Simplify the bundle plugin instructions

This fixes the following warning about unused Improt-Packages in Maven:
[INFO] ------< org.opencast.annotate:annotation-tool-frontend-delivery >-------
[INFO] Building Opencast Annotation Tool :: Backend :: Frontend Delivery 0-SNAPSHOT [6/7]
[INFO] -------------------------------[ bundle ]-------------------------------
[...]
[INFO] --- maven-bundle-plugin:3.5.0:bundle (default-bundle) @ annotation-tool-frontend-delivery ---
[WARNING] Bundle org.opencast.annotate:annotation-tool-frontend-delivery:bundle:0-SNAPSHOT : Unused Import-Package instructions: [org.opencastproject.*]

I also used the opportunity to remove some (by now) redundant explicit version specifications.

Does remove the warning, but also breaks my local OC 8.3 AllInOne.
Probably relevant part of the logs:
2021-05-03 09:18:49,008 | WARN  | (Util$OsgiLogger:205) - Error while starting bundle: file:/home/arnewilken/IdeaProjects/opencast/build/opencast-dist-develop-8.3/deploy/annotation-tool-impl-0-SNAPSHOT.jar
org.osgi.framework.BundleException: Unable to resolve annotation-tool-impl [65](R 65.5): missing requirement [annotation-tool-impl [65](R 65.5)] osgi.wiring.package; (&(osgi.wiring.package=javax.ws.rs)(version>=1.1.0)(!(version>=2.0.0))) Unresolved requirements: [[annotation-tool-impl [65](R 65.5)] osgi.wiring.package; (&(osgi.wiring.package=javax.ws.rs)(version>=1.1.0)(!(version>=2.0.0)))]
	at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4149) ~[?:?]
	at org.apache.felix.framework.Felix.startBundle(Felix.java:2119) ~[?:?]
	at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) ~[?:?]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundle(DirectoryWatcher.java:1260) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundles(DirectoryWatcher.java:1233) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startAllBundles(DirectoryWatcher.java:1221) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:515) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:365) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:316) [8:org.apache.felix.fileinstall:3.6.4]
2021-05-03 09:18:50,013 | INFO  | (Activator:43) - Stopped annotation tool
2021-05-03 09:18:50,055 | WARN  | (Util$OsgiLogger:205) - Error while starting bundle: file:/home/arnewilken/IdeaProjects/opencast/build/opencast-dist-develop-8.3/deploy/annotation-tool-impl-0-SNAPSHOT.jar
org.osgi.framework.BundleException: Unable to resolve annotation-tool-impl [65](R 65.5): missing requirement [annotation-tool-impl [65](R 65.5)] osgi.wiring.package; (&(osgi.wiring.package=javax.ws.rs)(version>=1.1.0)(!(version>=2.0.0))) Unresolved requirements: [[annotation-tool-impl [65](R 65.5)] osgi.wiring.package; (&(osgi.wiring.package=javax.ws.rs)(version>=1.1.0)(!(version>=2.0.0)))]
	at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4149) ~[?:?]
	at org.apache.felix.framework.Felix.startBundle(Felix.java:2119) ~[?:?]
	at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) ~[?:?]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundle(DirectoryWatcher.java:1260) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundles(DirectoryWatcher.java:1233) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startAllBundles(DirectoryWatcher.java:1221) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:515) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:365) [8:org.apache.felix.fileinstall:3.6.4]
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:316) [8:org.apache.felix.fileinstall:3.6.4]
2021-05-03 09:18:50,059 | INFO  | (Activator:38) - Starting annotation tool
2021-05-03 09:18:50,784 | WARN  | (ServletController:182) - Can't find the request for http://localhost:8080/admin-ng/event/events.json's Observer

Interesting. :thinking: Can you tryi n 9? That worked for me. If it's that, we can just wait a couple more weeks before merging this, since 8 support ends with the release of 10. :sweat_smile:

You're right, 9 is fine. RIP my beautiful OC 8.3 that I solely used for annotation-tool.

I mean you can still spend some time with it June 15th. ^_^

Opencast 8 is "deprecated" now, but there was a conflict with #499. @Arnei can you double check this for me when you get the chance? :)

Opencast 8 is "deprecated" now, but there was a conflict with #499. @Arnei can you double check this for me when you get the chance? :)

I did not get a conflict with #499.


[CNVS Upgrade] Convert white icons to neutral

mesosphere-ci retest this please

Error during Build Error: '../../node_modules/reactjs-components/lib/Dropdown/styles.less' wasn't found. :-(

@Poltergeist Sorry I didn't have this documented more clearly, but this PR requires the cnvs-upgrade/master branch be checked out for reactjs-components as well as the plugins repo. Tests won't pass until those branches have merged into master (or until CI can test plugins branches other than master).
I've added step-by-step instructions for testing this branch to the cnvs-upgrade/master PR: https://github.com/dcos/dcos-ui/pull/941

mesosphere-ci retest this please


Add a Zuul job for nightly bundles and index deploy

Adds a Zuul job definition to test the creation of an index image using pre build nightly bundles on OCP 4.14
Depends-On: https://github.com/infrawatch/service-telemetry-operator/pull/597

recheck

recheck

recheck

recheck

recheck

recheck

recheck


add option to disable recs updates

for hydrating from initial state

done in https://github.com/latticexyz/mud/pull/1661


Fix masterNode check in DefaultTemplateService

isMasterNode is true if a node is eligible to become master, it
doesn't indicate if it's the current master.

Codecov Report

Merging #5114 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #5114      +/-   ##
============================================
- Coverage     82.46%   82.41%   -0.05%
+ Complexity    11005    10989      -16
============================================
  Files          1331     1331
  Lines         45046    45047       +1
  Branches       5659     5660       +1
============================================
- Hits          37145    37126      -19
- Misses         5252     5266      +14
- Partials       2649     2655       +6

Impacted Files
Coverage Δ
Complexity Δ

...java/io/crate/metadata/DefaultTemplateService.java
91.83% <100%> (-4%)
9 <3> (ø)

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...exceptions/GroupByOnArrayUnsupportedException.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

...in/java/io/crate/data/CollectingBatchConsumer.java
69.23% <0%> (-15.39%)
4% <0%> (-1%)

...ration/collect/collectors/OrderedDocCollector.java
90% <0%> (-10%)
5% <0%> (-1%)

...transport/executionphases/ExecutionPhasesTask.java
83.33% <0%> (-8.34%)
21% <0%> (-3%)

.../java/io/crate/analyze/symbol/ParameterSymbol.java
87.5% <0%> (-6.25%)
6% <0%> (-1%)

.../java/io/crate/blob/TransportDeleteBlobAction.java
75% <0%> (-5%)
5% <0%> (-1%)

...ava/io/crate/jobs/AbstractExecutionSubContext.java
84% <0%> (-4%)
17% <0%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0cacf...8ca7a54. Read the comment docs.


[FEATURE] Document more details about the upgrade procedure

Is your feature request related to a problem? Please describe.
For troubleshooting the upgrade we need more technical details about the upgrade procedure.
Which POD is reacting on which annotation or CRD object in the process flow?
How can we push one or the other action to be restarted?
What should we do with which error situation?
Describe the solution you'd like
More insights, please.

Hi @Martin-Weiss , can you check if https://docs.harvesterhci.io/v1.1/upgrade/troubleshooting (in addition to https://docs.harvesterhci.io/v1.1/upgrade/v1-0-3-to-v1-1-1 ) meet your requirement?

https://github.com/harvester/harvester/issues/1926 will help as well.


Added functionality for searching company names

LGTM
Thank you for the PR. I'll be releasing a new version with this plus another couple small changes shortly.


Cant add collateral

Can't add collateral. Transaction failed. Reset wallet 3 times and same thing.

Same issue, using HW wallet Ledger Nano S

So do you have two wallet addresses now??
On Mon, 17 Jan 2022 at 16:08, PSYA Psychedelic Cardano Pool <
@.***> wrote:

Same issue, using HW wallet Ledger Nano S
—
Reply to this email directly, view it on GitHub
https://github.com/Berry-Pool/nami-wallet/issues/216#issuecomment-1014696287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXKMJ5IHQEYWO446PJMQXHLUWQ5HPANCNFSM5MBQM6YA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

how do you mean that?

Turned out to be Cardano network congestion. Will close this issue.


Fixes to evaluated branch and deployment links

Takes the good bits of #95 and makes sure the dev website is fixed now the evaluated branch is recovered.

In the end, this PR does these things:

Updated anaconda-project
Uses user_fields supported by this version of anaconda-project
Only installs holoviews for website building if it is not already available.
Use the new nbsite build to create the correct deployment links (original purpose of this PR)

@jbednar Ready to merge if you agree that the deployment links on  https://pyviz-dev.github.io/examples/ are now appropriate (all the ones I checked seemed fine to me)

The root cause has now been identified. Anaconda project 0.8.4 has a bug fixed in https://github.com/Anaconda-Platform/anaconda-project/pull/256 whenever user_fields was used. This means we will want to update anaconda-project once the next release is available (presumably 0.8.5?).

@jbednar The tests have now gone green again. I think this PR is ready to merge noting that the following issues still need to be tackled in subsequent PRs:

[ ] The opensky and gerrymandering projects had test failures when their anaconda-project.yml files had user_fields added. This will need to be investigated.
[ ] The user_fields field won't be respected till anaconda_project 0.8.5 is released and used in dodo.py.
[ ] There is still some issue around param pinning to get rid of the API deprecation warnings.

I think this PR is worth merging if only to get the deployment link fixes into master ASAP.


Add a foreach_thread_to_workgroup transform

This revision adds a transform dialect op that is very similar to foreach_thread_to_gpu to allow distributing to the first level of parallelism during codegen.
This is subject to conventions of what values are captured in the workgroup_count region and how these values are passed around in the stream.cmd.dispatch op.
For now the convention choosen is that 0 values are passed and the tile_to_foreach_thread may only use static sizes.
A followup PR will introduce a new transform dialect op to allow creating the sizes dynamically based on other conventions.

I still plan to do some cleanups, rewordings and renamings tomorrow but the mechanics are ready for review.
Where to put the test is also up for debate, I don't want to extend tests/transform_dialect forever but until we can transport transform IR down to the HAL level, we still need separate files.

If I can provide a suggestion:

You can read flow.dispatch.default_workgroup_count op as essentially compute flow.dispatch.workgroup_count_from_consumer_root op. The workload captured at the Flow level is the Range of the op that is tiled first (into which things are fused). I'll rename this anyway.
Totally agree we can have many different ops for different conventions for different use cases .

Thanks @MaheshRavishankar !
At this time, I think the combination wrap_in_dispatch_region + region_to_workgroups lives the workgroup_count region empty. I am not completely clear how one should populate this at the flow level and how that would connect to passing the right information to the stream dispatch call.
Pointers that would help solve that part would be very useful!
Once we have that, I can easily tweak this PR to avoid reconstructing the region and inline the  flow.dispatch.default_workgroup_count as the tile size during backend-specific codegen.
At that point I think I would still need guidance to find the IR that should replace flow.dispatch.default_workgroup_count after tiling to scf.foreach_thread and perform the proper constant propagations etc.
Please let us know if this line of thought makes sense of needs to be updated.

Thanks @MaheshRavishankar !
At this time, I think the combination wrap_in_dispatch_region + region_to_workgroups lives the workgroup_count region empty. I am not completely clear how one should populate this at the flow level and how that would connect to passing the right information to the stream dispatch call. Pointers that would help solve that part would be very useful!

It'd be good to decouple the flow level and codegen level to start with. Based on this RFC from Stella (https://groups.google.com/g/iree-discuss/c/Mz0ECZmWeTA) we should start with Transform dialect usage scoped within Codegen itself. So  we should decouple the way the workgroup_count region is handled and the way the dispatch region lowering proceeds. AFAICS, with a transformation driver these are two independent "transformations" that are all controlled by the driver which provides both of these with consistent information.
With that you can process the region you get from Flow today. You can assume that the number of operands to flow.dispatch.default_workgroup_count is same as the dimensionality of the tiled consumer (i.e the operation that is tiled first and into which all the other operations are tiled and fused). The value of the operands is (ub - lb)/step of the untiled operation. I am happy to make this more ergonomic, but these assumptions hold for today.

Once we have that, I can easily tweak this PR to avoid reconstructing the region and inline the flow.dispatch.default_workgroup_count as the tile size during backend-specific codegen.
At that point I think I would still need guidance to find the IR that should replace flow.dispatch.default_workgroup_count after tiling to scf.foreach_thread and perform the proper constant propagations etc.
Please let us know if this line of thought makes sense of needs to be updated.


[Question] Environment evaluation fails with KeyError: 'episode' in PPO training

When trying to run PPO training with my custom Bimanual_Allegro_Cube environment, evaluation fails with a KeyError indicating missing reward information in the info dictionary:
KeyError: 'episode'

When I run the command python ppo.py --env-id Bimanual_Allegro_Cube, the following error occurs:
Epoch: 1, global_step=0
Evaluating
Traceback (most recent call last):.07 hand_close: 0.15
  File "/home/creativenick/Desktop/SimToReal/bimanual-sapien/ppo.py", line 347, in <module>
    eval_infos["final_info"]["episode"]["r"][mask].cpu().numpy()
KeyError: 'episode'

This issue hasn't happened in the past which is why I'm unsure why it's happening now. I did recently update ManiSkill but I'm not sure if that's actually the cause of this error. Here's the code snippet in my ppo.py file for which the error is referring to:
...
  if "final_info" in eval_infos:
      mask = eval_infos["_final_info"]
      eps_lens.append(
          eval_infos["final_info"]["elapsed_steps"][mask]
          .cpu()
          .numpy()
      )
      returns.append(
          eval_infos["final_info"]["episode"]["r"][mask].cpu().numpy()
      )
      if "success" in eval_infos:
          successes.append(
              eval_infos["final_info"]["success"][mask].cpu().numpy()
          )
      if "fail" in eval_infos:
          failures.append(
              eval_infos["final_info"]["fail"][mask].cpu().numpy()
          )
...

The environment should properly structure reward information in the info dictionary during evaluation and the info dictionary should contain final_info with an episode key containing reward information. I'm not sure if the reward information may not be properly propagated through the environment wrappers.

Update: I have fixed the issue, had to adjust some initialization parameters and the evaluate function.


[Relay][Frontend][Onnx] Compare against onnxruntime more consistently during testing

I noticed that many of our onnx frontend tests compare to results produced by numpy rather than onnx itself. This is somewhat counterproductive because it makes assumptions about what onnx should do rather than checking what it actually does. I decided to go through all the tests in test_forward.py and make them use the new verify_with_ort helper function. This makes our testing suite more consistent and align more closely with their intention. In the process of making this conversion, I discovered many bugs with the importer that are also fixed in this PR. Although this PR might be a little painful to review due to its scope, I think that the result is an overall much cleaner and easier to maintain test suite.

@masahi @mbrookhart can you guys let me know what you think of this PR?

@masahi @mbrookhart can you guys let me know what you think of this PR?


It's yiddish for a certain body part


#12271: ban possibly slow Random methods

Just ban these possibly slow Random APIs.

Woops -- I messed up the actual forbidden APIs -- working on correct fix (we do use this API in many places!).


Glider Speed (3x) doesn't do anything

Is there a key that I need to press or hold? This doesn't seem to do anything (for the Switch)
[#22c Glider Speed (3x)]
040E0000 01D708EC D503201F
040E0000 01D70908 1E211002

I reverted it to older code


Rekey all vaulted files with new vault password (thanks, lastpass)

generated a new vault password and updated the secure note in LastPass
rekeyed all vaulted files with the new vault password (thanks to PUL for figuring out the syntax: ansible-vault rekey --ask-vault-password $(grep -Frl '$ANSIBLE_VAULT;'))

Please confirm you can decrypt vaulted files with the new password (no need to check all, just checking a few should be sufficient)

No, I did not update my password. And woops yeah I mispelt revault.

ok, second try!
I've updated to follow PUL approach, using lastpass cli and lastpass-ansible. Their setup instructions are here:
https://github.com/pulibrary/princeton_ansible#automatically-pull-vault-password-from-lastpass
We probably should add some of this documentation to our readme, but I'm not sure how much. Input appreciated!
The new vault password is in lastpass, so if you follow the install instructions at the link above, then you ought to be able to do ansible-vault edit ... on one of our vaulted files to confirm you can decrypt; to double-check, you can also do the same thing with ansible-vault edit --ask-vault-password and enter the password manually from lastpass.


Added report command and option to reset warns every round

reset warns after every round is a bad idea

Read the title; it's an option and it's disabled by default. I know that some people might want this so I added it. It literally took 6 lines of code


feat: include function signatures in rpc cli autocompletions

Adds function signatures (excluding input context field, and output error field) to the RPC CLI autocompletions. Now the autocompletions for the methods looks like this:

Codecov Report

Merging #2026 (0a7d9d4) into main (f480a8f) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
- Coverage   54.49%   54.39%   -0.10%
==========================================
  Files         216      216
  Lines       14078    14094      +16
==========================================
- Hits         7672     7667       -5
- Misses       5588     5605      +17
- Partials      818      822       +4

Impacted Files
Coverage Δ

cmd/celestia/rpc.go
6.51% <0.00%> (-0.53%)
:arrow_down:

... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add copy keyword argument to QuantumCircuit.append

Summary
We always copy compile-time parametric instructions during QuantumCircuit.append to avoid accidental mutation of other references in a call to assign_parameters(inplace=True).  However, mostly our rotation gates are added through things like QuantumCircuit.rz, where the only reference to the RZGate is internal to the QuantumCircuit, so creating and immediately copying it is a waste of time.
This commit adds a copy argument to QuantumCircuit.append, so we can set it to False in places where we know we own the instruction being added.

Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

61 of 63 (96.83%)  changed or added relevant lines in 3 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 89.414%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/circuit/quantumcircuit.py
58
60
96.67%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
5
93.13%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
59921

Relevant Lines:
67015

💛  - Coveralls

Yeah, exactly:
from qiskit.circuit import Parameter, QuantumCircuit
from qiskit.circuit.library import RZGate

a = Parameter("a")
qc = QuantumCircuit(1)

gate = RZGate(a)
qc.append(gate, [0], [])
assert qc.data[-1].operation is not gate, "parameter"
gate = RZGate(a + 0)
qc.append(gate, [0], [])
assert qc.data[-1].operation is not gate, "expression"

---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
Cell In[50], line 13
     11 gate = RZGate(a + 0)
     12 qc.append(gate, [0], [])
---> 13 assert qc.data[-1].operation is not gate, "expression"

AssertionError: expression

Also yeah, the biggest improvement here is actually in the construction of any parametric circuit using the convenience alias methods on QuantumCircuit like .rz - before these, those methods would copy despite having only just constructed the only reference to the gate just a line or two above, and that drop that reference again immediately.


Add missing type prefix for enums

This PR adds the missing type prefix on enums when an enum variant is used as the account discriminator.
This avoids generating duplicated imports – e.g.,:
import { Key, getKeyDecoder, getKeyEncoder, type Key } from '../types';

Hmm in this case I think we need the enum but not as a type. Because we're renderer MyEnum.myVariant so we need more than the type.
I think we should add a post-processing step on the ImportMap when outputting it as a string such that if X and type X are imported, it only imports X.


Split by HP tag including unphased reads? [Feature request]

For the purposes of easily viewing coverage across the haplotypes, I split my longranger bams by haplotype. bxtools can create bam files for phased reads - is it possible to also output the unphased reads when -t HP is used? Something like an option to output to a single BAM file all the reads that don't match the specified tag would be great.

Do you mean reads with no HP tag? I can include that in the next update. In the meantime, a two-pass solution using grep + samtools to get these would also work.

Yes, that's what I mean - reads with no HP tag. I'm currently using the samtools + grep solution, but bxtools is definitely faster.

Thank you for your patience with this.
I just pushed an update to bxtools split that allows for a -e flag to output a BAM with the reads without the specified tag.

Will close for now, but re-open if you have issues. On my tests this works well.

Thank you for your fantastic tool.
Unfortunately, bxtools split -e doesn't work for me!


Link to Stripe billing / account sections

Allows a user to see their Stripe billing history or Account history from either of the Payment Methods page and the Bank Accounts page

I think this needs some translations added, but otherwise is good to go.

How do you want to address removing "Congratulations" from the copy since the translations will need to be changed as well?

Probably fine to leave for now...

This will also probably have conflicts with Rafael's PR, but we'll see.


Replace Gulp with Fly

Fly and Gulp4 have very similar goals; but Fly is already out of beta, faster, lighter, and more performant. Next.js has already made the switch! 🎉
I also added fly-esnext, which allows for the async/await flavor.

Gulp
Fly

Total Dependencies
662
590

Time: build
840ms
734ms

Memory: start
43.8MB
38.2MB

Slight Changes:

Sourcemaps are created as siblings to their source files
Builds triggered by watcher are slightly slower (17ms vs 26ms); can be easily fixed with a fly-changed plugin (TBD)

I'll totally understand if you choose not to migrate away from Gulp; or if you'd prefer to wait for the plugin before considering.

Cool! I don't have any immediate objection to using fly, although I'm not familiar with the project. Could you link me to some information about what fly is?
Also, could you run yarn && yarn run format in the root repo directory?

Hey, no worries! It's been around for over a year, but only recently came into its 2.0 form.
Here's the README, which explains the entire project & its mechanics pretty well in ~10 minutes. Let me know if you have questions.
I also ran the format command. Ran it again locally to check & there were no changes.

Cool! It's on my list to take a look at when a little bit of the issue churn slows down. It looks like the fly scripts are using tabs, but prettier should have reformatted them to spaces.

Ah, gotcha. It's because you have {src,template} included in your glob. I'll just transform to spaces so you don't have to evolve a slightly more complicated glob. Plus I'm not sure if you can even use multiple glob patterns & ignores with prettier yet. 🤔

I'm trying this out, and it looks like fly needs to be called from package.json scripts to work with the async/await flavor:
$ fly babel
/Users/adam/code/flycrna/create-react-native-app/flyfile.js:9
export default async function (fly) {
^^^^^^
SyntaxError: Unexpected token export
    at new Fly (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/lib/fly.js:21:39)
    at Object.<anonymous> (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/lib/cli/spawn.js:35:9)
    at Generator.next (<anonymous>)
    at Generator.tryCatcher (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/node_modules/bluebird/js/release/util.js:16:23)
    at PromiseSpawn._promiseFulfilled (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/node_modules/bluebird/js/release/generators.js:97:49)
    at Promise._settlePromise (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/node_modules/bluebird/js/release/promise.js:574:26)
    at Promise._settlePromise0 (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/node_modules/bluebird/js/release/promise.js:693:18)
    at Async._drainQueue (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/Users/adam/.nvm/versions/node/v7.7.1/lib/node_modules/fly/node_modules/bluebird/js/release/async.js:17:14)

Can you add the scripts to package.json so that all commands are available via npm run/yarn?

Okay. Right now you can do that by running npm start babel simply because it's passing all task names thru that fly bin reference.
Of course, that's not ideal. But I matched the existing Gulp configuration, which only had start paired to gulp.

Ah fair enough. Cool, I can tweak as needed then.

Cool! Let me know if you have any questions while tweaking. More than happy to help!
Also, just missed the mark. Just pushed a commit for removing gulp-shell 😅

All good! Figured I was going to tinker a bit anyways 😃


Custom ranges

I'd like to be able to select a range of cells from a fixed top-left and supply the right-most column, but not the number of rows e.g.
Instead of A2:B99 I would like to be able to simply do A2:B and get all cells until the end of the table. Is this possible?

I'd like this also. I have existing code that does this with Linq and OpenXML in VB.NET, but wanting to transfer to F#. The problem this solves is skipping the overarching header above the data table.

Would like to add in case anyone comes and reads this, that using say Range = "A2", does make it so that the table is read starting at A2, it isn't exactly the same as the A2:B example, since it would still read data to the right of column B, but it does mean that it reads data starting from A2.


Usage of ClassName in Mappings section of discriminator

Problem description
As many Json frameworks use simple class names as JsonTypeName, we suggest adding a recommendation to use these class names as mapping keys. This will also serve as a workaround for openapi generators that do not properly handle the JsonTypeName of the derived class when the mappings section is present (this problem occurs on client side only) .
Expected action
New PR describing this recommandation
Additional context

@patrice-conil Could you provide example to illustrate the issue for non-developers? :wink:

Hi @rartych,
For example, in QoD we have
discriminator:
propertyName: eventType
mapping:
QOS_STATUS_CHANGED: "#/components/schemas/QosStatusChangedEvent"
But the class name (object name) of the event is QosStatusChangedEvent. If we define discriminator this way, everything works perfectly
discriminator:
propertyName: eventType
mapping:
QosStatusChangedEvent: "#/components/schemas/QosStatusChangedEvent"
This definition is equivalent to discriminator defined without mapping section.

No objections raised in meeting held on 7th September

No objections from my side.

@patrice-conil Could you start PR for this issue?

Hope to have time do it this week


Couldn't find class 'I32BitEnumAttrCase'

I have a problem about iree as follows when I install it:

The recent LLVM integration replaced BitEnumAttr with I32BitEnumAttr. Please make sure you update git submodules; that would update the repo to track the proper LLVM/MLIR project commit.

Nothing actionable additionally. Closing.


Fix hangs during failed authentication.

Validate credential parameters.
Don't retry on http.StatusUnauthorized.
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:

[ ] I've tested my changes, adding unit tests if applicable.
[ ] I've added Apache 2.0 Headers to the top of any new source files.
[ ] I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
[ ] If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

Fix for issue https://github.com/Azure/azure-sdk-for-go/issues/870.


Output containing 'current' (last?) phase

Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like
I would like the output message (payload) to contain the 'current' (or last, depending on how you look at it) solar phase. So it would contain something like:
"lastPosition: sunRise" (when the sun is between 'sunRise' and 'sunRiseEnd'), or
"lastPosition: "civilDusk" (when the sun is between 'civilDusk' and 'blueHourDuskEnd')
Describe alternatives you've considered
I have looked into making a number of flows and doing the above manually based upon the times provides. This is tedious to set up :-)
Additional context
The purpose of my request lies in usage with (for example) Home Assistant.
My idea is, that if I switch on a light, that depending on the 'current' (or last) solar state, it turns on the light at a specific luminance and/or colour temperature.
(so when I click the 'on' button for a light in the middle of the night, it will automatically turn on at a very low luminance and high colour temperature, and when I turn on that light during the day, it turns on at a higher luminance and lower colour temperature)

I'm not sure what else to implement here. There is already the possibility to output the last and the next position of the sun. This is even possible with every change:

here the english settings:

The next sun time is misleading, for the payload. There an object with next and last is given:

Is this what you looking for?

Hi,
First off, thank you for your quick responses!
Yes and no :)
I am looking for what is called 'last' in the output, but rather than having to trigger it via "Inject Enhanced", I would like to be able to get the 'last' value when via another trigger.
So for example:
<All Zwave>  -> <which zwave device> -> <which button> -> <button 1> -> <last suntime> ->

  <if last suntime is solarNoon, turn on light and then set brightness to 400> or
  <if last suntime is nadir, turn on the light and set brightness to 100>

(etc)
or something similar.
My initial idea was to have it added to the 'Sun position' node (and for completeness also the 'Moon position' node, though I don't have any personal use for that, but to keep them simular of course)

This is possible by using the time compare and change node and configuring it as follows:

In this case the node only acts like a change node.

Hi,
If I select 'timestamp' as input (as my zwave-buttons send out all kinds of info, but not a regular timestamp) and just don't compare it, it outputs the 'last suntime', so I can work with that. Thanks 👍


Showcasing how a Gradle plugin may look

Feel free to use this as a starting point. 😃

Thank you so much!


Add new docs demo: Ultimo Docs

http://docs.ultimogroup.co.nz/
I've set up the documentation pages to use daux.io, would like to request to be added to the demo list. The landing page however does not use daux.io.

Added, will be put in production shortly


fix usage of arm64 regs according to CC

Some int registers and fp registers were overwritten being caller-save. Made the generated asm to follow arm64 calling convention.

Changes made in tinygrad/:
------------------------------------------------------------
files                             insertions       deletions
------------------------------------------------------------
tinygrad/codegen/assembly_arm64.py         6               6
------------------------------------------------------------
lines added in the tinygrad folder: 0

Is there a test that could catch this regression?


Implement FAQ on /cody/subscription page

@chenkc805, do you still plan on adding this? Do you need any help?

Yes I'd like to add this, it can just be a duplicate of the FAQ we currently have on the cody pricing page: https://sourcegraph.com/pricing

@chenkc805, what's needed here? I guess the copy is done, so is this eng work? Or is it design work?
I guess this could be a P1, helping users be less lost seems to be pretty important at this point.

I'm still not seeing any FAQs at the bottom of the /cody/subscription page. Not a launch blocker for today but would like to get this in before 2/21.

@chenkc805, this task is currently assigned to you. It seems like you need engineering help on this then? Shall I reassign it to one of us engs?

yes please, can you assign to whoever is the right person to work on this? Thanks!


Using RequeueAfter in Reconcile requeues immediately

Bug Report

What did you do?
I tried to add a five second delay here
What did you expect to see?
I expected to see changes made my the Reconciler to persist for about five seconds before moving to the next iteration of the reconciler.
What did you see instead? Under which circumstances?
I get immediate run of the next iteration of the Reconciler method despite the delay.
Environment

operator-sdk version:
Side note:
This may be a "good first issue" RFE, to ensure version works as a command like most other k8s binaries.

10:06 $ operator-sdk version
Error: unknown command "version" for "operator-sdk"
Run 'operator-sdk --help' for usage.
10:06 $ operator-sdk --version
operator-sdk version v0.5.0+git

Kubernetes version information:
Minikube with:

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.3", GitCommit:"721bfa751924da8d1680787490c54b9179b1fed0", GitTreeState:"clean", BuildDate:"2019-02-01T20:08:12Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.3", GitCommit:"721bfa751924da8d1680787490c54b9179b1fed0", GitTreeState:"clean", BuildDate:"2019-02-01T20:00:57Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:

minikube in VBox

Are you writing your operator in ansible, helm, or go?

go
Possible Solution

Additional context
The old fashioned method, inserting time.Sleep(duration) works as expected.

@cwilkers Depending on the reconcile.Result and error returned by your Reconciler the controller will decided whether or not to enqueue the key for your CR so it is processed again.
https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/internal/controller/controller.go#L215-L229
With RequeueAfter you can control the delay with which the key is added for your CR.
However there is another eventhandler enqueuing keys for your CR to the controller's queue as well.
That is spawned from the secondary Watch for the Deployments that you have set for the controller.
https://github.com/cwilkers/useless-operator/blob/master/pkg/controller/useless/useless_controller.go#L55-L58
So when you update the Deployment in your reconcile loop that will result in the EnqueueRequestForOwner  eventhandler from your secondary watch to receive an Update event for that Deployment, and that in turn adds the key for your CR to the controller's queue.
So with RequeueAfter you can't delay the keys(events) that are added to your controller's queue from other sources. (@shawn-hurley Just want to double check that I'm not wrong on this)
time.Sleep() works to delay the processing of keys the controller won't process any other keys added to queue for your CR while it is blocked processing the current key in your reconcile loop.
I'm curious about why you would want to delay your reconcile loop in this manner though.
RequeueAfter is usually meant for periodically re-triggering the reconcile loop in the case where you can't watch for resources that are related to your CR, or for introducing a delay when processing errors and to avoid going into a hot-loop.
In your case of successfully updating a secondary resource(Deployment) that your are watching your reconcile loop should be able reconcile again without any delays by fetching the latest version of that resource.

I see what you mean; I took all the requeueing out of my controller, and the secondary watch alone seems to be forcing each iteration along as soon as possible.
Since my operator is just a toy demo (thus the "useless machine" concept) I was hoping to slow it down so observers could see the steps it performs in order. In this case, I can use the sleep function to effectively slow the execution down in a serial manner.
Thanks for clarifying what was going on!


Broken-but-continuing state possible after droppage of client param in 3f73fcec

Not sure if I'm a rare user affected by this due to my stability reqs spanning into the years, but I wanted to drop a quick note that anyone who didn't catch the removal of the client param in the commit above (presumably replaced by httpProxy going by publicIP) will get weird silently failing behavior due to the options param being passed second. Example in my case being a schrodinger's data dir and somehow managing to auth but none of the web stuff working.
If the user doesn't do an explicit check on publicIP for proxy presence this could present a data leak and odd backwards behavior.
Beyond that though, neat cleanups. Literally years and my porting footprint was 18 lines. :D
Versions
All after commit in subject

I'd recommend just noting in the ctor section that after [release following that commit] this arg was removed. I scanned the README to check that I didn't miss any breaking changes and likely would have noticed an advisory similar to your vX.Y.Z or later ones

The full list of breaking changes is noted in the v4 release notes.


AttributeDict construction

The constructor, via AttributeDict.add_entries, ignores null values, causing tests for AttributeDict to fail when None is the value in the mapping that's the argument to the constructor.

So this means if an entry key has a null value, the attribute will not be added to the AttributeDict; not that it will be added but with a null value...

We talked a bit about this yesterday @nsheff , but I don't think that we reached a decision. Should null values continue to be ignored since this is a special data type, or is the preference to make it more like builtin dict and allow nulls? What do you think @afrendeiro ?

I think probably null values should be added and allowed...

Sounds good!


Update run_instance.rb

fixes error reported on inspection

Coverage remained the same at 84.58% when pulling 435b4052243718ed34b6306979d5fbc735654823 on fix-error into 8498fc19f5b8638aa0cee037248c28fd41a59a0b on master.

Coverage remained the same at 84.58% when pulling c30884188a88dd5339b9a7fdab74f6daa4834ec1 on fix-error into 8498fc19f5b8638aa0cee037248c28fd41a59a0b on master.

:+1:


There's no example project for CoreData+iCloud and document is wrong

The document code is wrong, there is no NSBundle on Swift 3, it's Bundle
CoreData.ObjectModel.Merged([bundle]) ~> wrong syntax too. It might be CoreDataObjectModel.merged([bundle])
And the last: there's no iCloudConfig method, i've found on the example project, and found nothing.

Hey @Tom29, thanks for reporting it. I've updated the README.md with the new syntax. You can check the changes here: https://github.com/carambalabs/SugarRecord/commit/214f34f9dc4eafd525af9a9cec5d5c6851bb0149


GRO-539: Redirect for /artworks to /collect

GRO-539 This is to set up a redirect for /artworks to /collect

🚢


CLOUDSTACK-10190:Duplicate public VLAN for two different admin accounts.

ISSUE :
Duplicate public VLAN for two different admin accounts.
STEPS TO REPRODUCE :

Start multiple threads for executing createVlanIpRange API.
Make sure multiple threads run in parallel.
Verify vlan table in DB, duplicate entry for same VLAN and IP address range will be encountered, just id and uuid will be different, rest all fields will have similar value.
Following entry will be observed in vlan table :
`mysql> select * from vlan where vlan_id like 'vlan://77' and removed is null;
+----+--------------------------------------+-----------+--------------+-----------------+---------------------------+----------------+----------------+------------+---------------------+-------------+----------+-----------+---------+---------------------+
| id | uuid                                 | vlan_id   | vlan_gateway | vlan_netmask    | description               | vlan_type      | data_center_id | network_id | physical_network_id | ip6_gateway | ip6_cidr | ip6_range | removed | created             |
+----+--------------------------------------+-----------+--------------+-----------------+---------------------------+----------------+----------------+------------+---------------------+-------------+----------+-----------+---------+---------------------+
| 15 | 6a205b78-d162-43e3-8da9-86a3ff60f40e | vlan://77 | <IP_ADDRESS> | <IP_ADDRESS> | <IP_ADDRESS>-<IP_ADDRESS> | VirtualNetwork |              1 |        200 |                 200 | NULL        | NULL     | NULL      | NULL    | 2017-12-13 12:55:51 |

| 17 | ff8b5175-b247-45a5-b8d3-feb6a1ca64d0 | vlan://77 | <IP_ADDRESS> | <IP_ADDRESS> | <IP_ADDRESS>-<IP_ADDRESS> | VirtualNetwork |              1 |        200 |                 200 | NULL        | NULL     | NULL      | NULL    | 2017-12-13 12:55:51 |
+----+--------------------------------------+-----------+--------------+-----------------+---------------------------+----------------+----------------+------------+---------------------+-------------+----------+-----------+---------+---------------------+
`

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1390

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1807)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31546 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2361-t1807-kvm-centos7.zip
Test completed. Failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_vpc_privategw_acl
Failure
61.79
test_privategw_acl.py

test_02_vpc_privategw_static_routes
Failure
173.22
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
178.09
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
278.84
test_privategw_acl.py

test_02_create_template_with_checksum_sha1
Error
5.23
test_templates.py

test_03_create_template_with_checksum_sha256
Error
5.22
test_templates.py

test_04_create_template_with_checksum_md5
Error
5.22
test_templates.py

test_01_vpc_remote_access_vpn
Failure
71.03
test_vpc_vpn.py

test_hostha_kvm_host_degraded
Error
25.86
test_hostha_kvm.py

test_hostha_kvm_host_fencing
Error
1262.39
test_hostha_kvm.py

Test Cases which are failing are not related to these changes.

Test LGTM, ignoring known failures. Additional review requested.

Code LGTM

@rhtyd : Can you please merge this PR as code LGTM is given by @mrunalinikankariya ?

Merging based on code review and test results.


Request: font-awesome 4.4 update

Please update library with new font-awesome 4.4.0.
Thanks!

hi, the lib now ships the latest fontawesome ( 4.4.0 ) , i also updated the pypi package.


Can't use none value to override defaults

The EditorConfig spec declares that none is an acceptable value for any EditorConfig property, disabling a rule for the given file pattern(s):
https://github.com/editorconfig/editorconfig/issues/379#issuecomment-437697328
However, eclint does not appear to support this, causing spurious warnings in my projects:
$(npm bin)/eclint check examples/hello.bat
examples/hello.bat
    01:01 ❌ invalid charset: utf-16be, expected: none
                                           (EditorConfig charset https://goo.gl/hK94EO)

Please allow any and all rules to be disabled, by matching on a property value of none, per the spec, so that users can have fine grained control over how they configure EditorConfig for their projects.
eclint already does 99% of this, using a proprietary value unset to disable rules. We should adopt the name none for this, to match the EditorConfig standard, and perhaps continue supporting unset as an alias for a while, to maintain backwards compatibility with old eclint for a while.

ECLint uses the editorconfig-core-js under the hood, so that's where you should file the issue.


Feature Request: Test deployment on templatereadme.org

readme.so is on Vercel.
https://render.com/docs/deploy-nextjs-app
https://nascentdigital.com/thoughts/how-to-deploy-next-js-without-vercel


Improvement on the inviting parent organization API

Is your suggestion related to an experience ? Please describe.
The inviting parent organization API resource doesn't have an endpoint to retrieve the invitation by its invitation id. Only list all the invitation API is available.

Describe the improvement

When introducing front end improvement with role assignements when inviting a user from the parent organization, this API may required, hence better to include the API to retrieve the invitation by its id.
And with the support of RoleV2 in role assignments in parent user invite flow, change the model to provide the role details with its audience details. As of now the the list all the user invitations will provide the response as follow and this may be improved to list the role with the reference location to the /guests/invitations/{invitationId}

{
    "invitations": [
        {
            "id": "51310724-b33c-4b8c-a805-41580765a9d2",
            "username": "alex",
            "email"<EMAIL_ADDRESS>            "roles": [
                {
                    "displayName": "testrole",
                    "id": "d3ffa7cf-a4d9-4dc7-b0a1-cdd2c6a6ab84",
                    "audience": [
                        {
                            "value": "c139b9ef-79a4-4402-af1c-27406aeab5ff",
                            "display": "app2",
                            "type": "application"
                        }
                    ]
                }
            ],
            "status": "PENDING",
            "expiredAt": "2023-11-16 09:37:36.0"
        },
        {
            "id": "5f32d028-8c5d-451d-8dec-0b2d29fabf1f",
            "username": "bob",
            "email"<EMAIL_ADDRESS>            "roles": [
                {
                    "displayName": "testrole",
                    "id": "d3ffa7cf-a4d9-4dc7-b0a1-cdd2c6a6ab84",
                    "audience": [
                        {
                            "value": "c139b9ef-79a4-4402-af1c-27406aeab5ff",
                            "display": "app2",
                            "type": "application"
                        }
                    ]
                }
            ],
            "status": "PENDING",
            "expiredAt": "2023-11-17 05:20:26.0"
        }
    ]
}

Additional context

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Can't Switch Layer on Bobba Gateway

Browser: Brave
Wallet: Metamask with Nano Ledger Hardware Wallet
Issue:
Trying to switch layer results in nothing happening an error in dev console when trying to switch layer on the gateway.
inpage.js:1 MetaMask - RPC Error: The method 'wallet_switchEthereumChain' does not exist / is not available.
inpage.js:1 MetaMask - RPC Error: The method 'wallet_switchEthereumChain' does not exist / is not available. {code: -32601, message: "The method 'wallet_switchEthereumChain' does not exist / is not available.", data: {…}}
main.879918c4.chunk.js:1 MetaMask - Switch Error:  -32601

This works on chrome but not Brave. But now I can't approve transactions on MetaMask in chrome when trying to stake or bridge back to L1. Even though I have deposited ETH.

For anyone else having this issue you can have a workaround by adding the mainnet details in the wallet extension manually using the details from here https://docs.boba.network/developer-docs/006_parameters-mainnet then switching from the Eth main net to the Bobba main net in the wallet extension.

I am also having the same issue with tansfering from L1 to L2 to claim the airdrop.  I am using XDEFI extension and cannot seem to add a mainnet to it like you can quite easily in Metamask so this isn't a workaround for me.  Having said that, why can't I we transition easily between layers?  It doesn't look like anyone is working on this issue since you posted it.


The screen closes automatically after opening

Hello, after upgrading to 0.7.0, in cases where after closing the sheet and opening the screen in the stack it began to close itself, on version 0.6.4 this problem is not observed
import SwiftUI
import FlowStacks

enum Path: Hashable {
    case sport(Int, FirstCoordinator)
    case challenge(String, FirstCoordinator)
}

class FirstCoordinator: ObservableObject {
    @Published var path: Routes<Path> = []

    func presentSheet() {
        path.presentSheet(.sport(1, self))
    }

    func closeSheetAndPush() {
        path.goBack()
        path.push(.challenge("1", self))
    }

    func goBackToRoot() {
        path.goBackToRoot()
    }
}

struct ContentView: View {
    @ObservedObject var coordinator: FirstCoordinator

    var body: some View {
        FlowStack($coordinator.path, withNavigation: true) {
            VStack {
                Button {
                    coordinator.presentSheet()
                } label: {
                    Text("Present Sheet")
                }
            }
            .navigationTitle("ROOT")
            .flowDestination(for: Path.self) { screen in
                switch screen {
                case let .sport(value, coordinator):
                    SportView(coordinator: coordinator, value: value)
                case let .challenge(value, coordinator):
                    ChallengeView(coordinator: coordinator, value: value)
                }
            }
        }
    }
}

extension FirstCoordinator: Identifiable, Hashable, Equatable {
    static func == (lhs: FirstCoordinator, rhs: FirstCoordinator) -> Bool {
        lhs.id == rhs.id
    }

    func hash(into hasher: inout Hasher) {
        hasher.combine(id)
    }
}

struct SportView: View {
    @ObservedObject var coordinator: FirstCoordinator

    let value: Int

    var body: some View {
        VStack {
            Button {
                coordinator.closeSheetAndPush()
            } label: {
                Text("push")
            }
            Text(value.description)
        }
        .navigationTitle("Sport")
    }
}

struct ChallengeView: View {
    @ObservedObject var coordinator: FirstCoordinator

    let value: String

    var body: some View {
        VStack {
            Text(value)
            Button {
                coordinator.goBackToRoot()
            } label: {
                Text("goBackToRoot")
            }
        }
        .navigationTitle("Challenge")
    }
}

https://github.com/user-attachments/assets/77a87211-3a4d-468a-a34c-58d025f9fb1e

Thanks for raising this issue @lisindima!
I think this change fixes it:
https://github.com/johnpatrickmorgan/FlowStacks/compare/bugfix%2Fissue-82
I'll just need to do some more testing before I can merge this fix.

Yes, that solved the problem.

Released as v0.8.2. Thanks @lisindima !


[FLINK-10353][kafka] Support change of transactional semantics in Kaf…

…ka Producer with existing state
What is the purpose of the change
This PR changes FlinkKafkaProducer and  FlinkKafkaProducer011 to support a change of transactional semantics when restoring from existing state, e.g. a savepoint.
Brief change log

Introduced KafkaTransactionState#isTransactional to distinguish which transactional handling should be applied instead of relying on what is currently configured.

Call initializeUserContext in TwoPhaseCommitSinkFunction for all cases that did not recover a user context.

Consider removing tranactional id from the properties when creating a new producer to deactivate transactional semantics if no longer required.

Verifying this change
Added FlinkKafkaProducer(11)ITCase#testMigrateFromAtLeastOnceToExactlyOnce and #testMigrateFromAtExactlyOnceToAtLeastOnce
I wonder if we should also add tests from/to the NONE semantics. The tests are pretty heavy weight for what they are doing.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Addressed the comments. Please have another look.

Thanks for the review @pnowojski. I will keep the hotfix commit separated. Merging.


For a 0.18.1 release

[x] Suppress P <: Real check for the type of probabilities in UnivariateFinite.  In this way also allow "probabilities" of NaN, Inf, or -Inf, to address #525 (PR #531)
[x] Extend compatibility requirements to support MLJModelInterface 1.0 and StatisticalTraits 1.0 (which are essentially identical to previous versions)

Codecov Report

Merging #536 (7781275) into master (10bf820) will decrease coverage by 1.29%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   86.16%   84.87%   -1.30%
==========================================
  Files          36       36
  Lines        3065     3034      -31
==========================================
- Hits         2641     2575      -66
- Misses        424      459      +35

Impacted Files
Coverage Δ

src/composition/models/pipelines.jl
98.57% <ø> (ø)

src/univariate_finite/methods.jl
86.36% <33.33%> (+1.28%)
:arrow_up:

src/univariate_finite/types.jl
90.65% <85.71%> (-2.93%)
:arrow_down:

src/measures/meta_utilities.jl
30.00% <0.00%> (-68.37%)
:arrow_down:

src/measures/loss_functions_interface.jl
80.95% <0.00%> (-16.67%)
:arrow_down:

src/interface/data_utils.jl
94.44% <0.00%> (-0.11%)
:arrow_down:

src/measures/finite.jl
96.60% <0.00%> (-0.01%)
:arrow_down:

src/MLJBase.jl
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10bf820...7781275. Read the comment docs.


Moderators have to click Save/Edit resource twice to go to right pages

Describe the bug
In RC, when moderating items, if moderators are editing an item, they will have to click Save twice in order to view the right page.
Please note this bug was fixed before in PR #781
@SammyIsConfused may be more familiar with this issue.
To Reproduce
Steps to reproduce the behavior:

Select a task to moderate
Click on Edit resource
Make changes on the item
Click on Save

Expected behavior
The Save button should disappear and another four buttons should come up
Screenshots

Stacktrace
None
Platform:

OpenEquella Version: 2019.1
OS: Ubuntu 18.04
Browser Chrome

Additional context
Add any other context about the problem here.

Fixed


Add ClaimTips page

closes #199
I did not find any designs, so I decided to make it as simple as possible:

I'll ask designers to prepare a design
Can you also fix that text in the scope of this:
No zero amount claims
It should be something like "No new tips to claim" or "Nothing to claim yet"

I'll ask designers to prepare a design
Can you also fix that text in the scope of this:
No zero amount claims
It should be something like "No new tips to claim" or "Nothing to claim yet"

This can be fixed in a separate PR, when adjusting texts. Lets not hold the functionality further just because of text string.


error: Selector can not specify both 'start' and 'end' key when specifying 'prefix'" when use getMany

enviroment: bun 1.1.38 macos 15
i find that it cause by handlemany->createSelector
because denokv will check selector and forbidden use start ,end, prefix at the same time even if undefined
https://github.com/denoland/denokv/blob/a9eb782be66477b32e96a692c8c34f807ad10bcd/npm/src/kv_util.ts#L115

Weird quirk, but nicely done figuring it out! The change you made makes sense to me, if you care to make a PR I will gladly accept it :)

yes,i make a pr (#252 change the fn createListSelector) and test in deno(i don't how to test in bun)  although i think this is a problem with denokv, i can avoid it by modifying kvdex.
If you could merge this PR, I would be very grateful.

Closing this now as your fix has been merged and released as of 3.0.2. Thanks!


Route on file browser navigation

Fixes #15

Thanks!
Does this also handle updating the URL when navigating folders, like in the classic notebook?
https://user-images.githubusercontent.com/591645/131683675-703bdbd1-184f-48ce-9e94-6020ab27c557.mp4

I'm unsure the error is relevant as it happens only on Chromium. Did you encounter random failure in the past?

I'm unsure the error is relevant as it happens only on Chromium. Did you encounter random failure in the past?

Not yet. Will restart the check to be sure.

Thanks for the update. Looks like it's almost ready to go.
When checking on Binder the base url gets appended once on first navigation:
https://user-images.githubusercontent.com/591645/131701935-403c91e9-66df-450b-8752-683aed686782.mp4

0.3.3 is out: https://pypi.org/project/retrolab/0.3.3/


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter uv-protect for common errors and appropiate suggestions to keep this adapter up to date.
Please see the result of the check below.
ioBroker.uv-protect
   -

:thumbsup: No errors found
:thumbsup: No warnings found
Please review issues reported and consider fixing them as soon as appropiate.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence

All issues reported earlier seem to be fixed now.
THANKS for your support.
This issue can be closed.
your
ioBroker Check and Service Bot


Question: Is there an ETA or a timeline for the docs site?

I miss the older version when you could browse through the list of components.

hi @iamrudra , new documentation site is up now.

Thanks for the update @sesemaya 👍


Formatting results from external url

Hey!
It would be nice to add a way to format results from remote url. In my case the endpoint is returning a list of json objects, so I need to unpack them first. It could work in a similar way as in ui bootstrap library for Angular https://angular-ui.github.io/bootstrap/#/typeahead.
Cheers!

It sounds right. This is similar to issue #4.
It is on the wish list. It will be implemented in the future.

The feature to support list of json objects is implemented at commit 9d30bddc2e554e2040ccd82b3b15d562fedff3f1
It's available in the latest release v1.3.5.

Features have been implemented hence closing the issue.


VS code extension doesn't work

On the run command I get this error:

Cannot read property 'code2ProtocolConverter' of undefined

On status I get this error:

cannot open rust-analyzer-status://status. Detail: Cannot read property 'sendRequest' of undefined

VS Code version: 1.30.2

Are there any other error messages in the output channel. This is probably my fault - sorry!

This means that something on the typescript side dies. I think running the extension under debug should show a useful stacktrace.
I think we might be using some stuff from VS Code 1.31.0 so updating VS Code might be a good idea as well.

I don't think we explicitly use any new features but I did update some of the dependencies for node 10 which is what shipped with 1.31. That may be causing the problem. It also looks like we're using a beta of the vscode-languageclient package but that should only be additive to the feature set. Definitely try updating to 1.31.

Updating to 1.31 indeed helps.

Glad to head that! Will add "needs the most recent version of VS Code" to the readme!


followed instructions to install, but plugin does not appear in Xcode 6.4

i placed the plugin in the library location specified, and did not see the menu that the readme said would be there.
i also tried placing it in the Plug-ins folder under /Applications/Xcode.app with no results.

same...

Same with me

Same with me in xcode 6.4

same xcode 7.0 final

This thing should be marked as broken so others don't fall in the same hole.

xcode Version 7.2 (7C68)


Unsupported format types: regex, color, style, phone, email, ip-address, ipv6, host-name

with the addition of ipaddress the rest of these don't have well defined formats and are wontfix


Large points file fails to upload

The attached files - one flatgeobuff and the other a shapefile - both fail to upload. The file represents 162,000 depth soundings around Bonaire. Any thoughts as to why this won't upload to Next?
iacbaydepth2.fgb.zip
iacbaydepth.zip

Works now. FGB shouldn't be zipped though.


A couple of suggestions for dealing with iterating through fasta files

Not tested in a serious way but here are a couple of approaches I would generally use for the loop iteration.
I also put in a less biopython SeqIO solution as a suggestion -- also for my own edification because I had not use SeqIO in python before.

Thanks,
I am going to build some tests later in the day to check if both branches always handle the last sequence record etc correctly. And take a closer look at your suggestions.
I want to get into biopython too. I purposely avoid biopython/bioperl for low level scripts (e.g. get N50 etc) because I find that this limits their portability. Many researchers new to the command line are disinclined to start large installations also if I am visiting a lab and discussing their project in house I don't want to have to spend 20 min installing dependencies before I can check the volume of quality of data they have for their project.
In the case of this script the idea is to read and reformat mildly improperly formatted FASTA files while warning the user. BioPerl will not even tolerate unwrapped FASTA files although wrapping is suggested rather than required feature of a FASTA file. I would guess BioPython will also refuse to import an improperly or poorly formatted file but I'm not positive.
One of the points of this script is noticing our analyst starting a pipeline getting half way done. BioPerl rejecting the sequence reference because the file was not wrapped. She would have to stop the pipeline check that wrapping was indeed the issue and run a script to wrap the FASTA reference and restart. Another big issue is when someone leaves the final new line off a FASTA file. That can be a real problem if any standard method like concatenation is attempted. Often that just means the lab made a mistake that should be fixed and the workflow should continue. However because it could also indicate a failed file transfer my script also warns the user about the possible missing newline.
I noticed you putting the headers and sequences in a 2-D array (I guess in Python that is a 2-D list?) in line 179-187 in "A couple of tweaks for file line iteration". I tend to try to process one record at a time or in parallel if I can and if any record may be large. I was just thinking a FASTA file can store primers or a 20 Gb pine tree genome so I should move record by record through the file. What do you think?

Thanks for making a compare_lengths subroutine... Ahhh Perl. Sorry thanks for making a compare_lengths function I didn't like having to write that twice to handle the last FASTA record.
I had a funny thought about reading a FASTA file. It always makes clumsy code because only a header at the start of the sequence defines the boundary of the sequence. It can end with either an eof or another FASTA record.
What if you read the whole file in backwards? Last line to first line. While looping you would...
if 'line' does not match header pattern:
- remove trailing whitespace from 'line'
- prepend 'line' + 'dna' to 'dna'
else:
- remove trailing whitespace from 'line'
- header = 'line'
- do something with 'header' and 'dna'
-dna = '' # reset
-header ='' # reset
This would fix the issue of the special case of the last FASTA record as well as the issue of skipping the first header (e.g. don't process the current dna and header when you see the first header because you have no previous FASTA record). What do you think?
-J

Hi Jennifer,
About the 2D array, that was just one of a couple of suggestions and yes, it could create a high memory footprint with very large data sets.  From stack overflow, there are a few example of how to detect EOF in python but none seemed very elegant.  I would normally use streaming, as you do, in cases where scalability is an issue.  Personally, I have grown sanguine about falling off the end of a loop and don't let it bother me too much, as long as I remember to deal with the last record (or whatever).
About biopython and portability.  I understand your arguments but  I had to at least mention it.  However, I mainly put that in there because I had never used it before and took advantage of the opportunity to learn about it.
About reversing the order of lines in the incoming FASTA stream.  That's a clever idea, I had never thought of it.   Trying to do it within python would introduce the memory problem with large inputs but if you open the input stream using a command-line util to reverse the lines, it would work.  Sadly, the easiest solutions ('tac' in the GNU and 'tail -r' in Mac/BSD) are not universal but the command "sed '1!G;h;$!d' filename" is universal.
Dealing with input streams and system calls is easy in perl, less so in python.  Below is a code snipped of how to reverse a file and read it in as a stream:
from subprocess import Popen, PIPE
def open_reverse_file(file):
command = "sed '1!G;h;$!d' "+file
return Popen("sed '1!G;h;$!d' "+file, shell=True, stdout=PIPE)
file = "list";
proc = open_reverse_file(file)
while True:
line = proc.stdout.readline()
# detects EOF, don't strip line until after
if len(line) == 0:
break
line = line.strip()
print line

I grabbed your changes, added unit tests and removed some lingering bugs (e.g. fix_new_line was indiscriminately removing whitespace from headers).


problem with sass and @import

Constantly i see a similar error.
Message:
src\assets\scss\app.scss
Error: File to import not found or unreadable: settings
Parent style sheet: C:/xampp/htdocs/zurb/src/assets/scss/app
.scss
on line 1 of src/assets/scss/app.scss

@import 'settings';
^

Is there a _settings.scss file in the directory?
Are directory/file permissions getting in the way somehow?

Yes. Everything in its place.
Error does not occur at the start, but continuously during operation.

I don't have a specific answer, but perhaps doing a fresh install into a new directory, start up the stack, then start adding files from your other project and see what errors show up? Time consuming, yes, but will hopefully show the point at which the scss compiles break.

It is so strange, but i cleaned my .scss files from empty lines and extra spaces ... and problem with @import became more rare

Definitely strange. The only time I've had issues with this is when I have a path problem or permissions issue.

oh, i see another yet anomaly. When i change something in src files, i see:
[BS] Serving files from: dist/
[00:45:35] Starting 'pages'...
[00:45:35] Finished 'pages' after 521 ms
[00:45:35] Starting 'inline'...
[00:45:35] Finished 'inline' after 299 ms
[00:45:35] Starting ''...
[BS] Reloading Browsers...
but as result inliner completes files correctly

Huh. Check the gulp file to see if its trying to run something that isn't there, but the error is getting trapped before it's output. I'll have to compare this to what I'm seeing -- I use it so often I sometimes don't pay too much attention to the output unless there is a large error.

This occurs outside of foundation for me... just throwing that out there for anyone who feels this is related to zurb only.

You may need ~foundation-emails/...

Closing as we did not receive further feedback.


Update sprint-process.md

I have updated the refinement ritual to weekly, updated the language around retro's and demos and may have made some other minor copy edits.

Adding data engineers for visibility (@valbelova @EvavW @HansonVPHAM)


Fix facets not showing after empty facet is cleared

Questions
Answers

Description?
Fixes an issue where the facets will disappear and won't re-appear after removing the active filters. This issue occurs when clearing an empty facet (i.e. there are no available facet to display due to the current active filters)

Type?
bug fix

BC breaks?
No

Deprecations?
No

Fixed ticket?
Fixes PrestaShop/Prestashop#22488

How to test?
Follow reproduction steps in above ticket

This change is

LGTM
Thanks @ervinnnc ! :)

Hello I just found a regression with this PR : https://drive.google.com/file/d/1jCHWM94ESi8JV_KNFJum5VVskRFaTbzr/view

add a new attribute and feature
go to module configuration and disable a filter
save and see that change is not apply

Hi @ervinnnc ,
Since we had no news from you for more than 30 days, I'll close this pull request. Feel free to reopen or open another one if you think it's still relevant.
Thanks!


add Exception

:pushpin: Commit 50779f2 has been approved by japaric

@homunkulus r+

:hourglass: Testing commit 50779f2 with merge 50779f2...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing 50779f23d2bbe9ed5168c044ed63901bd2dd3ce7 to master...


error on missing slash in the states path

Get since today an error if the states endpoind miss a slash at the end:
does not work
https://api.corona-zahlen.org/states

work
https://api.corona-zahlen.org/states/

For the districts endpoint both versions work ( /districts AND /districts/  )
No Priority because simple to fix.
Question: is it possible to tag the Docker Image on docker.io with a continues build number?
I am hosting this API and set the :V2 tag, unfortunatley my app crashed on a new deployment because the issue above was for me a broken change :(

Update:
it is really confusing, I think it is not related to the slash!
Maybe the slash caused a cache busting (or forced to not use the cache)?
I had the same issue now with the /districts/ endpoint (with and without shlash):

As the message says, this was a RKI Issue!

Is the RKI response cached if an error happen?
Because /states doesnt worked (returned the above error) and /states/ worked.
After a while both worked again fine (1 hour)

yeah, I do think the messages get cached, even if an error is thrown.
I managed to reproduce this locally by replacing the implementation of an endpoint with a simple throw new Error('...')

After reverting to the regular implementation, the error response remains until the cache is cleared.
Expiry currently is set to 1800 seconds, hence after 30 minutes you get another try.
My suggestion would be to configure a different expiry for errors:
https://www.npmjs.com/package/express-redis-cache#expiration

However, the errors are also returned with a statusCode of 200, check with the current issue on #122:

I see!
Than the title of this issue makes absolute no sense.
The slash at the end caused a cache busting and the endpoint worked because RKI was "healthy" again.
I think this could be closed than.


Rename ann

As before, a flag to rename ANN fields.
Example:
--rename 'Gene_Name=Gene_Symbol,Annotation_Impact=Impact'

Can you explain what purpose this has? Wouldn't that be a separate tool?

This was just a shot at an idea from @christopher-schroeder , to allow renaming fields for users before writing an expression. I guess this will probably end up implemented in another way.

Closing this for now. I think renaming ANN fields is neat for a single user, but once you start communicating your vembrane command-lines (using new names for the ANN fields) confusion will eventually "arise" ;)


GH-35627: [Go][Format][Integration] Add StringView/BinaryView to Go implementation

Rationale for this change
See #35628 for the rationale and description of the StringView/BinaryView array types.
This change is adding Go as a second implementation of it.

What changes are included in this PR?
Add Array Types for StringView and BinaryView along with StringViewType and BinaryViewType and necessary enums and builders. These arrays can be round tripped through JSON and IPC.

Are these changes tested?
Yes, unit tests have been added and integration tests run (currently only Go vs Go but will run against C++ when #35628 is merged)

Closes: #35627

CC @felipecrv @benibus

Thanks for the reviews @lquerel and @candiduslynx!!


Push Rejected

Got the following error after pushing on Heroku:
-----> Fetching custom git buildpack... done
-----> Pelican app detected
-----> Installing Python (python-3.4.3)
-----> Ensure pip
python: /lib/libc.so.6: version `GLIBC_2.14' not found (required by /app/tmp/cache/python-3.4.3/lib/libpython3.4m.so.1.0)
 !     Push rejected, failed to compile Pelican app

Does anyone know how to solve this? Thanks

I fixed it by upgrading my Heroku app cedar stack to 14:


Crash in vkCmdWriteTimestamp executed outside of a render pass

The crash occurs here:
https://github.com/KhronosGroup/MoltenVK/blob/412c9ddb6763b5b80a60fcad90366b4eefea5ce3/MoltenVK/MoltenVK/Commands/MVKCommandBuffer.mm#L638
with the render pass related data uninitialized. I guess I could add some sort of inRenderpass() check as a fix?

Sorry about that. The patch in #1010 should fix this.


enum-iterator 0.6

@spearman can you update this for enum-iterator 0.6?

Updated in v0.4.2 https://crates.io/crates/enum-unitary/0.4.2


Reset command should remove tenderdash data files instead of unsafe_reset_all

Expected Behavior

unsafe_reset_all supposed to reset tenderdash state but it does it unsafely keeping something in the state which breaks further block production.
Current Behavior

unsafe_reset_all is used in reset command
Possible Solution

Delete all files from tenderdash data directory and generate new priv_validator_state.json with tenderdash gen_validator command.
Your Environment

Version used: v0.18
Environment name and version (e.g. Chrome 39, node.js 5.4): Node.JS v12
Operating System and version (desktop, server, or mobile): Mac OS

I don't think we currently use unsafe_reset_all in the reset command, where did you see this? We drop the volume and regenerate the validator state with tenderdash init instead.

Oh... My bad.


Added dashu crate, introduced new versions

Hi,
I added dashu crate to this benchmark. I also changed all crates to their latest versions. As I changed clap to the newest version, I also had to rewrite the code that deals with argument parsing, but I think I managed to replicate exact behaviour as before. I removed any mention of the old crates, not benhcmarked anymore (rust-gmp). I was also reading the part of the code that deals with benchmarking and I changed it a little. I think I made good simplifications that work pretty good. I'm getting the same results as you listed in the README on my laptop so I think that my benchmarking strategy works well while being much easier to understand and follow. What I did is I made each library do at least 5 iterations of the test, or run at least 60 seconds. Whichever is longer. I don't think it is neccessary to completely separate benchmarking samples as you did because we are only really interested in the fastest run anyway. I changed the output a little to appear prettier. README is also edited to account for these changes, I only didn't touch the timings table, you will have to measure that on your hardware and fill it. I did create a workflow that builds binary and runs benchmarks on push/pull_request/workflow_dispatch, but I don't know if its' benchmarks can be trusted since I believe that processing power available to jobs varies depending on the load on the GitHub servers. I tried turning on static linking c runtime cargo option, but dashu crate wouldn't compile for some reason, so I gave up on that.
I hope you will accept my changes. I know that they are pretty big, especially those around benchmark function so I will understand if you choose not to.
Regards

I added workflow jobs that run on macOS and Windows. Sorry for so much unneeded commits, it is tough to get workflow right and since I can't test it locally, each modification requires a new commit... 😢. Again, I don't think results from GitHub Actions are accurate, you should run benchmark yourself.

Thanks for making these changes. There are many things here in addition to just adding a new library and upgrading versions, so it would be easier to review those separately. But I'll take this anyway.
BUT: I don't think the new benchmarking strategy is better. This seems like a deterioration -- for very short running tasks you want to time multiple runs, rather than timing each run separately. Taking the minimum time of all the individual short runs creates the risk of bad clock resolution or other random factors affecting the result.
Can you revert this part? If you think this makes sense, open a separate ticket.

Hi, thanks for reviewing my changes. You are right, I assumed that clocks are precise enough, but after reading a bit I agree that it might not always be the case. I will revert this change, but I think that all iteration work should be done by one function instead of sending number of iterations as an argument to run_task function. You probably did it this way to decrease the number of function calls which also take time. I will add #inline(always) attribute to those functions instead so that they get inlined and the cost of calling them doesn't appear anymore. Of course that match block inside run_task will still need to be run every iteration, but I don't think that it can make much difference to results, it should be pretty cheap, after all, it is only one match block. Expect a fix in a few days, currently I'm having some performance problems with my IDE, I'm waiting for jetbrains support to fix a problem.

I don't understand why you want to implement any changes to the benchmarking loop at all if it's not going to change behavior. Let's leave that to a separate ticket if you want to refactor that code, that seems unrelated to this ticket.

There are still a bunch of changes to the benchmarking code that I don't understand the reason for.
Sorry I can't take it like this.
The name of the PR mentions adding a new crate and updating versions. Whereas there seem to be at least the following changes here:

add a new crate
update versions
delete some crates
github actions workflows
Rust edition update
library version change (why? don't do that,)
clap version upgrade with the corresponding rewrite
README formatting
output formatting
benchmarking code changes (not sure what changed)

I suggest closing this PR and doing these things one change at a time, without changing other unrelated things at the same time.


Update get-started-raw-media-access.md

Update quickstart for raw media v2

@yassirbisteni : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[8.x] Add queryable values in wheres

This PR adds the ability to add "Queryable" values on where queries.
When using the whereIn method on the query builder, it's super handy, that we can use expressions like the following:
User::query()->whereIn('id', Post::query()->select('user_id')->published())->get();

The problem is, currently we can't use this approach on other types of where queries, however sometimes that would be very helpful:
// Before
Proposal::query()->whereHas(
    'votes',
     static function (Builder $query): Builder {
           return $query->rejected();
      },
      '<=',
     DB::raw('('.User::query()->verified()->whereRaw("`role` = 'member'")->selectRaw("floor(count(*) / 2)")->toSql().')')
);

// After
Proposal::query()->whereHas(
    'votes',
     static function (Builder $query): Builder {
           return $query->rejected();
      },
      '<=',
      User::query()->verified()->role('member')->selectRaw("floor(count(*) / 2)")
);

Normally this works with all the wheres. Also, the "subquery" bindings are merged into the main query.
I've tested in MySQL 8+ and SQLite with real data, worked fine.
In my opinion this is not a BC, but if you consider as one, I gladly resubmit to 9.x.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Set webpack stats file path in settings

Set the path to the webpack-stats.json file in the settings.py. Does this make sense @melegiul ? It seems we use a different path, but basically this is almost the same as the example in https://github.com/django-webpack/django-webpack-loader#default-configuration.

I tried to address this in #983:
https://github.com/Integreat/integreat-cms/blob/6ab2f3a9d1084d903ff8776aa2ea6a4eafff9b8a/webpack.config.js#L119


README logo displays poorly with GitHub Dark Mode

I'm pretty sure that 95% of users on GitHub are using the dark theme at this point. The Passerine logo was designed before this was a thing, and now displays black-text on black. This needs to be fixed:

We could make the text white, but this is bad for the same reasons
We could make the background white, but the background would no longer be transparent.
We could make the background black and the text white, but the background would no longer be transparent
We could make the text green like the logo; this works because green is between black and white in terms of value, but then the logo has green text.
We could make the text grey; see the above.
We could add a white drop-shadow: with light mode this would be invisible, but on dark mode this would outline the text. Likewise, we could just add a white outline to the text.
I'm not sure if GitHub supports it, but SVGs can be styled with CSS. If GitHub exposes a 'dark-mode' selector, we could change the SVG dynamically to make it work on different platforms. Cross-platform support though.

All in all, a lot of choices. Will have to think about it; what are your thoughts?

The new logo has a solid background.


Re-add support for Centos and RHEL stemcells

This re-adds the previously-removed support for Centos stemcells (and also RHEL stemcells, since both types are handled identically by the agent).
NOTE: A PR to re-add https://github.com/cloudfoundry/bosh-linux-stemcell-builder support for Centos and RHEL stemcells will be submitted soon.

I'm guessing the guide-rails.json is for a CI pipeline you'll be running yourselves?

Yes, that is the CI control file for our CI system.


Support uploading a video (multipart media: mov, mp4)

Added the ability to post videos without violating the existing GIF submission and image submission methods.

Thanks for your contribution. This looks awesome to me. 👍

Thank you for merging my pull request!


Allow access to some details via @connection but limit "list" to specific groups

Which Category is your question related to?
Amplify API Auth
Amplify CLI Version
4.16.1
What AWS Services are you utilizing?
Cognito, Amplify, AppSync, DynamoDb
Provide additional details e.g. code snippets
Given the schema below I want to:

Allow "admin" to list all users and all posts
Allow "member" to list all posts and the "name" of the User in those posts
Don't allow "member" to list all users

I've tried to simplify the schema to focus on the issue.
type Post @model @auth(rules: [
  { allow: groups, groups: ["admin"], operations: [create, read, update, delete] },
  { allow: groups, groups: ["member"], operations: [read] },
]) {
  id: ID!
  title: String!
  content: String
  user: User @connection
  postUserId: ID
}

type User @model @auth(rules: [
  { allow: groups, groups: ["admin"], operations: [create, read, update, delete] },
]) {
  id: ID!
  name: String!
  dob: AWSDate
}

To restrict access I'd normally use @model(queries:null) and force the lookup of User.name via the @connection. However in this case I need the group "admin" to be able to list all users. I've tried and tried to come up with a solution to this seemingly simple and common scenario. Hope you can help me shed some light on it.
The options I'm currently considering, but that don't feel right...

Write a @function where the Lambda function queries the User table for name with different credentials. Assign this function to a field on Post, e.g userName: String @function(name: "GetUserName").
Add and manually manage Post.userName redundant value (messy).
Override the resolver (I really don't want to have to write Velocity).

Thank you!

I ended up implementing it with a @function on a field. Would love to hear if there's a better solution.
type Post @model @auth(rules: [
  { allow: groups, groups: ["admin"], operations: [create, read, update, delete] },
  { allow: groups, groups: ["member"], operations: [read] },
]) {
  id: ID!
  title: String!
  content: String
  user: User @connection
  postUserId: ID
  userName: String @function(name: "GetUserName-${env}")
}

exports.handler = async (event) => {
  const aws = require('aws-sdk');

  aws.config.update({
    region: 'us-east-1',
  });

  const ddb = new aws.DynamoDB({apiVersion: '2012-08-10'});

  const params = {
    TableName: process.env.TABLENAME,
    Key: {
      'id': { S: event.source[process.env.FKFIELD] },
    },
    ProjectionExpression: process.env.FIELD,
  };

  const val = await new Promise((resolve, reject) => {
    ddb.getItem(params, function(err, data) {
      if (err || !data.Item) {
        reject('N/A');
      } else {
        resolve(data.Item[process.env.FIELD].S);
      }
    });
  });

  return val;
};

TABLENAME = 'User-xyz...abc-dev'
FKFIELD = 'postUserId'
FIELD = 'name'


Lightbox generates CSP errors for sites that block inline-styles

So, you're experiencing a problem?
The current version of lightbox generates a CSP (Content Security Policy) error when sites are set to block 'unsafe-inline' styles.  This is because there are a couple pieces of the code that are setting styles directly on elements via a style tag.
If you really do think you have a bug, please:

[X] Provide a link to your site or a full example
https://pokeinthe.io/2017/03/07/recording-mtgo-in-4k-with-obs/

[X] Provide screenshots where appropriate

[X] Browser name and version
Firefox and Chrome (current releases)

This is the piece of code that causes the problem:
let header = `<div class="modal-header"${this._config.title || this._config.alwaysShowClose ? '' : ' style="display:none"'}>`+(this._isBootstrap3 ? btn+h4 : h4+btn)+`</div>`;

(and also footer)

I think you also make a few calls into .css() as well.  For the piece of code above, I think you can just use class="hide", since it's part of Bootstrap.  For calls into csp() it might be a bit more complicated, but not too tricky I don't think.


Responsive design

We would like to have an ability where we can specify different layout for different screen resolutions/viewport sizes in the Schema itself.

Thanks for this feedback, is responsive UI support still an active request on Adaptive Cards, something that you need?
Can you share any pictures or examples of what specifically you're trying to achieve? Additional requirements and examples help us make sure we build the right features for you :)
Please re-open if this is still an active request and share some more details!


TSI indicator

Should the TSI indicator, This is the indicator that allows multiple timeframe
https://ninjatrader.com/support/helpGuides/nt7/?highs.htm
~TSI.Calculation.xlsx

It should also gives an green light on how that is implemented.

https://drive.google.com/open?id=1wJzWMzk9Ki0P_t4sWQx6HIrbrhBrR4At

This looks good. I think now. I like the following logic.
Define LowerFrame, HighFrame and whatever timeframe the current chart has, it will be its time frame (MiddleFrame)
User allow to input LowerFrame and HigherFrame, it can be 1m, 5m, 15m, 60m, 240m, 1d, 1w and 1m
Other than the minutes, 1d = 1 day, 1 w = 1 week and 1 m = 1 month.
Add Three input param, TSIPeriod (int default 200) and ADX period(int default 14). Add a bool to show Signal or not.
Add Three param for threshold, TSIThreshold,(double, default 0.65) ADXUpperThreshold (double, default 50)
ADXLowerThreshold(double default 25)
Use our way to calculate TSI. Plot middle time frame TSI.
IsSignal has the following logic:
Midframe TSI200 absolute value > 0.65 (TSIThreshold)
LowerFrame TSI200 absolute value > 0.65
HigherFrame ADX(14) between 25 to 50 (ADX Thresholds)
Plot Middle Time Frame TSI, not overlay on price.


Python error when trying to generate twist bones (dev branch)

I'm trying to generate a twist bone for the arms and I get a python error

(happens on blender 2.8 and 2.9)

Looks like use_mesh_mirror_x was added in Blender 2.93 (https://docs.blender.org/api/2.93/change_log.html#bpy-types-object), so you would need to update your Blender version to at least 2.93 until a fix is made for older Blender versions.


👀  Integrate Microsoft Doc Intelligence for OCR

Currently the only OCR service Tarsier supports is GoogleOCR vision. We're told Microsoft's model is the most performant so would love to also include it!
Documentation: https://learn.microsoft.com/en-us/azure/ai-services/document-intelligence/concept-read?view=doc-intel-4.0.0

Document Intelligence has more advanced capabilities for processing multi-page documents. Since for tarsier, we're dealing with screenshots (single images), it's easier to integrate their OCR service as a start.
Please see https://github.com/reworkd/tarsier/issues/84 and https://github.com/reworkd/tarsier/pull/85
@asim-shrestha @awtkns

That sounds great @ml5ah !


Forward X-Auth-Request headers in oauth

[ ] update lua-script download link
[x] update docs

Codecov Report

Merging #1114 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1114      +/-   ##
=========================================
+ Coverage    3.61%   3.73%   +0.11%
=========================================
  Files         106     106
  Lines       21004   21042      +38
=========================================
+ Hits          760     785      +25
- Misses      20113   20122       +9
- Partials      131     135       +4

Impacted Files
Coverage Δ

apis/voyager/v1beta1/validator.go
55.02% <0%> (+1.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d433ed...e64b8f9. Read the comment docs.


python310Packages.asyauth: 0.0.12 -> 0.0.13

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 216526 run on x86_64-linux 1

23 packages built:

crackmapexec
python310Packages.aardwolf
python310Packages.aesedb
python310Packages.aiosmb
python310Packages.asyauth
python310Packages.asyncmy
python310Packages.lsassy
python310Packages.minikerberos
python310Packages.msldap
python310Packages.pypykatz
python310Packages.unicrypto
python310Packages.winsspi
python311Packages.aardwolf
python311Packages.aesedb
python311Packages.aiosmb
python311Packages.asyauth
python311Packages.asyncmy
python311Packages.lsassy
python311Packages.minikerberos
python311Packages.msldap
python311Packages.pypykatz
python311Packages.unicrypto
python311Packages.winsspi