Improper order? Unexpected behavior trying to use system in Chat.

Look what happen in this example:
{"keep_alive":"5m","messages":[{"content":"What are nimbus clouds?","role":"user"},{"content":"Nimbus clouds are dense, moisture-filled clouds that produce rain.","role":"assistant"},{"content":"What are some other kinds of clouds?","role":"user"}],"model":"llama3.1:latest","options":{"seed":42,"top_k":20},"stream":true}
content appears before role.
If you look at the example they gave us from the API documentation it should look like this.
messages := []api.Message{
api.Message{
Role:    "system",
Content: "Provide very brief, concise responses",
},
api.Message{
Role:    "user",
Content: "Name some unusual animals",
},
api.Message{
Role:    "assistant",
Content: "Monotreme, platypus, echidna",
},
api.Message{
Role:    "user",
Content: "which of these is the most dangerous?",
},
}
I have tried to provide system prompt as message1 followed by message2 being user, then 3 for assistant, then 4 for user.
It behave unexpectedly as if the 1 message is user and the second is system?
It is for this reason, that I suspect having it in proper order is important.
However, looking at the code, I can't seem to understand how it gets backward or how to get it right.
Please fix this.

Earlier I made a pull request to support system for both Generate and Chat. #17
But, then I remove it from Chat because it's supposed to already let you do that.
Now that I discovered it fail to do it, I tried putting it back in my space and it actually work. So for now I would use that.

Previously, Ollama required you to set the System parameter in the Modelfile itself. They've added the ability to override it in the API through the new field in the generate endpoint and the ability to include it as a message type in chat.
There's no issue with content appearing before role in the first example. This is still valid JSON, and JSON provides no guarantees about the ordering of the key/value pairs that it provides. When Ollama receives the request it will parse out those fields as a dictionary, so the order of individual key/value pairs should not matter.
What definitely does matter is the message order though. These should (and need to) be received in order so that the model can accurately understand the conversation history. It looks like that's happening based on the debug request as the conversation messages themselves occur in the proper order. That should be all that's required for Ollama to interpret them correctly.
I'll do some tests with the system parameter using chat messages and see if I observe any invalid results. In the meantime, I've done some refactoring to allow the user to manually create requests to be sent to the generate, chat, and embedding endpoints. This should allow you to more easily access custom fields such as system while I work on getting them included in the base functions. See the new section in the Readme labeled Manual Requests and the example test cases at the end of test.cpp:
// Manually specify all fields
ollama::request request(ollama::message_type::generation);
request["model"]="mistral";
request["prompt"]="Why is the sky blue?";
request["stream"] = false;
request["system"] = "Talk like a pirate for the next reply."
std::cout << ollama::generate(request) << std::endl;

Or alternatively:
// Use the default constructor for generate requests, and add custom fields.
ollama::request request("mistral", "Why is the sky blue?");
request["system"] = "Talk like a pirate for the next reply."
std::cout << ollama::generate(request) << std::endl;

I see! Thank you for doing this.

I tried using chat again with this new method. system is working.
But, I'm getting an issue where it act like I didn't give it any information at all and just hallucinate stuff instead.
It appears to happen when the first message as user is too big?
I might have to guess that it's not designed to take much.
Is there a proper way to inform the AI about something like a worldbuilding for instance?
Also, I'm getting random crashes from using any AI generating options. Even if it's not streamed. I can't tell what cause it.
But, I want to find a way to replicate it by using options.
And so, in trying to use options I'm confused by it because it crash.
Please provide an example on how to use options.
Here's how I tried to use it.
ollama::message message1("user", context);
ollama::message message2("assistant", "I'll remember everything you just gave me.");
ollama::message message3("user", prompt);
ollama::messages messages = {message1, message2, message3};
ollama::request request(ollama::message_type::chat);
request["model"]=Select_AIModel;
request["system"] = system;
request["messages"] = messages.to_json();
//request["options"] = options;
if (options!=nullptr) request["options"] = options["options"];
request["stream"] = false;
Also, putting system before messages still would have it at the end. Why is that?

I think the issue is that the chat endpoint has no direct system parameter; it has be added as a message in the conversation. Only the generate endpoint has a system parameter in the Ollama API: https://github.com/ollama/ollama/blob/main/docs/api.md. Passing a system JSON tag directly will work for generate but will likely produce undefined behavior for chat.
The manual requests are designed to allow for setting fields directly, but you should check the API to make sure they're supported for that endpoint otherwise it may produce unexpected results.
I'll investigate why adding a message for system isn't working in chat if you're having issues with that. It should just require adding a message like: ollama::message message1("system", "Speak like a pirate for the next message");

Ah. That actually fixes the problem then!
That is odd though, with chat I was having problem with it being in message.
I don't know why this exactly. But, for now this manual way to generate response appears to be much better.
Anyway, how do you put in options for manual? I tried figuring it out.

Hmm. I tried using a WebUI interface and tested a large prompt. It sees the beginning of something as right in the middle? This is awfully short span of memory. I'm using llama3.1 8b isn't it supposed to have a large context window? How do I use it???

I do this.
if (options.contains("options")){
std::cout << options["options"].dump() << "\n";
}
And yet, in spite of it passing the test, there is an object called options it gives me an error saying it's out of range, not found. and crashes.

If you wants to manually add options to a request you can do the following:
    ollama::options options;
    options["num_ctx"] = 8192;

    ollama::request request(ollama::message_type::generation);
    request["model"] = "llama3.1:8b";
    request["prompt"] = "Why is the sky blue?";
    request["stream"] = false;
    request["options"] = options["options"];

    ollama::response response = ollama::generate(request);
    std::cout << response << std::endl;

I figured out why it crashes. It's because of the lifetime when using thread. No problem there anymore.
However, I set the option and then do exactly what you did in getting "options" and it ends up empty.
Running your code I gets this.
{"model":"llama3.1:latest","options":{},"prompt":"Why is the sky blue?","stream":false}
options is not supposed to be empty?
So I tried dumping the whole thing to see what it look like.
std::cout << options["options"] << "\n";
std::cout << options.dump() << "\n";
Output:
{}
{"options":{"num_ctx":4096,"num_predict":18,"options":{},"seed":42,"temperature":0,"top_k":20}}
It's not empty. But, it's not getting anything either.

I see what you're referring to. That syntax works with the standard constructor for request but isn't working in your example. I'll take a look later.
In the meantime, you can set the options directly as JSON. They're just a dictionary under options:
    ollama::request request(ollama::message_type::generation);
    request["model"] = "llama3.1:8b";
    request["prompt"] = "Why is the sky blue?";
    request["stream"] = false;
    request["options"]["num_ctx"] = 8192;

    ollama::response response = ollama::generate(request);
    std::cout << response << std::endl;

Thank you very much! I didn't know you could do that with JSON. I have a lot to learn.
And this actually fix the issue I had with chat not having the full message through!
Chat was discarding messages from first to last when there's more than 2048 words without warning, which made it very confusing.
Tell you what, this is a lot of information we just covered that isn't explained well enough in their API documentation. Maybe you could provide some clarification for this as part of the example.cpp? I mean really, I didn't expect the context window to be capped at all.
I'm liking this manual request format we got here. Very flexible, easy and clean.
I think that with the knowledge like this, we can close this.


Mark TestHiveTransactionalTable.testFilesForAbortedTransactionsIgnored as @Flaky

CI failed -- https://github.com/prestosql/presto/issues/5809


Updated chain id types

Update chain_id type to avoid encoding error in the future

We will have to revert the changes to chain_id, Note will contain hex string representation, so the values might not fit into u128: https://github.com/webb-tools/webb.js/blob/master/packages/wasm-utils/src/note/mod.rs#L113

Chain id string should never be more than u128 so this shouldn't be an issue. We should panic if it's ever larger truly.

I guess you are right, we should do the same with amounts then


[Tentative] Remove Reddit Extension

Similar to Twitter, and dependent on Reddit following through with API pricing changes:

[ ] Remove Reddit-specific code
[ ] Remove Extensions UI in iOS Settings and macOS Settings (erstwhile Preferences 😢)
[ ] Include an Alert informing users of Reddit removal

I'm confused, isn't there still a level of free access per OAuth token?
from : https://www.reddit.com/r/reddit/comments/145bram/addressing_the_community_about_changes_to_our_api/
Free Data API
Effective July 1, 2023, the rate limits to use the Data API free of charge are:

100 queries per minute per OAuth client id if you are using OAuth authentication and
10 queries per minute if you are not using OAuth authentication.

The 100 queries per minute is per application. Across all users, NNW would exceed that constantly.

Today, over 90% of apps fall into this category and can continue to access the Data API for free.

I'm sure most apps in this category are toy apps or were never actually created once the developer registered them with Reddit.

Can't each client provide their own OAuth credentials?  100 queries is per OAuth client.

Even if we could make it work technically for each user to provide their own OAuth credentials, we would be acting in bad faith. It’s clear that Reddit wants apps like ours to either stop using the Reddit API or pay for the privilege.

Gotcha, welp, let's hope they don't kill the RSS feeds then.


Bug: Comma in string in list raises IndexError: list index out of range

item = """
a = [
  [
    ",",
    ""
  ]
]
"""

toml.loads(item)

raises exception:
    587     elif v[0] == '"':
    588         testv = v[1:].split('"')
--> 589         if testv[0] == '' and testv[1] == '':
    590             testv = testv[2:-2]
    591         closed = False

IndexError: list index out of range

Yes, I have just one comma in the string.

Hi Sep,
Thank you for your bug report. Does this look like a duplicate of #153 to you?

Hi @uiri
It looks the same. Did you release a new version to Pypi or should I test on your master?

This bug is there although #153 is fixed so I guess it is a distinct bug.

The cause is as follows.
https://github.com/uiri/toml/blob/master/toml/decoder.py#L761
But I'm wondering how to fix...

Any movement on this? Looks like there's a pending PR to solve this.

Any fix on that?

Any fix on that?


White screen when I was trying to upload an image. Why do I get it? Here is my code.

I'm using ng-file-upload for upload image, and getting white screen.
JS
angular.module('someApp', [
  'ngFileUpload',
  'ngImgCrop'
]);

 <link rel="stylesheet" type="text/css" href="ng-img-crop.css">

                    Чтобы загрузить, нажмите на иконку картинки

                    или перетащите файл в это окно

I'm just trying to upload an image, I can see it, but later it disappears. What is the problem?
video with problem: https://youtu.be/L2oKqh03bGM

can you reproduce it inside codepen?

I've already found a solution to my problem. The problem was in angular, I don't know why but using ng-if causes such a flicker. Native library doesn't have it. We need to check it. So thank you, the issue can be closed

@zidein07 I had exactly the same problem haha! It should be written : USE ng-show in the README 😄

If you have issues with ng-if and ng-show start use objects. Example
$scope.imageHanlder = {
  src: 'some src to the img',
  dest: 'dataUrl result'
}

and i believe you will have never problem. Some people use controller as object which solve the issue also but it's ugly by my option.


/js bed() no longer works

[19:36:16] [CanaryMod] [INFO]: Command used by CoderDojo2: /js bed();
[19:36:16] [ScriptCraft] [INFO]: Drone build error: java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.runtime.NativeJavaPackage to java.lang.Comparable while processing function wrapperFn() { [native code] }

ENVIRONMENT
Jars
CanaryMod-1.8.0-1.2.0-RC1.jar

and ScriptCraft.jar from http://scriptcraftjs.org/download/latest/scriptcraft-3.1.10/
$ java -version
java version "1.7.0_75"
Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

system_profiler SPSoftwareDataType
Software:

    System Software Overview:

      System Version: OS X 10.10.5 (14F27)
      Kernel Version: Darwin 14.5.0

Hey @kellyfj ,
I don't have that exact machine configuration myself but I haven't been able to reproduce this problem with either of the following Java versions on Mac OS X
java version "1.7.0_60-ea"
Java(TM) SE Runtime Environment (build 1.7.0_60-ea-b02)
Java HotSpot(TM) 64-Bit Server VM (build 24.60-b04, mixed mode)

or java 1.8
java version "1.8.0_40"
Java(TM) SE Runtime Environment (build 1.8.0_40-b25)
Java HotSpot(TM) 64-Bit Server VM (build 25.40-b25, mixed mode)

I'm still on OS X Yosemite 10.10.4 . I'll try to reproduce it again once I've upgraded.

Hey Walter - FYI when I used this version of CanaryMod it works fine
CanaryMod-1.8.0-1.2.1-SNAPSHOT-shaded.jar
I get that from here http://scriptcraftjs.org/download/latest/
Perhaps we just need to update the Canary Mod install instructions here
https://github.com/walterhiggins/ScriptCraft/blob/master/docs/YoungPersonsGuideToProgrammingMinecraft.md#installation
Also FYI the link in that documentation (https://canarymod.net/books/canarymod-admin-guide) is now a 404
Thanks!

Thanks @kellyfj,
I've mirrored the canarymod docs here https://github.com/walterhiggins/canarymod-admin-guide/


Great repo

Please provide more attributes etc :)
Then we can create our own android app or linux desktop app which works better x)

Thanks for your comment!
Are there any particular attributes/behaviours you'd like prioritised?

Hey! Thanks for your reply. I want to create my own music client for linux.
A very important function is to list all songs.
I would try to create PRs to make this repo more pythonic like if you want.
There are also some bugs which i can fix.

That'd be much appreciated, thank you!
On Fri, 25 May 2018, 17:27 Daniel Däschle<EMAIL_ADDRESS>wrote:

Hey! Thanks for your reply. I want to create my own music client for linux.
A very important function is to list all songs.
I would try to create PRs to make this repo more pythonic like if you want.
There are also some bugs which i can fix.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Jaffa/amazon-music/issues/2#issuecomment-392111091,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASNBRZx75Aag4mE725Q_2mXC_e5LpWIks5t2DDZgaJpZM4Tr2KE
.

Did you saw my PR?


cannot store *app.RequestContext to package scope variable

（in i18n.go） atl18n is a package scope variable, while app.RequestContext only valid in the request lifetime， it will be freed when request end. after that, call the GetMessage API may cause memory use after released.
func Localize(opts ...Option) app.HandlerFunc {
	newI18n(opts...)
	return func(c context.Context, ctx *app.RequestContext) {
		atI18n.setCurrentContext(c, ctx)
	}
}

May I ask if you are having problems with the above mentioned situation? If so, please provide me with a copy of the code used to reproduce it so that I can solve your problem.

Hertz's app.RequestContext is not thread-safe and does not currently support direct asynchronous use.

May I ask if you are having problems with the above mentioned situation? If so, please provide me with a copy of the code used to reproduce it so that I can solve your problem.

I think you can refer to the implementation method of this library : gin-contrib/i18n and use the context.Context as a parameter to the MustGetMessage method instead of store any Context in the package scope variable atl18n

May I ask if you are having problems with the above mentioned situation? If so, please provide me with a copy of the code used to reproduce it so that I can solve your problem.

I think you can refer to the implementation method of this library : gin-contrib/i18n and use the context.Context as a parameter to the MustGetMessage method instead of store any Context in the package scope variable atl18n

gin.Context will also be recycled and We'll optimise it.

Can I ask if this is an issue you are experiencing in your production environment or? This will determine the priority of refinement.

@qleein


Install fails via vue-cli

I tried to install the template via vue-cli but didn't work:
$ vue init nolimits4web/Framework7-Vue-Webpack-Template mytest
vue-cli · ENOENT: no such file or directory, scandir '/var/folders/7s/qrv4cn4d6xv0t350mzb0wl2m0000gn/T/vue-template-3f402w9/template'

If I do the same with my own template, it works.
Using latest vue version 2.6.0 here.
Is vue-cli not supported? I thought this template is based on the Vue Webpack Boilterplate and should thus work with vue-cli.

Hello valnub,
I watched your videos about vue-f7, helped me a lot. Thank you so much...
I think currently this templates not support anything (yeoman or vue-cli), just direct download working well.

Hi @centrual, I'm glad that the videos were helpful for you :)
Thanks for pointing out that the templates do not support vue-cli.
I'll just leave this ticket open here then as a feature request.

Thanks @valnub, yes your videos helped a lot! 👍
I created pull request for vue-cli compatible template: https://github.com/nolimits4web/Framework7-Vue-Webpack-Template/pull/6
Have a great day!

Nice, thanks! :-)

I've updated dependencies, should work fine now


request timeout

request to https://api.openai.com/v1/completions failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443
my model is text-davinci-003

request to https://api.openai.com/v1/chat/completions failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443

Dupe of https://github.com/gencay/vscode-chatgpt/issues/177 and https://github.com/gencay/vscode-chatgpt/issues/176. Please check the comments to see if the suggestions would work for you.
The reason is that OpenAI restricts access from your location/machine. Potential workarounds:

use system VPN
override apibaseurl


Compression  Task Bug

When I run the following cmd:
python -m train --task  compression --layers mh-attention swiglu mh-attention swiglu
Then the error occur:
ValueError: Expected input batch_size (163840) to match target batch_size (16384).

Hi,
I also have this issue and traced it to the position_ids not being set when passed into .encode here. This means that the position_ids are None when returned from .encode.
This then means None is passed to decode. position_ids is then used to select from the dec_position_embeds here meaning all (max_length) position embeddings are taken with an extra dimension added because of the None. However, I think only sequence length number of embeddings are supposed to be taken.
A simple fix for this is to add a one liner into the forward method to over write position_ids like this:
    def forward(self, input_ids: torch.Tensor) -> torch.Tensor:
        encoding, _ = self.encode(input_ids)
        position_ids = torch.arange(0, input_ids.shape[1])  # temp fix
        token_logits = self.decode(encoding, position_ids)
        return token_logits

I don't know if this is the correct fix, but it seems to make it work and seems logical from reading the code. Would love to know if it is correct @athms :)


lpc55: Improve IFS and PRINCE setup

This PR contains several patches that improve the IFS and PRINCE setup:

Only enable PRINCE for the IFS subregion when accessing the IFS.
Change the firmware and IFS boundaries to reflect the actual values.
Add more sanity checks.

Limitation:  Currently, our build script truncates the length of the IFS to multiples of 1024 when generating the linker script.  I think this should not be an issue as the filesystem region defined in the linker script does not have any effects AFAIK, but we could fix this by writing the full values instead.  Fixed by using the full values.

lgtm,
especially having the read/write/erase primitives inside the runner introduces more consistency between lpc55 & nrf52 - otherwise introducing this into the lpc55_hal might be the wrong way anyways as this is pretty (hardware-)application specific code.


how to set the parameters of the Blackfly S camera ?

such as White Balence

We haven't implemented this in our driver.  You should be able to implement it easily by using modifying the section at https://github.com/neufieldrobotics/spinnaker_sdk_camera_driver/blob/fd3d35e43ad590c4ef42937083317c56d5459386/src/capture.cpp#L489
You should be able to use either cams[i].setIntValue or cams[i].setEnumValue to set the white balance.  A good way to check the values and variable name it will accept is by opening the camera in SpinView and looking at the White Balance options there.
If you do implement this, please submit a pull request for the others.

@vik748 thanks for your suggestion, I will consider it.

@vik748 thanks for your suggestion, I will consider it.

Have you implemented this setting? I also want to set the parameters of the Blackfly S camera.

In the latest version of the code, we have implemented settings for Target grey value which can be set using Dynamic reconfigure. White balance should be very similar to that.


transition "fadeslide or slide" wrong positioning in fullscreen @ ie

in twelve theme transition "fadeslide or slide" wrong positioning 2nd images in fullscreen mode @ all internet explorers. even ie9
first image: correct
2nd image: wrong position etc..

btw temporary solution:
.fullscreen .galleria-image { left:auto !important; }

This issue should have been fixed in 1.2.6


Address review feedback for relayer

Need to address review feedback from #58 and #59.

Applies to open PR https://github.com/Snowfork/polkadot-ethereum/pull/57 as well

https://github.com/Snowfork/polkadot-ethereum/pull/89 addresses the Solidity portions of this issue. @vgeddes are we good to close the issue?


ArmNN still builds static libs even with -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF

ArmNN still builds static libs even with -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF
This is a problem for Linux distributions which usually only package dynamic libs, not static ones.
This lead to /usr/lib64/cmake/armnn/ArmnnTargets.cmake containing some STATIC refs and make some 3rd party builds to fail since the package dropped the static libs.
The problematic static libs are:
/usr/lib64/libarmnnUtils.a
/usr/lib64/libfmt.a
/usr/lib64/libpipeCommon.a

Hi @ggardet,
For our Debian packaging we use .install files to selectively package just the shared libraries we want, is that something these distribution can do?
Or is it at the build stage the packaging tooling refuses to create the static libraries and so they end up not being linked to libarmnn.so etc?
Thanks,
Francis.

@FrancisMurtagh-arm
Yes, static libs are dropped from the RPM package to only install shared libs, but the problem is ArmnnTargets.cmake still states we need to link to those static libs which are not available for the user.

Hmm, those three libraries are implementation details and ideally shouldn't be exported at all. But I guess they need to be, to satisfy linking of static Arm NN where that's needed.
So really what we need here is something like GNU Libtool's "Convenience Library" feature (https://www.gnu.org/software/automake/manual/html_node/Libtool-Convenience-Libraries.html).
I wonder if CMake has such a feature?


installation of texmaker (via homebrew) url does not exists

General troubleshooting steps

[ ] I have checked the instructions for reporting bugs (or making requests) before opening the issue.

[ ] None of the templates was appropriate for my issue, or I’m not sure.

[ ] I ran brew update-reset && brew update and retried my command.
[ ] I ran brew doctor, fixed as many issues as possible and retried my command.
[ ] I understand that if I ignore these instructions, my issue may be closed without review.

Description of issue
{{Hi, I've tried to install LaTeX to my mac, however the url for downloading dmg file does not works}}
Output of your command with --verbose --debug
{{m:~ mvlkova$ brew cask install mactex
==> Satisfying dependencies
==> Downloading http://mirror.ctan.org/systems/mac/mactex/mactex-20170524.pkg
######################################################################## 100.0%
==> Verifying checksum for Cask mactex
==> Installing Cask mactex
==> Running installer for mactex; your password may be necessary.
==> Package installers may write to any location; options such as --appdir are ignored.
Password:
==> installer: Package name is MacTeX-2017
==> installer: Installing at base path /
==> installer: The install was successful.
🍺 mactex was successfully installed!
m:~ mvlkova$ brew cask install texmaker
==> Satisfying dependencies
==> Downloading http://www.xm1math.net/texmaker/assets/files/texmaker-5.0.1.dmg

curl: (22) The requested URL returned error: 404 Not Found
Error: Download failed on Cask 'texmaker' with message: Download failed: http://www.xm1math.net/texmaker/assets/files/texmaker-5.0.1.dmg
Error: Install incomplete.
m:~ mvlkova$}}

Output of brew cask doctor
{{m:~ mvlkova$ brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.3.1-4314-ge1bab7e
caskroom/homebrew-cask (git revision 73d46; last commit 2017-08-14)
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
/usr/local/Caskroom
==> Homebrew-Cask Cached Downloads
~/Library/Caches/Homebrew/Cask (1 files, 2.9GB)
==> Homebrew-Cask Taps:
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask (3690 casks)
==> Contents of $LOAD_PATH
/usr/local/Homebrew/Library/Homebrew/cask/lib
/usr/local/Homebrew/Library/Homebrew
/Library/Ruby/Site/2.0.0
/Library/Ruby/Site/2.0.0/x86_64-darwin16
/Library/Ruby/Site/2.0.0/universal-darwin16
/Library/Ruby/Site
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0/x86_64-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0/universal-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/x86_64-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/universal-darwin16
==> Environment Variables
LANG="en_NZ.UTF-8"
PATH="/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/Homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/bash"
m:~ mvlkova$}}

https://github.com/caskroom/homebrew-cask/pull/37647


All fields could be truncated

Currently if any of the fields other than remark are too long, they are not truncated which decreases readability. Truncating all fields would greatly increase readability and if there is any missing information, users can use the ViewCommand instead.

@colinhia Could also add a "comment" icon beside remarks while fixing this!


Cancel subscription after writing the object is complete for better completion signaling

Currently, the subscription is cancelled as soon as the response subscriber receives an end-of-stream object, before it is actually written. This makes sense from a reactive streams perspective, but we also have the concept of a completion future which is tied into the stream's lifecycle. When the subscription is canceled, the completion future is set to a cancelled state as well - depending on the stream's implementation, this could be synchronous, meaning the completion future is notified before the last write can even happen. If someone is listening for the completion future to do a cleanup type of thing, it might happen even though things were successful. This is the result of a slightly confusing correlation between the stream lifecycle and completion future.
This PR changes the response/request subscriber to only cancel after finishing their write. This allows the completion future to be completed successfully on stream close before the subscriber calls cancel, for cleaner semantics.
Admittedly, I'm not sure why this only seems to repro when the request is HTTP/1.0 (not 1.1), but it seems to be better behavior either way.

Thanks, @anuraaga !


Feature: Button close/open specific tree

Could be interesting to have a close/open button, if we have a big folder it is difficult to understand and navigate through next.nav
Therefore, congrats to the project. I'll use it all the time.

Hi, This idea seems interesting can I try to implement this feature ??

Hi Mustafa! We would love to have you contribute! Please fork this repo and make a pull request when you are finished. Please make the pull request to the dev branch. We can't promise we will merge your changes, but if they work properly we are happy to.


Poor latency?

Just based on the benchmarks here,
https://github.com/the-benchmarker/graphql-benchmarks/blob/develop/latency.md
I noticed that both frameworks using Fastify have high latency, especially fastify-gql. Is there some bias in the benchmark? Or, is this a limitation of fastify-gql?
Thanks

I’m not entirely sure what’s happening. It would be interesting to debug and verify where we are losing latency.
I would recommend the benchmark methodology to pre-heat all the JS implementation, as it takes some time for V8 to optimize.
I would also recommend to use the data loader pattern for finds and enable the jit option in fastify-gql.

I would recommend the benchmark methodology to pre-heat all the JS implementation, as it takes some time for V8 to optimize.

The test appears to run for 20 seconds. Is that not sufficient?

I would also recommend to use the data loader pattern for finds and enable the jit option in fastify-gql.

None of the other implementations use a dataloader pattern. I'm not sure if that would be a fair comparison.
Would setting the jit option to something like 1 or 2 suffice?

The test appears to run for 20 seconds. Is that not sufficient?

Run it twice, and take the second set of measurements. In my tests, 40 seconds provide more stable results.

Would setting the jit option to something like 1 or 2 suffice?

yes, that’d be ok.

Probably that "latency" stuff somehow related to this lines of code in benchmark: https://github.com/the-benchmarker/graphql-benchmarks/blob/develop/frameworks/fastify-gql/app.js#L72.
I don't know what's there latency shows, but here some of my results with k6:

It seems totally ok from your diagram.

@SkeLLLa
I was actually wondering if there were alternative benchmarks of fastify-gql I could look at. (Is there any more?) Thank you. That's interesting. What kind of data is going through there?
I notice http_req_duration max for JIT and non-JIT respectively: 1.01s 807.95ms. Everything else seems faster for JIT. The max and 95th percentile seem extremely disparate. Is this some database cache warming up or something?

@deklanw That "max" duration is caused because data is fetched from 3rd-party server. And it cause this "max" value. Later those values are cached for some time and we see performance of fastify-gql.
Data is ~1Kb with nested arrays and objects + couple data loaders.
As for other frameworks benchmarks - I just have my server and run benchmarks on it. And it's written using fastify-gql.

Got PR merged with jit enabled over on the benchmark. Rate and latency improved. And, anyway, I was misreading those rates as being in seconds not milliseconds. Silly! Comparing subms benchmarks is of course silly
Thanks for the help


[ETHOSN] Upgrade NPU driver stack to v22.05

In updating the driver stack to v22.05 some additional things needed changes:

Prevent split being offloaded to the NPU which is not supported in
v22.05.
Removes compile algorithm configuration option since this was removed
in v22.05. Versions before v22.05 will use the default option.
Managing some API changes.
Updating network compile hashes.
Updating expected error message for overall scale bounds check.

cc @Leo-arm

@tvm-bot rerun

@tvm-bot rerun

friendly ping for review. also cc @manupa-arm @leandron

friendly ping for review

Thanks @manupa-arm!


Change dart lsp server

Hello,
It appears that the dart-sdk now ships its own lsp analysis server so the current option has become obsolete. The new command is something like:
dart path/to/dart-sdk/bin/snapshots/analysis_server.dart.snapshot --lsp

I tried to get it working on my machine but since I'm relatively new to kakoune in general, I've had no luck. I tried aliasing it to dart_language_server and deactivated the old command, but it didn't seem to work. Any help would be appreciated.
Thanks.

kak-lsp interprets the entire string as one command. Use the args item as follows (with correct dart-sdk path):
[language.dart]
filetypes = ["dart"]
roots = ["pubspec.yaml", ".git"]
command = "dart"
args = ["/opt/dart-sdk/bin/snapshots/analysis_server.dart.snapshot", "--lsp"]

Works for me with kakoune 2019.12.10, kak-lsp 7.0.0, Dart 2.7.0.

Sorry for the late reply, and for the late close.
Thanks for the fix @mogenson


WIP: Converting to generics proof of concept

NOTE: This is not to be merged until generics make it into mainline go, and even then care will have to be taken with versioning so clients without generics will still be able to compile.
I wanted to test out the generics proposal for go (https://go.googlesource.com/proposal/+/refs/heads/master/design/go2draft-contracts.md), and I thought a good exercise  would be to try to convert some code into generic code.
Below is a "working" example, which can be run like this (following instructions here: https://go.googlesource.com/go/+/refs/heads/dev.go2go/README.go2go.md)
luke@Lukes-MacBook-Air go-cache % ~/goroot/bin/go tool go2go run cache.go2
Hello world

Caveats:

This is embarrassing but I couldn't figure out how to run this code directly without temporarily changing the package name to main. I tried to put it into ~/go2/src and import it into a client project, but it complained about not being able to reference private field .cache, see caveat 2. Maybe there's a different way to do it, or maybe caveat 2 has to be addressed first.
I'm not sure if this is the go2go tool, but for some reason the go2 code needed to address the .cache field of Cache directly. For example, in my small client implementation at the bottom of cache.go2, if you replace c.cache.Set with the appropriate c.Set you get this compilation error:

cache.go2:1146:2: type *Cache(string) of c does not match *cache(T) (cannot infer T)

In general, I don't quite understand how all the methods here are able to be about cache and not Cache, I guess there's some sort of magic since cache is the only value in the struct? However it happens, it looks like that's not working in go2.
3. I needed to define ItemMap in lieu of map[string]Item due to a limitation in complex inline types in generic go. I asked about this in the go slack (https://gophers.slack.com/archives/C88U9BFDZ/p1598134017011500) and was told that this is the only option.
4. The runtime.SetFinalizer didn't work as is, perhaps the same issue as caveat 2, maybe some other thing, I pulled it out for now.
5. I commented out all the Increment code; I'm not sure the best approach here. Maybe some sort of IncrementableCache, but that seems to defeat the purpose of generic code :) I wonder if there's a way to define these methods and have client code fail to compile if they try to call Increment() on a cache they set up with e.g. strings or something?
6. I haven't touched the tests or the sharded file, other than to rename them to .go2 which is required by the go2go tool.

Closing in favor of #147


Unable to ping pods between each other over non-default service record for k8s 1.21 cluster

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):
TL;DR - pods in one namespace cannot be pinged between each other over custom dns record pointing to a workload - pings are passing over records created automatically when you deploy a deployment. The same testcase described below is working fine on custom RKE1 cluster with k8s v1.20.7-rancher1-1 deployed in the same local cluster.
Reproducer:

deploy custom RKE1 cluster with k8s v1.21.1-rancher1-1 on single node with all roles under local cluster running rancher/rancher:master-head 7d7dd99 (on RKE1 with k8s v1.20.6)
on the downstream cluster deploy busybox1 deployment in default namespace, enter busybox container image end specify Command: /bin/sh -c "while true; do echo blah; sleep 1; done" - do not expose any port
clone the busybox1 deployment and name it busybox2
create arecord custom service in default namespace under Default project->Resources->Workload->Service Discovery, select Resolves To:->One or more workloads bullet and point the dns entry to busybox2 deployment/workload.
Execute shell in busybox1-xxx pod and perform: ping arecord - it will return error ping: bad address 'arecord'

Result:
/ # ping arecord
ping: bad address 'arecord'

/ # ping arecord.default.svc.cluster.local
ping: bad address 'arecord.default.svc.cluster.local'

/ # ping busybox1
PING busybox1 (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=64 time=0.052 ms

/ # ping busybox2
PING busybox2 (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=64 time=0.026 ms

/ # ping busybox1.default.svc.cluster.local
PING busybox1.default.svc.cluster.local (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=63 time=0.054 ms

Other details that may be helpful:

The very same test case is working fine on RKE1 cluster with k8s v1.20.6
default DNS entries created automatically for deployments are working
seems to be similar to v1.21 k3s issue https://github.com/rancher/rancher/issues/32329

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): rancher/rancher:master-head 7d7dd99
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): custom
Machine type (cloud/VM/metal) and specifications (CPU/memory): any
Kubernetes version (use kubectl version): v1.21.1-rancher1-1

Feature gate IPv6DualStack for IPv4/IPv6 dual-stack networking is enabled by default for 1.21 kubernetes cluster. But cluster needs to meet a few requirements and configurations before it works correctly.
So we're going to disable the feature flag by default in Rancher k8s 1.21.

Available to test with RKE v1.3.0-rc6 and rancher master-head once build passes, https://drone-publish.rancher.io/rancher/rancher/5709

Blocked by https://github.com/rancher/rancher/issues/32801

Available to test once build passes https://drone-publish.rancher.io/rancher/rancher/5719

Test report:
Tested on rancher/rancher:master-head 5715b8a on RKE1 custom cluster with v1.21.1-rancher2-1.

For any workload the corresponding services with deployment name are created automatically
I was able ping pods from each other over automatically created services for the workload by using ping <deployment name>
I was able ping pods from each other over custom service as described in summary

Only problem I found is that services which are created automatically for the workload are not getting removed once the workload is removed, I opened new issue https://github.com/rancher/rancher/issues/33178
This is working ok. Close.

Disabling Feature gate isn't the ideal way to resolve this, since it is enabled by default in upstream.
We need to take a look into what is UI/API passing to create service and figure out what we're doing different than services created by default in Rancher or a v1.service created using kubectl.

This is caused by this:
Headless Services without selector
For Headless Services without selectors and without .spec.ipFamilyPolicy explicitly set, the .spec.ipFamilyPolicy field defaults to RequireDualStack.

Note: once this will be out there shoudn't be --feature-gates=IPv6DualStack=false arg used for kube-apiserver process on nodes (on RKE1 with v1.21 and eg. Canal CNI)

There is no sign of --feature-gates arg for kube-apiserver process on single-node RKE1 cluster with k8s v1.21.1-rancher2-1 provisioned on local rancher/rancher:master-head cd623b5 anymore.
The services are created automatically for a deployment defined in Ember UI and I was able to perform ping from one deployment/pod to another by ping <anameofdeployment>
But custom services created in EmberUI which are pointing to a workload (used Resolves to: One or more workloads) are not working again, a new issue was opened in meantime https://github.com/rancher/rancher/issues/33755 for this.
BTW if I create a service with Resolves to: Alias of another DNS record's value the ping is working.

The root cause is still the same as https://github.com/rancher/rancher/issues/33085#issuecomment-867835847, although I'm seeing in the current requests for creating a service, that ipFamilyPolicy is not empty but actually set to the default in Kubernetes (RequireDualStack). Instead of fixing this in the backend, I would add the configurable field ipFamilyPolicy to the service creation page and have it default to SingleStack so it works by default and if people want to create dual-stack service records, they can change it.
If we do want to fix this in the backend, we need to detect if the cluster is properly configured for dual-stack, which will then determine if the service record is going to be SingleStack or RequireDualStack.

@gaktive Is this something you can discuss if this could go into the UI?

I don't know the whole story here, but the UI making up a default that is different than the actual API's default (and us turning off features that are in by default?) is fairly unusual...

The feature gate IPv6DualStack was enabled by default in v1.21, even though no dual stack configuration exists. We follow upstream, but having that feature gate enabled, causes headless services to default to dualstack while there is no dualstack configuration. So as it needs to be configurable anyway (user can choose what service he/she wants to create), we can add it and default to singlestack and advanced users (I would mark dualstack as advanced currently), and it will solve the issue.
We can also take it a step further back and disable the feature gate but that was the first fix and reverted as we needed to follow upstream.

This isn't a viable fix for K3s and RKE2. We are going out of our way to allow for dual-stack operation; telling people to rebuild their cluster with dual-stack disabled to run Rancher isn't going to fly.

I tried according to the reproducer in summary on rancher/rancher:master-head 94bca99 and RKE1 downstream cluster with k8s v1.21.1-rancher3-1 and the custom services are still not reachable. I could reach only pods over their automatically created services by ping <deployment name>.
Reopening.

@thehejik Please validate with a newer version of mater-head

Verified on master-head 76b0695

Manually created two workloads
Created a Service discovery for one of the workloads
Pinged the SD from the other workload and works fine

Blocked by https://github.com/rancher/rancher/issues/33755 for other validations.

Anything created through the Ember UI is validated as working. The part that is currently stuck is that we have automated tests that use type: dnsRecord that has been removed from using in the Ember UI since a while (https://github.com/rancher/ui/commit/1ed161e60c2282e7e18a058838b58410a205aecc) that create Service recources that are not going through the Store that we modified to make this work. Currently looking into the dnsRecord functionality.

Available with c5b24bff8f4c29b71de49a783dc2764953b3116a

Verified on master-head f04ae9f
DNS resolution for the service discovery pods is working as expected
Validation tests run via automation have passed.


Modal onRequestClose won't fire on tvOS when in "Release" mode

Modal onRequestClose gets called on tvOS only for "Debug" scheme, for "Release" one it just doesn't seem to fire.
My app is behaving as expected when I'm in debug mode but not on an actual device installed via TestFlight.
Environment
Environment:
OS: macOS High Sierra 10.13.3
Node: 8.9.4
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.9.1
Xcode: Not Found
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: ^0.54.0 => 0.54.0
Expected Behavior
onRequestClose should be called for the Modal component wether the scheme is "Debug" or "Release"
Actual Behavior
onRequestClose isn't called for the Modal component when the scheme is "Release"
Steps to Reproduce
Repo: https://github.com/psegalen/rn-tvos-modal-bug
Steps:

Get the code, run it in Apple TV simulator with XCode
If you press the touchable, the modal shows, if you press the Apple TV remote's menu button, it hides, it's ok but onRequestClose isn't called (you can see that because the state hasn't changed, isModalOpen remains true)
If you do the same test after switching the "Run" scheme to "Debug" in XCode, you'll see that the behaviour is correct since the state is correctly changed (isModalOpen become false after closing the modal)

I can reproduce this in a debug environment as well.  Looks like the native setOnRequestClose in RCTModalHostView isn't setting the required menu key gesture recognizer, because _reactSubview doesn't exist at the time this is called.  Investigating.

Tested this today by creating a new project with latest master code:
react-native init --version=https://github.com/facebook/react-native rnTvosModalBug
and copying in the same code provided by @psegalen .
The issue is no longer reproducible for me.  @psegalen can you please try?

Hi @dlowder-salesforce, I just tried what you described, the behaviour is still the same: isModalOpen is still true when pressing the remote Menu button.

I'm currently dealing with this, too. But when creating my own view that fades in, the nested Flatlists (a grid of videos) is still scrollable below the new "modal". Did you have any issues like this? I don't know how to disable the navigation below the modal.

Actually, I just tested it, and after setting the visible prop to true (permanently), I'm still able to dismiss the modal with the menu button. So the normal "close on visible=false" behavior is being short circuited.


feat: port Data.Finsupp.Multiset

Nothing works anymore when AddEquiv.symm comes into play, and I am not sure why. I still have faith that #1219 could help out with this, but I don't know if that will ever see the light of day :(

@LukasMias should the top comment be updated? It becomes the commit comment after merging...

@LukasMias should the top comment be updated? It becomes the commit comment after merging...

Whoops, forgot about that one. Yeah, things were not quite as grim as I initially thought. Some rfl proofs needed to be explicitly spelled out. Thanks!


Articles don’t open on iOS

https://github.com/msasikanth/twine/assets/2178959/5b1263d8-f60c-4f09-9471-843b20ea6e4d

Can you share a link to this feed, please?

Weird, I have found the blog and added it. But it's opening it fine for me. For debugging purposes, by any chance you don't have Safari on your device? or what's your default browser?
If you can provide me the OS details as well that would be extremely helpful @SebastianAigner 🙏🏾
https://github.com/msasikanth/twine/assets/6140516/a1dbc5a5-30d2-4939-aa9e-8ed40b5c40d3

iOS 17.1, I have Safari installed. Seems to only be the case if the blog in question is the only feed added. When other feeds are added, it works mysteriously.

Oh, that's an interesting bug. Let me look into it further 👀


feat: factor out fs calls into axoasset

Culmination of the work that started with the 0.2.0 release of axoasset, which is to remove straight fs i/o calls from cargo-dist and put them in axoasset instead. Omits the templating things for now until we have a consensus on that.
Closes #221.
Needs testing, I haven't had enough time for that yet.

Closing in favour of #295, thanks again for doing this all!
(Some fs calls will remain, but they're in components that are getting rewritten anyway with #283 and https://github.com/axodotdev/axoproject/pull/26)


Time sweep speed - indicator

User story

As a user
I want the current time sweep speed of each channel
So that the user can understand the current sweep speed

Acceptance criteria

[ ]  The values should be shown on the right side of time sweep slider
[ ]  Text should be clearly visible under all browser settings ( Dark and light mode).
[ ]  Should possess correct units(eg. secs/div).

Definition of done (DoD)

[ ]  Feature/Bug/Change has been implemented

[ ]  Application compiles successfully

[ ]  Code is documented

[ ]  Feature/Bug/Change is tested by at least one unit or e2e test

[ ]  Tests have been passed without warnings (except "deprecated" warnings)

[ ]  Changes have been reviewed

[ ]  PR has been merged to dev branch

[ ]  New dependencies have been added to bill of materials

[ ]  Software archticture diagram has been updated

[ ]  All acceptance criteria are fullfilled

[ ]  Screenshot is attached to issue

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

The displayed sweep speed still not matches the actual sweep speed.
The indicators display 5ms/div (with 1 div is one grid block)

The real sweep speed feals more like 1 sec for 2 div, but that's not an correct measure, more like gut feeling


"verbatimModuleSyntax": true causes import {type} from '@remix-run/node' to run on the browser

Reproduction
https://github.com/justintoman/remix-node-bug
Copy/pasted from the README.md in that repo 👆

npm create vite@latest

Pick React and Remix

In tsconfig.json, add "verbatimModuleSyntax": true
In _index.tsx change the import type for the @remix-run/node import to be inside the braces

❌import type { MetaFunction } from "@remix-run/node";
✅import { type MetaFunction } from "@remix-run/node";

Steps to reproduce

npm install
npm run dev
Go to http://localhost:5173/
Open the browser console and see:

@remix-run_node.js?v=e931bf82:1543 Uncaught ReferenceError: process is not defined
    at node_modules/util/util.js (@remix-run_node.js?v=e931bf82:1543:5)
    at __require (chunk-WXXH56N5.js?v=4a3845ee:12:50)
    at node_modules/stream-slice/index.js (@remix-run_node.js?v=e931bf82:7121:16)
    at __require (chunk-WXXH56N5.js?v=4a3845ee:12:50)
    at<EMAIL_ADDRESS>(@remix-run_node.js?v=e931bf82:7318:23)
    at __require (chunk-WXXH56N5.js?v=4a3845ee:12:50)
    at<EMAIL_ADDRESS>(@remix-run_node.js?v=e931bf82:7506:29)
    at __require (chunk-WXXH56N5.js?v=4a3845ee:12:50)
    at @remix-run_node.js?v=e931bf82:7608:16

System Info
System:
    OS: macOS 14.3.1
    CPU: (12) arm64 Apple M3 Pro
    Memory: 106.95 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    npm: 10.4.0 - ~/.nvm/versions/node/v20.11.1/bin/npm
    bun: 1.0.29 - ~/.bun/bin/bun
  Browsers:
    Chrome: 122.0.6261.94
    Safari: 17.3.1
  npmPackages:
    @remix-run/dev: ^2.8.0 => 2.8.0
    @remix-run/node: ^2.8.0 => 2.8.0
    @remix-run/react: ^2.8.0 => 2.8.0
    @remix-run/serve: ^2.8.0 => 2.8.0
    vite: ^5.1.0 => 5.1.4

Used Package Manager
npm
Expected Behavior
@remix-run/node should not make it into the code run by the browser
Actual Behavior
It does get into the browser, which causes an error when process doesn't exist.

It looks like if there's additional non-type things in the import, then the bug doesn't happen.
E.g.
import {json, type LoaderFunctionArgs} from '@remix-run/node'`;

That doesn't seem to do it. It's only when there's only type imports and they're inside the braces. I know it's potentially silly to write it that way, but this happened in my project after I refactored a route to still need LoaderFunctionArgs but it no longer needed to import json and redirect.
The import used to be
import {json, redirect, type LoaderFunctionArgs} from '@remix-run/node';

And then after removing those two, it became
import {type LoaderFunctionArgs} from '@remix-run/node';

In any case, this still seems like a bug. But hopefully this will help other people that run into it.

You can either disable "verbatimModuleSyntax"
Or you can change your import statements to have the type on the outside of the braces.

Supper annoying issue which for me doesn't give any errors except that route navigation doesn't work.


Include URI in traceback if filename is unknown

Using URIs as entrered will make the stack trace arguably more readable than
using the module name which is the URI with non-word characters replaced by
underscores.
This change also fixes a mistake where a mods cache hit would not update
template_filename, causing a stale filename to be displayed if the stack
trace alternates between different templates.  There now is a test case for
this.

interesting ill have to understand the "alternating file" issue more, is it just that the file was <memory> or something generic?

New Gerrit review created for change e913228dd39829197d5a9e9927122cb0ae357528: https://gerrit.sqlalchemy.org/#/c/sqlalchemy/mako/+/1339

Regarding alternating problem: If your stack trace had first base then foo then base, the first encounter of base would be a cache miss, would compute stuff including template_filename, and write some of that to the mods cache but not the template_filename. Next foo would do the same. Next base again would be a cache hit, reading stuff from cache but not the template_filename. So that would remain at its previous value, namely the one for foo. You'd end up with a stack trace that cites a line from base but claims it came from foo.

Patchset ea35208d504932561711cdb574ec1f7def1e7060 added to existing Gerrit review https://gerrit.sqlalchemy.org/#/c/sqlalchemy/mako/+/1339

mike bayer (zzzeek) wrote:
Code-Review+2 Workflow+1

Gerrit review https://gerrit.sqlalchemy.org/1339 has been merged. Congratulations! :)


Document dashboard and Data explorer controls

We need to document the controls on dashboards in the UI and in the Data Explorer. For example:

Timezone selector
Visualization type selector
Visualization control toggle
View raw data
etc.

Resolved in control dashboards doc


Keep the calendar when modifying an event

It is kind of annoying that when i modify the title of an event i have every time to reselect the calendar in which it is already contained

Thanks for submitting @ascsanto -- this is definitely a bug. I'll add this to the "waiting for bugfix" milestone!

Duplicate of #142


New-TppCertificate customfield value

For our certificates, we are using 3 custom fields.
It would be great to have such an option to set custom fields in some hash table when creating certificates.
For example, the jiraps module has such a feature.
Or perhaps this already has it and I just can't find it.
Thanks.

Hi @fearnie85.  You should be able to use New-TppCertificate -PassThru | Set-TppAttribute -Attribute $myHash.

Oh that is perfect!!! Thanks a lot!

Resolved.


Is 22.03.0-rc1 ready to test?

I just received my seed router and I would like to put it to work with a stable openwrt version.
Has anyone tried it with https://downloads.openwrt.org/releases/22.03.0-rc1/targets/bcm27xx/bcm2711/ ?
I'm kind of new to flashing and things.

Hey @ieugen IIRC stable release now 21.02, please try it first.
Once I have time I will check release 22.03

Good morning,
I just loaded both the new 21.02.3 & 22.03.0-rc1 and noticed that for some reason the driver is not compiled for 21.02.3 and is not found in the stock image.
22.03.0-rc1 however, has everything on board and loads the driver at first boot.

root@OpenWrt:~# lsmod | grep lan
lan78xx                40960  0

Hey @stynoo, that is great news.
Looks like in next release 22.03 there is no need to compile lan78xx driver manually.
Thanks for this check.

Cool. thanks @stynoo .
Anything special needed to be done for 22.03-rc1 ?

@ieugen please try this release and let us know if the instructions are still actual

Ok. I will once i get a jumper to boot the board for firmware update.

Cool. I usually use a paper clip for this :)

Cool. I usually use a paper clip for this :)

Some advanced tech you got there.
I don't know if I can get my hands on it :smirk:

Anything special needed to be done for 22.03-rc1 ?
Nothing special besides expanding the /dev/root partition.   Both network ports & wireless are working.
But to be completely transparent: I didn't test any other interface (bt, gpio, spi, ...)

Hi, I'm trying too boot the device so I can flash it but no success so far.
Does any of you know what's going on?
I compiled usbboot locally and started rpitool.
I've connected the device to USB-C on my computer and device - also USB-A on my computer and USB-C on device.
I see some activity but nothing happens.
The device is flasshing 8 thimes green led and then pause and repeats.
usbboot$ sudo ./rpiboot
RPIBOOT: build-date May  3 2022 version 20220427~095022 54a0395d
Waiting for BCM2835/6/7/2711...
Loading embedded: bootcode4.bin
Sending bootcode.bin
Successful read 4 bytes
Waiting for BCM2835/6/7/2711...

Hey @ieugen,
Are you sure that enabled programming mode before running rpiboot tool ?
After this
RPIBOOT: build-date May  3 2022 version 20220427~095022 54a0395d
Waiting for BCM2835/6/7/2711...
Loading embedded: bootcode4.bin
Sending bootcode.bin
Successful read 4 bytes

You should see new storage device mounted in your OS ready to be flashed.
Please use this instruction for flashing new openwrt release to your device.

hi @sergey-brutsky ,
Yes.

started rpitool
connected wire between GND and BOOT
connected USB-C to power

Waited for about 3-5 min.
Nothing changed on the screen.
I pushed the reset button on the board and this cycled again.
I also read this guide: https://www.jeffgeerling.com/blog/2020/flashing-raspberry-pi-compute-module-on-macos-usbboot

Seems strange, I've tried instructions for macos and mini router without any issues.
Could you please file a bug to seeedstudio team repo ? Maybe they can shed some light on this.

So I managed to flash my router and will begin testing it soon.

One of the first things I noticed is that a bridge is created for both eth's .
Only the bridge has IP address.
Looking at how to change this.
I had to reflash it once because I messed up the networking :).

One of the first things I noticed is that a bridge is created for both eth's .
IIRC openwrt by default creates network bridges even if there is no need for that like in our case (1 lan, 1 wan).

Looking at how to change this.
Just remove the bridges and create interfaces on top of network devices (eth0/eth1/etc)
IP addresses assignment procedure is the same

Imho there is no need to change this, by default there is a br-lan (as with any other openwrt image I rolled out), but only eth0 is part of the bridge.  The bridge is already setup with IP, dhcp, firewall zone, ... and easy to expand with WLAN or other usb based interfaces.
The only thing you need to do now is creating a wan interface on device eth1 with a dhcp client (or whatever your ISP requires) and assign it to a wan firewall zone.

@ieugen could you please confirm that second network adapter and wifi modules are working out of the box  in release 22.03.0-rc1 ?
Is yes we can close the issue.

I can confirm Wi-FI module is working out of the box - but it's disabled so you have to enable and start it from web interface (or cli).
I don't know if the second adaptor works (wan).
While setting up the router, I notice WI-FI signal is weak so I ordered an antenna and will continue once that arrives.
I will set it up and close the issue then since I am not at home yet.

Hey @ieugen,
Just ssh into your board and run the command  ip l | grep -E 'eth0|eth1'
If you see something like
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
9: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000

It means that both network adapters are enabled and working

Hi guys, no worries, it works out of the box (ofc you have to config something according to your setup).
root@OpenWrt1:~# ip l | grep BROAD
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq master br-lan state UP qlen 1000
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc cake state UP qlen 1000
4: wlan0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel state DOWN qlen 1000
8: br-lan: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP qlen 1000
21: ifb4eth1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc cake state UNKNOWN qlen 32

I have 22.03-rc1 now running as my main router and only had to use the commands to expand / from your procedure.

Cool, looks like we've done with this issue.
I will update instructions in the doc accordingly

I started using the device just now.
I did a speed test and I got 90 Mbps on a 300 Mbps connection.
The PI is connected to the a gigabit switch that is connected to the ONT - HG8143 I believe.
I will keep it up for a day or two an ask for the ONT to be connected in "bridge" mode with disabled wireless.
I will run the tests again then.

I switched my ONT to bridge mode and using OpenWRT as main driver.
So it seems that I can't make wifi work in N mode - 2.4 Ghz.
I have a bunch of network IOT devices + printer that require 2.4 GHz.
Will report more once I uncover them.

Don't forget that you are using a release candidate firmware and that you are encouraged to report issues back to the project (for openwrt that is here)
As for speedtests: what I can report is 276Mbps on a 300Mbps line capped to 285Mbps by QOS.  You can't rely on wifi connections to test your bandwidth.
Also, if a stable and performant wifi connection is important, don't rely on the wifi chip that comes with the pi4.

Thanks @stynoo , I am just reporting things as I see them - in hope they are of use to others.
I'm using an older router also with OpenWrt as a dumb AP.
I only wished I had a single device instead of two.
I am happy with the setup otherwise.

From my experience it's very hard to achieve good wifi and routing performance by using the same device for everything.
seeed carrier board is really good for routing/firewaling/dhcp/running not cpu consuming dockers.
For serving wifi it would be worth considering a separate device (or a set of devices) working in AP mode.

@Izaic what do you mean by the latest firmware ? Which version ?
IIRC starting from version 22.03.0-rc1 the second LAN adapter and wifi should be working because support has been added in this PR

Has anyone successfully tried an ext4 sysupgrade from 22.02.x to a 22.03.0-rcx version?
When I try go sysupgrade via either luci or cli it goes through the process, looks like it work, the cm4 reboots, and I am back running the version that I started from.
I wonder if this has something to do with the eMMC not cooperating with the sysupgrade process.
Sorry to hijack the issue but it seems related and I'm not getting answers from either seeed or the openwrt channels.

Good afternoon @K2IE.  I had the same experience with earlier upgrades and always had to revert to the 'rpiboot/connect cables and flash from pc'-method to do an upgrade.
However, it seems that things changed since 22.03.  I just did and upgrade from 22.03.0-rc1 to 22.03.0-rc5 via sysupgrade over ssh and the seeed mini router happily rebooted with the new version.

wget the image
verify with sha256sum
sysupgrade -v imagefile (don't forget to make a backup of your settings if needed)

I'll test upgrading from Luci when the next sysupgrade package arrives.

Thanks for all the instructions folks, and for the hard work getting the drivers in @sergey-brutsky. I successfully booted my CM4 and board off of the latest release candidate and see eth1 and eth0 after encountering a boot fail issue with Seeed builds https://github.com/Seeed-Studio/seeed-linux-openwrt/issues/31


Added support for psutil version 6.0.0

Added support for psutil version 6.0.0 where connections is removed and should use net_connections.
Fixes: #44

Done in fixed_actions PR


Remove pylint-django from VITAL_BUT_UNKNOWN

Ref https://github.com/PyCQA/pylint-django/pull/337

Description

Remove pylint-django from VITAL_BUT_UNKONWN
Checklist:

[ ] I've made sure that tests are updated accordingly (especially if adding or updating a template option)
[ ] I've updated the documentation or confirm that my change doesn't require any updates

Rationale

pylint-django now includes trove classifiers for django.
Ref: https://github.com/cookiecutter/cookiecutter-django/pull/3288#discussion_r747603786
Ref https://github.com/PyCQA/pylint-django/pull/337

Thanks. Let's keep an eye on django-environ as well.


[thisvid] Add extractor

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of some of this code and I am willing to release it under Unlicense
[x] I am not the original author of the rest of this code but it is in public domain or released under Unlicense

What is the purpose of your pull request?

[x] New extractor

Description of your pull request and other information
This merges several versions of this extractor sent to the original yt-dl project, and adds a couple more fixes on top for subsequent site updates:

#20940
#21651
#26060

The rest of this code was written by @rigstot. Both of us, in those PRs, dedicated this code to the public domain.

Hmm, it seems something went wrong in the patch apply to hook the extractor in, because it's considered generic. I thought I tested that. I'll figure it out.

Doesn't #549 replace this?

After doing more tests, your are correct, @MinePlayersPE. It seems the video I tried to test generic with has another problem which is specific to that URL.
Closing.


libvpx: fix cross-compilation

This is done by removing some warnings that are not supported by the
cross-compiler.
We also need to disable the --enable-external-build flag, which breaks
the build completely.
This PR: https://github.com/NixOS/nixpkgs/pull/100210 added the flag,
but it doesn't explain why it was added. It also doesn't show any
attempt at trying to cross-compile for either darwin or aarch64. So
let's remove it again, since it 'just' seems to break the build anyway.

Motivation for this change
Support cross-compilation for libvpx, which is a dependency of ffmpeg.
I've tested building this with nix build .#pkgsCross.aarch64-multiplatform.libvpx, which works. With https://github.com/NixOS/nixpkgs/pull/123915 applied, ffmpeg now also cross-compiles for aarch64-multipllatform :).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This reverts a change made in https://github.com/NixOS/nixpkgs/pull/118783. @TredwellGit do you have any idea why the --enable-external-build flag was added there? It doesn't seem like you attempted a cross-build (looking at the PR at least), but maybe you did?

I added it because https://github.com/NixOS/nixpkgs/commit/1859b5a5aee9b39db2120685a36f1d60e0236394 did. Please remove it along with the other commented out flags.

Thanks for the review. I've updated the PR to remove the commented out flags and to be more specific on which files need patchShebangs. Let me know if there's anything I can improve.

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches  and squash the fix-up commits.
git rebase -i is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

Squashed the commits together. I thought the commits I made were separate enough to warrant a commit each, but this is ok for me too, so let's do it.

Note that libvpx_1_8 still doesn't cross-compile, but only firefox depends on it, so I think it's less of a priority.
That's also the reason why I didn't remove the --enable-external-build flag, it doesn't help anyway.

nix-build -A pkgsCross.aarch64-multiplatform.libvpx build for me.


Merge with sphinx_rtd_theme

I just realized that our copy of sphinx_rtd_theme is essentially forked and we're missing some key updates, i.e this fix which allows the search bar to actually work: https://github.com/snide/sphinx_rtd_theme/commit/a5e0e304d30ed7aa1eacc6cca04514913b8d2385
For now let's just merge that commit and worry about the rest later.

For now we can pull the commit as a patch and apply it. Instructions:
git remote add -f sphinx_rtd_theme https://github.com/snide/sphinx_rtd_theme/
git format-patch -k -1 --stdout a5e0e304 | git am -3 -k


Get the context data

Hello,
Thanks for sharing your work!
I am conducting some experiments with your code and trying to evaluate hallucinations and other metrics. However, I have tried everything to get the {context} to be returned at result = final_chain.stream({"question": question, "memory": memory, "context": ??}). This way, it would be possible to make such evaluations, especially since I am using LangSmith.

I tried to get this from _combine_documents, but it print empty.
I tried to creat a global variable with to return the join in _combine_documents function.
Also, I tried using the final_inputs['context´], but it shows <function getStreamingChain.. at 0x7fef02fcd000> and not the data.

Do you have any idea that could help me? Thank you very much and I sorry if this is inpleasant.

Typically, I would be more than happy to help you experiment with the code to get what you need. However, this week is extremely busy for me, so I apologize for not being able to help further. Nevertheless, here are some ideas (which could be completely wrong):
The UI and CLI use different functionality. The UI is more focused on streaming, while the CLI also streams but continues to produce the final results. You can see this here: https://github.com/amscotti/local-LLM-with-RAG/blob/main/llm.py#L129
I believe the items retrieved from the vector database are in the results. Again, I'm not 100% sure without opening up the project, but I do know that at one point, I had the documents displayed in the results.
Another approach you could take is to add your chain after the documents are retrieved, record the context, and then pass the information on to the rest of the chain.
I'm not sure of the scope of your project or what you're trying to find out, but I can tell you with certainty that even with context from RAG, LLMs are still able to hallucinate. Also, the RAG implementation in this project is quite arbitrary; there are better approaches discussed online to help decrease hallucinations. If you are just trying to gather data, and this particular code does not matter, maybe a project like https://www.promptfoo.dev/ or https://www.trulens.org/ would be better at evaluating the return from an LLM.
If not, at some point next week, I can dig into this a bit more and provide code examples if you still can't get the context.


Errors not handled on the amount input

Errors not handled on the amount input

Wrap functions that get triggered on input onChange in a try/catch to handle error with a toast instead to let un-handle error pop up with the ugly next error
Add support for decimal amount

Like the validation, but in some cases it prevents the users from changing valid inputs, please have a look and lmk what you think:
https://github.com/subspace/staking-interface/assets/66026548/63899760-bf9e-4a10-af09-acfb544bd776


bump rust branch

Okay after scratching my head for a while i figured it out, turns out you have to go into the rust directory and manually change what ver is checked out. this seems a bit tedious if things are changed in the future, maybe the url's in git submodules should be changed to track the git repo / branch so this happens automatically (as far as i know this is how it should work?)

can confirm it works!

Ah, right, so the bump of the rust commit is blocked on me merging in another PR that I'm working on. As a work around until then, if you change the .gitmodules in rust so the backtrace URL uses https, that should work locally. Once the change that makes the newest rust commit compile is merged, i'll bump the version.
This is generally how submodules (can) work -- that the actual commit is locked, and the branch can move forward. This allows independent development on the repos without causing compile errors (which is the reason just bumping the rust version here will cause the toolchain to fail to build).


Add help docs on connectivity issues

It's a common problem for newer players with firewalls or parental controls on their systems to have connection issues to the server list or servers. There should be an official doc with common troubleshooting steps per OS.

I would be willing to write documentation on the subject.
Is there any specifications I should be aware of?

@blast007, mind chiming in on common Windows troubleshooting? From memory, I just know things like Net Nanny and Windows Firewall have caused issues. Sometimes antiviruses too...? What were some solutions to these things?
For macOS, the only things that come to mind would be the macOS firewall and programs like Little Snitch.

For Net Nanny, you are able to connect, send messages, and even spawn and play. But as soon as you shoot you get disconnected for not using UDP. Note that it might vary depending on Net Nanny's settings.

Windows Firewall in Windows 7 seems to be a joke.  I can join a server and play like normal, only to close the client and see a "Do you want to allow BZFlag to access the Internet?" dialog.  Yeah, I think it was doing that just fine, Windows Firewall...  Maybe it's better in later Windows versions.
Ten years ago, at least, NOD32 would incorrectly identify BZFlag as a web browser (because of our initial HTTP connection to get the MOTD) and would then block any UDP traffic (because why would a web browser need UDP!).  I do not know if this still occurs.

My apologies for the late notice.
I will likely be unable to complete documentation on connectivity issues due to time constraints.
Recommending someone else be found to complete it.


Eventually move to JuliaPOMDPs and rename to Crux.jl

Mykel and I agree this fits nicely into JuliaPOMDPs (as opposed to sisl or here). No rush, of course—we'll want to stress it and let it mature a bit before we bring it over. Thoughts?

Yeah sounds good! The main thing I want to do before making it more public is write up some documentation for the API as well as a github.io page like https://juliapomdp.github.io/POMDPs.jl/stable/.

Yeah sounds good! The main thing I want to do before making it more public is write up some documentation for the API as well as a github.io page like https://juliapomdp.github.io/POMDPs.jl/stable/.

Documenter.jl is excellent for this (that's what POMDPs.jl is using, and I've used it for POMDPStressTesting.jl as well).
https://sisl.github.io/POMDPStressTesting.jl/dev/

Documenter.jl is excellent for this (that's what POMDPs.jl is using, and I've used it for POMDPStressTesting.jl as well).
https://sisl.github.io/POMDPStressTesting.jl/dev/

Do you mind if I move Crux and POMDPGym to the sisl Github sometime next week? I'd also like to register them with General so I can use them in my POMDPs.jl Julia Academy course, but understand the hesitation mentioned above (i.e. documentation before public release)

Shall we go ahead and move to this to JuliaPOMDP @ancorso and @mossr ?


Minimap does not update background correctly

When no minimapBackground color is defined minimap._getMinimapBackground get the background color from the MinimapTokensColorTracker
When debugging this I saw that onThemeChanged is called before before the MinimapTokensColorTracker is updated, so _getMinimapBackground read the old colors.
Is could listen to MinimapTokensColorTracker.onDidChange or invalidate the MinimapTokensColorTracker when it gets the onThemeChanged

Just FYI, here's how the MinimapTokensColorTracker gets updated:
workbenchThemeService.onDidColorThemeChange -> abstractTextMateService._updateTheme -> TokenizationRegistry.setColorMap -> TokenizationRegistry.onDidChange -> MinimapTokensColorTracker._updateColorMap
I wonder if that can be simplified now that the theme service is creating and updating the colorMap.
Also, when the minimap gets the editor background color, it could actually just ask the themeService: themeService.getColor('editor.backgroundColor').

@aeschli Can you please provide some repro steps, I am pushing a change that I hope might fix things, but I honestly can't tell due to the high complexity.

The steps are:

open a codespace, make sure it does not have a setting for the theme (= uses the default theme)
add ?loadingScreenThemeColor=dark to the URL

Right now all seems to work, but I somehow don't see how your change has fixed the issue I seen.
MinimapOptions uses the MinimapTokensColorTracker to get the background color. But it's not listening to MinimapTokensColorTracker.onChange. So the color it gets might be stale. That can happen if the Minimap get the theme change event before the MinimapTokensColorTracker.
But as said, it seem to be working now.

The steps are:

open a codespace, make sure it does not have a setting for the theme (= uses the default theme)
add ?loadingScreenThemeColor=dark to the URL

Right now all seems to work, but I somehow don't see how your change has fixed the issue I seen.
MinimapOptions uses the MinimapTokensColorTracker to get the background color. But it's not listening to MinimapTokensColorTracker.onChange. So the color it gets might be stale. That can happen if the Minimap get the theme change event before the MinimapTokensColorTracker.
But as said, it seem to be working now.


Allow promise containing stream

gulp.task allows you to pass in a function returning a promise or a stream.
Could it allow a promise containing a stream? The task should wait until the stream inside of the promise has completed.

Nope. We don't look at results of anything.

The problem I'm trying to solve is I need to perform some async action before I can define my gulp tasks, which is why my stream is currently inside of a promise.
Can you think of a way of doing this?
promise().then(x => (
  gulp.task('foo', gulp.src(x))
));

I'm currently doing something like this as a workaround:
gulp.task('build', () => {
    const promise = x;

    promise.then(fileName => {
        return new Promise(resolve => {
            gulp.src(fileName)
                .pipe(rev())
                .pipe(gulp.dest('./public'))
                .on('end', resolve);
        });
    });
});

I believe we should reopen this since async functions comes to our lives:
gulp.task('build', () => async function() {
  var config = await readConfig();
  return gulp.src(config.somePath).pipe(...); // will return a stream
}); // ... but wrapped to promise because of async

... so we must rewrite it to:
var toArray = require('stream-to-array');
gulp.task('build', () => async function() {
  var config = await readConfig();
  return toArray(gulp.src(config.somePath).pipe(...)); // ... and it's weird
});

Even with simple Promises it's quitely strange to force users resolve streams manually.
Also would be nice to have support for generators to reduce syntactic noise, since they are supported out of the box in Node4.x+:
gulp.task('build', () => co(function*() {
  yield toArray( // Need it to convert stream to promise because co returns a promise with a stream
    gulp.src('./from/*').pipe(gulp.dest('./to'))
  );
}));

@zxqfox this is out of scope

@phated That's sad because it means you forcing users to write their own helpers (their own gulp-pieces) to wait streams inside promises, whlie gulp were made for it. Thanks for an answer.

@zxqfox :+1:

@zxqfox :+1:

@zxqfox 👍

Hey everyone, github added reactions so your +1s are just noise. I'm locking this.


Use CCL v3.0.1 .to_dict() instead of .__params_init_kwargs

This is used inside the main module of smokescreen but also in the utils.
The reason I am not updating now is that I am not able to build CCL from source and v3.0.1 is not yet on conda-forge.
As soon as it is, I can update the code to use this new functionality.

Fixed by 5f2239c, will be merged into main later.


rbenv install -l does not list the same ruby version than ruby-build does

rbenv version rbenv 0.4.0
rbenv install -l

ruby-build --definitions
ruby-build version 20150506

As you can see 2.2.1 appears in ruby-build definitions but does not appear in rbenv list

My fault 2 different ruby-build versions, homebrew and git pull inside of rbenv


Note about GPT4 being in limited beta is now obsolete I think

I think it is now open to any paying customer
Also the message about gpt-3.5 pricing might be a bit old. Anyway nowhere in your app is made mentions of tokens which can be abstract to newsbies so I guess the pricing details might be irrelevant anyway.

Updated in 3.15


SetBonus tooltip: support for lang keys

Can you please mixin the following?
com/fantasticsource/setbonus/client/TooltipRenderer class
Method: tooltips
Line 47: Instead of displaying set.name as is, maybe use I18n.format(set.name), so in the config we can input a lang key and it gets translated?
Line 82: Same with bonus.name
I hope it's possible!

Applied here:
https://github.com/KameiB/Localizator/blob/072dca67a0bf994fcb3bbac20d80c57324630e38/src/main/java/localizator/mixin/setbonus/TooltipRendererMixin.java#L66
https://github.com/KameiB/Localizator/blob/072dca67a0bf994fcb3bbac20d80c57324630e38/src/main/java/localizator/mixin/setbonus/TooltipRendererMixin.java#L104C34-L104C34


feat(universal): add single text component w/context to replace other children text components

This will remove children text components like <ButtonText />. It will use a <Text /> component from typography.
The Text component has a context that any parent can provide a className value for the text component. While using the cn utility function, undefined values from the context are ignored and the closest parent wins specificity.
Example:
import { Text } from '~/components/universal-ui/typography';

const Parent = (props) => <TextClassContext.Provider value="text-blue-500"><View {...props} /> </ TextClassContext.Provider>

const Component = () => <Parent><Text>Content</ Text></ Parent>

The "Content" text in the Text component will be blue.

Suggestion from Discussions: https://github.com/mrzachnugent/react-native-reusables/discussions/21

I think this is looking great. Pretty much matches the implementation I was working on.


v0.21 attributesToRetrieve does not apply on _formatted anymore

Describe the bug
Previously attributesToRetrieve was applied on both _formatted and root fields.
Example using the following query parameters:
{
    "q": "prince",
    "attributesToRetrieve": ["title", "id"],
    "attributesToHighlight": ["*"]

}

in v0.20
{
    "hits": [
        {
            "id": 456,
            "title": "Le Petit Prince",
            "_formatted": {
                "id": 456,
                "title": "Le Petit Prince"
            }
        },
        {
            "id": 4,
            "title": "Harry Potter and the Half-Blood Prince",
            "_formatted": {
                "id": 4,
                "title": "Harry Potter and the Half-Blood Prince"
            }
        }
    ],
    "offset": 0,
    "limit": 20,
    "nbHits": 2,
    "exhaustiveNbHits": false,
    "processingTimeMs": 0,
    "query": "prince"
}

in v0.21 :
{
    "hits": [
        {
            "id": 456,
            "title": "Le Petit Prince",
            "_formatted": {
                "id": 456,
                "title": "Le Petit Prince",
                "comment": "A french book about a prince that walks on little cute planets",
                "genre": "adventure"
            }
        },
        {
            "id": 4,
            "title": "Harry Potter and the Half-Blood Prince",
            "_formatted": {
                "id": 4,
                "title": "Harry Potter and the Half-Blood Prince",
                "comment": "The best book",
                "genre": "fantasy"
            }
        }
    ],
    "nbHits": 2,
    "exhaustiveNbHits": false,
    "query": "prince",
    "limit": 20,
    "offset": 0,
    "processingTimeMs": 0
}

Expected behavior
Same behavior
MeiliSearch Version:
v0.21.0

this is the expected behaviour as per https://github.com/meilisearch/specifications/blob/main/text/0039-_formatted-field-behavior.md#expected-meilisearch-behavior-021

After a discussion with @gmourier it should be notified in the CHANGELOG as even if we switch from undefined to defined the user might rely on the undefined behavior.
Thus they should me made aware that the behavior changed.

This issue describes this problem: https://github.com/meilisearch/transplant/issues/203
My bad, I forgot to put the issue as "breaking"
However, the related spec still describes in detail all the behaviors: https://github.com/meilisearch/specifications/pull/39/files


Trouble converting string to int

Having some trouble converting strings that are numbers into integers or numbers.
In the playground:
a_number = int("110")
print 'a number is {a_number}'

prints a number is 0
I also tried number():
a_number = number("110")
print 'a number is {a_number}'

prints a number is 1
Am I doing something wrong?

This should be fixed. Thanks for reporting this.


V 3.+: (NEW FEATURE / ENHANCEMENT) Redesign the 'Info' menu with new search options and photo menu

ToDO: Since the completion of #197 we now have a photo options for all the trees in the species.json. Time to update and integrate this feature into our 'Info' menu.

[x] Design a mock up of the menu in Figma
[x] Delete the existing 'Information' menu (and the 'i' icon) update with the tree icon (see Figma designs below)
[x] (Backend) Create lists of items in python to find out what cases we need to finish the 'Genus' dataset. Query out from the species.json all the cases of 'spp.' in the "COMMON" field. These are Genus level entries. Compare them with a grouped list of the names in the "GENUS" field.
[x] (Backend) for all cases where there is NOT a 'spp.'  entry for the Genus name - create a new entry in the species.json. Find at LEAST one image for this GENUS in the current EOL store (it is okay if it is the same image as another entry of that GENUS). Source this image in the "FULL_PIC" field. Fill out other necessary fields like "ITREECODE", "DESCRIPTION", "TYPE","COMMON","SCIENTIFIC" "ID", and "GENUS"
[ ] (Backend) Load images into github, resize, link the resized images in the species.json. Prep them for load into AWS & Load.
[ ]  (Front-end) create the 'Info' menu. Add the tree icon to the nav bar (if it is not already there)
[ ]  (Front-end & Backend) create the multi-filter options as seen in the menu below. Users should be able to sort alphabetically by either "COMMON" or "SCIENTIFIC" name. Menu can also open to display all the available species under 1 GENUS of tree. They also can see the difficulty ranking ("easy", "medium", "expert" from "LEVEL" field) of the tree by icon (icons are provided here: https://drive.google.com/drive/folders/1ZmumvGBYZWArgl49v6HwTXsNihXsnkd-?usp=sharing).
[ ] (Front-end) User will be asked at the end menu for a species entry if they want to add this particular tree to the 'Add' menu. If they say 'No' the menu closes and goes back the previously opened menu. If they say 'Yes' they are taken to the 'Add' page and the 'Species' name is already filled out for them (see Figma examples below)

IMPORTANT:

[ ] Fix 'More Tree info >'. Once ALL the above is complete, make sure the 'More Tree info >' option on the pop-ups on the 'Explore' page is now fully integrated with this new 'Info' menu (selecting 'More Tree info >' should open the species level menu (as shown in the graphic).

As of version 1 this 'More Tree info' has been hard coded to the few different pages available in the 'Information' menu. Now we will have information available on EVERY tree....except the 'Unknown'...so the expectation is this 'More Tree info >' menu option with be available for everything on the map.
Clicking on this:

Should open this:

Figma design is here: https://www.figma.com/file/qPsbrgYovo3Tu7zgziql42/iSeaTree?node-id=2%3A1867
Icons are here: https://drive.google.com/drive/folders/1ZmumvGBYZWArgl49v6HwTXsNihXsnkd-?usp=sharing
Example of the main 'Info' menu and the alphabetical sorting and filtering options:

Example of filtering/selecting a specific species by GENUS:

Example of selecting a specific species by SPECIES:

Example of going to the 'Add' menu from 'Info':

Christy H. Provided the below (the script is missing_genus_finder.py in the EOL images repo).
Here is a list of the genera (genuses?) that do not have their own instance (spp) in species.json:
['Unknown', 'Amelanchier', 'Arbutus', 'Asimina', 'Calocedrus', 'Carpinus', 'Cercis', 'Chamaecyparis', 'Cladrastis', 'Cornus', 'Corylus', 'Cotinus', 'Crataegus', 'Davidia', 'Eucommia', 'Fagus', 'Gingko', 'Gymnocladus', 'Halesia', 'Hamamelis', 'Koelreuteria', 'Lagerstroemia', 'Larix', 'Liquidambar', 'Liriodendron', 'Maackia', 'Malus', 'Metasequoia', 'Nothofagus', 'Nyssa', 'Ostrya', 'Oxydendrum', 'Parrotia', 'Phellodendron', 'Prunus', 'Pseudolarix', 'Pseudotsuga', 'Pterostyrax', 'Rhamnus', 'Robinia', 'Sciadopitys', 'Sequoiadendron', 'Sequoia', 'Sophora', 'Sorbus', 'Stewartia', 'Styrax', 'Taxus', 'Thuja', 'Tilia', 'Trachycarpus', 'Tsuga', 'Zelkova', 'Laburnum', 'Rhus', 'Juniperus', 'Ginkgoopsida', 'Quercus/live', 'Pittosporum', 'Pisonia', 'Prestoea', 'Arctostaphylos', 'Adonidia', 'Morus', 'Araucaria']

10/26/2022 update. I'm currently 1/3 of the way through the updates to add the genus for the species missing a genus entry.

@bestw07
11/10/2022 update. All images and descriptions are complete for the next round of 'resizing' photos and adding them into AWS.
The updates to the species.json are here (once the images are in AWS this species.json should be added into a new feature branch then pushed to /develop/  ONCE the AWS load is complete AND these rows are populated -
"FULL_PIC_180x110"
"FULL_PIC_1024x768"
"THUMB_PIC_1024x768"
https://github.com/TreeMama/iSeaTree_EOL_Images/blob/main/species.json
All NEW images are in this folder:
https://github.com/TreeMama/iSeaTree_EOL_Images/tree/main/missing_images_pt2
Please note : SOME of the images in this photo are being added to entirely new json entries and SOME of the images are being added to existing json images.

we’ve made significant upgrades to the species.json. I have linked to new AWS images and Ari fixed the scientific names of all genus entries to include ‘spp.’
please use this species.json from the latest /develop/ to fix your genus filter menu issues Mohammed and @ddwj


Add linting via postprocessTree hook.

Need to add postprocessTree to handle linting app and test trees (as added in https://github.com/ember-cli/ember-cli-qunit/pull/28 and https://github.com/ember-cli/ember-cli/pull/3094).
Also, broccoli-jshint allows the testGenerator to be configurable so the JSHint tests can now be emitted as mocha style.

/cc @ef4

https://github.com/switchfly/ember-cli-mocha/pull/26

@rwjblue can we close this now?

Yep, Ed took care of it in #26.

I thought so - thanks for comfirming :+1:


Please CHECK CHEBI:209277 somaliensene B

Hi Adnan,
Please check CHEBI:209277 somaliensene B as it is needed for a Rhea reaction with an EC number.
The compound is found in MetaCyc CPD-26716
and is described in pmid:29553734
Best wishes,
Kristian

Now checked.


Bugfix: Correctly keep preview active during fullscreen-toggle

This is a fix for issues created by #286, as noted in #306.
The initial attempt to keep preview active when toggling full-screen, was to simply not call toggleSideBySide(), which unfortunately didn't account for "no-fullscreen" classes that are applied in the non-fullscreen side-by-side preview mode.
In this PR:

move to applying.sided--no-fullscreen only to the parent element and using CSS inheritance
on full-screen toggle, add/remove .sided--no-fullscreen as needed
on side-by-side toggle, remove .sided--no-fullscreen as needed

For future refactoring, it would be cleaner to apply general status classes to the .EasyMdeContainer, such as fullscreen sided and have the sub-elements key off the parent class to avoid having to set classes on multiple elements.  This would allow all the .EasyMdeContainer.sided--no-fullscreen ... classes be replaced with .EasyMdeContainer.sided:not(.fullscreen), with similar changes throughout the rest of the code (.editor-toolbar.fullscreen to .EasyMdeContainer.fullscreen .editor-toolbar, etc.).

@Ionaru Anyone using sideBySideFullscreen:false and allowing full-screen toggling will be seeing issues due to my previous change, this fix should be deployed ASAP.

It's a big change with lots of code changes, it's going to take a little while to make sure everything still works as it's supposed to.

Understood.  Fundamentally, there's only two changes:

remove the '.sided--no-fullscreen' class application to child elements : I verified that this doesn't have any side-effects in the code base, the only concern is if anyone using the package is applying their own styles based on the child element classes.
applying the '.sided--no-fullscreen' class when toggling full-screen: This was the piece I missed in my original change, when toggling full-screen the classes need to be changed when the side-by-side is open.

I did also just add some add/removeClass convenience functions, because the string manipulation of classNames is a common pattern, but that can be reversed.


Use context manager with BytesIO

Summary
Use a context manager for BytesIO operations to ensure buffers are always closed.
Details and comments

@rathishcholarajan Can we merge this?

@jyu00 We should close this and move this to qiskit-ibm-runtime.

Moved to https://github.com/Qiskit/qiskit-ibm-runtime/pull/34


VEGA 1393 edit payment widget

Version 1 of the edit payments widget
VEGA-1393 #minor

Codecov Report
Base: 78.28% // Head: 77.66% // Decreases project coverage by -0.61% :warning:

Coverage data is based on head (41a2bee) compared to base (628b3a2).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   78.28%   77.66%   -0.62%
==========================================
  Files          57       59       +2
  Lines        1349     1424      +75
==========================================
+ Hits         1056     1106      +50
- Misses        183      199      +16
- Partials      110      119       +9

Impacted Files
Coverage Δ

internal/sirius/payment.go
50.00% <0.00%> (-33.34%)
:arrow_down:

internal/sirius/edit_payment.go
38.88% <38.88%> (ø)

internal/server/edit_payment.go
80.76% <80.76%> (ø)

internal/server/server.go
93.75% <100.00%> (+0.09%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


After upgrade PHP from 5.3 to 5.5, YOURLS 1.7 doesn't work

After upgrade PHP from 5.3 to 5.5, YOURLS 1.7 doesn't work and gives me this message:
SQLSTATE[HY000] [2054] The server requested authentication method unknown to the client

Dunno. Works for me. Try changing the DB driver or upgrading to current master.


Non mandatory date field does not allow to 'select month' value from the drop down

Expected behaviour
Must allow to select 'select month' if it is a non mandatory date field
Actual behaviour
'Select month' value is greyed out for an non mandatory date field
Steps to reproduce the behaviour
Launch any survey which has a non mandatory date entry field
select a month from the drop down
and then try to select the 'select month' from the drop down
Technical information
Browser
Operating System
Screenshot

Fixed in #928