Fix x64_64 to x86_64

Correcting language here - I believe you meant a 64-bit machine, or x86_64.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove per-operation Open()/Close() calls to BoltDB

Context now maintains a DB handle that is kept alive

I've added a few comments.
Also please do this for indexCmd
--git a/cmd/drive/main.go b/cmd/drive/main.go
index b417f20..f43d837 100644
--- a/cmd/drive/main.go
+++ b/cmd/drive/main.go
@@ -411,6 +411,9 @@ func (cmd *indexCmd) Run(args []string) {
 	byMatches := *cmd.matches
 	sources, context, path := preprocessArgsByToggle(args, byMatches || byId)

+	exitWithError(context.OpenDB())
+	defer context.CloseDB()
+
 	options := &drive.Options{
 		Sources:           sources,
 		Hidden:            *cmd.hidden,

I have made the suggested changes @odeke-em!  Please take a look at it again.

Thanks @js-ojus, just one more and then we are good to go.

Once that is in, please help me squash the commits into one and then I'll merge it in.
Thank you again.

Hello @odeke-em!  I have squashed the commits into a single one, which is now reflected into the pull request.

LGTM! Thank you very much for diagnosing, and working on this.


fix: broken feature flags

lgtm. just revert std for customprinter

Gotcha. Then I'll add the std feature flag in the pub use underneath as well

Re-inserted the std feature flag


does it support multiple devices ?

does it support multiple devices ?

Yes, this last version supports multiple devices @prashantnirgun


[tools] CMake 3.15 required

CMake is one of the main external tool we call from Conan, transparent integration and reliability should be a priority. It is important to declare a minimum supported version so we can run all the tests and be confident that the user will get the
expected results and no regressions will be introduced.

Upvote 👍  or downvote 👎  to show acceptance or not to the proposal (other reactions will be ignored)

Please, use 👀  to acknowledge you've read it, but it doesn't affect your workflow

Comment and reviews to suggest changes to all (or part) of the proposal.

before I vote, I wonder why 3.15, what are the features that have been added with 3.15
I think all nice features I remember, like precompile header and multi config builds, came with 3.16.x ? (but I might be wrong)
so why not one of the newer ones with those features, given how easy it is to get cmake installed on your machine, this should not be a problem

before I vote, I wonder why 3.15, what are the features that have been added with 3.15

The relevant features for Conan are described in the proposal document: https://github.com/conan-io/tribe/pull/4/files. They are based on what Conan needs to operate consistently and implement its logic (toolchains, generators), not on generic CMake features.

I usually support using the newer versions of tools wherever possible however, I am wondering what the motivation is here for a release that is only just over a year old.
We currently use a much older version of CMake, we could likely upgrade to be compatible with conan 2.0 but I would like to know the motivation for selecting this version for conan 2.0.
Is it simply to make the test matrix for conan smaller (ie. you need to maintain compatibility with much fewer versions of CMake, making testing easier) or are there some critical features introduced in newer versions of CMake that you plan to use and integrate with, and if so, what are they?

Hi @Daniel-Roberts-Bose
Please read https://github.com/conan-io/tribe/pull/4/files. In short:

Support for VS2019
Support for the CMAKE_PROJECT_INCLUDE feature, that we use in the toolchains (otherwise requires more manual work in the consumer CMakeLists.txt)
Support for CMAKE_MSVC_RUNTIME_LIBRARY to select the VS runtime

There are a couple of other things that requires at least CMake 3.14, and we have hacks in the Conan codebase, like correctly defining CMAKE_SYSTEM_NAME under Apple for iOS, watchOS...

I would amend the change with a requirement that every cmake script must check the cmake version:
cmake_minimum_required(VERSION 3.15)

Would it be useful to document the behaviour of the cmake generators + cmake build helpers documented such that somebody can create a CMakeLegacy* build helper or cmake_legacy` build helper?

For the category of "minimum supported version of X" I'd suggest that Conan also put together a list of officially supported platforms, to include the major OS releases. Then I'd suggest enumerating the current version of the tool that's provided (or very easily obtainable) for that platform.

OS
Current available cmake version

macOS (brew)
3.18.4

Debian Stable
3.13.4

Ubuntu LTS
3.16.3

EPEL 7
3.17.3

RHEL / CentOS / Oracle Linux 8
3.11.3

etc
etc

Not every OS supports an easy way to update to current tools, so it's important to know which supported platforms are lacking and what (non-controversial) methods are available for installing the toolchain.

I do not agree.
The lowest version of its dependancies conan will support, the more users conan can expect.
recent version of dependancies is good for conan developpers , it is bad for user community.
I could not find any survey  showing us % of users using at least 3.15.
I could not find minimal version required by vcpkg.
IMHO  conan should support at least cmake 3.9.6 (3 years old)

@jgsogo
What is the ETA of conan 2.0? So can put things in perspective.

What is the ETA of conan 2.0? So we can put things in perspective.

There is still no defined ETA for Conan 2.0, depends on the scope of some core features and changes (still to be discussed), but I would say that not earlier than June 2021.

The lowest version of its dependencies conan will support, the more users conan can expect.

I don't think we should try to optimize for the needs of possible future Conan users, and choosing versions based on time is not representative of real usage. The Conan community is large enough, and this is exactly the purpose of this Tribe: lets choose the latest possible version that satisfy the current Conan user base. This should be good as a proxy for other possible future Conan users needs.
In that regard an important note: You should report what is the version support that you need, no need to design or to decide for others. You can be "selfish". The Tribe is big enough to be representative of real world constraints, if someone is constrained, lets say to CMake 3.9, because of reason X, they should report it and give that direct feedback here

Are we planning to use the cmake package from Conan itself as is often done for automake, autoconf`, etc...? That would make it irrelevant which version is installed by default on the OS/Distro

I could not find any survey showing us % of users using at least 3.15.
I could not find minimal version required by vcpkg.

Vcpkg downloads its own cmake executable, curently 3.18.4. cmake is packaged in conan-center, so anyone who wanted could do the same with a [build_requires] in their profile...

Are we planning to use the cmake package from Conan itself as is often done for automake, autoconf`, etc...? That would make it irrelevant which version is installed by default on the OS/Distro

No, we don't plan to force that as built-in, we think it is important to let users the possibility to define their own CMake, and not depend on ConanCenter if they don't want to (some might not even be able due to policies or other constraints). We think that users should be able to use their own system-installed CMake without problems.

We think that users should be able to use their own system-installed CMake without problems.

I agree 100% with "should be able to", and maybe about 50% with "should have to do it". It would be very nice if (particularly if https://github.com/conan-io/conan/issues/7240 becomes a thing), to have a some explicit way for a [build_requires] package (probably from the profile) to hook into the way the build helpers look for their respective tools, so one could confidently say "this profile is using the cmake/msbuild/vswhere/etc from a locked package.
But that's quite a different issue from "what's the minimum version", albeit if it existed it would be an easy way to deal with an environment whose system package is too old to meet said minimum.

We just recently bumped cmake to 3.18.4.  Some of our devs seems seems to have issues with upgrading cmake because we are still on vs2017 and it ships older cmake which seem to be a bit harder to bypass on the GUI side.  I work 100% to shell so I don't know how much trouble this could be for general usage.

You should report what is the version support that you need, no need to design or to decide for others. You can be "selfish". The Tribe is big enough to be representative of real world constraints, if someone is constrained, lets say to CMake 3.9, because of reason X, they should report it and give that direct feedback here

actually using cmake 3.9.6

we are still on vs2017 and it ships older cmake which seem to be a bit harder to bypass on the GUI side

We filed https://developercommunity.visualstudio.com/idea/419081/add-option-to-vcvarsallbat-to-pick-and-choose-what.html a long time ago asking for a way in vcvarsall to avoid MS throwing other random tools (cmake, ninja, etc) into PATH when we were just asking for the VC compiler/Windows SDK/etc. We've actually written a [build_requires] package into our MSVC profiles whose jobs is to run vcvarsall, filter those back out, and then export an environment that has the desired PATH (and other vcvars env vars), which suppresses conan's own use of vcvars. But this is quite ugly to have to do that, and I'd certainly welcome anyone else getting bitten by this to pile some more votes on the request and see if MS can be persuaded to make it better :-)

No, we don't plan to force that as built-in, we think it is important to let users the possibility to define their own CMake, and not depend on ConanCenter if they don't want to (some might not even be able due to policies or other constraints). We think that users should be able to use their own system-installed CMake without problems.

You don't have to force users to depend on ConanCenter if you mandate using the cmake version provided as conan package. It can be simply a configuration entry in conan.conf or similar - by default the version from ConanCenter would be used and users could override the default to use either system version of cmake or cmake from custom conan package. If such setting existed, it should not be a problem to bump minimum supported CMake version even with conan updates (e.g. conan 2.0 requiring cmake 3.15 (or newer), conan 2.5 requiring cmake 3.16 (or newer), etc.). If a system version is selected and is a too old version, conan can issue an error and inform the user to either update the system version of CMake, use the default version from ConanCenter, or provide custom conan package containing the correct version of CMake.
I know that some companies don't allow using packages from ConanCenter (mine included), but, at least in our case, we have a custom cmake/<version>@microblink/stable conan package that is built using a custom recipe (we did that because cmake from ConanCenter breaks when using our conan profiles). This not only benefits conan developers, as they don't have to worry about supporting very old versions of CMake, but also developers and CI maintainers, as they don't have to worry about manually installing the correct version of CMake.

It can be simply a configuration entry in conan.conf or similar

One thing I would really like to see is a the ability for profiles to do overrides for [build_requires]. If using the build helper just somehow injected a [build_requires] cmake/[^3.15] (which would, per defaults, be the resolved with the conan-center package) doing a version override would be a very natural-feeling way to redirect it something else. Profiles already can override build_requires in conan 1.x, but not without also adding the build_requires in the first place; they can't currently do "override if present" like self.requires(..., override=True) does.
And I'd like profiles to be able to do overrides for [requires] as well, though for separate reasons (I sometimes want to replace dependencies with "shim" packages that use a system_requires or similar for certain profiles).

One thing I would really like to see is a the ability for profiles to do overrides for [build_requires]. If using the build helper just somehow injected a [build_requires] cmake/[^3.15] (which would, per defaults, be the resolved with the conan-center package) doing a version override would be a very natural-feeling way to redirect it something else. Profiles already can override build_requires in conan 1.x, but not without also adding the build_requires in the first place; they can't currently do "override if present" like self.requires(..., override=True) does.

We will be discussing the graph-model later, and it will probably be one of the biggest thing (it will need to be broken into multiple pieces for proposals and discussions)
To clarify: we don't plan to remove the ability of users to use their own tools like CMake or Visual Studio, installed in their system in the way they like. We might provide other useful ways to install them, as with Conan packages, build_requires, or even new features, but removing the ability of users to provide their own tools directly themselves, is not under consideration. The current proposal applies mainly for this case, as for other cases as using build_requires, is not relevant.

Looking for a clarification. What is the intent of the minimum supported version? Is it just the minimum version that CCI will use in testing?  The minimum version for use in CCI recipes? Will people still be able to use older versions of CMake (assuming it meets the cmake_minimum_required of the originating project)?  Will issues raised where the user is using an older CMake be rejected?

Looking for a clarification. What is the intent of the minimum supported version? Is it just the minimum version that CCI will use in testing? The minimum version for use in CCI recipes?

@dheater nothing to do with ConanCenter, but with Conan itself. The generators like cmake or cmake_find_package_multi`, or the CMakeToolchain`` (which will be the CMake integration in Conan 2.0) will use CMake syntax that only works in CMake 3.15, if possible. This will imply of course that ConanCenter recipes will require at least this CMake version, but ConanCenter might impose other constraints, like the current one that it only works with latest Conan.

Will people still be able to use older versions of CMake (assuming it meets the cmake_minimum_required of the originating project)? Will issues raised where the user is using an older CMake be rejected?

Users might not be able to use the new standard proposed integration with cmake (basically an improved cmake_find_package_multi generator + CMakeToolchain toolchain).  Users might need to provide their own integrations, explicitly opt-in into possible legacy integrations (that might not implement as many features, or might not be provided at all, depending on demand).

voted :+1:  as we're using 3.17 and it wouldn't be a problem but do agree with concern that not supporting CMake that comes with apt install in major Linux distros will be an unnecessary hurdle raising eyebrows

We use a custom 12.2 version, because we support our own "TI CCS" Studio (adapted from the Visual Studio support), which is not in main line.

Worth noting that Visual Studio ships a CMake version, so this and https://github.com/conan-io/tribe/pull/5 are possibly bound together (not for everyone, but some people do end up not installing their own CMake, so they use whatever VS gives them).

Hi Tribe,
Finally, we have decided to merge this proposal with a comment. We want to develop Conan 2.0 targeting this minimum CMake version but considering that the situation will change from the moment of approval to when Conan 2.0 is released. At that moment, we will evaluate user's feedback to check if it's necessary to add some workarounds or opt-out behaviour for users chained to previous versions.

Apologies for my late feedback on this.
If conan were to require a "recent" version of CMake (e.g such as 3.15) I believe that on most mainstream Linux distros and on windows, installing a recent version of cmake should be easy enough as to not be a big problem (e.g. for Ubuntu, Kitware maintains a repo that covers 16.04 onwards: https://apt.kitware.com/)
However it's probably worth mentioning that on certain ARM-based platforms like the Raspberry Pi or NVIDIA Jetson, it's not as trivial and may require building it from source. Raspberry Pi is currently based on Debian buster (CMake 3.13.x) and the JetPack is based on Ubuntu 18.04 (CMake 3.10) - Unfortunately kitware doesn't provide ARM binaries for 18.04. I think one of the strengths of conan is the way it handles support for multiple platforms, so having to build cmake from source may increase the cost of entry. Perhaps for these platforms it is more common to cross-compile from an x86_64 system anyway (conan handles it easily and faster!) - but it's something worth noting. I suppose at some point next year both RPi and Jetson will be updated to more recent versions anyway

Thanks for the late feedback @jcar87

Perhaps for these platforms it is more common to cross-compile from an x86_64 system anyway (conan handles it easily and faster!) - but it's something worth noting. I suppose at some point next year both RPi and Jetson will be updated to more recent versions anyway

Yes, we think so, that by the time Conan 2.0 is released, some distros might have updated CMake too. It is also worth noting that requiring CMake 3.15 might not be a complete blocker in all cases, and there might be workarounds for using other older versions, the closer to 3.15, the most likely there will be viable workarounds, of course.

Having a CMake minimum requirement fixed is a good thing but still, it might not be enough. You have to leave a way to be able to bump this requirement when needed or be prepared to release Conan 3.0 soon. I might be wrong but I think that in the next few CMake releases we can expect a lot of changes addressing C++20 modules and I bet you want to support them with Conan too.

It is not incompatible. Conan can request latest CMake to support some modern features, like C++modules, still support CMake 3.15 for all the other users that do not plan to adopt modules that fast (that will probably be a large part of the Conan users). It is not necessary a Conan 3.0 to support it, the proposal is about minimum versions, but of course versions later than the minimum one should work too.

Sure, just keep in mind that this is not transparent for Conan. Conan CMake helper and toolchain may need to use new or updated commands to provide modules support. Such files generated by Conan will be incompatible with CMake 3.15 which is the official minimum requirement for Conan.

I just noticed one interesting point to support CMake 3.17. It introduced "Ninja Multi-Config" generator which works perfectly well with "cmake_find_package_multi". With this, one build directory is enough to build every configuration in a robust way.
mkdir build && cd build
conan install .. -s compiler.cppstd=20 -s compiler.libcxx=libstdc++11 -s build_type=Release -b outdated -u
conan install .. -s compiler.cppstd=20 -s compiler.libcxx=libstdc++11 -s build_type=Debug -b outdated -u
cmake ../src -G "Ninja Multi-Config" -DCMAKE_TOOLCHAIN_FILE=conan_paths.cmake
cmake --install . --prefix test_package/Release --config Release
cmake --install . --prefix test_package/Debug --config Debug


Fix AST transform for case of setting argument property

Setting argument property works for Ember 3.16 but fails on 3.17.
{{set @greeting.hi "Hola"}}
This pr fixes the transform to make it work with Ember 3.17.

@pzuraq do you have any comments on this pr? Is there something I should change?

I’m sorry, I just haven’t had time to review, have job things to focus on 😕 Hoping to get to it next week, it’s on my backlog.


third-party.gni: Search includes using -I.

This will ensure that the headers from the dependencies will have
precedent over system headers, thus preventing situations where system
headers will block dependency headers and prevent compilation.
For example, on macOS libjpeg can be read before libjpeg_turbo's
jpeglib.h, and thus block symbols like JCS_EXT_RGBA.

@StatusReport

ping @StatusReport. The Google submission process seems to be broken ATM, so please merge this in order not to block us.
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/skia-discuss/2M0foNObuIs/i51ABw0NAgAJ


Remove hardcoded @ NUS instances

Description

Closes #2244
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How to test

Checklist

[x] I have tested this code

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.325%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5229

Relevant Lines:
13542

💛  - Coveralls


⚠ Processors has degraded performance

In 00199e7, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 101 ms

Resolved: Processors performance has improved in 002d360.


As a world health organisation analyst, I want to produce reports by countries in the world about population so that I can support population reporting of the organisation

Country reports

all reports created


share icon panel changes

list of contributors not necessary, just the title is fine.
Change "share this dandiset" to "Share this dandiset with this link"
For the twitter message we should refer to @DANDIarchive rather than #dandi

I'm not sure where is @DANDIarchive


Improvement on OMNeT Message Casting

Currently when a module receive a message, the handleMessage(cMsg *m) method checks for the type and cast it to the intended type before using.
Although not much of a performance impact, we can can gain a small benefit from not double checking the type
example here
https://github.com/sfc-aqua/quisp/blob/3f693ed4ae3f8f9378ed328f09a8105477717d55/quisp/modules/QRSA/ConnectionManager/ConnectionManager.cc#L67-L68
we already call dynamic_cast<type> on the message, there is no need to use check_and_cast here. Using static cast like shown below is probably a better way to go
if (dynamic_cast<ConnectionSetupRequest *>(msg) != nullptr) {
   ConnectionSetupRequest *req = static_cast<ConnectionSetupRequest *>(msg);

or use dynamic cast once, check if it's not null and use it right away. (so no double casting) something like
auto *crm = dynamic_cast<ConnectionSetupRequest *> (msg);
if (crm != nullptr) {
  // do something with crm
}

or this might be clearer.
if (auto *crm = dynamic_cast<ConnectionSetupRequest *>(msg)) {
  // do something with crm
}

That does look nicer! I forgot we can use this syntax in c++.


Template literals for pagespeed.js

Just a small fix .
:tophat:

Hmmm. I'm not sure if is a best practice; We're not using the template literal on the best way in this case... I'm looking at one submodule for querystring

What do you mean by best practice for template literals. Any references where best practices defined would be good for all.
Second why do we need to inject a module/sub-module when we are  doing good when we wrote things in vanilla way.

I believe in the power of submodules, where we can simply use what other people did.
Why we develop something of which there already that was done well? It makes no sense to me..

Another option could be instead or array and join thing...we just write everything in one line with template literals but that would make code look ugly though better in terms of complexity becuase .join() brings O(n) complexity with it.

I think we need libraries to make our work easier and doing something that needs significant effort to do on our own , either of above is not true in our case.
And libaries are also built by humans.

Use libararies when you want to build something quick & get the work done while try to do on your own when you want to learn new things that where you know why would you need library and why certain things wont work as expected in our case. And here i cant see any scenerio as such now where things wont work as we expects.
And people learn from mistakes.

Yeah. But, think with me. Library is very difference of small packages and I really prefer to use small packages and create something with this..
So, It's very valid create your packages for study, understand how it works, among others. :)

That's a difference of opinion.
I always want to do everything in vanilla where-ever possible it helps me grow and learn.

Yeeah @tarungarg546 Me too. We're talking about the same thing 😄
I think the best option is to always use pure javascript. Only I commented that if someone has done this is the best option 👍


fix(data-table-v2): add helper mixins

This updates data-table-v2 to include an import to helper-mixins which causes the partial to fail if included independently when feature flags for X are on.

@shinytoyrobots @alisonjoseph A straightforward change - Good to put in v10? Thanks!


bolt upload throws if source or destination have trailing slashes

Describe the Bug
when using bolt file upload in powershell, if the source or destination has a trailing backslash in the path, bolt throws:
Command requires a targeting option: '--targets', '--rerun', or '--query'
Expected Behavior
I would expect bolt to either handle the trailing slash, or to provide a more informative error.  The current error is misleading.
For comparison, the trailing backslash is supported in powershell's copy-item
Steps to Reproduce

Open Powershell
use bolt file upload and include a trailing slash in either the source or destination path or both:

bolt file upload c:\temp\dir1\ c:\temp\dir2\ --targets server01

The error is thrown:

Command requires a targeting option: '--targets', '--rerun', or '--query'
Environment

Bolt Version 2.8.0
PowerShell 5.1 build 17763 revision 1007
Windows Version 10.0.17763

Additional Context
In the example above I didn't include --transport -u or -p because it's defined in my inventory.yaml, however if I pass these params the error throws before the password prompt occurs which indicates to me the error is throwing before the winrm connection is made.  For this reason, --debug doesn't work to get any extra information about the failure.

Huh, I just tried the same on Powershell 5.1 (Windows 2019, Bolt 2.16.0) and it seems to have worked:
PS C:\Users\Administrator> bolt file upload C:\cygwin64\home\Administrator\.ssh\ C:\Users\Administrator\ -t localhost   Started on localhost...                                                                                Finished on localhost:                                                                                Uploaded 'C:\cygwin64\home\Administrator\.ssh\' to 'localhost:C:\Users\Administrator\'                                Successful on 1 target: localhost                                                                                Ran on 1 target in 0.04 sec                                                                                PS C:\Users\Administrator> $PSVersionTable                                                                                Name                           Value                                                                                ----                           -----                                                                                PSVersion                      5.1.17763.771                                                                            PSEdition                      Desktop                                                                                PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                  BuildVersion                   10.0.17763.771                                                                           CLRVersion                     4.0.30319.42000                                                                          WSManStackVersion              3.0                                                                                PSRemotingProtocolVersion      2.3                                                                                SerializationVersion           <IP_ADDRESS>                                                                                PS C:\Users\Administrator>

And the file is actually there. We did just modify how file upload works, which may have fixed this issue - if you upgrade to Bolt 2.16.0 does the issue persist?

@lucywyman This is now working for me after upgrading to Bolt 2.16.0.  My windows version & ps version remain the same on my localhost and my remotes.  Thanks!


[Improve] Delete console.log

Please delete this in componentDidUpdate
    console.log(
      prevProps.navigationState.index,
      this.props.navigationState.index,
      this.justScrolled
    );

Thanks!

thanksss


Fix clips containing audio/video

I'm still not sure if the audios would stop after their scene is complete, but at least they work now.
@skavish @shamansir please review but do not merge yet

I've added the fixes I've meant, but haven't tested it hard. Will deploy to test later and check how it works.


Crash on startup 1.16.3

Thanks for reporting an issue to a Trident project!
When reporting an issue to a Trident project, please make sure to include:

Version of mod Architecturecraft-1.16-3.146-all.jar
Minecraft version 1.16.5 & 1.16.3
Forge version - any
Gist below.
https://gist.github.com/MinuteLicence/7322c96c0ba2082d61373641f2a208dd

None of my mods are even remotely stable on 1.16 yet.


Internalize WinRT dependency & re-release CLI as a net6.0 only

The packaging issue of the CsWinRT project seem to be resolved with the .NET 6 release wave. There is a diff showing the expected behavior.

When using the CsWinRTEmbedded option I need to specify the types used (directly and indirectly). Unfortunately, this does not end well dependency-wise.
  <PropertyGroup>
    <CsWinRTIncludes>
      Windows.Foundation;
      Windows.Devices.Bluetooth.Advertisement.BluetoothLEAdvertisement
      Windows.Devices.Bluetooth.Advertisement.BluetoothLEAdvertisementWatcher;
      Windows.Devices.Bluetooth.Advertisement.BluetoothLEScanningMode;
      Windows.Devices.Bluetooth.Advertisement.BluetoothLEAdvertisementReceivedEventArgs;
      Windows.Devices.Bluetooth.Advertisement.IBluetoothLEAdvertisement
      Windows.Devices.Bluetooth.Advertisement.IBluetoothLEAdvertisementBytePattern;
      Windows.Devices.Bluetooth.Advertisement.IBluetoothLEAdvertisementReceivedEventArgs;
      Windows.Devices.Bluetooth.Advertisement.IBluetoothLEAdvertisementPublisher;
      Windows.Devices.Bluetooth.Advertisement.IBluetoothLEAdvertisementWatcher;
      Windows.Devices.Bluetooth.Advertisement.BluetoothLEManufacturerData;
      Windows.Devices.Bluetooth.Advertisement.IBluetoothLEManufacturerData;
      Windows.Devices.Bluetooth.BluetoothLEAppearance;
      Windows.Devices.Bluetooth.BluetoothSignalStrengthFilter;
      Windows.Devices.Bluetooth.BluetoothDeviceId;
      Windows.Devices.Bluetooth.BluetoothLEDevice;
      Windows.Devices.Bluetooth.GenericAttributeProfile;
      Windows.Devices.Bluetooth.BluetoothAddressType;
      Windows.Devices.Bluetooth.BluetoothCacheMode;
      Windows.Devices.Bluetooth.BluetoothConnectionStatus;
      Windows.Devices.Bluetooth.BluetoothError;
      Windows.Devices.Bluetooth.IBluetoothDeviceId;
      Windows.Devices.Bluetooth.IBluetoothLEAppearance;
      Windows.Devices.Bluetooth.IBluetoothSignalStrengthFilter;
      Windows.Devices.Bluetooth.IBluetoothLEDevice;
      Windows.Storage.Streams.IBuffer;
      Windows.Storage.Streams.Buffer;
      Windows.Storage.Streams.IInputStream;
      Windows.Storage.Streams.IOutputStream;
      Windows.Storage.Streams.InputStreamOptions;
      Windows.Storage.Streams.IRandomAccessStream;

      Windows.Storage.Streams.IContentTypeProvider;
      Windows.Devices.Enumeration.IDeviceAccessInformation;
      Windows.Devices.Enumeration.DeviceAccessChangedEventArgs;
      Windows.Devices.Enumeration.IDeviceAccessChangedEventArgs;
      Windows.Devices.Enumeration.DeviceAccessStatus;
      Windows.Devices.Enumeration.DeviceAccessInformation;
      Windows.Devices.Enumeration.DeviceClass;
    </CsWinRTIncludes>
    <CsWinRTExcludes>
      Windows.Foundation.Diagnostic;
      Windows.Devices.Bluetooth.IBluetoothLEDevice2;
      Windows.Devices.Bluetooth.IBluetoothLEDevice3;
      Windows.Devices.Bluetooth.IBluetoothLEDevice4;
      Windows.Storage.Streams.IRandomAccessStreamReferenceStatics;
      Windows.Storage.Streams.RandomAccessStreamReference;
      Windows.Foundation.PropertyType;
    </CsWinRTExcludes>
  </PropertyGroup>

With 1 remaining issue which can not be resolved without including the whole rest of WinRT.
CsWinRT\Windows.Devices.Bluetooth.cs(593,52): error CS0234: [..] "DeviceInformation" [..]  "Windows.Devices.Enumeration" [..]

There is a request to exclude members not needed from the projection in this issue in the CsWinRT repo. We may need to wait till this is implemented or another way shows up.


OWD project: Fix how MDN distributes Polyfills

This project proposes that we work on fixing how MDN distributes Polyfills.
Originally proposed in the MDN discourse https://discourse.mozilla.org/t/mdn-rfc-001-mdn-wiki-pages-shouldnt-be-a-distributor-of-polyfills/24500 but never rolled out, because the MDN wiki didn't really allow to make mass changes. This is now much more approachable with MDN in git.
Problem statement
MDN reference pages often contain large code blocks of Polyfills. This is bad for a few reasons.

The UX is terrible: The polyfills are distributed in the reference page inside the usual <pre> code blocks which are normally used for static code examples and create a giant blocks of code you normally don’t want to read, but need to copy & paste into your project in order to make use of the polyfill.
Maintenance is an impossible task: The MDN staff contributors and the core community lacks knowledge and time for of looking after changes to polyfills. Code of polyfills can be really complicated as it implements functions and algorithms described in e.g. the ECMAScript specification or needs to handle weird edge cases. The code aims to be correct and fast, which can be tricky, too. There are bugs filed against MDN polyfills; they remain unresolved.
Translations outdate, too. I haven’t even looked at how bad polyfills are on outdated wiki translations.
We do not conform to the advice for polyfill distributors from the W3CTag:

We don’t check if we host bad polyfills that are hurting the web. They were in the wiki and editable at any time.
We do track spec changes more or less, but we are unable to update the polyfills accordingly.
We’re not a CDN for polyfills, we don’t bundle them (someone apparently started doing that for MDN), nor can we guarantee any integrity, or checksums, caching, or anything the like.

Priority assessment
This table checks this project against the OWD prioritization criteria.

Criteria
Assessment

Effort
Medium. Need to identify how many pages involved but it is not all reference pages.

Dependencies
Need to agree on trusted Polyfill sources

Community enablement
Yes. This task is quite self-contained and contributions to update as many pages as possible are welcome

Momentum
N/A

Enabling learners
Not really. Sometimes remove large distracting code blocks from reference pages

Enabling professionals
Probably. You want to trust MDN about its Polyfill recommendation

Underrepresented topics / ethical web
N/A

Operational necessities
N/A

Addressing needs of the Web industry
Might help address compat pain point as Polyfills are part of the story there.

Proposed solutions

We should remove polyfill code blocks from the MDN pages.
We still want to offer polyfills to MDN readers but we should link to a trusted polyfill source rather than providing untrusted ones inline on the pages.

Task list

[ ] Confirm Polyfill removal and linking to trusted sources is the way forward.
[ ] Figure out trusted sources for Polyfills
[ ] Replace inline Polyfill code with links to trusted Polyfill sources

More information
Open Web Docs (OWD) is a non-profit collective funded by corporate and individual donations.
In order for this project to happen, please consider donating to OWD on https://opencollective.com/open-web-docs.
For more information on sponsorship and membership tiers, see https://openwebdocs.org/membership/
More information is available at https://openwebdocs.org.
For questions, please reach out to<EMAIL_ADDRESS>

Thinking aloud, would it make sense to have a curated list of polyfills be part of BCD? It's the sort of data the feels related in terms of helping developers figure out if and how they can use a feature, and the BCD repo could host a curation process based on some of the criteria, documenting some the pitfalls?

Personally, I head over to https://polyfill.io/v3/ by @financial-times if I need a polyfill for something. Modernizr could be considered another trusted source.
Is this issue also about Ponyfills? https://github.com/sindresorhus/ponyfill#how-are-ponyfills-better-than-polyfills
Or Prollyfills? https://kikobeats.com/polyfill-ponyfill-and-prollyfill/

My two bits:

I lean towards a simple link as opposed to installation instructions. The more you write, the more you have to maintain - and that is hard for off-site resources
If in BCD, why not just specify this as a normal subfeature, indicating the browser versions it is known to work in?
My reservation about including it in BCD is bandwidth; that team feels pretty stretched.

Yes, I also think we shouldn't host them, only link (directly or via structured data in front-runner, in mdn/browser-compat-data, elsewhere).
We discussed this project yesterday.
To move it forward, we need a few decisions.
I opened: mdn/content#7841 to decide for what features do we want to have polyfills. This decision will already help us to clean what we have (and then to make a useful inventory of the situation)

FYI this came up in OWD SC meeting today. @estelle Wanted to know if

core.js was a trusted polyfill source, and if not what sources are trusted
What the policy is for removal/adding

The broad feeling was that core.js was a kind of defacto standard. Also that polyfills are good when you only have one browser implementation, but not when there is broad implementation because people shouldn't be loading these unless they are needed. Policy might be something like "remove when in all current browsers"

What is the status of this?

This is on hold.

Policy might be something like "remove when in all current browsers"

core-js will be moved to a similar policy by itself from the next version -) However, polyfills are also bug fixes, and most bugs are not documented in MDN. Many such bug fixes are required even if everything in MDN compat data is green.


Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Other
Brief description of your issue
Upgrading SQL Management studio originally installed via Winget fails.
"No installed package found matching input criteria."
Steps to reproduce
Install SQL management studio (v18.12.1) and attempt to upgrade
Microsoft SQL Server Management St… Microsoft.SQLServerManagementStudio 18.12.1              19.0.2              winget
Actual behavior
No installed package found matching input criteria.
Expected behavior
Package upgrades successfully.
Environment
Windows Package Manager (Preview) v1.5.441-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.1413
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.441.0

Screenshots and Logs
WinGet-2023-04-06-11-03-51.086.log

The URL set to https://go.microsoft.com/fwlink/?linkid=2226343&clcid=0x409

Reference https://github.com/microsoft/winget-cli/issues/3055

19 to 20 is still bad.

This 19 -> 20 issue appears to be that 20.0 is installed next to the pre-existing 19.3.
So winget will try to upgrade 19.3 -> 20.0 every time you run winget upgrade --all. Even if 20.0 is already installed.


asformat mis-formats MXML Script tag & ignores contents

This is confirmed in a fresh installation of the latest VSCode with the ActionScript & MXML extension on Windows 10 x64.
The opening Script tag is unindented and the ActionScript inside isn't formatted.

I've found that if I change the end-of-line sequence option in VS Code from CRLF to LF I can get full formatting to work. However, there seems to be a critical mass of code you can reach which causes the formatter to crash. I've attached the console output below as it's too long to paste:
error.txt
It's hard to determine what exactly causes this threshold to be crossed, as it seems to differ depending on the content of the Script tag. Take the following file (I had to add a .txt extension to get it to upload):
TileList.mxml.txt
Ensuring EOL is set to LF, I can get this file to crash the formatter by duplicating lines in the ListCollection block and then get it to work again by removing lines.
Empty lines don't affect this, but whitespace characters do seem to have an effect.

Thanks. I may not have tested much with CRLF because I tend to avoid it, even on Windows. I'll check that out. I'll also investigate the crash, which seems to be from a regular expression.

I admit I never thought to change it from the default 'auto' setting in VS Code, but have done now!

apache/royale-compiler@d76804aae02115dbb76c09eb3b39ab183281da5f

Sorry to be a pest, but just wondering if this looks fixable (either the CRLF or LF - whichever is easier!) It would be such a massive enhancement to my workflow if so.

Awesome! 🎉

Josh, it appears that MXML formatting is broken in a similar way for both CRLF and LF style line endings. If the Script contents is too long, formatting breaks, but removing lines will eventually allow it to work. The strange thing is that once it works, I can re-add lines and it will still work - up to a point at least. CRLF seems to be a little more sensitive than LF. This is a Windows PC btw. I'm using the file I posted above for the example below:

Shall I create a new issue for this?

Yeah, create a new issue. Be sure to click the "Go to output" button and copy the exception that is reported.


Export CSV with data of visible timeseries range

Is your feature request related to a problem? Please describe.
When exporting a SVG/PNG the image shows only the the currently visible range of the timeseries.
When exporting a CSV tough the file contains all timeseries information.
Describe the solution you'd like
Add a boolean option like chart.toolbar.export.csv.exportSelection
true = new behaviour / export only visible data
false = current behaviour / export all
Describe alternatives you've considered
none
Additional context
none

Did you find a solution for this?
When I tried zoom and export I get

Anybody find any solutions to this one? Just ran into it myself

I didn't find solution. I hit an impasse, so I just leave it as is and
instead I offer users to change the chart dates, so they download whole
chart, rather than zoomed portion
On Mon, 21 Jun 2021 at 09:33, Darragh Kearns @.***>
wrote:

Anybody find any solutions to this one? Just ran into it myself
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apexcharts/apexcharts.js/issues/2333#issuecomment-864767183,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWLV7DUME2HU66DYMSYKATTT3MMLANCNFSM42G7JZPQ
.

I didn't find solution. I hit an impasse, so I just leave it as is and instead I offer users to change the chart dates, so they download whole chart, rather than zoomed portion
…
On Mon, 21 Jun 2021 at 09:33, Darragh Kearns @.***> wrote: Anybody find any solutions to this one? Just ran into it myself — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2333 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWLV7DUME2HU66DYMSYKATTT3MMLANCNFSM42G7JZPQ .

Ah damn, thanks for the reply, will keep playing around.

This is still an issue, rather annoying to have to choose between the UI experience and accurate data export


Boolean conversion for strong mode

if (null) {}
This code produces no issues in dartanalyzer strong mode and with --no-implicit-casts. Is this intended? Shouldn't it be (for strong mode) an error in analyzer and a compile error in vm?

No, sadly not.
You get a static warning if the value isn't assignable to bool, but since null is assignable to anything, there is no error. In checked mode the code will at runtime, in production mode it will treate null as false and run.
That's one more reason to add non-nullable types, so we can require that conditions are non-nullable bool.

That's one more reason to add non-nullable types, so we can require that conditions are non-nullable bool.

+1!
@sgrekhov we could perhaps fix this particular example. It is rather interesting in that this one is an error with --no-implicit-casts
main() {
  var x = null;
  // [error] Conditions must have a static type of 'bool'
  if (x) {}
}

Dart 1 has a "the type of null is bottom" rule that probably confuses things, which is why your initial example doesn't report an error, but the one above does.

we probably can't fix this until we have non-nullable types.


Feature/deviceregistry improvements

Review this quickly, so I can continue with development repo :)

pre-commit et al missing, fixing

Merging this anyway, workflow checks will be fixed later.


Tickets/dm 21922

Hi, @loitly, can you give this a review, primarily for build-related information?
A deployment of the built document is available at https://dmtn-136.lsst.io/v/DM-21922/index.html .

Hi, @cbanek, can you have a look at this to make sure I haven't said anything wrong about deployment?

(@cbanek, your review is still welcome and I'll make any changes on a new branch.)


marshalled results not sorted same as stdlib

	json_test.go:29: marshal expected:
		    {
		    >  "-1538202063": 0.3634222946643717,
		    >  "1223101607": 0.16867633434109314,
		    >  "576443938": 0.020297602318735935
		    }
		got:
		    {
		    >  "576443938": 0.020297602318735935,
		    >  "1223101607": 0.16867633434109314,
		    >  "-1538202063": 0.3634222946643717
		    }

This is sort of tedious, but being exactly compatible has some value, right?

JSON does not require the key to be sorted. I would like to treat the two representation to be equivalent. If there is other user vote for this feature, I might support it.

2 arguments:

it makes the test less useful
systems like kubernetes want to be able to diff file-saved JSON and server-saved JSON, and this makes it impossible.

as this will cause significant cost to user not requiring it. sorting should be an optional behavior.

I think it might be a good design to have something like a policy type that
carries config values, and let encode/decode use those.  That way users can
measure and make tradeoffs.
E.g., spew does this:
spew.Printf(fmt, obj) // uses default config

x := spew.ConfigState{ SpewKeys: true }
x..Printf(fmt, obj) // uses custom config

so this could be:
json := jsoniter.Config { SortMaps: true, HTMLEscape: true }
jb, err := json.Marshal(obj)

and you could offer a StdlibConfig pkg variable that was exactly Golang
compatible, but not fast and a Fast variable that wasn't compatible but
used all optimizations.
Though, hopefully the compatible version can be fast, otherwise why not
just use the Golang impl ? :)
On Mon, Jun 12, 2017 at 8:58 AM, Tao Wen<EMAIL_ADDRESS>wrote:

as this will cause significant cost to user not requiring it. sorting
should be an optional behavior.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/json-iterator/go/issues/54#issuecomment-307834052,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVKCr_fG4MVhWUg-BcDCwt3RqWk1Dks5sDWAVgaJpZM4N2oWh
.

I am sure most user do not need to sort the map keys, and do not know std impl actually sorts the map keys. Taking things out of the std impl to make it faster while still keeping the behavior "compatible" is the goal. To be fair, std impl does the validation much more strictly, and many other things. But not everybody is happy with the fact those many other things come with runtime penalty.
I like
json := jsoniter.Config { SortMaps: true, HTMLEscape: true }
jb, err := json.Marshal(obj)

Yeah, leaving that to the user sounds good, even if not default.  I will
watch repo for changes, and send more test cases.
On Jun 12, 2017 5:27 PM, "Tao Wen"<EMAIL_ADDRESS>wrote:

I am sure most user do not need to sort the map keys, and do not know std
impl actually sorts the map keys. Taking things out of the std impl to make
it faster while still keeping the behavior "compatible" is the goal. To be
fair, std impl does the validation much more strictly, and many other
things. But not everybody is happy with the fact those many other things
come with runtime penalty.
I like
json := jsoniter.Config { SortMaps: true, HTMLEscape: true }
jb, err := json.Marshal(obj)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/json-iterator/go/issues/54#issuecomment-307971821,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVLgdko0pmPjwYGKAxkxvmfHTFTKcks5sDdeAgaJpZM4N2oWh
.

@thockin it is supported now


/party accept - accept most recent invitation

I believe people still getting tripped up with it having it being /party accept
Any chance we could have it remember who was the last player who sent you an invite and get accepted to their party? Maybe having /party accept  as an option incase a player gets many invites

Added.


Feature Request: Choose Article Typeface

This is specifically for the iOS version.
I’m sure it’s been worked on, but I wasn’t able to find any word on it. Would it be possible to allow for changing of the Typeface in the article view? Reading with a serif font is just far more comfortable.
Thank you!

Yep, that is on our roadmap.  Duplicate of #19.


Use podtato in Service Mesh Performance testing

Proposal: use podtato as a sample application to run performance tests in Service Mesh Performance

Please do :clap: and give us feedback on scenarios important to you and your users, also see https://github.com/cncf/tag-app-delivery/issues/167


Adding gitignore for python

Moved .gitignore up a level because it's necessary for src/api/public as well


Establish Hipcheck RFD process

Historically, changes to Hipcheck have been discussed historically with the team, subject to minimal review or contemplative process, and then either pursued or abandoned. While that's made sense for a project which was not open source and therefore not concerned with open governance, it doesn't make sense for a project which is open source and does intend to transition over time to some form of open governance.
An "RFD" (Request for Discussion) process, as seen in projects like the Rust programming language (which calls them "RFCs"), the Python programming language (which calls them "PEPs"), or the Oxide Computer Company (which does use the term "RFD"), is one which requires for "substantial" changes that they be proposed, discussed, and a disposition determined prior to being implemented.
The disadvantage of such a process is that it slows down the time from having an idea to implementing the idea, when the idea is sufficiently important or large enough in scale that it's worthy of the RFD process. The advantage of this process is that it gives time for deliberation and to bring in diverse voices who may add to the quality of the idea or show reasons why something should not be pursued or should be modified.
To borrow a phrase: "slow is smooth, smooth is fast." By increasing the deliberation prior to taking action, we can reduce the amount of work which needs to be un-done mid-stream when issues are discovered, and help to ensure we not just implementing things, but are implementing the right things.
As for what this could look like, I think something like an rfd/ subdirectory of the repository, into which documents go which describe completed RFDs, would be good. This could include RFDs in various statuses, including ACCEPTED, REJECTED, and SUPERSEDED. They ought to be prefixed with some numbering system; let's say three digits with left-most 0-padding, 1-indexed. So the first RFD would be 001-<title of RFD in ASCII with dash delimiters>.
The content of RFDs ought to reflect the problem, the constraints on the problem, the proposed path forward, other paths considered, and potential future work.
The details of how RFD's will work should likely be the focus of the first RFD!

Closed by #24.


Added button

Add animated buttons using HTML and CSS. 🚀 #141

@Spyware007  I have made PR, please review it .

Hello @aniketburman014
Please uncommit the package-lock.json
It will be merged then!

I have uncommitted the package-lock.json. please check and merge it.

@aniketburman014 There seems to be a merge conflict, please fix it

Sorry for the inconvenience. As I am new to GitHub, please check whether the issue has been resolved or not.

@aniketburman014
Failed to compile.
02:14:17.307 |
02:14:17.307 | [eslint]
02:14:17.307 | src/Data.js
02:14:17.308 | Syntax error: Unexpected token, expected "," (179:2) (179:2)
02:14:17.308 |
02:14:17.308 |
02:14:17.341 | Error: Command "npm run build" exited with 1
02:14:17.528 | BUILD_UTILS_SPAWN_1: Command "npm run build" exited with 1
This is the issue.
You are missing a semicolon in the Data.js file!


[chore] merge traffic-guru and traffic-guru-all into one chart

merge traffic-guru and traffic-guru-all into one chart
rename trafficguru-prometheus to traffic-guru-prometheus to make all resource name looks consistent
use nodeport for k8s service by default
expose pipy-repo via nodeport for external pipy workers
add procedures for using external database in README

@naqvis could you please help reviewing these changes?


[FEA] Update the citation text

Modulus Pull Request
This PR updates the citation text. Here's how the BibTeX is compiled in different formats:
Harvard:
Modulus Contributors. (2023). NVIDIA Modulus: An Open-source framework for building, training, and fine-tuning deep learning models for science and engineering. https://github.com/NVIDIA/modulus
IEEE:
Modulus Contributors, NVIDIA Modulus: An Open-source framework for building, training, and fine-tuning deep learning models for science and engineering. 2023. [Online]. Available: https://github.com/NVIDIA/modulus
APA:
Modulus Contributors. (2023). NVIDIA Modulus: An Open-source framework for building, training, and fine-tuning deep learning models for science and engineering. https://github.com/NVIDIA/modulus
MLA:
Modulus Contributors. NVIDIA Modulus: An Open-Source Framework for Building, Training, and Fine-Tuning Deep Learning Models for Science and Engineering. 2023, https://github.com/NVIDIA/modulus.
Date is set to the first Alpha release of the Modulus-Core.
Description

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci

Should we keep the title more general because Modulus can potentially offer features in addition to to building, training and fine tuning of models? For example: "Modulus: An open-source framework for physics based deep learning in science and engineering."

Yes I like the wording Rishi.

Should we keep the title more general because Modulus can potentially offer features in addition to to building, training and fine tuning of models? For example: "Modulus: An open-source framework for physics based deep learning in science and engineering."

Updated to your suggested text

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci


MM-38908: Handle /:team/_playbooks/:playbookId/run

Summary
Navigating to /:team/_playbooks/:playbookId/run will switch to the last viewed channel in the team, defaulting to Town Square, and then will execute the /playbook run-playbook command, effectively rendering an interactive dialog to run the playbook.
This is needed to support the Run button in the Playbooks product, fixing a bug in the desktop where the app successfully changes the tab to Channels but still renders the interactive dialog in the Playbooks tab.
The video below shows the use-case: the user is in team eligendi, then goes to the Playbooks tab and opens a Playbook in team minus, when clicking on the Run button, the desktop app focuses the Channels tab, where the user is redirected to the last channel viewed in the playbook team (in this case neque in the team minus) and opens the interactive dialog.
Ticket Link
https://mattermost.atlassian.net/browse/MM-38908
Related Pull Requests

Playbooks PR: https://github.com/mattermost/mattermost-plugin-playbooks/pull/780

Screenshots
https://user-images.githubusercontent.com/3924815/135624556-f38d661e-e7a1-41a7-bea6-930e78227689.mp4
Release Note

Looping @devinbinnie for review from the Desktop's perspective.

Hm, I had also added @calebroseland as reviewer :thinking: Let's go with both, you never have too many reviews in a PR :)

/release-note-none

Perhaps <PlaybookRunner/> could mounted in route handler/container that is provided by Playbooks via PluginRegistry.registerCustomRoute (listening for something like/plug/playbooks/:playbookId/run)

Wouldn't this keep the bug as it is, with the interactive dialog spawning in the Playbooks tab? Maybe there is a better place to put it, but we need something in the Channels product, not in the URLs managed by the plugin.

Perhaps <PlaybookRunner/> could mounted in route handler/container that is provided by Playbooks via PluginRegistry.registerCustomRoute (listening for something like/plug/playbooks/:playbookId/run)

Wouldn't this keep the bug as it is, with the interactive dialog spawning in the Playbooks tab? Maybe there is a better place to put it, but we need something in the Channels product, not in the URLs managed by the plugin.

5/5 You're right. Please disregard my comments above.

@amyblais, we need to get this into 6.0. Is there anything else I need to do apart from the cherry-pick?

@agarciamontoro Just a cherry-pick to release-6.0.

Skipping QA, I reviewed the fix myself and this will be tested as part of Playbooks in our regular bug bash parties :)

Cherry pick is scheduled.


gnome3.gdm: fix session chooser (backport to 18.03)

Motivation for this change
Backport to 18.03 of fix in 300af6677760944a3c27f7bf33a1366c380c3317 for #34101.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

cc @jtojnar

@GrahamcOfBorg  build gnome3.gdm gnome3.gnome-shell

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.gdm, gnome3.gnome-shell
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: gnome3.gdm, gnome3.gnome-shell
Partial log (click to expand)
shrinking /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/bin/.gnome-shell-wrapped
shrinking /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/libexec/.gnome-shell-perf-helper-wrapped
shrinking /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/libexec/.gnome-shell-portal-helper-wrapped
shrinking /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/libexec/.gnome-shell-calendar-server-wrapped
shrinking /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/libexec/.gnome-shell-hotplug-sniffer-wrapped
gzipping man pages under /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/share/man/
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/lib  /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/libexec  /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2/bin
patching script interpreter paths in /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2
checking for references to /build in /nix/store/k9i7lgs7bnx5v31vppdzf8n8jiyf4jny-gnome-shell-3.26.2...

Success on aarch64-linux (full log)
Attempted: gnome3.gdm, gnome3.gnome-shell
Partial log (click to expand)
shrinking /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2/lib/gnome-shell/libst-1.0.so
shrinking /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2/lib/gnome-shell/libgvc.so
shrinking /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2/lib/mozilla/plugins/libgnome-shell-browser-plugin.so
gzipping man pages under /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2/share/man/
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2/lib  /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2/libexec  /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2/bin
patching script interpreter paths in /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2
checking for references to /build in /nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2...
/nix/store/ckksdr839kda7fdzlvl156vkg2a9z1ba-gdm-<IP_ADDRESS>
/nix/store/q652ilv255jzph23n6nybk0zfzgzfmkv-gnome-shell-3.26.2


Dreamview module doesn't show map

Hello, developers. I use Apollo7.0 and when I tried to use your maps, the dreamview module cannot show the map. It just kept showing "Please send car initial position and map data".
What I did is just copy the map file to /modules/map/data, and I turned on the sim-control with 'Routing', 'Planning', 'Prediction', 'Transform', 'Localization' module and I choose map 'Town02'. However, the dreamview remains black. But when I use manual_light.sh, it detects traffic light signal.
Could you help me with that? Thanks a lot.

I will regenerate the map, it seems that some maps have a little problem


vencord: 1.3.4 -> 1.4.5

Description of changes
https://github.com/Vendicated/Vencord/compare/v1.3.4...v1.4.5
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I have opened a PR to upstream our patches.
See https://github.com/Vendicated/Vencord/pull/1677


ng add @angular/elements --project my-project-element is not updating angular.json

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [x] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 7.0.0-rc.3
Node: 9.4.0
OS: darwin x64
Angular: undefined
...
Package                      Version
@angular-devkit/architect    0.9.0-rc.3 (cli-only)
@angular-devkit/core         7.0.0-rc.3 (cli-only)
@angular-devkit/schematics   7.0.0-rc.3 (cli-only)
@schematics/angular          7.0.0-rc.3 (cli-only)
@schematics/update           0.9.0-rc.3 (cli-only)
rxjs                         6.3.3 (cli-only)
Repro steps

The log given by the failure

Desired functionality

Would be nice if we can do something like "ng add @angular/elements --project my-project-element that will update angular.json accordingly such as
    "my-project-element": {
      "root": "projects/my-project-element/",
            ...
            "scripts": [
              "node_modules/document-register-element/build/document-register-element.js"
            ]

Mention any other details that might be useful

Any specific capabilities of ng add beyond package installation are of the domain of the package being added and not the CLI.  If there is interest in such additional capabilities they would need to be added to the package and a request to the package itself would be the appropriate next step.


Added support to allow redirection.

refs #252 Added support to retrieve the data incase the source has been moved.

Coverage decreased (-0.2%) to 97.616% when pulling db422770a7ca4e3bf54edb5ed049c5d3312821e9 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.616% when pulling db422770a7ca4e3bf54edb5ed049c5d3312821e9 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.616% when pulling 8bec75beca89800a51b05f403a87ac41d3b34e88 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.616% when pulling 8bec75beca89800a51b05f403a87ac41d3b34e88 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.616% when pulling 8bec75beca89800a51b05f403a87ac41d3b34e88 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.616% when pulling 8bec75beca89800a51b05f403a87ac41d3b34e88 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.622% when pulling 0ad7bd92199ac44b5aa5a42f995046ab42932801 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.622% when pulling 0ad7bd92199ac44b5aa5a42f995046ab42932801 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.622% when pulling 0ad7bd92199ac44b5aa5a42f995046ab42932801 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.622% when pulling 0ad7bd92199ac44b5aa5a42f995046ab42932801 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.622% when pulling e6d33380a3c9ab4e5ad20a48c19b40a0426f2533 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.2%) to 97.622% when pulling e6d33380a3c9ab4e5ad20a48c19b40a0426f2533 on prasadsurase:add-redirection-support into 2632ae380f01f0827180369e23df4dadb24c6693 on piotrmurach:master.

Coverage decreased (-0.007%) to 97.622% when pulling a019aff34aa31a662c5e21439d8f81593dcba352 on prasadsurase:add-redirection-support into c30245509789e63463d1b62f612a54ed6c37086e on piotrmurach:master.

Coverage decreased (-0.007%) to 97.622% when pulling a019aff34aa31a662c5e21439d8f81593dcba352 on prasadsurase:add-redirection-support into c30245509789e63463d1b62f612a54ed6c37086e on piotrmurach:master.

Sorry for really late review. Would you mind adding tests that demonstrate redirects?

Thank you for your contribution ❤  I went with another solution of directly using middleware submitted by another person. I will release shortly new version that includes redirects.


Show suffix of clipboard entry, too

When the clipboard entry is too long, Maccy shows me the prefix.  But, especially in the case of file names, the prefix alone is not that helpful.  What do you think about showing a prefix, then an ellipsis, then a suffix, of each entry?
So that /Users/jrl/Documents/Projects/2020/05/Corona-Strategy.docx would not be abbreviated /Users/jrl/Documents/Projects/..., but rather /Users/jrl/.../Corona-Strategy.docx.  (I didn't could characters for this example, but I hope you get the idea.)

Released in 0.14.0


Mb/charge exchange kernel new

Description
Please include a summary of changes, motivation and context for this PR.
Fixes #178
Fixes #194
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)
[ ] Requires documentation updates

Testing
Please describe the tests that you ran to verify your changes and provide instructions for reproducibility. Please also list any relevant details for your test configuration.

[ ] Test Foo in /test/path/to/file_for_test_Foo.cpp
Description of test Foo
[ ] Test Bar in /test/path/to/file_for_test_Bar.cpp
Description of test Bar

Test Configuration:

OS:
SYCL implementation:
MPI details:
Hardware:

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any new dependencies are automatically built for users via cmake
[ ] I have used understandable variable names
[ ] I have run clang-format against my *.hpp and *.cpp changes
[ ] I have run cmake-format against my changes to CMakeLists.txt
[ ] I have run black against changes to *.py
[ ] I have made corresponding changes to the documentation
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings

Closing as superseded by later work.


Add CI

Add CI that automatically builds the project, with default config from lean-action

It's from this repo https://github.com/leanprover/lean-action
I think it is used also in a few large lean projects


AdMobBanner can't click in ios

I using react-native 0.39.2, react-native-admob ^1.1.5 and my code:
import React from 'react';
import {
Platform
} from "react-native";
import {AdMobBanner} from 'react-native-admob';
export default class extends React.Component {
render() {
if ((Platform.OS === 'ios'))
return (
<AdMobBanner style={{height: 50}}
adUnitID="your-admob-unit-id-ios"
testDeviceID="EMULATOR"/>
);
else return (

);
}
}
But just Android can click in AdMobBanner, IOS can't.

I have the same problem, ads not possible to press :/


Issue #164 html output test runner

Fixes #164

@faloi please review

Is the migration for :output_content_type missing?

@faloi No, it is not. It is in last commit

I am testing that the content type properly flags the strings as html safe for makdown, so that they can be rendered by tempalte engine later without doing any escapes.

@faloi  you where right, migration was missing. Fixed


add Rounded Rectangle

I have created a pyglet.shapes.RoundedRectangle class for rectangle with rounded corners.
There is an example:
import pyglet

window = pyglet.window.Window(300, 300)
rect = pyglet.shapes.RoundedRectangle(100, 125, 100, 50, radius=(10, 20, 5, 7))

@window.event
def on_draw():
    window.clear()
    rect.draw()

pyglet.app.run()

Thank you for the PR. I may make some minor tweaks to this after merging, but overall it looks good.

Thanks for adding this feature

Thanks, i really needed this!

Thanks again for this. It's kind of easy to crash at division by zero for the number of segments used to draw the corners, if providing a small value to the radius argument to this class constructor.
The class documentation string says:
                One or four values to specify the radii used for the rounded corners.
                If one value is given, all corners will use the same value. If four values
                are given, it will specify the radii used for the rounded corners clockwise:
                bottom-left, top-left, top-right, bottom-right. A value can be either a single
                float, or a tuple of two floats to specify different x,y dimensions.

Maybe it could just further elucidate in what sense is the radius argument interpreted as radii.
By the way, why does it draw the rounded corners using triangles?
Obviously these are obvious to anyone who ever implemented rounded corners in OpenGL, but a compact statement about the meaning of the radii for the radius argument might likely help.
I'm sure the explanations would make the questions foolish ...
Thanks for your comments!

Now that there's a rounded rectangle, and there is also a bordered rectangle, it's nice if there were also a bordered, rounded, rectangle :-)


chore: change initial input value to valid one

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

It's a one-line change! :imp:


Documentation calling plans not complete

In the documentation there are only two options: domestic calling plan (12$) and international calling plan (24$). In the Netherlands and Belgium there are four options: domestic calling plan (120 minutes) ; domestic calling plan (240 minutes); domestic calling plan (1200 minutes); domestic and international calling plan.

see on https://docs.microsoft.com/en-us/microsoftteams/country-and-region-availability-for-audio-conferencing-and-calling-plans/availability-in-the-netherlands

@Vleugelsjef hank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officedocsbot assign @scanum

@Vleugelsjef Thank you for your feedback. Could you please provide us the original document that you are referring to where the information is incomplete or incorrect?

Hi @msbemba I was looking at different sources: not all contains the same information:
https://docs.microsoft.com/en-us/microsoftteams/calling-plans-for-office-365 (only two)
https://docs.microsoft.com/en-us/microsoftteams/calling-plan-landing-page
https://docs.microsoft.com/en-us/skypeforbusiness/skype-for-business-and-microsoft-teams-add-on-licensing/assign-skype-for-business-and-microsoft-teams-licenses (only referring two types MCOPSTN1 and 2)

@Vleugelsjef Thank you for your feedback.
The first two links provide information about the different calling plans available and doesnt not go deep into the options within the calling plan. So I think it is Ok to leave those as it is , however the third link with SKU has been updated via PR https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/2401

@msmikedavis - Can you confirm that there are four calling plan options in the Netherland? See the first entry here. Thanks, Tony

Yes
From: Tony Smith (MSFT<EMAIL_ADDRESS>Sent: Friday, June 7, 2019 10:07 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Mike Davis<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] Documentation calling plans not complete (#2332)
@msmikedavishttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmsmikedavis&data=02|01|Mike.Davis%40microsoft.com|1add80e4c4c04a65154308d6eb6a7d63|72f988bf86f141af91ab2d7cd011db47|1|0|636955239933589805&sdata=ZFGgZ4FFklTfPi7OH8%2FMUrYgMqcsSdK5K209b3ud4WQ%3D&reserved=0 - Can you confirm that there are four calling plan options in the Netherland? See the first entry here. Thanks, Tony
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F2332%3Femail_source%3Dnotifications%26email_token%3DAH4DDC2TOTJICYVCL6TTKMLPZKIRPA5CNFSM4HQASG22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXGNPIA%23issuecomment-499963808&data=02|01|Mike.Davis%40microsoft.com|1add80e4c4c04a65154308d6eb6a7d63|72f988bf86f141af91ab2d7cd011db47|1|0|636955239933594796&sdata=D3HJ2qXzcyOCHFak%2BSKpfAMedJXYGGIylugC%2BTC%2Fpak%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH4DDCYVANN7GOGO4NHIZHTPZKIRPANCNFSM4HQASG2Q&data=02|01|Mike.Davis%40microsoft.com|1add80e4c4c04a65154308d6eb6a7d63|72f988bf86f141af91ab2d7cd011db47|1|0|636955239933599792&sdata=qMj4qxhy%2FomLcMfgXwZieDItIS3c7leYvFygPYUU0iE%3D&reserved=0.

Thank you @msbemba. Can you also adjust the following place: https://docs.microsoft.com/en-us/azure/active-directory/users-groups-roles/licensing-service-plan-reference
Then people can find this information on multiple places.

@msbemba

@Vleugelsjef Thank you for the feedback and sorry about the delay.  We have added the guid and other details for MCOPSTN5 - Domestic Calling Plan (120 min calling plan) via PR  https://github.com/MicrosoftDocs/azure-docs/pull/34468
Note that MCOPSTN6 is on limited availability.
Once again thank you for making our docs look better.
Thanks
Sri

You're welcome!


Flaming Candle

text: Once in play, can be moved (eg. Heidelberg Castle, Germany) or equipped by another minion from the minion who has it.
link: https://www.vekn.net/forum/rules-questions/80131-can-a-flaming-candle-be-moved-by-a-heidelberg-castle-germany#106697

Merged @ d78bb76


node: uncaughtException error on RESOURCE_EXHAUSTED: Quota exceeded

In my application, when reaching the quota:
speech.googleapis.com/default_requests
DefaultRequestsPerMinutePerProject
(which is 300 by default) -
The immediate caller to the library receives an error (via errHandler below) - but the main node process also gets an uncaughtException  via process.on("uncaughtException",function(err){ ...
eg:
var gspeech = require("@google-cloud/speech");
var client = new gspeech.SpeechClient( someAuth );
var stream = parent.client.streamingRecognize( someConfig );
stream.on("data", dataHandler);
stream.on("error", errHandler);

Obviously this is highly undesirable, as the entire application/process exits at that point.
The library should throw this error to the caller via the errHandler  but it should NOT crash the entire node process due to a resource/quota being reached.

full error:
{ Error: 8 RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'speech.googleapis.com/default_requests' and limit 'DefaultRequestsPerMinutePerProject' of service 'speech.googleapis.com' for consumer 'project_number:###########'.
    at Object.exports.createStatusError (/home2/arcos/arcos-app/arcos10-fsivr/node_modules/grpc/src/common.js:91:15)
    at ClientDuplexStream._emitStatusIfDone (/home2/arcos/arcos-app/arcos10-fsivr/node_modules/grpc/src/client.js:233:26)
    at ClientDuplexStream._receiveStatus (/home2/arcos/arcos-app/arcos10-fsivr/node_modules/grpc/src/client.js:211:8)
    at Object.onReceiveStatus (/home2/arcos/arcos-app/arcos10-fsivr/node_modules/grpc/src/client_interceptors.js:1306:15)
    at InterceptingListener._callNext (/home2/arcos/arcos-app/arcos10-fsivr/node_modules/grpc/src/client_interceptors.js:568:42)
    at InterceptingListener.onReceiveStatus (/home2/arcos/arcos-app/arcos10-fsivr/node_modules/grpc/src/client_interceptors.js:618:8)
    at /home2/arcos/arcos-app/arcos10-fsivr/node_modules/grpc/src/client_interceptors.js:1123:18
  code: 8,
  metadata:
   Metadata {
     _internal_repr:
      { 'google.rpc.help-bin': [Array],
        'grpc-status-details-bin': [Array] } },
  details:
   'Quota exceeded for quota metric \'speech.googleapis.com/default_requests\' and limit \'DefaultRequestsPerMinutePerProject\' of service \'speech.googleapis.com\' for consumer \'project_number:##########\'.' }

The same error is received by the errHandler registered on the stream and also by process.on("uncaughtException")

Seems similar in a way to another issue in which any invalid or missing credentials would throw an "unhandledRejection" event to process - rather than giving the caller of the library the chance to handle it.

I'm trying to look through the code that leads to the uncaughtException and found this in the nodejs docs:

Error events#
When an error occurs within an EventEmitter instance, the typical action is for an 'error' event to be emitted. These are treated as special cases within Node.js.
If an EventEmitter does not have at least one listener registered for the 'error' event, and an 'error' event is emitted, the error is thrown, a stack trace is printed, and the Node.js process exits.

Seems that the actual "stream" object from streamingRecognize is an instance of Pumpify which inherits from Duplixify which inherits from node native stream.Duplex .
Maybe the 'error' event from the underlying stream isn't being listened for properly...?

hm - I wonder if in my code, I had either (a) not yet listened for "error" or (b) had already unlistened for "error" but another "error" occurred and there was no longer any listener for it...

Thanks for reporting the issue, I tried using latest version of @google-cloud/speech with below code(taken from sample) and it's working as expected.
can you provide the version which you are using and complete code sample than We can dig into more.
also tried below code in loop but it's not crashing the entire node process.
async function main() {

    const fs = require('fs');
    const filename = 'H:/audio.raw';
    const speech = require('@google-cloud/speech');

    const client = new speech.SpeechClient();
    const request = {
        config: {
            encoding: 'LINEAR16',
            sampleRateHertz: 16000,
            languageCode: 'en-US',
        },
        interimResults: false,
    };

    const recognizeStream = client
        .streamingRecognize(request)
        .on('error', (err) => {
            console.error(err) //got error here
        })
        .on('data', data => {
            console.log(
                `Transcription : ${data.results[0].alternatives[0].transcript}`
            );
        });
    fs.createReadStream(filename).pipe(recognizeStream);
}

process
    .on('unhandledRejection', (reason, p) => {
        console.error(reason, 'Unhandled Rejection at Promise', p);
    })
    .on('uncaughtException', err => {
        console.error(err, 'Uncaught Exception thrown');
    });

main().catch(console.error);

it throws exception as below while Quota exceed:
{ Error: Quota exceeded for quota metric 'speech.googleapis.com/default_requests' and limit 'DefaultRequestsPerMinutePerProject' of service 'speech.googleapis.com' for consumer 'project_number:##########'.
    at Http2CallStream.call.on (f:\common-test\speech-demos\node_modules\@grpc\grpc-js\build\src\call.js:68:41)
    at Http2CallStream.emit (events.js:203:15)
    at process.nextTick (f:\common-test\speech-demos\node_modules\@grpc\grpc-js\build\src\call-stream.js:71:22)
    at process._tickCallback (internal/process/next_tick.js:61:11)
  code: 8,
  details:
   'Quota exceeded for quota metric \'speech.googleapis.com/default_requests\' and limit \'DefaultRequestsPerMinutePerProject\' of service \'speech.googleapis.com\' for consumer \'project_number:##########\'.',
  metadata:
   Metadata {
     options: undefined,
     internalRepr:
      Map {
        'google.rpc.help-bin' => [Array],
        'grpc-status-details-bin' => [Array] } } }


Initial variable set to Boolean by default

Describe the Bug with repro steps
Add the "Initialize variable"
Change the data type to Integer
Do something else
Go back to the variable and try to set the initial variable to 1, the only options are true or false.
I have to reload the page to take effect the change of data type
What type of Logic App Is this happening in?
Consumption (Portal)
Which operating system are you using?
Windows
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON

Screenshots or Videos
No response
Browser
Chrome
Additional context
No response

Hi @ikdv thanks for raising this issue. What do you mean with "Do something else" ? I tried to repro it but couldn't do it.
Could you please try it in the following private azure portal url and see if it still repros on your end? https://aka.ms/emastaging
This link has the latest changes on our end. This issue might have been fixed by now.
https://github.com/user-attachments/assets/1f4a513b-cb24-4a09-9997-419afba1672d


dataTables get data from dom without some ""

For example,there is a tr like:  <tr sytle="display"
I don't wanna to get  data  from this DOM.
Is there some one have ideas

Thanks for your question. However, per the Contributing document please post support requests in the DataTables forums. Please also ensure that you link to a running test case showing the issue so it can be debugged - I don't quite understand what you are looking for.


Remove unused opencollective dependency

It's no longer used after the postinstall command was removed:
https://github.com/siddharthkp/bundlesize/commit/e0527bd56b7c88a1b424afee16ab99d275295bcf#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
Removing the dependency avoids pulling in 39 packages unnecessarily.
Fixes #200.
(If it's preferred I can move it to devDependencies instead, however given that all of the opencollective references in this project point to their website and not the CLI, it presumably isn't regularly used.)
Types of changes

Bug fix (non-breaking change which fixes an issue)

Thanks!


Understand how we will use GitHub projects

Just wanted to drop this here as what seemed to be a nicely functioning example from another Google team who I am sure probably have some feedback and thoughts on what is and isn't working https://github.com/orgs/lit/projects/4


COUNT is including expired TTL documents that are pending deletion

Describe the bug
This is not specific to the .NET SDK, so let me know if I should report this elsewhere.
When a document has a TTL (Time to Live) defined, Azure will use a background task to delete the document.  Until the document is actually deleted, Cosmos will not return the expired data to ensure it appears delete as soon as it was supposed to be.
However, it seems COUNT does not reflect the appearance of deletion.
To Reproduce

Create document ID "123" with ttl=N
Wait N seconds
Run SELECT * FROM root c WHERE c.id = '123' - Query returns no data (as expected)
Run SELECT VALUE COUNT(c) FROM root c WHERE c.id = '123' - Query returns "1" (unexpectedly)

Expected behavior
COUNT queries should also filter out any documents whose TTL has already been surpassed.
Actual behavior
COUNT queries are including TTL documents that have already been surpassed and are pending deletion by the background task.
Additional context
This can be tested purely in Azure Portal.

The SDK can't do anything about this, so this is not the place the issue needs to live
The other issue is that fundamentally this can't be fixed - count does not inspect documents, and documents that are present but expired are simpyl present.
There's no secret index that anything could lean on to magically do this for free, and having an implicit behavior that makes count look into documents would be hugely inefficient (and a complete non starter as a behavior change).

@bartelink Thanks for the feedback.  I suspected as much about the SDK not being related to this.  Is there a hub where issues specific to Cosmos should be posted?

There's no secret index that anything could lean on to magically do this for free

I'm surprised to hear there isn't an internal "expirationTs" data somewhere, given the background task already has to efficiently find documents that are pending delete.  It must be implemented differently than I had imagined.

I'm surprised to hear there isn't an internal "expirationTs" data somewhere, given the background task already has to efficiently find documents that are pending delete. It must be implemented differently than I had imagined.

I dont know how it's implemented, but I know the principles.

There will be a field in the document
The indexing policy will show what's indexed

There is an index on the id, so you can count(1) efficiently. But to count other stuff efficiently, there needs to be an index to support it.
The point is that you would not lumber counting with looking inside the documents, as index lookups vs doc inspecions are very different things.
I can't recall whether _ts is implicitly indexed or not, but the way you find out is by looking at the query metrics
https://learn.microsoft.com/en-us/azure/cosmos-db/index-overview
https://learn.microsoft.com/en-us/azure/cosmos-db/index-policy


Adding keyboard enter and spacebar functionality for the Tree component

Added open & close subtree functionality (for accessibility) from keyboard.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Terraria

Game Name (and version if necessary)
Terraria
Hardware Specs (If necessary)
No response
Operating System
Windows 11 22H2
Game State
I couldn't find any issues, however I couldn't test crafting because of the unseeable bottom section of touchscreen in Qt builds.
Screenshots

Additional information
This was tested on the latest nightly build.

I've played this a bit, worked well for me but yeah need to fix the Qt screen size oddities


Fix changing the subjobs toggle icon on toggling

This was broken by the upgrade to Bootstrap 3, because the class names
for icons had changed.

Coverage remained the same at 65.01% when pulling f689f86be6993b2ac81e432cb46acfd55985a32d on guidow:fix_subjob_toggle_icon into 0c2101149d159d1ee8af9fd073ecec753d273055 on pyfarm:master.

Coverage remained the same at 65.01% when pulling f689f86be6993b2ac81e432cb46acfd55985a32d on guidow:fix_subjob_toggle_icon into 0c2101149d159d1ee8af9fd073ecec753d273055 on pyfarm:master.

Coverage remained the same at 65.01% when pulling f689f86be6993b2ac81e432cb46acfd55985a32d on guidow:fix_subjob_toggle_icon into 0c2101149d159d1ee8af9fd073ecec753d273055 on pyfarm:master.

Coverage remained the same at 65.01% when pulling f689f86be6993b2ac81e432cb46acfd55985a32d on guidow:fix_subjob_toggle_icon into 0c2101149d159d1ee8af9fd073ecec753d273055 on pyfarm:master.

Looks good, merging.


support any environment name

The environment tier type currently restricts environment names to be
either: 'production' | 'staging' | 'development', which may not map up
with what environemnets are named
This change allows environments with any names

closing, change introduced here

Thanks @KlotzAndrew! Didn't realize you had put up a PR for this already so we implemented it ourselves.


Warn if packages are missing wheels for the current python

There are many packages in Python that are built against the unstable CPython C ABI, which publish wheels for only a set of Python versions, often simply the oldest one supported to the latest at date of publishing. When running uv lock (also as part of uv sync) and a package has a wheel that is compatible (correct platform etc.) save for the python version (e.g. cp38 while we're on cp310), we should note this to the user: The sync goes from fast to very slow since we need to build the package, and often building fails because those source distributions aren't meant to be built on user's machines. We need to figure out when to show this, we shouldn't do it on every sync, but we should do when adding such a package and maybe the first time syncing on a particular Python version (e.g., there isn't a built wheel in cache yet).

I believe our issues are connected: #7435
I would like uv add to should support (either via flag or config) using the latest compatible wheel (based on the project's requires-python field) instead of defaulting to building from source.
For reference, pip offers similar functionality with the --prefer-binary flag or by setting prefer-binary = true in the pip.conf file, and uv pip install also supports this with --only-binary (albeit you need to specify the package(s) you want to install as binary or use :all:)