Fine grained control over what EXIF tags get stripped and which don't

Is your feature request related to a problem? Please describe.
It's a hypothetical. It would be nice to be able to specify some of the fields that would get kept and some that would be removed.
For example, the camera details are good (Like type, focal length, but model, gps no)
Describe the solution you'd like
Configurable option of filtering
I.e.

allowTags: Model
removeTags: exif:SubSecTim

Describe alternatives you've considered
None.
Additional context
None.

I would definitely consider this (or maybe something less granular), but I don't have the bandwidth to work on something this big at the moment.


Setting Source IP from Highlevel API

Hi,
I am facing the problem to set the source IP of our snmp requests and didn't find a way to do it via the highlevel API. Is this intended or is there an undocumented way to do it or did I missed it in the docs? I'm using the asyncio highlevel API.
Thanks for any help!

You should use the UdpTransport.Target.setLocalAddress() method for that. Apparently, it was missing in the documentation so I just added it there.
In other words:
    snmpEngine = SnmpEngine()
    errorIndication, errorStatus, errorIndex, varBinds = yield from getCmd(
        snmpEngine,
        CommunityData('public', mpModel=0),
        UdpTransportTarget(('demo.snmplabs.com', 161)).setLocalAddress(('<IP_ADDRESS>', 0)),
        ContextData(),
        ObjectType(ObjectIdentity('SNMPv2-MIB', 'sysDescr', 0))
    )

Thank you very much!


No documentation about asIntN() and asUintN() methods

Hi, there are some documentation about how  BigInteger wraps the signal of a number?
As (2018) "BigInt is being added as a native feature of JavaScript. This library now works as a polyfill", is important to check how is orking about it.
See https://developer.mozilla.org/pt-BR/docs/Web/JavaScript/Reference/Global_Objects/BigInt#Methods

Probably, could be implemented as:
bigInt.asUintN = function (bits, bigint) {
  if (typeof bigint === "bigint") {
    return BigInt.asUintN(bits, bigint);
  }
  const p2bits = bigInt(1).shiftLeft(bits);
  const mod = bigint.and(p2bits.subtract(1));
  return mod;
};
bigInt.asIntN = function (bits, bigint) {
  if (typeof bigint === "bigint") {
    return BigInt.asIntN(bits, bigint);
  }
  const p2bits = bigInt(1).shiftLeft(bits);
  const mod = bigint.and(p2bits.subtract(1));
  return mod.greaterOrEquals(p2bits.subtract(mod)) ? mod.subtract(p2bits) : mod;
};

If needed.

If someone wants to add a pull request for this feature I'll merge it in.


Field Uninteractable

Hello. I have followed the instructions written but I still cannot make this work. The autocomplete field does not react to my click at all, and it doesn't invoke the click event either. It is not showing any result and I see no error in my console.
I am building a progressive web app with Angular 4.4.4 and Ionic 3.8.0.
Here is my service class:
import {AutoCompleteService} from 'ionic2-auto-complete';
import {Injectable} from "@angular/core";
import {Constants} from "./constants";

@Injectable()
export class SchoolNameService implements AutoCompleteService {

    labelAttribute = null;

    getResults(keyword:string) {
        let results = Constants.schoolList.filter(input => input.startsWith(keyword));
        return results;
    }
}

Constants.schoolList is a simple array of string. However, I believe this part of the code is already correct.
Anyway, here is my HTML:
<ion-header>

    <ion-navbar hideBackButton="true">
        <ion-title>Register</ion-title>
    </ion-navbar>

</ion-header>

<ion-content padding>
    <form [formGroup]="mainForm">
        <ion-item>
            <ion-label>First Name</ion-label>
            <ion-input type="text" formControlName="firstName"></ion-input>
        </ion-item>
        <ion-item>
            <ion-label>Last Name</ion-label>
            <ion-input type="text" formControlName="lastName"></ion-input>
        </ion-item>
        <ion-item>
            <ion-label>School</ion-label>
            <ion-auto-complete [dataProvider]="schoolNameService" formControlName="schoolName"></ion-auto-complete>
        </ion-item>
        <ion-item>
            <ion-label>Email</ion-label>
            <ion-input type="email" formControlName="email"></ion-input>
        </ion-item>
        <ion-item>
            <ion-label>Type</ion-label>
            <ion-select formControlName="accountType">
                <ion-option value="student">Student</ion-option>
                <ion-option value="teacher">Teacher</ion-option>
            </ion-select>
        </ion-item>
        <button ion-button type="submit" [disabled]="!mainForm.valid" block>Register</button>
    </form>

</ion-content>

And a part of my page:
constructor(public navCtrl: NavController, public formBuilder: FormBuilder, private loading: LoadingController, private http : HttpClient, private account : Account, private alertCtrl: AlertController, public schoolNameService : SchoolNameService) {
        this.mainForm = this.formBuilder.group({
            schoolName : [],
            accountType : ['student', Validators.required ],
            firstName : ['', Validators.required ],
            lastName : ['', Validators.required ],
            email : ['', Validators.required ]
        });
    }

There is no error regarding dependencies or providers or something like that, so far. But I believe I must have missed something. Anyway, thanks for your attention. I’m looking forward to your reply.

Hey @piyachetk , if you place the autocomplete outside of ion-item?
For the sake of testing, let's just locate it above the <form>, and see what happens.
There's a known issue in ionic with ion-item and custom content (see #95 and https://github.com/ionic-team/ionic/issues/6643, and there are many more issues opened about this topic).

I moved it outside ion-item and it now works like a charm. Thank you.


Chained method calls should be able to be commented out

Description
I'm starting to do much larger and more functional functions, and sometimes need to comment out a filter or similar chained method off array, but it doesn't work and I have to delete the line to get the outcome I'm after
Example:
#let demo = {
  range(1, 20)
  // .filter(calc.even)
  .map(x => str(x, base: 16))
}

#demo

Expected outcome: the filter method is omitted, the output is just the range shown in hex
Actual: error
This markup in “main.typ”…
…caused this problem:
Unexpected dot

Reproduction URL
No response
Operating system
Web app
Typst version

[X] I am using the latest version of Typst

Interestingly, it works if you replace the braces by round parentheses:
#let demo = (
  range(1, 20)
  // .filter(calc.even)
  .map(x => str(x, base: 16))
)

#demo

This is still an issue, though.

Yes this works because parentheses only contain one expression where braces can contain multiple.

Yes this works because parentheses only contain one expression where braces can contain multiple.

Does allowing this cause any ambiguity though?

Not really, since there is already a special case for when the next line starts with a dot.

Minimal repro that can be handled by the Discord channel's bot-corner:

#{
  (1,2)

  .first()
}

works, output is 1.

#{ (1,2)/*comment*/.first() }

works, output is 1.

#{
  (1,2)
  // comment
 .first()
}

results in the error as described, "unexpected dot".

Minimal repro that can be handled by the Discord channel's bot-corner's ?r as well as ?ast:

These run:
(A)
#{
  "1"

  .at(0)
}

(B)
#{ "1"/*comment*/.at(0) }

(C)
#{
  "1" // comment
 .at(0)
}

These don't: "unexpected dot".
(D)
#{
  "1"
  // comment
 .at(0)
}

(E)
#{
  "1"
  /* comment */.at(0)
}

It appears that in example (D), the parser did not eat() the newline and comment as it is supposed to, at https://github.com/typst/typst/blob/a33d8bf32208ef0fe8556200dd0c9c5a1ad10c54/crates/typst-syntax/src/parser.rs#L788 because it thinks "1" is followed by a SyntaxKind::Eof, which can't be skip()-ed.
In example (A) though, the parse did eat() the newlines so the parser arrives at the dot.


Folder Structure for JS SPA

Move index.html outside of the JavaScriptSPA folder.
This allows any URL to simply return the index if it is not found in the JavaScriptSPA folder. By index.html being inside of the JavaScriptSPA folder, the code below is superfluous:
// Set up a route for index.html.
app.get('*', function (req, res) {
    res.sendFile(path.join(__dirname + "/index.html"));
});

The application functions properly, but the above piece of code is never hit and is confusing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c6d2219-cb28-5527-1079-6e3195cad282
Version Independent ID: 70c2aad0-6883-51a9-fed7-01be62302483
Content: Tutorial: Create a JavaScript single-page app that uses the Microsoft identity platform for authentication - Microsoft Entra
Content Source: articles/active-directory/develop/tutorial-v2-javascript-spa.md
Service: active-directory
Sub-service: develop
GitHub Login: @mmacy
Microsoft Alias: marsma

@pettewayshade
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

The following reviewer(s) could not be added because they aren't a valid GitHub ID, aren't a valid collaborator on this repo, or are the author of the PR: derisen

The following reviewer(s) could not be added because they aren't a valid GitHub ID, aren't a valid collaborator on this repo, or are the author of the PR: derisen

@mmacy for sure. @JamesTran-MSFT feel free to assign this on me.

@derisen Ha! It's an issue, sorry. Should likely result in a PR, though. :)
#reassign:derisen

@pettewayshade thank you very much for catching this. You're right, the code is never hit. However, instead of moving index.html, I would prefer to update the code instead:
// Set up a route for index.html.
app.get('*', function (req, res) {
    res.sendFile(path.join(__dirname + "/app/index.html"));
});

Keeping the static assets in the same folder is more idiomatic for Express.js, but another reason I'd like to keep index.html in the app folder is that it makes it convenient for folks who'd like to host their files on Azure storage static websites, which could be as simple as right click > publish to static storage on VS Code.
Will make a PR to update the article.


Prevent Git Gateway users with invalid tokens from logging in.

- Summary
Fixes #647. Also addresses the case where a user changes their GH repo from public to private after Git Gateway is set up.

- Test plan
Manually tested.

- Description for the changelog
Prevent Git Gateway users with invalid tokens from logging in.

- A picture of a cute animal (not mandatory but encouraged)

Deploy preview for netlify-cms-www ready!
Built with commit 6e50b9584471d17cd53eb3296cf877363f04de5a
https://deploy-preview-1209--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 6e50b9584471d17cd53eb3296cf877363f04de5a
https://deploy-preview-1209--cms-demo.netlify.com

@erquhart This is ready to review/merge if you want it in the release.


[BAT] add configuration test case

Coverage increased (+0.04%) to 56.159% when pulling 3049f36a4d3e0258e74bff67cfee988654f52751 on wy65701436:drone-test into b1578bd993ca8e6dbe5b1ac76165f0352132cce4 on vmware:drone.

Coverage remained the same at 56.116% when pulling 3049f36a4d3e0258e74bff67cfee988654f52751 on wy65701436:drone-test into b1578bd993ca8e6dbe5b1ac76165f0352132cce4 on vmware:drone.


Allow start options to be passed in

Thank you for making this awesome package!
I was trying this out on a large project with lots of api calls and wanted to be able to warn or block unhandled request with the onUnhandledRequest argument for start.
I am not seeing any guidelines configured for this repo so please let me know if I should make any adjustments to this PR.
Thanks!

Thanks for adding this feature @Sivli-Embir. I have merged your PR and released it under v1.1.0.
🎉🎉🎉🎉🎉🎉


Reland: Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder

Reland https://github.com/flutter/flutter/pull/141818 with a fix for a special case: If only background is specified for TextButton.styleFrom or OutlinedButton.styleFrom it applies the button's disabled state, i.e. as if the same value had been specified for disabledBackgroundColor.
The change relative to #141818 is the indicated line below:
final MaterialStateProperty<Color?>? backgroundColorProp = switch ((backgroundColor, disabledBackgroundColor)) {
  (null, null) => null,
  (_, null) => MaterialStatePropertyAll<Color?>(backgroundColor), // ADDED THIS LINE
  (_, _) => _TextButtonDefaultColor(backgroundColor, disabledBackgroundColor),
};

This backwards incompatibility cropped up in an internal test, see internal Google issue b/323399158.

The TextButton and OutlinedButton tests with the // Regression test for an internal Google issue: b/323399158 comments check the special case that caused the revert. They're at the end of their respective test files.


UmbrellaDocs/action-linkspector: Uncover broken links in your content using Linkspector GitHub action.

https://github.com/UmbrellaDocs/action-linkspector

Replace markdown link check with this.

Not going to use because it requires chrome installation


Build without debug options by default, rename library to libvita2d_fbo

The default build as using -Og -g -DDEBUG_BUILD. I switched it to -O3, like the master branch.
I also renamed the header and the generated library to (lib)vita2d_fbo because it would overwrite the (lib)vita2d files from the standard branch.
I also added some scripts to make building/cleaning easier, but those are besides the point. I'm just too lazy now to create a separate branch and a PR. Just delete them if you want :sweat_smile:

Closing so this can be handled in #7


nyxt: Version 2 pre-release-7 -> 2.0.0

Motivation for this change
Upstream release of final v2.0.0 : https://nyxt.atlas.engineer/article/release-2.0.0.org
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 124024 at 346ae1ce run on x86_64-linux 1

2 packages built successfully:

lispPackages.nyxt
nyxt

2 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/browsers/nyxt/default.nix:33:3:
   |
33 |   installPhase = ''
   |   ^

warning: missing-phase-hooks
checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/applications/networking/browsers/nyxt/default.nix:46:3:
   |
46 |   checkPhase = ''
   |   ^


graph/users: enable/disable users

Describe the problem
Our current implementation of the graph API does not allow to query the enabled/disabled state of users. Neither does it support setting it.
For the case where our libregraph implemenation is backed by our own User/Groupmanagement libregraph/idm (or another LDAP Server under our control) we can "invent" our own scheme of enabling/disabling users.
For cases where our libregraph is backed by an extermal service i.e. a read-only Active Directory we need some more flexibility to support whatever the external service provides. For AD e.g. that would need we need to supported the userAccountControl Bitmask attrribute.
Product considerations

The ways to disable users vary from Directory to Directory
The product needs to react to users which are disappearing from LDAP
Currently nothing happens
When the user is the last "manager" of a space, the space will be abandoned
Timeline: Before GA / After GA

Ways to handle it

Disable the users home space
Create a multi factor workflow to "unblock" an abandoned space.
Support the Microsoft AD way

@pmaier1 I could imagine that we "disable" the users home space when he disappears in LDAP.
We still have one challenge: If the user has been the only "manager" of a project space, it will result in a "stuck" situation.
We will certainly need a solution how to unblock a space with a kind of "multi-factor" process. @hodyroff like we discussed that already.

I would like to discuss that in Product Board.

PB

Define an LDAP scheme for disabled users ("oC expects this behavior for disabled users")
Later: Implement mappings for different LDAP implementations for disabled users
Behavior of user disable should be analogous to oC 10 (Use case: "temporary suspended")
Next: PB2 to define flow for short-term solution when a user is not in LDAP anymore

When the user is the last "manager" of a space, the space will be abandoned

This needs a general solution as there are other ways to produce this scenario (e.g., simply deleting the last "manager" user).

Basic support for enable/disable users has been added here: https://github.com/owncloud/ocis/pull/5588


Vue.config.errorHandler to handle Vue.nextTick and vm.$nextTick exceptions

Our app attempts to catch unexpected exceptions so they can be captured and reported back to base.
I can use Vue.config.errorHandler for Vue render and watch exceptions, but this doesn't catch exceptions within Vue.nextTick or vm.$nextTick closures.
For now I've interposed the nextTick and prototype.$nextTick functions to catch the errors, but this feels fragile.
The suggestion is that the existing errorHandler should be used to report Vue.nextTick and vm.$nextTick exceptions.

Moving the discussion to #4730


Add -PrimaryKey parameter to Compare-ObjectGraph

An -PrimaryKey parameter should be mutual exclusive with the list order switches.

Implimented in version 0.0.8.
Reduced list order switches to just -MatchOrder as the new -PrimaryKey switch also gives some control on specific related list items. Besides, for other specific list nodes the pathname of the default output could be used to target specific list (and dictionary) nodes.


MainActor Store Isolation

Stores have been required to be on the main thread for a long time, but because they predate Swift concurrency, we adopted a model that was standard at the time: pushing that responsibility on the user, and warning them when we detect access off the main thread.
This PR adopts a more modern sensibility by adding @preconcurrency @MainActor to APIs that we require to be on the main thread. We'll use @preconcurrency to avoid breaking changes, but the main advantages:

It will prevent stores from being created or interacted with off the main thread, and it will warn the user at compile time if they attempt to do so without awaiting.
Tests no longer need to be marked @MainActor for the TestStore.

This PR should not prevent us from providing stores the ability to work on non-main actors, and should actually help us get closer to that goal.

Some 5.10 warnings we should consider before merging, but generally things are looking good in 6.0!


Create script Dialog changes extension automatically.

Fix on Issue #6878.
I'm assuming that a file or a folder named with a "." is invalid in any system when you change the language of your script. If that is untrue, the fix is literally just taking the "_path_changed(file_path->get_text());" from the original if statement.

Just thought about the case in which you want to save something on an hidden folder; in Linux they are preceded with a ".". I'll create a fix on it with an iterator, just to check if the character is preceded with a "/", but I'm not sure if Godot even show hidden folders on its dialog screen.

The name of a file/folder cannot be just . but it can have a . anywhere, even in the beginning. This is valid on Windows too, you may have some trouble creating them from explorer, but once they're there you can use it like any file without issues.

I see. If I just check the basename for a "." and do a reverse find on the whole string in case that is true, I'll not get any folder dot, right?

Done! Now it checks if there is a dot after the basename, and only changes it in case it is true. Just tested changing a script inside a ".folder/" and it works.

Superseded by #7082.

The new superseded solution is much more efficient than mine, hahaha. I was trying to solve the Issue in a more elegant way, but I couldn't find any modification I could make on just that method - glad that 3.0 will have the automatic change on script extension that I tried creating.
Deleting the branch on my local rep!


web: make applyAttrs in the second overloaded TagElement nullable to be consistent with the first one

From what I understand, for non-inline functions passing null is a bit more efficient than passing an empty lambda, and that's why most functions in this library have the signature attrs: AttrBuilderContext<HTMLElement>? = null. Then there is no reason the second overloaded TagElement function shouldn't be like that, so I guess this is a small mistake that should be fixed.

I accidentally created the same PR #1822

thanks! lgtm


Add support of loading a single file in DoraLoadCommand

If the file is a single file, don't use listing.

alluxio-bot, merge this please

alluxio-bot, merge this please


bug: max-depth not working with apollo gateway

Hello, we've been working with apollo federation, and we were looking at alternatives for securing our graphql API, and graphql-armor seems to address many of the security concerns we have identified.
When testing max-depth, for some reason, it seems to identify fields as "depth" as you can see in the images below.

I put my sample code in this repo: https://github.com/fimassuda/apollo-federation-example
Thank you for the great work on consolidating all these security issues for GraphQL in a centralized library. Looking forward to see the increase of adoption of this library.

Hello @fimassuda,
Thanks you for your report and kudo for the sample code, I'll handle it asap.

I think this is the same thing I ran into: https://github.com/Escape-Technologies/graphql-armor/pull/119

Hello @fimassuda,
I confirm this has been fixed by @hayes in #119.
Thanks to both of you for participating.

Thanks @c3b5aw and @hayes for the quick fix.
I have one last question, is there a way to get how deep the query was? I was thinking of reporting in our logs and as part of the error message.

I have one last question, is there a way to get how deep the query was? I was thinking of reporting in our logs and as part of the error message.

@fimassuda,
Currently, no. This is doable, I'll open a dedicated issue #124


Output from Colorize Ruby gem doesn't appear colorized

Colored console output from the Colorize Ruby gem doesn't appear colorized in the Jenkins console.
In addition to the color code, the gem includes the mode and background color. Are these not supported?
"\033[#{color_parameters[:mode]};#{color_parameters[:color]+30};#{color_parameters[:background]+40}m#{color_parameters[:uncolorized]}\033[0m".set_color_parameters( color_parameters )

Thanks!

according to http://stackoverflow.com/questions/1401002/trick-an-application-into-thinking-its-stdin-is-interactive-not-a-pipe
the 'script'  command can solve this for you. Imho it should be somewhere prominent on the howto ;-)

@dothebart Please contribute to the doc.


Feature request: 'archive' should honor deletion

This is a request to make 'archive' remove tweets on re-running. If that requires checking all accessible tweets, it could be enabled by flag so the default run speed is reasonable.
Use case: Right now I'm using this to archive my friends' twitter, and it's basically making them uncomfortable that posting something online guarantees it will never be removed.
P.S. believe it or not, this is currently the best tool for archiving twitter that I've found.

This is difficult to do right now because of the way the Twitter api limits the number of tweets the archiver can retrieve. It's possible to have a tweet deleted outside of the range of the tweets received, so the archiver would never know about its deletion.
A different approach might be making something else that "cleans" the archive as a side task. It could check each id in the archive for existence and remove those that are gone.
This is a good point regardless. Twitter says that developers should honor deletions in their applications. Folks rolling out bots for their friends or others should be aware of this issue.

Honoring deletions only within the 30,000 tweet archive limit would not be too bad of a compromise for me--I think most tweets get deleted within a day or two, except in cases where someone is closing their entire account.

The limit is more like 3,200 tweets, by the way! Mentioned here: https://dev.twitter.com/rest/reference/get/statuses/user_timeline


rspec configuration changed from spec/suport to rails_helper.rb

config line in rspec is now added to the rails_helper.rb file so that factor girl methods can be accessed the previously on support/factory_girl.rb which dont work.

@xw19 I wouldn't actually recommend moving FG configuration into rails_helper itself; instead, I'd require the file explicitly (since the code to require everything from spec/support isn't enabled by default). This seems to better follow "single responsibility principle", since spec/support/factory_girl.rb is the canonical place for FG config. Thoughts?

@joshuaclayton I agree but in documentation it should be clearly mentioned to require that file in rails_helper

See #1141


Grahpical desktop ?

any GUI desktop for it ? since it can run xfce4

its possible, but requires you to download a LOT of dependencies. Not really worth the time and effort imo

no, there is no graphical desktop available currently.

https://www.youtube.com/watch?v=qvtYyLYRKhI


Improved for decode large file.

Thanks! I will check this out when I get the time. I'm a little busy at
the moment.

OK. I cherry-picked the commits in manually. Thanks.


expose ffprobe

Is your feature request related to a problem? Please describe.
A user asked if we can get the length of an audio file
Describe the solution you'd like
we would like to be able to run ffprobe on the file to get lengths etc.
Additional context
The query we got: "I'm trying to chunk an audio into 60 sec segments. How do I get the length of an audio file to break out of the chunking loop?"

Is it on the roadmap? At least basics metadata such as getting width, height, duration (for videos)

Definitely need ffprobe access


Gobber Ores are broken when mined by modded pickaxes

Any Modded Pickaxe I use can break the Gobber Ores, even the weak ones.
https://user-images.githubusercontent.com/118773544/206326552-dbdebbe9-604d-4eab-9bf2-01568da3d99a.mp4

This becomes a moot point in 1.20.5+ due to the removal of mining level

Any chance of adding in like a toggle for modpacks using mods like tetra or silentgear to allow for nether/end gob to have the same mining level as overworld gob as a dirty patch for pre 1.20.5?


CS3: implement locks as xattrs

This fixes #125. To be reviewed.

Merging as this was demonstrated to be a no-op for regular implementations providing locks. It will be used as part of the ScienceMesh demos.


[Discovery] Upgrade sql  and Fix some config bug

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4808 (0256f41) into master (1c21ed0) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4808      +/-   ##
============================================
+ Coverage     64.99%   65.14%   +0.15%
+ Complexity     8157     8151       -6
============================================
  Files          1138     1138
  Lines         33457    33464       +7
  Branches       2971     2971
============================================
+ Hits          21744    21801      +57
+ Misses         9987     9934      -53
- Partials       1726     1729       +3

Impacted Files
Coverage Δ

...nyu/admin/discovery/DefaultDiscoveryProcessor.java
10.30% <0.00%> (-0.33%)
:arrow_down:

.../apache/shenyu/admin/model/vo/ProxySelectorVO.java
30.76% <0.00%> (-2.57%)
:arrow_down:

...u/admin/service/impl/ProxySelectorServiceImpl.java
20.23% <0.00%> (ø)

... and 40 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Aggressive_Cows_Problem

Pls assign this issue to me

https://github.com/risingstar-bit/Compose-Community/pull/204#issue-1424054729 @risingstar-bit Kindly have a look

#204 (comment) @risingstar-bit Kindly have a look

Okay Proceed

https://github.com/risingstar-bit/Compose-Community/pull/204#issue-1424054729 @risingstar-bit I have made the PR pls check

#204 (comment) @risingstar-bit I have made the PR pls check

Already merged your PR


add GodotReport to Website category

The website This Week in Godot is no longer make new issues start from April based on this tweet: https://twitter.com/ThisWeekInGodot/status/1510729093565796356. And Kaiju has start his own report in https://www.thegodotreport.com/ . Please add this to the Website category

I replaced This Week in Godot by The Godot Report with https://github.com/godotengine/awesome-godot/commit/bba41be4aa3cd1677afbd39da2ab4283e671cbf4.


changed format of line listen

This new syntax is more consistent with the comment and pass test when editing default_server.
It is more direct for the user I think.

This is not the way NGINX is explaining this in the documentation. We are going to follow NGINX on this. Thanks for the effort!


test(primitives/types)

Detailed description:

[x] test ConsumedWeight (fix CheckedAccrue method)
[x] test DispatchResult
[x] test DispatchResultWithPostInfo
[x] test Event
[x] finish Era tests
[x] test SignedExtra

Which issue(s) this PR fixes:
Fixes #216
Special notes for your reviewer:
Checklist

[ ] Documentation added
[x] Tests updated

need to fix something


Idea: An easy, concise way of making elements

const Element = new Spuck({ type: 'h1', parent: '#app', class: 'first second third', id: 'id' }).render()

This way is too big and rather confusing and can still get potentially confusing, something more concise is needed.

TPCI way can be a solution

Instead of doing this:

TPCI way can be a solution

Instead of doing this:
const Element = new Spuck({ type: 'h1', parent: '#app', class: 'first second third', id: 'id' }).render()

We could use some function, that will return the required object by formatting this:
const Element = tpci('h1:#app:first,second,third:id')

This would return an already rendered element.


Hide or Unhide wallets/Vault:

Wallets or Vaults can be hidden and unhidden from App settings.
When hiding there should be a warning if there is balance.

https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/0cf4cd89-a6d6-4527-9159-5e440a11c4b1/


Don't obtain hms event id when the hive_incremental_sync is false

What type of PR is this：

[ ] bug

Which issues of this PR fixes ：

Fixes #
In most case, if hive metastore does't turn on the event option, it will return 0 when the client  call the get_current_eventId interface.
but if the user's hms has some auth-related options, there will throw an internal error on hms. So we will don't to call the get_current_eventId to avoid that create table failed.
fe.log error:

hive metastore log error:

Problem Summary(Required) ：

[FE PR Coverage check]
:disappointed: fail : 1 / 2 (50.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/external/hive/HiveMetaClient.java
1
2
50.00%

@Mergifyio backport branch-2.2


Make it possible to launch tikv-server with non-rocks KV engines

What problem does this PR solve?
Issue Number: close https://github.com/tikv/tikv/issues/10528
Part of https://github.com/tikv/tikv/issues/6402
Problem Summary:
Make it possible to typecheck tikv-server with non-rocks KV engines, and to launch tikv-server with PanicEngine.
What is changed and how it works?
What's Changed:
This is the last set of steps necessary to run tikv-server with a non-rocks KV engine. After this patch set it is possible to launch tikv-server with PanicEngine. This engine doesn't do anything, but it does ensure that tikv-server typechecks with alternate engines.
The big changes here are in components/server/src/server.rs, which is responsible for constructing the server.
These changes are kinda ugly, so this needs some good review.
There are still some limitations. Primarily, non-rocks engines are not able to launch the debug service or the backup service. These two still have hard rocks dependencies for now. This patch works around these limitations by introducing a CreateKvEngine trait that is implemented for all KV engines, and that contains some empty methods for PanicEngine.
The CreateKvEngine trait should be able to be deleted with time and refactoring.
Note that this patch series contains commits that temporarily introduce some ugly dynamic casts; those dynamic casts are later removed before the end of the series.
I have an out of tree engine, SimpleEngine, that is almost able to complete the startup sequence and reach a steady-state where it doesn't crash. I am focused on getting that engine to more-or-less work, while reworking engine_traits to remove rocksisms, before attempting to add a "real" alternate engine. For others though, it should be feasible to work toward alternate KV engines right now.
Related changes
Check List
Release note
None

I can't reach ci.pingcap.net to see the error.

[2021-07-06T20:02:44.839Z] error: this `else { if .. }` block can be collapsed

[2021-07-06T20:02:44.839Z]    --> components/server/src/server.rs:164:12

[2021-07-06T20:02:44.839Z]     |

[2021-07-06T20:02:44.839Z] 164 |       } else {

[2021-07-06T20:02:44.839Z]     |  ____________^

[2021-07-06T20:02:44.839Z] 165 | |         if !config.raft_engine.enable {

[2021-07-06T20:02:44.839Z] 166 | |             run_impl!(engine_panic::PanicEngine, RocksEngine)

[2021-07-06T20:02:44.839Z] 167 | |         } else {

[2021-07-06T20:02:44.839Z] 168 | |             run_impl!(engine_panic::PanicEngine, RaftLogEngine)

[2021-07-06T20:02:44.839Z] 169 | |         }

[2021-07-06T20:02:44.839Z] 170 | |     }

[2021-07-06T20:02:44.839Z]     | |_____^

[2021-07-06T20:02:44.839Z]     |

[2021-07-06T20:02:44.839Z]     = note: `-D clippy::collapsible-else-if` implied by `-D warnings`

[2021-07-06T20:02:44.839Z]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if

[2021-07-06T20:02:44.839Z] help: collapse nested if block

[2021-07-06T20:02:44.839Z]     |

[2021-07-06T20:02:44.839Z] 164 |     } else if !config.raft_engine.enable {

[2021-07-06T20:02:44.839Z] 165 |         run_impl!(engine_panic::PanicEngine, RocksEngine)

[2021-07-06T20:02:44.839Z] 166 |     } else {

[2021-07-06T20:02:44.839Z] 167 |         run_impl!(engine_panic::PanicEngine, RaftLogEngine)

[2021-07-06T20:02:44.839Z] 168 |     }

[2021-07-06T20:02:44.839Z]     |

[2021-07-06T20:02:44.839Z]

[2021-07-06T20:02:44.839Z] error: this `else { if .. }` block can be collapsed

[2021-07-06T20:02:44.839Z]    --> components/server/src/server.rs:164:12

[2021-07-06T20:02:44.839Z]     |

[2021-07-06T20:02:44.839Z] 164 |       } else {

[2021-07-06T20:02:44.839Z]     |  ____________^

[2021-07-06T20:02:44.839Z] 165 | |         if !config.raft_engine.enable {

[2021-07-06T20:02:44.839Z] 166 | |             run_impl!(engine_panic::PanicEngine, RocksEngine)

[2021-07-06T20:02:44.839Z] 167 | |         } else {

[2021-07-06T20:02:44.839Z] 168 | |             run_impl!(engine_panic::PanicEngine, RaftLogEngine)

[2021-07-06T20:02:44.839Z] 169 | |         }

[2021-07-06T20:02:44.839Z] 170 | |     }

[2021-07-06T20:02:44.839Z]     | |_____^

[2021-07-06T20:02:44.839Z]     |

[2021-07-06T20:02:44.839Z]     = note: `-D clippy::collapsible-else-if` implied by `-D warnings`

[2021-07-06T20:02:44.839Z]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if

[2021-07-06T20:02:44.839Z] help: collapse nested if block

[2021-07-06T20:02:44.839Z]     |

[2021-07-06T20:02:44.839Z] 164 |     } else if !config.raft_engine.enable {

[2021-07-06T20:02:44.839Z] 165 |         run_impl!(engine_panic::PanicEngine, RocksEngine)

[2021-07-06T20:02:44.839Z] 166 |     } else {

[2021-07-06T20:02:44.839Z] 167 |         run_impl!(engine_panic::PanicEngine, RaftLogEngine)

[2021-07-06T20:02:44.839Z] 168 |     }

[2021-07-06T20:02:44.839Z]     |

[2021-07-06T20:02:44.839Z]

Look like you need to run cargo clippy.

Clippy errors fixed. Rebased.

Rebased.

Rebased.

Rebased.

/test

Rebased.

Here is the code that causes the error, since it isn't obvious from the diff:
https://github.com/solana-labs/solana/blob/813628d833b518c9a8ee65afa109a342af376386/client/src/http_sender.rs#L126-L161

I've tried to rebase this once and failed. Requires some significant rework.

Closing in favor of https://github.com/tikv/tikv/pull/10785.


sandboxify: Reverse child/parent logic to preserve exec chain.

Avoid a double fork by making the sandboxify process exec into the
target binary and have the child instead act as the tracer.
This ensures that the return status of the executed binary is the the
return of the whole command line.
It also allows proper supervision without hack (ala systemd
Type=forking) as the launcher of the command line can simply
waitpid().
The reversal of the logic works around the kernel's yama protection by
having the parent first grant the child PTRACE access and then
wait()'ing on the child's PID. This, on one hand, gives time to the
child to setup the trace and suspend SECCOMP but also allows to detect
death of the child and properly abort.
The child sets up the trace mostly as before with the main difference
being that it overrides the wait4 syscall of the parent, making it
fail and allowing the parent logic to continue to loading SECCOMP
filters and calling execvp.

I have updated the PR with pipe now, which makes it portable.
As for your concern with YAMA and capabilities, I am not really how to approach this.
As I understand it YAMA allows you do do away with CAP_SYS_PTRACE in mode 0 and 1 (with SET_TRACER). In mode 2 that is not possible and you must have that capability.
On the other hand, you must have CAP_SYS_ADMIN anyway to suspend the SECCOMP filters.
No, no matter what, you won't be able run any of this as an unprivileged user.

Yes, having a second look at https://github.com/torvalds/linux/blob/cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2/security/yama/yama_lsm.c#L354 looks like we need to have the same set of capabilities for current and proposed setup regardless of YAMA configuration: that is in 1 we can either trace the child or do the parent do PR_SET_PTRACER. In 2 we need CAP_SYS_PTRACE anyway.

@ignatk I think I address all your comments. PR is no longer a draft. Let me know if there is anything else.

Thank you! Overall looks good. I tried to test it though and it seems I now require CAP_SYS_PTRACE even though I don't have YAMA compiled on my test system:
ignat@dev:~/sandbox$ zgrep YAMA /proc/config.gz
# CONFIG_SECURITY_YAMA is not set
ignat@dev:~/sandbox$ sudo setcap cap_sys_admin+ep ./sandboxify
ignat@dev:~/sandbox$ ./sandboxify /home/ignat/git/sandbox/helloworld
failed to attach to parent: Operation not permitted
child exited
ignat@dev:~/sandbox$ sudo setcap cap_sys_admin,cap_sys_ptrace+ep ./sandboxify
ignat@dev:~/sandbox$ ./sandboxify /home/ignat/git/sandbox/helloworld
Hello, world!

I'll try to look into the kernel code to understand what is happening here to see if we need any adjustments.

Sorry for the delay on this. It seems the additional PR_SET_PTRACER is fully implemented in the Yama LSM, therefore if it is not enabled in the kernel config, we always need the CAP_SYS_PTRACE capability.
After giving some thought I still think the convenience added by this approach out-weights the desire not to add another capability requirement (adding to the fact we already require the quite powerful CAP_SYS_ADMIN anyway).
I was just going to ask to update the README file with this, but it seems I've already done so in 5cfd5ee03aabbf5d13366b85737b7fe51ea2113e, so merging this as is.
Thank you for the contribution!


Failed to load native core functions! Couldnt find at location! (Ubuntu 20.04 + Debian 11)

Unhandled Exception:
System.IO.FileNotFoundException: Failed to load native core functions! Couldnt find at location /home/foo/Desktop/ReClass.NET-master/build/Debug/x64/NativeCore.so
I have #241 on both x64 and x86 builds on Ubuntu 22.04 and Debian 11

Built with docker and msbuild, error identical.


[Keyvault] Update Quickstarts to use the new packages

The QuickStart for Nodejs uses the old package. We should be showcasing the new package @azure/keyvault-keys that we have released instead.
We can do this by create a PR with changes to the markdown file https://github.com/MicrosoftDocs/azure-docs-pr/blob/master/articles/key-vault/quick-create-node.md
Please sync up with @AlexGhiondea and @schaabs on the approach here in case we want to standardize the format/text across the languages

Just for future reference, the Python docs seem to have been updated already: https://docs.microsoft.com/en-us/azure/key-vault/quick-create-python

The content team has been rewriting these for all languages - let me follow up why this one is not there

Update - JS will be up by the end of the week

Up on docs: https://docs.microsoft.com/en-us/azure/key-vault/quick-create-node


Introduction example in docs is broken

Problem
The example in the docs shows an error when clicking run.
Steps To Reproduce
Steps to reproduce the behavior:

Open docs (https://dioxuslabs.com/docs/0.3/guide/en/)
Click play button

Expected behavior
The example should work
Screenshots

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[x] I don't have time to fix this right now, but maybe later

Introduction examples on documentation are sometimes kept simple on purpose.
You just need to import dioxus like this to make it work:
use dioxus::prelude::*;

The problem isn't that the example fails. I can see why that happens. I just expect the example to work if I run play. This doesn't seem professional.

The problem isn't that the example fails. I can see why that happens. I just expect the example to work if I click play. This doesn't seem professional.

These examples are not interactive, I'll open a PR later so the play button doesnt show up.


touchParents and changedParents

@TrySound You know the interal Rollup source code better then I do, so can you look into this?
Look at this source code to get an idea:
https://github.com/webpack/karma-webpack/blob/master/index.js
This is interesting:
https://github.com/webpack/karma-webpack/blob/master/index.js#L106-L115

Seems like constructor and factory injects impicitly. And plugin have an access to emmiter. Maybe factory can inject it too. Let's try.

I did look at various preprocessor source codes now, and both Webpack and Browserify uses an emmiter. However Browserify also create a framework plugin.
https://github.com/nikku/karma-browserify/blob/master/lib/bro.js#L366-L367

Looks like an emitter /plugin would be a viable (and canonical) path.  The touch/denounce was just a hack to make it kinda work. 😀

Well. I try to think of a good solution, and - @TrySound - if rollup.watch() is stable enough. Could it be used to watch the source files, send a boolean flag back to a bundle function and do a re-trigger if any changes?  If that make sense...
Browserify uses watchify.

It can, but is there a way to prevent karma watching?

I'm not sure. Actually I doubt it. Webpack solution with emmiter, tried it?

Yep. But maybe without plugin class

It's a tricky one. I still looking at other preprocessors

@TrySound It didn't work? I may think we would need a framework plugin as well. As seen in browserify. And also here: https://github.com/Ferocia/karma-gzip/blob/master/lib/index.js#L9
and the plugin: https://github.com/Ferocia/karma-gzip/blob/master/lib/Plugin.js#L61-L71
Same thing actually as Browserify.

Yeah, but please don't split $inject and function itself. It's aweful.

ok. Anyway. I think we have a solution? Study this code
https://github.com/Chialab/karma-systemjs-preprocessor/blob/master/lib/systemjs.js#L55-L76

My time is up, but I also found that all files is hooked on the window. So you can grab the files like this:
window.karma.files
Better example here:  https://github.com/tamtakoe/karma-requirejs-preprocessor/blob/master/index.js#L46-L51

Incidentally, my SO question has a few comments I made on this, at http://stackoverflow.com/questions/37795680
Whatever mechanisms are available appear to be a poorly documented part of the Karma API.  It's a bit of a relief that it's such a pain ... it's not just me. :smile:

Agree this is a PITA. But hopefully it will be solved soon. My next step
will be to read the whole karma source code.
On Jul 11, 2016 10:50 PM, "Brian M Hunt"<EMAIL_ADDRESS>wrote:

Incidentally, my SO question has a few comments I made on this, at
http://stackoverflow.com/questions/37795680
Whatever mechanisms are available appear to be a poorly documented part of
the Karma API. It's a bit of a relief that it's such a pain ... it's not
just me. 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Kflash/karma-rollup-plugin/issues/14#issuecomment-231757656,
or mute the thread
https://github.com/notifications/unsubscribe/AEU1Aj2c8p-DRIElo3jD190NcaDqUWyOks5qUlgkgaJpZM4JJQOx
.

@TrySound  I looked at the karma source. A mess. But they are using event emmiters. Old code. Probably  promises can be used.
Just now I'm tempted to develop my own solution Ala karma. We will see what I do tomorrow if this can't be fixed.  So far I can do basic stuff from the client.  Yep. I started on it...

@TrySound Did you look into this? I will not be online the next days, working on analyzing Karma source code etc. As far as I see now, there is no easy solution.  But an emitter would probably solve this, and most of Karma code seems only to invoke code directly from plugin, frameworks etc.
I will come back to this soon as I know exactly whats going on here.

Not yet. Will look this night.

ok. I think it will be little hard to fix. Somehow you will need an
emitter, and check if files have changed, and restart Karma. And if you
look at this $inject, it's part of this NPM module ( 3 years ld).
https://www.npmjs.com/package/di
I'm in the middle of preprocessing now locale so I will know it soon.
Started to develop my own Karma look-a-like solution. CLI is fixed, and
config.
On Tue, Jul 12, 2016 at 3:02 PM, Bogdan Chadkin<EMAIL_ADDRESS>wrote:

Not yet. Will look this night.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Kflash/karma-rollup-plugin/issues/14#issuecomment-231954573,
or mute the thread
https://github.com/notifications/unsubscribe/AEU1AleB-QDvlJgH-MGkYJtpt3saPD8sks5qUzv4gaJpZM4JJQOx
.

@TrySound All I can say is this is tricky, and related to the HTTP server Karma are using, and Karma's own middleware. And for me now it seems like the preprocessor is more or less static. It takes the files and do some magic on them and send them back. However. The watch task uses a more complicated algorithm.
And everything is an module in Karma, and every module get injected when the server get invoked. So a preprocessor is outer layer on top of the internal code. So far I can't see how this can be done without fixing something in the Karma core to get it correct.
Dirty hacks I guess is possible... Karma's middleware inject variabels in the global scope - e.g. _KARMA_FILES to keep track on the files in an array.
And you can start and stop Karma if you invoke this callbacks too. So maybe just listen for file changes, and trigger an restart of Karma if any changes?
I'm still investigating...

But karma restart will also will restart server. It could be very expensive. Or it is happend every time?

I have no good answer except I know what's causing this. In karma you have
a watch task. This files is stored in a container on the window it seems.
__karma__files. Issue seem to occour with di and lodash dependency.
So if you somehow can get the files from there?
On Jul 13, 2016 12:55 PM, "Bogdan Chadkin"<EMAIL_ADDRESS>wrote:

But karma restart will also will restart server. It could be very
expensive. Or it is happend every time?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Kflash/karma-rollup-plugin/issues/14#issuecomment-232256356,
or mute the thread
https://github.com/notifications/unsubscribe/AEU1AnLBDex8mC3QIiI-zp6Q-TivQTbVks5qVG_ZgaJpZM4JJQOx
.

@TrySound  I will know more soon, but the files is first served by the server. Then they are hooked on the window object like this:  'window.__karma__.files = {\n' + mappings.join(',\n') + '\n};\n';
The watch task uses this this files.
Seems to be complicated, and bad documentation and API.

@Kflash Bad? It doesn't exist :))

I know. That's the reason why I'm developing my own task runner now where I actually solve this issues.

@TrySound I'm getting closer to an solution ....
13 07 2016 14:08:03.500:INFO [Jeibo]: |---- Launching the server with Jeibo at http://localhost:9876/---|
13 07 2016 14:08:03.503:INFO [launcher]: You are using Chrome browser.

@TrySound here is how it works.... in the configuration file you set the files to run test on. Webserver starts and save the files in an array on the window object. When you run tests the browser open on a specific port with unique Id. You see it in the browser url. This hamlet file is named static.html.
On a watch task the browser window stay open and the server listen on the port. If any changes with the files a karma.js file get invoked and trigger the Webster very to restart and updated files in the array.
I don't think this helped too much. .. and the files are sent to the preprocessor before mocha or jasmine get them

@TrySound Karma 1.x have a new options -  this.restartOnFileChange = false. Set to false by default.

Nice

@TrySound I'm done with Karma for now, and focusing on developing an Karma alternative.
Everything is here: https://github.com/jeibo/jeibo
Basic setup for now, but I'm pushing online as soon as I have done something. This is just a slooow project. I can send you a invite there later on.

@TrySound seems like the issue is related karma.

@TrySound I guess this isn't a case anymore. So closing. Re-open if you got a fix.


In editor: Some buttons in the toolbar are not selected when clicked in Markdown mode

Describe the bug
When I select the following buttons in Markdown mode, they are not highlighted or the wrong button is highlighted:

Bold
Italic
Strike
Line

But they work in WYSIWYG mode.
To Reproduce
Steps to reproduce the behavior:

Build the editor
Click on the 'Bold', 'Italic', 'Strike' or 'Line' button
These buttons are not selected when clicked as opposed to other buttons in the toolbar.

Expected behavior
The abovementioned buttons should be selected when clicked once and disabled when clicked again.
Screenshots
Buttons not working in Markdown:

Buttons working in WYSIWYG mode:

Desktop (please complete the following information):

OS: Mac
Browser: Chrome
Version: 81.0.4044.138 (64 bit)

@C-likethis123 First, I'll explain the toolbar activation in the Editor. The current toolbar activation state changes depending on which node the cursor is currently positioned on. So, the status of the toolbar can be different in Markdown and WYSIWYG.
In the case of the Markdown editor, a node is created according to the markdown syntax, and the toolbar is activated according to the returned node type according to the position of the cursor. In the situation you described, adding the bold adds **** syntax, and this syntax corresponds to thematic breaks, so thematic breaks's toolbar is active.

It's not a bug, but it looks like a bug. 🤔 The editor should discuss how to handle the specification for toolbar activation.


Simple mod for Windows 10?

I have an MSI GT62VR with a SteelSeries RGB keyboard. I use it with Windows 10 and Ubuntu 16. On Windows I have a problem when the laptop is running in Eco power-saving-mode on battery. Sometimes when the machine is under load it will not immediately register a key is released, so it writes things like "hellooooooooooooo" as if the o-key was stuck.
Neither MSI nor SteelSeries have provided any support on this problem. I have already tried updating all relevant drivers etc.
I think the problem might be the SteelSeries Engine that is trying to intercept macro keys and what-not, but has not been optimized properly. I've tried to increase the thread priority and also just killing the SteelSeries Engine thread. Although it'll take longer to determine if that is indeed the problem, because the problem only surfaces occasionally.
This problem only happens in Windows 10 and not in Ubuntu.
If the machine was first booted in Windows, then I can press the SteelSeries logo-key a few times and I get the backlit RGB keys in Linux. If the machine has not previously been booted in Windows, then the backlight is just white in Linux.
Two questions:

Do you think the SteelSeries Engine is a likely explanation for the problem I am observing with stuck keys, or do you have another suggestion for what I could try, given your knowledge of these matters?

Would it be possible to mod your code so it runs on Windows 10 and merely turns on the RGB backlight? I don't need any control or macros or anything, I just want the RGB light to turn on. Or is there another simple way of doing this?

Thanks!

The stuck keys is a problem with windows, and or other software, there are hundreds of stuck key reports online. I have never used the steelseries engine in windows beyond the first version of a few years ago.
If you can do this and post the output I'll know if it's possible:
$ npm i node-hid
var HID = require('node-hid');
var devices = HID.devices();
console.log(devices);

Thanks for the quick reply.
It has probably been 15 years since I've worked with java / javascript. But I managed to install npm and node and put the code in foo.js and ran that file with node on Ubuntu. This is the output I got.
[ { vendorId: 6000,
    productId: 65280,
    path: '0001:0004:00',
    release: 272,
    interface: 0 },
  { vendorId: 7805,
    productId: 11502,
    path: '0001:0003:00',
    release: 256,
    interface: 0 },
  { vendorId: 7805,
    productId: 11502,
    path: '0001:0003:01',
    release: 256,
    interface: 1 } ]

Thanks, Interesting:
{ vendorId: 6000,
    productId: 65280,
    path: '0001:0004:00',
    release: 272,
    interface: 0 }

That is the correct vendor object.
Can you try this?
$ git clone https://github.com/stevelacy/msi-keyboard
$ cd msi-keyboard
$ npm i
$ node ./examples/color.js

I tried running those commands in Ubuntu and got the following error message:
magnus@torpedo:~/msi-keyboard$ node ./examples/color.js
/home/magnus/msi-keyboard/node_modules/node-hid/nodehid.js:24
    this._raw = new (Function.prototype.bind.apply(binding.HID,
	        ^

Error: cannot open device with vendor id 0x1770 and product id 0xff00
    at Error (native)
    at new HID (/home/magnus/msi-keyboard/node_modules/node-hid/nodehid.js:24:17)
    at module.exports (/home/magnus/msi-keyboard/lib/findKeyboard.js:8:14)
    at Object.<anonymous> (/home/magnus/msi-keyboard/examples/color.js:1:92)
    at Module._compile (module.js:410:26)
    at Object.Module._extensions..js (module.js:417:10)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)
    at Function.Module.runMain (module.js:442:10)
    at startup (node.js:136:18)

Try to open your cmd or shell as admin, probably right click and "run as admin"

I'm running this on Linux so far because I don't have any dev-tools installed on Windows (git, java, etc.)
The following command worked and turned on the keyboard's RGB lights on Ubuntu:
$ sudo node ./examples/color.js

Questions:

How can I put this command in a script so every time Ubuntu wakes up from sleep this command is run?  How do you do it?

What is the minimal requirements for getting this working on Windows 10? Do I need to install git, java, npm, etc.? Or can I just copy a few of the .js files? I realize you're not a Windows user, but any idea how many dependencies etc. there are in your code and how much I would need to get this working on Windows?

startup scripts https://www.cyberciti.biz/tips/linux-how-to-run-a-command-when-boots-up.html
There is no telling what is needed on windows, if you can run that command on windows and get an output then it might work.

Thanks very much for your help I appreciate it!

Since I'm running a dual boot with Windows 10 x64, I thought I'd give this a shot as soon as I'd boot into Windows again. Even though the issue was closed before I could, I wanted to try and share my findings anyway, mainly since I'm not completely fond of the SteelSeries Engine either.
Your first code snippet with node-hid:
var HID = require('node-hid');
var devices = HID.devices();
console.log(devices);

printed a pretty large list, but I did find the device of interest:
{ vendorId: 6000,
    productId: 65280,
    path: '\\\\?\\hid#vid_1770&pid_ff00#7&2b03053&0&0000#{4d1e55b2-f16f-11cf-88cb-001111000030}',
    serialNumber: 'MSI EPF USB',
    manufacturer: 'MSI EPF USB',
    product: 'MSI EPF USB',
    release: 272,
    interface: -1,
    usagePage: 65440,
    usage: 1 },

Then cloning the msi-keyboard repository and running node ./examples/color.js worked as well, though instead of the three colours that it displays while I'm in Ubuntu, it displays one solid, though slightly green/blue-ish white colour. Why? I have no idea... The wave examples do work as they should though.
Finally, I also tried running msi-keyboard-gui on Windows. I removed the os tag from the package.json and was then able to npm install it. Then running npm start started the building process, which finished quickly enough, but it took quite some time for the application window to actually appear. Once it did though, the application launched correctly. I did a quick run-through of the colours and modes and they all seemed to work perfectly as well 😃 @stevelacy It might be easier to get this working properly on Windows than you previously thought 😋
So, as an answer to question nr. 1, @Hvass-Labs, in order to run from source like I just did, you'll need to have NodeJS and npm installed. Git is not strictly required since it is also possible to download the repository's contents as a .zip from GitHub itself, but it is useful to have anyways.

WAT WAT WAT OMG.
Ok amazing, did it only take npm start to build correctly? If so I should just be able to alter the build command and add a build:windows

@bvobart I'll do a windows dual boot and install the needed dev tools to try it there, thanks

Yeah, I was surprised that it worked that easily as well :P Luckily. this is NodeJS and ReactJS, which are mostly designed to be OS independent anyway. It was indeed only npm start (and thus build:app) that made the app work properly. The only problem I noticed was that it took quite some time (+- a minute at first launch or so) for the app to actually launch, although I have no idea why. Pre-built binaries would probably launch much quicker, though I'm not sure about that, as I have no experience building Electron apps and the like. Let me know once you've implemented a build:windows command, then I'll go and test it as well ;)

@bvobart Thanks very much!

check this out:

windows lol
Windows sucks lol...
https://github.com/stevelacy/msi-keyboard-gui/commit/fadafa2a568011dfac591899397e9458583adf32#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

Just released a build for windows: https://github.com/stevelacy/msi-keyboard-gui/releases/tag/0.2.1
@bvobart @Hvass-Labs @knuxyl

Thanks!
I actually prefer Windows and am not too happy with Linux nowadays. I used it 20 years ago and I think it has gotten worse since then. I'm now having massive problems with WiFi drivers, for example, and I can see that many others have the same problems, but it doesn't get fixed. It also took me a week to make a full install of Linux to do Deep Learning, because Ubuntu was so incredibly fragile if I installed something it didn't like, then I would have to reinstall everything. The problem I'm having with stuck keys in Windows, I don't think it's a Windows problem as much as a driver problem, probably with the SteelSeries Engine. So hopefully your tools may help with that. Thanks again!

Nice!! Just downloaded and launched the new release and it seems to work properly! I haven't launched the app from source as of yet, but it's great to see that this app now actually has a fully working release on Windows.
Personally, I prefer Windows for stability, everyday use and gaming, but Linux for development purposes. I don't have any problems with WiFi drivers and the like, although I do apparently have problems with graphics drivers (or Xorg), seeing as it seemingly switches over to software based rendering instead of hardware-accelerated rendering, which causes scrolling, moving / resizing windows, etc. to become incredibly slow. A reboot fixes it though.
Anyway, I hope this app (now with Windows support) will help you in your quest to fix those stuck keys! ;) As soon as I have some time for it again, I'll see if I can add some features here and there.


Unsupported field: steps

Integrations don't work when running "apply" on camel-karavan (serveless mode)
What config is missing for camel-k to use yaml?
(main) Failed to start application: java.lang.IllegalArgumentException: Unsupported field: steps
at org.apache.camel.dsl.yaml.common.YamlSupport.creteEndpointUri(YamlSupport.java:248)

Are you running this on Camel K, then Karavan requires Camel K 1.9.x release (not released yet).

See also: https://github.com/apache/camel-karavan/issues/198


Fix CI - Bump isort to 5.12.0

Fix pre-commit config
Link to issue: https://github.com/home-assistant/core/issues/86892

Codecov Report
Patch and project coverage have no change.

Comparison is base (9928241) 86.70% compared to head (e5eaa91) 86.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   86.70%   86.70%
=======================================
  Files          18       18
  Lines        2143     2143
=======================================
  Hits         1858     1858
  Misses        285      285

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


MacOS Changes

Couple changes for MacOS support.

modules/python/collection/osx/keychaindump_decrypt.py - Dumps cleartext credentials from the keychain.
stagers/osx/macro.py - Rewrote the macro to support newer versions of Office
modules/python/situational_awareness/host/osx/situational_awareness.py - Added another command to the end to output Wireless SSID info

I think I cleaned up some of the commits.  Also changed the verbiage.

Thanks @import-au !

hey gang, is it just me or are none of these multi and osx macros not working in office now?

Microsoft made changes in newer versions of Office to prevent loading of popen. There's still a few ways to get code execution on a mac via macro but most of the sandbox escapes that I know of have been patched up.


Mockserver NodeJS - no recorded requests

Hello,
Im using currently the newest version of mockserver & client.
I made some steps for recording requests feature and I can see in logs that it works.. I mean that, mock-server pass request to an external server. But I can't see logs when I tried to execute
retrieveRecordedRequests or retrieveRecordedExpectations.. Also I can't localize log file.

I have retested the mockserver nods js and have confirmed that requests are recorded.  Can you please provide me more details, including:

what version of you are using
example code you are executing

I am also not able to see anything recorded.
// Kotlin (using Java API)
val proxyHost = "localhost"
val proxyPort = 1234
val mockServer = startClientAndServer(proxyPort)
System.setProperty("http.proxyHost", proxyHost)
System.setProperty("http.proxyPort", proxyPort.toString())
try {
MockServerClient(proxyHost, proxyPort).use { mockServerClient ->
// Run my code that does some HTTP requests. This part is working.
val json = mockServerClient.retrieveRecordedExpectations(null, Format.JSON)
            Files.write(Paths.get("C:\\mockserver\\record.json"), json.toByteArray(), StandardOpenOption.CREATE_NEW) // Writes out "[]"

            mockServerClient.stop()
        }
    } finally {
        mockServer.stop()
    }

Have also tried using an external server by starting the mockserver-netty-5.6.0-jar-with-dependencies before running this code, and obviously in that case without the statements that init and stop the mockServer. I see in the console that it logs "retrieving recorded_exceptions in json that match: { }", 3 times, but there are no expectations returned, and mockserver.log is a 0-byte file.

@SamerAdra it sounds like no requests are being proxied via MockServer, can you please attach your entire MockServer log I can see what the issue is.
@masteruser20 do you have any update?  Can you please attach your entire log as well.

Closing due to inactivity, please open a new issue if this is still a problem


Update Travis caching

@cjh1 what's changed for wheel cache to work? It seems that you had cache setup earlier?

@aashish24 We were updating pip after install Girder, so the install of Girder requirements was not being done from the cache.

@aashish24 We were updating pip after install Girder, so the install of Girder requirements was not being done from the cache.

 Thanks.


Build sensu watchdog meta-check

This ticket is to build the code that will:

be deployed and run on all sensu servers
Actually do things only on the sensu master
Iterate over all watchdog/* stashes
If the watchdog stash timeout is expired (tbd how to do this. maybe a "watchdog_exipres" field
Re-send the alert details to sensu masqurading the originating host, rewriting some of the fields
status => 2 (crit)
output => "Watchdog expired! Last heard from this check $timestamp."
tip => "Remove this watchdog timer by removing this stash? (needs more detail)

cc @georgebashi @somic @trumpcard @keymone @lmovsesjan

bla
bla

This now can be done with server side checks. I think the requirement "actually do things only on the sensu master" can be dropped. I am going to experiment in a branch.

First cut:
https://github.com/somic/puppet-monitoring_check/blob/watchdog_meta_check/files/watchdog_meta_check.rb

@solarkennedy - is this issue still relevant now that we have ttl?

NOPE! :)


Installer needed

Every time download and unpack in the new folder - is bad, we need the installer which will check whether the previous version installed and install with save settings and plugins from previous version.

I agree that it's not needed, but I have to admit that having an installer really improves the experience. Even if it just downloads, unzips, and adds a start menu item.


skip application/octet-stream in gzip module

We want to skip application/octet-stream in the gzip module due to the
possiblity of having already compressed data in a repository or LFS
object store. This avoids problems with double compression and
decompression issues from tar.gz files stored in git-lfs.

Hmm you shouldn't need this. http.DetectContentType should detect if something is already gzip'd.
What is this apropos of?

http.DetectContentType will detect it, but the lfs server always sets the Content-Type to "application/octet-stream". The gzip module checks the Content-Type header to see if we want to "assume" it's compressed and not go through with the gzip compression. At this point, the gzip module blindly sets the gzip Encoding header in "startGzip" and encodes the header value.
https://github.com/go-gitea/gitea/blob/55a8e12d85bd59314416bb026e84d258004a5071/modules/gzip/gzip.go#L169-L194
https://github.com/go-gitea/gitea/blob/55a8e12d85bd59314416bb026e84d258004a5071/modules/gzip/gzip.go#L202-L229
LFS object serving code
https://github.com/go-gitea/gitea/blob/55a8e12d85bd59314416bb026e84d258004a5071/modules/lfs/server.go#L164-L184
From the specification, it looks like all content fetches are application/octet-stream and I'm not sure if this is a requirement by the git-lfs specification or not.
https://github.com/git-lfs/git-lfs/blob/master/docs/api/basic-transfers.md#downloads
I have a gitea server that's going to have large lfs objects and wanted this for performance and sensibility reasons. I haven't dug further and checked an actual request yet, but I can do that if you would like. I'm currently fixing up the tests now since the middleware tests used random bytes which triggered the Content-Type: application/octet-stream code path and disable gzip compression.

NVM I see my error now... Closing this PR.


scans_per_accumulation

TRAJECTORY_BUILDER_3D.scans_per_accumulation = 160
If I keep decreasing this value, the trajectory will become more and more dense， Will the amount of computation increase?

This purely depends on your setup, the answer is likely yes. But this is not really a tuning parameter, usually there is a single value or small range that is correct for your setup.
See this FAQ entry.

which incorporates motion estimation by combining constant velocity and IMU measurements, for matching.Since there are two VLP-16s, 160 UDP packets is enough for roughly 2 revolutions, one per VLP-16
Does it mean that lower or higher TRAJECTORY_BUILDER_3D.scans_per_accumulation affects trajectory accuracy?

Yes.


Setup Travis CI to use encrypted variables for unit tests

Closing this issue as we are moving towards Azure DevOps.


[terra-clinical-header] Add support for hyperlink header title

Summary

What was changed:

Add onTextClick prop to add callback function to the new hyperlink title
Added hyperlink button to clinical title
Updated existing jest tests to add test assertions

Why it was changed:

Fusion header component gap

Testing

This change was tested using:

[x] WDIO
[x] Jest
[x] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Hyperlink triggered:

Jaws:
https://github.com/cerner/terra-clinical/assets/37750902/a67a2eb4-4093-4425-9c08-4c7a877046eb
Reviews
In addition to engineering reviews, this PR needs:

[x] UX review
[x] Accessibility review
[x] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9683

Thank you for contributing to Terra.
@cerner/terra

Functionally reviewed, great job @trandrew1023!


Identity system

About the PR
Closes #5545
Basically, IdentitySystem is a proxy for getting an entity's name while taking their identity into account. The basic idea is like this:

If the entity has no inventory (no ID, mask, etc), just use their metadata name. This is most things. See below for whether it should be like this
If either the viewer (eg they are a monkey or drone and dont know jack shit) or the target (eg they are wearing a mask) block identity, then show the entity's 'presumed name' (generated from their ID card, defaulting to an unknown string if they have no ID or have no name on the ID)
If the viewer -can- see the target's identity (i.e. the events weren't cancelled) show the target's true name.
If the viewer should ALWAYS see identity (they are a ghost, or the target is yourself, or the caller said so) then show their presumed name with the true name in parentheses.

Unlike SS13 where the 'unknown name' string was just 'Unknown', here it is generated using a combination of the target's name, gender, and job. For example, old assistant woman, young captain person or middle-aged man. Changes were made to HumanoidAppearance since I needed to actually get their age properly. Inspired by how IS12 Reborn handles identity.
Caveats:

Anything that can change identity needs to be networked properly, since a lot of calls to IdentitySystem are purely clientside and changing this would be omega balls.
It's a little less convenient than just getting the name.

What still needs to be done (maybe, can be merged without these)

[ ] Localization in Robust needs to raise an event for getting an entity's "true name", since it directly uses MetaDataComponent.EntityName, revealing the true names of entities to everyone. This one is a little hard tbh and Idk if this is the correct answer. It also doesn't super need to be done yet since it's not a big deal, but it is annoying.
[ ] Maybe just make a CanChangeIdentity component, since the Inventory check is a little arbitrary and some stuff may want to change identity without having an inventory. Also just makes more sense, and means we can direct the aforementioned localization event to this comp.

Screenshots

https://user-images.githubusercontent.com/19853115/153672652-8e6a1a08-d005-4caa-a2f7-74016472e22c.mp4
Changelog

:cl:

add: Your identity is now not always guaranteed. Wearing masks or helmets conceals who you really are, and wearing a different ID while doing so may trick people. However, speaking will reveal your identity.

Fixed conflicts. Now to review.

finishing this up

DNM until i figure out fluent

see https://discord.com/channels/310555209753690112/770682801607278632/967607832658735245 and the messages below w/ flipp

Based on the discord comment, are you going to build off of this, or are you going to take a different approach in a different PR for your new ideas?


Display method signatures for match candidates

Enhancement, related to #22 - The new code completion support is awesome. What do you think about displaying method matches with signatures?
For instance:
java> public void someStringMethod() { }
Created method void someStringMethod()

java> someString   // <-- tab
someString          someStringTwo       someStringMethod(
java> public void someStringMethod(int x) { }
Created method void someStringMethod(int)

java> someString // <-- tab
someString          someStringTwo       someStringMethod(

Would instead display (something like):
java> public void someStringMethod() { }
Created method void someStringMethod()

java> someString  // <-- tab
someString          someStringTwo       someStringMethod()
java> public void someStringMethod(int x) { }
Created method void someStringMethod(int)

java> someString  // <-- tab
someString          someStringTwo       someStringMethod()     someStringMethod(int)

Again, this is an enhancement request only :-)

Albert! You've given up on this issue after 3 years? :-P


Do Not Merge!!!

Create a meaningful title

Description
Does your commit message include the wording below to reference a specific issue in this repo?

Related Pull Requests

Does your pull request have unit tests?

test CLI_smoke

test CLI_smoke

test CLI_smoke#master

test CLI_smoke#master

test CLI_smoke#master

test CLI_smoke#master

test CLI_smoke#master

test CLI_smoke#master

test CLI_smoke#master

test cli_smoke#master

test cli_smoke#master

test cli_smoke#master

est cli_smoke#master

test cli_smoke#master

test cli_smoke#master

test cli_smoke#master


Node.js server initialised and file structure modified

PR Description 📜
This PR just initialises the Express backend server and refactors the file structure for easier navigation.
This PR is not the final PR which will close #187 . This was just necessary to avoid future merge conflicts.
kindly add the labels. The #187 issue is still in progress

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE

Thank you soo much for contributing to our repository 💗

@Durgesh4993 Please see to it

@sambitsingha Add a proper demo i will review it

@Durgesh4993 See the changes I have done. This PR is just to avoid future conflicts.
https://github.com/GameSphere-MultiPlayer/Community-Page/assets/110420002/b1be1d3c-9583-4fc1-bb44-8da93301bffc

Show the output ( runing website )

and raise new issue, proper documentation how other contributors will able setup the project

Alright

@sambitsingha Demo video

@Durgesh4993 Server up and running well.
Demo -
https://github.com/GameSphere-MultiPlayer/Community-Page/assets/110420002/5c7b20e8-a695-46c9-838c-e497dcf24b0e

I am doing the changes in the README.md now. This PR can be merged. Closes Issue #187

Show me whole project output

@Durgesh4993 The recorder couldn't recorded the previous clip properly.
Here is the frontend -
https://github.com/GameSphere-MultiPlayer/Community-Page/assets/110420002/2a1494b3-fcfe-441b-ad54-62e47823967b


Missing docs for ProjectRef & RootProject

I don't see ProjectRef or RootProject mentioned anywhere in the documentation. A good place to include these docs might be in the section for multi-project builds.
I have a lot of questions about how to setup multi-project builds as our codebase grows larger. Should we put our entire codebase in a single SBT build split amongst standard SBT sub-projects? Or should we make each library it's own SBT project and wire them all together with ProjectRef external references?

Generally documentation related issues should be tracked in sbt/website, but in this case a better forum might be sbt-dev list to discuss what to document and how to set up multi-project builds.

Thanks. I've created an issue on sbt/website to track this. I'll email sbt-dev for more info and then potentially with some pointers I'll be able to create a PR


'bash' is not recognized while running any program via script. I have bash installed into my system, but still I'm getting this error.

Prerequisites

[ ] Can you reproduce the problem in safe mode?
[ ] Are you running the latest version of Atom?
[ ] Did you check the debugging guide?
[ ] Did you check the FAQs on Discuss?
[ ] Are you reporting to the correct repository?
[ ] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
[Description of the bug or feature]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Versions
You can get this information from executing atom --version and apm --version at the command line. Also, please include the OS and what version of the OS you're running.

Please open a new issue and fill out the issue template completely so we can help you debug. Thanks!


Allow DSPO test suite be running with RHOAI

The issue resolved by this Pull Request:
Break down the solution for #RHOAIENG-10212 into smaller PRs to facilitate review.
Description of your changes:
The goal of test.sh --rhoai is to be to run the DSPO test suite with a previous RHOAI installed.
Testing instructions

Have an OpenShift cluster with RHOAI installed and in the terminal do the following
oc login ...
export GIT_WORKSPACE=.....
test.sh --rhoai

The output must be
--- PASS: TestIntegrationTestSuite (350.21s)
    --- PASS: TestIntegrationTestSuite/TestAPIServerDeployment (1.89s)
        --- PASS: TestIntegrationTestSuite/TestAPIServerDeployment/Should_successfully_fetch_pipelines (0.47s)
        --- PASS: TestIntegrationTestSuite/TestAPIServerDeployment/Should_successfully_upload_a_pipeline (0.91s)
        --- PASS: TestIntegrationTestSuite/TestAPIServerDeployment/Should_successfully_upload_a_pipeline_with_custom_pip_server (0.50s)
    --- PASS: TestIntegrationTestSuite/TestDSPADeployment (1.05s)
        --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio (1.05s)
            --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio/should_have_6_pods (0.45s)
            --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio/should_have_a_ready_ds-pipeline-dspa-ext_deployment (0.30s)
            --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio/should_have_a_ready_ds-pipeline-persistenceagent-dspa-ext_deployment (0.15s)
            --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio/should_have_a_ready_ds-pipeline-scheduledworkflow-dspa-ext_deployment (0.15s)
    --- PASS: TestIntegrationTestSuite/TestFetchExperiments (0.15s)
        --- PASS: TestIntegrationTestSuite/TestFetchExperiments/Should_successfully_fetch_experiments (0.15s)
    --- PASS: TestIntegrationTestSuite/TestPipelineSuccessfulRun (327.14s)
        --- PASS: TestIntegrationTestSuite/TestPipelineSuccessfulRun/Should_create_a_Pipeline_Run (248.24s)
        --- PASS: TestIntegrationTestSuite/TestPipelineSuccessfulRun/Should_create_a_Pipeline_Run_using_custom_pip_server (78.90s)
PASS
ok  	github.com/opendatahub-io/data-science-pipelines-operator/tests	350.219s

Checklist

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

/lgtm
/approve


E0002 during E3028: 'dict' object has no attribute 'get_safe'

cfn-lint version: (0.28.1)
> cfn-lint cloudformation_templates/lint_fail.yaml
E0002 Unknown exception while processing rule E3028: 'dict' object has no attribute 'get_safe'
cloudformation_templates/lint_fail.yaml:1:1

This did not occur on 0.27.4, which is what I was running before.
Here's the template:
---
AWSTemplateFormatVersion: '2010-09-09'

Parameters:
  Serverless:
    Description: Whether to use Aurora Serverless
    Type: String
    AllowedValues: ["false", "true"]

Conditions:
  UseServerless: !Equals [!Ref Serverless, "true"]

Resources:
  AuroraCluster:
    Type: AWS::RDS::DBCluster
    Properties:
      Engine: aurora-postgresql
      EngineMode: !If [UseServerless, "serverless", "provisioned"]
      EngineVersion: "10.7"
      ScalingConfiguration: !If
        - UseServerless
        - AutoPause: true
          MaxCapacity: 192
          MinCapacity: 384
          SecondsUntilAutoPause: 1800
        - !Ref AWS::NoValue

@iamed2 fix coming shortly

Thanks!


Detect package.json changes without full cache reload

Hello,
I use new webpack.DefinePlugin to share variables between webpack.config.js and my TypeScript files. I shared also the version from package.json with the DefinePlugin.
If I change now the version in package.json it will not be changed in the TypeScript files, because it is cached. If I use the environmentHash to detect changes in the package.json the full cache will be deleted and new initialized, what  needs a lot of time.
Is it possible to detect changes in package.json and reset the cache only for this file, and not for the whole project?

To get this kind of thing working you want to load the version without changing the configHash or environmentHash. The easiest option is to use yarn.lock or package-lock.json for the environment hash (hard-source defaults to those first before package.json), and to require('package.json') in your build instead of using DefinePlugin. You could use loaders to get the smaller part of package.json you want, like version.
Using DefinePlugin for stuff like this with the Defines changing because the version changes normally changes the configHash leading hard-source to use a new separate cache. You could manage configHash to exclude DefinePlugin. If you don't want to require('./package.json') directly in your source, you could use DefinePlugin for that.
new DefinePlugin({
  VERSION: `require('${__dirname}/package.json').version`,
})

Since DefinePlugin replaces defines with code you can use it this way so the config doesn't change.


Comments and reference rules in adaptivity elements

Implements #332
Implements #333

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

234 of 255 (91.76%)  changed or added relevant lines in 14 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 87.84%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

BusinessLogic/Commands/Adaptivity/Action/Comment/EditCommentAction.cs
24
25
96.0%

BusinessLogic/Commands/Adaptivity/Action/ContentReference/EditContentReferenceAction.cs
24
25
96.0%

BusinessLogic/Commands/Adaptivity/Action/ElementReference/EditElementReferenceAction.cs
27
28
96.43%

BusinessLogic/Commands/Adaptivity/Rule/DeleteAdaptivityRule.cs
27
28
96.43%

BusinessLogic/Entities/LearningContent/Adaptivity/Action/ContentReferenceAction.cs
11
12
91.67%

BusinessLogic/Entities/LearningContent/Adaptivity/Action/ElementReferenceAction.cs
11
12
91.67%

BusinessLogic/Entities/LearningContent/Adaptivity/Action/CommentAction.cs
11
13
84.62%

BusinessLogic/Commands/Adaptivity/Rule/CreateAdaptivityRule.cs
28
31
90.32%

Presentation/Components/Adaptivity/AdaptivityContentDialogRuleControl.razor
0
10
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.6%

Covered Lines:
11059

Relevant Lines:
12590

💛  - Coveralls


Engine adds and remove entities and systems with Varargs

just addition of add and remove components/systems
often we needs to add multiple components/system, specially at
initialisation, this can reduce our code size in our gdx programms
thx for reading.

it makes classes grows without adding so much value. Also var args is prone of GC pollution.
I prefer not merging this, hope you understand.


switched back to openwrt

I did some minor modification to build openwrt
the name of imagebuilder at the openwrt download site is still named lede
tested it with my tl-wr1043nd-v2 that was running lede 17.01.4 before
i will implement automated builds with docker & gitlab-ci soon

merged (without locally testing for now). thanks!

also renamed the project back to openwrt-auto-extroot


Input box has outline

Describe the bug
When selected, the input has an outline. This is ugly, and could be replaced with a border.
To Reproduce
Steps to reproduce the behavior:

Go to matrix.to
Click on the input box
Explosion

Expected behavior
No outline. It doesn't have a border-radius, so it's always going to look ugly. We could remove it, but replace it with a border for accessibility.
Screenshots

Smartphone (please complete the following information):

Device: Pixel 2 XL
OS: Android 11
Browser: Bromite / Vanadium (Chromium)
Version: N/A

Additional context
N / A

Duplicate of https://github.com/matrix-org/matrix.to/issues/120

Thankie


rustup: unrecognized OS type: OpenBSD

Is it possible to add OpenBSD support?
Thanks

Hello,
I don't think I will maintain a build for openbsd, as it is a tier 3 arch, meaning best effort, architecture for Rust.
But if you install rustc & cargo directly from your package manager (without using rustup) on openbsd, and do a cargo build --release it should work.
Let me know if you have build issue


First version of mutiple mode of perspactive

Close the PR, i will raise a new PR for this feature.


Add validation to package names when creating image.

related to issue THEEDGE-1813
Signed-off-by: mgold1234<EMAIL_ADDRESS>Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
What is it?

[V] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[V] I have added tests that prove my fix is effective or that my feature works
[V] New and existing unit tests pass locally with my changes
[V] I run go fmt ./... to check that my code is properly formatted
[V] I run go vet ./... to check that my code is free of common Go style mistakes

Test results are available in Ibutsu. The test run IDs are:
72efb296-ffcb-401c-bebc-8a931d726d8b
c2c177b4-fb0f-41af-afc8-1af0f6833fc0

@mgold1234 I'd like to suggest to validate the packages with the image-builder list before send to creation as we are doing on UI.
{imagebuilder_url}/v1/packages?distribution=rhel-85&architecture=x86_64&search=badrpm will return 0, this mean the package not exists and you should not continue with the process.
you can:
loop on packages list
call imagebuilder Packages validator
if return from imagebuilder >0
continue
else
return invalid package selected
you can add it on validate request, given we should not proceed the process with a invalid package in a list.
for more context:
https://console.stage.redhat.com/#/default/GetPackages

@acosferreira originally this issue was raised as understood because custom packages are not validated at all , and we cannot make search for them for the moment. rhel packages are searched in the UI, but the custom packages are not.
@tpapaioa please explain what we are expecting when resolving bug THEEDGE-1813.
as "badrpm" package name maybe a valid custom package name.

/retest

closing this PR as one of the CI processes is hanging, a new PR has been created https://github.com/RedHatInsights/edge-api/pull/1138


Please consider adding $.ajax

Cool library. It will be nice to have a jquery like Ajax method with compatible Syntax. Response type json text, XML etc. Please can we have that functionality included?

This has been discussed several other times, see #103

Closing as duplicate of https://github.com/kenwheeler/cash/issues/103.


service version

Issue Type
[ ] bug report
[ x] feature request

Current Behavior
manual git SHA
Expected Behavior
a deployment would contain it's own release name
Suggested Fix
The service design we have should allows us to independently release any of our dependency services, as long as they pass the required testing. For the sake of introspection and traceability, a particular service should propagate it's current deployed version.
I understand that at the time of deployment, we can read the git SHA and release tag from the repository and bake it into the deploy... does ALD follow a truffle migration approach and would that allow us to update a particular public variable that dependency services can read?
Could you @kevsul and @boolafish give me some hints how to implement this ... if you find it valuable.
The requirement comes from: https://github.com/omisego/elixir-omg/issues/937#issuecomment-577663312
https://github.com/omisego/devops/issues/312#issuecomment-576198237
(tldr dropping SHA from domain name of an environment would simplify infrastructure and datadog metrics, but the information is needed anyway! services that interact with contracts would be able to expose this information by reading it contracts)

Is this issue done as your PR getting merged? @InoMurko
And also, is the version schema debate....finalized?XD

Is this issue done as your PR getting merged? @InoMurko
And also, is the version schema debate....finalized?XD @jbunce

I think that's a 'yes' @boolafish 😄


Opt out of Sentry logging

Would it be possible to add an option for users to opt out of the logging/tracking that was added in the latest release?

Hi @thornbill!
This is a reasonable request. In fact, I would like to make logging opt-in, but this requires some UI work, as well as some refactoring on the booting process. That will take some time. In the meantime, Build 7 remains available in Testflight, which does not include the Sentry SDK whatsoever.
For some background context:
Why the tracking?
Primarily to investigate issue #33 , but beyond this it is incredibly helpful in weeding out weird states and instances where data being passed around is not properly checked. In fact, two reports that have come in since enabling the logging have helped me quash two bugs involving rare states that could crash the application.
Why is it not optional now?
Primarily because I was investigating a boot crash that the Testflight crash logs were not providing enough information for. Since in this instance the app was crashing on launch, making the logging opt-out would have made it impossible to debug the issue.
What data is gathered?
Where is the data stored?
The Sentry backend is self-hosted on my own infrastructure. No-one but me has access to the servers, databases, application and data logs, least of all any Sentry staff. The infrastructure is hosted in the European Union.
For convenience's sake, I will add this information to the README and hopefully the app at some point in the future. I hope this is all clear for now, and I will close this issue once all the above points are implemented.

Opt-in Sentry logging has just been release as build 10 on Testflight.


[terra-core] clinical-lowlight-theme port

Summary
Ported Clinical Low Light Theme to "Terra-Core".
Travis Format
A. Pack default theme assets
B. Run wdio in parallel. Split by form factor.

tiny
small
medium
large
huge
enormous

C. Pack lowlight theme assets
D. Run wdio in parallel. Split by form factor.

tiny
small
medium
large
huge
enormous

WDIO Format
The below mentioned commands are applicable at the root level as well as the package level

"wdio-default" - Runs the wdio tests only for Default Theme.
"wdio-lowlight" - Runs the wdio tests only for Clinical Low Light Theme.
"wdio" - Runs the wdio tests for both Default Theme and Clinical Low Light Theme

Additional/New Files

config/wdio/clinical-lowlight-theme/wdio.conf.js - Custom wdio config for clinical-lowlight-theme which disables the color-contrast axe rules.
packages/{package-name}/clinical-lowlight-wdio.conf.js - Custom wdio config for clinical-lowlight-theme at the package level to disable color contrast axe rules.

Additional Details
Color Contrast Accessibility test are disabled for clinical-lowlight-theme

This PR is up to date with the latest changes/releases and is ready for review.

This PR is up to date with the latest changes/releases and is ready for review.

Let's go ahead and remove the old obsolete variables.  If teams still need them, they could (and should) use the old low light theme package (since there's no guarantee the latest version of a component will be pulled in anyway).

Removing label for UX-Review as tech-only PR.
Will continue to monitor as teams start to use and validate for missing theme items or mistakes.


WIP sd-image: Slims the ext4 filesystem even more.

This is to try and squeeze more lost space from the image, so that hydra
starts building it again.
The fsck previous to the resize2fs is required so resize2fs works.
The one afterwards is a sanity check.
Using -M from resize2fs will not give much saved space due to a known
(in the manual) issue.
[samueldr@aarch64:~/nixpkgs]$ ls -lh result-*/*/*.img
-r--r--r-- 1 root root 2.2G Jan  1  1970 result-original/sd-image/nixos-sd-image-18.09.git.a7fd431-aarch64-linux.img
-r--r--r-- 1 root root 2.1G Jan  1  1970 result-M/sd-image/nixos-sd-image-18.09.git.a7fd431-aarch64-linux.img
-r--r--r-- 1 root root 1.9G Jan  1  1970 result-slimmed/sd-image/nixos-sd-image-18.09.git.a7fd431-aarch64-linux.img

[samueldr@aarch64:~/nixpkgs]$ nix path-info -S ./result-original
/nix/store/c8k9n78gylx293rjh762fr05a069kxp2-nixos-sd-image-18.09.git.a7fd431-aarch64-linux.img<PHONE_NUMBER>

[samueldr@aarch64:~/nixpkgs]$ nix path-info -S ./result-slimmed
/nix/store/962238skj5mnzhrsmjy23dyzmxk77sp4-nixos-sd-image-18.09.git.a7fd431-aarch64-linux.img<PHONE_NUMBER>

Motivation for this change
Once backported to stable (or the proper jobs added to hydra for unstable), the sd-image will be built again (until its closure size gets too big [again]).
This is a small economy; it might be possible to squeeze more, but for now let's use those stable and known safe numbers. This is not a lost effort, even if the closure was slimmed down more.
Things done

✔ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

✔ NixOS
⬜ macOS
⬜ other Linux distributions

⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
✔ Tested execution of all binary files (usually in ./result/bin/)
✔ Determined the impact on package closure size (by running nix path-info -S before and after)
✔ Assured whether relevant documentation is up to date
✔ Fits CONTRIBUTING.md.

cc @dezgeg @cleverca22

Force push was to add 16MB free to the image; zero blocks caused init in stage-2 to fail; and many many services to fail starting.


The Quantum Break Mod Wont Work And I dont Know Why everyone else can use it

[19:43:55] [ERROR] Script 'QuantumBreak' is not responding! Aborting ...
[19:43:55] [DEBUG] Aborted script 'QuantumBreak'. Why Is This Happening?

The error explains it. The script is stalling and ScriptHookVDotNet therefore kills it so the game can continue to run. This can happen if Thread.Sleep is called or some heavy work which takes longer than a few seconds is going on.

i dont know why its doing this is there anyway i can fix it? @crosire

Report to the script author. This is not a problem with ScriptHookVDotNet, but the script.


Adding the new services in FAQ section

i can add the new section in the faq if u provide me the data