Dark mode for Contributing to Open Source Page

Description

Category

[ ] Resource Addition
[ ] Documentation
[ ] Codebase
[x] User Interface
[ ] Feature Addition

Related Issue

Fixes #474
Checklist

[x] I have followed the CONTRIBUTING guide
[ ] The name of the resource is spelled correctly (if applicable)
[ ] The link to the resource is working (if applicable)
[ ] The resource is added in the correct format (if applicable)
[ ] I have tested changes on my local computer (if applicable)

@Sriparno08 Can you check this MR and merge it


add v-attrs

What problem does this feature solve?
<input type="props.type" placeholder="props.placeholder" max-length="props.maxLength" />

It's not cool
What does the proposed API look like?
<input :attrs="props">

Use v-bind without an argument as shown in docs


refactor: cmd dir layout

ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
when exec go run cmd/cmd.go the compiler only load cmd.go file, so it will report registerRoutes is undefined.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #99 (8a902bb) into dev (7d4d5d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #99   +/-   ##
=======================================
  Coverage   41.78%   41.78%
=======================================
  Files          48       48
  Lines        5782     5782
=======================================
  Hits         2416     2416
  Misses       3143     3143
  Partials      223      223

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4d5d6...8a902bb. Read the comment docs.


C#

I might be missing something, so hopefully this isn't a really dumb question....
C# is not one of the runtime stack options for a new functionapp. I am referring to Step 1 under "Create function to clean HTML." So you choose .net runtime. With that setting chosen in the app, I can't see how to create the C# function in the app as mentioned in Step 3: "open the Scenario list, and select Core. In the HTTP Trigger template, select C#"
Please let me know if I missed something or if there's another way to make a C++ functionapp.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 771c44cc-a284-0c97-dae3-218e7319018f
Version Independent ID: e4b73a57-0c44-2453-2baa-7652bbbafc51
Content: Build workflows that process emails and attachments - Azure Logic Apps
Content Source: articles/logic-apps/tutorial-process-email-attachments-workflow.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

Never mind, I'm a moron and I was clicking on the wrong option in the new function process.

@mike-urnun-msft it appears I'm still having one problem (and it's more likely ID10T than anything):

I don't see the C# option when setting up the HTTP trigger. If I create the trigger and paste the code from the guide, tests don't pass (500 error)

@siobhter Even though the visuals aren't as accurate yet, were you able to create the HTTP trigger function, which should be in c# language by default now, and still get going with the rest of the steps? If you have any further questions and need assistance, please open an MSDN thread and we'd be happy to weigh in.
There were some changes in recent times for Azure Functions and some details on this documentation need to be updated to reflect those changes for sample code as well as the visuals (screenshots). @ecfan can we create an internal work item for this one?

@mike-urnun-msft Ah, I see. I can try to play with it and see where my error comes from. I'm not much of a coder so the C# stuff is a little hard for me. I'll post in the MSDN forum and see what happens.

I get the same Status: 500 Internal Server Error
2018-10-24T11:19:07.510 [Error] run.csx(17,15): error CS1501: No overload for method 'CreateResponse' takes 2 arguments

@siobhter and @mike-urnun-msft Thanks for reporting! I've created a work item for updating the content.
#please-close

Thanks for the tutorial and the updated code supplied in the forum. Just wondered if there is a way to get the actual URL of the attachment in the email sent back? I can see there is a URL in my storage account when I select the attachment.

i am also getting below error
[Error] run.csx(17,15): error CS1501: No overload for method 'CreateResponse' takes 2 arguments
please help me how to fix this issue....

See here https://social.msdn.microsoft.com/Forums/en-US/491ddd45-71c6-4472-a272-2a46c20755e5/logic-app-500-error-error-runcsx1715-error-cs1501-no-overload-for-method-createresponse?forum=azurelogicapps#491ddd45-71c6-4472-a272-2a46c20755e5

Thanks alot @paulowendevelopment
now it's working for me


Batch upload does not seem to work

I tried uploading a single 5 page pdf document via "Add documents in Batch". I get the prompt that 1 document is being upload and that this will happen asynchronously and will take time. However even after waiting for more than an hour I cannot see the converted file in Index Management. What am I doing wrong? All necessary components have been provisioned in Azure.

Have a look at your Azure Function logs.


Document how to add words to dictionaries

Contributors should be able to find in CONTRIBUTING.md how common words per language can be added. If that's not easy, people will keep having to add lots of words to their local dictionary which does not help other users. I looked around for a few minutes but could not easily find this information.

@AndiDog,
You make a good point. Would you be open to making a PR that points would be contributors to streetsidesoftware/cspell-dicts: Various cspell dictionaries? All the extensions in this repo are based upon the dictionaries found in cspell-dicts.
I must admit, the instructions on how to add words is not ideal. Most dictionaries have a src/additional_words.txt file.


Document new EF Core 5.0 query translations

[ ] DateTime

[x] https://github.com/dotnet/efcore/issues/15283
[x] https://github.com/dotnet/efcore/issues/17170
[ ] https://github.com/dotnet/efcore/issues/19273

[x] Byte arrays

[x]  dotnet/efcore#13487
[x]  dotnet/efcore#4601

[ ] Reverse

[ ] https://github.com/dotnet/efcore/issues/17388

[ ] Bitwise operators

[ ] https://github.com/dotnet/efcore/issues/18788

[x] Cosmos

[x] https://github.com/dotnet/efcore/issues/19800

Related to #900, but leaving this issue open to collect 5.0 changes.

I don't think dotnet/efcore#19273 is done or has anything to do with DateTime?

Did some of this in PRs #2744, #2746 & #2733

19273 seems wrong reference. (closed as a dupe of open issue)
For Queryable.Reverse - We don't explicitly document queryable methods unless complex ones. (We could call it out in what's new but there is nothing specific in query since support varies widely across providers).
For Bitwise operators - Same as above. We mention function mappings we have added for each providers. Operators mapping is kind of implicity.
I propose close this as fixed.


NIO: use Posix "namespace" more aggressively

Convert many more cases of the raw address family constant to the
definition in the System version.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]

Im very confused why I didn't need the conversion :/

@swift-nio-bot test this please

I think they're only necessary on Linux due to a mismatch in the way the constants are declared and the way they're used.


TF2.0 Tutorial Error

Here is the colab raised the error.
https://colab.research.google.com/gist/MokkeMeguru/788255c93d4a4d8d4485098a7ba5e9f5/hub_with_keras.ipynb
Problem
I had tried tf2.0 tutorial (https://www.tensorflow.org/beta/tutorials/images/hub_with_keras).
I found this issue (https://github.com/tensorflow/hub/issues/356), so I change tf_hub version 0.5.0 -> 0.6.0.
But I get this error.
InvalidArgumentError: ValueError: `generator` yielded an element of shape (22, 224, 224, 3) where an element of shape (32, 224, 224, 3) was expected.
Traceback (most recent call last):

  File "/home/meguru/Github/tensorflow-2.0tutorial-with-emacs/venv/lib/python3.7/site-packages/tensorflow_core/python/ops/script_ops.py", line 221, in __call__
    ret = func(*args)

  File "/home/meguru/Github/tensorflow-2.0tutorial-with-emacs/venv/lib/python3.7/site-packages/tensorflow_core/python/data/ops/dataset_ops.py", line 621, in generator_py_func
    "of shape %s was expected." % (ret_array.shape, expected_shape))

ValueError: `generator` yielded an element of shape (22, 224, 224, 3) where an element of shape (32, 224, 224, 3) was expected.

	 [[{{node PyFunc}}]] [Op:IteratorGetNextSync]

I think this is whether because of tf 2.0 or tf hub 0.6.0...
Thanks!

Thanks for reporting the bug. The issue with the hub version is due to a not updated colab. We will update it soon.
The second issue is not related to hub, and I was able to reproduce it using tf.keras alone. Will file a bug with tf.

FYI, the second issue was due to ".fit()" needed to be replaced with ".fit_generator()".
The colab will be updated soon.

Thanks!
I experimented with the code. Everything looks fine!
Here is the my updated Colab. https://colab.research.google.com/gist/MokkeMeguru/983ddb62a06c83d7ce1191586014988f/hub_with_keras.ipynb
And It's my hope, Can you print tensorflow and tensorflow_hub's version in your tutorials?
Anyway, if you want to close this issue, you can do it.
Thanks help!

Thanks, and good point about having the module versions printed out.


Switch tdp svg marker to data: uri

Currently, this svg is the only one in our codebase directly referenced in a less file. This presents some complications for ongoing frontend build upgrades. Switching this marker to use a data uri obviates those complications with no effect on TDP.
Testing:

Pull and build
Complete a survey at http://localhost:8000/consumer-tools/educator-tools/youth-financial-education/survey/3-5/
The svg marker should be visible:

We have a less plugin for including SVGs inline in the design system (here and used here). You could consider whether it'd make any sense to use that from the imported cfpb-icons in cfgov to keep the icon available as a stand-alone SVG in the source.


Warning in log about some Config default gases are not spawnable

Version of Advanced Rocketry
1.7.0-240
Have you verified this is an issue in the latest unstable build

[x] Y

Version of LibVulpes
0.4.2-75
Version of Minecraft
1.12.2
Does this occur without other mods installed

[x] N

Crash report and log, or VisualVM snapshot (if applicable)
Log: Snippet
Log: Full
Description of the problem
The log states that gases registered in the config by default do not work as spawnable Fluids. The declarations in the config should be fixed so that they are workable, or they should be removed from the defaults.

Hello! I know about this, I wrote that system. Yes, it will throw a few errors on load, but without it we cannot provide default compat to some mods gasses for spawning. That is why they are there regardless of whether they give errors or not, as they are default compat There is no bug, and no reason to fix it - after all, the way for the user (who actually notices the output, which is very few) to fix it is to simply remove them - which is both easy and not required for the game to start. Those few who notice it can simply fix it themselves.

Removed actually pertinent log errors in 2.0.0. These stay because they are not a bug


Link OpenSSL 3.0 error in libcurl on MacOS

I compiled OpenSSL 3.0.2 success on MacOS. However, when I build libcurl with compiled OpenSSL lib. It produce error.
Undefined symbols for architecture x86_64:
  "_EVP_PKEY_id", referenced from:
      _ossl_connect_common in libcurl.a(libcurl_la-openssl.o)
  "_SSL_get_peer_certificate", referenced from:
      _ossl_connect_common in libcurl.a(libcurl_la-openssl.o)
ld: symbol(s) not found for architecture x86_64

PS. When I use OpenSSL 1.1.1n, The libcurl can make successfully.

Yes, It use openssl-3.0.2 header and lib, You can see below configure, and I build from fully cleaned libcurl source.
   Host setup:       x86_64-apple-darwin20.6.0
  Install prefix:   /Users/test/Downloads/curl-7.82.0/curl
  Compiler:         gcc
   CFLAGS:          -Qunused-arguments -Wno-pointer-bool-conversion -Os -Werror=partial-availability -pthread
   CPPFLAGS:        -isystem /Users/test/Downloads/zlib-1.2.11/zlib/include -isystem /Users/test/Downloads/openssl-openssl-3.0.2/openssl/include -DOPENSSL_SUPPRESS_DEPRECATED
   LDFLAGS:         -framework CoreFoundation -framework SystemConfiguration -L/Users/test/Downloads/zlib-1.2.11/zlib/lib -L/Users/test/Downloads/openssl-openssl-3.0.2/openssl/lib
   LIBS:            -lssl -lcrypto -lssl -lcrypto -lz

  curl version:     7.82.0
  SSL:              enabled (OpenSSL v3+)

PS. I can see libcurl use many openssl function in code, but only these two  ("_EVP_PKEY_id" and "_SSL_get_peer_certificate") link error.

Are you sure the 1.1.1 headers are not in the system /usr/inculude path?

Thanks @t8m , It seems libcurl will use system /usr/local/include/openssl, However, I have set /Users/test/Downloads/openssl-openssl-3.0.2/openssl/include

-isystem dir
Search dir for header files, after all directories specified by -I but before the standard system directories. Mark it as a system directory, so that it gets the same special treatment as is applied to the standard system directories. If dir begins with =, then the = will be replaced by the sysroot prefix; see --sysroot and -isysroot.

https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html


flutter 3.13.3 - hash error

Prerequisites

[X] I have used the predefined issue title. (e.g. "xxx@xxx: hash check failed")
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name and Version
3.13.3

I am also getting this error. The actual hash is f55a027c1c73bc80104d0f390a3d569c9d5073fd918b5b07d0c84ab557cf8ce7 while the manifest expects 7dcb77a6688ef034ea3b1b482444e656c68013e22bc90ccc6f9de4dde67830af.


help needed generating image for the SnowFlake Extension

Hi
Just discovered your wonderful SnowFlake extension.
Assuming i understand correctly first i import t a picture into this utility , click the big green play button. Then i copy the list of hex numbers generated into the ITEM string in makecode?
However whatever picture i import & then copy my display bears no resemblance to the original file. However if use the demo.bmp file from your microbit-lib/neopixel/neo_16x16_img/ it works.
What am i doing wrong - my guess is that the original picture needs to be formatted in a specific way?
Any help & example code would be really gratefully received - i want to show how to do this to a friend in USA who runs coding club for children - i am sure they would love to be able to create & display their own pictures

Hi,
First, prepare a 16x16 pixel picture. The picture should be as simple as possible, with fewer colors and a black background (this is very important). Then use the software to convert the picture.
Here is an example image.

Hi
I really appreciate your help with this ..
Will try as you suggest & hopefully not have to bother you again
Regards


refactor(typedoc): resolve sonar code smells

What's changed?

File: export-typedocs.ts

removed redundant console statements
thrown errors where necessary

File: .czferc.js

added new commitzen scope called typedoc and mkdocs for related code changes in the repo

Fixes #1217

rebase the branch

@yeshamavani Done!


Consolidate logic for Pin image

Summary
Always show Pin image. That’s the reflection of DB status.

If there is golden - allow unpin (auto update) and pin
If there is no golden  - disabled pin image

if cluster is pinned, no problem
if cluster is unpinned, automatically pin image

Test plan
Test locally and dev1
No golden, disable Pin Image checkbox and auto checked.

There is a golden, reflect db status
Auto update

Pin Image

Save and it works.

I added the auto formating in the later commit so you can see the first commit for the change.

Updated the default for auto update and reverted the auto format commit for reviewing easier.


Creating a github action to automatically generate the contract's call graph + readme + fix makefile

This PR contains:

A new github action
Updating the readme with a small  decription

Please check the type of change your PR introduces:

[ ] Bugfix
[X] Feature
[X] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] Documentation content changes
[ ] Other (please describe):

Other information
Time spent on this PR:
0.5 - 1 day

What do you mean by ignored?
If you mean within the .gitignore, they are, otherwise I'm not sure to understand what you mean/ask ^^'

The thing is that if I push the action will be triggered and those files will be committed because in the action there is the flag to force push.
Also in the action takes care to delete the callgraphs folder to make sure it is always clean :)
Unless there is something I'm missing?

The thing is that if I push the action will be triggered and those files will be committed because in the action there is the flag to force push. Also in the action takes care to delete the callgraphs folder to make sure it is always clean :)
Unless there is something I'm missing?

it seems to me that the purpose of this PR @abdelhamidbakhta is to have these files automatically generated and committed.
To me it's somehow like the resources files, it's painful to have them committed because it's automatically generated files that are an eternal source of conflicts in PRs. I'd suggest @gaetbout not to commit them in the action but:

use the artifacts actions like for the resources
if you feel so, add a command in makefile to generate them locally

I understand the conflict issue it can create but as it is generic documentation I don't think "hiding" them in an artifact is a good idea. If you are not aware those are available I wouldn't go and look there.
Maybe making a "documentation" folder that has a callgraph folder is more relevant to regroup all documentation related stuff?
As for generating them locally it would push people to install thoth locally before being able to access them (unless the makefile takes care of doing it, but then it would require admin right (sudo)).
That's just my view on it, but if everyone agrees on doing it your way, I'll do it :)


Enable service worker by default as the latest CRA

Should I also apply this change to create-react-app-with-flow, create-react-app-with-typescript and create-react-app-with-jss for consistency?

I have removed it as I tried to keep the example as simple as possible. But I can get that following the default output of CRA is better.

@sharils It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot!


Add optional email field in the feedback tool

Add an optional email field to the feedback tool to easily re-contact the users sending feedback

Fixed in #368


Use the data-inspector to browse data frames?

For browsing Data Frames it could be interesting to use the data-inspector by default in Polymath. This issue would only modify the BaselineOf to include the data-inspector.

I think something that might be interesting to have.


Provide Offline Packages with Release

Environment data
any vs code
Steps to reproduce
obtain vsix and install on computer with no internet
Expected  behavior
Option to download precompiled vsix for your platform
Actual behavior
Manual compilation.
Would like to request that precompiled/packaged of the extensions be made for the different platforms and made part of the github release like the CPP extension does. Reason being that on closed/restricted network it is much easier and lest complicated if no compilation/ additional download are needed to build an offline package and the person that get tasked with the transfer may not be capable of the task either.

We are currently waiting on the VS Code to support platform-specific exceptions (see https://github.com/microsoft/vscode/issues/23251). When that feature is delivered, we should be able to redo how this extension is delivered so that no further downloads are needed.
In the mean time, in case you haven't seen them, here are the 'offline instructions': https://github.com/OmniSharp/omnisharp-vscode/wiki/Installing-the-C%23-extension-to-a-computer-without-internet-connectivity

I've created a repo, where I'll post offline versions of package installers. Hope this will help someone!


Optional size & checksum field in StageObject

These fields are required in the StageObject request. It's possible to make these required and Stat the object from the object store in the server side.

@N-o-Z this might be great for simplified uploaders I think.  For instance it could allow proper streaming?

@N-o-Z this might be great for simplified uploaders I think. For instance it could allow proper streaming?

The stage object API is being deprecated, instead we utilizing the get/link physical address API - nonetheless this might be relevant for these APIs as well


Fix Repository Archive API Format Bug.

If I try to visit
/api/v4/projects/*/repository/archive?sha=master&format=zip,
I will get "406 Not Acceptable" error.
Then I found this :
https://gitlab.com/gitlab-com/support-forum/issues/3067
https://gitlab.com/gitlab-org/gitlab-ce/issues/45992
This bug is caused by gitlab-ce itself, but there is a solution to request .../archive.:format instead of .../archive?format=:format. So I have changed the origin RepositoryApi.java a little to adjust to the "../archive.:format" way.

Thank you for your best suggestions.  I have revised the PR according to your suggestion. If there is anything wrong, I will fix it as soon as I can.

@zhengrenjie
Changes look good, thanks.

@zhengrenjie
This has been released in 4.8.46
BTW, I added methods where you can now also specify an enum (Constants.ArchiveFormat)  for the archive format. This enum is also used to validate the format when provided as a String.


FATAL ERROR in make install

Observed behavior
Installing ox-reveal
FATAL ERROR: (error) Need package ‘org-20150330’, but only 9.1.7 is available
Installing centered-window-mode
FATAL ERROR: (error) Package ‘centered-window-mode-’ is unavailable
Installing ob-redis
FATAL ERROR: (error) Package ‘ob-redis-’ is unavailable
Installing org-bullets
FATAL ERROR: (error) Invalid version syntax: ‘Command ’(env LC_ALL=C /usr/bin/timeout -k 60 600 git clone https://github.com/hlissner/org-bullets.git /home/fbob/.emacs.d/.local/packages/quelpa/build/org-bullets/)’ exited with non-zero status 128: Cloning into ’/home/fbob/.emacs.d/.local/packages/quelpa/build/org-bullets’...
fatal: could not read Username for ’https://github.com’: No such device or address
’ (must start with a number)
Installing auth-password-store
FATAL ERROR: (error) Package ‘auth-password-store-’ is unavailable
Installing help-fns+
FATAL ERROR: (error) Package ‘help-fns+-’ is unavailable
Expected behavior
A fresh install of doom-emacs :)
Steps to reproduce
git clone https://github.com/hlissner/doom-emacs ~/.emacs.d
cd ~/.emacs.d
cp init.example.el init.el  # maybe edit init.el
make install
System information
GNU Emacs <IP_ADDRESS> (x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
of 2017-09-15
Ubuntu 17.10
Replace this line with the output of *one* of these commands:

+ DOOM Doctor
Running Emacs v<IP_ADDRESS>, commit 5dacbb7cb1c6ac246a9ccd15e6c4290def67757c

shell: /usr/bin/zsh
Compiled with:
  XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
  NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
  TOOLKIT_SCROLL_BARS GTK3 X11 MODULES XWIDGETS
uname -a:
  Linux dylan 4.10.0-42-generic #46-Ubuntu SMP Mon Dec 4 14:38:01 UTC
  2017 x86_64 x86_64 x86_64 GNU/Linux

Attempt to load DOOM: success!

Please switch to the develop branch. These issues have been fixed and are due to be merged into master soon.

Great thanks.
Avewome work : doom-emacs rules :+1:

On develop branch, everything else installs except for auth-password-store. I'm getting this :
Looking for packages to install...
1 packages will be installed:

+ auth-password-store (ELPA)

Proceed? (y or n) y
Refreshing package archives
Importing package-keyring.gpg...
Importing package-keyring.gpg...done
Contacting host: elpa.gnu.org:443
Contacting host: elpa.gnu.org:443
Contacting host: melpa.org:443
Contacting host: orgmode.org:443
Package refresh done
Installing auth-password-store
  FATAL ERROR: (error Package ‘auth-password-store-’ is unavailable)
Finished!

Ack, looks like they changed the name of the package upstream. I'll fix this soon.

@a-y-u-s-h Just pushed the fix. This should be resolved in the latest develop.

Thanks!

auth-source-pass is a package in melpa now,
not available in elpa anymore. Could you help to update?
Melpa

@aladine It is already built into Emacs 26.1+, and is installed from MELPA if you are using Emacs 25.x.


Error with django-simple-captcha version when installing with pip

Downloading/unpacking django-simple-captcha>=0.4.6 (from django-crispy-contact-form)
Could not find a version that satisfies the requirement django-simple-captcha>=0.4.6 (from django-crispy-contact-form) (from versions: )
No distributions matching the version for django-simple-captcha>=0.4.6 (from django-crispy-contact-form)

pip install django-simple-captcha
--> gives django-simple-captcha==0.4.5

I don't have any problems with 0.4.6
https://pypi.python.org/pypi/django-simple-captcha/0.4.6

That was it: outdated pip, sorry


Address npm dependency issues found in development branch [Opened by bitHound]

 bitHound discovered:  2 packages with at least one security vulnerability. 19 unused packages. 1 deprecated package. 35 outdated packages.  For details go to bitHound.

There is still at least one more PR that will be associated with this issue before it can be closed out. Was trying to get it completed today but taking longer than I expected.


Change to use PacketIn2/Controller2

This commit replaces the use of packetIn and controller with
packetIn2 and controller2, respectively. It also replaces the use of
the 'reason' with the 'userdata' to distribute packetIn2 to the
handler. Additionally, it replaces the use of 'customreason'
with 'userdata' to indicate what operations are needed for the
handler when there is a chance that multiple operations are required
for a single packetIn2.
Furthermore, this commit introduces a change to use 'pause'+resume
for FQDN policy.
This commit upgrades ofnet to v0.7.1 and libOpenflow to v0.10.1, where
the packetIn2/controller2 support was added.
Signed-off-by: graysonwu<EMAIL_ADDRESS>

Will update go.mod after https://github.com/antrea-io/ofnet/pull/49 merged.

/test-all

/test-all

/test-all

/test-all

/test-conformance

/test-all

/test-e2e


improve FRAME storage docs

I started by performing an exercise that I have suggested myself a few weeks ago: start writing a pallet, from scratch, with minimal copy-pasting. I have two goals:

find out the DX shortcomings first-hand.
build a new kitchensink-pallet that is a gallery of all features that the pallet-macro provides, see https://github.com/paritytech/substrate/issues/13951.

This is related to 1. While coding a pallet, your IDE will give readily allow you to see the docs of two components:

pallet::storage macro, which is coming from a stub in frame_support_procedural.
the types defined in storage::types, eg StorageValue.

This PR moves all the relevant documentation of storage items into either of these two, while not repeating anything.
An open issue I have, which is also highlighted as a TODO in the code is:
I want to link to types like frame_support::storage::StorageValue in the frame_support_procedural macro stub rust-docs. Any way to do that? The code expanded by frame_support_procedural has access to frame-support, but I am not sure if the macro code itself can.
I would like to next suggest doing the same about weights and benchmarking, given its importance and being one of the biggest pain points for many.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2816199

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2816216

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2816200

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3373318

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3373317


Add francischeng.md #48

Fixes #48

This PR should be against a repo in the org nus-cs2103-AY1617S2 not against the repo in se-edu org :-)
Closing...


Add new features for supporting TemporalGeometry Query Resources

The current MF-API Server doesn't support queryable resource parts (i.e., Distance, Velocity, and Acceleration).
We implement these functionalities during the OGC Codesprint using Mobility DB.

We implemented all APIs in OGC API - MF with MobilityDB 1.0


net/url: no way to construct raw unqualified request URI starting with //

http://play.golang.org/p/67oKm8TFcm
When I pass the URL in the playground into the http transport, it will call .RequestURI() and do a GET http://foo/bar%2F, while what I actually wanted was GET //foo/bar%2f. It looks like there is no possible way to construct a URL that will query for //foo/bar%2f.
Not quite sure how to distinguish between the case of Opaque containing a qualified URI and an unqualified one starting with //. Does it make sense to look at the host part after the // and see if it matches what's in Host?

This was fixed in Go 1.5: there is now a way to construct this request URI. Don't use Opaque, use RawPath (or just ParseRequestURI). I will add some tests to make sure this keeps working.
http://play.golang.org/p/De3q6SYhE9


Chatbot lists paths instead of names of repositories

See screenshot

And when selecting one of the parts, it is not accepted
Type the name or path also is not accepted

@grimpy @zaibon @xmonader the username of the moehaha chatbot is @Moehaha_bot, please make sure that it works and is tested there


issue running server code

Hi,
First of all, I'm very thankful for sharing your code.
After running server.js code I get this error :
Error connecting to Fabric network. TypeError: FileSystemWallet is not a constructor
Error in connecting to Fabric network.  TypeError: gateway.getClient is not a function
at Object.utils.events (/Users/biekzadehsiamak/Desktop/iBM_vsCode/fabric-contract-attribute-based-access-control/application/server/utils.js:133:28)
at main (/Users/biekzadehsiamak/Desktop/iBM_vsCode/fabric-contract-attribute-based-access-control/application/server/server.js:37:21)

Hi, I already test the code and it's working properly as long you follow the instruction carefully, and don't try to upgrade the dependencies and convert the the JavaScript files to ES6 Module because it will broke the program.


Test issue for adding issue to GitHub project

As subject.

The test succeeded, closing this issue now.


Use conditionals to reduce the coverage collection to one task call in case and pon GATK ACNV wdl

CalculateTargetCoverage and WholeGenomeCoverage can be called using a conditional.  The current WDL was a workaround, since it pre-dates cromwell conditionals.

Issue moved to broadinstitute/gatk #2940 via ZenHub


yahoo find league id for all years

fix issue #27

Thanks for looking into this!
I was investigating this a bit earlier this week and opened this issue in the library that I'm using for Yahoo.
The owner of that repo didn't think there was a link that Yahoo returned to find the previous/next league ID, but your find may be just that.
Have you tested this locally with a multi-year Yahoo league?
I would test myself but I do not have access to any Yahoo leagues that have multiple years in them.

Thanks for looking into this!
I was investigating this a bit earlier this week and opened this issue in the library that I'm using for Yahoo.
The owner of that repo didn't think there was a link that Yahoo returned to find the previous/next league ID, but your find may be just that.
Have you tested this locally with a multi-year Yahoo league?
I would test myself but I do not have access to any Yahoo leagues that have multiple years in them.

Yes, I have one that goes back to 2010 I tested with. 😃

As of version 1.3.1, this issue has been fixed.
Thank you for your help on this.


Add FAQ questions

Create and answer real FAQ questions and replace the placeholder ones currently on the branch

how to ensure your app workable


Fix styled text treated as an emoji

Details

(A) When we send a styled text (italic, bold, or any styling) from another website, our current EMOJIS regex matches the text as an emoji, and because we set the font size bigger for emoji only messages, the styled text also gets bigger.
And there is also an additional issue (B) where when we copy emoji only messages by selecting it from the sent message and send it again, the emoji font size is not big (only possible happens on web).
Fixed Issues

$ https://github.com/Expensify/App/issues/13823
PROPOSAL: https://github.com/Expensify/App/issues/13823#issuecomment-1367036075
Tests

(A)

Copy styled text generated from https://lingojam.com/ItalicTextGenerator
Open any report
Paste the text to the composer and send it
Verify the text has a normal size

(B-web only)

Send an emoji-only message
Notice the font size of it
Copy the sent message (by selecting it from right to left, not from the context menu)
Paste to composer and send it again
Verify the sent emoji-only message has the same font size

[x] Verify that no errors appear in the JS console

Offline tests

(A)

Copy styled text generated from https://lingojam.com/ItalicTextGenerator
Open any report
Paste the text to the composer and send it
Verify the text has a normal size

(B-web only)

Send an emoji-only message
Notice the font size of it
Copy the sent message (by selecting it from right to left, not from the context menu)
Paste to composer and send it again
Verify the sent emoji-only message has the same font size

QA Steps

(A)

Copy styled text generated from https://lingojam.com/ItalicTextGenerator
Open any report
Paste the text to the composer and send it
Verify the text has a normal size

(B-web only)

Send an emoji-only message
Notice the font size of it
Copy the sent message (by selecting it from right to left, not from the context menu)
Paste to composer and send it again
Verify the sent emoji-only message has the same font size

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/50919443/209896082-f9df6f45-b019-4125-bd41-b9b1c73fd961.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/50919443/210041204-126c8d5b-6019-4aa1-8314-04f0769e783b.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/50919443/210091873-72fbbf6d-a06a-421d-9d82-24c1e5375e93.mp4

Desktop

https://user-images.githubusercontent.com/50919443/210038320-d9f179a6-27b0-4d2e-be9d-dac82bfa3f23.mov

iOS

https://user-images.githubusercontent.com/50919443/210038411-4c2981ef-3a35-4c00-9ec9-c5cf80d61d08.mov

Android

https://user-images.githubusercontent.com/50919443/210034713-0aa7535e-9644-4c50-b1be-4296a3de0eca.mp4

My IP has been whitelisted. Added the video for iOS mWeb and added some commits for the suggested changes.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @AndrewGable in version: 1.2.47-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.2.47-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


build action

Current coverage is 12.14% (diff: 0.00%)

No coverage report found for experimental at daf8207.

Powered by Codecov. Last update daf8207...a649420


thin-provisioning-tools: test boot configuration

Description of changes
This brings a test for the condition that triggered bug https://github.com/NixOS/nixpkgs/issues/317018
This sits on top of #317087
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cc @anpin

Thanks @baloo. Do you think I should merge this in the fix PR?

Actually, this does not reproduce the original issue anymore. I'm a bit confused.


CI doesn't pick up samples located in subdirectories

All the samples located in subdirectories are ignored.
I suggest that CI should read a file with list of samples that should be tested, as just scanning for "yml" files may be not ideal solution.
Some yml files may be nor exactly samples.
In case of some tests (these in subdirectories), samples should be executed in particular sentence.
This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce
run tests
check if any sample from subdirectory was run
Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

PR #38


[FLINK-23172][docs] Fix broken links to Task Failure Recovery page on Configuration page

What is the purpose of the change
The links to Task Failure Recovery page inside Fault Tolerance section and Advanced Fault Tolerance Options section on the Configuration page are broken.
The links are located in RestartStrategyOptions and JobManagerOptions. For more details please see FLINK-23172.
Brief change log

Fix broken links in RestartStrategyOptions.java and JobManagerOptions.java
Generate the docs based on the modification above

Verifying this change

Run the local server with Hugo and check if the links head to the correct pages.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / *no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Can we also fix the link in "jobmanager.execution.failover-strategy" which breaks due to the same reason?

Can we also fix the link in "jobmanager.execution.failover-strategy" which breaks due to the same reason?

Thank you for pointing this out. I get it fixed in the second commit.


LDAP Authentication

This issue resolves #12
This PR introduces initial support for configuring and managing LDAP authentication.

Tested this method on Ubuntu 20.04, CentOS 8.3 and RHEL 8.4 with success authenticating via LDAP.


"mocha-teamcity-reporter" reporter blew up with error:

20:19][Step 4/4] "mocha-teamcity-reporter" reporter blew up with error:
[08:20:19][Step 4/4] ReferenceError: window is not defined
[08:20:19][Step 4/4]   at Object. (D:\tc\ba1\work\39f0d6d839da2ca9\src\node_modules\mocha-teamcity-reporter\lib\teamcity.js:25:5)
[08:20:19][Step 4/4]   at Module._compile (module.js:541:32)
Version: 1.1.0
Previously. 1.0.2 works fine

Confirmed this behavior. Getting the same error as well. Running on Node.js environment (Node 6.3.4)

Same issue - all our CI builds are broken :-(
[06:52:21][Step 2/2] "mocha-teamcity-reporter" reporter blew up with error:
[06:52:21][Step 2/2] ReferenceError: window is not defined
[06:52:21][Step 2/2]     at Object. (C:\BuildAgent\work\45d48cc6de5b6cea\node_modules\mocha-teamcity-reporter\lib\teamcity.js:25:5)
[06:52:21][Step 2/2]     at Module._compile (module.js:556:32)
[06:52:21][Step 2/2]     at Object.Module._extensions..js (module.js:565:10)
[06:52:21][Step 2/2]     at Module.load (module.js:473:32)
[06:52:21][Step 2/2]     at tryModuleLoad (module.js:432:12)
[06:52:21][Step 2/2]     at Function.Module._load (module.js:424:3)
[06:52:21][Step 2/2]     at Module.require (module.js:483:17)
[06:52:21][Step 2/2]     at require (internal/module.js:20:19)
[06:52:21][Step 2/2]     at Mocha.reporter (C:\BuildAgent\work\45d48cc6de5b6cea\node_modules\mocha\lib\mocha.js:151:21)
[06:52:21][Step 2/2]     at new Mocha (C:\BuildAgent\work\45d48cc6de5b6cea\node_modules\mocha\lib\mocha.js:88:8)
[06:52:21][Step 2/2]     at module.exports (C:\BuildAgent\work\45d48cc6de5b6cea\node_modules\gulp-mocha\index.js:12:14)
[06:52:21][Step 2/2]     at Gulp.gulp.task (C:\BuildAgent\work\45d48cc6de5b6cea\node_modules@informa\tasks.pharma\lib\index.js:112:15)
[06:52:21][Step 2/2]     at module.exports (C:\BuildAgent\work\45d48cc6de5b6cea\node_modules\orchestrator\lib\runTask.js:34:7)
[06:52:21][Step 2/2]     at Gulp.Orchestrator._runTask (C:\BuildAgent\work\45d48cc6de5b6cea\node_modules\orchestrator\index.js:273:3)
[06:52:21][Step 2/2]     at Gulp.Orchestrator._runStep (C:\BuildAgent\work\45d48cc6de5b6cea\node_modules\orchestrator\index.js:214:10)
[06:52:21][Step 2/2]     at C:\BuildAgent\work\45d48cc6de5b6cea\node_modules\orchestrator\index.js:279:18

Submitted a PR to fix this issue: https://github.com/travisjeffery/mocha-teamcity-reporter/pull/22

Have the same error, node v4.4.0

Just pushed v1.1.1 fixing this, thanks @rajwilkhu


V1 Client APIs do not support authentication

All of the CLIs using the v1 client do not support authentication. We can either push auth support into the V1 Client/Server implementations or migrate away from the V1 Client/Server methods.

We can either push auth support into the V1 Client/Server implementations or migrate away from the V1 Client/Server methods.

I'm going to do the former as it should be as simple as just attaching auth tokens to the client requests. These methods will continue to work unauthenticated if the server has not been configured (as the default policies encode the existing v1 behaviours), and will still require signing of payloads where necessary, so this isn't a breaking change.


h2 headline doesnt have the "#" effect

Hey @shuding, thanks so much for creating this amazing project 🙏🏼 It's been a tremendous help. I have only one issue that's preventing me from delivering a no-brainer replacement for Hugo:

I cloned the master branch just now and tried to run locally, but the h2 headline doesnt have the "#" effect
thanks @anudit , let me check yours
Originally posted by @ChinW in https://github.com/shuding/nextra/issues/235#issuecomment-973861043

After reading this thread, I was able to solve one of my issues (missing titles on individual pages), however I'm still having the exact same issue as a couple others are/were having: h2 headlines (##) don't have the "#" effect that automatically populates these links into the navbar on the left.
I replicated all of the changes described below and it's still not working:

@ChinW checkout the codebase anudit/convodocs, Got the titles and floatTOC to work correctly with the latest versions of the dependencies.
Originally posted by @anudit in https://github.com/shuding/nextra/issues/235#issuecomment-973859193

Note the format of the meta.json documented by Nextra is different from what is used in the above. I tried it using the different structure (object vs key/value + "type": "nav"), but this ends up adding them to the header rather than a side navbar, so I walked this change back.
Separate but lesser concerns that don't currently impact me:

floatTOC doesn't work, no matter how I format the meta.json
.md files don't render properly, with React imports & navbar JSON showing up in the browser window; I have to change the file extensions to .mdx in order for them to work properly

Aside from the issues mentioned above, Nextra has been absolutely awesome, and I'd love to be able to solve this one remaining dealbreaker. Anyone else seeing this issue? Anyone else figure out a solution?

Thanks for writing this! I think it's because I'm using a raw <h2> here instead of ## to avoid it in the sidebar: https://raw.githubusercontent.com/shuding/nextra/master/pages/features/mdx.mdx

Thanks for writing this! I think it's because I'm using a raw <h2> here instead of ## to avoid it in the sidebar: https://raw.githubusercontent.com/shuding/nextra/master/pages/features/mdx.mdx
I did it intentionally to make the sidebar cleaner.

Hey @shuding, thanks for getting back to me. I'm genuinely confused. Perhaps you're referencing a different version than the one I'm seeing, but in the one I'm looking at both in the repo & the live deployed website, I see your linked file is using ##, not <h2>. I also see the ## showing up in the menu, as is my goal (& the goal of others). See attached image, which illustrates my confusion :)

Sounds like you're describing exactly the opposite: trying to prevent them from showing up in the menus. It would be great if the meta.json or other mechanism could easily allow us to customize whether h2/## headers are included or excluded from the nav menus.
Of course, when I looked at the example repo by @anudit, I saw an example of converting the meta.json from key/value to objects, which allows the inclusion of a "hidden": true property -- however, I also discovered this was incompatible with the vertical menu, only with displaying them along the top menubar horizontally.

@shuding by the way, I thought perhaps I misunderstood you, so I tried replacing own own ## headlines (which match how your documentation site works) with <h2> headlines, but it produces no change. I'm still unable to get them to show up in the menu, regardless of which option I use.

facing the same issue here

Hey @samuelgoff @faisalsayed10 are you on version 2.0.0-beta.5 for nextra and nextra-theme-docs ?

nope. this is in my package.js
    "nextra": "^1.1.0",
    "nextra-theme-docs": "^1.2.6",

@faisalsayed10 Try switching to 2.0.0-beta.5

ohh yeah, it started working now

Fixed in both @beta and @alpha releases, working on making it stable in 2.0 soon 🙏


Enable AppVeyor PR notifications with links to all artifacts

The issue causing the links to be randomly sorted should be fixed soon: appveyor/ci#3219.

:white_check_mark: Build sws 110-master completed (commit https://github.com/reaper-oss/sws/commit/dd75d1f41c by @cfillion)

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=i686

build/sws-<IP_ADDRESS>-Linux-i686-pr-artifact-links-8e43bef4.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=x86_64

build/sws-<IP_ADDRESS>-Linux-x86_64-pr-artifact-links-8e43bef4.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=aarch64

build/sws-<IP_ADDRESS>-Linux-aarch64-pr-artifact-links-8e43bef4.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2019, ARCH=x86

build/BuildUtils/SWS_Template.ReaperLangPack
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-pr-artifact-links-8e43bef4.exe

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=armv7l

build/sws-<IP_ADDRESS>-Linux-armv7l-pr-artifact-links-8e43bef4.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2019, ARCH=x64

build/BuildUtils/SWS_Template.ReaperLangPack
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-pr-artifact-links-8e43bef4.exe


fix!: sync with<EMAIL_ADDRESS>based on (PRs #194 #200)

This is a re-raise of #201 by @pham 🙇
Summary

Fix missing 2nd arg for Server.respond() causing TypeError (see error dump below)
Add prerendered files to public dir (thanks @AndrewLester)
Add Node.js 18 support

Fixes: #194 #200 #201 #202
TypeError
⚠  functions: TypeError: Cannot read properties of undefined (reading 'prerendering')
    at respond (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31409:14)
    at Server.respond (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31705:12)
    at svelteKit (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31767:33)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async runFunction (/tmp/svelte-adapter-firebase-wxGf/node_modules/firebase-

I misunderstood how release-please computes conventional-commit breaking changes (!) with the type chore, so my merge of #201 was erroneous. I have recreated the PR here. @pham sorry. The reason for the change of conventional-commit type was because this change is breaking, so the initial fix: would only create a semver patch update, not a semver minor update, fix!: would create a semver minor update.

Thanks for the merge @jthegedus! Appreciate the work you're doing!

I second that... very very much thanks to you @jthegedus 👏 😃


Add more information to thumbnails

Below is the QTip popup and thumbnail that gets displayed with TISAS (topic #15976), just to give an idea of what I'm talking about below.

Which items get added could vary from the above, especially the uploader name given the sensitivity to that by some people. I would at least like to see age from the popup, as I frequently have to open the artist page just to find out when the last time an artist has been uploaded to. The image information below the thumbnail would also be useful, but probably not the post #. I just added that in TISAS to round out the display info when comparing it against the original image(s). Score and favcount could be useful, just to show how well received an artist's uploads are. Not sure it's needed to add the rating, although maybe add a data item to the article container like data-rating so that users can block questionable or explicit images with a CSS extension.
Important:

Age (time ago)
Source info (domain)
Image info (width, height, filetype, filesize)
Rating (data item)

Optional:

Rating  (displayed info)
Score
Favcount
Username... maybe?

I added displaying of some info.
Now extraction of the domain name works incorrectly, e.g. for pixiv, it returns pximg.net. I think we should add a map of domain names for the most popular ones. Btw, I remember right, somewhere on the forum I saw the list of the most popular sources but I can't find it now.

Rating (data item)
Rating (displayed info)

What is the difference? Or it is the short and full name?

Rating (data item) is adding the rating to the HTML structure, like data-rating="e" . You can do that, or you can add a class, but I'd consider doing the the data item as it's easier. The purpose of that is that users could add something like the following to CSS extension like Stylus to hide ratings of questionable and/or explicit nature.
Example with hiding:
.post-preview[data-rating=q],
.post-preview[data-rating=e] {
    display: none;
}

Rating (displayed info) is actually showing the rating to the user.

Now extraction of the domain name works incorrectly, e.g. for pixiv, it returns pximg.net. I think we should add a map of domain names for the most popular ones.

In my script, I just show the image domain, i.e. pximg.net. I think it's usually clear where an image came from even if from a different domain of the actual source.

Btw, I remember right, somewhere on the forum I saw the list of the most popular sources but I can't find it now.

Do you mean topic #14119?

I gave the new tooltips a whirl, and I noticed a few things.

The unevenness of the lines is a bit distracting.
There's some element spacing issues as seen by the following.

https://twitter.com/inumoto/media

Some border color issues

https://twitter.com/pailand/media

The above are all supposed to be yellow or green as seen below.
https://danbooru.donmai.us/artists/5954

Line overflow on the ratings line, especially with questionable and explicit ratings
Cannot view the entire tooltip in the tweet view on Twitter (old version)

https://twitter.com/188_sch/status/1156211897667993601 (Warning! NSFW)
The thumbnails were intentionally blacked out.

That second row of images was half-cutoff and was as much as I could see. Regardless, it took having to middle scroll to see most of the toolttips even in the regular timeline view (old Twitter). I imagine that artists with huge URL sections would suffer the same.
One thing that could be done would be to have a static placement for the artist name and post count, and then have the rest overflow into scrollable content, like what is currently done with Danbooru's tooltips.  Example: tagcount:>100

Btw, I remember right, somewhere on the forum I saw the list of the most popular sources but I can't find it now.

Do you mean topic #14119?

No, there was another list with a domain name and number of pictures uploaded from it. And some sources, like pixiv, were presented 2 times: with 2-level (pixiv.net) and 3-level (www.pixiv.net) domain names.

The purpose of that is that users could add something like the following to CSS extension like Stylus to hide ratings of questionable and/or explicit nature.

Here is a problem: qtip's content is added via Shadow DOM and since not-in-shadow CSS can't reach the content. But I can add settings to blur/hide some ratings.

Here is a problem: qtip's content is added via Shadow DOM and since not-in-shadow CSS can't reach the content. But I can add settings to blur/hide some ratings.

Actually, shadow parts can be used to allow the exposure of certain parts of a Shadow DOM for styling.
https://developer.mozilla.org/en-US/docs/Web/CSS/::part
I tried it out and it works. For the below, I added part="post-preview" to all of the thumbnail containers, and part="post-preview rating-safe" to only one thumbnail container.

Styling all post-preview parts.
.qtip-content::part(post-preview) {
    background-color: black;
}

Styling only rating-safe parts.
.qtip-content::part(rating-safe) {
    background-color: black;
}

The caveat though is that only the elements with part attributes can be styled, so no styling of descendants unless those descendants also have parts. Also, parts behave like classes, i.e. they can have more than one part specifier, but they have to be space separated.

No, there was another list with a domain name and number of pictures uploaded from it. And some sources, like pixiv, were presented 2 times: with 2-level (pixiv.net) and 3-level (www.pixiv.net) domain names.

Oh, you mean [topic #1234](No, there was another list with a domain name and number of pictures uploaded from it. And some sources, like pixiv, were presented 2 times: with 2-level (pixiv.net) and 3-level (www.pixiv.net) domain names.) then?

Alright, I took a look at the updated qtips, and found a couple more items.

The thumbnails and their text information does not align.

Source: https://twitter.com/inumoto/media

I was encountering the same issue with TISAS, and I had to manually add a padding-top style to the image element itself.

That gets it to look like the following.

Significantly different text info widths.

The time ago line is much shorter than the other two lines.
I added a letter-spacing of 3px to better spread it out.

${timeToAgo(post.created_at)}

Admittedly, this one is more of a preference thing, and I imagine that there might be users that find the text spreading to be more distracting than the difference in line length.

Just barely a scroll container

As seen in all of the examples above, when 4-6 thumbnails are the setting, the scrollable section is minuscule. Either optimize the maximum height for 1 line of thumbnails or 2 lines.
2 lines, max-height = 420px

1 line, max-height = 220px

Incorrect setting of default settings

The code doesn't have the right parameters for GM_setValue. It only has one parameter, whereas the first parameter should be the name and the second parameter should be the value. The following is what gets set as the default.
{
    "booru": "https://danbooru.donmai.us",
    "cache_lifetime": 3000,
    "preview_limit": 5,
    "q": "undefined"
}

Adding the name to that function though fixes that.
function getSetting(name, defValue, validator) {
    const value = GM_getValue(name);
    if (typeof value === "undefined" || validator && !validator(value)) {
        GM_setValue(name,defValue);
        return defValue;
    }
    return value;
}

Which produces...
{
    "booru": "https://danbooru.donmai.us",
    "cache_lifetime": 3000,
    "preview_limit": 5,
    "blur_preview_rating": "q"
}

Unable to show all ratings

Currently all 3 ratings can be hidden, but all 3 ratings cannot be shown. It should probably be the opposite, since I can't really think of a reason why a user would want to hide the safe rating. Also, it's more likely that a user may not care and wants to see everything.
I do like the way that a blur option is offered to the user in addition to adding parts to various elements.  Some users may not know how to setup or install a CSS addon, plus blurring unsafe images would probably be enough for most users.

Significantly different text info widths.

The spacing is too big as for me. I prefer to swap lines.
A bit reduced spacing for the longest case hentai-foundry.com, rating:Q.

Incorrect setting of default settings

It was fixed but I accidentally removed the fix when undid some changes :(

Unable to show all ratings

It was supposed to set the empty string to show all ratings. Now I inverted the setting.

It looks good. One thing I thought of though was the possibility of an overly large "other names" section.
https://twitter.com/eber_accebeR

The above still fits, however the larger size makes it more difficult to get the whole thing to fit inside the screen. Additionally, although I wasn't able to find an artist with an "other names" section longer than the above, the possibility still exists for that section to fill up the entire screen. It should probably be limited to 2 rows before overflowing into a scrollable section.

Done, I also removed underscores in the names.
Here is one annoying issue: when you hover an image (e.g. to unblur it), appears a tooltip with the tag list and if you hover it you automatically unhover the qtip and it disappears. And I can't google any fitting case to get a solution clue.

It looks good now.

Here is one annoying issue: when you hover an image (e.g. to unblur it), appears a tooltip with the tag list and if you hover it you automatically unhover the qtip and it disappears. And I can't google any fitting case to get a solution clue.

I'm not getting what you're talking about. The taglist popup isn't supposed to stay up when you hover over it. It only appears when you're hovered over the image itself.
If you don't want the taglist tooltip to appear, you just need to hover just outside the image where the image container is at. It helps if the image is long or wide, but works even if the image is square (although the margin for error is a lot smaller).

Also, the README.md needs to be updated with the new user value. You can use the following screenshot when editing that file.

@7nik There's a misspelling in the settings update for the README.md

Possible values are "s", "q", "e" (save, questionable, explicit).

It should be "safe" instead of "save".

Oh, thank you!


gateway-api: incrementally update push context on namespace events

Please provide a description of this PR:
When the gateway controller triggers a full push on namespace events, set PushRequest.ConfigsUpdated so that we can update the push context incrementally rather than create a new one

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
ef7f100fca70c2fc0eabfc6d7e5bb929828516af
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
61e8db44097cc8b08f3e04e09b60d43b06d890b2
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

THis will introduce xds cache not cleared when namespace is deselected.
Think of this case, a vs is selected by a namespace, and later deselected, then it will still in the xds cache

I don't think so, if a route is deselected, its status will be changed in this push(triggered by the ns event),  which will trigger another push, and the xds cache can be correctly cleared then

not sure about how this could trigger push, can you shoe that

ns deselected -> full push -> gatewayController.Reconcile ->
route status updated -> config handler triggered -> full push -> xds cache cleared

FYI https://github.com/istio/istio/blob/1.15.3/pilot/pkg/config/kube/gateway/conditions.go#L103-L106

I am not sure how safe it is to rely on correctness of updates with Status updates. In theory the spec could change to not require us to write some status field and suddenly we would not have xds pushes which seems wrong.
Status and XDS are orthogonal, so coupling should be avoided.

I see, although I think reference grants would highly rely on status updates and some of our current logic might already have
Anyway I will revert the push code

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
175fcc5e28f1bd85fae3a1cb0f7856a79c23441a
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


chore: Update x86_64 crate links to latest version

Description
The x86_64 crate recently published a new version. Noticed that these links still point to 0.11.0 when 0.11.1 is now out. Left the /deprecated posts unchanged since they point to very out of date versions. And FYI just used this command to replace all of them:
find . -name "*.md" -exec sed -i '' "s,https://docs.rs/x86_64/0.11.0/,https://docs.rs/x86_64/0.11.1/,g" {} +

Also fixed links to the PhysAddr and VirtAddr structs which now have a /addr/*Addr path (in posts 08,09,10).
Pretty sure the failed Zola Check test is unrelated to my changes.

And can I just say, love everything you and all contributors have  done for the Rust community by making OS development so much more approachable in Rust :pray: Just started on my own OS thanks to you, following your guide and OsDev wiki mainly!

Thanks for your work on this and sorry for the late reply! Normally, I don't always update all the doc links for each new minor version of dependencies because most of the time there are no changes that are relevant for the blog. That being said, I do appreciate this PR since it's always good to be up-to-date.

And can I just say, love everything you and all contributors have done for the Rust community by making OS development so much more approachable in Rust pray Just started on my own OS thanks to you, following your guide and OsDev wiki mainly!

I'm very glad to hear that!


 The face pose model and landmark model are all primary aiming at high speed and not using deep learning method. So you can check which factors are more influential.

Thank you for your reply


[Install] Add support for Learn Layer5 sample app (for SMI Conformance)

Enhancement Description
Add support for provisioning and deprovisioning the Learn Layer5 sample application on Linkerd service mesh deployments.

I have a consider on the dependencies version the different may make broken to the adapter


Allow additional identifiers to be passed in to the babel plugin

Summary
I would like to wrap loadable in my own higher order component functions.  Loadable by default only injects a webpack chunk name  for loadable and lazy, but can readily accept additional identifiers.
This PR allows us to rewrite
// Loadable
const LoadableHelpPage = loadable(() => import('./HelpPage'), {
  resolveComponent: components => components.HelpPage,
})
// Our custom HOC
const HelpPage = PageHOC(LoadableHelpPage, {...additional page props })

to
const HelpPage = LoadablePageHOC(() => import('./HelpPage'), 'HelpPage', { ...additional page props })

We actually have a separate HOC for modals, so we would not be able to simply rename LoadablePageHOC to loadable for the sake of the existing babel plugin.  With the changes, we can specify additionalIdentifiers: [ 'LoadablePageHOC', 'LoadableModalHOC'] to transform both.
Test plan
New tests have been added that showcase the custom identifier being transformed or not, depending on babel options.

Got your idea, the request seems quite familiar 👍 and look like the currently proposed way to implement own loadable - loadable-detection - is not working. At least looking at the code.
In short - a right move, but let's take one more step and perfect this solution so it would not backfire in a couple of years as I don't feel that replacing random functions is a very safe pattern.
What about changing the configuration a little bit to replicate the current logic of "autodetecting" loadable imports, but for a custom function?
Ie
additionalIdentifiers: [ 'LoadablePageHOC', 'LoadableModalHOC']
⬇
signatures: [
  {name:'LoadablePageHOC', from:'@myapp/loadable'},
  {name:'LoadableModalHOC', from:'@myapp/loadable'},
  {name:'default', from:'@loadable/components'}, // still support default way
]

One can also refactor the current logic "looking" for default import of loadable and named import of lazy to utilize the same configuration, with your ability to totally override default configuration

@theKashey Thank you for the review.
Your suggestions are great, I should hopefully have some time this week to make the changes.

Amazing result 👍
Let's get it merged and I will update the documentation shortly after.

Released as 5.16.0


[Côte d'Ivoire]: Fixed parsing of mobile numbers and fixed splitting to ...

...reflect ITU specification
References:
[0] ITU
http://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000310001PDFE.pdf
[1] Telephone numbers in Ivory Coast
http://en.wikipedia.org/wiki/Telephone_numbers_in_Ivory_Coast
Fixes:
The Ivory Coast numbers do not have a trunk code leading to the situation that valid numbers such as '22507123456' would be normalized as '2257123456'. Furthermore, if you look at the
allocation of both landline and mobile numbers given in both [0] and [1], the area code is fixed to 2 digits. In the case of landlines, the ITU spec will list out 3 digit area codes
but this is only because they are making the separation based on telecom provider as well. That is, the 3rd digit of the national subscriber number signifies the network operator. But viewing
it from the zones listed in the "Usage of E.164 number" column, it is clear that the zones are allocated 2-digits. This also matches up with the information in [1] as well as the way the
numbers are formatted in [0]
Côte d'Ivoire
Tel: +225 20 34 43 74
Fax: +225 20 34 43 75
URL: www.artci.ci
As a result, the parsing of Ivory Coast numbers will split the NSN into 4 2-digit numbers. Furthermore, we need to set the trunk code to an empty string to prevent it from being removed
during normalization (similar to how it is done for Italy)

Coverage increased (+0.03%) to 99.3% when pulling db125392b487d831d66810febb46678353889a84 on tpena:feature/ivory-coast-parsing into 079693da23c81916ad2cfa040e687a4379f27808 on floere:master.

Thanks! :+1:

Released in 2.12.11.


CLI: add staking related commands/features

Duplicates of https://github.com/iotaledger/iota-sdk/issues/1943


Update to Swift 3

Ah, so someone actually uses this library!
Will look at this tonight.
best case scenario, I'll make a Swift 3 branch, instead of doing a full merge.

Hahah, yes, there are people using it 😄
Cool, let me know if you want me to recreate the PR against another branch 👍

Will do - just got home, so will do this tomorrow afternoon as it's late.

Done: https://github.com/ArtSabintsev/Magic/pull/8
Now I need to figure out how to add a subspec to the master repo that points to the swift3 branch.
I'm not going to pill in that PR until Swift 3 is live.

Closing this PR.


Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req()

BLE_GAP_EVENT_L2CAP_UPDATE_REQ and BLE_GAP_EVENT_CONN_UPDATE_REQ share the same conn_update_req event structure when they are sent to the application callback, but they do not behave the same way.
ble_gap_rx_param_req() creates a self_params, allowing the application to adjust the parameters to something acceptable.  ble_gap_rx_l2cap_update_req() just leaves the self_params pointer NULL.  Now they both use self_params.
In my specific case, the ESP32 platform I am using crashes if I don't enforce a specific set of parameters when multiple peripherals connect.  Since the peripherals use the L2CAP method to make the request, this change eliminates the crash.

I’ve been seeing this happen as well on esp32. Only way to prevent it I have found is to reject the peer request then manually change the parameters after. This PR makes more sense.

The reson why it differs between BLE_GAP_EVENT_L2CAP_UPDATE_REQ and BLE_GAP_EVENT_CONN_UPDATE_REQ is basically because over L2CAP you can only accept or reject the requested parameters. There is no option to modify the parameters here.
Having this patch, we could end up in the situation that remote devices requested for parameters set A, we reply over L2CAP that we accepted those, but in fact we set parameters B, which is not nice.
If master wants to change parameters, he can always do it, but if remote ask for the specific parameters set, we either Reject or Accept and set it.
I believe, that you need to fix you application and on BLE_GAP_EVENT_L2CAP_UPDATE_REQ does not modify self_parameters.
Hope that explains.
If you agree please close this PR.

If the peripheral requests an interval between 16 and 20, and I force the radio through this mechanism to use an interval of 18, it seems to me I've still accepted the peripheral's request because the connection interval will still match the peripheral's request.
I think the only invalid behavior would be to accept the request but to choose a  parameter out of the range requested by the peripheral (or to change one of the parameters that isn't given as a range).

@zacwbond What @rymanluk is saying is that the procedure you are suggesting would go against the bluetooth core spec, although it does help with the esp32 issues.
The esp32 has some weird issues with connection parameters stuffing it up with multiple connections, this is a specific case though. I think it's better to handle it manually by just rejecting the request and then calling ble_gap_update_params() afterward. This may cause issues if your peripherals are picky about accepting their parameters though, in which case there's not much else to do but maintain this patch in your own code.

@zacwbond Actually on the second thought, why not to allow application to fine tune that parameters. It is up to application to behave correctly here.
If there will be no voices against that I will merge it. Thanks

if we are going to allow adjusting min/max interval by application, we also need to make sure that selected range is within original range, otherwise we violate spec as @rymanluk said before. adding this extra check would both resolve original issue and would not make our host accept parameters that violate spec.

@andrzej-kaczmarek  I agree.

@zacwbond Could you please add additional check as @andrzej-kaczmarek suggested?

Got it, thanks.  I'll make the change as soon as I am able.


Read from Kafka

Hi,
I am trying to run the kafka reader example, but getting the following error. It seems that the Kafka plugin stuck at the Read.Map step.
step:<topic>.list0
  output : d0
     shard:0 time:11.505ms completed 3630
     ...
step:<topic>.RoundRobin1
  input  : d0
     shard:0 time:11.505ms completed 3630
     ...
  output : d1
     shard:0 time:17.107ms completed 227
     ...
step:<topic>.Read.Map2
  input  : d1
     shard:0 time:17.107ms completed 227
     ...
  output : d2
     shard:0 time:2m21.86562s processed 0
     ...

Failed to process output: Failed to read message: Failed to read message content size<PHONE_NUMBER>, but read only 24060620: unexpected EOF

step.go:58: Failed to run task Output-0: Failed to read message: Failed to read message content size<PHONE_NUMBER>, but read only 24060620: unexpected EOF

could be due to different kafka versions.

@chrislusf I have kafka 0.10.1, not old but also not the latest. It seems that if I put the flow definition and run inside a github.com/codegangsta/cli sub command, I will get this issue. If I put flow definition and run in main, it works fine.
Another question here: how gleam handles the errors emit from mappers? Is there any way that I could keep metrics of errors from different mappers?
Thanks!

I see. This is not related to Kafka. Gleam needs to run via normal CLI via "flag" package, not some other sub command.
Gleam currently only print out the errors back to the driver console. Later we need a new way to intercept the errors.


Building the Typhoon.framework Library

Hello!  Nice project!  I just cloned Typhoon Framework and tried to build the framework but it is failing when I'm trying to build the Cocoa framework library.  The error indicates that UIDevice is an undeclared identifier (the other error is in reference to UIUserInterfaceIdiomPad being unidentified), but I've checked to see if the framework target has UIKit as a linked framework and it does.  I've even checked the Build Phases tab and I don't see anything wrong.  How do I just clone the project and build the Cocoa Framework library?

The framework target was contributed by @mowens . . perhaps he's available to take a look? Otherwise we'll investigate ASAP.
Meanwhile, we recommend using Typhoon with CocoaPods. By default CocoaPods creates a static library, but if you specifically want a framework, it can support that now too.

Thanks @jasperblues!  I do have the beta version of CocoaPods (0.36 beta 2) and it still creates a static library for Typhoon for some reason.  I didn't look too heavily into it.  I decided to follow your documentation on creating a git submodule for swift to build a dynamic framework.  It didn't build there, so I just cloned the project and tried to build it.
I was planning on using Swift on a project and seeing if I could just use frameworks instead of using a bridging header, but I can always go the recommended approach if the framework route is not ready.  Thanks for your help.

@zenkimoto I believe that documentation should be updated as @mowens  is now recommending CocoaPods. Here's an example:
# platform *must* be atleast 8.0
platform :ios, '8.0'

# flag makes all dependencies build as frameworks
use_frameworks!

# framework dependencies
pod 'Typhoon', '2.3.3'

Does the above work for you?

#281

@zenkimoto Yes @jasperblues  is correct in that it would be ideal to leverage CocoaPods instead of the dynamic framework target, however the target should still build (last I checked from master). Note that you have to use the use_frameworks! in order to force the project to build as a dynamic framework (CocoaPods will automatically build pods as dynamic frameworks only if they contain swift code, thus you want to force pods to build as frameworks).
I will look into the framework target sometime tonight as that should still be a valid way to include the project.

Thanks @mowens , once @zenkimoto  confirms Podfile example works, I'll update docs to recommend that as the first course of action, while the manual build remains an option.

Hi @jasperblues @mowens
Thanks guys!!!  I used Cocoapods with the use_frameworks! specification and it works.  I guess I should have tried that.  (But if I did, I probably wouldn't have reported this issue :-D)  I do prefer Cocoapods over manually building.  Thanks for your help, it's working great now.
As far as why the framework isn't building, I'm not sure.  Perhaps it's my setup?


Some files now longer play (Chromecast Ultra firmware 1.28.100555)

The same video files which played yesterday now no longer play, though some files do play.
I am still able to play the now non-working file through other means (e.g., BubbleUPnP client).
It's not clear to me whether this is due to an update on the Chromecast. For what it's worth I did try a factory reset on the device before confirming the failed playback.
$ DEBUG='castnow*' castnow s10e01.mkv
castnow volume step: 0.05 +0ms
castnow launching... +1ms
castnow:stdin [ { path: 's10e01.mkv' } ] +1ms
castnow:localfile started webserver on address <IP_ADDRESS> using port 4100 +6ms
castnow player status: loading plugins +1ms
castnow player status: scanning +0ms
castnow player status: connecting +10ms
castnow player status: launching +46ms
castnow player status: loading +1s
castnow:localfile incoming request serving s10e01.mkv +101ms
castnow player status: ready +1s
castnow player status: idle +9ms
$ mediainfo s10e01.mkv
General
Unique ID                                :<PHONE_NUMBER>3835756931034307857593713827 (0x49FABDD0472F0918C77A1BE73D0CC4A3)
Complete name                            : s10e01.mkv
Format                                   : Matroska
Format version                           : Version 4 / Version 2
File size                                : 268 MiB
Duration                                 : 43 min 34 s
Overall bit rate                         : 861 kb/s
Writing application                      : Lavf57.71.100
Writing library                          : Lavf57.71.100
ErrorDetectionType                       : Per level 1
Video
ID                                       : 1
Format                                   : HEVC
Format/Info                              : High Efficiency Video Coding
Format profile                           : Main@L3@Main
Codec ID                                 : V_MPEGH/ISO/HEVC
Duration                                 : 43 min 34 s
Width                                    : 720 pixels
Height                                   : 480 pixels
Display aspect ratio                     : 16:9
Original display aspect ratio            : 16:9
Frame rate mode                          : Constant
Frame rate                               : 23.976 (24000/1001) FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Writing library                          : x265 1.5:[Windows][GCC 4.9.0][64 bit]
Encoding settings                        : wpp / ctu=64 / tu-intra-depth=1 / tu-inter-depth=1 / me=1 / subme=2 / merange=57 / no-rect / no-amp / max-merge=2 / temporal-mvp / no-early-skip / no-fast-cbf / rdpenalty=0 / no-tskip / no-tskip-fast / strong-intra-smoothing / no-lossless / no-cu-lossless / no-constrained-intra / fast-intra / open-gop / interlace=0 / keyint=240 / min-keyint=24 / scenecut=40 / rc-lookahead=15 / bframes=4 / bframe-bias=0 / b-adapt=0 / ref=2 / weightp / no-weightb / aq-mode=1 / aq-strength=0.00 / cbqpoffs=0 / crqpoffs=0 / rd=2 / psy-rd=0.00 / psy-rdoq=0.00 / signhide / lft / sao / no-sao-non-deblock / b-pyramid / cutree / rc=2 / pass / bitrate=600 / qcomp=0.60 / qpmin=0 / qpmax=51 / qpstep=4 / cplxblur=20.0 / qblur=0.5 / ipratio=1.40 / pbratio=1.30
Default                                  : Yes
Forced                                   : No
Color range                              : Limited
Color primaries                          : BT.601 NTSC
Transfer characteristics                 : BT.709
Matrix coefficients                      : BT.601
Audio
ID                                       : 2
Format                                   : AAC
Format/Info                              : Advanced Audio Codec
Format profile                           : LC
Codec ID                                 : A_AAC-2
Duration                                 : 43 min 34 s
Channel(s)                               : 6 channels
Channel positions                        : Front: L C R, Side: L R, LFE
Sampling rate                            : 48.0 kHz
Frame rate                               : 46.875 FPS (1024 SPF)
Compression mode                         : Lossy
Delay relative to video                  : -21 ms
Default                                  : Yes
Forced                                   : No
Menu

I have the same problem, I can no longer get any videos to play on my chromecast ultra.


[Question]

Hi everyone, does this work with real-time live games? lets say soloq or flex? or a need to spectate

Hey!
It should also work to some extent when using it from outside of the spectator mode (e.g. as player), also in normal drafts and solo / flex queue games.
However, some information like summoner spells may not be available. Also you team will always show as blue team, while the enemy team will be the red team / right side.
Also we can't guarantee if and how it works. But feel free to try it out, and let us know if you run into any issues.


PR: Fix create folder in a project explorer

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

This PR fixes an error that prevented creating a new folder in project explorer. The cause of the problem was the wrong form of the path generated by the script that looked like this:
OS (C:)\\Users\\Admin\\test_project\\some_module
This form caused os.mkdir() throws an error.
Now, corrected script produces valid paths like this: C:\\Users\\Admin\\test_project\\some_module

Issue(s) Resolved

Fixes #13722
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Thanks for your help @akwasigroch! However, I saw that you removed a lot of previous code (which was added to fix another issue) and that's probably not what we want in this case.
@steff456 was in charge of adding that code, so she'll take a more careful look at your work.

Hello @akwasigroch! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/explorer/widgets/explorer.py:

Line 443:1: W293 blank line contains whitespace

I pushed changes - add requested comment and style fix, that didn't change logic in code. Now, one of the automatic tests fails, I don't know why

I pushed changes - add requested comment and style fix, that didn't change logic in code. Now, one of the automatic tests fails, I don't know why

Thanks!!! I will restart them, sometimes they fail spontaneously, so don't worry 😉

Now, one of the automatic tests fails, I don't know why

Don't worry. I fixed that in PR #13756.


Change the preset networking.hostId to use mkDefault so it can be easily changed by the user later.

I'm not sure, but I get the feeling that the lib argument can just be added and everything will work?

Yes, the lib attribute is given to all modules, as it is needed for creating properties and options.
This patch looks good to me, and I see no references to hostId which might need any additional patching.
Still I think it might be good if you can provide additional documentation to ZFS to mention that the hostId should be changed if we want to use multiple instance (as I understand).

Where would you suggest to add that extra documentation? In the hostId comment section in the appendix?

I would add it next to the ZFS documentation if we have any.

There isn't any ZFS specific documentation in the manuals. There's only some in the wikis. But they are not really up-to-date. I'm working on a tutorial to setup ZFS on NixOS actually, will be releasing it once I have it all working.

Currently we have a few manual pages which are using the new style of writing documentation, such as postgres [1] and nixos path [2].
The idea would be to add a file named zfs.xml [3] next to the module zfs.nix and to include this documentation next to luks encryption [4] of the file system.
Feel free to open a new issue for that.
[1] https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/databases/postgresql.xml
[2] https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/misc/nixos.xml (see also https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/misc/nixos.nix#L78-L79)
[3] https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/tasks/filesystems/zfs.nix
[4] https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/configuration/file-systems.xml


Certificate error during download/installation: "certificate has expired"

I’m getting an error when trying to install from the Homebrew Channel. It says “An error occurred during installation: request to https://mirrors.kodi.tv/releases/webos/org.xbmc.kodi-webos_21.0~b1.ipk failed, reason: certificate has expired

@romerotsvk
That comment was not about you. But if you really want to know anyway, the space was between webos and /org in the first line of this comment.