css paths missing

Tried an installation of Iris and got it running, but there is no CSS displayed in the browser. Static logo is working. Tried looking a bit in the source code and the CSS link path is empty when I do inspect source, so my guess is that there is something wrong in the templating where it sais ASSET_URL. Not sure how to fix it though.

Seems like an issue with webassets. How are you running Iris when you see this issue? Docker, Makefile?

I'm running it using make serve. Followed the setup in the readme file

Does the src/iris/ui/bundles directory exist? In src/iris/ui/__init__.py, the first few lines should create js and css bundles that the frontend can reference. Are you seeing any errors in creating bundles when running make?

The bundle directory is not in src/iris/ui/bundles but instead under src/iris/ui/static/bundles
Not seeing any error messages when running make serve. The following lines are printed:
[2017-07-12 13:32:22 +0000] [3274] [INFO] iris.ui Web asset root: "/home/ubuntu/iris/src/iris/ui"
[2017-07-12 13:32:22 +0000] [3274] [INFO] iris.ui Building bundle: bundles/iris.js
[2017-07-12 13:32:22 +0000] [3274] [INFO] iris.ui Building bundle: bundles/libs.css
[2017-07-12 13:32:22 +0000] [3274] [INFO] iris.ui Building bundle: bundles/iris.css
[2017-07-12 13:32:22 +0000] [3274] [INFO] iris.ui Building bundle: bundles/jquery.libs.js
[2017-07-12 13:32:22 +0000] [3274] [INFO] iris.ui Building bundle: bundles/bootstrap.libs.js
Could there be a path mismatch somewhere?

The bundles should be generated at src/iris/ui/static/bundles, see: https://github.com/linkedin/iris/blob/master/src/iris/ui/init.py#L25. Could check out the rendered html source to see what's the generated CSS link path?

@kjetilmjos could you tell us what OS are you using?

Could you also run pip freeze paste the content here?

I wonder if this could be due to restrictive file permissions and webassets silently filing to write the files.
What user are you running make serve as the same user you clone/installed the venv/etc ?

I'm runnning ubuntu 16.04 LTS on a virtualbox machine with python 2.7.12
Output of pip freeze:
adium-theme-ubuntu==0.3.4
alabaster==0.7.10
argh==0.26.2
Babel==2.4.0
backports-abc==0.5
backports.ssl-match-hostname==<IP_ADDRESS>
Beaker==1.9.0
cached-property==1.3.0
certifi==2017.4.17
chardet==3.0.4
click==6.6
configparser==3.5.0
coverage==4.4.1
cssmin==0.2.0
dnspython==1.14.0
docutils==0.13.1
enum34==1.1.6
exchangelib==1.9.3
falcon==1.1.0
falcon-cors==1.1.2
flake8==3.3.0
funcsigs==1.0.2
future==0.16.0
gevent==1.2.2
google-api-python-client==1.4.2
greenlet==0.4.12
gunicorn==19.7.1
httplib2==0.10.3
idna==2.5
imagesize==0.7.1
importlib==1.0.3
-e git+https://github.com/linkedin/iris@4b603a94d0bd23e6f857ebd8ac14c630e605dd02#egg=iris
irisclient==1.2.0
Jinja2==2.9.6
kazoo==2.3.1
livereload==2.5.1
lxml==3.8.0
Markdown==2.4.1
MarkupSafe==1.0
mccabe==0.6.1
mock==2.0.0
msgpack-python==0.4.5
ntlm-auth==1.0.5
oauth2client==1.4.12
-e git+https://github.com/linkedin/oncall.git@f18141a0f3476fa5a31e1509110ff93d982e76c7#egg=oncall
ordereddict==1.1
pathtools==0.1.2
pbr==3.1.1
phonenumbers==8.5.2
pluggy==0.4.0
port-for==0.3.1
py==1.4.34
pyasn1==0.2.3
pyasn1-modules==0.0.9
pycodestyle==2.3.1
pycrypto==2.6.1
pyflakes==1.5.0
Pygments==2.2.0
PyMySQL==0.7.11
pytest==3.1.2
pytest-cov==2.5.1
pytest-mock==1.5.0
python-ldap==2.4.40
python-mimeparse==1.6.0
pytz==2017.2
PyYAML==3.12
requests==2.12.4
requests-ntlm==1.0.0
rsa==3.4.2
singledispatch==<IP_ADDRESS>
six==1.10.0
slackclient==1.0.6
snowballstemmer==1.2.1
Sphinx==1.5.6
sphinx-autobuild==0.6.0
sphinx-rtd-theme==0.2.4
sphinxcontrib-httpdomain==1.5.0
SQLAlchemy==1.1.11
streql==3.0.2
tornado==4.5.1
tox==2.7.0
twilio==4.5.0
tzlocal==1.4
ujson==1.35
unity-lens-photos==1.0
uritemplate==3.0.0
urllib3==1.21.1
virtualenv==15.1.0
watchdog==0.8.3
webassets==0.12.1
websocket-client==0.44.0
You are using pip version 8.1.1, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
have been using the same user yes. Tried to give all permission chmod 777 to the iris folder but it did not make any difference. When I inspect the source file in chrome after login I get a header section that looks like this:

--

   Iris

Did a clean install again on Ubuntu 17.04 following the readme. The CSS issue was not there anymore. Closing this issue.


⚠ Secret Website 3 has degraded performance

In d6f3b00, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2491 ms

Resolved: Secret Website 3 performance has improved in 17ddd35.


Add adoption base job to use extracted crc

Add a base job to use the extracted crc layout in adoption CI. The
running job will still reside in rdo-jobs, and will probably port it in
the future, but this change should make it easier to consume the new
layout.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

In order to to reuse the 06-deploy-edpm playbook in adoption to deploy the control plane considering the multinode layout, this PR adds a variable to skip a few tasks from the fetch_compute_facts hook

/approve

/lgtm


Feat/add-meta-label-to-Combobox

AB#514534

Remember to bump the amplify components version to release the new changes


Update various dependencies

[x] Added an entry to CHANGELOG_VULKANO.md or CHANGELOG_VK_SYS.md if knowledge of this change could be valuable to users
[ ] Updated documentation to reflect any user-facing changes - in this repository
[ ] Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.
[x] Ran cargo fmt on the changes

This updates various dependencies to their latest versions. A few changes have also been made to the code, to comply with breaking changes or deprecations. I've taken the liberty of removing the patch semvers on all the dependencies, so that they will be more flexible. If that's not desired I can undo it.

@Rua Merged. Thank you for your help with regular maintainability of dependency system.

I've taken the liberty of removing the patch semvers on all the dependencies

I see that most changes are about examples, so this is not critical part anyway.
I'm a bit worried about the shaderc upgrade, but at least it is passing our current tests. I will do a deeper testing of the shader system later.


bpf-iter-ns: fix bpf pin path again

The host might not have bpffs mounted in some setups. See:

IG's entrypoint.sh#L50-L59
minikube's entrypoint#L76-L81

So use the bpffs mountpoint in the container mount namespace.
Symptoms before the fix:

creating socket enricher: read BPF iterator: creating temporary
directory in bpffs: mkdir /host/sys/fs/bpf/ig-iter-3218307710: no such
file or directory

Fixes: 55f58bbe8dcf ("bpf-iter-ns: fix bpf pin path"), #1719
Fixes: e91a93bb2c0a ("Read bpf iterators from host pid ns"), https://github.com/inspektor-gadget/inspektor-gadget/pull/1708#discussion_r1220175307

on hold until I can check the result of the CI in #1709.


Highlight warning messages before upgrading control plan cluster

Part of https://github.com/istio/istio/issues/32384
Without revision:
$ istioctl install
WARNING: Istio control planes installed: 1.9.2.
WARNING: An older installed version of Istio has been detected. Running this command will overwrite it.
This will install the Istio 1.10.0  profile with ["Istio core" "Istiod" "Ingress gateways"] components into the cluster. Proceed? (y/N)

With revision:
$ istioctl install -r 1-10-0
WARNING: Istio is being upgraded from 1.9.2 -> 1.10.0.
WARNING: Before upgrading, you may wish to use 'istioctl analyze' to check for IST0002 and IST0135 deprecation warnings.
This will install the Istio 1.10.0  profile with ["Istio core" "Istiod" "Ingress gateways"] components into the cluster. Proceed? (y/N)

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
969066502fc8372643770f8497e034a9e75a5e3f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ba8de9219d4a2886c094d775eae6eb4d331759ac
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@irisdingbj PTAL.

In response to a cherrypick label: new pull request created: #32535


feat: support hook function after query

This PR allows users to add hook functions after each query or statement completes.
For example, to test fault recovery, I'd like to kill nodes and wait for a while between queries. In this case I can register a custom function using these API.

Can you elaborate a bit more about how to use it? What hook will you register? 🤔

Something like this one:
https://github.com/singularity-data/risingwave/blob/eb23ae236aa512277c1f3a66da5334c7e53f23c6/src/tests/simulation/src/main.rs#L158-L166

Is on_query_complete already represented by validator? 🤔

But I'm wondering whether there are any other possible meaningful hooks, because IMHO it's uncommon to run a parameterless function after each query 🤪

Yes, it makes more sense to pass the query as a parameter. 🤣

Is on_query_complete already represented by validator?

They are executed at adjacent locations, but with different functionality. So they should not be mixed up.


simulation manuscript figures notebook.

Issue to add the plotting notebook for the manuscript simulation figures.

I've started a branch 139_simulation_manuscript_figures with the main figure.
Supplementary figures TODO:

[ ] Simulated shift heatmaps - for default and other parameter sets run through notebook
[ ] recovery of beta's across sweep (a version of this exists in the simulation notebook already)
[ ] All scatter plots of shift recovery across lasso sweep
[ ] 2 more of the panel C figures, but for the other parameter sets

@Haddox I think you have mostly finished these tasks? Can you push the notebook and PR so we can get this closed?

@jgallowa07: will do! Right now it uses an absolute path for datadir, e.g.:
simdir = 'beta_ridge_1e-7'
datadir = os.path.join('/fh/fast/matsen_e/shared/multidms/2024-02-28-simulations-output', simdir)

What is the relative path that I should use instead?

We've decided to move this code to the manuscript analysis repo. closing.


Content field from _all.yml files are now loaded.

This is 44c12a9b from #67 , fixed up to avoid test failures.
I've not attempt to built test cases yet, as I suspect a bit more code is needed.
No doubt the commit message is correct that it allows _all.yml entries to contain a Content field.
But then shouldnt individual entry .yaml files also be able to have a Content field.  It looks like the code doesnt allow for that yet.

Individual files have an implicit Content field, which is in fact the content of the file (the part of the file after the header).

Hiya @PaulPichaureau , I was referring to individual .yaml files - I suspect they are able to have a Content field, from only a quick look at the code.  If that is true, then that needs to be added, but I suspect that is a really easy fix.  Last night I wsa only wanting to split PR 67 into two chunks which could be separately reviewed, enhanced and completed.


Wip/kw/detect parser misuse

Pull Request Description
Not intended to be merged. Demonstrates cause of #11121.
Important Notes

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.

No longer needed now when #11147 has been merged.


Azure OpenAI: add capabilities up through 2023-07-01-preview

This PR includes the latest representations of several new pieces of functionality:

Chat Functions support
(Azure-only) embedded content filter result details on Chat Completions responses
DALL-E Image Generation

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.AI.OpenAI


Fix google notebooks

The cirq_google extraction broke these notebooks - switching to pip install cirq --pre fixes them.

Does this also need the other changes listed in the notebooks doc?

No, because these are all exclude already from both the notebook tests, being vendor codes. This is the reason the bugs weren't found in the first place.


Refactor the metal backend to always reuse command encoders/buffers unless a shared memory access is requested

This change aims to replace the pattern of each tensor provisioning a command buffer and encoder for each kernel operation that occurs, to a pattern where an encoder is provided to a kernel to setup it's operations.
Prior to this change, we relied on the fact that command buffers were executed sequentially to handle ordering of operations and ensuring that an output from one operation has completed before being used in a downstream operation. We now leverage Metal's resource based memory barriers to do this more effectively by ensuring we only block operations on the completion of operations on input dependencies.
What are the outcomes in terms of performance for this change? Well in summary not much... in theory I would have expected a minor gain due to the improved parallelization and lower overhead of only using a few command buffers and encoders, however in practice for the example models we do not see a change in performance.
Now although we don't see a change in performance on our models, we get a much more stable gputrace output as a result of this change. On main generating a gputrace would often cause OOM errors due to the amount of extra recorded command buffer/encoders, we now get a much more streamlined recording of the models, and the memory required to load these traces has been cut down drastically.
The major changes to note here are the following:

command buffers are lazily initialized on calls to MetalDevice::command_buffer
command encoders are lazily initialized on calls to MetalDevice::command_encoder
a new RwLock is introduced for tracking the command encoder
the device struct is modified to make access to the command encoder and buffers private to ensure users always use the helper methods for accessing those methods
the method for copying data to the cpu has been adjusted to handle closing the compute encoder and initializing the compute encoder
reduced usage of the "wait_until_completed" instruction for the copy instructions, we now only rely on this when we require synchronization of resources between CPU and GPU

Hoping this branch will address some portion of https://github.com/huggingface/candle/issues/1939

Okay, I'm happy with the PR in it's current state!
@ivarflakstad it'd be great to get your eyes on this change as well!

@LaurentMazare I did some cleanup of the areas commented above, lmk if you have any other ideas on improving docs

Just an update, I've run through most examples and they work fine, the exception is stable diffusion which outputs garbage on the photo compared to main, i'll be looking into this and will tag when I find the root cause, not immediately obvious so far.

Just an update, I've run through most examples and they work fine, the exception is stable diffusion (wuerstchen is fine though...) which outputs garbage on the photo compared to main, i'll be looking into this and will tag when I find the root cause, not immediately obvious so far.

Gave it a quick look and it indeed looks pretty weird. When enabling intermediary-images (to make it use the vae earlier) and comparing with the base version via some print statements I saw the first difference on the last layer of the vae, but I also got a run where it didn't seem to happen. So it may well be some form of race condition, not sure if it's between kernels, or when fetching the data back from the gpu, also worth pointing out that my mac gets very low on memory at that point (with 16GB) - but I would expect an actual error rather than data corruption if this is an issue.
Two other things that may be worth trying if easy: disabling the buffer reuse and use freshly allocated buffers each time, and limiting the maximum number of encoded ops in the buffer.

Any luck with this? It would be great to have to analyze performance on metal so pretty keen to have it if it still works with stable diffusion etc.

Any luck with this? It would be great to have to analyze performance on metal so pretty keen to have it if it still works with stable diffusion etc.

Unfortunately haven't had the bandwidth the last two weeks, I should have some more time coming up where I can spend some time investigating. I was going back through the implementation I had and was trying to hunt down where the change was introduced, so far nothing seemed apparent, so now I'm running through the operations that are performed in the stable diffusion model so that I can understand what's going on.

updated the branch here with main so we don't stay too far out of sync


Suggestion: better keywords and description

I was looking for a cli for Brotli and ended up finding you module when searching for a gzip-cli.
In my opinion, you should add "brotli-cli" as a keyword in the package.json and update the package.json description with the one you put on the Github repo:

gzip-cli provides CLI for compressing files by using compress algorithms such as Gzip and Brotli.

Thanks for this awesome module!

Thanks for advice, I'll add it soon.


Condition types strange works

TypeScript Version:  3.4.0-dev.20190313

Search Terms:
Code
declare function path<
    Obj extends object,
    A extends keyof Obj,
    B extends keyof Obj[A] = never,
    C extends keyof Obj[A][B] = never
>(obj: Obj, path: [A] | [A, B] | [A, B, C]): B extends never ? Obj[A] : (C extends never ? Obj[A][B] : Obj[A][B][C]);

path({a: {b: {c: 3}}}, ['a']) // = never, what?

//

declare function path<
    Obj extends object,
    A extends keyof Obj,
    B extends keyof Obj[A] = never,
    C extends keyof Obj[A][B] = never
>(obj: Obj, path: [A] | [A, B] | [A, B, C]): B extends never ? Obj : Obj;

path({a: {b: {c: 3}}}, ['a']) // also never

Expected behavior:
Actual behavior:
Playground Link:
Related Issues:

I found a solution, make all condition generics non bare
declare function path<
    Obj extends object,
    A extends keyof Obj,
    B extends keyof Obj[A] = never,
    C extends keyof Obj[A][B] = never
>(obj: Obj, path: [A] | [A, B] | [A, B, C]): [B] extends [never] ? Obj[A] : ([C] extends [never] ? Obj[A][B] : Obj[A][B][C]);

@RyanCavanaugh  it is no question, I think this is bug
declare function foo<A = never>(): A extends never ? 1 : 2;
foo(); // never - how that?

That is the correct behavior. never is a union of zero types, and conditional types distribute over unions, so any instantiation of a distributive conditional type with never produces never regardless of the true/false types.

Oh, thanks for explanation


When loading a SVG with PIXI.loader, the resulting resource has no texture

loadImages() {
    return new Promise((resolve, reject) => {
      loader
      .add('note0', 'images/renderImages/0.svg')
      .add('note1', 'images/renderImages/1.svg')
      .add('plus', 'images/plus-yellow.png')
      .on('error', reject)
      .load(resolve);
    });
  }
loadImages().then(() => {
    // has texture
    console.log(loader.resources.plus.texture);
    // undefined
    console.log(loader.resources.note0.texture);
})

note0 and note1 have no texture,but plus has texture.

Hi @starInEcust , are you able to supply a pen that displays this issue you're having against the latest dev build?

@staff0rd  I'm sorry, version 4.3.2 is working.I just updated to 4.3.0 last week.
You guys update too fast~ thank you very much!

All good!  I'll close this one if it's working on latest.


Incremental parsing doesn't work with unquoted stuff when JSMN_STRICT is not defined

Here is a small program that shows the problem:
//#define JSMN_STRICT
#include "jsmn.h"
#include <stdio.h>
#include <string.h>

#define INCREMENTAL

static char  *json = "[\n"
"   1848,\n"
"   {\n"
"      \"key\": true\n"
"   }\n"
"]";

int   main( void)
{
   jsmn_parser   p;
   jsmntok_t     t[128];
   int           r;
   int           i;
   size_t        len;

   jsmn_init( &p);

   len = strlen( json);

#ifdef INCREMENTAL
   for( i = 1; i <= len; i++)
   {
      r = jsmn_parse(&p, json, i, t, 128);
      if( r < 0)
      {
         if( r == JSMN_ERROR_PART)
            continue;
         fprintf( stderr, "Failed to parse JSON: %d\n", r);
         return 1;
      }
      break;
   }
#else
   r = jsmn_parse( &p, json, len, t, 128);
   if( r < 0)
   {
      fprintf( stderr, "Failed to parse JSON: %d\n", r);
      return 1;
   }
#endif
   for( i = 0; i < r; i++)
      printf( "%.*s\n", t[ i].end - t[ i].start, &json[ t[ i].start]);
   return( 0);
}

This will see unquoted characters be turned into individual tokens:
[
   1848,
   {
      "key": true
   }
]
1
8
4
8
{
      "key": true
   }
key
t
r
u
e

The output for non-incremental or strict is correct:
[
   1848,
   {
      "key": true
   }
]
1848
{
      "key": true
   }
key
true

Obviously it's hard for the parser to detect the expected end for unquoted numbers. The solution could be to append to the previous token if it's a primitive and there has been no intervening space.

The problem here is mostly the way non-strict mode is. There is no definition of how it works and so it's difficult to say if behaviour is expected or not. Because of that, non-strict mode will be most likely dropped in a future release. In case it's still needed, a proper definition is required. You are welcome to give your input at #159.


break the build

:star: PR built and available in a preview environment ripcitysoftware-spring-boot-http-gradle-pr-5 here

:star: PR built and available in a preview environment ripcitysoftware-spring-boot-http-gradle-pr-5 here


Avoid mutating module exports.

We should stop mutating the modules exports.
This was needed while ember-cli was using amdStrict mode (since it did not use the _interopRequireDefault babel helper), and that is being unrolled in https://github.com/ember-cli/ember-cli/pull/6827.
Suggested migration path is:

Change makeDefaultExport to use Object.defineProperty(exports, 'default,...) with a getter that issues a deprecation warning in debug builds (avoiding Object.defineProperty in prod builds).
Remove deprecation and method after major version bump to<EMAIL_ADDRESS>

 See description in https://github.com/mike-north/ember-lodash/pull/104.
We need to move forward and kill makeDefaultExport.  I am tired of wasting time debugging things in phantom due to this behavior. 😩

@rwjblue I'm happy to take this on. We (Square) are finally migrating to Ember CLI and we're trying to switch out our custom module runtime with loader.js ahead of time to discover any subtle incompatibilities. The cyclical default property is the first obvious issue.
One question:
What do you mean by "debug build"? Unless I'm missing something, there's only a prod build (dist/loader/loader.js) and an instrumented build (dist/loader/loader.instrument.js). Do we need to update build.js to output a loader.debug.js? And how would we get an Ember CLI build to use the debug build in development/test and the prod build in production?
The benchmarks load the instrumented or prod build conditionally, but I'm not seeing the instrumented build referenced elsewhere.
Thanks!

Ack: I just noticed the ember-addon code in index.js. I think I know how to proceed. But if you have any similar debug builds I could model this after, please let me know!

This library is now an ember-cli addon, we directly app.import the specific transpiled dist file that we need. We have a build script that we use to generate those pre-built assets.
Rough steps:

update babel version in use by the build script to 6
add babel-plugin-debug-macros
import debug flag and use if statements to guard the debug only code
update build script to emit debug, prod, instrumented debug, instrumented prod files
update included hook to app.import the "right" file

Happy to discuss further, feel free to ping me here or in the community slack...


RedGIFs videos are downloaded without sound

Ripme version: 2.1.8
Java version: 21.0.1
Operating system: Arch Linux, Kernel 6.6.10
Exact URL you were trying to rip when the problem occurred: All Redgif Videos
Please include any additional information about how to reproduce the problem:

Expected Behavior
Sounds in videos, if sound is available
Actual Behavior
Videos do not have sound. All muted.
Important note: All RedGif vids are embedded in subreddits and the URL is fetched while downloading a subreddit. I dont know if this matters.

Nearly every .mp4 has -silent in it. With other tools like Downloader for Reddit this problem does not occour.
But other tools are not reliable. This tool here is fast and reliable but silent videos :(


[VS Code] RPC connection closed.

Error:
RPC connection closed.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.335

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.24.1

platformName
MacOS

platformVersion
17.6.0

@mealeark Thank you for reporting this error. Would you be able to provide more information about the issue? You can get your logs by running the "Live Share: Export Logs" command in VS Code. If you could attach them to this issue or email them to<EMAIL_ADDRESS>that would help us investigate it further.

Thanks for reporting this! We’re tracking this issue via #363, so I’m going to close this as a duplicate.


Cannot add thumbnail to mp3

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2<IP_ADDRESS>
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log on debian with python 3.7
ERROR: Conversion failed!                                                                                Traceback (most recent call last):                                                                                File "/home/federico/.local/lib/python3.7/site-packages/youtube_dl/YoutubeDL.py", line 2065, in post_process              files_to_delete, info = pp.run(info)                                                                                File "/home/federico/.local/lib/python3.7/site-packages/youtube_dl/postprocessor/embedthumbnail.py", line 51, in run      self.run_ffmpeg_multiple_files([filename, thumbnail_filename], temp_filename, options)                                File "/home/federico/.local/lib/python3.7/site-packages/youtube_dl/postprocessor/ffmpeg.py", line 235, in run_ffmpeg_multiple_files                                                                                raise FFmpegPostProcessorError(msg)                                                                                youtube_dl.postprocessor.ffmpeg.FFmpegPostProcessorError: Conversion failed!
Description
Hi, I have this version /usr/lib/python3.8/site-packages (2<IP_ADDRESS>) on my termux installation and when I run this command:
youtube-dl --extract-audio --audio-format mp3 --audio-quality 0 --embed-thumbnail https://youtu.be/WNeLUngb-Xg
I get this error:
ERROR: Conversion failed!
The only thing I noticed is that if I remove --embed-thumbnail I no longer get this error, (obviously I need this option).

why?

@dstftw

This solution doesn't work

Now the command is:
youtube-dl -v --extract-audio --audio-format mp3 --audio-quality 0 --restrict-filename --output "%(title)s %(artist)s %(album)s.%(ext)s" --embed-thumbnail https://youtu.be/WNeLUngb-Xg

This appears to be a duplicate of https://github.com/ytdl-org/youtube-dl/issues/25687


How to use hooks with slack-ruby-bot

I have started making a bot for attendance where a user will be marked as present as soon as his presence_change attribute for slack RTM is active and exit when this is away. I want to implement a web hook for this event. I am currently using rails as the framework in which I have the following code
class PongBot < SlackRubyBot::Bot
  ENV['SLACK_API_TOKEN'] = Rails.application.secrets.slack_api_token
  match 'present' do |client, data, match|
    user_id = "#{data[:user]}"
    user = Employee.find_by(slack_id: user_id)
    Attendance.create(entry: DateTime.now,employee_id: user.id)
    client.say(text: "Marked<EMAIL_ADDRESS>as present at #{DateTime.now.strftime('%B %d, %Y  %I:%M:%S %p')}", channel: data.channel)
  end
end

Can some one kindly guide me as to how to implement hooks for this purpose and also how to add custom functionality for this gem. I am new to adding custom functionality to gems and how to make use of the existing libraries.
Help appreciated.
:)

There's lots of detail in https://github.com/slack-ruby/slack-ruby-bot#hooks. You need to get hold of the server instance, then do on :presence_change. Depending on where you start this instance of PongBot, you probably just want PongBot.instance.on :presence_change.
PongBot.instance.on(:presence_change, ->(client, data) { ... })

I'll close this for now, but feel free to add more questions!


Support openai compatibility mode

Right now, completions code relies on the ollama /api/generate endpoint. This means we need to use ollama, which is good but also limits applicability.
I would like to be able to use either the /v1/completions or /v1/chat/completions endpoints as they are presented by openai and things that emulate it, including ollama!, but also llama.cpp's llama-server (used internally by ollama)
For example, if you run this
$ llama-server --log-disable \
  --hf-repo Qwen/Qwen2-0.5B-Instruct-GGUF \
  --hf-file qwen2-0_5b-instruct-q5_k_m.gguf

The following will work:
Legacy (explicit prompt)
$ curl -s -X POST localhost:8080/v1/completions -H "Content-Type: application/json" -d '{
  "prompt": "<|im_start|>user\nWhich ocean contains the falkland islands?\n<|im_end|>\n<|im_start|>assistant\n"
}' | jq -r '.content'

Current (messages)
$ curl -s -X POST localhost:8080/v1/chat/completions \
-H "Content-Type: application/json" \
-d '{"model": "whatever", "messages": [{ "role": "user","content": "Which ocean contains the falkland islands?"}]}'|jq .

I'm not sure the code impact, but this could at least for me better pitch ollama as even though it uses llama.cpp under the scenes, it allows more features such as model selection.
See https://github.com/openai/openai-openapi

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

p.s. for many tools, the base URL is given inclusive of the '/v1' suffix, so that could be a way to heuristically know the caller wants to try openai vs ollama endpoint. (even on ollama which has these endpoints)

incidentally, there is portability in the chat completions, but not the legacy one. port 8080 being llama.cpp's llama-server
/v1/completions isn't consistent in response format
$ curl -s -X POST localhost:8080/v1/completions -H "Content-Type: application/json" -d '{
  "model": "qwen2:0.5b",
  "prompt": "<|im_start|>user\nWhich ocean contains the falkland islands?\n<|im_end|>\n<|im_start|>assistant\n"
}' |jq -r .content
The Falkland Islands are located in the South Atlantic Ocean.
$ curl -s -X POST localhost:11434/v1/completions -H "Content-Type: application/json" -d '{
  "model": "qwen2:0.5b",
  "prompt": "<|im_start|>user\nWhich ocean contains the falkland islands?\n<|im_end|>\n<|im_start|>assistant\n"
}' |jq -r .content
null
$ curl -s -X POST localhost:11434/v1/completions -H "Content-Type: application/json" -d '{
  "model": "qwen2:0.5b",
  "prompt": "<|im_start|>user\nWhich ocean contains the falkland islands?\n<|im_end|>\n<|im_start|>assistant\n"
}' |jq -r .choices[0].text
The Falkland Islands are in the Southern Ocean.

Trivia: In ollama you don't need to specify the ChatML template for it to work!
$ curl -s -X POST localhost:11434/v1/completions -H "Content-Type: application/json" -d '{
  "model": "qwen2:0.5b",
  "prompt": "Which ocean contains the falkland islands?"
}' |jq -r .choices[0].text
The Falklands Islands are in the Atlantic Ocean.

/v1/chat/completions is consistent
$ curl -s -X POST localhost:8080/v1/chat/completions -H "Content-Type: application/json" -d '{"model": "qwen2:0.5b", "messages": [{ "role": "user","content": "Which ocean contains the falkland islands?"}]}'|jq -r .choices[0].message.content
The South Atlantic Ocean.
$ curl -s -X POST localhost:11434/v1/chat/completions -H "Content-Type: application/json" -d '{"model": "qwen2:0.5b", "messages": [{ "role": "user","content": "Which ocean contains the falkland islands?"}]}'|jq -r .choices[0].message.content
The Falklands Islands can't be part of the Atlantic Ocean.

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

ps ollama is correct on /completions, but I asked why llama-server has a different format. In any case the /v1/chat/completions is what's typically used.

@codefromthecrypt Initially, Parakeet is only for Ollama (I don't want to recreate a LangChain):

🦜🪺 Parakeet is a GoLang library, made to simplify the development of small generative AI applications with Ollama 🦙.

But I will have a look soon - I need to estimate the impact -> if the other payload completions are compliant with the Ollama completion, why not?
https://github.com/orgs/parakeet-nest/projects/1/views/1

thanks for considering, in some ways this is just a demo thought, in other ways a discussion of where scope starts and ends. it is tricky balance also because ollama will fix the prompt for you even if you use the old completions endpoint ;)

I did some tests:

for the query, it's not too complicated
but for the response, that means too much work

I keep it at mind, but not for tomorrow

I will add a new method and new types:
func ChatWithOpenAI(url string, query llm.OpenAIQuery) (llm.OpenAIAnswer, error) {}


node-red-contrib-alasql : problem with JOIN

Hello - first of all, I really like this node!
It works fine for a simple query from a spreadsheet but I am having difficulty if I try to use JOIN.
For example, in my node, I use - SELECT * FROM XLS("c:\GB_All.xls") JOIN XLS("c:\hs_postcodes.xls") USING POSTCODE where POSTCODE LIKE  'AB%';
This gives me "Error: Unknown type of FROM clause" in the debug node (for alasql).   Is this a user problem?
Apologies in advance... I'm relatively new to Node-Red (and to ALASQL).

At the moment AlaSQL does not support joining on data read from a file.
You can solve it by reading one (or both) files into a table and using that.
crap code, but you should get the point
create table postcodes (fields...);
select * from XLS("c:\hs_postcodes") into postcodes;
SELECT * FROM XLS("c:\GB_All.xls") JOIN postcodes USING POSTCODE
where POSTCODE LIKE 'AB%';

It might be that you need to read both files before joining. Please let me know how you go.
I will close this issue, but please reopen if this does not solve your problem.


Simplify the logic of List handling in DataTypeTransformer

In DataTypeTransformer, convert List to Object[] for the data type conversion. No need to push down the List handling into PinotDataType.

Codecov Report

Merging #4651 into master will increase coverage by 13.89%.
The diff coverage is 97.43%.

@@              Coverage Diff              @@
##             master    #4651       +/-   ##
=============================================
+ Coverage     42.54%   56.43%   +13.89%
- Complexity        0       16       +16
=============================================
  Files          1075     1075
  Lines         56433    56387       -46
  Branches       8366     8355       -11
=============================================
+ Hits          24009    31822     +7813
+ Misses        30285    22045     -8240
- Partials       2139     2520      +381

Impacted Files
Coverage Δ
Complexity Δ

...not/core/data/recordtransformer/PinotDataType.java
96.11% <100%> (+84.29%)
0 <0> (ø)
:arrow_down:

...re/data/recordtransformer/DataTypeTransformer.java
85.71% <75%> (+22.81%)
0 <0> (ø)
:arrow_down:

...e/pinot/core/operator/blocks/EmptyFilterBlock.java
0% <0%> (-100%)
0% <0%> (ø)

...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java
0% <0%> (-100%)
0% <0%> (ø)

...pache/pinot/core/realtime/stream/MessageBatch.java
0% <0%> (-100%)
0% <0%> (ø)

...starter/helix/DefaultHelixStarterServerConfig.java
0% <0%> (-96.16%)
0% <0%> (ø)

...re/data/manager/config/TableDataManagerConfig.java
0% <0%> (-94.45%)
0% <0%> (ø)

...converter/stats/RealtimeSegmentStatsContainer.java
0% <0%> (-94.45%)
0% <0%> (ø)

...a/org/apache/pinot/common/metrics/ServerTimer.java
0% <0%> (-88.89%)
0% <0%> (ø)

...pinot/core/realtime/stream/StreamDataProvider.java
0% <0%> (-87.5%)
0% <0%> (ø)

... and 714 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4e69e...8ec1d60. Read the comment docs.


On hold applications should show up in a separate tab.

In the application listing page, there needs to be another tab for On-hold applications. This will open up a new page and will show only the on-hold applications. That means that the Active tab will only show in-progress applications.

Also, rename the following texts in that menu:

[x] Active to Open
[x] Rejected to Closed

This is complete. Closing.


LSP API for all servers to persist state

After looking over LSIF documentation, I'm curious if the LSP project has considered implementing similar ways to persist server state across server instances?
There are two distinct use cases I'm currently working on achieving with the dart language server (and in particular, the plugin package that allows others to tap into the language server):

allow language servers to persist state when switching contexts or closing workspaces, avoiding the need for a cold reboot on next opening
allow other IDE tools to work with the dumped state (e.g. a git hook that doesnt allow publishing commits if there are any diagnostics found on the project)

In general, I think LSIF shows a lot of promising concepts, although the recent work + abandonment of LSIF from the Sourcegraph team seems to highlight the lack of industry support for that particular protocol. Incorporating such concepts into LSP directly would have some benefit, I believe.
These are just preliminary thoughts, but I'd be willing to help think through a spec here.

We discussed such a use case and came to the conclusion to leave the format a language server to persist state to the server since it can choose a better format than LSIF.
LSIF is meant as an language independent index format where a server can pick a language specific storage format.
I will close the issue. Please ping if something is unclear.


Add example starter code

Some resources that may help:

https://cloud.google.com/appengine/docs/standard/java/building-app/
https://www.ibm.com/developerworks/java/tutorials/j-introjsp/j-introjsp.html
https://stackoverflow.com/questions/1296235/jsp-tricks-to-make-templating-easier

lgtm :)


feat: structure response using function call

Description
structure response with user pydantic format (This part of the code is split from the output parse.)
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of example)

Implemented Tasks

[ ] Subtask 1
[ ] Subtask 2
[ ] Subtask 3

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[ ] I have read the CONTRIBUTION guide. (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly. (required for a bug fix or a new feature)
[ ] I have updated the documentation accordingly.

Thanks @raywhoelse , this PR LGTM, we can create one new issue to support BaseModel as response rather than string dict .


sleep flag does not seem to work

My command
flog -f apache_common -n 1 -s 10 --loop

Logs are generated non stop, even if I use a very large number like 100, 1000.
edit: I am seeing this on Linux with the latest release, and on MacOS when I build master from source.

Delay seems to do what I need. I think I just mis interpreted the flag descriptions.


Evt handle mods

This PR includes #4 and adds the ability to read the line level from a LineEventHandle using get_value()

@fpagliughi Can you close the other PR if those changes and included here and cleanly rebase your changes onto master without the merge commits?


vi: command mode - fix j, k, - and +

Fix j, k, - and + to match readme and readline vi behavior

Thanks.


Annexes A and B: Normative/Informative should be bold

In the Annex A and B headings, "Normative" and "Informative", respectively, should be bold:

Also, if conforming with ISO, then the headings should be formatted as follows, and centered, as shown in this screen grab from ST 2095-1 (about to be published):

Some documents use uppercase first letter for "Normative" and "Informative", and others do not. It would be good to standardize how headings, captions, and table headers are written. Or we can continue to leave it to the author.

Duplicate of https://github.com/SMPTE/html-pub/issues/202, as this is auto generated.


LS100 Does not stay connected.

Describe the problem
LS100 on Arduino Pro Micro Unstable connection.  First irst time connection after the software upload works few minutes than it will disconnect and jump into Unknown USB Device (Device Descriptor Request Failed).
Tried different USB Port, different Arduino Pro Micro, different Cable results are the same.
Screenshots
If applicable, add screenshots to help explain your problem.
System (please complete the following information):

OS: Windows 10
Board: Arduino Pro Micro
Device: LS100
Version of IDE: 1.8.15
Version of CLP: 0.14.2
Version of CLP Boards: [e.g. 0.3.1]
Sketch: Scale

Code changes
Did you changed the code of the library or the sketch?
#include <CorsairLightingProtocol.h>
#include <FastLED.h>
// Hint: The channels of the LS100 are swapped in iCUE, so the first channel in iCUE is here channel 2
#define DATA_PIN_CHANNEL_1 A1
#define DATA_PIN_CHANNEL_2 A0
#define BUTTON_PIN A3
// Hint: The ATmega32U4 does not have enough memory for 135 leds on both channels
// Ultrawide is 54 top and bottom 15 left and right
// Setting up Array
CRGB ledsChannel1[22];
CRGB ledsChannel2[6];
CorsairLightingFirmware firmware = corsairLS100Firmware();
FastLEDController ledController(true);
CorsairLightingProtocolController cLP(&ledController, &firmware);
const char mySerialNumber[] PROGMEM = "202B6949A001";
CorsairLightingProtocolHID cHID(&cLP, mySerialNumber);
void setup() {
pinMode(DATA_PIN_CHANNEL_1, OUTPUT);
pinMode(DATA_PIN_CHANNEL_2, OUTPUT);
pinMode(BUTTON_PIN, INPUT_PULLUP);
CLP::disableBuildInLEDs();
byte deviceId[4] = { 0x9A, 0xDA, 0xA7, 0x8F };
firmware.setDeviceID(deviceId);
FastLED.addLeds<WS2812B, DATA_PIN_CHANNEL_1, GRB>(ledsChannel1, 22);
FastLED.addLeds<WS2812B, DATA_PIN_CHANNEL_2, GRB>(ledsChannel2, 6);
ledController.addLEDs(0, ledsChannel1, 16);
ledController.addLEDs(1, ledsChannel2, 4);
//segment front represent corsair rear represent actual led
ledController.onUpdateHook(0, {
CLP::SegmentScaling segments[] = {{5, 5}, {6, 12}, {5, 5}};
CLP::scaleSegments(&ledController, 1, segments, 3);
});
}
void loop() {
static bool lightingEnabled = true;
cHID.update();
if (buttonClicked()) {
	lightingEnabled = !lightingEnabled;
	fill_solid(ledsChannel1, 45, CRGB::Black);
	fill_solid(ledsChannel2, 144, CRGB::Black);
	FastLED.show();
}

if (lightingEnabled && ledController.updateLEDs()) {
	FastLED.show();
}

}
bool buttonClicked() {
static bool previousState = 1;
bool state = digitalRead(BUTTON_PIN);
if (previousState == 0 && state == 1) {
previousState = state;
return true;
}
previousState = state;
return false;
}

Do you use the button to turn on and off the LEDs, if not remove the code for it, else the code must be updated with the correct number of LEDs.

Yes, let me try that.
But I can  not get my device connected now.  keep saying Unknown USB Device (Device Descriptor Request Failed).

Tried it, I removed the button code.  And still the same.  the LS100 will be recognize by the USB for about 30 seconds sometime longer and then suddenly become Unrecognized Device.

I have a Lighting Node Pro - Arduino, which is running perfectly without any issues.  somehow it seem to be the ls100 only to have the issue.
things I have tried.  Uninstall and reinstall Icue: results is the same.  tried on SparkFun Micro, Tried on Pro Micro, Tried on Leonardo it is all the same.  Show Hidden USB device and delete all hidden USB driver and reconnect.  Disable USB power saving mode.  Nothing seems to be working.

Will there be any issue if I am running a custom mega32u4 board?  My Lighting Node Pro already running in it and it is 100% okay.  It is LS100 firmware which I am having issue with.

My VID is 0000 and PID is 0002

can you send the current code, where you removed the button code.

But I can not get my device connected now. keep saying Unknown USB Device (Device Descriptor Request Failed).

https://github.com/Legion2/CorsairLightingProtocol/wiki/Troubleshooting

#include <CorsairLightingProtocol.h>
#include <FastLED.h>
#define DATA_PIN_CHANNEL_1 A1 //Channel1
#define DATA_PIN_CHANNEL_2 A0 //Channel0
CRGB ledsChannel1[22];
CRGB ledsChannel2[22];
CorsairLightingFirmware firmware = corsairLS100Firmware();
FastLEDController ledController(true);
CorsairLightingProtocolController cLP(&ledController, &firmware);
const char mySerialNumber[] PROGMEM = "202B00000002";
CorsairLightingProtocolHID cHID(&cLP, mySerialNumber);
void setup() {
byte deviceId[4] = { 0x90, 0xDA, 0xA7, 0x90 };
firmware.setDeviceID(deviceId);
CLP::disableBuildInLEDs();
FastLED.addLeds<WS2812B, DATA_PIN_CHANNEL_1, GRB>(ledsChannel1, 22);
FastLED.addLeds<WS2812B, DATA_PIN_CHANNEL_2, GRB>(ledsChannel2, 22);
ledController.addLEDs(0, ledsChannel1, 16);
ledController.addLEDs(1, ledsChannel2, 16);
pinMode(DATA_PIN_CHANNEL_1, OUTPUT);
pinMode(DATA_PIN_CHANNEL_2, OUTPUT);
//segment front represent corsair rear represent actual led
ledController.onUpdateHook(0, {
CLP::SegmentScaling segments[] = {{5, 5}, {6, 12}, {5, 5}};
CLP::scaleSegments(&ledController, 0, segments, 3);
});
}
void loop() {
cHID.update();
if (ledController.updateLEDs()) {
	FastLED.show();
}

}

Attached is my schematic as well.

Which Power supply do you use?

5V-5a to power the led and USB power to power the atmega32U4-MU.  In some
schematic I saw a 1M resistor between the Crystal do I need that?
On Fri, 24 Sep 2021 at 00:59, Leon Kiefer @.***> wrote:

Which Power supply do you use?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Legion2/CorsairLightingProtocol/issues/248#issuecomment-925992616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG37QOLCSZB7L3SHJ45SGSLUDNMIZANCNFSM5EMMSLNA
.

--
Cheers,
York Chan
Mobile/Whatsapp  +852 98662380
@.*** @.***>
http://www.petpalace.com.hk

can you reupload the latest sketch and make sure that it is successfully uploaded, in Arduino IDE it should not display an error if successfully uploaded.

Hello Legion2,
Thank you for your help.  I think I probably found the issue to be the USB port connector.  Seems to be a bad quality Female Port which can not keep the connection stable or my trace maybe too think that cause the connection D+/D- very unstable.

Hello Legion2,
Thank you for your help.  I think I probably found the issue to be the USB port connector.  Seems to be a bad quality Female Port which can not keep the connection stable or my trace maybe too think that cause the connection D+/D- very unstable.


Frontend Auth Form

Hello!
I've tried making a simple register/login form with FastAPI but I failed. My idea was to send a simple json object containing username and password using pythons request.  I get the email and password from a simple HTML form and then post it to "auth/register".
<form action="/auth/register-user" enctype="multipart/form-data"
          method="post">
        Email: <input name="email" type="text" >
        Password: <input name="password" type="text" >
        <input type="submit">
 </form>

@app.post("/auth/register-user")
def register_user(email: str = Form(...), password: str = Form(...)):
    r = requests.post("http://localhost:5000/auth/register",
                      data={'email': email, 'password': password})

Could somebody please tell me what kind of data/format I should send to the "auth/register"?

Hi there!
Similar question in #188:

FastAPI is intended to be used as a REST API, not a traditional web framework like Django that generates HTML response.
The correct way to do this is to write a bit of JavaScript in your page to handle the form submission, handle the response and make the redirection.

So you shouldn't write this in Python, but rather in JavaScript along with your HTML. You should read about AJAX requests : https://www.w3schools.com/xml/ajax_intro.asp

@frankie567, there is really no way register/login/etc. w/o AJAX?..
My situation: we have an SPA front-end for regular users and an HTML-based responses for those who don't want to use JS (say, for security-anonymity reasons). For simplicity, I use cookie-based JWT from FastAPI-Users for now.

Nevermind, it works via an async proxy route. For those, who'll be looking for the answer:
    <form method="post" id="auth_form">
        E-mail:

        <input type="text" id="email" name="email">

        Password:

        <input type="password" id="password" name="password">

        {# Login button... #}
        <input class="submit bg-info text-light" type="submit" formaction="{{ url_for('register_proxy_proxy') }}" value="Login">

        {# Register button... #}
        <input class="submit" type="submit" formaction="{{ url_for('register_proxy') }}" value="Sign Up">

        {# Forgor password button... #}

        <input class="submit" type="submit" formaction="{{ url_for('forgot_password_proxy') }}" value="Remind password">
    </form>

@app.post('/register_proxy')
async def register_proxy(email: Annotated[str, Form()], password: Annotated[str, Form()]) -> dict[str, str]:
    """Registration proxy for HTML sign-up form..."""

    import httpx

    async with httpx.AsyncClient() as client:
        response = await client.post(url='http://localhost:8000/auth/register', json={'email': email, 'password': password})
    return {'response': response.text}

Keep in mind that -> Response gives me ValueError: [TypeError("'TimerHandle' object is not iterable"), TypeError('vars() argument must have __dict__ attribute')], however, the user is still created in the database.

@UnoYakshi just checking did you open-source your code ?

@UnoYakshi just checking did you open-source your code ?

What code exactly are we talking about?
All the code for the project I was working on that time is here.


[BEAM-8416] Add locking to zipfile reading as well as zipfile writing.

I was not able to reproduce, but looking at the guarantees (or lack thereof) on threadsafety I think this should fix the issue.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Python ProstCommit

Run Python PostCommit


KARAF-4444 - Make a new command service:get

What is the purpose of this command?
It looks like the command simply lists services that match a name which is the same that service:list does. There is also already a command service:get to retrieve a service.

Indeed Christian.
The original problem was that when trying to know how to use service:get with "service:get --help" it threw an error.
IMHO , scr:list should print every service and not a specific one. That's what the user may think also, that's why I created a service:get (which already existed but now it's a nice command..)

I think service:list works fine. By default it prints all serivices and you can also set a filter. It does not make sense to replicate this in service:get. The purpose of service:get is to get the service object which then allows to call the service on the console. We need to improve the help and some examples.

Why a new service:get command ? It already exists: it's an alias in etc/shell.init.script:
service:get = { $.context getService ($.context getServiceReference $args) };
IMHO, the purpose of the Jira is to fix the Console Impl in case of alias (for instance, the help could be "This command is an alias to ...").

I'm sorry guys.. I understood it wrong.
I will provide another PR with the correct changes.

There's no problem ! We are here to help you and review !


passing props with redirect component

Think you found a bug?
Have a question?
Hello I couldn't find any documentation about passing props with redirect like this is react-router
<Redirect to={{
            pathname: '/order',
            state: { id: '123' }
        }}
/>

Typically, with Redirect, you can think of it as popping a view of the stack, in which there would be no state to pass.  If wanting to redirect but bring state, then navigate would probably suit you better.
Good insight though, in that the docs should point out these differences 🥇

whoops, reopening so the docs can reflect the convo.

Thank you for this. This will be helpful. Appreciate the response. :)

Seems like it's possible to do this :
<Redirect to="/order" state={{ id: '123' }} />
Under the hood, the state is passed to navigate.
https://github.com/reach/router/blob/28a79e7fc3a3487cb3304210dc3501efb8a50eba/src/index.js#L465
the state can then be fetched in location.state.
Is it an intended feature ?


chore: Add graphites ci optimizer

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#44
#43  👈
#42
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Atternatt and the rest of your teammates on  Graphite

Merge activity

Aug 21, 11:27 AM EDT: @Atternatt started a stack merge that includes this pull request via Graphite.


chore(ci): fix failing release

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


iwatchonline and cloudflare

Hi Mr. Know,
Just providing some info. If you try to go to https://www.iwatchonline.lol, with javascript turned off in the browser, the page displayed says turn javascript on and DDoS protection provided by CloudFlare.
Not sure if it's needed, but I entered "from resources.lib.libraries import cloudflare" into source iwatchonline_mv_tv.py, but it still didn't help in getting any links from source iwatchonline. This is with the latest release 2<IP_ADDRESS>.
Just passing on my experiment and observations.
Have a good day, everyone.
Regards,
Bob

fixed


Storing region in shared credentials file overwrites profile settings in config.

Describe the bug
I have an account, which I want to use in us-west-2 region. After authentication with okta-awscli, us-east-1 region gets written to .aws/credentials. This overwrites my settings in .aws/config, which now I have to overwrite in other way.
Simply removing the 'region' line in .aws/credentials solves the problem for me.
To Reproduce
Steps to reproduce the behavior:

authenticate with profile name specified
launch aws-shell or aws-cli
check that region might be different for what you set in .aws/config

Expected behavior
I can store my preferred region for profile in .aws/config and it will work with aws-shell after authentication.
Environment (please complete the following information):

OS: Debian
okta-cli version 0.2.5

Might be related to #19 in broader perspective.

Fixed in v0.3.1


Stop requiring angular in your code

Since adding your library to my site I get this warning from angular:
'WARNING: Tried to load angular more than once.'
This occurs because you require angular without checking if it is already exists.

It looks more like an issue with your build system than a problem with this plugin, are you using browserify or webpack? And npm 2 or 3? Angular is only listed as a peer dependency which means this module should use the version of angular you have set in your package.json as a dependency.

On 30 Jan 2016, at 03:20, David limkys<EMAIL_ADDRESS>wrote:
Since adding your library to my site I get this warning from angular:
'WARNING: Tried to load angular more than once'
This occurs because you require angular without checking if it is already exists
—
Reply to this email directly or view it on GitHub.

Browserify + NPM 3.5
I do believe it does uses the angular version I use, but non the less it tries to require it although it already been initiated.
I use outer angular plugins none have this problem.

Hmm it should resolve the angular version from the root of node_modules. Can you tell me the output of
npm ls angular
From the root of your project

On 30 Jan 2016, at 13:04, David limkys<EMAIL_ADDRESS>wrote:
Browserify + NPM 3.5
I do believe it does uses the angular version I use, but non the less it tries to require it although it already been initiated.
I use outer angular plugins none have this problem.
—
Reply to this email directly or view it on GitHub.

<EMAIL_ADDRESS>C:\david\work\WIT\public
└──<EMAIL_ADDRESS>

I think you just need to enable deduping with browserify, this should do the trick:
https://www.npmjs.com/package/browserify-resolutions

On 30 Jan 2016, at 13:21, David limkys<EMAIL_ADDRESS>wrote:
<EMAIL_ADDRESS>C:\david\work\WIT\public
└──<EMAIL_ADDRESS>—
Reply to this email directly or view it on GitHub.

Closing this as it can be solved with the plugin I mentioned previously.


Move @PicocliScript and Groovy dependenies to separate artifact

Is it possible to extract/move:
picocli/groovy/
picocli/groovy/PicocliBaseScript.class
picocli/groovy/PicocliScript.class
picocli/groovy/PicocliScriptASTTransformation.class

to a separate JAR artifact, ideally I don't want to pull in Groovy into my app since I don't need it, nor does picocli itself.

In this instance I was experimenting with trying to generate a jlink image under JDK11ea, and using a maven plugin to generate a modular version of the jar, which picks up the classes inside the jar.
All good and not a major issue - I suspect we'll find a lot of library projects may start hitting similar issues ( unfortunately, I just discovered Automatic Modules can't be used with jlink ).

@talios, FYI it is possible to use jlink with non-modular applications. Simon Ritter wrote this excellent tutorial: https://medium.com/azulsystems/using-jlink-to-build-java-runtimes-for-non-modular-applications-9568c5e70ef4

Thinking to address this in picocli 4.0 as detailed here: https://github.com/remkop/picocli/issues/495#issuecomment-437568224

FYI: #495 has just landed in master and will be included in the upcoming 4.0.0-alpha-2 release.
Closing this ticket. Feedback very welcome!


Fix monorepo node externals resolution

Fix #1216
Description
This replaces webpack-node-externals with a resolve-from based externals config in webpack.config.prod.js that fixes the monorepo support in react-static.
Changes/Tasks

Rewrite externals Webpack option for node stage in webpack.config.prod.js
Remove webpack-node-externals package

Motivation and Context
webpack-node-externals is not properly maintained and doesn't take monorepos and projects with multiple node_modules folders into account. Realistically we'd want to be as close to the node resolution algorithm as possible. Hence this PR utilises resolve-from.
This change is similar to the logic that is present in next.js for the same purpose: https://github.com/Timer/next.js/blob/31a47b4bffa45fc9d5f2bd464660bb68f6037229/packages/next/build/webpack-config.ts#L490-L548
Types of changes

[ ] Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I have updated the documentation accordingly
[x] I have updated the CHANGELOG with a summary of my changes
[ ] My changes have tests around them

@SleeplessByte Realistically it’s hard to test in-repo unless you have examples folders set up and are willing to drop in a full monorepo structure into one of these folders? I’d have to defer for a decision to you on that.
I’ve noticed however that you don’t change the Webpack config very often. So maybe a local test would suffice?
To get to what this actually fixes, suppose you have a repository that is set up with Lerna or Yarn Workspaces with a root package.json and a package with packages/site/package.json. The site in this example would contain and build a react-static site.
Typically and by default all dependencies would be hoisted to the root node_modules folder including react and react-dom. Without this fix the externals config with webpack-node-externals would cause all packages in the local node_modules folder not to be bundled by telling Webpack to require them using the commonjs prefix. In a monorepo scenario with hoisting most dependencies will however be in the root node_modules folder.
This causes dependencies to be accidentally bundled in the Node bundle. This isn’t desired and the first sign that this has happened is that we’ll see duplicate React errors due to the React Dispatcher being duplicated.
After this fix all resolvable packages in all node_modules folders won’t be bundled which fixes this issue.
Hope that clarifies this PR 👍 Let me know if you’d like me to set up an example repo or what you’d like to do about testing

A local test suffices 🗡 . We absolutely don't need this as test inside this repo 👍
I'll try out your steps. Thank you very much for the explanation. It's very clear :)

I also ran into this same issue #1216 and #1021 using Lerna & Yarn Workspaces and I can confirm that after applying this patch everything worked as expected!
Just out of curiosity, why was the exception for /react-static(\\|\/)lib(\\|\/)browser/, /webpack-flush-chunks/ removed?

Works like a charm for my lerna/npm monorepo needs!

Hi,
Do you have an ETA on merging this PR?
I'm using a monorepo and I can't make it work.
If I understand correctly, #1493 is related to this PR?

@ar7casper Various unresolved comments on this PR; so it can't be merged at the moment.

This PR has been open for a long time. Is there a chance these last comments can get resolved so it can be merged?

@DBosley only if someone resolves the open comments in this PR.


add a native plugin example

alternatives:

https://github.com/boostorg/dll

Make it work as an example of ss-cpp


Documentation cleanup

The docs have grown pretty fast, and gotten a bit messy; double-checking everything for accuracy, as well as shortening and re-writing for style, grammar, and clarity is needed.
It's primarily AutoPairs.txt in the doc directory that needs to be updated; it contains a lot of old text that I haven't focused on when doing other stuff. The things that need to be done are;

[ ] Spell-check and verify the readability of both the documentation files
[ ] Ensure technical accuracy in AutoPairs.txt, wrt. updates making certain parts obsolete
[ ] Changing the style in AutoPairs.txt, if necessary to improve readability
[ ] Making stuff easier to find in AutoPairs.txt

Also note that this is a lot for a single PR, so anything fixing or working on parts of this are fine; there's a lot of text to go through, and a lot of stuff to improve, so partial pull pull requests are obviously fine.

hey could i do this

Sure!

The docs have grown pretty fast, and gotten a bit messy; double-checking everything for accuracy, as well as shortening and re-writing for style, grammar, and clarity is needed.
It's primarily AutoPairs.txt in the doc directory that needs to be updated; it contains a lot of old text that I haven't focused on when doing other stuff. The things that need to be done are;

[ ]  Spell-check and verify the readability of both the documentation files
[ ]  Ensure technical accuracy in AutoPairs.txt, wrt. updates making certain parts obsolete
[ ]  Changing the style in AutoPairs.txt, if necessary to improve readability
[ ]  Making stuff easier to find in AutoPairs.txt

Also note that this is a lot for a single PR, so anything fixing or working on parts of this are fine; there's a lot of text to go through, and a lot of stuff to improve, so partial pull pull requests are obviously fine.

hey a small thing insted of using .txt we can use .md

Using txt is a Vim convention; https://vimhelp.org/helphelp.txt.html#help-writing
The files in question are also accessible from inside Vim, which is why they're formatted the way they are. The link also includes the format details.
Switching to markdown would require a lot more work, because we'd realistically need to make an entire standard for tags and whatnot, and somehow make it work when distributed, and I'd rather not reinvent the wheel with this particular problem. See: https://www.reddit.com/r/vim/comments/dxmpa6/writing_tagged_documentation_in_vim/


.EXE Not working

Hello!
I downloaded the release, unzipped the file, and launched gif.exe, but it doesn't seem to do anything when I run it. I downloaded gif.zip from releases.
Thanks!

Do you receive any errors when you are loading up the .exe? I loaded the .exe file seen in "gif-v.1.2.zip" and I can confirm that it is working as intended on Windows 10
It downloads the ID's from GitHub then doing a scan shows if there is/isn't any infected addons

I believe I might’ve compiled it in Debug mode and uploaded it, instead of release mode. I will fix that as soon as I’m able to!

@HonestResolv3, nothing even pops up, it's like double-clicking on blank space. The zip file had all the files in it in a folder called net6.0-windows.
and @LGuerrero13, please tell me when this is fixed.
Thank you both!

@TheTinkerer256  I have approved the PR and updated the release download to make sure it's in release mode. Please let me know if it still doesn't work.

Nope, still nothing, same result as before

Make sure you have Microsoft .NET 6.0 installed. https://dotnet.microsoft.com/en-us/download/dotnet/6.0/runtime?cid=getdotnetcore
(click either "Download x64" or "Download x86" depending on your OS, under "Run desktop apps")
If that still isn't pointing you in the right direction, run the app from a command window. Any exception should get printed to the command window and will remain open for you to examine

That worked, thanks for your help!


Toasts are not working

🐛 Bug report
Following the Vuejs SFC example, I cannot get the toasts to work
💥 Steps to reproduce
Click "Make a toast"
Nothing updates in the Vuejs state
💻 Link to reproduction
CodeSandbox reproduction: https://codesandbox.io/s/toast-example-l8jch2?file=/src/components/Toast.vue
🧐 Expected behavior
Vuejs state to update, and toast to show up in the list
🌍 System information

Software
Version(s)

Zag Version
0.12.0

Browser
Chrome

Operating System
Fedora

📝 Additional information

Hi @dasmikko,
Here's a working solution: https://codesandbox.io/s/zag-vue-toast-sfc-w9ntk3?file=/src/App.vue

Hi! Thanks for the link, but It says the sandbox doesn't exist?

Hey @dasmikko. Sorry, I forget to make the Sandbox public.
https://codesandbox.io/s/zag-vue-toast-sfc-w9ntk3?file=/src/App.vue


Run Acton with own predictors

Not enough time for me to do this before next week. That said, it’d certainly be worth it to extend Acton with regression predictors and recommenders.


feat(cmd/lint): added flag to lint dependent charts

feat(cmd/lint): added flag to lint dependent charts. Supplying the flag --with-subcharts will also lint the dependent charts in /charts
Closes #5767.
Signed-off-by: Nick Lee<EMAIL_ADDRESS>

Unless we're being keen on the flag name, I think this PR should address all points brought up in #4910.

@hickeyma if you're comfortable with the change, feel free to merge this one in. I'm okay with this PR but I want to make sure your points are addressed and you're comfortable with it too.


Add cli option to group reporter output. Closes #38

Added the option to group the report output by directory, filetype, or pass/fail using -groupby. The option can use one or more commands to organize the report output.

@kehoecj Seems my indentation is off in a few places. I will fix those along with @jd4235 suggestions once the review is completed.

I'll re-review once comments are incorporated

@kehoecj Hopefully it is good to go now. Seems I need to make some changes to my workspace config for Go formatting 😅

@kehoecj The changes requested are going to take me a bit. It may be worthwhile to close out this PR and I can resubmit for review once I am done. Thoughts?

@kehoecj The changes requested are going to take me a bit. It may be worthwhile to close out this PR and I can resubmit for review once I am done. Thoughts?

Whatever is easier for you! I'm happy to leave it open while you work through the changes but if you'd rather close it and open a new one when finished that works too.

@kehoecj We can leave it open. It should be ready for another review now.
I wasn't able to duplicate the index error on my end so let me know if you run into again. If so, I will continue testing.

@jd4235 I created the utility function and cleaned up the JSON reporter. Let me know if that is closer to what is wanted.

@jcsmurph Looks like we have some merge conflicts - can you take care of them and we'll do a final review. We'd like to get all your good work merged in

Should be good to go now. It was a quick change to the standard out testing file.

Looks like the new JUnit reporter needs to implement the groupBy print functions (either working or returning nil) or I could remove the groupBy print functions from the interface.
@kehoecj What do you think?

Looks like the new JUnit reporter needs to implement the groupBy print functions (either working or returning nil) or I could remove the groupBy print functions from the interface.
@kehoecj What do you think?

@jcsmurph Good question - I think Junit should be excluded from the groupby functionality. I don't see a lot of benefit to adding it since JUnit is really for processing. JUnit also has a pretty strict structure so I'm not even sure how feasible grouping it would be @jd4235 WDTY?

Looks like the new JUnit reporter needs to implement the groupBy print functions (either working or returning nil) or I could remove the groupBy print functions from the interface.
@kehoecj What do you think?

@jcsmurph Good question - I think Junit should be excluded from the groupby functionality. I don't see a lot of benefit to adding it since JUnit is really for processing. JUnit also has a pretty strict structure so I'm not even sure how feasible grouping it would be @jd4235 WDTY?

I agree that JUnit should be excluded from the grouping.

I agree that JUnit should be excluded from the grouping.

Sounds good. The options I am seeing are:

Remove the groupBy functions from the interface. Refactor the functions.
Implement the groupBy functions for JUnit but return nil/an error saying it is not supported.
A third option I have not considered.

I should probably add a validation check for the flags if a user passes JUnit for the reporter, they cannot add a groupBy. That way the user gets the error immediately rather than after the validator has ran.

I agree that JUnit should be excluded from the grouping.

Sounds good. The options I am seeing are:

Remove the groupBy functions from the interface. Refactor the functions.
Implement the groupBy functions for JUnit but return nil/an error saying it is not supported.
A third option I have not considered.

I should probably add a validation check for the flags if a user passes JUnit for the reporter, they cannot add a groupBy. That way the user gets the error immediately rather than after the validator has ran.

Option 1 seems the cleanest to me. I agree with the validation check if a user passes groupby and junit

Changes have been made and testing looks good on my end.
I am noticing now with the support for case mixed filetypes, they get sorted differently depending on the case. E.g. Csv is sorted differently than csv, CsV, etc. Did you want me to take a look into changing that as part of this PR?

I really need to figure out what is wrong with my local config and gofmt...
Sorry, you can try the workflow again. It should validate this time.

@jcsmurph I did a final functional test today running through several scenarios. There is currently an issue with --groupby directory functionality. For example running .\validator.exe -groupby directory .\test displays this output:
PS C:\Users\se456c\src\github.com\pr\grouping\config-file-validator> .\validator.exe -groupby directory .\test
/
    ✓ test\fixtures\exclude-file-types\excluded.json
    ✓ test\fixtures\exclude-file-types\not-excluded.toml
    ✓ test\fixtures\good.csv
    ✓ test\fixtures\good.hcl

This was definitely working before so it may be something that was introduced with one of the latest sets of changes. All my other functional tests passed so this should be the last issue before I'm ready to merge

@kehoecj If I understand correctly, it is grouping the test\fixtures\ and test\fixtures\exclude-file-types\ directories together?

It's grouping everything under /. For example even running this commend PS C:\Users\se456c\src\github.com\pr\grouping\config-file-validator> .\validator.exe -groupby directory .\test C:\ProgramData\ / groups all the output from two totally separate places under /

Got it. Seems to be Windows specific as I am not having the issue with my Linux setup but am with Windows. I will take a look.

@kehoecj I made an update and it is working on my Windows machine now. Let me know if you see any other issues.

@kehoecj I made an update and it is working on my Windows machine now. Let me know if you see any other issues.

LGTM! Thanks for the quick turnaround

@kehoecj I added 2 tests for the directory GroupBy function to cover Windows file paths and others. That should hopefully get the test coverage back in the threshold.

@kehoecj I added 2 tests for the directory GroupBy function to cover Windows file paths and others. That should hopefully get the test coverage back in the threshold.

That did it - thanks!

Merged - thank you for the great work on this PR @jcsmurph !

Awesome! I will keep an eye out for other issues I may want to tackle.


Assertion error on ac1111

so i did the instalation with only adding the extension on ac1111 and i been getting this error :

is there any way to fix it ? or am i missing something ?

the same error


Reply to Messages with Images

What JS Function do I need to reply to messages with images. Or Is this already an In-Built Function?

Any Updates on this?

Did u tried?
Did it fail?
Nobody is gonna tell you anything satisfactory if you don't supply enough info about it.


[REEF-468] DataLoader should support user-defined number of compute and data requests

This commit allows to request a user-defined number of compute and data evaluators to the DataLoader.
Each evaluator can be requested to run in particular locations, using the rack information.
As there are some clients of the DataLoadingRequestBuilder, we maintain its previous functionality, though we marked several fields as deprecated.
There is still pending to implement the different strategies on how to assign partitions to the different evaluators. For now, we use the previous implementation (tries to match the host, if it cannot, assigns the partitions randomly).
Also needed to update EvaluatorRequest.Builder to make "cloning" easier.
JIRA:
REEF-468
Pull Request:
This closes

@markusweimer. Ready to review. Still missing the assignment of specific partitions to certain evaluators. Will do in other JIRA.

I'll do a pass.

@nachocano I've done a surface level pass.

@markusweimer done the changes and added a few comments.
tested the dataLoading example and bgd and still work fine.

@nachocano Looks good to me. I will test and merge.

@markusweimer  Thanks!

There are two checkstyle violations:
[ERROR] src\main\java\org\apache\reef\io\data\loading\api\DataLoadingRequestBuilder.java[295] (javadoc) JavadocStyle: First sentence should end with a period.
[ERROR] src\main\java\org\apache\reef\io\data\loading\api\DataLoadingRequestBuilder.java[302] (javadoc) JavadocStyle: First sentence should end with a period.

@markusweimer done, sorry about that

I'm testing.


Admin Center Template Support

Added support for templates created in the Admin Center.
Templates were supported before but not in an easy way. This update has greatly simplified how this will work.
The updates I have made are as follows:

Removed BaseTemplateType and Team Visibility fields from Teams Templates list.
Renamed the following fields - BaseTemplateId to TemplateId, FirstPartyTemplate to AdminCenterTemplate in Teams Templates and Teams Requests list.
Updated the Power App to reflect the above changes.
Updated the Logic App so that when the template list item has a value of AdminCenterTemplate = true, it will now provision a team from the group using the Beta Graph API (https://docs.microsoft.com/en-us/graph/api/team-post?view=graph-rest-1.0&tabs=http - Example 4). The ability to provision custom templates defined in the Admin Center is not available in the v1.0 Graph API yet. The endpoint is available but it does not work for custom templates - confirmed with Graph PMs.
Existing functionality to clone teams remains and the TeamId field in the Teams Templates list can still be used.
The updates above DO NOT affect the clone functionality in that this still uses the 1.0 endpoints if organisations prefer to use these.
Update to the deployment script to fix an issue when the machine running the script on has not launched IE/Edge for the first time.

This makes templating much easier as admins can simply define a Template title, description, id from the admin center and whether or not it is an admin center template.
Limitations:

Only templates created in EN-US locale are supported - Graph API limitation at the time of writing.
Using the beta APIs as pointed out above.

@abbodh this has been tested at length, please approve.


fix %sqlcmd tables/columns in MySQL

Describe your changes
Issue number
Closes #206
Checklist before requesting a review

[ ] Performed a self-review of my code
[ ] Formatted my code with pkgmt format
[ ] Added tests (when necessary).
[ ] Added documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--370.org.readthedocs.build/en/370/

I would like to review it.


Fix issue with URI not being able to be parsed properly

Aiven now returns ..aivencloud.com: as the URI. According to this documentation, https://golang.org/pkg/net/url/#URL, only scheme and opaque will be filled in this scenario.

Thanks for this @FranOis !


ThemeData Color rendering discrepancy

Steps to reproduce
https://docs.flutter.dev/cookbook/design/themes

Go to the page and run "Try an interactive example".
Set the button color using "color: Color(0xff00acaf)".
Use the color picker.
See the difference: 0xff00acaf ==> #4DA9AD.

Expected results
The color difference prevents a strict rendering of the company's color theme.
Actual results
The colors are not respected.
Code sample
       Center(
        child: Container(
          padding: const EdgeInsets.symmetric(
            horizontal: 12,
            vertical: 12,
          ),
          color: Color(0xff00acaf),
          child: Text(
            'Text with a background color',
            style: Theme.of(context).textTheme.bodyMedium!.copyWith(
                  color: Theme.of(context).colorScheme.onPrimary,
                ),
          ),
        ),
      ),

Screenshots or Video

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Looks like your display/color picker uses Display P3 color space and your input colour is in sRGB. But it is the same colour. Set your monitor to sRGB, and it will show the same values, it does for me.

Thank you for the response,
Here is additional information, this is on the same screen. I am getting different results for the same color code and we can see that the colors are actually different.

Your colour picker is showing the P3 color space color.  When you enter it as a sRGB colorspace color, the color will be different, yes. You should use a color picker which shows you the sRGB color if you want to render that colour with flutter, which uses sRGB color space. It will make your life a lot easier than being confused and having to convert colour spaces.

If you want to render the green shown on the left, use the sRGB color #41E100
Flutter always takes Color() as sRGB. There is a ticket open to allow users to specify colors in P3 space, but it hasn't been done yet. https://github.com/flutter/flutter/issues/127855

It was the color picker that wasn't in the right color space. I found another one. It's the first time I have to adhere to an exact color code. Thank you for the information, it was very helpful!

close


How can I track token counts when I use @llm_prompt?

@ju-bezdek would you have any suggestions for this one?

you can use any LangChain solution or (PromptWatch)[www.promptwatch.io] which is free and you just get api key to track it... (you can also reply any of the prompts, try to experiment, without needing to rerun any of the code here)


Meta keys can be incorrect when there is an empty string property

Recently tracked down this weird edge case where there is a nested object with a key that is an empty string and the value is [{}] resulting in meta keys being incorrect after the serialization encounters it. I've added this test case that recreates it.
The offending data here:
const edgeCase = {
 nested: {
    '': [{}],
     bigint: BigInt(1),
  },
}

The expected value is
'{"nested":{"":[{}],"bigint":"1"},"__meta__":{"nested.bigint":"bigint"}}'

But the actual is:
'{"nested":{"":[{}],"bigint":"1"},"__meta__":{"bigint":"bigint"}}'

My guess is that there is somewhere doing a conditional on the "" value which will return false.

So you beat me at debugging, came here to make the exact same issue :D

Thanks for the bug report. I never considered empty keys before.


fix: Add AllowDynamicProperties annotation in Service class

Resolves https://github.com/googleapis/google-api-php-client-services/issues/4106

Just to be clear before we merge this - where is it that dynamic properties are being used for Service classes? Can you identify where it's happening (so we can also confirm that this is the right action to take)?

Hmm.. I was thinking about the ShoppingContent or similar classes extending the Service class. But, I just looked at them and the classes I should be concentrating are classes which extends Model class. Further, Model class already has the required annotation. Seems like this PR will not help in our scenario! My bad!


Duplicate icons/empty space when combined with Refined GitHub's quick-file-edit

Is there an existing issue for this?

[X] I have searched the existing issues.

Are you on the latest version of the extension?

[ ] I am on the latest version of the extension. (0.12.0, see comment below)

What browser are you using?
Firefox 133
What issue are you experiencing?
I have the Refined GitHub extension enabled (version 24.12.10), and when adding this icon pack on top, I sometimes get an extra padding between the icon and the file name:
https://github.com/user-attachments/assets/471fbb28-368b-4565-9d3e-08b6ea267b01
The behaviour is not always consistent, as you can see (going back and forth).
The issue is related to the quick-file-edit feature in RGH, which adds an inline "Edit" pen icon/button. Disabling quick-file-edit solves the problem.
If that's of any help, here are the innerHtml of the div.react-directory-filename-column element of this repo's top level package.json file, in various configurations (click to expand):
✅ Stock GitHub UI
<svg
  aria-hidden="true"
  focusable="false"
  class="color-fg-muted"
  viewBox="0 0 16 16"
  width="16"
  height="16"
  fill="currentColor"
  style="
    display: inline-block;
    user-select: none;
    vertical-align: text-bottom;
    overflow: visible;
  "
>
  <path
    d="M2 1.75C2 .784 2.784 0 3.75 0h6.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v9.586A1.75 1.75 0 0 1 13.25 16h-9.5A1.75 1.75 0 0 1 2 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .<IP_ADDRESS>.25h9.5a.25.25 0 0 0 .25-.25V6h-2.75A1.75 1.75 0 0 1 9 4.25V1.5Zm6.75.062V4.25c0 .<IP_ADDRESS>.25h2.688l-.011-.013-2.914-2.914-.013-.011Z"
  />
</svg>

        package.json

✅ rgh alone

  <svg
    aria-hidden="true"
    focusable="false"
    class="color-fg-muted rgh-seen-2924925456"
    viewBox="0 0 16 16"
    width="16"
    height="16"
    fill="currentColor"
    style="
      display: inline-block;
      user-select: none;
      vertical-align: text-bottom;
      overflow: visible;
    "
  >
    <path
      d="M2 1.75C2 .784 2.784 0 3.75 0h6.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v9.586A1.75 1.75 0 0 1 13.25 16h-9.5A1.75 1.75 0 0 1 2 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .<IP_ADDRESS>.25h9.5a.25.25 0 0 0 .25-.25V6h-2.75A1.75 1.75 0 0 1 9 4.25V1.5Zm6.75.062V4.25c0 .<IP_ADDRESS>.25h2.688l-.011-.013-2.914-2.914-.013-.011Z"
    />
  </svg>
  <svg
    class="octicon octicon-pencil"
    xmlns="http://www.w3.org/2000/svg"
    width="16"
    height="16"
    viewBox="0 0 16 16"
    role="img"
    aria-hidden="true"
  >
    <path
      d="M11.013 1.427a1.75 1.75 0 0 1 2.474 0l1.086 1.086a1.75 1.75 0 0 1 0 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 0 1-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61Zm.176 4.823L9.75 4.81l-6.286 6.287a.253.253 0 0 0-.064.108l-.558 1.953 1.953-.558a.253.253 0 0 0 .108-.064Zm1.238-3.763a.25.25 0 0 0-.354 0L10.811 3.75l1.439 1.44 1.263-1.263a.25.25 0 0 0 0-.354Z"
    />
  </svg>

        package.json

✅ gfei (this extension) alone
<svg
  data-catppuccin-file-explorer-icons=""
  data-catppuccin-file-explorer-icons-iconname="package-json"
  data-catppuccin-file-explorer-icons-filename="package.json"
  aria-hidden="true"
  focusable="false"
  class="color-fg-muted"
  viewBox="0 0 16 16"
  width="16"
  height="16"
  fill="currentColor"
  style="
    display: inline-block;
    user-select: none;
    vertical-align: text-bottom;
    overflow: visible;
  "
>
  <path
    fill="none"
    stroke="var(--ctp-green)"
    stroke-linecap="round"
    stroke-linejoin="round"
    d="M11.5 6.5v-.17c0-.73-.6-1.33-1.33-1.33H9a1.5 1.5 0 1 0 0 3h1a1.5 1.5 0 0 1 0 3H9a1.5 1.5 0 0 1-1.5-1.5M5.5 5v4.5c0 1.5-.08 1.87-.71 2.5-.5.5-1.5.5-1.5.5-.96-.4-1.2-.66-1.79-1v-7L8 .5l6.5 4v7l-6.5 4-2.49-1.53"
  />
</svg>
<svg
  aria-hidden="true"
  focusable="false"
  class="color-fg-muted"
  viewBox="0 0 16 16"
  width="16"
  height="16"
  fill="currentColor"
  style="
    display: none;
    user-select: none;
    vertical-align: text-bottom;
    overflow: visible;
  "
>
  <path
    d="M2 1.75C2 .784 2.784 0 3.75 0h6.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v9.586A1.75 1.75 0 0 1 13.25 16h-9.5A1.75 1.75 0 0 1 2 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .<IP_ADDRESS>.25h9.5a.25.25 0 0 0 .25-.25V6h-2.75A1.75 1.75 0 0 1 9 4.25V1.5Zm6.75.062V4.25c0 .<IP_ADDRESS>.25h2.688l-.011-.013-2.914-2.914-.013-.011Z"
  />
</svg>

        package.json

✅ rgh + gfei (when displayed correctly)

  <svg
    data-catppuccin-file-explorer-icons=""
    data-catppuccin-file-explorer-icons-iconname="package-json"
    data-catppuccin-file-explorer-icons-filename="package.json"
    aria-hidden="true"
    focusable="false"
    class="color-fg-muted rgh-seen-2924925456"
    viewBox="0 0 16 16"
    width="16"
    height="16"
    fill="currentColor"
    style="
      display: inline-block;
      user-select: none;
      vertical-align: text-bottom;
      overflow: visible;
    "
  >
    <path
      fill="none"
      stroke="var(--ctp-green)"
      stroke-linecap="round"
      stroke-linejoin="round"
      d="M11.5 6.5v-.17c0-.73-.6-1.33-1.33-1.33H9a1.5 1.5 0 1 0 0 3h1a1.5 1.5 0 0 1 0 3H9a1.5 1.5 0 0 1-1.5-1.5M5.5 5v4.5c0 1.5-.08 1.87-.71 2.5-.5.5-1.5.5-1.5.5-.96-.4-1.2-.66-1.79-1v-7L8 .5l6.5 4v7l-6.5 4-2.49-1.53"
    />
  </svg>
  <svg
    aria-hidden="true"
    focusable="false"
    class="color-fg-muted rgh-seen-2924925456"
    viewBox="0 0 16 16"
    width="16"
    height="16"
    fill="currentColor"
    style="
      display: none;
      user-select: none;
      vertical-align: text-bottom;
      overflow: visible;
    "
  >
    <path
      d="M2 1.75C2 .784 2.784 0 3.75 0h6.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v9.586A1.75 1.75 0 0 1 13.25 16h-9.5A1.75 1.75 0 0 1 2 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .<IP_ADDRESS>.25h9.5a.25.25 0 0 0 .25-.25V6h-2.75A1.75 1.75 0 0 1 9 4.25V1.5Zm6.75.062V4.25c0 .<IP_ADDRESS>.25h2.688l-.011-.013-2.914-2.914-.013-.011Z"
    />
  </svg>
  <svg
    class="octicon octicon-pencil"
    xmlns="http://www.w3.org/2000/svg"
    width="16"
    height="16"
    viewBox="0 0 16 16"
    role="img"
    aria-hidden="true"
  >
    <path
      d="M11.013 1.427a1.75 1.75 0 0 1 2.474 0l1.086 1.086a1.75 1.75 0 0 1 0 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 0 1-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61Zm.176 4.823L9.75 4.81l-6.286 6.287a.253.253 0 0 0-.064.108l-.558 1.953 1.953-.558a.253.253 0 0 0 .108-.064Zm1.238-3.763a.25.25 0 0 0-.354 0L10.811 3.75l1.439 1.44 1.263-1.263a.25.25 0 0 0 0-.354Z"
    />
  </svg>

        package.json

❌ rgh + gfei (when displayed incorrectly)

  <svg
    data-catppuccin-file-explorer-icons=""
    data-catppuccin-file-explorer-icons-iconname="package-json"
    data-catppuccin-file-explorer-icons-filename="package.json"
    aria-hidden="true"
    focusable="false"
    class="color-fg-muted rgh-seen-2924925456"
    viewBox="0 0 16 16"
    width="16"
    height="16"
    fill="currentColor"
    style="
      display: inline-block;
      user-select: none;
      vertical-align: text-bottom;
      overflow: visible;
    "
  >
    <path
      fill="none"
      stroke="var(--ctp-green)"
      stroke-linecap="round"
      stroke-linejoin="round"
      d="M11.5 6.5v-.17c0-.73-.6-1.33-1.33-1.33H9a1.5 1.5 0 1 0 0 3h1a1.5 1.5 0 0 1 0 3H9a1.5 1.5 0 0 1-1.5-1.5M5.5 5v4.5c0 1.5-.08 1.87-.71 2.5-.5.5-1.5.5-1.5.5-.96-.4-1.2-.66-1.79-1v-7L8 .5l6.5 4v7l-6.5 4-2.49-1.53"
    />
  </svg>
  <svg
    class="octicon octicon-pencil"
    xmlns="http://www.w3.org/2000/svg"
    width="16"
    height="16"
    viewBox="0 0 16 16"
    role="img"
    aria-hidden="true"
  >
    <path
      d="M11.013 1.427a1.75 1.75 0 0 1 2.474 0l1.086 1.086a1.75 1.75 0 0 1 0 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 0 1-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61Zm.176 4.823L9.75 4.81l-6.286 6.287a.253.253 0 0 0-.064.108l-.558 1.953 1.953-.558a.253.253 0 0 0 .108-.064Zm1.238-3.763a.25.25 0 0 0-.354 0L10.811 3.75l1.439 1.44 1.263-1.263a.25.25 0 0 0 0-.354Z"
    />
  </svg>

  <svg
    aria-hidden="true"
    focusable="false"
    class="color-fg-muted rgh-seen-2924925456"
    viewBox="0 0 16 16"
    width="16"
    height="16"
    fill="currentColor"
    style="
      display: none;
      user-select: none;
      vertical-align: text-bottom;
      overflow: visible;
    "
  >
    <path
      d="M2 1.75C2 .784 2.784 0 3.75 0h6.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v9.586A1.75 1.75 0 0 1 13.25 16h-9.5A1.75 1.75 0 0 1 2 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .<IP_ADDRESS>.25h9.5a.25.25 0 0 0 .25-.25V6h-2.75A1.75 1.75 0 0 1 9 4.25V1.5Zm6.75.062V4.25c0 .<IP_ADDRESS>.25h2.688l-.011-.013-2.914-2.914-.013-.011Z"
    />
  </svg>
  <svg
    class="octicon octicon-pencil"
    xmlns="http://www.w3.org/2000/svg"
    width="16"
    height="16"
    viewBox="0 0 16 16"
    role="img"
    aria-hidden="true"
  >
    <path
      d="M11.013 1.427a1.75 1.75 0 0 1 2.474 0l1.086 1.086a1.75 1.75 0 0 1 0 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 0 1-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61Zm.176 4.823L9.75 4.81l-6.286 6.287a.253.253 0 0 0-.064.108l-.558 1.953 1.953-.558a.253.253 0 0 0 .108-.064Zm1.238-3.763a.25.25 0 0 0-.354 0L10.811 3.75l1.439 1.44 1.263-1.263a.25.25 0 0 0 0-.354Z"
    />
  </svg>

        package.json

As I said, disabling the quick-file-edit feature in RGH solves the problem, which is what I ended up doing. Feel free to close this issue if out of scope, it may help others in the same situation.

I realised I wasn't on the latest version, updating to 0.12.1 gives the following result:

Thanks for the investigation and write up, I was running into this issue and wasn't able to find a consistent root cause but clearly didn't try hard enough!
I'm not sure if we can do anything from a plugin pov but I think it would be great to add a notice into the README or equivalent given how popular Refind GitHub is.
I'll leave the final decision to @uncenter.

I for one am unable to reproduce this issue after enabling the feature just now. Tried going into deeply nested folders, then back to root - no luck. Tried exactly the path in your video, using the back button twice after going to src -> entries, didn't see it either. I'll leave it on for a few days and see if I spot the bug... One thing I can point out is that I'm not seeing it on Chrome, and @franky47 is seeing it on Firefox. @sgoudham which browser are you using?

which browser are you using?

I'm using Firefox, I'll see if I can reproduce on Chrome at some point later.

I can't immediately reproduce it on Chrome, I'll keep it on for a bit and will report back if I get it. What I do see though is a very brief flash when navigating back to a repo's home page.
Here's a video of it slowed down 5x, when scrubbing I can see the following events (on Chrome):

The page loads in its final state (probably the DOM from browser cache)
Then the stock GItHub UI is shown with loading spinners
Then the Catpuccin icons replace the stock icons
Then the Refined GitHub UI elements show up / replace the stock ones
Then the final loaded data replaces the skeletons (latest commit title per file)

https://github.com/user-attachments/assets/4f866ff6-59c0-4dbd-8619-384541b0458c
It's possible that the order of events (Catpuccin loading before Refined GitHub) makes Chrome work, I'll try the same on Firefox and edit this comment.

@fregante I hope you don't mind me pinging you here, do you have any ideas? Is this something I need to fix with this extension here or is this an issue with Refined GitHub? I recall https://github.com/refined-github/refined-github/issues/6626, which was fixed, but this could very well be a regression in my reimplementation of that other extension...

This likely happens because React updates the DOM by adding its own icon, but the old icon is no longer in the exact position so it's not removed.
I don't have time to investigate this exact issue, but I'd make sure that the icon you're replacing matches the previous DOM exactly so that neither Refined GitHub nor React notices the difference. This includes the dynamic "rgh-seen" class. If Refined GitHub doesn't see it, it will wrap the icon again. So I'd advice copying the whole class list from the existing icon when replacing it.


refactor CMakeLists.txt. use automoc, autouic and autorcc

Status
DEVELOPMENT
Description
To shorten build time, i modified the CMakeLists.txt of the package that is rebuilt every time. #887
Todos

[x] Tests
[ ] Documentation

Steps to Test or Reproduce
$ cd <your-Autoware-path>/ros
$ catkin_make # build all packages, if it is first time build
$ catkin_make # nothing is rebuilt

Like this!

Before this commit, we used "add_custom_command" like the code dejanpan references.
In this method, since the file is regenerated every time although there is no change, it took useless time to build.
After this commit, I modified to use "automoc" "autouic", and automatically generate it if necessary.
Also, until now, we have created moc _ *. cpp and ui _ *. h under src. Now it is no longer under src, so .gitignore is deleted accordingly.


[ROAD-821] fix: restore all tree items after clear search

Description
Fix issue with search/filter functionality. Now if user search or filter OSS/SnykCode results and after this clear search keyword it will restore all results in results tree.
Checklist

[x] CHANGELOG.md updated

Screenshots / GIFs

The search is case-sensitive. I suggest changing .Contains(searchString) to .ToLowerInvariant().Contains(searchString) in FilterOssItems and FilterSnykCodeItems