virglrenderer: 0.6.0 -> 0.7.0

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size  +120k
[x] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: virglrenderer
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: virglrenderer
Partial log (click to expand)
make[1]: Leaving directory '/build/virglrenderer-0.7.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8yv2vda91pcf9z9iq43780yl77n058ag-virglrenderer-0.7.0
shrinking /nix/store/8yv2vda91pcf9z9iq43780yl77n058ag-virglrenderer-0.7.0/bin/virgl_test_server
shrinking /nix/store/8yv2vda91pcf9z9iq43780yl77n058ag-virglrenderer-0.7.0/lib/libvirglrenderer.so.0.2.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8yv2vda91pcf9z9iq43780yl77n058ag-virglrenderer-0.7.0/lib  /nix/store/8yv2vda91pcf9z9iq43780yl77n058ag-virglrenderer-0.7.0/bin
patching script interpreter paths in /nix/store/8yv2vda91pcf9z9iq43780yl77n058ag-virglrenderer-0.7.0
checking for references to /build in /nix/store/8yv2vda91pcf9z9iq43780yl77n058ag-virglrenderer-0.7.0...
/nix/store/8yv2vda91pcf9z9iq43780yl77n058ag-virglrenderer-0.7.0

Success on aarch64-linux (full log)
Attempted: virglrenderer
Partial log (click to expand)
make[1]: Leaving directory '/build/virglrenderer-0.7.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6rn8rmda9slyfx7i9kmipiyh6n5qd60m-virglrenderer-0.7.0
shrinking /nix/store/6rn8rmda9slyfx7i9kmipiyh6n5qd60m-virglrenderer-0.7.0/bin/virgl_test_server
shrinking /nix/store/6rn8rmda9slyfx7i9kmipiyh6n5qd60m-virglrenderer-0.7.0/lib/libvirglrenderer.so.0.2.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6rn8rmda9slyfx7i9kmipiyh6n5qd60m-virglrenderer-0.7.0/lib  /nix/store/6rn8rmda9slyfx7i9kmipiyh6n5qd60m-virglrenderer-0.7.0/bin
patching script interpreter paths in /nix/store/6rn8rmda9slyfx7i9kmipiyh6n5qd60m-virglrenderer-0.7.0
checking for references to /build in /nix/store/6rn8rmda9slyfx7i9kmipiyh6n5qd60m-virglrenderer-0.7.0...
/nix/store/6rn8rmda9slyfx7i9kmipiyh6n5qd60m-virglrenderer-0.7.0

@grahamcofborg build qemu

Success on x86_64-darwin (full log)
Attempted: qemu
Partial log (click to expand)
copying path '/nix/store/z5mm21wk64j1k6sjf9zai5z0ij8xvm1k-libevent-2.1.8' from 'https://cache.nixos.org'...
copying path '/nix/store/idzzwmzy2b43bhkswpg8zdj1rwj5q5h7-libidn-1.35' from 'https://cache.nixos.org'...
copying path '/nix/store/k6rm0wnxi14cc0imhwwsqpjff6rh4pj2-libtasn1-4.13' from 'https://cache.nixos.org'...
copying path '/nix/store/skfn3j8s4rk4b33xa6sm61qv3yngzbjg-libunistring-0.9.10' from 'https://cache.nixos.org'...
copying path '/nix/store/h759qnzfrwjddbkm25vqa4si0kllj9qb-vde2-2.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/sjkx68jmp1b7nhqlwmx69crmf6hfwf1r-unbound-1.7.3-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/4wrnfd41rh5zmf1zhfi808rr88304z58-p11-kit-0.23.13' from 'https://cache.nixos.org'...
copying path '/nix/store/zbnrmksh9abwqsg88mvsmcjqz56nx4nz-gnutls-3.5.10' from 'https://cache.nixos.org'...
copying path '/nix/store/xl29g1rillm205f4aigghsc1c156y02v-qemu-3.0.0' from 'https://cache.nixos.org'...
/nix/store/xl29g1rillm205f4aigghsc1c156y02v-qemu-3.0.0

Success on x86_64-linux (full log)
Attempted: qemu
Partial log (click to expand)
patching script interpreter paths in /nix/store/nzfmw8yya820al0j206i6a8d6vzm98d3-qemu-3.0.0
checking for references to /build in /nix/store/nzfmw8yya820al0j206i6a8d6vzm98d3-qemu-3.0.0...
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/nzfmw8yya820al0j206i6a8d6vzm98d3-qemu-3.0.0


test: fix CI failures when running with --git-provider=csr

https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2228 changes the default git provider from local to csr, which also changes the defalt git auth from ssh to gcpserviceaccount, which causes a bunch of testing failures and missing permissions.
This commit updates the tests to set the secret for non-csr git providers and also adds the missing IAM bindings.

Finally got all failed tests pass on my test clusters.

/lgtm
For the record, I objected to putting the IAM in TF because I believe it will make for more test failures and gotchas and more work for developers, but I was outvoted in favor of the principle of least privileged. Given that, this is fine, for now. We can circle back when it becomes an annoyance for the team.

/lgtm
For the record, I objected to putting the IAM in TF because I believe it will make for more test failures and gotchas and more work for developers, but I was outvoted in favor of the principle of least privilege. Given that, this is fine, for now. We can circle back when it becomes an annoyance for the team.

Thanks for reviewing it. Can you also approve it?


Add TraceTTL to cassandra schema spec

This adds the CassandraSchemaSpec.traceTTL field to allow the user to specify the TTL for their traces.
The TRACE_TTL env var is picked up by this script which creates the schema: https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/cassandra/schema/create.sh
fixes #1101

The es-otel test seems flaky, it runs fine locally. Can i re-run this check individually without git commit --amend and force-pushing?

LGTM. @kevinearls, is this ES failure known to you? If so, we can merge this as is, or we can try to restart the job via GitHub (which typically will cause everything to randomly fail...). Or, @moolen could try to amend and force-push and see if the test passes :-/

@jpkrohling which es failure?

I take that back, i don't think it's flaky: I reproduced the issue locally (i missed exporting the USE_OTEL_COLLECTOR env var before running es tests) and it continuously fails in CI. I'll dig into that.
stacktrace of the pod that runs jaegertracing/spark-dependencies : https://gist.github.com/moolen/091b62d537bab7f01c9f8072ad6d19a2

If you nee any help, let us know!

Thank you for your contribution!


Random crop during training

Hello,
This question is regarding the 'random_crop_to_size' transform here. Is the protein cropped at different locations across the different epochs during training or are they cropped the same way?
Thanks!

it is ultimately called by the feature_pipeline here. So each sample (protein chain) should get a random start position for the crop


[Feature] Get changes from all commits from a single push

Is this feature missing in the latest version?

[X] I'm using the latest release

Is your feature request related to a problem? Please describe.
In one of my repositories we have a situation that users are pushing multiple commits in a single push.
I am running one action on each push and I would like to get the changes from all commits that were added by this action.
Describe the solution you'd like?
At the moment it's just getting changes from the latest commit and commit before it.
I would like to have an option to use "last commit existing before push" as a BASE_SHA.
Describe alternatives you've considered?
No response
Anything else?
Here is the example of the use-case I am talking about:
https://github.com/raycast/extensions/commits/main
The exact two commits are visible here:

In my case the changes from the first one without Action were missing and never caught by my actions due to that problem.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@grzegorzkrukowski This feature is available  using
      - name: Run changed-files using the last commit on the remote branch
        id: changed-files-since-last-remote-commit
        uses<EMAIL_ADDRESS>        with:
          since_last_remote_commit: "true"

         ```

You can check out the README for more examples.


Minimal example for profiling neovim

Hi! Do you have a minimal example for how to use this to profile something in neovim? I tried for example
local func = function()
  print("sleeping")
  vim.system({"sleep", "2"}):wait()
  print("done")
end

vim.cmd.PerfLuaProfileStart()
func()
P(vim.diagnostic.get(0, {}))
vim.cmd.PerfLuaProfileStop()

but it didn't show anything (other than the message that "Callgraph has been loaded")

Once the callgraph is loaded, you can search for hottest lines etc. Try :PerfHottestLines (this works best if telescope is installed), annotations should just be on by default.
If you're trying to profile some script, make sure it is saved as a file (i.e. not just in some unnamed buffer) because the luajit profiler gives us filenames to associate the lines with.

I've had a chance to run your example on my setup and this just doesn't generate any samples to look at. Looks like when you wait on an external command, lua is effectively not running at all and the LuaJIT profiler does not generate any samples. This is not something I have any control over. Here is a minimal example that does something if you want one (although you can also just type :PerfLuaProfileStart, type some characters, and type :PerfLuaProfileStop):
local func = function()
  print("sleeping")
  vim.system({"sleep", "2"}):wait()
  print("done")
end

vim.cmd.PerfLuaProfileStart()
func()
P(vim.diagnostic.get(0, {}))
vim.cmd.PerfLuaProfileStop()


Release v0.3.5

Pull Request Test Coverage Report for Build 6fc739ab7ad66528df33ab4b0102df5fbaf4149c-PR-67

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build f4e4d3d5aa3c92030f707440f14e1b2ebbfc67ef:
0.0%

Covered Lines:
302

Relevant Lines:
302

💛  - Coveralls

Pull Request Test Coverage Report for Build 6fc739ab7ad66528df33ab4b0102df5fbaf4149c-PR-67

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build f4e4d3d5aa3c92030f707440f14e1b2ebbfc67ef:
0.0%

Covered Lines:
302

Relevant Lines:
302

💛  - Coveralls


Implement user registration endpoint

Create an API endpoint that allows users to register by providing their full name, email and password. Validate the input data and store the user details in the database.

merging to main directly is forbidden


scroll countries list

this helped to scroll the countries list

The default value of scroll is already true, as specified also in the doc:
http://ionicframework.com/docs/api/directive/ionContent/
May i know in what circumstances you had scrolling issues?
Pierre

Any input on that? i would like to know what scrolling issue you have, as scroll="true" is the default value,
Pierre

Hi Falanso, any feedback on that?
Pierre

Hi Falanso,
Can you provide some feedback? if not, i might close the pull request
Pierre


Restructure the documentation and ensure consistency between pages

This:

Makes pages consistent by making them all inherit from the same parent. This fixes problems with pages missing footers or content containers.
Make a clearer distinction between core DS files and files meant for the docs site only.
Refactor foo.html to foo/index.html to allow for clean URLs.
Removes the distinction between components and elements. We just have components now. with Brand and identity and Design pages (those can be renamed), with in a future follow-up Patterns  as well.

Organising Components with Atomic Design Methodology instead of "All Components approach suggested"

https://atomicdesign.bradfrost.com/chapter-2/

I'd be happy to make a distinction between different types of building blocks. What test do you propose that lets us unambiguously group them?


improve informer test

making all the threads terminate and no longer killing things ... 3 green ci runs 🤞

@agrare I don't know if you have been following the Kubeclient::Informer class on master branch, but perhaps it's interesting for future use in manageiq (?).  Either way, you may have useful experience to share here from how manageiq is killing & restarting watches...  That's a long way of saying "please review" :wink:
[P.S. entirely out-of-scope here, but there is the unfinished business of #488.  The blocker there was we didn't know how to implement watch .finish with Faraday :shrug:  @agrare I was considering maybe dropping .finish in 5.0 and letting you figure out how to bring it back when you want to upgrade ManageIQ :stuck_out_tongue_closed_eyes:  But now I realize Informer relies on it deeply, and I suspect so would any advanced usage of watches?]

I think this is a good step forward, so prefer to merge and then iterate further if there are still open issues.

Sorry, missed your reply entirely.
FWIW, Thread.pass is advisory, so not sure it can really "fix" things:

Give the thread scheduler a hint to pass execution to another thread. A running thread may or may not switch, it depends on OS and processor.

I'm still somewhat concerned a call to stop_worker might get stuck for a long time.
But yes, previous behavior was chaotic, so I guess it's an advance. :+1:
And I'm certainly happy about CI looking reliably green now :tada:  Merging.


Create Unit test suite

@notmessenger had to create new PR, last one got ruined due to git problems.

https://github.com/softlayer/sl-ember-components/pull/1084 was the last pr, @juwara0 already reviewed it so its ready to be merged.

I have started reviewing this.

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 29 [r2] (raw file):
Need to also add an assertion to test that namespace is mixin is present: https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/addon/components/sl-radio-group.js#L14

tests/unit/components/sl-radio-group-test.js, line 32 [r2] (raw file):
Test name is incorrect: https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#naming-unit-tests

tests/unit/components/sl-radio-group-test.js, line 103 [r2] (raw file):
There also needs to be an assert checking for disabled property and class on the  tag

tests/unit/components/sl-radio-group-test.js, line 140 [r2] (raw file):
This title is incorrect for what is being tested. It should read something like 'initialize() - "inline=false" property adds "radio" class to "sl-radio"'

tests/unit/components/sl-radio-group-test.js, line 161 [r2] (raw file):
Do you need this test since the one below written by Aziz covers both the scenario of the event handlers being setup in didInsertElement and their removal in willClearRender?

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

Comments from the review on Reviewable.io

Can you also add a test that exercises this line: https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/addon/components/sl-radio-group.js#L137-L139

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 29 [r2] (raw file):
Done.

tests/unit/components/sl-radio-group-test.js, line 32 [r2] (raw file):
Done.

tests/unit/components/sl-radio-group-test.js, line 103 [r2] (raw file):
the 2 tests below do exactly that, checks disabled prop and the class 'disabled'.

tests/unit/components/sl-radio-group-test.js, line 140 [r2] (raw file):
Done.

tests/unit/components/sl-radio-group-test.js, line 161 [r2] (raw file):
Done.

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 9 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 76 [r3] (raw file):
I believe this should be an integration test. I don't see any isolated component methods being called.

tests/unit/components/sl-radio-group-test.js, line 97 [r3] (raw file):
I believe this should be an integration test. I don't see any isolated component methods being called.

tests/unit/components/sl-radio-group-test.js, line 124 [r3] (raw file):
I believe this should be an integration test. I don't see any isolated component methods being called.

tests/unit/components/sl-radio-group-test.js, line 145 [r3] (raw file):
I believe this should be an integration test. I don't see any isolated component methods being called.

Comments from the review on Reviewable.io

tests/unit/components/sl-radio-group-test.js, line 229 [r3] (raw file):
I believe this should be an integration test. I don't see any isolated component methods being called.

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 140 [r2] (raw file):
The title is still incorrect. Please note that the class "radio" is added to '.sl-radio' https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/addon/components/sl-radio-group.js#L123

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 229 [r3] (raw file):
The title has a spelling error 'listner'

Comments from the review on Reviewable.io

tests/unit/components/sl-radio-group-test.js, line 245 [r3] (raw file):
spelling error of 'listner'

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 9 unresolved discussions.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 10 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 240 [r3] (raw file):
shouldn't this be trigger(  'change' )
https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/addon/components/sl-radio-group.js#L136-L139

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 10 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 140 [r2] (raw file):
removed test, see comment above.

tests/unit/components/sl-radio-group-test.js, line 76 [r3] (raw file):
correct, removed since this test already exists: https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/integration/components/sl-radio-group-test.js#L227

tests/unit/components/sl-radio-group-test.js, line 97 [r3] (raw file):
correct, removed since this test already exists: https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/integration/components/sl-radio-group-test.js#L45

tests/unit/components/sl-radio-group-test.js, line 124 [r3] (raw file):
correct, removed since this test already exists: https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/integration/components/sl-radio-group-test.js#L159

tests/unit/components/sl-radio-group-test.js, line 145 [r3] (raw file):
correct, removed since test already exists: https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/integration/components/sl-radio-group-test.js#L181

tests/unit/components/sl-radio-group-test.js, line 229 [r3] (raw file):
correct, removed since this test already exists: https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/integration/components/sl-radio-group-test.js#L203

tests/unit/components/sl-radio-group-test.js, line 229 [r3] (raw file):
test was removed, see comment above.

tests/unit/components/sl-radio-group-test.js, line 245 [r3] (raw file):
test was removed, see comment above.

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 10 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 240 [r3] (raw file):
test was removed, see comment above.

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 62 [r4] (raw file):
Indentation needs to be fixed. Also, function declaration can be made less verbose.
assert.throws(
    () => component.initialize(),
    '"name" property must be set on component'
);

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

tests/unit/components/sl-radio-group-test.js, line 62 [r4] (raw file):
Done.

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r5.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r5.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io


[BUG] Thread not safe when SetDefaultAgentInfo in Microsoft.Rest.ServiceClient

Describe the bug
I was using a singleton http client to create ContainerInstanceManagementClient instance and then get container group from azure container instance server.But sometimes, it throw out ArgumentNullException like this

Unhandled exception occured: System.ArgumentNullException: Value cannot be null. (Parameter 'obj')
at System.OrdinalIgnoreCaseComparer.GetHashCode(String obj)
at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
at System.Collections.Generic.Dictionary`2.ContainsKey(TKey key)
at System.Net.Http.Headers.HttpHeaders.AddHeaders(HttpHeaders sourceHeaders)
at System.Net.Http.Headers.HttpRequestHeaders.AddHeaders(HttpHeaders sourceHeaders)
at System.Net.Http.HttpClient.PrepareRequestMessage(HttpRequestMessage request)
at System.Net.Http.HttpClient.SendAsync(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.Azure.Management.ContainerInstance.ContainerGroupsOperations.GetWithHttpMessagesAsync(String resourceGroupName, String containerGroupName, Dictionary`2 customHeaders, CancellationToken cancellationToken)
at Microsoft.Azure.Management.ContainerInstance.ContainerGroupsOperationsExtensions.GetAsync(IContainerGroupsOperations operations, String resourceGroupName, String containerGroupName, CancellationToken cancellationToken)
at Microsoft.MachineLearning.ModelManagement.Utilities.AciClient.<>c__DisplayClass18_0`1.<<Execute>b__0>d.MoveNext() in /home/vsts/work/1/s/src/Product/Common/Services/Common.Services/Utilities/Webservice/AciClient.cs:line 295 --- End of stack trace from previous location where exception was thrown ---
at Polly.Policy.<>c__DisplayClass181_0`1.<<ExecuteAsyncInternal>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---
at Polly.Policy.<>c__DisplayClass229_1.<<TimeoutAsync>b__1>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---
at Polly.Timeout.TimeoutEngine.ImplementationAsync[TResult](Func`3 action, Context context, Func`2 timeoutProvider, TimeoutStrategy timeoutStrategy, Func`5 onTimeoutAsync, CancellationToken cancellationToken, Boolean continueOnCapturedContext)
at Polly.Timeout.TimeoutEngine.ImplementationAsync[TResult](Func`3 action, Context context, Func`2 timeoutProvider, TimeoutStrategy timeoutStrategy, Func`5 onTimeoutAsync, CancellationToken cancellationToken, Boolean continueOnCapturedContext)
at Polly.Policy.ExecuteAsyncInternal[TResult](Func`3 action, Context context, CancellationToken cancellationToken, Boolean continueOnCapturedContext)
at Polly.Wrap.PolicyWrapEngine.<>c__DisplayClass8_0`1.<<ImplementationAsync>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---
at Polly.Policy.<>c__DisplayClass181_0`1.<<ExecuteAsyncInternal>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---
at Polly.RetrySyntaxAsync.<>c__DisplayClass25_1.<<WaitAndRetryAsync>b__1>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---
at Polly.Retry.RetryEngine.ImplementationAsync[TResult](Func`3 action, Context context, CancellationToken cancellationToken, IEnumerable`1 shouldRetryExceptionPredicates, IEnumerable`1 shouldRetryResultPredicates, Func`1 policyStateFactory, Boolean continueOnCapturedContext)
at Polly.Retry.RetryEngine.ImplementationAsync[TResult](Func`3 action, Context context, CancellationToken cancellationToken, IEnumerable`1 shouldRetryExceptionPredicates, IEnumerable`1 shouldRetryResultPredicates, Func`1 policyStateFactory, Boolean continueOnCapturedContext)
at Polly.Policy.ExecuteAsyncInternal[TResult](Func`3 action, Context context, CancellationToken cancellationToken, Boolean continueOnCapturedContext)
at Polly.Wrap.PolicyWrapEngine.ImplementationAsync[TResult](Func`3 func, Context context, CancellationToken cancellationToken, Boolean continueOnCapturedContext, IAsyncPolicy outerPolicy, IAsyncPolicy innerPolicy)
at Microsoft.MachineLearning.ModelManagement.Utilities.AciClient.Execute[T](Func`1 func) in /home/vsts/work/1/s/src/Product/Common/Services/Common.Services/Utilities/Webservice/AciClient.cs:line 293
at Microsoft.MachineLearning.ModelManagement.Utilities.AciClient.GetAci(String subscription, String resourceGroup, String apiVersion, String serviceName, String authToken) in /home/vsts/work/1/s/src/Product/Common/Services/Common.Services/Utilities/Webservice/AciClient.cs:line 65

here is my source code

After tracking to the exception stack, seems the somewhere write the _defaultRequestHeaders of httpclient in a thread-not-safe way.After a seach in azure-sdk, I found the Service Client https://github.com/Azure/azure-sdk-for-net/blob/a647074ae4b2590d366fe03591ec022043222859/sdk/mgmtcommon/ClientRuntime/ClientRuntime/ServiceClient.cs#L563  is trying to set user agent for http client ,which may lead to this thread-not-safe write.If another thread is reading _defaultRequestHeaders, it could see a half-writen headers
here is a image show thread issue

I think remove the SetDefaultAgentInfo method will fix the issue
Expected behavior
What is the expected behavior?
Actual behavior (include Exception or Stack Trace)
What is the actual behavior?
To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)
Environment:

Name and version of the Library package used: [e.g. Azure.Storage.Blobs 12.2.0]
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): netcore 3.1
IDE and version : Jetbrain rider 2020

If user keep and reuse http client, the SetDefaultAgentInfo method is safe only if the ContainerInstanceManagementClient(sub class of ServiceClient) is reused.
But ContainerInstanceManagementClient should be create with token and subscription id.It seems impossible to keep ContainerInstanceManagementClient  if your service server different subscriptions
From this view,the SetDefaultAgentInfo seems useless and may lead some potential issue

@erich-wang can you help review this issue?

Unfortunately, I'm just the first line triage in this case, helping to tag so that the appropriate folks are able to help.  I've no insight into this area directly.   If @erich-wang isn't able to assist, perhaps @isra-fel or @pakrym would be able to provide an alternate suggestion for routing.

any response? @erich-wang @isra-fel @pakrym

@mjaow , thank you for raising the question. Could you use new HttpClient for each ServiceClient instance instead of using singleton HttpClient?
To reuse one single HttpClient among multiple ServiceClient instances, the class level lock instead of object level lock must be applied to UserAgent related method within ServiceClient.cs, which will introduce performance penalty, and this is what we try to avoid.

thanks for reply.@erich-wang. We server every different user request with diferent Serviceclient,which leading to a new ServiceClient and a new httpclient. But everytime create a new http client will also introduce performance penalty.
Or can you provide a way to avoid set user agent?I t's useless for us

In general the recommendation for HttpClient is to reuse it (this helps pool sockets/etc). Creating a new HttpClient per request is going to lead to client-side performance issues as well.
It sounds like the solution is to pool an HttpClient per ServiceClient today. is there any opportunity to improve further here to reduce resource utilization?

@doubleyewdee thanks for reply, but token will expire after a while

@erich-wang @isra-fel @pakrym  Do you have any suggestions?

I took a look at the issues and you are definitely right that this is a race of SetUserAgent with HttpClient.PrepareRequestMessage
We can't remove the method as that would we a behavioral breaking change.
One workaround that can work for you is prepopulating the DefaultRequestHeaders.UserAgent with values SetDefaultAgentInfo tries to add. This way the Contains logic AddUserAgentEntry would kick in and avoid modifying the header collection.
Something like:
var httpClient = new HttpClient();
httpClient.DefaultRequestHeaders.UserAgent.Add(new ProductInfoHeaderValue("FxVersion", ""));
httpClient.DefaultRequestHeaders.UserAgent.Add(new ProductInfoHeaderValue("OSName", ""));
httpClient.DefaultRequestHeaders.UserAgent.Add(new ProductInfoHeaderValue("OSVersion", ""));
httpClient.DefaultRequestHeaders.UserAgent.Add(new ProductInfoHeaderValue("Microsoft.Azure.Management.ContainerInstance.ContainerInstanceManagementClient", ""));

@pakrym thanks for reply.It's awesome and I'll have a try

The issue doesn't happen recently (deployed for more than 1 week). But I think it's better to wait and keep an eye for longer.

I'm going to close the issue. Please reopen if the issue comes back.

We are seeing a similar situation and it feels like this should be addressed directly in the SDK rather than asking folks to have a workaround, especially when the userAgent added also has a typeName to it, if different types happen to use it, we still have the same issue. If it is a breaking change, why not provide a way to skip adding the userAgent while keeping the default behavior to add them?


npm.exclude seems to exclude only deep subdirectories

We are seeing dozens of package.json scripts from our .cache directory appear in NPM Scripts. Even with npm.exclude set to any of .cache, **/.cache/** or .cache/** it still lists a script in .cache/package.json:
Steps to Reproduce:

Create a subdirectory .cache with a package.json with a script (package A)
Create a subdirectory inside .cache/foo with a package.json with a script (package B)
Setting "npm.exclude": [".cache/**"] results in both these unwanted scripts appearing
Setting "npm.exclude": ["**/.cache/**"] results in scripts from package A appearing

Does this issue occur when all extensions are disabled?: Yes

VSCode 1.52.1 user
Ekectron 9.3.5
Chrome 83.0
Node.js 12.14.1
V8: 8.3
OS: Windows_NT x64 10.0

In a similar situation I had to put in npm.exclude both **/.cache/** and **/.cache to have .cache/package.json excluded.

In a similar situation I had to put in npm.exclude both **/.cache/** and **/.cache to have .cache/package.json excluded.

Thanks that worked. Funny that someone decided imple * wildcards were not enough here. What is this strange language of ** magic of which you speak?

Thanks that worked. Funny that someone decided imple * wildcards were not enough here. What is this strange language of ** magic of which you speak?

** = Any directory level

** = Any directory level


Button Box toggle breaks if switching Entry Types multiple times

I'm using a Button Box field in one of a couple Entry Types assigned to the Section, and it's not the default Entry Type - so to see the BB field in action I first have to switch Entry Types.  Upon the first switch, the BB field works fine and I can toggle the button selection; however if I change back to the first Entry Type, and then back to the Entry Type with the BB field, I can no longer change it, it remains "stuck" on whatever the value currently is.

Thanks for reporting this John, I can’t promise when I'll get to look at it but I will try!

Can't replicate this, but closing due to the age of the issue.


fix(TXL-399): Use contract abi to decode the amounts of token balance changes

Explanation

Use contract abi's to decode the amounts of token balance changes – instead of the raw output from a balanceOf call.

References

Fixes: https://github.com/MetaMask/metamask-extension/issues/26521

Changelog

@metamask/transaction-controller

FIXED: Use contract abi's to decode the amounts of token balance changes – instead of the raw output from a balanceOf call.

Checklist

[ ] I've updated the test suite for new or updated code as appropriate
[ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
[ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Accurate token amount and fiat price for vUSDC:

https://github.com/user-attachments/assets/131ea146-64dd-4a6a-95e2-db6cda7b823b


Add Date Range Filter to graphs

I think it would be a good addition to be able to change the date range that is displayed in the graphs. This could easily be done with D3 on the front-end. Right now the graphs are displaying so much data that it could be hard to pull valuable insights from them.

After resizing the graphs, the dates are no longer a problem.


Delayed::Job no longer defined in initializers

We have some initializers in our app that do schedule recurring jobs if they are not scheduled yet (using the delayed_job_cron gem under the hood), so basically code like this:
# config/initializers/recurring_jobs.rb

if Delayed::Job.where('handler LIKE "%SomeRecurringJob%"').blank?
  Delayed::Job.enqueue(SomeRecurringJob.new, cron: '* * * * *')
end

Since 4.1.5 this results in NameError: uninitialized constant Delayed::Job. Looking at the changes it is very probably due to https://github.com/collectiveidea/delayed_job_active_record/pull/172 which changed the requireing of the relevant code to only happen after initialization.

I can work around the issue by adding
require 'delayed/backend/active_record'
Delayed::Worker.backend = :active_record

at the beginning of the initializers, but that does not feel right.

I have a similar problem. I'm configuring the reserve_sql_strategy option as detailed in the readme:
https://github.com/collectiveidea/delayed_job_active_record/blob/001b24687ca146581cb7b075f4353ea99ed51f70/README.md#L30
This has been working till version 4.1.5 where it produces an error:
/my-rails-app/config/initializers/delayed_job.rb:3:in `<top (required)>': undefined method `configuration' for Delayed::Backend::ActiveRecord:Module (NoMethodError)

This seems related to the change in #172.

My initializers broke with uninitialized constant Delayed::Job too.
I've never used one, but I think we could move our initializer to be an after_initialize block. Just have to make sure it is defined after the Delayed Job railtie defines its after_initialize block. Looking at https://guides.rubyonrails.org/configuring.html#initialization-events, I don't see when my configs are run, so I'm not sure if an after_initialize added to my config file would run after theirs. Maybe I can simply define the after_initialize in my current initializer. Initializers are clearly run after gems are loaded and their railties are run.

Yep, this seems to work for me:
# config/initializers/delayed_job_extensions.rb
module DelayedJobExtensions
  # my customizations
end

- Delayed::Job.prepend DelayedJobExtensions
+ Rails.application.configure do
+   config.after_initialize do
+     Delayed::Job.prepend DelayedJobExtensions
+   end
+ end

No errors and my customizations are available in the console. I think you could do something similar.

I would be nervous simply adding a require to your initializer. Looking at https://github.com/collectiveidea/delayed_job_active_record/pull/172, you'll possibly reintroduce that issue to your app.

I forgot that change hadn't been released. I need to circle back and update the changelog and probably add more documentation.
If you can, wrap what you need to run in an after_initialize like @ansonhoyt suggests, that will be the safest bet and your block will run after DJ's because DJ's is setup when the Bundler.require(*Rails.groups) runs in application.rb.
If you can't use after_initialize,
require 'delayed/backend/active_record'
Delayed::Worker.backend = :active_record

will work, however make sure your initializer runs after any other ActiveRecord configuration initializers. The app initializers are usually run in alphabetical order by filename, so this can usually be accomplished by prefixing your initializer filename with z's like zzzzz_my_late_run_intializer.rb. There are a number of ActiveRecord configuration items that won't apply after ActiveRecord loading triggers and the rails team refuses to consider that a bug.

make sure your initializer runs after any other ActiveRecord configuration initializers. The app initializers are usually run in alphabetical order by filename, so this can usually be accomplished by prefixing your initializer filename with z's like zzzzz_my_late_run_intializer.rb. There are a number of ActiveRecord configuration items that won't apply after ActiveRecord loading triggers and the rails team refuses to consider that a bug.

Wouldn't something like this be a better way of accomplishing that?
ActiveSupport.on_load(:active_record) do
  require "delayed/backend/active_record"
  Delayed::Worker.backend = :active_record
end

ActiveSupport.on_load(:active_record) won't work reliably because that relies on something triggering ActiveRecord to load. If nothing triggers the load, DJ never gets setup.

Ugh - yeah, ok. Can't see it happening in production due to eager loads, but I guess it might cause problems in development.

I ran into this. This is a breaking change in a patch update. I'm not sure if the version numbers are locked to delayed_job but I definitely did not expect this update to break my app. I haven't fully grokked #172 so maybe this is a good path forward but probably some warning and documentation about breaking changes and the pros/cons of different fixes might be warranted.

I think this may have caused the following in my app when I upgraded from 4.1.4 to 4.1.5 last night: undefined method `where' for Delayed::Job:Class (NoMethodError)  Did you mean?  when. I'm adding this in case anybody else tries to search the error.
The error occurs in an initializer, so I added the block as suggested:
Rails.application.configure do
  config.after_initialize do
    # original code
  end
end

This seems to work (at least Rails will start now).

I think this may have caused the following in my app when I upgraded from 4.1.4 to 4.1.5 last night: undefined method `where' for Delayed::Job:Class (NoMethodError)  Did you mean?  when. I'm adding this in case anybody else tries to search the error.
The error occurs in an initializer, so I added the block as suggested:
Rails.application.configure do
  config.after_initialize do
    # original code
  end
end

This seems to work (at least Rails will start now).

This also broke for me in another way (but only in the production environment). I had a small utility class that inherited from Delayed::Job like this:
class JobReview < Delayed::Job
    # implementation
end

In development it loads fine, but in production this causes the unitialized constant issue. Obviously wrapping this the same as above for initializers doesn't make sense. I use this rarely, so for now I have just removed the class, but others may come across this if inheriting Delayed::Job for some reason.

This also broke for me in another way (but only in the production environment). I had a small utility class that inherited from Delayed::Job like this:
class JobReview < Delayed::Job
    # implementation
end

In development it loads fine, but in production this causes the unitialized constant issue. Obviously wrapping this the same as above for initializers doesn't make sense. I use this rarely, so for now I have just removed the class, but others may come across this if inheriting Delayed::Job for some reason.

Seconding/thirding the comments above. This may well be the ‘right’ change, I haven’t had a chance to properly digest the issue, but making a breaking change in a minor version bump is a bit much!

Seconding/thirding the comments above. This may well be the ‘right’ change, I haven’t had a chance to properly digest the issue, but making a breaking change in a minor version bump is a bit much!

Don't know if this will be helpful for all of you, but I had an initializer that broke with this update and I was able to find a relatively straightforward resolution as detailed in this issue: #188.

I'm also seeing this, but with the error:
NameError: uninitialized constant Delayed::DelayProxy::Job

This happens if you try to use #delay method to delay a method call.  I'm adding it to the thread for anyone else searching for the error.

Ok. I was hoping to come up with a better solution, but didn't, and time got away from me. I have pushed out 4.1.6 which only rolls back the loading change. Using after_initialize should not break with the update, but it will no longer be needed.


Change thaliedje queue template, only show 10 most recent requests and modal for requesting songs

@KiOui you probably know how to make website/thaliedje/templates/thaliedje/queue.html nicer and just hide the column if the API doesn't provide the data, instead of changing it in the template, right?
Also, it would be nice to only display the 10 most recent requests, and display a button to launch a modal showing the other requested songs

Good idea! Will do
Originally posted by @KiOui in https://github.com/KiOui/TOSTI/issues/297#issuecomment-1178962532

Is this still relevant?

Yes, kinda, with the new queue endpoint from spotipy


Possible to set task properties like continueOnError dynamically?

Hi,
I am trying to use variables to dynamically set task-properties like "continueOnError" and am unable to get this to work. I am not even sure if it´s possible to get this to work.
I am currently setting up a build pipeline based on YAML to reduce build times in pull requests by only building and testing the applications that have actual changes (based on git diff entries). The actual build job then uses a matrix and its value is a generated json-dictionary containing the applications that need to be build.
This looks something like this:
{
  "some_application_name": {
    "type": "netcore",
    "continueOnErrors": true,
    ...
  },
  "some_other_application_name": {
    "type": "nodejs",
    "continueOnErrors": false,
    ...
  }
}

This works pretty well and the build step replicates itself for each entry and executes successfully. I am able to access and use properties like the "type" in e.g. the condition property of tasks:
condition: and(succeeded(), eq(variables['type'], 'nodejs'))

However I am unable to set other task-properties like the initially mentioned "continueOnError" dynamically:
continueOnError: ${{ variables['continueOnErrors'] }}

or
continueOnError: ${{ eq(true, variables['continueOnErrors']) }}

The expression itself correctly returns true or false, e.g. through this test:
- powershell: Write-Host "Equals true";
  condition: eq(true, variables['continueOnErrors'])
- powershell: Write-Host "Equals false";
  condition: eq(false, variables['continueOnErrors'])

When running the pipeline the correct tasks trigger.
Trying to use runtime expansion returns an error saying the $-sign is unexpected:
continueOnError: $[variables['continueOnErrors']]

Is there anyway to achieve what I am trying?

My current workaround is duplicating the tasks and use the condition to run them with or without "continueOnError" but this causes some clutter as the changes need to be made twice and both tasks show up in the UI but only one is ever executed.
Example:
- powershell: |
    # Do something
  condition: and(succeeded(), eq(false, variables['continueOnErrors']))
  inputs:
    ...
- powershell: |
    # Do something
  condition: and(succeeded(), eq(true, variables['continueOnErrors']))
  continueOnError: true
  inputs:
    ...

Same workaround for me :-(
I wish we'll have someday consistent substitutions and notations in those pipelines...

After wasting too many hours, this seems to work in Azure DevOps:
continueOnError: ${{ ne(variables['Build.Reason'], 'PullRequest') }}

But I wish for you to have already moved on from DevOps - it's a truly terrible experience IMHO.


feat: feature flag eCharts

Overview
create the appKit context component, which will hold feature flags and any other future configurable aspects such as translations, theme, etc.
2 ways to use this new config:

wrap all your widgets in a provider. example: dashboard/src/components/dashboard/index.tsx. For now the provider accepts a customFeatureConfig which toggles feature flags
do nothing and use default values chosen by us :)

also created the following hooks:
useHasFeatureFlag (featureName) => boolean
useAppKitConfig () => config
example of config we could have in the future:
{
  featureConfig: {
    HAS_FEATURE_A: false,
    HAS_FEATURE_B: true
  },
  themeColors: {
    background: #...,
    mainText: #...
  }
};

Legal
This project is available under the Apache 2.0 License.

What are the next steps for getting this work in? :)

What are the next steps for getting this work in? :)

this needs to be rebased to the main...


Edit hdinsight-hive-analyze-website-log.md

Edit complete. Sending this to Nitin: In addition to my suggestions in the article, this link was broken. Please verify that I fixed it appropriately: Analyzing sensor data using Hive with HDInsight.

Hi @ClarityQueen, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-diree). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Waiting for Nitin's approval.


Fix wrap class

I was trying to fix a test spew about an unused variable and stumbled upon this string interpolation using a '.  I think this repo would benefit from rubocop being used to catch classes of bugs like this.
I'm not sure what this affects but I made the code into a shape that I think it was intended.

This looks like it was fixed in the dev branch.


fix the typos

Checklist (Please check before submitting)

[x] I reviewed the Contributing Guide.
[ ] I signed and emailed the appropriate Contributor License Agreement to<EMAIL_ADDRESS>and copied<EMAIL_ADDRESS>
Describe the contribution
A clear and concise description of what the contribution is.

Include explicitly what issue it addresses [e.g. Fixes #X]

Testing performed
Steps taken to test the contribution:

Build steps '...'
Execution steps '...'

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

API Change: xxx (if applicable)
Behavior Change: xxx (if applicable)
Or no impact to behavior

System(s) tested on

Hardware: [e.g. PC, SP0, MCP750]
OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

Note CLAs apply to only software contributions.

@howjmay Thank you for your contribution! Can you open issue and link it to this PR? Would you also be able to submit a CLA (and email the CLA to<EMAIL_ADDRESS>with<EMAIL_ADDRESS>cc'd)?
If you are doing this work as part of a company, you can use the corporate CLA here: https://github.com/nasa/cFS/blob/main/cFS_Framework_Corporate_CLA.pdf. If you're doing this on your own, you can use the individual CLA here: https://github.com/nasa/cFS/blob/main/cFS_Framework_Individual_CLA.pdf. See https://github.com/nasa/cFS/blob/main/CONTRIBUTING.md for more information. Thank you again!

26 January 2023: Ignoring while waiting on CLA.


⚠ Fortnite has degraded performance

In 64b368e, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1646 ms

Resolved: Fortnite performance has improved in 7ecd79b.


ComputeSlopeV2 + VerifyZeroV3 + BigIntToUint256  hints

Resolves #531
Resolves #552
Resolves #554

@cicr99  @har777  ready for review !
All 3 hints work properly, the integration test involves the usage of the 3 , it works as expected

@har777  i added a test for the hint that was wrong and was not tested. I get some SIGSEGV error for this file i simlified as much as i could:
func main{range_check_ptr: felt}() {
    // Bigint to uint
    let big_int = BigInt3(d0=9, d1=9, d2=9);

    let (uint256) = bigint_to_uint256(big_int);

    return ();
}

     Running....
        panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x104ec9550]
        ```

@cicr99  @har777  @MaksymMalicki  SIGSEGV error resolved, ready for final review

@har777  just added unit tests for BigIntToUint256. will wait for  #549  being merged to refactor ComputeSlopeV2

@har777  VerifyZeroV3 seems missing because i implemented it in another PR as well (because i needed it there) so it just disappeared in the diff. #552  is already closed

@har777  @cicr99  ready for review. There is no unit test for ComputeSlopeV2 because like ComputeSlopeV3, computation is already checked in ComputeSlope test case that uses ComputeSlopeV1 hint


Usage of ~ shouldn't flag TypeOperators as unused

In GHC 9.4 ~ is now a type operator, meaning we need to enable -XTypeOperators. However, HLint seems to be reporting this pragma as unnecessary

Do you have an example? HLint doesn't seem to report unused TypeOperator when ~ is used.

Ah, my bad! I think I did a find and replace to add TypeOperators to all modules in one of our libraries, and forgot that I needed to go back and clean it up! I think these warnings are correct


🧑🚀 Define 3 application personas

[ ] Record project size in CRM
[x] #57
[x] Decision tree to determine project size
[ ] CTF on Project Sizing
[ ] Update Spec Review template with a questionnaire / decision tree

Link to Clean Architecture Personas & Project Complexity PPT: https://sswcom.sharepoint.com/:p:/s/CleanArchitecturev2/EXBICIBrUl1CmWBOv5sj3BoBMW8A_rn2BTwX29i7SexaYA?e=4PaYho

@christoment is this a duplicate of #57 ?

Have closed #4 as the duplicate.

Have closed #4 as the duplicate.

I think what you meant is that you closed #57 😄

I've added more details to persona in the PPTX above - please have a look 😄
Also I've added quick decision tree app (it's a PoC)
https://architects-journey.vercel.app/
Regarding rest of the tasks:

Record project size in CRM

Thinking maybe we can utilise the CTF for people to add their project to CRM... Thoughts?

CTF on Project Sizing

I think we can use the above app for CTF content. For the rule, I haven't made the rule yet, pending for SAW to approve the personas.

Update Spec Review template with a questionnaire / decision tree

Once we are all agreed on the persona and the tree, I can arrange to update this.
@danielmackay @william-liebenberg can you please have a look? 😄

Thinking maybe we can utilise the CTF for people to add their project to CRM... Thoughts?

@christoment  - There might be some difficulties here for larger projects where many people are trying to update the CRM for the same project.  How about we get people to size their project in the CTF, and someone can average out the sizes and update in CRM after?

@christoment - I've reviewed the PPT, but I think it would be good to review as a team.  Can you setup a 1 hour meeting for this?

@christoment - any update on this?

@danielmackay sorry no update yet on this... Full on client work at the moment, will try to send a review request to everyone before and then arrange a meeting when I'm booked on this

Persona is now defined with the decision tree.
It is also paired with an PoC app to make the decision tree (thinking to integrate it with the spec review process later down the line) https://architects-journey.vercel.app/
All other documentations are in the slides :)
Closing this issue and marking it as done


Finish porting parallel coordinates to react-vis

The work was started here: https://github.com/wandb/client/tree/feature/parcoor
We need to hookup highlighting, CSS, and the custom d3.brushes on the columns as is implemented in https://github.com/wandb/client/blob/feature/parcoor/wandb/board/ui/src/components/PanelParallelCoord.js
The legacy component uses d3 version 3 and the brush API has changed: https://github.com/d3/d3/blob/master/CHANGES.md#brushes-d3-brush

@shawnlewis originally implemented this and mentioned that the react-vis implementation of parallel coordinates wasn't very performant.  It might be a better approach to port the existing component to d3 version 4, regardless the brush logic will need to be written in v4 so that's a good place to start.

Yeah I think staying in d3 might be better but feel free to experiment.
Sorry the code is pretty terrible, it was the result of a hackathon and has
never been cleaned up.
On Tue, Feb 20, 2018 at 9:39 PM Chris Van Pelt<EMAIL_ADDRESS>wrote:

@shawnlewis https://github.com/shawnlewis originally implemented this
and mentioned that the react-vis implementation of parallel coordinates
wasn't very performant. It might be a better approach to port the existing
component to d3 version 4, regardless the brush logic will need to be
written in v4 so that's a good place to start.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wandb/client/issues/129#issuecomment-367219652, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAeet0eHZsTu87wz-HAH5lGs_DBO98Vbks5tW6wsgaJpZM4SJgm9
.

@thekatic there's a pull request open with comments about what needs to be added.

@vanpelt I've pushed new commit for this pull request.


final url when using {:follow-redirects :always} ?

Hello
Where could I find the final url when redirects occur?
(http/get "https://httpstat.us/302" {:client (http/client {:follow-redirects :always})})
:uri is the original url
:uri #object[java.net.URI 0x7a729f84 "https://httpstat.us/302"]
Using haop :uri contains teh final url
Thanks in advance
Matteo

@matteoredaelli I don't know where you get the :uri value from. Can you give a more full repro where this is unambiguously clear?

With hato I get the final url in this way
user=> (require '[hato.client :as hc])
nil
user=> (:uri (hc/get "https://pirelli.com/"  {:http-client {:redirect-policy :always}}))
"https://www.pirelli.com/global/en-ww/homepage/"

With this library how could I get it?
user=> (require '[babashka.http-client :as http])
nil
user=> (:uri (http/get "https://pirelli.com/" {:client (http/client {:follow-redirects :always})}))
nil

Thanks in advance

Fixed. Do you need a release?

no, thanks!

Made one anyway: 0.4.14


Release Flatcar Container Linux Alpha 4116.0.0, Beta 4081.1.0, Stable 3975.2.2

The release of the following Flatcar Container Linux version is planning October 10th, 2024.

Alpha 4116.0.0
Beta 4081.1.0
Stable 3975.2.2

1. Preparation
Owner: @dongsupark

[x] A. Go/No-Go hackmd doc created from HackMD template for test tracking and release notes: (https://hackmd.io/CLDLX-ntRTmvn6RKWk16OA?view)
[ ] B. All planned changes are merged & blocker bugs are fixed, last nightly reviewed for problems.
[x] C. Check that the kernel PR are merged for the channel(s) to be released.

2. Build
Owner: @dongsupark

[ ] A. Branched off the main branch (only for new major).
[ ] B. Tagged all the build branches.
[ ] C. Started the Jenkins builds, post the links into this issue as comment.

3. Release
i. The Go/No-Go Meeting
Owner:

[ ] A. Test status captured in the HackMD document.
[ ] B. All tests are Green.
[ ] C. Release notes / announcements added to Go/No Go doc from container/image_changes job by selecting Timestamps: None.
[ ] D. QA: Checked the diff for image file list, packages, and image size in the container/image_changes job output.
[ ] E. Conduct Matrix Go/No Go meeting (inc. release notes review).

ii. Artifacts goes public
Owner:

[ ] A. Created the Release Notes on the scripts repo for the respective tags on GitHub as GitHub Releases.
[ ] B. Ran the container/release Release job.
[ ] C. Images uploaded with copy-to-origin.sh.
[ ] D. Symlink to "current" updated with set-symlink.sh.
[ ] E. Website updated with ./update-flatcar-versions.sh and PR merged.

iii. Payload
Owner:

[ ] A. Update payload signed/uploaded.
[ ] B. Release package published in Nebraska (Prerequisite: 3.ii.E should marked done).

iv. Cloud Marketplace & Cluster API
Owner:

A. Azure

[ ] Offers updated and started publishing.
[ ] Sent the offers to publish to Live.

B. GCP

[ ] Offer deployment package uploaded to Google Bucket & submit for verification.
[ ] Offer Publish

C. Cluster API for new Stable

[ ] Azure: Manually run ./azure-sig.sh to create New Shared Community Gallery Images
[ ] OpenStack: documentation

4. Announcements
Owner:

[ ] A. Sent announcement to Mailing Lists
[ ] B. Sent Tweet out to X (Twitter), and Toot out to Mastodon
[ ] C. Brief version announcement in slack (k8s slack #flatcar) and the Flatcar Matrix channel

Alpha 4116.0.0 - http://localhost:8080/job/container/job/sdk/1775/cldsv/
Beta 4081.1.0 - http://localhost:8080/job/container/job/packages_all_arches/4808/cldsv/
Stable 3975.2.2 - http://localhost:8080/job/container/job/packages_all_arches/4807/cldsv/


Customize PAGE_URL like PAGE_SAVE_AS

When these are inconsistent that can lead to problems as documented at https://docs.getpelican.com/en/stable/settings.html#url-settings
I'm interested in this for https://github.com/apache/www-site/issues/178

I think that the only reason not to merge this would be for projects using slugs to set their page URLs. I don't know off the top of my head exactly how many use slugs to generate page URLs but I imagine that it could cause issues with the build process.

I imagine that it could cause issues with the build process.

Thanks for sharing - I tested this with www-site, which uses slugs for for example https://www.apache.org/board/plan and https://www.apache.org/board/policies .
Even without this change, testing the site locally with docker run -it -p8000:8000 -v $PWD:/site pelican-asf and browsing to http://localhost:8000/board/plan does not show the page, so I clearly don't understand how/when slugs are applied yet ;).
This indeed makes it pretty plausible the slug also isn't taken into account for the PAGE_URL/page.url yet. Converting to draft until I've had time to dig into this further.

since https://github.com/apache/www-site/issues/178 was closed I think we can close this for now as well


Issue 231 - EMT GFM VSC corrections

Pull requests for the EMT Grid Forming VSC model

Hi Carlos. Could you please check the paths of the figures? They do not appear correctly on my side

Hi, same here. I can see everything correctly (at least locally). Please, send me a screenshot so I can check what can be wrong


Removing the public link password is broken

ownCloud Web UI 5.7.0-rc.5
ocis: 2.0.0-beta.5
Steps:

Katherine creates project space "first" and shares it via public link "link1"
Katherine set password "pass"

Actual: public can open link

Katherine removes password "pass"
Public try to open public link

Expected: public should open link without password
Actual: old password does not work. blank password does not work. Backend issue, I created a api test for this
PS: It's not just in project space
https://user-images.githubusercontent.com/84779829/180476338-b0a3fe41-4dbe-40b3-9497-fa0f2dec1bf7.mov

Also see https://github.com/owncloud/web/issues/7307
Should have been fixed by https://github.com/cs3org/reva/pull/3094
It might need pulling into oCIS.

Re-tested after bump reva to ocis master. It works correct. I removed tests from expected failures

Note: the API test still fails on the "old" Public WebDAV API. But that "old" Public WebDAV API is not supported on oCIS. We should not be running that scenario example on oCIS. See issue #2079
The entry is still in expected-failures in both reva edge and ocis repos.
I will adjust the API test suite - see https://github.com/owncloud/core/pull/40247


Interfacing with KernelAbstractions

Hi,
the following issue occurred with a code using KernelAbstractions.jl.
I could probably reduce it to a minimal KernelAbstractions example but this fails too:
julia> using DifferentiationInterface, Mooncake

julia> using RadonKA

julia> x = rand(32, 32, 1);

julia> angles = range(0, 2π, 100);

julia> radon(x, angles);^C

julia> f(x) = sum(radon(x, angles));

julia> f(x)
35091.5054103222

julia> value_and_gradient(f, AutoMooncake(config=nothing),      x)
ERROR: No rrule!! available for foreigncall with primal argument types Tuple{Val{:jl_new_task}, Val{Ref{Task}}, Tuple{Val{Any}, Val{Any}, Val{Int64}}, Val{0}, Val{:ccall}, KernelAbstractions.var"#20#23"{KernelAbstractions.Kernel{KernelAbstractions.CPU, KernelAbstractions.NDIteration.DynamicSize, KernelAbstractions.NDIteration.DynamicSize, typeof(RadonKA.cpu_radon_kernel!)}, Tuple{Int64, Int64, Int64}, KernelAbstractions.NDIteration.NDRange{3, KernelAbstractions.NDIteration.DynamicSize, KernelAbstractions.NDIteration.DynamicSize, CartesianIndices{3, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}, Base.OneTo{Int64}}}, CartesianIndices{3, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}, Base.OneTo{Int64}}}}, Tuple{Array{Float64, 3}, Array{Float64, 3}, Vector{Float64}, Vector{Float64}, Vector{Float64}, Vector{Float64}, Float64, Float64, RadonKA.var"#5#6"{Float64}, Nothing}, KernelAbstractions.NDIteration.DynamicCheck, Int64}, Base.GenericCondition{Base.Threads.SpinLock}, Int64, Int64}. This problem has most likely arisen because there is a ccall somewhere in the function you are trying to differentiate, for which an rrule!! has not been explicitly written.You have three options: write an rrule!! for this foreigncall, write an rrule!! for a Julia function that calls this foreigncall, or re-write your code to avoid this foreigncall entirely. If you believe that this error has arisen for some other reason than the above, or the above does not help you to workaround this problem, please open an issue.
Stacktrace:
  [1] rrule!!(::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…})
    @ Mooncake ~/.julia/packages/Mooncake/TQO5a/src/rrules/foreigncall.jl:12
  [2] __run
    @ ~/.julia/packages/KernelAbstractions/iW1Rw/src/cpu.jl:98 [inlined]
  [3] (::Tuple{…})(none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…})
    @ Base.Experimental ./<missing>:0
  [4] (::Mooncake.DerivedRule{…})(::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…})
    @ Mooncake ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:882
  [5] (::Mooncake.DynamicDerivedRule{…})(::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…})
    @ Mooncake ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:1669
  [6] #_#16
    @ ~/.julia/packages/KernelAbstractions/iW1Rw/src/cpu.jl:40 [inlined]
  [7] (::Tuple{…})(none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual)
    @ Base.Experimental ./<missing>:0
  [8] DerivedRule
    @ ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:882 [inlined]
  [9] _build_rule!(rule::Mooncake.LazyDerivedRule{…}, args::Tuple{…})
    @ Mooncake ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:1748
 [10] LazyDerivedRule
    @ ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:1708 [inlined]
 [11] _radon
    @ ~/.julia/packages/RadonKA/FXHjL/src/radon.jl:136 [inlined]
 [12] (::Tuple{…})(none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…})
    @ Base.Experimental ./<missing>:0
 [13] DerivedRule
    @ ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:882 [inlined]
 [14] _build_rule!(rule::Mooncake.LazyDerivedRule{…}, args::Tuple{…})
    @ Mooncake ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:1748
 [15] LazyDerivedRule
    @ ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:1708 [inlined]
 [16] radon
    @ ~/.julia/packages/RadonKA/FXHjL/src/radon.jl:123 [inlined]
 [17] (::Tuple{…})(none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…}, none::Mooncake.CoDual{…})
    @ Base.Experimental ./<missing>:0
 [18] (::Mooncake.DerivedRule{…})(::Mooncake.CoDual{…}, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…})

    @ Base.Experimental ./<missing>:0
 [22] DerivedRule
    @ ~/.julia/packages/Mooncake/TQO5a/src/interpreter/s2s_reverse_mode_ad.jl:882 [inlined]
 [23] __value_and_pullback!!(::Mooncake.DerivedRule{…}, ::Float64, ::Mooncake.CoDual{…}, ::Mooncake.CoDual{…})
    @ Mooncake ~/.julia/packages/Mooncake/TQO5a/src/interface.jl:14
 [24] value_and_pullback!!(::Mooncake.DerivedRule{Tuple{…}, MistyClosures.MistyClosure{…}, Mooncake.Pullback{…}, Val{…}, Val{…}}, ::Float64, ::Function, ::Array{Float64, 3})
    @ Mooncake ~/.julia/packages/Mooncake/TQO5a/src/interface.jl:119
 [25] value_and_pullback(::Function, ::DifferentiationInterfaceMooncakeExt.MooncakeOneArgPullbackPrep{…}, ::AutoMooncake{…}, ::Array{…}, ::Tuple{…})
    @ DifferentiationInterfaceMooncakeExt ~/.julia/packages/DifferentiationInterface/gSdHF/ext/DifferentiationInterfaceMooncakeExt/onearg.jl:36
 [26] prepare_pullback(::Function, ::AutoMooncake{Nothing}, ::Array{Float64, 3}, ::Tuple{Bool})
    @ DifferentiationInterfaceMooncakeExt ~/.julia/packages/DifferentiationInterface/gSdHF/ext/DifferentiationInterfaceMooncakeExt/onearg.jl:22
 [27] prepare_gradient(::typeof(f), ::AutoMooncake{Nothing}, ::Array{Float64, 3})
    @ DifferentiationInterface ~/.julia/packages/DifferentiationInterface/gSdHF/src/first_order/gradient.jl:70
 [28] value_and_gradient(::typeof(f), ::AutoMooncake{Nothing}, ::Array{Float64, 3})
    @ DifferentiationInterface ~/.julia/packages/DifferentiationInterface/gSdHF/src/fallbacks/no_prep.jl:60
 [29] top-level scope
    @ REPL[63]:1
Some type information was truncated. Use `show(err)` to see complete types.

(@enzyme) pkg> st
Status `~/.julia/environments/enzyme/Project.toml`
  [052768ef] CUDA v5.5.2
  [a0c0ee7d] DifferentiationInterface v0.6.23
  [7da242da] Enzyme v0.13.16
  [da2b9cff] Mooncake v0.4.51
  [86de8297] RadonKA v0.6.2

Thanks for opening this! This looks to me like the problem is Task-related. This makes sense to me, because Mooncake's ability to handle tasks is currently rather limited.
Am I interpreting the above correctly that your current code shouldn't involve any GPU code?

Right now it's all CPU based but in future I'd like to use GPUs (and in fact with Enzyme this also works -> But slower than my custom written gradients)

Cool.
Unfortunately I don't know when I'm going to be able to resolve this. Properly handling Tasks is one of my larger outstanding todo items in Mooncake at the minute.
You mention that you have custom gradients -- are these in the form of ChainRulesCore.rrules? If so, do the KernelAbstractions calls happen inside of them?


Fix payment can not refunded if payment can also be captured

For example, I have pre-authorized $10, and I capture only $6. Then for this payment, it can also be captured again (since there are still pre-authorized $4 ) and also be refunded (since there are $6 which is captured)
This PR fixes this issue in dashboard.
Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.

You bet, another issue for tracking that will be nice.


fix various broken links in articles

fixes issue 19067 - [Mixins] Dead Link to template-mixin

Rebased to get DAutoTest on board. I've also fixed an oversight by amending. I think this is ready to go now.


Host crd: Fix insecure Route action

Description
Host crd: Fix insecure Route action
For each listener, there will be one envoy filter per server_names
and also an envoy filter with empty filter_chain.
For http, the envoy filter_chain by server_names has no effect.
This is only for SNI and https.
So for the http listener, only the first envoy filter is used.
So, when the first vhost is redirecting, all the http traffic will be redirected.
When the first vhost is routing http traffic, all the http traffic will be routed, no redirection.
The fix is checking per route, within the vhost loop,
if there is a corresponding "Host" crd for the route having the hostname.
If so, it applies the action based on the Host CRD and not based on the vhost currently processed.
Related Issues
https://github.com/datawire/ambassador/issues/2216
Testing
manual tests

Any chance to have this reviewed?

Not stale.

Not stale.

Not stale

After a number of issues in the area of how the various actions of various Hosts interact with each other, we're in the middle of digging deep into this and cleaning it all up. I'm going to close this one since it's doomed to millions of confilcts, but @jfrabaute, many thanks for the effort, and we've definitely studied this PR and learned from it -- be looking for a shout out when we land the cleanup. 🙂


sxml

Experiment with generating markdown with sxml.
One goal is to make specifying markdown for exercises uniform and automated. Eg, including a how-to for running the tests will be easy to extend and customize on a per problem basis.
This pull request also adds comments in track.ss and renames some of the stub/build/test functions to have uniform names.

This is looking pretty cool.
There is a document somewhere that specifies what formatting we are allowed to use in the README.md files.  Looking at the files you have made here I think everything is fine, but I'm trying to find it, so we can tell for sure.
I think there are some specifications like, each sentence should be on it's own line in the markdown representation, and we are allowed to use a certain range of header sizes, numbered and bulleted lists, etc...
I think markdown tables are off limits :rofl:
Anyway, I just wanted you to be aware that there is some sort of imposed standard, and I will link it here when I find it.

Yeah, the sentence per line is baked in to the current implementation, by tagging with (sentence "some string"). You can verify the output in the docs/ABOUT.md file. I also added proper escaping (it seems like github flavored markdown usually figures things out anyway though)

This is subsumed by #109


Run appropriate query operations when replacing documents

Q
A

Type
bug

BC Break
no

Fixed issues
Fixes #1981

Summary
This ensures that when not using update operators, the query does not attempt to run an updateOne or findOneAndUpdate operation. Instead, the replaceOne or findOneAndReplace operation must be run to avoid errors.
When using the "multiple" option on an update query in combination with a replacement document, the query class will now throw an error as there is no replaceMany functionality.

Looks A-OK but shouldn't the tests actually assert the correct command is ran? Or would the library complain otherwise?

This is where it gets interesting: the actual command run is always update - this is just the high-level API that MongoDB provides. So while I could use a command listener to check the command, the absence of an error is all the assertion we can have at the moment.

👌


Controlling Homekit enabled devices

Not yet supported by the server, will reopen when the server has the capability.


feat(DDI-1084): Adding typeValidation to components

Added typeValidation to all properties having multiple values

:tada: This PR is included in version 4.0.0-alpha.100 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.140 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.19 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-alpha.11 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add cookie notification

Nice first draft, expanded it a little and redid the service. See: #349f678


Compare the results of two different test runs

Is your feature request related to a problem? Please describe.
There is no native way to compare the results of two different test runs.
I would love to know if my latest change is going to worse the performance of my service, or if it's going to break something.
Also, when I run k6 on CI, I would like to comment back on each PR with the diff between the PR and master, the same way I do with coverage tools.
Describe the solution you'd like
I would like to have a compare command in k6. Nothing fancy! Just compare two JSON summaries, and beautifully print the diff between them.
Some things should be customizable, like the percentage change on which a metric is "important" (we don't want to pollute the output with 0.1% changes).
Another option (?), now that we have the handleSummary() callback is to add this at the script level. This way you can compare this run with a past run (that you can load via file).
Describe alternatives you've considered
I wrote a small script that does something "similar".
# diff.py
# requirements: Python 3.8.3 and deepdiff==5.2.2
from deepdiff import DeepDiff
from json import load

TOP_PERCENT_THRESHOLD = 20
BOTTOM_PERCENT_THRESHOLD = -20
BASELINE_FILE = "baseline.json"
RUN_FILE = "run.json"

print(f"Comparing {BASELINE_FILE} with {RUN_FILE}")
print(f"Percent Threshold: from {TOP_PERCENT_THRESHOLD} to {BOTTOM_PERCENT_THRESHOLD}")
print("-" * 60)

with open(BASELINE_FILE) as baseline, open(RUN_FILE) as run:
    data_baseline = load(baseline)
    data_run = load(run)

    result_diff = DeepDiff(data_baseline, data_run, ignore_order=True)

    for _, metric_name in enumerate(result_diff["values_changed"]):
        new_value = result_diff["values_changed"][metric_name]["new_value"]
        old_value = result_diff["values_changed"][metric_name]["old_value"]
        percent_change = 100 * (new_value - old_value) / old_value
        if percent_change > TOP_PERCENT_THRESHOLD:
            print(f"{metric_name} -> {round(old_value, 6)} ++ {round(new_value, 6)}")
        if percent_change < BOTTOM_PERCENT_THRESHOLD:
            print(f"{metric_name} -> {round(old_value, 6)} -- {round(new_value, 6)}")

Results:
➜  python diff.py
Comparing baseline.json with run.json
Percent Threshold: from 20 to -20
------------------------------------------------------------
root['metrics']['http_req_receiving']['min'] -> 0.086011 -- 0.04834
root['metrics']['http_req_receiving']['p(95)'] -> 0.759464 ++ 0.917917
root['metrics']['http_req_blocked']['max'] -> 130.380219 ++ 162.900105
root['metrics']['http_req_blocked']['p(95)'] -> 121.592829 ++ 157.314519
root['metrics']['http_req_blocked']['p(90)'] -> 118.183842 ++ 152.276601
root['metrics']['http_req_blocked']['avg'] -> 13.628404 ++ 17.557079

I expanded a tiny bit on @dgzlopes' idea that he wrote in Python, but I used vanilla JS. But I have a different idea I will work on as a k6 extension.
https://github.com/mostafa/k6-test-diff

@mostafa, you don't need xk6-file to write files from handleSummary(), see https://k6.io/docs/results-visualization/end-of-test-summary#customize-with-handlesummary

@na-- Does it mean that I can write as many files as I want? Or is it just one?

The result of handleSummry() is a JS object where the keys are file paths (or strout / stderr, as special cases) and the values are file contents. You can return as many elements in that object as you want :man_shrugging:

@na-- Then I definitely don't need the xk6-file extension. 😄


/ is highlighting popup inner text (Neovim only)

summary
In using / search, highlighted popup inner text.
environment
Neovim 0.6.0 (nightly)
minimal init.vim
set runtimepath^=~/repos/github.com/vim-denops/denops.vim
set runtimepath^=~/repos/github.com/Shougo/pum.vim
set runtimepath^=~/repos/github.com/Shougo/ddc.vim
set runtimepath^=~/repos/github.com/Shougo/ddc-around
set runtimepath^=~/repos/github.com/Shougo/ddc-matcher_head
set runtimepath^=~/repos/github.com/Shougo/ddc-sorter_rank

function! s:ddcinit() abort
  call ddc#custom#patch_global('sources', ['around'])

  call ddc#custom#patch_global('completionMenu', 'pum.vim')
  call ddc#custom#patch_global('backspaceCompletion', v:true)
  call ddc#custom#patch_global('autoCompleteEvents',
        \ ['InsertEnter', 'TextChangedI', 'TextChangedP'])
  call ddc#custom#patch_global('sources', ['around'])
  call ddc#custom#patch_global('sourceOptions', {
        \ '_': {
          \   'matchers': ['matcher_head'],
          \   'sorters': ['sorter_rank']},
          \ })

  call ddc#enable()
endfunction

autocmd User DenopsReady call s:ddcinit()

Oh, I cannot disable the feature in plugin side...

minimal style should disable the highlight.
It seems neovim's bug.

In neovim, You can use this solution. set winhighlight=Search:None

Oh, Thanks!

Fixed.


Django 2.0 support

Fixes #4

Coverage decreased (-1.02%) to 98.985% when pulling 21eed1ea5f4750a36fa779b75b4110db4205578f on moggers87:django-2.0 into 7c4c23238421eefcedc93e7205fe506d06e1ee8b on justinmayer:master.

Coverage decreased (-1.02%) to 98.985% when pulling 21eed1ea5f4750a36fa779b75b4110db4205578f on moggers87:django-2.0 into 7c4c23238421eefcedc93e7205fe506d06e1ee8b on justinmayer:master.

Coverage decreased (-1.02%) to 98.985% when pulling 21eed1ea5f4750a36fa779b75b4110db4205578f on moggers87:django-2.0 into 7c4c23238421eefcedc93e7205fe506d06e1ee8b on justinmayer:master.

Coverage decreased (-1.02%) to 98.985% when pulling 21eed1ea5f4750a36fa779b75b4110db4205578f on moggers87:django-2.0 into 7c4c23238421eefcedc93e7205fe506d06e1ee8b on justinmayer:master.

Coverage decreased (-1.02%) to 98.985% when pulling 21eed1ea5f4750a36fa779b75b4110db4205578f on moggers87:django-2.0 into 7c4c23238421eefcedc93e7205fe506d06e1ee8b on justinmayer:master.

Coverage decreased (-1.02%) to 98.985% when pulling 21eed1ea5f4750a36fa779b75b4110db4205578f on moggers87:django-2.0 into 7c4c23238421eefcedc93e7205fe506d06e1ee8b on justinmayer:master.

Coverage decreased (-1.02%) to 98.985% when pulling 21eed1ea5f4750a36fa779b75b4110db4205578f on moggers87:django-2.0 into 7c4c23238421eefcedc93e7205fe506d06e1ee8b on justinmayer:master.

Coverage decreased (-1.02%) to 98.985% when pulling 21eed1ea5f4750a36fa779b75b4110db4205578f on moggers87:django-2.0 into 7c4c23238421eefcedc93e7205fe506d06e1ee8b on justinmayer:master.

Oh, I guess @coveralls doesn't combine all the coverage data that we send :/


Travis Build Python 2.6, Maybe?

All official testing I've done has been with versions of 2.7. Theoretically, from my reading of docs code should work for Python 2.6-> 2.7.9.
Works So Far:

2.7.6

PPA with 2.6.9 - > https://launchpad.net/~fkrull/+archive/ubuntu/deadsnakes?field.series_filter=trusty

From Travis

Travis CI virtual machines are based on Ubuntu 12.04 LTS Server Edition 64 bit, with the exception of Objective-C builds, which runs on Mac OS X Mavericks.


Update redis dependency to v8 and test it

We have Redis support, so we need to check changes there from v6 to v8 (shouldn't be a lot for our trivial use case, but still), update dependency and test it. Refs. #2087.
I'm not sure anyone is using it though.

Related #2195 .


Test PR workflow

Task/Issue URL: https://app.asana.com/0/1202552961248957/1202798538526951/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2177   👈

This comment was auto-generated by Graphite.


Code clean-up in client_channel.

Replace an enum with a bool and split the code for canceling a pick into its own function.
No functional changes here.

I'd like to see the bm_diff before approving (pending #10852)

Jenkins: test this please

No significant performance differences

No significant performance differences

No significant performance differences

This should fix #10945.

Jenkins: test this please

Known failures: #9542 #10936 #10839 #10962

Hi I'm using gcc 4.8.4 and the lates 1.4.x branch got:
src/core/ext/filters/client_channel/client_channel.c: In function ‘lookup_external_connectivity_watcher’:
src/core/ext/filters/client_channel/client_channel.c:1459:40: error: declaration of ‘on_complete’ shadows a global declaration [-Werror=shadow]
src/core/ext/filters/client_channel/client_channel.c:1243:13: error: shadowed declaration is here [-Werror=shadow]
is it a related bug or it has somthing to with my own cofiguration?
gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/i686-pc-linux-gnu/4.8.4/lto-wrapper
Target: i686-pc-linux-gnu
Configured with: ../configure --enable-checking=release --enable-languages=c,c++ --disable-multilib
Thread model: posix
gcc version 4.8.4 (GCC)

@Zazakas, that looks like it's a code portability problem, not something related to your configuration, although I'm somewhat mystified as to how that could happen, because our portability checks should have prevented it.  @dgquintas may know more.
In any case, I don't think this is related to this PR, so I suggest filing a separate bug about it.


fix typo in cfep09

No biggie, but update date is assumed to be after creation date.
I assumed a typo in the year.

Thanks!


Colored miniFabIcon

I need to set my own colored icons in the VectorDrawable format as a miniFab. But correctly it turns out to install only black and white. How to do it???

@SergeyAppDroid Are you trying to color the individual drawables inside the miniFabs or are you trying to color the miniFabs themselves?


Scanner/Value interface

Hello, I am trying to implement a custom type, I've attempt to use a valuer scanner interface for it
eg:
type JSON json.RawMessage

type NullJSON struct {
	JSON  JSON
	Valid bool
}
func (n *NullJSON) Scan(value interface{}) error {
	if value == nil {
		n.JSON, n.Valid = nil, false
		return nil
	}
	n.Valid = true
	return n.JSON.Scan(value)
}
func (n *NullJSON) Value() (driver.Value, error) {
	if !n.Valid {
		return nil, nil
	}
	return n.JSON.Value()
}

Bun however attempts to use its own marshaling from schema/append_value.go, Is there a cleaner way to implement custom marshaling types in models?

Please see https://github.com/uptrace/bun/tree/master/example/custom-type and provide a similar example that I can run to reproduce the issue.

@vmihailenco I've looked into it and the problem relates to defining the type in bun
type Model struct {
	bun.BaseModel `bun:"table:tablename"`
	Data  utypes.NullJSON `json:"source_entity,omitempty" bun:"data,type:jsonb"`
}

Would yield {JSON: "payload"} in the Data column
While removing type:jsonb would yield payload
I think the reason is that this does check if *Field implements value scanner before coverting it directly to []byte:
switch strings.ToUpper(field.UserSQLType) {
	case sqltype.JSON, sqltype.JSONB:
		return AppendJSONValue
	}

You are right. We probably should re-order the code to give Scanner/Valuer priority.

@vmihailenco Do you still need example code for it?
Not sure if it's a complicated fix, I would have just put a check there if field implements Scanner/Value and if so skip returning AppendJSONValue, but I dont know what meshes nicely with the overall architecture of bun

I think this should be fixed by https://github.com/uptrace/bun/pull/386


Add tunnel and tunneld binaries for other platforms

Should occur on tag

In favor of https://github.com/coder/wgtunnel/pull/17


Adding app-shell breaks down lazy loading on server-side

Versions
Angular CLI: 1.6.4
Node: 8.9.1
OS: win32 x64
Angular: 5.2.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

@angular/cli: 1.6.4
@angular-devkit/build-optimizer: 0.0.38
@angular-devkit/core: 0.0.25
@angular-devkit/schematics: 0.0.48
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.4
@schematics/angular: 0.1.13
@schematics/schematics: 0.0.13
typescript: 2.5.3
webpack: 3.10.0

Repro steps

git clone git@github.com:krivochenko/lazy.git
npm install
build:ssr
serve:ssr - on this step everything works fine. Including server-side rendering with lazy loading. There isn't errors  in console of server.
ng generate app-shell --universal-app universal
build:ssr
serve:ssr

Observed behavior
Server-side rendering doesn't work (in source code of page I see only router-outlet). In console of server I get error:
Cannot find module 'app/pages/contacts/contacts.module.ngfactory'

Desired behavior
I expect server-side rendering work without errors.
Mention any other details that might be useful (optional)
I created simple repo for reproduction of issue by following steps:

ng new lazy --service-worker --routing
adding HomeComponent and ContactsComponent for checking lazy loading
adding universal followed with guide

Thanks for help

Hi,
I have investigated this issue to a degree. I also cannot find any way of using app-shells with Universal...
Sorry i wrote a novel, feel free to skip down to the solutions
Conflict:

Prerendering the app shell is done with the app server module
The ModuleMapLoaderModule requires a module map, without it the app shell wont render
It seems extraProviders during bootstrap are the bottom layer of providers

Providing a dummy module map or the app shell rendering will fix that but break lazy loaded routes on the server as mentioned by @krivochenko

Solutions:

Yes, you can have a normal server app with an app shell route and have the ngsw-config point to the route with the app shell instead of index.html

When someone installs a version of the PWA, it will go to the server rendered route and you will have your app shell
You can do this today but it's a little wasteful to have the server generate it at request time
It should be possible to prerender the app shell at build time AND server render

You can write your own post process script to render the app shell but this is what the CLI intends to do for you
These are possible solutions for the CLI

When rendering the app shell, it provides a dummy module map.

This should be the simplest/ easiest solution but it adds a (Angular team controlled) dependency to the CLI

The ModuleMapNgFactoryLoader is modified to have the module map be optional so that DI doesn't break

I had some trouble with this having a null module map even though one was provide in extraproviders in the server executable
This also isn't exactly kosher because the module map is pretty much require for the provider to work

@krivochenko Your solution should work, if you need an example, let me know
@hansl @Brocco Should we pursue providing a dummy moule map here?
It would look like
    const html = await renderModuleFactory(AppServerModuleNgFactory, {
        url: options.url,
        document: index,
        extraProviders: [
            provideModuleMap({})
        ]
    });

@Brocco you mentioned that app shell feature in CLI is not documented when we spoke in ng-atl.  Can you tell me what is the process to get that documented?  Thanks.

Any update on this? So lazy load caching doesn't work with service workers?

I looked into this and the problem is that when using the RouterModule.forRoot() in app.server.module.ts NgModuleFactoryLoader is not being provided as ModuleMapNgFactoryLoader from @nguniversal/module-map-ngfactory-loader but rather NgModuleFactoryLoader from @angular/core as the RouterModule is bootstrapped in prior to ModuleMapLoaderModule
To fix this one need to add the following in AppServerModule so that the provider is updated across the board;
  providers: [{
    provide: NgModuleFactoryLoader,
    useClass: ModuleMapNgFactoryLoader
  }],

That said, this only works with the latest packages of the dependencies.
Created an example repo here: https://github.com/alan-agius4/universal-lazy-loading-app-shell

@alan-agius4 - The provider should be used at the platform providers level and not the ServerAppModule
https://github.com/angular/universal-starter/blob/master/server.ts#L28

@vikerman that does work as well. Thanks for your input

@alan-agius4 your solution does not work for me. I keep getting the error: Cannot find module 'app/pages/contacts/contacts.module.ngfactory'

I solve my problem doing the following:
ng run my-app:app-shell:production
sed -i -e "s/RouterModule.forRoot/\\/\\/ RouterModule.forRoot/g" path/to/app.server.module.ts
ng run my-app:server
sed -i -e "s/\\/\\/ RouterModule.forRoot/RouterModule.forRoot/g" path/to/app.server.module.ts

Hi @csbenjamin, please note that this issue is closed.
If this issue is still happening even with changes stated in the documentation, please open a new issue with a minimal reproduction and a step by step guide. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

@alan-agius4 Thanks for the reply. Here is the new issue
https://github.com/angular/angular-cli/issues/12921
There I put a repo as you ask
https://github.com/csbenjamin/app-shell-plus-univeral-plus-lazy-routing


Update python interoperability link

LGTM. As a side thought, we should make sure to add the false positives on spell check to cspell.json (e.g.: qrng).


Docker setup issues in production pipeline

The apt-get install command fails because the specified libc-bin=2.36-9+deb12u7 version is either unavailable or the APT cache is outdated.
Steps to reproduce:

Push into main branch
Pipeline fails in docker build

Fix:
Added the apt-get update command immediately before attempting to install libc-bin, ensuring the APT cache is up-to-date.


Build images and push to quay.io

Build docker images for Rufio on the CI and push to quay.io.
This currently only supports amd64. We can expand to other builds by leveraging Go's cross compilation feature for speed as we've observed, in other projects, the cross docker build to be quite slow.
Closes #26

Codecov Report

Merging #39 (8233c03) into main (2faddf0) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 8233c03 differs from pull request most recent head dc52ebb. Consider uploading reports for the commit dc52ebb to get more accurate results

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   18.98%   18.98%
=======================================
  Files           4        4
  Lines         316      316
=======================================
  Hits           60       60
  Misses        249      249
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2faddf0...dc52ebb. Read the comment docs.

We have a self-hosted arm-64 runner, is this an architecture we can add now?
Can we create issues to address any architectures that we generally cover that we would not be covering in this PR?

@displague Raised https://github.com/tinkerbell/rufio/issues/41


Export Data variant selection is confusing

Actual Behavior:
Variant selection does not clearly present the available options. The user is presented with two select boxes: the first uses the prose name for one of the base signals available from this source, and the second uses the API name for the variants available for the selected base signal.
API names are used nowhere else on the website, so this is likely to confuse users for whom the Export Data page is their only access to the data. Additionally, some signals in the meta sheet use prose names which are specific to the variant, making the text insufficiently general to use as a label for a collection of variants.
The fix will likely require work across both www-covidcast and the meta sheet.
Steps to Reproduce the Bug:

Go to https://delphi.cmu.edu/covidcast/export/
Select any of the cases/deaths signals
Observe SELECT SIGNAL

Expected behavior
The names in the first select box should be general enough to cover all variants.
Individual variants should be legible to users unfamiliar with the API.
The intended variant-specificity of names and descriptions in the meta sheet should be treated uniformly across all signals, and documented in the Note on the column header in the sheet.
A few implementation possibilities:

Make the signal name column suitable for all variants. Make the Short Description specific to the variation and suitable for use in the second select box.
Add a new column to the signals meta sheet that stores a prose name to use for all variants of a base signal. Make the signal names of all variations specific to the variation and suitable for use in the second select box.
Use the "source subdivision" meta sheet functionality to store the prose name to use for all variants of a base signal. Make the signal names of all variations specific to the variation and suitable for use in the second select box.
Add a new sheet for collections of variants, and use this instead of the current "base signal" approach

also open to others. I do notice the category chips and the description text for each variant shows up below the select boxes, but that doesn't help defray the initial confusion, only helps soothe it after the user has clicked around experimentally, and only if that part of the interface is visible while they do so.
Screenshots

Rating Scale (1 is minor, 7 is severe): 4 -- confusing; ultimately nonblocking, but will reduce our conversion rate
Context

Browser:Chrome

an alternative is to make each signal name specific enough and then we don't provide the variant selector but go back to a full list of signals in this data source

meta is now unique signal name -compliant.


Closed form

Hey i just wanted to know if there was any research been done in achieving a closed form for this curve.
Is there a way to calculate the discrete value f(x) for a cell x in O(1)?

I was thinking of adding mapping functions similar to xy2d and d2xy from https://en.wikipedia.org/wiki/Hilbert_curve (but didn't have time for that yet). Those however seem to work in O(logN) where N is the width of the domain. Do you have an example for the classic Hilbert curve that works in O(1)?

I dont have a O(1) but i thought maybe the more general form of the curve presented in this repository maybe makes it possible to optimize it further.
I havent thought about it much, just thought i would ask first :)


Support MySQL 8.x

the mysqlclient in the requirements.txt is too old to work with MySQL 8.x
_mysql.c: In function ‘_mysql_ConnectionObject_ping’:
_mysql.c:1894:3: error: unknown type name ‘my_bool’; did you mean ‘bool’?
my_bool recon = reconnect;
^~~~~~~
bool
I changed requirements to: mysqlclient==1.4.4
And now it seems to work...
Any reason not using newer version anyway? :)

Could you hand in a Pull Request that implements this little change?

Hello @almereyda
I'm not very familiar with that to be honest, it would probably take a lot of time on my end.
Al that is needed is to change the requirements to at least mysqlclient==1.4.4 :)
I hope you can implement that?

Looks weird, I don't have any problem with MySQL 8 container. Btw, It is good to have packages updated.  I made a change to update mysqlclient to 1.4.6