noisy.py module should be removed

Before the contributions of @AamnaLawrence @adam2392 and @Nick3151 in #6 there was only the single module noisy.py implementing the "find_noisy_channels" functionality.
Now the full PREP is implemented, including a new "find_noisy_channels" functionality, see: https://github.com/sappelhoff/pyprep/blob/master/pyprep/find_noisy_channels.py
noisy.py should be removed and the find_noisy_channels.py module should be overhauled so that it can be used standalone, without having to run the full PREP.

Yeah, I agree. But noisy.py does has some functionality that find_noisy_channels.py does not include. (def find_bad_epochs(epochs, picks=None, thresh=3.29053):). So I think maybe we could:

Put find_bad_epochs into a separate file
Remove noisy.py
Add a notebook on using find_noisy_channels.py standalone

I think that find_bad_epochs is out of the scope for pyprep. IMHO, pyprep should do one thing and do it well --> being a python implementation of the matlab PREP pipeline.
WDYT @yjmantilla

@sappelhoff I think in that case we should make available that functionality in another repo, for example pyfaster or something. I think actually eegfaster exist so maybe that would collide. In any case at least leave it at a gist which we could mention in the pyprep readme if anyone is looking for that.

Another way would be to create a repo specifically for finding noisy stuff include find_noisy_channels and the noisy epochs functions. And then make prep use that module. That way pyprep is the prep implementation and only cares about that and pynoisy (or how that would be called) would only care about finding noisy eeg, being it continuous or epoched.

I think actually eegfaster exist so maybe that would collide

ah, interesting: https://github.com/mdelpozobanos/eegfaster ... but it's not based on MNE (which is not necessarily a drawback)

In any case at least leave it at a gist which we could mention in the pyprep readme if anyone is looking for that.

I took the FASTER code from this gist: https://gist.github.com/wmvanvliet/d883c3fe1402c7ced6fc
I think I'd prefer to mention to remove all non-prep code from this repo and mention the FASTER gist somewhere in the README.
We have to work on more code than we can handle anyways, so removing unneeded things is a good start.

Right now the biggest issues are:

the mne multitaper filter, which I know there was a windowed version done which we could test.
the test and validation of the pipeline, which I think are even more important than the filter unless we think of the filter as something absolutely essential of prep.

There was a suggestion too for the API change. So after we eliminate the noisy.py  what should our focus be, on your opinion?

Yes, if we could fix the mne multitaper that'd be great ... both for MNE and pyprep. I think it'd be nice to have a working Python implementation for that.
And yes, we need more tests (and better tests) ... and once we have them, we should start refactoring the code without breaking the tests.
re: what to focus on:

removing noisy.py is a simple PR < 1hour
adding tests can be done incrementally ... whenever somebody has time to take a look and has a good idea
biggest chunk is fixing mne multitaper --> that'll have to be done in MNE-Python

Other things to do is compare RANSAC in pyprep with RANSAC in autoreject ... and perhaps "unify" them ... take the best of each combination and make one version out of them (probably "enhance" autoreject ransac ... and then make autoreject a dependency in pyprep to import RANSAC from there.)
--> this is also a big job.
So I see two big jobs and some smaller jobs.
Once all of this is done, we can start refactoring :-)

@sappelhoff just to your last comment, something else that would be handy for end users (like me) would be a paragraph or two somewhere in the README or docs comparing autoreject to PyPREP and discussing how they relate. For example, is it valid for someone to clean their raw EEG using PyPREP and then try and remove any remaining bad epochs with autoreject, or should they only be used independently?

For example, is it valid for someone to clean their raw EEG using PyPREP and then try and remove any remaining bad epochs with autoreject, or should they only be used independently?

PREP (and pyprep) will interpolate channels .. and autoreject will also interpolate on an epoch level (or drop really bad epochs without trying to interpolate) --> so I guess the danger could be to interpolate a channel based on data that's been already interpolated. And that's like using a copy machine to copy a copy instead of copying the original --> it's getting worse each iteration.
Personally, I would not use prep and autoreject together ... except maybe with heavy testing - but I haven't given it much thought.
Regarding a paragraph to guide users: Sure that'd be helpful, but we'd have to find somebody who wants to pour a lot of testing and knowledge into it :-) I personally don't know much more than what I said in the beginning of this post.


[libzippp] Update to v7.0-1.10.1

See the latest release.

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static


Fix Readme.md

Several errors. Should use try-with-resources. Remove the Task model from the first example.
Use a write method without the int indentation parameter.

We made all fixes and we also rewrote all the examples to include lambdas and methods handles in branch feature/binder-functional


CORE-16246 Allow topic configuration overrides

This PR provides the ability to override topic configuration, including replica and partition counts, on the topic create CLI commands and via the Helm chart.
The YAML file output by the topic create preview now includes partitions and replicas fields per topic. These default to the global parameters. These are then consumed by the topic create connect command so can be manually modified between preview and use.
The topic create preview and topic create connect commands also both take an --overides/-o option, which is the optional path to a file of the same format as the preview file. This file's contents are merged to override those generated/passed in.
The contents of this file can be provided as YAML under bootstrap.kafka.overrides. For example, the following Helm chart configuration can be used to override the default part count of 10 for the avro.schema topic to 5:
bootstrap:
  kafka:
    partitions: 10
    overrides:
      topics:
        - name: "avro.schema"
          partitions: 5

This CLI change will also need CLI baseline to be updated in E2E repository. Or else E2E tests will fail like so: https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda5-e2e-tests/detail/release%2F5.1/1054/tests


Neo-scan missing some txids and showing different balances

Example below
Address:
AMcBtJWPoJp4td2N1bjBZ3VazDoN9rwCmP
Missing txid:
13db3c4271f4a0c05048a468bb5d3ac7b663bf73e76d679a9411045b6bab983a
Neotracker:
https://neotracker.io/tx/13db3c4271f4a0c05048a468bb5d3ac7b663bf73e76d679a9411045b6bab983a
Neoscan:
Can't find

yes, the block 2,980,963, is missing from the neoscan database. I am deploying a new synced version soon (tomorrow).

fixed with resync


Properly handle remote->local namespace mapping in blockchain plugin

In the "new world" (network version 2), the blockchain plugin (like other plugins) should only deal with the local namespace name.
For network version 1, the (remote) namespace must be written on chain, so it's necessary to map back and forth from local to remote namespace name within the plugin. This does break the paradigm of keeping namespace mapping at a higher level only, but seems like the cleanest solution for old environments.
Note that this also alters the subscription creation logic for V1 vs. V2. For V1, there will be a shared subscription for all namespaces on a given contract (which is how FireFly 1.0 already behaves). For V2+ only, there will be a separate subscription created per namespace.
Includes a basic E2E test for namespace mapping.

Codecov Report

Merging #911 (2bde3f7) into main (5d68c05) will decrease coverage by 0.14%.
The diff coverage is 98.46%.

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   99.96%   99.81%   -0.15%
==========================================
  Files         298      298
  Lines       19452    19437      -15
==========================================
- Hits        19445    19401      -44
- Misses          5       32      +27
- Partials        2        4       +2

Impacted Files
Coverage Δ

internal/events/event_manager.go
100.00% <ø> (ø)

internal/operations/manager.go
100.00% <ø> (ø)

internal/events/batch_pin_complete.go
95.31% <60.00%> (-4.69%)
:arrow_down:

internal/blockchain/ethereum/ethereum.go
100.00% <100.00%> (ø)

internal/blockchain/ethereum/eventstream.go
100.00% <100.00%> (ø)

internal/blockchain/fabric/eventstream.go
100.00% <100.00%> (ø)

internal/blockchain/fabric/fabric.go
100.00% <100.00%> (ø)

internal/dataexchange/ffdx/ffdx.go
100.00% <100.00%> (ø)

internal/multiparty/manager.go
100.00% <100.00%> (ø)

internal/multiparty/operations.go
100.00% <100.00%> (ø)

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


This Repo is excluded from Hacktoberfest, please look into it !!

We have already announced that. @myselfdeepdas . We are constantly trying to talk to hacktoberfest team .You can still contribute to this repo and that counts for ClueLess swags in the leaderboard.
Closing this issue.


Update exchange-online-powershell-v2.md

Changed the switch RPSSession to UseRPSSession so that it reflects the actual switch you use when connecting.

Docs Build status updates of commit 55bdfd6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Just spent a decent chunk of my time trying to figure out why this wasn't working so wanted to fix this.
Apologies if there are any issues, this is my first time trying to edit MS documentation.

Docs Build status updates of commit 7d6e797:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add custom WebViewClient class

Added a derived class of WebViewClient which helps intercepting URLs.
@aleffert Please review, though this class is partially built and we are yet to decide on the form of URLs.

This is a good start. Hope my comments make sense.

@aleffert Please review, I made few more changes.

Looks good.

I merge this.


de-double MGI IDs

identifiers.org MGI URLs have :s in them, which means the URI is encoded as
http://identifiers.org/mgi/MGI%3A5624838
which is not optimal
The whole MGI:MGI thing was a mistake inherited from GO a while ago, over the definition of identifier (local vs prefixes).
Can we have the URI prefix for MGI be http://identifiers.org/mgi/? So URLs would be of the form http://identifiers.org/mgi/5624838

Hi Chris, this is already addressed in the new patterns they support.
If you have a context map with MGI mapping to http://identifiers.org/MGI: it works fine.

OK, so this is a bit confusing
both

http://identifiers.org/MGI:80863
http://identifiers.org/mgi/MGI:80863

are supported (is the plan to make the first canonical and deprecate the
second?)
1 is preferable as it doesn't double up, but it still includes the ':'
in the URI, which is problematic due to the need to escape
On 18 May 2018, at 18:54, Julie McMurry wrote:

Hi Chris, this is already addressed in the new patterns they support.
If you have a context map with MGI mapping to
http://identifiers.org/MGI: it works fine.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/identifiers-org/registry/issues/8#issuecomment-390370203

In what context must you escape them? All modern browsers support the ':' natively now.

Re: deprecation, there are already URIs in the wild various places; I don't think they plan to (or should) stop resolving them. In time, my understanding is they do plan to update the documentation to the new patterns. Agreed it is confusing mid-stride.

Hi Chris and Julie,
Yes, we are actively promoting (1) prefix:identifier compact identifier form. However, we will continue to support (2) for now.

I'm not really concerned with browser behavior. If identifiers.org URLs are to be used as identifying URIs within a semantic web stack there's a complex set of specifications, to be waded through.
I haven't looked at these for a while, but colons have always been problematic.
For example, if we start at the CURIE spec https://www.w3.org/TR/curie/
curie       :=   [ [ prefix ] ':' ] reference
prefix      :=   NCName
reference   :=   irelative-ref (as defined in IRI)

irelative-ref is defined here:
https://www.ietf.org/rfc/rfc3987.txt
which eventually bottoms out here:
isegment-nz-nc = 1*( iunreserved / pct-encoded / sub-delims
                        / "@" )
                  ; non-zero-length segment without any colon ":"

":"s used to be very problematic with a lot of toolchains, but it seems now that the specs may not be always adhered to and many stacks will do the 'intended' thing...
...but why risk it? What is the reason for MGI being any different than others?

Hi Chris,
At the moment MGI is considered as being part of the identifier which results in:

http://identifiers.org/MGI:80863
http://identifiers.org/mgi/MGI:80863

Technically, it is much simpler to do

http://identifiers.org/MGI:80863
http://identifiers.org/mgi/80863 (currently not supported)
However, it is still not clear to me whether the data provider would approve this.

When last they were asked about this MGI was not ok with http://identifiers.org/mgi/80863. Things may have changed, just thought I'd convey what I know to date.

Thanks Julie. I'm not sure how to address these differences in approaches between data providers and tool builders.

IMHO, I think you're doing all you can.


On game crash: game gets stuck in loop

On the rare occasion where the mod crashes for whatever reason (usually something I did wrong), the error box pops up, I click cancel or end task, whatever, but then it pops right back up, over and over, and doesn't go away. Because of this I often end up playing the game in a window, as otherwise I can't ctrl+alt+del to get to task manager and kill the process.

Thanks for the report. This is known bug and it should be fixed in the nearest updates.


Improvement of the help command

This pull request resolves #40

Description
Improved the help commands and fixed some other issue while adding helpful utilities.
More info about the changes below...
Help command:

Used of RichEmbeds.
Changed the info to make it more suitable.
Added @Jacxk to the contributors.
Displayed prefix to the commands usage.
If no argument is provided it will send the list of features and a list of commands (This might probably have to change because I didn't understand what @SebastiaanYN wanted exactly)
If an argument is provided it will check if there is a command or alias for that arg and send the details of that command, such as: name, info, usage, contributors, etc.

Additions:

Added a stringify method on the Utils class to make objects human friendly. Takes an object and a join char (optional and for arrays only)
Added contributors to the command class and default values so it doesn't return undefined and make errors.
Fixed an issue with the aliases sending an error because a command didn't provide its aliases.

Note: The embeds have no colors because we need to agree on what color to use for all embeds type.

Make a option under the config what color is supposed be used in the embeds so and pass color option in the embed so anyone could choose there own color 🤷♂

Thanks for the PR. Just a couple of things:

I don't really like having a list of contributors per command. It becomes hard to maintain and I think it's unnecessary to keep track of it per command. We could probably use the GitHub API to display contributors at some point.
Regarding the "no arguments provided": Features act as a category for commands and events. When no argument is provided it should display the commands grouped by the Feature (category) it is in.
I think the command options should always be explicitly provided. It makes it easy to see everything about the command, without relying on default values that are set somewhere else. This is why the command options don't have default values, and always throw an error when they're not provided.

The collaborators thing could be changed to be displayed automatically, but I think we shouldn't remove this because on my opinion. people who worked on it should deserve some recognition.
I think that having default values is a good way making our experience a little better. Image you're making a few commands that doesn't have aliases, you'll have to put aliases: [] every time if there is no default value, but if there is then you don't have to worry about it.
For the feature thing, you want it to be like:

Feature Name 1:
*commands with info*
Feature Name 2:
*commands with info*

Also one the help and ping commands don't have a feature.

I think that having default values is a good way making our experience a little better. Image you're making a few commands that doesn't have aliases, you'll have to put aliases: [] every time if there is no default value, but if there is then you don't have to worry about it.

You'll likely copy and paste the layout from a different command most often. Other than that it's often the case that someone might change the value, resulting in the default value being provided explicitly. This becomes inconsistent.
Say guildOnly defaults to true, then to set it to false you would do:
{
  guildOnly: false,
}

Now later on someone decides to change this to true instead of removing it and using the default value. So now it says:
{
  guildOnly: true,
}

Expect this would be identical to:
{}

After some time this will make it so some commands explicitly provide true, some explicitly provide false, and some default to true. I don't like the inconsistency it can create and much prefer the explicit way.

For the feature thing, you want it to be like:

Feature Name 1:
*commands with info*
Feature Name 2:
*commands with info*

Also one the help and ping commands don't have a feature.

Something like that would work yes. There would have to be an additional category, like Others, for commands that do not belong to a feature.

I've automated the contributors list, it is using got, if you want me to change it and use another package let me know.

Why use got when we have node-fetch

Why use got when we have node-fetch

There is no huge difference but if @SebastiaanYN wants me to change it, I will...

It will reduce one dep 🙃

2 months later and nothing...

please merge or i die


Made urgentmessages only require when needed

This makes the urgent messages module only require the cloud version when out of date. So there won't be an annoying message in output anymore.
It also fixes a bug where the URL doesn't appear.
First on all non-studio instances the URL won't be shown, but also if you have logmode (which is on by default on studio), the URL won't appear either.
Remember that you have to manually update the time inside the plugin for it to work offline when it can.

I don't like the idea of hardcoding the last updated time like this. It partially defeats the reason it was an external module rather than just being built-in. If the MainModule needs to be updated when there's a new alert, they might as well just be included in the MainModule.

I don't like the idea of hardcoding the last updated time like this. It partially defeats the reason it was an external module rather than just being built-in. If the MainModule needs to be updated when there's a new alert, they might as well just be included in the MainModule.

Manually updating the time isn't required but it just makes it so that it requires the offline version if the dates match.

Closing because I don't think this is entirely necessary... sure, it gets rid of an extra "module loaded" message in console, but ultimately I suspect the hardcoded time will end up not getting updated frequently anyways


Death Save Push to D&D Beyond Fails

Describe the bug
When syncing to D&D beyond from Foundry, the console logs errors indicating death saving throws have failed to upload.
To Reproduce
Steps to reproduce the behavior:

Go to an actor's character sheet.
Perform an 'empty' sync (same as freshly fetched) - this should work perfectly with no errors in the log.
Delete a death save value (instead of setting to 0).
Resync and see the error in the log.

Expected behavior
It looks like the death saves fail due to a missing null coalescing to 0 when a user deletes the value instead of setting it to 0. Absent values should default back to 0.
Screenshots

Environment:

Browsers Chrome, Brave
Foundry Version 10.291
5e System Version 2.0.3
Module Version 3.2.12
Does this behavior occur with other modules disabled: Yes

One additional comment: the same issue may occur for other fields that sync that can be manually modified. May be worth checking those areas as well for the same check type.

Thanks for this, it will be fixed in the next release.


add support for jpeg quality option

adding this as a placeholder for @cubabit's work in his add-quality-option branch (at least, I assume you intended to contribute this.  Note also the relevant changes I made in 0980ea64a012b31c12f89ab1c226fc805bbabf70)

Sure - I'll send a pull request soon!

fixed in e7b0a5b88cb8fb82c0d7c1ce2d969ea3235205e2


Create a class or methods for Lift

Goal is to eliminate so much copy and paste (potential errors) in auton when wanting to use the lift

Kept running into runtime errors:
Op Mode threw uncaught exception
java.lang.NullPointerException: Attempt to interface method 'void... on


[Bug] Jackson version conflicts among MySQL/TiDB/MongoDB connectors

Search before asking

[X] I searched in the issues and found nothing similar.

Flink version
1.14
Flink CDC version
3.0.0
Database and its version
MySQL 5.7
Minimal reproduce step
Put flink-sql-connector-tidb-cdc-3.0.0.jar, flink-sql-connector-mysql-cdc-3.0.0.jar and flink-sql-connector-mongodb-cdc-3.0.0.jar into lib folder at Flink home (Flink 1.14 in my case), then create a MySQL CDC table and submit a simple query like select * from mysql_cdc_table, there would be an error:
java.io.InvalidClassException: com.ververica.cdc.connectors.shaded.com.fasterxml.jackson.databind.cfg.MapperConfig; incompatible types for field _mapperFeatures
It's caused by inconsistent jackson versions of the CDC connectors:

flink-sql-connector-mongodb-cdc-3.0.0.jar: 2.10.2
flink-sql-connector-mysql-cdc-3.0.0.jar: 2.13.2
flink-sql-connector-tidb-cdc-3.0.0.jar: 2.12.3

What did you expect to see?
All CDC connectors use the same jackson version.
What did you see instead?
Inconsistent jackson versions among the CDC connectors which conflicts with each other.
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

I'm planning to add a dependencyManagement in the root pom.xml to pin the common dependencies version (especially the ones in debezium modules) . WDYT? @leonardBang

+1 from my side, thanks @link3280 for raising up this ticket.

Closing this issue as it has been migrated to Apache Jira.


[TE] frontend - aaronucsd/added auth to dashboard

Made dashboard the home page
Updated fix to login's route willTransition to clean out old /rca path
Clean up router.js

fixed linting per Travis log.


Add tests for PEP 425 support

Summary of changes
When code for supporting PEP 425 compatibility tags was copied from pip in https://github.com/pypa/setuptools/pull/1200, the unit tests weren't copied with it.  I'm adding those to make sure we don't inadvertently break that functionality.
Pull Request Checklist

[x] Changes have tests
[x] News fragment added in changelog.d. See documentation for details

It looks like this increased overall coverage by 0.5%.


VM hangs when reaching breakpoint in code loaded from Kernel binary

Compile a Dart program with dartk, then load it and inspect it with the Observatory:
dartr pkg/kernel/bin/dartk.dart  ~/tmp/a.dart  --sdk xcodebuild/DebugX64/patched_sdk --link --target=vm --out=/Users/hausner/tmp/a.dart.dill
xcodebuild/DebugX64/dart --observe --pause-isolates-on-start /Users/hausner/tmp/a.dart.dill
Setting a breakpoint in 'main' does not work because the Kernel binary contains a second top-level function main (from vmservice_io.dart).
Setting a breakpoint in another function works, but when the breakpoint is reached, the VM hangs. Lldb shows this stack trace:
  thread #5: tid = 0x3c9443, 0x00007fffccbe5c86 libsystem_kernel.dylib`__psynch_cvwait + 10
    frame #0: 0x00007fffccbe5c86 libsystem_kernel.dylib`__psynch_cvwait + 10
    frame #1: 0x00007fffccccf96a libsystem_pthread.dylib`_pthread_cond_wait + 712
    frame #2: 0x000000010043b9c2 dart`dart::Monitor::WaitMicros(this=0x0000000102708fc0, micros=0) + 274 at os_thread_macos.cc:384
    frame #3: 0x0000000100323495 dart`dart::Isolate::PauseEventHandler() [inlined] dart::MonitorLocker::Wait(millis=0) + 213 at lockers.h:169
    frame #4: 0x000000010032348a dart`dart::Isolate::PauseEventHandler(this=<unavailable>) + 202 at isolate.cc:2417
    frame #5: 0x00000001001f668b dart`dart::Debugger::Pause(this=0x000000010542bff0, event=0x00007000028250d8) + 715 at debugger.cc:2582
    frame #6: 0x0000000100202c71 dart`dart::Debugger::SignalPausedEvent(this=0x000000010542bff0, top_frame=0x0000700002825448, bpt=0x000000010af17f30) + 385 at debugger.cc:2919
    frame #7: 0x0000000100203a33 dart`dart::Debugger::PauseBreakpoint(this=<unavailable>) + 1699 at debugger.cc:3122
    frame #8: 0x00000001001bee35 dart`dart::DRT_BreakpointRuntimeHandler(dart::NativeArguments) [inlined] dart::DRT_HelperBreakpointRuntimeHandler(thread=<unavailable>) + 209 at code_generator.cc:710
    frame #9: 0x00000001001bed64 dart`dart::DRT_BreakpointRuntimeHandler(arguments=NativeArguments @ 0x0000700002825d30) + 804 at code_generator.cc:699
    frame #10: 0x0000000102100630
    frame #11: 0x000000010210158f

@jensjoha

While I didn't realize that the VM would hang, it's known that debugging kernel doesn't currently work very well... As an example, trying to set a breakpoint on foo in this and running doesn't work:
foo() {
  print("Hello, World!");
}

main() {
  foo();
}

while doing it on this does:
foo() {
print("Hello, World!");
}

main() {
foo();
}

It will be better soon.

Could you verify that this is no longer the case (at least I cannot reproduce and "basic debugging" works with e7766c950eafabfd631d693902483a13bf3bfac7)

Seems to be working now.


Setup a deploy preview for Cloud Masthead endpoint within the webstandards/ibm-dotcom-translations repo

The problem

The HC team is now using the webstandards/ibm-dotcom-translations repo to house all of our masthead and footer data.
As part of the content management and PR process, we need to set up a deploy build preview that allows folks to preview and verify their content changes.
This deployed preview is similar to the ones that @jeffchew set up for Carbon and v18/Northstar (see attached).

The solution

Create a new deploy preview pipeline similar to the one created for the Carbon preview.
Set the name to Cloud

Additional information

We have a PR opened for adding the Cloud-specific container and composite components, which will be needed to assemble this preview. https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/5593

@annawen1 When you have a moment, can you let me know if this work is still part of the Sprint 21-11 that's due on 06/04? Just wanted to get a sense of when we have this preview available within the PRs for the webstandards/ibm-dotcom-translations repo, since we're going to be adding other translation files soon and it's nice to have a preview of the changes. Thanks!

@proeung Yep, this has been done! You should now be able to see the deploy previews when adding the cloud label to your PR in the translations repo


Sanitize User input with sanitize-html

Proposed changes
Added dependency sanitize-html and updated to Sequelize models to set sanitized text from input fields.
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
For issue #98 https://github.com/PublicDataWorks/police_data_manager/issues/98#issue-1114178089
Types of changes
What types of changes does your code introduce to Police Data Manager?
Put an x in the boxes that apply

[ ] Bugfix
[ ] New feature
[x] Maintenance / Documentation Update

Instance-files

[ ] Do your changes require changes to instance-files?

if so please include a link to pull request for instance-files demo

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

2 extra commits because I was trying to squash them.

Locally or on my remote fork?
On Tue, Feb 1, 2022 at 2:32 PM Andrew Rist @.***> wrote:

@.**** commented on this pull request.
In src/server/policeDataManager/models/caseNote.js
https://github.com/PublicDataWorks/police_data_manager/pull/111#discussion_r797043120
:

@@ -52,6 +58,9 @@ module.exports = (sequelize, DataTypes) => {
const action = await sequelize.query(
SELECT name FROM case_note_actions WHERE id=${this.actionId}
);

const formattedActionTakenAt = timezone

just remove the creation of formattedActionTakenAt
—
Reply to this email directly, view it on GitHub
https://github.com/PublicDataWorks/police_data_manager/pull/111#discussion_r797043120,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXHS47YEPV3I5JNXCKVGHSDUZBGNHANCNFSM5NKG7NFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Cat Trujillo
Consultant-Graduate Software Developer
Email @.***
[image: Thoughtworks]
http://www.thoughtworks.com/?utm_campaign=cat-trujillo-signature&utm_medium=email&utm_source=thoughtworks-email-signature-generator
[image: Delivering extraordinary impact together. Learn more about
Thoughtworks]
https://www.thoughtworks.com/?utm_source=email-signature&utm_medium=email&utm_campaign=brand


Typo in Changes.MD

There is a typo around line 766 in Changes.MD
var x = d3.scaleOrdinal()
    .domain(["a", "b", "c"])
    .rangeBands([0, width]);

Should be (d3.scale.ordinal() in 3.x)
var x = d3.scale.ordinal()
    .domain(["a", "b", "c"])
    .rangeBands([0, width]);

Thanks. In the future, please open a pull request with typo fixes. 👍


How to train a model with my data based on pre-training model

Hello, your code is very helpful to my problem. But the detection of the model still has problems with my image data. So I want to train my image data based on the pre-trained model. My data only includes images, not videos. How can I do this? Thank you

Hi! Do not know what your data is, may be just passing --height-size 512 (or 1024) to demo.py will make results better. For training on custom data please refer to the guide.

Hi! Do not know what your data is, may be just passing --height-size 512 (or 1024) to demo.py will make results better. For training on custom data please refer to the guide.

Hope, it helped.

Hope, it helped.


Clarified that ARO V3 instructions are specific to ARO v3

Made it clear that the Openshift-specific instructions only apply to Openshift V3. (These instructions confused ARO v4 users)

@daweim0 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Lamil/va bug fix

Description

Fixes To Do skill not working in skill mode
Fixes localization for intro card (required me to change the intro card encoding to UTF-8)

You need to update the test class too to accommodate for the constructor change to fix the build break.


MacOS Version doesn't open

When i try to open Doki-Doki-Takeover it tells me "The application “DokiTakeover” can’t be opened."

Unfortunately this only works on Intel Macs, as that's what GitHub Actions runs on. There's nothing we can do outside of someone offering to build it for M1 Macs, sorry about that.


composer require returns error: invalid package definition

I'm using composer 1.2.0, and I've copy/pasted the repository to my composer.json as described in the readme file, but when I try to install with composer require advanced-custom-fields/advanced-custom-fields-pro:* (also from the readme) I get this error message:
[Composer\Repository\InvalidRepositoryException]
  A repository of type "package" contains an invalid package definition: Invalid package information:
  version : invalid value (*.*.*(.*)): Invalid version string "*.*.*(.*)"
  Invalid package definition:
  {"name":"advanced-custom-fields\/advanced-custom-fields-pro","version":"*.*.*(.*)","type":"wordpress-plugin","dist":{"type":"zip","url":"https:\/\/connect.advancedcustomfields.com\/index.php?p=pro&a=download"},"require":{"philippbaschke\/acf-pro-installer":"^1.0","co
  mposer\/installers":"^1.0"}}

I tried removing the version string, but then I get an error message saying Package advanced-custom-fields/advanced-custom-fields-pro has no version defined.
I'm new to composer (and just getting back into PHP) so I'm not really sure how to work around this issue.

Thank you for your issue report @JKirchartz.
Did you replace the version placeholder *.*.*(.*) with an actual version (e.g. 5.4.2)?
{
  "type": "package",
  "package": {
    "name": "advanced-custom-fields/advanced-custom-fields-pro",
-    "version": "*.*.*(.*)",
+    "version": "5.4.2",
    "type": "wordpress-plugin",
    "dist": {
      "type": "zip",
      "url": "https://connect.advancedcustomfields.com/index.php?p=pro&a=download"
    },
    "require": {
      "philippbaschke/acf-pro-installer": "^1.0",
      "composer/installers": "^1.0"
    }
  }
}

That seems to have been the issue, it wanted the actual number.


Enhance UI experience

Hello, first thanks for this plugin.
IMHO, it would be better to have a tree in the Nx Tool Window like the gradle or maven integration in Intellij Idea.

We can group command like in the nx console for vscode and run by double click or create run configuration and invoke them later.
The way Execute gradle task too is very cool and we can inspire from it to execute Nx tasks or Commands.

Hello @iguissouma! I think that is a good idea as we add more commands for the nx plugin. I will see how feasible it is to get the tree view going 😄

Maybe I can contribute to this, I did a POC how I can support Nx like a Js build tool like Gulp, Grunt or NPM.
It looks like this:

Maybe I can contribute to this, I did a POC how I can support Nx like a Js build tool like Gulp, Grunt or NPM.
It looks like this:

Yea I've been putting some thought into the tree view, and I think I would probably want to take care of setting up the "Settings" portion of the plugin first, so that users can choose between the different views. Table view might be more in tune and useful for ease of readability and searching if someone mainly uses it to run schematics. The tree view might be helpful for someone who tends to use a lot of the other actions. Really depends on user preference.
Implementing the tree view should be pretty straight forward, but I would want to take care of that after having a "Settings" section for the plugin. I plan to start working on the Settings sometime this weekend into next week. 😄


GearVRf together with ARCore supported devices

Hi,
My intention is to integrate ARCore and GearVRf, and I try to understand what will be the supported devices.
In the documentation mentioned:

GearVR Framework supports following devices
Gear VR compatible Samsung phone:
Note 8
Galaxy S8
Galaxy S8+
Galaxy S7
Galaxy S7 Edge
Note 5
Galaxy S6
Galaxy S6 Edge
Galaxy S6+
Samsung Gear VR headset
Daydream-ready phone
Google Daydream View VR headset

But I assume this list is relevant for VR headset development?
Can I assume that developing AR using ARCore, and GearVRf's Loading Assets, Rendering and Scene Graph features will be limited to the ARCore supported devices?

If you want AR and VR together, then the supported devices should be the overlap of the ARCore supported devices list and GVRF supported list

@bohuang3d I want to achieve only an AR capability, without VR.
I'm actually asking, what will be the supported device list for the ARCore integration sample app?

@bohuang3d thanks, this confirms my assumption.

@itanbp Do you need more information? If not, planning to close the issue in few days.


Implement ECR batch_delete_image

This implements the missing endpoint from issue #2224

Coverage increased (+0.004%) to 93.014% when pulling 6898e37dfae87a6cceacb29e53a64cfecd7abc84 on queue-tip:implement-ECR-batch-delete-image into 8f53b16b9a5dc14d80df4a5f0137838c5bd71390 on spulec:master.

Coverage increased (+0.004%) to 93.014% when pulling 6898e37dfae87a6cceacb29e53a64cfecd7abc84 on queue-tip:implement-ECR-batch-delete-image into 8f53b16b9a5dc14d80df4a5f0137838c5bd71390 on spulec:master.

Nice job


Remove onHooks?

Triggers are useful for external objects and special subclassing cases. However there's not a huge benefit of:
Route.extend({
  fetch(id) {
    return this.store.find(id);
  },
  onFetch() {
    // do something...
  }
});

over:
Route.extend({
  fetch(id) {
    return this.store.find(id).then(() => {
      // do something...
    });
  }
});

The later simplifies this codebase and shrinks the public api a lot. It also seems more obvious.

/cc @jmeas

I’m not the router expert, but I’m all for a simpler API.  I also think .then() is a pattern everyone should know or learn, especially for handling the result of a specific data request.  Plus Backbone doesn't use "on" methods itself.

In ember, there are nuanced differences between all of their hooks to help account for the numerous edge cases when routing. For instance, their model hook won't be called if you navigate to a route programmatically and pass a model in, while the beforeModel and afterModel hooks still will be called.
This router doesn't seem to have all of those edge cases covered – which is fine – but if there's no distinction between the different hooks, then they might as well be removed. In addition to reducing public surface API and underlying LoC, it will make the code that developers write easier to read, as it removes a layer of unnecessary abstraction.
tl;dr, sure, remove it.


preview_fzf_grep: optional support for columns

Hey there! I was trying to reuse the grep preview script for integrating with some output from the lsp client that includes the column number. Keeping the column is important so I can jump to the precise location in the 'sink' function. I can move the column elsewhere in the line, but I think that would be weird.
I'm not familiar with the use case for having a : match the file group though, so please let me know if I'm messing something up.

Thank you. It's probably not a problem.
I'll try it after the merge and report back if it seems to cause problems.


[MultiModal] Fusion model inference acceleration with TensorRT

Issue #, if available:
Description of changes:
This PR brings support to accelerate fusion models with tensorrt.
For a fusion model trained with petfinder dataset, TensorrtExecutionProvider can boost inference speed up to 2.7x faster, comparing to GPU-based realtime prediction with PyTorch.
"petfinder",
["numerical_mlp", "categorical_mlp", "timm_image", "hf_text", "fusion_mlp"],
"google/electra-small-discriminator",
"mobilenetv3_small_100"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the change @liangfu. Do you know why preprocessing logics are generally slower in the TRT execution env?

Thanks for the change @liangfu. Do you know why preprocessing logics are generally slower in the TRT execution env?

Good question, I'm also interested to see why this is happening. Therefore, I did a breakdown of the call stack

Seems like data_processor is a bit slower when using TRT.


Update rookout chart environment variables

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

https://github.com/helm/charts/pull/11306


Send new list file entries discovered to an API

This allows users to benefit from each other because the entries can be included in the next release

Find a free online service where we can host the listfile.txt - To avoid maintaining custom server on AWS.
A simple example is a shared google drive document, but we have to tie it to an account, and there's a risk of that account user deleting the file.
And then we have to think about security. We need the exe to edit the file via API, but not grant write access to random anonymous web users.
And we don't want the file to disappear from the cloud in a few years, so it should be a reputable company.
Google drive may be the best option, but do some research first before implementing.

Neat idea but I think we can get a head start by doing something different and offline-only.
One major part of name discovery is the automatic extraction from current map resources, this includes object files (.doo, SLK and friends) but map scripts too (unless obfuscated). Maps cannot hide 99% of these. Though one piece of the puzzle iirc are MDX (model files) that have texture paths hardcoded in them. I don't think anything currently extracts from there?
Let's assume automatic extraction works to the best extent possible. We have a huge lake of maps to draw data from, the biggest websites hosting maps are:

epicwar.com
wc3maps.com (live archival of hosted Reforged lobbies)
Hiveworkshop + individually posted resources
xgm.guru (the Russian community) + individually posted resources

My idea is to run the automatic extraction over all public maps we can get our hands on in the hopes of extracting 99.9% of used names from this entire corpus of maps. Then this listfile could be used to uncover new maps. Considering the extent of resource reusage, maps that were not protected at one point, maps that has an unprotected release by mistake -- this should provide us with excellent coverage.
As you see, this wouldn't even take any online services and probably help to reduce the search namespace for bruteforcing yet  unknown names. One ad-hoc way to "forget" about a real-time online solution is to present users with a "listfile diff" that consists of new auto-detected names to be submitted upstream (to the authors of the program). A simple message box and Discord/Github links would do. Speaking of Github, automate issue/PR creation with API? :) Should be possible too. People don't usually extract API keys to abuse them.
I can run such an offline auto-detection effort if you make a tool to run recursively over all maps in a folder. 400 GB should be a good starting point ;) Of course if you add strict asserts, that map pool and me can act as your test pipeline on the way to figure out the various protections there are.

I agree with all your points here. I consider this online listfile task "phase 2", if it ever gets done. My primary goal is to improve the unknown file detection so that we don't need a listfile at all. Then we could cancel the idea of keeping a combined online listfile.
In the future, I love the idea of running over every map file & doing batch deprotection for testing.
Right now with manual testing, it's fairly easy to find bugs, so there's no reason to do batch testing yet. & I want to look at other options for unknown file recovery before I invest in making a 100% comprehensive list file for every map.
I think the starting point is running a web spider to download all the maps & group them by map name (Dota/Enfos/etc, so each folder contains different versions of the same map). If you have time to do that, it would be awesome. I can set up an FTP folder for you to send all the files to me once you have them downloaded. Even though we're not ready for batch processing yet, this would be a HUGE help.
I'm not ready to release a public version of the app for batch processing yet. The tool is too fragile still (breaks on some maps) & also I don't want a rogue actor to deprotect every map in the world & publish them somewhere. For now, I want to keep it 1 map at a time, by hand, so the human can verify everything deprotected correctly & they can consider the ethics of if that map really should be released unprotected (if the author has abandoned development, for example).

I think the starting point is running a web spider to download all the maps

I already have the 400 GB mentioned of EpicWar as I was afraid of the site disappearing one day. It's not up-to-date, I'd need to make a cron job to fetch the new maps as they appear. Some porn maps :) are deleted fairly actively (that was when I realized they exist).

I'm not ready to release a public version of the app for batch processing yet.

I didn't think of batch deprotection, but other parts of processing and testing. Like testing the parsers. I had made that triggerdata-converter parser extra strict and found a couple mistakes as a result. I don't know how strict War3Net is with parsing/asserts.
Also I love your focus on ethics, that warning window I saw in your video is great! Every so little obstacle is psychologically important (well I want to believe so).

Add me on discord & I'll give you FTP credentials where you can send me the map files.
Discord username: speige

P.S. I think a lot of tools extract the texture file names from the MDX files, including mine. I don't know if any actually "parse" the MDX, but they just do a regex across it. The downside to regex is it's going to be imperfect and possibly miss some of the filenames.


feat: impl date_add/date_sub functions

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Impls date_add and date_sub functions to add an interval to Timestamp/Date/DateTime values.
Checklist

[ ]  I have written the necessary rustdoc comments.
[x]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)
Close #2593

@zhongzc @QuenKar @fengjiachun  Please take another look. I fixed the wrong behavior of the previous implementation.


the name...

Saw this and like it a lot! But the name in latin-american countries has terrible meanings... http://www.asihablamos.com/word/palabra/Chota.php

LOOOOOOOOL

When this repo appeared on my feed I just opened it because of the name :laughing: It's funny and I'd love to suggest some chota development back at the office.


SeeMore Issue

Problem
Duplicated the code in Reputation Card component and all Reputations page
Solution
Make single point to Single Card from Reputation Card component and All Reputations page

Done


Added all open source licenses (Fixes #2941)

Description
Use licenses that we see on GitHub when we create a new repo. Also included is automatic updating of the licenses from the aforementioned license repository created by GitHub. The cookiecutter.json file is also updated.

Uses open source licenses (including the Jekyll format) from https://github.com/github/choosealicense.com/tree/gh-pages/_licenses
Added license section in README.rst because some licenses want it to be explicit
cookiecutter.json shows all licenses (including "Not open source") in lexicographical order except for "Not open source"

Checklist:

[X] I've made sure that tests/test_cookiecutter_generation.py is updated accordingly (especially if adding or updating a template option)
[ ] I've updated the documentation or confirm that my change doesn't require any updates

Docs haven't been updated because honestly... I don't know if we want to show ALL of those licenses...
Rationale
Fixes #2941
Lots of open source licenses... too many to choose.
Makes it easier to maintain since we can just use GitHub actions to constantly update the files if necessary.

Oooo that's an... interesting error to deal with...

Something that can make sure commits decrease in the automatic workflow is to check if the license file already exists since licenses don't change due to their copyright reasons. That means we should only commit if there's a difference in cookiecutter.json (i.e. any new license).
Additionally, it might be better to also include the MIT license, Apache, etc. near the front like "Not open source" license is in cookiecutter.json.

Just realized we should instead make a pull request instead of committing directly in case of a new file since there would be square brackets.

@browniebroke I'll be creating a new PR. Looks like I completely missed their (new?) API that includes the licenses: https://docs.github.com/en/rest/reference/licenses#get-a-license

#3982 would resolve this


record  double shapefile meta info using java geotools ingestion and etc problems

Nowadays, i'm making a java source based on Geotools to handle Geowave. but i have encountered some problems. So i'd like to get your advice about this troubles.

When i ingest shapefile through java-api based on geotools, the both meta data is recorded for one shape file in Accumulo.
This is the shot i was taken :

This issue was also in previous jar file version. I try to fix it up on my java client side but i didn't.
This is my java source for ingesting to geowave :
//-----------------------------------------------------
public static void main(String[] args) throws Exception {
	DataStore dataStore = dataStore(); //connection data for geowave and accumulo

	String typeName = "shp file name";
	String filepath = "file path";

	writestr(filepath, dataStore);
}

private static void writedata(String filepath, DataStore dataStore,
		String usrFNm) throws IOException {

	Map<Object, Serializable> shapeParams = new HashMap<Object, Serializable>();

	shapeParams.put("url", new File(filepath).toURI().toURL()); // shp file path
	shapeParams.put("charset", "utf-8");

	DataStore shapeDataStore = DataStoreFinder.getDataStore(shapeParams); /

	// feature type
	String typeName = shapeDataStore.getTypeNames()[0]; // taking a file name

	FeatureSource<SimpleFeatureType, SimpleFeature> featSource = shapeDataStore
			.getFeatureSource(typeName);
	FeatureCollection<SimpleFeatureType, SimpleFeature> featSrcCollection = featSource
			.getFeatures(); // gether the feature data

	System.out.println(shapeDataStore);

	SimpleFeatureType ft = shapeDataStore.getSchema(typeName);

	// feature type copy to set the new name
	SimpleFeatureTypeBuilder builder = new SimpleFeatureTypeBuilder();

	builder.setName(typeName);

	builder.setAttributes(ft.getAttributeDescriptors());
	builder.setCRS(ft.getCoordinateReferenceSystem());

	SimpleFeatureType newSchema = builder.buildFeatureType();

	Transaction transaction = new DefaultTransaction("create");

	dataStore.createSchema(newSchema);
	FeatureStore<SimpleFeatureType, SimpleFeature> featStore = (FeatureStore<SimpleFeatureType, SimpleFeature>) dataStore .getFeatureSource(typeName);

	featStore.setTransaction(transaction);
	try {
		featStore.addFeatures(featSrcCollection);
		transaction.commit();

		System.out.println("Incent done");
	} catch (Exception problem) {
		problem.printStackTrace();
		transaction.rollback();
	} finally {

		transaction.close();
	}
}

public static DataStore dataStore() throws Exception {

	DataStore dataStore = null;
	try {
		dataStore = getGeoWaveDataStore();
	} catch (IOException e) {
		// TODO Auto-generated catch block
		e.printStackTrace();
	}
	if (dataStore == null) {
		return null;
	}
	System.out.println("connection success");
	return dataStore;
}

private static DataStore getGeoWaveDataStore() throws IOException {
	return createGeoWaveDataStore();
}

public static Map<String, Serializable> getParams() {

	final Map<String, Serializable> params = new HashMap<>();
	params.put("zookeeper", zookeepers);
	params.put("instance", instanceId);
	params.put("user", user);
	params.put("password", password);
	params.put("namespace", tableName);
	params.put("gwNamespace", gwNamespace);

	params.put("Lock Management", "memory");
	params.put("Authorization Management Provider", "empty");
	params.put("Authorization Data URL", null);
	params.put("Transaction Buffer Size", 10000);
	params.put("Query Index Strategy", "Heuristic Match");
	return params;
}

private static DataStore createGeoWaveDataStore() throws IOException
{
	final Map<String, Serializable> params = getParams();
	final boolean useMock = false;
	DataStore dataStore = null;
	try {
		final StoreFactoryFamilySpi storeFactoryFamily;
		if (useMock) {
			storeFactoryFamily = new MemoryStoreFactoryFamily();
		} else {
			storeFactoryFamily = new AccumuloStoreFactoryFamily();
		}
		final GeoWaveGTDataStoreFactory geoWaveGTDataStoreFactory = new GeoWaveGTDataStoreFactory(
				storeFactoryFamily); // geotools 호출
		dataStore = geoWaveGTDataStoreFactory.createDataStore(params); // createNewDataStore(params);

	} catch (IOException e2) {
		;
	}

	return dataStore;
}

//-----------------------------------------------------
FYI 'DataStore' is imported form  'org.geotools.data.DataStore'.

How to get layer's 'InternalAdapterId' saved inside Accumulo using Geo-tools or the other way?

Did you know how to control the Geowave CLI in Java Eclipse? It looks like not to access Accumulo at Geowave-ingest. Don't u have some manual for control this at Eclipse?

This is the source for deal. but not perfect :
//-------------
public static void main(String[] args) throws Exception {
final String[] args1 = StringUtils.split(
"ingest localToGW -datastore sejong -f geotools-vector -b "+Ingesting+" -gwNamespace geowave.geowave -instance accumulo -user geowave -password geowave -zookeeper zookeeper:2181",
' ');
		for(String str:args1){ System.out.printf(str);}
		System.out.println(" ");
		GeoWaveMain gwm=new GeoWaveMain();
		//GeoWaveMain.run(args1);
		gwm.main(args1);

		System.out.println("!!!!!!");

}

//--------------------
Please answer my questions ASAP
Thank you for ur reading !! :)

While trying to setup GeoWaveMain with the commandline args should  work it seems cumbersome.  Our primary programmatic API is also called a DataStore.  We have some simplistic examples of ingesting data using the IndexWriter.
I'm unsure what exactly you're trying to do with these questions.  Basically our intent is that public API access shouldn't require access to the InternalAdapterStore.  Were you running into issues without it? If you really were to require it, you can instantiate an InternalAdapterStoreImpl given AccumuloOperations.  Here's a simple example of creating the operations

i appreciate your quick answer. I'm gonna consider how to use ur code in my one. And then it is my bad habit to speak specific explanation unclear especially in tech., even my mother tongue as well. lol
So I try to talk why ask it to u clearly this place but if something is not enough, plz let me know about it. i have fix it up.
As told u above, i'm handling Geowave java -api for viewing on Web in Non-commercial intent. As  unclearly know the Geowave, basic functions such  a uploading shapefile, viewing lists, deleting layer etc. was made by Geotools. And the code above is the result to upload shapefile from window to geowave-Accumulo. but ya file uploading is good but recording meta info in accumulo is not. So, i ask that fist question, reason why double write on there. and how to fix up. Third question is plan B.
Then, why i need to access 'InternalAdapterId', because a searching key in accumulo is typename(=shaep file layer name as well) on previous jar file version. So i built up my code according to that.  The newest jar version updated is not found the layer and meta info. on my source because of InternalAdapterId. All function which i'd written is fallen. so i asking How to get it.
it's the my story why i asking like that. said again plz if you didn't understand something, feel free asking  me.  and then have some the other advice about my problem as well comment anytime Please.
Thank you
Plus. what is setting up the 'shape file Path' in  the 'IndexWriter'???

plus; could i get the 'IndexWriter' code before applying to create 'InternalAdapterId'??? Please

Hi i got the double record problem finally but, sadly it has 'InternalAdapterId' you've added lately. so can i get a previous version before applying that?? SimpleIngestIndexWriter.java and SimpleIngest.java both

an example for you to get the internal adapter ID in your particular case using accumulo is here:
InternalAdapterStore internalAdapterStore = new InternalAdapterStoreImpl(new BasicAccumuloOperations(
				zookeepers,
				accumuloInstance,
				accumuloUser,
				accumuloPass,
				geowaveNamespace));
Short internalAdapterId = internalAdapterStore.getInternalAdapterId(<adapter ID>);

the  is the one you had been using previously, and its equal to new ByteArrayId(<feature type name>)

Thanks very


Skip test until 8.16

Description
Let's give conll2004 data server some more time to fix on their end.
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[x] Feature1, tests, (and when applicable, API doc)
[x] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Job PR-260/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-260/1/index.html


Updated old button references in dev/integration_tests/flutter_gallery ... persistent_bottom_sheet_demo

Replaced uses of FlatButton with TextButton and RaisedButton with ElevatedButton, per #59702.

Withdrawing this for the moment because https://github.com/flutter/flutter/issues/63428


New alpha calculator: top two

This adds a new method of alpha calculation, implementing point 4 in #37.
It has advantages from both CalculatorMax and CalculatorLinear:

No incongruous black or bright patches.
Power parameter allows transition sharpness to be controlled:

With a low power, large regions can blend terrains evenly.
With a high power, output will probably look like CalculatorMax.
With a moderate power, blended pixels are mostly confined to borders (the result looks like antialiased output from CalculatorMax).

Calculations work correctly even with high powers.
Calculations are simpler than CalculatorLinear.
Ignoring the quantisation, I think the function is continuous everywhere except a region with dimension 1.

I added an optional field to the options file, to control the power parameter.
Since this calculator has output very similar to CalculatorLinear at low powers, and isn't affected by #51, it might be worth removing CalculatorLinear once this is merged.
TODO:

[x] Add tests (#69).
[x] Fix failing tests.
[x] Add to CMakeLists.txt.

Rebased on master.


Fix bibtex

as an extra { in title was breaking my reference section for my LBD submission 😭

👍

Good catch! 😅


Full support for UGUI

All commands now work for TextMeshProUGUI components as well.

Omfg amazing. Thank you

Thanks for doing this.

This is fantastic, thank you so much for this!


V3 (Reanimated & Gesture Handler)

This is a work-in-progress reimplementation of this plugin using react-native-reanimated@2 and react-native-gesture-handler. These libraries are new, and very performant, and we hope to be able to resolve some performance issues on old Android devices.
Breaking changes

I believe react-native-reanimated@2 requires hermes. Android now supports this library without hermes now (this PR) but I'm not clear on the details.
Reanimated also requires react-native 0.62+.
Most of the props from v2 are not implemented yet, and it is yet to be determined whether they will or should be, as some are related to the previous implementation's gesture responder system.

It is possible that these changes are too extensive for a v2-v3 migration with breaking changes, and that a separate version of the library should be made.
https://user-images.githubusercontent.com/42827/151675363-3c901a36-88c7-4372-bcd5-e2499dd5fb40.mov

Hi, thank you for your great work! What is the current status of this PR?

Hi @pierretoussing! This PR is abandoned now, especially with new work that's gone into the main branch since this was done.
I think the best solution would be a new library with a reanimated implementation, because of how difficult it will be to re-implement all these changes and keep feature parity with the existing component's API. It's just too much. Starting over from scratch would be a better idea.
I don't think we have the time for a full rewrite at this stage, especially since the zoomable view suits our needs for the most part!


inner column overflow during resize

hi,
I was testing responsiveness and encountered this.
what I was trying to achieve is items inside div 'col' content should not touch the edge
before

after

link to the testing code if required
http://www.cssdesk.com/BC8ku
cheers

You should be using a .container around the main grid. For now, nested columns/rows aren't supported, but I'll add this in v1.0.0.

ok got it, thanks


Getting NoClassDefFoundError

Hi,
I added the certificate transparency logger to my project and I am getting the below crash for NoClassDefFoundError.
implementation 'com.appmattus.certificatetransparency:certificatetransparency-android:1.1.0'
java.lang.NoClassDefFoundError: Failed resolution of: Lorg/bouncycastle/tls/TlsUtils;
at com.appmattus.certificatetransparency.internal.utils.X509CertificateExtKt.parseSctsFromCertExtension(X509CertificateExt.kt:52)
at com.appmattus.certificatetransparency.internal.utils.X509CertificateExtKt.signedCertificateTimestamps(X509CertificateExt.kt:43)
at com.appmattus.certificatetransparency.internal.verifier.CertificateTransparencyBase.hasValidSignedCertificateTimestamp(CertificateTransparencyBase.kt:127)
at com.appmattus.certificatetransparency.internal.verifier.CertificateTransparencyBase.verifyCertificateTransparency(CertificateTransparencyBase.kt:95)
at com.appmattus.certificatetransparency.internal.verifier.CertificateTransparencyInterceptor.intercept(CertificateTransparencyInterceptor.kt:69)
Thanks
Ankit

This looks likely to be a conflict with the version of bouncycastle being resolved by your project. Some of these classes moved from version 1.6x to 1.7x which we currently use.
It would be worth running  ./gradlew app:dependencies and seeing what versions were resolved


IMPROVE: Token view

Please update the token view for chains according to figma . To have Value on the right matching main view and add comma seperators for tokens with more than 1,000 tokens to have a clearer display.

@realpaaao basically what you want is to invert the order, so on the right side the dollar and bellow the amount in tokens?


My divs container go crazy

I have 3 different slides, each slide have different items. Here's my problem: when the first slide's items move, the others slides move vertically and I don't know why, is it a bug?

Hey, I'm going to close this, because there is no test case, per the contributing guidelines. My guess without seeing it is that there might be overlap in the selector used for the slicks

sorry, here is http://jsfiddle.net/moisesnandres/vyz5593d/
it's run normally but when I use images , the divs crash

Hmm, I don't see any issue.

In jsfiddle not, but in my project does, but I fix it, well I just remove padding in section

Okay. Yeah the idea behind asking for the fiddle was to recreate the issue.
Good luck!
On Thu, Jan 21, 2016 at 5:50 PM, Moisés Ñañez<EMAIL_ADDRESS>wrote:

In jsfiddle not, but in my project does, but I fix it, well I just remove
padding in section
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/2056#issuecomment-173740830.

I've never used fiddle for issues, sorry if I didn't kwow the rules before asking

All good, brother!
On Thu, Jan 21, 2016 at 6:03 PM, Moisés Ñañez<EMAIL_ADDRESS>wrote:

I've never used fiddle for issues, sorry if I didn't kwow the rules before
asking
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/2056#issuecomment-173743608.


Update README.md #important

Added scroll to top button at the end of the readme file to improvise the user friendly experience

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)docs update

Why was this change needed? (You can also link to an open issue here)

Other information:

@tenokami @larinam @jbampton
kindly review the pr

Thank you so much!
We had a similar PR previously which was also closed.
I suggest you check out docs/pages for documentation contributions.


cv2.cuda_GpuMat <-> TensorFlow vector / TensorFlow NumPy

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): TF  2.3
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
Recently presented API between Numpy and TensorFlow, allows to speed up Numpy functions by utilinzf CUDA supporting GPU's, as demonstrated here.
Many Computer Vision tools use OpenCV, Numpy and  TensorFlow functions to resolve Computer Vision tasks.
OpenCV has a class allowing moving calculations intenstcive functions to GPU, via the CUDA-accelerated Computer Vision.
Pyhton API is less documented but an introduction can be seen here.
Currnlty  OpenCV cuda_GpuMat, TensorFlow vectors / TensorFlow NumPy ndArrays are stored in CUDA memory.
An efficient and easy to use type conversion  between OpenCV cuda_GpuMat and TensorFlow vector / TensorFlow NumPy in both directions will allow development of efficient applications that utilize OpenCV, Numpy and  TensorFlow without obsolete memory copies.
Will this change the current api? How?
Add new 0 copy convertions between tf.experimental.numpy and cv2.cuda_GpuMat classescv2.cuda_GpuMat
Who will benefit with this feature?
Computer Vision developers
Any Other info.

TensorFlow supports DLPack for 0-copy conversions. Could that work here ?


Our Paths section - Improve design & responsiveness

Description

Fix the mobile view to match the figma design
More fixes & adjustments to the component

Screenshots
current design

figma

Additional information
No response

@RoyTennenbaum please assign me for this issue


Allow backslash, carriage return in PQL strings

Overview
[Describe what this pull request addresses.]
Fixes #
Pull request checklist

[ ] I have read the contributing guide.
[ ] I have agreed to the Contributor License Agreement.
[ ] I have updated the documentation.
[ ] I have resolved any merge conflicts.
[ ] I have included tests that cover my changes.
[ ] All new and existing tests pass.

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.

This change works for me as I expect. @jaffee or @alanbernstein do either of you have any reservations with applying this change to master?

Actually, I just noticed a problem trying this:
curl -X POST http://localhost:10101/index/i/query -d 'SetColumnAttrs(1, name="left \"inner\" right")'

I'm not sure how to escape double quotes within a double-quoted string.
When I revert to the existing peg file, the above query results in this:
{"results":[{"attrs":{},"columns":[1]}],"columnAttrs":[{"id":1,"attrs":{"name":"left \\\"inner\\\" right"}}]}

which seems to me like it's over-escaping things.

@travisturner I've pushed a fix. All tests pass, even the one that failed earlier.

That curl command works with the latest fix:
curl -X POST http://localhost:10101/index/i/query -d 'SetColumnAttrs(1, name="left \"inner\" right")'
{"results":[null]}

I think what I'm struggling with is determining how/if the parser handles escaping, and I don't think it really does. The changes made so far allow it to parse the PQL without error, but I don't think the results that we get are expected.
For example (payloads provided with curl -X POST http://localhost:10101/index/i/query -d:
1) 'SetColumnAttrs(1, name="one \"foo\" three")' ---> "attrs":{"name":"one \\\"foo\\\" three"}
2) "SetColumnAttrs(1, name='one "foo" three')"   ---> "attrs":{"name":"one foo three"}
3) "SetColumnAttrs(1, name='one \"foo\" three')" ---> "attrs":{"name":"one \"foo\" three"}
4) 'SetColumnAttrs(1, name="one \'foo\' three")' ---> [isn't a complete bash command]
5) 'SetColumnAttrs(1, name="one 'foo' three")'   ---> "attrs":{"name":"one foo three"}

I think some of my confusion here has to do with the combination of bash and PQL parsing.

seems to result in the escaped, literal characters of the \"
this may be an issue with bash parsing, but the double quotes get lost completely here.
in a way this seems correct, but it wasn't intuitive
this is the inverse (single/double quote) of (3) and it isn't a valid command.
similar to (2)

The following test for this fix passes just fine, so I don't think the problem is with the parser:
q, err := pql.ParseString(`MyCall( key= value, foo='bar', age = 12 , bool0=true, bool1=false, x=null, escape="\" \\escape\n"  )`)
...
reflect.DeepEqual(q.Calls[0],
			&pql.Call{
				Name: "MyCall",
				Args: map[string]interface{}{
					"key":    "value",
					"foo":    "bar",
					"age":    int64(12),
					"bool0":  true,
					"bool1":  false,
					"x":      nil,
					"escape": `\" \\escape\n`,
				}

Checking where else the problem can be.

Btw, I've ran the following query with the Go client, and the problem happens with that too:
	attrs := map[string]interface{}{
		"name": "left \"inner\" right",
	}
	_, err = client.Query(i.BatchQuery(
		f.Set(5, 10),
		i.SetColumnAttrs(10, attrs),
	))

I've added the following code to the Go client test, and I think there's no problem at all:
	resp, err := client.Query(f.Row(5), pilosa.OptQueryColumnAttrs(true))
	if err != nil {
		panic(err)
	}
	fmt.Println(resp.Column())

Prints: {10  map[name:left \"inner\" right]}

I think everything's alright. I've decoded the response coming from curl in python, and this is what I get:
>>> s = '''{"results":[{"attrs":{},"columns":[10]}],"columnAttrs":[{"id":10,"attrs":{"name":"left \\\"inner\\\" right"}}]}'''
>>> json.loads(s)
{u'columnAttrs': [{u'id': 10, u'attrs': {u'name': u'left "inner" right'}}], u'results': [{u'attrs': {}, u'columns': [10]}]}

Everything is not alright. There's an extra slash being appended. Here's some client code:
	client := pilosa.DefaultClient()
	schema, err := client.Schema()
	if err != nil {
		panic(err)
	}
	i := schema.Index("i")
	f := i.Field("f")
	attrs := map[string]interface{}{
		"name": `left "inner" right`,
	}
	_, err = client.Query(i.BatchQuery(
		f.Set(6, 60),
		i.SetColumnAttrs(60, attrs),
	))
	if err != nil {
		panic(err)
	}
	resp, err := client.Query(f.Row(6), pilosa.OptQueryColumnAttrs(true))
	if err != nil {
		panic(err)
	}
	ci := resp.Column()
	name := ci.Attributes["name"]
	fmt.Println(name, name == `left "inner" right`)
}

Checking to see where the problem is...

I think I've found the problem. The Go client auto-escapes quotes, so
`left "inner" right` becomes `left \"inner\" right`

But the server interprets the value of an attribute as a raw string, so sends back
left \"inner\" right

Although it should have unquoted that string and sent:
left "inner" right

OK, found the fix. It's a bit rough now, will clean it up and push.

Pushed the fix. Escape characters were not supported in attribute values before this fix.

Output of curl with the latest commit:
$ curl -X POST http://localhost:10101/index/i/query?columnAttrs=true -d 'Row(f=6)'
{"results":[{"attrs":{},"columns":[60]}],"columnAttrs":[{"id":60,"attrs":{"name":"left \"inner\" right"}}]}

I've disabled unescaping for single quoted strings, since strconv.Unquote doesn't support that.


Allow cross-querying weightings for hybrid mode

Currently we can prepare a profile for hybrid mode (calculate landmarks). The weighting we use with these landmarks does not necessarily have to be the same as the one we used for the preparation. We can use any weighting as long as all edge weights calculated with this weighting are equal or larger in weight than the ones used during the preparation. So it would be useful to be able to 'cross-query': Use some existing landmarks with a weighting other than the one that was used during preparation.
Maybe we can do it like this:
profiles:
  - name: my_car
    vehicle: car
    weighting: some_weighting
  - name: my_adjusted_car
    vehicle: car
    weighting: other_weighting
lm_profiles:
   # this means we will calculate landmarks for the 'my_car' profile
  - name: my_car
  # this means we do *not* calculate landmarks for the 'my_adjusted_car', but we can use still use
  # the 'my_adjusted_car' profile in hybrid mode and it will use the landmarks from the 'my_car' profile
  - name: my_adjusted_car
    landmarks: my_car

The route calculation will only be correct if all edge-weights returned by other_weighting are equal or larger than those returned from some_weighting.

Instead of landmarks we could use preparation_profile, that would make it more clear that this is meant to be a reference to another profile.


Could you update latest version?

@c9s @marcioAlmada
Could you update CHANGES.md and phpbrew binary file? :smiley:

https://github.com/phpbrew/phpbrew/releases/tag/1.20.4

I just run phpbrew self-update. results are follows.
$ phpbrew self-update

Initialization successfully finished!
<=====================================================>
Phpbrew environment is initialized, required directories are created under

    /Users/usr0600244/.phpbrew

Paste the following line(s) to the end of your ~/.bashrc and start a
new shell, phpbrew should be up and fully functional from there:

    source /Users/usr0600244/.phpbrew/bashrc

To enable PHP version info in your shell prompt, please set PHPBREW_SET_PROMPT=1
in your `~/.bashrc` before you source `~/.phpbrew/bashrc`

    export PHPBREW_SET_PROMPT=1

For further instructions, simply run `phpbrew` to see the help message.

Enjoy phpbrew at $HOME!!

<=====================================================>
phpbrew - 1.20.3
cliframework core: 2.5.4

current version is 1.20.3:
CHANGES.md
CHANGES
=======

### Version 1.20.3 - Mon Dec  7 23:56:32 2015

- Fixed duplicated getBuild method in SystemCommandException
- Fixed class loading for symfony yaml component with new cliframework

Updated in f8c3b98..c004c4e

Thanks! :smile:


Transfer github repo and update bower URL

Hi, I'm going to transfer a repo from an organization to a member on github and I'm worried how do I keep bower working.
Will work it automatically from redirect 401/redirect github or something like that?
Or should I unregister and then register with same name(is that possible)?
I don't want to change the name on bower, want to keep because the bower is well used.
Thanks

You can follow the below command (You have to be the author of the bower package)
bower unregister packagename
bower register packagename url.

I'm collaborator of the project. Is that mean I'm also the author of the bower package? Because the person in charge no longer access github...

Thanks @rajzshkr it worked like a charm!


Docs version?

if version 2, there's no way to edit the readthedocs page. There's a misstake in the fullscreen example, here's the correct version (missing an import):
from prompt_toolkit import Application
from prompt_toolkit.buffer import Buffer
from prompt_toolkit.layout import Layout
from prompt_toolkit.layout.containers import VSplit, Window
from prompt_toolkit.layout.controls import BufferControl, FormattedTextControl

buffer1 = Buffer()  # Editable buffer.

root_container = VSplit([
    # One window that holds the BufferControl with the default buffer on
    # the left.
    Window(content=BufferControl(buffer=buffer1)),

    # A vertical line in the middle. We explicitely specify the width, to
    # make sure that the layout engine will not try to divide the whole
    # width by three for all these windows. The window will simply fill its
    # content by repeating this character.
    Window(width=1, char='|'),

    # Display the text 'Hello world' on the right.
    Window(content=FormattedTextControl(text='Hello world')),
])

layout = Layout(root_container)

app = Application(layout=layout, full_screen=True)
app.run()

Hi @ConsoleTVs,
Thanks a lot for this feedback!
Is it possible that this was fixed by @pythonpsql in https://github.com/jonathanslenders/python-prompt-toolkit/commit/a306d41c90b2a67fe72ab781355f549e656f76d2#diff-f4a0fa4b98cb834cf047c187ce976ddb
If so, I'll close this issue.

I guess ^^


Set 2.1 baselines

Is this a duplicate for issue #445 ?

No, #445 targets release/2.1, this targets dev.


error: ‘memcpy’ was not declared in this scope

I am trying to build this package on my virtual machine:

Ubuntu 16.04
No GPU (hence no CUDA)
I have already installed Intel Parallel Studio XE 2018.

Here is the details of the error message I get:
g++ -Wall -O3 -std=c++11 -I/include -I/data/util/intel/mkl/include -I/data/util/intel/tbb/include -Iinclude -fPIC -MMD -c -o build_cpuonly/objs/cxx/nn/one_hot.o src/nn/one_hot.cpp
g++ -Wall -O3 -std=c++11 -I/include -I/data/util/intel/mkl/include -I/data/util/intel/tbb/include -Iinclude -fPIC -MMD -c -o build_cpuonly/objs/cxx/nn/variable.o src/nn/variable.cpp
g++ -Wall -O3 -std=c++11 -I/include -I/data/util/intel/mkl/include -I/data/util/intel/tbb/include -Iinclude -fPIC -MMD -c -o build_cpuonly/objs/cxx/nn/square_error.o src/nn/square_error.cpp
g++ -Wall -O3 -std=c++11 -I/include -I/data/util/intel/mkl/include -I/data/util/intel/tbb/include -Iinclude -fPIC -MMD -c -o build_cpuonly/objs/cxx/nn/is_equal.o src/nn/is_equal.cpp
src/nn/one_hot.cpp: In instantiation of ‘void gnn::OneHot<mode, Dtype>::Forward(std::vector<std::shared_ptrgnn::Variable >&, std::vector<std::shared_ptrgnn::Variable >&, gnn::Phase) [with mode = gnn::CPU; Dtype = float]’:
src/nn/one_hot.cpp:54:1:   required from here
src/nn/one_hot.cpp:43:9: error: ‘memcpy’ was not declared in this scope
memcpy(output.data->row_ptr, idxes.data(), sizeof(int) * idxes.size());
^
src/nn/one_hot.cpp:44:9: error: ‘memcpy’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
memcpy(output.data->col_idx, input.data->ptr, sizeof(int) * input.rows());
^
src/nn/one_hot.cpp:43:9: note: ‘memcpy’ declared here, later in the translation unit
memcpy(output.data->row_ptr, idxes.data(), sizeof(int) * idxes.size());
^
src/nn/one_hot.cpp: In instantiation of ‘void gnn::OneHot<mode, Dtype>::Forward(std::vector<std::shared_ptrgnn::Variable >&, std::vector<std::shared_ptrgnn::Variable >&, gnn::Phase) [with mode = gnn::CPU; Dtype = double]’:
src/nn/one_hot.cpp:54:1:   required from here
src/nn/one_hot.cpp:43:9: error: ‘memcpy’ was not declared in this scope
src/nn/one_hot.cpp:44:9: error: ‘memcpy’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
memcpy(output.data->col_idx, input.data->ptr, sizeof(int) * input.rows());
^
src/nn/one_hot.cpp:43:9: note: ‘memcpy’ declared here, later in the translation unit
memcpy(output.data->row_ptr, idxes.data(), sizeof(int) * idxes.size());
^
Makefile:53: recipe for target 'build_cpuonly/objs/cxx/nn/one_hot.o' failed

Hi, I've added the cstring header, could you please check again?

I included the header <string.h> in "one_hot.cpp" and then the package was successfully built.
However, none of the examples could be built. Seems that the Makefiles are created assuming GPU_USE case. I even changed the lib_dir:=$(GNN_HOME)/build_cpuonly/lib in the Makefile, but I get this fatal error: thrust/device_vector.h: No such file

you can still install the cuda environment, even you don't have gpu.


Don't free non-heap b:changedtick value

The b:changedtick value is managed as part of the file_buffer buffer structure and not allocated with alloc(). As such, calling vim_free on it is invalid.

Discovered this compiling with -O3 -flto when playing around with compiler settings.

Nevermind I think I might have made a mistake here.

There's a clear check for DI_FLAGS_ALLOC, so the code path wouldn't have been triggered. I was kind of blindly following the compiler warning here. Either way this should have caused issues in the past if it was really freeing invalid memory.


[2.x] Change the regex command in install dashboard GHA + Increment version to 2.10.0

Description
Change the regex command in install dashboard GHA to handle generic format of version numbers. This PR also includes the  version bump to 2.10.0.
Category
Bug fix
Issues Resolved

Relate https://github.com/opensearch-project/security-dashboards-plugin/pull/1526
Resolve https://github.com/opensearch-project/security-dashboards-plugin/issues/1532

Testing
Before:

After:

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looking into this:
FAIL test/jest_integration/saml_auth.test.ts (35.497 s)
  start OpenSearch Dashboards server
    ✓ Login to app/opensearch_dashboards_overview#/ when SAML is enabled (21476 ms)
    ✕ Login to app/dev_tools#/console when SAML is enabled (114 ms)
    ✕ Login to Dashboard with Hash (109 ms)
    ○ skipped Tenancy persisted after Logout in SAML

  ● start OpenSearch Dashboards server › Login to app/dev_tools#/console when SAML is enabled

I don't think this is related to this change btw.
Reference:
https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/5733034965/job/15537963336?pr=1533#step:14:486

The current CI failure is introduced by the backport of this breaking change in core: https://github.com/opensearch-project/OpenSearch/pull/9006

Thank you @RyanL1997! This change (minus the version increment) should be done against main as well.

I'm seeing a lot of InvalidArgumentError: binary is not a Firefox executable in the build output.


Public top-level methods in patch files

As far as I know, dart2js should reject public API in patch files.
This indicates that it doesn't: https://codereview.chromium.org/45293002/patch/60001/70003

patches are now handled  by the CFE.


Add "View More" Button on Desktop/Laptop Devices

Issue: Add "View More" Button on Desktop/Laptop Devices
Description
Currently, all data is loaded at once on desktop/laptop devices. To improve the user experience and performance, limit the data displayed to 14 items at a time. A "View More" button should be added, which, when clicked, will load the next set of 14 items.
Requirements

Display a maximum of 14 items initially.
On clicking the "View More" button, load the next set of 14 items.
The button should only appear if there are more than 14 items available.
Ensure that the button continues to load more data until all items are displayed.
Once all data is loaded, the button should either disappear or be disabled.

Steps to Contribute
1. Fork the Repository
Click the Fork button at the top right of this repository's page to create a copy of the repo under your GitHub account.
2. Clone it to Your Local Machine
Open your terminal and use the following command to clone the repo:
git clone https://github.com/your-username/repo-name.git

3. Implement the "View More" Button
Step 1: Identify the section where the data is rendered in the code.
Step 2: Update the logic to display only 14 items initially.
Step 3: Add a "View More" button after the data list.
Step 4: Implement a function that will load the next 14 items when the button is clicked.
Step 5: Continue to load more data as long as items are available, and hide/disable the button once all items are displayed.
4. Ensure Responsiveness
The "View More" button should only be displayed on desktop/laptop devices. Make sure it is hidden on mobile/tablet views.
5. Test Your Changes
Test the functionality across different desktop screen sizes to ensure:
Data is properly limited to 14 items at first.

Clicking the "View More" button loads the next 14 items.
The button disappears or is disabled after all data has been loaded.
The feature does not interfere with mobile/tablet views.

6.  Create a Pull Request
Push your changes to your forked repository:
git push origin main

Go to the original repository and create a pull request with a description of the changes made.

hey @Arijit-017 i would like to work on it


Switch to more inclusive language

Could you please take some time in the next few days to make changes to some terminology in your repos and content as much as is possible:

Whitelist/blacklist to Allowed List and Blocked List (or Approve List/Deny List - some software uses this instead) respectively. Google and many developers are formalizing allowlist and blocklist. You might want to lobby for those terms to be used in the UI.
Master/Slave to master and replica (or subordinate, if that makes more sense) respectively.

If you cannot remove the term because the writing for example reflects the UI or the code, please make a note and send me an email to<EMAIL_ADDRESS>so we can bring it that team’s attention. Thanks for your efforts in this matter.

Thank you for bringing this up.  The code was part of the framework that this project was forked from, so I wasn't even aware of it.  I have changed all instances I could find.

@jschomay Thanks for the quick changes Jeff.


Changes to zpa_application_segment_browser_access.clientless_apps.certificate_id forces replacement

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v1.5.7
on darwin_arm64
+ provider registry.terraform.io/zscaler/zpa v3.33.7

Affected Resource(s)

zpa_application_segment_browser_access

Terraform Configuration Files

locals {
  cert_name          = "cert_name"
  server_group_name  = "server_group_name"
  segment_group_name = "segment_group_name"
}

data "zpa_ba_certificate" "example" {
  name = local.cert_name
}
data "zpa_server_group" "example" {
  name = local.server_group_name
}
data "zpa_segment_group" "example" {
  name = local.segment_group_name
}

resource "zpa_application_segment_browser_access" "example" {
  name             = "example"
  tcp_port_ranges  = ["443", "443"]
  domain_names     = ["example.test"]
  segment_group_id = data.zpa_segment_group.example.id

  clientless_apps {
    name                 = "example.test"
    application_protocol = "HTTPS"
    application_port     = "443"
    certificate_id       = data.zpa_ba_certificate.example.id
    domain               = "example.test"
  }
  server_groups {
    id = [data.zpa_server_group.example.id]
  }
}

Debug Output

Panic Output

Expected Behavior

Update the browser access segment to use a new certificate.
Actual Behavior

Forces a replacement for the browser access segment, which regenerates the CNAME, taking app offline.
Steps to Reproduce

terraform apply
Change local.cert_name to a different cert
terraform apply

Important Factoids

Changing the assigned certificate for a browser access segment in the web console does not force a replacement.
References

@dli-spoton There's a currently an API issue which force us to rebuild the application segment whenever an attribute within the clientless_apps block is changed.
The issue is currently under investigation and once addressed at the API level, we will re-evaluate the removal of the force replacement behavior from the provider source code.
Zscaler DevRel

@dli-spoton The issue related to Browser Access Application segment forced replacement (Updates), has been addressed in the latest version v3.33.9 of the ZPA Terraform provider.
If you have any issues please contact Zscaler support for further assistance.
Zscaler DevRel


[move] sui framework cleanup

Moving collection, bag, object_basics to examples
Deleting redundant implementations of transfer on types with store
Fixing the numerous tests that expect object_basics to be part of the framework :/

Please check documentation as well. There might be links to any of the modules (I assume object_basics is the one that is referenced there)
Cc @Clay-Mysten

Please check documentation as well. There might be links to any of the modules (I assume object_basics is the one that is referenced there)
Cc @Clay-Mysten

Yes, thank you @damirka! @sblackshear can we go over the effects of this together? I am wondering if there are changes needed beyond links, as well, as as the switch from transfer to split_and_transfer here. I assume that is not in all cases but want to confirm. We don't seem to mention it now:
/Users/claymurphy/vscode/sui
claymurphy@Clays-MacBook-Pro sui % grep -r -i split_and_transfer doc
claymurphy@Clays-MacBook-Pro sui %

Thanks!

@Clay-Mysten on docs, I would not expect this to have any effects. I took a careful look at this and:

There are no links to fix
There is no switch from coin::transfer to coin::split_and_transfer, we are simply removing coin::transfer. We have already been asking folks to use transfer::transfer for some time (which most code examples/tests already do), this is just removing one "wrong" way to do things.
object_basics is not mentioned in any docs except in a (harmless) example of a log message where the name is not meaningful
bag and collection are not used in docs
sui::transfer is used in a tutorial, so I left it in for now. Later, we should remove this and update the tutorial, but I don't want to add that to this already-large PR
There are no other uses of ::transfer (e.g., coin::transfer or sui::transfer) except for the expected transfer::transfer and transfer::transfer_to_object

I am planning to land this as soon as I can because there are many potential conflicts with tests and genesis. But please let me know if you have concerns beyond the above and we can discuss!

@sblackshear I should replace here though, correct?:
coin::transfer

@sblackshear I should replace here though, correct?:
claymurphy@Clays-MacBook-Pro sui % grep -r -i "coin::transfer" doc
doc/src/contribute/cli-client.md:    coin::transfer(c, Address::new(recipient))
claymurphy@Clays-MacBook-Pro sui %

We could replace this, but the snippet is already out-of-date on other ways (e.g., Address::new(recipient) is no longer needed/will not work). I think it would be best for us to take on the bigger task of refactoring cli-client.md to call a function other than sui::transfer--perhaps coin::split_and_transfer would be a good candidate.


FAPI-CIBA Bug : existing AccountFormServiceTest and LDAPUserLoginTest fails due to modifying testrealm.json

According to https://github.com/tnorimat/keycloak/pull/6/checks?check_run_id=1333282485
2020-10-30T23:09:38.0697679Z -- [INFO]
2020-10-30T23:09:38.0699234Z -- [INFO] Results:
2020-10-30T23:09:38.0699851Z -- [INFO]
2020-10-30T23:09:38.0700456Z -- [ERROR] Failures:
2020-10-30T23:09:38.0701476Z -- [ERROR]   AccountFormServiceTest.applications:1252
2020-10-30T23:09:38.0708555Z -- Expected: iterable over ["root-url-client", "Account", "Account Console", "Broker", "test-app", "test-app-scope", "third-party", "test-app-authz", "My Named Test App", "Test App Named - ${client_account}", "direct-grant", "custom-audience"] in any order
2020-10-30T23:09:38.0710153Z --      but: Not matched: "ciba-login-hint-encypted"
2020-10-30T23:09:38.0711551Z -- [ERROR]   AccountFormServiceTest.applicationsVisibilityNoScopesAndConsent:1236
2020-10-30T23:09:38.0713657Z -- Expected: iterable over ["root-url-client", "Account", "Account Console", "test-app", "test-app-scope", "third-party", "test-app-authz", "My Named Test App", "Test App Named - ${client_account}", "direct-grant", "custom-audience"] in any order
2020-10-30T23:09:38.0715028Z --      but: Not matched: "ciba-login-hint-encypted"
2020-10-30T23:09:38.0716696Z -- [ERROR]   AccountFormServiceTest.applicationsVisibilityNoScopesNoConsent:1209
2020-10-30T23:09:38.0718943Z -- Expected: iterable over ["Account", "Account Console", "test-app", "test-app-scope", "third-party", "test-app-authz", "My Named Test App", "Test App Named - ${client_account}", "direct-grant", "custom-audience"] in any order
2020-10-30T23:09:38.0720197Z --      but: Not matched: "ciba-login-hint-encypted"
2020-10-30T23:09:38.0720810Z -- [ERROR] Errors:
2020-10-30T23:09:38.0722383Z -- [ERROR]   LDAPUserLoginTest>AbstractKeycloakTest.beforeAbstractKeycloakTest:169->AbstractLDAPTest.importTestRealms:85->afterImportTestRealm:111 ﾂｻ RunOnServer
2020-10-30T23:09:38.0725122Z -- [ERROR]   LDAPUserLoginTest>AbstractKeycloakTest.beforeAbstractKeycloakTest:169->AbstractLDAPTest.importTestRealms:85->afterImportTestRealm:111 ﾂｻ RunOnServer
2020-10-30T23:09:38.0757035Z -- [ERROR]   LDAPUserLoginTest>AbstractKeycloakTest.beforeAbstractKeycloakTest:169->AbstractLDAPTest.importTestRealms:85->afterImportTestRealm:111 ﾂｻ RunOnServer
2020-10-30T23:09:38.0760159Z -- [ERROR]   LDAPUserLoginTest>AbstractKeycloakTest.beforeAbstractKeycloakTest:169->AbstractLDAPTest.importTestRealms:85->afterImportTestRealm:111 ﾂｻ RunOnServer
2020-10-30T23:09:38.0761632Z -- [INFO]
2020-10-30T23:09:38.0762222Z -- [ERROR] Tests run: 3370, Failures: 3, Errors: 4, Skipped: 170

It seems that AccountFormServiceTest failed due to modifying testrealm.json by https://github.com/tnorimat/keycloak/pull/5/files?file-filters[]=.html&file-filters[]=.js&file-filters[]=.json&file-filters[]=.properties#diff-99bcd16cbfd7e418a2f7fe1cb8c76e9e323e63b17ddd1d1f49c9462966c3e28a

resolved by https://github.com/tnorimat/keycloak/pull/7


Memoize node presenters

We were creating far more instances of NodePresenter and its subclasses than we needed. This in turn meant we were creating far more instances of SmartAnswer::ErbRenderer and thence ActionView::Base than necessary. It may well also have meant that we were unnecessarily re-rendering the same template multiple times.
In a recent release, all flows were converted to use ERB rendering for questions instead of YAML I18n rendering. This release coincided with the app using a lot more memory (private link). We have some evidence to suggest that making this change will (at the very least) reduce memory usage of the app somewhat. However, we haven't been able to unambiguously reproduce the memory usage problem we're seeing in production, so it's difficult to know whether this will actually resolve the problem.
In working on this change, it's highlighted how tangled an inefficient this area of the codebase is (e.g. FlowPresenter#collapsed_questions indirectly calls Flow#process multiple times). I'm convinced that the code could be considerably simplified, but that's going to have to wait for another day.

Based on the suspicion that ActionView::Base is the root of the problem, I think some sensible follow-up steps to this PR would be to:

Re-use the same instance of ActionView::Base for all question node presenters for a given flow and another for all outcome node presenters.
Re-use the same instance of ActionView::Base for all node presenters for a given flow.

@chrisroos, @erkede: Is there any reason why I shouldn't merge this? I've addressed @erkede's earlier comment to memo-ize node presenters keyed on name in 1a79b4f3d66ac8c0abd18f978b2925da73261cfa.

Looks good to me.