Bluetooth: host: bt_conn_create_le sometimes fails to stop pre-scan before connecting

Describe the bug
The host API function bt_conn_create_le uses the HCI_LE_Create_Connection command to make the controller scan for and connect to an advertiser. However, before doing that, it appears that bt_conn_create_le is doing a pre-scan to find the advertiser, and this pre-scan sometimes appears to be terminated too late, i.e. the host sends the HCI_LE_Create_Connection command before it ends the scan. This causes the controller to reject the HCI_LE_Create_Connection command with a Command Disallowed error. This is seen quite frequently when using an nRF52840 dongle with the Zephyr host on top as a master device.
To Reproduce
Steps to reproduce the behavior:

From the application layer scan for an advertiser and stop scanning when found.
From the application layer call bt_conn_create_le to connect to the advertiser.
At this point the controller will do the pre-scan (requested by the host) and sometimes report a Command Disallowed error when trying to connect.

Expected behavior
The pre-scan done by bt_conn_create_le should end before the connecting starts, so it doesn't cause the connect to fail.
Impact
We are currently using this BLE master functionality for internal testing only, and we can work around it by adding retries, so the impact is not big yet. But very soon we will start using it in real products where these additional connection latencies may annoy the end user.
Screenshots or console output
None.
Environment (please complete the following information):

Zephyr release 2.0 (host running on Linux machine, controller running on nRF52840 dongle), or 2.1 release candidate.

Additional context
None.

the pre-scan done by the host sometimes appears to be terminated too late, i.e. the host sends the HCI_LE_Create_Connection command before it ends the scan

That sounds very strange. If you look at the implementation of the check_pending_conn() function in subsys/bluetooth/host/hci_core.c you'll see that it calls set_le_scan_enable(BT_HCI_LE_SCAN_DISABLE) before calling hci_le_create_conn(conn). These functions will queue up HCI commands in the order that they are called, so it should be impossible for the order to be the wrong way around. Do you have any HCI logs to corroborate this? If this is really happening then it is indeed a bug, but it'd be good to split it into a separate issue - the remaining things you describe are as designed currently so that's more of a feature request/enhancement than a bug.

This is seen quite frequently when using an nRF52840 dongle with the Zephyr host on top as a master device.

Can you also specify what your setup looks like? Is this a 2-chip solution or are you running both Host and Controller in the same nRF52840?

This pre-scan doesn't seem necessary, because the application layer will typically already have scanned for available advertisers, and, as mentioned, the controller will subsequently scan again to establish the actual connection.

Not completely unecessary. In cases with host-based privacy this stage is needed.
So making this stage optional in some cases would be an improvement. But it is wrong to call it a bug.

@jhedberg "Zephyr release 2.0 (host running on Linux machine, controller running on nRF52840 dongle), or 2.1 release candidate."
Is this the USB issue where they are on different endpoints? Maybe we don't wait for the command complete for disabling the scanner?

@jhedberg, we'll try to get a log.
@carlescufi, I've added more details about the environment.
@joerchan, so if the extra scan is for host privacy, it should go away if controller privacy is enabled?

Debugging this issue I found that the order of bt_hci_cmd_send_sync... and atomic_set_bit_to...in set_le_scan_enable seems to be relevant. If I switch order, the problem seems to go away (pending more testing).

joerchan, so if the extra scan is for host privacy, it should go away if controller privacy is enabled?

@wdhpawa They way privacy is implemented now we switch to host-based privacy when the controller resolving list is full. So the extra scan is needed if the controller does not support controller privacy, or the controller resolving list is full and we switched to host based privacy.

@joerchan, I see, and I agree that skipping the scan in some cases should be a separate enhancement if the command disallowed problem can be solved independently.

@carlescufi, I've added more details about the environment.
@wdhpawa  I still don't get exactly the setup you are using.

What Host are you using? Zephyr's? If so, how are you compiling it? with the native_posix board? With QEMU?
Regarding the controller, which board exactly are you building for, and what transport are you using, UART or USB?

@jhedberg "Zephyr release 2.0 (host running on Linux machine, controller running on nRF52840 dongle), or 2.1 release candidate."
Is this the USB issue where they are on different endpoints? Maybe we don't wait for the command complete for disabling the scanner?

That would be a data vs commands/events race, but not a sequence of HCI commands. I don't think this is the issue.

@carlescufi  It is a Zephyr native posix application. We are using two different controller boards. One nRF52840 (PCA10059), and a PTS dongle from Blouetooth.org.

@carlescufi It is a Zephyr native posix application. We are using two different controller boards. One nRF52840 (PCA10059), and a PTS dongle from Blouetooth.org.

Can we please get a full HCI trace using btmon? With this setup it should work out of the box.

@ChristofferSchroeder
Using this combination you should be able to get a full HCI log using btmon. Please attach it to the issue so we can check it out.

I've split the pre-scan removal into a separate issue #20698 as suggested.

@carlescufi Please see this log.
cmd_disallowed.txt

Please see this log. cmd_disallowed.txt

Thanks @ChristofferSchroeder . The log really does show HCI_LE_Create_Connection before HCI_LE_Set_Scan_Enable(Disabled), which is really remarkable. Is this really an unmodified Zephyr host stack you're using? Which version? In latest master the reacting to a connectable advertising event that we want to connect to goes through the following calls in hci_core.c before reaching the point where hci_le_create_conn(conn) is called:
le_adv_report() -> check_pending_conn() -> set_le_scan_enable(BT_HCI_LE_SCAN_DISABLE) -> bt_hci_cmd_send_sync()
Note that the _sync() variant of the command sending is used, i.e. the HCI_LE_Create_Connection shouldn't even be queued to be sent before the Command Complete for the HCI_LE_Set_Scan_Enable comes. So something is really strange here.

My theory is that the processing of le_adv_report handler is done before the
thread that called bt_conn_create_le was woken up to process the command_complete event
for the issued LE Set Scan Enable.
This means that we have an inconsistent state in the host where we don't know that
we are currently scanning, but is receiving advertising reports nonetheless.
This happens because we haven't set the BT_DEV_SCANNING bt_dev.flags yet, as
this is done by the thread that called bt_conn_create_le after having processed the Command Complete Event.
The host then runs event handlers for the advertising reports. Since the host
thinks scanning is not enabled it doesn't disable it, and instead issues the
LE Create Connection command directly, which leads to command disallowed.
It might appear from the log that the LE Set Scan Enable to disable the scanner
appears after the LE Create Connection command, but this is because the
error handling of check_pending_conn will disable the scanner.
Relevant code:
Scanning state not set, so we skip disabling the scanner.
bt_conn_create_le -> set_le_scan_enable:
	err = bt_hci_cmd_send_sync(BT_HCI_OP_LE_SET_SCAN_ENABLE, buf, NULL);
	if (err) {
		return err;
	}

	atomic_set_bit_to(bt_dev.flags, BT_DEV_SCANNING,
			  enable == BT_HCI_LE_SCAN_ENABLE);

Starting initiator failed, so we disable scanner
le_adv_report (Event handler) -> check_pending_conn:

	if (atomic_test_bit(bt_dev.flags, BT_DEV_SCANNING) &&
	    set_le_scan_enable(BT_HCI_LE_SCAN_DISABLE)) {
		goto failed;
	}

	bt_addr_le_copy(&conn->le.resp_addr, addr);
	if (hci_le_create_conn(conn)) {
		goto failed;
	}
...
failed:
	conn->err = BT_HCI_ERR_UNSPECIFIED;
	bt_conn_set_state(conn, BT_CONN_DISCONNECTED);
	bt_conn_unref(conn);
	bt_le_scan_update(false);

Given my theory then this comment makes sense:

Debugging this issue I found that the order of bt_hci_cmd_send_sync... and atomic_set_bit_to...in set_le_scan_enable seems to be relevant. If I switch order, the problem seems to go away (pending more testing).

@jhedberg I am on the master branch commit c68ae690b60dd7df4b34d4ec852c9b52567c8aa1 right now, with no changes. I have seen this happening on pre-2.1 rc1 as well.
@joerchan I am not knowledgeable enough about this code to positively state if your theory is correct or not, but it seems valid. Is my observation about switching the order only a symptom fix?

@ChristofferSchroeder It fixes the case you are seeing but it seems to open up a new corner cases, so I will try to make a proper fix. Can I count on you to verify the fix?

@joerchan I will be happy to verify it.

@joerchan thanks for the analysis! It sounds about right to me. One thing regarding hci_cmd_done() that we should be careful with is to not introduce too much extra processing there. This function gets called through bt_recv_prio(), and with some drivers (like h4.c) it's actually in interrupt context. Setting the critical state flags in this context to avoid races does sound like the right thing, but it should probably be limited to just setting the flag and then letting any other logic stay where it is now. We probably want this for other states as well, like advertising, even though we can only see the race with scanning currently.

@ChristofferSchroeder @wdhpawa Can any of you give the proposed fix a try, see if it solves the issue?

Thanks @joerchan. @ChristofferSchroeder will give the fix a try.

@joerchan Sorry for the long wait. Most of my tests failed on Friday which luckily turned out to be other reasons than your change. I have been running tests for some hours today and they are passing with no incidents. So it looks like your change fixes the issue :)


Investigate SecurityHub policy that results in AccessDenied for config:GetComplianceDetailsByConfigRule

AWS SecurityHub is enabled via the modernisation-platform-terraform-baselines Terraform module. It uses the AWSServiceRoleForSecurityHub service-linked role. It integrates with AWS Config to configure a standard set of rules.
When SecurityHub assumes the service-linked role, and tries to perform config:GetComplianceDetailsByConfigRule on its own standard set of rules, the resource throws an AccessDenied error. This only happens on the SecurityHub-created rules, not any that are configured manually.
The error it throws is:
User: arn:aws:sts::${accountId}:assumed-role/AWSServiceRoleForSecurityHub/securityhub is not authorized to perform: config:GetComplianceDetailsByConfigRule on resource: securityhub-${rule-name}.
This full error stack is viewable in CloudWatch Logs if you search for AccessDenied.

I have a similar issue, started in last week or so....out of nowhere. Is there a fix on this?

I ran into the same error/symptom; the solution was to enable Config in the affected region.  The region was specified in the CloudWatch Log error.
Config - like GuardDuty and SecurityHub - is Region based.
Note - I came to this error via CloudFormation not the Terraform module.  In multiple accounts I turned on GuardDuty/SecurityHub but didn't turn on Config and got this error.  Errors disappeared after turning on Config.
I found this issue when looking for a solution and assume others will as well.


Flaky PolygonZKEvm E2E test

Since we integrated PolygonZKEvm in our local e2e tests we saw inconsistent behavior in the local environment due to a bug in their zkevm-node service.
The initial assumption is that the problem comes from the improper assignment of nonces to txs when they are being submitted/executed via their node.
The state synchronization between L1 <-> L2 stops working once the nonces get mixed up and the following errors are being logged in the zkevm-node service:
2023-05-30T11:09:14.197Z    ERROR    ethtxmanager/ethtxmanager.go:392    failed to send tx 0x01ecc3739866c23073c4b8f8143d6d85abf174e4e4dc883f0a48b2365b743f85 to network: replacement transaction underpriced    {"pid": 1, "version": "v0.0.7", "monitoredTx": "sequence-from-3-to-3"}
github.com/0xPolygonHermez/zkevm-node/ethtxmanager.(*Client).monitorTxs
    /src/ethtxmanager/ethtxmanager.go:392
github.com/0xPolygonHermez/zkevm-node/ethtxmanager.(*Client).Start
    /src/ethtxmanager/ethtxmanager.go:214

2023-05-30T11:09:15.202Z    ERROR    ethtxmanager/ethtxmanager.go:392    failed to send tx 0x01ecc3739866c23073c4b8f8143d6d85abf174e4e4dc883f0a48b2365b743f85 to network: nonce too low    {"pid": 1, "version": "v0.0.7", "monitoredTx": "sequence-from-3-to-3"}
github.com/0xPolygonHermez/zkevm-node/ethtxmanager.(*Client).monitorTxs
    /src/ethtxmanager/ethtxmanager.go:392
github.com/0xPolygonHermez/zkevm-node/ethtxmanager.(*Client).Start
    /src/ethtxmanager/ethtxmanager.go:214

2023-05-30T11:09:16.209Z    ERROR    ethtxmanager/ethtxmanager.go:392    failed to send tx 0x01ecc3739866c23073c4b8f8143d6d85abf174e4e4dc883f0a48b2365b743f85 to network: nonce too low    {"pid": 1, "version": "v0.0.7", "monitoredTx": "sequence-from-3-to-3"}
github.com/0xPolygonHermez/zkevm-node/ethtxmanager.(*Client).monitorTxs
    /src/ethtxmanager/ethtxmanager.go:392
github.com/0xPolygonHermez/zkevm-node/ethtxmanager.(*Client).Start
    /src/ethtxmanager/ethtxmanager.go:214

After communicating this bug with the Polygon team, i got the following response (not sure if this helps but worth trying it out):

Hi Gabriel, In case you have pending transactions please try sending another transaction with a custom nonce equal to the last successful transaction's nonce + 1. (If the last successful transaction from the sender's side had a nonce of 42, the new nonce has to be set to 43). Use this script here and let us know if the transaction succeeds: https://github.com/nonceblox/polygon-edge-tutorials/blob/master/clear_pending_txns.md

Hey team! Please add your planning poker estimate with Zenhub @bilbeyt @compojoom @fredo @istankovic @manuelwedler

We need to create an issue in https://github.com/0xPolygonHermez/zkevm-node


[Bug] Volumes are gray when SharedArrayBuffer is enabled and the volume is loaded through wadouri

Describe the Bug
As discovered in #832, all volumes are displayed as gray when SharedArrayBuffer is enabled and the volume was loaded through wadouri.
I did find out in #832 that the volume is gray because handleArrayBufferLoad returns before loading any data, but as I understood from @sedghi's response the code is not supposed to end up there and therefore the fix is wrong. Therefore, I am filing this as a separate issue.
Steps to Reproduce
A reproduction scenario is available at: https://sjorsgielen.nl/cornerstone3d/wadouri-sharedarraybuffer.zip
Unpack this .zip file, run yarn install and yarn dev, then browse to the indicated port.
The volume will be displayed as gray (at least for me).
If SharedArrayBuffer is disabled by setting shouldUseSharedArrayBuffer to false near the top of src/main.ts, then the volume renders normally. Similarly, if useVolume is false, a stack viewport is used instead of a volume viewport, which also renders correctly.
The current behavior
The volume is displayed as gray.
The expected behavior
The volume is displayed normally.
OS
macOS 14.0
Node version
20.8.1
Browser
Safari 17.0

This seems to be another scaling issue, for some reason there are multiple scales happen for different parts of the image
which results in this patterns

even with one web worker

if you window level you can see the data is there but at different values (intensities i.e., scales)

The simplest way to reproduce this is to use OHIF link to Cornerstone3D and use dicomjson below
http://localhost:3000/viewer/dicomjson?url=https://ohif-dicom-json-example.s3.amazonaws.com/LIDC-IDRI-0001.json&hangingprotocolid=mpr

SharedArrayBuffer was removed from Cornerstone3D 2.0, so this isn't an issue, anymore.


Sync patterns across windows

Hi there! Just started using this extension and loving it so far.
It would be amazing if there was an option in the config for each pattern to keep that group to its own window. For example, enabling it for 'mail' would move and keep the mail group to its own window.
Would a simple checkbox in the UI work, or could this feature be generalised a bit? Could be you want to group tab groups by some identifier which would keep them to the same window?
The use case for this is so that I could keep github tabs to one window, mail to another etc.
Thoughts? Is this even possible with the chrome API?

Hey @gkinsman, I definitely understand and like the idea here. I believe I had actually originally built it in a way that only had one group across your chrome windows, but then found the experience got pretty weird if you opened a new tab in a different window and it either disappeared to the other one or switched the focus over. Making it group per windows helped that, buuuuut I also do understand where it would be nice to do this.
In terms of how we could introduce it, I would love to keep each rule as simple as possible for as long as possible so I would prefer some sort of high level setting. A simple approach might be to have a global setting to either do per window groups or groups across all. The identifier (I'm assuming you mean some pattern in the group name) would be a solid approach as well, if customizable by the user, to give more flexibility at the cost of simplicity.
So in summary, I definitely think this is possible given the Chrome API. My personal preference would be to make it a global setting (I'm working on adding a settings page for things like this to live soon) and maybe with some way for the user to have a per rule way of driving the behavior.

Ah that's an interesting UX issue, I hadn't thought of that. Perhaps a way around it might be, if possible, to replace the moved tab with a tombstone saying 'You moved this tab' and a big button saying 'cool' that dismisses the tab. There might be better ways too.
I think moving to a system where you declare your window setup like this would be a dramatic change to workflow, as you're forcing people to start using the tabs they already have open. I think this is a good thing, but maybe there might be a way to support both workflows. What if you could open a new window and somehow say its an ad-hoc session that wouldn't group your tabs? Then maybe pressing the plugin button would send them to their respective groups in whatever window.
I'm just spitballing a bit here, but maybe the issue is less about the setting and more how to get the UX right to make it easy to use. Maybe introducing this global setting might be enough for now, and then once people are using it the UX could be refined?

I'm fine being able to have the same group in different window. But I'd like to have a way to "merge group A from all windows to the group in this window".


ESC L impl questions

Are you familiar with ESC L command? https://reference.epson-biz.com/modules/ref_escpos/index.php?content_id=193
The documentation says that this command switches from Standard mode to page mode, but I don't see this switch in the library.   I think we should have, in order to see the effects of commands that work only in page mode, such as GS $ or ESC W.  Do you have any insight about it?

I have seen the command but I never did anything around page mode. If you want to implement this I think you would have to add some additional fields to the context and possibly modify some of the render commands if it can't be done with the current set.

@zachzurn Yes, I thought something similar. But I wasn't sure about this. I had in mind that I would just need to add some fields in the context, but I didn't realize that I had to change the render too.
The things that I know so far:

The command facilitates the transition from Standard mode to Page mode, indicating a fundamental shift in the printer's behavior and capabilities.
Understanding this is good for defining custom print areas and layouts.
Used alongside with ESC W to set a print area.
ESC T is used in page mode to define a start position and a print direction.
FF command print and return to standard mode in page mode

I had in mind that the ESC L would be a big filter where only a couple of commands would work, and those commands would dictate the way that the render would treat the paper. Do you think that this command should modify something in the render?

Here is an interesting reference for page mode. Would love to somehow get those sample commands as a binary to use as a test file:
https://reference.epson-biz.com/modules/ref_escpos/index.php?content_id=271

It would be interesting to be able to parse this simple format into proper bytes for writing readable test files:
Lines starting with a '//  are comments. tokens are separated by whitespace. if token is surrounded by quotes, it's a string that gets converted to bytes, otherwise it is a constant (ESC) or a numeric value (203).
'// ============================================================================
'//  Print in Page mode
'// ============================================================================

'// Initialize printer
    ESC "@"

'// Select Page mode
    ESC "L"
'// Set horizontal and vertical motion units: Horizontal motion unit = 0.125 mm
'// (1/203 inch), vertical motion unit = 0.125 mm (1/203 inch)
'// The above are values based on the dot density of the TM-T20 printing head,
'// and this script must be changed for each model.
    GS "P" 203 203


improve svg format detection

The SVG decoder fails to detect sources that start with <svg although this is a valid format.
Here you have an example: https://www.codeinwp.com/wp-content/uploads/2018/05/codeinwp-logo.svg
I've tried to register this into the current decoder.
What do you think?

LGTM. But let's DRY it a little. Something like this:
decode := func(io.Reader) (image.Image, error) { ... }
decodeConfig := func(io.Reader) (image.Config, error) { ... }

image.RegisterFormat("svg", "<?xml", decode, decodeConfig)
image.RegisterFormat("svg", "<svg", decode, decodeConfig)

Thanks for the feedback, @DarthSim. I've applied your suggestion.

Thanks for your contribution! Released in v2.2.5

I'd be very appreciated if you could spend some time filling our survey form


Changelog out of date

The changelog is out of date and i'm curious what the changes have been in the last two minor/patch versions?

We are going to remove the changelog that is, frankly, gonna get ginormous very quickly. And add release notes to each release.
You can view the most recent relese note here: https://github.com/almasaeed2010/AdminLTE/releases/tag/v2.3.3

Much more awesome, cheers!


Login not working with javascript disabled, form missing a submit button

[x] I read and understood how to enable logging

Issue / Steps to reproduce the problem
<form method='post' action='https://some-uri.com'>
<input type='hidden' name='id_token' value='eyJh...' />
<input type='hidden' name='scope' value='openid profile' />
<input type='hidden' name='state' value='ae0796bb7562423d9a6b58da40a5fd' />
<input type='hidden' name='session_state' value='XRGLXOY8I-VlEK8_NL9J0MhBdpTseWWfB2DvLmldeBo.644807dfe875645faa7c5e5bd1d5c8' />
</form><script>(function(){document.forms[0].submit();})();</script>
Put a submit button in there and hide it using JS so that clients with disabled javascript can login.
https://github.com/IdentityServer/IdentityServer4/blob/dev/src/IdentityServer4/Endpoints/Results/AuthorizeResult.cs
IdentityServer4.Endpoints.Results.AuthorizeResult.FormPostHtml

Added as a feature request.
Another options for is to use authorization code flow instead. This does not use the form post.

Thank you! I tried that and it's looking good.
For refererence and review:
Starting from Quickstarts\Combined_AspNetIdentity_and_EntityFrameworkStorage I allow GrantType authorization_code for the MVC Client in database/config.
In MVC app startup OpenIdConnectOptions change to:
options.ResponseType = "code";
options.ResponseMode = "query";

For the original request <input type="submit" /> would do. It would then pick up a default text from the browser such as "Submit Query" or equivalent user's browser language. But maybe it's desirable to have some translations for stuff like that to be able to show a more valid text and title for those HTML docs?

tracked here #1880


[devicelab] adb missing on linux machines

adb is missing on devicelab linux machines. needs a salt config to install.

salt config has been submitted


error building py package in format of tar.gz

OS: OS X Yosemite 10.10.4
After installation of dependencies, I build it as following cmds:
delete bdist_wheel in tensorflow/tensorflow/tools/pip_package/build_pip_package.sh
${PYTHON_BIN_PATH:-python} setup.py bdist_wheel >/dev/null to ${PYTHON_BIN_PATH:-python} setup.py

bazel build -c opt //tensorflow/tools/pip_package:build_pip_package

sh +x tensorflow/tensorflow/tools/pip_package/build_pip_package.sh /tmp

then I got the package named tensorflow-0.8.0.tar.gz, after that I installed it using pip, succeed.
However, when I imported it, I got the error:
>>> import tensorflow as tf
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named tensorflow

Could anybody help me? Any help will be highly appreciated.
Could staff in Google build it or give some valuable instructions?

I think this might be related to the problems affecting "setting up for development" #2497 i.e. in
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md
section "Setting up TensorFlow for Development."
Specifically, The instructions have to be different on what you symlink into the python build directory dependent on the version of bazel (which ones to do when are outlined in #2497).  Are you able to get those instructions to work and sucessfully import tensorflow from python?

Yes, I have made it worked. I'll update the doc later.
I have another question:  where can I find the code before generating by SWIG of  bazel-bin/tensorflow/python/pywrap_tensorflow.py. I want to make it more general when packaging it as tar.gz.
Thanks a lot. Awaiting for your reply.

For the generated file location see bazel-out...
For example pywrap_tensorflow.cc on ci.tensorflow.org.

Closing since it seems to be of no further problem. Reopen if further bugs are discovered.


Number of Divisors in Number Theory

Problem Statement
Given an integer, find the number of divisors for it.
(Eg.) Given N = 10, output would be 4 since 10 has four divisors 1, 2, 5, 10.

I would be happy to contribute this problem to the repo. @akshitagupta15june
Thank you!

Hey @akshitagupta15june , can you please assign this to me, I would like to contribute in this.

I would like to contribute

I would like to contribute

Hi, Can you assign me? I want to work on it.


ol.proj.transform

When I use the function ol.proj.transform and the second coordinate is a string the function return NaN in the second coordinate. The first coordinate works fine with number or text.
Here are four test that I made
ol.proj.transform([-50, -50], 'EPSG:4326', 'EPSG:3857')
[-5565974.539663679, -6446275.841017161]
ol.proj.transform(["-50", -50], 'EPSG:4326', 'EPSG:3857')
[-5565974.539663679, -6446275.841017161]
ol.proj.transform(["-50", "-50"], 'EPSG:4326', 'EPSG:3857')
[-5565974.539663679, NaN]
ol.proj.transform([-50, "-50"], 'EPSG:4326', 'EPSG:3857')
[-5565974.539663679, NaN]
The test were made with the Version: v3.0.0-gamma.3-34-g819fd83

Did anyone ever determine why this happens? I am getting the same thing and can't figure it out....my 2nd coordinate is always NaN!

Using v3.2 this still seems to be an issue.

Just make sure you pass numbers as coordinates, not strings. If you still get NaN, then your coordinates are probably outside the validity extent of EPSG:3857, i.e. beyond +/- 85 degrees.

Yep! That was it. I can't believe how long it took me to get that. Didn't make sense to me since I was working with numbers the entire time, but somewhere along the way it was converted to a string. So anyone else that has this issue, wrap your lon and lat values in Number().


[MySQL StatefulSet] Use subPath to keep data dir out of volume root.

The data dir should not be at the root of the volume, because many
volume types create files or directories there automatically.
The database initialization script requires the data dir to be empty,
and we shouldn't try to guess which files may exist.
In particular, by retaining lost+found, it also becomes possible
to recover files that end up there.
Inspired by https://github.com/kubernetes/charts/pull/416.
https://kubernetes.io/docs/user-guide/volumes/#using-subpath

This change is

@janetkuo @kow3ns @foxish Can one of you review this? I'd like to update the tutorial since currently it's recommending a pattern that causes problems for certain PV types (e.g. https://github.com/kubernetes/charts/issues/415).

/lgtm


Uncaught TypeError: Cannot redefine property: name

View details in Rollbar: https://rollbar.com/OpenApparelRegistry/OpenApparelRegistry/items/303/

TypeError: name
  File "(native)", line unknown, in Function.defineProperties
  File<EMAIL_ADDRESS>line 11873, in [anonymous]
        }, Object.defineProperties(e, n), e;
  File<EMAIL_ADDRESS>line 11860, in [anonymous]
      var xc = function (t) {
  File<EMAIL_ADDRESS>line 2, in Object.<anonymous>
      "object" == typeof exports && "undefined" != typeof module ? e(exports) : "function" == typeof ...
  File "https://openapparel.org/facilities/BD2019172XZWQCQ", line 1, in f
  File "https://openapparel.org/static/js/main.c474202f.chunk.js", line 1, in Object.push.1267
  File "https://openapparel.org/facilities/BD2019172XZWQCQ", line 1, in f
  File "https://openapparel.org/static/js/main.c474202f.chunk.js", line 1, in Object.push.583
  File "https://openapparel.org/facilities/BD2019172XZWQCQ", line 1, in f
  File "https://openapparel.org/facilities/BD2019172XZWQCQ", line 1, in a

The same error message was logged at #420 but with a different stack trace

Linked to a group of issues. The exception is raised inside turf.js but originates in difference places
https://rollbar.com/OpenApparelRegistry/OpenApparelRegistry/items/362/


as of hapi-fhir v5.7.0, hapi-fhir-cli no longer supports MySQL 5.7

Describe the bug
Version 5.7.0 of the hapi-fhir-cli tool fails to execute the "migrate-database" command when used with a MySQL 5.7 database.  The command exits with an error message saying, "org.flywaydb.core.api.FlywayException: Unsupported Database: MySQL 5.7".
This change is not mentioned in the HAPI FHIR 5.7.0 release notes.
Newer versions of the Flyway "community edition" apparently do not support MySQL 5.7.  A comment on Flyway issue 3319 indicates, "You can request a trial license for Teams or downgrade to Flyway version 7.15 for the time being."
Example error message:
$ ./hapi-fhir-cli migrate-database -d MYSQL_5_7 -n myuser -p secret -u 'jdbc:mysql://localhost:3306/fhir_r3'
------------------------------------------------------------
🔥  HAPI FHIR 5.7.0 - Command Line Tool
------------------------------------------------------------
Process ID                      : 19704@A0505825
Max configured JVM memory (Xmx) : 4.0GB
Detected Java version           : 13.0.2
------------------------------------------------------------
2022-03-03 09:53:27.957 [main] INFO  ca.uhn.fhir.cli.App Logging configuration set from file logback-cli-on.xml
2022-03-03 09:53:28.845 [main] ERROR ca.uhn.fhir.cli.App Error during execution:
org.flywaydb.core.api.FlywayException: Unsupported Database: MySQL 5.7
	at org.flywaydb.core.internal.database.DatabaseTypeRegister.getDatabaseTypeForConnection(DatabaseTypeRegister.java:106)
	at org.flywaydb.core.internal.jdbc.JdbcConnectionFactory.<init>(JdbcConnectionFactory.java:75)
	at org.flywaydb.core.FlywayExecutor.execute(FlywayExecutor.java:143)
	at org.flywaydb.core.Flyway.repair(Flyway.java:335)
	at ca.uhn.fhir.jpa.migrate.FlywayMigrator.migrate(FlywayMigrator.java:63)
	at ca.uhn.fhir.cli.BaseFlywayMigrateDatabaseCommand.run(BaseFlywayMigrateDatabaseCommand.java:142)
	at ca.uhn.fhir.cli.HapiFlywayMigrateDatabaseCommand.run(HapiFlywayMigrateDatabaseCommand.java:56)
	at ca.uhn.fhir.cli.BaseApp.run(BaseApp.java:254)
	at ca.uhn.fhir.cli.App.main(App.java:43)
2022-03-03 09:53:28.846 [Thread-0] INFO  ca.uhn.fhir.cli.App HAPI FHIR is shutting down...

To Reproduce
Steps to reproduce the behavior:

Download hapi-fhir-5.7.0-cli.tar.bz2 from the hapi-fhir GitHub releases page.
Start a MySQL 5.7 database server (ideally, loaded with hapi-fhir data).
Attempt to execute the "hapi-fhir-cli migrate-database" command, e.g. "./hapi-fhir-cli migrate-database -d MYSQL_5_7 -n myuser -p secret -u 'jdbc:mysql://localhost:3306/fhir_r3'"
See error message saying, "org.flywaydb.core.api.FlywayException: Unsupported Database: MySQL 5.7".

Expected behavior
The "hapi-fhir-cli migrate-database" command should successfully update the MySQL 5.7 database schema.
Screenshots
N/A
Environment (please complete the following information):

HAPI FHIR Version 5.7.0
OS: MacOS 10.15.7
Browser N/A

Additional context
Add any other context about the problem here.

Try using the --dont-use-flyway option when upgrading your databae.
From the command-line help:
     --dont-use-flyway           If this option is set, the migrator will not
                                 use FlywayDB for migration. This setting should
                                 only be used if you are trying to migrate a
                                 legacy database platform that is not supported
                                 by FlywayDB.

Thanks!  The --dont-use-flyway options looks like it worked.
The MySQL 5.7 database had already been migrated to hapi-fhir v5.6.0, so watching the migrate-database process cycle through all migrations since 3_3_0.20180115.0 was slightly unnerving, but most of them said "No action performed", "No action needed", or "NopTask".

Closing this since the work-around resolved the problem.


tox bug fails testing on python 3.5.2: ERROR: unknown environment 'py35'

Attempted to run tox on the current master of ramlfications (https://github.com/spotify/ramlfications/commit/59ac38977cd45b6bdacde51a5fe12d602ddf1e1f) on a completely vanilla macos machine and it fails with the somewhat cryptic ERROR: unknown environment 'py35'
Steps to reproduce:

start with a completely vanilla macos 10.11.5
install xcode command line tools with xcode-select --install
install brew with the oneliner available from [http://brew.sh/]
install the brew python and  python3 with brew install python python3
install and set up virtualenvwrapper: pip install virtualenvwrapper && . /usr/local/bin/virtualenvwrapper.sh
create a virtualenv for python3: mkvirtualenv --python=/usr/local/bin/python3 py3
clone ramlfications: git clone https://github.com/spotify/ramlfications.git
install deps: pip install -r dev-requirements.txt
run tox: tox

Expected outcome:
some testing
Actual outcome:
tox exits immediately with the somewhat cryptic message ERROR: unknown environment 'py35' even though python --version outputs `Python 3.5.2``
This problem seems to be fixed between tox versions 1.8.1 and 1.9.0, the following change resolves the problem with a minimal delta
index 2c23456..aa6c087 100644
--- a/dev-requirements.txt
+++ b/dev-requirements.txt
@@ -4,7 +4,7 @@ check-manifest==0.21
 coverage==3.7.1
 flake8==2.2.3
 sphinx-rtd-theme==0.1.6
-tox==1.7.2
+tox==1.9.0
 pytest==2.6.4
 pytest-cov==1.8.1
 mock==1.0.1

One could discuss which version to upgrade to. I have no knowledge of the inner workings of the tox project, so being conservative with upgrading seems prudent. Another strategy would be to upgrade to the latest released version 2.3.1 or, assuming that semantic versioning is applied correctly the latest minor release, which would be 1.9.2

Addressed with #110. Let me know if there are future issues. Thanks!


(Suggets) Load the old value in the input field if validation error occurs bread user

Version information

Laravel: v5.7.28
Voyager: v1.2.6
PHP: 7.1
Database: MySQL 5.7.24

Description of problem

When add rule validation in Bread User's if a validation error occurs does not load the old value in the input field.
Proposed solution

Copy file edit-add.blade.php from vendor\tcg\voyager\resources\views\users
to resources\views\vendor\voyager\users

Edit file resources\views\vendor\voyager\users\edit-add.blade.php

Add code

I think this was supposed to be closed with #4348
Thank you for reporting and PR.
Please next time when you submit a PR that should close an issue write in your description:
Fixes #4338
or
Closes #4338
So that the issue will be automatically closed once PR is merged.


Improve UploadStakingLedger to validate json file and parameterize query

Although it's behind a password-protected (basic auth) endpoint, it's still a good idea to validate that the file being uploaded is legitimate / properly formatted.
Also parameterize the query vs. parsing straight in.

Changed to:

write to file vs. process in memory
parse json into defined interface so only known data can be used


Error with interface but not with type for indexed property

TypeScript Version:  2.6.0
Code
interface I<K extends string, P> {
    [key in K]?: P; // Error: 1. A computed property name must directly refer to a built-in symbol.
                    //        2. A computed property name must be of type 'string', 'number', 'symbol' or 'any'.
}

type T<K extends string, P> = {
    [key in K]?: P; // No Errors !?
};

Expected behavior:
Same error for both definitions, I and T.
Actual behavior:
Error only with the interface.

This is a duplicate of https://github.com/Microsoft/TypeScript/issues/18299

For other n00bs like me: Note that there is a difference between "indexed" and "mapped" types.
See http://www.typescriptlang.org/docs/handbook/advanced-types.html#mapped-types


Finish the uniform_matrix class including tests and docs

Need to add size, begin and end references to the doc

Should also include notes about time and space complexity in the doc file

Need to add front() and back() functions to both _uniform_matrix_row and uniform_matrix classes

Most current doc examples do not include examples of template arguments.

Doc file is now outdated after all the new functions and additional overloads

Stop naming things with underscores, instead use t_

Closed by #63. At some point looking to make the tests but might do that last


Where are the current Swift 5 releases

Query/Question
The Readme says this is a new Swift 5 SDK and I should download the releases.  But the  releases link go to release from 2019: https://github.com/Azure/azure-sdk-for-ios/releases.  There is no AzureStorageBlob referenced here: https://azure.github.io/azure-sdk-for-ios/AzureStorageBlob/index.html
Why is this not a Bug or a feature Request?
Just looking for the correct download.
Setup (please complete the following information if applicable):

OS: iOS
IDE :Xcode
Version of the Library used

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x ] Query Added
[ x] Setup information Added

Hi there @daverBellus3D, thanks for your interest in our libraries! We're preparing for the first preview release of our Core library - the work is tracked in #136 if you'd like to follow along, and it's currently on track for our September milestone.
The Storage library will be coming along shortly thereafter. Our documentation will be updated as part of this - the instructions to download the source code via the Releases page is out of date. We will be making these libraries available via Swift Package Manager so that you can easily add them to your application directly within Xcode (File > Swift Packages > Add Package Dependency). Even though we have not published a release yet, you're welcome to kick the tires on our Storage library now by adding a Package Dependency and pointing to this repo's master branch.

Ok thanks for the update.  I will give it a try.
Dave
On Tue, Aug 18, 2020 at 4:56 PM bsiegel<EMAIL_ADDRESS>wrote:

Hi there @daverBellus3D https://github.com/daverBellus3D, thanks for
your interest in our libraries! We're preparing for the first preview
release of our Core library - the work is tracked in #136
https://github.com/Azure/azure-sdk-for-ios/issues/136 if you'd like to
follow along, and it's currently on track for our September milestone.
The Storage library will be coming along shortly thereafter. Our
documentation will be updated as part of this - the instructions to
download the source code via the Releases page is out of date. We will be
making these libraries available via Swift Package Manager so that you can
easily add them to your application directly within Xcode (File > Swift
Packages > Add Package Dependency). Even though we have not published a
release yet, you're welcome to kick the tires on our Storage library now by
adding a Package Dependency and pointing to this repo's master branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-sdk-for-ios/issues/386#issuecomment-675775363,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKS23GHMAZPDECA6VFHRVJLSBMIKLANCNFSM4QC2NMHA
.

--
Dave Rothschild
iOS Engineering Manager
Bellus3D, Inc.
408-859-5170


model metrics visualization key error

In the given documentation, the mentioned key are acc and val_acc, but actually it is accuracy and val_accuracy.
Given documentation screenshot:

Whereas the actual keys are dict_keys(['val_loss', 'val_accuracy', 'loss', 'accuracy'])
Changes to be made in this file.

Does it not depend on the metrics set when compiling a model? For example, if you compile a model like this:
model.compile(
  loss="binary_crossentropy",
  optimizer="adam",
  metrics=["acc"]

Then the history object will have keys ["loss", "val_loss", "acc", "val_acc"]
But if you compiled like:
model.compile(
  loss="binary_crossentropy",
  optimizer="adam",
  metrics=["accuracy"]

Then the history object will have keys ["loss", "val_loss", "accuracy", "val_accuracy"]

@am1tyadav well then in that case it should'nt be dependent on the key that we pass in metrics while compiling the model.
I think the keys that we get from history object should be consistent everytime.


Better error messages for Parser and Scanner

Scanning and Parsing the command line arguments should return descriptive, helpful errors for a user. The current errors are vague and sometimes not explicit enough.

This needs also be applied to the script parser.

Following changes to errors are made:

Show file in which the error happens
Combine multiple errors in formatting
Use ASCII chars for better visuals

This is then how it now looks like (without colouring):
Error: Parameter format is wrong!
  → /Users/martin/Projects/krieselreihe/litr/litr.toml
12 | [params.targete]
   | └─ You're missing the "description" field.
 ...
13 | shortcut = 12
   |          └─ A "shortcut" can can only be a string.


Issue with Setting Guest Access Code and Detecting Keypad for Wyze Lock

I am experiencing issues with setting a guest access code for a Wyze Lock using the Wyze SDK. Specifically, the SDK fails to detect the keypad associated with the lock, even though the keypad is enabled and visible in the Wyze app.
Context
Device Nickname: HOME_NAME
Keypad Status: Enabled (visible in the Wyze app)
Firmware Version: <IP_ADDRESS>
Steps to Reproduce:
Use the Wyze SDK to list devices.
Attempt to set a guest access code for the lock.
Code Snippet:
import os
import time
import argparse
import logging
import requests
from dotenv import load_dotenv
from wyze_sdk import Client
from wyze_sdk.errors import WyzeApiError
from wyze_sdk.models.devices.locks import LockKeyPermission, LockKeyPermissionType

# Setup logging
logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(levelname)s - %(message)s')

# Load environment variables from .env file
load_dotenv()

WYZE_ACCESS_TOKEN = os.getenv('WYZE_ACCESS_TOKEN')
WYZE_REFRESH_TOKEN = os.getenv('WYZE_REFRESH_TOKEN')
LOCK_MAC_ADDRESS = os.getenv('LOCK_MAC_ADDRESS')  # Load MAC address from .env
ACCESS_CODE = "1234"  # Replace with desired access code
ACCESS_CODE_NAME = "Testtt"  # Replace with desired access code name
START_TIME = int(time.time()) * 1000  # Current time in milliseconds
END_TIME = START_TIME + 24 * 60 * 60 * 1000  # 24 hours from now in milliseconds

# Function to refresh the access token
def refresh_access_token(refresh_token):
    url = "https://api.wyzecam.com/app/user/refresh_token"
    payload = {
        "app_ver": "wyze_developer_api",
        "app_version": "wyze_developer_api",
        "phone_id": "wyze_developer_api",
        "refresh_token": refresh_token,
        "sc": "wyze_developer_api",
        "sv": "wyze_developer_api",
        "ts": int(time.time() * 1000)
    }
    headers = {
        "Content-Type": "application/json"
    }

    try:
        response = requests.post(url, json=payload, headers=headers)
        response.raise_for_status()
        data = response.json()
        new_access_token = data['data']['access_token']
        new_refresh_token = data['data']['refresh_token']
        logging.info("Access token refreshed successfully")
        return new_access_token, new_refresh_token
    except requests.RequestException as e:
        logging.error(f"Failed to refresh token: {e}")
        raise

# Function to get the client
def get_client():
    global WYZE_ACCESS_TOKEN, WYZE_REFRESH_TOKEN
    try:
        client = Client(token=WYZE_ACCESS_TOKEN)
        # Test if the access token is valid
        client.devices_list()
        logging.info("Access token is valid")
    except WyzeApiError as e:
        if "AccessTokenError" in str(e) or "access token expired" in str(e):
            logging.warning("Access token expired, refreshing...")
            try:
                WYZE_ACCESS_TOKEN, WYZE_REFRESH_TOKEN = refresh_access_token(WYZE_REFRESH_TOKEN)
                os.environ['WYZE_ACCESS_TOKEN'] = WYZE_ACCESS_TOKEN
                os.environ['WYZE_REFRESH_TOKEN'] = WYZE_REFRESH_TOKEN
                client = Client(token=WYZE_ACCESS_TOKEN)
            except Exception as refresh_error:
                logging.error(f"Failed to refresh access token: {refresh_error}")
                raise e  # Re-raise the original error if refreshing fails
        else:
            logging.error(f"WyzeApiError: {e}")
            raise e  # Re-raise the original error if it's not an access token issue
    return client

def set_guest_access_code(client, lock_mac, access_code, code_name, start_time, end_time):
    try:
        # Fetch the lock device
        device = next((d for d in client.devices_list() if d.mac == lock_mac), None)
        if not device:
            logging.error(f"No device found with MAC address {lock_mac}")
            return

        logging.info(f"Setting guest access code for device: {device.nickname}")

        permission = LockKeyPermission(
            type=LockKeyPermissionType.DURATION,
            begin=start_time,
            end=end_time
        )

        response = client.locks.create_access_code(
            device_mac=lock_mac,
            access_code=access_code,
            name=code_name,
            permission=permission
        )

        logging.info(f"API Response: {response}")
    except WyzeApiError as e:
        logging.error(f"Failed to set guest access code: {e}")
    except Exception as e:
        logging.error(f"Unexpected error while setting guest access code: {e}")

def main():
    parser = argparse.ArgumentParser(description="Wyze Lock Guest Access Code Setter")
    args = parser.parse_args()

    try:
        client = get_client()
        set_guest_access_code(client, LOCK_MAC_ADDRESS, ACCESS_CODE, ACCESS_CODE_NAME, START_TIME, END_TIME)
    except Exception as e:
        logging.error(f"Script failed: {e}")

if __name__ == "__main__":
    main()

Observed Behavior:
The SDK fails to detect the keypad associated with the lock, despite the keypad being enabled and visible in the Wyze app.
The error message encountered: 'NoneType' object has no attribute 'is_enabled'
Expected Behavior:
The SDK should detect the keypad associated with the lock.
The guest access code should be set successfully.
Environment:
Wyze SDK version: 2.1.0
Python version: Python 3.12.4
Operating System: MacOS
Using .env with
<EMAIL_ADDRESS># required the first time to obtain the access token
WYZE_PASSWORD=your_password # required the first time to obtain the access token
WYZE_TOTP_KEY=your_totp_key # required to login when account has MFA enabled
WYZE_API_KEY=your_api_key
WYZE_KEY_ID=your_key_id
WYZE_ACCESS_TOKEN=your_access_token # provided by the script
WYZE_REFRESH_TOKEN=your_refresh_token # provided by the script

HOME_1_NAME="Name House"
HOME_1_ICAL_URL=your_home_1_airbnb_ical_url
HOME_1_LOCK_DEVICE_MAC=your_home_1_lock_device_mac
HOME_1_KEYPAD_SERIAL_NUMBER=your_home_1_keypad_device_mac
HOME_1_CHECK_IN_TIME=16:00
HOME_1_CHECK_OUT_TIME=11:00

Fixing the Keypad would be a great update and useful in several use-cases.


feat: add cmake support

This pull request adds basic CMake support.

this does require further tweaking tho, but it builds with msvc :)

Thanks!


Run CounterFit in docker container

Before writing a PR to make CounterFit work in docker--is there any reason NOT to do so? It looks like all of the emulation happens through the socket through the CounterFit library.
I've already patched a container to work as well--I'm now testing with some of the sensors and actuators to make sure it doesn't inhibit functionality.
I also recognize that it's fairly easy to get started with CounterFit and you'd need the same packages installed whether or not it runs in docker. My specific use case is that I setup a number of virtualenvs and want to simplify the process by orchestrating a container (one line and simpler install vs two lines + installation).

Apologies - I missed this.
Go for it! There's no reason not to have docker as an alternative to installing the Python application. As long as we support both, for those folks who don't use docker.

Docker container created!
docker pull jimbobbennett/counterfit:latest

When you run this, you need to map port 5000 to a port on your localhost.
More details and the docker file is here: https://github.com/CounterFit-IoT/counterfit-docker-container


Changed Home Page UI

Fixes Issue #2173
Screenshots

@rupali-codes
You need to authorize the vercel deployment.

@rupali-codes
Vercel deployment.

@JoshiUtsav & @Anmol-Baranwal

@JoshiUtsav & @Anmol-Baranwal

He is facing some errors, and I've asked him to consult to aftab. I was tired at that time due to exams.
Please tag us, if the problem is still not resolved.

@JoshiUtsav & @Anmol-Baranwal

He is facing some errors, and I've asked him to consult to aftab. I was tired at that time due to exams.
Please tag us, if the problem is still not resolved.

I have shared the solution with him.

@rupali-codes  Sure, I'll take care of fixing the multiple exports in the pages/index.tsx file.

@rupali-codes
Deployment :)

@JoshiUtsav
For fixing scrollbar issue

@JoshiUtsav are you still working on this PR?

Yeah, I've been working on this pull request. @aftabrehan

All the code is responsive,  except for the welcome section.

@JoshiUtsav
Please solve the conflicts. Rest, we would see whatever we can do.

@rupali-codes Any update?

@rupali-codes Any update?

@JoshiUtsav, the merge conflicts need to be solved before we review your PR.

@CBID2 Done.

I haven't made any modifications to the CategoryDescription.ts file. @rupali-codes

@rupali-codes, I think this error is resolved now. Can you please help to deploy the changes?

@rupali-codes, I think this error is resolved now. Can you please help to deploy the changes?

Still failing

@rupali-codes
Please review and merge this if there are no changes required.
So, we can start working on #2234

@rupali-codes
Please review and merge this if there are no changes required.
So, we can start working on #2234

Hey Anmol, the theme functionality isn't working well. Please look into it

Hey Anmol, the theme functionality isn't working well. Please look into it

Sure, will do it then.

Hey Anmol, the theme functionality isn't working well. Please look into it

Sure, will do it then.

To @rupali-codes’ point @Anmol-Baranwal, some parts don’t match the design shown in the screenshot section

Hey Anmol, the theme functionality isn't working well. Please look into it

Sure, will do it then.

It’s pretty squished in some sections

Hey Anmol, the theme functionality isn't working well. Please look into it

Sure, will do it then.

It’s pretty squished in some sections

@JoshiUtsav
Make it responsive for mobile screens, for md devices it would be fixed on removing sidebar but at least do it for xs, sm devices.
@CBID2
Thanks for pointing out.

@Anmol-Baranwal Work in progress.

@Anmol-Baranwal Work in progress.

Any updates??

It looks better structure-wise, but the words "Welcome" and "LinksHub" are hard to read. Is there a way we can make this darker @JoshiUtsav and @rupali-codes?

@CBID2 & @rupali-codes Sorry for the delay, dealing with health issues. Need 2-3 more days

Hi Utsav!
Prioritize your health and take some deep rest.
I've pushed responsive code, so don't stress about this PR.
Meanwhile, Rupali will handle the theme bug, so most probably this will be resolved by tomorrow.
I hope you understand. Just thought I should let you know.
See ya :)

Hey @JoshiUtsav, the pr had lots of issues we have tried to fix whatever we could, and still merged the PR, but issues still affecting the dev branch so we're reverting the changes back.


Lookup image-data correctly in paintImageMaskXObjectGroup (issue 14990)

This fixes a regression from PR #14754.
We didn't lookup the image-data correctly, with the result that we tried to render some ImageMasks using a string rather than the intended TypedArray. To make matters worse, this code-path was apparently not properly covered by existing test-cases.

/botio test

/botio makeref


update cordovaPlugins version

i tested these newest Plugins on Android and IOS, all is right!

Thanks very much!


add adjust layout

👷 Deploy Preview for bochen1993 processing.

Name
Link

🔨 Latest commit
a9200370aa53d1a7fe5aaf29b521c6d8bb5771b0

🔍 Latest deploy log
https://app.netlify.com/sites/bochen1993/deploys/650fa92c31d23300088ad203


Add ability to generate Kenyan fake data

Description
Currently, the faker gem does not have an ability to generate Kenyan fake data.
Suggested fields to be added in the Kenyan faker module are;

Company registration number
Phone numbers
National ID numbers
KRA pin numbers

It would also be good to have location data i.e. Counties, Wards e.t.c

The implementation can follow a similar pattern to how the South Africa faker integration is implemented. You can find the Class implementation and the tests here.


Installed new Nodes with embedding node-red not Attached into Editor

hi
I cant show any Nodes in Editor when Installing new nodes
full story in node-red forums
https://discourse.nodered.org/t/i-cant-install-any-nodes-in-embedded-node-red/41791

[ ] Node-RED version:1.2.9
[ ] Node.js version: 12.16.3
[ ] npm version: 6.14.4
[ ] Platform/OS: win 10
[ ] Browser: opera or chrome or any browser same Error

If it's already been discussed in the forum, then there's no need for an issue here until we know there's a bug to be fixed.


Added additional Elixir library

PromEx is a library that I have been working on for some time now, and from the users that have adopted it, it has become a great observability solution using Prom+Grafana. Figured I would add it to the documentation list here :).
Thanks in advance!!

Thanks for your PR. To encourage the community to work on one solution and continuously reinventing the wheel, we only list one client library for a given runtime/language. As far as I can see the existing listing is more popular, predates the one in this PR by 4 years, and has a much bigger community. If you feel there's things the existing listing could do better, I'd recommend discussing it with them.

Thanks for your PR. To encourage the community to work on one solution and continuously reinventing the wheel, we only list one client library for a given runtime/language. As far as I can see the existing listing is more popular, predates the one in this PR by 4 years, and has a much bigger community. If you feel there's things the existing listing could do better, I'd recommend discussing it with them.

Thanks for the quick reply! The two libraries have two very different design philosophies behind them, so I don't think library consolidation is necessarily an option. But totally understandable that you want to keep 1 library per language :).
Thanks again!

Thanks for the quick reply! The two libraries have two very different design philosophies behind them, so I don't think library consolidation is necessarily an option. But totally understandable that you want to keep 1 library per language :).
Thanks again!


Run apt-get clean at the end of the installation

You should run 'apt-get clean' at the end of the apt-get installation process; this will remove any downloaded .tgz files which are no longer needed from /var/cache/apt

This isn't necessary. We used to have this in but ubuntu base image does this automagically: https://github.com/tianon/docker-brew-ubuntu-core/blob/9c78896fe39d5be95cc4a6ae6c0475599a1bc396/xenial/Dockerfile#L21-L24


Don't test refactor if there's no hint

Apply-refact no longer attempts to parse and re-print the input since <IP_ADDRESS> if there's no hint, so we don't need to test refactor if there's no hint. This makes the test suite run 17% faster on my machine.

Thanks!


equivalent of sway's 'include' directive

Hi,
I store my sway config in a git repository and reuse across multiple machines.
I'm using sway's include directive to deal with the small differences between setups
include ~/.config/sway/hostname/*
Not sure how to achieve something similar with waybar. I feel I should create as many different configs as needed, and  then create appropriate symlinks depending on which machine I'm on.
Could one improvement be to allow an argument to specify a filename doing something like this ?
bar {
    swaybar_command waybar ~/path/to/custom_config
}

PS: thanks a lot for this bar, just started using it and it feels like a great addition to my setup !

Hi!
You can already pass config file to waybar using -c arg.
waybar -c ~/path/to/custom_config

waybar --help for more information

thanks!
For some reason, it only works when using exec (and in that case, sway reloading had no effect on waybar)
So the following won't work :
bar {
    swaybar_command waybar -c ~/path/to/custom_config
}

not a big issue anyway

You may need to quote the cmd.
e.g.
bar {
    swaybar_command "waybar -c ~/path/to/custom_config"
}

bar {
swaybar_command "waybar -c ~/path/to/custom_config"
}

Tried it, didn't work

And with an absolute path to config?

It would still be nice to have something like sways "include". I have the same problem and I think putting the non-common parts in extra files is much nicer than having nearly the same file for each machine with only slightly differences.

I opened swaywm/sway#5724 about the ability to pass args to swaybg_command.
However, IMO waybar is really lacking here. Everywhere else that I tend to have machine-specific config, the bulk of the config is generic and is in dotfiles. The small bits of machine/host-specific config is able to be include in ".d" directories, include *.config, etc. The options for waybar feel clunky: custom startup/wrapper scripts to generate json/css, use a templating engine, store whole configs for each host separately (and resolve the above FR).
Sure, we can take the stance that waybar shouldn't need to do anything here, but I think it would really help to provide a nice out-of-the-box experience for users. Especially since I believe the difficulty here is largely caused by the design choice to use raw json and css for configuration.

Hey! Is this a waybar or sway issue?
I cannot pass --config and --style.

/home/user/path won't work
$HOME/path won't work
~/path won't work

Anyone stumbling here: Waybar supports the include directive now:
https://github.com/Alexays/Waybar/wiki/Configuration


how about html in question?

can you add content as v-html or any settings

@hasankemaldemirci ok I'll play around with it, and give u feedback

@hasankemaldemirci I have added v-html instead of {{ }} render
try, and let me know if it worked for u ✌


[Refactoring] refactor the no-assertion rule

Description
Move the no assertion detection to the expression package.
Type of change
Please delete options that are not relevant.

[x] Refactor

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added test case and related test data
[ ] Update the functional test

Checklist:

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I ran golangci-lint

@nunnatsa

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

78 of 81 (96.3%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 78.208%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/expression/actual/actualarg.go
13
16
81.25%

Totals

Change from base Build<PHONE_NUMBER>2:
0.2%

Covered Lines:
1999

Relevant Lines:
2556

💛  - Coveralls


bot crashes when accented chars are used

steps to reproduce:

install bobot following the instructions on http://botbot.readthedocs.org/en/latest/install.html
run and configure it following the instructions of http://botbot.readthedocs.org/en/latest/getting_started.html
wait for your bot to join your test channel
type á on the chat

expected results:

the bot logs your message

actual results:

the bot crashes with this message:

Traceback (most recent call last):
  File "/home/botbot/botbot/bin/honcho", line 9, in <module>
    load_entry_point('honcho==0.5.0', 'console_scripts', 'honcho')()
  File "/home/botbot/botbot/local/lib/python2.7/site-packages/honcho/command.py", line 315, in main
    app.parse()
  File "/home/botbot/botbot/local/lib/python2.7/site-packages/honcho/command.py", line 129, in parse
    options.func(self, options)
  File "/home/botbot/botbot/local/lib/python2.7/site-packages/honcho/command.py", line 197, in start
    sys.exit(process_manager.loop())
  File "/home/botbot/botbot/local/lib/python2.7/site-packages/honcho/process.py", line 118, in loop
    print(line, end='', file=proc.printer)
  File "/home/botbot/botbot/local/lib/python2.7/site-packages/honcho/printer.py", line 22, in write
    self.output.write(*new_args, **kwargs)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 182: ordinal not in range(128)

My system is Ubuntu 14.10 x64 from DigitalOcean

maybe related https://github.com/nickstenning/honcho/issues/66

indeed! adding the following lines to the .env file fixed the issue:
LANG=en_US.UTF-8
PYTHONIOENCODING=utf8


Org mode improvements (extend markdownify to support all markup formats)

document org front matter format
introduce htmlify (#5589)

We need to stop a minute and think a little about the name. I may have thought these "ify" function names was clever (I think we stole it from Jekyll), but I'm not so sure anymore. markdownify was obviously not fantastic.
I suggest we call the new one Markup.
That said, we also need to specify the block (paragraphs) vs inline behaviour of such func. There are miles of discussions about this  elsewhere, so I will not go into details.

I agree that the "ify" names are getting old.

I suggest we call the new one Markup.

How about toHTML in Markdown, Org, .. namespaces?
Can we have something like:
{{ "**BatMan**" | Markdown.toHTML }}

{{ "*BatMan*" | Org.toHTML }}

I feel like above are readable as in plain English too.

The current namespace is transform.Markdownify (I don't want 1 function namespaces) and I suggest we do transform.Markup. The name is pretty good, and another reason is that I plan to add  .Page.Markup method which defaults to the renderer or the page itself. It would be good if they shared the same name (and we're not adding a bunch of new methods to the alrady big Page interface).

I'm sorry I don't have any suggestion here. But for me Markup in the global sense is not HTML only, it's an ensemble of factors determining the look of your page. CSS is part of the "Markup".

@regisphilibert As an aside.. that you mention:

Originally these the little handwritten comments added next to the text to indicate the publisher how those element should be "styled" on once printed.

https://shadycharacters.co.uk/ is an awesome read if you are interested in such topics related to publishing and special characters 😃

I suggest we do transform.Markup
So.. how about a middle ground.. transform.ToHTML

I don't care either way but I'm unsure where to go from here.

Given that no one has a preference, but I do, @bep, does my proposal in https://github.com/gohugoio/hugo/pull/6043#issuecomment-502778769 sound good? 🙂

Given that no one has a preference,
I have a preference, which is the more general term mentioned earlier.

When I say .Markup (which is the page contextual variant of what we discuss here) I say: Render this using the page's rendering engine to the current output format.
I understand that what we currently have renders to HTML only, I would be rather disappointed if the future did not bring ... more.

@kaushalmodi @niklasfasching sorry, I have been slightly distracted lately. I think I will delay parts of this discussion to a later time. For this particular PR I will say that we cannot add another function with a different name but with almost identical functionality (you have no idea how much time just explaining the difference to people will add up to, even if we add fantastic docs).
So, also saying that in the future we need something to indicate block vs inline for this, I suggest that we:

Keep the name markdownify for now. We can create an alias for it once we know what that is.
Add an optional options map so I can do {{ "=hello=" | markdownify (dict "format" "org") }}

The above will map fairly nicely to the .Markdownify func, which then uses the page context to guess the above.

Bump.

Got distracted - I'll look into this on the weekend :)

I will probably replace this PR now ...
I have thought about this, and I think .Page.ToOutputFormat (which will fall back to HTML for now) would be an OK name. It's a little bit mouthy, but I think it describes what it does well.
/cc @regisphilibert

I'm a bit confused here as of the purpose of this .ToOutputFormat method. Its name evokes compatibility with multiple output. I understand it can take either markdown or org as input but I'm not sure I can figure what output, other than HTML, it could ever produce?
If I'm working on a JSON template file and I use .Page.ToOutputFormat, what does happen?

@regisphilibert I changed my mind as I wrote it ... See my update.

Yes .RenderString is great! And now I see we're talking about Rendering a string with shortcode, markdown etc... This will help greatly building pages with Front Matter Blocks! 🎉


Logging plugin infrastructure

Would appreciate a review of the approach.
Still todo:

Make the logging API more useful for different kinds of logging (i.e. Prometheus metrics).
Log useful stuff from around the code...

Status codes from webhooks.
Status codes from feeds.

Coverage decreased (-2.0%) to 96.376% when pulling ccdbcfd5ec50a7592af1a5dfc96f0189c2b7c91b on logging-plugins into 566e7021738a06e23cab5b5bfd3ef308e234b688 on master.


save current pillar block and stakes into db

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


fix: add backslash to path test for windows paths

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #39451

Tested on Windows 10, and WSL: Ubuntu 20.04 -  allows both file paths to be tested.

Actually, I've changed my mind - delaying this to use it for testing was a silly idea.  @Twaha-Rahman @RandellDawson would one of you mind QAing this and we can merge as soon as you're happy?

@ojeytonwilliams I am currently unable to test this on Windows, but it should work as written.  Feel free to merge if @Twaha-Rahman is able to test and validate the change does work on Windows.

I have been using this PR for a few days and it works flawlessly.

@Twaha-Rahman So maybe I should cherry-pick the commits off this PR and apply them to a new branch off my local master to see if the npm run develop issue goes away?

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Spaces

Some reports on the site's style @bendyorke
https://discord.com/channels/725182569297215569/1070587158739566603/1071574959031333008

the use of &nbsp is not consistent. It still exists in 2 of the user recommendations but not the others.

@cnrpman Thanks for taking a shot at this! Using non-breaking spaces might have undesirable side-effects. I believe we can use simple spaces in most of those cases. When we need to add a space in between elements, we can use {" "}.
Closing this in favor of https://github.com/logseq/sites/pull/27


Tensorflow keras save_weights and load_weights produce random evaluation result on some dataset

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Window 10 and Mac OS 10.15.7
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): pip install tensorflow
TensorFlow version (use command below): 2.3.1
Python version: Window 10 (3.7.4), Mac OS (3.8.5)
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: Has CUDA only on Window 10 (CUDA 10.1, cuDNN 7.6.5)
GPU model and memory: MSI GeForce GTX1080 8GB

Describe the current behavior
When save_weights and load_weights on keras model, seem to work fine in the same python session with training.
But after stop that python session and try calling load_weights on a new python session, some dataset produce a random evaluation result.
Describe the expected behavior
Evaluation result after load_weights should be the same across python session
Standalone code to reproduce the issue
This is the full standalone reproducible problem when load_weights each time get you a random evaluation loss and accuracy

Was able to reproduce the issue with TF v2.3 and TF-nightly. Please find the gist of it here. Thanks!

@sainttail This is duplicate of
As I mentioned earlier, this is not an issue with load_weights but the user code. I checked weights, labels, and features. There is no change in weight and labels after loading the model but there is a change in features. Please check the gist here. Thanks!
I am showing the difference in features before saving and after loading the weights. Please note that I restarted runtime as you mentioned.
After training model, loss: 0.9711138010025024, accuracy: 0.5186440944671631
test_features
[[-0.49808972  0.41190585 -0.27875089 ... -0.9401052   0.57645319
  -1.15568602]
 [-0.49808972  0.41190585 -0.27875089 ...  0.04428938  0.57645319
  -0.1313082 ]
 [ 0.70921448 -2.42566817 -0.27875089 ...  0.04428938  0.57645319
  -0.1313082 ]
 ...
 [ 0.70921448  0.41190585 -0.27875089 ...  0.04428938  0.57645319
  -0.1313082 ]
 [ 0.70921448  0.41190585  3.58440841 ...  0.04428938  0.57645319
  -2.18006385]
 [-1.70539393  0.41190585  3.58440841 ... -1.92449978  0.57645319
  -2.18006385]]

Restored model, loss: 1.0805716514587402, accuracy: 0.4203389883041382
test features
[[ 0.41190585  0.57645319 -0.49808972 ... -1.15568602 -0.27875089
  -0.9401052 ]
 [ 0.41190585  0.57645319 -0.49808972 ... -0.1313082  -0.27875089
   0.04428938]
 [-2.42566817  0.57645319  0.70921448 ... -0.1313082  -0.27875089
   0.04428938]
 ...
 [ 0.41190585  0.57645319  0.70921448 ... -0.1313082  -0.27875089
   0.04428938]
 [ 0.41190585  0.57645319  0.70921448 ... -2.18006385  3.58440841
   0.04428938]
 [ 0.41190585  0.57645319 -1.70539393 ... -2.18006385  3.58440841
  -1.92449978]]

As there is a change in features that were input to the model, evaluation metrics are changed.
I am closing this issue as this is not a bug or performance related to TensorFlow. Please feel free to reopen if I am mistaken. Thanks!

@jvishnuvardhan Thanks, for helping me. I've never once thought that the same code produce different feature values.

@jvishnuvardhan Hello, I've some trouble with LSTM layer model saving and loading. After loading the whole model from other python file weights of the LSTM layer is being different from the saving session.
I've asked for it in one of the keras-team/keras issue topics. But could not find any workaround yet. I've just seen the https://github.com/keras-team/keras/issues/14240#issue-718065369 topic then decide to ask under this topic as well.
Here is my issue which I described: https://github.com/keras-team/keras/issues/4875#issuecomment-719030257
You can see the weight differences between different python files right after training and after loading: https://github.com/keras-team/keras/issues/4875#issuecomment-719905493
Just for a recap, my setup is:

Python 3.8.6
Keras 2.4.3
TensorFlow 2.3.1
Windows10 and using PowerShell

@namcho Can you please create a new issue with a simple standalone code to reproduce the issue? It will help the community and helps us to track the issue better. Thanks!


Pipes clashing with Thaumcraft.

I currently have both the latest Thaumcraft and Inspiration, which causes an issue with Pipes. 3 iron bars create a pipe, instead of an iron plate.  I attempted to try and delete the pip file, but I'll be honest, I'm not super tech savvy. Could anyone, kindly, help with how to properly disable the pipe code? Thank you!!

Disable pipes in the config if you must (google Forge configs), though I'd argue this issue is really on Thaumcraft's side as the generally accepted recipe is 2 iron for a plate. I'll consider changing the recipe in the future, but the easiest fix for you is either changing it yourself using a mod such as crafttweaker

Resolved in 0.2.4


MQTT log in

Trying to connect to the MQTT via MQTT.fx, I wonder where I can get this one from:
A JSON Web Token from the API can be used as a password.
Any explanation?
Thanks, Best
Klim

Please see this section of the documentation: "Q: How Can I Generate an API Token". You will probably want to use the curl method.


Feature request

Awesome indicator, could you add alert when price touches the line?

Thanks, that sounds like a good option. I'll let you know what I come up with. Happy holidays!

Been working on Similar project.
Great idea is to allow alerts when the line is touched, but entry should be when price closes above a buy line or below a sell line.
I mean the close of the candles should be above/below for sell/buys respectively ('Raid' the buy/sell lines). I bet you it changes the outlook. The best entries are circled in white.


examples/windowssize: -autorestore doesn't work correctly on Windows

This worked with v2.3.0-alpha.


Implementation for Engagement_Presets and Network_Locations API

Added support to the v2 API for Engagement_Presets and Network_Locations

I simplified the engagement presets permissions implementation and removed the network locations implementation in favor of the model permissions as requested.  I removed the  engagement presets validation as it was simply replacing a null scope with an empty space to prevent errors, the user can do that in the api.
I'm thinking about using the engagement presets api with some automation so when a new engagement is created based on a preset, specific tests within the preset can be performed automatically and the results can then be uploaded as part of the engagement.  However, for this to be possible, the tests that are part of the preset need to be available and I didn't find an existing api that would allow me to determine that.

There is currently no functionality implemented concerning Engagement_Presets. You can save new ones and edit them, but that's it.

There appears to be enough functionality to implement what I was thinking (except for the API support).  I have been able to Add/Edit/Delete an Engagement_Preset, assign an Engagement_Preset to an existing or new engagement (both in the UI and the engagement API), and an Engagement_Preset panel appears on the engagement screen with details when an Engagement_Preset has been assigned to the engagement.


ESU notifications?

Is there a way for customers to receive notices when patches are available within the SQL Server registry portal?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd3e29e8-6559-58d3-27a5-3c443bd76c94
Version Independent ID: 37b33566-6d93-ca52-7f54-4101ddb3a332
Content: What are Extended Security Updates? - SQL Server
Content Source: docs/sql-server/end-of-support/sql-server-extended-security-updates.md
Product: sql
Technology: install
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

Hi @chjone , thanks for contacting Microsoft! Let me do a bit of research for you :)
Thanks!
Masha from the SQL Docs team

@WilliamAntonRohm please reach out to your TAM for further information on how we will be advertising ESU releases.

My TAMs are the ones asking me...

Typing with thumbs, please excuse brevity & typos.
Get Outlookhttps://aka.ms/qtex0l for iOS

From: Pedro Lopes<EMAIL_ADDRESS>Sent: Tuesday, March 17, 2020 4:53:24 PM
To: MicrosoftDocs/sql-docs<EMAIL_ADDRESS>Cc: Chris Jones<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/sql-docs] ESU notifications? (#4284)
@WilliamAntonRohmhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FWilliamAntonRohm&data=02|01|chjone%40microsoft.com|490fd2da9c334b8cd1ae08d7cace61be|72f988bf86f141af91ab2d7cd011db47|1|0|637200860066461135&sdata=HTlXqzRLyl4G2g4t1CIRb2x%2FRi9OUW%2Fz9crdhu1GVnc%3D&reserved=0 please reach out to your TAM for further information on how we will be advertising ESU releases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fsql-docs%2Fissues%2F4284%23issuecomment-600355752&data=02|01|chjone%40microsoft.com|490fd2da9c334b8cd1ae08d7cace61be|72f988bf86f141af91ab2d7cd011db47|1|0|637200860066461135&sdata=bVsmpl9IqkO88TnU%2BRLCV8Sm3SEWDdIMPvCfQXzyAAQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKMZEWCUWDYNTEFHKLVAPWLRIAEPJANCNFSM4LCO63JA&data=02|01|chjone%40microsoft.com|490fd2da9c334b8cd1ae08d7cace61be|72f988bf86f141af91ab2d7cd011db47|1|0|637200860066471128&sdata=rf4dUeAhTcT8AXGHJSri5jzZCZAu9SBK%2F15tT54HEeo%3D&reserved=0.

Please have them reach out to me directly.

Hi @chjone , I am going to close out this Git Issue for now as having been answered, but please feel free to comment should you have any additional questions or need further assistance.
Thanks and hope you have a wonderful rest of your day!
Masha from the SQL Docs team


added fix for language detection

This PR adds a fix for the language detection feature.

@hacktivist123 I have tested. You can go ahead and test. If you have any features to add. Any I can help with

@quamejnr check this out and let me know what you think since this relates to your PR

Yeah it looks good, wanted to first implement something like that but changed my mind later.
But in the usecase that's being proposed. considering both .js files and .ts files all have the same gitignore file, I don't quite see what changes it will make, unless there will be an introduction of a typescript exclusive gitignore file

Yes, there will actually be a typescript specific file soon.
So I’m going to merge this, then you can rebase your current PR and see if you can refactor your tests a bit. Is that fine with you? @quamejnr

Yes that's fine, if the merge goes well, I think the tests will work fine or is there something else you think would change?

Not sure, but let's see how it goes


Fix infer_auto_device_map when tied weights share the same prefix name

As per title, thanks to @giuseppe5 & @nickfraser notice.
On main currently, the detection of tied_param_goups and tied_params is wrong as e.g. if we have a group ["compute.weight", "compute.weight_submodule.parameter"] and we are currently treating the parameter compute.weight, tied_param_goups will wrongfully be empty as all(name in k for k in tied_group) is True.
This result in an error in this example:
import torch
import accelerate

class SubModule(torch.nn.Module):
  def __init__(self, ref_to_parameter):
    super().__init__()
    self.parameter = ref_to_parameter
  def forward(self, x):
    return self.x + torch.max(self.parameter)

class LinearModuleAndSubModule(torch.nn.Linear):
  def __init__(self, in_features, out_features):
    super().__init__(in_features, out_features)
    self.weight_submodule = SubModule(self.weight)
  def forward(self, x):
    return torch.nn.functional.linear(self.weight_submodule(x), self.weight)

class Model(torch.nn.Module):
  def __init__(self):
    super().__init__()
    self.compute = LinearModuleAndSubModule(3, 8)
  def forward(self, x):
    return self.compute(x)

model = Model()
print(model)

from accelerate.utils import infer_auto_device_map
# Low memory device, just to force splitting and trigger the error
device_memory = {0: 4, 'cpu': 96000}
device_map = infer_auto_device_map(model, device_memory, verbose=True)

The error does not exist if we use the name self.brrrweight_submodule instead of self.weight_submodule.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Update year

Update all headers, licence and docs to 2023
Some recently added moduels were missing headers. Those were added. Older files with missing header was not changed.

We decided to purge these headers and rely on the project-wide license.


chore: package.json description change

:tada: This PR is included in version 2.2.432 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CI: setup automatic builds

Note:
I haven't hooked up q2lint because I wasn't sure how we want to handle the copyright holder, and aside from that, the reference license hard-codes the year to 2016-2017, so there's not a great way to keep the 2017 year for this particular license without changing q2lint slightly.

Also, tests won't pass until busywork flushes out a new environment file (that's expected).

Coverage remained the same at 89.718% when pulling 9d9680069a3a337a7d11dd6cfe0d0b17fa11410b on ebolyen:ci-cd into 60d4f4b14c174d59206572ff852181519c5d6172 on qiime2:master.

Ignoring the drop in coverage --- that makes no sense to me, you made virtually no code changes. Thanks @ebolyen!


HAWQ-159. Fix the bug when hawq disconnect from libyarn, heartbeat th…

Segmentation fault happens when Hawq disconnect from libyarn. That is because heartbeat thread hasn't been canceled. Try to fix it.

looks good.

Looks good to me. +1


Idea: Final Round Question

One final round where everybody has to answer the same one question. Then, everybody has to try to match players to what they answered. Points to players for each correct guess. Time bonus so someone will have to win even if it's really close to a tie.

right now, there is a tiebreaker that is Friends Trivia. this could replace that - we should not need a tiebreaker.
this should be fun


Tweak dependencies

Applied latest updates of crypto dependencies ~(most notably: the crates aes and aes-ctr were unified)~ but not aes since it requires rust 1.49.
I realized that the block-modes dependency wasn't used anywhere so I removed it.
~Bumped zerocopy from 0.3 to 0.5.~ (Needs rust version 1.51)
Update Cargo.lock
The latest versions of hyper and libmdns require rust 1.46, and sdl requires 1.48, so I bumped the MSRV.
Adjusted some lower bounds of the version range to match the functionality we use. Unfortunately I was not able to make rm Cargo.lock && cargo +nightly build -Z minimal-versions work, but it's a step into the right direction.

While you're at it, there's a new libc too.

We don't use libc anywhere directly?
Let's try MSRV 1.48 next. This is the rustc version of the upcoming debian release.

It's here: https://github.com/librespot-org/librespot/blob/cc9d6f54ced1f5c30a720185652bcd8c8c828335/playback/Cargo.toml#L33
But you're right it's only a dependency for various backends and I think libvorbis so might as well be removed here?

Let's see whether this works

libc was used in the pulseaudio backend but wasn't removed when it wasn't needed anymore: 0411e6954822cf97afb7d58b6088f8125aca78df

I just tried and it's OK to update sdl2 on Rust 1.48:
diff --git a/playback/Cargo.toml b/playback/Cargo.toml
index b8736db..92bfb4a 100644
--- a/playback/Cargo.toml
+++ b/playback/Cargo.toml
@@ -31,7 +31,7 @@ libpulse-binding        = { version = "2", optional = true, default-features = f
 libpulse-simple-binding = { version = "2", optional = true, default-features = false }
 jack            = { version = "0.6", optional = true }
 libc            = { version = "0.2", optional = true }
-sdl2            = { version = "0.34.3", optional = true }
+sdl2            = { version = "0.34", optional = true }
 gstreamer       = { version = "0.16", optional = true }
 gstreamer-app   = { version = "0.16", optional = true }
 glib            = { version = "0.10", optional = true }

0.34.3 means >=0.34.3, <0.35.0 and 0.34 is equivalent to 0.34.4 which means >=0.34.0,<0.35.0. If you look at the Cargo.lock, you'll see that sdl2 is already on 0.34.5.

Ah I see, thanks.


Fixed Joint parameters for use of IMU

It is necessary to set a desired link for either of "Connected Body" or "Connected Articulation Body" parameter in Fixed Joint parameters.
However, the code looks like only aquisiting Rigidbody infomation like this:
https://github.com/arav-jp/UnitySensors/blob/main/Scripts/Runtime/IMU/IMU.cs#L71
And, Articulation Body class does not inheritate Rigid Body class, so I'm wondering where the program aquire Articulation Body info.

I merged your modification PR.
This issue looks solved. I will close this.


Not able to build the project

📝 Describe the Bug
When updated latest version, It's giving this error for building project.
📖 Library Version

PDF Viewer Version: : 2.0.3

📖 Project Version

minSdk 23
targetSdk 34
compileSdk 34

📖 Android studio Version
Android Studio Hedgehog | 2023.1.1
Build #AI-231.9392.1.2311.11076708, built on November 9, 2023
Runtime version: 17.0.7+0-17.0.7b1000.6-10550314 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.7.1
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 4
Metal Rendering is ON
Registry:
external.system.auto.import.disabled=true
debugger.new.tool.window.layout=true
ide.text.editor.with.preview.show.floating.toolbar=false
ide.experimental.ui=true
ide.images.show.chessboard=true
Non-Bundled Plugins:
com.intellij.marketplace (231.9392.3)
Dart (231.9409)
wu.seal.tool.jsontokotlin (3.7.4)
idea.plugin.protoeditor (231.9225.5)
dev.polek.adbwifi (1.2.5)
izhangzhihao.rainbow.brackets (2023.3.7)
io.flutter (76.3.3)
🚶 Steps to Reproduce
Please follow these steps to reproduce the issue:
Check attached image
Used this in my project
<uses-permission
        android:name="android.permission.WRITE_EXTERNAL_STORAGE"
        android:maxSdkVersion="28" />

Hi, the issue you are facing is due to the max sdk version for write permission. In my library i have put it as 32 (suggested by Android studio).
You can do either of these two things:

Bump maxSdkVersion from 28 to 32 if you do not have restrictions.
or you can use tools:replace="android:maxSdkVersion" as suggested in error.    android:name="android.permission.WRITE_EXTERNAL_STORAGE"
    android:maxSdkVersion="28"
    tools:replace="android:maxSdkVersion"/>```

Hi @afreakyelf
1. I can't use first option as Write External will not work after Android 9(SDK 28). Check attached image from official website. Ref

When I put maxSdkVersion 32, I get this warning in studio. Pasted below :
Warning from Android studio
WRITE_EXTERNAL_STORAGE no longer provides write access when targeting Android 10+ More... (⌘F1)
Inspection info:Scoped storage is enforced on Android 10+ (or Android 11+ if using requestLegacyExternalStorage). In particular, WRITE_EXTERNAL_STORAGE will no longer provide write access to all files; it will provide the equivalent of READ_EXTERNAL_STORAGE instead.  As of Android 13, if you need to query or interact with MediaStore or media files on the shared storage, you should be using instead one or more new storage permissions: * android.permission.READ_MEDIA_IMAGES * android.permission.READ_MEDIA_VIDEO * android.permission.READ_MEDIA_AUDIO  and then add maxSdkVersion="33" to the older permission. See the developer guide for how to do this: https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions  The MANAGE_EXTERNAL_STORAGE permission can be used to manage all files, but it is rarely necessary and most apps on Google Play are not allowed to use it. Most apps should instead migrate to use scoped storage. To modify or delete files, apps should request write access from the user as described at https://goo.gle/android-mediastore-createwriterequest.
2. I used second option but it's give me another error.

Thanks for pointing out. I must have missed it.
I will check the first point, meanwhile did you try the second option like this?
android:name="android.permission.WRITE_EXTERNAL_STORAGE"
android:maxSdkVersion="28"
tools:replace="android:maxSdkVersion"/>

@afreakyelf
I mentioned second option in my above comment. Please check it.

Yes but it says "no value specified" that's why I asked if you put the snippet correct.

@afreakyelf
I put above snippet but still it gives the error posted above.

Alright. I will take a look as soon as possible thank you!

Hi @hiteshsarsava , Can you try with com.github.afreakyelf:Pdf-Viewer:v2.0.4, I just released it.

Hi, Closing this as haven't heard from you.  Please feel free to reopen.

Thanks @afreakyelf It solved my issue.

@afreakyelf Can you explain why this library that shows PDF needs android.permission.WRITE_EXTERNAL_STORAGE and android.permission.READ_EXTERNAL_STORAGE permission ?
Just to be sure if I can remove these in my merged Manifest.


How can i make more quests in 1 quest?

Build number: 3.2.2
I want to make more quests in 1 quest. I cant find a tutorial about that.

Quest:
You talk to npc
npc: I can't find my glasses will you help me?
Stages:

Reach locations (too help look)

talk to ron

return back to the first npc

The thing is, that once you finish the quest, you get the rewards, but if you do the quest similar to what's above, you can pretend to give the player the glasses, but really you're completing the 'stage' which will then allow you to return to the first npc as if you got the glasses.
Doing the deliver item objective is assuming you already have the glasses, which you won't if it's supposed to be from the same quest. What you could do is have something near ron that gives you the glasses like a command block or using npc commands plugin, then set the give item since you 'got' them from ron.
Other than that, you're left with pretending you got the glasses

A good answer by @Midnight9746, thanks! Hopefully this is sufficient. Otherwise, check out the discussion thread on Spigot.


Pick up libpcap from pkg-config if available.

To keep existing behaviour, it will look for LIBPCAP_LIBDIR first and only then go the pkg-config way and then go for the hail mary as it used to. This will be less likely to break any existing setup and is similar to pq-sys for example.
Fixes #276

Great! Thanks a lot!
Could I ask you to just wrap this up with an update to the CHANGELOG.md file and to the README sections "Library location" and "Library version" to explain the use of pkg config. It might be worth pointing out that this can be used to configure static linking which some people are quite interested in (https://docs.rs/pkg-config/latest/pkg_config/).
Just a few sentences and don't worry about word smithing. I can modify/polish it later myself. There's also no rush, so whenever you have time.

Added some words to README and CHANGELOG + added a change to honour LIBPCAP_VER even in pkg-config scenario.


allow partial certificate chain for *.toggl.com

currently desktop uses http://curl.haxx.se/ca/cacert.pem but it would be better if you switch to http://curl.haxx.se/docs/mk-ca-bundle.html and extract all certificates.
Or alternatively - vendor full chain for toggl inside client, so it would not need  to be retransfered for every new connection again.
main goal is to reduce traffic needed for handshake making connections faster

we could concat the whole chain as needed. where is it?

openssl s_client -showcerts -connect toggl.com:443 </dev/null
..but not throw away current root's - so that if we -republish cert with full, but different chain it will not break, it's good be able switch stuff without rollout of clients.


Add proper support for CRD 'crds/' templating & support for CRDs in 'templates/' folder

What this PR does / why we need it:
Currently CRDs are too much of an afterthought. Keeping in mind https://github.com/helm/community/blob/main/hips/hip-0011.md, there are still quite a few improvements that can be made to Helm with regards to installing CRDs.

adds support for templating crds in the 'crds/' folder
filters crds in the 'templates/' folder and installs these resources first, also makes sure that the "discoveryClient.Invalidate" function is called after installing these CRDs

Context:
A request that we get a lot from cert-manager Helm Chart users is to move our CRDs to the "crds/" folder. However, we cannot do this because there are some templated fields in the CRDs (like labels & conversion webhook configs). Instead, we place the CRDs in the "templates/" folder, which makes it impossible to also add CRs in the Helm chart or in charts that use cert-manager as a dependency.
This PR proposes two fixes for the problem: 1) make resources in "crds/" folder templatable and 2) support CRDs in the "templates/" folder
Special notes for your reviewer:
Feel free to post some comments/ thoughts on these improvements.
If applicable:

[ ] this PR contains documentation // TODO
[x] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Thanks for the PR! During the dev call I mentioned some existing literature. I think the most pertinent is:
https://github.com/helm/community/blob/main/hips/hip-0011.md
@joejulian even wrote a blog post :):
https://joejulian.name/post/helm-v2-crd-management/ (I think still relevant for helm v3)
And if I remember correctly, there are some issues (and perhaps even existing PRs) in the backlog. But from memory, the HIP documents well/comprehensively the challenges.

TBH having the ability to only use a subset for templating like in the metadata.annotations and metadata.labels would be already a very good improvement. Even if it would not be by real templating but maybe just something like --crd-annotation x:y or --crd-label x:y in the CLI parameters.
The full templating support might cause a lot of issues to think about. But Annotations and Labels would improve a lot of Declarative Pipeline Tools Usages with less risk for issues.

This would need a PR to hip-0011 to be approved first.


Refactor -> Move should recognize a concrete class in the module (if it contains not the only class)

Let's say I have module with name SomeModule.hx which contains classes SomeModule and SomeHelper. I'd like to move only SomeHelper outside to separate module, but currently refactor->move moves entire module with both classes.
By example, doing it from any place should move as usually (entire module), but if "move" started from specific class name - "move" moves only that class.

yes, it is good idea


Update endpoints (users, pdfs, courses)

Users should be able to update their information in auth and firestore

Update endpoints for /pdf routes don't really make sense. So only created update endpoints on /users and /courses