HADOOP-17511. Add audit logging to S3A connector

Notion of AuditSpan which is created for a given operation; goal is
to pass it along everywhere.
It's thread local per FS-instance; store operations pick this up in their
constructor from the StoreContext.
The entryPoint() method in S3A FS has been enhanced to initiate the spans.
For this to work, internal code SHALL NOT call those entry points (Done)
and all public API points MUST be declared as entry points. Tricky given
the lack of layering in this branch.
The auditing is intended to be a plugin point; currently there is one
which logs at Info (yes, noisy but good for development)
Change-Id: Idddbbd3138e52b40e97f9c2383453190a02cd8ec
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

Testing? Not yet. It compiles, and I've done a few of the ITests.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
4m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 52s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 43s

trunk passed

+1 :green_heart:
shadedclient
14m 15s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m  5s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  3s

trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 20s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 20s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
javac
0m 20s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-0 :warning:
checkstyle
0m 20s
/diff-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 5 new + 14 unchanged - 0 fixed = 19 total (was 14)

-1 :x:
mvnsite
0m 22s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 48s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 28s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
findbugs
0m 25s
/patch-findbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 25s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

74m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux bc23b0127437 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6c891c0dd48

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/1/testReport/

Max. process+thread count
648 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/1/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Revised....!

Latest PR has mkdir under files working by the look of things
textURI
[ERROR] testMkdirsFailsForSubdirectoryOfExistingFile(org.apache.hadoop.fs.s3a.fileContext.ITestS3AFileContextURI)  Time elapsed: 6.385 s  <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertFalse(Assert.java:64)
	at org.junit.Assert.assertFalse(Assert.java:74)
	at org.apache.hadoop.fs.FileContextURIBase.testMkdirsFailsForSubdirectoryOfExistingFile(FileContextURIBase.java:260)

@kabeersdev hello, I hope this means you are volunteering to help review this PR

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
28m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 38s

trunk passed

+1 :green_heart:
compile
0m 49s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
shadedclient
19m 23s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 21s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m 21s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 19s

trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 24s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
0m 26s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
0m 26s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 22s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
javac
0m 22s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-0 :warning:
checkstyle
0m 27s
/diff-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 6 new + 15 unchanged - 0 fixed = 21 total (was 15)

-1 :x:
mvnsite
0m 25s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 30s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 30s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
findbugs
0m 24s
/patch-findbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 24s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

118m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 282bdd261ab0 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6c891c0dd48

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/2/testReport/

Max. process+thread count
512 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/2/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
5m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 31s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 15s

trunk passed

+1 :green_heart:
compile
20m 43s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m  9s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
4m 33s

trunk passed

+1 :green_heart:
mvnsite
2m 31s

trunk passed

+1 :green_heart:
shadedclient
21m 48s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 24s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m 19s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 33s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
20m 10s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
20m 10s

the patch passed

+1 :green_heart:
compile
18m 13s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
18m 13s

the patch passed

-0 :warning:
checkstyle
3m 46s
/diff-checkstyle-root.txt
root: The patch generated 6 new + 21 unchanged - 0 fixed = 27 total (was 21)

+1 :green_heart:
mvnsite
2m 29s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 10s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 42s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 44s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

+1 :green_heart:
findbugs
3m 46s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
17m 12s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m  5s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

205m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f6bc30f6ec74 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6c891c0dd48

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/3/testReport/

Max. process+thread count
2841 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/3/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 11s

trunk passed

+1 :green_heart:
compile
20m 36s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
17m 53s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
3m 44s

trunk passed

+1 :green_heart:
mvnsite
2m 27s

trunk passed

+1 :green_heart:
shadedclient
20m  0s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 26s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m 17s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 30s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
19m 58s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
19m 58s

the patch passed

+1 :green_heart:
compile
17m 57s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
17m 57s

the patch passed

-0 :warning:
checkstyle
3m 43s
/diff-checkstyle-root.txt
root: The patch generated 5 new + 21 unchanged - 0 fixed = 26 total (was 21)

+1 :green_heart:
mvnsite
2m 23s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 22s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 45s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

+1 :green_heart:
findbugs
3m 48s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
17m 12s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m  3s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

195m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 809853340ffb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f37bf651993

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/4/testReport/

Max. process+thread count
3152 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/4/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  6s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 23s

trunk passed

+1 :green_heart:
compile
24m 10s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 52s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
4m  9s

trunk passed

+1 :green_heart:
mvnsite
2m 18s

trunk passed

+1 :green_heart:
shadedclient
22m 36s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  6s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m 11s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 30s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 31s

the patch passed

+1 :green_heart:
compile
23m  8s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m  8s

the patch passed

+1 :green_heart:
compile
19m 44s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
19m 44s

the patch passed

-0 :warning:
checkstyle
3m 59s
/diff-checkstyle-root.txt
root: The patch generated 4 new + 23 unchanged - 0 fixed = 27 total (was 23)

+1 :green_heart:
mvnsite
2m 15s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 47s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 36s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

+1 :green_heart:
findbugs
3m 46s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
17m 38s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m  6s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

212m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 21b6991820a8 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 394b9f7a5c4

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/5/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/5/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 41s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 30s

trunk passed

+1 :green_heart:
compile
20m 34s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
17m 50s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
3m 48s

trunk passed

+1 :green_heart:
mvnsite
2m 24s

trunk passed

+1 :green_heart:
shadedclient
20m  5s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 21s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m 15s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 33s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
21m  3s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m  3s

the patch passed

+1 :green_heart:
compile
19m 12s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
19m 12s

the patch passed

-0 :warning:
checkstyle
3m 45s
/diff-checkstyle-root.txt
root: The patch generated 8 new + 25 unchanged - 0 fixed = 33 total (was 25)

+1 :green_heart:
mvnsite
2m 21s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 23s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 39s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

+1 :green_heart:
findbugs
3m 52s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
17m 25s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 59s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

197m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux bfb84f6c54ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 66ecee333e0

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/6/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/6/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 15s

trunk passed

+1 :green_heart:
compile
22m  2s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m 44s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
3m 55s

trunk passed

+1 :green_heart:
mvnsite
2m 15s

trunk passed

+1 :green_heart:
shadedclient
23m 16s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  2s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m 12s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 32s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 13s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
22m 43s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
22m 43s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
18m 59s
/patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
root in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
javac
18m 59s
/patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
root in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-0 :warning:
checkstyle
3m 48s
/buildtool-patch-checkstyle-root.txt
The patch fails to run checkstyle in root

-1 :x:
mvnsite
0m 29s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
whitespace
0m  1s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 26s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 28s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
findbugs
0m 26s
/patch-findbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
17m 53s

hadoop-common in the patch passed.

-1 :x:
unit
0m 26s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

204m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 18bd417cb2c2 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 182623d2bc7

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/7/testReport/

Max. process+thread count
1247 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/7/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Latest release adds operation context info to the referer logs so can generate a trace mapping S3 operations to the FS ops and S3A FS instance making the call. No tie-in to opentelemetry tho'.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  7s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 16s

trunk passed

+1 :green_heart:
compile
20m 46s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
17m 52s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
3m 52s

trunk passed

+1 :green_heart:
mvnsite
2m 24s

trunk passed

+1 :green_heart:
shadedclient
19m 58s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 20s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m 18s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 32s

trunk passed

-0 :warning:
patch
1m 40s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
19m 59s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
19m 59s
/diff-compile-javac-root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 generated 1 new + 2026 unchanged - 1 fixed = 2027 total (was 2027)

+1 :green_heart:
compile
17m 56s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

-1 :x:
javac
17m 56s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 generated 1 new + 1921 unchanged - 1 fixed = 1922 total (was 1922)

-0 :warning:
checkstyle
3m 40s
/diff-checkstyle-root.txt
root: The patch generated 12 new + 42 unchanged - 0 fixed = 54 total (was 42)

+1 :green_heart:
mvnsite
2m 25s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 28s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 44s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
findbugs
1m 26s
/new-findbugs-hadoop-tools_hadoop-aws.html
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
17m 13s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m  3s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

194m  7s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Dead store to span in org.apache.hadoop.fs.s3a.S3AFileSystem.create(Path, FsPermission, boolean, int, short, long, Progressable)  At S3AFileSystem.java:org.apache.hadoop.fs.s3a.S3AFileSystem.create(Path, FsPermission, boolean, int, short, long, Progressable)  At S3AFileSystem.java:[line 1399]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 10a17e9113d0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5e719bf5886

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/8/testReport/

Max. process+thread count
2451 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/8/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

HADOOP-15711. Auditing: scope/coverage
running all the tests with auditing set to fail if any call is made
unaudited highlights scope for improvement.
Production

Critical: nested scopes
Committers: scoping
S3GuardTool spans around lower-level operations.
Multipart listing to become a spanned entry point.

Test

create spans before all tests doing low-level things

Still a WiP, needs

new tests for new code
full coverage
stability on http referrer format. Even if doesn't yet use opentelemetry, I'd like compatible names/structure

+thinking of seeing how to push in telemetry prepareRequest() into AWS SDK logic so all SDK calls have span checking/header addition, and production code would actually be slightly leaner.
Needs me to understand the SDK a bit better, then for the audit manager to use an appropriate plugin point in the
SDK to hand off to the active audit for preparation.

Example log from a bit of a test run;
logs2021-02-05-15-25-40-BD60AB2786B3EBED.txt

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 20 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 15s

trunk passed

+1 :green_heart:
compile
24m 14s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m  3s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
4m  3s

trunk passed

+1 :green_heart:
mvnsite
2m 30s

trunk passed

+1 :green_heart:
shadedclient
22m 43s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  5s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m 13s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 36s

trunk passed

-0 :warning:
patch
1m 33s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 27s

the patch passed

+1 :green_heart:
compile
23m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
23m 29s
/diff-compile-javac-root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 generated 1 new + 2026 unchanged - 1 fixed = 2027 total (was 2027)

+1 :green_heart:
compile
22m 43s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

-1 :x:
javac
22m 43s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 generated 1 new + 1921 unchanged - 1 fixed = 1922 total (was 1922)

-0 :warning:
checkstyle
3m 59s
/diff-checkstyle-root.txt
root: The patch generated 4 new + 53 unchanged - 0 fixed = 57 total (was 53)

+1 :green_heart:
mvnsite
2m 17s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 49s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 35s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
findbugs
1m 25s
/new-findbugs-hadoop-tools_hadoop-aws.html
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
17m 10s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 51s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

217m  6s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Dead store to span in org.apache.hadoop.fs.s3a.S3AFileSystem.create(Path, FsPermission, boolean, int, short, long, Progressable)  At S3AFileSystem.java:org.apache.hadoop.fs.s3a.S3AFileSystem.create(Path, FsPermission, boolean, int, short, long, Progressable)  At S3AFileSystem.java:[line 1412]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4a892e99ba9b 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 65857ea7c07

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/9/testReport/

Max. process+thread count
1828 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/9/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@bgaborg: thanks for the comments, will take them on. I've done another iteration of this which won't currently compile (pulls in the request factory from my refactoring, to do the prepareRequest() in there rather than throughout the source. Also I'm trying to make that context for the logs really useful by wiring up spark/MR jobs and including that info. We will be able to see which job is doing the IO, rather than just the user. sweet eh?

Testing: all those which talk to landsat or common crawl fail -that's what happens when you switch to the new s3 client constructor. Which I didn't think I had done, not on this branch.

Latest PR moves the prepareRequest() callback of the active span into the AWS SDK.
HEAD^ does it in the request factory construction -that's still supported, but if we can keep the AWS SDK wiring -that will be better

guarantee of being invoked on all S3 operations, even those done in the client during startup
means we get audit/log of calls like doesBucketExistV2 without us reimplementing them
means we can simplify the work I've just done regarding  marking operations as OnceRaw and walking up/down the callstack

But: this does mean we need to solve the problem of endpoints and regions

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 23 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  1s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 37s

trunk passed

+1 :green_heart:
compile
22m 11s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 17s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
3m 57s

trunk passed

+1 :green_heart:
mvnsite
2m 16s

trunk passed

+1 :green_heart:
shadedclient
23m 27s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 25s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
31m 41s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
3m 59s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 41s

the patch passed

+1 :green_heart:
compile
23m 40s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
23m 40s
/diff-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1958 unchanged - 1 fixed = 1959 total (was 1959)

+1 :green_heart:
compile
18m 49s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
18m 49s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1853 unchanged - 1 fixed = 1854 total (was 1854)

-0 :warning:
checkstyle
3m 54s
/diff-checkstyle-root.txt
root: The patch generated 29 new + 83 unchanged - 0 fixed = 112 total (was 83)

+1 :green_heart:
mvnsite
2m 11s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 23s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 35s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
spotbugs
2m 23s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common cannot run computeBugHistory from spotbugs

-1 :x:
spotbugs
1m 12s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
17m 17s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 52s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

208m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint

uname
Linux 5d48d0a2d5ba 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ed9e36282c

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/11/testReport/

Max. process+thread count
2841 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 25 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m  6s

trunk passed

+1 :green_heart:
compile
22m 56s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
21m 12s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
3m 53s

trunk passed

+1 :green_heart:
mvnsite
2m 19s

trunk passed

+1 :green_heart:
shadedclient
23m 25s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 25s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
31m 24s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
4m  8s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 47s

the patch passed

+1 :green_heart:
compile
25m  1s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
25m  1s
/diff-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1958 unchanged - 1 fixed = 1959 total (was 1959)

+1 :green_heart:
compile
19m 53s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
19m 53s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1853 unchanged - 1 fixed = 1854 total (was 1854)

-0 :warning:
checkstyle
4m  9s
/diff-checkstyle-root.txt
root: The patch generated 30 new + 170 unchanged - 0 fixed = 200 total (was 170)

+1 :green_heart:
mvnsite
2m 25s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
16m 36s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 37s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
spotbugs
2m 40s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common cannot run computeBugHistory from spotbugs

-1 :x:
spotbugs
1m 28s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
18m 54s

hadoop-common in the patch passed.

-1 :x:
unit
1m 56s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

219m  9s

Reason
Tests

Failed junit tests
hadoop.fs.s3a.s3guard.TestS3Guard

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint

uname
Linux 2cbb2389947a 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ed9e36282c

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/12/testReport/

Max. process+thread count
2670 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 25 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 51s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 38s

trunk passed

+1 :green_heart:
compile
24m  4s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
22m 34s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
4m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 28s

trunk passed

+1 :green_heart:
shadedclient
24m 18s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 12s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
31m 40s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
3m 42s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 37s

the patch passed

+1 :green_heart:
compile
23m  4s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
23m  4s
/diff-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1960 unchanged - 1 fixed = 1961 total (was 1961)

+1 :green_heart:
compile
20m 55s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
20m 55s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1855 unchanged - 1 fixed = 1856 total (was 1856)

-0 :warning:
checkstyle
4m  7s
/diff-checkstyle-root.txt
root: The patch generated 30 new + 170 unchanged - 0 fixed = 200 total (was 170)

+1 :green_heart:
mvnsite
2m 11s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 16s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 36s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
spotbugs
2m 19s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common cannot run computeBugHistory from spotbugs

-1 :x:
spotbugs
1m 12s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
17m  8s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 21s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

219m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint

uname
Linux 864fe2788998 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e391844e8e4

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/13/testReport/

Max. process+thread count
1248 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/13/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 25 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 43s

trunk passed

+1 :green_heart:
compile
22m 16s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 25s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
3m 59s

trunk passed

+1 :green_heart:
mvnsite
2m 15s

trunk passed

+1 :green_heart:
shadedclient
22m  7s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 24s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  4s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
29m  7s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
3m 29s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
21m 34s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
21m 34s
/diff-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1958 unchanged - 1 fixed = 1959 total (was 1959)

+1 :green_heart:
compile
18m 52s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
18m 52s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1853 unchanged - 1 fixed = 1854 total (was 1854)

-0 :warning:
checkstyle
3m 54s
/diff-checkstyle-root.txt
root: The patch generated 35 new + 170 unchanged - 0 fixed = 205 total (was 170)

+1 :green_heart:
mvnsite
2m 12s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 43s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 36s
/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 3 new + 81 unchanged - 7 fixed = 84 total (was 88)

-1 :x:
spotbugs
2m 21s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common cannot run computeBugHistory from spotbugs

-1 :x:
spotbugs
1m 13s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
17m 15s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 54s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

205m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint

uname
Linux 4cd128a332a0 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e391844e8e4

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/14/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/14/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 25 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m  4s

trunk passed

+1 :green_heart:
compile
22m 17s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m 52s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
4m  0s

trunk passed

+1 :green_heart:
mvnsite
2m 16s

trunk passed

+1 :green_heart:
shadedclient
22m  7s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  7s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
1m 12s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 29s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
21m 35s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
21m 35s
/diff-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1958 unchanged - 1 fixed = 1959 total (was 1959)

+1 :green_heart:
compile
19m  0s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
19m  0s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1853 unchanged - 1 fixed = 1854 total (was 1854)

-0 :warning:
checkstyle
5m 17s
/diff-checkstyle-root.txt
root: The patch generated 41 new + 170 unchanged - 0 fixed = 211 total (was 170)

-1 :x:
mvnsite
0m 49s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 36s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 36s
/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 6 new + 81 unchanged - 7 fixed = 87 total (was 88)

-1 :x:
findbugs
0m 33s
/patch-findbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
17m 17s

hadoop-common in the patch passed.

-1 :x:
unit
0m 32s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

204m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux e777750772f6 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d28b6f90c8c

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/15/testReport/

Max. process+thread count
1883 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/15/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

This hits the big milestone of this has got complicated.
For best-effort tracking of what is the FS operation this thread initiated, we are functionally complete.
For anything more rigorous where the lifespan of operations is tracked: no.
I also think the attempts to preserve and restore the previous span get too complex/unreliable once you start considering spans with more complex lifecycles (what if you the previous span has already been closed?)
I'm going to take a couple of days off from this and do other stuff for the 3.3.1 release (which this is too big/complex to make).
Then think about how better to do this.
What do we want?

Maybe differentiate bounded and long-lived spans? with different API to create?
Or declare that close() must be callable > once and do nothing but log in an audit service
and that its not an error to call it on a closed span.

The S3A FS code will be slightly more sophisticated in that bounded try-with-resources spans
will, when close()d, switch the current thread to the unbonded span (i.e. no attempt to restore
to previous one). And when we handoff() a span, we get a new span and the active one is made inactive
immediately.
Like I said: I need to think of what we are trying to achieve here.

Based on an afternoon looking at client-side logs of a single hive process

add the thread name as part of the referrer, so we can filter on "all S3 calls made by thread 9".
a random process ID which is common for all FS instances in that vm

Thread ID critical for isolating a sequence of operations...with isolated span IDs the current patch doesn't join things together

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 18s

https://github.com/apache/hadoop/pull/2675 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/26/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

This PR is (And will repeatedly be) rebased on top of #2778; as that gets revised this will be force pushed.
Latest PR pulls out getContentStatus as it turns out some apps use it too much. The stats and logs will now make clear how much IO it uses.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 37 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  0s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 14s

trunk passed

+1 :green_heart:
compile
22m 29s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m 47s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
4m  4s

trunk passed

+1 :green_heart:
mvnsite
2m 17s

trunk passed

-1 :x:
javadoc
0m 58s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

+1 :green_heart:
javadoc
2m  7s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 32s

trunk passed

+1 :green_heart:
shadedclient
16m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
21m 40s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
21m 40s
/results-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1955 unchanged - 1 fixed = 1956 total (was 1956)

+1 :green_heart:
compile
18m 52s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
18m 52s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1850 unchanged - 1 fixed = 1851 total (was 1851)

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
3m 52s
/results-checkstyle-root.txt
root: The patch generated 48 new + 192 unchanged - 7 fixed = 240 total (was 199)

+1 :green_heart:
mvnsite
2m 14s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 57s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javadoc
0m 37s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
spotbugs
1m 26s
/new-spotbugs-hadoop-tools_hadoop-aws.html
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
17m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 45s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 31s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

207m 36s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-aws

Dead store to awsResponse in org.apache.hadoop.fs.s3a.audit.LoggingAuditor$LoggingAuditSpan.afterResponse(Request, Response)  At LoggingAuditor.java:org.apache.hadoop.fs.s3a.audit.LoggingAuditor$LoggingAuditSpan.afterResponse(Request, Response)  At LoggingAuditor.java:[line 268]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/28/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint xml

uname
Linux c905bc15640e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0403406d6e1e192a0a39e5b91c7f466ded845512

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/28/testReport/

Max. process+thread count
2604 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/28/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 37 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  8s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 49s

trunk passed

+1 :green_heart:
compile
22m 24s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m  0s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
4m  3s

trunk passed

+1 :green_heart:
mvnsite
2m 13s

trunk passed

-1 :x:
javadoc
0m 57s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

+1 :green_heart:
javadoc
2m  5s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 31s

trunk passed

+1 :green_heart:
shadedclient
16m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
21m 30s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
21m 30s
/results-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1956 unchanged - 1 fixed = 1957 total (was 1957)

+1 :green_heart:
compile
19m  0s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
19m  0s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1849 unchanged - 1 fixed = 1850 total (was 1850)

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
4m 23s
/results-checkstyle-root.txt
root: The patch generated 8 new + 192 unchanged - 7 fixed = 200 total (was 199)

+1 :green_heart:
mvnsite
2m 15s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 58s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

+1 :green_heart:
javadoc
1m 26s

hadoop-common in the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

+1 :green_heart:
javadoc
0m 35s

hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 0 new + 80 unchanged - 8 fixed = 80 total (was 88)

+1 :green_heart:
spotbugs
3m 50s

the patch passed

+1 :green_heart:
shadedclient
17m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m  7s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 25s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

206m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/29/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint xml

uname
Linux c77e8a29ad76 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f7c1acc3af88770e8ec20871ba896925acf6eed9

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/29/testReport/

Max. process+thread count
1236 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/29/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 18s

https://github.com/apache/hadoop/pull/2675 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/30/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 19s

https://github.com/apache/hadoop/pull/2675 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/31/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

will have to rebase. (sighs)
last version removed some of the callback from the AWS SDK related to copy as I didn't think it was needed/actually worked. it is. The transfer manager initiates its multipart copy in an executor, somehow we need to add the relevant trace data there.

[ERROR] Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.034 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.scale.ITestS3AHugeFilesDiskBlocks
[ERROR] test_100_renameHugeFile(org.apache.hadoop.fs.s3a.scale.ITestS3AHugeFilesDiskBlocks)  Time elapsed: 1.194 s  <<< ERROR!
java.nio.file.AccessDeniedException: tests3ascale/disk/hugefile: org.apache.hadoop.fs.s3a.audit.AuditFailureException: 49-00000001 unaudited operation Executing a request outside an audit span {multipart_upload_started 'tests3ascale/disk/hugefileRenamed' size=0, mutating=true}
	at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:208)
	at org.apache.hadoop.fs.s3a.Invoker.once(Invoker.java:119)
	at org.apache.hadoop.fs.s3a.Invoker.lambda$retry$4(Invoker.java:322)
	at org.apache.hadoop.fs.s3a.Invoker.retryUntranslated(Invoker.java:414)
	at org.apache.hadoop.fs.s3a.Invoker.retry(Invoker.java:318)
	at org.apache.hadoop.fs.s3a.Invoker.retry(Invoker.java:293)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.copyFile(S3AFileSystem.java:4100)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.access$1300(S3AFileSystem.java:241)
	at org.apache.hadoop.fs.s3a.S3AFileSystem$OperationCallbacksImpl.copyFile(S3AFileSystem.java:1943)
	at org.apache.hadoop.fs.s3a.impl.RenameOperation.copySourceAndUpdateTracker(RenameOperation.java:636)
	at org.apache.hadoop.fs.s3a.impl.RenameOperation.renameFileToDest(RenameOperation.java:364)
	at org.apache.hadoop.fs.s3a.impl.RenameOperation.execute(RenameOperation.java:309)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.innerRename(S3AFileSystem.java:1870)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$rename$7(S3AFileSystem.java:1717)
	at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.lambda$trackDurationOfOperation$5(IOStatisticsBinding.java:499)
	at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.trackDuration(IOStatisticsBinding.java:444)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.trackDurationAndSpan(S3AFileSystem.java:2186)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.rename(S3AFileSystem.java:1715)
	at org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles.test_100_renameHugeFile(AbstractSTestS3AHugeFiles.java:511)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.hadoop.fs.s3a.audit.AuditFailureException: 49-00000001 unaudited operation Executing a request outside an audit span {multipart_upload_started 'tests3ascale/disk/hugefileRenamed' size=0, mutating=true}
	at org.apache.hadoop.fs.s3a.audit.impl.LoggingAuditor$WarningSpan.beforeExecution(LoggingAuditor.java:386)
	at org.apache.hadoop.fs.s3a.audit.impl.ActiveAuditManager$WrappingAuditSpan.beforeExecution(ActiveAuditManager.java:394)
	at org.apache.hadoop.fs.s3a.audit.impl.ActiveAuditManager.beforeExecution(ActiveAuditManager.java:238)
	at org.apache.hadoop.fs.s3a.audit.impl.ActiveAuditManager$SdkRequestHandler.beforeExecution(ActiveAuditManager.java:277)
	at com.amazonaws.AmazonWebServiceClient.beforeClientExecution(AmazonWebServiceClient.java:787)
	at com.amazonaws.services.s3.AmazonS3Client.initiateMultipartUpload(AmazonS3Client.java:3528)
	at com.amazonaws.services.s3.transfer.internal.CopyCallable.initiateMultipartUpload(CopyCallable.java:250)
	at com.amazonaws.services.s3.transfer.internal.CopyCallable.copyInParts(CopyCallable.java:168)
	at com.amazonaws.services.s3.transfer.internal.CopyCallable.call(CopyCallable.java:130)
	at com.amazonaws.services.s3.transfer.internal.CopyMonitor.call(CopyMonitor.java:132)
	at com.amazonaws.services.s3.transfer.internal.CopyMonitor.call(CopyMonitor.java:43)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	... 1 more

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 19s

https://github.com/apache/hadoop/pull/2675 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/33/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 18s

https://github.com/apache/hadoop/pull/2675 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/2675

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2675/34/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

PR no longer applies, even with rebase. Will have to close and resubmit

See #2807 for successor PR


Make Git submodules dance

See #701 as to why.
(btw: I could be very blind, but there are no specs for *.rake files?)

coffeeaddict:git-submodules


Schedule batch tasks on opportunistic CPUs

This PR adds support for oversubscribing agent machines, and scheduling tasks onto opportunistic (underutilized) CPUs.
By default, a noop implementation of OpportunisticCpuAvailabilityProvider is used. A following PR will add support for fetching opportunistic CPUs from k8s clusters (kube api-server), when Titus is configured to run tasks on k8s.
Opportunistic CPUs are only enabled for batch jobs that include a prediction of their tasks runtime. IOW, a batch job needs to opt into opportunistic scheduling by having an attribute that hints at its runtime duration. The Titus scheduler will then match that job with opportunistic CPUs that will be available during that window.
Key aspects of this implementation

Before each scheduling loop iteration, we compute all available opportunistic CPUs, and all current usage. That information is cached for a single scheduling iteration.
Tasks requesting opportunistic CPUs can only be scheduled on machines that have opportunistic CPUs available.
We first try to schedule batch jobs with runtime predictions by allocating only opportunistic CPUs (all or none);
if it fails (say no opportunistic CPUs available on any compatible machine), we then decrement the number of requested opportunistic CPUs for the task, which increments the number of regular CPUs requested, and try again;
ultimately, if there are no compatible machines with any opportunistic CPUs available, we fall back to scheduling regularly with all "normal" CPUs.
If the above fails again, we loop back to scheduling with all opportunistic CPUs, in case more are available now, and the cycle repeats. The tradeoff is that opportunistic batch jobs can take multiple scheduling iteration cycles to be placed on a machine, but we always try to maximize opportunistic usage of CPUs.
Tasks will have metadata in their taskContext about opportunistic CPU allocation when they were scheduled opportunistically.
Other resource dimensions (memory, network, disk, ENIs, etc) are consumed and allocated normally.
Existing resource consumption metrics for CPU will only account for regular CPU usage, opportunistic CPUs will count as zero CPU consumption towards metrics and capacity groups.

Future improvements

Fitness function that binpacks opportunistic CPUs, and minimizes fragmentation
Opportunistic CPU consumption metrics
kube implementation of OpportunisticCpuAvailabilityProvider, compatible with how kubelets will emit their underutilized (opportunistic) CPU resources.

cc @jigish @gabrielhartmann @rostyboost

@tbak @corindwyer some more fixes based on reviews, and I added a feature flag to enable/disable opportunistic scheduling dynamically. It only controls the behavior inside each scheduling loop iteration, new pre-scheduling and post-scheduling hooks will always be executed regardless of the flag.
Given we have more concerns about code running in the scheduling loop for all tasks, I think this was a reasonable compromise. Thoughts?


Cleanup names

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
Just some housecleaning
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kris-nova
If they are not already assigned, you can assign the PR to them by writing /assign @kris-nova in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 469f62da5a9b307ea6c91b19cebf437eadd924be

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Define API for Carto layers order

//         BOTTOM v     v TOP
client.addLayers([A, B, C]);

// 0 < 1 < 2

A.setOrder(0); // A, B, C
A.setOrder(1); // B, A, C
A.setOrder(2); // B, C, A
A.setOrder(-1); // throw error: out of range
A.setOrder(3); // throw error: out of range

A.bringToFront(); // same as A.setOrder(<layers length>);
A.brintToBack(); // same as A.setOrder(0);

cc @csobier @alonsogarciapablo @IagoLast

LGTM!

What happens to the order of B and C when A.setOrder(0) is executed?
Why do you think A.bringToFront() and A.bringToBack will be useful?
Perhaps we can see how other libraries solve this problem.
Also, something like client.addLayer(myLayer, { at: 1 } might be useful.

What happens to the order of B and C when A.setOrder(0) is executed?

Since the order is the index, B and C will have order 1 and 2 respectively.

Why do you think A.bringToFront() and A.bringToBack will be useful?

I think these functions are more explicit and you don't need to remember the number of layers (for the bringToFront function).

Also, something like client.addLayer(myLayer, { at: 1 }) might be useful.

May be we could rename this function to client.addLayerAt(1, myLayer) (orclient.addLayerAt(myLayer, 1))

Closed by: https://github.com/CartoDB/cartodb.js/pull/2031


Reformat CTC linetype to support ROC diagram

Describe the Enhancement
The METplotpy ROC diagram uses either the PCT or CTC linetype output.  There is a reformatter for the PCT linetype, but the CTC linetype is also needed.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Projects and Milestone

[ ] Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
[ ] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Add any new Python packages to the METplus Components Python Requirements table.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issues

Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version

[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

Another format for the CTC linetype is not required. Instead, provide support in the METplotpy ROC diagram to read in this reformatted data: https://github.com/dtcenter/METplotpy/issues/424


[bug] Some planets have mass but no radius

        let mut accrete = Accrete::new();
        accrete.stellar_mass = 10000.;
        let system = accrete.planetary_system();

generates lots of planets with 0 radius but with moons and rings

@Wicpar seems like object with mass of 10000 suns should be a massive black hole - not sure if accrete can cover this, but still what a beautiful case!
From first sight it seems that 0 radius comes from kothari radius equation - i will investigate it further.


Drop-down visual element

Description
The menu visual element we have today is more like a sidebar. The purpose is to propose a drop-down menu visual element.

The drop-down should appear when clicking on an icon, label, link, etc.
Once clicked, the icon should open a drop-down menu. It should look like an opened selector visual element or like a dialog but localized near the icon and not centered.
The menu should contain a list of clickable actions that trigger a callback execution.

Examples

Acceptance Criteria

[ ] If applicable, a new demo code is provided to show the new feature in action.
[ ] Integration tests exhibiting how the functionality works are added.
[ ] Any new code is covered by a unit tested.
[ ] Check code coverage is at least 90%.
[ ] Related issue(s) in taipy-doc are created for documentation and Release Notes are updated.

Code of Conduct

[x] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

Hi team, could you assign this issue to me?

Hello @KesterTan, This issue depends on another issue, #2293, to be handled by our core maintainer team.
It cannot be implemented for now.
Thank you for your understanding.