Window frame color settings

Thanks for this port to Plasma 6 :sunglasses:
I can't get the window frame color to work for the active window vs the inactive window. Has the KDE API changed for this? In the README it still gives the same setup instructions as before:
    frame=61,174,233: set the border color of active window to RGB(61,174,233)
    inactiveFrame=239,240,241: set the border color of inactive window to RGB(239,240,241)

It was working for me on Plasma 5. I also tried setting the border size to normal in the rule for all windows but it doesn't work.
Environment

Distro: Manjaro
KWin version: 6.0.4
Krohnkite version: 0.9.1
List of KWin scripts in use: Desktop Change OSD, MinimizeAll, VideoWall, Synchornize Skip Switcher with Taskbar.

The part of readme has legacy data. Are you using kwriteconfig5 or kwriteconfig6 command? I'm personally never used this way to change the frame. I use Kde Settings->Colors and Themes->Window Decorations.

Both of them write to the same file, at least in that command. There is some thread about a bug on this issue - but I've used it successfully with dark themes (https://bugs.kde.org/show_bug.cgi?id=433761)
Is there a way to set the frame (border) color of the active window through Settings? The most I can do in Window Decorations is change the shadow color. (I have the rule that deletes the title bar for all windows)

I personally use klassy, and it works perfectly for me.

Is there a way to set the frame (border) color of the active window through Settings?

Oxygen decoration ..?
Screencast_20240603_081757.webm

Cool! I'll check it out, meanwhile here's my KDE5 setup with the frame coloring and no side borders of windows.

You can also use KDE-Rounded-Corners to color your borders and to change the border radius. It can add borders to active and inactive windows and it's pretty much the easiest way to change border colors currently.

Someone has also ported the Bismuth window decoration to Kwin 6: https://github.com/ivan-cukic/kwin6-bismuth-decoration

Thanks for all the recommendations - at the end I'm using Oxygen as @anametologin suggested with Inner Color only and no shadow. The others were a bit too involved as they couldn't be installed from the Settings window.

It's a bit too glowy (throwback to the KDE 4 spaceship days :sweat_smile: ) but it does the trick :+1:

It would be nice to ask the devs at KDE what is the new setting name for the frame color - I couldn't find a way to raise an issue or join a discussion forum.

Did you try to open a thread on discuss.kde.org → Development?
We could also ask on Matrix: there's a room for Kwin in KDE's space.

I didn't - can you post it if you have an account?

I tried but unfortunately I'm not so sure about what you want to ask; I suggest you create an account on discuss.kde.org

i came here to suggest coloured frames around focused window and was excited to see all these options in comments. Sadly i havent managed to get any of these to work. it would be really great if the option was built into the Krohnkite settings.

having the ugly full title bar and maximise / close buttons visable

Breeze decoration example:

Window-Specific Overrides tab-> Add
Regular expression to match: .*
Ok

Breeze decoration example:

Window-Specific Overrides tab-> Add
Regular expression to match: .*
Ok

thank you so much for taking the time to show me that, i appreciate it very much! I have it working exactly as intended now by applying the steps you provided on the Oxygen theme.
just want to also say thanks for the excellent work!

Hello! My easiest solution while keeping the Breeze (Classic, dark or Light) golbal themes applied is this. Works perfectly fine without window titles (as detailed on the readme's "Removing Title Bars" section) and you may also easily adjust the windows decorations border size.
I did try some of the other documented and above settings to change the border colours but thses are the ones that work best for me, while keeping the Breeze themes working fine and not requiring to install any other themes/scripts or whatever. Hope this helps everyone!

Great tip - thanks!
This does change the theme though, but you can use the default accent for the frames. I couldn't get turn off the side borders, even with "No side borders" in "Window Decorations", did you manage to do it?

Hi @gerazov! Yes, technically with "No Window Side Borders" the border sides are in fact removed. You still get a 1px wide accent-coloured side highlight - but that's the window outline (not a border) - which is typically "light grey" coloured when focused on the Breeze theme. I guess the focused "window title-bars accent-coloured" option includes the title bar, the header/menu bar and the window outline. Example:

To remove it you need to edit the themes "Window Decorations" and change the "Shadows and Outline" settings and turn off the "Outline intensity". Example:

This should help you get the desired result.

Enable Title Bar in Firefox:
☰ => More tools => Customize tools => Title bar check box at the bottom left

@anametologin Nice tip! Similarly for Thunderbird:
Settings > General > Language & Appearance > Hide system window titlebar (uncheck)

And similarly for Google Chrome or Chromium:
Settings > Appearance > Use system title bar and borders (enable)

Great! Thanks a ton :pray:

For Gentoo users, here is a simple patch to change the Breeze outlineColor to blue (#3daee9). Just save it in /etc/portage/patches/kde-plasma/breeze/custom-active-window-outline.patch and emerge breeze:
diff --git a/kdecoration/breezedecoration.cpp b/kdecoration/breezedecoration.cpp
index 22451a5..448e0e0 100644
--- a/kdecoration/breezedecoration.cpp
+++ b/kdecoration/breezedecoration.cpp
@@ -600,9 +600,8 @@ void Decoration::paint(QPainter *painter, const QRect &repaintRegion)
         painter->restore();
     }
     if (outlinesEnabled() && !isMaximized()) {
-        auto outlineColor = KColorUtils::mix(c->color(c->isActive() ? ColorGroup::Active : ColorGroup::Inactive, ColorRole::Frame),
-                                             c->palette().text().color(),
-                                             lookupOutlineIntensity(m_internalSettings->outlineIntensity()));
+        // outlineColor active to blue
+        auto outlineColor = c->isActive() ? QColor(61, 174, 233) : KColorUtils::mix(c->color(ColorGroup::Inactive, ColorRole::Frame), c->palette().text().color(), lookupOutlineIntensity(m_internalSettings->outlineIntensity()));

         QRectF outlineRect = rect();
         qreal cornerSize = m_scaledCornerRadius * 2.0;
@@ -627,7 +626,7 @@ void Decoration::paint(QPainter *painter, const QRect &repaintRegion)

         painter->fillPath(outlinePath.simplified(), Qt::transparent);
         painter->save();
-        painter->setPen(QPen(outlineColor, 2));
+        painter->setPen(QPen(outlineColor, 3));
         painter->setBrush(Qt::NoBrush);
         painter->setRenderHint(QPainter::Antialiasing);
         painter->setCompositionMode(QPainter::CompositionMode_SourceAtop);

Is there a way to set the frame (border) color of the active window through Settings?

Oxygen decoration ...? 1.webm

Is it part of a downloadable global theme? I seem to have the style but not the decoration (Plasma 6.1.5 on OpenSuse Tumbleweed)

:point_up: @frandmb Yes, I also didn't find the Oxygen Global theme anywhere, doesn't seem to be avalable or distributed anymore. I would suggest using my easiest/recommended solution using the default Breeze (Classic, Dark or Light) global themes. Works perfectly fine without window titles (as detailed on the readme's "Removing Title Bars" section) and you may also easily adjust the windows decorations border size.


Pocket Fails to Reconnect to Coordinator

It appears to be a sequence number problem.

sv_connect was consuming the watchdog timer events (and pocket comms packets). apisessions watchdogs and all comms are handled now while reconnecting with the supervisor.


Correct copyright info in README

Signed-off-by: Darius Alix-Williams<EMAIL_ADDRESS>

Correct typo in copyright information


Add the field "CapacityReservationID" to "AwsMachineProviderConfig"

This PR adds the support of capacity reservation in AwsMachineProviderConfig. A new field, CapacityReservationID, is added. This ID is used while creating the corresponding AWS EC2 instance and the instance is added to the capacity reservation.

/cc @mandre @bparees

/lgtm
/ok-to-test


Key Management

For example, Virtual Machines or Containers that leverage encrypted storage volumes often require
additional operational components to provide pre-boot authentication and/or HSM services for
decryption operations. The key hierarchy and lifecycle within the CC in the Cloud use case are of
additional concern in this threat model.

Change implemented.


Feature_Request adding the cotributors profile in the about us page

Is your feature request related to a problem? Please describe.

in the about us page their is give the Details about the project
i want to add the contributors profile on the About us page where the others can see the the contributors of the project
Describe the solution you'd like

Describe alternatives you've considered

Additional context (Mandatory )
Are you contributing under any open-source program ?

i want to work on this issue please assign m this issue

@CoderSwarup you are assigned.

@CoderSwarup you are assigned.

Ok


fix: 2965 Correct Parsing Logic for Qualitative Instance Level SR

Fix for https://github.com/OHIF/Viewers/issues/2965
Explanation below:
Qualitative slice-level SR annotations are within the Measurement Group container, which is obtained through https://github.com/OHIF/Viewers/blob/7aba01f534b70406ce02e1708004141c7b773904/platform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js#L31
This particular dataset did not have any ImageLibrary, hence getReferenceImagesList() was throwing errors.
I modified platform/core/src/DICOMSR/SCOORD3D/utils/getReferencedImagesList.js as it should not look for CodeValue from ImagingMeasurements.

I second @sedghi - @GitanjaliChhetri can you please summarize what this PR is doing and why?

Updated the description to explain the fix,

@GitanjaliChhetri can you please include specific SR samples that you are using to guide the development in this PR and test the revised code?

I let @igoroctaviano review first

@GitanjaliChhetri can you please include specific SR samples that you are using to guide the development in this PR and test the revised code?
Included in my response.

Reference images are not required for slice level annotations, moreover it wasn't used anywhere in the code.

What do you mean by "reference images" here?
I think 'referencedImages' at https://github.com/OHIF/Viewers/blob/7aba01f534b70406ce02e1708004141c7b773904/platform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js#L30 is a slightly confusing object name because this object is returned from the Image Library Container within the TID 1600 template.
This is not the IMAGE content item within the Measurement group container.

I reverted his changes from platform/core/src/DICOMSR/SCOORD3D/utils/getReferencedImagesList.js as it should not look for CodeValue from ImagingMeasurements.

I am not sure I understand what this means either ("as it should not look for CodeValue from ImagingMeasurements").

I meant that while searching the SR content tree for the Image Library Container, we should not be looking into the of Imaging Measurements container. Hence I reverted that portion of the fix.


ini file save same key for multiple times.

It would looks like this if I save ini file for two times.
[Group]
whitelist = false
whitelist  = false
code = false
code = false

Please provide source code for duplicating problem.


[Wiki] updated setup guide for Eclipse

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the [contributing guidelines][contributing].

Changes

[ ] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[x] Other: Wiki

Closes Issue: NaN
Description
This pr adds various images for the project setup wiki page on eclipse (2020-12).
As I'm unable to properly pr the changes for the wiki page I just placed it on hastebin
Not a lot has changed for the setup process in general so I mostly changed the config snippets to match what JDA-Butler returns  and added some new images to make following along easier.

Unfortunately, it appears that the hastebin is empty

Unfortunately, it appears that the hastebin is empty

It worked yesterday. hastebin.com is extremely wanky and sometimes like to die or not load stuff, which is why people stick with either hasteb.in or any other selfhosted option.

Unfortunately, it appears that the hastebin is empty

see the updated link

Yea using hastebin wasnt a great idea but I did not expect it to disappear in less than 24 hours.
Thanks for the edit Minn :)


Certificate for subdomain with minus sign not added via Webfaction API

Hello,
I faced situation for domain such as zh-hans.xxxyyyy.net ended up with error:
/usr/local/lib/ruby22/ruby/2.2.0/xmlrpc/client.rb:271:in `call': [u'Value must be alphanumeric only'] (XMLRPC::FaultException)
	from /home/user/.letsencrypt_webfaction/gems/gems/letsencrypt_webfaction-2.2.1/lib/letsencrypt_webfaction/webfaction_api_credentials.rb:20:in `call'
	from /home/user/.letsencrypt_webfaction/gems/gems/letsencrypt_webfaction-2.2.1/lib/letsencrypt_webfaction/certificate_installer.rb:20:in `install!'
	from /home/user/.letsencrypt_webfaction/gems/gems/letsencrypt_webfaction-2.2.1/lib/letsencrypt_webfaction/application.rb:32:in `run!'
	from /home/user/.letsencrypt_webfaction/gems/gems/letsencrypt_webfaction-2.2.1/exe/letsencrypt_webfaction:5:in `<top (required)>'
	from /home/user/.letsencrypt_webfaction/gems/bin/letsencrypt_webfaction:23:in `load'
	from /home/user/.letsencrypt_webfaction/gems/bin/letsencrypt_webfaction:23:in `<main>'

Is it a bug, api limitation or anything else?

Finally resolved with help of support:  --cert_name may not contain spaces, but somehow it affects only domain names with dash.

Could you expand on what you mean by it only affects domain names with a dash? Could you give me an example? That sounds like a bug.

It is simple - I had few lang subdomains such as ru.mydomain.net, en.mydomain.net, ... One of those was zh-hans.mydomian.net. I ran the script and after awhile I got error above. I suggested that dash was the reason as previously tested script with another group of subdomains without error. When I removed dash I got a warning that cert for zhhans.mydomain.net was not issued which it correct as I don't have one on my list but for the others cert was supplied. I opened a ticket and support suggested that --cert-name may be an issue - I had spaces on my --cert-name, so I replaced spaces with underscore and got cert even for zh-hans.mydomain.net without a complain. I was puzzled how --cert-name related to name of subdomain but I have no time to look Ruby code myself and finally I got cert for everything I needed.


Batch due check

closes #18
rebase and merge after #19

Codecov Report

Merging #21 (a174bc4) into main (46e2160) will increase coverage by 0.19%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   93.49%   93.69%   +0.19%
==========================================
  Files           7        8       +1
  Lines         523      539      +16
==========================================
+ Hits          489      505      +16
  Misses         18       18
  Partials       16       16

Impacted Files
Coverage Δ

batch.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


duplicate point removal not applicable to all file types

Duplicate point removal is only applied to HDF5 files. The reason for this is that by construction this format has duplicate points between adjoining sections. However, it would make sense to have a uniform treatment of data, where duplicate points can be removed optionally regardless of data format.
See related issue #177.

Closing this as it stems from a misunderstanding.


Base module unit tests

Refactored ManyServer unit tests as well
Tests will be refactored again when Account PR is merged

Closing. See mockall version instead.


OP should transmit HCA_01 at 10Hz when not steering

The factory LKAS camera transmits the CAN message HCA_01 at 50Hz when steering, and 10Hz when not. OP currently transmits at 50Hz all the time. This may or may not be having an ill effect, but there are sometimes issues with OP commanded torque not being applied for a few seconds after engagement, and we should match stock behavior if at all possible.

Just a historical note: the "bug" with torque not being applied after engagement turns out to be an OP "feature" wherein actuators.steer is suppressed until gas pedal input is zero, so no steering happens until you release the gas pedal. However, keeping this open as it would be nice to emulate stock sending rate behavior for other reasons.

Tested as workable, but creates problems in Cabana right now, and would require more extensive work to make truly correct. We also don't get any functionality out of it. Reclassifying as later enhancement.

Have decided there's no percentage in "fixing" this, closing.


BUG - CPE UI does not update when changes are created or deleted

Description
When you make some changes in the application and click the save icon, the CPE saved changes (left bottom corner) panel does not update accordingly. Or if you delete a change/s they are not removed in the UI (only removed from the project's workspace), and to see the changes you need to refresh the browser.
Steps to Reproduce
Steps to reproduce the behavior:
Scenario 1:

Open a Fiori or an Adaptation Project and start the editor
Make some changes and click save
The saved changes are not updated

Scenario 2:

Open a Fiori or an Adaptation Project and start the editor
Delete a change
The saved changes are not updated

Expected results
The UI is updated when saving or deleting changes.
Actual results
UI is not updated.
Version/Components/Environment
Add any other context about the problem here
OS:

[X] Mac OS
[X] Windows
[ ] Other

Root Cause Analysis
Problem
The UI is not updated when saving or deleting changes.
Fix
Refetches saved changes from the workspace each time a file is saved or deleted to update the Saved Changes panel in the UI.

Fix merged: #1443.


Eagerly move attachable values to the heap.

This PR modifies Test.Attachment.init(...) so that, if the attachable value passed to it is of a large or non-bitwise-copyable value type, we store it in a heap-allocated container object.
Why do we want to do this? Attachable values have arbitrary types we don't really know anything about, and may be very expensive to copy if they are large or if they contain many references to other objects. Since attachments are sendable and need to pass through many layers in the system, the cost of making copies for these attachable values can add up quickly. So, instead of copying them repeatedly, if we store them in a refcounted container and pass that value around, we only infer a single copy cost.
There are four modes for attachable value storage after this PR:
flowchart TB;
    S@{ shape: diam, label: "Sendable?" };
    C@{ shape: diam, label: "Copyable?" };
    AO@{ shape: diam, label: "AnyObject?" };
    BC@{ shape: diam, label: "BitwiseCopyable (POD)?" };
    SMOL@{ shape: diam, label: "Fits in an existential box?" };

    MO@{ shape: das, label: "In a heap-allocated box\n(eagerly serialized)" };
    EX@{ shape: das,  label: "Inline in an existential box" };
    H@{ shape: das,  label: "In a heap-allocated box" };
    RC@{ shape: das,  label: "Directly on the heap" };

    S-- Yes ---C
        C-- Yes ---AO
            AO-- Yes ---RC
            AO-- No ---BC
                BC-- Yes ---SMOL
                BC-- No ---H
                    SMOL-- Yes ---EX
                    SMOL-- No ---H
        C-- No ---MO
    S-- No ---MO

Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci test

Ahh… interesting! Something on a similar topic I was investigating was the impact that migrating from pass-by-value (for large data structures) to pass-by-reference would have on binary size. This might not be so critical for test code (makes a bigger impact for production code)… but was there any attempt to benchmark or test for binary size impact or compile time improvements from reducing the amount of code swift-testing has to generate behind the scenes to pass very complex value types?

I would not expect this change to affect the binary size of test code in any statistically significant way. Swift Testing is built with library evolution enabled, so the internal _HeapAllocatedAttachableProxy class is not visible to client code.
For embedded targets (which we do not support yet), attachments will probably always be eagerly serialized and this class won't be necessary.

Swift Testing is built with library evolution enabled, so the internal _HeapAllocatedAttachableProxy class is not visible to client code. Client code therefore cannot optimize based on whether or not it's used, nor can it create static specializations of the class that are emitted into any binaries.

https://forums.swift.org/t/what-does-island-suffix-in-symbol-name-mean/73105
Hmm… what I was investigating was if (accounting for the small increase in instructions and binary size from code landed in this diff to support heap boxing) we could still see a net negative reduction in binary size when product engineers build their test code… if the product engineer was previously attempting to pass-by-value very large data structures and the amount of code Swift generated behind the scenes to pass those very large data structures was no longer necessary.
It's not a high-priority blocker for me… but something I was trying to investigate and if there was any more potential insight from what was just shipped here that would be great!

I would be genuinely surprised if this has any non-negligible impact on the size of production binaries or test binaries when Swift Testing is used from the toolchain or Xcode.


NotADirectoryError: [Errno 20] Not a directory: '/home/kevin/name/HTRPN-main/fsdet/model_zoo/configs'

请问你解决了吗

我也遇到同样的问题 请问你解决了嘛

https://blog.csdn.net/qiankendeNMY/article/details/128450196?spm=1001.2014.3001.5502
参考这篇博文，重新对框架做链接

Thanks for your comments, just delete "configs" file and rerun the installation code, then you are good to go. Though I'll fix this problem soon. :)


fix: "isExcludeFile" will is NOT right in large project

when there are tons of file, Declaration's file path will be NOT same with Once's file path,the excluded files with be convert from px to rem TOO
fix issue #101

your pr should not modify package.json without any deps changed

#110


[BUG] Centos still doesn't work on Vagrant

Recently, a following line was added to Vagrantfile:
   "centos"        => {box: "bento/centos-7.3",   bootstrap_os: "centos", user: "vagrant"},

Now, it should be as simple as changing $os = "centos" but it doesn,t work, see below.
Environment:

laptop

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):
Ubuntu 16.04

Version of Ansible (ansible --version):
2.3

*Kubespray version (commit) (git rev-parse --short HEAD):
lastest
Network plugin used:
Command used to invoke ansible:
vagrant up
Output of ansible run:
sokoow@sokoow-ThinkPad-X230 ~/Desktop/GIT/kubespray $ vagrant up
Bringing machine 'k8s-01' up with 'virtualbox' provider...
Bringing machine 'k8s-02' up with 'virtualbox' provider...
Bringing machine 'k8s-03' up with 'virtualbox' provider...
==> k8s-01: Importing base box 'bento/centos-7.3'...
==> k8s-01: Matching MAC address for NAT networking...
==> k8s-01: Checking if box 'bento/centos-7.3' is up to date...
==> k8s-01: Setting the name of the VM: kubespray_k8s-01_1503235288246_59242
==> k8s-01: Clearing any previously set network interfaces...
==> k8s-01: Preparing network interfaces based on configuration...
    k8s-01: Adapter 1: nat
    k8s-01: Adapter 2: hostonly
==> k8s-01: Forwarding ports...
    k8s-01: 22 (guest) => 2222 (host) (adapter 1)
==> k8s-01: Running 'pre-boot' VM customizations...
==> k8s-01: Booting VM...
==> k8s-01: Waiting for machine to boot. This may take a few minutes...
    k8s-01: SSH address: <IP_ADDRESS>:2222
    k8s-01: SSH username: vagrant
    k8s-01: SSH auth method: private key
    k8s-01: Warning: Remote connection disconnect. Retrying...
    k8s-01: Warning: Remote connection disconnect. Retrying...
    k8s-01: Warning: Remote connection disconnect. Retrying...
==> k8s-01: Machine booted and ready!
==> k8s-01: Checking for guest additions in VM...
    k8s-01: The guest additions on this VM do not match the installed version of
    k8s-01: VirtualBox! In most cases this is fine, but in rare cases it can
    k8s-01: prevent things such as shared folders from working properly. If you see
    k8s-01: shared folder errors, please make sure the guest additions within the
    k8s-01: virtual machine match the version of VirtualBox you have installed on
    k8s-01: your host and reload your VM.
    k8s-01:
    k8s-01: Guest Additions Version: 5.1.24
    k8s-01: VirtualBox Version: 5.0
==> k8s-01: Setting hostname...
==> k8s-01: Configuring and enabling network interfaces...
==> k8s-01: Mounting shared folders...
    k8s-01: /vagrant => /home/sokoow/Desktop/GIT/kubespray
==> k8s-02: Importing base box 'bento/centos-7.3'...
==> k8s-02: Matching MAC address for NAT networking...
==> k8s-02: Checking if box 'bento/centos-7.3' is up to date...
==> k8s-02: Setting the name of the VM: kubespray_k8s-02_1503235388231_26907
==> k8s-02: Fixed port collision for 22 => 2222. Now on port 2200.
==> k8s-02: Clearing any previously set network interfaces...
==> k8s-02: Preparing network interfaces based on configuration...
    k8s-02: Adapter 1: nat
    k8s-02: Adapter 2: hostonly
==> k8s-02: Forwarding ports...
    k8s-02: 22 (guest) => 2200 (host) (adapter 1)
==> k8s-02: Running 'pre-boot' VM customizations...
==> k8s-02: Booting VM...
==> k8s-02: Waiting for machine to boot. This may take a few minutes...
    k8s-02: SSH address: <IP_ADDRESS>:2200
    k8s-02: SSH username: vagrant
    k8s-02: SSH auth method: private key
    k8s-02: Warning: Remote connection disconnect. Retrying...
    k8s-02: Warning: Remote connection disconnect. Retrying...
    k8s-02: Warning: Remote connection disconnect. Retrying...
==> k8s-02: Machine booted and ready!
==> k8s-02: Checking for guest additions in VM...
    k8s-02: The guest additions on this VM do not match the installed version of
    k8s-02: VirtualBox! In most cases this is fine, but in rare cases it can
    k8s-02: prevent things such as shared folders from working properly. If you see
    k8s-02: shared folder errors, please make sure the guest additions within the
    k8s-02: virtual machine match the version of VirtualBox you have installed on
    k8s-02: your host and reload your VM.
    k8s-02:
    k8s-02: Guest Additions Version: 5.1.24
    k8s-02: VirtualBox Version: 5.0
==> k8s-02: Setting hostname...
==> k8s-02: Configuring and enabling network interfaces...
==> k8s-02: Mounting shared folders...
    k8s-02: /vagrant => /home/sokoow/Desktop/GIT/kubespray
==> k8s-03: Importing base box 'bento/centos-7.3'...
==> k8s-03: Matching MAC address for NAT networking...
==> k8s-03: Checking if box 'bento/centos-7.3' is up to date...
==> k8s-03: Setting the name of the VM: kubespray_k8s-03_1503235481105_68747
==> k8s-03: Fixed port collision for 22 => 2222. Now on port 2201.
==> k8s-03: Clearing any previously set network interfaces...
==> k8s-03: Preparing network interfaces based on configuration...
    k8s-03: Adapter 1: nat
    k8s-03: Adapter 2: hostonly
==> k8s-03: Forwarding ports...
    k8s-03: 22 (guest) => 2201 (host) (adapter 1)
==> k8s-03: Running 'pre-boot' VM customizations...
==> k8s-03: Booting VM...
==> k8s-03: Waiting for machine to boot. This may take a few minutes...
    k8s-03: SSH address: <IP_ADDRESS>:2201
    k8s-03: SSH username: vagrant
    k8s-03: SSH auth method: private key
    k8s-03: Warning: Remote connection disconnect. Retrying...
    k8s-03: Warning: Remote connection disconnect. Retrying...
    k8s-03: Warning: Remote connection disconnect. Retrying...
==> k8s-03: Machine booted and ready!
==> k8s-03: Checking for guest additions in VM...
    k8s-03: The guest additions on this VM do not match the installed version of
    k8s-03: VirtualBox! In most cases this is fine, but in rare cases it can
    k8s-03: prevent things such as shared folders from working properly. If you see
    k8s-03: shared folder errors, please make sure the guest additions within the
    k8s-03: virtual machine match the version of VirtualBox you have installed on
    k8s-03: your host and reload your VM.
    k8s-03:
    k8s-03: Guest Additions Version: 5.1.24
    k8s-03: VirtualBox Version: 5.0
==> k8s-03: Setting hostname...
==> k8s-03: Configuring and enabling network interfaces...
==> k8s-03: Mounting shared folders...
    k8s-03: /vagrant => /home/sokoow/Desktop/GIT/kubespray
==> k8s-03: Running provisioner: ansible...
==> k8s-03: Vagrant has detected a host range pattern in the `groups` option.
==> k8s-03: Vagrant doesn't fully check the validity of these parameters!
==> k8s-03:
==> k8s-03: Please check https://docs.ansible.com/ansible/intro_inventory.html#hosts-and-groups
==> k8s-03: for more information.
    k8s-03: Running ansible-playbook...
ERROR! 'check_mode' is not a valid attribute for a Task

The error appears to have been in '/home/sokoow/Desktop/GIT/kubespray/roles/bootstrap-os/tasks/bootstrap-coreos.yml': line 16, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

- name: Bootstrap | Check if we need to install pip
  ^ here

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

Just to make sure, I also tried to the centos, but installation process can be performed successfully. My environment looks like you, detail as below:
$ cat /etc/os-release
NAME="Ubuntu"
VERSION="16.04.2 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.2 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

$ ansible <IP_ADDRESS>
  config file = /home/kylebai/kubespray/ansible.cfg
  configured module search path = [u'./library']
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]

$ vagrant up
...
PLAY RECAP *********************************************************************
k8s-01                     : ok=392  changed=109  unreachable=0    failed=0
k8s-02                     : ok=366  changed=102  unreachable=0    failed=0
k8s-03                     : ok=332  changed=90   unreachable=0    failed=0

Tuesday 22 August 2017  17:08:18 +0800 (0:00:00.013)       0:09:09.393 ********

$ vagrant ssh k8s-01
Last login: Tue Aug 22 17:22:18 2017 from <IP_ADDRESS>
[vagrant@k8s-01 ~]$ kubectl get no
2017-08-22 09:21:54.042358 I | proto: duplicate proto type registered: google.protobuf.Any
2017-08-22 09:21:54.042452 I | proto: duplicate proto type registered: google.protobuf.Duration
2017-08-22 09:21:54.042462 I | proto: duplicate proto type registered: google.protobuf.Timestamp
NAME      STATUS    AGE       VERSION
k8s-01    Ready     14m       v1.7.3+coreos.0
k8s-02    Ready     14m       v1.7.3+coreos.0
k8s-03    Ready     14m       v1.7.3+coreos.0

Last commit as below(master branch):
commit e91c04f586907d44d98ab88df4d4182155a45c4c
Merge: ca3050e 277fa6c
Author: Bogdan Dobrelya<EMAIL_ADDRESS>Date:   Mon Aug 21 11:42:23 2017 +0200

use upstream code base, to isntall k8s on centos, it report not found docker

@xiaods, can you provide ansible output for more details?
@sokoow  ERROR! 'check_mode' is not a valid attribute for a Task could happen if you using ansible < 2.2. Try upgrade ansible to 2.3.0 if the error remains


Enable postponed evaluation and upgrade typehints

Oh, I initially forgot about tests. When I upgraded tests as well, many failed.
Mostly because starlite currently doesn't work with ForwardRefs at all.

So @Bobronium . I like you take initiative, but I don't understand the reasoning for this PR. Why would we want to do this? We will eventually update our syntax when we only support v3.10+ .

This IMO improves readability and requires less effort to write annotations.
I don't see what holding us back from using the new syntax inside the library since it's compatible with python 3.7+ when enabling postponed evaluation for typehints. Locally all tests have passed.
CI presumably fails because of a bug in pydantic that I haven't yet looked into much.
As for why I opened PR instead of an issue/discussion: save time and effort. These changes were mostly done automatically, so I'm ok with throwing this PR away :)

Aight. Lets close this for now.

Sure. Could you tell why though?

Sure. Could you tell why though?

I think its an unnecessary change - its syntactic sugar. And - python 3.11 will not include postponed evaluation is originally intended, see<EMAIL_ADDRESS>


Better pump refresh loop

CGM loop refreshing CGM
•	Current cgm-loop works well
NS and AMA loop
•	If temptargets.json is older than 1m, refresh it
•	If carbhistory.json is older than 1m, refresh it and meal.json
•	If glucose.json is newer than meal.json, refresh meal.json
•	If suggested.json is newer than upload/ns-status.json, upload-ns-status
•	Upload-latest-treatments (already checks whether anything is new)
Pump loop refreshing pump data
•	Wait-for-silence (15s)
•	&& if pumphistory.json is older than 30m, refresh it
•	&& if profile.json is older than 30m or invalid, refresh settings
•	&& if temp_basal.json is older than 1m or older than glucose.json, refresh it && enact
•	&& if pumphistory.json is older than 5m, refresh it && enact && refresh temp_basal.json
•	&& if profile.json is older than 15m, refresh settings
•	&& if pumphistory-24h.json is older than 15m, refresh it
•	If any of the above fails:
o	Wait-for-silence
o	Mmtune
o	Repeat from the top
autosens loop
•	If pumphistory-24h.json is newer than autosens.json, refresh it

Completed in https://github.com/scottleibrand/openaps-sh/tree/refresh-loops


Kim/fix weight method

2 unit tests are failing could you please check that after your exam @tim

Hello @Karim-53! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pdll/_pairwise.py:

Line 342:80: E501 line too long (81 > 79 characters)
Line 344:80: E501 line too long (84 > 79 characters)
Line 346:80: E501 line too long (101 > 79 characters)
Line 347:80: E501 line too long (81 > 79 characters)
Line 509:80: E501 line too long (127 > 79 characters)
Line 513:80: E501 line too long (90 > 79 characters)
Line 514:80: E501 line too long (82 > 79 characters)
Line 584:80: E501 line too long (84 > 79 characters)
Line 589:80: E501 line too long (174 > 79 characters)
Line 593:80: E501 line too long (80 > 79 characters)
Line 602:80: E501 line too long (95 > 79 characters)
Line 604:80: E501 line too long (89 > 79 characters)
Line 612:80: E501 line too long (143 > 79 characters)
Line 619:80: E501 line too long (121 > 79 characters)
Line 629:80: E501 line too long (205 > 79 characters)
Line 636:80: E501 line too long (142 > 79 characters)
Line 641:80: E501 line too long (91 > 79 characters)
Line 645:80: E501 line too long (107 > 79 characters)
Line 648:80: E501 line too long (90 > 79 characters)
Line 655:80: E501 line too long (83 > 79 characters)
Line 664:80: E501 line too long (101 > 79 characters)
Line 669:80: E501 line too long (105 > 79 characters)
Line 675:80: E501 line too long (106 > 79 characters)
Line 676:80: E501 line too long (109 > 79 characters)
Line 696:80: E501 line too long (138 > 79 characters)
Line 707:80: E501 line too long (101 > 79 characters)
Line 708:80: E501 line too long (95 > 79 characters)
Line 710:80: E501 line too long (91 > 79 characters)
Line 715:80: E501 line too long (120 > 79 characters)
Line 730:80: E501 line too long (86 > 79 characters)

In the file tests/weighted_PDR_unit_test.py:

Line 12:80: E501 line too long (96 > 79 characters)
Line 17:80: E501 line too long (110 > 79 characters)
Line 22:80: E501 line too long (83 > 79 characters)
Line 25:80: E501 line too long (83 > 79 characters)
Line 52:80: E501 line too long (81 > 79 characters)
Line 69:80: E501 line too long (81 > 79 characters)
Line 85:80: E501 line too long (81 > 79 characters)
Line 93:80: E501 line too long (87 > 79 characters)
Line 103:80: E501 line too long (84 > 79 characters)
Line 119:80: E501 line too long (81 > 79 characters)
Line 124:80: E501 line too long (81 > 79 characters)
Line 129:80: E501 line too long (81 > 79 characters)
Line 134:80: E501 line too long (82 > 79 characters)
Line 139:80: E501 line too long (81 > 79 characters)
Line 144:80: E501 line too long (81 > 79 characters)
Line 149:80: E501 line too long (80 > 79 characters)
Line 154:80: E501 line too long (80 > 79 characters)
Line 157:80: E501 line too long (168 > 79 characters)
Line 158:80: E501 line too long (168 > 79 characters)
Line 159:80: E501 line too long (166 > 79 characters)
Line 160:80: E501 line too long (152 > 79 characters)
Line 161:80: E501 line too long (139 > 79 characters)
Line 161:120: E231 missing whitespace after ','
Line 166:80: E501 line too long (80 > 79 characters)


[VT-15] vit; obsures task error messages on startup

David Patrick on 2013-10-05T04:10:16Z says:
If task can't start, because of misconfigured .taskrc (for example) vit can't start either.
The bug here is not how vit will start, but how it fails to provide a clue why, even though task is usually issuing a clear error message (that you never see).

Migrated metadata:
Created: 2013-10-05T04:10:16Z
Modified: 2014-02-09T01:16:50Z


revisit update_imported_docs, link processing, kubectl

This is a Bug Report

Problem:

Determine if the update_imported_docs script can correctly update or create new links for the kubectl component reference doc.
The documentation for building the component reference pages may be outdated.

Proposed Solution:

Revise the script as needed.
Update the documentation for building the component reference pages.

Page to Update:
Refer to:
https://kubernetes.io/docs/reference/kubectl/kubectl/#see-also
https://kubernetes.io/docs/contribute/generate-ref-docs/kubernetes-components/

/priority backlog

/assign

Should be corrected now.
/close


Separate nodeSelectors for non vizier-pem pods

Is your feature request related to a problem? Please describe.
Pixie deploys various pods like vizier-query broker, vizier cloud connector, kelvin and vizier-pem.
When we try to add nodeSelector for these pods using values defined here , it also selected the node pool for vizier-pem and that actually disable the function of vizier-pem to run on all nodes in cluster.
Pem already has pre-defined value for memory i.e. pemMemoryRequest and pemMemoryLimit
Describe the solution you'd like
nodeSelector should only work for pods that dont require to run on all nodes like query broker or kelvin.
Vizier-pem should have separate resource blocks. Rather if we can have separate defination for each deployments then it will help to customise in a better way for users.
Describe alternatives you've considered
No alternatives available
Additional context
NA

@ashutoshrathore gave this a try once #1887 was merged. While this fixed the issues with the DaemonSet pods, the expected behaviors was to be able to control the scheduling of the OLM and operator pods as well. #1913 implements this by adding two new node selector configuration options in the helm chart.


Issue with Vue config keyCode aliases and triggering keydown events

Version
1.0.0-beta.29
Reproduction link
https://github.com/tbcorr/vue-test-utils-issue
Steps to reproduce
Run the unit tests and look at the failing tests.
What is expected?
I would expect keydown event handlers bound to specific keyCode aliases would only be called when the specific key is pressed.
What is actually happening?
It appears that keydown event handlers bound to keydown events with custom keyCode aliases are being called for all keydown events, regardless of the key which triggered the event.

I'm not sure if this is only related to triggering keydown events. It just so happens I noticed this issue while testing keydown events. I'm also not sure if this is only related to the keys I was testing which are Home, End, Page Up, Page Down. Also, in browser I get the expected behavior which makes me think this is related to vue-test-utils.

This seems to be working with me.
import { shallowMount } from '@vue/test-utils';
import App from '@/App';

describe('App', () => {
  describe('when pressing the home key', () => {
    let wrapper;

    beforeAll(() => {
      wrapper = shallowMount(App);

      wrapper.find('.keys').trigger('keydown', {
        key: 'home',
      });
    });

    it('should update homePressed', () => {
      expect(wrapper.vm.homePressed).toBe(true);
    });

    it('should not update endPressed', () => {
      expect(wrapper.vm.endPressed).toBe(false);
    });

    it('should not update upPressed', () => {
      expect(wrapper.vm.upPressed).toBe(false);
    });

    it('should not update downPressed', () => {
      expect(wrapper.vm.downPressed).toBe(false);
    });

    it('should not update pageUpPressed', () => {
      expect(wrapper.vm.pageUpPressed).toBe(false);
    });

    it('should not update pageDownPressed', () => {
      expect(wrapper.vm.pageUpPressed).toBe(false);
    });
  });
});

I also noticed that supplying key code doesn't work.

@aholzner thanks for the comment! I modified my tests to to match how you triggered the keydown event and my tests are now passing, which is great!
I guess the issue only manifests when using the vue-test-utils key aliases vs specifying the key in the event options.

@tbcorr Awesome! 👍

I am still running into this issue in v1.0.3. @tbcorr reproduction link is very useful and for me the tests are still failing. This workaround works for @keydown.home but not for @keydown.left, @keydown.right, @keydown.up, @keydown.down. Also using keyCode described here doesn't work.
Can we consider re-opening this issue? Thanks!

I simplified the example to just the up key here: https://github.com/phegman/vue-test-utils-issue
As you will see I have tried trigger("keydown.up"), trigger("keydown", {keyCode: 38}), and `trigger("keydown", {key: "up"}) and neither of them work 😢

Use "key" instead

@dobromir-hristov ahhhh okay, trigger("keydown", {key: "ArrowUp"}) works! 🎉  Thanks!
I still think it may make sense to re-open this issue as it seems like trigger("keydown.up") does not work as it should according to the docs


Support for Multiple Vision Models with easy Interface

HI @haseeb-heaven, first thanks for your great work for tying up all common LLMs with one string. Really appreciateable.
I was looking for Vision AI models. In the documentation, you have written that currently, it supports Vopensource and Vision AI models and Vision APIs, but is there any possibility to add any UI, may be a web page running on localhost to deal with LLms, like prompt writing , image uploading, or a drop-down to switch to LLMs and entering their API keys in text fields?

Hi
Currently it only support GPT Vision and Google AI Vision models and others are not added yet and about the interface it has only CLI interface but for vision models you need to modify it to have the UI for image upload or chat.
The interface is simple to use for all users but for additionalal features like image upload and chat interface we can create new interface but it will take lots of re-designing the interpreter.py and interpreter_lib.py class

Thanks for the reply. Any plans to upgrade this with Gemini?
Open-source vision models like LLAVA and GUI support will make CODE-Interpreter a more generic and interesting tool.

This was supposed to be command line tool only for ease to use but for image we can have different branch for GUI to make it more usable.


Forced Install of wp-content/mu-plugins/wpstarter-mu-loader.php Conflicts with Existing MU Plugin Loaders

Describe the bug
There needs to be a way to disable the forced us of the wp-content/mu-plugins/wpstarter-mu-loader.php MU Plugin loader especially when there are existing MU Plugins that are installed via Composer and use other MU Plugin loaders.
To Reproduce
Steps to reproduce the behavior:

Install the https://packagist.org/packages/ndigitals/wp-local-media-proxy MU Plugin via Composer.
This includes/requires the https://packagist.org/packages/boxuk/wp-muplugin-loader MU Plugin Loader package.
Both loaders will attempt to load MU Plugins.

Expected behavior
Provide a config option that prevents the installation of this loader.
Additional context
This didn't existing in early beta releases.

As an update, what I've relegated to doing, for now, is to add a post-install-cmd & post-update-cmd script to remove that file.
        "remove-muplugins-loader": [
            "rm public/wp-content/mu-plugins/wpstarter-mu-loader.php"
        ],

Unfortunately, I come to find pretty quickly that trying to simply rm the file in the way I proposed is not viable. For starters it is likely not cross-platform compatible. The bigger issue is that if you run a composer install --no-dev and then follow that by a composer install, or even just multiple composer install executions, you'll get failures since the file is deleted the first time and then it's not there later. Attempts to get around errors if the file is no longer there go back to the first issue of things not being cross-platform compatible. I'm going to take the route of adding this file to the  prevent-overwrite list and just add an fake version of this file and commit it to the repository.

Thanks @timnolte
I think that managing that kind of loaders is a matter of the website-level handling, like WP Starter or Bedrock, and a plugin should not do that, because it has no knowledge of the wider website architecture. For example, that would make such a plugin incompatible with a platform like wp.com VIP.
Anyway, WP Starter is very flexible and pretty much every aspect of it are configurable, so it make sense to add this to the list.

FYI one way to handle this would be to have a custom template for the loader that would just be an empty file.
To use custom templates, you need to define a custom template folder via the templates-dir configuration and place in that folder a file named like the current template. You don't need to place in the custom folder all the templates: files not found in the custom folder fallback to the default WP Starter templates folder.
You can even have a separate Composer package with your custom WP Starter templates, and then define the custom template directory inside the vendor folder.

@timnolte I just realized that the MU loader is created in one step called build-mu-loader, see https://wecodemore.github.io/wpstarter/05-WP-Starter-Steps.html#muloaderstep
WP Starter allows you to disable specific steps, see docs: https://wecodemore.github.io/wpstarter/05-WP-Starter-Steps.html#skipping-steps
So you can have a configuration like:
{
    "skip-steps": [
        "build-mu-loader"
    ]
}

And that will achieve exactly what you're asking.
I'm closing this issue, please reopen if something is not working for you.

@gmazzap thanks for that detail. We were resorting to creating an empty version of that file and directing WP Starter to not overwrite it. I'd much rather use the skip-steps setup.


ApplicationLifecycleModule.IsEnabled = false; not working

I have 3 slots of an Azure Web Application running slightly different versions of the same ASP.NET MVC web app.
I'm logging to an external Seq server through Serilog with some enrichers from SerilogWeb.Classic. Each slot has its own ApiKey so I can differentiate each event in the Seq dashboard.
I don't want to log every HTTP request and this was working fine until now. All of a sudden one of the slots started logging every HTTP request. So I went back and make sure ApplicationLifecycleModule.IsEnabled = false; was there. It's there. I also went further and added ApplicationLifecycleModule.RequestLoggingLevel = Serilog.Events.LogEventLevel.Verbose; but it's not working either, the requests are still being logged with level Information.
The only real difference between the slots during deployment is the web.config that gets transformed in order to modify some appSettings, nothing strange.
What could be causing this behaviour? Is there another place where this could be overwritten?
Just to provide more information, this is the method that gets called in Global.asax Application_Start() method.
    public static class SerilogConfig
    {
        private const string SeqServerUrl = "http://mySeqUrl";
        private static readonly string ApiKey = ConfigurationManager.AppSettings["Seq.ApiKey"];

        public static void Initialize()
        {
            ApplicationLifecycleModule.IsEnabled = false; // disable logging every HTTP request
            ApplicationLifecycleModule.RequestLoggingLevel = Serilog.Events.LogEventLevel.Verbose;

            Log.Logger = new LoggerConfiguration()
                .WriteTo.Seq(SeqServerUrl, apiKey: ApiKey)
                .WriteTo.RollingFile(AppDomain.CurrentDomain.BaseDirectory + "App_Data\\" + "Logs\\" + "{Date}.txt")
                .Enrich.WithMachineName()
                .Enrich.With(new HttpRequestClientHostIPEnricher(true))
                .Enrich.With(new HttpRequestClientHostNameEnricher())
                .Enrich.With(new HttpRequestRawUrlEnricher())
                .Enrich.With(new HttpRequestUrlReferrerEnricher())
                .Enrich.With(new HttpRequestUserAgentEnricher())
                .CreateLogger();

            Log.Information("Application started.");
        }
    }

Hi - it's most likely that there are two different assemblies at work here. Do you have Serilog.Extras.Web.dll as well as SerilogWeb.Classic.dll in the bin folder?

That's correct. The old Serilog.Extras.Web.dll was sitting in the bin folder next to the new one and causing the issue. Deleted it and now it's working.
Thank you


use proxy from git config

This updates #1173 with the latest master. Since that PR, a lot of subpackages have been split out, and we've switched assertion libraries.
@jonmagic @LizzHale: I also changed the main ProxyFromGitConfigOrEnvironment() function from #1173 for these reasons:

proxyFromGitConfigOrEnvironment() is coupled to the global Config value. I updated the function to accept only a *config.Configuration argument, and return a func(*http.Request) (*url.URL, error). That cleaned up the test setup for TestProxyFromGitConfig a bit.
It returns a valid url OR error from http.ProxyFromEnvironment now. I didn't want to drop a potential error if users have a bad HTTPS_PROXY value, but a good git http.proxy value.
The end of the function returns nil now, explicitly.

Unfortunately, I couldn't test the environment, because of how http.ProxyFromEnvironment is implemented. It reads from the env the first time that function is called. Calling os.Setenv doesn't affect it.
However, I'm thinking about pulling all that code into Git LFS. There are a few internal functions that would be useful for proxy values specified in the git config, such as NO_PROXY handling.

@technoweenie awesome! Just getting back from vacation, anything I can do to help on this?

👍 looks good

Hey, funny story time. @ttaylorr asked me why the function is named ProxyFromGitConfigOrEnvironment, when it's reading from the env first, before git config. Turns out it's named that way because the original implementation read from the git config first. Then, I chimed in:

My main question is whether this should prefer the git config or the environment first? I'd lean towards using the git config as a last resort. A couple use cases:

Someone has a global http_proxy set in their bashrc because of their local network setup.
Someone runs http_proxy=.... git clone ...

I'd like to see how git handles this.

I never looked into it until just now though, while looking for any other proxy related git config values. The docs say:

Override the HTTP proxy, normally configured using the http_proxy, https_proxy, and all_proxy environment variables

Looks like @jonmagic and @LizzHale are right :) I wonder if a git http.proxy value should override a HTTPS_PROXY env var for https requests though?

This is a great point - I even checked the precedence and agreed with it, but now you raise it again I think this does need to be the other way around in this case.
Usually environment variables should override gitconfig, but in this case the environment variables are general ones, not git specific ones. Thinking about it, it makes sense that the overall order of precedence should be:

Git specific environment variables
git config
General environment variables

.. because otherwise you have no way of persistently overriding generic environment settings specifically for git. The confusion I've had is that we've only really had 1 & 2 most of the time.

I updated the code to check the git config first :+1:

Looks good! ✨

:sparkles:


Python 3 support?

Attempting to pip-install oauth2 gives a SyntaxError on a print statement lacking parens when in a Python 3 environment. Therefore I assume oauth2 does not support Python 3 at the moment.
Any plans to add support for Python 3 in the future?

Hi @davidfstr
You're correct, although we are actively working on it. The plan is to release 1.9 soon (as soon as I get the readme finished) and then release py3k in version 2

Closing this thanks to the latest 1.9 release :+1: it has py3k in it!


Make license available in GitHub

GitHub doesn't show MIT license for CodeJam:

Maybe it is in the project settings ?
Here license works well:
https://github.com/jquery/jquery

There are no these settings

Fixed by a00f2bd9c9e16aa54675e215945f89719cdc7087 :)


Ray TPU Webhook RayJob Support

Extends the mutating admission webhook for multi-host TPUs with Kuberay to support RayJob creation requests. This PR causes the webhook to intercept RayJob creation requests with the app.kubernetes.io/name: kuberay label and inject the subdomain field and TPU_WORKER_HOSTNAMES environment variable. This PR has been manually tested using kubectl describe to verify correct variable injection.

In order for the webhook to work with RayJobs, it's necessary to annotate the RayJob with the label app.kubernetes.io/name: kuberay, since the mutating webhook configuration uses that label as a selector. I wanted to check whether this is reasonable, or if it'd be preferable to remove the label selectors entirely and have the webhook intercept all RayClusters, RayJobs, and Pods created while it's running.

@ryanaoleary we did a refactor in https://github.com/GoogleCloudPlatform/ai-on-gke/commit/6aeff71532b7210e1bc50f913abf8bdb5c05427c, please move your changes under https://github.com/GoogleCloudPlatform/ai-on-gke/tree/main/applications/ray


Set row's CSS class depending on value of data item?

Is it possible to set the CSS class of the row depending on the value of one of the properties of my data row?
For example:
If (row.IsValid)
// Set CSS class "success"
else
// Set CSS class "failure"

@tobbi
Hello for now this is not supported scenario.
For now you can create your own component which you can render into every column.
Example config.
 RenderFragment<Customer> customerEmailComponent = (Customer customer) => delegate (RenderTreeBuilder rendererTreeBuilder)
 {
     var internalBuilder = new BlazorRendererTreeBuilder(rendererTreeBuilder);
                 internalBuilder
                     .OpenElement(HtmlTagNames.H4)
                     .AddContent(customer.Email)
                     .CloseElement();
 };`


Option to change Web RDP URL for Windows Virtual Desktop

@Mr-Sharma Thanks for posting here.
Please share the azure document URL if you are following one.

@Mr-Sharma Did you got a chance to look at my previous comment?

@ChristianMontoya @Heidilohr Please add your comments .

"https://docs.microsoft.com/en-us/azure/virtual-desktop/". This is the Document I'm referring to deploy Windows Virtual Desktop. By the end of this tutorial, we can connect to our WVD using the web client URL: "https://rdweb.wvd.microsoft.com". Can we change this URL to include our domain?

@Mr-Sharma : Currently, we do not support providing a custom URLs to replace "https://rdweb.wvd.microsoft.com" . This is something we are investigating for the future.

@Mr-Sharma You can submit a feedback here https://feedback.azure.com/forums/34192--general-feedback  to request for this feature
Then the community can upvote it.

@Mr-Sharma
I will close this out for now. If you need additional help please let me know and we can reopen and continue.
Please post the feedback URL here so that it will help others users to find the feedback link and upvote.


WordPress Blog Folder Get Deleted When run dep deploy command

Q
A

Issue Type
Bug, Question, Feature Request

Deployer Version
N/A

Local Machine OS
N/A

Remote Machine OS
N/A

Description
If you're reporting a bug, please include following information
Steps to reproduce
Content of deploy.php
CONTENT

Output log
With enabled option for verbose output -vvv.
Hi,
I have installed a Wordpress blog on current/public/blog folder. When I run dep deploy command the blog folder gets deleted.
What is the best way to handle this situation?

Yes


Fix unstable_const for the latest compiler

This PR removes some of #![feature(...)]s for compatibility with the latest nightly compiler.

const_maybe_uninit_as_ptr has been stabilized by https://github.com/rust-lang/rust/pull/90896 and is not recognized by the compiler anymore.

const_raw_ptr_deref has been stabilized by https://github.com/rust-lang/rust/pull/89551.

Thanks @yvt !
Will release a new version with this soon
Have a nice weekend


Fix/initialize markets

Closes https://github.com/eprbell/dali-rp2/issues/161

There's still a static analysis failure.

There's still a static analysis failure.

Yes, thanks the pylinted tests didn't like the name of the fixture. Ran pylint locally now, as it is not part of the pre-commit hook.

There's still a static analysis failure.

Yes, thanks the pylinted tests didn't like the name of the fixture. Ran pylint locally now, as it is not part of the pre-commit hook.

No worries. There's still some mypy errors. You can run mypy locally with https://github.com/eprbell/dali-rp2/blob/main/README.dev.md#development-workflow and you can also run all the other CI test locally (see https://github.com/eprbell/dali-rp2/blob/main/README.dev.md#development-workflow).

It seems like #198 addresses this more robustly. Is it all right to close this PR?

I tried to merge but there is one more small static analysis problem: once that's fixed this is good to go.

@macanudo527 Sure thanks, still had to fix the typing issue any way.


Facebook oEmbed Changes

Refer this article: https://developers.facebook.com/docs/plugins/oembed/
The oEmbed product has been replaced with the oEmbed Read feature. If you implemented the oEmbed product before June 8, 2021, you have until September 7, 2021 to complete App Review for the oEmbed Read feature. If you have not been approved for the oEmbed Read feature by September 7, 2021, your oEmbed implementations will fail to load.
I don't really help with the api that often and am unsure if this actually affects us, but I thought I'd bring it to attention anyway.

This does indeed affect existing API keys but doesn't affect the code.
However, an update to providers.json is necessary. Here's the relevant commit for updating providers.json:
https://github.com/iamcal/oembed/commit/6f2af3104ca7fca8270916bb9a977257214ed3ad
When it comes to fixing existing API keys, one needs to do the new App Review process:

Also, they have an entire video over here https://developers.facebook.com/docs/app-review describing the process.
Also, services must now undergo yearly data checkup https://developers.facebook.com/docs/development/maintaining-data-access/data-use-checkup It's not very difficult, just lots of boxes to check.


KAFKA-3514, Documentations: Add out of ordering in concepts.

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

failures unrelated
retest this please

The failed test RepartitionOptimizingIntegrationTest is being fixed in https://github.com/apache/kafka/pull/5517

Should only be merged after #5428 was merged.

Should only be merged after #5428 was merged?

Yes, that's the plan.

Can we merge this?


Add snippets for Gleam

It would be great, if snippets for the Gleam programming language would be added. A ready JSON already exists.
Should I just make a PR for it?

Hi @tobsz 👋 opening a PR is good as it'll let others see it ahead of time. Just make sure to reference this issue in the PR title or description.


Pretty print error messages in API client

This change is

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

generator/bindata.go, line 114 at r1 (raw file):
Previously, danieljy (Daniel Yehuda) wrote…
How was this file modified?

this is auto-generated by go-bindata

Comments from Reviewable

I'm LGTMing, but I would love to just know that you were able to point your local glide.yaml to the sha and that everything worked.

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

yup everything worked. sha in https://reviewable.io/reviews/sidewalklabs/parking/996 is correct

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

sorry for this incredible commit history lol

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Foundation 6.6.1 util.motion does not work as in version 6.5.3

What should happen?
"dependencies": {
 "foundation-sites": "6.5.3",
 "motion-ui": "1"
}
import {Motion} from 'foundation-sites/js/foundation';
Motion.animateIn(submenu, animation, () => {
console.log('Test);
});
submenu = jquery element
animation = 'hinge-in-from-top'
With Foundation version 6.5.3, the animation and the console log works.
What happens instead?
"dependencies": {
 "foundation-sites": "6.6.1",
 "motion-ui": "1"
}
After updating Foundation to 6.6.1 same code is not working any more. There is no JavaScript error message and there is no animation and no console log.

Hi @naimRahman08,
thanks for reporting this.
Can you verify that this still happens in 6.6.1?
https://github.com/foundation/foundation-sites/releases

Hi @naimRahman08,
thanks for reporting this.
Can you verify that this is fixed by https://github.com/foundation/foundation-sites/pull/11944?

Thank you for your quick reply @DanielRuf.
After testing with current PR, I can confirm that the issue is fixed. Can you please tell me when should we expect it in production?
Big Thanks


Integer kind

Massive change - most things end up inside modules, integer kind is added.

Superceded by #132, #134, #136.


DocumentRepository->findBy doesn't work when array is passed

Failing test case for https://github.com/symfony/symfony/issues/13961

On a second thought current flow makes perfect sense as Document can contain array and user can search for document by it, closing this then


Upnp playback

To work over this is there a plugin you would recommend?
From the example, console.log(devices) return multiple hash of uuid, location, st, etc. More than 10 hashes of those.
If you could help with a flow to follow up after setting up this plugin, that would be cool.

@arjunmenon I have written a pretty comprehensive JS stack for DLNA, but that is locked down under the company i worked for copyright and distribution license.
Working on a simple stack at the moment, will let you know when i have something substantial.

Hey
Great to know! I have this basic code to get, list and call actions - https://gist.github.com/arjunmenon/8ad89f7348442834efe6271e731221f4
I haven't tested it for OpenHome. That is a primary goal.
Coded to adapt it for TabrisJS. It can work for Cordova as well.
Bit struggling on the subscription part. TabrisJS is not that friendly to work with sockets.


[Snackbar] Treat null properly and add a test for it

Fixes #9089 and even adds a test for autoHideDuration={null} so that it won't get broken again. :wink:

@leMaik As always, good job here :)


This assumes webdav

https://github.com/PHSERIS/paper_trail/blob/6a70cd03d62e9ba6ad6f43b1107fd403aa7b7cff/use_cases/paper_trail_common.php#L399

Not all users use webdav.  This should rely on the Files class to determine storage mechanism.

@123andy @alanisem123  I thought I'd put a PR in for this last year.

@123andy @alanisem123 I believe this was our commit to correct the storage issue: https://github.com/PHSERIS/paper_trail/compare/master...ucsf-research-tech:paper_trail:master
I thought I'd submitted a PR, but maybe it was a pointer in our email conversation from back then, @alanisem123 .

Individual commit here: https://github.com/PHSERIS/paper_trail/commit/e639037156c9572d33acbaadd7ee3e7f642db83d

sounds good - let me see if I can complete the pull request.

Submitted as https://github.com/PHSERIS/paper_trail/pull/4. See if @123andy can review; there may be a more elegant or robust way to do this.

Hi @remifrazierucsf - I'm not volunteering to review code for this repo :-). I looked at it after the REDCap con and was excited but the idea of a uniform consent system but am not sure what the status of this repo is given we ran into a few issues.   For now, I'm going to keep my separate module for multi-sig-consent that builds custom PDFs and see if I can extend it a bit to do what htis does.  I hate having two modules with overlapping functionality but I'm not sure where to go at the moment.

@123andy no problem, I get it. :) I can't recall now what we needed from the multi-sig process for our part 11 system that led me to update this one instead of using yours.
It may be worth us getting together to chat about these as well as the two custom PDF template engines out there. They basically all do the same thing but none of them comprehensively. It might be nice to get one solution built and try to PR it into the core codebase.


Add support for refresh tokens for openshift connector

Notes:

During review, will ask about the Close func as it is not defined anymore, whether it would be OK to delete it.

Split the PR into three

this one remains with the refresh token support
#2 was split with the change related to checking the availability of the OAuth2 endpoints during creation
#3 was split with the change related to allowing to use system trusted CAs and custom CAs within the openshift connector


Updates to dev center.

Docs Build status updates of commit 6e8afed:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/index.yml
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 45f59e2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/index.yml
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


python311Packages.gios: 3.2.0 -> 3.2.1

Diff: https://github.com/bieniu/gios/compare/refs/tags/3.2.0...3.2.1
Changelog: https://github.com/bieniu/gios/releases/tag/3.2.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 265902 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.gios
python310Packages.gios
python310Packages.gios.dist
python311Packages.gios
python311Packages.gios.dist


Unspecific names: TerminalBehaviour and RevealKind

Unsure of alternatives but I didn't expect TerminalBehaviour to belong to tasks but to the terminal API, also RevealKind is very generic and can be confused with other parts, like editor selection reveal kind

Similar, ShellOptions should be probably called ShellTaskOptions

Good points. I will at least insert Task somehow into the name.
ShellOptions -> ShellTaskOptions
ProcessOptions -> ProcessTaskOptions.
TerminalBehaviour -> TaskTerminalOptions
RevealKind -> TaskTerminalRevealKind

One additional comment:
Used TaskTerminalBehavior and not TaskTerminalOptions since there are already TerminalOptions and it might be confusing.

Should it then also become Task#terminalBehavior instead of just terminal?

Makes sense. Will do.

Done.


Shouldn't change url_key's if they are already defined

Hi!
For some reason this tool changes existing url_keys on products. Why does this happen? If it is already defined, it shouldn't overwrite it with a newly generated one? Shop owners want to have control over the url keys, the tool shouldn't assume that it can blindly overwrite these values I think.
It would be appreciated if some option can be added to stop this from happening (or even make this the default behaviour, since I don't think people are expecting this?).
But it should still generate url_key's for products when they don't have one yet.
Thanks!

As explained in #78 , this is default behavior. My PR was refused for this reason. However, I will submit soon a PR with the reverse option, that is not to regen URL_key.

See #94 if you want to test.

Pull request was accepted. Option was added in release v1.4.3
Please confirm to close a ticket.

Thanks @olegkoval & @werfu!
This new option says to not generate url_key's at all, which is already a very nice improvement!
Just briefly tested it and it seems to works like was intended.
But it's not fully fixing this issue I think.
I would like to see a behavior in this tool where it corrects incorrect url_key's (meaning: missing/empty ones), but it shouldn't touch the ones which are already filled in.
In that case, it will make sure all products have an url_key in the database on every storeview and it would also not overwrite those which got manually entered.
Is this something which makes sense?
Thanks!

Implemented. Closed.

Have same problem as @hostep defined, that means the module generated all store views url_key even the entity was marked as Use Default.
Unfortunately the problem is still exist.


Uncaught TypeError: undefined is not a function

[Enter steps to reproduce below:]

Open a markdown file
Press CTRL+SHIFT+E to export

Right clicking in markdown preview also does nothing.
Atom Version: 1.0.9
System: Microsoft Windows 7 Professional
Thrown From: markdown-themeable-pdf package, v0.7.2
Stack Trace
Uncaught TypeError: undefined is not a function
At C:\Users\marty\.atom\packages\markdown-themeable-pdf\lib\markdown-themeable-pdf.js:304

TypeError: undefined is not a function
  at C:\Users\marty\.atom\packages\markdown-themeable-pdf\lib\markdown-themeable-pdf.js:304:20
  at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:379:3)

Commands
     -1:01.1.0 markdown-themeable-pdf:export (atom-text-editor.editor.is-focused)
     -0:41 markdown-preview:toggle (atom-text-editor.editor.is-focused)
     -0:07.3.0 markdown-themeable-pdf:export (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ],
    "autoHideMenuBar": true,
    "projectHome": "C:\\Users\\marty\\Dropbox\\Documents\\ecu"
  },
  "markdown-themeable-pdf": {}
}

Installed Packages
# User
autoclose-html, v0.18.0
language-asp, v1.0.0
language-aspx, v0.4.0
language-latex, v0.6.1
markdown-scroll-sync, v0.4.0
markdown-themeable-pdf, v0.7.2
save-session, v0.15.7
sync-settings, v0.6.0
tabs-to-spaces, v0.11.1

# Dev
No dev packages

Hey, thank´s for your report. Is that once happened, or happens to you every time? I and my colleagues also work with Windows. Here everything works. May be the package was not installed correctly. Most simply uninstalling it easy and install it again. Possibly a node module was not available on npmjs.com at the time of your installation.
The right click on markdown preview is a known issue and and is achieved up to v1.0.

I close this issue. Please let me know if you have this problem again.

I have the same issue on Ubuntu

I'm testing it and add some more human friendly error messages... ;)

Apologies for late response. I disabled markdown-scroll-sync and it worked perfectly after that.
I may have also disabled markdown-pdf to get it working, although I'm not 100% sure. I've disabled it anyway since this great addon replaces it =)

Ah, very good! I look at the whole still at times where the incompatibility occurs. I am pleased that now everything works :)

As @martymcflywa said, disabling markdown-pdf made this error go away. Perhaps the install could test if markdown-pdf is also installed? My first take was that they were related, not against each other.

I look at this closer, when such interest exists here ;)

Hmm, I tried it with following packages... Everything works with:

markdown-format
markdown-pdf
markdown-scroll-sync
markdown-themeable-pdf

I let the plugins installed in my development environment. So I will eventually notice an error, if it exists. I do not think that all reported errors here have the same cause. Please create a new Issue, if something happens.


Add support for node placement

Refer https://github.com/submariner-io/submariner-operator/pull/2530

/cc @skitt @tpantelis

/cc @sridhargaddam

/approve

/lgtm


EACirc@CAESAR

Try using EACirc for Authenticated Encryption competition submissions.
http://competitions.cr.yp.to/caesar-submissions.html

Ideas moved to internal wiki.


[Bug report]:

Platform
Desktop
Version
1.7.3
Description
App Version: 1.7.3
platform: macOS
platformVersion: 10.15.7
platformArchitecture: x64
cpuCount: 4
totalMem: 8192.0 MB
freeMem: 403.0 MB
Error Type: [Preload Context] Error
Error: node-loader:
Error: dlopen(/private/var/folders/l0/tq1kb1wj7v19l8n6xrkpjj040000gn/T/AppTranslocation/79AEBD62-BD1F-4BF0-83D6-08E08A601E91/d/Firefly.app/Contents/Resources/app.asar.unpacked/public/build/index.node, 1): Symbol not found: __ZNSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE7seekoffExNS_8ios_base7seekdirEj
Referenced from: /private/var/folders/l0/tq1kb1wj7v19l8n6xrkpjj040000gn/T/AppTranslocation/79AEBD62-BD1F-4BF0-83D6-08E08A601E91/d/Firefly.app/Contents/Resources/app.asar.unpacked/public/build/index.node (which was built for Mac OS X 13.0)
Expected in: /usr/lib/libc++.1.dylib
in /private/var/folders/l0/tq1kb1wj7v19l8n6xrkpjj040000gn/T/AppTranslocation/79AEBD62-BD1F-4BF0-83D6-08E08A601E91/d/Firefly.app/Contents/Resources/app.asar.unpacked/public/build/index.node
Expected behaviour
Not sure, I assume to be able to log in. But each time I go to load fire fly I get the above error message
Actual behaviour
The above error appears each time I try to open the app
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue
Open the App
Operating System
Mac
Diagnostics
App Version: 1.7.3

platform: macOS
platformVersion: 10.15.7
platformArchitecture: x64
cpuCount: 4
totalMem: 8192.0 MB
freeMem: 403.0 MB

Error Type: [Preload Context] Error

Error: node-loader:
Error: dlopen(/private/var/folders/l0/tq1kb1wj7v19l8n6xrkpjj040000gn/T/AppTranslocation/79AEBD62-BD1F-4BF0-83D6-08E08A601E91/d/Firefly.app/Contents/Resources/app.asar.unpacked/public/build/index.node, 1): Symbol not found: __ZNSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE7seekoffExNS_8ios_base7seekdirEj
  Referenced from: /private/var/folders/l0/tq1kb1wj7v19l8n6xrkpjj040000gn/T/AppTranslocation/79AEBD62-BD1F-4BF0-83D6-08E08A601E91/d/Firefly.app/Contents/Resources/app.asar.unpacked/public/build/index.node (which was built for Mac OS X 13.0)
  Expected in: /usr/lib/libc++.1.dylib
 in /private/var/folders/l0/tq1kb1wj7v19l8n6xrkpjj040000gn/T/AppTranslocation/79AEBD62-BD1F-4BF0-83D6-08E08A601E91/d/Firefly.app/Contents/Resources/app.asar.unpacked/public/build/index.node

Developer Profile
No
Profile Type
Software (Stronghold)
Staking
None
Crash Status
None of the above
Error Messages
No response
Error Logs
No response
Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Duplicate of https://github.com/iotaledger/firefly/issues/7324

Hi, we just released the new version 1.7.4 which contains the fix
Firefly IOTA 1.7.4 announcement message
We just released Firefly IOTA 1.7.4. Among the changes, it contains the fixes for macOS crash at startup and the slow stronghold export.
:warning: Important: macOS 10.13 will not be supported anymore in Firefly IOTA, so if you are running macOS 10.13 we highly recommend upgrading your macOS version to a newer one.
:pencil: Changelog:

fix slow stronghold export
fix macOS support (official drop support macOS <= 10.13)
add official asmb staking event 6 results

:arrow_down:  Download:
https://firefly.iota.org/
:bug:  Bug Reporting:
https://github.com/iotaledger/firefly/issues/new?assignees=&labels=bug+report&template=bug_report.yml&title=[Bug+report]%3A


New algorithm for resolving action groups

Description
This code change is just in preparation for the change in #4380 as requested in https://github.com/opensearch-project/security/pull/4416#pullrequestreview-2106138499 .
This replaces the previous action group resolution algorithm done in ConfigModelV7 by a new one, which has a number of enhancements:

The new implementation forms an independent class, enhancing testability and use in other components that will be introduced in #4380.
The new implementation handles action group configurations containing loops gracefully. The old one would wind up StackOverflowErrors.
The new one pre-computes the resolved action groups, thus enhancing the performance.

Category: Enhancement
Why these changes are required? - The changes in #4380 will no longer use ConfigModelV7 and thus need an independent action group resolution mechanism.
What is the old behavior before changes and new behavior after changes? - No behavioral changes except for action group definitions containing groups, which will be handled gracefully now.

Testing

Unit tests in org.opensearch.security.securityconf.FlattenedActionGroupsTest

Check List

[x] New functionality includes testing
[x] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks

Thank you @nibix! This change looks good to me. One scenario I'd like to see covered would be a change in action group and verify its reflected in the new FlattenedActionGroups data structure.

This is certainly an important thing to test. However, such configuration updates are handled by the DynamicConfigFactory class which is not changed by this PR.
There used to be an integration test which would test what you are asking for - that is, it changed action groups via API and tested the effectiveness of these changes via normal user operations. That was at https://github.com/opensearch-project/security/blob/069249656970e839302a0d3b8b87c82fbf3e56cc/src/test/java/org/opensearch/security/dlic/rest/api/ActionGroupsApiTest.java . There was recently a refactor of this test in #4371. I quickly skimmed the replacement code and could not find any logic which tests the effectiveness of the modified configuration, but maybe I missed something?

@DarshitChanpura

Would the new runtime be more linear compared to the older implementation because we are using a combination of BFS + DFS?

The major gain comes from the fact that we calculate the resolved action group space only once instead of re-calculating it again and again for each action privilege configuration. Additionally, by using an iterative algorithm instead of a recursive algorithm it is easier for us to detect that resolution has finished and abort early. That give some more gain. However, all these gains only pertain to the config reload phase and not to the actual privilege evaluation.


step attribute outside of element

warnings running xslt:
[WARNING]: file:/build/upp/xsd2html2xml/utils/gui-attributes.xsl: line 418: Attribute 'step' outside of element.
[WARNING]: file:/build/upp/xsd2html2xml/utils/gui-attributes.xsl: line 429: Attribute 'step' outside of element.
[WARNING]: file:/build/upp/xsd2html2xml/utils/gui-attributes.xsl: line 440: Attribute 'step' outside of element.

how did you resolve it ?


[swarm] swarm cluster didn't recover upon VM restart (rpc error: code = 2 desc = raft: no elected cluster leader)

Output of docker version:
Client:
 Version:      1.12.0
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   8eab29e
 Built:        Thu Jul 28 23:54:00 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   8eab29e
 Built:        Thu Jul 28 23:54:00 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 4
 Running: 4
 Paused: 0
 Stopped: 0
Images: 1
Server Version: 1.12.0
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 15
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge overlay host null
Swarm: active
 NodeID: 2jml8zh2ap8gnw3ghchc03g09
 Error: rpc error: code = 2 desc = raft: no elected cluster leader
 Is Manager: true
 ClusterID:
 Managers: 0
 Nodes: 0
 Orchestration:
  Task History Retention Limit: 0
 Raft:
  Snapshot interval: 0
  Heartbeat tick: 0
  Election tick: 0
 Dispatcher:
  Heartbeat period: Less than a second
 CA configuration:
  Expiry duration: Less than a second
 Node Address: <IP_ADDRESS>
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.16-boot2docker
Operating System: Boot2Docker 1.12.0 (TCL 7.2); HEAD : e030bab - Fri Jul 29 00:29:14 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 995.9 MiB
Name: master1
ID: XFBC:QIPK:ZJH5:MGSZ:D6IA:32XG:TUHL:6E43:HXOQ:FVLW:OY64:HWD4
Docker Root Dir: /mnt/sda1/var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 72
 Goroutines: 218
 System Time: 2016-08-05T09:22:12.607462985Z
 EventsListeners: 4
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
5 VirtualBox VMs cluster
Steps to reproduce the issue:

Create a cluster with 2 managers and 3 workers
Turn off the laptop

Describe the results you received:
docker@master1:~$ docker node ls
Error response from daemon: rpc error: code = 2 desc = raft: no elected cluster leader
docker@master1:~$

manager logs --
logs.txt
It might be related to https://github.com/docker/docker/issues/25395#issuecomment-237718994
Describe the results you expected:
rogaha@Robertos-MacBook-Pro:~$ docker node ls                                                                                1:37:46
ID                           HOSTNAME  STATUS  AVAILABILITY  MANAGER STATUS
2jml8zh2ap8gnw3ghchc03g09 *  master1   Ready   Active        Leader
3tdlv4cze7r11d5qis26dwrrs    node3     Ready   Active
9fs2d5teotj8d4bsmpy7ml3wq    master2   Ready   Active        Reachable
9j07wl6mklsz56gf4gf6x0m4v    node2     Ready   Active
dnojrk9arbs9m864okbdwhygd    node1     Ready   Active

Additional information you deem important (e.g. issue happens only occasionally):

/cc @aaronlehmann @LK4D4

This could be a manifestation of #25055, which will be fixed in the next patch release.
Otherwise, there could be something particular about the VM setup that causes problems on restart. For example, if the VMs don't have static IP addresses, and they change after restart, that would prevent the two managers from communicating.
A cluster of two managers can't survive any manager failures. We recommend using an odd number of managers for the best resiliency.
In a situation like this where too many managers are down and the quorum is lost, it's possible to recover using the --force-new-cluster option (which starts a new cluster with a single manager, using the existing state).

Having the same issue
Docker version 1.12.0, build 8eab29e
Currently hosting the service in Azure.
The difference is that i did not reboot all the hosts, only one of the leaders got rebooted and the end result is the same, election seems to have failed.
let me know if there's anything i can add to this that would help

@aaronlehmann  i did try with the --force-new-cluster, this broke the cluster even further. when it executed the result was context deadline exceeded
now if i try to do a docker node ls from what was a manager before, i get "this node is not a swarm manager" but i cannot find any node that is !?

@toutougabi if you have just two manager, then that may be expected; if one of two managers is down, you lost quorum, and there's no way to re-elect a new leader (because both leaders are needed to elect a new leader), also see https://docs.docker.com/engine/swarm/admin_guide/#add-manager-nodes-for-fault-tolerance. Basically having a single manager is better than two

@thaJeztah i had 3 managers

anything new on this ?

The original issue is reported in this ticket is quite possibly fixed in the upcoming 1.12.1 release (https://github.com/docker/docker/issues/25055).
The issue related to --force-new-cluster is not something I've seen before. @abronan do you have any ideas what might cause this?

I just experienced this as well. I had a seemingly healthy swarm with 1 manager and 2 workers:
$ docker node ls
ID                           HOSTNAME  STATUS  AVAILABILITY  MANAGER STATUS
0xzzb9ocuwrpoq8aque2ckgtv    engine2   Ready   Active
7yo9kjx7csti4qjehlsci0d3u *  engine1   Ready   Active        Leader
dzjdm8lm1f48t9aqjuojc9byr    engine3   Ready   Active

After rebooting all 3 servers the swarm cannot recover.
Following is from the master:
$ docker node ls
Error response from daemon: rpc error: code = 2 desc = raft: no elected cluster leader

$ docker info
Containers: 15
 Running: 0
 Paused: 0
 Stopped: 15
Images: 137
Server Version: 1.12.1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 194
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: overlay null bridge host
Swarm: pending
 NodeID: 7yo9kjx7csti4qjehlsci0d3u
 Error: rpc error: code = 2 desc = raft: no elected cluster leader
 Is Manager: true
 ClusterID:
 Managers: 0
 Nodes: 0
 Orchestration:
  Task History Retention Limit: 0
 Raft:
  Snapshot Interval: 0
  Heartbeat Tick: 0
  Election Tick: 0
 Dispatcher:
  Heartbeat Period: Less than a second
 CA Configuration:
  Expiry Duration: Less than a second
 Node Address: <IP_ADDRESS>
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.4.0-38-generic
Operating System: Ubuntu 16.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.38 GiB
Name: engine1
ID: HRFF:EBHJ:CG5E:VI7S:YIJN:NHSE:WOTR:V7CH:TPOF:PQK2:DHID:CMQ7
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

More logs:
docker_2016_09_29.txt
/cc @mrjana

Let me close this ticket for now, as it looks like it went stale.


Add .editorconfig

PR Summary
Related #4708.
The .editorconfig file can be used by various editors and tools like Visual Studio and CodeFormatter.
The .editorconfig comes from Roslyn and CoreFX repositories:
https://github.com/dotnet/corefx/blob/master/.editorconfig
https://github.com/dotnet/roslyn/blob/master/.editorconfig
Description http://EditorConfig.org
Options https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[x] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

some of these conflict with style cop rules.  It would be good to make them consistent (disable the conflicting rules)

I believe we have already gained experience with StyleCop and we can turn off a few more rules. But first I would like to make some PR with CodeFormatting and style fixes so that we see the state of things more clearly. Also I guess CodeFormatter will use the .editorconfig file.

Many of the naming rules, especially for non-public fields, conflict with the style cop rules.  I believe those rules should be disabled before we add a file that defines conflicting rules.

@SteveL-MSFT Could you please share plans about fixing style issues?
My suggetion is to spend 1-2 weeks and fix as many style issues as we need, adjust and approve StyleCop and .editorconfig rules, reformat all code with CodeFormatter. After that we can return to normal contributing process with minimal style issue pressure.

@iSazonov I think after GA of 6.1 would be the best time to bulk address style issues to have consistency.  We're still targeting mid Sept for GA, so perhaps we can postpone this until then.

@SteveL-MSFT GA shipped; it's time to look at this. :)

Rebased to update CIs.

@TravisEz13 Can we merge? Or we should address

some of these conflict with style cop rules. It would be good to make them consistent (disable the conflicting rules)

If .editorconfig rules is ok we could continue with style cop rules in follow PRs.


Add UrlAttribute concern

This PR introduces UrlAttribute concern to remove http(s)://protocol and custom prefix from URL attributes. It also refactors the existing logic for social profile links (github, ...).
It doesn't add any URL validation because I think it's not necessary at this point. The http(s):// protocol is not required in the submitted data, so even asdf should be valid, because https://asdf is a valid URL.
Resolves #842

I've added a migration, what do you think? The URL logic is duplicated in the migration, because migrations shouldn't depend on the current application code (that will change in the future).

Sorry, I didn't mean we needed an actual Rails migration. You can throw a couple lines of a script in lib/tasks/backfills.rake that I can run as a one-off on Heroku.
Does that make sense?

🤦♂ Need to think before typing. Sure, makes sense. Changed.


Structure view for cyclic structure still contains R groups

I draw a cyclic structure in the editor - the sequence and HELM strings look OK, but the structure view shows that it is not fully connected and R groups remain on some monomers.

FIxed in 2016-11-21 update

Confirmed fixed. Closed.


Question: One ring is enabled without user asking for ring management after First Workload doc

Feedback:

the end point is deploying using traefik and is automatically hidden behind a master ring.  At the end of service management to hit the deployed end point I have to use:
curl -Lv -H "Ring: master" <IP_ADDRESS>/changefeed-app-service/weatherforecast -v
this is unexpected as I did not ask for a ring and documentation does not tell me that this is what is going to happen

@bnookala @evanlouie

Fixed by: https://github.com/CatalystCode/spk/pull/427

Docs: https://github.com/CatalystCode/spk/blob/8724e4003edd2f5138748c1257c09a0284ea90b7/guides/rings-101.md#setting-the-default-ring--routing


Screenshot quality

Is there an option to specify .screenshot() quality? I believe the default one is not the highest.

I could be wrong, but it looks like Chrome doesn't let you specify the quality for png images https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-captureScreenshot so I assume they are using the highest quality.
If not, maybe we can use format: "jpg", quality: 100?

You're right. I've tried both png, and jpg with quality: 100, and it's bad. Anyway, this has nothing to do with Chromeless, that's a chrome-remote-interface issue, so closing this.


ultimate-oldschool-pc-font-pack: simplify using fetchzip

Motivation for this change
@volth pointed out that  #45969 could be done much more simply using fetchzip, so I fixed it.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ultimate-oldschool-pc-font-pack


Update simpleclient, simpleclient_common, simpleclient_hotspot to 0.6.0

Updates

io.prometheus:simpleclient
io.prometheus:simpleclient_common
io.prometheus:simpleclient_hotspot

from 0.5.0 to 0.6.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Here's hoping for the good guys!
Changelog - https://github.com/prometheus/client_java/releases/tag/parent-0.6.0


gcc: create dummy crtstuff on S390 as well

Description of changes
This commit replicates the fix in https://github.com/NixOS/nixpkgs/pull/258032 for S390 as well.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Squashed, rebased.

Dammit something went wrong when I squashed.