Confine GRUB providers to presence of menus, prefer GRUB 2

This pull request is based on https://github.com/hercules-team/augeasproviders_grub/pull/1 and the latest comment by @m4ce. The specs are still working.

I added two commits incorporating your feedback. Thanks.

@domcleal what do you think of this PR?

@domcleal ?

Seems reasonable I guess.

Coverage decreased (-3.7%) to 96.319% when pulling 14b2d1b816cac20fdbba365668902a94ce03e000 on crealytics:confine2 into 980c92116c4164ad470a26330b32b83a97a7c769 on hercules-team:master.

To be honest, I'm not sure, what to do about the failing builds in travis. Looks like it tries to install a wrong rake version. Should I rebase by branch on the current master or is the problem something else?

Some of the gems do not work on ruby 1.8.3 in their latest version. there were some changes in the Gemfile that may get them working again.
Or would it be possible to get this merged without without passing tests on 1.8.3? Everything else is green. This would probably fix my issue in https://github.com/hercules-team/augeasproviders_grub/issues/22

https://github.com/hercules-team/augeasproviders_grub/commit/0d8f4455d4278b02abd2c5dca772eaf1fa637fe5 fixes build on Ruby 1.8, so a rebase should pass now.

Coverage increased (+0.09%) to 96.319% when pulling 08090dc888c4ddd34fc9875ae8b5fa50fcf9b4ed on crealytics:confine2 into 0d8f4455d4278b02abd2c5dca772eaf1fa637fe5 on hercules-team:master.


Catch GraphQL Errors

Currently the interceptor ignores errors if the context is "graphql"
https://github.com/ntegral/nestjs-sentry/blob/master/lib/services/sentry.interceptor.ts#L25
Something like this should work:
              case 'graphql':
                return this.captureGraphqlException(
                  scope,
                  GqlExecutionContext.create(context),
                  exception
                );

  private captureGraphqlException(scope: Scope, gqlContext: GqlExecutionContext, exception: any): void {
    const info = gqlContext.getInfo()
    const context = gqlContext.getContext()

    scope.setExtra('type', info.parentType.name)

    if (context.req) {
      // req within graphql context needs modification in
      const data = Handlers.parseRequest(<any>{} context.req, this.options);

      scope.setExtra('req', data.request);

      data.extra && scope.setExtras(data.extra);
      if (data.user) scope.setUser(data.user);
   }

    this.captureException(scope, exception);
  }

Is this fixed with #23 ?

Is this fixed with #23 ?

This has been updated in the latest version.

This has been updated in the latest version.


fix(parser) fixes sublanguage with no rule matches

Resolves #2504.

In the future (if we pull plaintext into the core library so it's impossible to build without) it'd probably make sense to use that here, but this works for now.


Regression in version 0.12.130

Some of my code isn't able to be @turboed anymore since version 0.12.130. Specifically, I'm getting a
┌ Warning: #= ... =#:
│ `LoopVectorization.check_args` on your inputs failed; running fallback `@inbounds @fastmath` loop instead.

and ~3x slowdown on code that worked fine on version 0.12.129.
I'm not sure if I'll be allowed to share the code. Is there any information I could help with while I try to figure this out?

After looking through the changes I think it was making safe=true the default.
Since replacing every instance of a^2 by a*a and ifelse by my_ifelse(decider, a, b) = decider * a + (1 - decider) * b I have achieved the old performance again.
I'm not sure if that was the intention behind the change but if so I can certainly live with the changes I made.

Hi, regressions where @turbo worked before were not the intention.
can_turbo should return true for ifelse and ^.
I'll have changes shortly that make this so.
Please feel free to file issues or create PRs for any more such problems.

Please let me know if your original versions encounter any problems. They should work now.

I can confirm that the original code now again runs with original speed (and no warning).
Thanks for looking into this and all the work you have been doing on this project! Truly a gamechanger.


hardware/structs/nvic.h: address_mapped.h should be address_map.h

Search for address_mapped.h. It is wrong in many files.
src/rp2040/hardware_regs/include/hardware/regs/addressmap.h
"hardware/address_mapped.h" should be "hardware/regs/address_map.h"

"hardware/address_mapped.h" is correct.


Feature Request: Have line numbers display in the RowHeader of the various grids

When looking through large sets of messages, it's often helpful to have line numbers for the row as in the following image:

I'm not that familiar with windows UI applications so I didn't make a PR for the changes. I'll explain what I've done to achieve the above results instead. If the explanation seems reasonable, I'd be happy to create a PR.
In the following 2 files:

C:_repositories\github\paolosalvatori\ServiceBusExplorer\src\ServiceBusExplorer\Controls\HandleQueueControl.cs
C:_repositories\github\paolosalvatori\ServiceBusExplorer\src\ServiceBusExplorer\Controls\HandleSubscriptionControl.cs

I have place the following code (Based on a SO answer here):
        private void dataGridView_RowPostPaint(object sender, DataGridViewRowPostPaintEventArgs e)
        {
            var grid = sender as DataGridView;
            var rowIdx = (e.RowIndex + 1).ToString();

            var centerFormat = new StringFormat()
            {
                Alignment = StringAlignment.Far,

                LineAlignment = StringAlignment.Center
            };

            Size textSize = TextRenderer.MeasureText(rowIdx, this.Font);

            if (grid.RowHeadersWidth < textSize.Width + 20)
            {
                grid.RowHeadersWidth = textSize.Width + 20;
            }

            var headerBounds = new Rectangle(e.RowBounds.Left, e.RowBounds.Top, grid.RowHeadersWidth - 4, e.RowBounds.Height);
            e.Graphics.DrawString(rowIdx, this.Font, SystemBrushes.ControlText, headerBounds, centerFormat);
        }

I then went into the UI designer and found the grids I know about and bound their RowPostPaint event to the new function.
As far as I can tell, that did the trick to achieved the results of having line numbers added to the rows.

@SeanFeldman I have done as you suggested and created a PR.
I'm not familiar with all that this tool offers, but, it looks like there may be other grids that may benefit from a row number display feature. It may be worth considering creating a subclass control to handle this and other common features.

Fixed in #717 😄


fix #2157 - Dom Util getEventTarget sometime throws illegal invocation

in some cases (might depend on Framework used, in our case it's SalesForce), it can throw an illegal invocation error and if that is the case then catching the error and defaulting to return event.target is what works. This PR wraps the code in a try/catch and if an error is caught then will default to return event.target
fixes #2157

Thanks @ghiscoding !

Welcome from a Canadian to another ;)


Bug: Function input_fn() creates new dataset on every call, leads to model overfitting

Our team has found what appears to be a major bug that causes models to be trained with a small subset of the full dataset specified by the user. This often leads to models that overfit.
The issue is caused by the use of tensorflow's continuous_train_and_eval() function combined with how input_fn() is implemented in tf-seq2seq. The smaller is the value of FLAGS.eval_every_n_steps, the faster overfitting occurs.
This is how it happens:
https://github.com/google/seq2seq/blob/master/bin/train.py#L269 function main() calls function learn_runner.run(), which goes to a bunch of tensorflow code and eventually makes it to…
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/learn/python/learn/experiment.py#L506 function continuous_train_and_eval(), which interleaves training and evaluation. The training portion eventually goes into…
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/learn/python/learn/experiment.py#L647 function _train_model(), which calls function input_fn(), which goes into…
https://github.com/google/seq2seq/blob/master/seq2seq/training/utils.py#L255 function input_fn() calls pipeline.make_data_provider(). In the case of this this model, that goes into…
https://github.com/google/seq2seq/blob/master/seq2seq/data/input_pipeline.py#L145 which creates a brand new tf.contrib.slim.dataset.Dataset().
This causes the effective size of the dataset to be as small as FLAGS.eval_every_n_steps, as the new Dataset() always starts reading from the beginning.
The problem is exacerbated when the input pipeline is set up with shuffle=False.
We reproduced this problem by training a small_nmt model with 8 layers, but it should affect more or less any model trained with tf-seq2seq. You can reproduce the issue by setting FLAGS.eval_every_n_steps equal to 1K in one instance, and 10K in another instance. If you look at the testing loss it will be clear that the smaller FLAGS.eval_every_n_steps, the faster it overfits.
It seems like the problem could be avoided if input_fn() was memoized.
Thanks for looking into this.

We currently think that memoizing input_fn() won't be enough because every time continuous_train_and_eval() switches and calls _call_train(), it eventually goes into  train_model, which creates a brand new graph.
We have created a bug against Tensorflow itself related to this issue, as we are not 100% certain of whether the problem could have been avoided through cleverer client code here.

@dagarcia-nvidia I think continuous_train_and_eval is not a good way to train model faster, what I do now is train model only with gpu, and make another running parallely eval the model with cpu.

I came across this problem too, and is trying to solve it.

@dagarcia-nvidia I think continuous_train_and_eval is not a good way to train model faster, what I do now is train model only with gpu, and make another running parallely eval the model with cpu.

The evaluate function and the continuous_eval function  in Experiment seems not work, could you please tell me how do you eval the model?


Can not hear sounds

Hi, I think I have correctly followed the CSV tutorial, I see all my soundsets and moods in the drop-downs but when I play them I can not hear anything and even the browser does not display the sound logo nor windows seeing it in the sound manager.
What can I do and what additionnal informations can I provide you ?

Hello,
SyrinControl does not provide audio, and I do not intend to add this feature. You need to use Syrinscape Online Player to hear the sound.
https://syrinscape.com/online/
See step 2.
 If not does the "currently playing" mood in Syrinscape Online Player changes when you change the active scene in Foundry?

Ok yeah it works perfectly I just did not understood that it was "solely" an automatic/programmable remote controler for online syrinscape. Now that I know that I should be able to used it to it's full potential.
Thanks again


CoreInternal: Convert register functions to add/remove

Pull Request Test Coverage Report for Build 2807

19 of 20 (95.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 99.879%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/core/lib/CoreState.sol
0
1
0.0%

Totals

Change from base Build 2799:
-0.1%

Covered Lines:
594

Relevant Lines:
595

💛  - Coveralls


Can I change prompts.py and add some entities myself ?

You can add your own custom entities with prompts just by adding to the existing file llmgraph/prompts.yaml. No need to change any Python files.
For example add:
kaomitas-new-concept:
  system: You are highly knowledgeable about things that kaomita likes
  knowledgeable_about: things that kaomita likes
  entities: things
  entity: thing
  top_n: 5

And then run with a command similar to this: llmgraph kaomitas-new-concept "https://en.wikipedia.org/wiki/<ADD-YOUR-ROOT-ENTITY-HEHE>"
See additional commandline args here: https://github.com/dylanhogg/llmgraph?tab=readme-ov-file#required-arguments
I haven't fully tested adding new concepts with the pip installed llmgraph - you will may need to clone this repo and run it locally so that it picks up your edited prompts.yaml file with the concept and corresponding prompt you added. With pip you can probably do this by finding and editing the installed prompts.yaml where the library has been installed to.
Hope that helps.

You can add your own custom entities with prompts just by adding to the existing file llmgraph/prompts.yaml. No need to change any Python files.
For example add:
kaomitas-new-concept:
  system: You are highly knowledgeable about things that kaomita likes
  knowledgeable_about: things that kaomita likes
  entities: things
  entity: thing
  top_n: 5

And then run with a command similar to this: llmgraph kaomitas-new-concept "https://en.wikipedia.org/wiki/<ADD-YOUR-ROOT-ENTITY-HEHE>"
See additional commandline args here: https://github.com/dylanhogg/llmgraph?tab=readme-ov-file#required-arguments
I haven't fully tested adding new concepts with the pip installed llmgraph - you will may need to clone this repo and run it locally so that it picks up your edited prompts.yaml file with the concept and corresponding prompt you added. With pip you can probably do this by finding and editing the installed prompts.yaml where the library has been installed to.我还没有完全测试使用 pip 安装的 llmgraph 添加新概念 - 您可能需要克隆此存储库并在本地运行它，以便它使用您添加的概念和相应的提示来获取您编辑的 Promps.yaml 文件。使用 pip，您可以通过查找并编辑库已安装到的已安装的提示.yaml 来完成此操作。
Hope that helps.

Thanks, I will try.


Test

Code of Conduct

[X] I have read and agree to the project's Code of Conduct.

PowerVCF
2.3.0
Motivation
Test
Suggestion
Test

Closing test issue.


Update dependencies

Currently several pending dependency updates are breaking the build. We should investigate what to do to fix these issues and update the corresponding libs.

Dependencies were updated in multiple PRs. Some dependencies cannot be updated yet due to react-scripts-ts not supporting of webpack4 (e.g. styleguidist).


How to get a standard http.Request form goreq.Request

First, thanks for creating the library.
Second, some of the libraries I'm using requires the standard http Request as  a parameter. I like how easy it is to construct a JSON request with goreq.  How would I go about creating a goreq.Request object then having that return a standard http Request? I would then passed the return object to the said library.

@rexposadasi it's not a bad idea. Can you provide a snippet about how you'd use goreq and third party libraries so I can get an idea how to implement the API?

I'm writing a library which accepts an http.Request, make the call, and does some metrics on it.  See this function signature.  That function accepts a standard http.Request because, while using something like goreq is great, i don't want to force users to do that in order to use my library.  I can see cases where some library creators feels the same way.  So I was thinking of something like this.
req := goreq.Request{
Method: "POST"
Uri: "http://localhost:8000/myendpoint"
Body: body,
}
// req.Standard is simply a reference to a  standard http.Request
simulate.MakeRequest(req.Standard)

@rexposadas I see where you're going and I have some questions though which may help to clarify the use case.
If your library does all the request handling  how do you plan to return the request handler to goreq for all the remaining processing (ie: response, headers, redirects, etc)??.
To give an example:
req := goreq.Request{
Method: "POST"
Uri: "http://localhost:8000/myendpoint"
Body: body,
}

// req.Standard is simply a reference to a standard http.Request
simulate.MakeRequest(req.Standard)

//If we do this, then the request will be triggered two times against the targer URL. Once by your library and then by goreq
res, err := req.Do();

I believe a pluggable/middleware solution is more efficient in this cases where you need to sit between the request and the response to do some processing rather than just delegating the request handling to the library. We've thought to add middleware support to goreq so we can encourage some other projects (like yours) to sit between requests (currently Go default http client doesn't provide this functionality) but we haven't found the necessity or the time to do it so far.
I'm not saying we couldn't or shouldn't do it, I'm just trying to find the best use case for our users whenever they need to use both libraries.

I see what you mean. I guess my usecase is not common. What I'm trying to do is measure that time of when a request gets called and when it returns.  I didn't want to delegate that work in the middleware since I'm trying to get a very accurate reading.  In this piece of code I am trying to guarantee that nothing happens between the time I start my timer, run a request, receive a response, then stop my timer. Using middleware to do that removes that guarantee.
But for all other things, I do agree that using a middle solution is the way to go.
Feel free to close this issue if you see fit.  I do not think a change on your side would be beneficial to your target audience.

Here is another situation of what I was thinking about..
http://golang.org/pkg/net/http/httputil/#DumpResponse
That standard package method accepts an http.Reponse, but I'm having difficulty using that library with goreq since goreq.Response cannot be passed to that method.
There are, at least, a couple of ways to tackle this situation:

add a method in goreq.Response which returns an http.Response
have a similar method to DumpResponse added to the goreq.Response object

@rexposadas you're correct. plz check out #85 and let me know your opinion so we can merge.

@marcosnils thanks for that.  I looked at #85. I think it's a step in the right direction. I would do something similar for goreq.Request.
i.e. having the ability to make use of http://golang.org/pkg/net/http/httputil/#DumpRequest

@rexposadas I've updated #85 with the ability to obtain the *http.Request with Goreq. Can you please check the PR and see if it sounds good from the user perspective?
Thanks!.

@marcosnils looks good to me. I can get a handle on the http.Request and http.Response, which was what I was after. Thanks for doing this.

closed by #85


Library name change request

Library repository URL
https://github.com/hafidhh/Callmebot-ESP8266

Hi @hafidhh. I am confirming your request.
Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will close this issue when it is done. You will get a notification from GitHub at that time.
After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

Done in https://github.com/arduino/library-registry/pull/2134#issuecomment-1333545426


[Scenes] Need to increase SceneTableSize attribute value to validate other functionalities like Add and Remove scene

Summary:
For the test cases like TC-S-2.2, TC-S-2.3, TC-S-2.4, and TC-S-2.5 we have multiple function like Add scene , Remove Scene, View Scene, Store Scene the Scene Table Size has to be more than zero to validate in cert test.
Feature description
...

Read SceneTableSize : ./chip-tool scenes read scene-table-size 1 1

[1685167609.521892][13200:13202] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0005 Attribute 0x0000_0006 DataVersion:<PHONE_NUMBER>
[1685167609.521932][13200:13202] CHIP:TOO:   SceneTableSize: 0

Add scene to the added group : ./chip-tool scenes add-scene 1 1 0 "scene name" '[{"clusterID": "0x0006", "attributeValueList":[{"attributeID": "0x0000", "attributeValue": "0x01"}]},{"clusterID": "0x0008", "attributeValueList":[{"attributeID": "0x0000", "attributeValue": "0x64"},{"attributeID": "0x0001", "attributeValue": "0x00"}]}]' 1 1

[1688464612.526900][8648:8651] CHIP:DMG: Received Command Response Data, Endpoint=1 Cluster=0x0000_0005 Command=0x0000_0000
[1688464612.526959][8648:8651] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0005 Command 0x0000_0000
[1688464612.527035][8648:8651] CHIP:TOO:   AddSceneResponse: {
[1688464612.527081][8648:8651] CHIP:TOO:     status: 137
[1688464612.527110][8648:8651] CHIP:TOO:     groupID: 1
[1688464612.527138][8648:8651] CHIP:TOO:     sceneID: 1
[1688464612.527166][8648:8651] CHIP:TOO:    }

Platform
raspi
Platform Version(s)
RPI4 8GB RAM
Anything else?
While trying to remove the scene before it is added DUT responses with status failure but for the same Test plan expects Success response.
In Test case 2.2 step 1b : ./chip-tool scenes remove-all-scenes 0x0001 1 1
Actual Outcome:

[1686815342.516889][12148:12150] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0005 Command 0x0000_0003
[1686815342.516902][12148:12150] CHIP:TOO:   RemoveAllScenesResponse: {
[1686815342.516908][12148:12150] CHIP:TOO:     status: 1
[1686815342.516911][12148:12150] CHIP:TOO:     groupID: 1
[1686815342.516914][12148:12150] CHIP:TOO:    }

Expected Outcome:

[1686815342.516889][12148:12150] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0005 Command 0x0000_0003
[1686815342.516902][12148:12150] CHIP:TOO:   RemoveAllScenesResponse: {
[1686815342.516908][12148:12150] CHIP:TOO:     status: 0
[1686815342.516911][12148:12150] CHIP:TOO:     groupID: 1
[1686815342.516914][12148:12150] CHIP:TOO:    }

Fixed by https://github.com/project-chip/connectedhomeip/pull/29569/files


oh-my-zsh not finding "/etc/paths.d/" for finding the Golang install path

I'm not entirely sure why, but when I did a fresh install of Golang on my computer, zsh (and particularly oh-my-zsh) would not be able to find the "/etc/paths.d/" path. This was trying to setup the PATH variables in .bashrc, .zshrc, and finally, .preztorc (Prezto worked). Oddly, however, Prezto uses zsh just like oh-my-zsh, which is why I find this strange that oh-my-zsh could not find it. Perhaps it is a bug?
-Stu

Please post your .bashrc, .zshrc and .zpreztorc files. I believe this is a bug with how we're dealing with PATH configuration in the zshrc template. Please check if you also have that line commented and comment it again if that's the case.

What OS and version is this?
Normally, it's not OMZ that's supposed to do the finding of the /etc/paths.d paths. Those /etc/paths.d paths are picked up by system-wide rc files that are run before your user init files and before OMZ is initialized. In OS X, it's /etc/zshenv for zsh, and /etc/profile for bash. (I think /etc/paths.d is an OS X specific feature, and not supported on other platforms.)
Marc, that line in the template seems like it should be fine, since it includes the existing $PATH at the end. That should already have the paths from /etc/paths.d in it. Maybe there's something else that's clobbering $PATH?
I'm running zsh and oh-my-zsh on OS X 10.9.5, and have a a line like that from the OMZ template in my zshrc. It's working fine with /etc/paths.d: the TeX and XQuartz paths defined using that mechanism are in my $PATH. (Though my ~.zshrc is one I wrote, not the stock one from the OMZ installation.)
[@ in /etc]
$ grep PATH ~/.zshrc
    PATH="/usr/local/bin:$PATH"
    PATH="$HOME/bin:$PATH"
    PATH="$PATH:$HOME/.gem/ruby/2.0.0/bin"
[@ in /etc]
$ ls /etc/paths.d
40-XQuartz TeX
[@ in /etc]
$ cat /etc/paths.d/*
/opt/X11/bin
/usr/texbin
[@ in /etc]
$ echo $PATH
/Users/janke/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/opt/X11/bin:/usr/texbin:/Users/janke/.gem/ruby/2.0.0/bin

You can use the omz_diagnostic_dump from diagnostics.zsh here to get a dump with the relevant configuration files and system info, except for .zpreztorc, which you'll have to add separately.

Oh, here it is, in the installer. The installer tool modifies that line from the zshrc template and replaces it with a static copy of the user's $PATH value at the time of OMZ installation.
echo "\033[0;34mCopying your current PATH and adding it to the end of ~/.zshrc for you.\033[0m"
sed -i -e "/export PATH=/ c\\
export PATH=\"$PATH\"
" ~/.zshrc

That's a bug. It will break any PATH settings done by upstream system-wide config files, so if they're set dynamically and relevant state changes, or new items are added later, they'll be missed.
This would break path discovery in the way @stuartweir experienced here.
I'm guessing thhere's nothing special about what Prezto does with paths vs plain zsh. I'll bet that Prezto fixed it here because installing it installed a new non-broken ~/.zshrc file (or reverted to the one Stuart had before the OMZ installation replaced it with a broken one). Just uninstalling OMZ would have had the same effect.
As a cheap hack to fix this particular issue, we could change the installer to leave an explicit :$PATH in the path it sets up, so it picks up any path entries added by the system-wide rc files. You'll end up with duplicate entries, but that's less bad than missing things.
For a longer-term fix, maybe we should reconsider how the installer deals with ~/.zshrc. As it is now, it completely replaces the user's existing zshrc so any settings there are lost unless the user manually copies them over. And they'd still have to know to undo this PATH change. Maybe OMZ should just add its template stuff and OMZ initialization call to a copy of the user's existing zshrc instead of starting from scratch.

Yep, I can reproduce. I did a fresh install of oh-my-zsh, and I ended up with a .zshrc that clobbers $PATH.
$ grep "export PATH" ~/.zshrc
export PATH="/Users/janke/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/opt/X11/bin:/usr/texbin:/Users/janke/.gem/ruby/2.0.0/bin"

Looks like this is a known issue, and there's existing discussion on it: #1359.

on my OS X I used
$ vim /etc/paths.d/go

and the file contained:
/usr/local/go/bin

I added this last path to my .zshrc and it worked.
here's what my .zshrc export looked like:
export PATH="/Users/myusername/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin"

All I had to do was append /usr/local/go/bin to the end of this path, and now Go works on oh-my-zshell. Here's what my .zshrc export looks like now:
export PATH="/Users/myusername/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/go/bin"

I wish OMZ would handle paths.d elegantly on Mac. Nevertheless @lborg019 solution worked.


Make pictures visible while adding their alt text

Is your feature request related to a problem? Please describe.
It would be nice if you could see the picture you are currently adding alt text to.
Original idea here: https://staging.bsky.app/profile/cooperstreaming.bsky.social/post/3jvsvboakec2i

Platform: iOS / Android 🙏

@renahlee I think this applies to desktop as well, see this example:

You can sort of see the picture behind the window there, but it would be nice to have a clearer view of it.

@jetpacktuxedo Ah! Thank you for flagging mobile web! I'd updated desktop web to look like the following but will go ahead and update my comment to reflect that 🙏

This appears to have been fixed. Tested on web (build version: 1.37.0), both the "ALT" menu and "Edit" menu show an alt text field alongside the image:

I also checked Android (build version: 1.37.0 (23) production), and its "ALT" menu does the same thing (the "Edit" menu on Android doesn't have an alt text entry box).

Yep should be all set. Cheers


go install: no install location for directory

Hello,
I am using Linux mint and would like develop an application using goqt.
I followed the steps as mentioned by visualfc, in the process of doing so i am getting the following error
mint@mint-OptiPlex-790 ~/go/goqt/ui $ go install
go install: no install location for directory /home/mint/go/goqt/ui outside GOPATH
For more details see: go help gopath
mint@mint-OptiPlex-790 ~/go/goqt/ui $
I have tried different methods as mentioned in various blogs,

such as setting the GOPATH and GOROOT
Setting GOBIN
Enabling "CGO_ENABLED" manually from shell and also setting / resetting CGO_ENABLED of go env

None of the above worked for me, kindly let me know how i can proceed

I am on OSX and am getting an error also
go install -v
github.com/visualfc/goqt/ui
github.com/visualfc/goqt/ui
ld: warning: directory not found for option '-L../../bin'
ld: library not found for -lqtdrv.ui
clang: error: linker command failed with exit code 1 (use -v to see invocation)


🚸 Deprecate ln.track() in favor of ln.context.track()

repurpose the static class run_context as Context
remove parsing of legacy nbproject_id

https://www.notion.so/laminlabs/Prettier-ln-track-0cee883dee2d4280b31b54309236901b

⚠ At this point in time in the PR, all renaming is done, and I'm actually starting to introduce the new behavior.


reduce logging level for some status things

Lowering the logging level from INFO to FINE for a few items.
The noisiest one is the 'not matching slave' message in mesos environments
where only a few of the slaves are jenkins candidates.  The non-matching ones
dump many large json objects into the logs which really falls more into
the debugging camp hence the lower level

going to move to master branch


Simplify possible inputs for structure function calculations

The goal is to allow the user only to specify a list of measurements to get a reasonable structure-function.

Allow user not to specify input times - assume equidistant times between measurements
Allow user not to specify errors - compute assuming that errors are zeros
If the user supplies a single value for an error, assume that it is the same error that needs to be applied for all of the measurements
Allow user not to have to supply band or id of lightcurves (more broadly - it is possible to operate on user-specified array inputs )

Just to make the pieces easier for me to track, I'm going break this up into a few smaller PRs. But I'll associate this issue with each of them.

[ ] Allow user not to specify input times - assume equidistant times between measurements

[ ] Allow user not to specify errors - compute assuming that errors are zeros

[ ] If the user supplies a single value for an error, assume that it is the same error that needs to be applied for all of the measurements

[ ] Allow user not to have to supply band or id of lightcurves (more broadly - it is possible to operate on user-specified array inputs )

After conversations with @nevencaplar and @dougbrn there will be some additional work necessary to accomplish the desired result here. Note that 2 PRs (#84 #87) were created to allow users to pass None and scalar values for time and error, but that doesn't actually satisfy the initial request. (Those PRs have been merged and can be used directly, but we can do better)
Neven described the ideal desired result as follows:

If I was an user and did not know anything, I would assume that I can pass three lists, that the first one is time, second one is flux, third one is errors. If I pass only two, time and flux. If I pass only one, it is flux. Unfortunately, that is not how python thinks.

So to clarify, we should be able to use the function equally well in the following three ways:
sf2(flux=list_of_flux)
sf2(flux=list_of_flux, time=list_of_time)
sf2(flux=list_of_flux, time=list_of_time, err=scalar_or_list_of_errors)
Doug pointed out that the current implementation in Ensemble and TimeSeries doesn't permit the user to avoid specifying time, error, band, id, etc... Some reasonable set of additional flags or a refactor would be needed so that the user can do that. TimeSeries has the most straightforward way for a user to not provide time or error, but to do so, it seems that you have to recreate the TimeSeries object without time or error values - not a very dynamic way of working, and doesn't make this easy.


Cplex solver specific options

I really appreciate the new feature to set solver specific options without editing the library. However, the subclass "configure" method is never called because of the constructor call in line 75.

Didn't quite think that through... I'm working on an alternative design.

Now there is a solution that works.
I've modified ojAlgo to enable this new feature.
When you construct your ExpressionsBasedModel you may call theModel.options.setConfigurator(...). If you set that to an instance of SolverCPLEX.Configurator it be used/called by the SolverCPLEX just before executing the solver.

I've suspected that a redesign of ojAlgo is required. The new design is working well now.
It is a great improvement to set the settings now directly without editing the extension file.


Emacs all the icons fonts

Motivation for this change
all-the-icons is an Emacs package which needs some fonts to work. This PR adds the necessary fonts as propagated build inputs of this package.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

The problem is that Emacs won't find the fonts I add that way. How can I make Emacs find fonts in the closure of its store path?
/cc @ttuegel @vcunat

@DamienCassou: it's possible to use something like pkgs.makeFontsConf and wrapProgram --set FONTCONFIG_FILE, though it will probably need some work for it to load the system default and only extend it by some font dirs (and even more to e.g. cover the case of user setting her own $FONTCONFIG_FILE).

@DamienCassou are you interested in pursuing this feature?

No.


ci(check-urls): use a matrix to speed-up execution

What does this PR do?
Improve repo
For resources
Description
The matrix strategy creates 10 max-parallel workers with a disabled fail-fast parameter
Examples

Before: https://github.com/davorpa/free-programming-books/actions/runs/2999590952
After: https://github.com/davorpa/free-programming-books/actions/runs/3007199364

Running the workflow when -langs.md or -subject.md files are involved could exhaust the runner execution max-time like sometime happens in the past (https://github.com/EbookFoundation/free-programming-books/actions/runs/2924594027 max is 360min).

Using this implementation... the elapsed time is of the longest execution time, normally no more than 30min on the worst of cases.
Moreover, we can meter how much time awesome bot consumes in each check.
Checklist:

[x] Read our contributing guidelines.
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

there must be some limit on how many threads the repo can use as a whole. Worrying about load in October

there must be some limit on how many threads the repo can use as a whole. Worrying about load in October

About max-parallel matrix strategy param:

The maximum number of jobs that can run simultaneously when using a matrix job strategy. By default, GitHub will maximize the number of jobs run in parallel depending on the available runners on GitHub-hosted virtual machines

Is it 10 well or better leave GitHub to decide?
Moreover... setting max-parallel: 1 it will the same what we have now :wink: but with a bit penalization of 5s (I'm not sure at all) wasting on warm up the job container.

Investigating if

https://github.com/davorpa/free-programming-books/blob/f9be34faa39faafe64bfb2c5c4b118bbfa8761c9/.github/workflows/check-urls.yml#L59-L67
needs a precheck when no files are changed.

Investigating if needs / how to add
<EMAIL_ADDRESS>a precheck when no files are changed. It could crash if spawned jobs are 0. It could be related with #7059 but addressing concurrency

Fixed!!!
The workflows runs testing that:

Failing: https://github.com/davorpa/free-programming-books/actions/runs/3031689939
Working after apply 3e9a1e69778e91da5ceec71e649dba4be5bd194a: https://github.com/davorpa/free-programming-books/actions/runs/3031721462

Reviewers welcome!

Conflicts are with #7096. Preserve it side in concurrency config

This seems like it could be a really nice improvement. I like that you are not failing fast so a user can see all issues right away. In looking at the workflow results I am a bit confused though.
Original Workflow

Matrix workflow

As you can see, the new workflow shows a total time that is nearly 3 times as long as the original. With that said, the individual times add up to 30s so maybe this is misleading on GitHubs part. Additionally, this is only running a single test, so not really seeing the full benefits of the matrix.
As far as I can tell, this is, at the very least, working as expected. Would it be worth making some test PR's that trigger as many workflows as possible to get a better gauge what improvement to execution time this makes? Admittedly, I have not used this matrix feature before, so let me know if there is anything else I should look into/test on my end.

is this ready?

is this ready?

Yes, developing is ready 😉


Disable snapshot shims by default

Fixes #3166.
This disables the shims for Spark snapshot versions by default.  The snapshot-shims profile must be explicitly specified to include snapshot shims. After this change, RAPIDS Accelerator source should continue to build even after new Spark versions release since it won't try to pull Spark snapshot artifacts by default.

build


Rename IBEX to CVE2

@christian-herber-nxp - this is done, isn't it?

This task seems to be a duplicate of #54.


the new parameter in print_tensors_in_checkpoint_file breaks old code

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): v1.6.0-0-gd2e24b6039 1.6.0
Python version: 3.6

Describe the problem
The function print_tensors_in_checkpoint_file in tensorflow/python/tools/inspect_checkpoint.py is changed in this commit, a new parameter all_tensor_names is added.
This change breaks the old code using this function, including the examples in the Programmer's Guide.
I believe an elegant solution is setting the default value of the new parameter all_tensor_names to False

I will create a pull request to solve this.


Update: add await before prisma update promise

Yet another fix to documents.
Describe this PR

Changes

What issue does this fix?

Any other relevant information

Thanks @immorez - we'll include this explicit await to make things clearer.


UI: Display Resubmission Reason in Data Table

As an ECMPS Admin, when I select a record to require resubmission I want any notes written in the reason box to be saved and displayed in the corresponding record row of that table.
Given a user has selected a record to require resubmission
When a user enters notes in the require resubmission pop out and clicks save
Then the note will be displayed in the read only view pop out of the corresponding record

Display Resubmission Reason in Data Table Cert Event


Tweak scoring?

I'm getting some very unlikely false positives, even after changing the matching to visual similarity only.
Is there a way to adjust the visual similarity matching? If not, would you mind adding this ability?
Thanks!

Due to the nature of the visual matching, there will be images which, to the user, are clear false positives. Yes, you can tweak the process and change thresholds but it'll always be a balance between limiting false positives and missing actual duplicates, and that tweaking is difficult enough that I think it'll just burden the user with non-obvious options.
Unless it's an actual bug or some weird corner case, of course. I'd have to see the image pair in question do determine that.


[doc] dispatchChangeEvent -> changed

I think this is the only place in code that documents dispatchChangeEvent, but I think it means "changed" instead.  I also created  https://github.com/openlayers/openlayers/compare/master...nyurik:patch-1#diff-946befd18169a7196da938115c099af4  but I'm not sure if that's an autogenerated file or not.
P.S. It would be great to make it into a doc link instead of simply text.  Not sure what the doc semantics would be.

Thanks for the pull request; you can create a link by using @link:
{@link module:ol/Observable~Observable#changed}

@fredj thx, fixed.

thanks @nyurik


[Bug]: bcp giving "An existing connection was forcibly closed by the remote host." error

What happened?
I am loading a large amount of tables in a for loop with bcp. It is working well most of the time but sometimes errors out (on the same tables).
My powershell commands, on a Windows server, look like this:
-- data export command

bcp "<SELECT * FROM MYDB.MYSCHEMA.MYTABLE>" <FILEPATH> -c -t"<CUSTOM DELIM>" -r"<CUSTOM NEWLINE>" -S <RDS ENDPOINT> -U <USERNAME> -P <PASSWORD>

--data import command

bcp <MYDB.MYSCHEMA.MYTABLE> in <FILEPATH> -c -t"<CUSTOM DELIM>" -r"<CUSTOM NEWLINE>" -S <BABELFISH ENDPOINT> -U <USERNAME> -P <PASSWORD>

I can't see anything in those tables that seem special, but it consistently errors on the same ones. Does anyone have any knowledge of what might be causing this?
Version
BABEL_3_X_DEV (Default)
Extension
None
Which flavor of Linux are you using when you see the bug?
No response
Relevant log output
Starting copy...
1000 rows sent to SQL Server. Total sent: 1000
SQLState = 08S01, NativeError = 10054
Error = [Microsoft][ODBC Driver 17 for SQL Server]TCP Provider: An existing connection was forcibly closed by the remote host.

SQLState = 08S01, NativeError = 10054
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = S1000, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Text column data incomplete
SQLState = 08S01, NativeError = 0
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure
SQLState = 08S01, NativeError = -2147467259
Error = [Microsoft][ODBC Driver 17 for SQL Server]Communication link failure

BCP copy in failed

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct.

Side note, is it possible to load the data via psql's \copy command, then move the data to the Babelfish DB?

@calmitchell617 can you please provide more details like the table DDL and also check if there was a crash and provide it's stack trace along with any logs you can capture.

Yes, I will provide as much as possible.
This work is for a 3rd party client - I just asked them what is OK to share. They will probably want certain things shared privately, can you please let me know how that can be accomplished? Email?
Once the problem is diagnosed, I would be happy to post a generalized example for the benefit of the viewers of this issue, but like I said, I'm not sure what the issue is, so cannot generalize it at this time.

@KushaalShroff they said it is OK to share DDL privately, as well as the stack trace.
How can I get that to you? If you want to send me an email, the contact form at https://sqlpipe.com goes to my inbox.

@calmitchell617: Are you using Babelfish on Aurora PostgreSQL? If so, you can open a support ticket with AWS and share the materials there.

Yes, this is on Aurora PostgreSQL. Should I open the ticket on the customer's account, or in mine?
My account does not have paid AWS support, but I think the customer does.

You can create with customer's account id

Hello @calmitchell617
Did you manage the issue? I am getting exactly the same error when copying large data. I am thinking about exceeding destination memory, but not sure.


{AKS} az aks update: Add --network-plugin to support updating cluster networking settings

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

az aks update --network-plugin azure
General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

AKS

this does not include a live test because the toggle is not enabled right now. I will come back and add a live test when we flip the toggle, next week?


Implement setNativeProps() to allow use in TouchableHighlight, etc

Submitted a PR: https://github.com/react-native-community/react-native-linear-gradient/pull/118

Fixed it 1.5.14


also override GraphRepositoryFactory.getQueryLookupStrategy(key)

GraphRepositoryFactory.getQueryLookupStrategy(QueryLookupStrategy.Key) to compensate shortcoming in sd-commons

Spring Boot wrongly pulled in SD-Commons 1.9.1.RELEASE instead of 1.10.0.BUILD-SNAPSHOT


ttl may be too short

Hello, I facing the "ICMP time exceeded in-transit"(tcpdump) message from the server that forwaring packet to  phantun_server. I saw from source packet.rs that ttl was fixed at 32. Maybe ttl can be turned to a configurable option? Thanks for the great job!

I can change the value to 64 or 128 by default. Does making it tunable makes sense? It was an arbitrarily chosen value anyway...

Actually, making it 64 same as net.ipv4.ip_default_ttl will be enough IMHO :)


Editor: In-Node Editor

Enable a node to own an in-node editor, for defining composite functions or other purposes.
Expected behavior
When the (outer) node is double clicked, an inner editor opens and shows the containing graph. That can be nested. (不禁止套娃)
Notes
Grapycal should provide an interface to node developers to take use of this feature i.e. make a node to contain a graph.

My opinion:
While it's natural to think that the in-node editor represents the definition of the outer node in the form of a composite function, the relationship between the editor and the node should not be restricted to that. Instead, it can be one of:

definition of a composite function:
Just like the current function definition scheme, but the function is defined in an in-node Editor in a FuncDefNode.

definition of a graph template:
A graph template is defined inside a GraphTemplateNode, which has a name field and an in-node editor where the graph is defined. The user can type the template's name to create a copy of it on the current editor.

anything that the node creator wants. (We'll find more use case in the future, I believe)

So the API should be general enough to enable all above. My proposal is to make the in-node Editor a control. That way, a node can own multiple in-node editors.
The SObject structure would be:
Node - InNodeEditorControl - Editor - (Content of the in-node editor)

About in-node edtitor:
I think it would be more general if we see it as a sub-workspace. That way the full power of workspace can be leveraged and new features, including fixes, will be available automatically.
Providing this feature to node developers as a new component seems reasonable, as it follows our old practice to provide additional functionalities to node, but I suspect that it cannot be implemented as an ordinary component.
About multiple editors on a single node:
Though we decided to provide it as a component, I think we should restrict the use of it to 1 editor a node for the following reasons:

Though it is achievable, since we provide it as a component, it complicates the user interaction. If there's at most 1 editor per node, opening the editor can be a single action. If there're many, however, users must identity which to open, which further indicates that user may need to give each editor (in a node) a unique name.
Multiple editors will be useful only when a node wants to have multiple workspaces for different tasks. However, such behaviour can be implemented with nesting, which sub-workspace already provides.

Desired functionalities

Node developers can decide if they want to have in-node editor on certain node. (It becomes natural if we provide it as a component)
Nesting. A node in an in-node editor can alao have its own editor.
Subworkspace-specific nodes. Node developers can provide additional nodes that's only available inside the sub-workspace.
Local namespace. A sub-workspace should have a local namespace from users' (not node developers!) perspective. Therefore local variables, local functions are available.
In/out mapping. Node developers can somehow connect In/Out port into its sub-workspace, so the nodes inside sub-workspace can drive/be driven by ports on outer node. (This can be provided as subworkspace-specific nodes)
No presumed semantics. Instead of restricting the usage to certain situation, we only provide the functionality to node developers. Developers should decide what it is used for and what the sub-workspace represent.

About implementation
I believe that figuring out the things that forms a workspace is important. So we should first ask: what are the essential components of a workspace? And how do they interact to provide what we have in a workspace?

Agree.
Let's clarify the terminology of Workspace and Editor first. In the current implementation's logic,

Workspace process (workspace.py) is the unit of Grapycal runtime, analog to a Python Interpreter process.
Workspace SObject (workspaceObject.py/workspace.ts) is an SObject exists per workspace process, managing the states or communication that is global for the whole workspace process. In terms of the SObject tree, it is the only child of the "root", and is parent of a Settings, a WebcamStream, a Sidebar, an Editor (the main editor), a LocalFileView and a RemoteFileView. The Sidebar is where preview nodes locates. (The node list at the left of the UI)

The  WorkspaceObject.build() looks like:
class WorkspaceObject(SObject):
    frontend_type = 'Workspace'

    def build(self):
      self.settings = self.add_child(Settings)
      self.webcam = self.add_child(WebcamStream)
      self.sidebar = self.add_child(Sidebar)
      self.main_editor = self.add_child(Editor)
      self.file_view = self.add_child(LocalFileView,name='Local Files 💻')
      self.add_child(RemoteFileView,url = data_yaml['examples_url'],name = 'Examples💡')

Editor Sobject (editor.py/editor.ts) represents a plane for Nodes and Edges to be placed on. Adding, removing, copying, and pasting nodes and edges are done on the level of Editor.[*1] Currently, the Workspace SObject have only one Editor (main editor) and all the nodes (except preview nodes) and edges is direct children of the main editor.

Back to the question: What level of functionality do we want an "In-node editor" have? Should it be an Editor, an WorkspaceObject, or something between?
[*1]: The code for delete is incorrectly placed at Workspace instead of Editor currently. This is to be fixed.

My first thought was it should be just an Editor (that's why I named the issue so). But maybe its nicer to treat in-node editors as subgraphs and associate each of them to a .grapycal file, just like Workspace.

What about the inspector at right? Is it a part of the main editor?

No. It is pure frontend thing

It's outside of the editor in the frontend.
The editor is the central draggable area


Is it possible to replace Firebase with any other opensource tool?

Hello Team, Thank you very much for the project.
Is it possible to replace Firebase with an open-source tools like appwrite, feathersjs, etc?

Any update on it?

No response or update from the team. Hence closing it.


Description of the method

Hi @kmammou,
This is a great framework that works great in many contexts. I would like to undertstand the inner workings better and was wondering if you have a publicly available version of the book chapter that you can share. If you don't want to share it here, please also feel free to send it to my email madvncv at gmail dot com.
Thank you!

Hello, I have the same issue, have you found the whole version?

I am currently refactoring the code base for V-HACD and when it is complete I will make a slide presentation of the algorithm to go along with it.


Feature/msal migration

Overview
Changes the authentication implementation from hellojs to msal
implements Msal through a provider to be used in the graph client
Known Issues

Login via redirect on edge since you would have to close the dialog on your own when you use the popup option.

@jobala We do not want to duplicate the GE V1 MSAL code.  We want to use the Graph JavaScript SDK 2.0 with the ImplicitMSALAuthProvider because that code has been written to handle incremental consent, Multi-Factor Authentication, Conditional Access and other Identity Platform related exception cases.  We do not want to have to re-write that code again in Graph Explorer.  Additionally we want to help to validate the Microsoft Graph Javascript SDK by being a consumer of that library.  /cc @MIchaelMainer  @bettirosengugi  @cwahome @jthake-msft

@darrelmiller I don't understand the requirements for this too well and I am not familiar with SDK 2.0 so I am going to trust your opinion.

Please implement MSAL the same way it was implemented in GE classic.

Classic did not use the graph sdk so there was no use for an auth provider.

👍 This works well for me on edge and chrome.


Command executions should be logged as DEBUG instead of INFO. In syst…

…ems where INFO is being used to log informative messages like 'user logged in'.A loop with redis for e.g. in a background-process will pollute the logs extremely.
Commands should be saved as DEBUG logs entries rather than INFO. As INFO is for informative messages and DEBUG for debugging purposes.
A loop with a lot of redis calls (a daemon for example) could easily pollute the logs with command execution messages.
While the next level is WARNING a mesage like "background loop process started" is not WARNING and not DEBUG, i consider that as an INFO log entry.
It would also be consistent with Doctrine for example who log their commands as DEBUG.

I agree the log level is too high but that probably belongs in a major release as it's kinda breaking.

However, 876f722 should not be part of this PR IMO

Yeah sorry, i kinda messed up the pull request somehow :(

@FuzzyPones can you rebase the PR and remove the extra commit?

Ok should be better now i hope.

Manually merged, thanks!


Create user facing guide

The spec is focused (properly) on what implementations must and must not do. It's hard for a user trying to understand how they can leverage a ServiceBinding to do work within their cluster. We should create a user guide that gives a non-normative overview of the concepts and capabilities provided by the spec.
Topics to cover include:

service and application references

using a label selector in the application reference
limiting which application containers are bound

mapping custom values in the projected secret
defining environment variables (and when not to)
consuming a binding within an application
cross-namespace services

Closing in lieu of finer grained issues.


additionalType

Hello all!
I'm in the process of allowing making a .eln that contains both experiments and resources (the two main entity type in elabftw). Previously, it was only one or the other.
In order to convey that information, I chose to use the additionalType property of the @type: Dataset.
So during import, I look at the additionalType property , to figure out if this node describes an experiment or a resource (which in elab can be anything like an antibody or a microscope).
The value could simply be: "experiments" or "resources". But if I create this issue it is to discuss with you what could be the best approach regarding the value.
I'm thinking of using http://semanticscience.org/resource/SIO_000994. And the code basically is: if it's that URI, it's an experiment, otherwise it's a resource. There are many others to choose from: https://lov.linkeddata.es/dataset/lov/terms?q=Experiment
So if on your side you've already digged into these aspects, please let me know here so that I can use the same as you!

I can give some input on how we currently use additionalType in the Kadi export. We allow users to (optionally) specify an arbitrary type value within the basic record metadata, such as "experiment", "device", "document", etc., which we just put into additionalType as is. In some sense, this can be seen as an additional keyword with some inherent semantics.
That being said, these types don't follow a standardised vocabulary. Therefore, if we settle on something here, we would probably need to either move this type somewhere else or remove it from the export altogether. I don't have strong feelings about it either way though. For us it mostly depends on what the import/export requirements of other systems are. In any case, I think that full interoperability of such types will be tough to achieve across all systems.

Oh so you let users add anything in there? Or is there an enum/list they can choose from?

Yeah, the former.

Why? We both independently came to the conclusion that additionalType was a good attribute to categorize further the Dataset we have. Your usage is basically the same as mine, except you're more libertarian on the value. What about import? Do you use this field? If yes, then how do you deal with arbitrary text?

Sorry, I was unclear. I just meant in case we ultimately settle on a fixed vocabulary. Of course if we (in Kadi) can keep it as is that would be ideal :) Regarding the import, I just checked and seems like we don't use it at all yet. However, I guess since we don't have any restrictions, there shouldn't be anything to deal with regarding the import.

Well, that's why we're discussing it now! Also, I'm thinking of the import interface allowing to force the resulting "type". At the end of the day, asking the user what they want is an acceptable shortcut.

Of course! And the option of letting users customize the import (or even export) could indeed be a solution (or at least a good workaround), not just for the types.

Do you see any overlap with genre? experiment was already one of the values for it we decided on during the last meeting, resource might be another?

@FlorianRhiem I forgot about it!
So I'll use genre instead of additionalType, similar to what SampleDb does. My genres will be one of:

experiment
resource
template (maybe protocol / experiment template ?)

Just my 2ct: I understood it at the last meeting as @FlorianRhiem: genre for the subtype.

You are right, I just checked my old meeting notes and genre was indeed already suggested for this, as an optional property with a (most likely) fixed selection of strings. I guess this still leaves the question of whether additionalType can also have a place in the specification or if it can just be left as an ELN-specific thing :thinking:

Following @SteffenBrinckmann comment on #103, @type MUST be a single string value while additional types should go to genre.
I understand the point of limiting variances.
However, @type is rather central in any RDF/JSON-LD reasoning, validation and framing operation.
A workaround would be to alias genre as @type ìf required by an interpreter
{
  "@context": [
    "https://w3id.org/ro/crate/1.1/context",
    {
      "genre": "@type"
    },
    "type": "schema:Dataset",
    "genre": "ex:CustomType"
  ]
}

In this case it would be helpful to allow genre to by an array of IRIs. This would allow the TheELNConsortium to specify a list of common types while vendors can add more specific subtypes to persist internal classification.
{
  @context": [
    "https://w3id.org/ro/crate/1.1/context",
    {
      "eln": "https://w3id.org/TheELNConsortium/",
      "elabftw": "...",
      "osw": "https://opensemantic.world/id/"
    }
  ],
  "genre": [
    "eln:Experiment",
    "osw:Category-3AOSW0e7fab2262fb4427ad0fa454bc868a0d"
  ]
}

Otherwise additionalType IRIs may be the right location for those IRIs

I suggest moving this into a new issue rather than resurrecting this old (closed) one :P

created https://github.com/TheELNConsortium/TheELNFileFormat/issues/105 from message above.


fix: use docker-compose shell command

Description
This is a very small modification in your documentation about how to run a validator node by using docker-compose. It is sudo docker-compose up -d not sudo docker compose up -d that let me so confused.  And I cannot run it step by step, for example:

## Prerequisites and Setup 3. -  I don't know where genesis.blob is.
docker-compose.yaml - This file also does not have a href link. I have to find it for a long time or search it in your repo.

Whatever, In general, I feel that the reading and operational experience of the document are not good.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[x] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

nope

docker compose is correct for v2, isn't it? Using the - is v1?

docker compose is correct for v2, isn't it? Using the - is v1?

Yep, I think you are right. And I will try to use Docker Compose version v2.17.2 to do it once again. thanks for your reply.

But it would be best if you guys told users like us that documentation used docker-compose V2 not v1. thanks very much.


Added Dropbox version 119.4.1772.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Have you tested your manifest locally with winget install -m ?

Microsoft Reviewers: Open in CodeFlow

Can you take a look at the description?  team and world have strange characters
Organize all your teamÃ¢â‚¬â„¢s content, tune out distractions, and get everyone coordinated with the worldÃ¢â‚¬â„¢s first smart workspace.

Sorry about that, looks like I have my encodings messed up somewhere again...


[Documentation] - Add AWS lambda deployment documentation

I was wondering if safe-settings can be deployed on AWS lambda, since it is based on probot I assume this is possible, for the triggers, it is just matter of redirecting the webhook from the app to the lambda. Thanks in advance

I'd be interested in a lambda deployment as well. Would this be possible in the future ?
cc: @decyjphr

Hi, I have added the instructions for AWS Lambda deployment to #194. You can see the instructions here.

@chitopunk @nitrocode:
I also found it hard to figure out how to properly install and package this in something deployable with our own deployment settings while still being able to easily upgrade the version of Safe-Settings. Instead of cloning the repo I added it as a dependency and modified the handler.js to reflect this.
I used the provided instructions (mentioned above) and the AWS SAM CLI to deploy this as a Lambda function. I put up the following repo as an example of what my real repository looks like: https://github.com/anderssonjohan/example-safe-settings-sam-app
It also has a workflow file that can be used to manage the secrets and deploy from GitHub Actions.


ValueError: Protocol message RewriterConfig has no "layout_optimizer" field.

I just start learning tensorflow object detection API.And now,I can use the train.py script to train my model,and use the eval.py script to evaluate normally,but when I use the export_inference_graph.py script to export .pb file,the following error occurred.my tf version is 1.4 and python version is 3.5,ubuntu14.04.thank you very much.
Traceback (most recent call last):
File "export_inference_graph.py", line 110, in
tf.app.run()
File "/home/yj/anaconda3/envs/tensorflow3.4/lib/python3.4/site-packages/tensorflow/python/platform/app.py", line 48, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "export_inference_graph.py", line 106, in main
FLAGS.output_directory)
File "/home/yj/anaconda3/envs/tensorflow3.4/models/research/object_detection/exporter.py", line 427, in export_inference_graph
input_shape, optimize_graph, output_collection_name)
File "/home/yj/anaconda3/envs/tensorflow3.4/models/research/object_detection/exporter.py", line 391, in _export_inference_graph
initializer_nodes='')
File "/home/yj/anaconda3/envs/tensorflow3.4/models/research/object_detection/exporter.py", line 72, in freeze_graph_with_def_protos
layout_optimizer=rewriter_config_pb2.RewriterConfig.ON)
ValueError: Protocol message RewriterConfig has no "layout_optimizer" field.
I guess I installed a wrong protobuf version,but I tried 2.6.0 2.6.1 3.5.1,and the same error occured.

@Geoyi : This saved my day too :)

File "C:\Users\user\AppData\Local\Programs\Python\Python36\models\research\object_detection\export_inference_graph.py", line 119, in
tf.app.run()
File "C:\Users\user\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\platform\app.py", line 48, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "C:\Users\user\AppData\Local\Programs\Python\Python36\models\research\object_detection\export_inference_graph.py", line 115, in main
FLAGS.output_directory, input_shape)
File "C:\Users\user\AppData\Local\Programs\Python\Python36\lib\site-packages\object_detection-0.1-py3.6.egg\object_detection\exporter.py", line 427, in export_inference_graph
File "C:\Users\user\AppData\Local\Programs\Python\Python36\lib\site-packages\object_detection-0.1-py3.6.egg\object_detection\exporter.py", line 391, in _export_inference_graph
_write_frozen_graph(frozen_graph_path, frozen_graph_def)
File "C:\Users\user\AppData\Local\Programs\Python\Python36\lib\site-packages\object_detection-0.1-py3.6.egg\object_detection\exporter.py", line 72, in freeze_graph_with_def_protos
rewrite_options.optimizers.append('pruning')
File "C:\Users\user\AppData\Local\Programs\Python\Python36\lib\site-packages\google\protobuf\internal\python_message.py", line 484, in init
field = _GetFieldByName(message_descriptor, field_name)
File "C:\Users\user\AppData\Local\Programs\Python\Python36\lib\site-packages\google\protobuf\internal\python_message.py", line 548, in _GetFieldByName
(message_descriptor.name, field_name))
ValueError: Protocol message RewriterConfig has no "layout_optimizer" field.
I'm still getting this error :(

@lekshmi17
me too getting the same error
did you figured it out?


Update and rearrange docs + add info on releasing

There were some items in CONTRIBUTING.md that were incomplete, and
some items in README.md that needed to be moved to CONTRIBUTING.md.
Closes: #1316

I likely went overboard on the detail, but I'm not sure. Let me know what you think; I'm happy to prune when+where we think is appropriate.
Part of me wonders if we should remove all of the detailed git usage documentation from contributing. If we're going to have it though, it needs to be more complete than it was before.


#27996 @include adding extra space/line break to content

The pull-request contains the fix for #27996
The main idea is to remove extra line break related to the added path comment during view rendering.
This fix should not affect any line breaks which doesn't relate to added path comment.
I personally don't like the following things in the fix.

If we change a form which is used to represent a path in compiled view, we should not forget to fix a rendering as well (I couldn't write a test for it, it looked quite complicated)

Totally we pass through a view 2 times, the first time when including the compiled view, and the second time when checking if it ends with path comment, probably it could be optimized and done with a single pass.

I appreciate if you could advise me how to improve it.

I'm not sure this is worth fixing? Should one blade component really be dependent on there not being any space rendered after another Blade component?

@taylorotwell IMO yes - here's the simplest illustration why:
This blade code renders a partial with an inline element:
@each('widget', $widgets, 'widget')

Before 5.8:

Since 5.8:

There are times when whitespace in HTML matters.

Rather than wrangling around with the file contents themselves, maybe there is a simpler way to approach this? Could we encode the original file path in the cached file path, perhaps where the cached file path is a base64_encoded version of the original file path? Or some approach like that. For now, I have disabled this feature on 5.8.

Closing since #28117 was merged.


add contiformer implementation

implementation of contiformer.
add mask time series dataset and model for irregular time series modeling.
add configs for both regular time series and irregular time series.

@microsoft-github-policy-service agree company="Microsoft"


Request for improvement of the problem

[As we're using a translator, we ask for your understanding in advance as the context may not be smooth]
This plug-in has helped me a lot in listening and organizing. But I haven't used it for a while, and after a long time, I've confirmed that it doesn't function properly.
Previously, I used Obsidian 1.5.4, and recently I'm using the last updated version.
I made the following changes in the settings,

If it's the way it is, we're faced with a problem where a preview should come out, but it doesn't.

Is there anything you can help me with on these issues?

Hello, sorry for the late response. I was away from the computer for two weeks.
So the plugin used to work with multiple translations before, but after updating to the newest version, the linking stopped working?
I have tried using two transactions myself, and it seems to work fine, so it is weird that it stopped working for you.
What is the file structure of your vault? Have you changed something recently?

I'm sorry for the late confirmation and response as well. The approximate folder structure I'm using is as below, and I haven't changed it since I used that plug-in in the early days.
I used the plug-in until Obsidian 1.5.x, but after 1.6, I didn't use it. But when I tried to use it recently, I left an issue like this because it didn't work.
Is there anything I can try to change in my folder structure? If so, I'll give it a try.
Thank you for your service.

Strange. The problem is probably caused by some change in the plugin, but I don't remember any change that could affect the linking.

So you are using 3 different translations? What about the other 2, does the linking work for them or is it broken as well?
If it doesn't work for any of the translations, try disabling the "use multiple translations" option and test if the linking works.

This way we shall be able to determine if the problem is related to the multiple translations usage or not.
And what version of the plugin are you currently using? You can see that in the settings:

First of all, I'm sorry for the late confirmation. I don't get access to GitHub often, and the smartphone app doesn't alert me, so I only checked it now.
I checked the version after I updated it to the latest one.

It doesn't pop up even if you don't select multiple translations, but there might be a path problem. For example, there are three folders called "Genesis," so I wonder if it doesn't pop up.

Hi, the version number looks good.
However, I'm afraid I can't provide much help without more details, as I would just be guessing what could be wrong. I'm not familiar with alphabets other than Latin, so the issue might be related to missing spaces or something similar. Having three "Genesis" folders could also cause problems, but I'm not certain.
I recommend the following steps to help pinpoint the issue:
Create a new vault with just a few Bible files and a simple folder structure. Test if the plugin works. If it doesn't, try adding a space between the book name and chapter in both the files and the Bible linker command.
If the plugin works with the setup from step 1, gradually adjust it to match your current setup in the main vault. When the plugin stops working, you'll have identified the problem.


504 copy paste plugins inside ckeditor refer to same instance

This is fixing a severe bug caused by pull request 569. In pull request 569, after the referenced plugin is copied  successfully, the post_copy method is removing the other child plugins of the plugin we are pasting into, because the other child plugins are not inside the plugins_ziplist provided in the arguments of the post_copy method. This fix is including the existing plugins as well, so they are not touched by the post_copy method.

Codecov Report

Merging #572 (d9266be) into master (1221448) will decrease coverage by 0.23%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   72.72%   72.49%   -0.24%
==========================================
  Files          19       19
  Lines         825      829       +4
  Branches       90       91       +1
==========================================
+ Hits          600      601       +1
- Misses        200      203       +3
  Partials       25       25

Impacted Files
Coverage Δ

djangocms_text_ckeditor/models.py
80.00% <28.57%> (-2.90%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1221448...d9266be. Read the comment docs.

Looks Good! :+1:

@nichoski do you think, given what we've seen happen here, that a test case could be written for this?

@marksweb yes, it's the least I could do. I just added a test case to this.

This was merged into master, but I don't see it in any of the releases. Is this planned to be added in a new release? Or is it already added and I have issues finding it?


SwipeRefresh does not work with a child of type Column()

Describe the bug
I'm presenting a screen with data on it. This data is presented in a simple Column (not LazyColum) I want to allow the user to update the data using a swipe-to-refresh gesture
To Reproduce
Steps to reproduce the behavior:

Create a screen like with then following content:
 val viewModel: MyViewModel = viewModel()
 val isRefreshing by viewModel.isRefreshing.collectAsState()

 SwipeRefresh(
     state = rememberSwipeRefreshState(isRefreshing),
     onRefresh = { viewModel.refresh() },
 ) {
     Column {
         Row(Modifier.padding(16.dp)) {
             Text(
                 text = "Text",
                 style = MaterialTheme.typography.subtitle2,
                 modifier = Modifier
                     .weight(1f)
                     .align(Alignment.CenterVertically)
             )
         }
             ...
     }
 }

Run the code on a device and execute the "swipe-to-refresh" gesture

Error: viewmodel.refresh() is never called

Expected behavior
viewmodel.refresh() is called
Environment:
'com.google.accompanist:accompanist-swiperefresh:0.9.1'
Additional context
It works fine if I use a LazyColumn with an item count of 1

Is there no way to use SwipeRefresh without a scrollable layout? We don't want our layout to scroll but still want to use a SwipeRefresh to refresh the page. Is it possible for me to copy the source code and easily remove the scrollable requirement?


Enable optional flex buttons

Currently the buttons have this default style
display: inline-block;
text-align: center;
vertical-align: middle;

It would be great if there was a new variable called $enable-flex-buttons that would default to false that would change these styles to
display: inline-flex;
align-items: center;
justify-content: center;

It makes working with buttons much easier (like, having svg icons in them becomes much easier) and there are no drawbacks to my knowledge to do this instead of regular inline-block.
Demo to play with
https://codepen.io/lekoalabe/pen/JjWExoN
Remove the css to see the layout shifting. With inline-flex it works nicely.

There are a few drawbacks in fact, see #30923 and linked CodePen for an example.
Still in favor of this, but definitely could break things.

Ok I should have done more research on this one :-D I wasn't aware of the whitespace space issue and the issue with the long texts.
For the collapsing whitespace, I think it could be fixed, mostly, with
.btn-flex > * {
  margin-right: 0.5ch;
}

provided than you also use span tags if necessary (not necessary for leading icon for example). Not ideal nevertheless...
flex-flow: wrap; fixes also mostly the issue with long content but again it doesn't behave exactly the same. Mhh so it has advantages but also drawbacks. Still interesting to have. Maybe a btn-flex class would be better than enabling this globally.

Any suggestion welcome 🙂 For now it looked easier to use flex utilities for such cases.

Closing as a won't fix at this time :).


Preventing Null Pointer Exception

Thanks for this sweet library!

Weird, for some reason WhenActivated is getting called before OnApplyTemplate.
Thank you for the PR, but with these changes, if EditorHost is null, the UI will not be updated which leaves it in an inconsistent state. I'll push a commit to fix this issue, but I'll be closing this PR.


Option to emit GHC versions in Nix-like format?

Nix (at least in both in nixpkgs and haskell.nix) usually represents GHC versions as e.g. ghc865/ghc8107/ghc944. Would you be open to a convenience flag that allows to emit the GHC versions in this format, or do you consider this out of scope for this project?

Yes I would! Thank you for this suggestion. :)

Hello @Kleidukos Are you open for contributions for this?

Hello @Kleidukos Thanks for reaching out. No, I don't think it's going to be something that we need in the short term.


Fix support for tolerations

ISSUE TYPE

Bug fix Pull Request

SUMMARY

Currently, even if I set toleration values in the values.yaml file they are not being picked up as there is not toleration block in  deployment.yaml template

Hey @jspiro ,
This is already fixed with https://github.com/infracloudio/botkube/pull/277. Please let me know if you are still facing the issue

Ah so it is!


Remove encoding from file transfer source

Hey -
This is similar to my other pull request.  The philosophy here is that the user should have to encode the URI of the source while using the File Transfer plugin if they want it encoded -it shouldn't be done by default.  Again, motivated by lack of compatibility with Azure blob storage shared access signatures...
Thanks.

I guess this can be closed as in v0.1.11-alpha there is
var uri = options.encodeURI === false ? source : encodeURI(source);

for download and upload.


Preallocate space in new maps in resp.Any

Possible since 1.9, avoids a few allocations in most cases

👌


Slim 3.X $request->getUri() gives different results if called in a subrequest

Hi Guys,
I'll try and explain as simply as possible, using Slim 3.X to create a REST API, I have monolog logging set up and whenever a route is called it makes a call similar to the below before anything else.
  $this->logger->info($request->getMethod() . ": " . $request->getUri() .  " Starting");

I get an entry like the below in the logs:
"POST: http://localhost/base_path/path_name starting"
When I call the route from Swagger UI, that works fine, however if I call the route from within another route, for example below:
    $url = "route_name";
    $reqType = 'POST';
    $res = $app->subRequest($reqType, $url, "id=1234");

The same logging call is invoked and I get an entry like:
"POST: http://localhost/base_path/path_name starting"
http://localhost/path_name
For some reason it drops the BASE_PATH from the uri when called as a subRequest.
The REST API is in a sub folder at the root of my server, the log entry is misleading obviously but it showed me that I can't trust getURI to behave the same because it isn't returning the actual URI from my perspective.
Am I missing something?

Yes. Calling a route within a route is not best practice and we will be depricating it in 4.0.
In this case you should not be logging the uri to the action but some other information. Like the class and method that is being invoked. if tou are not using classes and methods then you should be refactoring to do so.
A short term solution would be to modify the reqeust object directly.

Thanks @geggleto, can you explain why it's not good practice please?
In this case I have 3 routes which are used for specific purposes to wrap and call 3rd party APIs and are used individually by, however a seperate requirement of the UI is orchestrate all three calls in certain circumstances, in which case having one route that fires the other three seems quite logical. So in this case I want to log the route call and parameters, when they are called directly, and also when they are orchestrated.
I am using classes and methods for some aspects of the code, however in this case I don't see the need to refactor 3 classes only for the purpose of orchestrating calls to the other routes, seems like extra complexity for little gain.
Can you provide some guidance on where/how to modify the request object as per your last comment please?
Deprecating the ability in future versions is fine, but when people want to do it, then we can obviously just go around the framework by using something like Curl to make a call to outside the current app, seems better to facilitate it in a way that make sense in the framework rather than have people work around it particularly if they have already coded against the current solution.

What you want to do is wrap those 3 routes in a Class.
class MyExternalAPI {

    public function __invoke(Request $req, Response $res, array $args) {

    }

}

You can add it to the container
$container = $app->getContainer();
$container[MyExternalAPI::class] = function ($c) {
     return new MyExternalAPI();
};

Finally add it as a route
$app->get('/path', MyExternalAPI::class);

Ideally you are using proper practices and you have no domain logic in your action methods at all.
The reason for this is that you do not want to tie your business logic to your framework. It should be separate. When designing it this way, you can then use this logic in other places in your application [ your use case ].
Example...
public MyExternalAPI:getData($options) => Returns an array formatted data.
You can simple access this class from other sub-systems in your app. You can still keep invoke so you can simply return a JSON formatted representation of the data.
I hope this helps.
If this is for a production/money making product both myself and @akrabat provide consulting services on these sorts of System Design problems, if not I would recommend checking out our slack. It's very complex to discuss in a github thread.

Thanks for the clarification, that helps a lot.


fix: opensearch instance type check during push

Description of changes

Use OpenSearchInstanceType for transformer v2 pre push check
Issue #, if available
fix #10362

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10389 (56867dd) into master (714f2fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #10389   +/-   ##
=======================================
  Coverage   46.57%   46.58%
=======================================
  Files         703      703
  Lines       35246    35249    +3
  Branches     7134     7137    +3
=======================================
+ Hits        16417    16421    +4
+ Misses      17042    17041    -1
  Partials     1787     1787

Impacted Files
Coverage Δ

...loudformation/src/graphql-transformer/api-utils.ts
100.00% <100.00%> (ø)

...li/src/domain/amplify-usageData/getUsageDataUrl.ts
100.00% <0.00%> (+12.50%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Any work around to retain original form of words ?

The model currently cannot retain the original form of words. For example, in image if words are "sunflower oil", it returns "sunfloweroil" without space. Is there any work around to address it?
Also, is it possible to fine-tune this model on other dataset such as XFUND (https://github.com/doc-analysis/XFUND) ?

Hello @PSanni,
For your first problem, namely, retaining original form of words, I do not know how to adress it.
Though, for your second question, I was able to use another dataset of my own (actually being trained). Hereby the solution I came up with. I hope it can be applied to your usecase.
This project makes use of the datasets from this other project https://github.com/ku21fan/STR-Fewer-Labels, as mention in Datasets.md, with few workarounds.
If you look into this other project, you will find a section in the Readme.md named "When you need to train on your own dataset or Non-Latin language datasets.". I bet the name is explicit enough.
They provide a piece of code in create_lmdb_dataset.py as well as the input format to this file to generate a dataset well formatted to be used by the algorithm, and a fortiori, by parseq as well.
I thouroughly followed the instructions and was able to start a training with parseq on my own dataset.

@PSanni for now, you can just directly edit and comment out https://github.com/baudm/parseq/blob/98959c9a43dff9f44898f10a4e8541beb2961150/strhub/data/dataset.py#L85
Note that some preprocessed datasets have had the spaces within labels removed. For the datasets which I preprocessed (COCO, OpenVINO, TextOCR), the spaces within the labels should be intact.
For fine-tuning on other datasets, you have two options:

Write your own Dataset subclass which follows the same public interface as LmdbDataset.
Preprocess your dataset into an LMDB database (see one of the converter scripts in tools to write your own preprocessing script. Then use create_lmdb_dataset.py to create the actual LMDB files).

@PSanni since commit e8ea463, you can now disable whitespace removal and/or Unicode normalization like so:
./train.py data.remove_whitespace=false data.normalize_unicode=false

I think its a good idea to include a annotations sample and required input format to the model as well.

The LMDB format used is unchanged from prior work. create_lmdb_dataset.py expects a text file with one image path and label per line. The actual format is described in the README for the TextOCR and OpenVINO archives.
The conversion from text labels to token IDs is handled by Tokenizer.encode() (in strhub/data/utils.py).

@PSanni since commit e8ea463, you can now disable whitespace removal and/or Unicode normalization like so: ./train.py data.remove_whitespace=false data.normalize_unicode=false

In addition to disabling whitespace (space, tabs, new line, etc.) removal, make sure you add the space character ' ' to charset_train and charset_test so it won't get removed by CharsetAdapter.
Closing this now since all issues have been addressed already. Feel free to reopen if I missed anything.


Add support for .Net Desktop Applications

Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hello!
I've been developing a pure .Net desktop application, and was intrigued by appCenter and its ability to distribute development versions to specific testers.
So I hooked up my application to the appCenter, chose windows, and tied it all up to my Azure Devops source.
Now, I'm getting the application to build, even though it is NOT an UWP app. The shortcomings are, as I see them:

No unit-test runs
The build does not execute a publishing step, so the artifacts built are not published
Since there are no artifacts, there is nothing to distribute

I guess I'm one of those guys who still believe in desktop applications, and would love to be able to use appcenter, MAINLY for the ability to distribute test-versions to specific groups of people, but also for the ability to run the Analytics part.

I would also add that I'd love the ability to create a ZIP package for distribution that contains the result equivalent of publishing from VS2017 - using the option "Athe application is available offline as well) that creates a self installer. This is something Azure Devops doesen't offer either.

Referencing #53 #85

@digitaldias have you looked at the packaging project to produce APPX/MSIX packages? these tachnologies can replace ClickOnce and are easily configured from AzureDevOps.

This issue is preventing us from migrating completely to App Center. We currently distribute our .NET application as an MSI through HockeyApp. I do not think we can use APPX/MSIX at this time because we still support Windows 7, and from my understanding APPX/MSIX is not supported on Windows 7. Please consider including this issue on your roadmap.

MSIX is supported on Windows 7

@leoniDEV I stand corrected. Thank you! I will investigate MSIX and see if it will meet our needs.


Put key tags before nodes/edges

I haven't read the spec but it seems that some applications assume that keys are before the rest of the data, like graph-tool and Gephi. Anyway, it's easier as a human to read the file if the keys are first.

So I just ran into this problem, and I'm now trying to think about how you could handle the fact that you can't know the keys until you iterate over the nodes. However, you also want the keys to be at the beginning of the file.
I guess the best way to do it would be to do a quick iteration over all the keys and store all of those events into an iterator or something. Send the key events through, then send the graph events through. But I also don't rust as much as I'd like so I'm not sure how that looks in this ecosystem.

I guess for some contexts, if the graph you are trying to write is extremely large, that would end up storing a lot of events in memory. So, I guess the other thought is to write the other events out to a temporary file on disk if the graph is large enough and then basically copy the contents of that temporary file to the final file. Whatever, probably premature optimization.

Just had an epiphany. What if you enforced that for those who want the keys before they have to register the keys beforehand?  But otherwise, you keep on putting the keys at the end if they don't request keys specifically being pre-registered.

Added PR #57 to solve this issue.

I released v3.1.0 which contains #57 by @Shadetheartist thus fixing this problem. Thanks for the PR.


Add OpenCV 3.2.0-p1 package

Done. Thanks for quick response :)

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1518
https://travis-ci.org/ingenue/hunter/builds/218335235

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1519
https://travis-ci.org/ingenue/hunter/builds/218360906

Released: https://github.com/ruslo/hunter/releases/tag/v0.18.36


Added filter input to Cas Services registry

Added your mat-table filtering logic into registry/services component

@rmathis is this something you might have time to review?


Building new version of polybar in openSUSE 15.2

Checklist

[x] I have followed every step on the compiling wiki page and
installed all necessary dependencies.
[x] My problem is not described on the known issues page
[x] I have searched for other open and closed issues that
may have already reported this problem.
[x] I was able to reproduce this build issue in a clean build

Build Process
How did you build polybar?

[x] From a release archive (Which version?) - 3.5.2
[ ] By cloning this repository (What is the output of git describe --tags?)
[ ] Some other way (How?)

Build Log

[    5s] make: Entering directory '/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build'
[    5s] /usr/bin/cmake -S/home/abuild/rpmbuild/BUILD/polybar-3.5.2 -B/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build --check-build-system CMakeFiles/Makefile.cmake 0
[    5s] /usr/bin/cmake -E cmake_progress_start /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build/CMakeFiles /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build/CMakeFiles/progress.marks
[    5s] /usr/bin/make -f CMakeFiles/Makefile2 all
[    5s] make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build'
[    5s] /usr/bin/make -f doc/CMakeFiles/doc_html.dir/build.make doc/CMakeFiles/doc_html.dir/depend
[    5s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build'
[    5s] cd /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/abuild/rpmbuild/BUILD/polybar-3.5.2 /home/abuild/rpmbuild/BUILD/polybar-3.5.2/doc /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build/doc /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build/doc/CMakeFiles/doc_html.dir/DependInfo.cmake
[    5s] Scanning dependencies of target doc_html
[    5s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build'
[    5s] /usr/bin/make -f doc/CMakeFiles/doc_html.dir/build.make doc/CMakeFiles/doc_html.dir/build
[    5s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build'
[    5s] [  1%] sphinx-build html: see doc/builder-html.log
[    5s] cd /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build/doc && sphinx-build -b html -c /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build/doc -d /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build/doc/doctrees /home/abuild/rpmbuild/BUILD/polybar-3.5.2/doc /home/abuild/rpmbuild/BUILD/polybar-3.5.2/build/doc/html > builder-html.log
[    6s] Traceback (most recent call last):
[    6s]   File "/usr/lib/python3.6/site-packages/sphinx/config.py", line 161, in __init__
[    6s]     execfile_(filename, config)
[    6s]   File "/usr/lib/python3.6/site-packages/sphinx/util/pycompat.py", line 150, in execfile_
[    6s]     exec_(code, _globals)
[    6s]   File "conf.py", line 20, in <module>
[    6s]     from sphinx.domains.changeset import VersionChange
[    6s] ModuleNotFoundError: No module named 'sphinx.domains.changeset'
[    6s]
[    6s] make[2]: *** [doc/CMakeFiles/doc_html.dir/build.make:78: doc/CMakeFiles/doc_html] Error 2
[    6s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build'
[    6s] make[1]: *** [CMakeFiles/Makefile2:515: doc/CMakeFiles/doc_html.dir/all] Error 2
[    6s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build'
[    6s] make: *** [Makefile:150: all] Error 2
[    6s] make: Leaving directory '/home/abuild/rpmbuild/BUILD/polybar-3.5.2/build'
[    6s] error: Bad exit status from /var/tmp/rpm-tmp.kH66yQ (%install)
[    6s]

Environment:

Distro (with Version): openSUSE 15.2

Additional context

Hi,
I tried to update polybar in openSUSE 15.2 but get issues with compiling. As you see above there's a problem with Sphinx, in openSUSE 15.2 the version of that package is 1.7.6 (maybe that is the issue?). What is the minimum version required to pass build?

I actually can't find this module anywhere in the sphinx documentation. But looking at the repo, it was first released in version 1.8.
The (very) old sphinx version is definitely at fault here. Does openSUSE really have now newer version of this package?

Does openSUSE really have now newer version of this package?

uhm, about that.. yes, the Leap version have 1.7.6 version in repo, newer version is on Tumbleweed (3.3.1).
Anyway, thanks for reply I assume, we can close that ticket as resolved, because the older version is the problem.

Oh that's too bad. But I think in this case installing a newer version through pip also works.
If you are talking from a packaging standpoint, you could either disable the documentation by passing -DBUILD_DOC=OFF to cmake (this also disable the manpages) or remove the offending code from the conf.py.
Patching the conf.py would involve removing the import from sphinx.domains.changeset import VersionChange and removing the last 23 lines (everything after suppress_warnings = ['app.add_directive']).

Oh, I totally forgot about this. There was another issue with the same problem and I fixed this for version 3.5.5, so you should be able to build polybar again even on opensuse leap


Use nested hashes instead of arrays for methods with multiple required arguments

This was a suggestion made by @brasic in the RubyConf Discord channel for our talk. The idea is that for a method like foo(a, b), instead of storing the results like this:
# @_memo_wise[index_of_foo]
{ [a, b] => memoized_value }

we'd store them like this:
# @_memo_wise[index_of_foo]
{ a => { b => memoized_value } }

our talk implies that this would be faster (hash lookups on array keys are significantly slower, and in the already-memoized case we avoid a new array allocation each time), and in Discord @brasic had a microbenchmark showing this solution to be faster as well.

@brasic would you be interested in implementing this? (No pressure either way!)

@JacobEvelyn I don't have the bandwidth right now but if this is still open over holiday break when I have some free time I will try to take a look!


⚠ Bofrost.at has degraded performance

In e892879, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1072 ms

Resolved: Bofrost.at performance has improved in 4099c7c.