Invalid prop undefined when using throw createError

Environment
Nuxi 3.4.3
RootDir: /home/projects/github-c5prhs
Nuxt project info:

Operating System: Linux
Node Version:     v16.14.2
Nuxt Version:     3.4.3
Nitro Version:    2.4.0
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

👉 Report an issue: https://github.com/nuxt/nuxt/issues/new
👉 Suggest an improvement: https://github.com/nuxt/nuxt/discussions/new
👉 Read documentation: https://nuxt.com
Reproduction
Reproduction project: https://stackblitz.com/edit/github-c5prhs
Reproduction description: When loading the reproduction, an error is immediately thrown using createError - this results an error:  Invalid prop: type check failed for prop "title". Expected String with value "undefined", got Undefined.
Describe the bug
The throw createError somehow still leads to the template being rendered, but with items from the setup being undefined. This leads to SSR errors, but also to hydration errors in more complex cases. Looking at the documentation of createError I cannot see this being expected behavior (link).
Additional context
No response
Logs
✔ Nitro built in 1217 ms
ℹ Vite client warmed up in 1887ms
✔ Vite server hmr 21 files in 794.22m
[Vue warn]: Invalid prop: type check failed for prop "title". Expected String with value "undefined", got Undefined
[Vue warn]: Invalid prop: type check failed for prop "title". Expected String with value "undefined", got Undefined

FYI: This is still reproducible in Nuxt v3.9.0

After @danielroe investigated the scenario, the conclusion is:

This only happens in development mode and not in production. In production, the Home component is neither rendered nor even initialized
In development mode, the Home component is initialized (setup is running) but not rendered.

Vue itself has no concept of "stop rendering when throwing an error", which is why this happens

The whole info could be enhanced DX-wise so it is more clear what is happening.


ZEPPELIN-2173 Duplicate user names populated in the Note permission box

What is this PR for?
Duplicate user names populated in the Note permission box
What type of PR is it?
Bug Fix
Todos

[ ] - Task

What is the Jira issue?

ZEPPELIN-2173

How should this be tested?
See JIRA description for the steps to reproduce the issue.
Screenshots (if appropriate)
Questions:

Does the licenses files need update? n/a
Is there breaking changes for older versions? n/a
Does this needs documentation? n/a

@r-kamath Thanks for fixing this issue!
Let me check and give a feedback soon :)

Tested and It works well as that remove duplication name.
But, In my personal opinion, I'd like to suggest that It would be better to show it in its original state. For example, if user who is not permission fail to edit permission, the status of permission is displayed to values before the modification .
What do you think?

@soralee thanks for the review.

For example, if user who is not permission fail to edit permission, the status of permission is displayed to values before the modification

we will have to handle this in the backend and restrict the users from editing the exiting permissions, may be with some UI modifications.

closed and reopened to trigger CI

Unrelated CI failure for profile 2 and 3

Merging this to master and branch-0.7 if no more discussion.


Extension yields errors if advisories exist

Hey,
I was giving the extension a try, but it yields errors and doesn't display the banner from the readme:

Setup
I am using Chrome version 120.0.6099.234 on MacOS version 14.2.1 (23C71) if that helps.
I installed the extension by loading it as described in the README, and obtained it previously via git clone https://github.com/Wadeck/extension-jenkins-security

@NotMyFault Try updating, it should work now :)

@NotMyFault Try updating, it should work now :)

Thanks, works like a charm!

Good job disclosing it's working without disclosing for which repo :)))


Bug: v0.90 AssetStudioCLI cannot write to file with  Parallel call.

v0.18.60 works fine.
v0.80.65 works fine.
https://github.com/kongying-tavern/it-is-a-exporter/blob/main/scripts/Resources.csx#L37-L44

use process monitor or other tools to find Write file operation.

Greetings,
Should be fixed.

Yes, thank you!


add values_strided_to

Codecov Report

Merging #47 into master will decrease coverage by 1.43%.
The diff coverage is 64.51%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   87.68%   86.25%   -1.44%
==========================================
  Files           7        7
  Lines         950     1011      +61
==========================================
+ Hits          833      872      +39
- Misses        117      139      +22

Impacted Files
Coverage Δ

src/file.rs
92.42% <100%> (ø)
:arrow_up:

src/variable.rs
83.81% <63.93%> (-3.84%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbb569...e038054. Read the comment docs.


Multiple instances of modaal issue

When I create more than a single Modaal instances, something goes wrong. When I close the second or the third instance with X close button, the previous modaal not works, I can't close it, when i do console.log(self.scope.id) it show always the last created modaal id and it no change.
Thanks!

You should probably share your code.

I had to change the library to generate the modals because I was in a hurry to finish the project, however it is as simple as declaring two different instances of modaal. Something like:
$ ('. my-first-selector'). modaal ({args});
$ ('. my-second-selector'). modaal ({args});
The error occurs when I open the modal $ ('. my-first-modal') and then, without closing the first one, I open the modal $ ('. my-second-modal');
It allows me to close the last one but afterwards the first one cannot be closed anymore.
Thanks!!

I'm experiencing the same issue — I have a global modal, in which there's a link to launch a second (video) modal on top. I can close the video modal, but the original modal then fails to close at all and I need to refresh.
I've tried forcing it via callbacks on the second modal, but it ends up launching multiple instances of the first.
// Initialize first modal
// --------------------------------------------------

jQuery(function($){
	$('.trigger__modal--first').modaal({
		custom_class: 'modal--first'
	});
});

// Initialize second modal
// --------------------------------------------------

jQuery(function($){
	$('.trigger__modal--second').modaal({
		custom_class: 'modal--second',
		type: 'video',
		after_open: function() {
			$('.trigger__modal--first').modaal('close');
		},
		after_close: function() {
			$('.trigger__modal--first').modaal('open');
		}
	});
});


build_orchestrator_build: parse container.yaml for excluded and extra…

… platforms
use PyYaml to get the platform.not and platform.only values. remove the
platform.not platforms from the set of available platforms and add the
platform.only platforms.
Signed-off-by: Mark Langsdorf<EMAIL_ADDRESS>

Draft release notes updated.


Revert icon for js files

This line seems to be changing the JS files icon to an ... antenna?
https://github.com/DanBrooker/file-icons/commit/65c2accf7195da6f4ee75a434b4453a07ee78cbc#diff-65aa8dfdba97754cb84150bb589dba59R49

Try restarting Atom instead. Solved the issue for me.

@hgGeorg Yes, that worked.


We need have concatenate method for text

It would be nice to have method for strings concatenation. Of course we can have this functionality via text.join method, but I think it's a terrible way to use it.

@Graur please assign me

@EugeneDar go ahead


Couldn't capture from a Vulkan app

Description

I tried to capture from an Android's Vulkan Sample vulkan.sample.T15_draw_cube from Android Studio. I got this error.
ADRD 019666: [22:42:49]         vk_manager.h( 206) - Error   - Assertion failed: 'm_CurrentResourceMap.empty()'
How do I fix this? thank you.
Repro steps

Environment

RenderDoc build: Version v1.4 (built from 214d8522)
Operating System: Windows 10 launch to Android
API: Vulkan

Xiaomi MI 9 Qualcomm Snapdragon 855 Adreno (TM)640

I don't understand what you mean that you captured "from Android Studio". RenderDoc is not related to Android Studio and actually having it running while trying to use RenderDoc typically completely breaks since Android is very fragile and easy to break.
The assertion you've mentioned is fairly innocuous and only suggests that the application didn't properly release all resources before destroying the vulkan instance. Please outline what real problem you are encountering and please fill in the Repro Steps section so that I know how I can reproduce the problem.

Closing this issue due to lack of information or response.


Type alias resolution with constant assignments

Input
→ View on sorbet.run
# typed: true

module A
  Result = T.type_alias {B::Result[Integer]}
end

module B
  Result = C::Result
end

module C
  module Result
    extend T::Generic

    X = type_member(:out)
  end
end

Observed output

module C
  module Result
    extend T::Generic

    X = type_member(:out)
  end
end

editor.rb:4: Integer cannot be used for type member ::C::Result::X https://srb.help/7028
     4 |  Result = T.type_alias {B::Result[Integer]}
                                           ^^^^^^^
    editor.rb:4: Integer is not a subtype of <todo sym>
     4 |  Result = T.type_alias {B::Result[Integer]}
                                           ^^^^^^^

editor.rb:4: Integer cannot be used for type member ::C::Result::X https://srb.help/7028
     4 |  Result = T.type_alias {B::Result[Integer]}
                                           ^^^^^^^
    editor.rb:4: <todo sym> is not a subtype of Integer
     4 |  Result = T.type_alias {B::Result[Integer]}
                                           ^^^^^^^
Errors: 2

Expected behavior
No errors

This is a problem in the ResolveTypeParamsWalk of the resolver, as it should be tracking the dependency between the Result constant assignment, and the type alias. This could be as simple as making sure to walk through aliases when checking if a type has been fully resolved.

cc @Morriar
cc @paracycle

🎉


Return all relationships from resource

As title
I did it with:
$all = array_filter($include, function ($filter) {
    return (strtolower($filter === 'all'));
});

foreach ($this->getRelationshipMap() as $key => $map) {
    if (empty($all) && is_array($include) && ! in_array($key, $include)) {
        continue;
    }

    ...
}

This is not ideal due to the possibility of someone having a relationship called all.

You wot m8

Bit messy, but couldn't you have a query string such as ?all=true?

Likely be handled with /endpoint/resource?complete not available on listings


User Notifications API

Lastuser needs to provide a centralised mechanism for controlling notifications sent to users by client apps. The primary purpose of this mechanism is to provide a meaningful "unsubscribe".
Notifications should be modelled on the Growl API, giving us:

Transport: how the notification is delivered (currently in-app, SMS or Email, in future IM, other), with sub-options (HTML or plain text email).
Notification class: A class of notifications from each client type. Funnel may have "Comment alert", for example. Notification classes specify defaults for users who haven't made a choice yet. A class may be defined as mandatory, meaning a user cannot unsubscribe from it (for example, password reset emails). Notification classes should however specify if they are transactional or mass-mails.
UserNotificationPreference: What the user prefers for each class of notification: disabled, preferred transport, preferred sub-option, preferred batching (immediate, digest, silence period (particularly for SMS)).

For email:

Lastuser wraps all email notifications with its own markup, which includes branding, app identification and one-click unsubscribe, or
Lastuser allows the client app to specify its own markup, but ensures required links are present.

To be considered: Should Lastuser preserve a copy of every notification delivered, or even just a transaction id? This is required for proper bounce detection, etc.
Also related: should the existing notice mechanisms (email verification, password reset) be moved on top of the notification API?

Consider WhatsApp/Telegram groups:
Notification classes:

A message was posted to the group
You were mentioned

Transports:

Notification icon

Allow peeking
Show on lock screen

Notification light

Colour
Flashing?

Sound

Ringtone

Vibrate

Extra:

Mute sound/vibrate for a specific period for a specific group (a "context")
Mute notification icon/light as well for the same period
Show or cancel mute status

For in-app and in-browser transports, the notification will be delivered by the client app itself, not by Lastuser. Apps also own the UX for a user to manage notifications from and are the logical place for the user to look. Further, in an OS like iOS, notification management is centralised in the OS system settings. There is no scope of a Lastuser notification settings page in a native iOS app. Therefore, should notifications be centralised in Lastuser, or should they be managed by each app, using a common API (and shared library codebase)?

Deprecated by the new architecture proposed in #232 and #217. Let client apps be in charge, with Lastuser limited to just handling auth.

The deprecation is partially inspired by the Meetup app on Android, which offers fine-grained customisation of in-app notifications per meetup group. (No other app I'm aware of does this.) We cannot possibly implement such functionality if users install a HasGeek app, but notifications are managed by the Lastuser app.


Project 1: Hello Microverse.

Additional description about the project and its features.

Understanding Git, and GitHub.
Understanding GitHub Flow.
Understaanding linters and the structure and use of HTML & CSS

Hi Tumworobere Tumworobere,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

## Invalid Code Review Request

You have submitted a project, that has failing linter checks on PR. Kindly fix the linter issues and make sure that all checks show green.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

**_Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise._**

--------

Invalid Code Review Request **does not count** into the code reviews limit._

Thanks @SajjadAhmad14 for taking time to review my project.Let me correct the linter errors and resubmit

Hi @Tumworobere ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.

Thanks @carlos-ssh !


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.10.118 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Handler events.APIGatewayProxyRequest Cognito fields empty

I've deployed an API Gateway that calls a lambda_proxy handler. My handler function receives in a context and an events.APIGatewayProxyRequest. Inside the request, there are fields for the Cognito Identity ID and Pool ID, but both are empty. This may be related to Issue #106. While I saw a workaround to manually verify JWTs, that would seem to largely defeat the purpose of API Gateway Cognito authentication and certainly the request's cognito fields.
Code to reproduce the error:
package main

func Handler(ctx context.Context, request events.APIGatewayProxyRequest) (events.APIGatewayProxyResponse, error) {
	lc, _ := lambdacontext.FromContext(ctx)

	fmt.Println("Context cognito identity id:", lc.Identity.CognitoIdentityID)
	fmt.Println("Context Cognito pool:", lc.Identity.CognitoIdentityPoolID)
	fmt.Println("Request context cognito id:", request.RequestContext.Identity.CognitoIdentityID)

	return events.APIGatewayProxyResponse{}, nil
}

func main() {
  lambda.Start(Handler)
}

I also dug into the aws-lambda-go/lambda/function.go Invoke() function and verified that the req.CognitoIdentityID and req.CognitoIdentityPoolId are both empty strings. I verified this using a deployed Lambda function that I tested using API Gateway and Postman (with valid JWT Cognito tokens) using Printlns also in the function.go Invoke() function.

Related to #106 - I think I have wrongly anticipated what exactly OP wanted to know and my answer might misguide. There are many ways to authorize user if he passes an IdToken in Authorization header, i.e.:

Authorizer with Type: "COGNITO_USER_POOLS".
Custom Lambda authorizers with Type: "REQUEST", i.e. which will extract interesting claims from JWT and pass them further in the request context.
Handling authorization directly in the Lambda handler.


MoverController sorely needs optimisation

It's a not-insignificant part of physics ticks.

I did some work on this so good enough for now.


Unable to import component

Since yesterday there are problems with the recognition of c5 after restarting Home Assistant. Another restart also leads to the error, yesterday I was able to de-energize the RLT system, after which it was recognized by ha after another restart - unfortunately not anymore today. that's the mistake.
`Logger: homeassistant.setup
Source: setup.py:162
First occurred: 06:34:35 (1 occurrences)
Last logged: 06:34:35
Setup failed for custom integration komfovent_c5: Unable to import component: No module named 'pymodbus.client.asynchronous'`

Interesting, I haven't encountered anything like this yet. It's possible that you ended up with an incompatible version of pymodbus. Can you check which version you're running?

Okay, how can I check the pymodbus version because - I couldn't find anything.

Problem since HA Version 2022.4 and only after a reboot.

2022-04-12 06:36:56 ERROR (MainThread) [homeassistant.setup] Setup failed for custom integration komfovent_c5: Unable to import component: cannot import name 'is_installed' from 'pymodbus.compat' (/usr/local/lib/python3.9/site-packages/pymodbus/compat.py)

The existence of the 'compat' module basically confirms  that you're running pymodbus 3 rather than the expected pymodbus 2.
Im not sure how this happened because pymodbus 3 doesn't even habe a stable release yet. Are you perhaps using another integration which depends on pymodbus?

Good question, actually nothing new. SolarEdge Modbus will probably use it, but I've had it for a long time. Currently I'm helping myself as follows. Make RLT stromloas and restart HA, then it always works - exactly until HA is restarted.

2022-04-15 11:27:38 ERROR (MainThread) [custom_components.komfovent_c5] Unexpected error fetching state data: Modbus Error: [Connection] Connection lost during request Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 190, in _async_refresh self.data = await self._async_update_data() File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 150, in _async_update_data return await self.update_method() File "/config/custom_components/komfovent_c5/__init__.py", line 60, in __fetch_data return await KomfoventState.read_all(self.client, self.settings_state) File "/config/custom_components/komfovent_c5/__init__.py", line 49, in read_all modes=await Modes(client).read_all(), File "/config/custom_components/komfovent_c5/api/modes.py", line 237, in read_all ahu, registers = await asyncio.gather( File "/config/custom_components/komfovent_c5/api/modes.py", line 247, in ahu_on return bool(await self._client.read_u16(self.REG_AHU_ON)) File "/config/custom_components/komfovent_c5/api/client.py", line 55, in read_u16 await protocol.read_holding_registers(address, count=1) File "/usr/local/lib/python3.9/site-packages/pymodbus/client/asynchronous/async_io/__init__.py", line 35, in execute resp = await asyncio.wait_for(req, timeout=self._timeout) File "/usr/local/lib/python3.9/asyncio/tasks.py", line 481, in wait_for return fut.result() pymodbus.exceptions.ConnectionException: Modbus Error: [Connection] Connection lost during request

Failed to connect: [Errno 110] Connect call failed ('<IP_ADDRESS>', 502)
06:22:03 – (WARNUNG) /usr/local/lib/python3.9/site-packages/pymodbus/client/asynchronous/async_io/init.py - Die Nachricht ist zum ersten Mal um 13. Mai 2022, 22:01:13 aufgetreten und erscheint 390783 mal
<IP_ADDRESS> is the IP address to my komfovent

Is something else connecting to your unit using Modbus? Komfovent can only handle a single client at a time.
Otherwise, it just looks like your unit is unreachable (wrong IP, firewall, etc.)

The error actually only came up after I connected my solaredge inverter via modbus, which of course has a different IP of its own. Something is wrong, there is no error message with the solaredge add on. what can i do to fix this, because 400000 errors in a few hours can't be healthy.

 Must have something to do with the solaredge integration.

Great, disable this in Solaredge, reboot and no Error. THX

Solved with:
update_interval=timedelta(seconds=40),
client = await Client.connect(host, port, connect_timeout=35.0)
no errors since yesterday


Filter request by method

It would be a good idea to add the possibility of filtering requests by method

@MMukundi top player


I'll take a look in a few minutes.


It is possible to use modulo when specifying min/max values?

It is possible to use modulo when specifying min/max values?
For the project I am working on I have to work with fiscal months formatted YYMM. So I need to be able to have something like:
1710, 1711, 1712, 1801, 1802, 1803...
If that is not currently a feature I would be interested in doing a PR for it.

For this kind of very custom steps, you can use the stepsArray option. ;)


Do not create empty menu sections

These menu sections does not render nicely in the role editor.
Introduced in https://github.com/ManageIQ/manageiq/pull/12205
Before

After

@miq-bot add_label ui, bug
@miq-bot assign @martinpovolny

@miq-bot add_label euwe/no


fix: support config nacos namespace

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message follows commit guidelines

Affected core subsystem(s)

Description of change

1.2.1


fix: cmp.close() when autocompletion = false

Fix https://github.com/hrsh7th/nvim-cmp/issues/1919.
cf. https://github.com/hrsh7th/nvim-cmp/pull/1920
Now, autocomplete = false got more cozy!

ty!

Sorry for opening multiple PRs targeting the same issue 🥲
But thank you for merging them!!


Visually Balance Logos on Titlepage

Currently, logos on the titlepage are not balanced (notice the extra space to the left of logo A when compared with logo C, furthermore, B is not centered with the centerline of Image.

Additionally, they are not aligned with the title text.
What kind of alignment do we want here? Or is it "fine as is"?

I think for now it would be fine if we can just omit the extra white space left of logo A.
Nevertheless, I am open for proposals on new alignments.

For now, I agree with @tthuem. However, if it is not too complex to realize, I would also prefer having the right logo aligned with the title.

@EagleoutIce Just go ahead with whatever you think fits best.


Add option to allow connections with invalid ssl certificates

DON'T MERGE, blocked on https://github.com/sfackler/rust-native-tls/pull/56 (and probably updates to the dependencies of hyper-tls and tokio-tls).
Given that it may be a while before this is merge-able, consider this PR an RFC.
Motivation
I know this is just... wrong, and everyone should be using letsencrypt, or adding their self-signed cert as a trusted root. Allowing invalid SSL connections is still a "feature" that rust doesn't have, and I'd like to fix that.
Also, this should put #15 to bed.
Changes
Add methods to the ClientBuilders that disable certificate validation. Added a doc-string with a warning about how this is a bad practice. If anything can be more clear and/or obnoxious, let me know.
Example
let mut client = reqwest::ClientBuilder::new()
    .danger_disable_certificate_validation_entirely()
    .build().unwrap();

let mut res = client.get("https://expired.badssl.com/")
    .send().unwrap();

let mut body: String = String::new();
let _ = res.read_to_string(&mut body).unwrap();
println!("{}", body);

You can try this out by using my fork in Cargo.toml
reqwest = { git = "https://github.com/scottschroeder/reqwest", branch = "noverify" }

Just checking in here, is this still a thing being worked on?

Yeah, just waiting on some of the dependencies to get released/merged.
See https://github.com/sfackler/rust-native-tls/pull/56 and https://github.com/sfackler/rust-security-framework/issues/47 for more details.

I just tested the PR, works fine for my case (self-signed, outdated ceritificate)

[x] There was the security-framework 0.2.0 release which enabled merging https://github.com/sfackler/rust-native-tls/pull/56.
[ ] We're still waiting on a new release from rust-native-tls
[ ] A few methods got renamed in https://github.com/sfackler/rust-native-tls/commit/c20481346cd306fe8fa03521346d98fcfce45e29, so I'll have to update this PR to reflect the new names.
[ ] I need to rebase & fix merge conflicts with upstream reqwest, and generally just re-test everything as its been ~6 months since this was originally written.

(Side note: I'll be of limited availability until mid April, so that could delay my piece a bit)

Yeah that's definitively a wanted feature. I use reqwest for a project and run unit-tests in a CI. I don't want to have to regenerate a certificate with Let's encrypt each time because it will only be used when running unit-tests.
Thanks for this PR

I too could use this.  I'm using reqwest to pull rest api information from various datacenter servers and sometimes they have some really bad ssl certs on them that I can't fix.

Hey folks, is there a rough timeline for this? I'm happy to help if I can.

The feature here was completed in #325. Follow-up PR made in #327.
Closing this as its now irrelevant. Thanks!


License information update

PR Description:
This PR is to update the license information of this project along with its dependencies
License file information in README file is updated accordingly
Project license is added with Apache Version 2.0 considering the project use cases and deployment scenarios.

@swaminathanvasanth @abhi4578 Please have a look

Can one of the admins verify this patch?

@swaminathanvasanth @abhi4578 Dependency licenses file updated with all the licenses related to servers and client packages, pls review


refactor(svg): use InjectionTokens instead of strings

:tada: This PR is included in version 7.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Grace period for reusing consumed refresh tokens

Show how to extend AcceptConsumedTokenAsync to allow consumed tokens to be reused for a short grace period.
We do already document this feature here - consider adding code sample inline in the docs.

Came up in a support issue: https://github.com/DuendeSoftware/Support/issues/406

Given the updated guidance, we discourage this approach and thus don't need a sample.


Query Variables for Subscription Parameters not working.

Describe the bug
When creating a subscription using a GraphQL client (In my case the GraphQL Playground Desktop App), if query variables are used instead of "hard-coded" values for the subscription parameter, the subscription does not received notifications.
subscription {
  onAlertCreated(individualId:"01566d84-4811-4959-b479-1b8f74376c77") {
    title, text
  }
}

Produces the correct response when a subscription notification is created for this user (01566d84-4811-4959-b479-1b8f74376c77). However if I take the individualId out into a Query Variable like so:
subscription onAlertCreated($individualId: String!){
  onAlertCreated(individualId:$individualId) {
    title, text
  }
}

The subscription does not receive the notification.
To Reproduce
Unknown on other systems, but locally:
Build and run the ASP.Net Core Api using the HotChocolate GraphQL server.
Create a subscription with an id parameter to filter notifications.
Using GraphQL Playground connect to the Api's graphql endpoint and create a subscription to your api using query variables for the id value.
Expected behavior
Receive the subscription package associated with the id value specified in the Query Variables.
Desktop (please complete the following information):

OS: Mac OS Mojave
v10.14.6

Additional context
Using HotChocolate v10.01, HotChocolate.AspNetCore v10.0.1, HotChocolate.Subscriptions v10.0.1, HotChocolate.Subscriptions.InMemory v10.0.1

hi, is there a workaround for this?

Found one: it is working when variable is string. Was not working when I had variable of type Uuid.

This is already fixed for version 11.

I will close this issue since we fixed it in our current preview builds.


Vulnerability fix: CVE-2021-3777

Scanned using WhiteSource.:
nodejs-tmpl is vulnerable to Inefficient Regular Expression Complexity
Updated from 1.0.4 to 1.0.5.
URL: https://vuln.whitesourcesoftware.com/vulnerability/CVE-2021-3777
(Also removed local GitHub action that automatically updates the fork and whitesource config)

Closing in favor of #4716 which has the integrity fields updated properly.


MaaS: Swift time-sync validation and alarming

Validating and alarming on time-sync with swift-recon.
Connects rcbops/u-suk-dev#1217
Dependent on https://github.com/rcbops/rpc-openstack/pull/1888 for swift_recon_checks_list.

I set the time drift threshold to 30 seconds which is up for debate.  The swift-recon check will grab the metrics from the host that's the most out of sync and return that time.
Multinode output:
(swift-14.0.7) root@swift1:~/rpc-openstack/rpcd/playbooks/roles/rpc_maas/files/plugins# swift-recon --time
===============================================================================
--> Starting reconnaissance on 3 hosts (object)
===============================================================================
[2017-02-22 23:19:21] Checking time-sync
!! http://<IP_ADDRESS>:6000/recon/time current time is 2017-02-22 23:19:21, but remote is 2017-02-02 21:19:20, differs by 1735200.51 sec
!! http://<IP_ADDRESS>:6000/recon/time current time is 2017-02-22 23:19:21, but remote is 2017-02-16 21:19:23, differs by 525597.56 sec
1/3 hosts matched, 0 error[s] while checking hosts.
===============================================================================
(swift-14.0.7) root@swift1:~/rpc-openstack/rpcd/playbooks/roles/rpc_maas/files/plugins# ./swift-recon.py time
status okay
metric time_sync_total uint64 3
metric time_sync_errors uint64 0
metric time_sync_success uint64 1
metric time_sync_time_differ uint64 1735200

AIO Node Output:
(maas-r13.1.0rc1) root@rpc-openstack:/usr/lib/rackspace-monitoring-agent/plugins# swift-recon --time
===============================================================================
--> Starting reconnaissance on 1 hosts (object)
===============================================================================
[2017-02-22 23:30:56] Checking time-sync
1/1 hosts matched, 0 error[s] while checking hosts.
===============================================================================
(maas-r13.1.0rc1) root@rpc-openstack:/usr/lib/rackspace-monitoring-agent/plugins# ./swift-recon.py time
status okay
metric time_sync_total uint64 1
metric time_sync_errors uint64 0
metric time_sync_success uint64 1
metric time_sync_time_differ uint64 0

Digging into error:
 {"changed": false, "cmd": " . /openstack/venvs/maas-r13.1.0rc1/bin/activate\n  /opt/rpc-openstack/scripts/rpc-maas-tool.py verify-local", "delta": "0:00:30.897128", "end": "2017-02-23 01:56:34.571287", "failed": true, "failed_when_result": true, "rc": 1, "start": "2017-02-23 01:56:03.674159", "stderr": "", "stdout": "The following alarms have critera that could not be parsed: Alarm: swift_time_sync_check--jramcp-307-28022-swift-proxy-container-57fda26c Criteria: :set consecutiveCount=3\nif (metric[\"time_sync_time_differ\"] > 30) {\n    return new AlarmStatus(CRITICAL, \"Time synchonization error\");\n Error: Cannot parse alarm criteria: swift_time_sync_check--jramcp-307-28022-swift-proxy-container-57fda26c Error: parse error: failed to match 'endOfLine' at line=4, col=0, pos=135", "stdout_lines": ["The following alarms have critera that could not be parsed: Alarm: swift_time_sync_check--jramcp-307-28022-swift-proxy-container-57fda26c Criteria: :set consecutiveCount=3", "if (metric[\"time_sync_time_differ\"] > 30) {", "    return new AlarmStatus(CRITICAL, \"Time synchonization error\");", " Error: Cannot parse alarm criteria: swift_time_sync_check--jramcp-307-28022-swift-proxy-container-57fda26c Error: parse error: failed to match 'endOfLine' at line=4, col=0, pos=135"], "warnings": []}

Rebased

@antonym I didn't see this one get backported. Did I miss it?

Going to do those this morning now that you merged the ones it was dependent on.


How can i show the page in a specific route?

I wish to know how can i show the page :id in a specific route, like:
https://domain.com/page-tag

@marlon33 you can create a simple route and render a blade file in it and pass the loaded page to that blade file. Copy and paste the below lines into your blade file.
<style type="text/css">
	{!! $page->css !!}
</style>

{!! $page->html !!}


Adjust size/scale on hud

Provide a detailed and clear description of feature or change that you want to offer.
Add a config option for something like a scale or sizing number, so the clock & time can be made bigger or smaller.
Describe why you want this. If there's a reason.
it's too big for me lol. It's a really nice hud doodad but it takes up just a bit more space than I'd really like it to; I think it'd be perfect otherwise.

Perhaps, but no promises. It's not very easy to resize rendered items in GUI actually.


Set screen size/resolution?

I've looked through the wiki, docs, headers, and samples and I can't seem to find a way to set the application's resolution. How do we do this as well as setting full-screen/windowed, re-sizable window or not, etc...?
With XNA/MonoGame it was:
graphics = new GraphicsDeviceManager(this);
graphics.IsFullScreen = false;
graphics.PreferredBackBufferHeight = 340;
graphics.PreferredBackBufferWidth = 480;
Surely there's an equivalent in UV.

Ultraviolet works a bit differently than XNA here, because Ultraviolet has built-in support for multiple windows. Resolution settings are exposed on the IUltravioletWindow interface.
The first window which your application creates is called the "primary window" -- for the majority of applications, this will be the only window that exists. You can get to it through the platform subsystem:
var win = uvcontext.GetPlatform().Windows.GetPrimary();

Once you have that, you can modify its resolution:
// for fullscreen
win.SetFullscreenDisplayMode(width, height, 32, 60)
win.SetWindowMode(WindowMode.Fullscreen); // or FullscreenWindowed

// for windowed
win.SetWindowedClientSize(width, height);
win.SetWindowMode(WindowMode.Windowed);

The window will remember both resolutions independently and automatically switch between them when you call SetWindowMode().
I will make a note to add documentation on this.

I should note also that the reference documentation for IUltravioletWindow is available here. It can provide guidance on how to modify your game window in other ways.

Cool. That helps a lot, thanks.


Got error when proxying POST request with form

Describe the bug
I hava a project to manage file upload and download, and another project use yarp to proxy those request.
But when i try to request my file service to upload file via proxy server, i got http response code with 400.
Here's the exception Info: https://pastebin.com/BE8rRGFG
After a time to dig out the problem, i found out it was Exceptionless, which is a log collector.
the following is the code i thought might be impact the problem in Exceptionless (because after i set IncludePostData to false, all things goes on) Exceptionless.AspNetCore/RequestInfoCollector.cs#L53
But what confused me is that, Exceptionless in fact didn't read from Body Stream, it only return Unable to get POST data: The stream could not be reset. when i request the proxy server.
Why I still got the exception i mentioned?
Other Post Request was normal
To Reproduce
Here is a repo can reproduce the error
https://github.com/yangon99/FormRequest
Further technical details

Yarp.ReverseProxy 2.1.0

well, i think i got it.
When the code in Exceptionless try to get Count of the Form in HttpContext.Request,
The implemention of Form will read use ReadForm to get info.
Am i right?


initial register prototype

Fixes https://github.com/doublebyte1/bblocks/issues/2

@ghobona good initiative! I am going to link this to the main page


:cop: Upgrade node to 8.1.4

:rocket: deployment of elasticsearch-updater succeeded (http://elasticsearch-updater-pr-5.dev.beta.nhschoices.net)

Coverage remained the same at 89.222% when pulling 13f78bc1fc66f2f632b797bf0ca68404266404cc on feature/node-8.1.4 into 92172862a9d7412f90ba9abee027b8656d899d9b on master.


[Coverity CID: 185275] Integer handling issues in /kernel/posix/pthread_common.c

Static code scan issues seen in File: /kernel/posix/pthread_common.c
Category: Integer handling issues
Function: timespec_to_timeoutms
Component: Kernel
CID: 185275
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

not valid anymore, closing this issue.


[#103779820] Improve messaging for removed users.

Part of this bug fix: https://www.pivotaltracker.com/story/show/103779820
When a supplier removed a user from their supplier account the message said that they could re-invite the user at any time.  This isn't entirely true, as Nicole will have to re-activate the user first.
Rather than spell this out in a lengthy flash message (as re-adding a removed user is an unlikely edge case), it's better to just confirm that the user has been removed.
Depends on:

[ ] https://github.com/alphagov/digitalmarketplace-utils/pull/166/files

:+1:


Avoid Java 17 printing a warning about the SecurityManager

One of the planned clean-ups of Java that's happening is the removal of the SecurityManager. The plan is to replace it with utilities and methods that provide similar capabilities but in a more controlled way.
In order to make this process smoother, the JRE now prints a warning when System.setSecurityManager() is called.
A common use-case for the Security Manager is to prevent people calling System.exit() in untrusted code. Indeed, this particular case is called out in the JEP:
https://openjdk.org/jeps/411
Now, people using the JUnit5 runner don't really deserve to see this warning. There's nothing they can do about it, and we're fully aware of the impending System.exit apocalypse. Worse, many of users are still on Java 11, and setting the security manager there is totally legit behaviour, and in no way frowned upon.
Fortunately, Java 17 offers a system property we can call to disable the warning. That system property is java.security.manager with a value of allow. Java 17 knows that allow is a fine thing to say, and simply disables the warning about the security manager.
The bad news is that in Java 11 the very self-same system property is used to set the security manager. In fact (!) it's used for that in Java 17 too, but only if the value isn't one of default, disallow, or allow. The way it does this is by passing in a class name.
So! In Java 11, calling -Djava.security.manager=allow tells the JRE to set the security manager to the class who's name is allow. You can guess how well that goes down.
Well then. That's fine. We'll just use the name of our own security manager as the value of the system property, and we're all good, right? Except our security manager was never really designed to be used this way. Much of this PR is just shuffling code around so that we can use our own security manager as the default security manager.
So, how's your yak?

This PR depends on #88 in order to finish wiring up the security manager properly.

Doesn't work for me, but a quick tweak on top does it. Kindly have a look at #92.


Fix(Carousel): Moved carousel buttons below carousel div to correct c…

…lickthrough #723
@blynch11p @skhtet @rkenyon1969

:+1:


cnn_lidar_detection

Hi, I found there is a branch named cnn_lidar_detection, but it seemed the model and net struct did not release. so I can not test this version.
so , can you guys release a model , and let us learn the method in the cnn_lidar_detection branch?

This is still experimental @mjjdick we'll release this in a near future : )


code editor areas don't data bind correctly

Need to fix this for them to be more usable on the preview / edit board

fixed.


Application appears in wrong language

Microsoft PowerToys version
0.71.0
Installation method
GitHub
Running as admin
No
Area(s) with issue?
General
Steps to reproduce
First install on a first install of Windows 10 22h2
OS language: Dutch
Location: Switzerland
✔ Expected Behavior
App appearing in Dutch language in leu with the OS language
❌ Actual Behavior
The app appears in German
Other Software
None I only run Powertoys

/dup https://github.com/microsoft/PowerToys/issues/7670


Badge Request for a friend

Username and Discrim: LSD_FREE_2020#3209
User ID:<PHONE_NUMBER>36261936
Image Link: https://i.imgur.com/QKLqAwM.png

Username and Discrim: omelet#7407
User ID:<PHONE_NUMBER>23672832
Image Link: https://i.imgur.com/4zD2ih1.png

two requests :) actually i might make more

the images don't seem transparent, is that intentional or?

the images don't seem transparent, is that intentional or?

wtf

the images don't seem transparent, is that intentional or?

wtf

let me know when you make them transparent and i will add them

alright both comments are edited try now

oh.

oh.

idk why imgur didn't make them transparent

weird. anyways added both :D

weird. anyways added both :D

TYSM


Isolated Projects dogfooding

Initiative to reach a point when Isolated Projects can be used in the gradle/gradle build.
### Adoption changes
- [ ] https://github.com/gradle/gradle/pull/28696
- [ ] https://github.com/gradle/gradle/pull/29267
- [ ] https://github.com/gradle/gradle/pull/28929

@alllex Could you add labels, please?


Add observatory location to SubarrayDescription

the SubarrayDescription (built currently in each EventSource) should contain the location of the observatory as an astropy.coordintates.EarthLocation.  This is needed e.g. for some coordinate transforms.
I suggest we add it as a field called "location", so we can do things like:
subarray = SubarrayDescription(...)
elevation = subarray.location.height
# <Quantity 2124. m>

Done in #1980


Unable to train datasets

Hi,
I put the datasets in the data file,
and execute this command：$python main.py --dataset=CelebA --use_gpu=True ,The following bug:
Traceback (most recent call last):
File "main.py", line 4, in
from trainer import Trainer
File "E:\product\faceVerification\faceAttributes\BEGAN-tensorflow\trainer.py", line 4, in
import StringIO
ImportError: No module named 'StringIO'
Thank you for your help!

Are you using python3?

yes

StringIO   Change io

Hi,
Traceback (most recent call last):
File "main.py", line 42, in
main(config)
File "main.py", line 28, in main
config.data_format, config.split)
File "E:\product\faceVerification\faceAttributes\BEGAN-tensorflow\data_loader.py", line 22, in get_loader
with Image.open(paths[0]) as img:
IndexError: list index out of range
Thank you for your help!

Did you run this?
python download.py

I could download CelebA dataset using Baidu Drive.

The error said that data_loader.py couldn't find the images. You need to put *.jpg into BEGAN-tensorflow/data/CelebA/*.jpg.

Hi,

Thank you for your help!

Hi,

Thank you for your help!

Hi,

Thank you for your help!


[Event Request] Codeunit 90 Modify property var for parameters of some publishers

Hello,
We need to modify parameters of some publihers with the property var :

  [IntegrationEvent(false, false)]
    local procedure OnInsertReceiptLineOnBeforeCreatePostedRcptLine(**var** PurchRcptLine: Record "Purch. Rcpt. Line"; **var** WarehouseReceiptLine: Record "Warehouse Receipt Line"; PostedWhseReceiptHeader: Record "Posted Whse. Receipt Header")
    begin
    end;

   [IntegrationEvent(false, false)]
    local procedure OnInsertReceiptLineOnBeforeCreatePostedShptLine(**var** PurchRcptLine: Record "Purch. Rcpt. Line"; **var** WarehouseShipmentLine: Record "Warehouse Shipment Line"; PostedWhseShipmentHeader: Record "Posted Whse. Shipment Header")
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnCreatePostedWhseShptLineOnBeforeCreatePostedShptLine(**var** ReturnShipmentLine: Record "Return Shipment Line"; **var** WarehouseShipmentLine: Record "Warehouse Shipment Line"; PostedWhseShipmentHeader: Record "Posted Whse. Shipment Header")
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnCreatePostedRcptLineOnBeforeCreatePostedRcptLine(**var** ReturnShipmentLine: Record "Return Shipment Line"; **var** WarehouseReceiptLine: Record "Warehouse Receipt Line"; PostedWhseReceiptHeader: Record "Posted Whse. Receipt Header")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11007.


Always run bootSearchable method

This PR adjusts the bootSearchable method to run each time the trait is used, which matches the behavior of the default Scout Seachable trait.
By only running this once, we risk issues observers or macros not being available that Scout requires. We were running into an issue with our tests where the ::searachable() and ::unsearchable() methods were not available on the Eloquent builder unless we ran the test using those methods before any other tests. This is due to the application being refreshed between tests, and since the $isSearchableTraitBooted stays true, this trait wasn't being booted again and thus the macros required by Scout weren't being loaded.
I'm sure there are other places where the current implementation could be causing issues, but the above example is just the one that we ran into.

I'm facing the same issue. Hope to see it merged soon! 👍

@babenkoivan @mwisner Any update on this?

Hi @aaronhuisinga
Thanks for your PR. Sorry for our delay to reply, @babenkoivan seems to be busy, but I think that I can help here.
Could you please explain why this is needed? Also, @babenkoivan I don't understand why this package overrides the original Searchable trait, could you explain it?

Hey @iget-esoares - thanks for taking a look at this!
As I'd stated in the PR, our case where we're having an issue with this implementation is in tests, but my assumption is that it likely causes issues in other cases as well.
In the default Scout Searchable trait, the bootSearchable method is run every time the trait is loaded. For some reason, this package overrides the trait and uses a check to see if this method had previously been run. If it has, it doesn't run it again.
In our case, Laravel must be doing some tearing down of registered macros between tests, including the searchable() and unsearchable() macros that are registered in the bootSearchable method. So even though it's been previously run, using the Searchable trait past the initial usage will not fire the bootSearchable method, and the macros are not properly registered. This leads to "method searchable() does not exist" when trying to call the searchable() macro method.

Hi @aaronhuisinga, thank you for your contribution!
Back in the days Laravel had some issue and could boot traits several times. It lead to a situation, that Searchable trait was registered more than once and for example, when you removed a model, the engine sent several queries to ES to delete the model and only the first one was successful.
I checked that Laravel checks now if traits were booted or not, so we should be safe here.


Feedback

Thanks for this package man.
It was really helpful, since sizeof over estimates and firestore doesn't offer any cloud/sdk tools to track these sizes.
I really appreciate it.

I'm glad you found it useful!😊


Questions about data sampling in the perturbation tutorial

Hi, thanks for your geat work! In the released perturbation tutorial, I saw you set the max_seq_len=1536 during training stage. I think this would ignore much information. I would like to ask if the perturbation results shown in the paper are also based on models trained with sampling? If so, how did you determine the value of 1536? Thanks a lot!

Hi, thank you for the great question. Yes, we reported the results based on this setting with max_seq_len=1536. Note that the model will randomly sample 1536 genes out of the whole input in each iteration, so during training across iterations, it will still see all the input genes and expression. The number 1536 is selected simply based on a balance between training time, memory consumption, and performance. Theoretically, as you said, including more genes during each iteration would potentially increase the performance further. While we did try training with max len equaling all pre-selected ~5500 hvgs on the experiment datasets, interestingly, we found that training on max length of 1536 already provides comparable results while being much faster, so we used this setting.

It is a very interesting conclusion. I will try that. Thank you so much!


Swap ember-inline-svg for ember-svg-jar

📖 Description
ember-inline-svg doesn’t look maintained anymore so we switch to ember-svg-jar. While changing the SVG setup, we add a config to svgo to avoid id clashes when including several files with the same ids in them.
🦀 Dispatch

#dispatch/ember

🦀 Requesting reviewers for this pull request:

@pboutin (contributor with 0 commits in the last 90 days and 8 commits overall)
@garno (reviewer for the ember stack)


fix plugin_app error in Open edX make it a dictionary again

Aparently Open edX can't work with @property and expects a regular dictionary. This PR fixes the error below in Open edX:
AttributeError: 'property' object has no attribute 'get'

@OmarIthawi looks really good, thank you!


Stabilize alloc feature

Currently, this feature requires the nightly feature active to explicitly opt-in to unstable features, but this is no longer needed because rust-lang/rust#59675 has been merged.

Wooot! :)


[FLOC 3429] Add a concept topic about Flocker Leases

Fixes 3429
As part of the updates on the Flocker Concepts section of the docs, this addition explains the concept of Flocker Leases.

LGTM, thanks.


Please can we have resource counts for ELBs and EKS clusters?

Please can we have resource counts for ELBs and EKS clusters?
I see code for listing the EKS clusters in the resource-count-aws.sh script but no flag for it. Same for the ELBs as well.
Thank you.

If cwp is specified as a parameter:
https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L56
We do count EKS clusters:
https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L528
https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L259
https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L498
And we always count ELBs:
https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L259
You can verify this by adding -x to line 1 and running.
https://superuser.com/questions/1537905/what-does-x-mean-in-this-line-bin-sh-x#:~:text=What x mean in the,entire script in debug mode.


dispatcher: schedule deletion for next event loop iteration

Signed-off-by: Jose Nino<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

closing in favor of https://github.com/lyft/envoy-mobile/pull/1048


handle local constants

This one isn't complete, but the test shows a current deficiency. As you probably know Ruby's constant resolution first does a .nesting pass and then a .ancestors pass. This code isn't handling the nesting correctly by just assuming the one child provides the context.

When we were doing our constant resolution build step we found this resource to be pretty good: https://cirw.in/blog/constant-lookup.html . From reading the code I think you're not doing Module.nesting at all.

It is now complete and I updated the summary

It didn't pass on 5 ruby versions (probably because of the eval(Module.nesting)) but they are deprecated and I would vote to remove them from the .travis.yml file
Ruby: 2.1.0
Ruby: 2.1.2
Ruby: 2.1.3
Ruby: 2.1.4
Ruby: 2.1.5


Bug: First interval is drawn over top of the border

When chart interval lines are enabled the very first interval line is being painted over top of the border. One of the two need to be removed because together they form a bug.

Hi @shamilovtim
I think this issue can be closed,
what do you think?

No matter the size of the interval the first interval will always be painted on every users chart so every user who has an interval and a border will experience this bug and will need to write code to handle it. If the border is enabled there's no reason to leave it to the user to stop the interval from being draw over top of the border. So I would say it's still valid and still a bug.

Okay, it makes sense,
you are completely right.
we will skip the first and last interval,
agree?

Yup exactly

Thanks!

Fixed in 0.8.1, thanks for reporting.

There's a regression where this problem appears again but only for the last border

It will be fixed in the new version,
I think we have an issue for this reported by you?

@imaNNeoFighT  The other issue caused this regression again, then the other issue got closed.


[DOCS] python is not a valid language identifier

The docs indicate -l python should be used, but the source indicates the identifier is actually python3. I would be happy to update the docs, but I wanted to first ask if which identifier is desired/correct (or perhaps both?).

@ttymck thanks for pointing this out,  I think both should be valid identifiers, the code should also be changed to reflect this.


Update sky130A_mr.drc

Hi Marwan,
I approved the change.
David
On Wed, Apr 3, 2024 at 11:23 AM Marwan Abbas @.***>
wrote:

@marwaneltoukhy https://github.com/marwaneltoukhy requested your review
on: #271 https://github.com/efabless/mpw_precheck/pull/271 Update
sky130A_mr.drc.
—
Reply to this email directly, view it on GitHub
https://github.com/efabless/mpw_precheck/pull/271#event-12344050856, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BFSQ4KLXP2VF42DNPWVNGILY3QNGJAVCNFSM6AAAAABFVQ22S2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGM2DIMBVGA4DKNQ
.
You are receiving this because your review was requested.Message ID:
@.***>


ci: enable on all branches

This PR enables the CI on all branches and for pull requests with any target branch.
Additionally it upstreams a patch from @zrgt fixing an incorrect initializing assignment.

CI looks good to me, technically, commit 8b76c04c7ab8826ad809d16573846d0adfb1568e does not belong into this PR, but since it's very minor, I'd be okay with it.
@FrankSchnicke  Can you please merge this PR?


Update suggested webpack loader for minifying literals

This just updates the suggested webpack loader to match the suggested rollup plugin so that they are both using the same minifier under the hood.  This package is also more mature than the current suggestion.

thanks for the submission


Errors are logged in database, but /elmah stays empty

I have a weird problem that I can't seem to figure out.
I installed the Elmah.MVC package, added the required connection string, as well as <errorLog type="Elmah.SqlErrorLog, Elmah" connectionStringName="ElmahConnectionString" /> to the <elmah> section in Web.config, and the error logging is working fine — exceptions thrown are logged in ELMAH_Error table in the database.
However, when I open the log panel at /elmah, it says "No errors found."
What could I be missing?

Just diagnosed this issue, I think. I had the same problem.
Dropped and created stored procedures and storage table and now the admin area is working again.


Request headers are not sent

Description
In version 0.10.0 the headers does not seem to be added. Tho you can still see them in the headers list if you log in the middleware the resulting request does not seem to use them.
Reproduction
I noticed it by my backend erroring since a header was missing.
This does not work:
const response = await client.GET('/my-endpoint', {
   headers: {
     'my-header': 'something'
   }
});

Neither does setting it on the client directly:
export const client = createClient<paths>({
  baseUrl: 'https://....',
  headers: {
     'my-header': 'something'
  },
});

If helpful i noticed when poking around in the files that changing line 117 in the compiled /dist/index.js
from
let response = await fetch(request.url, request);

to
let response = await fetch(request.url, {
  headers: request.headers
});`

will actually work. So I'm assuming there is something going on with the request object there.
Expected result
Header to be sent with it!
Checklist

[ ] I’m willing to open a PR (see CONTRIBUTING.md)

I’m not able to reproduce this myself; I’m seeing headers passed both in a browser and in Node.js (18, 20, and 22). Are you able to look at all the existing header tests and determine how your setup differs from what’s currently being tested (e.g. are you using a custom fetch? are you in another env such as Deno we’re not testing?). I think there’s another missing piece here to your setup that’s causing headers to get missed; I don’t believe that line change you suggested is the root of the problem though.

I had the same issue today, in a NextJS 14 project that follows the example in the docs.
Headers are not sent, even though they would seem to be there at build time. Adding a console.log in the coreFetch function and running the build command will output the auth headers I was adding, but they seem to be ignored on run time.
In a regular native fetch without this library, my auth headers works correctly.

Seems to me this was fixed in a newer version, so closing this issue. Nice!


"Could not connect: Outdated server!"

Version of Waterdog

This server is running Waterdog version git:Waterdog-Bootstrap:1.15-SNAPSHOT:cb61ce3:312 by md_5
Expected Behavior

Actual Behavior

Crashdump, Backtrace or Other Files

Describe the bug

When i tried joining the server on waterdog, it prompted me with a "Could not connect: Outdated server!"
To Reproduce

Screenshots

Server software used:

Pocketmine
Additional context

Also i dont know what happened but the download link for waterdog isnt working anymore >=c

I apologize for this bug report, i just checked the previous bug report and it worked


Feature Management Update Schema

Description
Updates the schema to be snake case.

API change check
API changes are not detected in this pull request.


Cant get the symbols to render

Environment
OS: Bash on Ubuntu on Windows
Vim Version: 7.4
Plugins
Gundo
NerdTree
Nerdtree-git-plugin
syntastic
vim-airline
vim-colors-solarized
vim-devicons
vim-distinguished
vim-javascript
vim-material-monokai
vim-monokai
vim-nerdtree-syntax-highlight
vim-sensible
Nerdfont
LiterationMono NF
ISSUE
When I copy the vimscript:
let g:NERDTreeIndicatorMapCustom = {
\ "Modified"  : "✹",
\ "Staged"    : "✚",
\ "Untracked" : "✭",
\ "Renamed"   : "➜",
\ "Unmerged"  : "═",
\ "Deleted"   : "✖",
\ "Dirty"     : "✗",
\ "Clean"     : "✔",
\ 'Ignored'   : '☒',
\ "Unknown"   : "?"
\ }
to .vimrc it does not display the symbols between the quotes, and in the nerdtree it only appears a square in some cases.

same problem.. any fix?

Sorry, too late
Does it work now?


[4.0.2] previously focused window retains focus when moving to an empty space

With both kwmc space -fExperimental and OS X's built-in space movement, after I do this:

focus, for example, a text field in Firefox (or anything else that takes text input, like Terminal.app)
move to an empty space (a space with no open windows) using either -fExperimental or OS X's built-in space movement
type spooky action

moving back to the original space shows spooky action written in the originally focused item.
So far this is only a problem for me with Firefox in particular, where command + N (in place of typing spooky action above) opens a new window in the original space instead of the just-moved-to empty space.
Perhaps this additionally indicates a bug in Firefox (opening new windows based on the space of the currently focused window instead of the currently open space), but I imagine this is still undesired behavior for kwm.
Lastly--for what it's worth--I'm running El Capitan.

move to an empty space (a space with no open windows)

There is nothing to focus on an empty space. A space can't be "focused" according to OS X, so unless there are windows populating a space kwm can't focus anything on said space.

Sorry, I somehow managed to completely overlook the fact that--without kwm--OS X automatically focuses Finder upon movement to an empty space. I'd mistakenly thought that OS X retained the focus of the last-focused application as kwm does (which I do prefer).

There is nothing to focus on an empty space. A space can't be "focused" according to OS X, so unless there are windows populating a space kwm can't focus anything on said space.

What is OS X doing internally when you refocus an application owning no windows in the current space (and you've unchecked the system preference "When switching to an app, switch to a Space with open windows for the app")?
If I perform the repro steps as above, but I unfocus and refocus Firefox just before typing spooky action, then no spooky action actually occurs. Could this behavior be robustly emulated by kwm?
I briefly attempted the simple workaround of sending commandtab then its reverse (shifted), but khd doesn't report successfully switching the focus (and spooky action still occurs).
As long as the current behavior remains, perhaps this sort of "focus-retention" should only be opt-in in kwmrc (with a warning) considering its potential for (rare) perniciousness.

For what it's worth, I'm currently using this effective but mildly gross workaround:
# avoid Firefox focus-retention bug (when moving to empty space)
ctrl - left [Firefox]          -> : open -a Finder;\
                                    osascript -e "tell application \"Finder\" \
                                    to close front window"
ctrl - right [Firefox]         -> : open -a Finder;\
                                    osascript -e "tell application \"Finder\" \
                                    to close front window"

The Finder window closes before you can see it save some minor edge cases where it pops up for half a second.


jsk_recognition: 1.2.17-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository jsk_recognition to 1.2.17-1:

upstream repository: https://github.com/jsk-ros-pkg/jsk_recognition
release repository: https://github.com/tork-a/jsk_recognition-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.2.15-1

audio_to_spectrogram

No changes

checkerboard_detector

No changes

imagesift

No changes

jsk_pcl_ros

No changes

jsk_pcl_ros_utils

No changes

jsk_perception

No changes

jsk_recognition

No changes

jsk_recognition_msgs

No changes

jsk_recognition_utils
* https://github.com/jsk-ros-pkg/jsk_recognition/pull/2648 requires jsk_data package (#2805 <https://github.com/jsk-ros-pkg/jsk_recognition/issues/2805>)
* Contributors: Kei Okada

resized_image_transport

No changes

sound_classification

No changes

Holding for Noetic sync


Describe image name format for private registries

Configuring the plugin for private registries involves including the
registry name within the image name. Add a note to README.md.

Thank you for the PR.


Camera loads a static image

I tried to install this game. The camera would only take a snapshot.
Console Error: Uncaught (in promise) OverconstrainedError in movenet-space-invade…n.up.railway.app/:1

What OS and browser are you using?
I currently tested it on Windows OS , with Chrome 120 and Edge 120
Make sure to  enable the camera in the browser.
OverconstrainedError seems like an error related to the webcam camera

Linux (PopOS) with Brave.
I tried again and instead of giving it permission till I close the site I gave it 24h and it appears to work. Interesting.

As far as I understood the issue is related to your camera browser config.
I will close the issue


Resource function return hangs http connection

Description:
With the new resource syntax, uses have the ability to return from resources at any point of execution.
And for 'check' expressions, they automatically return the function with 'error' when the 'check' expression found an error as it's operand.
Anyhow if it comes to a place in resource functions where function returns before calling caller->respond(..) method, the HTTP connection seems to hang until timeout.
Steps to reproduce:
import ballerina/http;

service hello on new http:Listener(9090) {
    resource function sayHello(http:Caller caller, http:Request request) returns error? {
        http:Response response = new;
        response.setTextPayload("Hello Ballerina!");

        // uncomment below 3 lines.
        if (1 == 1) {
            error e = error("The error");
            return e;
        }
        _ = caller -> respond(response);
        return;
    }
}

Affected Versions:
0.990.0

Possible duplicate of #12566

Fixed with https://github.com/ballerina-platform/ballerina-lang/pull/12614 and https://github.com/ballerina-platform/ballerina-lang/pull/12626


mouseAxis Event issue

Hyprland Version
Hyprland, built from branch main at commit 29970228c5f71f417b0a3e1b4851d9430ed095dd dirty (nix: override libdrm to use newer version (4003)). Tag: v0.32.3-95-g29970228
Bug or Regression?
Bug
Description
static void testHook(void* self, SCallbackInfo &info, std::any data)
{
//do something
}

//both works
HyprlandAPI::registerCallbackDynamic(PHANDLE, "mouseMove",[&](void* self, SCallbackInfo& info, std::any data) { testHook(self, info, data); });
HyprlandAPI::registerCallbackDynamic(PHANDLE, "mouseButton", [&](void* self, SCallbackInfo& info, std::any data) { testHook(self, info, data); });

//not working with mouseAxis event, not calling the testHook while using the mouse wheel
HyprlandAPI::registerCallbackDynamic(PHANDLE, "mouseAxis", [&](void* self, SCallbackInfo& info, std::any data) { testHook(self, info, data); });

Am I doing something wrong or is this event not working with HyprlandAPI ?
How to reproduce
try the code
Crash reports, logs, images, videos
No response

it doesn't exist: https://wiki.hyprland.org/Plugins/Development/Event-list/

Do you have any plan to implement axis and keypress events for plugins?


Update BACKUP/RESTORE syntax to match the RFC; Added IMPORT statement(#824)

cherry-pick #824

What problem does this PR solve?
Update the parser syntax to match pingcap/tidb#15274.
What is changed and how it works?

Removed the S3/GCS-specific options
Removed the "INCREMENTAL UNTIL" syntax, replaced by the "LAST_BACKUP" option
The "SHOW BACKUP" statement is renamed to "SHOW BACKUPS".
Added "IMPORT" statement (fix pingcap/tidb-lightning#293)

(Recommended: ignore whitespace when reviewing).
Check List
Tests

Unit test

Code changes

Has exported variable/fields change

Side effects
Related changes

LGTM


Syntax highlighting breaks without any reason. (Javascript)

From @ebastuart on August 24, 2016 8:41

VSCode Version: 1.4.0
OS Version: Windows 10 64bit, latest updates

the highlighting breaks without any reason. there are no errors and the code is valid, but the code remains white (no highlighting)  down to the end of the file.

Copied from original issue: Microsoft/vscode#10878

From @wallverb on August 24, 2016 18:30
Maybe related to this https://github.com/Microsoft/vscode/issues/9937

From @alallier on October 4, 2016 16:1
I've seen this happen in many different occurrences, mainly in longer files. Could this be a file length issue?

From @alexandrudima on August 25, 2016 14:22
@ebastuart Is it possible to share the file with us so we can track down the problem and check if it is an issue with the grammar

From @alallier on October 7, 2016 12:48
@alexandrudima The files I am working on contain sensitive data, so I can't attach them to an issue. I've been meaning to work up a dummy file I can attach to show the problem I am running into.
@ebastuart it doesn't seem to be a nesting problem for me

From @ebastuart on October 6, 2016 13:49
@alallier it is a nesting issue ... if you have to much code nested in each other it will break the highlighting.

From @jdalton on October 13, 2016 22:2
If you're looking for a large file which stops highlighting you can check out:
https://raw.githubusercontent.com/lodash/lodash/4.16.4/lodash.js

From @alexandrudima on October 6, 2016 13:27
@alallier When you notice this, please create an issue and attach the file or a similar file that reproduces the issue.

Closing as fixed
@ebastuart Please let us know if you still see this issue in VSCode 1.8.1+. If you do, please provide some sample code so we can investigate.
Thanks

From @alexandrudima on October 24, 2016 17:17
@jdalton we regularly update our JavaScript TM language (we take it from https://github.com/Microsoft/TypeScript-TmLanguage). With the latest version we have in master (insiders build stream) lodash appears to be colored fine.

From @djlooney on November 14, 2016 20:35
Not sure if you are still in the market for a nonsensitive file. Here is an un-minified js resource loaded by twitch.tv which has issues for me starting at line 4825. The lodash file from earlier in the thread has no issues for me.
https://gist.githubusercontent.com/djlooney/4ec6a2a55f778d11bd95eb9bbc87fe28/raw/6c7cc59860114382420eec82d55a7bd630f94133/sample.js

From @djlooney on January 10, 2017 2:39
I am still having issues with some of my large files on 1.8.1. Attached is a js file which has no syntax highlighting after line 4823, and an attached screenshot of what I see.
https://gist.githubusercontent.com/djlooney/4ec6a2a55f778d11bd95eb9bbc87fe28/raw/6c7cc59860114382420eec82d55a7bd630f94133/sample.js
http://imgur.com/a/B2A4U

I just tested this with the latest grammar. Using the file that @djlooney provided, I see highlighting break in a number of places, staring at around line 3274:


Laravel 10 Support

Hi Abanoub!
This PR will add support for Laravel 10 for new project.
Thanks for the package btw! Love it

@AbanoubNassem can you also tag a new version? so that the packagist will detect the changes, thanks

already did.


add catch2 include_dirs to cmake

Pull Request Title
Fixes #345
Task List

[x] add pkg-config detection of catch2 to CMakeLists.txt
[ ] Updated the README or other documentation

Change Description

Previously CMake could only compile PrognosticData_test.cpp is catch2 is installed in the /usr dir.
I have now added the option to detect via pkg-config which will allow spack install

Pre-Request Checklist

[x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[x] No new warnings are generated
[ ] The documentation has been updated (or an issue has been created to track the corresponding change)
[x] Methods and Tests are commented such that they can be understood without having to obtain additional context
[x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[x] File dates have been updated to reflect modification date
[x] This change conforms to the conventions described in the README

Catch2 is no longer used in the nextsimdg project. This PR can be closed.


Fixing strange parallelism in folder deletion

Description

Checklist

[x] Tests have been added/updated to verify that the new or changed code works.
[x] Docstrings were included and updated as necessary
[x] The code is understandable and maintainable to people beyond the author
[x] There is no commented out code in this PR.

If user exposed functionality was added/changed:

[x] Documentation added/updated in the doc folder.
[x] New or updated dependencies have been added to setup.py.

@davis8dd  Thanks, David!   I was a bit busy yesterday, but I will review it today!

I'm afraid this PR was kind of left in stasis for too long, and the problem was fixed elsewhere.
Thanks for volunteering!


Change site Logo based on Tenant

As a Super Admin i want to be able to upload a logo to a Tenant so that the site has the branding I want.

Verified, the sites are showing up different branding based on tenant. Links used to verify are as below:
https://met-web-dev.apps.gold.devops.gov.bc.ca/eao
https://met-web-dev.apps.gold.devops.gov.bc.ca/emli


c++ example code is wrong!!

[Enter feedback here]
C++
Copy
int (**p) () = new (int (*[7]) ());
delete *p;
the code for C++ should be( without *):
int (**p) () = new (int (*[7]) ());
delete p;
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ba500f8a-29af-57af-704f-78b0cf3a1588
Version Independent ID: a280744d-1e46-b36a-3d65-c33761c6835c
Content: new operator (C++)
Content Source: docs/cpp/new-operator-cpp.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

@willerwu
Good catch, and thanks for the report. We've published a fix that's visible now.


Segmentation fault problem when lookup after bulk load

I write a simple test where the index first bulk load 2000000 keys, then carry out lookup operation one by one. But there will be a segmentation fault.
TEST(Alex, TestLookup) {
    Alex<int, int> index;
    Alex<int, int>::V values[2000000];

    for (int i = 0; i < 2000000; i++) {
        values[i].first = i;
        values[i].second = i;
    }

    std::sort(values, values + 2000000,
        [](auto const &a, auto const &b) { return a.first < b.first; });
    index.bulk_load(values, 2000000);
    EXPECT_EQ(2000000, index.size());

    for (int i = 0; i < 2000000; i++)
    {
        EXPECT_EQ(2000000, index.size());

        auto it = index.find(i);
        EXPECT_TRUE(!it.is_end()) << "The index of iterator is " << i;
        EXPECT_EQ(i, it.key());

        int *p = index.get_payload(i);
        EXPECT_TRUE(p);
        EXPECT_EQ(i, *p);

        EXPECT_EQ(2000000, index.size());
    }

    for (int i = 0; i < 2000000; i++)
    {
        auto it = index.find(i);
        EXPECT_TRUE(!it.is_end()) << "The index of iterator is " << i;
        EXPECT_EQ(i, it.key());

        int *p = index.get_payload(i);
        EXPECT_TRUE(p);
        EXPECT_EQ(i, *p);
    }
}

Thanks for bringing this issue to our attention. We'll look into it.

The issue should now be fixed, based on #6

The issue is fixed. Thanks for your great work.


KAFKA-9581: Remove rebalance exception withholding

The rebalance exception withholding is no longer necessary as we have better mechanism for catching and wrapping these exceptions. Throw them directly should be fine and simplify our current error handling.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

cc @mumrah

okay to test

test this please

test this please

test this please

test this please

Only the flaky test failed: kafka.admin.DescribeConsumerGroupTest.testDescribeGroupMembersWithShortInitializationTimeout
for https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/856/
with 1/2 green

LGTM! Merging to trunk.


Requirement conflicts when mixing named and non-named specification for a package

[packages]
jinja2 = { git = 'https://github.com/pallets/jinja' }
flask = '*'

Jinja2 would have only one candidate (the VCS checkout), but this cannot satisfy Jinja2 (>=2.10) (specified by Flask). I’m not sure how this should be handled… maybe the checkout needs to read the package’s version. But how should we store it… just using Requirement.specifiers?

OTOH, pip does not support URL-based (including VCS) dependencies (PEP 508, PEP 440), so if we ever find ourselves in this situation, it must be caused by a user specification. I guess we can simply trust the user to know what their doing.

Right, I don't think this is a bug.  However, if the user specifies the VCS url in dev-packages then it would be a bug to prefer it over the actual resolution if they don't specify --dev

The implementation there might not be totally right -- you may want to always prefer editable requirements but not necessarily always prefer a requirement just because it has a link

It is not right in general, but right for the currently available in Python packaging (i.e. pip). I’ll do better when pip can do better :p


Update segment library to 2.4.7 to get GA working

JIRA: https://openedx.atlassian.net/browse/MOB-1567
cc @aleffert @nasthagiri @shahidtamboli

Should we just use gradle for this instead?
https://segment.com/docs/libraries/java/ suggests
compile 'com.github.segmentio:analytics:LATEST'

I'm a little wary of just doing LATEST, but we could do 2.4.+ or something?

@aleffert We need custom integration of segment as we need GA to be integrated. I merge this and will check if gradle dependency works for us.
I will work on this branch but will create new pull request if gradle compile dependency works.

Hi @aleffert , With gradle dependency, we cannot include only GA integration in the custom build of segment. We have to include all their integration which increases size of the build (from 6.4MB  to 7.0MB).
I suggest not to go with gradle dependency for segment.
@nasthagiri  What are your thoughts on this?
Please check this https://segment.com/docs/libraries/android/#custom-builds

According to that page you can solve that problem by just including the "core" artifact and then bring in individual libraries.
It looks like the jar we're adding here is exactly that "core" version of the library, so I think they should be equivalent?


Create documentation for pipeline configuration v2

Update the documentation in the conduit repo and on conduit.io to describe the new pipeline configuration format 2.0.

We should explain the behavior when two or more pipelines contain the same ID (pipelines with the same ID are skipped and warnings are logged). See https://github.com/ConduitIO/conduit/pull/926#discussion_r1134020256.

Done in https://github.com/ConduitIO/conduit-site/pull/28.


Need for VNet Peering in DR Scenario

Our customer is wondering why the following diagram (found here) specifies network peering between the two spokes. Mays, Chris and I were discussing, and can’t figure out why it would be needed. In fact, this other AVD DR documentation doesn’t mention any need for peering at all.
Questions:

Is the peering really needed for either active-active or active-passive?
If so, why?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 573d378d-d411-98d6-6d7d-78b73c3d17a9
Version Independent ID: d362913b-c241-5d25-209c-dca5a6f4c01c
Content: Azure Virtual Desktop disaster recovery concepts
Content Source: articles/virtual-desktop/disaster-recovery-concepts.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@gamullen
Thanks for your feedback! We will investigate and update as appropriate.

@gamullen
Based on the document you provided, it seems that the virtual network peering is not a requirement for disaster recovery for shared host pools in Azure Virtual Desktop. The diagram you mentioned in the document is just an example of how the virtual networks can be connected to each other.
In fact, the other AVD DR documentation you mentioned also does not mention any need for peering. Therefore, it is safe to say that virtual network peering is not a requirement for disaster recovery for shared host pools in Azure Virtual Desktop.
However, if you want to connect two or more virtual networks in Azure seamlessly, virtual network peering can be used. The peered virtual networks appear as one for connectivity purposes. The traffic between virtual machines in peered virtual networks uses the Microsoft backbone infrastructure. The traffic between the client application and the flexible server in peered VNets is routed only through Microsoft's private network and is isolated to that network.

If the VNet peering is not required for this DR scenario it should be removed, as it is confusing. Typically spokes do not communicate with each other in a hub-spoke networking architecture.


⚠ Bofrost.be has degraded performance

In b039e72, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1384 ms

Resolved: Bofrost.be performance has improved in 452fda4.


Add domain_query option

Solves Issue #278 .
As suggested by @rschwant , adds optional keyword "domain_query".
To avoid breaking old code, sets the default value for "domain_query" as True.
EDIT: I forgot to mention: I have tested this with airnow_wrfchem.ipynb, adding False domain_query and giorgi and EPA regions.
Cheers
Pablo

@zmoon, should we call it something else then?
domain_metadata=True (default, use metadata from observation file to determine domain)
domain_metadata=False (use build in features in MONETIO to determine metadata since it is not provided?)
Open to other options too?

should we call it something else then?

I feel it could be done just with domain_type with a special syntax. For example

domain_type: auto-region:giorgi -- group on the fly using the rectangles (this PR method)
domain_type: giorgi_region -- current behavior, using column giorgi_region in the dataframe

I like this method too. This may be easier to explain in the docs too.

OK, I'll try to add that now.

I think the proposed config format (domain_query=False) is kind of confusing. In a sense it's still a query, just based on automatic lat/lon box. To me this feels more like a "domain query" than the original using site metadata already present in the dataframe.
Also, the Giorgi regions actually are rectangles so that's fine. But I would skeptical about suggesting people use the EPA region rectangles, which are pretty rough estimates.
I have a little project for assigning to precise EPA regions. But it uses GeoPandas which is a heavy dependency.

If we end up adding optional regionmask, that would include geopandas as a requirement.

@blychs do you want to mention these new option in the docs YAML section?

I don't understand the failed tests...  I don't believe I changed any of that?

@zmoon One of the tests is failing because it does not find noaa   https://www.ncdc.noaa.gov/crn/  . Is it just out or does that link require updates?

We are linking to data that normally is stable, but is located at the Asheville office, so it's likely that the recent hurricane took down some of their servers. Let's see if it's back up and running tomorrow and go from there. We can re-run the checks then.

It seems the NCEI/NCDC websites are still having issues: https://www.ncei.noaa.gov/node/6696

@zmoon do you approve this now, since you have looked at this closer than me? If so, I will merge without the checks passing as it might take NOAA awhile to fix the servers in Asheville.

@blychs were you able to test that it seems to work?

Wait, something is wrong. Nothing breaks (I had tested it) but it seems to not be doing anything. I'll fix it right away

OK, it was in effect being skipped. I had tested it with the airnow_wrfchem example, nothing broke, and I was happy with it.
Now it should be fine. I just tested it with that example, running it with and without auto-region:epa and auto-region:giorgi.
I don't have an aircraft example though.
We were not supporting anything like this for satellite before. This might work for it but I haven't tested it.


Improving UI of Form Stop Page of Web-App

The files are rstop.js and its respective stylesheet in styles folder

working on it ! 🙌


Added a new step when git is not installed. Fixes #125349

Added a step to Install Git in Getting Started page, if not installed already.
This PR fixes #125349

Thanks!

Thanks!

My Pleasure! :)


Improve rich inputs support

Detect cycles in nested properties and fail the build
NestedBeanAnnotationHandler should take care of everything related to @Nested

@lptr Please have another look.

@lptr Please have another look.


lake new should add lakefile.olean to the .gitignore

@semorrison It already does?

Version mix-up on my part, sorry for the noise!


Subverse.Client Barebones Implementation

Implements a barebones SubverseNode client in C#

Might wanna fix those commit messages in a squash!


Use idpHostName instead of customURL

What is the problem?
Cannot use idpHostName in the preferences.
Expected behavior
Be able to get a password from WebView.
Actual behavior
Unknown Provider.
Solution
When using any IdP that is not officially supported, https://github.com/twocanoes/xcreds/wiki/AdminGuide#idphostname says that the preference key should useidpHostName.
However, the implementation uses actually customURL.
I decided that idpHostName was more appropriate from a processing standpoint as well.

Ops, it was already fixed in the development version.
https://github.com/twocanoes/xcreds/commit/83947497ec00cdfd7ec3b9a3683fa3b8e007aadf


grpc: move ifdefs out of headers.

Description: It is problematic to have ifdefs for fields in class definitions in a header file that's used at the boundary of Envoy as a library, such as main_common.h. This PR moves the ifdef into the .cc file so that the compilation of that module is the only one that needs to see the ifdef
Risk Level: low
Testing: //test/common/grpc/...
Docs Changes: n/a
Release Notes: n/a

@envoyproxy/senior-maintainers


Make consistent chats easier to save and restore

This SDK could also make it so that chats could become consistent between different sessions.
As of right now, people could wrap around chats and models to recreate the chats from history but it would be a nice addition if this were already built-in.
With options for the user to save and restore it in a file or something similar.
Any suggestions or considerations are welcome.

How do I even wrap around chats?

I was personally looking into doing something with ChatSession.history but I stopped working on that.


fix flutter analyze --dartdocs

I spent most of this afternoon trying to test this without success.
cc @tvolkert


Rename allowlist to better reflect the wording of modern society

Reviewer:

Description:
I was bored last night after completing the end of Netflix so decided to check out the work involved:

This won't work yet as we need the allowlist for https to change names; we could ignore that part. (https://app.asana.com/0/0/1200710125801716/f)

Relevant e-tag code needs a clean up on browser load.

In sites.js isWhiteListed was removed as it collides with isAllowListed however I couldn't find obvious use for it either. This needs verifying.
The setting syncToStorage and getFromStorage will need to migrate the stored setting data on browser load. This is used by setGlobalAllowlist and others.
Currently untested, it needs lots of that.

Steps to test this PR:

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Closing in favour of: https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/783


Bypassing LAN and mainland address then proxy

How to set up Bypassing LAN and mainland address then proxy

yes
please also add geosite, and ip or website  bypassing


IridescentDishWithOlives provokes MSL compiler error

This does not occur with GL or VK or debug configuration.   Only occurs with ubershader mode in a release configuration.
To repro:
gltf_viewer -u glTF-Sample-Models/2.0/IridescentDishWithOlives/glTF/IridescentDishWithOlives.gltf

Error message:
FEngine (64 bits) created at 0x7f9432800000 (threading is enabled)
FEngine resolved backend: Metal
Selected physical device 'AMD Radeon Pro 5500M'
program_source:504:1: warning: control may reach end of non-void function
}
^
program_source:729:15: error: no matching constructor for initialization of 'half3' (vector of 3 'half' values)
half3 _4509 = half3(_4220.uv, half(1.0));
              ^     ~~~~~~~~~~~~~~~~~~~
note: candidate constructor half3(half, half2)
note: candidate constructor half3(half2, half)
program_source:735:15: error: no matching constructor for initialization of 'half3' (vector of 3 'half' values)
half3 _4540 = half3(_4220.uv, half(1.0));
              ^     ~~~~~~~~~~~~~~~~~~~
note: candidate constructor half3(half, half2)
note: candidate constructor half3(half2, half)
program_source:768:15: error: no matching constructor for initialization of 'half3' (vector of 3 'half' values)
half3 _4793 = half3(_4220.uv, half(1.0));
              ^     ~~~~~~~~~~~~~~~~~~~
note: candidate constructor half3(half, half2)
note: candidate constructor half3(half2, half)
program_source:774:15: error: no matching constructor for initialization of 'half3' (vector of 3 'half' values)
half3 _4824 = half3(_4220.uv, half(1.0));
              ^     ~~~~~~~~~~~~~~~~~~~
note: candidate constructor half3(half, half2)
note: candidate constructor half3(half2, half)

in MetalProgram:366
reason: Failed to compile Metal program.

N5utils17PreconditionPanicE
in draw:1171
reason: Attempting to draw with an invalid Metal program.

libc++abi: terminating with uncaught exception of type utils::PreconditionPanic

Ugh, this is probably a problem with SPIRV Cross. I'll try updating to the latest version this week. If that doesn't fix it, I may have to file a bug report with them.

Thanks Ben!  Looks like it also occurs with StainedGlassLamp.

FYI I created an issue for SPIRV-Tools:
https://github.com/KhronosGroup/SPIRV-Tools/issues/4814


fix: added public_did message type

Signed-off-by: Micah Peltier<EMAIL_ADDRESS>

Actually, we've got some changes to the auto generated backchannel that we probably don't want to include. I'll do a bit of tweaking on this PR by dropping the most recent commit.


Adjust topics you're comfortable with

Adjust Topic and lessons you're comfortable teaching:
| SoRDS curriculum, please adjust
-- | --
dc/cloud | Software carpentry - command line
  | Software carpentry - git
  | Software carpentry - R
  | Software carpentry - Python
dc/python | Visualisation
dc/r | Open and Responsible Research
dc/shell | Research Data Management
dc/spreadsheets |
dc/sql | Computational Infrastructures
swc/git | Information Security
swc/hg | Author Carpentry
swc/make | Machine Learning
swc/matlab | Neural Networks
swc/python |
swc/r | Data stewardship
swc/regexp |
swc/shell |
swc/sql |
swc/svn |

I"m a little confused with the first column - I assume that's the present set of entries?

Yes, that's what's currently in the system and I don't even think that represents a lot of the carpentries. We basically need to figure how detailed the SoRDS curriculum should be reflected here.

The SoRDS curriculum still needs to be implemented, if we confirm that the list in the right column is complete, that should be easy to do.

I've gone ahead and added this to the codebase; please let me know if this list is complete before I deploy it.

Yeap, it can be. We discussed yesterday, I'll also add a few options to group/categorize them more effectively based on Hugh's input.


Cannot parse a geometry only shapefile without a DBF

A user in discord reported not being able to process a shapefile because they didn't have a .dbf file.
I think we should be able to parse such a datasource, provided there's a .shp file, and just treat it as having empty properties while iterating over the geometries.
thread 'open_shp_file' panicked at 'called Result::unwrap() on an Err value: MissingDbf', src/main.rs:256:19
stack backtrace:
   0: rust_begin_unwind
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/panicking.rs:142:14
   2: core::result::unwrap_failed
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/result.rs:1814:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/result.rs:1107:23
   4: geogcn::open_shp_file
             at ./src/main.rs:256:15
   5: geogcn::open_shp_file::{{closure}}
             at ./src/main.rs:249:1
   6: core::ops::function::FnOnce::call_once
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
   7: core::ops::function::FnOnce::call_once
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.

I wonder whether GDAL supports this. But +1 from me, anyway.


russcip fails to compile on Windows MSVC: u32 != i32

Problem
When trying to compile russcip on Windows MSVC, I get a couple of errors that are all similar to this:
error[E0308]: mismatched types
  --> [...]\.cargo\registry\src\index.crates.io-6f17d22bba15001f\russcip-0.2.6\src\branchrule.rs:34:43
   |
32 |     fn from(val: BranchingResult) -> Self {
   |                                      ---- expected `u32` because of return type
33 |         match val {
34 |             BranchingResult::DidNotRun => ffi::SCIP_Result_SCIP_DIDNOTRUN,
   |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `u32`, found `i32`
   |
help: you can convert an `i32` to a `u32` and panic if the converted value doesn't fit
   |
34 |             BranchingResult::DidNotRun => ffi::SCIP_Result_SCIP_DIDNOTRUN.try_into().unwrap(),
   |                                                                          ++++++++++++++++++++

Cause
The underlying reason is that the enum SCIP_Result type is represented by unsigned int on Linux, but by int in Windows MSVC. Apparently this is allowed by the C++ spec:

Declares an unscoped enumeration type whose underlying type is not fixed (in this case, the underlying type is an implementation-defined integral type that can represent all enumerator values; this type is not larger than int unless the value of an enumerator cannot fit in an int or unsigned int.

bindgen then just exposes the underlying type as u32 or i32 to Rust, see https://github.com/rust-lang/rust-bindgen/issues/1966.
In turn, russcip does not handle this type difference correctly, and fails to compile.
Solution
I see a couple of potential solutions:

Tell bindgen to generate an actual Rust enum instead. This might be problematic for the reasons described in https://github.com/rust-lang/rust-bindgen/issues/758, but I don't know how this applies to SCIP specifically.
Expose this type difference to users russcip, by changing all types to SCIP_Result instead of u32. This is annoying because it just pushes the problem onto users, who will probably all also end up with either broken Linux or Windows builds.
Add casts to u32 in all the right places in russcip, at least for windows targets. Then everyone would be using u32 all the time, even though it's not what the underlying SCIP library is using.

I think the last solution is the easiest to implement, and also the best one. I could submit a PR for any solution if that's helpful and a decision has been made.
This might also be the only thing stopping Windows CI from working, in which case it can be turned on again!
https://github.com/scipopt/russcip/blob/cc34f3d7faece624be2c1907fc3def8d0a1e86ea/.github/workflows/build_and_test.yml#L84

Hi @KarelPeeters! thank you for the very well-structured detailed issue. I agree that the last solution sounds like the best fit, and I would be happy to review your PR :)

Since looking into this more and actually putting together a fix, I think the second solution is actually the better one.
russcip already isolates users from SCIP_Result with its own separate enum types, eg. BranchingResult. The functions that were failing to compile earlier are exactly those that convert between those. Of course it's fine if they have to know about the underlying type, their entire purpose is hiding it from users!
I've submitted this second solution as https://github.com/scipopt/russcip/pull/115.