My two concerns:
1, I don't see the results of Ducktape.
2, This comparison in itself does not tell anything.
Comparing a low-end engine with a high-end engine (V8) is quite unfair. Both engines have a different design pattern. In high end engines the main aspect is the performance which has significant memory/stack usage and enormous binary size. JerryScript was designed to low-end devices with restricted resources so the main priority is the low memory usage and the small binary footprint. However, keeping these numbers low work against the performance.
So I suggest to compare only the low-end engines. What I'd call a fair and detailed comparison is:

Engine - Score
Engine - Peak Memory Consumption (KB)
Engine - Peak Stack Usage (KB)

Richards

DeltaBlue

...

Where Engine is one of Jerry, Ducktape or QuickJS.
Also good to mention the supported revision of the standard by the tested engines, since the new language elements above ES6+ are real challenges to the developers to support them without serious engine slowdown.

Binary size (KB)
Standard compatibly

Jerry

Ducktape

QuickJS

JERRY_LINE_INFO

JERRY_LINE_INFO  affect little, and Splay are toooo slow, this should be a bug.

Let's get just a wee bit more professional. "too** slow" is not anything helpful. Same goes for "this should be a bug." Analysis is welcome.

Splay is a specific test for GC. It was designed to test the evolutional GC. Since JerryScript uses single mark&sweep model it wouldn't perform well in this test. However increasing the JERRY_GC_MARK_LIMIT can help this problem but it will also increase the stack usage.

Splay is a specific test for GC. It was designed to test the evolutional GC. Since JerryScript uses single mark&sweep model it wouldn't perform well in this test. However increasing the JERRY_GC_MARK_LIMIT can help this problem but it will also increase the stack usage.

Splay is a specific test for GC. It was designed to test the evolutional GC. Since JerryScript uses single mark&sweep model it wouldn't perform well in this test. However increasing the JERRY_GC_MARK_LIMIT can help this problem but it will also increase the stack usage.

What JERRY_GC_MARK_LIMIT  value suggest to benchmark it?

Splay is a specific test for GC. It was designed to test the evolutional GC. Since JerryScript uses single mark&sweep model it wouldn't perform well in this test. However increasing the JERRY_GC_MARK_LIMIT can help this problem but it will also increase the stack usage.

What JERRY_GC_MARK_LIMIT  value suggest to benchmark it?

I have no optional number to say. Increasing the recursion limit will increase the score and stack usage simultaneously. So keep fine tuning it, I suggest to start doubling it continuously.

I have no optional number to say. Increasing the recursion limit will increase the score and stack usage simultaneously. So keep fine tuning it, I suggest to start doubling it continuously.

@rerobika
For the record, increased to 1024 have on effect
lygstate@DESKTOP-94PU0GB:/mnt/c/work/study/languages/typescript/jerryscript/build/linux$ cmake -GNinja ../..   If you consider this as the source of the slowness a with/without comparison would be great.

Moreover I've tested the engine on splay with lcache and hashmap and without them and there were no significant difference. But feel free to share how that you came to this conclusion.

I guess mainly because of -DJERRY_LCACHE=1 and -DJERRY_PROPRETY_HASHMAP=1
What does it mean exactly? If you consider this as the source of the slowness a with/without comparison would be great.

Moreover I've tested the engine on splay with lcache and hashmap and without them and there were no significant difference. But feel free to share how that you came to this conclusion.

As it was said before, the splay test was created specifically to test garbage collection, and thus uses a lot of memory and creates a lot of fragmentation. The fact that it is slow has nothing to do with the lcache, and verry little with hashmaps (these can have a slight effect on fragmentation).
The reason this test is slow is that the jerry allocator was not designed to handle this much memory, and maintaining the free block list gets more and more costly as the memory get fragmented. I have a few ideas on how to improve the logic behind the allocator to make it less affected by fragmentation, but can't really give anything specific for now.
However the fact remains the same, the core idea behind the allocator will still be handling smaller amounts of memory with as little overhead as possible, and not high performance. When larger amounts of memory is required or performance is more critical then the system allocator should be used instead.

As it was said before, the splay test was created specifically to test garbage collection, and thus uses a lot of memory and creates a lot of fragmentation. The fact that it is slow has nothing to do with the lcache, and verry little with hashmaps (these can have a slight effect on fragmentation).
The reason this test is slow is that the jerry allocator was not designed to handle this much memory, and maintaining the free block list gets more and more costly as the memory get fragmented. I have a few ideas on how to improve the logic behind the allocator to make it less affected by fragmentation, but can't really give anything specific for now.
However the fact remains the same, the core idea behind the allocator will still be handling smaller amounts of memory with as little overhead as possible, and not high performance. When larger amounts of memory is required or performance is more critical then the system allocator should be used instead.

As it was said before, the splay test was created specifically to test garbage collection, and thus uses a lot of memory and creates a lot of fragmentation. The fact that it is slow has nothing to do with the lcache, and very little with hashmaps (these can have a slight effect on fragmentation).
The reason this test is slow is that the jerry allocator was not designed to handle this much memory, and maintaining the free block list gets more and more costly as the memory get fragmented. I have a few ideas on how to improve the logic behind the allocator to make it less affected by fragmentation, but can't really give anything specific for now.
However the fact remains the same, the core idea behind the allocator will still be handling smaller amounts of memory with as little overhead as possible, and not high performance. When larger amounts of memory is required or performance is more critical then the system allocator should be used instead.

Hi, verified, you are right, but the current situation is on 64bit processor, we can not using system allocator, that's why I have forced to using jerry memory allocator and leading to significant fragmentation

As it was said before, the splay test was created specifically to test garbage collection, and thus uses a lot of memory and creates a lot of fragmentation. The fact that it is slow has nothing to do with the lcache, and very little with hashmaps (these can have a slight effect on fragmentation).
The reason this test is slow is that the jerry allocator was not designed to handle this much memory, and maintaining the free block list gets more and more costly as the memory get fragmented. I have a few ideas on how to improve the logic behind the allocator to make it less affected by fragmentation, but can't really give anything specific for now.
However the fact remains the same, the core idea behind the allocator will still be handling smaller amounts of memory with as little overhead as possible, and not high performance. When larger amounts of memory is required or performance is more critical then the system allocator should be used instead.

Hi, verified, you are right, but the current situation is on 64bit processor, we can not using system allocator, that's why I have forced to using jerry memory allocator and leading to significant fragmentation

Sorry to bring up an old topic but lvgl switched memory allocators recently which gave a pretty big speed boost. Could have a look at what they used. I forgot the name of the library right now.


Semantics for failed refreshes.

I've been unable to find in the documentation what happens if a cache refresh fails (for example a timeout or 4xx).
Does the cached item get evicted, or does the previous entry stay around until a successful refresh happens?

They stay. The idea is that this way intermittent outages on the remot side does not immediately affect key usage.


Penstand SVG added

Thanks to having me for contributing in this project.

Thanks for contributing. Sorry for the delay in merging.


Upgrade test suite to JUnit 5

We are using still JUnit 4 here and some legacy packages.
I am now going to upgrade the test suite in order to prevent an unexpected incompatibility, which breaks everything.

Also, included updated dependencies to close known security holes. Would release this soon :)


Blitter rendering from Atlas / Spritesheet broken as of Phaser 3.52.0

Phaser Version: Phaser 3.52.0
Operating system: Windows 10
Browser: Chrome 88 / Firefox 85
Blitter throws "Uncaught TypeError: src.setRenderDepth is not a function" error since 3.52.0 when rendering from atlas / spritesheet. Error does not occur in v3.51.0
Example can be seen in labs.phaser.io blitter multi-atlas example
http://labs.phaser.io/view.html?src=src/game objects/blitter/multiple atlas frame bobs.js&v=3.52.0
Error traced to line 166408
var BlitterWebGLRenderer = function (renderer, src, camera, parentMatrix)
{
    var list = src.getRenderList();

    if (list.length === 0)
    {
        return src.clearRenderDepth(camera);
    }

    src.setRenderDepth(camera); <--- throws error

Thank you for spending time reporting this issue. However, we've already fixed this in the master branch of Phaser and it will be part of the next official release. You can track what's already been fixed by searching closed issues, or by looking at the Change Log.

Thank you for spending time reporting this issue. However, we've already fixed this in the master branch of Phaser and it will be part of the next official release. You can track what's already been fixed by searching closed issues, or by looking at the Change Log.


Updated cloudbuild.yaml to produce container

Addresses #50

Thanks for the review.  Made the fix.


Anthropic shouldn't be in list of autocomplete options

Addresses this bug
Testing
Bug replicated

After changes, anthropic option removed.

Wait this isn't correct


Add app open ai PROOF-6

I have added app-open-ai docs. I have also created new category in the navbar "applications/other", since app-open-ai is not a trigger.

tagging @bakobako

@bakobako Added in https://github.com/keboola/connection-docs/pull/464/commits/e28c05237b07e3178b2746e23d90b6d5dda06080

@hhanova I have edited the UI and made new screenshots


Unit test warnings

When running unit tests, a lot of warnings are emitted about filters and subcomponents not being found.

The unit tests seem to be using a local Vue instance that does not have Vuetify and the custom filter registered.

The bug seems to be produced in 23a9c5f9d04bfc5dda6d52ff6e2ce9ac4df7112b.


Add ActivityBase class

https://github.com/microsoft/vscode-azureresourcegroups/pull/160 depends on these changes.

@bwateratmsft I could see us wanting to have completed activities persist across VS Code sessions. Do you think worth rewriting parts of the API to accommodate for that?
We'd have to be able to hydrate completed activities from a saved state in local storage. We could come up with a serializable state that a completed activity can save and be rehydrated from. I can see this getting complicated if we want to persist the child nodes between sessions (a big reason why we might want to have activities persist in the first place).

@alexweininger that's a good idea.
I think it would be prohibitively difficult to handle incomplete items; I don't think we could come up with any reasonable way to serialize how to update the status after restarting VSCode.
For complete items, as you mention it would not be too difficult to keep just the activity node, but when you start introducing children it gets more complicated quickly.
I'll try to think about it more today. I don't want to bite off more than we can chew right now but I also don't want to paint us into a corner where we can't do that in the future.


Scroll page by JS { with out giving href }

I wanted to add JS function(s)  to scroll the page / go to a particular location  .
As giving this:-
 .....

 .......

is a bit  time taking , and changes the base link as well .
To remove such thinks I came up with this idea .
Hope to hear from u soon .

Hello man , can you assign me this? I worked in the utility

HI @SushanthReddyManda , I would like to add a snippet for this issue.

This is a language feature - Window.scrollTo() - so it's not worth implementing a snippet that replicates this behavior.


08/14/2018 06:14 : Create Pull Request for branch master -> prTesting1_2018081406

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Js bundling

Motivation and Context
Lets us write modern, modularised code and bundle it for older browsers
What has changed
Code split into modules
Bundler added
Pipeline and watcher added
Old bundler removed
How to test?
Delete js in static.  run npx gulp build and confirm that a main.min.js file is created in static/js
Links
https://trello.com/c/rlSmARte
Screenshots (if appropriate):

@ryangrundy7 @ChristopherMShelton Happy to sign off the changes?


Create Home View Page

DashBoard which will be available for users after login

Logout Button
Welcome message

I would like to work on this issue.

I would like to work on this issue.

(under JWOC)

@hound77 I would love to work on this issue. Please assign it to me! Thank you!!

I want to work on this issue under JWOC.


fix typo in atom.gyp

use product_name instead of project_name when creating framework symlinks; fixes build on MacOS

:+1:

:+1:

Thanks!


An error occurred while building OpenSSL for Android

How do I fix this? Please help me.
FM@DESKTOP-ADDG61L MINGW64 ~/Desktop/td-master/example/android
$ ./build-openssl.sh
Downloading OpenSSL sources...
Configuring OpenSSL version 1.1.1t (0x1010114fL) for android-arm64
Using os-specific seed configuration
Creating configdata.pm
Creating Makefile

**********************************************************************
***                                                                ***
***   OpenSSL has been successfully configured                     ***
***                                                                ***
***   If you encounter a problem while building, please open an    ***
***   issue on GitHub <https://github.com/openssl/openssl/issues>  ***
***   and include the output from the following command:           ***
***                                                                ***
***       perl configdata.pm --dump                                ***
***                                                                ***
***   (If you are new to OpenSSL, you might want to consult the    ***
***   'Troubleshooting' section in the INSTALL file first)         ***
***                                                                ***
**********************************************************************
makefile:577: target `tags' given more than once in the same rule.
makefile:577: target `tags' given more than once in the same rule.
makefile:577: target `tags' given more than once in the same rule.
makefile:577: target `tags' given more than once in the same rule.
llvm-ar.exe: warning: creating apps/libapps.a
llvm-ar.exe: warning: creating libcrypto.a
llvm-ar.exe: warning: creating libssl.a
llvm-ar.exe: warning: creating test/libtestutil.a
process_begin: CreateProcess(NULL, aarch64-linux-android21-clang -I. -Iinclude -Iapps -pie -pthread -Wa,--noexecstack -Qunused-arguments -Wall -O3 -ffunction-sections -fdata-sections -U__ANDROID_API__ -DNDEBUG -D__ANDROID_API__=21 -MMD -MF apps/asn1pars.d.tmp -MT apps/asn1pars.o -c -o apps/asn1pars.o apps/asn1pars.c, ...) failed.
make (e=2): The system cannot find the file specified.
make[1]: *** [apps/asn1pars.o] Error 2
make: *** [all] Error 2

Did you install a supported Android SDK to the directory SDK using ./fetch-sdk.sh script?

Yes, I use the SDK and OpenSSL that are downloaded through the script.

Yes, I use the SDK and OpenSSL that are downloaded through the script.

I just redownloaded everything but it's still an error.

Check that you have the file td/example/android/SDK/ndk/23.2.8568313/toolchains/llvm/prebuilt/windows-x86_64/bin/aarch64-linux-android21-clang.
Alternatively, try building using the provided Dockerfile, which should be easier on Windows.

Yes, I have it, but it still errors when running build-openssl.sh
I will try it using Docker


bash shebang to determine python/pgrep exec

Codecov Report

Merging #10 (bd415a9) into master (fe61884) will decrease coverage by 9.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   96.15%   86.81%   -9.34%
==========================================
  Files           2        2
  Lines         312      311       -1
==========================================
- Hits          300      270      -30
- Misses         12       41      +29

Impacted Files
Coverage Δ

pgtree/pgtree.py
84.01% <100.00%> (-11.09%)
:arrow_down:

tests/test_pgtree.py
97.01% <0.00%> (-2.99%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe61884...bd415a9. Read the comment docs.


Add a meaningful message after withdraw

Below message is displayed after withdraw command is executed:
Withdrawing db0d1408e211fc91
Withdrew [object Object]

There is no easy way to find out is the operation was successful or not. Can we have a meaningful message instead?

Should make https://github.com/loomnetwork/loom-js/blob/master/src/plasma-cash/entity.ts#L491 to also setup a Withdrew event listener so that it logs success.


option to not use cache for some request

const graphql = createClient(/* ... */)
graphql(QUERY, variables, { noCache: true })

mutation should not be cached


iOS: cursor and keypad does not show up once the user navigates back to biometric to passcode page

Describe the bug
cursor and keypad does not show up once the user navigates back to biometric to passcode page
To Reproduce

Install the app and click on Get Started button
Choose "unlock with biometrics".
Authenticate using fingerprint / face ID base device settings.
Otp is prompted to enter -> where cursor or keypad is automatically shown to user
Now navigate back to previous screen i.e app unlock screen.
and again navigate back to Otp screen

Expected behavior
cursor and keypad should show up whenever user enters the Otp screen irrespective of attempts.
Actual behavior
cursor and keypad does not show up once the user navigates back to biometric to passcode page
Screenshots
https://user-images.githubusercontent.com/79500509/228442485-a700f19f-c0c8-4f24-8a90-5f98b68cb0a8.MP4

Add the screenshot of the profile page with commit id

iOS app version :0.4.1 (32)

Smartphone (please complete the following information):
iphone 11 | iPhone OS version: 15, BLE 5.0
Environment details:

Mimoto version: <IP_ADDRESS>
MOSIP Version: qa-1201-b2.mosip.net

Where does the issue occur: Wallet/Verifier?
N/A
Logs of wallet and verifier:
N/A
Additional context
The issue is common across all the devices of iOS

verified as fixed in the build with commit id in the below screenshot.


Create interpolation test

This tests an interpolation done within FUSE that fails for DataInterpolations v6.1.
We should avoid merging #26 until this passes (though I think v6.0 is okay).
I've made DataInterpolations aware as well: https://github.com/SciML/DataInterpolations.jl/issues/322

@orso82 Merging is still blocked for me here.

I merged for now and will take e a look at the privileges tonight

you should be ok now


Getting HTTP error 500

After setting the plugin i get the that error, please help

Research google for analysing http 500 error with php.


sync website cookies in background - captured from version 1.1.1

changes captured from @castana/cordova-plugin-ios-xhr version 1.1.1, ignored spaces & blank lines
(version 1.1.1 seems to switched to DOS line endings, guess someone published it from a PC)
It looks to me like the updates from @castana/cordova-plugin-ios-xhr version 1.1.1 were never pushed to GitHub.
@CASTANA-Solutions I would appreciate it if someone could push the changes for 1.1.1 to GitHub, thanks.

Hi Brody,
thx for pointing out this difference!

Oh, sorry, should have been "Hi Chris" ... :)


Error while using NAN 1.6.1 to compile node-msgpack

Here's node-msgpack.
It says on line 1848 of nan.h, there's an error with node::Encode().
In file included from ../src/msgpack.cc:9:
../node_modules/nan/nan.h:1848:10: error: no matching function for call to 'Encode'
  return node::Encode(
         ^~~~~~~~~~~~
/Users/XadillaX/.node-gyp/1.0.3/src/node.h:251:34: note: candidate function not viable: cannot convert argument of
      incomplete type 'const void *' to 'const char *'
NODE_EXTERN v8::Local<v8::Value> Encode(v8::Isolate* isolate,
                                 ^
/Users/XadillaX/.node-gyp/1.0.3/src/node.h:257:34: note: candidate function not viable: requires 3 arguments, but 4 were
      provided
NODE_EXTERN v8::Local<v8::Value> Encode(v8::Isolate* isolate,
                                 ^
/Users/XadillaX/.node-gyp/1.0.3/src/node.h:262:45: note: candidate function not viable: requires at most 3 arguments, but
      4 were provided
                inline v8::Local<v8::Value> Encode(
                                            ^
/Users/XadillaX/.node-gyp/1.0.3/src/node.h:43:53: note: expanded from macro 'NODE_DEPRECATED'
#define NODE_DEPRECATED(msg, fn) V8_DEPRECATED(msg, fn)
                                                    ^
/Users/XadillaX/.node-gyp/1.0.3/deps/v8/include/v8config.h:332:45: note: expanded from macro 'V8_DEPRECATED'
# define V8_DEPRECATED(message, declarator) declarator
                                            ^
1 error generated.
make: *** [Release/obj.target/msgpackBinding/src/msgpack.o] Error 1

https://github.com/rvagg/nan/pull/265


Adding existing project causes VS 2022 to hang

SqlPackage or DacFx Version:
.NET Framework (Windows-only) or .NET Core: 8.0.200
Environment (local platform and source/target platforms): local

Steps to Reproduce:

dotnet new -i Microsoft.Build.Sql.Templates
dotnet new sqlproj -n ProductsTutorial
create table (optional)
Open VS 2022 Version 17.9.2
Right click in solution
Add existing project
select sqlproj
hang/wait

Did this occur in prior versions?  If not - which version(s) did it work in?
idk, first time I am using the new sdk database project

closing this as we have several items tracking the work for SSDT to support Microsoft.Build.Sql projects.
https://github.com/microsoft/DacFx/issues/180#issuecomment-1332850284

@jphellemons I encountered the problem you described yesterday and the following allowed me to work around it:
After your step 2 and before opening visual studio, perform a dotnet restore on the new .sqlproj from the command line.


Default keyboard shortcuts for Accept Incoming / Current gone

VSCode Version: 1.14.0
OS Version: Linux

After updating to 1.14 merge-conflict.accept.current and merge-conflict.accept.incoming no longer have their keyboard shortcut Alt+M, 1 / Alt+M, 2 assigned to them. I found them really handy and would like to keep my custom keybindings as short as possible (makes it easier when switching machines or sitting in front of another person's VS Code).

The Alt combinations were causing problems, see #28376.

You can add them back through File > Preferences > Keyboard Shortcuts.


Add validation to ensure that departure date does not exceed maximum permitted stay

This is a first pass at a simple iteration of this feature, with a maximum permitted stay of 14 days.

also I think we need to tweak the guidance on the departure date to confirm with the 14 day max stay rule:


Question

Hi,
Im implementing prity much same functionality. I straggling a bit with generating correct certificate for merchant validation. Can you help a little on how to generating pfx having .cer and .certSingingRequest ?

You can use OpenSSL to do this.
I found some instructions here, where your CER file is the public key and your CSR is your private key.
If you have a fairly recent version of Windows 10, it can be easier to use Windows Subsystem for Linux (WSL) to generate it from bash rather than trying to get OpenSSL installed and working with Windows.

Thank you for your quick answer and for your time. I think i miss some thing on the way.
So i got merchant_id.cer file
i got xxx.CertSigningRequest
I also generated the .p12 private key and .pem public key on mac where i was creating the request file.
(as in documented here https://docs.ptf.radial.com/Content/Topics/payments/apple-pay-web.htm)
Now i get all of those file into my widows and trying to run openssl commands to generate pfx
I think i missign this step: Find the private key file (xxx.key) (previously generated along with the CSR).
Itried to run the commend using CSR as key
C:\>c:\OpenSSL-Win64\bin\openssl.exe pkcs12 -inkey C:\cert\umbrella-request.cert
SigningRequest -in C:\cert\merchant_id.cer -export -out C:\cert\umbrella-merchan
t-identify_pfx.pfx
unable to load private key
7512:error:0906D06C:PEM routines:PEM_read_bio:no start line:.\crypto\pem\pem_lib
.c:707:Expecting: ANY PRIVATE KEY

C:\>c:\OpenSSL-Win64\bin\openssl.exe pkcs12 -inkey C:\cert\umbrella-merchant-req
uest-private.p12 -in C:\cert\merchant_id.cer -export -out C:\cert\umbrella-merch
ant-identify_pfx.pfx

unable to load private key
12144:error:0906D06C:PEM routines:PEM_read_bio:no start line:.\crypto\pem\pem_li
b.c:707:Expecting: ANY PRIVATE KEY

Is it ok to use .certSigningRequest directly in the command? Is this should be a regenerated as .key (the extension should not have much to do since its a text ... )? Do i need to do it on the same machine as the request was created (MAC in this case?). Should i add the certificate on the machine im trying to make a conversion?  Im bit confused here.

Despite the file extension, I think a .certSigningRequest file is effectively a .key file for this purpose.
It was over a year ago since I did this myself, but if I recall correctly I think I put the merchant validation certificate and the original CSR into keychain and exported everything from there on the Mac, then used those files to generate the .pfx with OpenSSL on Windows.

Hi,
I finnally mange to do this.
I needed to import cer to Personal certificate on my window machine then export it as out.p7b
Then create a pem file from it
openssl pkcs7 -in out.p7b -inform DER -out result.pem -print_certs
then from .p12 file i get from MAC cert export i extracted a key
openssl pkcs12 -in umbrella-merchant-identify.p12 -nocerts -out privateKey.pem
openssl rsa -in privateKey.pem -out newPrivateKey.pem

And finally generated the the pfx.
openssl pkcs12 -export -inkey newPrivateKey.pem -in result.pem -name umbrella-merchant-identify -out final_result.pfx

Glad to hear you've gotten it working. I might update the README at some point soon to give some pointers for how to do this for other people.

marcingorzan : I am trying to get apple pay on our website but struggling with the sending client certificate to apple in the request.
I was wondering if you have managed to achieve this.
I need some help if possible.
Thanks

hey @honey6611 I'm having this issue at the moment.
I've generated the PEM file using the EXPORT method in Keychain (Mac)
I'm getting the following errror:
error:0906D06C:PEM routines:PEM_read_bio:no start line
Any idea?


Refactor LogInWithShortLivedAuthTokenPage to a functional component

Details
Refactor LogInWithShortLivedAuthTokenPage into a function component.
Fixed Issues
$ https://github.com/Expensify/App/issues/16237
Tests
1. Desktop Web

Valid authentication flow:

Sign out of NewDot
Sign in to any account in OldDot
Click on the blue Concierge icon in the bottom right corner of the page
Make sure a new tab opens to NewDot, and you get automatically signed in

Expired/invalid authToken flow:

Sign out of NewDot
Go to http://localhost:8080/transition?accountID=111111111&email=test%40expensifail.com&shortLivedAuthToken=abc&encryptedAuthToken=abc&shouldForceLogin=true
Make sure you see the "Your session has expired. [Please sign in again]." page

2. mWeb Android

Sign out of NewDot
Sign in to any account in OldDot
Click on "Set up my company for free"
After being redirected to localhost:8080/transition?..., manually update the URL to <IP_ADDRESS>:8080/transition?...
Make sure you get automatically signed in to NewDot, on the "Create a new workspace" page

[x] Verify that no errors appear in the JS console

Offline tests
N/A, must be online to sign in
QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/2229301/2d4d073b-dec7-49cb-a2d9-f42c1ed03018

Mobile Web - Chrome
https://github.com/Expensify/App/assets/2229301/3ac3ea3d-16b4-4b24-80d2-4f6aa728110f

Mobile Web - Safari
N/A, flow not supported for mWeb Safari

Desktop
N/A, transition not supported

iOS
N/A, transition not supported

Android
N/A, transition not supported

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

https://github.com/Expensify/App/assets/46707890/c9a786a5-a78c-4bc5-8b42-12555c874c80

Mobile Web - Safari

N/A

Desktop

N/A

iOS

N/A

Android

N/A

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.24-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@francoisl we found this issue on mWeb (Android Chrome browser) https://github.com/Expensify/App/issues/20275, added the deploy blocker label since I'm unsure if this should qualify as a DB or not since the same flow cannot be reproduced in production.
This issue is partially failing this PR, please check it out and let me know if there's anything else we can help with.

I think it's the behaviour even without this change. I think the time delay is for the api to return information about the workspaces present. Even during c+ review same behaviour was observed.
Correct me if wrong @francoisl

Yep thanks for checking. Commented on the issue and commenting here as well for visibility - this is not a blocker.

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅


add ctrl key support for pyglet integration

I was trying to use Ctrl-A to highlight the text I was writing in a text_input and this seems to fix it.
I'd bet something similar could be used for alt, shift, and super/windows key but I haven't tested those myself so I didn't want to commit it.

Coverage decreased (-0.04%) to 54.165% when pulling db410e002865d456f859a0cfe353b9843969b26c on tankorsmash:patch-1 into c84315ef05881734298366c74b18fbc26192f1de on swistakm:master.

Hey! Thanks for PR! It had few small issues:

didn't capture ctrl release properly
import errors
didn't fix the functionality on macOS where Command (super) key takes role of Ctrl key in "highlight all" shortcut

I have fixed all of them manually and merged to master.

Will try to release this on PyPI by the end of the week.

Thank you!
On Fri., Jul. 17, 2020, 6:48 a.m. Michał Jaworski<EMAIL_ADDRESS>wrote:

Will try to release this on PyPI by the end of the week.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/swistakm/pyimgui/pull/156#issuecomment-660036174, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKANBUEQJZHMALNRLAZTSLR4AUANANCNFSM4OZ5XK5A
.

Feature released in 1.2.0


Locate schema method

There is a lot of logic in locate_schema method in validator class of csvlint. They are not implemented as of now and need to be done at a later stage.
The well-known/csvm are part of csv-w spec and need to be implemented for a complete compliance. Ideally this logic should not go into the validator class as this is different from validation

Issues for this exist. This is super-ceded by #77


MATERIALIZED VIEW: actions on the target table partitions

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

duplicate 86d53b34a55226715edb592070dd6ca52a83a9a3

Oops, sorry :) Didn't notice your PR...


Add influx_inspect deletetsm command to 1.6

URL for relevant page?
https://docs.influxdata.com/influxdb/v1.6/tools/influx_inspect/
The deletetsm command isn't documented in the influxdb 1.6 docs. In the 1.5 docs, it's documented, but needs a anchored link at the top of the page.

Note that when specifying the path for the deletetsm command, wildcard paths are supported.
Single shard:
./influx_inspect deletetsm -sanitize /influxdb/data/location/autogen/1384/*.tsm

All shards int he db:
./influx_inspect deletetsm -sanitize /influxdb/data/location/autogen/*/*.tsm


Showcase type provider Autofac DI configuration workaround

Motivation
Related to #312
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

The showcase was moved to https://github.com/Kentico/kontent-delivery-sdk-net/tree/preparation-issue-312


IsRemoteReachable returns true if there is no internet connection

Bug Information
IsRemoteReachable returns true if you're connected to the WiFi that requires logging in to connect to internet (and you're not logged in).
Version Number of Plugin: 2.3.0
Device Tested On:Samsung Galaxy S7, Android 6.0.1
Simulator Tested On:
Version of VS: XS 6.3
Version of Xamarin: Xamarin.Android 7.3
Steps to reproduce the Behavior

Connect to WiFi that requires logging in to get internet connection.
Don't log in, so you'll have no internet connection.
Try to call CrossConnectivity.Current.IsRemoteReachable("www.google.com");

Expected Behavior
It returns "false" indicating that internet connection is not available.
Actual Behavior
It returns "true" indicating that there is internet connection available (which is not true)
Comments
I've noticed, that you're using await sock.ConnectAsync(sockaddr, msTimeout); to check connection to the remote host. But for such WiFi connections it's really possible to create this connection, though there is no internet connection. Maybe it would be more reliable using Ping for this check?

Do you still have cell reception though, Android is smart enough to know that in this case that you can still use the cell even when not logged in? What happens when you go to the browser?

When trying to load "www.google.com" in browser it redirects me to the Login page. By the way, when using Ping.Send it returns "TtlExpired".

IsRemoteReachable returns true when google.com is reachable, which is true, but you can't ACCESS it, so the behavior for IsRemoteReachable look fine for me.

I believe this is as designed. As this is a use case that is nearly impossible to test for.

I have similar issue, but I have disconnected ethernet cable from router. Wifi connected, but no internet access.
And if I call IsRemoteReachable() few times (different threads, different methods), one of it returns true.

i'm facing this issue using Xamarin.Forms, currently tested in the Android project.
Steps to reproduce the Behavior

Download and compile the Connectivity Plugin source code
Create a sample app and delete the Xam.Plugin.Connectivity from the Packages list for both Android and iOS projects
Add the references previously generated to both the Android and iOS projects of this sample app
In the MainActivity class for the Android project add the following code:

protected override async void OnResume()
{
        base.OnResume();
        await CrossConnectivity.Current.IsRemoteReachable("google.com");
}

Turn off the WiFi adapter of the physhical android smartphone and keep mobile data enabled
Go to Settings of your mobile carrier app and disable data usage. Confirm that you can't access to any website (it takes forever to load but never actually finish)
Add a breakpoint exactly on this code section in the ConnectivityPlugin/src/Connectivity.Plugin.Android/ConnectivityImplementation.cs class:

using (var sock = new Socket())
{

    await sock.ConnectAsync(sockaddr, msTimeout);
    return true;
}

You'll see that the returning value of ConnectAsync() is false, but I'm not sure why is this block set to return true anyway.

There is really no reason to use these at all. Just call to your API and that will fail if there is an issue. I did re-write all of it in 4.X

I've read the blog post about the changes in version 4, but 😅 I am ashamed to admit that I couldn't find more information on how to get this IsRemoteReachable() function to work, because it is still returning true on version 4 using the scenario mentioned before.


add solid body rotation test

Add regression and validation tests for the solid body rotation case.

bors try

When the correctness of the validation test has been confirmed by @jiahe23 we can merge this PR.

bors try

bors r+

bors r+

bors r+

bors r+


Remove obsolete replicators table from local datastore

com.cloudant.sync.datastore.DatastoreConstants#getSchemaVersion3 creates a replicators table.
Replication information is stored in a local document there is no need to have a replicators table any more. We may need a migration path.

This library is now end-of-life and this issue won't be fixed.
This issue has been tagged EOL in case any forks want to import it.


Framerate parameter does not work

When I run a command like ./jetson-utils/build/aarch64/bin/video-viewer /dev/video0 rtp://<IP_ADDRESS>:5000 --headless --framerate=15, it does not change the framerate from 30 to 15 properly.
An equivalent gstreamer command that would properly achieve what one would expect would be something like
gst-launch-1.0 v4l2src device=/dev/video0 do-timestamp=true ! image/jpeg, width=1280, height=720 ! jpegdec ! video/x-raw ! nvvidconv ! "video/x-raw(memory:NVMM), width=1280, height=720, framerate=15/1" ! nvv4l2h264enc bitrate=4000000 ! video/x-h264 !  rtph264pay config-interval=1 ! udpsink host=<IP_ADDRESS> port=5001 auto-multicast=true

I see this problem, too
emm, when i run code like
videoOptions outputOpt;
outputOpt.Parse("rtsp://@:8556/test",0,nullptr,videoOptions::IoType::OUTPUT);
outputOpt.frameRate = 25;
outputVideo = videoOutput::Create(outputOpt);

this is invalid, frame rate is actually 30


chore: bdd-spring-1585744520 to 0.0.1

chore: Promote bdd-spring-1585744520 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix dodgy signals

Resolves #58

Here we increase the specificity of the signal detection algorithm. This is achieved by increasing the delta_i threshold to 1000, and also adding a requirement that the maximum value of H12 within a peak is above 0.1. This second requirement is reasonable because we are also calibrating the H12 window size such that 95% of windows are below 0.1.
Also the signal detection algorithm is simplified to only consider a single size of genome region (the gflanks parameter) when fitting peak models, which is configured at 6 cM on each flank (12 cM total). This makes setting a delta_i threshold better too, because a single flank size then gives consistent and comparable delta_i values.
The parameters to control minimum delta_i, minimum H12 value, and the flank sizes, are exposed as config params to make it easier to change them later if further tuning is required.
Also a couple of other unrelated minor changes, see line comments below.

A point of discussion regarding the delta_i threshold, we might want to consider raising it further, e.g., to 1200 or 1500, for even greater specificity. However, we will definitely lose some true positives if we do, e.g., I know that Vgsc drops out in the Mali gambiae 2014 cohort if we do (delta_i is 1087).


Padding setting was added to tweak UIs with small padding on the righ…

a small improovement for right side padding, because of small padding by some UI-Themes. (its not for nuclide, because i don't use it and can't test)

and please test it, im not sure, that it works properly

To make this work you should add @pad also here:
if currWidth > @treeView.width()
        @treeView.animate {width: @getWidth(currWidth + @pad)}, 200

in resizeTreeView and resizeNuclideFileTree  and in resizeNuclideFileTree:
newWidth = fileTree.find('.nuclide-file-tree').outerWidth() + @pad

@antonkluev there is something wrong with the package.json

Requested pull request with fix here: https://github.com/lexcast/tree-view-autoresize/pull/6


What is Table Identifier?

Question
In test_base.py the Table Identifier, TEST_TABLE_IDENTIFIER, is a tuple of 4 elements
TEST_TABLE_IDENTIFIER = ("com", "organization", "department", "my_table")

In most other places, the Table identifier is either a tuple of 2 elements (database_name, table_name) or a string with 2 parts, database_name.table_name.
See more examples
In #289, I wanted to implement the location for in-memory catalog the same way as other catalog implementations, by using the _resolve_table_location function.
location = self._resolve_table_location(location, database_name, table_name)

However, due to the Table Identifier being a 4-element tuple, I cannot parse the database name using identifier_to_database_and_table
database_name, table_name = self.identifier_to_database_and_table(identifier)

What is the proper spec of Table Identifier? And what part of it represents the database_name?
In Java implementation, TableIdentifier is made up of two parts, the namespace and the name, where
Namespace is a list of string.

Hey @kevinjqliu As you already concluded, most catalogs only use two parts, one namespace and the table name. The REST catalog supports hierarchical namespaces, and of course we can add it to the InMemory one as well.

What is the proper spec of Table Identifier? And what part of it represents the database_name?

So if I understand correctly, TableIdentifier consists of the namespace and the table name. Namespace can be multiple parts, for example ("com"."apache"."iceberg") or "com.apache.iceberg". And table name is 1 word, i.e. "foo".
If this is the case, is "database name" part of the namespace and possibly the last element of the namespace?
There are a few references to "database name" in the codebase and I want to understand the relation.
Particularly, the _resolve_table_location function exposed by [catalog/__init__.py](https://github.com/apache/iceberg-python/blob/a4856bc2eadf90ac85dec96d4502ca3517bb1bb5/pyiceberg/catalog/__init__.py#L535)

The REST catalog supports hierarchical namespaces
What is the definition of "hierarchical namespaces" here?

Answering my own questions above.
A TableIdentifier is in the form of (namespace, ..., database_name, table_name). table_name is the last element of the tuple. database_name is the second to last element of the tuple. everything else is part of the namespace name.
TableIdentifier can be represented as either tuple or a single string separated by .
A namespace can be "hierarchical" because it has multiple levels, such as (foo) or (foo, bar) or (foo, bar, baz).


Event Request: table 904 "Assemble-to-Order Link" OnBeforeShowAsmToOrderLines

Please could we have the following event added:
table 904 "Assemble-to-Order Link"
procedure ShowAsmToOrderLines(SalesLine: Record "Sales Line")
var
AsmLine: Record "Assembly Line";
IsHandled: Boolean;
begin
IsHandled := false;
OnBeforeShowAsmToOrderLines(SalesLine)
if IsHandled then
exit;
    SalesLine.TestField("Qty. to Asm. to Order (Base)");
    if AsmExistsForSalesLine(SalesLine) then begin
        AsmLine.FilterGroup := 2;
        AsmLine.SetRange("Document Type", "Assembly Document Type");
        AsmLine.SetRange("Document No.", "Assembly Document No.");
        AsmLine.FilterGroup := 0;
        PAGE.RunModal(PAGE::"Assemble-to-Order Lines", AsmLine);
    end;
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeShowAsmToOrderLines(SalesLine: Record "Sales Line"; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52435.


Mention that it is Windows-only in readme

Since this addon relies on D3D and the Mac client uses OpenGL (and we only ship a Windows dll), this addon does not work with the Mac client. Noting this in the readme will prevent frustrated users and reports like #86.

Feels a little superfluous, but sure.


Plot is separated from toolbar?

I have a weird visualization problem where the plot is displayed on the right side of the toolbar instead beneath it. Anyone knows why or how to fix it?

I have the same problem with you, and have you fixed it now?

I experience the same issue after updating jupyter notebook

I debugged this a bit. Attached is a screenshot of how the bk-canvas-wrapper children are laid out in Chrome. The other children of bk-canvas-wrapper have position: absolute with left: 0, but the canvas has position:absolute (from the CSS), without a left: setting. I'm not a CSS expert, and it's not clear to me if this makes sense as a configuration.
Several CSS changes I tried targeting the bk-canvas canvas fix the issue:

adding left: 0;
adding position: relative; (or inherit)

I'm not sure where this should be fixed, or what combinations of configurations produce the problem. (I installed iTorch / Torch yesterday, with Jupyter 4.3.0 on OSX [via anaconda], fwiw.)
As a workaround, if you find your jupyter installation's custom.css (for me it's lib/python2.7/site-packages/notebook/static/custom/custom.css within an anaconda tree), you can update it to add a rule like this:
 .bk-canvas-wrapper canvas.bk-canvas {
   left: 0;
 }

Graphing using bokeh via the python (2.7) kernel works on my jupyter installation, without the custom CSS rule. The canvas gets left: 0; from a rule in bokeh-0.12.5.min.css.


Fix showing times on FlutterScreen cards

This PR fixes the TalkerDataCard titles to show a time instead of {Closure: TimeFormat timeFormat} on FlutterScreen widgets.

Hello @fieldOfView 👋
Thanks a lot for this fix ❤


fix bug that lead to data from one page being displayed in the edit-v…

…iew of another

This needs to be reverted ASAP as it completely wrecks the image upload!


Angular 1.5.x

How to implement this on angular 1.5.x version. I tried it using the steps but it does not work. Is there specific steps to work it on the higher version of Angular?

I'm using it with angular 1.5 with no issues. Can you clarify what do you mean when you say it does not work?

Oh Sorry for bothering, I manage to solved the problem. It just happen that I called 2 https://www.google.com/recaptcha/api.js on the body and I commented the other script and it works like a charm. I appreaciated your work :)


[Scenario] One Man's Trash and [Scenario] Bonds of the Wild

What kind of mission do you want to add (mark with an X, e.g. [X] Descent)?

[ ] Mansions of Madness
[X] Descent

I have adapted two new Descent 2E quests.  Can these be added to the mission list?
Please enter the GitHub Url to your scenario here
BW1 - One Man's Trash
https://github.com/afellowspelunker/OneMansTrash
BW2 - Bonds of the Wild
https://github.com/afellowspelunker/BondsoftheWild

Both are now added to the manifest. Thanks a lot for your hard work, @afellowspelunker
They should be available within an hour.

Looking good, on the mission list now.  Thanks @vidimus for your support and admin on these projects.


fixes https://github.com/qooxdoo/qooxdoo-compiler/issues/56, caused by missing babel polyfill

Why does the test fail with rake failed? Doesn't seem anything to do with our code...

I think because travis is not configured. And then it uses the default configuration. Can we ignore this?

Yes we can. Merge is allowed.

But shouldn't we fix this first? It's probably not difficult since the tests used to pass, didn't they @johnspackman ?

I've already prepared a PR that includes travis and npm support for this repo. Looks like @oetiker didn't tick the checkbox for "only run if .travis.yml is present".

Currently the PR fails in travis, because 'npmt test' fails. See https://travis-ci.org/cajus/qooxdoo-compiler

Just fixed the travis settings.

Thanks  @johnspackman!


Integrated terminal keybindings don't work after adding new terminal

VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:53:14.822Z)
OS Version: Windows_NT ia32 10.0.14931
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.0.18

theme-monokai-dark-soda
AdamCaviness
0.0.5

Bookmarks
alefragnani
0.10.0

project-manager
alefragnani
0.12.0

vscode-node-readme
bengreenier
1.0.7

npm-intellisense
christian-kohler
0.1.4

path-intellisense
christian-kohler
1.1.0

regex
chrmarti
0.0.6

vscode-eslint
dbaeumer
1.0.8

vscode-npm-source
dkundel
0.0.3

githistory
donjayamanne
0.1.0

EditorConfig
EditorConfig
0.3.4

vscode-npm
fknop
3.3.0

bracketselection
guosong
0.0.1

output-colorizer
IBM
0.0.8

vscode-todo-parser
minhthai
1.8.3

vscode-exec-node
miramac
0.1.8

js-atom-grammar
ms-vscode
0.1.10

debugger-for-chrome
msjsdiag
2.2.0

fontsize-shortcuts
peterjuras
1.0.0

seti-icons
qinjia
0.1.3

view-in-browser
qinjia
0.0.3

vscode-paste-and-indent
Rubymaniac
0.0.6

code-settings-sync
Shan
2.3.6

searchdocsets-vscode
silverlakesoftware
0.5.2

change-case
wmaurer
1.0.0

JavaScriptSnippets
xabikos
1.2.0

ReactSnippets
xabikos
1.2.0

Steps to Reproduce:

Add new integrated terminal
Try any terminal related keybindings before re-toggling terminal.

Can you go into a little more detail on:

What do you mean by "Add new integrated terminal", are you referring to an extension here or a keybinding, if a keybinding which one?
Do you have any errors in the dev tools console (Help > Toggle Developer Tools)?

Sorry.

Add new integrated terminal by hitting Ctrl+Shift+`
Try focusNext/Previous or Kill terminal keybindings
This will fail. Keybindings will recover only if you toggle the terminal.
P.S I'm not referring to any extension and Developer Tools show no error.
Thanks.

I can repro this as well on OSX. Shortcut for next/prev terminal works if you're on the first terminal, but after that prev/next shortcuts stop working.

@vladamx @gigafied do you have terminal.integrated.commandsToSkipShell set in your settings file?

Nope, these are my shortcuts
[
    { "key": "cmd+y",           "command": "redo"},
    { "key": "cmd+shift+r",     "command": "npm-script.start"},
    { "key": "cmd+shift+t",     "command": "npm-script.test"},
    {
        "key": "cmd+k",
        "when": "terminalFocus",
        "command": "workbench.action.terminal.clear"
    },
    {
        "key": "cmd+n",
        "when": "terminalFocus",
        "command": "workbench.action.terminal.new"
    },
    {
        "key": "cmd+w",
        "when": "terminalFocus",
        "command": "workbench.action.terminal.kill"
    },
    {
        "key": "cmd+right",
        "when": "terminalFocus",
        "command": "workbench.action.terminal.focusNext"
    },
    {
        "key": "cmd+left",
        "when": "terminalFocus",
        "command": "workbench.action.terminal.focusPrevious"
    }
]

@gigafied terminal.integrated.commandsToSkipShell would be in your settings.json file

Sorry, wasn't clear.... it's not in settings.json, I was just providing my shortcuts as well to hopefully provide a bit more info as to how to repro.


¡Good job!

Cool! Great job. Thank you very much for uploading this information. That you use openzepellin already seems to me the incredible :-)
Thanks!

Thanks Carmelo! If you have any question about the project you can ask me
anytime. 😊
El mar., 28 ago. 2018 a las 10:37, Carmelo Zubeldia (<
<EMAIL_ADDRESS>escribió:

Closed #1 https://github.com/kartojal/mecenas/issues/1.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kartojal/mecenas/issues/1#event-1812466035, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKqXR7ZNWIC0iCHdEO205Mc0GcNxfQYNks5uVQE4gaJpZM4WPKJr
.


fix lifetime issue

and rework test assets folder

@dipinknair after this lands, we should make a new release on pypi


Print and Copy and CSV of Built Table are not correct

I ran current-law policy (that is, no changes on the TaxBrain GUI input page) through TaxBrain and on the Static Results page I built a table with these specifications:

The built table on the Static Results page looks like this:

So far, so good.
But when I print this table, the printed output is fine except for the fact that a second blank page was printed.  This bug was originally reported on April 13th in issue #534.
When I copy this table, here is what I get when I paste the copied table here:
                                TOTAL LIABILITIES BY CALENDAR YEAR (CHANGE)
	Returns	AGI	Taxable Income	Individual Income Tax Liabilities	Payroll Tax Liablities
	Thousands	Billions	Billions	Billions	Billions
Less than 10	23,157	89.6	3.3	-8.2	12.3
10-20	24,467	237.4	35.7	-33.6	33.5
20-30	18,943	321.4	96.9	-16.6	42.4
30-40	16,372	423.7	183.5	2.7	52.9
40-50	13,283	484.3	261.8	22.2	58.0
50-75	22,758	1,216.4	752.8	88.8	136.1
75-100	13,548	1,070.8	743.8	102.0	120.7
100-200	23,024	2,964.9	2,228.5	367.0	359.9
200-500	7,922	2,148.3	1,755.4	409.2	200.7
500-1000	1,179	772.0	691.3	202.5	38.1
1000+	636	1,867.9	1,748.9	564.7	32.9
All	170,055	11,445.6	8,502.5	1,700.2	1,089.9
Source: http://www.ospc.org/taxbrain/15852/

Notice that the row and column labels are the same as the printed table and the numbers in the table cells are the same as the printed table, but the title is different and incorrect.  It was reported on April 13th in issue #534 that the copied table had no title and a title has been added subsequently.  But the title is incorrect.  Why not use the same title as is showing on Static Results page (which is the same as what it printed out)?
The title should be this:
BASE PLAN TAX VARS, WEIGHTED TOTAL BY EXPANDED INCOME BIN (2017)

rather than this
TOTAL LIABILITIES BY CALENDAR YEAR (CHANGE)

Also, note that when clicking on the CSV button and bringing the downloaded .csv file into a spreadsheet, the new title is the same (incorrect title) as in the Copy.  Now the downloaded file has a meaningful filename 15852_2017_diagnostic_currentlaw_bins.csv, which is a big improvement from last April.
Can we fix the new title used in the Copy and CSV actions?
And can we also fix the print to eliminate the blank page at the end?
@MattHJensen @brittainhard @GoFroggyRun
P.S.  I would presume that clicking on the Excel button will download a file that has the same incorrect title, but I can't test that because I don't have Excel on my computer

Issue #629 is resolved in TaxBrain 1.0.3.  @GoFroggyRun, thanks for your work on pull request #675.


Static analysis?

Coverity Scan is a free service by Coverity offering static analysis for open-source projects. Apparently we can integrate it with Travis as well.
I'm not sure if it's worth yet with large parts of the project still in flux and not working, but it might catch a few bugs we have that otherwise would wait around to be found later.

+1
If you want to push this in to our Travis CI build, go for it.

Completely missed this thread. I just opened a #346 to turn on the FXCop code analysis for the Visual Studio side of things. See the Google Group thread. When you enable all of the rules in VS you get way more than 18 violations. A lot of them are related to globalization issues, but there are quite a few legitimate ones: methods that should be static, classes with incorrect exposure, that sort of thing.


Compile to JS for release

When TS 5.7 RC candidate lands, we should switch to it and reconfigure our project to transpile the TS source to JS in /build.
https://github.com/microsoft/TypeScript/issues/59905

since Piconbello will need a subpath import with some of our primitives, for developing zkpassport circuits, I'm going to do this soon with the TS beta


is possible to integrate openid with hapijs? and also make it work with steampowered.com?

I'm looking for a solution of how to integrate steampowered.com with Hapi JS and I couldn't find anything out there..
Thanks,
Lucas

It seems hapijs does not support OpenID. You'll have to try and convince them or contribute support, there's an open issue on their side which I see you've already found. :)


BeagleBone Blue encoder 4

I'm working with your library on a BeagleBone Blue for a system that has 4 encoders. However, the 4th encoder reading doesn't seem to be working properly; it simply toggles between 0 and 1 as the encoder turns. I have checked that the encoder is working by using the other ports. They all work. I have also tried a second BeagleBone Blue and got the same result.

Which version of system software are you using? This is probably a temporary regression on our part and soon to be fixed in an upcoming release.

the PRU remoteproc interface changed a bit in recent kernels. V0.4.0 supports the new interface, please give this new deb package a go.
https://github.com/StrawsonDesign/Robotics_Cape_Installer/releases/tag/v0.4.0
Just a heads up, the PRU encoder test program is now separate and called rc_test_encoder_pru to keep that subsystem separate and prevent future issues/changes from effecting the normal eqep subsystem and test program.

@RobertCNelson - I didn't see you message before installing the 0.4.0. The output after that install is:
git:/opt/scripts/:[d36fe9a7be9ebfc872b10a470e904ab4c61c4516]
eeprom:[A335BNLTBLA21712EL002069]
dogtag:[BeagleBoard.org Debian Image 2017-10-10]
bootloader:[microSD-(push-button)]:[/dev/mmcblk0]:[U-Boot 2017.09-00002-g0f3f1c7907]
bootloader:[eMMC-(default)]:[/dev/mmcblk1]:[U-Boot 2017.03-rc2-00002-g11d4fd]
kernel:[4.4.91-ti-r133]
nodejs:[v6.14.0]
uboot_overlay_options:[enable_uboot_overlays=1]
uboot_overlay_options:[uboot_overlay_pru=/lib/firmware/AM335X-PRU-RPROC-4-4-TI-00A0.dtbo]
uboot_overlay_options:[enable_uboot_cape_universal=1]
pkg:[bb-cape-overlays]:[4.4.20180408.0-0rcnee0~stretch+20180409]
pkg:[bb-wl18xx-firmware]:[1.20180328-0rcnee2~stretch+20180328]
pkg:[firmware-ti-connectivity]:[20170823-1rcnee1~stretch+20180328]

@StrawsonDesign - Perhaps I missed a step in the .deb package install, but the rc_ commands were not recognized after installation via that method.
So, I installed from source. The rc_ commands are recognized. Running rc_test_encoder_pru gives (with the same output if run with sudo):
$ rc_test_encoders_pru

ERROR in rc_pru_stop opening remoteproc driver: No such file or directory
PRU probably not enabled in device tree
ERROR in rc_encoder_pru_init, failed to start PRU0
ERROR: failed to run rc_encoder_pru_init

Other rc_test_ commands seem to all be working fine, including rc_test_encoders_eqep.

@DocVaughan 0.4.0 needs v4.14.x-ti pru..
bootloader:[microSD-(push-button)]:[/dev/mmcblk0]:[U-Boot 2017.09-00002-g0f3f1c7907]
bootloader:[eMMC-(default)]:[/dev/mmcblk1]:[U-Boot 2017.03-rc2-00002-g11d4fd]

First, nuke the eMMC bootloader via;
sudo dd if=/dev/zero of=/dev/mmcblk1 bs=1M count=10

2nd: update the bb-cape-overlays, this contains the overlays:
sudo apt update ; sudo apt install --only-upgrade bb-cape-overlays

3rd: tweak /boot/uEnv.txt
from:
uboot_overlay_pru=/lib/firmware/AM335X-PRU-RPROC-4-4-TI-00A0.dtbo

to:
uboot_overlay_pru=/lib/firmware/AM335X-PRU-RPROC-4-14-TI-00A0.dtbo

4th: update /opt/scripts/
cd /opt/scripts/
git pull

5th: update kernel
sudo /opt/scripts/tools/update_kernel.sh --ti-channel --lts-4_14

6th: update bootloader
sudo /opt/scripts/tools/developers/update_bootloader.sh

Regards,

4.9 also works, I've been developing recently on the latest 'official' stable image from beagleboard.org which is using 4.9.82-ti-r102
Embarrassingly I went to confirm this works myself and found a quick typo causing the encoder pru binary to load but always return a position of 0. fixed now in master. Pushing a new deb package momentarily.
Closing issue for now since it seems to be working with the right kernel. We can keep discussing this here if you still need help getting it going.

it is still broken encoder 4 using kernel 4.19 newest kernel ti and librobotcontrol


dirichlet.rvs has incorrect shape

In [1]: import scipy.stats as ss

In [3]: ss.dirichlet.rvs([1,2,3], size=10).shape
Out[3]: (10, 3)

In [4]: ss.dirichlet.rvs([1,2,3], size=1).shape
Out[4]: (1, 3)

In [5]: ss.dirichlet.rvs([1,2,3]).shape
Out[5]: (1, 3)

In [7]: ss.norm.rvs(size=10).shape
Out[7]: (10,)

In [8]: ss.norm.rvs(size=3).shape
Out[8]: (3,)

In [10]: ss.norm.rvs()
Out[10]: -0.08102031305456647

Line 5 should have shape (3,).

Related: #13171 (i.e. a mis-handling of size=1 as size=None).
Perhaps it's time to rationalize all of these.

Let's lump this into gh-7689.


Feature: Feed details page

What problem are you trying to solve?
The first version of the Orcfax Explorer only had a single ADA-USD feed and also did not show many (if any) details about said feed. Now that there is more feed-specific metadata available and we support many more feeds now, we need a feed details page that gives a more comprehensive overview of the feed as well as the ability to "drill down" into a single feed and make sense of that feed's fact statements over time.
Describe the solution you’d like
Feed Summary
A high-level summary of the most important details for a given feed

Token pairs (if price feed)
Feed name
Feed ID (not sure if we will have this or not)
Latest on-chain update

Value
Time published (2 minutes ago)
Up, down, or - (based on previous value?)

Status
Type
Sources for the feed (little icons for sources? number?)
Posting schedule (heartbeat, deviation, countdown to next scheduled publication?)
Previous 5 values that link to FS?
Addresses and hashes

Feed Switcher

The feed name with price pair tokens should be a clickable "feed switcher"
Dropdown that is searchable (like the feeds filter)
Use keyboard arrows and enter or scroll and click with mouse
Clicking on a feed takes you to that feed page

Most Recent Facts / Feed History Table

An ordered table or card view of the most recent facts for the current feed

Graph / Chart Visualization

See #

Describe any alternatives you’ve considered
No response

This has been completed and the corresponding code can be seen / followed here


Track usage of SDK

Motivation
Send identification header for tracking usage of SDK
Blocked by https://github.com/kontent-ai/management-sdk-net/issues/197
Additional Context
for inspiration see https://github.com/kontent-ai/boilerplate-net/pull/107

https://github.com/kontent-ai/management-sdk-net/issues/197 is resolved, so not blocked anymore.


Make the tests run by transforming warnings into errors

Introduce pytest.ini and introduce configuration to filter and transform warnings into errors.
Few exceptions are documented in the same file. We filter out the specific warning using regex and its type instead of ignoring a generic type of warning which might lead to us missing out on something newly introduced in the flax codebase. Notably causing due to:

Importing tensorflow.compat.v2.io import gfile in training/checkpoints.py
XLA level Warning.
RuntimeWarning due to scipy compiled against an older numpy than installed.

@avital PTAL.

Thanks, this is a clear improvement! Should we file separate GitHub tickets to investigate why the other deprecation warnings happen and see if we can eliminate them altogether?

Thanks, this is a clear improvement! Should we file separate GitHub tickets to investigate why the other deprecation warnings happen and see if we can eliminate them altogether?

Yes, I will go ahead and create them.

Thanks @mohitreddy1996!


feat(golang)!: change paths

remove GOSUMDB=off and CGO_ENABLED=0
set GOPATH=/opt/containerbase/home/go
set GOCACHE=/opt/containerbase/cache/go
closes #2662
closes #2663
#2713

What's the home path map to? I'm asking due to "read only file system" and our desire to keep all writes to /tmp or /opt/containerbase

/opt/containerbase/home

see PR description. it's pointing to /opt/containerbase/home and /opt/containerbase/cache


Socket.io adapter emitted error event: { ParserError: Protocol error, got "a" as reply type byte. Please report this.

verbo: Socket.io adapter emitted error event: { ParserError: Protocol error, got "a" as reply type byte. Please report this.
at parseType (/app/node_modules/redis-parser/lib/parser.js:305:34)
at JavascriptRedisParser.execute (/app/node_modules/redis-parser/lib/parser.js:563:20)
at Socket. (/app/node_modules/machinepack-redis/node_modules/redis/index.js:267:27)
at Socket.emit (events.js:180:13)
at addChunk (_stream_readable.js:274:12)
at readableAddChunk (_stream_readable.js:261:11)
at Socket.Readable.push (_stream_readable.js:218:10)
at TCP.onread (net.js:581:20)
offset: 138,
buffer: '{"type":"Buffer","data":[43,79,75,13,10,36,50,49,49,57,13,10,35,32,83,101,114,118,101,114,13,10,114,101,100,105,115,95,118,101,114,115,105,111,110,58,50,46,56,46,50,52,13,10,114,101,100,105,115,95,103,105,116,95,115,104,97,49,58,100,99,101,55,102,55,53,54,13,10,114,101,100,105,115,95,103,105,116,95,100,105,114,116,121,58,48,13,10,114,101,100,105,115,95,98,117,105,108,100,95,105,100,58,52,97,51,53,48,48,55,52,101,98,52,52,100,53,52,100,13,10,114,101,100,105,115,95,109,111,100,101,58,115,116,97,110,100,97,108,111,110,101,13,10,111,115,58,76,105,110,117,120,32,52,46,49,53,46,49,53,45,51,50,46,101,108,54,112,105,101,32,120,56,54,95,54,52,13,10,97,114,99,104,95,98,105,116,115,58,54,52,13,10,109,117,108,116,105,112,108,101,120,105,110,103,95,97,112,105,58,101,112,111,108,108,13,10,103,99,99,95,118,101,114,115,105,111,110,58,52,46,56,46,52,13,10,112,114,111,99,101,115,115,95,105,100,58,50,48,13,10,114,117,110,95,105,100,58,50,50,102,53,52,48,53,55,101,55,51,56,102,51,49,48,49,100,53,56,52,57,100,97,57,50,48,51,55,97,55,57,101,55,98,56,52,56,98,48,13,10,116,99,112,95,112,111,114,116,58,51,49,57,57,50,13,10,117,112,116,105,109,101,95,105,110,95,115,101,99,111,110,100,115,58,50,52,52,48,51,56,55,13,10,117,112,116,105,109,101,95,105,110,95,100,97,121,115,58,50,56,13,10,104,122,58,49,48,13,10,108,114,117,95,99,108,111,99,107,58,49,54,53,54,57,49,54,49,13,10,99,111,110,102,105,103,95,102,105,108,101,58,47,97,112,112,47,114,101,100,105,115,46,99,111,110,102,13,10,13,10,35,32,67,108,105,101,110,116,115,13,10,99,111,110,110,101,99,116,101,100,95,99,108,105,101,110,116,115,58,49,49,13,10,99,108,105,101,110,116,95,108,111,110,103,101,115,116,95,111,117,116,112,117,116,95,108,105,115,116,58,48,13,10,99,108,105,101,110,116,95,98,105,103,103,101,115,116,95,105,110,112,117,116,95,98,117,102,58,48,13,10,98,108,111,99,107,101,100,95,99,108,105,101,110,116,115,58,48,13,10,13,10,35,32,77,101,109,111,114,121,13,10,117,115,101,100,95,109,101,109,111,114,121,58,49,51,48,57,49,53,50,56,13,10,117,115,101,100,95,109,101,109,111,114,121,95,104,117,109,97,110,58,49,50,46,52,57,77,13,10,117,115,101,100,95,109,101,109,111,114,121,95,114,115,115,58,51,49,57,53,50,56,57,54,13,10,117,115,101,100,95,109,101,109,111,114,121,95,112,101,97,107,58,52,54,57,57,57,51,49,50,13,10,117,115,101,100,95,109,101,109,111,114,121,95,112,101,97,107,95,104,117,109,97,110,58,52,52,46,56,50,77,13,10,117,115,101,100,95,109,101,109,111,114,121,95,108,117,97,58,51,54,56,54,52,13,10,109,101,109,95,102,114,97,103,109,101,110,116,97,116,105,111,110,95,114,97,116,105,111,58,50,46,52,52,13,10,109,101,109,95,97,108,108,111,99,97,116,111,114,58,106,101,109,97,108,108,111,99,45,51,46,54,46,48,13,10,13,10,35,32,80,101,114,115,105,115,116,101,110,99,101,13,10,108,111,97,100,105,110,103,58,48,13,10,114,100,98,95,99,104,97,110,103,101,115,95,115,105,110,99,101,95,108,97,115,116,95,115,97,118,101,58,54,51,13,10,114,100,98,95,98,103,115,97,118,101,95,105,110,95,112,114,111,103,114,101,115,115,58,48,13,10,114,100,98,95,108,97,115,116,95,115,97,118,101,95,116,105,109,101,58,49,53,50,54,53,49,56,52,57,51,13,10,114,100,98,95,108,97,115,116,95,98,103,115,97,118,101,95,115,116,97,116,117,115,58,111,107,13,10,114,100,98,95,108,97,115,116,95,98,103,115,97,118,101,95,116,105,109,101,95,115,101,99,58,48,13,10,114,100,98,95,99,117,114,114,101,110,116,95,98,103,115,97,118,101,95,116,105,109,101,95,115,101,99,58,45,49,13,10,97,111,102,95,101,110,97,98,108,101,100,58,48,13,10,97,111,102,95,114,101,119,114,105,116,101,95,105,110,95,112,114,111,103,114,101,115,115,58,48,13,10,97,111,102,95,114,101,119,114,105,116,101,95,115,99,104,101,100,117,108,101,100,58,48,13,10,97,111,102,95,108,97,115,116,95,114,101,119,114,105,116,101,95,116,105,109,101,95,115,101,99,58,45,49,13,10,97,111,102,95,99,117,114,114,101,110,116,95,114,101,119,114,105,116,101,95,116,105,109,101,95,115,101,99,58,45,49,13,10,97,111,102,95,108,97,115,116,95,98,103,114,101,119,114,105,116,101,95,115,116,97,116,117,115,58,111,107,13,10,97,111,102,95,108,97,115,116,95,119,114,105,116,101,95,115,116,97,116,117,115,58,111,107,13,10,13,10,35,32,83,116,97,116,115,13,10,116,111,116,97,108,95,99,111,110,110,101,99,116,105,111,110,115,95,114,101,99,101,105,118,101,100,58,50,52,52,51,55,51,13,10,116,111,116,97,108,95,99,111,109,109,97,110,100,115,95,112,114,111,99,101,115,115,101,100,58,50,51,52,57,55,48,54,55,13,10,105,110,115,116,97,110,116,97,110,101,111,117,115,95,111,112,115,95,112,101,114,95,115,101,99,58,49,13,10,116,111,116,97,108,95,110,101,116,95,105,110,112,117,116,95,98,121,116,101,115,58,52,51,56,48,56,54,49,52,56,54,13,10,116,111,116,97,108,95,110,101,116,95,111,117,116,112,117,116,95,98,121,116,101,115,58,49,50,57,53,54,52,51,51,57,57,53,13,10,105,110,115,116,97,110,116,97,110,101,111,117,115,95,105,110,112,117,116,95,107,98,112,115,58,48,46,48,53,13,10,105,110,115,116,97,110,116,97,110,101,111,117,115,95,111,117,116,112,117,116,95,107,98,112,115,58,48,46,48,50,13,10,114,101,106,101,99,116,101,100,95,99,111,110,110,101,99,116,105,111,110,115,58,48,13,10,115,121,110,99,95,102,117,108,108,58,51,13,10,115,121,110,99,95,112,97,114,116,105,97,108,95,111,107,58,48,13,10,115,121,110,99,95,112,97,114,116,105,97,108,95,101,114,114,58,48,13,10,101,120,112,105,114,101,100,95,107,101,121,115,58,49,48,52,49,48,49,54,13,10,101,118,105,99,116,101,100,95,107,101,121,115,58,48,13,10,107,101,121,115,112,97,99,101,95,104,105,116,115,58,49,51,50,51,48,13,10,107,101,121,115,112,97,99,101,95,109,105,115,115,101,115,58,48,13,10,112,117,98,115,117,98,95,99,104,97,110,110,101,108,115,58,51,13,10,112,117,98,115,117,98,95,112,97,116,116,101,114,110,115,58,49,13,10,108,97,116,101,115,116,95,102,111,114,107,95,117,115,101,99,58,49,48,56,52,13,10,13,10,35,32,82,101,112,108,105,99,97,116,105,111,110,13,10,114,111,108,101,58,109,97,115,116,101,114,13,10,99,111,110,110,101,99,116,101,100,95,115,108,97,118,101,115,58,50,13,10,115,108,97,118,101,48,58,105,112,61,49,55,46,49,50,49,46,49,51,56,46,49,53,56,44,112,111,114,116,61,51,49,48,49,49,44,115,116,97,116,101,61,111,110,108,105,110,101,44,111,102,102,115,101,116,61,52,49,55,50,48,56,49,49,52,52,44,108,97,103,61,49,13,10,115,108,97,118,101,49,58,105,112,61,49,55,46,49,50,49,46,49,52,56,46,56,54,44,112,111,114,116,61,51,49,48,48,55,44,115,116,97,116,101,61,111,110,108,105,110,101,44,111,102,102,115,101,116,61,52,49,55,50,48,56,49,49,52,52,44,108,97,103,61,49,13,10,109,97,115,116,101,114,95,114,101,112,108,95,111,102,102,115,101,116,58,52,49,55,50,48,56,49,49,52,52,13,10,114,101,112,108,95,98,97,99,107,108,111,103,95,97,99,116,105,118,101,58,49,13,10,114,101,112,108,95,98,97,99,107,108,111,103,95,115,105,122,101,58,49,48,52,56,53,55,54,13,10,114,101,112,108,95,98,97,99,107,108,111,103,95,102,105,114,115,116,95,98,121,116,101,95,111,102,102,115,101,116,58,52,49,55,49,48,51,50,53,54,57,13,10,114,101,112,108,95,98,97,99,107,108,111,103,95,104,105,115,116,108,101,110,58,49,48,52,56,53,55,54,13,10,13,10,35,32,67,80,85,13,10,117,115,101,100,95,99,112,117,95,115,121,115,58,50,48,51,49,46,56,50,13,10,117,115,101,100,95,99,112,117,95,117,115,101,114,58,49,49,56,54,46,51,49,13,10,117,115,101,100,95,99,112,117,95,115,121,115,95,99,104,105,108,100,114,101,110,58,55,55,46,50,50,13,10,117,115,101,100,95,99,112,117,95,117,115,101,114,95,99,104,105,108,100,114,101,110,58,54,49,54,46,53,51,13,10,13,10,35,32,75,101,121,115,112,97,99,101,13,10,100,98,48,58,107,101,121,115,61,51,52,54,56,49,44,101,120,112,105,114,101,115,61,51,52,54,56,49,44,97,118,103,95,116,116,108,61,52,52,48,48,56,50,56,51,13,10,13,10]}' }
redis: 2.6.3
redis-parser 2.6.0

I just had a look at this and I doubt that the parser made a mistake.
Can you please tell me how exactly it came to this error and are you by any chance able to reproduce this?

I am closing this as there has never been a follow-up. Please comment if something like this happens again / if there is any new information about it.


code of conduction.md

as its an open source so might be we need an code of conduct file

Can I contribute

Hey @Mukesh-ghildiyal  and @RonakSurana-2001
Go ahead, both of you can contribute to this issue. If you think any more improvements can be made, feel free to go for it. Keep up the great work, and happy contributing!


Mnist Grads Cpp

@saxenasaurabh

SGTM
On Wed, Jul 15, 2020 at 6:58 PM Saurabh Saxena<EMAIL_ADDRESS>wrote:

@saxenasaurabh commented on this pull request.
In tensorflow/c/eager/mnist_gradients_test.cc
https://github.com/tensorflow/tensorflow/pull/41432#discussion_r455464234
:

+namespace tensorflow {
+namespace gradients {
+namespace internal {
+namespace {
+
+class CppGradients

: public ::testing::TestWithParam<std::tuple<const char*, bool, bool>> {
protected:
void SetUp() override {
TF_SetTracingImplementation(std::get<0>(GetParam()));
}
+};

+// Creates an Identity op.
+Status Identity(AbstractContext* ctx,
Should we add these in c/experimental/ops and c/experimental/gradients?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/41432#discussion_r455464234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRJLH6J35NGBB5IKNK3R3ZNDPANCNFSM4O3CUXPQ
.

--

Alex

Hi, It looks like you did a merge in the wrong direction or something.
Can you rebase your branch onto master? this is not submittable as is.

ReluGrad should depend only on the outputs of the relu op
On Fri, Aug 7, 2020 at 9:24 AM amturati<EMAIL_ADDRESS>wrote:

@amturati commented on this pull request.
In tensorflow/c/experimental/gradients/math_grad.cc
https://github.com/tensorflow/tensorflow/pull/41432#discussion_r467142307
:

private:
long counter;
std::vector<AbstractTensorHandle*> forward_inputs;
+};

+class ReluGradientFunction : public GradientFunction {

public:
explicit ReluGradientFunction(std::vector<AbstractTensorHandle*> f_inputs)

 : forward_inputs(f_inputs) {}

Status Compute(Context* ctx,

            absl::Span<AbstractTensorHandle* const> grad_inputs,

            std::vector<AbstractTensorHandle*>* grad_outputs) override {

AbstractTensorHandle* upstream_grad = grad_inputs[0];
AbstractTensorHandle* input_features = forward_inputs[0];

Unless I'm misunderstanding, I think the ReluGrad Op asks for features
which is the input to the Relu Op
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/41432#discussion_r467142307,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRMLBYYZ5N3ZJB2CWYTR7QTE5ANCNFSM4O3CUXPQ
.

--

Alex

Specifically if we use the input we will dramatically increase memory usage
for some models. If you have linear+relu+linear+relu style model, the
gradient of the linear depends on its inputs, which are the outputs of the
relu, so if we can make the gradient of relu depend on its outputs we don't
need any additional memory (but dpeending on its inputs might close to
double memory usage).
On Fri, Aug 7, 2020 at 9:38 AM Saurabh Saxena<EMAIL_ADDRESS>wrote:

@saxenasaurabh commented on this pull request.
In tensorflow/c/experimental/gradients/math_grad.cc
https://github.com/tensorflow/tensorflow/pull/41432#discussion_r467149084
:

private:
long counter;
std::vector<AbstractTensorHandle*> forward_inputs;
+};

+class ReluGradientFunction : public GradientFunction {

public:
explicit ReluGradientFunction(std::vector<AbstractTensorHandle*> f_inputs)

 : forward_inputs(f_inputs) {}

Status Compute(Context* ctx,

            absl::Span<AbstractTensorHandle* const> grad_inputs,

            std::vector<AbstractTensorHandle*>* grad_outputs) override {

AbstractTensorHandle* upstream_grad = grad_inputs[0];
AbstractTensorHandle* input_features = forward_inputs[0];

Either is correct in this case since all we care about is the sign
https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/core/kernels/relu_op_functor.h;l=51-55;drc=791f4f2b773208b21ece71e1d37204a91720346d
but I think it would be nice to be consistent with the python gradient
function which uses the output.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/41432#discussion_r467149084,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRPJ257YFYZN7C4WUMDR7QUXVANCNFSM4O3CUXPQ
.

--

Alex


Improve performance of function restriction sniffs

This abstract sniff is extended by quite a few of our sniffs, and so it has a major impact on the performance of the ruleset as a whole.
Here we make two improvements:

We use isset() instead of in_array().
We don't call findPrevious() a second time unless we actually need the information. We only need to check if the namespace is top-level if the function is prefixed with \\, the namespace separator.

This seems to improve the performance of these sniffs by as much as 25%.
Profiled with Blackfire (free edition, so the links will only be retained for 1 day), by running over a sizable plugin (using a custom ruleset that includes Core, Extra, Docs, and VIP, but with some exclusions):
Before:

After:

Comparison:

I've implemented @grappler's suggestions in 4e2d298, and in addition added $skipped to the list of unset() vars at the end of that if block.

Related: #782 will actually make this PR unit testable for the change to the handling of exclude

@JDGrimes Shall I merge this or do you want to look at #782 before I do ?


TridentBackendConfig : failed to create backend,  update initiated using an invalid configRef

Describe the bug
I am receiving this error every time I delete and regenerate trident opearot
status:
  backendInfo:
    backendName: ''
    backendUUID: ''
  deletionPolicy: delete
  lastOperationStatus: Failed
  message: >-
    Failed to create backend: backend 'Backend-XX-XX-X-XX-XX' update
    initiated using an invalid configRef, it is associated with configRef
    '1548424b-a9ff-4708-bc4c-d3e87cc381dc' and not
    '6f8e9eaa-dc62-4221-b57d-67008f2c7828'
  phase: ''

Environment
Provide accurate information about the environment to help us reproduce the issue.


Compilation fails after requiring a missing fmt/chrono.h

The fmt.wrap file included at the subprojects folder is requiring the 5.2.1 version of the fmt library which doesn't include the chrono header support. This causes the build to fail:
../src/modules/mpd.cpp:3:10: fatal error: fmt/chrono.h: No such file or directory
 #include <fmt/chrono.h>

The correct version should be >=5.3.0. This version included the experimental chrono support:
https://github.com/fmtlib/fmt/releases/tag/5.3.0
Updated wrap file:
https://wrapdb.mesonbuild.com/v1/projects/fmt/5.3.0/1/get_wrap

Updated with 0d0f5ed7db16e13ff96361f56faaa0dc7f4e95e9


required command line arguments

param_file.txt
model_file.csv
jobID
output_dir

Read all other arguments from input file

This is important and should be done soon. Although some of the other issues may be faster to complete.

so you want the number of arguments of simprily.py to be decreased to 5?

param_file.txt
model_file.csv
jobID
output_dir
other_arg_inputfile

No, the remaining arguments should go in model_file.csv.
I'm updating the Issue now...

Example model file:
-macs,./bin/macs,
-length,1000000,
-t,2.5e-8,
-s,1231,
-r,1e-8,
-h,1e5,
-R,genetic_map_b37/genetic_map_GRCh37_chr1.txt.macshs,
-I,2,20,140,
-n,1,A,
-n,2,B,
-ej_1,AB_t,2,1,
-en,AN_t,1,AN
-discovery,1
-sample,2
-daf,daf
-array, array_template/ill_650_test.bed

Runs as
python simprily.py examples/eg1/param_file_eg1.txt examples/eg1/model_file_eg1.csv 1 output_dir

works with no error.

Changed all model files to have:
-macs, ./bin/macs,
Ran it using:
pt simprily.py examples/eg1/param_file_eg1.txt examples/eg1/model_file_eg1.csv 1 output_dir
Interchanging the example numbers for 1, 3, 4, 6, 7
All completed successfully
Changed all model files to have:
-macsswig,./bin/macs,
Ran it using:
pt simprily.py examples/eg1/param_file_eg1.txt examples/eg1/model_file_eg1.csv 1 output_dir
Interchanging the example numbers for 1, 3, 4, 6, 7
All completed successfully
Changed all model files to have:
-macsswig,
Ran it using:
pt simprily.py examples/eg1/param_file_eg1.txt examples/eg1/model_file_eg1.csv 1 output_dir
interchanging the example numbers for 1, 3, 4, 6, 7
Got this error for all files:
  File "simprily.py", line 227, in <module>
    main(argv)
  File "simprily.py", line 51, in main
    processedData =  processInputFiles(args['param file'], args['model file'])
  File "/home/agladstein/Rafaels/SimPrily/processInput.py", line 337, in processInputFiles
    processedData = processModelData(variables, modelData) # creates the input for macsSwig
  File "/home/agladstein/Rafaels/SimPrily/processInput.py", line 170, in processModelData
    macs_args = [flags['-macsswig'][0][0], flags['-length'][0][0], "-I", flags['-I'][0][0]]
IndexError: list index out of range```


Manage threads explicitly instead of using executors - 1/3

Issue #, if available:
#105
Description of changes:

Create a singleton thread provider which provisions threads and handles exceptions by writing to a queue. (The queue is currently a dummy placeholder for correct error handling)
Manage the RcaScheduler thread ourselves instead of using an executor and a separate exception handling thread. This exception handling thread led to the spike in master CPU utilization.
Manage the RcaController as a separate thread instead of using 3 scheduled tasks. It removes creation of 3 exception handling threads as well.

With all of the changes, there is no change in behavior other than the fact we don't see a spike in master CPU utilization. We can improve the error handling with per-task error handling if need be in the next set of commits.
All threads die if they throw an exception that the thread itself is not catching and this leads to that thread dying.
Tests:
Tested on opendistro, unit tests pass.
Code coverage percentage for this patch:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ktkrg I have some comments on this PR. Let's discuss if you agree and maybe we can create another PR to fix ?


support redmine-5

before pull-request
root@aeb7af15062f:/opt/app# bin/rails console --environment=production
Loading production environment (Rails 6.1.6)
irb(main):001:0> Issue.included_modules.include? RedmineAutoPercent::IssuePatch
=> false

after pull-request
root@aeb7af15062f:/opt/app# bin/rails console --environment=production
Loading production environment (Rails 6.1.6)
irb(main):001:0> Issue.included_modules.include? RedmineAutoPercent::IssuePatch
=> true

tested Redmine version
[4] pry(main)> Redmine::VERSION::STRING
=> "5.0.1.stable"

@southbridgeio Hi! Thank you for your useful Redmine plugin :tada:
I want to use this plugin on Redmine 5.0.1, but I cannot get same behavior on older Redmine.
This pull-request gives us "Automatically sets the percent done to 100% ..." on redmine-5.


Chemical renaming

Fixes https://github.com/C2SM/processing-chain/issues/37
This should eventually close https://github.com/C2SM/processing-chain/issues/37 once async becomes the main code. It should push back into async (I've never pushed a branched branch, so please check if all goes correctly).

@efmkoene Thanks for this PR! I will review this one, but will set the base branch to v3.1-rc once async is merged (as it is in its final review stage).

This satisfies your review :-)

launch jenkins


Include the 'Basics of Writing Tutorials' video

Had the parts of this video lying around for a while - finally did the voiceover.
writing-tutorial-basics

Good feedback, thanks. I'll do a re-take with the changes from your suggestions.

@ganicke dead PR?

Yes. I'll close.