About short reads: insert size and type

Hi,
In order to correct my long reads, I have short reads of different insert size and different types (paired end and mate pair).

How is it handle by the program ?

For example for the 1st part Building the short-read BWT with this guide: https://github.com/holtjma/fmlrc/wiki/Converting-to-the-fmlrc-RLE-BWT-format

Should I just catenate everything into a single file (so transforming my paired to single reads). Can we use only paired end or also mate pairs ?

What is the optimal coverage for long reads and short reads ?

Thanks a lot for your help.

Paired-end information is not actually stored anywhere inside the BWT, only string sequences.  Any paired reads are effectively reduced to single-end reads for the purpose of constructing the BWT and FMLRC then only uses the string sequences for correction.
If you have a bunch of fastq files, you would basically cat or gunzip -c them all together in that first step and everything would fall into place (see example with ecoli paired end).
For read correction, the coverage of long reads doesn't matter (since that's what you're correcting), but you want "sufficient" short-read coverage that the correction algorithm of FMLRC considers the k-mers to be solid.  The default absolute minimum k-mer count is 5, and the default dynamic count is 10% of the median counts along the long-read.

Thanks.
I dont't have too much resources so I guess using more reads require more memory.
For short reads coverage, is 50X is a "sufficient" amount ?

More short reads will use more memory during the FMLRC steps, increasing long reads will not impact the memory usage (but will increase run-time of course).
For a diploid organism, I would expect 50X to be enough yes.


transparent color not supported by functions

Passing a color value of transparent into functions like darken causes an error.
Error: Couldn't parse the color string. Please provide the color as a string in hex, rgb, rgba, hsl or hsla notation.
However other color strings such as white work fine.

@corbanbrook This is because transparent does not have an associated color code. In order to act upon it with our color methods, it has to translate to a HEX or RGB value. All other color keywords work since they have associated HEX values. I'm not sure there is a universally accepted color representation for transparent (such as white or black at 0 opacity).

We will also be improving the error messaging in V2, I'll make a note we need to include color keywords (outside of transparent) as valid input types.

I think it would make sense to support transparent as it is a valid color value in css but rather than treating it as black or white with 100% transparency, it should simply pass-through on all color functions like it does on sass/stylus.
Here is a sass example:
.hello {
  color: darken(transparent, 0.5);
}

.hello {
  color: transparent;
}

This has been added to the V3 Roadmap (#354).


cannot retreive infos from Gdrive folders (unsupported URL)

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.06.14. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2016.06.14

Before submitting an issue make sure you have:

[X] At least skimmed through README and most notably FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v --skip-download  --get-id --get-title  "https://drive.google.com/drive/folders/HIDDEN"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'--skip-download', u'--get-id', u'--get-title', u'https://drive.google.com/drive/folders/HIDDEN']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.06.14
[debug] Python version 2.7.6 - Linux-3.14.20-i686-with-glibc2.4
[debug] exe versions: avconv 9.16-6, avprobe 9.16-6, ffmpeg 9.16-6, rtmpdump 2.4
[debug] Proxy map: {}
WARNING: Falling back on generic information extractor.
ERROR: Unsupported URL: https://support.google.com/drive/answer/6286662?p=unsupported_browser&rd=1
Traceback (most recent call last):
  File "/tmp/youtube-dl/youtube-dl/youtube_dl/extractor/generic.py", line 1440, in _real_extract
    doc = compat_etree_fromstring(webpage.encode('utf-8'))
  File "/tmp/youtube-dl/youtube-dl/youtube_dl/compat.py", line 2524, in compat_etree_fromstring
    doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
  File "/tmp/youtube-dl/youtube-dl/youtube_dl/compat.py", line 2513, in _XML
    parser.feed(text)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
    raise err
ParseError: syntax error: line 1, column 0
Traceback (most recent call last):
  File "/tmp/youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 676, in extract_info
    ie_result = ie.extract(url)
  File "/tmp/youtube-dl/youtube-dl/youtube_dl/extractor/common.py", line 342, in extract
    return self._real_extract(url)
  File "/tmp/youtube-dl/youtube-dl/youtube_dl/extractor/generic.py", line 2140, in _real_extract
    raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://support.google.com/drive/answer/6286662?p=unsupported_browser&rd=1
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue required an account credentials please provide them or explain how one can obtain them.
The folder was shared with public link sharing (anyone with the link can view).

Google Drive folders are not supported yet.

Try YT-DLP


Download link is broken

Hi,
The download link in the README file is not working anymore.  Where can we get the  .jar file?

Thanks. I didn't aware bitbucket, where jar files were hosted, closed Mercurial based repository.
You can download jar files from Maven as a workaround:
https://repo1.maven.org/maven2/org/xerial/sqlite-jdbc/<IP_ADDRESS>/

Fixed


ts-node-dev issue or other?

I'm getting this error for like 1 on every 10 runs. Does anyone have solution for this?

This is runtime error, seems something wrong with your code.


Lack of IME support

Lacks support for the input method. Many input methods might require multiple key presses to input a single character, or a single key press to input multiple characters. There will be input prompts during the process. This is commonly seen in Chinese input methods.

That's correct. I'm really unfamiliar on how IME works and never took the time to implement it. I understand this is a blocking issue for many people so I need to investigate it.

IME support has been added in current eepp development branch. Next ecode's version will ship with IME support. This is gonna be probably this week.


Update to newest version of Omnitone

The package.json isn't pulling from the most recent version of Omnitone. (Version 1.05 vs. 1.2.4).
https://www.npmjs.com/package/omnitone/v/1.2.4

I've signed the Google CLA under my name.

As of today, Omnitone is at 1.2.5, fixing an issue that resonance has inherited.


Update: Apache.OpenOffice version 4.1.11

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.1 schema?

Microsoft Reviewers: Open in CodeFlow

My mistake. I installed in sandbox and the original version number is correct.


CI currently broken? Centos 8 is EOL?

https://github.com/RTimothyEdwards/open_pdks/actions/runs/1909078486
 CentOS Linux 8 - AppStream                      237  B/s |  38  B     00:00
  Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist

@umarcor / @kguala - I think you were just doing something related to CentOS for SymbiFlow / F4PGA. If it is easy to do you help fix GitHub Actions here for @RTimothyEdwards?

CentOS Linux 8 reached End Of Life (EOL) on December 31st, 2021 -- it seems like the next release of CentOS is "CentOS Stream 8"?

FYI - https://www.centos.org/centos-linux-eol/

Additionally, with this deadline falling during a time when many of our team, as well as many of our users, will be out of the office, we intend to bend the usual EOL process by keeping this content available until January 31st.

Which probably explains why only now at the end of February has things started breaking.

I don't know anything about this CI, so I will definitely need help with any updates.

In several projects (such as Verible or f4pga-examples), CentOS 8 was removed. CentOS 7 is kept, because it is alive for at least one more year. In some places, Fedora is tested.


Translate the readme

Translate the readme to another language in a new readme file

Hello, I would like to work on this


Types "Null?" and "dynamic?" should probably be a hint/auto-fix

The following program produces no diagnostics:
void main() {
  Null? x = null;
  dynamic? y = null;
  print(x == y);
}

I imagine that Null? and dynamic? should never really happen, and are deserving of being a HINT in the analyzer.

Landed a Hint in https://github.com/dart-lang/sdk/commit/d693078bbfef7bd2f5ad9735b17058271d9b28e2


Review all third-party dependencies

We (the Go SDK team) have been burned in the past by poor-quality third-party dependencies.  Review the current list to ensure they're required and provide value.
We should also avoid using any third-party type as an "exchange type" (a type exposed in public surface area).

Mostly a duplicate of  #17

Closing as dupe.


Can support the load directly from the HTML address for PDF？

Now I have a project server returns a PDF address to me I want to use this address directly display PDF documents, can support

Oh. thank you

if you are happy, just close the thread.


WIP: Fixes #1618. Add zstandard support

WIP
Note I'm keeping this draft until I can test with GEOS.

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description
This PR adds support for zstandard compression in History via zstandard_level.
Much like netCDF quantize support, if netCDF-C wasn't built with zstandard support, then MAPL will not allow a user to set zstandard_support. We also prevent a user from setting both deflate and zstandard_level at the same time. Also, two new ExtData tests are added.
NOTE: At the moment, this support is only available via Spack builds of MAPL (and GEOS). The reason is that zstandard support in netCDF-C is only available via shared library (because it uses HDF5 plugins). For historic reasons, ESMA Baselibs uses static HDF5, netCDF, etc.
cc: @edwardhartnett
Related Issue
Closes #1618

Yup. This is currently not working. I've done something wrong, but not sure what yet. Turns out, enabling zstandard doesn't actually enable it! Bug hunting time.


Merge 3-12 updates to live

OPS Build status updates of commit 910942d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Language/Concepts/Forms/add-a-watch-expression.md
:white_check_mark:Succeeded
View

Language/Concepts/Forms/adjust-horizontal-and-vertical-spacing-between-controls.md
:white_check_mark:Succeeded
View

Language/Concepts/Forms/create-a-list-box-with-option-buttons-or-check-boxes.md
:white_check_mark:Succeeded
View

Language/Concepts/Forms/set-the-tab-order-using-the-tabindex-property.md
:white_check_mark:Succeeded
View

Language/Concepts/Forms/what-is-a-shortcut-menu.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/64-bit-visual-basic-for-applications-overview.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/avoiding-naming-conflicts.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/calling-procedures-with-the-same-name.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/calling-property-procedures.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/calling-sub-and-function-procedures.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/compiler-constants.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/creating-object-variables.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/declaring-arrays.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/declaring-constants.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/declaring-variables.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/looping-through-code.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/making-faster-fornext-loops.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/type-conversion-functions.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/understanding-automation.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/understanding-named-arguments-and-optional-arguments.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/understanding-objects-properties-methods-and-events.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/understanding-scope-and-visibility.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/understanding-visual-basic-syntax.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/using-arrays.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/using-doloop-statements.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/using-for-eachnext-statements.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/using-fornext-statements.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/using-ifthenelse-statements.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/using-select-case-statements.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/vartype-constants.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/visual-basic-naming-rules.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/writing-a-function-procedure.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/writing-a-sub-procedure.md
:white_check_mark:Succeeded
View

Language/Concepts/Getting-Started/writing-visual-basic-statements.md
:white_check_mark:Succeeded
View

Language/Glossary/glossary-vba.md
:white_check_mark:Succeeded
View

Language/Glossary/vbe-glossary.md
:white_check_mark:Succeeded
View

Language/How-to/check-or-add-an-object-library-reference.md
:white_check_mark:Succeeded
View

Language/How-to/set-visual-basic-environment-options.md
:white_check_mark:Succeeded
View

Language/How-to/stop-code-execution.md
:white_check_mark:Succeeded
View

Language/How-to/user-defined-data-type.md
:white_check_mark:Succeeded
View

Language/How-to/user-defined-type-not-defined.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/abs-function.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/activate-deactivate-events.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/activex-component-can-t-create-object-or-return-reference-to-this-object-error-4.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/add-in-manager-dialog-box.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/add-method-microsoft-forms.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/add-method-visual-basic-for-applications.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/additem-method.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/ambiguous-name-detected.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/appactivate-statement.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


netcoreapp3.1 prerequisite for Azure Function add API to static webapp

VS Code Azure Functions (Extension) seems to have a prerequisite of netcoreapp3.1.
The error message on vscode is:
Unrecognized target framework "netcoreapp3.1".
Available frameworks: "net6.0", "net6.0".
Source: Azure Functions (Extension)

The install link to netcoreapp3.1 could be added to
https://docs.microsoft.com/en-au/azure/static-web-apps/add-api?tabs=vanilla-javascript#prerequisites
This may be a related to an issue in Azure Function about not detecting installed skds/runtimes.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5689b389-ead5-825d-dde1-9a290bc0819f
Version Independent ID: 52a526a2-477a-dda4-02b4-eac1440811ed
Content: Add an API to Azure Static Web Apps with Azure Functions
Content Source: articles/static-web-apps/add-api.md
Service: static-web-apps
GitHub Login: @manekinekko
Microsoft Alias: wachegha

Hi @OzBob, if I'm not mistaken the static webapps extension should download the necessary .net core dependencies if not already installed. If you change your Azure Functions runtime version to ~3, it should pull the .NET Core 3 LTS. See Let users change Functions version when picking runtime by ejizba · Pull Request #2987 · microsoft/vscode-azurefunctions (github.com).

I'm getting the exact same issue trying to use the 'Create HTTP Function' option to add an API to an existing Azure Static Web Apps project and selecting a C# function.

my settings.json says:
    "azureFunctions.projectRuntime": "~4"

and there is a line in 'tastks.json' that refers to 'net6.0'
			"type": "func",
			"dependsOn": "build (functions)",
			"options": {
				"cwd": "${workspaceFolder}/bin/Debug/net6.0"
			},
			"command": "host start",
			"isBackground": true,
			"problemMatcher": "$func-dotnet-watch"
		}

@alexweininger @nturinski Any idea what's happening here?

Nathan's replied here https://github.com/microsoft/vscode-azurefunctions/issues/3002#issuecomment-973453019.

Could you run func --version for me and tell me what version of the Function Core Tools that you have installed? I think you may have a version that is no longer compatible with .NET 3.1.

Closing this issue as it's being mitigated in microsoft/vscode-azurefunctions#3002.

Hi @RyanHill-MSFT But https://github.com/microsoft/vscode-azurefunctions/issues/3002 has been closed for want of more information.

I think there's some confusion there. It doesn't look like the Azure Static Web Apps VS Code extension supports creating .NET 6 functions right now. Created an issue to track: https://github.com/microsoft/vscode-azurestaticwebapps/issues/590

For now, create a folder for your API, then use the Azure Functions: Create New Project... command to create the .NET 6 Azure Functions project in the API folder you created.

It was the create the Role based Function App for Role Management (preview) but for now I have used JS . But Azure SWA is throwing a 500 Internal Server error


Enhance the sample python client script

Kafka REST proxy is now accepting JSON objects in Producer API, so the sample python script has been updated accordingly.
Add 2 APIs: List partitions, List a partition

@jihwang0709 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jihwang0709 Thanks for your contribution. Changes look good.
#sign-off


feat(watcher): introduce 'final' flush mode

In this PR the 'final' WatcherOptions flush mode is added.
'final' flush mode executes the watcher callbacks after all other effects (with multiple iterations).
Why is this necessary?
  it('multi-iteration reactivity: post', async () => {
    const count = ref(0)
    const count2 = ref(0)
    const count3 = ref(0)

    watchEffect(() => {
      count2.value = count.value * 2
    })

    watchEffect(() => {
      count3.value = count2.value * 2
    })

    const results: number[] = []
    const assertion = jest.fn(() => {
      const c1 = count.value
      const c2 = count2.value
      const c3 = count3.value
      results.push(c1 + 10 * c2 + 100 * c3)
    })

    watchEffect(
      () => {
        assertion()
      },
      {
        flush: 'post'
      }
    )

    expect(assertion).toHaveBeenCalledTimes(1)

    count.value++
    await nextTick()

    expect(results).toEqual([0, 21, 421])
    expect(assertion).toHaveBeenCalledTimes(3)
  })

assertion is executed double (3 times in total because of the initial call).
The reason is that value it watches may have inter-dependencies, triggering each other in multi-iteration flushPostQueue runs. In every iteration assertion may be added and invoked.
We have a real world use case. We have a component that creates some div elements with scrollbars. You can change the zoom value, which in turn changes the visibleRange using a watchEffects. Another part of the application watches zoom and visibleRangeX (and more) to finally draw stuff in a canvas. We noticed this draw function being called multiple times because of the issue described by @jods4. The draw function is very expensive so we don't want that to happen.
Although the recent commit https://github.com/vuejs/vue-next/commit/165068dbc295bb70fdec9ae56dfcaac17d2f977c (see https://github.com/vuejs/vue-next/issues/1595) mitigates the problem somewhat by checking if the effect was still on the queue (and it has not been run yet), it can still go wrong when watchers that have multi-level dependencies, or when the effect was already executed in the pending PostFlushCbs.
This PR addresses this problem by providing a way of postponing the effect until everything else has been processed. This allows you to make sure that an expensive watcher is run only once in multi-iteration flushes.

First, I'd say this kind of chained watching is bad practice - you are relying on side effects to propagate the consistency of the state graph.
From your example, the only actual mutable state is zoom while visibleRange and all other state the depends on zoom are derived state, which by design should be modeled as computed properties:
const { ref, watchEffect, computed } = Vue

const count = ref(0)
const count2 = computed(() => count.value * 2)
const count3 = computed(() => count2.value * 2)

watchEffect(
  () => {
    const c1 = count.value
    const c2 = count2.value
    const c3 = count3.value
    // only runs once when count.value is mutated
  }
)

postFlushCb is for side effects and your problems roots in relying on side effects to stabilize the state graph - and when you do that, repeated invocation will sometimes be needed to reach stable state. Adding yet another flush queue doesn't fundamentally solve the problem. If you have multiple watchers using flush: 'final', you'd eventually run into repeated invocations in the final queue as well.

Thanks for the suggestion, I didn't realise that they were handled differently than watchEffects in terms of scheduling.
I will try to convert my code and see if that works.


add frontend readme

Hi @soniasusanto
Do you wanna move this content to the frontend folder like we did in the backend and then add a reference?
I feel this way it keeps things clean without cluttering.
WDYT?

yea sounds good, moved it to frontend folder, the reference will be added by @jessat 's PR so I removed my changes there.


Change implode signature according to php.net

https://www.php.net/manual/en/function.implode.php

Removed array for the $separator. This is no more supported since PHP 8.0.
$array should not be nullable.

@RSickenberg unfortunately such change will not work. It will produce false positive errors when declare(strict_types=1)

Removed array for the $separator. This is no more supported since PHP 8.0.

Unfortunately stubs at the current implementation should suit all the versions of PHP but not only the latest one


OPC UA client driver integration

Features supported :

Connection to server excluding security configs.
User configuration through environment variables.
Multi Sensor data gathering.
Sensor filtering based on configured RegEx.
Batch write raw sensor data into Pravega streams.

Test Results on Driver performance:

Sr No.
No Of Sensors
Polling periodicity
Average processing time (Read from server +Write to pravega)

1
1
1000 ms
7.68 ms

2
3
1000 ms
10.49 ms

3
50
1000 ms
15.64 ms

4
100
1000 ms
18.88 ms

5
500
1000 ms
40.73 ms

4
998 (max limit for bulk read)
1000 ms
75.38 ms

Sample Event JSON written to Pravega for each sensor :
{
"nodeIdentifier":"Channel.Device.Node",
"timestamp":1376930356913500,
"dataType":"java.lang.Float",
"data":13.05
}


[URP] Bug on underwater effect - flickering with Enviro asset. Missing camera type check.

If there are other types of cameras in the scene besides the game camera, then these are also used in the various callbacks. In the underwater effect this generates a flicker
Instead only a Game camera should be used.
I discovered this issue using Enviro asset. This asset draw into an hidden camera used for rendering reflection probes.
When I went underwater, the screen starts to flicker due to a massive redraw calls.
Versions
I tested with URP version.
To Reproduce
Install Enviro, and then go underwater.
Platform
Any
Additional context
Solution:
Edit the UnderwaterEffect.cs and change the BeginCameraRendering method, adding the camera type check:
    private void BeginCameraRendering(ScriptableRenderContext scriptableRenderContext, Camera camera)
    {
        if (camera.cameraType != CameraType.Game) return;

        _currentCamera = camera;
    }

I think that this check should be done in the other places where you use this callback:
RenderPipelineManager.beginCameraRendering
I also added this:
        if (camera.cameraType != CameraType.Game) return;

at the beginning of each
  public void BeginCameraRendering(ScriptableRenderContext context, Camera camera)

inside these files:
UnderwaterEffect.cs (obviously)
OceanDepthCache.cs
OceanChunkRenderer.cs
OceanPlanarReflection.cs
These are the available camera types:
//     Describes different types of camera.
[Flags]
public enum CameraType
{
    //     Used to indicate a regular in-game camera.
    Game = 1,
    //     Used to indicate that a camera is used for rendering the Scene View in the Editor.
    SceneView = 2,
    //     Used to indicate a camera that is used for rendering previews in the Editor.
    Preview = 4,
    //     Used to indicate that a camera is used for rendering VR (in edit mode) in the
    //     Editor.
    VR = 8,
    //     Used to indicate a camera that is used for rendering reflection probes.
    Reflection = 16
}

Inside the OceanDeepCache, the check should be:
if (camera.cameraType != CameraType.Game && camera.cameraType != CameraType.SceneView && camera.cameraType != CameraType.Preview) return;

Inside the OceanDeepCache, the check should be:
if (camera.cameraType != CameraType.Game && camera.cameraType != CameraType.SceneView && camera.cameraType != CameraType.Preview) return;

Thank you for finding the problem. I don't think that will fully address the problem for the depth camera though. I think something like camera != _camDepthCache would cover all cases as it will limit the function to the created camera. But that will require more changes for it to work. I'll look into this more.

Thank you for finding the problem. I don't think that will fully address the problem for the depth camera though. I think something like camera != _camDepthCache would cover all cases as it will limit the function to the created camera. But that will require more changes for it to work. I'll look into this more.

No, this is related to the depth camera, just with the integration with other asset.
In this case with Enviro, which use its own reflection probe, and it update every frame, so that each BeginCameraRendering is called even with camera != Game type.
Instead, the check into OceanDeepCache should include the other camera types, because the DeepCache could be update inside the editor too, so that camera type should be included also.

No, this is related to the depth camera, just with the integration with other asset.
In this case with Enviro, which use its own reflection probe, and it update every frame, so that each BeginCameraRendering is called even with camera != Game type.
Instead, the check into OceanDeepCache should include the other camera types, because the DeepCache could be update inside the editor too, so that camera type should be included also.

Thanks. I had a look over all of them and fixed the ones that needed fixing. Fix will be out for 4.8. Details below:
UnderwaterEffect.cs
Removed BeginCameraRendering. This one didn't make much sense since we expect the parent GO to have a camera so we will use that instead. This may have been an issue since that event sets the camera for _CameraForward, which is set in LateUpdate, resulting in the wrong camera forward being used.
OceanDepthCache.cs
Removed BeginCameraRendering. This one could execute other cameras, but it never ran every frame so could have been missed.
OceanPlanarReflection.cs
Uses if (camera != _camViewpoint)already  so it will only render for the camera attached to same game object. No change required.
OceanChunkRenderer.cs
The usage for this one is correct. BeginCameraRendering sets the camera property to solve Camera.current not being supported. OnWillRenderObject is called right after BeginCameraRendering for the camera so the correct camera is set.

Thanks. I had a look over all of them and fixed the ones that needed fixing. Fix will be out for 4.8. Details below:
UnderwaterEffect.cs
Removed BeginCameraRendering. This one didn't make much sense since we expect the parent GO to have a camera so we will use that instead. This may have been an issue since that event sets the camera for _CameraForward, which is set in LateUpdate, resulting in the wrong camera forward being used.
OceanDepthCache.cs
Removed BeginCameraRendering. This one could execute other cameras, but it never ran every frame so could have been missed.
OceanPlanarReflection.cs
Uses if (camera != _camViewpoint)already  so it will only render for the camera attached to same game object. No change required.
OceanChunkRenderer.cs
The usage for this one is correct. BeginCameraRendering sets the camera property to solve Camera.current not being supported. OnWillRenderObject is called right after BeginCameraRendering for the camera so the correct camera is set.

@Magic73 4.8 is out. Please let me know if it solves the issues for you when you have a chance. Thank you.

Closing this one. I'll reopen if we get reports of the issue persisting.


BinarySearchTree.py

Fixes #{ISSUE_NUMBER}
By submitting this pull request I confirm I've read and complied with the below declarations.

[ ] I have read the Contribution guidelines and I am confident that my PR reflects them.
[ ] I have followed the coding guidelines for this project.
[ ] My code follows the skeleton code structure.
[ ] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

Hi! Thanks for showing interest in contributing to this repository.
Please make sure that you have ticked the points mentioned in PR description correctly.
Thanks again!

what is wrong in code??

@avsingh999: There are some style issues with the code. You can see more details here.


[languagedetection] Fix Node.js installation in E2E test

What does this PR do?
Update the Node.js installation steps, as they were previously failing. The steps were taken from https://github.com/nodesource/distributions#installation-instructions which is recommended by nodejs.org.

Motivation
https://datadoghq.atlassian.net/browse/PROCS-3429

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

E2E language detection tests passed on this commit: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/360818599


refactor(storybook): ♻ remove trash, change emoji

:tada: This PR is included in version 1.8.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


FactoryBot linter failing for a model that uses closure_tree

I have a model that I am using closure tree with and have a factory created for it. We have a spec that does FactoryBot.lint FactoryBot.factories, which is now failing because of the error below.
expected no Exception, got #<FactoryBot::InvalidFactoryError: The following factories are invalid:

* display_logic - undefined local variable or method `_ct_reorder_prior_siblings_if_parent_changed' for #<Registries::DisplayLogic:0x00007ffb3bc1c828> (NameError)

This was the last commit where the factory was passing the linter. Any suggestions on how to fix this?
rails (5.2.0)
factory_bot (4.8.2)
factory_bot_rails (4.8.2)

@chunlea I digged into it and found out it was this change that broke it. I am still trying to figure out why ActiveRecord is not connected in my test environment.

I am still trying to figure out why ActiveRecord is not connected in my test environment.

See https://github.com/ClosureTree/closure_tree/issues/264 :

Rails itself (without closure_tree) doesn't hit the DB until first request will come, so everything works as expected even if DB was not ready at time of first request (ActiveRecord will analyze tables when DB will be ready).


Package: python3:x64-windows  issue

 PS C:\vcpkg-master> .\vcpkg install mlpack[tools]:x64-windows
The following packages will be built and installed:
  * boost[core]:x64-windows
  * boost-parameter-python[core]:x64-windows
  * boost-poly-collection[core]:x64-windows
  * boost-process[core]:x64-windows
  * boost-program-options[core]:x64-windows
  * boost-python[core]:x64-windows
  * boost-sort[core]:x64-windows
  * boost-stacktrace[core]:x64-windows
  * boost-statechart[core]:x64-windows
  * boost-wave[core]:x64-windows
  * boost-yap[core]:x64-windows
  * clapack[core]:x64-windows
    mlpack[core,tools]:x64-windows
  * python3[core]:x64-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/14: python3:x64-windows
Building package python3[core]:x64-windows...
-- Using cached C:/vcpkg-master/downloads/python-cpython-v3.7.3.tar.gz
-- Extracting source C:/vcpkg-master/downloads/python-cpython-v3.7.3.tar.gz
-- Using source at C:/vcpkg-master/buildtrees/python3/src/v3.7.3-1161ad7a91
-- Building C:/vcpkg-master/buildtrees/python3/src/v3.7.3-1161ad7a91-Lib-dynamic-crt-dynamic/PCBuild/pythoncore.vcxproj for Release
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
    Command failed: msbuild;C:/vcpkg-master/buildtrees/python3/src/v3.7.3-1161ad7a91-Lib-dynamic-crt-dynamic/PCBuild/pythoncore.vcxproj;/p:Configuration=Release;/t:Rebuild;/p:Platform=x64;/p:PlatformToolset=v140;/p:VCPkgLocalAppDataDisabled=true;/p:UseIntelMKL=No;/p:WindowsTargetPlatformVersion=;/m
    Working Directory: C:/vcpkg-master/buildtrees/python3/x64-windows-rel
    Error code: 1
    See logs for more information:
      C:\vcpkg-master\buildtrees\python3\build-x64-windows-rel-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_msbuild.cmake:119 (vcpkg_execute_required_process)
  ports/python3/portfile.cmake:37 (vcpkg_build_msbuild)
  scripts/ports.cmake:71 (include)

Error: Building package python3:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: python3:x64-windows
  Vcpkg version: 2018.11.23-nohash

I had the same problem it seems boost-python/portfile doesn't work with multiple version of Python installed (?) or that the line
file(GLOB PYTHON_INCLUDE_PATH "${CURRENT_INSTALLED_DIR}/include/python[0-9.]*")
is not working as expected :(
A quick fix that worked for me is to define the include path manually :
set(PYTHON_INCLUDE_PATH "C:/vcpkg/installed/x64-windows/include/python3.7")

Thanks for the tio. I tried adding
set(PYTHON_INCLUDE_PATH "C:/vcpkg/installed/x64-windows/include/python3.7")
to the ports/boost-python/portfile.cmake  file and rerun
.\vcpkg install mlpack[tools]:x64-windows
but I keep getting the same error message.
I indeed have Anaconda + Python installed, so an alternative could be to remove this installation.
From: zeFresk<EMAIL_ADDRESS>Sent: Monday, 6 May 2019 12:27
To: Microsoft/vcpkg<EMAIL_ADDRESS>Cc: Martens, J.B.O.S<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Microsoft/vcpkg] Package: python3:x64-windows issue (#6310)
I had the same problem it seems boost-python/portfile doesn't work with multiple version of Python installed (?) or that the line
file(GLOB PYTHON_INCLUDE_PATH "${CURRENT_INSTALLED_DIR}/include/python[0-9.]*")
is not working as expected :(
A quick fix that worked for me is to define the include path manually :
set(PYTHON_INCLUDE_PATH "C:/vcpkg/installed/x64-windows/include/python3.7")
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vcpkg/issues/6310#issuecomment-489574414, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADYMIIQTFKSCHRQKKN4FMEDPUABWBANCNFSM4HKZBR6Q.

Did you add it before or after the line with GLOB?
I have Anaconda, Python 2 & 3 installed so I don't think that's the problem (with my fix).

I tried both before and after the GLOB statement (not sure which one is the correct order).
I noticed that the directory  C:/vcpkg/installed/x64-windows/include/python3.7 doesn’t seem to exist.
The feedback that I get is the following:
From: zeFresk<EMAIL_ADDRESS>Sent: Tuesday, 7 May 2019 17:00
To: microsoft/vcpkg<EMAIL_ADDRESS>Cc: Martens, J.B.O.S<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/vcpkg] Package: python3:x64-windows issue (#6310)
Did you add it before or after the line with GLOB?
I have Anaconda, Python 2 & 3 installed so I don't think that's the problem (with my fix).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vcpkg/issues/6310#issuecomment-490117359, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADYMIIUYBHEBPXHADMXJLWDPUGKQZANCNFSM4HKZBR6Q.

I have Anaconda + Python 3 installed.
I tried the fix proposed by @zeFresk, but had the same problem.
Is there any workaround?

I tried both before and after the GLOB statement (not sure which one is the correct order).
I noticed that the directory  C:/vcpkg/installed/x64-windows/include/python3.7 doesn’t seem to exist.
The feedback that I get is the following:
PS C:\vcpkg-master> .\vcpkg install mlpack[tools]:x64-windows
The following packages will be built and installed:

boost[core]:x64-windows
boost-parameter-python[core]:x64-windows
boost-poly-collection[core]:x64-windows
boost-process[core]:x64-windows
boost-program-options[core]:x64-windows
boost-python[core]:x64-windows
boost-sort[core]:x64-windows
boost-stacktrace[core]:x64-windows
boost-statechart[core]:x64-windows
boost-wave[core]:x64-windows
boost-yap[core]:x64-windows
clapack[core]:x64-windows
mlpack[core,tools]:x64-windows
python3[core]:x64-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/14: python3:x64-windows
Building package python3[core]:x64-windows...
-- Using cached C:/vcpkg-master/downloads/python-cpython-v3.7.3.tar.gz
-- Extracting source C:/vcpkg-master/downloads/python-cpython-v3.7.3.tar.gz
-- Using source at C:/vcpkg-master/buildtrees/python3/src/v3.7.3-1161ad7a91
-- Building C:/vcpkg-master/buildtrees/python3/src/v3.7.3-1161ad7a91-Lib-dynamic-crt-dynamic/PCBuild/pythoncore.vcxproj for Release
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
Command failed: msbuild;C:/vcpkg-master/buildtrees/python3/src/v3.7.3-1161ad7a91-Lib-dynamic-crt-dynamic/PCBuild/pythoncore.vcxproj;/p:Configuration=Release;/t:Rebuild;/p:Platform=x64;/p:PlatformToolset=v140;/p:VCPkgLocalAppDataDisabled=true;/p:UseIntelMKL=No;/p:WindowsTargetPlatformVersion=;/m
Working Directory: C:/vcpkg-master/buildtrees/python3/x64-windows-rel
Error code: 1
See logs for more information:
C:\vcpkg-master\buildtrees\python3\build-x64-windows-rel-out.log

Call Stack (most recent call first):
scripts/cmake/vcpkg_build_msbuild.cmake:119 (vcpkg_execute_required_process)
ports/python3/portfile.cmake:37 (vcpkg_build_msbuild)
scripts/ports.cmake:71 (include)
Error: Building package python3:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: python3:x64-windows
Vcpkg version: 2018.11.23-nohash
Additionally, attach any relevant sections from the log files above.
From: zeFresk<EMAIL_ADDRESS>Sent: Tuesday, 7 May 2019 17:00
To: microsoft/vcpkg<EMAIL_ADDRESS>Cc: Martens, J.B.O.S<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/vcpkg] Package: python3:x64-windows issue (#6310)
Did you add it before or after the line with GLOB?
I have Anaconda, Python 2 & 3 installed so I don't think that's the problem (with my fix).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vcpkg/issues/6310#issuecomment-490117359, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADYMIIUYBHEBPXHADMXJLWDPUGKQZANCNFSM4HKZBR6Q.

Hi @jbmartens thanks for posting this issue.  Does this issue still exist on your machine now?
I can install mlpack on my local successfully.  if this issue can be reproduced now, please provide your log.
Thanks.

If more than one python version is installed, the boost-python install fails. If I hard code the path to the version of python needed and remove the search in the portfile.cmake then boost-python package will install properly - windows 10 64-bit Version 1909 (OS Build 18363.476 and the latest updates to VS 2017 and VS 2019 - example of portfile.cmake with hardcoded PYTHON_INCLUDE_PATH:
_# Find Python. Can't use find_package here, but we already know where everything is _
# file(GLOB PYTHON_INCLUDE_PATH "${CURRENT_INSTALLED_DIR}/include/python[0-9.]*")
set(PYTHON_INCLUDE_PATH "D:/Git/vs2017/installed/x64-windows/include/python3.7")
set(PYTHONLIBS_RELEASE "${CURRENT_INSTALLED_DIR}/lib")

Related: #6639 #8882.

@jbmartens
Could you please help confirm if the issue you encountered is the same as that before?
In my opinion, the old issue is caused by installing python2 and python3 in the same time.
And now this issue has been fixed.
As for the issue you encountered, it seems that it is related with Visual Studio ToolSet version.
Please double check about this.
If it is still a problem for you, please open a new issue.

@NancyLi1013
I do believe that it is the same issue.
If I read the first post correctly, in order to install mlpack, first boost-python and of course python3 itself have to be built and installed. The whole process starts with package 1 of 14: python3[core]. And that's the build/installation, that fails.
It would probably be very helpful to see, if @jbmartens' VCPKG\buildtrees\python3\build-x64-windows-rel-out.log contains

fatal error C1189: #error: NTDDI_VERSION setting conflicts with _WIN32_WINNT setting

as well.
Reading the whole thread again, I notice that manually adding the include path of python3 to boost-python didn't work, because - as @jbmartens states:

I noticed that the directory  C:/vcpkg/installed/x64-windows/include/python3.7 doesn’t seem to exist.

I'm wondering, why would it exist? The build and installation of python3 failed...
I did a test just now, after updating vcpkg to Version 2020.02.04-nohash-external, the commit is [c5f01e1]:
I removed and purged all installed packages and deleted all remaining downloads and buildtrees as well. Then I tried to
vcpkg install python3
After successfully building and installing the dependency packages

(1/4) libffi
(2/4) openssl-windows
(3/4) openssl

building package (4/4) python3 fails with:

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
Command failed: msbuild C:/Dev/vcpkg/buildtrees/python3/src/v3.7.3-1161ad7a91-Lib-Win/PCBuild/pythoncore.vcxproj /p:Configuration=Release /t:Rebuild /p:Platform=x64 /p:PlatformToolset=v142 /p:VCPkgLocalAppDataDisabled=true /p:UseIntelMKL=No /p:WindowsTargetPlatformVersion=10.0.18362.0 /m
Working Directory: C:/Dev/vcpkg/buildtrees/python3/x64-windows-rel
Error code: 1
See logs for more information:
C:\Dev\vcpkg\buildtrees\python3\build-x64-windows-rel-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_build_msbuild.cmake:119 (vcpkg_execute_required_process)
ports/python3/portfile.cmake:46 (vcpkg_build_msbuild)
scripts/ports.cmake:90 (include)
Error: Building package python3:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with '.\vcpkg update', then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: python3:x64-windows
Vcpkg version: 2020.02.04-nohash-external
Additionally, attach any relevant sections from the log files above.`

C:\Dev\vcpkg\buildtrees\python3\build-x64-windows-rel-out.log includes lots of

C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\shared\sdkddkver.h(291,1): fatal error C1189: #error:  NTDDI_VERSION setting conflicts with _WIN32_WINNT setting [C:\Dev\vcpkg\buildtrees\python3\src\v3.7.3-1161ad7a91-Lib-Win\PCBuild\pythoncore.vcxproj]

and no other errors, ie the same as before.
So long story short: I'm pretty sure it's the same issue, as in my opinion the old issue was actually not about about a failing build of mlpack (or boost-python) due to python 2 and 3 being installed at the same time, but because the build and installation of python3 itself failed/fails.
If preferable, though, I'll gladly open a separate issue.

@ JackGoldfinch
Thanks for your so detailed info and deep investigation about this issue.
I will try it again on my local with clean environment.
Note: If this is the same issue, we continue to track this here.

Hi @JackGoldfinch
Sorry for the late reply.
I used another vcpkg repo in a clean environment to build python2 and python3 at the same time. There is no any error.
Could you please try to update vcpkg to the latest version to rebuild this? Since python3 has been updated to 3.8.3.

Yes! It's working now! Thank you very much!


Add missing properties to cosmos block header

Prerequisites

[X] I checked the documentation and made sure this feature does not already exist.
[X] I checked the existing issues to make sure this feature has not already been requested.
[X] I have read the code of conduct before creating this issue.

Problem
We are missing few block properties for cosmos block , eg proposerAddress
Ref: https://github.com/cosmos/cosmjs/blob/33271bc51cdc865cadb647a1b7ab55d873637f39/packages/tendermint-rpc/src/tendermint34/responses.ts#L279
I have raised the same issue to Subquery Network, and they implemented it in their latest release. Now we can easily integrate.
Ref: https://github.com/subquery/subql-cosmos/pull/94
Feature / Solution Acceptance Criteria

Alternatives
No response
Additional Context
No response

Hey @axshivam, thanks for raising the issue. I will look into this for you!

closed with #260


User Sign-in / Sign Out

Create a user login form using html template samples
Create a javascript file which handles the form validation
Create a view which handles sign in and sign out functionality
Create a test user, implement a test
Modify home view function as if user logged in don't show the intro area

Done


Feature: last session filesystem time

Here is an attempt at implementing the last session by using the filesystem last write time, instead of a symlink.
The symlink adds a bunch of complication about keeping it in sync, and I'm pretty syre there is a bug around deleting a session from telescope not removing the symlink. I'm also unsure how well supported these are on Windows.
The second commit in the PR serves to remove the symlink for exisiting users. We may wish to incorporate this, otherwise a symlink will persist unless the users manually remove it. I'm unsure how long this feature should remain, the alternative is to mark this as a possible breaking change and have the users clean up the symlink themselves. I'll leave this decision up to @jedrzejboczar as to how you want to manage this plugin.
There might very well be a much better way to implement this, but I found that the query module did most of what was needed already, so have just leveraged that. Please disregard any or all of this PR if there are better ways to achieve this feature. Treat this as a proof of concept.
Do note that when executing :PossessionLoad I get the following error, which might be an issue with my specific Neovim config, or it could be something I've done incorrectly in the PR.

It's also worth noting the comment in commands.lua from line 98. Because autosave might be enabled, using mtime can trigger a flip flop effect if you run :PossessionLoad multiple times; it will toggle the last two sessions. We may or may not want this. The comment suggests ways to avoid this, but this toggling effect, or not, is open for discussion.

Thanks for implementing this! Looks good to me, really nice that you used the query module to avoid code repetition.
I added file "touching" after load to update last session as you suggested and removed your comment from commands.lua. It uses libuv so it should be portable between different systems (hopefully). For this to work I had to fix implementation of autosave not to autosave if there is a current session loaded (this is the behaviour described in the documentation but it the implementation was incorrect).
I think it's good idea to clean up the unused symlink, I just changed the implementation to avoid using plenary.path to be more lazy-loading-friendly.
Regarding the error that you get - I don't seem to experience this, so it might be a problem with your configuration or something that has been fixed/introduced in Neovim nightly (depending on which Neovim versions we use, mine is NVIM v0.11.0-dev-207+g20f22f75ee).

My first implementation was a loop over the files reading the mtime via vim.uv.fs_stat. While I was working on the next feature, loading the latest session for the cwd, I found the query module and said to myself, oh, everything is pretty much already implemented here :)
I'll keep an eye on that error I'm having. I'm using 0.10.0 official release.
Thanks for your help with this.


⚠ Bofrost.fr has degraded performance

In 6e94c88, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 834 ms

Resolved: Bofrost.fr performance has improved in 86bc718 after 8 minutes.


haskell.compiler.ghc*Binary: add missing #! patch

inplace/bin/mkdirhier needs #!/bin/sh patched to run properly. This may affect other dists, too, but this is where I ran into it.
Description of changes
Attempting to build ghc8107Binary (to bootstrap default ghc) on non-nixos host was failing on release-23.11 with glibc version errors when attempting to run inplace/bin/mkdirhier during make install. This adds script in this directory (just this one really) to the patchShebang list.
I've only tested this on 8.10.7 but it does look like >= 8.10 will be similarly affected.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build haskell.compiler.ghc8102Binary haskell.compiler.ghc865Binary haskell.compiler.ghc8107Binary haskell.compiler.ghc924Binary


Error whilst reading junit-xml file in kosli-attest-junit

See https://kosli-internal.slack.com/archives/C06JZ5ZV02J/p1728622691352499

The command they are using is:
FLOW=pottspillsport-lambda-rs-bet-detail-producer
TRAIL=4652946727ba47b45f99ef8d2055518a68fad924
kosli attest junit --name unit_test --trail ${TRAIL} --flow ${FLOW} --attachments ${repo_dir}/junit.xml

I have downloaded the junit xml and created a script which runs this kosli-attest-junit command.
It succeeds.

The commands they are using are:
kosli create flow $flow_name --use-empty-template
kosli begin trail ${GITHUB_SHA} --flow ${flow_name}
kosli attest artifact --name source --artifact-type file --trail ${GITHUB_SHA} --flow ${flow_name} ${artifact_file}
kosli attest junit --name unit_test --trail ${GITHUB_SHA} --flow ${flow_name} --attachments test_report_junit/junit.xml

It is interesting that they are not providing the artifact-name nor the fingerprint on the kosli-attest-junit command.

I wanted to install previous versions of the CLI to try and replicate their error.
I tried
brew search kosli-cli@
and it says no previous versions are available.
And this is confirmed with:
brew install<EMAIL_ADDRESS>Warning: No available formula with the name<EMAIL_ADDRESS>Did you mean kosli-cli?

brew install kosli-cli
Warning: kosli-cli 2.10.18 is already installed and up-to-date.

@JonJagger it appears you cannot install an older version with brew https://www.reddit.com/r/HelixEditor/comments/1cdhdgz/comment/l1bvjo1/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
However, you can download any version directly from github

Thanks.

I downloaded the ARM tgz for the CLI 2.10.17 from github.
I copied the kosli binary to the cli/ dir
Then, from the cli/ dir I ran ./kosli
I'm getting Kosli cannot be opened because Apple cannot check it for malicious software.

I assume, you used the zip file they shared in slack. One possibility is that the files that was actually used when the error happened (potentially in CI) is modified by something before it is used.

Yes. That is looking more and more likely.
They have reported the version 2.10.12
I will try with that.

Cannot reproduce the error in 2.10.12
But I am using an ARM binary and they of course will be using an AMD binary.

Some progress. They were running the command:
kosli attest junit --name unit_test --trail ${TRAIL} --flow ${FLOW} --attachments ${repo_dir}/junit.xml
and this is using the default of --results-dir=.
and there was another xml file in the . dir (which had encoding issues).
It seems in this case they were under the impression that if you specified --attachments as an xml file in a subfolder then the Kosli CLI would use that as the input and no longer use --results-dir.
What would have helped a lot here is that when we printed the error message...
Error: xml: encoding "ISO-8859-15" declared but Decoder.CharsetReader is nil
we also printed the name of the (xml) file involved.

Put CLI diagnostic suggestions into their own issue: cli #354


pip install spark-sklearn-(version-no) doesn't work

Hi
I am looking to use best_score_ parameter from GridSearchCV function, but it looks like that is not present in the latest version of the library. When I'm trying to uninstall the latest version and reinstall and older version with the command
pip install spark-sklearn-(version-no)
It does not work. Please rectify this or refer me to a some documentation to see how I can install older versions in my cluster environments.
Thanks

That's because it's not the correct command.
Here is the correct command if you wish to install an older version :
pip install spark-sklearn==0.2.0
Nevertheless, according to the question that you have asked here, I wouldn't advise that you solve your problem this way.
If there is a 'bug' in with best_score, rather you share a reproducible example so it can be fixed. (Note that v.0.2.0 is almost 2 years old).

Thank you for your comment. I see that a bug is already opened for this issue at https://github.com/databricks/spark-sklearn/issues/73. Do you still want me to share a reproducible code for this problem?

Honestly I don't think it's necessary anymore. The problems resides which the scikit dependency lib used by the project which deprecated model_selection.

Are there any plans to update that library? Because unless that happens, the scoring and some of the other parameters cannot be used with spark-sklearn library.

Yeah, see #73 for more info. I am not sure we can set best_score_


[DROOLS-987] avoid flushing drools propagation queue out of state machine control

@mswiderski [DO NOT MERGE] 4 tests in ActivityTest are still failing

closing this one as same commit is included in https://github.com/droolsjbpm/jbpm/pull/611


Fix ik rotation issue on splines modules

need tangeantes or fk move const.

Done adding constraint from the ik_ctrls to the spine locators


Cannot find module '.../.next/server/pages/lib/worker.js'

Describe the bug
I'm trying to install and run @module-federation/nextjs-mf. When I run NEXT_PRIVATE_LOCAL_WEBPACK=true next build I get this error multiple times and crashes.
[ Federation Runtime ]: Version 18.2.0 from components of shared singleton module react/jsx-runtime does not satisfy the requirement of components which needs ^17.0.0 || ^18.0.0)
[ Federation Runtime ]: Version 18.2.0 from components of shared singleton module react/jsx-runtime does not satisfy the requirement of components which needs ^17.0.0 || ^18.0.0)
[ Federation Runtime ]: Version 18.2.0 from components of shared singleton module react/jsx-runtime does not satisfy the requirement of components which needs ^17.0.0 || ^18.0.0)
   Collecting page data  ...[ Federation Runtime ]: Version 18.2.0 from components of shared singleton module react/jsx-runtime does not satisfy the requirement of components which needs ^17.0.2 || ^18.0.0)
   Collecting page data  .
node:internal/event_target:1033
  process.nextTick(() => { throw err; });
                           ^
Error: Cannot find module '/Users/bejaouis/projects/fe-n1-nextjs/.next/server/pages/lib/worker.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:86:12)
    at MessagePort.<anonymous> (node:internal/main/worker_thread:164:24)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:757:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)
Emitted 'error' event on Worker instance at:
    at [kOnErrorMessage] (node:internal/worker:300:10)
    at [kOnMessage] (node:internal/worker:311:37)
    at MessagePort.<anonymous> (node:internal/worker:212:57)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:757:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)
    at [kOnExit] (node:internal/worker:278:5)
    at Worker.<computed>.onexit (node:internal/worker:209:20) {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v18.18.2

.
.
.
.

> Build error occurred
Error: Jest worker encountered 4 child process exceptions, exceeding retry limit
    at ChildProcessWorker.initialize (/Users/bejaouis/projects/fe-n1-nextjs/node_modules/next/dist/compiled/jest-worker/index.js:1:11580)
    at ChildProcessWorker._onExit (/Users/bejaouis/projects/fe-n1-nextjs/node_modules/next/dist/compiled/jest-worker/index.js:1:12545)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess.emit (node:domain:489:12)
    at ChildProcess._handle.onexit (node:internal/child_process:292:12) {
  type: 'WorkerError'
}
   Creating an optimized production build  .   Collecting page data  .%

Host
const nextConfig = {
  experimental: {
    middlewarePrefetch: 'strict',
  },
  output: 'standalone',
  reactStrictMode: true,
  transpilePackages: ['@mui/material'],
  i18n,
  images: {
    domains: safeEnv('NEXT_IMAGE_DOMAINS').split(','),
  },
  eslint: {
    ignoreDuringBuilds: false,
  },
  typescript: {
    ignoreBuildErrors: false,
  },
  async headers() {
    return [
      {
        source: '/:all*(woff|woff2|ico|json)',
        locale: false,
        headers: [
          {
            key: 'Cache-Control',
            value: 'public, max-age=31536000, immutable',
          },
        ],
      },
    ]
  },
  webpack(config, options) {
    //config.cache=false
    config.plugins.push(
      new NextFederationPlugin({
        name: 'components',
        filename: 'static/chunks/remoteEntry.js',
        exposes: {
          './header': './src/layouts/Header/Header.tsx',
        },
        shared: {},
      })
    )

    return config
  },
}

@module-federation/nextjs-mf: ^8.1.7
Next.js: 13.5.6
React: 18.2.0
Node.js v18.18.2
Any idea what I'm doing wrong?
Reproduction
internal_repo
Used Package Manager
npm
System Info
System:
    OS: macOS 12.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 441.55 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
    pnpm: 8.3.1 - ~/Library/pnpm/pnpm
    bun: 1.0.1 - ~/.bun/bin/bun
  Browsers:
    Chrome: 121.0.6167.85
    Chrome Canary: 123.0.6265.0
    Edge: 120.0.2210.144
    Safari: 15.6

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

Try removing async headers?
async headers() {
return [
{
source: '/:all*(woff|woff2|ico|json)',
locale: false,
headers: [
{
key: 'Cache-Control',
value: 'public, max-age=31536000, immutable',
},
],
},
]
},
Delete stuff from config till it works.

@ScriptedAlchemy is it feasible to create a private repo and give you access?


feat: add Freely

Pls also update the corresponding src/tokens/flow-mainnet.tokenlist.json file

Actually, this can be generated by running a script... I feel it's best if we update the README.


updated Dutch translations

First time trying to contribute to someone else's code, hoping I did everything right!

Thank you so much for your help with this! I have completed tokenizing KlipTok.  There are a few more entries that may require your attention


[FSunstone] User error "Restricted attribute DISK" when updating VM Template

Description
When trying to update a VM template the following error is thrown: [one.template.update] Cannot update template. Tried to change restricted attribute: DISK
To Reproduce

Create a user
Download an app from the marketplace
Try to update the app VM Template
The described error is thrown

Expected behavior
Users without special permission can edit their templates.
Details

Affected Component: FSunstone
Hypervisor: [e.g. KVM]
Version: 6.6, master

Additional context
The error was detected by trying to attach a NIC to a VM Template, It will be a good idea to verify that users can attach the NIC after the changes

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

It looks like the API call being issued by FireEdge is trying to update the DISK attribute with information that the user is not inputting at all
On a template looking like this
DISK=[
  IMAGE_ID="244" ]

issuing a template update, without altering the DISK section whatsoever, the resulting DISK ends up like this
DISK=[
  ALLOW_ORPHANS="FORMAT",
  CLONE="YES",
  CLONE_TARGET="SYSTEM",
  CLUSTER_ID="0",
  DATASTORE="default",
  DATASTORE_ID="1",
  DEV_PREFIX="vd",
  DISK_ID="0",
  DISK_SNAPSHOT_TOTAL_SIZE="0",
  DISK_TYPE="FILE",
  DRIVER="qcow2",
  FORMAT="qcow2",
  IMAGE="rocky9",
  IMAGE_ID="244",
  IMAGE_STATE="1",
  LN_TARGET="NONE",
  NAME="DISK0",
  ORIGINAL_SIZE="4096",
  READONLY="NO",
  SAVE="NO",
  SIZE="4096",
  SOURCE="/var/lib/one//datastores/1/d731fc4ee8b8c9e260c7d2755cf0ec61",
  TM_MAD="qcow2",
  TYPE="FILE" ]

The update call was issued as oneadmin, and the changes made were related to live resize attributes.

Reopening, we need to update the following guides

https://docs.opennebula.io/6.6/management_and_operations/references/template.html?highlight=restricted#restricted-attributes
https://docs.opennebula.io/6.6/management_and_operations/vm_management/vm_templates.html#preparing-vm-templates-for-end-users


Create a suitable OWNERS file in /dashboard

We should create a suitable OWNERs file in /dashboard to add approvers/reviewers.
We should explicitly list people knowledge of javascript/react because this set of folks is rather small; @wbuchwalter and @Jimexist anyone else?
This set of folks will also be different from the folks with knowledge/context about the operator. So an OWNERs file should help blunderbuss assign a better set of reviewers.
#442.

Added @jlewi @Jimexist and me as approvers, and kept the reviewer as the same set of people as the root dir OWNERS file.


Msal Angular cannot pass multiple consent scopes from different apis

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[x ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[x ] Chrome version XX
[ ] Firefox version XX
[ ] IE version XX
[ ] Edge version XX
[ ] Safari version XX

Library version

Library version: 0.1.2

## Current behavior

I am updating my web application to work with the new msal library.
The application is a frontend application written in angular 5.
It sends requests to Microsoft Graph, Dynamics CRM and my backend net core web api application.
The frontend app and backend app share the same azure ad registration app.
It is a version 1.0 app. I am currently using only the msal config, described in documentation, for login and getting access tokens and not the methods listed calling login or getting access token.
I can't pass in consent scope scopes for Microsoft graph and dynamics crm at the same time or during the login I will the message that my scopes are incorrect.
If I use only the scope for Microsoft Graph or Dynamics CRM the login is successful and there is no error about incorrect or invalid scopes.
The access token for Dynamics CRM is not generated but for Microsoft Graph is generated.
The other access token contains in his key the client id for my application so I suspect it is used for my backend api calls but its version is 2.0 and I can't use it to make calls.
For my frontend request I use the @ngx-resource/core library and during my backend web api request I get the admin consent requeired error in the ResourceHandlerHttpClient.prototype.handleResponse method and even after I sent the admin consent it is still called. Also the request passed in the method has an empty header property so I get another error when the method tries to get the header key from the property.

## Expected behavior

To be able to pass multiple scopes in consent scopes for different api and be able to get the access token, version 1.0, for each of them to successfully make requests.

## Minimal reproduction of the problem with instructions

Create a new app registration for azure ad version 1,0 app, web api/app type.
Create a new asp net core 2.0 web api.
Create a basic angular 5 application.
I use hash in routes in routing my pages.
RouterModule.forRoot(appRoutes, { useHash: true })
install @azure/msal-angular, @ngx-resource/core and @ngx-resource/handler-ngx-http.
Set up msal config, my msal config looks like this:
 MsalModule.forRoot({
            clientID: environment.AppId,
            authority: 'https://login.microsoftonline.com/' + environment.tenant,
            redirectUri: environment.frontendUrl,
            cacheLocation : 'localStorage',
            navigateToLoginRequestUrl : false,
            unprotectedResources: ['https://www.microsoft.com/en-us/'],
            popUp: false,
            protectedResourceMap: protectedResourceMap,
            consentScopes: [environment.endpoints.crmUri + '/.default', environment.endpoints.graphApiUri +  '/.default' ],
            level: LogLevel.Verbose,
            piiLoggingEnabled: true,
          })

export const protectedResourceMap: [string, string[]][] = [
    [environment.ServerBackEndUrl, [environment.endpoints.backendAudience + '/acess_as_user']],
    [environment.endpoints.crmUri, [environment.endpoints.crmUri + '/api/data/v8.2/contacts']],
     ['https://graph.microsoft.com/v1.0/me/Photos/48X48/$value', ['user.read']]
];
Create a basic page and make a request using the ngx-resource/core.
Example service:
@Injectable()
@ResourceParams({
    url:  environment.ServerBackEndUrl + '/api/version',
})
export class ExampleService extends Resource {
    @ResourceAction({
        method: ResourceRequestMethod.Get
    })
    getVersion: IResourceMethod;

    constructor(restHandler: ResourceHandler) {
        super(restHandler);
    }
}

So is it , or is it not supported:

To be able to pass multiple scopes in consent scopes (for different endpoint api) and be able to get the access token, version 1.0, for each of them to successfully make requests.

There is no error message. I don't get any response back.

@chigivigi can you make sure your scope has a double forward slash in it?  I'm not sure if your environment.endpoints.crmUri has a trailing slash or not.  For example, your scope should be https://<organization>.crm.dynamics.com//.default or https://<organization>.crm.dynamics.com//user_impersonation.

@chigivigi have you tried @bguidinger 's suggestion? Also we support 'scopes' per resource at a time for accessTokens but can pre consent at the time of signing in (idToken) only.
We have recently gone through a redesign of the library's API surface. Please download our latest preview package or pull the dev branch and try updating your code and see if the issue still persists.
Please re-open this issue if it persists. We are now throwing error stack traces so we can understand better why your code is failing.
If you would like guidance on how to use the new version of the library, please review our wiki page here.


Replace FKX token address with new address + replace FortKnoxster logo icon

FortKnoxster is a cyber-security company offering secure and private communications for all.
FKX official token details
https://fortknoxster.io/knowledge-base/fkx-token-smart-contract-address/
FortKnoxster Transfer
https://fortknoxster.com
FortKnoxster Messenger
https://fortknoxster.io
Token tracker
https://etherscan.io/token/0x16484d73ac08d2355f466d448d2b79d2039f6ebb
FKX ERC20 verified smart contract:
https://etherscan.io/address/0x16484d73ac08d2355f466d448d2b79d2039f6ebb#code
Facebook
https://www.facebook.com/FortKnoxster
Twitter
https://twitter.com/FortKnoxster
Medium
https://medium.com/fortknoxster
Telegram
https://t.me/FortKnoxster
LinkedIn
https://gi.linkedin.com/company/fortknoxster
YouTube
https://www.youtube.com/c/FortKnoxster
Instagram
https://instagram.com/fortknoxster
Reddit
https://www.reddit.com/r/FortKnoxster

Hi @wycliffkas - I would like to merge this request but there is a new requirement that the logo has to be in SVG format. Can I ask you to add it as a replacement for the PNG one? Thanks


kernel security: set nx bit on module ro segments.

This is a config setting I saw that Ubuntu uses
https://wiki.ubuntu.com/Security/Features#module-ronx

So, @alexanderkjeldaas are you willing to make this optional?
@edolstra are you against this being on by default? It seems to be conflicting with both systemtap and kpatch.

@thoughtpolice this is something you're interested in, right?

I've done some research and it seems that both systemtap and dtrace are not affected by this option. As all major Linux distributions seem to enable this I'm doing some testing and am going to merge this.


Add password verification on registration

https://dev.bukkit.org/bukkit-plugins/loginsecurity/
Adds dual password please!!! Login and register.

Yeah, that's quite useful.
Sometimes I type my password wrongly and I cannot login anymore.

What do you mean by this? Multiple passwords for the same account?

@Plazmaz /register

gud


Use external Olm

This makes updating Olm easier, and puts the responsibility for security updates of Olm itself with the user or the operating system.

As mentioned in the other thread, this change removes the build from source feature, which I won't accept.
Build from source is deliberate since it avoids the extra step of having to install and manage libolm on the system. I appreciate there are different views here, I think there is room for more than one gem.


Pack fails in github actions when building packaging windows release on UbuntuLatest runner

I'm using nuke.build to run the vpk cli. When executing in a github action I'm getting the following error
[12:44:22 INF] Velopack CLI 0.0.462-gf8acc97 (prerelease), for distributing applications.
     [12:44:23 WRN] There is a newer version of vpk available. Run 'dotnet tool update -g vpk --version 0.0.474-gb9d73fc'
     [12:44:23 INF] Beginning to package Velopack release 0.0.1.
     [12:44:23 INF] Releases Directory: /home/runner/work/tasktitan/tasktitan/release/win-x64
     [12:44:23 INF] Starting: Pre-process steps
     [12:44:23 INF] Building new .AppDir
     [12:44:23 INF] Complete: Pre-process steps
     [12:44:23 INF] Starting: Building portable package
     [12:44:23 FTL] Command LinuxPackCommand had an exception.
     System.ArgumentException: Given stream is not a proper ELF file.
        at ELFSharp.ELF.ELFReader.Load(Stream stream, Boolean shouldOwnStream)
        at ELFSharp.ELF.ELFReader.Load(String fileName)
        at Velopack.Packaging.Unix.Commands.LinuxPackCommandRunner.GetMachineForBinary(String path) in ./Velopack.Packaging.Unix/Commands/LinuxPackCommandRunner.cs:line 109
        at Velopack.Packaging.Unix.Commands.LinuxPackCommandRunner.CreatePortablePackage(Action`1 progress, String packDir, String outputPath) in ./Velopack.Packaging.Unix/Commands/LinuxPackCommandRunner.cs:line [98](https://github.com/henry-js/tasktitan/actions/runs/9128413386/job/25100713752#step:4:104)
        at Velopack.Packaging.PackageBuilder`1.<>c__DisplayClass35_0.<<Run>b__4>d.MoveNext() in ./Velopack.Packaging/PackageBuilder.cs:line 125
     --- End of stack trace from previous location ---
        at Velopack.Vpk.Logging.BasicConsole.Progress.RunTask(String name, Func`2 fn) in ./Velopack.Vpk/Logging/BasicConsole.cs:line 58
        at Velopack.Packaging.PackageBuilder`1.<>c__DisplayClass35_0.<<Run>b__1>d.MoveNext() in ./Velopack.Packaging/PackageBuilder.cs:line 130
     --- End of stack trace from previous location ---
        at Velopack.Vpk.Logging.BasicConsole.ExecuteProgressAsync(Func`2 action) in ./Velopack.Vpk/Logging/BasicConsole.cs:line 24
        at Velopack.Packaging.PackageBuilder`1.Run(T options) in ./Velopack.Packaging/PackageBuilder.cs:line [107](https://github.com/henry-js/tasktitan/actions/runs/9128413386/job/25100713752#step:4:113)
        at Velopack.Vpk.ProgramCommandExtensions.<>c__DisplayClass3_0`2.<<Add>b__0>d.MoveNext() in ./Velopack.Vpk/Program.cs:line 206

     at Nuke.Common.Tooling.ProcessExtensions.AssertZeroExitCode(IProcess process) in /_/source/Nuke.Tooling/ProcessExtensions.cs:line 39
     at Nuke.Common.Tooling.ProcessTasks.DefaultExitHandler(ToolSettings toolSettings, IProcess process) in /_/source/Nuke.Tooling/ProcessTasks.cs:line 257
     at Nuke.Common.Tooling.ToolExecutor.<>c.<Execute>b__2_0(IProcess p) in /_/source/Nuke.Tooling/ToolExecutor.cs:line 63
     at Nuke.Common.Tooling.ToolExecutor.Execute(ArgumentStringHandler arguments, String workingDirectory, IReadOnlyDictionary`2 environmentVariables, Nullable`1 timeout, Nullable`1 logOutput, Nullable`1 logInvocation, Action`2 logger, Action`1 exitHandler) in /_/source/Nuke.Tooling/ToolExecutor.cs:line 63
     at Build.<get_Release>b__35_2() in /home/runner/work/tasktitan/tasktitan/build/Build.cs:line 157
     at Nuke.Common.Execution.BuildExecutor.<>c.<Execute>b__4_2(Action x) in /_/source/Nuke.Build/Execution/BuildExecutor.cs:line 119
     at System.Collections.Generic.List`1.ForEach(Action`1 action)
     at Nuke.Common.Execution.BuildExecutor.Execute(NukeBuild build, ExecutableTarget target, IReadOnlyCollection`1 previouslyExecutedTargets, Boolean failureMode) in /_/source/Nuke.Build/Execution/BuildExecutor.cs:line [119](https://github.com/henry-js/tasktitan/actions/runs/9128413386/job/25100713752#step:4:125)

Can I not build windows installers on Linux?

At the moment this is not supported, please see https://github.com/velopack/velopack/issues/18


Request/Suggestions : saving ability enhancement for new community made Mod Character support (Current discussion: Myst)

Hi,
Disclaimer:
This is a suggestion or request or something like a information. Whether is seem as something to be implemented or not is solely based on the intention of propersave mod creator. As this features are pretty much additional and is not part of the actual support for the original game.
Let's begin, currently the mod is at vers 2.9.0 if I'm not mistaken. Currently the mod works perfectly and allow redefine save file location etc.
What current mod is unable to do is saving something that applies to totally custom-made character. For current suggestion, support for Myst skill number 3 and 4, and/or inclusion of the skill screen after pressing of number '4' keyboard.
At this current moment, skill 3 and 4 is not save. Thus it will act as expected, loading up with no skill even if previously have acquired any skill.
This is just an suggestion/information for thought.
Think it may be too annoying to implement, or save file might end up saving something that is not needed.
Might even effect someone that do not have Myst character mode to save something unnecessary into their save file. Unneeded amount of save data size probably is not everyone favorite.
This, this is only something for thought. Thank you for taking your time for reading. (/･ω･(-ω-)

Hi, ProperSave itself will be only supporting vanilla. However it has public events that other mods can use to save/load whatever info they need, everything is described in the readme. This can be done by the character mod itself, or even a separate mod.


add google analytics

Hmm, maybe some individual gulp task should take of case of this ? eg. using https://www.npmjs.com/package/gulp-ga

It'll be better if the ID is configurable from project.config.ts. You can use the underscore (lodash) template syntax.

I added a comment. Let's change Google_Analytics_ID to GOOGLE_ANALYTICS_ID.

pls comment it out, i think its a bad idea, i always have to delete those lines

had to delete it 3 times in the last month

If you do not use it can be ignored directly.

thats not true, it makes at least two http requests to google servers by default:
:authority:www.google-analytics.com
:method:GET
:path:/analytics.js
:scheme:https
accept:*/*
accept-encoding:gzip, deflate, sdch, br
accept-language:en-US,en;q=0.8,de;q=0.6
cache-control:no-cache
pragma:no-cache
referer:http://localhost:5555/
user-agent: XXXXXX

and
https://www.google-analytics.com/collect?XXXXXX


Clearer Slackbot error messages

Feels we could at least mention when it's the underlying model being flaky?

Task under-specified and stale. closing


Runner time limit

Is there a way to set a time limit on runners - for example if a job gets stuck the cost can be high - would be nice to be able to terminate a runner after x hours.

@7adamf the default global timeout is 12h (the instance will auto-shutdown after that time), but currently there is no way to override it. For your use-case, would you like an override at the stack level (i.e. for all runners), or at the runner level, with an additional runs-on: label?

Yes that would work great if possible!

I think this is a case where stack-level and label-level overrides are both valuable, but I suspect they'd be used a bit differently.

at the stack level feels like a safety measure, and 12h seems like a very reasonable default. I imagine this would be overridden to increase the limit, for orgs that have particularly long running things like soak tests.
at the label level, on the other hand, I'd expect this to be used more to reduce the limits, for jobs with expected short durations. For instance, if rendering some markdown files to static HTML takes more than an hour, something has probably gone horribly wrong (or you have a terrifying amount of markdown).

🤔

Makes sense. Just trying to find a way to not duplicate existing attributes in workflows / add too many labels. GitHub already has timeout-minutes so ideally RunsOn would be able to infer the job timeout from that attribute if specified.


publish new tagged releases

As discussed in https://github.com/hdl/conda-eda/pull/228#issuecomment-1201078808, we'd need to get releases tagged in order to publish an OpenROAD to https://conda-forge.org/.
Latest tag https://github.com/The-OpenROAD-Project/OpenROAD/tree/v2.0 is ~1yo, would it be possible to get another release tagged.
Alternatively the project could use a strategy similar to https://github.com/chipsalliance/verible/blob/master/.github/workflows/verible-ci.yml#L340 to get version tagged on every commit.
Let me know what you think.

Why can't you use a commit id?    Not to mention tags can be moved so it is less stable than a commit id.

@maliberty conda-forge automation (as many other packaging system tend to do) relies on tagged release for referencing and updating upstream tarballs, see:
https://conda-forge.org/docs/maintainer/adding_pkgs.html#maintainer-role
https://conda-forge.org/docs/maintainer/updating_pkgs.html#how-does-regro-cf-autotick-bot-create-automatic-version-updates
I agree that automated tagging is not ideal for a mature project, as, if not careful implemented, it can loose some of the semantic around the versioning of the repo. I believe verible use it because they are still < 1.0 and are basically implementing https://semver.org/#spec-item-4:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

Based on the release history, I can spot a few patterns currently being used for versioning OpenROAD:
https://github.com/The-OpenROAD-Project/OpenROAD/tags

tag
date
commit

v2.0
Jul 17, 2021
a5a5658

2021_03_09_stable
Mar 10, 2021
0f5a83c

v1.0rc2
Oct 17, 2020
c30c26e

v0.9.0-beta
Jul 7, 2020
2f8a74e

1-2  releases per year
Only major release v0 -> v1 -> v2, or dated version for specific occasion

Assuming this is consistent I have a few questions:

Will the next tagged version of OpenROAD will be v3.0? If yes, do you have an idea yet of what the feature sets/issues to be fixed are to reach it? (maybe creating a GitHub milestone would be handy).
Can we get a (minor?) including a subset of the changes v2.0 and master (4632 commits) so that we can make progress on the packaging effort?

The only pattern is that we are obliged by contract to have certain releases.   We don't really have formal releases in general and follow @mithro advice to keep everyone at head.
We can add a specific tag for testing but setting up a tag based methodology isn't a good long term strategy.  We don't intend to support those tags if there are problems by anything other than telling someone to move to head.

You can build from a tarball so can you use something like https://github.com/The-OpenROAD-Project/OpenROAD/tarball/4a99e88667b0840531ca0096c4fa0da8f80d6cb1 ?

https://conda-forge.org/docs/maintainer/adding_pkgs.html#tarballs-no-repos

Yep, but as hinted my earlier comment conda-forge (and other packaging system) requires/strongly suggest that those tarballs comes from tagged release.
A few of the reasons could be that:

intermediate commit are often considered unstable
releases w/ changelog are the standard way to convey distribution readiness in the wider software community
automation for bumping version in recipe and generating new package versions are based on those releases metadata

Keeping everyone at HEAD sounds like a valid strategy if everyone is building from source, but having some form of release/versioning is desirable if we want to ease redistribution of OpenROAD in various packaging system.

Tagging every commit is not a recipe for stability.  Google explicitly shot down the idea of versioned releases previously when I proposed it.  Please coordinate with @mithro on a unified stance.  I believe we've had this same conversation before...

Tagging every commit is not a recipe for stability. Google explicitly shot down the idea of versioned releases previously when I proposed it.

Sorry if I gave this impression, but I didn't meant to push for one versioning strategy over the other. Each projects have differents cycles of stability, and it's ultimatly the decision of the project maintainers find a release cycle and versioning strategy that better fit the expectation they want to set for their user base.
I'm mainly interested to find out if there is a desire from the project maintainers to find "one versioning strategy" that can make the packaging story for OpenROAD across different packaging system/distribution easier (like we're currently discussing w/ potential contributors in https://github.com/hdl/conda-eda/pull/228#issuecomment-1214471947).

Google explicitly shot down the idea of versioned releases previously when I proposed it. Please coordinate with @mithro on a unified stance. I believe we've had this same conversation before...

@mithro should be free to jump in here too, I'm just one extra data point and I'm not convinced an unified stance is a strict prior requirements to have this conversation in the open.
I could only find this one issue https://github.com/The-OpenROAD-Project/OpenROAD/issues/205 discussing a similar need in the project history, maybe other packagers could also comment on how versioning strategies impacts their effort to package and redistribute OpenROAD?

@sequencer for Arch
@cbalint13 for Fedora
@trepetti for NixOS
@rubund for Debian/Ubuntu (OpenSTA)

For nixpkgs, I originally packaged it at 2.0 and assumed there would be semver releases, but just recently, it became clear that this style of release had been dropped, so the package now uses the unstable-yyyy-mm-dd format. I am hoping to make a bot to take monthly snapshots eventually to automate this depending on CI status. If there is a bug that is fixed in at HEAD but not in the package cache, versioning can be overridden programmatically by Nix users if they have the commit ID and the SHA256 hash for the tarball. This way, the project can be tracked pretty closely, and there will always be a reasonably recent binary in the cache in the absence of formal releases.

Not part of the official team: The two tagged releases were done to satisfy a contract requirement, and did not signal a decision around versioning.

I am hoping to make a bot to take monthly snapshots eventually to automate this depending on CI status.

Maybe we could have this as a shared infrastructure that all packagers could leverage?

@proppy Most likely it will be Nix-specific but open, yes. For the next several releases, I will do it manual for the next several version bumps, most likely.

@trepetti I've started setting up something in my fork that run weekly https://github.com/proppy/OpenROAD/tags.
https://github.com/proppy/OpenROAD/blob/sync/.github/workflows/github-actions-cron-release-from-head.yml
Maybe we could run this in a shared project instead w/ some additional QA to vet the upstream tarball before tagging?

I'd also love it hear from @maliberty (w/ input from @QuantamHD and @mithro) if they think that something like https://en.wikipedia.org/wiki/Rolling_release could be more appropriate releasing strategy for the project, and if yes at which frequency (weekly? monthly? daily?).

I'm not clear from the links as to what exactly is requested.  Is a rolling release just whenever the tests pass or something more?  Is  there any expectation of a fix to a rolling release that is not just at the current head?  To the degree that this is all automatic and of minimal impact I am agnostic.

Is a rolling release just whenever the tests pass or something more?

Yes pretty much, you'd need to decide on two things:

the cadence of the release (daily, weekly, bi-weekly, monthly?)
the tests required to validate the release (what's in test/*, https://github.com/The-OpenROAD-Project/OpenLane-MPW-CI, more?)

Is there any expectation of a fix to a rolling release that is not just at the current head?

You could explicit set the expection that bugs fixed at HEAD are (by virtue of the process) to be included in "next rolling release".

Also OpenROAD-flow-scripts-Nightly-Public and OpenROAD-public.
Is this fully automatable?  If so I don't care what the frequency is.  If not I would pick the longest period possible.

Is this fully automatable?

Yep, I started something at in my fork at https://github.com/proppy/OpenROAD/blob/sync/.github/workflows/github-actions-cron-release-from-head.yml and sync the tree from upstream at a given frequency and cut a new tag if it doesn't already exist for that commit.
I was thinking of proceeding this way:

[ ] add steps to query the Jenkins status for the current commit being considered for tagging
[ ] let it run for a few days to create a few release in my fork
[ ] send a PR against the https://github.com/The-OpenROAD-Project/OpenROAD to integrate it w/ the rest of .github/workflows

If so I don't care what the frequency is. If not I would pick the longest period possible.

@trepetti what would be the ideal frequency for nixpkgs? I'm tempted to think weekly could be a good first pick; we can always adjust the frequency depending of each distribution needs as the tag get actually used.

https://github.com/Precision-Innovations/OpenROAD/releases has maintaining the tags by latest.

@vijayank88 thanks for pointing this out! Do you plan to also populate the tag on this repo?

@proppy
I don't have information  on your question. Maybe @maliberty have?

Those 'releases' are just nightly builds.  GH just provide releases as the mechanism for distribution.  We don't make any guarantee of stability.
There is no plan to tag them for all the reasons discussed above.

I can send a PR for an automatic release drafter, similar to the one we use in gdsfactory

filed https://github.com/berkeley-abc/abc/issues/267 and https://github.com/The-OpenROAD-Project/OpenSTA/issues/208

@vijayank88 it would be nice for the tarball at https://github.com/Precision-Innovations/OpenROAD/releases to include the source for abc and OpenSTA in order to make the build more easily reproducible.

@vijayank88 doesn't produce those builds - @vvbandeira would be the right person to help.  That said those are submodules so you can easily do an init to get the code.

you can easily do an init to get the code.

sadly GitHub release tarballs don't include git metadata nor information, see: https://github.com/dear-github/dear-github/issues/214

Is there any GH mechanism to do what you want?

You can get GitHub release tarballs to include git information this way -> https://github.com/YosysHQ/yosys/pull/3138/files


Fix error message to display message specific to the index

Before, entering a negative integer will result in the command usage being displayed. After this change, entering a negative integer will instead result in the message "Index is not a non-zero unsigned integer." being displayed. Entering a positive integer that is out of bounds of the client list will display the more specific message, "The client index provided could not be found in the list of clients."

Codecov Report
Base: 59.96% // Head: 59.91% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (818a01f) compared to base (d6ab36e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
- Coverage     59.96%   59.91%   -0.06%
  Complexity      621      621
============================================
  Files           113      113
  Lines          2268     2265       -3
  Branches        254      254
============================================
- Hits           1360     1357       -3
  Misses          823      823
  Partials         85       85

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

.../address/logic/parser/ViewClientCommandParser.java
88.88% <100.00%> (-2.78%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

#156


[FIX] Changes in the md view of card in the dev tools section

Description
Major change
I encountered a design issue in the dev tools components section.
This happens when it reaches the condition min width - 768px.
Minor change
Anchor tags in the footer section should be changed to the Link for page optimizing stuff.
Li tags should be placed in the Navbar section.
Expected Behavior

Actual Behavior

I have added pr for this respective issue

For this issue the corresponding pr for this fix is fix: minor layout and link issues #161

/attempt #160