Bug in wiring diagram for I2S sample

There is a bug in the wiring diagram for the I2S sample. The I2C pull-up resistors should be connected to 3.3V (as described in the README), however, the wiring diagram has the pull-ups connected to the 5V pin of the MT3620 dev board.

Thank you! I'd missed this one in the cleanup the other week.


Send search request to Algolia with some delay

🚀 Feature
Now a new search request is sending to Aloglia on each query change. I want to reduce the number of requests to Aloglia. It would be nice if Docusarus will have some delay option n config. If the delay is set, the request will be sent if the user is not printing. Without delay in the config, the search behavior will be the same as now.
Have you read the Contributing Guidelines on issues?
Yes.
Motivation
This feature can reduce the number of requests to Algolia, and therefore reduce the costs of search.
API Design
Add new option to Algolia search plugin config. If the delay is set search query will be sent only after a user stops inputting the query. I assume that desired behavior can be easily achieved by React hooks. There is an example on StackOverflow: https://stackoverflow.com/questions/53071774/reactjs-delay-onchange-while-typing
Have you tried building it?
Unfortunately, I'm not a react developer, so I can't build it myself.

The search modal is a react component provided by Algolia on which we don't have control, but we allow to customize it through props.
It's unlikely Docusaurus will handle that throttle/deboucing logic.
You'd rather ask the Algolia DocSearch team: if they implement this feature (maybe it already exists?), then Docusaurus will be able to use it by passing extra config options.
ping @shortcuts

Algolia has been already supported this feature. It's named seacrhAsYouType.
https://www.algolia.com/doc/api-reference/widgets/search-box/js/

Can you add extra config options for it?

Hey @Markeli,
I've attached a sandbox to the body of this PR, which will help you to implement a debounced search method.
(Need confirmation from @slorber) You should be able to add the transformSearchClient option to your docusaurus config, which will forward the logic to the DocSearch component

Thanks @shortcuts
Not sure how this works exactly but we already forward props to the React component exported as @docsearch/react/modal
However this prop was already provided by @francoischalifour:
  const transformSearchClient = useCallback(
    (searchClient) => {
      searchClient.addAlgoliaAgent(
        'docusaurus',
        siteMetadata.docusaurusVersion,
      );

      return searchClient;
    },
    [siteMetadata.docusaurusVersion],
  );

And it's code that runs in the browser so it's not possible to pass a fn to the browser through Docusaurus config file. If this is the only exposed API, this means Docusaurus users will have to swizzle the component and override the existing transformSearchClient. It's not ideal but can be good enough, considering this usecase is not common. It would be simpler if the component accepted a serializable prop like transformAsYouType={false}

@slorber The current docs suggest that all algolia options are supported by the docusaurus config:
https://docusaurus.io/docs/search#customizing-the-algolia-search-behavior
It took me a while to figure out what you wrote above, that functions (transformSearchClient) cannot be passed from the config, and also that the component does not allow all the listed options (placeholder for example). We ended up swizzling the component but at least it would be great to fix the docs and mention which props are actually supported (or which ones are not).

@xixixao it's not possible to provide any callback from Docusaurus config to the client-side JavaScript.
If you want to allow passing transformSearchClient you'd have to swizzle anyway.
If you want to make it easier (just wrapping instead of ejecting), I would be happy to accept a similar PR as this one: https://github.com/facebook/docusaurus/pull/8462

From what I see, we could easily allow to pass a placeholder, it's just we should apply the {...props} spread after those props.

Do you want to submit a PR?


Roadmap

I'd like to see a roadmap/goals/features list to have the project on track for contributions.

On my short list: automatic ports, subnets
Longer term - I am hoping for feedback from the FBP community!


Update release notes for the UWP 5.x releases for March 2019

UWP 5.2.9
UWP 5.3.10
UWP 5.4.7

@HollyAM can you merge if this looks good?


docs: update android setup with react native 0.71

Description

This pull request addresses the issue described here: #<?>

In this pull request, I have updates the docs for android setup with react native 71

For features/enhancements:

[x] I have added/updated the relevant references in the documentation files.

For API changes:

[x] I have made the necessary changes in the types index file.

We have known issues with SDK v33 (so can't recommend it in the docs) and are not officially compliant with RN v0.71 yet.
I have to close this in favor of #3884, which we will get to sometime in Q2.


ReadMe file is incorrect on some steps

When adding a bot to a server in the discord section is incorrect with some of the settings you need to choose. Read me file can also look nicer

Resloved. The ReadMe file is now up to date and accurate.


glfwPostEmptyEvent sometimes fails to unblock glfwWaitEvents on Ubuntu 18.04

From times to times, the empty event posted by a call to glfwPostEmptyEvent won't unblock a call to glfwWaitEvent in the main thread.
A minimal program reproducing the issue is available here
It can be built and run on linux like so:
g++ main.cpp -std=c++14 -lglfw -lX11 -ldl -lpthread && ./a.out
If the calls of glfwPostEmptyEvent and glfwWaitEvent don't overlap in time, then the bug will never happen, but if the 2 calls are concurrent, the bug happens, "sometimes".
Note that on OSX, this bug never happens.
GLFW Version (from glfwGetVersionString()):
3.2.1 X11 GLX EGL clock_gettime /dev/js Xf86vm shared
Ubuntu version
18.04 LTS

Note that I have tried posting "several" empty events at the same time: it doesn't help either, it just makes the bug a little less reproducible but doesnt fix it entirely.

Edit : added the build command
Edit2 : fixed the build command

The bug also exists with the latest version of the master branch

I also tried to fix the bug by changing the implementations of glfwPostEmptyEvent and glfwWaitEvents for X11, but could only make the bug "lees frequent", so it's not a solution.
My workaround sofar is to systematically post a second empty event, one millisecond after the first one, to have the guarantee that the freeze will not exceed a millisecond when it happens.

Wouldn't the fix be simply to use a mutex either wrapping your calls to glfwPostEmptyEvent() and glfwWaitEvents() or add a mutex to glfw itself (which may not be appropriate since glfw does not depend on ptthreads, IIRC)

@kovidgoyal if I wrap my calls to glfwPostEmptyEvent() and glfwWaitEvents() in a mutex, I won't be able, ever, to wake up the thread that made the glfwWaitEvents() call by calling glfwPostEmptyEvent() from another thread, because ... of the mutex :) so it's not a solution.
Using a mutex at a finer level inside glfw is an approach that could work, my first attempt was not conclusive, but there might be a possible solution there. Do you want to give it a try?

Oh yeah, sorry, I wasn't paying much attention to the context :) Thinking about it some more, I dont think this will work, or at least, one needs to understand the root cause of the failure first. What is happening to the events sent by XSendEvent? Why aren't they being picked up by XNextEvent?

with the i3 window manager, it freezes before starting the test

Can you add logs to the test program to see where it freezes?
If I run your program on my system, it works fine, so that shows that we need a window to reproduce the problem.

It freezes on the window creation step, basically glfwCreateWindow() never returns
If you need a window to reproduce it, it means something on your system is interfering with event handling, probably accessing the X event queue itself. Some kind of plugin that hooks into all processes? Ubuntu is notorious for those.

It freezes on the window creation step, basically glfwCreateWindow() never returns

I think I'm using "the standard way" of creating a glfw window, so I'm surprised that it doesn't work for you.

I can reproduce with your example, by adding glfwWindowHint(GLFW_VISIBLE, false);
before the call to the window creation step.

I don't see why this call is necessary, it seems to me it's an unrelated issue (an issue nonetheless).

If you need a window to reproduce it, it means something on your system is interfering with event handling, probably accessing the X event queue itself. Some kind of plugin that hooks into all processes? Ubuntu is notorious for those.

The window itself probably needs the X event queue, for mouse events, resize events, etc... so I'm not surprised that having or not having a window can make a difference.

The reason the window is needed is because of line 1115 in window.c Basically glfwpostemptyevent is a no-op when no windows are present. I dont know why that is the case, probably needed by some other backend.

one needs to understand the root cause of the failure first. What is happening to the events sent by XSendEvent? Why aren't they being picked up by XNextEvent?

Let me explain what I understood about "what can be the root cause" :
I think the problem is that to wait for events, we use select (see the comment on top of waitForEvent in x11_window.c) instead of using X-related functions.
X-related functions use the display-lock when necessary to avoid race conditions, but select doesn't.

That should be easy to check, just replace the implementation of waitForEvent with XEventsQueued see if that fixes it.

Using XPeekEvent instead of the select does indeed fix the issue on my system

And this commit is the one that introduced the use of select, as best as I can tell: https://github.com/glfw/glfw/commit/eb7688df8f851b2a21047f757096b500ded34e48
I dont see any good way to fix this. As far as I can tell, you cannot both be lock free and avoid race conditions. I dont know why it is important to be able to use GLX calls from another thread, OpenGL calls, sure, but GLX?

CPU consumption would be awful with that. The other possibility is to use a dedicated extra fd pair. Have the select call wait on that as well and have the postemptyevent function write to it.

so XPending() + sched_yield() works (the race condition is solved), we are lock-free (i.e one can take the display lock when we release it), but the problem is we use 100%cpu! we could use usleep(...) instead of sched_yield() but that would increase latency...

I dont know why it is important to be able to use GLX calls from another thread, OpenGL calls, sure, but GLX?

I have no idea

See my previous post.

The other possibility is to use a dedicated extra fd pair. Have the select call wait on that as well and have the postemptyevent function write to it.

Sounds good

I'm happy to implement that in my glfw fork (and switch to using poll as well instead of select) since this issue could affect me, though I have not seen it in the wild so far. However you'll need to get buy in from @elmindreda if you want to get the fix merged here.

Thanks, it would be great! If you want I can cherrypick your commit to propose a merge here afterwards (or did you intend to merge your fork?).
Just to give some context, in my games I use event-driven loops : no rendering happens until an event (coming from the server, or from the platform) occurs. I'm not sure I would have noticed this bug had I used a time-based loop where every 10 milli seconds a render occurs...

I use an event based loop as well, isn't that what everybody uses? Why would you render repeatedly if nothing has happened? As for merging my fork, it seems unlikely at this point. It has pretty much diverged since #1140 and tons f other bug fixes/enhancements.
Feel free to cherry pick and propose a merge, I have no objections.

I should have added this to the context description : in my case, I also have different sources of events : glfw events (which I listen to on the main thread), and server events (which are listened to on another thread). If the server event arrives before the glfw event, then to continue on the main thread I need to wakeup the glfw wait function (glfwWaitEvents) using glfwPostEmptyEvent.
Hence, this bug becomes very visible :)

Yeah same architecture for me (in my case there are two secondary threads listening for server events and events from child processes), but I've never run into this in the wild and kitty (my project that uses glfw) has been out in the wild for almost two years now.
But anyway, I agree with your point, this is a potentially bad bug and should be fixed.

IMO, https://github.com/kovidgoyal/kitty/issues/426 may be related to this. Quoting the last comment:

They stay that way, until I do something to snap them out of it. Switching desktops or sometimes even just pressing shift (!) seems to do it, or just moving the mouse

This is the same behaviour I saw in my games : if I moved the mouse or pressed a key, then that would wake up the glfwWaitEvents call.
But I might be wrong.

Seems unlikely this would cause high cpu usage, though. But, with threading bugs, who knows :)

I was wondering that too, maybe it's just that one empty event post is missing somewhere in the code (I guess it's hard to debug without having a repro case...)

I have committed a fix. Your test case passes and kitty seems to be unaffected by it, fee, free to review.

Cool! I'm looking at it

I made a comment on the commit, and also, what about using ppoll instead of poll which has a better time precision ?

I dont know how portable ppoll is

I was just wondering if that would be seen as a regression wrt select time resolution. I think to be sure we need to benchmark, to see what the implications are... but as a first approximation it should work. I made another comment on the new commit, to simplify the code, you might want to check it out.

I;ve never come across a need for sub-millisecond timeouts. For example, QTimer from Qt uses millisecond resolution timers. And glfw itself makes no guarantees about timer resolution. The wayland backend uses milliseconds as well.

Another thought, what happens if we repeateadly call glfwPostEmptyEvent, without calling glfwPollEvents or glfwWait***Events : at some point the self pipe will overflow? block? crash?

Its non-blocking, so the writes will simply fail. The write failure is ignored, so it is harmless.

@kovidgoyal yes, retrying the write could be nice, if someone uses signals

Done. And just for completeness, here is my analysis of the root cause:
basically, depending on the exact timing of the calls, it can happen that Xlib on the GUI thread reads data of the fd and stores it in its internal cache, which causes the select() to block, even though the other thread has sent an event that the main thread does not yet see.
This is fundamentally because of the bad (or perhaps more correct ancient) design of Xlib. it really is is not made for multiplexed I/O

I was going to open a PR, and did some benchmarks first:
on Ubuntu / X11 (this is the scope of the fix):

current implementation where we use select to wait with timeout:

glfwWaitEventsTimeout has a precision of 80 micro-seconds

with the fix, where we use poll to wait with timeout:

glfwWaitEventsTimeout has a precision of 1100 micro-seconds

To me, as a user of the library, this change sounds like bad news. Of course, the games I develop will continue to run with the decreased precision, but the timing we be a little more "off".
@kovidgoyal do you think it's possible to do the same idea but with select? what are the disadvantages of select that made you chose poll? I don't mind doing the implementation with select.
Also, for completeness, I will benchmark with ppoll

Just google select vs poll. Basically select becomes highly inefficient if the fd number of one of the monitored fds happens to be high.

So the benchmark of glfwWaitEventsTimeout with ppoll is similar to what happens for select : 80micro second precision, except that below that, it stays at 80, instead of dropping to 0 for select.
The problem is that it seems less portable than other functions so we can't really use that...

And note that the wayland backend use poll() anyway. Which reminds me that this fix probably needs to be ported to the wayland backend as well.

And on OSX, the precision of glfwWaitEventsTimeout is also in the 80 micros. So I didn't test with wayland but it seems it would currently be 1 millisecond then? Maybe we can see that as a bug and fix it by using select instead?

Note that to do the benchmarks I use https://github.com/OlivierSohn/repro-evt/blob/master/timeout.cpp

As far as i can see, ppoll is available on linux and freebsd and openbsd and on netbsd under the name pollts, so it's probably fine to use it. But as I dont need sub-millisecond timers, I'm not particularly motivated to make that change.

I did the change, it's working, the only thing is I have a compilation warning because the function is not found in the header <poll.h>, i tried to fix it by passing -D_GNU_SOURCE but it failed. I'll look into it a bit more then, thanks for doing the research on portability!

On 7 juin 2018, at 20:01, Kovid Goyal<EMAIL_ADDRESS>wrote:
As far as i can see, ppoll is available on linux and freebsd and openbsd and on netbsd under the name pollts, so it's probably fine to use it. But as I dont need sub-millisecond timers, I'm not particularly motivated to make that change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Never mind, I made the change.

Btw, regarding the availability of ppoll it would be nice if we can document from which version of the different OSes it is available? I'll try to do my research on that...
Also, did you intentionally leave the non-timeout call using poll? I was thinking that we can use ppoll here too, to be consistent with the timeout case (passing NULL instead of -1 for the time indicates "waiting forever").

Your test case was failing on wayland as well, so I ported the fix to the wayland backend and cleaned it up a little removing the externs and using pipe2, since pipe2 is available everywhere that ppoll is available.
Please review.

See my previous comment :)

I also made a new comment on the last commit.

@kovidgoyal  It's hard to follow comments on commits, so I'll write it here (ideally we should discuss this on a PR):

I think there is some code that could be factored between the x11 and wayland backends, especially in the new code. One way to share the code would be to write functions in a source file, that we #include in both backends. This way, when we make a change / review other people's code, we don't have to double check everything, which is error-prone. For example the deinitialization code now has 2 different behaviours and there is no way to know if it's because something was forgotten to be changed or because it was intended to be this way. (see next point)
in one of the 2 backends, the pipes fd are closed only if the display is not null, is it intentional? If so, please add a comment saying why.

I'll take a shot at refactoring the code to use more functions to encapsulate the code, and to share code between backends.

That's a lot of detective work, thank you! :purple_heart:
I'm currently finishing Windows 10 per-monitor v2 DPI support. Will have a proper look at this as soon as I'm able. PR noted.
The GLX call that's expected on non-main threads is glXSwapBuffers.

@elmindreda you're welcome, I wanted to get to the bottom of this bug to see what was going on exactly, eventhough I had a working workaround...

Just FYI, I greatly cleaned up the implementation of this in my fork. The X11/Wayland event loops now support watching an arbitrary number of fds as well as an arbitrary number of timers. This was needed to integrate DBUS into the event loops which in turn was needed for IME support #41

@kovidgoyal could you please point out the relevant commits in your fork? I'd like to have an idea of what the incremental changes are, if we want to report the changes here. Thanks!

There is only one commit in my fork, the latest https://github.com/kovidgoyal/glfw/commit/f4b72f2492d250816775a7ce8dc2ab89637eacb4
If you want to see the code under development look at the commits under the glfw sub-directory of kitty.

Thanks. imo it's a change that should not be part of this particular issue. But it might be relevant for other issues or features.

I wonder if I'm running into this issue.  I'm running glfw on wayland, and once in awhile my program randomly freezes.  Attaching with gdb shows this backtrace:
#0  __cp_end () at src/thread/x86_64/syscall_cp.s:29
#1  0x00007fafcbcacc6d in __syscall_cp_c (nr=0, u=8, v=140721514594888, w=<optimized out>,
    x=<optimized out>, y=<optimized out>, z=0) at src/thread/pthread_cancel.c:33
#2  0x00007fafcbcb2b16 in read (fd=<optimized out>, buf=<optimized out>, count=<optimized out>)
    at src/unistd/read.c:6
#3  0x000055777d5240c8 in handleEvents ()
#4  0x000055777d524c8e in _glfwPlatformPollEvents ()
#5  0x000055777d51d825 in glfwPollEvents ()
#6  0x000055777d4fbb18 in opengl_ui_handle_input (ctx=0x7fafcbc4bde0, km=0x7ffc47e3c388,
    hf=0x7fafcbc4bc80) at ../client/ui/opengl/ui.c:125
#7  0x000055777d4ee559 in ui_handle_input (ctx=0x7fafcbc4bda0, km=0x7ffc47e3c388,
    hf=0x7fafcbc4bc80) at ../client/ui/common.c:82
#8  0x000055777d4eda24 in main (argc=3, argv=0x7ffc47e3eb78) at ../client/main.c:65


Swap from master to develop branch for badges

Since we don't really use the master branch.

Pull Request Test Coverage Report for Build 544

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 86.866%

Files with Coverage Reduction
New Missed Lines
%

brigade/core/init.py
5
85.05%

Totals

Change from base Build 540:
-0.5%

Covered Lines:
873

Relevant Lines:
1005

💛  - Coveralls


Sentiment your workbook

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 23f4be67-d870-aaae-9eaa-166416030303
Version Independent ID: 6f758af1-638e-5b43-9c07-202f69a29497
Content: Authenticate playbooks to Microsoft Sentinel
Content Source: articles/sentinel/authenticate-playbooks-to-sentinel.md
Service: microsoft-sentinel
GitHub Login: @yelevin
Microsoft Alias: yelevin

@slaffyJoe24
Thanks for your feedback! We will investigate and update as appropriate.

Hi @slaffyJoe24, there seems to be missing feedback here. If you have feedback on these docs, can you try opening a GitHub issue again with your comments? I'm going to close this issue for now.
Thanks
#please-close


Initial holoviews docs theme redesign

Switches from readthedocs based Sphinx template to a template based on the bokeh_theme and CSS based on bokehplots.com. Also introduces basic website skeleton based on the plan discussed in https://github.com/ioam/holoviews/issues/1379.
An initial build can be seen at: build.holoviews.org

Let's get this merged now, so we can both start building with the new theme. There's still plenty of things to fix but that can be a new PR.

I really like the new look!
It will definitely do the job of making anyone who has visited the website before notice all the new docs. Merging.


[FEATURE] Add option to use full commit SHA

Describe the solution you'd like
Github autolinks commit SHAs, but only if given a full 20-character hash explicitly. This would be nice in a changelog generated for a github release.
My vision is to add a flag for cog changelog like --full-hash since this is probably only wanted on a per-execution basis, like in github actions.
Describe alternatives you've considered
As an alternative we could generate github commit links as part of cog functionality, but IMO a commit hash is less ambiguous than a github URL.

@tranzystorek-io this is a great idea.
Are you talking about changelogs generated from cog changelog or cog bump ?
Having full hash would be great for both of them but I think changes to changelog generation should not be integrated until #124  is sorted out.


Python 3.6 drop follow up

Found these comments about legacy code and did what I think they were telling me.

This is the original PR that introduced that change


Tracking Events not being fired

Certain tracking events present in my vast xml are never being fired. These events include fullscreen/exitfullscreen, mute/unmute, and skip (maybe it works, but I cannot skip the ad event after removing 'controls' attr from my video element). I've been stuck on this for quite awhile..
Anyone got any ideas on how to help?

@wroberts15  Do you have an example vast tag url that I can use to test skip ad?
I've noticed the skip ad issue but have don't have an ad that always provides the skip functionality.

This is my attempt so far around line 160
errorFn = function() {
          // Inform ad server we couldn't play the media file for this ad
          vast.util.track(player.vastTracker.ad.errorURLTemplates, {ERRORCODE: 405});
          errorOccurred = true;
          player.trigger('ended');
        },
        muteFn = function() {
          player.vastTracker.setMuted("mute");
        },
        unmuteFn = function() {
          player.vastTracker.setMuted("unmute");
        };

    player.on('canplay', canplayFn);
    player.on('timeupdate', timeupdateFn);
    player.on('pause', pauseFn);
    player.on('error', errorFn);

    // wroberts15
    player.on('mute', mute);
    player.on('unmute', unmuteFn);

I can post the vast in a moment

<?xml version="1.0" encoding="UTF-8"?>
  <VAST xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="2.0">
    <Ad id="1">
    <InLine>
        <AdSystem>intranet</AdSystem>
        <AdTitle><![CDATA[HTTP -1]]></AdTitle>
         <Impression><![CDATA[http://example.com/p?exmple1=[campaign-id1]&ex5=[creative-id]&ex6=[ad-placement-id]&c6=[impression]&vce4v=1]]></Impression>
         <Creatives>
          <Creative>
           <Linear>
              <Duration>00:00:30</Duration>
              <MediaFiles>
                 <MediaFile delivery="streaming" type="video/mp4" scalable="true"><![CDATA[http://office.intranet.com/vce_tests/vce4v_html5_tests/tests/static/pepsi_vs_coca.mp4]]></MediaFile>
                 <MediaFile delivery="progressive" type="video/webm" scalable="true"><![CDATA[http://office.intranet.com/vce_tests/vce4v_html5_tests/tests/static/pepsi_vs_coca.webm]]></MediaFile>
              </MediaFiles>
              <TrackingEvents>
                 <Tracking event="start"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-start-id]&c6=[start]&vce4v=1]]></Tracking>
				      <Tracking event="pause"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-pause-id]&c6=[pause]&vce4v=1]]></Tracking>
				      <Tracking event="resume"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-resume-id]&c6=[resume]&vce4v=1]]></Tracking>
                 <Tracking event="firstQuartile"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-firstq-id]&c6=[firstQuartile]&vce4v=1]]></Tracking>
                 <Tracking event="midpoint"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-midpoint-id]&c6=[midpoint]&vce4v=1]]></Tracking>
                 <Tracking event="thirdQuartile"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-thirdq-id]&c6=[thirdQuartile]&vce4v=1]]></Tracking>
                 <Tracking event="complete"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-complete-id]&c6=[complete]&vce4v=1]]></Tracking>
                 <Tracking event="skip"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-skip-id]&c6=[skip]&vce4v=1]]></Tracking>
                 <Tracking event="mute"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-mute-id]&c6=[mute]&vce4v=1]]></Tracking>
                 <Tracking event="unmute"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-unmute-id]&c6=[unmute]&vce4v=1]]></Tracking>
                 <Tracking event="fullscreen"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-fullscrn-id]&c6=[fullscreen]&vce4v=1]]></Tracking>
                 <Tracking event="exitfullscreen"><![CDATA[http://example.com/p?exmple1=[campaign]&ex5=[creative-id]&ex6=[ad-exitfs-id]&c6=[exitfullscreen]&vce4v=1]]></Tracking>
              </TrackingEvents>
              <VideoClicks>
                 <ClickThrough><![CDATA[http://www.intranet.com]]></ClickThrough>
                 <ClickTracking><![CDATA[http://example.com/p?exmple1=[campaign-id1]&ex5=[creative-id]&ex6=[ad-placement-id]&c6=[click-thru]&vce4v=1]]></ClickTracking>
              </VideoClicks>
           </Linear>
        </Creative>
     </Creatives>
  </InLine>
  </Ad>
</VAST>

Formatting is a little off but try that.. or I can post to a pastebin or something. Also, you'll have to use your own media files

Still working through the issues but looks like player.on('mute', muteFn); will work if you listen to volumechange, --> player.on('volumechange', muteFn); just need to figure out what the actual volume is


Can't Login

The Website log me out and can't login again.
When i click i the login button,
it redirects me to a 500 Error page on this link
https://api.dogehouse.tv/auth/github/callback?code=0266bb29f9182bec633e&state=web
After a reload got this response
{"error":"code expired, try to login again"}

#88

not sure what the code value represents, consider it's best if you edited it out for privacy reasons?

Just in case 🤣

You should also remove it from your edit history, otherwise it's still visible. You should be able to do so by clicking the arrow on edited and then remove it from there :)


Thumbnails are 'borrowed' for items without thumbnails

Open the item details of an item with an uploaded thumbnail
return to the Gallery
Open the details of an item without an uploaded thumbnail
Notice that the thumbnail for the first item displays on the item details for the second item.

non-repro


Ensure use of Clockwise and Counterclockwise are consistent

They are not currently. Table 3 lists the two atom parity variants as Clockwise and Counterclockwise. But under syntax, "... corresponding to the values Left and Right respectively."
Pick one pair of variants and use it consistently.

Duplicate of #39.


Restrictions on entity interfaces: Interface must be defined in the same assembly as the entity class

I wanted to have an abstractions project with only entity interfaces, but apparently the interfaces must be defined in the same project/assembly as the entity class itself.
This restriction is not documented in the "Restrictions on entity interfaces" section.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3799266d-bc0a-63f0-b67a-bc182d37667a
Version Independent ID: b768cbf4-c572-58d9-d5e2-1d067e9bba5e
Content: Developer's Guide to Durable Entities in .NET - Azure Functions
Content Source: articles/azure-functions/durable/durable-functions-dotnet-entities.md
Service: azure-functions
GitHub Login: @sebastianburckhardt
Microsoft Alias: azfuncdf

Hello @Costo,
Thank you for your feedback! We will review and update as appropriate.

Hi @cgillum - any insights on one?

@Costo thanks for calling this out. I've opened a PR to update the article, listing this restriction.


Convert luthersystems/sandbox to GitHub Actions

Pipeline migrated from CircleCI :tada:
Manual steps
Perform the following steps to complete the migration:
luthersystems/sandbox/luthersystems/sandbox

[x] Ensure environment variable is updated: LUTHER_LICENSE

@jeremy-asher I'm using the script command to create a pseudo tty which gets around the -it and compose script issues that all expect a tty at the moment.


react-pdf Document is caching PDFs failure to load

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Coming from here: https://github.com/Expensify/App/pull/13409#pullrequestreview-1210923388
Action Performed:

Upload a pdf
Go offline
Open the pdf and verify that you see error message
Go back online
Open the pdf and verify that you can view it. (there should be no error message)

Expected Result:
The PDF should open successfully now that you are online
Actual Result:
We keep getting the error after coming back online
https://user-images.githubusercontent.com/87341702/206594057-936d0665-84c1-4f66-85e4-974ce7aeaef3.mov
Workaround:
Refresh the page?
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

I think a next step is create a GH issue in the react-pdf repo: https://github.com/wojtekmaj/react-pdf/issues proving a reproducible example.
There is an existing issue about disabling cache, but it was opened for other reasons and then closed without activity.

When we close and reopen the attachment, I confirmed that the component PDFView is getting destroyed/reconstructed.

@muttmuure This issue was mentioned by @rushatgabhane here when he was reviewing a PR. Just mentioning in case it makes him qualify for reporting compensation.

Not had chance to get to this yet

Testing now

Hey @aldo-expensify I can't reproduce this - I can still load the PDF I uploaded even after I go offline, do you mind checking that the bug still happens for you?

I managed to reproduce, but I noticed that I can only do it using the Chrome dev tools to go offline/online and with Disable cache checked. I tried to reproduce without chrome dev tools by disconnecting the wifi and it works fine in that case (which is the normal use case).
I'm going to close it, thanks for trying!


"continuously collects behavioral cyber telemetry" -- but not always

After working with Microsoft support when we saw a large number of gaps in event data in MDE, an MDE engineer said this is working as designed. From the support ticket "MDE is not intended to be an auditing/logging solution that records every operation or activity that happens on a given machine...Our sensor has an internal throttling/capping mechanism, so the high rate of repeat identical events won't flood the logs...when we transmit telemetry to the cloud". This, or something similar to it, should be noted on this page (and likely others as well). Any reader will make the assumption that ALL events will be sent to MDE with the existing statement "This includes process information, network activities, deep optics into the kernel and memory manager, user login activities, registry and file system changes, and others. The information is stored for six months, enabling an analyst to travel back in time to the start of an attack." Thus, a note about the throttling, likely event loss, and MDE is "not intended to...record every operation" is VERY relevant to users and potential users.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 072bd7c6-9f5b-4de2-2d65-f83e7adbc85f
Version Independent ID: 39c90a0c-6bce-68a3-7b1f-138819744b76
Content: Overview of endpoint detection and response capabilities
Content Source: microsoft-365/security/defender-endpoint/overview-endpoint-detection-response.md
Product: m365-security
Technology: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@msbemba

@cronq Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/9030
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @cronq Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


FAQ: Not a discoverability service and Rejected casks

Went ahead and included a FAQ for rejected casks.


ssd1325 spi device fails to correctly update screen

Type of Raspberry Pi
Pi 3 Model B
Linux Kernel version
Linux raspberry 4.14.98-v7+ #1200 SMP Tue Feb 12 20:27:48 GMT 2019 armv7l GNU/Linux
Expected behaviour
Run examples without issue. Was previously working with same hardware configuration. SD card reformatted with fresh raspbian image, and updating canvas no longer works as expected. Verified hardware setup, and all examples ran with previous software install.
Actual behaviour
Running demo.py from luma.examples with:
$ python3 luma.examples/examples/demo.py -d ssd1325 --interface spi --gpio-reset 22
Version: luma.oled 3.2.0 (luma.core 1.8.3)
Display: ssd1325
Interface: spi
Dimensions: 128 x 64
------------------------------------------------------------
Testing basic canvas graphics...
Testing contrast (dim/bright cycles)...
Testing display ON/OFF...
Testing clear display...
Testing screen updates...

First few Tests display as expected, but fails on Testing screen updates.... See gif below.

Similar results are observed from other examples that should update. Running clock.py with:
$ python3 luma.examples/examples/clock.py -d ssd1325 --interface spi --gpio-reset 22
Version: luma.oled 3.2.0 (luma.core 1.8.3)
Display: ssd1325
Interface: spi
Dimensions: 128 x 64
------------------------------------------------------------

Results in garbled output, shown below.

A nearly identical issue was reported for SSD1327 devices (see #242) and was recently fixed in #244. I wonder if the same regression has crept into the SSD1325 driver also. The reason this happens is because of the way the column addressing is being set when using the diff to previous frame buffer.
The issue will “go away” if you add the —frambuffer full_frame flag when you run the examples.
In the meantime, I will investigate further and provide a fix for the diff-to-previous framebuffer implementation. It could be something to do with the logic here: https://github.com/rm-hull/luma.core/blob/master/luma/core/framebuffer.py#L52 but this hasn’t changed in a long time.

@stylerf  - v3.2.1 released to pypi with a fix for this

Thanks for the super quick reply and fix! That did the trick!
I was able to use the examples with the --framebuffer full_frame flag. Upgrading to luma.oled v3.2.1 via pip removes the need for the flag. You rock!


Questionnaire-b

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

A3: complete. You demonstrated a good understanding of the material.

Thank you!


Wrong filename for ArgoCD

My quarkus application created and pushed the helm files to a Nexus Helm repository.
The quarkus archive name is xxxx-helm.tgz
ArgoCD need a filename xxxx.tgz
For me and ArgoCD is "-helm" to much in the filename.
Can I change it over the applications.properties?

Thanks for reporting this issue!
Actually, I'm thinking of always generating xxxx.tgz unless the user provides a prefix via configuration. Wdyt?

For me, that would be the right way to go. Other applications, like ArgoCD, cannot know that a prefix is present.


Need to test the new Azure Node Driver fixes on SLES

This is a task to retest: https://github.com/rancher/rancher/issues/25342#issuecomment-632932416 using SLES.

Discussed with CSM and it's not needed anymore.


Allow query to be passed to Balance service

The Balance service's methods do not pass any params to the underlying stripe methods, as seen here: https://github.com/feathersjs-ecosystem/feathers-stripe/blob/a388b8e05248d539507a18ee55de2f8eaed277cb/lib/services/balance.js#L7
But, the stripe.balance method does actually accept query parameters, specifically stripe_account. When fetching a balance without providing a stripe_account, the balance of the account holding the keys is returned. But, when using Stripe Connect, we can manage other accounts and need to be able to fetch their balance.
You can see an example of this working here: https://github.com/stripe/stripe-connect-rocketrides/blob/897716cae8130f76254a71f6d1258c6b6f85dbc9/server/routes/pilots/pilots.js#L33
I propose that the Balance service's get and find methods pass params.query to the underlying stripe method.

Closed via #64


"You appear to have already installed WordPress."

I'm trying to create a new installation of wordpress, stackable, and I'm getting this error:
You appear to have already installed WordPress. To reinstall please clear your old database tables first.

I have one install working on another domain, so I created a new, similar stack, and all was well, until I decided to change some more things and redeploy. Now it's giving me the above error, even if I terminate the whole stack and redeploy. Here's my whole stackfile:
drhWordpress-storage:
  image: 'tutum/wordpress-stackable:latest'
  volumes:
    - /app/wp-content/plugins
    - /app/wp-content/themes
    - /app/wp-content/uploads
    - /var/lib/mysql
drhDb:
  image: 'tutum/mysql:5.5'
  environment:
    - MYSQL_PASS=examplepassword
  volumes_from:
    - drhWordpress-storage
drhPhpMyAdmin:
  image: 'corbinu/docker-phpmyadmin:latest'
  environment:
    - MYSQL_USERNAME=root
    - MYSQL_ROOT_PASSWORD=examplepassword
  links:
    - 'drhDb:mysql'
  ports:
    - '4105:80'
drhSftp:
  image: 'luzifer/sftp-share:latest'
  environment:
    - PASS=examplepassword
    - USER=julian
  ports:
    - '2025:22'
  volumes_from:
    - drhWordpress-storage
drhWordpress:
  image: 'tutum/wordpress-stackable:latest'
  environment:
    - VIRTUAL_HOST=example.com
    - DB_PASS=examplepassword
  links:
    - drhDb
  volumes_from:
    - drhWordpress-storage

Not sure if it has something to do with your volume container

I assume as much. Wouldn't terminating and starting it fresh remove the volume? I'm wondering if somehow the volumes are hanging out in cyberspace without being removed.

Did you deployed it in Tutum?
Usually in Tutum:

When a service is redeployed, the container is deleted and the volume is mounted to the new created container.
When a service is terminated, a container is destroyed, the volume will be cleaned by tutum after a period of time. A new started container will have its own volume.

Yes, I deployed it with Tutum. Even using new container and stack names doesn't seem to help... could this be related to having more than one stack using the same image? I don't know why that would have an effect, but perhaps the new stack is using the volume from the older stack...? It doesn't appear to, because it appears as a vanilla wordpress install (when I visit the site). Problem is I can't  log in, it goes to the installer, which then tells me I already have wordpress installed.

It looks likes there was something wrong with the volume mounting, not related to the image itself.
Can you open a ticket on tutum?

Oh, this is funny... there's are orphan containers running outside of any stacks. Removing that solved the problem. I wonder how they got there, there were almost a dozen! So somehow Tutum is creating orphan containers.


Refactor numba_rvsdg/tests/test_figures.py

This is a reminder to refactor numba_rvsdg/tests/test_figures.py as per:
https://github.com/numba/numba-rvsdg/pull/50#discussion_r1253057244
Pending merge of #50 and #75

Partially addressed by: https://github.com/numba/numba-rvsdg/pull/118


Support API keys (Open cloud)

Some new APIs have been added, and some have been modified to support these new OAuth based API keys.
We should aim to phase out use of cookies and move to these new tokens, in preparation for when more APIs are made available

I would propose having a dual system, where all supported methods are moved to the new key system and all other APIs labelled as 'legacy' and using the cookie.
It may be worth making this v5 and continuing to maintain v4 of methods which use the current APIs.
At present only publish is available but this provides a good starting point.

partially implemented

No longer planned


ThemeSwitch: fix state on page load

Preview is available here:http://laboratory-pr931.previews.kube001.services.stellar-ops.com/


Add support for 64-bit integers

Adding this as an issue, it is mentioned in the TODO.md file.
We would like to compress 64 bit unsigned integers.
Since the library now requires a 64 bit system (see README.md), 64 bit compression would be useful.

any updates on this? is there any recommended workarounds for 64 bit integers?

Publicly available datasets derived from actual problems would go a long way generating interest for this problem.

The FrameOfReference (C++) library supports compressing arrays of 64-bit values https://github.com/lemire/FrameOfReference

Thank you for the great library.
I see that the FrameOfReference repo you linked to does not have MSVC support etc. similar to FastPFor. Since I see that this thread has been open since 2015 I just wanted to check to see if you had any plans for adding support for 64-bit unsigned integers. Thank you!

@rapoth I think you should have no problem building FrameOfReference with Visual Studio if you follow these instructions...
https://github.com/lemire/FrameOfReference#building-visual-studio-under-windows

@lemire I verified that the latest version is working on Windows. Thank you so much! I really appreciate your time.

@rapoth  ;-)

Resolved by @xndai via https://github.com/lemire/FastPFor/pull/58


Import 40eb7ed793: JSDoc automatically finds all doclets now (by Maki)

This is an automated proposal to look at a commit made by Maki and import it into Overte

Commit:
40eb7ed79319485b9ddb3ac2265d4c09e1fe25a0

Author:
Maki

Date:
Sat, 18 Jan 2020 03:53

JSDoc automatically finds all doclets now

Stats:

Filename
Stats
Lines
Added
Removed
Lines in blame

tools/jsdoc/config.json

60
30
30
30

tools/jsdoc/plugins/{tivoli-json-export.js => export-json.js}

8
5
3
⚠ File gone

tools/jsdoc/plugins/find-doclets.js

151
151
0
116

tools/jsdoc/plugins/tivoli.js

150
0
150
⚠ File gone

4 files
-
369
186
183
146

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
If the commit is not useful, tag it with "Tivoli: Discard", and close it.
If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.
You can cherry-pick this issue with this command:
git cherry-pick 40eb7ed79319485b9ddb3ac2265d4c09e1fe25a0

Not sure what this does, could be useful

I will have to take a closer look at it at some point.


Optimize Metrics.IncrementCounter() for .NET 8+

Description
Optimize the performance of Metrics.IncrementCounter() on .NET 8+ by using the ref-returning CollectionsMarshal.GetValueRefOrAddDefault(). To my knowledge, the lock statement is still needed owing to the following remark in the documentation

Items should not be added to or removed from the Dictionary<TKey,TValue> while the ref TValue is in use.

Motivation and Context
Metrics counters tend to be called a lot. The optimized version is also less code.
Testing
Unit tests covering both sequential and concurrent scenarios.
Screenshots (if appropriate)

Benchmarks

Benchmark Code
public class DictionaryIncrement
{
  private object metricsLock = new object();
  private readonly Dictionary<string,long> Counters = new Dictionary<string,long>();
  private string metric;

  [GlobalSetup]
  public void Setup()
  {
      metric = "foo";
  }

  [Benchmark(Baseline = true)]
  public void Original()
  {
      lock (metricsLock)
      {
          long value;
          if (!Counters.TryGetValue(metric, out value))
          {
              value = 1;
          }
          else
          {
              value++;
          }
          Counters[metric] = value;
      }
  }

  [Benchmark]
  public void Optimized()
  {
      lock (metricsLock)
      {
          ref long value = ref CollectionsMarshal.GetValueRefOrAddDefault(Counters, metric, out _);
          value++;
      }
  }
}

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

Actually, I can't seem to find this in use anywhere. Perhaps this is old code?

@stevenaw It looks like we use SetCounter rather than IncrementCounter, it is mainly used for retries which is already being tracked at the request pipeline and we get the latest value at SetCounter, maybe this was used before or was added for completeness.


run into dead loop when tuning the tma persistent kernel

I'm try running matmul_kernel_tma_persistent this kernel with various configs, but it often get into dead loop with GPU 100% utilization.
Is that a bug?

You probably need to add a TMA fence. Can you try adding this at the top of the kernel body and let me know if it solves your issue?
tl.inline_asm_elementwise("fence.proxy.tensormap::generic.acquire.gpu [$1], 128; // $0 dummy reg", "=r, l",
                        [a_desc_ptr], dtype=tl.int32, is_pure=False, pack=1)
tl.inline_asm_elementwise("fence.proxy.tensormap::generic.acquire.gpu [$1], 128; // $0 dummy reg", "=r, l",
                        [b_desc_ptr], dtype=tl.int32, is_pure=False, pack=1)
tl.inline_asm_elementwise("fence.proxy.tensormap::generic.acquire.gpu [$1], 128; // $0 dummy reg", "=r, l",
                        [c_desc_ptr], dtype=tl.int32, is_pure=False, pack=1)

Context: https://github.com/embg/triton/blob/ed125e4a44e397e9a40e691bb7ce40c698120a1a/tma_repro.py

@sleepwalker2017 Please let me know if https://github.com/triton-lang/triton/pull/4342 solves your issue :)

#4342

OK   I'll try that!

@sleepwalker2017 Please let me know if #4342 solves your issue :)

Hi, I have another question, Is this a bug?
loc("/data/triton/python/tutorials/tma_test.py":110:32): error: 'tt.trans' op inferred type(s) '!tt.memdesc<128x128xf8E4M3FNUZ, #triton_gpu.shared<{vec = 16, perPhase = 1, maxPhase = 8, order = [0, 1], hasLeadingOffset = true}>, #triton_gpu.shared_memory>' are incompatible with return type(s) of operation '!tt.memdesc<128x128xf8E4M3FNUZ, #triton_gpu.shared<{vec = 16, perPhase = 1, maxPhase = 8, order = [0, 1], hasLeadingOffset = false}>, #triton_gpu.shared_memory>'
loc("/data/triton/python/tutorials/tma_test.py":110:32): error: 'tt.trans' op failed to infer returned types

When I pass in some specific configs, it reports this error. Are these configs illegal?

@sleepwalker2017 Please let me know if #4342 solves your issue :)

I tried my tuning code, and it seems the dead loop is solved!

When I pass in some specific configs, it reports this error. Are these configs illegal?

Can you share the exact code and configs you are using? For example, fork the Triton repo and push a branch with the exact code you are running + the CLI command you are using to repro the error?
I would like to close this issue, as the dead loop problem was solved by adding the TMA fence. After you upload the repro information, perhaps you can open a new issue?


container burn cpu case failure

Issue Description
Type: bug report
Describe what happened (or what feature you want)
Describe what you expected to happen
Open readable and writable directory parameters
How to reproduce it (as minimally and precisely as possible)

Tell us your environment
Anything else we need to know?

Please provide the following command and error message


Welcome print out version and cataloger type if set

Codecov Report

Merging #1324 (82983e9) into master (a22f94f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
+ Coverage   47.09%   47.10%   +0.01%
==========================================
  Files         203      203
  Lines       15904    15904
==========================================
+ Hits         7490     7492       +2
+ Misses       7424     7423       -1
+ Partials      990      989       -1

Impacted Files
Coverage Δ

catalog/mvcc/cataloger_create_repository.go
62.96% <0.00%> (ø)

catalog/mvcc/cataloger_create_entry.go
100.00% <0.00%> (+5.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22f94f...481efe7. Read the comment docs.

Codecov Report

Merging #1324 (82983e9) into master (a22f94f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
+ Coverage   47.09%   47.10%   +0.01%
==========================================
  Files         203      203
  Lines       15904    15904
==========================================
+ Hits         7490     7492       +2
+ Misses       7424     7423       -1
+ Partials      990      989       -1

Impacted Files
Coverage Δ

catalog/mvcc/cataloger_create_repository.go
62.96% <0.00%> (ø)

catalog/mvcc/cataloger_create_entry.go
100.00% <0.00%> (+5.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22f94f...481efe7. Read the comment docs.


Preserve spaces in copts values

Do this by only trimming whitespace, which will limit it to the start and end of the string.

Thanks for the PR @bolsinga 👍


No contributing.md

There is no contributing.md file which is also required for new users to start with it
I can make it if you assign this issue to me

sure. create a PR for it.


Style

Classes are usually singular, especially when they are models. Games --> Game
More consistent view names btn_commentSave --> btnSaveComment
Remove commented out code. You have git for getting back to the old code, you don't need to comment it.
Format the code before you push it. MainActivity has some brackets in wrong places.

Ок :)


Adding redirection file

...so links to old page locations continue through to new locations

OPS Build status updates of commit 79cd571:
:clock10: Preparing: average preparing time is 44 sec(s)

OPS Build status updates of commit 79cd571:
:clock10: Incremental building: average incremental building time is 21 sec(s)

OPS Build status updates of commit 79cd571:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


3.2.4rc3 exit response is slower than 3.2.4rc2

Godot version:

3.2.4 rc3 offical
OS/device including version:

Issue description:

not big issue but I still decide to report it, see the videos below (why the videos can't be previewed?)
3.2.4rc3 exit
https://user-images.githubusercontent.com/64188282/109470983-124d8a80-7aab-11eb-8112-77807f3c922a.mp4
3.2.4rc2 exit
https://user-images.githubusercontent.com/64188282/109471014-1ed1e300-7aab-11eb-8fa9-e1dfb98f48fd.mp4

Not sure yet if that's a bug or a bug fix (could be that it's now properly cleaning memory that would usually be left to the OS to handle), but it seems reproducible on Linux too.

(why the videos can't be previewed?)

You need to add a blank line before and after the video link for the preview to work.

After doing further testing I can't seem to reproduce the issue. I wonder if it's just a matter of the OS caching stuff for subsequent launches. For example when testing 3.2.4 RC 2 my first launch + close takes over 2.5 s, while subsequent attempts can be sub-1.0 s.

After doing further testing I can't seem to reproduce the issue. I wonder if it's just a matter of the OS caching stuff for subsequent launches. For example when testing 3.2.4 RC 2 my first launch + close takes over 2.5 s, while subsequent attempts can be sub-1.0 s.

I can reproduce the issue everytime on macOS


⚠ ClamAV has degraded performance

In 5789717, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 489 ms

Resolved: ClamAV performance has improved in 20887a3.


floordiv truncates and not floors negative numbers

gl.SArray(range(-5,6)) // 3
dtype: int
Rows: 11
[-1, -1, -1, 0, 0, 0, 0, 0, 1, 1, 1]

[i // 3 for i in range(-5,6)]
[-2, -2, -1, -1, -1, 0, 0, 0, 1, 1, 1]

Should the output type of this be int or float?
The main question here is what to do with divide-by-zero errors.  Should those then be None or NAN?


V12 compatibility

Personal rambelings
First off, thanks for all the hard work you have put into this module. I noticed in the issue list #326 you are currently very busy and I really wanted to use Drag Ruler in a new campaign that we will start soon in V12, so I thought: I can develop modules! Why not have a look?
What you probably care about
I managed to get Drag Ruler to work on both V11 and V12, I did some test as GM, as player, with and without routingLib & the dnd5e extension and things seem to be working but has not been "field tested" yet.

Does the original author have to confirm the commits for us to use this?

I suppose it doesn't have to be. I just made a beta release for you. You can manually install it with the module.json provided in the release.
I would like to kindly ask to not bother the original author with issues on V12 since this is an unofficial and experimental release
Manual installation:

Appreciate your contribution to this, hopefully your branch helps the creator to create a stable release!

Nice one! This absolutely gets things going, though it does seem to crash at times, resulting in no label being printed for the ruler at all. I haven't investigated too deeply yet to describe how to reproduce this, but I will drill down further later. I'm seeing this exhibited on a gridless game.

I finally got around to testing and reviewing the changes. Unfortunately, the canvas doesn't load at all on my system. This is the error that gets spammed.

Since people seem to be successfully using your patch, I assume it cannot be inherently broken. Any idea what might be going on?

Nice one! This absolutely gets things going, though it does seem to crash at times, resulting in no label being printed for the ruler at all. I haven't investigated too deeply yet to describe how to reproduce this, but I will drill down further later. I'm seeing this exhibited on a gridless game.

I'm afraid I seem to be unable to reproduce this error on a gridless system with foundry version 12.330

I'm afraid I seem to be unable to reproduce this error on a gridless system with foundry version 12.330

It might involve the speed provider. I'll dig further.

Hi! I'm trying to use it with wfrp4e, but have a duplicate of token when moving, then got an error in console.

Any ideas, is it package or system problem?
Foundry v12 328

Hi! I'm trying to use it with wfrp4e, but have a duplicate of token when moving, then got an error in console.  Any ideas, is it package or system problem?
Foundry v12 328

wfrp4e does not officially support V12 and the error does happen in the wfrp4e code, which leads me to believe this might be related to wfrp4e, although I am not familiar with the system

wfrp4e does not officially support V12 and the error does happen in the wfrp4e code, which leads me to believe this might be related to wfrp4e, although I am not familiar with the system

Thank you for clarification! Sorry to bother you with this.

In further testing, I've found a much bigger issue than what I initially suggested. From testing on gridless maps, I'm finding that ruler.rulerOffset is probably double-correcting. L142 of main.js:
ruler.rulerOffset = {
    x: entityCenter.x - event.interactionData.origin.x,
    y: entityCenter.y - event.interactionData.origin.y,
};

This seems meant to counter where the user grabbed the token and force it back to center. In v11, it prevents the issue that it now causes in v12. See images below. Gridless scene, with lines showing five foot marks. Deliberately grabbed an image off center, trying to drag it five feet in the -x direction:

Pre-Move
Post-Move

I'm pretty sure this happens constantly, but it's only visible on gridless and hex grids because square grids are orthogonal wrt the canvas, so the offsets don't cause an apparent issue. I can fix this via hack:
ruler.rulerOffset = {
    x: 0,
    y: 0
};

Another issue appears to be hex grids in general. This isn't surprising, since hex grids received a lot of rework in v12, afaik. In testing, these are just not functional at all.

Also note this PR breaks on hex grids. I've submitted a pr downstream to TPNils to correct both issues.

I finally got around to testing and reviewing the changes. Unfortunately, the canvas doesn't load at all on my system. This is the error that gets spammed.

Since people seem to be successfully using your patch, I assume it cannot be inherently broken. Any idea what might be going on?

Silly question, but you did update your game system to v12, right? Someone reported that issue on reddit and their problem was being on the v11 version of D&D 5e.

Not that silly of a question. You nailed it @n0q. This PR is now merged as 0808f17 and I also took the liberty to pull in your PR in TPNils' fork as 0e2ab35. I've also gotten rid of most of the deprecation warnings - though a few remain (which in Drag Ruler unfortunately always means the console will be absolutely spammed). Release of those changes is imminent. Thanks your work and for your patience with me, guys! :)


Custom LogEntry actions

I would like to track some actions other than create, update or delete, e.g. sent or archived
Is this something that could be supported?

Hi. When you "send" or "archive" any object, it is "update" action, right? And you can see the action in the changes field.


Performance and functionality improvements for gdb

Make the endlessly polling function await_halt in worker.rs
sleep for 1ms on every iteration so we don't constantly draw
100 % from the CPU core we're running on

Return a T02 instead of a T05hwbreak when a user requests a
break via an interrupt with Ctrl-c (stolen from OpenOCD, I don't
actually know the meaning of the 02)

Previously await_halt would send a constant stream of T05hwbreak
to the GDB client once the core was haltet as await_halt was never
set to false when a breakpoint was hit, change this behaviour so
breaking actually works.

Thanks for the fixes :)
I commented on some minor thing :)


Web Socket Connection - Get disconnected intermittent

I'm facing this issue that a connection is getting closed intermittently between 10sec~40sec. (error shown on client log which is attached below)
I'm not sure what we've changed lately but before it was working fine. Any ideas how to solve this issue?
We have set:

Sticky sessions on the NGINX load balancer
Idle timeout is set to 3600

Load Balancer Configuration:
NGINX ConfigMap

proxy-read-timeout: "3600"
proxy-send-timeout: "3600"

Ingress NGINX Service  (Load Balancer)

service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout: "3600"

NGINX Ingress

ingress.kubernetes.io/affinity: "cookie"
ingress.kubernetes.io/session-cookie-name: "route"
ingress.kubernetes.io/session-cookie-hash: "sha1"

Currently we are using:

Signalr Javascript client : 1.0.0
Server-Side NuGet Packages: 1.0.0
Signalr Server is running on Kubernetes cluster of: 4 instances
Kubernetes: using ingress with ngnix
Operating System on the Server: Linux
Operating System on the Client: Windows
Host: AWS
Browser on the client: Chrome

Sample Client Application for quick testing:
This sample client application connects with our signalr server
https://github.com/claylaut/signalr-websocket-connection-issue
Server logs sample:
These server logs are for one specific user getting disconnected and reconnected multiple times.
If you need stack trace of any particular log, please do not hesitate to ask.
server-logs-sample
Client sample error:
Note: Client and server logs are from different sessions, so ID's will not correlate

Looks like the connection is being terminated by the proxy. Have you configured NGINX to proxy WebSockets properly? It requires specific configuration: https://www.nginx.com/blog/websocket-nginx/

Hummm, didn't know that about nginx, just commenting to make a note of this when we want to deploy that way.

@anurse,
This is the headers that we received from the hub, we got these from hub:
((HttpConnectionContext)Context.Features[typeof(IHttpContextFeature)]).HttpContext.Request.Headers
Headers received:
Cache-Control -> no-cache,
Connection -> upgrade,
Pragma -> no-cache,
Upgrade -> websocket,
Accept-Encoding -> gzip, deflate, br,
Accept-Language -> en-US,en;q=0.9,
Cookie -> __zlcmid=mohOuPX0onJyAa; route=a7a2cbdba8e7b7b3b378565d8a825d438758a64f,
Host -> underworld.loki.com,
User-Agent -> Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36,
Origin -> file://,
X-Request-ID -> ff571cb8bafc18d6e83fb65cefc6fb0c,
X-Real-IP -> <IP_ADDRESS>,
X-Original-Proto -> http,
X-Forwarded-Host -> underworld.loki.com,
X-Forwarded-Port -> 80,
X-Original-URI -> /common/real-time/magic?id=crHVwzsEfyu4GjHA3GQCVw,
X-Scheme -> http,
Sec-WebSocket-Version -> 13,
Sec-WebSocket-Key -> wfs3sn0wshcVpzeO15nbTA==,
Sec-WebSocket-Extensions -> permessage-deflate; client_max_window_bits,
X-Original-For -> <IP_ADDRESS>:32884

We did few other changes but unfortunatly we had no luck to fix this.
Any ideas?

Can you try connecting directly to the server, without using nginx as a proxy and see if the connections disconnect then? If they don't, then the issue is likely in the nginx configuration. The fact that it is disconnecting reliably after a certain period indicates that nginx is probably killing the connection due to some timeout. By default, the ASP.NET Core WebSockets middleware sends a keep-alive frame every 2 minutes, so as long as the timeouts for all the proxies are larger than that (your original issue indicated 3600 which as long as the units are seconds should be fine), the connection should remain active.
Also, since you're using Ingress, have you configured it appropriately for WebSockets? https://github.com/nginxinc/kubernetes-ingress/tree/master/examples/websocket

@anurse sorry for the late reply but currently I`m abroad and I have limited internet connection.
Finally, we solved this issue it was nginx reloading and dropping connections.
in a nutshell we had to add:
--enable-dynamic-configuration
--watch-namespace=$(POD_NAMESPACE)
--force-namespace-isolation=true
For more information about this fix can be found here: https://github.com/kubernetes/ingress-nginx/issues/2647
@anurse thanks again for your help.


Getting friends does not work anymore

I get a 403 error
Traceback (most recent call last):
  File "test.py", line 9, in <module>
    smittys_pals = fortnite.friends(username='Smitty Werbenjagermanjensen')
  File "/home/fn/.local/lib/python3.5/site-packages/pfaw/core.py", line 41,in friends
    response = self.session.get(constants.friends.format(player_id))
  File "/home/fn/.local/lib/python3.5/site-packages/pfaw/core.py", line 120,in get
    response.raise_for_status()
  File "/usr/lib/python3/dist-packages/requests/models.py", line 840, in raise_f or_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://friends-public-service-prod06.ol.epicgames.com/friends/api/public/friends/9c9212603304472d831c03d0978d2bc1

I tested this method and it works correctly. The friends method is very limited as it only works for getting the friends of the authenticated account. You can't get the friend list of some random player.

What information can we get from that?
Can we see their game status like kills and status and can we send them a DM?
or does it just show the friends and their IDs?


Integrate qwen and qwen_parallel into minillm pipeline

Integrate the open-sourced model Qwen (https://huggingface.co/Qwen) into the minillm distillation algorithm, supporting both non-parallel and parallel training.
mainly added 2 folders：
transformers/src/transformers/models/qwen/
transformers/src/transformers/models/qwen_parallel/
Tips:

Due to the vocab_size of Qwen's tokenizer exceeds 150k, which is much larger than gpt2 (~50k) or llama (32k), I did slight modification of the data processing code related to tokenizer to prevent overflow, like from uint16 to uint32;
Slightly added few lines in transformers/src/transformers/ __ init__.py and transformers/src/transformers/models/ __ init__.py to adapt to qwen;
The corresponding training data like dolly and roberta/openwebtext needs to be pre-processed using qwen's tokenizer, which is not done here.

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree
I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.


remove heartbeats delay

Towards: https://github.com/giantswarm/giantswarm/issues/26770
This PR removes the delay before sending heartbeat alerts.
Means as soon as prometheus is up and ready it sends heartbeats, instead of waiting for 10 extra minutes.
Checklist

[x] Update CHANGELOG.md
[ ] Add Unit tests
[ ] Follow Alert structure
[ ] Consider creating a dashboard (guidelines) (if it does not exist already) to help oncallers monitor the status of the issue.
[ ] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).

Why do you think this makes sense? Will we not then bé unaware that prometheus is crashing in a loop?

Why do you think this makes sense? Will we not then bé unaware that prometheus is crashing in a loop?

There's 2 different cases why prometheus could be crashing in a loop:

crashing when reading WAL. In this case, it does not become ready, and does not send heartbeat.
crashing after being ready, like when receiving data from agent. In this case, the 10min delay is arbitrary, and I'm not even sure we're catching it in a consistent way today. We should create SLO rules for this.

Anyway I'm looking for a series of patches in different directions to reduce "false" heartbeat alarms, and this one looked like the easiest to implement.
Maybe we should do an SLO rule before though.

Sure thing. Then let's try this for a week and check the dashboard showing prometheus availability which is what we should use as an slo in my opinion. If we can reduce oncall alerts for now while keeping the same feature it's fine with me

We cannot release till one prometheus-rule is fixed though

This https://gigantic.slack.com/archives/C020E38NGTZ/p1682676925792619?thread_ts=1682676716.862719&cid=C020E38NGTZ
Should become https://gigantic.slack.com/archives/C020E38NGTZ/p1682677181541959?thread_ts=1682676716.862719&cid=C020E38NGTZ but I did not have time friday to fix it


Bug/heron-helm

fixes for bugs mentioned here: https://github.com/apache/incubator-heron/issues/3288
Not sure if this is exactly how you want the fixes implemented, but at least want to start the conversation.

There might be more packages that have issues with org.apache vs com.twitter, not sure if this issue is fixed somewhere else.
Using heron image for bookie init container since it has nc and its already used for zookeeper and tools yamls, fix string comparison
Changed data-disk to ledgers-disk, could go other way

Is this still WIP?

I think that covers the bugs I had, I removed the WIP. I did notice that the nc command takes a while to timeout, so might be worth adding a -w for the nc commands to make bookie/the tools init containers(wait-for-zookeeper.sh uses nc) come up faster, but not technically a bug since they do eventually come up. I'll add a separate pull for some of the features I wanted when I get a chance.

Cool. Thx.


test: changes to cypress test components functions

changing function names to use camel case
removing support file entry from cypress config
and moving navigation functions inside the model page file

:tada: This PR is included in version 0.292.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Prime Business Spaces: Elan The Mark, Gurgaon

Discover the ultimate business destination at Elan The Mark in Gurgaon. Renowned as the best Elan commercial project, it offers top-notch amenities and strategic location for success. Elevate your business in a dynamic environment designed for growth and prosperity. With prime spaces tailored to meet your needs, unlock the potential for unparalleled success at Elan The Mark in Gurgaon.

Experience the Essence of Luxurious Living with 2 BHK Flat in Gurgaon at M3M Antalya Hills! Located in the heart of Gurgaon, this residential marvel offers a perfect blend of comfort and sophistication. Immerse yourself in a world of modern amenities and scenic landscapes, promising a lifestyle of tranquility and opulence. Your dream of owning a lavish 2 BHK flat in Gurgaon awaits at M3M Antalya Hills.Experience the Essence of Luxurious Living with 2 BHK Flat in Gurgaon at M3M Antalya Hills! Located in the heart of Gurgaon, this residential marvel offers a perfect blend of comfort and sophistication. Immerse yourself in a world of modern amenities and scenic landscapes, promising a lifestyle of tranquility and opulence. Your dream of owning a lavish 2 BHK flat in Gurgaon awaits at M3M Antalya Hills.

Discover your perfect abode at M3M Antalya Hills, situated in Sector 79, Gurgaon. "Find Your Bliss" encapsulates the essence of this serene residential project by M3M Properties Gurgaon. Experience tranquility amidst lush landscapes and modern amenities. Embrace a lifestyle of comfort and joy, where every moment is filled with bliss. Make M3M Antalya Hills your sanctuary, where dreams meet reality in the heart of Gurgaon.


Datadir Problems Patch

Addresses: https://github.com/jswhit/pyproj/issues/176

Should we get a 2.0.1 release out soon with this fix?

@jswhit, yes I think getting this patch out sooner than later would be good. I just removed the change causing the build issues and targeted the exact fix. Should be good to merge when the build passes.

It passes and is ready to merge.


Fix: update nacosWatch doc

Describe what this PR does / why we need it
Update nacosWatch doc
Does this pull request fix one issue?
Related issue #2868

LGTM, thanks @ruansheng8

Don't forget to create a same PR to branch of 2.2.x.

Don't forget to create a same PR to branch of 2.2.x.

This commit is already included in #2904

Don't forget to create a same PR to branch of 2.2.x.

This commit is already included in #2904

Great!


Chess: Move E1 to D2

Please do not change the title. Just click "Submit new issue".

@tmchuynh done! Successfully played move e1d2 for current game.
Thanks for playing!


Add android support, that uses new swift-foundation for Android

Requires https://github.com/apple/swift-foundation/pull/757

@swift-ci please test

Supersedes https://github.com/apple/swift-corelibs-foundation/pull/4994

CC @parkera

@hyp Android support is not part of Swift 6, correct?

This depends on https://github.com/apple/swift-foundation/pull/714 now.

@parkera  Sorry for the late reply! Android overlay support is included in Swift 6, so this should be taken into Swift 6 as well.

@swift-ci please test

@swift-ci please test

Which swift-foundation change does this rely on now?

None, as the one he opened is now obsolete. However, I have proposed further changes to this pull in hyp#1 and haven't gotten any response.

@compnerd can you help with this one?

@hyp, any reason this is just sitting here? I can submit these commits and mine from hyp#1 separately if you don't have time for this.

Ping @hyp, I've been using a version of this pull along with my own modifications on my Android CI. I think we should go ahead with some version of this.
If you're unable to work on this pull further, I can rebase this pull, add my own mods, and submit it in another pull.
Let us know what you'd like to do.

Working on merging this in

@swift-ci please test

testing a merge first, need to rebase it again though

@swift-ci please test

@swift-ci please test

@swift-ci please test windows platform

@swift-ci please test

There was a change missing related to turning off WMO for a windows host but now it's fixed too. Should be ready to merge (pending windows CI too 🤞 )

@swift-ci please test windows platform

@swift-ci please test

@swift-ci please test windows platform

@swift-ci please test

Great to see this land!
@finagolfin, does this mean that we'll be able to drop swift-android.patch for trunk? Or will it need to be split up into separate patches, since the modifications to, e.g., build-script-impl are not covered by this PR?

The latter, because this is applied to all three Swift 6 release branches on my CI and this pull only got it into trunk.


GIDSignIn complains that it's uiDelegate doesn't implement GIDSignInUIDelegate

I have a class that implements GIDSignInUIDelegate. When I set GIDSignIn's uiDelegate to said class, I get an exception stating the following:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'uiDelegate must either be a |UIViewController| or implement the |signIn:presentViewController:| and |signIn:dismissViewController:| methods from |GIDSignInUIDelegate|.'
These methods are implemented in my class, therefore I'm assuming that the class needs to implement GIDSignInUIDelegate AND be a UIViewController, not OR.

@Rajveer86  @Rajveer86 God damn, I have got the same issue! Is there any workaround? Did you solve it?
I've implemented  GIDSignInUIDelegate in my not-view-controller class (which is only NSObject).
I call this code im my class init() method:
GIDSignIn.sharedInstance().clientID = "MY_GOOGLE_ID"
GIDSignIn.sharedInstance().uiDelegate = self
GIDSignIn.sharedInstance().delegate = self
When I try to call  GIDSignIn.sharedInstance().signIn()  in other method of this class, I get crash
'uiDelegate must either be a |UIViewController| or implement the |signIn:presentViewController:| and |signIn:dismissViewController:| methods from |GIDSignInUIDelegate|.'
My class is public, but to implement  GIDSignInUIDelegate in it I had to mark those delegate methods internal or private. Maybe this is the problem?
When my class wasn't public I was able to login via Google once using this class... And now it just crashes.

@Rajveer86  @rhys-edwards
I've solved my problem.
In my case the access modifiers broke my implementations, and since all method in GIDSignInUIDelegate are optionals Swift compiler wasn't complained about all its methods implementation.
Be careful with access modifiers.
And I think that those methods must be required:

(void)signIn:(GIDSignIn *)signIn presentViewController:(UIViewController *)viewController;
(void)signIn:(GIDSignIn *)signIn dismissViewController:(UIViewController *)viewController;

because if you haven't implemented them your application will crash.

add this "[GIDSignIn sharedInstance].presentingViewController=self;" it can solved this problem.

أضف هذا "[GIDSignIn sharedInstance] .presentingViewController = self؛" يمكن أن تحل هذه المشكلة.

What is that


Redis Command getting executed twice

Expected behavior
Any command or LUA script executed using jedisCluster client should get executed only once on redis.
Actual behavior
We have seen few instances where we have tried to execute evalSha command using jedisCluster, that LUA script has got executed twice on redis.
Steps to reproduce:
Unable to reproduce. But have seen this happen sporadically in production. No exception seen in logs.
Redis / Jedis Configuration
Redis configuration - v3.2.1, cluster: 8 master, 8 slave (121 mapping between master and slave)
Jedis version - 2.8.1
Pool configuration - Using GenericObjectPoolConfig. MinIdle=128, MaxIdle=128, MaxTotal=128. Other attributes are default.
Java version: 1.8.0_72

@AgarwalR3 thx for reporting. We'll leave this open in case someone encounters the same situation. If you manage to get a reproducible use-case please let us know!.

Hi @marcosnils, offlate we have been also seeing similar issue a couple of times on production. We are using Jedis 2.8.1 with redis 3.2.1 cluster. Under high load of around 4k operations/sec per node, we have observed that for sudden very short streaks of time, redis operations become very slow and few commands for eg. evalsha,hmset executed during those period tend to get executed twice. Around those period, we have also found the following exception in the logs-
Could not return the resource to the pool
redis.clients.jedis.exceptions.JedisException: Could not return the resource to the pool
at redis.clients.util.Pool.returnBrokenResourceObject(Pool.java:103)
at redis.clients.jedis.JedisPool.returnBrokenResource(JedisPool.java:112)
at redis.clients.jedis.JedisPool.returnBrokenResource(JedisPool.java:12)
at redis.clients.jedis.Jedis.close(Jedis.java:3355)
at redis.clients.jedis.JedisClusterCommand.releaseConnection(JedisClusterCommand.java:160)
at redis.clients.jedis.JedisClusterCommand.runWithRetries(JedisClusterCommand.java:154)
at redis.clients.jedis.JedisClusterCommand.run(JedisClusterCommand.java:30)
at redis.clients.jedis.JedisCluster.pttl(JedisCluster.java:212)
at com.platform.utils.redis.RedisUtils.pttl(RedisUtils.java:161)
Caused by: java.lang.IllegalStateException: Invalidated object not currently part of this pool
at
org.apache.commons.pool2.impl.GenericObjectPool.invalidateObject(GenericObjectPool.java:640)
at redis.clients.util.Pool.returnBrokenResourceObject(Pool.java:101)
... 23 more
at redis.clients.jedis.JedisClusterCommand.releaseConnection(JedisClusterCommand.java:160)
at redis.clients.jedis.JedisClusterCommand.runWithRetries(JedisClusterCommand.java:154)
at redis.clients.jedis.JedisClusterCommand.run(JedisClusterCommand.java:30)
at redis.clients.jedis.JedisCluster.hmget(JedisCluster.java:422)
We have tried reproducing this issue under high load in test environment but have been unable to do so.
Thanks!

hi @anandsaha87 thx for providing further info. I'll try to run some quick examples to reproduce.

@marcosnils  I'm guessing that for commands to be executed twice, data must be sent through the socket twice. Do we currently have such "recovery" behavior in the codebase that can cause commands to be re-sent ? it's a good place to start looking...

Caused by: java.lang.IllegalStateException: Invalidated object not currently part of this pool?

. Do we currently have such "recovery" behavior in the codebase that can cause commands to be re-sent ? it's a good place to start looking...

not that I'm aware of.


Complete: Anjana: Task 81-85: Clickbait_news_bg and TriviaQA datsets

@aarunku5, wondering if you can help review this PR?

Make sure you update the readme file according to the comments given where necessary.
For augmenting the definitions for tasks 81-83, since it's a different language put it through translate in order to get the relevant details.
Also run the definition and explanations through Grammarly before resubmitting.
81
In the definition, modify to "In this task you are given a passage as the input content in the ___ language. You are expected to generate a suitable title for the passage."
You also need to write another sentence about any constraints in the output. Like what constitutes the title? Is it words from the story or a generic title? How many words max? Check the sample tasks provided to you from squad. Modify your defnition to be specific about the details of input and output generated. Also make sure you write in complete sentences, with proper punctuation.
The same goes for your explanations- they need to be complete sentences, with proper grammar and punctuation. You also need to be able to say why they are correct/incorrect. Is the title not relevant? Does it contain no words from the passage? Those kinds of things.
82
Refer to comments on 81's definition.  Also the task category  is answer generation if you are calculating it and not selecting from provided options. Change that, change the task name, and update the readme file as well.
If there is a method of picking particular words or sentences for the fake news score, you need to include that as part of the explanation to justify why the score is correct/incorrect.
83
Same comments about definition and explanation as 82. The category is again answer generation here.
84
Minor grammatical errors in definition. Also split the first sentence into two, it's not clear at first glance.
Put a comma between the question text's end and search result label for all examples and instances to make it more readable.
85
Make the category classification. Specify in the defn that they can choose a or b as the answer, and modify output to be a or b.
Put a comma between question, options, search result in the input.

@amulyaarunb, can you address reviewer comments so that I can evaluate your HW?

@swarooprm, Can I get some time to address the comments by the reviewer? There are a lot of points mentioned, and it is taking a lot of time to address everything.

@aarunku5 I have made all the changes you have asked me to do, with respect to the review.
However, with respect to how the fake_news_score and click_bait_score are calculated, there is no information provided. I have read through the entire research paper associated with the article but they have not provided any details on how these values are calculated. In the paper, they used neural networks and different architectures to generate the scores for an unseen passage, based on a huge dataset of passages and corresponding scores.
All other changes have been made as per the comments provided

@swarooprm can you check tasks 82, 83? The rest look good.

Your HW2 is complete now.
Would you like to submit the same tasks to our big project repo https://github.com/allenai/natural-instructions-expansion/pulls? You just need to fork that repo, rename tasks starting from the latest number in the repo and create PR there. This way, you can be part of our research on "learning from instructions instead of learning from examples (conventional machine learning)". This is purely optional and your HW2 grade does not depend on this @amulyaarunb

@amulyaarunb Just a reminder that, if you plan to submit these tasks to the main Github repo and join our research project, Monday (27th Sept) is the deadline. Again, this is optional and independent of your HW2 grade.


look at a failing jest test

https://github.com/inaturalist/iNaturalistReactNative/tree/failing-jest-test demonstrates a consistently failing test that we should figure out

@albullington, https://github.com/inaturalist/iNaturalistReactNative/commit/5635936d384b603b6c03da299e758b71d0bb1474 addresses the test failure in that branch. FWIW, the main problem seemed to be the use of useCallback. I think the problem was that useCallback was storing a stable function that returned a new component every time it was called, so the SuggestionsFooter was constantly getting recreated. useMemo memoizes the return value itself, i.e. the component (which, confusingly, is itself a function, of course, thank you React).
A slightly less significant problem in that branch was the use of queryBy instead of findBy. findBy is going to be a little bit safer in complicated situations like integration tests where we're not 100% sure the things we're looking for exists at the moment we look for it.
Does this address the issue? Would you like me to merge that branch?

Ah, interesting find and good learnings here about useCallback and findBy. Yeah, that addresses the issue -- I can see PhotoDeletion tests passing instead of the unmounted node error -- and would be great to merge.


adding port 0 call to validNets listen test

Changing the listen call to use port 0 to grab an available port, the current code doesn't work on alpine linux in a container. This small change fixes it and I don't see a reason it would break other use cases assuming the Go source code is correct:

If laddr has a port of 0, ListenTCP will choose an available port.

Example of this breaking:

cloud_sql_proxy -dir=/cloudsql -instances=PROJECT:us-central1:INSTANCE=tcp:3306 -credential_file=/account.json
2016/04/26 20:20:56 errors parsing config:
invalid "PROJECT:us-central1:INSTANCE=tcp:3306": unrecognized network tcp

Thanks for the merge request! I swear I checked whether passing 0 was okay.


[libSyntax] Support parsing type-identifier

CC: @nkcsgexi

The first commit is for split token.
Previously, the split token was always tokenized as tok::oper_binary_unspaced.
We wan't to specify the kind of token.
The second commit is the main commit on this PR.
It uses SyntaxBuilder for building libSyntax nodes.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test


Estimated age doesn't make sense as, as time passes this changes

https://github.com/openhie/cares-covid-ig/blob/36521e0e0f13772cab03acb94bf964d8a777a458/input/fsh/profiles.fsh#L115
birthDate is allowed to have missing values so I think we can capture and estimated date by just providing a year for example - https://hl7.org/fhir/patient-definitions.html#Patient.birthDate

this has been communicated, will be removed today


 Kotlin's coroutines should be the proper means to speed up this process.

The commit 03c9b62d53c87789c877f925539de9ce03554da7 fixing this might have introduced a thread-safety issue. Reassigning a local variable (here filteredLanguages) concurrently from different threads is not safe, see this StackOverflow answer.


test/i18n: enforce regex translations at test time

This is working towards #1306.
Previously, the find missing translations script found these (although
it apparently missed some) and would not block merging in new errors.
This PR moves the regex translation to the test code, so npm run test
and github workflows will complain if they are missing.  As there are
now no more errors in this department after this PR, we can ratchet this
fixed so the followup can proceed.
The next steps here are to add code to popup-text to use replaceSync to
do the translation (if there are no locale regexes like netRegexDe).  For
backwards compat, the locale regexes will always be valid (and will
override this translation) in case any user triggers are using them in
weird ways.  However, once that it done we can deprecate locale regexes
and remove them from the documentation and triggers.

cc @Akurosia @valarnin because we've talked about #1306

@Akurosia can you take a look at the translations? It seems like there's inconsistencies in Haukke Manor and t1, in terms of the replace section and the trigger regexes.  It seems like find missing translations didn't find these before because these files didn't have a timeline, and this check was in the timeline test.

should these inconsistent translations be shown when running npm run find-translations -- -l=de -f=ui ? because atm i only get a few results from my latest PRs (that are not merged with this branch here)

also i had a look at these, and do we need .*? in the end of a addedCombatant/ message ?

should these inconsistent translations be shown when running npm run find-translations -- -l=de -f=ui ? because atm i only get a few results from my latest PRs (that are not merged with this branch here)

No, it's merged into test, so you'll get errors when you run npm run test or via the github workflow rather than needing an extra script to do it.

also i had a look at these, and do we need .*? in the end of a addedCombatant message ?

You shouldn't.

Ok maybe i misunderstood something, but i ran both find-translation and test and non of them showed any issues (see screenshot attached). I will go through all ARR and HW files to see if there are any .*? for e.g. addedCombatants or any other inconsistency.

Sorry, I feel like there's some confusion here.  With this patch, there should not be any issues, as I fixed them.  I was mostly asking for you to take a look at the translations I changed in this PR to make it pass npm run test.  If you take this PR but then remove all the changes to ui/raidboss/data then it will have a bunch of failures.  However, I'm not sure those translations were correct as the timelineReplace did not agree with the netRegexFr (etc).
Re: addedCombatant.  I do not know why some of the lines in t1 have a .*? on the added combatant.  Maybe this can/should be removed here.  In general, addedCombatant should not have/need this.  I think this can be changed after this.

WAIT, I didn't see you were targeting this PR with your PR.  Was that intentional?


⚠ Turnos 24x7 has degraded performance

In 4590e06, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1544 ms

Resolved: Turnos 24x7 performance has improved in 3de5ca7.


updated username

PR Type: ___

Affiliation: N/A

Ticket: N/A

Checklist:

[x] I've read Contributing Guidelines
[x] I agree to follow the Code of Conduct

Thanks :)
For future reference, don't forget to also fill in the PR template (e.g. PR Type)

Okay. Sure :)


Remove redundant encoding in pinWithImageURL

Trying to resolve issue https://github.com/pinterest/ios-pdk/issues/142

@amyhametov this is going to be fixed within the Pinterest app, that way nobody using the PDK will need to update the version of the PDK they're using.
https://github.com/pinterest/ios-pdk/issues/142#issuecomment-312326842


workflows: Use new test-repository features

Use three new features of test-repository:

update_base_url

During publish workflow we want to test that a client can update from current GCS (tuf-repo.cdn.sigstage.dev) to Pages
(sigstore.github.io/root-signing-staging/).
This test is done during cron runs as well but then it's usually not relevant (as the repos contents typically match).

valid_days

We want a failure if either Pages or GCS repository is invalid in 3 days.
Note: sigstore-probers alerts when repository is invalid in 2 days

offline_valid_days

We want a failure if root or targets in either Pages or GCS repository expires within 30 days.
Note: sigstore-probers alerts when offline roles expire in 15 days

Fixes #94
I have test runs:

test.yml:
# Run tuf-on-ci test client
Testing repository at metadata-url https://sigstore.github.io/root-signing-staging/, artifact-url https://sigstore.github.io/root-signing-staging/targets/
Client metadata update from base url https://tuf-repo-cdn.sigstage.dev/: OK
Client metadata update from https://sigstore.github.io/root-signing-staging/ at reference time 2024-04-12 11:46:32: OK
Client metadata matches sources: OK
Role root is valid on 2024-05-09 11:46:32: OK
Role targets is valid on 2024-05-09 11:46:32: OK

gcs-test.yml
# Run tuf-on-ci test client
Testing repository at metadata-url https://tuf-repo-cdn.sigstage.dev/, artifact-url https://tuf-repo-cdn.sigstage.dev/targets/
Client metadata update from https://tuf-repo-cdn.sigstage.dev/ at reference time 2024-04-12 11:46:57: OK
Client metadata matches sources: OK
Role root is valid on 2024-05-09 11:46:57: OK
Role targets is valid on 2024-05-09 11:46:57: OK

This sort of setup is what I will propose for sigstore-prober as well, but let's test it here first so oncall isn't bothered...


Room names with slashes in them ("/") causes the app to break

Room names with "/" in them messes the call to backend server. For e.g., if room name == "event/room1", the server thinks we're making a "GET" request to the route event/room1 instead of the standard /:roomID dynamic route

This is fixed in the new extension #98


Add wrapping logging class

Add a class that allows us to wrap existing log functions with ones that will add various arguments specified when we create the class.

Ready for review.

Left one comment, otherwise looks good.
Guessing the Travis errors are unrelated?

Travis errors were unrelated. A restart fixed them.
@hodgestar I addressed your comment. Ready for review again.

:+1:


Replace the android.defaultConfig.applicationId in build.gradle with the package/unique_name

Fix #33838.
This is done by passing the package/unique_name to the gradle build as a project property during build time.

Thanks!


Extraneous test requirements in runtime requirements

The runtime requirements include pytest, but that is not used at runtime, and seems extraneous.

Thanks for the report! Yes, pytest is what we use on our testing suite. @jorisvandenbossche maybe we could move that to requirements_dev instead? If memory serves, I put everything on one file as it was easier to get the project off the ground, but would be happy to split.

I don't think this is still the case? https://github.com/darribas/contextily/blob/master/requirements.txt
@QuLogic Are you using a version from PyPI, or from github master?

Ah, from PyPI yes, it does appear to have changed on master.


Sample “LowLatencyMRC” audio

Hello,
in the code I enabled "audio" flag but not works.
Do you have any advice?
Thank you

Hello,
@AlexKossi there is a enableAudio flag in the . But as @86simonepenna I was not able to make it work, when I enable audio the connection the stream is closed immediately.

Yes :-(

In the code of PlaybackEngine there is a note on line 185

  // config the source for Video only
  // TODO: support audio¨

May I ask @86simonepenna, whether had you solved the audio stream some other way?

No, I'm implementing a new method audio and video but for now i have very higth latency.