No mention to the "FeatureMask" field in the Subject description

When adding a subject, the user can define if the value is hidden with Feature Mask, it is not mentioned in the document

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b10ea23f-970e-6831-b18f-4af29e17de25
Version Independent ID: 890c06d6-7b65-455f-95df-e71eba36494e
Content: Define subjects to categorize cases, products, and articles - Power Platform
Content Source: power-platform/admin/define-subjects-categorize-cases-products-articles.md
Service: power-platform
Sub-service: admin
GitHub Login: @shubhadaj
Microsoft Alias: shujoshi

Thanks for your comment, @Laurent-riet. This issue has been assigned to the doc author for review.


speed up calculate_auc_values()

As mentioned in issue #15, the code for AUROC can be more efficient.
This commit improves the calculate_auc_values() function so that it runs
more quickly:
145k cells, 28k genes, and 23 clusters
Before: 1044 seconds running on 8 threads
After:   325 seconds running on 1 thread

Before, the code was using parallel processing to repeat redundant
calculations independently for each cluster.
After, the code uses a single thread and does fewer redundant
calculations.
To reduce the complexity of the algorithm, I deleted the part
that deals with cond_labels, but it can be added back in.
To do:

[x] Add support for cond_labels again.
[x] Learn from the presto R package how to run 10 times more efficiently.

More details
The underlying idea is that some intermediate values can be computed
once, saved, and then reused multiple times.
For example, it is necessary to sort and rank each gene to compute the
AUROC and the Wilcoxon rank sum test p-value.
It is inefficient to sort and rank each gene N times for N clusters.
A more efficient approach is to sort and rank each gene once. Then,
those ranks can be accessed multiple times to compute the statistics for
N clusters.

I tested Kamil's modification on MantonBM_nonmix dataset on my macOS. It took 598.04s in AUC step, comparing with Pegasus 8-thread's 1833.88s. And the result in adata.varm['de_res'] remains the same.
The command-line tool doesn't need to support condition argument, but interactive API needs it.

I made one more change in cef9fb8 and now the time is down from 325 to 138 seconds.

I believe the Python code is now as efficient as the presto R package code.
Regarding the condition argument, I have a question. Is it true that the purpose of this argument is to answer the question:

Is expression predictive of a binary vector within each cluster?

If that is true, then it seems to me that we can run the new AUROC code separately on the expression matrix that corresponds to each cluster. This should be a fast way to support the condition argument.
Could I please ask if this is the right interpretation?

OK, I think I'm finished working on this pull request. I would be delighted to hear your comments.
On my data with 145k cells, 28k genes, and 23 clusters:

27 seconds for regular AUROC
58 seconds for conditional AUROC within each cluster

Hi Kamil,
Thanks so much for working on this. I'll take a look and merge it into
Pegasus this week.
Thanks,
Bo
Bo Li, Ph.D.
Director, Bioinformatics and Computational Biology Program, Center for
Immunology and Inflammatory Diseases, Massachusetts General Hospital
Member of the Faculty, Harvard Medical School
Associated Scientist, Klarman Cell Observatory, Broad Institute of MIT &
Harvard
149 13th Street, Room 8214, Charlestown, MA 02129
On Mon, Dec 16, 2019 at 10:01 PM Kamil Slowikowski<EMAIL_ADDRESS>wrote:

OK, I think I'm finished working on this pull request. I would be
delighted to hear your comments.
On my data with 145k cells, 28k genes, and 23 clusters:

27 seconds for regular AUROC
58 seconds for conditional AUROC within each cluster

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/klarman-cell-observatory/pegasus/pull/16?email_source=notifications&email_token=ACPHRF5T7MLTBDBTJRUWEULQZA6IXA5CNFSM4J254KR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHA7DDY#issuecomment-566358415,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPHRF5SNGOPO5F7VO6RU3TQZA6IXANCNFSM4J254KRQ
.

Hi Bo,
It seems like we might want to activate some tests so we automatically know that the pull request does not break anything.
Let me know if you need help to get the tests up and running again.
(Anyway, I already tested this code, so it would be surprising to me if it fails any tests.)

Just to clear up a bit of confusion...
pegasus depends on GPL packages:

https://pypi.org/project/louvain/
https://pypi.org/project/python-igraph/
https://pypi.org/project/forceatlas2-python/

So, it seems like it might have been reasonable to make a python package that is a translation of the presto R package, and then add that as a dependency.
Anyway, I guess this isn't relevant anymore, considering that the differential expression analysis code has been updated in pegasus 1.0.0.

By the way, I think it is OK for a BSD package to depend on a GPL package.
For example, matplotlib (custom BSD-like license) depends on PyQT4 (GPL):
https://github.com/matplotlib/matplotlib/blob/dbae370733f2bfd7b616bf1972294a2eff020747/lib/matplotlib/backends/qt_compat.py#L116


How can we use Dojo Toolkit offline instead of online dependency

I have been trying to use this application without internet connectivity but unable to do the same. I am not getting any altenative for Dojo Toolkit for offline applications. Can you please help me regarding the same.

to host the application without an internet connection you'd need to install the entire ArcGIS API for JavaScript behind your firewall.
https://developers.arcgis.com/downloads/apis-and-sdks?product=javascript

I tried doing as per what you have said but I am getting this error

I have done as per the suggestion but still I am getting this error.

I have done as per the suggestion but still getting this error.


[Grid2, styled-components] React does not recognize the ownerState prop on a DOM element

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
Steps:

Go to https://codesandbox.io/s/styled-components-forked-jj0gfv?file=/src/demo.js
Open console tab
See error

Current behavior 😯
Error
Warning: React does not recognize the `ownerState` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `ownerstate` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at div
    at O (https://jj0gfv.csb.app/node_modules/styled-components/dist/styled-components.browser.esm.js:666:7)
    at Grid (https://jj0gfv.csb.app/node_modules/@mui/system/esm/Unstable_Grid/createGrid.js:55:40)
    at div
    at O (https://jj0gfv.csb.app/node_modules/styled-components/dist/styled-components.browser.esm.js:666:7)
    at Grid (https://jj0gfv.csb.app/node_modules/@mui/system/esm/Unstable_Grid/createGrid.js:55:40)
    at div
    at StyledComponents

Expected behavior 🤔
The same example as above does not print the error when used with the old Grid component.
Context 🔦
The same error has been reported in https://github.com/mui/material-ui/issues/35643, and https://github.com/mui/material-ui/issues/35309, but this scenario differs slightly: Here the component prop is not being used, and the styled-components engine is used.
I am not sure if the solution proposed in https://github.com/mui/material-ui/issues/32882#issuecomment-1135784140 applies as the component prop is not being used.
 Almost all components giving warning about ownerState. Any solution?
styled-components: it looks like an unknown prop "ownerState" is being sent through to the DOM, which will likely trigger a React console error. If you would like automatic filtering of unknown props, you can opt-into that behavior via `<StyleSheetManager shouldForwardProp={...}>` (connect an API like `@emotion/is-prop-valid`) or consider using transient props (`$` prefix for automatic filtering.)
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at NotchedOutline (http://localhost:3003/node_modules/.vite/deps/chunk-DO7F7SUR.js?v=42291977:1651:5)
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at div
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at InputBase2 (http://localhost:3003/node_modules/.vite/deps/chunk-DO7F7SUR.js?v=42291977:331:17)
    at OutlinedInput2 (http://localhost:3003/node_modules/.vite/deps/chunk-DO7F7SUR.js?v=42291977:1822:17)
    at div
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at FormControl2 (http://localhost:3003/node_modules/.vite/deps/chunk-DO7F7SUR.js?v=42291977:2480:17)
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at TextField2 (http://localhost:3003/node_modules/.vite/deps/chunk-DO7F7SUR.js?v=42291977:5143:17)
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at div
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at http://localhost:3003/src/lib/Input/Input.tsx?t=1695042217388:28:3
    at div
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at PersonalInfo (http://localhost:3003/src/views/personalInfo/PersonalInfo.tsx?t=1695042217388:34:7)
    at le (http://localhost:3003/node_modules/.vite/deps/react-use-intercom.js?v=42291977:92:24)
    at ProtectedRoute (http://localhost:3003/src/shared/containers/Content.tsx?t=1695042217388:105:3)
    at RenderedRoute (http://localhost:3003/node_modules/.vite/deps/react-router-dom.js?v=42291977:3327:5)
    at Outlet (http://localhost:3003/node_modules/.vite/deps/react-router-dom.js?v=42291977:3720:26)
    at Settings (http://localhost:3003/src/views/settings/Settings.tsx:29:7)
    at ProductStatusProvider (http://localhost:3003/src/contexts/productStatus.context.tsx:31:3)
    at div
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at div
    at O2 (http://localhost:3003/node_modules/.vite/deps/chunk-YJJLW5UR.js?v=42291977:1254:6)
    at UnauthorizedRoutesContainer (http://localhost:3003/src/shared/containers/UnauthorizedRoutesContainer.tsx?t=1695036077699:30:3)
    at le (http://localhost:3003/node_modules/.vite/deps/react-use-intercom.js?v=42291977:92:24)
    at ProtectedRoute (http://localhost:3003/src/shared/containers/Content.tsx?t=1695042217388:105:3)
    at RenderedRoute (http://localhost:3003/node_modules/.vite/deps/react-router-dom.js?v=42291977:3327:5)
    at Routes (http://localhost:3003/node_modules/.vite/deps/react-router-dom.js?v=42291977:3780:5)
    at Content (http://localhost:3003/src/shared/containers/Content.tsx?t=1695042217388:129:3)
    at Suspense
    at CustomErrorBoundary (http://localhost:3003/src/components/errorBoundary/ErrorBoundary.tsx?t=1695036077699:6:5)
    at ToastProvider (http://localhost:3003/src/contexts/notification.context.tsx?t=1695036077699:38:3)
    at I18nextProvider (http://localhost:3003/node_modules/.vite/deps/react-i18next.js?v=42291977:791:5)
    at TextsProvider (http://localhost:3003/src/contexts/texts.context.tsx?t=1695036077699:55:3)
    at ThemeProvider (http://localhost:3003/node_modules/.vite/deps/chunk-PBWFQ6HJ.js?v=42291977:2138:5)
    at ThemeProvider2 (http://localhost:3003/node_modules/.vite/deps/chunk-PBWFQ6HJ.js?v=42291977:2197:5)
    at ThemeProvider (http://localhost:3003/node_modules/.vite/deps/chunk-A6L7DZ5C.js?v=42291977:268:12)
    at Theming (http://localhost:3003/src/assets/styles/Theming.tsx:21:3)
    at App (http://localhost:3003/src/App.tsx?t=1695042217388:46:20)
    at Router (http://localhost:3003/node_modules/.vite/deps/react-router-dom.js?v=42291977:3727:15)
    at HistoryRouter (http://localhost:3003/node_modules/.vite/deps/react-router-dom.js?v=42291977:4275:5)
    at Provider (http://localhost:3003/node_modules/.vite/deps/react-redux.js?v=42291977:1038:3)
    at ErrorBoundary2 (http://localhost:3003/node_modules/.vite/deps/@rollbar_react.js?v=42291977:305:5)
    at Provider2 (http://localhost:3003/node_modules/.vite/deps/@rollbar_react.js?v=42291977:242:5)

This is a workaround for the ownerState case but something even stranger is going on with inputComponent which is never seen by this function.
// Hack for MUI5 and StyledComponents 6.
const shouldNotForwardProp: string[] = ['inputComponent', 'inputProps', 'ownerState'];
const styledComponents6HackForMui5 = (prop: string): boolean => {
  return shouldNotForwardProp.indexOf(prop) === -1;
}

export const App = () => {
  return (
    <>
      <StyleSheetManager shouldForwardProp={styledComponents6HackForMui5} > {/* https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v6 */ }


__/auth/handler.js window.close after Google SignIn

I'm not sure this is an plugin issue, but after sign in with google using signInWithRedirect I'm getting blank page on google with this in console:
Scripts may close only the windows that were opened by it.

Screenshot below

Anyone?

Hi @wojtek1150, Please use stackoverflow for questions like this.


Question regarding NUM_CORES and NUM_THEADS

What is the motivation of dividing NUM_CORES by 4, why can't all available cpus be used?
get_num_cores()
{
   nproc_exist=$(which nproc)
   if [ ! -z "$nproc_exist" ];
   then
       NUM_CORES=$(nproc --all)
       echo "Num cores on a system: $NUM_CORES"
       if [ "$NUM_CORES" -gt 4 ]
       then
           NUM_THREADS=$(($NUM_CORES / 4))
           NUM_THREADS=-j$NUM_THREADS
       fi
else
    NUM_CORES=""
fi
}

Few instances observed a couple of hang issues especially when VM used as server for build procedure. Sometimes aggressive compilation causes random memory or other issues especially on VMs. Added additional check not to use all the cores available in physical server/VM which can avoid the aggressive parallel compilation.  It is just to minimize resources required for build procedures and to make sure scripts work for both physical and VM environments.

Thanks for the details @vsureshkumarp

If you would be so kind as to add the above (formalized) as a comment for get_num_cores() that would be much appreciated.
Can you add logic in which if these NUM_CORES and/or NUM_THREADS are already set in environment (export etc) then they shall be used explicitly by the script(s)?

One thing that might be happening with large numbers of parallel jobs is that they can consume a lot of RAM, and if you run out of RAM and swap, Linux has an OOM process killer that starts killing processes that consume significant memory.  You want to stay away from that.  Guaranteeing you stay away from that is not so simple to calculate in a script, though, except by being conservative in amount of make parallelism used.

Thanks for the details @vsureshkumarp

If you would be so kind as to add the above (formalized) as a comment for get_num_cores() that would be much appreciated.
Can you add logic in which if these NUM_CORES and/or NUM_THREADS are already set in environment (export etc) then they shall be used explicitly by the script(s)?

It would be easy to check if NUM_CORES and NUM_THREADS are already set and skip overriding them, I'll push a PR to do this. I'll also add a comment.


Migrate to WebView

The API vscode.previewHtml has been removed. So I modified code to migrate to new WebView API.

cool! will merge this soon

CI reported error. After fiddling around, the cause was an update of Ubuntu version of the CI container (/etc/init.d/xvfb was not found).
Now fixed.


I would like to create a Snake,Water & Gun game

I would like to develop a game where the user and the computer plays the snake water game and the computer selects the input randomly.please assign me this task

@Keegan-20 Assigned you the issue. Best of Luck ✨


because of mature process: check compatibility to latest php 7.0

Since PHP 7 is still maturing, it may be a good idea to check compatibility to latest available version of PHP 7 from time to time...
(this time 7.0.1 see http://www.php.net/ChangeLog-7.php)

7.0.1 is a minor release so is unlikely to introduce any new incompatibilities, but you're right that it's good to keep an eye on this stuff.

What @durzel said. If anything, we expect 7.0.* to be more compatible (less buggy) with point releases. Further compatibility breaks are to be expected from 7.1, and we will have an eye on it.


HBASE-26590 Hbase-client Meta lookup performance regression between h…

…base-1 and hbase-2 (#4008)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 27s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
4m 43s
branch-2.4 passed

+1 :green_heart:
compile
0m 34s
branch-2.4 passed

+1 :green_heart:
shadedjars
7m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 25s
the patch passed

+1 :green_heart:
compile
0m 34s
the patch passed

+1 :green_heart:
javac
0m 34s
the patch passed

+1 :green_heart:
shadedjars
7m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 38s
hbase-client in the patch passed.

34m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4012/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4012

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ed417749e988 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 53f8240b9f

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4012/1/testReport/

Max. process+thread count
305 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4012/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
9m 13s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
branch-2.4 passed

+1 :green_heart:
compile
0m 27s
branch-2.4 passed

+1 :green_heart:
shadedjars
6m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 37s
hbase-client in the patch passed.

35m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4012/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4012

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c021afafb398 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 53f8240b9f

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4012/1/testReport/

Max. process+thread count
232 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4012/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
branch-2.4 passed

+1 :green_heart:
compile
1m  4s
branch-2.4 passed

+1 :green_heart:
checkstyle
0m 33s
branch-2.4 passed

+1 :green_heart:
spotbugs
1m 12s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
checkstyle
0m 36s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 15s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

40m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4012/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4012

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 35c1043f111f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 53f8240b9f

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
96 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4012/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


System.BadImageFormatException: 'Bad IL format.'

Am working on code based on ZeroFormater Serializer where part of the serialization methodology is implemented by creating a dynamic method using IL Generator.
The implementation works on .Net Core 2.2 but not on 3
Are there any changes regarding how IL works-changes that might lead to this problem and how can it be resolved (have code to send but am waiting for your response)

Can you share a small example code that demonstrates the problem? Or at least some details about what IL is causing the issue? Without that, I think it would be really hard to tell what change introduced in .Net Core 3.0 is causing this.

src.zip
ByteAnalysis is the executing project. The IL generation happens on DynamicFormatter.cs, CreateSerialize method

@btogkas
OpCodes.Callvirt should be used instead of OpCodes.Call for IZeroFormatterSegment.Serialize.

@btogkas did @yyjdelete's note resolve your issue?

Please re-open with more info if you still need assistance. Thanks.


fixing tests failing on travis

Contributor Comments
There were several problems with these two tests. The time has to be mocked when we using actual time value (new Date()). There was also a 1-hour difference in the generated timestamp on Travis probably caused by daylight saving.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[ ] Have you included steps or a guide to how the change may be verified and tested manually?

[ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[ ] Have you written or updated unit tests and or integration tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

Looks good to me. Thanks!


Outdated rospy-reference

In section_1_introduction_and_tools/3_introduction_to_ros1.ipynb, the link to the publisher/subscriber implementation in rospy is outdated (see here). Instead, this link refers to the correct website.

Hi,
thanks for pointing that out. The link has probably changed over time.
Fixed with https://github.com/ika-rwth-aachen/acdc-notebooks/commit/10f0c8219a30346ddd9f8cf2170045de928d2e86
Best,
Till


Prow hackathon testing blockade plugin

What is this PR About?
Describe the contents of the PR
How do we test this?
Provide commands/steps to test this PR.
cc: @redhat-cop/day-in-the-life

/good-first-issue

/help


Discord.hx Compilation Error.

Hi, I've been trying to build Kade for a little mod I was making, however I keep getting this error when compiling, while I have the Discord Rpc library:
"source/Discord.hx:5: characters 8-30 : Type not found : discord_rpc.DiscordRpc
source/Discord.hx:14: characters 3-13 : Type not found : DiscordRpc
source/Discord.hx:24: characters 4-14 : Type not found : DiscordRpc
source/Discord.hx:29: characters 3-13 : Type not found : DiscordRpc
source/Discord.hx:34: characters 3-13 : Type not found : DiscordRpc
source/Discord.hx:39: characters 3-13 : Type not found : DiscordRpc
source/Discord.hx:75: characters 3-13 : Type not found : DiscordRpc"
Any way to fix this??

Make sure you installed all of the dependencies properly.


failed implementation check using CLI only

Hi,
So this seems like it's definitely an issue with my environment on a particular workstation and I'd like to know what might be causing it.
I have a lot of MKV files that fail the MKV implementation check on the CLI, but they pass the implementation check in the GUI of the latest snapshot. I'm tried 17.06 via homebrew and the latest snapshot as well. I installed mediaconch on a different workstation on CLI and GUI and the files pass the implementation check fine. So it seems that my particular environment is a bit messed up, perhaps the XML tools? Is there something else that I can check in my environment that could be causing this?
This is the error:
 -- EBML-ELEMENT-VALID-PARENT
 --    [fail:Colour is not a valid Parent Element of 15B7.]
 --     [/Segment[1]/Tracks[1]/TrackEntry[1]/Video[1]/Colour[1]/15B7[1] at bytes offset of 475]
 --    [fail:Colour is not a valid Parent Element of 15B8.]
 --     [/Segment[1]/Tracks[1]/TrackEntry[1]/Video[1]/Colour[1]/15B8[1] at bytes offset of 479]

and the full report from the CLI:
https://gist.github.com/kieranjol/8c90289b0cd18f798f0275e0c6632656

It may be due to the file analysis part is from an older version of MediaConch, and the updated tool did not rechecked the file, so the new fields are still unknown in the trace.
Can you test with  --force option?

AAAAAARG - thanks so much Jerome, that fixed it!
Cheers,
-Kieran.

That demonstrates that we need to have a better management of old analysis.


NEW SCENARIO

Description of Problem or Question
Made a scenario, it is here:
https://github.com/Crosisdepurger/Mansios/tree/master/MutantMadness
Valkyrie Version
2.4.06

I have added the scenario, apologies for the delay :).
I'll add to the statsheet when I get time at a pc


How to install cross compilation targets with no rustup?

Comment:
I've got an existing C/C++ project that already has cross compilation set up on Linux for Windows and Mac in conda environments.  I've now got a Rust project that links against some of my built libraries, and I want to cross-compile Rust in the same way.  Understandably, the conda installation of Rust you're providing here (thank you!) doesn't include rustup.  How do I get the targets I need to cross compile with if I don't have rustup?

After some digging, I figured out that there's conda packages for the different rust targets, labeled as rust-std-<target>.  Install those and that gets you the targets you need.


Adjust cumulative line

Adjust the display. of cumulative line so that the data is readable. Current display is not correct (se reference picture).
Acceptance criteria:

[ ] The cumulative line starts to display in the middle of the first bar and ends in the midpoint of the last bar.
[x] The cumulative line should remain responsive for screen size 450px and above.

The responsiveness is done, meaning that the line doesn't go outside of the chart.
We are facing some challenges, and would like guidance from Tibco, when adjusting the line so that it starts and ends in the middle of the first and last bars.

The responsiveness is done, meaning that the line doesn't go outside of the chart.
We are facing some challenges, and would like guidance from Tibco, when adjusting the line so that it starts and ends in the middle of the first and last bars.

The issue is obsolete in the new code refactor and handled in D3 instead.


Feature/leaderboard setup

messed up some of the commit history, will close this PR and push a new, clean one


Preliminary classification does not work for manually suggested disambiguations where the type attribute is missing

Steps to reproduce:
Run a file with e.g. 3 data rows (Book e.g.). Select the column which was classified and values disambiguated to at least to two different entities in total. Then adjust all disambiguations to something else for all cell values in that column (e.g. to some disambiguations in a different column, again having at least two different disambiguations in that column). Try re-executed.
What I would expect is that the class is adjusted based on the adjusted disambiguations. But there is an issue. If the entity is manually disambiguated, the standard "findEntityCandidates" method at kbproxy is not called (see below), but only the URI and label is obtained for that manually added disambiguation. As a result, the preliminary classification does not work correctly, because the preliminary disambiguated entities do not have "type" attributes (see below, it is null), so there are not types which may vote for classification. As a result, the algorithm probably randomly, or based on the web search, selects the classification.

Original class with all disambiguations changed:

Then re-rerun. As a result, the algorithm probably randomly, or based on the web search, selects the classification. In the case below, it even selected the predicate for classification:

@JanVana I think that the support from KBProxy is needed. My opinion:

myslím, že bych k tomu potřeboval podporu od KBProxy - nejlépe asi tak, že podobně, jako má metodu findEntityCandidates(String content) , která hledá entity podle labelu a při zadaném feedbacku už její volání vynecháváme, by měla ještě podobnou metodu, která by hledala přímo podle adresy resourcu, případně adresy + labelu (což bychom ji právě předali z feedbacku) a očekávalo by se, že najde jen jednu entitu, ale vrátí ji kompletní včetně nastavených atributů (a tím by zároveň i ověřila existenci entity z feedbacku v duchu úkolu #302)

Would it be possible to do it this way?

It is no problem to a method like that.

@JanVana please prepare such method (discuss with @josef-janousek if needed) and then assign to @josef-janousek  to finalize

Test is needed

Loading entities from Feedback (disamb.) adjusted - using the method for loading directly from KBProxy.
@JanVana @brodecva It seems that loading of attributes of entites works well, so pull request can be created.


About option "keep_aspect_ratio" in examples/object_detection.py

I followed the instruction here, then I got the following result and first figure:
$ python3 examples/object_detection.py --model='test_data/ssd_mobilenet_v1_fine_tuned_edgetpu.tflite' --label='test_data/pet_labels.txt' --input='test_data/pets.jpg' --keep_aspect_ratio
-----------------------------------------
german_shorthaired
score =  0.37109375
box =  [1762.1801829338074,<PHONE_NUMBER>974463, 2210.349624156952, 1173.771092295647]
-----------------------------------------
shiba_inu
score =  0.32421875
box =  [1916.2815427780151,<PHONE_NUMBER>467953, 2195.608711242676, 1104.3338206197534]
Please check  object_detection_result.jpg

I can see both two bounding boxes are assigned to the right dog.
Then I remove --keep_aspect_ratio form command line, which gave a better result.
$ python3 examples/object_detection.py --model='test_data/ssd_mobilenet_v1_fine_tuned_edgetpu.tflite' --label='test_data/pet_labels.txt' --input='test_data/pets.jpg' -----------------------------------------
staffordshire_bull_terrier
score =  0.37109375
box =  [712.9122591018677,<PHONE_NUMBER>3655167, 1122.5919842720032,<PHONE_NUMBER>427139]
-----------------------------------------
staffordshire_bull_terrier
score =  0.35546875
box =  [1831.8864297866821,<PHONE_NUMBER>970474, 2190.160117149353, 1146.7327305078506]
Please check  object_detection_result.jpg

@tongtybj Thanks for submitting the issue.
I believe this is most likely just due to the input images that was feed to the model during training  did not have paddings. You can check the option here and here


Unhandled Exception: Invalid argument(s): Failed to lookup symbol (dlsym(RTLD_DEFAULT, isar_connect_dart_api): symbol not found

022-01-12 15:27:30.198144+0800 Runner[16682:8571892] [VERBOSE-2:ui_dart_state.cc(209)] Unhandled Exception: Invalid argument(s): Failed to lookup symbol (dlsym(RTLD_DEFAULT, isar_connect_dart_api): symbol not found)
#0      DynamicLibrary.lookup (dart:ffi-patch/ffi_dynamic_library_patch.dart:31)
#1      IsarCoreBindings._isar_connect_dart_api_ptr (package:isar/src/native/bindings.dart:332)
#2      IsarCoreBindings._isar_connect_dart_api (package:isar/src/native/bindings.dart)
#3      IsarCoreBindings.isar_connect_dart_api (package:isar/src/native/bindings.dart)
#4      openIsarNative (package:isar/src/native/open.dart:26)

32/5000
Ios Debug mode can be initialized, but release mode fails to be initialized.
Version

Platform: iOS （iphone8p）
Flutter version: 2.14.3
Isar version: 1.0.5
Isar Generator version: 1.0.5

#169

@htsunshine did you find a solution?

No, I saw you pointed me to 169 issues.Ios Debug mode can be initialized, but release mode fails to be initialized.

Yes, I already fixed it on main. Will release a new version in the coming days 👍

Thank you

I want to know what you changed. I want to fix it first

I've got the same error with version 3.0.5 building for iOS. It works in debug mode but not in release.
IsarError: Could not initialize IsarCore library for processor architecture "ios_arm64". If you create a Flutter app, make sure to add isar_flutter_libs to your dependencies.
Invalid argument (s): Failed to lookup symbol 'isar_version': dism(RTLD_DEFAULT, isar_version): symbol not found


Update fvm api calls

Closes #???
Description

For contributor use:

[x] Targeted PR against master branch
[x] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the GitHub PR explorer
[x] Added appropriate labels

@pattyshack thank you so much for fvm.WithAuthorizationChecksEnabled and fvm.WithSequenceNumberCheckAndIncrementEnabled


Change build status gathering to prevent problems

Currently build status does not care about the build number when gathering status, this PR should fix cases where the API would consider a notebook image as incomplete despite there being a later successful build.

lgtm


Sketch Compilations and Optimization

@jkeskingvillage Can you just review that your parts did not get messed up by the merge conflict resolution?


On iPhone 7 - Safari - this is all I can open, no further links

Seems to be related to #155

@medied is this solved ?

Old


NPM package is still at version 0.1.2

Hey @kriskowal the tengwar package on npm is still at 0.1.2. https://www.npmjs.com/package/tengwar
Are you able to publish the updated version?

I’ve published 1.0.0 and 1.1.0 to npm.


display-info 0.4.9 breaks semver compatibility, please yank it

Since 0.4.9, the DisplayInfo struct no longer derives Copy, which is a breaking change. You may already be aware of this, as version 0.5.0 was recently released. Releasing a version with the correct number is good but not sufficient to prevent breakages. The erroneous version 0.4.9 must also be yanked.
Thank you in advance!

done


chore(main): release 1.0.4

:robot: I have created a release beep boop
1.0.4 (2023-01-16)
Miscellaneous 🧹

deps-dev: bump @typescript-eslint/eslint-plugin (4d21c40)
deps-dev: bump @typescript-eslint/parser from 5.48.1 to 5.48.2 (94710ce)
deps-dev: bump eslint from 8.31.0 to 8.32.0 (2a9e7b0)
deps-dev: bump prettier from 2.8.2 to 2.8.3 (645f234)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/paulschuberth/regex-extract-action/releases/tag/v1.0.4 :sunflower:


Improve completion in JLine3

JLine3 offers a completion API that allows applications to set not just the completion candidate strings, but also to group aliases together and show descriptions for candidate groups.
To avoid code duplication, it seems a good idea to keep the bulk of the logic in AutoComplete.complete. However, the current signature of that method is (taking a List<CharSequence> output parameter) is only suitable for JLine 2 and does not allow us to leverage the richer org.jline.reader.Candidate API. Consider adding a AutoComplete.complete method that takes a ICompletionVisitor.
Something like this:
interface ICompletionVisitor<T> {
    /** Add completion candidates for arguments following the specified command. */
    void completeCommand(CommandSpec command, T userObject);

    /** Add completion candidates for arguments following the specified option. */
    void completeOption(OptionSpec option, T userObject);

    /** Add completion candidates for arguments in the specified position. */
    void completePositional(PositionalParamSpec positional, T userObject);
}

For the JLine2 completer, we can have a visitor where the user object is a List<CharSequence>, and for the JLine 3 completer it can be a List<org.jline.reader.Candidate>.

Superceded by #888 and delivered in picoci 4.1.2.


Use zeroex liquidity in http solver

Fixes #1663
Added basic machinery to utilize 0x limit orders as liquidity.
For that a new type of liquidity was introduced Liquidity::LimitOrder(LimitOrder) which is just a wrapper around our usual LimitOrder type.
Also ZeroExInteraction was added which just generates call data for IZeroEx::fillOrKillLimitOrder() as its encoding strategy.
The http solver takes advantage of the new liquidity limit orders by adding them to the list of solvable orders of the auction.
Note that the Baseline solver does not take advantage of the new liquidity yet.
Test Plan
Manual test where I ran the driver locally configured to use quasimodo until a winning settlement was found which included a ZeroExInteraction. (call stack includes fillOrKillLimitOrder())
I didn't add a unit test for generating the call data (as opposed to other interactions) because this is done with a crate which is hopefully properly tested.
Release notes
Added liquidity of 0x limit orders to quasimodo

Codecov Report

Merging #1710 (bd51625) into zeroex-order-correct-types (1ede091) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@                      Coverage Diff                       @@
##           zeroex-order-correct-types    #1710      +/-   ##
==============================================================
- Coverage                       65.69%   65.50%   -0.20%
==============================================================
  Files                             179      181       +2
  Lines                           36046    36147     +101
==============================================================
- Hits                            23681    23678       -3
- Misses                          12365    12469     +104

I make the http solver take advantage of the new liquidity by

This sentence cuts off.

This PR showed that some work has to be done on the solver side in order to not sometimes cause settlement simulation failures. The progress on the solver side is captured here.

This PR showed that some work has to be done on the solver side in order to not sometimes cause settlement simulation failures.

Maybe we can highjack this PR to already add the has_atomic_execution flag to limit orders that need to get passed to the solver? Can also be separate - not sure how much extra code it would add.

Maybe we can highjack this PR to already add the has_atomic_execution flag to limit orders...

I'm already in the process of doing that. It's not much work I just got sidetracked a little.

Another thing to consider is having a custom "cost-model" that more closely captures the actual gas usage of a 0x order.

Yeah, I think so too. Since they don't provide gas cost with their OrderRecords I think we will have to simulate each order, no? Not sure if that is too much work to do for every 0x order.
Also @marcovc brought up that we should probably also send those orders during price estimation to get a representative estimate. This seems to involve either reimplementing a bunch of code or moving liquidity related code into from the solver crate into shared. I would do that in another PR because this would blow up this one too much.

I think we will have to simulate each order, no?

IMO its fine to just use the mean gas cost for calling fillOrKillLimitOrder on the 0x contract.

With the help of @bh2smith we were able to establish a lower bound for a trade on 0x (min over last 2 months).
This is the query we used.

Also @marcovc brought up that we should probably also send those orders during price estimation to get a representative estimate. This seems to involve either reimplementing a bunch of code or moving liquidity related code into from the solver crate into shared.

YES! This has been something in the backlog for ages! The liquidity we use in the API is different than in the solver. That would be awesome to tackle (but quite an extensive task with a long thread of small changes to pull on).

Why did you chose a lower bound?

It looks like gas_model.rs uses lower bounds for all gas calculations so I thought it wouldn't be fair to use a different measurement for zeroex.

Also, this seems to be using the event which includes fillLimitOrder calls which I don't think we want...

We were aware of this issue but is was our best idea to get some estimate. If you have a good alternative query I'm happy to use that instead.

If you have a good alternative query I'm happy to use that instead.

Likely need to search the transaction table by sighash (first 4 bytes of calldata).

I did a manual test where I checked simulations of a driver on this branch using a solver on the corresponding branch.
In order to verify that complex multi-hop settlements don't produce simulation errors I made the solver assume that 0x trades don't incur any gas costs. This results in solutions which are way more complex than we would normally generate but that gives me more confidence in the test.
simulation with 3 user orders, 2 uni v2 hops and 9 0x hops.
Before carefully ordering the execution plan simulations with as few as 2 0x hops already produced errors. I think it's safe to merge this PR now.

Very thorough testing.
Lets merge it!

Updated the query to calculate the min gas cost per 0x transaction.
Previously we used the minimum of all transactions which created a LimitOrderFilled event which can also be emitted by the slightly cheaper fillLimitOrder() function (as opposed to fillOrKillLimitOrder()).


[SPARK-33970][SQL][TEST] Add test default partition in metastoredirectsql

What changes were proposed in this pull request?
This pr add test default partition in metastoredirectsql.
Why are the changes needed?
Improve test.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A

Test build #133884 has started for PR 31109 at commit f32af89.

Test build #133884 has started for PR 31109 at commit f32af89.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38473/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38473/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38473/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38473/

Test build #133884 has finished for PR 31109 at commit f32af89.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133884 has finished for PR 31109 at commit f32af89.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133884/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38473/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38473/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133884/

Test build #133888 has started for PR 31109 at commit 272e831.

Test build #133888 has started for PR 31109 at commit 272e831.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38477/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38477/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38477/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38477/

Test build #133888 has finished for PR 31109 at commit 272e831.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133888 has finished for PR 31109 at commit 272e831.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133888/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38477/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38477/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133888/

retest this please.

retest this please.

Test build #133900 has started for PR 31109 at commit 272e831.

Test build #133900 has started for PR 31109 at commit 272e831.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38489/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38489/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38489/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38489/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38489/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38489/

Test build #133902 has started for PR 31109 at commit 56cb9fb.

Test build #133902 has started for PR 31109 at commit 56cb9fb.

cc @gatorsmile

cc @gatorsmile

Test build #133900 has finished for PR 31109 at commit 272e831.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133900 has finished for PR 31109 at commit 272e831.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38491/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38491/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133900/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133900/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38491/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38491/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38491/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38491/

Test build #133902 has finished for PR 31109 at commit 56cb9fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133902 has finished for PR 31109 at commit 56cb9fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133902/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133902/

Merged to master and branch-3.1 (since this is rather a followup of https://github.com/apache/spark/pull/30534).

Merged to master and branch-3.1 (since this is rather a followup of https://github.com/apache/spark/pull/30534).


Cant see dataLabels on the markers at column with markers char

hello , thank you for this great library!!
i cant set a label on the marker in a column with marker chart
the label is only on the columns, but not on the markers
maybe should do something like this?
data: [      {         x: '2011',     y: 1292,   goals: [          {            name: 'Expected',           value: 1400,           strokeHeight: 5,           strokeColor: '#775DD0',           toShowLabel: true        <----------- // SOMETHING LIKE THIS MYBE?     }  ] },
https://codepen.io/eliyahu-kriel/pen/XWzXmVd?editors=1111
THANKS

anyone please?


A version vs latest-stable vs latest-beta

Can you explain why there are now 3 types of releases and how we should apply this change?

There is one type of release, and it's numeric: N.N.N.N.  For example, <IP_ADDRESS>.
When a release first comes out, it's beta.  After a while, either:

the release looks good: we label it stable
there are bugs we want to fix before we are ok calling stable: we put out a new release that fixes the bugs

The latest-beta and latest-stable tags will always point to the most recent release in each category.  Currently they both point to <IP_ADDRESS>, but when <IP_ADDRESS> is ready we'll update the latest-beta tag to point there instead.

Okay, thanks for clarifying! I didn't see that you actually just upgraded the already versioned <IP_ADDRESS>.

Yup, nothing new for people who are already on <IP_ADDRESS>!
(But very excited to be able to call ngx_pagespeed now)


[feature] Save the world when on server crash

Is your feature request related to a problem? Please describe.
When the server crashes, all progress is lost since there is no automatic save feature. This can be frustrating, especially when players have made significant progress right before the crash. Currently, admins must rely on regular intervals for saving, which might not capture the state right before a crash.
Describe the solution you'd like
The server should automatically save the game world whenever a crash is detected. This way, even if the server crashes unexpectedly, the world is preserved up to the point of failure, minimizing data loss and improving the player experience.
Describe alternatives you've considered

Allowing an increase in the frequency of automatic saves, but this could still result in data loss if a crash occurs between saves.
Manual saving, but this depends on server admins remembering to save regularly, which is not reliable for crash situations.

Additional context
This feature could significantly improve server stability and data preservation for players. It may require capturing server states or integrating with existing crash-handling mechanisms. A similar implementation exists in other server software, e.g., LeviLamina, which could serve as a reference.

Thank u


years as integers in level1stat plot

years as integers on x-axis in level1stat plot.
have verified that this solves the issue by inspecting
http://localhost:5000/level1statistics
resolves #odin2

no, and if you think this change requires a dedicated test I will withdraw this PR.

Not the change but the error would have been nice to have a test for, but only if it was easy.


Add confirm dialog before deleting pickup

Changed the icon to a trash bin.
Use pre-rendered DOM for dialog, it seems easier if we don't need
dynamic content in the dialog.

Current coverage is 98.69% (diff: 100%)

Merging #240 into master will increase coverage by <.01%

@@             master       #240   diff @@
==========================================
  Files           108        108
  Lines          1680       1685     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1658       1663     +5
  Misses           22         22
  Partials          0          0

Powered by Codecov. Last update bd02897...350c9e4


Contractor can request changes to the contract

Additional context
This is a sub-issue of
User story

As a contractor, I need to  download, sign and then upload a signed contract.

Option 1: "contractor has no amendments" route: current manual (download, read, sign, upload) workflow

Option 2: "contractor has 'simple' amendments" route relies on it being clear to the contractor they are required to communicate via the communications tab.
Priority

Low

Ideal deadline
December 2022

The current workflow for uploading and requesting changes to a contract requires more ux.


hledger-lib 1.9

hledger-lib-1.9 (Simon Michael<EMAIL_ADDRESS>@simonmichael) is out of bounds for:

[ ] hledger-iadd-1.3.3 (>=1.5 && < 1.9). Hans-Peter Deifel<EMAIL_ADDRESS>@hpdeifel. @hpdeifel. Used by: library, executable, test-suite

Is there a way to declare priorities for inclusion in stackage ? I don't know if @hpdeifel agrees, but generally it's more important for me to keep the latest version of core packages like hledger-lib in stackage, and let the depending hledger-* tools in when their bounds are up to date.

I released version 1.3.4 with a fix.
However: How did this happen? Only the test-suite depended on hledger-lib <1.9 and it was disabled anyway.

The test suite wasn't skipped, it was marked as "expected failure." That means that it's included in the build plan.

@simonmichael We don't have any kind of official policy on priority of packages, though I'm open to doing something along those lines. This isn't at all a technical discussion, it's a social/community exercise around deciding which set of trade-offs we want to have. If the general consensus is to always include the latest and greatest for hledger, I don't have an objection.

Nod, thanks. I guess I'll add a comment about it in build-contraints.yaml, as a hint for stackage maintainers.


Suggestion

I suggest adding either a tab or a section below 'IA cover' for a history of the converted audio files

@YonaProXD This is a good idea. I have been considering adding something similar for my fork of this repo at : https://github.com/JackismyShephard/ultimate-rvc. What exactly did you have in mind? Perhaps something like a dropdown where you can listen to each generated cover song? If you have some other suggestion you are more than welcome to raise an issue in my repository as well :)

@JackismyShephard Yes, a dropdown menu where it shows Song Name (Model name), something like what Kits -- AI does.


Flow is currently failing to disable itself in case the the browser in not compatible.

Currently flow.js is failing to disable itself in case the the browser in not compatible.
Even if a support check is performed at https://github.com/flowjs/flow.js/blob/master/src/flow.js#L42  the library returns an empty Flow() object so that further code is sometimes executed with mass failure.
e.g. using ng-flow on GlobaLeaks i'm able to see failures reaching this.events.hasOwnProperty() calls, but if flow is  not compatible this.events is even == undefined so that the browser fails in a miserable way with a javascript exception preventing an  application that uses flow to work at all and not simply flow.

Issues like this could have been detected automatically if features like https://github.com/flowjs/flow.js/issues/137 would have been implemeented (on flowjs primarly  and then  on ngflow and whateverflow)


Ignore directories with the same name as python binaries

For #15357
The test already looked verified the files. It just needed a "dir" with the same name as a python binary. Added a empty file in such a dir.
Adding "skip tests" label because the test was just missing a entry in the FS layout.

Codecov Report

Merging #15367 (972649f) into main (36bb325) will decrease coverage by 0%.
The diff coverage is 92%.

@@          Coverage Diff           @@
##            main   #15367   +/-   ##
======================================
- Coverage     65%      65%   -1%
======================================
  Files        559      559
  Lines      26799    26801    +2
  Branches    3868     3869    +1
======================================
+ Hits       17447    17448    +1
  Misses      8634     8634
- Partials     718      719    +1

Impacted Files
Coverage Δ

...rc/client/pythonEnvironments/common/commonUtils.ts
58% <66%> (ø)

src/client/pythonEnvironments/common/posixUtils.ts
100% <100%> (ø)

...covery/locators/services/posixKnownPathsLocator.ts
100% <100%> (ø)

src/client/pythonEnvironments/base/info/env.ts
72% <0%> (-1%)
:arrow_down:

...nts/base/locators/composite/environmentsReducer.ts
97% <0%> (ø)


The problem about using RECORDER in dev1.x (RecorderManager)

Thanks to the MMrazor team contribution, Now I am learning the use of MMrazor dev1.x about the RECORDER moudle, but I ran into a couple of problems.
1.I find no mmrazor.core in dev1.x. however,I find the module such as MethodOutputsRecorder, RecorderManager and so on in mmrazor.models.task_modules, this problem seems to have been solved.
2.But when I test the demo about RecorderManager, I found that if I tried to use ModuleOutputs and MethodOutputs in RecorderManager at the same time, the forward process would seem to run twice, and output MethodOutputs would report an out-of-range error. But if the Method(toy_func) isn’t in the same python file, this error doesn't seem to happen.
For example:
import torch
import random
from mmengine import ConfigDict
from torch import nn
from mmrazor.models.task_modules import RecorderManager

class Toy():
    def toy_func(self):
        return random.randint(0, 1000000)

class ToyModel(nn.Module):
    def __init__(self):
        super().__init__()
        self.conv1 = nn.Conv2d(1, 1, 1)
        self.conv2 = nn.Conv2d(1, 1, 1)
        self.toy = Toy()

    def forward(self, x):
        return self.conv2(self.conv1(x)) + self.toy.toy_func()

# configure multi-recorders
conv1_rec = ConfigDict(type='ModuleOutputs', source='conv1')
conv2_rec = ConfigDict(type='ModuleOutputs', source='conv2')
func_rec = ConfigDict(type='MethodOutputs', source='demo.Toy.toy_func')
# instantiate RecorderManager with a dict that contains recorders' configs,
# you can customize their keys.
manager = RecorderManager(
    {'conv1_rec': conv1_rec,
     'conv2_rec': conv2_rec,
     'func_rec': func_rec})

model = ToyModel()
# initialize is to make specified module can be recorded by
# registering customized forward hook.
manager.initialize(model)

x = torch.rand(1, 1, 1, 1)
with manager:
    out = model(x)

conv2_out = manager.get_recorder('conv2_rec').get_record_data()
'''
 - mmengine - WARNING - The "task util" registry in mmrazor did not set import location. Fallback to call `mmrazor.utils.register_all_modules` instead.
tensor([[[[-0.2194]]]], grad_fn=<ThnnConv2DBackward>)
tensor([[[[-1.8282]]]], grad_fn=<ThnnConv2DBackward>)
'''

func_rec = manager.get_recorder('func_rec').get_record_data()
'''
569682
Traceback (most recent call last):
  File "demo.py", line 50, in <module>
    func_rec = manager.get_recorder('func_rec').get_record_data()
  File "mmrazor\mmrazor\models\task_modules\recorder\base_recorder.py", line 78, in get_record_data
    assert record_idx < len(self._data_buffer), \
AssertionError: record_idx is illegal. The length of data_buffer is 0, but record_idx is 0.
'''

But when I remove the MethodOutputs, everything seemed normal again.

import torch
import random
from mmengine import ConfigDict
from torch import nn
from mmrazor.models.task_modules import RecorderManager

class Toy():
    def toy_func(self):
        return random.randint(0, 1000000)

class ToyModel(nn.Module):
    def __init__(self):
        super().__init__()
        self.conv1 = nn.Conv2d(1, 1, 1)
        self.conv2 = nn.Conv2d(1, 1, 1)
        self.toy = Toy()

    def forward(self, x):
        return self.conv2(self.conv1(x)) + self.toy.toy_func()

# configure multi-recorders
conv1_rec = ConfigDict(type='ModuleOutputs', source='conv1')
conv2_rec = ConfigDict(type='ModuleOutputs', source='conv2')
#func_rec = ConfigDict(type='MethodOutputs', source='demo.Toy.toy_func')
# instantiate RecorderManager with a dict that contains recorders' configs,
# you can customize their keys.
manager = RecorderManager(
    {'conv1_rec': conv1_rec,
     'conv2_rec': conv2_rec})

model = ToyModel()
# initialize is to make specified module can be recorded by
# registering customized forward hook.
manager.initialize(model)

x = torch.rand(1, 1, 1, 1)
with manager:
    out = model(x)

conv2_out = manager.get_recorder('conv2_rec').get_record_data()

'''
- mmengine - WARNING - The "task util" registry in mmrazor did not set import location. Fallback to call `mmrazor.utils.register_all_modules` instead.
tensor([[[[-0.7945]]]], grad_fn=<ThnnConv2DBackward>)

'''

Hi @cape-zck ! Thank you for your issue.
If we set the source module name to demo.Toy.toy_func, the method output recorder will first import this target module demo.Toy by import_modules_from_strings('demo.Toy') and then wrap its toy_func method by the method_record_wrapper method in MethodOutputsRecorder. In this way, we can record the output data of a specific class method.
While the Toy.toy_func method you used during the forward pass is not the same as demo.Toy.toy_func. So the method  demo.Toy.toy_func is not executed actually and the output data of demo.Toy.toy_func is not recorded by the MethodOutputsRecorder. Hence it would report an out-of-range error.

Hi @cape-zck ! Thank you for your issue. If we set the source module name to demo.Toy.toy_func, the method output recorder will first import this target module demo.Toy by import_modules_from_strings('demo.Toy') and then wrap its toy_func method by the method_record_wrapper method in MethodOutputsRecorder. In this way, we can record the output data of a specific class method.
While the Toy.toy_func method you used during the forward pass is not the same as demo.Toy.toy_func. So the method demo.Toy.toy_func is not executed actually and the output data of demo.Toy.toy_func is not recorded by the MethodOutputsRecorder. Hence it would report an out-of-range error.

Could you help me check #636


Most of the keymaps are not working

Only basic hjkl movement works
:checkhealth which-key output
Checking your config ~
- WARNING There are issues with your config:
  - `opts.triggers_blacklist`: option is deprecated. see `opts.triggers`
  Please refer to the docs for more info.
- OK |mini.icons| is installed
- OK |nvim-web-devicons| is installed

Checking for issues with your mappings ~
- OK No issues reported

checking for overlapping keymaps ~
- WARNING In mode `n`, <ъ> overlaps with <ъЗ>, <ъй>, <ъа>, <ъс>, <ъц>, <ъу>, <ъв>, <ъе>, <ъИ>, <ъФ>, <ъъ>, <ъи>, <ъф>, <ъС>, <ъА>, <ън>, <ъз>:
  - <ъЗ>: Put Indented After Cursor (Linewise) LM (translate "]P")
  - <ъй>: Next Trouble/Quickfix Item LM (translate "]q")
  - <ъа>: Goto next start @function.outer LM (translate "]f")
  - <ъс>: Goto next start @class.outer LM (translate "]c")
  - <ъц>: Next Warning LM (translate "]w")
  - <ъу>: Next Error LM (translate "]e")
  - <ъв>: Next Diagnostic LM (translate "]d")
  - <ъе>: Next Todo Comment LM (translate "]t")
  - <ъИ>: Move buffer next LM (translate "]B")
  - <ъФ>: Goto next end @parameter.inner LM (translate "]A")
  - <ъъ>: Next Reference LM (translate "]]")
  - <ъи>: Next Buffer LM (translate "]b")
  - <ъф>: Goto next start @parameter.inner LM (translate "]a")
  - <ъС>: Goto next end @class.outer LM (translate "]C")
  - <ъА>: Goto next end @function.outer LM (translate "]F")
  - <ън>: Cycle Backward Through Yank History LM (translate "]y")
  - <ъз>: Put Indented After Cursor (Linewise) LM (translate "]p")
- WARNING In mode `n`, <Б> overlaps with <Бз>, <БЗ>:
  - <Бз>: Put and Indent Left LM (translate "<p")
  - <БЗ>: Put Before and Indent Left LM (translate "<P")
- WARNING In mode `n`, <п> overlaps with <пх>, <пк>, <пв>, <пъ>, <пВ>, <пШ>, <псщ>, <псЩ>, <пЛ>, <пн>, <пз>, <пЗ>:
  - <пх>: Move to left "around" LM (translate "g[")
  - <пк>: References LM (translate "gr")
  - <пв>: Goto Definition LM (translate "gd")
  - <пъ>: Move to right "around" LM (translate "g]")
  - <пВ>: Goto Declaration LM (translate "gD")
  - <пШ>: Goto Implementation LM (translate "gI")
  - <псщ>: Add Comment Below LM (translate "gco")
  - <псЩ>: Add Comment Above LM (translate "gcO")
  - <пЛ>: Signature Help LM (translate "gK")
  - <пн>: Goto T[y]pe Definition LM (translate "gy")
  - <пз>: Put Text After Selection LM (translate "gp")
  - <пЗ>: Put Text Before Selection LM (translate "gP")
- WARNING In mode `n`, <Ю> overlaps with <Юз>, <ЮЗ>:
  - <Юз>: Put and Indent Right LM (translate ">p")
  - <ЮЗ>: Put Before and Indent Right LM (translate ">P")
- WARNING In mode `n`, <х> overlaps with <хй>, <хЗ>, <хИ>, <ха>, <хс>, <хц>, <ху>, <хв>, <хе>, <хх>, <хФ>, <хи>, <хф>, <хС>, <хА>, <хн>, <хз>:
  - <хй>: Previous Trouble/Quickfix Item LM (translate "[q")
  - <хЗ>: Put Indented Before Cursor (Linewise) LM (translate "[P")
  - <хИ>: Move buffer prev LM (translate "[B")
  - <ха>: Goto previous start @function.outer LM (translate "[f")
  - <хс>: Goto previous start @class.outer LM (translate "[c")
  - <хц>: Prev Warning LM (translate "[w")
  - <ху>: Prev Error LM (translate "[e")
  - <хв>: Prev Diagnostic LM (translate "[d")
  - <хе>: Previous Todo Comment LM (translate "[t")
  - <хх>: Prev Reference LM (translate "[[")
  - <хФ>: Goto previous end @parameter.inner LM (translate "[A")
  - <хи>: Prev Buffer LM (translate "[b")
  - <хф>: Goto previous start @parameter.inner LM (translate "[a")
  - <хС>: Goto previous end @class.outer LM (translate "[C")
  - <хА>: Goto previous end @function.outer LM (translate "[F")
  - <хн>: Cycle Forward Through Yank History LM (translate "[y")
  - <хз>: Put Indented Before Cursor (Linewise) LM (translate "[p")
- WARNING In mode `n`, <<Space>w> overlaps with <<Space>wm>, <<Space>wd>:
  - <<Space>w>: Windows
  - <<Space>wm>: Enable Maximize
  - <<Space>wd>: Delete Window
- WARNING In mode `n`, <<Space>ц> overlaps with <<Space>ць>, <<Space>цв>:
  - <<Space>ц>: Windows LM (translate "<leader>w")
  - <<Space>ць>: Toggle Maximize LM (translate "<leader>wm")
  - <<Space>цв>: Delete Window LM (translate "<leader>wd")
- WARNING In mode `n`, <gc> overlaps with <gcO>, <gco>, <gcc>:
  - <gc>: Toggle comment
  - <gcO>: Add Comment Above
  - <gco>: Add Comment Below
  - <gcc>: Toggle comment line
- WARNING In mode `x`, <ш> overlaps with <шт>, <шд>:
  - <ш>: Inside textobject LM (translate "i")
  - <шт>: Inside next textobject LM (translate "in")
  - <шд>: Inside last textobject LM (translate "il")
- WARNING In mode `x`, <a> overlaps with <al>, <an>, <a%>:
  - <a>: around
  - <al>: last
  - <an>: next
- WARNING In mode `x`, <ф> overlaps with <фт>, <фд>:
  - <ф>: Around textobject LM (translate "a")
  - <фт>: Around next textobject LM (translate "an")
  - <фд>: Around last textobject LM (translate "al")
- WARNING In mode `x`, <i> overlaps with <il>, <in>:
  - <i>: inside
  - <il>: last
  - <in>: next
- WARNING In mode `o`, <ш> overlaps with <шт>, <шд>:
  - <ш>: Inside textobject LM (translate "i")
  - <шт>: Inside next textobject LM (translate "in")
  - <шд>: Inside last textobject LM (translate "il")
- WARNING In mode `o`, <a> overlaps with <al>, <an>:
  - <a>: around
  - <al>: last
  - <an>: next
- WARNING In mode `o`, <i> overlaps with <il>, <in>:
  - <i>: inside
  - <il>: last
  - <in>: next
- WARNING In mode `o`, <ф> overlaps with <фт>, <фд>:
  - <ф>: Around textobject LM (translate "a")
  - <фт>: Around next textobject LM (translate "an")
  - <фд>: Around last textobject LM (translate "al")
- OK Overlapping keymaps are only reported for informational purposes.
  This doesn't necessarily mean there is a problem with your config.

Hi. This repository is deprecated, you don't need to use it. Use the most recent version of LazyVim and langmapper.nvim. The langmapper.nvim repository in the issue has an explanation of how to use which-key after updating.


1657408: 20 more SEO description adds.

Summary
Added the missing description metadata field to 20 articles as part of User Story 1657408: SEO OKR: [ms.prod(dotnet) ms.technology (dotnet-standard)] Missing description issue (502).

#sign-off


Privacy policy

Hi,
I just got a token code to test your plugin but I wanted to know what was the privacy policy of codemaker ai. Do you collect, store data? Snippets of code specifically? Where can I find this information?
On your website it simply says

Your access to and use of the Service is also conditioned on Your acceptance of and compliance with the Privacy Policy of the Company. Our Privacy Policy describes Our policies and procedures on the collection, use and disclosure of Your personal information when You use the Application or the Website and tells You about Your privacy rights and how the law protects You. Please read Our Privacy Policy carefully before using Our Service.

Without any link or more information that I could find. Thanks

Thank you for your patience as we were resolving this issue. The Privacy Policy has been publish on the company website and is available at: https://beta.codemaker.ai/privacy-policy


Random crashes

After pressing escape or in middle of a SP game.
2015-09-04 13:15:18    Notice     Running TrueCraft server on <IP_ADDRESS>:45916
Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
at Microsoft.Xna.Framework.Game.Tick () [0x00000] in :0
at Microsoft.Xna.Framework.OpenTKGamePlatform.RunLoop () [0x00000] in :0
at Microsoft.Xna.Framework.Game.Run (GameRunBehavior runBehavior) [0x00000] in :0
at Microsoft.Xna.Framework.Game.Run () [0x00000] in :0
at TrueCraft.Client.Program.Main_Thread (System.String[] args) [0x00000] in :0
at TrueCraft.Client.Program.Main (System.String[] args) [0x00000] in :0
[ERROR] FATAL UNHANDLED EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object
at Microsoft.Xna.Framework.Game.Tick () [0x00000] in :0
at Microsoft.Xna.Framework.OpenTKGamePlatform.RunLoop () [0x00000] in :0
at Microsoft.Xna.Framework.Game.Run (GameRunBehavior runBehavior) [0x00000] in :0
at Microsoft.Xna.Framework.Game.Run () [0x00000] in :0
at TrueCraft.Client.Program.Main_Thread (System.String[] args) [0x00000] in :0
at TrueCraft.Client.Program.Main (System.String[] args) [0x00000] in :0
AL lib: ReleaseALC: 1 device not closed
2015-09-04 13:15:21    Notice     drfragment has left the server.
System.NullReferenceException: Object reference not set to an instance of an object
at TrueCraft.RemoteClient.Save () [0x00000] in :0
at TrueCraft.MultiplayerServer.DisconnectClient (IRemoteClient _client) [0x00000] in :0
at TrueCraft.MultiplayerServer.Stop () [0x00000] in :0
at TrueCraft.Launcher.Singleplayer.SingleplayerServer.Stop () [0x00000] in :0
at TrueCraft.Launcher.Views.SingleplayerView.<PlayButton_Clicked>m__A () [0x00000] in :0
at Xwt.Application+c__AnonStorey0.<>m__0 () [0x00000] in :0

Escape is the exit key, and it's designed to end the program. Crashing during exit is a MonoGame issue. Can you provide steps to reproduce that don't involve exiting?

When the world loaded, the character started going up until the game crashed.

Can you try on a new singleplayer world? If the problem does not persist in a new world, can you upload the problematic world (it's in ~/.truecraft somewhere for us to test with?

I cannot replicate the crash any more, however the character can go through trees and when it does it catapults up.

Yeah, that's a known issue with the physics engine. Feel free to comment here again later if you can reproduce the bug.


Throwing InvalidArgumentException when polymorphic has_one/component's class is removed

Affected Version
silverstripe/framework       4.5.2

Description
When DataObject::getComponent() is called for a polymorphic relation with an existing $componentName . Class value, and the class name is no longer in the project, I get the error
[Emergency] Uncaught InvalidArgumentException: {Fully\Qualified\Class\Name} is not a subclass of DataObject

Trace
SilverStripe\ORM\DataObjectSchema->baseDataClass
DataQuery.php:168
SilverStripe\ORM\DataQuery->initialiseQuery
DataQuery.php:79
SilverStripe\ORM\DataQuery->__construct
DataList.php:61
SilverStripe\ORM\DataList->__construct
ReflectionClass->newInstanceArgs
InjectionCreator.php:23
SilverStripe\Core\Injector\InjectionCreator->create
Injector.php:594
SilverStripe\Core\Injector\Injector->instantiate
Injector.php:1002
SilverStripe\Core\Injector\Injector->getNamedService
Injector.php:955
SilverStripe\Core\Injector\Injector->get
Injector.php:1125
SilverStripe\Core\Injector\Injector->createWithArgs
Injectable.php:30
SilverStripe\View\ViewableData::create
DataObject.php:3200
SilverStripe\ORM\DataObject::get
DataObject.php:1780
SilverStripe\ORM\DataObject->getComponent
DataObject.php:2498

Steps to Reproduce

Create a class to remove later e.g PolymorphicBreakdownTestObject
Create a polymorphic relationship with that class from another Object (to act as the "owner" of the relationship)
Add a record of that class to the relationship, so that it's class name is stored in the database under the {Relation}Class field
Remove the PolymorphicBreakdownTestObject from the project, dev/build etc
Call ->getComponent('Relation') on the owner of the relationship

Expected result:
The ->getComponent() fails gracefully and returns a null value
Actual result:
An [Emergency] Uncaught InvalidArgumentException interrupts execution

I'm not sure about this. If I remove a model from my project, I probably would like to know if I still have relationships pointing to it in my DB.
We can probably make the error message a bit clearer, but it's not clear to me to silently returning a null is the best solution here.

True. Agreed, my expected result is a bit too narrow/opinionated. Is there a valid case to introduce a pattern like the DatabaseAdmin's classname_value_remapping config for a situation like this?

How to resolve this issue:

Add an entry to config:

SilverStripe\ORM\DatabaseAdmin:
  classname_value_remapping:
    Obsolete\ClassName: Replacement\ClassName

Run dev/build?flush=all

DatabaseAdmin will remap the relation classnames as per your configuration


Fixed broken markdown in registry path

This PR fixes incorrect markdown related to registry paths.
The markdown in the registry path was not correct causing wrong rendering:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: valterc sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@valterc : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for the fixes, @valterc ! Merging your changes. They should be live within a day.


500 error at /add/ (#12489)

'int' object has no attribute 'id'

Reported on decksite by logged_out
Request Method: POST
Path: /add/?
Cookies: {'__cfduid': 'd9061d17f6d442ac86e0efefe32a231c81518407268'}
Endpoint: add_deck
View Args: {}
Person: logged_out
User-Agent: python-requests/2.18.4
Referrer: None
Request Data: {'url': 'http://tappedout.net/mtg-decks/birthday-stax'}
AttributeError
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1997, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1985, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "./decksite/cache.py", line 66, in decorated_function
response = make_response(f(*args, **kwargs))
File "./decksite/main.py", line 147, in add_deck
deck_id = decksite.scrapers.tappedout.scrape_url(url).id

'int' object has no attribute 'id'

Reported on decksite by logged_out
Request Method: POST
Path: /add/?
Cookies: {'__cfduid': 'd9061d17f6d442ac86e0efefe32a231c81518407268'}
Endpoint: add_deck
View Args: {}
Person: logged_out
User-Agent: python-requests/2.18.4
Referrer: None
Request Data: {'url': 'http://tappedout.net/mtg-decks/birthday-stax'}
AttributeError
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1997, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1985, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "./decksite/cache.py", line 66, in decorated_function
response = make_response(f(*args, **kwargs))
File "./decksite/main.py", line 147, in add_deck
deck_id = decksite.scrapers.tappedout.scrape_url(url).id

'int' object has no attribute 'id'

Reported on decksite by logged_out

Request Method: POST
Path: /add/?
Cookies: {'__cfduid': 'd17244bd7ecd006213194bbec0f28ffd71519106536'}
Endpoint: add_deck
View Args: {}
Person: logged_out
User-Agent: python-requests/2.18.4
Referrer: None
Request Data: {'url': 'https://tappedout.net/mtg-decks/birthday-stax'}

AttributeError
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1997, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1985, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "./decksite/cache.py", line 66, in decorated_function
response = make_response(f(*args, **kwargs))
File "./decksite/main.py", line 147, in add_deck
deck_id = decksite.scrapers.tappedout.scrape_url(url).id

This was happening when a deck already existed in the system, and we were exiting early with return deck_id, rather than the return Deck(deck_id) we did when actually adding the decklist.

@silasary fixed this. Or maybe she still needs to PR.


Update Route Query to look at last updated

There needs to be a way for routes that don't get approved to "fall off" the map. This could also be solved in Golbat most likely long term but an additional condition on the query in RM is a quick solution.

In the discord we made a sql doe it.
Run this on a cron
DELETE FROM route where updated < UNIX_TIMESTAMP(now() - INTERVAL 1 DAY)
i have set mine to 3 days instead of one, but it works :)


Voice selection

Fixes #2. I unfortunately only get two voice options on my machine, David and Zira, not the newer natural voices. But those may be unavailable to us, as discussed at https://github.com/nvaccess/nvda/issues/13288

Unfortunately when I run this I get:
error: process didn't exit successfully: `target\debug\rust_reader.exe` (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN)

Try again? I found one place I could induce a crash on startup (I wasn't properly handling if a default voice named "Microsoft David Desktop" isn't installed), and I just fixed that.

I take it I fixed your crash. Out of curiosity, how many voices are you presented with?

Yes, the crash went away. I assume it was because of your changes. (It would be really nice to have tests, but I've never figured out how to do meaningful tests when a main event loop is required.)
On my Windows 10 computer I have David and Zira. On my Windows 11 computer... same.


Unable to create Redditor for sending messages, throws TypeError

Issue Description
Setup:

Create a Reddit instance, as in reddit = new praw.Reddit(...)
Pass instance to a function
Read and store all unread messages
For each message, add the author (from Message.author) to list,, and create Redditor instance via reddit.redditor(user)
Send message to redditor via Redditor.message('subject', 'text').

Expected Behaviour:
Create the user without issue, and send a message
Actual Behavior:
Exception is thrown when attempting to create Redditor object.
Traceback (most recent call last):
  File "C:/Users/krobertson/Documents/GitHub/postsubscribe/postsubscribe.py", line 118, in <module>
    main()
  File "C:/Users/krobertson/Documents/GitHub/postsubscribe/postsubscribe.py", line 101, in main
    new_users = poll_messages(reddit, users)
  File "C:/Users/krobertson/Documents/GitHub/postsubscribe/postsubscribe.py", line 36, in poll_messages
    useracc = reddit.redditor(user)
  File "C:\Program Files\Python35\lib\site-packages\praw\reddit.py", line 388, in redditor
    return models.Redditor(self, name)
  File "C:\Program Files\Python35\lib\site-packages\praw\models\reddit\redditor.py", line 36, in __init__
    self._path = API_PATH['user'].format(user=self)
TypeError: __str__ returned non-string (type Redditor)

System Information
PRAW Version: v4.4.0
Python Version: 3.5.2
Operating System: Windows 7 Professional SP1

TypeError: str returned non-string (type Redditor)

Based on this information it would seem that you're code is passing a Redditor instance into reddit.redditor here: useracc = reddit.redditor(user).
Assuming that's the case, you could just do useracc = user or replace useracc with user. This seems in line with your statement:

For each message, add the author (from Message.author) to list,, and create Redditor instance via reddit.redditor(user)

Message.author is already a Redditor instance.

Apologies, the docs seemed to imply that only Submission or Comment instances had this property:
Obtain Redditor Instances
There are several ways to obtain a redditor (a Redditor instance). Two of the most common ones are:

via the author attribute of a Submission or Comment instance
via the redditor() method of Reddit

Would you like to update that comment to include Message and be more generic?


Unable to set Apple private key (.p8)

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
yarn global add @aws-amplify/cli
If applicable, what version of Node.js are you using?
v16.13.0
Amplify CLI Version
7.6.7
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
auth
Amplify Commands
push
Describe the bug
Unable to set private_key.p8, I tried copying the p8 contents and using path but I'm not able to make this work. The docs does not describe how to properly setup SIWA.
Expected behavior
It should be able to push without Provided private key cannot be used for Sign in with Apple error.
Reproduction steps
amplify update auth
❯ Update OAuth social providers
◉ Sign in with Apple

Fill up the necessary data

Then

Try path or p8 contents, it does not work.
Enter your Private Key for your OAuth flow:  ./path_to.p8

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line
Resource Name: 2022/01/10/[$LATEST]3f5b94f511a1427ea5548fb53b5c0bc3 (Custom::LambdaCallout)
Event Type: create
Reason: Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream: 2022/01/10/[$LATEST]3f5b94f511a1427ea5548fb53b5c0bc3 (RequestId: 1759da36-e6fd-46ed-8f9e-b15122d4a35f)

Resource Name: 2022/01/10/[$LATEST]af46afe57b1741df81b73249058f2021 (Custom::LambdaCallout)
Event Type: create
Reason: Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream: 2022/01/10/[$LATEST]af46afe57b1741df81b73249058f2021 (RequestId: 2e4fa649-18e7-47dc-9953-283a2b148fc0)

// CloudWatch JSON error
{
    "Status": "FAILED",
    "Reason": "See the details in CloudWatch Log Stream: 2022/01/10/[$LATEST]f7beceb769d043279637f815cdd91afb",
    "PhysicalResourceId": "2022/01/10/[$LATEST]f7beceb769d043279637f815cdd91afb",
    "StackId": "arn:aws:cloudformation:us-east-2:143966962572:stack/amplify-applesignin-dev-231357-authapplesignin7cfff4b7-11QDAUKAZKS2H/58bd1cd0-7233-11ec-9632-06c5cf500f92",
    "RequestId": "4b223649-f4ad-4689-b515-b298eedf1a1c",
    "LogicalResourceId": "HostedUIProvidersCustomResourceInputs",
    "NoEcho": false,
    "Data": {
        "err": {
            "message": "Provided private key cannot be used for Sign in with Apple.",
            "code": "InvalidParameterException",
            "time": "2022-01-10T16:37:00.278Z",
            "requestId": "01d0bad7-9168-4769-b87f-0c44a28e1645",
            "statusCode": 400,
            "retryable": false,
            "retryDelay": 54.55269406556693
        }
    }
}

Additional information
I also tried adding the private_key.p8 inside ~/.aws/amplify, then set the private key path on CLI prompt with ./private_key.p8.

Additional logs
{
    "LogicalResourceId": "HostedUIProvidersCustomResourceInputs",
    "NoEcho": false,
    "Data": {
        "err": {
            "message": "Provided private key cannot be used for Sign in with Apple.",
            "code": "InvalidParameterException",
            "time": "2022-01-10T19:28:51.712Z",
            "requestId": "bba90cec-f2af-4505-99ad-1456586d69fd",
            "statusCode": 400,
            "retryable": false,
            "retryDelay": 97.73668519290946
        }
    }
}

{
        "LogicalResourceId": "OAuthCustomResourceInputs",
    "NoEcho": false,
    "Data": {
        "err": {
            "message": "The provider SignInWithApple does not exist for User Pool us-east-2_78SHZy0qr.",
            "code": "InvalidParameterException",
            "time": "2022-01-10T19:28:51.352Z",
            "requestId": "54e300dc-f2d3-43a7-9e84-398f7dc34f81",
            "statusCode": 400,
            "retryable": false,
            "retryDelay": 88.48927212960052
        }
    }
}

I have had this error happen to me when I accidentally included newlines or other unexpected characters in my private key. Could that be it?

@johnpc Yeah, I think that's it.
What I did is to upload .p8 key on Amplify Studio, amplify pull it. Then, copy the HostedUiCreds then paste it to deployment-secrets.json.
My question is, does the CLI accept the path/to/key.p8 or paste the p8 key without new lines?

I think it uses path/to/key.p8 - is that not working for you?

Using path to the .p8 file does not work for me. That’s why I set it up
using amplify studio. Can you verify using the amplify version on this
issue?
On Wed, Jan 19, 2022 at 03:15 John Corser @.***> wrote:

I think it uses path/to/key.p8 - is that not working for you? Make sure
it's the absolute path
—
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/9478#issuecomment-1015741191,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABW4M2C77VT7PKPCJ4XTLN3UWW343ANCNFSM5LUHVXUA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I don't understand - are you currently still blocked on this, or did the studio workaround work for you? I cannot reproduce an issue with this on v7.6.9

Closing due to a lack of followup, but we can revisit this issue if needed.

This worked for me: https://github.com/aws-amplify/amplify-cli/issues/8939#issuecomment-1028440837


[SPARK-35845][SQL] OuterReference resolution should reject ambiguous column names

What changes were proposed in this pull request?

The current OuterReference resolution is a bit weird: when the outer plan has more than one child, it resolves OuterReference from the output of each child, one by one, left to right.
This is incorrect in the case of join, as the column name can be ambiguous if both left and right sides output this column.
This PR fixes this bug by resolving OuterReference with outerPlan.resolveChildren, instead of something like outerPlan.children.foreach(_.resolve(...))
Why are the changes needed?

bug fix
Does this PR introduce any user-facing change?

The problem only occurs in join, and join condition doesn't support correlated subquery yet. So this PR only improves the error message. Before this PR, people see
java.lang.UnsupportedOperationException
Cannot generate code for expression: outer(t1a#291)

How was this patch tested?

a new test

cc @allisonwang-db @maropu

Test build #140094 has started for PR 33004 at commit 9173bb3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44622/

Test build #140098 has started for PR 33004 at commit 20c3c5c.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44622/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44622/

Test build #140094 has finished for PR 33004 at commit 9173bb3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140094/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44626/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44626/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44626/

Test build #140098 has finished for PR 33004 at commit 20c3c5c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140098/

Test build #140127 has started for PR 33004 at commit 01f5833.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44655/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44655/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44655/

Test build #140127 has finished for PR 33004 at commit 01f5833.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140127/

Thanks, merging to master


Looking for a new maintainer!

Due to the fact that I no longer activley working with Laravel as a Framework, I'm looking for someone who is willing to maintain this little project in the future. If you're interested, let me know.

Hi, we at @razorcreations love to take over the package if you're happy with that? 👍

Hey @rossjcooper , thank you for your offering. I've already found someone und we are in the middle of a transfer of ownership. The project will be maintained by @tomhatzer in the future. :)


initial version of compatibility script

Packages up compatibility tests as a script that could be executed through NPX.  Uses PM2 or Docker Compose to start and manage multiple processes.
Difference between PM2 and Docker:

When using PM2, script starts inventory and user subgraphs (devs can also specify their pm2 config to start product subgraph under test) and then runs rover dev to compose the supergraph.
When using Docker Compose, script generates supergraph config using rover supergraph compose and then starts the router using Docker.

Simplest use case (when test app is already running):
npx @apollo/federation-subgraph-compatibility pm2 --endpoint http://localhost:8080/graphql

Use --help to see all available configuration options.

Looks okay to me, though I'm not a node developer 😅. Can we have a dedicated markdown file describing just this CLI usage which can be on npmjs and potentially also added to the docs site somewhere?

Yeah, once it is published on NPM (and we are happy with the result) will update README with all the info.

I'm trying this on my machine and it is expecting me to have a supergraph.config.js, is that expected?

Adding the same config from this repo doesn't work (as you'd expect, since it requires the subgraphs)

Updated README -> https://github.com/dariuszkuc/apollo-federation-subgraph-compatibility/tree/script