[React Native] Support Hermes on iOS (react-native 0.64)

react-native 0.64-rc0 released, which includes Hermes support for iOS. (see https://github.com/react-native-community/releases/issues/214) Currently, all appcenter codepush commands fail, because the bundle-generation is hardcoded in such a way that it isn't expecting a hermes js executor/bitcode instead of JSC for iOS builds, so at the moment codepush does not work.
Is hermes support planned for codepush?

I managed to actually build the JS bundle using the appcenter CLI, and it actually works with Hermes. The problem is, that the bundle is not built with the Hermes compiler (hermesc), meaning it is not in bytecode format and the app will therefore not run with maximum performance.

Hi! Thanks for getting in touch with us!
Hermes for IOS is on our roadmap but we don't have ETA for this. We will do it as soon as possible and notify you when we will have any updates.

@AnastasiaKubova are there any updates on this?

We don't have ETA for this. We will notify here when we will have any updates.

We need this also. It would be nice if your documentation clearly listed the limitations for various versions of react-native.

I'm closing this issue, since https://github.com/microsoft/appcenter-cli/pull/1461 was merged.


@now/node Typescript 3.7

Now that the long expected Typescript 3.7 is out, can @now/node's typescript dependency be upgraded to the latest version?
Or perhaps, there is a way to specify the version of TS that is used in the project?

Hi @Zdend
You can specify the version in package json.
Run yarn add --dev<EMAIL_ADDRESS>or npm i -D<EMAIL_ADDRESS>

Hi @styfle ,
I have tried that but with no luck. Maybe it's due to my folder structure which is following
├───backend
│   ├───package.json
│   ├───tsconfig.json
├───frontend
│   ├───package.json
│   ├───tsconfig.json
├───now.json

{
  "version": 2,
  "builds": [
    {
      "src": "frontend/next.config.js",
      "use": "@now/next"
    },
    {
      "src": "backend/src/index.ts",
      "use": "@now/node",
      "config": {
        "maxLambdaSize": "20mb",
        "includeFiles": [
          "backend/src/schema.graphql"
        ]
      }
    }
  ]
}

I have tried to hoist tsconfig.json to the root level and install<EMAIL_ADDRESS>there as well but the build runtime still shows me that it uses internal version
Using TypeScript 3.5.2 (now internal)
Interestingly enough, @now/next that compiles frontend doesn't have the same problem, although it might be due to the custom .babelrc that contains plugins to compile optional chaining rather than letting typescript do so.
Thanks

You will need a package.json at the root level (next to the now.json) containing Typescript 3.7.
That will get you a little further, but if like me you were hoping to leverage optional chaining, you will be disappointed for now :(
› yarn dev
yarn run v1.17.3
$ now dev
> Now CLI 16.4.4 dev (beta) — https://zeit.co/feedback/dev
> Creating initial build
> Using external babel configuration
> Location: "<snipped>/now/web/.babelrc"
[ info ]  bundled successfully, waiting for typecheck results...
[ wait ]  compiling ...
> Success! Build completed
[ info ]  bundled successfully, waiting for typecheck results...
> Ready! Available at http://localhost:3000
[ event ] build page: /next/dist/pages/_error
[ wait ]  compiling ...
[ info ]  bundled successfully, waiting for typecheck results...
[ ready ] compiled successfully
> Building @now/node:api/src/routes/auth/login/index.ts
Installing dependencies...
Using TypeScript 3.7.2 (local user-provided)
> Built @now/node:api/src/routes/auth/login/index.ts [4s]
/private/var/folders/m6/1fn9pd3x6j568fffgksl71jr0000gn/T/zeit-fun-ca509de1e78d2/api/src/koa.js:24
        domain: config_1.default.auth0?.tennant,
                                       ^

SyntaxError: Unexpected token .
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (<snipped>/now/api/src/routes/auth/login/index.ts:2:1)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
LambdaError: RequestId: 1af5da18-3041-4c1d-a287-41004d362bfa Process exited before completing request
    at Lambda.<anonymous> (<snipped>/now/node_modules/now/dist/index.js:2:3106637)
    at Generator.next (<anonymous>)
    at fulfilled (<snipped>/now/node_modules/now/dist/index.js:2:3104508)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Hey @dan-turner,
I'm glad that it solved it for you! I tried the same thing both having typescript in the root package.json and having proper target version in the tsconfig. When I run now dev it actually picks up the right version of typescript!
However when I deploy to prod (now deploy -f), it picks up the old version. There seem to be differences in typescript resolution between dev and prod - at least with my setup.

This has been fixed in the canary channel.
You can try it out with npm i -g now@canary, thanks!

Awesome, confirming it works! Thank you

For anyone else who still runs into this problem, make sure tsconfig.json isn't ignored by .nowignore like it was for me.

I just ran into the same problem, following steps helped me solving this:

yarn add --dev typescript
Create a tsconfig.json:

{
  "compilerOptions": {
    "target": "ES2018"
  }
}

Hope this will help others! cc @tsujp

None of these solve it for me.  I have a structure like this:
api/index.ts (graphql server)
web/ (react frontend)
Graphql server won't run when using anything from 3.7 and above.  Frontend works fine because there is a build step


Custom logger

I would like an option to disable console.warn messages. While I was initially fond of the feedback, I'd prefer to be able to override console.warn with a custom logger passed in as an option, or perhaps just keeping the warning off by default.
I could suggest an implementation if interested.

Good idea. The easiest implementation from the top of my head is an extra option called 'console' that is window.console by default, false if you want it turned off, or a custom object for anything other (so as long as it has a method 'warn').

I added this in my fork, but now I realized that what I take issue with is that the error level seems a little high. I'd prefer if console.info was used instead of console.warn.
Perhaps a toggle to reduce the warning level would be an option? Or maybe I need to clean up my code, as I'm actually passing tinysort data before the dom is ready! :) Going to try adjusting a debounce.

There should be an option to turn off console.warn messages.

there is now


add missing **kwargs in DataBunch.create

It's not adding **kwargs that was missing here (since the init don't take any other special argument), but the collate_fn being properly passed.


Simplify Electron executable scenario

Created a bin link to ./node_modules/.bin/electron, eliminating the need to have electron on your environment, and simultaneously making scripts easier to write.

Fair enough, thanks!


Godot filesystem on osx does not synchronize files.

Godot version:
v3.2.1
OS/device including version:
OSX.
Issue description:
Editor filesystem viewer does not sync with new files added externally or dragged and dropped into the editor. When another folder is dragged and dropped into the editor the folder is copied into the actual folder but does not show up on the view.
Steps to reproduce:
Start a new project copy a folder of files into project folder. Editor does not reflect change on OSX. It does reflect the change on windows.
Minimal reproduction project:
Can be reproduced with a completely new project.

I'm also having this issue.  Strangely, it's only happening on my newer of two macs (an M1 MacMini with BigSur) but it's not happening on my older, Intel MBP running Catalina.

Strangely, it's only happening on my newer of two macs (an M1 MacMini with BigSur) but it's not happening on my older, Intel MBP running Catalina.

It's probably caused by Rosetta x86 emulation in this case. Can you try the native ARM binaries available for 3.2.4beta4?

@Calinou So I download the 3.2.4beta4.  Here's the result:

Opened Godot it in native mode (outside of Rosetta mode)
Dragged and dropped a PNG file into the FileSystem tab.
Did not see the file in the FileSystem view.
Restarted Godot
Did not see the file in the FileSystem view (or in the project folder)

Afterwards, I enabled Rosetta mode by clicking the "open using Rosetta" checkbox:

Opened Godot it in Rosetta mode
Dragged and dropped a PNG file into the FileSystem tab.
Did not see the file in the FileSystem view.
Restarted Godot
DID see the file in the FileSystem view (or in the project folder)

This seems to be the same behavior as the stable Godot release I was using 3.2.3 before where it only syncs after an editor restart.  It also suggests that importing assets/resources only works in Rosetta mode and not at all in ARM mode.

Fixes for drag-and-drop not working on native M1 - #44619 (4.x), #44620 (3.2.x)
I can't reproduce FS panel not updating on x86-64 Big Sur.

Most likely FS panel not updating is related to the resource directory "modified time" flag not changed or read correctly (get_modified_time/stat`).

Thanks @bruvzg !

Can anyone still reproduce this issue in 4.0 alpha7?

Closing due to lack of response. Please comment if you can still reproduce this bug.


Platform development: architecture diagrams

DigitalTWINS-platform-architecture-v4

User DB issue (duplication)
Putting the user DB into another server apart from the three platform servers
Data duplication issue
DigitalTWINS-platform-architecture-DHB-v1


Chapter 7: Lottery - Integration Test Error

I am having the same problem which was described here and wasn't able to be solved:
https://github.com/PatrickAlphaC/smartcontract-lottery/issues/68
This is the error I get
Function I am calling
def test_can_pick_winner():
    if network.show_active() in LOCAL_BLOCKCHAIN_ENVIRONMENTS:
        pytest.skip
    lottery = deploy_lottery()
    lottery.startLottery(_from())
    lottery.enter(_from(lottery.getEntranceFee()))
    lottery.enter(_from(lottery.getEntranceFee()))
    fund_with_link(lottery)
    lottery.endLottery(_from())
    time.sleep(60)
    assert lottery.recentWinner() == get_account()
    assert lottery.balance() == 0

Result
Running on [rinkeby] network
Deployed Lottery!
Funded contract with LINK
tests/test_lottery_integration.py::test_can_pick_winner FAILED

I guess I solved it by the help of these posts:
https://ethereum.stackexchange.com/questions/114500/brownie-rinkeby-valueerror-gas-estimation-failed-you-must-set-the-gas-limit
https://stackoverflow.com/questions/71194882/execution-reverted-during-call-this-transaction-will-likely-revert-if-you-wish/71212745#71212745
Seems it was a VRFCoordinator version error. I have updated the contract address by VRF version 1 address and this error didn't occur again.

I guess I solved it by the help of these posts:
https://ethereum.stackexchange.com/questions/114500/brownie-rinkeby-valueerror-gas-estimation-failed-you-must-set-the-gas-limit
https://stackoverflow.com/questions/71194882/execution-reverted-during-call-this-transaction-will-likely-revert-if-you-wish/71212745#71212745
Seems it was a VRFCoordinator version error. I have updated the contract address by VRF version 1 address and this error didn't occur again.

Yes, this helped me as well.
We have to use the v1 VRF Coordinator address and keyhash.
Both can be found here for Rinkeby:
https://docs.chain.link/docs/vrf-contracts/v1/

Thanks! Could you make a PR to the repo for the "chronological issues" section with the fix?

Thanks! Could you make a PR to the repo for the "chronological issues" section with the fix?

The error occurs when people (like myself) try to get the VRF Coordinator address by themselves instead of just copying it from the repo. By getting the address on our own we can accidentally end up on the version 2 contract address page.
In other words, the repo should work just fine how it is. The repo is correct, because it has the v1 VRF Coordinator address in the brownie-config.yaml.

Thanks! Could you make a PR to the repo for the "chronological issues" section with the fix?

I just made a PR to the repo for the "chronological issues" with a small note that should bring some more clarification for following people.

Thank you!


flutter 1.12.13+hotfix5 Black screen appears when loading

flutter 1.12.13+hotfix5 Black screen appears when loading

flutter v1.9.1+hotfix.6 Display normal
Please How to solve it.

12/21 18:59:21: Launching 'app' on OPPO PADM00.
$ adb shell am start -n "flutter2.flutter_app2/flutter2.flutter_app2.MainActivity" -a android.intent.action.MAIN -c android.intent.category.LAUNCHER
Waiting for process to come online...
Connected to process 21093 on device 'oppo-padm00-MJPVZL9THY7SAALR'.
Capturing and displaying logcat messages from application. This behavior can be disabled in the "Logcat output" section of the "Debugger" settings page.
I/ResourceExtractor: Found extracted resources res_timestamp-1-1576924733583
Resource version mismatch res_timestamp-1-1576925982542
D/FlutterActivityAndFragmentDelegate: Setting up FlutterEngine.
No preferred FlutterEngine was provided. Creating a new FlutterEngine for this FlutterFragment.
I/ResourceExtractor: Extracted baseline resource assets/flutter_assets/kernel_blob.bin
I/ResourceExtractor: Extracted baseline resource assets/flutter_assets/vm_snapshot_data
I/ResourceExtractor: Extracted baseline resource assets/flutter_assets/isolate_snapshot_data
D/libEGL: ARC_TRACE: arc_initARCTraceLevel
Active EGL Table is EglArcHook
I/zygote64: android::hardware::configstore::V1_0::ISurfaceFlingerConfigs::hasWideColorDisplay retrieved: 0
W/GiFTMANAGER: OppoGiFTServiceManager::getGiFTPara nRetSize = 1
I/libARC: gli_eglCreateContextRet() tid:21093, ctx: 0x7dbaa5ef90, ARC not Enabled.
D/libEGL: ARC_TRACE: ARCASM_eglCreateContext() => ctx: 0x7dbaa5ef90
D/libEGL: ARC_TRACE: ARCASM_eglMakeCurrent(ctx:0x7dbaa5ef90)
D/FlutterActivityAndFragmentDelegate: Attaching FlutterEngine to the Activity that owns this Fragment.
I/SurfaceFactory: [static] sSurfaceFactory = com.mediatek.view.impl.SurfaceFactoryImpl@8ef20a7
D/skia_mt: canRunInCoworker = true
I/flutter: Observatory listening on http://<IP_ADDRESS>:40627/aupSjhaBEi0=/
D/WindowClient: Add to mViews: DecorView@21442b5[MainActivity], this = android.view.WindowManagerGlobal@bf1bd4a
D/OpenGLRenderer: Dumper init 4 threads <0x7dc98f6c80>
<flutter2.flutter_app2> is running.
D/OpenGLRenderer: HWUI GL Pipeline
D/ViewRootImpl[MainActivity]: hardware acceleration = true , fakeHwAccelerated = false, sRendererDisabled = false, forceHwAccelerated = false, sSystemRendererDisabled = false
D/libARC: etEventThreadFunc()::thread Begin. eventRefCnt: 1
I/InputTransport: Create ARC handle: 0x7dbaba5800
V/PhoneWindow: DecorView setVisiblity: visibility = 0, Parent = ViewRoot{ed654bb flutter2.flutter_app2/flutter2.flutter_app2.MainActivity,ident = 0}, this = DecorView@21442b5[MainActivity]
D/FlutterView: Attaching to a FlutterEngine: io.flutter.embedding.engine.FlutterEngine@2b53dd8
D/FlutterActivityAndFragmentDelegate: Executing Dart entrypoint: main, and sending initial route: /
I/Choreographer: Skipped 2 frames!  The application may be doing too much work on its main thread.
I/OpenGLRenderer: Initialized EGL, version 1.4
D/OpenGLRenderer: Swap behavior 2
D/libEGL: [GIFT] clean GIFT bit (0)
I/libARC: gli_eglCreateContextRet() tid:21336, ctx: 0x7db8e82cb8, ARC not Enabled.
D/libEGL: ARC_TRACE: ARCASM_eglCreateContext() => ctx: 0x7db8e82cb8
ARC_TRACE: ARCASM_eglMakeCurrent(ctx:0x7db8e82cb8)
D/OpenGLRenderer: [init] completed
D/HWUIExtension: MTKProgramCache.init: enable enhancement 1
I/HWUIExtension: Get disable program binary service property (0)
Initializing program atlas...
I/ProgramBinary/Service: ProgramBinaryService client side disable debugging.
ProgramBinaryService client side disable binary content debugging.
D/ProgramBinary/Service: BpProgramBinaryService.getReady
zhiyin- 1 BpProgramBinaryService::getReady()
D/ProgramBinary/Service: zhiyin- 2 BpProgramBinaryService::getReady()
BpProgramBinaryService.getProgramBinaryData
I/HWUIExtension: Program binary detail: Binary length is 193832, program map length is 104.
Succeeded to mmap program binaries. File descriptor is 87, and path is /dev/ashmem.
I/HWUIExtension: No need to use file discriptor anymore, close fd(87).
D/HWUIExtension: Dumper init 4 threads <0x7db7d25400>
<flutter2.flutter_app2> is running.
Initializing program cache from 0x0, size = -1
D/Surface: Surface::connect(this=0x7db8ed3000,api=1)
I/libARC: gli_eglCreateContextRet() tid:21292, ctx: 0x7dcf2a1ef0, ARC not Enabled.
D/libEGL: ARC_TRACE: ARCASM_eglCreateContext() => ctx: 0x7dcf2a1ef0
D/Surface: Surface::connect(this=0x7db8edc000,api=1)
D/mali_winsys: EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
D/mali_winsys: EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
D/libEGL: ARC_TRACE: ARCASM_eglMakeCurrent(ctx:0x7dcf2a1ef0)
D/libEGL: ARC_TRACE: ARCASM_eglMakeCurrent(ctx:0x0)
I/Choreographer: Skipped 12 frames!  The application may be doing too much work on its main thread.
D/libEGL: ARC_TRACE: ARCASM_eglMakeCurrent(ctx:0x7db8e82cb8)
D/HWUIExtension: MTKProgramCache.generateProgram: 1
D/HWUIExtension: createProgram 0x0000000000000001, binary 0x7e59d4f59c, length 4912, format 36705 within 506ns
MTKProgramCache.generateProgram:<PHONE_NUMBER>8
D/HWUIExtension: createProgram 0x0000000800000000, binary 0x7e59d508cc, length 4336, format 36705 within 355ns
D/libEGL: ARC_TRACE: ARCASM_eglMakeCurrent(ctx:0x7dcf2a1ef0)
D/HWUIExtension: MTKProgramCache.generateProgram: 0
D/HWUIExtension: createProgram 0x0000000000000000, binary 0x7e59d29000, length 4336, format 36705 within 497ns

https://github.com/flutter/flutter/issues/47287#issuecomment-566879767

Hi @ltq2017
can you please provide  a minimal code sample
or the steps to reproduce the problem.
Thank you

flutter_test2.zip
code example

Hi @ltq2017
can you please provide a minimal code sample
or the steps to reproduce the problem.
Thank you

example code file
flutter_test2.zip
flutter_test.zip

Hi @ltq2017
can you please provide a minimal code sample
or the steps to reproduce the problem.
Thank you

same issues

same issues

same issues

same issues

same issues

Same Issue. Any one got it resolved ?

same issue

has someone solved the problem,please?
Thank you！

same issues

has someone solved the problem,please?
Thank you！

create a  new project, then execute ”flutter build apk “ is Ok, this bug occurs when run directly.

same issues

add this can lighten it
                android:name="io.flutter.embedding.android.SplashScreenDrawable"
                android:resource="@drawable/launch_background" />```

I think maybe below code cause the issue
![image](https://user-images.githubusercontent.com/1514899/71613641-9e7fcb80-2be2-11ea-8cdb-4ce6f3f66d08.png)

same issues，how do solve it.

别要人家上传代码了，这个问题在android10下会出现，而且flutter_gallery官方的例程也会出现该问题。希望尽快解决！flutter团队，加油！

别要人家上传代码了，这个问题在android10下会出现，而且flutter_gallery官方的例程也会出现该问题。希望尽快解决！flutter团队，加油！

Don't ask others to upload the code, this problem will appear under android10, and the official routine of flutter_gallery will also have this problem. Hope to solve it soon! flutter team, come on!

Yeah, it should be fixed as soon as possible, because it affects release applications :(

add your activity meta-data in AndroidManifast.xml
<meta-data
    android:name="io.flutter.embedding.android.SplashScreenDrawable"
    android:resource="@drawable/launch_background"/>

I find a solution as shown in below link,
Please see this link https://github.com/flutter/flutter/issues/49932#issuecomment-583084421
Hope it helps somebody

I find a solution as shown in below link,
Please see this link https://github.com/flutter/flutter/issues/49932#issuecomment-583084421
Hope it helps somebody

I find a solution as shown in below link,
Please see this link https://github.com/flutter/flutter/issues/49932#issuecomment-583084421
Hope it helps somebody

not ok

@xing634325131 , I updated link pls check it once.

Pls follow the official guide https://flutter.dev/docs/development/ui/splash-screen/android-splash-screen

add this can lighten it
<meta-data
                android:name="io.flutter.embedding.android.SplashScreenDrawable"
                android:resource="@drawable/launch_background" />

I think maybe below code cause the issue， default use the splashview.
If not set, it show default black.

This fix works perfectly, but the splash screen remains in the backstack of the app, so when I press the back button the splash screen shows! is there any fix to that

Hi，哥们儿，试了你的方一，没用
发自我的iPhone

在 2020年2月10日，04:02，Taha Malas<EMAIL_ADDRESS>写道：

add this can lighten it

I think maybe below code cause the issue， default use the splashview.
If not set, it show default black.
This fix works perfectly, but the splash screen remains in the backstack of the app, so when I press the back button the splash screen shows! is there any fix to that
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

This looks very similar to #39494

Following up, this does appear to be a duplicate of #39494. Please track that issue for updates. If you believe we've made an error, please reply here with more details that explain the difference and we'll re-open this issue.
Also, please avoid commenting “me too”, “+1”, or similar on issues. Instead, we encourage you to add a thumbs-up reaction to the original comment on the linked issue. We use thumbs-up 👍
reactions as part of our issue prioritization process, so this will help get your issue addressed quicker. If you’d like to receive updates, click the subscribe button in the right hand column on the linked issue. :)

The reason of the black screen because of this
<

    <meta-data
        android:name="flutterEmbedding"
        android:value="2" />

I have solution:

remove above code in AndroidManifest.xml
Replace this code in MainActivity
<
import android.os.Bundle

import io.flutter.app.FlutterActivity
import io.flutter.plugins.GeneratedPluginRegistrant
class MainActivity: FlutterActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
GeneratedPluginRegistrant.registerWith(this)
}
}

It's worked with me.

Problem still exists on my android phone and non of the above mentioned solution worked.

[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76, locale en-DE)
    • Flutter version 1.12.13+hotfix.8 at /Users/dev/flutter/sdk
    • Framework revision 0b8abb4724 (7 weeks ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/dev/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.0

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (2 available)
    • Pixel 4           • 99061FFAZ00H36                       • android-arm64 • Android 10 (API 29)
    • iPhone 11 Pro Max • B8902A39-1CE9-4842-BAE5-9E5913285940 • ios           • com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)

version: 1.0.0+1

environment:
  sdk: ">=2.6.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  flutter_localizations:
    sdk: flutter
  kt_dart: ^0.7.0+1

  hive: ^1.4.1+1
  hive_flutter: ^0.3.0+2

  flutter_svg: ^0.17.3+1
  provider: ^4.0.4
  cupertino_icons: ^0.1.3

dev_dependencies:
  test:
  flutter_test:
    sdk: flutter
  mockito: ^4.1.1
  hive_generator: ^0.7.0+2
  build_runner: ^1.8.0

same inssues

same inssues
Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.3 19D76,
locale zh-Hans-CN)

Problem still exists on my android phone and non of the above mentioned solution worked.

[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76, locale en-DE)
    • Flutter version 1.12.13+hotfix.8 at /Users/dev/flutter/sdk
    • Framework revision 0b8abb4724 (7 weeks ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/dev/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.0

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (2 available)
    • Pixel 4           • 99061FFAZ00H36                       • android-arm64 • Android 10 (API 29)
    • iPhone 11 Pro Max • B8902A39-1CE9-4842-BAE5-9E5913285940 • ios           • com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)

version: 1.0.0+1

environment:
  sdk: ">=2.6.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  flutter_localizations:
    sdk: flutter
  kt_dart: ^0.7.0+1

  hive: ^1.4.1+1
  hive_flutter: ^0.3.0+2

  flutter_svg: ^0.17.3+1
  provider: ^4.0.4
  cupertino_icons: ^0.1.3

dev_dependencies:
  test:
  flutter_test:
    sdk: flutter
  mockito: ^4.1.1
  hive_generator: ^0.7.0+2
  build_runner: ^1.8.0

Create a new issue should be better.

Create a new issue should be better.

@ windows7lake  @CaptMustache @githubjin This issue has been resolved by #52913, which has not reached the stable channel yet. It looks like it has been tagged first at v1.16.3, which is currently available on the dev channel. Please check and see if the issue persists on that channel before filing another issue.

@Piinks Finally I can confirm that my issue is now completely resolved after a long while 👍 Thank you all guy. 🥂 🥂 🥂  I really appreciate for your commitment.

When using Flutter beta channel (1.17.0) I can observe that on Android the short black screen between splash screen and initial frame of Flutter in release mode occurs on average 1 out of 3 launches.
What I do to test is:

Launch the app, looks OK
Kill the app by swiping in task manager
Launch again, looks OK
Kill the app
Launch again, most of the time black screen blinks for a split second

~When using Flutter beta channel (1.17.0) I can observe that on Android the short black screen between splash screen and initial frame of Flutter in release mode occurs on average 1 out of 3 launches.~
~What I do to test is:~
~1. Launch the app, looks OK~
~2. Kill the app by swiping in task manager~
~3. Launch again, looks OK~
~4. Kill the app~
~5. Launch again, most of the time black screen blinks for a split second~
Edit: ok, I copied the metadata from project generated on Flutter 1.17 in AndroidManifest. Now it works as described in the PR.
<activity
    android:name=".MainActivity"
    android:launchMode="singleTop"
    android:theme="@style/LaunchTheme"
    android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
    android:hardwareAccelerated="true"
    android:windowSoftInputMode="adjustResize">
    <!-- Specifies an Android theme to apply to this Activity as soon as
            the Android process has started. This theme is visible to the user
            while the Flutter UI initializes. After that, this theme continues
            to determine the Window background behind the Flutter UI. -->
    <meta-data
        android:name="io.flutter.embedding.android.NormalTheme"
        android:resource="@style/NormalTheme"
        />
    <!-- Displays an Android View that continues showing the launch screen
            Drawable until Flutter paints its first frame, then this splash
            screen fades out. A splash screen is useful to avoid any visual
            gap between the end of Android's launch screen and the painting of
            Flutter's first frame. -->
    <meta-data
        android:name="io.flutter.embedding.android.SplashScreenDrawable"
        android:resource="@drawable/launch_background"
        />
    <intent-filter>
        <action android:name="android.intent.action.MAIN"/>
        <category android:name="android.intent.category.LAUNCHER"/>
    </intent-filter>
</activity>

I guess only this line make it works

~When using Flutter beta channel (1.17.0) I can observe that on Android the short black screen between splash screen and initial frame of Flutter in release mode occurs on average 1 out of 3 launches.~
~What I do to test is:~
~1. Launch the app, looks OK~
~2. Kill the app by swiping in task manager~
~3. Launch again, looks OK~
~4. Kill the app~
~5. Launch again, most of the time black screen blinks for a split second~
Edit: ok, I copied the metadata from project generated on Flutter 1.17 in AndroidManifest. Now it works as described in the PR.
<activity
    android:name=".MainActivity"
    android:launchMode="singleTop"
    android:theme="@style/LaunchTheme"
    android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
    android:hardwareAccelerated="true"
    android:windowSoftInputMode="adjustResize">
    <!-- Specifies an Android theme to apply to this Activity as soon as
            the Android process has started. This theme is visible to the user
            while the Flutter UI initializes. After that, this theme continues
            to determine the Window background behind the Flutter UI. -->
    <meta-data
        android:name="io.flutter.embedding.android.NormalTheme"
        android:resource="@style/NormalTheme"
        />
    <!-- Displays an Android View that continues showing the launch screen
            Drawable until Flutter paints its first frame, then this splash
            screen fades out. A splash screen is useful to avoid any visual
            gap between the end of Android's launch screen and the painting of
            Flutter's first frame. -->
    <meta-data
        android:name="io.flutter.embedding.android.SplashScreenDrawable"
        android:resource="@drawable/launch_background"
        />
    <intent-filter>
        <action android:name="android.intent.action.MAIN"/>
        <category android:name="android.intent.category.LAUNCHER"/>
    </intent-filter>
</activity>

I guess only this line make it works
 <meta-data android:name="io.flutter.embedding.android.SplashScreenDrawable" android:resource="@drawable/launch_background" />

Thanks, worked for me

add this can lighten it
<meta-data
                android:name="io.flutter.embedding.android.SplashScreenDrawable"
                android:resource="@drawable/launch_background" />

I think maybe below code cause the issue， default use the splashview.
If not set, it show default black.

This works like a Charm @proghjy Thank you

add your activity meta-data in AndroidManifast.xml
<meta-data
    android:name="io.flutter.embedding.android.SplashScreenDrawable"
    android:resource="@drawable/launch_background"/>

This works like a charm. Thank you @proghjy

I'm still getting this issue both on Android and iOS using Flutter stable 1.22.5. Is there any news about this ?

I'm still getting this issue both on Android and iOS using Flutter stable 1.22.5. Is there any news about this ?

@AlmogRnD
this issue was closed almost a year ago and is not actively worked on
please open a new issue providing your flutter doctor -v, your flutter run -v
and a minimal reproducible code sample

@AlmogRnD
this issue was closed almost a year ago and is not actively worked on
please open a new issue providing your flutter doctor -v, your flutter run -v
and a minimal reproducible code sample

@iapicca thanks I already did that yesterday https://github.com/flutter/flutter/issues/73418

@iapicca thanks I already did that yesterday https://github.com/flutter/flutter/issues/73418

Using this plugin as dev dependency solved the issue
flutter_native_splash
Add to your Pubspec
dev_dependencies:
  flutter_test:
    sdk: flutter

  flutter_native_splash: ^1.2.0
flutter_native_splash:
  color: "#32b3a4"
  image: assets/logo.png #u must place logo.png in your assets folder
  android: true
  ios: true

flutter:
  uses-material-design: true

More customization are given in the ReadMe of the plugin


Changing these device settings shouldn't cause firmware to re-initialize

Changing these settings causes the firmware to re-initialize unnecessarily:

FBOS Auto Update
Autosync
Automatic factory reset
Connection attempt period


AP-3713: Bring proto markdown tools from trustero/monorepo

AP-3713: Bring over proto-markdown utils
We wish to provide markdown capabilities for our proto types. To avoid dependencies to
private repos, the markdown utitlites have been extracted and will now be imported from the
api repo

Current dependencies on/for this PR:

main

PR #8   👈

This comment was auto-generated by Graphite.

Merged into main.


[Bug Report] Cannot train on z: interfaces disagree on shape?

Description
Also, in case anyone reads this, I keep getting this issue that is really annoying to track down. When I switch from hook point hook_mlp_out to attn.hook_zafter a fixed number of training epochs (or whatever you'd call these; for me its 9 with batch size 128 as you'll see below). It fails with the error (first error, then config on the bottom as a JSON which is passed as kwargs)
Has anyone run into this error and found a fix? What is going on?
Error
Traceback (most recent call last):
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/saes.py", line 184, in train_saes
    sparse_autoencoder: TrainingSAE = sae_training_runner.run()
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/sae_training_runner.py", line 81, in run
    sae = self.run_trainer_with_interruption_handling(trainer)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/sae_training_runner.py", line 124, in run_trainer_with_interruption_handling
    sae = trainer.fit()
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/training/sae_trainer.py", line 172, in fit
    self._run_and_log_evals()
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/training/sae_trainer.py", line 321, in _run_and_log_evals
    eval_metrics = run_evals(
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/evals.py", line 28, in run_evals
    losses_df = recons_loss_batched(
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/evals.py", line 98, in recons_loss_batched
    score, loss, recons_loss, zero_abl_loss = get_recons_loss(
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/evals.py", line 196, in get_recons_loss
    recons_loss = model.run_with_hooks(
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/transformer_lens/hook_points.py", line 358, in run_with_hooks
    return hooked_model.forward(*model_args, **model_kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/transformer_lens/HookedTransformer.py", line 550, in forward
    residual = block(
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/transformer_lens/components.py", line 1585, in forward
    self.attn(
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/transformer_lens/components.py", line 587, in forward
    z = self.calculate_z_scores(v, pattern)  # [batch, pos, head_index, d_head]
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/transformer_lens/components.py", line 764, in calculate_z_scores
    z = self.hook_z(
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1595, in _call_impl
    hook_result = hook(self, args, result)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/transformer_lens/hook_points.py", line 77, in full_hook
    return hook(module_output, hook=self)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/evals.py", line 140, in standard_replacement_hook
    activations = sae.decode(sae.encode(activations)).to(activations.dtype)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/training/training_sae.py", line 156, in encode
    feature_acts, _ = self.encode_with_hidden_pre(x)
  File "/home/ubuntu/git/IfYouDontUnderstandItDontUseIt/src/.venv/lib/python3.10/site-packages/sae_lens/training/training_sae.py", line 176, in encode_with_hidden_pre
    sae_in = self.hook_sae_input(x - (self.b_dec * self.cfg.apply_b_dec_to_input))
RuntimeError: The size of tensor a (64) must match the size of tensor b (1024) at non-singleton dimension 3

Configuration
{
    "model_name": "tiny-stories-1L-21M",
    "model_class_name": "HookedTransformer",
    "hook_name": "blocks.0.attn.hook_z",
    "hook_eval": "NOT_IN_USE",
    "hook_layer": 0,
    "hook_head_index": null,
    "dataset_path": "apollo-research/roneneldan-TinyStories-tokenizer-gpt2",
    "streaming": true,
    "is_dataset_tokenized": true,
    "context_size": 256,
    "use_cached_activations": false,
    "cached_activations_path": null,
    "d_in": 1024,
    "d_sae": 16384,
    "b_dec_init_method": "geometric_median",
    "expansion_factor": 16,
    "activation_fn": "relu",
    "normalize_sae_decoder": true,
    "noise_scale": 0.0,
    "from_pretrained_path": null,
    "apply_b_dec_to_input": true,
    "decoder_orthogonal_init": false,
    "decoder_heuristic_init": false,
    "init_encoder_as_decoder_transpose": false,
    "n_batches_in_buffer": 64,
    "training_tokens": 50000000,
    "finetuning_tokens": 0,
    "store_batch_size_prompts": 16,
    "train_batch_size_tokens": 128,
    "normalize_activations": false,
    "device": "cuda",
    "act_store_device": "cuda",
    "seed": 42,
    "dtype": "float32",
    "prepend_bos": true,
    "autocast": false,
    "autocast_lm": false,
    "compile_llm": false,
    "llm_compilation_mode": null,
    "compile_sae": false,
    "sae_compilation_mode": null,
    "adam_beta1": 0,
    "adam_beta2": 0.999,
    "mse_loss_normalization": null,
    "l1_coefficient": 0.001,
    "lp_norm": 1.0,
    "scale_sparsity_penalty_by_decoder_norm": false,
    "l1_warm_up_steps": 0,
    "lr": 0.0004,
    "lr_scheduler_name": "constant",
    "lr_warm_up_steps": 10000,
    "lr_end": 4e-05,
    "lr_decay_steps": 0,
    "n_restart_cycles": 1,
    "finetuning_method": null,
    "use_ghost_grads": false,
    "feature_sampling_window": 1000,
    "dead_feature_window": 1000,
    "dead_feature_threshold": 0.0001,
    "n_eval_batches": 10,
    "eval_batch_size_prompts": null,
    "log_to_wandb": true,
    "log_activations_store_to_wandb": false,
    "log_optimizer_state_to_wandb": false,
    "wandb_project": "sae_lens_tutorial",
    "wandb_id": null,
    "run_name": "16384-L1-0.001-LR-0.0004-Tokens-5.000e+07",
    "wandb_entity": null,
    "wandb_log_frequency": 10,
    "eval_every_n_wandb_logs": 100,
    "resume": false,
    "n_checkpoints": 0,
    "checkpoint_path": "my folder/my folder/my older/my folder/my folder/random string SAE lens appends apparently",
    "verbose": true,
    "model_kwargs": {},
    "model_from_pretrained_kwargs": {},
    "sae_lens_version": "3.0.0",
    "sae_lens_training_version": "3.0.0",
    "tokens_per_buffer": 2097152
}

Code that Passes in Configuration
cfg = LanguageModelSAERunnerConfig(
                **config_copy,
)
import json # XXX
print(json.dumps(cfg.__dict__, indent=4)) # XXX  <------ prints out what we said above
# NOTE this is used implicitely in `language_model_sae_runner`
layer_checkpoint_path = Path(cfg.checkpoint_path)
layer_checkpoint_path.mkdir(
    parents=True, exist_ok=False
)
layer = cfg.hook_layer
assert isinstance(layer, int)
sae_training_runner = SAETrainingRunner(cfg)
sparse_autoencoder: TrainingSAE = sae_training_runner.run() # <------ FAIL

Solution (Not Acceptable)
Turn off wandb logging or comment out the some of the code in site-packages
I can also just decode to never use z values and use MLP out. This works:
{
    ...
    "hook_name": "blocks.0.hook_mlp_out",
    ...
}

More Notes

It is able to train fine until an evaluation; it is the FIRST such evaluation
During training it is able to properly reshape the activations, but upon this FIRST evaluation it FAILS
When you train, activation sizes incoming are size n_ctx x 1 x d_model (which gets indexed on that 2nd index) whereas when you eval the size is n_batch x n_ctx x n_heads x d_head where n_heads x d_head = d_model => Maybe things are not getting properly reshaped? You can look at the difference between self.activation_store.next_batch() in sae_trainer.py and eval_tokens = activation_store.get_batch_tokens(eval_batch_size_prompts) in evals.py. Note that the latter is inputting into the MODEL and flowing through (latter) whereas the former was somehow getting from an activation cache (I have not yet fully understood the internal mechanism used by this.

I wonder if a disagreement between the caller and this in training_sae.py is responsible. Look:
THIS (training_sae.py, constructor)
# The training SAE will assume that the activation store handles
# reshaping.
self.reshape_fn_in = lambda x: x

VERSUS (evals.py, get_recons_loss)
def standard_replacement_hook(activations: torch.Tensor, hook: Any):
    # Handle rescaling if SAE expects it
    if activation_store.normalize_activations:
        activations = activation_store.apply_norm_scaling_factor(activations)

    # SAE class agnost forward forward pass.
    print("="*100) # XXX <------------ DOES print
    print("ACTIVATIOSN IN STANDARD REPLACEMENT HOOK", activations.shape) # XXX <----- error source
    activations = sae.decode(sae.encode(activations)).to(activations.dtype)
    print("+"*100) # XXX <---- does NOT print

    # Unscale if activations were scaled prior to going into the SAE
    if activation_store.normalize_activations:
        activations = activation_store.unscale(activations)
    return activations

AND
# we would include hook z, except that we now have base SAE's
# which will do their own reshaping for hook z.
has_head_dim_key_substrings = ["hook_q", "hook_k", "hook_v"]
if any(substring in hook_name for substring in has_head_dim_key_substrings):
    if head_index is None:
        replacement_hook = all_head_replacement_hook
    else:
        replacement_hook = single_head_replacement_hook
else:
    print("STANDARD REPLACEMENT HOOK") # XXX  <----- this probe prints when I do my config
    replacement_hook = standard_replacement_hook

The printout is ACTIVATIOSN IN STANDARD REPLACEMENT HOOK torch.Size([16, 128, 16, 64]) (with the typo and all).
Note all these print probes I added in venv site packages, so you can ignore as part of SAE Lens.
System Info

Ubuntu AWS A10G g5.xlarge instance
Using Deep Learning OSS Pytorch AMI (on Ohio region: ami-05a1fdc12eccdf405)
Note this also happens on my home desktop
Requirements dump below:

azure-identity==1.16.0
azure-storage-blob==12.20.0
black==24.4.2
boto3==1.34.114
circuitsvis==1.41.0
click==8.1.7
datasets==2.19.1
einops==0.7.0
evaluate==0.4.2
fancy-einsum==0.0.3
fire==0.6.0
google-cloud-storage==2.16.0
ipywidgets==8.1.3
jaxtyping==0.2.29
jupyterlab==4.2.1
jupyterlab_pygments==0.3.0
jupyterlab_server==2.27.2
jupyterlab_widgets==3.0.11
notebook==7.2.0
notebook_shim==0.2.4
numpy==1.26.4
plotly==5.22.0
plotly-express==0.4.1
pydantic==2.7.2
pydantic_core==2.18.3
pytest==8.2.1
pytest-asyncio==0.21.2
pytest-profiling==1.7.0
pyyaml_env_tag==0.1
requests==2.32.2
sae-lens==3.0.0
torch==2.3.0
transformer-lens==1.17.0

Checklist

[x] I have checked that there is no similar issue in the repo (required)

Hotfix
This appears to fix it but I have not trained for many epochs:
1. Add this to the top of evals.py
# HOTFIX
def shape_safe_enc_dec(activations: torch.Tensor, sae: SAE) -> torch.Tensor:
   """
   Enable the usage of shape agnostic and non-shape agnostic SAEs by handling shape transformations on their behalf.
   """
    _in_acts = activations
    _in_shape = activations.shape
    if _in_shape[-1] != sae.cfg.d_in:
        assert len(_in_acts.shape) >= 3
        _in_acts = activations.flatten(-2, -1)
    _out_acts = sae.decode(sae.encode(_in_acts)).to(activations.dtype)
    if _out_acts.shape != _in_shape:
        # TODO(Someone) this should have some asserts over the shape going back
        # in the right way
        _out_acts = _out_acts.reshape(_in_shape)
    assert _out_acts.shape == _in_shape
    return _out_acts

2. Replace two lines in the same file
1 run_evals function should end like this:
if activation_store.normalize_activations:
    original_act = activation_store.apply_norm_scaling_factor(original_act)

# send the (maybe normalised) activations into the SAE
# HOTFIX
sae_out = shape_safe_enc_dec(original_act, sae) # HOTFIX
del cache

l2_norm_in = torch.norm(original_act, dim=-1)
l2_norm_out = torch.norm(sae_out, dim=-1)
l2_norm_in_for_div = l2_norm_in.clone()
l2_norm_in_for_div[torch.abs(l2_norm_in_for_div) < 0.0001] = 1
l2_norm_ratio = l2_norm_out / l2_norm_in_for_div

metrics = {
   ...
}

return metrics

2
def standard_replacement_hook(activations: torch.Tensor, hook: Any):
    # Handle rescaling if SAE expects it
    if activation_store.normalize_activations:
        activations = activation_store.apply_norm_scaling_factor(activations)

    # SAE class agnost forward forward pass.
    activations = shape_safe_enc_dec(activations, sae).to(activations.dtype) # HOTFIX

    # Unscale if activations were scaled prior to going into the SAE
    if activation_store.normalize_activations:
        activations = activation_store.unscale(activations)
    return activations

Happy to PR this but I'm also not 100% sure if I'm just misusing some new release or something and if not whether there is a cleaner/better way to fix this with a more top-down refactor.

Ahhh I know what's happened. Thanks for the detailed report. 3.0 involved special casing hook z for analysis so reshaping by heads is handled by the SAE class and not the store, however the activation store used in training handles the reshaping as well so that buffers don't have variable numbers of dimensions. This breaks run_evals in a way not covered by testing and which you only see when it runs part way into a training run.
I will do two - three things here:

Fix this (not sure yet what I'll do, maybe one of the things you suggested).
Add a test that would have caught this.
(Maybe) Run evals once at the start of the script so if there's an issue you see it immediately.

@4gatepylon  Let me know if you still get any issues. I didn't run a training run but I added new tests and I expect it will work now.


Add computation_usage to transaction result response object

Closes: #769

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.40%. Comparing base (b87f9c7) to head (16413ee).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   51.45%   52.40%   +0.95%
==========================================
  Files          35       35
  Lines        5446     5562     +116
==========================================
+ Hits         2802     2915     +113
+ Misses       2288     2261      -27
- Partials      356      386      +30

Flag
Coverage Δ

unittests
52.40% <100.00%> (+0.95%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Query bundles for the rebuilt operators/operands

New Pyxis module to query bundle images and ContainerImages by thier
nvrs. So we can find bundle images for the operator/operand images that
were rebuilt by us previously.
Signed-off-by: Andrei Paplauski<EMAIL_ADDRESS>

@mprahl @qixiang @gnaponie PTAL it's still WIP, but I want to know if maybe I am doing something wrong and I should correct it.

The CI is complaining due to some flake8 errors, you might want to check that.

The CI is complaining due to some flake8 errors, you might want to check that.

Yeah I know, I will do it when all the coding will be completed

As the output of this PR, I'd like to see the code determine the set of NVRs of bundle images that need to be rebuilt for the input operator/operand images. You're very close, but the last part of going from bundle image digests to NVRs is missing.

@apaplaus this is looking good. I'll review the tests after the comments are addressed.

@mprahl @gnaponie @qixiang I've added some unittests and last improvements to the code, so now it's finished and could be reviewed as a whole.

@apaplaus I haven't reviewed the unit tests yet. I will do that tomorrow. I noticed that there were no unit tests added for changes in the BOTAS advisory handler. Could you please add those.

@mprahl Sure. About testing botas advisory, maybe it's better to implement some tests after that handler will be completed? Because as I continue working on it a lot of things are changing so it would be complicated to edit tests every time some fixes/improvements are applied to the handler.

@mprahl Sure. About testing botas advisory, maybe it's better to implement some tests after that handler will be completed? Because as I continue working on it a lot of things are changing so it would be complicated to edit tests every time some fixes/improvements are applied to the handler.

@apaplaus I understand that it's frustrating but it's the price we pay for breaking up the implementation work into multiple parts. I will not +1 the PR if there is important code that is not tested as part of the PR. Other folks from the guild can override me however.
@gnaponie, what are your thoughts?

@mprahl Sure. About testing botas advisory, maybe it's better to implement some tests after that handler will be completed? Because as I continue working on it a lot of things are changing so it would be complicated to edit tests every time some fixes/improvements are applied to the handler.

@apaplaus I understand that it's frustrating but it's the price we pay for breaking up the implementation work into multiple parts. I will not +1 the PR if there is important code that is not tested as part of the PR. Other folks from the guild can override me however.
@gnaponie, what are your thoughts?

Hey @apaplaus, unfortunately I kinda agree with Matt here. I know it's really frustrating to keep updating the tests, but I wouldn't merge the MR with untested code. Perhaps would it be ok if you'd just forget about the test for the moment, and just work on the comments on the main code? And then once that's finalized you can focus on the tests (also on a separate commit).
Next time let's split the card in smaller items. It becomes too frustrating working on the same card for too long.

I'm sure @mprahl will find something :) But the MR overall looks good to me. I didn't check the tests. Once that's completed I can check again.

In additional to Giulia and Matt's comments, I only have one minor comment, it overall looks good to me.

@mprahl May I ask you for just a quick check for only major issues with the code and then I will merge it? Thx =)


Add flags allow_force_pushes & allow_force_pushes

Hi Awesomes,
Thank you so much for the great effort!
It would be great if this 2 flags could be added to the resource github_branch_protection

allow_force_pushes => boolean
allow_deletions => boolean

The API is supports in the github api in vendor.
Github reference:
https://developer.github.com/v3/repos/branches/
Thanks a lot 💌

It looks like there is already an issue open for this: #305
I just opened a PR to add support for this: #473


Question: can somehow be used on Android, stand-alone?

Is there any way to have a mini-app that all it does is to enhance images, using this repository?
If so, how can I do it? Any fork/port of it for Android, as a library?

@shallowdream204 Well, if you can port it to Java/Kotlin or use C/C++ and have some bridge to it via Java/Kotlin. It should have no UI elements at all (because Android uses its own UI framework, not having anything of PC) and use only core stuff. Then it should be possible to be used on Android.
But, on Android you have to be extra careful with memory usage. Not all devices out there have plenty of memory.


Notification on claimable gift screen

When viewing this screen from a non-web3 browser, user doesn’t get a helpful response once clicked on ‘claim gift’ button.
Reproduce this bug:

Click on a claim link
Open up a new screen with card preview and button ‘claim gift’
Click on ‘claim gift’ button
Nothing happens

Suggested solution:

Add a pop-up note once users from non-web3 browser click claim gift button.
“Oops! You can only claim gift using web3 browser. Install MetaMask, ImToken to get started.”

I’ll create this mock-up in figma and share it.

cool, thanks @Lililashka. I think this is due to portis providing a web3 client but if you dont create an account there is no unlocked wallet. this links to the other issue on defensive error handeling

made designs for all situations, with and without portis https://github.com/RadiCards/radi.cards/issues/59. probably they could help

Implemented this for now. Would disable the portis popup cause its still buggy (https://github.com/RadiCards/radi.cards/issues/73):


added legit-tests

This is a copy of #58 but using legit tests. It could be a little better, some things could be broken into a function and be reusable, but I am looking for feedback. What do you think @JedWatson?

@zackify nice tests

@benigeri thanks :)

@JedWatson status?

:+1: nice work

Thanks @zackify - we ended up going wiht #116 so I'm closing this, really appreciate the contribution though!


Labeled data plotting

An interesting feature of matplotlib which was added recently is the use of labeled data in the plotting function.
i.e. one can do
some_dict = {
    'elephant': [1, 3, 4],
    'cat': [8, 0, 7],
    'mouse': [3, 3, 3],
}
plt.scatter(some_dict, x="elephant", y="mouse")

this also works with anything that accepts indexing with "elephant" and "mouse" such as a data frame having such columns. I think this is an interesting feature worth implementing in bqplot.pyplot.

@SylvainCorlay Yeah that will be very useful. How about implementing it in the Marks itself? I feel it is useful to have other attributes in thetooltip.

@ssunkara good point.

Or allow this type of binding with the marks and axes directly, but not necessarily in the mark since we will probably want to enable  binding axis labels etc...

I think it would be great to support it, but I would advise using the
data=df keyword argument to pass the data to follow the API of matplotlib,
seaborn and other libraries that are using this approach.
On Fri, Oct 30, 2015 at 9:56 AM, Sylvain Corlay<EMAIL_ADDRESS>wrote:

Or allow this type of binding with the marks and axes directly, but not
necessarily in the mark since we will probably want to enable binding
axis labels etc...
—
Reply to this email directly or view it on GitHub
https://github.com/bloomberg/bqplot/issues/57#issuecomment-152532131.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@ellisonbg thanks. I edited the issue.

As per discussion with @ssunkara1 , the mark might not be the right place to do this. A figure-level approach might be the right approach.

FYI @ellisonbg we support this in an mpl style syntax now..

✨ 🎉 👍 💯


Support of js config file

It would be a great idea to support js config file so Env variables can be used.

Thank you for your feedback. I need more details. Can you give me an example?


pinocchio 2.9.1 build failure on osx

👋 trying to build the latest release, but run into some build issue. The error log is as below:

test error
  /tmp/pinocchio-20221120-71841-1cqh73s/pinocchio-2.9.1/build/include/pinocchio/multibody/geometry.hxx:47:34: error: no matching conversion for functional-style cast from 'const pinocchio::GeometryObject::CollisionGeometryPtr' (aka 'const shared_ptr<fcl::CollisionGeometry>') to 'fcl::CollisionObject'
        collisionObjects.push_back(fcl::CollisionObject(geom_object.geometry));
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  In file included from /tmp/pinocchio-20221120-71841-1cqh73s/pinocchio-2.9.1/src/parsers/urdf/geometry.cpp:5:
  In file included from /tmp/pinocchio-20221120-71841-1cqh73s/pinocchio-2.9.1/build/include/pinocchio/parsers/urdf.hpp:10:
  In file included from /tmp/pinocchio-20221120-71841-1cqh73s/pinocchio-2.9.1/build/include/pinocchio/multibody/geometry.hpp:448:
  /tmp/pinocchio-20221120-71841-1cqh73s/pinocchio-2.9.1/build/include/pinocchio/multibody/geometry.hxx:47:34: error: no matching conversion for functional-style cast from 'const pinocchio::GeometryObject::CollisionGeometryPtr' (aka 'const shared_ptr<fcl::CollisionGeometry>') to 'fcl::CollisionObject'
        collisionObjects.push_back(fcl::CollisionObject(geom_object.geometry));
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/3509282025/jobs/5878306372
relates to Homebrew/homebrew-core#116238

@chenrui333 Thanks for raising this issue.
Unfortunately, we do not yet support 2.9.1 for deployment.


Question about sending an email to various emails

Trying to send a single email to various emails.
Would this code work?
const toEmail = new<EMAIL_ADDRESS>bar@example.com');

Hi @johhansantana,
No that would not work. Please see this example: https://github.com/sendgrid/sendgrid-nodejs/blob/master/examples/helpers/mail/example.js#L15
Let me know if you need further assistance. Thanks!
With Best Regards,
Elmer

thank you!


[Date & Time pickers] issue with typing year part

[ ] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Hi! I was trying to use date & time pickers and I found out the year part contains 6 numbers and I was wondering if there is any props that will avoid this case. Thanks!
Current:

Expected Behavior 🤔

Expectation:
**

**
Steps to Reproduce 🕹

Steps:

https://material-ui.com/components/pickers/#datepickers
go to [Date & Time pickers] part
click year and type 6 numbers and it will happen.

Context 🔦

I try to make it type only 4 letters in years part and automatically move to month part to able to modify and type it.
Your Environment 🌎

`npx @material-ui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @material-ui/envinfo` goes here.

I'm using typescript and using chrome!

This is a native <input. Material-UI has no control over it's behavior.


Additional modes on wrap-attributes

Description

I want a small amount of additional ability, this is related to the style guide that our Team uses. The problem is in wrap-attributes.
You can see like the code example below.

NOTE:

Do not include screenshots! This library is a text processor, we need text inputs and outputs for debugging and fixing issues.
Check the list of open issues before filing a new issue.

Input
With this new feature, when I give like this input:

Expected Output
I'd like to see this output:

Environment
OS:

Given that input, use the setting wrap_attributes: preserve, and it will produce the output you want.
Also See #1404. let's make sure this is covered by that proposal.


Change test to actually test read_visium

https://github.com/theislab/scanpy/blob/8736fc3b02a6af3b7214481c2cf78a3f8f5e06bd/scanpy/tests/test_read_10x.py#L105

@dineshpalli you might give it a try

squidpy will take over, shall we remove this or add deprecation warning?


NN-4481: alerts add visor

Add VISOR alert to the list of DPS alerts
Acceptance Criteria
• Unsaved changes
The alert should be visible in the
Global Prisoner Search – for example HMPPS Digital Services - Sign in
Prisoner Profile –  for example HMPPS Digital Services - Sign in
ViSOR Nominal (PVN) is an existing alert that can be added to a prisoner profile. The type of alert is ‘MAPPP Case' and the alert is called 'ViSOR nominal’.
The alert label will appear with the other labels at the top of the Prisoner profile, when the alert has been added to a prisoner’s record.
The label should read ViSOR in capital letters (lower case i) and be #003078 coloured text with the same colour border.
The label should appear in alphabetical order like the existing labels.

Not so familiar with this area but wondering do we need a specific presence test for VISOR / PVR ?

Thanks for taking a look.
The presence of ViSOR & PVN is covered in test prisonerSearch.test.ts - line 573

Looks good to me! Well done for navigating this giant repository 😅

Thanks for taking a look. I'll merge it in.
Giant is an understatement 😅


empty profile in the list

seen on the page http://speakerinnen.org/en/profiles

Is there a test for necessary content for listed profiles?

@sabrina-ulbrich thx for sharing. Muhaha! We only have tested that only published profiles are displayed. Empty profiles shouldn't be published. I'm not sure how this special case could happen but we don't have a solution that warns us (or hides) profiles that are once published and then emptied. Do you want to write a test for this case or was it "just" a reporting?

@zaziemo I just wanted to report this issue :)

@sabrina-ulbrich :) as fabulous @tyranja found out while I was responding to the issue: this was only a test profile that we forgot to delete 😁

ok, hahaha, then I close this issue


Update cromwell and WDL bindings

Description
This PR updates the WDL bindings by updating cromwell to version 84 (latest version).
Other changes:

Removed some exclusions that aren't applicable anymore

Modified the SRTestChromosome.wdl file in gatk-sv-clinical because it fails the WDL validation with the new cromwell version. It complained about a cyclic dependency:

Failed to import 'module02/Module02.wdl' (reason 1 of 1): Failed to import 'SRTest.wdl' (reason 1 of 1): Failed to import 'SRTestChromosome.wdl' (reason 1 of 1): Failed to process workflow definition 'SRTestChromosome' (reason 1 of 1): This workflow contains a cyclic dependency:
"File stats = MergeStats.merged_stats" -> "call tasks02.MergeStats as MergeStats {"
"call tasks02.MergeStats as MergeStats {" -> "File stats = MergeStats.merged_stats"
Failed to import 'module02/SRTest.wdl' (reason 1 of 1): Failed to import 'SRTestChromosome.wdl' (reason 1 of 1): Failed to process workflow definition 'SRTestChromosome' (reason 1 of 1): This workflow contains a cyclic dependency:
"File stats = MergeStats.merged_stats" -> "call tasks02.MergeStats as MergeStats {"
"call tasks02.MergeStats as MergeStats {" -> "File stats = MergeStats.merged_stats"`

Using womtool validate from version 84 also returns the same error. The fix in the workflow was just to rename a variable (based on the newest version from the original repo) ... I don't completely understand why it works :upside_down_face:. Made the same change to the dockstore-testing/gatk-sv-clinical repo here.

In WdlBridge.scala:

JavaConverters.mapAsJavaMap is deprecated so I updated it to use what was recommended.
There was a spotbug that didn't show up before [ERROR] High: Class io.dockstore.common.WdlBridge$$anonfun$2 defines non-transient non-serializable instance field $outer [io.dockstore.common.WdlBridge$$anonfun$2] In WdlBridge.scala SE_BAD_FIELD. I added it to findbugs-exclude.xml because I think it's not applicable. If others who are more scala-savvy know how to fix it, let me know.

Issue
SEAB-4850
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running mvn clean install
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[x] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[x] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[x] Do not serve user-uploaded binary images through the Dockstore API
[x] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[x] Do not create cookies, although this may change in the future
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

Removed some exclusions that aren't applicable anymore

How do you figure this out by the way? Is there a way to configure an IDE to show this our get Maven to show exclusions that do not make sense?

Removed some exclusions that aren't applicable anymore

How do you figure this out by the way? Is there a way to configure an IDE to show this or get Maven to show exclusions that do not make sense?

No, there was no IDE/Maven setting to do this. I determined that they weren't applicable based on the comment about why they were excluded.
For the jackson-core exclusion, it was excluded because com.fasterxml.jackson.core:jackson-core 2.13.1 causes an error in some integration tests. We are now using jackson 2.13.3, and there are no errors in the integration tests so that exclusion isn't applicable anymore.
For the eu.timepit exclusion, this artifact is now also using the Scala 2.13 compiler, and I see no Scala warnings when building so I removed the exclusion.

No, there was no IDE/Maven setting to do this. I determined that they weren't applicable based on the comment about why they were excluded.

Ah rats. Looking at the comments makes sense, but I've always been curious if there was a more systematic way of doing it. In the past, we often had to exclude things to satisfy dependency convergence or what not. But as dependencies update their own transitive dependencies, that can become superfluous. (No action required)


Exclude dirs

This will allow you to specify directories you want excluded. I tried https://github.com/phaikawl/fresh which also attempts to add this feature, however it never worked quite right for me.
You add directories you want excluded via the runner.conf :
exclude_dir: assets, bower_components, something_else

:+1: Really need this option, bower breaks the usage of fresh

if @ae0000 fixes the import path we can merge it

waiting on this seriously awesome pr

This is fixed in pr #60.


new Pid design function built on sisotool

Provides a manual means of tuning a PID controller but does not attempt an automatic solution, thus its name pid_designer. Partially addresses #657 .
Uses `Sisotool` to investigate the effect of adding or subtracting an
amount `deltaK` to the proportional, integral, or derivative (PID) gains of
a controller. One of the PID gains, `Kp`, `Ki`, or `Kd`, respectively, can
be modified at a time. `Sisotool` plots the step response, frequency
response, and root locus.

When first run, `deltaK` is set to 1; click on a branch of the root locus
plot to try a different value. Each click updates plots and prints
the corresponding `deltaK`. To tune all three PID gains, repeatedly call
`pid_designer`, and select a different `gain` each time (`'P'`, `'I'`,
or `'D'`). Make sure to add the resulting `deltaK` to your chosen initial
gain on the next iteration.

Same CI failure as in #659. #663 might work around it.

Coverage increased (+0.1%) to 90.066% when pulling b2478f23f09db980ae89e432d96ab8659e82c26d on sawyerbfuller:pid-designer into e9c224cfac55968906c89372424ca7baebf18a93 on python-control:master.

  We should clean up when we get a chance.


requirements on powershell 3.0 or above

referring to issue #38 where on powershell 2.0 any exit code other than 0 or 1 doesn't get interpreted properly by powershell if a script was executed with the -file flag.
example: powershell.exe -file .\check-windows-disk.ps1 5 10
This fix will require users to upgrade their versions of powershell (to at least version 3.0) to be able to run the checks. This is required to be able to get the correct check results back. Also included is an update to the readme stating this dependency.

I do need a changelog entry especially since this is technically a breaking change though not sure who is affected as I believe powershell 2.x is quite old...

@simonsteur can you rebase and add a changelog entry?

@majormoses done.

Although I don't think these checks could every function properly on PSv2, I do agree that it's better to play safe. I rebased and made the changes.

released: https://rubygems.org/gems/sensu-plugins-windows/versions/2.0.0


Update NPM version to 2.10.4

See https://github.com/NginxProxyManager/nginx-proxy-manager/releases/tag/v2.10.4

Hi Team, it would be nice if I could edit the docker image tag for apps in the UI. I was hoping to have the docker image be something like
image: jc21/nginx-proxy-manager:${AppVersion:-2.10.4}

however, this requires that the AppVersion variable be configurable from the interface. Is this something that can be achieved currently?

We will provide the installation of custom labels in a later version


Feature avatar update

Apply this new update ( Kiran Kadariya and Jay Bhatia )

(Kiran Kadariya and Jay Bhatia )

KIran Kadariya and Jay Bhatia CSCI Update feature

Missing video demo. Additionally, feature not requested and not part of list of open tickets - https://github.com/3C-SCSU/Avatar/issues . Submission not invited by Cloud Computing Club. Pull request denied.


Anchor fails to deserialize #[account] annotated types as instruction arguments even though they're defined in the IDL.

Something like:
#[account]
pub struct State { x: u64, ... }

cannot be used as the type of an input to some instruction:
pub fn initialize(ctx: Context<Initialize>, input: State) -> Result<()> {
    ctx.accounts.state.set_inner(state); ...
}

Deserialization fails on the client with IdlError: Type not found: {"name":"input","type":{"defined":"State"}} even though the State type is defined in the IDL.
Attempting this:
#[derive(AnchorSerialize, AnchorDeserialize)
pub struct StateEntry(State);

as a bypass doesn't work. It looks like tuple structs aren't supported.
Neither does:
#[derive(AnchorSerialize, AnchorDeserialize)
#[account]
pub struct State { x: u64 };

due to multiple derived implementations.
This means users need to write a mirror type for the State type, which seems unnecessary. For example:
impl From<StateEntry> for State {
    fn from(se: StateEntry) -> Self {
        State {
            update_authority: se.update_authority,
            marinade_state: se.marinade_state,
            sunrise_state: se.sunrise_state,
            vault_authority_bump: se.vault_authority_bump,
            treasury: se.treasury,
        }
    }
}

is code I had to write to get around this

Indeeed I have the same issue. This is because of the idl. In the args of my instruction:
  "args": [
        {
          "name": "state",
          "type": {
            "defined": "State"
          }
        }
      ]

I think it is caused by the   "defined": "State" State being in capital. I changed it to state manual and it worked. But thi is not a solution. Adding a extra type because of this.

Fixed by https://github.com/coral-xyz/anchor/pull/2824.


update Topten.RichTextKit to 0.4.145

Rebased to current master and fixed conflicts with #1194.

Note: Apart from simply updating the RichTextKit version here, I have also added a dependency on it in Mapsui.Forms.nuspec.
I'm not sure if this is strictly required or not. At least RichTextKit is used in Mapsui.UI.Forms. In principle there is already an implicit dependency on RichTextKit via Mapsui.Forms -> Mapsui -> RichTextKit. This might already be sufficient. However, SkiaSharp (for example) is also used as an explicit dependency in Mapsui and Mapsui.Forms (and Mapsui.Native).

Note: Apart from simply updating the RichTextKit version here, I have also added a dependency on it in Mapsui.Forms.nuspec.
I'm not sure if this is strictly required or not. At least RichTextKit is used in Mapsui.UI.Forms. In principle there is already an implicit dependency on RichTextKit via Mapsui.Forms -> Mapsui -> RichTextKit. This might already be sufficient. However, SkiaSharp (for example) is also used as an explicit dependency in Mapsui and Mapsui.Forms (and Mapsui.Native).

Not sure what's the best policy here. In general I would go for minimal. So, if not needed then don't add. A motivation to add it explicitly is if it used expliciet in the project. So if in Mapsui.Forms we do things with RichTextKit itself that might be a reason to add it.

I can remove the RichTextKit project reference from Mapsui.Forms and everything still compiles, so it is not used in there. So perhaps we should not add the nuget dependency.
There one 'using Topten.RichTextKit;' but it is unnecessary.
You say:

However, SkiaSharp (for example) is also used as an explicit dependency in Mapsui and Mapsui.Forms (and Mapsui.Native).

I don't see what you are referring to. The mapsui.forms.nuspec only refers to 'SkiaSharp.Views.Forms'.

RichTextKit is used for Callouts. They move sometime from Forms to the native part, so that all UI could use them. That is the reason, why Mapsui.Forms no longer need a reference.

I can remove the RichTextKit project reference from Mapsui.Forms and everything still compiles, so it is not used in there. So perhaps we should not add the nuget dependency.
There one 'using Topten.RichTextKit;' but it is unnecessary.

Ah, right. I removed that one, and also removed the package reference to RichTextKit from Mapsui.UI.Forms, so that adding the nuspec reference is indeed not necessary (I removed that commit from the branch and rebased to fix conflicts).

However, SkiaSharp (for example) is also used as an explicit dependency in Mapsui and Mapsui.Forms (and Mapsui.Native).

I don't see what you are referring to. The mapsui.forms.nuspec only refers to 'SkiaSharp.Views.Forms'.

Right. Sorry for the confusion. (Also this was slightly cleanup up in #1196.)

Thank you for cleaning up the code 👍


Update authoring docs for 1.1.4

@angelazhangmsft  Do C++ project references need to set Implementation on the winmd after the manual reference?

@angelazhangmsft Do C++ project references need to set Implementation on the winmd after the manual reference?

No this doesn't seem to be required. I think it's because of the exe.manifest registrations


Add two Prometheus metrics for director stat queries

Closes #1431
To test, first spin up your director. If you'd like to also test a local file, then you'll need to spin up your local federation (director, registry, origin)

Get the test file through the origin: curl -k -o /dev/null https://localhost:8444/api/v1.0/director/ospool/uc-shared/public/OSG-Staff/validation/test.txt. Assuming that your local director runs at 8444
Check the Prometheus /metric endpoint to confirm the value. Login to your director web UI and go to https://localhost:8444/metrics. You should see two metrics named pelican_director_stat_active and pelican_director_stat_total where the value of pelican_director_stat_total should be 1 (for the test file you just queried)

@jhiemstrawisc This should be one of the items to backport to 7.9.1


refactor(pie-link): DSW-2280 use classes instead of attributes for styling

Describe your changes (can list changeset entries if preferable)

Use classes instead of attributes for styling pie-link.
Update component generator to reduce the number of type changes in future.

Author Checklist (complete before requesting a review)

[x] I have performed a self-review of my code
[ ] I have reviewed the PIE Storybook PR preview
[ ] I have reviewed visual test updates properly before approving
[x] If changes will affect consumers of the package, I have created a changeset entry.
[ ] If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)
Reviewer 1

[ ] I have reviewed the PIE Storybook PR preview
[ ] If there are visual test updates, I have reviewed them

Reviewer 2

[ ] I have reviewed the PIE Storybook PR preview
[ ] If there are visual test updates, I have reviewed them

/snapit


KP Compagne preparation

Hello @zeroSteiner ,
we are going to start a phishing compagne of more than 13000 users , what do you recommande us,
for email list that contain more than 13000 users is it better to splie it on 3 lists or use all in one list,
i want you give us more recommandations befor starting the compagne
Thank You

Send all 13000 at once. In the future please try to limit opening issues to legitimate bug reports. This is third day in a row that an issue with a basic questions has been opened and I can't continue to answer each one. I suggest you try to answer your questions through experimentation and trial and error in the future instead of coming straight here to ask.


Links cannot be drawn when zoomed

When zoom is not 100%, drawing links doesn't work either in connect mode or with shift-click-drag.

Fixed this plus a number of other anomalies when editing while zoomed.


Adding a policy will always fail authorization

In this modified snippet from the Isolated-Net6 sample, adding any policy will cause authorization to always fail.
services.AddOpenIDConnect(config =>
{
    var audience = Environment.GetEnvironmentVariable("OpenIdConnect_Audience");
    var issuer = Environment.GetEnvironmentVariable("OpenIdConnect_Issuer");
    var issuerUrl = Environment.GetEnvironmentVariable("OpenIdConnect_IssuerUrl");

    config.SetTokenValidation(TokenValidationParametersHelpers.Default(audience, issuer));
    config.SetIssuerBaseUrlConfiguration(issuerUrl);

    config.AddPolicy("DefaultPolicy", policy =>
    {
        policy.RequireClaim("scope", "myscope");
    });
});

It would seem no IAuthorizationHandler for the policy is added to the IAuthorizationService. Looks like same issue is reported here #18.
What is the intended way to add a policy?

This seemed to work exactly as expected in v0.71 Snowdrop, but was broken in the following release and ever since....


Extension description renders misformatted workspace trust string

Steps to Reproduce:

Install the Volar extension in insiders.vscode.dev
:bug: see this workspaceTrust string below the Install / Disable buttons:

It seems the extension is not having nls value for this string. Hence transferred this issue - https://github.com/johnsoncodehk/volar/issues/1516


[SPARK-22226][SQL] splitExpression can create too many method calls in the outer class

What changes were proposed in this pull request?
SPARK-18016 introduced NestedClass to avoid that the many methods generated by splitExpressions contribute to the outer class' constant pool, making it growing too much. Unfortunately, despite their definition is stored in the NestedClass, they all are invoked in the outer class and for each method invocation, there are two entries added to the constant pool: a Methodref and a Utf8 entry (you can easily check this compiling a simple sample class with janinoc and looking at its Constant Pool). This limits the scalability of the solution with very large methods which are split in a lot of small ones. This means that currently we are generating classes like this one:
class SpecificUnsafeProjection extends org.apache.spark.sql.catalyst.expressions.UnsafeProjection {
...
  public UnsafeRow apply(InternalRow i) {
     rowWriter.zeroOutNullBytes();
     apply_0(i);
     apply_1(i);
...
    nestedClassInstance.apply_862(i);
    nestedClassInstance.apply_863(i);
...
    nestedClassInstance1.apply_1612(i);
    nestedClassInstance1.apply_1613(i);
...
  }
...
  private class NestedClass {
    private void apply_862(InternalRow i) { ... }
    private void apply_863(InternalRow i) { ... }
...
  }
  private class NestedClass1 {
    private void apply_1612(InternalRow i) { ... }
    private void apply_1613(InternalRow i) { ... }
...
  }
}

This PR reduce the Constant Pool size of the outer class by adding a new method to each nested class: in this method we invoke all the small methods generated by splitExpression in that nested class. In this way, in the outer class there is only one method invocation per nested class, reducing by orders of magnitude the entries in its constant pool because of method invocations. This means that after the patch the generated code becomes:
class SpecificUnsafeProjection extends org.apache.spark.sql.catalyst.expressions.UnsafeProjection {
...
  public UnsafeRow apply(InternalRow i) {
     rowWriter.zeroOutNullBytes();
     apply_0(i);
     apply_1(i);
     ...
     nestedClassInstance.apply(i);
     nestedClassInstance1.apply(i);
     ...
  }
...
  private class NestedClass {
    private void apply_862(InternalRow i) { ... }
    private void apply_863(InternalRow i) { ... }
...
    private void apply(InternalRow i) {
      apply_862(i);
      apply_863(i);
      ...
    }
  }
  private class NestedClass1 {
    private void apply_1612(InternalRow i) { ... }
    private void apply_1613(InternalRow i) { ... }
...
    private void apply(InternalRow i) {
      apply_1612(i);
      apply_1613(i);
      ...
    }
  }
}

How was this patch tested?
Added UT and existing UTs

Can one of the admins verify this patch?

@HyukjinKwon or @cloud-fan May you help to trigger the jenkins test? Thank you.

@mgaido91 Thank you for working on this! Based on your explanation, sounds like a reasonable direction to me.

ok to test

Test build #82682 has started for PR 19480 at commit bdc2fdb.

Thank you @HyukjinKwon

Test build #82687 has started for PR 19480 at commit 831fc40.

nit: Do we need nestedClassInstance1.apply(i); in the description?

@kiszk I added just to show that there is one method for instance, but then I am missing the NestedClass1 declaration. I am adding it. Thanks.

@mgaido91 thanks, this example makes sense.

Test build #82682 has finished for PR 19480 at commit bdc2fdb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82682/
Test PASSed.

Test build #82687 has finished for PR 19480 at commit 831fc40.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82687/
Test FAILed.

Test build #82697 has started for PR 19480 at commit 76b5489.

Test build #82697 has finished for PR 19480 at commit 76b5489.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82697/
Test PASSed.

The current change LGTM.
If you can have an end-to-end test for this. This might be better. This seems not an issue very easy to encounter by end users. Can you try to have one? @mgaido91

Test build #82734 has started for PR 19480 at commit c4601b4.

Test build #82735 has started for PR 19480 at commit 61cc445.

Test build #82734 has finished for PR 19480 at commit c4601b4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82734/
Test FAILed.

sorry, the test failure is due to an OutOfMemory exception. I don't know whether it is possible to change the heap size used by sbt in the Jenkins job and I am not sure this is the right thing to do.
The problem is caused by the UT which reproduces the error in a end-to-end example. Nonetheless, there is the first UT I added which tests that the patch is working. IMHO we might get rid of this new UT and rely on the original one in order not to waste resources.
Let me know what you think about this and what I should do.
Thanks.

Test build #82735 has finished for PR 19480 at commit 61cc445.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82735/
Test FAILed.

Test build #82758 has started for PR 19480 at commit 37506dc.

Test build #82758 has finished for PR 19480 at commit 37506dc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82758/
Test PASSed.

Merged build finished. Test PASSed.

@mgaido91 It is possible to increase the heap allocated during testing if that seems like a desirable thing to do (I did so for #18075, but the current default is already 4GB), see [1] and [2] depending on which SQL module the test is in.
[1] https://github.com/apache/spark/blob/master/sql/core/pom.xml#L198
[2] https://github.com/apache/spark/blob/master/sql/catalyst/pom.xml#L137

@bdrillard thanks but we removed the "guilty" test case for many reasons. Thank you anyway.

Could you resolve conflicts, @mgaido91 ?

Test build #82858 has started for PR 19480 at commit 95b0ad8.

Test build #82861 has started for PR 19480 at commit bce3616.

Test build #82858 has finished for PR 19480 at commit 95b0ad8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82858/
Test PASSed.

Test build #82861 has finished for PR 19480 at commit bce3616.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82861/
Test PASSed.

cc @rednaxelafx Do you have a bandwidth to review this?

@kiszk Does this look good to you?

Sounds good to me. Sorry for being late since I was busy last week.

@kiszk Thanks!
@mgaido91 I have not reviewed it carefully. Will do another pass in the next few days. Thanks for your fix!

Test build #83047 has started for PR 19480 at commit 0215139.

Test build #83047 has finished for PR 19480 at commit 0215139.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83047/
Test PASSed.

Test build #83052 has started for PR 19480 at commit 41c0b2b.

Test build #83052 has finished for PR 19480 at commit 41c0b2b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83052/
Test PASSed.

Test build #83079 has started for PR 19480 at commit be84c4d.

Test build #83079 has finished for PR 19480 at commit be84c4d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83079/
Test FAILed.

Test build #83084 has started for PR 19480 at commit a39098d.

Test build #83084 has finished for PR 19480 at commit a39098d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83084/
Test PASSed.

Test build #83119 has started for PR 19480 at commit 6e8cd00.

Test build #83119 has finished for PR 19480 at commit 6e8cd00.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83119/
Test PASSed.

LGTM except two comments.
Thanks for your work!!! @mgaido91

Test build #83127 has started for PR 19480 at commit 36d8e2e.

Thank you all for your reviews. I addressed the last comments.
@gatorsmile meanwhile may I ask you to backport this to branch-2.2 when it will be merged?
Thanks.

@mgaido91 https://github.com/apache/spark/pull/18377 was reverted. I believe we are unable to merge this to 2.2. Sorry for that.

LGTM pending Jenkins

@gatorsmile sorry, I wasn't aware. Thank you anyway.

Test build #83129 has started for PR 19480 at commit 4952880.

Test build #83127 has finished for PR 19480 at commit 36d8e2e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83127/
Test PASSed.

Test build #83129 has finished for PR 19480 at commit 4952880.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83129/
Test PASSed.

Merged build finished. Test PASSed.

Thanks! Merged to master.


Add scripts for building conda package and deployingn to anaconda.org

Great project thanks for sharing!
This pull request contains scripts I used to package your project with conda and deploy it to anaconda.org (https://anaconda.org/joshbtn/neo4j-driver).  The upload location is driven by the anaconda token.
I leveraged TravisCI to deploy based on a new tag being created. The only thing that needs to be set in travis to make this work is an ANACONDA_TOKEN.
Regards,
Josh Bennett

Thanks. We'll look into this.

Hi @joshbtn
I've just started looking at this but I'm unfamiliar with Anaconda in general. Could you help me understand how this benefits users above and beyond the PyPI distribution, and how this might be achieved through our own internal build infrastructure, rather than Travis CI.
Thanks
Nigel

Hi @joshbtn
I've just started looking at this but I'm unfamiliar with Anaconda in general. Could you help me understand how this benefits users above and beyond the PyPI distribution, and how this might be achieved through our own internal build infrastructure, rather than Travis CI.
Thanks
Nigel

Anaconda is similar to PyPI in the way you distribute, however I lot of (my) corporate clients may only use anaconda repositories for download of packages and not from PyPI due to their internal IT regulations which are overly concerned with security. Therefore it would be beneficial to have all neo4j packages distributed both in PyPI and in Anaconda. This contributes to the bottomline of adoption of neo4j in python (which is the de-facto (and discussable) standard for datascience and AI projects)

I will have a look into this for the 4.0 release of the driver.

I don't think this is needed any longer as conda forge picked up the slack :raised_hands: :bow:
https://github.com/conda-forge/neo4j-python-driver-feedstock