Color: Invariant for channels within [0, 1] is not strictly enforced; implicity divison is weird

Environment

OS Version: N/A
Source or binary build? Current master (see source permalink)

Description
Came across this during @jennuine's resolution of https://github.com/osrf/sdformat/issues/193

Expected behavior:

Color channel values are all strictly w/in [0, 1]
An error is thrown (rather than weird implicit conversion)

Actual behavior: Here's what @seancurtis-tri found:

  // Case: Values out of range:
  //  A (alpha) simply gets clamped to the range [0, 1]
  //  For each individual element in R, G, B:
  //    Negative values are set to zero.
  //    Values > 1 are divided by 255

https://github.com/RobotLocomotion/drake/blob/v0.28.0/multibody/parsing/test/detail_scene_graph_test.cc#L861-L867
This is due to the following code:
https://github.com/ignitionrobotics/ign-math/blob/ad0118e689ba531c93df9c332e0c78a5dcd84e6e/src/Color.cc#L498-L511
Steps to reproduce
See code
Output
N/A
\cc @azeey

Per @jennuine's analysis, this invariant is now enforced in libsdformat XML parsing (https://github.com/osrf/sdformat/pull/519), but due to this issue, it can leak in via DOM mutators.

What's even weirder is that the copy constructor keeps dividing again on each copy, in case it was still over the limit:
https://github.com/ignitionrobotics/ign-math/blob/797f67f89c6863b5e02b6e7b24b6c587396cc614/src/Color.cc#L47-L51
Whichever of #283 or #286 merges will fix that part, though, by marked the copy constructor as defaulted.


CI: test mips-unknown-linux-musl

Closing because we are already testing a similar target: mips-unknown-linux-gnu.


Consider removing general purpose EventStream

Since now we have AsyncStream/AsyncSequence in the language, we don't really need event stream as a general capability.
We would keep one specific implementation -- the cluster events -- and that's about it.
Thanks @yim-lee for noticing this.

It could be enough to hide it first, since our internals still use it perhaps.


Intellisense errors (non-critical)

There are a bunch of intellisense errors inside the addFields() method, because the TabContract is missing some methods:

This issue is fixed in v1.1.0 released. Thanks for creating a issue.


Add Semaphor

https://spideroak.com/solutions/semaphor

[x] Checked there aren’t open pull requests for the same cask.
[x] Checked there aren’t closed issues where that cask was already refused.
[x] When naming the cask, followed the token reference.
[x] Commit message includes cask’s name.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.

Thank you.

Version check @ https://spideroak.com/semaphor/versioncheck/#{version}/darwin/x64 - didn't find a plain text one with a quick search
(current version is 1.0.4)

Judging by the download page, https://spideroak.com/releases/semaphor/osx always downloads the latest version, so we shouldn't have to worry about it being out of date. I looked for a versioned download URL, but I wasn't able to find one, unfortunately.


create altekanti.txt

The school is located in Aarau, Switzerland and has it's own dedicated school for informatics : https://altekanti.ch/
Even Albert Einstein spent few years there  : https://de.wikipedia.org/wiki/Alte_Kantonsschule_Aarau#Geschichte_2

@lukaswampfler First stage of verification passed, official domain is ag.ch as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://gesetzessammlungen.ag.ch/frontend/annex_document_dictionaries/32940

@lukaswampfler Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Update/time picker

Remove icons for AM/PM because they confused some of our users
Remove fixed-width for AM/PM button
Update guide and illustrations

Do we need to update snapshots for this component?
My locale tests are always failing for all components for some reasons 🤔


Problems with iOS 10.2 - infinity cycle

I started on a real device, but the problem can be reproduced on the simulator (I tried with iphone 7 plus iOS 10.2). If you enter some text in the textView, then select the text and click "Select All". The application will be in an infinity cycle, called layoutSubviews.
I tried to fix the problem and added a custom class for the textView. I redefine the intrinsicContentSize, it works, but there are other difficulties. Tell me how to fix this problem. The test project was add into my repository:
https://github.com/ed8009/textView-With-JVFloatLabeledTextView
The problem occurs when scrollEnabled = NO

Fix it:
if (!self.scrollEnabled && !CGSizeEqualToSize(self.bounds.size, [self intrinsicContentSize])) {     [self layoutIfNeeded]; }


Add Random Song Generator based on Mood

PR Title
Add Random Song Generator based on Mood
Summary
This PR introduces a new Python script that fetches a random song from YouTube based on a user's mood and opens the YouTube link in the browser. The script uses the YouTube Data API to search for songs related to the mood input (e.g., happy, sad, energetic).
Description
The changes include:

Added random_song_generator.py script that takes mood input and fetches related songs from YouTube.
Integrated the YouTube Data API to search for songs by mood.
Used webbrowser to open the song link in the default browser.
Added requirements.txt for dependencies.

The changes are as follows:

Created the script random_song_generator.py.
Added function to fetch songs from YouTube based on mood input.
Integrated the YouTube Data API and used webbrowser.open() to launch the video in a browser.
Added requirements.txt for dependencies (google-api-python-client).
Added script to main readme list

Checks
in the repository

[x] Made no changes that degrades the functioning of the repository
[x] Gave each commit a better title (unlike updated README.md)

Thank You,
Amazia Gur

@hasan-py is it possible to be added to the contributors wall ?


USER STORY: Log in to the App

EPIC: #3
In order to access my tasks, as a registered user, I can log in to the to-do app.
Acceptance Criteria:

Acceptance Criteria 1: User can navigate to the login page.
Acceptance Criteria 2: User can enter their email and password.
Acceptance Criteria 3: After clicking the Log In button, user is logged in.
Acceptance Criteria 4: User is redirected to the home screen upon successful login.

Tasks:

[x] Design login page
[x] Implement frontend form for entering email and password
[x] Backend: Implement API endpoint for user authentication
[x] Implement form validation

Done


Uses unsupported API in UWP

Validating UWP packages using DryWetMidi to deploy applications to the store results in
FAILED
Supported APIs
Error Found: The supported APIs test detected the following errors:
API midiInAddBuffer in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInClose in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInGetDevCapsA in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInGetErrorTextA in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInGetNumDevs in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInOpen in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInPrepareHeader in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInReset in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInStart in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInStop in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiInUnprepareHeader in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutClose in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutGetDevCapsA in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutGetErrorTextA in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutGetNumDevs in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutGetVolume in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutLongMsg in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutOpen in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutPrepareHeader in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutSetVolume in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutShortMsg in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API midiOutUnprepareHeader in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API timeKillEvent in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
API timeSetEvent in winmm.dll is not supported for this application type. Coimbra.dll calls this API.
Impact if not fixed: Using an API that is not part of the Windows SDK for Microsoft Store apps violates the Microsoft Store certification requirements.
How to fix: Review the error messages to identify the API that is not part of the Windows SDK for Microsoft Store apps. Please note, apps that are built in a debug configuration or without .NET Native enabled (where applicable) can fail this test as these environments may pull in unsupported APIs. Retest your app in a release configuration, and with .NET Native enabled if applicable. See the link below for more information:
Alternatives to Windows APIs in Microsoft Store apps. http://go.microsoft.com/fwlink/?LinkID=244022

Hi, @andreasbalzer,
Thanks for the provided failure log. I'll try to provide UWP compatible package. But please be patient, it's not super quick task :)

I'm going to dive into the task after 16 Dec after my vacation. From what I know I need to create developer account on Microsoft site to be able to validate package publishing. @andreasbalzer am I right?

Well, I've created developer account and run validation to see the same failures. I'm going to implement the system within the library to automatically create UWP compatible package.

Just was wondering on the progress on this? I think this dependency also is incompatible with .NET Native

When compiling with .NET Native the following warnings are present and the application crashes on startup
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'StartHighPrecisionTickGenerator_Mac' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.TickGeneratorApi.TG_STARTRESULT Melanchall.DryWetMidi.Multimedia.TickGeneratorApi32.StartHighPrecisionTickGenerator_Mac(System.Int32, System.IntPtr, Melanchall.DryWetMidi.Multimedia.TickGeneratorApi.TimerCallback_Mac, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'StartHighPrecisionTickGenerator_Mac' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.TickGeneratorApi.TG_STARTRESULT Melanchall.DryWetMidi.Multimedia.TickGeneratorApi64.StartHighPrecisionTickGenerator_Mac(System.Int32, System.IntPtr, Melanchall.DryWetMidi.Multimedia.TickGeneratorApi.TimerCallback_Mac, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'AreInputDevicesEqual' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'System.Boolean Melanchall.DryWetMidi.Multimedia.InputDeviceApi32.AreInputDevicesEqual(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'OpenInputDevice_Mac' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.InputDeviceApi.IN_OPENRESULT Melanchall.DryWetMidi.Multimedia.InputDeviceApi32.OpenInputDevice_Mac(System.IntPtr, System.IntPtr, Melanchall.DryWetMidi.Multimedia.InputDeviceApi.Callback_Mac, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetEventDataFromInputDevice' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.InputDeviceApi.IN_GETEVENTDATARESULT Melanchall.DryWetMidi.Multimedia.InputDeviceApi32.GetEventDataFromInputDevice(System.IntPtr, System.Int32, System.IntPtr, System.Int32)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetInputDeviceUniqueId' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.InputDeviceApi.IN_GETPROPERTYRESULT Melanchall.DryWetMidi.Multimedia.InputDeviceApi32.GetInputDeviceUniqueId(System.IntPtr, System.Int32)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetInputDeviceDriverOwner' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.InputDeviceApi.IN_GETPROPERTYRESULT Melanchall.DryWetMidi.Multimedia.InputDeviceApi32.GetInputDeviceDriverOwner(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'AreInputDevicesEqual' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'System.Boolean Melanchall.DryWetMidi.Multimedia.InputDeviceApi64.AreInputDevicesEqual(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'OpenInputDevice_Mac' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.InputDeviceApi.IN_OPENRESULT Melanchall.DryWetMidi.Multimedia.InputDeviceApi64.OpenInputDevice_Mac(System.IntPtr, System.IntPtr, Melanchall.DryWetMidi.Multimedia.InputDeviceApi.Callback_Mac, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetEventDataFromInputDevice' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.InputDeviceApi.IN_GETEVENTDATARESULT Melanchall.DryWetMidi.Multimedia.InputDeviceApi64.GetEventDataFromInputDevice(System.IntPtr, System.Int32, System.IntPtr, System.Int32)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetInputDeviceUniqueId' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.InputDeviceApi.IN_GETPROPERTYRESULT Melanchall.DryWetMidi.Multimedia.InputDeviceApi64.GetInputDeviceUniqueId(System.IntPtr, System.Int32)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetInputDeviceDriverOwner' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.InputDeviceApi.IN_GETPROPERTYRESULT Melanchall.DryWetMidi.Multimedia.InputDeviceApi64.GetInputDeviceDriverOwner(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'AreOutputDevicesEqual' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'System.Boolean Melanchall.DryWetMidi.Multimedia.OutputDeviceApi32.AreOutputDevicesEqual(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'OpenOutputDevice_Mac' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.OutputDeviceApi.OUT_OPENRESULT Melanchall.DryWetMidi.Multimedia.OutputDeviceApi32.OpenOutputDevice_Mac(System.IntPtr, System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'SendSysExEventToOutputDevice_Mac' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.OutputDeviceApi.OUT_SENDSYSEXRESULT Melanchall.DryWetMidi.Multimedia.OutputDeviceApi32.SendSysExEventToOutputDevice_Mac(System.IntPtr, System.Byte[], System.UInt16)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetOutputDeviceUniqueId' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.OutputDeviceApi.OUT_GETPROPERTYRESULT Melanchall.DryWetMidi.Multimedia.OutputDeviceApi32.GetOutputDeviceUniqueId(System.IntPtr, System.Int32)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetOutputDeviceDriverOwner' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.OutputDeviceApi.OUT_GETPROPERTYRESULT Melanchall.DryWetMidi.Multimedia.OutputDeviceApi32.GetOutputDeviceDriverOwner(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'AreOutputDevicesEqual' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'System.Boolean Melanchall.DryWetMidi.Multimedia.OutputDeviceApi64.AreOutputDevicesEqual(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'OpenOutputDevice_Mac' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.OutputDeviceApi.OUT_OPENRESULT Melanchall.DryWetMidi.Multimedia.OutputDeviceApi64.OpenOutputDevice_Mac(System.IntPtr, System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'SendSysExEventToOutputDevice_Mac' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.OutputDeviceApi.OUT_SENDSYSEXRESULT Melanchall.DryWetMidi.Multimedia.OutputDeviceApi64.SendSysExEventToOutputDevice_Mac(System.IntPtr, System.Byte[], System.UInt16)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetOutputDeviceUniqueId' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.OutputDeviceApi.OUT_GETPROPERTYRESULT Melanchall.DryWetMidi.Multimedia.OutputDeviceApi64.GetOutputDeviceUniqueId(System.IntPtr, System.Int32)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetOutputDeviceDriverOwner' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.OutputDeviceApi.OUT_GETPROPERTYRESULT Melanchall.DryWetMidi.Multimedia.OutputDeviceApi64.GetOutputDeviceDriverOwner(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'OpenSession_Mac' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.MidiDevicesSessionApi.SESSION_OPENRESULT Melanchall.DryWetMidi.Multimedia.MidiDevicesSessionApi32.OpenSession_Mac(System.IntPtr, Melanchall.DryWetMidi.Multimedia.MidiDevicesSessionApi.InputDeviceCallback, Melanchall.DryWetMidi.Multimedia.MidiDevicesSessionApi.OutputDeviceCallback, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'OpenSession_Mac' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.MidiDevicesSessionApi.SESSION_OPENRESULT Melanchall.DryWetMidi.Multimedia.MidiDevicesSessionApi64.OpenSession_Mac(System.IntPtr, Melanchall.DryWetMidi.Multimedia.MidiDevicesSessionApi.InputDeviceCallback, Melanchall.DryWetMidi.Multimedia.MidiDevicesSessionApi.OutputDeviceCallback, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'OpenVirtualDevice_Mac' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi.VIRTUAL_OPENRESULT Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi32.OpenVirtualDevice_Mac(System.IntPtr, System.IntPtr, Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi.Callback_Mac, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'CloseVirtualDevice' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi.VIRTUAL_CLOSERESULT Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi32.CloseVirtualDevice(System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'SendDataBackFromVirtualDevice' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi.VIRTUAL_SENDBACKRESULT Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi32.SendDataBackFromVirtualDevice(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetInputDeviceInfoFromVirtualDevice' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'System.IntPtr Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi32.GetInputDeviceInfoFromVirtualDevice(System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetOutputDeviceInfoFromVirtualDevice' was not found in module 'Melanchall_DryWetMidi_Native32' specified by DllImport method 'System.IntPtr Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi32.GetOutputDeviceInfoFromVirtualDevice(System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'OpenVirtualDevice_Mac' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi.VIRTUAL_OPENRESULT Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi64.OpenVirtualDevice_Mac(System.IntPtr, System.IntPtr, Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi.Callback_Mac, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'CloseVirtualDevice' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi.VIRTUAL_CLOSERESULT Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi64.CloseVirtualDevice(System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'SendDataBackFromVirtualDevice' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi.VIRTUAL_SENDBACKRESULT Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi64.SendDataBackFromVirtualDevice(System.IntPtr, System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetInputDeviceInfoFromVirtualDevice' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'System.IntPtr Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi64.GetInputDeviceInfoFromVirtualDevice(System.IntPtr)'. Calling this method would throw exception at runtime.
1>C:\Users\XXXX\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0004: The method 'GetOutputDeviceInfoFromVirtualDevice' was not found in module 'Melanchall_DryWetMidi_Native64' specified by DllImport method 'System.IntPtr Melanchall.DryWetMidi.Multimedia.VirtualDeviceApi64.GetOutputDeviceInfoFromVirtualDevice(System.IntPtr)'. Calling this method would throw exception at runtime.

Crash possibly related to

I would be interested in a version of this library that does not include any hardware interfacing bits.

@daltzctr Nothing done on UWP support, sorry. I'll think about a new package like Melanchall.DryWetMidi.Core which won't include any native parts.

That would be absolutely awesome!

I took a quick attempt at building with the 6.1.2 prerelease that's based on the nativeless CI build, seems to still barf on the UWP app. Still trying to get some more verbose exceptions/messages out of this.

Looks like it fails on just loading the 32bit dll

Okay, awesome news. I downloaded the "Binaries" artifact from https://dev.azure.com/Melanchall/DryWetMIDI/_build/results?buildId=23676&view=artifacts&pathAsName=false&type=publishedArtifacts and used the netstandard2.0 build and it looks like my application is starting and working properly! This is awesome!

@daltzctr Heh, you're faster then me :) Yes, you can use it, but it's not officially released yet, I'm still tweaking some parts to incorporate them propertly to the project structure. Thank you for checking that the package OK!

@daltzctr Well, the Melanchall.DryWetMidi.Nativeless package created and the version 6.1.2-prerelease2 available on NuGet.

All works for me!

:rocket: 6.1.2 version is released now!
Prerelease NuGet packages will be unlisted soon, so please update the package references to the new version.
Thanks for using the library!

Well, looks like UWP is almost dead nowadays. So I have no plans to proceed with this issue.


Only support Fisher

With #58, fzf.fish is fully compatible with Fisher. But Fisher v4 is designed such that plugins cannot be fully compatible with both Fisher v4 and OMF. Therefore, fzf.fish is now slightly incomptabile with OMF. Thankfully, the only incompatibility is that the uninstall script doesn't work anymore with OMF uninstall. The fish session used to uninstall fzf.fish won't have fzf.fish key bindings removed (so you have to close that session and open up a new one).
Because of that, fzf.fish now only targets full compatibility with Fisher (version >= 4.0). OMF support has been dropped but should still mostly work except uninstallation with be slightly buggy for the foreseeable future.

This is a shame, after you opened https://github.com/oh-my-fish/oh-my-fish/issues/788 I thought you were honestly interested on the community's wellbeing. I guess we were all wrong.
The good part is that it only took a couple weeks before we could see your real intention.

^ Removed unnecessarily harsh and demeaning comment from bucaran.


fail cirq's use of deprecated features in tests

Fail cirq's use of deprecated features in tests.
It also:

standardizes the deadline parameter for deprecations - it must be a valid minor version.
it forces the deprecation tests to specify this minor version
it fixes one v0.10 deprecation that went uncaught: decompose_two_qubit_interaction_into_four_fsim_gates_via_b is now removed.
it fixes incorrect deprecation of of _simulator_iterator and adds tests for it
forces the deprecation of JSON serializable objects to be tested

Fixes https://github.com/quantumlib/Cirq/issues/3848.
Fixes https://github.com/quantumlib/Cirq/issues/3847.

@maffoo PTAL, made it much more targeted!

Automerge cancelled: A status check is failing.

Automerge cancelled: A required status check is not present.
Missing statuses: ['cla/google']

We should add a page on how to deprecate stuff correctly to the contributor guide. Asking for a friend.


SAK-29895 Webservice to change the user locale.

SAK-29895 Webservice to change the user locale.

It seems like anyone can run this webservice......... is it supposed to be limited to super-users?

Should be limited to super-users? Does users have permissions to change other's locale using the PreferencesService?

I would say if user is updating their own preference, or an admin user can update anyone's preference.


Add API documentation

Does this feature exist in Emacs orgmode core?
N/A
Orgmode link
No response
Feature value
Enable easier production of plugins for orgmode.nvim.
Additional context
I have been trying my best to create some plugins for org-mode, but it has been a struggle due to (1) not seeing any reference to the API in the current documentation and (2) after finding it, I couldn't grasp my thoughts around it since its vague in description and short for the amount of functionality the plugin gives.
Would gladly help in adding documentation and examples for this if needed since, as of today, the API could be more precise if you don't know the ins and outs of the plugin.

You are absolutely right. Documentation is one of our weak points at the moment. If you have the time to compile a basic wiki page for API docs, don't hesitate! Also don't worry about it being perfect, we can iteratively improve on it :+1:


Azure Search Commitments for Java (July-December 2021)

This tracks the Azure Search Commitments for Java for the Azure SDK team

Closing as this time period has passed


Add test for affiliate contract

Add test for affiliate contract
What does this PR do?

Resolve #60

Steps to test

brew install node
make contracts-init-tests
make affiliate-contract-build
make contracts-run-tests

CheckList

[x] Follow proper Markdown format
[x] The content is adequate
[x] The content is available in both english and spanish
[x] I Ran a spell check

@adriexnet  please see conflicts


Fix go.mod for examples

While running the examples using-cron-handler and using-web-socket the following error occurs:

This is because of gofr version mismatch in require and replace statement.

Since, there is no difference in build size even after making every example a separate module. Removing go.mod for all examples (wherever present)


Retrieving connection details through file

There should be a way to connect to the MySQL server without providing login data, but the path to a file where the login data actually is. This makes it easier to switch the environments (the login credentials could differ from the local server to the production server).

Here's an example on how that file should look like:
hostname = localhost
username = root
password = p4ssw0rd
database = test
auto_reconnect = true
multi_statements = false
pool_size = 3
server_port = 3306


Use a different border color

This is a testbed for reducing the primary color usage. I'm not sure, if we should go forward with this.

You can also go to https://flathub.vercel.app and play with the color via the --color-border variable

Setting it to none also works

Let's explore this by running with it for a bit


docs: add updated example with  caikit-nlp-client

The python client has been released on pypi and is available here https://github.com/opendatahub-io/caikit-nlp-client. docs should be updated to use this new client

I'd assign myself, if only I could :slightly_smiling_face:

see #23


about robustness

In this page (http://www.angusj.com/clipper2/Docs/Robustness.htm), it says self-intersection is unavoidable. However, when I study CGAL, I found it has a snap rounding library. And it mentioned a page (Rounding Arrangements Dynamically, Leonidas J. Guibast and David H. Marimont https://dl.acm.org/doi/pdf/10.1145/220279.220300), it provides an algorithm that will not cause self-intersection.

In this page (http://www.angusj.com/clipper2/Docs/Robustness.htm), it says self-intersection is unavoidable.

Where does it say this? And I'm afraid I don't understand your point?

The paper has provided a snap rouding algorithm. With this algorithm, the arrangement may collapse, but new invert. That means the snap algorithm will never create situations in below picture, so the snap algorithm can avoid self-intersection.

Again, I'm not seeing an issue here.


Use same package naming convention across Chef FIPS platforms

We only name the Chef Windows package chef-client* (as opposed to chef* like all other platforms) for legacy reasons. There is no reason to create this same legacy issue out of the gate for the Chef FIPS package.
/cc @chef/workflow @chef/engineering-services
:construction: until this CI test build passes:
http://manhattan.ci.chef.co/job/chef-fips-trigger-ad_hoc/1/downstreambuildview/

:shipit:

:ice_cream:

:+1:

:+1:


Form.dart doc typo fixes

Came across "can ve" while experimenting with Forms using VSCode and Dart Code. Glanced over the rest of the docs for typos while I was at it.

Thanks!


Both the FID scores and visualization are pretty bad in FFHQ dataset

Hi authors:
Thanks for your work.
The original K-Diffusion paper report FID scores for FFHQ dataset (64x64) is about 2, but when we use your code repo, the FID is over 60 and the visualization results are very bad after 100 epoch with 256 batch size training. What do you think?

Best,
Tutu Iroh Zhao

I think there is a bug in the use of "accelerate launch" for launching train.py with acceleration. If you do not use "accelerate" FID is close to 2 points.


Make istio optional and sort optional parameters out

close #9
close #26

I've checked that this works correctly when istioMode is false, no sidecar istio proxy and VS are created.


add stella vault ust-glmr

vaultAddr = "0xD4df53B51Bf98363c587C2427417d3e71Af4e27A"
stratAddr = "0x9503159F1E55065aEd1A86e1678f430058CE6E1d"
wantAddr =  "0xb6835036C9A2A96D3BfB8DBE1722971fEb456a83"

conflict with EOL vault that used to issue same earned token

instead of new vault, will update strat on existing vault


Update to pipelines OWNERS

Adding myself as a reviewer to pipelines OWNERS.
@chensun do you suggest any other updates for the pipelines OWNERS?
/assign @andreyvelich @chensun

/approve

@hbelmiro I warn you that this will result in you being assigned as a reviewer to literally all PRs they get created on the website (because the other sections OWNERS don't define reviewers)

Thank you @thesuperzapper.
I removed myself from root.
@rimolive can you take a second look?

/lgtm

/lgtm


Improve: [newmm tokenizer] Change regular expression of "non-thai-characters"

What does this changes
Make the newmm tokenization more accurate; recognize more characters as "non-thai"
What was wrong
#855
It sometimes didn't recognize non-thai symbols as non-thai
"(คนไม่เอา)" -> ['(คน', 'ไม่', 'เอา', ')']
"กม/ชม" -> ['กม', '/ชม']
"สีหน้า(รถ)" -> ['สีหน้า', '(รถ)']
How this fixes it
Fixed the recognition method of "non-thai-character".
The examples above are all improved.
Your checklist for this pull request

[ ] Passed code styles and structures
[ ] Passed code linting checks and unit test

['👍👍👍 # ana', 'มาก', 'xxrep', 'xxwrep', 'น้อย', '.1146'] != ['xxwrep', '👍', '#', 'ana', 'มาก', 'xxrep', 'xxwrep', 'น้อย', '.', '1146']

It seems that this change makes the tokenization more minute than the test-case.
What do orginizers here think about this?

['👍👍👍 # ana', 'มาก', 'xxrep', 'xxwrep', 'น้อย', '.1146'] != ['xxwrep', '👍', '#', 'ana', 'มาก', 'xxrep', 'xxwrep', 'น้อย', '.', '1146']

It seems that this change makes the tokenization more minute than the test-case. What do orginizers here think about this?

Can you update the pull request? https://github.com/PyThaiNLP/pythainlp/commit/9df5a4a7963d5697488f775086fada45570ddd80

Greetings PR check

Resource not accessible by integration

I don't understand this. It this error common in this project?

['👍👍👍 # ana', 'มาก', 'xxrep', 'xxwrep', 'น้อย', '.1146'] != ['xxwrep', '👍', '#', 'ana', 'มาก', 'xxrep', 'xxwrep', 'น้อย', '.', '1146']

It seems that this change makes the tokenization more minute than the test-case. What do orginizers here think about this?

Can you update the pull request? 9df5a4a

Updated

It seems that there is unit-test error occuring by 9df5a4a

Ignorable

Yes, It's self-host issues but I don't have time to new setup. The unit-test by GitHub is look good https://github.com/PyThaiNLP/pythainlp/actions/runs/6718024461/job/18256943528

coverage: 0.0% (-87.0%) from 86.983% when pulling a5b6db4ab40cb566fa7c156a0e08774db7dffee7 on konbraphat51:dev into 9df5a4a7963d5697488f775086fada45570ddd80 on PyThaiNLP:dev.

I add some rule. https://github.com/konbraphat51/pythainlp_newmm_fix/pull/2

Hello @konbraphat51! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pythainlp/tokenize/newmm.py:

Line 42:4: E121 continuation line under-indented for hanging indent
Line 49:1: W293 blank line contains whitespace

I merged and modified @wannaphong PR. Please check.

OK. It look ['เวลา', ' ', '12:12pm ', 'มี', 'โปรโมชั่น', ' ', '11.11'] is error.  ['เวลา', ' ', '12:12pm',' ', 'มี', 'โปรโมชั่น', ' ', '11.11'] is correct.

I fixed.

In my case, fb3e7bb showed
['เวลา', ' ', '12', ':12pm ', 'มี', 'โปรโมชั่น', ' ', '11.11']
The last [^\u0E00-\u0E7F]+ scoups up all the non-thai character until it hits Thai character

In my case, fb3e7bb showed ['เวลา', ' ', '12', ':12pm ', 'มี', 'โปรโมชั่น', ' ', '11.11']
The last [^\u0E00-\u0E7F]+ scoups up all the non-thai character until it hits Thai character

https://github.com/PyThaiNLP/pythainlp/pull/856/commits/3d889f7be4cf90c30bc64285f7fdcdb6ba369656 showed
>>> from pythainlp.tokenize import word_tokenize
>>> word_tokenize("เวลา 12:12pm มีโปรโมชั่น 11.11")
['เวลา', ' ', '12:12pm', ' ', 'มี', 'โปรโมชั่น', ' ', '11.11']
>>> word_tokenize("กม/ชม")
['กม', '/', 'ชม']
>>> word_tokenize("(คนไม่เอา)")
['(', 'คน', 'ไม่', 'เอา', ')']
>>> word_tokenize("สีหน้า(รถ)")
['สีหน้า', '(', 'รถ', ')']

In my case, fb3e7bb showed ['เวลา', ' ', '12', ':12pm ', 'มี', 'โปรโมชั่น', ' ', '11.11']
The last [^\u0E00-\u0E7F]+ scoups up all the non-thai character until it hits Thai character

3d889f7 showed
>>> from pythainlp.tokenize import word_tokenize
>>> word_tokenize("เวลา 12:12pm มีโปรโมชั่น 11.11")
['เวลา', ' ', '12:12pm', ' ', 'มี', 'โปรโมชั่น', ' ', '11.11']
>>> word_tokenize("กม/ชม")
['กม', '/', 'ชม']
>>> word_tokenize("(คนไม่เอา)")
['(', 'คน', 'ไม่', 'เอา', ')']
>>> word_tokenize("สีหน้า(รถ)")
['สีหน้า', '(', 'รถ', ')']

Oh sorry, I was testing by segment() function. Didn't notice there was a post-process.
3d889f7 This seems good to me :)

Added the commentation for further maintenance.


Use EIP-1193 provider, remove hardhat/ethers dep

Demo
https://codesandbox.io/s/sweet-feather-45k4rz

Closing as this branch was merged into k1-r1/fe-demo which is itself being merged in #7


Workflow running out of memory

Describe the Bug
Worker processes not spawning with enough memory or scaling; therefore Nexflow will error with exit status 137 (not enough memory)
Steps to Reproduce
name: foo
schemaVersion: 1
workflows:
  foo:
    type:
      language: nextflow
      version: dsl2
    sourceURL: workflows/foo
contexts:
  dev:
    instanceTypes:
      - "r5.large"
    engines:
      - type: nextflow
        engine: nextflow

Child processes are spawing with 1vCPU and 1024 MEMORY
Relevant Logs
Main Process
2022-11-17T14:00:01.866-08:00	Version: 22.04.3 build 5703
2022-11-17T14:00:01.866-08:00	Created: 18-05-2022 19:22 UTC
2022-11-17T14:00:01.866-08:00	System: Linux 4.14.294-220.533.amzn2.x86_64
2022-11-17T14:00:01.866-08:00	Runtime: Groovy 3.0.10 on OpenJDK 64-Bit Server VM <IP_ADDRESS>+9-LTS
2022-11-17T14:00:01.866-08:00	Encoding: UTF-8 (ANSI_X3.4-1968)
2022-11-17T14:00:01.866-08:00	Process<EMAIL_ADDRESS>[redacted]
2022-11-17T14:00:01.866-08:00	CPUs: 2 - Mem: 2 GB (1.5 GB) - Swap: 2 GB (2 GB)
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:57.780 [main] WARN com.amazonaws.util.Base64 - JAXB is unavailable. Will fallback to SDK implementation which may be less performant.If you are using Java 9+, you will need to include javax.xml.bind:jaxb-api as a dependency.
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:57.799 [main] DEBUG nextflow.file.FileHelper - Can't check if specified path is NFS (1): redacted
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:57.799 [main] DEBUG nextflow.Session - Work-dir: redacted
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:57.799 [main] DEBUG nextflow.Session - Script base path does not exist or is not a directory: /root/.nextflow/assets/redacted/bin
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:57.871 [main] DEBUG nextflow.executor.ExecutorFactory - Extension executors providers=[AwsBatchExecutor]
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:57.886 [main] DEBUG nextflow.Session - Observer factory: DefaultObserverFactory
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:57.954 [main] DEBUG nextflow.cache.CacheFactory - Using Nextflow cache factory: nextflow.cache.DefaultCacheFactory
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:57.975 [main] DEBUG nextflow.util.CustomThreadPool - Creating default thread pool > poolSize: 3; maxThreads: 1000
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:58.123 [main] DEBUG nextflow.Session - Session start invoked
2022-11-17T14:00:01.866-08:00	Nov-17 21:53:59.049 [main] DEBUG nextflow.script.ScriptRunner - > Launching execution

Child Process
2022-11-17T14:00:01.867-08:00	Essential container in task exited - OutOfMemoryError: Container killed due to memory usage
2022-11-17T14:00:01.867-08:00	Command executed:
2022-11-17T14:00:01.867-08:00	fastp     -i USDA_soil_C35-5-1_1.fastq.gz     -I USDA_soil_C35-5-1_2.fastq.gz     -o "USDA_soil_C35-5-1.trim.R1.fq.gz"     -O "USDA_soil_C35-5-1.trim.R2.fq.gz"     --length_required 50     -h "USDA_soil_C35-5-1.html"     -w 16
2022-11-17T14:00:01.867-08:00	Command exit status:
2022-11-17T14:00:01.867-08:00	137
2022-11-17T14:00:01.867-08:00	Command output:
2022-11-17T14:00:01.867-08:00	(empty)
2022-11-17T14:00:01.867-08:00	Command error:
2022-11-17T14:00:01.867-08:00	  .command.sh: line 2:   188 Killed                  fastp -i USDA_soil_C35-5-1_1.fastq.gz -I USDA_soil_C35-5-1_2.fastq.gz -o "USDA_soil_C35-5-1.trim.R1.fq.gz" -O "USDA_soil_C35-5-1.trim.R2.fq.gz" --length_required 50 -h "USDA_soil_C35-5-1.html" -w 16

Expected Behavior
spawn processes with enough memory or scale.
Actual Behavior
Container ran out of memory
Screenshots
Additional Context
ran workflow with the following command: agc workflow run foo --context dev
Operating System: Linux
AGC Version: 1.5.1
Was AGC setup with a custom bucket: no
Was AGC setup with a custom VPC: no

I am seeing a similar behavior with cromwell.  In AWS batch, I see the following warning next to the Memory information
Configuration conflict
This value was submitted using containerOverrides.memory which has been deprecated and was not used as an override. Instead, the MEMORY value found in the job definition’s resourceRequirements key was used instead. More information about the deprecated key can be found in the AWS Batch API documentation.

I see an "Essential container in task exited". However, when I click on the job definition. It appears to have 8GB allocated memory.
Is there a different way to specify memory?

Thanks for reporting this issue. Is this an issue with the 1.5.2 release as well?

It is still an issue with v 1.5.2 (cromwell)

@spitfiredd The child processes are spawned with a default of 1vCPU and 1024 MEMORY. If tasks need more memory or CPU then you would typically make these requests as process directives for CPU and memory. (https://www.nextflow.io/docs/latest/process.html#cpus) and (https://www.nextflow.io/docs/latest/process.html#memory).

@biofilos AGC is currently using an older version of Cromwell. This older version uses the deprecated call to AWS Batch, hence the error. In our next release we will update the version of Cromwell used.
As a possible work around, you might consider deploying a miniwdl context to run the WDL.


Redundant check for missing variable

There's a conditional check for checking whether a variable is ignored when using var. This check appears in two places:
https://github.com/ballerina-platform/ballerina-lang/blob/2047bfc74e0fc77a7aa3fba4ae30ab4218e17f1a/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java#L789
https://github.com/ballerina-platform/ballerina-lang/blob/2047bfc74e0fc77a7aa3fba4ae30ab4218e17f1a/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java#L1543
The latter can probably be removed since the former checks it.

This is no longer the case in the current code base.


Gradle ignores "write only" properties in up-to-date checks

@big-guy commented on Fri Aug 19 2016
I found this in PlayRun, but there may be other tasks that have this problem.
runtimeClasspath is annotated as an @InputFiles:
https://github.com/gradle/gradle/blob/master/subprojects/platform-play/src/main/java/org/gradle/play/tasks/PlayRun.java#L67-L67
It has a setter, but no getter, so we don't see this as an actual input because we look for getters. This means we don't get an error message when it's null.
I don't know if it makes sense to change the way we search for annotations or just add a validation to the java-gradle-plugin validator that looks for this scenario.

If we end up not supporting this pattern, then we should add the validation to the inspection we do at runtime (which every task instance goes through), rather than checking in the plugin plugin at build time (which not every task goes through). Or, even better, check in both places.

The validation is already in place: https://github.com/gradle/gradle/blob/8fbc841e1d1304471064a3fe04328b4ead9cb89a/subprojects/plugin-development/src/integTest/groovy/org/gradle/plugin/devel/tasks/AbstractPluginValidationIntegrationSpec.groovy#L666-L718


City Scrapers Events Website Returns a 404

Our website is not building as of January 26th. This means that the page returns a 404 and events are unavailable.
Here is the "Page Build Warning" I received about this issue:

The page build completed successfully, but returned the following warning for the master branch:
The CNAME bonfirefan.github.io/city-scrapers-pitt/ is not properly formatted. See https://help.github.com/articles/troubleshooting-custom-domains/#github-repository-setup-errors for more information.
For information on troubleshooting Jekyll see:
https://help.github.com/articles/troubleshooting-jekyll-builds
If you have any questions you can contact us by replying to this email.

It's possible that I'm out of the loop and this is a temporary side effect of migrating our stuff out of the bonfirefan account and onto an organization account.

We are back up and running.


CSharpScript should not own method infos of the base class

CSharpScript::methods should only hold methods defined by current class.
Previous implementation stores methods defined by current class and all base classes, thus
result returned by CSharpInstance::get_method_list (which gather all method infos from current to base classes) contains duplicated method infos of base class.
The duplication can be visualized in method picking dialogue of signal connection dialogue panel.
For example, there are two C# scripts
// Test.cs
using Godot;

public partial class Test : TestBase
{
    public void Bar()
    {
        GD.Print("C# Bar");
    }
}

// TestBase.cs
using Godot;

public partial class TestBase : Node3D
{
    public void Foo()
    {
        GD.Print("C# Base");
    }
}

Attach the Test class to a node, and try to connect a signal to it. In method picking dialogue, the Foo method defined by TestBase is duplicated twice.

This pr fix the duplication issue. The behaviour of methods like CSharpScript::has_method, CSharpInstance::get_method_list are consistent with the corresponding methods of GDScript.

It feels weird to change this loop for methods and not for the others (rpc functions and event signals).
I think the proper fix would be to remove the loop from CSharpInstance::get_method_list. Other similar methods (like CSharpInstance::has_method and CSharpInstance::get_property_list) also don't have a loop because they assume the script already contains inherited methods and properties.

I suggest there to be some clarification for the meaning of Script::has_method and ScriptInstance::has_method.
In current implementation, GDScript::has_method and CSharpScript::has_method all do a simple check without looking at the base class.
https://github.com/godotengine/godot/blob/809a98216267f3066b9fec2f02b2042bdc9d3e0d/modules/gdscript/gdscript.cpp#L357-L359
https://github.com/godotengine/godot/blob/809a98216267f3066b9fec2f02b2042bdc9d3e0d/modules/mono/csharp_script.cpp#L2473-L2485
GDScriptInstance::has_method and CSharpInstance::has_method all check the method in the current class AND the base class. CSharpInstance::has_method check the existance of a method by do recursion in HasGodotClassMethod generated by ScriptMethodsGenerator.
https://github.com/godotengine/godot/blob/809a98216267f3066b9fec2f02b2042bdc9d3e0d/modules/gdscript/gdscript.cpp#L1757-L1768
In current implementation, CSharpScript::members contains methods from the current class and its base, whileGDScript:: member_functions ONLY contains method from the current class.
This PR tries to correct the contents in CSharpScript::members, which is modified by ScriptManagerBridge.UpdateScriptClassInfo, to fix the behaviour for both CSharpScript::has_method and CSharpInstance::get_method_list.
By removing the loop, CSharpScript::members only contains methods from the current class. Then the behaviour for theses method reflection functions are all consistent.
Only remove the loop from CSharpInstance::get_method_list won't fix the problem with CSharpScript::has_method.
I haven't check properties, rpc functions and signal. They might have similar issues, but I need more time to figure out.

Emm.. I just found in editor mode, there might be no actual script instance, instead a PlaceHolderScriptInstance will be created instead.
PlaceHolderScriptInstance::get_method_list will in turn calls Script::get_script_method_list. CSharpScript::get_script_method_list also iterates on the inheritance chain. Only remove the loop in CSharpInstance::get_method_list may not fix the issue.
Sorry for my inaccurate explain in the first comment. The duplication in method picking dialogue actually comes from CSharpScript::get_script_method_list rather than CSharpInstance::get_method_list, though CSharpInstance::get_method_list also returns duplicated method info. Actually these two methods contains duplicated code :(

@huisedenanhai Will you be available to finish this PR based on the feedback above? It's not in scope for 4.2 at this point, but we could merge it as soon as it's fixed up and the consensus is reached.

Superseded by https://github.com/godotengine/godot/pull/91564. Thanks for the contribution nonetheless.


Fe: Add creator in 2D preview mode

Underneath 2D mode previews it can be Creator + filename + extension
Relevant issues:

2D mode cuts off screen https://github.com/webaverse/app/issues/1156
Add filenames in 2D mode https://github.com/webaverse/app/issues/1140

Great work, closing this issue


Return a 429 for all of the back pressure stuff.

Right there are some case where we return a 500 when really it should have been a 429.
For instance, the router to count the number of request queue and circuit break when too many clients are waiting.
This results in the proper gRPC status code, but somehow the conversion somewhere along the chain is wrong and we return a 500 instead of a 429

https://github.com/quickwit-oss/quickwit/pull/4294 should fix the issue, but I don't know how to trigger the router code mentioned in the ticket. A regular ingest does not.
#[async_trait]
impl IngestRouterService for IngestRouter {
    async fn ingest(
        &mut self,
        ingest_request: IngestRequestV2,
    ) -> IngestV2Result<IngestResponseV2>{..}

I could confirm that 429 is getting returned for queue full and the semaphore in the router.


Temporarily disable periodic installs on 102

Some of the cloud 9 QE environments are down,
disabling periodic installs on 102 so we can use
this environment on demand installs.

looks ok


[Feature request] Break the build when issues are found

Hi,
Is it possible to add a feature (or if it exists, I couldn't find it) to break the build when issues are found ?
We are using Jenkins, after running the teststhe build is successful and the html report is generated, and (as expected, the vulnerabilities are left on purpose) 2 high alerts are generated for xss and sql injection vulnerabilities. In this case we would like to "break the build"
Is this currently possible ? If so, could someone please provide an example ?
Thank you so much,
Rares

Duplicate of JENKINS-30035

This issue will be closed, all future issues will be created here. The GitHub issue tracker will be closed in favor of using the Jenkins JIRA issue tracker. If you would like to reopen this issue, please do so :)


Update panic! macros to syntax for Rust 2021

A very simple PR just to fix up the build warnings you get with the old style panic! macro calls.

✅  https://doc.rust-lang.org/edition-guide/rust-2021/panic-macro-consistency.html
Thanks!


InvalidPathException on last index pattern<EMAIL_ADDRESS>-1]

In version 2.0.0 this worked (contextSize). But for the current 2.2.0 it's a regression, In PathCompiler::readNextToken there is no support for it.

Could you provide a example?

@olajuwon99 Please search for existing issues before creating new ones.

@kallestenflo Dupe of #198

Thanks for the quick reply!

In the upcoming version, you'll be able to use negative array indexes, i.e. $.store.book[-1].title to get the last book's title.

Unfortunately I can't tell that to my customers. Will wait with the version bump until a more complete fix is available.


Export a variable to let users to custom the font family of code

Couple of stuff:

Even though "Monospace" is a font, you should include monospace as the last fall back.
Since the base-font has lots of choices, I think the code font should have more choices too. I think you should add `"Consolas", "Roboto Mono", "Ubuntu Mono" to the list.
"Courier New" is like "Times New Roman" for text. It should have lower priority than other fonts.
As always for such PRs, please post a before and after set.

Couple of stuff:

Even though "Monospace" is a font, you should include monospace as the last fall back.
Since the base-font has lots of choices, I think the code font should have more choices too. I think you should add `"Consolas", "Roboto Mono", "Ubuntu Mono" to the list.
"Courier New" is like "Times New Roman" for text. It should have lower priority than other fonts.
As always for such PRs, please post a before and after set.

OK, I have added some more fonts.

@jekyllbot: merge +minor


Nested generic models fail to validate when using 'Optional' at toplevel

Checks

[X] I added a descriptive title to this issue
[X] I have searched (google, github) for similar issues and couldn't find anything
[X] I have read and followed the docs and still think this is a bug

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.7.3
            pydantic compiled: True
                 install path: /home/scott/src/network_api_v2/.env/lib/python3.8/site-packages/pydantic
               python version: 3.8.5 (default, Jul 28 2020, 12:59:40)  [GCC 9.3.0]
                     platform: Linux-5.4.0-47-generic-x86_64-with-glibc2.29
     optional deps. installed: ['typing-extensions']

from ipaddress import IPv4Network
from typing import Generic, Optional, TypeVar

from pydantic.generics import GenericModel
from pydantic import BaseModel

T = TypeVar("T")

class Child(GenericModel, Generic[T]):
    field: T

class Parent(GenericModel, Generic[T]):
    child: Optional[Child[T]] = None

class Net(BaseModel):
    ipnet: IPv4Network

Using this with invalid data in Net results in:
>>> Parent[Net].parse_obj({"child": {"field": {"ipnet": "1.1.1/24"}}})
Parent[Net](child=Child[T](field={'ipnet': '1.1.1/24'}))

Redefining Parent minus Optional fixes it:
>>> class Parent(GenericModel, Generic[T]):
...     child: Child[T] = None
...
>>> Parent[Net].parse_obj({"child": {"field": {"ipnet": "1.1.1/24"}}})
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "pydantic/main.py", line 520, in pydantic.main.BaseModel.parse_obj
  File "pydantic/main.py", line 362, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for Parent[Net]
child -> field -> ipnet
  value is not a valid IPv4 network (type=value_error.ipv4network)

Hi @nu11ptr
Your issue has already been solved by PR #1989.
The fix will be available in pydantic 1.8 for sure 👍
In the meantime you can always use the merge commit and install pydantic directly from the repository
pip install git+https://github.com/samuelcolvin/pydantic.git@6b8d2babaaca420d20aab52bfe5f42cf5e382f1d
Hope it helps :)

Ahh...cool. Didn't see that one. Thanks for the quick response!


Packages installed via install.packages in R conflict with packages installed via conda.

[x] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:
Packages installed via install.packages in R conflict with packages installed via conda.
Reproduction steps
Here is an example to demonstrate this problem:

Create and activate a conda environment with the r-brio package:

 ~ $ mamba create -n rtest1 r-base r-brio
<snip>
Executing transaction: done
<snip>
 ~ $ conda activate rtest1

Use R to install the brio package

~ $ Rscript -e "install.packages('brio', repos='https://cran.rstudio.com')"
trying URL 'https://cran.rstudio.com/src/contrib/brio_1.1.2.tar.gz'
Content type 'application/x-gzip' length 12069 bytes (11 KB)
==================================================
downloaded 11 KB

* installing *source* package ‘brio’ ...
<snip>
* DONE (brio)

Try to create another conda environment with the r-brio package and watch the carnage

 ~ $ mamba create -n rtest2 r-base r-brio
<snip>
Verifying transaction: /
SafetyError: The package for r-base located at /home/izahn/.conda/pkgs/r-base-4.0.5-h8cab1ac_0
appears to be corrupted. The path 'lib/R/doc/html/packages.html'
has an incorrect size.
  reported size: 2946 bytes
  actual size: 3102 bytes

done
Executing transaction: done

Cleanup
The mess (intentionally) created above can be cleaned up be deleting the environments and cleaning out unused packages:
 ~ [1] $ conda deactivate
 ~ $ mamba env remove -n rtest1

Remove all packages in environment /home/izahn/.conda/envs/rtest1:

 ~ $ mamba env remove -n rtest2

Remove all packages in environment /home/izahn/.conda/envs/rtest2:

 ~ $ conda clean --yes --all

Proposed solution
I propose that we fix this problem by creating the site-library directory when building the r-base package. Here is a demonstration showing that this solves the problem:

Create conda environment with r-brio as before

 ~ $ mamba create -n rtest1 r-base r-brio

<snip>

Finished r-base                               (00m:03s)              24 MB     28 MB/s
Preparing transaction: done
Verifying transaction: done
Executing transaction: done

Create the site-library directory this is the crucial step

 ~ $ mkdir ~/.conda/envs/rtest1/lib/R/site-library

Activate environment and install brio with install.packages, as before

 ~ $ conda activate rtest1
 ~ $ Rscript -e "install.packages('brio', repos='https://cran.rstudio.com')"
Installing package into ‘/home/izahn/.conda/envs/rtest1/lib/R/site-library’
(as ‘lib’ is unspecified)
trying URL 'https://cran.rstudio.com/src/contrib/brio_1.1.2.tar.gz'
Content type 'application/x-gzip' length 12069 bytes (11 KB)
==================================================
downloaded 11 KB

* installing *source* package ‘brio’ ...
<snip>
* DONE (brio)

Create another conda environment including r-brio -- all good!

 ~ $ mamba create -n rtest2 r-base r-brio
<snip>
Executing transaction: done
#
# To activate this environment, use
#
#     $ conda activate rtest2
#
# To deactivate an active environment, use
#
#     $ conda deactivate

I'm happy to make a PR including the proposed change, but I wanted to propose and discuss it here first to see if there are any objections or concerns.

Details about  conda and system ( conda info ):

$ conda info

 active environment : mamba
active env location : /home/izahn/.conda/envs/mamba
        shell level : 1
   user config file : /home/izahn/.condarc

populated config files : /opt/mambaforge/.condarc
/home/izahn/.condarc
conda version : 4.10.1
conda-build version : not installed
python version : 3.9.2.final.0
virtual packages : __linux=5.12.2=0
__glibc=2.33=0
__unix=0=0
__archspec=1=x86_64
base environment : /opt/mambaforge  (read only)
conda av data dir : /opt/mambaforge/etc/conda
conda av metadata url : https://repo.anaconda.com/pkgs/main
channel URLs : https://conda.anaconda.org/conda-forge/linux-64
https://conda.anaconda.org/conda-forge/noarch
package cache : /home/izahn/.conda/pkgs
envs directories : /home/izahn/.conda/envs
/opt/mambaforge/envs
platform : linux-64
user-agent : conda/4.10.1 requests/2.25.1 CPython/3.9.2 Linux/5.12.2-arch1-1 arch/rolling glibc/2.33
UID:GID : 1000:1000
netrc file : None
offline mode : False

@izahn Thanks for the detailed example. I was able to reproduce it (copied below). My initial thoughts are:

This is only a warning. The R and r-brio installed in the environment rtest2 appear to work fine. The warning comes because the file packages.html was modified when brio was installed with install.packages(). There isn't any actual security or functionality concern, but I understand why users may be concerned when they see those messages.

I'm open to the potential of using the site-library. Other than removing this warning, I'd have to think about the potential side effects and collisions with other install directories.

Output from reproducing example

mamba create --yes -n rtest1 r-base r-brio
conda activate rtest1
Rscript -e '.libPaths()'
[1] "/home/jdblischak/miniconda3/envs/rtest1/lib/R/library"
Rscript -e 'find.package("brio")'
## [1] "/home/jdblischak/miniconda3/envs/rtest1/lib/R/library/brio"
Rscript -e 'library("brio")'
Rscript -e "install.packages('brio', repos='https://cran.rstudio.com')"
## ...
## Updating HTML index of packages in '.Library'
## Making 'packages.html' ... done
Rscript -e 'find.package("brio")'
## [1] "/home/jdblischak/miniconda3/envs/rtest1/lib/R/library/brio"
Rscript -e 'library("brio")'
conda deactivate

mamba create --yes -n rtest2 r-base r-brio
## ...
## WARNING Size incorrect, file modified in package cache "/home/jdblischak/miniconda3/pkgs/r-base-4.0.5-h8cab1ac_0/lib/R/doc/html/packages.html"
## ...
## SafetyError: The package for r-base located at /home/jdblischak/miniconda3/pkgs/r-base-4.0.5-h8cab1ac_0
## appears to be corrupted. The path 'lib/R/doc/html/packages.html'
## has an incorrect size.
##   reported size: 2946 bytes
##   actual size: 3102 bytes
## ...
conda activate rtest2
Rscript -e 'find.package("brio")'
## [1] "/home/jdblischak/miniconda3/envs/rtest2/lib/R/library/brio"
Rscript -e 'library("brio")'
conda deactivate

mamba env remove -n rtest1
mamba env remove -n rtest2
conda clean --yes --all

mamba create --yes -n rtest1 r-base r-brio
mkdir ~/.conda/envs/rtest1/lib/R/site-library
## mkdir: cannot create directory ‘/home/jdblischak/.conda/envs/rtest1/lib/R/site-library’: No such file or directory
echo $CONDA_PREFIX
## /home/jdblischak/miniconda3
mkdir $CONDA_PREFIX/envs/rtest1/lib/R/site-library

conda activate rtest1
Rscript -e "install.packages('brio', repos='https://cran.rstudio.com')"
## Installing package into ‘/home/jdblischak/miniconda3/envs/rtest1/lib/R/site-library’
## ...
conda deactivate
ls $CONDA_PREFIX/envs/rtest1/lib/R/site-library
## brio

mamba create --yes -n rtest2 r-base r-brio

conda info
##
##      active environment : base
##     active env location : /home/jdblischak/miniconda3
##             shell level : 1
##        user config file : /home/jdblischak/.condarc
##  populated config files : /home/jdblischak/.condarc
##           conda version : 4.10.1
##     conda-build version : 3.21.4
##          python version : 3.7.9.final.0
##        virtual packages : __linux=4.4.0=0
##                           __glibc=2.27=0
##                           __unix=0=0
##                           __archspec=1=x86_64
##        base environment : /home/jdblischak/miniconda3  (writable)
##       conda av data dir : /home/jdblischak/miniconda3/etc/conda
##   conda av metadata url : https://repo.anaconda.com/pkgs/main
##            channel URLs : https://conda.anaconda.org/conda-forge/linux-64
##                           https://conda.anaconda.org/conda-forge/noarch
##                           https://conda.anaconda.org/bioconda/linux-64
##                           https://conda.anaconda.org/bioconda/noarch
##                           https://repo.anaconda.com/pkgs/main/linux-64
##                           https://repo.anaconda.com/pkgs/main/noarch
##                           https://repo.anaconda.com/pkgs/r/linux-64
##                           https://repo.anaconda.com/pkgs/r/noarch
##           package cache : /home/jdblischak/miniconda3/pkgs
##                           /home/jdblischak/.conda/pkgs
##        envs directories : /home/jdblischak/miniconda3/envs
##                           /home/jdblischak/.conda/envs
##                platform : linux-64
##              user-agent : conda/4.10.1 requests/2.25.1 CPython/3.7.9 Linux/4.4.0-19041-Microsoft ubuntu/18.04.2 glibc/2.27
##                 UID:GID : 1000:1000
##              netrc file : None
##            offline mode : False

@izahn Thanks for the detailed example. I was able to reproduce it (copied below). My initial thoughts are:
1. This is only a warning.

The actual message says SafetyError, which at least sounds worse than a warning!

The R and r-brio installed in the environment rtest2 appear to work fine. The warning comes because the file packages.html was modified when brio was installed with install.packages(). There isn't any actual security or functionality concern, but I understand why users may be concerned when they see those messages.

I think the fundamental issue is that conda and install.packages from R should not be trying to install things in the same place. Things might work after R overwrites a conda package, but they might not, and on the face of it this sounds like a bad idea. It definitely should not be the default behavior.

2. I'm open to the potential of using the site-library. Other than removing this warning, I'd have to think about the potential side effects and collisions with other install directories.

site-library is the documented and official place to install installation-wide packages. That is why just creating that directory is enough to get R to install packages to it by default. I don't see any reason why conda should not take advantage of this standard R mechanism.

Maybe, but from my perspective this is clearly a bug, and there is an easy and non-hacky solution. We should fix it!

I think the fundamental issue is that conda and install.packages from R should not be trying to install things in the same place.

I thought of a potential issue. If site-library is created when r-base is installed, how will that affect conda R recipes built with conda build? Since build.sh simply calls R CMD INSTALL --build, I think it would install the package in site-library. I think we would need to modify build.sh to specify --library to point to the current install location. Otherwise conda and install.packages() will still be writing to the same directory.
$ R CMD INSTALL --help
Usage: R CMD INSTALL [options] pkgs

Install the add-on packages specified by pkgs.  The elements of pkgs can
be relative or absolute paths to directories with the package
sources, or to gzipped package 'tar' archives.  The library tree
to install to can be specified via '--library'.  By default, packages are
installed in the library tree rooted at the first directory in
.libPaths() for an R session run in the current environment.

Maybe, but from my perspective this is clearly a bug, and there is an easy and non-hacky solution. We should fix it!

I say go for it then! Worse case scenario: the issue is better known and better documented.

Definitely need to be careful not to affect the conda build process for R packages! My first thought is to create the site-library directory in recipe/post-link.sh, and only if CONDA_BUILD is not set.

Definitely need to be careful not to affect the conda build process for R packages! My first thought is to create the site-library directory in recipe/post-link.sh, and only if CONDA_BUILD is not set. I gave it a quick stab, seems harder then I expected :-(


Add documentation for testing with an API Client

I just relealised I never update the documentation for testing with an API Client.
I think I was waiting to add the missing API Clients, I have to check if they require customizations...
I was also waiting for #1840 before adding more test on
http...
Anyway even if we don't have a custom GraphQLClient for all the integration, think is time to add it to the
documentation... and even if they can always use the BaseGraphQLClient...
Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

thanks for this, I'm a bit afraid of merging it since there's a possibility of us changing the test client after I merge that PR. I'll see if I can work on it in the next few days and then then get back to this PR


Hint Generation Protocol

Changes to Ok:

The analytics protocol now keeps track of the number of attempts per question and overall. This info is included in the analytics messages (and stored locally as .ok_history)

analytics should be run after the grading protocol for full functionality

Additions:

Hint generation protocol: It queries the server for changes and displays hints along the lines of:

The computer thinks that the conditional expression on line 4 has some errors.

It also provides rubber duck debugging prompts to help guide students to solve questions themselves.
The prompts are along the lines of:

What kinds of debugging strategies have you tried? [List of strategies]:
Could you describe what the error is for the computer?:

(after hint is displayed and student corrects error)

Could you summarize for the computer what you had to change to fix the bug?
If another student had the same error you had, what advice would you give them?
How helpful was the hint that the computer provided? [1 as not helpful, 5 as very helpful]:

For code review:

I'd appreciate comments on the changes I've made to the analytics protocol.
It's likely that the hint protocol won't be used in this form for long (the plan is that it is used for one assignment), so maintenance of that protocol isn't too big of a concern)

Sample:
Sample of hint generation after 30+ attempts at a question
ok -q nodots
=====================================================================
Assignment: Homework 6
OK, version v1.5.5

Running tests

nodots > Suite 1 > Case 3

scm> (load 'hw06)

scm> (nodots '((1 . 2) 3))
((1 . 2) 3)

# Error: expected
#     ((1 2) 3)
# but got
#     ((1 . 2) 3)

---------------------------------------------------------------------
Test summary
    2 test cases passed before encountering first failed test case

Check for hints on nodots? [yes/no]: yes
-- While we wait, respond to this question. When you are done typing, press Enter.
Could you describe what the function you are working is supposed to do at a high level?

Your Response: Turn malformed lists into well formed lists

The computer thinks that:
1. The conditional expression on line 35 has an error.

^ That is an example of heavy guidance because the hint says what to do.
Lighter guidance is along the lines of "Inspect the conditional expressions"

@albert12132 or @brianhou - Any comments?
We're going to need this tomorrow so I'm going to merge & deploy before then.

@albert12132 / @brianhou  - Any other comments? I want to deploy this soon so that I can launch a 61A Homework.

LGTM.


Cleaning mocks cache on disable?

Hi,
I've been having issues on my tests using mockery when I try to register mocks. When I register the mocks with the useCleanCache flag to false my mocks are not being used because some other test is using the module I'm trying to mock, this is expected behaviour as far as I know.  The problem is, I'm using useCleanCache set to true to avoid this, and that makes my mocked test pass properly, but because some later test is trying to use the same mocked module, my tests fail because the later test gets the mock. I'm calling mockery.disable and mocker.deregisterAll after the test where I'm using the mock is finished, but apparently the mock is stored on the node module cache so whenever is required again, I get the mock. Is there a way of forcing the cache to be cleaned after mockery is disabled? I thought that was the default behaviour, but it doesn't seem to be working for me?
Thanks!

If you use useCleanCache, when mockery is disabled the original module cache should be put back in place:
https://github.com/mfncooper/mockery/blob/master/mockery.js#L164-L167
I know it's been a while since this was reported, but if you could add a repro case I could add a test for it to ensure it's doing the right thing.

tbh, the code where I found this issue is long gone and I can't tell what the problem was anymore, I guess it's safe to just close it unless anyone else can replicate it.


ActionSheetIOS.showShareActionSheetWithOptions options missing anchor in option type

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
When calling ActionSheetIOS.showShareActionSheetWithOptions on an iPad I expect to pass an anchor to position the sheet. The type ShareActionSheetIOSOptions is missing that field, however if you pass it still uses it:
https://github.com/facebook/react-native/blob/0f4f91766339f2cf4189446d7d575493d33b4009/React/CoreModules/RCTActionSheetManager.mm#L236
It works but, I believe the type should be updated (or stated why it's not used).
React Native version:
info Fetching system and libraries information...
System:
OS: macOS 10.15.6
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 3.66 GB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.18.3 - ~/.nvm/versions/node/v12.18.3/bin/node
Yarn: 1.22.5 - /usr/local/bin/yarn
npm: 6.14.6 - ~/.nvm/versions/node/v12.18.3/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
Android SDK:
NOT RELEVANT
IDEs:
Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
Xcode: 12.0/12A7209 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_265 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: ~16.11.0 => 16.11.0
react-native: ^0.62.2 => 0.62.2
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

add a button
click on it and maintain get the node id of the event
pass it:

ActionSheetIOS.showShareActionSheetWithOptions(
  {
    url: uri,
    anchor: Number(e.nativeEvent.target),
  },
  (error: Error) => {
    console.log(error);
  },
  (success: boolean, shareMethod: string) => {
    console.log(success ? 'Succeeded! ' : 'Failed! ' && shareMethod);
  }
);

the sheet is anchored to the button

Expected Results
I expect that anchor is part of the options interface and the documentation.
Snack, code example, screenshot, or link to a repository:

Closing as stale