Tik Tok issue

I cannot push my new tik tok icon (auth error). It fix a black thic border around the icon.
  tiktok: {     icon: 'm 42.413371,22.84366 a 7.2842381,7.2843028 0 0 1 -0.629963,-0.36665 8.8574793,8.8575582 0 0 1 -1.617905,-1.374596 c -1.206595,-1.3806 -1.657235,-2.781196 -1.823226,-3.761812 h 0.0067 C 38.210286,16.526642 38.267617,16 38.276287,16 h -5.495683 v 21.250939 c 0,0.285319 0,0.567305 -0.012,0.84596 0,0.03466 -0.0033,0.06666 -0.0053,0.103993 0,0.01534 0,0.03133 -0.0033,0.04733 0,0.004 0,0.008 0,0.012 a 4.6663919,4.6664333 0 0 1 -2.347862,3.703816 4.5863967,4.5864374 0 0 1 -2.273866,0.599968 c -2.560516,0 -4.635727,-2.087896 -4.635727,-4.666434 0,-2.578537 2.075211,-4.666432 4.635727,-4.666432 a 4.5930634,4.5931041 0 0 1 1.42725,0.225988 l 0.0067,-5.595718 a 10.208733,10.208824 0 0 0 -7.86625,2.301209 10.785366,10.785461 0 0 0 -2.353194,2.901858 c -0.231987,0.39998 -1.107268,2.007232 -1.213262,4.615766 -0.06666,1.480594 0.377977,3.01452 0.589965,3.648487 v 0.01334 c 0.133325,0.373313 0.649962,1.64725 1.491912,2.721195 a 11.168009,11.168108 0 0 0 2.380526,2.245888 v -0.01334 l 0.01333,0.01334 c 2.660511,1.80791 5.610337,1.689249 5.610337,1.689249 0.510637,-0.02067 2.221203,0 4.163756,-0.92062 2.154539,-1.020617 3.381134,-2.541208 3.381134,-2.541208 a 10.563379,10.563472 0 0 0 1.842558,-3.061846 c 0.497304,-1.307271 0.663294,-2.875191 0.663294,-3.501828 V 26.698798 c 0.06666,0.04 0.954611,0.627302 0.954611,0.627302 0,0 1.279258,0.81996 3.275141,1.353933 1.431917,0.379981 3.361136,0.459975 3.361136,0.459975 v -5.455726 c -0.675958,0.07333 -2.048546,-0.139993 -3.453797,-0.840625 z',     mask: 'M 0 0 L 0 64 L 64 64 L 64 0 L 0 0 z M 32.78125 16 L 38.275391 16 C 38.266721 16 38.210919 16.525885 38.349609 17.339844 L 38.341797 17.339844 C 38.507788 18.320459 38.959422 19.720964 40.166016 21.101562 A 8.8574793 8.8575582 0 0 0 41.783203 22.476562 A 7.2842381 7.2843028 0 0 0 42.414062 22.84375 C 43.819312 23.544381 45.19123 23.756924 45.867188 23.683594 L 45.867188 29.140625 C 45.867188 29.140625 43.937775 29.059668 42.505859 28.679688 C 40.509978 28.145715 39.230469 27.326172 39.230469 27.326172 C 39.230469 27.326172 38.342051 26.739219 38.275391 26.699219 L 38.275391 37.972656 C 38.275391 38.599293 38.110585 40.16734 37.613281 41.474609 A 10.563379 10.563472 0 0 1 35.769531 44.537109 C 35.769531 44.537109 34.543209 46.057509 32.388672 47.078125 C 30.446121 47.998744 28.737199 47.977377 28.226562 47.998047 C 28.226563 47.998047 25.275743 48.116502 22.615234 46.308594 L 22.601562 46.294922 L 22.601562 46.308594 A 11.168009 11.168108 0 0 1 20.220703 44.0625 C 19.378754 42.988556 18.86184 41.71511 18.728516 41.341797 L 18.728516 41.328125 C 18.516528 40.694159 18.072012 39.16028 18.138672 37.679688 C 18.244666 35.071156 19.121529 33.464433 19.353516 33.064453 A 10.785366 10.785461 0 0 1 21.705078 30.162109 A 10.208733 10.208824 0 0 1 29.572266 27.861328 L 29.566406 33.457031 A 4.5930634 4.5931041 0 0 0 28.138672 33.230469 C 25.578158 33.230469 23.501953 35.319903 23.501953 37.898438 C 23.501953 40.476973 25.578158 42.564453 28.138672 42.564453 A 4.5863967 4.5864374 0 0 0 30.412109 41.964844 A 4.6663919 4.6664333 0 0 0 32.759766 38.259766 L 32.759766 38.248047 C 32.763066 38.232047 32.763672 38.216512 32.763672 38.201172 C 32.765672 38.163839 32.769531 38.132316 32.769531 38.097656 C 32.781531 37.819002 32.78125 37.535319 32.78125 37.25 L 32.78125 16 z ',     color: '#000000'   },

for the love of God will someone merge this PR???????


IOS adaptative card not rendered

Hi,
its working fine on macos, but just appear the link in the ios app
card = {         "type": "message",         "attachments": [             {                 "contentType": "application/vnd.microsoft.card.adaptive",                 "contentUrl": None,                 "content": {                     "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",                     "type": "AdaptiveCard",                     "version": "1.2",                     "msTeams": {"width": "full"},                     "body": [                         {                             "type": "TextBlock",                             "text": f"[Grafana Report Status](grafana-link)\r - item 1\t - item 2"                         }                     ]                 }             }         ]     }

@mayku00 - Were you able to resolve your issue? Or are you still looking for any help?


command to clear log (hunt)

would be nice to have an update like clearlog@ or something like that.

Do you mean reset@?

Oh cool, worked thanks!


PdPanel collapse / pd-collapsed

When using collapse=someBoolean and also using @pd-collapsed to do something if the panel is expanded the state of the collapse gets out of sync
Example:
<pd-panel
        :collapsed="collapsed1"
        @pd-collapsed="handleCollapse($event, collapsed1)"
>

<pd-panel
        :collapsed="collapsed2"
        @pd-collapsed="handleCollapse($event, collapsed2)"
>

handleCollapse({detail: {collapsed}}, panel) {
   if (!collapsed) {
      if (collapsed1 === panel {
         collapsed2 = true
      } else collapsed1 = true
   }
}

What we try to do is close other panels if a panel is expanded but the state gets out of sync

I think the problem is that you create a 'loop' here. If you change the property collapsed a new event pd-collapsed is emitted which triggers another handleCollapse event.
If both panels change each other this wont work.

I will try to add a better example today or next Week. It should work as I am only changing the other if it wasnt collapsed but let me make a working example and a video

I made a video showing the behaviour it works correctly but the state of the other panel is wrong afterwards. If i click it twice its back to normal
https://user-images.githubusercontent.com/77280472/188110195-e18ee3ec-380b-4bcf-b3b6-67fcdfff5984.mov

Looking at the panel-header code it could be that the state of the panel is not passed to the header correctly. It looks like the header reads the panel state on load but is not updated afterwards if the state is changed by something else then the header itself

I've fixed 2 issues with the collapsed state in pd-panel. Can you check if this now works for you?

Looks good!


Update to post-challenge and new challenge

I was unfamiliar with working against Reddit's APIs, so please feel full freedom to reject or request alterations to this pull request.
What I found was:

It appears that the praw api has evolved since post-challenges.py was created and I have updated post-challenges.py according to what I believe is the expected behavior.
As a test, I have added in challenge 336, which post-challenges.py pulled from Reddit.
In a future pull request, I would like to update the documentation to provide guidance on how to use praw and the setting up of a reddit api access key, as that information was not in a convenient single location.

I would also like to update the documentation about the reference to a post_challenges script that seems to no longer exist in the repo and another script referenced inside of post-challeneges.py that is also not there (send-data.sh)

After we have discussed these updates, I will submit more pull requests that fit what you would prefer.
The naming convention appears to have shifted and challenges appear in the repo that do not follow what is requested in CONTRIBUTING.md, i.e. #336 vs 0336 and so on.  Would be happy to rename and resubmit those to follow the naming convention

Hi @freddiev4 I have submitted an update to transform that I think will help it do a better job. I have also backfilled the challenges to fill the gap between 313 and this current week. I just noticed that there appears to be no 334 easy challenge (in the reddit itself)

@colbygk just had one comment in regards to style. If you fix that I think we can go ahead and merge this 🙂 great work on refactoring transform.py!

Okay, I think that's it. I did update the README.md that you may want to double check.

Okay, fo'reals, I'm done.

I am unfamiliar with commit squashing.  Recommendation on what to do to squash?

Hm, I think I figured it out and squashed the last 5 commits into one.

@colbygk here's an official guide on Rewriting History in Git.
The short of it is that you can do:
git rebase -i @~15 which will allow you to do an interactive rebase, on the head of your branch, up until the last 15 commits.
From there you'll see something like:
pick f7f3f6d changed my name a bit
pick 310154e updated README formatting and added blame
pick a5f4a0d added cat-file

And you can change everything below the first commit to:
pick f7f3f6d changed my name a bit
fixup 310154e updated README formatting and added blame
fixup a5f4a0d added cat-file

Which will remove the commit message of every commit but the first (which is 15 commits before the most recent one)

Looks like since I used squash instead of fixup it melded instead of replacing.

After you squash, I think you'd need to run git push -f, as it looks like there are still 17 commits here 🙂

Well, now we're down to 11 commits. :)  Were you thinking that it should had more squashing?

Yeah usually we can squash these down into 2 or 3 commits.
Here I was thinking something like:
Update most recent challenges
Refactor post_challenges and transform.py
Update config, dev files, and docs

Hmm... Okay... maybe done now? Sorry for the thrashing.

Looks good to me 👍


How to connect exist graphQL endpoint?

Hi, I want connect exist graphQL endpoint, but there seems to be no relevant information in the document.
Please what do I can find it in somewhere?

Hi, @hank9653, thanks for the question. Actually, the implementation isn't written in our document,  so I just note it below.

NOTICE: your graphQL endpoint should follow https://github.com/opencrud/opencrud

You can simply new a GraphqlClient instance and put it into your <root> tag. If you're using CLI to serve or deploy, you don't have to install canner-graphql-interface manually.
canner.schema.js
import CannerScript from 'canner-script';
import {GraphqlClient} from 'canner-graphql-interface';

const graphqlClient = new GraphqlClient({
  uri: "http://localhost:4000/graphql",
  credentials: "same-origin"
});

export default () => (
  <root graphqlClient={graphqlClient}>
    {/* ... your schema */}
  </root>
)

GraphqlClient constructor arguments
{
    uri: string,
    headers?: any,
    fetch?: any,
    includeExtensions?: boolean,
    credentials?: string,
    fetchOptions?: any,
    useGETForQueries?: boolean
}

Any further questions please let us know, thanks!

It's work, I can get data from the graphQL endpoint, thank you for help.

hi @abz53378  I have the same problem, but this solution did not work for me, I have problems with the CORS, I have enabled them and I continue to generate the same problem ... if you have any example where you can look at all the configuration and development of a project in react , I would like very much ...

HI @CharliToro, sorry about the late reply, to solve the CORS problem, you have to configure your server instead of changing anything about CannerCMS, here is a great explanation of CORS, an article about CORS in express, and in our project, we use @koa/cors. Hope these help!


Nullable and Referenced Property

Using Swashbuckle.AspNetCore 5.0.0-beta
I'm trying to set Nullable = true for a referenced property and I'm getting no "nullable":true output. Is that normal? Is it forbidden in OpenApi 3.0?
-> Schema.Properties.abc.Value.Nullable = true;
"abc": {
"$ref": "#/components/schemas/abcViewModel"
}

I think it is forbidden. It is just weird.
I solved my problem with oneOf


No data displayed for gear count, Gears, shift battery,

Version 2.0, I do have drivetrain and it works well and really like that display. Hood buttons are working well and I checked that buttons only was not selected.
Side note, are you in Ukraine? I spent quite a bit of time there about 10 years ago, various cities. Loved it.

Hi, if you open the details of the shifter in Ki2 do you see battery % and gearing information there? Should be similar to this image:

Keep in mind that in Karoo Ride Profiles, you need to replace all data elements with the ones from Ki2, for example if you have Shf Bat % from Karoo it won't show any data from Ki2, you need to use the element from Ki2 in the profile - even if the name is the same.
Post a picture of the details in Ki2 and the ride with the data problems.

As you described, I have replaced all the data elements from Ki2. The shift battery % shows up when I open up the connected Ki2 menu but does not display in the data fields. I currently don't have Shift battery %, shift count, Gears or similar. I do have drive train and hood switch functions which is fantastic. Any ideas?

No ideas. Those fields use the same information that the Drivetrain uses, so that's really weird. Can you post a screenshot/picture of the ride elements and the Ki2 gearing information?
What is displayed in the ride elements in 'Shift battery %', 'shift count', 'Gears'?

I downloaded your 3.0 update and it looks like everything is perfect! All the missing data fields suddenly populated.  I didnt change anything other than doing your latest update. No idea why.

Ok, thanks for updating :)


⚠ Mobitopup has degraded performance

In 37ef1a1, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 5190 ms

Resolved: Mobitopup performance has improved in edb812d.


After upgrade to 0.3 - client and server don't have same version (client : 1.19, server: 1.18)

After upgrading both docker and docker-machine to the latest versions (1.7.0 and 0.3.0) I get the following error:
client and server don't have same version (client : 1.19, server: 1.18)
h59ec2765:nxt-docker-node ronagy$ docker-machine create -d virtualbox test
Creating VirtualBox VM...
Creating SSH key...
Starting VirtualBox VM...
Starting VM...
To see how to connect Docker to this machine, run: docker-machine env test
h59ec2765:nxt-docker-node ronagy$ eval $(docker-machine env test)
h59ec2765:nxt-docker-node ronagy$ docker version
Client version: 1.7.0
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 0baf609
OS/Arch (client): darwin/amd64
Error response from daemon: client and server don't have same version (client : 1.19, server: 1.18)
h59ec2765:nxt-docker-node ronagy$ docker-machine -version
docker-machine version 0.3.0 (HEAD)

@ronag - you likely have a boot2docker ISO cached in ~/.docker/machine/cache/.
To upgrade this you should run docker-machine upgrade test, or delete the cached ISO before createing the machine.

@hairyhenderson is right on the money.  Please re-open if upgrade doesn't work out for you.  Thanks!


Component: use old models on http errors

Coverage remained the same at 30.572% when pulling e9c46b78f464f6f36841c42156cfc8d30847b56b on calixteman:component_old_models_on_404 into 0209c46edf5123ac9c5e63550cf37f26d55c8a73 on mozilla:master.


Supported cars list is wrong, 2020 Toyota Corolla is not fully supported

I found out the 2020 Toyota Corolla LE is not fully support even though it says under supported cars: "All". Found this out after getting the vehicle. Please fix.

This is most likely a fingerprint issue, i.e. your vehicle might generate CAN messages that we have not seen before on that vehicle model. This is always a possibility on every vehicle model.
You can join dicord.comma.ai for a more in-depth discussion.

There has been discussion on this, there doesn't seem to be support for the 2020 Corolla LE out of the box and trying to run get_fingerprint.py does not yield anything useful.

@meritus do you still have issues?


fixed containsPoint failing

Fixed failed result of containsPoint when GraphicsData#matrix is setted.

Description of change

GraphicsData support setting specific matrix for points transformation, but containsPoint wasn't consider it.
Before:
https://www.pixiplayground.com/#/edit/iMS~MESj6tf1KHMhiRO~Q
After:
https://www.pixiplayground.com/#/edit/DGKjCWH7ayLAU7FW6NnJl
Pre-Merge Checklist

[x] Tests and/or benchmarks are included
[ ] Documentation is changed or added
[x] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

Codecov Report

Merging #5987 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5987      +/-   ##
==========================================
+ Coverage   70.51%   70.54%   +0.03%
==========================================
  Files         208      208
  Lines       10523    10527       +4
==========================================
+ Hits         7420     7426       +6
+ Misses       3103     3101       -2

Impacted Files
Coverage Δ

packages/graphics/src/GraphicsGeometry.js
73.38% <100%> (+0.25%)
:arrow_up:

packages/graphics/src/Graphics.js
69% <0%> (+0.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e6ea3...7e8594d. Read the comment docs.


http:server: Support HEAD method

Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

merged, with the suggestion


Enhance the cache ability

issue: #113
local test code
import time

import guidance

# set the default language model used to execute guidance programs
guidance.llms.caches.cache_creator = guidance.llms.caches.DiskCache.default_cache_creator
guidance.llm = guidance.llms.OpenAI("text-davinci-003")

# define a guidance program that adapts a proverb
program = guidance("""Tweak this proverb to apply to model instructions instead.

{{proverb}}
- {{book}} {{chapter}}:{{verse}}

UPDATED
Where there is no guidance{{gen 'rewrite' stop="\\n-"}}
- GPT {{gen 'chapter'}}:{{gen 'verse'}}""")

# execute the program on a specific proverb
start_time = time.time()
executed_program = program(
    proverb="Where there is no guidance, a people falls,\nbut in an abundance of counselors there is safety.",
    book="Proverbs",
    chapter=11,
    verse=14
)
print(executed_program)
print("consume time: ", time.time() - start_time)

start_time = time.time()
executed_program = program(
    proverb="Where there is no guidance, a people falls,\nbut in an abundance of counselors there is safety.",
    book="Proverbs",
    chapter=11,
    verse=14
)
print(executed_program)
print("consume time: ", time.time() - start_time)

there is the screenshot of the second running result

There are many changes in this pr, please help to review. @slundberg thanks

Thanks! Will review today.

@slundberg Hi, thanks your patient review.
Here's a possible rephrased version of your text:

I've been struggling with how to initialize the cache for a while. Initially, I considered passing the cache as a parameter when initializing the "llm" object. However, since the cache is at the object level, when two identical "OpenAI llm" objects are created, they use the same cache, making the object-level cache redundant. Therefore, I decided to keep the cache at the class level and initialize it using a static assignment method. Like:

guidance.llms.caches.cache_creator = guidance.llms.caches.DiskCache.default_cache_creator

Since this cache is designed specifically for handling "llm" requests, it's meaningless outside of the "llms" context. Thus, I placed the caches content in the "llms" directory.

@slundberg I have resolved the conflict, help me checkout it.

@slundberg Hi, do you have more suggestions? Maybe you can merge the pr, because the current pr should not have serious logic errors. 🤝

Sorry was out for a day, and am catching up. Will get back to this as soon as I can (tomorrow I think).

@slundberg has handled the conflict, and thanks your reply 😆


Support for other sources ?

This program is very useful and works great. Would it be possible to add support for other data sources like Shapefile or PostGIS ?

Thanks. Shapefile would be useful and will be practical once I factor out GeoJSON parsing from the rest of the code. PostGIS seems like it would be more difficult to support.

Ok thanks for your reply. It is not a big deal as it is easy to use ogr2ogr to convert any source into GeoJSON but it is an extra step which can take time for big files, it would be great to be able to link this tool directly to a PostGIS database.
By the way, I got some kind of error message when I try to import some big files, the program stops after the first level and display this:
*** NOTE TILES ONLY COMPLETE THROUGH ZOOM 0 ***
And my mbtiles contains only the first level, any idea ?

@flp-gpc do you have any ideas of linking this tool directly to a PostGIS database.

Any further thoughts about directly supporting shapefile?

I've implemented https://github.com/mapbox/tippecanoe/issues/777 in my fork at https://github.com/protomaps/tippecanoe
Once streaming in https://github.com/protomaps/tippecanoe/issues/9 is supported, GDAL should be able to act as glue for any vector format when using /vsistdout/ to pipe in to tippecanoe, so I suggest that as a solution to Shapefiles, barring conversion quirks like -nlt PROMOTE_TO_MULTI.


Fix incompatibility with tournament (and possibly other mods)

Tournament fix: https://github.com/alex-s168/VS_tournament_continued/pull/12
The mixins to computer craft turtles and computers should not use CallbackInfoReturnable#setReturnValue because it also automatically cancels the processing of other mixins. Also doing this is useless anyways because the return value is already set.

It has now been fixed. I hadnt realized you made a PR. Thanks for informing me of the imcompatibility!


lambda-deploy fails due to incorrectly named .env file

the lambda-deploy file fails because it is looking for a file called .env - not .env.lambda , I figured it out and renamed the file, and I'm sure there is a good reason for having the two .env files so you can switch between them, but your install guide should recommend renaming one of the files to .env in order for it to work (in windows you have to do this in the command prompt - not explorer.

This is correct. If you check instructions you will see that you have to make .env file from .env.lambda. This issue can be closed.

Thanks. I didn't see the line of text in the readme.

The environment variables are stored in an .env file which you need to create yourself from a copy of .env.lambda
I think it would be helpful to many first time users if it was emphasized more in the readme and maybe more detail added to explain what they need to do. Also, an error message built into the deploy code to say "you don't have a .env file, are you sure you want to proceed without it or would you like to use the file .env.lamdba that I found? Not a huge amount of work to add...

It states that you need to copy .env.lambda to .env and then edit it.  What else should it say?


[Catalog] Sample K8s Apps

Current Behavior
Meshery Catalog has a relatively small number of public designs.
Desired Behavior
The catalog should be replete with a variety of published designs.
Implementation

Import common sample apps from https://github.com/kubernetes/examples
Publish those imported apps to Meshery Catalog.

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hey can i get some more details...I wanna work on this...

@leecalcote, can you assign this issue to me, please..??

@prashant235913 I missed your note earlier. We need to get some more information published about how design can be created and published... @anshuhtwt is familiar with this process.
There are a few slides to publish on this. @meshery/meshery-docs-contributors and @meshery/maintainers  let's ensure that we get a doc update going for the Catalog and how this publishing process works.

@leecalcote, thank you

@Loknath-Das the process is automated so you dont have to create any PR.  Once your designs are approved, they will be automatically published on meshery.io
These are currently available published designs:
https://meshery.layer5.io/api/catalog/content/pattern

This issue has been open for some time with no recent activity, unassigning to open it up for new contributors to give it a go.


Torsion result and calculator

Response to #63
Provides a Calculator for extracting Torsions in molecules and constructedmolecules.
Provides an example for extracting, iterating through and calculating the values of these torsions - specifically showing the distinction between building block and constructed molecule torsions in a constructed molecule.

Wow this looks like a pretty solid foundation for working with torsions.
I can try using the example as a launch point for playing with some of the nuances I was mentioning in #63

Excellent. I will merge it and please send PRs with enhancements for your problems!


Remote files completion

It's making me nervous that the test is writing and deleting from my documents folder, but other than that 👍


dots in filename cause 403 for cms uploaded assets

Affected Version
4.2.0
Description
Files uploaded as CMS assets get a Title and Filename. If the filename contains extra dots before the extension, the file cannot be viewed - it returns a 403 error.
Steps to Reproduce

Log into CMS, got to the Files section and upload a file.
Set the filename to include extra dots, for example "my-nice.file.txt"
Try to view the file, it fails.

Related: https://github.com/silverstripe/silverstripe-assets/commit/d42bd6ec3e1d15d48074de04bcabfd90ce0cbdc9

Just tried this on 4 branch, works now


Fix build suggestions

Contributes to #34611

Internal previews

📄 File
🔗 Preview link

docs/orleans/deployment/consul-deployment.md
Use Consul as a membership provider

docs/spark/how-to-guides/windows-instructions.md
Learn how to build your .NET for Apache Spark application on Windows

I reached out to @scottaddie, asking if he could help figure out why fully qualified URLs are being generated for these Azure SDK articles/includes. While this PR will undo those places, I think their tool might add them again. Just an FYI.

Thanks @IEvangelist


Download Piece

Hello, how do I download a separate piece ?
Torrent torrent = Torrent.Load("file.torrent");
byte[] array = DownloadPiece(torrent.Files[0].StartPieceIndex));

byte[] DownloadPiece(int index)
{
   //
}

You'd have to write a custom PiecePicker for this kind of logic.
In short, you'd have to create a PiecePicker which returns false ( https://github.com/mono/monotorrent/blob/master/src/MonoTorrent/MonoTorrent.Client/PiecePicking/PiecePicker.cs#L92-L96 ) if a peer does not have the piece you want.
Then you should override the PickPiece https://github.com/mono/monotorrent/blob/master/src/MonoTorrent/MonoTorrent.Client/PiecePicking/PiecePicker.cs#L106-L110 method to do something like:
        public virtual MessageBundle PickPiece(PeerId id, BitField peerBitfield, List<PeerId> otherPeers, int count, int startIndex, int endIndex)
        {
            CheckOverriden();
            var bitfield = peerBitfield.Clone ().SetAll (false);
            bitfield.SetTrue (pieceIndex);
            return picker.PickPiece(id, bitfield, otherPeers, count, startIndex, endIndex);
        }


Intercept Requests Event is Broken

Steps to reproduce
This works in 1.6.2 at least, does not work in any other version I have tried after *1.12, 1.13 etc....
Tell us about your environment:

Puppeteer version: 1.12 or anything above 1.6.2 it seems
Platform / OS version: WINDOWS 10
URLs (if applicable): www.google.com
Node.js version: latest

What steps will reproduce the problem?
Enable Intercept Request
Load page
all resources are now pending.
Please include code that reproduces the issue.
 const browser = await launch({
    headless: false,
    args: [
      // `--proxy-server=${ROUTER_PROXY}`,
      "--no-sandbox",
      "--disable-setuid-sandbox",
      "--disable-dev-shm-usage",
      "--disable-accelerated-2d-canvas",
      "--disable-gpu",
      "--window-size=1920x1080",
      "--enable-feature=NetworkService"
    ]
  });

private interceptRequest = async (request: puppeteer.Request) => {
    console.warn("INTERCEPTED");
    await request.continue();
    return;
}

 const page = await browser.newPage();
      page.on("request", this.interceptRequest);

      this.page = page;
      await page.setViewport({ width: 1920, height: 1080 });
      await page.setUserAgent(this.agent);
      await page.setRequestInterception(true);
      page.on("response", this.interceptResponse);
      this.logger("Request Interception On");

      await page.goto("http://www.google.com");

What is the expected result?
For the page to load  correctly

What happens instead?
Currently it loads  the page without any other asset (images, fonts )

@Morphexe the following works just fine for me on v1.13.0:
const puppeteer = require('puppeteer');

async function main() {
    const browser = await puppeteer.launch({headless: false})
    const page = await browser.newPage()
    await page.setRequestInterception(true);
    page.on('request', request => {
      console.log('INTERCEPTED: ' + request.url());
      request.continue();
    });
    await page.goto('https://google.com');
}
main()

@Morphexe the following works just fine for me on v1.13.0:
const puppeteer = require('puppeteer');

async function main() {
    const browser = await puppeteer.launch({headless: false})
    const page = await browser.newPage()
    await page.setRequestInterception(true);
    page.on('request', request => {
      console.log('INTERCEPTED: ' + request.url());
      request.continue();
    });
    await page.goto('https://google.com');
}
main()

This is a odd one, if I replace my class method with a lambda function it works perfectly, if I don't it fails, is there something that I might be missing on my side that might be causing this?

is there something that I might be missing on my side that might be causing this?

@Morphexe looks like a bug somewhere in your code. You didn't post all your code, so it's hard to say for sure. If you post the whole thing, then we might be able to help.

@aslushnikov  So I found out its a scoping issue, the "this" is being rebinded by puppeter or something else on its inner workings.
Thats why it wasn't working, although I am not sure why the requests were being hanged even with that.
But I figured it out by using lambdas, so should be fine for now.

Awesome, I'm glad we figured it out 👌


Clicking add block to matrix does not work set to maximum of 1 in inline editable format when Smith is installed

Bug Description
Description
In element view on a structured entries page editing multiple entries at once unable to change or edit Link Field type entries that are as URL in selection dropdown.
Operating system and version
Mac Sonoma 14.6.1 / DDEV version v1.23.2
Database type and version
MySQL 8.0.36
Image driver and version
Imagick 3.7.0
Installed plugins and versions

Amazon S3: 2.2.1
Batch Actions: 2.0.1
Blitz: 5.7.1
BlurHash: 3.0.0
CKEditor: 4.2.0
Control Panel CSS: 3.0.0
Embedded Assets: 5.1.2
Environment Label: 5.0.0
Feed Me: 6.3.0
Freeform: 5.5.8
Matrix Extended: v3.5.0
Minify: 5.0.0
Reverse Relations: 3.0.0
SEOmatic: 5.1.2
Smith: 3.1.0
Sprig: 3.5.0

Steps to reproduce

Create matrix field with at least one entry type
Not Required
Minimum entries: empty
Maximum entries: 1
View Mode: inline editable block

Add field to entry
Add a block to matrix field

Expected behavior
Clicking add block will show editable entry type of choice.
Actual behavior
Nothing appears when clicking on buttons. Clicking the button does work if the matrix field is set to Cards or Element Index or Batch Actions is disabled.
Batch Actions version
2.0.1
Craft CMS version
<IP_ADDRESS>

Do any errors appear in the browser console?

Try disabling your other plugins and confirming that Batch Actions is working at that point, then re-enabling them one-by-one to see when it stops working. I'm guessing one of them (possibly Matrix Extended?) is conflicting with Batch Actions.

Turns out it's a conflict with the Smith Plugin from Verbb. If Matrix Extended is enabled but Smith is disabled batch actions still works and I get the benefits of Batch actions and Matrix Extended with copy, paste, clone.

Thanks for that extra info, I'm now able to reproduce it. It's happening because of the kind of hacky way we need to hook into Smith's functionality - it involves adding an empty <div> to the start of the Matrix blocks' container element as a dummy block, and then creating a Smith menu on that block. Since Craft checks if new blocks can be added based on the number of child elements the container element has, our dummy block has already maxed out the count. Unfortunately I don't think we can work around that, but I'll keep this open in case I can figure out a solution in the future.

Hopefully something works out. Thank you for the explanation.


[stable/prometheus-operator] Allow to pass --namespaces to Prometheus Operator

What this PR does / why we need it:
This PR allows to pass the --namespaces parameter to the Prometheus Operator. It also creates the proper Roles and RoleBindings accordingly.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

Actually please wait before merging this, I found an issue with the rolebinding


Plot.auto - TypeError: Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'

I'm trying to use Plot.auto() in a Server Side Rendering (SSR) environment, so using JSDOM to provide a DOM document.  When plot() is called, I get a TypeError.
I can't find much information on this, but I believe it might be to do with different instances of window being used.  If I specify the mark type, e.g. Plot.rectY it works fine, so think that this might be down to the mark type that auto is choosing based on the data, so no doubt I'll find other instances of marks that fail in this way.
const { document } = new JSDOM('<!DOCTYPE html>').window;
const plot = Plot.auto(penguins, {x: "island"}).plot({document})

Right… currently we need to patch Event like so:
global.Event = jsdom.window.Event;
But in that case you might want to patch document too:
import { JSDOM } from "jsdom";
import * as Plot from "@observablehq/plot";
import * as d3 from "d3";
const penguins = await d3.csv(
  "https://raw.githubusercontent.com/mwaskom/seaborn-data/master/penguins.csv",
  d3.autoType
);
const jsdom = new JSDOM("<!DOCTYPE html>");
global.document = jsdom.window.document;
global.Event = jsdom.window.Event;
const plot = Plot.auto(penguins, { x: "island" }).plot();
plot.setAttribute("xmlns", "http://www.w3.org/2000/svg");
console.log(plot.outerHTML);

(note; I'm using "type":"module" in my package.json)
I don't think we plan to actually use the event in JSDOM, so maybe the happy fix here is to wrap the dispatchEvent call in a try…catch.


SQL Lab query indefinitely in PENDING

Make sure these boxes are checked before submitting your issue - thank you!
-[✅] I have checked the superset logs for python stacktraces and included it here as text if any
-[✅] I have reproduced the issue with at least the latest released version of superset
-[✅] I have checked the issue tracker for the same issue and I haven't found one similar
Superset version
Superset 0.22.1 on Mac OSX
Don't have a celery worker setup.
Problem:
The picture below shows my database settings:

The below image shows  the query, and what I get when I run it:

Any query given directly on the sqllab editor seems to be in a PENDING state no matter what I try. However, the results do come in Slice and the Dashboard.
Am I missing any necessary parameter?

Try with latest release please.

This is my log:
2018-04-02 12:46:40,548:INFO:root:Parsing with sqlparse statement SELECT count(*) from PrestoViz.mlp_visualization.kaggle_data_orc;
2018-04-02 12:46:40,578:INFO:root:Triggering query_id: 29
2018-04-02 12:46:40,579:INFO:root:Running query on a Celery worker
[2018-04-02 12:47:25 +0530] [67569] [CRITICAL] WORKER TIMEOUT (pid:71847)
[2018-04-02 12:47:25 +0530] [71847] [INFO] Worker exiting (pid: 71847)
[2018-04-02 12:47:26 +0530] [71870] [INFO] Booting worker with pid: 71870
2018-04-02 12:47:28,921:DEBUG:root:[stats_logger] (incr) queries
/Users/s0j00os/anaconda3/lib/python3.6/site-packages/sqlalchemy/sql/sqltypes.py:596: SAWarning: Dialect sqlite+pysqlite does not support Decimal objects natively, and SQLAlchemy must convert from floating point - rounding errors and other issues may occur. Please consider storing Decimal numbers as strings or integers on this platform for lossless storage.
'storage.' % (dialect.name, dialect.driver))
2018-04-02 12:47:28,975:DEBUG:root:[stats_logger] (incr) search_queries
2018-04-02 12:47:28,988:DEBUG:root:[stats_logger] (incr) queries
2018-04-02 12:47:28,998:DEBUG:root:[stats_logger] (incr) queries
2018-04-02 12:47:29,200:DEBUG:root:[stats_logger] (incr) queries
2018-04-02 12:47:29,209:DEBUG:root:[stats_logger] (incr) queries
2018-04-02 12:47:29,222:DEBUG:root:[stats_logger] (incr) queries
2018-04-02 12:47:29,235:DEBUG:root:[stats_logger] (incr) queries
2018-04-02 12:47:29,247:DEBUG:root:[stats_logger] (incr) queries
2018-04-02 12:47:29,258:DEBUG:root:[stats_logger] (incr) queries

And I have updated to
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Superset 0.24.0
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Still doesn't work


Final Touches pull request

Leaderboard : final touches
In this project I :

add footer in template.html file to look good the application
modify the style of leaderboard header
create new folder to store image

Project Status: INVALIDATED :red_circle:
Hi @YoutLone ,
While you made a great effort in this project, I can't go ahead and review your code.

Invalid Code Review Request

This is because you have submitted a project, that is not following the right flow which in this case is Gitflow so kindly fix this :+1:
Your current flow

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @NahnahAJ in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Gremlin Query does not run in a Function

OrientDB Version, operating system, or hardware.

v2.2.13

Operating System

[ ] Linux
[X ] MacOSX
[ ] Windows
[ ] Other Unix
[ ] Other, name?

Expected behavior and actual behavior
I have a Gremlin pipeline as such

g.v('41:0').outE('AE_Cat_SubCat').inV().transform{[id:it.id, text:it.text]}.gather

This produces the following output in Gremlin console
[{id=#46:0, text=Physics}, {id=#45:0, text=General Science}, {id=#47:0, text=Sports}]
However, I created a function in the OrientDB web console and used the following code

def mydb = orient.getGraph();
def queryOutput, results;
try{
  def query = "g.v(\'${CategoryId}\').outE(\'AE_Cat_SubCat\').inV().transform{[\'id\':it.id, \'text\':it.text]}.gather";
  println query
  queryOutput = mydb.command('gremlin', query);
  println queryOutput

}catch(err){
  return err;
}
return queryOutput;

And I get the following result
[
{
"@type": "d",
"@version": 0,
"value": [
null,
null,
null
]
}
]
Output in the console is
g.v('41:0').outE('AE_Cat_SubCat').inV().transform{['id':it.id, 'text':it.text]}.gather
[null, null, null]
Please note the the Gremlin query and transform is identical. I have tried with and without the quotes in the transform also.
However, if we remove the transform step, now I get the expected result but a bit too verbose for practical use.

def mydb = orient.getGraph();
def queryOutput, results;
try{
  def query = "g.v(\'${CategoryId}\').outE(\'AE_Cat_SubCat\').inV().gather";
  println query
  queryOutput = mydb.command('gremlin', query);
  println queryOutput

}catch(err){
  return err;
}
return queryOutput;

Gives me back
[
{
"@type": "d",
"@rid": "#46:0",
"@version": 2,
"@class": "A_SubCategory",
"text": "Physics",
"in_AE_Cat_SubCat": [
"#53:0"
],
"@fieldTypes": "in_AE_Cat_SubCat=g"
},
{
"@type": "d",
"@rid": "#45:0",
"@version": 2,
"@class": "A_SubCategory",
"text": "General Science",
"in_AE_Cat_SubCat": [
"#54:0"
],
"@fieldTypes": "in_AE_Cat_SubCat=g"
},
{
"@type": "d",
"@rid": "#47:0",
"@version": 5,
"@class": "A_SubCategory",
"out_AE_SubCat_Question": [
"#73:0",
"#74:0",
"#75:0"
],
"text": "Sports",
"in_AE_Cat_SubCat": [
"#55:0"
],
"@fieldTypes": "out_AE_SubCat_Question=g,in_AE_Cat_SubCat=g"
}
]
Steps to reproduce the problem
I suspect the transform stage of the pipeline does not work in Functions.  You can try to apply any type of transform and it will likely fail.
Is there a better way to accomplish what I need?  I am merely trying to clean up the output such that we get only the data that the front end would need and be interested in.
Thanks

hi @ashkumar
let me check

hi @ashkumar
Fixed. It will be available in the next release 2.2.17
Thanks


Enhanced ecommerce

Is there a way I can get the variables into the facebook pixel so that I can use dynamic retargeting and other features of facebook ads?

I have a client who is running an online store in opencart. They are using the default facebook extension with 1 pixel. I need to install a second pixel so I am using Google Tag Manager. I am unable to get the variables to be passed to the facebook pixel.

Enhanced Ecommerce added in ef005f12f5429183534e74e117365e02dac51cd0


Memory Leak in MVKInstance::initConfig

I have noticed if I repeatedly call vkCreateInstance in a loop, memory usage of my process will grow unbounded. I have traced this to the autoreleased CFStrings that are allocated by mvkGetEnvVar, through the call to [[NSProcessInfo processInfo] environment]. Surrounding MVKInstance::initConfig in an autorelease pool would be one way to resolve the leak.

@csmulhern
What version of MoltenVK are you using?
This was fixed a couple of months ago, and was included in the MoltenVK 1.0.36 release, and the Vulkan SDK 1.114 release.

Doh, I was using version <IP_ADDRESS> of the Vulkan SDK. You are correct that this leak was resolved by updating.
On the latest version, I'm seeing two other leaks in the same code (that repeatedly creates and destroys an instance / device / command pool in a loop). One is a leak of MTLCommandQueueDescriptor from MVKQueue::initMTLCommandQueue, the other is a leak of CFString from [_MTLDevice name], called from mvkPopulateGPUInfo, called from
MVKPhysicalDevice::initProperties.
Here are stack traces:
0 libsystem_malloc.dylib malloc_zone_calloc
1 libsystem_malloc.dylib calloc
2 libobjc.A.dylib class_createInstance
3 libobjc.A.dylib +[NSObject allocWithZone:]
4 Metal +[MTLCommandQueueDescriptor allocWithZone:]
5 Metal -[_MTLCommandQueue initWithDevice:maxCommandBufferCount:]
6 AppleIntelKBLGraphicsMTLDriver -[MTLIGAccelCommandQueue initWithDevice:maxCommandBufferCount:]
7 libMoltenVK.dylib MVKQueue::initMTLCommandQueue()
8 libMoltenVK.dylib MVKQueue::MVKQueue(MVKDevice*, MVKQueueFamily*, unsigned int, float)
9 libMoltenVK.dylib MVKDevice::initQueues(VkDeviceCreateInfo const*)
10 libMoltenVK.dylib MVKDevice::MVKDevice(MVKPhysicalDevice*, VkDeviceCreateInfo const*)
11 libMoltenVK.dylib vkCreateDevice
12 libvulkan.dylib terminator_CreateDevice
13  0x10f338f4f
14 libvulkan.dylib loader_create_device_chain
15 libvulkan.dylib loader_layer_create_device
16 libvulkan.dylib vkCreateDevice

0 libsystem_malloc.dylib malloc_zone_malloc
1 CoreFoundation __CFStrAllocateMutableContents
2 CoreFoundation __CFStringChangeSizeMultiple
3 CoreFoundation CFStringAppend
4 CoreFoundation -[NSArray componentsJoinedByString:]
5 Metal -[_MTLDevice name]
6 libMoltenVK.dylib mvkPopulateGPUInfo(VkPhysicalDeviceProperties&, id<MTLDevice>)
7 libMoltenVK.dylib MVKPhysicalDevice::initProperties()
8 libMoltenVK.dylib MVKPhysicalDevice::MVKPhysicalDevice(MVKInstance*, id<MTLDevice>)
9 libMoltenVK.dylib MVKInstance::MVKInstance(VkInstanceCreateInfo const*)
10 libMoltenVK.dylib vkCreateInstance
11 libvulkan.dylib terminator_CreateInstance
12  0x10f3369f8
13 libvulkan.dylib loader_create_instance_chain
14 libvulkan.dylib vkCreateInstance

@csmulhern PR #751 includes a fix for this. Please retest and close this issue if the problem is fixed now.

That fixes it, thanks!


Android targeting support

We need to add full android support for the framework.
This should not be too difficult as everything has been designed with cross-platform support in mind. Will require hooking up Xamarin, adding the android version of bass (any probably other) native libraries.
I welcome anyone who has an interest in cross-platform targeting support, especially if you have experience with xamarin.

In it's current state Android support won't be possible, System.Drawing is not available on Xamarin Android. The main Framework assembly will need to be reworked to remove that dependency. Once that's done it should then be simple to complete the rest as you say.

system.drawing is hardly used anywhere in our code base (we have purposefully avoided using it for such reasons). you should have no trouble removing the dependency if you are intending on taking on this task.

I intend too, it'll be great fun I think. I'll start by removing that dependency then look at targeting support.

2>  No way to resolve conflict between "mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089" and "mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e". Choosing "mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089" arbitrarily.
I've managed to get the build down to this warning, which from my understanding is because of the framework targeting .net 4.5, but I have managed to get it to build..... sadly it's gonna take me awhile to actually make a sample to begin testing anything cause to be honest I've never used OpenGL on Android.... all my apps have been built with Android views. So this is all new to me! Any suggestions on something I may have missed that would cause this issue though?

You can try recompile Xamarin.Android with proper target version.

@Tauntawn Can you publish result of your work?

@peppy should comppatibility changes for android be mergable to master or as new branch?

@peppy i need to use some code from Android namespace. So i need to make multitarget project. And i found two ways for it, and i wanted to ask what fits better to you.

Change SDK to https://github.com/onovotny/MSBuildSdkExtras to allow multitargetting for xamarin and netstandard simultaneously.
Create shared project and next 2 for every target

xamarin should support netstandard, no?

Yeah, but i need to use android.content.context.GetExternalFilesDir() to access path to external storage

Have you checked the iOS PR for reference? https://github.com/ppy/osu-framework/pull/1409/files

You can check out the solution structure I'm using for iOS if you look at my latest branch.  It's not the same branch as the one in that PR, which is dependent on an old version of OpenTK and will no longer run with the latest framework.  The new branch is currently using a (temporarily) renamed fork of OpenTK to prevent namespace clashes.  I'm still looking for a way around that.
https://github.com/swoolcock/osu-framework/tree/osutk-ios

Thanks, I'll take a look

can i use just dll not nuget package for now for OpenTK?

Or maybe better question
I should use ppy's version of OpenTK, yeah?
Or can i use this included in xamarin?
Cause i cannot find a way to use ppy's version directly. Maybe using DLL and extern alias, if it will work.

for now i get this error while running samplegame:
Unhandled Exception:

System.TypeLoadException: Could not set up parent class, due to: Could not set up parent class, due to: Could not set up parent class, due to: Generic Type Definition failed to init, due to: Could not set up parent class, due to: Invalid type osu.Framework.Graphics.Colour.SRGBColour for instance field osu.Framework.Graphics.Containers.CompositeDrawable:borderColour assembly:/storage/emulated/0/Android/data/SampleGame.Android1.SampleGame.Android1/files/.__override__/osu.Framework.dll type:CompositeDrawable member:(null) signature:<none> assembly:/storage/emulated/0/Android/data/SampleGame.Android1.SampleGame.Android1/files/.__override__/osu.Framework.dll type:Container`1 member:(null) signature:<none> assembly:/storage/emulated/0/Android/data/SampleGame.Android1.SampleGame.Android1/files/.__override__/osu.Framework.dll type:Container`1 member:(null) signature:<none> assembly:/storage/emulated/0/Android/data/SampleGame.Android1.SampleGame.Android1/files/.__override__/osu.Framework.dll type:Container member:(null) signature:<none> assembly:/storage/emulated/0/Android/data/SampleGame.Android1.SampleGame.Android1/files/.__override__/osu.Framework.dll type:Game member:(null) signature:<none>: wystąpił wyjątek

are these problems with opentk or is this bigger problem?
and my branch is https://github.com/ticotaco72/osu-framework/tree/target-android

Rename the opengl dll.

You might want to ping @FreezyLemon about Android support, as he’s spent some time researching it.

Hm.. it's been a while since I tried it, but you'd probably be best off trying to get OpenTK to work first...
There've been a lot of issues with it (mostly due to Xamarin.Android being uncooperative with their namespace usage), and I couldn't find a workaround yet.
Some more info on this:
opentk/opentk#494 (almost the exact issue I had)
opentk/opentk#810 (this issue has some links in it that give detailed descriptions, also the post itself is useful)

Thanks. I'll look for some solution for this problem, but for now I'll use osutk fork for development time as @swoolcock in osutk branch

@FreezyLemon Can OpenTK's GameWindow be initialised in standard way on Android? cause in my implementation it can't initialise DisplayDevice and throws an error. I'm debugging on vs' emulator

System.TypeInitializationException: The type initializer for 'osuTK.DisplayDevice' threw an exception.

09-28 21:50:54.504 D/Mono    ( 6220): DllImport attempting to load: '/system/lib/liblog.so'.
09-28 21:50:54.505 D/Mono    ( 6220): DllImport loaded library '/system/lib/liblog.so'.
09-28 21:50:54.505 D/Mono    ( 6220): DllImport searching in: '/system/lib/liblog.so' ('/system/lib/liblog.so').
09-28 21:50:54.505 D/Mono    ( 6220): Searching for '__android_log_print'.
09-28 21:50:54.505 D/Mono    ( 6220): Probing '__android_log_print'.
09-28 21:50:54.505 D/Mono    ( 6220): Found as '__android_log_print'.
09-28 21:50:54.510 I/MonoDroid( 6220): UNHANDLED EXCEPTION:
09-28 21:50:54.819 I/MonoDroid( 6220): System.TypeInitializationException: The type initializer for 'osuTK.DisplayDevice' threw an exception. ---> System.IO.DirectoryNotFoundException: Could not find a part of the path '/dev/dri'.
09-28 21:50:54.819 I/MonoDroid( 6220):   at System.IO.__Error.WinIOError (System.Int32 errorCode, System.String maybeFullPath) [0x000f7] in <43dbbdc147f2482093d8409abb04c233>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at System.IO.FileSystemEnumerableIterator`1[TSource].HandleError (System.Int32 hr, System.String path) [0x00006] in <43dbbdc147f2482093d8409abb04c233>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at System.IO.FileSystemEnumerableIterator`1[TSource].CommonInit () [0x00054] in <43dbbdc147f2482093d8409abb04c233>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at System.IO.FileSystemEnumerableIterator`1[TSource]..ctor (System.String path, System.String originalUserPath, System.String searchPattern, System.IO.SearchOption searchOption, System.IO.SearchResultHandler`1[TSource] resultHandler, System.Boolean checkHost) [0x000d6] in <43dbbdc147f2482093d8409abb04c233>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at System.IO.FileSystemEnumerableFactory.CreateFileNameIterator (System.String path, System.String originalUserPath, System.String searchPattern, System.Boolean includeFiles, System.Boolean includeDirs, System.IO.SearchOption searchOption, System.Boolean checkHost) [0x00009] in <43dbbdc147f2482093d8409abb04c233>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at System.IO.Directory.InternalGetFileDirectoryNames (System.String path, System.String userPathOriginal, System.String searchPattern, System.Boolean includeFiles, System.Boolean includeDirs, System.IO.SearchOption searchOption, System.Boolean checkHost) [0x00000] in <43dbbdc147f2482093d8409abb04c233>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at System.IO.Directory.InternalGetFiles (System.String path, System.String searchPattern, System.IO.SearchOption searchOption) [0x00000] in <43dbbdc147f2482093d8409abb04c233>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at System.IO.Directory.GetFiles (System.String path) [0x0000e] in <43dbbdc147f2482093d8409abb04c233>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at osuTK.Platform.Linux.LinuxFactory.CreateDisplay (System.IntPtr& gbm_device, System.IntPtr& egl_display) [0x00011] in <a54ff0cec5aa4de9af1726aec139577d>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at osuTK.Platform.Linux.LinuxFactory.get_gpu_fd () [0x0001d] in <a54ff0cec5aa4de9af1726aec139577d>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at osuTK.Platform.Linux.LinuxFactory.CreateDisplayDeviceDriver () [0x00001] in <a54ff0cec5aa4de9af1726aec139577d>:0
09-28 21:50:54.819 I/MonoDroid( 6220):   at osuTK.DisplayDevice..cctor () [0x00010] in <a54ff0cec5aa4de9af1726aec139577d>:0
09-28 21:50:54.819 I/MonoDroid( 6220):    --- End of inner exception stack trace ---
09-28 21:50:54.820 I/MonoDroid( 6220):   at osu.Framework.Platform.Android.myAndroidGameWindow..ctor () [0x00008] in C:\Users\ppast\OneDrive\Pulpit\osu-developing\osu-framework\osu.Framework.Platform.Android\myAndroidGameWindow.cs:20
09-28 21:50:54.820 I/MonoDroid( 6220):   at osu.Framework.Platform.Android.AndroidGameHost..ctor (System.String gameName, System.Boolean bindIPC) [0x0000a] in C:\Users\ppast\OneDrive\Pulpit\osu-developing\osu-framework\osu.Framework.Platform.Android\AndroidGameHost.cs:27
09-28 21:50:54.820 I/MonoDroid( 6220):   at osu.Framework.AndroidHost.GetSuitableHost (System.String gameName, System.Boolean bindIPC) [0x00001] in C:\Users\ppast\OneDrive\Pulpit\osu-developing\osu-framework\osu.Framework.Platform.Android\AndroidHost.cs:10
09-28 21:50:54.820 I/MonoDroid( 6220):   at SampleGame.MainActivity.OnStart () [0x0000e] in C:\Users\ppast\OneDrive\Pulpit\osu-developing\osu-framework\SampleGame.Android1\MainActivity.cs:23
09-28 21:50:54.820 I/MonoDroid( 6220):   at Android.App.Activity.n_OnStart (System.IntPtr jnienv, System.IntPtr native__this) [0x00009] in <a10f61e70eeb434e952fef884856c199>:0
09-28 21:50:54.820 I/MonoDroid( 6220):   at (wrapper dynamic-method) System.Object.4(intptr,intptr)
09-28 21:50:55.533 W/zygote  ( 6220): JNI RegisterNativeMethods: attempt to register 0 native methods for android.runtime.JavaProxyThrowable
09-28 21:50:55.541 D/Mono    ( 6220): DllImport searching in: '__Internal' ('(null)').
An unhandled exception occured.

Do i understand it well, that it tries to get something from x11, but it isn't supported in android?

Well at core android is a linux based OS, so finding things like /dev/* is more or less normal.
What is strange tough is that it seems to call something in osuTK.Platform.Linux, I don't think that's supposed to happen, you sure you're using the correct library?
openTK can be quite wonky when it comes to mobile support, it didn't even compile properly on android for quite a while.
You might want to compare opentk/opentk/develop/src/OpenTK/Platform/Factory.cs with ppy/opentk/develop/src/OpenTK/Platform/Factory.cs

@neico osuTK is my fork of ppy's OpenTK that just has the top-level namespace and assemblies renamed.  It's to prevent namespace clashes with Xamarin's outdated OpenTK fork.

After some code reading i think loading using Linux factory seems reasonable, and not like a bug. But i don't know maybe this is incorrect.
AndroidFactory is used only as embedded factory and i haven't seen how it's used

TBH I would take most of the OpenTK Android/iOS code with a grain of salt, as the maintainers have no interest in supporting it.  There will likely be significant changes required to OpenTK to get it to a usable stage for osu!framework on mobile platforms.

without building androidfactory/iosfactory and neccesasry clases from scratch, i think using sdl2 could solve part of problems (only CreateGLContext isn't implemented sdl2factory), but building this is some mess too

I have an Android device, so I'm going to help out with this as well.
Perhaps I'll learn a lot about C# and Xamarin and many other things in the process.

Please follow the discussion in the OpenTK Discord server to keep up to date on the Xamarin situation. 👍


path error

I found cmd path not suit for it.
open /Users/Apple/.qwen-cli/api-config.json: no such file or directory
Error: open /Users/Apple/.qwen-cli/api-config.json: no such file or directory

but actually we create them in /Users/Apple/.qwen-cli/conversation/api-config.json

Hi Eason, try a again please :)


Support Step Load Pattern

This PR adds a new feature related to the issue: #1001
The main idea is to allow you to trigger a load test in Step Load pattern, and you can specify a Step Clients and a Step Duration to monitor your server's performance with different user load.
For example if you specify the swarming plan with
Total Clients of 50, Hatch Rate of 1, Step Clients of 5 and Step Duration of 5m
click the button and it will trigger a load test with increasing the user load by 5 every 5 mins.
At last you will get the metrics charts as below after 1h' running:

I think hatch rate is already a step with 1s as interval.

How much of the desired feature can be had by allowing control of the length of the hatch-step? Instead of #/sec label it "# spawned per step" and allow setting the "hatch-step length". In the example case, hatch-rate 5, hatch interval 5m should yield most of the same behavior.

Seems this code does not work with a single local locust instance:
[2019-06-17 16:15:59,368] sensei/ERROR/stderr: AttributeError: 'LocalLocustRunner' object has no attribute 'start_stepload'

Seems this code does not work with a single local locust instance:
[2019-06-17 16:15:59,368] sensei/ERROR/stderr: AttributeError: 'LocalLocustRunner' object has no attribute 'start_stepload'

@reedstrm thank you for trying it out, yes, currently start_stepload is only supported in distributed mode.

How much of the desired feature can be had by allowing control of the length of the hatch-step? Instead of #/sec label it "# spawned per step" and allow setting the "hatch-step length". In the example case, hatch-rate 5, hatch interval 5m should yield most of the same behavior.

I want to make sure this change is backward compatible, so I didn't modify the old interface and added two params for step load support.

I think hatch rate is already a step with 1s as interval.

Actually hatch rate is kinda of a booting rate, and the users/second line chart is kinda of linear. while step load is to increase the user load by step and the users/second line chart is kinda of staircase curve.
For more reference please go to Proposal #1001.

I think what's proposed in this PR with the extra options is a little hard to understand?
For example, the graph shown doesn't look any different to something you can produce with the current implementation? Maybe at least update the docs to make it clear

I think what's proposed in this PR with the extra options is a little hard to understand?
For example, the graph shown doesn't look any different to something you can produce with the current implementation? Maybe at least update the docs to make it clear

actually it's a new way to run load test by step, for more details please go to proposal https://github.com/locustio/locust/issues/1001

Hi @delulu !
I dont see the need for three command line flags (you could just remove --step-load).
Could you make another test case that validates the step pattern (number of clients at a certain point in time for example)?
@heyman What do you think of this change? I think it is a nice feature, but I'm unsure about the implementation, and I think we might need to rethink the web gui as we add more parameters.

does LocustRunner.stop() really still work after this change? It specifically looks at hatching_greenlet on line 196. I think the correct way of doing this is using only the hatching_greenlet variable, and not adding a new one.

I added a comment in the related #1001 issue: https://github.com/locustio/locust/issues/1001#issuecomment-546004337
(I would really like Github to add a feature for merging issues/PRs)

@cyberw I've update the test case for step load validation, please have a check.

merged with latest master branch and resolved conflicts.

Personally I still prefer always having the UI option present (but hidden, maybe under an "advanced" selection together with host name) instead of explicitly passing a --step-load to enable it in the gui.
But I'm not a gui person anyway, so I'm ok with merging if you resolve the conflicts.
@heyman Your opinion on this? I agree that we may want a more flexible format in the future, but this does solve an important problem in a quite simple way which will be useful to a lot of ppl.

@heyman I've replied to your comment, please take a look at https://github.com/locustio/locust/issues/1001#issuecomment-549237782.

@cyberw I'll resolve the conflicts, but for the check failure of codecov/patch, I don't know why this check failed, could you show me a way to fix it?

@cyberw I'll resolve the conflicts, but for the check failure of codecov/patch, I don't know why this check failed, could you show me a way to fix it?

Ignore it :)

LGTM. I will merge soon if nobody objects (@heyman ?). I would like to improve the UI, but we can do that later.

Thanks for your contribution!

@delulu I just realized this is not documented (outside the help function). Would you consider adding some documentation?

@delulu I just realized this is not documented (outside the help function). Would you consider adding some documentation?

sure, will add it : -)


Feature/cdr 380 ehr distribution

Reviewed together with @stefanspiska :
will be merged after verifying that the j-meter tests still deliver valid results with the new insert and generation implementation.

Reviewed together with @stefanspiska : will be merged after verifying that the j-meter tests still deliver valid results with the new insert and generation implementation.

The impacted queries (composer/name) still return results


Document keeping controllers out of packs dir

Previously, the documentation for installation had an example implying a directory structure of app/javascript/packs/controllers. However, the documentation for rails/webpacker states that packs is a special directory that should only contain entrypoints to be included in HTML, ex. application.js.
This changes the installation example to imply a directory structure of app/javascript/controllers, and explicitly gives that structure as context to the example.

Thanks for bringing this up!
The Stimulus documentation tries to steer clear of framework (e.g. Rails) specifics, and its install guide includes a section for webpack, but not webpacker, which has its own set of conventions. If you're using Rails + Webpacker, I suggest using the baked in Stimulus installer. It creates a controllers/ directory adjacent to packs/, avoiding the issue/question you ran into here.
So, we're going to pass on this change for now, and will consider updating the docs to nudge people using Rails in the right direction. Thanks again, and sorry for the confusion.


Maintenance: Enable auto-merge for non-failed Github PRs

Summary
Over 10 PRs are automatically created per week to update dependencies. Project maintainers need to manually approve merging of the successful ones.
Why is this needed?
Improve governance and reduce manual work.
Which area does this relate to?
Automation, Governance
Solution

Review and fix "Auto merge if dependabot PR" Github workflow here. Last execution is available here.
Review and define which dependencies can be trusted for auto-merging.

Acknowledgment

[X] This request meets Lambda Powertools Tenets
[ ] Should this be considered in other Lambda Powertools languages? i.e. Python, TypeScript

It woks now. A few have been merged.


refactor history component

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #2589
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Also 006 has the current owner ;)

Also 006 has the current owner ;)

TBH, I'm not sure what do you mean? I already used currentOnwer in the code.

Waiting for the publication of @kodadot1/minimark with the new version

Published!
I am still fighting with the publish github action

Re: force update events:
Make a watcher that will trigger apollo to fetch events :)
Watcher should watch: burned, currentOwner, price

Re: force update events:
Make a watcher that will trigger apollo to fetch events :)
Watcher should watch: burned, currentOwner, price

Done. Now it could fetch events on demand.

@petersopko Please take a look at this pr ❤

@Jarsen136 lgtm, just pls resolve conflicts and update :)

@Jarsen136 lgtm, just pls resolve conflicts and update :)

Done

@Jarsen136 lgtm, just pls resolve conflicts and update :)

Done

I think the deepscan issue might be right in this case ...? it is an inconsistency there? lmk what you think

I think the deepscan issue might be right in this case ...? it is an inconsistency there? lmk what you think

Sure, I have solved them. @petersopko

pay 150 usd


zcbor: backport zcbor_any_skip() for zcbor < 0.7.0

Backport fixed zcbor_any_skip() from zcbor 0.7.0.
This fix was originally implemented by @mniestroj in https://github.com/golioth/golioth-zephyr-sdk/commit/e6a6117.

I have tested this using the nRF9160dk. Prior to this PR the RPC example fails:
[00:00:56.632,995] <inf> lte_monitor: RRC: Connected
[00:00:59.781,250] <wrn> golioth_rpc: Failed to skip param (5)
[00:00:59.781,280] <err> golioth_rpc: Failed to parse tstr map
[00:01:07.368,652] <inf> lte_monitor: RRC: Idle

With this PR, the RPC completes as expected:
[00:00:32.868,499] <inf> lte_monitor: RRC: Connected
[00:00:34.978,607] <dbg> rpc_sample: on_multiply: 42.000000 * 1.000000 = 42.000000
[00:00:45.465,972] <inf> lte_monitor: RRC: Idle

I have also tested the following on this branch and found all working:

NCS: Settings
ESP-IDF: Settings
ESP-IDF: RPC


[BUG] [ws-sbom-generator] SPDX field extractedText should be filled with full licence text for all components

Bug Description
In the SPDX output created by ws-sbom-generator we see two issues with the SPDX field extractedText:

The field is filled with the licence name. According to the SPDX standard it should be filled with the full licence text as provided with the component: "Purpose: Provide a copy of the actual text of the license reference extracted from the package or file that is associated with the License Identifier Assigned to aid in future analysis." - see https://spdx.org/rdf/spdx-terms-v2.0/dataproperties/extractedText___-1947076550.html
The extractedText field seems only to be present for licences w/o an SPDX ID. For providing an SBOM compliant with many of the open source licences we need to deliver the full licence text for each component. Thus, the full licence text should be present for all components listed in the SPDX file. Please not that for licences like MIT or ISC this licence text should not be the template with the placeholders " " but should contain the original licence text as provided with the component or the present in the component's source code.

Steps to Reproduce
Steps to reproduce the behavior:

scan a project with WhiteSource scanner
obtain project token for the scan
run ws_sbom_generator -u $WS_USERKEY -k $WS_APIKEY -s $WS_PROJECTTOKEN -a $WS_URL -t json -e ./whitesource/sbom_extra.json -o ./whitesource/artifacts
inspect SPDX json output

Expected Behavior
see Bug Description
Environment Details
reproducible on Azure DevOps build pipelines using the ubuntu-20.04 image

Hi @DimarrWS,
I just did as you said - but I couldn't observe any change in the output, I'm afraid.
This is the log output of the build step for ws_sbom_generator: pipeline-spdx-new.log
When comparing this to an older run (pipeline-spdx-old.log) I can see a change in the ws_sbom_generator's version number: it changed from ws_sbom_generator-0.5.8-py3-none-any.whl to ws_sbom_generator-0.6.1-py3-none-any.whl.
However, the resulting SPDX file still has just the licence name in the extractedText field and the hasExtractedLicensingInfos section only contains 3 licences - whereas the project contains 6 different licences in total. This is the created SPDX file:WhiteSource LicenseCheck_master_0.1.0-beta.180 SBOM report-SPDX-2.2.zip
Am I using the right version? Can you see what could be wrong?`
Thanks, Ralf

Hi @RalfEckstein ! I suppose this is my mistake. I have not described it to you in detail. I apologize. The sbom-generator use ws-sdk package. This package was updated too. You need completely to reinstall sbom-generator. It has to take the last version of ws-sdk package (0.10.3) also.

Hi @DimarrWS,
ws_sbom_generator runs on an Azure DevOps build machine provided by Microsoft. This means that we always start with a "clean" machine and install everything from scratch. The log output provided above it seems to indicate that version 0.10.3 of ws-sdk already was used in my test:
2022-06-27T15:02:46.7789249Z Collecting ws-sdk==0.10.3
2022-06-27T15:02:46.7868417Z   Downloading ws_sdk-0.10.3-py3-none-any.whl (47 kB)

Thanks, Ralf

Hi @RalfEckstein  First, please, use pip install ws-sbom-generator == 0.6.3. Second, I ran it locally and see that extractedText contains License text in case this text was presented by SPDX Org. We put the name instead text now just in case that license text was not found on spdx.org

Hi @DimarrWS,
thanks for testing and the explanation. Using the licence text from spdx.org is not exactly what we need. Our legal advisors tell us that we must use the licence text as provided in the package or the corresponding source code. In my understanding this matches the citation from the SPDX standard in the bug description where it says "the actual text of the license reference extracted from the package or file".
We can see in Mend's UI that the original licence text (as provided in package or source code) is available for many packages. Our requirement would be to use this information.
Thanks, Ralf

Hi @DimarrWS,
when re-testing with an enforced 0.6.3 version (see ws-sbom-generator-0.6.3.log) I still get the same SPDX json content:  WhiteSource LicenseCheck_master_0.1.0-beta.180 SBOM report-SPDX-2.2 (1).zip
Thanks, Ralf

Hi @RalfEckstein ! Please, take version 0.6.4. I'll wait your feedback

We have the same problem. The SPDX File should refer to the actual License Text, like the REST API getProductAttributionReport. I checked it with 0.6.5 and it is still not producing the correct output.
The SPDX Attribute "extractedText" should be added and should have the same value as the Attribution Report Attribute "licenseReference" I guess!
Here is an example of a nuget Package:
Generated Json with Attribution Report:
"castle.core.4.4.1.nupkg": [
  {
    "itemNumber": 5,
    "licenses": [
      {
        "license": "Apache 2.0",
        "licenseReference": "https://index.whitesourcesoftware.com/gri/app/reader/resource/content/asString/3020448c-8294-4ed3-9c0f-ebbe3da2076d",
        "licenseText": "License Text Under Appendix"
      }
    ],
    "copyrights": [
      {
        "copyright": "Copyright 2004-2020 Castle Project",
        "copyrightReference": "https://index.whitesourcesoftware.com/gri/app/reader/resource/content/asString/61f46266-b7dc-4f99-b69e-701f6bdcc4ac",
        "author": "Castle Project"
      },
      {
        "copyright": "Copyright 2004-2016 Castle Project",
        "copyrightReference": "https://index.whitesourcesoftware.com/gri/app/reader/resource/content/asString/3f1b15f7-75c7-4f76-9aea-db9031048c57",
        "author": "Castle Project"
      }
    ]
  }
],

Generated SPDX Output by ws-sbom-generator 0.6.5:
    {
        "SPDXID": "SPDXRef-PACKAGE-castle.core.4.4.1.nupkg",
        "name": "Castle.Core",
        "downloadLocation": "https://api.nuget.org/packages/castle.core.4.4.1.nupkg",
        "licenseConcluded": "Apache-2.0",
        "licenseInfoFromFiles": [
            "Apache-2.0"
        ],
        "licenseDeclared": "Apache-2.0",
        "copyrightText": "['Copyright 2004-2016 Castle Project', 'Copyright 2004-2020 Castle Project']",
        "versionInfo": "4.4.1",
        "packageFileName": "castle.core.4.4.1.nupkg",
        "supplier": "Organization: Castle Project Contributors (NOASSERTION)",
        "originator": "Organization: Castle Project Contributors (NOASSERTION)",
        "checksums": [
            {
                "algorithm": "SHA1",
                "checksumValue": "aa7230a8449a6849af8be6996ce8374b5dab4bf7"
            }
        ],
        "homepage": "https://api.nuget.org/packages/castle.core.4.4.1.nupkg",
        "filesAnalyzed": false
    },

Hi @Markus-Wild !  First of all, you can take the new version 0.6.6 with small updates related to getting extractedText data. Second, If I understood your request correctly, I think you are a little bit wrong.
In SPDX documentation (https://spdx.dev/spdx-specification-21-web-version/) described when Tag "Extracted Text" should be added.
Item 6.2.2 is "Intent:  Provide the actual text as found in the package or file for a license that is not on the SPDX License List."
We are not adding License Text for each library from SPDX License List.
Just for extracted packages License text is provided, related to official SPDX documentation.
Related the documentation : the sections for library from SPDX License List contains a different set of fields than a list of Extracted packages.
If I misunderstood your question, please specify it and I'll be happy to help.

Hi @DimarrWS thanks for your answer.
So if I understand you right, if I want to extract the "exact/original" Licenstext of a package I do not get this information from the spdx document?! So when I have to include the exact Licenstext of a Package with the delivered software I need a second source to get this information from?

Hi @RalfEckstein and @Markus-Wild ! Thank you for your feedback! I understood your requests.
I will check how better to implement it.
And, of course, I will check that SPDX output file will be valid after adding extractedTexp into every section.
I will update you soon.

HI @RalfEckstein , @Markus-Wild !
We prepared a new release 0.6.7.
Added two parameters (as described in the Readme file). Now possible to get License text for each library in case we have this text.
Please, pay attention, that needs to update the package ws-sdk too. The last version of ws-sdk package is 0.11.2

Hi @DimarrWS ,
we just experimented with the new v0.6.8 Version:
ws_sbom_generator -u $env:WS_USERKEY -k $env:WS_APIKEY -s $env:WS_PROJECTTOKEN -a $env:WS_URL -t json -o ./whitesource -e ./whitesource/extra-conf.json --license_text True --out_file "license-information"
what makes me wonder is, that the license text for example of the parse5 package is not listed in the license information file as expected:
license-information-SPDX-2.2.json.txt
I expect the content of following link:
https://index.whitesourcesoftware.com/gri/app/reader/resource/content/asString/2a9b1dca-6d7d-4a0c-8e9f-cb38f7433516
Do I understand the meaning of the --license_text parameter wrong or is this still not working correctly?
Thanks,
Markus

Hi @Markus-Wild ! Please, take the new version of sbom-generator. We changed the business logic of extra license text preparation.

@DimarrWS @Markus-Wild For me, it's working now as we (@Markus-Wild is a colleague) expected.

@DimarrWS :Thanks a lot for your effort!
So from my point of view this thread can be closed!
Kind regards,
Markus
P.S.:
@RalfEckstein: Can you confirm this?

@Markus-Wild , @RalfEckstein
thank you for your feedback!
Mend PS Team


gojpeg merge

Here is the cleaned up version of the gojpeg conversion (targeting #324)

I formatted the code as best I can to match the existing project
The Encoder and Decoder class have all non-essential fields/methods private
All jpeg helper classes are marked internal to prevent external access

Let me know if you want any more changes to encapsulation or formatting.

I'm good to merge this as-is. I can apply my particular OCD to the code after (I enjoy that kind of thing) It'll help me to understand properly what is going on when I add documentation anyway.
Thanks again for this!

Hi @mweber26
As I'm going through the library to port to a generic Image type I've just noticed that there are a couple of fields in the jpeg decoder that are not used.
    private byte[] blackPix;
    private int blackStride;

https://github.com/JimBobSquarePants/ImageProcessor/blob/Core/src/ImageProcessorCore/Formats/Jpg/JpegDecoderCore.cs#L322
Have you any idea what they are for? I can't figure it out from the golang source.
https://github.com/golang/go/blob/0104a31b8fbcbe52728a08867b26415d282c35d2/src/image/jpeg/reader.go#L126
I'm going to be doing a full cleanup of the class to match the styles of the other formats so I'd like to make sure everything is ok first.

I am pretty sure that they are used for an adobe extension to support CMKY/YPrPbK inside 3 component JPEG.

Thanks for that! :+1:
I reckon I can do without it for now then and go ahead with a cleanup.
I'm going to be attempting to port it across to match the other encoders in my new generic image branch here. They were easy but this is a different beast.
https://github.com/JimBobSquarePants/ImageProcessor/tree/2540005d263d7cd223413b314faafe322eee30a5/src/ImageProcessorCore/Formats
I may need to call on you if that's ok?

Sure, I haven't looked at the new encoder framework, but let me know if you run into any problems.

Thanks. Appreciate it!


Better dispatch for submodules

While testing the dispatch_model features in this PR I hit some edge case for model parallelism: when a submodule of a given model is never actually called in the forward pass (like the h of the GPT-2 model which is a module list which is iterated on in the forward but not directly called) the inputs aren't necessarily moved to the right device.
This PR adds a hook in all submodules to just move those inputs to the device, which fix this issue.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Not yet, will have a look before merging (though I don't expect much difference since there is not that many submodules).


[FLINK-14076] Ensure CheckpointException can always be deserialized on JobManager

What is the purpose of the change
JobManager would previously fail to deserialize a DeclineCheckpoint if it contained a CheckpointException with a root cause from user-defined code. For example, if a org.apache.apache.kafka.KafkaException caused a checkpoint to fail, it would get wrapped in a CheckpointException. The KafkaException is not on the JM classpath, so the (wrapped) KafkaException will cause deserialization to fail on the JM. Now CheckpointException always wraps its cause to ensure deserialization works.
Brief change log

JM is guaranteed to be able to deserialize DeclineCheckpoint from TM

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: don't know
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@jdm2212 thanks for updating the PR. I'll mark it as ready for review then.

Thanks!


PA Team 1st submission

Hello! Thank you for entering, I'm very happy you're here. Your submission scores 0.573, which is the best performance we've had yet from a neural net. (Surprisingly — I expected them to dominate this contest.) It's also one of the best first attempts we've had, second only to Paolo Bestagini's first go. So: kudos to you, and I hope you get a chance to try to better it.

Thanks, will try with additional feature engineering.


Buggy rendering of some NFOs?

Hi,
i've two NFO files that render badly in ICY Tools but look correct in NFOPad (see screenshots).
Is there a special option to render these correctly? (NFOs attached)
Thanks.

Nfo.zip

Embarrassing :/ didn't handle the tab char correctly :/.  Will update icy view/draw when the build finishes.


Update scala3-compiler, scala3-library to 3.4.1

About this PR
📦 Updates

org.scala-lang:scala3-compiler
org.scala-lang:scala3-library

from 3.3.3 to 3.4.1
📜 GitHub Release Notes - Version Diff - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

As this is a library I would stick to the Scala LTS version:

… so which version should I update to?
Scala 3.4.0 code can use dependencies compiled with Scala 3.3.x, but not the other way around. That means that if you are a library author, you should stay on the LTS line. Moreover, you can safely bump the patch version of the LTS release and benefit from the bugfixes without forcing any updates on the consumers of your library, even in regard to the patch version.

https://www.scala-lang.org/blog/2024/02/29/scala-3.4.0-and-3.3.3-released.html
Scala Steward can't (not yet) distinguis between Next and LTS

@mzuehlke good catch. Sure, I will revert. Thanks for your feedback!


Styling issue when using a custom spacing function

Environment

Tech
Version

@material-ui/pickers
3.2.6

material-ui
4.4.2

React
16.8.6

Browser
Chrome 76

Peer library
data-fns 1.3.11

Steps to reproduce

Override styles using custom spacing
Instead of number, use a function as per instructions

Expected behavior
Time picker styling of clock numbers should not break
Actual behavior
The clock numbers of all shifted to the left.
Live example
https://codesandbox.io/s/async-dew-j2hcs

@r-s-sandbox Maybe because you overwrote the spacing method in index.js file which caused the above case. You can comment it as below to try again:
const materialTheme = createMuiTheme({
  //spacing: factor => `${0.25 * factor}rem`
});
``


Skip test_dask_fsql on Python 3.8 pytests

For the past couple of months, test_dask_fsql (formerly test_fsql) would fail randomly on our Python 3.8 tests. I was wondering if we should just mark these cases as skips, or if there are any plans to debug this?
From what I've seen, these failures happen on Windows and MacOS, and I don't recall seeing it happen on Ubuntu. If desired, I could add an even more specific condition to skip Windows+Python3.8 and MacOS+Python3.8 and still run Ubuntu+Python3.8.

Codecov Report

Merging #1021 (9603a8c) into main (910fe19) will decrease coverage by 0.41%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
- Coverage   80.88%   80.48%   -0.41%
==========================================
  Files          76       76
  Lines        4322     4320       -2
  Branches      788      780       -8
==========================================
- Hits         3496     3477      -19
- Misses        655      665      +10
- Partials      171      178       +7

Impacted Files
Coverage Δ

dask_sql/integrations/fugue.py
85.71% <0.00%> (-14.29%)
:arrow_down:

dask_sql/physical/rex/core/literal.py
58.09% <0.00%> (-2.86%)
:arrow_down:

dask_sql/physical/rel/logical/window.py
95.37% <0.00%> (-1.74%)
:arrow_down:

dask_sql/physical/utils/statistics.py
89.41% <0.00%> (-1.18%)
:arrow_down:

dask_sql/_version.py
32.76% <0.00%> (-1.13%)
:arrow_down:

dask_sql/physical/rel/custom/predict_model.py
75.00% <0.00%> (-0.68%)
:arrow_down:

dask_sql/utils.py
100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add sorting order to DataField and SchemaAttribute

Avro Fields have Schema.Field.Order which is  how values of this field should be ordered when sorting records. This value needs to be stored in the DataField and SchemaAttribute

The Avro schema's Enum is defined here: https://avro.apache.org/docs/current/api/java/org/apache/avro/Schema.Field.Order.html
It includes 3 values:

ASCENDING
DESCENDING
IGNORE

This is the new Enum called DataItemSortOrder and its use in SchemaAttribute:

And the new property in DataField


Add reference-source jars to ensime config

Doesn't automatically fetch the sources, but if they've already been
fetched (such as by running mvn dependency:source), then it will
attempt to detect them and add the one's that actually exist in the file
system to the ensime config file.

@parsnips @fommil any thoughts on this pull request? Been sitting here for a month with no comments.

Hey @tanzoniteblack and @fommil apologies I've been super busy with non-scala/jvm stuff as of late.  I'll get to this tonight.

Thanks @tanzoniteblack I'm working on getting CI up and running and then will get this published into maven central soon.


Change or fix links to OpenAPI Reference and Metagov API

Description
All links to "OpenAPI Reference" & "Metagov API" in docs lead to a 400 Bad Request error page.
This is the link currently being used: https://metagov.policykit.org/redoc/
Files
https://github.com/metagov/gateway/blob/master/docs/index.rst
https://github.com/metagov/gateway/blob/master/docs/readme.rst

We're not running metagov as a co-located server anymore, so that may explain the 404. If we want to keep hosting this (it's the swagger interface, right?) we may need to expose it via policykit.

@mashton Hi Miriam, do you remember what the "OpenAPI Reference" link in the docs was pointing to? Was this the Swagger page?

@thelastjosh it was the OpenAPI documentation, which was being served up as a swagger page at /swagger and a redoc page at /redoc

Perfect, thanks Miriam!
On Tue, Mar 1, 2022 at 11:55 AM Miriam Ashton @.***>
wrote:

@thelastjosh https://github.com/thelastjosh it was the OpenAPI
documentation, which was being served up as a swagger page at /swagger
and a redoc page at /redoc
—
Reply to this email directly, view it on GitHub
https://github.com/metagov/gateway/issues/190#issuecomment-1055648671,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHA5PEYOSBGN72RR6QTBD3U5ZDXFANCNFSM5OIKCEYQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
http://www.joshuatan.com/research/

Essentially, what needs to happen is we need to move code from this urls.py in Gateway:
https://github.com/metagov/gateway/blob/maste/metagov/metagov/httpwrapper/urls.py#L101
Into the policykit urls.py:
https://github.com/policykit/policykit/blob/master/policykit/policykit/urls.py
I'm not sure precisely what code needs to be moved over, since DRF is doing some fairly complex stuff here.

@shaunagm that's what's required technically, but it raises some flags for me (Though I may have missed some arch changes!). I don't understand why PolicyKit should expose the OpenAPI docs. Metagov Gateway is a layer under PolicyKit, and the PolicyKit authoring API for accessing these services is different from the Metagov Gateway API (as we discussed on Slack last week re: the voting method). So, developers who are using PolicyKit should reference documentation that works for Policykit. What purpose does it serve to serve the Gateway OpenAPI docs from PolicyKit?
I think the OpenAPI docs are correctly located in the http-wrapper package because they will be exposed alongside the "public metagov service" (not sure if that exists yet).

_ If the problem is that there is no deployment of http-wrapper yet, one idea is to set up a minimal one that only exposes the documentation endpoints but has all other endpoints turned off._
That is the problem I believe. After checking with the requester this doesn't seem to be an urgent issue, so I think we're okay to go with the longer term fix of:

[ ] removing the broken link from the docs
[ ] setting up a separate deployment with http-wrapper to expose them again, and adding that new link to the docs


GoAFormItem currently requires label property

Info
In our documentation, the label property for the Form Item component is listed as not required. And in the web component, it is not required. But our react component requires it.
Acceptance Criteria:

Our GoAFormItem React component no longer requires label

:tada: This issue has been resolved in version 4.14.0-alpha.3 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


AI: Dark mode toggle is not remembered per page

Think this is more a limitation of Mesop right now (could do it by passing query param, but kind of ugly), but could be nice if the dark mode toggle could not revert back to the default system choice every time I change the page (if I override the toggle).

Yeah, I noticed this too and I think we should consider having some kind of app-wide settings for dark theme so that the preferences are set across all pages and persisted across navigations. There are ways around it, e.g. query param, passing into state, but they're quite inconvenient.
At the same time, I think there could be usages of app-wide settings like having a static dir for serving assets, e.g. JS, CSS, favicon, images, etc.


National Numer - Leading Zero in CarrierNumberEditText

I am using the CountryCodePicker in combination with the CarrierNumberEditText.
For Austria, the hinted number shows with a leading zero (used for national dialing): 0664 12345.
If the user enters the number like that "0664 12345", and I use getFullNumberWithPlus(); to read it, ccp returns "+43066412345" whereas it should return "+4366412345".
How can I make sure that the national prefix is not included in the number I receive from ccp?
When debugging the code, I saw that the national 0 was added in PhoneNumberUtil => format => maybeAppendFormatExtension due to the fact that you set the flag to NATIONAL.

@joielechong any chance for this to happen?

No activity & no need anymore. Closing issue.


Improve get partitions and reset spec

do not fill mountpoints if we dont need them
try to unmount partitions before we format them
only warn about missing partitions if we are asking to format them
getpartitions now tries to find the mountpoint by label as well

The main issue here was that a partition mounted as /dev/disk/by-label/LABEL would not be found properly by ghw library, so the mountpoint will always be empty
This patch introduces an extra check on the GetAllPartitions functions that if the mountpoint its empty it will try to infer if it was mounted by label instead and gather the mountpoint
Only reset should be affected by this, as we only format in that case and we only need the mountpoint during the reset to be able to unmount it beforehand. In upgrade and install we dont really need that so its not implemented there.
Fixes: https://github.com/kairos-io/kairos/issues/2836

Since this is the agent, this may not be covered by any tests here but we should probably add a test in the e2e suite to make sure we don't break it again.

We have a reset test already in the e2e suite of kairos. We dont have a test for reset-oem as that would need extra work to support it, but we should do one. Something like reset-oem + after-reset-chroot stage to create a new cloud-config so on restart it can login :D
Also there is unit tests for this I think which should cover this changes.

Since this is the agent, this may not be covered by any tests here but we should probably add a test in the e2e suite to make sure we don't break it again.

We have a reset test already in the e2e suite of kairos. We dont have a test for reset-oem as that would need extra work to support it, but we should do one. Something like reset-oem + after-reset-chroot stage to create a new cloud-config so on restart it can login :D
Also there is unit tests for this I think which should cover this changes.

If it was covered, shouldn't those tests be broken?

Since this is the agent, this may not be covered by any tests here but we should probably add a test in the e2e suite to make sure we don't break it again.

We have a reset test already in the e2e suite of kairos. We dont have a test for reset-oem as that would need extra work to support it, but we should do one. Something like reset-oem + after-reset-chroot stage to create a new cloud-config so on restart it can login :D
Also there is unit tests for this I think which should cover this changes.

If it was covered, shouldn't those tests be broken?

Only the normal reset ones, we do not test the reset OEM part :)
That will change hopefully and we will see this patch fixing the test I hope?


Error: :nxdomain

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
i used tesla_auth as Tesla API tokens generator, then copy and paste access & refresh token into teslamate app, yet getting this error

Error: :nxdomain

Expected Behavior
sign into teslamate ui
Steps To Reproduce

download/run tesla_auth
open teslamate over web and copy/paste respective tokens

Relevant log output
teslamate-1  | 2024-11-14 22:49:31.878 [error] POST https://auth.tesla.com/oauth2/v3/token -> error: :nxdomain (8001.790 ms)

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
teslamate/teslamate:1.31.1

Is the hosting device able to access the internet? Have you restarted the containers?

Is the hosting device able to access the internet? Have you restarted the containers?

i actually just restarted host and was able to login just now! so i guess the issue wasn't teslamate, but rather somewhere else..


Drop usage of serializable transactions

I audited all uses, and none of them should be serializable; ReadCommitted is more than fine. I also removed the helper to discourage accidental future use.
Release Note

Drop usage of serializable transactions

/assign @mikehelmick

needs a go mod tidy
removed dependencies

/lgtm


wl_pointer's axis_source event is sent multiple times per frame

According to the Wayland spec, only one axis_source event is permitted per pointer frame. When scrolling on my laptops touchpad diagonally, two identical axis_source events are emitted.
wev output:
[…]
[13:      wl_pointer] frame
[13:      wl_pointer] axis_source: 1 (finger)
[13:      wl_pointer] axis: time: 228155853; axis: 0 (vertical), value: -3.136719
[13:      wl_pointer] axis_source: 1 (finger)
[13:      wl_pointer] axis: time: 228155853; axis: 1 (horizontal), value: 3.089844
[13:      wl_pointer] frame
[…]

We should fix this in the wlr_seat implementation:

When sending a wl_pointer.axis event, cache the source.
If there's already a cached source, don't send it again. If the event source and the cached source mismatch, error out.
Clear the cached source when sending wl_pointer.frame.


Simplifies the sample application deployment guide.

This allows users to try how to deploy kubernetes resources into a newly provisioned cluster and access the application using TLS.
Change-type: patch

LGTM!


Adding gemm batched benchmark

@przemektmalon you're right, I've fixed that.
@RossBrunton sure, there are probably better ways, I'd say we can do that later (there's a lot of refactoring that could be done in the benchmarks but it's not a priority)

We mentioned offline that a possibility would be to create a common function for non-batched and batched benchmarks and the non-batched benchmark cold call it with 1, but given that we need two executables anyway, I don't feel like creating a a hpp file with the common code, it would break the structure just to avoid a bit of duplication.
As said before, the benchmarks are not structured in an optimal way but their code is fairly easy to maintain.


Invalid commands in Installation.md

I got a 'permission denied' error when trying to run env/bin/activate on macOS. However, using . env/bin/activate worked.

fixed in