fix python version requirement

The docs say we need 3.4, but then make tells me 3.5.
One of these is wrong.
 ~/src/m8e/dcos-cli [master|…1]
14:59 $ make env
bin/env.sh
Cannot find supported python version 3.5. Exiting...
make: *** [env] Error 1

Also added commit to make an error message easier to act on

@timcharper thanks for the pr! One small comment and then you'll need to update this tests here: https://github.com/dcos/dcos-cli/blob/master/cli/tests/integrations/test_ssl.py#L113

@timcharper some small nits and don't forget to update test_ssl.test_verify_ssl_without_cert_env_var.

You got it!
I couldn't figure out how to run the test_ssl tests properly; looks like I need to set up a snakeoil domain and server or something. Anyways, I'll check back in a bit to see if the build still fails and if I need to do anything else.

@timcharper anything I can help with?


Preparation for release v1.0.1

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
Removed redundant files as well as the external dependencies of Unity.
Created a note for the used Unity version.

How about the removal of framework specific files in examples as well as src ?

will be done in different PR


Remove sha1, add signSync and verifySync for node

We anyway just check if sha256 is given.
Add the signSync and verifySync methods, as crypto code runs in C++ code of node, which makes it by nature block the event loop of node. By making it sync we reduce the unecessary overhead of creating intermediary Promises, which are thrown away anyway. So we can use that in probot / webhooks.js.
Only when using web crypto async maybe makes sense, because that runs by nature async, but I suspect to be signifcantly slower.
We need to patch then webhooks.js repo to use sync calls.
@semver-minor.

Resolves #ISSUE_NUMBER

Before the change?

After the change?

Pull request checklist

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[x] Yes
[ ] No

Implemented now in a way, that it does not break.

@gr2m
Is  the readme now to your liking?


ENH: update everything Binder

[ ] Update repo/notebook name: parameter-test is confusing
[ ] Use bash kernel notebook, not python
[ ] Check if useful progress reporting can be shown
[ ] use updated link in catalog javascript

I've been trying to help here, but I can't find the notebook. :/

Sorry, it is quite obscure and I didn't do anything to shed light on the situation.
The parameter-test comes from a branch on the datalad-binder repo: https://github.com/datalad/datalad-binder/tree/parameter-test, that is set up so that it can work with URL parameters. This should ideally just be merged into main, although we need t check what's in main to be sure we keep all the important commits.
The notebook that's used is here: https://github.com/jsheunis/datalad-notebooks/blob/main/download_data_with_datalad_python.ipynb. This one should probably be the bash notebook and not the python. A bash notebook exists, and I'm not sure why that hasn't been used, it could be that I didn't know yet about the bash kernel when this whole pipeline was set up, or that the jupyter-params extension didn't play nicely with the bash kernel. Need to check. Also, we can probably move the notebook to somewhere in the datalad world, possibly the tutorials repo: https://github.com/datalad/tutorials
This is the code that runs in the browser when selecting "Explore with Binder":
openWithBinder(dataset_url) {
            const environment_url =
              "https://mybinder.org/v2/gh/datalad/datalad-binder/parameter-test";
            const content_url = "https://github.com/jsheunis/datalad-notebooks";
            const content_repo_name = "datalad-notebooks";
            const notebook_name = "download_data_with_datalad_python.ipynb";
            binder_url =
              environment_url +
              "?urlpath=git-pull%3Frepo%3D" +
              content_url +
              "%26urlpath%3Dnotebooks%252F" +
              content_repo_name +
              "%252F" +
              notebook_name +
              "%3Frepourl%3D%22" +
              dataset_url +
              "%22";
            window.open(binder_url);
          },

This would need to be updated to point to the correct main branch (once parameter-test is merged) and the correct notebook repo and name (once notebook is moved).

Test for new setup:
Datalad dataset:
https://github.com/psychoinformatics-de/studyforrest-data.git
Binder-repo:
https://mybinder.org/v2/gh/datalad/datalad-binder/HEAD
Notebook repo:
https://github.com/datalad/tutorials
Notebook name:
notebooks/binder/download_data_with_datalad.ipynb
Seems to work, just need to edit the notebook a bit.

Main problem is that jupyter-notebookparams sets the parameter cell content as:
repo_url = "<dataset-url>"

instead of
repo_url="<dataset-url>"

i.e. there as spaces, where there should be none. I'm guessing this happens internally to the extension. The HTML URL encoding that's used in catalog to add the parameters is as follows:
"%3Frepourl%3D%22" + dataset_url  + "%22";

where:
%3F -> ?
%3D -> =
%22 -> "
therefore:
?repourl="<dataset-url>"
i.e. there aren't any explicit spaces encoded.


Create new renderer styles based on the existing renderers

Implement the function and UI for creating new renderer styles based on the existing renderers. This allows users to reuse the settings of the existing renderers, without editing style files by hand.

Implementation finished.


Unable to upload file to S3 if computer's time is not synchronized

Environment:

fineuploader 5.1.3
Chrome/Windows (I believe it doesn't matter)

Steps to reproduce:

Change your computer's date, add or subtract more than 5 minutes
Go to http://fineuploader.com/demos.html#amazon-demo and try to upload file to S3

Problem description:
An error appears
<?xml version="1.0" encoding="UTF-8"?>
<Error>AccessDenied<Message>Invalid according to Policy: Policy expired.</Message><RequestId>...</RequestId><HostId>.....</HostId></Error>

Console output:
[Fine Uploader 5.1.3] Received 1 files.
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Attempting to validate image.
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Generating new thumbnail for 0
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Attempting to draw client-side image preview.
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Attempting to determine if sample.mp3 can be rendered in this browser
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] First pass: check type attribute of blob object.
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] sample.mp3 is not previewable in this browser per the blob's type attr
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Not previewable
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Sending simple upload request for 0
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Submitting S3 signature request for 0
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Sending POST request for 0
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Sending upload request for 0
upload.fineuploader.com/:1 POST http://upload.fineuploader.com/ 403 (Forbidden)
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Received response status 403 with body: <?xml version="1.0" encoding="UTF-8"?>
<Error>AccessDenied<Message>Invalid according to Policy: Policy expired.</Message><RequestId>E0B80E0216D27E32</RequestId><HostId>XEKD0yb95aoI87baTkof+u/rXRvQG6OV5xvG3McLdZ/ZxFGg/Y+OawFCP0bLEp9I3Eq63MEcC00=</HostId></Error>
all.fine-uploader-5.1.3.min.js:16 [Fine Uploader 5.1.3] Simple upload request failed for 0

I believe it's because JS code adds 5 minutes to the current date when making a signature
expirationDate = new Date(),
....
policy.expiration = qq.s3.util.getPolicyExpirationDate(expirationDate);
....
date.setMinutes(date.getMinutes() + 5);

I suggest to add an optional 'policy expiration' parameter that will control expiration threshold. By default it may be set to 5 minutes
Sincerely, Alex

Yes, this is correct and by design, and you'll really want to ensure that client machines have reasonably accurate time, not just for Fine Uploader or S3.
We can consider adding such an option in a future release.

I second correcting this. We have thousands of users trying to upload everyday, some of which have had incorrect system times. While that I agree that their system times should be accurate, it seems unreasonable for us to expect it to always be so. I don't know of any professional web services that fail due to an incorrect system time on the client. As the policy is being processed by our own servers first (validation and signing), it would make sense to use the time on the server for these requests. As a paid customer, we hope you will strongly consider making this change.
Thanks for all your hard work on this.

I don't see how we will be able to consider server-time, without some breaking changes or complex code adjustments. This is especially true as we look into support for v4 signatures. However, we will consider allowing the 5 minute expiration time to be adjusted via a client-side option.

We are seeing a lot of failed uploads because of this. While I am stupefied by the apparent number of people with bad system times, this should not be a prerequisite for them using our site. Otherwise we love the functionality of FineUploader as it solves a number of problems for us.
Is there any way - or incentive - that can expedite the inclusion of the configurable expiration time?

You have a few options, all are fairly easy to achieve since Fine Uploader is a JavaScript library.

Override the qq.s3.getPolicyExpirationDate function with your own logic. This can perhaps be simply done by keeping a copy of the original implementation in scope, updating the passed Date to reflect your desired expiration date, and then calling the original function with the modified Date.

Modify the code locally to change the + 5 minutes part of the expression in getPolicyExpiration to your desired value.

In both cases, you'll need to be conscious of changes to these methods when Fine Uploader is updated, but I don't intend to make any breaking changes to this API. I intend to make this possible either as part of #1336 or shortly thereafter in Fine Uploader 5.3.

@rnicholus the same cause of this bug infects the setting of the x-amz-date header, which is not configurable on the amazon side so can't be worked around in the way you suggested here: https://github.com/FineUploader/fine-uploader/issues/1387#issuecomment-101821802
While I understand that a user should keep their clock up to date, we're using the S3 uploader in production for millions of users, and telling each of them to update their clock is not really a workable solution.
To mitigate this issue, I've modified my local copy of fineuploader to account for clock drift in the following way:

On page load, pass down the unix timestamp generated by the server as a global variable.
Calculate clock drift and store it as a param for the signatur request:

signature: {
          endpoint: CONFIG.cloud_uploader.signature.endpoint,
          params: {
            drift: (UNIX_TIMESTAMP * 1000) - Date.now()
          },
         ...

Hack fineuploader getToSign as follows:

headers["x-amz-date"] = new Date().toUTCString();

to:
var driftAdjustedDate = Date.now() + options.signatureSpec.params.drift;
headers["x-amz-date"] = new Date(driftAdjustedDate).toUTCString();

I know this is a hack, but a better written patch can be done without breaking backwards compatibility nor a complicated patch. Please consider fixing this issue as it will improve the reliability of the S3 solution for large sites.

I moved this into the schedule for 5.4.0. In order to account for user time issues, I intend to provide a new option that will allow you to specify the relative policy expiration date. It will default to 5 minutes from present, which is the current hardcoded value that has caused some problems for all who have weighed in on this case.

@rnicholus, thanks for responding. I'm afraid the proposed solution will not work for the issue I outlined in https://github.com/FineUploader/fine-uploader/issues/1387#issuecomment-127343461
Correct me if I'm wrong, but a more robust solution involves passing server time as a drift parameter to account for users clocks being wrong.
I really love Fineuploader, and dislike having to maintain a hacked fork. Would you be willing to accept a patch that introduces a drift parameter?

@mikesherov You're correct, I forgot about x-amz-date. Thanks for reminding me. I'm certainly open to a patch. It would be great if you have a unit test as well, or at least passing unit tests after the change. But if not, I'll take care of that as part of my review of the code.

Yeah, I'll write a test as well. Are we in agreement on the interface? I'll add a drift parameter? I no longer think it belongs as a key on the signature object but rather a key on the main options object since it effects more than just signature signing.
Thoughts?

I can see it being a standalone option property (root-level) or on the request object option. Either way.
I would expect this option to be set as part of Fine Uploader initialization. Fine Uploader will need to calculate the actual drift by comparing server time and browser time, so shouldn't this option be called serverDate? I would expect it to be in ISO8601 format to make parsing easier. If the serverDate option is not supplied, the existing code path will be used. In other words, drift will be determined to be 0.
If writing tests takes up too much of your time, don't worry about it. I may end up adding more tests anyway.

Just deleted my last comment after thinking it over some more.
I can see it being a standalone option property (root-level) or on the request object option. Either way.  If so, it should be in ISO8601 format to make parsing easier. Fine Uploader will need to reformat it and generate future dates in order to properly support POST and multipart upload API uploads across v2 and v4 signatures.
Don't worry too much about the tests if they take up too much of your time. I'll make sure they are in there either way.

OK, I'll put it on the request object, but how about the date being handed in being the unix timestamp in milliseconds, so the code would still be able to determine drift easily by doing serverDate - Date.now()?

Yes, I think that should work.

@mikesherov Due to scheduling obstacles that would prevent a release until the end of December, I'm aiming to release no later than 18 Nov. Will you possibly have a PR ready within the next few days? If not, I'll do my best to implement this feature as we have discussed so I can get this in for the 5.4.0 release.

I'll see if I can get this done today. If not, I'll defer to you. Thanks for your patience and support!

I'm pushing this, along with additional required work described at the bottom of #1258, to a 5.5.0 release. I don't think I can get out 5.4.0 in the next couple weeks if I include these cases. After 5.4.0 releases, I expect there to be other requests that pop up after some start to make use of v4 signature support. Any of those non-critical issues will also be part of 5.5.0.

OK, thats fine. Just let me know if you want me to work on this after 5.4 is out. Thanks again for all your hard work!

work on this case has started for 5.5.0

This feature is now complete and on the develop branch. Can someone pull down 5.5.0-1 and verify that this fixes your clock drift issues? Once this has ben verified by at least one user, I'll consider it complete and ready to be released with the rest of 5.5.0.

...note that the documentation has been updated as well. See http://docs.fineuploader.com/branch/develop/features/s3.html#accounting-for-browserclient-clock-drift and http://docs.fineuploader.com/branch/develop/api/options-s3.html#request.clockDrift for more details.

Looks good to me.

@schmuhl @mcorrigan @alexsaveliev Are you still interested in this feature? If so, can you verify that this change addresses the issue for you?


update name of CZ CELLxGENE Census

Issue and/or context:
CZ has changed the name of the "Cell Census". Update the name and repo link in the README

Codecov Report
Patch coverage has no change and project coverage change: -39.68 :warning:

Comparison is base (b946786) 90.67% compared to head (0996e9e) 51.00%.

:exclamation: Current head 0996e9e differs from pull request most recent head b62131c. Consider uploading reports for the commit b62131c to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1211       +/-   ##
===========================================
- Coverage   90.67%   51.00%   -39.68%
===========================================
  Files          30       61       +31
  Lines        2337     4396     +2059
===========================================
+ Hits         2119     2242      +123
- Misses        218     2154     +1936

Flag
Coverage Δ

python
?

r
51.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 91 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Keyboard shortcuts sync conflict - undefined

Problem description
See how I have badge (1) with Show Conflicts (undefined) inconspicuously indicated the problem

When I reloaded, I got a notification message which told me about the sync conflict but, otherwise, I couldn't understand the problem.
I think there're 2 problems:

The undefined in the context menu
"Show Conflicts" not standing out enough

Reproduction
I think I opened vscode.dev, which resulted in conflicting shortcuts.
Version info
(insiders from march 20, 2023)
Version: 1.77.0-insider (Universal)
Commit: fa13bf16fd237afef07f4df0648da026f43e3963
Date: 2023-03-20T05:27:33.182Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.3.0
Sandboxed: Yes

This bug has been fixed in the latest release of VS Code Insiders!
@ulugbekna, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 0bdaa6f4d8e2fe601514bdf110c8cbed0adfecd8 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

Not sure how to repro, @ulugbekna if you could verify or provide steps that would be great. Thanks


Added prefix and useBootstrap Input() directives.

Closes https://github.com/gmostert/ng2-breadcrumb/issues/37, https://github.com/gmostert/ng2-breadcrumb/issues/36
Also cleaned up the code a bit (spelling error, moving from ctor to ngOnInit).

Thnx man, pulled in the changes and republished as 0.5.3


Update The-Role-of-Attribute-Stores.md

I suggest removing the connection from content referring a product that is not supported anymore. Still, makes sense keeping the description.
Added support to newer versions of SQL and AD;

@rotraves-microsoft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@rotraves-microsoft : Will you be returning to this PR and make the necessary changes, so it can be merged?

I was trying to understand how can I do that change without having to submit everything all over again. Do I need to do that to replace the semi-colon by the dot?

@illfated

Thank you for asking. The main thing to do here, is to go to each of the suggestions from eross-msft and find the merge or commit suggestion buttons, then merge the changes to add it to your PR content. That is mostly what is needed.

Amended. Added my own suggestions to make it easier for you to add the changes manually, by using the [ Commit suggestion ] buttons.

I was trying to understand how can I do that change without having to submit everything all over again. Do I need to do that to replace the semi-colon by the dot?

GitHub has a feature where you can re-edit the file yourself, but most other users do not have access to editing your PR file except for creating a pull request from their repository to yours (the same file in your PR branch). Feel free to ask, if you want to know more about how to edit your file to add the changes manually in one go.


docs(example): add missing mikro-orm section to package.json

The documentation mentions that adding the mikro-orm section to package.json enables TypeScript support for the CLI. However, the actual example code does not include this section.
Based on the information provided in Checkpoint 1, I have added the necessary mikro-orm configuration to the package.json example to ensure consistency and correctness.

this is on purpose, it was removed with v6.3 since its no longer needed. we need to update the text instead of the code

Oh, I see. Thanks for the information. I'm just starting to learn about MikroORM by reading through the documentation. I've noticed there are similar inconsistencies between the text and code examples in the Getting Started guide, which can be quite confusing.
I'm not entirely sure how the text should be updated, so I'm unable to create a PR for that specific change. Could you please close this PR?
By the way, I think the documentation and this package are excellent. Thank you!

Can you point to such examples? I'll be happy to fix them myself.

I saw your comment a bit late. While I might not be able to pinpoint exactly what seemed odd, I have tried to understand and address any issues as best as I could. If I come across any more issues in the future, I will add comments or create new issues.
In the meantime, I have identified and addressed the parts that were definitely not working before seeing your comment, and I have submitted the changes.
Here is the PR: #5913
If there are any parts in the PR that need adjustments, please feel free to modify them, or close the PR and make the changes you see fit.
Feel free to adjust any parts of the message as needed!

https://mikro-orm.io/docs/guide/relationships#creating-entity-graph
In this document, the following content is provided as an example code:
// create new user entity instance via constructor
const user = new User();
user.email =<EMAIL_ADDRESS>user.fullName = 'Foo Bar';
user.password = '123456';

// fork first to have a separate context
const em = orm.em.fork();

// first mark the entity with `persist()`, then `flush()`
await em.persist(user).flush();

// clear the context to simulate fresh request
em.clear();

// create the article instance
const article = em.create(Article, {
  title: 'Foo is Bar',
  text: 'Lorem impsum dolor sit amet',
  author: user.id,
});

// `em.create` calls `em.persist` automatically, so flush is enough
await em.flush();
console.log(article);

And below that, it mentions that if you run this code, an error will occur stating that createdAt and updatedAt are missing.
However, in reality, the error that occurs includes not only createdAt and updatedAt, but also slug and description are missing. At this point, since there is no code to calculate slug and description using the constructor yet, and no optional handling has been done, you need to include slug and description when creating.
I would like to inform you that this part also needs to be modified. Thank you.

https://mikro-orm.io/docs/guide/project-setup#seeding-the-database
In the document above,
expect(res.json()).toMatchObject({
  items: [
    { author: 1, slug: 'title-13', title: 'title 1/3', text: 'text text text 1/3' },
    { author: 1, slug: 'title-23', title: 'title 2/3', text: 'text text text 2/3' },
    { author: 1, slug: 'title-33', title: 'title 3/3', text: 'text text text 3/3' },
  ],
  total: 3,
});

You have written the test matcher code like this, but the test actually fails. This is because the expected value includes the text property, which is a lazy scalar type. However, in the example code of app.ts written earlier, the code for populating is missing as shown below.
Therefore, we should either exclude the text property from the expected value in the test, or populate it in the app.ts code.
import { RequestContext } from '@mikro-orm/core';
import { fastify } from 'fastify';
import { initORM } from './db.js';

export async function bootstrap(port = 3001) {
  const db = await initORM();
  const app = fastify();

  // register request context hook
  app.addHook('onRequest', (request, reply, done) => {
    RequestContext.create(db.em, done);
  });

  // shut down the connection when closing the app
  app.addHook('onClose', async () => {
    await db.orm.close();
  });

  // register routes here
  app.get('/article', async request => {
    const { limit, offset } = request.query as { limit?: number; offset?: number };
    const [items, total] = await db.article.findAndCount({}, {
      limit, offset,
    });

    return { items, total };
  });

  const url = await app.listen({ port });

  return { app, url };
}

https://mikro-orm.io/docs/guide/advanced#validation-via-zod
In this chapter, the process of installing Zod is missing.

The documentation mentions that adding the mikro-orm section to package.json enables TypeScript support for the CLI.

I was checking the original problem again, and it feels like you were looking at older docs version, there is no place mentioning the useTsNode in the getting started guide in v6.3 or next, it is only in the older versions (and there it needs to stay). I will update the stackblitz projects, that's a good point.

Addressed the other issues via #5920 so closing this one. Thanks a lot!

Thanks a lot, Have a good one!


Support Microsoft Office file formats

Most of the documents I would like to search are in ppt or pptx format (Powerpoints).
Would be nice if Powerpoint and Word documents can be indexed, even without a preview option.

This will be an excellent feature to add.

Looking into Apache Tika for this via tika-python. It does require Java to be installed but seems robust and permissively licensed. Open to another solution that has fewer dependencies, but I haven't found a good one yet


Support Functional Interface for Batch Message Listener

Currently, in Java, default methods in functional interfaces cannot be overridden using lambda expressions. While functional interfaces are designed to simplify code using lambdas, default methods are excluded from this flexibility.
@FunctionalInterface
public interface MessageListener<T> {
    void onMessage(Message<T> message);

    default void onMessage(Collection<Message<T>> messages) {
        throw new UnsupportedOperationException("Batch not implemented by this MessageListener");
    }
}

If I want to override the
onMessage(Collection<Message<T>> messages)
method using a lambda, the following code is invalid

 MessageListener<String> listener = messages -> {
    messages.forEach(msg -> System.out.println(msg.getContent()));
};

Solution:
Have Separate Functional Interfaces:
Define separate interfaces for single and batch processing. However, this creates redundancy and bloats the codebase.

@Darshanbc  You're correct that default methods in functional interfaces cannot be overridden using lambda expressions, as lambdas can only target the single abstract method of a functional interface. This is a design limitation in Java.
To address your specific use case, while avoiding redundancy or bloating the codebase with multiple interfaces, you can use an anonymous class to provide an implementation for the onMessage(Collection<Message> messages) method alongside the lambda for the single message handling:
MessageListener<String> listener = new MessageListener<>() {
    @Override
    public void onMessage(Message<String> message) {
        System.out.println(message.getContent());
    }

    @Override
    public void onMessage(Collection<Message<String>> messages) {
        messages.forEach(msg -> System.out.println(msg.getContent()));
    }
};

This approach avoids creating multiple interfaces while giving you flexibility to override the onMessage method for batch processing.
CC : @maciejwalkowiak


Yaml Docs

Given the emphasis Azure DevOps is placing on yaml-defined pipelines, we should update our docs to include usage from yaml as well as the visual designer

Hi @mfkl - honestly I don't know. We're still personally primarily using the Visual Designer based Azure Pipelines so we haven't done much with the YAML configurations yet.
I would assume that the YAML engine supports 3rd party tasks like our mirror git repo task, but we haven't tested yet.
// cc @traviskosarek

@mfkl - you can use a configuration like the below in your yaml file to use the mirror git repo task. Obviously replace the example values below with your respective mirror source/destination repos, etc.
- task: swellaby.mirror-git-repository.mirror-git-repository-vsts-task.mirror-git-repository-vsts-task@1
  displayName: 'Mirror Git Repository'
  inputs:
    sourceGitRepositoryUri: 'https://github.com/swellaby/vsts-mirror-git-repository.git'
    sourceVerifySSLCertificate: false
    destinationGitRepositoryUri: 'https://dev.azure.com/swellaby/OpenSource/_git/mirror2'
    destinationGitRepositoryPersonalAccessToken: '$(destVar)'
    destinationVerifySSLCertificate: true

Thanks @calebcartwright, managed to make it work. I guess your last comment is sufficient to be added to the README as doc and this issue could be closed.


Add Tezos Support

This PR adds Tezos support to 2 of the example projects.
There is also a PR to add the Tezos messages to the docs: https://github.com/WalletConnect/walletconnect-docs/pull/513

Apologies for the prettier noise, I've cleaned it up and synced this branch so the diff is clean now. Currently reviewing.

Sorry about the lag in response here @AndreasGassmann, I missed your initial responses to the review and only saw them end of last week.
Some small tweaks that I'd still recommend above, but beyond that if it works for you we can move ahead here and get this initial setup merged for the sake of getting this off a preview-only branch, and then carry on with deeper work where needed 👍

I included one of your feedback, the others I left for now because they seem to be in line with how the other protocols are implemented, and I'm not sure how to easily add the feature.
In my opinion this can now be merged and we can improve it later on.


Required connectivity

I'm pretty sure you wouldn't be able to sign in (or do anything useful) if connections from your machine to the Internet are totally blocked. Could you sign in and use Azure CLI from a VM with an NSG allowing all Azure IPs?
In other words, what are the connectivity dependencies for using CLI?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93174b3a-3e97-8304-83fc-807be75198fe
Version Independent ID: 1155045b-ce8c-2def-7b0e-043283f8be01
Content: Sign in with Azure CLI
Content Source: docs-ref-conceptual/authenticate-azure-cli.md
GitHub Login: @sptramer
Microsoft Alias: sttramer

I believe that you only need the ability to reach Azure cloud endpoints, which should be possible from any VM hosted in Azure. If those endpoints aren't automatically available, you can get a whitelist of them from az cloud show. If that doesn't work, please reopen this issue and I'll get somebody from engineering to provide more concrete details.


predict API KeyError

Hi,
Trying out the API, and I can't get it to work.
I'm sharing the images with python3 -m http.server 8000
Using gradio_client==0.6.1
from gradio_client import Client
client = Client("http://<IP_ADDRESS>:7860/")
job = client.submit("http://<IP_ADDRESS>:8000/my_image.jpg",api_name="/predict",)
while not job.done():
    time.sleep(0.1)
print(job.status())
print(job.exception)
try:
    print(job.result())
except KeyError as e:
    print(f"KeyError: {e}")

The server logs show that pipeline is done.
htrflow-htrflow-1  | Function 'transcribe' executed in 0.2464s
2it [00:08,  4.16s/it]
htrflow-htrflow-1  | Function 'running_htr_pipeline' executed in 10.3494s

gradio_client shows KeyError: 'log'
StatusUpdate(code=<Status.FINISHED: 'FINISHED'>, rank=0, queue_size=None, eta=None, success=False, time=datetime.datetime(2023, 10, 31, 19, 36, 43, 703883), progress_data=None)
<bound method Future.exception of <Job at 0x106d49a50 state=finished raised KeyError>>
KeyError: 'log'

Hi, I updated some of the code. Can you make a git pull and see if the issues still there?

I tried with the latest commit and there were some issues.
1. API name change api_name="/run_htr_pipeline",
2. Docker cuda error

I modified the utils.py so I use my own hugginface repo.
I build the docker image.
I get error RuntimeError: nms_impl: implementation for device cuda:0 not found.

3. Running python app.py (outside docker) is not downloading models

python3 -m venv .venv
source .venv/bin/activate
pip install -r requirements.txt
python app.py
FileNotFoundError: ./models/RmtDet_lines/epoch_12.pth can not be found.

The docker image is downloading the models so I copied them to the correct directory and after that the api calls to the new endpoint worked with gradio_client.


Fix #8646 for faster find of all files

After sleeping on it, I realized there was a simpler (less code) and slightly faster version of the previous https://github.com/rubocop-hq/rubocop/pull/8806.
By recursively getting all directories and then at each directory level testing Rubocop Exclude on directories.  Once directories are found at all levels, we search for files.
In addition, I replaced many of the base_dir string concatenations with the safer File#join.
Benchmarks on a large project removes an additional 500+ milliseconds.
The following flamegraphs illustrate the percentage of processing TargetFinder#target_files_in_dir took in using the command bundle exec rubocop -L to list rubocop files.
Original Flamegraph

Changes from https://github.com/rubocop-hq/rubocop/pull/8806

Changes from this MR

Note: I didn't add an entry to the Changelog as a previous one was already added.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Nicely done! I think it's the first time I see someone sharing flamegraphs in a PR which is extra cool! I always think of @miharekar when I see a flamegraph (a friend of mine, who's a big proponent of the concept).


test: add mock e2e tests

:tada: This PR is included in version 2.0.0-rc.2 :tada:
The release is available on:

v2.0.0-rc.2
GitHub release

Your semantic-release bot :package::rocket:


Bump version to 7.0.0

Includes:

#105 Better code snippets
#106 Tweak spacing on browse list
#107 Refactor summary pattern

MAJOR change because it will cause problems for anyone (probably no-one) who was using the template for the summary page.
Full changes: https://github.com/alphagov/digitalmarketplace-frontend-toolkit/compare/v6.0.2...0f81405

:steam_locomotive:


Fix tkn pac resolve

I can't figure out why the apiVersion and Kind is not getting populated
on CLI while working when generated from the controller.
let's add it manually which seems to generate proper PipelineRun
We do have e2e tests covering all of this code path but it seems to
occur only from a binary and not when launched from go code, so i guess
we can't do much about it.
Fixes #1178
Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>

objects fetched from api server doesn't have ApiVersion and Kind
kubectl used to populate that.. I think!

@sm43 yeah that's what vincent told me, but how did it work previously? i cant' figure out why

/retest


fix(#77): Change Announcement Title and abstractText to string in Hib…

…ernate to support Oracle.
Resolves #77.

Tested and working as expected with Oracle.


Add Hidden-surface determination

A large contributor to the slower performance on more polygons is pythons for loop's sluggishness and the more polygons there are to draw, the more sluggish it gets.
To reduce the amount of polygons that need to be drawn perhaps some Hidden-surface determination would be beneficial, thus increasing performance and allowing more real-time rendering.
A Wikipedia article on this topic

Occlusion culling and Back-face culling could be 2 pretty decent ones to consider.

Note: Back-face culling is already implemented at Main.py, line: 120 'if nz <=0:' checks the length of the normal in the Z axis for the given triangle, if the value is negative it indicates that it is facing towards the camera, if it is positive that indicates its normal on the Z axis is running in the same direction as the camera, and hence is facing away from the camera. The nz value is set to -1 at Main.py, line: 116 'nz = -1', this is for the 'wiremesh' feature which displays a transparent surface and requires Back-face culling to be turned off.


Poketracker miss placing legendary pokemon bosses

Describe the bug
As title says, when a legendary pokemon spawns as a boss it shows up in legend spawn list instead of boss spawn list. Happened on Orion but I imagine its like this on all servers.
To Reproduce
Have a wild Legendary pokemon boss spawn on you
check /poketracker
see error

^ Ultimate Type Null boss

Should be fixed now, thanks for the report! Closing


WIP - Add support for IMAP ID command - RFC 2971

:+1:
A couple of notes:

We already have too many settings. Let's not make this another one. Always sending the ID command should be fine.
I feel the amount of information sent is a bit much. I'd limit it to 'name' and 'version'. That information should be enough to find our contact details using a search engine. The name of the app should be "K-9 Mail".
We should avoid hardcoding app-specific stuff in the library project. A user of k9mail-library should be able to pass in the values that are used as arguments to the ID command.
Parsing of the ID response could use stricter format checking. Following the *Response class pattern should make it easy to add tests for that.
Please try to keep PRs focused. Adding unrelated tests could be a separate pull request.

Side note:
I don't like the grouping of tests via comment. If you feel such a grouping is necessary please create a separate test class per group.

The RFC specifically mentions privacy considerations. That's the main justification for the setting. We've always been a privacy focused app so it seemed reasonable. We already have a user agent privacy setting flag for example.
I didn't actually add unrelated tests, I just reordered them so they were listed in a logical order. Probably should have been a separate commit though. I'm not a fan of comments either - it generally means your base class is doing too much. We could have a ConnectionOpener class that solved this.
I'll probably wait until rhari's IMAP rework lands then tidy up and rebase this.

I find the usefulness of this feature questionable, in comparison to the required extra roundtrip. On top of that there's the privacy concerns, and a setting for this is just confusing to everyone who has never read an RFC (which is everyone).

I prototyped the connectionopener strategy idea: https://github.com/philipwhiuk/k-9/commit/49851ab24e10bc730209e02f16aa4fdca2fa7249

I find the usefulness of this feature questionable, in comparison to the required extra roundtrip.

It makes K-9 a responsible well behaved email client.

And a setting for this is just confusing to everyone who has never read an RFC (which is everyone)

We currently have a "User-Agent" privacy setting which equally confusing and aimed at the same privacy question. (One option is to use the same privacy setting for both with some slightly new text).

I didn't look closely at the "connectionopener strategy" prototype. There's a lot of changed lines. What I meant was handing a ClientIdentification data structure that holds information like client name and version to the library. The library would then use this data structure to fill in the arguments to the ID command.
Anyway, I'm with @Valodim regarding usefulness vs. cost. Maybe we should postpone this until we support sending multiple commands at once. That way we don't add an additional roundtrip.
And maybe by then we've reorganized the settings UI so we can add a setting for this to the advanced settings screen that is hidden by default.

I would be fine with this if it didn't take an extra roundtrip, and merging with the other user-agent setting sounds reasonable.
With the extra roundtrip I'll vote against this one, since I consider the benefit marginal at best. I would be very surprised if we ever got a bug report from some mail server admin based on this id, it's far more likely that users notice something being off and report bugs, except maybe for bugs that show no actual symptoms.

The benefits of using the ID command seem small.


Hide edit and delete icon conditionally

There are onItemEditing and onItemDeleting to block edit or delete but is there a way to hide edit and/or delete icon by special condition only for same row?

It is possible along these lines :
`         {type: "control",align:"center",
             itemTemplate: function(value, item) {
                var $result = $([]);

                    $result = $result.add(this._createEditButton(item));

                if( somecondition) {
                    $result = $result.add(this._createDeleteButton(item));

                    this.css = "deletenandericoontje";
                   // this._grid.editing = false; works

                }

                return $result;
            },

`
Hopefully clear enough (conditional delete button, but you can make it an edit button if you like ...)

Hi,
you can override the _createDeleteButton as below
I test it and works fine
jsGrid.setDefaults("control", {
        _createDeleteButton: function (item) {
            if (item.Name === 'Otto Clay') return;

             return this._createGridButton(this.deleteButtonClass, this.deleteButtonTooltip, function (grid, e) {
                grid.deleteItem(item);
                e.stopPropagation();
            });
        }
    });

you can test on codepen, ( just add the code and the end of the script )

https://codepen.io/regateiro/pen/wrgNzM?editors=1010

https://codepen.io/BRA-TN/pen/wbpLzz?editors=1010


error downloading .flv from tvcast.naver.com.

Hello,
Here is a video url
http://tvcast.naver.com/v/444529
When I try to download the vid, the format is in flv and it threw an error saying that
ERROR: RTMP download detected but "rtmpdump" could not be run. Please install it.
So I simply tried installing rtmpdump with homebrew and now it threw another error...
ERROR: rtmpdump exited with code 1
I'm stuck here and if someone could help me, it would be great.
Thanks,

Duplicate of #6744.


failed transaction

Hello;
I made a transaction earlier today from my external nano s wallet to cryprto.com acct but the account-wallet there is not able as of yet to take XLM! Wish there was a pop up note preventing a transfer...I have the transaction ID, time etc...I sent -<EMAIL_ADDRESS>who is listed at bottom of Stellar Expert transaction page a note earlier.
Please advise...
Rodd
<EMAIL_ADDRESS>

Hello?

Answered via email


[DOCFIX]Change chinese doc

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20667/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.server.ft.ZookeeperFailureIntegrationTest.zkFailure
Test FAILed.


includes match not working

This should find many results in our monorepo:
`$client.$_($_)` as $call where {
  $client <: imported_from($source),
  $source <: includes "client"
}

I'm getting 15 matches, how many are you getting?

Looks like it's working now, I got 0 before for some reason.


Fix typo in config-json man page

In the NAME section: "confg.json" -> "config.json"

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-man-typo" git@github.com:tomxtobin/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Nice catch, thanks!
LGTM


Create emoticon.json : add emoticon

add emoticon.json

Thank you for taking the time to contribute! This is sincerely appreciated. 😇
(Powered by GitMate.io)


Incomplete Image Nvidia/PyTorch

Expected Behavior
A fully working image (just as the original)

Actual Behavior
The size reduced nicely, but it's not working.
-> docker run nvcr.io/nvidia/pytorch.slim
/etc/shinit_v2: line 42: dpkg: command not found
/opt/nvidia/nvidia_entrypoint.sh: line 30: readlink: command not found
/opt/nvidia/nvidia_entrypoint.sh: line 30: dirname: command not found

/etc/shinit_v2: line 42: dpkg: command not found

Steps to Reproduce the Problem

docker pull nvcr.io/nvidia/pytorch:21.10-py3
docker-slim build --target nvcr.io/nvidia/pytorch:21.10-py3 --http-probe-off
docker run nvcr.io/nvidia/pytorch.slim

Specifications

Version: 1.37.5
Platform: Linux (Ubuntu)

Similar thing happened in my case with a self built Tensorflow image with CUDA / CuDNN + RAPIDS
The image is really big, so it should be a perfect candidate for trimming down.
1st run - docker-slim build --target myimage --http-probe-off
cmd=build info=results size.optimized='3.7 MB' status='MINIFIED' by='5337.08X' size.original='20 GB'
The build is useless, as practically everything is stripped out
2nd run - docker-slim build --target myimage --include-path /usr --http-probe-off
cmd=build info=results status='MINIFIED' by='1.15X' size.original='20 GB' size.optimized='17 GB'
Asked the build specifically to let the libraries inside of the container. But even this smaller trimming broke the otherwise
working container.

$ docker run --rm -it myimage.slim bash
bash-4.2# python3
Python 3.8.9 (default, Apr  7 2022, 12:44:12)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-44)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import cuml
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/cuml-22.4.0-py3.8-linux-x86_64.egg/cuml/__init__.py", line 17, in <module>
    from cuml.common.base import Base
  File "/usr/local/lib/python3.8/site-packages/cuml-22.4.0-py3.8-linux-x86_64.egg/cuml/common/__init__.py", line 17, in <module>
    from cuml.common.array import CumlArray
  File "/usr/local/lib/python3.8/site-packages/cuml-22.4.0-py3.8-linux-x86_64.egg/cuml/common/array.py", line 25, in <module>
    from cudf import DataFrame
  File "/usr/local/lib/python3.8/site-packages/cudf-22.4.0-py3.8-linux-x86_64.egg/cudf/__init__.py", line 5, in <module>
    validate_setup()
  File "/usr/local/lib/python3.8/site-packages/cudf-22.4.0-py3.8-linux-x86_64.egg/cudf/utils/gpu_utils.py", line 89, in validate_setup
    cuda_runtime_version = runtimeGetVersion()
  File "/usr/local/lib/python3.8/site-packages/rmm/_cuda/gpu.py", line 87, in runtimeGetVersion
    major, minor = numba.cuda.runtime.get_version()
  File "/usr/local/lib/python3.8/site-packages/numba/cuda/cudadrv/runtime.py", line 111, in get_version
    self.cudaRuntimeGetVersion(ctypes.byref(rtver))
  File "/usr/local/lib/python3.8/site-packages/numba/cuda/cudadrv/runtime.py", line 65, in __getattr__
    self._initialize()
  File "/usr/local/lib/python3.8/site-packages/numba/cuda/cudadrv/runtime.py", line 51, in _initialize
    self.lib = open_cudalib('cudart')
  File "/usr/local/lib/python3.8/site-packages/numba/cuda/cudadrv/libs.py", line 59, in open_cudalib
    path = get_cudalib(lib)
  File "/usr/local/lib/python3.8/site-packages/numba/cuda/cudadrv/libs.py", line 51, in get_cudalib
    libdir = get_cuda_paths()['cudalib_dir'].info
  File "/usr/local/lib/python3.8/site-packages/numba/cuda/cuda_paths.py", line 158, in get_cuda_paths
    'nvvm': _get_nvvm_path(),
  File "/usr/local/lib/python3.8/site-packages/numba/cuda/cuda_paths.py", line 136, in _get_nvvm_path
    candidates = find_lib('nvvm', path)
  File "/usr/local/lib/python3.8/site-packages/numba/misc/findlib.py", line 44, in find_lib
    return find_file(regex, libdir)
  File "/usr/local/lib/python3.8/site-packages/numba/misc/findlib.py", line 56, in find_file
    entries = os.listdir(ldir)
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/cuda/nvvm/lib64'

Strangely it complains about missing files under the /usr path, which was explicitly included.

Hello @kcq are there any updates?


Fatal Compile Error: Cannot use 'Object' as class name as it is reserved

I was implementing this library in a project in which I am using the symfony framework. I wanted to return the data of an object in binary and I got this error:
[2018-12-20 23:19:18] php.CRITICAL: Fatal Compile Error: Cannot use 'Object' as class name as it is reserved {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalErrorException(code: 0): Compile Error: Cannot use 'Object' as class name as it is reserved at /home/user/my-api/vendor/ipfs/php-client/src/Api/Object.php:24)"} []
[2018-12-20 23:19:18] request.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalErrorException: "Compile Error: Cannot use 'Object' as class name as it is reserved" at /home/user/my-api/vendor/ipfs/php-client/src/Api/Object.php line 24 {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalErrorException(code: 0): Compile Error: Cannot use 'Object' as class name as it is reserved at /home/user/my-api/vendor/ipfs/php-client/src/Api/Object.php:24)"} []

This is the code I am using:
$hash = 'QmNR9QMUHn9ocZLqegyjfrsQkL928a74N14JBxZTCGWN6z';
$ipfs = $this->getIPFSClient();
$data = $ipfs->execute((new \IPFS\Api\Object)->stat($hash));

These are the versions I am using:
symfony: 3.3.*
ipfs/php-client: ^1.3
php: 7.2

Hey, thanks for this Bug Report. Object is indeed a reserved Word. We should implement a Special handling for those!

@ander7agar should be fixed with 1.4.0 release

sorry for that! 1.4.1 fixes this correctly


Add release_branch_regex version argument

thanks for catching that!

released as 0.2.12. Thanks!


What would it take to implement a client?

Hello!
I'd be willing to give a go at implementing the ClientApp.
Would you happen to have anything in mind or some pointers that may help get started?
Thanks!

There is no client because nobody is ready to pay for a client to exist. And therefore no client should exist. There is no incentive for me to take on the task of vetting your work, supporting it and adding the eventual heap of extra features people will require. In fact, there is a strong incentive for me to actively postpone a client as it remains a payable project.

How much are we talking?
How much if it includes a simple reverse proxy (http+ws) example?
What time frame are we talking?


trouble with bcf_ip2g

Hi
Since I needed the exact same functionality as that of bcf_ip2g in my Java app, I thought I would translate your implementation to Java. However when I then started testing it I found myself in an infinite loop in some cases like bcf_ip2g(3,3) bcf_ip2g(3,4) or bcf_ip2g(4,4).
I first thought something was wrong in my code translation but after further investigation, I managed to get your program to launch this method with the above parameters, and never got a reply. So unless I am completely mistaken (which could be the case!) there might be a little bug somewhere. Would you mind having a quick look?
Thanks very much,
G.

Thanks for reporting this bug, the problem was with the if statement for detecting an "overflow"
The fix is simply
if (i>=leftover_genotype_index) to
if (i>=leftover_genotype_index || allele_index==max_allele_index)
in the for loop iterating over the alleles for a ploidy position.
The formulae and derivations for these type of computations can be found at
http://genome.sph.umich.edu/wiki/Relationship_between_Ploidy,_Alleles_and_Genotypes

Thanks a lot for the fix. May I suggest to also fix bcf_ap2g by replacing
if (no_ploidy==1)
with something like
if (no_ploidy==1 || no_allele<=1)
?
This would return the correct value (0) for bcf_ap2g(0, n) and improve performance for bcf_ap2g(1, n)

done, thanks.


Improve the FIO benchmarks

Currently there is a fio benchmark in PKB, it mostly works but needs some improvement. The core testing logic is driven by an FIO job file which is specified by the user who runs this benchmark, that's quite flexible and good. What's missing are:

The ability to test directly against a device in addition to testing against a file (that is, test against /dev/sdb). Basically we need to be able to handle the case where the flag fio_benchmark_file points to a device rather than a file, specifically, the prepare and cleanup logic needs some change to handle this.

The ability to provision (write) the entire test file, or the entire test device in the prepare step as instructed by the user. This is for some read or random read test cases, to run those properly, the device or file has to be filled first.

@voellm FYI, this is the fio improvements we talked about, which is necessary to enable full automation for any fio/raw device benchmarking.

@yuyantingzero Would you be able to work on this soon? I've talked to Tony about this.

I can start on this next week.

pull request #236


Kotlin LSP module does not work because kotlin lsp server download link is no longer valid

What did you expect to happen?
When I open a kotlin file it should download and install the kotlin language server.
What actually happened?
When I open a kotlin file and select to download the kotlin language server, it does
Describe your attempts to resolve the issue
When I opened a kotlin file, doom prompted me to install the kotlin language server, but it failed. The reason it failed can be seen in messages. It tries to download the language server, but the link it tries is unavailable, just try git cloning it:
https://github.com/fwcd/kotlin-language-server/releases/download/latest/server.zip
It should be trying to get the server from here somehow:
https://github.com/fwcd/kotlin-language-server/releases/
I tried to download the latest zip file server release on the website, but in I put it in the location that doom wanted it downloaded to
/home/diegocaples/.emacs.d/.local/etc/lsp/kotlin/kotlin-language-server.zip
and tried to start the lsp install again, but it just overwrote my zip file with an empty zip file. I also extracted the zip file, but it didn't work, and still prompted me to install the kotlin lsp server.
Steps to reproduce

add lsp to init.el
add (kotlin +lsp) to init.el
open a kotlin file; you will be prompted to install kotlin server
the install will fail

System Information
https://pastebin.com/QrDVWXp9

This should instead be reported to lsp-mode

This is indeed an upstream issue. Please report it to lsp-mode. I'll leave this open until it's addressed and we've bumped the package.

https://github.com/emacs-lsp/lsp-mode/pull/3315

This issue should now be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!


Dev Agreement section

Add top-level link to Developer Agreement per request from Legal.

Hi @kfansler  -
Adding this as part of https://github.com/smartsheet/smartsheet-java-sdk/pull/74
Closing this out, thank you !


Fix mypy errors attributed to pytorch_lightning.core.saving

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.core.saving for issue #13445
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Hi @JustinGoheen, we recently started testing mypy with PyTorch 1.12 and it seems it produced one error on this PR. Can you please take a look? Thanks!

@awaelchli @carmocca @borda I made a few changes to standardize annotations for map_location across all files that use load_checkpoint. The new annotation uses Carlos' recent change in pl.utilities.cloud_io and adds Callable into the annotation based on doc strings for checkpoint_plugin.CheckpointIO.load_checkpoint describing map_location

@Borda I believe this was incorrectly milestoned

@Borda I believe this was incorrectly milestoned

well yes, I think it can be any release, just was thinking that all this typing included would simplify eventual future cherry-picking as it lowers the diff between master and releases branch

There's some risk involved in typing PRs (example) so we want to minimize it for bug-fix releases.


Accounts page with different components version

@davidyuk,
I made minimal change to your code to integrate https://github.com/aeternity/aepp-components/tree/update-identities into your PR (#90 )

It looks broken when I choose the second account in inactive accounts list.

@davidyuk,
I could not reproduce the bug in Firefox or Chrome. Which browser were you using?

I could not reproduce the bug in Firefox or Chrome. Which browser were you using?

This bug are maked in #90, it is fixed in f242f11af671dea2011bb5c62549334601d68ce8

It should not be closed

Replaced by https://github.com/aeternity/aepp-identity/pull/103


Add 5.12.1 version of Apache ActiveMQ in addition to 5.8.0

The Apache ActiveMQ version is currently at 5.8.0, the most recent stable version is 5.12.1.
I looked at the tomcat .nix files and used that as a template to add another entry for activemq 5.12.1, without overwriting the 5.8.0 version.
If there is no reason to keep the old 5.8.0 version around an alternative would be to just bump that one.

Okay I finally sorted out the different url schemes ;)


Negative numbers and zero is not required in filter for Id.

Framework Version: 0.1.4

This issue had been fixed in the commit https://github.com/prashant-webkul/bagisto/commit/cd6d6c89a87da07e5abcb32ccec940cca51fe0ca and changes will actually reflect in next update of the release that is going to happen next week.


Add way to check SIM card balance

From @nzola

(1) It is difficult to know from the Lokole device when the data credit is finished.
(2) When one buys data credit for the SIM inside the Lokole, one has to use USSD code on the phone to activate the data. Otherwise it would not work.

This could be done via gammu (code example).
Implementation notes:

To the admin page settings.html, add an element that displays the current SIM card balance and a form that enables the admin to submit a SIM card top-up code.
To actions.py add two new commands that back the elements in the settings page: one to check SIM card balance and one to top up the SIM card.
To views.py, add the glue to connect the admin page with the actions.

Suggested approach:
a) Insert a pay-as-you-go SIM card into a USB modem like Huawei MS2131i-8 and install gammu.
b) Manually experiment on the CLI with gammu commands to retrieve the SIM card balance and top up the balance.
c) Add code to actions.py that wraps the gammu CLI commands as described in 2) above. The code for StartInternetConnection can be used as a reference of an existing action that calls out to CLI commands.
d) Run a Python interpreter and experiment with the actions to ensure that the wrapping code works.
e) If the new action takes more than 1 second to run we'll have to run it outside of the http request/response cycle, so wrap it in tasks.py.
f) Follow steps 1) and 3) above to wire the action into the Lokole admin page.

Vodacom details from @nzola:
To top up data: *1141*creditamount*phonenumber#yes
To check data credit: *100*2#yes or *100*1#yes
To check SIM card phone number: *89#yes
@sbathgate I would recommend that the UI is flexible enough that the user can edit any of these strings if their SIM provider requires a different setup.

Orange details:
To check data credit: 12412#yes
Airtel details:
To check data credit: 5653#yes
To check SIM card phone number: *502#yes
Afritel details:
To check data credit and SIM card phone number: *1000#yes

As discussed I have run into some difficulties with this issue. I have extracted a series of fault logs attached below. The short form is: An error is reported every time the "gammu getussd" command is sent via the Huawei MS2131i-8. Testing was successful with the Huawei e303 and the corresponding logs are attached in gist links below for comparison. I am unsure if this is strictly an incompatibility with the Huawei MS2131i-8 and Gammu.
Research has, unfortunately, shed little light on this error. After attempting to resolve this with just Gammu, I tried to work around it through the python-gammu package and utilizing Picocom to manually send the appropriate AT+ commands. Both resulted in similar faults. I can extract copies of these faults if that will assist with further troubleshooting.
Ultimately, I believe the fault lies with some form of encoding issue. On line 393 of the Huawei e303 Gammu Log Errors file, you can see the USSD code being successfully sent. It should read "AT+CUSD=1,"AADBEDA68A8D00",15" as seen here. The text in bold represents the "*777*1#" USSD code that my sim card provider uses to retrieve the account balance.
Review of line 372 of the
Huawei MS2131i-8 Gammu Log Errors indicates the code sent was "AT+CUSD=1,"002A003700370037002A00310023",15". The mixture of characters in bold represents the USSD code the USB modem attempted to send.
As mentioned above, I have attempted to manually send the correct ("AADBEDA68A8D00") AT+CUSD code by making a serial connection with the USB modem via Picocom which resulted in a similar error to Gammu with the MS2131i-8. I found M2MSupport.net helpful to better understand the AT+ command requirements.
Huawei e303:

Huawei e303 Gammu Log Errors
Huawei e303 Gammu Log TextAll
Huawei e303 Terminal Output

Huawei MS2131i-8:

Huawei MS2131i-8 Gammu Log Errors
Huawei MS2131i-8 Gammu Log TextAll
Huawei MS2131i-8 Terminal Output


[staging & production] Language change for added files in logs

Steps

Go to a project/component on staging or production
Go to Settings > Select Add-ons
Enable and configure an add-on for the project/component
Go to the Files tab
Add a file to the project/component
Return to the project/component overview page
Look at the logs for the file and add-on additions

Expected
I expect that since both logs start with User added, that the preposition for adding would be the same.
Actual
The preposition for adding an add-on is "to", whereas the preposition for adding a file is "in"
Add-on:

File:

As per discussion with @brianjgeiger and @sloria, the preposition should be "to" in both cases.

I'm looking into this.

@leb2dg this is already fixed in https://github.com/CenterForOpenScience/osf.io/pull/2772

@chennan47 Great! Does #2772 fix the preposition issue as well? The difference is still on production (see below screen shot).

@leb2dg that pr fixes this problem but just haven't been merged yet.

Nice dialog @leb2dg and @nanchen47 -- appreciate it.

The fix has been deployed.


Reduce friction encountered when adding Flutter to existing apps

Flutter's templates, tooling, and runtime are currently primarily optimized for the use case of creating a new mobile application from scratch. However, several developers have expressed an interest in making it easier to add one or more Flutter "screens" to existing Android and iOS apps.
The present bug tracks reduction of general friction developers encounter when trying to accomplish this integration of Flutter into existing apps.
The detailed work for this effort is tracked in a number of more detailed issues:
https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A"a%3A+existing-apps"
The initial documentation for the preview support is available on our Wiki:
https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps

Hello,
Any news about the documentation explaining how to embed flutter views in native apps ?
Thank you very much.

Sorry, no, not yet

My scenario is a variation of the above, aimed at enterprise apps that use .NET (Core): I would like to evaluate whether Flutter can be combined with 'classic' Xamarin.iOS and Xamarin.Android.
Flutter would be used for shared UI + Navigation; Xamarin for logic, models and services. This could be a more productive alternative to Xamarin Forms.
This should be possible; Flutter can be embedded as a native iOS/Android component and Xamarin can interop with such components through bindings.
Would the Flutter team consider this use case relevant?
If so, are there contact options to get info on this until the documents are here?
In case anyone would like to give feedback (much appreciated!), this is my idea:
Create a single UI component in Flutter, containing all screens, navigation and design data for an app. This component is developed and tested with high productivity in standard Flutter toolchain; and then embedded in the Xamarin apps. The complete app build & publishing would be with Xamarin toolchain.

@VincentH-Net Please file a extra ticket for Xamarin interop. This issue is about integrating Flutter in an native iOS/Android app.
If you want to interact with your C# core, better checkout this issue.

@passsy thx, I created a new issue #15200
I would need more than interacting with C# core logic; e.g. access native device services, .NET Core NuGet libraries. Basically only the views would be Flutter.

Hello @mit-mit , @passsy  ,
I would like to know how to embed Flutter into a native Android project. Do I have to create a Flutter project within the Android project folder and then bind everything ? Or do I have to create a Flutter project, change the android folder with my Android project folder and then bind everything ?
Thank you

goes as well for adding flutter lib project to existing flutter app

Hello @eseidelGoogle,
Is it possible to create multiple Flutter views or we are limited to only one ?
Thank you

#15556 I hava an app which most pages written by native code. Now I want to integrate flutter, in order to write new pages.  I have read flutter doc, for example:
Android
public class MainActivity extends FlutterActivity {
  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    GeneratedPluginRegistrant.registerWith(this);
  }
}

this activity run with main.dart automatically.
But if I have mainA.dart and mainB.dart, how to assign mainA.dart to AActivity, assign mainB.dart to BActivity. Or how to specify which dart file to load?
many thanks.

I think you should in your native side keep only one FlutterActivity and send for example a string that correspond to the name of the view that you want to display to your main.dart using the channel.
In the flutter side I think you should implement Routes first and then get the string and use a switch to push the view that corresponds to the string.

Can you provide a plug-in on android studio, to let us simply integration flutter into exist android project. @mit-mit

Still there is no explanation how to integrate in an existing iOS or Android project...
Do you need a new Flutter project and move existing iOS project swift files into the iOS folder and build from Flutter?
We have a big app and want to start with Flutter in that existing app or the best solution is to start over and create a brand new version 100% Flutter project

I have a similar case as @FredvanRijswijk.
Is there a possibility to specify somewhere (e.g. pubspec.yaml) the paths to iOS and Android projects?
Currently, the alternative is (at least for Android) to move all the files to android subfolder and rename the project - that creates inconvenience with git.

We are currently experimenting with approaches that would invert that dependency, so that your existing project would include the Flutter project in some form (say, as an Android Activity). We're writing up our experiments and findings as we go along. I'll provide a link here once we have a draft wiki page.

@mravn-google Nice

https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps

/cc @floitschG

Thanks @mravn-google. I've already tried to integrate your solution (with small modifications, had to add FlutterMain.startInitialization) into my legacy Android app, and it works nicely.

Great to hear, thanks for sharing. Credit is due to @floitschG. We'll update the wiki page with the initialization.

Do you happen to have similar findings how to integrate Flutter in an iOS app?

@tomaszpolanski We are working on it.

∞  to this!

WeChatSight188.mp4
https://github.com/flutter/flutter/files/1892512/flutter_image_test.zip（This is a demo ，It needs to run in ios real machine to reproduce this problem）
I introduced the flutter framework in the ios native app and started the new FlutterViewController the second time. The image was displayed incorrectly in Flutter ，
https://files.gitter.im/flutter/flutter/yR2i/1523967103260.jpg（
This is a screenshot showing that the picture is incorrect）
I want to introduce flutter in the native app, but this problem can't let me do it，Because in ios, multiple flutterViewControllers cannot be started, even one flutterViewController cannot be started multiple times

WeChatSight188.mp4（This is a demo video）
https://github.com/flutter/flutter/files/1892512/flutter_image_test.zip（This is a demo ，It needs to run in ios real machine to reproduce this problem）
I introduced the flutter framework in the ios native app and started the new FlutterViewController the second time. The image was displayed incorrectly in Flutter ，
https://files.gitter.im/flutter/flutter/yR2i/1523967103260.jpg
（This is a screenshot showing that the picture is incorrect）
I want to introduce flutter in the native app, but this problem can't let me do it，Because in ios, multiple flutterViewControllers cannot be started, even one flutterViewController cannot be started multiple times

WeChatSight188.mp4（This is a demo video）
https://github.com/flutter/flutter/files/1892512/flutter_image_test.zip（This is a demo ，It needs to run in ios real machine to reproduce this problem）
I introduced the flutter framework in the ios native app and started the new FlutterViewController the second time. The image was displayed incorrectly in Flutter ，
https://files.gitter.im/flutter/flutter/yR2i/1523967103260.jpg
(This is a screenshot showing that the picture is incorrect)
I want to introduce flutter in the native app, but this problem can't let me do it，Because in ios, multiple flutterViewControllers cannot be started, even one flutterViewController cannot be started multiple times

WeChatSight188.mp4（This is a demo video）
https://github.com/flutter/flutter/files/1892512/flutter_image_test.zip（This is a demo ，It needs to run in ios real machine to reproduce this problem）
I introduced the flutter framework in the ios native app and started the new FlutterViewController the second time. The image was displayed incorrectly in Flutter ，
https://files.gitter.im/flutter/flutter/yR2i/1523967103260.jpg (This is a screenshot showing that the picture is incorrect)
I want to introduce flutter in the native app, but this problem can't let me do it，Because in ios, multiple flutterViewControllers cannot be started, even one flutterViewController cannot be started multiple times

https://files.gitter.im/flutter/flutter/Fc4R/WeChatSight188.mp4（This is a demo video）
https://github.com/flutter/flutter/files/1892512/flutter_image_test.zip（This is a demo ，It needs to run in ios real machine to reproduce this problem）
I added flutter to an existing native application and started the new FlutterViewController the second time. The image was displayed incorrectly in Flutter ，
https://files.gitter.im/flutter/flutter/yR2i/1523967103260.jpg (This is a screenshot showing that the picture is incorrect)
I want to add flutter to an existing native application , but this problem can't let me do it，Because in ios, multiple flutterViewControllers cannot be started, even one flutterViewController cannot be started multiple times，But there is no problem in android

https://files.gitter.im/flutter/flutter/Fc4R/WeChatSight188.mp4
（This is a demo video）
https://github.com/flutter/flutter/files/1892512/flutter_image_test.zip
（This is a demo ，It needs to run in ios real machine to reproduce this problem）
https://files.gitter.im/flutter/flutter/yR2i/1523967103260.jpg
(This is a screenshot showing that the picture is incorrect)
I added flutter to an existing native application and started the new FlutterViewController the second time. The image was displayed incorrectly in Flutter ，
I want to add flutter to an existing native application , but this problem can't let me do it，Because in ios, multiple flutterViewControllers cannot be started, even one flutterViewController cannot be started multiple times，But there is no problem in android
How to solve this problem?

@bobzhou80 , I'm having the same issue, see https://github.com/flutter/flutter/issues/16840.

@alexwhiteside1
No solution is found now, I expect developers can solve this problem as soon as possible

@mravn-google Thank you guys for providing this update. This, in my opinion, is a very necessary feature. Many of us developers work for large businesses that would be better suited for a cross-platform technology stack like Flutter. Unfortunately, the only way to convince business execs to adopt this is a seamless integration between Flutter and existing native app code. I really hope this is a feature that is delivered soon because it is instrumental to its success in many non-IT markets.

hi, i tried to let my android project depends on my flutter android module, and i did step by step as [Add Flutter to existing apps]{https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps}
but after that and i run my application it crashes with this error:
java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/-cghZarZN7mfe_qjTTemg1Q==/base.apk", zip file "/data/user/0//files/hydra/flutter/unspecified/bundle.zip"],nativeLibraryDirectories=[/data/app/-cghZarZN7mfe_qjTTemg1Q==/lib/arm, /data/app/-cghZarZN7mfe_qjTTemg1Q==/base.apk!/lib/armeabi, /system/lib, /vendor/lib]]] couldn't find "libflutter.so"
look forward to get help...

@mravn-google
a litter problem, then i enable the webview debug,like "WebView.setWebContentsDebuggingEnabled(true);", then app whill crash
### ### ### ### ### ### ### ### ### ### ### ### ###

06-13 16:44:24.281 15493-15746/com.ztgame.dudu E/chromium: ### WebView Version Developer Build (code 1)
06-13 16:44:24.281 15493-15746/com.ztgame.dudu A/libc: Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 15746 (1.ui)
06-13 16:44:24.282 15760-15760/? I/AEE/AED: handle_request(0)
check process 15493 name:com.xx.xx
tid 15746 abort msg address is:0x00000000, si_code is:1 (request from 15493:10877)
BOOM: pid=15493 uid=10877 gid=10877 tid=15746
06-13 16:44:24.283 15760-15760/? I/AEE/AED: [OnPurpose Redunant in void preset_info(aed_report_record*, int, int)] pid: 15493, tid: 15746, name: 1.ui  >>> com.xx.xx <<<
06-13 16:44:24.341 15760-15760/? I/AEE/AED: pid: 15493, tid: 15746, name: 1.ui  >>> com.xx.xx <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
06-13 16:44:24.463 15760-15760/? I/AEE/AED: backtrace:
#00 pc 0030cce4  /data/app/com.xx..xx/lib/arm/libflutter.so
#01 pc 0030b6d3  /data/app/com.xx.xx-1/lib/arm/libflutter.so
#02 pc 0030fae5  /data/app/com.xx.xx-1/lib/arm/libflutter.so
#03 pc 003104e5  /data/app/com.xx.xx-1/lib/arm/libflutter.so
#04 pc 000a0325  /data/app/com.xx.xx-1/lib/arm/libflutter.so
#05 pc 0009f1ed  /data/app/com.xx.xx-1/lib/arm/libflutter.so
#06 pc 0009f1a7  /data/app/com.xx.xx-1/lib/arm/libflutter.so
#07 pc 0043ad01  /data/app/com.xx.xx-1/lib/arm/libflutter.so
#08 pc 00000714

modify my flutter android module as this doc Add-Flutter-to-existing-apps but when i run my android base project ，in some mobile the flutter page is opened normal，but some mobiles flutter page is white and the back physical button is invalid，look forward to getting help~
06-15 16:03:47.671 3565-3565/com.lostoy.android.androidmatrix I/hwaps: JNI_OnLoad
06-15 16:03:47.840 3565-3894/com.lostoy.android.androidmatrix W/libEGL: load: so=libEGL_vr.so
dlopen failed: library "libEGL_vr.so" not found
load: so=libEGL_vr.so
dlopen failed: library "libEGL_vr.so" not found
06-15 16:03:47.841 3565-3894/com.lostoy.android.androidmatrix W/libEGL: load: so=libEGL_vr.so
dlopen failed: library "libEGL_vr.so" not found
06-15 16:03:47.842 3565-3894/com.lostoy.android.androidmatrix W/libEGL: load: so=libEGL_vr.so
dlopen failed: library "libEGL_vr.so" not found
06-15 16:03:47.867 3565-3565/com.lostoy.android.androidmatrix I/FlutterActivityDelegate: onResume app wasn't a FlutterApplication!!
06-15 16:03:47.898 3565-3565/com.lostoy.android.androidmatrix W/libEGL: load: so=libEGL_vr.so
dlopen failed: library "libEGL_vr.so" not found
load: so=libEGL_vr.so
dlopen failed: library "libEGL_vr.so" not found
load: so=libEGL_vr.so
dlopen failed: library "libEGL_vr.so" not found
load: so=libEGL_vr.so
dlopen failed: library "libEGL_vr.so" not found
06-15 16:03:47.984 3565-3904/com.lostoy.android.androidmatrix I/flutter: Observatory listening on http://<IP_ADDRESS>:56473/

Hello,
I followed @mravn-google guide to Add Flutter to existing app and I was able to start the Flutter activity from my Android project. But I'm only able to run it in debug mode, so it's very slow. How do I run it in release mode?

@simoneguidiBA Unless you have special setup (like custom build variants not named debug or release), the choice of build mode for the Flutter part is determined by Android Studio or Gradle as you build the host apk.

Thank you @mravn-google, I didn't think about selecting the build variant and it was indeed on debug.
I've got another issue though. I imported the following flutter plugin in my pubspec.yaml:
shared_preferences: ^0.4.1
Now the build fails with the following errors:
error: package io.flutter.plugins.sharedpreferences does not exist
error: cannot find symbol variable SharedPreferencesPlugin

It looks like they're caused by the following lines in the auto generated GeneratedPluginRegistrant Java class:
import io.flutter.plugins.sharedpreferences.SharedPreferencesPlugin;

[...]

SharedPreferencesPlugin.registerWith(registry.registrarFor("io.flutter.plugins.sharedpreferences.SharedPreferencesPlugin"));

I don't know how to solve this. If I run the flutter application as a standalone it works fine, the error happens only when integrated in a native Android project.

The wiki guide was an experiment, and plug-ins won't work just by following the guide. Changes to Flutter tooling are needed too. #18633 just landed on master. That might do it, but I haven't had time to check yet. We are working on a Flutter module project template that should make add2app much easier, see the flutter_module branch.

@simoneguidiBA I just did a quick test and updated the wiki. Plugins should be supported now.

@mravn-google hi, any progress for this?

If flutter support add2app better, it would be more popular.

@radityagumay @williamwue We are very much aware of this and actively working on it. I'll post here when I have any updates.

For those following along, we are tracking this work in more detail in a number more detailed issues all tagged here: https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A"a%3A+existing-apps"

@mit-mit Should a checkbox list be added to this issue? If we leave it like this i feel there will be no "closing" criteria. Unless you want to leave it open for another reason.

This bug tracks the overall scenario, and we expect to resolve it when we are happy with a first level of support. For concrete issues, see the link I had above.

@mravn-google are any efforts being made in the non-invert of @FredvanRijswijk and @tomaszpolanski proposed?  Namely, we would like to create a fresh Flutter project and make our existing Android and iOS projects be dependencies of this empty Flutter shell project initially.  Then, gradually migrate Android and iOS functionality into Flutter over time.  Possible?  Any work being done in this direction?  Barring any significant architectural constraints on the Flutter side, this seems like the most logical way to migrate a pair of Android+iOS projects into Flutter.

@leemcdole AFAIK, no work is being done to support that approach specifically. And I'm not really sure it would make the transition easier, in general. For one thing, Flutter tooling makes a number of assumptions about the way projects are laid out, built, and launched. If those assumptions aren't true for your existing apps, you may be in for a lot of work to make ends meet.

@leemcdole For the last 4 months I've been including Flutter into 4 years old project and it's going fine - already that version is for 1 month in the stores.
But the approach we've taken is to have our iOS and Android repositories as submodules inside android and ios folders. Some work in gradle and iOS scripts were required.
This approach is not as smooth as creating fresh Flutter application but for us, it works and we are gradually adding/replacing pages in our application. Additionally, no modification of the Flutter repository is required to have Flutter embedded.

@tomaszpolanski not sure if you're up for it but I know me and many others would love to see how you accomplished this. Maybe a short blog post or post your gradle files :)

@mravn-google Have you considered ways to write custom platform-specific code using platform channels? The way in this Add Flutter to existing app is very good,but can't convenient to write MethodChannel。For example, I write a MethodChannel in my Android project,I have to copy the code to Flutter project in order to run successful.And the dart code is in Flutter project,the code of MethodChannel is in my Android project, it's hard to debug MethodChannel. I hope to receive your reply.

@cignaCode Actually it's already in the works :). It's won't so short as I want also to share my experience starting from build setup to UI testing with Flutter driver. ETA 2 weeks

@koudle One option might be to extract your channel communication as a Flutter plugin, and create a dependency on that plugin from the Flutter module. But it depends on what you are trying to achieve. Some clarifying questions:

Are you using the new Flutter module template (flutter create -t module)?
If so, why do you want to run it without the host app? I can think of a few good reasons, but I'm curious about your setup.
How tightly coupled is the Android side of channel communication to your Android app? Does it call into your custom code or into Android SDK APIs?

@mravn-google Thanks for your reply。

Yes，I use the  new Flutter module template (flutter create -t module)
Becasuse it can't write and debug the Dart code in the host app,and it can only be debugged in the pure Flutter project. So if I want to debug the Dart code,I have to change the Android library to become an application or copy the Dart code to another Flutter app project.Can use the Dart code as a module to make the host app depend on it?And it's best to write and debug the Dart code.
It's very deeply coupled,the MethodChannel depends on my custom code.

@koudle You should be able to use the flutter attach command to connect to the service protocol of the Flutter/Dart portion of a hybrid app. This supports hot reload/restart and debugging. We do not yet have IntelliJ IDE support for this (we are actively working on that), but you can do hot reload/restart from the command line and use the Observatory web ui for debugging.
Suppose you have your Flutter module in some/path/hello and the Android host app in some/path/BigApp. Connect a device or start an emulator (Nexus 5X in my case). Then open a terminal:
$ cd some/path/hello
$ flutter attach
Waiting for a connection from Flutter on Nexus 5X

Now launch BigApp in debug mode from Android Studio or using the Gradle CLI --- whatever you'd normally do. Navigate to a Flutter view on the device. Now look back at the terminal:
Done.
Syncing files to device Nexus 5X...                          5.1s

🔥  To hot reload changes while running, press "r". To hot restart (and rebuild state), press "R".
An Observatory debugger and profiler on Nexus 5X is available at: http://<IP_ADDRESS>:59556/
For a more detailed help message, press "h". To quit, press "q".

Copying the http link into a browser leads you to the Dart Observatory UI where you can select a Dart isolate (there will be one per active Flutter view). You can then set breakpoints, evaluate expressions and a lot of other things (memory profiling, heap snapshots etc).

@mravn-google Thanks a lot!

I am trying to integrate flutter module inside existing iOS and Android app. For the Android, it is working fine. I am following steps from https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps. But for iOS app When I try to push FlutterViewController I get the following error.
Logs
[VERBOSE-2:engine.cc(112)] Engine run configuration was invalid.
[VERBOSE-2:FlutterViewController.mm(411)] FlutterViewController.mm(411)] Could not launch engine with configuration.

Following is the code that I am using to push flutter view controller
@IBAction func onClickButton(_ sender: Any) {
        print("Tapped on Button");
        let flutterViewController = FlutterViewController()
        navigationController?.pushViewController(flutterViewController, animated: false)
    }

an output of running flutter doctor -v
[✓] Flutter (Channel master, v0.5.9-pre.79, on Mac OS X 10.13.6 17G65, locale en-IN)
    • Flutter version 0.5.9-pre.79 at /Users/shivamgosavi/flutter
    • Framework revision 3a4ae280e3 (5 hours ago), 2018-08-17 15:02:39 -0700
    • Engine revision 4ee648914f
    • Dart version 2.1.0-dev.0.0.flutter-be6309690f

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.2)
    • Android SDK at /Users/shivamgosavi/Library/Android/sdk
    • Android NDK at /Users/shivamgosavi/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.2
    • ANDROID_HOME = /Users/shivamgosavi/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 26.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] IntelliJ IDEA Community Edition (version 2017.2.6)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 21.2.2
    • Dart plugin version 172.4343.25

[✓] Connected devices (1 available)
    • iPhone 8 Plus • 0822DE18-6632-4F22-93F3-46770C82A247 • ios • iOS 11.4 (simulator)

• No issues found!

Please let me know If I am missing anything. And also please update the doc for integrating flutter into existing swift app, currently, the doc is only about ObjectiveC.
I have also created an issue for this #20777 .

I tried to add Flutter to existing Android app which is successful. However, I couldn't make function calls from Flutter to native Android to retrieve data via platform channel. It is due to extend AppCompatActivity to allow getLifecycle() to work. Do let me know if there is workaround for this as I tried searching for it as the article of having Flutter in existing app is just a week old.
Thanks in advance.

I'm going to close this ticket because it doesn't have a clear delivery artifact.
For bugs and feature requests related to adding Flutter to an existing Android or iOS app, please file bugs against the following project:
https://github.com/flutter/flutter/projects/28
Also, if any comments in this thread require their own issues, please file those against the above project as well.

@tomaszpolanski could you share the experience for how to ues the "Flutter driver" to test the hybrid app?

@Wanghuayin I don't want to spam this issue. Just find me on twitter and I will be happy to share

Hello,
Can I use google map in IOS?
Now I just can be able to use it on Android App

I am embedding Flutter into an existing project. I know how to use "route" to navigate to the specified Flutter page, but how do I put parameters or set arguments to this Flutter page?
For example, the goods list of the native page jumps to the goods details of Flutter, and the goodsID is the parameter that the page needs to load the data. Unfortunately, the Flutter page does not have this parameter when it is render. Should I wait for a channelMessage (include a goodsID) from my native page? This seems unreasonable
Who can help me？thanks

@jonasbark It works for me, thank you

Add Flutter to existing apps is an awesome resource. When invoking Flutter from within iOS/Android, what is the best way to send data to the Flutter world and then get something back once the Flutter view is dismissed? I don't see any arguments or return values to/from Flutter.createView or FlutterViewController.
Writing custom platform-specific code would do it, but that seems relatively cumbersome. We would have to write a bunch of asynchronous messages between the two worlds, including verifications that the data is ready for the Flutter or native views before they're shown.

@pejalo would you mind filing a dedicated ticket for your use-case?  Then we can address your use-case, specifically.  In that ticket, please provide any surrounding details about why you need those particular signals so that we can factor that information into any API changes.

@matthew-carroll thanks for your response! I just created this ticket: #24080

@jonasbark It works for me, thank you

can you provide whole example, please? :)

hi, i tried to let my android project depends on my flutter android module, and i did step by step as
[Add Flutter to existing apps]{https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps}
but after that and i run my application it crashes with this error:
    java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/*-cghZarZN7mfe_qjTTemg1Q==/base.apk", zip file "/data/user/0/*/files/hydra/flutter/unspecified/bundle.zip"],nativeLibraryDirectories=[/data/app/*-cghZarZN7mfe_qjTTemg1Q==/lib/arm, /data/app/*-cghZarZN7mfe_qjTTemg1Q==/base.apk!/lib/armeabi, /system/lib, /vendor/lib]]] couldn't find "libflutter.so"

look forward to get help...
** Resolved by add **
ndk {
            abiFilters 'armeabi-v7a'
        }

** to host project's build.gradle
found after flutter android module is compiled，the “libflutter.so” is located in "jni/armeabi-v7a/libflutter.so" **

Is there a way to get it to work with 'normal' emulator as well, or do you have to use the slow emulators?
tanks

@walterFeng you could just add the Id in the route name, just like a get parameter in a URL? E.g. "/goods/(Id)" or "/goods?id=(id)".

Does this work in iOS? It was not working for me...

@jonasbark It works for me, thank you

hi could you please share the any code to implement it for iOS. I have no idea how to open different flutter pages with some parameter in existing iOS app. I can able to open flutter page, but donot know to open different pages on the basis of app requirements.

Add Flutter to existing apps is an awesome resource. When invoking Flutter from within iOS/Android, what is the best way to send data to the Flutter world and then get something back once the Flutter view is dismissed? I don't see any arguments or return values to/from Flutter.createView or FlutterViewController.
Writing custom platform-specific code would do it, but that seems relatively cumbersome. We would have to write a bunch of asynchronous messages between the two worlds, including verifications that the data is ready for the Flutter or native views before they're shown.

Hi
Could you have any idea of it. or you got any solution for the same. I have also same issues in my existing app. So please share your experience if you have any solution.


convert skip to iterate instead of call recursive functions

The observation is that "skip" functionality shouldn't be hard to avoid function recursion because the return type is always (). So here's an attempted implementation. Should hopefully be faster...

This is great, thank you.


Update sbt-plugin to 2.8.1

Updates com.typesafe.play:sbt-plugin from 2.6.25 to 2.8.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.play", artifactId = "sbt-plugin" } ]

labels: sbt-plugin-update, semver-minor

Not compatible with 2.11


techniques to improve ddc compile times

If and when we want to improve DDC compile times:

To get the ddc compile times down further you can use the bazel_worker package to keep DDC alive between compiles which should speed things up some. Specifically, you want to look at the BazelWorkerDriver class. This would also allow you to handle multiple requests in parallel but limited to a set number (it handles spawning multiple workers and delegating work between them).

If you start it in --kernel mode and compile with --reuse-compiler-result and --use-incremental-compiler it will also retain the state from the previous compiles and you should see a significant speedup.

cc @jakemac53

Fwiw, this is probably something I would be willing to take on if you would like. I suspect compile times for dartpad-like apps to be in the ~50ms range based on the build_runner times for the spinning square example.

That would be much appreciated!
We compile here: https://github.com/dart-lang/dart-services/blob/master/lib/src/compiler.dart#L147
And generate the summary and framework js files here: https://github.com/dart-lang/dart-services/blob/master/tool/grind.dart#L106
I'll be OOO for a bit, but @domesticmouse and @RedBrogdon will be around in terms of coordination.


Resolve topic user docs edit pass

Cleanup pass on user docs for Resolve topic.
Testing plan:
Manual

Merged, after doing my own edit pass on this.  Thanks @alya!


Possible deadlock with messages with no body

Describe the bug
In my mailbox, I have a message with no body, only headers, and it seems mail2most is blocking on it. it stops working just after showing the processing message for this message.
Expected behavior
mail2most stops processing, no message is sent to mattermost
Release version
v1.11.7
Architecture
amd64
Additional context
I cannot publish the content of the mail here, unfortunately. I might follow-up later on this issue.

Possibly it's the server that never responds when requesting the body, I cannot be sure.

Hello @mildred thank you for your issue. I'll take a look at this issue and test out if empty body mails work as soon as i can.


Micronaut 4: validation not working

Expected Behavior
When calling POST trips the DTO gets validated and it returns 400 error because the fields are annotated with NotNull.
Actual Behaviour
The DTO is not validated and it gets passed through to the controller resulting in a 500 null error.
Steps To Reproduce

Open and run: uber.zip
Make a request to POST ttp://localhost:8080/trips with an empty body.
Returns a 500 null exception instead of a 400 validation error.

Environment Information
No response
Example Application
No response
Version
4.6.1

Looks like it has something to do with a current Micronaut Core bug with ExceptionHandler. 🤔

Please don't use Lombok if you don't know how to properly configure it.


Fix(plugins): Remove wrong 3.9 deprecation warning

Change Summary
A warning is currently emitted for user running 3.9 stating deprecation will happen in Nov 2023. This is a leftover mistake and this PR addresses it
Component(s) name
plugins
How to test
No more warning
Checklist
Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

Thanks @ankudinov - we discussed it but given that deprecation will happen regularly we decided to keep it in there in the end!


How to delete a document?

Is there a way using the CLI to delete a document, or to have some way to replace a duplicate document given a certain field name?

The functionality exists in tantivy, as it cannot be done with tantivy-cli at the moment.
Toshi is likely to become a cleaner / more complete project than tantivy-cli.

@zjgreen  I opened https://github.com/hntd187/Toshi/issues/2