Let jsxImportSource be configurable through tsconfig.json

Is your proposal related to a problem?
Right now it's only suggested for tsconfig.json to set "jsx": "react" but it's not enforced.
TS 4.1 will bring new JSX-related option (jsxImportSource) and new possible values for the jsx option (react-jsx & react-jsxdev) - both of those changes are related to the new JSX runtimes.
TS also has an ability to change what exact JSX namespace is used for type-checking based on the used jsx factory as per the documentation. This probably means that there is a problem for some possible configuration today:
TS can do its typechecking thinking that another factory is used (when one would configure jsxFactory) but in fact the emitted code uses the default factory of React.createElement because the transpilation is done by Babel that is not aware of TS configuration.
I'm not really interested in fixing this problem - I haven't found any issue about this so the audience for this is probably very little and it's just a possible problem that I have thought of and not something that affects me.
However, I would really love to be able to configure jsxImportSource globally and while you don't allow for Babel customization (which is understandable tradeoff here) you allow for some tsconfig.json configuration. It (tsconfig.json) seems to be a good match for inferring this particular configuration for a vast number of consumers (as TS is used by a lot of people).
Motivation
I'm a maintainer of Emotion which is a popular CSS-in-JS solution for React (3.4M downloads/week) which comes with the CSS prop API that is based on @jsx pragma (although not all of our consumers use the CSS prop API as we expose the popular styled API as well).
Right now the @jsx pragma in CRA has to be used all over the place. We personally don't find it to be that problematic but we get complaints about this regularly from the community. Having a way to configure this (new transforms, not the old pragma) globally in CRA would probably result in a huge DX improvement for us.
Describe the solution you'd like
Provide custom importSource to @babel/preset-react, based on the jsxImportSource from tsconfig.json
Describe alternatives you've considered
If this is something that you don't want to support then I strongly believe that you should disallow configuring jsxImportSource in the tsconfig.json altogether because it causes a configuration mismatch between TS and Babel and this might be a footgun for people.

[x] Implementation intent

I created a new project using CRA4 with typescript template today.
I have a difficult time trying to use emotion. as I know with the release version 10.1.0 of emotion, I should use /** @jsxImportSource @emotion/core /` instead of /* @jsx jsx */, so I try to use like this
/** @jsxImportSource @emotion/core */
import { jsx } from '@emotion/core';

or just
/** @jsxImportSource @emotion/core */

but I got error anyway saying "'React' refers to a UMD global, but the current file is a module. Consider adding an import instead.". I guess maybe it's about CRA typescript template.
I'm not familiar with neither CRA nor new JSX runtime.

Could u share a repository with this issue reproduced? I could take a look at this.

@Andarist Thanks!  here is the repository https://github.com/seanbruce/butler-of-ellen.git

The current TS version is not aware of the new @jsxImportSource and thus it doesn't know that there are already implicit imports (inserted automatically) based on that @jsxImportSource pragma. This requires TS 4.1 which is currently at the beta stage and I believe that it is supposed to be shipped as stable this month.
I've managed to trick the compiler to accept this by changing this:
https://github.com/seanbruce/butler-of-ellen/blob/28754637234e145547f16232fe5eef111457a651/tsconfig.json#L18
to "preserve"
And by adding import '@emotion/core' to this file:
https://github.com/seanbruce/butler-of-ellen/blob/28754637234e145547f16232fe5eef111457a651/src/react-app-env.d.ts

following this trick. I change compilerOptions.jsx to "preserve" and add change react-app-env.d.ts like this
import '@emotion/core';
/// <reference types="react-scripts" />

then I run yarn start I got this error says TypeError: Cannot assign to read only property 'jsx' of object '#<Object>'

Oh, right 😢 I've focused on fixing TS problems without running yarn start and CRA enforces certain values to be what they want them to be. Those are enforced values:
https://github.com/facebook/create-react-app/blob/aec42e2cc05fe0799a3b73830b874757e9e3f561/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js#L148-L158
I'll give this more thought but I don't have an idea how this can be approached right now without waiting for TS 4.1

@Andarist I think I just wait for TS4.1 released to solve this issue once and for all.  for now, I use this not perfect solution until TS4.1. Thank you so much for your time.😄

With version Typescript 4.1 I tried
"jsxImportSource": "@emotion/react",
"jsx": "react-jsx"

But the css props from emotion is not working, I have to put "/** @jsxImportSource @emotion/react */" on top on the file.
Id the property jsxImportSource ignored .

And this issue is exactly about this problem. I'm proposing that the CRA's Babel preset could be "configured" with the importSource based on the jsxImportSource of the tsconfig.json. I believe that wouldn't compromise the 0config approach taken by the CRA.

@iansu fyi this feature (being able to pass importSource to babel) would be a big usability win for CRA's CSS-in-JS users (i.e. emotion/et al) by being able to remove the /** jsxImportSource ... */ lines that currently have to be copy/pasted into every file in a project.
It looks like this PR added an importSource with a process.env.JSX_IMPORT_SOURCE flag:
https://github.com/facebook/create-react-app/pull/10138/files#diff-7cd8a2246cedc973ca54463e12073aaff89e13fda0f3d8b61742ec8e2b64b708R100
But @Andarist is suggesting adding a smarter if-isTypeScriptEnabled-then-parse-tsconfig-for-its-jsxImportSource setting, right around this section of code from your "New JSX Transform Opt Out" PR:
https://github.com/facebook/create-react-app/blame/master/packages/babel-preset-react-app/create.js#L99
If I wrote a PR that changed that ~section of code to conditionally parse tsconfig.json and pass along importSource to babel, would that likely get accepted? Do you have any preferences/suggestions for a better approach?
Thanks!
(...I'm a little worried about "just fs.load tsconfig.json; while really simple, it wouldn't support tsconfigs that extend other tsconfigs ... would have to research the idiomatic way of loading tsconfigs...although maybe that could be a V2.)

@iansu fyi this feature (being able to pass importSource to babel) would be a big usability win for CRA's CSS-in-JS users (i.e. emotion/et al) by being able to remove the /** jsxImportSource ... */ lines that currently have to be copy/pasted into every file in a project.
It looks like this PR added an importSource with a process.env.JSX_IMPORT_SOURCE flag:
https://github.com/facebook/create-react-app/pull/10138/files#diff-7cd8a2246cedc973ca54463e12073aaff89e13fda0f3d8b61742ec8e2b64b708R100
But @Andarist is suggesting adding a smarter if-isTypeScriptEnabled-then-parse-tsconfig-for-its-jsxImportSource setting, right around this section of code from your "New JSX Transform Opt Out" PR:
https://github.com/facebook/create-react-app/blame/master/packages/babel-preset-react-app/create.js#L99
If I wrote a PR that changed that ~section of code to conditionally parse tsconfig.json and pass along importSource to babel, would that likely get accepted? Do you have any preferences/suggestions for a better approach?
Thanks!
(...I'm a little worried about "just fs.load tsconfig.json; while really simple, it wouldn't support tsconfigs that extend other tsconfigs ... would have to research the idiomatic way of loading tsconfigs...although maybe that could be a V2.)

TS exposes the API to read the config file so that part shouldn't be particularly a problem: https://github.com/facebook/create-react-app/blob/aec42e2cc05fe0799a3b73830b874757e9e3f561/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js#L173-L176

TS exposes the API to read the config file so that part shouldn't be particularly a problem: https://github.com/facebook/create-react-app/blob/aec42e2cc05fe0799a3b73830b874757e9e3f561/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js#L173-L176

@stephenh Curious if you had the chance to start the PR you mentioned?
I just created a new CRA4 app + Emotion 11 and ran into this - completely agree it will be awesome for CRA users if they don't have to manually prepend
/** @jsxImportSource @emotion/react */
on a per-file basis.

Is the property jsxImportSource ignored ?

@MatthieuCoelho Yes, it seems that way. On CRAv4.0.1 + Emotion v11.1.4 I was able to repro what you're describing - this property seems to not get picked up by react-scripts which makes sense since it only arrived with TS v4.1+.
Is anyone aware of existing PRs that start to make CRA aware of TypeScript 4.1?

@onpaws no, didn't bother starting a PR w/o an ack from the maintainers. Plus our existing codebase already has the per-file snippet so this is a nice to have, but not blocking us.

Got it, thanks for the prompt reply.

Plus our existing codebase already has the per-file snippet so this is a nice to have, but not blocking us.

Lucky you, wish I could say the same! 🙈
If I get some time in the coming weeks I'll try to take a look at 1, 2 for other potential ways to workaround it.

If you're happy using craco/rewired so you can edit the babel config then you should be able to get around the per-file pragma definition with the trick I've used for twin.

I opened a PR that uses the jsxImportSource compiler option from tsconfig.json or removes it (and explains why) when Babel and TypeScript configuration would be inconsistent: https://github.com/facebook/create-react-app/pull/10583

Has this been solved yet? I have just got into Emotion with a CRA project and I'm struggling to get the css property to work.
So far I have managed to make it work adding either:
  /** @jsxRuntime classic */
  /** @jsx jsx */
  import { jsx } from '@emotion/react';

or
  import { jsx } from '@emotion/react';
  /// <reference types="react-scripts" />

while adding in tsconfig.json the line "jsxImportSource": "@emotion/react",
Is there any clean way of solving this? I was already at odds with having to add the jsx pragma  :sweat_smile:

Any progress on this one?

This issue is confusing and some documents say this typescript config works but actually it is not. Do you have any updates on this issue?

I'm currently running a vite application and the emotion docs suggest updating the tsconfig compiler options (https://emotion.sh/docs/typescript), with:
{
    "jsx": "react-jsx",
    "jsxImportSource": "@emotion/react",
}

but this does not work- I still need to add /** @jsxImportSource @emotion/react */ above each file. What am I missing?

Any news on this ?

eed to add /** @jsxImportSource @emotion/react */ above each file is very difficty

👍

Oh man, this problem is really annoying for the developer experience. In our project, the css prop worked for a long time, until some update. Unfortunately, the bug is noticed only in the application and not in the development process.
I don't want to complain, because I am very thankful for all the time invested in open source tools here. However, this problem is so prominent in Google searches that it really should be addressed.

In case this helps anyone if your configuration is ejected and you have access to the Webpack config file, you can use ModifySourcePlugin to prepend the jsxImportSource comment to every file:
      new ModifySourcePlugin({
        rules: [
          {
            test: /.+\.tsx$/,
            operations: [
              new ConcatOperation(
                'start',
                '/** @jsxImportSource @emotion/react */\n\n'
              )
            ]
          }
        ]
      }),

I added it at the start of the plugins list, which seemed to do the trick. It's not ideal, but I couldn't bear the thought of adding this at the top of every file. 🤣

Is there any update on this issue? It's been a problem for a while, and I can not figure out how to use the CSS prop without manually adding the JSX Pragma in every file. It is extremely annoying to add it to every file and if anyone has a solution that does not involve prepending the pragma using a Webpack plugin it would be much appreciated! I am also using CRACO, but no luck getting it to work.

Would be awesome to have an inline CSS solution out of the box. Svelte/SvelteKit does this the best way to my knowledge: no extra steps needed, you can just write standard CSS within your component and they are scoped to it by default, even the classes.

I do not want to add /** @jsxImportSource @emotion/react */ at the top of every file in my CRA project. Not only because its extra work, and we as developers should find solutions for repetitive tasks, but also because it looks hideous and hacky.
Does anyone have a step by step work-around this issue?

I do not want to add /** @jsxImportSource @emotion/react */ at the top of every file in my CRA project. Not only because its extra work, and we as developers should find solutions for repetitive tasks, but also because it looks hideous and hacky.
Does anyone have a step by step work-around this issue?

Yes, the solution is simple: switch to vite yesterday and start using stitches instead of emotion. All your problems will be solved overnight.

I do not want to add /** @jsxImportSource @emotion/react */ at the top of every file in my CRA project. Not only because its extra work, and we as developers should find solutions for repetitive tasks, but also because it looks hideous and hacky.
Does anyone have a step by step work-around this issue?

Yes, the solution is simple: switch to vite yesterday and start using stitches instead of emotion. All your problems will be solved overnight.

I like to use inline-styles like this, unfortunately stitches doesnt work like this.
			<div
				css={{
					backgroundColor: 'pink',
					height: "500px",
					'&:hover': {
						backgroundColor: 'green'
					}
				}}
			>
			</div>

I do not want to add /** @jsxImportSource @emotion/react */ at the top of every file in my CRA project. Not only because its extra work, and we as developers should find solutions for repetitive tasks, but also because it looks hideous and hacky.
Does anyone have a step by step work-around this issue?

ive answered my own question here
https://stackoverflow.com/a/76381748/12671440

I do not want to add /** @jsxImportSource @emotion/react */ at the top of every file in my CRA project. Not only because its extra work, and we as developers should find solutions for repetitive tasks, but also because it looks hideous and hacky.
Does anyone have a step by step work-around this issue?

Yes, the solution is simple: switch to vite yesterday and start using stitches instead of emotion. All your problems will be solved overnight.

I like to use inline-styles like this, unfortunately stitches doesnt work like this.
			<div
				css={{
					backgroundColor: 'pink',
					height: "500px",
					'&:hover': {
						backgroundColor: 'green'
					}
				}}
			>
			</div>

Yes I used to write this way too. Now with stitches I can do:
return  <Button
              variant="naked"
              cols="mx mx" // mx expands to max-content
              colG={12}
              alignI // true defaults to center
              h={500}
              w="fit-content"
              px={16}
              py={8}
              mx={8} // margin left and right
              br={24}
              bg={theme.colors.pink9}
              initial={{ opacity: 0 }}
              animate={{ opacity: 1 }}
              exit={{ opacity: 0 }}
              disabled={isLoading}
              _disabled={{
                 bg: theme.colors.gray5
              }}
              _before={{
                content: "",
                position: "absolute",
                inset: 0
             }}
             _hover={{
                bg: theme.colors.green9
             }}
             _active={{
               scale: 0.9
             }}
            css={{
               svg: {
                  w: "100%"
               }
            }}
            >
              <Text color={theme.colors.red8}>Delete</Text>
            </Button

The above is more of a kitchen sink example, but with stitches I can do your same stuff but use my own aliases for css properties AND values. cols gets translated to gridTemplateColumns and mx expands to max-content.
w, h, px, and bg become width, height, padding-left and padding-right, and background-color underneath.
_disabled, _active, and _hover become &:disabled, &:active, and &:hover, respectively, but I could have made them anything I wanted.
No more dealing with the limitations of CRA and emotion. I get to make my own CSS-in-JS shorthands. It's skyrocketed my UI development.
I even added an onLongPress handler and copy variant to my button, and I have cool things for many of my components now. I have a truncate prop for my <Text> component (just a stitches created p tag underneath) that will apply at least 3 css classes to give me the ellipsis when text is too long. Stitches + vite + Radix colors has made all the difference.
There is a little setup required but its so insanely worth it.

Tried doing this and it works
// tsconfig.json
{
  "compilerOptions": {
    // ...
    "jsxImportSource": "@emotion/react",
    "jsx": "react-jsx"
  }
}

// vite.config.ts
export default defineConfig({
  plugins: [react({ jsxImportSource: '@emotion/react' })],
})


An importable modulesPath, once again

This is the simplest way I can think of to make it happen and work the way it used to (which doesn't seem that bad). Alternative to #8189 and should resolve #8188.
This feels like an extremely noisy problem that has a dozen valid solutions. @edolstra @shlevy @nbp probably care the most. I'm building my functionality on top of this but will swap out something else if people prefer it. I mostly just want to put this problem behind us and move on :smile:

Also related to #7835.

:+1: avoids the "special treatment of NixOS in the module system" problem and doesn't do scope magic. Bikeshedding possible on the name of specialArgs but I don't really care personally.

Also, after merging this, I'd probably want to go back and change the various <nixpkgs/...> imports back to modulesPath. I've run into lots of confusing issues due to those NIX_PATH imports floating around in nixpkgs.

I don't think we should change those imports back to modulesPaths. Keeping modulesPath around for backwards compatibility is one thing, but it shouldn't be used for new deployments.

:+1: on merging btw.

Okay, just waiting on @nbp then.
@edolstra I still think there's a legitimate use case for this thing, and that's the one I'm encountering with my EC2 image: if I want to both build an image/VM test from a config (in my current tree) and copy that config into the resulting image (will be in /etc/nixos) for maximum realism/avoiding DRY, I don't think I have another option. Am I missing a good way to make that work?

Couldn't you use the -I command line argument?  I am not sure I understand your problem with the <nixpkgs/…> notation.

Sure I can, but:

it's a trap; no indication ahead of time or even after the fact that a
particular call to nix-build is going to need -I. The system will just
quietly do the wrong thing unless you notice
why make people jump through hoops for this, what is so bad about
keeping the old behavior that actually served a purpose?
the tests could be running in hydra. I don't get to specify -I there and
don't have guarantees about where it's pointing

On Tue, Jun 9, 2015 at 08:32 Nicolas B. Pierron<EMAIL_ADDRESS>wrote:

Couldn't you use the -I command line argument? I am not sure I understand
your problem with the <nixpkgs/…> notation.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/8204#issuecomment-110340481.

In short, <nixpkgs>-style paths are basically an untracked impurity that can deeply and subtly change your expression's behavior, allowing what would otherwise be a pure expression (anywhere you import it) to access global state. I'm fine with them around "entry points", but if you ever find yourself processing a <nixpkgs> behind an import, I think you're in for some trouble/pain. The implementation of eval-config probably imports configuration.nix right now, but configuration.nix is still the "entry point" as far as the user is concerned. That's where my #8190 proposal is coming from, if anyone missed that.

I don't understand the problem. How is writing <nixpkgs/...> jumping through hoops compared to the totally ad hoc modulesPath? And how will it do the wrong thing?
Regarding Hydra, it's completely guaranteed what <nixpkgs> points to, namely, the nixpkgs input of the jobset.

The problem is just that I got bitten repeatedly when trying to run what seemed like a perfectly innocent expression in #8013. I'd type nix-build -A tests.ec2 release.nix and think it was doing the right thing, but deep within my import expression someone imported <nixpkgs/...> and was calling my system nixpkgs rather than the directory I was running in.

How about scopedImport has an option to provide additional (or modify existing) NIX_PATH components in the evaluated expression? Then when I import something I can be sure that its nixpkgs is pointing to the right place?

@nbp anyway, can we split the discussion into two parts?

whether this is a "good" (or simple, at least) way to get modulesPath back
whether people should want modulesPath going forward

Both @shlevy and @edolstra seem to be okay with 1. I still have some work to do to convince Eelco at least of 2, but that can happen later (or I can be convinced that it isn't useful), but I'd rather not hold up 1 for that. Do you have a view on that?

@copumpkin Let's just merge this for now.

Merging because 2/3 "module VIPs" have :+1:'d it :smile:. We can revert if it ends up being terribad.
@edolstra, @nbp, at some point (if I ever find some time to be on IRC while you guys are awake) we should talk about whether I'm just missing something in my desire to use this parameter.


Start introducing host screening state

Branched off https://github.com/avimoondra/fishbowl/pull/98

Abstract AssignTeamsButton component
Introduce WaitingForSubmissionsState enum

 [XS] Screen cards


Inconsistent behaviour between save() and bulk_create() for JSON fields

Describe the bug
The Model.save() function and the QuerySet.bulk_create() function differ in how they treat incoming JSON objects before saving to the database. Specifically, the bulk_create function always stringifies the contents of a JSON field, while the save function does not. This is invisible from a code perspective, as the field is re-interpreted properly on .load(), but it means that JSON fields from results stored in a bulk_create function cannot later be queried in the database.
To Reproduce
Steps to reproduce the behavior (with a database/metadata assigned in the BaseMeta as in the docs):
class TestModel(ormar.Model):
    class Meta(BaseMeta):
        tablename = "test_model"

    id: int = ormar.Integer(primary_key=True)
    json_field: Json = ormar.JSON()

# For the same json value, create two models
json_value = {"a": 1}
test_model_1 = TestModel(id=1, json_field=json_value)
test_model_2 = TestModel(id=2, json_field=json_value)

# store one with .save() and the other with .bulk_create()
await test_model_1.save()
await TestModel.objects.bulk_create([test_model_2])

# refresh from the database
await test_model_1.load()
await test_model_2.load()

assert test_model_1.json_field == test_model_2.json_field # True

# try to query the json field
table = TestModel.Meta.table
query = table.select().where(table.c.json_field["a"].as_integer() == 1)
res = [TestModel.from_row(record, source_model=TestModel) for record in await database.fetch_all(query)]

assert test_model_1 in res # True
# assert test_model_2 in res # FAILS
# assert len(res) == 2 # FAILS

Expected behavior
Both methods should behave like .save() - i.e. they both result in records that can be queried by JSON field.
Screenshots
From the pgadmin console, you can see the stringified result for test model 2.

Versions (please complete the following information):

Database backend used: postgres (with asyncpg driver)
Python version: 3.10
ormar version: 0.10.25
pydantic version: 1.9.0

Additional context
This seems to be related to the behaviour of the prepare_model_to_save function, specifically the call to dump_all_json_fields_to_str. If this is actually a bug and not expected behaviour, I can dig around in there to try to fix it.

I am also experiencing the described behavior.
A janky way to query stringified records in the meantime: https://stackoverflow.com/a/70878521/7262049

Fixed in 0.11.0 - please update and check.


Surround xml with tag

Hi would it be possible to build a model that has a parent or surround_with notation?
Use case:

I have class Foo
It includes a list of Bars
The XML representation should be surrounded by Root:

<Root>
  <Foo>
    ...
    <Bars>
      ...
    </Bars>
  </Foo>
</Root>

I wouldn't want to declare a class Root for this

Open the file with nokogiri and then run Foo.parse(doc.xpath("Root"))

@deiga  Isn't this provided by wrap https://github.com/mvz/happymapper/blob/master/spec/wrap_spec.rb

@fidalgo Sure, that was added a year later than this question. But this is now resolved.


All my history for 2 years is suddenly gone!

I have been using this site to save my wishing history since i started playing. I'd come every 2-3 months to reload. Today i got in as usual, did my importing and suddenly all my history is gone, and now i only got the past 6 months instead of 2 years. I am desperate to get that back. Anyone can help??


prepare Linux support (1/many)

Description Of Changes
minor changes that allow Boxstarter modules to be loaded on Linux.
fixes #527
Motivation and Context
some basic changes that are required to be able to run Boxstarter(Shell) on Linux (someday,...  eventually :smile: )
Testing
on a proper OS,
pwsh
./BoxstarterShell.ps1

Change Types Made

[x] Bug fix (non-breaking change)
[x] Feature / Enhancement (non-breaking change)
[ ] Breaking change (fix or feature that could cause existing functionality to change)
[x] PowerShell code changes.

Change Checklist

[ ] Requires a change to the documentation
[ ] Documentation has been updated
[ ] Tests to cover my changes, have been added
[x] All new and existing tests passed.
[x] PowerShell v2 compatibility checked.

@mwallner I have left a couple of comments on this PR, but nothing that would stop this change from going in.


Update Bulma to 0.6.0

Buefy version: [0.5.3]
Vuejs version: [2.5.2]
Description
Not a major issues, but it would be great to bump the Bulma version to 0.6.0. Only three small breaking changes, so it should be a smooth upgrade for Buefy. Thanks for such a great and easy to use library.

Updated in dev branch


Move CredentialMakeResult to Fido2NetLib.Objects namespace

Fixes #432

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (15263ca) 77.50% compared to head (6b07590) 77.50%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   77.50%   77.50%
=======================================
  Files          98       99    +1
  Lines        2716     2716
  Branches      445      445
=======================================
  Hits         2105     2105
  Misses        492      492
  Partials      119      119

Files
Coverage Δ

Src/Fido2.Models/Objects/CredentialMakeResult.cs
100.00% <100.00%> (ø)

Src/Fido2/Fido2NetLib.cs
90.00% <ø> (-1.67%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@joegoldman2 Let's rename this type to MakeNewCredentialResult while we are here.

👍

LGTM. @aseigler anything or are we good to merge?

I'm happy if you're happy!


Documentation: Aql with ArangoDB Web Interface

create Aql/AqlWithWebInterface with text adapted  from WebInterface/README and jan's blog. Links adapted.  Moved CombiningQueries.md in AqlExamples. Added links between Parameter Binding related chapters.

Thanks!


How to build TensorRT-LLM with Python bindings for C++ runtime?

I ran the following command to build the Docker image, which runs successfully.
make -C docker wheel_build BUILD_WHEEL_ARGS="--clean --trt_root='/usr/local/tensorrt' --cuda_architectures='75-real;80-real;86-real' --python_bindings"

I then ran the following to run the built image in a Docker container:
docker run -i -t -d --gpus=0 -u root --shm-size=1g --ulimit memlock=-1 <image id> /bin/bash

However, when I try to import a Python module that depends on the Python bindings for the TensorRT-LLM C++ runtime, I am met with an error:
root@bbb534ca93cc:/src/tensorrt_llm# python
Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorrt_llm
[12/26/2023-08:09:23] [TRT-LLM] [W] Found pynvml==11.4.1. Please use pynvml>=11.5.0 to get accurate memory usage
>>> tensorrt_llm.runtime
<module 'tensorrt_llm.runtime' from '/src/tensorrt_llm/tensorrt_llm/runtime/__init__.py'>
>>> tensorrt_llm.runtime.model_runner_cpp
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'tensorrt_llm.runtime' has no attribute 'model_runner_cpp'. Did you mean: 'model_runner'?

What am I missing?

Never mind... I realized that I was using an older commit on the rel branch which did not include model_runner_cpp.py. After switching to use the most recent commit to the rel branch, this is working correctly.


Added arm-gcc-10-2020-q4 revision

The new stable version of gnu-arm toolchain is available. Because of some C++ features and bugfixes that are supplied with 10.2 gcc version it would be fine to update the existing GitHub action for adding the support of the new compiler.

@ValentiWorkLearning thank you!

@gretel I've no idea, how to fix the issue with NodeJS download, because of passed build for Mac OS. How to reproduce these failed tests locally? I want to fix them and prepare this PR to be merged, because some essential fixes are supplied only from GCC 10.2( Especially  some of upcoming stable C++20 features ).

@gretel I've no idea, how to fix the issue with NodeJS download, because of passed build for Mac OS.

not sure if i get you right. this error happens sometimes because github actions is using docker. there is nothing you can do to change that. but there is a workaround which i have added on my branch (Take the trash out step). please check the action running fine on my fork.

How to reproduce these failed tests locally? I want to fix them and prepare this PR to be merged, because some essential fixes are supplied only from GCC 10.2( Especially some of upcoming stable C++20 features ).

one step at a time. we did port all what is required to have this working inlcuding on osx now.
it is not any different for the platforms when they actually use the same compilers. i also don't think any more abstraction (like build containers) should be put in place cause this would just add more hidden complexity and requires additional maintenance efforts.
the test suite completes fine. now, the tests have to test the right things.
nobody has taken any care in regards to unit testing since.. the original fork. all the changes, all features, the dozens of little experiements eventually got merged without working on the tests. the betaflight project is not accepting any PRs without the tests to complete fine - and this project would be better of doing same.
you just can't fix that on your own in a couple of days. the contributors of this project have to accept the need for unit testing and continue to work on their submissions. or, as some prefer - abandon their previous hackings and work on betaflight instead.

@ValentiWorkLearning thanks, there is nothing you can do. the post gets done automatically on reference - it's just how github works.
but, i was mixing up context cause what you wrote als matched the actual issue i was trying to comment on 😕

@fiam howdy! can you check on this please?

@gretel seems these issue will be here for a long. If you need a quick temporary fix- these can be used:
    - name: Get the latest arm-gcc-none-eabi-gcc
      uses: wei/wget@v1
      id: download-arm-gcc
      with:
        args: 'https://developer.arm.com/-/media/Files/downloads/gnu-rm/10-2020q4/gcc-arm-none-eabi-10-2020-q4-major-x86_64-linux.tar.bz2'

    - name: Unpack arm-gcc-compiler
      run: |
        mkdir toolchain
        tar -xjf gcc-arm-none-eabi-10-2020-q4-major-x86_64-linux.tar.bz2 --directory ${{ github.workspace }}/toolchain

It's not a cross-platform approach, but having the latest compiler is more important, imho.
P.S. I used this for my project because arm-gcc-none-eabi is used only under linux environment.

@ValentiWorkLearning many thanks.

It's not a cross-platform approach

this is something i can change 😸

I think Windows if failing because the new Windows .zip file now has a top level gcc-arm-none-eabi-10-2020-q4-major directory like the Mac and Linux .bz files. It didn't have the before.
The tar extractor has an option to strip this top level extractor = tar.x({strip: 1, C: directory}) but the unzipper doesn't have this option extractor = unzipper.Extract({path: directory}) See https://github.com/ZJONSSON/node-unzipper/issues/109

So maybe the solution is to not await fs.promises.mkdir(directory, {recursive: true}) except for on older windows .zip files and remove the strip option from the tar unzipper. Then after the files are extracted, rename the directory to the shorter name.

I resolved this in a fork by checking the presence of the bin directory in the zip to decide how to set the path: https://github.com/fiam/arm-none-eabi-gcc/compare/master...ryanwinter:master

I resolved this in a fork by checking the presence of the bin directory in the zip to decide how to set the path: https://github.com/fiam/arm-none-eabi-gcc/compare/master...ryanwinter:master

@dlech thanks! How to properly integrate your fixes into the existing PR for passing the checks?

@dlech thanks! How to properly integrate your fixes into the existing PR for passing the checks?

How to properly integrate your fixes into the existing PR for passing the checks?

I think @ryanwinter did something like this already in their fork.

How to properly integrate your fixes into the existing PR for passing the checks?

I think @ryanwinter did something like this already in their fork.

Seems issue is fixed now in master branch by the action maintainer.


Allow Create Token to use the amount set

Payment express does an initial payment when creating a token. It is currently hard-coded to $1 but it is valid to do it for a user-defined amount
The PR facilitates that ... https://github.com/thephpleague/omnipay-paymentexpress/pull/13

#13 merged


One object two tables

Is there any way to get data to one object from two tables without hand writing sql's?

A view would be one option I suppose.


Differentiate font sizes for risk budget selector

All of these are the same size. We should make them different sizes so some information stands out a bit more. Probably the help text under the label should be smaller.

@blanchardjeremy This appears to have been fixed at some point, is it alright if I close this?

Yeah I fixed it a long time ago I think a d forgot to close this.


Windows

How I can install this on Windows?

Hello, for example, you can install as follows:

Install Windows Terminal app from the store
Install python 3.x also from the store (if you just type python in the Terminal app it will offer you to install).
Install a few libraries by typing in the Terminal pip install holidays windows-curses
Download this repository and extract the calcure file somewhere, for this example I'll use Documents folder.
Now you can finally run it by typing in the terminal python ./Documents/calcure

This is a bit bothersome, and I guess there should be a nicer way to do it. I'll update if I find something...

Ok, thanks.

Not working :(

I assume you didn't change the config.ini. I think it might be related to encoding. I'll be able to take a look later today...

I can't see config.ini

So yes, it was encoding problem. Try again with the version I just uploaded, please.
By the way, on Windows config is stored in your $HOME directory \.config\calcure\config.ini in my case it was c:\Users\myname\.config\calcure\config.ini or something like that.

Now I don't have issue.


[Experiment] Avalonia single project support

What does the pull request do?
Makes it easier to create a single project for windows, macos, ios and android platforms.
With "NET8.0" it's possible to include "net8.0-browser" as well now.
But it still has problems with linux target - .NET doesn't support yet nor alias it.
What's working:

Platform specific folders, including bootstrap projects.
Rider integration (at least EAP), including project build, debug and run.
Referencing of correct platform specific nuget packages.

What does not work:

Proper integration with VS (everything seems to work except VS doesn't understand how to run mobile projects).
Linux targets. But it's possible to create a "Desktop" target (i.e. "net8.0" TFM)
Windows MSIX support (out of scope).
Special resource types that can be converted to the platform specific ones. For instance, icons defined once and converted to each platform automatically. Instead, developers need to convert them manually and put to the platform specific folder.

Disclaimer: Avalonia team still recommends multiple projects approach, which is available in our templates. It is more verbose, but way more flexible in a long term. Also doesn't have stoppers with linux projects.
What is the updated/expected behavior with this PR?
MAUI, Tizen and MSBuild.SDK.Extras source codes were used as a reference.

You can test this PR using the following package version. 11.0.999-cibuild0026996-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-nightly/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0027018-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-nightly/nuget/v3/index.json) [PRBUILDID]

Potentially can be useful on mobile only. But blocked by inconsistency in the .NET SDK itself.
Possibly can be reopened in the future.

Resurrecting this PR. I want to have this feature at least for the internal use.


[BUG]: Address flakiness of a distribution_system_spec due to DistributionPdf failing to find a logo

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
We randomly see this spec fail:
Failures:

  1) Distributions When creating a distribution from a donation when editing that distribution User creates a distribution from a donation then edits it
     Failure/Error: StringIO.open(organization.logo.download)

     ActiveStorage::FileNotFoundError:
       ActiveStorage::FileNotFoundError

     [Screenshot Image]: /home/runner/work/human-essentials/human-essentials/tmp/screenshots/failures_r_spec_example_groups_distributions_when_creating_a_distribution_from_a_donation_when_editing_that_distribution_user_creates_a_distribution_from_a_donation_then_edits_it_483.png

     # ./app/pdfs/distribution_pdf.rb:13:in `initialize'
     # ./app/mailers/distribution_mailer.rb:26:in `new'
     # ./app/mailers/distribution_mailer.rb:26:in `partner_mailer'
     # <internal:kernel>:90:in `tap'
     # ./app/jobs/partner_mailer_job.rb:6:in `perform'
     # ./app/controllers/distributions_controller.rb:205:in `send_notification'
     # ./app/controllers/distributions_controller.rb:136:in `update'
     # ------------------
     # --- Caused by: ---
     # Errno::ENOENT:
     #   No such file or directory @ rb_sysopen - /home/runner/work/human-essentials/human-essentials/tmp/storage/qy/8q/qy8qtup4tgfnfc7nljxlqlkp0j7j
     #   ./app/pdfs/distribution_pdf.rb:13:in `initialize'

  2) Distributions When creating a distribution from a donation when editing that distribution User creates duplicate line items
     Failure/Error: StringIO.open(organization.logo.download)

     ActiveStorage::FileNotFoundError:
       ActiveStorage::FileNotFoundError

     [Screenshot Image]: /home/runner/work/human-essentials/human-essentials/tmp/screenshots/failures_r_spec_example_groups_distributions_when_creating_a_distribution_from_a_donation_when_editing_that_distribution_user_creates_duplicate_line_items_7.png

     # ./app/pdfs/distribution_pdf.rb:13:in `initialize'
     # ./app/mailers/distribution_mailer.rb:26:in `new'
     # ./app/mailers/distribution_mailer.rb:26:in `partner_mailer'
     # <internal:kernel>:90:in `tap'
     # ./app/jobs/partner_mailer_job.rb:6:in `perform'
     # ./app/controllers/distributions_controller.rb:205:in `send_notification'
     # ./app/controllers/distributions_controller.rb:136:in `update'
     # ------------------
     # --- Caused by: ---
     # Errno::ENOENT:
     #   No such file or directory @ rb_sysopen - /home/runner/work/human-essentials/human-essentials/tmp/storage/qy/8q/qy8qtup4tgfnfc7nljxlqlkp0j7j
     #   ./app/pdfs/distribution_pdf.rb:13:in `initialize'

Finished in 2 minutes 12.6 seconds (files took 8.23 seconds to load)
118 examples, 2 failures, 1 pending

Failed examples:

rspec ./spec/system/distribution_system_spec.rb:[331](https://github.com/rubyforgood/human-essentials/actions/runs/3105923312/jobs/5032144011#step:7:332) # Distributions When creating a distribution from a donation when editing that distribution User creates a distribution from a donation then edits it
rspec ./spec/system/distribution_system_spec.rb:[354](https://github.com/rubyforgood/human-essentials/actions/runs/3105923312/jobs/5032144011#step:7:355) # Distributions When creating a distribution from a donation when editing that distribution User creates duplicate line items

Randomized with seed 59233

Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
Coverage report generated for RSpec to /home/runner/work/human-essentials/human-essentials/coverage. 2891 / 5149 LOC (56.15%) covered.
/opt/hostedtoolcache/Ruby/3.1.2/x64/bin/ruby -I/home/runner/work/human-essentials/human-essentials/vendor/bundle/ruby/3.1.0/gems/rspec-core-3.10.2/lib:/home/runner/work/human-essentials/human-essentials/vendor/bundle/ruby/3.1.0/gems/rspec-support-3.10.3/lib /home/runner/work/human-essentials/human-essentials/vendor/bundle/ruby/3.1.0/gems/rspec-core-3.10.2/exe/rspec  --default-path spec "spec/system/distribution_system_spec.rb" "spec/system/request_system_spec.rb" "spec/system/product_drive_system_spec.rb" "spec/system/vendor_system_spec.rb" "spec/system/donation_site_system_spec.rb" "spec/system/question_system_spec.rb" "spec/system/dashboard_system_spec.rb[1:2:1:1]" "spec/system/dashboard_system_spec.rb[1:2:4:1]" "spec/system/dashboard_system_spec.rb[1:2:6:7:1:1]" "spec/system/dashboard_system_spec.rb[1:2:4:10:1:1]" "spec/system/dashboard_system_spec.rb[1:2:5:5:1:2]" "spec/system/dashboard_system_spec.rb[1:2:5:8:1:2]" "spec/system/dashboard_system_spec.rb[1:2:5:3:1:3]" "spec/system/dashboard_system_spec.rb[1:2:3:4:1:1]" "spec/system/dashboard_system_spec.rb[1:2:5:7:1:3]" "spec/system/dashboard_system_spec.rb[1:2:6:3:1:1]" "spec/system/dashboard_system_spec.rb[1:2:5:2:1:2]" "spec/system/dashboard_system_spec.rb[1:2:3:1]" "spec/requests/transfers_requests_spec.rb" "spec/system/partners/helps_system_spec.rb" "spec/system/dashboard_system_spec.rb[1:2:5:11:1]" "spec/system/dashboard_system_spec.rb[1:2:6:1]" "spec/requests/requests_requests_spec.rb" "spec/requests/admin/account_requests_requests_spec.rb" "spec/requests/partners/user_requests_spec.rb" failed
Coverage report generated for RSpec to /home/runner/work/human-essentials/human-essentials/coverage. 28 / 8354 LOC (0.34%) covered.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
Error: Process completed with exit code 1.

Expected Behavior
The specs should always pass or always fail.
Steps To Reproduce
N/A
Environment
N/A

Criteria for Completion

[ ] The spec always passes or always fails.

Anything else?
There are some options that we could explore which would make this more resilent. Stubbing is an option that may better ensure that this doesn't occur randomly
Code of Conduct

[X] I've read the Code of Conduct and understand my responsibilities as a member of the Ruby for Good community

I'm unable to repro this, even with bundle exec rspec --bisect spec/system/distribution_system_spec.rb
Will attempt to review the examples manually and trace through where the errors might be occurring. @edwinthinks Is this limited to specific environments / situational?

It isn't clear, @armahillo; I've only personally seen it occur in CI.
A side note to your comment, I'am wondering if we want to redesign the test to be not dependent on a file to make this more resilent?

It isn't clear, @armahillo; I've only personally seen it occur in CI.

OK!

A side note to your comment, I'am wondering if we want to redesign the test to be not dependent on a file to make this more resilent?

Yeah that's what I was thinking too

@armahillo I was thinking maybe as a way to side step this issue is to avoid the DistributionPDF class by using the invoice theme - https://adminlte.io/themes/v3/pages/examples/invoice.html that they can print. What do you think?

Oh yeah I am always a fan of <link rel="stylesheet" media="print" type="text/css" src=".../path/to/print.css" />
I would consider this to be a non-trivial, but worthwhile conversion to explore.
One caveat I'd have is that the output becomes more client-dependent, and will require more extensive testing, particularly on non-desktop clients. But I don't think that should be an obstacle large enough to block this.

OK I was able to repro (sort of) by extracting
logo_image = if @organization.logo.attached?
<EMAIL_ADDRESS>                 else
                   Organization::DIAPER_APP_LOGO
                 end

to a private memoizing method and then raising the exception in it:
private
  def logo_image
    raise Errno::ENOENT
    @logo_image ||= if @organization.logo.attached?
<EMAIL_ADDRESS>                 else
                   Organization::DIAPER_APP_LOGO
                 end
  end

It's a little louder than it is in CI, but it will work for at least determining that the stubbing I'm about to do addresses the issue.
These tests are ambivalent to the mailer async jobs, so I'm going to stub out those schedule methods. I think this points to a separate issue of responsibilities (like, should schedule_reminder_email be in the controller or should it be in the service object?) but those are out of scope for this issue.
Attempting to stub it out and seeing if that addresses the issue.


The system cannot find the file specified. | A device attached to the system is not functioning.

can

you help i am getting that when

i dont know how i fix

also have same bug

I think hyperhide work only in intel

bcdedit /set testsigning on works only for the next reboot
in the BIOS need to disable virtualization and secure boot
And it must fix

But now I has BSOD =(


fix: alpha-1 faucets and explorer redirects

Describe the bug
The following sites need to be redirected to the Taiko main website as they are currently showing the site is unreachable.
https://l1faucet.a1.taiko.xyz/
https://l2faucet.a1.taiko.xyz/
https://l1explorer.a1.taiko.xyz/
https://l2explorer.a1.taiko.xyz/
Steps to reproduce
Steps to reproduce here.
Additional context
Additional context here.

Not sure what went wrong on GoDaddy, but I did create those CNAME redirects.

Should have been fixed.

Not sure if this is website or redirect issue. All 4 sites are showing this similar error. "This site can't be reached ... took too long to respond"

Not sure if this is website or redirect issue. All 4 sites are showing this similar error. "This site can't be reached ... took too long to respond"

only http is redirecting successfully http://l1faucet.a1.taiko.xyz/
https://l1faucet.a1.taiko.xyz/ is unreachable indeed

I went through this tesnet several times and got everything right, but my address is not in your list, please check  0x11b183eB85562eE448161fB57AB3De8d8b23644C


fix: toc links keep keyboard focus in firefox

fixes https://github.com/slidevjs/slidev/issues/499
Here is a PR if it is ok to fix it this way (explicit inline $event.target.blur()).
Maybe something more general would be needed, e.g., I can imagine focusing the slide div when navigation occurs.

I've found it while implementing another feature related to the TOC that it could be better to not use RouterLink at all, and rather do a <a @click="router.push({ path: item.path })"> because in some contexts blur() is not sufficient.
I'll make a PR later with the feature and a (coherent) fix replacing this one.


How to deal with large data flow output based ssh

If you want to output is completed, may have memory overflow, hoping to provide a way to handle the output stream

HI icanfly,
Thanks much for your question and interests in Parallec.  By default the response is not saved after the task complete, so there should not a be a problem. Unless your responses on a single task is bigger than the heap size

can you try it out and see if it working with your huge output?

Thanks much for your reply.
Okay, I admit that my goal is to return to a steady stream of data, such as the log flow, and perhaps my purpose is not the framework should be done.

sure. not a problem. have you considered using log stash etc for this?


Change the header to be fixed on top of the screen

A problem with back-navigation has been spottet, but could not be solved. Made a note in #10 .


Trouble building the library project and running tests

First, thank you guys for all of your hard work in creating this project!
I'm trying to build the Cuckoo framework project to run your test suite so I can learn more about it, but I'm having issues.
First, which branch should I be looking at if I'm currently targeting Swift 3.0 in my work? I'm having issues on the swift-3.0 branch:
/Users/{MY_USERNAME}/Library/Developer/Xcode/DerivedData/Cuckoo-fitysyqzshtoazefkaxqqwhmlhzj/Build/Intermediates/CodeCoverage/Intermediates/Cuckoo.build/Debug/CuckooTests.build/Script-1894D0F31C4D119A00879512.sh: line 2: /Users/{MY_USERNAME}/Library/Developer/Xcode/DerivedData/Cuckoo-fitysyqzshtoazefkaxqqwhmlhzj/Build/Intermediates/CodeCoverage/Products/Debug/cuckoo_generator.app/Contents/MacOS/cuckoo_generator: No such file or directory
Particulars:
XCode 8.2.2 beta / Swift 3

Hi, for Swift 3, use the master branch. Let me know if there's a problem. You can also join our Slack at http://swiftkit.brightify.org if you'd like to chat about it.

after our talk on slack today, here's the path the Generator scheme is building to:
~/Library/Developer/Xcode/DerivedData/Cuckoo-diftpaehsepkbidstgxwecowouvi/Build/Products/Debug/cuckoo_generator.app
which is different from what the run script expects at this time.

any update on this?

@daviskoh I have worked with @TadeasKriz for 0.11.3 which fixes this. At least it did for my team.
Can you try 0.11.3 and see if you're still seeing this issue? If not, I think we can close this issue.


Add 3 crawlers

This PR will detect:
CookieReports.com
GoogleCloudMonitoring
kube-probe

Awesome, thanks! 👍


The website is too slow

The website is basically just too slow tho my internet is fast and it's working normally I checked reddit and i found a post by a guy with the same issue and an admin ig said that it's gonna be fixed asap but that was from 2months so pls help

@unstableperson Can you please provide more details like 1) What feature/URL are you trying to access 2) Time frame 3) If possible please provide contest to issue (end to end use case).
if the issue still persist - Please gather HAR file using below steps.
Create HAR files with the following steps:

In your browser, press F12 to start the developer mode.
Switch to the 'Network' tab.
Check the Preserve log.
Open the page or repeat the workflow that should be investigated regarding performance. (Or just reload the slow page).
After the issue was reproduced, right-click on any line in the Network protocol.
Select "Save All As HAR", pick a location, and save the file.

Happy to help.

I think you're talking about probot.io, the Discord bot, not Probot, the framework for building GitHub bots. I'll close this unless you can describe this in more detail using our issue template.


feat: add prompt for confirmation to use dekick stop with --remove flag

It will be included in next release


Github pages doesn't redirect to CV

Hey, don't know if I'm doing something wrong. But my page is pointing to README instead of default CV.

@aramacs
Are GitHub Actions builds successful? Please tell me the URL of your repository. 😌

Didn't change anything on that part. This is my repo. I didn't push my language yet.
https://github.com/aramacs/cv-static

@aramacs
Are github actions targeted by pages in your settings?

It didn't. But I check now.

It still show the readme. Sorry for my poor skills.  It's my first time configure it a page here.

@aramacs
Could you please temporarily invite me as a contributor to your repository?

I'm doing right now. I'll be awesome to learn from you.


fix #2532, change different port

What is the purpose of the change
fix #2532, change different port
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #2551 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2551      +/-   ##
============================================
- Coverage     55.06%   54.98%   -0.09%
+ Complexity     5283     5277       -6
============================================
  Files           573      573
  Lines         25517    25517
  Branches       4531     4531
============================================
- Hits          14051    14030      -21
- Misses         9368     9384      +16
- Partials       2098     2103       +5

Impacted Files
Coverage Δ
Complexity Δ

...ache/dubbo/remoting/p2p/support/AbstractGroup.java
45.45% <0%> (-11.37%)
7% <0%> (-1%)

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
77.77% <0%> (-11.12%)
5% <0%> (-2%)

...he/dubbo/remoting/transport/netty/NettyClient.java
72.88% <0%> (-10.17%)
12% <0%> (-1%)

...onfig/spring/extension/SpringExtensionFactory.java
79.31% <0%> (-6.9%)
11% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
58.06% <0%> (-6.46%)
3% <0%> (ø)

...bo/remoting/transport/netty/NettyCodecAdapter.java
53.12% <0%> (-1.57%)
3% <0%> (ø)

...ache/dubbo/remoting/transport/mina/MinaClient.java
56.92% <0%> (-1.54%)
8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84410f7...d712d54. Read the comment docs.


How do i disable rotate and disable some icon?

I want to show onlye delete icon and disable rotate function.
Thank you.

It's my question too.


Integration Test - Release - 2019/02/03 07:02:51

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest2 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


/usr/local/bin/see 1.txt 2.txt

echo a > 1.txt
echo b > 2.txt
see 1.txt 2.txt

opens only 2.txt, am i missing something here?

Opens both for me, maybe you are overlooking a tab for 1.txt? If not more infos for reproduction would be great. E.g. the environment snippet from Help ▶ Report an issue…

      Model Name: MacBook Pro
      Model Identifier: MacBookPro11,4
      Processor Name: Intel Core i7
      Processor Speed: 2,5 GHz
      Number of Processors: 1
      Total Number of Cores: 4
      L2 Cache (per Core): 256 KB
      L3 Cache: 6 MB
      Memory: 16 GB
      Boot ROM Version: <IP_ADDRESS>.0
      SMC Version (system): 2.29f24

experimented a little bit more, dont make sense ...
mkdir somedir
touch somedir/1.txt somedir/2.txt
see somedir/1.txt somedir/2.txt # only 2.txt is opened
see somedir/1.txt # opens 1.txt
see somedir/2.txt # opens 2.txt
see somedir/1.txt somedir/2.txt # opens both 1.txt and 2.txt
???

Indeed. Seeing the same behaviour here. Will investigate. Sounds like a sandbox/security bookmark related issue. Thanks for the additional information!

Indeed. Somehow the first of multiple arguments does not get the right treatment. (incidentally a workaround for you is to give the first file again to the command line if this is essential for your current workflow)
e.g. this works
~/tmp$ touch a.txt b.txt c.txt
~/tmp$ see a.txt b.txt c.txt a.txt

Thanks for finding this one. Was an off by one error based on the fact that applescript is 1-indexed and not 0-indexed, even in the coco api.
You should be able to install and use the attached see tool until the next SubEthaEdit release.
see-tool.pkg.zip


Fix Location caching doesn't work (#1031)

Short Description:
Fix can't set attribute exception here:
self.position = (location_json['lat'],
                 location_json['lng'], 0.0)

Fixes:

#1031

I can confirm that this fixes the problem.

LGTM as well.

Good catch.


Need more precision in floating point number display

I need more than two digits of fraction in the floating point display. My project has small values which are being rounded and truncated too much and giving poor UX.
In the long run, the pre_format display option is meant to allow this to be customized. I know there are some concerns about which formatting language and library to use here.
In the short term, I need either a simpler deployment config option to adjust precision of the current rounding, or a hard-coded change to increase the rounding width to 4 fractional decimal digits (which would be good enough to address my current UX problem).
Right now, we have values like 0.001 and 0.007 being visible in recordedit app but being rounded to 0.00 and 0.01 in the record app.
@hongsudt  @robes

duplicate of #299.


Fix regex for usernames with underscores

With the current regex you can't use the chat commands /whisper, /block,
/mute ect on Players who have an underscore in their name. The %w
specifier is for alphanumberic characters only.
The regex (%w+_?%w+) is valid as usernames can have up to one underscore
and it can not be the first or last character in their name

Merging should be done by someone in the core script admin group FYI. This
merge seems fine, but in the future if you see a merge you feel good about
just let one of us know and we'll look at it.
On Fri, Mar 11, 2016 at 10:01 AM, ethankoester<EMAIL_ADDRESS>wrote:

Merged #335 https://github.com/ROBLOX/Core-Scripts/pull/335.
—
Reply to this email directly or view it on GitHub
https://github.com/ROBLOX/Core-Scripts/pull/335#event-586747814.

--
ben


Removing the use of the ioutil package

Description
The current minimum version of dapr is golang 1.18, which is no longer compatible with the previous version and can remove the marked deprecated functions.
Issue reference
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

The self-hosted test failure is not wrt to this change. merging PR.

@qiangmzsx Thanks for the contribution !


fix(artifacts): checksum the read-only staging copy instead of the original file

Fixes
Fixes WB-13354
Description

Check the size and MD5 checksum of a file after copying it to our staging area so that we can't be affected by an in-progress write from another process
Make the file read-only

Testing
How was this PR tested?
Checklist

[x] Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
[x] Ensure PR title compliance with the conventional commits standards

🤖 Generated by Copilot at bb38b7f

Copy local_file
Compute digest and size
Winter snow, no change

I think Anni wrote this staging-logic in this PR, but it looks like he wasn't worried about crazy multi-threaded race-condition overwrites mid-digest, so... yeah, I ain't worried, I retract my concern.

I think (but can't prove) that this can't happen in today's code, without extra convolutions like "the file gets rewritten twice but the second rewrite just reverts the first rewrite."
That said, this seems like a very theoretical concern, so, ✅

I agree–I think this is a way that can't fail in today's code that can fail with this change, and I'd be open to the opinion that the the failure mode of this behavior is worse.
Really, what should happen and just isn't supported by all platforms is that we atomically create a reflink and rely on CoW semantics. In the absence of reflinks there are a few other options that have their own failure modes:

move the file (the original copy disappears) and then copy the moved copy into the original's location. Con: we could clobber a simultaneous write to the original file
lock the file (varying support on different platforms) and prevent any other processes from accessing it. Cons: won't work on all platforms, will work differently on platforms it does work on, and will generally cause a competing process to crash


Openssl3 support

I think this plugin needs the same OpenSSL3 SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION option that homebridge-daikin-local has. Tried installing and got the following.
Thanks
[Outside Temperature] _doSendGetRequest: ERROR: API request to https://xx.xx.xx.xx/aircon/get_sensor_info returned error Error: write EPROTO 105014A2FFFF0000:error:0A000152:SSL routines:final_renegotiate:unsafe legacy renegotiation disabled:../deps/openssl/openssl/ssl/statem/extensions.c:922:

    at WriteWrap.onWriteComplete [as oncomplete] (node:internal/stream_base_commons:94:16) {
  errno: -71,
  code: 'EPROTO',
  syscall: 'write',
  response: undefined,
  retries: 0
}

true.

Fixed with version 1.0.1.


Player not dead after re-load

When the player dies and doesn't respawn before re-loading the game, they start alive but on 0 health.
How to reproduce

Load a world with Core enabled.
Die.
Exit to main menu without re-spawning.
Re-load game.

This is probably fixed by #3203 ? Which I think is ready for merge, just haven't had a chance to catch up with PRs for a while :/

@l0ftyWhizZ Did you get around to recreating your PR to fix this?

About to submit PR for this, in order to reproduce the bug I have to choose Exit Terasology instead of exiting to main menu.


CI release: activate windows builds

Yes finally wheels on Windows!
@jorisvandenbossche perhaps you may want to have a look here? There is still room for improving the way we build python wheels here, e.g.,

on windows choose the s2geometry version to install (require switching to vcpkg manifest mode if I understand well IIUC - a bit silly this cannot be done using the command line)
on macos / linux use vcpkg as well to install openssl, abseil and s2geometry (might allow using older macos deployment target? I haven't checked)

This can be done later, though (I already spent a lot of time on packaging).

Great!
Agreed that if it is working, this is more than good enough for now, and we can see to streamline the setup more in the future.

on macos / linux use vcpkg as well to install openssl, abseil and s2geometry (might allow using older macos deployment target? I haven't checked)

With pyogrio I have a good experience with using vcpkg for all platforms, so I would prefer that as well. Especially seeing the hoops you had to go through to get all dependencies properly installed in the end in https://github.com/benbovy/spherely/pull/35/, I was already wondering if vcpkg wouldn't make that easier (but that is not a given, of course .. ;))
One annoyance with the vcpkg setup is of course that s2geography is not included and so requires to still have some custom install script anyway. I don't know how easy it is to add a package to vcpkg upstream, but we could also have a local "overlay port" (https://learn.microsoft.com/en-us/vcpkg/concepts/overlay-ports), which might simplify to integrate s2geography in a full vcpkg workflow.
Essentially that requires writing just a portfile.cmake for s2geography, and the one for s2geometry looks like this: https://github.com/microsoft/vcpkg/blob/master/ports/s2geometry/portfile.cmake (and I think for s2geography it would be very similar)
But all ideas for later ;)

Caching seems to work well.

Thanks Joris!


"cookie-composer update" did not updated the template layers of a project created from an old version of the template composition

cookie-composer version: 0.11.0
Python version: 3.11.0
Operating System: Linux 631c6f7e8441 5.15.0-82-generic #91-Ubuntu SMP Mon Aug 14 14:14:14 UTC 2023 x86_64 GNU/Linux

Description
First of all, I'd like to congratulate Calloway's team for providing this tool to the Python community. I believe it will be very useful to keep the many projects out there with less effort in the boilerplate part of the code base.
Now, about the issue... I'm testing the tool before using in a real case. My test has three steps:

Create a project with the template composition of https://github.com/coordt/cookiecomposer-templates, using the old version from commit 6a6d3c7cef1d5b2daabe9f749057dd6fe2875f67;
Update the project with the latest version of the template composition.
Since, I create the project with an old version of the template composition, I expected cookie-composer to update the template in step 2, but it said that all layers were up-to-date.

What I Did
I've executed the commands as follows:
user@631c6f7e8441:/tmp/teste$ curl https://raw.githubusercontent.com/coordt/cookiecomposer-templates/master/package-composition.yaml > package-composition.yaml
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   603  100   603    0     0   1477      0 --:--:-- --:--:-- --:--:--  1481
user@631c6f7e8441:/tmp/teste$ cookie-composer create --checkout=6a6d3c7cef1d5b2daabe9f749057dd6fe2875f67 package-composition.yaml
You've downloaded /home/user/.cookiecutters/cookiecomposer-templates before. Is it okay to delete and re-download it? [yes]:
project_name [python-boilerplate]:
project_slug [python_boilerplate]:
friendly_name [Python Boilerplate]:
project_short_description []:
version [0.1.0]:
author [Who am I?]:
email<EMAIL_ADDRESS>
github_user [whoami]:
You've downloaded /home/user/.cookiecutters/cookiecomposer-templates before. Is it okay to delete and re-download it? [yes]:
You've downloaded /home/user/.cookiecutters/cookiecomposer-templates before. Is it okay to delete and re-download it? [yes]

The .composition.yaml file was generated with the correct commit, as follows:
user@631c6f7e8441:/tmp/teste$ cat python-boilerplate/.composition.yaml
checkout: 6a6d3c7cef1d5b2daabe9f749057dd6fe2875f67
commit: 6a6d3c7cef1d5b2daabe9f749057dd6fe2875f67
context:
  _copy_without_render:
  - .github/**/*.jinja
  _dev_requirements:
    bump2version: '>=1.0.1'
    generate-changelog: '>=0.7.6'
    git-fame: '>=1.12.2'
    pip-tools: ''
  _prod_requirements:
    environs: '>=9.3.5'
  _test_requirements:
    black: '>=19.10b0'
    coverage: '>=6.1.2'
    flake8: '>=4.0.1'
    pre-commit: '>=2.15.0'
    pytest: '>=6.0.0'
    pytest-cov: '>=3.0.0'
  author: Who am I?
  email<EMAIL_ADDRESS>  friendly_name: Python Boilerplate
  github_user: whoami
  project_name: python-boilerplate
  project_short_description: ''
  project_slug: python_boilerplate
  version: 0.1.0
directory: cookiecutter-boilerplate
merge_strategies:
  '*.json': comprehensive
  '*.yaml': comprehensive
  '*.yml': comprehensive
no_input: false
overwrite: []
overwrite_exclude: []
password: null
skip_generation: []
skip_hooks: false
skip_if_file_exists: false
template: https://github.com/coordt/cookiecomposer-templates
---
checkout: 6a6d3c7cef1d5b2daabe9f749057dd6fe2875f67
commit: 6a6d3c7cef1d5b2daabe9f749057dd6fe2875f67
context:
  _copy_without_render:
  - docsrc/**/*.rst
  _dev_requirements: {}
  _docs_requirements:
    Sphinx: '>=4.3.0'
    furo: ''
    ghp-import: ''
    linkify-it-py: ''
    myst-parser: ''
    sphinx-autodoc-typehints: ''
    sphinx-click: ''
    sphinx-copybutton: ''
  _prod_requirements: {}
  _test_requirements:
    black: '>=19.10b0'
    coverage: '>=6.1.2'
    flake8: '>=4.0.1'
    pre-commit: '>=2.15.0'
    pytest: '>=6.0.0'
    pytest-cov: '>=3.0.0'
  author: Who am I?
  email<EMAIL_ADDRESS>  friendly_name: Python Boilerplate
  github_user: whoami
  project_name: python-boilerplate
  project_short_description: ''
  project_slug: python_boilerplate
  version: 0.1.0
directory: cookiecutter-package
merge_strategies:
  '*.json': comprehensive
  '*.yaml': comprehensive
  '*.yml': comprehensive
no_input: false
overwrite: []
overwrite_exclude: []
password: null
skip_generation: []
skip_hooks: false
skip_if_file_exists: false
template: https://github.com/coordt/cookiecomposer-templates
---

However, when I ran the update command, cookie-composer gave the feedback that all layers were up-to-date.
user@631c6f7e8441:/tmp/teste/python-boilerplate$ cookie-composer update
You've downloaded /home/user/.cookiecutters/cookiecomposer-templates before. Is it okay to delete and re-download it? [yes]:
You've downloaded /home/user/.cookiecutters/cookiecomposer-templates before. Is it okay to delete and re-download it? [yes]:
You've downloaded /home/user/.cookiecutters/cookiecomposer-templates before. Is it okay to delete and re-download it? [yes]:
All layers are up-to-date.

Sorry for the delayed response. I swear GitHub makes it hard to notice when issues are raised.
I'll schedule this work soon (probably this weekend, Sep 9/10).

Just a quick update: I've found what was causing the issue. It was always comparing itself to the same commit on the template.
That said, the method you used above to test would not work exactly. The "checkout" flag is usually meant for branches, in that when the repo template is cloned, it check out the reference of "checkout". You would have to empty it from .composition.yaml file after you first generated the new repo.
That said, I hit another snag. The UI experience. With the way that cookiecutter handles things, the update process will ask you all the prompts, with the appropriate answers as the default. I think it is better if it only prompts for new things.
So I'm doing a bit of a refactor.

Hi @coordt , thanks for the feedkback!
Regarding what you said about "checkout" parameter, I've forked https://github.com/coordt/cookiecomposer-templates, created the "test" branch, and adjusted package-composition.yaml to test again.
Once you are done with that changes, I'll follow the steps below.
pip install --upgrade cookie-composer
mkdir /tmp/test
cd /tmp/test
curl https://raw.githubusercontent.com/dinaldoap/cookiecomposer-templates/test/package-composition.yaml > package-composition.yaml
cookie-composer create --checkout=test package-composition.yaml
# Update template by adding a new section into https://github.com/dinaldoap/cookiecomposer-templates/blob/test/cookiecutter-package/%7B%7Bcookiecutter.project_name%7D%7D/README.md
cd python-boilerplate
cookie-composer update

Please, keep me noticed if you find another misuse of "cookie-composer".

@dinaldoap Thanks for your patience on this issue. It was a bigger undertaking than expected.
I believe things are fixed, but I created a dev release so you might test it out.
Let me know if it works and I'll merge the PR.

Hi, @coordt . Thanks for your fix! It worked like a charm when I referred to the template on the master branch.
I'v done the following steps to test that dev release:
pip install cookie-composer==0.11.0rc52.dev56
mkdir /tmp/test
cd /tmp/test
curl https://raw.githubusercontent.com/dinaldoap/cookiecomposer-templates/master/package-composition.yaml > package-composition.yaml
cookie-composer create package-composition.yaml
# Update template by adding a new section into https://github.com/dinaldoap/cookiecomposer-templates/blob/master/cookiecutter-package/%7B%7Bcookiecutter.project_name%7D%7D/README.md
cd python-boilerplate
cookie-composer update

The output was as expected and README.md was updated:
(venv) user@docker:/tmp/test/python-boilerplate$ cookie-composer update
Attempting to apply patch with 3-way merge.
Patch applied successfully.

\o/

Hi, @coordt . Your fix solves the main problem and I'm able to move forward to integrate cookie-composer to my template. However, I believe I should give an additional feedback here and wait for your thoughts. I don't if this is a topic for another issue...
I've tested that dev release with the same template in another branch (https://github.com/dinaldoap/cookiecomposer-templates/tree/test). The used command and the traceback are as follows:
(venv) user@docker:/tmp/test$ cookie-composer create --checkout=test package-composition.yaml
  [1/8] project_name (python-boilerplate):
  [2/8] project_slug (python_boilerplate):
  [3/8] friendly_name (Python Boilerplate):
  [4/8] project_short_description ():
  [5/8] version (0.1.0):
  [6/8] author (Who am I?):
  [7/8] email (whoami@existential-crisis.doom):
  [8/8] github_user (whoami):
Traceback (most recent call last):
  File "/workspace/cookiecutter-python-vscode-github/.venv/bin/cookie-composer", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/rich_click/rich_command.py", line 126, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/cookie_composer/cli.py", line 127, in create
    create_cmd(
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/cookie_composer/commands/create.py", line 66, in create_cmd
    rendered_layers = render_layers(composition.layers, output_dir, no_input=no_input, accept_hooks=accept_hooks)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/cookie_composer/layers.py", line 370, in render_layers
    rendered_layer = render_layer(
                     ^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/cookie_composer/layers.py", line 280, in render_layer
    with layer_config.template.repo.render_source(commit=commit) as repo_dir:
  File "/usr/local/lib/python3.11/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/cookie_composer/templates/types.py", line 114, in render_source
    with temp_git_worktree_dir(
  File "/usr/local/lib/python3.11/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/cookie_composer/git_commands.py", line 219, in temp_git_worktree_dir
    repo.git.worktree(
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/git/cmd.py", line 736, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/git/cmd.py", line 1316, in _call_process
    return self.execute(call, **exec_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/cookiecutter-python-vscode-github/.venv/lib/python3.11/site-packages/git/cmd.py", line 1111, in execute
    raise GitCommandError(redacted_command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git worktree add /tmp/tmpnv7_qulm test
  stdout: 'Preparing worktree (checking out 'test')'
  stderr: 'fatal: 'test' is already checked out at '/home/user/.cookiecutters/cookiecomposer-templates_test''

What do you think?

Your issue is related to the changes I made. There must be an issue when creating a project with a checkout  option. The new process for generating and merging layers uses git worktrees. I'll put in a test for this and get it fixed. It shouldn't take much time (famous last words...)

@dinaldoap Try https://pypi.org/project/cookie-composer/0.11.0rc52.dev57/

Hi, @coordt . I've executed the same tests and they all succeeded. :+1:
Thanks for your attention!


Any plans for macOS?

Hey Andrew.
Thanks for such a great library. Do you have any plans for porting it to macOS?

macOS support was added in PR #6

Merged #6 to add macOS support.  Thank you, @yangyubo!


iOS: ACSException - Attempting to get event handler for a cookie which was never added.

Hello!
I put the AzureCalling code in an iOS app and it works for the most part. However, sometimes (~50%) I have a crash when I hang up the call. See stack trace below. Does anyone else have this problem or am I missing something? I get almost the same crash every now and then when answering a call (~10%).

2022-07-04 12:51:54.006 DentalCoach.iOS[50485:11389458] Unhandled managed exception: Objective-C exception thrown.  Name: ACSException Reason: Attempting to get event handler for a cookie which was never added.
Native stack trace:
	0   CoreFoundation                      0x00000001833f129c 5198FB57-5645-3B34-A49F-F32B52256CF3 + 627356
	1   libobjc.A.dylib                     0x000000019c0eb744 objc_exception_throw + 60
	2   CoreFoundation                      0x0000000183448390 5198FB57-5645-3B34-A49F-F32B52256CF3 + 983952
	3   AzureCommunicationCalling           0x0000000109f39a5c +[ACSProjectedObjectEventHandlerCache getEventHandler:isEventPublic:] + 232
	4   AzureCommunicationCalling           0x0000000109f38f50 __static_remoteParticipantOnVideoStreamsUpdated_block_invoke + 76
	5   AzureCommunicationCalling           0x0000000109f3939c +[ACSProjectedObjectCache getOrCreate:factoryBlock:] + 236
	6   AzureCommunicationCalling           0x0000000109f32458 static_remoteParticipantOnVideoStreamsUpdated + 100
	7   AzureCommunicationCalling           0x0000000109fb3238 _ZN22sam_remote_participant24updateAndRaiseVideoEventEjj + 336
	8   AzureCommunicationCalling           0x0000000109fb5204 _ZN23sam_remote_video_stream27timerForRemovedEventExpiredEN2rt12IntrusivePtrIS_EE + 364
	9   AzureCommunicationCalling           0x0000000109fb5954 _ZN3auf3VarIM23sam_remote_video_streamFvN2rt12IntrusivePtrIS1_EEERS1_JRS4_EE8dispatchEv + 60
	10  AzureCommunicationCalling           0x000000010b31b620 _ZN3auf12TimerHandler16callExpiredTimerERNS_22SignalAndReleaseAtLastE + 88
	11  AzureCommunicationCalling           0x000000010b32020c _ZN3auf4priv13MRMWTransport11tryDispatchEPNS_11IDispatcherE + 136
	12  AzureCommunicationCalling           0x000000010b31a8dc _ZN3auf17StrandExecutorImp11tryDispatchEPNS_11IDispatcherE + 24
	13  AzureCommunicationCalling           0x000000010b31a754 _ZN3auf17StrandExecutorImp13depleteStrandEN2rt12IntrusivePtrIS0_EE + 84
	14  AzureCommunicationCalling           0x000000010b31ab80 _ZN3auf8internal12async_method5applyIRNS_17StrandExecutorImpEMS3_FvN2rt12IntrusivePtrIS3_EEENSt3__15tupleIJS7_EEEJLm0EEEEDTcldsclsr3stdE7forwardIT_Efp_Efp0_spscNS0_19async_required_castIXT2_EN3spl8internal16inspect_callableIT0_E3get10args_tupleET1_E4typeEclsr3stdE3getIXT2_EEfp1_EEEOSD_SI_RSL_NSG_3seqIJXspT2_EEEE + 56
	15  AzureCommunicationCalling           0x000000010b319904 _ZN3auf24NativeThreadPoolExecutor20callFromNativeWorkerEPN3spl7VarBaseEPv + 56
	16  AzureCommunicationCalling           0x000000010b319a6c ___ZN3spl4priv23NativeThreadPoolManager8dispatchERKDnP16dispatch_queue_sPFvPNS_7VarBaseEPvES7_S8__block_invoke + 48
	17  libdispatch.dylib                   0x0000000183056e6c 355ACCF4-3917-3730-BC55-EF7003887ABE + 7788
	18  libdispatch.dylib                   0x0000000183058a30 355ACCF4-3917-3730-BC55-EF7003887ABE + 14896
	19  libdispatch.dylib                   0x000000018306a280 355ACCF4-3917-3730-BC55-EF7003887ABE + 86656
	20  libdispatch.dylib                   0x000000018306a96c 355ACCF4-3917-3730-BC55-EF7003887ABE + 88428
	21  libsystem_pthread.dylib             0x00000001f4534080 _pthread_wqthread + 228
	22  libsystem_pthread.dylib             0x00000001f4533e5c start_wqthread + 8
 (Foundation.MonoTouchException)

=================================================================
	Native Crash Reporting
=================================================================
Got a abrt while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================

=================================================================
	Native stacktrace:
=================================================================
	0x106f3d930 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x106f33a7c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x106f3ce78 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x10b2aa924 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN3spl4privL27logCriticalBackTraceHandlerEiP9__siginfoPv
	0x1f452cc10 - /usr/lib/system/libsystem_platform.dylib : <redacted>
	0x1f453a3bc - /usr/lib/system/libsystem_pthread.dylib : pthread_kill
	0x18e4f7524 - /usr/lib/system/libsystem_c.dylib : abort
	0x1070f869c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : xamarin_find_protocol_wrapper_type
	0x106f9e318 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : mono_pmip
	0x106f33484 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x106f31e58 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x106f27b58 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x10502ec2c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x10700ab98 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : mono_pmip
	0x1070f8370 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : xamarin_get_block_descriptor
	0x1070f81a4 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : xamarin_get_block_descriptor
	0x1070f815c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : xamarin_get_block_descriptor
	0x106f329dc - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x106f31e58 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x106f27b58 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x10502ec2c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x10510a690 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x105106454 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x10516bb10 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : _ZN7plcrash2MS5async24dwarf_cfa_state_iteratorIyxE4nextEPjPNS1_28plcrash_dwarf_cfa_reg_rule_tEPy
	0x1070f4f1c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : xamarin_get_block_descriptor
	0x1070f8e00 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/DentalCoach.iOS : xamarin_find_protocol_wrapper_type
	0x183472520 - /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : <redacted>
	0x19c0f1c5c - /usr/lib/libobjc.A.dylib : <redacted>
	0x19c1f5f18 - /usr/lib/libc++abi.dylib : <redacted>
	0x19c1f8c1c - /usr/lib/libc++abi.dylib : __cxa_get_exception_ptr
	0x19c1f8bc8 - /usr/lib/libc++abi.dylib : <redacted>
	0x19c0eb8ac - /usr/lib/libobjc.A.dylib : objc_exception_throw
	0x183448390 - /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : <redacted>
	0x109f39a5c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : +[ACSProjectedObjectEventHandlerCache getEventHandler:isEventPublic:]
	0x109f38f50 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : __static_remoteParticipantOnVideoStreamsUpdated_block_invoke
	0x109f3939c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : +[ACSProjectedObjectCache getOrCreate:factoryBlock:]
	0x109f32458 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : static_remoteParticipantOnVideoStreamsUpdated
	0x109fb3238 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN22sam_remote_participant24updateAndRaiseVideoEventEjj
	0x109fb5204 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN23sam_remote_video_stream27timerForRemovedEventExpiredEN2rt12IntrusivePtrIS_EE
	0x109fb5954 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN3auf3VarIM23sam_remote_video_streamFvN2rt12IntrusivePtrIS1_EEERS1_JRS4_EE8dispatchEv
	0x10b31b620 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN3auf12TimerHandler16callExpiredTimerERNS_22SignalAndReleaseAtLastE
	0x10b32020c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN3auf4priv13MRMWTransport11tryDispatchEPNS_11IDispatcherE
	0x10b31a8dc - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN3auf17StrandExecutorImp11tryDispatchEPNS_11IDispatcherE
	0x10b31a754 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN3auf17StrandExecutorImp13depleteStrandEN2rt12IntrusivePtrIS0_EE
	0x10b31ab80 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN3auf8internal12async_method5applyIRNS_17StrandExecutorImpEMS3_FvN2rt12IntrusivePtrIS3_EEENSt3__15tupleIJS7_EEEJLm0EEEEDTcldsclsr3stdE7forwardIT_Efp_Efp0_spscNS0_19async_required_castIXT2_EN3spl8internal16inspect_callableIT0_E3get10args_tupleET1_E4typeE
	0x10b319904 - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : _ZN3auf24NativeThreadPoolExecutor20callFromNativeWorkerEPN3spl7VarBaseEPv
	0x10b319a6c - /private/var/containers/Bundle/Application/4B928FA2-5296-4AED-9BB2-A384DAB484EC/DentalCoach.iOS.app/Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling : ___ZN3spl4priv23NativeThreadPoolManager8dispatchERKDnP16dispatch_queue_sPFvPNS_7VarBaseEPvES7_S8__block_invoke
	0x183056e6c - /usr/lib/system/libdispatch.dylib : <redacted>
	0x183058a30 - /usr/lib/system/libdispatch.dylib : <redacted>
	0x18306a280 - /usr/lib/system/libdispatch.dylib : <redacted>
	0x18306a96c - /usr/lib/system/libdispatch.dylib : <redacted>
	0x1f4534080 - /usr/lib/system/libsystem_pthread.dylib : _pthread_wqthread
	0x1f4533e5c - /usr/lib/system/libsystem_pthread.dylib : start_wqthread

=================================================================
	Basic Fault Address Reporting
=================================================================
Memory around native instruction pointer (0x1bae2db38):0x1bae2db28  ff 0f 5f d6 c0 03 5f d6 10 29 80 d2 01 10 00 d4  .._..._..)......
0x1bae2db38  03 01 00 54 7f 23 03 d5 fd 7b bf a9 fd 03 00 91  ...T.#...{......
0x1bae2db48  a6 ed ff 97 bf 03 00 91 fd 7b c1 a8 ff 0f 5f d6  .........{...._.
0x1bae2db58  c0 03 5f d6 7f 23 03 d5 fd 7b bf a9 fd 03 00 91  .._..#...{......

=================================================================
	Managed Stacktrace:
=================================================================
=================================================================

I have seen this, but its been a while...
Like @andersonvieiragomeslopes , i think its due to lacking cleanup, but not sure...
My cleanup code has been through some iterations, and at the moment it looks almost like andersons,
except I also dispose the callagent, that might not be an option for you...
I also set every local to null and also cleanup event listeners.
I reported a bug to ms on this, at least i think its the same:
https://github.com/Azure/Communication/issues/440

Thank you for the reply's!

Do your calls have video or are they just audio?

I'm using video

Did you use the methods in the example to end the call?

Yes I did!

Do you have the latest (<IP_ADDRESS>) version of the sdk?

I'm using 2.2.0-beta 1.4 (released for other bugfix) will try <IP_ADDRESS> now

Does the problem occur on the first call after starting the app or on all calls?

Yes it also happens from the first call, both answering and hanging up the call

I also set every local to null and also cleanup event listeners.

I'll try also today, hope it helps :-)

@jveenhuizen some more details here:
https://github.com/Azure/Communication/issues/423

Updated to <IP_ADDRESS>, added null checks and did some more cleanups. I haven't seen it since... fingers crossed I think?

hehe, programming and religion shouldn't be this similar, but sometimes all we can do is thoughts and prayers... keeping this open for a while, let me know if it happens again!

Assuming this is fixed since it is not occuring anymore, feel free to reopen if its still a problem


OCPBUGS-6644: Add assets after manual merge 4.13

Backport of #162

/jira refresh

/label backport-risk-assessed
/lgtm

OCPBUGS-12996 is not fixed, will review this PR when the OCPBUGS-12996 is fixed

tested with PR, issue is not fixed, details please see from bug OCPBUGS-6644


"illegal generic type for instanceof" since 1.10.6

Happens in the mergeFrom(Foo value) method when the value type with generics. Here is the generated code:
    if (value instanceof Foo_Builder.Value<R> && resources == ImmutableList.<R>of()) {
      resources = value.getResources();
    } else {
      addAllResources(value.getResources());
    }

I suppose this code here generates it:
https://github.com/google/FreeBuilder/blob/28591b548edba0ac280afb610b08b13ebc011f9f/src/main/java/org/inferred/freebuilder/processor/ListPropertyFactory.java#L407
And analogous for Sets.

Thanks for the bug report! Could you see if this is fixed in v1.12.1-rc1, please?

Doesn't seem like it is.

Can you give me an example to produce the bug, please?

Here it is:
@FreeBuilder
public abstract class Page<R> {

  public abstract ImmutableList<R> getResources();

  public static class Builder<R> extends Page_Builder<R> {
  }
}

Could you try v1.12.2-rc1 for me?

With v1.12.2-rc1 it compiles. Thanks.

Fix released as v1.12.2.


Agility plugin- colour overlay for obsticles beyond your level

Please add in an additional colour overlay.  I love how all the obstacles, shortcuts, and traps light up with the Agility plugin.  I would like this new suggested overlay (purple, blue, ?) to show that the short cut is too advanced for your skill level.
I think this would be rather useful to have ability to identify shortcuts that are too advanced for you.

Duplicate


Monitor kubemark master's components via Prometheus.

This includes kubelet, kubelet/cadvisor, kube-scheduler, kube-controller-manager.
Ref. https://github.com/kubernetes/perf-tests/issues/503

/lgtm
/approve

@wojtek-t, needed to rebase, could you lgtm again?

/assign @mborsz

/lgtm


Error: <class 'django.urls.exceptions.NoReverseMatch'>

After upgrading Netbox to the latest version Im getting this error:
`<class 'django.urls.exceptions.NoReverseMatch'>
Reverse for 'rack_elevation_list' with arguments '()' and keyword arguments '{}' not found. 0 pattern(s) tried: []`

Thank you for your interest in NetBox. We require that all issues be submitted using the template provided here. This is to ensure that only valid issues are reported and that each issue includes all the information necessary for a developer to act on it. Please update your issue so that it matches the template (this may require rewriting your issue entirely). This issue will be closed in one week if it has not been updated. Thanks!


Panic on referencing mod with empty file

Possibly related to #331.
Tested with 7ae984f.
$ touch foo.rs
$ echo "mod f" > test.rs
$ racer complete 1 5 test.rs
PREFIX 4,5,f
MATCH flate,1,0,c:/projects/rust/rustc-1.3-beta-src/src\libflate\lib.rs,Module,flate
MATCH fmt_macros,1,0,c:/projects/rust/rustc-1.3-beta-src/src\libfmt_macros\lib.rs,Module,fmt_macros
thread '<main>' panicked at 'called `Option::unwrap()` on a `None` value', ../src/libcore\option.rs:
363

Seems that "mod f" (in the process of typing "mod foo;") will cause racer to load foo.rs, which is an empty file, and then it unwraps something it shouldn't.

Hi @JoshBlake,
I'm not getting this error. E.g.
$ touch foo.rs
$ echo "mod f" > test.rs
$ /home/pld/src/rust/racer/target/release/racer complete 1 5 test.rs
PREFIX 4,5,f
MATCH fmt_macros,1,0,/usr/local/src/rust/src/libfmt_macros/lib.rs,Module,fmt_macros
MATCH flate,1,0,/usr/local/src/rust/src/libflate/lib.rs,Module,flate
END

Maybe it is fixed by a subsequent patch. Can you re-open this if not.
Thanks!