Remove restriction on maximum number of core events

Currently we have hard limit on how many core PMU events Kernel Driver can count (and multiplex). In some situations number of core events can be insufficient.
[FutureDev] Arm Telemetry Solution metrics and other methodologies keep evolving we would need to be able to handle more events. In theory CPUs can have up to 31 GPCs (General Purpose Counters).
Number of events is specified with wperf padding algorithm, see ….. and with CLI (using -e).
wperf stat -e e0,e1,e2,e3.....,e127

Background
Currently we allocate up to MAX_MANAGED_CORE_EVENTS for user events, see https://gitlab.com/Linaro/WindowsPerf/windowsperf/-/blob/main/wperf-common/macros.h?ref_type=heads#L46:
wperf-common/macros.h:46:#define MAX_MANAGED_CORE_EVENTS             128

This is not as flexible solution and can be changed so that we can dynamically allocate number of events.
Notes:

How we “squeeze” events to event structure and send it via IOCTRL is implemented with “padding algorithm”, see https://gitlab.com/Linaro/WindowsPerf/windowsperf/-/blob/main/wperf-test/wperf-test-padding.cpp?ref_type=heads#L57.

We do not need to change padding algorithm. But MAX_MANAGED_CORE_EVENTS may impact this algorithm.

See DeviceAsyncIoControl API in wperf to see how we send IOCTRL to the driver and tract the flow from there. Use logs from https://linaro.atlassian.net/browse/WPERF-968to reason about flow of the IOCTRLs.

Definition of done

High level: Replace all fixed data structures which use MAX_MANAGED_CORE_EVENTS with dynamic allocation.

We can keep static max core event support value but we can increase it to e.g. 512. So:

MAX_MANAGED_CORE_EVENTS would be 512 and new value of
“max core events per IOCTRL transfer” will be used to slice:

total number of events defined with -e <EVENTS_LIST> into separate IOCTRL packets what are sent to the driver from the wperf app.

See:

PMU_CTL_ASSIGN_EVENTS IOCTRL message.
void pmu_device::events_assign(uint32_t core_idx, std::map<enum evt_class, std::vector<struct evt_noted>> events, bool include_kernel) function.

total number of events' counts sent back to the app from the driver.

See:

PMU_CTL_READ_COUNTING IOCTRL message.
void pmu_device::core_events_read() function.

Use ENABLE_MAX_CORE_EVENTS macro to enable / disable in code this feature. See how we use e.g. ENABLE_SPE to weave in SPE features.

This should apply to both wperf-driver and wperf.
Update supporting macros used to create static WindowsPerf Feature string based on macros defined during compilation. See https://gitlab.com/Linaro/WindowsPerf/windowsperf/-/blob/main/wperf-common/public_ver.h?ref_type=heads#L54  -

This was investigated by Kush and we have internal Wiki page with this design.


⚠ Bofrost.at has degraded performance

In 027bb4b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1849 ms

Resolved: Bofrost.at performance has improved in a073a6e.


bug: Empty query results in Jupyter

Description
Running through a user study in vanilla Jupyter the data tab wasn't rendered in Jupyter. Other tabs (schema, details, etc) were shown, but not the data. Additionally, the response object's dataframe attribute was None.

@kerinin do you have any additional information to reproduce this bug? The expected behavior for a query producing no results is to render a data frame with 0 rows. Something like this is the expected user experience:

This is no longer a problem. Verified in the latest ecommerce using the latest kaskada version.


Companion Triggers won't work

Despite all connection being ok, triggers won't work. Obviously same for StreamDeck. What happened, what changed?
I'm on Companion v2.4.2 and updated MixEffect on iPad/iPhone

Are you using the MixEffect Companion Profile or are you adding your own buttons? if the former, re-import the profile. If the latter, make sure that your target IP addresses are correct. Also, if you have multiple instances of MixEffect running at the same time on an iPad, the two instances trying to run an OSC server may conflict with each other. Post some screenshots of your set up if you continue to have problems.


Change license

The upstream lead author has changed the license from LGPL to BSD3.
I would capture this modification.
@heuristicus

Merged upstream and updated package.xml and readme to reflect this change.


Show loading message, structure in way that adding dynamic informatio…

…n when reconnecting is trivial, for example reconnecting times

Looks ok. Good to merge?

OK, please merge ~ and create a card for the silent retry with interval ~


rename variable to kafkaTopic to avoid obfuscate

Codecov Report

Merging #39 (7d4a98d) into main (bb27472) will not change coverage.
The diff coverage is 48.14%.

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   59.45%   59.45%
=======================================
  Files          11       11
  Lines         841      841
=======================================
  Hits          500      500
  Misses        278      278
  Partials       63       63

Impacted Files
Coverage Δ

pkg/kafsar/kafka_impl.go
44.25% <35.29%> (ø)

pkg/utils/pulsar_util.go
58.22% <70.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb27472...7d4a98d. Read the comment docs.


Add WebSDK version update 12/13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


JS accumulate: Fix order of actual/expected in tests.

Thanks! Would you mind rebasing onto master to get rid of the merge commit?

Done ( :
Starting Hack Reactor tomorrow so I expect to be too busy to help out anymore. :_( Good luck on this site, @kytrinyx !

Best of luck at Hack Reactor! Thanks so much for pitching in :heart:


Make syntax of config yaml file entries consistent

We use different types of syntax in the config yaml file.
here is a short clip of the yaml file showing the different types of syntax we use.
  - input: bytes
    output: all
    type: add_if
    parameters: '>=0'
  - input: dstIP
    output: dstLocation
    type: add_location
    parameters: ""
type: network

extract:
aggregates:

Name: bandwidth_network_service
By:

service
Operation: sum
RecordKey: bytes

We should strive to have a uniform type of syntax for the different parts of the yaml file.

@KalmanMeth I think #213 has addressed this issue


Help users resolve 'Udon C# Program Asset is null' error

Feature Description:
Users often create empty Udon C# Program Assets. This prevents UdonSharp from compiling.
Users often do not understand the error. Possible reasons:

They're inexperienced with UdonSharp
They received their UdonSharp assets from someone else
They created the Asset on accident and forgot about it
Double-clicking the error does not highlight the asset (Unconfirmed)

Regardless, we should help users identify the issue, and suggest a solution.
For example:

The error should indicate that the file should either be deleted, or a source C# script should be added
The error could be downgraded to a warning, as was the case before U# 1.0

Is there any update to this? I made the mistake of migrating my Unity project to VCC, and all of the sudden my UdonSharp is broken and so are my worlds which I can no longer fix or update.
I noticed my UdonGraphs were fine, but any instance of an UdonSharp script were screwed. So I deleted them all. I now have zero items with UdonSharp scripts on them, and yet, no matter which Scene I open in the entire project, I'm told there's a "Cube(2)" with a null script. There isn't a single "Cube(2)" in any scene in the entire Project. It makes no sense. Two feels of failed attempts to fix now.

You may have a prefab named that which you need to update. You can try re-migrating the old version of your project that VCC leaves. This issue doesn't seem relevant to your problem though and sounds more like Unity just broke during migration.

Feature Description: Users often create empty Udon C# Program Assets. This prevents UdonSharp from compiling. Users often do not understand the error. Possible reasons:

They're inexperienced with UdonSharp
They received their UdonSharp assets from someone else
They created the Asset on accident and forgot about it
Double-clicking the error does not highlight the asset (Unconfirmed)

Regardless, we should help users identify the issue, and suggest a solution.
For example:

The error should indicate that the file should either be deleted, or a source C# script should be added
The error could be downgraded to a warning, as was the case before U# 1.0

I am actually in this very position, I am completly new to creating a world, and I grabbed a bunch of prefabs to throw into my world and for the most part they work, except for a prefab bowling lane setup that is showing that error, and it's referring to a "joiner" in the prefab, but I cannot for the life of me figure out what is wrong and I attempted to try contact the prefab creator by email as that was the only way to contact them but have yet to get a responce.


Evaluate jest-validate for validating configs

Do you want to request a feature or report a bug?
feature
What is the current behavior?
Right now webpack only issues validation errors.
https://github.com/facebook/jest/blob/master/packages/jest-validate would allow us to display more information about each validation error + deprecate stuff more nicely.
If this is a feature request, what is motivation or use case for changing the behavior?
Better UX and more clear error messages from validation.

Better validation messages would be good. I guess ideally the approach would still be driven by JSON schema. The gotcha is that JSON Schema does not have the concept of deprecations or warnings.
Ajv can be extended to include these features. I wrote a little deprecation plugin for it myself just to see if it's feasible and it definitely is. This is likely the route I would take.
A good solution would work across webpack plugins and loaders too. schema-utils would be a good place to experiment.


STUN instead TURN server

How can I set STUN server url?
I see only TURN_BASE_URL in constants and ts in GET params.
And other question: I see in my console "Same origin policy" error, when i test apprtc in localhost, which is normal.  So i need set Access-Control-Allow-Origin to my domain in turn/stun server response header, right?
So it is possible test some servers from below public list?
https://gist.github.com/yetithefoot/7592580

See http://gingertech.net/2014/03/19/apprtc-googles-webrtc-test-app-and-its-parameters/
(ss= parameter)


🥳[Feature] Add Two Factor Authentication for Litecoin Card

Overview
The Litecoin Card API needs a higher degree of authentication than just login for Transfers. So, the Enable2FA Api needed to be added.
Approach
There are a few structural changes tp make this happen

The LitecoinCard API needed to be updated
The Litewallet code needs to leverage that update (v0.8.0)
A new Login UI needed to be added for the user to choose 2FA usage
A new Enable UI Modal for the user to add the 2FA Code
Add tests

Screenshots/GIFs

Before
After

@JasperHeist thanks...let me made changes and push them up soon (in 24 - 36 hrs)

@JasperHeist merged the other PRs in:

f7ae472ba78372d352f91eb49acf6fa46297869f
``


Allow the editor to be focused programmatically

This small change adds the ability to programmatically focus the megadraft editor.

Hello @danielfalk, what is your use case? Wouldn't refs.editor.focus() do the trick?

My use case is auto-focusing the editor.  refs.editor.focus() doesn't seem to work for me.  The draft.js documentation recommends calling .focus() on the draft.js component instance, whereas refs.editor is only a ref to the div that contains the editor.

It seems ok to me, a nice addition. Thanks @danielfalk .


Error Autosave / Save

Map cannot be saved: The mod YARM - Resource Monitor (0.11.0) caused an error that cannot be fixed.
Please inform the author of the mod about this error.
Error while running event YARM::on_save()
Cannot serialise lua functions
The error always occurs during autosave, normal saving and loading works but no autosave is created
ridesdragons:
for me it's the other way around - autosaves seem to be functioning, but I can't manually save

Well, it's on autosave for us (server, hosted by me). Manual saving works fine.
The mod YARM - Resource Monitor (0.11.0) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event YARM::on_save()
Cannot serialise lua functions

The iterator is saved to the storage table, which is not ideal: storage.ore_tracker.iterator_func 👎

The iterator is saved to the storage table, which is not ideal: storage.ore_tracker.iterator_func 👎
Located here:
https://github.com/narc0tiq/YARM/blob/4eda629eb250bc3a807bdfbfebdda34b164c1d6a/libs/ore_tracker.lua#L152

What's a better place to store it?

No, no, we shouldn't save it, that's the problem -- we need to get a new one each time. The iterator state and key have to be enough to resume iteration. Factorio 1.1 was silently ignoring our request to save the iterator anyway, so we've been unexpectedly doing this all along for the last 3 years anyway, but now we should do it on purpose.
I'll take a look at how a patch for that might look like, I can still mostly remember how the ore tracker works.

Having some real trouble trying to figure this one out, particularly since i can't reproduce it. Are any of y'all able to have this happen reliably? A savegame of that would be great, as well as some context info of which mods you're using and whether you're using a fresh 2.0 save.

We got a savegame in this thread, and in replying to it i also realized it would be useful if any people affected could share their factorio-current.log

Talked to a factorio dev, and they confirmed that the storage is exclusive to YARM, so it is something in our code.

Ok, good news, I have reproduction steps: you have to be in the middle of adding a site (either scanning for resources or just waiting for the scan to time out). If it just sits there, nothing will go wrong, but if you (or anyone else, in multiplayer!) happen to be adding a site then the state of the game during this step includes some function somewhere in YARM's storage.

Ok, revising my previous statement: if it just sits there with relatively few and small sites, nothing will likely go wrong -- I've found the likely culprit:
https://github.com/narc0tiq/YARM/blob/4eda629eb250bc3a807bdfbfebdda34b164c1d6a/resmon.lua#L669
Locally it looks fine, right? site.iter_fn, we're just putting something into this local... but actually, its true name is storage.player_data[game.get_current_player()].current_site.iter_fn and that's much more obviously not ok because we're trying to put a function into storage.
There are two cases where we enter here, once is when finalizing a site (after creation or expansion _with addition of entities), the other is when updating site totals for each force, which happens rarely enough you wouldn't run into it unless you were really lucky. Happily, finding the first case let me find both.

I don't honestly think factorio logs would be useful, but I just experienced the crash, and someone asked for them above, so here ya go:
14296.800 Info AsyncScenarioSaver.cpp:162: Saving process PID: 909
14297.151 Info ChildProcessAgent.cpp:61: Child 909 exited with return value 0
14297.151 Info AppManager.cpp:291: Saving finished
14785.169 Info ServerMultiplayerManager.cpp:1083: Disconnect notification for peer (3)
14785.169 Info ServerMultiplayerManager.cpp:971: updateTick(4889304) received stateChanged peerID(3) oldState(InGame) newState(DisconnectScheduled)
14785.169 Info ServerSynchronizer.cpp:613: nextHeartbeatSequenceNumber(887010) removing peer(3).
15196.785 Info AppManager.cpp:290: Saving to _autosave7 (non-blocking).
15196.799 Info AsyncScenarioSaver.cpp:162: Saving process PID: 932
15197.145 Info ChildProcessAgent.cpp:61: Child 932 exited with return value 0
15197.145 Info AppManager.cpp:291: Saving finished
16096.785 Info AppManager.cpp:290: Saving to _autosave8 (non-blocking).
16096.796 Info AsyncScenarioSaver.cpp:162: Saving process PID: 955
16097.161 Info ChildProcessAgent.cpp:61: Child 955 exited with return value 0
16097.161 Info AppManager.cpp:291: Saving finished
16605.502 ConnectionRequestReplyConfirm (type(ConnectionRequestReplyConfirm) ) from(IP ADDR:({<IP_ADDRESS>:64335}))
16605.502 Info ServerRouter.cpp:465: Replying to connectionRequest for address(IP ADDR:({<IP_ADDRESS>:64335})).
16605.502 Info ServerSynchronizer.cpp:594: nextHeartbeatSequenceNumber(996229) adding peer(5)
16605.521 Info ServerMultiplayerManager.cpp:803: updateTick(4998525) changing state from(InGame) to(InGameSavingMap)
16605.552 Info ServerMultiplayerManager.cpp:971: updateTick(4998525) received stateChanged peerID(5) oldState(Ready) newState(ConnectedWaitingForMap)
16605.732 Warning WriteFileGuard.cpp:51: Writing /factorio/temp/mp-save-4.zip failed; previous version (if any) should still be available
16605.733 Error ParallelScenarioSaver.cpp:156: Saving scenario failed: The mod YARM - Resource Monitor (0.11.1) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event YARM::on_save()
Cannot serialise lua functions
16605.735 Error ServerMultiplayerManager.cpp:84: MultiplayerManager failed: save-map-failed.cannot-save-map("Cannot save map: The mod YARM - Resource Monitor (0.11.1) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event YARM::on_save()
Cannot serialise lua functions")
16605.735 Info ServerMultiplayerManager.cpp:803: updateTick(4998525) changing state from(InGameSavingMap) to(Failed)
16605.752 Quitting: multiplayer error.
16606.056 Info ServerMultiplayerManager.cpp:146: Quitting multiplayer connection.
16606.056 Info ServerMultiplayerManager.cpp:803: updateTick(18446744073709551615) changing state from(Failed) to(Closed)
16606.059 Info UDPSocket.cpp:233: Closing socket
16606.059 Info UDPSocket.cpp:263: Socket closed
16606.059 Info UDPSocket.cpp:233: Closing socket
16606.132 Info UDPSocket.cpp:233: Closing socket
16606.132 Info UDPSocket.cpp:263: Socket closed
16606.134 Goodbye

A release with a fix is out. Please test it and reopen this if it still happens. :)

Appears to be working.  I couldn't trigger the crash at-will before, but I have not been able to trigger it recently, so I THINK it's fixed now.
Thanks much!!


Migrate existing bot to connect to Polygon (through Alchemy)

but still via web3 ? @branimirangelov

Yes, still via web3. I just use Alchemy to make the troubleshooting experience easier. I've created an Apocryph team there, I will invite you.

done


feat(ci): see if sqlsmith tests run, when no changes to source files (ignore tihs)

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
just see if sqlsmith tests run, even when no change to source files :eyes:

There's no issue, it does not run sqlsmith tests.
My suspicion is that coverage might be affected for prs which do not run sqlsmith workflow.
IF that's the case, sqlsmith tests should probably be excluded from coverage.

Updating this PR. Use to fix coverage issue.

Please feel free to suggest a better approach, if any.

See if mergify can merge (does code coverage block merging? :eyes: )


Bump to 0.13.0

@alexcrichton: no appropriate reviewer found, use r? to override

@bors: r+ fb2faf29b26da39bd815b470ca73255dbfe30e42

:hourglass: Testing commit fb2faf2 with merge d263690...

:sunny: Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing d2636907a80f57cb34ac8907694f71d58eb38928 to master...


build: replace travis with github ci

https://github.com/dajohi/btcutil/runs/670938539

@dajohi Any update on this? If you would prefer, I can take this over for the last fixes.

@onyb updated

@dajohi Recent changes look good to me, but the build on your fork appears to be failing.

Needs a rebase.

@onyb @Roasbeef ready for review..


Error when removing node

When removing a node from RackHD, we get an HTTP 500 error:
$ docker-machine rm test1
About to remove test1
Are you sure? (y/n): y
(test1) There was an issue Shutting Down the Server. Error: [POST /Systems/{identifier}/Actions/ComputerSystem.Reset][500] doResetInternalServerError  &{Message:<nil>}
Successfully removed test1

This error is ignored, and the node is removed both from RackHD and from docker-machine. The failing step is attempting to power off the machine, and that's failing.

Root cause: https://github.com/RackHD/RackHD/issues/382

I'll switch this to a ForceOff instead of a GracefulShutdown for now.

This issue as well: https://github.com/RackHD/RackHD/issues/383
This keeps me from using the redfish API at all for OBM tasks. Since the actually OBM tasks (reset, on, off) is done as a workflow, I need to check that the workflow has finished successfully before continuing (e.g. removing the node from RackHD, as is done when calling docker-machine rm <node). But I always get an error when using the DoReset() call, since the status code is invalid.
I could switch to the monorail API for these actions. Depends on priority.


Fix Access-Control-Request-Method header

At least since #3578, the Access-Control-Request-Method HTTP header for preflight requests doesn't contain the actual request method, but instead the origin.
That's not correct.

I did some research into this and found that Access-Control-Request-Method is a request only header, we shouldn't reply with that header, instead, we have to reply with the correct allowed headers.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Request-Method
I've updated the PR to reflect this. cc @arunoda please review

Thanks @timneutkens!

I should have linked to MDN as that's why I made the choice not to use *:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers
There's a compatibility note there saying * has not been implemented in many browsers.

The wildcard value (*) that is mentioned in the latest specification, is not yet implemented in browsers:

Nice catch @timneutkens 🙇♀


Feature/documentation

Description
This branch updates the documentation, adapting the given template to fit our needs. Also in the readme the front end repo is linked.
Type of change

[X] New feature (non-breaking change which adds functionality)

Change Status

[X] Complete, tested, ready to review and merge

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] There are no merge conflicts

Awesomenesssssss


[Feature Request]: The Footer layout and design can be enhanced

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
The footer design can be enchanced and made better
Use Case
It will be in good design to view
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Please provide designs.


Wrong docker pull and run commands mentioned in documentation.

Documentation
https://kuma.io/docs/1.3.0/installation/docker/
there are no tag or version given for images in

kuma-cp: at docker.io/kumahq/kuma-cp:

kuma-dp: at docker.io/kumahq/kuma-dp:

kumactl: at docker.io/kumahq/kumactl:

kuma-prometheus-sd: at docker.io/kumahq/kuma-prometheus-sd:

I used below docker pull commands

docker pull kumahq/kuma-cp:1.3.0
docker pull kumahq/kuma-dp:1.3.0
docker pull kumahq/kumactl:1.3.0
docker pull kumahq/kuma-prometheus-sd:1.3.0

Also docker run command is also wrong
docker run \
    -p 5681:5681 \
    docker.io/kumahq/kuma-cp: run

its failing with
docker: invalid reference format.
See 'docker run --help'.

Correct command is
docker run -p 5681:5681 docker.io/kumahq/kuma-cp:1.3.0 run

@Bradamant3 This looks like another case where the tooling missed a version number update?


Require php8.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.3%) to 71.287%

Totals

Change from base Build<PHONE_NUMBER>:
-1.3%

Covered Lines:
72

Relevant Lines:
101

💛  - Coveralls


Bump version to 1.5.1

Description of changes:

Bumping the version to 1.5.1
Adding feed.json updates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.66%. Comparing base (612bc56) to head (65bc457).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #246       +/-   ##
===========================================
+ Coverage   12.28%   15.66%    +3.37%
===========================================
  Files        2246      187     -2059
  Lines      191014    16755   -174259
  Branches   174929      670   -174259
===========================================
- Hits        23468     2624    -20844
+ Misses     166379    14131   -152248
+ Partials     1167        0     -1167

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Omitting access_duration in cyral_identity_map results in plan change on every plan

Link to doc: https://github.com/cyralinc/terraform-provider-cyral/blob/main/doc/resource_identity_map.md
Even though it says that access_duration can be omitted, after an identity_map has been created, any subsequent terraform plan results in a change. Nothing ends up happening after applying, but these changes show up in every plan thereafter.
  ~ resource "cyral_identity_map" "identity_map" {
        id                          = "1v3ApyyPb6VzZGi79c1KSPfZTBL-my-local-account"
        # (4 unchanged attributes hidden)

      - access_duration {
          - days    = 0 -> null
          - hours   = 0 -> null
          - minutes = 0 -> null
          - seconds = 0 -> null
        }
    }

I would assume that if the docs specify that its not required, then if its omitted when creating the resource, it shouldn't result in this change on any subsequent plans.
It feels like theres probably some error of not setting this block in the TF state by default if its omitted:
      access_duration {
          days    = 0 -> null
          hours   = 0 -> null
          minutes = 0 -> null
          seconds = 0 -> null
       }

As a separate, but related question:
its not super clear if setting
    access_duration {
        days    = 0
        hours   = 0
        minutes = 0
        seconds = 0
    }

is equivalent to omitting it.

@h-wang94 and @greenkiwi , please refer to v2.0.1 for this bug fix. Make sure to read the change log to check the minimum CP version required for this version.


Update android-sdk to 3859397

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Closes #42088.
This removes the preflight which now seems to require downloading extra components and accepting additional licences.

Merging this for now, if we can find a way to correctly handle the components/licences they can be added back.


ESP Scanning Suite brakes Windows Boot

Device
msi-pro-z690-a-wifi-ddr4
RTE version

OSFV version
develop
Affected component(s) or functionality
ESP-Scanning Suite
Brief summary
ESP Scanning Suite brakes Windows Boot
How reproducible
100%
How to reproduce
Run any test in ESP-Scanning for example:
robot -v snipeit:no -L TRACE -v rte_ip:<IP_ADDRESS> -v config:msi-pro-z690-a-wifi-ddr4 -v sonoff_ip:<IP_ADDRESS> -v pikvm_ip:<IP_ADDRESS> -v device_ip:<IP_ADDRESS> -v fw_file:./msi_ms7d25_v1.1.4_ddr4.rom -v capsule_fw_file:./msi_ms7d25_v1.1.4_ddr4.cap -t 'ESP002*' dasharo-compatibility/esp-scanning.robot
Expected behavior
Suite teardown should only remove boot options added in suite prepare.
Actual behavior
All boot options added are deleted but also files required to boot windows are removed - so boot to windows is no longer working. This breaks a lot of tests.
Link to screenshots or logs
log-ESP.zip
Additional context
No response
Solutions you've tried
No response

@JanPrusinowski Does it breaks still, even when running from this branch: https://github.com/Dasharo/open-source-firmware-validation/pull/550

@macpijan Did not break on provided branch:

So we can say it's not an issue anymore in develop.


feat: 1-Click-Demo

Write bash script that does the following:

setup and activate conda environment "lapspython"
install swig (see #41)
install asdf
install pipenv
pipenv install --dev
pipenv run tests
pipenv run linting
pipenv run statics typechecks
run lapspython using re2 checkpoint
run lapspython using re2 checkpoint in R mode
show sample programs in both languages

Solved by ceda056. Will be closed after adding a demo documentation to README.md


Re-add settings command but for all config values

Re-add the /physsettings command with a more general approach that automatically allows values in the config to not only be edited through the native forge GUI but also through a command.

bad idea, it dumbs down the mod for little to no benefit
just stick with the gui, kiddies dont understand commands anyways

it's required to edit config in game on servers, unfortunately

keyword: in game
Feature has been added


Array Value cannot be set with context.node.input

Describe the feature
TypeError: Cannot convert undefined or null to object
in eq function
Suggest improvement.

eq(null, [])

Please provide a reproduction, thanks

@justin-schroeder
Please look at the previous message.

OK


HIVE-27508 : Backport of HIVE-21584 to branch-3.1

Took a quick look and compared with the original PR for HIVE-21584. I am not sure of the state of tests in branch-3.1 but based on There are 0 new tests failing, 51 existing it looks like none of them are new failures.

@vihangk1 These tests were failing in branch-3.1 since the beginning. No work was put into this. The correctness of this PR will be determined by tests passing in branch-3

merged into branch-3.1


Youtube 18.48.3 with iPad OS 16.6.1 not working

The request is https://youtubei.googleapis.com/youtubei/v1/browse?key=AIzaSyB-63vPrdThhKuerbB2N_l7Kwwcxj6yUAc&retry=1  and the produced result body is undefined when processing request.
The request body dump is here https://github.com/FrontMage/web3d/releases/download/1.0.0/reqbody.dump

I have tested Youtube 18.48.3 on IPad OS 16.7.2. and it works well.
I  have not received similar reports from other users.
Are you using Surge?

No, I'm writing my client, similar to Surge, using quickjs to load the script, but I don't think it's the problem with quickjs, since I put the script and the data into node, it can't produce any result.

To add on top of the protocol change, if I use the request dump from a month before, then everything is fine.

I see what you mean.
The first thing I'd like to ask is how reqbody.dump is  captured, I tried to parse it using protoc but it prompted a format error, which means it’s probably not a protobuf.
BTW, I'm debugging the script with a body exported using surge, and it works with node after removing some of the built-in methods ($request, $done, etc.)

I wrote a MIMT program to intercept https traffic, and it is dumped from the MIMT request intercept section, so maybe there is something wrong with MIMT broke the protobuf, l'll try debug from here, maybe it's using quic?

As far as I know, only mitmproxy is perfecting quic-based mitm. None of the commonly used proxy tools support it, but of course it would be great if you develop an app that supports this feature. So, for YouTube traffic capture are based on TCP (HTTPS).
You can use other apps to capture the body first to further investigate.

Sure, I'm trying to use Charles to debug this.

Issue found, https://youtubei.googleapis.com/youtubei/v1/browse?key=AIzaSyB-63vPrdThhKuerbB2N_l7Kwwcxj6yUAc this url sometimes produces none protobuf requests, instead of just panic, If I return the origin request body, it will work, I suspect surge and others are doing the same. Thx for the help!


UCUM service reinitialized for every Context

While doing some performance evaluation today, I noticed a bunch of stack traces showing up inside CqlContext.init(Library) related to the initialization of the UcumEssenceService. This seems like this is a thing that could be initialized once and reuse across contexts to save some cycles.
app//org.fhir.ucum.UcumEssenceService.<init>(UcumEssenceService.java:57)
app//org.opencds.cqf.cql.engine.execution.Context.init(Context.java:182)
app//org.opencds.cqf.cql.engine.execution.Context.<init>(Context.java:166)
app//com.ibm.cohort.cql.evaluation.CqlContextFactory.createContext(CqlContextFactory.java:81)

I'll have to do some digging to see if the UcumService is thread-safe or not.

Worst case, we could just store the UcumService in a ThreadLocal static right? I was also wondering if it is something that the user  should configure and provide as input to engine initialization. This would be similar to what is already done in the CqlTranslator.

+1 to providing as a parameter, many environments will already have one in context.

I did some poking around this in the ucum-java code. They don't mention anything about thread safety. I reviewed the code and didn't see anything that would concern me, but it is certainly possible I missed something. I think a better indicator is probably that the HAPI code that uses the UcumEssenseService creates a single static copy for reuse and gets away with it. See https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/util/UcumServiceUtil.java.

Thanks for the research!
Agreed on passing it in as a parameter and we'll create a static copy for environments that don't provide one.


Added entities for legislatives website.

You may need to adapt https://github.com/EnMarche/en-marche.fr/blob/master/src/AppBundle/Admin/AdherentAdmin.php#L81-L88 & https://github.com/EnMarche/en-marche.fr/blob/master/src/AppBundle/Admin/AdherentAdmin.php#L180-L186

@mykiwi fixed. thanks.

One last thing, you should adapt the doctrine migration to select all adherent who are a legislative candidate, and set the boolean to true.

You should add the firstName and lastName attribute since the relationship with the adherent entity was dropped. And maybe generate the slug based on these two fields.

@rpg600 first name and last name are already there thanks to the EntityPersonNameTrait trait. For now slugs are manually generated. I don't think we need to automate slug generation as all candidates' profiles will be manually inserted from the BO.

Automated them on insertion to avoid having to enter them by hand could be useful though

@rpg600 @tgalopin @mykiwi I applied your requested changes. I think PR is good to merge now.


Gradle 7 support (0.0.15) - currently missing annotations

Currently seeing some failures when trying to build with gradle 7, and making use of the execfork plugin:
Specifically, gradle7 is complaining that file following properties are missing an input or output annotation: commandLine, environment, executable, killDescendents, process - they need to be marked as @input @output or @internal. I suspect the first three at least, possibly all, may be classed as input as changes could fundamentally affect the result?
Full output:
jonesn:egeria/ (issue5101*) $ ./gradlew build                                                                                [12:43:24]
Picked up JAVA_TOOL_OPTIONS: --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED

> Configure project :open-metadata-implementation:access-services:asset-catalog:asset-catalog-api
Picked up JAVA_TOOL_OPTIONS: --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED

> Configure project :open-metadata-implementation:access-services:asset-catalog:asset-catalog-server
Picked up JAVA_TOOL_OPTIONS: --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED
Picked up JAVA_TOOL_OPTIONS: --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED

> Task :open-metadata-test:open-metadata-fvt:access-services-fvt:subject-area-fvt:test
Execution optimizations have been disabled for task ':open-metadata-test:open-metadata-fvt:access-services-fvt:subject-area-fvt:test' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/Users/jonesn/IdeaProjects/egeria.maven/open-metadata-implementation/server-chassis/server-chassis-spring/build/libs/server-chassis-spring-2.10-SNAPSHOT.jar'. Reason: Task ':open-metadata-test:open-metadata-fvt:access-services-fvt:subject-area-fvt:test' uses this output of task ':open-metadata-implementation:server-chassis:server-chassis-spring:bootJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.0/userguide/validation_problems.html#implicit_dependency for more details about this problem.

> Task :open-metadata-test:open-metadata-fvt:access-services-fvt:data-engine-fvt:test
Execution optimizations have been disabled for task ':open-metadata-test:open-metadata-fvt:access-services-fvt:data-engine-fvt:test' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/Users/jonesn/IdeaProjects/egeria.maven/open-metadata-implementation/server-chassis/server-chassis-spring/build/libs/server-chassis-spring-2.10-SNAPSHOT.jar'. Reason: Task ':open-metadata-test:open-metadata-fvt:access-services-fvt:data-engine-fvt:test' uses this output of task ':open-metadata-implementation:server-chassis:server-chassis-spring:bootJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.0/userguide/validation_problems.html#implicit_dependency for more details about this problem.

> Task :open-metadata-test:open-metadata-fvt:access-services-fvt:asset-consumer-fvt:startServer FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Some problems were found with the configuration of task ':open-metadata-test:open-metadata-fvt:access-services-fvt:asset-consumer-fvt:startServer' (type 'ExecFork').
  - Type 'ExecFork' property 'commandLine' is missing an input or output annotation.

    Reason: A property without annotation isn't considered during up-to-date checking.

    Possible solutions:
      1. Add an input or output annotation.
      2. Mark it as @Internal.

    Please refer to https://docs.gradle.org/7.0/userguide/validation_problems.html#missing_annotation for more details about this problem.
  - Type 'ExecFork' property 'environment' is missing an input or output annotation.

    Reason: A property without annotation isn't considered during up-to-date checking.

    Possible solutions:
      1. Add an input or output annotation.
      2. Mark it as @Internal.

    Please refer to https://docs.gradle.org/7.0/userguide/validation_problems.html#missing_annotation for more details about this problem.
  - Type 'ExecFork' property 'executable' is missing an input or output annotation.

    Reason: A property without annotation isn't considered during up-to-date checking.

    Possible solutions:
      1. Add an input or output annotation.
      2. Mark it as @Internal.

    Please refer to https://docs.gradle.org/7.0/userguide/validation_problems.html#missing_annotation for more details about this problem.
  - Type 'ExecFork' property 'killDescendants' of type boolean shouldn't be annotated with @Optional.

    Reason: Properties of primitive type cannot be optional.

    Possible solutions:
      1. Remove the @Optional annotation.
      2. Use the java.lang.Boolean type instead.

    Please refer to https://docs.gradle.org/7.0/userguide/validation_problems.html#cannot_use_optional_on_primitive_types for more details about this problem.
  - Type 'ExecFork' property 'process' is missing an input or output annotation.

    Reason: A property without annotation isn't considered during up-to-date checking.

    Possible solutions:
      1. Add an input or output annotation.
      2. Mark it as @Internal.

    Please refer to https://docs.gradle.org/7.0/userguide/validation_problems.html#missing_annotation for more details about this problem.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/7.0/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 2 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.

BUILD FAILED in 17s
1841 actionable tasks: 5 executed, 1 from cache, 1835 up-to-date

(Source: https://github.com/odpi/egeria/issues/5103)

Are you sure you're on the latest version (0.1.15)? This should have been fixed by PR #38, as it's the same errors in #36.

Closing. User error. I was using another developer's fork of your code which purported to be 0.1.15 but is based on earlier code.
Corrected names & can confirm all now working


[Immediate] SIL Module Lazy Compilation

This PR implements lazy compilation at the SIL module granularity, meaning that the main SIL module will only be IRGen'd when the entry point to the script is invoked. By adding a materialization unit for the main SIL module and lazy re-exports, this PR lays the groundwork for function at-a-time lazy compilation.

@swift-ci please test

@swift-ci please test

Re-running to see If the original failures at https://ci.swift.org/job/swift-PR-Linux/9352/ were transient.
@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test


Mythril hangs when firing the lasers at this contract.

$ myth -x MemoryArrayBuilding.sol

MemoryArrayBuilding.sol file contents:
     1	// This code has not been professionally audited, therefore I cannot make any promises about
     2	// safety or correctness. Use at own risk.

     3	pragma solidity ^0.4.20;

     4	contract MemoryArrayBuilding {

     5	    struct Item {
     6	        string name;
     7	        string category;
     8	        address owner;
     9	        uint32 zipcode;
    10	        uint32 price;
    11	    }

    12	    Item[] public items;

    13	    mapping(address => uint) public ownerItemCount;

    14	    function getItemIDsByOwner(address _owner) public view returns (uint[]) {
    15	        uint[] memory result = new uint[](ownerItemCount[_owner]);
    16	        uint counter = 0;

    17	        for (uint i = 0; i < items.length; i++) {
    18	            if (items[i].owner == _owner) {
    19	                result[counter] = i;
    20	                counter++;
    21	            }
    22	        }
    23	        return result;
    24	    }
    25	}

To reproduce this bug copy the contract to your pc and myth -x it like it's hawt.

currently i am not sure why it's taking lot of time, can you try running it with a --max-depth of 17(or anything less than that) in that case it seems to be giving results in a reasonable amount of time.

It seems like this piece of code results in a lot of time spent in the integer module. This might improve a bit with the callback refactor #226

I'll close this issue as a duplicate of #226 if thats okay with you @chronaeon


First run is slow

Currently, first run on gauge-java needs more than 5 sec to start launching test. This should not be a problem. But in my case, with more than 400 scenarios with 2 or 3 specs each one of them, It takes around 20 - 30 seconds to start launching tests. Is there a way to tune this ?
Expected behavior
Tests should start faster
Actual behavior
20-30 seconds to start launching tests with a high amount of them. 5 seconds to start launching the default "example.spec" gauge java test
Steps to reproduce

Create an empty folder
type gauge init java
launch first test

Gauge version
Run gauge -v on your system and paste the results here.

Gauge version: 1.0.5
Commit Hash: 7aaf683

Plugins
-------
html-report (4.0.3)
java (0.7.2)
screenshot (0.0.1)

@javiviprospe I tried to replicate this issue but found test execution always starts within a second.
I tried with a sample project and a project which has more than 500 specs. In both projects, execution started as soon as a hit for run gauge test.
I checked with MacOS. In which environment you are seeing this issue?

I'm using ubuntu linux. And I use java 1.8, do you also use it ?

@javiviprospe I checked on Ubuntu with Java 1.8. but found the tests are starting immediately.
if all dependencies are not installed gauge try to install it first that could take 2-3 sec before running the tests.  If you want to resolve all dependency before running gauge tests, you can use gauge install. it will install all gauge related dependency.

@javiviprospe Please feel free to reopen this issue if you are still facing this issue.
Please provide more details as well.


Update to Spring Boot 2.3

Closes #1
This pull request is not working as there seems to be a backwards incompatible change with the handling of schema.sql files. I made this as I thought I was doing something wrong when following the guide. But digging deeper now, from my understanding schema.sql is only supported by Spring JDBC, but there is no point in adding jdbc dependencies for the sake of generating a schema. However flyway suffers from the same issue, so I'm not sure how to proceed here (I'm open for suggestions).
We could create the schema manually. But that is not what people want. Also the hint that schema.sql and flyway are not supported this way belong in this guide as well.

@Brutus5000 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@Brutus5000 Thank you for signing the Contributor License Agreement!

Ok I digged a bit deeper and it was fixed here but it might take a while until this is released in Spring Boot.

Thanks for having a look. The full upgrade requires a few additional steps:

Initial: Migrate from experimental starter to Spring Boot proper (pom.xml and Gradle)
Initial: Migrate from experimental starter to Spring Boot proper (pom.xml)
Remove dependencyManagement for experimental starter
Config in application.yml can be removed entirely
Replace spring-boot-test-autoconfigure-r2dbc with spring-boot-test
Add ConnectionFactoryInitializer for schema.sql

Please let us know whether you want to look into these steps or whether we should close this PR and take a look ourselves.

I checked this out once more. The ResourceDatabasePopulator required in the ConnectionFactoryInitializer requires Spring 5.3 / Spring Boot 2.4, which is only available as a milestone right now and I don't know how to set this up in Gradle. So I'd wait for Spring Boot 2.4 official release unless you have a better idea.

ConnectionFactoryInitializer is available from Spring Data R2DBC (1.0) directly. With the migration to Boot 2.4, we will need to touch this guide again to update for deprecations.

Closing in favor of c4d77ec.

Yes, thanks I didn't find the time. Sorry.


30 fps when tapping a button in Cards demo of Gallery

On a Moto G4, in release mode, we're seeing 30 fps when tapping on the SHARE and EXPLORE buttons in the Card demo of the Gallery.
Not sure what we should expect here, but since barely nothing is changing on the screen when we tap these buttons, surprised to see 30 fps.

Looks like the gpu is being overloaded.  Likely shadows or tiling related.  There were just a bunch of changes this week with regards to upload tiling, which may have improved this.  Jason is also working on moving us to a faster shadow path in Skia.  We should check this bug again in a couple weeks and it's likely to be improved.

FYI @chinmaygarde @jason-simmons (no action necessary, just likely that your current fixes may have affect here).  Seth has a Moto G4 on his desk.

Closing as not reproducible. If you disagree, please file an issue at https://github.com/flutter/gallery.


Enhance to allow binding the legend to an external element

Can this be enhanced to allow the legend to be built in an element passed in via configuration (similar to the bindto property for the graph)? I'm envisioning this would then not have to shrink the width of the graph to show the legend, and would allow for the legend to be placed anywhere by just changing css, etc.  Also, can there be a tooltip for the legend item in this case?

:thumbsup:

Won't be fixed, closing.
If you need your legend to be elsewhere you can do your own:
http://c3js.org/samples/legend_custom.html


<transition disappear> attribute complementary to already existing appear

What problem does this feature solve?
Why do we have appear attribute for <transition> tag but not disappear? It would be really handy in a scenario when parent div holding the <transition> gets destroyed for any reason (e.g. v-if directive).
Unanswered post that accurately describes the exact same issue I have:
https://forum.vuejs.org/t/is-there-a-vue-transition-opposite-of-appear/87288
What does the proposed API look like?
<transition disappear> (...) </transition>

disappear is just the leave, appear has a specific use case to force entering animations even when the element is initially present.
Please, next time consider using the forum, the Discord server or StackOverflow for questions first. But feel free to come back and open an issue if it turns out to be a bug 🙂

As much as I appreciate the answer, it does not clearly indicate whether there is or there isn't a way to fulfill the aforementioned use-case.
The following scenario does not apply any transition:

    <transition name="modal-overlay-transition">
    </transition>

    <transition name="modal-panel-transition">
    </transition>

However, the following code does apply the transition but only when the modal shows up and not when it gets closed.

    <transition name="modal-overlay-transition" appear>
    </transition>

    <transition name="modal-panel-transition" appear>
    </transition>

The main point I am trying to raise here is to look for a solution when there is a parent
 wrapping any transitions. Why cannot we have a feature that, once parent v-if is changed to a falsy value, any transitions inside will trigger their leave attributes before completely disappearing from the DOM? Doesn't it sound logical to have disappear in opposite to appear? If there is the way to achieve the above in a different, already existing way - please let me know.

Your desired disappear behavior isn't implemented right now, and likely won't as it is much more complex than appear.
You see, where with appear, the transition component can do the in-transition independent of the the parent chain, disappear would mean that somehow element removals up the parent chain would be halted until all nested transitions have disappeared.
While not impossible, this is much harder to implement and require much more additional code. For that reason, we so far have left the management of such scenarios to user land.

Sleek explanation, thank you @LinusBorg! That makes perfect sense :) Halting the removal could be tricky to implement. I will look for some workarounds knowing the state on this matter.


DX: update PHPStan

I wonder if we should drop a caret from composer.json to avoid such surprises as the needed update is related to new PHPStan version.
// cc @keradus @SpacePossum @julienfalque

Coverage remained the same at 92.175% when pulling 5ecb843c3fc298aea961ec8d79db447cd36af07d on kubawerlos:update-phpstan into ec587dba94c3b99ecbdea17554dc1c749b751569 on FriendsOfPHP:3.0.

Yep, we should drop it and use an exact version (or commit compose.lock) so we don't get new errors randomly reported as new PHPStan versions are released. I would even apply this reasoning to all the tools we use (when possible).

Let's go with PHPStan for now as it's the only one making troubles.

Thank you @kubawerlos.


NoneType' object has no attribute '_inbound_nodes'

I'm trying to solve this problem for hours but sill getting the NoneType' object has no attribute '_inbound_nodes' error.I think the issue is in tf.add(layer3_1_out,layer3_2_out). please help

I tried to attach the code snippet but it didn't detect my code as snippet,sorry for that.please help
Thank you.

Keras can't create model if you used a tensorflow operation without wrapping it into a layer. You have multiple options:

use https://keras.io/layers/merge/#add instead of tf.add
put tf.add into a lambda layer.

thank you very much.it working fine now :-)

I had a similar error before using Multiply(). However, using Lambda layer solved my issue. @gabrieldemarmiesse thanks!


[BUG] SONOFF ZBMINIL2 potentially requiring quirk

Bug description
I've recently got my hands onto an SONOFF ZBMINIL2, which is generally working fine, BUT it appears to be improperly recognized as battery powered (or unknown). ~Also I've noticed it is impossible to add it to a Zigbee group (it doesn't get listed at the group setup page).
Being unaware of the inner workings of ZHA, I see potential these two issues could be linked.~
After researching again, the Zigbee group issue appears to be unrelated: https://community.home-assistant.io/t/sonoff-zbminil2-cant-add-to-group/557814
Steps to reproduce

Link the device
Check the available entities (or the signature)
~3. Try to setup a Zigbee group with this device~

Expected behavior
I'd like the device to not have a (useless) battery indicator ~and be able to setup a Zigbee group containing it~.
Screenshots/Video
No response
Device signature
Device signature
{
  "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4742, maximum_buffer_size=82, maximum_incoming_transfer_size=1024, server_mask=11264, maximum_outgoing_transfer_size=1024, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
  "endpoints": {
    "1": {
      "profile_id": "0x0104",
      "device_type": "0x0002",
      "input_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0x0006",
        "0x0007",
        "0x0b05",
        "0xfc57"
      ],
      "output_clusters": [
        "0x0019"
      ]
    }
  },
  "manufacturer": "SONOFF",
  "model": "ZBMINIL2",
  "class": "zigpy.device.Device"
}

Diagnostic information
Diagnostic information
{
  "home_assistant": {
    "installation_type": "Unknown",
    "version": "2024.1.5",
    "dev": false,
    "hassio": false,
    "virtualenv": false,
    "python_version": "3.11.6",
    "docker": false,
    "arch": "x86_64",
    "timezone": "Europe/Vienna",
    "os_name": "Linux",
    "os_version": "6.1.63-production+truenas",
    "run_as_root": true
  },
  "custom_components": {
    "thermal_comfort": {
      "version": "2.2.2",
      "requirements": []
    },
    "truenas": {
      "version": "0.0.0",
      "requirements": []
    },
    "zha_toolkit": {
      "version": "v1.1.8",
      "requirements": [
        "pytz"
      ]
    },
    "hacs": {
      "version": "1.34.0",
      "requirements": [
        "aiogithubapi>=22.10.1"
      ]
    },
    "multiscrape": {
      "version": "6.5.0",
      "requirements": [
        "lxml>=4.9.1",
        "beautifulsoup4>=4.12.2"
      ]
    },
    "openweathermaphistory": {
      "version": "2.0.2",
      "requirements": []
    }
  },
  "integration_manifest": {
    "domain": "zha",
    "name": "Zigbee Home Automation",
    "after_dependencies": [
      "onboarding",
      "usb"
    ],
    "codeowners": [
      "@dmulcahey",
      "@adminiuga",
      "@puddly",
      "@TheJulianJES"
    ],
    "config_flow": true,
    "dependencies": [
      "file_upload"
    ],
    "documentation": "https://www.home-assistant.io/integrations/zha",
    "iot_class": "local_polling",
    "loggers": [
      "aiosqlite",
      "bellows",
      "crccheck",
      "pure_pcapy3",
      "zhaquirks",
      "zigpy",
      "zigpy_deconz",
      "zigpy_xbee",
      "zigpy_zigate",
      "zigpy_znp",
      "universal_silabs_flasher"
    ],
    "requirements": [
      "bellows==0.37.6",
      "pyserial==3.5",
      "pyserial-asyncio==0.6",
      "zha-quirks==0.0.109",
      "zigpy-deconz==0.22.4",
      "zigpy==0.60.6",
      "zigpy-xbee==0.20.1",
      "zigpy-zigate==0.12.0",
      "zigpy-znp==0.12.1",
      "universal-silabs-flasher==0.0.15",
      "pyserial-asyncio-fast==0.11"
    ],
    "usb": [
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*2652*",
        "known_devices": [
          "slae.sh cc2652rb stick"
        ]
      },
      {
        "vid": "1A86",
        "pid": "55D4",
        "description": "*sonoff*plus*",
        "known_devices": [
          "sonoff zigbee dongle plus v2"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*sonoff*plus*",
        "known_devices": [
          "sonoff zigbee dongle plus"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*tubeszb*",
        "known_devices": [
          "TubesZB Coordinator"
        ]
      },
      {
        "vid": "1A86",
        "pid": "7523",
        "description": "*tubeszb*",
        "known_devices": [
          "TubesZB Coordinator"
        ]
      },
      {
        "vid": "1A86",
        "pid": "7523",
        "description": "*zigstar*",
        "known_devices": [
          "ZigStar Coordinators"
        ]
      },
      {
        "vid": "1CF1",
        "pid": "0030",
        "description": "*conbee*",
        "known_devices": [
          "Conbee II"
        ]
      },
      {
        "vid": "0403",
        "pid": "6015",
        "description": "*conbee*",
        "known_devices": [
          "Conbee III"
        ]
      },
      {
        "vid": "10C4",
        "pid": "8A2A",
        "description": "*zigbee*",
        "known_devices": [
          "Nortek HUSBZB-1"
        ]
      },
      {
        "vid": "0403",
        "pid": "6015",
        "description": "*zigate*",
        "known_devices": [
          "ZiGate+"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*zigate*",
        "known_devices": [
          "ZiGate"
        ]
      },
      {
        "vid": "10C4",
        "pid": "8B34",
        "description": "*bv 2010/10*",
        "known_devices": [
          "Bitron Video AV2010/10"
        ]
      }
    ],
    "zeroconf": [
      {
        "type": "_esphomelib._tcp.local.",
        "name": "tube*"
      },
      {
        "type": "_zigate-zigbee-gateway._tcp.local.",
        "name": "*zigate*"
      },
      {
        "type": "_zigstar_gw._tcp.local.",
        "name": "*zigstar*"
      },
      {
        "type": "_uzg-01._tcp.local.",
        "name": "uzg-01*"
      },
      {
        "type": "_slzb-06._tcp.local.",
        "name": "slzb-06*"
      }
    ],
    "is_built_in": true
  },
  "data": {
    "ieee": "**REDACTED**",
    "nwk": 48767,
    "manufacturer": "SONOFF",
    "model": "ZBMINIL2",
    "name": "SONOFF ZBMINIL2",
    "quirk_applied": false,
    "quirk_class": "zigpy.device.Device",
    "quirk_id": null,
    "manufacturer_code": 4742,
    "power_source": "Battery or Unknown",
    "lqi": 76,
    "rssi": null,
    "last_seen": "2024-01-29T20:55:30",
    "available": true,
    "device_type": "EndDevice",
    "signature": {
      "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4742, maximum_buffer_size=82, maximum_incoming_transfer_size=1024, server_mask=11264, maximum_outgoing_transfer_size=1024, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
      "endpoints": {
        "1": {
          "profile_id": "0x0104",
          "device_type": "0x0002",
          "input_clusters": [
            "0x0000",
            "0x0001",
            "0x0003",
            "0x0006",
            "0x0007",
            "0x0b05",
            "0xfc57"
          ],
          "output_clusters": [
            "0x0019"
          ]
        }
      },
      "manufacturer": "SONOFF",
      "model": "ZBMINIL2"
    },
    "active_coordinator": false,
    "entities": [
      {
        "entity_id": "sensor.bathroom_mirror_sw_light_rssi",
        "name": "SONOFF ZBMINIL2"
      },
      {
        "entity_id": "sensor.bathroom_mirror_sw_light_lqi",
        "name": "SONOFF ZBMINIL2"
      },
      {
        "entity_id": "switch.bathroom_mirror_sw_light",
        "name": "SONOFF ZBMINIL2"
      },
      {
        "entity_id": "button.bathroom_mirror_sw_light_identify",
        "name": "SONOFF ZBMINIL2"
      },
      {
        "entity_id": "select.bathroom_mirror_sw_light_start_up_behavior",
        "name": "SONOFF ZBMINIL2"
      }
    ],
    "neighbors": [],
    "routes": [],
    "endpoint_names": [
      {
        "name": "ON_OFF_OUTPUT"
      }
    ],
    "user_given_name": "Bad Lampe Spiegel",
    "device_reg_id": "c9f9a8ea61a1895511a4f5431f488f02",
    "area_id": "bad",
    "cluster_details": {
      "1": {
        "device_type": {
          "name": "ON_OFF_OUTPUT",
          "id": 2
        },
        "profile_id": 260,
        "in_clusters": {
          "0x0000": {
            "endpoint_attribute": "basic",
            "attributes": {
              "0x0004": {
                "attribute_name": "manufacturer",
                "value": "SONOFF"
              },
              "0x0005": {
                "attribute_name": "model",
                "value": "ZBMINIL2"
              }
            },
            "unsupported_attributes": {}
          },
          "0x0001": {
            "endpoint_attribute": "power",
            "attributes": {},
            "unsupported_attributes": {
              "0x0020": {
                "attribute_name": "battery_voltage"
              },
              "0x0021": {
                "attribute_name": "battery_percentage_remaining"
              },
              "0x0031": {
                "attribute_name": "battery_size"
              },
              "0x0033": {
                "attribute_name": "battery_quantity"
              }
            }
          },
          "0x0003": {
            "endpoint_attribute": "identify",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0006": {
            "endpoint_attribute": "on_off",
            "attributes": {
              "0x0000": {
                "attribute_name": "on_off",
                "value": 0
              },
              "0x4003": {
                "attribute_name": "start_up_on_off",
                "value": 0
              }
            },
            "unsupported_attributes": {}
          },
          "0x0007": {
            "endpoint_attribute": "on_off_config",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0b05": {
            "endpoint_attribute": "diagnostic",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0xfc57": {
            "endpoint_attribute": "manufacturer_specific",
            "attributes": {},
            "unsupported_attributes": {}
          }
        },
        "out_clusters": {
          "0x0019": {
            "endpoint_attribute": "ota",
            "attributes": {},
            "unsupported_attributes": {}
          }
        }
      }
    }
  }
}

Logs
Logs
None

Additional information
~If these two issues are unrelated, I apologize for my wild guess and will happily reduce this ticket to the power source problematic only.~
If someone could provide me a hint on how to create a quirk to overwrite given property, I'd be happy to submit a PR.

It's not only that the power source is "battery or unknown"; the devices are potential routers but without being "mains" powered they are not eligible. I had to put another device in the area as Zigbee repeater which the switches were intended to be.

It's not only that the power source is "battery or unknown"; the devices are potential routers but without being "mains" powered they are not eligible. I had to put another device in the area as Zigbee repeater which the switches were intended to be.

AFAIR the device wrongly advertises itself as non mains powered, even though it is. It is not usable as router though, due to weird limitations Sonoff made on this model. Having ZHA applying a quirk recognizing the power source as mains should eliminate the misleading/invalid battery indicator, as long as Sonoff doesn't provide a fix.
I texted their support in hopes to get that rolling, but had no luck yet. The report was "handed over to the programming team" (or something along the lines), and never to be heard of again. :(


Allow table selection when cells are already selected

Earlier on table selection,  previous selection was cleared before immediately returning on mousedown if table cells were already selected. By not returning, but still clearing selection, we are able to make a proper new table selection instead of ending up in bad states.
Fixes issue #4697
See issue for more details.
Before:
https://github.com/facebook/lexical/assets/23295934/d9eec6bc-6829-4dca-a4d8-023acf3ed8fa
https://github.com/facebook/lexical/assets/23295934/e101c75e-6f2c-4369-84a7-3cda2bc72817
After:
https://github.com/facebook/lexical/assets/23295934/3d1832a2-d105-422c-b005-107c3afcc4bf
https://github.com/facebook/lexical/assets/23295934/c39419ed-08d6-4cb1-97d2-04655ab0c4f8

Started some rework on table selection in #4689 which seem to address your case, but regardless, having more tests is great. Thank you!


use pre-compiled stan models when possible

It's possible to reliably crash RStudio (at least on Windows) by running two stan models [of the same type] and then Build & Reloading. I've found no way to avoid this systematic issue. But then, it's probably an issue that average users won't encounter and power users can learn to avoid.
Besides that, it's great! 50 seconds goes down to 16 for quick models.

Coverage decreased (-0.2%) to 18.979% when pulling 1ff619e0d8df6e57eaffaaf3ae2bc025b7aa3f19 on aappling-usgs:develop into 2fb479fd71e9c9d26541762a342078465abf8f7a on USGS-R:develop.


about mac client

hi all,
freerdp a framework is obtained by cake to compile a MAC version, but there was no Xcode source code. I use the iOS client source code?

@cloudecker Could you repeat the question in english please?

@akallabeth  I compiled freerdp MAC client, I got a framework, not a MAC client source code. My question, whether the MAC client also uses the iOS client source code?

@akallabeth Compile MAC version freerdp, I get the information as follows. Attached image

@cloudecker The clients are separate (the stuff in client/* is just the GUI) but they share some code (audio support, etc). But please do not post duplicate questions like in #2950
As for compiliation there is a .app bundle created (MacFreeRDP.app in client/Mac/cli).
The frameworks are built before as the client consists of a couple of them ;)

@akallabeth  Thank you for your patience reply.
I mean, mac client only a framework and some GUI layout file. mac  client does not actually run the RDP connection.
In the ios client, there are a lot of RDP connection Settings file. But the MAC client without these files.

@cloudecker The MAC client is very rudimentary, it can only be started with command line, so there is no nice GUI for connection settings. The iOS client on the other hand has such an interface.

@akallabeth  thank  you very much，i will try it again!


Added 2019 Toyota Corolla Hatchback SE

Relayed from @johntatum noting dongle ID 0e23dc2562a9807e

nice

A few specifics in case anyone is curious: The added signature is for the USA market Corolla Hatchback's (specific vehicle fingerprint was taken from: 2019 Corolla Hatchback SE with CVT trans).
The previous original signature applied to Canadian market Corolla Hatchbacks.

manually looked at one drive from 0e23dc2562a9807e and got the fingerprint. this new one can be merged with the existing one, since only 1649 seemed to be missing from it.
Will be in next release

Thanks!


Fix: Fixed an issue where WindowsIniService.GetData might try to add the same key in a dictionary

Resolved / Related Issues

Closes #15875

Steps used to test these changes

Open Files app
Add two keys that has the same name in Desktop.ini
Try to load it in Files

I was trying to fix the same thing lol
I fixed it this way.
				// Read data
				var parameters = range
					// Split the lines into key and value
					.Select(line => line.Split('='))
					// Validate
					.Where(parts => parts.Length == 2)
					// Group by key to avoid duplicates
					.GroupBy(parts => parts[0].Trim())
					// Gather as dictionary
					.ToDictionary(partsGroup => partsGroup.Key, partsGroup => partsGroup.Last()[1].Trim());

Looks very simple! Can you open your PR?


Change "Open WebUI at Launch" to false by default

The app currently starts up w/ a full window on system startup in Windows 10.
An option/config to minimize to system tray on app launch would be much appreciated.

The app currently starts up w/ a full window on system startup in Windows 10.
An option/config to minimize to system tray on app launch would be much appreciated.

This is really annoying.
"minimize to system tray on app launch". Yes, please.

I noticed that IPFS services don't get added to the Windows 10 services, if this was done, under Windows services, an administrator could set IPFS services to start at Windows startup and not have to launch the desktop app. So, IPFS should move away from desktop apps and only add IPFS services and use web applications for IPFS display of Status, files, explore, peers and settings.

We already have setting for this in Settings → Open WebUI at Launch.
IIRC it is enabled by default because Electron broke Tray icon (#1153) and people on Linux were unable to access the app at all.
I believe the tray is fixed on Linux now, so if someone fills a PR that changes the default behavior I'm happy to review it.

@lidel I don't see the Open WebUI at Launch setting in Settings menu or the JSON config. Where is the setting supposed to be located? I see API Address, Pinning, Language, Analytics, CLI Tutor, and IPFS Config JSON.

@nickkeane

@nickkeane you can change it here:
![image](https://user-image@lidel githubusercontent.com/5447088/133882547-452fd994-0aee-4241-8c1f-e10bc899c530.png)
@lidel I just saw this more recent PR #1757 where this option was defaulted to True for all users in all OSes. Not sure how to proceed here as the reason presented on #1153 no longer applies, but then we have #1757.


ActiveExprModel: insert and update a model with SimpleExpr

Motivation
It'd be convenient if we allow inserting and updating with expression such as summation of two columns "num1" + "num2" or even DB built in function CURRENT_TIMESTAMP or UUID().
Proposed Solutions
Introduce a SimpleExpr version of ActiveValue and ActiveModel. Which conversion methods will be provided to convert ActiveValue into ActiveExpr and ActiveModel into ActiveExprModel.
let active_expr_model: ActiveExprModel =
    ActiveModel {
        // ...
    }
    .into_active_expr_model();

let model: Model =
    ActiveExprModel {
        created_at: SetExpr( ... ),
    }
    .insert(db) // or `.update(db)`
    .await?;

Comments? @tyt2y3

I second the idea of having an ergonimc way to SET c = c+1.
However I think ActiveExprModel is not necessary.
The API can probably look like:
let change_set = ChangeSet::new(Cake).set(cake::Column::Counter, cake::Column::Counter.add(1));
change_set.insert(&db).await?;

change_set
    .which(2) // this is the PK
    .update(&db).await?; // if `which` is never called, we should refuse to execute


Path separator should be escaped on Windows

ncc generates require path with platform specific path separators
module.exports = require("./build\Release\zmq.node")

If not correctly escaped, this statement causes a runtime error

Error: Cannot find module './buildReleasezmq.node'

For repro nteract/kernel-relay

cc @rgbkrk

This should be resolved now, please let me know if it comes up again at all.

Thank you!


compile error in sample

    await ds.sleep(50)

should be
    await ds.sleepMs(50)

import * as ds from "@devicescript/core"

console.log("starting...")
const sensor = new ds.AirPressure()
const mouse = new ds.HidMouse()
// listen for pressure changes
sensor.pressure.subscribe(async pressure => {
    // read sensor reading
    console.log(pressure)
    // user blows in straw
    if (pressure > 1400) {
        // click!
        console.log(`click!`)
        await mouse.setButton(
            ds.HidMouseButton.Left,
            ds.HidMouseButtonEvent.Click
        )
        // debouncing
        await ds.sleep(50)
    }
})

No it has been reanmed ds.sleep but the package has not been properly bumped yet.


Anyway to use Apollo Queries inside containers?

Anyway to integrate https://github.com/trojanowski/react-apollo-hooks into our containers?
Is something like this is possible? Which fires on an onChange hook?
const addExistingCreds = (() => {
    const { data } = useQuery(CREDENTIALS_BY_EDORG, {
      variables: {name: childEdOrg},
    });
    const existingCreds = data.allEducationalOrganizations[0].credentials;
    return setCredential((prevCreds) => {
      return update(prevCreds, { $set: existingCreds });
    });
  });

Hooks can only be used at the top level of a component or another hook. See https://reactjs.org/docs/hooks-rules.html
But yes, you can call any hook inside of your container hook.
function useCurrentUser() {
  let { data } = useQuery(...)
  ...
}

let CurrentUser = createContainer(useCurrentUser)

As for using a hook inside a callback: you can't. But I assume a graphql hook library would have a way of dealing with that

Awesome, that helps. Think I can make this work. Thanks


SimulateMouseMovementRelative(0, 0) - Mouse is moving - Windows 11

Hi very nice lib! I've been experimenting with it to control mouse movement on Windows 11.
I'm encountering an issue where, when I execute the following code every second using a timer:
var simulator = new EventSimulator();
        simulator.SimulateMouseMovementRelative(0, 0);

The mouse consistently moves to the top-left corner.
Environment:
Operating System: Windows 11
Library Version: 5.3.1
Additional Information:

This issue is reproducible consistently.
No error messages or exceptions are thrown during execution.

Hello! Thanks for posting this issue! I will investigate it in the nearest future.

Same as the SimulateMouseMovement

Sorry about the delay, but I've finally managed to fix the issue.
Here's the code I used to test that the mouse coordinates don't actually change when moving by 0 pixels:
using var hook = new SimpleReactiveGlobalHook();

hook.MouseMoved
    .Select(e => (e.Data.X, e.Data.Y))
    .DistinctUntilChanged()
    .Buffer(2, 1)
    .Subscribe(coords => Console.WriteLine($"Mouse moved by: ({coords[1].X - coords[0].X}, {coords[1].Y - coords[0].Y})"));

_ = hook.RunAsync();

Thread.Sleep(1000);

var simulator = new EventSimulator();

for (int i = 0; i < 10000; i++)
{
    simulator.SimulateMouseMovementRelative(0, 0);
}

With the current version of libuiohook I got the following output in one of the runs (the output is more or less random):
Mouse moved by: (-1, -1)
Mouse moved by: (-1, -1)
Mouse moved by: (-1, -1)
Mouse moved by: (-1, -1)
Mouse moved by: (-1, -1)
Mouse moved by: (-1, -1)
Mouse moved by: (-1, -1)
Mouse moved by: (-1, -1)
Mouse moved by: (-1, -1)

With the new version I've got no output which is expected.
I will release a new version with the fix shortly.

I've just released version 5.3.2 which fixes this bug so this issue can be closed.


📦 Consume Bang from a package

Depends on https://github.com/isadorasophia/bang/pull/23 so we can update bang faster when needed.
This removes the bang submodule and instead consumes bang from a NuGet package

So I've been thinking about this, I think I still want to keep this as a submodule for a while. There's still a lot of ongoing changes (.NET 8/etc) and I want to prioritize a faster development right now.
I would be okay switching just the Analyzers and Generators for a package, though, what do you think?

Given the above I'm closing this as obsolete and will instead focus on making Murder package-able :)


Warnings with gcc-8.1.0

Build environment:
Ubuntu Server 18.04
Compiler: gcc 8.1.0 (installed from repositories)
Build: without X11, gtests, OpenCL
Used cmake options:
cmake --no-warn-unused-cli -Wno-dev -G "Unix Makefiles" -DCMAKE_C_FLAGS_RELEASE="-O2 -Wformat -Wformat-security -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong" -DCMAKE_CXX_FLAGS_RELEASE="-O2 -Wformat -Wformat-security -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong" ..cmake --no-warn-unused-cli -Wno-dev -G "Unix Makefiles" -DCMAKE_C_FLAGS_RELEASE="-O2 -Wformat -Wformat-security -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong" -DCMAKE_CXX_FLAGS_RELEASE="-O2 -Wformat -Wformat-security -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong" ..

Output of cmake:
Not searching for unused variables given on the command line.
-- The C compiler identification is GNU 8.1.0
-- The CXX compiler identification is GNU 8.1.0
-- Check for working C compiler: /usr/bin/gcc-8
-- Check for working C compiler: /usr/bin/gcc-8 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/g++-8
-- Check for working CXX compiler: /usr/bin/g++-8 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- No build type selected, default to release
-- Intel OpenCL SDK was not found (optional). The following will not be built: rotate_opencl plugin.
-- CMAKE_INSTALL_PREFIX=/opt/intel/mediasdk
-- Intel(R) Media SDK was found here /localdisk/tmp/MediaSDK-gcc8
-- Enabling API 1.27 feature set with flags
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for module 'libva>=0.33'
--   Found libva, version 1.1.0
-- Checking for module 'libdrm'
--   Found libdrm, version 2.4.91
-- Checking for module 'libva-drm>=0.33'
--   Found libva-drm, version 1.1.0
-- Checking for module 'x11'
--   No package 'x11' found
-- Checking for module 'libva-x11>=0.33'
--   No package 'libva-x11' found
-- x11 modules not found (optional). Samples will be built without x11 support
-- Google tests libraries and headers were not found! Build GTest and install to /usr/local.
-- Global Configuration of Targets
-- Target Architecture to compile: sse4.2
-- CMAKE_INSTALL_PREFIX=/opt/intel/mediasdk
-- MFX_PLUGINS_DIR=/opt/intel/mediasdk/plugins
-- MFX_MODULES_DIR=/opt/intel/mediasdk/lib
-- Checking for module 'libdrm'
--   Found libdrm, version 2.4.91
-- Checking for module 'pciaccess'
--   Found pciaccess, version 0.14
-- Google tests was not found (optional), the following will not be built: test_monitor.
-- Intel OpenCL SDK was not found (optional). The following will not be built: rotate_opencl plugin.

 Please, be aware. We are working on resolution.

@mgonchar : could you, please, look into and fix gcc-8.1 warnings in FEI part?

@dvrogozh looked through the log. Looks like gcc-8.1 doesn't like our common practice of memsetting POD structures right after creation. Will add default initializers for them

@mgonchar : yep, it does not. Thank you. FYI: CI for gcc-8.1 will be ready and enabled (if all is ok) today/tomorrow (without -Werror). As a next step we need 0 warnings level on gcc-8.1 to use -Werror. Hence, we need to fix this bug...

PR #405 should fix most of the warnings except these 2 in sample_hevc_fei_abr:
/localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/src/dso/hevc2_ssdata.cpp: In member function ‘BS_HEVC2::TU* BS_HEVC2::SDParser::parseTT(BS_HEVC2::CU&, BS_HEVC2::TU&, BS_HEVC2::TU&, Bs16u)’:
/localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/src/dso/hevc2_ssdata.cpp:1190:34: error: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘struct BS_HEVC2::TU’; use assignment or value-initialization instead [-Werror=class-memaccess]
         memset(&tu, 0, sizeof(tu));
                                  ^
In file included from /localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/include/dso/hevc2_parser.h:26,
                 from /localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/src/dso/hevc2_ssdata.cpp:21:
/localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/include/dso/hevc2_struct.h:800:8: note: ‘struct BS_HEVC2::TU’ declared here
 struct TU
        ^~
In file included from /localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/include/dso/hevc2_parser.h:24,
                 from /localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/src/dso/hevc2_ssdata.cpp:21:
/localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/include/dso/bs_mem+.h: In instantiation of ‘BS_MEM::MemObj<T>::MemObj(unsigned int, bool) [with T = BS_HEVC2::TU]’:
/localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/include/dso/bs_mem+.h:158:25:   required from ‘T* BS_MEM::Allocator::alloc(void*, unsigned int) [with T = BS_HEVC2::TU]’
/localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/src/dso/hevc2_ssdata.cpp:228:61:   required from here
/localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/include/dso/bs_mem+.h:56:19: error: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘struct BS_HEVC2::TU’; use assignment or value-initialization instead [-Werror=class-memaccess]
             memset(m_obj, 0, sizeof(T) * count);
             ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/include/dso/hevc2_parser.h:26,
                 from /localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/src/dso/hevc2_ssdata.cpp:21:
/localdisk/tmp-drogozh/MediaSDK/samples/sample_hevc_fei_abr/include/dso/hevc2_struct.h:800:8: note: ‘struct BS_HEVC2::TU’ declared here
 struct TU
        ^~

@dmitryermilov, @mgonchar : I need your help to fix these!

Ok, https://github.com/Intel-Media-SDK/MediaSDK/pull/408 was just merged and I think this is the last piece of gcc-8.1 warnings puzzle. @adydychk : please, try to enable -Werror for gcc-8.1 build ASAP.

This is fixed, CI switched to have -Werror with gcc-8.1 compiler.


General: Allow instructors to flag competencies as optional

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Server

[ ] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[ ] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[ ] I documented the Java code using JavaDoc style.

Client

[ ] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[ ] I followed the coding and design guidelines.
[ ] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context
To allow instructors to create proper competency-based learning there has to be a differentiation between required and optional competencies.
Description
This PR allows instructors to set competencies as optional.

Competencies can be set as optional if they are not linked to exercises that are included in the course score
The flag (Optional: Yes/No) is visible in the competency management table
When editing a competency that is linked to exercises that are included in the course score, the checkbox to set the competency as optional is disabled
Competency Cards and Details-View show an Optional-Badge
Exercises that are included in the course score can't be linked to optional competencies
When configuring an exercise the Competency-Selection shows only non-optional competencies if the exercise is included in the course score

Steps for Testing

Prerequisites:

1 Instructor

Create a competency, set the competency to optional
make sure the competency-management table shows the correct flag
create a second competency that is not optional

For each exercise type:

create exercise that is included in the course score
check that you optional-competency is not visible in the competency-selection and try to link one of the competencies
edit the exercise and set it to be not included in the course score
make sure you can now see the optional competency and try to link it to the exercise

[ ] Programming
[ ] Quiz
[ ] Modeling
[ ] Text
[ ] File

For each lecture unit:

create lecture unit
check that you can link it to all competencies (except if it's an exercise that's included in the course score)

[ ] Text
[ ] Exercise
[ ] Video
[ ] Online
[ ] File

Review Progress

Performance Review

[ ] I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Codecov Report

Merging #6669 (1a7748a) into develop (c2b8ecf) will increase coverage by 4.26%.
The diff coverage is 84.31%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6669      +/-   ##
=============================================
+ Coverage      76.07%   80.33%   +4.26%
- Complexity         0    13703   +13703
=============================================
  Files           1280     2425    +1145
  Lines          48104    92246   +44142
  Branches        8409    12947    +4538
=============================================
+ Hits           36596    74108   +37512
- Misses          5854    10005    +4151
- Partials        5654     8133    +2479

Impacted Files
Coverage Δ

src/main/webapp/app/entities/learningGoal.model.ts
70.37% <ø> (ø)

...oal-selection/learning-goal-selection.component.ts
79.06% <66.66%> (-0.94%)
:arrow_down:

...learning-goal-form/learning-goal-form.component.ts
74.76% <72.72%> (-1.10%)
:arrow_down:

...java/de/tum/in/www1/artemis/domain/Competency.java
83.05% <100.00%> (ø)

...n/java/de/tum/in/www1/artemis/domain/Exercise.java
87.30% <100.00%> (ø)

...tum/in/www1/artemis/service/CompetencyService.java
95.18% <100.00%> (ø)

...m/in/www1/artemis/web/rest/CompetencyResource.java
95.12% <100.00%> (ø)

...te-learning-goal/create-learning-goal.component.ts
81.81% <100.00%> (+0.42%)
:arrow_up:

...edit-learning-goal/edit-learning-goal.component.ts
86.53% <100.00%> (+0.26%)
:arrow_up:

...mponents/programming-exercise-problem.component.ts
100.00% <100.00%> (ø)

... and 1 more

... and 1143 files with indirect coverage changes

Flag
Coverage Δ

client
76.08% <77.77%> (+<0.01%)
:arrow_up:

server
84.98% <100.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b8ecf...1a7748a. Read the comment docs.

Tested on ts1 with the following findings:

Exercise lecture units cannot be linked.

@lennart-keller Are you sure that the exercise was not included in the course score? I can not reproduce this.

Editing competencies doesn't show linked lecture units
I think this should be addressed in another issue.


SoundCloud Battery

Describe the changes you have made in this PR
Added integration for SoundCloud
Link this PR to an issue
#1348
Type of change (Remove other not matching type)

feat: New feature (non-breaking change which adds functionality)

Demo
https://user-images.githubusercontent.com/64399555/187685931-cea0251d-711d-4085-840d-9ff1cfdef69e.mp4
Checklist

[x] My code follows the style guidelines of this project, and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@AnastasiaVolk does this look good?

@bumi [  ] (https://www.loom.com/share/883c525429ff4cbfb38af3fabdcbd91c) all good!

Now the important thing the donation link appears in the wallet dashboard on getalby.com #207 and after SC and MC are needed to be added to value4value section (As well as in the Integration section in the Account on getalby.com)

@im-adithya we should try one thing here:
extract the information from a https://getalby.com/p/[LN-ADDRESS] link. for example:
https://getalby.com/p/monvol -> should be a ln address<EMAIL_ADDRESS>if we do this in the helpers.ts then this would extract that link automatically from the other platforms, too.
so we check for either the ⚡that we currently have OR check for https://getalby.com/p/(\w+)
this allows users to actually put the link there which then works for users that do not have the Alby extension installed.

This is great! Didn't know about this earlier; added support now!

for that to work we need to check the href of the profile links.
document.querySelector(".web-profiles a[href*='getalby.com']").href

soundcloud uses some redirect there, so we have to get the URL from that href: "https://gate.sc/?url=https%3A%2F%2Fgetalby.com%2Fmonvol&token=7f1dd6-1-1662050178940"

@AnastasiaVolk can you update your link to getalby.com/p/monvol? - when publishing this we should use the /p/ for technical reasons.

@bumi done, working ) then it should be the same with YouTube..

yes, we always use the /p/... URL - that makes it easier for us to identify those profile URLs.
Will be shown on getalby.com - as per your other issue.


Added note to preview option.

Just added overflow:hidden to preview Option in README.md https://github.com/fengyuanchen/cropper/issues/386

Good! Thank you!


Value cannot be changed on new label

version: eef16bcb5e84cf73b570a2b98c99288b4f7fd23f
I cannot set a value under 'value' (text box does not react when i click on it)

      self.value_line_edit.setEnabled(False) # To be changed at resolution of Issue #28 - line 1411 in the main branch
By enabling the field, this should resolve this issue. I will try to look into issue #28.


Add test to show dispatching middleware is recursive

We show that it's not safe to use the mock with middleware
that dispatches actions itself.
However, this is working with the standard store implementation.
It would be nice if someone could fix the issue.

@Byron-TW Do you know how they implement it in redux to avoid dispatching itself? /cc @gaeron

Sorry for the late reply ! I have rechecked this and came to believe that they actually have no protection against this either. The reason this ever seemed to work is more complex internal logic in the middleware itself.
Thus I think there is nothing to be done here.


Implement getCounter function

I need this function for createOrder.
My attempts to add it has a function under seaport impl have been ... so I'm thinking of using traits instead.
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=55d62283d88a5d09e79c73569acf04b5
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9266c06a71c1a4ac67f146831907a5b0

fixed https://github.com/Perelyn-sama/seaport-rs/commit/f3390b6dfa7308dc9d8d0a1e22e9e400250a0b49


Add MySql POINT DataType To Prisma

Problem
MySql POINT Datatype is an unsupported type for prisma to map to. At least convert the value to string type?
Suggested solution
Convert it to a string using ST_AsText(point)
Alternatives
Currently i am using raw sql which somewhat defeats the purpose of using an ORM.
type Test = {
coordinates: string
}
const test:Test = await client.$queryRaw`select ST_AsText(coordinates) as coordinates from test_table`

OR

let temp = await client.$queryRaw`SELECT ST_X(coordinates) AS longitude, ST_Y(coordinates) AS latitude FROM test_table`

This gets me around the issues for now but its nice to have the orm updated when my tables are changed instead of having to update this raw select query.
Additional context
I am using Prisma with MySql and Next.js application.

Is this covered by https://github.com/prisma/prisma2/issues/1798?

Ah so its planned to be implemented according to what you linked me to

Not necessarily "planned", but it is a highly requested feature already that we track in that issue. I'll close this one then. Thanks!


Define alert as int not bool

Closes #1
To be honest I'm not sure if this is the correct fix, but it successfully flashed for me after making the change.
@jimblom
Cheers!

Looks like the error was due to an update to the Particle.variable() API. As of firmware 0.4.7, you no longer have to declare the variable type along with initializing a Particle variable.
The latest commit fixes the error in the example. v1.1.2 is pushed to Particle Build.
Thanks for the heads up!

Excellent, thanks!


Improve FloatingActionMenu

[ ] The animation isn't quite the same as the Speed dial presented in the Material Design Guidelines
[ ] The RotationTransitionDrawable should also rotate pre-Honeycomb with the help of the new ValueAnimatorCompat

Any other suggestions for improving the FloatingActionMenu? Feel free to comment below!

You could make an option to choose the distance between the menu buttons, that would be helpful :)

@sedestrian Good idea! Added it to the list.

Great!

@sedestrian You can now customize the button spacing in release 0.3.0 by using the app:fabMenuSpacing attribute. Thanks for the patience!

The visibility should be changed to "INVISIBLE" instead of "GONE". The top FAB label is still visible if GONE is used.

@athospg Thanks, I'm aware of this :smiley:, this is currently a work in progress (I'm currently working on the LabelView, after that is finished this issue should be gone).

All features here are now implemented and will be released as part of Release 0.4.0 by the end of next week, so I'll be closing this issue now.


Suggestion: Netherite Block extends range further.

I have a suggestion. A netherite block could increase the range even further, to let's say 20. Just an idea. Love the mod!

You can create custom values all on your own @seanimusprime.


Redis Lego: Delete keys matching a pattern

Write a lego to delete keys in Redis matching a given pattern.

This is live in production - I think we can close


fix [wordpress] php version not set test

This plugin now does declare a PHP version requirement. Rather than trying to find another live package to test against I've just switched this to a mocked test.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS against efff24c06f28b8697aed946696c91525fb0afbb2