Support Procs as a filter

Just wondering, has there even been any thoughts on support proc as a filter? e.g.
class Foo < ActiveInteraction::Base
  proc :my_callback, arity: 2
end

Foo.run(my_callback: ->(arg1, arg2) { ... })

I'm finding myself needing it right about now. :-)

Proc filters aren't built into ActiveInteraction, but there are two ways you can get them.

Create an object filter with class: Proc.
Create an interface filter with methods: %I[call].

ActiveInteraction doesn't provide them out of the box because it's designed for use on the web. You can't really send a Proc over the wire.
Checking the arity can be done in a custom validator.

In fairness, you can't really send objects or interfaces over the wire either. Like interface, this could be used for dependency injection.

When you say "for use on the web", do you mean to take inputs from only form params?
We've been using interactions for everything and it's been working great. Want to move this model's state from one to another? There's an interaction for that!
Our models are merely for validation and state declarations. Providing an interaction for every task allows us to perform complex operations involving database table locking as well as calling many nested interactions that share the same principles. I wonder how many people are doing the same?
Yes, we do have interactions that take "web inputs" but we quickly coerce or mutate them into proper classes before passing them through to the nested interactions. For example: money is always passed through as an "cents" represented by an Integer. Once we get ahold of that input, the interaction changes it to a Money object before passing it along to other interactions.
If this is completely outside the scope of AI then I can understand that. But if you think AI can possibly go beyond just taking "web inputs" then it opens the door for a lot of cool things like project-custom filters.

As Aaron pointed out, what I said wasn't accurate.
I'm not opposed to adding a proc filter. Out of curiosity, why are you using Procs instead of compose with another interaction?

I'm using it as a callback. As in, "this interaction requires a callback."
class CreateInvoice < ActiveInteraction::Base
  proc :callback, arity: 1

  def execute
    invoice = Invoice.create(...)

    callback.call(invoice)

    invoice.finalize!
  end
end

I think @tfausak was asking why a callback instead of wrapping it in another interaction and composing it in.

Because the callback can be different each time the interaction is executed. Wrapping it in another interaction and composing it would mean hardcoding which interaction is composed, no?

Right, you'd have to have a separate wrapping interaction to replace each callback. Can you help us to understand the advantage of the proc over wrapping the interaction? Are there lots of callbacks and it would be tons of work to wrap them all? Does it make the calling code really ugly if each callback case is a separate interaction?

Hey guys, I've just decided to go with object :foo, class: Proc.


deepstream 3.1.0 crash on this._handleForceWriteAcknowledgement is not a function

Worked fine on deepstream 3.0.1 but crashed immediately on starting backend client. Was there API change between deepstream 3.0.1 and 3.1.0?
C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\async.js:61
        fn = function () { throw arg; };
                           ^

TypeError: this._handleForceWriteAcknowledgement is not a function
    at _options.cache.set ([eval]:47684:14)
    at tryCatcher (C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\util.js:16:23)
    at Promise.successAdapter [as _fulfillmentHandler0] (C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\nodeify.js:23:30)
    at Promise._settlePromise (C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\promise.js:566:21)
    at Promise._settlePromise0 (C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\promise.js:614:10)
    at Promise._settlePromises (C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\promise.js:693:18)
    at Async._drainQueue (C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\async.js:133:16)
    at Async._drainQueues (C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\async.js:143:10)
    at Immediate.Async.drainQueues (C:\Projects\DS\server\deepstream\lib\deepstream.io-cache-redis\node_modules\bluebird\js\release\async.js:17:14)
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)

Thanks for this, looks like a regression that was introduced between 3.0.1 and 3.1.0.
Fixed in 3.1.1

Looks like Windows build of deepstream 3.1.1 still missing.


Agree on definitions of project board elements

Ask Laurie what the difference is between task, story and epic

Is a story in the project board the same as a user story?

Provide a link to where these definitions exists so that we can share them with the team
@jiaxinmachine88 and @tschaffter to agree on the definitions before sharing them with the rest of the team

@jiaxinmachine88 Now tracking this task at the workstream level.


feat: Farcaster frame mint is live - notification on landing page

Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Feature

Needs Design check

@exezbcz please review

Context

[x] Closes #10111

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Looking good! thank you

one thing maybe, is it dynamic? e.g. does it take the img and a name from some sort of database so it can be updated without release?

small stuff

Thanks, all updated

one thing maybe, is it dynamic? e.g. does it take the img and a name from some sort of database so it can be updated without release?

No, it's a static config. Currently, we do not have the API to achieve it.

works-for-me

maybe if you could switch the img and name to this

and link to this: https://warpcast.com/th0mas-art/0x47bfc921

maybe if you could switch the img and name to this
and link to this: https://warpcast.com/th0mas-art/0x47bfc921

✅ Done

thanks a lot, letsgo


Exception "_auth_delegate" attribute error when accessing password protected servers

See
https://github.com/geopython/OWSLib/issues/762
Workaround: install owslib version 0.21 (0.22 does not have this error, but was very quickly replaced by 0.23)

intermediate solution by a build fixation for owslib.
https://github.com/conda-forge/mss-feedstock/pull/90

Seems fixed in 0.24.1


[BugFix] Fix bug add plugin has intermediate state

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #20468
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[x] 2.4
[x] 2.3

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3


[UX]: Improve copy of "Undefined" token supply

URGENCY

[ ] High
[ ] Medium
[X] Low
[X] I don't know

PRODUCT ENVIRONMENT
Staging
DESCRIPTION OF ISSUE
Description
The copy for "Undefined" token supply can probably be replaced with "Unknown" or some other variant.

DEVICE / VIEWPORT

[X] Desktop
[ ] Mobile

STEPS TO REPRODUCE

Navigate to https://explorer.dev.oasis.io/mainnet/sapphire/token/0x998633BDF6eE32A9CcA6c9A247F428596e8e65d8
See "Undefined"

ALTERNATIVES AND SUGGESTIONS
"Unknown" or "Unlimited" or "Arbitrarily large"

I would propose an unobtrusive "-" like we do for "Active Nodes" panel if we don't have the data from the backend.

OK, #742 will solve this.

Closed via https://github.com/oasisprotocol/explorer/pull/742.


Silence Info.plist patching warning

The output of this command can be completely silenced.

The PR title is fine, I'll add an exception for it.


win10 installed office365 ,but this plugin doesn't work

I'm also experiencing the same issue. File Explorer Preview pane reveals nothing of the file selected.

Same here. Is this repo still being maintained, even?

This repo is not being watched by anyone. All instructions are written in https://github.com/QL-Win/QuickLook/wiki/Available-Plugins.

I see no instructions referring to how to fix this issue.
My office365 is installed via download, not the store, and still doesn't work.

作者能不能更新一下，office365不能使用贼难受，现在图片预览都不行了。


Half of the links on https://uppload.js.org/ are 404

Half of the links on https://uppload.js.org/ are 404

All the links on the website are working again!


JavaScript global variables in TagUI

Raising this from an user email for sharing, as other users might benefit from this question.

Suppose I've written a lot of different modules, and there are a couple of variables that I would like to use across all modules. In standard javascript script, I can have global javascript variables, something like the following:
var carName = "Audi";
// code here can use carName
function myFunction() {
// code here can use carName
}
How do I do this in TagUI, since your .js is auto-generated. I looked at the generated code. It seems that any variables are enclosed in {. } => all are local variables. Do you have somewhere we can specify the codes that will go into the first section of .js? If yes, I can put the global variables there. For your advice, please.

The execution context is within the CasperJS + PhantomJS framework and that design is made by the framework for good reasons (to isolate from actual webpage DOM). Normally variables defined in TagUI can be used in other subsequent steps or functions, for example below -
Try this -
http://google.com
name = 'Alan'
echo name
js begin
function addSurname() {
name = name + ' Toh'
}
js finish
addSurname();
echo name

The result will be -
Alan
Alan Toh


Getting ERROR in Maximum call stack size exceeded

ERROR in Maximum call stack size exceeded When i ng build --prod
Please help me...

I am getting this error as well.
@dalelotts

Hey, thanks for the info, but this isn't enough information for me to diagnose. Can either of you provide more information?

I created a new project using ng new, and imported the component. Here's the zip: ngx-bs-dtp-demo.zip
After downloading, go into directory and run npm install, and then ng build --prod

Thanks @ChaudhryAtif, having a look now.

I'm stumped at the moment.
Do you need the input directive? If not, the previous version 2.2.1 does not have this problem.

I was hoping to use the input directive, but didn't have a good example to get it going. There's an example for inline calendar, but not for input / dropdown.
When you get this resolved, can you add an example using the input / dropdown like in AngularJS version?
This might need to be another thread/question, but how do I go about configuring the picker like min/max date, etc?

@ChaudhryAtif have a loot at the demo page and the selectFilter documentation

You can use this version without --prod for now. I don't know when I will get this resolved. I'm over my head in rollup, barrels, and the TypeScript compiler trying to solve it.

I've been waiting to see if updates to the angular-cli fix this, but some of the related errors I've seen on The Internet (TM), circular dependencies in lazy loaded modules can cause this issue.

@cthrax I looked at this a bit and found the where the infinite loop is happening - basically two imports resolve to the same relative path - I don't recall at the moment the exact line of code (it is fairly easy to find). I don't know enough about ngc at this point to fix either my code or ngc. =)  I'm swamped with paid work for the next several months so I don't expect to work on this any time soon. So sorry for the delay. I hope since this is all new functionality in 3.0 nobody is impacted

Ok, thanks for the update
On Tue, 21 May 2019 at 08:18, Dale Lotts<EMAIL_ADDRESS>wrote:

@cthrax https://github.com/cthrax I looked at this a bit and found the
where the infinite loop is happening - basically two imports resolve to the
same relative path - I don't recall at the moment the exact line of code
(it is fairly easy to find). I don't know enough about ngc at this point to
fix either my code or ngc. =) I'm swamped with paid work for the next
several months so I don't expect to work on this any time soon. So sorry
for the delay. I hope since this is all new functionality in 3.0 nobody is
impacted
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dalelotts/angular-bootstrap-datetimepicker/issues/440?email_source=notifications&email_token=AAYZV6DRHMGHOKEITRQSCZDPWNPIJA5CNFSM4HJ6Z2T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2S73Q#issuecomment-494219246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYZV6CXUSBUA4HDO6WS7YTPWNPIJANCNFSM4HJ6Z2TQ
.

--
Thank You
Dhananjay Vaidya
Potpie Web Solutions

I am facing same problem => ERROR in Maximum call stack size exceeded when build using --aot=true.Please help

I am also facing the same problem in angular 7 .
@dalelotts if you doest have enough time to resolve this issue with the version 3.0 can you please hire some body or atleast help us about that ?
That will be really appreciating if you do so.

@btanmoy that's not how open source works. If you would like a fix, you can fix it, or as you suggest you can hire someone to fix it, but open source is created by volunteers and freely distributed. You have all the power and all the pitfalls of a piece of software owned by the community.

@)dalelotts any updates about the error ERROR in Maximum call stack size exceeded when build using --aot=true.please help

I have not looked since my last update. I don't expect to have time to look at this until September at the earliest.

@)dalelotts thanks for your update.I am waiting for your cooperation because this is very vital issue.thanks again

import {DlDateTimePickerChange,DateButton} from 'angular-bootstrap-datetimepicker';
when I import this, I build by ng build --prod --build-optimizer --base-href /admin --deploy-url /admin/
I met the same issue
ERROR in Maximum call stack size exceeded

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I got the same error. I just downgraded to 2.2.1 and replaced my imports with 'DlDateTimePickerDateModule' and it worked.

I got the same error. I just downgraded to 2.2.1 and replaced my imports with 'DlDateTimePickerDateModule' and it worked.

Thank you @twu14, your suggestion worked. A temporary solution that will suffice for the time being!

I got the same error. I just downgraded to 2.2.1 and replaced my imports with 'DlDateTimePickerDateModule' and it worked.

That worked fine

I got the same error. I just downgraded to 2.2.1 and replaced my imports with 'DlDateTimePickerDateModule' and it worked.

I have done as u said but now how to use it as a component?

I'm stumped at the moment.
Do you need the input directive? If not, the previous version 2.2.1 does not have this problem.

Downgrading to 2.2.1 solved the issue for me. Thanks.

yeap, 2.2.1 is worked.

:tada: This issue has been resolved in version 3.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Does not seem to be fixed - published module does not behave the same as local

:tada: This issue has been resolved in version 3.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

My testing shows this is fixed now. Sorry about the delay.

@dalelotts thanks! I attempted to fix this and couldn't get the local build to exhibit the issue. It was a head scratcher. So did you have index files causing issues with the full path imports?

Hey @cthrax, I agree, it was a real head scratcher. No stack trace, nothing helpful from the error message, does not happen in this project, and only happens in projects that consume this module.
I'll try to explain...I found a few comments that when a webpack project is building all of the imports must come from the same barrel - I tried countless variations and eventually settled on the simplest possible brute-force solution - everything must be imported from public-api  except the top level module.
Given all of this, I expected this error to happen when doing a local prod build on this project.
I know that it is possible to build this in such a way as to allow deeper imports and it will still work, I just had to time box it to 100 hours =)
I think a good long debugging session on webpack would shed some light on what is happening. Any volunteers? =)


Add Feature to Ignore IP addresses in subdomain scan

I was using CloudFail on a domain with a wildcard dns entry, and it was spitting out false positives with the same IP. So I added a flag which allows you to ignore results that match an ip address (or in list of IP's) to avoid seeing junk results. One or Multiple IP addresses can be added to the -i/--ignore parameter with space as a delimiter.
Usage looks like this: python3 cloudfail.py -t <target> -i <ip1> <ip2>
If you have any questions or additional edits, let me know :) Happy to make changes if needed!

Interesting approach.
My pull request regarding this problem has been open for a year now. Good luck with yours

@DatDraggy lol I didnt even look before making this. Hopefully one of us gets merged! 👍 My Dockerfile PR did, but that was two years ago)

I think both solutions could be merged. If I already have an IP for sure I don't need to see it again ^^ Useful in some cases imo

@DatDraggy @samsheff Hi guys, apologies for being a ghost the past year, life has taken a very busy turn it seems and I generally don't have much time in-front of a computer that's not in the office...

Oh no worries. This is just an open source project and people were still able to use our forks.
IRL things are of course more important.

what happenned to this?


Use conda-build >=2.1.7

This conda-build version fixes an error in symlinks.
cc @jakirkham

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I'm going to merge this to see if it fixes the problem https://github.com/conda-forge/sagelib-feedstock/issues/7


Happy for suggestions on how to improve the Rule. Was at first trying to walk the PSI Tree, but that would require lots of manual whitespace and codeword counting if I understood it correctly.

Awesome thx!


Addding myself as a project owner

I know we want expand and diversify this list in the near future, but for now this should help get some PRs approved a bit faster.

/lgtm

/approve


Add a git tag for 3.1.0

Looks like tablesort 3.1.0 has been released (congrats!), but it's not yet tagged on git.
Shouldn't be too hard to do.

Thanks for the catch. Done in https://github.com/tristen/tablesort/releases/tag/v3.1.0


double_float benefit from eval_log series for arg near 1

For the implementation of eval_log()in the cpp_double_float class, consider making a special approximation for log near argument 1.


Malformed URLs in search results

Details
I'm having trouble getting search results to work properly on the Cyphon project.
Project Name: cyphon
Project URL: https://github.com/dunbarcyber/cyphon
Build URL: https://readthedocs.org/projects/cyphon/builds/5366489/
Read the Docs username: lhadjchikh
Expected Result
Search results should list valid links to pages in the documentation.
Actual Result
Search results list links that don't exist. For example, this search yields this result.
I don't see this issue on my local build, so I'm guessing this may be due to the build on RTD timing out before the makeindex step. Would it be possible to increase the timeout setting for the project to see if that fixes the issue?
Thanks for your help!

Correct. This is a duplicate issue around a bug related to us upgrading to Sphinx 1.5. Closing this here, I'm working to address the bug.

Awesome, thank you!


Implicit stuff

See blog post:
http://dpldocs.info/this-week-in-arsd/Blog.Posted_2024_02_20.html

Are you going to add some tests for these novel features?

Tests don't run anyway so what's the point?
I'll instead use them in a real world application.

The tests are useful if you run the manually, like before a release in order to ensure nothing is broken. Tests are your friend and you have probably already written them in order to test your implementation so why not save them.


compression: enable use of decompression errors

Description: The decompression library uses a RELEASE_ASSERT to verify there are no decompression errors. This is because today the decompression library is only used for testing the gzip compression filter, however this makes it impractical for anyone to use the decompression library for a filter.
Risk Level: Low
Testing: Added
Docs Changes: N/A
Release Notes: N/A
cc @gsagula
Signed-off-by: Derek Argueta<EMAIL_ADDRESS>

Should https://github.com/envoyproxy/envoy/pull/7057 be merged first?

@jmarantz I don't think it actually matters which lands first - having looked through that PR it doesn't touch the decompression code at all, just compression. The decompressor is currently only used by testing code to validate the output of the gzip filter:
$ git grep "ZlibDecompressorImpl" | cut -d ':' -f 1 | uniq
source/common/decompressor/zlib_decompressor_impl.cc
source/common/decompressor/zlib_decompressor_impl.h
test/common/compressor/compressor_fuzz_test.cc
test/common/decompressor/zlib_decompressor_impl_test.cc
test/extensions/filters/http/gzip/gzip_filter_integration_test.cc
test/extensions/filters/http/gzip/gzip_filter_test.cc

but I'm perfectly happy to wait for the gzip generalization PR to land, no rush on this.

/wait

@jmarantz going to revisit this later, it hasn't been high in my queue. I'm also thinking it'd be nice to have compress and decompress have a symmetrical API of returning an error code - it'd be odd for only decompress to return the error to the user.

Sure, symmetry is a good goal. But what kind of error would you get while
compressing, other than maybe "out of memory"?
On Fri, Nov 22, 2019, 8:27 PM Derek Argueta<EMAIL_ADDRESS>wrote:

@jmarantz https://github.com/jmarantz going to revisit this later, it
hasn't been high in my queue. I'm also thinking it'd be nice to have
compress and decompress have a symmetrical API of returning an error code

it'd be odd for only decompress to return the error to the user.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/8599?email_source=notifications&email_token=AAO2IPMQNTBSZ67SHUHQVVTQVCBGTA5CNFSM4JAFGB7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7JZ6Y#issuecomment-557751547,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO2IPLZDNPMNXADENTAXYTQVCBGTANCNFSM4JAFGB7A
.

hmm that's a great point. Compression tends to be error-free (besides system issues i.e. memory), whereas decompression mandates a known format that, if corrupt or invalid in any other way, can easily surface an actual error that should be handled by the user. From that perspective, the asymmetry actually seems fine.


onChange event does not get triggered when using keyboard to change AM / PM on the time picker

The onChange event is not firing when changing AM/PM from keyboard but it does when clicked with the mouse.
See the following screen capture and fiddle.
Your Environment

flatpickr version used: v4.6.13
Browser name and version: Chrome latest
OS and version: Windows 10 latest

Screen Capture

Fiddle
https://jsfiddle.net/jq5sma6d/ (Don't forget to enable the console pane)

Appears to be a dupe of #2224

If anyone is using Laravel Livewire with this problem, here is how I resolved it:
If your input is deferred, e.g. wire:model.defer="myProperyName"
Add the following to the flatpickr instance:
"onValueUpdate": function(selectedDates, dateStr, instance) {
    @this.set("myProperyName", dateStr, true);
},

Otherwise, if your input is live or lazy, e.g.  wire:model="myProperyName" or wire:model.lazy="myProperyName"
Add the following to the flatpickr instance:
"onClose": function(selectedDates, dateStr, instance) {
    @this.set("myProperyName", dateStr);
}


Adds reading geometry from feature property

This allows users to pass in an openlayers geometry directly (e.g. if geometry JSON was obtained through an API call)

For all our other geometries they are passed as children to the Feature component, and I'd rather follow this pattern even for geometries that are fetched over an API. I've therefore added a RawGeometry component which does the same thing. Take a look here:
https://github.com/richardhills/ol-react/commit/a0ad136fa73f252560d00963adda4fd8e9bfdc67

I like this approach. As I get doing a little bit more I used the getType() from OpenLayers to construct the proper component as well.


face_colors Property missing?

I was trying to create a viewer using three.js and manage to make work fine but I tested some files and found this face_colors that does not exist in the schema.
Looks like this face_colors is the color of each face when the mesh needs to have different colors.
https://github.com/kovacsv/dotbim-archicad/blob/d50b54a33c586090b3fee947cf67c8268c201244/Sources/AddOn/DotbimExporter.cpp#L188

Yes, you're right, there is no face_colors right now, as it is an extension of a schema described here: https://github.com/paireks/dotbim-extensions-multicolor, while the library keeps core schema (same is with Typescript and Python library).
Generally as simple as it looks at first glance - it's actually quite complex (and subjective) topic on multiple levels. I can discuss it here or in DM if you want cause it will take a while :)
Right now as far as I know currently face_colors extension is supported by Archicad plugin and Online3dViewer.

I just found it a little odd that the face_colors are in the Element and not inside the Mesh with the indices and coordinates.
Could be neat to have work in both places actually. DM probably gonna be better 😁

Kinda work!

Wow, it looks amazing!
Let me know if you will decide to release it somewhere!

Here is a base implementation: https://github.com/ricaun/dotbim.three.js
I propose to create propriety in the mesh called colors with something like this [ir,ig,ib,ia,jr,jg,jb,ja...] with one color for each face or one default color for all the faces in the mesh.
And the color in the element became optional and should overwrite the color in the mesh in a viewer. I believe makes more sense to remove the face_colors in the element and move to the mesh.

I believe that such change of an extension then should be proposed here first: https://github.com/paireks/dotbim-extensions-multicolor and then question for @kovacsv if Viktor likes it and agrees with it, and if he wants to change it in archicad plugin and Online 3d Viewer.
Then after that there is an open question how to handle extensions inside libraries like this one in C# but also in Python and Typescript libraries. Right now they all only holds data for core-schema, so it's quite straight-forward and doesn't require updates. I guess the default option would be to add there the properites for every extension there, but that could make it much more difficult and dirty if there will be more than 1 extensions as it is right now. E.g. I was considering adding extension where you do not color it by faces, but by vertices. Someone else could add extension for textures. And then we will find ourselves with 4 different methods of coloring objects in one schema that claimed itself as minimalist :) So open question is: should we (and how) support all extensions in libraries in a smart way without complicating it.

Defining face_colors on mesh level provides the ability to reuse meshes with different colors. For example you are able to place the same chair 10 times, all with different colors. On the other hand it would make sense to provide default face_colors on mesh level so it's used when there are no face_colors on element level. It would keep the flexibility, and the format would still remain backward compatible.

I don't think the extension in the main dotbim schema is a good idea, it all depends on the purpose of the dotbim.
This multicolor definitely is missing in the main schema, with colors probably, should be possible to make the colors work with faces or vertex depending on how many colors you provide in the array.
Now I don't know if makes sense to add colors or face_colors in the element level, makes it more flexible but I make the element really connected with the number of faces in the mesh_id.

If it should be in the main is actually really subjective. I had some long discussions in the past that e.g. supporting breps in the main schema is missing. Or maybe textures should be in the main schema? Also in the past the discussions was that in main schema I should add standardization of naming things (like in IFC providing how we should call beam, wall, and so on) :)
The goal of dotbim was to be as minimalist as it could be, yet still make it possible to transfer meshes with attached properties, which is in my opinion essence of BIM (some disagree on that ;)). The most minimalist way of handling colors is one color per element.
For most of the cases it is actually enough: e.g. all Tekla Structures models I've seen had such limitation, yet it still works and I've never seen anyone missing this feature. I believe MEP models similiarly deal with it. Cases where it's actually needed are the detailed models modelled by architects, where they actually want to color doors, windows, furnitures. Does it mean that with one color per element we cannot transfer it? Not really, because we still can disassemble by  colors and send it like this. You can see models like this here: https://3dviewer.net/#model=https://raw.githubusercontent.com/paireks/dotbim/master/test/ExampleFiles/TestFilesFromBlender/Chair 01.bim
The disanvantage of such approach is that rather than having 1 element you will have 2 or more then. That's why Viktor came up with the idea, that OK, if you want to have multiple colors on object and still have it as one element - place the colors there. Thing is later I've tried to apply it in various other places, and it's not so easy to apply everywhere. In Grasshopper there is not really an option to color one mesh with various different face colors. You have to disasseble it to multiple different elements, and color it separately. So still we are back in the same spot, that we have to disassemble it, but right now not on an exporter side, but importer side, and the result will be the same: multiple elements representing one :)
So because feature is really specific and because there can always be someone wanted to add something, color it differently (e.g. if someone wanted to transfer the colorful results of analysis by this, then vertex colors will be needed), the decision was that to put such features as an extensions rather than make the core grow same as it looks like for other schemas, that are constantly being expanded and developed, so they become more and more complex during the years to satisfy every workflow and everyone :)

The only way to create a cube with different face color in the current schema is creating 6 meshes and 6 element. And if I want 10 cubes instead I gonna need 60 elements, and if I need to change the color of one face I gonna need to change in each element that has that face.
The only reason that I have been start using dotbim is that is a Json standard for mesh/element and work in multiple platform, that viewer that can convert to a .bim file is really neat.
But technically the only want to get the face_colors in the current package is no using the package...
Maybe the schema should have a parameter like the info, a special place to add extension, a dictionary<string, object>. I don't know if is a good ideia, but adding colors in the mesh gonna maks mush easyer to work with the default package.
Probably gonna create my meshcolor extension...

Hmm, the idea of a dictionary<string, object> for extensions is pretty interesting, I will think about, maybe that will ressolve this :)
If there would be something like extension properties (similiar to extension methods), then that would work :D
I will think about it and let you know, if you will come up with something else as well, please let me know, cause sure it should be solved :)

Extension properties does not exist 🥲
Would be possible to add the extension in the Info like a Json text, extension_face_colors...
A place for the extension using dictionary<string, object> probably is better. So each extension could have an 'oficial' name with a custom schema. And could be ignored pretty easy.
Now I need to convince you to add the colors propriety in the mesh, with no color, one color, one color for each face and one color for each corner in the face. 😁

Ok, so after thinking for a while - I will check how <string,  object> idea would work in a different places, and will be back with some answers, it will probably take a while. I plan also to reconsider adding face_colors to main schema, so will let you know as well.
For now I really recommend using this library as a submodule if you want to get face_colors and still use this library (rather than doing it by Nuget).  It's not perfect solution, but it should work for now.
Let's be in touch :)

Yep, I gonna create my own version and make some tests, gonna be easy to change the import and export locally in the Online3DViewer and make some tests.
https://github.com/kovacsv/Online3DViewer/blob/master/source/engine/import/importerbim.js

Ping me when you agree on the file format modification. I'm happy to implement it in Online3DViewer, and even more happier to see a pull request. 🙂

@kovacsv I was trying some implementation in the Online3DViewer and was not able to make work to add color in a vertex mode, like each corner in a triangle with one color. Looks like only supports RGB and not RGBA. This means gonna be a pain to support vertex color, I made work to support one color for the whole mesh or by triangle faces.
Another thing I discovered by testing is all the proprieties in the scheme are obligatory and if someone is missing makes the 3DViewer break. Now I kinda understand the reason the face_colors is in the element level and the color has a default value.
The dotbim.three.js works now with both implementation face_colors in element and colors in mesh.

Vertex colors are completely different. It's supported by Online3DViewer, but not by most of the BIM applications. Anyway, if you agree on the format, I'll implement it in the viewer.

If vertex colors are not supported by most of BIM apps then screw that :)

Just faces then! 😁
The file is not optimized, I have duplicated meshes in different rotations, and have the colors in the mesh and the face_colors to make work in the 3DViewer, the file is enormous I'm glad that .zip format works.
https://3dviewer.net/#model=https://github.com/ricaun/dotbim.three.js/blob/develop/models/rac_advanced_sample_project.zip

@ricaun wow, it looks great!
Ok, I think I finally grown up to the idea of merging face_colors into main schema and call it "1.1.0". Especially knowing that it's last puzzle needed most likely :) Question is if we should do it as it is defined in the extension (face_colors inside elements, so there will be nothing to change by Viktor) or we place it inside mesh instead. I don't want to make it possible to place it in both places, it makes sense, but I prefer having one way possible :)

I like the idea to add in the mesh level, so if someone have 10 at the same windows, I only need one mesh and 10 element each one with a different position and rotation, and the information about the colors is apply in the mesh.
The only problem I see is the color in the Element is kinda opcional, and the colors in the mesh optional too.
I changed the struct color to class so by default is null, the 3dviewer is not prepared for null values but could be great to make optional as well.
Maybe all the struct could be class and when serializing just make ignore what is null, the output file would be smaller but all the reader/viewer will need to handle that.

Placing face_colors inside mesh (instead of placing it inside element) seems ok, it won't allow workflow that Viktor described (coloring one chair in a various ways without duplicating meshes), but I think it's still acceptable.
You're right with optional tags, I have with these problems as well. Generally:

I think I will keep color inside element as obligatory <- this will make sure, that it's backward compatible, and all the old files and old connectors will be working, and colored just by the color inside elements, just as it was.
But regarding face_colors if they should be optional or obligatory - I don't know right now. Making it optional will be okay only if I will make sure that optional tags can be handled anywhere properly (not only for C# and viewers, but also Python and TS libraries and all other connectors).

Right now (in 1.0.0) all tags are obligatory (even if e.g. Vector is 0,0,0) and that simplifies a lot of things, cause without it there would be multiple checks required in every connector and viewer. So I think making face_colors obligatory would also simplify the whole process.
The only downside is having 2 different coloring methods at the same time.

for viewers I think coloring it with face_colors, but if not applied -> with element's color (just as Viktor done it :)) seems correct
for Grasshopper I think I can do some sort of a button that can switch between these both methods depending what user will pick
for Blender I have to ask @Gorgious56 ;) I remember we talked about it, but I can't remember the conclusion different than we should be able to make it :)
and also I will have to find out in other projects as well.

We will have to update all the documentation drawings, but hopefuly maybe @rojus will help me with that ;)

I pushed a new branch here for that: https://github.com/paireks/dotbim/tree/schema_development/1_1_0 and will do same thing for e.g. Python library to check on these branches how well this works.

The only problem with having color in the element and face_colors or colors in the mesh will be what the viewer could use.
How the viewer/application gonna know what color to use?
Imagine I have 2 elements pointing to one mesh with face_colors and that makes the color in the element level kinda useless, or maybe I want to show one mesh with red and blue, but the mesh has colors.
That's why I think color/colors should be optional, but I really don't know, or maybe the color 0,0,0,0 should be used to ignore. In C# the color is defined as a struct and the default is 0,0,0,0 so maybe the viewer could ignore the color and use the colors in the mesh level.

It can just work based the use the most specific rule (like in inheritance in programming).
So something like this:

If there are face_colors defined on element level, use them. Otherwise:
If there is a color defined on element level, use that. Otherwise:
If there are face_colors defined on mesh level, use them. Otherwise:
Use the color on mesh level which is a mandatory member.

It would provide full flexibility and keeps it compatible with older versions. On the other hand it makes the import implementation a bit more complex. If we would like to optimize for simplicity, I would put every color information on mesh level (even though it's a breaking change, and doesn't allow to reuse the same geometry with different colors).

One thing that is really important to me is backward compatibility, so naturally breaking changes are something I would avoid.
Side note regarding color in elements: I already use it a lot, I have some 3d symbols that I store once and then color it differently, place different metadata for each one, and it works great.
Maybe let's just make it as it is already in the Online 3d Viewer then, and treat is with these two points only:

If there are face_colors defined on element level, use them. Otherwise:
Use color defined on element level.

This extension face_colors is a branch of the default schema and I agree with backward compatibility, but.
Gonna be a nightmare to provide backward compatible for all the extension, I suppose only exist this one but imagine 10 extension how manage that... The extension propriety kinda makes sense.
In my opinion only add a colors in the mesh level and should work something like:

if there are color define on the element level, use them. otherwise:
Use colors defined on the mesh level.

The color in the Element level gonna work like a overwrite.
This way is not gonna be backward compatible with this extension and gonna work fine with the main schema.

We have added face_colors to elements, updated documentation and updated version to 1.1.0 here: https://github.com/paireks/dotbim/tree/schema_development/1_1_0
Will merge with master soon.

We have added face_colors to elements, updated documentation and updated version to 1.1.0 here: https://github.com/paireks/dotbim/tree/schema_development/1_1_0
Will merge with master soon.

I am kinda disappointed that you decide to add the face_colors in the element instead of the mesh.

I see, at least the functionality that was missing is there :) The fact that you convinced me to update something in schema is already huge thing, as this project is more about reduction than addition, so I try to keep it as minimalist as I can. Regularly someone asks if I can add this, and this and that, and regularly I have to say no, because this project won't be original anymore if I will try to satisfy everybody, and naturally it will become another complex standard like other that already exist. I'm sorry it's not 100% the way you wanted it to be, I hope you will still find it useful :)


port curved version to 2.x

at first glance, there should be no real blockers to integrate this into 2.x

implemented by ac54d1897ce953e205b30445448d228260833191


android: styles.xml change for dark theme, on the path to RN v0.64 upgrade.

We need to test on Android 10 and record any changes; the linked doc says the dark theme is available in Android 10 (API level 29) and higher. I've tested on the office Android device, a Samsung Galaxy S9, but it's running Android 9 and I'm not sure it's time to upgrade it yet (I'm not sure if we can go back to Android 9 after doing so).
I found no visible changes in the app on Android 9 when switching the system-level dark theme setting on and off. I'm not sure how I was able to switch that setting on and off when the doc says that the Dark theme is available starting in Android 10. Anyway, best to test on Android 10.
@AkashDhiman, would you be interested in testing on a device running Android 10?
Related: #4426
Related: #4009

Sure, I will have a look.

checked by using ../zulip/tools/reset-to-pull-request 4846 and then launching the app, the usual way.
The following observation is made on Android 10 and 11:

white screen that comes up on starting the app changes to darker color when system UI is set to dark mode, this does not happen in the current master build.

There are no visual changes within the app.
For reference here are some screen captures on an Android 10 emulator:
when the system UI is set to light mode

when the system UI is set to dark mode

Thanks for testing it out, @AkashDhiman, and thanks for the review, @WesleyAC! Merged.

Thanks all!

I'm not sure how I was able to switch that setting on and off when the doc says that the Dark theme is available starting in Android 10.

FWIW my guess for this is that Samsung added a version of this feature for their own devices before it was in Android itself.
I'd expect their version to apply to their own apps, and possibly some third-party apps that explicitly use some Samsung-specific API to get the theme. It probably doesn't succeed in setting the theme in a way that apps relying on the Android 10 API will notice, because they probably designed it before that API existed. If you didn't see an effect like the one Akash showed above, then that fits with that expectation.


Data - buttons that take the user to the swap app should open it in a new tab

This should be the behavior regardless of the fact it's the same app technically.

i do not see this "new tab" behavior on staging.
@pingustar

works fine on my end @ashachaf
are you still able to reproduce this?

@ashachaf This is what I see on my end - https://streamable.com/4xbdsf What's the experience for you?

I think he means a new tab for the Add Liquidity and Trade buttons in the table action column on the data page.
I have added it.


[5.9][Serialization] Pass up deserialization errors under generic type params

There is no related test as we don't have reproducer code and we've seen it only in the debugger, but I believe the fix is sound on its own.
rdar://106430304
Cherry-pick of https://github.com/apple/swift/pull/64618.

@swift-ci Please smoke test

@swift-ci Please test


Janaina ramos

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: janainaimpacta sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Bitbucket Cloud Discovery Getting Rate Limited

Expected Behavior
For integrations with Bitbucket Cloud, API rate limits should not be hit when discovery is configured.
Current Behavior
Bitbucket Cloud REST API rate limits are hit, which prevents further scanning/onboarding of repos
Possible Solution
Some ideas, although not sure how feasible they are:

Configurable polling frequency through the app-config.yaml
Once rate limits are hit, future scans should pick up from where the previous scan left off, instead of scanning all over again

Steps to Reproduce

Configure Bitbucket cloud discovery according to this doc
Wait till scanning/polling happens

Context
Recently, in 6216, support for auto-discovery of entities from Bitbucket Cloud repositories was rolled out. However, the scanning for repos happen too frequently and this leads to the Bitbucket Cloud REST APIs returning HTTP Code 429, as the rate limits of BB Cloud is being hit. Rate limits also get hit when scanning a wide sample space, say a Bitbucket workspace which contains 1000+ repos. Note: This is an issue originally mentioned by @FilipSwiatczak in the plugin request thread
Btibucket Cloud API limits: https://support.atlassian.com/bitbucket-cloud/docs/api-request-limits/
Your Environment

NodeJS Version: 14.4.0
Operating System and Version (e.g. Ubuntu 14.04): MacOS 11.6
Browser Information: Chrome v94

hi @aravindparappil46 I am currently successfully working around rate limits by specifying:
  const { processingEngine, router } = await builder.setRefreshIntervalSeconds(600).build();

in
packages/backend/src/plugins/catalog.ts
600 sec/10 min makes for 6 queries per hour and BB Cloud rate limit for repositories is 1000/h so 1000/6=166 would be your max number of separately called entities. Let me know if that works :)


Improve round generation

Seems to be somewhat fixed by https://github.com/waleko/wiki-race/commit/765be01934b04c2fa2d7d3b7f40c72135c70c838


Support JS embedded in HTML

With the advent of web components, it would be nice to have the jshint run on html files in atom, not just .js files.
:)

Sure, happy to receive a pull request for that, but I don't need it, so won't come from me.

Actually I also need this feature very much.

@109km Looking forward to the pull request ;)

Closing as this project is deprecated. 🌵


Updated frequency capping constraints schema to support repeat and custom events

https://jira.corp.adobe.com/browse/CJM-29979

Updated frequency capping constraints schema to support repeat & custom events
Deprecated unused attributes from frequency capping constraints schema

data type change for xdm:repeat is intentional .. the feature for frequency capping repeat is not live and we wanted to change the data type for xdm:repeat from boolean to object.
What are the schemas that are affected by the issue

personalized-content-offer.schema.json
frequency-capping-constraints.schema.json

What are examples of products that are impacted by the issue

No impact on the existing products. Frequency capping constraints define additional rules based on prior offer proposition, either across all audiences or for a particular profile identity.

@jshaik-adobe , would you please  update your master branch and then re submit the PR ? It has some missing objects from the current master. Please refer the build failure. Thanks !

@mjasrotia updated master branch, current build failure is related to data type change for xdm:repeat which is intentional.

@jshaik-adobe , I am approving this PR on your confirmation that the changed property has no data ingested and you understand the risks of changing the type of this property if there was any data ingested against it.


[Event Request] codeunit 17 "Gen. Jnl.-Post Reverse" - OnReverseGLEntryOnAfterReverseVAT

Hello, can you please add a new Event OnReverseGLEntryOnAfterReverseVAT in codeunit 17 "Gen. Jnl.-Post Reverse" ?
                    ReverseVAT(GLEntry, GenJnlLine."Source Code");
                    OnReverseGLEntryOnAfterReverseVAT(GLEntry2, GLEntry, GenJnlPostLine);
                until Next(-1) = 0;

        OnAfterReverseGLEntry(GLEntry);
    end;

    local procedure ReverseCustLedgEntry(CustLedgEntry: Record "Cust. Ledger Entry"; NewEntryNo: Integer; Correction: Boolean; SourceCode: Code[10]; var NextDtldCustLedgEntryEntryNo: Integer)

    [IntegrationEvent(false, false)]
    local procedure OnReverseGLEntryOnAfterReverseVAT(GLEntry2: Record "G/L Entry"; GLEntry: Record "G/L Entry"; var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10907.


Blueprints can match owners based on fields in their spec.

Description of problem
As a blueprint author, I would like to be able to match my owner based on fields in the spec.
Proposed solution
Implement matchFields and matchLabels as per this RFC
Example
apiVersion: carto.run/v1alpha2                                  # <======== bump this
kind: ClusterSupplyChain
metadata:
  name: supply-chain
spec:
  selector:
    matchLabels:                                                # <=========== move existing labels here
      app.tanzu.vmware.com/workload-type: web
    matchFields:                                                # <=========== add this
      - { key: "spec.image", operation: exists }                # <===========

Additional Context
This introduces v1alpha2 to avoid a breaking change and will require a bump to the apiVersion for both ClusterSupplyChain and ClusterDelivery, and requires the introduction of a conversion webhook.
Open questions:

does v1 need to support matchfields at all? because we couldnt downgrade to it unless we implemented it there as well, making the selector field go from map[string]string to map[string]{}interface

Left to do:

documentation
possible refactoring (comments inline in code)


reacjis in outbox

this is still WIP on the GUI integration from @buoyad  but @mmaxim can you take a look at the core side?

@keybase/react-hackers this is ready for a look! it changes the reaction update API
Previously on clicking the button we send postReactionNonblock and listen for incoming messages & deletes to update the state of the buttons. We stored the reaction msg ID to look up deletes later.
Now on clicking the button we send postReactionNonblock and add the reaction to the store immediately. We ignore incoming messages and deletes and listen for a new notification, ReactionUpdate to give us the new reaction map for the message. On getting the notification we blow away our version of the reaction map and replace it with the service's. We don't store the reaction msg ID because we don't manually delete individual reactions anymore.

Merge?


No error logging when mirror is "faulty"

What version of OpenRewrite are you using?

OpenRewrite -- latest HEAD

How are you running OpenRewrite?
Just running as a test.
I enabled "reading maven settings" like this:
    public static boolean readFromDiskEnabled() {
        return true;
    }

And create a copy of a test like this:
    @Test
    void changeParent2() {
        rewriteRun(
          spec -> spec.recipe(new ChangeParentPom(
            "com.example.adm.ws4",
            "com.example.adm.ws5",
            "adm-web-site-4-pom",
            "adm-web-site-5-pom",
            "1.0.6",
            null,
            null,
            null,
            true
          )),
          pomXml(
            """
              <project>
                <modelVersion>4.0.0</modelVersion>

                <parent>
                    <groupId>com.example.adm.ws4</groupId>
                    <artifactId>adm-web-site-4-pom</artifactId>
                    <version>2.1.10</version>
                </parent>

                <groupId>com.mycompany.app</groupId>
                <artifactId>my-app</artifactId>
                <version>1</version>
              </project>
              """,
            """
              <project>
                <modelVersion>4.0.0</modelVersion>

                <parent>
                    <groupId>com.example.adm.ws5</groupId>
                    <artifactId>adm-web-site-5-pom</artifactId>
                    <version>1.0.6</version>
                </parent>

                <groupId>com.mycompany.app</groupId>
                <artifactId>my-app</artifactId>
                <version>1</version>
              </project>
              """
          )
        );
    }

Now inside my settings.xml file I have this:
<settings>
	<servers>
		<server>
	    	<id>Maven_Public</id>
	    	<username>user</username>
	    	<password>pass</password>
	    </server>
	</servers>

	<mirrors>
		<mirror>
			<id>Maven_Public</id>
			<mirrorOf>*</mirrorOf>
			<url>https://nexus.local:1234/repository/Maven_Public/</url>
		</mirror>
	</mirrors>
</settings>

Which should pick up any downloaded artifacts (pom, jar, ...) and fit it through our internal Nexus server.
However, I noticed that during resolution of downloadMetadata it is passed getResolutionResult().getPom().getRepositories(). Which is further elaborated on in MavenPomDownloader::distinctNormalizedRepositories.
But nowhere in this chain are the mirrors taken into account it seems.
What is the smallest, simplest way to reproduce the problem?
See above for the snippet. You need a mirror-of and an internal nexus server set up. Plus maybe a block on the official maven "repo.maven.apache.org" hostname.
What did you expect to see?
That the test works :)
What did you see instead?
+  <!--~~(com.example.adm.ws5:adm-web-site-5-pom failed. Unable to download metadata.)~~>--><parent>

Are you interested in contributing a fix to OpenRewrite?
Looking how to most easily fix this, but I could use some guidance.
References:

Discussion #4784
Issue #130

@timtebeek : I finally figured this one out. And it was an issue at my side.
Because the Nexus server is internal, it has an internal certificate. The root certificate wasn't added into the cacerts, and during the check here it is not reporting anything.
So the error is silently ignored, leaving the end-user clueless what needs to change.
If I would have gotten the error (it was: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target), I would immediately know that I had an update of my JDK, and I needed to re-apply the certificates.
Now, I had to step through the code and look at the debugger to realize what was going on ;).
So my suggestion for this would be (but I don't know how, and I guess it'd be relatively small for you/your team): Add some logging to the default method in ResolutionEventListener.java.

Step 0: check out latest version from rewrite & gradlew publishToMavenLocal
Step 1: I removed the internal certificates from cacerts in my jdk
Step 2: mvn rewrite:dryRun
No clue what I did now... But it's working as you described:
[WARNING] Failed to access maven repository https://nexus.internal:1234/repository/Maven_Public/ due to: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

Maybe something in the latest version (trunk) changed something for the better compared to the one that is online?
I don't know, but I can't reproduce it anymore. So closing this ticket.
Thanks for the continued support @timtebeek !

All good; those lines were last changed quite some time ago it seems; but happy to see it's working as expected.

https://github.com/openrewrite/rewrite-maven-plugin/pull/811

Hope that clears any last hurdles you had in getting started!


Import common classes from stdcheck to Flexible Mink.

Description:
In order to avoid duplication of code and keep consistency in how we test our projects, we need to move all common case Behat steps from stdcheck to Flexible Mink (both 1.0 and 2.0).
Example of Behat case:
public function assertElementAttributeValue(NodeElement $element, $attribute, $value)
    {
        $actualValue = $this->assertElementHasAttribute($element, $attribute);
        if ($value != $actualValue) {
            throw new ExpectationException(
                $attribute . ' attribute has value of: ' . $actualValue . ' expected: ' . $value,
                $this->getSession()
            );
        }
    }

Acceptance Criteria:

[ ] Code is removed from the stdcheck repo and moved to Flexible Mink branches
[ ] stdcheck is updated to use the latest version of Flexible Mink
[ ] Issues are created to update the other projects to the latest version of Flexible Mink

Bye FlexibleMink


Finalization issue, telling when an object has been GC'd

I have objects with native class instances bound and need to know when the object has been garbage collected and will no longer be referenced in script.
The initial approach has been to use a finalizer.  However, this is problematic as the objects are being rescued outside of the finalizer.  I understand that this can happen, as the guide says "this may happen in special cases even when the object is not rescued by the finalizer".  I am not sure what this means.
I am wondering if there is any reliable way to tell if an object has been GC'd.  (I am using heapptr native side to track the script objects)
Thanks!

The quote relates to multiple execution of a finalizer:

A finalizer may be called multiple times (this may happen in special cases even when the object is not rescued by the finalizer).

There are some special cases where a finalizer may run twice even when the object was not rescued. This used to happen when an object had been finalized by mark-and-sweep (but not yet wiped) and duk_destroy_heap() was called, which then ensured all objects are finalized and ended up calling the finalizer for a second time (IIRC this has been fixed but there may be similar cases).
The fix right now is to make the finalizer capable of detecting it's being executed for the second time (e.g. write a NULL over a native resource pointer or such).
The finalizer is currently the only signal of an object being GC'd - with the catch the Duktape may tell that you twice :)
Fixing the finalizer guarantees to be exact would be nice, I'll add it to the 1.2 release.

The quote relates to multiple execution of a finalizer:

A finalizer may be called multiple times (this may happen in special cases even when the object is not rescued by the finalizer).

There are some special cases where a finalizer may run twice even when the object was not rescued. This used to happen when an object had been finalized by mark-and-sweep (but not yet wiped) and duk_destroy_heap() was called, which then ensured all objects are finalized and ended up calling the finalizer for a second time (IIRC this has been fixed but there may be similar cases).
The fix right now is to make the finalizer capable of detecting it's being executed for the second time (e.g. write a NULL over a native resource pointer or such).
The finalizer is currently the only signal of an object being GC'd - with the catch the Duktape may tell that you twice :)
Fixing the finalizer guarantees to be exact would be nice, I'll add it to the 1.2 release.

Hi Sami,
The problem isn't that the finalizer may be called twice, which is pretty easy to catch.  It is that the finalizer is being called while the object is still valid and in use.  So, the native object is gone when it actually shouldn't have been deleted.
I have been catching the 2nd run of the finalizer (which does still happen).  The problem is that the finalizer is run, somehow the object is rescued or shouldn't have had the finalizer called and is still available in script. The object gets accessed after the first finalizer call.
I know it is the same object because I flagged some properties on it to check and the heapptr matches what was in the first finalizer call.
If I call duk_gc per frame, I cannot seem to trip the issue however this isn't really an option.  If I change the gc to every 5 seconds the problem happens frequently.
My only guess is that the mark/sweep may finalize objects in a closure, but they become reachable on the next pass.. this is just a wild guess though :)

I should probably also note that the finalizer is a c_function and does not rescue the object

What happens if you run your finalizer as normal, but simply leak the native resource? Do you get a resource leak but no crash?
When you say "the object gets accessed", who accesses it?

Running the finalizer is pretty straightforward in mark-and-sweep, and freeing an object takes two mark-and-sweep passes (when the object has a finalizer, that is):

Mark-and-sweep pass N marks the object finalizable, and once mark-and-sweep is otherwise finished, finalizers are executed.  The object is still in Duktape heap at this point, but no-one should have a reference to it.

Assuming the finalizer didn't rescue the object, at this point the object is not reachable through ordinary means. Any C code can still resurrect the object if it uses duk_push_heapptr() to create a reference to it.

Mark-and-sweep pass N+1 detects that the object was finalizable, and if it's still unreachable, the object is freed. If the object is reachable, it's considered rescued.

A finalizer may also be executed (and probably most often is) by the refcount code, without involving mark-and-sweep at all:

If object refcount becomes zero, the finalizer is executed. For the duration of the finalizer call the refcount is bumped by one to avoid queueing the object again for refcount finalization.

If the refcount after removing the artificial bump is zero after the finalizer call, the object is freed.

Unlike mark-and-sweep there should be no delay in this case.

Can you confirm whether your finalizer seems to triggered by refcount (i.e. the object doesn't participate in a reference loop) or mark-and-sweep?

Ok, fantastic, thanks for all the great details!
The best lead I have now is that somehow: duk_push_heapptr() is being called between finalization and the next pass, so the object is being rescued.
I can look into whether this is being triggered by refcount or mark-and-sweep.  I'll probably have to detect this case and set a breakpoint on it.
If I leak objects, other than failing the verification checks in our system, there aren't any dangling pointers being accessed by duktape.
Thanks again

It's odd that calling duk_gc() fixed the issue for you - the second mark-and-sweep should just free the object but since your code should not "see" that free, it would still be doing a duk_push_heapptr() (assuming that is the cause here). Doing that push after the second mark-and-sweep should be unsafe and should most likely cause a crash.
Similarly if the finalizer is executed by refcount code, there should be no time for rescuing (unless the finalizer itself rescues the object) and any duk_push_heapptr() for the object afterwards should be unstable.
Let me know if you can pinpoint the problem a bit more :)

Yes, I let the game run for 30 minutes without issue when calling duk_gc per frame.  I can trip the issue within 15 seconds otherwise.  I was thinking the aggressive gc'ing was just keeping things from being rescued so the finalizer was really final :)
I also don't think it is the heapptr push rescuing the object, as this is only done with a valid heapptr, which is cleared on the first finalizer call
We're crunching for GDC, so I may stick with the aggressive GC for now and come back to figuring out why this seems to either fix or greatly reduce the issue.

One piece of the puzzle I'm missing is what call triggers the issue ("the object gets accessed")?

Ok, so I just verified that a script object is being finalized, though accessed, by script later.  In the finalizer, I set index 0 of the object to true.  I print index 0 of the object before the call that blows up (which is always the same, not erratic).
"undefined, undefined, undefined, true", the last one is where it has been finalized though should not have been... and if I gc every frame I have not yet seen this behavior.

A possible cause is that the refcount is off by one so that Duktape ends up refcount finalizing the object while it's still reachable. But that should be unstable too, because the object would be freed and removed from the Duktape heap's "heap_allocated" list. Mark-and-sweep would no longer see the object so no-one would be finalizing it for the second time so this doesn't match the symptoms.
Just as a way of pinning down the problem, what happens if you use DUK_OPT_NO_REFERENCE_COUNTING?

On 1.1 (latest download release), with DUK_OPT_NO_REFERENCE_COUNTING set:
[Mon Jan 19 08:15:21 2015] INFO: undefined
[Mon Jan 19 08:15:21 2015] INFO: undefined
[Mon Jan 19 08:15:21 2015] INFO: true
Still having finalize called though accessed (in script) after that finalize call

Ok, so this kind of seems like a smoking gun, self has not been finalized however a memory of an array it holds has been finalized:
    var sprite = self.sprites[frame];
    // index 0 is set to true once finalized, otherwise undefined
    print(self[0], ":", sprite[0]);

[Mon Jan 19 08:46:28 2015] INFO: undefined:undefined
[Mon Jan 19 08:46:28 2015] INFO: undefined:undefined
[Mon Jan 19 08:46:28 2015] INFO: undefined:true

Hunches on how this could be reproduced in a stripped down test case?

I filed an Atomic issue to check whether DUK_OPT_NO_VOLUNTARY_GC is still required to avoid the gc issues described here, whether we end up using it to control GC timing or not...
https://github.com/AtomicGameEngine/AtomicGameEngine/issues/151
I should note that with it disabled these months, objects have been being GC'd properly, with a fair amount of stress on the system.  I do think that https://github.com/svaarala/duktape/issues/109 would be great

I've been stress testing with the voluntary gc enabled and haven't been able to trip this :+1:
I think we'll stick with the default of having the voluntary, unless getting some GC pauses... so far, silky smooth!
If you're looking to close out some issues, I think this is now a candidate.

Unfortunately, I had to disable voluntary GC as I am tripping the issue after some more testing.  Disabling the voluntary GC also seems to smooth out the framerate a bit, so that is desirable.  I will work to get a good minimal repro case when possible

I'll be happy to help with the reproduction if there are any clues what I should be looking for :-)

Weird, I've never had a double finalization issue yet, and I would definitely know since it would lead directly to a segfault (double free). :wink:

I'll be happy to help with the reproduction if there are any clues what I should be looking for :-)

@fatcerberus Note that this is not a basic double finalization issue (and there are those cases still left); here an object finalizer is called when the object is still in use.

Oh.  Ouch!

It is ok, significantly smoother without the voluntary GC, though I do want to figure this out :)
I would also like to figure out exactly how to: make dist-src
using settings https://github.com/svaarala/duktape/blob/master/config/examples/timing_sensitive.yaml
Crunching and I am sure how to do this is right in front of my face, somewhere :)

If I had to guess at the cause of this, I would say there's a refcounting error somewhere, e.g. a corresponding DECREF coming before an INCREF (instead of after) which causes the object to be finalized and then immediately rescued.

So, when you started developing Duktape, did you think it would be used to control the AI of virtual chickens?
Because it has now been used for this purpose:

Oh, it is also used to make them cluck :)

Josh

the AI of virtual chickens

AI... artificial intelligence... chickens...
But wait, I thought chickens were stupid? :wink:

That's an awesome application :)

@JoshEngebretson The config YAML files are part of the duk_config.h rework (#64) which is still a work-in-progress in 1.3. But what you can do and would do later on is generate a new duk_config.h using genconfig.py, with specific config options overridden based on option YAML files and/or command line options.
For example:
# Options can be defined in YAML files and/or command line entries, applied in order
$ python --metadata config --output duk_config.h \
    --option-file config/examples/timing_sensitive.yaml \
    --option-file my_further_options.yaml \
    -DDUK_USE_FASTINT \
    autodetect-header

There's a more verbose explanation here: https://github.com/svaarala/duktape/blob/master/doc/duk-config.rst

Ok, thanks!  I will give this a shot in a little bit

There isn't all that much in the timing sensitive options, you probably already have the DUK_OPT_xxx variants in your compilation already (DUK_OPT_xxx variants will be removed later on, after 1.3 release, in favor of working with duk_config.h and DUK_USE_xxx config options directly, removing one layer of indirection).
But there are a lot more options in performance_sensitive.yaml, so you could e.g. apply performance_sensitive.yaml first, and then timing_sensitive.yaml on top of that. After that you can do additional tweaks. It's not a perfect process but that way you'd automatically inherit new performance related options.

@JoshEngebretson With the fix for #287 in master, now might be a good time to check if you can still reproduce this problem. There are a few torture case failures for finalizers and longjmp handling left (tracked in #314) but they seem quite difficult (if not impossible) to trigger from user code. I'll probably deal with them after the base 1.3.0 release and incorporate the fixes into 1.3.1 if there's something that's actually possible to trigger.

We're currently crunching here, though this is on my list of things to do.  We're going to leave the voluntary gc off as it really does smooth out frames, though it would be good to know if the behavior persists with #287 in
Until then, Chickens on Android!

No worries Josh, I know that feeling :) Probably voluntary GC off is the right choice for Atomic anyway, I'm just curious if we found the underlying cause or not - but this can wait :)

There hasn't been activity or a way to reproduce this for a while now so I'm closing this. This can be reopened if there's some way to reproduce or otherwise narrow down the problem.


Include QR code extension

The Quarto QR Code extension is quite useful in slides but it needs installing in the GitHub action.
This PR adds such a section and also serves as a template if other extensions are required by users.

Looks good to me, will merge!


[#132565531] Update bosh-init to v0.0.100

What
Story: Upgrade to BOSH >= 261.3
Due to a bug in bosh-init and more recent versions of stemcell we have to update to the version 0.0.100+.
How to review

Build and test locally
Test with temp commit on the relevant paas-bootstrap PR
The bootstrap pipeline should be able to build BOSH

After merging

Finalise TEMP commit in paas-bootstrap PR and replace the branch reference with the merge commit SHA

Who can review
Not @combor or me

That wan't WIP any more.


fix: append structured logs when injecting lambda context

Issue #, if available: #85
Description of changes:
Bugfix for #85

Checklist

[x] Meet tenets criteria
[x] Update tests
[x] Update docs
[x] PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #86 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           17        17
  Lines          474       474
  Branches        42        42
=========================================
  Hits           474       474

Impacted Files
Coverage Δ

aws_lambda_powertools/logging/logger.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a63141...0d2ab65. Read the comment docs.


Make config cwd agnostic

@asinghal
This is causing issues in prod.
Note that naught supports passing the cwd which probably fixes this but I don't want to rely on naught's options. I think an app should work the same way regardless on which CWD is being used to start it.

Makes sense! Thanks for fixing

:cry:
it breaks mocha...
reverted: https://github.com/costacruise/node-app/commit/b9ab9b05ab64bb428fccbfa0cea753b3f4567f79
I can't think of a generic way to make it work nicely as is, ie. with a statically defined conf (nconf like).
I'll update cloudformation to to pass --cwd to naught.


Fix --user argument

The flag wasn't actually taking effect:
docker run --rm -v $PWD:/host -w /host --user : --entrypoint sh node:20-alpine -c "/usr/local/bin/yarn && /usr/local/bin/yarn build"

https://gitlab.com/finestructure/swiftpackageindex/-/jobs/5761071117
It just happened to succeed because no new files were generated.
I've reset the permissions in all directories on the builders so hopefully this won't fail again.

With this change:
docker run --rm -v $PWD:/host -w /host --user $(id -u):$(id -g) --entrypoint sh node:20-alpine -c "/usr/local/bin/yarn && /usr/local/bin/yarn build"
yarn install v1.22.19
warning Skipping preferred cache folder "/.cache/yarn" because it is not writable.
warning Selected the next writable cache folder in the list, will be "/tmp/.yarn-cache-999".
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
warning Cannot find a suitable global folder. Tried these: "/usr/local, /.yarn"
Done in 12.05s.
yarn run v1.22.19
warning Skipping preferred cache folder "/.cache/yarn" because it is not writable.
warning Selected the next writable cache folder in the list, will be "/tmp/.yarn-cache-999".
$ ./FrontEnd/esbuild.mjs
warning Cannot find a suitable global folder. Tried these: "/usr/local, /.yarn"
Done in 1.11s.


[IOTDB-140]Fixed the bug in calculating chunk datasize and write the size for string variable.

Now it can support string with non-ascii characters.

I will merge it.
How about also merge into rel/0.8?


Victor cluster and hub

I've already deployed this and the hubs https://victor.2i2c.cloud and https://staging.victor.2i2c.cloud are up and running


refactor(client): adjust limit of getting items for listing diff to 128

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.71%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5560

Relevant Lines:
6642

💛  - Coveralls


Filter list-of-links links to audiences

Reminiscent of the retired-from-service "Dynamic Menu Portlet":
Add optional .audience field to links in list-of-links widgets, with value array of Strings representing group names. Filter away links that specify an audience none of the groups of which include the viewing user.
Punchline: whereas content like
{
               "launchText":"Open website",
               "links":[
                  {
                     "title":"Employee wellness",
                     "href":"https://uwell.wisc.edu/employee/",
                     "icon":"loyalty",
                     "target":"_blank"
                  },
                  {
                     "title":"Student wellness",
                     "href":"https://uwell.wisc.edu/student/",
                     "icon":"group",
                     "target":"_blank"
                  }
               ]
            }

currently usually shows a typical user two links only one of which is relevant, evolved content like
{
               "launchText":"Open website",
               "links":[
                  {
                     "title":"Employee wellness",
                     "href":"https://uwell.wisc.edu/employee/",
                     "icon":"loyalty",
                     "target":"_blank",
                     "audience": ["employees"]
                  },
                  {
                     "title":"Student wellness",
                     "href":"https://uwell.wisc.edu/student/",
                     "icon":"group",
                     "target":"_blank",
                      "audience": ["students"]
                  }
               ]
            }

would show only the relevant links to the user.

From discussions: a better way to do this is a better microservice vending the list-of-links JSON, avoiding more complexity client-side.


Basic Orchard features testing should include Workflows and Audit Trail (OSOE-847)

Extend BasicOrchardFeaturesTestingUITestContextExtensions so it also tests Workflows and Audit Trail.

Do this similarly to how Media features are tested: a separate extension method just for Workflows, and one for Audit Trail (like TestMediaOperationsAsync()). Don't put all the code into the same class though.
No need to use page classes, just write the test also similar to TestMediaOperationsAsync().
For Workflows, test the following: Add workflow, add Event and Task, test that workflow runs. You can e.g. display a notification on login or a content item publish.
For Audit Trail, configure it to record events for a content type, test that content publishing for that type is correctly recorded.

Jira issue

Extend BasicOrchardFeaturesTestingUITestContextExtensions

Don't put all the code into the same class though

Do you mean to put these new methods in a new ...Extensions file?

It's up to you how to structure the code, just let's not make that class perpetually longer.

What do you think, should we also test the creation itself of the workflow, so clicking trough each step, creating the event and the task, or creating it from a recipe is enough? Then testing the workflow of course.
Because I think clicking it together could be problematic during the part where you have to connect the event with the task:

We need to test that the workflow editor also works, yes, that's why I mentioned adding an Event and a Task. Drag and drop is possible in Selenium, so that step should not be an issue either. See e.g. https://www.browserstack.com/guide/drag-and-drop-in-selenium for inspiration (this is Java, but the API is the same).


⚠ Bofrost.at has degraded performance

In ed015fe, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2170 ms

Resolved: Bofrost.at performance has improved in 6f5fd2d after 6 minutes.


jsonpb allows unmarshaling invalid date

What version of protobuf and what language are you using?
protobuf v1.4.0
go 1.15.1
What did you do?
Unmarshal a json request containing an invalide date into a proto.Message struct
example:
dest := &Message{} // Which has a UpdatedAt *timestamp.Timestamp attr
err := jsonpb.Unmarshal(strings.NewReader(`{"updated_at":"0000-12-31T23:45:00Z"}`), dest)
assert.Error(t, err)

What did you expect to see?
A successful test, an error should be returned as the date is invalid according to validateTimestamp method.
What did you see instead?
The test fails, there is no error returned.

The google.golang.org/protobuf/encoding/protojson package should handle this correctly.

Thanks! I’ll have a look at it!

The following snippet on the google.golang.org/protobuf module:
ts := new(timestamppb.Timestamp)
err := protojson.Unmarshal([]byte(`"0000-12-31T23:45:00Z"`), ts)
fmt.Println(ts, err)

correctly fails with:
proto: (line 1:1): google.protobuf.Timestamp value out of range: "0000-12-31T23:45:00Z"

The github.com/golang/protobuf module is frozen for any changes except for regression fixes. This issue is not seem to be a regression. Closing this as "wont fix".


Can't process MS2 data from timsTOF .tdf file

Basic information

My operating system: Windows 10
My MZmine version: MZmine 3.4.27, MZmine 3.5

What happened
I have Bruker timsTOF Flex LC-IMS-MS data (.d -> .tdf) that I am trying to process.  I run mass detection for both MS1 and MS2 and raw data overview suggests it worked.  I used 'Frame only' and 'Centroid'.  See first figure.
However, when performing ADAP Chromatogram Builder, MS2 data are not included.  See the second figure for ADAP CB parameters I used.  When I try to export the feature table (or any downstream feature table), there are no MS2 data.  GNPS files are empty, for example.
I was, however, able to successfully create a feature table that included MS2 data processed using ADAP CB from an mzML file.  This file was converted from a .d file (no ion mobility) using MSConvert.
I'm happy to provide any more information that is relevant.
Thanks,
Peter

Hi,

I run mass detection for both MS1 and MS2 and raw data overview suggests it worked. I used 'Frame only' and 'Centroid'. See first figure.

You need to run mass detection in mobility scan dimension, too. Do you not want to get the IMS data also in MS1 dimension? Best follow the processing wizard and see what modules it uses for processing and then optimize the parameters for your dataset.

I was, however, able to successfully create a feature table that included MS2 data processed using ADAP CB from an mzML file. This file was converted from a .d file (no ion mobility) using MSConvert.

I don't exactly know what happens with the MS2 data during conversion when removing the ims dimension. I'd not recommend this, it might merge all ms2 spectra from a single tims ramp.

Yes -- that was the issue.  Appreciate the help, Steffen.


Adding Role via the UI always errors with "Name" is required, despite providing one

Setup

Rancher version: 2.6.2 / 2.6.3
Browser type & version: Firefox 95.0.2

Describe the bug
Populating the Name field when creating a new role object type results in the UI presenting an error stating it is not set
To Reproduce
Log into Rancher -> Cluster Explorer -> Search Resources -> Role -> Create
Result

Expected Result
Object to be created with supplied input.

On 2.6-head commit id: 11a7451

Deploy a cluster --> CLuster Explorer --> Roles --> Create
Give in a name, add in details. Click on create
User is able to create a role successfully.


Switch to creekservice

part of https://github.com/creek-service/creek-test/issues/24
Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage decreased (-0.6%) to 98.817% when pulling 58a90070de9d45ec055757e4d29211dc201e07c5 on creekservice into e511be221a06b1197afb905f05e63c46d1eeb01d on main.


Support 24-bit color in the new Windows console (RS2)

ref = Microsoft/BashOnWindows#345

Am 2016-11-23 08:43, schrieb Belleve Invis:

ref = Microsoft/BashOnWindows#345 [1]

A little bit more information would be appreciated. What exactly is
missing from the current support for the Windows console?
What needs to be done?
Simply quoting an issue which is about 256color support on windows
console (and not about true color support) does not help.
regards,
Christian

There is a code segment that shows the incoming 24-bit color support in Windows.
bool EnableVTMode()
{
    // Set output mode to handle virtual terminal sequences
    HANDLE hOut = GetStdHandle(STD_OUTPUT_HANDLE);
    if (hOut == INVALID_HANDLE_VALUE)
    {
        return false;
    }

    DWORD dwMode = 0;
    if (!GetConsoleMode(hOut, &dwMode))
    {
        return false;
    }

    dwMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
    if (!SetConsoleMode(hOut, dwMode))
    {
        return false;
    }
    return true;
}
int __cdecl wmain(int argc, WCHAR* argv[])
{
    argc; // unused
    argv; // unused
    //First, enable VT mode
    bool fSuccess = EnableVTMode();
    if (!fSuccess)
    {
        printf("Unable to enter VT processing mode. Quitting.\n");
        return -1;
    }
    int red = 0; // set these to whatever
    int green = 0;
    int blue = 0;
    printf("\x1b[38;2;%d;%d;%dm", red, green, blue); // produces RGB foreground
    printf("\x1b[48;2;%d;%d;%dm", red, green, blue); // produces RGB background

    int index = 0;
    printf("\x1b[38;5;%dm", index); // produces xterm color table index foreground
    printf("\x1b[48;5;%dm", index); // produces xterm color table index background
}

That sounds like it should work when setting t_8f and t_8b correctly.
There is even an example in the help, that should work with those codes.
See :h xterm-true-color
Please test that before you create an issue for it and please ask user
questions on the vim_use ml. The issue tracker is for actual issues.
Best,
Christian

The key problem is that you need to call SetConsoleMode to enable ANSI escapes.

This is definitely something I'd be interested in. I can confirm that just setting t_8f= (and the other similar variables) and or term= doesn't seem to work.
I've also got a local build and tried playing around with adding ENABLE_VIRTUAL_TERMINAL_PROCESSING in the places where SetConsoleMode happens. However, I couldn't get anything working (but I'm not sure I quite understand everything that's going on here).
Also, because of the previous lack of ansi escape code support, there's a bunch of code to translate certain escape codes to SetConsoleXXX calls. I wonder if at some point it might make sense to add support for just using the ansi escape codes if ENABLE_VIRTUAL_TERMINAL_PROCESSING can be enabled.


Fix casing of upgradingOS and automaticOSUpgradePolicy

Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

[ ] a private preview
[ ] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Design Document:
Previous API Spec Doc:
Updated paths:

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Schedule a data plane REST API spec review

Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`.
This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

Can we merge this with https://github.com/Azure/azure-rest-api-specs/pull/28325 since that already needs a breaking change approval?

Changes applied to #28325


How to add number of partition to a topic in Kafka?

How to add number of partition to a topic in Kafka using this code. I tried with meta function but its not working for me

@appasahebs  not support add partition to a topic


Remove fomantic accordion module

Replace it with native <details> element. Did some slight restyling on the release downloads, new behaviour should be exactly the same otherwise.
Here is how the three sections where accordion was in use now look:

Diff is best viewed with whitespace changes hidden.

make L-G-T-M work.


Separate Date and Time in LogProperties

To increase flexibility Date and time should be addressable separately so that more stylings are possible.
For example different colors within the date time string are not possible at the moment. If you want the date/time to be shown something like this:
[2022-05-13][11:57:43] while all brackets should have the same color while the date text should have a different color. This is not possible at the moment

you can always extend the presets and add your own to your delight

I know but i think those are important enough to be available by default

EDIT: The presets dont support dynamic content. The time changes every second but there is no way to tell the Log to render out the current time. You can just set a static string.

the log always uses the current time to log the messages (Log.replaceDynamicElements())

yes but only for the predefined time template string. currently there is no way to add a second time string


#5852 remove buefy tag

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[x] Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

[ ] Closes
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 4b19b5a
Refactored and restyled the NeoTag component and added a NeoIcon component for better UI.

🤖 Generated by Copilot at 4b19b5a

Oh, we're the crew of the NeoTag ship, and we sail the web so free
We've refactored and restyled our code, to make it look so neat
We've used a div and CSS, to give it some flair and flex
And we've added a NeoIcon too, to close it with a click

there are 2 more files where we use <b-tag, but I think those will be deleted its Facts.vue & keyboardhosrtcutsmodal.vue , so didnt change it there
PS. the cross icon in the tag now looks different as we use font awesome icon now

can we merge this one?


Problems cloning jetson--interference

Hi,
I'm having problems cloning jetson-inference:
desktop:~$ git clone --recursive https://github.com/dusty-nv/jetson-inference
Cloning into 'jetson-inference'...
remote: Enumerating objects: 164, done.
remote: Counting objects: 100% (164/164), done.
remote: Compressing objects: 100% (108/108), done.
error: RPC failed; curl 56 GnuTLS recv error (-9): A TLS packet with unexpected length was received.
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
Does anyone have similar problems?

Hmm I just tried re-cloning and didn't have an issue.
https://www.githubstatus.com/ is not showing a current outage.

OK. Thank you for checking. Must be a problem at mine end.

Hi I'm getting a similar issue.
Cloning into 'jetson-inference'...
fatal: unable to access 'https://github.com/dusty-nv/jetson-inference/': Could not resolve host: github.com

@ilackner can you clone any github repo?   Maybe github was down for a time when you tried before.


[3.x] Mesh merging - refactor to be backward compatible for CPU / GPU storage

Allows the old merge_meshes() function to work from the editor.
Fixes #91988
Most of the lines changed here are just moving the implementation functions to a new location. The bug fix is allowing them to be called choosing storage CPU or GPU etc, and defaulting the old function to store in GPU (which is the old way in 3.5).
So the PR is actually very simple and doesn't require in depth review or specialist knowledge (it just looks more complex because of moving a bit of code).
Notes

MergeGroups totally changed the backend for merging, which inadvertently broke the old merge_meshes() function in MeshInstance when used from the editor.
The breakage was simply because the new method defaulted to creating the result mesh on the CPU only (as this is significantly faster, as it removes a round trip to the GPU + drivers for any geometry processing).
This PR moves the wrappers for the MeshInstance merging functions to the MergingTool, and converts the results from the wrappers to GPU meshes, so they are suitable for use in the editor and rendering.

Thanks!


Fix python script and allow autotune prep/core to write to file directly

While running the autotune python script i noticed a couple issues:

bin/oref0-autotune.py was not compatible with python3.
The output of bin/oref0-autotune-core.js and bin/oref0-autotune-prep.js is piped to an output file which was causing autotune to crash because unrelated logs were being piped to the output file.

This PR introduces py3 compatibility (and fixes a couple of style issues) and adds an optional output file argument to the autotune core and prep modules to prevent extraneous data from being written to the files.

Has anyone tested this branch, such as by running a fresh install from it on a rig?

@hsghori did you see my question above about testing?


Localizing scopes

I trying use ActiveAdmin in a localized project. However, translating the scope names is not fully working feature now.
I using 0.3.4 version of gem, and I saw this in the code
File: lib/active_admin/scope.rb

    def initialize(name, method = nil, &block)
      @name = name.to_s.titleize
      @scope_method = method
      # Scope ':all' means no scoping
      @scope_method ||= name.to_sym unless name.to_sym == :all
      @id = @name.gsub(' ', '').underscore
      if block_given?
        @scope_method = nil
        @scope_block = block
      end
    end

Nil-ing the@scope_method variable is a really annoying thing, at least because the translation is firstly based on this variable. Instead, I think you must work around this in the code where the scope method calling is happens. The nil-ing is broke two case: :all, and if the scope declared in the ActiveAdmin controller instead in a model.

Hmmm... as I see, it is fixed in the git version. When do you plan a new release? It is a required feature for us, but we do not want to use Git version of any gem in production... :-(


dracula-qt5-theme: init at unstable-2022-05-21

Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 253233 run on x86_64-linux 1

1 package built:

dracula-qt5-theme


laravelshopper.io domain expired

@mckenziearts your laravelshopper.io domain expired about 2 weeks ago. Just making sure you're aware. The website is not viewable there, but laravelshopper.dev seems to work.

Hello @joelvh  and thank you for your attention. But I voluntarily shoutdown this domain to keep only the .dev. I prefer to have all the site and documentation on the same domain, it's easier to manage.

ok @mckenziearts - just know that you are still linking to the old domain from your GitHub repo description and README, org and the contact email has the old domain. Those are just examples, but there are more, possibly in the docs.