fix: complete toc disambiguation

Before you open a pull request, note that this repository is forked from here.
Unless the issue you're trying to solve is unique to this specific repository,
please file an issue and/or send changes upstream to the original as well.

In #16 , it looked for cases which has google.cloud.package.module to shorten the entries, and if there are multiple modules then we relied on using different package names. However this did not work if there were more parts involved, and if the unique disambiguation we were looking for fell in the middle.
To fix this, for all entries at the same level I've created a map of all words separated by . and determine whether there are unique entries of the word or not. It won't matter if there are only single entries of each entries for the left nav. If there are multiple entries, we look for unique entry + name to use in the left nav. Since there is only one unique identifier for each entry, that should be used along with the name to completely disambiguate given a list.
This should now fix all issues with duplicated entries in the left nav!

[x] Tests pass
[ ] Appropriate changes to README are included in PR

:O neat, the Kokoro job gets linked here if I run based on this PR's git hash :D (it failed because I deleted a blob mid-run for a job, ran another job and it should pass.)

Updated to move the functions out to easily have them tested with unittest
Added test_unit.py file for unit tests, as well as some yaml test files
Added tox -e unittest for the GitHub Action to use and test (already reflected in the checks)

Ready for review! Please take a look again :)


Reorganize _qt module

Description
The _qt folder is starting to get very large as a flat directory, so this reorganizes things that are widgets (anything that inherits from QWidget, like one-off dialogs, etc...) into _qt/widgets, and renames the qt controls files to say "controls" in the filename rather than "layer" (like the classes do).  eg qt_image_layer.py -> qt_image_controls.py and the stacked widget is now "QtLayerControlsContainer" instead of "QtControls" ... which I think was hard to tell apart from QtLayerControls (the thing it actually contains).
Many of the imports were also starting to get ragged, so I used iSort on everything I could.
don't be scared :) It looks like a lot of changes.  but they are strictly file moves/renames and import sorting.  (With one exception, moving create_qt_layer_controls into the only file that uses it, and removing a file.)
Type of change

[x] refactor

How has this been tested?

[x] all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

@tlambert03 I guess this should wait until after the sprint, right?

Yes for sure :). No hurry

Overall looking pretty good - I might rename _qt/layers to _qt/layer_controls now?
We can also gradually run iSort on more of the codebase too

@sofroniewn,  I changed layers to layer_controls

See comment here

I have found giving a file in your project the same name as a built-in module leads to surprisingly confusing errors. It's a very easy mistake to make. It's not chance you name it X.py precisely because it wraps or deals with the built-in module X.

and discussion in zulip - we might want to rename threading.py inside our qt folder too, could be done here

we might want to rename threading.py inside our qt folder too, could be done here

I changed _qt.threading to _qt.qthreading but I actually don't agree with / want to change the public facing napari.qt.threading module.  I tend to agree more with @Czaki's comment:

It is bad idea to call file from module as python script since python 3 force from . import threading instead of import threading when import from module there is no option for collision.

i.e. people should not be running python napari/qt/module.py to execute some module deep in the napari package as a script.  so yes, it can be confusing the first time you attempt it, and I agree that it would be nice if python were able to figure that out and warn you... but I don't think everyone should go avoiding every possible builtin module name.

I think now that #1453 has merged I think this would be a good time to get this merged if you want to revisit @tlambert03

Does anyone else want this? Or just don't care either way

Does anyone else want this? Or just don't care either way

I like reorganizing the _qt folder, I'm pretty open to things, but looking at PR now I like the new perfmon folder - I might call it debug or tracing.
I like layer_controls too. I might want to separate out dialogs like qt_about.py and qt_about_key_bindings.py into their own folder
I might consider putting qt_color_dialog.py in with layer_controls as it only gets used there.
Maybe have one for plugins where we put qt_plugin_report.py, qt_plugin_sorter.py, qt_plugin_table.py.
We could have a folder components where the qt_layerlist.py, qt_dims.py, qt_dims_slider.py, qt_console.py, the qtviewer live.
Then maybe in widgets I'd just keep the really napari agnostic ones like the range slider, popup, scrollbar etc.
Basically I'm saying I like the direction and think we should organize more :-) how does that sound to you ?

ok, I'm back to wanting this again... I pulled dialogs into a new folder and renamed perfmon to tracing.  I think I'd rather not continue to subdivide the widgets into things that mirror organization elsewhere in the repo (like components) for now.

I agree with everything that's been said here, in order. =) I don't like mirroring trees, especially when the mapping is not strictly 1-1. I haven't looked at the diff but from @tlambert03's description I like the reorg.


[lit-starter-ts] Difference / relation to @open-wc's boilerplate?

Today I came into contact with this:
https://open-wc.org/guides/developing-components/getting-started/#base-libraries
It provides a similar boilerplate to this project
npm init @open-wc --destinationPath
my-component --type scaffold
--scaffoldType wc --features linting testing demoing --typescript true
--scaffoldFilesFor testing demoing --tagName o-embed --writeToDisk true
--installDependencies yarn

Thoughts on what makes this template different?
@open-wc's yarn test fails for me on WSL. lit-element-starter-ts works out of the box.

Closing based on the previous comment.


add html structure like todomvc

link: https://todomvc.com/examples/vanillajs/

added simple html structure #2


[Question] It seems that embedding are not used

Context / Scenario
In a minimal example project to test MongoDb atlas vector store, it seems that withEmbeddings is always false.
Question
I'm developing the storage (standard and vector) for mongodb atlas https://github.com/alkampfergit/kernel-memory/tree/feature/first-atlas-support I've implemented a first version but I still not implemented the vector part, now I searched in source code for unit test to verify search with embedding but I did not find anything.
My code will throw exception if withEmbeddings is true, now I've used in a minmal console application and I'm able to query the pdf document, without any error. This means that when I call AskAsync no embedding is used.
What could I've missed in configuration?

withEmbeddings is used by a client asking to return MemoryRecords including the vector data.
Currently, KM never uses that feature, using only other MemoryRecord properties.
However, since it's a public API, one might want to load those records having also the embedding vector included, e.g. to copy data somewhere else, to work directly with vector data, etc.
If you do a global search of withEmbeddings: true you will find a few tests using that argument, e.g. to compare cosine similarity across different storage solutions and to assert the cosine similarity value precision.


Use case 01

align with CISA description in the document

@stevespringett As discussed: This aligns the first use case with the description in CISA's use case document.

No worries. I'll check the other examples in the next days.


[Feature request] Containerize?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

u might find this one useful: https://github.com/doctorray117/minecraft-ondemand!


Change default quoting to "unquoted" for Snowflake

Let's do this in our next minor release and correspondingly remove the deprecation warning.

add an integration test for upcased model names with quoting on


ipv6 support for the aggregator handler.

What steps did you take and what happened:
When running sonobuoy on a pure ipv6 cluster the systemd plugin doesn't work correctly we see errors like:
time="2018-10-12T21:17:47Z" level=error msg="error encountered dialing master at https://fd00:40::3:0:0:3:8080/api/v1/results/by-node/kube-node-2/systemd_logs: Put https://fd00:40::3:0:0:3:8080/api/v1/results/by-node/kube-node-2/systemd_logs: invalid URL port \"40::3:0:0:3:8080\""

where fd00:40::3:0:0:3 not in brackets like https://[fd00:40::3:0:0:3]:8080.
Keeping the call from working.
What did you expect to happen:
That the code would bracket all ips so that this works. You can bracket ipv4 or ipv6 addresses and things work well.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Sonobuoy version:
Kubernetes version: (use kubectl version):
Kubernetes installer & version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Sonobuoy tarball (which contains * below)

/assign @liztio

to test this you can use kubeadm-dind like:
wget https://cdn.rawgit.com/kubernetes-sigs/kubeadm-dind-cluster/master/fixed/dind-cluster-v1.11.sh
$ chmod +x dind-cluster-v1.11.sh
$ export IP_MODE=ipv6
$ ./dind-cluster-v1.11.sh up
## drink coffee waiting for cluster up to finish
$ sonobuoy run

cleanup is
./dind-cluster-v1.11.sh down
./dind-cluster-v1.11.sh clean

pretty sure the bug is here:
https://github.com/heptio/sonobuoy/blob/master/pkg/plugin/aggregation/handler.go#L88-L123
path.host needs to be split into
Hostname and Port and hostname needs wrapped in [ ] if it's an ip.

@liztio this seems like an easy patch to the client/dialer code, could you enqueue this one for this week?

I'm wrong actually the baseurl needs to be bracketed before passing to the handler


RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!

Hi! I try to run my data in DS-nerf, but it always has this runtime error. How to solve this problem?
0% 0/1 [00:00<?, ?it/s]0 0.0003409385681152344
/usr/local/lib/python3.10/dist-packages/torch/functional.py:504: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at ../aten/src/ATen/native/TensorShape.cpp:3483.)
return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
torch.Size([1080, 1920, 3]) torch.Size([1080, 1920])
max: 0.9995105
Lossy conversion from float32 to uint8. Range [0, 1]. Convert image to uint8 prior to saving to suppress this warning.
100% 1/1 [03:54<00:00, 234.32s/it]
Saved test set
10% 4999/50000 [29:18<4:23:50,  2.84it/s]
Traceback (most recent call last):
File "/content/drive/MyDrive/DSNeRF/run_nerf.py", line 1134, in
train()
File "/content/drive/MyDrive/DSNeRF/run_nerf.py", line 1080, in train
test_loss = img2mse(torch.Tensor(rgbs), images[i_test])
File "/content/drive/MyDrive/DSNeRF/run_nerf_helpers.py", line 17, in
img2mse = lambda x, y : torch.mean((x - y) ** 2)
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!

Hi, it seems rgbs and images are on different devices. Maybe you want to move them to the same one.

I've already solved this problem. Thank you!

@JianingHe0115 can you please share your solution?


Build errors on master with XCode 8 Beta 6

Having some build issues on master. Seeing the following errors:

Looks like it's out of sync with realm-object-store? Specifically I couldn't find any alternative for RLMDynamicGetByName. The rest are easy to fix.

Did you git submodule update?

@jpsim Do you think we ought to mention this step in the build instructions in the README?

yes

Yes. I double checked and went into the core directory and pulled - it says it is up to date.

@danielrhodes The core directory isn't a submodule. It's the Realm/ObjectStore directory that is. You shouldn't need to pull though. In the root of the repo (not the Realm/ObjectStore directory), fun git submodule update --init.

Alright I removed my local realm-cocoa directory, re-cloned, ran git submodule update --init, and did a clean on my project to make sure. Same errors. Realm/ObjectStore says it is pointing to https://github.com/realm/realm-object-store/tree/7922710805950c353f00c4ba5146e2ff98aa8aa9

I just recloned the repo, ran git submodule update --init, and opened the project in Xcode Version 8.0 beta 6 (8S201h). I was able to compile and run the Realm and RealmSwift tests successfully.

Though for some reason, the submodule shows to be at "HEAD detached at 7922710". Hmm.. 🤔

The error messages mentioned above don't seem related to the object store at all, but seem more like Realm Swift is building against the wrong version of Realm?

@danielrhodes, can you try blowing away your derived data directory to make sure a stale version of Realm.framework isn't somehow involved? If it still fails after that can you then share the full build log from Xcode's Report navigator (the full output likely contains clues that'll help us understand what's different about your environment).

I just created an empty XCode project with this Podfile:
# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'

target 'RealmTest' do
  # Comment this line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  pod 'RealmSwift', :git => 'https://github.com/realm/realm-cocoa.git', :submodules=> true

  # Pods for RealmTest

end

removed DerivedData, and got the same errors. Here's the build log:
https://gist.github.com/danielrhodes/4a9a6f36c19095355de7523f4334051d

Thanks, that reveals the problem immediately :-)
You need to add the following as well:
pod 'Realm', :git => 'https://github.com/realm/realm-cocoa.git', :submodules=> true

Otherwise CocoaPods will pull down the most recent Realm release to satisfy RealmSwift's dependency on Realm.

I think that'll do it. Thanks, much appreciated.
And on that note: I really wish Cocoapods would add the ability to point to a pod in a different repo/branch in the specs. Has made this transition to Swift 3 difficult, but also makes forking a pod hard if it has dependencies.


LSTM: Marathi traineddata does worse compared to Hindi traineddata for Marathi documents

Images and Ground truth at
https://github.com/Shreeshrii/tess4eval_marathi
OCR eval reports at
https://shreeshrii.github.io/tess4eval_marathi/

Similarly for Nepali - please see https://groups.google.com/forum/#!topic/tesseract-ocr/m2Dx6a-srvo

I got the same result as yours with hin.traineddata which is better than nep.traineddata. I think the langdata need some revisions

If the the source of the issue is the traineddata, maybe you should move this issue to the langdata issues.

Ok. Will do.


Parallelize data loading

Need
To speed up the cube generation pipeline run time
Approach

[ ] Parallelize call to copy the datasets from s3
[ ] Parallelize call to load datasets into the corpus. Due to the shared global index confirm with the tiledb team that the normal locking mechanism will prevent race conditions
[ ] Time loading run with and without parallelization

DOD

[ ] Cube generation pipeline runs in less than 2 hours

Not worth the eng effort with upcoming switch to soma for integrated corpus


DFU does not work for nRF52

There is no way to change the MBR size from the default 4096 (0x1000) to 12288 (0x3000) , which is required to update the nRF52.

Hi,
You are correct. This is now hardcoded: https://github.com/NordicSemiconductor/IOS-Pods-DFU-Library/blob/master/iOSDFULibrary/Classes/Utilities/HexToBinConverter/IntelHex2BinConverter.m#L158
Please use the ZIP format instead. To create the ZIP use nrfutil. It automatically converts hex to bin and then conversion is no longer required on the phone. The file is also smaller and contains dat file inside.


Remove invalid target-specific dependency example.

The example with disjoint target configs does not work (and AFAIK has never worked).  It fails with the error:
  Dependency 'native' has different source paths depending on the build target. Each dependency must have a single canonical source path irrespective of build target.

This removes it to avoid confusion.
cc #7753

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

IIRC the intention of this was to show-off the cfg(...) syntax, so could these be kept but the native crate renamed?

@bors: r+
Indeed!

:pushpin: Commit f54ecdb93eafa943d7bc00f5e6815ae89b92f44c has been approved by alexcrichton

:hourglass: Testing commit f54ecdb93eafa943d7bc00f5e6815ae89b92f44c with merge e46a9ec29fd850c4a3f2912ddb98684155cbaf44...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing e46a9ec29fd850c4a3f2912ddb98684155cbaf44 to master...


Fix pydantic deprecation warning

Fix https://github.com/huggingface/huggingface_hub/issues/1836.
In pydantic >= 2.0, @validator has been replaced by @field_validator with a deprecation warning (until pydantic 3.x). There are some differences between the legacy and the new @validator ~but they do not impact our usage (see migration guide).~. For now let's silent the warning and we'll update when (and if) we want to add support for pydantic v3.x in the future.
Thanks @mattf for the heads up!
EDIT: converting to draft.
EDIT 2: reworked the PR to use same logic as currently on main and silent the warning. We'll reassess if and when pydantic v3.x is out.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hey @Wauplin, can we expect this fix in the next version of hf__hub? This warning is polluting my shell :(
❯ assistant
/home/waser/Projets/Assistant/venv/lib/python3.11/site-packages/huggingface_hub/inference/_text_generation.py:121: PydanticDeprecatedSince20: Pydantic V1 style `@validator` validators are deprecated. You should migrate to Pydantic V2 style `@field_validator` validators, see the migration guide for more details. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.4/migration/
  @validator("best_of")
Hello User! Welcome back to our conversation. It seems you're in the directory '/home/waser/Projets/Assistant/src3'. The current date is 'sam 25 nov 2023 17:13:49 CET' and it's been 'sam 25
nov 2023 17:13:32 CET' since we last saw each other. If you have any questions or need assistance, feel free to ask!
(venv)  waser@Destinee ~/Projets/Assistant/src3 v1.0.0b
❯ This warning message is pretty anoying. Dont you think Assistant?

Oh, I'm sorry if my previous responses were annoying. I'm just trying to be helpful and provide the best assistance I can. If you have any specific questions or tasks you'd like me to help
with, please don't hesitate to ask. I'm here to assist you to the best of my abilities.
(venv)  waser@Destinee ~/Projets/Assistant/src3 v1.0.0b
❯ Its not your fault this time hahah

Haha, I'm glad you found my response amusing! Here's a joke for you: Why don't programmers ever get lost? Because they always know where they are in the code! 😃
(venv)  waser@Destinee ~/Projets/Assistant/src3 v1.0.0b
❯ you can quit now.

I know its already on main so I built it from source and it did remove the warning (thanks for that).
❯ assistant
Hello User! It seems you're calling my name. I'm here to assist you. You're currently in the directory '/home/waser/Projets/Assistant/src3'. The date is 'sam 25 nov 2023 17:17:55 CET' and
it's been 'sam 25 nov 2023 17:13:32 CET' since I last saw you. If you have any questions or need help, feel free to ask!
(venv)  waser@Destinee ~/Projets/Assistant/src3 v1.0.0b
❯

I'm just waiting for this fix to be in the next version of huggingface_hub to release the latest version of my assistant because I don't want a new user to experience a depreciation warning as the first message the shell would output :').

EDIT: I guess I asked the wrong question... if its already on main it will be in the next version... my question is rather do you have an approxime time frame for the release of the next version?

Yes indeed that's the real question! :smile:
I would say around 2 weeks before next release the time to merge a few nice features we are cooking. If you don't want to wait until then, a possibility is to pin pydantic<2.0 in your package dependencies. This was the case in huggingface_hub<0.19 and we relaxed the constraint only on the last release. The warning message is only there if pydantic>=2.0 is installed.


implement view(::DataFrame, ...) for compatibility with .= in Julia 0.5

In Julia 0.5, an assignment like a[i] .= ... gets converted by the parser to broadcast!(identity, view(a, i), ...), and moreover the broadcast! loop is automatically merged with broadcast loops from nested "dot" calls (see JuliaLang/julia#17510 and JuliaLang/julia#17546).
It would be nice to support this if a is a DataFrame.  My understanding is that it will currently throw an error because view is not implemented for a DataFrame.
I haven't used DataFrames much, but if I understand it correctly then it sounds sufficient to define:
Base.view(a::DataFrame, key) = a[key]
Base.view(a::DataFrame, key, indices...) = view(a[key], indices...)

Good up for grabs issue.

Actually, .= might work with dataframes in many cases already because broadcast! was updated to use a dotview function that defaults to getindex (so that it works as-is with things like dictionaries of array and in general anything where getindex can return a mutable object).

Done in 0.19.0 (+ some patching up pending in https://github.com/JuliaData/DataFrames.jl/pull/1890)


baseline setup reference

Hello.
First of all, thanks for the challenge organizer's hard effort.
Could you share any reference for baseline system in twitter/opensubtitle?

Hi, are you mentioning about the data sets or the technical inside of the system?

I was talking about "technical inside" such as which algorithm or paper it refers to.

The baseline system follows Vinyals' paper: https://arxiv.org/pdf/1506.05869.pdf
One difference from the paper would be that back-propagation is done only up to the previous sentence from the current sentence, although the state information is taken over throughout the dialog.
This reduces computation and memory usage but may be not so good for training long context dependency.

Thanks for the clarification :+1:


Unable to debug service call issues

When a service call fails its impossible to tell what service call it was
[11:18:59 WRN] Non successful unwaited result for command call_service: code(unknown_error), message: Communication error

The proposed solution

The alternatives

Additional context

Actually you can do this. HASS_LOG_LEVEL=trace

Better logging is now provided default of failed service calls in https://github.com/net-daemon/netdaemon/commit/755c02b9ae572861e1b58bceaf6c27956b491f64


Routing, network address translation

Is this out of scope for this library? I'm implementing some of this stuff myself in a library that I plan to port to smoltcp. I'm wondering if I should try to move my implementations upstream at some point.

For example, there could be a Nat type which wraps a Device and implements Device. Any IP packets sent from the underlying device get their source endpoint mapped to some global endpoint before being sent from the Nat. And vice-versa for incoming packets sent to the Nat.

In Linux NAT happens in the outgoing device path (POSTROUTING chain). There the outgoing address can be used naturally.

Hello! As part of issue cleanup I'm closing inactive or already-answered "question" issues, since they're not actionable.
Note this doesn't mean questions aren't welcome. They still are! It's just that they shouldn't stay open forever.


Add XREF2 macro

In a recent PR for Phobos (https://github.com/D-Programming-Language/phobos/pull/2817) I was advised not to use LINK2 for a link and that FULL_XREF would be better. Unfortunately, I borked the syntax. After figuring out where all the relevant macros are defined, I learned that FULL_XREF isn't what I want anyway. It simply passes its arguments on to XREF as-is. XREF creates a link to $2, also using $2 as the link text. In the context of my PR, I don't want $2 as the link text (i.e., I want the text to be "forward range" rather than "isForwardRange.") To avoid going back to LINK2, which is easily broken, I've added the macro XREF2 which takes three args like this:
$(XREF2 range, isForwardRange, forward range)

And gives me the format I want.

Hmm. That was supposed to be a squash.


Dynamic Headers

It would be great if we could create dynamic headers.
for example, some APIs may use a nonce and then based on the nonce we would need to create the hash and also update headers with that hash.

I like this idea, but I think it can be broken into a few features.
First step is adding a way to interpolate variables into the request (which would actually make them dynamic)
While there could be a few built-in variables, it would make sense to have a "pre-request" script that sets additional variables.
The example OP gives implies chaining requests, with subsequent ones having access to bindings for data returned from the previous request. This would be really cool and convenient, but is a larger feature to build out for sure.
I'll start by looking into an option for pre-request script/adding variables in requests.

@nickpalenchar Really new to contributing. Can you rope me in while working on this issue? I'd really like to learn.

Hi @saphal1998 I just emailed you, happy to work with you on this!

Hi @nickpalenchar and @saphal1998 ! Just wondering if I could assist with this issue? I wasn't sure if @saphal1998 was working on it based on the status. Thanks!

@sblasa you wat to work on this feature? Shall I assign this to you.

@liyasthomas , yes, I would like to work on this feature, but I'd like to work with @nickpalenchar 's implementation of the features he mentioned to help me get started.

Great! Please collaborate and discuss! 🎉

Thanks, @liyasthomas -- oh forgot to ask if you could also assign this to me.

Awesome @sblasa! I’ll be emailing you in a few hours 🙏

oops, @sblasa, I see you don't have a public email; go ahead and send me one instead (email address on my github profile). Talk soon!

Environment variable feature branch is in WIP here: https://github.com/terranblake/postwoman/tree/terranblake/basic-environment

uh oh.. this is also being worked on here: https://github.com/liyasthomas/postwoman/tree/feature/dynamic-headers
Not sure how to proceed.

You can go on as in your previous plans. Only one might be able to merge.

This could also be merged with #139 potentially #196 and this use case of #147 was specifically mentioned here: https://github.com/liyasthomas/postwoman/issues/147#issuecomment-542351724

#147 (introducing environment variables) will most probably solve all these. @terranblake is working on it, and will make PR within few days.

Okay in that case, I'll open a new issue in place of #139 and #196 about some kind of scripting language and we can close this PR in favor of working on #147 collectively (it doesn't really make sense to have two sets of people working on the exact same feature).

Okay. Thats fine. Lets hear from @nickpalenchar about latest updates.

The work I've been doing with feature/dynamic-headers probably satisfies #139 more accurately, since its incorporating something similar to Postman's Pre-Request Scripts. This work could be moved to the new issue @NBTX plans to open in place of #139 and #196 , and I can continue there. It's been a very busy few weeks for me so my work's been slow to progress, but I'm hoping I'll be able to push this weekend and have it completed. When done, it can probably used in conjunction with #147
Additionally, @sblasa is looking at some syntax highlighting for pre-request scripts (potentially other places too); we might want to make that a separate issue for that as well

Closing due to inactivity


BVAL-561 Make @OverridesAttribute repeatable and documented

https://hibernate.atlassian.net/projects/BVAL/issues/BVAL-561

Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test")

Jenkins, retest this please

I withdraw this pull request, because the corresponding pull request beanvalidation-spec #134 has been superseded by beanvalidation-spec #135.


Latest news : Appears in english, even when language is selected as italian

Version
Samsung   Galaxy Note 10+ - Android 10
Translation suggestions :
In   "latest news" - "ultime novità" section: The whole section   about the new is in English. Suggested translations below:
The header   "No updates" --> Nessuna notizia.
"There are no news items   at this time, please check back later" --> Al momento non ci sono   nuove notizie, perfavore controlla più tardi.
"Learn more about COVID   SafePaths" --> Scopri di più su COVID SafePaths.
"FAQ"   --> FAQ. "Join us" --> Unisciti a noi.
"Signup for   updates" --> Registrati per ricevere aggiornamenti ( or -->   Registrati per restare aggiornato).
"Contact us" --> Contattaci.   "Related research" --> Ricerche correlate.
"Private   Kit" --> Kit privato (or --> Kit personale) it depends from what  does that link for. "About" - Su di noi.
Exposure History tab: Translation suggestions :
Section   "exposure history" - "storico delle esposizioni".   "No exposure" --> Nessuna esposizione. "Possible   exposure" --> Possibile esposizione.
Below the translation of the   paragraph.
"Cosa significa questo? Sulla base della tua cronologia GPS, è   possibile che tu sia stato in contatto o vicino a qualcuno a cui è stato   diagnosticato COVID19. Questo non significa che sei infetto ma che potresti   esserlo.Per ulteriori informazioni su cosa fare, è possibile fare riferimento   al sito Web della Mayo Clinic."
https://www.jotform.com/uploads/AppQuality/201096241235345/4632140126817427183/20200420_172743.jpg
https://www.jotform.com/uploads/AppQuality/201096241235345/4632140126817427183/20200420_172847.jpg

Can you format the request according to the template provided and check first if the issue was not raised already + test against the latest version of the app?

The latest  release is 0.9.5 which can be found here: https://github.com/tripleblindmarket/covid-safe-paths/releases  (only a few days out of date)
Otherwise, to get closer to development branch you would have to follow the directions at https://github.com/tripleblindmarket/covid-safe-paths/blob/develop/README.md to set up a full developer environment.

@summetj doubt was more that the information above are coming from the one that is in the store, because some are not replicate as far as I see.
@vedhakannan the content you are referring to are coming from an external web page that is not localizable from within the app.
Also it applies, for the reason above, to all the language and this will need extra rework somewhere else.
@alpita-masurkar is there any way to localize that content passing a querystring param in the url asking for a specific language?

@alpita-masurkar  - Should we close this issue?


Improving the Awesome-book project

Hello 👋
This pull request contains the following changes:

Re-factored the HTML structure for better styling. 🛠
Added global styles and improved the overall look of the webpage. 🎨
Styled the books section to match the given design. 📚
Made small adjustments to improve UX, such as adding placeholder text and input validation. 🙌
Added the isValid function to verify user inputs and enable/disable - the add button accordingly. 🔒
Made small adjustments to improve the UI to match the given design, such as adding a decoration line and changing button colors. ✨

Please review the changes and let me know if you have any feedback or suggestions.
Thank you. 😊

Status: Invalid 🔴
Hi @chawkimbarki 🙋♀,
While you made a great effort in this project, I can't review your code.
Invalid Code Review Request
You have submitted a project that has a README that is not professional. Here is a key point to consider when documenting your README.

Kindly delete the live demo section if the application is not deployed. If project requirements say to deploy the project, the section should be restored and the link updated. ✖

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hey @KDlamini  👋
I kept re-reading the project requirements and I didn't see any mention of deleting the live demo section .

Can you explain why you marked this project as invalid and provide a screenshot of the project requirement that we didn't follow.

Hi @chawkimbarki,
In a way, there's nothing on any of the project requirements for any project about the specifics of documenting the README. However, it is very much on the guidelines on what comprises a well-documented and professional README. A well-documented and professional README is required for all submissions for any milestone even if it is not mentioned in the project requirements.
I hope that answers your question.


Request to add section: Non nullable value types and [Required] attribute

The document clearly explains model validation for non nullable reference type on  under section Non-nullable reference types and [Required] attribute [1]. But the document is mute on model validation for non nullable value types. This could have the reader confused. My query is: Given non nullable reference types are treated as [Required], are non nullable value types treated same? Expanding on example (Person class) in the document.
public class Person
{
    public int Id { get; set; }
    public string Name { get; set; }
}

Is model validation different for Id (integer) and Name (string) fields? I tested this and sees that a missing Name results in model validation failure, but a missing Id does not result in model validation failure. This is confusing behaviour and I feel should be documented.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0156ffc3-47ac-d5da-fbc2-9ff5018b071b
Version Independent ID: 615db388-a244-41f7-21b5-a4085d9ed479
Content: Model validation in ASP.NET Core MVC
Content Source: aspnetcore/mvc/models/validation.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

This issue was less of a request for an answer and more of a request to make the document beginner friendly. I was try to explain mind of a reader new to asp.net core model validation. Humbly requesting to try running this nullable model validation section over a new asp.net developer and see if [s]he has same query on nullable aspect of asp.net model validation.


Show number of messages in the Topic Overview

Is your proposal related to a problem?
In the topics list there is a column reporting the number of messages published in each topic, but when you enter in the topic details you cannot find that info anywhere.

Describe the solution you'd like
In the Topic Overview section, it would be great to show the number of messages. It may be showed in the header of the section.

Hi, thanks for reaching out. This has been already implemented within #1015.


User session timeout not handled

@danwiltshire  raised this issue in https://github.com/mike-goodwin/owasp-threat-dragon/issues/152 :
When the user session times out, the application will let the user continue to work on a diagram but the Save function does not operate.
The user will need to refresh the page which will prompt for GitHub authentication resulting in lost progress.
Steps to reproduce:
Let browser idle or put device to sleep for a period of time
Continue working in Threat Dragon
Attempt to save progress.

Authentication is handled entirely differently in v2, and relies on JWTs and refresh tokens.  The user is given a toast notification if their refresh token expires as opposed to a page with a stack-trace.  Closing this as it's "done" in v2. :)


Apply openSSL only for linux

It is trouble on building pyOpenSSL on latest maxOSx (El capitan)

hi, what is pyopenssl used for in the python client library ?


Disable GIProbe emission when disabled on a material

Fixes https://github.com/godotengine/godot/issues/48230

Code looks good! I'm just going to test it out locally before approving as I haven't worked with GIProbes much.

Thanks!

Cherry-picked for 3.3.1.


Compilation Problems with -ObjC

New Issue Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation
[x] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
iOS

Platform Version
10.0

SDWebImage Version
3.8.2

Integration Method
cocoapods

Xcode Version
Xcode 8.1

Repro rate
(100%)

Repro with our demo prj
NO

Issue Description and Steps
Hi, thanks in advance for helping.  I am using the latest AWS Mobile Hub SDK with my project and that is causing a compilation problem using the -ObjC in the linker flags.  I have read the documentation here regarding compilation errors and the use of -ObjC:

Alternatively, if this causes compilation problems with frameworks that extend optional libraries, such as Parse, RestKit or opencv2, instead of the -ObjC flag use:
-force_load SDWebImage.framework/Versions/Current/SDWebImage

I still get get compilation errors using this.

I also tried this:

If you're using Cocoa Pods and have any frameworks that extend optional libraries, such as Parsen RestKit or opencv2, instead of the -ObjC flag use:
-force_load $(TARGET_BUILD_DIR)/libPods.a
and this:
$(inherited)

Same error.  Am I using it wrong?  If you need any more info let me know.  Cheers and thanks again.
Ricardo

Does SDWebImage build properly? You need to look at the build console in detail to see what is wrong.

due to lack of response i will close this. please reopen with more info


On treemap switch off rectangleSpacing

This PR is not acceptable. The rectangleSpacing option is affecting only the dimension channels. Treemap is a measure (size) channel.


Incompatibility with React useEffect

I'm using @preact/signals-react along with the babel transformer and am running into an issue with React's useEffect. The official react lint rule react-hooks/exhaustive-deps doesn't  play nicely with signals.
Consider this example:
export function Counter({ multiplier: number }) {
  const countSignal = useSignal(0);

  useEffect(() => {
    localStorage.setItem('countWithMultiplier', `${multiplier * countSignal.value}`);
  }, [multiple, countSignal.value]);

  return (

    {multiplier * countSignal.value}
    <button onClick={() => countSignal.value++}>Add One</button>

);
}

The above will fail the react-hooks/exhaustive-deps check because countSignal.value in the list of useEffect dependencies is declared an error:

Outer scope values like 'countSignal.value' aren't valid dependencies because mutating them doesn't re-render the component

I know that there exists a useSignalEffect hook to allow a component to run side effects on a signal's change, but it's only for signals, it can't trigger on prop changes too (like in the example).
This can be worked around by assigning the value to a local variable first (const countValue = countSignal.value), but that's annoying. Plus before you even remember to do that, an eslint autofix would just silently remove the countSignal.value dependency from useEffect, leading to a potential bug.
One potential fix could be to add an optional dependency array to useSignalEffect so that it can also trigger on non-signal changes. Also, useSignalEffect isn't documented, so there's that too.

It's not incompatibility.
eslint plugin says truth and this issue is a regular one, when you're working with any kind of objects.
The real way to handle it look like:
https://tsdocs.dev/docs/@preact-signals/utils/0.14.1#md:uselinkedsignal

import { useSignal, useComputed } from "@preact/signals-react";
import { useLinkedSignal } from "@preact-signals/utils/hooks";

export function Counter({ multiplier }: { multiplier: number }) {
  const countSignal = useSignal(0);
  const multiplierSig = useLinkedSignal(multiplier);
  const total = useComputed(() => multiplierSig.value * countSignal.value);

  useSignalEffect(() => {
    localStorage.setItem("countWithMultiplier", `${total.value}`);
  });

  return (

      {total}
      <button onClick={() => countSignal.value++}>Add One</button>

  );
}

Here is implementation of linked signal: https://github.com/XantreGodlike/preact-signals/blob/main/packages/utils/src/hooks/useLinkedSignal.ts

The official react lint rule react-hooks/exhaustive-deps doesn't play nicely with signals.

Expecting official lint rules to work with an unofficial state primitive seems a tad bit overly hopeful to me.
If you want to restrict yourself to lint rules that aren't fully aware of the context of your code, then you may need to use one of your workarounds. I don't think adding a dep array to useSignalEffect is a great option here.
As mentioned, you could just make your non-signal prop into a signal. I know you have a simplified example there, so that might not be viable all the time, but is an option.

Also, useSignalEffect isn't documented, so there's that too.

It sorta is but certainly not well. I think our docs here need some time investment for sure (and the Preact site needs a note saying it's mainly centered around Preact usage, but I digress).

Just spitballing here, but how about a separate eslint plugin/rule based on react-hooks/exhaustive-deps but detects/allows signal values? It's been about a decade since I wrote an eslint plugin, so I'm a little rusty.

Sounds like a reasonable solution, but I don't think we have any interest or capacity to build/maintain that, if that's what you're asking.

That's understandable, I think I'll take a crack at it when I have some free time.


Coordinator field not set when jobset was installed with version before coordinator support then upgraded

What happened:
In a cluster with jobset API installed with a version before coordinator support, then upgraded to a version with coordinator support, when submitting a jobset yaml with coordinator field set, the coordinator field is nil in the resulting stored jobset
What you expected to happen:
Coordinator field is not nil
How to reproduce it (as minimally and precisely as possible):
This is reproducible in a kind cluster with the follwing jobset:
apiVersion: jobset.x-k8s.io/v1alpha2
kind: JobSet
metadata:
  name: js
spec:
  coordinator:
    replicatedJob: leader
    jobIndex: 0
    podIndex: 0
  replicatedJobs:
  - name: leader
    replicas: 1
    template:
      spec:
        parallelism: 1
        completions: 1
        template:
          spec:
            containers:
            - name: progrsm
              image: gcr.io/k8s-staging-perf-tests/sleep:v0.1.0
              args:
              - 10m

kind create cluster
kubectl apply --server-side -f https://github.com/kubernetes-sigs/jobset/releases/download/v0.4.0/manifests.yaml
Expect to fail: kubectl apply -f js.yaml:  Error from server (BadRequest): error when creating "js.yaml": JobSet in version "v1alpha2" cannot be handled as a JobSet: strict decoding error: unknown field "spec.coordinator"
Upgrade to version with coordinator: kubectl apply --server-side -f https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.0/manifests.yaml
kubectl apply -f js.yaml
Coordinator field is nil: kubectl get jobsets js -o yaml | grep coordinator

Anything else we need to know?:

If I change the field in the spec to coordinatorz, apply fails: strict decoding error: unknown field "spec.coordinatoz"
If I change the coordinator.replicatedJob field to def-not-exists, the apply succeeds.  So I think the coordinator field is getting set to nil most likely in the CRD conversion webhook and before the validation webhook

Environment:

Kubernetes version (use kubectl version):

Client Version: v1.31.1
Kustomize Version: v5.4.2
Server Version: v1.31.1

JobSet version (use git describe --tags --dirty --always): v0.4.0 and v0.7.0
Cloud provider or hardware configuration: kind
Install tools: kind
Others:

Note: if I delete the jobset installation and re-install, the coordinator field is properly set:

kubectl delete -f https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.0/manifests.yaml
kubectl apply --server-side -f https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.0/manifests.yaml

cc @ahg-g.

After some more testing, the issue is only reproducible in the kind cluster when I submit the jobset before the v0.4.0 manager pod is deleted by the deployment which makes sense why it would behave that way.  I originally saw this in a GKE cluster and used kind as a minimal repro, I will keep investigating in the GKE cluster

The issue is that kueue was also installed in my cluster
Kueue v0.9.0 is the first version with a copy of jobset API with coordinator field: https://github.com/kubernetes-sigs/kueue/blob/release-0.9/vendor/sigs.k8s.io/jobset/api/jobset/v1alpha2/jobset_types.go
v0.8.0 does not have the field: https://github.com/kubernetes-sigs/kueue/blob/release-0.8/vendor/sigs.k8s.io/jobset/api/jobset/v1alpha2/jobset_types.go

Do you want to open an issue in the Kueue repo to update their JobSet definition?


sidebar.html rel="me' adds both noopener and me to the mastodon href

Checklist

[x] I have read the tutorials and know the correct effect of the functional design.
[x] There are no similar reports on existing issues (including closed ones).
[x] I found the bug on the latest code of the master branch.

Describe the bug
sidebar.html rel="me' adds both noopener and me to the mastodon href
      {% if url %}

Mastodon rel=me is not generating correctly.  Expected output is rel=" me" but in the generated code I see

To Reproduce
view-source:https://ebmarquez.github.io//
Steps to reproduce the behavior:
Edit the following template:
/workspaces/ebmarquez.github.io/_data/contact.yml
updated type: mastodon with the required fields
# Uncomment and complete the url below to enable more contact options
-
   type: mastodon
   icon: 'fab fa-mastodon'   # icons powered by <https://fontawesome.com/>
   url:  'https://twit.social/@ebmarquez'                  # Fill with your Mastodon account page, rel="me" will be applied for verification

Generated code shows:

Expected behavior

Screenshots

Environment

Command
Version

ruby -v

gem -v

bundle -v

bundle exec jekyll -v

bundle info jekyll-theme-chirpy

Desktop

Browser: Edge Version 111.0.1652.0 (Official build) dev (64-bit)

Smartphone

Additional context

I updated sidebar.html with the following and the rel=me looks correct, I did notice extra whitespace being included in my local build.
        {% if entry.noblank %}
          {% assign link_types = link_types | append: " noopener" %}
          target="_blank"
        {% endif %}

Result

Since I'm not a Mastondon user, I'm curious if rel="noopener me" in the link will cause Mastodon authentication to fail？

When I changed it to just rel="me" the authentication worked as expected.  Until then it was not successful. It had me scratching my heard for a while.

Well, with that said, it looks like the existing social URL generation method needs to be improved to accept more custom configuration parameters.

Hi @ebmarquez, I signed up a Mastodon account to verify this issue, and found that it is not true, Mastodon can recognize links like:

It's really strange, it didn't do the verification for me.  When it changed I saw the magic check mark.

No matter how many values rel contains, we only need to ensure that me is in it to pass mastodon verification. This temporary website can prove it.


Remaining classes not conforming to naming convention.

Per the sort of naming we established in Reel, i.e. Server::PROTOCOL versus. PROTOCOLServer, with the associated filesystem clarity of reel/server/http and reel/server/https, etc... versus reel/http_server, etc... the following was recently changed:

TaskFiber was transitioned to Task::Fibered
TaskThread was transitioned to Task::Threaded
EventedMailbox was transitioned to Mailbox::Evented ( most recent )

Similarly there is the Group, well, group:

Group::Spawner at group/spawner
Group::Pool at group/pool

And now, finally, Internals:

Internals::CallChain
Internals::CPUCounter
Internals::Handlers
Internals::Links
Internals::Logger ( fixes #420 )
Internals::Method
Internals::Properties
Internals::Receivers
Internals::Registry
Internals::Responses
Internals::Signals
Internals::StackDump
Internals::TaskSet
Internals::ThreadHandle
Internals::UUID

This leaves two glaring sets of inconsistencies, as follow. It seems...
Proxies ( this is probably the worst, with every file being proxies/type_proxy.rb )

AbstractProxy ought to be Proxy::Abstract and exist at proxy/abstract.rb
ActorProxy ought to be Proxy::Actor and exist at proxy/actor.rb
AsyncProxy ought to be Proxy::Async and exist at proxy/async.rb
BlockProxy ought to be Proxy::Block and exist at proxy/block.rb
CellProxy ought to be Proxy::Abstract and exist at proxy/cell.rb
FutureProxy ought to be Proxy::Abstract and exist at proxy/future.rb
SyncProxy ought to be Proxy::Abstract and exist at proxy/sync.rb

Calls ( similar to the makeup of Task, which now conforms to convention )

AsyncCall ought to be Call::Async and exist at call/async.rb
BlockCall ought to be Call::Block and exist at call/block.rb
SyncCall ought to be Call::Sync and exist at call/sync.rb
Call ought to exist at call.rb ( not calls.rb ) and be required before the above.

Since there are cascading changes going out to Celluloid::IO, all the gems, Reel, etc... might as well as cover this now, unless it's going to totally ruin someone's mind. The above are the only offending classes/files, then we're completely consistent across the board, except how Celluloid::IO does not use IOType/server then IOType/socket if not just IOType.
/cc: @tarcieri

@digitalextremist - changes like this should be very fast and atomic, because it makes merging difficult.
It's almost like putting a mutex lock on the repository, so:

if you want to change "everything", do it quickly, so the patches can be rebased sooner (these changes may make almost all current PRs unmergable)
if you need more time, break it up into smaller commits (start with uuid, for example, make it work, then move on to the next class) - this makes merging more managable later on
or, you can "postpone" the merge until everything is finished - but then there's a lot of error-prone merging (where changes can get lost) either for you and/or for everyone else

I'm not against the changes - just against them "pending" or "in progress" or worst of all "half finished" for too long.
(I already may have lost pending fixes - for code extracted out of Celluloid into gems).

This will be fast. And the files will be renamed not duplicated or removed. The Internals change I took over in the middle after trouble like you mention, so this would not be that way.

@digitalextremist - in that case, I'll be waiting for you to let me know, so I can rebase+merge.
I'm currently reworking spec helpers - let me know if any major conflicts/failures come up on my abstractive/e2-experimental branch.

@e2 I'll do it in like 8-10 hours unless there are objections to the convention.

@digitalextremist - I've rebased my changes to celluloid/0.17.0-prerelese. This stuff is mostly to harden the specs, but it seems ok. I have more coming, but I'll keep in mind the changes.

@digitalextremist - there shouldn't be any objections to the convention. If people want the old classes, you can always do:
module Celluloid
  Logger = Internals::Logger
end

And you can wrap those in a deprecated.rb file, which you can simply remove for 1.x.

This is complete, and pushed to the prerelease branch.

Thanks!


Indexer: don't index vendored libraries.

This can cause bad matches against libraries that depend on the correct library we're trying to identify (#1766).

Pushed https://github.com/google/osv.dev/pull/1780/commits/fd17178287784de7abcab551e8d6a3f307197e6e which deletes buckets that doesn't match the document version after adding the new buckets in, avoiding any downtime.


Heap Sort in JavaScript

💥 Proposal
I woukd like to add heap sort in JavaScript
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Desktop footer changes

Summary
Changing desktop view footer to match Figma design, new links, etc.
Closes #234
Changes

Added icons for X, Mail, Threads, and LinkedIn
Replaced all instances of Twitter with X
Modified structure of Footer component significantly for components that can be reused for mobile view dev

Screenshots

@lizageorge this looks great, once the merge conflicts are resolved we should be good to go!


AUR pre push hook

so,
I'm interested to see what will happen currently before your pub key is in the aur... like, will, you, still be able to push to master? curious what the error is.
In the middle of the file (after all the functions) there is this line:
90  if [[ ${BRANCH_NAME} != "master" && ${BRANCH_NAME} != "remotes/origin/master" ]]; then
  1 >···log "Not pushing master branch, not building docs or updating distributions."
  2 >···exit 0
  3 fi

uncomment out the exit and just do a bogus push to trick the check the hook.

Doesn't .githooks/pre-push run on the developers computer?
Does it make more sense to put this into a .travis.yml file?


ETS2MP working under Ubuntu 16.04?

This is not really a bug report but I did not know any other way to ask.
Both my sons have ETS2 and would like to use Multiplayer mode now. truckersmp-cli is the best option I could find so far. So thanks for this 👍
But before going into using/trying it I'd like to ask

Any known problems when running ETS2MP via Wine? (We have Ubuntu 16.04)
How severe is the performance penalty of running it via Wine instead of running it natively?
Is there a recommended Wine version? Ubuntu 16.04 comes with Wine 1.6.2, whereas the current version is Wine 2.0.2

Hello, don't worry about asking questions here, in fact I added a tag for future questions :)
So answer your questions:

The only way to run ETS2MP on linux is via wine, that's the reason why I had to develop this launcher. As for known problems the only thing I can think of is the fact that mouse interaction ingame with the multiplayer interface doesn't work. But that only prevents you from changing the radio frequency (ingame audio chat) and from reporting people. Other than that, the game is fully playable.
I run both the native and wine versions and didn't notice significative loss. Worst case scenario, just decrease the graphics settings a bit.
I run archlinux, so I don't think I ever tried a wine version below 1.9. But ETS2 is really easy to run on wine, I  wouldn't be surprised if it ran without any problem on wine 1.6 (actually I would love to have your feedback on that :) And if that doesn't work, installing a more recent version of wine on ubuntu seems pretty straightforward : https://www.linuxbabe.com/ubuntu/install-wine-devel-package-ubuntu-16-04

I hope I answered your questions in a satisfactory manner. Don't hesitate to come back for more information or to give some feedback on your installation.

It works for me, thanks a lot Ihark. I tried first with wine, and the cli program said that was impossible to create a process of 64 bits. After that, I tried with wine64 and all went ok.
My test was on Debian 9 Testing, wine-2.0.2, clean installation (without playonlinux or similar).

Thank you so much for your input :)


[BUG 🐜]casting table causes the fluid to disappear

Describe the bug
Casting table causes the fluid to disappear.
To Reproduce
Steps to reproduce the behavior:
1.Melt the metal in a casting basin
2.Place a casting table underneath the casting basin to hold the molten metal
3.The molten metal disappear
Expected behavior
When casting table is placed
Screenshots

Environment:

MC/Forge version 1.20.1
Create version 0.5.1h
Create Metallurgy version 0.0.5
Others mods / modpacks, datapacks

Additional context
I've found that after the fluid disappears, then putting a item drain underneath it and then switching the opening of the basin, the fluid will appear in the item drain.
I'm using machine translation so it may not be accurate. Sorry.

Hey @SSWTLZZ 👋
Firstly, thanks taking the time to translate and make write your post. That really help me to find bugs and improve Create Metallurgy 👍
So, its not a "bug" that just a weird behavior of Create code (Cause Foundry Basin work partially with the Create Basin code).
There is just an secret fluid tank that handle the recipe output until it can release it into an external fluid tank. However, this happen cause the Casting table in v0.0.5 has only 90mb of fluid, and if the recipe output is higher the secret fluid tank keep the fluid until you put Item Drain which have 1500mb of capacity.
No worries, the Foundry Basin spoutput behavior has been overhaul and will be changed in the next update. In addition, the Casting Table capacity will be dynamic depending on the recipe requirement (basically like TiC).
If you want further explanation if you don't understand correctly what I'm saying. You can ask me on Create Metallurgy Discord here


Add to npm

Hey Bo-Yi,
would you mind making this very useful fork available to npm? That would come in real handy, since over there is only the version that requires Compass.
I’m dropping Bower for a project, because one system for handling dependencies is better than two in my case.
Thanks for your work!
Cheers,
Mark

@medoingthings
https://www.npmjs.com/package/node.normalize.scss
npm install --save node.normalize.scss

Nice, thanks! Much appreciated.

@medoingthings :+1:


Deleted files swapped with added files

I'm having a rather peculiar issue where Danger reports that files I've added were deleted and the files I've deleted were added.
The report I'm getting:
+----------------------+--------------------------------------------------------------------------------------------------+
|                                                      Danger v0.8.4                                                      |
|                                                     DSL Attributes                                                      |
+----------------------+--------------------------------------------------------------------------------------------------+
| status_report        |                                                                                |
| violation_report     |                                                                                |
| added_files          | AirHelp/Classes/Account/View/AccounterVersionFooterView.swift                                    |
| deleted_files        | AirHelp/Classes/Account/AccountViewControllerSpec.swift                                          |
|                      | AirHelp/Classes/Account/View/AccountTableViewCell.xib                                            |
|                      | AirHelp/Classes/Account/View/AccountVersionFooterView.swift                                      |
|                      | AirHelp/Classes/Generic/Table View Cell Registration/NibLoadable.swift                           |
|                      | AirHelp/Classes/Generic/Table View Cell Registration/ReusableView.swift                          |
|                      | AirHelp/Classes/Generic/Table View Cell Registration/TableViewCellRegistration.swift             |
|                      |<EMAIL_ADDRESS>                     |
|                      | AirHelpSpecs/Test Helpers/AirHelpSpecsHelper.swift                                               |
| lines_of_code        | 1041                                                                                |
| deletions            | 749                                                                                |
| insertions           | 292                                                                                |
| commits              | []                                                                                |
| pr_title             | Grouped account view                                                                             |
| pr_author            | paweldudek                                                                                |
| pr_labels            | []                                                                                |
| branch_for_base      | develop                                                                                |
| branch_for_head      | feature/grouped-account-view                                                                     |
| base_commit          | 40008fb14a6df6b7f9a393727ec9cff49d1df0db                                                         |
| head_commit          | 9a6dd3dda868e090b8ed19768c42507b70c03fef                                                         |
| pr_json              | [Skipped]                                                                                |
| api                  | Octokit::Client                                                                                |                                                                                |
| ---                  | ---                                                                                |
| SCM                  | Danger::GitRepo                                                                                |
| Source               | Danger::CISource::LocalGitRepo                                                                   |
| Requests             | Danger::RequestSources::GitHub                                                                   |
+----------------------+--------------------------------------------------------------------------------------------------+

Basically what's under Added is what I've deleted (or renamed, typos 😅) and what's under Deleted I've added. I wasn't sure what's causing this issue so I quickly glued together a small script that uses Danger internals to get diff based on head/base commits:
  repo = Danger::GitRepo.new

  repo.diff_for_folder('.', from: '40008fb14a6df6b7f9a393727ec9cff49d1df0db', to: '9a6dd3dda868e090b8ed19768c42507b70c03fef')
  diff =  Danger::FileList.new(repo.diff.select { |diff| diff.type == 'deleted' }.map(&:path))
  puts diff

This prints our deleted files correctly:
AirHelp/Classes/Account/View/AccounterVersionFooterView.swift

So ultimately the question is whether someone has any clue what I'm doing wrong? This looks like a configuration issue as I'm getting correct data when using Danger internals directly.
I've also checked out previous versions of Danger with similar results (all up till 0.7.3).

Okay, I can reproduce using ./bin/danger local --use-merged-pr=283 on Danger repo. Fix incoming soon.

I understand this only happens while running in local mode, right?

I'm seeing this issue both on Jenkins and locally.

Could you check if this #305 fixes your problem?

Definitely better! I also see insertions and deletions are now correctly calculated 👍
+----------------------+--------------------------------------------------------------------------------------------------+
|                                                      Danger v0.8.4                                                      |
|                                                     DSL Attributes                                                      |
+----------------------+--------------------------------------------------------------------------------------------------+
| status_report        |                                                                                |
| violation_report     |                                                                                |
| added_files          | AirHelp/Classes/Account/AccountViewControllerSpec.swift                                          |
|                      | AirHelp/Classes/Account/View/AccountTableViewCell.xib                                            |
|                      | AirHelp/Classes/Account/View/AccountVersionFooterView.swift                                      |
|                      | AirHelp/Classes/Generic/Table View Cell Registration/NibLoadable.swift                           |
|                      | AirHelp/Classes/Generic/Table View Cell Registration/ReusableView.swift                          |
|                      | AirHelp/Classes/Generic/Table View Cell Registration/TableViewCellRegistration.swift             |
|                      |<EMAIL_ADDRESS>                     |
|                      | AirHelpSpecs/Test Helpers/AirHelpSpecsHelper.swift                                               |
| deleted_files        | AirHelp/Classes/Account/View/AccounterVersionFooterView.swift                                    |
| lines_of_code        | 1041                                                                                |
| deletions            | 292                                                                                |
| insertions           | 749                                                                                |
| commits              | 9a6dd3dda868e090b8ed19768c42507b70c03fef                                                         |
| pr_title             | Grouped account view                                                                             |
| pr_labels            | []                                                                                |
| branch_for_base      | develop                                                                                |
| branch_for_head      | feature/grouped-account-view                                                                     |
| base_commit          | 40008fb14a6df6b7f9a393727ec9cff49d1df0db                                                         |
| head_commit          | 9a6dd3dda868e090b8ed19768c42507b70c03fef                                                         |
| pr_json              | [Skipped]                                                                                |
| api                  | Octokit::Client                                                                                |
| ---                  | ---                                                                                |
| SCM                  | Danger::GitRepo                                                                                |
| Source               | Danger::CISource::LocalGitRepo                                                                   |
| Requests             | Danger::RequestSources::GitHub                                                                   |
+----------------------+--------------------------------------------------------------------------------------------------+

There's only one concern (not sure whether this should be the default behavior here) - I'm seeing the deleted file in both deleted and modified files.
I've checked previous version (aka 0.8.4, current one) and this was the case before as well there - added and deleted files pop up in modified files as well.

Yeah, I saw that too but I focused on the issue at hand first. Will fix that later.

Awesome, thanks for helping out! ❤ You can close this issue once #305 gets in.


Comment out TextDxfDocument error in WriteSplineBoundaryHatch

It seems that AddEntity for sub entities of a parent entity are redundant.

The TestDxfDocument project is just a place holder, do with it what you like. It might include old samples that got broken with new updates. For small fixes just open an issue, tThere is no need for a Pull Request.


not available in Europe

when will be available in Europe countries?

Hi @akardas16 , thanks for your patience. Support is coming soon, but we don't have an ETA just yet.


IdentityAndConsentManagement meeting notes 2023-10-18

What type of PR is this?

documentation

What this PR does / why we need it:
MoM of the call held in 2023-10-18
Which issue(s) this PR fixes:
None.

Guys, do you have any comments on the meeting notes? If not, could you give your approval to merge the PR?
(CC @rartych)

@rartych kind reminder :P

LGTM
Should we change the date of the next call in this MoM?

Let's merge it as is for simplicity. At that point in time was not known what was going to happen with Nov 1st meeting. The meeting has been cancelled already and properly communicated to everyone.


⚠ NCAA has degraded performance

In dfb2906, NCAA (https://www.ncaa.com) experienced degraded performance:

HTTP code: 200
Response time: 781 ms

Resolved: NCAA performance has improved in 65d39f4.


File descriptor leaking issue

Expected behavior
We expected the fd will be released after netty channel is closed.
Actual behavior
fd usage keep increasing.  There are lots of closed sockets.
$ ss -s
Total: 26574
TCP:   26297 (estab 5645, closed 20587, orphaned 0, timewait 8)

Netty version
4.1
JVM version (e.g. java -version)
jdk 11
OS version (e.g. uname -a)
linux

Can you add more detail? What is the app doing; how do you recreate this issue? What specific Netty version are you using, or have tried?


TypeError: Cannot read property '$modelValue' of undefined

Hello, I am not sure if this is the right place to post this, but I have an issue that's driving me crazy.
I am just trying to match two fields for password, and once I start typing into the fields I get the following error: 'TypeError: Cannot read property '$modelValue' of undefined'
I am using webpack and angular 1.6.1, and the latest formly lib and bootstrap. Formly works great on every other page I have created without issue. This is only happening when I am trying to match two fields.
I did an exact copy paste of the examples code (minus the script includes as I have bundled them into the final js file with webpack), and this error keeps coming up in the console.
Can anyone lend any idea as to what the issue may be? If you need more information ill be happy to post more here.
Thank you in advance.

I was able to resolve this thanks to the example that was posted in #533
For the life of me I couldnt get it to work with the documentations example. But using @yahyaKacem 's example that he posted I was able to get it working without issue.
Sorry for polluting the issues here on GH.
Thanks you for this wonderful plugin.


Graphman docs link broken

Small unrelated notes, the link here to the graphman documentation and here does not have the .md extension, and therefore is broken, and is also shown as markdown instead of being parsed as an anchor tag
From @YassinEldeeb

It looks like the markdown links are correctly defined, but probably the client/server side parser has an issue, as it didn’t parse it correctly and parsed a few links without the .md extension, even though, they were specified.
https://github.com/graphprotocol/docs/blob/a52086f2e594d72be6029ff2aec1532cbd91ddc0/website/pages/en/operating-graph-node.mdx?plain=1#L275

@saihaj @YassinEldeeb It was fixed in latest nextra by @enisdenjo, but since these docs is deployed once per month we need to wait next deployment :)

@B2o5T which docs deploys once per month? (if you are referring to graphprotocol/docs, we can release more frequently as required 😄 )


Add multi-station weather querying

If one of the meteorological elements is not available from our preferred station, get it from the next one.
I.e. instead of
SELECT DISTINCT ON (timestamp)
    temperature,
    ...

do
SELECT
    timestamp,
    FIRST(temperature),
    ...
GROUP BY timestamp

This implies that we cannot return source information (station_id, location, etc.), since a single timestamp could be comprised of elements from multiple sources.


Ionide FAKE creates new output window on each use

I'm using the Ionide FAKE build integration.  On each use, a new FAKE output window is created (see below).

Is this a feature?  I would expect that subsequent usages would simply log the text to the existing output window.
I am using VS Code 1.1.1 and Ionide FAKE 1.0.11.
Thanks!

Fixed in 1.1.0