31 oauth support

Oauth support.

Tests are failing; commits will eventually need to be squashed.
Also, were you planning on adding any unit tests to this code?

We're having a think about the best way to test it, but yes tests are on the way.

This is totally awesome @jbu! I've given some detailed feedback on specific bits above, but my overall impression is that this is great. I love it. Some higher level feedback:

I think these changes are percolating through already, but I might as well say them anyway. I think we should keep all the config in our main config file, and OIDC should be optional.
The index landing page shouldn't be available until after we've logged in. I guess from a UX perspective, the best thing to do would be to redirect to the login page if auth is enabled, and redirect back to the landing page then. We can even write the session key to the landing page, where CLI clients can copy it.
It would be nice to know where the various identifiers and functions are coming from (e.g. rndstr, session, etc), which is why I'm nagging about the imports. When coming in raw, I think it helps to understand how things are structured when it's clear which library is providing various bits of functionality.
I'm getting slightly nervous about the hard-coded strings... it's difficult to know if we're increasing readability by having lots of string constants lying around, but I worry about what would happen (security wise) if one of these ever got accidentally changed. I'm not saying definitely change things, I'm just sort of expressing a general feeling of unease...

Hi @jeromekelleher. This now has tests and so forth. Anything else to do before merging?

Thanks for the updates @jbu, it's coming together nicely. I'm finding the configuration a bit brittle at the moment though, and I think we need a bit more work to make sure things work smoothly outside of the testing environment. I'm having trouble running the server at all on my local setup here, so it would be good to sort out these issues. One way to do this would to try reproducing the demo with and without authentication, with local and remote clients.

One thing to watch out for when going through the demo is that the structure of the data dir has changed. The easiest thing to do is to update your ga4gh-example directory to make a new directory, say, dataset1, and then moving reads and variants in there.

Hi, yes i've discovered the change in the dir structure :)

This is starting to feel more reasonable. The configuration mechanisms could be argued with, but it might we worth waiting until any external session support or move to cheerypy is decided before fixing it.

Thanks @jbu. I'm still having some issues:

When I run without auth, I seem to have URL mapping problems and cannot run any queries.
When I run python client_dev.py -vv datasets-search https://localhost:8000 I get a JSON cannot be decoded error. (Is the 302 using the standard error mechanisms on the server?)
When I've logged in, I'm getting URL mapping problems.

I can't really evaluate the code until I can run some queries; can you reproduce these issues?

Also getting come test spam when on testOidcBadLoginKey when I run nosetests -vs.

I can't reproduce
try python client_dev.py --key <key from browser> -vv datasets-search https://localhost:8000/current
not yet reproduced. Will keep looking

For (1), I run
python server_dev.py

on the server and
python client_dev.py -vv variants-search http://localhost:8000/ 2>&1 | less -S

on the client. Both are on the same machine. I would imagine that (3) is the same issue. I'm having the same problem on two different linux boxes.
For (2), --key works properly, but we should return the proper error message when it's not used.

That client command
python client_dev.py -vv variants-search http://localhost:8000/ 2>&1 | less -S
should have a protocol version on the url (so http://localhost:8000/current would work)

@jeromekelleher what sort of proper error messages are you thinking of? At the moment any errors the client sees are just returned as exceptions.

One thing that's a bit of a gotcha, (and I need to document somewhere) is that when using OIDC you need to take care with hostnames. In particular, if you don't configure something, the server starts to use whatever sockets.gethostname() returns, which is not 'localhost'. This is important when you use the browser to get the session key

I've cleaned up that test spam. It involved removing some debug prints from exception handlers in server_test and client. I'm happy with this as they're not used anyway, and it's the wrong place for them.

Doh! Sorry about that @jbu, major idiocy on my part.
The issue with not specifying a key is we get the following at the client side:
ValueError: No JSON object could be decoded

This means we're not sending back a JSON document on error (which we're supposed to). I think this just means putting an error handler for 302, and making sure it operates in the same way as the rest of the error conditions.
I'll review this again tomorrow morning, and give any final feedback then.

Also, it would be good to document these hostname gotchas in the development page. This is pretty tricky when you're not used to it.

Authentication errors are returning a json document, with a 403 response code (which is then thrown as an exception by the client code). I'm getting
'''
mrsmall:ga4gh-server james$ python client_dev.py --key TtjXPFdg04HUeclSDN6BpE1  datasets-search https://localhost:8000/current
ERROR:ga4gh.client:403 {"errorCode":<PHONE_NUMBER>, "message": "Not authenticated. Use the key on the server index page."}
Traceback (most recent call last):
File "client_dev.py", line 7, in
ga4gh.cli.client_main()
[...]
File "/Users/james/src/ga4gh-server/ga4gh/client.py", line 93, in _checkStatus
response.url, response.status_code))
Exception: Url https://localhost:8000/current/datasets/search?key=TtjXPFdg04HUeclSDN6BpE1 had status_code 403
'''

You get a different response if you leave out the --key option:
$ python client_dev.py variants-search https://localhost:8000/current
Traceback (most recent call last):
  File "client_dev.py", line 7, in <module>
    ga4gh.cli.client_main()
  File "/home/jk/work/github/server/ga4gh/cli.py", line 867, in client_main
    runner = args.runner(args)
  File "/home/jk/work/github/server/ga4gh/cli.py", line 375, in __init__
    datasetIds = [dataset.id for dataset in datasetsResponse]
  File "/home/jk/work/github/server/ga4gh/client.py", line 145, in runSearchRequest
    'POST', fullUrl, protocolResponseClass, httpData=data)
  File "/home/jk/work/github/server/ga4gh/client.py", line 130, in _doRequest
    return self._deserializeResponse(response, protocolResponseClass)
  File "/home/jk/work/github/server/ga4gh/client.py", line 103, in _deserializeResponse
    jsonResponseString)
  File "/home/jk/work/github/server/ga4gh/protocol.py", line 191, in fromJsonString
    jsonDict = json.loads(jsonStr)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

ahh. got it

Will have to thing about that one. The problem is that if you're using the browser, we want to redirect to the OP. If you're on the command line, we want to return a 403. How to distinguish?

We could just set a default key ("This is not a valid key!") for the CLI?

I've set this up over the network, and I'm having some issues. After I point my browser at the server (machine:8000), I get redirected to the OIC provider (machine:9010) and I log in successfully. However, when I get redirected back to the server landing page, I get
{"errorCode":<PHONE_NUMBER>, "message": "Not authenticated. Use the key on the server index page."}

Then, if I try reloading the server index page I get a server internal error, and the following traceback:
--------------------------------------------------------------------------------
ERROR in app [/home/jk/.local/lib/python2.7/site-packages/flask/app.py:1423]:
Exception on /oauth2callback [GET]
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jk/.local/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/jk/.local/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/jk/work/github/server/ga4gh/frontend.py", line 691, in oidcCallback
    request_args=args)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oic/__init__.py", line 588, in do_access_token_request
    authn_method, **kwargs)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oauth2/__init__.py", line 615, in do_access_token_request
    http_args=http_args, **kwargs)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oauth2/__init__.py", line 549, in request_and_return
    **kwargs)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oauth2/__init__.py", line 517, in parse_request_response
    state, **kwargs)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oauth2/__init__.py", line 460, in parse_response
    raise err
TypeError: __str__ returned non-string (type Error)
<IP_ADDRESS> - - [01/Jul/2015 10:02:14] "GET /oauth2callback?scope=openid+profile&state=fhuAGeyDLulAh6gp5zRcIiVg&code=UXFCS6RuhZEZDPeXVPj3TNhjoYHoTXH6YcMEYoXVc9SG%2B8XQzz6rDSK5biIEBtNwfiiX43ViiaBfCM2EYqKU6fpFkPzTjLKY%2BZWArq%2F8OAw%3D HTTP/1.1" 500 -

@jeromekelleher how's the demo for you now?

In the tests a lot of these lines are printed out:
/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py:734: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html

These should be silenced to eliminate the spam in the test run output.

Whenever I run the tests, this file seems to be marked as modified in git:
oidc-provider/simple_op/src/provider/server/static/jwks.json

Please change the tests so that the files that git tracks are left unmodified after a test run.

That should all be cleaned up now.

Server startup produces spam output when configured with LocalOidConfig; please fix:
$ python server_dev.py -c LocalOidConfig
/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py:734: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)
... more spam ...

I'm still having trouble when I run this across the network @jbu:
--------------------------------------------------------------------------------
ERROR in app [/home/jk/.local/lib/python2.7/site-packages/flask/app.py:1423]:
Exception on /oauth2callback [GET]
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jk/.local/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/jk/.local/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/jk/work/github/server/ga4gh/frontend.py", line 693, in oidcCallback
    request_args=args)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oic/__init__.py", line 588, in do_access_token_request
    authn_method, **kwargs)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oauth2/__init__.py", line 615, in do_access_token_request
    http_args=http_args, **kwargs)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oauth2/__init__.py", line 549, in request_and_return
    **kwargs)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oauth2/__init__.py", line 517, in parse_request_response
    state, **kwargs)
  File "/home/jk/.local/lib/python2.7/site-packages/oic/oauth2/__init__.py", line 460, in parse_response
    raise err
TypeError: __str__ returned non-string (type Error)
<IP_ADDRESS> - - [07/Jul/2015 09:37:09] "GET /oauth2callback?scope=openid+profile&state=UOvIR3Q8NdcToiDLky3VI1t2&code=Xqr%2BO5yyNwt8Bmn6RR7dE0NogtHMRFOJhtA3azQO4jsfC6WbSbAdRqCdE7r1IBq4t4GOcybV7KiyE6u8JnrdFO2A7q0sLVLw3Q7yRAwUnpc%3D HTTP/1.1" 500 -

I'm happy to provide more details if you're having trouble reproducing this.
I agree with the points that @dcolligan has made above also.

@jeromekelleher yes details would help debug it. What are the actual machine names and config files?

Actually, I've given the main details above in a previous comment. I can send on the exact config if you like, but there I've only changed a couple of host names and ports.

@jeromekelleher I tried a multi-machine setup, and found a problem with setting the hostname of the oidc provider (run.sh changed) and a problem with validating ssl certificates (now turned off when testing). But I couldn't get precisely the same stack trace as you. But give it another go - the new changes might have helped.

I'm still having the same problem @jbu. However, this review process is getting extremely unwieldy, so I suggest we resolve any major outstanding issues, and merge what we have. Contentious issues should be marked with comments in the source, and added as an issue to follow up on. For things like removing try blocks, I think these should be replaced. Things like test-spam in the output can be dealt with in issues and follow-up PRs. I'll make another pass, and highlight any points I think need to be either resolved or followed up.

I've added a few more comments on how we can resolve any remaining problems. I think after that we should merge and move on with (hopefully) smaller issues and PRs to deal with. @dcolligan, do you agree with this way of moving forward?

@jeromekelleher Last comments taken into account and pushed (as far as I can work out). Perhaps merge now?

OK, I'm +1 to merge this much. Let's wait for @dcolligan's final word, and merge if he's happy to proceed.

Sure, let's do it +1

Excellent! OK, can we follow up with issues for the remaining issues please?

I've figured out what the problem I was having above was too: I was using an FQDN in rather then the result of socket.gethostname(). Works great now!


Calling a modal inside the modal

Hi,
I have this modal and I want to call another modal within this modal. When I tried to call the child modal using
this.modalService.toggle( {show:true , id: ''childmodal'}) it will just close the parent modal and the child modal did not display as well.
Am I doing something wrong? I have been calling modal from a parent component and it displays. Only calling a modal from a modal did not work for me. Please advise.  Thank you

Do you have any suggestion what alternative way or to use for this scenario @xidedix ?


Shared nested directories

If the shared directory is nested it is not working because it is trying to move nested path to nested path with mv

The cases seems to be a lot and the solution is complicated. This issue will be postponed for now.


showEventOrigin not working

Hi,
this is my calendar config:
  - type: custom:calendar-card     title: "Kalender"     entities:     - calendar.cal_a     - calendar.cal_b     timeFormat: HH:mm     showEventOrigin: true     showLocation: true     highlightToday: true     hidePastEvents: true
I would expect to see the calendar name for each event, but it does not show up.
Data source is a private Nextcloud instance.
version 3.103.1

The data structure might be different since it's coming from a Nextcloud instance. Can you tell me the event object property for the event origin? Or paste a whole event object here stripping any personal info you want

How do I get the event object?
Sorry for that question. I am new to HA, my system is running for about a week.

ok doesnt look like events give back origin. what does the calendar editor show? it should fall back to the sensor name

view:
    - type: custom:calendar-card
      title: "Kalender"
      entities:
      - calendar.cal_1
      - calendar.cal_2
      timeFormat: HH:mm
      showEventOrigin: true
      showLocation: true
      highlightToday: true
      hidePastEvents: true
      eventsLimit: 8

calendar:
calendar:
  - platform: caldav
    username: !secret caldav_username
    password: !secret caldav_password
    url: !secret caldav_url

Entity: calendar.cal_1
friendly_name: Cal 1
Entity: calendar.cal_2
friendly_name: Cal 2
I think it would be the best solution to show the friendly name


Initial macos support, a couple of fixes

I'm sure it needs fontconfig, or should provide some font with the package.  And I didn't like tons of .o in git status :D
brew install glm fftw to get all deps btw

Oh, cool! You rock! I'll test this out on my mac during lunch today.


Get BLOB image and apply base64_encode before encoding it to JSON

I have some images saved into BLOB. I can retrieve the images like this:
$datas = $database->select("images", [
    "title",
	"image"
], [
	"id[>=]" => 1
]);

and display them with PHP like this:
echo '<img src="data:image/jpeg;base64,'.base64_encode($data['image']).'"/>';
Now I would like to send the result query via Ajax in JSON format and then display the image using Javascript. The following code works fine for text fields but not for images saved into BLOB:
$a = $_GET['jsoncallback'] . '(' . json_encode($datas) . ');';
echo $a;

because at the images is not applied base64_encode first .
How do I add base64_encode to image before sending it to json_encode using Medoo?

You can encode and decode the BLOB image content yourself for saving and fetching data for database.
BTW, I think it is not a good idea to save image content into database. Using file system or third-party image storage provider is better.

Thank for the fast answer. Encoding the image before adding it to a BLOB worked fine:
$blob = file_get_contents("Image00001.jpg");

$last_user_id = $database->insert("images", [
    "image" => base64_encode($blob_01)
]);

Read the image from dB:
$datas = $database->select("images", [
    "image"
], [
    "id[>=]" => 1
]);

$a = $_GET['jsoncallback'] . '(' . json_encode($datas) . ');';

echo to Ajax:
echo $a;


Listing at drop page shows default picture

Is it possible to show the currently minted item as on the previous page of the dialogue?
I've seen it, and on the listing, I see the default.

seems to be working well here:

#9709
https://deploy-preview-9709--koda-canary.netlify.app/


Bump package.json version

As suggested by @gunar on twitter, this would see Renovate bump the version in package.json.

I suggest we'd call this "bumpVersion" and make it boolean (false by default). We would do this manually rather than actually running "npm version patch".

Perhaps "bumpVersion" and default to "none" but allow "patch" or "minor" as values.

Waiting on #1016, otherwise it's hard to make sure we don't accidentally bump it twice if branch is updated with second commit.

@rarkins I'd like to quickly ask about bumpVersion. It seems like the setting "bumpVersion": "patch" is ignored if the major version is 0, but works for numbers greater than 0. Is this an intended behaviour?

Not intended. Could you raise a bug report?

@rarkins Apparently the issue resolved all of a sudden, but I stumbled upon another issue I will raise a bug report for when I am able to recreate it.


Vickel: Watch stop[\W_]*+Elbit

Vickel requests the watch of the watch_keyword stop[\W_]*+Elbit. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

stop[\W_]*+Elbit has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


Thank you so much! Additional information:

Works like a charm, but you might want to link to the entire command line reference: https://docs.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio
Also, do link to the workload reference for Visual Studio 2017 editions, but it would be helpful to mention that this guide uses the workload categories, not the individual workload components.
Thanks again!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b2a7f87-7685-2618-9be0-f2286662342f
Version Independent ID: 626a45d3-732a-6992-9f0c-bf06bc87fe1c
Content: Install on low bandwidth or unreliable network environments - Visual Studio
Content Source: docs/install/install-vs-inconsistent-quality-network.md
Product: visual-studio-dev15
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@ciphernemo We appreciate your feedback; thanks! This is in the queue to be addressed.


Add TMC registration docs to TCE documentation

Starting in v0.11.0 of TCE, TMC registration of management clusters now works.
This means we need documentation on:

Registering a TMC management cluster.
Creating (life cycle managing LCMing) a workload cluster from that management cluster
Attaching a workload cluster to TMC (not via a registered management cluster)

TODO(joshrosso): figure out if there are more requirements.

Putting this at-risk since we became aware of the requirement days before release.

Talked to @amandakatona this morning and appears our only requirement for initial work is to ensure our docs say that TMC can be used to both register to (mgmt) and attach (wrkld) for TCE v0.11.0.

closing this issue as won't resolve as https://github.com/vmware-tanzu/community-edition/issues/3617 was updated.


CB-6514 AWS Datalake deployment on mow-dev is failing with HV000028 U…

@bergerdenes I saw you put the annotation on this field, but in case of sdx internal, name comes from pathparam, people usually don't put in into the input json but validation is on it within stackv4request, thus lot of people experienced issue with sdx internal. Since I do not want to make people fill this info twice, I removed the annotation for now.

cloudbreak will validate the stackrequest anyway


Remove superfluous bracketing

Turn ((((foo())))) into foo() and {{{{foo()}}}} into {foo()}.

Can this be closed given #2519?

Looks like it.


Update organizationWhitelist.txt

Is this your University?

Yes, but I used my gmail to register github.
On Sun, Nov 13, 2016, 11:20 PM Michael Truell<EMAIL_ADDRESS>wrote:

Is this your University?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HaliteChallenge/Halite/pull/202#issuecomment-260192382,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABV9j7Y8V19ftOhljE4OTMhwyWP0SXblks5q9yrVgaJpZM4Kwo3l
.

I'll tag you as a member of your uni.

OK. Thanks~
On Sun, Nov 13, 2016, 11:42 PM Michael Truell<EMAIL_ADDRESS>wrote:

I'll tag you as a member of your uni.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HaliteChallenge/Halite/pull/202#issuecomment-260193541,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABV9j3bxJS7vXiWCp3okJZ-aYFiQB-Mkks5q9y_agaJpZM4Kwo3l
.


App crashes when having server folders Asha 303

Exactly as title says, the app crashes if I have a server folder in my server list on other devices.

I have server folders on both of my accounts, and many others probably do too. I've had no issues with those. If the app is crashing, there may be a different problem. Version 4.0 is releasing in a few days, so you can try that out once it's available.


azure read: connection reset by peer

Hi,
I know there are a lot of azure related bugs in here but none of them gives a solution.
I'm trying to connect to my auzre db:
select @@Version
Microsoft SQL Azure (RTM) - 12.0.2000.8   Mar 21 2017 02:11:40   Copyright (C) 2016 Microsoft Corporation. All rights reserved.

with connection string
Server=*;Port=1433;User Id=*@8;Password=*;Encrypt=True;TrustServerCertificate=True;log=51;connection timeout=90;dial timeout=60;keepAlive=60;"

And all I see in the log is:
2017-05-28T21:44:00Z E! Error in plugin [inputs.sqlserver]: read tcp <IP_ADDRESS>:59260-><ip>:11210: read: connection reset by peer
2017-05-28T21:44:00Z E! Error in plugin [inputs.sqlserver]: driver: bad connection

The azure firewall is configured properly and the credentials are ok. When I try to use Encrypt=False or Encrypt=disable it failes misserably as well...
Can you please help?

I'm assuming same parameters work on a different client. Your Reed port
looks odd. Can you specify the port on the host colon separated.
On Sun, May 28, 2017, 14:51 regev<EMAIL_ADDRESS>wrote:

Hi,
I know there are a lot of azure related bugs in here but none of them
gives a solution.
I'm trying to connect to my auzre db:
select @@Version
Microsoft SQL Azure (RTM) - 12.0.2000.8   Mar 21 2017 02:11:40   Copyright (C) 2016 Microsoft Corporation. All rights reserved.
with connection string
Server=;Port=1433;User Id=@8;Password=*;Encrypt=True;TrustServerCertificate=True;log=51;connection timeout=90;dial timeout=60;keepAlive=60;"
And all I see in the log is:
2017-05-28T21:44:00Z E! Error in plugin [inputs.sqlserver]: read tcp <IP_ADDRESS>:59260->:11210: read: connection reset by peer
2017-05-28T21:44:00Z E! Error in plugin [inputs.sqlserver]: driver: bad connection
The azure firewall is configured properly and the credentials are ok. When
I try to use Encrypt=False or Encrypt=disable it failes misserably as
well...
Can you please help?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/denisenkom/go-mssqldb/issues/266, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuFsXd7sHvbNxZhpv7WqEQG9uwcdFyBks5r-exEgaJpZM4NoxXA
.

Actually, running this connection string directly on your module works fine. Somehow the issue is with the telegraf sqlserver input. I opened a bug there...
https://github.com/influxdata/telegraf/issues/2861


Converstion to Full TypeScript

An issue to track progress and notes on converting all the remaining JS files to TypeScript.

Document the list of things to convert
Document the chunks that are reasonable to convert in
Document a general estimate of time to convert

When done this would trigger the ability to close #25 by just building the .d.ts files and including them in the package.

parquet typescriptification
things to convert

/

esbuild-* (2)

optional, but good to make everything consistently in ts

examples/ (2)
lib/

compression (1)
codec/ (3)
types/ (2)

can improve the ParquetTypeKit type and remove all the anys

reader.js (3)
writer.js (3)
everything else (2)

chunks
required, in order

independent files

/lib/bufferReader
/lib/codec
/lib/compression
/lib/types

utility

/lib/util
/lib/schema
/lib/shred
/lib/compression

reader/writer

/lib/reader
/lib/writer

optional

/esbuild-*
/examples/

general estimate
about 3 days for the meat of the work in lib/ +/- 2 days

Added those chunks as issues at to a Milestone: https://github.com/LibertyDSNP/parquetjs/milestone/1


Refactor type provenance tracking and error reporting

This PR deeply cleans up the way type provenances are recorded and used for error reporting. This took a lot more effort to accomplish than I originally thought.
Now the type provenance chain construction is more principled, simpler, and importantly no longer mixes the provenances of type flows at different levels. For instance, before this PR we used to have provenances chains like:
//│ ╟── expression of type `false` does not match type `int`
//│ ║  l.+1: 	f { prop: false }
//│ ║        	          ^^^^^
//│ ╟── but it flows into record with expected type `{prop: ?a}`
//│ ║  l.+1: 	f { prop: false }
//│ ║        	  ^^^^^^^^^^^^^^^

This approach turns out (from long experience, notably on another project) to be unmaintainable and inextricably buggy. Now we do not mix flows in this way – every part of a provenance chain is supposed to have the same type (or at most one actual and one expected type, in case of a mismatch).
The tracking is currently still only for first-order provenances.
Investigating higher-order ones is left for future work (Cc: @Elrouille).

I've reviewed all the tests diffs. They seem correct to me. The only thing I'm not sure about is the result of the :stats option -I'm not saying it's incorrect, just that I could not check whether it was.

No worries, :stats simply shows the number of constraining calls just to make sure it doesn't go crazy. It's normal if it changes a little after making changes to constraint solving.


Configure JAX-RS resources with an array of classe

Enhancement proposition for JAX-RS resources configuration, instead of :
{
  "controllers": {
    "/api/my-resource": "com.mycompany.MyResource"
  }
}

and ...
@Path("/")
public class MyResource {
    @GET
    @Produces(APPLICATION_JSON)
    public String sayHello() {
        return "Hello World!";
    }
}

We could use an array of resource classes in the config file, and let the @Path annotation handle the endpoint :
{
  "rest-resources": [
    "com.mycompany.MyResource"
  ]
}

and ...
@Path("/api/my-resource")
public class MyResource {
    @GET
    @Produces(APPLICATION_JSON)
    public String sayHello() {
        return "Hello World!";
    }
}

Improvement. We could provide a contextual route to avoid conflicts with the other routes.
{
    "rest-resources": {
        "/api-res-type1":  [
            "com.mycompany.MyResource1", "com.mycompany.MyResource12"
         ]
    }
}```


erase

https://en.cppreference.com/w/cpp/container/vector/erase

use std::move to move the range to the left https://en.cppreference.com/w/cpp/algorithm/move


Double encoded problem fix

Hi @ptrepka! Thanks for you pull request! It took my attention to that issue, and finally I found time to check it out. Indeed, you're right: there is an issue with double escaping all query parameters. Since all requests are affected by this issue, I decided to make a bigger fix - it was already merged in #372. Sorry, I will close your pull request. Also, I'm going to release the new version as soon as possible 💪


Fix typo in metric name

@xichen2020 @robskillington

Coverage increased (+0.1%) to 91.14% when pulling a0ca428100143b56a4005b768d0f6a8727200fb2 on chao-typo into 97a2887cbba99d291ff81c649872a70e27589cef on master.


Allow hashtag-in-tag

Ref https://github.com/olafurpg/sbt-ci-release/issues/102#issuecomment-586599859
steps
$ git tag v1.4.0-M2#something
$ sbt
....
sbt:IO Root> version
[info] io / version
[info] 	1.4.0-M2#something
[info] version
[info] 	1.4.0-M2#something

problem
version is set to 1.4.0-M2#something.
expectation
I'd like the version to be set to 1.4.0-M2 removing # and subsequent letters.

Here's how you can post-process the string, to customize it: https://github.com/dwijnand/sbt-dynver#custom-version-string.


Make phobos.lib include std.experimental.logger

Note this is NOT tested on Win64 because I have no such environment.

what was the problem? from the diff it looked like you just moved the lines!

did not work for win64

@MartinNowak somehow the logger was not included in the win32 and win64 build.
this is strange as win32/64 failed me regularly before I rewrote FileLogger.
Anyway, this and #3024 should fix that. IMO this needs to go into 2.067.
Sorry for the inconvenience.

looking at different autotester output from phobos testing, I got it.

So what was fixed here?

all logger source where not include in phobos.lib and the unittest
this fixes it for win32


parseChartKeys_fig fails for Scatter3d plot

parseChartKeys_fig compares chart['type'].title()  with all members of go to get the trace type. However, for a 3d scatter:
chart['type'].title() is Scatter3D (capital D) and getmembers(go, isclass)[51][0] is Scatter3d (lower case d), so it cannot find the plot type.
Suggest
  if i.lower() == chart['type'].lower():             realChart = y

Thanks for catching this, I typically dont use 3d charts. :)

This is fixed in https://github.com/BSd3v/dash-chart-editor/commit/ace788d9e6bd51dcacf10ac5a37a03a0b6d2b3ed


persist & show container_group 'phase', 'message' and 'reason'

persist & show container_group 'phase'

fyi @simon3z @abonas
@miq-bot add_label ui, providers/containers, enhancement

@abonas @simon3z Please review

The phase field is part of a status section with more details (for example for "Failed" it has a message, a reason, etc). I see they are not persisted - is this the intended design on purpose? @simon3z

Since a new field is collected in this PR, please check if this shouldn't be added to the refresher tests (VCR)

@moolitayer please add also reason and message.

@moolitayer minor comments

@simon3z, this looks super straight forward ... once you give the thumbs up, I'll merge.

LGTM :+1: @blomquisg @chessbyte ready for merge


How can i Download file to local directly from Dropbox API

$file = $dropbox->download("/example.txt");
$contents = $file->getContents();
$metadata = $file->getMetadata();
file_put_contents(__DIR__ . "/example.txt", $contents);

From this code this "example.txt" file downloaded in my project directory. But i want to download this "example.txt" file with my browser into browser download folder.

Not an issue, your question is PHP related. You should look up the first example here:
http://php.net/manual/en/function.readfile.php


Excellent ...

... initiative !

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df99ad6c-a845-e4a3-e1d0-bb2b2ef421ad
Version Independent ID: 0312f80c-d7f9-20f4-46b1-10550f2ac13d
Content: Migrate user licenses users to group-based licensing in Azure Active Directory
Content Source: articles/active-directory/users-groups-roles/licensing-groups-migrate-users.md
Service: active-directory
GitHub Login: @curtand
Microsoft Alias: curtand

@marc-be Thanks for the feedback.

Hi
How can I remove Direct licensing from a set of users (as a test) using Powershell script before I do it for the whole enterprise?
Thanks, M

@marc-be
Thanks for the kudos!!! You're the first one I have received through GitHub.
Hi  @Maelito77
Contact<EMAIL_ADDRESS>@SaurabhSharma-MSFT
#please-close


Fix code scanning alert - Clear text storage of sensitive information

Tracking issue for:

[ ] https://github.com/openpredictionmarkets/socialpredict/security/code-scanning/1

This issue can be closed because CodeQL was flagging an issue with a flag, and we have bigger issues to tackle right now.


[Consensus] Peer presented nonconsecutive headers

[2018-11-28 20:33:39.9782 5] INFO: Stratis.Bitcoin.Connection.ConnectionManagerBehavior+<OnStateChangedAsync>d__15.MoveNext Peer '[::ffff:<IP_ADDRESS>]:16178' offline, reason: 'The peer was banned, reason: Peer presented nonconsecutive headers.'.

Related to https://github.com/stratisproject/StratisBitcoinFullNode/pull/2887

Fixed


Add prefix queries to es5,es6 using STARTS_WITH operator

Allow passing Prefix Queries e.g. workflowType STARTS_WITH "add".

Pull Request Test Coverage Report for Build 3884

14 of 20 (70.0%)  changed or added relevant lines in 3 files are covered.
16 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 68.833%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

es5-persistence/src/main/java/com/netflix/conductor/dao/es5/index/query/parser/NameValue.java
0
2
0.0%

es5-persistence/src/main/java/com/netflix/conductor/elasticsearch/query/parser/ConstValue.java
2
6
33.33%

Files with Coverage Reduction
New Missed Lines
%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java
8
69.86%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java
8
55.79%

Totals

Change from base Build 3882:
-0.1%

Covered Lines:
11387

Relevant Lines:
16543

💛  - Coveralls


Unable to sync entire bazel project on macOS using dazel

Description of the issue. Please be specific.
The setup of the bazel project that I am working on does not support macOS so I am using dazel as a wrapper to execute it on linux in docker, which works fine from the command line. My bazel configuration in IntelliJ uses dazel to execute in linux in docker and looks like this:

Syncing individual targets in IntelliJ works, although slow - several minutes for a component. However, when I try to do a full project sync IntelliJ errors with the following stacktrace:

And trying again and again to sync just gives a "sync finished with errors" message and a Bazel Problems message of "Error: Deriving targets from project directories failed":

It should be noted that my colleagues who are using linux and bazel instead of the wrapper dazel are able to sync the entire project.
What's the simplest set of steps to reproduce this issue? Please provide an example project, if possible.
Use dazel as a wrapper for bazel in IntelliJ and do a full project sync. This results in the stacktrace shown above.
Version information
IdeaUltimate: 2022.2.3
Platform: Mac OS X 12.6
Bazel plugin: 2<IP_ADDRESS>.1-api-version-222
Bazel: 4.1.0

Dupe  of https://github.com/bazelbuild/intellij/issues/418

Dupe of #418

Yes possibly. But I don't see a suggested resolution on that issue. It looks like somehow the messages between docker and IntelliJ gets corrupted when syncing the entire project. However, it does not happen for sub-targets and individual targets.

@ittaiz I know that https://github.com/bazelbuild/intellij/issues/418 was reported long time ago, but if you can help us with more details about your findings and how you worked around it, that will be great.

We had our own dazel project back then (of course called wazel 😁) and we scraped it for other reasons so I don't remember the exact details.
Having said that I think the issue was about our wrapper printing additional bytes and that failed the strict proto parsing IJWB had/has.
To this day in our wrapper we have logic which makes sure to not print anything additional if the commands are with tool IJWB and are sync related.
@ZachiNachshon @joeyfwix any ideas given you know our existing wrapper a lot better than me now :)


Trouble with /private/var/root/.ssh/known_hosts when using ssh:// repos

When i run dusty up  with a repo defined as ssh://git@git.doman.com:7999/path/to/repo I get this error message ERROR: 'Error when fetching: fatal: Could not read from remote repository.' returned with exit code 2
However, if I go to /etc/dusty/repos/path/to/repo and run sudo git pull I get the The authenticity of host '[git.domain.com]:7999 ([xx.xx.xx.xx]:7999)' can't be established.... Are you sure you want to continue connecting (yes/no)? question. If I confirm the host is added to /private/var/root/.ssh/known_hosts and dusty up works just fine. Unfortunately the known_hosts entry disappears when I restart my mac. (and it's not exactly ideal that I have to go through this procedure every time I restart)
Can this be fixed any way, so that dusty's git pull uses my known_hosts file located in $HOME/.ssh/known_hosts?

We manually ensure that github.com is added to the root's known hosts during preflight. We don't do anything for private hosts currently, which we could consider doing.
We could possibly use another user's known hosts file, but we're doing the SSH operations as root, so I'm not sure how feasible that is.
It should be sufficient to do what you've done to manually add the domain as a known host for the root user. I have no clue what could be resetting your known hosts file on reboot. If you can diagnose that and stop it, manually adding the host should be permanent and you should stop having issues.

I could use this workaround for now as I'm testing Dusty, but it would be a bit of a hurdle if the rest of my team should start using it for their daily development workflow.
How about copying all entries for the ~/.ssh/known_hosts file of the user issuing the dusty command, or at least all entries containing .*git.* ?

This is probably a bit dodgy from a security perspective, but we could either try to convince Git to ignore the hosts check (not sure if that's possible with our Git driver) or just parse all hosts from the repo specs and make sure they're all added. I'd prefer a fully automatic solution.

I think the last option, where we parse hosts from specs and add them, is doable, but might end up necessitating some janky python code (running subprocesses that do ssh-keyscan, etc).  I'm doubtful that we can tell our git commands to ignore the hosts check.  I also agree that just copying known hosts from user to root is a little sketchy.

I guess this would be a problem for people using bitbucket etc. as well, so an automatic solution would have been nice :pray:

I think we've decided to have Dusty automatically add any hosts you specify in your specs to root's known_hosts.  This will probably get implemented next week

:grinning:

Turns out that url parsing in python is hard :(


Various clean up of bottomSheet-dev before merge into main

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
While the Bottom Commanding control isn't fully featured yet, the API is in a good place to unblock app teams for integration work. This PR includes various clean up for the bottomSheet-dev branch before it can be merged into main:

Updated Bottom Sheet demo controller to use table view.
Split up Bottom Sheet and Bottom Commanding into separate folders
Localizable string for the "More" button in the commanding bottom bar
Added xcfilelist with a reference to the "more" image asset for use in the subspec
Added .button trait to the "More" button
CocoaPods subspecs for BottomSheet and BottomCommanding

My plan is to merge bottomSheet-dev into main after this PR is merged. Future work will go in the main branch.
Verification
Sanity checks in the test app.
Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[x] VoiceOver and Keyboard Accessibility
[x] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[x] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

Is there any other setup I should do before this can live in main?

@harrieshin Is there a way to verify that the subspecs are well defined and aren't missing dependencies?

@harrieshin Is there a way to verify that the subspecs are well defined and aren't missing dependencies?

pod lib lint

@harrieshin Is there a way to verify that the subspecs are well defined and aren't missing dependencies?

pod lib lint

Thanks, verified.


Deployment of glm-4-9b-chat model fails with SentencePiece tokenizer error

Hello,
I am encountering an issue while trying to deploy the glm-4-9b-chat model using the scalellm repository. The deployment fails with an error related to the SentencePiece tokenizer. Below are the details of the error and the steps I have taken to troubleshoot it.
Error Message:
WARNING: Logging before InitGoogleLogging() is written to STDERR
I20240801 13:16:18.061883   140 llm_handler.cpp:171] Creating engine with devices: cuda:0
I20240801 13:16:18.070197   140 llm_engine.cpp:138] Initializing model from: /export/home/dengyingxu1/test_glm4_scalellm/models/glm-4-9b-chat
I20240801 13:16:18.070269   140 model_loader.cpp:184] Using SentencePiece tokenizer.
F20240801 13:16:18.083376   140 sentencepiece_tokenizer.cpp:36] Failed to load SentencePiece model from /export/home/dengyingxu1/test_glm4_scalellm/models/glm-4-9b-chat/tokenizer.model: Internal: /ScaleLLM/third_party/sentencepiece/sentencepiece_processor.cc(1102) [model_proto->ParseFromArray(serialized.data(), serialized.size())] , error Internal: /ScaleLLM/third_party/sentencepiece/sentencepiece_processor.cc(1102) [model_proto->ParseFromArray(serialized.data(), serialized.size())]
*** Check failure stack trace: ***
Aborted (core dumped)

Thank you for reporting the issue. I've tested it on my end and encountered the same error with 'THUDM/glm-4-9b-chat'. I strongly suspect that the 'tokenizer.model' file is corrupted, as it fails to load even with the 'sentencepiece' package using the following code snippet:
pip install sentencepiece
>>> import sentencepiece as spm
>>> s = spm.SentencePieceProcessor(model_file='your_path_to/tokenizer.model')

I would recommend you report the issue to the model owner. let me know if something i can help.

oops, sounds glm-4-9b-chat is using 'tiktoken', let me take a further look.

just land a diff to support glm4 using 'tiktoken' tokenizer. https://github.com/vectorch-ai/ScaleLLM/pull/292
The issue should be fixed in next release.

new release just out, please try it out.


User Subscription in a SAAS app

Hi Scott, kudos, very nice blog article, a missing :key: in multi tenant solution,

If we have SAAS app, where users from 2 different organizations are logging in, and I have the same app instance serving/running and the tenant is fixed during the new dbContext, isnt it fixed to only one tenant per app instance.
It was my impression IMHO, that in the same app instance could serve many organizations (SAAS); and, I would leverage/fetch the users tenantID from an extended Identity userID/principal from the session to save/preform data operations. Am I wrong here, can you help with a modification. I believe the key to making this work, would be letting the user select a Tenant(or Organization, during registration).
Lastly, I am using the identity with a roles approach, will you solution still work, I ask because you mentioned claims in your original blog. What would I need to make it work with roles?

thanks

You can change the tenant Id at any time during a dbcontext's lifetime. Also, you can have any number dbcontexts around at any time, so changing the tenant Id a dbcontext is currently serving can be avoided by simply newing up another dbcontext.
You can set the tenant Id anywhere you like, for example the user could select it or it could be hardcoded at the host level. It really is up to you and has no bearing on the underlying repositories.
A role is a type of claim, ASP.NET Identity just gives it its own table in the database, which confuses things, I know. But yes, it will work, no changes necessary

Hope that helps


Files disappearing and reappearing

Description
What steps will reproduce the problem?

Python files I am working on keep disappearing from my project directory.
Open a file and make a change to it.
Save the file.
The file will then periodicly disappear and then reappear.
An error is sent if I set the focus to that file Spyder says the file doesn't exist and if I really want to close it.  I select no and save it and if the file has reappeared, it will save fine, or it will promt me like it was a new file.

Thanks!

We have File Director and our ITS team is looking into that as well.  At this point, Spyder is the only application exhibiting this issue.

What does File Director do exactly?

We use It to backup our local drive to a network drive automatically.

Ok, please let us know if your IT team can fix this issue or not.

Hi @bdgrantham we are going to close this issue, please let us know if your IT team could fix this issue via a comment here.
Thanks for reporting!


CASMINST-3546 : csi pit validate for k8s has failed

Summary and Scope
Automation tweak to runs appropriately for pit/non pit case
_Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix? bug fix
Issues and Related PRs

Resolves CASMINST-3546
Change will also be needed in release/csm-1.2
Future work required by [issue id](issue link) NA
Documentation changes required in [issue id](issue link) NA
Merge with/before/after <insert PR URL here> NA

Testing
drax pit
Tested on:
Verified that with this change the Kubernetes Check cray-vault Vault Cluster Status and Kubernetes Ensure Configmaps Containing CA Certs Exist no longer run
drax-ncn-m001-pit:/opt/cray/tests/install/livecd/automated # csi pit validate pit --k8s | grep "Kubernetes Check cray-vault Vault Cluster Status"
drax-ncn-m001-pit:/opt/cray/tests/install/livecd/automated # csi pit validate pit --k8s | grep "Kubernetes Ensure Configmaps Containing CA Certs Exist"
drax-ncn-m001-pit:/opt/cray/tests/install/livecd/automated #

Test description:

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? NA
Were continuous integration tests run? If not, why? NA
Was upgrade tested? If not, why? NA
Was downgrade tested? If not, why? NA
Were new tests (or test issues/Jiras) created for this change? NA

Risks and Mitigations
Are there known issues with these changes? Any other special considerations? NA
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[x] Target branch correct
[ ] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

/backport release/csm-1.2


How to use BuildRenderTree() as a RenderFragment?

When extending an existing component, one can use the base.BuildRenderTree(__builder) to render the base component's HTML.
However, using base.BuildRenderTree(__builder) inside a component as a RenderFragment ChildContent will fail.
Here is an example:
// MyWrapper.razor

Wrapper

@ChildContent

@code {
    [Parameter]
    public RenderFragment? ChildContent { get; set; }
}

// MyComponent.razor

@Inherits SomeComponent

My Component

    <MyWrapper>
        @{
            base.BuildRenderTree(__builder);
        }
    </MyWrapper>

The above fails with the following error:
  System.AggregateException: One or more errors occurred. (TypeError: Cannot read properties of undefined (reading 'parentNode'))
       ---> System.InvalidOperationException: TypeError: Cannot read properties of undefined (reading 'parentNode')
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.InvokeRenderCompletedCallsAfterUpdateDisplayTask(Task updateDisplayTask, Int32[] updatedComponents)

This can be fixed by replacing the base.BuildRenderTree(__builder) block with a RenderFragment factory method:
// MyComponent.razor

@Inherits SomeComponent

My Component

    <MyWrapper>
        @WrapInRenderFragment()
    </MyWrapper>

@code {
    private RenderFragment WrapInRenderFragment() => builder => base.BuildRenderTree(builder);
}

My understanding is that this happens because RenderFragment is a delegate that operates on a RenderTreeBuilder, whereas running the code base.BuildRenderTree(__builder) is used to generate the contents of the component's BuildRenderTree() method, which are two different things.
I'm unable to find much documentation on the subject of using the BuildRenderTree() method inside a RenderFragment. Is the above the correct way to handle this or will it lead to unexpected complications down the line?

Edit:
You can also replace the private method with a Razor expression that returns a lambda instead, which leads me to believe that RenderFragments are handled differently by the Razor code generator (I'm guessing they're invoked when found):
<MyWrapper>
    @((RenderTreeBuilder builder) => base.BuildRenderTree(builder))
</MyWrapper>

Calling base.BuildRenderTree(__builder); seems unsupported - you are relying on an implementation detail that a __builder variable is available. On the other hand, relying on RenderFragments looks good to me.

when you say calling base.BuildRenderTree(__builder) is unsupported, are you specifically talking about calling it in this context (i.e. inside a custom component that expects a RenderFragment?

I meant in general, accessing __builder looks like a hack that might not work in all situations. That's why it also doesn't work in your example (see below).
But I will let other @dotnet/razor-compiler folks chime in whether they think this is something we should support and hence somehow make this work.

Note: in your example, the <Wrapper> component introduces a new builder (__builder2) like this in the generated code:
__builder.OpenComponent<global::BlazorApp1.Components.MyWrapper>(2);
__builder.AddAttribute(3, "ChildContent", (global::Microsoft.AspNetCore.Components.RenderFragment)((__builder2) => {
    base.BuildRenderTree(__builder);
}));

So you are referring to the wrong builder and it's failing at runtime. That should also demonstrate why relying on __builder is a hack today.

Is there a "correct" approach to rendering a component's base HTML, then? Or is it unsupported and the hack the only way to do it currently?

Is there a "correct" approach to rendering a component's base HTML, then?

As I already said, the RenderFragment approaches look good to me. I think they will behave as expected. Either one of those:
@code {
    private RenderFragment WrapInRenderFragment() => builder => base.BuildRenderTree(builder);
}

@((RenderTreeBuilder builder) => base.BuildRenderTree(builder))

Sorry, your previous comment made me think you meant using base.BuildRenderTree(__builder) is unsuported everywhere (outside of this use case with nested components and RenderFragments).
It's still the correct way to render a base component normally , right?
An example of what I mean:
// Foo.razor

@inherits Bar

@base.BuildRenderTree(__builder)

@code {
    // Override some of Bar's methods/defaults here.
}

It's still the correct way to render a base component normally , right?

Although it works today, I wouldn't recommend it.
Let me summarize:

Accessing __builder anywhere is a hack and I wouldn't recommend it. It won't work in nested components. Even though it works in some scenarios, it's still an implementation detail of the compiler - we might not change it if lots of people depend on it, but in theory we could change it in a breaking way at any point in the future.
Calling base.BuildRenderTree anywhere seems fine. But you shouldn't pass __builder into it per the previous bullet point.
Using RenderFragment is also a supported scenario.
Combining the last two bullet points => you should do something like @((RenderTreeBuilder builder) => base.BuildRenderTree(builder)) everywhere.

Adding @SteveSanderson @javiercn @mkArtakMSFT
I think we need to get crisp on what is and isn't supported when it comes to Blazor component inheritance. As @UniMichael pointed out, we've pointed users to __builder based workarounds before. If we're now saying that touching __builder isn't supported at all, then we probably need to do a scrub of the Blazor docs to make sure it isn't recommended anywhere. And we should document what our actual guidance is for component inheritance. We may also want to consider adding compiler features to make the experience better.

My 2c: We definitely should stop telling people to use __builder. At the end of the day its an internal compiler construct that could change, and as Jan pointed out above, sometimes people would need to use __builder2 (or maybe even __builder3? 😛), and we don't have a good way to allow users to find out which one to use.
Having said that, we shouldn't do it until we have an alternate suggestion that our users will be happy with.

Agree with @davidwengier that we should stop telling people to use __builder. @danroth27 What's the next steps here, doing a scrub of the documentation?

For this scenario, I think that the cleanest way would be if the runtime provided a method like
class ComponentBase
{
    protected RenderFragment RenderBase() => builder => base.BuildRenderTree(builder);
}

That could be called simply as
@RenderBase()
.
The second cleanest way is telling customers to define this method themselves like
@code {
    private static RenderFragment RenderBase() => builder => base.BuildRenderTree(builder);
}

That being said, I don't know if we are recommending to use __builder in other scenarios, if so, we should rethink those as well.

private static RenderFragment RenderBase() => builder => base.BuildRenderTree(builder);

@jjonescz thanks for all this, its very helpful!
just a quick note that the static keyword causes a CS1511 error 'base is not available in a static method'

Agree with @davidwengier that we should stop telling people to use __builder. @danroth27 What's the next steps here, doing a scrub of the documentation?

I believe use of __builder was already scrubbed from the docs. @mkArtakMSFT It looks like we do still use it in one of our tests: https://github.com/dotnet/aspnetcore/blob/main/src/Components/benchmarkapps/Wasm.Performance/TestApp/Shared/FastGrid/Grid.razor

@mkArtakMSFT It sounds like we also need to update our response to https://github.com/dotnet/aspnetcore/issues/21664#issuecomment-1261225519

I'm going to close this out, as I think we have an acceptable answer to the original question.
I will open a language design issue to track the idea of a new razor keyword for rendering parent content.


Any suggestion for Install ROCm on aarch64,Ubuntu ?

hello , I want to install ROCm. but I can't find anything about how to install on the aarch64 architecture.
here is my os and gpu infor.

ROCm does not support ARM. I am not aware of any path you can take to enable ROCM on aarch64.


Add tests for no-attr-in-host

Tests the last remaining uncovered lines.

Codecov Report

Merging #31 (44d211e) into master (27cd474) will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   98.82%   99.25%   +0.42%
==========================================
  Files           4        4
  Lines         512      537      +25
==========================================
+ Hits          506      533      +27
+ Misses          6        4       -2

Impacted Files
Coverage Δ

grandiso/test_grandiso.py
100.00% <100.00%> (ø)

grandiso/__init__.py
96.87% <0.00%> (+1.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cd474...44d211e. Read the comment docs.


How to set callValue or msg.value from migrations.js

I am learning solidity smart contract. I am using tronbox as my development framework. While deploying contract, I need to send some trx to contract address. So that It will be available in msg.value. For example this is my constructor function,
constructor() public payable {
    require(msg.value == 2 trx, "2 trx initial funding required");
}

How to send  2 trx, while deploying contract in migration file. For example this is my migration file,
var SimpleBank = artifacts.require("./Simple.sol");
var Migrations = artifacts.require("./Migrations.sol");

module.exports = function(deployer) {
  deployer.deploy(Simple);
  deployer.deploy(Migrations);
};

Please add payable key to constructor's abi in /build/contracts/*.json
before
{
  "inputs": [],
  "stateMutability": "payable",
  "type": "constructor"
},

after
{
  "inputs": [],
  "stateMutability": "payable",
  "payable": true,
  "type": "constructor"
}

deployer.deploy(Migrations, {callValue: 1});

It's an upstream bug.


Pablo/invoices live

Customer_name and reference data are not the correct ones. I have just rendered some random fields from the invoice schema to see if it works

#24


Tidy Up 0.1.0

[x] Add DB connection string
[x] Move view models in their own files

View models isn't a big issue now. Moved to later stages.


output looks TOTALLY different from GraphViz

Hi!
I have a problem with graphlib-dot (mostly just starting…) because it absolutely ignores any styling.
Input: https://github.com/mirabilos/TC3conv/blob/master/experiments/d.htm
Expected output: https://github.com/mirabilos/TC3conv/blob/master/experiments/d.png
Actual output: boxen (not so bad), and all colour information is ignored (very bad). Please advice how I can fix this.

Your links are broken.

Indeed, the new Github ToS are to blame.
The data is now here: https://evolvis.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=useful-scripts/tc3conv.git;a=tree;f=experiments;h=9fb940a0c73e745af945f173667f02eb5b078b22;hb=HEAD
Sorry about that.


Fastclick caused a click problem on ios12

Version
1.12.19
Reproduction link
https://didi.github.io/cube-ui/#/zh-CN/example
Steps to reproduce
When you use input or textarea above ios12, quick clicks don't evoke the keyboard. This is because ios12 updates a problem caused by scrolling smoothness, and I don't quite understand why there is a need to apply fastclick on ios10. Hope to answer, thank you.
What is expected?
Quick single click to evoke the keyboard
What is actually happening?
Quick single click does not evoke the keyboard
Dependencies Version
vue: 2.6.9
better-scroll: 1.15.0

This https://github.com/ftlabs/fastclick/issues/549 ?

no,it does'nt work.


Revisions feature

I was hoping this would contain a revisions feature.
Where you can get a list of your revisions, download specific one, ...
Would this ever be on the roadmap?

I have no plans to implement it at this time, as FlySystem has no concept of revisions.


replace TextPlainResponse to plainResponse

Replace TextPlainResponse to PlainResponse

this has been fixed in the new branch oc-10-take-2, not necessary to merge this one.


Instructions to add to path don't work

[x] are reporting a bug others will be able to reproduce and not asking a question or requesting software. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh. To get software added or changed in Homebrew please file a Pull Request
[x] have a problem with brew install (or upgrade, reinstall) a single, Homebrew/homebrew-core formula (not cask) on macOS? If it's a general brew problem please file this issue at Homebrew/brew: https://github.com/Homebrew/brew/issues/new/choose. If it's a Linux problem please file this issue at https://github.com/Homebrew/linuxbrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[x] ran brew update and can still reproduce the problem?
[x] ran brew doctor, fixed all issues and can still reproduce the problem?
[x] ran brew gist-logs <formula> (where <formula> is the name of the formula that failed) and included the output link?
[x] if brew gist-logs didn't work: ran brew config and brew doctor and included their output with your issue?

(Of course these all fail because brew isn't installed.)
To help us debug your issue please explain:

What you were trying to do (and why)

Install Homebrew (to build SciPy)

What happened (include command output)

The installer says:
- Add Linuxbrew to your PATH
    eval $(/home/linuxbrew/.linuxbrew/bin/brew shellenv)

and the website https://docs.brew.sh/Homebrew-on-Linux says
test -d /home/linuxbrew/.linuxbrew && eval $(/home/linuxbrew/.linuxbrew/bin/brew shellenv)

But neither of these work:
$ test -d /home/linuxbrew/.linuxbrew && eval $(/home/linuxbrew/.linuxbrew/bin/brew shellenv)
bash: set: -g: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
bash: set: -g: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
bash: set: -g: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
bash: set: -g: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
bash: set: -q: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
or: command not found
bash: set: -g: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
bash: set: -q: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
or: command not found
bash: set: -g: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]

What you expected to happen

Add Linuxbrew to your PATH

Step-by-step reproduction instructions (by running brew install commands)

Ubuntu 18.04

Open bash terminal
sh -c "$(curl -fsSL https://raw.githubusercontent.com/Linuxbrew/install/master/install.sh)"
 eval $(/home/linuxbrew/.linuxbrew/bin/brew shellenv)

To workaround your current problem: there's a binary in your path called set that you need to remove. Try temporarily changing your PATH environment variable.

Closing as user-specific issue.

This is what I had to do, for anyone else with this problem:
set -U fish_user_paths /home/linuxbrew/.linuxbrew/bin $fish_user_paths

This is a permanent change, you don't need to do it each time.
http://fishshell.com/docs/current/tutorial.html#tut_path

I also had this problem with the Ubuntu homebrew-wrapper installed fish shell, which seems to have skipped installing the fish shell init in my fish profile but which executes erroneously from the bash.profile which is AFAICT always executed at login as part off some ubuntu setup step. For me the fix was to append
eval (/bin/brew shellenv)

to ~/.config/fish/config.fish
and to modify the init line in .profile to read
eval $(SHELL=bash /bin/brew shellenv)

Then the correct vars seem to be initialized for both the compulsory bash shell and also my fish shell.


Review 2018Q3-okrs:talent

Signed-off-by: tsolakou<EMAIL_ADDRESS>

In order to avoid conflicts, it would be good to review and merge this, so that I can rebase https://github.com/src-d/okrs/pull/94

Rebased this on top of 2018Q4 branch, solving conflicts.


Subsonic has gone closed-source. We should replace it with a maintained, free fork

Issue description
Subsonic has closed down its source code, following the 6.0 release. We should switch to a free fork instead.
Libresonic is one such free fork and Airsonic is another.

@therealpxc Would you be able to test the above PR? I was able to run the service and it was listening on 4040 after setting services.airsonic.enable =true;.

I will set it up on my multimedia machine when I get home, and test streaming with it for a few days to my work machine and phone.
PS: I mostly filed this issue to remind myself to get to it eventually (which may have been a long time). So thanks for jumping in and fully revealing my laziness! :-D


feat: scale based on metrics

Signed-off-by: Derek Wang<EMAIL_ADDRESS>

Is this what I think it is?

In the Reconcile func, asking the metrics cache to periodically poll for last pending, or ask it to stop if step is being deleted.
The polling could probably be single threaded using a ticker. It can then use a worker query to limit the number of concurrent requests for pending.

Changed to use a queue as task list.

can not regenerate api/v1alpha1/generated.pb.go, deleted it temporarily.

can not regenerate api/v1alpha1/generated.pb.go, deleted it temporarily.

I noticed that I need to delete this too.

This is excellent innovate and simplify.


World is null upon rocket land?

I just looked over at my console window for my pack using your mod (latest released version) for 1.7.10 mc
and saw this error pop up.
https://gyazo.com/300dfd4689e1eba5e314b2b30d6f70fc
Any idea how to fix this or know what it means?

<IP_ADDRESS>-1.0.19b.jar is the version I am running.

There was an issue where the reference to world would be null when the rocket lands, but rather than letting the game crash I printed a debug message with a bit of info. I've not been able to replicate it myself yet though either.   Still no definitive idea of how it happens though my best guess is interaction from something like thermos or sponge.
It's basically saying the tile exists at 0,0,0 and is valid in the world.  I'm regretting not sticking a stack trace printout.
Only negative effect you should see in the world from this directly is the rocket might not link to the pad it landed on when the message shows up.
Also would it be possible to list the mods and version of forge that you're running?  Also does this happen every time a rocket lands on a station or just sometimes?

Advanced Rocketry by zmaster587
AE2 Stuff by bdew
Agricraft by InfinityRaider
AOBD by ganymedes01
AOBD Singularities by RCXcrafter
Apple Milk and Tea 2 by RazzleberryFox
Applied Energistics 2 by AlgorithmX2
Animus by TeamDman and Saerethlb
Aroma1997's Dimensional World by Aroma1997
Automagy by Tuhljin
Avaritia by SpitefulFox
Avaritia Addons by WanionCane
Better Questing by FunWayGuy
Better Questing: Standard Edition by FunWayGuy
BiblioCraft by JDSinclair
BiblioWoods (BiomesXL) by JDSinclair
BiblioWoods (Forestry) by JDSinclair
BiblioWoods (Natura) by JDSinclair
Big Doors by jaquadro
Big Reactors by ErogenousBeef
Binnie Mods by Binnie567
Birds Nests by cleverpanda714 []
Blood Arsenal by Arcaratus
Blood Magic by WayofTime
Botania by Vazkii
Carpenters Blocks by Syntaxial
Chisel by tterrag1098, Drullkus, and Minecreatr
Chisel Tones by TehNut
ComputerCraft by dantwohundred
Cooking for Blockheads by BlayTheNinth
Cosmetic Armor Reworked by ZLainSama
Custom NPCs by Noppes
DecoCraft 2 by RazzleberryFox
Dense Ores by RWTema
Enchanting Plus by Darkhax
Enchiridion by joshiejack
Ender IO by CrazyPands_MC
Ender IO Addons by Henry_Loenwind
Ender Storage by chicken_bones
EnderTech by CarrotCodes
EnderZoo by CrazyPants_MC
Eternal Singularity by KingWealthyturtle
EvilCraft by kroeser
Extra BiomesXL by Annysia
Extra Cells by DrummerMC
ExtraTiC by JeanGlassmaker
Extra Utilities 2 by RWTema
Fairy Lights by pau101
Forbidden Magic by SpitefulFox
Forestry by SirSengir
Gadomancy by makeoo
Gany's End by ganymedes01
Gany's Nether by ganymedes01
Garden Stuff by jaquadro
Gendustry by bdew
Grapple Mod by Yyon
Grimoire of Gaia by Silentine
Growthcraft Community Edition by Alatyami
Grue by Shinoow
Hardcore Ender Expansion by chylex
Hats by iChun
Iguana Tinker Tweaks by bonusboni
INpure Core by INpureProjects
Inventory Pets by Purplicious_Cow
Inventory Tweaks by Kobata
Iron Backpacks by gr8pefish
Iron Chest by progwml6
Jabba by ProfMobius
Jaffa Foods (A HarvestCraft Addon) by Murdy007
Magical Crops by Mark719
Magical Crops Armoury by Mark719
Magical Crops Decorative by Mark719
Magic Bees by MysteriousAges
Malisis Doors by Ordinastie
Mariculture by joshiejack []
Minecraft Comes Alive by WildBamaBoy
Minefactory Reloaded by skyboy026
Mekanism by aidancbrady
Mekanism Generators by aidancbrady
Mekanism Tools by aidancbrady
Minechem by jakimfett
Modular Powersuits by MachineMuse
Morpheus by Quetzi
MrCrayfish Furniture Mod by Mr_Crayfish
Natura by mDiyo
NEI Addons by bdew
NEI Integration by tonius111
Nether Ores by skyboy026
Nodal Mechanics by Shukaro
No More Recipe Conflict by Oliv1er
Not Enough IDs by fewizz
Not Enough Items by chicken_bones
Not Enough Resources by Way2muchnoise
Not Enough Thaumcraft Tabs by fewizz
OpenBlocks by OpenMods
Pam's HarvestCraft by MatrexsVigil
Platforms by ShetiPhian
PortalGun by iChun []
Project Red - Base by Mr_TJP
Project Red - Compat by Mr_TJP
Project Red - Integration by Mr_TJP
Project Red - Lighting by Mr_TJP
Project Red - Mechanical by Mr_TJP
Project Red - World by Mr_TJP
RailCraft by CovertJaguar
Random Things by lumien231
Recurrent Complex by Ivorforce
Redstone Armory by TehNut
Redstone Arsenal by TeamCoFH
Reliquary v1.3 by P3pp3rF1y
RFTools by McJty
Sanguimancy by Tombenpotter
Secret Rooms Mod by AbrarSyed
Simple Labels by insaneau
Solar Expansion by TedTheRusSB624
Soul Shards - The Old Ways by SgtPunishment
Starminer by あるべ
Steves Addons by hilburn
Steves Factory Manager by Vswe
Storage Drawers by jaquadro
Storage Drawers (Forestry) by jaquadro
Storage Drawers (Misc) by jaquadro
Storage Drawers (Natura) by jaquadro
Tails by KitsuneKihira
Tainted Magic by yorkeMC
ThaumCraft Inventory Scanning by BlayTheNinth
ThaumCraft Node Tracker by Dyonovan
Tinkers Construct by mDiyo
Technomancy by Theflogat
ThaumCraft by azanor
ThaumCraft Mob Aspects by Parker8283
ThaumCraft NEI Plugin by DjGiannuzz
Thaumic Energistics by Nividica
Thaumic Exploration by nekosune
Thaumic Horizons by TheKentington
Thaumic Tinkerer by nekosune
The Spice of Life by squeek502 []
Thermal Dynamics by TeamCoFH
Thermal Expansion by TeamCoFH
Thermal Foundation by TeamCoFH
Thermal Singularities by WanionCane
TiC ToolTips by Squeek502
Tinker IO by gkbm2011
Totemic by ljfa
TrainCraft by Mrbrutal
Traveller's Gear by BluSunrize
Universal Singularities by KingWealthyturtle
Waila by ProfMobius
Waila Plugins by tterrag1098
Wawla by Darkhax
Wireless Crafting Terminal by TheRealp455w0rd
Witchery by Emoniph
Witching Gadgets by BluSunrize []
ZTones by riciJak
forge version: forge-10..13.4.1614


CDS-51927 metadata expressions

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

https://harness.atlassian.net/browse/CDS-51927

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


[fix_bug#2055][config] optimize configuration initialization function  and add endpoint debug log

Summary
optimize configuration initialization function  and add endpoint debug log
close #2055
Verify this pull request
Manually verified the change by testing locally.

Nice job! Thanks man!

Nice job! Thanks man!

hello man, please help me reviewer

There is contamination in this PR submission record, I submitted a new one

@SnowMoon-Dev Hi, thank you for your contribution to Apache Devlake, Devlake community specially invites you to join our contributor group and issue you a contributor certificate. If you are willing, please contact<EMAIL_ADDRESS>looking forward to your reply.


Remove: GitHub.GitHubDesktop.Beta version 2.8.3-beta1

## .\Tools\YamlCreate.ps1 -SkipPRCheck -Mode 5 -PackageIdentifier GitHub.GitHubDesktop.Beta -PackageVersion 2.8.3-beta1

[X] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


Draft-Sentiment-Model

Naming: feature/descriptive-name
Reviewers: minimum 2 (Chris and/or 2 from Web or DS respectively and not person who submitted PR)
Description:
What is the motivation for changes?
The TwitterBot needs to be able to understand the different responses from the twitter users about Police Misconduct.
What specific changes were made?
Jupyter notebook containing an LSTM Model
Submitter Checklist:

[x] Small scope (1-2 components)
[x] Not too many concerns in a single commit
[x] Remove extraneous comments (code in comments), print statements, to-dos, console.logs, extra fluff
[ ] Atomic, descriptive commit messages
[ ] Consistent formatting

Reviewer Checklist:

[ ] Small scope (1-2 components)
[ ] Comments, print statements, to-dos, console.logs, extra fluff were removed
[ ] Give feedback no matter what conversations happened elsewhere, document here
[ ] Comment on the line of code itself (blue plus box) in files changed tab

Pair programmed with Imani and Andrew on this. At the moment although the model has a great training accuracy, the testing accuracy is only about 50%. We will continue to try and improve this model.

Update: We have changed from multiclass sentiments to binary sentiments and it has improved the model accuracy quite a bit. We want to incorporate more data and explore the use of Distilbert pretrained model to see if this makes a difference as well

Update: Added more data, Model Accuracy did not chance. We are looking to now explore the use of Distilbert pretrained model to see if this makes any difference!

Closing out this pull request because of the conflicting file (scraper.py) instead of deleting it so that the model's progress is available to view.
I will be creating a new pull request

Please DO NOT Merge this Pull Request


Merge MIXS:0000253 and MIXS:0000254

Current term details
Term name - host infra-specific name
Term ID - MIXS:0000253
Structured comment name - host_infra_specific_name
Definition - Taxonomic information about the host below subspecies level name
Expected value -
Value syntax -{text}
Example - borealis
Preferred unit -
Package(s) - host-associated AND plant-assocaited

NB - partner term MIXS:0000254 "host_infra_specific_rank"
@lschriml says :

seems to be equivalent to core: subspecific genetic lineage

Term name - subspecific genetic lineage
Term ID - MIXS:0000020
Structured comment name - subspecf_gen_lin
Definition - This should provide further information about the genetic distinctness of the sequenced organism by recording additional information e.g. serovar, serotype, biotype, ecotype, or any relevant genetic typing schemes like Group I plasmid. It can also contain alternative taxonomic information. It should contain both the lineage name, and the lineage rank, i.e. biovar:abc123
Expected value - genetic lineage below lowest rank of NCBI taxonomy, which is subspecies, e.g. serovar, biotype, ecotype
Value syntax - {rank name}:{text}
Example - serovar:Newport
Preferred unit -
Package(s) - CORE

Suggested updates
The difference between  subspecf_gen_lin and host_infra_specific_name is online that the later is specific to the host of the sample, perhaps the definitions need to be updated to make that clear?
The CORE term subspecf_gen_lin includes the rank as part of the value, the host_infra_specific_name requires the additional term host_infra_specific_rank to be included, this should be merged to be consistent by including rank and name in 1 field.

@anjijohnston you're currently not appearing in the list of options to assign to! I guess we need to get your username into the repo somehow, hopefully tagging you here will do that!


[6.x] Interfaces for test helpers

I added interfaces for the test helper methods, used in the setUpTraits() method. Additionally to checking if a test case uses the helper traits, the implementation of interfaces is checked and therefore the implementation of the methods like refreshDatabase() or setUpFaker().
The purpose of the PR is to not be dependent on the Laravel specific traits, but be able to use custom implementations of the methods, without the need of overwriting the setUpTraits() method.
I reopened the PR again, but this time I made the changes on the 6.x branch, because the changes are no breaking changes. Test cases using the traits still work.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Animation Editor, key frames, not deselected visually

Godot version
v3.4.1.stable.official [aa1b95889]
System information
Windows 10 21H1
Issue description
Key frame(s) are not deselected visually,
when clicking outside a key frame in the Animation Editor.
Steps to reproduce

add a node: AnimationPlayer
add a new animation

click on the Animation button at the top of the Animation editor
choose New
press OK to use the default name: New Anim

add a key frame

the Inspector shows the AnimationPlayer properties,
click on the key icon to the right of: Editor Description

A window opens: Please Confirm...

click: Create

In the Animation Editor,
select the key frame by clicking on it (the white diamond) at the animation position (time): 0
the key frame changed color to blue, and the Inspector shows: AnimationTrackKeyEdit
In the Animation Editor,
try to deselect the key frame by clicking below the editor_description track

Observed
The inspector becomes blank (as expected, nothing is selected)
but the key frame still has a blue color.
The key frame isn't selected, because:
right clicking on an unselected the key frame just shows: Insert key
and this is what's observed after the steps above.
Right clicking on a selected key frame shows:
Insert Key
Duplicate Key(s)
Delete Key(s)
Expected
The key frame color should change to white, to indicate that it's been deselected.
Multiple key frames
There's an additional issue when attempting to deselect multiple key frames.
Only the key frame(s) on the selected track are deselected.
Reproduction steps

Add another key frame,
with the AnimationPlayer node selected,
in the Inspector, click on the key icon to the right of: Pause Mode
In the Animation Editor,
click on the first (top) key frame,
to select the editor_description track (it gets a border)
select both key frames and keep the first track selected by,
mouse dragging a selection rectangle, from below both key frames
try to deselect them by clicking below both key frames

The Inspector became empty (as expected).

move up the mouse over the 2d editor

Observed
Only the key frame on the selected track (with the border), changed to white.
The key frame, on the second track (pause_mode), is still blue.
Expected
Both key frames should have been deselected (white color),
when clicking outside a selected key frame.
Minimal reproduction project
No response

I can confirm this on master 8485d0c53 when clicking outside the area that contains any tracks. If I click outside of a key but still inside a track, keys appear to be deselected visually as expected.


Test ValueDB and CC serialization for consistency

Currently, the conversion and (de)serialization of map-like values seems inconsistent.
Ideally, the valueDB should either:

internally store map-like values as real maps
or return map-like values as maps when asked to with getValues()

fixed


fix issue #14

Hi i fixed the issue.

Thank you so much!

@csprea the fix is available in<EMAIL_ADDRESS>

Hi team,
I am using 0.7.2 and still facing the issue. At the moment I have circum-navigated this issue by introducing a delay of 1.25 seconds between the api fetching the result and rendering the results.
However, not sure why this is not getting fixed permanently for me. I am getting the following error:
ERROR TypeError: Cannot set properties of undefined (setting 'centralLabel')
at t.drawChart (main.976623a2e235b4123d4e.js:1:1482291)
at t.ngOnInit (main.976623a2e235b4123d4e.js:1:1481584)
at main.976623a2e235b4123d4e.js:1:380721
at main.976623a2e235b4123d4e.js:1:380764
at Ho (main.976623a2e235b4123d4e.js:1:382087)
at ha (main.976623a2e235b4123d4e.js:1:388580)
at Object.updateDirectives (11.676a246b04968a88821e.js:1:68006)
at Object.updateDirectives (main.976623a2e235b4123d4e.js:1:397512)
at No (main.976623a2e235b4123d4e.js:1:378668)
at Xo (main.976623a2e235b4123d4e.js:1:385605)
ERROR TypeError: Cannot read properties of undefined (reading 'removeGauge')
at t.drawChart (main.976623a2e235b4123d4e.js:1:1482252)
at t.ngDoCheck (main.976623a2e235b4123d4e.js:1:1482026)
at main.976623a2e235b4123d4e.js:1:380750
at main.976623a2e235b4123d4e.js:1:380764
at Ho (main.976623a2e235b4123d4e.js:1:382087)
at ha (main.976623a2e235b4123d4e.js:1:388580)
at Object.updateDirectives (11.676a246b04968a88821e.js:1:68006)
at Object.updateDirectives (main.976623a2e235b4123d4e.js:1:397512)
at No (main.976623a2e235b4123d4e.js:1:378668)
at Xo (main.976623a2e235b4123d4e.js:1:385605)


Tautological comparisons are not normalized away by F*

This seems to be generated by a tactic. Found in mitls-fstar/src/tls/extract/Kremlin-Library/DHGroup.c
      uint32_t v1 = scrut0.v.fst;
      FStar_Pervasives_Native_option__K___uint32_t_uint32_t ite;
      if (!(v1 < (uint32_t)0U || (uint32_t)65535U < v1))

this generates a warning on modern compilers:
DHGroup.c:393:14: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
    if (!(v1 < (uint32_t)0U || (uint32_t)65535U < v1))

CC @nikswamy @tahina-pro

Related to #1482.
I hit this issue and had to add a -Wno-error flag to make the warning non-fatal when compiling with -Werror.

We are tracking it in #1376, closing this issue (thanks for reporting it Jonathan!).


callbackOnChange : only trigger on user inputs (select elements)

Me again for an enhancement ;)
callbackOnAddItem and callbackOnRemoveItem are called when choices are added to the select list.
I've made another callback which is called only on user inputs : https://github.com/chymz/Choices/commit/57c241aac06ac25c983eec83e149c836efbe29e1
Thanks !

I'm loving all your feedback! So useful. I'll start integrating some of these enhancements ASAP.
Thanks!

This has now been implemented (https://github.com/jshjohnson/Choices#callbackonchange).
Thanks!


js development: catch vizzu releated errors

catch async exceptions and write out the error message into the html page. this solution would be easier than sending it back to jupyter

We should write the error message into HTML


Add processor example to README

Just adds to the README processor option example, discussed in #9 and implemented in #11.
By the way, is there any prevision where a new version will be pushed to rubygems with this feature?
Thanks

Good idea to document this! I think, however, that you're looking at an out-of-date PR – this feature saw it's final implementation using a different API in #16.
Also, we're looking to move most of our documentation over to dry-rb.org instead of keeping them in READMEs. Would you mind submitting a PR to the dry-rb.org repo instead?

We'll obviously need to wait until a release before the PR to dry-rb.org docs is merged - I'll let @AMHOL chime in here if he has any thoughts on release timing.

Thanks for pointing me to the updated API, I didn't saw that.
I submitted the pull request to dry-rb.org repository and also updated this one, because I think it is also useful if you find it in the Readme.
Cheers!

Cheers, I know @solnic isn't keen on having documentation in the readme, I like it myself but I think it's better to be consistent so I will probably remove it here and in dry-container, I'll release tomorrow night, thanks for the reminder.

Ok, thinking about it a little bit I see @solnic is right. Having also a website, it is better to only have the documentation in one place, otherwise it may be difficult to keep both updated. I guess the README should only have a link to the website. I'll close this pull request, then. Thank you!

@waiting-for-dev released as 0.3.0, sorry for the delay.

Hey, many thanks! :)


False - positives on Models match DDL test

Expected behavior:

When alembic revision --autogenerate generates no changes in schema, pytest-alembic should pass on this test

Actual behavior:

alembic generates no revisions and pytest-alembic fails this test.

Errors:
E   pytest_alembic.plugin.error.AlembicTestFailure: The models decribing the DDL of your database are out of sync with the set of steps described in the revision history. This usually means that someone has made manual changes to the database's DDL, or some model has been changed without also generating a migration to describe that change.

If you're on latest (or close to latest, i'd have to go check the version this was introduced), the test failure ought to output the migration that the pytest-alembic claims autogenerate should output, which is where I would start. I suspect some configuration mismatch.

Closing due to this being a limitation of Redshift, not pytest-alembic.


AudioWaveforms does not remove listeners properly

Describe the bug
The way AudioWaveforms is written it never removes the listener it attaches.
https://github.com/SimformSolutionsPvtLtd/audio_waveforms/blob/ea69c5ec00e5c7a18b8d87d22999ad5c4ddf71ca/lib/src/audio_waveforms.dart#L45-L56
Since the listener is a closure it will not be removed. The listener needs to be a method of the class for the widget to be able to remove it from the list of listeners.
This bug is being hidden away by the if (mounted) check before setState. However, that is just a workaround to the fact the listener is not being removed.
In addition, while looking at this widget it seems sub-optimally structured, it rebuilds way too much.
The only thing that depends on the values produced by the controller is the painter, and since the controller is a Listenable it can be passed to the CustomPainter.repaint property. This would then avoid rebuilding the widget all together and simply have the painter repaint, skipping a whole lot of work in the process.
Expected behavior
The AudioWaveforms widget should correctly remove the listeners it attaches.

Fixed in latest release.


Table view for HasMany field

It is often more convenient to display some relations as a table. This commit adds support for outputting the hasMany form field as a table.
Example
$form->hasMany('keywords', 'Add more keywords', function ($nestedForm) {
$nestedForm->select('campaign_id', 'Campaign')->options(...);
$nestedForm->text('title', 'Title');
$nestedForm->checkbox('active', 'Active keyword');
...
})->useTable();
Real implementation looks like http://joxi.ru/bmovx88h3yeXZr
Css rules for correct output added to laravel-admin.css (some padding fix + validation error label)

Thanks！


Maybe There is a bug in train.py, when flip the image

Here in the second if, I think the axis should be 2.  axis=0 means flip along the batch dimension
    if np.random.randint(2,size=1)[0] == 1:  # random flip
        input_patch = np.flip(input_patch, axis=1)
        gt_patch = np.flip(gt_patch, axis=1)
    if np.random.randint(2,size=1)[0] == 1:
        input_patch = np.flip(input_patch, **axis=0**)
        gt_patch = np.flip(gt_patch, **axis=0**)
    if np.random.randint(2,size=1)[0] == 1:  # random transpose
        input_patch = np.transpose(input_patch, (0,2,1,3))
        gt_patch = np.transpose(gt_patch, (0,2,1,3))

You're right. Thanks
It is fixed in the latest version.


Changing TargetFramework TargetFrameworks causes project error

New dotnet core console project
r-click edit project file
Change TargetFramework to TargetFrameworks
Save

Get the following error.
---------------------------
Microsoft Visual Studio
---------------------------
The project system has encountered an error.

Could not resolve mscorlib for target framework '.NETCoreApp,Version=v1.0'.  This can happen if the target framework is not installed or if the framework moniker is incorrectly formatted.

A diagnostic log has been written to the following location: "C:\Users\billhie\AppData\Local\Temp\VsProjectFault_6e2b5b1e-8855-4ddb-a787-b308fad4ffca.failure.txt".
---------------------------
OK
---------------------------

This is related to the DTAR stuff. @davkean is working on a PR now.

Dupe of #660?

I'd guess it's the same issue, but a different repro.

Dupe of #660


Add instructions on how to compile game.ts and output game.js

Being a newbie to Typescript and Babylon.js I had trouble knowing how to properly compile game.ts so I thought I'd contribute this pull request to maybe help other neophytes.

Thanks a lot!


Generators

Did the concept of platform specific generators ever come up with regards to oslo?
It would be nice to see a community supported set of assets for transforming OpenSLO compliant SLOs into operational measures on Splunk, Dynatrace, etc etc
I feel like most implementations will create these anyways, so why not make it open... thinking like a "galaxy" style or something. Happy to work out a few initial implementations if people think its a good idea to include in the scope of the project.
If not, would really love to hear why.

Yeah, this is something that we are talking about.  It would be great to have olso be able to generate SLOs.

@ian-bartholomew It generates some interesting discussion around spec constructs, as I mentioned in https://github.com/OpenSLO/OpenSLO/issues/29 , there might need to be a bit more consistency in the constructs of the spec in order to be able to allow the spec to translate to actionable SLOs for platforms, and vice versa.
Additionally, I think this may lead back to the discussion that led to you creating https://github.com/OpenSLO/OpenSLO/issues/27 as well

@its02003 yeah, you are correct.  We have a number of prerequisites to address before we can do it

Mind if we list those in this issue? We can build out the list as we identify more

@ian-bartholomew thoughts on the idea of tracking the prerequisites here?

@its02003 i think the primary prerequisite is that we need to get the spec in a more stable place.  While we are working on the early iterations there's a lot in flight.  I'm trying to track as many of those issues in the spec repo.  Thanks!

@ian-bartholomew I added this as a pre-requisite on the issue. I think it might make sense to spend a moment defining what is considered unstable about the spec and when it might be considered "stable"


⚠ DDoS-Relay US-W-sfo3-02 has degraded performance

In 44db588, DDoS-Relay US-W-sfo3-02 (http://<IP_ADDRESS>:42069/;csv) experienced degraded performance:

HTTP code: 200
Response time: 130 ms

Resolved: DDoS-Relay US-W-sfo3-02 performance has improved in c8cbf4b after 18 minutes.


Back-rev urllib3 to avoid later issues with Qdrant client

For some reason Qdrant client has the version of urllib3 set to <2.x.  Since we were pinning to a 2.x version this caused problems for the AI Assistant when we tried to update to the current Qdrant client version (older versions work because they lack the pinned requirement in the project file).

@sfitts, I'll try & pin urllib3 to >= 1.26.18 -- previous versions seem to have their own sets of CVE's.  Other things (extpsdk & associated python exec source, specifically) have a similar >= 2.0.7 pinning -- probably one came first & we just copied that across.  I don't know  if there are issues with earlier versions with the web sockets or aiohttp stuff we use -- I'll find out soonish.
It is, I'm assuming, sufficient here to change the python SDK.  If it's at >= 1.26.18, the upstream things will require something higher level and stuff should be fine (presuming you don't use those with the Qdrant SDK).