Invalid link description in generated API doc

Issue description
https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.mvc.apicontrollerattribute?view=aspnetcore-6.0#remarks has link name Cookie policy middleware, however, it actually leads to https://docs.microsoft.com/en-us/aspnet/core/web-api/#apicontroller-attribute.
I couldn't find any corresponding file for this doc to make a PR and also it doesn't have the "quick edit" button, so I suppose it was auto-generated.
Target framework

[x] .NET Core
[ ] .NET Framework
[ ] .NET Standard

You can update it here: https://github.com/dotnet/AspNetApiDocs/blob/main/aspnet-core/xml/Microsoft.AspNetCore.Mvc/ApiControllerAttribute.xml.
@Rick-Anderson Does this change need to be made in the source code though?


DFU device checking not foolproof

From the forums:
Somehow CLI tries to flash to a non-Particle device
And here's the output for particle flash --usb electron_firmware_1448459332199.bin when the bluetooth device is enabled.

Cannot open DFU device 0a5c:217f
Cannot open DFU device 0a5c:217f

Error writing firmware...Cannot open DFU device 0a5c:217f
Cannot open DFU device 0a5c:217f

Thanks for opening this one, I've definitely seen reports of this as well.  I wasn't sure if this was a bug in dfu-util, or the CLI, didn't we usually pipe out the DFU command before we run it?

We concentanate our own DFU command but the matching is not saying "no devices" found and went ahead to execute the DFU command

I cannot reproduce this, checking with the forum user for CLI version information.

I fixed this in a5a75ab2018d127ccf0ae2ef62fd34aaa04837a1


Get Common Name from a certificate loaded in ESP32 automatically. (IDFGH-5312)

Is there a method via which I can extract the CN from the certificate in esp directly, instead of manually passing it. Every single device that I have needs to have a separate device certificate and the device name on Azure IOT hub is derived from the common name of the certificate in the device. It is becoming very tedious now, since I have to keep track of more than 50 certificates and their common names, and have to manually change it the firmware before flashing the program onto esp.
A alternative that I am currently exploring is that i create a NVS partition which contains the common name. I can then use the mass_mfg tool to create different nvs partition files for each device using the csv, which is automatically generated by a python script which loops through all the certificates and gets their common name and stores it in the csv.

Mbedtls has x509 certificate parsing functions

@nexstem-siddhant

Is there a method via which I can extract the CN from the certificate

Please see following pointer that may help:
https://github.com/espressif/esp-idf/blob/c13afea635adec735435961270d0894ff46eef85/components/coap/port/coap_mbedtls.c#L301

I can then use the mass_mfg tool to create different nvs partition files for each device using the csv

This sounds all good and something that we would also recommend.

Hopefully that answers your question. Please feel free to re-open if you need additional information or raise a topic on esp32.com forum


Incomplete code

Hi!
I can't find the code you mention in your README. I wonder if something went wrong when staging/committing?
Would be great to see your code.
Best regards,
Michael

Apologies for the mistake! There should have been a link to this DOI in the STATUS.md file, but I believe it got replaced by mistake. You can find the code there: https://doi.org/10.6084/m9.figshare.7010474.v4


Secp and keccak hash

Motivation

Add support for ethereum signature verification to move language
// obtain public key from signature
// if signature is invalid, then zero key [0u8,20] is returned
native public fun recover(signature: vector, message: vector): vector;
// verify signature
native public fun verify(signature: vector, pubkey: vector, message: vector): bool;

Add support for keccak hash (ethereum sha3)
// Ethereum keccak_256 hash function
native public fun keccak_256(data: vector): vector;

Design considerations:

For recover/verify

[x] use older ethers-rs (0.1.3) library, newer ones are not compatible with rust we use
[x] recover() returns [0u8,20] (zero key vector) if signature is invalid. This is done to keep return type the same.
[x] gas for recover/verify is set to 3k as in ethereum erecover op. Both functions are essentially the same (validate signature)

For keccak hash

[x] add support for keccak-256 hashing used compatible with ethereum solidity hash
[x] add tests
[x] use XHash module name to add new hashes in future. This simplifies task of merging with the original diem tree
[x] gas for keccak is the same as for sha3_256 (64 units)
[x] run rustfmt on modified files
[x] tests passed :
cargo test 0L
test result: ok. 155 passed; 0 failed; 248 filtered out

Have you read the Contributing Guidelines on pull requests?
yes
Test Plan

Tests for recover/verify are added
tests for keccak hash are added

I think this is ready to go. We just need to think a little bit about how this is going to be released. I may keep it off the main branch until we have a new release branch. @dboreham  any thoughts?


feat: base widget standardization for dynamic height

Description
Here we are standardizing the BaseWidget abstract class so that all the widgets inheriting from this class will get a reference to the rendered container component which is nothing but a React forwarded ref. This class has a property called contentRef which we will pass to the rendered component.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
// Code coverage diff between base branch:release and head branch: feature/dh-stdzn-base-wdiget

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
app/client/src/widgets/BaseWidget.tsx
80 (0.16)
48.94 (0)
76.47 (0)
79.2 (0.17)

/ok-to-test sha=a9fb17b

/ok-to-test sha=6501ba5

/ok-to-test sha=fde44c4

/ok-to-test sha=7df8b38


Fix owner and lifecycle picker

Signed-off-by: Sarah Medeiros<EMAIL_ADDRESS>Hey, I just made a Pull Request!

This is still a work in progress.
I have been working on issue #12081 and this is my not fully implemented, proposed solution. Any feedback is appreciated.
Bug: Catalog table filters are not cleared when changing entity kind
Why does this happen? When the kind changes, the selected filters persist, even if that filter is not relevant to that kind. This creates a confusing experience for the user because no entities are shown (which they may not expect) and that picker disappears because it does not apply to that kind.
Solution: When setting the available options in the picker, if there are none (example no owners), then also update the selected options to be an empty array. This clears out the option that was previously selected when that filter does not apply to that kind.
This fix would need to happen in each picker file, but I didn't make all of those changes yet.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Not working
https://user-images.githubusercontent.com/14253893/206046296-517b4b26-53cd-4c94-ac55-90337327dca4.mov
Working
https://user-images.githubusercontent.com/14253893/206494044-cf61ad5c-35dd-4b73-9ccd-799cd86715e5.mov

Thanks for taking a look! @taras I can look into that more, but echoing what you said I do not think we have the needed data about the filters

Makes sense, I remember adding similar code in the useEntityTypeFilter hook. That actually goes a step further and removes any selected filters that are no longer possible, rather than just clearing the filters if none are available.
It would certainly be ideal to centralize the logic and remove any outdated filters when the entity list is updated. This isn't possible with the current filter architecture, as @Rugvip said.


Complete flow of Design Thinking

Please check the cvv input
and e-wallets container padding not matching with figma


Update .gitignore file

Summary:
Updated .gitignore file for stability and security.
Test Plan:
Checked that all the files mentioned are not read

Hi, thanks for the PR. How have you generated this list of “stability and security” enhancements here for the ignore file? I generally just add as things come up that I don’t want in the repo ...
I haven’t looked into why CI failed here, but if you get that to pass I’ll merge.

There is some problem with setup.py, ptr.py, ci.py and subprocess.py due to which error is being raised not because there is any problem in my updation. You can check the log as well as my file to confirm that.Thus, you can force merge the commits. 👍 😃
Thanks in Advance.

Ahh - new upstream typeshed has changed returncode to be an optional int - PR incoming.

Can you please explain your claim for stability and security that this PR addresses please. I'm just interested, cause I'll be honest, it does not make sense.
All this achieves is to just ignore files to no add to the repo ...

There is some problem with setup.py, ptr.py, ci.py and subprocess.py due to which error is being raised not because there is any problem in my updation. You can check the log as well as my file to confirm that.Thus, you can force merge the commits. 👍 😃
Thanks in Advance.

Typing Error fixed here:
https://github.com/facebookincubator/ptr/pull/96

There is some problem with setup.py, ptr.py, ci.py and subprocess.py due to which error is being raised not because there is any problem in my updation. You can check the log as well as my file to confirm that.Thus, you can force merge the commits. 👍 😃
Thanks in Advance.

Typing Error fixed here:
#96

ThankYou for fixing this 👍 😄

Can you please explain your claim for stability and security that this PR addresses please. I'm just interested, cause I'll be honest, it does not make sense.
All this achieves is to just ignore files to no add to the repo ...

Sure, This ignores all the files which are wastage and many people take it casually but, It also filters out some secret files which can accidently be thrown in front of the user like cache files which can leak out some vital information.
Hope I am able to  make you understand 👍 😃

Please merge this PR.

Thanks for the effort but I don’t agree with some of the entries and project does not need this. All the best.

So you can always suggest some edits. Please! 👍 😃 .But merging this will help


toc help is incorrect

Proof attached:
$ jupyter-book toc --help
usage: jupyter-book [-h] [--quiet] path_book

Execute all of the notebooks in a specified folder.

positional arguments:
  path_book   The path to a Jupyter Book.

optional arguments:
  -h, --help  show this help message and exit
  --quiet     Whether to suppress the final message box.

@choldgraf let me know if it's okay for you this way. I'm raising issues as I notice them.

this is perfect - the CLI is brand new and there are bound to be some bugs in there :-)


Slack is installed twice?

It appears you're installing Slack twice. Once via the Mac App Store and once via brew cask.

Good catch. Fixed in 25edc9464cbc30030c9556a1784e60c8d39479e0.


[Feature request] option for output consumer to output in it's own fixed window/panel

First of all, thanks for working on neotest! I'm looking for the right workflow(s), also peeking at other established editors.
I think it would be be helpful if the output consumer, optionally, can open_output in it's own fixed and separate window at the bottom, just like the summary has it's own fixed panel on the right (positions configurable + possible to just manipulate like any other window). Together with open_on_run, you would get a classic IDE experience like
--------------------------------------------
|                                          |
|              code/test                   |
|       (keymap to run last test)          |
|                                          |
|------------------------------------------|
|                                          |
|             test results                 |
|     (auto update + scroll to bottom)     |
|                                          |
-------------------------------------------|

What do you think?

Thinking about this, it might make more sense as a separate consumer as the flows would likely be quite different. VS Code for example appends new output to the existing window which I think makes the most sense here as output disappearing on reruns would be annoying if the whole point is to be persistent.
So I'm thinking something like an output_panel as a consumer which when a test runs will append the output to the window that it maintains. If a group of tests is run, the top level position (e.g. directory) will have its output used put into the panel. This will work for most cases but may have issues with adapters that provide different outputs for each position such as neotest-plenary where it will have a separate output for each file. I'm not sure of the best way to handle this, just go through all the results and append all of them? Open to suggestions

I think that just appending would be a great start!

I've got this in a PR, would appreciate if people would check it out and let me know of any issues https://github.com/nvim-neotest/neotest/pull/153. I'll leave it there for a few days to test, but it should be good to go :smile:

@rcarriga I just tried it out, it works good! 💪🏻  I have couple of suggestions for future improvements:

scroll to bottom on open (maybe only the first time after tests are executed)
append output as tests are running, so that on_attach function doesn't have to be called

Thanks for testing!

scroll to bottom on open (maybe only the first time after tests are executed)

This can be done by using the following:
  vim.api.nvim_create_autocmd("FileType", {
    pattern = "neotest-output-panel",
    callback = function()
      vim.cmd("norm G")
    end,
  })

append output as tests are running, so that on_attach function doesn't have to be called

Unfortunately that won't work because multiple processes can be running at once (either multiple runs by the user or multiple processes spawned internally due to how adapters can work) and so the output would be mixed. Adapters can also transform the output from machine readable formats such as JSON to human readable text so we can't just show the raw output from test processes.

I've found no issues so it's been merged :smile:

Perhaps I am using the feature wrong but this is what i found using neotest-go.
The test file:
package main

import (
	"testing"
)

func TestFoo(t *testing.T) {
	t.Error("Foo is not working")
	t.Fail()
}

func TestBar(t *testing.T) {
	t.Error("Bar is not working")
	t.Fail()
}

Running the entire suite gives both the "raw" json ouput which the test adapter uses and the parsed ouput. These seem to come in random order:
{"Time":"2022-11-23T09:19:21.869175+01:00","Action":"run","Package":"neotest-test","Test":"TestFoo"}
{"Time":"2022-11-23T09:19:21.869446+01:00","Action":"output","Package":"neotest-test","Test":"TestFoo","Output":"=== RUN   TestFoo\n"}
{"Time":"2022-11-23T09:19:21.869463+01:00","Action":"output","Package":"neotest-test","Test":"TestFoo","Output":"    foobar_test.go:8: Foo is not working\n"}
{"Time":"2022-11-23T09:19:21.869482+01:00","Action":"output","Package":"neotest-test","Test":"TestFoo","Output":"--- FAIL: TestFoo (0.00s)\n"}
{"Time":"2022-11-23T09:19:21.869491+01:00","Action":"fail","Package":"neotest-test","Test":"TestFoo","Elapsed":0}
{"Time":"2022-11-23T09:19:21.869509+01:00","Action":"run","Package":"neotest-test","Test":"TestBar"}
{"Time":"2022-11-23T09:19:21.869513+01:00","Action":"output","Package":"neotest-test","Test":"TestBar","Output":"=== RUN   TestBar\n"}
{"Time":"2022-11-23T09:19:21.869516+01:00","Action":"output","Package":"neotest-test","Test":"TestBar","Output":"    foobar_test.go:13: Bar is not working\n"}
{"Time":"2022-11-23T09:19:21.86952+01:00","Action":"output","Package":"neotest-test","Test":"TestBar","Output":"--- FAIL: TestBar (0.00s)\n"}
{"Time":"2022-11-23T09:19:21.869887+01:00","Action":"fail","Package":"neotest-test","Test":"TestBar","Elapsed":0}
{"Time":"2022-11-23T09:19:21.869904+01:00","Action":"output","Package":"neotest-test","Output":"FAIL\n"}
{"Time":"2022-11-23T09:19:21.869921+01:00","Action":"output","Package":"neotest-test","Output":"coverage: 0.0% of statements\n"}
{"Time":"2022-11-23T09:19:21.870142+01:00","Action":"output","Package":"neotest-test","Output":"FAIL\tneotest-test\t0.131s\n"}
{"Time":"2022-11-23T09:19:21.870172+01:00","Action":"fail","Package":"neotest-test","Elapsed":0.132}
=== RUN   TestFoo
                     foobar_test.go:8: Foo is not working
                                                         --- FAIL: TestFoo (0.00s)
                                                                                === RUN   TestBar
                                                                                foobar_test.go:13: Bar is not working
                                                                                --- FAIL: TestBar (0.00s)

Running a single test does not include the raw json output but the indentation issue is still there.
How the output looks seem to depend on some neovim settings such as expandtab and shiftwidth.
However no matter what settings I use, I cannot seem to make the ouput look correct.
Running the test multiple times just continues the indentation issue.
=== RUN   TestBar
                     foobar_test.go:13: Bar is not working
                                                          --- FAIL: TestBar (0.00s)
                                                                                === RUN   TestBar
                                                                                foobar_test.go:13: Bar is not working
                                                                                --- FAIL: TestBar (0.00s)
                                                                                === RUN   TestBar
                                                                                foobar_test.go:13: Bar is not working

@akarl Both of these issues should now be fixed in latest master :smile:
Closing this as the feature request has been fulfilled, anything else can be a new issue


Update permissions-reference.md

"Read-only" would make sense if it was alone. "Read-only and" doesn't make sense, it's no longer "only"

@nickadam : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @nickadam
Thanks for your contribution. We'll get your change merged.
thanks!

#sign-off


Add bootstrap distributions to results

Depends on #31, its dependency #30, and its dependency #26.
This is a small change to actually include all the bootstrap distributions in the results.  This adds to the output of OaxacaBlinderDecomp() but doesn't change or remove anything.
Here is the old structure of results$bootstraps:

overall

data frame with metrics (e.g., se, CI boundaries) as columns and term types (e.g., endowments etc.) as rows

varlevel

data frame with metrics (e.g., se, CI boundaries) as columns and term-type/term pairs as rows

Here is the new structure:

overall

data frame with metrics (e.g., se, CI boundaries) as columns and term types (e.g., endowments etc.) as rows

varlevel

data frame with metrics (e.g., se, CI boundaries) as columns and term-type/term pairs as rows

dists

overall
list of term types, each containing a data frame with the column "overall" and each bootstrap run as rows
varlevel

list of term types, each containing a data frame with term names as columns and each bootstrap run as rows

I do think that ultimately it'd be a little more elegant to have the distributions and the summaries at the same level, something like this:

bootstraps

overall

summaries
distributions

varlevel

summaries
distributions

... or perhaps with the finest- and next-finest levels reversed.  However this would break the existing hierarchy, so I've put the new $dists element alongside the old ones for now.
Nothing in the generics touch this yet, so this shouldn't affect users much unless they go looking for it.
A similar PR for the bootstrapped gaps is coming shortly.
@sinanpl, of course let me know if anything needs clarification!

Oh, by the way, the motivation for this PR is from this stackexchange comment, which, in addition to recommending a zillion bootstrap runs, recommends looking at histograms of the bootstrap distribution to ensure that it looks "regular".

As in https://github.com/sinanpl/OaxacaBlinder/pull/34#issuecomment-2065349954, this has been updated so that the name of the single column in each element of the overall bootstrap distribution list is "estimate" instead of "overall".


selectorcache: Move identity alloc/release outside of critical section

Michi and Maciej report that they can trigger a deadlock as part of FQDN
SelectorCache preparation:
goroutine 873 [chan send, 969 minutes]:
github.com/cilium/cilium/pkg/identity/cache.(*localIdentityCache).lookupOrCreate(0xc00096b440, 0xc0011baf00, 0x0, 0xc000f4c800, 0x0, 0x0)
/go/src/github.com/cilium/cilium/pkg/identity/cache/local.go:106 +0x32a
github.com/cilium/cilium/pkg/identity/cache.(*CachingIdentityAllocator).AllocateIdentity(0xc0001decc0, 0x2f6c4a0, 0xc00263e660, 0xc0011baf00, 0xc000a18400, 0x0, 0x2ed1e00, 0x0, 0x0)
/go/src/github.com/cilium/cilium/pkg/identity/cache/allocator.go:377 +0xbfa
github.com/cilium/cilium/pkg/ipcache.allocateCIDRs(0xc001031000, 0x816, 0x816, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
/go/src/github.com/cilium/cilium/pkg/ipcache/cidr.go:105 +0x27d
github.com/cilium/cilium/pkg/ipcache.AllocateCIDRsForIPs(0xc0010ce000, 0x816, 0x955, 0x0, 0x0, 0x0, 0x8000101, 0x0, 0xffffffffffffffff)
/go/src/github.com/cilium/cilium/pkg/ipcache/cidr.go:66 +0x71
github.com/cilium/cilium/daemon/cmd.cachingIdentityAllocator.AllocateCIDRsForIPs(0xc0001decc0, 0xc0010ce000, 0x816, 0x955, 0x0, 0x252fbe0, 0xc00076ca38, 0x2598940, 0xc00148a610, 0x0)
/go/src/github.com/cilium/cilium/daemon/cmd/identity.go:124 +0x4d
github.com/cilium/cilium/pkg/policy.(*fqdnSelector).allocateIdentityMappings(0xc0012cfa40, 0x7fe4824e20f8, 0xc0001decc0, 0xc0013b9050)
/go/src/github.com/cilium/cilium/pkg/policy/selectorcache.go:502 +0x2dd
github.com/cilium/cilium/pkg/policy.(*SelectorCache).AddFQDNSelector(0xc000483420, 0x2f0dc80, 0xc001848f00, 0xc000fcef40, 0x32, 0x0, 0x0, 0x0, 0x0, 0x0)
/go/src/github.com/cilium/cilium/pkg/policy/selectorcache.go:831 +0x3db
...

goroutine 440 [semacquire, 969 minutes]:
sync.runtime_SemacquireMutex(0xc000483424, 0xc001163500, 0x1)
/usr/local/go/src/runtime/sema.go:71 +0x47
sync.(*Mutex).lockSlow(0xc000483420)
/usr/local/go/src/sync/mutex.go:138 +0x105
sync.(*Mutex).Lock(...)
/usr/local/go/src/sync/mutex.go:81
sync.(*RWMutex).Lock(0xc000483420)
/usr/local/go/src/sync/rwmutex.go:111 +0x90
github.com/cilium/cilium/pkg/policy.(*SelectorCache).UpdateIdentities(0xc000483420, 0xc0009685a0, 0xc0009685d0, 0xc000699e40)
/go/src/github.com/cilium/cilium/pkg/policy/selectorcache.go:960 +0x55
github.com/cilium/cilium/daemon/cmd.(*Daemon).UpdateIdentities(0xc0002ed8c0, 0xc0009685a0, 0xc0009685d0)
/go/src/github.com/cilium/cilium/daemon/cmd/policy.go:99 +0x6a
github.com/cilium/cilium/pkg/identity/cache.(*identityWatcher).watch.func1(0xc000655140, 0xc0001decf8)
/go/src/github.com/cilium/cilium/pkg/identity/cache/cache.go:205 +0x20c
created by github.com/cilium/cilium/pkg/identity/cache.(*identityWatcher).watch
/go/src/github.com/cilium/cilium/pkg/identity/cache/cache.go:154 +0x49

Commit b10797c7d87b ("fqdn: Move identity allocation to FQDN selector")
contains the following fateful quote in its commit message:

This commit should have no functional changes. Technically the identity
allocation is moved inside the SelectorCache critical section while
holding the mutex, but CIDR identities are only ever locally allocated
within memory anyway so this is not expected to block for a long time.

Evidently, the author (yours truly) was unaware that deep in the local
identity allocator, it holds a notification mechanism to notify the rest
of the SelectorCache about the newly allocated identity; or indeed that
this in itself would also attempt to grab the SelectorCache.mutex in
order to propagate this identity into the rest of the policy subsystem.
On average, this issue would not trigger a deadlock as there is a
channel between the two goroutines at the beginning of this PR
message. As long as the channel does not become full, and the goroutines
are handled by different OS threads, the first goroutine above would not
stall at (*localIdentityCache).lookupOrCreate() and would instead proceed
to release the SelectorCache.mutex, at which point the identityWatcher
from the second goroutine could acquire the mutex and make progress.
However, in certain cases, particularly if many IPs were associated with
a single FQDN, and policy recalculation was triggered (perhaps due to
creation of a new pod or new FQDN policies), the deadlock could be
triggered by filling up the channel.
This PR fixes the issue by pushing the identity allocation and release
outside of the critical section of the SelectorCache, so that even if there
are many queued identity updates to handle and they fill up the channel,
first goroutine will block at (*localIdentityCache).lookupOrCreate()
without holding the SelectorCache.mutex. This should allow the second
goroutine to make progress regardless of the channel filling up or the
first goroutine blocking.
Fixes: #17788
Fixes: b10797c7d87b ("fqdn: Move identity allocation to FQDN selector")
Reported-by: Michi Mutsuzaki<EMAIL_ADDRESS>Reported-by: Maciej Kwiek<EMAIL_ADDRESS>Signed-off-by: Joe Stringer<EMAIL_ADDRESS>Fix bug where FQDN policy calculation could trigger a deadlock in cilium-agent

/test

Adding the needs/e2e-test, but I don't currently have plans for that. I think we could look at adding some sort of testing where we reduce the capacity of channels in the daemon and try to pick up any similar sorts of deadlocks, but I see that as a general testing initiative that I don't currently have cycles to dig into.
@michi-covalent  has a testing environment where he was able to trigger the deadlock in the first place, so I will rely on his dutiful testing to valide the fix for now.

k8s-1.22-kernel-4.19 job hit known flake #18318.

fwit i've been running cilium with this patch applied since yesterday, and i haven't hit the deadlock issue so far. i'll keep it running over the weekend.

/test

k8s-1.23-kernel-net-next job failed vm provisioning, re-running.
EKS encryption seems broken, we just tried re-enabling that. It''s likely it's not stable.
GKE / External Workloads / Multicluster all failed provisioning on GKE, assuming there's some infra problem on that side.

/test-1.23-net-next

EKS failure is in the encryption test which was just re-enabled in the tree, there's no other failures and I don't see any way that this fix could interact with the encryption code on EKS. All reviews are now in. Bypassing CI to merge this fix.


Persian Language Support in SSMS

Hi, Why don't you add Persian language support for SSMS?

@alikiaee -- Alireza, thank you for your question from Tehran.  Please add it here:

SQL Server feedback

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.

Ok, Thanks.


Add example of a categorical map plot

@victoria-cherkas : Thanks for you review. Are you happy with my updates or anything more to change?

Thanks for the changes, looks good to me!


Minor code formatting improvement

needs to be indented one more time, wanna fix and resubmit?

Sure i would, but can't get the indentation to work while keeping the code formatted. Not very familiar with the markdown syntax (yet).

closing


NNBD: the least and greatest closure of a type does not use Object? in runtime.

Dart VM version: 2.8.0-dev.20.0 (dev) (Fri Apr 3 10:19:55 2020 +0200) on "windows_x64"
The following source code example throws a compile error with analyzer and passes printing true in runtime:
bool Function(T) predicate<T>(bool Function(T) fn) => (T val) => fn(val);

void main() {
  print(predicate((v) => v % 2 == 1)(3));
}

According to the recent nnbd spec update it should throw a compile error in both cases.
Sample output is:

$> dartanalyzer --enable-experiment=non-nullable test.dart
Analyzing test.dart...
error - The expression is nullable and must be null-checked before it can be used. - test.dart:4:26 - use_of_nullable_value
1 error found.
$> dart --enable-experiment=non-nullable --null-safety test.dart
true

@johnniwinther @leafpetersen - this appears to be a missing error in the cfe.  Please re-triage if I got that wrong.

Yes, this is a missing error.  The downwards context for the parameter to predicate should be bool Function(?), so the inferred parameter type of v should be the greatest closure of ? which is Object? in nnbd.

@leafpetersen Where is the specification for this?

About the null-safety specific changes to the greatest/least closure operations, there is this section.
For the locations where these operations are used, there is inference.md, but you may need to look at the large comment at the end.

Wouldn't this mean that map in
var map = {};

is now inferred to have type Map<Object?, Object?> ?

There is a distinction between the greatest closure, which is used for function literal type inference, and instantiation to bound, which is used to select the type arguments passed to a generic function invocation when no constraints apply. The latter chooses dynamic, and that would also apply to instance creations and to collection literals.
@leapetersen, do you agree?

And where is the definition of this distinction?

For the code in the example, does it mean I should infer:
bool Function(T) predicate<T>(bool Function(T) fn) => (T val) => fn(val);

void main() {
  print(predicate<dynamic>((Object? v) => v % 2 == 1)(3));
}

That is, dynamic for the type parameter and Object? for parameter even when these are linked by  T ?

I would say "yes". However, cf. https://github.com/dart-lang/language/issues/908#issuecomment-607753083, I'm sure @leafpetersen can add detail and background.

I can't see why and how we should have a disconnect between the value for T implied by the argument type (inferred or not). If we have
class Class<T> {
  Class(void Function(T));
}
void function1(String o) {}
void function2(Object? o) {}
void function3(dynamic o) {}
main() {
 new Class(function1);
 new Class(function2);
 new Class(function3);
 new Class((o) {});
}

shouldn't we use the type of the argument to compute the type argument for Class in all cases:
class Class<T> {
  Class(void Function(T));
}
void function1(String o) {}
void function2(Object? o) {}
void function3(dynamic o) {}
main() {
 new Class<String>(function1);
 new Class<Object?>(function2);
 new Class<dynamic>(function3);
 new Class<Object?>((Object? o) {});
}

?

A CL is in progress: https://dart-review.googlesource.com/c/sdk/+/144940

That is, dynamic for the type parameter and Object? for parameter even when these are linked by T ?

No.  Sorry, I realize this part of the spec is in a tremendously bad state, and I'm not happy with where the language is either, but for path dependent reasons this is where we are.
The relevant distinction is between types which arise by "closing" a type schema, vs types which arise from choosing a final generic instantiation in an under-constrained inference problem.  There's no essential reason for doing a different thing here - it's just that for historic reasons we used dynamic everywhere, and for usability reasons we're trying to shave away uses of dynamic at the margins.
To elaborate.  There are certain points in inference when we have a type schema (by which I mean a type which may contain placeholders, which I usually write ?), and need to reify it as a type.  For example, during downwards inference, the "context type" is really a "context type schema".  Greatest/least closure defines how we get from a "type schema" to a type, essentially by replacing all of the ? by a top or bottom type depending on the variance of their position of occurrence. So in the original example, we have a downwards context of bool Function(?), and  hence a parameter type schema of ? which we need to turn into a type so that we can do inference on the body of the lambda.  Greatest closure used to produce dynamic here, the change for null safety is that it produces Object?.  As a result, inference fills in the lambda as (Object? v) => ... and then upwards inference fully constrains T to be Object? as you observe.
The instantiation to bound comes in when we've completed the inference process, and we have type variables which are still under-constrained.  Hence an example like void foo<T>(int x) {print(T);};  foo(3);.   After doing downwards inference on 3 in context int, we do upwards inference, and we end up with T being still totally unconstrained.  At this point, in a last minute desperation move, we use instantiation to bounds to try to produce something useful for T.  Instantiation to bound is still defined to substitute dynamic for unresolved things, and so... we end up producing foo<dynamic>(3) as the inference solution.
For generic functions, it's plausible that we could make this final instantiate to bounds step use Object? instead of dynamic, but... we haven't taken that step yet.  For types, it would be hugely breaking (but also, I think hugely beneficial).

shouldn't we use the type of the argument to compute the type argument for Class in all cases:

Yes.  Your filled in types for Class are all what I expect here.


Adding more information to callback errors

This should have been taken care of in ac33956 (http://cl.ly/1S37370f0I18)


App crashes when entering in the unified inbox

Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
Expected behavior
Open Unified Inbox
Actual behavior
App crashes
Steps to reproduce

Just tap on the unified inbox
The app crashes

Environment
K-9 Mail version: 5.700-SNAPSHOT
Android version: 7.1.1 Nougat (LineageOS)
Account type (IMAP, POP3, WebDAV/Exchange):

Works for me. Please provide a stack trace.

Same issue for me with a clean build of today:
unified_inbox_crash.log

I believe this has been fixed.


UX Backlog

Intro
This backlog is a collection of items related to the user experience of the product. Design will use this list as a discussion point for iteration planning as well as discussions with the team during our weekly ux sync. Additionally, we will use our design principles and design checklist to guide the process for designing and implementing this work.
The backlog is split up into three parts: Existing users, New users, and Not yet incorporated.
Backlog
Existing users

[x] Review code at your finger tips: hover, completion items, completion item details https://github.com/Microsoft/vscode/issues/63144

css completions showing MDN info
fonts, colors, etc. in completion items and completion details, hovers

[x] Update Octicons https://github.com/Microsoft/vscode/issues/65508
[x] Iconography re-design https://github.com/Microsoft/vscode/issues/8017, https://github.com/Microsoft/vscode/issues/44594
[x] Explore settings sync UX https://github.com/microsoft/vscode/issues/78869
[x] :running_man: Explore Extensions Management UX #68527

Improve the Show Running Extensions experience
Explore the best way to show additional meta information (running, start time)
Show this information on the extension detail view https://github.com/Microsoft/vscode/issues/64344

[x] Improve Find All References https://github.com/Microsoft/vscode/issues/22261

Implications for the monaco editor
Can this be done in the search viewlet instead?
Better empty selection state

[x] Overflow and customization for status bar https://github.com/Microsoft/vscode/issues/6651, https://github.com/Microsoft/vscode/issues/35744, https://github.com/Microsoft/vscode/issues/3874
[x] Make hover/suggest presentation consistent https://github.com/microsoft/vscode/issues/78718
[ ] Revisit extension recommendation end-to-end experience (on file load, ext. viewlet, etc.)
[x] :runner: Improve Search when position is moved to panel https://github.com/Microsoft/vscode/issues/64418

The search icon is gone, making it harder to remember to use the keyboard shortcut
The over layout panel is not a good user of space

[x] Ability to move views into separate viewlets/panels (universal layout)

Ability to minimize panels

[x] Ability to pin tabs https://github.com/Microsoft/vscode/issues/12622
[ ] Improve creating a new file/folder when explorer has content and when hidden

We should show a quickpick that has the path pre-populated

[ ] Add touch support https://github.com/microsoft/vscode/issues/70764
[x] Better experience for dynamic views/viewlets

Find all references
Hiding an activity bar item & accessing it

[ ] Explore Hiding titlebar on Mac https://github.com/Microsoft/vscode/issues/12377
[ ] Explore Fluent Design https://github.com/Microsoft/vscode/issues/26572, https://github.com/Microsoft/vscode/issues/17060, https://github.com/Microsoft/vscode/issues/12578, https://github.com/Microsoft/vscode/pull/52707
[ ] Extension welcome pages and release notes

Potentially show an area on the welcome page for release notes and recently updates

Add "Recently updated" as a keyword option in the extension viewlet
Show diagnostics tab when in this view
Default tab would go to changelog from this view

[x] Explore ways for the community to contribute to designs in the same way as code is contributed https://github.com/microsoft/vscode-figma-toolkit
[x] Identify design inconsistencies with UI + JSON expriences #84309
[x] Add guidelines for extension authors https://github.com/microsoft/vscode/issues/104006

New users

[ ] First user onboarding experience

[x] :runner: Welcome page https://github.com/Microsoft/vscode/issues/63152
[ ] :runner: Stacking of notifications (particularly when on non-English locales)
[ ] Playground
[ ] UI overview
[x] Loading of webpage on first launch
[ ] Guidance to install extensions

[x] :runner: Website re-design

roadmap outlining incremental steps to a friendlier, more modern website
Internationalization
Reducing visual noise
Use web-worker

[x] Improve discoverability for regular expression (boolean operators) in search and find widget (Ref: https://github.com/Microsoft/vscode/issues/66206)
[ ] Discoverability: How do we raise awareness of functionality?

Using web worker to show functionality on website
Use tool as to learn t

[ ] Update default theme colors with modern color palette (Fluent?)
[ ] Define a color system for color tokens

These issues should get some priority. #52707 was ready but wasn't merged.
Visuals are as important as new features

Can we also add 32257?
Thanks for the awesome editor 💖

what's about allowing custom background image?! something like

Could you please let us know if the topmost feature in the list take longer time to be merged?

@zbandhan which item are you referring to?

@misolori referring to #63144

I see that boolean search references here, and that ticket is closed and mentioned as having been added to this list, but it seems that it never actually was added to the list.
Boolean search is an essential feature, and regex search isn't really a replacement for it. Certain operations, like looking for all files that contain "email" AND "receipt" are trivially easy in a standard boolean search and devilishly difficult to phrase effectively in regex.

 Does it mean part of the current sprint?

@lambainsaan they're not all necessarily tied to a milestone, it just means we are actively working on it or have efforts in place to be working on them. You can think of it as being "active".

Hi @misolori quick question about “Add touch support #70764”. In order for VS Code to be on iPadOS, is the main blocker more about the Apple App Store/Electron/HTML5 policy? Or it’s something smaller like touch support?
For a long time I thought it’s the Apple’s policy that makes it difficult for VS Code to land, but since you use “Add touch support” as the title there, I’m just a little confused. Thank you very much!

@misolori, It would be cool, if they will publish VS Code for iPadOS, but, i think, touch support is only support for touch-screens in browser version of vsc (online.visualstudio.com) :(

@tclzcja @lujo777 the touch support issue is to support Visual Studio Online, we don't have any current plans to create an iOS app.

Closing this issue as most items are complete and we've created a new, revamped, version in #146840


Bind the cookie to ITlsTokenBindingFeature

If the cookie is marked as Secure (https://github.com/aspnet/Session/issues/106), bind it to the TLS token (https://github.com/aspnet/Security/issues/773, https://github.com/aspnet/IISIntegration/issues/31)

@muratg this should be backlogged, the underlying infrastructure from IIS, WebListener, and Kestrel.Https isn't ready.

This issue was moved to aspnet/Home#2406


Add settings after how many m² the device should return to the dock to clean the mop-pads

Is your feature request related to a problem? Please describe.
Describe the solution you'd like
in the Xiaomi-App you can set after how many m² the robot should return to the dock and clean the mop-pads (also refilling the internal water tank).
The lowest setting in the app is 10 m² up to (currently unknown, because I cannot check the app right now)...
Anyway - I would like to see a setting that would also support lower values - for example 5 or 8 m² because I think, the internal tank does not store enough water for 10 m²
Maybe, this can somehow be acheived with an script or automation... but having at least the same configuration parameter like the app does would be great :)
Describe alternatives you've considered
Additional context

found the setting... strange, that I haven't seen it earlier... o.O

Hi, just to verify:
This is the setting I've found - and I think, that's pretty much the same as shown in the Xiaomi App where you can select after how many m² the robot should return to the dock...?!


clusterrole missing cm permission

It seems that the clusterrole trivy-operator does not allow creating configmaps. This prevents trivy-operator from starting;
 {"level":"info","ts":1657706766.2230577,"logger":"controller-runtime.metrics","msg":"Metrics server is starting to listen","addr":":8080"}                                     │
│ unable to run trivy operator: initializing Trivy plugin: configmaps is forbidden: User "system:serviceaccount:trivy-system:trivy-operator" cannot create resource "configmaps" │
│  in API group "" in the namespace "trivy-system"

How do you provision trivy-operator? There is a Role that should allow trivy-operator to create configmaps in the trivy-system namespace:
https://github.com/aquasecurity/trivy-operator/blob/7ddaac9fd1dbe6b0ca4bf47732c2e73118bb4bd9/deploy/static/trivy-operator.yaml#L934-L954

@githubcdr in version of trivy-operator was it occur ?

0.1.3

0.1.3, I noticed the clusterrole is missing the permissions.

Why should the clusterrole include permissions to create configmaps cluster-wide? By the error message, it seems like you are missing the role and rolebinding.

@githubcdr Maybe close this issue? 😄


use only Twist not TwistStamped

This removes the TwistStamped. The Stamp information was unused.
This makes it easier to use with teleop_twist_joy
In the future we plan to add a TwistStamped version which can be configured

@abake48 this hasn't been tested on hardware yet.

Perfect, I also tested this today:
ros2 run teleop_twist_keyboard teleop_twist_keyboard --ros-args --remap /cmd_vel:=/twist_controller/commands

I will update the documentation in ros2_kortex and re-release everything


DATA (read-only opened) can not be locked by File#flock on Solaris

See https://github.com/ruby/rubyspec/issues/121

Thank you :smiley:


Make video widgets

@jaburgoyne what would be the requirements / scope of a video component? I have some questions:

Which platforms / sources should it support? Youtube, Vimeo, Self-hosted, Externally-hosted?
In case of self-hosted, are we talking about strictly playing videos or also GIFs / animations?
Should it support auto playback, auto repeat, and should we give the user to pause / stop / restart the video?
Should the component be "interactive", e.g. the user clicks somewhere in the video and we record the timestamp and location of the click event?
Should the component "know" the length of the video and / or should we be able to know when the video ends, allowing the parent component to "do something" once the video ends? E.g. showing a button or going to a next page / trial after the video ends.

I would say that what we can do now with embedding in an Info widget should suffice for our needs. Yes, the player is out of our control then, but it also means we don't have to implement it from scratch.


HiveError: The box "boxName" is already open and of type Box

Steps to Reproduce
I`ve created custom adapter ArticleAdapter.
But have 2 issues:

When i try to register with Hive.registerAdapter(ArticleAdapter()), i receive an error

The argument type 'ArticleAdapter' can't be assigned to the parameter type 'TypeAdapter'. (argument_type_not_assignable at [eton_news_test] lib/core/services/hive_service.dart:24)
So the only way is working is to write Hive.registerAdapter(ArticleAdapterAdapter())

When i try to access to read data from the box by

static Article loadArticle(String id) {
    Box<Article> box =  Hive.box (BoxNames.ARTICLES_BOX);
    return  box.get(id);
  }

I receive an error:

Unhandled Exception: HiveError: The box "articlesbox" is already open and of type Box.

Code sample
import 'package:eton_news_test/core/domains/articles/author.dart';
import 'package:eton_news_test/core/domains/domains.dart';
import 'package:hive/hive.dart';

part 'article_adapter.g.dart';

@HiveType(typeId: 0)
class ArticleAdapter {
  @HiveField(0)
  String authorId;
  @HiveField(1)
  Author author;
  @HiveField(2)
  DateTime createdAt;
  @HiveField(3)
  String id;
  @HiveField(4)
  List<String> likes;
  @HiveField(5)
  List<MobileTextBlock> content;
  @HiveField(6)
  MobileTextBlock mainContent;
  @HiveField(7)
  MobileMediaBlock mainMedia;
  @HiveField(8)
  MobileMediaBlock mainMediaPreview;
  @HiveField(9)
  MobileTextBlock subtitle;
  @HiveField(10)
  MobileTextBlock title;
  @HiveField(11)
  String ownerId;
  @HiveField(12)
  String projectId;
  @HiveField(13)
  bool rtl;
  @HiveField(14)
  String language;
}

Version

Platform: iOS, Android, Mac, Windows, Linux, Web
Flutter version: [e.g. 1.5.4]
Hive version: [e.g. 0.5.0]

Please update your Hive version. There have been many releases since v0.5.0 and I think it is not worth investigating an old bug.

I`m using the most recent Hive version 1.4.1

Box box =  Hive.box(BoxNames.ARTICLES_BOX);

I`m using the most recent Hive version 1.4.1

Box <Article> box = Hive.box<Article>(BoxNames.ARTICLES_BOX);

Steps to Reproduce
I`ve created custom adapter ArticleAdapter.
But have 2 issues:

When i try to register with Hive.registerAdapter(ArticleAdapter()), i receive an error

The argument type 'ArticleAdapter' can't be assigned to the parameter type 'TypeAdapter'. (argument_type_not_assignable at [eton_news_test] lib/core/services/hive_service.dart:24)
So the only way is working is to write Hive.registerAdapter(ArticleAdapterAdapter())

When i try to access to read data from the box by

static Article loadArticle(String id) {
    Box<Article> box =  Hive.box (BoxNames.ARTICLES_BOX);
    return  box.get(id);
  }

I receive an error:

Unhandled Exception: HiveError: The box "articlesbox" is already open and of type Box.

Code sample
import 'package:eton_news_test/core/domains/articles/author.dart';
import 'package:eton_news_test/core/domains/domains.dart';
import 'package:hive/hive.dart';

part 'article_adapter.g.dart';

@HiveType(typeId: 0)
class ArticleAdapter {
  @HiveField(0)
  String authorId;
  @HiveField(1)
  Author author;
  @HiveField(2)
  DateTime createdAt;
  @HiveField(3)
  String id;
  @HiveField(4)
  List<String> likes;
  @HiveField(5)
  List<MobileTextBlock> content;
  @HiveField(6)
  MobileTextBlock mainContent;
  @HiveField(7)
  MobileMediaBlock mainMedia;
  @HiveField(8)
  MobileMediaBlock mainMediaPreview;
  @HiveField(9)
  MobileTextBlock subtitle;
  @HiveField(10)
  MobileTextBlock title;
  @HiveField(11)
  String ownerId;
  @HiveField(12)
  String projectId;
  @HiveField(13)
  bool rtl;
  @HiveField(14)
  String language;
}

Version

Platform: iOS, Android, Mac, Windows, Linux, Web
Flutter version: [e.g. 1.5.4]
Hive version: [e.g. 0.5.0]

Box <Article> box = Hive.box<Article>(BoxNames.ARTICLES_BOX);

Facing same issue, using latest version
hive: ^2.0.4
hive_flutter: ^1.0.0

this was good and stable library, null-safety enhancement broke your package.


Ingress removal storage svc

Description
This PR removes the storage-service ingress from the RPM, adds storage-service handlers to the proxy-server, updates karavictl to connect to the proxy-server instead of the storage-service, and adds telemetry updates.
Proxy-Server changes:
New service handler at internal/proxy/service_handler.go to handle these paths for karavictl:
POST /proxy/storage/ (create storage, storage info is in request body)
PATCH /proxy/storage/ (update storage, storage info is in request body)
GET /proxy/storage/ (list or get storage, storage name is in query parameter)
PATCH /proxy/storage/ (storage info is in request body)
The handlers for each path will parse the request and make the appropriate grpc request to the storage service.
Adds grpc connection interceptors which will automatically create tracing spans for grpc client requests.
New http middleware called TelemetryMW. This will log the time taken for the next handler to complete and record the error in the span. The telemetry will happen only if the next handler is the type HandlerWithError. This handler returns an error specifically for recording in the span.
type HandlerWithError func(w http.ResponseWriter, r *http.Request) error
karavictl changes:
karavictl commands that previously connected to the storage-service via grpc now connect to the proxy-server via https
New file cmd/karavictl/cmd/api/api.go which is a generic http client inspired by https://github.com/dell/goscaleio/blob/main/api/api.go
karavictl will build this generic http client and execute the appropriate request
Storage-service changes:
Adds grpc server interceptors which will automatically create tracing spans for incoming requests.
Adds telemetry middleware at internal/storage-service/middleware/storage_telemetry.go to log the time taken for the request, log request info, and set the request info in the span
Most if not all code is similar to Tenant-service changes made by Aaron Tye
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/725

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[ ] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Backward compatibility is not broken

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Powerflex E2E Test, and manual test (Containerized, RPM, and CSM-Operator)

run e2e test

run e2e test

run e2e test


⚠ Bofrost.fr has degraded performance

In 74260c4, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 926 ms

Resolved: Bofrost.fr performance has improved in a2adcba.


New header design: icons, app colors and edit text mode

Task/Issue URLs
Icons: https://app.asana.com/0/72649045549333/614787299259405
Colors: https://app.asana.com/0/72649045549333/614787299259403
SearchBar: https://app.asana.com/0/72649045549333/614787299259402
Description:
Adds new header design
Steps to test this PR:
Run the app and check that
• The icons and colors are updated
• The edit text mode hides other icons and shows new background when in edit mode
NOTE: There is a separate task to add a "count" to the tabs button.

Looking good!
Can the following buttons also be made the right kind of grey to make them consistent:

Settings -> Done
Bookmarks -> Done
Bookmarks -> Edit

Also, on iPad (checked 9.7inch and 12.9inch) the up arrow isn't quite aligned with the centre of the privacy grade. (see screenshot to follow)

@brindy good thinking regarding the button colors, they should be consistent so I have updated those. I'll let design know too. The up arrow positioning is weird, I tweaked it but iOS does some magic to decide the final positioning. In the end, I gave in to the system and just simplified the code to provide the source rect and let it decide from there. Let me know if you have more luck!

@subsymbolic - the stack view needs to be trailing/leading relative to the safe area.

in OmniBar.xib click on Search Container
under Size Inspector turn on Safe Area Layout Guide
Update the StackView's leading and trailing to be relative to the Safe Area with a constant of 0

@brindy that example works as it has dropped the leading / trailing margin constants but as soon as I add them things are a tiny bit off centre again. I think this is just iOS choosing the "ideal" positioning, the same happens with UIBarButton.


Fix hmac_drbg failure in benchmark, with threading

Description
Remove redunadnat calls to hmac_drbg_free() between seeding operations,
which make the mutex invalid. Fixes #1095
Status
READY
Requires Backporting
Yes
Which branch?
mbedtls-2.1
mbedtls-2.7
Migrations
NO
Todos

[ ] Tests
[ ] Documentation
[x] Changelog updated
[ ] Backported

Steps to test or reproduce
Outline the steps to test or reproduce the PR here.

@andresag01 I agree that the mbed-os-example-tls has the same issue.
Do you know if MBEDTLS_THREADING_C can be defined in Mbed OS?

As far as I remember, we had some pending changes to Mbed TLS to make sure that the Mbed TLS multithreading abstraction used through MBEDTLS_THREADING_C had an implementation in Mbed OS, but I do not think it has been merged because some changes are needed to the Mbed TLS APIs (e.g. https://github.com/ARMmbed/mbedtls/pull/1131) that have not been finalized. So I think for now the mbed-os-example-tls will work, but it would still be good to fix it there as well or to raise an issue.

@sbutcher-arm I fixed the typo
I will rebase to resolve conflicts once the PR is reviewed.

@roneld - I've approved it, but I think you should go ahead and rebase now, else you'll need another review now, and another two after rebasing, which will just slow things down.

@sbutcher-arm I have rebased and resolved conflicts.
Could you please review?
cc @andresag01

Backported to branches 2.1 and 2.7 in #1898 and #1899
cc @andresag01 @sbutcher-arm

@sbutcher-arm @RonEld: Please note that the PR https://github.com/ARMmbed/mbed-os-example-tls/pull/194 already addresses these problems.

Removing the "needs backports" label, as all backports have been fully approved


for i in n has no type hint

Godot version
4.0 57bdddc
System information
Windows 10 x64
Issue description
range(n) correctly returns Array[int] (or similiar) and for loop on range is properly typed. But if you omit range and iterate on integer, the variable is not typed.
See here:

Line 10 is unsafe, because i isn't typed as integer.
Steps to reproduce

Use for i in 10
Do something with i
Unsafe

Minimal reproduction project
No response

for i in range(10): does not allocate an array: https://github.com/godotengine/godot/blob/master/modules/gdscript/gdscript_analyzer.cpp#L1324

But standalone range(10) is an array. I assume this is why it's properly typed in a loop.

Little unrelated: does line number color show code (un)safety?

Yes, "safe" lines have line number tinted green.

Duplicate of #61727.


Stop suppressing gandlf config errors

If gandlf config cannot be parsed properly (typos, wrong values, etc), now the error is just suppressed without any meaningful error and gandlf_config variable is just broken.
Fix ensures

runner fails if gandlf config cannot be parsed,
if any errors, they are printed to logs with their stack trace

Thanks for the contribution @VukW! Approved and merged.


How to handle multi region replicated cluster?

Does Spring Kafka help in handling failover kafka clusters running in 2 different aws regions? if so, can some one please help.

Spring Kafka just delegates to the Apache Kafka.
Both Producer and Consumer Spring APIs are based on the particular onces from Apache Kafka.
They just accept CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG:
public static final String BOOSTRAP_SERVERS_DOC = "A list of host/port pairs to use for establishing the initial connection to the Kafka cluster. The client will make use of all servers irrespective of which servers are specified here for bootstrapping—this list only impacts the initial hosts used to discover the full set of servers. This list should be in the form "
                                                       + "host1:port1,host2:port2,.... Since these servers are just used for the initial connection to "
                                                       + "discover the full cluster membership (which may change dynamically), this list need not contain the full set of "
                                                       + "servers (you may want more than one, though, in case a server is down).";

and build the target Apache Kafka components.
Nothing there in Spring Kafka for described issue.
I think you should go directly to Apache Kafka support.
Thanks

Closing with no response.


R200 on Visual Studio 2017

Issue Description
I've recently borrowed an R200 camera for a university project and am struggling to get it to work. I have the right DCM installed and can successfully build the librealsense files with CMake. When I run realsense-viewer.cpp it works for a short time and then opens a white window and produces the following:
Exception thrown at 0x744508B2 in rs-capture.exe: Microsoft C++ exception: std::runtime_error at memory location 0x00D6ECCC.
The thread 0x3530 has exited with code 0 (0x0).
Exception thrown at 0x744508B2 in rs-capture.exe: Microsoft C++ exception: std::runtime_error at memory location 0x00D6ECCC.
The thread 0x1fd0 has exited with code 0 (0x0).
Exception thrown at 0x744508B2 in rs-capture.exe: Microsoft C++ exception: std::runtime_error at memory location 0x00D6ECCC.
Exception thrown at 0x744508B2 in rs-capture.exe: Microsoft C++ exception: [rethrow] at memory location 0x00000000.
Exception thrown at 0x744508B2 in rs-capture.exe: Microsoft C++ exception: [rethrow] at memory location 0x00000000.
Exception thrown at 0x744508B2 in rs-capture.exe: Microsoft C++ exception: rs2::error at memory location 0x00D6F1EC.
Exception thrown at 0x744508B2 in rs-capture.exe: Microsoft C++ exception: std::runtime_error at memory location 0x00D6E3B0.
Exception thrown at 0x744508B2 in rs-capture.exe: Microsoft C++ exception: [rethrow] at memory location 0x00000000.
The thread 0x2548 has exited with code 0 (0x0).
The thread 0x1038 has exited with code 0 (0x0).
The thread 0x31c has exited with code 0 (0x0).
The thread 0x518 has exited with code 0 (0x0).
The thread 0x3f08 has exited with code 0 (0x0).
The thread 0x1f34 has exited with code 0 (0x0).
The thread 0x3ff4 has exited with code 0 (0x0).
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\ntasn1.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\ncrypt.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\igd10iumd32.dll'
The thread 0x468 has exited with code 0 (0x0).
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\PortableDeviceTypes.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\deviceaccess.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\mfsensorgroup.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\Windows.Media.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\SensorsUtilsV2.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\SensorsNativeApi.V2.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\SensorsApi.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\winmmbase.dll'
'rs-capture.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\winmm.dll'
The thread 0x3368 has exited with code 1 (0x1).
The thread 0x316c has exited with code 1 (0x1).
The thread 0x3ac0 has exited with code 1 (0x1).
The thread 0x3dcc has exited with code 1 (0x1).
The thread 0x1fe0 has exited with code 1 (0x1).
The thread 0x1d84 has exited with code 1 (0x1).
The thread 0x3c1c has exited with code 1 (0x1).
The thread 0x3ed8 has exited with code 1 (0x1).
The thread 0x2c08 has exited with code 1 (0x1).
The thread 0x2e0 has exited with code 1 (0x1).
The thread 0x2a34 has exited with code 1 (0x1).
The thread 0x2328 has exited with code 1 (0x1).
The thread 0x4d0 has exited with code 1 (0x1).
The thread 0x3c9c has exited with code 1 (0x1).
The thread 0xd50 has exited with code 1 (0x1).
The program '[12452] rs-capture.exe' has exited with code 1 (0x1).
My feeling is that the R200 itself is not configured correctly for two reasons.

The debug output is the same even if the R200 is unplugged.
In the device manager, all of the R200 depth, left-right, and rgb items are listed under 'Cameras', not 'Imaging Devices'.

I have tried reinstalling the DCM twice with no change. I'm not a compsci student and this is my first time with C++ so any help is appreciated.

[Realsense Customer Engineering Team Comment]
hi @DMG22,
for running realsense viewer and libRealsense, you don't need DCM, so would suggest to remove it in case of any interference.
and would like to know if you can run pre-built realsense viewer with R200 you have? so we can make sure your system is good.

Hi @RealSense-Customer-Engineering ,
I tried uninstalling DCM, and I still have the same result when I try to use the librealsense viewer. I also downloaded the Intel Realsense Viewer v2.12.0, and the program is asking me to connect a realsense camera or add source. I can still see the Depth, Left-Right and RGB items under Cameras in the device manager, so I am pretty sure the USB connection is working to some degree.

[Realsense Customer Engineering Team Comment]
hi @DMG22,
the LibRealsense v2 is not support R200, so you need to use the legacy version of librealsense which are versions 1.12.0 and earlier.

Hi @RealSense-Customer-Engineering,
Thanks for pointing that out. I have downloaded the legacy version of the SDK, but I have some new problems.
When I run CMake I get the following error:
G3D193B2D: #error At least Visual Studio 2013 Update 4 is required to compile this backend
This is strange because I am using the latest version of Visual Studio 2017.
My other problem is that Visual Studio fails to open any of the source files specified in the C and C++ headers. Below are two examples:
E1696	cannot open source file "cstdint"
E1696	cannot open source file "cstddef"
I have searched for these files in the visual studio folder and they are definitely there. This leads me to believe it is an issue with the file path. I attempted to access Visual C++ directories in the settings but MS has apparently changed VC++ directories so you can only specify them for individual projects. I can't figure out how to open librealsense as a project, and I can't edit VC++ directories for a CMake file or non project file. I even tried copying the MSVC folder with all the C++ source files into the librealsense directory, but VS still cant find the files.

[Realsense Customer Engineering Team Comment]
hi @DMG22,
per installation guide:
https://github.com/IntelRealSense/librealsense/blob/v1.12.1/doc/installation_windows.md
suggest to use Visual Studio 2013 Release 4, both Professional and Community editions.
your following issue seems also due to visual studio version not match so you don't have those files.


OpenXR Toolkit crashes Unreal Engine Editor

Describe the bug
XR_APILAYER_NOVENDOR_toolkit.log
When OpenXR Toolkit is enabled I cannot open Unreal Engine Editor 4.27.2's VR Template.
Unreal crashes with EXCEPTION_ACCESS_VIOLATION reading address 0x0000000000000000
Environment
Unreal Engine Editor 4.27.2's VR Template.
HP Geverb G2
110.2202.10002
Nvidia GTX 3080
To Reproduce
Steps to reproduce the behavior:

Open Unreal Engine
Create VR template
Crash

Expected behavior
No crash
Screenshots
N/A

Thanks. We've already (in our main branch) completely disabled openxr toolkit with Unreal (see #280). This change isn't in any release yet.
We will never be able to support unreal, because it does too much trickery with swapchains and its too complicated to support.

Closing this is will not longer crash (but not work) in the next major release.


Fix allowance bug

This fixes the critical bug in withdraw that allowed anyone to withdraw from any address without approvals. We also improve consistency of errors by reverting with InsufficientAllowance() in all places rather than silently failing with underflows.

Just double checked with forge test it looks like it has 3 failed test cases. Not sure if that is known 🤔
Overall changes LGTM 😄


fail to open new bam file when splitting

I want to split bam file with 10x barcodes. But it seemed that bxtools did not generate bam files for all barcodes. The error is "E::hts_open_format] fail to open file 'abc.bam'   Could not open BAM: abc.bam"

abc.bam is the BAM that you would like to split? Can you check that samtools can operate on this BAM? This looks like something is corrupted with the BAM, since the error is direct from htslib code that is baked into bxtools.


Global key shortcuts

###v1:

Create a global handler for instantly jumping to the search bar.
Create a component wrapper to stop events from inputs from propagating to this global handler unnecessarily

ember test results:
skip 1 Chrome 68.0 - [0 ms] - Acceptance | datasets/dataset/comments: visiting /datasets/dataset/comments
skip 2 Chrome 68.0 - [0 ms] - Acceptance | datasets/dataset/ownership: visiting /datasets/dataset/ownership
...
ok 485 Chrome 68.0 - [1 ms] - Unit | Utility | validators/urn: buildLiUrn
ok 486 Chrome 68.0 - [1 ms] - ember-qunit: Ember.onerror validation: Ember.onerror is functioning properly

1..486
# tests 486
# pass  480
# skip  6
# fail  0

# ok

Coverage remained the same at 27.633% when pulling c1ae62e1f301b004b3735151d87b16d46fc63e45 on cptran777:global-key-shortcuts into 7cc30b7e8bd5c4663728e7f571b0435ce42998bd on linkedin:master.

Codecov Report

Merging #1325 into master will increase coverage by 0.28%.
The diff coverage is 52%.

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   51.56%   51.85%   +0.28%
==========================================
  Files         178      179       +1
  Lines        3679     3697      +18
  Branches      813      816       +3
==========================================
+ Hits         1897     1917      +20
+ Misses       1782     1780       -2

Impacted Files
Coverage Δ

wherehows-web/app/components/ivy-tabs-tablist.ts
0% <0%> (-15.39%)
:arrow_down:

wherehows-web/app/components/search-bar-form.js
5.26% <0%> (-3.08%)
:arrow_down:

wherehows-web/app/constants/keyboard.ts
100% <100%> (ø)
:arrow_up:

...herehows-web/app/components/dataset-deprecation.ts
87.87% <100%> (ø)
:arrow_up:

wherehows-web/app/components/user-lookup.ts
50% <100%> (ø)
:arrow_up:

...s-web/app/components/abstracts/stop-propagation.ts
100% <100%> (ø)

wherehows-web/app/utils/api/datasets/schema.ts
83.33% <0%> (-16.67%)
:arrow_down:

wherehows-web/app/utils/api/datasets/compliance.ts
67.85% <0%> (-7.15%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc30b7...c1ae62e. Read the comment docs.

Closing for rework


feat(rust): add builders to ockam_api

To enable a more fluent construction of requests and responses and their optional bodies.

Superseded by https://github.com/build-trust/ockam/pull/2768


Lazy instantiation for segmentKillers, segmentMovers, and segmentArchivers

Description
Currently, the ingestion task requires for you to specify the AWS region if you have druid-s3-extensions loaded even when your ingestion task doesn't use s3. This is because OmniDataSegmentKiller is being initialized when the Peon starts up which loads all implementations of DataSegmentKiller from extensions. This is a bug from UX perspective as the the user should be able to load the s3 extension without AWS region configured if they don't use any s3 stuff. This PR fixes DataSegmentKiller as well as  DataSegmentMover and DataSegmentArchiver, which have the same problem, to accept a client supplier instead of a client, so that the client is initialized when they are actually used. For example, S3DataSegmentKiller accepts a supplier of s3Client now. Since the AWS region is checked when s3Client is initialized and the supplier initializes s3Client when the killer is actually used, any ingestion jobs should now be able to run with the s3 extension loaded without AWS region unless they use s3 stuff. The ingestion job will fail when it tries to use extension stuff if something is not configured properly instead of at the beginning of the ingestion job. For example, a kill task that kills segments in s3 will fail when it calls s3 APIs instead of at the beginning of the task if the AWS region is not configured. This change is covered by integration tests as ingestion tests always use the kill task to clean up segments in deep storage after the test is done.

This PR has:

[x] been self-reviewed.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

Travis failed because of #12171.

Travis failed again because of https://github.com/apache/druid/issues/12171.

Ignoring the flaky test as it doesn't pass even after a couple of retries.


New Features

Adds the following

:add and :append methods for logging
Debug info
A clear! method

Also removes the default logger since it was buggy

Adds autosizing


Fix Logger During Predict

What does this PR do?
During predict, we currently use self._state.timestamp. This always returns the same value, so all logged metrics are overridden by the latest version. Instead, we should be using the predict timestamp during predict (which we know because predict always sets a fixed dataloader label).
What issue(s) does this change relate to?
CO-1797

@eracah what are the implications of this during eval? I think it will also break similarly if I just called eval?

While this is a very nice quality of life improvement, it technically breaks things if a user names their dataloader "predict" :( so can't merge

Could you just add something to state that says when predict is active instead?

Could you just add something to state that says when predict is active instead?

i think we probably want a state var that tracks train / predict / eval state. Will add to backlog


how to add a header comment?

does anyone know how to add a header comment?

What do you mean by 'header comment' ? Could you give examples?

like this. at the beginning of the file, one-click to add a header comment.

@Author: xxx
@Date: xxx
@LastEditTime: xxx
@Description:

Please move this to discussions.


Create .npmignore

Removes example and test code from distributed npm package

Not interested .. none of these are huge and including them with the install helps you understand how things work .. i.e. if you're somewhere without internet and are working with it.
If you can convince me otherwise, i.e. what is the big deal of including this I'm open to change my mind ;)

My personal reason behind this is that AWS Lambda deployments have a hard limit of 250mb and soft limit of 10mb when using their API. If you go over 10mb you need an extra step involving S3. I've hit both these limits on projects. One quick fix has been to get rid of extra stuff in node_modules. Lots of small modules === lots of small extra files. I've been pushing those changes upstream when it seems to make sense.
Obviously your repo, so your call, just wanted you to know my motivation. Thanks for making this module in the first place and also for looking at this PR!

Could you maybe help me figure out why and fix it here so we can merge your PR and have all tests pass as a result as well?
I'd totally appreciate that but understand if you pass due to time constraints.

I refer to docs offline all the time, removing them would definitely come back to bite me. If AWS lambda has hard caps, it should probably be resolved on their end. This would literally just remove a couple of KB; I think there's bigger gains to be made elsewhere (e.g. are you using babel or electron? Those deps are massive, consider removing those first).

@yoshuawuyts this is just about removing tests and examples, not the Readme.
However I agree that the code in there is not big.

@thlorenz ran into this yesterday even with tcomb - they strip their docs/ and tests/ from the npm output, had to wait a couple of hours before I could continue. Having access to either would've probably helped a great deal, as their readme didn't cover all cases.
There's been prior discussion about this topic on https://github.com/substack/tape/pull/260.

@southpolesteve Please show that this makes a meaningful difference, i.e. only if the tarball is significantly smaller will I consider the pull, otherwise not since for some people working offline it is important to access the tests as part of the packages they installed locally on their machine.
You can compare the sizes as follows:
git checkout master
npm pack
du -h *.tgz

git checkout <your-branch>
npm pack
du -h *.tgz

fwiw, I measure a 33% reduction in the tarball size
dougwade code/readdirp ‹reduce-package-size› » npm pack
du -h *.tgz
(node:47721) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
readdirp-2.0.1.tgz
dougwade code/readdirp ‹reduce-package-size*› » du -h *.tgz
12K	readdirp-2.0.1.tgz
dougwade code/readdirp ‹reduce-package-size*› » vim .npmignore
dougwade code/readdirp ‹reduce-package-size*› » rm readdirp-2.0.1.tgz
dougwade code/readdirp ‹reduce-package-size*› » npm pack
(node:47841) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
readdirp-2.0.1.tgz
dougwade code/readdirp ‹reduce-package-size*› » du -h *.tgz
8.0K	readdirp-2.0.1.tgz

33% is a lot of %, but 4K is not a lot of K, so ¯_(ツ)_/¯

@doug-wade that's quite substantial even if we're just talking 4K.

I'd really like to keep the tests in.

Resolved, see #55


Request to add uploader to firebase-dart library

This issue was originally filed by @sethladd

The original owner of http://pub.dartlang.org/packages/firebase is no longer maintaining the library. The company would like to add another uploader to the account.
Can you please add<EMAIL_ADDRESS>as an uploader? Thanks!

This issue has been moved to dart-lang/pub-dartlang#284.


[FEATURE] Add fuzz testing

Is your feature request related to a problem? Please describe.
We currently do not do fuzz testing on wasmCloud and it would be great to ensure that we're passing fuzz tests on each PR.
Describe the solution you'd like
Ideally, wasmCloud should be able to handle a variety of fuzzing on:

The CLI (arguments and environment variables passed at runtime)
The control interface (NATS messages sent on wasmbus.ctl.> to request ctl operations)
The Actor RPC topics (NATS messages on wasmbus.rpc.<lattice>.<actor_id> when that actor is running)

This should all be pretty simple to build based off our current wasmbus suite of tests.
Describe alternatives you've considered
Not fuzz testing, and that's what we do now, but it's better to fuzz test!
Additional context
https://github.com/rust-fuzz/cargo-fuzz is a great tool for Rust projects 😄

I've never done any fuzzing, so this is just based on what I've learned in the last 30 minutes.
Taking a quick look at the code:

CLI arguments: Fuzz CliCommand. This is probably more effective than just fuzzing Cli = Parser::parse()
The control interface: Fuzz message in async fn handle_ctl_message(self: Arc, message: async_nats::Message)
The actor RPC topics isn't as clear to me, there are a couple of places in the host/wasmbus crate that could be fuzzed.

Am I correct in assuming the wasmbus suite of tests is /tests/wasmbus.rs?

Yep that's right @cdmurph32 ! Fuzzing on the CLI is nice to make sure we can't just straight up break the runtime with a malformed string. Fuzzing on the control interface is what I really think we'd benefit from, make sure that receiving garbage payloads doesn't cause any undefined behavior

I'm going to defer this until Host in https://github.com/wasmCloud/wasmCloud/blob/main/crates/host/src/wasmbus/mod.rs has been refactored into more easily mockable parts.

@cdmurph32 getting closer here, in https://github.com/wasmCloud/wasmCloud/pull/1588 I refactored a bunch of the handlers to return strongly typed data. More refactors to come for the code but just a note on the progress


how to set post_meta when creating a post?

I'd like to learn this as well. Currently I'm trying like
meta: [{
            key: 'external_thumbnail',
            value: thumbnail
        }]

while creating posts, but no luck

Even I have the same issue any ideas how can we update Meta Fields?

How are you registering the meta you wish to update?

If you use register_rest_field like this: https://github.com/kadamwhite/wp-notebook/blob/master/wp-notebook.php#L62-L81 then you should be able to update the value by passing that key in the response: https://github.com/kadamwhite/wp-notebook/blob/master/src/components/EntryComposer/index.jsx#L49-L53

If you're using register_meta, it should be something like this (untested):
meta: {
    external_thumbnail: thumbnail
}

cc @jiji262 / @emreycolakoglu

What about with https://codex.wordpress.org/Function_Reference/update_post_meta  I have a big problem using this plugin and framework... documentations is missing or not working.. hard to debugg, thanks for your help

Closing this as a duplicate of #280 to unify the threads; meta handling is currently our top-priority documentation issue


Support reverse DFS searches

Summary
Support the ability to do a DFS search that goes against the direction of the edges
Motivation
The motivating example here is the WebAudio processing graph I'm implementing in https://github.com/servo/media . It's a DAG with audio going from sources, through multiple processing nodes, to a single audio sink. I would like to represent the graph as a StableGraph with edges going in the direction of sound since that's more in line with the general mental model of dealing with this and it's harder to be confused about what you mean by input/output incoming/outgoing.
However, to process these nodes, I have to process them dependency-wise, starting at the source nodes and working my way up.
Such a "bottom up" traversal is just a DFS post order search. Great, this library has one!
Except the DFS post order starts at a node and follows outgoing edges to find "children", whereas in this case I need the opposite -- I need incoming nodes to find dependencies.
This doesn't feel like an uncommon use case. In general, most of what the graph does seems independent of the direction you choose for your edges, with all the important APIs having a Direction argument, so it feels weird that the search cannot be done this way.
This isn't prohibitive -- I've currently implemented the graph with the edges following dependency relationships, but writing complex code around this just gets confusing since input/output are easily mixed up.
Details

DFSPostOrder and friends would have a Direction argument

Probably don't have time to implement this myself, but can help someone wanting to implement

What about using the ReverseGraph adaptor?

Oh, Reversed? Hmm, this can work. I hadn't realized it was a thing.


Support for MakerDiary MDK Dongle

Hi, it should technically be possible to support the MakerDiary Dongle (MDK), which contains the same nRF chip. It is just easier to flash by copying the hex file over to the USB mass storage device the dongle provides.
The hex file probably needs to be different, but you could see how that works here: https://github.com/RoganDawes/LOGITacker
They also support the Nordic dongle AND the MDK dongle.
Would you be willing to port your firmware it to this device?

Hi,
porting the firmware to this device may be interesting. I'll probably add new protocols and new features soon, and supporting another dongle which is easier to use could be interesting, thanks for the idea !
I just ordered it, i'll try to work on it when I find some time.

Awesome! I really like Mirage, although not everthing is working as documented, but it is a great project and I hope it is here to stay.


Questions about "Is your goal oriented model performing well"

Hi there,
Thanks for the excellent paper of Takanobu et al. (2020). I thoroughly appreciate the systematic comparison across so many points, and especially the call out of mismatch between single turn performance and overall performance.
One question I have is about the source code. Right now, the top line README for this repo shows a very similar table to Table 1 of the paper, but with very different results (and indeed, quite a few different systems, with some disagreeing). Furthermore, you have similar tables for 2, 3, etc in the README, but with different metrics.

How the table in the README different from the one presented in the paper?
Why the mismatch of reported metrics? Can one use ConvLab-2 to produce the rest of the metrics reported in the paper?
The paper calls out that the code was all open source in February, while this repo became available in May. Perhaps I should be looking at a different repo?
If there are two repos, which one do you anticipate receiving more support? I assume this one, as it aims to be a standardized platform.

Best wishes from the ParlAI team & collaborators
Thanks,
Stephen

Thanks for your interest. The paper of Takanobu et al. (2020) use ConvLab platform. This repo updated data, algorithms, the simulator, the evaluator, etc. This repo will receive more support.

Great, thanks much!


chore: seperate IO from cloudflare request handler

Currently instance of IO is created while handling request hence handle request needs instance of worker::Env to initiate IO, with this implementation we are confined to use implementation Cloudflare*IO and can not have unit tests, so the goal is to design the function in such a way that avoids passing worker::Env to cloudflare/src/handle::fetch.
Proposal:

Either make a struct which contains implementation of required IOs which can be passed to the function
Or ability to pass app context to the function.

Must avoid:

Must avoid IO to be re instantiated for every request as the instantiation of AppContext occurs only once

This should be much easier once #1015 is merged.


Initial internalization support of Docs on production with new sidebar & navbar items

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: softmarshmallow:x: gridabotYou have signed the CLA already but the status is still pending? Let us recheck it.


[Dns] Rename dns recordset

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check for Azure.ResourceManager.Dns
API changes have been detected in Azure.ResourceManager.Dns. You can review API changes here

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.Dns


'SP3 neuron' as a subclass of 'larval DMS cell of pars intercerebralis'

Based on defs.
Check refs on SP3 neuron as well as:
https://elifesciences.org/articles/16799
May need to update 'SP3 neuron' term

related to #191

Upon review of McCormick and Nichols (1993) - FBrf0065487, it appears that there are two of these (DMS-expressing) cells per hemisphere, in the PI (see fig 4). These must correspond to the two 'larval DMS cell of pars intercerebralis' - i.e. these terms refer to the same thing and should be merged.
I would prefer to keep 'larval DMS cell of pars intercerebralis' as I think this name is more informative, 'SP3 neuron' will be added as a synonym.


ARROW-10135: [Rust] [Parquet] Refactor file module to help adding sources

https://issues.apache.org/jira/browse/ARROW-10135

I first moved the footer parsing out of the SerializedFileReader. I will now try to move as much logic as possible from the SerializedFileReader and SerializedRowGroupReader traits to the more generic FileReader and RowGroupReader traits

The discussion with @alamb about the need for an intermediate layer when reading a parquet file is discussed on JIRA
The highlights of the current implementation:

The public API has changed, but keeps working for File and Path thanks to the corresponding trait implementations. Cursor cannot be used any more because it requires data copies when being passed around with clone() (this was already the case before in the implem of TryClone for Cursor<Vec<u8>>).
I have added a custom cursor type (SliceableCursor) that allows to generate cursor slices without cloning the underlying data. This can be used to read in-memory files. I guess it could be made more generic, but this would be for convenience only and I find it simple and clear as is.
I have separated the implem (SerializedFileReader, SerializedRowGroupReader...) from the traits (FileReader, RowGroupReader...) for more clarity. I know that this is not how the code base is structured in the rest of the project but I tend to get lost in these huge files with millions of struct/trait/impl blocks. I'm very much open to suggestion about this point!
There is nothing about async/parallelism yet, I have to think about it a little bit.

@alamb : can you take a look at the new ChunckReader trait and how it is integrated to the rest of the reader? What do you think about it?

Thanks a lot for your time and comments!

using a more standard spelling of Chunk rather than Chunck

You mean "a more correct spelling" 😉

I wonder how important separating out get_read and get_read_seek is

Right, I was just looking at this. There might be some simplifications that could be implemented here.

I think we should begin moving the parquet reader towards using Arc

That is true, but there is a major problem with the way FileSource works in that case. The fact that we share a single file handle between instances (because it is the behavior of File::clone()) prevents us from accessing concurrently a same file.
Give me a bit of time, I will try to fix these. I'll come back to you if I have further doubts. Thanks again !!!

@alamb I think I addressed most of your concerns. The only one that remains is the necessity to prepare for async, but I have digged a little bit into and I think that tackling this properly will require work that is not really in the scope of this PR. There is more to it than converting Rc to Arc because of this shared handle to the file. Lets do that work in an other PR associated to a sub-tasks of ARROW-9464 or simply associated to ARROW-9674. I will work on it next week, but until then we can validate and merge this one.

The only one that remains is the necessity to prepare for async, but I have digged a little bit into and I think that tackling this properly will require work that is not really in the scope of this PR

I agree

Sorry I don't have more time to spend on this -- I am still struggling to get my existing project code to compile against this branch and this PR is pretty massive to digest.
One other thing I found this morning is that the TryClone trait is still used in ParquetWriter so I do think it needs to be publically exported somehow (or we need to refactor the writer)
I have also been trying to figure out if the ParquetReader trait is still needed after this refactoring.
So I guess all in all my conclusion is that the ideas behind this PR are good but:

It is hard to review given its size
There will likely be a fairly substantial backwards incompatible change for anyone using the ParquetReader in their project

I'll also only be able to review this in the next 2 week(end)s, and I'd like to go through it before it's merged.
I'm also going to reach out to a few active crates that depend on Parquet, so I can solicit their feedback on these changes.
I anticipate a lot of changes + improvements for the 3.0.0 release, so if we can manage that without causing a lot of breakage; I think we should go for it.

I should probably make clear that anyone using the SerializedFileReader with File will likely have no issues (as @rdettai  has done a great job of keeping the that level interface consistent. Any project that uses a custom input source (as we did in my internal project) by implementing ParquetReader and associated traits may have more to change.
I actually think the changes in this PR will make such custom input sources easier to write in the future, but existing code will have to be rejiggered.

I'm open to moving traits such as ParquetReader back to reader.rs or re-exposing them with pub use crate::. But I have the feeling these traits are very specific to the implementation of the util::io::FileSource, which is private because it is mainly a slicing/buffering wrapper around File (hence the name ;-)). This wrapper makes sense because File is cheap to clone and needs to be buffered, but this will not be generally the case for other implems of ParquetReader. What about your usecase @alamb ? Do you think it is worth it have the ChunkReader be implemented for T:ParquetReader rather than File ? This would be more flexible, maybe a little bit too much...
It is a good observation that TryClone is also used in the writer. I didn't want to move things around in the writer because it would have made the PR even more massive and also because I've been told that there was an active development effort going on over there :-). Similar changes might apply.

@rdettai  --

This wrapper makes sense because File is cheap to clone and needs to be buffered, but this will not be generally the case for other implems of ParquetReader.

Yes, actually that was our experience (when we used a buffered implementation, we found that the underlying (large) buffer got copies around a lot.
I think in general, the cleaner thing (and my preference) would be to simply port my code to use ChunkReader (I think it will end up being cleaner and likely more performant).

Do you think it is worth it have the ChunkReader be implemented for T:ParquetReader rather than File ?

The upside is that it would be somewhat more backwards compatible, but unless other reviewers feel strongly I personally think we should just do the breaking change in terms of ChunkReader and move on

I am but one opinion -- I wonder if @nevi-me  or @sunchao  have any thoughts / opinions about where this PR is heading

I am but one opinion -- I wonder if @nevi-me or @sunchao have any thoughts / opinions about where this PR is heading

I'm principally fine with the changes, and the direction of the PR. I'll highly likely be working more on the non-Arrow side of Parquet, so I expect that I might be making a lot of changes on top of this.
There seems to be some demand for supporting sources and sinks other than files, and as this helps with that; I'm pro getting it merged.
@rdettai are there still more changes that you intend on making, and @alamb are all your queries and concerns addressed? Thanks for the detailed review.

@nevi-me  -- I think this is good enough to merge; Once it is merged, I'll try and port my internal project asap (which has custom readers and writers) and make a PR to do any touchups needed (like re-exporting TryClone if need be)

From the description the changes proposed here makes sense to me as well - but seems the PR itself is messed up and contains many unrelated changes.

@rdettai are there still more changes that you intend on making, and @alamb are all your queries and concerns addressed? Thanks for the detailed review.
@nevi-me Depends on whether we want ParquetReader to remain public or not. If not, I think the PR is fine, otherwise, I can bring it back into parquet::file::reader.

@sunchao I tried to restrain myself on this PR 😄. Honestly, I had to move quite a lot of things around because this touches a core API and things were very "monolithic". There are two points were I'm getting a little bit out of the main concern:

I added a Seek implem to the FileSource that ended up not being useful. I am removing it right now.
The typo fix in array_reader, but I'm sure you can forgive me that one :-)

Thanks @rdettai . I'll take a look at this PR today.

I'm having second thoughts about the ChunkReader interface. It has a length, but what we really want is the capability to "read from end" in order to get the parquet footer. So I'm thinking about removing the Length trait and give to get_read the capability to read from end, for instance by making start: u64 an enum { FromStart(u64), FromEnd }. This is particularly interesting when reading from a remote store where getting the size is expensive. What do you think ?

I'm having second thoughts about the ChunkReader interface.

I personally think the ChunkReader interface is good enough as is and this PR has been hanging out for quite a bit.
By adding more sophistication (FromStart, FromEnd) you may save an S3 or other object store`  metadata request to get the length in theory, but I suspect most applications will already have the length metadata from other sources anyway (e.g.  because they had to list the objects for some other reason) so acquiring the length may not be as expensive as it first appears.

I agree that this PR is hanging, but as this is an API change, I guess its better to think things through before moving forward! 😄 This should maybe have been thought through in a design document rather than in the PR... 😅
Its true that most of the time you will have the length around from an other source. But shouldn't we prefer a traits that contains exactly the minimum amount of information we need to make the FileReader implem work ?
Proposition:
pub enum ChunkMode {
    FromStart(u64),
    FromEnd(u64),
}

pub trait ChunkReader {
    type T: Read + Length;
    fn get_read(&self, start: ChunkMode, length: usize) -> Result<Self::T>;
}

I can have the implem ready by the end of the day!

Hi! I did some experimentation with this new interface (with ChunkMode). It works but is not flawless. You are right @alamb , we should move on with this PR the way it is currently implemented (with get_read(&self, start: u64, length: usize)), and we'll discuss the other possibility in a dedicated thread.
@sunchao I have responded to all your comments. If you are okay with my answers, I think we can merge this.

FYI I have filed https://issues.apache.org/jira/browse/ARROW-10390 for the issue with TryClone not being public. I'll try and whip up a PR to get it fixed.