Unsupported operation: Cannot add to an unmodifiable list

Describe the bug
Issue while adding any filter in the TalkerScreen
To Reproduce
Steps to reproduce the behavior:

Go to TalkerScreen
Click on any filter

Expected behavior
The filters should be added without errors
Additional context
Unsupported operation: Cannot add to an unmodifiable list

When the exception was thrown, this was the stack:
#0      UnmodifiableListMixin.add (dart:_internal/list.dart:114:5)
#1      TalkerScreenController.addFilterTitle (package:talker_flutter/src/controller/talker_screen_controller.dart:57:56)
#2      TalkerScreenFilter._onToggleTitle (package:talker_flutter/src/ui/widgets/filter/talker_screen_filter.dart:167:18)
#3      TalkerScreenFilter.build.<anonymous closure> (package:talker_flutter/src/ui/widgets/filter/talker_screen_filter.dart:115:23)
#4      _GroupButtonBodyState._generateButtonsList.<anonymous closure> (package:group_button/src/group_button_body.dart:170:38)
#5      _InkResponseState.handleTap (package:flutter/src/material/ink_well.dart:1072:21)
#6      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:253:24)
#7      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:627:11)
#8      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:306:5)
#9      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:276:7)
#10     GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:163:27)
#11     GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:464:20)
#12     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:440:22)
#13     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:337:11)
#14     GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:395:7)
#15     GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:357:5)
#16     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:314:7)
#17     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:295:7)
#18     _invoke1 (dart:ui/hooks.dart:167:13)
#19     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:341:7)
#20     _dispatchPointerDataPacket (dart:ui/hooks.dart:94:31)
Handler: "onTap"
Recognizer: TapGestureRecognizer#13c3e
  debugOwner: GestureDetector
  state: ready
  won arena
  finalPosition: Offset(44.3, 280.0)
  finalLocalPosition: Offset(34.3, 21.0)
  button: 1
  sent tap down
====================================================================================================

Hello @ProjectAJ14 !
I see this issue. I will fix it in next release!

You can contribute If you know how to fix it

Hello @Frezyx , I have added a PR#85


Add platform-dependent module resolution

As described by @philikon in https://github.com/mjohnston/react-native-webpack-server/pull/111#discussion_r43030879:

Another thing to consider is the platform-based module resolution. If I do require('./foobar') with the React Native packager within a bundle that's been loaded with ?platform=<platform>, it will resolve to ./foobar.<platform>.js or ./foobar.js. Having both foobar.ios.js and foobar.android.js being importable as ./foobar is quite powerful. Because you can push platform-dependent differences into their own modules/React components and the code that's common to both platforms simply imports the module/component while being oblivious to which platform it's actually running on.

As far as I know, webpack does not support serving multiple configurations (i.e. both Android and iOS) in the same process, so we'll need to run two webpack instances to have different module resolution rules for each platform.

@elliottsj Any updates on this? It seems pretty important to me!

Didn't catch #143, my bad.

As far as I know, webpack does not support serving multiple configurations (i.e. both Android and iOS) in the same process,

Fortunately that's not true! Webpack's multicompiler feature makes this easily possible. Here's how I have solved this for myself: https://github.com/mjohnston/react-native-webpack-server/pull/156#issuecomment-195826035


exportImage() - TypeError: this.drawer.getImage is not a function

exportImage() function call drawer.getImage(), but drawer object dos't have function getImage();
drawer.canvas and drawer.muliticanvas have it but it seems that on layer drawer is not connected.

@robert8888 can you a supply a simple example that shows how to reproduce this problem?

i think you try to use the function to early. wavesurfer.drawer.getImage() exists and works.

no response, closing.


issue on assigning  $to ie. phonenumber

i was going through your work , when i use the below condition it sucessfully sends the message or even if i put i single number as $to in my config it works.
$sms_message = Sparrow::send('1234567890,'This is message')
Issue here is i have $phonenumber and i want to pass it here
$sms_message = Sparrow::send($phonenumber,'This is message')
even if the number is int/string it doesnot work .
How can  admin pass different number from database without assigning variable here.

issue solved
it was not the issue i changed the identity to other name thats why message was not sending , identity must be Demo unless it is changed .

Glad it has been solved 😁


Events page does not display any events.

There are two events visible on the front page. There are zero events visible on the events page, either in previous or upcoming.

Fixed now


My location sometimes appear

Whit the standard code  (market swift version) in view for Annotation sometimes my location appear as marker, is there a way to hide it?
already tried to force whit  mapView.showsUserLocation = false

stopping location manager did the trick!

no, it continues to happens sometimes...


mailpit as a proxy

We rely fully on mailhog (not for long) as our mock in lower environments.
However, we also run tests with a real SMTP server from time to time.
We're soon replacing mailhog with mailpit and I would like to know if there's a feature where mailpit acts like a proxy, meaning that it would take the e-mail, record, store it, etc; and pass over to the underlying (real) SMTP server. So that then we can see the e-mail even when we don't have access to the recipient's e-mail box.
Do we have such a feature?

There was another feature request similar to this: https://github.com/axllent/mailpit/issues/29#issuecomment-1502010175. I haven't gotten around to test it myself, but like yourself we'll be phasing out mailhog pretty soon.

I'd say 29 was a request for the exact same thing - you want Mailpit to receive an email, store a copy, and automatically send/forward that email on to another SMTP server. This functionality was added recently and is documented on https://github.com/axllent/mailpit/wiki/SMTP-relay
Please let me know if this is what you were after?

I'd say 29 was a request for the exact same thing - you want Mailpit to receive an email, store a copy, and automatically send/forward that email on to another SMTP server. This functionality was added recently and is documented on https://github.com/axllent/mailpit/wiki/SMTP-relay
Please let me know if this is what you were after?

Amazing! Thanks for the reply.
In this case, I'm closing this issue until I get the change to try it out.

FYI I've tried out and it works like a charm 😄 .

I went over the wiki. Can anyone of you please share a sample yml file for configuration of this proxy ?

@Yahyaali1 I assume by proxy you mean that Mailpit automatically relays all messages via a preconfigured SMTP server? If so, first ensure your configuration is set up correctly (docs), and  when Mailpit is running you are able to "release" messages via the web UI. Assuming that is working (your SMTP server accepts the messages), you can add the --smtp-relay-all flag to your Mailpit startup options (or MP_SMTP_RELAY_ALL=true to the environment, depending on how you start Mailpit) and it should work.

Thank you @axllent.


TryFrom or TryInto?

I'm in doubt what the best/ideomatic way of writing this is and would just raise the question here (BTW: I wish there was a chat room for the book readers.)
On page 154, I have implemented TryInto<NewSubscriber> for FormData:
impl TryInto<NewSubscriber> for FormData {
    type Error = String;

    fn try_into(self) -> Result<NewSubscriber, Self::Error> {
        let email = SubscriberEmail::parse(self.email)?;
        let name = SubscriberName::parse(self.name)?;

        Ok(NewSubscriber { email, name })
    }
}

// ...

pub async fn subscribe(form: web::Form<FormData>, pool: web::Data<PgPool>) -> Result<HttpResponse, HttpResponse> {
    let new_subscriber = form.0.try_into().map_err(|_| HttpResponse::BadRequest().finish())?;
    // ...
}

And I think it's really cool to use TryInto this way. I appriciate to learn these standard way of dealing with conversions!
However, then I read a bit about From and Into in Rust By Example and found that implementing From would also work, and even for both form.0.try_into() and NewSubscriber::try_from(form.0) because Into calls From.
So my question: Would the intent be clearer implementing TryFrom instead?:
impl TryFrom<FormData> for NewSubscriber {
    type Error = String;

    fn try_from(form: FormData) -> Result<NewSubscriber, Self::Error> {
         let email = SubscriberEmail::parse(form.email)?;
         let name = SubscriberName::parse(form.name)?;

         Ok(NewSubscriber { email, name })
    }
}

// ...

pub async fn subscribe(form: web::Form<FormData>, pool: web::Data<PgPool>) -> Result<HttpResponse, HttpResponse> {
    // I find this more readable, since the intent is very clear
    let new_subscriber = NewSubscriber::try_from(form.0).map_err(|_| HttpResponse::BadRequest().finish())?;

    // And try_into() still works (although not at the same time as try_from above due to move semantics)
    let new_subscriber = form.0.try_into().map_err(|_| HttpResponse::BadRequest().finish())?;

    // ...
}

So, I just wanted to leave this thought/question here. For what it's worth.
Thanks for your book, I have learned a lot from it already.
(Edit: Added syntax highlighting)

@skovmand Implementing TryFrom and TryInto should work the same in this case, but one benefit of implementing TryFrom
is that you automatically get an implementation for TryInto for free.
There is a blanket implementation from the standard library.
// https://doc.rust-lang.org/core/convert/trait.TryInto.html
// TryFrom implies TryInto
impl<T, U> TryInto<U> for T
where
    U: TryFrom<T>,
{ ... }

For those who are interested, have a read at this blog post.
I do follow the an-introduction-to-property-based-testing-in-rust, but I prefer to implement  TryFrom.

Very nice blog post you referred to. Thanks 👍

I went for TryInto because, down the line, we will be splitting the project into multiple crates - the API-related bits and the domain-related bits will end up in separate crates within the same workspace.
An important constraint that we will enforce is inversion of control - the domain crate will NOT depend on the API crate.
Before Rust 1.41.x, it would have not been possible (with such a constraint in place) to implement TryFrom - the orphan rule would have prevented it. But the coherence rule has been relaxed, therefore it would probably be better to go straight for TryFrom there.
I'll update the book at a certain point to reflect it 😁

@LukeMathWalker Thanks for your answer 👍

This has been fixed - it will go out with the next book release 😁


fix: forgotten labels

There are no direct changes in the behaviour other than the fact that the bot fills in the gaps where one of the following isn't true:

no reviews
one review requesting changes
all reviews were accepted

Which seems to be what steamed the issue in #119 where some labels (namely: "PR: unreviewed") were forgotten.
There are other minor changes that include a small loop fusion, typo fix and addition of a detail in an error report regarding statuses.
There are more things that could be improved but I decided to leave those for now.

@Berkmann18 Thank you for creating the PR :+1: I will review this on this weekend.

@sotayamashita Why did you close this?


(Feature)Property with type 'embedded' cannot be a primary key

Now OrientDB not supports unique indexes for propries with type 'embedded'.
The feature needs for support annotation @EmbeddedId.
See https://en.wikibooks.org/wiki/Java_Persistence/Identity_and_Sequencing#Embedded_Id

Hi @schernolyas
I'm not sure it's structurally possible, I marked it as an enhancement, we will see if we can do this in 3.0
Thanks
Luigi

Hi @luigidellaquila
Ok. It feature needs for JPA.


How to adjust the log to /var/log/messages

I have several ASP. NET core applications deployed to CentOS 7.2, ASP. NET core application   write a lot of logs in /var/log/messages, these logs should not be written to this place, how can I adjust the configuration to solve this problem:
This is logs:
2017-06-14 17:31:54.4432|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|AuthenticationScheme: Cookies was successfully authenticated.
2017-06-14 17:31:57.7880|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request starting HTTP/1.1 GET http://power.cf.com/
2017-06-14 17:31:57.7889|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|HttpContext.User merged via AutomaticAuthentication from authenticationScheme: Cookies.
2017-06-14 17:31:57.7889|Microsoft.AspNetCore.Authorization.DefaultAuthorizationService|INFO|Authorization was successful for user: 5686.
2017-06-14 17:31:57.7889|Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker|INFO|Executing action method FIT.RightWay.Infrastructure.Web.Controllers.HomeController.Index (FIT.RightWay.Web) with arguments ((null)) - ModelState is Valid
2017-06-14 17:31:57.7889|Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor|INFO|Executing ViewResult, running view at path /Views/Home/Index.cshtml.
2017-06-14 17:31:57.7889|Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker|INFO|Executed action FIT.RightWay.Infrastructure.Web.Controllers.HomeController.Index (FIT.RightWay.Web) in 0.8751ms
2017-06-14 17:31:57.7889|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request finished in 2.2907ms 200 text/html; charset=utf-8
2017-06-14 17:31:57.8157|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request starting HTTP/1.1 GET http://power.cf.com/alifont.css
2017-06-14 17:31:57.8157|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|HttpContext.User merged via AutomaticAuthentication from authenticationScheme: Cookies.
2017-06-14 17:31:57.8168|Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware|INFO|The file /alifont.css was not modified
2017-06-14 17:31:57.8168|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request finished in 1.3016ms 304 text/css
2017-06-14 17:31:57.8396|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request starting HTTP/1.1 GET http://power.cf.com/style.css?36bfdce4f83ed4ca8b78
2017-06-14 17:31:57.8396|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|HttpContext.User merged via AutomaticAuthentication from authenticationScheme: Cookies.
2017-06-14 17:31:57.8396|Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware|INFO|The file /style.css was not modified
2017-06-14 17:31:57.8409|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request finished in 1.3109ms 304 text/css
2017-06-14 17:31:57.8880|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request starting HTTP/1.1 GET http://power.cf.com/app.js?36bfdce4f83ed4ca8b78
2017-06-14 17:31:57.8888|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|HttpContext.User merged via AutomaticAuthentication from authenticationScheme: Cookies.
2017-06-14 17:31:57.8888|Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware|INFO|The file /app.js was not modified
2017-06-14 17:31:57.8888|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request finished in 1.4013ms 304 application/javascript
2017-06-14 17:31:58.0124|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request starting HTTP/1.1 GET http://power.cf.com/me application/x-www-form-urlencoded
2017-06-14 17:31:58.0131|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|HttpContext.User merged via AutomaticAuthentication from authenticationScheme: Cookies.
2017-06-14 17:31:58.0131|Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker|INFO|Executing action method FIT.RightWay.Web.Controllers.AccountController.Me (FIT.RightWay.Web) with arguments ((null)) - ModelState is Valid
2017-06-14 17:31:58.0131|Microsoft.AspNetCore.Mvc.Formatters.Json.Internal.JsonResultExecutor|INFO|Executing JsonResult, writing value { StatusCode = 20000, Message = , Result = FIT.RightWay.Web.ViewModel.UserViewModel }.
2017-06-14 17:31:58.0131|Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker|INFO|Executed action FIT.RightWay.Web.Controllers.AccountController.Me (FIT.RightWay.Web) in 0.9083ms
2017-06-14 17:31:58.0131|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request finished in 2.4777ms 200 application/json; charset=utf-8
2017-06-14 17:31:58.0425|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request starting HTTP/1.1 GET http://power.cf.com/dispatch/get?api=%2Fapi%2FRight%2FUserOperations&type=2&queryString=systemId%3D25%26userName%3Dgeffzhang application/x-www-form-urlencoded
2017-06-14 17:31:58.0425|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|HttpContext.User merged via AutomaticAuthentication from authenticationScheme: Cookies.
2017-06-14 17:31:58.0425|Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker|INFO|Executing action method FIT.RightWay.Web.Controllers.DispatchController.Get (FIT.RightWay.Web) with arguments (/api/Right/UserOperations, systemId=25&userName=geffzhang, External) - ModelState is Valid
2017-06-14 17:31:58.0425|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|AuthenticationScheme: Cookies was successfully authenticated.
2017-06-14 17:31:58.9647|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request starting HTTP/1.1 GET http://power.cf.com/
2017-06-14 17:31:58.9655|Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware|INFO|HttpContext.User merged via AutomaticAuthentication from authenticationScheme: Cookies.
2017-06-14 17:31:58.9655|Microsoft.AspNetCore.Authorization.DefaultAuthorizationService|INFO|Authorization was successful for user: 5686.
2017-06-14 17:31:58.9655|Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker|INFO|Executing action method FIT.RightWay.Infrastructure.Web.Controllers.HomeController.Index (FIT.RightWay.Web) with arguments ((null)) - ModelState is Valid
2017-06-14 17:31:58.9655|Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor|INFO|Executing ViewResult, running view at path /Views/Home/Index.cshtml.
2017-06-14 17:31:58.9655|Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker|INFO|Executed action FIT.RightWay.Infrastructure.Web.Controllers.HomeController.Index (FIT.RightWay.Web) in 0.898ms
2017-06-14 17:31:58.9655|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request finished in 2.7536ms 200 text/html; charset=utf-8
2017-06-14 17:31:58.9933|Microsoft.AspNetCore.Hosting.Internal.WebHost|INFO|Request starting HTTP/1.1 GET http://power.cf.com/alifont.css

This isn't a kestrel issue. Logging verbosity can be controlled by changing your appsettings.json.

@davidfowl how to change appsetting.json ,this is my appsetting.json
"Logging": {
"IncludeScopes": false,
"LogLevel": {
"Default": "Debug",
"System": "Information",
"Microsoft": "Information"
}
}

More details on Logging can be found here: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/logging


Reporter refactoring

[ ] Since this PR suggests a bug fix, the relevant tests have been added.
[ ] Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
[ ] This PR is just a minor change, like a typo fix.

Please rename the dir modules to reporters


Ward Segfaults

I 've been trying to use this library via the Ward objects, but I've been running into issues with segfaults.
I tried setting up a consumer thread and a producer thread which each have a ward, and the consumer thread has the queue.
Running each thread individually works, but it seems there's some kind of race condition happening when they both interact which causes a segfault.
import loony
import loony/[Ward]
import std/[os]
type TestRef = ref object

const flags : set[WardFlag] = {PushPausable, Clearable, Pausable}

var queueChannel = Channel[ptr LoonyQueue[TestRef]]()
queueChannel.open()

proc consumerFn(): void =
    let queue = newLoonyQueue[TestRef]()
    var warden = newWard[TestRef](queue, flags)

    # Broadcast the queue address
    queueChannel.send(queue.addr)

    echo "Begin Popping via Consumer Warden"
    while true:
        var res = warden.pop()
        if res == nil:
            echo "Queue is empty."
        else:
            echo "Successfully Popped from queue via Warden."

proc producerFn(): void =
    var queueAddress : ptr LoonyQueue[TestRef] = nil
    # Hold until the queue address is received.
    while queueAddress == nil:
        var (ready, queueAddr) = queueChannel.try_recv()
        if ready:
            echo "Queue Address received"
            queueAddress = queueAddr

    echo "Begin Pushing via Producer Warden"
    let queue : LoonyQueue[TestRef] = cast[LoonyQueue[TestRef]](queueAddress)
    var warden = newWard[TestRef](queue, flags)
    while true:
        let testRef = new TestRef
        case warden.push(testRef):
            of true:
                echo "Successfully pushed to queue via Warden."
            of false:
                echo "Queue is full."

# Create a consumer thread
var consumerThread: Thread[void]
createThread(consumerThread, consumerFn)

# Create a producer thread
var producerThread: Thread[void]
createThread(producerThread, producerFn)

while true:
    sleep(1000)
    echo "Main Thread is still alive."

joinThread(producerThread)
joinThread(consumerThread)

Update: I was using the address directly to create a new queue, instead of dereferencing the queueAddress passed to the producer. Fixing that fixed the issue.

I would abstain from Wards if possible as they have had next to zero use
and are heavily untested.
I made them for Disruptek on request and then he ignored their existence 🤣
Will be happy to help in any way should you have questions.
On Thu, 9 May 2024 at 11:22 AM, marcgehman @.***> wrote:

Update: I was using the address directly to create a new queue, instead of
dereferencing the queueAddress passed to the producer. Fixing that fixed
the issue.
—
Reply to this email directly, view it on GitHub
https://github.com/nim-works/loony/issues/35#issuecomment-2101862048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN2EZW7EZXODKFVMIWK2LCDZBLTXPAVCNFSM6AAAAABHN5FWMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRHA3DEMBUHA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Don't limit mypy to nbqa

we've been typing tests all along but it seems this was never checked

Codecov Report

Merging #462 (8509249) into master (c5e532b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #462   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          713       713
=========================================
  Hits           713       713

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e532b...8509249. Read the comment docs.


Crash when running command

https://gist.github.com/BBoldt/d43ea894342356e8d62e696732bc641c
I'm assuming a server is down somewhere but not sure.

This has been fixed. The server was maved to a new address but apparently our library can't handle HTTP redirects properly. Therefore it is now running on both the old and the new address.


server: add view helper featureFlags

The view helper featureFlags can be used in templates. The behavior is a little bit different compared to FeatureFlags\Service. E.g., the call
  $this->featureFlags()->isEnabled('redesign')

does the following:

Check whether there is a query param featureFlagRedesign
Check whether there is a cookie feature-flags/redesign
Check whether redesign is enabled via the service (i.e. globally active)

So in templates, you can override the behavior both via query params and cookies

Closes #59


Is there any simple way to set minDate to current date? Or tomorrow?

Is there any simple way to set minDate to current date? Or tomorrow?  Like jQuery UI Datepicker set minDate as 0?

you can pass a property which value is moment().startOf('day');

Thanks!


"Available Balance" after staking confusing

As a user after depositing, seeing "available balance" is confusing. Instead, I would say  "Deposited Tokens"

@ashachaf Maybe adding a tooltip explaining the amount and the differences user can see between what he deposited to what is available?

less relevant with the portfolio and token page changes


add absolute img urls to media library

closes ENG-848
Links to img's from media library

Adds delete modal for media

TODO:

Confirm this works with CDN URLS on external media providers

@spbyrne  The empty state of the media manager looks a little off.

@logan-anderson That's fixed now 👍


Enable a11y addon for accessibility testing

Thanks Joseph, I'll be more careful next time and I also will try to make the build scripts working on Windows, what do you think ?

Thank you very much for your proposal.
Don't worry about it though, I just fixed it, I think.
If you are willing to contribute futher there is many more miningfull things on the todo list :)
Anyway thank you for that!


Realsense Viewer open depth stream exception occured in debug mode!!!

Required Info

Camera Model
D435I

Firmware Version
5.15.1

Operating System & Version
Win 10

Kernel Version (Linux Only)
/

Platform
PC

SDK Version
2.54.2

Language
C

Segment
others

Issue Description
I compiled the latest master branch of the librealsense SDK using the VS2022 compiler. The debug version I compiled crashes immediately when I run the realsense viewer and start the depth stream with a connected D435I device. The same thing happens when I switch the depth resolution and frame rate. However, starting the RGB or IR streams works normally, as shown in the picture.

The same phenomenon occurs when I use both VS2015 and VS2019.
However, it works normally in the release version.
I want to know if this is a known issue. Please help me to resolve it!

Hi @asla1  There was a previous report of this issue at https://github.com/IntelRealSense/librealsense/issues/10299 with the earlier 2.49.0 version of the Viewer when the SDK is built in debug mode.  In that case I suggested disabling GLSL support in the Viewer.  Instructions for doing so can be found at https://github.com/IntelRealSense/librealsense/issues/8110#issuecomment-754705023

@MartyG-RealSense  Thank you very much! It did help me!

That's great to hear, @asla1 - thanks very much for the update!

Case closed due to solution achieved and no further comments received.


Feature request: copy/paste-able download links with good filenames

Yesterday I posted a talk to OSF,
https://osf.io/mhwa5/
and I had a surprising amount of trouble getting a direct download link that I could curl.

The download button doesn't seem to have a link associated, so I couldn't copy-the-link for posting;
when I did find a direct download link (under Revisions, the download buttons there are direct links), it didn't have a sensible URL name so the curl -O saved a badly named file that had special characters in it.

To be clear, I can click on various places and (presumably through JavaScript magic) get the file to download. But I would like to be able to do this from e.g. command line or Python urllib.open as well, if possible, because that would let me use data files stored on the OSF in scripts and notebooks for teaching and research.
A typical solution to the filename problem is to have a "fake URL" that has all the right IDs to download the file encoded in it, and then ends with the filename that it should be saved under (which doesn't necessarily matter for retrieval, but is used by curl and wget and human readers).
Happy to discuss!

Hey @ctb, thanks for the feedback! This is certainly worth exploring/supporting, and I'll pass it along to the Product team.
In the interim, the download link for the current version of a file is:
osf.io/GUID/?action=download , where GUID is the 5 character ID for the file (in your case mhwa5)
Previous versions append "&version=#" where # is the version you want to download (so, for version 1 of your file, osf.io/mhwa5/?action=download&version=1)
You can also do https://api.osf.io/v2/guids/mhwa5/ and get the download link from that if you want a programatic way.

Use case illustrated in more detail here: https://github.com/spacegraphcats/spacegraphcats/blob/47ce4d26a83a13cc69690ca046ee77f40afd6946/Makefile#L83

OK! Found another use case that illustrates the problem quite well -- and this one I can't fix because it's hosted on another site :)
If I go to the UCSC genome browser here, https://genome.ucsc.edu/cgi-bin/hgCustom, and attempt to use an uploaded file as a custom track, it doesn't work. Specifically, choose mouse (mm10) and put the URL 'https://osf.io/87trm/download' in the top box ("paste URLs or data"). Then on submit I get the error
Error It appears that you are directly uploading binary data in an unrecognized format (https://files.osf.io/v1/resources/pyvfg/providers/osfstorage/595e8a0f9ad5a1022c00ceb5?action=download&version=1&direct).

In contrast, if I use the same file stored on github, https://raw.githubusercontent.com/ngs-docs/angus/2017/_static/SRR3152806.bw, it works fine.
I think what is going on is that UCSC is looking for a '.bw' on the end of the URL. Silly, I know, but there you are.
This is a really big use case (like, literally thousands of people want to do this with files too big for GitHub) and I can't figure out how to do it via OSF. It might be enough to update the URL so that you can include anything you want after download/ e.g download/SRR.bw...

curl -O -J -L https://osf.io/mhwa5/download
You'll need a newer version of curl which supports the Content-Disposition header.
see: https://stackoverflow.com/a/8841522

Ahh, interestingly, this was proposed in e-mail but didn't make its way on to this issue - thanks!
"Upgrade the software to the latest" is only a partial solution because a lot of the learners I teach are stuck on older OSes/installs.
Also, it does not address the problem in this comment where (for better or for worse) the UCSC folk have not implemented the grokking of Content-Disposition.

Reviewing the genome application source and website error messages, I believe these might be the two issues causing problems.

[x] WaterButler returning a ISO 8601 (incorrect) Last-Modified header.
Issue: https://github.com/CenterForOpenScience/waterbutler/issues/228
PR/Fix: https://github.com/CenterForOpenScience/waterbutler/commit/84074cbba0b06965c97f80a79440088a6cfbf36c

** works **
track type=bigWig name="Example One" description="A bigWig file222" bigDataUrl=https://files.osf.io/v1/resources/pyvfg/providers/osfstorage/595e8a0f9ad5a1022c00ceb5?action=download&version=1

[ ] The response to a valid /<guid>/download HEAD request is sending back a 200 rather than a 302 to get file metadata like Last-Modified from WaterButler.
PR/Fix:  https://github.com/CenterForOpenScience/osf.io/pull/7433

** pending hotfix deployment **
track type=bigWig name="Example One" description="A bigWig file222" bigDataUrl=https://osf.io/87trm/download

We'll have the OSF side released soon and I'll follow up.

Fixes have been applied and the following track configuration now works when providing a name parameter.
track type=bigWig name="Example One" bigDataUrl=https://osf.io/87trm/download

Reviewing the genome application code base a bit further capturing Content-Disposition appears to be possible @:
net.c -> netSkipHttpHeaderLinesWithRedirect -> netSkipHttpHeaderLinesHandlingRedirect
and it can be passed up the chain @:
customPp.c -> customPpNext-> netLineFileOpen

thank you VERY much - I will give it a try!

I can confirm the URL now works for me - thank you VERY much!

It is also worth mentioning adding the file name into the url on the OSF side is non-trivial / in some cases not possible due to the OSF Storage backend data de-duplication efforts.
Once authorization is handled between WaterButler <-> OSF (assuming the direct parameter is not included, which will soon be most). WaterButler will opt to sign a time sensitive URL, pass it back to the client and giving them the opportunity to download the file directly from the third party object store (S3, CloudFiles, etc...).
https://storage101.iad3.clouddrive.com/v1/MossoCloudFS_.../osf_storage/3044f194333361594118e20531e9f48ee05685930b50f66d7cfea75f23ae2aba?temp_url_expires=...&temp_url_sig=...&filename=SRR3152806.bw

As you can see the file name is a SHA256 value (for de-duplication), and in this case the storage provider uses a query parameter for the filename.
Hope this helps, happy to discuss further.

thanks for the explanation @icereval - really appreciate it.

I think this issue can be closed as fixed! thanks!


add table of contents to README.md [skip ci]

this PR just adds a ToC to our README.md

Did you create this manually or with a tool?

Started doing it manually until my IDE (VSC) suggested to autocomplete the rest by surprise :)


No link from Speech Services to parent Cognitive Services

Scenario:

A net new user to Cognitive Services, looking to learn about what is available.
Click on Speech Services documentation from a presentation or search result.

Problem:

There are no direct links or references to discover the parent category, Cognitive Services.

Describe the solution you'd like
Add a section to for "See Also" or "Other Cognitive Services" with links to Cognitive Services page.
Describe alternatives you've considered
Adding a sidebar or breadcrumbs links at the top of the page for
"Azure / Cognitive Services  / Speech Service"

@nitinme @trevorbye this is potentially feedback for someone on your team. Hub page feedback: no link from Speech service back to the bigger list of Cognitive Services
#assign:trevorbye


Vortex Scans Theme Change

Source information
Vortex Scans 1.4.40
Source language
English
Steps to reproduce
Goto Sources
Select Vortex Scans
Expected behavior
Shows lists of manga or when searched.
Actual behavior
Not showing lists of manga or when searched.
Mihon/Tachiyomi version
Mihon v0.17.1 / Yokai v1.9.6
Android version
Android 14
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Add a :+1: reaction to issues you find important.

Duplicate of #6448, Also, the theme hasn't changed as the extension is working; only the popular tab is showing 'no results found'.


NOR

when I create class extends AndroidFragmentApplication and implements ApplicationListener, it throws this error before View initializing (initializeForView called in onCreate),
I fix it by overriding onResumeFragments of my activity then if(androidFrag.getInput()!=null) super.onResumeFragments();..
but maybe there's a better solution should be added to the library... java.lang.NullPointerException: Attempt to invoke interface method 'void com.badlogic.gdx.backends.android.AndroidInput.onResume()' on a null object reference

You should be calling initializeForView in onCreateView, rather than onCreate.


version: post-release bump

Signed-off-by: Lars Holm Nielsen<EMAIL_ADDRESS>

Coverage remained the same at 99.552% when pulling 160499d025c2ab2caa08eb438bf62769eec40a30 on lnielsen:postrel into da932ea5a1a5478a2c1517ffa159c21ae807d184 on inveniosoftware:master.


Excel references and named ranges

Hi,
Thank you for creating this. It's something that I've wanted for a long time. I'm looking forward to trying it out.
Just a quick question, is it possible to also work with Excel references and named ranges?
I would like to do things like:
FROM Table1 WHERE Name=Sheet1!A1

In order to avoid ambiguity this could be under a namespace like "xl", e.g.
FROM xl.Table1 WHERE Name=xl.Sheet1.A1

Hi,
Glad you like the project!
Accessing ranges as tables would be a nice feature. For this to be feasible we'll need DuckDb.NET to support replacement scans
https://duckdb.org/docs/api/c/replacement_scans.html
I see there is an open issue for this
https://github.com/Giorgi/DuckDB.NET/issues/239
I'm not sure about the utility of using Excel references in the WHERE clauses? How is this more useful than constructing the string using Excel string functions and passing in the query?


Added Unsplash integration for searching and uploading images

Fixes #120
Fixes epic issue #29

Added Unsplash integration.

Used debounce search for throttling API.

Updated webpack configuration to load UNSPLASH_API_KEY in development mode.

New packages added:

axios
dotenv

Demo: https://vimeo.com/660737269/db942f726e

Figma link: https://www.figma.com/file/Osl7GBbBk0iwVMc57366nZ/neetoKB?node-id=322%3A8508

@goutham-subramanyam _a could you please work on the UI issues I mentioned in the same?
cc: @karthiknmenon, @amaldinesh7 please check if it meets the requirements.
NOTE: The Unsplash API will not work in the deployed link till the UNSPLASH_API_KEY environment variable is set on netlify.

Added @babel/plugin-transform-runtime plugin. The previous config did not permit async-await in builds. It used to crash the the netlify deployment when the Unsplash tab was clicked.
Ref: https://github.com/babel/babel/issues/9849

Added Masonry Layout:

@amaldinesh7 _a Please review.
cc: @AbhayVAshokan @karthiknmenon

Can we do something similar for the main landing page for neeto forms? //cc @karthiknmenon

And then Quiz.

@neerajdotname Yes. That's the goal.
This issue https://github.com/bigbinary/neeto-editor-tiptap/issues/103 will try to resolve the issue with aligning images. After this, we can use editor and similar approach for neetoForm (landing pages), neetoQuiz, and neetoKb.

@labeebklatif _a Please review.

@AbhayVAshokan Also, noted that when opening the Unplash tab, there are 2 redundant API calls fired at the initial load. Please check and limit this.

@labeebklatif _a please have a look at the changes.
Demo: https://vimeo.com/661460304/b53bd2700c
It would be best to merge this PR after making sure it works in production as well. Could you please mention someone with access to the Netlify account so that the API key can be added to the environment variables?

@labeebklatif _a please have a look at the changes. Demo: https://vimeo.com/661460304/b53bd2700c
It would be best to merge this PR after making sure it works in production as well. Could you please mention someone with access to the Netlify account so that the API key can be added to the environment variables?

@karthiknmenon Do you have access to Netlify for this?

@AbhayVAshokan Please update the documentation for Unsplash integration.

@labeebklatif _a please review the new changes.

@labeebklatif _a please review the new changes.


Package Dependency Issue for npcap.vm, wireshark, sfextract.vm

What's the problem?
I tried to install flare-vm using .\install.ps1 twice, and in both tries, I was unable to install npcap.vm, wireshark, sfextract.vm, Installing the packages using choco install -y didn't work either.
Steps to Reproduce
I tried to install flare-vm using .\install.ps1 twice, and in both tries, I was unable to install npcap.vm, wireshark, sfextract.vm, Installing the packages using choco install -y didn't work either.
Environment

VMWare Fusion Player 13.5.0
VM OS version: 10.0.22631
Powershell version: 5.1.22621.2506
choco version: 2.2.2
Boxstarter version: Boxstarter|3.0.3
2024/01/18 16:53:47 vm.common.psm1 [+] INFO : Host Information

VM OS version and Service Pack
Version                 : 10.0.22631
BuildNumber             : 22631
OSArchitecture          : ARM 64-bit Processor
ServicePackMajorVersion : 0
Caption                 : Microsoft Windows 11 Pro
VM OS RAM (MB)
4096
VM OS HDD Space / Usage
DeviceID DriveType ProviderName VolumeName                       Size        FreeSpace

C:       3<PHONE_NUMBER>0<PHONE_NUMBER>0
D:       5                      Windows11_22631.2861_Professiona<PHONE_NUMBER>  0
VM AV Details
AntiVirusProduct classname does not exist...

[NuGet] One or more unresolved package dependency constraints detected in the Chocolatey lib folder. All dependency constraints must be resolved to add or update packages. If these packages are being updated this message may be ignored, if not the following error(s) may be blocking the current package operation: 'wireshark.vm 4.2.0 constraint: npcap.vm ', 'wireshark.vm 4.2.0 constraint: wireshark (= 4.2.0)'
Unable to resolve dependency: Unable to find a version of 'common.vm' that is compatible with 'apktool.vm <IP_ADDRESS>40104 constraint: common.vm (>= <IP_ADDRESS>31221)', 'didier-stevens-suite.vm <IP_ADDRESS>31221 constraint: common.vm (>= <IP_ADDRESS>31221)', 'sysinternals.vm <IP_ADDRESS>40112 constraint: common.vm (>= <IP_ADDRESS>40111)'.
Chocolatey installed 0/1 packages. 1 packages failed.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Failures

npcap.vm - Unable to resolve dependency: Unable to find a version of 'common.vm' that is compatible with 'apktool.vm <IP_ADDRESS>40104 constraint: common.vm (>= <IP_ADDRESS>31221)', 'didier-stevens-suite.vm <IP_ADDRESS>31221 constraint: common.vm (>= <IP_ADDRESS>31221)', 'sysinternals.vm <IP_ADDRESS>40112 constraint: common.vm (>= <IP_ADDRESS>40111)'.
Chocolatey v2.2.2
Installing the following packages:
sfextract.vm
By installing, you accept licenses for the packages.
Progress: Downloading sfextract.vm 2.1.0... 100%

sfextract.vm v2.1.0
sfextract.vm package files install completed. Performing other installation steps.
ERROR: The term 'dotnet' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
The install of sfextract.vm was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\sfextract.vm\tools\chocolateyinstall.ps1'.
See log for details.
Chocolatey installed 0/1 packages. 1 packages failed.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Failures

sfextract.vm (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\sfextract.vm\tools\chocolateyinstall.ps1'.
See log for details.
1
True
OK
The install of installer.vm was successful.
Software installed to 'C:\Program Files\Wireshark'

Chocolatey installed 1/1 packages.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
True
Errors       : {}
ComputerName : localhost
Completed    : True
FinishTime   : 1/18/2024 4:31:06 PM
StartTime    : 1/18/2024 4:27:05 PM
log.txt
chocolatey.log
Detected by test suite
No

Thanks for the detailed report. Can you provide the config file (or the packages you selected if you used the GUI)?

For the first run, I ran without the GUI (-noGui) and the second run, the default packages were selected, and I added sfextract.vm.On 20 Jan 2024, at 1:08 AM, Ana María Martínez Gómez @.***> wrote:
Thanks for the detailed report. Can you provide the config file (or the packages you selected if you used the GUI)?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I tried to install the three packages using choco install -y npcap.vm, choco install -y wireshark and choco install -y sfextract.vm. However, all of them met with the same error:
PS C:\Windows\system32\WebThreatDefSvc > choco install -y npcap.vm
Chocolatey v2.2.2
Installing the following packages:
npcap.vm
By installing, you accept licenses for the packages.
[NuGet] Access to the path 'C:\Windows\system32\WebThreatDefSvc' is denied.
[NuGet] Access to the path 'C:\Windows\system32\WebThreatDefSvc' is denied.
[NuGet] Access to the path 'C:\Windows\system32\WebThreatDefSvc' is denied.
It seems like it could be a permissions issue, and I followed the steps from https://lazyadmin.nl/win-11/turn-off-windows-defender-windows-11-permanently/ to disable the Windows Defender permissions.

Can you please provide the whole console output when you run choco install -y npcap.vm? Please ensure you are running the command in a PowerShell console with admin rights.

@googlercolin is this still an issue? if so, can you please provide the required information?

Closing due to inactivity. Please re-open if you can provide the requested information.


BlockedThreadChecker.log not work in 4.0.0-x, but 3.x is work ok.

Questions
#522 had be close and I can't to reopen, I have to create this.
First thanks for your answer,  and hear 4.0 will released a few months :)
I will continue in Vertx 4 work.

BlockedThreadChecker.log not work in 4.0.0-milestone4 and 4.0.0-SNAPSHOT, but 3.9.0 is work ok.
I create a demo project, this test code is https://github.com/takeseem/takeseem-demo-vertx/blob/master/src/main/java/com/takeseem/demo/vertx/issues/VertxIssues522.java#L47

log4j2 2.13.1,  includeLocation="true"
in eclipse debug: StackLocator.calcLocation(StackLocator.java:79), but I found in fact it's logging-log4j2-java9 StackLocator.java:79, but in my classpath I can't found the log4j-api-java9.jar?
Exception in thread "vertx-blocked-thread-checker" java.lang.NullPointerException
	at org.apache.logging.log4j.util.StackLocator.calcLocation(StackLocator.java:79)
	at org.apache.logging.log4j.util.StackLocatorUtil.calcLocation(StackLocatorUtil.java:78)
	at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:409)
	at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:63)
	at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:153)
	at org.apache.logging.slf4j.Log4jLogger.log(Log4jLogger.java:376)
	at io.vertx.core.logging.SLF4JLogDelegate.log(SLF4JLogDelegate.java:188)
	at io.vertx.core.logging.SLF4JLogDelegate.log(SLF4JLogDelegate.java:160)
	at io.vertx.core.logging.SLF4JLogDelegate.log(SLF4JLogDelegate.java:156)
	at io.vertx.core.logging.SLF4JLogDelegate.warn(SLF4JLogDelegate.java:86)
	at io.vertx.core.impl.logging.LoggerAdapter.warn(LoggerAdapter.java:79)
	at io.vertx.core.impl.BlockedThreadChecker$1.run(BlockedThreadChecker.java:59)
	at java.base/java.util.TimerThread.mainLoop(Timer.java:556)
	at java.base/java.util.TimerThread.run(Timer.java:506)

Version

4.0.0-milestone4
4.0.0-SNAPSHOT

Context
Do you have a reproducer?
Steps to reproduce
Extra

Ubuntu 18.04.4 LTS
OpenJDK 64-Bit Server VM (build 14+36-1461, mixed mode, sharing)

thanks I will have a look at the reproducer

in this project the class StackLocator is in the log4j-api 2.13.1 jar

this class is present using multi release jar feature:
MBP-de-julien:2.13.1 julien$ jar -tvf log4j-api-2.13.1.jar | grep StackLocator
  5612 Tue Feb 25 19:52:58 CET 2020 org/apache/logging/log4j/util/StackLocator.class
  1894 Tue Feb 25 19:52:54 CET 2020 META-INF/versions/9/org/apache/logging/log4j/util/StackLocator$FqcnCallerLocator.class
  2553 Tue Feb 25 19:53:00 CET 2020 org/apache/logging/log4j/util/StackLocatorUtil.class
  7373 Tue Feb 25 19:52:54 CET 2020 META-INF/versions/9/org/apache/logging/log4j/util/StackLocator.class

it is a bug in log4j : https://issues.apache.org/jira/browse/LOG4J2-2809

there is no release with this fix yet.


Convert OpenTSDB to service

Overview
This pull request converts the OpenTSDB server into a service and adds some tests.

+1 on green build.

I also reviewed this code, particularly to see if it had implications for https://github.com/influxdb/influxdb/issues/2799. The WaitGroup  handling here seems OK, so +1 from me.

Obviously +1 on a green build, as per @corylanou

I don't where the PointsWriter is supplied to this service, by the production code.

@otoolep Ah, damn, good catch. Fixed in b688ecc.

OK, let's get it in. Thanks for the final changes.


Multi-channel architecture in keras

I am trying to implement the multi-channel CNN architecture that uses two word embedding channels proposed in [1].
From the paper: "In the multi-channel architecture [...], each filter is applied to both channels and the results are added to calculate (the feature generated by each filter for a window)."
As I understand, we slide each filter over the windows for each channel. This produces an output vector of length n - h + 1 where n is the sequence length and h is the window size. Is this correct?
My question is now how to implement this in keras so that the same convolution applies to the windows at each position in the channel.
My intuitive approach was having a Graph network which takes the channels stored in inputs and applies a convolution on them:
graph.add_node(Convolution1D(nb_filter=nb_filters, filter_length=7, border_mode="valid",
                                                 activation="relu", subsample_length=1),
                                   name='conv, inputs=inputs, merge_mode='concat')

However, this doesn't seem to match with my understanding of the architecture above, where the values are added after the convolution and are not merged before.
Can you help me? Thanks a lot in advance!
Kim, Y. (2014). Convolutional Neural Networks for Sentence Classification. Retrieved from http://arxiv.org/abs/1408.5882

Hi Sebastian have you had any luck in solving this? Regards and Thanks

Hey @devroy73, thanks for checking in. I ended up using a separate Merge layer instead, which seemed to work.

Hi Sebastian it would be great if you could share the snippet

As @sebastianruder mentions, I believe that it can be done in a separate Merge layer.  Here's a post where someone tried to do something similar by using one channel for word2vec embeddings and another for GloVe embeddings.  I've not tried this yet<EMAIL_ADDRESS>


Should HttpServerCodec issue 100 continue responses when there's no HttpObjectAggregator in the pipeline?

A http server pipeline with both HttpServerCodec and HttpObjectAggregator installed will do the right thing for requests with 'expect: 100 continue' headers but removing the object aggregator leaves users rolling their own handling as seen in netty's http server hello world example.
If HttpServerCodec is intended to be the 'batteries included' protocol implementation it seems like it could take the burden off application writers by issuing 100 CONTINUE responses when there is no HttpObjectAggregator instance in the pipeline thereby saving clients the timeout before proceeding with the payload.
This behavior exists in 4.1.0.CR7 (and has for a long time I think).

It depends on the use-case and would have to be a configurable option. We're using Netty to implement something like a proxy server and it'd be fatal if HttpServerCodec would start issuing 100s on its own.

@dschobel - The HttpObjectAggregator is designed to give users a "simple" FullHttpMessage in the pipeline, and has some knowledge of the maxRequestSize. If HttpObjectAggregator can infer the body size from the headers it can make an informed decision and accept/reject the continue request, and if it cannot infer the body size it will enforce maxRequestSize as data is read. HttpServerCodec currently has no knowledge of how much data is OK, or other constraints that may impact the server's response to a continue request. If you are interested in submitting a PR to make HttpServerCodec accept some sort of pluggable policy (as indicated by @rkapsi) can you elaborate on what ideas you have in this area?

@Scottmitch yep, a HttpServerCodec application without HttpObjectAggregator doesn't have enough information to intelligently reject/accept based on headers but by ignoring the header we're not changing the outcome for clients, when netty is acting as an origin server we're only delaying the request which leaves application writers having to include some boiler plate as in the hello world example.
As @rkapsi points out, ignoring the header does make HttpServerCodec usable for proxying but that's the crux of the issue in my view, it seems like arbitrary coupling to tie HttpObjectAggregator with origin server friendly behavior (managing 100 CONTINUE responses) and HttpServerCodec to proxy friendly behavior.
There are a lot of ways to skin the configuration cat, we could either say that HttpServerCodec and HttpObjectAggregator both will do the origin server friendly thing of managing 100 CONTINUE and then people who want to build proxies can either use HttpResponseDecoder directly, or we could introduce some parallel HttpProxyServerCodec handler which ignore the header, or otherwise have a policy param on HttpServerCodec.

we could either say that HttpServerCodec and HttpObjectAggregator both will do the origin server friendly thing of managing 100 CONTINUE

It seems a bit strange to have the 100 continue maintained in 2 places. HttpServerCodec and HttpObjectAggregator can exist in the pipeline at the same time so it may be a confusing to have the logic duplicated in the pipeline.

it seems like arbitrary coupling to tie HttpObjectAggregator with origin server friendly behavior

IIUC the intention is not focused on being origin/proxy friendly but more that if HttpObjectAggregator didn't handle 100-continue the server may not make progress. Users that put HttpObjectAggregator in the pipeline only expect to handle FullHttpMessage objects after this, and if HttpObjectAggregator doesn't respond to the 100-continue the client may never issue the request.

or otherwise have a policy param on HttpServerCodec.

I would be interested in hearing more here. My concerns are duplication of concerns and maintaining existing behavior by default.

It seems a bit strange to have the 100 continue maintained in 2 places. HttpServerCodec and HttpObjectAggregator can exist in the pipeline at the same time so it may be a confusing to have the logic duplicated in the pipeline.

That's fair but I think tolerable since it will be a (small I think) burden on the codec maintainers vs the benefit to the server writers of not timing out their clients expect-continue timer or copying boiler plate.
I think the complexity will amount to:
if (!object aggregator in pipeline && request has expect: continue header)
  send 100 CONTINUE

and the object aggregator doesn't need to be touched.
If the goal is to be tolerant of dodgey clients that wait forever for the 100 CONTINUE then it seems reasonable to be tolerant even when the server isn't aggregating chunks.

I would be interested in hearing more here. My concerns are duplication of responsibility and maintaining existing behavior by default.

Concretely, I think this can solved in a small way with the change above to HttpServerCodec. If we want to be behavior compatible with the current implementation, we can paramterize the ctor and default behavior off.
Even then the expect-continue handling becomes more visible to users as it becomes part of the java doc rather than a snippet of code to copy/paste from the tutorial.
If you're open to a big change (ie; for the 5.x branch) then there can be a single overarching HttpServerCodec which manages the codec + aggregator handlers for you and will save us from having to introspect on the pipeline. Whether to aggregate chunks becomes a param on the new super-codec and expect-continue behavior is a policy param.

@dschobel - It is not ideal for one handler to look for another handler's presence in the pipeline ... kinda breaks the boundaries between handlers. What about creating some sort of HttpContinueRequestHandler which can intercept the "expect continue" request and call some overridable method which by default just responds with 100 continue. This way the user would have to explicitly add this into the pipeline to get this behavior. So the pipeline would look like:
pipeline.addLast(new HttpServerCodec(...));
pipeline.addLast(new HttpContinueRequestHandler(...)); // by default just send 100-continue
// It is now much more clear that the previous handler will handle continue requests and does
// not change the existing behavior of any handlers ...

@Scottmitch that definitely works, it's the solution we arrived at for finagle where the handler is conditionally installed depending on whether chunk aggregation is configured.
pipeline.addLast(HttpServerCodec(...))
if (streaming) { pipeline.addLast(new HttpContinueRequestHandler(...)) }
else { pipeline.addLast(HttpObjectAggregator(...)) }

that's already less boilerplate so I'm happy with that if inspecting the pipeline is a non-starter and bundling aggregation as part of a new handler that manages the codec is too big of a change.

@dschobel - Yes this is what I had in mind ... looks like you guys already figured it out :)  Are you interested in contributing this to Netty?

if inspecting the pipeline is a non-starter

best to avoid this if we can IMO

sounds good, I'll take a crack at the PR next week.

@dschobel thanks buddy!

@dschobel ping

@normanmaurer I'm going on leave for 6 weeks as of today so I won't get to this before I'm back but I'd still like to contribute this back from finagle.

@dschobel ping


Window size larger than declared

Hi,
I noticed the windows created with Glutin are far bigger than the specified size, anyone knows how to fix this issue? example >>
You can  see the value on the code is smaller
thanks
This is on Linux

Hi
says hipdi factor: 1.5
weird cause I have a normal 1080 laptop
thanks

Actually this happened in both my 4K monitor and 1080 laptop

@varomix On X11, you can figure out the dimensions Xorg thinks your screen has using xrandr | grep mm We do some simple math using those numbers to decide the dpi, see https://github.com/tomaka/winit/blob/3c59283b3fbf409353413c0c0d7d39ae85287e60/src/platform/linux/x11/util/randr.rs#L7
The formula is Max(((width_px * height_px) / (width_mm * height_mm) * (12.0 * 25.4 / 96.0)).round() / 12.0, 1). If you want, you can try computing it manually using the numbers xrandr provides.
If xrandr provides the wrong dimensions for your monitor, you might consider manually correcting them as according to here: https://bbs.archlinux.org/viewtopic.php?id=239789

Closing. If this is still an issue, file it with winit.


Make memory to build UI more configurable

Describe the bug
Currently, we "hardcode" & require 8GB of available memory to build the Angular UI.  See this setting:
https://github.com/DSpace/dspace-angular/blob/main/package.json#L26
Ideally, we should support systems which have less than 8GB of available memory, as there's no reason (that I can tell) for this default setting except that it speeds up the build on systems which have more memory available.  There's no way to easily override this default setting, unless you manually edit the package.json before building the UI.
Should we consider removing the --max_old_space_size=8192 flag in that setting?  That would allow users more control over how much memory they wanted to provide by using the NODE_OPTIONS environment variable, like:
NODE_OPTIONS="--max_old_space_size=8192" yarn start
(The downside to this approach appears to be that --max_old_space_size seems to default to 512MB, which is really low)
UPDATE: In Node v12, it appears that Node might automatically just use "available memory".  See "Properly configure default heap limits" section here: https://nodejs.medium.com/introducing-node-js-12-76c41a1b3f3f
Obviously, if we remove this default, we may want to update our CI build process to still use 8GB by setting this environment variable in our build.yml: https://github.com/DSpace/dspace-angular/blob/main/.github/workflows/build.yml#L12

@artlowel and @atarix83 : I'd appreciate your (very quick) opinions on this.  I suspect this might help make it easier for people to build the UI on lower memory machines, but I also realize that will make the build much slower as a result.
Another option here could be to change the default to 2-4GB (which should work for everyone), but allow a way for CI & developers to override that value easily.
This is low priority right now, but just wanted quick feedback on the idea.

A 2GB default is what I'm currently using for the UI build, on an AWS ec2 t3.medium instance (4GB RAM... which is the same size of VM I'm using for our API instance).

From chatting with @hardyoyo on Slack, it sounds like he's tested that Node v12 (and above) manage the memory automatically (by using any available memory as noted in https://nodejs.medium.com/introducing-node-js-12-76c41a1b3f3f).  So, it appears that the --max_old_space_size setting is not necessary in Node v12, unless you want to limit it to a subset of available memory.
Therefore, it might be worth considering removing this setting from our package.json, and also recommending installation on Node v12 (for it's better memory management).  We can still keep Node v10 support.   (And @mwoodiupui noted on Slack that he's been running on Node v14 for some time with no issues)

I've verified that it works without --max_old_space_size, on node 12 and 14. Since, in order to test it, I had to make the changes anyway I created a PR: #1038
Node 10 is EOL in April this year, so I wouldn't worry about supporting it too much

It turns out that with node 12 the max amount of memory is still only 2GB: https://github.com/nodejs/node/issues/28202
This seems a likely cause for the issues we've been having with the demo server. I've set the max higher using an environment variable for now. We'll see whether that improves stability. If it does, it still doesn't mean we have to add that flag to our yarn script again, but we may have to add it to the docs.


Fix capstone installation

Python-capstone is no longer up-to-date with the current python2 capstone, so it was removed in favor of the pip capstone. However, if not removed through APT pkg manager, pip can't install capstone properly.
Modified the state to remove python-capstone first, then install capstone using pip.

Thanks @digitalsleuth. Please add a require Pkg statement to the pip install to ensure the previous runs successfully before it’ll allow the pip install to run.

Done, thanks for pointing that out!


Fix links which pointed to unavailable location

Routes /docs/concepts/#kubernetes-control-plane and /docs/concepts/#kubernetes-objects don't work as they are expected, due to unimplemented pages perhaps. Could be better if they directly point to topics.
fix https://github.com/kubernetes/website/issues/22867

Hi @zacharysarah
It's my first contribution to this repo. Would you please review it when you are free? Many Thanks! 😃
/assign @zacharysarah

Hi @jimangel @kbarnard10
Seems Zach is on vacation now. Do you mind if I assign this PR to you? Thank you! 😃
/assign @jimangel
/assign @kbarnard10

Hello @blueabysm . Thanks for opening this PR.
To enable quick reviews, it is a good idea to limit a pull request to one language.
/cc @kubernetes/sig-docs-ja-reviews @kubernetes/sig-docs-zh-reviews @kubernetes/sig-docs-it-reviews
/cc @kubernetes/sig-docs-id-reviews @kubernetes/sig-docs-pt-reviews

Hi @kbhawkey! Thank you for your advice!😃 It's because the same unavailable links exist in different language folders, so I was not sure if I should replace all of them at one time or just replace them for only one language.
Do I need to close this PR and open another one with only one language edited, or just waiting for approvals?

Some Page previews:
https://deploy-preview-22922--kubernetes-io-master-staging.netlify.app/docs/concepts/architecture/controller/
https://deploy-preview-22922--kubernetes-io-master-staging.netlify.app/docs/concepts/extend-kubernetes/operator/

👋 @blueabysm . It would be nice to get these changes reviewed within a few days.

@kbhawkey thanks for your quite valuable review. I've read and agree with them. Currently I'm not at a computer but with a smartphone, so would you mind if I update them in hours later? It's 4:19 AM here😂.

Thank you @sftim 🙂. I'll update later. So next time if I need to fix a linking issue, I should limit my PR to only one language even if it appears in multiple languages right?

Sure, when you have time.


Adding missing use into ValidationException

Adding missing use that made that when something is wrong with validation, everything blows

Thanks :)


Additional Payment technologies

Hey @AliasIO
Navigating in this page https://busyferns.ca/ I found put that they support multiple payment technologies we are not identifying form the homepage
Some of them are specific to the apple pay support :

"visa","masterCard","amex","interac"
-> Apple Pay
-----> American Express
-----> MasterCard
-----> Visa
-----> Interact (Canada only)
They also support Shopify Pay:

And Paypal, that we should be able to identify but we are not:

They also mention that the support google Pay

But I only found evidence of supporting google merchant in their code:

But when you enter in a checkout page, there you are able to see  it more clearly, ie: https://busyferns.ca/24400363625/checkouts/a7f0c0edfe66d137bca5222e8350bec3

You may request a new technology to be added but changes of having it included are greatly improved if you submit a pull request. Please refer to the documentation.

I think this is relevant to why google pay is supported by Shopify pay : https://news.shopify.com/hey-google-install-shopify-payments

I added several payment technologies in a340675c916edadda8dc64665e4340d816ba53b0 based on these patterns, but they're specific to Shopify. It's a start but we'll need more patterns to make detection more general.

@AliasIO - Generic way to look for Apple Pay is to look for presence of file https://busyferns.ca/.well-known/apple-developer-merchantid-domain-association.txt
For example - this site has https://busyferns.ca/.well-known/apple-developer-merchantid-domain-association.txt

The extension doesn't make network requests so we can't check for the .well-known file. The meta tags are great though.

@AliasIO - How will you se META for Amazon Pay example? There is no 'name' and 'content' property in it

@rockeynebhwani Like this: https://github.com/AliasIO/wappalyzer/commit/49d979e5305ca817e3bdaec260f8c52aed93455a#diff-557d7d60c04092a680ce152f367618c0R1021

Thanks @AliasIO .. I see.. I was hoping to use META detection but I see that you have gone for HTML route in this case.

@AliasIO - One more detection pattern for Amazon pay

Look for script https://static-eu.payments-amazon.com/OffAmazonPayments/gbp/lpa/js/Widgets.js (End point can also be https://static-na.payments-amazon.com depending on geography so best to look for static-*.payments-amazon.com
Look for window.onAmazonPaymentsReady
Example site - https://www.insulationsuperstore.co.uk/
Amazon documentation on this - https://developer.amazon.com/docs/amazon-pay-onetime/add-a-button.html

@rockeynebhwani I added the script but onAmazonLoginReady appears to be for 'Login with Amazon', which I'll add as a social login technology.

Thanks @AliasIO ..  I am seeing some detections not working  correctly. Have a look on https://niococktails.co.uk/ (see screenshot below). I am on 6.2.3 v of chrome extension

@AliasIO  - PayPal is not being detected on https://www.moonglow.com/?lang=fr. This link has PayPal meta data. We can use this to identify PayPal


workflow added for auto assign author

Associated Issue
Closes #42
Implemented Solution

Added a GitHub action in the workflows directory that will automatically add the GitHub user as assignee to the pull request that they have created.

Took reference from the link provided in the issue.

@all-contributors please add @AdityaJ7 for maintenance


Is it possible to use preact with other doms?

For example, libraries like pixi.js, three.js, nativescript have their own dom.
Or is it only support html?

Preact is specialized for the HTML DOM. For other use-cases it probably makes more sense to use React. That being said, part of the current refactoring will involve splitting DOM access into a separate module, which would make it possible to use custom DOM backends.

Preact is specialized for the HTML DOM. For other use-cases it probably makes more sense to use React. That being said, part of the current refactoring will involve splitting DOM access into a separate module, which would make it possible to use custom DOM backends.


proper policy for marathon-lb missing in docs

Expected Behavior
In the explanation for marathon-lb https://docs.projectcalico.org/v2.6/getting-started/mesos/tutorials/connecting-tasks#load-balancing--external-service-discovery
There are no steps regarding how does the policy have to be design to let marathon-lb access the calico networks
currently I use for this
    ingress:
    - action: allow
      protocol: tcp
      source:
        nets:
        - <IP_ADDRESS>/32
        - <IP_ADDRESS>/32
        - <IP_ADDRESS>/32
      destination:
        ports: [80]

where the IP adresses are the hostIPs of the public nodes
I dont think this is best practice,since it is quite unflexible
But I am not sure what is best practice (maybe using mesos dns somehow? )
Your Environment

Calico version 2.6
Orchestrator version: mesos - DC/OS 1.10.2
Operating System and version: Centos 7

I think that's the best available in Calico v2.6. Later releases introduce global network sets, which provide a better abstraction here, but Calico v2.6 is the last version to support integration with Mesos / Marathon.


LineStrips3D ignores color if num_strips divisible by four or equals three

Describe the bug
rr.LineStrips3D(strips, colors) ignores the colors argument and makes all lines white if len(strips) % 4 = 0 or len(strips) == 3.
To Reproduce
strips = [[[0, 0, 0], [0, 0, 1]]]
colors = [0x00FF00FF] # green
for n in range(30):
    rr.log(
        "linestrips3d", rr.LineStrips3D(strips=n * strips, colors=n * colors)
    )

Desktop (please complete the following information):

OS: macOS Sequoia 15.1

Rerun version
Local client: rerun-cli 0.18.2 [rustc 1.76.0 (07dca489a 2024-02-04), LLVM 17.0.6] aarch64-apple-darwin release-0.18.2 59ff15b, built 2024-08-29T13:55:42Z

wow. that's.. impressive Oo
Repros cleanly on main. It's an SDK issue given that the data doesn't get through. Given how language dependent this is I suspect it's a Python SDK only issue.
Good frame:

Bad frame:

Thanks @Wumpf for jumping on this fast!
Also, I think you mixed up "good" and "bad" there.

This is a bug in rgba32_ext.py. Confirmed it affects other primitives such as Points3D.
In short, the python API is trying to be way too clever with precedence of multi-representation of colors combined with our lazy batch-conversion.
Concretely consider we support:

color = int (0x00ff00)
color = [int] ([0, 255, 0] or [0, 255, 0, 255])
colors = [color1, color2, color3, color4] ([0x00ff00, 0x00ff00, 0x00ff00, 0x00ff00], ...)
colors = color ([0, 255, 0, 255], ...)

It's clear there's an ambiguity between an array of colors represented as ints, and a single RGBA represented as an array.

fwiw, we actually try to handle this ambiguity here, but you need to be explicit about your types.
https://github.com/rerun-io/rerun/blob/jleibs/rrdp_wheels/rerun_py/rerun_sdk/rerun/datatypes/rgba32_ext.py#L76
Confirmed this works around the issue:
import rerun as rr
import numpy as np

rr.init("rerun_example_colorbad", spawn=True)

point = [[0, 0, 0]]
colors = [0x00FF00FF]  # green

for n in range(30):
    colors = np.array(n * colors, dtype=np.uint32)
    rr.log("points3d", rr.Points3D(positions=n * point, colors=colors))

Thanks @jleibs for the help!


How to use formidable with stream

Hi,
I use formidable to get selected file from the FS , I've file index.html (source)
and different file that call index.html (target) and I want to override the target from the source .
https://coligo.io/building-ajax-file-uploader-with-node/
`form.on('file', function(field, file) {
    fs.rename(file.path, path.join(form.uploadDir, file.name));
});`

Now after I got the file I need override the file for this specific path,
const writeStream = sftp.createWriteStream("/resources/index.html");
is it possible ?  I dont want to use the upload folder  I just want to pick file from the FS and put it in specific path and override the original

I just want to pick file from the FS and put it in specific path and override the original

If I got it correctly, then you need to give form.on('fileBegin',...) event a try. Use that event and change file.path inside it to the path you want. Then you will not need to rename it manually using fs.rename().

Is it resolved? Closing for now.


Add stronger typing to Container.get() via usage of generics

First, thanks for your work on this library. I've been using it extensively for over a year now :smile:
Motivation
The current Container.get() returns any, which means you need an explicit type annotation or cast afterward in order to get any type safety.
By using generics, we can make the typescript compiler a little smarter - it can assume that the type you get out of Container.get() is the same type you pass to it.
// old
const foo = Container.get(Foo); // Inferred type of `foo` is `any`.
const foo: Foo = Container.get(Foo); // Explicit type annotation makes type `foo`.
const foo = Container.get(Foo) as Foo; // Explicit cast make type `foo`.

// new
const foo = Container.get(Foo); // Inferred type of `foo` is `Foo`, no need for type annotations or casting.

The new function signature
I originally tried to use new(...args: Array<any>): T, but this doesn't work for abstract classes because abstract constructors don't match that type signature.
So, after seeing https://stackoverflow.com/questions/36886082/abstract-constructor-type-in-typescript#38642922, it looks like the type Function & {prototype: T} encompasses both concrete and abstract classes and should cover all use cases

Coverage remained the same at 91.353% when pulling 2b4ec2ff3d758b65696b7208e5313526769541cd on ccl2of4:stronger-typing into ab4e827d1b4cd3a1cb4293aa11b5a5586c3bda6e on thiagobustamante:master.


Support use of arquillian REST protocol

Ensure that requests from the arquillian framework itself are ignored by the InMemorySpanExporter
Remove reference to the servlet API
Avoid using "/" path in a test application

The arquillian rest protocol includes a rest resource class with @Path("/"). Autodiscovery for the test application is also picking up the arquillian class. If the test application also has a resource method mapped to "/", the server will fail a request to that path.

Fixes #72

It's worth noting there are other ways to fix this problem.
We could start a test span at the start of each test without the parent context. When we query the InMemorySpanExporter, we could look only for spans with a traceId which matches the test span. However, this may make it harder to tell what has gone wrong if a test fails since the span is not found rather than found with the wrong traceId. It also makes it harder to ensure that the implementation is not accidentally making extra spans with a different traceId. In the OpenLiberty tests we get around this by logging if the InMemorySpanExporter exports a span which is not claimed by any test at app shutdown and then checking the logs, but we can't do that in the TCK.
The problem of having a test REST application pick up the Arquillian REST resource, causing a conflict if the test application has a resource mapped to "/" is very unfortunate. I'd like to see if there's anything we can do in Arquillian to avoid this happening.
We could work around it by implementing getClasses() to avoid triggering autodiscovery, but we'd need to do that consistently in every test application.


NVIDIA 465 beta driver breaks suspend, due to lacking nvidia-sleep.sh script

In
https://github.com/NixOS/nixpkgs/pull/73530/files#diff-98b29c6e49617265eccb2562afa3a70ba277e6af9508d908c001a4ed398b5e48R49
nvidia-sleep.sh is installed if it exists, and the install siliently continues if it doesn't exist.
    # Install systemd power management executables
    if [ -e nvidia-sleep.sh ]; then
        sed -E 's#(PATH=).*#\1"$PATH"#' nvidia-sleep.sh > nvidia-sleep.sh.fixed
        install -Dm755 nvidia-sleep.sh.fixed $out/bin/nvidia-sleep.sh
    fi

In the service
https://github.com/NixOS/nixpkgs/pull/73530/files#diff-28ea4da3a9a595f8bd1a37a555c229f998f3a11b0715ebc5842ba266384eba73R247
          ExecStart = "${nvidia_x11.out}/bin/nvidia-sleep.sh '${state}'";

the script is executed unconditionally, even if the script doesn't exist.
That breaks suspend with the 465 beta driver, because there the script does not exist.
I think we should

[ ] fail loudly if it doesn't exist (so that if you close the laptop and put it in a bag, it doesn't catch fire)
[ ] figure out where the script went / what the replacement is.

CC @lovesegfault @eadwu

I will look into this in an hour or two, have a thing to do soon.


Fix interception of subcommand --version flag by cargo

Addresses #2286: when subcommand used execute_main_without_stdin and provided --version flag, cargo intercepted it and printed it's own version.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks! Could you add a test for this as well?

I have two ideas for a test:

check that cargo::flags_from_args() decodes --version flag into flag_version == true, where flag_version is a member of flags struct. Problem: cargo::flags_from_args() is private.
use existing testing facilities to spawn a process running dummy subcommand and compare stdout like in a lot of existing tests. Problem: dummy subcommand needs to call execute_main_without_stdin so it depends on cargo and rustc-serialize (I assume that dummy subcommand inside a test shouldn't have such dependencies).

I've tried to implement both, but haven't succeeded yet with either of them. Are these approaches even worth an effort or should I try to come up with something else?

Ah I was thinking of making a test which generates a dummy subcommand that always prints a constant string and then cargo dummy --version should print the dummy string instead of Cargo's own version.
There should be a few examples in the tests I believe of custom subcommands being run.

That test won't fail even without the fix. When subcommand doesn't use execute_main_without_stdin, cargo invokes its main and subcommand handles any following arguments. flags_from_args is not invoked and the defect isn't triggered.

I added a test, which calls call_main_without_stdin and should return a string with subcommand version information. Without the fix it panics, because docopt::decode() returns a Version error, indicating that the special handling of --version flag is enabled.

Oh sorry I meant writing a test for the cargo binary itself (e.g. literally running cargo foo --version).
You can install local subcommands in tests via something similar to this test case.

I understood that and I said, that if this dummy subcommand only has println!(...) inside its main, then it won't print cargo's version, since cargo intercepted the flag in the flags_from_args function and it isn't called in such a dummy subcommand. Lots of 3rd party subcommands don't use execute_main_without_stdin and they parse arguments themselves — these subcommands didn't have the problem I'm fixing.
Therefore I think that testing for this defect should include calling execute_main_without_stdin or some other function down the line. Since writing a dummy subcommand with that call requires that it depends on cargo and rustc-serialize, I decided to write a test calling call_main_without_stdin directly (it's call_... and not execute_... because the latter returns unit and I had to test something).
I'm sorry if my logic here is flawed due to the lack of experience.

Ah sorry, but what I mean to say is that the interface for calling subcommands is not through a helper function in Cargo itself (e.g. call_main_without_stdin) but rather through invoking a whole new process with new arguments.
The bug here is that cargo foo --version never executes cargo-foo, when instead that should be invoked as cargo-foo foo --version. I'd prefer to avoid these Cargo helper functions in tests as that's not where the bug really is here I believe, but rather with the process-spawn-didn't-happen.

Okay, let's say that I run cargo new --bin cargo-foo and then cargo install --path cargo-foo cargo-foo (with cargo here being a stable version or a binary built from master). Do you expect that cargo foo --version will print cargo's own version? The experience I have on my computer is that it will print Hello, world!, indicating that the cargo-foo process is in fact spawned. Perhaps that's not what you experience, which might be due to configuration issues on my computer (unlikely though as stable cargo from brew prints Hello, world!).
Here's my version of what happens: when cargo foo --version is called, cargo's main calls execute_main_without_stdin, inside of which docopt parses command as cargo <command> [<args> ...] therefore leaving --version flag untouched. Then execute callback is called, which indirectly starts cargo-foo binary. That's where execute_main_without_stdin is called another time, only now docopt detects --version flag and since the special handling of this flag was enabled, docopt::decode() now returns an Err, containing a Version variant of docopt::Error enum with cargo's version baked into it. Then somewhere down the line the error-handling code is invoked which prints the contents of error — cargo's version.
That's not to say that I am fascinated by how the test turned out to be. If I knew how to write a test without violating project's conventions, I would happily do that.

Wait sorry I clearly have no idea what this bug is about. @sfackler are you using Cargo's infrastructure and you're not able to print your own version?

He mentioned that he was using Cargo's infrastructure in the issue (#2286).

@alexcrichton this code can never be reached because cargo does this unconditionally.

Ok, sorry for the roundabout @antonlarin, definitely my fault! Thanks for the clarifications though @safckler and @antonlarin!
@bors: r+ 131719858d58da2721d381c11b3857fa10dd2138

:hourglass: Testing commit 1317198 with merge 289411b...

@alexcrichton that's fine, I'm sure you have more important issues to keep in your mind than E-easy ones. :smile:

:broken_heart: Test failed - cargo-win-msvc-64

@bors: retry
On Mon, Feb 1, 2016 at 11:44 AM, bors<EMAIL_ADDRESS>wrote:

[image: :broken_heart:] Test failed - cargo-win-msvc-64
http://buildbot.rust-lang.org/builders/cargo-win-msvc-64/builds/284
—
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/cargo/pull/2336#issuecomment-178147685.

:zap: Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32 are reusable. Rebuilding only cargo-mac-32, cargo-win-msvc-64...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64


Bug: Graphic EQ Audio Unit Plug-in crashes often

[x] I have checked for a similar issue and sure it hasn't been reported before.

Describe the bug
Several times per day, eqMac will crash and then re-launch, showing a dialog explaining that the Graphic EQ Audio Unit Plug-in has crashed. Additionally, when this happens, the Graphic EQ is removed from all presets.
Steps to Reproduce

In the Extra Effects panel, click "Add Effect" and select "Apple: Graphic EQ"
Configure the EQ to preference (doubtful the actual values matter here)
In the Extra Effects panel, click the [ + ] icon and enter a name for the preset, then Save.
After a seemingly random amount of time (typically between 45-90 mins), eqMac will crash, and relaunch with the following dialog:

Notes:

Output device seems to have no impact on this occurring. I've experienced it using bluetooth headphones and built-in speakers.
(I believe) This only began occurring after the update to 1.8.3

Expected behaviour
No crashes occur.
Setup information:

Audio device used for playback: Sony WH-1000XM5, Macbook Pro speakers
Audio transmission interface: Bluetooth, Built-in speakers
macOS Version: 14.2.1 (Sonoma)
eqMac Version: 1.8.7 (beta, but issue exists on the latest stable release (1.8.5) as well)
eqMac UI Version: 5.0.8 (Remote)
Driver version: 2.5.3

Can I help debug this somehow? It's incredibly frustrating and happens several times a day

Just wanted to add that I have the same problem (although I am using the "Apple: Dynamics Processor" Plugin instead).
I understand the crashes may not be easy to fix, an easier fix could possibly be to at least not remove it and keep the presets saved and just disabled it instead.
If i have restart and enable it again it's annoying but much less frustrating than also configuring it again.

...an easier fix in the meantime could possibly be to at least not remove it and keep the presets saved and just disabled it instead.

Agreed that deleting the preset makes the problem orders of magnitude more frustrating, since you have to go build the settings for it all over.
Here's a workaround I've been using to at least sidestep this part of the issue:

After adding a plugin (Graphic EQ or Dynamics Processor) in the Extra Effects panel, save the preset as you normally would.
Then, click save again and give it another name (mine are just labelled v1 and v1.1).
When the plugin inevitably crashes, you can switch the dropdown to your second saved preset, where your preset will still exist intact
After switching, click the save button again and overwrite the version that just crashed.

This absolutely doesn't solve the entire issue and requires a couple steps whenever this thing crashes, but IMO it's far less work than re-configuring a plugin every time.

@kevinfales Good tip, thank you, I will use that. Agree fully with what you said about this not solving the issue of course 👍

Seeing the same issue with the CanOpener Studio plugin. Logs have been emailed to customer support.

UPDATE
Updating to MacOS 14.4.1 (latest as of today) seems to address this issue. No longer seeing audio unit crashes.
From the 14.4.1 patch notes:

Audio Unit Plugins Crash
FIXED
There have been reports of compatibility issues with PACE products in macOS 14.4, including the iLok License Manager, connected to Apple silicon Macs running macOS 14.4. The problem specifically impacts plugins from various manufacturers that are safeguarded by PACE/iLok, including those made by Universal Audio, when used with host DAWs such as Logic Pro. Apple's release notes for macOS 14.4.1 say the update provides a fix for cases in which "copy protected Audio Unit plug-ins designed for professional music apps may not open or pass validation."

@kevinfales  I am running 14.4.1 as well and just had a crash yesterday :-(

Can confirm, using 14.4.1 and still crashing

@dan-iway @coroiu Can you check if these plugins crash with any other software besides eqMac? I consulted with the dev and plugin crashes should not be related to/caused by eqMac. Just like with kevinfales case it may be an issue with macOS version compatibility with those plugins or an issue with the plugin itself.

@ragauskl How are we supposed to test this? The plugin does not crash for hours in eqMac either...
And while it may be true that the plugin crash has nothing to do with eqMac, eqMac could definitely handle this better - just restart the plugin and keep the config.

@ragauskl I'm on a completely different computer now (Macbook Pro M3) running the latest MacOS (14.5) and I just had a crash of the audio plugin after about an hour.

eqMac could definitely handle this better - just restart the plugin and keep the config.

Yes. Yes yes. The crash is frustrating, but the fact that it deletes my preset is far, far more frustrating.

just restart the plugin

@dan-iway this is how eqMac used to work before but some plugins would continuously crash causing even bigger problem.
Dev will be looking into a better handling of plugin crashes so it's not as annoying, but said that it may not be as easy as simply disabling the crashing plugin if possible at all (don't ask me, I'm just a middleman between you and him, he knows the details but I can't bother him about every single one).
Regarding testing, I know it may not be easy to replicate as it takes hours, but if anyone can use another software and use the plugins to see if they crash in there as well can help with identifying if it's eqMac issue which would help prfioritize this (specifically the crash investigation, better handling of errors like this will be looked into anyway).

Is there any update or priority on a fix here? This happens probably 15 or 20 times per day and it's a serious vibe-killer.

For now there's no update on the issue as there are higher priority (issues affecting more users) tasks being worked on, until those are resolved there's no timeline for when this will be worked on. It's in the to-do list, just not at the top of the list.

App v1.8.8
Driver v.2.5.4
UI: 5.1.4 (Local)
macOS: 15.0
No longer seeing this issue, have been using for two days straight 👍 I also switched from an M1 Pro to M3 Ultra so I'm not sure if that might've been the reason. Either way now I can fully enjoy this awesome app!


Bump jhipster server lib to 1.1.13

Need this to rebase the PR on generator-jhipster.

Actually, @jdubois would you consider a PR that puts jhipster-dependencies and jhipster server lib in a single repository, for simultaneous release cycle? The co-dependency is troublesome, I think. For instance now I'd like to bump jhipster-server lib managed dependency to 1.1.13 here, but then to be really clean the server lib would have to get the latest jhipster-dependencies, and so on :-)

I'm not sure they should have the same release cycle - indeed you probably want jhipster/jhipster-dependencies to follow the jhipster/jhipster versions, but not the other way around, and also sometimes we do intermediary releases for test or patch purposes. I'm fine with having them separated for the moment. My biggest concern is having something simple, that I can merge as soon as our OIDC support is out, and then we can work on improving it.

So, if I understand correctly, you are saying that jhipster-dependencies should be updated for each release of jhipster, but not the other way around?
But that will mean that, for the common case that jhipster-dependencies is released due to an upgraded dependency X to version Y+1, that downstream modules like jhipster-registry and newly generated apps will get X at version Y+1 while being linked against the server lib that was compiled with X at version Y...
That seems like asking for trouble to me :-)
Honestly I don't think a single repository setup is all that more complicated than things are now, and test/patch releases should be fine too as long as we are careful about not consuming those in the main branches of downstream repos (but that is also true currently).
Anyway, obviously I defer to your expertise -- and sorry if I misunderstand your reasoning here!

@jdubois I will mark my single-repo PR "on hold" but feel free to close it if you like.
Thanks for merging the bump in jhipster server lib here. If I could please have a new release, then I can rebase my other PRs without regressing the server lib version... Much appreciated, and sincere apologies to take up so much of your time!

@erikkemperman I just want something simple for the moment, we have so many opened tickets and PRs, I just can't follow everything.
I'm doing the JHipster lib release, no problem!

@erikkemperman sorry, I meant the jhipster-dependencies release - it's on its way to Maven Central!

@jdubois No worries, I've been having a little free time lately, but of course I completely understand if it's too much all at once.
Thanks for release, will update my PRs as soon as it hits Maven central!


One way binding performance

This PR addresses some performance issues with record and recordedit. The changes made were to reduce the number of two-way bindings that each app creates.
On record page, I was able to reduce the number of listeners on initial load from about 100 to 70, a 30% decrease.
On recordedit page, I was able to reduce the number of listeners on initial load from about 60 to the mid 25. This is roughly a 50% decrease. This doesn't address the overall concern with performance which seems to be caused by the ellipsis directive, but this is a good step towards cleaning up the apps and limiting unnecessary events from bogging down the angular digest cycle.

I turned on PR builds for this PR to verify the tests were still green after the chaos I waded through yesterday. I have since turned PR builds off again for chaise.


move token to request body form instead of url

Closes https://github.com/R-ArcGIS/arcgislayers/issues/71

This still needs to be addressed in arcgisutils


More documentation/examples using RepositoryEnv, RepositoryIni

If the documentation had spelled out that AutoConfig is the default and examples of RepositoryEnv/Ini that would have been helpful. Perhaps it is only a matter of adding a more few examples? For instance, if I found something like this, it would have been helpful:
from decouple import Config, RepositoryEnv

keypath = os.path.join(os.path.dirname(BASE_DIR), 'keys/.env')
config = Config(RepositoryEnv(keypath))
SECRET_KEY = config('SECRET_KEY')

Hi. The proper way is already on the documentation:

Feel free to propose a PR to improve it. It's always nice to make thing more clear.


iOS invisible text on textarea in accordion

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: v1.6.5

Platform and Target: Cordova, iOS 11

Live Link or JSFiddle/Codepen: https://jsfiddle.net/ttc9trw1/

What you did
Created a textarea in an accordion element. Opened Accordion, wrote text.
See Link above for a live demo.
Expected Behavior
Text visible
Actual Behavior
Text invisble
This only happens in Mobile Safari, tested on iOS 10 and iOS 11.
If you close and open the accordion, the text is visible, but this is very confusing for users!

Issue is closed because of outdated, irrelevant or not actual
If this issue is still actual and reproducible for latest version of Framework7, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


libsndfile: 1.0.30 -> 1.0.31

Motivation for this change
Fixes CVE-2021-3246.
https://github.com/libsndfile/libsndfile/releases/tag/1.0.31
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Can we make use of the following?

Implement fast SSE2 optimized psf_lrintf() and psf_lrintf() functions to
improve perfomance when libsndfile is built using Visual C++ (especially)
and other compilers on x86 and AMD64 platforms. See also description of
ENABLE_SSE2 CMake option in README.md.

From my understanding it's on by default:

ENABLE_SSE2 - add compiler flag to enable SSE2 if required, ON by default.
This option is for X86 and GCC compatible compilers configurations only.
If you compile for other SIMD set, e.g. AVX2, you may want to set ENABLE_SSE2 to OFF.
Note: This option is not active for X64 configuration, because SSE2 is always available in this mode and all optimizations are enabled by default.

And it looks like it's appropriately verified
https://github.com/libsndfile/libsndfile/blob/d60deb5d8691997b6bb28d88e3b43f322073d146/CMakeLists.txt#L89-L99
https://github.com/libsndfile/libsndfile/blob/d60deb5d8691997b6bb28d88e3b43f322073d146/src/sfconfig.h#L127-L129

A sneaky cherry-pick back to master builds happily on macos 10.15.


Accept args to config.parse()

The parse() method could accept args that it can proxy to _parse_args(args) which would allow pydocstyle to more easily be run in-process.
Right now it's hard to correctly parse the config, without pydocstyle reading sys.argv

The best way right now is via monkeypatching sys.argv.