refactor(p-tooltip): change from stories.ts to stories.mdx

To Reviewers

[ ] Skipping review is not a problem (style, chore ONLY)
[x] Not that difficult

Type of Change

[ ] New feature
[ ] Bug fixes
[ ] Feature improvement

[ ] These changes require a usage change

[x] Others (performance improvement, refactoring, CI/CD, etc.)

Checklist

[x] Updated Storybook documents
[ ] Tested with console

Description
SSIA

:tada: This PR is included in version 1.1.0-beta.439 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use lazy-loaded cached tree implementation

This introduces a largely rewritten implementation of the SMT which operates on a cached, lazily-loaded tree structure, as opposed to the current paradigm of reading from/writing to the DB directly for each operation. This gives a significant performance improvement on all operations while preserving full compatibility of the produced hashes.
This also refactors the hasher objects to allow tree paths and stored values to be hashed independently, and Options to configure them. https://github.com/celestiaorg/smt/issues/40 can be satisfied by passing an identity function as the path hasher.
As noted here, the DeepSubtree code supporting state-transition fraud proofs was not compatible as-is with this implementation and so is removed; but there should be no technical block to adapting that code to this impl.; it was simply outside the scope of Cosmos-SDK ADR-40 for which this was originally built.

Codecov Report

Merging #73 (ea93a97) into master (5f13c0f) will increase coverage by 0.83%.
The diff coverage is 86.15%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   85.62%   86.46%   +0.83%
==========================================
  Files           6        8       +2
  Lines         466      650     +184
==========================================
+ Hits          399      562     +163
- Misses         39       53      +14
- Partials       28       35       +7

Impacted Files
Coverage Δ

options.go
50.00% <50.00%> (ø)

smt_testutil.go
69.23% <69.23%> (ø)

smt.go
83.33% <84.31%> (+2.54%)
:arrow_up:

types.go
88.37% <88.37%> (ø)

proofs.go
93.61% <97.05%> (-6.39%)
:arrow_down:

hasher.go
100.00% <100.00%> (ø)

utils.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks @roysc! I've pulled the changes from the vulcanize repo a few weeks into the "lazy" branch here (https://github.com/celestiaorg/smt/tree/lazy), as we need to implement the things in https://github.com/celestiaorg/smt/issues/72 first before merging to master. Is that already up to date or does this PR introduce anything new not in the lazy branch?
For context though, we've currently decided to put the SMT work on hold too, as we're currently implementing deep trees for IAVL instead (https://github.com/celestiaorg/iavl/issues/1). This is because due to the assumptions made by store V1 including range queries and versioning etc, making store V1 work well with SMT is more work than expected so we've decided to pursue IAVL for now.

@roysc does this PR remove value storage? I recall in the original lazy implementation in vulcanize, value storage was removed. But it looks like you added back in this PR, if I understand correctly (from a cursory look)? Would the code in the README still work?

Sorry for the delay on this, it was sidelined by prioritization and time off. I'd like to wrap it up if possible, and to that end I've pushed an additional cleanup/refactor with a README update.

@roysc does this PR remove value storage?

Yes it does, but we can easily add a type that wraps value storage with the tree. (Alternatively, the raw value can be stored directly in the leaf by using an identity function as the value hasher.)
What's the likelihood of this being reviewed in the near future? If it's most likely to stay in limbo for now, I plan to just close this PR.

Thanks for this @roysc. Given we're not currently using SMT at Celestia, there's no one really currently maintaining this repo.
My suggestion is that given that your PR breaks the current interface, that you merge this into vulcanize/smt, and then perhaps I can add to the README of this repo that this repo isn't currently being maintained, and point them to vulcanize/smt as a more recently maintained version. Is vulcanize currently using and maintaining vulcanize/smt? Alternatively, I think it's fine to just leave this PR open in case we start maintaining this repo again.

Thanks @musalbas. I think the SMT is basically shelved for vulcanize for now as well, but could possibly be experimented with in the future, so pointing to that fork makes sense. I'll close this PR though, just for tidiness purposes.

@musalbas @roysc  We're using this library at Pocket and plan on taking it to production as well. It probably won't be for a month or two, but what I was thinking was:

We can fork this library
Use this PR (update docs, test, etc...)
Optionally merged it back here to avoid maintaining a fork

@Olshansk That works, we will maintain our fork at Vulcanize and I can take up your PR once it's ready.

We intend to deprecate this repo as we don't have bandwidth to review PRs and maintain this repo. So @Olshansk if you plan to actively use and maintain SMT, I suggest maintaining your own fork for now.

We intend to deprecate/archive this repo as we don't have bandwidth to review PRs and maintain this repo. So @Olshansk if you plan to actively use and maintain SMT, I suggest maintaining your own fork for now.

👍  I've created https://github.com/pokt-network/smt.
Will revisit potential collaboration opportunities when our fork is more mature & battle-tested.


[BUG] Update footer links on mobile

Related Issue #70

The footer links had the incorrect class name on them

Closes: #70
Describe the changes you've made
The list items under Resources, Legal stuff, and Contact were set to inline-block on mobile making them sit inline with each other. I removed that class name and updated the block class name from md:block to block since we want them to always display as block.

Type of change
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
I have tested this locally on my machine in 3 different browsers and devices.

Checklist

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented on my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original
Updated

 |

|
Code of Conduct

[x] I agree to follow this project's Code of Conduct

Awesome thanks @pattimcletchie 🚀


Merge pull request #1 from ELIXIR-Belgium/master

update

@vdkkia something strange happened here. My fork seemed to be 1 commit ahead of the master, but I didn't do any changes. What's the best way to handle this?
I need to make new changes to the DMP template. Shall I create a new branch?


Feature request - Add method to share local files using UIDocumentInteractionController

Thank you for sharing your work!  I had a feature request:
Use Case: To share a local app generated file with installed iOS apps such as "Copy to Google Earth"
urlToLocalKmlFile: file:///var/mobile/Containers/Data/Application/13052-F5A9-48FF-90F7-613A3E75F4/Documents/Demo_Parking_Lot.kml
Implementation Example:
https://github.com/deldreth/react-native-document-controller/blob/master/DocumentController.m
Or perhaps keep same interface, and switch to use   UIDocumentInteractionController if URL scheme begins with "file://"

@esutton  if you use url props not resolve?


chore: default compiler.enableNew to false until development restarts

@leodemoura There is a number of tests testing new compiler output that are now broken. We could disable the option for external users only but I think the time savings for building Lean itself are significant enough to justify moving these tests into a new folder that is not part of the suite for now.

I've moved the new compiler tests to a separate directory that is currently not included in the test suite

!bench


First install, used HACS, SkodaConnect not showing up in "Integrations"

Hi,
I just installed this for the first time. Used HACS without issues. Even after several (full) restarts I cant add the integration because Skoda Connect doesnt show up.
I´m using Home Assistant 2021.12.10 on a RasPi and tried your latest and previous version via HACS.

Issue solved itself - no idea how


multi-module IJ project

With the continuation of #1109, a separate ticket to track multi-module IJ project. The current behavior is there are only 2 predefined modules i.e .ijwb and the root directory. It would be great if we can introduce a fine-grain module system(or adapt existing modules system i.e module-info.java). Alternatively, we should be able to control modules to activate using .bazelproject file.
@ittaiz please add if I missed something.

This is https://github.com/bazelbuild/intellij/issues/179. Closing as dupe.


MetaLB: Separate cost/benefit analysis for running LB strategy and performing migration

Original issue: https://charm.cs.illinois.edu/redmine/issues/65

MetaLB potentially has two separate decisions to make as execution proceeds:

Is current load imbalance bad enough to justify the cost of running the load balancing strategy to compute new assignments?
Having obtained new better-balanced assignments, is the improvement they would offer enough to justify the cost of migration they would entail?

We may need to carry object size information (as reported by the sizing PUPper) in the load balancing database to allow estimation of migration costs as soon as decisions are made. Alternately, we can transmit the decisions and compute the expected time cost in a distributed fashion (max over network model, some more detailed contention-based estimate, simulation, etc.).

Original date: 2018-04-04 20:03:01

Estimation of migration costs is already included in the model based method to select Load balancing strategy. So this issue is somewaht subsumed by ~~https://charm.cs.illinois.edu/gerrit/#/c/charm/+/1914/~~ https://github.com/UIUC-PPL/charm/commit/27eaa51c4c55bde8f66541b747e9cdea92165794

Original date: 2018-08-07 22:46:59

The MetaBalancer patch has been merged. The random forest model will be updated to include more training runs. Chare pup size feature will also be included as a hint for migration cost in the updated model.


feat: new ssr.fileExtension option

Allow meta frameworks to explicitly set the desired file extension. For example, in VitePress heavily relies on the file name conversion by adding .js to .md files for the chunk name. The current solution provides reasonable default, but may not be stable enough for meta-frameworks to consume (may vary on users' package.json).
Alternative
Or maybe, we could always generate as .js with a fake package.json to force the type resolution.

We could already use entryFileNames to override the default. And you can keep the name but fix the extension with it, no? It is hidden in build.rollupOptions.output.entryFileNames but this is a more general issue. I would like if we provide a default build: { entryFileNames, chunkFileNames, assetsFileNames } as shortcuts to these, that would be generally useful

I'm also slightly leaning towards build.rollupOptions.output.entryFileNames to prevent config overlap. Maybe we could document instead of Vite's extension default for cases like this.

I am doing this because of https://github.com/vuejs/vitepress/pull/707
In VitePress it assumes the output is .js (https://github.com/vuejs/vitepress/blob/52499221874e23ec437c416f4fc5ef3edb771857/src/node/build/render.ts#L52), where with the previous #8382, the output will not be stable when the users set type: module for their project root.

Alright, end up using https://github.com/vuejs/vitepress/blob/e0f30159b3141e48bfd3a4cc277880cdf486fabe/src/node/build/bundle.ts#L76-L80. Close for now to minimalize the config inteface.


Tasks aren't available within Azure DevOps releases anymore

Install the latest version of this extension into your Azure DevOps organisation from the Visual Studio Marketplace (time of writing this is 2.2.20)
Observe that the extension has successfully installed by going to Organization Settings -> Extensions in DevOps
Go to your Azure DevOps instance and go to create a new release pipeline
Next to 'Select a template' - search for any of the Epinova tasks and none are showing in the results:

Additional observation
The tasks do show when configuring a Pipeline build - but they are no longer available for release pipelines.

Hi @JayWilk
Thanks for info! I will have a look...

Hi @JayWilk
If I look on your first image you are searching for a release pipeline template. We have never created a template. So if you click on a "stage" and then click "Add task". Then do should be able to search for the Epinova tasks. And if you want to find all of them you can search for "DXP" since all tasks are found in that case.

I hope the image above here show where you should search for tasks.


Chrome v32 + Win8. Icons with 3-bytes code sometime not displayed

added by @puzrin:
This looks like Crome v32 bug - codes from the latests (6.0+) unicode specs now not displayed under Win8. If you are affected, please go to https://code.google.com/p/chromium/issues/detail?id=338644 and star this issue.
If anyone has direct contacts with Chrome devs - ask them to increase priority of that bug.
As temporary solution - use PUA codes range (Settings -> Advanced). After settings change, you should reselect glyphs or change codes manually. Note, that fontello use PUA range by default, and majority of users should not suffer from this problem.

Several of my fontello icons are not appearing for PC users. Only able to reproduce this issue in Chrome 32 on PC. What's strange is that some icons appear and some do not. The files are set to PUA and I see nothing in the CSS or Json file that would cause this issue. Important to note that the icons render fine on a Mac on Chrome 32. Also renders fine on Firefox and Safari

We have same issue on mac with chrome version  43.0.2357.124 m


Tag 0.7.0

@brson Can you please tag e75f58f3fd2ede83492bdb193ba5532db6f90d64 as 0.7.0 so it's picked up by build systems using git for versioning? :)

This can be closed now that the tag was made.


Character limit on github urls making it impossible to add some repo links

I'm trying to setup some projects for some of our community GitHub repos and it appears that you have a character limit on GitHub URLs making it impossible to add some repo links: https://opencollective.com/rest-cache-plugin. This project should go to: https://github.com/strapi-community/strapi-plugin-rest-cache

Verified:

@SudharakaP could you have a look at this one today?

I should have checked that an issue tracker existed before emailing.
Thanks for creating the issue!


Add command-line argument to create a CRL

This seems fine but unnecessary? We always create the crl on CAinit https://github.com/opensciencegrid/osg-ca-generator/blob/master/lib/cagen.py#L97

Useful for recreating it when you delete it by "accident"


bug： Cropping without depth testing

When cropping the scene, not only the gs points in front of the camera are cropped, but also the gs points behind the camera. This is unreasonable, so I think it is necessary to add depth judgment and crop the point cloud in front of the camera.

Hi @Bin-ze ,
Oh my gosh - this is a bug!
Will fix ASAP, thanks for reporting.

@slimbuck  I want to know when the web version will be updated？
https://playcanvas.com/supersplat/editor : There is still a problem with the Gaussian after cropping the camera

@Bin-ze SuperSplat should be updated early next week.


May I ask which channel estimation algorithm is used by ESP32-WROOM-32U to obtain channel state information(CSI)？ (IDFGH-9734)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
May I ask which channel estimation algorithm is used by ESP32-WROOM-32U to obtain channel state information(CSI)？

Please refer https://www.esp32.com/viewtopic.php?t=9733

Please refer https://www.esp32.com/viewtopic.php?t=9733

thank you！Sorry I didn't explain my problem clearly. What I want to ask is, what algorithm is used for channel measurement, LS or MMSE?

Hi @ogleede
We use LS :)

Thanks for reporting, we will close this issue. Feel free to reopen if have more updates.
Thanks for using our Espressif product!


Wire up .svg images support

Followup https://github.com/iterative/dvc/pull/8542
Otherwise SVG is still not rendered.

cc @blakeNaccarato FYI - if I'm not missing anything this is needed to properly support SVGs

Codecov Report
Base: 96.02% // Head: 96.02% // No change to project coverage :thumbsup:

Coverage data is based on head (18f14f8) compared to base (f783afc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   96.02%   96.02%
=======================================
  Files          19       19
  Lines         680      680
  Branches      100       73   -27
=======================================
  Hits          653      653
  Misses         22       22
  Partials        5        5

Impacted Files
Coverage Δ

tests/test_image.py
100.00% <ø> (ø)

tests/test_vega.py
100.00% <ø> (ø)

src/dvc_render/image.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@shcheklein Thanks for pointing out, and for wiring it up, as well.
Sorry, when I worked on the initial PR over at iterative/dvc, I didn't notice iterative/dvc-render and its role. I should have checked tests/integration/plots/test_plots.py and realized dvc-render's role in this. Thanks!

@shcheklein Thanks for pointing it out, and for wiring it up, as well.
Sorry, when I worked on the initial PR over at iterative/dvc, I didn't notice iterative/dvc-render and its role. I should have checked tests/integration/plots/test_plots.py and realized dvc-render's role in this. Thanks!

My fault for not raising this on the P.R. review 🙏


Update sbt to 1.10.0

About this PR
📦 Updates org.scala-sbt:sbt from 1.9.9 to 1.10.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

PRs don't have the secrets access needed to install Fortify, so the CI failure is normal. If it fails again post-merge, we'll know there's an actual problem.


#4529

Description 📜
This is a video contribution to Stack in C++ STL.
Fixes #4529

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[x] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[ ] Doc#umentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[x] C/CPP

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@apeksha235 i think changes done
please review it once more.

@Op-panda  Nice 👍🏻  LGTM 🚀


Add staging a diff

There's an undo command and to complement it would be great to have a command for staging a diff to the index, so you don't have to leave the editor to do git add -p.

Thanks for your suggestion. The problem with this is that we'd need to interact with git to enable it. Retrieving the diffs is something that is done through the git-utils package, it provide a specific api to get the line diffs. However, that package doesn't cover a wide range of git functionality. This means that i'd have to directly interact with git, similarly to what the git-plus package does. In my opinion, this is out of the scope of this package. Maybe you want to suggest this feature over at the git-plus package?

Ah, I see. Turns out git-plus already has the feature called "Stage Hunk". Also see https://github.com/akonwi/git-plus/issues/388 Thanks for pointing it out!


change of rate and deceleration of waypoints

rate change should fix latency issues in simulator
linear deceleration of waypoints improves stopping behavior

ok


Example sources

Most of the examples only have examples of wiring up redux-form to the input, but the props(functions) that are passed in, are not included in the source code. It would be awesome, if we got the full complete source for the examples, instead of just the form component.

Just found this.
https://github.com/raboof/redux-form/commit/e35e7d6d43d3e492c0d5adffa5b4320aac17a8c0
Thanks @raboof

Update: 'npm install fails'

@fallenpeace it might help if you post the complete output of your 'npm install' failing

Examples can be found in the gh-page branch.
npm install works like a charm. Can you delete node_modules and rerun npm install? If the problem persists, please file an issue including details about your environment and the error output.


Added aerial queries for objdump

Now that https://github.com/neovim/neovim/pull/23608 and https://github.com/nvim-treesitter/nvim-treesitter/commit/0179a89656b4ce395a4487c07ae385b8425524ae merged, objdump files are recognized in Neovim with tree-sitter support. Adding to aerial.nvim as well.

Since objdump files aren't really code, I wasn't sure what the preferred header would be. So I just chose "Interface" and "Function". Open to suggestions, there.

Thank you for the tip. It should be working now!

Thanks for the PR!


different approach for iframes

The problem is described in #2471. I was thinking about using ng-include to just include the projector (as a div; this div could be scaled like the iframe now, too). For the /projector/1 url (projector container) this is working; the container calls the ´/webclient/projector/` so the projector has its own realm and gets autoupdates. But how to handle this in the sidebar or manageview?
Because the projector gets included in the webpage, the page is the site and projector at the same time. This is not the way OpenSlides is current going with the strict separation between the site and projector; There have to be many changes to implement this in an useful way but I think it's possible.
I could create an PR with my experiments for using the projector in a div if someone wants to try this out.
Other idea: Render the projector on serverside and just updating a picture with the projector content and broadcast it with the autoupdate when the projector changes. I think this is some kind of over complicated and the server has a lot to do; whats about videos? Not my favorite.
Any Ideas, discussion?

As discussed with @FinnStutzenstein and @normanjaeckel
won't fix


[Bug] go build failed with malformed import path on Windows

Describe the bug
go build failed with malformed import path on Windows
Steps to reproduce
go build failed with malformed import path on Windows
Expected behavior
work
Actual behavior
not work
opentelemetry-go-auto-instrumentation version
latest
Environment
Go:
OS:
Additional context
No response

我在我本地windows上导入成功了。


Maham Khalid Final Womanium Assignment (Classiq 6.12)

PR Description

Some notes

[ ] Please make sure that you placed the files in an appropriate folder

[ ] And that the files have indicative names.

[ ] Please note that Classiq runs automatic code linting, which may minorly alter some files.

[ ] If you're familiar with pre-commit, you may run pre-commit install, and then at each commit, your files will be altered in a similar way

Good job!
Score: 8/10.


Provide global search for a track name

I have got some songs that I often want to access directly. Currently I always have to (try to) remember which albums they are on in order to navigate to them and play them. I would prefer having an top level display of 'tracks' in the same way as for 'artists' and 'albums', where I can just type part of the song's title into the search field.

Not sure what your solution is. What I would suggest is use the search query at artists or albums overview to search through songnames as well. This means you also get artistnames or albumnames that contain a song that matches the query. Would that work for you?

I think your suggestion would give surprising results and would not be findable and understandable by users. Searching by artist, album or song should not be mixed.

I also think this would cause some confusion to users. The obvious solution is to add a "songs" tab (which can also solve the issue of showing songs without albums), but i have doubts about its general usability. I just can't see myself browsing and searching through all the songs of my music collection, but then, maybe that's just me. It might also have performance issues.

The songs tab could be search-only: It could stay empty until three letters of a search word are entered.

Ok, I agree that mixing the search over artists/albums/songs will be confusion.
I guess we could give a songs tab a chance. Scrolling through a large list should not be a problem, searching however might give some noticeable delays. To make the user aware the app is still searching, we could show a progress indicator while the cursor is loading.
I would then also add the play button on the songs tab to be able to quickly play all songs matching the search query. I find it sometimes very amusing to play all tracks containing a specific word.

#240 implements this feature request. This can be closed.

Sorry, I can only use this feature (and close this issue) after Kore is updated on F-Droid or Play Store. Both are on the latest version 2.0.0, which is nearly half a year old. @SyncedSynapse ?

@jondo Soon. I'm closing this one for now, if after you check it you have some additional comments, place them here.


Update README.md for Mighty

Add Environments description for Mighty
Add Example link for Mighty
Add Demo for Checkers and Mighty

@ayo79
LGTM! Thank you for contribution!


💡 RFC: Add support for selection ranges

Background & Motivation
Selection ranges are used for commands / shortcuts like Expand / shrink selection. The commands work without them but they're not as smart, instead using a simple word-based algorithm instead of actually understanding the language being selected
We should support them, as they're pretty handy for navigating code through shortcuts, especially for advanced users used to them in JavaScript
Proposed Solution
Possible solutions
This should be able to be easily provided by our usual language service (vscode-html-languageservice, vscode-css-languageservice and TypeScript). A selection range could be added for the frontmatter, not sure if it's necessary though
Alternatives considered
N/A
Risks, downsides, and/or tradeoffs
N/A
Open Questions
N/A
Detailed Design
No response
Help make it happen!

[x] I am willing to submit a PR to implement this change.
[ ] I am willing to submit a PR to implement this change, but would need some guidance.
[ ] I am not willing to submit a PR to implement this change.

I tried this today inside VS Code without success - is some other piece needed to have it work?


Bump mdbook to 0.3.7

fixes nothing
:tada: Hi and welcome! Please read the text below and remove it - Thank you! :tada:
No worries if anything in these lists is unclear. Just submit the PR and ask away! :+1:

Things to check before submitting a PR

[ ] the tests are passing locally with cargo test
[x] cookbook renders correctly in mdbook serve -o
[ ] commits are squashed into one and rebased to latest master
[ ] PR contains correct "fixes #ISSUE_ID" clause to autoclose the issue on PR merge

if issue does not exist consider creating it or remove the clause

[ ] spell check runs without errors ./ci/spellcheck.sh
[ ] link check runs without errors link-checker ./book
[ ] non rendered items are in sorted order (links, reference, identifiers, Cargo.toml)
[ ] links to docs.rs have wildcard version https://docs.rs/tar/*/tar/struct.Entry.html
[ ] example has standard error handling
[ ] code identifiers in description are in hyperlinked backticks

[`Entry::unpack`]: https://docs.rs/tar/*/tar/struct.Entry.html#method.unpack

Things to do after submitting PR

[ ] check if CI is happy with your PR

Thank you for reading, you may now delete this text! Thank you! :smile:

I bumped to 4.5 due to security concern

I bumped to 4.5 due to security concern


Not include some files

I have built the project using RestKit

When I build the project, there are some issues (Couldn't find out the header files) in RestKit project.

-RKValueTransformers.h
-ISO8601DateFormatterValueTransformer.h
-SOCKit.h
So I had copied the above files into 'Code' directory in RestKit project folder.
These issues are fixed.

I had changed the class name AFNetworkActivityIndicatorManager into AFRKNetworkActivityIndicatorManager

The following issues are occurred.

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_AFRKHTTPClient", referenced from:
      objc-class-ref in AppDelegate.o
  "_OBJC_CLASS_$_AFRKNetworkActivityIndicatorManager", referenced from:
      objc-class-ref in AppDelegate.o
  "_OBJC_CLASS_$_RKAttributeMapping", referenced from:
      objc-class-ref in JobApi.o
  "_OBJC_CLASS_$_RKEntityMapping", referenced from:
      objc-class-ref in JobApi.o
      objc-class-ref in DriverApi.o
  "_OBJC_CLASS_$_RKInMemoryManagedObjectCache", referenced from:
      objc-class-ref in AppDelegate.o
  "_OBJC_CLASS_$_RKManagedObjectStore", referenced from:
      objc-class-ref in ViewController.o
      objc-class-ref in JobService.o
      objc-class-ref in UserDao.o
      objc-class-ref in AppDelegate.o
      objc-class-ref in JobDao.o
      objc-class-ref in VehicleDao.o
  "_OBJC_CLASS_$_RKObjectManager", referenced from:
      objc-class-ref in NewMaintenanceController.o
      objc-class-ref in JobService.o
      objc-class-ref in SignInController.o
      objc-class-ref in UserDao.o
      objc-class-ref in AppDelegate.o
      objc-class-ref in VehicleService.o
      objc-class-ref in DriverService.o
      ...
  "_OBJC_CLASS_$_RKObjectMapping", referenced from:
      objc-class-ref in VehicleApi.o
      objc-class-ref in JobApi.o
      objc-class-ref in DriverApi.o
  "_OBJC_CLASS_$_RKRequestDescriptor", referenced from:
      objc-class-ref in VehicleApi.o
      objc-class-ref in JobApi.o
      objc-class-ref in DriverApi.o
  "_OBJC_CLASS_$_RKResponseDescriptor", referenced from:
      objc-class-ref in VehicleApi.o
      objc-class-ref in JobApi.o
      objc-class-ref in DriverApi.o
  "_RKApplicationDataDirectory", referenced from:
      -[AppDelegate application:didFinishLaunchingWithOptions:] in AppDelegate.o
  "_RKMIMETypeJSON", referenced from:
      -[AppDelegate application:didFinishLaunchingWithOptions:] in AppDelegate.o
  "_RKStatusCodeIndexSetForClass", referenced from:
      +[VehicleApi incidentReport:] in VehicleApi.o
      +[VehicleApi maintenanceReport:] in VehicleApi.o
      +[VehicleApi emergencyMaintenanceReport:] in VehicleApi.o
      +[JobApi sync:] in JobApi.o
      +[DriverApi signIn:] in DriverApi.o
      +[DriverApi postSignIn:] in DriverApi.o
      +[DriverApi postSignOut:] in DriverApi.o
      ...
  "_RKlcl_configure_by_name", referenced from:
      -[AppDelegate application:didFinishLaunchingWithOptions:] in AppDelegate.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

How could I fix these issues?
Please help me.:) Sorry for my english is not so good.

Which version of cocoapods are you using?
Restkit 0.27.0 is compatible with cocoapods 1.0.1 with use_frameworks! enabled

I'm using cocoapods 1.0.1 version.

You shouldn't need to move or rename any file. If you were using AFNetworking directly into your project you may now want to add it to your podfile, regardless you are using RestKit or not as it's not an explicit dependency anymore.
As far as I know, it works if you create a new project and install RestKit. You may want to try that, it may be something going on in your specific project.

Let me try again as you said. Thanks


USB CDC RX interrupt routine calls blocking functions

It really not a good idea to call blocking functions in an Interrupt Service Routine.   Doing so typically requires waiting on a spinlock (or similar), which means that core will be tied up until something else unblocks that ISR.
Here, the USB RX interrupt handler calls queue2_add_blocking(&rx_fifo ...), which does a spin-wait for space if the FIFO queue is full.  If lucky, the ISR is already configured to execute only on Core1.  Else, if this ISR runs on Core0, this would cause a deadlock as Core0 is the only core that removes entries from that FIFO.
Even if lucky, the use of blocking / spin-wait in an ISR is generally frowned upon, and can cause intermittent, incredibly difficult-to-track-down bugs (e.g., timeouts, poor interactions with USB hosts, etc.).
https://github.com/DangerousPrototypes/BusPirate5-firmware/blob/7f9538ecbd5f376343d447d9b5227b8fd9aac2a6/src/usb_rx.c#L62-L84
Action Required
Review where blocking / spin-waits are currently used.  Consider modifications to minimize or eliminate blocking / spin-wait code paths for at least Core1.

This is a non-trivial problem.
Yes, you are right ... we generally want to stick it somewhere for deferred processing.  Here, that's what the code is already attempting ... but it's choosing a blocking function, rather than losing terminal input.
In addition, the ISR fires whenever the host sends another packet, which is not under the firmware's control.  Thus, the ISR might be re-entered essentially immediately upon exit ... so the read bytes must be inserted into the queue or discarded?
At the same time, we cannot force Core0 to read from the fifo.  We just have to hope that Core0 is not also blocked somewhere.  However, I think Core0 has many blocking functions where it will not read the terminal input for some time.  For example, NAND erase or write appear to take significant time.
So... yeah.   Non-trivial.  I can see why the choice was made here.  Without moving to pre-emptive multitasking, maybe this ends up being the right balance among many imperfect choices.   I need to give it some more think......

a bulk endpoint connecting to a much slower hardware serial port.

Set up the endpoint buffers to hold more than the endpoint max packet size. The max packet size is set in the USB descriptors for the device. Now as the USB engine receive packets from the host, those data bytes are written to the endpoint buffer.

Source
The flow control is very simple. When the device is not ready to receive the OUT data, it NAKs the OUT token, as usual. The controller should do this automatically, without any overhead on the firmware side.

When you call USBD_CDC_ReceivePacket you tell the controller to enable receive and get the following OUT data. Until you are ready to digest more data, don't call USBD_CDC_ReceivePacket.

Source
I will need to dig further, but it is my understanding there is at least some kind-of-sort-of reliable flow control in USB CDC. These discussions are for other chips, but I recall that it should be possible to stall the next CDC packet until we process and acknowledge a pending packet in a cooperative multitasking loop.
Is this feasible, or would it require digging into the USB stack, I do not at the moment know.

We using hatach's tinyusb stack ... so the above is the right concept, but didn't shed light on implementation.   I'll probably start by searching there how to implement control flow in the USB CDC, and if that fails, I'll ask him directly for advice.  I've contributed to his repositories before.  :)

If I'm looking at this properly, the ISR will fire once.  But, if we just set a flag, it looks like tinyUSB might properly respond with a NAK when it doesn't have space in its own buffer.  So, we can simply check for more data in the core1 infinite loop, maybe optimizing to only doing so if the flag is set?  Or maybe just do it unconditionally, and have the ISR be a no-op?   Something worth testing....

Notes:
To have a chance of fixing this in a less-than-really-complex manner, I want to add some basic rules around the use of the USB FIFO queues:

src\usb_tx.c:tx_fifo and bin_tx_fifo

Transmits data from buspirate to host over first/second CDC interface (Terminal/Binmode)
Queue must be serviced (drained) from core 1, and only core 1.
Queue must be added to (put/insert) from core 0, and only core 0.  (else risk of deadlock)

src\usb_rx.c:rx_fifo and bin_rx_fifo

Receives data from the host over first/second CDC interface (Terminal/Binmode)
Queue must be added to (put/insert) from core 1, and only core 1.

This means any interrupt handler must also run on core 1.

Queue may be serviced (drained from) core 0, and only core 0.

These rules appear to be generally followed already.  Known exceptions include:

rx_fifo -- script parsing appears to push data into this FIFO queue, and does so in a blocking manner.  Script parsing might therefore be interfered with if terminal input occurs?  Consider how to resolve this....
rx_fifo -- need to verify interrupt handlers setup properly for core1, or modify to not use the interrupt handler (e.g., just set flag?)


Symbol not found: luaL_checkversion

when i run lua require('lfs') I got this error  fully error:
E5108: Error executing lua error loading module 'lfs' from file '/Users/stephen/.config/nvim/lua/lfs.so':
        dlopen(/Users/stephen/.config/nvim/lua/lfs.so, 6): Symbol not found: _luaL_checkversion_
  Referenced from: /Users/stephen/.config/nvim/lua/lfs.so
  Expected in: flat namespace
 in /Users/stephen/.config/nvim/lua/lfs.so

I encountered the same error, did you solve it?


Typo: "Are their limitations if I am on the Log Analytics Free pricing plan?"

Are there limitations if I am on the Log Analytics Free pricing plan?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0526b200-ba5c-5427-35a8-1290d23bcada
Version Independent ID: 4ca174bd-6fbb-7b74-8065-eaabdb10a699
Content: Azure Monitor FAQ - Azure Monitor
Content Source: articles/azure-monitor/faq.md
Service: azure-monitor
Sub-service: ****
GitHub Login: @bwren
Microsoft Alias: bwren

@apeczan Thanks again for bringing this to our notice and improving our Azure documentation. I have raised a PR to correct the typo, which will be merged in the live document next 1-2 business days.
At this point it appears that there's no further edits or updates needed to the documentation. We will go ahead and close this issue, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


⚠ Fortnite has degraded performance

In 7b8ed6f, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1439 ms

Resolved: Fortnite performance has improved in dd4578a.


Adding v0.15.0 firecracker docker image

Adds a docker file that allows for testing of v0.15.0 of Firecracker.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing due to inactivity and age.


Add config URLS to CORS whitelist

This PR is the result of the conversation here: https://github.com/TryGhost/Ghost/pull/6644#issuecomment-210649748
This is not quite as straightforward as it seems at face value, because config.js is not loaded at the time when the middleware is required. Therefore I've added an internal cache (these values cannot change whilst the software is running).
The tests also needed the addition of rewire to handle this. Not ideal but it works.
If anyone has a smarter way to do this I'd happily accept alternative PRs 😉
refs #6644

urls specified in config.js should be considered whitelisted/trusted
this is not quite straightforward because config.js is not ready at the point the middleware is required
tests have been updated to cover these new cases + use rewire to override the internal whitelist cache

I'm playing around with this (the PR and the urlSSL scenario in general) a little. It would be nice to come up with a way not to need the config dependency here.

It would be nice to come up with a way not to need the config dependency here.

Agreed ;)


docker image updated?

has the docker image been updated with the recent commits?

@camelotceo
No. I am waiting help from @restmount


The camera occasionally teleports to 0, 0, 0

I've been using this mod on a small SMP for help with getting screenshots or viewing my build progress, and I've found that sometimes when I enable freecam, the camera teleports ~1500 blocks away to the exact origin of the world. I've observed that the bug occurs more often when the server has just started. I have not observed this bug in singleplayer.

After looking through previous posts, it looks like one of my other mods causes this. As I don't want to remove that mod, I'm just gonna deal with it.

Which version of the mod are you using? This was a bug I thought I had already fixed.


Add context path when listing routes

This PR makes changes to list context path in cf routes command.
Pivotal tracker story: https://www.pivotaltracker.com/story/show/104020832
Regards,
@atulkc and @shashwathi
(CF Routing team)

We will be consolidating the PRs related to context path into one and resubmit. Closing this PR.


Bug for multitask learning

Hi, I have a problem with multi-task learning when using EfficientNet.
I want to load the pre-trained model and remove the raw FC layers, then add my own 2 new FC layers for 2 different tasks.
However, it always shows the following bug:
File "/home/user/miniconda3/envs/pytorch/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
TypeError: forward() takes 1 positional argument but 2 were given
and here is my code:
class AuxNet(torch.nn.Module):
    def __init__(self, original_model, num_classes, num_classes_aux):
        super(AuxNet, self).__init__()

        input_features = original_model._fc.in_features

        self.network = torch.nn.Sequential(*list(original_model.children())[:-2])

        self.fc1 = torch.nn.Sequential( torch.nn.Linear(input_features, num_classes))

        self.fc2 = torch.nn.Sequential( torch.nn.Linear(input_features, num_classes_aux))

    def forward(self, x):

        f = self.network(x)
        y1 = self.fc1(f)
        y2 = self.fc2(f)

        return y1, y2

model = AuxNet(effi_model,512,128)
print(model)
X = torch.rand(8, 3,224,224)
model(X)

Is there any solution?
There is the same issue proposed here
https://stackoverflow.com/questions/62954999/flattening-efficientnet-model
Thank you very much!

Hi, I have a problem with multi-task learning when using efficientNet.
I want to load the pre-trained model and remove the raw FC layers, then add my own 2 FC layers for 2 different tasks.
However, it always show the following bug:
File "/home/user/miniconda3/envs/pytorch/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
TypeError: forward() takes 1 positional argument but 2 were given
and here is my code:
effi_model = EfficientNet.from_pretrained('efficientnet-b7')
model = .AuxNet(model, output1, output2)
class AuxNet(torch.nn.Module):
def init(self, original_model, num_classes1, num_classes2):
super(AuxNet, self).init()
# Everything except the last linear layer
self.features = torch.nn.Sequential(*list(original_model.children())[:-2])
input = self.features._fc.in_features
    self.classifier1 = torch.nn.Linear(input , num_classes1)

    self.classifier2 = torch.nn.Linear(input , num_classes2)

def forward(self, x):
    f = self.features(x)
    y1 = self.classifier1(f)
    y2 = self.classifier2(f)
    return y1, y2

Is there any solution?
There is the same issue proposed here
https://stackoverflow.com/questions/62954999/flattening-efficientnet-model
Thank you very much!

I think I get the right solution now.
We just need to replace the '_fc' layer:
class AuxNet(torch.nn.Module):
    def __init__(self, input_features):
        super(AuxNet, self).__init__()

        self.fc1 = torch.nn.Sequential( torch.nn.Linear(input_features, 512))
        self.fc2 = torch.nn.Sequential( torch.nn.Linear(input_features, 128))

    def forward(self, x):

        y1 = self.fc1(x)
        y2 = self.fc2(x)

        return y1,y2

effi_model = EfficientNet.from_pretrained('efficientnet-b7')
feature = effi_model._fc.in_features

effi_model._fc = AuxNet(feature)
X = torch.rand(8, 3,224,224)
effi_model(X)

And this kind of solution can be applied to all similar cases.


Does the project have the function of drawing the training process? Thank you for your efforts

I wrote a piece of code myself and drew it using the .h5 file in the result directory


Implement waypointfor annotation

Please provide a description of this PR:
Implementing waypoint-for annotation. Basing off of @ilrudie's use-waypoint annotation work (https://github.com/istio/istio/pull/49700) since the same files are being simultaneously added. I'll trail his changes and continuously rebase off of Ian's PR until it is merged to ensure I have the latest controller changes he's added.
Related to: #49851
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[X] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test all

@MorrisLaw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test release-notes

gencheck_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test release-notes

gencheck_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test gencheck

unit-tests-arm64_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test unit-tests-arm64

unit-tests_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test release-notes

gencheck_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test gencheck

unit-tests-arm64_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test unit-tests-arm64

unit-tests_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test unit-tests

integ-ambient_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test gencheck

unit-tests-arm64_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test unit-tests-arm64

unit-tests_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test unit-tests

integ-ambient_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test integ-ambient

release-notes_istio
bc54ac5321a9f51db52f65862678ff9c46170946
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test unit-tests-arm64

integ-ambient_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test integ-ambient

release-notes_istio
bc54ac5321a9f51db52f65862678ff9c46170946
link
true
/test release-notes

unit-tests_istio
bc54ac5321a9f51db52f65862678ff9c46170946
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test integ-ambient

release-notes_istio
bc54ac5321a9f51db52f65862678ff9c46170946
link
true
/test release-notes

unit-tests_istio
bc54ac5321a9f51db52f65862678ff9c46170946
link
true
/test unit-tests

unit-tests-arm64_istio
bc54ac5321a9f51db52f65862678ff9c46170946
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
integ-ambient_istio	b941bb4 link	true	/test integ-ambient
unit-tests_istio	bc54ac5 link	true	/test unit-tests
unit-tests-arm64_istio	bc54ac5 link	true	/test unit-tests-arm64

Looks like I'll need to update some additional unit/integration tests to account for the waypoint annotation.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test integ-ambient

unit-tests_istio
63cb13143d17aa3c3a63fcab2150a509bde482ec
link
true
/test unit-tests

unit-tests-arm64_istio
63cb13143d17aa3c3a63fcab2150a509bde482ec
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test integ-ambient

unit-tests_istio
63cb13143d17aa3c3a63fcab2150a509bde482ec
link
true
/test unit-tests

unit-tests-arm64_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
b941bb4009088d989bebcc2bd490519ce36e6ba1
link
true
/test integ-ambient

unit-tests-arm64_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test unit-tests-arm64

unit-tests_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test unit-tests-arm64

unit-tests_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test unit-tests

integ-ambient_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test unit-tests-arm64

unit-tests_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test unit-tests

integ-ambient_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test integ-ambient

integ-security-multicluster_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
da4b4c9659145370c76203686f445f96b5a8d574
link
true
/test integ-security-multicluster

integ-ambient_istio
9ab92b73def654f947e580009bb118393861e10d
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
c86d229f9e2a3ac2528e4fb2007bb4931fd34e3e
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
c86d229f9e2a3ac2528e4fb2007bb4931fd34e3e
link
true
/test integ-ambient

unit-tests-arm64_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
c86d229f9e2a3ac2528e4fb2007bb4931fd34e3e
link
true
/test integ-ambient

unit-tests-arm64_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test unit-tests-arm64

unit-tests_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
c86d229f9e2a3ac2528e4fb2007bb4931fd34e3e
link
true
/test integ-ambient

unit-tests-arm64_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test unit-tests-arm64

unit-tests_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test unit-tests

integ-cni_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test unit-tests-arm64

unit-tests_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test unit-tests

integ-cni_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-cni

integ-ambient_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test unit-tests

integ-cni_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-cni

integ-ambient_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-ambient

integ-telemetry-istiodremote_istio
a5dc70d3de6e5aa49814a8d4912795f115da4552
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-cni

integ-ambient_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-ambient

integ-telemetry-istiodremote_istio
a5dc70d3de6e5aa49814a8d4912795f115da4552
link
true
/test integ-telemetry-istiodremote

unit-tests_istio
488241f067fc5ae41894b8ff78e9c94e3f7a9100
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-ambient

unit-tests_istio
488241f067fc5ae41894b8ff78e9c94e3f7a9100
link
true
/test unit-tests

unit-tests-arm64_istio
b695abde5f182ba30584f427203aaece31021286
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
bc497605969a685cb8b019ee2157623f5be9b44e
link
true
/test integ-ambient

unit-tests-arm64_istio
b695abde5f182ba30584f427203aaece31021286
link
true
/test unit-tests-arm64

unit-tests_istio
b695abde5f182ba30584f427203aaece31021286
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-ambient

integ-security-multicluster_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-ambient

integ-security-multicluster_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-security-multicluster

lint_istio
36b7e118d5ca0355899c51e28f37d552f118320d
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-ambient

integ-security-multicluster_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-security-multicluster

lint_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-ambient

integ-security-multicluster_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-security-multicluster

lint_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test lint

unit-tests-arm64_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-ambient

integ-security-multicluster_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-security-multicluster

lint_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test lint

unit-tests-arm64_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test unit-tests-arm64

unit-tests_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
ff9d7ab6182c76f13c0f7d1b2f3fd744144bc607
link
true
/test integ-security-multicluster

lint_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test lint

unit-tests-arm64_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test unit-tests-arm64

unit-tests_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test unit-tests

integ-ambient_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-ambient

integ-helm_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-helm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test lint

unit-tests-arm64_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test unit-tests-arm64

unit-tests_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test unit-tests

integ-ambient_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-ambient

integ-helm_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-helm

integ-telemetry-discovery_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test unit-tests

integ-ambient_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-ambient

integ-helm_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-helm

lint_istio
2c82adef25043ccf6e788646cf80b160ff4f62c5
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-ambient

lint_istio
be7aee0794cbcce9b38e5eb9f0a30b2235a53b4f
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-ambient

lint_istio
e726068fa0fe96cd72feae4419424c164bda3532
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
e36cff21cefbf4f5cdf42a64f1a6812ebb9a0762
link
true
/test integ-ambient

lint_istio
e726068fa0fe96cd72feae4419424c164bda3532
link
true
/test lint

gencheck_istio
e726068fa0fe96cd72feae4419424c164bda3532
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
fea27e6e04ed2cc23ce70d024f009aec26872d40
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
fea27e6e04ed2cc23ce70d024f009aec26872d40
link
true
/test integ-security

integ-ambient_istio
fea27e6e04ed2cc23ce70d024f009aec26872d40
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw there are a number of tests that send to workload traffic in the ambient integ suite but the waypoint won't have your new annotation to allow all traffic so pods won't be getting the waypoint configured. I think integ failures are probably along those lines.

@MorrisLaw there are a number of tests that send to workload traffic in the ambient integ suite but the waypoint won't have your new annotation to allow all traffic so pods won't be getting the waypoint configured. I think integ failures are probably along those lines.

Yeah I think so too

@MorrisLaw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
cae57e41d7fc638bcb16138b0941b141b1a8557b
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nice! looks like fixing that istioctl bug did the trick

had to rebase on flake fix in waypoint test: https://github.com/istio/istio/commit/a40a23dee75ba452f7c240970577b6a998920b01

@MorrisLaw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
afd32cccb5fd1c8ed31097afadc5df89f22ea953
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests-arm64


fix issue:

https://github.com/mhart/dynalite/issues/68

Thanks @ieiayaobb! I added a test to ensure there are no regressions and published this as v1.0.4


Doesn't support .wat input

Hi!
If u will get wast from EOS system (cleos -u https://mainnet.eoscalgary.io:443 get code eosio.token -c a.txt ) , it cannot be decompiled by your decompile, but wast is ok.
sorce code cpp is here : https://github.com/EOSIO/eosio.contracts/blob/master/eosio.token/include/eosio.token/eosio.token.hpp
wast is attached: a.txt

Hey, it looks like that binary is in .wat format, which isn't supported by wasmdec. However, you can convert this binary into a .wasm with wat2wasm offered in the wabt repository, then decompile it with wasmdec. I'll leave this issue open and implement .wat parsing.

Ceos told me, that it was wast: "saving wast..", but anyway, thank you!

oh, I see. Thank, I'll write to eosio.

Sorry, the WebAssembly text format is a bit confusing. .wast is meant to be only for the WebAssembly spec test script format. This can include multiple modules, as well as mechanisms for linking modules together, invoking functions, and calling assertions.
The .wat format only has one module and has none of the scripting functionality.
Both formats allow S-expressions (what we call "folded") and the "flat" syntax. The folded format is syntactic sugar for the flat format. For example, (i32.add (i32.const 1) (i32.const 2)) and i32.const 1 i32.const 2 i32.add generate identical instruction sequences. Partially folded constructs are also supported, like i32.const 1 (i32.add (i32.const 2)).
Some tools like binaryen only parse the folded format, so many of the .wast files in the spec testsuite are written using the folded format (and because it is somewhat easier to read/write).

Thank you for the clarification, I'll rename the issue accordingly.

I have attached a WASM in txt format from EOS that shows the same issues.
File: chintailease.txt


[a58 bug] Chat Input stopped working with Azure OpenAI model/embedding component

Describe the bug
When a chat input component is connected to Azure Open AI embedding/model, we currently get the below error with a58 version,
Error building vertex Azure OpenAI: 2 validation errors for HumanMessage content str type expected (type=type_error.str) content value is not a valid list (type=type_error.list)

Browser and Version
All
To Reproduce
Steps to reproduce the behavior:

Create a very basic flow with Chat Input -> Azure Open AI Embedding -> Chat Output
Run each component and you'll end up with this error. Console will show error as below:

ValueError: Error building vertex Azure OpenAI: 2 validation errors for HumanMessage
                             content
                               str type expected (type=type_error.str)
                             content
                               value is not a valid list (type=type_error.list)

Screenshots

Additional context
This used to work somewhere with <= a48 version.

@dosu How is this fix implemented in the code of the Chat Input ? I have tried changing the code but it doesnt work. Please provide an example based on the issue that was described before.

Is the problem still there with langflow 1.0.5?

Yes, this is still a problem even with v1.0.6

Hi @msmygit,
Is the problem still there with langflow 1.0.9?

Thank you for your contribution! This issue will be closed. If you have any questions or encounter another problem, please open a new issue and we will be ready to assist you.


Test eslint

Pull Request Title
works better in finding project type issue
Thank you for contributing to mern-project-cli!

@ZeeshanMukhtar1 see this pr


add team role BOT

patch adds support for team member role BOT. bot members don't receive boxes for the PTK and don't have access to any of the application reader masks. the team cache version is bumped so new clients will be able to correctly process change membership links with bot members.

[ ] after release

depends on https://github.com/keybase/keybase/pull/4013
cc @keybase/hotpotatosquad

note: need to add support for bot members to get the public half of the signing key to verify signatures of derived teambot keys


Bug compiling in cordova iOS 4.0.1

Hi, Im trying to compile and here are the errors:
(...)/de.sitewaerts.cordova.documentviewer/SitewaertsDocumentViewer.m:74:84: Property 'request' not found on object of type 'UIView *'
(...)/de.sitewaerts.cordova.documentviewer/SitewaertsDocumentViewer.m:108:84: Property 'request' not found on object of type 'UIView *'
Thanks in advance

I've created a fix. Will send a pull request :)


[5.7] Allow Gate::after() callbacks to provide a result

For example, imagine we wanted to grant admins every ability. But locked posts can't be edited by anyone, even an admin. They have to first be unlocked (this is just a trivial example).
Registering a general before callback (with Gate::before()), there's no way to accomplish this. Instead, we can do it via an after callback:
Gate::after(function ($user) {
    if ($user->isAdmin()) {
        return true;
    }
});

With this in place, any ability that was not granted by a policy et al will be granted here for admins, while still being able to explicitly return false from any policy method to disallow it for everyone (of course, the user would have to be careful to generally not return false from policies. Only when they want to deny everyone explicitly).

My main motivation for this is for use in Bouncer, where we currently run all of our DB permission checks in a before callback. This works great, but means that policies no longer work, because the call is intercepted by Bouncer in many cases.
Instead, we would love to be able to register our logic as an after callback. This way, the policies can all run and do their thing. If any of them return a non-null result, that would be used. Otherwise, Bouncer will run its checks.
You can read more about our need for this in this discussion: https://github.com/JosephSilber/bouncer/issues/264, specifically this comment.

@JosephSilber am I correct in observing that the Laravel Docs for 5.7 need updating to reflect this change to Gate::after?
Or am I mis-reading the change here?
https://laravel.com/docs/5.7/authorization#intercepting-gate-checks

Good catch. That has to be changed now.


String data rendered into table in webchat but its not rendering properly in MS team

Describe the bug
I'm getting table data in string from OpenAI it is rendered into table in webchat fine but its not rendering properly in MS team. Please refer the screenshot.
To Reproduce
Steps to reproduce the behavior:

create a bot
integrate it with azure OpenAI
Ask the question "give me random student data in tabular form"

Expected behavior
want the same table rendering in both Webchat and MS Teams
Screenshots
Webchat

MS Teams

Hello @NagarroShobharaja ,
Thanks for raising your issue. We will check this at our end and will update you accordingly.

Hello @NagarroShobharaja - Could you please share all the steps and code you have referred to setup and test the app?
Are you trying it in Azure Bot web chat?


Revive REST functionality with what conditions?

Hello,
I found there was REST search functionality that was deleted in https://github.com/google/zoekt/commit/744484438f16a7a3458cd4175863a982d7b726ea. I find that functionality useful, so would like to restore it.
Can it be restored as-is (maybe with some tweaks, to support result size limit from request etc), or do you have any concerns with it? Thank you!

The REST support was removed because I added it to support some other functionality.
What do you want to do? I see two options:

Make the core API available over HTTP / JSON.

add a &format=JSON parameter to the Search endpoint in server.go, and dump the data in the web API format.

my main concern is that I don't want to have an extra API flavor, because that necessarily will create extra conversion code that needs to be maintained.
Maybe the srcgraph folks have ideas/preferences too. Summoning @keegancsmith

Maybe the srcgraph folks have ideas/preferences too. Summoning @keegancsmith

We use "net/rpc" to remotely expose a "zoekt.Searcher". We originally used the json API, but quickly moved to something which can expose the core API. What about option 2, but directly marshalling the response from Searcher.Search into JSON?
FYI we have been working on a streaming API internally, and will likely add an adapter to zoekt.Searcher which allows use to do streaming RPCs. I wasn't originally thinking this would be that useful to upstream, but if you feel otherwise we can debate that decision :)

Maybe the srcgraph folks have ideas/preferences too. Summoning @keegancsmith

We use "net/rpc" to remotely expose a "zoekt.Searcher". We originally used the json API, but quickly moved to something which can expose the core API. What about option 2, but directly marshalling the response from Searcher.Search into JSON?
FYI we have been working on a streaming API internally, and will likely add an adapter to zoekt.Searcher which allows use to do streaming RPCs. I wasn't originally thinking this would be that useful to upstream, but if you feel otherwise we can debate that decision :)

Is the streaming just for the browser <-> server communications? You'd need all results anyway to sort the results, right?

Is the streaming just for the browser <-> server communications? You'd need all results anyway to sort the results, right?

Is the streaming just for the browser <-> server communications?

browser <-> server. But we also want to do streaming between services so as to return the results sooner. We have use cases where a search can take a long time. For example a poor regular expression over a large cluster can take a while to return.

You'd need all results anyway to sort the results, right?

We currently aren't relying on ranking/sorting, so no. When we do start doing this, we will try and visit shards/repos in a smart order (somewhat like the rankedShard idea in zoekt).

Is the streaming just for the browser <-> server communications?

browser <-> server. But we also want to do streaming between services so as to return the results sooner. We have use cases where a search can take a long time. For example a poor regular expression over a large cluster can take a while to return.

You'd need all results anyway to sort the results, right?

We currently aren't relying on ranking/sorting, so no. When we do start doing this, we will try and visit shards/repos in a smart order (somewhat like the rankedShard idea in zoekt).

might make sense to add an option "Unsorted" to the SearchRequest, then making all of the APIs streaming makes more sense.

might make sense to add an option "Unsorted" to the SearchRequest, then making all of the APIs streaming makes more sense.


Added new fields to Cooperation model

Added fields availableLessons, finishedLessons to Cooperation model

Don`t forget to change cooperation-schema.yaml and cooperation.yaml files. Also add test cases


Improve RSAPSS documentation

Proposed changes
The documentation for RSAPSS receives additional clarity:

Return value of new_rsapss_load_pkey and new_rsapss_load_skey explains that NULL is returned on failure.
Supported hash algorithms are listed in every applicable function and rendered in proper bullet point form, now. The use of * to create Doxygen lists can cause trouble when also using markdown for documentation. Doxygen itself admits special care needs to be taken. If we simply replace the * with - to make a list, it works without extra worries.
Endianness/Byte-order addressed for key part parameters.
Additionally, the disjoint memory pre-condition for applicable parameters should be mentioned somewhere. Although it is non-sensible in most functions for a client to attempt memory overlapping, verification guarantees are off the table if it is overlapped, and so a note on that should appear generally somewhere in docs. This PR does not address this issue.

These changes resolve the issues expressed in cryspen/hacl-packages#345 & cryspen/hacl-packages#346.
Types of changes
What types of changes does your code introduce to HACL*?
Put an x in the boxes that apply

[ ] Proof maintenance (non-breaking change which fixes a proof regression)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New algorithm or feature (non-breaking change which adds functionality)
[ ] Improved performance (fix or feature that would improve performance of some algorithm on some platform)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CODE_OF_CONDUCT.md doc
[x] I have read and agree to submit my changes under the LICENSE
[x] I have added necessary documentation (if appropriate)
[ ] I have edited CHANGES.md (if appropriate)

* Error 168 at /build/source/code/rsapss/Hacl.RSAPSS.fst(107,1-107,1):
hacl-star>   - Syntax error

if you can fix the missing closing quotes, then I'm happy to merge this... thanks

Updated

Excellent, thanks so much! Great to see this kind of improvements.


Updated cards-es.coffee

A ton of changes. What I've done:
-Translated all the expansion packs. It was weird to be the only language to don't use the oficial published names.
-Changed the text on many, many cards to match the oficial translation (and the FAQ changes on the few cases where it could be applied).
-Added the translation for TIE Defender, Z-95 Headhunter and VT-49 Decimator, as they were the only "old" ships using the original English name instead the one they have in the Spanish game.
-Translated all the new Scum and Villany ships, pilots and upgrades, including the faction name (Escoria y Villanos).
-Added the generic pilots for M3-A Interceptor*, StarViper and Scum Z-95.
-Moved Dace Bonearm from Y-Wing to its HWK-290. Added the missing Hired Gun on his place.
-Added the translation for a few "blank" (or just missing) cards as they didn't had an entry on the file. Experimental Interface or Andrasta title, i.e.
-Fixed a gazillion typos and errors.
-Some extra things I can't remember right now.
I haven't touched a couple things related to the Imperial Rider, as we still don't know how they will exactly translate them.
I've reviewed all the changes 2-3 times, so it shouldn't be any error. I also hope I didn't break anything :D, but I've tried to be extra careful when changing each line.
There may be still some missing cards, but right now my head is a mess. I'll recheck everything once (if) this goes up.
*Although the ship is missing on the Spanish builder :P

Also, I think I'm doing this Pull Request thing correctly. Let me know if I'm not :D

Also again. Seeing this Travis CI failed check, I have no idea what's the problem on the 4 things it has find. Checking right now, I don't see any problem on the A-wing test pilot nor the Royal Guard title. On the "Rebel" and "Imperial"... well, God knows what line is that D:

Are you still figuring out what's going on with the tests or do you want me to drop in and take a look?

Also thanks a lot for all this effort, this is awesome.  (The diff is so much that GitHub isn't bothering to show it to me!)

It looks like one of the problems is in line 169 of cards-es.coffee -- it should be
    exportObj.renameShip 'Aggressor', 'Agresor'

(note the two g's)
The rest of the errors are just updates needed to the tests to match the new translations.  I can fix those, should have that merged up in a bit.


Make a feature comparison table with alternatives

Good "marketing"/glancing/understanding the differences.
Might mean I have to use the alternatives for a bit so I can give it a fair eval.
Differences to Aider:

Less git-commit focused
More general-purpose?
Wider array of tools?

Differences to Cursor:

in-terminal instead of in vscode-fork
extensible with tools

Differences to Open Interpreter:

Idk?

Gptme is linux focused
Agent zero is windows and mac, no Linux uses open Interpreter
Self improving, autocorrecting
From just reading up, looks similar to fabric in cli piping approach
Can do offline fully local
I think the main difference is ai coding tool (create application) or general automation tool with integrated ai (get some task done)

Started writing a docs page yesterday, feedback welcome: https://github.com/ErikBjare/gptme/pull/220

Since I created this issue, Claude Desktop has become kind of an alternative with their MCP protocol enabling local-running tools.
It has also become apparent to me that Claude Projects is sort-of a lightweight version of running gptme in a folder (especially when there's a gptme.toml file): https://x.com/alexalbert__/status/1865073820882886971
I've also had the idea of asking an agent to compare gptme to a bunch of alternatives one-by-one, then aggregate it into a single/half page for the docs/README or such.
I will update the issue description with this info.

I merged it and it's live at https://gptme.org/docs/alternatives.html
But I will keep this issue open since it's not really "done".


Is PHP 5.5 required?

Currently PHP 5.5 is required for the package.  I glanced quickly through the code and the only place I noticed 5.5 syntax was in the tests.  Would it be reasonable to require 5.5 for dev, but 5.4 otherwise?

I think the major reason to use 5.5 was so that class name constants could be used in tests.
I checked the requirements for FlySystem and they state "php": ">=5.4.0" so it would make sense to just follow that.


WSOD when attempting to report abuse while Javascript is disabled.

Disable JavaScript in the browser of your choice and navigate to the Report Abuse page of an existing package (e.g. https://qa.nugettest.org/packages/jQuery/2.0.3/ReportAbuse )
Fill out the form, and then click Report.

Result:  You'll get a WSOD.  Examining the site logs reveals an System.InvalidOperationException that, oddly, appears to be ties to RECAPTCHA APIs.  The full stack trace can be seen at https://qa.nugettest.org/Admin/Errors.axd/detail?id=6313.
Expected:  I'd expect the flow of control to be the same regardless of whether JavaScript is enabled on the client.  In any case, we should be handling internal errors gracefully regardless of the reason.

Related: https://github.com/NuGet/NuGetGallery/issues/1803
I didn't could pass the captcha stuff without JS. Without JS it is super weird...


x/tools/go/analysis/passes/fieldalignment/cmd: document exit codes

Step 1: https://github.com/golang/proposal#the-proposal-process
The proposal author creates a brief issue describing the proposal.
Note: There is no need for a design document at this point.
Note: A non-proposal issue can be turned into a proposal by simply adding the proposal label.
Note: Language changes should follow a separate template

Context
https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/fieldalignment
Usecase
Using https://github.com/switchupcb/disgo/blob/v10/_gen/bundle/main.go#L80

I have to do it in this way because running fieldalignment -fix returns an exit code 3.

exit code 3 is from go/exec Command Run . fieldalignment Stdout shows that structs were fixed.

Running fieldalignment -fix again twice more fixes things (fixes https://github.com/switchupcb/disgo/blob/v10/wrapper/json_unmarshal.go#L186)

Sure, I can fix it in the developer version. However, I'm still unaware of what exit code 3 is.
Code
Add the meaning of the exit codes for fieldalignment to fieldalignment -help or somewhere.

Exit code 3 most likely comes from printDiagnostics in the analysis package. Documented here:

// It returns the exitcode: in plain mode, 0 for success, 1 for analysis
// errors, and 3 for diagnostics. We avoid 2 since the flag package uses
// it. JSON mode always succeeds at printing errors and diagnostics in a
// structured form to stdout.

Add the meaning of the exit codes for fieldalignment to fieldalignment -help or somewhere.

I think this comes down to whether we think we should document the exit codes within analysisflags.Help.
cc @adonovan

I suggest you use the -json flag, which cause the tool to exit zero and report its diagnostics and fixes in a machine-readable form. You don't need to read them, but it solves the exit code problem.
xtools$ cat a.go
package tools

type S struct {
	byte
	int
	bool
}
xtools$ go run ./go/analysis/passes/fieldalignment/cmd/fieldalignment -json -fix a.go; echo $?
{
	"command-line-arguments": {
		"fieldalignment": [
			{
				"posn": "/Users/adonovan/w/xtools/a.go:3:8",
				"message": "struct of size 24 could be 16",
				"suggested_fixes": [
					{
						"message": "Rearrange fields",
						"edits": [
							{
								"filename": "/Users/adonovan/w/xtools/a.go",
								"start": 22,
								"end": 49,
								"new": "struct {\n\tint\n\tbyte\n\tbool\n}"
							}
						]
					}
				]
			}
		]
	}
}
0
xtools$ cat a.go
package tools

type S struct {
	int
	byte
	bool
}
xtools$

BTW I'm curious why you would want to apply fieldalignment to code you plan to bundle. The fixes applied by fieldalignment should be reviewed, since in some cases they may degrade performance and they can certainly cause tests that rely on field order (via reflection) to fail.

@adonovan Thanks for letting me know. That library (disgo) is based on a types library dasgo which defines the types in the manner specified by Discord API. There are many structs so the assumption is that the costs of saving memory (beneficial) over millions of requests will reduce the amount of GC pauses (also beneficial)
I didn't know about the potential for performance degradation (negative). Do you think I should avoid using the fieldalignment tool given that the documentation specifies "rare cases"? Does the performance degradation from both goroutines slowing down outweigh the costs of saving memory?

Thanks for letting me know. The bundle is tested and analyzed in the CICD workflow.