Refurbished checker listing and detail view

New, extended and refurbished command for available checker listing
Splitting "old-style" and  "new-style" invocation
CodeChecker checkers as of now is most likely used by many of our users – yours truly included! – in wrapper scripts to quickly generate specific analyzer enable and disable args for invocation. Due to this, I did not wish to break this interface with the upcoming releases.
Starting from the acceptance of this MR up until a later release, the principle introduced in #610 is somewhat stabbed and broken: in the context of this new command, CodeChecker checkers will NOT have the same behaviour as codechecker-checkers. Code parts related to this behaviour (essentially just HACKs) are marked for removal once later release rolls.
CodeChecker checkers retains its old behaviour.
Issue #579 will be solved by #629.
A warning is implemented as unexecuted code, so users can later be notified about the changes upcoming in a later release.
New codechecker-checkers command
For easier use and better pipeability, the new checkers command works in the following way:

Initially, all checkers are listed, one by one.

The user can request to --only-disabled and --only-enabled for filtering.

By default, only names are printed.

Similar to CodeChecker analyzers, a --details view is available, complete with name, analyzer, description, enabled status

similarly, --output json, csv, ... is present here too.

Just like the "old" CodeChecker checkers command, checkers can be filtered by-analyzer.

Depends: #629

I would recommend to change this behavior

Initially, only the enabled (based on the config file) checkers are listed.

to that all the available checkers are listed first, so the users can see the full list and choose what to enable or disable. It can be misleading if we print out only a limited set of the available checkers, users might think that the enabled list is the full list.

I've done the asked changes, updated the documentation, the MR's code, and also fixed merge conflicts introduced.


Organizing utils

Is your feature request related to a problem? Please describe.
At the moment there's been many new functionalities being created for PASS. Many new functionalities are stored within utils. We should consider organizing the files into utils subdirectories.
Describe the solution you'd like
As stated above, we can consider organizing files into subdirectories.

Issue resolved in PR #171, now merged into Development.


SQL generated by orCreate logged in reverse order

With orchidORM({ log: true }, ...), SQL statements logged by orCreate don't make sense.
For example, the two orCreate operations below should obviously at least begin with the single statement (they can't possibly know about each other):
console.log("--- 1")
await db.config.findOptional(1).orCreate({ title: "foo" })
console.log("--- 2")
await db.config.findOptional(1).orCreate({ title: "foo" })

However, based on the log output, the first query seems to somehow magically know it should insert data, and the second one fetches it right away:
--- 1
(0.5ms) INSERT INTO "config"("title") VALUES ($1) RETURNING * ['foo']
(2.0ms) SELECT * FROM "config" WHERE "config"."id" = $1 LIMIT 1 [1]
--- 2
(0.3ms) SELECT * FROM "config" WHERE "config"."id" = $1 LIMIT 1 [1]

I suspect it simply logs the queries in reverse order? Or it's not logging some begin/rollback wrapping?

orchid-orm 1.34.7

Full reproduction
import process from "node:process"

import { createBaseTable, orchidORM, testTransaction } from "orchid-orm"

const BaseTable = createBaseTable()

class ConfigTable extends BaseTable {
  override readonly table = "config"

  override columns = this.setColumns(t => ({
    id: t.serial().primaryKey(),
    title: t.varchar(),
  }))
}

const db = orchidORM(
  { databaseURL: process.env.DATABASE_URL, log: true },
  {
    config: ConfigTable,
  },
)

await testTransaction.start(db)

await db.$query`
create table "config" (
  id serial primary key,
  title varchar not null
);`

console.log("--- 1")
await db.config.findOptional(1).orCreate({ title: "foo" })
console.log("--- 2")
await db.config.findOptional(1).orCreate({ title: "foo" })

await testTransaction.close(db)

I had an idea for later to re-implement orCreate and upsert using WITH statement shenanigans, so once that's done the logging here will become consistent.


Small Resolution when opening GUI on WSL on 4K monitor

I have 4K monitor. The GUI resolution (font size, graphical interface) is smaller than Windows application. How can I adjust it to fit perfectly to my 27 inch 4K monitor?

same problem，i think it can be slove by modify /etc/xdg/weston/weston.ini  [output] scale=1.5, but nothing happend

Thanks for your report. We've currently disabled fractional scaling due to poor filtering quality. It will be re-enabled in some future released, this is tracked by issue #23.
Note that you can use 200% DPI scaling today and that will scale correctly.
Closing as a duplicate of #23


Possible compatibility issue with Forien's Quest Log

Module Version: v1.5.3
Describe the bug:
When I open the Forien's Quest Log (v0.7.9) quest tracker, I am unable to minimize or close the quest tracker if Window Controls is enabled. If I disable Window Controls this issue does not persist.
Steps to reproduce the behavior:
Go to Journal Notes button on the left side of the menu.
Click on Quest Tracker button.
Attempt to close/minimize the window.
Expected behavior:
I expect that the window would minimize or close, like other windows. Instead, they stay stuck, unable to minimize or close the window. This issue persists between logins.
Screenshots
If applicable, add screenshots to help explain your problem.

Browser: Brave Browser, v1.33.106
Foundry Version: v0.8.9
Game System: DnD5e v1.5.6
Link to Forien's Quest Log GitHub: https://github.com/League-of-Foundry-Developers/foundryvtt-forien-quest-log

Hi @Kev1112005
I am not planning on supporting 0.8.x anytime soon.
When possible, please confirm if this is still valid on V9.

I have the same problem, but I'm also on 0.8.9.

This is a problem for me on v9

Hey all @JordanRR @NutritiousCookie @Kev1112005 - Window Controls 1.6.3 should work with Forien! Could anyone please confirm?

Hey all @JordanRR @NutritiousCookie @Kev1112005 - Window Controls 1.6.3 should work with Forien! Could anyone please confirm?

I still have the same problem, I'm on Foundry 0.8.9.

Ah, I am very sorry @JordanRR - Installing 0.8.9 with an old version of a module, to support both and old Foundry and an external module simultaneously is too much for the moment :) Will update to indicate that it is only for V9+

No problem. Thanks!


Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root

Signed-off-by: Peter Zhu<EMAIL_ADDRESS>Description
Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root
Issues Resolved
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

BWC tests should work it's just failing due to security plugin.

BWC tests should work it's just failing due to security plugin.

@kavilla Are you taking about OpenSearch dashboards?

Codecov Report

Merging #1990 (a20211c) into main (7c732e9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1990   +/-   ##
=========================================
  Coverage     94.41%   94.41%
  Complexity       22       22
=========================================
  Files           187      187
  Lines          3739     3739
  Branches         29       29
=========================================
  Hits           3530     3530
  Misses          203      203
  Partials          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c732e9...a20211c. Read the comment docs.

Merge it now, we can add back later on.

Merge it now, we can add back later on.

BWC test were running for OpenSearch Dashboards tar distributions they were actually catching some issues that should be followed up. I guess my question instead of full out removing it from everything we remove the BWC tests from the test manifest being called if we don't want to see the error but otherwise it was just show a "failed" notification versus removing this completely.


Update prow config to kfctl_istio_dex config

/assign @yanniszark @gabrielwen
kubeflow/kubeflow#4501

This change is

/lgtm

@yanniszark could you please take a look at this?
This clears up the pathway for kubeflow/manifests#620.

Thanks @krishnadurai!
/lgtm
/approve

cc @krishnadurai maybe this needs a rebase?
This doesn't seem related:
kubeflow-kfctl-presubmit-kfctl-go-iap-96-1801bd1-8480-1c0b-deploy_pytorchjob-pytorch-job:

Subprocess failed; level=error msg="validating registry URL: validating GitHub registry URL: \"https://github.com/kubeflow/kubeflow/tree/master/kubeflow/registry.yaml\" actual 404; expected 200"
--

@yanniszark did a rebase right now. Let's see if it passes.

/lgtm


Readme: Install npm package globally

@bencevans Thanks!  Perhaps this should be sudo npm install -g gittorrent?

In README's I'd suggest longform options (--global rather than -g) as
for users that arn't used to npm etc might get a better idea.
Ideally sudo shouldn't be used when installing modules either. Stick
them in userland! :D
On Mon, Jun 1, 2015 at 3:55 PM, Chris Ball<EMAIL_ADDRESS>wrote:

@bencevans Thanks! Perhaps this should be sudo npm install -g
gittorrent?
—
Reply to this email directly or view it on GitHub.

Ah, that's fair.  But won't it just fail for everyone by trying to write to /usr/local, when you use --global but not sudo?

@cjb It depends on how you have setup your system. Personally I have setup so my current user owns /usr/local

But the point of the README is to explain how to install npm modules to people who don't already know, and those people are very likely not to have set up their system to make --global work without sudo.
It seems like it would make more sense to include sudo in the instructions, and then people who've done as @ralphtheninja did will know that it's safe for them to remove the sudo.

Or perhaps write something like
$ [sudo] npm i -g gittorrent

I'd say the convention is to just write npm i -g xyz to inform the user that it's a global install and leave up the user to decide if he/she needs to do sudo or not.

Why not
add the --global flag to install globally (may require superuser privileges)

If this is only meant as a cli tool it should always be installed globally imo.
@cjb Or is this meant to be used as a dependency as well?

@bencevans Thanks for the patch!  I'll merge this, add a sudo, and add a note explaining that you can avoid using sudo if you get the binaries into your $PATH.

:+1:

Sweet!
On 2 Jun 2015 17:32, "Chris Ball"<EMAIL_ADDRESS>wrote:

@bencevans https://github.com/bencevans Thanks for the patch! I'll
merge this, add a sudo, and add a note explaining that you can avoid using
sudo if you get the binaries into your $PATH.
—
Reply to this email directly or view it on GitHub
https://github.com/cjb/GitTorrent/pull/30#issuecomment-108007475.


Pin NumPy < 2 for Python 3.9

Fix cluster analysis
E           Cell In[1], line 9
E                 7 from libertem.udf.stddev import StdDevUDF
E                 8 from libertem.masks import _make_circular_mask
E           ----> 9 from skimage.feature import peak_local_max
E                10 import sparse
E                11 from sklearn.feature_extraction.image import grid_to_graph
E
E           File ~/work/LiberTEM/LiberTEM/.tox/py3.9/lib/python3.9/site-packages/skimage/__init__.py:122
E               118     # We are not importing the rest of the scikit during the build
E               119     # process, as it may not be compiled yet
E               120 else:
E               121     try:
E           --> 122         from ._shared import geometry
E               123         del geometry
E               124     except ImportError as e:
E
E           File geometry.pyx:1, in init skimage._shared.geometry()
E
E           ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[N/A] I have added a changelog entry for my contribution
[N/A] I have added/updated documentation for all user-facing changes
[ ] I have added/updated test cases
[N/A] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed
[x] No import of GPL code from MIT code

/azp run libertem.libertem-data

I think this was fixed with the release of scikit-image==0.24.0 @ https://pypi.org/project/scikit-image/0.24.0/#files. As-is I can run the cluster analysis on numpy==2 with python==3.9. So I think this can be closed without merging?
I've re-triggered the failed, thorough tests to check.

New release fixed it for me, too. Closing!


[Runtime] Exclude logd_helper from tracing.

logd_helper is part of the log system and we can't safely log from within it.
rdar://126120335

@swift-ci please smoke test


[SuperEditor & SuperTextField] ColorAttribution support

Hello,
Is text coloring for SuperEditor, SuperReader and SuperTextField under development?
ColorAttribution doesn't seem to be working at the moment.
Thank you.
ParagraphNode(
  id: Editor.createNodeId(),
  text: AttributedText(
    'My text colored in orange',
    AttributedSpans(
      attributions: const [
        SpanMarker(
          attribution: boldAttribution,
          offset: 0,
          markerType: SpanMarkerType.start,
        ),
        SpanMarker(
          attribution: ColorAttribution(
            Colors.orange,
          ),
          offset: 0,
          markerType: SpanMarkerType.start,
        ),
        SpanMarker(
          attribution: ColorAttribution(
            Colors.orange,
          ),
          offset: 24,
          markerType: SpanMarkerType.end,
        ),
        SpanMarker(
          attribution: boldAttribution,
          offset: 24,
          markerType: SpanMarkerType.end,
        ),
      ],
    ),
  ),
),

@Sh4dord I'm testing this against main on iphone simulator and macOS desktop, and I'm not able to reproduce the issue you're describing.
Could you please share a reproducible example where this issue is occurring?

Okey, what is the difference between stable and main ?
I currently use stable and on stable is not working. Does I in development feature ?

@Sh4dord I'm testing this against main on iphone simulator and macOS desktop, and I'm not able to reproduce the issue you're describing.

Could you please share a reproducible example where this issue is occurring?

Okey, what is the difference between stable and main ?
I currently use stable and on this is not working.

I currently use stable and on stable is not working. Does I in development feature ?

By stable, are you referring to the super_editor package hosted on pub.dev? and is that what you're using in your pubspec rn?

@Sh4dord Could you please share the Flutter version you're using and a reproducible example for this issue?
For super_editor, stable branch is tested against Flutter stable channel, and main against Flutter master channel. So far on both of this branches with latest Flutter stable 3.13.9 and master updates, I'ven't been able to reproduce this issue.

@rutvik110 Sorry for response delay
I use Flutter branch stable
[✓] Flutter (Channel stable, 3.13.9, on macOS 13.5.1 22G90 darwin-arm64, locale fr-FR)

I use also super_editor on branch stable
pubspec.yaml

dependencies:
  flutter:
    sdk: flutter
  super_editor:
    git:
      url: https://github.com/superlistapp/super_editor
      path: super_editor
      ref: stable

dependency_overrides:
  super_text_layout:
    git:
      url: https://github.com/superlistapp/super_editor
      path: super_text_layout
      ref: stable
  attributed_text:
    git:
      url: https://github.com/superlistapp/super_editor
      path: attributed_text
      ref: stable

dev_dependencies:
  flutter_test:
    sdk: flutter

Then I use SuperReader :
super_reader.dart
SuperReader(
              document: MutableDocument(
                nodes: [
                  ParagraphNode(
                    id: Editor.createNodeId(),
                    text: AttributedText(
                      'My text colored in orange',
                      AttributedSpans(
                        attributions: const [
                          SpanMarker(
                            attribution: boldAttribution,
                            offset: 0,
                            markerType: SpanMarkerType.start,
                          ),
                          SpanMarker(
                            attribution: ColorAttribution(
                              Colors.orange,
                            ),
                            offset: 0,
                            markerType: SpanMarkerType.start,
                          ),
                          SpanMarker(
                            attribution: ColorAttribution(
                              Colors.orange,
                            ),
                            offset: 24,
                            markerType: SpanMarkerType.end,
                          ),
                          SpanMarker(
                            attribution: boldAttribution,
                            offset: 24,
                            markerType: SpanMarkerType.end,
                          ),
                        ],
                      ),
                    ),
                  ),
                ],
              ),
            ),

I that case, I have the problem of the orange text not colored in orange but in black

I was able to reproduce this issue with SuperReader but not SuperEditor.
@Sh4dord Could you please confirm if this is an issue with SuperReader only or if SuperEditor also has similar issue on your side?

@Sh4dord Could you please check if the linked PR resolves your issue?


Headless mode is changing in selenium

https://www.selenium.dev/blog/2023/headless-is-going-away/
Looks like --headless needs to be changed to --headless=new
I'm on chromium/chromedriver 110.0.5481.77 (from apt in Debian 11)
https://github.com/SeleniumHQ/selenium/issues/11634

I second that switching the parameter to "headless=new" works for the newer versions of chromium.

Thanks! If anyone is interested in making a PR with this change as well as the relevant dependency changes to use the new versions, that would be great!

Created a pull request but as mentioned in note, took the road of just adding the flag and not changing the old one, needs to be tested with older versions of chromium -> https://github.com/mintapi/mintapi/pull/589

I gather this is the symptom for this problem:
  File "/usr/bin/mintapi", line 8, in <module>
    sys.exit(main())
  File "/usr/lib/python3.10/site-packages/mintapi/cli.py", line 465, in main
    mint = Mint(
  File "/usr/lib/python3.10/site-packages/mintapi/api.py", line 124, in __init__
    self.login_and_get_token(
  File "/usr/lib/python3.10/site-packages/mintapi/api.py", line 192, in login_and_get_token
    self.driver = driver or _create_web_driver_at_mint_com(
  File "/usr/lib/python3.10/site-packages/mintapi/signIn.py", line 311, in _create_web_driver_at_mint_com
    driver = Chrome(options=chrome_options)
  File "/usr/lib/python3.10/site-packages/seleniumrequests/request.py", line 148, in __init__
    super(RequestsSessionMixin, self).__init__(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/selenium/webdriver/chrome/webdriver.py", line 80, in __init__
    super().__init__(
  File "/usr/lib/python3.10/site-packages/selenium/webdriver/chromium/webdriver.py", line 104, in __init__
    super().__init__(
  File "/usr/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 286, in __init__
    self.start_session(capabilities, browser_profile)
  File "/usr/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 378, in start_session
    response = self.execute(Command.NEW_SESSION, parameters)
  File "/usr/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 440, in execute
    self.error_handler.check_response(response)
  File "/usr/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: unknown error: unable to discover open pages

Hi!
I'm no longer encountering the above issue in my day to day use.
I also used the technique in the fold below to try to reproduce it with various combinations of Chrome versions, the current main branch and a copy of @gyllen's deleted change in #590--all seemed to work.
If you don't see a problem with my methodology, I guess my recommendation would be to close this and the PR until can sees the bug again and or wants to advocate for another reason to use headless=new.
That said, assuming you trust my test, it doesn't sound like the proposed change in #590 will hurt anything, so merging it might be OK too:
Results:

mint-mintapi-main-111.0: success
mint-mintapi-main-108.0: success
mint-mintapi-main-109.0: success
mint-mintapi-main-103.0: success
mint-apiology-gyllen-patch-1-109.0: success
mint-apiology-gyllen-patch-1-111.0: success
mint-apiology-gyllen-patch-1-103.0: success

Testing technique
Dockerfile:
ARG SELENIUM_IMAGE
FROM $SELENIUM_IMAGE

# add mintapi to path
ENV PATH=$HOME/.local/bin:$PATH

RUN echo "**** install packages ****" && \
    sudo apt-get update && \
    sudo apt-get install -y python3-pip git
# && \
ARG MINTAPI_SPECIFIER
RUN pip3  install "${MINTAPI_SPECIFIER:?}" && \
    echo "**** cleanup ****" && \
    sudo apt-get clean && \
    sudo rm -rf \
	/tmp/* \
	/var/lib/apt/lists/* \
	/var/tmp/*

# make mintapi help menu default command
CMD mintapi -h

Steps to test:
cd ~/src/mintapi/
export MINTAPI_SPECIFIER=git+https://github.com/${git_owner:?}/mintapi.git@${branch_name:?}
tag_name=mint-${git_owner:?}-${branch_name:?}-${chrome_version:?}
docker build -t ${tag_name:?} --build-arg SELENIUM_IMAGE=selenium/standalone-chrome:${chrome_version:?} --build-arg MINTAPI_SPECIFIER --progress=plain -ff .docker/Dockerfile .
# replace below with whatever your favorite working Docker invocation is, of course!
docker run -v "${HOME:?}/.mintapi":/home/seluser/.mintapi -t "${tag_name:?}" mintapi --attention --fail-if-stale --wait_for_sync_timeout=150 --beta --use-chromedriver-on-path --transactions --headless "${MINT__USERNAME:?}" "${MINT__PASSWORD:?}" | head -200
# now log the results
echo "${tag_name:?}: "


Expect Bundle CRD to exist, do not create it

Issues with current approach where Smith ensures Bundle CRD exists before it starts doing anything:

Smith needs extra permissions to create/update CRDs. This may not be desirable.
This complicates code a bit. It is a bit ugly to attach CRD listener after the CRD informer has started.

As part of this issue documentation should be added, explaining what needs to be done to provision CRD for Bundle.

Fixed by #184.


[SPARK-5831][Streaming]When checkpoint file size is bigger than 10, then delete the old ones

Can one of the admins verify this patch?

Eh, can you explain why this should be changed?

ok to test

Test build #27552 has started for   PR 4621 at commit b5f2816.

This patch merges cleanly.

Test build #27552 has finished for   PR 4621 at commit b5f2816.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27552/
Test FAILed.

Retest this please

Test build #27554 has started for   PR 4621 at commit b5f2816.

This patch merges cleanly.

Test build #27554 has finished for   PR 4621 at commit b5f2816.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27554/
Test PASSed.

It doesn't actually affect anything, since take(n) is empty for any n <= 0, but this looks like it was clearly a typo.


TK8 Cattle AWS Provisioner with Terraform Rancher Provider on Linux

Describe the bug
When executing the process described here, TK8 Cattle AWS Provisioner with Terraform Rancher Provider, on Ubuntu 18.04 and CentOS Linux 7.6, both amd64, in the end of the process, the output of the command tk8 cluster install cattle-aws, says everything were deployed, yet, any resource is created on AWS or Rancher.
Additional context
TK8-v0.7.1
Terraform-v0.12.2
config.yaml file:
config.txt
tk8 cluster install cattle-aws command output:
tk8_cluster_install_cattle-aws-output.txt

Fixed via #107


Missing filters for Flows with DateTimeTz

As part of #30 i would assume that both flows of DateTime  and DateTimeTz should have appropriate filters.

Fix will be in 0.7.3 . Sorry for the delay :(


[WebToolsE2E][Aspire]Error "failed to add files..." pop up after run command "azd pipeline config"

INSTALL STEPS

Clean machine: Win11 x64 23h2 ENU
Install Dev17.10.0 Preview 7 [rel.d17.10-34902.84] (Includes Aspire 8.0.0-preview.7.24251.11)
Apply NuGet Feeds.
Install azd use power shell
powershell -ex AllSigned -c "Invoke-RestMethod 'https://aka.ms/install-azd.ps1' -OutFile 'install-azd.ps1'; ./install-azd.ps1 -Version 'daily'"

REPRO STEPS
1.File > New Project > .NET Aspire Starter Application > Make sure .NET 8.0 is select, ensure that Use Redis for caching(requires a supported container runtime) is checked.
2.Open a new terminal window and cd into the root of the project and type azd init.
3.Create a folder named .github at the root of your project, create a folder workflows in ".github" folder, create
azure-dev.yml in folder "workflows" then add below code to azure-dev.yml file.
on:
  workflow_dispatch:
  push:
    # Run when commits are pushed to mainline branch (main or master)
    # Set this to the mainline branch you are using
    branches:
      - main

permissions:
  id-token: write
  contents: read

jobs:
  build:
    runs-on: ubuntu-latest
    env:
      AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
      AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
      AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}
      AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
      AZURE_ENV_NAME: ${{ vars.AZURE_ENV_NAME }}
      AZURE_LOCATION: ${{ vars.AZURE_LOCATION }}
    steps:
      - name: Checkout
        uses: actions/checkout@v4

      - name: Install azd
        uses<EMAIL_ADDRESS>
      - name: Install .NET Aspire workload
        run: dotnet workload install aspire

      - name: Log in with Azure (Federated Credentials)
        if: ${{ env.AZURE_CLIENT_ID != '' }}
        run: |
          azd auth login `
            --client-id "$Env:AZURE_CLIENT_ID" `
            --federated-credential-provider "github" `
            --tenant-id "$Env:AZURE_TENANT_ID"
        shell: pwsh

      - name: Log in with Azure (Client Credentials)
        if: ${{ env.AZURE_CREDENTIALS != '' }}
        run: |
          $info = $Env:AZURE_CREDENTIALS | ConvertFrom-Json -AsHashtable;
          Write-Host "::add-mask::$($info.clientSecret)"

          azd auth login `
            --client-id "$($info.clientId)" `
            --client-secret "$($info.clientSecret)" `
            --tenant-id "$($info.tenantId)"
        shell: pwsh

      - name: Provision Infrastructure
        run: azd provision --no-prompt

      - name: Deploy Application
        run: azd deploy --no-prompt

4.Run the azd pipeline config command  and type "y" when  azd prompts you to commit and push your local changes to start the configured CI pipeline.
Note:
1.The workaround is sample, just close the vs and the command window, then reopen the command window, rerun the "azd pipeline config", this issue will not repro.
2.When do scenario Tutorial: Deploy a .NET Aspire app using the Azure Developer CLI and GitHub Actions meet this issue, can refer this for details info.
ACTUAL:  Error pop up"failed to add files..."

ERROR: git push: adding files: failed to add files: exit code: 128, stdout: , stderr: warning: in the working copy of '.gitignore', LF will be replaced by CRLF the next time Git touches it
error: open(".vs/AspireSample/FileContentIndex/c963a3b7-5269-46f1-8405-9bf21f5b58c9.vsidx"): Permission denied
error: unable to index file '.vs/AspireSample/FileContentIndex/c963a3b7-5269-46f1-8405-9bf21f5b58c9.vsidx'
fatal: adding files failed

EXPECTED No Error pop up.

@v-yuwzh doesn't seem to be an issue with azd pipeline config since the error is coming from git push.
Please try adding .vs/* to .gitignore and try. @vhvb1989 do you see anything else going on?

@rajeshkamal5050 , when add .vs/* to .gitignore, this issue will not repro, thanks for your solution.


Incorrect English in the Core eDiscovery bullet under eDiscovery solutions heading

The phrase "Core eDiscovery builds on the basic search and export functionality of Content search enabling you to create eDiscovery cases and eDiscovery managers who can only access the case their members of. " should read something like "Core eDiscovery builds on the basic search and export functionality of Content search enabling you to create eDiscovery cases and eDiscovery managers who can only access the cases of which they are members."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 562b6b1d-b0fd-0d65-9db8-37df67bd7035
Version Independent ID: 92c4403b-0d6b-88aa-74f4-ba3b7640ad00
Content: Microsoft 365 eDiscovery solutions - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/ediscovery.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@exactmike Thanks for the heads up. I will fix this.


fix link

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnetcore/data/ef-mvc/advanced.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnetcore/data/ef-mvc/advanced.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


project moved to second dev machine fails to start with error 404.15

Using Azure AD for authentication/authorization. Followed the asp.net web app project template and used 'school/work' authentication option. Project has been working well locally, IIS Express, and deployed to Azure.
But when I moved to a second dev machine and cloned project from repo, will no longer start in localhost https port. Immediately results in error 404.15, query string is too long, and indeed the detail area shows a requested URL that is about a page long.
 Tried matching ports by setting in /Properties/launchSettings.json, all to no avail. Issue persists. Will move to another dev machine today and try to clone again.

Is the 404.15 coming from your own server or from a request to Azure AD?
cc @Tratcher

Sorry, believe it is coming from the callback to Azure (how would I know?).
To get past it, I commented out the authentication code in startup.cs in order to proceed on laptop dev machine. Then checked in changes, returned to regular work PC, uncommented that auth code, build, run, and all is well. The laptop I had an issue on was a straight clone from git repo (VS team services) and I was running on same network plus two remote networks and always had the same issue.
If you want, I can run the project again on the laptop to determine source of 404.15
Don't have time today, but willing to try reproducing with clean project template using 'work/school' auth and set up another Azure application.

https://www.iis.net/configreference/system.webserver/security/requestfiltering/requestlimits
I'd guess it's a question of having request limits installed or configured differently on the two machines. Are they the same OS / IIS version? Is it different in IIS vs IIS Express?

@Thratcher I don't think that this is a matter of request limits as I have travelled down that route a bit and it will just continue to loop until it breaks.....
I actually have 2 developers that are experiencing the same issue. These are Windows 10 builds. The problem seems to let us log in through Azure but then we get sent into a loop where it is breaking down at our HomeController with the [Authorize] tag..... it fails gets sent back through Azure AD... goes through since you logged in already...back to HomeController and on and on...
Our Startup.cs is pretty straightforward right now ...
 app.UseCookieAuthentication(options =>
            {
                options.AutomaticAuthenticate = true;
                options.AutomaticChallenge = true;
                options.ExpireTimeSpan = new System.TimeSpan(0,10,0);
                options.SlidingExpiration = true;

            });`

app.UseOpenIdConnectAuthentication(options =>
            {
                options.AutomaticChallenge = true;
                options.ClientId = Configuration["Authentication:AzureAd:ClientId"];
                options.Authority = Configuration["Authentication:AzureAd:AADInstance"] + Configuration["Authentication:AzureAd:TenantId"];
                options.PostLogoutRedirectUri = Configuration["Authentication:AzureAd:PostLogoutRedirectUri"];
                options.SignInScheme = CookieAuthenticationDefaults.AuthenticationScheme;
                options.Events = new CarepilotAuthenticationEvents(loggerFactory);
            });

The devs in question have already tried to clear cookies in their respective browsers. It's very puzzling because we have also had one other end user(tester) experience the same issue on one of her laptops and then when switching to a different one she is fine. This is with the site deployed to Azure. We get a slightly different log output here...
warn: Microsoft.AspNet.Authentication.OpenIdConnect.OpenIdConnectMiddleware[27]       => RequestId:0HKPP4E9FV2EG RequestPath:/signin-oidc       .AspNet.OpenIdConnect.State.ENQPD3-yDttk3HZgzRKu4o71cmYy-fZOUSXKcHiRKRI cookie not found. info: Microsoft.AspNet.Authentication.OpenIdConnect.OpenIdConnectMiddleware[0]       => RequestId:0HKPP4E9FV2EG RequestPath:/signin-oidc       Error from RemoteAuthentication: Correlation failed. info: Microsoft.AspNet.Hosting.Internal.HostingEngine[2]
Currently we are pegged at RC1 Update 1 until RC2 becomes a bit more stabilized. We are running on IIS Express locally and I would assume IIS in Azure.  So if someone could throw us a direction to solve here that would be helpful.

"Correlation failed" is a mismatch between the correlation cookie and the state field in the request.
https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication.OpenIdConnect/OpenIdConnectHandler.cs#L398
Delete all the cookies and then take a fiddler trace of the login flow.
Side note: You should only have AutomaticChallenge enabled on a single middleware, not both. I think you want it on OIDC in this scenario.
What do you do in CarepilotAuthenticationEvents?

I will try to have them install fiddler and trace the login flow.... thanks for the heads up on the Automatic Challenge piece.
The CarepilotAutheticationEvents was just an attempt to hook into the Failed event to see if we could catch some kind of extra tidbit of information.


share plus plugin doesn't work on flutter web

What exactly does not work?
Can you post a reproducible example?

 static Future<void> forTap(BuildContext context) async {
    context.findRenderObject()!.sendSemanticsEvent(const TapSemanticEvent());
    switch (_platform(context)) {
      case TargetPlatform.android:
      case TargetPlatform.fuchsia:
        return SystemSound.play(SystemSoundType.click);
      case TargetPlatform.iOS:
      case TargetPlatform.linux:
      case TargetPlatform.macOS:
      case TargetPlatform.windows:
        return Future<void>.value();
    }

The error raises in C:\flutter\packages\flutter\lib\src\material\feedback.dart, in short the Feedback class .There seems to be no case defined for the web. Below is the debug console log:
Error: Unsupported operation: _Namespace
    at Object.throw_ [as throw] (http://localhost:54986/dart_sdk.js:5393:11)
    at Function.get _namespacePointer [as _namespacePointer] (http://localhost:54986/dart_sdk.js:57149:17)
    at Function._namespacePointer (http://localhost:54986/dart_sdk.js:54830:28)
    at Function._dispatchWithNamespace (http://localhost:54986/dart_sdk.js:54835:31)
    at io._File.new.open (http://localhost:54986/dart_sdk.js:54984:23)
    at io._File.new.writeAsBytes (http://localhost:54986/dart_sdk.js:55238:19)
    at capture (http://localhost:54986/packages/convert_widget_image_example/utils.dart.lib.js:39:17)
    at capture.next (<anonymous>)
    at http://localhost:54986/dart_sdk.js:40636:33
    at _RootZone.runUnary (http://localhost:54986/dart_sdk.js:40493:58)
    at _FutureListener.thenAwait.handleValue (http://localhost:54986/dart_sdk.js:35420:29)
    at handleValueCallback (http://localhost:54986/dart_sdk.js:36005:49)
    at Function._propagateToListeners (http://localhost:54986/dart_sdk.js:36043:17)
    at _Future.immediate.[_completeWithValue] (http://localhost:54986/dart_sdk.js:35885:23)
    at async._AsyncCallbackEntry.new.callback (http://localhost:54986/dart_sdk.js:35908:35)
    at Object._microtaskLoop (http://localhost:54986/dart_sdk.js:40798:13)
    at _startMicrotaskLoop (http://localhost:54986/dart_sdk.js:40804:13)
    at http://localhost:54986/dart_sdk.js:36267:9

It kinda looks to me that you're trying to use dart:io's  File on web which will not work. Are you sure that's not the case?

Yup that's it, so will I be only able to share text?

Yes, at the moment that's the case.

Yes, at the moment that's the case.

Any way to cover this issue?

Dart:io will never work on web.
But there's some progress here: https://github.com/fluttercommunity/plus_plugins/pull/318


Api needs to know about the language

If not specifying the language the flagged tokens array will be empty for some people

@ashkansirous : Thanks for your contribution! The author, @mikedodaro, has been notified to review your proposed change.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ashkansirous sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@ashkansirous : Thanks for your contribution! The author, @mikedodaro, has been notified to review your proposed change.

#sign-off


Added basic linting with Verilator and support for System Verilog files

Early days on a lot of these things but the basic support is there...

https://user-images.githubusercontent.com/16142499/226522062-7354e3e5-331b-4bcb-ae0e-d2217584cb1b.mp4
This probably isn't because of anything wrong with your PR, but I noticed that sometimes the linter falls a bit behind what's happening in the editor.  for example, if I add some gibberish, I'll get a ton of errors after I save.  but then if I undo the change and save again, the errors remain until I save a second time.  have you seen this on your side?

This probably isn't because of anything wrong with your PR, but I noticed that sometimes the linter falls a bit behind what's happening in the editor. for example, if I add some gibberish, and then I save, I'll eventually get a ton of errors after I save, if I add a line break. but then if I undo the change and save again, the errors remain until I save a second time. have you seen this on your side?

I have not seen this on my end. Can you try and enable debug log and make sure the file does get re-parsed after you make changes?

I can see that in some cases, the linter runs on stale file data for me.  In the attached image, I did the following steps:

enable debug logging in the extension
entered some gibberish on line 10
cleared any existing extension debug logs and starting fresh
discarded changes on line 10
saw in the debug logs that the file was processed, and errored out on line 10, even though line 10 is now blank

There may be a different API that debounces the file changes and waits a little bit before processing (onDidStopChanging).  It is just a theory but might be worth looking into.  But it's up to you - we can definitely merge this PR as-is or hold off until a little more investigation.  I don't mind doing some investigation this weekend on whether onDidStopChanging would solve that problem.
https://docs.nova.app/api-reference/text-editor/#ondidstopchangingcallback-thisvalue

Ok, long story short I was always linting the file on disc, even when changes were made inside the editor so that's how things looked out of sync.
We're now saving the editor content to a tmp file and linting that since Verilator doesn't seem to accept input from stdin. Seems to work.
Let's both play with it for a bit and see how it goes.

Thanks so much!  Sorry I haven't had more time yesterday to try this.  But I will give it some time this weekend.

I'd like to credit your Github username in the changelog. is that ok?

Sure thing. I appreciate it!


Conditionally multi-targeting a project causes VS memory to grow unbounded

Steps to reproduce:

Create a new project
Edit the project to multi-target where one of the TFMs is conditionally declared

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFrameworks>netcoreapp1.0</TargetFrameworks>
    <TargetFrameworks Condition="'$(OS)'=='Windows_NT'">$(TargetFrameworks);net451</TargetFrameworks>
  </PropertyGroup>
</Project>

Open the project in VS

VS's memory grows unbounded and the UI is completely frozen. Removing the condition in the TFM specification causes the project to load normally.
VS version: 15.0.0-RC.3+26123.0.d15rel
I separately filed a feedback item for this but also creating this so we can track this via our work items.

cc @natemcmaster @davkean

This is a dupe of https://github.com/dotnet/roslyn-project-system/issues/547, which I resolved as Won't fix as we didn't have an actual user scenario affected by it.
The issue here is that our TargetFramework project configuration dimension provider determines the set of TFMs by reading the project xml, because there is no way to do an msbuild project evaluation at unconfigured project level, and it only identifies netcoreapp1.0 as the set of TFMs. The language service loops infinitely to try to create an aggregate workpsace project context with 2 TFMs, but we end up with a single one and keep retrying. See this comment for the underlying issue. This piece of code executes before we create any configured project, so we cannot do any evaluation.
Couple of possible ways to fix this:

CPS/MSbuild allows us to do a project evaluation at unconfigured project level
We move away from implicitly inferring configurations from project file.

Tagging @davkean and @lifengl in case they have a solution for (1), i.e. https://github.com/dotnet/roslyn-project-system/issues/547.
Tagging @RaulPerez1, who was looking at (2).

Until we've figured 2), can we do something tactical here to not block VS and maybe just ignore the one that we can't resolve?

I am wondering if even 2) will help, as we will eventually need an evaluation at unconfigured project level to compute configurations.

can we do something tactical here to not block VS and maybe just ignore the one that we can't resolve?

Yes, but is this a mainline scenario? Would it be better to just add this to release notes that TFMs cannot be conditioned for this release? If we ignore the conditioned properties, user would still be confused why it never worked as we don't generate any such diagnostic message.

Then add a diagnostic or fail the load. This really isn't ideal behavior to continue to consume memory until we crash.

Yes, but is this a mainline scenario?

It's going to be pretty common for people that want to multi-target but also want to build on non-Windows OS's, since we don't support targeting .NET Framework when building outside of Windows right now.  We do this in the SDK, for example.

Follow up question to clarify what was fixed.
Since CPS still parses XML, does this mean only the unconditioned TargetFrameworks property is identified? If so, will this work better?
    <TargetFrameworks>netcoreapp1.0;net451</TargetFrameworks>
    <TargetFrameworks Condition="'$(OS)'!='Windows_NT'">netcoreapp1.0</TargetFrameworks>

Yes, that is correct.

Ok, thanks. Should there be a follow-up issue to make conditional TargetFrameworks work?

Yes, I re-opened and added comment to https://github.com/dotnet/roslyn-project-system/issues/547#issuecomment-277379863

Thanks, I'll track that issue now.


Odd data issues in the country list

For any country data assume that the totals are for the last reported date shown in the json available at https://virustrack.live/site-data/confirmed.json.
!Global has 125,865 cases. !Outside Mainland China has 125,865. How is that possible? If it's truly !Outside Mainland China it should be 125,865 - 80,793 or 45,072.
There is an entry for China with 80,921 and an entry for Mainland China with 80,793.
We have South Korea 7869, and Korea, South 7755.
We have United Kingdom 459 and UK 456
Czech Republic 94 and Cezchia 91
Taiwan* 48 and Taiwan 48
There's an Iran with cases, but also Iran (Islamic Republic of) with 0
There's a Vietnam and a Viet Nam

Hola.
I'll work on this as part of issue 0096 - they are related.

These are the issues I mentioned with the original data source.  If you open this in Vim or awk/grep it, you'll find all these weird data entries.  They're doing a shoddy job of maintaining this thing.


File Locksmith doesn't recognize 'System' using font files

Microsoft PowerToys version
0.64.1
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
File Locksmith
Steps to reproduce
Install an OTF font file.
Try to delete them. Some of the font files won't be possible to delete for some reason due to being used by System process.
Use File Locksmith to check the file for processes using the font file.
✔ Expected Behavior
It should be able to detect which System process is using it and stop it, so I can delete the font file without restarting computer.
❌ Actual Behavior

Restart as administrator:
It doesn't work at all (infinite loading circle)

Other Software
No response

/bugreport

When trying to use "What's using this file" on "C:\Windows\Fonts", I can get a list of the processes using the fonts. Can you please provide more detailed repro steps as well?


Handle referral transactions via toasts

Wont do this .... its no needed given its all the dialog anyway.


[BUG] Check container engine state. Failed: exit status 60 Error During Scan

Describe the bug
When running a scan, the extension returns an error: Error: Check container engine state. Failed: exit status 60.
Expected behavior
KICS is executed without errors and issues are highlighted and results are shown in the output as expected.
Actual behavior
Although KICS seems to execute correctly (based on the Docker logs), the extension only shows the error message without displaying the actual scan results.
Steps to reproduce

Install the extension
Open a Terraform file
Save the file
See error

Environment

VS Code extension version: v2.17.0
Platform: Ubuntu 24.04 LTS (running on a virtual machine)
VS Code: 1.92.1
Docker: 27.1.1, build 6312585

Docker Logs

docker ps

CONTAINER ID   IMAGE                   COMMAND                  CREATED        STATUS                  PORTS     NAMES
024683ec3a07   checkmarx/kics:latest   "/app/bin/kics scan …"   1 second ago   Up Less than a second             cli-kics-realtime-698e3ac9-8fcd-462f-a34b-8465e166a021

docker logs -f 024683ec3a07

   MLLLLLM             MLLLLLLLLL   LLLLLLL             KLLLLLLLLLLLLLLLL       LLLLLLLLLLLLLLLLLLLLLLL
   MMMMMMM           MMMMMMMMMML    MMMMMMMK       LMMMMMMMMMMMMMMMMMMMML   KLMMMMMMMMMMMMMMMMMMMMMMMMM
   MMMMMMM         MMMMMMMMML       MMMMMMMK     LMMMMMMMMMMMMMMMMMMMMMML  LMMMMMMMMMMMMMMMMMMMMMMMMMMM
   MMMMMMM      MMMMMMMMMML         MMMMMMMK   LMMMMMMMMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMMMMMM
   MMMMMMM    LMMMMMMMMML           MMMMMMMK  LMMMMMMMMMLLMLLLLLLLLLLLLLL LMMMMMMMLLLLLLLLLLLLLLLLLLLLM
   MMMMMMM  MMMMMMMMMLM             MMMMMMMK LMMMMMMMM                    LMMMMMML
   MMMMMMMLMMMMMMMML                MMMMMMMK MMMMMMML                     LMMMMMMMMLLLLLLLLLLLLLMLL
   MMMMMMMMMMMMMMMM                 MMMMMMMK MMMMMML                       LMMMMMMMMMMMMMMMMMMMMMMMMML
   MMMMMMMMMMMMMMMMMM               MMMMMMMK MMMMMMM                         LMMMMMMMMMMMMMMMMMMMMMMMML
   MMMMMMM KLMMMMMMMMML             MMMMMMMK LMMMMMMM                                          MMMMMMMML
   MMMMMMM    LMMMMMMMMMM           MMMMMMMK LMMMMMMMMLL                                        MMMMMMML
   MMMMMMM      LMMMMMMMMMLL        MMMMMMMK  LMMMMMMMMMMMMMMMMMMMMMMMMML LLLLLLLLLLLLLLLLLLLLMMMMMMMMMM
   MMMMMMM        MMMMMMMMMMML      MMMMMMMK   MMMMMMMMMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMMMMMM
   MMMMMMM          LLMMMMMMMMML    MMMMMMMK     LLMMMMMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMMMML
   MMMMMMM             MMMMMMMMMML  MMMMMMMK         KLMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMLK

Scanning with Keeping Infrastructure as Code Secure v2.1.2

Security Group Rule Without Description, Severity: INFO, Results: 2
Description: It's considered a best practice for all rules in AWS Security Group to have a description
Platform: Terraform
Learn more about this vulnerability: https://docs.kics.io/latest/queries/terraform-queries/aws/68eb4bf3-f9bf-463d-b5cf-e029bb446d2e

        [1]: ../../path/KICS_test.tf:21

                020:
                021:   ingress {
                022:     from_port   = 0

        [2]: ../../path/KICS_test.tf:28

                027:
                028:   egress {
                029:     from_port   = 0

Resource Not Using Tags, Severity: INFO, Results: 3
Description: AWS services resource tags are an essential part of managing components. As a best practice, the field 'tags' should have additional tags defined other than 'Name'
Platform: Terraform
Learn more about this vulnerability: https://docs.kics.io/latest/queries/terraform-queries/aws/e38a8e0a-b88b-4902-b3fe-b0fcb17d5c10

        [1]: ../../path/KICS_test.tf:5

                004:
                005: resource "aws_instance" "example" {
                006:   ami           = "ami-0c55b159cbfafe1f0"

        [2]: ../../path/KICS_test.tf:36

                035:
                036: resource "aws_s3_bucket" "example" {
                037:   bucket = "example-bucket"

        [3]: ../../path/KICS_test.tf:17

                016:
                017: resource "aws_security_group" "example" {
                018:   name        = "example"

... (omitted) ...

S3 Bucket ACL Allows Read Or Write to All Users, Severity: CRITICAL, Results: 1
Description: S3 Buckets should not be readable and writable to all users
Platform: Terraform
Learn more about this vulnerability: https://docs.kics.io/latest/queries/terraform-queries/aws/38c5ee0d-7f22-4260-ab72-5073048df100

        [1]: ../../path/KICS_test.tf:39

                038:
                039:   acl    = "public-read"
                040: }

Results Summary:
CRITICAL: 1
HIGH: 66
MEDIUM: 7
LOW: 1
INFO: 6
TOTAL: 81

Preparing Scan Assets: DoneExecuting queries: [----->___________________________________________________________________] 7.91%Executing queries: [------>________________________________________________________________] 10.09%Executing queries: [--------->_____________________________________________________________] 12.77%Executing queries: [---------->_____________________________________________________________] 15.09%Executing queries: [----------->___________________________________________________________] 17.78%Executing queries: [-------------->________________________________________________________] 20.46%Executing queries: [---------------->_______________________________________________________] 22.86%Executing queries: [----------------->_____________________________________________________] 25.11%Executing queries: [-------------------->__________________________________________________] 27.79%Executing queries: [--------------------->__________________________________________________] 30.12%Executing queries: [---------------------->________________________________________________] 32.66%Executing queries: [------------------------>______________________________________________] 34.69%Executing queries: [-------------------------->_____________________________________________] 37.08%Executing queries: [--------------------------->___________________________________________] 39.62%Executing queries: [----------------------------->_________________________________________] 41.65%Executing queries: [------------------------------->________________________________________] 44.05%Executing queries: [-------------------------------->______________________________________] 46.73%Executing queries: [----------------------------------->___________________________________] 49.13%Executing queries: [------------------------------------->__________________________________] 51.45%Executing queries: [------------------------------------->_________________________________] 53.85%Executing queries: [---------------------------------------->______________________________] 56.24%Executing queries: [------------------------------------------>_____________________________] 59.14%Executing queries: [------------------------------------------->___________________________] 61.76%Executing queries: [---------------------------------------------->________________________] 64.37%Executing queries: [------------------------------------------------>_______________________] 67.20%Executing queries: [------------------------------------------------->_____________________] 69.59%Executing queries: [---------------------------------------------------->__________________] 72.28%Executing queries: [----------------------------------------------------->__________________] 74.89%Executing queries: [------------------------------------------------------>________________] 77.43%Executing queries: [--------------------------------------------------------->______________ 79.61%Executing queries: [----------------------------------------------------------->____________] 82.00%Executing queries: [------------------------------------------------------------>__________] 84.91%Executing queries: [-------------------------------------------------------------->_________] 7.30%Executing queries: [---------------------------------------------------------------->_______] 89.84%Executing queries: [----------------------------------------------------------------->_____] 92.09%Executing queries: [------------------------------------------------------------------->____] 9405%Executing queries: [--------------------------------------------------------------------->__] 95.86%Executing queries: [--------------------------------------------------------------------->_] 97.46%Executing queries: [----------------------------------------------------------------------->] 99.5

KICS VS Code Extension Output
[INFO - 11:19:33 AM] Checkmarx plugin is running
[INFO - 11:19:33 AM] Initializing severity filters
[INFO - 11:19:33 AM] Initializing group by selections
[INFO - 11:19:33 AM] Data refreshed and synced with Checkmarx One platform
[INFO - 11:19:33 AM] Git Extension - Add branch.
[INFO - 11:19:33 AM] Initializing state filters
[INFO - 11:19:33 AM] Group by initialized
[INFO - 11:19:33 AM] Filters initialized
[INFO - 11:39:49 AM] File saved updating KICS results
[INFO - 11:39:49 AM] Opened a supported file by KICS. Starting KICS scan
[ERROR - 11:39:59 AM] Error: Check container engine state. Failed: exit status 60

[INFO - 11:59:27 AM] File saved updating KICS results
[INFO - 11:59:27 AM] Opened a supported file by KICS. Starting KICS scan
[ERROR - 11:59:37 AM] Error: Check container engine state. Failed: exit status 60

Thank you for opening the issue. Issue created in our Jira board -https://checkmarx.atlassian.net/browse/AST-65027

Hi,
I attempted to run the scan using an environment similar to yours, but with a different Docker version. The scan completed successfully. Please update your Docker version to the latest and try again.

Hi,
Thank you for your reply!
I updated Docker and ran the scan again, but I'm still encountering the same issue (KICS seems to execute correctly based on the Docker logs, but the extension only shows the error message without displaying the actual scan results).
Docker version: 27.3.1, build ce12230
Error message: [ERROR - 9:38:14 AM] Error: Check container engine state. Failed: exit status 60
Could you please let me know if there are any additional configurations needed or specific settings I should pay attention to? If you need any further information, please let me know.
Thank you!


bsim_ctl start fails on Fedora 40

Describe the bug
bsim_ctl start fails on Fedora 40. After some investigation I found that the issue arises from Fedora using a much newer OpenSSL version (3.2.2) compared to Ubuntu 22.04 (3.0.2). This newer version does not work well with PostgreSQL 15.3.
To Reproduce
Steps to reproduce the behavior:

Install Fedora (or any other distro with newer packages)
Install Ghidra 11.2 from the releases or build master branch from source, then:

$ cd Ghidra/Features/BSim
$ ./make-postgres.sh
$ cd ../../../
$ ./support/bsim_ctl start ~/git-repos/bsim-db/
openjdk version "21.0.4" 2024-07-16 LTS
OpenJDK Runtime Environment Temurin-21.0.4+7 (build 21.0.4+7-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.4+7 (build 21.0.4+7-LTS, mixed mode)
Server started
SSL error: Remote host terminated the handshake
Server shutdown complete

There is no useful information in the log file generated by pg_ctl.
Expected behavior
$ ./support/bsim_ctl start ~/git-repos/bsim-db/
openjdk version "21.0.4" 2024-07-16 LTS
OpenJDK Runtime Environment Temurin-21.0.4+7 (build 21.0.4+7-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.4+7 (build 21.0.4+7-LTS, mixed mode)
Server started
BSim extension enabled

I have installed OpenSSL 3.0.2 from source (to /usr/local/ssl) and it fixed the problem:
$ LD_PRELOAD=/usr/local/ssl/lib64/libssl.so:/usr/local/ssl/lib64/libcrypto.so ./support/bsim_ctl start ~/git-repos/bsim-db/
openjdk version "21.0.4" 2024-07-16 LTS
OpenJDK Runtime Environment Temurin-21.0.4+7 (build 21.0.4+7-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.4+7 (build 21.0.4+7-LTS, mixed mode)
Server started
BSim extension enabled

Screenshots
N/A
Attachments
N/A
Environment (please complete the following information):

OS: Linux fedora 6.10.12-200.fc40.x86_64
Java Version: openjdk 21.0.4 2024-07-16 LTS
Ghidra Version: 11.3_DEV
Ghidra Origin: locally built from the GitHub repo without any changes (commit 64b70d8e)

Additional context
N/A

This issue relates to #6115

We will be updating to postgresql 15.10 which works with openssl 3.2.2


Update copy to remove reference to line data

Overview
We don't support this quite yet, so this copy is incorrect
Closes #1010

Trivial, merging now that CI has passed.


Resizing element through Javascript

What is the best way to resize an element (like a div) through Javascript and have the GSS engine take the new width/height into account? Doing something like $('elementToResize).width(400) with jQuery does not work. If this is not currently possible, will it be in the future?

Can this be added to the documentation?
In fact, I think it would be good if there was an entire section devoted to how Cassowary deals with live changes to the DOM. I was quite surprised to find that Cassowary is able to detect DOM insertion/deletion. If there are caveats (such as having to use intrinsic-*) for DOM insertion/deletion, then I'd like to know about those as well.

It is in documentation. There's now a computed- property family too.
Yes, GSS observes DOM mutations and it will act on style changes too. The caviat is the fact that newly applied rules will have more power than the ones that were applied before the mutation. Sometimes that matters.


1.18.2 Update

is a 1.18.2 update planned?

i'm pretty sure the current version already works for 1.18.2 and i have now added that to curseforge and modrinth!


Missing Extra Point / 2pt Conv Plays After Defensive Touchdowns

I'm not sure whether this is due to the code or the NFL feed itself, but I have yet to find a game containing an extra point or 2-point conversion play after a defensive TOUCHDOWN (ie. a pick six).  The next play returned seems to always be a kick off in such cases.
I found this to be true for both interceptions and fumble recoveries resulting in an immediate touchdown.
At first I thought that maybe the assumption is a made XP unless otherwise noted, but then I found an example of a defensive TD, followed by a 2-pt conversion (week 13 in 2012 - SF vs. STL) that also went unreported by nflgame.
This obviously makes it impossible to keep track of the score of the game with 100% accuracy.

Yeah.  Unfortunately, the blame goes entirely to the source data from nfl.com
From nfl.com play-by-plays:
Week 17 2014 - Carolina @ Atlanta
2-20-ATL 9
(4:32) (Shotgun) 2-M.Ryan pass deep right intended for 84-R.White INTERCEPTED by 41-R.Harper [95-C.Johnson] at ATL 31. 41-R.Harper for 31 yards, TOUCHDOWN.
Atlanta Falcons at 04:18
9-G.Gano kicks 71 yards from CAR 35 to ATL -6. 17-D.Hester to ATL 23 for 29 yards (33-T.Boston). PENALTY on ATL-53-P.Shembo, Offensive Holding, 6 yards, enforced at ATL 12.

Week 12 2012 - San Francisco @ St. Louis
3-3-SF 17
(3:11) (Shotgun) 7-C.Kaepernick FUMBLES (Aborted) at SF 12, RECOVERED by STL-21-J.Jenkins at SF 2. 21-J.Jenkins for 2 yards, TOUCHDOWN. The Replay Assistant challenged the backward pass ruling, and the play was Upheld.
San Francisco 49ers at 03:04
4-G.Zuerlein kicks 73 yards from STL 35 to SF -8. 19-T.Ginn, Touchback.

This is the first I have noticed that it is always defensive touchdowns that are missing extra point play-by-play information.
FYI - nfldb does offer a score_at_time function that would deliver to you the score at any particular point in the game. (See https://github.com/BurntSushi/nfldb/issues/6)

Thanks for the lightening-quick reply.  I will have my code check for a
defensive touchdown and then use the score_at_time function to update the
score if need be.
On Wed, Jan 28, 2015 at 11:04 AM, ochawkeye<EMAIL_ADDRESS>wrote:

Yeah. Unfortunately, the blame goes entirely to the source data from
nfl.com
From nfl.com play-by-plays:
Week 17 2014 - Carolina @ Atlanta
2-20-ATL 9
(4:32) (Shotgun) 2-M.Ryan pass deep right intended for 84-R.White INTERCEPTED by 41-R.Harper [95-C.Johnson] at ATL 31. 41-R.Harper for 31 yards, TOUCHDOWN.
Atlanta Falcons at 04:18
9-G.Gano kicks 71 yards from CAR 35 to ATL -6. 17-D.Hester to ATL 23 for 29 yards (33-T.Boston). PENALTY on ATL-53-P.Shembo, Offensive Holding, 6 yards, enforced at ATL 12.
Week 12 2012 - San Francisco @ St. Louis
3-3-SF 17
(3:11) (Shotgun) 7-C.Kaepernick FUMBLES (Aborted) at SF 12, RECOVERED by STL-21-J.Jenkins at SF 2. 21-J.Jenkins for 2 yards, TOUCHDOWN. The Replay Assistant challenged the backward pass ruling, and the play was Upheld.
San Francisco 49ers at 03:04
4-G.Zuerlein kicks 73 yards from STL 35 to SF -8. 19-T.Ginn, Touchback.
This is the first I have noticed that it is always defensive touchdowns
that are missing extra point play-by-play information.
FYI - nfldb does offer a score_at_time function that would deliver to you
the score at any particular point in the game. (See BurntSushi/nfldb#6
https://github.com/BurntSushi/nfldb/issues/6)
--
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-71860563.

There are a number of nflgame-specific methods to arrive at the score as well.
Game score_home and score_away might be of use.
During completed games those are aware of the actual score despite play-by-play not being able to arrive at those totals.  While games are being played this holds true as well.
    games = nflgame.games(2014, 17)
    for game in games:
            print game.nice_score()
            print game.home, game.score_home, game.away, game.score_away

CAR (34) at ATL (3)
ATL 3 CAR 34
CLE (10) at BAL (20)
BAL 20 CLE 10
DET (20) at GB (30)
GB 30 DET 20
JAC (17) at HOU (23)
HOU 23 JAC 17
SD (7) at KC (19)
KC 19 SD 7
NYJ (37) at MIA (24)
MIA 24 NYJ 37
CHI (9) at MIN (13)
MIN 13 CHI 9
BUF (17) at NE (9)
NE 9 BUF 17
PHI (34) at NYG (26)
NYG 26 PHI 34
CIN (17) at PIT (27)
PIT 27 CIN 17
NO (23) at TB (20)
TB 20 NO 23
IND (27) at TEN (10)
TEN 10 IND 27
DAL (44) at WAS (17)
WAS 17 DAL 44
OAK (14) at DEN (47)
DEN 47 OAK 14
ARI (17) at SF (20)
SF 20 ARI 17
STL (6) at SEA (20)
SEA 20 STL 6

That sounds great; I'll give it a whirl tonight.
Thanks again!
--John

One more quick question...would you say I'm safe polling for new plays
every 10 seconds today?  I figure it's enough to be under the radar, but
obviously you know best.
On Wed, Jan 28, 2015 at 1:32 PM, ochawkeye<EMAIL_ADDRESS>wrote:

There are a number of nflgame-specific methods to arrive at the score as
well.
Game score_home and score_away might be of use.
During completed games those are aware of the actual score despite
play-by-play not being able to arrive at those totals. While games are
being played this holds true as well.
games = nflgame.games(2014, 17)
for game in games:
        print game.nice_score()
        print game.home, game.score_home, game.away, game.score_away

CAR (34) at ATL (3)
ATL 3 CAR 34
CLE (10) at BAL (20)
BAL 20 CLE 10
DET (20) at GB (30)
GB 30 DET 20
JAC (17) at HOU (23)
HOU 23 JAC 17
SD (7) at KC (19)
KC 19 SD 7
NYJ (37) at MIA (24)
MIA 24 NYJ 37
CHI (9) at MIN (13)
MIN 13 CHI 9
BUF (17) at NE (9)
NE 9 BUF 17
PHI (34) at NYG (26)
NYG 26 PHI 34
CIN (17) at PIT (27)
PIT 27 CIN 17
NO (23) at TB (20)
TB 20 NO 23
IND (27) at TEN (10)
TEN 10 IND 27
DAL (44) at WAS (17)
WAS 17 DAL 44
OAK (14) at DEN (47)
DEN 47 OAK 14
ARI (17) at SF (20)
SF 20 ARI 17
STL (6) at SEA (20)
SEA 20 STL 6
--
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-71888736.

The Game Center page on NFL.com is only updated evey 15 seconds (according to live.py) so anything more often than that won't buy to much.

Gotcha...enjoy the game!  Thanks again.
On Sun, Feb 1, 2015 at 9:48 AM, ochawkeye<EMAIL_ADDRESS>wrote:

The Game Center page on NFL.com is only updated evey 15 seconds (according
to live.py
https://github.com/BurntSushi/nflgame/blob/master/nflgame/live.py#L192)
so anything more often than that won't buy to much.
--
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-72367495.

Today's game is week 5 in nflgame.  Is that correct?  The past few years'
games were week 4's.  Sorry to be a pain, but I want to make sure I am
reading the correct feed.  lol
On Wed, Jan 28, 2015 at 1:32 PM, ochawkeye<EMAIL_ADDRESS>wrote:

There are a number of nflgame-specific methods to arrive at the score as
well.
Game score_home and score_away might be of use.
During completed games those are aware of the actual score despite
play-by-play not being able to arrive at those totals. While games are
being played this holds true as well.
games = nflgame.games(2014, 17)
for game in games:
        print game.nice_score()
        print game.home, game.score_home, game.away, game.score_away

CAR (34) at ATL (3)
ATL 3 CAR 34
CLE (10) at BAL (20)
BAL 20 CLE 10
DET (20) at GB (30)
GB 30 DET 20
JAC (17) at HOU (23)
HOU 23 JAC 17
SD (7) at KC (19)
KC 19 SD 7
NYJ (37) at MIA (24)
MIA 24 NYJ 37
CHI (9) at MIN (13)
MIN 13 CHI 9
BUF (17) at NE (9)
NE 9 BUF 17
PHI (34) at NYG (26)
NYG 26 PHI 34
CIN (17) at PIT (27)
PIT 27 CIN 17
NO (23) at TB (20)
TB 20 NO 23
IND (27) at TEN (10)
TEN 10 IND 27
DAL (44) at WAS (17)
WAS 17 DAL 44
OAK (14) at DEN (47)
DEN 47 OAK 14
ARI (17) at SF (20)
SF 20 ARI 17
STL (6) at SEA (20)
SEA 20 STL 6
--
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-71888736.

That is a fine question.  According to nflgame.live.current_year_and_week() it is indeed (2014, 5) and you are correct that in years past the Super Bowl was week 4 despite a Pro Bowl sneaking in there between the Conference Championship & Super Bowl.  It's possible @BurntSushi made an adjustment to move those previous Super Bowls into week 4?

Week 5 does indeed appear to be the week.  Not sure if that is the intent, but I can't imagine much downside other than having some difficulty in comparing Super Bowls from season to season.
import nflgame
print [str(g) for g in nflgame.games(2014, 5, kind='POST')]

['NE (0) at SEA (0)']

Sounds good.  I just wanted to confirm that's all
On Feb 1, 2015 4:59 PM, "ochawkeye"<EMAIL_ADDRESS>wrote:

Week 5 does indeed appear to be the week. Not sure if that is the intent,
but I can't imagine much downside other than having some difficulty in
comparing Super Bowls from season to season.
import nflgameprint [str(g) for g in nflgame.games(2014, 5, kind='POST')]
['NE (0) at SEA (0)']
--
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-72386764.

Just in case you were curious, here's a link to what I was working on:
http://pandora.dyndns.biz/boxes
I had a lot of free time the past two weeks.  :)
PS - Please excuse any horrendous code you may come across; I really hacked
it together.  lol
On Sun, Feb 1, 2015 at 5:00 PM, John A Gruska<EMAIL_ADDRESS>wrote:

Sounds good.  I just wanted to confirm that's all
On Feb 1, 2015 4:59 PM, "ochawkeye"<EMAIL_ADDRESS>wrote:

Week 5 does indeed appear to be the week. Not sure if that is the intent,
but I can't imagine much downside other than having some difficulty in
comparing Super Bowls from season to season.
import nflgameprint [str(g) for g in nflgame.games(2014, 5, kind='POST')]
['NE (0) at SEA (0)']
--
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-72386764.

@krusta80 That's awesome! I've added it to the wiki. :-) https://github.com/BurntSushi/nflgame/wiki/How-do-people-use-nflgame%3F

Hey there!  Just wondering if/when to expect the list of this season's
games to be available?  :)
On Mon, Feb 2, 2015 at 8:39 PM, Andrew Gallant<EMAIL_ADDRESS>wrote:

@krusta80 https://github.com/krusta80 That's awesome! I've added it to
the wiki. :-)
https://github.com/BurntSushi/nflgame/wiki/How-do-people-use-nflgame%3F
—
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-72576119.

@krusta80 It's been available for quite some time. Make sure you're running the latest nflgame. i.e., pip install --upgrade nflgame.

That did it!  Sorry, this is my first second season with nflgame.  ;)
On Tue, Aug 25, 2015 at 6:35 AM, Andrew Gallant<EMAIL_ADDRESS>wrote:

@krusta80 https://github.com/krusta80 It's been available for quite
some time. Make sure you're running the latest nflgame. i.e., pip install
--upgrade nflgame.
—
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-134549818.

I suppose that was redundant...first non-first season.  Wow, I need some
coffee stat.
Thanks again!
On Tue, Aug 25, 2015 at 9:39 AM, John A Gruska<EMAIL_ADDRESS>wrote:

That did it!  Sorry, this is my first second season with nflgame.  ;)
On Tue, Aug 25, 2015 at 6:35 AM, Andrew Gallant<EMAIL_ADDRESS>wrote:

@krusta80 https://github.com/krusta80 It's been available for quite
some time. Make sure you're running the latest nflgame. i.e., pip
install --upgrade nflgame.
—
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nflgame/issues/112#issuecomment-134549818
.

:-)


[Bug]:  Intl.supportedValuesOf is not a function on Coveo 2.63.5 - Safari 15.3

Which product are you using?
Headless
product version
2.63.5
bug description
On Safari 15.3 - Coveo is giving error and not rendering our components. Here's the error from browser console,
TypeError: Intl.supportedValuesOf is not a function. (In 'Intl.supportedValuesOf("currency")', 'Intl.supportedValuesOf' is undefined)
Screenshot:

Our only option is to add a polyfil but can this be fixed in Coveo headless library itself.
Steps to reproduce
On Safari 15.3 - check for error message.
Relevant log output
No response

Possibly this PR contains Intl.supportedValuesOf which is failing on Safari 15.3
https://github.com/coveo/ui-kit/pull/3667/files

Hi, we guarantee support only on the latest and active versions of browsers. Safari 15.3 does not qualify.
You will need to polyfill the Intl.supportedValuesOf.
See https://github.com/formatjs/formatjs/tree/main/packages/intl-enumerator
For potential polyfill


Fixed user review page #73

https://github.com/user-attachments/assets/413a71bc-2ea9-4302-abfd-bac4f14c6434
Scroll on top button arrow

@PriyaGhosal Thank you for assigning me these 3 tasks. Plz add gssoc-ext, hacktoberfest-accepted, and level labels here too just for safety 😅

@devarsheecodess Your pull request has been successfully merged! Don't stop here -continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile! Great contribution to GSSOC'24 EXTENDED!


Cargo test failed in "test player::in_room::tests::player_in_room"

After running cargo test inside of the project, I have received the following message
running 23 tests
test config::tests::read_and_write ... ok
test config::tests::update_task_default_file ... ok
test config::tests::valid_default ... ok
test config::tests::update_task_no_file ... ok
test config::tests::update_task_modified_file ... ok
test connection::tests::check_shutdown ... ok
test connection::tests::accept_plain ... ok
test config::tests::read_err ... ok
test connection::tests::accept_tls ... ok
test room::tests::test_client_close ... ok
test room::tests::test_client_drop ... ok
test room::tests::test_host_error ... ok
test room::tests::test_senario ... ok
test room::tests::test_shutdown ... ok
test room::tests::test_time_limit ... ok
test room::tests::test_time_limit_change ... ok
test room_code::tests::check_conversion ... ok
test room_code::tests::check_default ... ok
test room_code::tests::check_profanity ... ok
test player::tests::send_close ... ok
test player::joining::tests::player_joining ... ok
test player::in_room::tests::player_in_room ... FAILED
test room_code::tests::check_random ... ok

failures:

---- player::in_room::tests::player_in_room stdout ----
thread 'player::in_room::tests::player_in_room' panicked at src/player/in_room.rs:765:39:
server function failed: SendError(PlayerJoined(9))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'player::in_room::tests::player_in_room' panicked at src/player/in_room.rs:783:9:
error receiving message from server: Io(Os { code: 32, kind: BrokenPipe, message: "Broken pipe" })

failures:
    player::in_room::tests::player_in_room

test result: FAILED. 22 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 18.09s

error: test failed, to rerun pass `--lib`

It seems that there is something wrong with the test "test player::in_room::tests::player_in_room" I am not sure if this is something that I did wrong, but I would love to know your opinion.

Ok for some reason it just worked now after resetting

Yeah, there's a note about this in the README - I'm still not exactly sure what causes it (I'm guessing its a UNIX pipe being accessed from separate threads at the same time), but it only happens rarely.


type 'ZSAT_ADT_OBJECT_INFO' does not exist

Hi! I tried several branches, but still see the same error:
Transformation ZSAT_OBJECT_INFOS
dictionary type 'ZSAT_ADT_OBJECT_INFO' does not exist

Can you please add this object to the repository?

Hi @ukysys,
sorry for that. Somehow I missed to delete this transformation during a clean-up commit.
Now you should be able to pull it without any issues.
Best regards,
Ludwig


Update FAQ-journey.md

Updated information about 3PIP phones since these will be supported after 2023.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

Reached out to PM.

Hi @lcansby - thanks for your input.  We have updated that section with support info for 3PIP and SIP phones, and so am closing out your PR.


Listen for GitHub webhooks and update opportunities

This closes #1
RFC @burden / @ponty96 / @ybur-yug

I need to finish a test for this and it should be good to go.


Added missing semi-colons to pass JSLint

Added missing semi-colons to pass JSLint

This project uses https://github.com/feross/standard

This module uses standard style

I've added standard to the devDependencies to make it more clear.

Ah that explains it. TY!


[stable/fluentd-elasticsearch] unable to specify service type per port, specify nodePort and protocol

Is this a request for help?: Yes

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Which chart: stable/fluentd-elasticsearch
What happened: Trying to specify a ClusterIP for prometheus and a NodePort for syslog aggregation, encountered following problems:

While able to use service.type = NodePort, cannot specify the nodePort to use for each port.
Unwanted random nodePort will be consumed for in-cluster services.
Cannot specify protocol so unable to use UDP rsyslog. (k8s service defaults to TCP)

Anything else we need to know:
I have to use NodePort as the syslog clients are not in the k8s network, and I don't have loadbalancers.
While it's easy to change the template to fix my problems, I don't think the current values.yaml file can allow service type per port without a breaking change (or without confusing users).
I'm also not sure rsyslogd-aggregation using this chart is a good idea, advice of alternatives is also appreciated.

After reading the k8s service API (again) I found that service type per port have to be achieved by multiple service objects thus making it rather hard to achieve. I'll try add Nodeport and Protocol support.


OSL updates

Minor unregistering addon fix

Fixes in.

Not sure if the stuff I added will work.  I found it online but I don't quite understand how it works

Thanks, let's try with that and refine as necessary!


[BUG] YOLOP Lane Detection Image Scaling Issue

Describe the bug
When running the out of box VSI-DEMO MWAA Dag on the public Rosbag files from the blog post (s3://aws-autonomous-driving-datasets/test-vehicle-01/072021/small1__2020-11-19-16-21-22_4.bag) the SageMaker Processing job for Lane Detection fails with errors around img size (scaling). It seems to always be off by specific factor 0.8 (600->480), (1200->960)
To Reproduce

Deploy the ros-image-demo manifest
Copy the public bag file above into your account into the addf raw bucket (you need to copy it twice since the batch job needs min of 2 files (another bug)
Run the VSI sample data DAG with config similar to:

{
    "drives_to_process": {
        "test-vehicle-01": {
            "bucket": "<addf-raw-bucket>",
            "prefix": "test-vehicle-01/072021/"
        },
        "test-vehicle-02": {
            "bucket": "<addf-raw-bucket>",
            "prefix": "test-vehicle-02/072021/"
        }
    }
}

Check pipeline. Last step fails, sagemaker processing job with logs below

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
/opt/conda/lib/python3.8/site-packages/torchvision/io/image.py:11: UserWarning: Failed to load image Python extension:
  warn(f"Failed to load image Python extension: {e}")

Using torch 1.10.2+cpu CPU
['/YOLOP/tools', '/opt/conda/lib/python38.zip', '/opt/conda/lib/python3.8', '/opt/conda/lib/python3.8/lib-dynload', '/opt/conda/lib/python3.8/site-packages', '/YOLOP']
=> creating runs/BddDataset/_2022-11-18-15-44
#015  0%|          | 0/202 [00:00<?, ?it/s]/opt/conda/lib/python3.8/site-packages/torch/functional.py:445: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at  ../aten/src/ATen/native/TensorShape.cpp:2156.)
  return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
/opt/conda/lib/python3.8/site-packages/torch/nn/functional.py:3631: UserWarning: Default upsampling behavior when mode=bilinear is changed to align_corners=False since 0.4.0. Please specify align_corners=True if the old behavior is desired. See the documentation of nn.Upsample for details.
  warnings.warn(
#015  0%|          | 0/202 [00:00<?, ?it/s]
image 1/202 /opt/ml/processing/input/image/frame_0005407_1605824495_875984259.png:
Traceback (most recent call last):
  File "tools/detect_lanes.py", line 226, in <module>
    detect(cfg, opt)
  File "tools/detect_lanes.py", line 147, in detect
    img_det = show_seg_result(img_det, (da_seg_mask, ll_seg_mask), _, _, is_demo=True)
  File "/YOLOP/lib/utils/plot.py", line 57, in show_seg_result
    img[color_mask != 0] = img[color_mask != 0] * 0.5 + color_seg[color_mask != 0] * 0.5
    IndexError: boolean index did not match indexed array along dimension 0; dimension is 1200 but corresponding boolean dimension is 960

Please confirm that this PR corrected the issue:
https://github.com/awslabs/autonomous-driving-data-framework/pull/54
@a13zen @kevinsoucy

confirmed @dgraeber

can we close this bug? @dgraeber


run integration tests in parallel

Codecov Report

Merging #219 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #219   +/-   ##
========================================
  Coverage    58.61%   58.61%
========================================
  Files           50       50
  Lines         1590     1590
  Branches       176      176
========================================
  Hits           932      932
  Misses         596      596
  Partials        62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256e94b...3abcc87. Read the comment docs.


Way to fix issue with some users intermittently not seeing random streams?

Is there something that causes this or is it just a bad negotiation or is there a way to re-try the connection somehow if it detects it fails?
It's not throwing errors but sometimes the video just doesn't show up...
Anyone else experience issues like this?

You should get a connection_failed stream event if the ICE negotiation fails. This is the most common problem if there is anything wrong in the negotiation.
Otherwise you will get disconnected from a room if the web socket connection is lost.
There are a number of things that could cause this. A good way to have an idea, besides the logs is to check chrome://webrtc-internals/ and see if the ICE connection has completed, and if it is sending or receiving data.

Thanks!
If I have 3 chrome instances running at once.
I refresh all 3.
Intermittently , 1 or 2 of them (when subscribing) will console.log a "send message"
like this screenshot:

and on the server if I'm monitoring the basic logs...
So I get 3 "ErizoController - Sending message to..." which tells me it's getting all 3 messages.
And only two "Adding subscriber / subscriber added / initializing subscriber"
2015-08-31 10:02:37.408  - INFO: RoomController - Erizo got
2015-08-31 10:02:37.750  - INFO: ErizoController - Sending message to ia9s_XUpnAot4-kUAAAD in room  55e45a4e2634e4290256e791
2015-08-31 10:02:37.750  - INFO: ErizoController - Sending message to MAyuXx2tqn9lShvsAAAE in room  55e45a4e2634e4290256e791
2015-08-31 10:02:37.750  - INFO: ErizoController - Sending message to TYhxXdZ_8t-X-j_OAAAF in room  55e45a4e2634e4290256e791
2015-08-31 10:02:37.800  - INFO: RoomController - Adding subscriber  MAyuXx2tqn9lShvsAAAE  to publisher<PHONE_NUMBER>94390900
2015-08-31 10:02:37.801  - INFO: ErizoController - Subscriber added
2015-08-31 10:02:37.802  - INFO: RoomController - Adding subscriber  ia9s_XUpnAot4-kUAAAD  to publisher<PHONE_NUMBER>94390900
2015-08-31 10:02:37.803  - INFO: ErizoController - Subscriber added
2015-08-31 10:02:37.805  - INFO: ErizoController - Initializing subscriber
2015-08-31 10:02:37.807  - INFO: ErizoController - Initializing subscriber

Guessing next place I need to debug is within ErizoController and the webrtc-internals like you said.

Just looked at chrome://webrtc-internals
out of the 2 browsers that refreshed...
both should be individual users since they are on their own user directory and everything.
one of them went all the way successfully.
The other one stops at createOfferOnSuccess
Both of the browsers createOfferOnSuccess look fairly identical.
Going to compare them a bit closer I suppose.

Diff of the two looks nominal and doesn't look like anything should have happened differently.

Nevermind, it only ever shows 2 subscribers since one of them is a publisher.
But I still do have the intermittent issue... it's really putting a wrench in things. :-/

Could it be a race condition?
If 5 sessions simultaneously connect and the publisher publishes and the stream subscribes....
Is it possible that some of the subscribers may not subscribe due to too much happening simultaneously?

For instance, is there something in erizo that is checking if all subscribers have subscribed to all publishing streams? Even after it thinks it has them all?  A redundancy check possibly?

Okay so for some reason... at seemingly completely random times... the client will create and offer, send it via socket-io and socket-io server will not respond back.
I think that's the basis of the issue.
Wish I knew more about licode to know where to check in logs to see if I can diagnose it further.
Any tips on where to look?

Do only subscriptions fail? Is there any instance where the publication also fails for unknown reasons (discarding ICE connectivity fails)
If you suspect the speed at which you are trying to subscribe to the streams is an issue, you can try to artificially delay the subscription to see if the situation improves and then work from there.
Basically what you have there is - erizoClient will send a subscribe request to ErizoController, ErizoController via its RoomController will look at his erizoJS table to know where is the required stream published. Then via amqp, the message will be sent to that erizoJS where it will be processed and a response sdp will be generated and it will travel all the way back. At the same time, new ICE candidates will be exchanged via the same channel.
You can look at the logs in the erizoAgent directory (each .log file is for one erizoJS process, you may want to restrict the number of processes to 1 for easier debugging). There, you can make sure that the MCU core is receiving the SDP Offer. You should see something like this:
2015-09-01 13:16:12.452  - INFO: ErizoJSController - Process Signaling message:
With the SDP message from the client printed after that.

Thank you for taking the time to help me.
It seems to happen when simultaneous subscribers try to pickup a new publisher.
And if that happens to fall in at the same time as a publisher is trying to subscribe to his own stream, it could affect that one too... but it's less likely to happen to publishing streams but it may not be.  It's actually very hard to test because it happens so sporadically within different browser windows.  All currently Chrome Stable I might add but since I feel like this is a server issue I don't know if browser version matters.
Could it help by starting more erizoJS processes from initialization?  So it doesn't have to start / stop them on the fly?  Or would that not help?  The server it's running on is 2GB / 2 CPU.
Only 6 simultaneous browser windows are causing it... I'm sure it will only get worse.
I reproduce it by having 6 browsers loaded at once.  They are all viewing both streams. (of 2 of them publishing but also seeing themselves)
I then refresh the browser window of one of the publishers.
I can watch each browser resolve the publisher as the logs fly by I can see  each new video pop up on each screen.  It's not very fast for 6 people.... wish I could improve that performance but I'm more concerned about it appearing at all at this point more than I am speed.
But randomly about every 2-3 refreshes of the publisher, one of the subscribers and sometimes the remote stream of the other user on the publishers screen doesn't resolve upon refresh.
It's usually just 1 of the browsers that has the issue, but it happens ENOUGH for it to be a deal breaker and ruin the service.
Never the less, also I should probably add that I did update the socket-io version since my existing web-app already was using socket-io newer version with namespaces and stuff so I had to attempt updating it and for the most part everything was working... this is the last issue.  I'm wondering if that's the problem?  I hope not, would throw a huge wrench in my web app if so.
Again, thank you for taking the time to help me - I will continue debugging with your instructions and if you have any other input or things to try please feel free to share.  I'll report back my findings.
The service I'm working on may have trouble scaling on Licode... some Celebrities with millions of followers could be linking our service soon which could easily buckle and need to scale drastically.
We may have to limit the amount of users that can hit the page at once.
:-/  Oh well, guess we will deal with that when we get there.

So far I haven't been able to reproduce this.
Can you quickly check the delay from the computers you are running the clients to the server?
Are you running Licode in Amazon or another Cloud service?
How many erizoJS processes do you have in the config file?
I'll try to reproduce the conditions to see if I can pinpoint where it is.
Ideally, the socket.io version should not affect the behaviour but it's good to keep it in mind.

If one of the publishers experiences a JS error, would that cause a peer to not be able to receive an answer from the MCU?
I changed the client line to this:
that.close = function () {
     that.state = 'closed';
     if (that.peerConnection.iceConnectionState === 'closed') {
       console.warn("[CLIENT] peerConnection signaling state is already closed!")
     } else {
       console.warn("[CLIENT] peerConnection signaling state is not closed, closing now.")
       that.peerConnection.close();
     }
   }

Because I was noticing that it was saying RTCPeerConnection could not close because it's signaling state is already closed.
Thinking I must have been closing something too soon?
But if these errors happened on the publisher could that prevent the server from answering some of the subscribers?
It does seem to be more stable now though...?
:-/

On Sep 2, 2015, at 5:05 AM, Pedro Rodriguez<EMAIL_ADDRESS>wrote:
So far I haven't been able to reproduce this.
Can you quickly check the delay from the computers you are running the clients to the server?
Are you running Licode in Amazon or another Cloud service?
How many erizoJS processes do you have in the config file?
I'll try to reproduce the conditions to see if I can pinpoint where it is.
Ideally, the socket.io version should not affect the behaviour but it's good to keep it in mind.
—
Reply to this email directly or view it on GitHub https://github.com/ging/licode/issues/342#issuecomment-136985181.

Well this issue is presenting itself again...
Intermittently one of the users is not getting an answer back from Licode server...
It's silently failing as far as I can see... I don't know how to get to the bottom of this... :(

I can reproduce the issue very frequently on my user interface... but have no idea how to track down where the hiccup is...  would anyone on here be interested in consulting this issue with me over screen hero or anything?

I never did answer your questions before:
@lodoyun Running the server in DigitalOcean, not sure of the delay but it would appear to be roughly 100-200ms to negotiate and show the video completely.
Config says this:
// Max processes that ErizoAgent can run
config.erizoAgent.maxProcesses    = 1; // default value: 1
// Number of precesses that ErizoAgent runs when it starts. Always lower than or equals to maxProcesses.
config.erizoAgent.prerunProcesses = 1; // default value: 1

Could this be causing an issue:
//STUN server IP address and port to be used by the server.
//if '' is used, the address is discovered locally
config.erizo.stunserver = ''; // default value: ''
config.erizo.stunport = 0; // default value: 0

I'm experiencing same problem discussed here and I found that in RTP Stats the value of SSRC was 0 for inbound_rtp_video_1 and `inbound_rtp_audio_0'
will re-subscribing the stream when ssrc: 0 help to solve this issue?
a=rtpmap:120 VP8/90000
a=ssrc:4271848487 cname:o/i14u9pJrxRKAsu
a=ssrc:4271848487 msid:TlpZSJcbVF v0
a=ssrc:4271848487 mslabel:TlpZSJcbVF
a=ssrc:4271848487 label:TlpZSJcbVFv0
RTP Stats

inbound_rtp_audio_0

Local: 16:11:43 GMT+0530 (IST) inboundrtp SSRC: 0

inbound_rtp_video_1

Local: 16:11:43 GMT+0530 (IST) inboundrtp SSRC: 0

Hi anyone,
I've just got the same issue above, anyone has experience for it?


bug: CE-491 Adding in message queues to prevent duplicate complaints

Description
The following only occurs in the test environment.   It is likely a result of multiple webEOC containers running.
Steps to Reproduce:
Consume complaints from webEOC

Observed Behavior:
Some complaints have duplicate entries in the staging table

Both complaints have a status of ‘Error’ however the complaint was loaded into the system

Expected Behavior:
If a complaint was loaded into the system there should be a row with a status of ‘SUCCESS’

Multiple error rows for a complaint are okay, however it looks like the rows are being created at the same time, which is probably because the message is going to both webeoc containers.

Fixes CE-491
How Has This Been Tested?

[x] Created 2 WebEOC replicas, verified that there are no errors in the staging table

Checklist

[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

I am still seeing this error on this PR.   By looking at the staging table:

@barrfalk - Sorry no dice here, this doesn't look like it's resolved.   See Complaint 24-000195 in Openshift Database