Chapter 10.1 Issues.

Code box afterOne last task left for us: injecting the secret used by our HMACs into the application state. requires secrecy::Secret.
Code box after Let's change login once again to use it: requires secrecy::Secret.
Everything involving Hmac will not compile with hmac v0.11, which is the version explicitly used in this chapter. It will compile with v0.12 with no changes to the code. It appears that hmac is eventually removed, so I'm not gonna spend time troubleshooting this, but it took several hours of me thinking I did something wrong.
Code box after "One last task left for us: injecting the secret used by our HMACs into the application state:" is missing use secrecy::Secret.
Code box after the last one also needs use secrecy::Secret
Code box after "Let's create a wrapper type to sidestep the issue:" does not compile.         .app_data(Data::new(HmacSecret(hmac_secret.clone()))) should be             .app_data(Data::new(hmac_secret.clone())) and impl Application needs to be updated to:

impl Application {
/* */
pub async fn build /* */
let server = run(
/* */
HmacSecret(configuration.application.hmac_secret),
)?;

Code after "We can now define a verify method on QueryParams itself: "         mac.verify(&tag)?; should be mac.verify_slice(&tag)?;
After "We can avoid this issue entirely by making all fields in QueryParams required while QueryParams itself becomes optional:" query: web::Query<Option<QueryParams>> may not actually be allowed in actix-web. It compiles, but there is a runtime (which always displays on the page, which is the opposite of what we're going for) Query deserialize error: invalid type: map, expected option. I believe that error is from serde::Deserialize on QueryParams. Again, it looks like the final code doesn't use this so I'm moving on from troubleshooting it. There is a chance that it could never work because I'm fairly certain actix-web and serde don't allow options to be used like that.
All of the tests in "3.4.9. An Integration Test For Login Failures" have the wrong file path. The repository has everything under /tests/api/*.
Code under "Let's go for the latter - a user being redirected with some dodgy query parameters will see our login page, an acceptable scenario"  has a typo in the file path. It should read //! src/routes/login/get.rs
same typo in code under: "We can now define a verify method on QueryParams itself: it will return the error string if the message authentication code matches our expectations, an error otherwise."
I'm unable to get the last tests in "3.4.11. An Integration Test For Login Failures - Part 2" to pass because of the previously mentioned web::Query<Option<QueryParams>> issue.
Last code in "3.4.13. How To Delete A Cookie In actix-web" require use actix_web::cookie::Cookie.
Using the time crate is unnecessary and gives an error. using  Cookie::build("_flash", "").max_age(actix_web::cookie::time::Duration::ZERO).finish(), works
typo "after having been read - actix-web-flash-messages takes of it." should be "after having been read - actix-web-flash-messages takes care of it."
# base.yaml should be # configuration/base.yaml
In "4.4.1. Redis In Our Development Setup" scripts/init_redis.sh is never run. It will also need to be made executable.
Adding actix-sesion took a little finagling with versions. A cargo clean and a cargo update was able to sort me out eventually.
Typo:     .context("Failed to performed a query to retrieve a username.")?; should bit     .context("Failed to perform a query to retrieve a username.")?;.
Need to add use change_password in //! src/startup.rs use crate::routes::{change_password, change_password_form};
use actix_web::http::header::LOCATION; not required in //! src/routes/admin/password/post.rs or //! src/routes/admin/password/get.rs
use actix_web::http::header::LOCATION; missing in src/utils
box after "The test fails because the request handler panics. Let's fix it:" missing use::secrecy::ExposeSecret
The boxes surrounding "That takes care of the redirect, the first part of the test, but it does not handle the error message:" are slightly misleading. The code cannot compile as-is in order to get the resulting test to pass. return see_other("/admin/dashboard"); needs to be wrapped with Ok().
"logged out by mistake due to browser optimisations like link prefetching." isn't exactly accurate. Prefetching only currently happens with <link> tags and not <a> tags.
In "5.2.5. Logout" one code change is unnecessary, it's already the state it's in.

//! src/routes/login/post.rs
// [...]
pub async fn login_form(/* */) -> HttpResponse {
    // [...]
    // Display all messages levels, not just errors!
    for m in flash_messages.iter() {
        // [...]
    }
    // [...]
}

TestApp.post_logout() is never written, but is called.
In compute_password_hash() it expose_secret is missing     .hash_password(password.expose_secret().as_bytes(), &salt)?
Not clear what this refers to, "Migrate the expected input from application/json to application/x-www-form-urlencoded;"
Using javascript for the logout form is a little odd. Just using a regular form and button works better, has the benefit of being more obvious, and is accessible also.

        <li>
          <form name="logoutForm" action="/admin/logout" method="post">
            <input type="submit" value="Logout">
          </form>
        </li>

It's very difficult to compare my code to the code that's in the repo for a few reasons.

There appears to have been an undocumented refactor at some point. Possibly in the time between chapters, If that is the case, this wouldn't be a problem when someone is reading the book straight through from cover to cover once it's finished.

see:

https://github.com/LukeMathWalker/zero-to-production/blame/c5bbd6bca250c17e4dd26d9e40c07fa7e1fe4bde/tests/api/helpers.rs#L102
https://github.com/LukeMathWalker/zero-to-production/blame/c5bbd6bca250c17e4dd26d9e40c07fa7e1fe4bde/tests/api/helpers.rs#L238

I'm not sure if it's RLS or rustfmt, but my use statements and dependencies are in alphabetical order....this makes it so much easier to spot minor version differences, forgotten imports, etc.

I'm having two issues with the latest chapter.  When I run locally all the session based tests fail, and I cannot login to the admin dashboard. The errors in the log statements look like this when the correct username and password are supplied to the login form:
{"v":0,"name":"zero2prod","msg":"[HTTP REQUEST - EVENT] Error encountered while processing the incoming
HTTP request: GenericError(NOAUTH: Authentication Required.)","level":50,"hostname":"ChristophersMBP",
"pid":73005,"time":"2022-01-30T19:53:19.835621Z","target":"tracing_actix_web::middleware","line":258,
"file":"/Users/cgubbin/.cargo/registry/src/github.com-1ecc6299db9ec823/tracing-actix-web-0.5.0-
beta.9/src/middleware.rs","http.route":"/login","http.target":"/login","http.flavor":"1.1","otel.kind":
"server","exception.details":"GenericError(NOAUTH: Authentication required.)","otel.status_code":"ERROR",
"http.status_code":500,"request_id":"b9b4002e-170e-4924-99f0-f733fef04a66",
"http.user_agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko)
Chrome/96.0.4664.110 Safari/537.36","exception.message":"Something went wrong when persisting the session
state.","http.host":"<IP_ADDRESS>:8000","http.client_ip":"<IP_ADDRESS>","http.scheme":"http","http.method":"POST"}

After some troubleshooting I got my all the tests to pass on Circle, so I am confident that I have written the code correctly. I think there is some issue locally with how the actix server is communicating with redis which does not occur on the CI server (i am using macOS locally).
When I connect to the redis instance using docker exec -it redis_ sh and run redis-cli I can set variables ok. When I enter auth "password" it correctly informs me ERR AUTH <password> called without any password configured for the default user.
When I connect using redis-cli and the connection string "redis://<IP_ADDRESS>:6379" from the app configuration I get the error  NOAUTH: Authentication Required. which appears in the actix logs.
I am also having a secondary issue on DigitalOcean since adding redis. My project builds but on deployment I get a single line in the log:
Error: TLS error: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify
failed:../ssl/statem/statem_clnt.c:1913: (unable to get local issuer certificate)

This is presumably also an error from trying to connect to the redis database.


#163: Show latest metric only

JIRA Ticket link:
https://github.com/dessa-oss/atlas/issues/163

Sorry I'm a bit out of the loop on this. Was this the recommended UX solution from the MLE's?

Hopefully this summarizes well: when logging a metric continuously throughout the training, MLE's primarily look for the last metric when inspecting a job run. So even though continuous logging of a metric would create a list, we can ignore all metrics except the last as all other metrics are process details and would make for a tougher time reading results.

Sorry let me rephrase, the conversation in the ticket seems inconclusive. Were there any conclusions made?

@choi-calvin the conclusion is to change the functionality of log_metrics such that only the most recent metric published to it is shown in the UI.
This is the task to be able to do so

Got it, thanks for the clarification

@pippinlee OK to merge this?

Let's hold off on merging till UAT pipeline is green: https://jenkins.shehanigans.net/job/foundations-uat/


Pimp my Lock V2 ideas !

Pimp my lock will soon be recreated in a better version !
If you have any ideas of features you want in the new version, please put it in this issue !
If you want to contribute to the new version, do not hesitate to say hi in comments ! :)
Here are some of them :

Clean the code
Invert width and height to be consistent with the resolution given in the settings.
To be able to give position and size using percents or keyword (center, left, etc), instead of raw pixels
Add a way to put other medias (network stream, gif, etc)
To be able to see the password field through Pimp my Lock
To be able to add multiple videos ? (Chosen randomly ? Give a folder and the program choose automatically ?)
(42Paris only) : More portable way to click every second on the window (clean the folder architecture to avoid confusion ?)
Do something if VLC is not installed (install manually of something like this ?)
To be able to link an application to pimp my lock instead of vlc (be careful about danger of this)
Hide vlc logs, handle errors => Do something prettier

Hey Jeremy,
I did not test this on my setup yet (Manjaro KDE) but I'm wondering if this soft is only usable inside 42?
Would like to give it a try to adapt to other contexts if necessary.
Cheers!

Maybe if we set value to -1 in width and height of the player automatically set it to full screen size ?

Hey Jeremy,
I did not test this on my setup yet (Manjaro KDE) but I'm wondering if this soft is only usable inside 42?
Would like to give it a try to adapt to other contexts if necessary.
Cheers!

Hi Zak !
It could be used everywhere. Started alone, this program launch a window with a video inside and let pass every input through it.
Inside 42, this program is started just after the locker to allow students to personalize their lock but it could be started alone or along something else :ok_hand:

Maybe if we set value to -1 in width and height of the player automatically set it to full screen size ?

I thought that using percents will be easier to understand. Instead of -1, it will be 100%. Does -1 have something better I am missing ?

Maybe if we set value to -1 in width and height of the player automatically set it to full screen size ?

I thought that using percents will be easier to understand. Instead of -1, it will be 100%. Does -1 have something better I am missing ?

maybe not  didnt think of that :ok_hand:


fix(text-input): Changing spellcheck to spellCheck

Found out a warning when running my tests for spellcheck on text-input
This pr fixes that. 😄
Warning: Invalid DOM property `spellcheck`. Did you mean `spellCheck`?
    in input (created by Box)
    in Box (created by Text)
    in Text (created by TextInput)
    in TextInput (at index.js:30)
    in div (at index.js:29)
    in DebuggerHeaderTextInput (at index.js:28)
    in div (at index.js:23)
    in DebuggerHeader (created by WrapperComponent)
    in WrapperComponent

cc @jeroenransijn


notify app/driver owner of bad manifest

I see that BPTWorld has a bad manifest for one of his apps.  Wonder how a notification could occur to the developer to notify them of the error.  Maybe use a free SMTP relay?

That sounds a bit scary. Imagine if 1000 people have the app installed, you wouldn't want 1000 emails. I'm thinking the best thought is to encourage people to use the hpm.exe to build the files and to test locally before publishing.

Very scary! I have over 30 apps/drivers.  Typo's WILL happen.  Just need to flush them out as people start using this app.

Makes sense not to do this


didPressLeftButton not firing on the left border

Any fix for that? Seems to be related to the back gesture recognizer.

Sounds good, thank you!

This worked, thanks again!
    let correctLeftInset: CGFloat = 8.0
    self.textInputbar.contentInset = UIEdgeInsetsMake(5.0, 8.0 - correctLeftInset, 5.0, 8.0)
    //then use an image that is 2*correctLeftInset wider than needed
    leftButton.setImage(myImage, forState: UIControlState.Normal)


chore(frontmatter): dealias created/modified/updated time

Signed-off-by: Aaron Pham<EMAIL_ADDRESS>

latest change should address the regression PTAL.


Getting worse results when not using --cuda_ray?

Hi,
I found that when testing nerf_synthetic_lego dataset, if I remove --cuda_ray, the result seems to become worse. What's the difference between the pytorch ray marching & cuda ray marching? Shouldn't they only differ in speed? Thanks!

@yongsiang-fb Hi, they are quite different in implementation (e.g., the occupancy grid). You may increase num_steps and upsample_steps for non cuda ray mode for better quality.


Fixed //mixpanel.com/somefile.js being replaced.

Currently it doesn't work for this code:  <script async src='//www.google-analytics.com/analytics.js'></script>. It tries to replace the CDN because it is only checking for / in urls, not //. This pull request fixes it.
Thanks!
Shawn

pls!


background.png flickers during boot

During boot, when displaying the background.png, a few times a blank screen flickers on.
Is that somehow avoidable?

It's certainly possible, but I'm not sure how off the top of my head.
At least one flicker is caused by switching the display from the Plymouth boot graphics to the window manager background. They both have been configured with the same background color & background image, so they look the same, but they're actually two completely different things.
Something someone more versed in this stuff might be able to achieve is to keep the Plymouth boot graphics somehow visible for a longer time, while starting X in a different VTY, and switching over only when the browser is ready.
Would love a PR if someone has ideas on how to make this happen!


[WindowsAppSDK1.4 ]Exception on Close() ( AppWindow is set as parent of Xaml Window )

Describe the bug
Issue is only in WindowsAppSDK1.4 , not in 1.3.
An AppWindow is created and is made as a parent to XamlWindow. On button( of XamlWindow) click , Close() is called. Which resulted in exception.
Steps to reproduce the bug
A simple WinUI3 ( WinRT c++ ) app is created. WindowsAppSDK1.4 is created.
By default a xaml window is there ( MainWindow.xaml ).   On Button click of MainWindow, another window is created.
void MainWindow::myButton_Click(IInspectable const&, RoutedEventArgs const&)
    {
            winrt::Microsoft::UI::Windowing::AppWindow AppWindows(nullptr);
            AppWindows = winrt::Microsoft::UI::Windowing::AppWindow::Create();
            HWND hAppWnd = (HWND)AppWindows.Id().Value;
            HWND hMsgWnd{ 0 };
            auto k = make<BlankWindow>();
            hMsgWnd = (HWND)k.AppWindow().Id().Value;
           ::SetParent(hMsgWnd, hAppWnd);
           // k.AppWindow().
            AppWindows.Show();
            k.Activate();
    }

BlankWindow
A simple window added to project.
<Window
    x:Class="App5.BlankWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:App5"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    mc:Ignorable="d" >

    <StackPanel Orientation="Horizontal" HorizontalAlignment="Stretch" VerticalAlignment="Stretch" Background="DimGray" >
        <Button x:Name="myButton" Click="myButton_Click" Foreground="Red">Click Me</Button>
    </StackPanel>
</Window>

void BlankWindow::myButton_Click(IInspectable const&, RoutedEventArgs const&)
{
    Close();
}

On button click on BlankWindow, Close is called, which creates exception/crash.
Exception thrown at 0x00007FFF49751328 (Microsoft.ui.xaml.dll) in App5.exe: 0xC0000005: Access violation reading location 0x0000000000000000.
[CallStack]
Microsoft.ui.xaml.dll!DirectUI::WindowChrome::SetTitleBar(ABI::Microsoft::UI::Xaml::IUIElement * titleBar=0x0000000000000000) Line 87	C++
 Microsoft.ui.xaml.dll!DirectUI::DesktopWindowImpl::SetTitleBarImpl(ABI::Microsoft::UI::Xaml::IUIElement * pTitleBar=0x0000000000000000) Line 1285	C++
 [Inline Frame] Microsoft.ui.xaml.dll!DirectUI::Window::SetTitleBarImpl(ABI::Microsoft::UI::Xaml::IUIElement *) Line 846	C++
 Microsoft.ui.xaml.dll!DirectUI::WindowGenerated::SetTitleBar(ABI::Microsoft::UI::Xaml::IUIElement * pTitleBar=0x0000000000000000) Line 374	C++
Microsoft.ui.xaml.dll!DirectUI::DesktopWindowImpl::CloseImpl() Line 451	C++
 [Inline Frame] Microsoft.ui.xaml.dll!DirectUI::Window::CloseImpl() Line 287	C++
 Microsoft.ui.xaml.dll!DirectUI::WindowGenerated::Close() Line 247	C++
App5.exe!winrt::impl::consume_Microsoft_UI_Xaml_IWindow<winrt::App5::implementation::BlankWindow>::Close() Line 4604	C++

If  we didn't made AppWindow as parent to BlankWindow, Close works fine.
Expected behavior
No response
Screenshots

NuGet package version
None
Windows version
No response
Additional context
No response

Hi I'm an AI powered bot that finds similar issues based off the issue title.
Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!
Closed similar issues:

WinAppSDK 1.3: Application crash when pressing the close button while debugging  (#8535),  similarity score: 0.81
[WinAppSDK1.2] App crash and fails to load main window, if layout xaml contains any TextBox element.  (#7915),  similarity score: 0.79
Closing multi-window app results in unhandled win32 exception. (#7719),  similarity score: 0.77

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

I don't think issue is same as above mentioned links.

The issue in general here is that a window that is written as a top level window may not function correctly as a child window. Microsoft.UI.Xaml.Window has no means of creating the window as a child, which means that this scenario is not supported. This does have an effect, for example, broadcast messages are only ever sent to top level windows. Changing the parent of a window is also problematic in general. The child window has to be aware of this kind of thing in order to work.
To put it simply, WinUI 3 does not support the main window being set as a child window, it never did. The fact that it worked in earlier versions of the Windows App SDK releases is just luck. There is also a bug report that describes this same layout somewhere, but it was closed as not supported. I'll see if I can find that.

Ok. Understood. Thank you for explanation.

Resolving as dup of #8900


Is there a way to customize HTTP Response Content (More Specifically, Code)?

For Password Reset, POST http://localhost:8000/auth/users/reset_password/,

First of all, the response header doesn't seem to tell me whether user is already registered or not. Of course the password reset link only gets send to the ones who are registered, but is there some other way to automatically tell if user is registered beforehand?

One idea for 1 is to return a customized HTTP response, or at least change the HTTP Code. So far, regardless of whether user is registered, the response code is 204, the response headers are always the same, and there's no response body. Can we customized this?

Thanks!

Edit:
It looks like, in djoser/djoser/views.py, line 236-247:
@action(["post"], detail=False)
    def reset_password(self, request, *args, **kwargs):
        serializer = self.get_serializer(data=request.data)
        serializer.is_valid(raise_exception=True)
        user = serializer.get_user()

        if user:
            context = {"user": user}
            to = [get_user_email(user)]
            settings.EMAIL.password_reset(self.request, context).send(to)

        return Response(status=status.HTTP_204_NO_CONTENT)

The function would return the same response regardless of user exists... is there a way to customize/overwrite this? （Or would it be allowed to add another return statement under the if statement with different status?)

If else will work right here? If user exits send mail or else return other status

If else will work right here? If user exits send mail or else return other status

Yeah, exactly. I‘ll try to create a PR?

Yeah sure

Sorry, but this is a security/privacy antipattern because it allows for checking if there is an account for given email.


Aesthetic and functionality improvements

Suggestions are from hcevasco@ to<EMAIL_ADDRESS>Copied from email :)

Use a color gradient for easy visual scanning of class rating / workload. Highly rated classes are dark green and that fades to yellow then red as the ratings decrease. The opposite gradient applies to increased workload ratings. (See pics for examples)
Include the name of the course (maybe just enough to fit on one or two lines) in a smaller font underneath the course number on the calendar view. This would be helpful to quickly see which class is which without having to click on it. (See example in attached schedule screenshot)
Maybe a “hover” capability (not sure what this is called in CS terms) so you can see a course description from your schedule or from the list without clicking on it. (See pic for example)
A wishlist for classes you’re interested in for the future but not for your current schedule.
Can you save your schedule somehow? I cleared my cache and all of the schedules I had made disappeared.

ideally this is split into several issues


update to the latest path-to-regexp (2.2.1)

fixes #232

This change is

Manual work is a bug.
I guess there are some valid reasons for not using semver ranges for path-to-regexp dependency.


EMX:  Supporting liveramp and uid2 userids

Please let us know when can we expect these changes to be merged or if you require any additional information.
Thanks

Confirmed released with 5.4


Changing info about email

Starting to update the instruction for R-Ladies email

I think this is ready to merge, so we have the email information updated on the guide.  Thanks @drmowinckels for reviewing my changes.


test(DataStore): Update schemas for use 'sub' as default identity claim feature

Issue #, if available:
Description of changes:
The change in CLI tagged release<EMAIL_ADDRESS>will provision backends and codegen the default identity claim as "subs", previously "cognito:username".
This PR is running automated tests related to the usage of @auth with default owner field in the schema.
The code generated model files contains the explicit identityClaim key, which has been updated from "cognito:username" to "subs" (see model schema file changes in this PR).
Tests that were in place with regards to these schemas were tested.
There is one failing test related to TodoExplicitOwnerField. [TBD CLI issue]
Check points: (check or cross out if not relevant)

[ ] Added new tests to cover change, if needed
[ ] Build succeeds with all target using Swift Package Manager
[ ] All unit tests pass
[ ] All integration tests pass
[ ] Documentation update for the change if required
[ ] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Is the TodoExplicitOwnerField the subscription issue that you pointed out?

Is the TodoExplicitOwnerField the subscription issue that you pointed out?

yes that's the same one

We should add a schema used for V2 transform.
 We should either have another set of tests for V2 backends or update these tests completely.
the schema in V2 reads owner is allowed to create, update, delete but no one is allowed to read (owner or others).  so regardless of whether the subscription contains an owner input doesn’t matter since no one should be able to get/list/onCreate/onDelete/onUpdate. the schema to verify that things are working is

retest with<EMAIL_ADDRESS>


Restoration workers aren't restarted with the wallet

Release
Operating System
Cause

next
Windows & OSX & Linux)
Code

Context

When creating a wallet via the API, we also start a restoration worker in charge of keeping the wallet in sync with the chain. There's one dedicated worker per wallet, and they're fairly resilient to network issues.
However, when restarting a wallet using an existing database that already contains a wallet, not restoration worker is started. Though, the wallet exist in DB and can't be recreated for instance.
Steps to Reproduce

$ cardano-wallet launch --state-dir .state
$ cardano-wallet wallet create ...
SIGINT or CTRL-C on the launcher
$ cardano-wallet launch --state-dir .state

Expected behavior

We should see log activity for a restoration worker keeping the wallet in sync.
Actual behavior

Nothing happen, the wallet exists in the DB but no restoration worker in background.

Resolution Plan

[x] Upon starting, lookup existing wallets.
[x] Start a worker for each wallet.

PR

Number
Base

#486
master

QA

Add an integration tests which does the following steps (see LauncherSpec)

Start a wallet server (on an empty state, with persistence)
Create a new wallet
Immediately kill the wallet server
Re-start a wallet server, using the same database file
Expect the previous wallet to exist and eventually be restored.

Note that the test is only a best-effort and will sometimes give false positive (but shouldn't give any false negative!). This is because we are running the test on a fresh new blockchain so, depending on when the restoration kicks in, it might have time to restore the wallet before we even kill the server (:rocket:). This happens fairly rarely in practice, and shouldn't give any false alarm anyway.

lgtm


Rive Renderer with Flutter?

The documentation mentions that when using Flutter its only possible to use Skia/Impeller, is this still true?
Are there any updates on Flutter support? Will it be possible in the near future?
Thank you <3

Soon! Our Flutter runtime required a bigger rework. We will be releasing a base package called rive_native to Pub, which will eventually be used in rive_flutter. Once rive_native launches you'll be able to use the Rive Renderer in Flutter, however, it will still be a few weeks before we do a major release of rive_flutter, at which point you can opt-in to use either Flutter's renderer or the Rive Renderer (for Rive content).
We have this issue on the public Flutter board: https://github.com/rive-app/rive-flutter/issues/388
I'll close this here as a duplicate of that.


Customize stepper: In step array, beyond the title, add an icon for each step

I've added support for icon, it's already merged into master.

Awesome! I will test and give feedback asap.


[1.9.4] Unable to place Wind Generator

Compiled on 04/07/2014
Forge Version: 1.9.4-<IP_ADDRESS>6
Simply unable to place the wind generator in the world, it simply deletes itself

Should be fixed, thanks!


PR test

@ItamarLevin I don't think that the CI should run in prs, only tests.
CI containing deploy should run only in push to dev/master, that one is good.
Sorry if I got you confused


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/91791

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92157


New Properties and Comment Edits

Objective
Added 'Group' Property to 'AIRTURN', 'SPLITTER' and 'STIFFENER' Objects to support undocumented Autodesk Fabrication 2022 additions.
Numerous edits to Comments to for more clarity, grammar/formatting consistency and various spelling errors.
Abstractions
n/a
Tests performed
n/a
Screen shot
n/a

Everything in this was handled by the newer PR #34


[5.6] Fix issues caused by having the plugin subcommand be the default subcommand (#4060)

This is a 5.6 cherry-pick of #4060. Details in that PR. Motivation: This improves package plugins, a new feature in SwiftPM 5.6.

@swift-ci please test

Rebased and restarting test

@swift-ci please test

Rebased and restarting build

@swift-ci please test


docs: update README.md on current status and setup instructions for the project

Fix bug report URL and update setup instructions.
Closes https://github.com/elastic/apm-aws-lambda/issues/241

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-08-23T09:10:21.726+0000

Duration: 8 min 38 sec

Test stats :test_tube:

Test
Results

Failed
1

Passed
159

Skipped
2

Total
162

Test errors
Expand to view the tests failures
Test / Matrix - PLATFORM = 'ubuntu-18 && immutable' / Test / TestInfoRequest – github.com/elastic/apm-aws-lambda

Expand to view the error details
 Failed

Expand to view the stacktrace
 === RUN   TestInfoRequest
{"log.level":"warn","@timestamp":"2022-08-23T09:17:40.392Z","log.origin":{"file.name":"extension/process_env.go","file.line":110},"message":"Could not read ELASTIC_APM_DATA_RECEIVER_TIMEOUT_SECONDS, defaulting to 15: strconv.Atoi: parsing \"\": invalid syntax","ecs.version":"1.6.0"}
{"log.level":"warn","@timestamp":"2022-08-23T09:17:40.392Z","log.origin":{"file.name":"extension/process_env.go","file.line":116},"message":"Could not read ELASTIC_APM_DATA_FORWARDER_TIMEOUT_SECONDS, defaulting to 3: strconv.Atoi: parsing \"\": invalid syntax","ecs.version":"1.6.0"}
{"log.level":"warn","@timestamp":"2022-08-23T09:17:40.392Z","log.origin":{"file.name":"extension/process_env.go","file.line":128},"message":"Could not read ELASTIC_APM_LOG_LEVEL, defaulting to info","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:40.394Z","log.origin":{"file.name":"extension/client.go","file.line":122},"message":"ExtensionID : b03a29ec-ee63-44cd-8e53-3987a8e8aa8e","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:40.394Z","log.origin":{"file.name":"app/run.go","file.line":61},"message":"Register response: {\n\t\"functionName\": \"UnitTestingMockLambda\",\n\t\"functionVersion\": \"$LATEST\",\n\t\"handler\": \"main_test.mock_lambda\"\n}","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-08-23T09:17:40.395Z","log.origin":{"file.name":"apmproxy/receiver.go","file.line":57},"message":"Extension listening for apm data on :44683","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-08-23T09:17:40.396Z","log.origin":{"file.name":"logsapi/subscribe.go","file.line":73},"message":"Extension listening for Lambda Logs API events on <IP_ADDRESS>:44755","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-08-23T09:17:40.396Z","log.origin":{"file.name":"app/run.go","file.line":149},"message":"Waiting for next event...","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:40.397Z","log.origin":{"file.name":"app/run.go","file.line":166},"message":"Received event.","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:40.397Z","log.origin":{"file.name":"app/run.go","file.line":167},"message":"{\n\t\"timestamp\": \"2022-08-23T09:17:40.397081478Z\",\n\t\"eventType\": \"INVOKE\",\n\t\"deadlineMs\":<PHONE_NUMBER>396,\n\t\"requestId\": \"6cabdc97-bc9e-42a0-adc6-2764ce97213c\",\n\t\"invokedFunctionArn\": \"arn:aws:lambda:eu-central-1:627286350134:function:main_unit_test\",\n\t\"tracing\": {\n\t\t\"type\": \"\",\n\t\t\"value\": \"\"\n\t}\n}","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:40.398Z","log.origin":{"file.name":"logsapi/event.go","file.line":78},"message":"Received log event platform.start","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.399Z","log.origin":{"file.name":"apmproxy/receiver.go","file.line":95},"message":"Handling APM server Info Request","ecs.version":"1.6.0"}
{"level":"debug","ts":1661246261.3997996,"caller":"apm-aws-lambda/main_test.go:101","msg":"Event type received by mock APM server : TimelyResponse","ecs.version":"1.6.0"}
{"level":"debug","ts":1661246261.3998437,"caller":"apm-aws-lambda/main_test.go:104","msg":"Timely response signal received","ecs.version":"1.6.0"}
{"level":"debug","ts":1661246261.4001422,"caller":"apm-aws-lambda/main_test.go:302","msg":"Response seen by the agent : 200","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.400Z","log.origin":{"file.name":"logsapi/event.go","file.line":78},"message":"Received log event platform.runtimeDone","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-08-23T09:17:41.400Z","log.origin":{"file.name":"logsapi/event.go","file.line":84},"message":"Received runtimeDone event for this function invocation","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.400Z","log.origin":{"file.name":"app/run.go","file.line":217},"message":"Received runtimeDone signal","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.400Z","log.origin":{"file.name":"app/run.go","file.line":123},"message":"Waiting for background data send to end","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.400Z","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":43},"message":"Invocation context cancelled, not processing any more agent data","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.400Z","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":66},"message":"Flush started - Checking for agent data","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.400Z","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":75},"message":"Flush ended - No agent data on buffer","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-08-23T09:17:41.400Z","log.origin":{"file.name":"app/run.go","file.line":149},"message":"Waiting for next event...","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.401Z","log.origin":{"file.name":"app/run.go","file.line":166},"message":"Received event.","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.401Z","log.origin":{"file.name":"app/run.go","file.line":167},"message":"{\n\t\"timestamp\": \"2022-08-23T09:17:41.401696979Z\",\n\t\"eventType\": \"SHUTDOWN\",\n\t\"deadlineMs\":<PHONE_NUMBER>400,\n\t\"requestId\": \"94f832b2-4150-4a67-8ffe-8318ac4fbe3d\",\n\t\"invokedFunctionArn\": \"arn:aws:lambda:eu-central-1:627286350134:function:main_unit_test\",\n\t\"tracing\": {\n\t\t\"type\": \"\",\n\t\t\"value\": \"\"\n\t}\n}","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-08-23T09:17:41.401Z","log.origin":{"file.name":"app/run.go","file.line":120},"message":"Received shutdown event, exiting...","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.401Z","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":66},"message":"Flush started - Checking for agent data","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-08-23T09:17:41.401Z","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":75},"message":"Flush ended - No agent data on buffer","ecs.version":"1.6.0"}
    main_test.go:672: timed out waiting for app to finish
--- FAIL: TestInfoRequest (5.00s)

Steps errors
Expand to view the steps failures

Running Go tests

Took 1 min 31 sec . View more details here
Description: gotestsum --format testname --junitfile junit-report.xml -- -v ./...

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

/test


s/logging.warn/logging.warning/ in python code

logging.warn is deprecated in favour of logging.warning in Python3,
which results in deprecation warning messages polluting our test logs.
This commit updates the usage to the new style.
I noticed this in the logs referenced in #2589

Oops, I didn't look at other places when I created #2629, sorry!

Oh I wasn't even aware of #2629!


Update website for TFjob v1 docs

Removed v1beta1 documentation, added v1.

This change is

/hold

/assign @sarahmaddox

Preview:

https://deploy-preview-732--competent-brattain-de2d6d.netlify.com/docs/reference/pytorchjob/
https://deploy-preview-732--competent-brattain-de2d6d.netlify.com/docs/reference/tfjob/

LGTM with just one question: I see we've removed the v1beta1 API reference, replacing it with v1. Is that because v1beta1 is no longer supported?
/lgtm

@sarahmaddox Yes, we have stopped supporting v1beta1. V1 is the stable release now, and v1beta2 is for backward compatibility.


xCode 7, ios demo failed

When I building the project, I got the error info like this: "no such file or directory: 'webrtc-build-scripts/ios/webrtc/src/talk/examples/objc/AppRTCDemo/ios/AppRTCDemo-Prefix.pch'"
I found the directory "/src/talk/examples/objc/" isn't exist, but why the demo project leading to that directory.
Thanks.

+1 Got this as well

@T-tssxuan in case this helps, I worked around this by introducing a soft link directory at src/talk pointing at ../webrtc/examples. But after that I started getting errors about files missing (seems that example project structure has been changed by Google or something). And after resolving these I have now reached a point when the build fails during linking, getting 'Undefined symbols for architecture armv7', which is strange cause the library used has such symbols.
Anyone has any ideas how to properly build the AppRTCDemo application for XCode 7?
Thanks in advance!

In case this is helpful to anyone else apart from @T-tssxuan  in the future, here are the steps I took to get it to work in Xcode 7:

added src/talk symlink to fix path as described above
added missing files in project both in sample app (webrtc/examples/objc/AppRTCDemo) and include files (talk/app/webrtc/objc/public)
added some frameworks and libs that were missing (videotoolbox framework , libstdc++.tbd library)
removed resources/Default-568.png from the project as the file was no longer there and there was a build error issued
Added<EMAIL_ADDRESS>in the launch image resources of xcode to get the screen to be resized properly in iphone 5 that I'm testing

And that's about it I think
Best regards

@atsakiridis Could it be the version that the webRTC support is too old? I did not test it, because I need to investigate the server side solution for the video conference. Did you solve this problem? @atsakiridis If I get the solution, I will tell you immediately.
Thanks.

Not sure @T-tssxuan, I guess the pristineio folks can tell us which webrtc version they are currently using. From my side, I'm using #10255. Yes I was able to build AppRTCDemo. I was thinking of adding a Pull Request, but I first need to know if others have this issue or whether it only happens to us for some reason

I'm having the same issue as well, along with one more:
clang: error: no input files

+1 Same here.
There is also problem with WebRTC.framework (Xcode 7 only), simulator will fail with error:
Error=PackageInspectionFailed, ErrorDescription=Failed to load Info.plist from bundle


Update Readme

Hello,
I found this on the forum
Could you, please, elaborate on the game

What stage of development is it on? Is it playable?
Could you provide some plans on development? May be just a short list of features that are planned next.

I understood that the primary purpose of the game is to demonstrate the use of Nakama. What Nakama features are already implemented? Which ones are you planning to implement? Please, add some details as where in the code they are invoked, may be some other details that could be of help for Nakama newbies.
Thank you, that will definitely be of use for many Godot users.

The game is at a playable stage.
Main Nakama features are:

User accounts
Matchmaking
Leaderboards
Real-time connection

David is now working on a tutorial that’ll walk through all of this.

The game is at a playable stage.
Main Nakama features are:

User accounts
Matchmaking
Leaderboards
Real-time connection

David is now working on a tutorial that’ll walk through all of this.

@dsnopek if you could kindly add info on what features of Nakama are being used in the game, as well as how to play the game (which keys - see #2) that would be super helpful. Thanks!

@dsnopek if you could kindly add info on what features of Nakama are being used in the game, as well as how to play the game (which keys - see #2) that would be super helpful. Thanks!

@mofirouz Absolutely!
The README.md has been updated with the controls and list of Nakama features used.

@mofirouz Absolutely!
The README.md has been updated with the controls and list of Nakama features used.


NON-ISSUE Fix broken link in doc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Advanced button disabled in RDF extension 0.9

While using RDF extension 0.9, when I edit RDF skeleton and add prefixes, the advanced button for adding a new prefix appears disabled. How do I enable this button to add a prefix of local ontology file?

@rjakshayjain13 You should rather report this issue at https://github.com/fadmaa/grefine-rdf-extension , this is the repository for the core functionality of OpenRefine.


when i download it says virus detected, so whats that all about🤨

what the title says, why does it say virus detected

Can you elaborate? Where are you downloading the installer from? What does the message look like?

I'm downloading for the github page but when I tried to it said "Failed to
download-virus detected"
On Tue, 18 Jul 2023, 19:58 voidloops, @.***> wrote:

Can you elaborate? Where are you downloading the installer from? What does
the message look like?
—
Reply to this email directly, view it on GitHub
https://github.com/BetterDiscord/Installer/issues/354#issuecomment-1640797755,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7LO4GK2EMX5KTG37TJ2EKLXQ3MEHANCNFSM6AAAAAA2OYF5XQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

@KAKTUSMAN21 Your browser is marking it, look for ... or an arrow next to the download, and choose keep.

We don't add viruses to our software.


Update the public helm chart used by the namespace repo

TestHelmNamespaceRepo validates that a namespace reconciler gets a source error when syncing from a public helm chart that includes cluster-scoped resources. The wordpress chart doesn't include any cluster-scoped resources, so this commit updates the chart to pass the validation.

@tiffanny29631 FYI, the should prevent a new autobug from your onduty list.

/lgtm
/approve


What's the idea?

We've implemented a unique, auto-increment Guid generator based on append blob.
How's your plan about your generator? Is it OK to share?

@Wizmann sorry for late response, I have changed the idea, it is not strict-auto-increment, I use an id generator algorithm called BoundaryFlake which includes time information in id finally. Could you share the idea of auto-increment Guid generator?

After each appending of an append blob, there's a return value for the offset of the data we just add to the blob.
Apparently it's an strictly auto-increasing ID as we adding bytes to the end of the blob, the offset value should be monotone increasing.
The only problem is the limitation of the append operation of a single append blob. But we've figured out a way to tackle it (similar to CAS operation). If you are interested with the idea, we can have a discussion privately.


Adding RTL mode

Would you accept a PR that allows us to kick the generator into RTL mode and change the default text from English lipsum to arabic or hebrew (see http://generator.lorem-ipsum.info/_arabic).
Currently, we could only do this with a wrapping script, providing a different wordlist, but testing components in RTL is something that would be great if it came OOTB.

Hey @joscha! Absolutely, would accept a PR for that.

Closing as it is not something on my radar to add, but if you want to submit a PR I would be happy to accept it. Cheers.


add pkg flag for join cmd

What type of PR is this?

/kind optimize
What this PR does / why we need it:
添加 pkg 命令行参数，可以覆盖默认的 deploy-config,  用来支持添加异构的 agent 节点
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

/kind optimize

Codecov Report

Merging #577 (d53fd5e) into master (9697b94) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   14.03%   14.03%
=======================================
  Files         138      138
  Lines       19503    19503
=======================================
  Hits         2738     2738
  Misses      16469    16469
  Partials      296      296

/lgtm


Request To Add My University

Universidad del Valle de Mexico
Site

https://uvm.mx/

@dev-alvarez I am sorry, the domain my.uvm.edu.mx is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

Thanks a lot for replying, yeah to be hones it really does not surprise me. I am already enrolled on the github student dev pack. Thanks a lot have a wonderful day!


Help with the issue of interaction with itwin viewer

Hello,
Considering the model, you can interact with its elements (that is, click on the element) and get more detailed information on the side information window. I wanted to find out where the code that is responsible for this interaction is located in order to link my code to this click.
My very task is that when I click on an element, receiving object data, I would be able to compare this data with the data of another database and output the result to the information window I created.
I'll attach a photo, with a more visual example. The notepad window is just an example of an information window that will be based on the task in the browser window.
I hope that I have described everything in an accessible way.
Thank you in advance for your help in this matter
https://disk.yandex.ru/i/2lPx9EKPswYGBw - link to the photo

⚠ Do not edit this section. It is required for imodeljs.github.io ➟ GitHub issue linking

LINK: Developing-a-Web-Viewer---iTwin.js-link-to-docs
TAG: imodeljs-docs-question
SOURCE: https://www.itwinjs.org/learning/tutorials/develop-web-viewer/

I think these sandboxes might be useful to you:

Unified Selection PropertyGrid - creates a similar component that you have in your screenshot and hooks it into unified selection so it shows properties of selected elements.
Element Properties Loader - hooks into unified selection and shows properties of selected element in a custom component.

More on unified selection:

Demystifying Unified Selection and Selection Scopes
Hooking 3rd Party Component into Unified Selection

I've studied the sandboxes and the articles you gave me
I have problems understanding where to use the code that is used in sandboxes and in articles

Well, it depends on your application. The sandboxes create a widget through UiItemsProvider and all the unified selection and properties related code is contained within the widget.
Adding @kckst8 and @aruniverse for the itwin-viewer perspective.

Take a look at the following tutorial on how to go from some of the samples Grigas had listed above to the viewer: https://developer.bentley.com/tutorials/adding-showcase-widgets-to-your-itwin-viewer/
I'd also recommend you take a look at our accreditation program, https://developer.bentley.com/accreditation/, which will give you a good overview of how to connect your own services to your viewer.
When you click on an element, you should be able to retrieve it's ECInstanceId which you could use to look up in your own database or whatever maps to it, and then your service would need to return the data you'd like to see.
 Take a look at https://github.com/imodeljs/viewer-components-react/blob/master/packages/property-grid/src/PropertyGridUiItemsProvider.tsx for the PropertyGrid we use in the iTwin Viewer.

I tried using the code from these two sandboxes, Unified Selection PropertyGrid , Element Properties Loader , adding them as shown in this example,
https://developer.bentley.com/tutorials/adding-showcase-widgets-to-your-itwin-viewer/ , but the widgets did not appear
I also noticed that the examples use elements from @itwin/sandbox, but at the same time, it is not in the application
I attached the code in which I made changes based on the examples, I think I missed something, on which the display of widgets in the application depends- https://disk.yandex.ru/d/Y3xWo3Yv_BYyrg
I also apologize for possibly stupid questions, I'm new to this field and I'm trying to figure it out as best I can
Thank you for helping me


Jenkins thinks "0" means "3 minutes", not "infinite"

maybe 3 minutes is enough for some programming languages. not for Scala

this is a followup to #103. review by @adriaanm

I guess there should be a way to make it infinite, but 1440 minutes should be enough for anybody.


Bottom black bar doesn't recover from landscape sometimes

When recovering from landscape mode, sometimes the bottom black bar doesn't appear. Switching landscape mode and switching back to portrait sometimes fixes it, sometimes it doesn't.
https://github.com/zacharee/NachoNotch/assets/8340896/f3dd2ed1-cbc6-44de-88be-b86a1dd78ac1
Once it happens, toggling either the app itself or the option for black nav bar doesn't fix that. It has to be done by flipping the phone like in the recording.

Hi @zacharee, thank you for updating the app. I was testing the latest release but feel like this issue is not fixed, can you please confirm? Thank you!
https://github.com/zacharee/NachoNotch/assets/8340896/53a8e58a-5af3-43eb-8f01-5e049dfa6f0a

This should be fixed in version 38.

@zacharee it works like a charm, thank you!


Updated AboutUs.md and added portfolios for each member

Updated according to week 7 requirements.
It is not completed, we require other members to add their profile pictures. Once this is done, we can close #5.
I've also added the portfolio files to log each member's contributions (as templated by team/johndoe.md).

Note: IIRC CS2103T commits need to be in present tense so Update not Updated.


Add "Hourly" as a default interval

This PR adds support for "hourly" as a default interval, meaning the order limiting would reset at the top of every hour.
Since this change introduces sub-day resetting, I've also applied some updates to the messaging within WP Admin (e.g. "Based on your store's configuration, new orders have been put on hold until 4:00pm" instead of always defaulting to the date on which the next interval begins).
The customer-facing placeholders have also been updated, giving store owners the following options:

{current_interval} (e.g. "April 27, 2020")
{current_interval:date} (alias of {current_interval})
{current_interval:time}(e.g. "5:00pm")
{next_interval} (e.g. "April 28, 2020")
{next_interval:date} (alias of {next_interval})
{next_interval:time}(e.g. "6:00pm")
{limit} (e.g. "100")

I've kept {current_interval} and {next_interval} for backwards-compatibility purposes.
Fixes #18.

Just realized the README hasn't been updated with the new placeholders, adding now.

Waiting to merge until the readme is updated


User-reported unhelpful error message

https://code.world/#PfDSvNaEK01xEr6lc4O5cCA
program.hs:7:18-27: error:
• Missing punctuation before this expression.
Perhaps you forgot a comma, an operator, or a bracket.
• To multiply, please use the * operator.
For example: drawingOf * ourPicture
• To apply a function, add parentheses around the argument.
For example: drawingOf(ourPicture)

This looks like someone who intended to use https://code.world/haskell, and ended up at the educational variant instead.  Given that they are where they are, though, the error message seems clear, and even explicitly suggests adding the parentheses to apply a function.  I don't think there's any obvious improvement here.


Features suggestions

Like instead of highlighting the line  i want to highlight some part of code

suppose  on line 7
python3 blah blah blah important blah blah
i want to highlight the word important only.

Just like we can change colour of inline code. like that i am expecting to change codeblocks colour as well.

I was already considering to offer this option. I will include this in the next release.
I don't really know what you mean by this? You can change the background color of code blocks. Or which color do you mean? Please explain in more detail.

Available in current release (1.2.6). Should there be any problems please report back.


Which version of Gazebo Ignition is currently in use?

Hi. I was trying to run the Gazebo user guide by following the documentation, but I'm seeing some inconsistencies.

The Gazebo tutorial tells how to install Gazebo Fortress, but when I want to try the examples, the commands use gz sim, which could be Gazebo Garden or Harmonic. So what version is it?

Hi,
thanks for pointing out this discrepancy. You should try Gazebo Harmonic - our latest tutorial points to that.

Hi Ruben. To the best of my knowledge, we don’t have any resources for reinforcement learning with Gazebo Harmonic. However, it’s possible that others have explored using the Crazyflie in a similar context. Alternatively, you might find general resources online for reinforcement learning with UAVs in Gazebo that could be applicable to the Crazyflie.

Thanks for your advice @gemenerik. I'm going to research it.


Story 2159 work in progress added error handling retry mechanism, err…

…or page in progress testing on other views in progress, see details to be done using Error component from next.js
2159 Infura Error handling
Changes 👷♀

Added error page
Changed translation from 'Go to home' to 'Go to hompage'
Added new error handling coponents to do it outside AppSpinner

How to test 🧪
On Landing Page

Turn off developer tools go to network tab block requests from infura
After 3 request fail one should be redirected to error page
On error page one should be able to see error details. after clisking button 'See details'

Definition of done ✔

[ ] Acceptance criteria for each issue met
[ ] Unit tests written where needed and passing
[✔ ] End-to-end tests for happy path
[ ] Documentation updated
[ ] Project builds without errors
[ ] Non-functional requirements met
[ ] Code reviewed and functionality tested by the reviewer (locally, Heroku, etc.)
[ ] Feature verified and accepted by Product Owner
[ ] Project deployed to production environment

I guess this can be closed @johnnieskywalker?

Yes

closed as was implemented better way in other pull request with errorHook https://github.com/OasisDEX/oasis-borrow/pull/319


Refactor JavaScript code with classes

Could you please check my refactored JavaScript code?

Great job!
The code is nice, and it is working fine.


Allow specifying the model namespace to use

In c-sharp emitter options defined in tspconfig.yaml, it is possible to say whether or not to use a model namespace, e.g. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/eventgrid/Azure.Messaging.EventGrid/tspconfig.yaml#L28
It would be helpful to allow the model namespace to be configurable. This is a requirement for migrating the Event Grid system events to TypeSpec.

@JoshLove-msft sounds like if we take the namespace defined for model could solve your problem? Currently we don't read any model namespace from spec.
Could you give me an example what namespace you want to change to?

@m-nash would you triage this request? My understanding is we do not allow arbitrary namespace for models.

Hello @JoshLove-msft Would you please describe why EventGrid want customize the model namespace, and what namespace hierarchy they want?  We will justify if we need to provide customized model namespace. Thanks

This is no longer required as the system events are now in a separate library and do not use model namespaces.


Manifest Reproduce true fix

Ok so I've had a go changing the manifests reproduce True logic. Currently (on the main branch), it create symlinks to the work directory from the manifests, and only raise errors if the files that existing on the manifest are modified.
In the first commit, I changed logic in model setup to always add model exe path and prior restart path to the manifest. This picks up if exe path is changed in config.yaml. If there's new restart files, in the prior restart path, it will also pick it up that there's been a change.
It still had the logic that symlinks from files to the work directory are generated from the manifest initially when reproduce is True. This I feel could run into weird issues when there's a file in the manifest, thats existing unchanged on the filesystem, but it's no longer added to manifest in Model.setup. It'll pass the manifest checks because the hashes are unchanged and this file will still be symlinked into the work directory.
In the second commit, I have changed it to when reproduce is True, all the symlinks are created from filepaths added in the model.setup() when it calls manifest.add_filepath(). I have used the pre-existing existing_filepaths set on the PayuManifest class to keep track of what files haven't been added to the work directory but are in the manifest. There is now a check at the end of PayuManifest.fastcheck checking if that set is empty when reproduce is True.
The second commit, also has changes to the input/scanInputs logic. I've changed it to have scaninputs True when reproduce is True. This is so changes to inputs in config.yaml are picked up, or if new files are added to input directories.
scaninputs can be set to False, when reproduce is False. This is will still not check for changes in config.yaml as it'll create symlinks only from the input manifest. If a file in the manifest no longer exists, it will still be removed from the manifests before manifests are checked (only when reproduce is False).
I'll appreciate any feedback on these changes as it is changing the behaviour of reproduce:True quite a bit, and I'm unsure of my assumptions..

Hello @jo-basevi! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file payu/manifest.py:

Line 382:80: E501 line too long (81 > 79 characters)

In the file test/common.py:

Line 148:19: E222 multiple spaces after operator

coverage: 52.518% (+0.2%) from 52.281%
when pulling f14bfa5b250fd354e91d15886c7c09c45325dd57 on ACCESS-NRI:456-manifest-exe-true-bug
into c83489e1cf5af27f94aa8d255330cc50b6cb34fe on payu-org:master.

One goal of the original behaviour was to be able to re-run an experiment from any commit, by using the restart manifest to populate the restart file symlinks as they were at that commit. This would bypass the payu machinery for determining the restarts to use. The same goal is achieved by setting the restart path in config.yaml, but requires manual intervention of the user.
It is an open question as to the utility of this functionality. As far as I know no-one has used it, and with the typical workflow of using ephemeral /scratch storage it is likely the original paths to restarts will no longer exist.
One use-case is perturbation experiments branching from the same point in a control experiment. Each perturbation experiment could be a payu branch and then run with restart reproduce true for a single run to pick up restarts from the control experiment. To be honest I'm not sure if it is worth trying to keep this functionality for the reasons stated above. It is fragile to files being deleted/moved, and the same effective functionality is available setting the restart config option.

I've updated the manifests to keep track of the pre-existing manifest and to compare directly with the created manifests to try simplify some of the logic. A key difference is that previous manifests are used as source of truth for md5 hashes (this was previously the case for just input manifests). So if a calculated fast hash matches the fast hash in the previous manifest, then the full hash from the previous manifest is used. This is to avoid re-calculating any md5 hashes.
TODO:  Some changes to documentation

I'm doing some tests on performance, which is one of the key criteria for the design and re-use of manifest hashes etc.
The release-01deg_jra55_iaf config is definitely the worst in this regard, as it has all the JRA55-do forcing data in the manifest.
I'll report back what I find.

Timing looks similar after the first run of payu setup. I guess the files made it into some sort of lustre cache.
Typical timings for setup for both are
110.06user 145.29system 0:28.29elapsed 902%CPU (0avgtext+0avgdata 68016maxresident)k
133489472inputs+8202176outputs (4584major+362431minor)pagefaults 0swaps

for 708 files.
If the input manifest is deleted, forcing recalculation, the timing for this PR is
1484.73user 1696.42system 2:29.14elapsed 2132%CPU (0avgtext+0avgdata 65180maxresident)k
1664125624inputs+8202728outputs (12861major+1030049minor)pagefaults 0swaps

Current payu timing is
1650.39user 1556.04system 2:34.74elapsed 2072%CPU (0avgtext+0avgdata 50616maxresident)k
1662310320inputs+8202728outputs (2231major+1110215minor)pagefaults 0swaps

The times vary (I tried a couple of times) and likely it is very sensitive to disk usage and cache status.
Conclusion: this change does not degrade performance.

I only have one question: is it true that when reproduce = True the respective manifests are only written if there are no reproduce errors?

The binhash values may be updated, and maybe the fullpaths if they have changed? But that should only happen if all MD5 hashes match.

Conclusion: this change does not degrade performance.

That's great! Thanks for running those tests :) How did you run those timing tests?

Conclusion: this change does not degrade performance.

That's great! Thanks for running those tests :) How did you run those timing tests?

/usr/bin/time payu setup -f
You can pass command line arguments to that command to output all sorts of useful info, above is just the default. There is also a bash builtin time but it isn't as configurable and doesn't report memory usage.


board: stm32f3_seco_d23:  update name and refs

Due to board name change (JUNO -> SBC-3.5-PX30), it is necessary to update board names, links and references in files and documentation.
Closes https://github.com/zephyrproject-rtos/zephyr/issues/67169

Sorry, didn't see this one as this didn't get through the PR Assignee bot. Looks like there's now a merge conflict, that's bad luck!

@ektor5 can you rebase please?

You need to actually git rebase and then force push again. :-)

@fabiobaltieri I know, I know... just testing how intelligent was the GitHub webUI, nice but still not ideal. :sweat_smile:


[engsys] fix pnpm-lock.yaml

There's an error from previous commit which caused rush update to bump dependency versions. Normally only rush update --full does that.
This PR fixes pnpm-lock.yaml by checking out to a good and old version then run rush update

I don't see a change in xml dep here?

I don't see a change in xml dep here?

  The build break is installation error because of the dup


big rollback

What was this all about?

Yeah sorry about that I was trying to get Cookie Monster to work on version 2.0042 (I was playing here), and meant to do a pull request on my own fork but didn't realize it was a pull request on yours until after I had already accidentally submitted it

Ah okay, well there is the older version here, but it's missing the newer features.


Incorrect status code on bad credentials

Wrong password with correct username gives code 500:

Need to be fixed

@l3r8yJ, yours


using unocss in Angular

Hello, do you have any ideas to use unocss in Angular? Because I don't know how to config the unocss in Angular.
Thank you.

Hey, I am not as familiar with angular, but I think it uses webpack as build tool, so u can try this. https://uno.antfu.me/?s=guide:Setup+Webpack

Here's a demo of Vite + Angular. Maybe this would be a good start.


Spelling fixed in Age Calculator Title

Fixes Issue🛠

Closes #468
Description👨💻

There was a spelling error in the page title of the age calculator page. This has been replaced with the correct spelling.
Type of change📄

[X] Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

The page title is named with the correctly spelled word
Checklist✅

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added demonstration in the form of GIF/video file
[X] I am an Open Source Contributor

Screenshots/GIF📷

Merged 🎉 @KeyurGK


KAFKA-10000: Widely-used utility methods (KIP-618)

Adds some reusable utility methods for KIP-618 that facilitate:

Overriding (and logging a warning) user-supplied properties if they do not contain an expected value
Generating an array of the names (or, to be precise, toString representations) of every known value for an enumerable type (which is useful for defining ConfigDef validators in conjunction with existing validators such as CaseInsensitiveValidString)

Note that these utility methods are not used in this PR. They will be used in downstream PRs.

Thanks Mickael!


Write Premain errors to the response and write different status codes

Fixes https://github.com/aspnet/AspNetCore/issues/10011 and will eventually fix https://github.com/aspnet/AspNetCore/issues/10008.
Here is so backstory behind how ANCM writes error pages, and my initial thoughts on how to design dynamic vs static responses.
When ANCM hits a startup exception in the shim or in the request handler, an error "Application" is created, which serves static HTML or the Hosting Startup Error page. This needs to be expanded now to serve dynamic content from hostfxr or potentially from ANCM. Along with checking if disableStartupErrorPage is set, writing text/plain vs text/html, status codes, substatus codes, etc, having a single application to handle multiple failure points has become unmanageable.
I think we should probably redesign how we server error responses. My initial idea was to create an ENUM or key off of HRESULT to know what type of error occurred, and change the type of application/handler to create. An example of this is what I did with hostfxr errors, where I create a new handler and application. I think the best approach is to create a unique application/handler per type of error which just serves a single type of failure. Then, per each failure type, we can add more dynamic data (like stack trace, hresult, doc link, etc.) when running in development. There may be a good amount of duplication, but trying to cram everything into the same class is getting worse and worse (see ServerApplication.cpp).
If this plan looks good, I'll go ahead and follow through. I just want to confirm with someone before I do a decently size refactoring.

Some feedback I received from @shirhatti is that the error pages need work with regards to looking different than the default error page (they look too similar). Currently errors look like this:

This does have the necessary information, but it isn't presented nicely. We can consider doing more work on this in either this PR or a separate PR.

🆙 📅


File linked to .NET core project gets removed from the project when the BuildAction is set to AdditionalFiles from None.

Scenario:

Create a .NET core project and have a file linked to the project which has BuildAction=None.

  <ItemGroup>
    <None Include="..\abc\xyz.txt">
      <Link>xyz.txt</Link>
    </None>
  </ItemGroup>

Adding a link from Visual Studio 2017 doesn't seem to be possible. It makes a copy of the file in the project folder. So I edited the .csproj file. In our scenario we don't want to make duplicates of the file.

From Visual Studio, change the BuildAction to AdditionalFiles. The file disappears from the project.

@mavasani We added an additional files rule right? Did we also add it to the list of items that show up in the tree?
@aakash-johari When it disappears, do you mean the solution tree? Or do you mean that it's physically removed from the project file. Can you check the project file and see if it's present?

@davkean Yes, I verified additional files showed up in solution explorer after changing the build action. Let me attempt to repro @aakash-johari scenario on latest build.

@davkean  - you meant this file right: https://github.com/dotnet/roslyn-project-system/blob/master/src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/Rules/CSharp.ProjectItemsSchema.xaml#L13

Yeah, what is the that  thing, and where are the other content types? Perhaps we're inheriting them from MSBuild common targets./

Other content types and item types are here: https://github.com/dotnet/roslyn-project-system/blob/master/src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/Rules/ProjectItemsSchema.xaml#L61.

It looks like <ContentType/> refers to the ItemType - perhaps that is needed?

Ok, so I investigated further and this seems unrelated to AdditionalFiles, but is instead specific to linked files.

This issue does not repro if xyz.txt is just a regular file in the project tree with build action None.
This issue repros even if step 2 is changed so the new build action is something else (content, embedded resource, etc.)

So, I am seeing something weird happening here:

After the above repro steps, if I open the csproj on the disk, it still has the old ItemGroup with build action None.
If I invoke "Edit .csproj", then the item group doesn't show up in the csproj opened from the temp location.

Even clicking save all doesn't change the contents of csproj on the disk, it still has the old item group.

@davkean Yes the file is removed from the project file and hence no longer visible in the solution tree as well. I have updated the bug description with the .csproj file I used. I opened that project file in visual studio and changed the build action of the abc.xyz to AdditionalFiles. The file abc.xyz disappeared from the solution tree and even the entry from the .csproj file was removed.

@mavasani What's happening with this? Is this our bug or CPS?

I debugged this further and it looks like a CPS issue. We have correct old and new types inside ProjectItemProviderBase.OnItemIdentityChangedAsync and also invoke SourceItemsProvider_ItemsRemoved for old item and SourceItemsProvider_ItemsAdded for the new item, but somehow only remove seems to be working and we never add back the new project item.

I have ported this issue to CPS bug 371345: Changing the BuildAction within VS for a linked file which lies outside the project cone causes the item to disappear from the project file.

Also tagging @lifengl and @jviau as an FYI

I found the cause in CPS and am working on a fix. However, I found a bigger issue with msbuild: https://github.com/Microsoft/msbuild/issues/1598
Items outside the project cone are being matched to globs inside the project cone when using GetItemProvenance. This in this case, you cannot change the build action from Content back to Compile. We will match to the **/*.cs glob, consider it included, and fail.
@cdmihai suggested a workaround for now by changing the glob to $(MSBuildProjectDirectory)/**/*.cs.

@mavasani @jviau Is this intentional to make a copy of the linked file? Making a copy doesn't seem right. It  fails the basic idea of links where using a link to a file one could update the original file.

@aakash-johari What's the repro for making a copy of the linked file?

@davkean

Create a .NET core project.
Right click the project, choose "Add" and "Existing Item..."
Select a file that is not under the project folder.
You'll see a copy of the file in the folder where your .csproj file is present. i.e. your project folder.

That's not linking a item, that's adding a item. To link, you need to click the arrow next to the Add button and choose "add as link".
ie While surprising behavior - that's how it's worked for ~15 years.

Oh. My bad then. :( I didn't know about "Add as link". Thanks!

By the way, when is the insertion due for this? We tested the latest d15prerel and d15rel build and the issue still reproes there.


Reduce of empty array with no initial value

Uncaught (in promise) TypeError: Reduce of empty array with no initial value
at Array.reduce (native)
at ProductStore.getMaxAmountOfPossibleClients (http://localhost:5000/javascripts/app.js:5662:11)
at AdvertPlannerPanel.render (http://localhost:5000/javascripts/app.js:8933:49)
at renderComponent (http://localhost:5000/javascripts/app.js:371:61)
at rerender (http://localhost:5000/javascripts/app.js:140:47)

@IGGAMEMAKER add second argument to reduce, thus adding the initial value

@idchlife have already fixed it in


python3Packages.luxtronik: init at 0.3.9

Motivation for this change
Python library to interact with Luxtronik heatpump controllers
https://github.com/Bouni/python-luxtronik
This could become a Home Assistant dependency.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 146627 run on x86_64-linux 1

2 packages built:

python38Packages.luxtronik
python39Packages.luxtronik


Switch the logic in querying Kubernetes cluster config, and removed

Signed-off-by: Antonette Caldwell<EMAIL_ADDRESS>Notes for Reviewers
This PR switches the logic.
Anytime you use mesheryctl system status, it looks to see if you have the Kubernetes config on your local computer. However, the error message used for this situation was not correct.
I switch the name of the Error Code to the right place, and also removed
 from the line.
Also added newline in the appropriate place, but this can be changed.
Here is before:
./mesheryctl system status
Error: stat /home/phxvlabs-io/.kube/config: no such file or directory. Your local context is configured to run Meshery on Kubernetes using the Default token.
The Kubernetes cluster is not accessible. Please confirm that the token is valid. See https://docs.meshery.io/installation/quick-start for additional instructions

Here is the output after the changed.
./mesheryctl system status
Error: stat /home/phxvlabs-io/.kube/config: no such file or directory. Your local context is configured to run Meshery on Kubernetes using the Default token.
The Kubernetes cluster is not accessible. Please confirm that the cluster is running. See https://docs.meshery.io/installation/quick-start for additional instructions.

Signed commits

[ ] Yes, I signed my commits.

// @leecalcote @hexxdump
Okay done, forgot that line, I thought I had changed it, but missed the copy/paste

Codecov Report
Base: 16.64% // Head: 12.37% // Decreases project coverage by -4.28% :warning:

Coverage data is based on head (eda0aee) compared to base (b5cf2c1).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6983      +/-   ##
==========================================
- Coverage   16.64%   12.37%   -4.28%
==========================================
  Files         117      117
  Lines       16046    16063      +17
==========================================
- Hits         2671     1987     -684
- Misses      12894    13757     +863
+ Partials      481      319     -162

Flag
Coverage Δ

gointegrationtests
?

unittests
12.37% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/pattern/apply.go
23.83% <0.00%> (ø)

mesheryctl/internal/cli/root/system/error.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/system.go
63.88% <0.00%> (ø)

mesheryctl/internal/cli/root/system/token.go
50.76% <0.00%> (-1.20%)
:arrow_down:

mesheryctl/pkg/utils/error.go
0.00% <0.00%> (ø)

mesheryctl/pkg/utils/helpers.go
57.39% <ø> (ø)

server/handlers/user_handler.go
0.00% <0.00%> (ø)

server/router/server.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/start.go
1.56% <0.00%> (-54.07%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.51% <0.00%> (-53.79%)
:arrow_down:

... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


What is the license for the bpmpd library?

I noticed that the repository has a BSD license but what to make sure that also applies to the this library also. If not what is the license of the library?

What library? All I see are freaking binary blobs that are linked against


Update multicollateral DAI icon

Currency name: DAI
Symbol: DAI
Website: https://makerdao.com/en/
Theme color: That's a complex question.

Officially: #F4B731 (both listed on their website, and present in the zip's Logos > SVGs > Logo_Dai.svg)
In the zip, there's a badge icon with a gradient starting at: #FBCC5F
Also seen in the wild: #EAB24B, depending on the icon kit used, or if there's a gradient present.

Logo official kit: https://www.notion.so/Maker-Brand-ac517c82ff9a43089d0db5bb2ee045a4
Logo flat in a circle, like others in this package (SVG): https://cryptologos.cc/logos/multi-collateral-dai-dai-logo.svg?v=008
Coinmarketcap's PNG version: https://s2.coinmarketcap.com/static/img/coins/64x64/4943.png

Download Maker, MKR and DAI logo kit.zip
Maker has rebranded DAI and changed the logo, though there seem to be a few variants floating around in the wild for their new logo, none are referencing the old one with the Unicode ⬙ symbol any longer:
https://blog.makerdao.com/creating-the-brand-identity-for-the-worlds-first-unbiased-currency-dai/
Unfortunately their badge SVG directory has no flat variant, so I tried my hand at importing the new logo into the same format as the legacy DAI.svg (commit 9a28318)
I'm not well versed in editing SVGs, so there are some details like the viewBox and circle values which differ because I don't know how to properly scale the path:
<svg viewBox="0 0 600 600" xmlns="http://www.w3.org/2000/svg" ><g fill="none"><circle cx="300" cy="300" r="300" fill="#F4B731"/><path d="M477.9 250.5h-35.6c-19.6-54.4-72.3-91.7-141.8-91.7H186.2v91.7h-39.7v32.9h39.7v34.5h-39.7v32.9h39.7v90.6h114.3c68.7 0 121-37 141.1-90.6h36.3v-32.9h-28.3c.7-5.8 1.1-11.8 1.1-17.8v-.8c0-5.4-.3-10.7-.8-15.9H478v-32.9zm-259.7-62.4h82.3c51 0 88.9 25.1 106.4 62.3H218.2v-62.3zm82.3 223.7h-82.3v-61.1h188.5c-17.6 36.6-55.4 61.1-106.2 61.1zm117.1-111c0 5.8-.4 11.5-1.2 17H218.2v-34.5h198.3c.7 5.4 1.1 11 1.1 16.7v.8z" fill="#fff"/></g></svg>

We should use #F4B731 and not the colors from the gradient.

Done in v0.17.1.

Done in v0.17.1.


refactor: add lint step and fix linting issues

Signed-off-by: ankitm123<EMAIL_ADDRESS>

/cc @rawlingsj

/hold
go-plugin-multiarch does not have make-lint step.

/test pr

/hold cancel

sonarcloud checks can be ignored, as they are unrelated to my changes ....

/test all


Rename instances of lint to check

Following up the PR #654 , this PR renames the lint into check inside the website

Thank you so much! Looks good!


Map Timeline Single Date Selection

This issue implements the usecase Map Timeline Single Date Selection

There is a library that looks promising but has other peer dependencies that I do not want to bring into the project.
https://github.com/namespace-ee/react-calendar-timeline

I already looked at it and didn't even find an option so that looks like how we want it. Did I miss something?

I think like this, it looks quite similar.
https://codesandbox.io/s/timeline-demo-sticky-header-forked-3t7hm0?file=/CustomTimeline.jsx

It is also quite different, we don't need that the day is split in smaller units and we also don't need text per day but a graph of how many occurrences were at which day. So something like what video-players have, e.g. youtube where you see the number of watches (but we need number of changes in the map on that day).
Maybe we can reuse something from video players, and change the scale from seconds to days?

There are some small updates about this UC (basically what we already said) in #454

A probably more simple (than what we originally imagined but not more simple than a date picker) implementation of timeline could be done via server-side SVG.  See https://alexplescan.com/posts/2023/07/08/easy-svg-sparklines/ for inspiration.
We would basically write the dates with an SVG path below/around (indicating how many actions on the elements happened each day). The question is how clicking on the dates then actually would lead to the right action. Is this possible with react-svg?
If you think this makes somewhat sense, please write this as implementation hint linked the left-over of the use case.

I would then prefer to use a graphing library that comes with click handling on datapoints.
One that I already used is react-charts.

Yeah, if you already used it the choice is obvious. Then let us forget the idea with SVG. Anyway, we won't do it for this user study.


UdpSocketClient.SendToAsync() not working on Android 5.1.1?

Notice: I doubt this is an issue with Sockets For PCl, BUT I hope someone has some insight:
I have some code that uses UdpSocketClient.SendToAsync() to send commands over a wired network (via usb-ethenet adapter) on Andr.4.4.1, but appears to fail on 5.1.1.  I can get incoming UDP broadcasts, but the device to which I am trying to send data doesn't seem to get my packets when the same code is run on 5.1.1(lolipop) instead of 4.4.1(kitkat).
Has anyone seen anything like this?

This is an issue with switching from dhcp to static ip configuration on Samsung tab s2, it appears. After some patience, I figured out the right sequence to get static settings to stick and work.


before and after events are not working

The nuts.before and nuts.after events are not firing after the refactor

Any updates on this?


Support INotifyDataErrorInfo, rename ISupportsValidation

What kind of change does this PR introduce?

This PR introduces a set of two major changes, one of them is breaking:

The ISupportsValidation interface is refactored into IValidatableViewModel, to match the new ReactiveUI 10 activation-related things naming, e.g. IActivatableViewModel;
The abstract base class ReactiveValidationObject<TViewModel> is added, which encapsulates INotifyDataErrorInfo support for platforms such as WPF, Avalonia, Xamarin.Forms. Closes https://github.com/reactiveui/ReactiveUI.Validation/issues/37

What is the current behavior?

Currently, INotifyDataErrorInfo isn't supported and ISupportsValidation isn't renamed.
What is the new behavior?

INotifyDataErrorInfo is supported, ISupportsValidation is renamed to IValidatableViewModel.
What might this PR break?
Existing code bases which rely on the ISupportsValidation interface naming may break, so probably we should document the update instructions. Also, a small bug causing a Sequence contains no elements exception was fixed https://github.com/reactiveui/ReactiveUI.Validation/blob/master/src/ReactiveUI.Validation/ValidationBindings/ValidationBindingEx.cs#L151
Please check if the PR fulfills these requirements

[x] Tests for the changes have been added (for bug fixes / features)
[x] XML Docs have been added / updated (for bug fixes / features)

stylecop is complaining, will fix the issues on a machine with Windows and VS2019 today.


Integrate standard benchmarks with integration tests

Process:

Get benchmark compiled and configured such that it provides good performance on one important HPC system.
Document process above and results from running the benchmark on our internal wiki.
Find common scripting between all wiki pages for different benchmarks.
Refactor scripts documented on wiki to merge with integration tests.

#807 for AMG

Having these tests running in regular/nightly testing will help detect performance regressions.


fix dev building (old)

@stephenandrews does this fix npm start for you? I was able to repro npm start hanging and this fixes it for me while keeping the production build healthy.

Prevent chunking in dev mode.
Don't polyfill Node.js crypto module for frontend. We never import it (same as the stream module which also is ignored in the config override.)

Note that production builds didn't complain about it missing so this is fine. No need to increase bundle size.

Ignore missing source maps from node_modules since we can't do much about that.

Uh whoops, didn't mean to close this. Must've accidentally clicked the close button.

Superseded by #17


JSON to have newlines to improve human readability

Robert: "I would like the JSON that I can download to have newlines to improve human readability, and I wonder why it is a list of lists, rather than an object of objects: I had expected sections such as design_and_sample, hardware, etc."

Consulted Dejan - he did not consider human readability given the PDF output. He can fix this, but the way things are is easier for him. If there are additional benefits, he can make the change. Let's see with Dejan and Robert.


[ITEM] - Ink Sac

Item name:
Ink sac
Current method of obtaining:
Killing squid
Link to wiki:
https://minecraft.gamepedia.com/Ink_Sac

Baked coal? Stonecuttered coal? Some kind of coal/water suspension? Charcoal/water suspension?

Black dye now craftable by stonecuttering charcoal

As raised in the VegCraftForge fork, other mods may rely on the existence of Ink Sac - they suggest "Charcoal + Water Bottle -> Ink Sac" as a sensible recipe, which I am inlined to agree with. Implement this.


dj-tracker UI login system

How can I limit the information dj-tracker provides so that only admins can see it? a login page maybe.

Hey @Natgho, yes, I think a login page will do it if you include the dj-tracker urls under a path that requires authentication (using the login_required decorator for example).
I assume people mostly used locally, for debugging purposes, hence the lack of authentication.

Hey @Natgho, there aren't authentication checks to access the dashboard as I assume people mostly use dj-tracker locally, for debugging purposes.
To limit dashboard access, you could add a decorator that requires a user to be logged in:
dj_trackers_urls = [path("dj-tracker/", include(dj_tracker_urls))]

urlpatterns += decorate_urlpatterns(dj_trackers_urls, require_admin_access)

You can find an implementation of decorate_urlpatterns and require_admin_access in the Wagtail source: here and here.
I hope this helps.

Hi @Tijani-Dia ,
Thank you for your answer. I will try the method you mentioned and return.
How about adding it as built-in with a key called "login" under settings?
https://tijani-dia.github.io/dj-tracker/configuration/
DJ_TRACKER = {
    "LOGIN": True # or False
}

Sounds good.
That's a nice suggestion. However, as I mentioned above, I think most people use dj-tracker locally meaning they won't need authentication. I'll be happy to add it if more people request it or when dj-tracker is mature enough to be used on a production environment.

Actually, the idea came from here, we realized that we were querying too many DBs query in our production environment and we wanted to determine which endpoints were querying these queries. This is how I met dj-tracker :)
I will prepare a PR to add this as built-in.

Oh, interesting! Have you already used it on production without issues? It may not work nicely in a multiprocessing environment as each process has a worker thread and they can have conflicting write queries resulting in integrity errors sometimes. That's on my to-do list.
A PR (for this and anything else) would be more than welcome.

Hmm, yeah, you're right. No, I haven't integrated it yet. I tried dj-tracker locally today and it worked fine. But our production environment is on k8s and works with 5+ pods. It is quite possible to encounter problems like deadlock. Tomorrow I will share this plan with my technical team leader, as far as I can see from the source code, conflicts will not block the flow of the code, only some queries may not be recorded by dj-tracker. What do you think?
I'll be sure to write about the bugs if I run it in production. So this project can move forward. I think it's a very useful app.

That's exact, when an error occurs in one of the worker threads, it'll just stop recording the queries in that process. It shouldn't affect the flow at all as you said.
A quick work around the race condition issue I mentioned may be to set the ignore_conflict flag here.
Note: I have work in progress to make it work in a multiprocessing environment, hopefully I'll wrap it up soon.


Ops stacks

What do these changes do?

[x] adds adminer stack
[x] adds minio stack (deploys for both single and distributed mode)

Related issue number

links osparc-simcore#575
Checklist

[ ] I think the code is well written
[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes
[ ] Runs in the swarm
[ ] If you design a new module, add your user to .github/CODEOWNERS

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #19   +/-   ##
======================================
  Coverage    85.1%   85.1%
======================================
  Files          20      20
  Lines         685     685
======================================
  Hits          583     583
  Misses        102     102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19a8a9...6a1c598. Read the comment docs.


feat: traps should go to events

:tada: This PR is included in version 0.11.0-beta.44 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Auto pause for captcha

Will automatically pause (turn off) Current/Heal status (if on) when captcha appears, and will revert Current/Heal status to the previous state after captcha is filled.

I really liked the idea to pause, but the way it is now it will annoy people that uses skill timer to use some pots. I will change a little but take some of your code, link your discord for credits on this feature. Thank you very much :)


Update ReadMe and Typos

Changes
Updated the ReadMe and a few other text changes
Checklist

[x] have tested my change

@SJLennon Wow, thanks - this is awesome. You are awesome too!


Icon display is not clear under "High Contrast On" mode.

Repro step:

Navigate to https://makecode.microbit.org/beta
Click "More... " and choose "High Contrast On"
Then click " ?(Help) " and choose "Getting Started"
Choose "step 7" and click "Finish"

Expected result:
Under "High Contrast on" mode, the icon should shows clear like following picture:

Actual result:

The issue still repro, for some changes, new rero steps:
Click "Projects" -> "Projects" ->"Flashing Heart" ->Click to the seventh step -> click "Finish"

Won't fix. Fixing this is non trivial and the icon is aesthetic and not crucial.


Fixing path to output directory for _sources

In #339 I introduced a fix for the _sources directory path that works with the default sphinx Makefile. But I have since discovered that this doesn't work with a custom output directory (as used by ReadTheDocs, for example). This updated PR should do the trick more generally. Sorry about the noise!

oops I missed this PR, sorry! Is there a way that we can confirm this really solves the problem this time? E.g., is there a test that could make it fail w/o this PR, and passes with this PR?

No worries at all! I'll do some poking around and see what I can come up with.

@choldgraf: ok - I added a test that checks to make sure that the ipynb generated for a myst notebook ends up in the right _sources directory. It uses subprocess because I couldn't figure out how to pass outdir to sphinx_build_factory. Happy to update if there is a better way. This fails on master but passes with this fix. Thanks!

Nice - that seems reasonable, I added in a comment to make it clear why we're using sphinx-build there. Thanks for this improvement!


Fix ThermalStandard must_run in tabular data parser

Thanks for opening a PR to PowerSystems.jl, please take note of the following when making a PR:
Check the contributor guidelines

Fix tabular data parser to parse must_run  for ThermalStandard
Issue Fix

Using parse is dangerous during runtime applications. It's better to employ a string comparison

Using parse is dangerous during runtime applications. It's better to employ a string comparison

The only reason I was usingparse was because must_run could be either a true/false (or) 1/0 which could be parsed as a String by the CSV parser (because of 'NA' values). Should I use stringcompariosn for all these cases then?


Fixing Stage 3 dirpath issue

I just ran through the quickstart on the main branch and bumped into an issue where if the topdir for Stage 2 didn't match the topdir for Stage 3, then an error gets raised.
STAGE2
# Project directory
topdir         /Users/acarter/Documents/TRANSITS/EUREKA

# Directories relative to project dir
inputdir       /QUICKSTART_DATA/NIRSpec   # The folder containing the outputs from Eureka!'s S2 or JWST's S2 pipeline (will be overwritten if calling S2 and S3 sequentially)
outputdir      /QUICKSTART/Stage2

STAGE3
# Project directory
topdir         /Users/acarter/Documents/TRANSITS/EUREKA/QUICKSTART

# Directories relative to project dir
inputdir       /Stage2   # The folder containing the outputs from Eureka!'s S2 or JWST's S2 pipeline (will be overwritten if calling S2 and S3 sequentially)
outputdir      /Stage3

I've figured out a quick fix for now, which is to change the following line (454 in s3_reduce):
 meta.inputdir = os.path.join(s2_topdir, s2_outputdir)
to
 meta.inputdir = os.path.join(meta.topdir, s2_outputdir)
But I'm not 100% sure this is the best route to take / whether I'll just break things in a different situation.
Either way, I think it would be valuable to be able to have different topdirs between Stages. Particularly stage 1, 2, and 3, as they might use files in a different directory than the save directory (i.e. where you're keeping your JWST data).

This should already be handled by my PR #305 - can you try running with that branch rather than main and confirm whether the issue is resolved there already?

@AarynnCarter can you confirm that this is no longer an issue for you using the updated code in the main branch? If so, we can close this PR

Hi Taylor,
As a quick reply, I’ve caught covid and am stuck in a hotel in London, so won’t be able to take a look at this until next week at the earliest.
Cheers,
Aarynn

On 10 May 2022, at 21:05, Taylor James Bell @.***> wrote:

@AarynnCarter can you confirm that this is no longer an issue for you using the updated code in the main branch? If so, we can close this PR
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

Oh yikes, okay I'll double check this myself then and close the PR if it works for me now. Hope you recover quickly!


Created a bash script to automate the process of .env file creation and also GITPODIFIED the repo.

Bash script automates the process of .env file creation and with the help of it I created a gitpod config for this repo so developers don't have to go through the hassle of manual configuration and can make changes on the cloud ide on the go.

Hey! Thank you for the suggestion, but we'd prefer not to add a bash script for this.