Reporting whether virtualization is enabled/disabled

Is your feature request related to a problem? Please describe.
I think showing status of virtualization support in the output of .cpu() can be useful.
Describe the solution you'd like
Get the status of virtualization support. On UNIX operating systems virtualization can be detected from CPU flags vmx (Intel) and svm (AMD). I wasn't able to find an easy way to check virtualization on Windows?
Suggested behavior
si.cpu()
---
{
  manufacturer: 'Intel®',
  ...
  virtualization: false
}

Describe alternatives you've considered
I considered checking CPU flags in my code, but that doesn't help with checking virtualization status on Windows. Also I think this functionality seems like a good addition for systeminformation package.

@ssmirr ... good idea. Will provide a solution for that. Guess I have an idea also for windows.

cool, thanks @sebhildebrandt! looking forward to it.

@ssmirr will be introduced in upcoming version 5. Should be available within the next 2-3 weeks

@ssmirr will be introduced in upcoming version 5. Should be available within the next 2-3 weeks

@ssmirr Version 5.0 just released. .si.spu() now contains the virtualisation attributebute.
Be aware: Version 5 is NOT fully backwards compatible to version 5 ... see https://systeminformation.io/changes.html to get an overview over all breaking changes.

@ssmirr Version 5.0 just released. .si.spu() now contains the virtualisation attributebute.
Be aware: Version 5 is NOT fully backwards compatible to version 5 ... see https://systeminformation.io/changes.html to get an overview over all breaking changes.

awesome, thanks a lot @sebhildebrandt! I will check it out 🚀

awesome, thanks a lot @sebhildebrandt! I will check it out 🚀

@sebhildebrandt I just tried si.cpu() version 5.0.2, it works nicely on macOS, but on Windows it doesn't seem to report correct virtualization status.
On my Windows PC with virtualization enabled (I even have virtualbox VMs running right now), si reports virtualization: false. How does si check virtualization status on Windows?
For our usecase, we've been checking the output from systeminfo command on Windows until now, and make sure Virtualization Enabled in Firmware: Yes is present:
Hyper-V Requirements:      VM Monitor Mode Extensions: Yes
                           Virtualization Enabled In Firmware: Yes
                           Second Level Address Translation: Yes
                           Data Execution Prevention Available: Yes

@sebhildebrandt I just tried si.cpu() version 5.0.2, it works nicely on macOS, but on Windows it doesn't seem to report correct virtualization status.
On my Windows PC with virtualization enabled (I even have virtualbox VMs running right now), si reports virtualization: false. How does si check virtualization status on Windows?
For our usecase, we've been checking the output from systeminfo command on Windows until now, and make sure Virtualization Enabled in Firmware: Yes is present:
Hyper-V Requirements:      VM Monitor Mode Extensions: Yes
                           Virtualization Enabled In Firmware: Yes
                           Second Level Address Translation: Yes
                           Data Execution Prevention Available: Yes

Update: I see this in the implementation of si.cpu()
https://github.com/sebhildebrandt/systeminformation/blob/cb2c057294c7ce1d94a3f6591d8ee3251ea2e709/lib/cpu.js#L552
This is actually how we've been checking virtualization on macOS/Linux.
But on Windows with intel CPU I don't see vmx cpu flag reported by si 🤔

Update: I see this in the implementation of si.cpu()
https://github.com/sebhildebrandt/systeminformation/blob/cb2c057294c7ce1d94a3f6591d8ee3251ea2e709/lib/cpu.js#L552
This is actually how we've been checking virtualization on macOS/Linux.
But on Windows with intel CPU I don't see vmx cpu flag reported by si 🤔

@ssmirr ... ok, will try to implement it this way ...
Can you check if this (from Powershell):
Get-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V

output give you the same result as your approach? My main question is, which one is faster ... can you provide both outputs?
Thank you in advance!

@ssmirr ... ok, will try to implement it this way ...
Can you check if this (from Powershell):
Get-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V

output give you the same result as your approach? My main question is, which one is faster ... can you provide both outputs?
Thank you in advance!

Please find the outputs below. I also included some suggestions from my experience with virtualization which I hope will help (sorry kinda too long).
So my understanding is these commands two check different things.
On Windows there are two things to be aware of:

Virtualization status (configured in BIOS) and can be checked in output from systeminfo command (There will be this line if enabled: Virtualization Enabled In Firmware: Yes)
Hyper-V status (configured in Windows features and requires ^ virtualization in BIOS settings be enabled) and can be checked two ways, your command above (required Administrator), or systeminfo command (There will be this line if enabled: Hyper-V Requirements: A hypervisor has been detected. Features required for Hyper-V will not be displayed.)

Important note / Suggestion:
You probably know this, but I think worth mentioning here.
For VirtulBox to work Hyper-V must be Disabled! So one can only use either VirtulBox/VMWare hypervisor or Hyper-V at a given time. Because of this, it might make sense to including two things in si.cpu() report: { virtualization: true, hyperv: false } or { virtualization: true, hyperv: true }.
> systeminfo
---

OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.19042 N/A Build 19042
OS Manufacturer:           Microsoft Corporation
...
Hyper-V Requirements:      VM Monitor Mode Extensions: Yes
                           Virtualization Enabled In Firmware: Yes
                           Second Level Address Translation: Yes
                           Data Execution Prevention Available: Yes

Get-WindowsOptionalFeature requires elevation to Administrator rights, probably not ideal.
My virtualization is enabled here, but my Hyper-V is disabled:
> Get-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V
---

FeatureName      : Microsoft-Hyper-V
DisplayName      : Hyper-V Platform
Description      : Provides the services that you can use to create and manage virtual machines and their resources.
RestartRequired  : Possible
State            : Disabled
CustomProperties :

Please find the outputs below. I also included some suggestions from my experience with virtualization which I hope will help (sorry kinda too long).
So my understanding is these commands two check different things.
On Windows there are two things to be aware of:

Virtualization status (configured in BIOS) and can be checked in output from systeminfo command (There will be this line if enabled: Virtualization Enabled In Firmware: Yes)
Hyper-V status (configured in Windows features and requires ^ virtualization in BIOS settings be enabled) and can be checked two ways, your command above (required Administrator), or systeminfo command (There will be this line if enabled: Hyper-V Requirements: A hypervisor has been detected. Features required for Hyper-V will not be displayed.)

Important note / Suggestion:
You probably know this, but I think worth mentioning here.
For VirtulBox to work Hyper-V must be Disabled! So one can only use either VirtulBox/VMWare hypervisor or Hyper-V at a given time. Because of this, it might make sense to including two things in si.cpu() report: { virtualization: true, hyperv: false } or { virtualization: true, hyperv: true }.
> systeminfo
---

OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.19042 N/A Build 19042
OS Manufacturer:           Microsoft Corporation
...
Hyper-V Requirements:      VM Monitor Mode Extensions: Yes
                           Virtualization Enabled In Firmware: Yes
                           Second Level Address Translation: Yes
                           Data Execution Prevention Available: Yes

Get-WindowsOptionalFeature requires elevation to Administrator rights, probably not ideal.
My virtualization is enabled here, but my Hyper-V is disabled:
> Get-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V
---

FeatureName      : Microsoft-Hyper-V
DisplayName      : Hyper-V Platform
Description      : Provides the services that you can use to create and manage virtual machines and their resources.
RestartRequired  : Possible
State            : Disabled
CustomProperties :

@ssmirr thank you for your detailed answer! Will make some tests on my machines and will come back with a solution the next days.

@ssmirr thank you for your detailed answer! Will make some tests on my machines and will come back with a solution the next days.

Thank you! Let me know if you want me to check anything else.
btw this is how we've done it so far, if it helps:
https://github.com/ottomatica/virtcrud/blob/6d239f9c85251d0d13bcc64250f21f4c21ecfaeb/providers/util.js#L179-L222

Thank you! Let me know if you want me to check anything else.
btw this is how we've done it so far, if it helps:
https://github.com/ottomatica/virtcrud/blob/6d239f9c85251d0d13bcc64250f21f4c21ecfaeb/providers/util.js#L179-L222

@ssmirr just released version 5.0.3 which should fix this ... I added detection also for German and French language as the systeminfo output unfortunately is localized.
Can you give it a try?

@ssmirr just released version 5.0.3 which should fix this ... I added detection also for German and French language as the systeminfo output unfortunately is localized.
Can you give it a try?

Thanks @sebhildebrandt, I just tried it and now it works on Windows as well 👍
I wasn't able to find if a property was added in the report for checking Hyper-V status?

Thanks @sebhildebrandt, I just tried it and now it works on Windows as well 👍
I wasn't able to find if a property was added in the report for checking Hyper-V status?

@ssmirr ... I addd this now to osInfo() as this is not really a cpu() property. Just pushed a first version to GitHub. Would you like to test it on one of your windows machines? Simple testing is described here: https://systeminformation.io/tests.html, and inside the test suite just press o for osInfo() and review results ;-)
If this is fine from your perspective, I will release a new version with this enhancement.
Thank you for your help, your idea and your patience!

@ssmirr ... I addd this now to osInfo() as this is not really a cpu() property. Just pushed a first version to GitHub. Would you like to test it on one of your windows machines? Simple testing is described here: https://systeminformation.io/tests.html, and inside the test suite just press o for osInfo() and review results ;-)
If this is fine from your perspective, I will release a new version with this enhancement.
Thank you for your help, your idea and your patience!

@sebhildebrandt I agree, having it separately in osInfo() makes sense. I tested the hyper-v status (both enabled and disabled) and it works great! 👌
Thank you for making systeminformation and always adding improvements!

@sebhildebrandt I agree, having it separately in osInfo() makes sense. I tested the hyper-v status (both enabled and disabled) and it works great! 👌
Thank you for making systeminformation and always adding improvements!

@ssmirr Hi again, I would like to ask for some further assistance: As systeminfo spits out language dependent labels, I would like to modify the method used in my package. Currently I only support EN, DE and FR, but if there are other system languages, this would fail.
Could you once again make a test with virtualization enabled and disabled and then running THIS from powershell:
Get-ComputerInfo -property "HyperV*"

and post the output here?


Relationship handling in non-transactional context

This is a summary of #476, #477 and further analysis.
Problem description
If OGMs session methods are used without any explicit transaction around the unit of work, it will come to some unexpected outcome. Sample:
// Setup
A a = new A();
B b = new B();
a.b = b;
session.save(a);

// Block 1
A a = session.load(A.class, a.id);
// simulate separated sessions/transactions
session.clear()

// Block 2a
a.b = null;
session.save(a);

// Block 2b
a.b = new B();
session.save(a);

The outcome of this sample won't make any change to the relationship A->B because the relationship is not in the session context anymore when it comes to updating the entity in block 2.
Longer description:

The setup block is just to draw the sample dataset. This could also be already existing data in Neo4j.
Block 1 pulls the desired object from the database through OGM into a Java object and also registers all found relationships (and more) in a session context. The session.clear() afterwards removes all the metadata from the session context incl. relationship informations. This looks a little bit odd for a productive use case but this is the explicit form of how an operation within Spring Data Neo4j (where the issue came up) works. If there is no explicit transaction around the unit of work, SDN will just open a new session with a new transaction.

myAclassRepository.findById(a.id); // equal to block 1 above

Now the relationship gets removed on a Java object level and we save the entity (block 2a). Because this is a fresh session it has no context populated with any relationship information and as a consequence of this it does not notice that there was a relationship before. The only information left is a null field on the entity that does not trigger any creation.
Looking at block 2b we can see that we now provide a new B object instead of null. Instead of ignoring the relationship OGM now creates a new one (and new B node) because the relationship field is populated. This will end up in multiple relationships for 1:1 connections.

Open for analysis:
[] What happens in collections of direct linked entities
[] Do RelationshipEntity relationships have the same problem
Solving idea(s)
Just for updates
When an entity is about to get saved we could prefix the cypher query with a delete non existing entities. This will only work if there is a update to the relationship but not for null values because the entity might have been loaded with a depth=0 that excludes all relationships and results in null for every one.
Collections
Assuming the problem also exists for collections we could support the removal by providing a empty collection to the entities relationship property. An update will have to look into all end nodes and compare them with the ones in the updated relationships.
Open questions
[] How to support a single relationship removal?

It took some time to discuss and evaluate the possible solutions for this problem.
Even though Spring Data Neo4j and Neo4j OGM aim to give the developers a more convenient access to the database, we cannot hide the fact that a unit of work must be wrapped in a transaction on its own.
We discussed multiple approaches how to solve the null value for a relationship when a node is saved.
You may ask, why this is a problem?
Two samples how to get null into a previous existing value on a node:

The value was set to null (obvious)
The node was loaded with a horizon/depth of 0. No related fields will be loaded at this point.

Now we trigger the save method and OGM cannot decide what to do.
Because there is no ongoing transaction the information if there were any relationships before is not cached and OGM will assume "everything" is new or in the null case ignore the relationship persistence (delete).
Without any surrounding transaction it is not possible to know how the new values in the entity object should be interpreted.
There is just the state of an object that should be saved and does not have a history (in the session cache).
Additionally I do think that developers will face the problem in Neo4j OGM not so often because they would have to call session.clear() explicitly within a unit of work.
From the SDN view it is more hidden because if there is no ongoing transaction to join SDN will always create a new one and with it a new session.
I can only advice all SDN devs to use explicit transactions around their unit of work because the problem could not be solved with a "one-fits-all" solution and also might introduce a behaviour change that I would try to avoid.


perf: Modify the class display method in table, tabs, ripple and lazy

Checklist

[ ] Modify class display method

Change information

Codecov Report

Merging #391 (b773053) into dev (799ba2d) will increase coverage by 0.00%.
The diff coverage is 93.33%.

@@           Coverage Diff           @@
##              dev     #391   +/-   ##
=======================================
  Coverage   96.43%   96.43%
=======================================
  Files         209      209
  Lines        4959     4966    +7
  Branches     1015     1012    -3
=======================================
+ Hits         4782     4789    +7
  Misses        173      173
  Partials        4        4

Impacted Files
Coverage Δ

packages/varlet-ui/src/tabs/Tabs.vue
82.71% <85.71%> (+0.43%)
:arrow_up:

packages/varlet-ui/src/lazy/index.ts
95.32% <100.00%> (ø)

packages/varlet-ui/src/ripple/index.ts
97.67% <100.00%> (+0.02%)
:arrow_up:

packages/varlet-ui/src/table/Table.vue
100.00% <100.00%> (ø)

packages/varlet-ui/src/tabs-items/TabsItems.vue
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799ba2d...b773053. Read the comment docs.


Clarify get-scala goal/contribution opportunities

Add an "about" link to the top-level navigation, to describe why get-scala.org exists and what it's goals are. Copy the "about get-scala.org" content to a separate chapter in the readme.
Split the contribution page in to two sections

contributions to Scala
contributions to get-scala.org

Describe what and how people can contribute to get-scala.org. Link "about" <-> "get-scala.org contributions"

Great idea, thanks!

I wrote http://get-scala.org/about today, but I realized that we had this ticket only right now. At least there is some content, might make it easier to split and reorganize things ... :-)


Has anyone tried to use DT-DETR or similar instead of YOLO in BoT-SORT?

I do think ut would be a nice idea, although I haven't had time to test it.
My RT-DETR test are usually better than YOLO.
Regards,

do you trained RT-DETR with other datasets like crowdhuman，citypersons...


Remove MXEventDirectionSync

Fixed https://matrix.org/jira/browse/SYIOS-207.
MXEventDirectionSync was used to identify events coming from an initialSync. They were managed differently than MXEventDirectionForwards events which came from /events.
In sync v2, everything comes from a single API, /sync, MXEventDirectionForwards. It is no more possible to make such distinction.
MXEventDirectionSync has been removed. MXEventDirection* has been renamed to MXTimelineDirection*.
MXEventTimeline.m has been refactored to match sync v2 mechanism better (no more handleLiveEvent for example as live event has no more sense with /sync v2).

LGTM


Add unmap support for jiva volume

Description

When any data is written at the client side (iscsi) it is replicated to all the n no of jiva replicas. If the space is freed from the client side it is not freed at the replica side because jiva frontend (gotgt) doesn't support unmap.
Context

Since replicas consume some storage space unnecessarily, it should also do cleanup at the replica side.
Possible Solution

Jiva replicas implement unmap but it is not enabled from the [frontend]  (https://github.com/gostor/gotgt) for remote backend. So implementation at frontend side is required to support this feature.
Also if this volume needs to be used for some other applications/databases, it is still usable and the data will be overwritten at the replica side and replica will reclaim the space.
Screenshots

@utkarshmani1997 Is this issue related? https://github.com/longhorn/longhorn/issues/836

It is @SeMeKh


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1710

Questions ?
Please refer to the Backport tool documentation


AppVeyor Challenge

Details of the scenario you tried and the problem that is occurring
AppVeyor automatically grabs the SharePoint Online Management Shell msi from the web and installs it on the Build Agent. However, whenever the link changes (new version released) like it happened on January 2nd, then AppVeyor crashes because it gets a 404 trying to download the msi. We need to upload a static version to some stable location.
Verbose logs showing the problem
N/A
Suggested solution to the issue
The DSC configuration that is used to reproduce the issue (as detailed as possible)
N/A
The operating system the target node is running
N/A
Version of SharePoint that is used (e.g. SharePoint 2016)
N/A
Version and build of PowerShell the target node is running
N/A
Version of the DSC module that was used ('dev' if using current dev branch)
N/A

Can't we add a specific version to the repo?

@ykuijs your recommendation was implemented. We now have a static version of the MSI included. Closing the issue.


Frontend rewrite with freemarker templates, matching Ore design!

Hey guys! I've been working on a full frontend rewrite for a while and now I'm finally ready to show this to you, going back to the all beloved freemarker templates! I have taken it upon myself to just port the Ore frontend with slight adjustments, so here are a few examples of how it currently looks like:
Organization and project creation have a simple, yet wonderful look to them, with functionality the current frontend does not have:

Version channel editing is back to its old glory with amazing looking color selectors:

Logs are as powerful as ever with different colors and clickable info links:

And here is a preview of the project main page; instead of the member edit button being smaller than the pages plus button, I have made it the other way around, as a cheeky easter egg ;)

I am eager to receive feedback on this new frontend rewrite, I'm sure it's finally going to be the last one! It simply needs some slight adjustments to the build script so it can build again.

https://www.youtube.com/watch?v=wKbU8B-QVZk

Hmm it seems like I somehow copied the frontend from 2020 by accident. Whoopsie

!


does it work?

Looks like I'm missing the point.
I expected the sample output to display something with 3D feeling from test camera.
yet I get regular structure all over the field

Am investingating an idea to push these guys to consider printing Seene....
http://3d-crystals.ru/order/
https://imaage.com.au/3D-Crystal/3D-photocrystals
(not affiliated with any of these parties, nor with Seene itself, just a user)
Awing at your reverse engineering patience!

Hey, thanks!
It does work. The problem is there was no way to control the camera so it looked like nothing. I added mouse camera controls. You should be able to rotate, zoom and pan to explore the scene.
Make sure you run local HTTP server not just opening index.html in the browser. I wouldn't work with Chrome (it might with Firefox). I use python -m SimpleHTTPServer. Easy peasy.

Thanks, a lot! (Спасибо!)
I've just published a small backup script.
https://github.com/neopaf/seene-backup/blob/master/README.md


Fix ansicolors codes for windows terminal.

The high and low intensity color codes (ansi-color names) seem to be swapped by prompt-toolkit on windows.
This PR fixes this. Now teal is the dark color, and ansiturquoise the light color. The same goes for the rest of the color names.

@melund: Thanks for this pull request!
This was indeed incorrect.
However, this needs to be fixed as well in the following file:
https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/prompt_toolkit/terminal/vt100_output.py#L27
@Carreau: Can you confirm that this is the right way to do it.
Personally, if we're about to change this, I don't mind renaming the colors as well.
As far as I understand, the colors are: black,red,green,yellow,blue,magenta,cyan,while. Either low or high intensity.  Naming them fuchia, turquoise, brown, etc.. is confusing.
But this has to be fixed in Pygments as well. (Right?)

I am all for changing the color names if there is no good reason for what they are now. But pygments has a very slow release cycle so I think we should just fix it now in PTK.

However, this needs to be fixed as well in the following file:
https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/prompt_toolkit/terminal/vt100_output.py#L27

I will do that as well.

@jonathanslenders. I have updated the vt100 file as well.

Yeah, I originally tried to stick to a hard compatibility between Pygments ConsoleFormatter and the ansi escape sequences. I agree that it might have been a bad idea, and I should find time to fix that in pygments itself.
The teal/navy names are imho also a bad choice as they get away from the light/dark prefix. And are confusing as well when either on light-on-dark theme of dark-on-light themes as you will always get some dark-color that are lighter than their counterpart or vice-versa.
IMHO names like blue/alternate-blue or red/Bright-red would be better suited, but it's will be hard to convince users and the pygments team (IMHO).
Here is for example the naming in iterm2 that try to stay away from light/dark naming.

Thanks, @Carreau. Then I think we should just fix the immediate problem in PTK now, and then change the names later. I will fix this in xonsh as well once this one is merged into PTK.

Hi Everyone, the two commits from this pull request were merged. Thanks for this.
Next thing to be done: rename the colors.

@jonathanslenders .. Thanks a lot for this :)


Remove unused imports across project/current file

As I'm just switching to Atom and haven't had the linter running in my editor previously I have a ton of unused imports. It would be fantastic if the following commands existed:

Remove unused imports across project
Remove unused imports in file

How about also adding "Remove unused imports on save" option?
Cc: @mybuddymichael @splodingsocks

@halohalospecial Makes sense to me! I am curious if you have any thoughts to when functionality like this should go into elmjutsu instead of linter-elm-make or vice versa?

@mybuddymichael linter-elm-make features seem to be anything related to the output from elm-make (error highlighting, quick fixes), while elmjutsu features are those that uses information extracted from parsing (except for Install Package and Uninstall Package, which I'm thinking of removing or moving to another package).

There are sometimes overlaps, though.  Like if we want to have a quick fix that also needs parsed info.
Just realized that Atom is the only editor/IDE where Elm support features are spread across different packages/plugins :D

How about also adding "Remove unused imports on save" option?
I'll try and take a look today

The timing seems a little tricky regarding save/linting/removeImports. The linting happens after save(unless you have on the fly enabled) and because removeImports requires the linter to run first it means that it also can't be run until after save. This means that you have to hit save twice to save the results from removeImports. There doesn't appear to be anyway to force the linting to happen before save because even if I call it explicitly in the onWillSave hook https://github.com/mybuddymichael/linter-elm-make/blob/master/lib/linter-elm-make.js#L407 is async which means that it still runs after save. Potentially I can trigger a second save automatically but preventing an infinite loop is fiddly. Open to ideas if anyone has any.

So I added a hack that does the job, https://github.com/mybuddymichael/linter-elm-make/pull/114/commits/33795c8c7623ba1fd4c60be5043399a455aa5739. It does work reliably but you definitely have to hold your nose.

Ok, found a better approach, https://github.com/mybuddymichael/linter-elm-make/pull/114/commits/32aa060d28725e97c486d6dca15fca406c9eb1a5#diff-b34cd59fb6c7fbe5ac5d92af133b9935R455

Should we also have "Add missing type annotations on save" and the "Add missing type annotations" command?

Should we also have "Add missing type annotations on save" and the "Add Missing Type Annotations" command?

happy to add these as well


Fix import path for html-tag.

LGTM
Would want to add a test but it's actually non-trivial since polymer.html imports polymer-element.html, which also imports the (correct) html tag function.


Does not work on my Catalina Mac :(

~/ja2-building/ja2-stracciatella/_bin/mods/wildfire-maps (v0.17.0 ✔) ᐅ ./install_wildfire_maps --src_dir ~/ja2-building/Jagged\ Alliance\ 2\ Wildfire
Traceback (most recent call last):
  File "install_wildfire_maps.py", line 17, in <module>
ImportError: No module named pathlib
[34698] Failed to execute script install_wildfire_maps
~/ja2-building/ja2-stracciatella/_bin/mods/wildfire-maps (v0.17.0 ✔) ᐅ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.5
BuildVersion:	19F101
~/ja2-building/ja2-stracciatella/_bin/mods/wildfire-maps (v0.17.0 ✔) ᐅ uname -a
Darwin chuck.local 19.5.0 Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64 x86_64

Weird. That library should be bundled in the installer. I will give a check

Can I download the Build PR somewhere?

Travis CI builds have been disabled. We need to wait for an org owner to re-enable before we can have PR builds.
So no, you have to build it from source. Or check again in a few hours when org owners comes online.

Wondering if @lynxlynxlynx or @selaux can help to enable TravisCI on this repo?

I merged the PR, but travis hasn't been set up for this repo yet. It's been acting weird lately too, so I don't even have access to the settings (any more?). Both travis apps are already enabled at the org level.

Ok, Derek was right, a migration was needed. The build will appear here:
https://travis-ci.com/github/ja2-stracciatella/mod-wildfire-maps/builds/177204852

It should work now https://github.com/ja2-stracciatella/mod-wildfire-maps/releases/tag/0.2.2
Tested on my Mac


Implement the size_graph library.

size_graph scans through an ELF file and forms a directed graph of symbols in the ELF binary and their sizes. It is intended to be used for the following types of analysis:

What created the size delta between these two binaries?
What large symbols have few references to them (i.e. where are
the low-hanging size optimizations?)
Why was a symbol pulled in?

I vendored the rustc-demangle library for Rust name demangling.
Work that remains to be done:

Implementing binaries to perform the above analysis. The
binary comparison library could benefit from a parallel loader,
which I will implement.
Looking into name mangling: Rust has a new and much more informative
(but technically unstable) name mangling scheme. We may want to pull
information out of the mangled names to make size analysis easier.
Improve analysis of indirect calls -- this may be fine as-is but it
may need work.

----------------------
`make prtest` summary:
----------------------
git rev-parse HEAD
27cf42c953350f676cd77d70131552c43ba9c0e2
git status
On branch size-tools
Your branch is up to date with 'origin/size-tools'.

nothing to commit, working tree clean

Can you fix the prtest?

Can you fix the prtest?

Would you mind clarifying? Seems fine to me.

I read this as an issue, that what you're prtesting is not necessarily what's in the origin branch? I.e., you'll need to merge then prtest that merge? Or is this not a problem and I misunderstand?
Your branch and 'origin/size-tools' have diverged,
and have 1 and 1 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

I read this as an issue, that what you're prtesting is not necessarily what's in the origin branch? I.e., you'll need to merge then prtest that merge? Or is this not a problem and I misunderstand?
Your branch and 'origin/size-tools' have diverged,
and have 1 and 1 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

Ah, that's because my workflow is:

git commit
make prtest
git push

You can check that the listed commit hash (74cb604...) matches the value that GitHub sees. As an alternative, I could push before I run prtest, which would give nicer prtest output, but then I need extra force pushes if the prtest fails.

I've renamed size_tools to tools/, as discussed in #125 .
----------------------
`make prtest` summary:
----------------------
git rev-parse HEAD
b69a91418ad2a135bb81d8d4c8cbd8d64ec14205
git status
On branch size-tools
Your branch is up to date with 'origin/size-tools'.

nothing to commit, working tree clean

I wanted to try the tool to see if I had any feedback on its use/output. When I run make in the tools directory, I get
make -C .. tools/build
make[1]: Entering directory '/usr/local/google/home/plevis/src/jrvanwhy/tock-on-titan'
cd tools && cargo build --offline --release
error: Found argument '--offline' which wasn't expected, or isn't valid in this context

USAGE:
    cargo build [OPTIONS]

For more information try --help```

I wanted to try the tool to see if I had any feedback on its use/output.

There is no binary yet, just a library. I'm trying to separate out the gory/hacky implementation details (parsing objdump output, in this PR) from the UI design details ("coming soon").

Do I have the wrong cargo version?

Yes. I was missing a rust-toolchain file, which I have now added. However, it just points at the latest stable toolchain, so you'll need to update your toolchain. This is a relatively-new cargo flag.

Yes. I was missing a rust-toolchain file, which I have now added. However, it just points at the latest stable toolchain, so you'll need to update your toolchain. This is a relatively-new cargo flag.

If you could include a check that this is properly updated, that would be good. E.g., I haven't updated to the latest stable toolchain (e.g., for elf2tab) for a long while, and figuring out that I needed to do so wasn't obvious.

Yes. I was missing a rust-toolchain file, which I have now added. However, it just points at the latest stable toolchain, so you'll need to update your toolchain. This is a relatively-new cargo flag.

If you could include a check that this is properly updated, that would be good. E.g., I haven't updated to the latest stable toolchain (e.g., for elf2tab) for a long while, and figuring out that I needed to do so wasn't obvious.

I'm not sure how to do this. We could:

Parse the output of 'cargo -V', looking at either the version number or the date.
Run 'cargo --help', and search for the string "--frozen".
Drop the use of "stable" and instead specify a fixed Rust version (e.g. 1.37.0). elf2tab would stick  with "stable", and presumably would receive the new version after rustup updates the toolchain.

#1 would require us to periodically update the supported version. #2 could be automated by using a wrapper binary that does that check before invoking cargo -- but the build system for that wrapper binary (or should it be a Python script? I don't want to pick up too many build dependencies) has the same issue.
Perhaps we should do #3?

I think standard Tock has a way of handling this -- check out Makefile.common in boards/.

I think Tock has a way of handling this -- check out Makefile.common in boards/.

That's method 1. I implemented it in #129


Zzz

A calculator in which you enter how many bells you spent and how much you will gain

This feature request is out of scope for the project.
From the README

This tool is not:

A calculator for how much money you'll make
A way to count your turnips
A way to store multiple people's islands
Something with a backend

Just a suggestion to help improve or develop the page.

Suggestions are alwaays welcome! Just happens that this one in particular is out of scope for the goals of this project.

Thanks Mike!
Maybe a goal for a future project. I’m more than happy to think of more suggestions/comments as well.
Sent from my iPhone

On 17 Apr 2020, at 02:12, Ryan Carbotte<EMAIL_ADDRESS>wrote:

Suggestions are always welcome! Just happens that this one in particular is out of scope for the goals of this project.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Fix Import-DbaCsv Finding Schema From File Name

Function was not picking up the schem name in files with
a period in their name, as help suggested. Have added a new
switch UseFileNameForSchema to help the user specify when
they want to use the schema in a filename.

Type of Change

[x] Bug fix (non-breaking change, fixes #5868 )
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

This fixes the bug with Import-DbaCsv not recognising that testschema.data.csv should import data to table [testschema].[data]. Current behaviour is importing it to [dbo].[testschema.data].
Approach

I've added a new switch, UseFileNameForSchema to try and only enable this feature if you really want it. Thinking about how this interacted with the Schema and Table parameters left too many possible paths to make it clear. Instead the script will treat file names exactly as it did before unless the UseFileNameForSchema flag is specified, then it will use the file name up to the first period as the schema name, and the file name after the first period, op to the extension, as the table name.
Commands to test

Import-DbaCsv -Path C:\temp\schema.data.csv -SqlInstance sql2016 -database tempdb -UseFileNameForSchema -Table testtable

This script could use more integration tests. Just got to figure out how to add files and test the appveyor build without a load of commits here!

YESSSSSSSSSSSSS thank you! and i'd love more. Do me a favor. I'll merge this, then you can open a new PR just for the extra tests. I'll squash that then you don't have to worry about how many commits occur.

Will do! Just added a PR for some more tests files to appveyor-lab so I'll sort the tests separately.

🎉 thank you!

done! your changes are now in development


feat: update dataFrom with use of generator

Problem Statement
The annoted example of ExternalSecret was not using the present dataFrom with use of generatorRef
Related Issue
Fixes #2392
Proposed Changes
I changed the full-external-secret.yaml to use the generatorRef in the structure under dataFrom
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[x] My changes have reasonable test coverage
[x] All tests pass with make test
[x] I ensured my PR is ready for review with make reviewable

Thanks @LucasPimentel123, very useful!


Test Mtgraphite emitter with new logmet endpoints

Description
As reported by @fabolive (https://github.ibm.com/watson-foundation-services/tracker/issues/9375#issuecomment-3496780), mtgraphite emitter works with legacy endpoints and does not work with new endpoints.
Need to test and fix emitter.

I tried publishing metrics to the new logmet endpoint. I used metrics.stage1.ng.bluemix.net. Although, in crawler log it shows it has successfully
2017-09-26 13:46:26,000 MainProcess INFO     Sent authentication with mtgraphite, returned length = 52
2017-09-26 13:46:26,262 MainProcess INFO     MTGraphite authentication server response of 1A
2017-09-26 13:46:26,364 MainProcess INFO     Confirmed write to mtgraphite socket.

on grafana, it does not show any data.
Another point, although crawler is started with frequency=60, i see only one emit log in the crawler o/p. It does not send logs periodically.
@fabolive @sahilsuneja1 @canturkisci

@nadgowdas It seems to me that the new Logmet endpoints now can send "partial ACKs", that is, a message that contains fewer than the 6 bytes that comprise a full ACK. The behavior we are seeing in the mtgraphite emitter seems to be related to this change.
For our reference, here is a pull request made against a nodeJS Logmet client I maintain to support the new endpoints: https://github.com/IBM/logmet-client-njs/pull/2


offset image incorrect after bind

Using Chrome Version 58.0.3029.110 (64-bit) (Windows)
When I look at the last example on https://foliotek.github.io/Croppie/ the offset of the image initially is  incorrect when toggling the button. After you slide the zoom, it corrects the offset.

I'm seeing this issue as well, after loading a rotated image using enableExif. Adjusting the zoom slider fixes it

This one is fixed in master and will go live with the next release.  Thanks guys.


Make Random Quote Visualizer

No Game No Life that's my favorite quote what about you
Fetch a random quote from an API and display it in a simple window, with changing background colors or fonts to make it more engaging.

Can you assign me this issue?


Update aks samples

Changes:

Use WKO 4.1.8.
Domain on PV sample

Add "Create domain creation image " section.
Remove steps to deploy sample app, use included app instead.
Update automation script.

Model in image sample

Fix file paths
Update content of the sample jsp page.

Did a pre-review of this during the Oracle meeting. Looking good. Will do detailed review as time permits.

Hello @rosemarymarano I have reviewed and approved these changes.

Merged commits through internal process.


what is  "format": "integer"??

"Integer" is not valid format in JsonSchema, why quicktype expose this?

Is there a workaround for this?  It looks like this breaks json schema parsers.


Add websockets into async-downloads

Add websockets communication in async-downloads. Package can be now used inside multiple products suite and connect all of them with async websockets. Each action should notify all connected clients and update download-dropdown. Downloads now run asynchronous and are updated in fronted separately with individual information about one download at a time.
Example implementation:

What are the minimum requirements to make this work in WS_MODE? We should make this general, and leave the multi-app stuff out where we can I think.
If I have understood things correctly...
In order to have a single Django app running in WS_MODE, we need to:

Load the websocket JavaScript.
Configure the ASGI and consumer.

In order to be compatible with a multi-app setup, sharing a cache, we need to support:

Setting a specific cache.

So I believe we should amend the README to express things this way, and remove anything not relevant to that. The multi-app setup using channel layers I think is out of scope of this package.
The setting of a specific cache could be an independent feature you could decide to use outside of WS_MODE too, so I think we should simply provide a setting for that.

TODO during rebase:
rename commit:  8d2c97d|| feat: add optional APP_NAME setting ->feat: add optional css class setting

Should we also bump here package version ?

Yeah, we can wait until the PR is ready though and decide what to make the new version. I'll rename the PR so the autolabeler works.

Yes its correct because flex will format side by side our new custom div with applied class and existing download. So for example if we add class that has 100px width it will be inserted before and squeeze download-content to fit in remaining space.

Oh, it's actually supposed to be two divs next to each other? I assumed it was supposed to be a class on the existing div for the particular download entry.
I feel like that's a rather bespoke feature of gaia - can we achieve the same styling by putting the class on the download entry div instead? Perhaps a ::before?

Yes its correct because flex will format side by side our new custom div with applied class and existing download. So for example if we add class that has 100px width it will be inserted before and squeeze download-content to fit in remaining space.

Oh, it's actually supposed to be two divs next to each other? I assumed it was supposed to be a class on the existing div for the particular download entry.
I feel like that's a rather bespoke feature of gaia - can we achieve the same styling by putting the class on the download entry div instead? Perhaps a ::before?

Can you show it to me somewhere how I can add this colored label and move content of download with css?

Yes its correct because flex will format side by side our new custom div with applied class and existing download. So for example if we add class that has 100px width it will be inserted before and squeeze download-content to fit in remaining space.

Oh, it's actually supposed to be two divs next to each other? I assumed it was supposed to be a class on the existing div for the particular download entry.
I feel like that's a rather bespoke feature of gaia - can we achieve the same styling by putting the class on the download entry div instead? Perhaps a ::before?

0ebd3d6f24595951fbfe467f7d035496f3f09338
example config in argus/gaia-product:
ASYNC_DOWNLOADS_OPTIONAL_CSS_CLASS= 'ad-background-gradient-label-argus'
.ad-background-gradient-label-argus {
    padding-left: 20px !important;
    background: linear-gradient(
        to left,
        rgba(0, 0, 0, 0) 0%,
        rgba(0, 0, 0, 0) 97%,
        rgba(26, 104, 214, 1) 97%
    );
}

Can we fixup these commits more? There's quite a few that just change something from a previous commit. Even just a single feat commit would be fine.

Can we fixup these commits more? There's quite a few that just change something from a previous commit. Even just a single feat commit would be fine.

conflict markers removed, commits merged into one feat

Does the v3rsion need bumping as well?


Consider Fargate

Interesting read here: https://www.pulumi.com/blog/aws-eks-managed-nodes-fargate/. See last point. To enable Fargate we just set a flag fargate: true when creating the cluster. Might make managing our nodes easier.

The issue is no longer valid as we are now 3rd party hosted.


Consider mark some packages as "hold"

http://www.cyberciti.biz/faq/debian-ubuntu-linux-apt-get-blacklisting-packages-using-hold-option/
i.e: xnbd-client, nbd-client
Related with #28
cc @aimxhaisse

Fixed in #49


Default font-size of body is 0.875rem when using CssBaseline

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
After upgrading from v3 to v4 of material ui, the font size of our entire application has changed, and the default is now 0.875rem
Expected Behavior 🤔
I would expect that the default font size is 1rem
Steps to Reproduce 🕹
https://codesandbox.io/s/clever-poitras-x70t9

@jim-moody Thanks for the report.
It's a duplicate of #17100.

For anyone else that has this problem, I was able to add the following to the theme object as a workaround:
const theme = createMuiTheme({
  typography: {
    body2: {
      fontSize: "1rem"
    }
  }
});

For anyone else who tries the above and it does not work. You need to ensure that CssBaseline is placed after MuiThemeProvider E.g.
 <MuiThemeProvider theme={theme}>
      <CssBaseline />
 </MuiThemeProvider>


Update twitter hashtag to #CarpentryConAtHome

Per clarification from Omar in cc2022-planning slack channel. This is in PR #24

Closed with #24


Detect Gradle when setting default value of pact.rootDir

This is awesome! It's been bothering me for years :-D


Add wish list CMS related components to apparel-uk

Some new CMS was added to the spartacussampledataaddon for powertools and electronics in #5239. This issue is to add it to apparel-uk. (only uk as de is not done)
PR where CMS items were added: https://github.tools.sap/cx-commerce/spartacussampledataaddon/pull/33

PR here: https://github.tools.sap/cx-commerce/spartacussampledataaddon/pull/35


fix(pronouns-page): pronouns displayed without search

Details

Pronouns were being displayed without searching.
Instead of patching to fix the issue, I decided to fix the root cause, which is that the PronounsPage was too convoluted, with a lot of unnecessary async code (setting state and relying on useEffects) causing unnecessary re-renders and difficulty to debug.
For example, there was a loadData() call on mount to generate the pronouns list. But that data was already available and could have been calculated on-the-fly, without relying on creating states, setting states, and listening to the change in useEffects.
Refactored to make the information flow be synchronous, without any side-effects, and fixed the issue mentioned above.
Fixed Issues

$ https://github.com/Expensify/App/issues/26074
PROPOSAL:
Tests

In Profile -> Pronouns:

[X] Verify that no errors appear in the JS console
[X] If you had a Pronoun pre-selected, the text input should have the pronoun as it's value
[X] If you had a Pronoun pre-selected, the list should be filtered to show your Pronoun (and possibly a few others that share the same start of the pronoun name. E.g. "He / Him / His" and "He / Him / His / They / Them / Theirs")
[X] If you had a Pronoun pre-selected, the pronoun should be highlighted
[X] If you did not have a Pronoun pre-selected, the text input should be empty
[X] If you did not have a Pronoun pre-selected, the list should be empty
[X] Changing the search should filter the list
[X] Clearing the search show show an empty list

Offline tests

QA Steps

In Profile -> Pronouns:

[ ] Verify that no errors appear in the JS console
[ ] If you had a Pronoun pre-selected, the text input should have the pronoun as it's value
[ ] If you had a Pronoun pre-selected, the list should be filtered to show your Pronoun (and possibly a few others that share the same start of the pronoun name. E.g. "He / Him / His" and "He / Him / His / They / Them / Theirs")
[ ] If you had a Pronoun pre-selected, the pronoun should be highlighted
[ ] If you did not have a Pronoun pre-selected, the text input should be empty
[ ] If you did not have a Pronoun pre-selected, the list should be empty
[ ] Changing the search should filter the list
[ ] Clearing the search show show an empty list

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Pinging @Santhosh-Sellavel here because he was reviewing the other regressions related to the SelectionList refactor

@Santhosh-Sellavel Are you going to review this PR or is this waiting for me?

I'll take care of this on Monday!

[x]  Verify that no errors appear in the JS console
[x]  If you had a Pronoun pre-selected, the text input should have the pronoun as it's value
[x]  If you had a Pronoun pre-selected, the list should be filtered to show your Pronoun (and possibly a few others that share the same start of the pronoun name. E.g. "He / Him / His" and "He / Him / His / They / Them / Theirs")
[x]  If you had a Pronoun pre-selected, the pronoun should be highlighted
[x]  If you did not have a Pronoun pre-selected, the text input should be empty
[x]  If you did not have a Pronoun pre-selected, the list should be empty
[x]  Changing the search should filter the list
[x]  Clearing the search show show an empty list

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/85645967/992995f4-4de0-47c0-a63b-f0a433458e69

Mobile Web - Chrome & Mobile Web - Safari
https://github.com/Expensify/App/assets/85645967/b687dfdd-8bcc-4d23-8036-22829f3dc824

Desktop
https://github.com/Expensify/App/assets/85645967/4234ca85-c099-4165-97e9-be21e9655092

iOS
https://github.com/Expensify/App/assets/85645967/49f19c6f-ca68-453f-a8d1-30263fcbc093

Android
https://github.com/Expensify/App/assets/85645967/e2bc80fc-9c60-4210-9edc-37ac9df354ea

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.68-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

As the author is already aware, this PR caused a small bug because a wrong key was being checked when calling the update function.


OpenAI compatible API

We should support a version of the REST API that mirrors the OpenAI completion API, similar to vLLM:
https://docs.vllm.ai/en/latest/getting_started/quickstart.html#openai-compatible-server

This has landed, let me know how it goes!


Update EventHub CI test case

Keep project fail in CI test for bug finding, and using Thread safe list in EventHubProcesser

Codecov Report

Merging #517 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #517   +/-   ##
========================================
  Coverage    41.89%   41.89%
========================================
  Files           57       57
  Lines         2158     2158
  Branches       268      268
========================================
  Hits           904      904
  Misses        1190     1190
  Partials        64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 574e25e...abbbca2. Read the comment docs.


fix: escape ddev composer args, for #6604, fixes #6628

The Issue

#6628

The culprit:

#6604

This was discussed earlier in:

#2547

How This PR Solves The Issue
Adds proper escaping.
Adds missing test coverage.
Manual Testing Instructions
Test any composer command, that has ", ', ' ' (whitespace), or {}:
ddev composer config description "test description"
ddev composer config description "''''"
ddev composer config description "\""
ddev composer config repositories.local '{"type": "composer", "url": "https://example.com"}'

And check composer.json file for changes.
Automated Testing Overview

Release/Deployment Notes

Double-bashing is a never-ending pain.

@stasadev thanks so much for explaining why this couldn't be solved with a more general fix (https://github.com/ddev/ddev/pull/6627#issuecomment-2422364014). I was wondering about that.
More followups in the issue.

I updated this PR to pass PATH to the docker-compose exec.
This is better than escaping.
I explicitly used this condition:
if err == nil && path != "" {
	env = append(env, "PATH="+path)
}

Because it would be strange to fail the whole composer command if echo $PATH somehow fails.

Sorry, the suggestion also requires strings to be imported.


Merge CLI repo to YoMo repo

Summary
As getting off go plugin, there is no need to separate YoMo and CLI to different repos, should merge them together, and change install script.
Release v1.9.0 for this changes, no breaking changes.

any updates this ? there seems to be overlap in the code base so its a bit hard to follow.

Hi @gedw99, already merged, please upgrade to newer version.


Merge branch 'master' into DataMana-patch

@sdhutchins this may fix the genbank.py issue

It's certainly worth a try.

https://help.github.com/articles/reverting-a-pull-request/

@grabear ff4555f needs to be reverted probably on the command line


127 code and namespace cleanup

Code Clean up:
1- Rename all Responses and Requests to match this format "{Entity Name} {Operation}"
2- Simplify Namespaces
3- Add In Memory DB support to our DI Extension for Lite Db (For Tests)
4- Rename All Edits to Update
5- Configured .editorconfig to throw warnings at ca2016 https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2016
@pournasserian am i missing anything?

@ParsaGachkar please remove changes from src/.editorconfig and create another PR for that

@ParsaGachkar there are many conflicts, please resolve

@ParsaGachkar there are many conflicts, please resolve

Resolved @pournasserian @pournasserian review Please


Shift-cmd-T clashes with default mapping for restoring tab

The default editor mapping
'body':
  'shift-cmd-T': 'pane:reopen-closed-item'

overlaps with terminal-plus
'.platform-darwin atom-workspace':
  'shift-cmd-T': 'terminal-plus:new'

I have the same issue, but it doesn't seem to always be active (I'll have to check that part).

Just FYI, I fixed it adding this to my keymap file:
'.platform-darwin atom-workspace':
  'shift-cmd-T': 'pane:reopen-closed-item'

Thanks @alazaro for the workaround. It worked for me. I still think this should be fixed by default. I don't understand packages overriding native keybindings.

Putting this keybinding for the application in user-accessible package settings (and hopefully changing the default to something that isn’t already mapped by Atom) would be ideal.


Custom library support: allow to customize 'main' and 'typings'

Hi guys 👋
What?
This PR adds the possibility to provide a custom "main" and/or "typings" through the "decentralandLibrary" property on package.json.
Example: https://github.com/colyseus/colyseus.js/commit/fe1f4da44211fe0bccbf898b75f970c7a6a2619f
Why?
As a library author, I'd like to customize the main and typings fields specifically for Decentraland support on a module. The colyseus.js module, for example, currently uses the "main" root property for Node.js/ReactNative target, and "browser" property for browsers.
Additionally, the default typings provided by colyseus.js module have references to other third-party typings/modules, making it difficult to integrate seamlessly with Decentraland. Luckily, some work has been done in the past to generate a "standalone" .d.ts file for Colyseus that is meant for copying and pasting on a standalone project - which is perfect to be used on Decentraland!

Let me know what you think about this change. I haven't found if "decentralandLibrary": {} is being used for another specific purpose, otherwise I'm happy to make any changes requested to land this PR.
(I'm starting to work on a demo scene using Colyseus + Decentraland 🎉)

Cool, thanks for your contribution!

@endel I want to know about your use case and I'd love to watch an example. Please share!

Hi @menduz, thanks for reviewing and merging! This is what I've got so far: https://github.com/colyseus/decentraland
I'm in contact with Nico and will try to get it deployed Monday on some land hopefully :pray:
The Decentraland's TypeScript API is very straightforward, which makes the integration with Colyseus very straightforward as well!

Spawning cubes in the client-side https://github.com/colyseus/decentraland/blob/558be8db135089f781d77249c3c0c468caae46a1/scene/src/game.ts#L54-L60
Receiving "touched block" and spawning a new cube from the server: https://github.com/colyseus/decentraland/blob/master/server/src/rooms/MyRoom.ts#L18-L21


text/plain should interpret ANSI

Plain transformime does this and it's fully expected here too, based on the mimebundles that IPython returns.
We can use https://github.com/nteract/react-jupyter-display-area/blob/master/src/ConsoleText.jsx though we'll still want our ANSI -> React converter.
/cc @IonicaBizau

Done in #11!


Cannot install config/settings_data.json

Describe the bug
I have been downloading theme files from the staging version of a client site.
Following multiple attempts, I have been unable to install config/settings_data.json using both theme get and theme download - whereas every other file has downloaded successfully.
I had to run the theme get command multiple times due to being rate limited (there seems to be 1196 files in total from the theme), but eventually every file has downloaded, apart from config/settings_data.json.
To Reproduce
Steps to reproduce the behavior:

run command 'theme get --password=mypassword --store=our store ID here.myshopify.com --theme=our theme ID here'
Repeat 1 (can substitute with theme download if config.yml is created) until most files have downloaded (apart from config/settings_data.json)

Expected behavior
A clear and concise description of what you expected to happen.
Environment (please complete the following information):

OS [e.g. iOS]: Ubuntu 18.04.4 LTS (Using Windows Subsystem for Linux on Windows 10 Pro, Build Number: 19042)
Themekit version (run theme version to check): ThemeKit 1.3.0 linux/amd64
Editor [e.g. atom, sublime]: VIM 8
Ignore:

Additional context
Add any other context about the problem here.

use --themeid not  --theme


Return handle for job is null when scheduling a "Date" based Job

Hello,
The return handle is null when scheduling a job based on a Date object.
var schedule = require('node-schedule');
var d = new Date(2012, 1, 16, 10, 15, 40);

var j = schedule.scheduleJob(d, function(){
    console.log('The world is going to end today.');
});
console.log(j);

-- Output is null
The fix I believe is below
Job.prototype.schedule = function(spec){
	var success = false;
	var job = this;

	if (typeof(spec) == 'object' && spec instanceof Date)
	{
		var inv = new Invocation(this, spec);
		scheduleInvocation(inv);
		success = this.trackInvocation(inv);
	}
....

compared to the existing code which is
success = scheduleInvocation(inv);
    if (success)
	this.trackInvocation(inv);

Thanks,
Nithin

Thanks for the catch, you're absolutely right. Fixed! :)


Color Picker CMYK is not correct? or could you please show how to do it?

Description of the new feature / enhancement

as in the Example Above, I am using CorelDraw to get the colors.
RGB is perfect match in Color Picker, but I cannot say the same for CMYK.
what is happening so it gives me wrong color codes?
Scenario when this would be used?
when using a graphics application for color matching
Supporting information
No response

[image: image.png]
I see. CorelDraw has it's own color manager system so it uses the profile
that converts the RGB to CMYK (The profile is coated fogra 39), Color
picker is correct as you mentioned. then actually, is it possible to
implement a color profile to this color picker?
PesBandi @.***>, 30 Eyl 2024 Pzt, 21:36 tarihinde şunu
yazdı:

Hi @TheFuturist350 https://github.com/TheFuturist350, I don't think
this Color Picker's fault. If you convert #742125 to CMYK you get
0,72,68,55 (just google #742125). How did you get the other color
(34,96,77,51)?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/35147#issuecomment-2383903369,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BANOUDODHDFVFIUKVVEFJDTZZGK3LAVCNFSM6AAAAABPDV7X2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTHEYDGMZWHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Anyone knows how to use Evernote to publish?

Any ideas?
Best regards
ArchGalileu

When we'll implement an API for Grav, there could be a IFTTT rule that publishes an Evernote page to a Grav site, but currently unless you create some custom procedure, it's not possible.


Expanded section bug with shortcut edit links

Issue description:
I'm using a section with 'type' => 'expanded', though clicking on the edit link in the frame seem not to understand this type yet

Version used:
3.0.8
Using theme_mods or options?
themee_mods
Code to reproduce the issue (config + field(s))
Kirki::add_field( 'ipetri', array( 	'type'     => 'text', 	'settings' => 'header_phone', 	'label'    => __( 'Phone', 'my_textdomain' ), 	'section'  => 'header', 	'priority' => 10, 	'transport' => 'postMessage', 	'partial_refresh' => array( 		'header_phone' => array( 			'selector'        => '.phone__number', 			'render_callback' => function() { 				return get_theme_mod('header_phone'); 			}, 		) 	), ) );

👍 Marking as a bug. I haven't found a solution to this one yet though, so not sure it will make it in the next version.

It's a pity, very promising one. Going back and forth with native WP panels is a pain, I don't know why they implemented it that way. Expanded sections though would reduce the effort significantly. Personally I hope you would figure it out!

Hello and thank you for reporting this issue.
We are closing most open GitHub issues with the release of Kirki 4 to start fresh with this major release.
If you are still running into issues after you have tested your theme with Kirki 4, please let us know so we can reopen the issue.
Please note that Kirki 3 is no longer actively supported. Moving forward, we will only provide support the very latest version of Kirki.
Thank you for your understanding.
Best,
David


Errors on Auth when creating JavaScript client

Issue / Steps to reproduce the problem
Was following the quickstart docs. Followed it all through and finished the javascript client and found a couple of problems. I am not sure if I have missed something or if the quickstart implies something.
It seems that the JavaScript Oidc user manager tries to call the logout(logoutId) overload which following the quickstarts the ASP.NET Core identity quickstart does not implement this method.
Similarly, the client added to the identity server for the js client requires consent which again following the ASP.NET Core identity quickstart is not implemented.
Is it assumed that we should copy the quickstart UI with these methods to the ASP.NET Core identity quickstart project or use the older quickstart project which uses the UI but not the identity.
I just wanted to make people aware of this in the quickstarts but not sure which is the better solution.
Relevant parts of the log file

You probably took the prior quickstart (the one using ASP.NET Identity) as the starting point for this one?

Ahh yes, that would be it. Thank you for the quick reply. Where should it follow on from as a minimum? Would it be possible to just add a sentence saying that at the beginning just to prevent other peoples future confusion?

At the end of the ASP.NET Identity QS it says: http://docs.identityserver.io/en/release/quickstarts/6_aspnet_identity.html#what-s-next
It basically means that yea, the ASP.NET Identity UI is really missing abunch of stuff to really make your host a full OIDC server implementation. Basically their template mindset is just for local stuff, whereas IdentityServer/OIDC needs more.
HTH


Connecting to Windows 10\Windows Server 2019 Session 0 through FreeRDP

We are looking for help to connect Windows Session 0 through FreeRDP from C#.NET
Is FreeRDP feasible to connect to Windows Session 0?

@Ranga1987 well, as long as you speak RDP it should work. (Session 0 is a server side thing - only relevant stuff is what are the authentication requirements)
That is, I assume you want to use FreeRDP as a client, correct?

@Ranga1987 since Windows 7/Server 2008 R2, session isolation was introduced which means session 0 is no more the (formerly known) "console session" but now hosts all services running on the system.
Further more it has no access to the video/display device, limited network access and there is no way you can authenticate to that session as it runs using the built-in SYSTEM account (and there is no way you have the password for that).

@akallabeth, @mfleisz , yes Session 0 is no more interactive in latest Windows Versions, but here we are looking to access Session 0 through FreeRDP to control the Services (pass messages to services to run on demand).

@Ranga1987 you won't be able to access session 0 through RDP (due to the aforementioned reasons). If you want to communicate with services in session 0 you will have to use some sort of IPC (named pipes, sockets, RPC, ... to name a few).

@akallabeth, @mfleisz , thank you for your prompt response. Please provide us the clarification on below queries
Is it possible to create non-interactive user session through FreeRDP?
If yes, can we open non-interactive user session using FreeRDP in C# application (windows service)?


Tflm cc files

Gets the TensorFlow Lite micro build forward.
At this point it fails to find some files:
/Users/microbit-carlos/workspace/mbef/codal-tflm/source/output_handler.cc:18:10: fatal error: tensorflow/lite/micro/micro_log.h: No such file or directory
   18 | #include "tensorflow/lite/micro/micro_log.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/MICROBIT.dir/source/output_handler.cc.obj] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 78%] Building CXX object CMakeFiles/MICROBIT.dir/source/tensorflow/lite/core/api/error_reporter.cc.obj
In file included from /Users/microbit-carlos/workspace/mbef/codal-tflm/source/tensorflow/lite/core/api/flatbuffer_conversions.h:28,
                 from /Users/microbit-carlos/workspace/mbef/codal-tflm/source/tensorflow/lite/micro/micro_mutable_op_resolver.h:23,
                 from /Users/microbit-carlos/workspace/mbef/codal-tflm/source/tensorflow/lite/micro/all_ops_resolver.h:16,
                 from /Users/microbit-carlos/workspace/mbef/codal-tflm/source/main_functions.cc:18:
/Users/microbit-carlos/workspace/mbef/codal-tflm/source/tensorflow/lite/schema/schema_generated.h:21:10: fatal error: flatbuffers/flatbuffers.h: No such file or directory
   21 | #include "flatbuffers/flatbuffers.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~

I believe source/tensorflow/lite/micro/micro_log.h is not present in this branch.

Commit https://github.com/neil-tan/microbit-v2-samples/pull/1/commits/da9cf386c317d89498457cd3a2752de93bdeb6dc shows how to add specific include paths to the build, necessary for source files that include in the "path/to/header.h" style.

Apart from that, all the files in the source/tensorflow/lite/micro/kernels/ contain this at the start, which I had to comment out to move forward, not too sure if it's necessary or not:
// Patched by Edge Impulse to include reference, CMSIS-NN and ARC kernels
#include "../../../../classifier/ei_classifier_config.h"

The rest of the compilation errors that I get are from missing files in the tensorflow folder.


Change unclear variables & fix typos

Simple PR learning about code.
Closes #122

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks for the fixes @natolambert! Happy to integrate all the typo changes. However, for the variable renaming I would suggest leaving that for a major release. It is a breaking change which doesn't benefit the user much. Happy to clarify the docstrings though where necessary!

Ah, great point. Thanks for teaching me open-source.


Unify github http client / auth

This allows the same http client w/ oauth to be used in both the githubv4 API and rss requests.  It also moves the knowledge about the auth env var to a single function.

I'm rolling this into another bit of work instead.


StatusLineNC highlight causes infinite ^ in status line

If I don't supply my own highlight group for hl.StatusLineNC I get this:

Anytime I use a fuzzy find or open a split.
	{
		"neanias/everforest-nvim",
		version = false,
		lazy = false,
		priority = 1000, -- make sure to load this before all the other start plugins
		-- Optional; default configuration will be used if setup isn't called.
		config = function()
			require("everforest").setup({
				-- Your config here
				background = "soft",
				transparent_background_level = 2,
				italics = true,
				on_highlights = function(hl, palette)
					hl.StatusLineNC = { fg = palette.none, bg = palette.none, sp = palette.red }
				end,
			})
		end,
	},

I'm not sure why this is happening (on latest Neovim Nightly) but it looks like its related to the highlight groups being the same.
https://github.com/nordtheme/vim/issues/37
Thought I would report in case other have issues with the workaround above.

Thanks for raising this! It turns out I hadn't accurately ported the Vim version to Lua as the StatusLineNC foreground values should differ for transparent_background_level == 2 configurations. All fixed now!


SessionDelegate crashes recorded in firbase crashlytics

Crashed: NSOperationQueue 0x10617e690 (QOS: UNSPECIFIED)
0  libswiftFoundation.dylib       0x1f614e00c specialized __DataStorage.init(bytes:length:copy:deallocator:offset:) + 368
1  libswiftFoundation.dylib       0x1f6077e4c Data.InlineSlice.ensureUniqueReference() + 152
2  libswiftFoundation.dylib       0x1f6078734 Data.InlineSlice.append(contentsOf:) + 48
3  libswiftFoundation.dylib       0x1f607f2a4 Data._Representation.append(contentsOf:) + 400
4  Kingfisher                     0x1058e856c $s10Kingfisher15SessionDelegateC03urlB0_8dataTask10didReceiveySo12NSURLSessionC_So0i4DataF0C10Foundation0J0VtF + 148
5  Kingfisher                     0x1058e88b4 $s10Kingfisher15SessionDelegateC03urlB0_8dataTask10didReceiveySo12NSURLSessionC_So0i4DataF0C10Foundation0J0VtFTo + 124
6  CFNetwork                      0x1c3af6d08 _CFNetworkHTTPConnectionCacheSetLimit + 204976
7  Foundation                     0x1c0acf3f0 NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK + 16
8  Foundation                     0x1c09da710 -[NSBlockOperation main] + 84
9  Foundation                     0x1c0ad164c NSOPERATION_IS_INVOKING_MAIN + 20
10 Foundation                     0x1c09da414 -[NSOperation start] + 740
11 Foundation                     0x1c0ad2044 NSOPERATIONQUEUE_IS_STARTING_AN_OPERATION + 20
12 Foundation                     0x1c0ad1b10 __NSOQSchedule_f + 180
13 libdispatch.dylib              0x1c0380c8c _dispatch_block_async_invoke2 + 104
14 libdispatch.dylib              0x1c03ce524 _dispatch_client_callout + 16
15 libdispatch.dylib              0x1c0376e98 _dispatch_continuation_pop$VARIANT$mp + 412
16 libdispatch.dylib              0x1c03765ec _dispatch_async_redirect_invoke + 656
17 libdispatch.dylib              0x1c0383438 _dispatch_root_queue_drain + 376
18 libdispatch.dylib              0x1c0383bf8 _dispatch_worker_thread2 + 124
19 libsystem_pthread.dylib        0x1c041fb38 _pthread_wqthread + 212
20 libsystem_pthread.dylib        0x1c0422740 start_wqthread + 8

Crashed: com.apple.NSURLSession-delegate
0  libswiftFoundation.dylib       0x1856c7cd8 specialized __DataStorage.init(bytes:length:copy:deallocator:offset:) + 388
1  libswiftFoundation.dylib       0x1856b2c20 Data.InlineSlice.ensureUniqueReference() + 156
2  libswiftFoundation.dylib       0x1856b3a5c Data.InlineSlice.append(contentsOf:) + 52
3  libswiftFoundation.dylib       0x1856bbb30 Data._Representation.append(contentsOf:) + 416
4  Kingfisher                     0x10376056c $s10Kingfisher15SessionDelegateC03urlB0_8dataTask10didReceiveySo12NSURLSessionC_So0i4DataF0C10Foundation0J0VtF + 148
5  Kingfisher                     0x1037608b4 $s10Kingfisher15SessionDelegateC03urlB0_8dataTask10didReceiveySo12NSURLSessionC_So0i4DataF0C10Foundation0J0VtFTo + 124
6  CFNetwork                      0x1823c3118 _CFNetworkHTTPConnectionCacheSetLimit + 155520
7  libdispatch.dylib              0x1817df24c _dispatch_call_block_and_release + 32
8  libdispatch.dylib              0x1817e0db0 _dispatch_client_callout + 20
9  libdispatch.dylib              0x1817e810c _dispatch_lane_serial_drain + 580
10 libdispatch.dylib              0x1817e8c90 _dispatch_lane_invoke + 460
11 libdispatch.dylib              0x1817f2d78 _dispatch_workloop_worker_thread + 708
12 libsystem_pthread.dylib        0x1cb004804 _pthread_wqthread + 276
13 libsystem_pthread.dylib        0x1cb00b75c start_wqthread + 8

@onevcat please help on it. any idea or suggestion for this?

@onevcat please help on it. any idea or suggestion for this?

It is more likely an out of memory crash when allocating data. Try to limit the memory usage, or when you load huge images, use a DownSampling processor to avoid the memory peak.
I believe there is not much we can do in Kingfisher, since it is related to the system framework and overall memory usage.

It is more likely an out of memory crash when allocating data. Try to limit the memory usage, or when you load huge images, use a DownSampling processor to avoid the memory peak.
I believe there is not much we can do in Kingfisher, since it is related to the system framework and overall memory usage.


Refactoring

[x] UMD
[x] ability to use on strings, for client-side
[x] tests
[x] docs

I've left the minified JS alone, not sure how you've done that. Would you like me to add a gulpfile so that it can handle the minification? It'll make it easier for collaborators.

All done :smile:
If you're happy with this, I think this is probably worth a 1.0.0 release. It definitely breaks backward compabilitity (technically okay pre-1.0.0, but could annoy people), and also adds tests, which is probably useful. I'd recommend getting travis working on this repo :smile:

smartquotesjs looks to be available on npm. I have smart-quotes, which is just an earlier version of this repo. I'd be happy to hand over smart-quotes or deprecate it when this refactoring is published to npm.

Sure it's available on npm, but it doesn't work unless you're using it client-side. Or am I misunderstanding you?

I think that was in reference to the name being available?

Oh, right. Fair enough :)

@kellym it was. "smartquotesjs" is an available name on npm.

Although, to be fair, "smartquotes" would probably be better, and is also available.

agreed, I like "smartquotes" for npm -- looking through the PR now

Love splitting this into string() and element() -- I hated that it couldn't be used to parse just plain text. Nice changes!
I'm slightly averse to putting an .editorconfig file in the repo since it's more of a user-preferences type of thing, but I'm always flexible.
If you want to add gulp to handle the minification, I'll +1 that.  I'd used a command line minifier in the past since the repo was so simple.

The editorconfig file is actually the opposite of that—the user can set their editor settings to whatever they want, but when they contribute to this project it means they use the existing code style, otherwise it gets messy. It means they don't have to change their editor settings.
I can remove if you want, though—that's why it's in its own commit!

I added an npm script to run uglifyjs, gulp would have been overkill :smile:

@kellym Hey! Any update on this?

@kellym: Sorry to nag, but I really want to use this library on my website and I can't until this PR is merged! Could you take a look at it?
If you're struggling for time, feel free to add me as a collaborator on this project and I'll keep it maintained for you :smiley:

LGTM. Sorry for the delays, busy last week and was out of town until last night. I'm going to get these issues cleaned up today and merge this one in. Also, I'm adding you as a collaborator -- great work on all of these changes, this is a perfect addition.

Awesome, thanks!

This has been published as v1.0.0 to npm at https://www.npmjs.com/package/smartquotes

:+1: I will start work on a gulp plugin :smiley_cat:


Dkocen patch 1

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi, can you please provide context? What feature are you fixing/updating?

Closing due to lack of response, please re-open if you have more context behind the changes.


Fix rackConfig in cluster helm chart README.md

Indentation for the storage stanza in the rack config example is fixed
Signed-off-by: Jean-Francois Weber-Marx<EMAIL_ADDRESS>Signed-off-by: Jean-Francois Weber-Marx<EMAIL_ADDRESS>

Thanks @jfwm2 for noticing this and also fixing it. I'll merge the PR.


Move prop-types to dependencies

The prop-types package recommends for libraries to install prop-types as a direct dependency rather than a peer dependency. This change simplifies consumption of react-sane-contenteditable for projects who would otherwise not need to install prop-types. Package managers will still be able to dedupe compatible versions of prop-types so there will be no bundle size increase in those cases.
https://github.com/facebook/prop-types#how-to-depend-on-this-package

@ahutchings Thank you for this PR.
On another note, seeing as you raised this issue and provided a PR I was wondering if you might be able to help test #52? It aims to solve a number of long-standing issues and I could do with another pair of eyes on it.

I've published v1.5.1 now.

Thanks @nijk! I'll try to take a look at #52 in the next few days.


Compliance Report | Part 2 Summary section of the Summary and Declaration Page |5|

Task:
This card is to create the Part 2 - Renewable Fuel Requirement Summary section of the Summary & Declaration Page.

See attached mockups for proposed layout (Summary Section Mockup and Part 2 and Part 3 Summaries Mockup)

Sub-tab label:

Summary & Declaration

Sub-tab heading:

Part 2 - Renewable Fuel Requirement Summary

Design and Content:

Proposed design is to use the spreadsheet plug-in to create Summary tables similar to the ones in the existing excel-based compliance reporting spreadsheet (see attached screenshots "CR - Part 2 Summary Section.PNG" and "Part 2 and Part 3 Summaries Mockup.docx")

Refer to the "Part 2 and Part 3 Summaries Mockup.docx" file for the content to include in this section. Content is on page 1 under heading "Part 2 - Renewable Fuel Requirement Summary"

Functionality:
The functionality behind these cells will be developed in other Trello cards. This card is simply to create the tables / layout needed prior to implementing functionality.
https://trello.com/c/AyaNiJhL/1250-compliance-report-part-2-summary-section-of-the-summary-and-declaration-page-5#

Resolved in Sprint Quasar.


Fix IOSStorageFolder permission problem

What does the pull request do?

This PR aims to fix StorageProvider.OpenFolderPickerAsync permission errors when run on an iOS device.
What is the current behavior?

Folders opened using StorageProvider.OpenFolderPickerAsync can't be used on an iPhone, because of "Operation not permitted" errors on every operation.

Please note that these errors occur only on a real device, the emulator works without the changes in this PR. My test device runs iOS 17.1.2, and I do not have access to any other Apple devices / iOS versions to test on.
I have attached a minimal test application to demonstrate this behavior. The application asks the user for a folder, and puts the name of all files and folders under it into a ListBox. The file/folder list will appear in the ListBox when run in the emulator, but not when run on a real device.
What is the updated/expected behavior with this PR?
With the commit in this PR, folders opened using StorageProvider.OpenFolderPickerAsync can be accessed as normal.
How was the solution implemented (if it's not obvious)?

The root cause of the problem is that IOSStorageFolder does not call StartAccessingSecurityScopedResource / StopAccessingSecurityScopedResource on its Url. This PR adds these calls to IOSStorageFolder's constructor and Dispose methods, similarly to IOSSecurityScopedStream.

@dotnet-policy-service agree


MM-40751 Properly set Content-Type on API requests

Turns out all API requests we make to the server from the client are made with Content-Type: plain/text even though we're always passing JSON through Client4. I looked through every Client4 call that passes a body, and every one of them calls JSON.stringify on an object before passing it as the body option
Ticket Link
https://mattermost.atlassian.net/browse/MM-40751
Closes https://mattermost.atlassian.net/browse/MM-40751
Release Note
Changed Client4 to properly set Content-Type as application/json on API calls

/e2e-tests

Cherry pick is scheduled.