feat(NODE-6158): add signature to github releases

Description
Sign releases in legacy driver.
Uses drivers-github-tools v1 since we don't have credentials for v2 as of now (SBOM handling is not required for this repo.
What is changing?
Automate release signing with a detached signature and verification instructions in the README.
Link to an example of release signatures working with v2 (if you check the artifact link at the end of the compress_sign step, you can see the signature)
Is there new documentation needed for these changes?
No
What is the motivation for this change?
SSDLC Compliance

Release Highlight

Add Signature to Github Releases
The Github release for mongodb-legacy now contains a detached signature file for the NPM package (named
mongodb-legacy-X.Y.Z.tgz.sig), on every major and patch release.  To verify the signature, follow the instructions in the 'Release Integrity' section of the README.md file.

Double check the following

[ ] Ran npm run check:lint script
[ ] Self-review completed using the steps outlined here
[ ] PR title follows the correct format: type(NODE-xxxx)[!]: description

Example: feat(NODE-1234)!: rewriting everything in coffeescript

[ ] Changes are covered by tests
[ ] New TODOs have a related JIRA ticket

Also just need to update the PR description since we did end up migrating to the v2 action


Texture.Texture() is inaccessable

Environment

Source : Unity Asset Store
VRTK Version : 3.2.1
Unity Version : 2018.1.0f2
Hardware : Have not even been able to get that far yet

Steps to reproduce
Created a brand new project
Downloaded VRTK from Unity Asset Store.
Open project solution into Visual Studio.
Expected behavior
Expected a clean compile.
Current behavior
I get an error saying,
"Texture.Texture()' is inaccessible due to its protection level"
This is happening in file:
"\Assets\VRTK\Scripts\Interactions\Highlighters\VRTK_MaterialColorSwapHighlighter.cs"
This is happening in Line "146"

VRTK 3.2.1 doesn't support Unity 2018.1 you will need to use VRTK 3.3.0 (which is currently the github master branch)

Ok, ok!  Thanks so much.


Issues importing OPML files that have repeated podcasts. The import breaks.

Describe the bug
There are podcasts that are on different platforms, therefore they have different feeds, but the name is the same. When I import an OPML file, the importation stops and gets stuck. If there are 200 subscriptions in the file and the numbers 7 and 8 are the same podcast with the same title but a different feed URL, it stops and doesn't continue importing the rest of the feeds.
It seems to be a problem where something breaks when creating the database and the title matches. In this case, it would be interesting to import repeated podcasts with different feeds and if there is any problem of this type, skip it and continue importing the rest of the feeds if they are not added.
Reproduction

System Info
linux, firefox, brave

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Could you please add a sample opml that contains two entries - both have the same name but different rssfeeds.

Ex:
Try importing this file and you will see that when it reaches the podcast Applelianos, since the title is duplicated, it breaks. I had a file with about 6 podcasts duplicated by title and it always broke. I have been manually deleting them to test and that was the reason.
<opml version="2.0">
<head>
<title>AntennaPod Subscriptions</title>
<dateCreated>03 May 23 18:32:23 +0200</dateCreated>
</head>
<body>
<outline text="#SoyCopywriter" title="#SoyCopywriter" type="rss" xmlUrl="https://soycopywriter.libsyn.com/rss" htmlUrl="https://soycopywriter.com"/>
<outline text="3.0" title="3.0" type="rss" xmlUrl="http://api.rtve.es/api/programas/59470/audios.rss" htmlUrl="https://www.rtve.es/play/audios/30/"/>
<outline text="5.0" title="5.0" type="rss" xmlUrl="http://api.rtve.es/api/programas/1872/audios.rss" htmlUrl="https://www.rtve.es/play/audios/50/"/>
<outline text="Alimento y salud" title="Alimento y salud" type="rss" xmlUrl="http://www.rtve.es/api/programas/1881/audios.rss" htmlUrl="https://www.rtve.es/play/audios/alimento-y-salud/"/>
<outline text="Apple Coding" title="Apple Coding" type="rss" xmlUrl="https://cuonda.com/apple-coding/feed" htmlUrl=""/>
<outline text="Applelianos" title="Applelianos" type="rss" xmlUrl="https://applelianos.podbean.com/feed.xml" htmlUrl="http://www.ivoox.com/podcast-applelianos_sq_f1170563_1.html"/>
<outline text="Applelianos" title="Applelianos" type="rss" xmlUrl="https://www.ivoox.com/podcast-applelianos_fg_f1170563_filtro_1.xml" htmlUrl="http://www.ivoox.com/podcast-applelianos_sq_f1170563_1.html"/>
<outline text="Aprendiendo GTD y productividad" title="Aprendiendo GTD y productividad" type="rss" xmlUrl="https://www.ivoox.com/aprendiendo-gtd-podcast_fg_f1286811_filtro_1.xml" htmlUrl="http://www.ivoox.com/podcast-aprendiendo-gtd-productividad_sq_f1286811_1.html"/>
<outline text="Órbita Laika. El podcast" title="Órbita Laika. El podcast" type="rss" xmlUrl="https://api.rtve.es/api/adapter/programas/146030/audios.rss" htmlUrl="https://www.rtve.es/play/audios/orbita-laika-el-podcast/"/>
</body>
</opml>


Translation model associations missing from translatable resources

Since the refactor of translations and the creation of their own model and controller, some resources are missing the has_many :translations, as: :translated, dependent: :destroy AR association back to their translations. Projects have this relationship, but the following do not:

Workflow
Tutorial
FieldGuide
ProjectPage
Organization
OrganizationPage

Adding these relationships will allow translations to be included when any of these resources are copied via deep_clone.

On it, I was just looking into making it more obvious which resources are translatable, and which arent. This fits in nicely.


Crash when upcasting complete Range to Enumerable

This was discovered while trying to recreate https://github.com/crystal-lang/crystal/issues/4684#issuecomment-313793055. The following code started crashing since 0.36.0:
puts (0..0).as(Enumerable(Int32))

Invalid memory access (signal 11) at address 0x17600000176
[0x56058ea71366] print_backtrace at /usr/lib/crystal/exception/call_stack.cr:129:5
[0x56058ea64c4c] __crystal_sigfault_handler at /usr/lib/crystal/signal.cr:347:3
Program exited because of a segmentation fault (11)

0x176 is Range(Int32, Int32).crystal_instance_type_id.
Range(Int64, Int64), Range(UInt8, UInt8), and Range(UInt64, UInt64) have a similar issue, when the integer literals and the as argument are modified. On the other hand, Range(UInt32, UInt32) and Range(UInt16, UInt16) produce:
Module validation failed: Invalid bitcast
  %163 = bitcast %"Range(UInt32, UInt32)"* %10 to [4 x i32], !dbg !41
Load operand must be a pointer.
  %164 = load i32, [4 x i32] %163, !dbg !41
Call parameter type does not match function signature!
  %164 = load i32, [4 x i32] %163, !dbg !41
 [4 x i32]  call void @"*puts<Enumerable(UInt32)>:Nil"(i32 %164), !dbg !44
 (Exception)

Range(Int16, Int16) produces the following on e572b56:
BUG: trying to upcast Enumerable(Int16) <- Range(Int16, Int16) (Exception)
  from /crystal/src/compiler/crystal/codegen/cast.cr:672:5 in 'upcast_distinct'
  from /crystal/src/compiler/crystal/codegen/cast.cr:527:15 in 'upcast'
  from /crystal/src/compiler/crystal/codegen/codegen.cr:1219:19 in 'accept'
  from /crystal/src/compiler/crystal/codegen/codegen.cr:2184:7 in 'prepare_call_args_non_external'
  from /crystal/src/compiler/crystal/codegen/call.cr:57:7 in 'visit'
  from /crystal/src/compiler/crystal/syntax/visitor.cr:27:12 in 'accept'
  from /crystal/src/compiler/crystal/codegen/codegen.cr:619:9 in 'accept'
  from /crystal/src/compiler/crystal/codegen/codegen.cr:2149:7 in 'codegen'
  from /crystal/src/compiler/crystal/compiler.cr:172:16 in 'compile'
  from /crystal/src/compiler/crystal/command.cr:210:5 in 'run_command'
  from /crystal/src/compiler/crystal/command.cr:117:7 in 'run'
  from /crystal/src/compiler/crystal.cr:11:1 in '__crystal_main'
  from /crystal/src/crystal/main.cr:110:5 in 'main'
  from src/env/__libc_start_main.c:94:2 in 'libc_start_main_stage2'

Range(Int8, Int8) works. Floating-point ranges and ranges with mixed integer types also seem to work.

It seems Crystal::GenericModuleInstanceType#@including_types isn't properly populated when a generic type includes a generic module.

Reduced:
class Bar(T) # -> Range
end

module Foo(T) # -> Enumerable
end

def foo(x : Bar(Int64))
end

def foo(x : Bar(Int32))
end

class Bar(T)
  include Foo(T)
end

Bar(Int32).new.as(Foo(Int32)) # BUG: trying to upcast Foo(Int32) <- Bar(Int32) (Exception)

This happens because a bunch of Ranges are instantiated in Random#rand_range, but prelude.cr requires random.cr before range.cr. Swapping the order of the require statements fixes the standard library but not this reduced snippet. The include Foo(T) statement should do something similar to Type#after_initialize on any instantiations prior to the include.
Note that Range is defined internally by Crystal::Program, not by range.cr; if we move the include to above then nothing breaks.

A segmentation fault occurs when running the following code.
(note that Range printing is Ok outside class definition),
Is this the same issue ?
class Table(T)
  def initialize(@sources : Enumerable(T))
    p @sources
  end
end

data = 1..3
p data
puts "---"
t = Table.new(data)

1..3
---
Invalid memory access (signal 11) at address 0x0
[0x562ccbaa54b6] *Exception::CallStack::print_backtrace:Nil +118 in /home/hubert/.cache/crystal/crystal-run-test_range.tmp
[0x562ccba94ac6] ~procProc(Int32, Pointer(LibC::SiginfoT), Pointer(Void), Nil) +310 in /home/hubert/.cache/crystal/crystal-run-test_range.tmp
[0x7f4e78dfea00] ?? +139975012116992 in /usr/lib/libc.so.6
[0x562ccba9a7a7] *Exception::CallStack::new:Exception::CallStack +7 in /home/hubert/.cache/crystal/crystal-run-test_range.tmp
Program exited because of a segmentation fault (11)

Yes, that appears to be the same issue.
Thanks for reporting anyways.


golangci-lint: change renamed linter goerr113 -> err113

This commit gets rid of the deprecation message when using golangci-lint with the renamed linter goerr113 that has been renamed to err113.
WARN [lintersdb] The name "goerr113" is deprecated. The linter has been renamed to: err113.

Looks like the linter has been renamed with golangci-lint version 1.58.x that i already have installed locally. Since cilium still uses 1.57.x linting starts to fail.
Marking as draft until cilium has caught up.

Closing this PR in favor of cherry-picking the fixing commit into the renovate update PR itself.


front end/UI

Must have a polished front end/UI

Basic styling completed. May do more if there is time, but currently it is styled/functional enough for MVP.

As a note, the color palette referenced for design was: https://colorpalettes.net/color-palette-4214/


Fix/lock claim request

@akru I made a lot of changes and ensured that the lockdrop claim request functions. It worked on my system but please double-check it for me


remote-debugging with ssh-fs is not working

Environment data

VS Code version: 1.30.1 (1.30.1)
Extension version (available under the Extensions sidebar): 2018.12.1
OS and version: macOS 10.14
Python version (& distribution if applicable, e.g. Anaconda): conda, 3.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Relevant/affected Python packages and their versions: none

Expected behaviour
I can add breakpoints when I use the remote-debugger while working using the ssh-fs extension
Actual behaviour
pydev debugger: warning: trying to add breakpoint to file that does not exist: /disk/vanishing_data/xxx/xxx/xxx/ssh:/xxx/xxx/xxx/xxx/xxx.py (will have no effect)
Steps to reproduce:
use the ssh-fs extension to develop on a remote (localhost for reproducing) machine. Then add to the launch.json:
{
            "name": "Python: Attach",
            "type": "python",
            "request": "attach",
            "port": 5678,
            "pathMappings": [
                {
                    "localRoot": "${workspaceFolder}/",  // You may also manually specify the directory containing your source code.
                    "remoteRoot": "/disk/vanishing_data/xxx/xxx/xxx/"
                }
            ],
            "host": "localhost"
        }

Logs
Diagnostic Code: InvalidPythonInterpreterDiagnostic, Message: No Python interpreter is selected. You need to select a Python interpreter to enable features such as IntelliSense, linting, and debugging.
Starting Microsoft Python language server.
Microsoft Python Language Server version <IP_ADDRESS>
Initializing for generic interpreter

Output from Console under the Developer Tools panel
there's a lot of stuff here, some with sensitive information. Is it important?

I just replaced the work-related directories with xxx. I didn't alter anything, it's the project accessed via ssh-fs and remote debugging on said machine.


Ad should not be shown after the jailbreak fails.

Describe the bug
I'm not sure why this was coded in. The dev/sponsor should not be rewarded when your jailbreak tool fails. I could go on and explain why this is a terrible decision, but I'm going to assume this wasn't intended.
To Reproduce
Steps to reproduce the behavior:

Jailbreak fails
Shown ad.

Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

iOS Version:  13.5
iOS Device: XS
unc0ver Version: 5.0.1

Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[x] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.

I agree.

This thread should be quite expanded. I would like to just give the developer some money to get rid of this annoying add every time I jailbreak. As well the company does not even offer a case for my phone.
Once I purchase the case, the annoying ad is not removed of course. Come on, add some kind of a paid option at least to remove the advertising!

This is not the place to post this.

I believe it does since it (to me) seems like bug behavior. You do not reward a user with an ad if the main function of the app/task fails. CaseAdViewController is being presented regardless. If I was the sponsor, I wouldn’t want my ad being shown when there’s a failure. It doesn’t look good for the sponsor & it doesn’t look good for the dev of unc0ver. (Which leads me to believe the code for presenting the ad was misplaced)

On Jun 16, 2020, at 12:04 PM, Hamlock-maneuverr<EMAIL_ADDRESS>wrote:

This is not the place to post this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Who gets "rewarded" with adds bro?   Use a different jailbreak if it bothers you.    You know why you see an add just like everyone else knows why.  He made a deal with EverythingApplePro... Is it that you just wanted or needed someone else to say it?  really though.

@Hamlock-maneuverr What are you getting so salty over? @CokePokes has a point. And even I wondered the exact thing they did.

For some reason so it is a hot commodity on anonymous forums.
Just to enhance this thread further a proper handling of the advertising programming for this application should include my ability to pay to remove ads. Without a blink of an eye I would pay this excellent developer more than the cost of that iPhone case, literally, which case I can’t even buy for my version of iPhone anyway!  Once I actually purchase a case I would at least like the ad removed at that point. I would purchase a case I don’t even need just to get the ad removed,

Bro.  Nobody but you in getting salty.  I came to try to give you some insight.  If you want to continue pointless bitching in a forum pwn will never see.  Be my guest. But don't assume everyone is mad just because you are.  Get real my guy.

Alrighty, lets calm down. I'm not mad. No one here is mad. I'm just saying OP has a point. There is no need to shoot them or me down because of this point. I'm sorry that what i said may have mad you or upset. Lets keep this civil from now on. :D

I hope in the final stable release which is upcoming, that were given an option to pay this developer to remove the advertising. The little button to close the ad I have to tap on it like 10 times to get it to work as well. And they won’t even sell me a case for my phone!


No more free public api from telize.com

From http://www.telize.com:

The public API will permanently shut down on November 15th, 2015. More information can be found here [http://www.cambus.net/adventures-in-running-a-free-public-api/].
To continue using Telize after this date, please spin up your own instance or subscribe to a paid plan.

Oh, that's sad news. Thanks for letting me know though. I'll work something out.

@Mironor fixed in https://github.com/theiterators/akka-http-microservice/commit/fa4eb0041c674cb0a3d88da1b5f11e5428da9cdc Again, thanks for noticing us about it!


Fix for Errno::ENAMETOOLONG

I added code and spec to shorten filenames that will cause Errno::ENAMETOOLONG on filesystems that will only support 255 characters.
There were a couple other reports of this issue, but their solutions were not up to date with the latest version of ci_reporter.
I made the code compatible with the latest sidestep code and included a spec.

Can you put out a release with this fix please.  Thanks.


FR: move up/down using ctrl-n/ctrl-p

In the command palette, move the selection up/down using ctrl-n/ctrl-p key combo. This is a very common Unix style shortcut, another plugin quick switcher++ has it implemented, so I think it could be a great bonus if this one could behaves the same.

Now it's implemented Obsidian-wise: every suggestion modal can use ctrl-n/ctrl-p to navigate

yeah, Ctrl+N/Ctrl+P work.  but it would be nice to have Ctrl+J/Ctrl+K as well


Clean up 'uncommitted' diff.

Description:
This PR fixes an issue originating in how go-diff is used on uncommitted changes.
Given the following git diff:
diff --git a/.ci/ci.settings.xml b/.ci/ci.settings.xml
index ec2cf0ac76..bd029dd740 100644
--- a/.ci/ci.settings.xml
+++ b/.ci/ci.settings.xml
@@ -13,7 +13,9 @@
         <server>
             <id>foo-bar</id>
             <username>${env.S3_KEY_ID}</username>
-            <password>${env.S3_SECRET}</password>
+            <password>
+-----BEGIN EC PRIVATE KEY-----
+            </password>
         </server>
         <server>
             <id>bar-baz</id>

On current master, diffContents at https://github.com/zricethezav/gitleaks/blob/master/scan/scan.go#L291 contains the following string (note the line breaks):
\n-----BEGIN \n P\nIVA\nE KEY-----\n            \n

The problem with this is, that standard and custom regexes do not produce matches and pre-commit hooks therefore result in false negatives.
According to https://github.com/sergi/go-diff/issues/91, DiffCleanupSemantic has to be used to have a diff respecting line boundaries and producing more git like diffs.
With this PR applied, diffContents at the same place contains the following string, which will also match against regexes:
\n-----BEGIN EC PRIVATE KEY-----\n            \n

Checklist:

[x] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[x] Have you lint your code locally prior to submission?

@maennel fantastic contribution! Thank you. I'll try and add some tests for this at some point. But I think this is a pretty safe change to merge in now


Switch to using aws configure sso to provide CLI access to our AWS accounts

Context
Our docs currently suggest you copy paste the access tokens from AWS into your terminal for credentials. This is not the most secure thing to do. aws configure sso now exists, and is much more secure.
Proposal
No response
Updates and actions
No response

This is also represented by #3441 with a more obfuscated topic title


Delete documentation for parameters that already has been removed

These parameters are no longer supported in master branch.

Thanks for the PR @deric , nice catch


Architecture Diagram

Adds a design diagram.
I verified the link works on the fork, it should work after it merges:

No, I'm not familiar with the mermaid format, this will render nicely on
the readme once it merges to main because the URL I set as the image URL
assumes the main branch..
The example in the PR description actually uses the PR branch url to show
it'll render.
On Mon, Oct 24, 2022, 10:02 PM Dotan Simha @.***> wrote:

@.**** commented on this pull request.
In docs/architecture.puml
https://github.com/kamilkisiela/graphql-hive/pull/525#discussion_r1003999906
:

@@ -0,0 +1,63 @@
@.***

@B2o5T https://github.com/B2o5T any idea if we can add some magic to
display this kind of file (similar to what we have with mermaid)?
In the same context, @Enrico2 https://github.com/Enrico2 any plan to
move this to be in mermaid format?
—
Reply to this email directly, view it on GitHub
https://github.com/kamilkisiela/graphql-hive/pull/525#pullrequestreview-1154129291,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABHMITGJ4YTJZKGZIHQJBDWE5SWLANCNFSM6AAAAAARNLPCTM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Share results from different sites

There should be a common repository for results, which allow you to generate graphs without running everything yourself.
Checking in should be guarded so that only improvements are entered by default, and that results are traceable.

Sharing of information addressed in #62
Generating pages from shared information addressed in #65
Still TODO: Update Web pages with instructions.


custom-profile cannot show data correctly after zooming in many times when number of data is large

Version
4.8.0
Steps to reproduce

open "https://echarts.apache.org/examples/zh/editor.html?c=custom-profile"
change the line #3, "var dataCount = 10" to "var dataCount = 10000"
zoom in the chart enough, and drag the chart
now you can see many useless color blocks left on the Canvas, and cannot remove

What is expected?
fix the bug
What is actually happening?
custom-profile cannot show data correctly after zooming in many times when number of data is large

adding line 151, can fix the bug


Drilldown menu and sub-menu styling

Hey there guys,
Firstly thanks for Foundation 6, it's pretty awesome overall.
In the drilldown menu, it seems that a vertical menu works best. My question is, if I set the top level menu to have the vertical class and add the data-drilldown to the top level, I would expect each of the inner sub-menu items to inherit the layout of the parent menu. Basically unless I add the vertical class to each of my sub-menus it reverts back to the standard horizontal menu style.
I'm just not sure why its necessary to add the vertical class to the sub-menu items when using the drilldown menu it should just default the sub-menus to match the parent (I can't imagine any scenario where you would want a vertical top level menu and then inside it's sub-menus are horizontal)
Let me know if you guys want a CodePen of what I mean if you want any clarification.
Thanks again guys!

Yeah, this makes sense as a desired results i suppose. I feel like we had a reason why they shouldn't cascade, but we just has a discussion and couldn't think of any.  A PR would be appreciated, but if not we can get to it soon.

Thanks for the response.
Let me have a look into it and offer a pull request back to you guys for consideration.
Thanks again :)

Thanks Simon! Looking forward to it

Implemented in the 6.2 branch: 8cb890c375afe5b146443386933b3e3370ccb383


docs: update changelog for 0.5.4

Codecov Report

Merging #90 (c3728d0) into main (5243c13) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   99.73%   99.71%   -0.03%
==========================================
  Files          67       67
  Lines        3801     3801
==========================================
- Hits         3791     3790       -1
- Misses         10       11       +1

Impacted Files
Coverage Δ

lib/eth/client/ipc.rb
93.33% <0.00%> (-6.67%)
:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


"Open Revision" does not work with RemoteSSH

Issue Type: Bug

Use VSCode Insiders build
Use RemoteSSH Insiders version
Use GitLens
Open any file
Switch to GitLens
Pick any past commit
Right-click and select "Open revision"

Result:
Error running command gitlens.views.openFileRevision: Running the contributed command: 'gitlens.views.openFileRevision' failed.. This is likely caused by the extension that contributes gitlens.views.openFileRevision.
Extension version: 9.9.3
VS Code version: Code - Insiders 1.39.0-insider (575062278d181c075ea8dce345ab3d20a127309c, 2019-09-20T06:11:13.647Z)
OS version: Windows_NT x64 10.0.17763
Remote OS version: Linux x64 5.1.3-050103-generic
Remote OS version: Linux x64 5.1.3-050103-generic
Remote OS version: Linux x64 5.2.14-050214-generic

This should be fixed in GitLens 10

This is not fixed as far as i can tell - i'm running GitLens 10.0.0 with latest insiders build, and i'm still seeing the issue.

@eamodio never mind, updating to latest Insiders build fixed the issue. all seems to be working now, thanks!


Possibility to affect SEO since AppBar using  tag behind the scenes

Currently in material-ui  AppBar is using html5 header tag which could badly affect SEO.
As I think header tag most likely to play important role in SEO, Checkout header tag at W3School here
Since AppBar already using  behind the scene for to display logo and other navigation items, No any h1 or h2 tags giving introduction about the website, it could badly affect SEO.  (Yes we could have them inside AppBar tag but it is not what it built for.) Yes we can multiple header tags in a page, but it is nice to have one header instead.
Suggestion:

using nav tag instead of header

using nav tag instead of header

@KaushalyaPradeep You are free to change the root element of the AppBar. You can provide a component="nav" property to change it. Sorry, but without any specific resources to support your argument, I will label the issue won't fix`.

It is unclear whether they are matter or not. checkout the last paragraph here.
Since I can use component="nav", issue is fixed.
Thanks


[Snyk] Security upgrade sanitize-html from 1.4.2 to 1.7.1

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json
package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Code Injection SNYK-JS-LODASH-1040724
  298

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Code Injection

🎉 Snyk hasn't found any issues so far.
✅ security/snyk check is completed. No issues were found. (View Details)
✅ license/snyk check is completed. No issues were found. (View Details)


kedro-datasets: allow skipping Python 3.12 unit tests for SnowflakeTableDatasets

Description
Currently, installing testing requirements are failing for SnowflakeTableDatasets for Python 3.12, because it is not supported yet by the SnowparkAPI... Skipping Python 3.12 makes the tests succeed, as shown here
Context
I want to create a PR (#881) for SnowflakeTableDatasets, and the unit testing is failing.
Possible Implementation
Update CI/CD in such a way that it can skip unit tests for Python 3.12
Possible Alternatives

Skipping unit tests for SnowflakeTablesets like was done in the past, because of poor previous compatibility of SnowparkAPI.
Praying for Snowflake to finally update Snowpark to be compatible with Python 3.12.

Currently, SnowflakeTableDatasets are not included in testing (see here). Happy to keep it this way and merge #881, while bumping the snowflake-snowpark-python version to 1.23. That would be already much better than the current implementation of SnowflakeTableDataset which is stuck at version 1.0.0 (that only supports the depreciated Python 3.8 version). What do you think of this?

Hi @tdhooghe that sounds good to me. I was actually thinking we probably need to demote this dataset to experimental, since it doesn't technically adhere to our requirements of testing and python version support.
Of course, if the testing framework you linked works fine, we can then make it a core dataset again.

Hmm makes sense, although I think it would be really nice to have this one as core dataset.. If I implement the testing framework above, would the team then be fine of not having compatibility with Python 3.12 (for now, and once it is there, I will make the PR for including)?

Done in #881


[WIP] Support dropconnect

This PR is proposal for supporting dropconnect activation.
Dropconnect is generalization of dropout.
It drops weight element instead of input element.
Deteil is here.
http://cs.nyu.edu/~wanli/dropc/dropc.pdf

Thanks for your comment :smiley:
link.dropconnect test is failing, the document has not been completed and
there is a need to improve the overall quality.
I'm going to get down when there is a time.

Thank you for updating the implementation. I replied to your comments.

Could you add test cases in which dropconnect link work well with parameter shape placeholder (i.e. the first argument of the link is None)?

Thanks for your comment.
I added shape placeholder test and fixed bugs.
Especially, I struggled to reproduce mask for tests and to write docs.

I responded to your comments.

Thanks. I replied to review!

I'm struggling to implement API.
To pass check_backword, all explicit input arguments have to be Variable.
But train is bool, so first, I implemented __call__ as follows.
    def __call__(self, x, mask=None, train=True):

This API enable us to test by check_backward as follows.
Because train is last argument and we don't have to input explicitly.
    def check_backward(self, x_data, y_grad):
        gradient_check.check_backward(
            self.link, (x_data, mask), y_grad, (self.link.W, self.link.b), eps=1e-2)

But user may think that prior argument is important, and posterior argument is optional.
Conversely, train is important, and mask is optional.
I appreciate if you have a good idea.
If you want, I can upload draft commit.

How about wrapping the link with a function?
def f(data, mask):
    return self.link(data, True, mask)

def check_backward(self, x_data, y_grad):
    gradient_check.check_backward(
        f, (x_data, mask), y_grad, (self.link.W, self.link.b), eps=1e-2)

I really enjoy discussion here :smiley:
And I tried your idea.
But unfortunately, It seems not works well.
Here is a part of gradient_check.
    for skip, x, cx in six.moves.zip(no_grads, xs, casted_xs):
        if skip:
            assert x.grad is None
            continue
        gx, = numerical_grad(f, (cx.data,), y_grad, eps=eps)
        testing.assert_allclose(gx, x.grad, atol=atol, rtol=rtol)
        if dtype is None:
            assert gx.dtype == x.grad.dtype
        else:
            assert gx.dtype.kind == 'f' and gx.dtype == dtype

Current gradient_check regards tuple of Variable as data_x1 and data_x2.
And iterates test about data_x1 and data_x2 respectively.
But in our case, func(*xs) returns one array, and iterating about each data is impossible.
So it is difficult that we test dropconnect using data_x and mask by current API gradient_check.
One way is giving up and implement to set mask in __init__ like my previous draft.
Another way is extending gradient_check API.
If similar tests is needed for another links, I'd like to implement it.
But if no other links, I think the extension of the API is somewhat exaggerated.
How about you?

I am not confident I understand your comment perfectly but you mean the problem is that gradient_check tries to calculate the numerical gradient with respect to mask, as well as x_data?

I overlooked no_grads option and I succeeded to implement test. Thanks!

Thanks for your attentive review.
Could you check GPU test results?

OK, I will push the code to the Jenkins.

Sorry for being late for letting you know the result of GPU tests. The following error occurred. Can you find out the cause of the problem?
14:46:24 ======================================================================
14:46:24 FAIL: test_backward_gpu (test_dropconnect.TestDropconnectParameterShapePlaceholder)
14:46:24 ----------------------------------------------------------------------nose.plugins.multiprocess: ERROR: Worker 2 STOPPED
14:46:24 NoneType
14:46:24 nose.plugins.multiprocess: ERROR: Worker 1 STOPPED
14:46:24 NoneType
14:46:24 nose.plugins.multiprocess: ERROR: Worker 3 STOPPED
14:46:24 NoneType
14:46:25 nose.plugins.multiprocess: ERROR: Worker 0 STOPPED
14:46:25 NoneType
14:47:41
14:47:41 Traceback (most recent call last):
14:47:41   File "/work/chainer/chainer/testing/condition.py", line 71, in wrapper
14:47:41     fail()
14:47:41   File "/work/chainer/chainer/testing/condition.py", line 51, in fail
14:47:41     instance.fail(msg)
14:47:41 AssertionError:
14:47:41 Fail: 3, Success: 0
14:47:41
14:47:41 The first error message:
14:47:41 Traceback (most recent call last):
14:47:41   File "/work/chainer/chainer/testing/condition.py", line 57, in <lambda>
14:47:41     lambda: f(*args, **kwargs),
14:47:41   File "/work/chainer/tests/chainer_tests/links_tests/activation_tests/test_dropconnect.py", line 156, in test_backward_gpu
14:47:41     self.check_backward(cuda.to_gpu(self.x), cuda.to_gpu(self.gy))
14:47:41   File "/work/chainer/tests/chainer_tests/links_tests/activation_tests/test_dropconnect.py", line 146, in check_backward
14:47:41     (self.link.W, self.link.b), eps=1e-2, no_grads=(False, True))
14:47:41   File "/work/chainer/chainer/gradient_check.py", line 210, in check_backward
14:47:41     y = func(*xs)
14:47:41   File "/work/chainer/tests/chainer_tests/links_tests/activation_tests/test_dropconnect.py", line 141, in link_wrapper
14:47:41     return self.link(data[0], True, data[1])
14:47:41   File "/work/chainer/chainer/links/activation/dropconnect.py", line 86, in __call__
14:47:41     self.ratio, train, mask)
14:47:41   File "/work/chainer/chainer/functions/noise/dropconnect.py", line 121, in dropconnect
14:47:41     return Dropconnect(ratio, mask)(x, W, b)
14:47:41   File "/work/chainer/chainer/function.py", line 199, in __call__
14:47:41     outputs = self.forward(in_data)
14:47:41   File "/work/chainer/chainer/functions/noise/dropconnect.py", line 57, in forward
14:47:41     W = inputs[1] * self.mask
14:47:41   File "cupy/core/core.pyx", line 865, in cupy.core.core.ndarray.__mul__ (cupy/core/core.cpp:17251)
14:47:41     return multiply(x, y)
14:47:41   File "cupy/core/elementwise.pxi", line 731, in cupy.core.core.ufunc.__call__ (cupy/core/core.cpp:40840)
14:47:41     args = _preprocess_args(args)
14:47:41   File "cupy/core/elementwise.pxi", line 107, in cupy.core.core._preprocess_args (cupy/core/core.cpp:29538)
14:47:41     raise TypeError('Unsupported type %s' % type(arg))
14:47:41 TypeError: Unsupported type <class 'numpy.ndarray'>

As you see, CPU tests is failing. But the cause of the failure seems different from the change this PR made. We are now investigating the problem and will let you know how to fix the problem.

Thanks for GPU tests.
The reason why GPU tests fail is self.mask was not converted to cupy.
I use add_persistent to fix it.

Thank you for updating the code. I will run the GPU tests again.

Hi, thank you for updating the code. But unfortunately, it seems the same error remains. Is it possible to investigate the problem? Let me know if it is difficult to do so without GPUs.

I'm sorry for taking your time.
Now, I got a GPU environment.
I fixed tests and confirmed to pass GPU tests.

Ok, I will check it.

I confirmed that all GPU tests have passed successfully. I will check the code again and will merge if there are no problems.

@fukatani I realize that mask in dropconnect Function need not to be Variable, unless I miss something. As isinstance is costly, it is better if we can remove it in forward method here. How do you think of it?

hmm...difficult
In honest, I'm not comfortable with it isinstance.
But it is a consistent interface in chainer that __call__ can be input both Variable and ndarray.
And these arguments check by isinstance every forward call.
Another reason for allowing Variable is current gradient_check.check_backword permits only Variable type.
In addition, mask is None in normal case, so isinstance will not be executed.

I see. I could forget the discussion so far with you. So forgive me I could bring the same problem again. Do you remember why we did not choose to include mask as an argument of the function, as well as x, W, and b?

Don't mind. Actually, I think we should discuss about this topic too.
The reason why mask isn't argument of forward is as follows.
1)There are cases that we have to input only mask but not bias.
Inversely, input only bias but not mask.
We should identify these cases in forward.
For tht purpose, not only by using len(inputs), but also  by ndarray.shape
It's somewhat irregular.
2)mask is expected not to change by backward, backward returns zeros.
When doing the above, it will dirtier than the current pull request.
And current mask implementation resembles function.MulConstant, constant value of function.MulConstant is set in __init__.

I found the PR we are discussing is implemented differently from the original one. Original dropconnect creates masks for each sample in a minibatch, whereas the PR uses single same mask for all samples. Also, the forward propagation in inference is different (see Algorithm 2 in the original paper). Unlike dropout-like inference, original paper uses approximation with the Gaussian distribution.
It seems to need sophisticated techniques to implement the original method (c.f. section 5) as naive implementation requires too much memory (proportional to minibatch size). So I guess it will take some additional time to reimplement to align the original one.
As the PR is almost finished, I am thinking that we should complete the PR and create another PR that implements the original method if necessary. How do you think of it?

I really sorry for my mistake. :disappointed:
I want to correct dropconnect in near future, current PR had better to be merged so far.
I wrote the differences with original paper in doc.
As original paper, can be saved memory by boolean mask ?

Please do not worry, I was at fault.

I wrote the differences with original paper in doc.

Thank you, could you write the difference between the implementation and the original paper and add notice that this implementation cannot be used for reproduction of the paper.
Also I think it is better to rename the names of the function and the link to reserve Dropconnect for future use (e.g. SimplifiedDropconnect). How do you think of it?

As original paper, can be saved memory by boolean mask ?

Yes, it is better if possible. Could you try to change like that?

I decided to implement dropconnect as the paper.
GPU test failure remains.
It may be caused by cupy.random bug.
I'm investigating it now.
Changes:

Abolished scaling (as original implementation).
Instead, ratio is multiplied at inference.

Sampling at inference is optional .
Default num_samples is 1000  (as original implementation).

Support only float32.
This is because current matmul is support only float32.
I sent PR (#2151).

Cons:

Memory saving is not perfect.
mask which is class attribute is boolean,
But memory consumption by batch-sized array in the process of calculation still remains.
I don't consider it as a big problem.
e.g. There is a similar situation in bilinear.

I need #2169 for this PR.

Sorry for my late reply. So, you have decided not to make simplified version of DropConnect but to align the implementation with original one haven't you? I will check the implementation.

Don't worry.
Yes.
Actually, It is not difficult to implement batch-common-mask as option of Dropconnect`.
But I want to split PR, Since it is already big.

But I want to split PR, Since it is already big.

I agree. Could you do that?

OK! I'll do that.

I confirmed GPU tests at local. This PR can be reviewed.

Thank you for the update. I thought you would split this PR and send new smaller PRs because it ease our review. I would appreciate you if you would do so. If it is difficult, it is OK to remain this PR as it is.

Sorry for not working on this PR. Is it possible to splitting this PR into smaller ones.  I would appreciate you if you make a comment. Thank you in advance.

Sorry for late response.
I deleted commit about sampling inference. Is it OK?

Thank you for updating the code. I will take a look. Are you considering to send Sampling inference as another PR?

If the performance seems to rise with the original inference, I want to send PR, but as far as I implemented, the variance due to random sampling was large and the result was unstable.
I will rename this PR to SimplifiedDropconnect
Not-batchwise mask, as I said above, I will send another PR.

I will rename this PR to SimplifiedDropconnect
OK, go ahead.

Not-batchwise mask, as I said above, I will send another PR.
OK, I will check the PR.

As you can see, currently Travis tests of this PR fail. But this error seems independent of this PR as I encountered the same problem in another PR #2067. I am now investigating the problem.

Sure!
Basically, I confirmed failed contents, and I ignore them if it does not seem to be related.
And I renamed Dropconnect to SimplifiedDropconnect.

Thanks! I fixed them.
I also fixed bug on gen_mask at test.
It is irrelevant to the result of the test, but the shape of temp_x was also inappropriate and I fixed it.

Thank you for your change. I will check it.

As you can see, there occurs the following errors in Travis. This is because old NumPy (< 1.10) does not have matmul (see reference). As Chainer support NumPy older than 1.10, we should make this function work with it. We have several choices:

Implement this function without numpy.matmul
Check the version of NumPy and switch the implementation depending on the version.
Check the version of NumPy and raise an error if NumPy is older than 1.10.

Could you consider the implement this function without matmul? If it is difficult, I think the workaround is to take the third option and support older NumPy in another PR.
======================================================================
ERROR: test_forward_cpu (test_simplified_dropconnect.TestSimplifiedDropconnect_param_0)  parameter: {'train': True, 'ratio': 0.0, 'W_dtype': <type 'numpy.float16'>, 'x_dtype': <type 'numpy.float16'>}
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pfnet/chainer/tests/chainer_tests/functions_tests/noise_tests/test_simplified_dropconnect.py", line 56, in test_forward_cpu
    self.check_forward(self.x, self.W, self.b)
  File "/home/travis/build/pfnet/chainer/tests/chainer_tests/functions_tests/noise_tests/test_simplified_dropconnect.py", line 52, in check_forward
    self.train)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/chainer/functions/noise/simplified_dropconnect.py", line 148, in simplified_dropconnect
    return SimplifiedDropconnect(ratio, mask)(x, W, b)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/chainer/function.py", line 199, in __call__
    outputs = self.forward(in_data)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/chainer/functions/noise/simplified_dropconnect.py", line 61, in forward
    y = xp.matmul(W, x[:, :, None])
AttributeError: 'module' object has no attribute 'matmul'

As #2067, I use numpy.einsum instead of numpy.matmul.

@fukatani Thank you! As we use matmul in the test code, could you fix it in the same way?

Sorry, I fixed test.

LGTM, I will run the GPU test.

Thank you for your contribution!


Java SavedModelBundle.load do not support long path in windows

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Windows 10 64bit.
TensorFlow installed from (source or binary):
binary
TensorFlow version (use command below): 1.8.0
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

Describe the problem
Java SavedModelBundle.load do not support long path in windows.
It will throw something like:
org.tensorflow.TensorFlowException: NewRandomAccessFile failed to Create/Open: C:\Projects\veryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryverylongpath/variables/variables.data-00000-of-00001 : The system cannot find the path specified.
; No such process
	 [[Node: save_1/RestoreV2 = RestoreV2[_output_shapes=[<unknown>, <unknown>, <unknown>, <unknown>, <unknown>, ..., <unknown>, <unknown>, <unknown>, <unknown>, <unknown>], dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save_1/Const_0_0, save_1/RestoreV2/tensor_names, save_1/RestoreV2/shape_and_slices)]]
	at org.tensorflow.SavedModelBundle.load(Native Method)

I shorten the model path, everything works fine.
I enabled long path based on this doc. It still has this issue.
I know it's a limit of Windows OS. I just wandering is there any way to let the C++ part bypass this limit?

Thanks for the report @iron9light , I'm guessing you're talking about the path size limitations described in https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#maximum-path-length-limitation ?
The TensorFlow maintainers are unlikely to have the cycles to investigate a fix for this in the short term, so I'm marking this as "Contributions Welcome" in case anyone else in the community would like to give it a shot.
Thanks!

Fine!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


config binder /5

Fixes #30215

Internal previews

📄 File
🔗 Preview link

aspnetcore/fundamentals/aot/native-aot-tutorial.md
Tutorial: Publish an ASP.NET Core app using native AOT

aspnetcore/fundamentals/configuration/index.md
Configuration in ASP.NET Core

aspnetcore/fundamentals/native-aot.md
ASP.NET Core support for native AOT

@layomia please review


help i keep getting this error

like the title says i keep getting this here is the fulPS D:\redshelf_downloader-master\redshelf_downloader-master> python scrape.py
[Thread-1 (download_thread)] Downloading page 1
Exception in thread Thread-1 (download_thread):
Traceback (most recent call last):
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.1520.0_x64__qbz5n2kfra8p0\Lib\threading.py", line 1075, in _bootstrap_inner
self.run()
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.1520.0_x64__qbz5n2kfra8p0\Lib\threading.py", line 1012, in run
self._target(self._args, **self._kwargs)
File "D:\redshelf_downloader-master\redshelf_downloader-master\scrape.py", line 115, in download_thread
download_page(i)
File "D:\redshelf_downloader-master\redshelf_downloader-master\scrape.py", line 82, in download_page
base_url = get_base_url(raw)
^^^^^^^^^^^^^^^^^
File "D:\redshelf_downloader-master\redshelf_downloader-master\scrape.py", line 38, in get_base_url
return re.search("<base href="(.?/(OPS|OEBPS)).*"/>", raw).group(1)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'group'
[Thread-2 (convert_thread)] Converting page 1 to PDF
Exception in thread Thread-2 (convert_thread):
Traceback (most recent call last):
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.1520.0_x64__qbz5n2kfra8p0\Lib\threading.py", line 1075, in _bootstrap_inner
self.run()
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.1520.0_x64__qbz5n2kfra8p0\Lib\threading.py", line 1012, in run
self._target(*self._args, **self.kwargs)
File "D:\redshelf_downloader-master\redshelf_downloader-master\scrape.py", line 121, in convert_thread
convert_html_to_pdf(i)
File "D:\redshelf_downloader-master\redshelf_downloader-master\scrape.py", line 89, in convert_html_to_pdf
html = Path(f"{PAGE_PATH}/{page}/html/{page}.html").read_text(encoding="utf-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.1520.0_x64__qbz5n2kfra8p0\Lib\pathlib.py", line 1027, in read_text
with self.open(mode='r', encoding=encoding, errors=errors) as f:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.1520.0_x64__qbz5n2kfra8p0\Lib\pathlib.py", line 1013, in open
return io.open(self, mode, buffering, encoding, errors, newline)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'pages\1\html\1.html'
Merging PDF files
Traceback (most recent call last):
File "D:\redshelf_downloader-master\redshelf_downloader-master\scrape.py", line 152, in
merge_pdf_files()
File "D:\redshelf_downloader-master\redshelf_downloader-master\scrape.py", line 104, in merge_pdf_files
main_pdf = pymupdf.open(Path(f"{PAGE_PATH}/1/1.pdf"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\mattt\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\pymupdf_init.py", line 2763, in init
raise FileNotFoundError(msg)
pymupdf.FileNotFoundError: no such file: 'pages\1\1.pdf'

This pull request my fix your issue. #6

Hello.
Can you please send the raw html that you get? You can do this by adding print(raw) after line 81:
def download_page(page: int):
    path = Path(f"{PAGE_PATH}/{page}")

    if not os.path.exists(path):
        os.mkdir(path)

    raw = get_raw_html(page)
+   print(raw)
    base_url = get_base_url(raw)
    remote_urls = get_remote_urls(raw)
    download_remote_resources(page, base_url, remote_urls)
    create_html_file(page, raw)

Hello.
Can you please send the raw html that you get? You can do this by adding print(raw) after line 81:
def download_page(page: int):
    path = Path(f"{PAGE_PATH}/{page}")

    if not os.path.exists(path):
        os.mkdir(path)

    raw = get_raw_html(page)
+   print(raw)
    base_url = get_base_url(raw)
    remote_urls = get_remote_urls(raw)
    download_remote_resources(page, base_url, remote_urls)
    create_html_file(page, raw)

My friend has been having this issue and this is the raw html that he got:

Yeah, I’m busy but should be able to get that to you in a few hours.
On Tue, Sep 3, 2024 at 18:13, Jared Marriner @.***(mailto:On Tue, Sep 3, 2024 at 18:13, Jared Marriner < wrote:

Hello.
Can you please send the raw html that you get? You can do this by adding print(raw) after line 81:
def download_page(page: int):
path = Path(f"{PAGE_PATH}/{page}")
if not os.path.exists(path):
    os.mkdir(path)

raw = get_raw_html(page)

print(raw)
base_url = get_base_url(raw)
remote_urls = get_remote_urls(raw)
download_remote_resources(page, base_url, remote_urls)
create_html_file(page, raw)

My friend has been having this issue and this is the raw html that he got:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Hello.
Can you please send the raw html that you get? You can do this by adding print(raw) after line 81:
def download_page(page: int):
    path = Path(f"{PAGE_PATH}/{page}")

    if not os.path.exists(path):
        os.mkdir(path)

    raw = get_raw_html(page)
+   print(raw)
    base_url = get_base_url(raw)
    remote_urls = get_remote_urls(raw)
    download_remote_resources(page, base_url, remote_urls)
    create_html_file(page, raw)

My friend has been having this issue and this is the raw html that he got:

This isn't the full html file. If that is what is being printed, try saving the file instead.

Hello.
Can you please send the raw html that you get? You can do this by adding print(raw) after line 81:
def download_page(page: int):
    path = Path(f"{PAGE_PATH}/{page}")

    if not os.path.exists(path):
        os.mkdir(path)

    raw = get_raw_html(page)
+   print(raw)
    base_url = get_base_url(raw)
    remote_urls = get_remote_urls(raw)
    download_remote_resources(page, base_url, remote_urls)
    create_html_file(page, raw)

My friend has been having this issue and this is the raw html that he got:

This isn't the full html file. If that is what is being printed, try saving the file instead.

I am having the same issue and this is what is in the html:
<!doctype html><meta charset="utf-8"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="RedShelf Reader"/><title>RedShelf Reader</title><link rel="shortcut icon" href="/read/static/images/favicon.ico"/><link rel="icon" type="image/png" href="/read/static/images/icon.png"/><link rel="icon" sizes="192x192" href="/read/static/images/touch-icon-192x192.png"/><link rel="apple-touch-icon-precomposed" sizes="180x180" href="/read/static/images/apple-touch-icon-180x180-precomposed.png"/><link rel="apple-touch-icon-precomposed" sizes="152x152" href="/read/static/images/apple-touch-icon-152x152-precomposed.png"/><link rel="apple-touch-icon-precomposed" sizes="120x120" href="/read/static/images/apple-touch-icon-120x120-precomposed.png"/><link rel="apple-touch-icon-precomposed" sizes="76x76" href="/read/static/images/apple-touch-icon-76x76-precomposed.png"/><link rel="apple-touch-icon-precomposed" href="/read/static/images/apple-touch-icon-precomposed.png"/><link href="/read/static/css/main.4b2ac2d4.css" rel="stylesheet">You need to enable JavaScript to run this app.

Is this issue being worked on, or been fixed? I have a textbook I'd like to use this on and I do have a time limit to do it.

@Comrade-Spood Sorry I am a little busy with other things. Do you get the same html file as @akoot did? If it says you need javascript enabled then perhaps you are using an incorrect url to get the page.

@Comrade-Spood Sorry I am a little busy with other things. Do you get the same html file as @akoot did? If it says you need javascript enabled then perhaps you are using an incorrect url to get the page.

I got what DaystromInst got. For some reason I could not figure out how to get it to give me the right html file.


Add Shane's info

closes #12

hi @Shantaa kindly add in the PR description which issue this commit closes. thanks

hi @Shantaa kindly add in the PR description which issue this commit closes. thanks

done sincere apologies

hi @Shantaa kindly add in the PR description which issue this commit closes. thanks

done sincere apologies

Is this telegram?

it might be.

hi @Shantaa kindly add in the PR description which issue this commit closes. thanks

done sincere apologies

Is this telegram?


Cabal sandboxing confusion

In the build script, you currently do one cabal sandbox init at the beginning, then other cabal sandbox inits later on. You are creating two different sandboxes that way!
The first cabal sandbox init, in the root directory, creates a sandbox root/.cabal-sandbox, so its build results would go into root/.cabal-sandbox/bin etc.
Then, later, in subdirectories of root you do cabal sandbox init --sandbox ... This is not reusing the earlier created sandbox. Instead, you are telling cabal to create a new sandbox that will use directories like root/bin etc.
This is possibly a reason for issue #62.
Moreover, it is possibly a reason for why you don't see the success in #63 that you expect there. That @garyLockyer and @mgold have different versions of aeson in their build plans indicates that your cabal.config version constraints do not get taken into account. The reason is possibly where you put it, and which sandboxes actually get used. In my experiments with https://www.stackage.org/lts/cabal.config, I always put the cabal.config file into the directory of the project currently being built. So cabal.config should then be in root/elm-compiler, in root/elm-repl etc., not in root itself. Maybe there is a way to have cabal pick it up from the root location, via sandbox sharing. But the current way is obviously not working. (As said above, all the project builds do not actually use the sandbox you created at the very beginning. Instead, that one is completely ignored, instead the first project build makes another new one, and that one is used by all later project builds.)

You can see what I mean by looking at this:
Creating a new sandbox at /home/teddy/Programy/Elm-Platform/0.15.1/.cabal-sandbox

and this:
Creating a new sandbox at /home/teddy/Programy/Elm-Platform/0.15.1

in @TeddyDD's gist, from a single run of BuildFromSource.hs (which has the same problem).

Closing this, since it's addressed by my pull request #65.


For issue: #27

Change the direction attribute and rename it 'srldirection'. If my change is accepted, could you update also the maven lib?
Regards!

Hello @yeshuamayen
Could you actually add an underscore to the attribute (that's what we actually do on other libraries than this one, but this one is old and we did not updated it from a long time ^^).
So it would be srl_direction?
Thank you very much in advance.
Sorry for the delay, with the holiday period and all ^^

Hello @olivierg13 !
I have already add the underscore to the attribute.
Thanks and good day! :)

Cool thx!
I'm gonna merge it and publish a 1.2.2 on maven (available in a few minutes/hours).
Cheers,
Olivier


Add missing copyright headers.

@aljones15 pretty clerical, but something we need to monitor more closely.


Ci/cd formatting

PR-Codex overview
This PR updates GitHub Actions workflows by adding a new job named Scan to the existing jobs in three different workflow files.
Detailed summary

Added a new job named Scan to the build job in .github/workflows/xcop.yml.
Added a new job named Scan to the pdd job in .github/workflows/pdd.yml.
Added a new job named Scan to the codecov job in .github/workflows/codecov.yml.
Updated the branches configuration in .github/workflows/codecov.yml to use a list format.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@hizmailovich OK, I'll try to merge now. You can check the progress of the merge here


[Bug]: Message listener functions shows up as an error on JS objects

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Message listener functions shows up as an error on JS objects but works fine on trigger field of a widget
Steps To Reproduce

Go to GAC DP https://ee-2453.dp.appsmith.com/
Type in windowMessageListener() on a widget trigger field and JS object and observe the error on the object

Public Sample App
https://ee-2453.dp.appsmith.com/
Environment
Deploy Preview
Issue video log
No response
Version
Cloud

Message listener not available on this DP
@RakshaKShetty

Message listener not available on this DP
@RakshaKShetty


add baseUrl parameter to support slack-compatible integrations

Remove Merge Conflicts from https://github.com/jenkinsci/slack-plugin/pull/204
Add some documentation

@Reamer can you ammend your PR so that there's two commits?  One commit for the author of #204 and a second commit for your additional changes?  I prefer to preserve credit where due in the contributor statistics.  If you like; give me write access to your branch and I can do it for you.

I'll test this change now.

So far in my testing; upgrading the plugin from 2.1 to 2.2-SNAPSHOT doesn't break any configurations.  That's a good start.  Now I'm going to review the code.

I have mattermost configured on http://localhost:8065/.  How do I configure the Slack plugin to interact with it?  I don't know how to test this feature.
Bootstrap Jenkins with slack configured and a mattermost machine (requires vagrant).

Clone https://github.com/samrocketman/jenkins-bootstrap-slack
Bring up mattermost; vagrant up; once mattermost is up you can visit http://localhost:8065/.
Bring up Jenkins; ./slack_bootstrap.sh; The end of the console output will include how to log into it.

Beyond that; I don't know how to test the integration.

@samrocketman You have now write access to my branch.
To test this feature with mattermost:

Login to Mattermost
click in the upper right corner on three points
click on Integrations
click on Incoming Webhooks
Create a Webhook
You should now have a URL with a Token, something like this (https://mydomain.com/hooks/xxxxxxxxxxxxxx)
"https://mydomain.com/hooks/" is your baseUrl + "xxxxxxxxxxxxxx" your token.

Now I will take a look into your Vagrant-Box

@samrocketman: Vagrant is up and running, but I doesn't want a local jenkins server on my os. I was wondering that the integration button was missing. After a clean install you must enable this integration
Go to http://localhost:8065/admin_console/integrations/custom and enable webhook integration. After this you can follow my instructions in my last comment.
Let me know ,if I can help you with testing.

Thanks, I'll try it tomorrow.

Testing
So far adding a trailing slash is required.  I configured Base URL = http://localhost:8065/hooks/ and "Test Connection" button succeeded.  However, Base URL = http://localhost:8065/hooks causes "Test Connection" button to fail.  It should not matter; this is a bug.

Fully Tested
Okay, this has FINALLY been successfully tested.  I tested the following:

Upgrading configurations from prior version of Slack plugin (success).
Configured with Mattermost using http://localhost:8065/hooks (no trailing slash) (success).
Configured with Mattermost using http://localhost:8065/hooks/ (trailing slash) (success).

This pull request is ready to be merged!

Thanks for your work @Reamer and @andrzejwp.

Feel free to subscribe to #296 for updates related to Slack Plugin 2.2 release.

Great! Sorry I didn't asist further. Hope this makes it to the public release soon. Thanks!

No worries.  It's challenging to stay on top of volunteer stuff so I appreciate your contributions.


fix(kubeserver): cluster ca and key field nullable deleted

3.6

fix: https://github.com/yunionio/yunioncloud/issues/10915


perf(key-result): load key results in memory to reduce excessive quer…

…ying
🎢 Motivation
A brief summary of the purpose of this PR.
🔧 Solution
How the implementation works or fixes the issue.
🚨  Testing
A brief description of how the reviewer can test my PR.
🃏 Task Card
Link to issue on Jira

BUD22-123

🔗 Related PRs
This PR is related to some other PRs in different services, they are:

project#PR_NUMBER

🍩 Validation
Who tested this PR?
Canary

[ ] Marcelo
[ ] Gustavo
[ ] Aline

Dev

[ ] Perin
[ ] Guilherme
[ ] Rodrigo
[ ] Diego

Descartei esta mudança por enquanto porque teve um resultado pior do que eu esperava.


Speed up "sending tarball" step for PythonFunction CDK Construct

What is the problem you're trying to solve?.
When I use the PythonFunction CDK construct, I'm experiencing very slow image build times. See example below. The slow step is the "sending tarball" part which takes ~60 seconds (per function) on every deploy. I'm not 100% sure this is a finch issue, but it seems like it might be related based on #412.
> cdk deploy "**" --require-approval never

Bundling asset lh-stickb/data/InitDbCR/DbMigrationFunction/Code/Stage...

  infra/cdk.out/bundling-temp-cc678e010fa9f9810641f894e6f344652008fa8a4cfc0b9c95358adb9dd01ee7/index.mjs      193.8kb
  infra/cdk.out/bundling-temp-cc678e010fa9f9810641f894e6f344652008fa8a4cfc0b9c95358adb9dd01ee7/index.mjs.map  977.5kb

⚡ Done in 104ms
#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 1.32kB 0.0s done
#1 DONE 0.0s

#2 [internal] load metadata for public.ecr.aws/sam/build-python3.12:latest
#2 ...

#3 [auth] aws:: sam/build-python3.12:pull token for public.ecr.aws
#3 DONE 0.0s

#2 [internal] load metadata for public.ecr.aws/sam/build-python3.12:latest
#2 DONE 2.6s

#4 [internal] load .dockerignore
#4 transferring context: 2B 0.0s done
#4 DONE 0.1s

#5 [1/2] FROM public.ecr.aws/sam/build-python3.12:latest@sha256:21608d5510c34056470cd48875d77be1a859b1a0a0471de1e73f61f80e05ee25
#5 resolve public.ecr.aws/sam/build-python3.12:latest@sha256:21608d5510c34056470cd48875d77be1a859b1a0a0471de1e73f61f80e05ee25
#5 resolve public.ecr.aws/sam/build-python3.12:latest@sha256:21608d5510c34056470cd48875d77be1a859b1a0a0471de1e73f61f80e05ee25 0.1s done
#5 DONE 0.1s

#6 [2/2] RUN     python -m venv /usr/app/venv &&     mkdir /tmp/pip-cache &&     chmod -R 777 /tmp/pip-cache &&     pip install --upgrade pip &&     mkdir /tmp/poetry-cache &&     chmod -R 777 /tmp/poetry-cache &&     pip install pipenv==2022.4.8 poetry==1.5.1 &&     rm -rf /tmp/pip-cache/* /tmp/poetry-cache/*
#6 CACHED

#7 exporting to docker image format
#7 exporting layers 0.0s done
#7 exporting manifest sha256:0088dd21c818679b3f1b9943c238614107f9549051f6f008d745be8b34cf2df0 done
#7 exporting config sha256:296cf64f3d73791e304b9c5f9236fdcad178f4c79c1cc97a6c972b2e9ad3d541 done
#7 sending tarball
#7 sending tarball 57.7s done // NOTICE HERE
#7 DONE 57.7s
unpacking docker.io/library/cdk-494312d8bd232151bea24b90d65d84f4c30e86e2996d22c26490f0d7e8b1a6e9:latest (sha256:0088dd21c818679b3f1b9943c238614107f9549051f6f008d745be8b34cf2df0)...
Loaded image: docker.io/library/cdk-494312d8bd232151bea24b90d65d84f4c30e86e2996d22c26490f0d7e8b1a6e9:latest

Describe the feature you'd like
I'd like the whole image build step to be cached, but if that cannot be done then for the "sending tarball" step to be faster.
Additional context
Finch Version: finch version v1.1.2
finch.yml:
cpus: 3
memory: 4GiB
creds_helpers:
    - ecr-login
vmType: qemu
rosetta: false

@bestickley  We have merged a pr upstream for this that would avoid creating tarballs.
Once it is in stable release for nerdctl we would update finch to avoid creating tarballs
https://github.com/containerd/nerdctl/pull/2834

@Shubhranshu153, just wanted to check on status of this.


We should use Docker so it's seamless to use

Trying to see what people think about having a Docker workflow so we can use licensed seamlessly. We currently use brakeman in this fashion and would also be good to do for licensed.
docker run -v "$(pwd)":/code github/licensed licensed status

Thoughts?

@westoque :wave: thats a really great question and I've already spent a long time trying to figure out 😞 .
Due to quite a bit of complexity I ended up dropping any docker-specific work in favor of distributing self-contained executables that can be downloaded for each licensed release.
TL;DR this is a hard problem for licensed since it has unique environment requirements per usage.  I recommend for users to create custom Dockerfiles for their projects and to install licensed into those images.  There are additional options for some non-docker scenarios
There's a few major problems that make a tool like licensed not a great idea for "officially supported" docker images.
First, licensed needs an available runtime for each tool/language/framework being used.  This becomes a problem because everyone's use case is different - I've seen projects using go, ruby and npm all in the same repo.  Do users want to run each language in separate docker containers, or in a single container that has all available frameworks?  Do the maintainers of the project need to support a docker image for every combination of tools that licensed supports, for each supported version of each tool/framework?  That sounds... less than fun 😆
There's an additional issue with an all-in-one image, in that it will be LARGE.  When I attempted to work through this, a workable Haskell installation alone was multiple GB.  Downloading that into CI environments, or locally, sounds terrible and would need to be redone whenever licensed is released - on average maybe once or twice a month.
I also attempted to provide a docker image that contained ruby, licensed and scripting to install each tool as needed in the docker image.  The problem there is that it can add a significant amount of setup time in the container before licensed is usable.
For projects that include ruby, that's easy enough with gem install licensed [version] or including licensed in a Gemfile / gemspec and picking it up as part of bundle install.
For projects that don't include ruby, every release since 1.2.0 includes executables that can be downloaded and run.  They're not the smallest files as they're basically a self-extracting archive of a ruby runtime and the licensed code but they should be small enough to be alright in most situations.
Recently, some additional tools have been made to make using licensed easier in specific scenarios

a bundler plugin - ref
a pair of GitHub Actions to help make running licensed in your GitHub Action workflow easier - ref

:wave: @westoque I'm going to close this as it hasn't gotten any feedback, but please let me know if you think there's more to chat about!

👋 @westoque I'm going to close this as it hasn't gotten any feedback, but please let me know if you think there's more to chat about!

yup. i think your explanation is perfect. i hope others find that helpful as well.


fix: win32 meteor yarn (Release 40)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

What is the current behavior? (You can also link to an open issue here)

Repo package install scripts don't work correctly on Windows.

What is the new behavior (if this is a feature change)?

Patches the yarn installation so that it works with meteor yarn

Other information:

Status

[x] Code documentation for the relevant parts in the code have been added/updated by the PR author
[x] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Just tested this, and it seems to solve the issues on my machine 👍


allow creation of empty text node when range points past end of line

Fixes https://github.com/natejenkins/squire/issues/44
Easy to reproduce bug - hit space at the end of a line when inside an inline style element (bold, italics, code). The range localization (child at current offset) goes past the end of the line, making child undefined - in this case, we should create a text node instead of throwing an error.
The only reason we never see this for text in regular divs is that divs end with brs, so brs become the focused node (instead of undefined).

(© one line fix ™)

root && child && is superior! No idea what this PR is about, came to see THE line

hey I'm having trouble reproducing this.  Can you give the html contents of a squire editor and where I can position the cursor and click backspace to get the error?  thx

Typo, corrected: I meant hit "space" at the end of the line

ah, well that does change things

nice


IOS No Mail Accounts

On startup alert comes 'No Mail Accounts' in ios how can we disable this?

Which plugin version are you on?

4.3.7

Check this (was fixed in 4.3.8)

i have upgrade to 4.3.13 still issue is there


Issue with Targeted IaC and SAST Scanning in Trivy Action

I'm encountering an issue where Trivy scans the entire repository instead of just the changed files or the latest commits.
I initially attempted the fetch-depth: 1 method in the checkout action, but this did not limit the scan to recent changes. Subsequently, I tried the shallow cloning approach i have used with TruffleHog, but Trivy still scanned the entire repository instead of focusing on the modified files (new commits).
What am I doing wrong or how else can I achieve my goal (scanning only the changed files and the pushed code)?
I am not able to scan with trivy just the changed files/ lastest commits. On Every Scan the whole Repo is scanned.
What i am doing wrong or can i achieve my intention ?
I have first tested with the Checkout fetch-depth: 1 Way, was not working
`
name: IaC scan
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
name: Checkout
with:
fetch-depth: 1
  - name: Run Trivy static analysis
    uses: aquasecurity/trivy-action@master
    with:
      scan-type: 'fs'
      scanners: 'config'
      ignore-unfixed: false
      format: 'table'
      vuln-type: 'os,library'
      severity: 'CRITICAL'

`
`    name: IAC Scan with Trivy
runs-on: ubuntu-latest
steps:
- name: File Change Detection
shell: bash
run: |
if [ "${{ github.event_name }}" == "push" ]; then
echo "depth=$(($(jq length <<< '${{ toJson(github.event.commits) }}') + 2))" >> $GITHUB_ENV
echo "branch=${{ github.ref_name }}" >> $GITHUB_ENV
fi
if [ "${{ github.event_name }}" == "pull_request" ]; then
echo "depth=$((${{ github.event.pull_request.commits }}+2))" >> $GITHUB_ENV
echo "branch=${{ github.event.pull_request.head.ref }}" >> $GITHUB_ENV
fi
  - uses: actions/checkout@v4
    with:
      ref: ${{env.branch}}
      fetch-depth: ${{env.depth}}

  - name: Run Trivy static analysis
    uses: aquasecurity/trivy-action@master
    with:
      scan-type: 'fs'
      format: 'table'
      severity: 'CRITICAL,HIGH'

`

Hi @ameurmeddeb-zero. I don't think this is possible trivy fs will scan all files and directories recursively, If you wanted to scan just Terraform you could do trivy config (scan-type: config). The fetch with --depth will still include all of the files from your git repository, However, the git history will be incomplete.

Hello @kderck  :wave:
I need to create the same functionality: having trivy to run solely on the committed files. I understand this may be not a part of the action feature, and it is more focus on having a periodic full scan, that would report back to github code scanning.  ref.
Having a closer look, it looks like the code can easily be patched by adding an additional command[ line argument for a file path ].(https://github.com/aquasecurity/trivy-action/blob/1f6384b6ceecbbc6673526f865b818a2a06b07c9/entrypoint.sh#L196C4-L196C57)
Is this something you are thinking to add ?


replace cx_Oracle to python-oracledb

What type of PR is this?

[x] Refactor
[x] Feature
[x] Other

Description

This is a pull request to switch the Oracle Driver module from cx_Oracle to python-oracledb.
Please note the following points with this change.

The supported Python version is 3.6 or higher.🐍
The supported Oracle database version is 12c or higher.

Thin mode: 12c or higher.
Thick mode: 9.2 or higher. (with Oracle Client library)

In Thin mode, you do not need the Oracle Client library⭕
The ENCODING option has been deprecated. Please set the NLS_LANG environment variable instead.❌ -> The environment variable "NLS_LANG" is also used now.

https://python-oracledb.readthedocs.io/en/latest/user_guide/globalization.html#setting-the-client-character-set

For other considerations from cx_Oracle changes, please refer to the following documents.

https://oracle.github.io/python-cx_Oracle/#features
https://oracle.github.io/python-oracledb/#features

Please review and let me know if you have any comments. Thank you.🙇♂
How is this tested?

[x] Unit tests (pytest, jest)
[x] E2E Tests (Cypress)
[x] Manually

Related Tickets & Documents

#6373
#6380
Mobile & Desktop Screenshots/Recordings (if there are UI changes)

The error message being shown there felt very familiar to me, as I remember something very similar in the old "RedashCommunity" repository.
I think you can fix it by removing the --record option from client/cypress/cypress.js.
Like in this patch: https://github.com/RedashCommunity/redash/commit/a5d12b1740402a25dce6ded436af5e3fbd227d79

I think you can fix it by removing the --record option from client/cypress/cypress.js.

Thank you very much.
I will try it.

Awesome.  Looks like this python-oracledb concept works. :smile:

@justinclift
When I create a pull request to getredash/redash, do I need to submit this commit with it? 3893072bfe4e09d564049ae28c4cf58c461b0821

@snickerjp Nope.  That commit was just working around an issue in forked repositories.  The PR doesn't need it. :smile:

@justinclift
I understand.
I will remove this commit when I submit a pull request to getredash/redash.


Node:fs disturbs Express?

I cant use node:fs.readdir() in express.
i want to use readdir() to load routes automatically, but i find that it is ok when run dev and Not Found when access the route.
whats a problem? is it because i dont have a deep understanding of whats the effect of readdir() or readdir() cant be used like this?
the main code is following:
app.js
const {useRouter} = require('./routes/index')
useRouter(app)

./routes/index
const { readdir} = require('node:fs/promises')
const user = require('./user')

const useRouter = async function(app) {
    // Not Found when access the route
    await readdir(__dirname)

    app.use(user.path, user.router)
}

module.exports = {
    useRouter
}

./user
const express = require('express')

const path = '/user'
const router = express.Router()

router.get('/login', (req, res) => {
    res.json({
        msg: 'logined'
    })
})

module.exports = { path, router }

Hi,
There is no issue with using readdir inside an app using express js as far as I know and tested.
The issue with your code might be different.
Did you check what you're getting in __dirname?

@JeensmLill There's one possible issue with your code - useRouter is an async function, but you call it as a sync one.

Your code works for me when I add few lines, so app.js from example looks like:
const express = require('express')
const app = express()

const {useRouter} = require('./routes')

useRouter(app).then(() => {
    app.listen(3000)
})

and the route is:
GET http://localhost:3000/user/login](http://localhost:3000/user/login

@ArtemNikolaev Oh yeah, that is the problem!
I forget the possibility that the problem will come from the async function,  becauce nodejs does not support top-level await.
Maybe I should use readdir() with a sync version originally.
Hhh, I think it must be the amnesia of the rookie using async function like me.
@ArtemNikolaev, thank you for reminding me!!!


Add Press Start (Piano Cover) by MDK

Song Name
Press Start (Piano Cover)
Artist Name
MDK
Source
Youtube
Youtube Link
jYmpqTI7xBo
Direct File Link
No response
Song ID
37
Start Offset [ms]
3500
Extra
Created from Auto Nong.
Created for level: 77243256
Downloaded: Yes

Accept


Function breakpoints - protocol allows condition but no UI to set condition

Maybe I'm missing something in the debug UI experience but I see no way to add a condition to a function breakpoint even though the debug protocol supports it.

You are correct, function breakpoints currently can not have a condition.
We will add this in the future to the UI

Thanks for the confirmation!  Glad to hear it is a planned feature.

UI for conditional breakpoints exists for quite some time:

Ropened because function breakpoints do not appear in the gutter and provide no UI to add/edit their condition.

@weinand should this really be closed? The feature is supported in the DAP, it would be nice if it was also surfaced in the UI.

Yes, this is a valid feature request and we should address it because bringing VS Code's debugger UI on par with the Debug Adapter Protocol is actually on the VS Code roadmap.

Let's assign to this milestone for the inital investigation.
Ideas on how the UX would look like are welcome.
Here's how this looks for Exception Breakpoints https://github.com/microsoft/vscode/issues/111227#issuecomment-734870584
I would probably go with a similar approach for function breakpoints
fyi @connor4312

Hi,
First of all, thanks for adding this to January goal !
I saw how you handled conditions for breakpoint filters.
Since FunctionBreakpoint has as hitCount attribute as well, I see two possibilities:

it can be shown the same way as ExceptionBreakpoint with a Edit Hit Count and Edit Condition actions.
it can be shown as a drop-down menu the same way as SourceBreakpoint

Thanks

@YannickMeeus thanks for jumping in and for sharing ideas.
If we do it inline like we did for Exception Breakpoint than indeed we need two actions as you proposed. Since there is not enough vertical space for a rich widget that could have a drop-down.
If we do a rich breakpoint widget than the question is where to show it, in what editor/

Yes, you are right about vertical space, I missed that point.
Maybe instead of showing full name for Condition and Hit Count we can display products icons such as symbol-key and symbol-numeric (or new/customized ones) to reduce vertical constraints.
If you click on this logo it will display a drop-down with logo + full text and this text will be reduced after selection.

Here's an idea:

We add a Context Menu action to the Function Breakpoint: "Edit Condition". We also add an inline edit action (like propossed here https://github.com/microsoft/vscode/issues/113805)
When this action is executed we simply open the editor breakpoint widget in the Active editor and pass focus to the widget. We open the widget on cursor location. Even though the Function breakpoint is not tied to the active editor this will give us the most space, and a same experience as for regular breakpoints.
Rare corner case where there is no editor open: this action is disabled

I believe that in practice this will work nicely.
@weinand @connor4312 @yannickowow let me know what you think? I can also present this in the UX meeting today.

Here's an idea:

We add a Context Menu action to the Function Breakpoint: "Edit Condition". We also add an inline edit action (like propossed here https://github.com/microsoft/vscode/issues/113805)
When this action is executed we simply open the editor breakpoint widget in the Active editor and pass focus to the widget. We open the widget on cursor location. Even though the Function breakpoint is not tied to the active editor this will give us the most space, and a same experience as for regular breakpoints.
Rare corner case where there is no editor open: this action is disabled

I believe that in practice this will work nicely.
@weinand @connor4312 @yannickowow let me know what you think? I can also present this in the UX meeting today.

@isidorn editing an object (here a function breakpoint) in a random unrelated editor is a kludge.
I see two options:

we use the same UI as done for the exception breakpoints
we open the editor breakpoint widget in the breakpoints view

@isidorn editing an object (here a function breakpoint) in a random unrelated editor is a kludge.
I see two options:

we use the same UI as done for the exception breakpoints
we open the editor breakpoint widget in the breakpoints view

@weinand thanks for feedback. Editor breakpoint widget can not be rendered in the breakpoints view, it requires an editor the way it is implemented.
So let's go with option 1 and use the same UI as done for exception breakpoints, and have two context menu options as @yannickowow proposed Edit Hit Count and Edit Condition

@weinand thanks for feedback. Editor breakpoint widget can not be rendered in the breakpoints view, it requires an editor the way it is implemented.
So let's go with option 1 and use the same UI as done for exception breakpoints, and have two context menu options as @yannickowow proposed Edit Hit Count and Edit Condition

I have pushed a first version of this. Please try it out with VS Code insiders from tomorrow.
A UI corner case is when a Function Breakpoint has both a Hit Cound and a Condition. I try to render both, and am happy with the final result (can be seen in the gif).
What is not shown in this demo: the Edit Condition inline action and the context menu action gets disabled if the Exception Breakpoint does not support conditions, or if there is a debug adapter connected which states in it capabilities that it does not support conditions.

I have pushed a first version of this. Please try it out with VS Code insiders from tomorrow.
A UI corner case is when a Function Breakpoint has both a Hit Cound and a Condition. I try to render both, and am happy with the final result (can be seen in the gif).
What is not shown in this demo: the Edit Condition inline action and the context menu action gets disabled if the Exception Breakpoint does not support conditions, or if there is a debug adapter connected which states in it capabilities that it does not support conditions.

It looks good and intuitive to me ! Thanks a lot !

It looks good and intuitive to me ! Thanks a lot !

Great, looking forward to feedback.

Great, looking forward to feedback.


[Feature Request] Synchronize additional book metadata (% Read, Total Pages, etc)

Describe the solution you'd like
I would love if the % complete, total pages in the book, total pages read, etc were also synced and added to the page metadata.

HI @evitiello. In terms of your suggestion:
Already exists:

Total pages in book - the plugin makes this data available if its a book purchased from Amazon

No possible known way - there is no way that the Kindle or Amazon exposes this information:

% complete
Total pages read

Gotcha, thank you!


Add flow-typed to files

What: added flow-typed to the npm package

Why:

How:

Checklist:

[ ] Documentation
[ ] Tests
[x] Ready to be merged

[ ] Added myself to contributors table

:tada: This PR is included in version 2.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The place_masks given to place_text routine may be modified casually if None is returned by the routine

Hi Ankush,
The place_masks given to place_text routine may be modified casually if None is returned by the routine. This could cause the mask collision for the next round of text placing.
Can you help confirm if there's any issue? Thanks.

Hi @bravelywangexocr,
Can you please explain what you mean by "modified casually"?


fix(crit): rename sa.proto and core.proto

In Podman, the core.proto and sa.proto files from https://github.com/letsencrypt/boulder conflict with identically named proto files in crit, causing a panic during the build. As a workaround, these two files have been renamed to criu-core.proto and criu-sa.proto.

Can you describe the problem a bit more in detail.

Codecov Report

Merging #90 (4ca4d9a) into master (287ed08) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 4ca4d9a differs from pull request most recent head def02ab.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Can you describe the problem a bit more in detail.

This pull request adds a fix the problem that occurred in https://github.com/containers/podman/pull/15591 after updating go-criu to v6.0.0:
panic: proto: file "sa.proto" is already registered
	previously from: "github.com/letsencrypt/boulder/sa/proto"
	currently from:  "github.com/checkpoint-restore/go-criu/v6/crit/images"
See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

Not really convinced about this. This global protobuf namespace is very unfortunate. Can we fix it in another way?
In the link there is something about a go_package option. Can that be passed during proto -> pb.go compilation?

In the link there is something about a go_package option. Can that be passed during proto -> pb.go compilation?

@adrianreber According to the language guide at https://developers.google.com/protocol-buffers/docs/proto#packages:

In Go, the package directive is ignored, and the generated .pb.go file is in the package named after the corresponding go_proto_library rule.

I also looked at it and found no real solution. The thing about this change is that it seems temporary until we meet another namespace collision. So maybe we have to namespace all files now. Would something like this work:
$ for i in criu-temp/images/*.proto; do if [[ "$i" == *"opts.proto" ]]; then continue; fi; sed -e 's,import\s",import "criu-,g' -i $i; done
$ for i in criu-temp/images/*.proto; do cp -v $i ./images/criu-$(basename $i); done

This is really unfortunate. Maybe we need to do this change on the CRIU level. It should not break the content of the existing images, I hope, but if we include the namespacing already in CRIU the changes here are no longer necessary.

@adrianreber @rst0git The issue is fixed in Go by adding a package directive to all the .proto files. This prevents conflicts in the protobuf namespace, while keeping the Go bindings unchanged. To ensure we don't have any more conflicts in the future, it would be prudent to pick a unique and verbose package name. I would suggest package checkpoint.restore (I tested with this, podman is building successfully).
Unfortunately, this change on criu breaks the generated C bindings. The package name is prepended to all protobuf messages, eg. checkpoint__restore__core_entry in core.pb-c.c, which generates a considerable number of errors. It would require a major overhaul of every reference to the messages in the codebase, which doesn't look like a practical refactor to me. Instead, we can keep the package directive exclusive to the .proto files in this repository only, possibly by injecting it through the gen-proto target in crit/Makefile with something like:
ls crit/images/*.proto | xargs sed -i '/syntax/a package checkpoint.restore;\n'

If that works. That sounds much cleaner to me.

Looking at the change now, especially with a possible integration of this change in the main CRIU repository, I think criu as package name would make more sense than checkpoint.restore as all files are from the CRIU repository/project.

@adrianreber that was indeed my first thought too, but we cannot use package criu as it conflicts with the criu field in opts.proto.

@adrianreber that was indeed my first thought too, but we cannot use package criu as it conflicts with the criu field in opts.proto.

What is the error message you get?

What is the error message you get?

Something along the lines of criu has already been declared. Oddly enough, I tried it again now, and it works :thinking: will change and push

What is the error message you get?

Something along the lines of criu has already been declared. Oddly enough, I tried it again now, and it works thinking will change and push

:smile: I also tried it and it was working, that's why I asked. Good to see that it works now.

This PR works for me. @rst0git what do you think.
At some point we can try to push this change to CRIU and remove the sed line here.


Uncaught TypeError: Right-hand side of 'instanceof' is not callable

After I updated to newest version of markdown-preview-plus scroll sync does not work anymore and throws the following error on scrolling in the the markdown pane.
Atom: 1.23.3 x64
Electron: 1.6.15
OS: Ubuntu 17.10
Thrown From: markdown-scroll-sync package 2.1.2
Stack Trace
Uncaught TypeError: Right-hand side of 'instanceof' is not callable
At /home/simon/.atom/packages/markdown-scroll-sync/lib/main.coffee:38

TypeError: Right-hand side of 'instanceof' is not callable
    at /packages/markdown-scroll-sync/lib/main.coffee:38:14
    at Function.module.exports.Emitter.simpleDispatch (/opt/atom/resources/app/node_modules/event-kit/lib/emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (/opt/atom/resources/app/node_modules/event-kit/lib/emitter.js:141:34)
    at Workspace.didChangeActivePaneItemOnPaneContainer (/opt/atom/resources/app/src/workspace.js:492:28)
    at WorkspaceCenter.paneContainer.onDidChangeActivePaneItem (/opt/atom/resources/app/src/workspace-center.js:17:20)
    at Function.module.exports.Emitter.simpleDispatch (/opt/atom/resources/app/node_modules/event-kit/lib/emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (/opt/atom/resources/app/node_modules/event-kit/lib/emitter.js:141:34)
    at PaneContainer.didChangeActiveItemOnPane (/opt/atom/resources/app/src/pane-container.js:284:26)
    at PaneContainer.didActivatePane (/opt/atom/resources/app/src/pane-container.js:262:18)
    at Pane.activate (/opt/atom/resources/app/src/pane.js:1002:46)
    at Pane.focus (/opt/atom/resources/app/src/pane.js:393:23)
    at /app.asar/src/pane-element.js:51:25)

Commands

Non-Core Packages
adwaita-pro-ui 2.1.5
autocomplete-bibtex 1.1.0
color-picker 2.2.5
language-pfm 0.82.0
line-length-break 0.4.0
markdown-footnote 1.1.0
markdown-preview-plus 2.5.1
markdown-preview-plus-opener 0.2.0
markdown-scroll-sync 2.1.2
markdown-toc 0.4.2
markdown-writer 2.7.3
pandoc-convert 1.1.1
pandoc-minimal-syntax 0.2.0
pen-paper-coffee-syntax 0.14.9
regex-tester 0.2.0
tool-bar 1.1.4
tool-bar-markdown-writer 0.3.1
wordcount 2.10.4
Zen 0.18.0
zotero-citations 0.19.1
zotero-picker 1.5.0

Yup same, I juste have to open a .md file for this error to show up.


Trying to refactor the parsing

This looks really good! I'll let @hbertrand review since it's mostly his section of code

Needs a round of black before merging.


feat: import snappy dependency library

Add the snappy library and change leveldb to the specified version.

@CodiumAI-Agent /improve

@CodiumAI-Agent /review

PR Reviewer Guide 🔍

 ⏱ Estimated effort to review [1-5]
3

 🧪 Relevant tests
No

 🔒 Security concerns
No

 ⚡ Key issues to review

Dependency Management: The PR modifies the way dependencies are managed and built, specifically for leveldb and snappy. Ensure that these changes do not break the build process or create conflicts with other dependencies.

Build Configuration: The changes in CMake configuration for multiple components (leveldb, snappy, gflags) need careful review to ensure they are correctly set up for different build environments and do not introduce any build-time or runtime errors.


Audit Elevate NPSP Connector Installer and Product for Power of Us Hub links

W-11647682 (WI specifies Elevate but have changed it to be across all NPSP-based repos)
Performed audit and modification of POU links based on  https://docs.google.com/spreadsheets/d/1yqj16qZWe_LndjqvamQXINs_-XQ0ggjBDBpR-6EIhgo/edit#gid=1076789067
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

We are back at it again! After discussion with @ErinWiedemer and observing that there were some powerofus links still left in the NPSP code, we decided to just get address everything in the NPSP repo and get it all out of the way now regardless of what the audit sheet specifies, feedback and general observations are much appreciated, thank you!

Hi Balsam, I checked the links in all of these files. They are all good, though I am not sure we need all of the extra code at the end of them. For example, in https://help.salesforce.com/s/articleView?id=sfdo.NPSP_Automated_Soft_Credits.htm**&type=5"** I don't know if we need this or not: the bold portion or not. Especially because the URL uses &type=5 and not & amp; type=5. (Full URL is https://help.salesforce.com/s/articleView?id=sfdo.NPSP_Merge_Contacts.htm&type=5 though https://help.salesforce.com/s/articleView?id=sfdo.NPSP_Merge_Contacts.htm works too. This is pure ignorance on my part, so it's probably not a problem. I just want to make sure the replacement URLs work :)

@ErinWiedemer No pure ignorance at all, definitely a good question.  To answer the initial question, putting characters like & , <, or > in html by themselves will break the url as those are special characters that are already used for something else in html. So instead an amp; needs to be appended to those characters in order to escape them and allow them to be read properly as part of the string. So something like "https://help.salesforce.com/s/articleView?id=sfdo.NPSP_Merge_Contacts.htm&type=5" actually ends up being displayed as "https://help.salesforce.com/s/articleView?id=sfdo.NPSP_Merge_Contacts.htm&type=5". For the other part, yes I can definitely remove the &type=5 if that is seen as preferred, I actually originally had them as .htm without the query string &type=5 but I wasn't sure if that was significant as that's what the URL gets redirected to, whatever you prefer I can make the change 👍

@balsamhindi I definitely don't have a preference. I think it's fine to leave the &type=5.  Thanks for explaining the nomenclature. I wasn't sure about the use of the ampersand and "amp". So thanks for reassuring me that it works.