Type annotation for the whole package

This is a daunting task, even if the package is small. It is extensive, time-consuming and tedious. But is has the great advantage of standardization, robustness, flexibility and less error-prone source code, i.e., more like a true test-driven development style of code.
The following are options to achieve this:

Follow a standard: For everything Python related, we use Google's Python style guide

Use a type checker by default, some options are:

pyright
pytype
mypy

Automate type checking and testing, some options for this are:

nox
Invoke

We should also look into TensorFlow specific types, as I'm aware that the actual TensorFlow source code is not type annotated, I don't know if actual types exist for this kind of objetcs.
Or is it that the actual object, such as numpy.ndarray are the types that we can use to annotate the code. @gmagannaDevelop

As you said previously, this task is extensive, time-consuming and tedious.
Nevertheless I strongly agree on the benefits of typed Python code.
I'll dive into the documentation to properly start type-annotating the package's scripts.

For an initial, automated type format we could use MonkeyType which automatically generates type stubs when code is executed. This could be helpful for the first time to avoid doing everything by hand, and then adjusting properly if the types are not correctly inferred (which will be the case).

TensorFlow has been working on generating type stubs for most of the general and specific types used in the library, and there are other places we could look at if needed, like tensorflow-stubs.

In commit 43c7d9d I started looking into static type checking using mypy. It turns out that without stub files most of the imports are not recognized. With this, even though type annotation is useful, type checking which is the ultimate goal here is kind of useless.
There seems to be two options:

Create stub files for all the common types used in segnet.

Avoid using type checking, and with that rely on the developers experience to correctly type most of the code.

Can you have have a look at this @gmagannaDevelop ?

Closing in favor of the new 0.7 version where this is already implemented, see f639db82d77c52d93e639745c745af4cbaa866ce .


How do I access the current mode?

Hey, thanks for this library. I'm pretty new to programming and CS, having just started writing python recently. So having this library is really awesome because I can write some of my first "real" pieces of software for a WM that I love. Anyway.
Is there a way to get the current mode?  Thanks again.

The current mode is not exposed with the IPC, see https://i3wm.org/docs/ipc.html, and so is not available in this library. There is a binding modes reply, which lists the available modes.
An alternative would be to listen to changes in the binding mode. This way, you would be able to store the current binding in a variable based on the most recent change.

That's kind of strange that you can't do that. Open an issue on the i3 project if you would like it added to the ipc.

Thanks for the help. I'll post an issue to i3 so that maybe ipc can get it. I'll use one of the above suggested workarounds for now.

Airblader says:
"You can get the mode (i3bar needs it as well). You just can't query it directly, but there is an event when it changes for which you can listen."
xfce4-i3-workspaces must be using this somehow. I don't know because I can't write C yet. But if you search for mode in that project I think it might be relevent in some way. Line 425-440:
https://github.com/denesb/xfce4-i3-workspaces-plugin/blob/master/panel-plugin/i3w-plugin.c

Here are the docs for listening to events

@acrisci Thanks thats making more sense. I understand now I need to do something like:
import i3ipc i3 = i3ipc.Connection() #starts the socket to listen on
Then create some sort of function to run for when the event happens.
def myfun():     #do something     print("Super fun")
Then do something like:
`
listen for events
i3.on('workspace::focus', myfun())
`
Closing the issue because it's not an issue. I just need to figure out how to listen for an event for mode change and name somehow.
Thanks again.


Add more installation detail

The installation section in getting started should have a bit more explanation.  A discussion on virtual environments, etc.  I the user just copy-pasts the code i think it should give them a working installation.  I'd be inclined to stick with he basics.
mkdir teehr-getting-started
cd teehr-getting-started
python3 -m venv .venv
source .venv/bin/activate
pip install 'teehr<EMAIL_ADDRESS>
I think we could remove the poetry part and just keep it simple.  Users can add complexity if the know how.

This is just an idea, might be worth looking at other repos to see how they do it.

@samlamont I will work on this while I am in here making other changes.

@mgdenno Sounds good, I was thinking we could potentially make the whole page a notebook, so we could execute the example at the bottom (and add more detail, e.g., plots?). Not sure if it's worth the effort though since it breaks the links with other pages.  I can take a quick look to see how feasible it is

Yeah, there seems to be a balance here as the notebooks are not quite as robust as the actual docs pages.

This was addressed in v0.4.0.


Bug: The app doesnt show me a full screen

The app doesnt allow me to add more bands to the expert EQ as the screen is blocked out at the bottom and I cant seem to get the app to minimize to make any changes

Hi, you can solve this issue using two methods, first is to change the display mode of the filters by clicking on the settings icon on the left of where you select the Expert EQ mode and change the "Bands Style" to "Mixer". Second is to click the settings icon on the top right of the window and reduce the "UI Scale" slider which would scale the whole UI down to fit. I would close this issue now, but feel free to reopen this if you have other things to add.
This issue is related to #552.


Working with MP3s

How can we use the library with MP3 files? At the moment when working with MP3, the error "Invalid wave file RIFF header" is thrown. The original Whisper supports MP3 files.

Original whisper does not support mp3, some example scripts just include the ffmpeg decoding step.

Hello @7702244,
@Alumniminium is right, Whisper as a model is only supporting wav. But you can use ffmpeg or NAudio to process other types.
I didn't want to introduce any additional dependency in the base package, but another package with NAudio integration (which will have dependency both NAudio and Whisper.net) would be great.

For example, I wrote an Adapter with FfMpegCore, which converts every given file to .wav with a 16kHz sampling rate. It saves the converted file to the origin's filename and changes its file extension to .wav. Just needed to install FfMpegCore via NuGet
FFMpegArguments
                    .FromFileInput(filePath)
                    .OutputToFile($"{outputFilePath}", true,
                        options => options
                            .ForceFormat("wav")
                            .WithAudioSamplingRate(16000))
                    .ProcessAsynchronously();

Works like a charm for me

Added also an example of how to use NAudio in order to convert the mp3 to wav 16 khz and pass it to Whisper.net:
https://github.com/sandrohanea/whisper.net/blob/main/examples/NAudioMp3/Program.cs
Ofc, FFmpeg can be used instead as @GFNiko shown above.

However, NAudio does not support Linux as it integrates too many Windows related APIs


updates export filename for users, comments, quiz, poll, and survey

fixes #161

updates export filename for comments to comments_timestamp
updates export filename for users to user_timestamp
updates export filename for poll to poll-poll_title_timestamp
updates export filename for survey to survey-survey_title_timestamp
updates export filename for quiz to quiz-quiz_title_timestamp

👍🏼

Issue #161 also prefixes some kind of identifier for the site name. Do we have something which could serve this purpose?


[Question] When Hive is queried, it reports that the zk-related classes cannot be found, such as: org.apache.curator

Before asking

[X] I have read the How to ask for help (我已阅读如何寻求帮助指引文档).

Your environment

Linkis version used: 1.1.2
Environment name and version:

cdh-5.14.2
hdp-3.1.5
hive-2.1.1
spark-3.2.1
scala-2.12.2
jdk 1.8.0_121
....

Describe your questions
When Hive is queried, it reports that the zk-related classes cannot be found, such as: org.apache.curator., error message: When executing the hive task, the log reports that the class starting with org.apache.curator. cannot be found, classNotFound
Hive查询的时候报：找不到zk相关的类比如：org.apache.curator.*,错误信息: 执行hive任务时，日志报找不到org.apache.curator.*开头的类，classNotFound
Eureka service list

eg:
Some logs info or acctch file

linkis-xxx.log:

<!--日志文字贴到这里-->

log file:

linkis-xxx.log

This is because the hive transaction is enabled, you can modify the hive-site.xml on the linkis machine to turn off the transaction configuration, refer to hive transaction: https://www.jianshu.com/p/aa0f0fdd234c
Or put the relevant packages in the engine plugin directory lib/linkis-engines/hive/dist/version/lib
这是因为开启了hive事务，可以在linkis的机器上面修改hive-site.xml关掉事务配置，参考hive事务：https://www.jianshu.com/p/aa0f0fdd234c
或者将相关包放到引擎插件目录中lib/linkis-engines/hive/dist/version/lib


Add additional tests for handling relative links in notebooks.

Added some relative links cases to the Link Dialog and Link Handler tests to better capture the manual steps in our test plan.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.656%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27183

Relevant Lines:
59220

💛  - Coveralls


[Question] - where can I get the 1.0.1 NuGet packages?

I am using 1.0.0 but I see there is a 1.0.1 patch release. Are those 1.0.1 NuGet packages available anywhere?

https://dotnet.myget.org/gallery/aspnetcore-patch

Cheers


Custom struct example does not work

Am I doing something wrong or is there a problem with the newest Rust compiler?
Cargo.toml:
[package]
name = "prefs"
version = "0.1.0"
authors = ["Sehny<EMAIL_ADDRESS>
[dependencies]
serde = "1.0"
serde_derive = "1.0"
preferences = "^1.1.0"

Source code:
#[macro_use]
extern crate serde_derive;
extern crate preferences;
use preferences::{AppInfo, Preferences};

const APP_INFO: AppInfo = AppInfo{name: "preferences", author: "Rust language community"};

// Deriving `Serialize` and `Deserialize` on a struct/enum automatically implements
// the `Preferences` trait.
#[derive(Serialize, Deserialize, PartialEq, Debug)]
struct PlayerData {
    level: u32,
    health: f32,
}

fn main() {

    let player = PlayerData{level: 2, health: 0.75};

    let prefs_key = "tests/docs/custom-types";
    let save_result = player.save(&APP_INFO, prefs_key);
    assert!(save_result.is_ok());

    // Method `load` is from trait `Preferences`.
    let load_result = PlayerData::load(&APP_INFO, prefs_key);
    assert!(load_result.is_ok());
    assert_eq!(load_result.unwrap(), player);

}

Build log:
$ rustc --version
rustc 1.23.0 (766bd11c8 2018-01-01)
$ cargo build
   Compiling quote v0.3.15
   Compiling dtoa v0.4.2
   Compiling num-traits v0.1.42
   Compiling serde v1.0.27
   Compiling itoa v0.3.4
   Compiling serde v0.9.15
   Compiling unicode-xid v0.0.4
   Compiling xdg v2.1.0
   Compiling synom v0.11.3
   Compiling syn v0.11.11
   Compiling app_dirs v1.1.1
   Compiling serde_derive_internals v0.19.0
   Compiling serde_derive v1.0.27
   Compiling serde_json v0.9.10
   Compiling preferences v1.1.0
   Compiling prefs v0.1.0 (file:///home/sehny/tmp/prefs)
error[E0599]: no method named `save` found for type `PlayerData` in the current scope
  --> src/main.rs:21:30
   |
21 |     let save_result = player.save(&APP_INFO, prefs_key);
   |                              ^^^^
   |
   = note: the method `save` exists but the following trait bounds were not satisfied:
           `PlayerData : preferences::Preferences`
   = help: items from traits can only be used if the trait is implemented and in scope
   = note: the following trait defines an item `save`, perhaps you need to implement it:
           candidate #1: `preferences::Preferences`

error[E0599]: no function or associated item named `load` found for type `PlayerData` in the current scope
  --> src/main.rs:25:23
   |
25 |     let load_result = PlayerData::load(&APP_INFO, prefs_key);
   |                       ^^^^^^^^^^^^^^^^
   |
   = note: the method `load` exists but the following trait bounds were not satisfied:
           `PlayerData : preferences::Preferences`
           `&PlayerData : preferences::Preferences`
           `&mut PlayerData : preferences::Preferences`
   = help: items from traits can only be used if the trait is implemented and in scope
   = note: the following trait defines an item `load`, perhaps you need to implement it:
           candidate #1: `preferences::Preferences`

error: aborting due to 2 previous errors

error: Could not compile `prefs`.

To learn more, run the command again with --verbose.

Problem seems to be due to serde 1.0 release. I have a similar problem right now :(

It should work with this fork:
https://github.com/Eh2406/preferences-rs/tree/patch-1


[5.3] Uploading multiple files doesn't work anymore (in conjunction with the Validator)

Laravel Version: 5.3.11
PHP Version: 7.0 (stable)
Database Driver & Version: MariaDB (latest stable)

Description:
PR https://github.com/laravel/framework/pull/15166 broke my file upload. I dug into the code and found out that is_uploaded_file() in isValid() returns false when being invoked from within the Validator with the changed code from the PR.
Steps To Reproduce:
This is a part of my code:
public function upload(Request $request) {
    $files = $request->files->get("files");
    foreach ($files as $i => $file) {
        $validator = $this->getValidationFactory()->make($files, [
            $i => "mimes:jpeg,jpg,png|max:3072"
        ], $custom_messages, []);

        if ($validator->fails()) {
        /*
            var_dump($file->isValid());
            die();
        */ // funny: isValid() returns true at this point
            var_dump($validator->failed());die();
            }
    }
}

Output:
array(1) {
  [0]=>
  array(1) {
    ["Mimes"]=>
    array(3) {
      [0]=>
      string(4) "jpeg"
      [1]=>
      string(3) "jpg"
      [2]=>
      string(3) "png"
    }
  }

So I can see the mime rules are failing.
If I var_dump() the guessed extension of the $file by calling var_dump($file->guessClientExtension()); die(); I correctly get jpeg.
I also tried calling $validator->setFiles([...]); but that didn't help either.

I don't seem to understand your issue, using your code on a fresh laravel 5.3 installation works for me, uploading 3 valid files passes, uploading any invalid files fails with the correct message.
It's not clear what your issue is, is it because the guessed extension is not correct at your end?

ping @dhardtke

Okay, I'm closing this since I've got it working by validating all files before uploading them in my foreach loop. I still don't understand why, when I upload two files, the validation of the second file results in an "uploaded" error ("uploaded" rule failing). I guess it must have two do with the upload of the two interfering each other somehow.
Somehow, is_uploaded_file() returns false for the second file in the loop.


Using styled-components in production to wrap the router breaks it

Version
4.2.0
Using electron 1.7.11
Binaries:

Node: 8.9.4 - /usr/local/bin/node
Yarn: 1.3.2 - /usr/local/bin/yarn
npm: 5.6.0 - /usr/local/bin/npm
Watchman: 4.7.0 - /usr/local/bin/watchman

npmPackages:

babel-plugin-styled-components: ^1.5.1 => 1.5.1
styled-components: ^3.2.6 => 3.2.6

Steps to reproduce
When we build for production the router stops working. It works perfectly in development. If we change the UserPanelSectionRouting styled component to a regular div with inline styles the routing will work.
class UserPanel extends PureComponent {

    constructor(props) {
        super(props);
    }

    render() {
        console.log('UserPanelSectionRouting', UserPanelSectionRouting)

        return(
            <MainSceneBackgroundContainer>
                <Menu />

                <UserPanelSectionRouting>
                    <Routes />
                </UserPanelSectionRouting>

            </MainSceneBackgroundContainer>
        )
    }
}

import styled                               from 'styled-components';

const UserPanelSectionRouting = styled.div`
    font-family: "Avenir Next";
    background-attachment: fixed;
    background-size: cover;
    flex: 1;
    position: relative;
    overflow-y: auto;
    margin-top: 80px;
    margin-bottom: 80px;
    margin-right: 44px;
`;

export default UserPanelSectionRouting;

const Routes = (props) => {
    let { match } = props;

    return(
        <Switch>
            <Redirect   exact   from={match.path}   to={`${match.url}/profile`} />

            <Route              path={`${match.path}/history`}          component={History}         />
            <Route              path={`${match.path}/not-authorized`}   component={NotAuthorized}   />
        </Switch>
    )
};

export default withRouter(Routes);

Expected Behavior
It should work as in development.
Actual Behavior
The routes are not rendering in production.

This sounds like an issue with styled-components. My best guess is a blocked update: https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/guides/blocked-updates.md


Added Application Registration to AzureAD for RabbitMQ testing purpose

Added AzureAD Application Registration to enable test of Azure Workload Identity auth against RabbitMQ as proposed in https://github.com/kedacore/keda/pull/4657
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Related to https://github.com/kedacore/keda/pull/4657

I guess that we will need to add more applications in the future. Could you create the module more abstract in order to reuse it?
I think that we can achieve it just moving this code to outside the module and passing it as variable:
application_name             = "${var.unique_project_name}-rabbitmq-app"
rabbitmq_roles = {
  management = "tag:management"
  administrator = "tag:administrator"
  read_all = "read:*/*/*"
  write_all = "write:*/*/*"
  configure_all = "configure:*/*/*"
}

(and renaming the resources, ofc)

@JorTurFer refactored to make it more generic module for app registraion.

There is an issue with the SP permission in our side, I'll update the issue once it's solved

Done, the app has been created! 😄


Tracking

/
#1996  feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f54bc635-cbe9-0a10-0936-fd97ef878a39
Version Independent ID: 793467bb-69e0-4093-6761-ce443318751e
Content: Tracking prevention in Microsoft Edge - Microsoft Edge Development
Content Source: microsoft-edge/web-platform/tracking-prevention.md
Product: microsoft-edge
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

Closing as incomplete. Please feel free to add more information if you have any and we can re-open the issue.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #470 (7ff60c0) into main (366ac3d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       42       42
=======================================
  Hits          378      378
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Missing parameter "-EnableCORS"

Hi,
I was not able to found any clarification to parameter:
-EnableCORS
How that could be used?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88845a18-3c61-4321-f35a-7bedbe81cdc2
Version Independent ID: 971d3596-6073-727b-ae99-39880f6d921f
Content: Set-CsAutodiscoverConfiguration (SkypeForBusiness)
Content Source: skype/skype-ps/skype/Set-CsAutodiscoverConfiguration.md
Service: skypeforbusiness-powershell
GitHub Login: @hirenshah1
Microsoft Alias: hirshah

Thanks for your feedback @Petri-X


Paste as bicep sometimes throws with "The specified line number is not valid."

[Error - 11:46:01 AM] Request textDocument/codeAction failed.
Message: Internal Error - System.ArgumentException: The specified line number is not valid.
Code: -32603
This might be easiest to repro when doing repeated undo/redos.
[Error - 12:23:51 PM] Request textDocument/codeAction failed.
Message: Internal Error - System.ArgumentException: The specified line number is not valid.
at Bicep.Core.Text.TextCoordinateConverter.GetOffset(IReadOnlyList1 lineStarts, Int32 line, Int32 character) in C:\Users\stephwe\Repos\bicep\src\Bicep.Core\Text\TextCoordinateConverter.cs:line 71    at Bicep.LanguageServer.Utils.PositionHelper.GetOffset(ImmutableArray1 lineStarts, Position position) in C:\Users\stephwe\Repos\bicep\src\Bicep.LangServer\Utils\PositionHelper.cs:line 20
at Bicep.LanguageServer.Handlers.BicepCodeActionHandler.Handle(CodeActionParams request, CancellationToken cancellationToken) in C:\Users\stephwe\Repos\bicep\src\Bicep.LangServer\Handlers\BicepCodeActionHandler.cs:line 64
at OmniSharp.Extensions.JsonRpc.JsonRpcServerServiceCollectionExtensions.RequestHandlerDecorator2.Handle(T request, CancellationToken cancellationToken)    at OmniSharp.Extensions.LanguageServer.Server.Pipelines.SemanticTokensDeltaPipeline2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)    at OmniSharp.Extensions.LanguageServer.Server.Pipelines.ResolveCommandPipeline2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)    at MediatR.Pipeline.RequestPreProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)    at MediatR.Pipeline.RequestPostProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)    at MediatR.Pipeline.RequestExceptionProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)    at MediatR.Pipeline.RequestExceptionProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)    at MediatR.Pipeline.RequestExceptionActionProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)    at MediatR.Pipeline.RequestExceptionActionProcessorBehavior2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate1 next)    at OmniSharp.Extensions.JsonRpc.RequestRouterBase1.g__InnerRoute|7_0(IServiceScopeFactory serviceScopeFactory, Request request, TDescriptor descriptor, Object params, CancellationToken token, ILogger logger)
at OmniSharp.Extensions.JsonRpc.RequestRouterBase1.RouteRequest(IRequestDescriptor1 descriptors, Request request, CancellationToken token)
at OmniSharp.Extensions.JsonRpc.DefaultRequestInvoker.<>c__DisplayClass10_0.<b__5>d.MoveNext()
Code: -32603

ChatGPT:
A bug, in code, a glitch in the system
A error message, a cause for dismissal
The request failed, with a message so dire
Internal Error, a cause for the fire
ArgumentException, the line not right
A problem in the code, a source of blight
Undo and redo, a cycle of woes
A reproducible bug, that nobody knows
A team of developers, to fix and to mend
To debug and to solve, until the very end
A bug in the system, a glitch in the code
A challenge to overcome, before the next load.

Ugh, now I can't repro again!

I think a dup of #1931


Bump crossplane runtime version to v0.13.0

use common extracting credentials function CommonCredentialExtractor
use base64 string as the secret value for Alibaba provider config
bump version of providerconfi from v1alpha1 to v1alpha2
update make demo

Signed-off-by: Zheng Xi Zhou<EMAIL_ADDRESS>
Description of your changes

Fixes https://github.com/crossplane/provider-alibaba/pull/58/files#r595574127
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Yes.

Hi @negz @hasheddan, please help review this PR again.
@xiqiu618 and I are hoping to power these two managed resource Redis (#68) and OSS bucket (#59) by Crossplane new runtime:)

@negz  Hi Nic, can you help approve this PR. Let's merge it.

Hey folks! I'm happy to merge this, but I'd love to see the "How has this been tested" section filled out with some more detail. I think it was misinterpreted as "Was this tested" because it currently just says "Yes". :)

@zzxwill Thank you for the very thorough testing info!

Hrm I think merging this PR broke the main branch - see https://github.com/crossplane/provider-alibaba/actions/runs/1054471865. Did you rebase before running your tests?
https://github.com/crossplane/provider-alibaba/blob/8131deba22c8dd853a2c0311c0803de95de9ae0b/pkg/controller/sls/machineGroup_controller.go#L35
It looks like the problem is that the SLS controller/sls package is trying to import the v1alpha1 ProviderConfig type, that no longer exists.

@negz SLS MachineGroup and MachineGroupBinding are the last two managed resources I supported. In the PR, there should be conflicts. And, indeed, these two are missed out. I have fixed it in #95


add scram integration

allow connection to kafka with scram 256 or 512

Hey @jchomat ,
thank you for your pull request. I'll try to review it during the holidays somewhere between christmas eve and new years eve.

Hey @weeco,
Thank you, i 'm using a local binary for now but it will be easier to use for the community;)
I use it on 2-3 kafka cluster with scram 256 since few days. tls must be enabled to use it ;)

@jchomat FYI: https://github.com/cloudworkz/kafka-minion/commit/a1642e37455d3075e75831e978ed0edcf29b04cf

Hey @weeco,
Thanks a lot, i'm just back from holidays. i will move on the last version ;)
I've seen that the label host is missing for prometheus filtering when i have multiple cluster.
i've used the prefix_metrics to avoid that but it's not the easiest way for maintain dashboard
does anyone work on this subject?
BR,
Jérémy

Take note that I haven't released a new version with the SCRAM support yet. I'd like to fix some other things before releasing a new version. However you are obviously free to use the master build which is rebuilt regularly.
I'd recommend you to add annotations/additional labels for your prometheus job instead. I want to avoid adding multi tenant support in Kafka Minion because that adds a lot complexity (code and configuration) which in my opinion can be avoided by just deploying separate instances for each Kafka cluster with unique prometheus labels attached to these scrapes.

Ok thank for your answer, i will wait for the release and take a look on additionnals label ;)
Deploying multiple exporter is not a problem but just using multiple prefix ;)


Use std::map in contacts (instead of std::unordered_map)

This PR changes the API contact as it helps to plot contact data (because it is organized the map).

Thank you - this makes a lot of sense for plotting and since we expect the number of contacts to be small it shouldn't be a noticeable performance penalty.


KAFKA-15743: KRaft support in ReplicationQuotasTest

Updated to support KRaft mode.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hello, @jolshan @mimaison
Please, take a look. Tests passed.
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15191/2/testReport/kafka.server/ReplicationQuotasTest/


Closing settings requires an additional click each time

Describe the bug
When opening the settings window, closing it requires an additional click each time.
So at first, it behaves like expected, closing when clicking the arrow in the top left corner.
Once you open the settings again, you need two clicks to close the window, next time three etc. Tested up to 11 clicks.
To Reproduce
Steps to reproduce the behavior:

Open Settings.
Click on arrow in top left corner.
Open settings again.
Click on arrow in top left corner => Settings don’t close.
Click on arrow again => Settings now close.
Repeat as you see fit, needs one more click each time.

Expected behavior
Settings should close on first click of back (arrow) butten.
Desktop

OS Version: Windows 10 Build 19042.685
App version: v.<IP_ADDRESS>

Log file
Nothing interesting here, just two lines about the app launch.

Fixed in #2867

Fixed in #2867


Markdown Files for Blog

Blog currently covers:
XML, XSD, Forge and Java overview and resources.
Build Battle Task creation guide.
Markdown files are in doc/MalmoBlog/docs/

Thanks for this! Changes needed:

Please remove the spaces from the filenames. It avoids problems.
Malmo has the dots on the 'o' not the 'a'/
Please add the .md filenamess to the INPUT tag in Doxyfile.in, line 760, and build Malmo to see how the documentation looks. If we're happy with it then we can remove the .yml file. If not then we need to rethink how this blog will get hosted.

Upon review it looks like the doxygen route isn't ideal, so please add directly to the gh-pages branch, so that the URL for this entry is something like http://microsoft.github.io/malmo/blog


Vault metrics

Type of change

Enhancement / new feature

Description
We want to start making it visible how many API calls are being made to Vault and how many operations are resulting in keys not being found or other exceptions.
Example of the new metrics obtained via the prometheus endpoint:
kroxylicious_kms_vault_request_attempt_total{operation="resolve_alias",} 1.0
kroxylicious_kms_vault_request_attempt_total{operation="decrypt_edek",} 1.0
kroxylicious_kms_vault_request_attempt_total{operation="create_datakey",} 1.0
kroxylicious_kms_vault_request_outcome_total{failure="",operation="create_datakey",outcome="success",} 1.0
kroxylicious_kms_vault_request_outcome_total{failure="not_found",operation="decrypt_edek",outcome="failure",} 0.0
kroxylicious_kms_vault_request_outcome_total{failure="",operation="decrypt_edek",outcome="success",} 1.0
kroxylicious_kms_vault_request_outcome_total{failure="exception",operation="create_datakey",outcome="failure",} 0.0
kroxylicious_kms_vault_request_outcome_total{failure="exception",operation="resolve_alias",outcome="failure",} 0.0
kroxylicious_kms_vault_request_outcome_total{failure="not_found",operation="resolve_alias",outcome="failure",} 0.0
kroxylicious_kms_vault_request_outcome_total{failure="not_found",operation="create_datakey",outcome="failure",} 0.0
kroxylicious_kms_vault_request_outcome_total{failure="exception",operation="decrypt_edek",outcome="failure",} 0.0
kroxylicious_kms_vault_request_outcome_total{failure="",operation="resolve_alias",outcome="success",} 1.0

The idea is that the sum of the outcomes series for an operation should equal the attempt count for that operation.
Note that this is a limited set of metrics that are registered on startup so that we can start emitting 0.0 values, we do not tag by HTTP status code etc. This helps systems like prometheus alert on changes in each series, there can be issues if you emit no data until the very first occurrence of your error.
We could add HTTP status breakdown in a subsequent PR, or rely on logging to debug failures.
Checklist

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonar-Lint warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

I ended up making these first metrics at a logical level above the level of HTTP request and response counts so that there were fewer counters that could be emitted immediately on startup.
Maybe it would be better to implement this in the Filter? We could wrap these measurements around the KMS regardless of implementation.

Feels like we would want metrics at the filter level for counting requests/found/missing etc thats the "business" metrics we care about, HTTP codes etc are implementation details. They should in theory only be interesting in diagnosing issues with how we translate errors or the actual KMS systems.

Feels like we would want metrics at the filter level for counting requests/found/missing etc thats the "business" metrics we care about, HTTP codes etc are implementation details. They should in theory only be interesting in diagnosing issues with how we translate errors or the actual KMS systems.

I think I'll rework this to be at the filter level as this is going to be more interesting than the KMS implementation details at first.

Superceded by #861


Hi, please launch a simple web app for json-formatter

A simple web app to paste JSON and format. The existing apps are too buggy, slow, and unresponsive.
Thank you.

I'm not sure if I'm allowed to post links here, but, I typically use https://jsonformatter.org/ and haven't had any issues.

Just use this JSON formatter and validator by Curious Concept


Added TimeSpan comparison support

Added TimeSpan comparison support

@ExLuzZziVo Thank you so much for your contribution. Your commit has been merged.


Process exclusion addition

I think we should add more processes to the process list on this page:
cmd.exe
cscript.exe
wscript.exe

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 864c454f-e0d9-fb1d-6090-5982eb733eb0
Version Independent ID: ca1abacc-22e4-688d-370b-e34d827fde76
Content: Common mistakes to avoid when defining exclusions
Content Source: microsoft-365/security/defender-endpoint/common-exclusion-mistakes-microsoft-defender-antivirus.md
Service: microsoft-365-security
Sub-service: mde
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

@BlakeMsft Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/11241
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @BlakeMsft Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also

My suggestions have not been added, so how is this closed?
Common mistakes to avoid when defining exclusions | Microsoft Learnhttps://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/common-exclusion-mistakes-microsoft-defender-antivirus?view=o365-worldwide
Thank you,
Blake
From: Yogesh Kumar @.>
Sent: Tuesday, March 7, 2023 8:09 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Blake Morrison @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Process exclusion addition (Issue #11221)
Closed #11221https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F11221&data=05|01|blakemo%40microsoft.com|15f64b325aa349df623e08db1f159027|72f988bf86f141af91ab2d7cd011db47|1|0|638137949700581275|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=E%2FtkW1DgvvMIGQTrxP%2F9LexiuEvpQR4vDqD1VjCZs30%3D&reserved=0 as completed.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F11221%23event-8686283589&data=05|01|blakemo%40microsoft.com|15f64b325aa349df623e08db1f159027|72f988bf86f141af91ab2d7cd011db47|1|0|638137949700581275|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=N0bmn3A%2FYXYwUi3R9V4Wxgr3t4aWS0ONVNbb7RTnBrc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWKFIQP7LVJEE24PI43IWR3W246RPANCNFSM6AAAAAAVO2FESI&data=05|01|blakemo%40microsoft.com|15f64b325aa349df623e08db1f159027|72f988bf86f141af91ab2d7cd011db47|1|0|638137949700581275|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=St%2FeLvI2L1Y4SeFl%2BtMUBhY6cc9xLve%2BLT4PZgX0knA%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@BlakeMsft The Pr has been merged. The document will be updated in the next 24 hours.
Thanks
Sri

Thank you!
From: Sriraman M S @.>
Sent: Tuesday, March 7, 2023 8:57 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Blake Morrison @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Process exclusion addition (Issue #11221)
@BlakeMsfthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBlakeMsft&data=05|01|blakemo%40microsoft.com|51e8db43d5284041c29708db1f1c39f5|72f988bf86f141af91ab2d7cd011db47|1|0|638137978314789626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=OMNJt7dL%2FU9toCZbKZOWW2ZrS2SfSg3obljI9mGwlPY%3D&reserved=0 The Pr has been merged. The document will be updated in the next 24 hours.
Thanks
Sri

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F11221%23issuecomment-1458316816&data=05|01|blakemo%40microsoft.com|51e8db43d5284041c29708db1f1c39f5|72f988bf86f141af91ab2d7cd011db47|1|0|638137978314789626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Wu8LcvN0IiCH0vEIGpMq%2FDCatb882ww2FCklEvDVCh8%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWKFIQI4JFEXXPKA23A7JXDW25EEJANCNFSM6AAAAAAVO2FESI&data=05|01|blakemo%40microsoft.com|51e8db43d5284041c29708db1f1c39f5|72f988bf86f141af91ab2d7cd011db47|1|0|638137978314789626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=VUUYx75NjEHIy2fI3DmAsktZnF7EcjGV6BHc0weNaz8%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


[CMake] Support LLVM-16 static linking

LLVM static linking in TVM relies on default flags provided by llvm-config, which however does not depend on modern CMake features, namely, imported targets, leading to a series of issues on builds particularly on macOS and Windows. This PR strengthens CMake configuration process to avoid such behavior.

thanks


forge create does not work

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.0.2 (13497a5 2024-05-22T00:24:24.116664000Z)
What command(s) is the bug in?
forge create
Operating System
macOS (Intel)
Describe the bug
Forge create does not deploy contracts.

Create a new repo

forge init

Try to deploy

forge create Counter --rpc-url ${ZKSYNC_SEPOLIA_RPC_URL} --private-key $PRIVATE_KEY

You'll get:
Error:
(code: -32600, message: Unsupported method: eth_feeHistory on zksync, data: None)

So if you add the --legacy flag, you'll get:
Error:
(code: 3, message: Failed to serialize transaction: toAddressIsNull, data: None)

So if you add --zksync flag, meaning the whole command is:
forge create Counter --rpc-url ${ZKSYNC_SEPOLIA_RPC_URL} --private-key $PRIVATE_KEY --legacy --zksync

You'll get
Error:
(code: 3, message: ErrorObject { code: ServerError(3), message: "not enough gas to publish compressed bytecodes", data: Some(RawValue("0x")) }, data: Some(String("0x")))

However, doing this on zksync mainnet passes. It only fails on zksync sepolia.

If I run the following command:
forge create Counter --rpc-url $ZKSYNC_SEPOLIA_RPC_URL --private-key $PRIVATE_KEY --legacy --zksync

The deployment succeeds (For Counter.sol)
Were you using Counter here or one of the Updraft challenges?

Ok, after a second try it worked.


approach quality as a progress rather than fixed levels

Like this we can suggest users where to improve and reward the completeness of metadata.

duplicated https://github.com/earthpulse/eotdl/issues/198


RunDistributedTests cannot access collection

I am trying to run a data driven Coded UI Test where my data source is VSTS.
 [DataSource("Microsoft.VisualStudio.TestTools.DataSource.TestCase", "https://testcollection.visualstudio.com/defaultcollection;Foo", "78785", DataAccessMethod.Sequential)]

The problem is that because the task does not support overriding the user of the test run, the agent tries to connect to VSTS as the windows service account which is not valid.
Is it possible to set a run context with a VSTS user?

@cwoolumtechnossus so you want to run a particular test under a different user context? We do not have that functionality today.
@atinb to track the feature request

I am fine running the entire run as a single user. It just needs to be a VSTS user so that it has access to data in VSTS
Sent from Ninehttp://www.9folders.com/

From: Allen Mathias<EMAIL_ADDRESS>Sent: Aug 3, 2016 4:10 AM
To: Microsoft/vsts-tasks
Cc: Christopher Woolum; Mention
Subject: Re: [Microsoft/vsts-tasks] RunDistributedTests cannot access collection (#2178)
@cwoolumtechnossushttps://github.com/cwoolumtechnossus so you want to run a particular test under a different user context? We do not have that functionality today. This is also true for the entire run when using the vstest task that runs on the build machine.
If you use the "run functional tests" task you can execute your tests under a different user by configuring the agent as that user.
@atinbhttps://github.com/atinb to track the feature request for vstest task

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vsts-tasks/issues/2178#issuecomment-237201254, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AP80_NO_TrqmimbD3r3VyO3aC5oexhK9ks5qcHEfgaJpZM4JaDWx.

Unfortunately, Data driven tests are currently only supported if the data is coming from xml, csv or sql end points. Run Functional Tests task cannot be used for data coming from VSTS. Adding this support is on our backlog. Thanks!

Hi @atinb ,
Can you share with us the roadmap for this feature ? It is very important for non-technical tester.


AbsoluteLayout doesn't work.

Hi
I am trying to use AbsoluteLayout but it doesn't work.
My code:

BlazorBindings.Maui.Templates version 1.0.1

What is the actual behavior though?

What is the actual behavior though?

What do you mean by actual behavior?

I mean - how it doesn't work? What behavior do you expect, and what do you actually see?
I don't think your LayoutBounds are correct. Currently you have a Box with a Size=1x1. With a CornerRadius=10 it's probably not visible at all.

I mean - how it doesn't work? What behavior do you expect, and what do you actually see?
I don't think your LayoutBounds are correct. Currently you have a Box with a Size=1x1. With a CornerRadius=10 it's probably not visible at all.

I am sorry it's my mistake. I found the issue in the LayoutBounds as you said. Thank you.


Add prefix support to KV

Currently we can't run multiple tests concurrently because of isolation. We need an isolation  mechanism.
So TiDB make use it like:
Open(DSN + prefix)
And we can reuse lots of tests.
TiDB may also use environment variable to define DSN.

Call for discuss.

I think first we should change tidb unit test to support a persistent engine with prefix to distinguish different tests, then we can use all tidb unit test for tikv.

Yes

FoundationDB had a very nice system for generating keys. They had the notion of directories and subspaces which gave you a couple nice primitives for building up key spaces:
https://web.archive.org/web/20150325003904/https://foundationdb.com/key-value-store/documentation/javadoc/com/foundationdb/directory/DirectoryLayer.html
It was pretty useful and made it possible for lots of applications to use the KV store as long as they didn't write arbitrarily to the keyspace. Their Tuple class also made it easy to generate lexagraphically sorted compound keys. Might be useful to emulate it for people that use your KV store directly.

@spullara Thanks for providing the links. It's helpful.  We will try to support namespace or directory api after we release beta.


Issue #1525 - Enhancements to ActionContext

Adding a new constructor that takes ModelState.
Removing an extra constructor that's not needed
docs
test cleanup

:shipit:

:shipit:


[css] /deep/ selector is still broken (scss)

VSCode Version: 1.12.1
OS Version: Win 10

Steps to Reproduce:
Interestingly the issue at https://github.com/Microsoft/vscode/issues/7002 is considered fixed since 1.12, but apparently it has not been fixed, as I just updated to latest version 1.12.1, and /deep/ selector in scss is still not recognized by the IDE.
This screenshot shows it all:

Those are ordinary SCSS files. Angular-CLI generated project (latest version). Please fix this.
#7002

Please paste your code sample, thanks!

The problem is the lack of spec here. Can someone confirm that >>> or /deep/ followed by > is a valid syntax?

@aeschli It seems that direct child selector (>) is causing the problem indeed. Without it, there is no error as far as I can test. As for whether the /deep/ followed by > syntax is valid, I'd say that it's totally valid because valid css is generated by scss parser, and not only it is semantically correct, it is quite commonly used and pretty hard to emulate otherwise.

From a logical standpoint, parentelement > childelement makes sense,
while parentelement /deep/ > childelement does not.
What should the direct child selector of the second example refer to? Direct child of what?
Compared to CSS without shadow DOM, this makes sense: > element { } is not valid CSS (again - direct child of what?), * > element { } is valid CSS.
Consider using either

parentelement /deep/ * > childelement, which carries the semantics "somewhere within parent, find a childelement which is a direct ancestor of any element" or
parentelement::shadow > childelement which means "inside the shadow dom of the parent element, find a direct ancestor which is a childelement.
parentelement /deep/ childelement which means "a childelement anywhere underneath parentelement"

@leonadler I don't want to sound rude, but... please don't talk and give advice on the subject that you don't understand. The particular use case I'm facing in my project for example, is an Angular application, that emulates the shadow DOM for its components and :host /deep/ > child is used to apply styling to the direct child component that is transcluded inside parent dynamically. Shortly, there is a valid, frequent, and hard-to-workaround use case, at least for Angular applications. I'm sure there are other uses, but I think the single example is enough. When the platform uses the particular functionality, compiles it perfectly, and at the same time IDE has a syntax highlighting problem - that is clearly an IDE issue, period.

The particular use case I'm facing in my project for example, is an Angular application, that emulates the shadow DOM for its components and :host /deep/ > child is used to apply styling to the direct child component that is transcluded inside parent dynamically.

according to all i know about css selectors, :host /deep/ > child is invalid in the same way as :host > > child is
are you sure the style is actually being applied? what does the selector look like in your browser's style inspector?

Angular application, that emulates the shadow DOM for its components

if it's only emulating the shadow dom and not actually using it (for older browsers i assume), then it probably has to convert :host and /deep/ into something that works without actual shadow dom, so maybe a transformation like that is erroneously turning the selector into a valid one?
disclaimer: i have not used angular or scss

Thanks a lot for the information, @leonadler!
Closing the issue until we get a prove that /deep/ > is valid syntax.

The particular use case I'm facing in my project for example, is an Angular application, that emulates the shadow DOM for its components and :host /deep/ > child is used to apply styling to the direct child component that is transcluded inside parent dynamically.

Yeah, I know, I am working with Angular2&4 for almost two years. If you would have bothered to read or try my answer instead of trying to belittle me, you would see that :host::shadow-root > element does exactly what you are trying to do. /deep/ > element just makes no sense.

I don't want to sound rude, but...

Then don't be rude?

Answer for future readers
Assuming this HTML with shadow DOM (native or emulated, does not matter):
<my-component>
    ::shadow-root

a

b

</my-component>

To select the paragraph containing "a", not the one containing "b":
my-component::shadow-root > p {
    // style declarations
}

A scenario where parent /deep/ child (or parent >>> child) makes sense:
<parent-component>
    ::shadow-root

a

        <child-component>
            ::shadow-root

b

        </child-component>
        <child-component>
            ::shadow-root

c

        </child-component>
        <nested-component>
            ::shadow-root

d

                <child-component>
                    ::shadow-root

e

                </child-component>
        </nested-component>
</parent-component>

With this HTML structure, parent-component /deep/ div (or parent-component >>> div) will select all divs in the example.

Agreed. /deep/ > doesn't make sense, even for transcluded content. I'm actually surprised that it works. I wonder if it's, more than anything, a side effect of how Angular parses the css for emulated view encapsulation.


tests folder showing empty

runned tests folder all pages but showing webpage null.no information.what is the use of tests folder

Test are performed with the phpunit command. Please read:
https://github.com/akalongman/php-telegram-bot/blob/master/CONTRIBUTING.md


fix: move client msgs to common

Description:
We have decided that it would be helpful to have client messages in common so that both host and light client contract refer to same data structure . This will make sure that we are on same page and prevent accidental changes.

Changelog Entry
version: <log entry>

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have documented my code in accordance with the documentation guidelines
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have run the unit tests
[ ] I only have one commit (if not, squash them into one commit).
[ ] I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Codecov Report

Merging #272 (c8a1437) into main (9660970) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   44.85%   44.84%   -0.02%
==========================================
  Files          90       90
  Lines       14595    14592       -3
==========================================
- Hits         6547     6544       -3
  Misses       8048     8048

Impacted Files
Coverage Δ

contracts/cosmwasm-vm/cw-ibc-core/src/msg.rs
20.00% <ø> (ø)

...cosmwasm-vm/cw-icon-light-client/src/bin/schema.rs
12.50% <ø> (ø)

...s/cosmwasm-vm/cw-icon-light-client/src/contract.rs
58.11% <ø> (ø)

...ts/cosmwasm-vm/cw-icon-light-client/src/helpers.rs
0.00% <ø> (ø)

...tracts/cosmwasm-vm/cw-icon-light-client/src/lib.rs
100.00% <ø> (ø)

libraries/rust/common/src/btp_header.rs
100.00% <ø> (ø)

libraries/rust/common/src/client_msg.rs
66.66% <0.00%> (ø)

...ibc-core/src/ics04_channel/handler/open_confirm.rs
71.02% <100.00%> (-0.80%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Additional control of "Operational Status" when incident is created

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
Apologies if this already is somewhere, I couldn't find it.
I have deployed this monitor in the infrastructure of a large company. We love it! However, as a "public uptime tracker status" page, it isn't always that the pings and HTTPS codes accurately can reflect our system status. This seems to be handled nicely by the ability to create "incidents" that can be nicely flaired with a color.
What isn't so great, is when you have a large red bubble saying you have an outage or issue, and then the "operational status" is all green and happy.
✔ Solution
Proposing the ability that when incidents are pinned/open on the status page, that the "operational status" bar enters a mode where the operator has 4 choices: Operational, Degraded, Failed (sorry, can't recall of the top of my head the last status), and then also Auto if the operator doesn't want to set this manually.
But is just is confusing to see "operational issue is known" and a green or yellow status field when the bubble on top is red.
❓ Alternatives
Or, if it is not wanted to give operators such control, at least make the "operational" status match the color of the bubble if it is one of the three (green, yellow or red).
📝 Additional Context
No response

This would be a nice feature +1

where the operator has 4 choices: Operational, Degraded, Failed (sorry, can't recall of the top of my head the last status)

That last one is typically "Partial outage" and/or "Full outage"


Design: template parameter usage should allow named parameters to be specified (to skip default values)

When providing values for templated elements with multiple template parameters, it's much clearer to authors and reviewers to be able to specify only the template parameter values that diverge from the defaults.  This is a resuscitation of #379, but Graph has found the same requirement.  Azure and Graph will both be able to add cleanliness and enhanced reviewability with this feature.
Example from Graph library:
interface GraphOps {
 @get op GetPagedCollection<
    TResource = Automatic.CalculatedResourceType,
    TParams =  {... Automatic.GraphRouteParams},
    TResponse = PagedCollectionResponse<TResource>,
    TErrorResponse = CollectionErrorResponse>(
       ...TParams): TResponse | TErrorResponse;
}

When this templated operation is consumed the defaults are often fine, like so:
@graphRoute("/users/{id}")
interface usersById extends EntitySet<user> {
  get is GraphOps.GetPagedCollection;
}

However, when the author wants to vary ONE of the template parameters, and it's not the first, they have to provide values for more/all, as only positional specification is supported.
This means the author must refer to the Graph library deeply to build the parameters.
It also means reviewers cannot see immediately what the author is varying from the standard.
Let's examine the worst case example where the author wants to return a customized error response:
Today's code
@graphRoute("/users/{id}")
interface usersById extends EntitySet<user> {
  get is GraphOps.GetPagedCollection<
            user,
            {... Automatic.GraphRouteParams},  // or worse, { "id" : string }
            PagedCollectionResponse<user>,
            CollectionErrorReponse<409>>;
}

Desired code
@graphRoute("/users/{id}")
interface usersById extends EntitySet<user> {
  get is GraphOps.GetPagedCollection<TErrorResponse = CollectionErrorReponse<409>>;
}

Proposal
New syntactic sugar is added to support the syntax in the desired code above.

Allow referencing template args with their name Foo<T = [value]>
Allowed for all parameters optional(with default) and required
(P2) Allow mix of positional and named args
(P2) Positional MUST be located before the 1st named parameter
(P2) CANNOT specify again the value for one of the positional argument already provided earlier
Order of evaluation should be unchanged, i.e. in the positional order from the templated element definition, unchanged by the arbitrary order provided in the template usage via named params.

Previously, we had hoped that options bags would be a palatable alternative, but this turned out to not be the case. The primary issue is that, without conditional types, it's impossible to apply defaults to options in the bag that are not provided. So you end up having to provide all the options in the options bag anyway. And arguably, even with conditionals, the result is more verbose than desired.

We discussed and accepted a design that meets this proposal, and its implementation is tracked by the following issue: https://github.com/microsoft/typespec/issues/2340


I need ESP32 explorer feature for my web application

Hi,
I need to return in JSON reply via HTTP rest api list of folders and sub folders  with files names to be shown on UI. User can select files or folders and I can download it on PC. Is JSON module which generate files explorer is moduler, so I can use it as module integrate into my codebase.
Otherwise I can write myself JSON generated from file system. any JSON format recommendation for folders and sub folders.
Thanks,
Naeem

https://github.com/espressif/esp-idf/tree/master/components/json

Sure, I am using this json. I wonder Is there JSON format you are using to return list folders and sub folders files with nested levels.

Like you can see in this code, all nested values are build from iterations and JSONObject.
https://github.com/nkolban/ESP32_Explorer/blob/master/main/BLEExplorer.cpp

I am using mongoose web server on ESP32 with card mount.
I enable direct list.  When I point my web server to folder. Web browser does not browser folders and shows folders and files as folder explorer
enable_directory_listing = "yes"

Like you can see in this code, all nested values are build from iterations and JSONObject.
https://github.com/nkolban/ESP32_Explorer/blob/master/main/BLEExplorer.cpp

For Get JSON file system folders and files. This is more relevant.


feat(server-routes): cache responses

note: in next PR, we will add Global Inputs and user will be able to manage cache settings
https://github.com/nuxt/devtools/assets/38922203/af649898-f5e8-437d-abfb-12467caf3d1a

What would be the benefit of caching the request for devtools? I feel that it would be more intuitive that you always get the latest data in the playground. In addition, persist them in the options, which will sending back and forth from fs and server, which to me feels inefficient and redundant.

What would be the benefit of caching the request for devtools? I feel that it would be more intuitive that you always get the latest data in the playground. In addition, persist them in the options, which will sending back and forth from fs and server, which to me feels inefficient and redundant.

Aw yes. that's right, sorry😁
what about saving the selectedRoute(to always have the last route when server restarts)? Is it okay to save it in fs options, or should it be in localStorage?

Saving the selected routes makes sense to me. We could save in fs options to make it per-project based


Software Requirements

What is the line "Visual Studio 2015 Add 2017" supposed to mean? Shouldn't it just say "Visual Studio 2015"?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e79448e9-680f-5c35-fd60-1ae7222d4abd
Version Independent ID: 8fdc1f71-7ac3-11e2-cab9-b20f2ec6bafc
Content: Dynamics 365 for Customer Engagement (on-premises) reporting requirements
Content Source: ce/on-premises/microsoft-dynamics-365-reporting-requirements.md
Product: crm-2016
GitHub Login: @Mattp123
Microsoft Alias: matp

@ovinophile Thank you for your feedback. This issue has been fixed.


Certbot on host machine

I have certbot on my host machine, and wanted it to work with docker-mailserver. Is there any way to do that?

This shouldn't be a problem.  Did you have a specific issue with it?
I got this working by mounting /etc/letsencrypt in the container (or you could probably manage with just a specific subfolder, but I haven't tried that yet).  So add the following line under volumes: in your docker-compose.yml:
    - /etc/letsencrypt:/etc/letsencrypt

Then you can run certbot on your host, and next time you start your docker-mailserver it will see the certs.
I don't think I did anything else other than set SSL_TYPE to letsencrypt in my .env, but let me know if that doesn't work and I'll go through my configs again.


Add generic selector group to kube deployment

Is your feature request related to a problem? Please describe.
Implement a selector group on the template for the manifests that allows the selection of all of the agent instances.
Describe the solution you'd like
https://github.com/valory-xyz/open-autonomy/pull/1584
This pr proposes a small change to the template which enables this
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Addressed https://github.com/valory-xyz/open-autonomy/pull/1584


High DPI Icon

The current icon doesn't look great on high dpi screens.

You are right.  These types of fit and finish issues aren't the priority for PerfView development at this time.  If you are interested, please contribute a PR.

Leaving open for community contributions


Experiment a more streamlined way for 6th step of prod install.

context: https://chat.zulip.org/#narrow/stream/feedback/topic/step.206.20of.20prod.20install

I'd like to pursue other approaches to streamlining the process here.

Checking whether the email system works should be decoupled into its own step. Realm creation shouldn't require this extra "does my email system work?" check.


Remove usages of deprecated github.com/pkg/errors, use native golang errors

What this PR does
Since Go 1.13 one can use native error wrapping and unwrapping
(fmt.Errorf with %w, errors.Is and errors.As).
This (at least) lowers our container score.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Not sure what to do about the remaining "github.com/evanphx/json-patch",
will these be removed following https://github.com/kubevirt/kubevirt/pull/11599?

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

cc @alicefr @nunnatsa
not sure what to do about the jsonpatch package

/approve


Fix hook error when removing Ceph relation

It seems that there is a possible case where the ceph-storage.available flag is still set and the key is available, but the fsid comes back as None, leading to the following (from CI):
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed Traceback (most recent call last):
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed   File "/var/lib/juju/agents/unit-kubernetes-master-1/charm/hooks/ceph-client-relation-departed", line 22, in
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed     main()
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed   File "/var/lib/juju/agents/unit-kubernetes-master-1/.venv/lib/python3.6/site-packages/charms/reactive/__init__.py", line 74, in main
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed bus.dispatch(restricted=restricted_mode)
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed   File "/var/lib/juju/agents/unit-kubernetes-master-1/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 390, in dispatch
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed _invoke(other_handlers)
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed   File "/var/lib/juju/agents/unit-kubernetes-master-1/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 359, in _invoke
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed handler.invoke()
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed   File "/var/lib/juju/agents/unit-kubernetes-master-1/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 181, in invoke
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed self._action(*args)
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed   File "/var/lib/juju/agents/unit-kubernetes-master-1/charm/reactive/kubernetes_master.py", line 1364, in configure_cdk_addons
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed 'ceph-fsname=' + (ceph.get('fsname', '')),
2020-07-31 02:42:28 DEBUG ceph-client-relation-departed TypeError: must be str, not NoneType
2020-07-31 02:42:29 ERROR juju.worker.uniter.operation runhook.go:132 hook "ceph-client-relation-departed" failed: exit status 1

This checks that all of the fields that we use are available.

This also applies to lp:1887000

Cherry-picked to stable: b076bfd


rank alleles by their t scores instead of their pvalues

since we might have precision issues with p-values

closing for now b/c it doesn't seem the issues we were having are due to precision in the p-values
and besides, it's actually not easy to acquire t-statistics from some of the stats libraries we are using


Import Error: No module named gmpy2

On running the following command python robot-detect it is giving the following error.

Please provide the solution

You have to install gmpy2. An installation guide is published on https://gmpy2.readthedocs.io/en/latest/

not a bug, gmpy2 is a dependency


record.data is not public but used in examples

in https://github.com/sencha/extjs-reactor/blob/master/packages/reactor-classic-boilerplate/src/App.js
the example used : record.data
not too big issue, but not a best practice to use not documented props from framework, at least for beginers could be confusing when they will search new stuff from docs and will not find Ext.data.Model.data as public/protected property.
Thanks.

Thanks for reporting. I'll see what we can do to add it.


Clean up usage of lucene deprecated search method

The IndexSearcher.search(Query, Collector) method has been deprecated in favour of IndexSearcher.search(Query, CollectorManager)

Switch to this new method in ReservoirSampler, also refactoring the ReservoirCollector and introducing an UnscoredLeafCollector interface to make implementation neater.
Switch to using IndexSearcher.count(Query) in InternalEngineTests
Remove an inadvertently committed Seed annotation on InternalEngineTests, and fix a test bug in a randomized branch that was never exercised due to the fixed seed.

@mergifyio requeue


Update Docker to cudnn6 and fix src mapping

I had to make a few tweaks to the Keras Docker image to get it up and running.

Upgraded cuDNN5 to cuDNN6 following Tensorflow's example.
Changed the workspace directory to be able to import keras. This fixes #6750.
Added SRC as a configurable parameter in the Makefile to be able to use something like make notebook GPU=0 BACKEND=tensorflow DATA=~/project/foo/data SRC=~/project/foo

Before these tweaks I got libcudnn.so.6: cannot open shared object file: No such file or directory
After the edits, I was able to run make test with the following results:
E ValueError: Unexpectedly found an instance of type `<class 'theano.gpuarray.type.GpuArraySharedVariable'>`. Expected a symbolic tensor instance.

keras/backend/theano_backend.py:211: ValueError

1 failed, 505 passed, 1 skipped, 212 warnings

I believe Theano works with cuDNN6 and that it is officially supported: https://github.com/Theano/Theano/blob/master/theano/gpuarray/cudnn_defs.py#L13
In other words: I don't know whether the test failure is caused by cuDNN version change or not, but I think not.

Please update following https://github.com/fchollet/keras/pull/7884/files

Good catch. Updated.


EN_background edge case

An edge case appears in the interaction between EN_background and EN_std_lev_bkg_buddy when considering profile uid 580707 (reproduced below for convenience). It appears that in EN_background, every value in the array returned by
clim = parameters['enbackground']['clim'][:, ilat, ilon, imonth]

for this profile, which in turn comes from the EN_bgcheck_info.nc parameter file, is masked, causing EN_background to exit gracefully a couple lines later at:
    iOK = (clim.mask == False) & (bgev.mask == False)
    if np.count_nonzero(iOK) == 0: return qc

But then, EN_std_lev_bkg_buddy fails when it doesn't find anything for the profile in the enbackground table, which is normally written by EN_background but is not in this case as it exited before updating this table.
EN_std_lev_bkg_buddy exits with no flags if it doesn't find any proper levels from the EN_background lookups; therefore, it seems appropriate for it to exit with no flags if there is simply no entry for the profile in the corresponding table. But, this is bordering on a domain-knowledge decision. @s-good, your opinion?
580707:
C3272658070799101995<PHONE_NUMBER>22111664948000180<PHONE_NUMBER>191111001811022212202
82225536415222911022331101254110027111012997702016127022200003312550044267180033
12450044277520033123500552103360033121600552129200033119500552155040022018005521
80880033117100552206720033116800

Upon further inspection, it's clear that when we were still using globals (pre #195), these parameters were getting handed off to the buddy check even if some of them were empty; therefore I'm downgrading this from a domain question to a simple algorithm issue, with a fix in e282acc as part of #195.


DM-45807: Update USDF TAP authentication to qserv.

This is deployed on a branch on USDF and working, but I have one question for @pav511: I coped the secrets-usdf* files from the IDF versions, including the field for uws-db-password. I'm not sure if that secret is actually used at USDF, or if it matters to have it in here at all? It doesn't seem to be hurting anything, but I can clean it up if it's unnecessary.

I don't think these secrets are needed for usdf, the qserv password is already present in a different secret in usdf vault. Which env was this tested in?  It looks like all environments were synced to main. I moved usdf-int tap to point to this ticket branch though, It looks like changes are ok.

I got super confused by testing this with an invalid RA, Dec (turns out there's no data at 62, +37), so the only net change through these pushes was to remove the unused secret field.


Provide the monadic "join" function

I'm talking about something like the following:
func join<A>(future: Future<Future<A>>) -> Future<A> {
  return future.flatMap{$0}
}

Thanks for your input!
Three points for discussion:

This would be great to have if Swift would support extending generic classes that have a specific type signature (e.g. a Future where T is Future). Since this is not the case, join will have to be a public global/top-level function, which I'm not very comfortable with, but that might be my OOP background speaking.
Does it really add substantial convenience/clarity over future.flatMap{$0}
I understand that join is the terminology used in Haskell, but for me it would make more sense to name this function flatten. Does that make sense?

You're correct about the Haskell reference. However, "Future" forms a monad and "join" is the standard name of such an operation in the context of a monad. People with functional background will be looking for it and they will be looking for it under that exact name. I know that, because that's what I did myself.
So I vote for "join". If Scala's standard library didn't mess people's minds up with new definitions, I'd also ask for the proper "bind" instead of "flatMap" as well, but I sense you wouldn't be inclined to changing that.
BTW, instead of future.flatMap{$0} it should probably be implemented more efficiently by directly using the internal mechanisms of the library.

I appreciate the elegance of functional programming concepts and BrightFutures is definitely inspired by them in a significant way. The usability of the library for people coming from a functional background does matter to me. You'll find that BrightFutures is more functional than some other Future implementations in Swift out there.
That said, the primary goal for BrightFutures is to provide idiomatic futures & promises for Swift. It should work with, and act like, the Swift standard library as closely as possible. Swift 1.2 introduced flatMap, so that name is a given. The question now is given flatMap, what name makes the most sense in Swift for the join/flatten operation?

I agree, in the context of flatMap the name flatten does seem consecutive.

One option is to provide references to the standard names of those functions in the docs.

That's a great idea. If you want, feel free to start a PR on either of the two tasks. If not, I'll do it, but perhaps after 1.0.
Thanks for understanding.

Isn't BrightFuture's meant to be inspired by the Scala Future API, in which case, map and flatMap do what they are supposed to do?
PS. arguing about what the correct terminology is kind of redundant, The names map and flatMap have no real definition, the actual definition are mathematical statements. Haskell just happened to use words such as bind because thats what they thought was intuitive.
Honestly this is just an argument about whether we should be using Haskell terminology or Scala terminology

Haskell just happened to use words such as bind because thats what they thought was intuitive.

Haskell doesn't use bind. It uses >>=.
The name "bind" is part of the universal terminology used in the functional world, which is not limited to Haskell and Scala. Amongst prominent players there also exist F#, OCaml, Erlang, Clojure and even JavaScript.

Honestly this is just an argument about whether we should be using Haskell terminology or Scala terminology

Scala's standard library doesn't even mention monads. The "Scalaz" library is what brings the functional abstractions to the language, and FYI it uses "bind".

I think you are missing the point I was working, Scala is using different terminology (and it just that, different terminology), and the the BrightFuture's library was based off the scala API. Its even mentioned in the blurb
The goal of this project is to port Scala's Futures & Promises (guide, api) to Swift. Second to this readme, the Scala documentation should therefore also be of help.
Furthermore, in Swift 1.2 (just released yesterday), they also use flatMap the same way Scala does, i.e. http://airspeedvelocity.net/2015/03/13/changes-to-the-swift-standard-library-in-1-2-betas-2-and-3/
In other words, in terms of consistency with both the goal of the project, and with the Swift API, there isn't much of a reason to change flatMap.

and the the BrightFuture's library was based off the scala API. Its even mentioned in the blurb

I have to admit that I might want to revise that goal. BrightFutures started out as a port of Scala's Future, but its current goal can be better worded (as I did above) as "to be an idiomatic futures library for Swift". So far, these two goals have been aligned, including the naming of the flatMap operation.
I think we all agree that the naming of flatMap (and flatten) are probably best for Swift and thus for BrightFutures. Thanks for your input!

I think we all agree that the naming of flatMap (and flatten) are probably best for Swift and thus for BrightFutures.

Yeah. I'm not arguing that.

Even if it's not a goal anymore, coming from Scala (as I am), I feel right at home with BrightFutures :)


Audio Switcher Client Issue

Details:
Audio Switcher
Version: <IP_ADDRESS>
Operating System: Microsoft Windows NT 6.1.7601 Service Pack 1 64-bit
Administrator Privileges: False
User Comments:
Switching speakers.
Stacktrace:
System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at FortyOne.AudioSwitcher.AudioSwitcher.RefreshTrayIcon()
   at FortyOne.AudioSwitcher.AudioSwitcher.RefreshNotifyIconItems()
   at FortyOne.AudioSwitcher.AudioSwitcher.RefreshPlaybackDevices()

I think is related to an early deploy of <IP_ADDRESS>, create defaults was being called incorrectly.
Re-downloading <IP_ADDRESS> should resolve this


Discovery page: Don't use branding colors in lightbox

Done hardcoding color codes for now, maintaining the defaults from
vuex.  Because this will be migrated soon to Bootstrap theme anyways.
https://phabricator.endlessm.com/T32023

Makes sense to me. Ideally we'll want to swap this component with a bootstrap modal anyway :)


addBuildPhase keeps adding phases when they already exist

This is the build script line
xcodeProject.addBuildPhase(
              [], 'PBXShellScriptBuildPhase', 'Configure Crashlytics', undefined, options
            ).buildPhase;
            fs.writeFileSync(xcodeProjectPath, xcodeProject.writeSync());
            $logger.trace('Xcode project written');
          } else {
            $logger.error(xcodeProjectPath + ' is missing.');
            reject();
            return;
          }

So I guess everytime the CLI build runs it adds a NEW "Configure Crashlytics" to the build phase.  Eventually my machine just outright died because the script was running hundreds of times.
Is there maybe a way before this I can check to see if it exists first before just adding it again?

I did it with this js script, called from a Cordova "after_build" hook:
var xcode = require('xcode'),
    fs = require('fs'),
    projectPath = 'platforms/ios/MyProj.xcodeproj/project.pbxproj',
    proj = xcode.project(projectPath);

proj.parse(function (err) {
        var scriptName = 'My Script';
        var buildPhases = proj.getPBXObject('PBXShellScriptBuildPhase');
        if (JSON.stringify(buildPhases).match(scriptName)) {
            console.log('Xcode project not updated - ' + scriptName + ' already exists')
        } else {
            var options = {shellPath: '/bin/sh', shellScript: 'bash somescript.sh'};
            proj.addBuildPhase([], 'PBXShellScriptBuildPhase', scriptName, proj.getFirstTarget().uuid, options);

            fs.writeFileSync(projectPath, proj.writeSync());
            console.log('Xcode project updated - added ' + scriptName);
        }
});


User guide not complete

[Guide](../wiki/User's Guide)

Add paragraph about the purpose of the LayoutManager. Lays out header views, passes the buck to SLMs.
Add paragraph about SLMs. Lays out content views. Add link to developer page for SLMs where details for how to implement a SLM are.
Add stub to adapter views section.


(WIP) Run MIRI in a single thread

Which issue does this PR close?
Re https://github.com/apache/arrow-rs/issues/879
Rationale for this change
try to get a reliably passing MIRI run
The symptoms of the failing MIRI runs seem to be the same as would happen if the system OOM'd -- https://github.com/apache/arrow-rs/issues/879#issuecomment-957879870 so try running with a single thread to avoid blowing out memory

Codecov Report

Merging #906 (2a43d4e) into master (b79c600) will decrease coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head 2a43d4e differs from pull request most recent head f4438e0. Consider uploading reports for the commit f4438e0 to get more accurate results

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   82.30%   82.30%   -0.01%
==========================================
  Files         168      168
  Lines       48026    48026
==========================================
- Hits        39529    39528       -1
- Misses       8497     8498       +1

Impacted Files
Coverage Δ

parquet_derive/src/parquet_field.rs
65.98% <0.00%> (-0.46%)
:arrow_down:

arrow/src/array/transform/mod.rs
85.47% <0.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79c600...f4438e0. Read the comment docs.

https://github.com/apache/arrow-rs/runs/4084929751?check_suite_focus=true <-- experiment failed


Upload error

Got the same error for all uploaded images:

Any idea what the reason might be?
Display error without HTML tags?

checked htop a bit later on the server. it showed that no processing step was running.

the backend connection is missing on the netidee server - the backend always responds with 500 for every request
locally it is working fine

akiwa checked the server and it looked like it was a consequence of a too small partition for user data, which was probably a strange default setting from somewhere


Release 1.7.6

Version bump and housekeeping for release 1.7.6 as a first 1.x release after the fork. Removed traces of the 2.x plans, since this fork is intended for improving 1.x, not continuing with the 2.x beta.

Sorry for the noise. PR was intended to go to my fork, not to this repo.


Updating columnFilters state from outside doesn't update table state correctly

Description
I'm building a reset filters feature. The approach that I think of was the following one:
`    const [columnFilters, setColumnFilters] = useState([]);
<DataGrid
           ....
            state={{
                columnFilters,
            }}
            onFilter={setColumnFilters}
>
</DataGrid>

.....
 /// when a button is clicked:
 setColumnFilters([]);

`
But the state of the table remains the same.
Additional Information
seems to be similar with: https://github.com/Kuechlin/mantine-data-grid/issues/144 but the problems is to the columnFilters not to the rowSelection.

This issue is not valid, the state is updated and the scenario described works as expected, my previous test was wrong.

Updates: At first the table state appears to be updated and the filters are reset to [], but as soon I apply another filter, the old filters are also applied to the table


[Feature] Fixed issues with creating dates

Previously dates on the profile page would give error messages at weird times.
I went into the Date mixin and moved around some of the code and provided some new checks as well as editing some old ones to create a more intuitive experience that provides feedback to the user at the appropriate time.
[#OSF-4571]

Looks good to me @ticklemepierce! Done with code review 1 :jack_o_lantern:

Pass finished. Just one request for clarification above.


Asynchronous iframeResizer.min.js

I've been thinking about how to load iframeResizer.min.js asynchronously in the parent window. Bear in mind that this code HASN'T been tested and probably contains mistakes, it is just an idea.

...

...

So this is the first part, it would require to create inline the function "jQuery.fn.iFrameResize" if it hasn't already been loaded so it queues the commands(well, the iframe object and the command arguments) in the global variable "window.iFrameResizeQ".
Later on, after the iframeResizer.min.js file has been loaded and it has overwritten the function "jQuery.fn.iFrameResize" with the original/working one, the queue is executed in FIFO order as follows:
if (window.iFrameResizeQ) {
	var iFrameQer {};
	for ( var i=0; i < window.iFrameResizeQ.length; i++ ) {
		iFrameQer = window.iFrameResizeQ.shift();
		iFrameQer["object"].iFrameResize(iFrameQer["args"]);
	}
}

The code would be located at the end of iframeResizer.min.js
So far the main issue is having this feature working with both jQuery and native javascript seamlessly.  Also, what is the reason behind this line?

Why not just use requireJS or WebPack to achieve async loading?
That last line guards against loading the JS file twice.

If here you use dedicated script handlers then it makes native support for asynchronous loading redundant for you.
Still that last line would have to be changed to make the file compatible with native javascript queuing. I've worked an example that doesn't need to include the queue cleaner in the iframeResizer.min.js file but I can't implement an enqueuer for native javascript method without changing that last line.
For those not using requireJS or WebPack and using the jquery method the following(now tested) example can be quite useful

...

...

This last example can be added to the documentation/readme. If you want I will create an enqueuer for native javascript methods and expand the cleaniFrameQ function to cover that case, otherwise you can close this issue.


Colour background of raised button did not changed well when clicked

When clicked on Raised button in mobile mode only , the background colour of the button did not change well. need to click at other side to change back the background colour to normal.

Material-UI: V1.0.0 beta-.4
On Mobile mode only

We can always take advantage of the @media (hover: none) { feature to change the behavior. There is a StackOverflow issue close to it.

Thanks for the feedback, we are now closer to the native bahavior.


Teams Webhooks with markdown don't work

Hello,
Adaptive cards that contain markdown are not correctly rendered by Microsoft Teams.
In particular, the problem is with the following tags

Headings (level 1 through 6): # Heading through ###### Heading
Strike-through: ~~This text is struck through~~

Example JSON:
{
    "type": "message",
    "summary": "summary",
    "attachments": [
        {
            "contentType": "application/vnd.microsoft.card.adaptive",
            "contentUrl": null,
            "content": {
                "type": "AdaptiveCard",
                "body": [
                    {
                        "type": "TextBlock",
                        "text": "# Heading (not work)\n- list 1\n  - list 1.1\n- *Italics*\n- **Bold**\n- ***Bold + Italics***\n- ~~Strike-through~~ (not work)\n- [Microsoft](http://www.microsoft.com)\n- `inline code` (not work)"
                    }
                ],
                "msteams": {
                    "width": "Full"
                },
                "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
                "version": "1.3"
            }
        }
    ]
}

Teams output:

Expected result (Adaptive cards designer):

Hello @danygold - Thanks for raising your query.
We will look into it and let you know the updates.

@danygold -  Strike-through, #Heading,  inline code are not supported in Adaptive card.
Please find the list of markdown supported in adaptive cards.


Provider: NextDNS

Provider Repository
amalucelli/terraform-provider-nextdns
DCO

[X] I sign this project's DCO

Thank you for your submission @cpressland the provider should be available in the registry within the next hour.


Update react-komposer dependency

This will not work as utility composers were removed in v2.
https://github.com/arunoda/react-komposer#no-utility-composers-for-promises-redux-and-etc


A Docker image not based from Alpine?

We are using docker:dind to build images on AWS m5 EC2 instances. Some of the images that we build are based on node and installing some node packages causes an error when the container doing the install is based on Alpine:
Error: could not get uid/gid
[ 'nobody', 0 ]

    at /usr/local/lib/node_modules/npm/node_modules/uid-number/uid-number.js:37:16
    at ChildProcess.exithandler (child_process.js:301:5)
    at ChildProcess.emit (events.js:198:13)
    at maybeClose (internal/child_process.js:982:16)
    at Socket.stream.socket.on (internal/child_process.js:389:11)
    at Socket.emit (events.js:198:13)
    at Pipe._handle.close (net.js:606:12)
TypeError: Cannot read property 'loaded' of undefined
    at exit (/usr/local/lib/node_modules/npm/lib/utils/error-handler.js:98:27)
    at errorHandler (/usr/local/lib/node_modules/npm/lib/utils/error-handler.js:216:3)
    at /usr/local/lib/node_modules/npm/bin/npm-cli.js:77:20
    at cb (/usr/local/lib/node_modules/npm/lib/npm.js:225:22)
    at /usr/local/lib/node_modules/npm/lib/npm.js:263:24
    at /usr/local/lib/node_modules/npm/lib/config/core.js:83:7
    at Array.forEach (<anonymous>)
    at /usr/local/lib/node_modules/npm/lib/config/core.js:82:13
    at f (/usr/local/lib/node_modules/npm/node_modules/once/once.js:25:25)
    at afterExtras (/usr/local/lib/node_modules/npm/lib/config/core.js:173:20)
/usr/local/lib/node_modules/npm/lib/utils/error-handler.js:98
  var doExit = npm.config.loaded ? npm.config.get('_exit') : true
                          ^
TypeError: Cannot read property 'loaded' of undefined
    at exit (/usr/local/lib/node_modules/npm/lib/utils/error-handler.js:98:27)
    at process.errorHandler (/usr/local/lib/node_modules/npm/lib/utils/error-handler.js:216:3)
    at process.emit (events.js:198:13)
    at process._fatalException (internal/bootstrap/node.js:496:27)

This would not be a problem if there was a docker image that is not based from Alpine as this is an Alpine-m5 specific issue. Does such an image exist?

https://github.com/docker-library/docker/issues/146

I've got https://hub.docker.com/r/tianon/docker-tianon and https://hub.docker.com/r/tianon/docker-master, which are both Debian-based (the former is based on https://github.com/tianon/docker-deb-vendored, the latter is based on builds from https://master.dockerproject.org/).
If that's not good enough, it wouldn't be terribly hard to convert the relevant steps outlined in https://ram.tianon.xyz/post/2017/05/18/docker-setup-redux.html into a simple Dockerfile.

I think the docker image was likely not the real problem. I'm going to close this.


Make flash button's animation faster

The animation for the flash button is currently slow, it should be faster.

Hi @shahednasser, could I pick this one?

i could work on that. as i can see the animation is 2s long now. how much faster should it be in your opinion?

oh, well, nvm then

I want to fix this issue.


Cant import part from shared library

Hi! I compiled the shared library from ngspice (master) and enabled shared library flag.
Successfully found those on my Ubuntu16.04 under /usr/local/lib :
libngspice.so, libngspice.so.0, libngspice.so.0.0
In jupyter I included the library as following as in the example of the diode in 8.2.1 and changed this line to:
libraries_path = os.path.join(os.path.dirname('/usr/local/lib/'), 'libraries')
spice_library = SpiceLibrary(libraries_path)
When I try spice_library['1N4148']  I get the key error because spice_library has no entry of this part.
When I open interactive python console and look into the class of spice_library I have only two empty subclasses:
models  subcircuits
Could anyone tell me what I am missing?

It looks like you are conflating two identically-named packages called SPICE:  one is an electronics simulation package, IIRC; the other is a toolkit for working with spacecraft mission geometry and events written by the Navigation and Ancillary Information Facility at the Jet Propulsion Laboratory (NAIF/JPL).
PySPICE is related to the latter.

Wow I mixed this up! Those are indeed named both PySpice and PySPICE. Thank you for the hint!


Revisit all iconography in the PT Plugins that have been moved over

This is blocking on #78. After that is improved, we need to ensure that the icon story matches for each and every PT Plugin that we have moved over.

It kinda seems like a lot of the icons in the existing PT Run plugins are just images of segoe UI icons. I bet you could just use the equivalent segoe icon, and get the light/dark icons for free. No need to futz with actual pngs.


Refactor QueryParser

Description

Make DicomTagParser into static class, remove support to sequence tags which is not implemented.
Move QueryParser.ParameterParser.cs into QueryParamsParser.cs
Move QueryParser.TagValueParser.cs into QueryFilterConditionParser.cs

Related issues
Addresses AB#84774
Testing
All tests pass

Already included in https://github.com/microsoft/dicom-server/pull/1052


EnableAppDesktopsharing not per-user level

Based on the following bug, EnableAppDesktopsharing is not enforced at the per-user level.
https://icm.ad.msft.net/imp/v3/incidents/details/87254892/home

OPS Build status updates of commit 6787f76:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit 6787f76:
:clock10: Incremental building: average incremental building time is 12 min(s) 22 sec(s)

OPS Build status updates of commit ce573e6:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit ce573e6:
:clock10: Incremental building: average incremental building time is 12 min(s) 22 sec(s)

OPS Build status updates of commit ce573e6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsConferencingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


1.3.0

This closes #7 and closes #3

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4af5f42). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #9   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      7
  Lines             ?    122
  Branches          ?      4
=======================================
  Hits              ?    122
  Misses            ?      0
  Partials          ?      0

Impacted Files
Coverage Δ

generators/job/index.js
100% <100%> (ø)

generators/app/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af5f42...0e28f32. Read the comment docs.


Responsive mode seems to apply to screen 1 only

See this message from Ghica:
Hi, I am trying the pending release of the responsive system.
(http://ai2-test.appinventor.mit.edu)
I have a very simple testcase (aia attached) with two screens, both with a canvas of 100px square. If I use responsive mode, the width of my screen is 600 on my first screen, but whatever I do, it stays 320 on the second screen.
Here a link to the test case.
https://drive.google.com/open?id=0B3jsksMcCW5bZlNrMGNxeVhWNTA

I believe I can fix this without a component release!

#513 was closed