[Go Live][Dec 15]

Push to live

Learn Build status updates of commit 3911b2a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 3911b2aa6e2bf6c9eb1a73746a8dc5bafc1186fb in branch main of repository https://github.com/MicrosoftDocs/msteams-docs into branch live (commit 13eadf699e07acbefb07dfa84b35555cce8cdb45). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit d826bca:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Roll Flutter from 9cfaabaed09e to e8c7a88914e5 (4 revisions)

https://github.com/flutter/flutter/compare/9cfaabaed09e...e8c7a88914e5
2022-03-09<EMAIL_ADDRESS>Updated tokens to v0.90. (flutter/flutter#99782)
2022-03-09<EMAIL_ADDRESS>Marks Mac_ios backdrop_filter_perf_ios__timeline_summary to be unflaky (flutter/flutter#99836)
2022-03-09<EMAIL_ADDRESS>updateEditingValueWithDeltas snippet docs fix (flutter/flutter#99570)
2022-03-09<EMAIL_ADDRESS>Roll Engine from 9362061fbb79 to a0963f14b67d (1 revision) (flutter/flutter#99838)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Plugins: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Deploy contracts

Add a feature to deploy contracts to Starknet

@clementjuventin is working on this contribution
OnlyDust link : https://app.onlydust.xyz/contributions/0x007a

This is now released.


Add complex inverse function

Resolves addition of complex/inv, as discussed.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines, including the relevant style guides.
[x] Read and understand the Code of Conduct.
[x] Read and understood the licensing terms.
[x] Searched for existing issues and pull requests before submitting this pull request.
[x] Filed an issue (or an issue already existed) prior to submitting this pull request.
[ ] Rebased onto latest develop.
[x] Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

add a complex inverse function using logic distilled from complex/divide. That is, it's mostly just complex division code evaluated for re1 = 1, im1 = 0 in a manner that matches the julia code.

Questions

Any questions for reviewers of this pull request?

I left the references intact since if you want to dig into this function, your best bet would be to read and simplify the complex division references. Does that seem reasonable?
"Compute the inverse of a complex number." I'm sure you'll let me know how you feel about that tense/voice.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

@stdlib-js/reviewers

Awesome!

We only use the imperative mood (e.g., Compute) in three places:

Top description in the README, underneath the README first-level heading.
In the package.json.
In the JSDoc comment in index.js where we provide the module definition and examples.

Everywhere else, we use active voice (e.g., Computes).

Will wait for Circle CI to finish before squashing and merging. Thanks for your work on this @rreusser!


remove storage option

as the amount of work maintaining old storage versions is very high and the benefit of storing the API model as a file in contrast to storing the last version and retrieving a live version of it (via pub or git ref) is very low we want to drop support for storing (and loading) the model.
We could keep the storing option (so that other scripts could use the model)

will be solved by #67


Action buttons in map are wrong positioned in narrow window

Context
when in the map view the action buttons (change to table view, add geometry, ...) are wrong positioned if you narrow the viewport
Steps to Reproduce
Please break down here below all the needed steps to reproduce the issue

open a map
make the viewport narrow-er

Current Result
buttons are not aligned with zoom/search
Expected result
buttons should be aligned with zoom/search
Additional info

Not happening anymore, closing!


updated multiplesin example to use new api

API changed in version 0.2 which could be confusing to users. This closes #4 which is one such instance of this confusion.

Thank

Thanks, aspidites. Can this change be pulled into the master branch?


elasticache nuke error

Noticed that elasticache removal fails with error:
Nuking batch of 1 elasticache resource(s) in eu-central-1 [19/931]  2% | 6sERRO[2024-11-11T10:09:41Z] runtime error: invalid memory address or nil pointer dereference  binary=cloud-nuke version=e4e9493b52bd500015b49e2b3ed88a93fc3811fe

log-1.txt

Hey, I was able to reproduce the issue by creating a single-node cluster. I addressed the problem in #783.


Streaming logs don't capture Verbose level?

Info level is captured, but not the Verbose.

There was a change in the previous release to the default log level. It is now Info rather than Verbose. You can adjust that in your host.json' file by setting the tracing.consoleLevel` property to "Verbose".


Add Issue template

This template will be used by GitHub when a new issue is created.
It gives a structure to the issue and the contributor a framework to articulate thoughts well

Thank you @tallpsmith 👍


RequestQueue URL Parsing with # Parameter

Describe the bug
Requestqueue ignores everything after # and thinks it's the same URL
To Reproduce
const Apify = require("apify");

(async() => {
    const urls = ['https://example.com/#/param','https://example.com/#/param2','https://example.com/#/param3']

    const requestQueue = await Apify.openRequestQueue();
    for (const url of urls) {
        await requestQueue.addRequest({url});
    }
    console.log(`Requests in requestQueue: ${(await requestQueue.getInfo()).totalRequestCount}`);
})()

Will return:
Requests in requestQueue: 1
Expected behavior
I would expect that the Request Queue adds all of these URLs.
I currently do:
url.href.replace('#', '%23')
with each of the URLs and in
handlePageFunction()
const url = page.url(); await page.goto(url.replace('%23', '#'))
Not a clean way to do it (maybe there is something I missed)
System information:

OS: Windows
Node.js version v16.14.0
Apify SDK version 2.3.0

Additional context

You need to use keepUrlFragment

If false then the hash part of a URL is removed when computing the uniqueKey property. For example, this causes the http://www.example.com#foo and http://www.example.com#bar URLs to have the same uniqueKey of http://www.example.com and thus the URLs are considered equal. Note that this option only has an effect if uniqueKey is not set.

await requestQueue.addRequest({url, keepUrlFragment: true});

@B4nan
I'm sorry to waste your time :(
Thank you very much!


Support post-config scripts in targets and executables

Use-case: not all configurations are legal, and not all logic for valid configs can be encoded using techniques like the JSON-Schema approach that has been previously discussed. Thus, yotta should offer a way for targets and applications to provide custom logic (e.g. a post-config pre-build script). Since targets are in a hierarchy, yotta should run all such scripts in the target+executable hierarchy and ensure all scripts exit without and error exit code.

'post-config' would be 'pre-build', I think


CI: Temporarily disable pxt docker build until image becomes available.

As mentioned in:

https://github.com/lancaster-university/codal-microbit-v2/issues/338#issuecomment-1658767316

As this is a CI-only change that will help us catch issues in the MakeCode builds (since right now it's always red), I'll merge this now, as I'd like to submit a few PRs tomorrow and it'd be good to ensure MakeCode doesn't have any issue with those.


[Feature Request]: Enhance Services Page with Additional Fitness and Wellness Offerings

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Expand the FitFlex website's Services page by adding new fitness and wellness services. These additions aim to provide a more comprehensive range of offerings, catering to the diverse needs of clients, from fitness enthusiasts to those looking to improve overall health and well-being.
Use Case
New Services to Add:
1)Group Fitness Classes
Engage in high-energy group sessions like HIIT, yoga, pilates, and circuit training, designed to keep clients motivated and
connected.
2)Lifestyle and Wellness Coaching
Offer holistic guidance on stress management, mental wellness, and lifestyle changes to support overall health.
3)Posture and Mobility Improvement
Introduce sessions focused on enhancing posture, flexibility, and joint mobility for daily comfort and improved movement.
4)Fitness Assessments and Tracking
Provide regular assessments to monitor progress, set new goals, and give feedback on achievements.
5)Strength and Conditioning Programs
Develop specialized programs for building strength, endurance, and athletic performance, ideal for athletes and enthusiasts.
Benefits
1)Attracts a diverse client base, from beginners to advanced athletes.
2)Enhanced Client Retention
3)Increased Revenue Opportunities
4)Empowers clients to track their progress with assessments and feedback.
5)Adds services like injury prevention for a sustainable fitness journey.
Add ScreenShots

Like these above mention cards in the screenshots I want to add more Cards as a services part of view.
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC-EXT contributor
[ ] I'm a HACKTOBERFEST contributor
[X] I have starred the repository

could u pls assign this issue to me I really wanna work on it

@GAVINESHWAR  its done sir


[BUG]: InferInsertModel is omitting nullable columns

What version of drizzle-orm are you using?
0.32.2
What version of drizzle-kit are you using?
0.23.2
Describe the Bug
After upgrading from 0.31.2 to 0.32.2, some of my schema models started breaking.
E.g: With a schema like so:
export const foos = pgTable('foos', {
  bar: text('bar').notNull(),
  baz: text('baz'),
  createdAt: timestamp('created_at', { mode: 'date' })
    .default(sql`CURRENT_TIMESTAMP`)
    .notNull(),
});

export type InsertFoo = InferInsertModel<typeof foos>;

The inferred type of InsertFoo is
{ bar: string }

Expected behavior
The inferred type of InsertFoo should've been:
{
  bar: string,
  baz?: string // or maybe baz: string | null | undefined?
}

Environment & setup
Windows 10
npm v8.19.3
node v20.11.0

Looks like this might be a duplicate of or related to https://github.com/drizzle-team/drizzle-orm/issues/2636

I'm gonna close this since its a duplicate of 2636.


Taskrun gives error while pulling image from ECR

Expected Behavior
Running the task and taskrun on the EKS cluster and pulling the image from ECR.
Actual Behavior
When I view the taskrun logs, I am seeing the below error message:
task test has failed: failed to create task run pod "image": translating TaskSpec to Pod: error getting image manifest: unsupported status code 401; body: Not Authorized. Maybe missing or invalid Task default/image
Error: pod for taskrun irxep-ui not available yet

Steps to Reproduce the Problem

Run the below yaml

apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: test
spec:
  steps:
    - name: image
      image: Account#.dkr.ecr.us-east-1.amazonaws.com/image:latest
---
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  name: testtask
spec:
  taskRef:
    name: test

Additional Info
The below test deployment using the nginx is working just fine.
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: nginx
spec:
  steps:
    - name: nginx
      image: nginx:latest
---
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  name: nginx
spec:
  taskRef:
    name: nginx

Kubernetes version:
EKS 1.16
Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T23:35:15Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.8-eks-e16311", GitCommit:"e163110a04dcb2f39c3325af96d019b4925419eb", GitTreeState:"clean", BuildDate:"2020-03-27T22:37:12Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:

v0.12.1
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'
Client version: 0.9.0
Pipeline version: v0.12.1

See here for a workaround: https://github.com/tektoncd/pipeline/issues/1539#issuecomment-640457021

/kind bug

I'm having the same issue, @MarcusNoble tried the WA but it didn't work for me.

Issue still exists in Tekton v0.29.0:
  steps:
    - name: test
      image: 123456789.dkr.ecr.some-region.amazonaws.com/some/image:1.2

Fails with:
  Warning  Failed   11s (x2 over 11s)  TaskRun  failed to create task run pod "test-task-s6847": translating TaskSpec to Pod: error getting image manifest: GET https://123456789.dkr.ecr.some-region.amazonaws.com/v2/some/image/manifests/1.2: unexpected status code 401 Unauthorized: Not Authorized
Workaround:
It works when you provide a command (args only are not sufficient):
  steps:
    - name: test
      image: 123456789.dkr.ecr.some-region.amazonaws.com/some/image:1.2
      command: ["python3", "test.py"]

Though the command duplicates the already defined ENTRYPOINT within the image, it at least prevents Tekton from trying to fetch the manifest from ECR.
Had this issue on v0.27.2 first. Just upgraded to v0.29.0, same error.


Population is broken in case of join with additional condition

Let's imagine i have entities Report and Organization. Report belongs to some Organization. Organization has field domain that isn't PK. I need to filter Reports by organization domain:
const [reports, total] = await this.em.findAndCount(
      Report,
      {
        researcher,
        organization: { domain:  'some-domain'},
      },
      {
        populate: ['organization', 'product'],
        orderBy: orderByMapper[sorting.sortBy],
        ...pagination,
      },
    );

if i run it without populate parameter it generates correct query, but if i populate organization i see the following:
err: {
      "type": "Error",
      "message": "select `e0`.*, `e1`.`id`, `e1`.`undefined` from `report` as `e0` left join `organization` as `e1` on `e0`.`organization_id` = `e1`.`id` where `e0`.`researcher_id` = 3 and `e1`.`domain` = 'mydomain' order by `e0`.`code` desc limit 10 - Unknown column 'e1.undefined' in 'field list'",
      "stack":
          Error: Unknown column 'e1.undefined' in 'field list'
              at Packet.asError (/home/alexandermartynov/projects/ioxt/haxlab-be/node_modules/mysql2/lib/packets/packet.js:708:17)
              at Query.execute (/home/alexandermartynov/projects/ioxt/haxlab-be/node_modules/mysql2/lib/commands/command.js:28:26)
              at Connection.handlePacket (/home/alexandermartynov/projects/ioxt/haxlab-be/node_modules/mysql2/lib/connection.js:408:32)
              at PacketParser.Connection.packetParser.p [as onPacket] (/home/alexandermartynov/projects/ioxt/haxlab-be/node_modules/mysql2/lib/connection.js:70:12)
              at PacketParser.executeStart (/home/alexandermartynov/projects/ioxt/haxlab-be/node_modules/mysql2/lib/packet_parser.js:75:16)
              at Socket.Connection.stream.on.data (/home/alexandermartynov/projects/ioxt/haxlab-be/node_modules/mysql2/lib/connection.js:77:25)
              at Socket.emit (events.js:198:13)
              at Socket.EventEmitter.emit (domain.js:448:20)
              at addChunk (_stream_readable.js:288:12)
              at readableAddChunk (_stream_readable.js:269:11)
              at Socket.Readable.push (_stream_readable.js:224:10)
              at TCP.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)
      "code": "ER_BAD_FIELD_ERROR",
      "errno": 1054,
      "sqlState": "42S22",
      "sqlMessage": "Unknown column 'e1.undefined' in 'field list'"
    }

As a workaround i have to run population later now. As i understand the problem is reproduced when:

I use join with additional condition
I use population by the same relation

Versions
alpha 22

As said in the other issue, please test it with latest version (3.0.0-alpha.25) and provide definition for both entities (you can omit properties that are not significant for this issue).

mikro-orm-test.zip
Attached you can find sample app that illustrates the issue on alpha.25

You need to run db in docker
docker run --name mikro-orm-db -e MYSQL_DATABASE=mikroorm -e MYSQL_USER=mikroorm -e MYSQL_PASSWORD=mikroorm -e MYSQL_ROOT_PASSWORD=mikroormroot -p 3307:3306 -d mysql:5.7

Just checked the package-lock.json and I see you are using 3.0.0-dev there:

Seems  "mikro-orm": "^3.0.0-alpha.25" resolves to 3.0.0-dev.4. I am sorry. I forced version and looks like it works fine with "mikro-orm": "3.0.0-alpha.25"

Yeah as I said, I recently fixed few issues that looked similar :] So all good, can we close this?

Yes


consider stronger typing for Server::listen arguments

the Server::listen call currently takes an &str for both host and port. This gets fed into a format! call, using the a str impl of ToSocketAddr.
IMHO, there is no opinion to stringly-type these parameters. Taking a std::net::IpAddr and a u16 does exactly the same, with stronger typing. The combination (IpAddr, u16) even has a ToSocketAddrs-impl, so it can be directly passed into the TcpListener.
As discussed on users.rust-lang, this would add some boilerplate on the user-side to create the IpAddr:
IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)); // verbose, guaranteed to work...
"<IP_ADDRESS>".parse().expect("couldn't parse IP address") // not much better...

the goals of this project are to make an easier user interface. so i dont think we'd like to push this onto our developers. however, if we implement default values for port and host (https://github.com/steveklabnik/simple-server/issues/25) i think this might be something we consider.
thanks for filing!

 As I said on users.rust-lang, I believe a project like this can be the "gateway drug" for a whole new generation of people, just like node was. Only this time they'll learn to expect safe, native software, instead of callback-tangles (sorry, a little bit tongue-in-cheek there)
I can understand that &str is easier for the IP-address, but for the port? port: u16 seems easier to me than port: &str? And the format! should be able to take a u16 or a &str with equal ease, no?
Of course, there may be other things I'm missing; I've spent considerably less time on this than you two obviously have :-)

Even in the node example, the port is a number, not a string.

FWIW, yes to u16 for the port. A string for the host seems like the ideal choice because hostnames: "<IP_ADDRESS>" -> "localhost" is an example of a very simple transformation that users may instinctively want to use. Also, IPv6 "::1".

Cliff on URLO mentions that [127,0,0,1].into() should also work for the IP, including IPv6.
That's good enough for me!
I'm also pondering if using Into<IpAddr> might be a good type for the parameter.. this may be confusing to newcomers though...

FWIW, Unix has a concept of names for particular ports, listed in /etc/services, like
http             80/udp     www www-http # World Wide Web HTTP

For this reason, Unix functions like getnameinfo and getaddrinfo are similarly stringly typed: you can pass either a decimal representation of the port number, or one of the service names.
…But I've rarely seen any modern code use this, so it feels really old-fashioned, and it's probably not worth supporting in simple-server.  On the other hand, if you do end up keeping the port argument a string, for whatever reason, then it ought to be supported.


Santinize db.statement for static queries

What version of OpenTelemetry are you using?
My package.json
{
  "name": "js",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@opentelemetry/api": "^1.6.0",
    "@opentelemetry/auto-instrumentations-node": "^0.39.4",
    "@opentelemetry/instrumentation-pg": "^0.36.2",
    "body-parser": "^1.20.2",
    "express": "^4.18.2",
    "pg": "^8.11.3",
    "sqlite3": "^5.1.6"
  }
}

What version of Node are you using?
v20.6.1
What did you do?

When we use opentelemetry-instrument to automatically instrument a express app connected to postgres database, we notice that it doesn't sanitize queries with constant parameters, even though it collects db.statement by default. It goes against OTel semantic conventions .
What did you expect to see?
I expect to see db.statement sanitized.  But am seeing below trace for static queries (/select endpoint in below code). Sanitization works well for queries with params (/users/John) in below code.
What did you see instead?
{
  traceId: '7fed3a44c4611f0035e5091c9a6bbed7',
  parentId: '6666ad513beeb304',
  traceState: undefined,
  name: 'pg.query:SELECT postgres',
  id: '8e230a83eb8f174d',
  kind: 2,
  timestamp:<PHONE_NUMBER>703000,
  duration: 2141.875,
  attributes: {
    'db.system': 'postgresql',
    'db.name': 'postgres',
    'db.connection_string': 'postgresql://localhost:5432/postgres',
    'net.peer.name': 'localhost',
    'net.peer.port': 5432,
    'db.user': 'dinesh.gurumurthy',
    'db.statement': "select * from users where name = 'John'"
  },
  status: { code: 0 },
  events: [],
  links: []
}
{
  traceId: '7fed3a44c4611f0035e5091c9a6bbed7',
  parentId: undefined,
  traceState: undefined,
  name: 'GET /select',
  id: '6666ad513beeb304',
  kind: 1,
  timestamp:<PHONE_NUMBER>681000,
  duration: 26401.625,
  attributes: {
    'http.url': 'http://localhost:3000/select',
    'http.host': 'localhost:3000',
    'net.host.name': 'localhost',
    'http.method': 'GET',
    'http.scheme': 'http',
    'http.target': '/select',
    'http.user_agent': 'curl/8.1.2',
    'http.flavor': '1.1',
    'net.transport': 'ip_tcp',
    'net.host.ip': '::ffff:<IP_ADDRESS>',
    'net.host.port': 3000,
    'net.peer.ip': '::ffff:<IP_ADDRESS>',
    'net.peer.port': 51169,
    'http.status_code': 200,
    'http.status_text': 'OK',
    'http.route': '/select'
  },
  status: { code: 0 },
  events: [],
  links: []
}

Additional context

Code
const express = require('express');
const bodyParser = require('body-parser');
const db = require('./database');

const app = express();
const PORT = 3000;

app.use(bodyParser.json());

// CREATE: Add a new user
app.post('/users', async (req, res) => {
    const { name, email } = req.body;
    try {
        const { rows } = await db.query("INSERT INTO users (name, email) VALUES ($1, $2) RETURNING id", [name, email]);
        res.json({ id: rows[0].id, name, email });
    } catch (err) {
        res.status(500).json(err);
    }
});

// READ: Get all users
app.get('/users', async (req, res) => {
    try {
        const { rows } = await db.query("SELECT * FROM users");
        res.json(rows);
    } catch (err) {
        res.status(500).json(err);
    }
});

// READ: Get user by name
app.get('/users/:name', async (req, res) => {
    try {
        const { rows } = await db.query("SELECT * FROM users WHERE name = $1", [req.params.name]);
        if (!rows.length) {
            return res.status(404).json({ message: "User not found" });
        }
        res.json(rows[0]);
    } catch (err) {
        res.status(500).json(err);
    }
});

// READ: Get user by name
app.get('/select', async (req, res) => {
    try {
        sql = "select * from users where name = 'John'"
        const { rows } = await db.query(sql)
        if (!rows.length) {
            return res.status(404).json({ message: "User not found" });
        }
        res.json(rows[0]);
    } catch (err) {
        res.status(500).json(err);
    }
});
app.listen(PORT, () => {
    console.log(`Server started on http://localhost:${PORT}`);
});

Right now we don't sanitize static queries because it would require parsing the SQL itself. Queries with parameters are properly sanitized because we know what they are. The only way to solve this would be to disable collecting ALL static queries by default and making them opt-in.
Also note that the semconv is a recommendation, not a requirement in this case.

I think we should engage with the semconv group on what we should do in this case. I think its unlikely that they expect SDKs to parse SQL statements, but I also don't know if they intended to disable collection of static queries.

@dyladan That make sense. I found similar issue with Python SDK https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2003 . While Java sdk is sanitizing static queries. we Should address the inconsistencies across languages.

There are other instrumentations moving to an opt-in approach. In this PR the intent is to let the user provide a serializer for the statement defaulting to a noop which does not serialize at all
https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1748

Is there any easy workaround that allows us to alter or omit the db.statement attribute somehow?
The only option I've found is to run an instance of attributesprocessor, but that requires deploying a whole separate process with a different language runtime, which I don't have bandwidth for. So I'm just omitting the Postgres instrumentation from my app, regrettably.


Add macOS kitchen testing

This is probably going to have to be done outside of Buildkite. We should probably just set it up in Azure Devops Pipelines or another CI system since we don't have public mac testers.

We have this in azure pipelines now. Thanks @btm @christopher-snapp


fix: Parse error occurs before PHP version check

Description
Fixes #6306
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

then https://github.com/kenjis/CodeIgniter4/blob/6ac3a7bfe48e72b687c5727cd60f88b9724da4ac/system/Language/en/Core.php#L17
should be removed


Added caching

Implemented two types of caching:

Exact caching: Searches for exact match of the input prompt and returns the cached response. If not found, stores the new response from the LLM model
Similarity caching: Performs a similarity search on the input prompt and returns the closest cached response.

another awesome contribution-- thanks @HemuManju 🎉 !


High level of estimated contamination for same sample but different set of filtered cells

Hi Team at Celda,
Recently, my cellranger output looked unusual where CR estimated 4,000 cells -> I expected 10,000 cells assuming 20,000 cells were loaded with a 50% capture rate.
I wanted to see what happened to my sample so I forced cellRanger to return 10,000 cells so then I could assess "cells" 4000 - 10,000
I ran decontX on both results (default CR and forced 10,000) with both the filtered and raw matrices as input for decontX
Surprisingly, for the default results -> the estimated contamination was low (which is great) but the 10,000 set had much higher levels of estimated contamination

This is the default cells by CR

This image is the forced 10,000
I have also compared the contamination estimates between the default and forced-10,000 to see what the differences in estimation are for the same cells

Where it appears that cells that were estimated to have low contamination now have high levels
Is this behaviour expected or do I need to set parameters in the decontX function?

Hi @dlee598, thanks for using our tool! Just to double clarify, is the scatter plot you are showing for the 4000 cells that were included in both analyses? Can you show the cluster labels that decontX generated in each analysis?
I'm wondering if some cells that were estimated to have lower contamination in the default setting (first analysis) ended up in the same cluster with cells/droplets that were originally excluded (second analysis). You can specify your own cluster labels from another tool such as Seurat using the z parameter which may help with this.
In general it appears that both CelRanger and decontX agree that the extra cells you get by forcing 10K cells look like ambient background. So you may not want to include those in your downstream analysis.
Also, I am going to convert this Issue to a Discussion as other people may have similar questions.


how to re-initialize cropper?

How can I re-initialize cropper if I dynamically include path to cropper.js with

Destroy it first, and then initialize again.

After the script reference is loaded into  I'm trying to initialize it, but I get this error that copper is not a function, so there is nothing to destroy and $('#image').cropper returns the error

I guess you loaded a wrong script. Which one you are using?

https://github.com/fengyuanchen/cropper
https://github.com/fengyuanchen/cropperjs

I was using jquery based cropper and everything was working fine when the link was present in html.
Than new requirement came to load script on button click and it stopped working.
Now I tried JS based cropperjs and was able to use it, just have to re-write some old jquery code now, so I was thinking if it was possible to initialize jquery cropper.

There is no proper example for destroying the cropper session using jquery. In documentation it is written
`destroy()
Destroy the cropper and remove the instance from the image.`
But i don't understand where to write this code

@milpas999 $('img').cropper('destroy')

Hi...
And how destroy cropper using pure javascript?

If you have:
var cropper = new Cropper(image, {...});

Then you can destroy it by writing:
cropper.destroy();

But how to reinit after the destroy?
It is removing the element from the DOM.


Tests are failing cause of incorrect DB setup

We have failing test on Travis. There are multiple revisions saved while should be one per each dataset. This is happening cause we are erasing data only ones from db (on the start) - we need to do that after each test
Acceptance criteria

[x] Travis is passing

Tasks

[x] delete from tables after each test

FIXED


Edge/Line wrapping around the components to which it is connected.

It would be so awesome if an optional feature could be included in the fdl which would allow the line to avoid crossing over those components to which it is connected.
Line right now:

Required Feature:

OR

It's already implemented. In current demo app it's possible by long clicking on the line.
It is intended to allow library user to use their own gesture to make it work.

Works perfectly!


Extract method/variable doesn't work in the middle of a function

Using this code here:
def function():
    codeToExtract = 1
    print(codeToExtract)

Highlight the codeToExtract=1 line and try Extract Method or Extract Variable.
Both do nothing and output this in the log:
2024-01-25 15:30:58.919 [info]   Message: Request workspace/executeCommand failed with message: applyEditSync failed with error 0
  Code: -32603

This is not a regression, reproduces in 2023.12.1

Oh wait this is 'syncServer' only.

I have the same error

bump

@Morriz it's unlikely your issue is the same. This error I had was only with our experimental 'syncserver' which you have to add a setting to turn on explicitly. Can you open a new issue?

Somehow that setting was turned on in my local settings.json. Turned it off and the problem disappeared :)


ISO.CREATE event is not present for Kubernetes ISO registration

ISSUE TYPE
Bug report
COMPONENT NAME
Component: UI
CLOUDSTACK VERSION
Cloudstack version 4.18
SUMMARY
ISO.CREATE event is not present for Kubernetes ISO registration
Steps to reproduce the issue
Register a kubernetes iso

Navigate to

Image> Kubernetes ISO > Add Kubernetes Iso

Navigate to

Image > ISo's > Events

The iso create event is present in the event section only

Expected behavior
ISO.CREATE event should be present for the kubernetes iso
Actual behavior
ISO.CREATE event should be present for the kubernetes iso

Is there an event under the actual ISO @kiranchavala ?

@rohityadavcloud there is a event present  for normal iso's

@kiranchavala @rohityadavcloud Current design allows only one resource to be linked with an event. Here the actual ISO is linked as with any ISO registration. Also, currently, we do not have any events for KUBERNETES as such so would it be a better idea to add new event types?

Fixed by https://github.com/apache/cloudstack/pull/9070


Implement support of isStarted

Thanks! Please allow me only to change the property's name. Merged: https://github.com/shu223/Pulsator/pull/9


Allow any component with a reference to the router to send a routing failed message

This routing failed message would be picked up by Yew routers with the 404 role, and the default route would be displayed.
It would be a novel idea if components didn't need to keep the router around for this. Conceptually, the router never needs to be attached to the model if all it does is send things, as an instance could quickly be created and destroyed.
Code like this should be possible:
if response.did_404() {
    TemporaryRouter::send(self.link, RouterRequest::RoutingFailed);
}

Maybe not the Router Agent, but instead maybe a separate entity named YewRouterNotifier

Outdated implementation


No moons or planets

On my MP server, started a fresh modpack with advanced rocketry and when I try to go to the moon there is nothing there.   When I click select destination, there is just the earth and no moon.  When opening the planet selector, all of the solar systems have 0 planets.  Getting this with a fresh server and fresh config.

Was this with AR version 1.0.11?

yes.  I just upded to 1.0.12 and seems to be better, except now i'm having issues with a lot of planets showing up as gas planets, including the moon on earth.  I have changed in the config to have the dimensions for the planets to start at number 1000, but I don't know if that is causing it.

If you want me to test anything let me know.  Also, where is this planet data located?  I'm trying to get this fixed in my modpack so I don't have to start over from scratch.

Planet data is located in /advRocketry/temp.Dat. you can
open it with an nbt editor


Improve client tool constant generation code

Description:
Refer this comment https://github.com/ballerina-platform/module-ballerina-grpc/pull/1095#discussion_r1034627827

@dilanSachi , @keizer619 - I can pick this up. Please assign to me..

Hi @rashmibharambe   🚀
We value your contributions and look forward to collaborating with you.
To help you get started, here are some essential resources:

Understanding Ballerina Platform: Learn what Ballerina is all about: Ballerina Platform
How to Contribute: Read our contributing guidelines to understand how you can contribute effectively: Contribution Guide
Learn Ballerina: If you're new to Ballerina or want to enhance your skills, our official website offers a wealth of learning resources: Learn Ballerina
Get Help and Connect: Join our Discord community to chat with fellow Ballerina enthusiasts and get assistance: Ballerina Discord

Remember, no contribution is too small, and your feedback is invaluable. Feel free to ask questions, propose ideas, or report issues. Together, we can make Ballerina even better!
Happy coding! 🎉

@rashmibharambe
Let me give you some context regarding this specific issue.
In Ballerina gRPC, we use the protoc-tool[1] to generate the ballerina files needed for the gRPC client and service. Earlier this tool was combined with the gRPC runtime in the module-ballerina-grpc, hence you see the above comment in that repo. What you have to do is follow the review comment and use a constant map instead of the switch case.
Also, if you want learn about gRPC and the protoc-tool you can follow these.

https://ballerina.io/learn/by-example/grpc-service-simple/
https://ballerina.io/learn/grpc-tool/

[1] https://github.com/ballerina-platform/protoc-tools

@dilanSachi I have raised PR please check and let me know if any comments. Thanks.

@rashmibharambe Merged your PR. Great work and thanks for your contribution. You are always welcome to contribute to other existing issues.


Add creation of truststore.p12 from CA

What this PR does / why we need it:
Add support for creation of PKCS12 truststore.p12 using Certificate Authority.  This implementations follows the same pattern as the creation of truststore.jks and leverages the go-pkcs12 EncodeTrustStore function to produce a PKCS12 trust store that is compatible with Java 8 and greater.
Which issue this PR fixes:
fixes #3373
Special notes for your reviewer:
Release note:
Add creation of PKCS12 truststore.p12 using Certificate Authority

Signed-off-by: David Handermann<EMAIL_ADDRESS>

/assign @munnerz

/kind feature

/assign

Thanks a lot for this! We're not the biggest pkcs#12 users so all help is welcome.
Looks good to me, just a small nit in the code
/approve

/ok-to-test

Thanks for the quick review and feedback, I pushed an update to simplify the return statements of the encode PKCS12 functions.

/retest


added the main.py and readme along with dataset file

Description

This project utilizes a Random Forest Classifier for binary classification, which is effective for structured data and allows us to evaluate feature importance. Random Forest is suitable for this problem because it handles various customer data types (e.g., demographics, account details, and service usage) and helps identify key factors contributing to churn. The model provides a clear, interpretable outcome, highlighting the primary attributes associated with churn behavior.
Issue Resolved

#205
Changes Made

Added the main.py, dataset.csv and readme file
Screenshots or Videos

Additional Details

Checklist

[x] My code follows the current project structure
[x] I have thoroughly reviewed and updated the requirements.txt file to include any new packages
[x] The predict.py file includes a properly implemented model_details() function, or the notebook contains this function to print a detailed model report. The model will not be accepted without this function, as it is essential for generating the necessary model details.
[x] I have added relevant tests (if necessary).
[x] I have added comments in the code where needed.
[x] This PR is submitted under Hacktoberfest.
[x] This PR is submitted under GirlScript Summer of Code (GSSoC-Extd).

i would like to contribute @yashasvini121

@yashasvini121 I have made the changes as per tutorial.md.


Some Problems about Global Query and deduplication

I want to know some design questions about global query and deduplication.
1:  Does it query all Prometheus instances about Global query(Global querying view)？
2:  The Prometheus instance sets up replica_label, and when querying, one of the returns will be
queried according to replicas_label or all of them will be returned after deduplication.
Sorry to be a nuisance，I want to know the code module of the above part.

1: Does it query all Prometheus instances about Global query(Global querying view)？

Yes, the Query component would query all of the sources by store API on the top of layer, the sources could be sidecar(Prometheus) or store gateway(long-term storage: object storage).  So it can query cross multi environments. You can look the document for the detail.

2: The Prometheus instance sets up replica_label, and when querying, one of the returns will be
queried according to replicas_label or all of them will be returned after deduplication.

The replica_label is used for deduplication, the replica_label would indicate which metrics are deduplicated if those have same labels. All sources would return all of the matched metrics to the Query component, then doing deduplication dependent on the replica_label before backing result to user.

You can join the slack channel to ask question, you might get a quick response.


Update sttp:async-http-client-backend-future, ... to 1.6.2

Updates

com.softwaremill.sttp:async-http-client-backend-future
com.softwaremill.sttp:circe
com.softwaremill.sttp:core

from 1.6.1 to 1.6.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "com.softwaremill.sttp" }]

labels: semver-patch

Coverage remained the same at 80.46% when pulling a0a5b4306b9400dbcdab15882ad71b467b579523 on scala-steward:update/async-http-client-backend-future-1.6.2 into 129d46ccc79e822c6b29aac88d7aa9edec6d09b6 on hntd187:master.


AttributeError: 'dict' object has no attribute 'size'

Currently, if we try to use the summary or summary_string functions with modules that output a dictionary (or contain submodules that output dictionary, we get the following error:
    def hook(module, input, output):
        class_name = str(module.__class__).split(".")[-1].split("'")[0]
        module_idx = len(summary)

        m_key = "%s-%i" % (class_name, module_idx + 1)
        summary[m_key] = OrderedDict()
        summary[m_key]["input_shape"] = list(input[0].size())
        summary[m_key]["input_shape"][0] = batch_size
        if isinstance(output, (list, tuple)):
            summary[m_key]["output_shape"] = [
                [-1] + list(o.size())[1:] for o in output
            ]
        else:
>           summary[m_key]["output_shape"] = list(output.size())
E           AttributeError: 'dict' object has no attribute 'size'

It would be useful if we could support running modules that output a dictionary.

@nathanpainchaud hi,
The feature you added is really helpful and meets my use case. But I encountered another error
Traceback (most recent call last):
  File "XXX.py", line 442, in <module>
    summary(model, input_size=(1, 28, 28))
  File "/home/liuzhian/anaconda3/envs/pt1.5/lib/python3.6/site-packages/torchsummary/torchsummary.py", line 13, in summary
    model, input_size, batch_size, device, dtypes)
  File "/home/liuzhian/anaconda3/envs/pt1.5/lib/python3.6/site-packages/torchsummary/torchsummary.py", line 88, in summary_string
    total_output += np.prod(summary[layer]["output_shape"])
  File "<__array_function__ internals>", line 6, in prod
  File "/home/liuzhian/anaconda3/envs/pt1.5/lib/python3.6/site-packages/numpy/core/fromnumeric.py", line 3000, in prod
    keepdims=keepdims, initial=initial, where=where)
  File "/home/liuzhian/anaconda3/envs/pt1.5/lib/python3.6/site-packages/numpy/core/fromnumeric.py", line 87, in _wrapreduction
    return ufunc.reduce(obj, axis, dtype, out, **passkwargs)
TypeError: can't multiply sequence by non-int of type 'list'

Process finished with exit code 1

It seems that the bug was triggered by the line   total_output += np.prod(summary[layer]["output_shape"]). I am not very clear on how to fix that, could you provide some advice?

@LiUzHiAn I'm not really sure what version of the code you're running, but it doesn't seem to be the version from the PR I opened (or master for that matter). I think, you identified the line where the error occurs correctly, but your stack message indicates it's at line 88. However, this code can be found at line 94 on master, and has been outright replaced by lines 97-102 in my PR.
Because of that, I suspect something is up with your version of the torchsummary package installed in your environment, and I'd make sure you have installed the version from my PR. You should be able to do this easily with pip:
pip install git+https://github.com/nathanpainchaud/pytorch-summary.git@fix/layer_dict_output

@nathanpainchaud  Thanks for your help. It works well.

Oof it seems like your fork hosting the fix no longer exists, any chance it got migrated somewhere? @nathanpainchaud


Fix some error returns without unlocks.

When looking at the last lock issues, I noticed some returns missing unlocks.
PR Checklist

[ ] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
[ ] All new changes are covered by tests
[ ] If GraphQL schema is changed, make generate has been run
[ ] If collectsub protobuf has been changed, make proto has been run
[ ] All CI checks are passing (tests and formatting)
[ ] All dependent PRs have already been merged

This LGTMs but I'm wondering if we can fix this better by having defer for the unlock?

All the verbs and single-level noun ingests work with defer, but the nested nouns (pkg/src/vuln) have more complex logic. If each stage (type/ns/name/version) were put in their own function that could work.


Class 'SkinSkinny' not found in /home/usr/public_html/wiki/skins/booty/base/Skin.php on line 6

This should be fixed in the latest release.


[feature][npm] Generate SBOM for npm

This could be enabled thru a sbom-generate: true and sbom-format: xxx options. I think a scan of the package.json would work, although I'm not 100% sure if additional deps could be pulled in thru the script...
A larger question we need to answer before doing that is how we attest to the SBOM: thru a dedicated provenance, thru a new predicateType, thru byproduct of the existing provenance.

See https://github.com/npm/rfcs/pull/714
Presumably this is primarily useful for an end-user application, since it can be autogenerated at any time from a lockfile and node_modules directory?

Correct, only for end applications. Thanks for the link, we'll take a look.


[HybridApp] Launch the NewDot experience on HybridApp for new sign-ups on native mobile

Problem
Coming from this thread and this one.
The goal is to put 100% of new sign-ups through NewDot with the August release. Plans are a-foot with the new home page on expensify.com to redirect those sign-ups to new.expensify.com. A large portion of sign-ups come from the native mobile app though, so we'll be sending all of those to the OldDot experience on HybridApp, as the new home page logic doesn't cover them.
In order to not miss out on that large population of new sign-ups on native mobile, we want to load the newDot experience in HybridApp for them.
Solution
We'll need to either pass the shouldSetClassicRedirectNVP param from Mobile, or default to setting it on the backend with some additional handling for the new web landing page logic. The first solution is simpler but requires a Hybrid App deploy.
Note: I don't know how closely correlated this is with the other issue Jules, like if we need to hold on it or if SWM can work on this issue, but wanted to make sure we have an issue for it to verify as you mentioned in the thread.
CC: @AndrewGable

Focusing on other hybrid tasks

We're still rolling out to existing installs before putting this in place, Melv.

Still not being picked up

We shouldn't be that far off being able to get this one in place, Melv.

I made a web PR, but we are showing the "Welcome" modal via completedHybridAppOnboarding.
I am going to see how we can hide this modal for new users going forward:
https://github.com/user-attachments/assets/28b22535-9757-4bfd-8efb-67cae6d82f1a

Ok I got this working with a small auth change 🎉
https://github.com/user-attachments/assets/f254c92f-c0f9-4f25-97b7-2404d0065310
I need to write some tests on Monday, but feel free to review the changes @Julesssss

FYI auth PR was reverted

Both PRs merged, awaiting deployment and testing.

We ran into some issues during testing this, but have resolved them in the latest TestFlight. We will need another production deploy in order to start rolling this out to users.

Thread this week, here.

I think hopefully one more releaseœ

Here's the 'final' release: https://github.com/Expensify/Expensify/issues/442751

@AndrewGable we can release the beta now, right? We fixed the remaining NewDot bugs on 9.0.58-2 didn't we: https://github.com/Expensify/Expensify/issues/442751

I believe we can, do we want to do one last test before turning it on?

I just downloaded the iOS app from the production app store, and the receipt scanning thumbnail doesn't go blank anymore on this version:
https://github.com/user-attachments/assets/cf989b1e-7399-488c-bf4c-544b7cc3ef8e
My trj.chat domain is on the beta if anyone wants to create an account with<EMAIL_ADDRESS>to test.

I think we are really close here but @Julesssss has been leading this recently

I'm struggling to find the thread, but we discussed with @trjExpensify last week and planned to hold on the 'redirect admins back to OldApp when they indicate they have 11+ member workspaces' changes.

This one. Issue here.

@Julesssss @AndrewGable just confirming the plan of action for the final steps here.

Merge & Deploy @mateuuszzzzz PR.
* the hybridAppRedirect beta to put all new sign-ups in the NewDot experience on sign-up.

@trjExpensify sounds good. I'm not sure when I'll be able to find time to verify this though. Were you planning to ship ASAP?

Yeah, with the NewDot app listing deprecated looking to ship it ASAP.


FreeStyle Project Plugin

Repository URL
https://github.com/slide/freestyle-project
New Repository Name
freestyle-project-plugin
Description
This is a breakout of the FreeStyle project from Jenkins into a plugin.
GitHub users to have commit permission
@slide
Jenkins project users to have release permission
slide_o_mix
Issue tracker
Jira

Security audit, information and commands
The security team is auditing all the hosting requests, to ensure a better security by default.
This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.
Commands
The bot will parse all comments, and it will check if any line start with a command.
Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:.
	It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.31.144)

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

/hosting re-check

@jglick any thoughts on this?

@core should be co-maintainers IMO.

Not sure if the checks will handle that but can be added at merge time

/hosting host

I will follow-up with a PR to core to make the plugin detached.

/hosting host

/hosting host

https://github.com/slide/freestyle-project/blob/8e20b062fc37a0213c154475016cf2292f7bcfad/src/main/resources/index.jelly#L3
My only concern is the impact on tests:

Core tests referring to FreeStyleProject seem to all be moved to the plugin? Or just selected ones, with jenkins/test/pom.xml to keep a test-scoped dep on the plugin (as it already does for a few other plugins)?
jenkins-test-harness has some APIs referring to FreeStyleProject (like JenkinsRule.createProject()) which would not even compile without this plugin. We could proactively rewrite those all to e.g. createProject(Class) but there would be a lot of callers. JTH’s own tests could be left alone if it gets a test-scoped dep. Maybe we provisionally keep it in compile scope but optional?

/hosting host


added myself as contributor

seems like you accidentally erased almost complete code from staticfiles/js/crowdsource.routes.js.

Taking this PR out of the pending list.  Please fix the bugs/resolve conflicts and raise the new PR or move to the Milestone 2. Thank you.


Fix typos

/lgtm

Thanks for the fix, @yanghaichao12!
Preview: https://deploy-preview-13120--kubernetes-io-master-staging.netlify.com/docs/tasks/administer-cluster/out-of-resource/#evicting-end-user-pods
/approve


Extract library from framework integration

Hi,
currently you can only use this with the full symfony framework, although it would also be usable within a silex or cilex or any other application.
Would it be possible to extract the implementation from the framework integration which would have an own package like M6Web/amqp-core or something like that?
Kind regards
Thomas

that's a good idea :+1:

@omansour if you create a separate repository like M6Web/amqp-core then we can make an PR to both repos.
This way you keep rights of the package and we have core classes available :)

I have created a service provider for Silex using your bundle, i thought about extracting the core classes myself into a separate repo but then i would have to create a repo myself and it would not be under your namespace. So let me know when you extract the library and i can update the Provider with just the library as dependency not the entire bundle.

@mente I can do that :) https://github.com/M6Web/Amqp

I think this issue can be closed considering silex is dead and the few classes it provides does not warrant a separate package. Also the things it brings are profiler integration and events and both are very tied to symfony.
You could also delete the repo https://github.com/M6Web/Amqp

I agree with @Tobion
we should delete the M6Web/Amqp repository (it's still empty since its creation 4 years ago)... IMHO, if we want to keep maintaining our open source repositories efficiently, we should decrease their number whenever possible... and this one seems to be a golden opportunity 🙏
I don't have enough permissions to do so, so I'll leave @omansour doing it
anyway, I close this issue, feel free to open a new one if you think it's still relevant


Add GraphQL to mern-starter

add graphql, particularly redux would have to change for relay and relay the truth is not doing very well in applications isomorphic

Yup. We are thinking of adding GraphQL in a seperate repository.

they will with relay I imagine?

Yup! @carloscuatin  are you facing this issue https://hashnode.com/post/error-occurred-after-npm-run-build-in-mern-starter-cilb1tw7i004utw53j4rh3bww ? I'm not able to reproduce it.

yes, i'm reproduce in windows

@carloscuatin @mayankchd I was able to successfully run tests in windows, only thing I noticed was spelling mistake so did a pr #91

@mayankchd 1+ for seperate repo :+1:

any news on the graphql support?
Is there another repo / fork that implements it yet?

We are planning to work on MERN v2 starting today. After that, we will work on the advanced version of MERN which will include graphql and redux saga.


add an example of streaming from a specific user

Thank you for this. Would a pull request to add a docstring to filter, etc. be worthwhile?

A suggestion for this pull request. Instead of this advice:

An easy way to find a single ID is to use one of the many conversion websites: search for 'what is my twitter ID'.

-- How about reminding the user that the API object has access to the get_user method?
client = myStream.api
client.auth = myStream.auth
userid = client.get_user('ev').id

didn't know it existed.
Also, noticed on my raspberry pi (don't know version at this moment) that
the id needs to be a string not an integer.
What is the current behaviour?
On 2 January 2017 at 19:14, Dan Nguyen<EMAIL_ADDRESS>wrote:

A suggestion for this pull request. Instead of this advice:
An easy way to find a single ID is to use one of the many conversion
websites: search for 'what is my twitter ID'.
-- How about reminding the user that the API object has access to the
get_user method?
client = myStream.api
client.auth = myStream.auth
userid = client.get_user('ev').id
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tweepy/tweepy/pull/827#issuecomment-270004433, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAmtbMx7WaOE54GLC2EQp3lZR-3K7wXyks5rOT5vgaJpZM4LVerj
.

--
Matthew Venn
web mattvenn.net twitter @matthewvenn https://twitter.com/matthewvenn

The user object has an id_str attribute:
> userid = client.get_user('tweepy').id_str
'14452478'

@mattvenn I made a separate issue for how the StreamListener.filter method breaks when the id is passed in as integer: https://github.com/tweepy/tweepy/issues/829
My comment here was meant to suggest that there was a programmatic, automatable way to derive a user's ID without having to refer to a third-party conversion website. Any such website itself uses the same API functionality to get user ID from a screen name, anyway. Might as well cut out the middleman.

OK, happy to include that. Should I do a new commit & pull request or should this one somehow be reverted first?

The example has been corrected with https://github.com/tweepy/tweepy/commit/5df139cefff497d965d5833f0b135805cabb47e4 (#855).


Consider changing default value of withAuthenticateSslClients to false

I wanted to run a littleproxy instance with SSL enabled. I had used the withSslEngineSource API in the bootstrap for this. When I used my client to talk to this proxy, I got an SSL error (javax.net.ssl.SSLHandshakeException: null cert chain). It was not obvious that SSL client authentication was enabled and that the proxy was expecting the client certificates. It took me sometime to figure this out.
I believe that the default value of withAuthenticateSslClients should be changed to false because I guess disabling SSL client auth would be the more common scenario. But I could be wrong. Another solution is to update the method documentation of withSslEngineSource to mention that SSL client authentication is enabled by default (with a note to see withAuthenticateSslClients method).
Please do let me know which is the better solution and I can raise a PR with the changes.

I'd be kind of curious to hear from people who actually use this feature (I haven't). But documentation update + change to not authenticate by default seems entirely reasonable to me.

Let me add a post on the littleproxy Google group asking for any comments on this change.
If we decide to change the default value to false, then how do we handle upgrades? Users who have it enabled already by default (without calling withAuthenticateSslClients()) need to now make a change in their applications to enable it. Is this okay? Or do make any guarantees about forward compatibility? :)


[Request] Adding script support

I use Osiris is my main cheat for 10 months and I really like it, but something is missing.
I think script support would make the cheat much better and the people who use the cheat, can code thier own scripts and publish them for everyone to use.
Sorry for my bad english.

Osiris is open-source, people would add something they want anyway. Script would be useful if it wasn't open source tbh.

Three reasons why this is not a good idea:

Osiris is open source anyone can download a version of the source and edit it, then publish it to Pull Requests.
Lua/JS degrades performance.

Its easy to implement Lua.
lua = thats what you need

except why do people want lua, its literally open source?

except why do people want lua, its literally open source?

Lua is open source, you can find on github osiris with lua implemented.
@DoomFishWasTaken
Btw: can u make the rainbow color on 2 colors? Like i previous wanted..

I think the main benefit is an easier learning curve to coding in LUA vs osiris.

lua is easier to learn than c++ and it's easier to use

I totaly agree that it is not that important to have lua support, but I do not know how to code cheats and dont know c++. And I want to add my own things learn how to code. I think many people can agree with me that scripting for a cheat is easier than modifing a cheat. And scripters can always use the latest version of osiris. (sry for bad english)

And I think it would make it more comunnity driven and people could learn something than rather always asking to implement something.

-1

@AntonDoil
float fade(float step, float globaltime, float min, float max)
{
    float colorVar = std::sin(globaltime * step);
    return std::clamp(colorVar, min, min);
}

this should do :)


The package must be rebuilt with conda-build > 2.0.

Hi there, when i follow the install scripts:
Install the Conda

#download the miniconda
wget https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh -P tools/
#install the miniconda
bash tools/Miniconda3-latest-Linux-x86_64.sh -b
#conda init
$HOME/miniconda3/bin/conda init
#use the "bash" command to make the conda environment works
bash
#create a conda virtual environment
conda create -y -p tools/venv python=3.7
...

the conda create -y -p tools/venv python=3.7 complains:
PaddingError: Placeholder of length '33' too short in package /home/berg/PaddleSpeech/tools/venv/python.pdb.
The package must be rebuilt with conda-build > 2.0.
I'm working in the ubuntu-18.04.6, with CUDA and cuDNN installed.
It seems that the something is wrong with miniconda, or something i've missed.

You can try updating conda-build by using:
conda update conda
conda update conda-build
If it still does not work, you can use:
conda create -n paddlespeech python=3.7
conda activate paddlespeech

I have use the ubuntu18.04 docker with CUDA and cuDNN installed to reproduce your probelm. However, I can make the conda virtual environment without problems. Maybe you need to make sure the conda is installed correctly and try using the scripts above to solve the problem.

vim ~/.condarc
#use the following lines.
channels:
  - defaults
show_channel_urls: true
channel_alias: https://mirrors.tuna.tsinghua.edu.cn/anaconda
default_channels:
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/main
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/r
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/pro
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/msys2
custom_channels:
  conda-forge: https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud
  msys2: https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud
  bioconda: https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud
  menpo: https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud
  pytorch: https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud
  simpleitk: https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud

that works:)


Add link to Lancaster University guide

The Lancaster University guide to the micro:bit runtime is itself a valuable collection of documentation for the more advanced micro:bit user. Although not strictly a teaching resource, it is resource that teachers and users may both want to use and doesn't fit directly in any of the other categories. I've included it here as a single link to their documentation.

It may be worth considering whether it is more useful to link to individual articles on the Lancaster University documentation pages. Of particular note to me have been:

The Bluetooth Profile - includes link to the default *.hex file for resetting the micro:bit
MicroBitLightSensor - an explanation of how the display is used as a light sensor

Would be interested in thoughts on whether you prefer a single link to the site or multiple links to articles within the site.

Hi Bill,
Thanks for the contribution. At the moment the DAL documentation is linked on the C/C++ programming language entry, and I think we should avoid repeating links and instead have a single entry highlighting the different sections.
That being said, I think you are right in the fact that these docs contain a lot of important information that might get overlook if it stays where it currently sits, so we could probably make an exception here and have another entry (just one though), or alternatively change the C/C++ programming link to the github repo or anything else appropriate.
It doesn't quite fit within the teaching resources section though, perhaps it will be better to place it under Articles. If you move it there, you could also add a short description ([Title](link) - Description) with the highlights you've mentioned.

My bad, I hadn't spotted the duplicate link. I've had another browse of the documentation hosted there in an effort to find an appropriate target for a second link and I keep coming back to this quote on the Introduction page.

On these pages you will find guidance on how to start using the runtime in C/C++, summaries of all the components that make up the system and a full set of API documentation (the functions you can use to control the micro:bit).

The documentation is clearly targeted at C/C++. The fact that this includes useful descriptions of device components and API methods is a bonus. I'm coming back to the idea of sticking to the principle of only linking to sources once and, for this example, keeping the link in the 'Written Programming Languages' section.
I propose amending the pull request to remove the duplicate link and to call out these additional highlights as part of the description for your original link.

I think you are right, my main concern was that the Bluetooth page is probably the main source for the Bluetooth profile info (apart from Martin's blog, which is also linked in that page) and will most likely get overlooked. But, as you said, a mention could be added to the original description to highlight this. If in the future there are more requests to add it as an individual link, or more Bluetooth info is requested, then it can be reconsidered.

Looks good, thanks @billglover !


Update set output syntax

Problem
Update set output
Solution
Update
Notes

@itabdullahi - It appears I do not have permission to merge this. Do you think you could?


Bad owner or permissions on /root/.ssh/config

Having issues setting up with sshkey, Im getting this error when -o debug
Bad owner or permissions on /root/.ssh/config
Installed like:
sudo docker plugin install vieux/sshfs  DEBUG=1 sshkey.source=/home/usermedia/.ssh
Mounting:
sudo docker volume create -d vieux/sshfs -o cache_timeout=72000 -o attr_timeout=72000 -o auto_cache,reconnect -o IdentityFile=/home/usermedia/.ssh/private.pk -o sshcmd=remote@<IP_ADDRESS>:/remote/path pathname
Any ideas?

Facing the same problem here. Does anybody have a solution?


Sway does not register small mouse movements

Moving the mouse cursor very slowly either right or down will not cause the cursor to move.
However, it does work properly if you move the mouse slowly up or left.
I've tried it in X11 (using xf86-input-libinput) and in weston, and it works fine, so it's not a problem with my mouse or libinput.

https://github.com/Cloudef/wlc/issues/181


Draft: Feature/add imp sort

@MiguelRicardos Let me know when this is updated and ready for review


Main cleanup

Great stuff @damianmarti Thanks!!
Pushed a few tweaks and I think it's ready for a merge!


"Server error"

I'm trying out this package on Windows 10 with Sublime version 3144 (most recent dev release on Windows).
I've installed LSP via Package Control, and installed pyls via pip.
Whenever I execute any of the commands in the command palette, e.g. "Document Symbols", Sublime's status bar shows Server error1. Nothing appears in the diagnostics box (100% empty, there's no whitespace or anything), nor does anything interesting show up in Sublime's own console3. Apart from this, I haven't changed anything to the default configuration, and the server does seem to start properly2.
1:  (sorry for the poor contrast, this theme's contrast is bad.)
2:
3: Sublime's console output:
DPI scale: 1
startup, version: 3144 windows x64 channel: dev
executable: /C/Program Files/Sublime Text 3/sublime_text.exe
working dir: /C/Program Files/Sublime Text 3
packages path: /C/Users/.../AppData/Roaming/Sublime Text 3/Packages
state path: /C/Users/.../AppData/Roaming/Sublime Text 3/Local
zip path: /C/Program Files/Sublime Text 3/Packages
zip path: /C/Users/.../AppData/Roaming/Sublime Text 3/Installed Packages
ignored_packages: ["Vintage"]
pre session restore time: 0.120855
startup time: 0.164855
first paint time: 0.167855
[...]
reloading plugin LSP.main
[...]
plugins loaded
LSP: Config added: pyls (enabled)
LSP: Config added: clangd (enabled)
LSP: Config added: dotty (enabled)
LSP: Config added: reason (enabled)
LSP: Config added: rls (enabled)
LSP: Config added: golsp (enabled)
LSP: Config added: ocaml (enabled)
LSP: Config added: jsts (enabled)
Emmet: No need to update PyV8
Package Control: Skipping automatic upgrade, last run at 2017-09-19 00:11:00, next run at 2017-09-19 01:11:00 or after

Thanks for the complete report!
You will get a lot more logging by adding "log_debug": True to your LSP Settings.
Could you share your findings (perhaps more logs if the fix isn't obvious)?

Turning on "log_stderror": true gave me this
LSP: (stderr):  b'2017-09-19 14:40:29,567 UTC - WARNING - pyls.config - Path c:\\Users\\...\\Desktop\\test.py not in s:\\somerandomfolder\\somerandomnestedfolder
By adding the test.py to the project folder, it started working.
So I think the overall problem is that when a .py (or whatever?) file is outside its sublime project folder, LSP won't work.

Correct!
I'm glad you sorted this out. Would changing the LSP status bar text to "file outside workspace" provide a valuable hint, or would you expect to read about this in the documentation?

I'd expect the diagnostics to say something at least, or make the "server error" message refer to the diagnostics. That would make a lot more sense to me.
Or perhaps a message in the diagnostics panel saying
"If this is empty, and you're still experiencing errors, turn on the "..._debug" option in the package options" or something among those lines.

Closing in favour of #115, thanks for the feedback!


Stopping Apps On Android 4.4.2 Can Silently Kill Related Background Services

Hi,
I face with the same issue on my phone with android 4.4.2.
I've found out that it's the android issue.
The details: [link] (http://www.androidpolice.com/2014/03/07/bug-watch-stopping-apps-on-android-4-4-2-can-silently-kill-related-background-services-a-fix-is-on-the-way/)
Will be good to implement the restarting of service using the [AlarmManger] (http://developer.android.com/reference/android/app/AlarmManager.html)
Thanks.

Hi.
I have never coded on android. But I try to improve this one as in example.
Now service is restarted automatically if it was killed. I checked it on my device with android 4.4.2.
diff --git a/traccar-client/src/main/java/org/traccar/client/AutostartReceiver.java b/traccar-client/src/main/java/org/traccar/client/AutostartReceiver.java
index e9c0011..a15fde9 100644
--- a/traccar-client/src/main/java/org/traccar/client/AutostartReceiver.java
+++ b/traccar-client/src/main/java/org/traccar/client/AutostartReceiver.java
@@ -20,6 +20,9 @@ import android.content.Context;
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;
+import android.os.PowerManager;
+import android.app.AlarmManager;
+import android.app.PendingIntent;

 public class AutostartReceiver extends BroadcastReceiver {

@@ -27,10 +30,33 @@ public class AutostartReceiver extends BroadcastReceiver {

     @Override
     public void onReceive(Context context, Intent intent) {
+
+		PowerManager pm = (PowerManager) context.getSystemService(Context.POWER_SERVICE);
+		PowerManager.WakeLock wl = pm.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, "");
+		wl.acquire();
+
     	SharedPreferences sharedPreferences = PreferenceManager.getDefaultSharedPreferences(context);
     	if (sharedPreferences.getBoolean(TraccarActivity.KEY_STATUS, false)) {
     		context.startService(new Intent(context, TraccarService.class));
     	}
+
+		wl.release();
     }

+	public void SetAlarm(Context context)
+	{
+		AlarmManager am =( AlarmManager)context.getSystemService(Context.ALARM_SERVICE);
+		Intent i = new Intent(context, AutostartReceiver.class);
+		PendingIntent pi = PendingIntent.getBroadcast(context, 0, i, 0);
+		am.setRepeating(AlarmManager.RTC_WAKEUP, System.currentTimeMillis(), 1000 * 60 * 1, pi); // Millisec * Second * Minute
+	}
+
+	public void CancelAlarm(Context context)
+	{
+		Intent intent = new Intent(context, AutostartReceiver.class);
+		PendingIntent sender = PendingIntent.getBroadcast(context, 0, intent, 0);
+		AlarmManager alarmManager = (AlarmManager) context.getSystemService(Context.ALARM_SERVICE);
+		alarmManager.cancel(sender);
+	}
 }
+
diff --git a/traccar-client/src/main/java/org/traccar/client/TraccarService.java b/traccar-client/src/main/java/org/traccar/client/TraccarService.java
index afb007c..df36b10 100644
--- a/traccar-client/src/main/java/org/traccar/client/TraccarService.java
+++ b/traccar-client/src/main/java/org/traccar/client/TraccarService.java
@@ -51,6 +51,8 @@ public class TraccarService extends Service {

     private WakeLock wakeLock;

+    AutostartReceiver alarm = new AutostartReceiver();
+
     @Override
     public void onCreate() {
         StatusActivity.addMessage(getString(R.string.status_service_create));
@@ -82,10 +84,24 @@ public class TraccarService extends Service {
     }

     @Override
+    public void onStart(Intent intent, int startId)
+    {
+        alarm.SetAlarm(this);
+    }
+
+    @Override
+    public int onStartCommand(Intent intent, int flags, int startId)
+    {
+        alarm.SetAlarm(this);
+        return START_STICKY;
+    }
+
+    @Override
     public IBinder onBind(Intent intent) {
         return null;
     }

+
     @Override
     public void onDestroy() {
         StatusActivity.addMessage(getString(R.string.status_service_destroy));

could you please copy paste it, without the + signs, just the code?

jamejo
could you please copy paste it, without the + signs, just the code?

It is a diff between my changes and master branch.
Copy these changes in file.patch.
Clone master branch.
And apply this patch: git apply file.patch

I have added START_STICKY to the service (https://github.com/tananaev/traccar-client-android/commit/fc83e7525a67fb650d8b5ed426229836f46d5ddd). I think it should fix the problem without the need for Alarms.
@shuricksumy, what do you think?

Hi.
I am not sure that START_STICKY will help to restart service on android 4.4.2.
At first I tried to use just START_STICKY, but service was not restarted on my device.
I am ready to check new code.
But also I want to add that using of Alarms very useful, I use modified traccar-client-android for several days and service is always running. I used task killer which are very popular now. I over used memory on my device using browsers and other huge apps. But service is restarted every time and it worked well.

Hi,
START_STICKY should be the way to solve the issue. But as explained in the link in the first post of this issue, there seems to be a bug and the suggested workaround is to use AlarmManager.
But even if the START_STICKY worked, don't you think that AlarmManager should be used to schedule the position polling ? You are currently using a wakelock an this quite bad for the battery drain. As already suggested by mhdyousif    here  and [ here ] (https://github.com/tananaev/traccar-client-android/issues/11) , I think AlarmManager is a better approach.
Redge.
[See also ] (http://codereply.com/answer/509z3x/whats-best-alarmmanager-handlerwakelock.html)

I think using alarm manager for position updates is a really good idea. Furthermore, I want to rely on standard location update mechanism plus use AlarmManager functionality for mixed provider. I want to implement it over the weekend.
As for using alarm manager to keep service awake, I'm not so sure. I think STICKY service should be enough. Also, in future looks like we would have to use foreground service (see app standby mode in Android M). Any thoughts?
I have one question about your patch. Why do we need wake lock in AutostartReceiver?
As for HTTP protocol, it's already implemented. I have made a lot of changes in the code over the last few days.

I use wake lock in AutostartReceiver because it was in the example of using AlarmManager. I am not good in development for android, so I tried do it using this example.
As for using only STICKY, of course it will be enough. But some devices with issue on android 4.4.2 will have problem with restarting service.(START_STICKY does not work on Android KitKat)
Thanks for your work.
I will try fix this problem for my device using AlarmManager.

I have implemented foreground service option. Please try new version of Traccar Client (3.3) and see if it solves the problem with Android KitKat.

I installed latest version of traccar-client-android on my device (foreground service option was enabled).

Now service is not destroyed if I clean latest apps from memory using standard method of android interface.
Now service is not destroyed if there is not free memory on your device and android try get some free memory by killing old processes.
Once I found that this process was killed. But I tried to reproduce this again and couldn't do it.
Service is not restarted if I destroy it using taskkiller. So we should add traccar-client-android as exception for popular ramcleaner and speedup apps.

Anton, thanks for your work.

Thanks for feedback. I guess we leave it as a foreground service. In future I will probably force foreground option (at least on Android M).


Remove mapview from make_receiver_push_summary.qmd

Edits needed (similar to those in make_tag_push_summary.qmd:

https://github.com/mhpob/otndo/blob/dev/inst/qmd_template/make_receiver_push_summary.qmd#L130-L142
https://github.com/mhpob/otndo/blob/dev/inst/qmd_template/make_receiver_push_summary.qmd#L31

leaflet_graph will likely need to be edited with an if/else in order to handle receiver data.

@joyliujoyliu @jdpye


Clean up and add OCaml lexer.

(Original issue 188 created by None on 2007-02-02T22:43:56+00:00)
I've got an OCaml lexer that I hacked up just now (you guys have a great system), but I'm not sure if it meets code standards.  It's attached and working on my test code [http://www.personal-api.com/train/2007/feb/02/ocaml-insertion-sort/ at my own site].
Feel free to take it and use it.
Reported by guest

(Original issue was assigned to gbrandl)
(Original issue 188 last updated on 2007-02-03T20:19:51+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2007-02-03T20:19:51+00:00)
Thanks, I patched it up and integrated it in the latest SVN revision.


Relationships requires full model namespace for the referenced model

Consider following relationship between two models:
<?php namespace App\Models\Book;
class Page extends Model {}
//...

<?php namespace App\Models\Book;
class Book extends Model {
        public function pages() {
                 return $this->hasMany('Page'); // Not working, but I really want to be able to declare it like this.
                 return $this->hasMany('App\Models\Book\Page'); // Working
        }
}

I think it is fair to expect that models that do share namespace should not be expected to explicitly state the namespace when declaring relationships.
The related model instantiation happens here:
https://github.com/laravel/framework/blob/f377f9b9f2e952bd217ec9987cda5d039bf50dd5/src/Illuminate/Database/Eloquent/Concerns/HasRelationships.php#L656
To me it appears that the context namespace is not taken into consideration, the method attempts to instantiate the model based solely on the provided name;
Something in the lines of:
    protected function newRelatedInstance($class)
    {
        if(strpos($class, '\\') === false) $class = (new \ReflectionObject($this))->getNamespaceName().'\\'.$class;
        return tap(new $class, function ($instance) {
            if (! $instance->getConnectionName()) {
                $instance->setConnection($this->connection);
            }
        });
    }

Appears to be addressing this at some extent. However I have been away from php for years, I am not really sure if by changing this protected method I am not braking some other crucial functionality.  Also if somebody can share what is the proper way to override framework internals, as apparently changing the file directly is not going to stick.

You just need to do it like this:
return $this->hasMany(Page::class);

Hey, thanks for input, that was helpful, it makes the declaration shorter. Its pity the framework cannot use this internally. I guess the reflection thing I tried is considered heavy in comparison with the ::class  keyword.


Add Property changes to ChangeBlockEvent.Modify

Currently the only thing stopping ChangeBlockEvent.Modify from being used as a perfect way to detect redstone changes is the absence of property changes calling the event. As 'PoweredProperty' is a property, and not a data value, it does not call the event.

@me4502 @bloodmc has a redstone tracking branch that does add the event hooks for redstone.

Redstone tracking is now in master.


[engineering] Enable StyleCop for C# BotProject

Need to enable StyleCop for C#, especially to enforce the Copyright headers.

See botbuilder-dotnet conventions


Distro version improvements

The new validator will in addition to [ArchLinux] and [Debian] be used in [Fedora] and [Ubuntu].

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @scop!

  Generated by :no_entry_sign: dangerJS against 404e522058915f0cf508e54c83e6a5074716ae98


Please explain ledc_cb_register‘s callback return bool mean in LEDC controller. (IDFGH-8647)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
When I try to use the ledc example ledc_fade with ESP32C3 and IDF v4.4.2, I find the ISR function:
static bool cb_ledc_fade_end_event(const ledc_cb_param_t *param, void *user_arg) {
    portBASE_TYPE taskAwoken = pdFALSE;
    if (param->event == LEDC_FADE_END_EVT) {
        SemaphoreHandle_t counting_sem = (SemaphoreHandle_t)user_arg;
        xSemaphoreGiveFromISR(counting_sem, &taskAwoken);
    return (taskAwoken == pdTRUE);
}

I don't know return return (taskAwoken == pdTRUE); mean. Exactly, I don't know return true or false will happen what.
Some information I searched:
https://docs.espressif.com/projects/esp-idf/zh_CN/v4.4.2/esp32c3/api-reference/peripherals/ledc.html
https://docs.espressif.com/projects/esp-idf/zh_CN/v5.0-beta1/esp32c3/api-reference/peripherals/ledc.html

The return value indicates whether a high-priority task has been woken up by the callback function. We will explain this in the doc, thanks for reporting!

Thank you. I think if only use return taskAwoken; can let us understand the return mean.


Synchrnoize with 18.5.

Main changes

More meta attribute support
use overrides
Fix bug with empty grids early-terminating the enlargeBoundingBox.

Note this is just a reference implementation.

might be worth adding release notes but I'll leave it down to you!


Option unescape_strings can produce invalid string literals making JS invalid/uninterpretable

Description
Option unescape_strings can produce invalid string literals making JS invalid/uninterpretable
Input
The code looked like this before beautification:
        function () {
          i.exports = "\t\n\x0B\f\r                　\u2028\u2029\ufeff"
        }()

Expected Output
The code should have looked like this after beautification:
code that does not contain invalid string literals
Actual Output
The  code actually looked like this after beautification:
        function () {
          i.exports = "\t\n\x0B\f\r

"
        }()

Steps to Reproduce
Environment
OS: Firefox/Win10
Settings
{
        "unescape_strings": true,
}

I'm pretty sure we already look for some of those chars when santizing newlines. The might be an ordering issue when we need to unescape before/after that search.
Or maybe we need to have a list of escape chars that are unsafe to convert and either skip or convert them back.

So basically after the beautification code should look like this?
function () {
i.exports = "\t\n\x0B\f-\u2028\u2029\ufeff"
}()

So basically what i understand is the proposed fix is to modify the unescaping logic to:
-Decode the \xNN sequences
-Check if the resulting string has matching opening/closing quotes
-Only perform the unescaping if it results in a valid string literal
This ensures only valid JavaScript is produced.
would like to work on it if its still availlable. I am open to suggestions (i am a beginner at os cont.).
Thank You.

Hey is the issue resolved? I am new to open source and found out that this would be a good first issue to work on.

well i would say that is rather easy to check:

is the issue still open -> yes
did another person already work on it -> maybe, Aryann15 said they would. you can easily check if the forked this repo and started to commit work and or opened a merge request

@sirati can you tell the name of file where we have to make changes? @bitwiseman


Several issues trying to setup

(Disclaimer: this is my first time trying to use c++ with react-native)
Hi, i'm trying to setup my environment, so far i managed to make a successful ./gradlew bundleRelease. I'm using clion and I'm trying to load the CMakeLists so that i can get some intellisense / code completion. But I'm getting several errors. The first one i get without touching anything is:
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LOG_LIB
    linked by target "cpp" in directory /home/dominick/Projects/testing/android
REACT_NATIVE_JNI_LIB
    linked by target "cpp" in directory /home/dominick/Projects/testing/android

CMake Error at CMakeLists.txt:37 (add_library):
  Cannot find source file:

    ../../react-native/ReactCommon/jsi/jsi/jsi.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
[Finished]

if i change the path to jsi to
../node-modules/react-native[...]
i get:
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LOG_LIB
    linked by target "cpp" in directory /home/dominick/Projects/testing/android
REACT_NATIVE_JNI_LIB
    linked by target "cpp" in directory /home/dominick/Projects/testing/android

Any help would be greatly appreciated.

Nevermind, please ignore me. I just realized clion doesn't support android. Sorry.


Wrong schema versions in com.snowplowanalytics.snowplow.storage/redshift_config

Hi,
In com.snowplowanalytics.snowplow.storage/redshift_config, there are wrong increments of schema versions which do not respect the SchemaVer.
1) 2-0-0 to 2-1-0
This change is fully backward compatible because:

Existing password field is expanded from "type": "string" to "type": ["string", "object"]
A new key sshTunnel is added but additionalProperties was False

So nothing breaks backward compatibility and the proper new schema version should be 2-0-1, not 2-1-0
2) 3-0-0 to 4-0-0
This change is fully backward compatible because:

A new key blacklistTabular is added but  additionalProperties was False

So nothing breaks backward compatibility and the proper new schema version should be 3-0-1, not 4-0-0

Closing as per https://github.com/snowplow/iglu-central/issues/1072#issuecomment-674085232


Fix Exception

Thank you for your pr.
But the idea here is to display an error that contains the call stack, not to throw it.


Update jwt_verify_lib to 2019-12-20

Cherrypick https://github.com/envoyproxy/envoy/pull/9441 for https://github.com/istio/istio/issues/19424
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

please have someone that works with Envoy review this, I have no knowledge of if this is safe/proper

@qiwzhang @jmarantz Could you review this PR? I want to cherrypick this upstream fix for the upcoming Istio 1.4.3 in next week, thank you.

I meant like @lizan or @PiotrSikora who work on Istio and are familiar with our branching/cherrypick process

I meant like @lizan or @PiotrSikora who work on Istio and are familiar with our branching/cherrypick process

@lizan @PiotrSikora could you help take a quick look at this PR? This should be quite safe because the jwt_verify_lib is only used by JWT filer and we have also updated it in the master branch. Thank you.


null-safe but depends on non-null-safe esc_pos_utils

@andrey-ushakov
First, thank you for releasing the null-safe package for esc_pos_bluetooth.
However, is depends on the non-null-safe utils - esc_pos_utils: ^0.3.6. Can this dependency be chanted to null safe esc_pos_utils: ^1.1.0

I've just published the latest version 0.4.0. This should resolve the issue. Don't hesitate to reopen the issue if need.


Feat: Multiple texture support

Support multiple texture
Fix hack texture problem that fragment sub mesh not share one default material.

Duplicated #85


Do I remove a js directory?

Do I remove a js directory after redpen command is exited?
redpen command create a js directory every time.
https://github.com/redpen-cc/redpen/blob/v1.4.0/redpen-core/src/main/java/cc/redpen/validator/JavaScriptValidator.java#L69
$ ls
$ redpen -v
1.4.0
$ redpen -c /path/to/redpen-conf-en.xml /path/to/test.txt
...some output...
$ ls
js

Thank you a lot for creating the issue @karronoli!  It looks like a bug which create a js directory int the current directory. I succeeded to reproduce the issue.

Actually this is an expected behavior.
"js" is the directory where you put JavaScript based validators.
And JavaScriptValidator is enabled by default from RedPen v1.4.
But I assume that it's confusing. I'll change the behavior to just put a info level log message that reports the directory is missing.

Fixed in PR#499
https://github.com/redpen-cc/redpen/pull/499

Fixed with #499.


Structured data for degree qualifications

What's the need around knowing when they started their degree?

Can this entry indicate where the data comes from?
My degree isn't there:

When no suggestions are found, I don't think it will always be clear that a user can continue with their free text, rather than having to make a selection.
I wonder if the empty state text in the autocomplete could be more helpful.

How would you enter two different undergraduate degrees? (A friend of mine took a 3yr undergrad computer science course at Cambridge, followed by a 3yr undergrad law course at UCL)

Suggestion: We ask if degree is undergrad or postgrad when adding, rather than inferring. We add validation if they don't add an undergrad degree when marking section as complete/reviewing.

How would you enter two different undergraduate degrees? (A friend of mine took a 3yr undergrad computer science course at Cambridge, followed by a 3yr undergrad law course at UCL)

That’s possible; it’s just that we force the first degree to be an undergraduate degree (by limiting the degree type options, and using ‘undergraduate’ in the title). Subsequent degrees can be undergraduate too. Do you think that’s not clear?

Suggestion: We ask if degree is undergrad or postgrad when adding, rather than inferring. We add validation if they don't add an undergrad degree when marking section as complete/reviewing.

I wondered about that, but my thought that degree type was a strong enough indicator. I guess that falls apart if your degree type is not shown and/or you are able to enter your own type.

When no suggestions are found, I don't think it will always be clear that a user can continue with their free text, rather than having to make a selection.
I wonder if the empty state text in the autocomplete could be more helpful.

I can try this, but I think providing text when there are no options prevents another answer being submitted. But I may be wrong.

my thought that degree type was a strong enough indicator

How do you infer if a Masters is undergrad or postgrad?

Can this entry indicate where the data comes from (or will come from)?

Links to HESA datasets are in the related items. Maybe these links should be contextual, too?

MEng is is the dataset: https://www.hesa.ac.uk/collection/c20053/e/degtype (Code 211), and in the data in the prototype.
I wonder if the autocomplete is case sensitive?

Perhaps we shouldn’t limit the type options for the first degree? Or only omit doctorates?


Introduces testnet configuration section

Just started using this bot and on first try I didn't figured out how to work with the testnet. I was not able to connect to the testnet using my testnet API-Keys without making these changes. I really don't know how you worked with the bot on the testnet before. Let me know if my changes are okay or if there is a different way. But at least updating the python-binance dependency should be a good change.

We removed testnet and its API keys, and are using just mainnet even for testing. We will not revert back to old version with the limited test net.

Okay, didn't know that. Would be nice to have an updated documentation for that.

I don't see anything in the current docs that references test net or its API keys.
Maybe you could point it out to me so that we can correct it accordingly.

@ShogunMan I started trying the bot yesterday and was also confused about my testnet key not working.
There are still mentions of it in (at least) the main README.md and the FAQs.
The first link even has a link to the original blog post (which is how I ended up here) where it talks in detail how to set up testnet.
So yeah, it can be confusing and I tend to agree with @NiklasLehnfeld that perhaps a mention of testnet being unsupported would be beneficial (and I also agree based on past experience that it can be a pain in the rear end to work with, so I'm not surprised you guys removed it).
Hope that helps.

Thank, removed it now i hope :-)

Thanks @piscui for the explanation, that is exactly what I meant. And thanks @ShogunMan for the removal. Can only agree. Great work with this tool!


Update CameraActivity.java

Added test to speech feature for people with distorted eye sight.

@googlebot I signed it!

Hi Amit,
Thank you for your interest of contribution!
It is an image classification app. Adding text-to-speech may not be useful for everyone who uses image classification. So I suggest that you could keep it at your repo and use it for your own use case, instead of merging to TensorFlow examples. Thanks! :-)

Although thanks for your response 😊

can anyone tell me how to add text to speech in object detection?


[V2] handleChange should accept any value

🐛 Bug report
Current Behavior
I'm using Formik on React-native and  Typescript.
For example, I have only one field of type number:
type MyFieldValues = {
  val: number,
}

On input handleChange
formikProps.handleChange('val')(newVal as number);
Got this: Error:(100, 46) TS2345: Argument of type 'number' is not assignable to parameter of type 'string | ChangeEvent'.
Expected behavior
handleChange should accept any value type like setFieldValue does.
Your environment

Software
Version(s)

Formik
2.0.6

React
16.9.0

TypeScript
3.6.3

Browser

npm/Yarn

Operating System
Mac 10.15.1

What's the update on this bug?

Shouldn't this be fixed? I still use patch-package to handle this tiny bug.

I explain the resolution for this in depth here: https://github.com/formium/formik/issues/3013#issuecomment-766994432
Unfortunately, we need to upgrade TS to TS4, so this will probably be a major version update.

I explain the resolution for this in depth here: https://github.com/formium/formik/issues/3013#issuecomment-766994432
Unfortunately, we need to upgrade TS to TS4, so this will probably be a major version update.

The problem is not only types and typescript, but also functionally it only accepts strings or events. The types are actually correct, in that if you pass anything else, you run into this error: https://github.com/formium/formik/issues/1667 (dupes: https://github.com/formium/formik/issues/2942, https://github.com/formium/formik/issues/1973).
Here are some closed PR's that try to address the above issue:
https://github.com/formium/formik/pull/2305/files
https://github.com/formium/formik/pull/1669/files (https://github.com/formium/formik/pull/2255 was supposed to carry this on, but looks like the type part didn't make it)
https://github.com/formium/formik/pull/3039/files
Based on @johnrom 's comment here, it seems that setFieldValue should be used instead of handleChange? If that's true, then perhaps we just need a documentation update for the  migrating-v2 guide page.