[Meta]: Add usage example of nvim-tree

Category
Docs
Description
-- ~/.config/nvim/lua/init.lua

local   nvimtreemappings = require("nvim-tree.keymap").keymaps
local   keystodisable    = vim.tbl_map(function(e) return e.key end, nvimtreemappings)
require("nvim-tree").setup({
  ...
  on_attach = function(bufnr)
        -- Set up Legendary plugin keybindigns
        keymaps = vim.tbl_map(function(e)
            local entry = {}
            entry.mode  = "n"
            entry[1]    = e.key        -- Key
            if type(e.key) == "table" then entry[1] = e.key[1] end
            entry[2]    = e.callback
            entry.description = "Nvim-tree: " .. e.desc
            entry.opts = { buffer = bufnr, noremap = true }
            return entry
        end, nvimtreemappings)

        require("legendary").setup({
            keymaps = keymaps
        })
      end,
      remove_keymaps = keystodisable
      ...

https://user-images.githubusercontent.com/8136158/209453360-27d30933-94fa-42a0-8a39-f7ee64fb0c4d.mp4

Demo video. (CC BY 4.0). Note: the Nvim-tree: toggle is bound by Legendary separately.

The above demostrates integration with nvim-tree/nvim-tree.lua module.  Note: the said plugin should export a stable API, see related issue here:

https://github.com/nvim-tree/nvim-tree.lua/issues/1858

Hey there, this is awesome, thanks for filing the issue!
This may be better suited actually for #184, nvim-tree is probably a good candidate for a first one for a proof of concept.
I'm not sure exactly what they will look like, but I have a few ideas. The best idea I have currently is along the lines of:
Legendary.nvim must be loaded before other plugins. We have a set of plugins, or plugins can be provided by the other plugin itself, at legendary.plugins.[plugin name]. This way, plugins can be looked up dynamically; that is, if they wanted to, nvim-tree could provide its own legendary.nvim integration by adding lua/legendary/plugins/nvim_tree.lua in their repo, just for an example.
The plugin is just a plugin-specific script that must handle registering its keymaps, commands, autocmds, and functions. It may set up autocmds to do so on BufEnter for example, or it may call some custom logic to determine the correct buffer to attach to.
So for this example, and nvim-tree / legendary.nvim plugin would look like:
User's config:
require('legendary').setup({
  plugins = {
    nvim_tree = true,
  }
})

File: lua/legendary/plugins/nvim_tree.lua
vim.api.nvim_create_autocmd('FileType', {
  pattern = 'NvimTree',
  callback = function()
        local   nvimtreemappings = require("nvim-tree.keymap").keymaps
        local   keystodisable    = vim.tbl_map(function(e) return e.key end, nvimtreemappings)
        -- Set up Legendary plugin keybindigns
        local keymaps = vim.tbl_map(function(e)
            -- just set up a description-only keymap
            local entry = {}
            entry.mode  = "n"
            entry[1]    = e.key        -- Key
            if type(e.key) == "table" then entry[1] = e.key[1] end
            entry.description = "Nvim-tree: " .. e.desc
            entry.opts = { buffer = bufnr, noremap = true }
            return entry
        end, nvimtreemappings)
        require('legendary').keymaps(keymaps)
  end
})

cc @olimorris  for input

@mrjones2014 I would suggest to take a look at others nvim extensions that provide kind of extensions APIs to learn the best way, .e.g: Telescope.nvim#extensions

@mrjones2014 I would suggest to take a look at others nvim extensions that provide kind of APIs for sub-extensions to learn the best way to do that, .e.g: Telescope.nvim#extensions

nvim-tree provides a callback :help nvim-tree.on_attach to allow custom mappings for the buffer. Similar to gitsigns.
nvim-tree is moving to that on_attach mechanism being the preferred means of creating mappings: https://github.com/nvim-tree/nvim-tree.lua/pull/1579. which-key and friends will be functional and the help screen will be greatly improved.
The existing mechanism :help nvim-tree.view.mappings will still be functional but deprecated.

Going to close this issue in favor of #184 since we now have a concrete implementation plan for it.

@mrjones2014 Would be best if you update USAGE_EXAMPLES.md when  #183 is closed. Best.

Yeah I will definitely add documentation. Most likely I will create a separate PLUGINS.md file.


Draft: Automated generation of configs.md

Which issue does this PR close?

Closes #2770.
Rationale for this change

What changes are included in this PR?

Added a binary - print_config_docs to datafusion core which generates the config markdown table and prints it.
Added a script to dev (should this be in docs instead?) which runs this binary to update the configs.md file.

Posting this as a draft because I'm not sure yet what the best plan is for fully automating updates to the config documentation. I looked into build.rs but I'm not sure it's the right fit for this since it runs before compilation and can't import from the module it is part of.
One idea I had was to run the script in a github action alongside the tests. If the action runs and there are changes to configs.md, it could suggest the diff on the PR and then fail. It would then be a single click to update the PR to include the changes and restart the tests. There are a few actions on the marketplace for doing this, this one looks promising: https://github.com/marketplace/actions/action-git-diff-suggestions. Open to thoughts and alternatives 🙂 Edit doesn't look like this will work as I had hoped, since Github doesn't allow suggestions on files that haven't been touched by the PR. Maybe the best we can do is to fail if there are changes that need making.
Are there any user-facing changes?

Thank you @mrob95. This looks great. I tried out the changes locally.
Minor nit: could you use underscores in the script filename for consistency with the other scripts.
I like the idea of CI failing if there is a diff in the generated docs but that can be handled in a separate PR.


Hi, Could you share with me an effective method for initializing the MySQL database from your code?

Hi, I'm a student, and I'm eager to learn how to create a database directly from your code. My understanding in this area is somewhat limited, so I'm seeking guidance on the process.
As a student, I'm not entirely sure where to start or what tools to use for this task.
Any tips, resources, or examples would be greatly appreciated as I embark on this learning journey.
Thank you in advance for your assistance!

Are there alternative solutions aside from the utilization of Docker?

Because my knowledge in this area is quite limited, could you please clarify for me?
Sorry for any inconvenience I may have caused and thank you very much for your support.

Is the command to run like this?
wget -O - https://github.com/netless-io/flat-server/raw/main/scripts/prepare-test-env.sh | sh
docker run --name mysql-db -e MYSQL_ROOT_PASSWORD=your_password -d mysql:latest
docker run --name redis-db -d redis:latest
yarn run test:sync:orm

It doesn't need to be docker of course. The code of flat-server has to connect to a mysql service and a redis service. It will read config/development.local.yaml or config/production.local.yaml (depending on the env NODE_ENV) at runtime and connect to these services, see https://github.com/netless-io/flat-server/blob/f97c153502f8b3079d37ed6e31e19600f4ee8983/config/test.yaml#L7-L20.
So you just have to make sure the services are there, and that's enough. The test:sync:orm script will create database tables for you.
Once you have prepared the databases, you can start running the server with:
# watch build the server, will generate dist/index.js
$ yarn run start

# start server in another terminal
$ node dist/index.js

Thanks for your support. I will try it.

Could you please tell me why when I use 'yarn run start' and 'node ./dist/index.js' with port 8080, even though it displays as running successfully but the link doesn't work?

<IP_ADDRESS> is not a valid address to connect to (ERR_ADDRESS_INVALID). It means that the server listens to all possible addresses that could reach the server. For example localhost <IP_ADDRESS> 192.168.x.y {your internet ip}. You can just use <IP_ADDRESS>.


API -  Need to add Key Value check  for the static and dynamic value

Area ->  API
New Feature - Need to add validation support of the key from the response body as to check its value contains define value or undefined dynamic value.
Describe the bug - New feature request
Version - NO
Expected behaviour -  Feature not available in current version
Actual behaviour - Feature not available in current version
How to Reproduce? -  NO
Anything else? - NO
Note: In current testman response validation is not included.

Already this feature is supported

Tested OK
Now We can validate the static value of the key using TO_BE_EQUAL
<EMAIL_ADDRESS>- then pass the value
Code:
await expect(typeof restResponse.data.result_delivery_mode == "string"  ? restResponse.data.result_delivery_mode:JSON.stringify(restResponse.data.result_delivery_mode)).toEqual("hook@poll");
Tested by both valid and invalid values of the key
file:///Users/Kannan/Downloads/Eztoverify_Smoke_Automationbk/Eztoverify_Smoke_Automation/Eztoverify_Smoke_Automation/playwright-report/index.html#?testId=93b13450cf8a674e8332-da56c3c1a906aab18db4


connect Code and Data section: clarify dvc run/repro command

See discussion at https://discordapp.com/channels/485586884165107732/485596304961962003/546947809341865986

from the discussion:

also what is -d or -o
or how you can add -M
to store metrics
and also that metrics file can be in any format, just make sure that you generate the same metrics and the same file every time

a little more details on what run is doing and its basic required parameters I think here would help
I hope I am being helpful here with the feedback

Fixed.


Paket latest version 401 Unauthorized

When I use the latest version (<IP_ADDRESS>) I get an error when updating my packages:
Source 'http://teamcity.*****' exception: System.Exception: Could not retrieve data from http://teamcity.*****/odata/Packages(Id='****',Version='<IP_ADDRESS>')
 Message: One or more errors occurred.
 Details: The remote server returned an error: (401) Unauthorized.
   at Paket.Utils.getXmlFromUrl@282-6.Invoke(String message)
   at Paket.Utils.getXmlFromUrl@271-5.Invoke(Exception _arg2)
   at Microsoft.FSharp.Control.AsyncBuilderImpl.callA@851.Invoke(AsyncParams`1 args)
Paket failed with:
        Couldn't get package details for package **** <IP_ADDRESS> on http://teamcity.*****.

It seems like Paket stops sending the Authorization header:

When I download Paket version 2.36.7 it works.

Can you try to find the last version that still works? Would makes things easier for us to track down

Oh man :( That's a lot of versions in between...
The question is, am I the only one who is getting this? Because you can see that in the 2nd screenshot the Authorization header is not being sent. Should it not be easy to check in the code where the auth header gets set and what the reason could be for it to be ignored?

Can you try to find the please also try to run "paket update -f" so that we know it's not cache related

Okay, I'll have a look...

I ask because AFAIK our teamcity still works, so there must be something subtle. @agross how about you?

As I am trying to narrow it down I came across another issue now. When I revert back to v2.36.7 I get a parse error from a public NuGet packge on NuGet.org, which is completely unrelated to my initial issue.
I will continue to narrow down the original issue, but it seems to me that the package pulling is extremely unstable. Makes me wonder if there was a good reason to completely reinvent everything instead of using the well tested and working NuGet client for some of the work like getting package information which would be the same for both products. -.-

what package?

https://www.nuget.org/packages/Darkseid/

facaf22 seems to work. How can I reproduce that? Is the parsing a real error or does only one of the intermediate proctols fail?

This is how I get the parsing error:
paket.dependencies
source https://nuget.org/api/v2

nuget Darkseid

paket.lock
NUGET
  remote: https://nuget.org/api/v2
  specs:
    Darkseid (0.2.0)

Then I run
paket.bootstrapper.exe 2.36.7
paket update Darkseid

And I get:
Paket version <IP_ADDRESS>
Updating Darkseid in C:\Dev\test\paket.dependencies group Main
Resolving packages for group Main:
 - Darkseid 0.3.0
Paket failed with:
        Couldn't get package details for package Darkseid 0.3.0 on https://nuget.org/api/v2.

With verbose on:
...
Source 'https://nuget.org/api/v2' exception: System.Exception: unable to parse (, )
   at <StartupCode$Paket-Core>.$VersionRange.failParse@143-1.Invoke(String message)
   at <StartupCode$Paket-Core>.$VersionRange.parseRange@142(FSharpRef`1 prereleases, String text)
   at Paket.VersionRequirement.Parse(String text)
   at Paket.NuGetV2.split@158-1(String d)
   at Paket.NuGetV2.parseODataDetails[a](String nugetURL, PackageName packageName, a version, String raw)
   at Paket.NuGetV2.getDetailsFromNuGetViaOData@226-9.Invoke(Unit unitVar)
   at Microsoft.FSharp.Control.AsyncBuilderImpl.callA@851.Invoke(AsyncParams`1 args)
Paket failed with:
        Couldn't get package details for package Darkseid 0.3.0 on https://nuget.org/api/v2.
...

ah so that's only in older version and already fixed. Yes NuGet.org changed their dependencies format one night...

It also seems that the original issue which I reported happened after 2.36.7, because when I use the next version 2.37.0 I get the same issue as with the very latest.
I was looking at the changes https://github.com/fsprojects/Paket/compare/2.36.7...2.37.0 and there is quite some stuff that happened there so I need to have a closer look

okay, makes sense re parsing error

The private package source in question is a private ProGet instance, but I don't think it makes a different as long as package source requires authentication.
I've tried debugging this issue. Not sure if that's the cause, but I've tracked missing authentication to [PackageResolver.getCompatibleVersions] (https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/PackageResolver.fs#L319) where availableVersions are resolved from LockFile which parses sources with authentication as None. However, it's not so obvious where this bug was introduced looking at 2.36.7...2.37.0 changes.
Should Paket try to apply authentication to such sources at a later stage when downloading the package?

yes getcompatibleversion should only use sources with proper authentication.
We need to find the place where it lost the authentication

is there a way for me to reproduce?

but I don't think it makes a different as long as package source requires authentication.

Just tried against myget and it works fine.

I've started new private ProGet instance, and was able to reproduce this issue there.
While NonExistingPackage.* packages don't actually exist in this private package source, it's still possible to reproduce the issue, because Paket update fails with Unauthorized 401 response from server thus reproducing the bug.
You can reproduce the bug by running build.cmd, build.sh, or paket.exe update nuget Darkseid version 0.3.0. Hope this helps.

Thanks @domaslasauskas!

thans for createting a repero. but shouldn't https://github.com/domaslasauskas/Paket-issue-1469/blob/master/paket.dependencies#L2 contain username and pw so that I could theoretically get in?

but If I add this then I think I can reproduce and have an idea of what's going wrong.

ok found the bug. will fix later today

please try with 2.50.6

It's fixed now, thanks!
Re: credentials - we don't store credentials in paket.dependencies, they are set using paket config add-credentials instead.

cheers!


Hide zero value record

Hi,
Please see the picture i want to hide zero value record. If any possible?
Thanks in advance

I think you can try https://ecomfe.github.io/echarts-doc/public/en/option.html#series-bar.label.normal.formatter, where you can use callback function to return ''; for zero value.

When setting the series data, you can use:
{
	value: (yourValue || '-')
}

So it sets the value when it's not zero or undefined, and otherwise it sets a -, which will not be shown as a label.

The question is old but if someone is looking for a better solution use this
 label: {
       show: true,
       formatter: function(param) {
          return param.data == 0 ? '': param.data;
        }
      }


Improve the typing performance of HTTP interceptors

I've observed that Zimic may cause slow typing performance whenever we use different interceptors as part of an array, such as:
const interceptors = [myInterceptor1, myInterceptor2, myInterceptor3]

This is consistent with the slow type generation time we're facing (~10s). We should further investigate which types are causing problems and could be optimized.
Some useful resources:

https://github.com/microsoft/Typescript/wiki/Performance
https://www.typescriptlang.org/tsconfig/#generateCpuProfile
https://www.npmjs.com/package/@typescript/analyze-trace

I've identified that the main culprits were:

Unnecessarily complex restrictions in generic extends, especially the ones related to StatusCode:

- StatusCode extends HttpResponseSchemaStatusCode<Default<Default<Schema[Path][Method]>['response']>> = never,
+ StatusCode extends HttpStatusCode = never,

Slow and deep comparisons between request handler types. This was caused by 1. and a missing IfNever to reduce the load of some type checks:

- type PartialHttpHeadersOrSchema<Schema extends HttpHeadersSchema> =
-   | Partial<Schema>
-   | HttpHeaders<Partial<Schema>>
-   | HttpHeaders<Schema>;
+ type PartialHttpHeadersOrSchema<Schema extends HttpHeadersSchema> = IfNever<
+  Schema,
+  never,
+  Partial<Schema> | HttpHeaders<Partial<Schema>> | HttpHeaders<Schema>
+ >;


Pretrained Models

Dear Authors, thanks for your nice work.
I wonder if there is a BI version pretrained model for TMP network.

We shared one pretrained model using onedrive in the homepage.
Although it was named by "BD_", it actually is a model for BI degrdation. We have corrected its name.

Yes, we will.
But it would not be soon since we are preparing additional experiments.

Thank you for your response. I appreciate your efforts in preparing additional experiments. I'll be looking forward to the release of the pretrained model for BD degradation whenever it becomes available.


Login Page Design Enhancement

I have made some change please take a look and feel free to change anything
and do you feel if we remove header and footer from login page it will look more appealing

Appreciate it! I have to admit I like the current design a little bit more though, so I'll close this for now.


Add alert when the order is placed

Add a pop-up message that says "Your order has been placed". And there should be an "OK" button that takes you back to the homepage.

Added in Popup feature update, patch #11


only set git user if one isn't already set

What Changed
Previously auto would override the local git user with whatever was in the package.json author field.
Now:

it first checks that one isn't set before configuring the email and name
only tries to set the git user during changelog or shipit
If a user is running npm version themselves (rather than using shipit) they are required to set the git config manually

Why
closes #124
Todo:

[ ] Add tests (This file is still fully untested)
[ ] Add docs
[x] Add SemVer label

Thanks!


[feat][offload] Support namespace/topic level auto trigger offload policy.

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Currently, Pulsar only supports global offload auto trigger policy: managedLedgerOffloadAutoTriggerSizeThresholdBytes and managedLedgerOffloadTimeThresholdInSeconds(see: https://github.com/apache/pulsar/pull/17398),
this is a very coarse granularity.
For the purpose of more fine control of auto trigger offload, we'd better to support namespace/topic level auto trigger offload policy.
Solution
Add the following configurations:
// Namespace -> managedLedger size
private final Map<String, Long> managedLedgerOffloadNamespaceSizeThresholdBytes;
// Topic -> managedLedger size
private final Map<String, Long> managedLedgerOffloadTopicSizeThresholdBytes;
// Namespace -> time threshold in seconds
private final Map<String, Long> managedLedgerOffloadNamespaceTimeThresholdSeconds;
// Topic -> time threshold in seconds
private final Map<String, Long> managedLedgerOffloadTopicTimeThresholdSeconds;

Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

This is a practical proposal!


Updated Genome Informatics scholarship pages.

Both news and scholarship pages now point to application form.

Thank you @tnabtaf. @dannon can we make sure this gets published tomorrow (not today)

@nekrut Yes, will do.  I'll update the styling too.

Swapped to the same call to action buttons as seen on the front page, ready to go for tomorrow.


fix(tiller): correctly sort PodDisruptionBudget objects before pods that might use them

Without this, using a pod disruption budget causes errors like this:
"Upgrade \"<rel-name>\" failed: no PodDisruptionBudget with the name \"<pdb-name>\" found"

It turns out, the error I was really running into was caused by an upstream bug: https://github.com/kubernetes/kubernetes/pull/63757 that was fixed in k8s 1.12.0
Basically, the DisruptedPods field cannot be null and if you are trying to edit your PodDisruptionBudget, but dont currently have any disrupted pods, then k8s will fail validation and your release will fail.
The only way to work around this is to delete the PodDisruptionBudget object before you do a helm upgrade.... or update to k8s 1.12.0.
I still think this pull request is useful, but it turns out not to be the real solution.


bad link on doc about policy-controller installation

Hello,
On this web page policy-controller/overview, I noticed a bad link installation instructions (error page not found).
The markdown file with the bad link is this one:
https://github.com/sigstore/docs/blob/ba2468317377e448cdda4b8a51500cf3d700b662/content/en/policy-controller/overview.md?plain=1#L14
I don't know for sure, but the link should probably point toward content/en/policy-controller/installation.md.

We're having a discussion about trailing slashes here: https://github.com/sigstore/sigstore-website/pull/228

Okay thank you @ltagliaferri , I did not notice the issue since it was on the other repo. Closing the issue since it is discussed sigstore/sigstore-website/pull/228.


[BUG] Engine crash makes volume throw input/output error

Describe the bug
If the engine manager crashes on the node where pod is running, the volume attached to it throws error. User is unable to access the volume. After redeploying the pod it works fine.
To Reproduce
Steps to reproduce the behavior:

Create a volume (3 replicas 3 nodes), attach to a workload
Delete the instance-manager-e pod running on the same node where the workload is running.
Go to the pod of workload, try to access the volume (use ls command to list the data in the volume)
The ls command throws error. input/output error

Environment:

Longhorn version: master
Kubernetes version: v1.17.5
Node OS type and version: ubuntu 18.04

This is expected since here the engine was crashed. The block device endpoint will lost so input/output error will be shown. However, Longhorn will automatically reattach the volume, but the workload pod needs to be restarted to recognize the updated mount point. That's why we need to use liveness check for workloads. See https://longhorn.io/docs/0.8.1/high-availability/recover-volume/ for details.


macro-error, when using  #[cfg_attr(test, derive(Serialize))]

https://github.com/IWANABETHATGUY/vue-template-compiler/blob/4a2f334692f82776a5558e89b3203ef64322817e/src/core/error.rs#L7

restart the rust-analyzer does't resolve this issue

varsion: 1.60.0
commit: e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff
date: 2021-09-01T10:43:02.136Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.11.0-27-generic

FWIW, I can't reproduce this. What error are you getting and which rust version are you using?

broken with rust nightly, works fine with latest stable release

Thanks!

If it doesn't work, we want to fix it, but it seems fine for me on rustc 1.57.0-nightly (fdf65053e 2021-09-07).


Swipe left to close sidebar

@ChenJesse when you click on a cell while in the sidebar view, does the song start playing?

@acheng96 Yea it does

@ChenJesse yea I believe that's the reason we set userEnabled to false. But this is a design decision you guys should talk about

I think we should implement this change right now.
I just realized that the main problem is that if you happen to swipe on a cell that is playing, it will scrub the song backwards, but we are planning to redesign the feed to having a constant sticky cell that shows the song being played (like Spotify), so when we make that change, we can disable view interaction in that sticky cell.
Making that constant sticky cell should solve a lot of the UI/UX issues on the backlog.


Changes for Azure DevOps Branding

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: deborshinew sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix RoundRobinPolicy

What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

@jiacheliu3 I totally agree your suggestion, just close this PR


[Question] How to create a new build?

Problem Type (问题类型)
No response
Before submit

[X] 我已经确认现有的 Issues 与 FAQ 中没有相同 / 重复问题

Environment (环境信息)

Server Version: v0.11.x
Backend: RocksDB x nodes, HDD or SSD
OS: xx CPUs, xx G RAM, Centos 7.x
Data Size:  xx vertices, xx edges

Your Question (问题描述)
I want to release a new build with latest changes.Can you please guide me how to create a build ?
Vertex/Edge example (问题点 / 边数据举例)
No response
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
No response

refer #1668 , u could do the following steps:

mvn package -DskipTests  in hugegraph directory , and u'll get the dir 0.12.x & tar package
find the jraft jar in v0.11.2 ./lib
replace the jraft*.jar in 0.12 ./lib with the./lib/jraft-core-1.3.5.jar in  version 0.11.2 .
init-store & start the server

And any more exception with the log u could paster here.

This is the exception am facing while connecting from java API
java.lang.IllegalStateException: The version <IP_ADDRESS> of 'hugegraph-api in server' is not in [0.38, 0.59)|
com.google.common.base.Preconditions.checkState(Preconditions.java:531)|
com.baidu.hugegraph.util.E.checkState(E.java:68)|
com.baidu.hugegraph.util.VersionUtil.check(VersionUtil.java:65)|
com.baidu.hugegraph.driver.HugeClient.checkServerApiVersion(HugeClient.java:100)|
com.baidu.hugegraph.driver.HugeClient.initManagers(HugeClient.java:83)|
com.baidu.hugegraph.driver.HugeClient.(HugeClient.java:63)|
com.baidu.hugegraph.driver.HugeClientBuilder.build(HugeClientBuilder.java:67)|

seems u are using the older version for HugeClient, it doesn't allow use  lower version for client, try 3 ways:

update your client version to adopt with the latest server
comment the version check code by yourself in huge client (warn: it will lack version protection and hide some version inconsistent problem)
turn down the server version from 0.66 -> 0.58 in APIVersion (have the same risk as above)

After updating the client version from 1.9.1 to 1.9.6 ,still facing the same problem.And FYKI , the jraft jar version in 0.11.2 is jraft-core-1.3.3.jar not .jraft-core-1.3.5.jar.Is there any problem with this?

if the latest client version still lower than server, u could try another 2 way (hard code), we'll release the new client version for V0.12 in December (this year)

Thanks for the info !!Worked

changing version from 0.58 still creates same error .error log
ERROR :: java.lang.IllegalStateException: The version <IP_ADDRESS> of 'hugegraph-api in server' is not in [0.38, 0.66)


Cosmetic problem

There's a whiteblue circle around the Artist name each time you open an Artist channel.

yeah, that's an issue with android's accessibility support. I'll investigate to see if it can be turned off

changed the css rule to remove the outline on all nodes. This should fix the issue.


No License File

I would like to use LogBERT for a project. Unfortunately, there seems to be no license mentioned, so I'm not sure how to go about it.

Thank you for letting me know. I just created the license.

I don't see a license file. Or requirements.txt, for that matter. Are they hidden somewhere?


Avoid using undefined value in generate_stateless_cookie_callback

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Looks like the same problem applies to master, so this fix should be applied there too.

Yes for master.

master solved this differently, and initialized temp = 0, so it's not undefined.

do you still want me to add the if (res != 0) in master?

Ah, sorry. That's me misreading the code. Ignore  me. The code actually looks a little different here in master anyway. 1.1.1 only is fine by me.

I'd still be tempted to make this change in master too, just from the point of view of don't change things on failure.
I'm not all that fussed either way, though.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.


SAML Integration tests not passing in release/2.7.1

I'm having difficulties with the SAML integration tests in the release/2.7.1 branch. I know that these are run continuously so I'm hoping it's a configuration issue but either way it looks like maybe the default configuration is not correct for these integration tests. Here's the issue I am seeing:
org.openqa.selenium.NoSuchElementException: {"errorMessage":"Unable to find element with xpath '//h2[contains(text(), 'Enter your username and password')]'","request":{"headers":{"Accept-Encoding":"gzip,deflate","Connection":"Keep-Alive","Content-Length":"86","Content-Type":"application/json; charset=utf-8","Host":"localhost:22082","User-Agent":"Apache-HttpClient/4.3.3 (java 1.5)"},"httpVersion":"1.1","method":"POST","post":"{"using":"xpath","value":"//h2[contains(text(), 'Enter your username and password')]"}","url":"/element","urlParsed":{"anchor":"","query":"","file":"element","directory":"/","path":"/element","relative":"/element","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/element","queryKey":{},"chunks":["element"]},"urlOriginal":"/session/c0598c80-9219-11e5-803a-659861915331/element"}}
While troubleshooting this issue, I developed a theory for why this might be happening. Take "testSimpleSamlPhpLogin()" as an example. The test starts with a redirect to "http://localhost:8080/uaa/login" and expects to see the "simplesamlphp" login page. Instead it sees the UAA "Welcome" page to either login using the default UAA idp or click on the "Login with Simple SAML" link. It's as if the integration test expects that the user is automatically redirected to the Simple SAML login page but instead UAA is giving them the option of using the default IdP or the SAML login page.

Here is what the test is expected to do:

Create  the SAML provider
GET to login page
Looks for Cloud Foundry to be the title of the page
Looks for a link with the text Login with Simple SAML PHP("+alias+")
Clicks on that link
Enters username and password

If the SimpleSAMLPhp site already thinks you are logged in, it will automatically redirect you back to UAA. Therefor, I suggest you take a screen shot before you evaluate the next page.
https://github.com/cloudfoundry/uaa/blob/32b5ea941d872b4160f6ed67b9323934ddbc1c75/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/SamlLoginIT.java#L291-L291
you can simply call IntegrationTestUtils.takeScreenshot(webdriver)
and let us know what you see.

@fhanik As I suspected the issue was our corporate proxy and I was able to confirm it by dumping the page source in the spot you suggested. Thanks.


Elasticsearch Connection Issues

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Linux
Python version information

=3.11

DB-GPT version
main
Related scenes

[ ] Chat Data
[ ] Chat Excel
[ ] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[ ] Dashboard
[ ] Plugins

Installation Information

[ ] Installation From Source

[ ] Docker Installation

[X] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information
A6000
Models information
large-chinese
What happened
I configured the IP address for ES, but why does it show localhost when an error occurs?
What you expected to happen
es connect success
How to reproduce
deployment,and .env has been modified

Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

it looks like es connection error,.

make sure your connection
debug ElasticsearchStore connect module

看起来像 ES 连接错误，。

确保您的连接
debug connect 模块ElasticsearchStore

It’s a connection error, but I don’t understand why it still uses localhost after I modified the .env file.

what is your ELASTICSEARCH_URL value in .env

what is your value in ELASTICSEARCH_URL``.env

this is in docker container

what is your ELASTICSEARCH_URL value in .env

this is in docker container

can you use telnet to connect telnet <IP_ADDRESS> 123456

can you use telnet to connect telnet <IP_ADDRESS> 123456

es port is 9200


XenForo exclusion profile improvements

remediate FP in xf_session
remediate FP in options update
tighten URI regexes on options/update and pages/templates/save
support for merging templates
support for allowing HTML in user group's user_title

Thank you. Looks clean to me. Merging ahead of the meeting tonight (to clean up the PR queue).


when choosing generate component or any others doesnt work

There's some issue generating files now can you pls fix or let me know how to do

Can you please elaborate more...
What VSCode version are you using?
OS?
What is your project structure?
Do you have .angular-cli.json file inside project directory?

I am using VS code 1.11.1 with angular 4.
I do have angular-cli.json.
I am able to use ng generate commands in terminal but extension alone is not working


How to configure the Expiration of an upload?

Does s3store support expiration of an upload?. Appreciate if someone can point to a documentation or relevant methods.

Does s3store support expiration of an upload?

No, it doesn't. In fact, tusd does not currently implement the Expiration extension. However, I would be delighted to help you add this feature :)

I searched a bit and found out that s3 support expiration. http://docs.aws.amazon.com/AmazonS3/latest/dev/lifecycle-configuration-examples.html#lc-expire-mpu

I searched a bit and found out that s3 support expiration. http://docs.aws.amazon.com/AmazonS3/latest/dev/lifecycle-configuration-examples.html#lc-expire-mpu

This is also in line with our approach here: https://github.com/transloadit/uppy/issues/122#issuecomment-243703608 - letting a layer close to the actual storage handle it has its drawbacks, but also the clear advantage of not having to do bookkeeping at a higher layer which has an increased chance of being out of sync and/or more resource hungry.

Hello, if there any plan to implement expiration extension? Can I add expiration date into FileInfo struct?

We currently have no plan to implement the Expiration extension on our own but we are always happy to assist you if you would like to contribute this feature.

I opened https://github.com/tus/tusd/issues/435 to start the discussion for a possible implementation of the Expiration extension.


Sync latest RLMeta SegmentTree implementation to TorchRL

@xiaomengy thanks for this brilliant contribution!
Here's the error message from the built, any tips on how to solve this?

@xiaomengy I fixed the issues by adopting a code structure more similar to what you have in rlmeta.
Does it make sense to you?

@xiaomengy I fixed the issues by adopting a code structure more similar to what you have in rlmeta. Does it make sense to you?

Thanks for the update. Actually I was planning to do the same thing in the next PR


Confirm DEB packaging works and prepare PPA

Some pointers from Erik Kristensen:
Here is a PPA quick start guide — http://blog.launchpad.net/ppa/personal-package-archives-for-everyone
If you install the python-stdeb package, you’ll be able to do this very simply on a ubuntu system.

python setup.py —command-packages=stdeb.command sdist_dsc
cd deb_dist/package_name
Edit the debian/control file, make sure section is set  to something other then unknown.
Edit the debian/changelog file, make sure your name and email address is in there, and that unstable is precise or any other ubuntu distro you want to support.
debuild -S
cd ..
dput ppa:yourusername/yourppa your_package-version_source.changes

closing due to lack of interest


Habit Tracker

Experience
My Routine Set consisted of 3 or 4 must-do habits that I must do every day. The Responses of these are either Yes or No.
The purpose is to instill a daily routine of must-do habits and then after 1 month, you can see how the graph is going.
As they say, repeated habit is the sole determination of the character of a person.

 It ensures that you "keep the ball rolling," even when the temptation to stop is strong, thus cultivating a "can-do" attitude.
Categories
Personal Growth
Language
en-US
Terms

[X] I agree that this Experience is licensed under the MIT License.
[X] I have intellectual property rights and/or permission to contribute the Experience and its content.
[X] I confirm that the Experience does not contain any harmful or malicious content.

hey @darshansharma, please add the link to the zip file under the Experience field, in order for the submission to be checked again. it should look like this:
### Experience

[Habit.Tracker.zip](https://github.com/anyproto/gallery/files/14083669/Habit.Tracker.zip)

thanks!

/gallery approve


missing example.vcf of chapter 16.5.1

This was rearranged in the final book (it was chapter 20) and the files are all in the pedigree subdirectory.


Increase speed by compiling to native code

It should be investigated if and how detection speed can be increased by compiling crucial parts of the library to native code, probably with the help of Cython or mypyc.

This issue can be closed as I've written Python bindings for the Rust implementation of Lingua. This solution performs much better than using Cython etc.


SeaweedfsDisk Usage Much Large Than Actual File Stored

I set up Seaweedfs as a Docker instance for storing image file, which average size is about 500MB and I didn't use the large file version Seaweedfs. I used it as a S3 storage and there are around 5TB images to be uploaded via a Java program. Today, I notice the Java program cannot upload the images and the NAS, which has 44TB storage, reported it is almost full. I checked Seaweedfs has used up around 38TB disk space. When I list the S3 bucket, there are around 2TB images in it. There is only one S3 bucket used and one program uploading the image. So, why Seaweedfs is taking up so much disk space?

Please show the output of volume.list via weed shell

I dumped the volumes with the following command in the attached file
curl "http://localhost:8080/status"
volume-list.txt

There are about 1500 volumes. If each volume is pre-allocated with 30GB. So the total occupied disk space is about 45TB.
In each volume, only about 1.5GB data are actually stored.

How can I stored more than 1.5GB data per volume?

Upload with the existing collection. And ensure weed master -volumeSizeLimitMB=30000

I just summed the file count of each volume in the list and the total is around 470K. I should have around 6000 files to be uploaded. How come there are so much files in the volumes?

I started the docker container with the following already.
docker run --name seaweedfs-s3 -d \   --restart unless-stopped \   -p 9333:9333 -p 8333:8333 -p 8080:8080 -p 18080:8080 \   -v /volume1/mongodb/seaweedfs/data:/data chrislusf/seaweedfs \   server -dir="/data" -volume.max=1500 -master.volumeSizeLimitMB=30000 -s3
and I should have the latest container image.
REPOSITORY            TAG                 IMAGE ID            CREATED             SIZE
chrislusf/seaweedfs   latest              3f49588b43f9        9 days ago          91.7MB

You should know that internally files are split into chunks (or 32MB by default I believe), so maybe that's the number of chunks and not files ?

Make sense. But would it be better if it is reported as chunk count instead?

Make sense. But would it be better if it is reported as chunk count instead?

To the volume server, a "chunk" is a "file", it doesn't understand if it's a "chunk" or "full file". It's all bytes.


4109: Implement 90-degree Cylindrical Rotation of a Matrix in R

Title: Implement 90-degree Cylindrical Rotation of a Matrix in R
📑 ## Description
This pull request introduces a new function, cylindrical_rotate_90, in R that performs a 90-degree cylindrical rotation of a given matrix. The rotation is achieved by reversing the rows of the matrix and reassigning them as columns in a new matrix.
🐞## Related Issue
Closes https://github.com/codinasion/codinasion/issues/4109
📋 Explanation of changes
Added a new R function, cylindrical_rotate_90, that performs the required rotation.
The function takes a matrix as input and returns the matrix rotated by 90 degrees in a cylindrical manner.
copilot:walkthrough
copilot:poem

@victoriacheng15 can you please review the code and merge the PR to close this issue?

I checked the code with Replit online editor and the output below is what I got.
Input Matrix:
     [,1] [,2] [,3]
[1,]    1    2    3
[2,]    4    5    6
[3,]    7    8    9

Output Matrix:
     [,1] [,2] [,3]
[1,]    3    6    9
[2,]    2    5    8
[3,]    1    4    7

@victoriacheng15 I think its the compiler notation. The numbers in the square brackets are just the indices of rows and columns but not the actual input. correct me if I am wrong.

Thanks @victoriacheng15 for approving and merging the CR.


Add Smaller Description Deck

The current description deck is too long for use in places like Related Content (or whatever we end up calling this section).
Create an additional field called "mini-deck" with a short explanation/help text of "one-sentence description".

@sarawb: Can you confirm/correct my understanding of how the new Mini Deck works?

Articles, Blog Posts, and Columns all get this new field.
The content in the new field should replace the old deck wherever content is promoted, but not the main focus of the page — i.e. in the sidebar areas, but not the home page or blog/column landing pages. Do you want to use the new field in the emails as well?
To prevent holes, if the mini deck is not populated, the templates will fall back to the current field.

Yes.

Yes re: sidebars, etc. No for email (the full deck doesn't look long at all on email; I think the mini would look super spare).

Yes, but should they (cringe) truncate in sidebars?

Also, these should start pulling into Meta description, Open Graph Description, and Twitter Card description, instead of the full deck (per the recommendations from Jonathon).

Right, good call on the meta info.

We could truncate, if you think it's the lesser of two evils. I would lean toward showing the whole thing, my thinking being that the larger text might be more likely to draw the attention of an editor who will realize the mini deck empty.

@aparkening @murtaugh @sarawb
I have implemented this on DEV, the mini-deck field has been populated in a few recent cases so we can see how it works and looks. Let me list the cases where we see the mini-deck:

Articles landing page in the sidebar only (for column + blog entries)
Columns landing page in the sidebar only (for article + blog entries)
Article entry pages in the sidebar (for column + blog entries)
Column entry pages in the sidebar (for column + blog entries)
Blog entry pages in the sidebar (for column + blog entries)

Shouldn't we be also be showing articles in all the sidebars or will this be covered by the new relationships fields?

We could truncate, if you think it's the lesser of two evils. I would lean toward showing the whole thing, my thinking being that the larger text might be more likely to draw the attention of an editor who will realize the mini deck is empty.

I think there should be zero excuse for leaving this empty for new articles—this will be on the list of required details, and we'll have Erin checking that it's there in prod for articles.
What I am worried about is the vast amount of past articles we are dealing with. So let's say we have a new article on RWD we publish. Of course the editor will write a mini-deck for that. But the new article template will pull in a couple recent RWD articles that might predate the mini-deck. If that uses the full deck instead, then the template will look pretty overloaded. And I suspect, at least at first, that that will happen quite often. That's not something an editor can be expected to do: go back to the past pieces and write new mini-decks for all of them. So that's why I think a truncation fallback might be the most realistic.

Ok cool, we will truncate.
Maybe we could (someday) make it a community task to add mini decks to older content.

On May 25, 2015, at 9:15 AM, sarawb<EMAIL_ADDRESS>wrote:
We could truncate, if you think it's the lesser of two evils. I would lean toward showing the whole thing, my thinking being that the larger text might be more likely to draw the attention of an editor who will realize the mini deck is empty.
I think there should be zero excuse for leaving this empty for new articles—this will be on the list of required details, and we'll have Erin checking that it's there in prod for articles.
What I am worried about is the vast amount of past articles we are dealing with. So let's say we have a new article on RWD we publish. Of course the editor will write a mini-deck for that. But the new article template will pull in a couple recent RWD articles that might predate the mini-deck. If that uses the full deck instead, then the template will look pretty overloaded. And I suspect, at least at first, that that will happen quite often. That's not something an editor can be expected to do: go back to the past pieces and write new mini-decks for all of them. So that's why I think a truncation fallback might be the most realistic.
—
Reply to this email directly or view it on GitHub https://github.com/alistapart/AListApart/issues/198#issuecomment-105230080.

@sarawb @murtaugh @aparkening
I implemented truncating (you can see examples on [DEV] (dev.alistapart.com) in the same places listed above where we are using the mini-deck). I set the description to truncate at 175 characters and to end with '...' Is the number of characters ok and should we use an elipsis?

175 chars and an ellipsis works for me! Thanks @michellekondou!

@aparkening @sarawb @murtaugh
The mini deck is now pulling into Meta description, Open Graph Description, and Twitter Card description (if there isn't one the full deck is being used). Any second thoughts before we push these changes to production? Double checking because it will a visible change in the page layout.

I think we're set on my end. This means we need to be aggressive about having editors use the new field starting now! I'll finish up some guidelines for that.


Adapt poetry as package manager

This PR adapts the entire project to use poetry as the package manager. See the following demo.

One issue is when doing poetry install torch-scatter throws an error. I think this is because torch-scatter never explicitly says it depends on torch so when doing parallelized installation it throws the error. To fix it, simply run poetry install again.

installation issue will likely be fixed after #68 #69

Beautiful 🤩
The GitHub action and CONTRIBUTING.md will need to be updated.
Also, do we still need the setup.py files? They seem redundant with the pyproject.tomls

Also, do we still need the setup.py files?

Nope :) I will delete them and update the CI and CONTRIBUTING.md

Updating black to fix a python 3.9 issue: https://stackoverflow.com/questions/69912264/python-3-9-8-fails-using-black-and-importing-typed-ast-ast3

@cswinter how would you feel upgrading black to the latest version?
otherwise it seems updating typed-ast would also work.

@cswinter how would you feel upgrading black to the latest version?

SGTM

The CI passed but note the newer version of black does incur slightly different formatting behaviors.

Merging now.


Does Spring Cloud has a plan to support CNCF OpenTelemetry at future?

OpenTelemetry will be produced by CNCF, Google and MicroSoft, it will integrate Opentracing & OpenCensus to support tracing, metrics and log.So any plan? Thanks a lot

The Spring Framework has a LONG history of supporting common standards vs own implementations. OpenTelemetry (https://opentelemetry.io/) is not only an API, but also a proper implementation. For me, the Spring way to go would be to provide an ADAPTER to OpenTelemetry.
@marcingrzejszczak Marcin added the discussion tag some months ago, but I don't see any discussion here yet.
What do you think?

this is a beta library, designed by several people.  I'm not sure the "common standards" is warranted here, quite yet.

For example, it is only less than a month ago that 0.3 was released, which the group decided to call Beta. https://github.com/open-telemetry/opentelemetry-java/tree/v0.3.0
Similar to other discussions, brand words are secondary to stability when considering A. if something is standard or not and B. if it is stable enough to consider thrashing existing users over.

I'd like to also fix the description as there are some things not obvious about this.

OpenTelemetry integrates with the canceled OpenTracing project via a bridge

We have a bridge to OpenTracing for years

OpenTelemetry does not integrate with OpenCensus and will not

See https://github.com/open-telemetry/opentelemetry-java/pull/341

More importantly, OpenTelemetry is trying to reinvent many wheels, not just Tracing. This repository only scopes tracing and correlation

Ex they have an evolving metrics api (with far less backends than micrometer)
Ex they want to make their own logging model and apis

Let's consider that there are years of features in the current libraries not possible in the 0.3 apis. What are some potential outcomes?
Well, it is possible that if the tracing apis stabilize, Brave can forward data into them which would allow the years of code end users have written to continue to work. This would be the same way we handle OpenTracing today.
Data formats are not a concern at the moment, as Otel not only supports B3 headers, but (soon) will support Zipkin data anyway. There is talk about w3c trace-context and that is already in scope for Sleuth 3.0, though there are issues in the spec which remain unaddressed and prevent portable implementations.
At the point that OTel ends up with stable formats, a decoupled feature could be written to do that in the same way we have decoupled features to report data into Google and Amazon cloud formats. Even without that, they have a project aiming to convert into their format https://github.com/open-telemetry/opentelemetry-collector
Regardless of any of these potential outcomes, it is certainly the case that Sleuth 3.0 will not make a hard dependency on any 0.3 versioned library. Sleuth has no scope to change the underlying logging infrastructure used by apps for the last decades (log4j sl4fj etc). It also has neither value to gain from, nor scope to try to swap out well designed and used metrics libraries for a 0.3 alternative.

It is probably less intuitive how much damage is caused by unstable apis. Even though OpenTracing support is optional, there is rev lock caused by it. Sleuth 2.1.x is pinned and we can't change it to the more recent OpenTracing libraries because people in 2.1 got locked into the older versions.
The summary is we know this path, we've been down it before, and it hurt.
This is compounded by a focus of instrumentation work done with java agents. This sort of integration can hide problems that hurt dependency injection, such as reliance on static initialization of things like tracers.
https://github.com/open-telemetry/opentelemetry-auto-instr-java
My advice is to let this group stabilize their code. When the thrashing dies down a bit, consider it again. Consider more than the version number, what precise value is being brought. It may be that folks are taking a lot of features present here for granted!
I suspect it will be at least the end of the year before even the tracing aspect of Otel will be near 1.0, if then. It would certainly be fair to re-assess towards the year end.
Hope this helps.

We can reopen when it is more stable

Kudos to you @adriancole @spencergibb for the fast, exhaustive and in-depth discussion!
Yes, this makes sense.

Done via https://github.com/spring-cloud/spring-cloud-sleuth/commit/6e306e594d20361483fd19739e0f5f8e82354bf5

@adriancole and @spencergibb Can we revisit this topic? Otel spec for tracing is close to GA, as well as .NET library. There is also serious support from cloud community (eg. AWS distro of OpenTelemetry). Would be good to revisit and discuss potential support for openTelemetry.

@adriancole and @spencergibb Can we revisit this topic? Otel spec for tracing is close to GA, as well as .NET library. There is also serious support from cloud community (eg. AWS distro of OpenTelemetry). Would be good to revisit and discuss potential support for openTelemetry.

We have plans. The project is in incubator until it goes GA. We're in regular meetings with their team. https://github.com/spring-cloud-incubator/spring-cloud-sleuth-otel

We have plans. The project is in incubator until it goes GA. We're in regular meetings with their team. https://github.com/spring-cloud-incubator/spring-cloud-sleuth-otel


Add support for partitioners in LLC realtime.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@47f4a80). Click here to learn what that means.
The diff coverage is 72.47%.

@@            Coverage Diff            @@
##             master    #1230   +/-   ##
=========================================
  Coverage          ?   67.34%
=========================================
  Files             ?      773
  Lines             ?    37595
  Branches          ?     4921
=========================================
  Hits              ?    25317
  Misses            ?    10617
  Partials          ?     1661

Impacted Files
Coverage Δ

.../indexsegment/generator/ColumnPartitionConfig.java
92.59% <ø> (ø)

...pinot/core/query/pruner/AbstractSegmentPruner.java
79.16% <100%> (ø)

...m/linkedin/pinot/common/config/IndexingConfig.java
67.27% <100%> (ø)

...ltime/impl/dictionary/StringMutableDictionary.java
83.92% <100%> (ø)

...time/converter/stats/RealtimeColumnStatistics.java
93.18% <100%> (ø)

...ommon/request/helper/ControllerRequestBuilder.java
89.77% <100%> (ø)

.../impl/stats/AbstractColumnStatisticsCollector.java
75% <100%> (ø)

...ot/core/query/pruner/ColumnValueSegmentPruner.java
84.48% <100%> (ø)

.../core/data/partition/PartitionFunctionFactory.java
73.91% <100%> (ø)

...ltime/impl/dictionary/DoubleMutableDictionary.java
56% <25%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f4a80...46c00d9. Read the comment docs.


Document implicit assumption in non-blocking spi trait

It should only be able to read the data returned by the last write call. Otherwise the overflow handling isn't really possible when doing only write calls (at least on stm32f0). @therealprof and me came to this conclusion after chatting on irc that this is the intended usage of this api.

Removed the change for the default implementation, otherwise releasing cs after doing a blocking write will lead to unintended consequences

Any progress here?

I've thought about this a bit more: If any hal (with hardware fifos) wants an efficient implementation with these restraints,
they'd have to count the current spi transactions. This would also make utilizing the receive fifo pretty much impossible.
This slows bidirectional communication (which, in my experience, is pretty uncommon) down, especially when considering techniques like dmas or platforms like linux.
In contrast leaving it like it's currently often implemented (just giving an error if the receive fifo overflows and otherwise returning the oldest byte) makes it uncertain when the fifo overflows,
forcing chip independent implementations to read after every write (and worse, if the peripheral is somehow shared, making off-by-one errors possible).
But it enables chip-specific implementations to utilize the receive fifo to it's full potential.
I'm not happy with both solutions, but the proposed one sounds a lot better to me. Open to alternatives
As-is, this PR is done, not needing more progress, but some discussion could improve it.
(I think) This is also a breaking change, since existing implementations didn't have to consider any restraints.

It seems we need more discussion here. Will you be able to participate in our weekly meeting? Next will be on Feb 16.

As this hasn't been resolved yet, I'd like to try & get this (or some alternative) into v1.0.

Any progress here?

This is basically ready as-is. If we want to do the simpler, but way less useful alternative of unspecified behaviour for unpaired read & send calls, that would also work, I don't care much either way, I just want there to be some thought given to it & documented instead of "the most convenient interpretation".

bors r+

Maybe the unresolved review? I've resolved it, might work now.

bors r+

Nope, bors is picky about that. @Disasm will need to explicitly approve to get rid of the concern.

bors r=therealprof

bors r+


master branch  can not be builded ,I need your help!

Question and/or Comment

Incomplete (no logs, errors, etc.), wrong issue template (it could be a bug, it is definitely not a question).


GarbageCollect causes graphical glitches

So I have attempted to archive a program in Cesium, and gotten a garbage collect scree. First off, the OS attempts to go back to normal, and has that graphical error. But second, if you hit yes, Cesium goes ballistic after it finishes. Text displays everywhere. Cesium is still responsive though.

Fixed it "good enough"


Need a logo for the library.

We need some sort of logo for the library. So, if you are a Graphic designer and wanted to contribute to the open source community then here's your good chance.

see my pull req.

Hello @Gautam-Arora24! I'd like to contribute, could you please assign this to me?

Hi @SaxenaAnushka102! Sure!

Hey @Gautam-Arora24 I'm on it! Could you please provide some information about the theme, required picture resolution & dimension details?

We'll be using the logo in the README.md file so you can make something that extends till the whole width of the file.

Hi @Gautam-Arora24! I've done a PR, please check it out.

@SaxenaAnushka102 You have pointed your PR to the wrong origin(your own repo), please point it towards Gautam-Arora24/nixty.

Closes with #3


add smart contract security

add A curated list of Smart Contract Security materials and resources For Researchers

add new curated awesome list

Thanks for making an Awesome list! 🙌
It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

Vbnj

add A curated list of Smart Contract Security materials and resources For Researchers


Document use of isobib

Will need to add to Readme, detailed Wiki, and Quickstart.

@opoudjis @andrew2net can we have documentation for how to trigger auto-bibliography?
e.g. keywords found in anchor (e.g. ISO, IEC...?)

Done. The trigger is ISO in the reference label (not the anchor! e.g. [[[ricepotentialmilling,ISO 6646]]]. (The code is in fact called for IEC too, since I treat IEC as equivalent to ISO in reference building; but there are no IEC references to be found on the IEC site.)
If and when there is caching, I will document that separately.


Position of Y axis

Describe the solution you'd like
Consider the possibility to let the user choose the position of the Y axis (left or right)

@wrightak Yes, you can change it with this property.
let chart = FLChart(data: [...], type:  [...])
chart.cartesianPlane.yAxisPosition = .left or .right

For a bar chart, is this supposed to change the bars so that they're ordered from the right, instead of the left? It looks like it just changes the position of the axis. The whitespace in the graph is still on the right hand side.

@wrightak Yes the order of the bars is always from left to right.

@francescoleoni98 Thanks for the replies. We're looking to implement something similar to the graphs in Apple Health, where the most recent is on the right. Do you think it would be difficult to add a configuration to order from right to left? Would you accept a PR doing this? Any tips on how to go about it?

@wrightak Yes, I think it would be pretty complex but if you want to try make it that is really welcomed 😄


ci: re-enable tests on PRs

I’m hoping the secret passes properly, but if not, I’m going to need to rewrite the way the tests automatically run to allow that to connect without making the token public

why are the tests failing?

nvm, it's just the compile errors that are fixed in #82


ffmpeg -i rtsp://admin:admin12345@<IP_ADDRESS>:554/h264/ch1/main/av_stream   -f mpeg1video  -r 25  -s 640x480  http://localhost:8081/supersecret

ffmpeg -i rtsp error
av_interleaved_write_frame(): Unknown error
[h264 @<PHONE_NUMBER>7c9300] error while decoding MB 98 20, bytestream -5

This is not a problem with JSMpeg. Seems the RTSP is not valid. Ask on Stackoverflow or on the ffmpeg support sites.


Add mock for Extension types

As I can see there's no way by design for mocktail to mock recently added Extension types?
It would be nice to have such feature. Is there any possibility?

I am also battling with this a while, as it is really annoying. There was an issue about it a few years ago: https://github.com/felangel/mocktail/issues/58.
@felangel Is there anything new regarding this?

This is a limitation of the way extensions are implemented afaik. When you write an extension, it’s similar to adding a static method which isn’t possible to mock. Not sure there’s anything we can do in mocktail to improve this but I’m open to suggestions.

Thanks for the quick answer, I didn’t realize extensions worked that way. It makes more sense now why they can’t be mocked.

Closing this for now but happy to continue the conversation if anyone has suggestions.


Build fails on ARMv7 (Raspberry Pi / Debian)

I'm not sure if this is the same issue as #3783, but as I get a different error message I thought a new issue was more appropriate.
I'm trying to get Atom running on a Raspberry Pi 2 Model B under Raspbian, using a normal user account with sudo only when root is required (i.e. I build everything as non-root). uname -a gives the following output:
Linux raspberrypi 3.18.7-v7+ #755 SMP PREEMPT Thu Feb 12 17:20:48 GMT 2015 armv7l GNU/Linux
I've installed on the dependencies as per the Linux build instructions, and I've compiled and installed Node.js v0.12.0 from source. Everything runs fine until I get to the following command:
script/build
This produces the following output on the console:
$ ./script/build
Node: v0.12.0
npm: v1.4.28
Installing build modules...
child_process: customFds option is deprecated, use stdio instead.
gyp: name 'chromeos' is not defined while evaluating condition 'target_arch=="arm" and chromeos==1' in deps/breakpad/breakpad.gyp while loading dependencies of binding.gyp while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/home/pi/dev/atom/build/node_modules/npm/node_modules/node-gyp/lib/configure.js:343:16)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1067:12)
gyp ERR! System Linux 3.18.7-v7+
gyp ERR! command "node" "/home/pi/dev/atom/build/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/pi/dev/atom/build/node_modules/minidump
gyp ERR! node -v v0.12.0
gyp ERR! node-gyp -v v1.0.1
gyp ERR! not ok

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the minidump package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls minidump
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 3.18.7-v7+
npm ERR! command "node" "/home/pi/dev/atom/build/node_modules/.bin/npm" "--userconfig=/home/pi/dev/atom/.npmrc" "install" "--loglevel" "error"
npm ERR! cwd /home/pi/dev/atom/build
npm ERR! node -v v0.12.0
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! not ok code 0

Is this a bug with Atom or the minidump package (as suggested in the error log)? I have very little experience with Node and this is the first time I've had to debug a problem related to it.

Same here running Ubuntu 14.04 on the Pi 2
Linux adamspi 3.18.5-v7+ #225 SMP PREEMPT Fri Jan 30 18:53:55 GMT 2015 armv7l armv7l armv7l GNU/Linux

I am getting an error as well but different issue, my output is:
Node: v0.10.36
npm: v1.4.28
Installing build modules...
Installing apm...
/bin/sh: 1: /home/pi/atom/build/node_modules/.bin/npm: not found

Judging by atom/node-minidump#5 this has already been fixed over on the minidump module, but build/package.json is still requiring ~0.8. Changing that to ~0.9 seems to fix it for me and then I run into #3783.

Same here, bumping up minidump to 0.9 gets the build process a bit further but then bombs out with the error in #3783.

:wave: I've been trying to get Atom up and running on ARM and created an issue with updates linked :point_up:

I am using Raspberry Pi mode 3 Jessie (latest) and running the latest version of node.js(6.9)
All build looks great. until this part
Wrote Dependencies Fingerprint: /home/pi/Downloads/atom/node_modules/.dependencies-fingerprint cef7aa06628941107a71c33269fa1c5037092436
Copying assets to /home/pi/Downloads/atom/out/app
Transpiling Babel paths in /home/pi/Downloads/atom/out/app
Transpiling CoffeeScript paths in /home/pi/Downloads/atom/out/app
Transpiling CSON paths in /home/pi/Downloads/atom/out/app
Transpiling PEG.js paths in /home/pi/Downloads/atom/out/app
Generating module cache for /home/pi/Downloads/atom/out/app
Generating pre-built less cache in /home/pi/Downloads/atom/out/app/less-compile-cache
Generating metadata for /home/pi/Downloads/atom/out/app/package.json
Generating API docs at /home/pi/Downloads/atom/docs/output/atom-api.json
Skipping Chromedriver download because it is used only on macOS
Dumping symbols in /home/pi/Downloads/atom/out/symbols
Running electron-packager on /home/pi/Downloads/atom/out/app with app name "atom"
Downloading electron-v1.3.6-linux-x64.zip
[============================================>] 100.0% of 42.62 MB (1.72 MB/s)
Packaging app for platform linux x64 using electron v1.3.6
Changing permissions for node files in /home/pi/Downloads/atom/out/atom-1.13.0-dev-18609f8-arm
Error: spawnSync /bin/sh ENOMEM
    at exports._errnoException (util.js:1026:11)
    at spawnSync (child_process.js:461:20)
    at Object.execSync (child_process.js:517:13)
    at chmodNodeFiles (/home/pi/Downloads/atom/script/lib/package-application.js:96:16)
    at runPackager.then (/home/pi/Downloads/atom/script/lib/package-application.js:46:7)

Did it download the wrong version of the electron? electron-v1.3.6-linux-x64.zip

Currently the build script only downloads the x64 binary on Linux.  There is a PR to fix that at #13001 if people want to test it out.

I have noticed, that the ARM arch "key" has different values, dependent on how it is accessed:
$ uname -m
armv7l
$ node -p process | grep arm
  arch: 'arm',
      { arm_float_abi: 'hard',
        arm_fpu: 'vfpv3',
        arm_thumb: 0,
        arm_version: '7',
        host_arch: 'arm',
        target_arch: 'arm',
$ node
> process.arch
'arm'

Look at script/lib/package-application.js.
electron-packager receives the process.arch value, which is 'arm', not 'armv7l'.
This leads to a build fail in electron-packager:
Running electron-packager on /home/maru/atom/out/app with app name "atom"
Error: Unsupported arch=arm; must be one of: ia32, x64, armv7l
    at Object.validateListFromOptions (/home/maru/atom/script/node_modules/electron-packager/targets.js:29:16)
    at packager (/home/maru/atom/script/node_modules/electron-packager/index.js:234:23)
    at Promise (/home/maru/atom/script/lib/package-application.js:141:5)
    at runPackager (/home/maru/atom/script/lib/package-application.js:140:10)
    at module.exports (/home/maru/atom/script/lib/package-application.js:17:10)

I've opened an issue at electron-packager, but it was closed with the suggestion, that atom should have a better check for the "right" ARM version.
I've added a quick test for the above stated combination of process.arch and process.config.variables.arm_version and the build passed successfully!
This might get a bit trickier, when support for ARMv8 is out, but I think this is the right place to add the additional check.
It doesn't seem to be safe to rely on process.arch only. Nevertheless electron-packager declined adding an additional ARM version check...

We don't support Atom on the Raspberry Pi. While we would love to support Atom on all possible platforms, our resources are finite so we have to draw a line somewhere. You can find out more information about Atom on ARM and links to other community efforts on #7822.


aix: -Wattributes warnings during build

As found out in PR: https://github.com/libuv/libuv/pull/908
The issues seems to be -fvisibility=hidden which we are compiling with by default.
Auto tools checks for it as seen here:
configure:4010: checking if /usr/bin/gcc supports -fvisibility=hidden flag
configure:4026: /usr/bin/gcc -c -g -O2 -fvisibility=hidden  conftest.c >&5
conftest.c:11:1: warning: visibility attribute not supported in this configuration; ignored [-Wattributes]
 int a;
 ^
configure:4026: $? = 0
configure:4043: result: yes

Console output:
imrani@dal-pax /tmp/imranbuild gcc -c -O0 -g3 -fvisibility=hidden test.c
test.c: In function 'main':
test.c:16:1: warning: visibility attribute not supported in this configuration; ignored [-Wattributes]
 }
 ^
imrani@dal-pax /tmp/imranbuild

Without -fvisibility=hidden
imrani@dal-pax /tmp/imranbuild gcc -c -O0 -g3  test.c
imrani@dal-pax /tmp/imranbuild

I'm not too entirely sure why are not checking with -Werror
in configure.ac we have : CC_CHECK_CFLAGS_APPEND([-fvisibility=hidden])
Which should call : CC_CHECK_CFLAG_APPEND in libuv-check-flags.m4
Which calls : CC_CHECK_CFLAGS_SILENT which does not use -Werror
However we do have CC_FLAG_VISIBILITY which does check for  -fvisibility=hidden with -Werror

So ran a test with the following change:
https://github.com/iWuzHere/libuv/commit/58b13b0dcc120faba25d48be9500a210c28c4bfa
CI for AIX: https://ci.nodejs.org/job/libuv-test-commit-aix/nodes=aix61-ppc64/71/console
output is much cleaner!
Will open up PR


Improve newVariableInstace and defineVariable defaultValue expressions

This commit enables newVariableInstance's to have non-constant default
value expressions.  These expressions are evaluated when the
newVariableInstance is created.
DAFFODIL-2352
This is WIP because dfdl:defineVariable defaultValue's also allow for expressions referencing other variables with default values (as long as they evaluate to a constant) and that currently causes a cirularity error to occur (see the commented out test case). This may involve so more low-level changes to 1) Get rid of the circularity error, and 2) Perform more thorough checking to see if the referenced variable's defaultValue expression evaluates to a constant.  I feel this may warrant a separate ticket, but wanted to bring this up for discussion and possibly allow the newVariableInstance fix to get into the 3.0.0 release.

This should be ready for a proper review.  Open to input on how best to handle the negative test cases that don't want to work in TDMLRunner.

DAFFODIL-2443 has been created for the TDMLRunner issues
DAFFODIL-2444 has been created for the unhandled exceptions when evaluating paths before the infoset exists.

+1 just a couple minor changes for comments that maybe you missed?


Route blueprint not working in Ember 2.13

The route blueprint is no longer working on Ember 2.13 and ember-cli-emblem 0.9.0
This is the error I get when I try to run ember g route test:
Cannot read property 'moduleName' of undefined
TypeError: Cannot read property 'moduleName' of undefined
    at __name__ ( ... /node_modules/ember-source/blueprints/route/index.js:35:30)
    at fileMapValues.map.token ( ... /node_modules/ember-cli/lib/models/blueprint.js:633:50)
    at Array.map (native)
    at Class.generateFileMap ( ... /node_modules/ember-cli/lib/models/blueprint.js:633:37)
    at Promise.then.customLocals ( ... /node_modules/ember-cli/lib/models/blueprint.js:827:26)
    at tryCatch ( ... /node_modules/rsvp/dist/rsvp.js:539:12)
    at invokeCallback ( ... /node_modules/rsvp/dist/rsvp.js:554:13)
    at  ... /node_modules/rsvp/dist/rsvp.js:629:16
    at flush ( ... /node_modules/rsvp/dist/rsvp.js:2414:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)

PS.: I have omitted my project's path and replaced with ...

For anyone facing the same Issue: I had the same error. As a temporary workaround, I just delete ember-cli-emblem entry in my package.json, generate route and add the package again. Works for me for the time being.
cc: @tmeloliveira @renatocarvalho @discandanty

same here with ember 2.14
thanks @dhilipsiva for the workaround
 ~/Projects/testing   master  ember g route about
installing route
Cannot read property 'moduleName' of undefined
TypeError: Cannot read property 'moduleName' of undefined
    at __name__ (/.../node_modules/ember-source/blueprints/route/index.js:35:30)
    at fileMapValues.map.token (/.../node_modules/ember-cli/lib/models/blueprint.js:634:50)
    at Array.map (native)
    at Class.generateFileMap (/.../node_modules/ember-cli/lib/models/blueprint.js:634:37)
    at Promise.then.customLocals (/.../node_modules/ember-cli/lib/models/blueprint.js:828:26)
    at tryCatch (/.../node_modules/rsvp/dist/rsvp.js:525:12)
    at invokeCallback (/.../node_modules/rsvp/dist/rsvp.js:538:13)
    at /.../node_modules/rsvp/dist/rsvp.js:606:14
    at flush (/.../node_modules/rsvp/dist/rsvp.js:2415:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)

I just started a new project and installed this using ember-cli 2.18.1, seems to work now. Perhaps something has changed since Ember 2.13 and 2.14?
Also, is this project dead?

Hi, @vburzynski. I work for Vestorly. While we are certainly happy to continue to accept PRs for this project, we are migrating away from using Emblem in our codebase and thus are not likely to continue to maintain it over the long term. We don't know if Emblem compiler will be continued to be supported through upcoming changes to hbs in Ember 3.0 either, given that its maintainer is no longer actively using it. I won't say it's dead, but I would be hesitant to recommend it for new projects.

Our organization makes heavy use of Emblem and I plan to continue helping maintain Emblem for the foreseeable future.  I'd be happy to help out with this project as well.

@Gaurav0 I would suggest you guys look for a new maintainer.

I made a fork a while back that fixes some issues in later Ember versions, it may have resolved this one as well: https://github.com/fizmo/ember-cli-emblem


Symlink full WAU Log folder to Intune

Proposed Changes
Currently only the WAU update log is being symlinked to the Intune folder. I would prefer to symlink the full WAU log folder, so that install/uninstall Logs from winget-install.ps1 are available through Intune too.
Related Issues

(Github link to related issues or pull requests)

Does Intune Management Extension collection of log files support sub folders?

Intended to do it by myself with this PR, but yes you are right. I have just tested it with my client and it only contains files, no folders which is sad. The new commit switched this to include the install.log too instead of the full folder which doesnt work.
Thank you for the hint.

Thanks you guys for your great help :)

Sorry, but...
install.log only exist if Winget-Install is used, but -ErrorAction SilentlyContinue takes care of that error.
But, how about README.md, Invoke-PostUpdateActions.ps1, Winget-AutoUpdate-Install.ps1 (Uninstall-WingetAutoUpdate) and WAU-Uninstall.ps1 (I've forgotten about that one too)?

Sorry, but... install.log only exist if Winget-Install is used, but -ErrorAction SilentlyContinue takes care of that error. But, how about README.md, Invoke-PostUpdateActions.ps1, Winget-AutoUpdate-Install.ps1 (Uninstall-WingetAutoUpdate) and WAU-Uninstall.ps1 (I've forgotten about that one too)?

Not sure to understand

And, I think $WorkingDir\logs\install.log is only correct in the upgrade, not in the install.

I agree. Maybe this should be set from winget-install project itself


fix(valuecard): datastate texts removed for size smallwide

Closes #304
Summary
The content of the data state rendering in the ValueCard did not fit in the available height of size SMALLWIDE. The flex column content was rendered differently in Chrome and FF. In Chrome the bottom padding was keps and the content was pushed upp overflowing into the card header (which kind of looked okay), but in FF the content was pushed down resulting in the bottom padding not being visible.
Change List (commits, features, bugs, etc)
Regardless of the difference between the browsers, the actual problem was that the content did not fit vertically, which has now been fixed by adding the SMALLWIDE to the same rendering as SMALL and MEDIUMTHIN.
Added a unit test that verifies the fix.
Acceptance Test (how to verify the PR)
Check the ValueCard stories with using size SMALLWIDE and make sure they look correct and the same in webkit browsers and FF

Is #304 the issue you meant to link? That's the old v2 epic issue.

@tay1orjones
Regarding the number 304. This is bit confusing to me. Here is the issue but it looks like it belongs to another tracker https://github.ibm.com/Watson-IoT/pal-tracking/issues/304

@bjornalm ah, yes. The github.ibm.com url is for our internal tracking. Use the full link when reference these issues to prevent mis-linking an issue present in this external github.com repo. Looks like you updated the original comment with the proper issue. 👍
Sorry for the confusion as we need to track issues for internal reporting purposes.

:tada: This PR is included in version 2.57.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Dimensionless SVG does not render in Firefox

This issue seems specific to Firefox.  In Chromium this works fine.  My tests are on Linux but I have confirmation this issue exists on Windows and MacOS as well.
Paste this example into the Sandcastle at https://sandcastle.cesium.com/; note that the SVG referenced has no top-level width nor height attributes.
var viewer = new Cesium.Viewer("cesiumContainer");
var collection = new Cesium.BillboardCollection();
viewer.scene.primitives.add(collection);
collection.add({
  position: Cesium.Cartesian3.fromDegrees(-75.59777, 40.03883),
  image: "https://raw.githubusercontent.com/lupomontero/psl/master/browserstack-logo.svg",
  width: 200,
  height: 200,
});

In Firefox width and height are 0 at this point for the SVG in question; in Chromium they are 300 and 65.  It's not clear where Chromium gets its "intrinsic" dimensions for SVGs that don't specify.  For some other "square" SVG I have, the intrinsic dimension is 150x150.  Chromium must be inspecting the viewbox/geometry and scaling to fit some internal sizing somehow or such.
https://github.com/CesiumGS/cesium/blob/master/Source/Renderer/Texture.js#L664

It seems this issue is related: https://github.com/whatwg/html/issues/3510.  Discovered via this issue to Firefox, marked as resolved and invalid: https://bugzilla.mozilla.org/show_bug.cgi?id=1328124
It may be possible to work-around this in CesiumJS by setting width and height if the loaded image has zero dimension and zero intrinsic dimension:
diff --git a/Source/Core/Resource.js b/Source/Core/Resource.js
index 4dba57ae1a..1972b21852 100644
--- a/Source/Core/Resource.js
+++ b/Source/Core/Resource.js
@@ -1865,6 +1865,10 @@ function loadImageElement(url, crossOrigin, deferred) {
   var image = new Image();

   image.onload = function () {
+    if (image.naturalWidth === 0 && image.naturalHeight === 0 && image.width === 0 && image.height === 0) {
+      image.width = 100;
+      image.height = 100;
+    }
     deferred.resolve(image);
   };

It looks like this isn't a Firefox bug as much as undefined behavior and different browsers handle it differently? Does this workaround make sense to be done at the application level instead? You can load your image and check if it has 0 width/height before passing it to CesiumJS:
var viewer = new Cesium.Viewer("cesiumContainer");
var collection = new Cesium.BillboardCollection();
viewer.scene.primitives.add(collection);

var image = new Image();
image.src = "https://raw.githubusercontent.com/lupomontero/psl/master/browserstack-logo.svg";
image.crossOrigin = "anonymous";
image.onload = function() {
  if (
      image.naturalWidth === 0 &&
      image.naturalHeight === 0 &&
      image.width === 0 &&
      image.height === 0
    ) {
      image.width = 300;
      image.height = 150;
    }

  collection.add({
    position: Cesium.Cartesian3.fromDegrees(-75.59777, 40.03883),
    image: image,
    width: 200,
    height: 200,
  });
};

Following the conversation about the issue is difficult without all of the context/knowledge of Firefox architecture to be honest.
It sounds like there are two issues at play, depending how far down the tech. stack you look.  Either way, it sounds like Firefox's behavior is "bad," and might need fixed at two different branches, leading to a yet undetermined UX: either what a typical user expects (a rendered SVG with no intrinsic dimensions), or an error message of some sort.
  It seems like it will bypass the Resource (request) queuing feature, but the cache will still function; do you agree?
The only other issue is that a client might have to blindly load a resource and not know the MIME type.  It looks like Billboard's image accepts a Resource too: it should be possibly to modify a Resource instance's fetchImage to perform the fix-logic and still use the queue and cache?


Question: fs implementation?

What is holding back adding an fs polyfill? I've seen many implementations for browser fs polyfills for node:

https://github.com/jvilk/BrowserFS
https://github.com/matthewp/fs
https://github.com/mafintosh/browserify-fs

Seems possible. Any reasons why this hasnt been done yet? I can PR for this.

I don't think there's a one-size-fits-all browser fs polyfill. a readFile call in the browser may have to do a request to a server like in BrowserFS, if the file is a template or image resource. If the file is a user configuration file, using a client-side store like browserify-fs makes more sense. that makes it difficult to pick a single polyfill.

I have my own fs polyfill, just for reference, it's here:
https://github.com/sumanjs/suman-browser-polyfills/blob/master/modules/fs.js
I generated it by looping through all the fs methods and just allowing for both a synchronous return and a callback. It seems to work ok, was quick and dirty.
Here is how I generated it:
https://github.com/sumanjs/suman-browser-polyfills/blob/master/lib/src/fs.js


fix for the crash

cam think signature changed from 85 C0 75 30 38 86 to 85 C0 75 30 38 87, thanks valve

my dick went from 2cm to -4 cm after this fix epic halal


Add custom backoff setter

Users should have the capability to customize the backoff pattern and accordingly adjust it within the retry mechanism.
@duke-git Have a look please

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2e1c227) 80.65% compared to head (aed455c) 80.63%.

Files
Patch %
Lines

retry/retry.go
60.00%
1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   80.65%   80.63%   -0.02%
==========================================
  Files          65       65
  Lines        7221     7226       +5
==========================================
+ Hits         5824     5827       +3
- Misses       1058     1059       +1
- Partials      339      340       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Investigate for hot reloading

Hot reloading is lost because I had to remove webpack dev server from CRA configuration in order to write the project files to the disk hence losing hot reloading feature. Let's see if there is a way to bring it back either through special mode with WDS or with a custom method.

Hi @Nargonath first of all, thank you for creating this library. Is really useful.
I am not too sure about my availability but if you give me some guidance I would be happy to investigate the hot reloading as well, and maybe submit a PR.
Right now when I apply some changes I need to open and close the chrome extension and is not really cool.
Thanks!!

Hey @apanizo! I'm glad this tool is useful to you, thanks for letting me know.
Actually now I think something can be done, perhaps we can even reintroduce webpack-dev-server because in one of the latest release they introduce an option to write on the disk instead of the memory. https://webpack.js.org/configuration/dev-server/#devserverwritetodisk-
IIRC create-react-app has also been updated with the version of WDS required to use that option. You would need to check their changelog to be sure though. If that's the case, we can try keeping WDS in the config, tweek the webpack configuration by adding that option and see how it goes.
Feel free to ping me if you need some more help or explanations. Thanks for your help. 👍

I have taken a look, and yes, the writeToDisk option is available on create-react-app.  If you take a look into the changelog, WDS was updated to 3.1.14, and the writeToDisk option was released in 3.1.10.
So after playing a bit with it, I am missing some points here 😅
When I run yarn watch everything seems to be fine, but if I open the extension I get this error:
Uncaught SyntaxError: The URL 'chrome-extension:beoefdfgfpliobcablom/sockjs-node' is invalid
    at new SockJS (main.js:70)
    at eval (webpackHotDevClient.js:53)
    at Object.../../node_modules/react-scripts/node_modules/react-dev-utils/webpackHotDevClient.js (0.chunk.js:1825)
    at __webpack_require__ (bundle.js:782)
    at fn (bundle.js:150)
    at Object.0 (main.chunk.js:113)
    at __webpack_require__ (bundle.js:782)
    at checkDeferredModules (bundle.js:46)
    at Array.webpackJsonpCallback [as push] (bundle.js:33)
    at main.chunk.js:1
__get-internal-source?fileName=webpack-internal%3A%2F%2F%2F..%2F..%2Fnode_modules%2Fsockjs-client%2Flib%2Fmain.js:1 Failed to load resource: net::ERR_FILE_NOT_FOUND
__get-internal-source?fileName=webpack-internal%3A%2F%2F%2F..%2F..%2Fnode_modules%2Freact-scripts%2Fnode_modules%2Freact-dev-utils%2FwebpackHotDevClient.js:1 Failed to load resource: net::ERR_FILE_NOT_FOUND

@Nargonath can you guess something?

I've been able to get a live-reload functionality working with my express app that uses create-react-app and wanted to share. It is not the same as HMR, but it does enough to help improve the developer experience for me.
Add chokidar to watch for file changes in the src directory and socket.io to emit "files changed" event
const socket = require('socket.io');
const chokidar = require('chokidar');

// Setup server
const port = '8080';
const server = app.listen(port, () => {
  console.log(`Server is running on: ${port}`);
});

// Setup file watcher to emit event to the client on './src' file changes
// Used to live-reload the web page
let io = socket(server)
io.on('connection', socket => {
  const buildDir = path.join(__dirname, '..', 'src');
  const watcher = chokidar.watch(buildDir);

  const watchHandler = () => {
    socket.emit("files changed");
  };

  watcher.on('ready', () => {
    watcher.on('add', watchHandler);
    watcher.on('change', watchHandler);
  });

  socket.on('disconnect', () => {
    watcher.close();
  });
});

And then in your client code, you need to listen for this "files changed" event and reload the current page.
Create a file named reload.js in your public directory and add the following.
// Open a connection.
var socket = io('http://localhost:8080');

// Listen for the event.
socket.on("files changed", function () {
  // delay to allow cra to build files before we reload
  setTimeout(window.location.reload.bind(window.location), 250);
});

Then in your index.html, add the following:
<% if(process.env.NODE_ENV !== 'production'){ %>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/2.3.0/socket.io.js"></script>
    <script src="reload.js"></script>
<% } %>

Sorry I don't have time to maintain this project anymore so I'll archive it and add a note in the README. Feel free to fork it as you see fit.


SDL2: 2.30.6 -> 2.30.9

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Yay! A mostly harmless refactor found a bug in the test packages!

Mental note: study the new Darwin SDK.

2.30.9 is out: https://github.com/libsdl-org/SDL/releases/tag/release-2.30.9

As far as I can see, the bugs are in the other packages. Let's wait.

Finally it is working!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4846


Optimize is_file_excluded with pygit2 if available

For repositories with many files, is_file_excluded() is the biggest
bottleneck since it has to be called for each file. git-check-attr is
actually pretty fast, so most of the time is just spent in the process
of shelling out to git.
We can use the pygit2 library (a wrapper around libgit2) if it's
available for a much faster check. In my testing of MediaWiki tarball
generation (a rather large case), is_file_excluded went from 117 seconds
of wall clock time to 1.5 seconds!
Since pygit2 can be a bit tricky to install as you need to have a
matching libgit2 version, only use it if it's already installed and fall
back to the current behavior of shelling out if not.
There are some other calls to git that could also use pygit2, however in
my profiling, none of those appear as hotspots, and the cost of shelling
out is negligible compared to the amount of time the command itself
takes.

I hope it's OK to optionally depend upon an external library like this. It wasn't very straightforward for me to install it (had to manually install a slightly older version, since Fedora is not using the very latest libgit), so I didn't think it would be that great to have a hard dependency on it.

The test failure (https://travis-ci.org/Kentzo/git-archive-all/jobs/431358381) looks like an issue with travis-ci.

Alternatively, git-archive-all could aggregate all the files and then check them all at once.

@legoktm Please try the version from the check-attr branch.