[5.2] Added RouteFound event

Fixes https://github.com/laravel/framework/issues/11496
Basically I added a RouteFound event, so that we can inject Controller namespace based on the HTTP api-version header before implicit bindings are resolved (RouteMatched is fired too late).
Route::found(function(RouteFoundEvent $event) {
    // modify $event->route as needed
});

Just had a thought. What if we implemented the parameter substitution via an event listener for that event?

By "parameter substitution" are you talking about what I was doing in my middleware or the parameter substitution that happens in implicit model binding?

Ping @taylorotwell. That would be so awesome. It would be cool if I could stop extending the router to stop the parameter substitution happening.
NB My use case is I perform non-read request locking on a per user basis, then, after a lock has been established, at that point, I do the param substitution, so I know the data is fresh.
NB The middleware that does the binding is here if anyone thinks that's a cool idea: https://github.com/AltThree/Locker/blob/master/src/Http/Middleware/LockingMiddleware.php.

Yeh, my use case is all bindings.

Yeah can y'all give code examples of these use cases?

Excuse me if this isn't what your looking for....im pretty new to core development. I have a middleware that replaces a placeholder in the "uses" with the api version namespace from the header. This is the handle method of the middleware:
public function handle($request, Closure $next)
	{
		$route = $request->route();
		$actions = $route->getAction();

		$requestedApiVersion = ApiVersion::get($request);
		if (!ApiVersion::isValid($requestedApiVersion)) {
			throw new ApiVersionException('Invalid API Version');
		}

		$apiNamespace = ApiVersion::getNamespace($requestedApiVersion);

		$actions['uses'] = str_replace('{api-namespace}', $apiNamespace, $actions['uses']);

		$route->setAction($actions);

		return $next($request);
	}

Currently, I extend the router:

Then I have a middleware that runs it:

Then, the middleware applied is looking something like this:
            LockingMiddleware::class,
            SubstituteBindings::class,

So, at this point I've already started the session, authenticated the user, acquired a lock, then only then do I subsisute the bindings. This also reminds me of that issue we had previously were some people were concerned about ddos attacks regarding this binding, specifically targetting the database.

Excuse me if this isn't what your looking for....im pretty new to core development.

No worries at all. Your middleware and use case looks pretty similar at the end of the day to mine. You, ultimately, one to have some sort of guard before then doing the bindings.

@GrahamCampbell Did you have something like that in mind?

Copying my thoughts from Slack
what is the difference between routeFound and routeMatched
[5:03]
those sound the same to me
[5:03]
in fact RouteMatched is fired just a few lines later
[5:04]
i dont really see why you need a separate event for this
[5:04]
instead of just substituting bindings in the route matched event
[5:04]
i also worry about attaching multiple listeners on this event in a unit testing scenario if the app is maintained across unit tetts

Taylor, the important difference is that it's before we query the database, so we can bail out first if we need to.

I'm not entirely sure that I really like this fix though.

Maybe this event isn't the way to go.

I'd much prefer to just fire a single event too.

I deleted the last commit that moved substituteBindings in an event. At least until we find a better solution.

Yhe event should not extend the other event.

@GrahamCampbell  Fixed.

@GrahamCampbell I understand if this isn't the fix you want but I would be interested in how you would solve my problem without it.
I require a header on calls to my API called 'api-version' and CURRENTLY a middleware that pulls that api-version and determines if its valid (according to my white list) and then, using a mapping, determines the namespace of this version. It then injects this version into a placeholder that I have on my routes. Ex: Route::get('member/{id}', '/whatever/{api-namespace}/MembersController@show');
With implicit model binding the '/whatever/{api-namespace}/MembersController@show' triest to get reflected and fails miserably because the implicit model binding gets run before middleware (as expected). Someone here decided it would be a good idea to listen to the routeMatched event and do my manipulation of the route there. However this event fires AFTER the implicit model binding and there are no events fired before.
All this I say as a "quick" description of what brought us to this point. If you have another solution for custom placeholder manipulation inside of the route "uses" attribute that doesn't cause implicit model binding to explode i am all ears. Or even if you have a better way of Api versioning that fits along the same lines but doesn't mess with the route?

So is this going to be pulled into 5.2 or should I just hack a workaround?

I still don't understand why you can't just move substituteBindings into a RouteMatched event. Why add a second event?

We can't do that because of this line  $parameters = (new ReflectionMethod($class, $method))->getParameters(); which happens on line 263 in Route.php in the method "signatureParameters". It happens BEFORE the RouteMatched event is called and tries to call a reflection of a string that would have custom bindings in it which fails miserably.

@taylorotwell am i not clarifying well enough? Do you have any more questions?

@acasar As it seems this won't be getting merged do you have any suggestions on how i might implement api versioning / namespacing using a header in the request?

@bgarrison25 Can't you just provide a valid namespace for a class (e.g. v1 by default) and then substitute it in the RouteMatched event if needed?

On the side note: In my experience, whenever I needed API versioning I always put the version in the URL. Sure it may not be a "best practice", but it's very flexible, easy to implement and many big companies are also using that approach... (Twitter, Facebook, etc.).

@acasar I would prefer to keep the version in the header. I have sort of built around it. Also, the issue with your proposed fix above is that I want the version of the api that they send in to determine the namespace of the controller. So if its v3 it will be App\Http\Controllers\v3....This is why all my routes had the {api-namespace} tag in them. The problem is I can't use custom tags anymore because when implicit model binding occurs it checks to see what the parameters of App\Http\Controllers{api-namespace}\FooController@Bar are. It tries to do a reflection call on that and obviously fails. This is why I was pushing for an event BEFORE implicit model binding....or even having the existing event happen before....whatever works best....but since that doesn't seem to be happening im not sure where to go....

@bgarrison25 To be honest, (after sleeping on it) I think that adding a new event would be confusing and is also quite a "hacky" way to achieve routing based on headers.
If you want to stick with header routing, then I'm afraid you'll need to develop some workaround. Maybe you could use a global middleware or App:before() filter? In this case you will of course need to inject the correct namespace into all of your API routes, since the current route is not resolved yet at that point.
Maybe in the future, we'll have some way of generically dealing with this problem. I imagine it could look something like this:
Route::group(['header' => 'Version:3'], function() {
    Route::get('...');
});

But of course someone would need to develop that.

In my opinion routing based on headers is a smell. That's (according to the spec) not what headers are for (unless you interpret "request modifer" as such).


Questionable ST quality on drosophylia sample

We wanted to test STAligner with drosophila sample E14-16h_a_count_normal_stereoseq.h5ad. adata.obs['slice_ID'] denotes a part of anndata object that refers to 1 of 16 slices. Raw counts are available in adata.layers['raw_counts'] and spatial info is in adata.obs.['raw_x', 'raw_y'].
We run the default configuration with rad_cutoff=30 (each cell has approx. 7.5 neighbors) and obtained the following result.
Is this expected behaviour and is there something that might be done to improve the quality?
Here is the ground-truth for these samples.
Here is the source code that we used to load the data:
from scipy import sparse
Batch_list = []
adj_list = []
adata_whole = sc.read('/goofys/Samples/Stereo_seq/flysta3d/E14-16h_a_count_normal_stereoseq.h5ad') #edit
section_ids = list(adata_whole.obs['slice_ID'].cat.categories)
adata_whole.X = adata_whole.layers['raw_counts'] # select raw counts gene matrix
adata_whole.X = sparse.csr_matrix(adata_whole.X) # STAligner expects to find sparse matrix here

for section_id in section_ids:
    adata = adata_whole[adata_whole.obs['slice_ID'] == section_id]
    adata.obsm['spatial'] = adata.obs[['raw_x', 'raw_y']].values
    adata.uns = {}
    adata.var_names_make_unique(join="++")

    # read the annotation
    adata.obs['Ground Truth'] = adata.obs['annotation']

    # make spot name unique
    adata.obs_names = [x+'_'+section_id for x in adata.obs_names]

    # Constructing the spatial network
    print("Cal Spa Net")
    STAligner.Cal_Spatial_Net(adata, rad_cutoff=30) # the spatial network are saved in adata.uns[‘adj’]

    # Normalization
    sc.pp.highly_variable_genes(adata, flavor="seurat_v3", n_top_genes=5000)
    sc.pp.normalize_total(adata, target_sum=1e4)
    sc.pp.log1p(adata)
    adata = adata[:, adata.var['highly_variable']]

    adj_list.append(adata.uns['adj'])
    Batch_list.append(adata)

adata_concat = STAligner.train_STAligner(adata_concat, verbose=True, knn_neigh = 50, device=used_device)

We run it with knn_neigh = 50 since each sample has around 500 obs
Rest of the code is the same as in Tutorial_DLPFC

Hi. Suggestions below may be helpful.

The n_top_genes is very import. We need to increase the number to ensure enough common HVGs (~1000) in the combined matrix. In the drosophila dataset, we suggest n_top_genes > 8000.

rad_cutoff=25  #each cell has approx. 4 neighbors

iter_comb = [(0, 8), (1, 8), (2, 8), (3, 8), (4, 8), (5, 8), (6, 8), (7, 8), (9, 8), (10, 8), (11, 8), (12, 8), (13, 8), (14, 8), (15, 8)] #middle slice 8 has the most common domains, use it as reference


Slider use number input

Overview
Helps resolve #278 from the react repo.
Changes the input on the slider to be a number input, and selects it on focus. Added some webkit styles to remove the increment / decrement arrows.
Testing / Reviewing
Verified in Chrome, Firefox, Safari. Input type=number isn't supported in Edge

Just realized the change to fix the old class name to .bx--slider-text-input might be a breaking change

@jamesvclements could you just make the selector .bx--slider-text-input, .bx-slider-text-input so that we don't break anyones code?

Looks good to me, thanks for that! 👍 ✅

👍 ✅


Error in MaxQuant converter

Hi,
I tried to run the MaxQuant converter with the sdrf file from here: https://github.com/bigbio/sdrf-pipelines/tree/master/sdrf_pipelines/testdata and a newly downloaded human uniprot fasta file:
parse_sdrf convert-maxquant -s sdrf_test.tsv -f /test_uniprot.fasta -m False -pef 0.01 -prf 0.01
results in:
None PROCESSING: sdrf_test.tsv" Traceback (most recent call last):   File "/home/meli/.local/bin/parse_sdrf", line 8, in <module>     sys.exit(main())   File "/home/meli/.local/lib/python3.8/site-packages/sdrf_pipelines/parse_sdrf.py", line 98, in main     cli()   File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 829, in __call__     return self.main(*args, **kwargs)   File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 782, in main     rv = self.invoke(ctx)   File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 1259, in invoke     return _process_result(sub_ctx.command.invoke(sub_ctx))   File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 1066, in invoke     return ctx.invoke(self.callback, **ctx.params)   File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 610, in invoke     return callback(*args, **kwargs)   File "/home/meli/.local/lib/python3.8/site-packages/click/decorators.py", line 21, in new_func     return f(get_current_context(), *args, **kwargs)   File "/home/meli/.local/lib/python3.8/site-packages/sdrf_pipelines/parse_sdrf.py", line 56, in maxquant_from_sdrf     Maxquant().maxquant_convert(sdrf, fastafilepath, matchbetweenruns, peptidefdr, proteinfdr,   File "/home/meli/.local/lib/python3.8/site-packages/sdrf_pipelines/maxquant/maxquant.py", line 690, in maxquant_convert     tempFolder_node.appendChild(doc.createTextNode(tempFolder))   File "/usr/lib/python3.8/xml/dom/minidom.py", line 1659, in createTextNode     raise TypeError("node contents must be a string") TypeError: node contents must be a string
Any idea where the error comes from?
Thanks,
Melanie

Hi,foellmelanie .Thanks for your testing. This should be the temporary file path is not specified, but I should set a default value, I will fixed these errors. Thanks

Hi @daichengxin
thanks for you feedback.
Now I set a file path:
parse_sdrf convert-maxquant -s sdrf_test.tsv -f test_uniprot.fasta -m False -pef 0.01 -prf 0.01 -t /tmp

and obtain the following error:
None
PROCESSING: sdrf_test.tsv"
Traceback (most recent call last):
  File "/home/meli/.local/bin/parse_sdrf", line 8, in <module>
    sys.exit(main())
  File "/home/meli/.local/lib/python3.8/site-packages/sdrf_pipelines/parse_sdrf.py", line 98, in main
    cli()
  File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/meli/.local/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/meli/.local/lib/python3.8/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/meli/.local/lib/python3.8/site-packages/sdrf_pipelines/parse_sdrf.py", line 56, in maxquant_from_sdrf
    Maxquant().maxquant_convert(sdrf, fastafilepath, matchbetweenruns, peptidefdr, proteinfdr,
  File "/home/meli/.local/lib/python3.8/site-packages/sdrf_pipelines/maxquant/maxquant.py", line 746, in maxquant_convert
    string.appendChild(doc.createTextNode(raw_Folder + '\\' + key))
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

Has the code been tested unter Linux? I use Ubuntu 20.04.1 LTS.
Thanks,
Melanie

I guess this needs to be changes are required=true:

@click.option('--raw_folder', '-r', help='raw data folder,please use \')

What does the \\ mean?

OK, I only considered running MaxQuant under windows, the mqpar.xml is different between linux and windows.

I assume many Linux users are using the MQ conda package: https://anaconda.org/bioconda/maxquant

Thanks. I will try to make the mqpar.xml file compatible with both versions @bgruening

Thanks! Please also try to use pathlib wherever possible, then we do not have problems with different path on Unix and Windows.

@bgruening @foellmelanie we have changed and merge the PR to fix this issue. We are planning to fix another bug related with  OpenMS converter to perform the final release.


Training for IMDB - Running out of patience

I am trying to train for the IMDB dataset, but only after a few epochs the training ends with the message Ran out of patience, which i guess is from early stopping. Can you recommend any hyperparamters I need to adjust to improve training?

I assume you are talking about training VAMPIRE. I would try adjusting the learning rate, vocab size, hidden size of the model. Learning rate will probably have the biggest impact on how long you train for.

thanks


Using a general LOS for adding an event detector and refactoring radiation pressure?

This is related to #1258 where the shadow_function was modified to use a general LOS implementation that could work for any two assumed point bodies whose position vector with respect to a central attractor is known.

Have a line_of_sight method in core that works for any general two position vectors. After this, maybe the shadow_function could now be removed. The new line_of_sight method could have the same code as the current shadow_function.
This might open a possibility to add a new event detector that detects whether any two orbiting satellites have a line of sight between them or not.

Additionally, I was wondering whether it would be a good choice to somehow use the output of eclipse_function to model radiation pressures? I thought of this since currently, the shadow_function assumes a point body whereas the eclipse_function takes into account the radius of the star. Maybe this could potentially sync the solar pressures and eclipse event detection implementations?
Thanks!

Have a line_of_sight method in core that works for any general two position vectors.

What would this new function take into account? The bodies of the Solar System?

To clarify: the line_of_sight you are proposing is the line_of_sight(r1, r2, R) you wrote in #1258?

To clarify: the line_of_sight you are proposing is the line_of_sight(r1, r2, R) you wrote in #1258?

Yes, exactly!

What would this new function take into account? The bodies of the Solar System?

This new method would aim to work for any two position vectors with respect to a central attractor (i.e. any body of the Solar System). Let us call this body_1. The two-position vectors (with respect to body_1) could be either of:

satellite_1, satellite_2
body_2, satellite

The first one could work for the satellite LOS event detector. The second one could replace the current main's shadow_function.
If it would be a good choice to use the output of eclipse_function in, say, radiation_pressure, the new method that I aim to propose here would work only for satellite_1-satellite_2 LOS.

Awesome!


Support of ImGuiMouseCursor

Change the cursor depending on GImGui->MouseCursor

Implement for BGFX backend with help of @bdumesnil.
Also work with OpenGL backend.

Add GLFW support.

Add cursor support for DX11 and OpenGL backends.


Update Lint and IntelliSense Table of contents

Haskell and PHP sections added.

Good catch, thanks! Merged


chore(sln):  upgraded to slnx #2150

@BigHoss thanks, would you like to resolve the conflict? There are some new projects added recently


Feature/localized text field hints

Resolves #28.

Thank you @jlaskowska for your contribution. Keep up the good work.


feat: XYplot default axis limits (PT-184867297)

PT Story: https://www.pivotaltracker.com/story/show/184867297

Sets a default range for axes with values from -10 to 10
Sets default axis labels of "x" and "y"
Axis tick, extent, and labels change when linked to match first and second columns of linked Table tile
Unlinking Table tile returns Graph tile to default view

@emcelroy if this is going to take any longer, we should pull the title fix out and make it is own PR. We really need to get the tests passing again in master so we can deploy new versions and QA can start testing the work for the 4.1.0 release.

@emcelroy if this is going to take any longer, we should pull the title fix out and make it is own PR. We really need to get the tests passing again in master so we can deploy new versions and QA can start testing the work for the 4.1.0 release.

I think it should just be a matter of using the appConfig from the environment.

Actually, I just noticed that there's one more thing you could do if you were so inclined -- the defaultContent() function that is registered in the content info takes an argument that includes the appConfig, so you could pass it down to createaGraphModel() as an argument -- but I'm also fine with saving that for another day in the interest of expediency.

Thanks. I spent a few minutes on this, but it wasn't coming together for me. So I opted to go with just adding the comment since this should get merged in ASAP.


Data race? uv__req_register vs. uv__req_unregister

I'm hunting ./src/threadpool.c:329: uv__queue_done: Assertion `uv__has_active_reqs(req->loop)' failed. which seems to be triggered by either an imbalance/corruption of the request queue - or by a problem of the request tracking itself.
If I look at uv__req_register and uv__req_unregister, I see non-atomic inc/dec. Is that fine because both functions must always be run over the same thread? Or is some lock protecting these calls which I missed so far. If not, we have a data race here that could cause the active_reqs.count to become corrupt.


drivers: mfd: gpio: adjust init priority

Take into account the SPI bus init priority that can be used for MFD drivers.

This one needs updating too:
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/watchdog/Kconfig.npm1300#L16

@gmarull would you mind taking a look at it?

some of these devices are I2C only, so why are they changed?

Due to MFD_INIT_PRIORITY change. Let me know if I'm wrong but I thought if they depend on that priority, they also should be changed accordingly.


Please upgrade kotlin version

Hello,
I got error The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher.
The following dependencies do not satisfy the required version:
project ':react-native-pager-view' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.30,
so, if you have time, can you upgrade kotlin version?
Thank.

You override kotlin version while setting it in your project   def kotlin_version = rootProject.ext.has('kotlinVersion') ? rootProject.ext.get('kotlinVersion') : project.properties['PagerView_kotlinVersion']

@AnhDTN were you able to fix the issue?

I am still facing the same issue..can any one please help here ?

You override kotlin version while setting it in your project
https://github.com/callstack/react-native-pager-view/blob/e01cd62017d5fb1de262f744ffd9d21b63179899/android/build.gradle#L3

See if you have defined your kotlin version with something like kotlin_version = '<version>' in your build.gradle. Then you need to change it into kotlinVersion since that is what react-native-pager-view defined in their script. And also check your android/app/build.gradle too.
It works for me.


xt/rakuast-compare.rakutest failures

Several files are failing this test currently:
https://github.com/rakudo/rakudo/issues/5618

[x] doc/Language/pod.rakudoc

https://github.com/rakudo/rakudo/issues/5617

[x] doc/Language/glossary.rakudoc
[x]  doc/Language/create-cli.rakudoc
[x]  doc/Language/ipc.rakudoc
[x] doc/Type/IO/Spec/Unix.rakudoc
[x] doc/Type/IO/Spec/Win32.rakudoc
[x] doc/Type/independent-routines.rakudoc

@lizmat  fixed these raku issues, closing ticket.


Update Composer dependencies (2021-06-17-00-04)

Visual regression test passed!
View the visual regression test report


Farmer Jobs JobsReborn problem

*Description of issue:
Hello, I do not understand my farming profession does not work ... For example the block:
carrots-7 does not work in game, when I break and when I put the block I get no level and it's like that for all the items
Spigot
1.12.2
JobsReborn

Show your Farmer job entirely

My configuration : https://pastebin.com/fiKaYpSt

Change carrots to carrot in Place action
Place:
  carrot:
    income: 1
    points: 1
    experience: 1

thanks for carrot, no't xp for break carrot

carrot-7 for carrot no't working :/

legacy_wheat
https://github.com/Zrips/Jobs/wiki/Legacy-items


perf: reduce the read and write of shared memory in the FusedAddRMSNormKernel

Use vec_t<float, VEC_SIZE> x_vec to reduce the number of read and write operations to shared memory.

On A800
Improve the precision of the FusedAddRMSNormKernel function #587
#python3 benchmarks/bench_fused_add_rmsnorm.py
batch_size:   1, hidden_size:   111, dtype: float16, latency:  9us, throughput:   0.071GB/s
batch_size:   1, hidden_size:   500, dtype: float16, latency:  8us, throughput:   0.366GB/s
batch_size:   1, hidden_size:  1024, dtype: float16, latency:  8us, throughput:   0.775GB/s
batch_size:   1, hidden_size:  3072, dtype: float16, latency:  9us, throughput:   2.081GB/s
batch_size:   1, hidden_size:  4096, dtype: float16, latency:  9us, throughput:   2.614GB/s
batch_size:   1, hidden_size:  8192, dtype: float16, latency: 11us, throughput:   4.622GB/s
---
batch_size:  19, hidden_size:   111, dtype: float16, latency:  8us, throughput:   1.079GB/s
batch_size:  19, hidden_size:   500, dtype: float16, latency:  8us, throughput:   4.848GB/s
batch_size:  19, hidden_size:  1024, dtype: float16, latency:  8us, throughput:   9.626GB/s
batch_size:  19, hidden_size:  3072, dtype: float16, latency:  9us, throughput:  27.505GB/s
batch_size:  19, hidden_size:  4096, dtype: float16, latency: 10us, throughput:  32.598GB/s
batch_size:  19, hidden_size:  8192, dtype: float16, latency: 11us, throughput:  56.068GB/s
---
batch_size:  99, hidden_size:   111, dtype: float16, latency:  8us, throughput:   5.729GB/s
batch_size:  99, hidden_size:   500, dtype: float16, latency:  9us, throughput:  23.173GB/s
batch_size:  99, hidden_size:  1024, dtype: float16, latency:  8us, throughput:  49.529GB/s
batch_size:  99, hidden_size:  3072, dtype: float16, latency: 10us, throughput: 125.046GB/s
batch_size:  99, hidden_size:  4096, dtype: float16, latency: 11us, throughput: 152.740GB/s
batch_size:  99, hidden_size:  8192, dtype: float16, latency: 13us, throughput: 241.902GB/s
---
batch_size: 989, hidden_size:   111, dtype: float16, latency:  9us, throughput:  49.054GB/s
batch_size: 989, hidden_size:   500, dtype: float16, latency: 11us, throughput: 181.884GB/s
batch_size: 989, hidden_size:  1024, dtype: float16, latency: 14us, throughput: 282.162GB/s
batch_size: 989, hidden_size:  3072, dtype: float16, latency: 26us, throughput: 461.995GB/s
batch_size: 989, hidden_size:  4096, dtype: float16, latency: 31us, throughput: 515.154GB/s
batch_size: 989, hidden_size:  8192, dtype: float16, latency: 54us, throughput: 597.058GB/s
---

Origin
#python3 benchmarks/bench_fused_add_rmsnorm.py
batch_size:   1, hidden_size:   111, dtype: float16, latency:  9us, throughput:   0.072GB/s
batch_size:   1, hidden_size:   500, dtype: float16, latency:  9us, throughput:   0.332GB/s
batch_size:   1, hidden_size:  1024, dtype: float16, latency:  9us, throughput:   0.713GB/s
batch_size:   1, hidden_size:  3072, dtype: float16, latency:  9us, throughput:   2.132GB/s
batch_size:   1, hidden_size:  4096, dtype: float16, latency:  8us, throughput:   2.989GB/s
batch_size:   1, hidden_size:  8192, dtype: float16, latency:  9us, throughput:   5.210GB/s
---
batch_size:  19, hidden_size:   111, dtype: float16, latency:  8us, throughput:   1.152GB/s
batch_size:  19, hidden_size:   500, dtype: float16, latency:  8us, throughput:   4.762GB/s
batch_size:  19, hidden_size:  1024, dtype: float16, latency:  8us, throughput:   9.507GB/s
batch_size:  19, hidden_size:  3072, dtype: float16, latency:  9us, throughput:  27.441GB/s
batch_size:  19, hidden_size:  4096, dtype: float16, latency:  8us, throughput:  38.120GB/s
batch_size:  19, hidden_size:  8192, dtype: float16, latency: 10us, throughput:  65.015GB/s
---
batch_size:  99, hidden_size:   111, dtype: float16, latency:  8us, throughput:   5.715GB/s
batch_size:  99, hidden_size:   500, dtype: float16, latency:  8us, throughput:  24.209GB/s
batch_size:  99, hidden_size:  1024, dtype: float16, latency:  8us, throughput:  48.887GB/s
batch_size:  99, hidden_size:  3072, dtype: float16, latency: 10us, throughput: 123.630GB/s
batch_size:  99, hidden_size:  4096, dtype: float16, latency: 10us, throughput: 158.446GB/s
batch_size:  99, hidden_size:  8192, dtype: float16, latency: 12us, throughput: 277.162GB/s
---
batch_size: 989, hidden_size:   111, dtype: float16, latency:  9us, throughput:  48.444GB/s
batch_size: 989, hidden_size:   500, dtype: float16, latency: 10us, throughput: 194.863GB/s
batch_size: 989, hidden_size:  1024, dtype: float16, latency: 12us, throughput: 332.859GB/s
batch_size: 989, hidden_size:  3072, dtype: float16, latency: 24us, throughput: 515.186GB/s
batch_size: 989, hidden_size:  4096, dtype: float16, latency: 28us, throughput: 575.327GB/s
batch_size: 989, hidden_size:  8192, dtype: float16, latency: 48us, throughput: 675.133GB/s
---

This PR
#python3 benchmarks/bench_fused_add_rmsnorm.py
batch_size:   1, hidden_size:   111, dtype: float16, latency:  9us, throughput:   0.077GB/s
batch_size:   1, hidden_size:   500, dtype: float16, latency:  9us, throughput:   0.333GB/s
batch_size:   1, hidden_size:  1024, dtype: float16, latency:  9us, throughput:   0.723GB/s
batch_size:   1, hidden_size:  3072, dtype: float16, latency:  8us, throughput:   2.258GB/s
batch_size:   1, hidden_size:  4096, dtype: float16, latency:  8us, throughput:   2.977GB/s
batch_size:   1, hidden_size:  8192, dtype: float16, latency:  9us, throughput:   5.382GB/s
---
batch_size:  19, hidden_size:   111, dtype: float16, latency:  7us, throughput:   1.162GB/s
batch_size:  19, hidden_size:   500, dtype: float16, latency:  8us, throughput:   4.775GB/s
batch_size:  19, hidden_size:  1024, dtype: float16, latency:  8us, throughput:  10.349GB/s
batch_size:  19, hidden_size:  3072, dtype: float16, latency:  9us, throughput:  27.543GB/s
batch_size:  19, hidden_size:  4096, dtype: float16, latency:  9us, throughput:  36.015GB/s
batch_size:  19, hidden_size:  8192, dtype: float16, latency: 10us, throughput:  63.313GB/s
---
batch_size:  99, hidden_size:   111, dtype: float16, latency:  8us, throughput:   5.806GB/s
batch_size:  99, hidden_size:   500, dtype: float16, latency:  9us, throughput:  22.935GB/s
batch_size:  99, hidden_size:  1024, dtype: float16, latency:  9us, throughput:  46.636GB/s
batch_size:  99, hidden_size:  3072, dtype: float16, latency: 10us, throughput: 124.325GB/s
batch_size:  99, hidden_size:  4096, dtype: float16, latency: 10us, throughput: 167.690GB/s
batch_size:  99, hidden_size:  8192, dtype: float16, latency: 12us, throughput: 273.261GB/s
---
batch_size: 989, hidden_size:   111, dtype: float16, latency:  8us, throughput:  52.296GB/s
batch_size: 989, hidden_size:   500, dtype: float16, latency: 11us, throughput: 185.426GB/s
batch_size: 989, hidden_size:  1024, dtype: float16, latency: 13us, throughput: 317.443GB/s
batch_size: 989, hidden_size:  3072, dtype: float16, latency: 24us, throughput: 503.647GB/s
batch_size: 989, hidden_size:  4096, dtype: float16, latency: 29us, throughput: 554.262GB/s
batch_size: 989, hidden_size:  8192, dtype: float16, latency: 49us, throughput: 660.946GB/s
---

This PR has essentially the same performance as the original, slightly lower than the original, but for the sake of precision, it can be improved by an order of magnitude (from 1e-2 to 1e-3), which I believe is acceptable.
cc @yzh119 @zhyncs

This PR has essentially the same performance as the original, slightly lower than the original, but for the sake of precision, it can be improved by an order of magnitude (from 1e-2 to 1e-3), which I believe is acceptable.

I  tested #587 , and if dtype=torch.bfloat16,  1e-3 is too strict

slightly lower than the original

@Abatom Could you clarify the main purpose of this PR, since it doesn't appear to focus on performance improvements? I'm also curious about any other potential benefits, as the accuracy improvements don't seem significant.

@zhyncs this PR uses vectorized load/store to shared memory to accelerate #587 .

@zhyncs this PR uses vectorized load/store to shared memory to accelerate #587 .

cool!


prompt(): Implement options.messages

This would introduce a new call signature. Instead of prompt(message: text, options: PromptOptions), introducing options.messages also introduces the call signature prompt(options: PromptOptions).
See #40 for specs

I'm gonna work on this one as it turns out it's necessary for function calling in order to not end up like this 🤣


What version of CUDA toolkit is required?

What version of CUDA toolkit is required?

We have tested cuOSQP on CUDA Toolkit versions 10 and 11. Which version do you use?

We have tested cuOSQP on CUDA Toolkit versions 10 and 11. Which version do you use?

Ver 9 with no luck. Thanks, that is helpful.
If we have Tesla K80 w/ 3.7 is it a lost cause?

Ver 9 with no luck. Thanks, that is helpful.
If we have Tesla K80 w/ 3.7 is it a lost cause?

I think we need compute capability version at least 5.2.

I think we need compute capability version at least 5.2.

What happens if you change compute_52 in
https://github.com/oxfordcontrol/osqp/blob/cuda-1.0/CMakeLists.txt#L121
to compute_37?

What happens if you change compute_52 in
https://github.com/oxfordcontrol/osqp/blob/cuda-1.0/CMakeLists.txt#L121
to compute_37?


Adding InferenceClient.get_recommended_model

Closes https://github.com/huggingface/huggingface_hub/issues/1767

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[CI] E2E Core workflow update

Signed-off-by: Gaurav Chadha<EMAIL_ADDRESS>Description
Ports the Cilium to the new core e2e workflow
This PR fixes https://github.com/meshery/meshery/issues/5529
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Signed-off-by: Gaurav Chadha<EMAIL_ADDRESS>Description Ports the Cilium to the new core e2e workflow
This PR fixes meshery/meshery#5529
Notes for Reviewers
Signed commits

[x]  Yes, I signed my commits.

@Chadha93 Can you just change 'This PR fixes' to 'This PR is a part of' so that it doesn't close the issue on merge


Segfault in String.find() (maybe linked to #1146)

Hello. I had a segfault running this code:
use "ponybench"

class BuiltinFinder
  let _n: String
  let _h: String
  new val create(needle: String, haystack: String) =>
    _n = needle
    _h = haystack

  fun box apply(): ISize => try _h.find(_n) else -1 end

actor Main
  let bench: PonyBench
  new create(env: Env) =>
    bench = PonyBench(env)

    var needle = "x"
    var haystack = "y"
    bench[ISize]("builtin", BuiltinFinder(needle, haystack))

I couldn't narrow the LoC using Debug.out() traces, yet (I guess in ponybench) because the error doesn't happen when I compile in debug mode (ponyc -d).
# ponyc --version
0.3.0-5-gb2cdd03 [release]

# llvm-ar-3.8 --version
LLVM (http://llvm.org/):
  LLVM version 3.8.0

  Optimized build.
  Built Mar  8 2016 (11:05:43).
  Default target: x86_64-pc-linux-gnu
  Host CPU: broadwell

note, the segfault happens only when there's no match in find. I guess the try...else...end block is suspicious.

If I use a lambda instead of a callable object it works fine:
actor Main
  let bench: PonyBench
  new create(env: Env) =>
    bench = PonyBench(env)
    bench[ISize]("builtin", lambda(): ISize => try "x".find("y") else ISize(-1) end end)

the error appends here : https://github.com/ponylang/ponyc/blob/master/packages/ponybench/_bench.pony#L15
I suspected DoNotOptimise at first, but a simple call f() segfaults too.
I Couldn't find a code example that fails without ponybench. It has to do with the way the callable expression is passed around internally.

I ran this through lldb and got the following output:
Process 11098 launched: '/home/theodus/stuff/test/test' (x86_64)
Process 11098 stopped
* thread #2: tid = 11102, 0x0000000000000001, name = 'test', stop reason = signal SIGSEGV: invalid address (fault address: 0x1)
    frame #0: 0x0000000000000001
error: memory read failed for 0x0

@Theodus can you run with a debug compiler in debug mode and put the backtrace after the SIGSEGV in here?

Here is the backtrace:
* thread #2: tid = 23030, 0x0000000000000001, name = 'test', stop reason = signal SIGSEGV: invalid address (fault address: 0x1)
  * frame #0: 0x0000000000000001
    frame #1: 0x0000000000402fe6 test`ponybench__Bench_ISize_val_Dispatch + 182

Here is the output with a breakpoint at ponybench__Bench_ISize_val_Dispatch:
Process 23026 exited with status = 9 (0x00000009)
Process 23179 launched: '/home/theodus/stuff/test/test' (x86_64)
Process 23179 stopped
* thread #2: tid = 23183, 0x0000000000402f30 test`ponybench__Bench_ISize_val_Dispatch, name = 'test', stop reason = breakpoint 1.1
    frame #0: 0x0000000000402f30 test`ponybench__Bench_ISize_val_Dispatch
test`ponybench__Bench_ISize_val_Dispatch:
->  0x402f30 <+0>: pushq  %rbp
    0x402f31 <+1>: pushq  %r15
    0x402f33 <+3>: pushq  %r14
    0x402f35 <+5>: pushq  %r13

Here is the output with the breakpoint when compiled in debug mode:
Process 23482 launched: '/home/theodus/stuff/test/test' (x86_64)
Process 23482 stopped
* thread #2: tid = 23487, 0x0000000000402c00 test`ponybench__Bench_ISize_val_Dispatch, name = 'test', stop reason = breakpoint 1.1
    frame #0: 0x0000000000402c00 test`ponybench__Bench_ISize_val_Dispatch
test`ponybench__Bench_ISize_val_Dispatch:
->  0x402c00 <+0>: subq   $0x58, %rsp
    0x402c04 <+4>: movl   0x4(%rdx), %eax
    0x402c07 <+7>: testl  %eax, %eax
    0x402c09 <+9>: movq   %rsi, 0x50(%rsp)

Is that from a debug person of the compiler? It looks like it came from a release version.

I'm using the command /usr/local/ponyc/build/debug/ponyc. It was compiled using make config=debug. Is there something else that I need to do in order to make a debug version of the compiler?

create a debug version of the binary you are running.
ponyc --debug

frame #0: 0x0000000000000001

We're jumping to a very wrong address here. I'll look into it later.

A debug binary runs without a segfault.

Here's the simplest failing code I could write ( uses only builtin )
class BuiltinFinder
  let _n: String
  let _h: String
  new val create(needle: String val, haystack: String val) =>
    _n = needle
    _h = haystack

  fun box apply(): ISize => try _h.find(_n) else ISize(-1) end

actor Runner
  let _env: Env

  new create(env: Env) =>
    _env = env

  be apply(f: {(): ISize} val) =>
    _env.out.print("start")
    f()
    _env.out.print("done")

actor Main
  new create(env: Env) =>
    let l: {(): ISize } val = lambda(): ISize val => try "x".find("y") else -1 end end
    let f = BuiltinFinder("x", "y")
    let r = Runner(env)
    r(l)
    r(f)

The lambda works well while apply() segfaults. Output:
start
done
start
zsh: segmentation fault ./tests

Hmm, ok so... @Theodus that tells us something at least.

This doesn't segfault for me with LLVM 3.6 but it does with 3.8

It looks like something in LLVM really doesn't like llvm.invariant.start, and that thing is reacting by stomping landing pads for exception handling. Maybe we're using llvm.invariant.start wrong but I can't find anything in the documentation. I think I'll just remove it from code generation, it shouldn't have any noticeable effect on optimised programs since we have a quite precise type-based alias analysis.

:/ the code in https://github.com/ponylang/ponyc/issues/1186#issuecomment-244120040 still segfaults
ponyc --version
0.3.0-14-gd8c6c55 [release]

And, i checked, it runs fine with --debug

Sorry for that, I thought I had reduced your example to a more minimal case but apparently there are multiple factors here. I can't find anything wrong in the generated IR. Since it works with LLVM 3.6 maybe it's a bug within LLVM?
If somebody else wants to look into it, the bug is sometimes appearing during pony_throw (when raising an exception and unwinding the stack). At some point, the saved instruction pointer for the return address of the function that called pony_throw is modified to 0x1.

So, here's the workaround, at the moment if you're stuck: compile with llvm 3.6
make LLVM_CONFIG=llvm-config-3.6 LLVM_LINK=llvm-link-3.6 LLVM_OPT=opt-3.6
sudo make install

or ( depending on your distribution)
make LLVM_CONFIG=llvm-config36 LLVM_LINK=llvm-link36 LLVM_OPT=opt36
make install

Here's a reduced example if it helps:
actor Main
  new create(env: Env) => Foo.test()

actor Foo
  let h: String = ""

  be test() => try h.find("x") end

There's no segfault if any of these are true:

If h is not a field of Foo
If we throw our own error manually: try h.find("x"); error end
If we use a different method to get the error: try h.i32() end

As another data point, there is no segfault if h is assigned by calling the String constructor rather than using a string literal.

Using Clang instead of Ponyc for the machine code generation solves the problem. That means the issue is on our side. I'll keep looking.

Some more data.
actor @Foo
  be test() => try error end

Building this actor as a library and sending a message for test from C results in _Unwind_RaiseException failing with error code _URC_END_OF_STACK. That means the exception handling code reached the end of the call stack without finding a suitable landing pad.

It also works with LLVM 3.7, so the breaking change is somewhere in LLVM 3.8.

I just tested this out on OSX with LLVM3.8.
Does not happen on OSX.

@Praetonus did you test with LLVM 3.8.0 or 3.8.1 ?

@Theodus do you have 3.8.1 installed now? can you test this and see if going from 3.8.0 to 3.8.1 fixes this?

With LLVM 3.8.1 it still works when compiled with the -d flag otherwise it segfaults.

So no change @Theodus ?

@SeanTAllen no change

@SeanTAllen I used LLVM 3.8.1.

I've made some progress on this. The assembly code generated by ponyc and by clang (with IR from ponyc) is different.
For @Perelandric's minimal example we get this from ponyc
Foo_Dispatch:
        cmpl    $1, 4(%rdx)
        je      .LBB6_1
.LBB6_4:
        retq
.LBB6_1:
        pushq   %rax
        callq   pony_throw
        addq    $8, %rsp
.LBB6_3:
        jmp     .LBB6_4

and this from clang
Foo_Dispatch:
        subq    $40, %rsp
        cmpl    $1, 4(%rdx)
        movq    %rsi, 32(%rsp)          # 8-byte Spill
        movq    %rdi, 24(%rsp)          # 8-byte Spill
        jne     .LBB3_2
        addq    $40, %rsp
        retq
.LBB3_2:
        callq   pony_throw
        jmp     .LBB3_3
.LBB3_3:
.LBB3_4:
        movq    %rdx, 16(%rsp)          # 8-byte Spill
        movq    %rax, 8(%rsp)           # 8-byte Spill
        addq    $40, %rsp
        retq

The thing is, when we exit from pony_throw, we skip the instruction right after it. So the code from ponyc doesn't restore the stack correctly and jumps to a garbage address.
I still have no idea why the code is different but it seems that the problem can be solved by shifting the landing pad by one instruction. I don't know why the landing pad is placed that way, maybe this is the bug.

Update: compiling from IR to assembly with clang with -O3 gives the same code (and the same crash) as ponyc. The bug is definitely coming from the landing pad location.

Apparently it only occurs in small functions with conditional branching (tested only on x86_64).

I've looked at the personality function for C++ in GCC and it does the same thing we're doing for the relevant part.
The problem appears to be in the LSDA data, the landing pad offset (retrieved at lsda.c:232) can be off by one instruction.
I'm a bit lost at that point. A bug in the LSDA generation seems unlikely but I don't really see what else could be wrong.

@Praetonus any status on this?

@SeanTAllen No, I've forgotten to open a bug report on LLVM's tracker. I'll do it in the next coming days.

Updated code for this based on lambda change:
class BuiltinFinder
  let _n: String
  let _h: String
  new val create(needle: String val, haystack: String val) =>
    _n = needle
    _h = haystack

  fun box apply(): ISize => try _h.find(_n) else ISize(-1) end

actor Runner
  let _env: Env

  new create(env: Env) =>
    _env = env

  be apply(f: {(): ISize} val) =>
    _env.out.print("start")
    f()
    _env.out.print("done")

actor Main
  new create(env: Env) =>
    let l: {(): ISize } val =  {(): ISize val => try "x".find("y") else -1 end }
    let f = BuiltinFinder("x", "y")
    let r = Runner(env)
    r(l)
    r(f)

@Praetonus did you open the issue for this on the LLVM tracker? If yes, can you reference it here?

@Praetonus says he is going to open the LLVM bug report this week.

I think I found the root of the issue. LLVM marks the crashing function as nounwind, which results in the landing pad address being incorrect. If I remove the nounwind attribute manually, the landing pad is generated correctly. I'll sum up all the info gathered in this thread and open that long overdue bug report.

LLVM bug opened: https://bugs.llvm.org/show_bug.cgi?id=36513

The bug has been fixed, the fix will be part of the next LLVM release.


when I deployed to local folder,run error

debug is ok，but release show not load "AppConfiguration" information
why?

I solved it


Flaky test: throttle_63_test

FAIL: //modules/canbus/vehicle/lincoln/protocol:throttle_63_test (see /home/siyangy/.cache/bazel/_bazel_siyangy/9ed9c7603857b144a49c9eb873c44a13/execroot/apollo/bazel-out/local-dbg/testlogs/modules/canbus/vehicle/lincoln/protocol/throttle_63_test/test.log).
INFO: From Testing //modules/canbus/vehicle/lincoln/protocol:throttle_63_test:
==================== Test output for //modules/canbus/vehicle/lincoln/protocol:throttle_63_test:
Running main() from gmock_main.cc
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from Throttle63Test
[ RUN      ] Throttle63Test.General
modules/canbus/vehicle/lincoln/protocol/throttle_63_test.cc:32: Failure
Value of: cd.gas().throttle_enabled()
Actual: true
Expected: false
[  FAILED  ] Throttle63Test.General (0 ms)
[----------] 1 test from Throttle63Test (0 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] Throttle63Test.General
1 FAILED TEST
The failure disappeared after I rerun it. @lianglia-apollo

The data in lincoln/proto tests should be fixed. Will fix this issue soon.


Best way to get list of the components with their state

Hi all, I want to make a live-patch module for browserify (like https://github.com/Kureev/browserify-react-live but for deku), and as far as I can't take react-hot-api library from Dan Abramov, I would need to implement the same for deku. Could you help with considering best way to do it?

I've been trying to figure out a way to get live reloading working. We could expose an API for it. Would you need every instance that deku has created? We store this in an entities object. It would be pretty easy to expose that, but there might be more we need to do.

In react we're able to get tree of mounted components and retrieve their state to preserve it for updated components. So it works like this: exclude state -> replace component -> apply state. Now it's all about how to extract and apply state. Mb some inner implementation which allow me to do it? (Not sure it should be public)

The state of all of the components will be stored on a single object that you'll be able to access. It's just an object with the mount id as the key and the state object as the value. We could expose methods for manipulating the state so that re-renders are triggered.
I'd probably need to know in more detail what happens to make it work. But it shouldn't be too tricky.

If you store component's state outside from component instance - it makes live-patch even easier! In classic variant it works like this: on change we replace mounted components(their prototypes) by new ones we got thru web sockets, then emit global forceUpdate. We can start from this I guess.

If you're interested how it works on browserify level etc, you may [take a look here].(https://github.com/Kureev/browserify-patch-server)

Take a look at amok (http://amokjs.com)
Disclosure, I'm the author.

This should be much easier to do now that components are all stateless. I want to get an example repo up and running showing how it's possible.

This just work now. We have some docs on the site. :boom:


Unsuccessful deployments show up as successful when deploying from modeler

If I deploy a model directly from the modeler, it says "Deployment was done successfully" even if this was not the case. My engine complained with a BPMN parse error and did not deploy the diagram, but the modeler did not catch that problem.
v 1.16.0

Would be extremely helpful to surface model parsing errors in the modeler. I see errors using the API but modeler just says deployment succeeds for the same file.

Perhaps, it happens because deployment endpoint responds with 2 HTTP statuses? E.g. this is what happens when I try to deploy a definition with a process-level Event Subprocess triggered by a Compensation Start Event (not supported according to the doc): first 100, and then 500 status is sent:
> POST /engine-rest/deployment/create HTTP/1.1
> Host: localhost:8081
> User-Agent: curl/7.55.1
> Accept: */*
> Content-Length: 12747
> Expect: 100-continue
> Content-Type: multipart/form-data; boundary=------------------------75a62bae9b8408af
>
< HTTP/1.1 100
< HTTP/1.1 500
< Content-Type: application/json
< Transfer-Encoding: chunked
< Date: Sun, 23 Sep 2018 20:24:26 GMT
< Connection: close
<
{"type":"ProcessEngineException","message":"ENGINE-09005 Could not parse BPMN process. Errors: \n* event subprocess with compensation start event is only supported for embedded subprocess (since throwing compensation through a call activity-induced process hierarchy is not supported) | testprocess.bpmn | line 30 | column 48"}* Closing connection 0```

Closed via https://github.com/camunda/camunda-modeler/pull/1041.


Fixes tcptype with raddr and rport.

Seems tcptype is no working in the following example:
a=candidate:4 1 TCP<PHONE_NUMBER> <IP_ADDRESS> 9 typ srflx raddr <IP_ADDRESS> rport 9 tcptype active
Example taken from taken from http://tools.ietf.org/html/rfc6544#appendix-C.
(Credits to @bgrozev and @gpolitis)

More tcptype fixes with references. Appreciate it :+1:
Will publish later.

Landed in<EMAIL_ADDRESS>


View/Edit User screen is a mixture of differing font sizes

so it looks a bit odd

I've made the copy for audit and recent activity slightly smaller and I think that looks slightly better.
If you'd like anything else changed please let me know but also please be more specific and provide reasoning.


blockfrost api.epochsStakesByPoolIdAll it sometimes gives me wrong data.

I am fetching delegators data using blockfrost api.
This is the function I use.
API.epochsStakesByPoolIdAll(epochNumber, poolId);

And it sometimes gave me wrong data (less than real)
When I test at the very begining of epoch, and test with that epoch number.
For example, now epoch 436 just started, and I call
API.epochsStakesByPoolIdAll(436, poolId);

then it gave me wrong data (less than actual delegators)
Does this api need some time to prepare all of its data from blockchain?

Hi @golddydev, sorry for the late reply. Are you still experiencing issue? Could you post an example of the call and inccorect response?

@golddydev If you still have the issue, feel free to reopen.

Yeah, it is fixed, now.


[WFLY-19471][WFLY-19472] WildFly Preview EE 11 Servlet and Security API updates

https://issues.redhat.com/browse/WFLY-19471
https://issues.redhat.com/browse/WFLY-19472
Tested with WFP-centric CI via #17985 #17986 #17987

Thanks @darranl


Repo view: Show icon for different original language

In case an objects has a different original language than the main language of the repository, an icon will be shown after the object. On hover, you can see the original language.
Needs https://github.com/open-abap/open-abap-core/pull/677
Example:
Repo main language = English
Object = German

Ref https://github.com/abapGit/abapGit/issues/5624
Similar to https://github.com/abapGit/abapGit/pull/5514

It's the same as adding srcsystem, so I knew which places to adjust :-)
Theoretically, we could get rid of item and just use tadir since it's now a 1:1 mapping.

I share the same concern, but think this PR is ok to merge


[VS Code] Starting collaboration session: Could not connect to the server. HTTPS connection failed, verify there are no self-signed certificates or custom cert validation policies blocking Live Share.

Error:
Starting collaboration session: Could not connect to the server. HTTPS connection failed, verify there are no self-signed certificates or custom cert validation policies blocking Live Share.
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.766

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.37.1

platformName
Linux

platformVersion
4.19.0-parrot4-28t-amd64

Hey @BlackZacky , did you check out our connectivity guidance here?

Closing due to inactivity. Please re-open if this you're still encountering the issue and can share more details. Thanks!


yaml2ics: Allow a "timezone" option within each event.

I at first tried using the yaml datetime "+03:00" explicit offset.
But, this created an output that worked in Google
Calendar/Thunderbird, but not office 365 cloud.  The problem seems
to relate to the quoting of "UTC +03:00" in one place but not the
other (and, as it turns out, it didn't work with either quotes
there, or no quotes there!)
I had made the idea in this PR earlier, but didn't submit it because
"less is more".  But now this seems simpler (and more explicit
somehow).
Changes are minimal and it just worked in one of my test casse.
There is no effect if 'timezone' is not given in an event.
Review: decide if this is a good idea or not.  Is there any simpler
way to implement it?

Black needed to be bumped, see the top of the description at https://github.com/psf/black/issues/2964
This needs to be done anyway, if this isn't accepted I will make a separate PR.

Thanks!


Feature Tracking: Add support for maps and lists

Description

Feature tracking can now support maps and lists.
Related issue

b/258211839
How has this been tested?

Unit tests and integration tests.
Checklist:

Unit tests

[ ] Unit tests do not apply.
[x] Unit tests have been added/modified and passed for this PR.

Integration tests

[x] Integration tests do not apply.
[ ] Integration tests have been added/modified and passed for this PR.

Documentation

[x] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[x] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

Adding @braydonk to help share the review load


Specify username when getting Pagure projects

PagureService.get_project() calls PagureService.get_username() in case
a username keyword argument is not specified. But the way projects are
used in dist2src context, these calls are superfluous—projects don't
need an associated username—and they often fail. Specify a username in
order to avoid them.
Signed-off-by: Hunor Csomortáni<EMAIL_ADDRESS>

recheck


[BUG] Messages are no longer being sent in groups

Due to a new whatsapp update, my bot no longer sends messages in groups. Is there anyone else with this problem?

I was also having this problem, I solved it by informing the version 2.2318.11 in the baileys-version.json file


GH-17211: [C++] Add hash_64 scalar compute function

We would like to expose hashing functions via new compute functions. This PR would add a scalar compute function, FastHash32, which uses Hashing32::HashMultiColumn to compute a 32-bit hash for each row of the input array (or scalar).
This PR focuses on 32-bit hashing, but I would like to use this PR to help decide if a different design is preferable before adding 64-bit hashing. I also am not sure what should be in the unit test except for code coverage.
Potential design changes:

Using an Options argument.
Using an init function for the kernel (but I don't know the input length until run time).
Changing how hashing is used.

Confusion about unit tests:

I'm not sure how to validate the hash outputs are "as expected". Further, unit tests for the hashing functions don't seem to validate hash outputs.
I'm not sure validating the output data types is necessary.
Code coverage of the various input types seems to be the most important, but I need help to figure out the best way to approach this.

Edit (8/9/22):
This PR has been open awhile but seems to have hit a good level of functionality. This PR does not:

address whether the hash functions are "acceptable" statistically
comprehensively benchmark, or test, the various data types

I think these can be addressed in future improvements:

ARROW-16017
Closes: #17211

I'm not sure how to validate the hash outputs are "as expected". Further, unit tests for the hashing functions don't seem to validate hash outputs.

For a hashing function I would expect:

If two values are equal then their hashes are equal
Given a random selection of non-equal values there should be some kind of expected false positive rate (e.g. equal hashes on unequal values).  Ideally we would include, as part of this, a benchmark that measures the FPR on random values.  You could then take then, pick a safe threshold (e.g. if the benchmark tends to show a 5% FPR then pick 10%) and put that into the unit test (e.g. assert the FPR is less than the safe threshold).

@save-buffer would you mind reviewing this when you get a chance?

I renamed this PR for ARROW-16945, so that I can track just a 32-bit version for now. Not sure if this will confuse some of the automated issue tracking/associations

Why 32-bit rather than 64-bit?

Why 32-bit rather than 64-bit?

I think Weston mentioned 32-bit in passing and I just made a semi-arbitrary decision to start there. I plan on following this up with a 64-bit version, though not sure if other things should be addressed before I do so (memory management, etc.).

There's https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/hashing_benchmark.cc at least

Thanks @pitrou , I'll start with that as a base and add benchmarks that use the utilities from key_hash.h (I'll see if these also exist elsewhere).
I recently was exposed to hashing.h when looking at the count_distinct function, so I should be able to compare them. Maybe I'll skeleton another compute function, StandardHash (arbitrary, temporary name to distinguish from FastHash), and we can use it to better consider how many hash functions we should have vs what should be knobs available via an Options class.

rebased

I wanted to update with initial changes to hashing_benchmark.cc. To make sure comparisons covered at least a few cases, I decided to add FastHash64, although it is currently very copy pasta.
Barring code style/organization improvements, I was hoping to get some feedback on whether these benchmarks are fundamentally what we would like to see. Some questions I have:

how do I ensure I am not including the time to construct an arrow::Array from a vector in the benchmark time?
do we want to time calling the function, or just the mechanisms that the compute function wraps?

do we want to do both to also capture any overhead in compute kernel invocation?

Also, I see now that util/hashing.h wraps xxHash, vendored from Cyan4973's github repo. Hashing32 has the following comment above it:
// Implementations are based on xxh3 32-bit algorithm description from:
// https://github.com/Cyan4973/xxHash/blob/dev/doc/xxhash_spec.md

I need to experiment a bit, but I suspect that for int primitives, Hashing32 and Hashing64 just wrap xxHash and add logic for iterating over rows and columns. Specifically, key_hash.cc#L745 looks a lot like hashing.h#L88. hashing_benchmark.cc#L70 benchmarks using 2 multipliers, and I think if it uses just the 1 multiplier then the implementation looks a lot like Hashing64.
All this to say that I think it should be accommodated in the benchmark, but I also wonder if some of the hashing code can be simplified/better organized in case they aren't as independent as they seem at first glance.

Here is my understanding, which may not be complete:
util/hashing.h is a more-or-less direct adapter between Arrow and xxhash.
key_hash.cc is based on xxhash but most of the algorithms have been reimplemented to some degree. The key_hash.cc utilities are, in theory, better suited to take advantage of columnar formats and/or vectorized CPUs.  However, as part of this rewrite, certain sacrifices were made in hash quality, in favor of performance.  This is primarily (only?) used today in Acero for the hash-join and hash-aggregate.
In theory, util/hashing.cc should have a better distribution but worse performance than key_hash.cc.

Weston is correct, the key_hash interface is only meant for internal use of hash tables. It subtly doesn't match xxh in some cases (iirc it for example can pad with 0's instead of having special handling for arbitrary lengths). The interface is also optimized for hashing in mini batches and reusing as much memory as possible. In general I would suggest using util/hashing instead of key_hash, as key_hash is for internal use; we may want to change it at any time (e.g. we had an idea to see if we can make a really crappy hash that's very fast to compute but is "good enough" for a hash table).
I can leave a review of the current code, but I'd suggest moving away from the key_hash interface overall.

Biggest feedback is to not allocate a large temporary std::vector and instead write directly into the buffer you'll be returning. Also you made your TempVectorStack way too big.

thanks! I had troubles with smaller sizes and tried to not size it too large, but I'll revisit.
For writing directly into the buffer to return, I assume that means I need to create an ArrayData? is there a better interface via Builders?

never mind, you actually mentioned how to do it already. the mobile interface hid it

util/hashing.h is a more-or-less direct adapter between Arrow and xxhash.

That's how it ended up working in practice for non-tiny strings, but the basic objective is to have some fast though statistically good hash functions.

@drin could you please add an entry for this function in the Compute Functions docs (cpp/compute.rst)? Thanks!

@ursabot please benchmark lang=C++

before figuring out the conbench stuff, I put some of the local benchmark results in a google slide:
https://docs.google.com/presentation/d/1cUU_F3jB6LsOLbClhl34YdQiodtbz7l76l3juHTsC5k/edit#slide=id.g13e9d117f47_0_63
Just wanted to put this in as a sneak peek even though the test size is small (10,000 items) and this is only for a couple primitives.

@ursabot please benchmark lang=C++

sorry, renaming to match the PR back to ARROW-8991. Since I am already trying to accommodate 64-bit, it didn't make sense to keep the smaller scope that the sub-task was meant to capture. I'll try not to scope creep too much though

This PR is ready for review. based on how long this has been opened, I tried to get important coverage through util/hashing_benchmark.cc and handle the main data types.
This PR does not:

address whether the hash functions are "acceptable" statistically
comprehensively benchmark, or test, the various data types

I think this PR is mostly a first pass at creating some hash functions that can be called through the compute API.
I will create a few issues related to ARROW-8991 to track future improvements

@ursabot please benchmark lang=C++

rebased on master for reviewer's convenience

Why is this exposing 3 different hash functions instead of one? Is there a use case for it?

It was so that I could have some reference points when adding to the benchmarks, to compare using key_hash.h and hashing.h. I wanted to see what the overheads of the compute API were for each, as well as how fast they were without that overhead. This ends up becoming a starting point for ARROW-16017, but I don't consider it complete since I have few cases covered and I didn't include any statistical comparisons

I understand the desire to benchmark different alternatives, but this shouldn't result in these alternatives being all exposed to the user. Once you have selected the best option, the others needn't remain in the code IMHO :-)

It seems to me that a single hash64 should be sufficient (if it comes out faster than plain xxhash).

ah, I hadn't thought of removing it from the code after getting some benchmark results, I assumed we would want to keep it in. In that case, I can just expose the fast_hash_64 function

For the record I ran the benchmarks on this PR and got the following results (AMD Zen 2, gcc 12.1.0):
HashSmallStrings                   53804 ns        53797 ns        12765 bytes_per_second=3.78259G/s items_per_second=371.771M/s
HashMediumStrings                 134763 ns       134741 ns         5204 bytes_per_second=9.62158G/s items_per_second=148.433M/s
HashLargeStrings                  131613 ns       131592 ns         5303 bytes_per_second=14.5615G/s items_per_second=15.1984M/s
HashIntegers32                      7000 ns         6999 ns        98803 bytes_per_second=10.6457G/s items_per_second=2.85769G/s
HashIntegers64                      5870 ns         5870 ns       121495 bytes_per_second=25.387G/s items_per_second=3.40739G/s
XxHashIntegers64                    9703 ns         9701 ns        72891 bytes_per_second=7.67983G/s items_per_second=1030.77M/s
XxHashSmallStrings                110951 ns       110928 ns         6290 bytes_per_second=749.782M/s items_per_second=90.1486M/s
XxHashMediumStrings               156073 ns       156042 ns         4473 bytes_per_second=3.37323G/s items_per_second=64.0852M/s
XxHashLargeStrings                639924 ns       639779 ns         1098 bytes_per_second=12.4299G/s items_per_second=15.6304M/s
KeyHashIntegers32                   4547 ns         4546 ns       153644 bytes_per_second=8.19474G/s items_per_second=2.19976G/s
KeyHashIntegers64                   4464 ns         4463 ns       157182 bytes_per_second=16.6926G/s items_per_second=2.24045G/s
FastHash32Int32                     7474 ns         7472 ns        92988 bytes_per_second=4.98571G/s items_per_second=1.33834G/s
FastHash64Int64                     7279 ns         7277 ns        95608 bytes_per_second=10.2381G/s items_per_second=1.37414G/s
FastHash64StructSmallStrings      133759 ns       133732 ns         5144 bytes_per_second=1.73021G/s items_per_second=224.329M/s
FastHash64StructMediumStrings     179672 ns       179640 ns         3790 bytes_per_second=3.72547G/s items_per_second=167.001M/s
FastHash64StructLargeStrings      654450 ns       654307 ns         1079 bytes_per_second=12.2498G/s items_per_second=45.85M/s
FastHash64Map                     109664 ns       109645 ns         6391 bytes_per_second=1.61148G/s items_per_second=182.408M/s

Forgot that scalar_hash_test.cc existed, so had to remove references to fast_hash_32. I also decided to add a few more test cases and realized that list types weren't being hashed. This was fixed by changing how I try to extract KeyColumnArrays (https://github.com/apache/arrow/pull/13487/commits/0f0b304955c3a91830ab47d9354a31562a9838b5), now I take this approach:

Try to grab buffers from ArrayData

If successful, grab buffers
If not successful, skip buffers (data type is nested so there's no data buffer anyways)

recurse on children

rebase to accommodate changes for ARROW-16695 that were introduced to light_array.cc. This PR extends light_array.cc to accommodate raw pointers which are used by ArraySpan. The rebase needed to slightly change ColumnMetadataFromDataType to use a raw pointer to the physical type instead of a shared pointer.
Also, I changed the variable name typ to ptype to better capture that it's a physical data type.

@rok since you worked on ARROW-16695, maybe you could review https://github.com/apache/arrow/pull/13487/commits/d43155f1deb481f208034f568354d90d87552b74. I think it's straightforward and it doesn't seem like ExtensionType needs to be accommodated anywhere else in light_array.cc?

@drin this looks good to me! ExtensionType is not handled anywhere else in light_array.cc. I don't think it's relevant here but I introduced similar logic to row_encoder.cc that's needed for HashJoin.

rebased to deal with some build issues

I couldn't figure out how to construct a MapArray for Hash64IntMap test case. I tried using [{<key>: <value>, ...}] and [{<key>, <value>}, {<key>, <value>}, ...] but they both don't seem to work. For now, [ [[<key>, <value>]], ...] is functional.
I'll be on vacation until Nov 2nd, so I won't be making any more commits until then. Feel free to push any changes in the meantime

rebased. I think this should be good, unless someone wants me to change the test data in the Hash64IntMap case (scalar_hash_test.cc#L104):
  // test data we directly hash to compare to the output of the scalar hash function
  std::vector<uint16_t> test_vals_first{7, 67, 3, 31, 17, 29};
  std::vector<int16_t> test_vals_second{67, 7, 31, 3, 29, 17};

  // input for the scalar hash function
  auto test_map = ArrayFromJSON(map(uint16(), int16()),
                                R"([[[ 7, 67]], [[67,  7]], [[ 3, 31]],
                                    [[31,  3]], [[17, 29]], [[29, 17]]])");

oh wait, jk, I didn't implement the other test cases. let me do that real quick

hmm, so I have implemented more test coverage now, but when testing ListArray I realized that my naive approach for nested types is too naive. I have figured out what I think is correct, but making the updates is a bit slow (easy to confuse myself).
The gist of the change is that for list types I need to flatten the structure to a binary-like layout that has offsets and variable length data. In simple cases, (list and map), this mostly means flattening offsets and recursing into child arrays as before. No change for struct types. The fixed size list type should be relatively similar to other list types.
Union types seem like they will require a different approach; though, they may only require something like a flattened sparse union representation.

@drin is this something you are still working on?

The key portion that added extra dev time was thinking I needed something in between a KeyColumnArray (alternative to ArraySpan) and ResizableArrayData (version of KeyColumnArray that owns buffers). For now I am calling it a KeyColumnPseudoSpan.
For example, when hashing a ListArray a class in between the 2 mentioned above would allow me to maintain a view into the data owned by the ListArray but alter offsets to that only the top-most structure is preserved. For a standard ListArray this means just representing the ListArray with a KeyColumnArray, for a nested ListArray with 2-levels, this means flattening the ListArray into a standard ListArray (1 level) and then representing the ListArray data and modified offsets with the new KeyColumnPseudoSpan class.
I'll try to get the commit in today so that I can clarify the approach and get feedback

converted to draft PR for now. will mark ready when I've figured out the KeyColumnPseudoSpan

okay, I'll finally work actively on this during this week. I have talked with Weston to figure out a good path forward on the aspect that was blocking me. I am also (mostly) clear of a deadline that had been blocking me otherwise.
I still think I won't finish this until closer to the end of the week or early next week, but progress should actually be made

rebased again. I will try to clean the history up before I mark this ready for review

rebased again. I will try to clean the history up before I mark this ready for review

Looking forward to it :)

Hello. Faced a problem joining tables containing list. Hope this PR helps.

Hello. Faced a problem joining tables containing list. Hope this PR helps.

It would! I just have struggled to find enough time for it, and I've let it go for far (far) too long.

I am going to force push a clean history so that rebases don't take so long, and then maybe I can pick this up or maybe someone can help finish it off

I may have to do a new PR; it seems that manually cherry picking changes (but not the commits themselves) perhaps resolves to the same commit hashes and git thinks the branches are the same (up-to-date).
Just noting here that even though I have a branch ready with fresh history (https://github.com/drin/arrow/tree/ARROW-8991-newfn-scalar-hash-fresh), I can't seem to overwrite this branch with it.

alright, I attempted to force change of commit history by using
git merge -s ort -Xtheirs ARROW-8991-newfn-scalar-hash-fresh
While this seems to be the "correct way", clearly it makes the PR look gratuitous. I'm going to close this one, and refer to it from a new PR. I'll try to update everything as appropriate.


WIP: 1864 log4j update

Related issue: https://github.com/locationtech/geowave/issues/1864
This PR is a Work in Progress.
Integration testing is being in the PR builds.

@rfecher I think this branch is ready for final review/approval/merging.


doesn't work on windows ?

doesn't work on windows ? D:\lipsing/video-retalking>conda activate video_retalking.
(video_retalking) D:\lipsing/video-retalking>python3 inference.py
Python
(video_retalking) D:\lipsing\video-retalking> --face examples/face/1.mp4 .
"--face" is not an internal or external
command, executable program, or batch file.
(video_retalking) D:\lipsing\video-retalking> --audio examples/audio/1.wav .
"--audio" is not an internal or external
command, executable program, or batch file.
(video_retalking) D:\lipsing\video-retalking> --outfile results/1_1.mp4

might need to remove the newlines and run the command as one line and change python3 to python. i created a fork of this repo with instructions for windows if you wanna check that out

i got this err: "[Info] Using cuda for inference. [Step 0] Number of frames available for inference: 135 [Step 1] Landmarks Extraction in Video. landmark Det:: 100%|█████████████████████████████████████████████████████████████████| 135/135 [00:32<00:00, 4.15it/s] Traceback (most recent call last): File "inference.py", line 345, in main() File "inference.py", line 82, in main lm = kp_extractor.extract_keypoint(frames_pil, './temp/'+base_name+'_landmarks.txt') File "C:\Users\Admin\Downloads\01.Video-Head-Talking\video-retalking\third_part\face3d\extract_kp_videos.py", line 34, in extract_keypoint np.savetxt(os.path.splitext(name)[0]+'.txt', keypoints.reshape(-1)) File "<array_function internals>", line 200, in savetxt File "C:\Users\Admin\Downloads\01.Video-Head-Talking\video-retalking\venv\lib\site-packages\numpy\lib\npyio.py", line 1533, in savetxt open(fname, 'wt').close() FileNotFoundError: [Errno 2] No such file or directory: './temp/.\examples\face\1.mp4_landmarks.txt'"

how can i fix it to run on windows?

I used conda with these instructions: https://github.com/natlamir/video-retalking#environment
there is a video too but I don't think I have that linked on the github yet.

I used conda with these instructions: https://github.com/natlamir/video-retalking#environment there is a video too but I don't think I have that linked on the github yet.

Thank natlamir, i've tried your repo and it worked with me.


Negative/Unrealistic UV Index Value & Precipitation Intensity

I noticed late night on Thursday that the API was giving some unrealistic values for the UV index. I first noticed this in my HA installation and checked in the browser and I can confirm that it's an API issue rather than a HA issue.
The first thing I noticed was at 11:50 PM there was a UV index of 0.03 which shouldn't be possible at that point. I wonder if it was using the absolute value of -0.03 which is why it returned 0.03 instead of -0.03.

  "currently": {
    "time":<PHONE_NUMBER>,
    "uvIndex": 0.03,
  },

The second thing I noticed was that the current day has a forecasted UV index of -0.03 which makes no sense. I know I mentioned this in #7 and #4 but it was never fixed.

  "daily": {
    "summary": "Rain",
    "icon": "rain",
    "data": [
      {
        "time":<PHONE_NUMBER>,
        "uvIndex": -0.03,
      },

EDIT: Seems to be a common occurrence late at night (around 10/11pm) as I noticed it again a few days ago.

The 1.5.4 update seems to have fixed this as well. Will close for now but if it pops up again I will re-open.

Just noticed the same issue pop up again. Current UV is 0.03, the daily UV index is -0.0 but the hourly data is fine.

@alexander0042 I also found that a negative precipIntensity and precipIntensityError are still possible
  "currently": {
    "time":<PHONE_NUMBER>,
    "summary": "Clear",
    "icon": "clear-day",
    "nearestStormDistance": 0,
    "nearestStormBearing": 0,
    "precipIntensity": -0.0005,
    "precipProbability": 0.0,
    "precipIntensityError": -0.0,
    "precipType": "rain",
    "temperature": 21.7,
    "apparentTemperature": 27.49,
    "dewPoint": 17.72,
    "humidity": 0.78,
    "pressure": 1009.08,
    "windSpeed": 16.63,
    "windGust": 31.36,
    "windBearing": 166,
    "cloudCover": 0.18,
    "uvIndex": 5.51,
    "visibility": 4.5,
    "ozone": 302.01
  },

I found this issue while using these coordinates 47.486771,-52.751787 so maybe it's just a GFS/GEFS issue but I have seen precipIntensityError be -0.0 before in the HRRR domain.

Going to bump this before I get the stale notification. I just checked and I'm seeing "uvIndex": 0.05, 2 hours after sunset which seems a little bit off? I think the negative issues can still happen though I haven't seen it lately.

There's already #88 to take care of the unrealistic UV Index values and the negative values seem to be fixed in the V2 beta.


[PORT] Updates to readme

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/4159

Fixes #4158.
Updates to readme address accuracy, provide a consistent format (which will be replicated across the languages SDKs) and consolidate wiki content.

Wiki also now hidden.


feat: Add convert only match pattern files

fix: #35

Codecov Report
Base: 81.06% // Head: 81.11% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (72ef698) compared to base (3796fb2).
Patch coverage: 50.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   81.06%   81.11%   +0.04%
==========================================
  Files          10       10
  Lines         412      413       +1
==========================================
+ Hits          334      335       +1
  Misses         78       78

Flag
Coverage Δ

unittests
81.11% <50.00%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/airphin/cli/command.py
48.57% <50.00%> (+0.74%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


test and document the new knesset APIs

Knesset published the new APIs on Mar. 5, 2017, they admit it's not 100% correct but they would like to get feedback. From a quick glance I already see some problems, for example - committees data have an email column which is mostly empty and when it's not empty it contains the name of the committee in hebrew..
need to review the APIs and find the blatant problems and notify knesset about them
you can see how to browse the data in the data sources documentation - https://github.com/hasadna/knesset-data/blob/master/docs/dataservice/README.md
this issue referes to the latest API which is available at this ODAta endpoint - http://knesset.gov.il/Odata/ParliamentInfo.svc/$metadata

as you are reviewing the API, should also update the documentation at https://github.com/hasadna/knesset-data/tree/master/docs/dataservice


[WIP] Update templates

This is work in progress right now. We'll need to update again once
there's a build with the Action fix in it, and again to point to the
final package versions.
Just getting things staged ahead of time.

I know this is not the final version for 0.2.0, but I'm trying to reconcile this PR, #465, and further template updates needed to make it show up for both 2.0 and 2.1 project types. So to get everything consistent I'm going to merge this WIP as-is, and we can then change the package versions further later. Hope that's OK!

Merged

Sounds good!


CurveCurrencyParameterSensitivities equality depends on the ordering of its list of sensitivities

It would seem intuitive that the ordering isn't important

The internal list is sorted and normalized, so list equality should work just fine. Not sure any change is needed here.

The varags version of the of method doesn't sort or normalise the inputs, it calls the constructor directly with a copy of the input array.
That method should call the other of method, or the logic should be moved to the constructor.


Magic link is not working in Safari browser

Describe the issue:
Magic link is not working in Safari browser.
https://user-images.githubusercontent.com/39077751/183301959-95b9dd10-4538-4555-b9e2-9befce96eacf.mov
How to reproduce:

Create application and  configure magic link
Authenticate with magic link

Expected behavior:
Authentication should be successful.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 6.0.0-beta
OS: Mac
Database: MSSQL
Userstore: JDBC

Optional Fields
Related issues:

Suggested labels:

Tested magicLink on safari and it works as expected. If there is an issue, that should be in the sample side tested. Tested in both super tenant and tenented environments.

@aaujayasena please check and close the issue.

@SujanSanjula96 please test this with Mac M1

Tested this with Mac M1. Magic link works as expected in normal window. But it is not working in private window because browsing initiated in one tab 0f a private window is isolated from browsing initiated in another tab.
https://support.apple.com/en-lk/guide/safari/ibrw1069/mac

Closing this issue since it is the expected behaviour in private windows for safari browser.

@SujanSanjula96  Shall we update the reason for accept this on Safari private windows

@aaujayasena  Mentioned the reason in https://github.com/wso2/product-is/issues/14600#issuecomment-1207705717

Shall we create a doc issue https://github.com/wso2/product-is/issues/14600#issuecomment-1207705717 @SujanSanjula96

Doc issue created https://github.com/wso2/product-is/issues/14644


[Feature Request]: Logging at one line

🔎 Search Terms
one line logging
The vision
It will be nice if winston can provide one line logging
and also it should work with multiple loggers aka  multiple progress bar
Use case
No response
Additional information
No response

Unclear what you're looking for that isn't currently possible, though this seems like a usage question that might get better response on StackOverflow.

  It's not even clear here when asked on GitHub.
Guidance here might help in future questions.

Stackoverflow's tag winston is dead :/
Not sure what you mean - it's had 11 questions in the last 30 days and that's about a typical month.

 It's not even clear here when asked on GitHub. Guidance here might help in future questions.

Stackoverflow's tag winston is dead :/

Not sure what you mean - it's had 11 questions in the last 30 days and that's about a typical month. One every few days hardly seems "dead" to me.

Oh,my bad,i will rewrite my question


Battery doesnt deplete for me

It's depleting for others, but not for me. Neither for stealth nor thermal cam

Closing this as it's related to the same problem as #53. Since battery is depleted in PlayerTick. Something I did caused me being the only player for which the PlayerSecondElapsed (or PlayerTick) did not fire anymore.


Could you add Heroicons support?

It would be nice to have them in the options.

Will have a look to see if we decide to implement this separately or in sync with #13 @iamdagy

This have now been resolved in v2.0.0. Closing


Data not showing up

Hi there, I am in a similar position to https://github.com/milesmcc/shynet/issues/24 but have tried the suggestions from there and cannot get data to be logged.
I have also tried the troubleshooting ...
I am using an nginx reverse proxy and can access the admin area of shynet.
What is weird is that if I go to the script created by shynet for my site and paste in into a browser, I get a 404, which is odd!
It uses an 'ingress' directory which isn't present on my server, so am not sure if shynet should be redirecting that in some way....as I am not using Kubernetes.
Thanks for any help.
Cheers

Can you paste 1) the script that Shynet generates, and 2) a redacted version of your environment file?

Okay, apologies for the noise, as I should have read everything...
I took this to mean the hostname of the monitored site rather than that of the shynet instance....that is why the scripts were pointing to my website and not the shynet instance...its obvious now I think about it but not at the time :)
I am up and running, thanks for creating and hope you keep improving :)


More than one upload of same XML throws error

It returns...
"MultipleObjectsReturned at /videostorage/list/show/test.mkv.qctools
get() returned more than one Video -- it returned 4!"
(etc etc etc)

I just limited to one for now. But do you want to be able to add same file twice? Or Can I overwrite it? I can't keep them as both having the exact the same files name. I need to modify the file name itself if user needs to upload the same file names twice.

Hmm... I guess overwriting is best with a prompt to the user that it already exists and will be overwritten? For now it doesn't matter much. I feel like in the future things will be loaded in as batches, and not one-at-a-time like now.

Okay I will change it overwriting then.


Test-Json cannot parse schema

It appears that both the JSON data file and schema file are valid.
Is there any way to get more information about why the schema cannot be parsed?
Steps to reproduce
PS C:\src\t\json> Test-Json -Json (Get-Content -Path .\project-manifest.json -Raw)
True
PS C:\src\t\json> Test-Json -Json (Get-Content -Path .\project-manifest.schema.json -Raw)
True
PS C:\src\t\json> Test-Json -Json (Get-Content -Path .\project-manifest.json -Raw) -Schema .\project-manifest.schema.json
Test-Json: Cannot parse the JSON schema.
PS C:\src\t\json> Test-Json -Json (Get-Content -Path .\project-manifest.json -Raw) -Schema .\project-manifest.schema.json -Verbose
Test-Json: Cannot parse the JSON schema.

Expected behavior
PS C:\src\t\json> Test-Json -Json (Get-Content -Path .\project-manifest.json -Raw) -Schema .\project-manifest.schema.json
True

Actual behavior
PS C:\src\t\json> Test-Json -Json (Get-Content -Path .\project-manifest.json -Raw) -Schema .\project-manifest.schema.json
Test-Json: Cannot parse the JSON schema.

Environment data
PS C:\src\t\json> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.0.1
PSEdition                      Core
GitCommitId                    7.0.1
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@Liturgist The value for the -Schema is a string containing the schema. Please have a look at the example in the documentation. https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/test-json?view=powershell-7#examples
Also, there is a recent PR which will bring in support for -SchemaFile.

@adityapatwardhan - Thank you for your quick reply. I should have thought of that. Yes, I should have read the examples as well.
Perhaps a good alias for the -Schema parameter would be -SchemaString. That might go with an alias for -Json as -JsonString.
Does the proposed change include -JsonFile and -SchemaFile?

SchemaFile was already added yesterday.

Does that mean that -JsonFile will not be considered?

You could open new issue with the proposal.

Hey, I am trying to use Test-Json but apparently, it's showing the error cannot parse schema json
Please let me know what's the issue
address.json
{
  "definitions": {
     "required": [
      "street_address",
      "city",
      "state"
    ],
      "street_address": {
        "type": "string"
      },
      "city": {
        "type": "string"
      },
      "state": {
        "type": "string"
      }
    }

}

subschema.json
{
"$schema": "http://json-schema.org/draft-04/schema#",
"type": "object",
"properties": {
"address":{
"$ref":"address.json#/definitions"
}
}
}
Powershell Script
'{"address":{"city": "ABCDEFGHIJKLMNOPQRSTUVWXY","state": "ABCDEFGHIJKLMNOPQRSTUVWXYZABC"}}' | Test-Json -SchemaFile 'demoschema.json'

@HSweta I hope this will be fixed in #18141. Please vote there.

@iSazonov even getting the same error with draft-7

@HSweta It seems you use a refence to external file in the schema file - it is blocked by default in modern standard. I guess we will have a parameter/switch in Test-Json to explicitly enable this.


Enable flake8 and cov plugins only when installed.

Avoid installing in PyPy.

Does auto-merge mean nothing to you, Github?


Update sbt-scalajs to 1.13.1

About this PR
📦 Updates org.scala-js:sbt-scalajs from 1.9.0 to 1.13.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js", artifactId = "sbt-scalajs" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-js", artifactId = "sbt-scalajs" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #299.

Superseded by #310.


Checkstyle fixes in Cloud Storage JSON API tests.

Getting ready to use shared java-repo-tools configuration.
I also convert the assertions to use truth.
Since I find it more readable to get a list of object names first
instead of manually looping through, I also update the sample to use
Java 8 lambdas to extract these object names. The sample is used here:
https://cloud.google.com/storage/docs/json_api/v1/json-api-java-samples
which does not indicate the required Java version.
Depends on https://github.com/GoogleCloudPlatform/java-docs-samples/pull/107

Closing because I told it to merge into the wrong branch.


Sojourn overclock deals 10% damage

When using right-click during overclock, the damage is recognized as ultimate instead of secondary fire and doesn't activate the secondary fire code.

moved from ow1_plus_plus#14

fixed in v0.4.0


Added Codechef to competitive programming

Fixes Issue
#1842

Closes #1842
Changes proposed

Added CodeChef platform to the Competitive Programming db
Screenshots

Note to reviewers

Hi @rahul0x00! :) I just realized that you were not assigned to this issue, so I placed your PR in draft mode for now. Can you tag yourself in the comment section of #1842, please?

Sure, no issues @rahul0x00


Tentative fix for classloading issue in annotation processing

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

Sorry some internal error occurs, please contact the administrator @blindpirate


Is this still being maintained?

Curious if this project is still being maintained. Thanks

I would also love to know, this is the best modal lib out there. If you need help maintaining, I think there are many people who would gladly assist you doing so, including myself.

We've also been quite happy with the library; it works really well, and we've only found one bug in pretty heavy use. It'd be nice if it were a bit more actively maintained but I'm not particularly worried about it as a problem for using it -- it's a small enough library that it would not be hard to maintain a fork if the maintainers don't get back to working on the project at some point that it needs changes.

@ghosh Are you maintaining this library anymore? If not, would you be willing to hand over maintenance to someone else? Or at least add someone else?

Have you considered this, @ghosh ?