Add code coverage

See https://github.com/ipfs/go-ipfs/issues/3053#issuecomment-239061371.

+1

We use currently two coverage report providers, coveralls and codecov. Many of our current repos (especialy js) use coveralls but codecov has superior UX and UI, transition would be trival.

@Kubuxu Cool. What should I add? The badge?

I think it badge which links to the project's page would be ok.

Cool. And that is for all go-* and js-* repos, right?

Not all of them have coverage reports yet but yes.

Ok. Can you point to one example of the badge? I'm not seeing it on go-ipfs; is it being used elsewhere atm?

Or is this it:
[![Coverage Status](https://coveralls.io/repos/github/ipfs/go-ipld-node/badge.svg?branch=master)](https://coveralls.io/github/ipfs/go-ipld-node?branch=master)
[![Codecov](https://img.shields.io/codecov/c/github/codecov/example-python.svg)]()

I'll add the second (codecov) and open an issue about switching; that work for you? Where should I point questions about that - I don't see an issue in ipfs/community about the switch. Where is that discussion happening?

There was no discussion yet, I will start issue in community.

I like this style of badges a lot:
We could use the same style of icons from shields.io for Travis, Circle and the normal task:

In that case, I will start looking for or adding:
![CodeCov](https://img.shields.io/codecov/c/github/ipfs/go-ipfs.svg?style=flat-square)
[![Travis CI](https://travis-ci.org/ipfs/go-ipld-node.svg?branch=master)](https://img.shields.io/travis/ipfs/go-ipld-node.svg)

To every IPFS repo.

We should probably make the coverage shield clickable.

[![codecov.io](https://img.shields.io/codecov/c/github/ipfs/go-ipfs.svg?style=flat-square&branch=master)](https://codecov.io/github/ipfs/go-ipfs?branch=master)
[![Travis CI](https://img.shields.io/travis/ipfs/go-ipld-node.svg?branch=master&style=flat-square)](https://travis-ci.org/ipfs/go-ipld-node/)

Look better?


Fix breaks in controller_test.go

Fixes breaks in master after #708 merged.

This is a bugfix for a break on master. I will merge this promptly after CI passes


Update IG arch diagram in README file

Add AWS Clean Rooms to left side. (Chip is updating the one in IG and LP, can copy)


Android crash when connecting.

Moved to new issue from #17.
The certificate created by PKI will cause my Samsung S23 with the latest update to crash and restart. Older versions are not affected.
The only alternative is to not validate the certificate, which is bad for security.
Apparently the cert CN is null? Crash does not happen on older android device and on IOS.
Android log via logcat
05-20 20:28:39.038 17596 17939 E AndroidRuntime: !@*** FATAL EXCEPTION IN SYSTEM PROCESS: WifiHandlerThread
05-20 20:28:39.038 17596 17939 E AndroidRuntime: java.lang.NullPointerException: Attempt to read from field 'java.lang.String com.android.server.wifi.util.CertificateSubjectInfo.commonName' on a null object reference in method 'void com.android.server.wifi.InsecureEapNetworkHandler.askForUserApprovalForCaCertificate()'
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at com.android.server.wifi.InsecureEapNetworkHandler.askForUserApprovalForCaCertificate(InsecureEapNetworkHandler.java:667)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at com.android.server.wifi.InsecureEapNetworkHandler.startUserApprovalIfNecessary(InsecureEapNetworkHandler.java:399)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at com.android.server.wifi.ClientModeImpl$L2ConnectingState.processMessageImpl(ClientModeImpl.java:6230)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at com.android.server.wifi.RunnerState.processMessage(RunnerState.java:62)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at com.android.wifi.x.com.android.internal.util.StateMachine$SmHandler.processMsg(StateMachine.java:1001)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at com.android.wifi.x.com.android.internal.util.StateMachine$SmHandler.handleMessage(StateMachine.java:819)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:230)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:319)
05-20 20:28:39.038 17596 17939 E AndroidRuntime: 	at android.os.HandlerThread.run(HandlerThread.java:67)

Server Certificate
Subject: CN=radius.dariussg.intra, O=DariusSG Intra Network
Issuer: CN=DariusSG Intra Network Root CA, O=DariusSG Intra Network
Validity: from 2024-05-12T08:20:33.000Z to 2025-05-12T08:20:33.000Z
-----BEGIN CERTIFICATE-----
MIICYzCCAemgAwIBAgIQcvqm8zKwxnbUgG+irPWjJTAKBggqhkjOPQQDAjB8MXow
QwYDVQQDHjwARABhAHIAaQB1AHMAUwBHACAASQBuAHQAcgBhACAATgBlAHQAdwBv
AHIAawAgAFIAbwBvAHQAIABDAEEwMwYDVQQKHiwARABhAHIAaQB1AHMAUwBHACAA
SQBuAHQAcgBhACAATgBlAHQAdwBvAHIAazAeFw0yNDA1MTIwODIwMzNaFw0yNTA1
MTIwODIwMzNaMGoxaDAxBgNVBAMeKgByAGEAZABpAHUAcwAuAGQAYQByAGkAdQBz
AHMAZwAuAGkAbgB0AHIAYTAzBgNVBAoeLABEAGEAcgBpAHUAcwBTAEcAIABJAG4A
dAByAGEAIABOAGUAdAB3AG8AcgBrMHYwEAYHKoZIzj0CAQYFK4EEACIDYgAE5i9F
9wIdD8eHAfXEExN0s8sHxDkW8b/mA3FI+DSyUGS2xZ7OsYQvR46AAukeyrDKEuFS
Q31OWYJAPzgkaRPbqWWFzz4ZQAEEYGjzqas/sky+cYrTXY3h/f6MFFVjUUqfo0Iw
QDAMBgNVHRMBAf8EAjAAMA4GA1UdDwEB/wQEAwIA4DAgBgNVHSUBAf8EFjAUBggr
BgEFBQcDAQYIKwYBBQUHAw4wCgYIKoZIzj0EAwIDaAAwZQIxAM5iJALcFo9JDUH3
13y+MDmJtN8o6YuJil74aXFqS5391pa3HcobxChMI0EqlIV3MAIwChr/WYsPBObX
ilj8kpoIiJE/zbDzZlm90locoqecVg/n7LvxyAWOXcpH4pHu8KTe
-----END CERTIFICATE-----

Root Certificate
Subject: CN=DariusSG Intra Network Root CA, O=DariusSG Intra Network
Issuer: CN=DariusSG Intra Network Root CA, O=DariusSG Intra Network
Validity: from 2024-05-12T08:20:11.000Z to 2034-05-10T08:20:11.000Z
-----BEGIN CERTIFICATE-----
MIICVjCCAdygAwIBAgIQFMHJ5bg3KGGIjv7Jo1y3CTAKBggqhkjOPQQDAjB8MXow
QwYDVQQDHjwARABhAHIAaQB1AHMAUwBHACAASQBuAHQAcgBhACAATgBlAHQAdwBv
AHIAawAgAFIAbwBvAHQAIABDAEEwMwYDVQQKHiwARABhAHIAaQB1AHMAUwBHACAA
SQBuAHQAcgBhACAATgBlAHQAdwBvAHIAazAeFw0yNDA1MTIwODIwMTFaFw0zNDA1
MTAwODIwMTFaMHwxejBDBgNVBAMePABEAGEAcgBpAHUAcwBTAEcAIABJAG4AdABy
AGEAIABOAGUAdAB3AG8AcgBrACAAUgBvAG8AdAAgAEMAQTAzBgNVBAoeLABEAGEA
cgBpAHUAcwBTAEcAIABJAG4AdAByAGEAIABOAGUAdAB3AG8AcgBrMHYwEAYHKoZI
zj0CAQYFK4EEACIDYgAEJ/3zWfk5PfYGd3Hrel/UAuB7DNEriIGwwFsQsVGFBI5q
kqRcccrWKibJjXvVYATMPPjTg406Yg+adGBVnmM/Qu4Vj6pZlfVj3zscC6FdKNrn
xn+6whOHxXGCmOj+g4pOoyMwITAPBgNVHRMBAf8EBTADAQH/MA4GA1UdDwEB/wQE
AwIAhjAKBggqhkjOPQQDAgNoADBlAjATPkEyQud/YIQZb7QjDIQgsT4bLiA8BW0E
N/rXD1DhMM6o8To4/CyIVIR0Wx4dD18CMQDLETppEvu6vi0gBqUZIrl2vdFpX8Ww
5+GaHuuV0ehzNHg3LBg4vUJqJkqdBT/8NKQ=
-----END CERTIFICATE-----

p12 User Certificate (dariussg)   **Note, Please rename the file back to '.p12'.

Password
 neko

3fe75e0ee79cf1fab866e941c0503368.txt

Weirdly enough, I works for my School WiFi which is using the same wpa-eap protocol.

When I'm inspecting the server certificate you provided, the issuer is populated but in a weird string representation. This probably indicates the PKI didn't encode the string correctly.
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            72:fa:a6:f3:32:b0:c6:76:d4:80:6f:a2:ac:f5:a3:25
    Signature Algorithm: ecdsa-with-SHA256
        Issuer: CN=\x00D\x00a\x00r\x00i\x00u\x00s\x00S\x00G\x00 \x00I\x00n\x00t\x00r\x00a\x00 \x00N\x00e\x00t\x00w\x00o\x00r\x00k\x00 \x00R\x00o\x00o\x00t\x00 \x00C\x00A, O=\x00D\x00a\x00r\x00i\x00u\x00s\x00S\x00G\x00 \x00I\x00n\x00t\x00r\x00a\x00 \x00N\x00e\x00t\x00w\x00o\x00r\x00k
        Validity
            Not Before: May 12 08:20:33 2024 GMT
            Not After : May 12 08:20:33 2025 GMT
        Subject: CN=\x00r\x00a\x00d\x00i\x00u\x00s\x00.\x00d\x00a\x00r\x00i\x00u\x00s\x00s\x00g\x00.\x00i\x00n\x00t\x00r\x00a, O=\x00D\x00a\x00r\x00i\x00u\x00s\x00S\x00G\x00 \x00I\x00n\x00t\x00r\x00a\x00 \x00N\x00e\x00t\x00w\x00o\x00r\x00k
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
                Public-Key: (384 bit)
                pub:
                    04:e6:2f:45:f7:02:1d:0f:c7:87:01:f5:c4:13:13:
                    74:b3:cb:07:c4:39:16:f1:bf:e6:03:71:48:f8:34:
                    b2:50:64:b6:c5:9e:ce:b1:84:2f:47:8e:80:02:e9:
                    1e:ca:b0:ca:12:e1:52:43:7d:4e:59:82:40:3f:38:
                    24:69:13:db:a9:65:85:cf:3e:19:40:01:04:60:68:
                    f3:a9:ab:3f:b2:4c:be:71:8a:d3:5d:8d:e1:fd:fe:
                    8c:14:55:63:51:4a:9f
                ASN1 OID: secp384r1
                NIST CURVE: P-384
        X509v3 extensions:
            X509v3 Basic Constraints: critical
                CA:FALSE
            X509v3 Key Usage: critical
                Digital Signature, Non Repudiation, Key Encipherment
            X509v3 Extended Key Usage: critical
                TLS Web Server Authentication, <IP_ADDRESS>.<IP_ADDRESS>.14
    Signature Algorithm: ecdsa-with-SHA256
         30:65:02:31:00:ce:62:24:02:dc:16:8f:49:0d:41:f7:d7:7c:
         be:30:39:89:b4:df:28:e9:8b:89:8a:5e:f8:69:71:6a:4b:9d:
         fd:d6:96:b7:1d:ca:1b:c4:28:4c:23:41:2a:94:85:77:30:02:
         30:0a:1a:ff:59:8b:0f:04:e6:d7:8a:58:fc:92:9a:08:88:91:
         3f:cd:b0:f3:66:59:bd:d2:5a:1c:a2:a7:9c:56:0f:e7:ec:bb:
         f1:c8:05:8e:5d:ca:47:e2:91:ee:f0:a4:de
-----BEGIN CERTIFICATE-----
MIICYzCCAemgAwIBAgIQcvqm8zKwxnbUgG+irPWjJTAKBggqhkjOPQQDAjB8MXow
QwYDVQQDHjwARABhAHIAaQB1AHMAUwBHACAASQBuAHQAcgBhACAATgBlAHQAdwBv
AHIAawAgAFIAbwBvAHQAIABDAEEwMwYDVQQKHiwARABhAHIAaQB1AHMAUwBHACAA
SQBuAHQAcgBhACAATgBlAHQAdwBvAHIAazAeFw0yNDA1MTIwODIwMzNaFw0yNTA1
MTIwODIwMzNaMGoxaDAxBgNVBAMeKgByAGEAZABpAHUAcwAuAGQAYQByAGkAdQBz
AHMAZwAuAGkAbgB0AHIAYTAzBgNVBAoeLABEAGEAcgBpAHUAcwBTAEcAIABJAG4A
dAByAGEAIABOAGUAdAB3AG8AcgBrMHYwEAYHKoZIzj0CAQYFK4EEACIDYgAE5i9F
9wIdD8eHAfXEExN0s8sHxDkW8b/mA3FI+DSyUGS2xZ7OsYQvR46AAukeyrDKEuFS
Q31OWYJAPzgkaRPbqWWFzz4ZQAEEYGjzqas/sky+cYrTXY3h/f6MFFVjUUqfo0Iw
QDAMBgNVHRMBAf8EAjAAMA4GA1UdDwEB/wQEAwIA4DAgBgNVHSUBAf8EFjAUBggr
BgEFBQcDAQYIKwYBBQUHAw4wCgYIKoZIzj0EAwIDaAAwZQIxAM5iJALcFo9JDUH3
13y+MDmJtN8o6YuJil74aXFqS5391pa3HcobxChMI0EqlIV3MAIwChr/WYsPBObX
ilj8kpoIiJE/zbDzZlm90locoqecVg/n7LvxyAWOXcpH4pHu8KTe
-----END CERTIFICATE-----

However, based on the investigation in below, it seems unrelated to the issue we're having now.

From your logcat I suspect the following line is where the error occurs:
https://cs.android.com/android/_/android/platform/packages/modules/Wifi/+/6ac46ef90e32e323fb8b12807fd3bd0e420e0056:service/java/com/android/server/wifi/InsecureEapNetworkHandler.java;l=667;drc=9c4490cecdb83cf20d89af26bd99fc31cc5541c9
The function assumes mPendingServerCertIssuerInfo is non-null, which is populated in an earlier time:
https://cs.android.com/android/_/android/platform/packages/modules/Wifi/+/6ac46ef90e32e323fb8b12807fd3bd0e420e0056:service/java/com/android/server/wifi/InsecureEapNetworkHandler.java;l=312-317;drc=9c4490cecdb83cf20d89af26bd99fc31cc5541c9
Can you also confirm there is a log line saying Cert has no valid issuer.?

Weirdly enough, I works for my School WiFi which is using the same wpa-eap protocol.

Can you elaborate more on this?

Weirdly enough, I works for my School WiFi which is using the same wpa-eap protocol.

Can you elaborate more on this?

I was testing if it was a general bug or specific to this package.

Can you also confirm there is a log line saying Cert has no valid issuer.?

According to the logs, I appears that the weird string representation might be the cause.
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler: addPendingCertificate: SSID="<Redacted>" depth=0 certHash=d5e5b2efaae60433c5424e20a71f1e0fa5c0061e945e42a1f89750fb47d4bb7b current config="<Redacted>"WPA_EAP
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler: certificate content:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler: Certificate:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:     Data:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:         Version: 3 (0x2)
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:         Serial Number:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:              (Negative)58:43:d3:85:80:c0:a2:cc:0d:88:98:4d:87:06:c6:a8
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:     Signature Algorithm: ecdsa-with-SHA256
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:         Issuer: CN=\x00D\x00a\x00r\x00i\x00u\x00s\x00S\x00G\x00 \x00I\x00n\x00t\x00r\x00a\x00 \x00N\x00e\x00t\x00w\x00o\x00r\x00k\x00 \x00R\x00o\x00o\x00t, O=\x00D\x00a\x00r\x00i\x00u\x00s\x00S\x00G\x00 \x00I\x00n\x00t\x00r\x00a
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:         Validity
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:             Not Before: May 20 12:25:37 2024 GMT
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:             Not After : May 20 12:25:37 2025 GMT
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:         Subject: CN=\x00r\x00a\x00d\x00i\x00u\x00s\x00.\x00d\x00a\x00r\x00i\x00u\x00s\x00s\x00g\x00.\x00x\x00y\x00z, O=\x00D\x00a\x00r\x00i\x00u\x00s\x00S\x00G\x00 \x00I\x00n\x00t\x00r\x00a\x00 \x00N\x00e\x00t\x00w\x00o\x00r\x00k
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:         Subject Public Key Info:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:             Public Key Algorithm: id-ecPublicKey
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                 Public-Key: (P-384)
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                 pub:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                     04:b8:d0:53:34:48:b5:fa:81:0c:1c:f9:a2:66:f0:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                     ae:21:dd:89:a0:3a:a7:00:fb:b2:57:08:68:92:fe:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                     66:f0:93:5e:29:a5:e6:9d:27:84:e4:00:b6:0a:b1:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                     a9:9f:9d:88:71:05:72:0a:1f:e2:04:bb:f1:04:32:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                     e7:6c:16:27:2d:ac:60:70:40:53:15:28:2c:29:9b:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                     f3:71:78:e9:51:54:c5:cb:47:e7:72:2a:45:05:8b:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                     cc:22:99:1d:55:87:2f
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:         X509v3 extensions:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:             X509v3 Basic Constraints: critical
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                 CA:FALSE
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:             X509v3 Key Usage: critical
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                 Digital Signature, Non Repudiation, Key Encipherment
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:             X509v3 Extended Key Usage: critical
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:                 TLS Web Server Authentication, <IP_ADDRESS>.<IP_ADDRESS>.14
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:     Signature Algorithm: ecdsa-with-SHA256
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:          30:64:02:30:6c:56:11:42:f2:89:32:af:63:63:24:70:50:20:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:          d2:a7:31:16:83:61:a1:ef:37:e1:02:b4:08:77:a0:aa:34:70:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:          4f:d9:df:a2:a2:59:31:3b:30:b5:aa:cc:4d:5e:05:72:02:30:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:          7f:b0:0f:c3:0d:6c:46:26:39:dd:6e:7f:b1:98:30:e4:51:d3:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:          67:61:9c:ed:f7:db:df:63:6a:41:9c:56:9e:d9:8d:d0:46:a4:
05-21 23:05:22.310  6577  6946 D InsecureEapNetworkHandler:          56:49:f4:cb:ab:d8:af:e6:76:c9:79:35
...
05-21 23:05:22.314  6577  6946 E CertificateSubjectInfo: Unable to unescape string: CN=\00r\00a\00d\00i\00u\00s\00.\00d\00a\00r\00i\00u\00s\00s\00g\00.\00x\00y\00z+O=\00D\00a\00r\00i\00u\00s\00S\00G\00 \00I\00n\00t\00r\00a\00 \00N\00e\00t\00w\00o\00r\00k
05-21 23:05:22.314  6577  6946 E InsecureEapNetworkHandler: Cert has no valid subject.
05-21 23:05:22.314  6577  6946 D WifiClientModeImpl: Cannot set pending cert.
05-21 23:05:22.318  6577  6946 D InsecureEapNetworkHandler: TOFU certificate chain:
05-21 23:05:22.318  6577  6946 D InsecureEapNetworkHandler: CN=\00r\00a\00d\00i\00u\00s\00.\00d\00a\00r\00i\00u\00s\00s\00g\00.\00x\00y\00z+O=\00D\00a\00r\00i\00u\00s\00S\00G\00 \00I\00n\00t\00r\00a\00 \00N\00e\00t\00w\00o\00r\00k
05-21 23:05:22.318  6577  6946 D InsecureEapNetworkHandler: CN=\00D\00a\00r\00i\00u\00s\00S\00G\00 \00I\00n\00t\00r\00a\00 \00N\00e\00t\00w\00o\00r\00k\00 \00R\00o\00o\00t+O=\00D\00a\00r\00i\00u\00s\00S\00G\00 \00I\00n\00t\00r\00a
...
05-21 23:05:22.328  6577  6946 I InsecureEapNetworkHandler: Server certificate chain validation succeeded, use Root CA
05-21 23:05:22.336  6577  6946 E AndroidRuntime: !@*** FATAL EXCEPTION IN SYSTEM PROCESS: WifiHandlerThread

Looks like it was unable to escape the subject and set the cert null
05-21 23:05:22.314  6577  6946 E CertificateSubjectInfo: Unable to unescape string: CN=\00r\00a\00d\00i\00u\00s\00.\00d\00a\00r\00i\00u\00s\00s\00g\00.\00x\00y\00z+O=\00D\00a\00r\00i\00u\00s\00S\00G\00 \00I\00n\00t\00r\00a\00 \00N\00e\00t\00w\00o\00r\00k
05-21 23:05:22.314  6577  6946 E InsecureEapNetworkHandler: Cert has no valid subject.
05-21 23:05:22.314  6577  6946 D WifiClientModeImpl: Cannot set pending cert.

CN and other strings in Subject is encoded with BmpString, which could be the root cause.
https://github.com/amphineko/yonagi/blob/ff65e38b95585354e6edec59907136f08a73273d/packages/supervisor/src/pki/pkijs/utils.ts#L72
Switching to PrintableString or UTF8String might help.

CN and other strings in Subject is encoded with BmpString, which could be the root cause.
https://github.com/amphineko/yonagi/blob/ff65e38b95585354e6edec59907136f08a73273d/packages/supervisor/src/pki/pkijs/utils.ts#L72
Switching to PrintableString or UTF8String might help.

Using UTF8String does not work.
However, Using PrintableString will allow it to process but when displayed, it shows
<Common name>, O=<Org Name>
More Investigation is required but for now, I'm switching to PrintableString as a temporary workaround.

Inspecting a known good certificate reveals this.
Known Good

Mine

As you can see, each subject is encoded in its own RDN and the string type is PrintableString.

Sidenote, Would it be possible to switch to using OpenSSL commands to generate certificate instead to ensure that certificate work properly for all devices?

I would prefer not to call OpenSSL by shell commands. However, I have considered migrating to OpenSSL node.js binding if necessarily.

After looking at PKI.js, we would need to fork it to fix this minor display issue, which would be too much trouble.

By overriding ASN.1 serialization, it's possible to tweak the structure without forking.
I have created #20 and please let me know if it works for you.

Testing #20, The following error came up
CertificateSubjectInfo: Unable to unescape string: O=<redacted>\
InsecureEapNetworkHandler: Cert has no valid issuer.
InsecureEapNetworkHandler: O=<redacted>,CN=<redacted>
InsecureEapNetworkHandler: O=<redacted>\ ,CN=<redacted>

Apparently there is an encoding error with the issuer subject.
Also, note that I have switched the code from using BmpString to PrintableString.


docs: add guide on how to build on Arch Linux

What was wrong?
There was no info about how to build Trin on non-debian-based systems.
How was it fixed?
Added a guide explaining the steps necessary to build Trin on Arch Linux. Also fixed some errors.
The guide was tested on a fresh container built from the official Archlinux Docker image
To-Do
N/A

@danielrachi Not quite sure what happened here, but it looks like you might need to rebase off master and resolve some merge conflicts.

Hmm, that's weird. I think I just pulled and rebased. It looked well on my local git history :man_shrugging:
Will fix it rn.


⚠ gorzdrav.org has degraded performance

In 1bcd03a, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 29088 ms

Resolved: gorzdrav.org performance has improved in 86b79d4.


Failed to save study instance UID and series instance UID

Dear developer, I am trying to modified some tag value of the series dicom image, I following the structure of this script: Examples/DicomSeriesReadModifyWrite/DicomSeriesReadModifySeriesWrite.py, the code can run without error, but study instance UID and series instance UID were not saved to modified files, and the study UID and series UID of the modified files different from slice to slice, I don't how to fix the tricky problem, hope to get some help here, thanks.

Hello @LamFTS,
I suspect you are not following the example as is and missed the relevant line which configures the writer to use the study and series ID you set in the meta-data dictionary and not create new ones on its own.

Thanks for your time @zivy , after re-organizing my script, the UID-saving related problem solved, here come another problem, that the z-axial would be reversed, when I scroll to view the modified series in dicom viewer (i.e microdicom), the series display from bottom to the top, which is reversed from the previous order. I try to modified that line setting value of Instance Number ("0020|0013") from str(i) to str(image3D.GetDepth - i), but problem still exists, I attach the script below, it may help explain the situation. What's more, I would like to ask a question, is letter in key of tag case-sensitive? I saw some key with different case status, which confusing me. Thank for your generous help again. : )
untitled10.txt

Hello @LamFTS,
From your code I see your intent is to do anonymization. I highly recommend not doing this on your own as doing it well is not trivial. Possibly take a look at the following open source resources:

Code from kitware.
Program from PixelMed.

@zivy , I am so gold to be informed of the method of anonymization, that really help me out of the tricky situation. But I still want to know how to fix the problem of z-axial-reversed, I though maybe one day I would encounter the same problem in another task. : D

Hello @LamFTS,
The only DICOM tags that are involved in the ordering are the Image Position (Patient) 0020|0032 and Image Orientation (Patient) 0020|0037.
Please make sure that they are not changed during writing. The Instance Number 0020|0013 is not used in this context. It is only "A number that identifies this image". Not sure what is causing the change you are experiencing. Possibly try another DICOM viewer to see if it is a viewer specific issue.

Dear  ==@zivy ==, thanks for patience and generous help, I finally managed to solve the z-axis reversal after process by inheriting the  Image Position (Patient) 0020|0032 and Instance Number 0020|0013 from original series. What' more, it seems that the line of "0020|000D" need modified, Study UID was set correctly only when I change 0020|000D to 0020|000d.

Hello @LamFTS,
Thanks for identifying the issue and helping us improve SimpleITK.
This pull request, addresses the problem.


Fix bower json error Unexpected token ] in JSON

This extra , will cause bower installation's failure:
bower not-cached    https://github.com/hiasinho/Leaflet.vector-markers.git#*
bower resolve       https://github.com/hiasinho/Leaflet.vector-markers.git#*
bower checkout      leaflet.vector-markers#0.0.5
bower EMALFORMED    Failed to read /tmp/shahin/bower/5dca7318ee3361e5724a508b55670d46-32548-tRIz8X/bower.json

Additional error details:
Unexpected token ] in JSON at position 607

@hiasinho Would really appreciate being able to get this one merged in, thank you.

:+1:


TechDocs: Sidebars not adjusting positions

Hey, I just made a Pull Request!
Sidebars in TechDocs were not adjusting position automatically. This appears to be due to scroll events in some part of the document not bubbling to window level. Scroll listeners at window level changed to use capture phase.
:heavy_check_mark: Checklist

[:heavy_check_mark: ] A changeset describing the change and affected packages. (more info)
[ NA  ] Added or updated documentation
[ NA ] Tests for new functionality and regression tests for bug fixes
[ NA ] Screenshots attached (for UI changes)
[ :heavy_check_mark: ] All your commits have a Signed-off-by line in the message. (more info)

Hey @adrianke77, this pull request got me quite curious about in which case the sidebars are not adjusting positions. Could you give an example where the behaviour is not as expected?
The reason why the event is not bubbling out to window should be because it is emitted from within the shadow root of the Reader. It would need to set composed: true to "escape" the shadow root (some examples here).

Hey @adrianke77, this pull request got me quite curious about in which case the sidebars are not adjusting positions. Could you give an example where the behaviour is not as expected?
The reason why the event is not bubbling out to window should be because it is emitted from within the shadow root of the Reader. It would need to set composed: true to "escape" the shadow root (some examples here).

It didn't seem to be adjusting for any of the techdocs (eg on documented-component) until i made the change. Are you seeing seeing something different on current master?

@adrianke77 I verified your fix is working 👍
Before when scrolling the sidebars are in arbitrary position

After fix

@ottosichert - this is the scroll event being listened to and I am not sure of how to use the composed: true attrib with it and I can find only examples of using composed attrib when firing Custom events. Happy to hear any suggestions

Gonna go ahead and merge this--worth getting out this week.  Thanks again @adrianke77!


Repositories components

Try to fetch data from the endpoint and use that instead the json-file.
Here is is link to fetch unfiltered all the repositories: https://core.ac.uk/repositories/datatable?start=0&length=10000&_=1546528237293


time_stamp type changed from float to string

Close #153

I'm trying to think of a way merge #158, #159, #160, #162, & #162 in a single PR such that we only have to bump the version number once; i.e., this should at least constitute a patch release, since we're fixing "patching" requirements.

I'm trying to think of a way merge #158, #159, #160, #162, & #162 in a single PR such that we only have to bump the version number once; i.e., this should at least constitute a patch release, since we're fixing "patching" requirements.

I can't think of an elegant way to handle these version bumps, so lets just bump the minor version no. per PR

I'm trying to think of a way merge #158, #159, #160, #162, & #162 in a single PR such that we only have to bump the version number once; i.e., this should at least constitute a patch release, since we're fixing "patching" requirements.

I can't think of an elegant way to handle these version bumps, so lets just bump the minor version no. per PR

Sorry, I meant "patch" release in this comment :facepalm:


ligand_fixes

Ligand related fixes

[x] removeHs more systemically
[x] minor bugfix in rascalMCES unmatched bond masking in get_template_to_mol_matches and in get_matched_template_v2
[x] increase rascal_opts.maxBondMatchPairs to 5000 in get_matched_template_v2
[ ] Ligand Tanimoto similarity fix (store above 5k)
[ ] Ligand MMP similarity scoring in test stratification
[ ] remove code that is not used from smallmolecules.py
[ ] move useful rdkit functions from data to core
[ ] update artifacts (cf. posebusters)
[ ] update bindingDB to 2024.11 version?
[ ] fix nucleic acids bug: https://github.com/plinder-org/plinder/issues/61
[ ] tbd

Test ligand_template2resolved_atom_order_stacks for:
4u9h__1__1.B__1.J
4u9i__1__1.B__1.L
have more atoms in the resolved structure than in the template. Most likely a result of improperly removed hydrogens being saved to SDF.


⚠ Samsung has degraded performance

In a5195d8, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2504 ms

Resolved: Samsung performance has improved in 6c04d4f.


Drop or revise "Make Certain" feature for lens creation in MimirVizier

Is there a compelling reason to keep this feature?
As implemented, it kills ALL fine-grained provenance (by defining the newly created lens as an entirely new table). This kind of defeats the purpose of Mimir.  Proposed paths forward include:

Drop "Make Certain" entirely.
Implement it Lens-side (i.e., lenses can register pre-acked models)
Do a rewriting pass over the lens view, adding a "Ignore" field to VGTerms (DataWarnings can be outright removed).

My personal preference would be removing Make Certain.  @mrb24 : What do you think?

dropped "Make Certain" completely. closed by commit: 5369d153bcbe57f0ac4e467f54e03128b2957636


Move local common protobuf files to frequenz/api/weather

The repo-config documentation parts appear to be looking for docs for
frequenz/api/common in the submodules/frequenz-api-common
directory, which we have temporarily removed.
This change moves the files out of frequenz/api/common, in order to
get the documentation working.

This was unnecessary.


Multiple App level Alerts have incorrect rendering on low resolution screen

Summary
Multi-Alert component appears incorrectly on low resolution screens.
Expected behavior
Correct render on low resolution screens.
Examples
Open the Clarity's site on the browser and resize.

API
Is possible to use the styles below. The code is on the file app.component.scss. Repository: https://github.com/ronymesquita/project-with-clarity
@media only screen and (max-width: 768px) {
    .alert-item .alert-icon-wrapper {
        align-self: center;
        margin-top: 0;
  }

  .alert-item .alert-text {
      margin: 0;
      max-width: 100%;
      width: auto;
      flex-basis: unset;
  }

  .alert-item .alert-actions {
      flex: unset;
  }
}

I remember this being part of the design, the spec specifically had alerts go on 2 lines on smaller screens, the description on top and the actions under. I'll let UX confirm that when they can.

Can be supported more lines, aligning the icon and the text?

The wrapping is intentional but I agree that the alignment needs work. I will open this up for contributions as it is a fairly straightforward CSS fix.

@mathisscott Something like this?

Yes. Facilitates the reading and maintain the icon visible.


[Bug]:

Current Behavior
Right after installing the library and following the quickstart I'm getting the error 500 At least one chain must be set before attempting to connect a wallet
I'm on Nuxt3, Vue3 and my code is pretty straightforward:
<script setup>

import Onboard from '@web3-onboard/core'
import injectedModule from '@web3-onboard/injected-wallets'
import { ethers } from 'ethers'

const MAINNET_RPC_URL = 'https://mainnet.infura.io/v3/...'

const injected = injectedModule()

const onboard = Onboard({
    wallets: [injected],
    chains: [
        {
            id: '0x1',
            token: 'ETH',
            label: 'Ethereum Mainnet',
            rpcUrl: MAINNET_RPC_URL
        }
    ]
})

const wallets = await onboard.connectWallet()

console.log(wallets)

</script>

Expected Behavior
not getting the error At least one chain must be set before attempting to connect a wallet
Steps To Reproduce

install Onboard
try the quickstart code https://github.com/blocknative/web3-onboard/tree/web3-onboard/2.3.0#quickstart

What package is effected by this issue?
@web3-onboard/core
Is this a build or a runtime issue?
Runtime
Package Version
2.13.0
Node Version
16
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
Relevant log output
500
At least one chain must be set before attempting to connect a wallet

at ./app.js:40:78
at Module.withAsyncContext (./node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:7558:21)
at setup (./app.js:40:47)
at _sfc_main.setup (./app.js:104:23)
at callWithErrorHandling (./node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:157:22)
at setupStatefulComponent (./node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:7176:29)
at setupComponent (./node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:7131:11)
at renderComponentVNode (./node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:172:17)
at Module.ssrRenderComponent (./node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:624:12)

Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

the problem is due to the use of <script setup>, because using the mounted() function it works nicely

@inmarelibero thank you for reporting a solution to this issue! I will close this issue as resolved with you fix above


[MNT] - Fix plt kwargs for plot_points

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3e91dea) 98.84% compared to head (ca71682) 98.84%.
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   98.84%   98.84%
=======================================
  Files         100      100
  Lines        3900     3900
=======================================
  Hits         3855     3855
  Misses         45       45

Files
Coverage Δ

spiketools/plts/data.py
94.59% <100.00%> (ø)

spiketools/version.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Improve signOutUser

Nulls all user attributes upon signout
Makes the call to signOutUser require no input parameters

Codecov Report

Merging #11 into master will increase coverage by 0.7%.
The diff coverage is 37.5%.

@@            Coverage Diff            @@
##           master      #11     +/-   ##
=========================================
+ Coverage   39.59%   40.29%   +0.7%
=========================================
  Files           6        6
  Lines         197      201      +4
  Branches       27       27
=========================================
+ Hits           78       81      +3
- Misses        119      120      +1

Impacted Files
Coverage Δ

src/actions.ts
15.38% <0%> (-0.12%)
:arrow_down:

src/reducers/current-user/index.ts
75% <0%> (+3.57%)
:arrow_up:

src/types.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319c98b...2ea3fb9. Read the comment docs.

 Make signOutUser clear all User state

 Make signOutUser less dependent on user input


Suggestion: Add all vulnerabilities from testssl output

Hey, I was wondering if you are considering adding an option to parse all vulnerabilities from testssl output! I made a few changes to your script for my own personal use, if you want I can (try) and submit a pull request. However, I just wanted to know if there was a specific reason you don't already do this and rely on the hard-coded dictionary.
Thanks, awesome script btw!

Hi @s3nn,
Thanks for your feedback.
Indeed, there is a reason behind my choice of relying on a hard-coded dictionary for the vulnerabilities to parse. This is mainly due to the selection of findings I usually include into my pentest reports (I willingly ignore some testssl findings that I do not judge super relevant for my cases). This is also due, to my need of including the generated Excel tables within the pentest report (.docx) without having to change the page orientation.
In previous versions of the script, I had a -filter option which let the user decide of what vulnerability to parse but it was a bit heavy, therefore I decided that any change would be made by commenting (out) directly the source code.
Maybe this feature could be brought back with default (which would process my current choice of vulnerabilities) and all (which would process all vulnerabilties) values.
Kind regards,
Alex


x/tools/gopls: Highlight the symbols in comments, and support jump to the definition of symbols

gopls version
v14.2
go env
unimportant

What did you do?
unimportant
What did you expect to see?
In Golang, documentation is maintained in code comments. The comment contain a lot of symbols, Highlighting these symbols will make reading clearer. When reading the documentation, you may want to look at the definition of the commit object, so improving the ability to jump would be great.

highlight symbols in comments
suport go to definition for symbols in comments

These feature are already implemented in Goland.
Goland

Vscode

What did you see instead?
unimportant
Editor and settings
No response
Logs
No response

I don't think that GoLand does the right thing either. Only [Context] should be rendered as a link, because the author explicitly marked it as one, cf. pkg.go.dev: https://pkg.go.dev/context#Background

I see this feature request is relevant to a couple of different functionalities gopls is offering.

textDocument/documentLink. Not sure though if editors themselves color differently the parts associated with links. (vscode doesn't seem to color linkified texts).

Semantic tokens - symbols in comments may be annotated with the documentation modifier. For example, "Background" and linkified symbols may be differently rendered.

textDocument/hover. Hover UI can use richer presentation (for symbol documentations), but gopls does not seem to handle [] notation yet.

@hyangah

textDocument/documentLink. Not sure though if editors themselves color differently the parts associated with links. (vscode doesn't seem to color linkified texts).

I hope "textDocument/definition" is also supported, because I hope to use a shortcut key to jump to the corresponding definition.

Semantic tokens - symbols in comments may be annotated with the documentation modifier. For example, "Background" and linkified symbols may be differently rendered.

The "doccumentation" modifier is suitable, bu it seems that many themes in vscode do not highlight this.

Just to double check: will this will work with any comment, or just with godoc comments? Even if non-godoc comments don't get rendered as godoc and don't strictly speaking have support for links, I still use this format in them for the sake of consistency and clarity when I refer to a Go identifier, particularly from another package.

@mvdan This decision is still open to discussion, although I might personally prefer not to work with any comments.
Think about it from a consistency perspective, It would be better to follow the godoc link rules, but I see many packages that don't go out of their way to follow the godoc link rules.

After some discussion, due to consistency and performance considerations, it only takes effect for doc links. More details can be found in CL  https://go.dev/cl/553836

After some discussion, due to consistency and performance considerations, it only takes effect for doc links. More details can be found in CL https://go.dev/cl/553836

As long as [Foo] works in any comment, godoc or not, that's what I wanted :) I meant that I use this format in non-godoc comments too, such as those inside function bodies, and I'd like gopls to support them too. pkgsite doesn't have to, since it doesn't render those comments in any way.

@mvdan Ok, now it's exactly what you expected.

Just used this for the first time, and it's so great!


Refactor test utils into ambry-test-utils subproj

There are many test utilities that are shared across many subprojects
and even dependended on when writing tests for wrappers that extend open
source Ambry (like AmbryLI for LinkedIn). Generally, depending on test
artifacts across projects is not a great practice (issues handling
transitive dependencies with non-standard classifiers), so this project
moves the test utilities used across repos into an ambry-test-utils
subproject.
For now, this targets moving only the test dependencies that are
depended on by LinkedIn internal projects to ambry-test-utils. Going
forward, we can simplify our test dependencies within the open source
repo by moving more classes into ambry-test-utils.

Codecov Report

Merging #1420 into master will increase coverage by 0.4%.
The diff coverage is 88.63%.

@@             Coverage Diff             @@
##             master    #1420     +/-   ##
===========================================
+ Coverage     72.48%   72.89%   +0.4%
- Complexity     7107     7531    +424
===========================================
  Files           516      541     +25
  Lines         40202    42044   +1842
  Branches       5062     5268    +206
===========================================
+ Hits          29142    30648   +1506
- Misses         9640     9870    +230
- Partials       1420     1526    +106

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com/github/ambry/utils/MockClock.java
100% <ø> (ø)
3 <0> (?)

...in/java/com/github/ambry/commons/TestSSLUtils.java
94.96% <ø> (ø)
19 <0> (?)

...thub/ambry/store/MockStoreKeyConverterFactory.java
94.44% <ø> (ø)
5 <0> (?)

...com/github/ambry/rest/MockRestResponseChannel.java
83.33% <ø> (ø)
30 <0> (?)

...ava/com/github/ambry/clustermap/MockReplicaId.java
88.23% <ø> (ø)
26 <0> (?)

...thub/ambry/account/InMemAccountServiceFactory.java
66.66% <ø> (ø)
6 <0> (?)

...va/com/github/ambry/clustermap/MockDataNodeId.java
85.52% <ø> (ø)
31 <0> (?)

...a/com/github/ambry/clustermap/MockPartitionId.java
97.29% <ø> (ø)
30 <0> (?)

...ain/java/com/github/ambry/store/MockIdFactory.java
66.66% <ø> (ø)
2 <0> (?)

...in/java/com/github/ambry/router/ByteBufferRSC.java
73.17% <ø> (ø)
8 <0> (?)

... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb99b62...24ccc30. Read the comment docs.


CAN SKIP SPLASHSCREEN.PY

When I added this to mainprog it broke it when hitting the x on the login screen. I will fix this in the next build.

Fixed in dev. Never was a problem in main branch. Closing this issue.


Class 'Adldap\Laravel\Resolvers\UserResolver' not found

Laravel Version: 5.5-dev
Adldap2-Laravel Version: v3.0.5
PHP Version: 7.1

Description:
New install, maybe related to 5.5 dev? Same setup/install seems to work fine on 5.4.
 I'm assuming you might have downloaded dev-master from composer, as that would lead to this error.


Allow getting query results

Superset provides a /superset/sql_json/ endpoint to fetch results of a given SQL query. We could use this to get the data of a dataset or a saved query, or to run arbitrary SQL against a database.

+1


fix(Dropdown): omit moveSelectionBy() when options aren't defined

Fixes #1875.

Codecov Report

Merging #2119 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2119   +/-   ##
=======================================
  Coverage   99.76%   99.76%
=======================================
  Files         150      150
  Lines        2596     2596
=======================================
  Hits         2590     2590
  Misses          6        6

Impacted Files
Coverage Δ

src/modules/Dropdown/Dropdown.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c003fe9...8978737. Read the comment docs.

Since this is already submitted, I'll merge.  However, I want to avoid any fixes for using children with the Dropdown and instead direct users to use the options prop.
I'm afraid we'll end up on a slippery slope of fixing small issues with children constantly, thereby supporting it.

Released in<EMAIL_ADDRESS>


Strawberry isn't graphql-ws compatible

In #1623 I discuss how strawberry seems to diverge from the official graphql-ws protocol (

strawberry uses start message instead of subscribe
strawberry doesn't respond with correct ws error in case of invalid message
strawberry doesn't support the relatively new PING/PONG messages

My limited internet skills have not enabled me to find out what is the origin of the start message, if that conforms to some different graphql-ws specification.
If you like I could submit a PR to fix some of those compliancy issues, maintaining start as a historic fallback.

@kristjanvalur a PR would be nice 😊 pinging @DoctorJohn for context around the support of GraphQL WS :)

Strawberry fully supports the latest specs of both subscription protocols. Strawberry also responds to pings. If you want server side pings you need to subclass the corresponding handler and send server side pings in the interval you want.
Take a look at the discussing you linked. I'm pretty sure you confused the legacy with the newer protocol. The new protocols repository is called graphql-ws while the actual protocol is called graphql-transport-ws. The legacy protocol is called graphql-ws.

Anyway, knowint that GraphiQL is using the legacy protocol is helpful. Would be good to have it updated.

I'm currently working on a PR updating our GraphiQL template to support the newer spec :)


Crash on wayland

Description
After about 1 minute app crashes on wayland
To Reproduce
This was on hyprland, but it should be applicable for any wayland compositor

Run app
Do something for ~1 minute
Crash

Additional Info
stdout log:
(pinta:22773): GdkPixbuf-CRITICAL **: 23:18:47.414: gdk_pixbuf_calculate_rowstride: assertion 'width > 0' failed
// ^ it's ok
(pinta:22773): GdkPixbuf-CRITICAL **: 23:18:47.414: gdk_pixbuf_calculate_rowstride: assertion 'width > 0' failed
// ^ it's ok

Gdk-Message: 23:19:12.631: Error 22 (Invalid argument) dispatching to Wayland display.

// ^ it's ok means after that app keeps working

Version
Arch linux, pinta version - 2.1.2

Thanks for the report!
Would you be able to try out the master branch to see if it has the same issue?
The master branch is ported to GTK4 (Pinta 2.1 is GTK3) so there's a good chance that might fix Wayland issues in GTK

Yep master is fine, closing this


retry mechanism is not working with filer for a specific case

The retry mechanism of the filer does not work for a very specific case. I'll try my best to explain the issue.
when the filer is trying to stream some chunk from volume server URLs (https://github.com/chrislusf/seaweedfs/blob/689f5513a955528f365e79c30d9965e7826b1509/weed/filer/filechunk_manifest.go#L158)
the retry mechanism will be bypassed for this reason (https://github.com/chrislusf/seaweedfs/blob/689f5513a955528f365e79c30d9965e7826b1509/weed/filer/filechunk_manifest.go#L175)
because of the reason (https://github.com/chrislusf/seaweedfs/blob/689f5513a955528f365e79c30d9965e7826b1509/weed/util/http_util.go#L329).
this will only happen when the filer is trying to stream some chunk and filler send the HTTP request to the volume server (https://github.com/chrislusf/seaweedfs/blob/689f5513a955528f365e79c30d9965e7826b1509/weed/util/http_util.go#L297) and then get a 200 OK (https://github.com/chrislusf/seaweedfs/blob/689f5513a955528f365e79c30d9965e7826b1509/weed/util/http_util.go#L302)  so it starts to stream some bytes (https://github.com/chrislusf/seaweedfs/blob/689f5513a955528f365e79c30d9965e7826b1509/weed/util/http_util.go#L324) but at this moment if the volume server is killed then it won't work for this condition (https://github.com/chrislusf/seaweedfs/blob/689f5513a955528f365e79c30d9965e7826b1509/weed/util/http_util.go#L329)
I think the solution should be

for {
m, err = reader.Read(buf)
fn(buf[:m])
if err == io.EOF {
return false, nil
}
if err != nil {
return true, err
}
}

please let me know what do you think about this. thanks

if the volume server is killed, the request should not retry, correct?

if the volume server is killed, the request should not retry, correct?

I think the request should be retried again for the same chunk. suppose for a very large file all of the chunks are transmitted except the last chunk. if it's retried again then there is a chance we will be able to send the chunk from another volume server(https://github.com/chrislusf/seaweedfs/blob/689f5513a955528f365e79c30d9965e7826b1509/weed/filer/filechunk_manifest.go#L146). right?

you are right. you can send a PR?


Pipe update

NaCl updates to implement pipe in SafePOSIX.
This accomplishes ripping out the old pipetable that was in NaCl and transferring pipes to SafePOSIX. This also updates how NaCl descs are replicated on fork.
For review:
in nacl_app_thread.c:

updates NaCl desc replication on fork

in nacl_syscall_common.c:

NaClSysPipe now gets fds from lind, sets them up as NaCl descriptors, and manages cagetable.

Thanks Yiwen!


Final Onshape updates

I restructured this repo. "trunk" is now the clean fork of user-agent-utils. "onshape-trunk" is the base for our changes.
Most of the updates here are to handle the new device name format (and order) that our Android and iOS apps are reporting in the user-agent header.

:shipit:

What's the status of this PR?

This was pushed a long time ago. I think I ended up moving to another branch.


I add "place" module in local/wit.json

I want to add "place" module!
"place" module works as follows:
users send "place" module to JARVIS then JARVIS pick one of many places to travel and send a message about the picked place to user!

Thank you for taking the time to contribute! This is sincerely appreciated. 😇
(Powered by GitMate.io)


CachedImage not created

Hey there, I have a weird situation where one of my images was getting rewritten but no CachedImage or Repository were getting automatically created for it. I have looked through the controller logs for any hints but am not seeing anything obvious. The CachedImage and Repository are being created for other images in the same repo but not this one.
The only thing I could think of is that the problematic image name and tag are longer than others, so I tried manually creating the Cachedimage and Repository to see if I got any errors, but it worked fine and now my Pods are starting.
Has anyone seen anything like this before? Are there specific log lines I can look at in the controller log to try to troubleshoot? Thank you!

Hello,
I would need more information in order to help you. Could you please provide:

Relevant logs (specifically the pod controller logs, which is in charge of creating CachedImages). You can enable debugging logs with .controllers.verbosity: DEBUG to get more details.
A minimal reproducible example of a Pod producing this behavior.
Any custom configuration in your values.yaml.

Thanks for reporting!

Ah thank you, I will enable the higher verbosity and try to reproduce in a test cluster in the next few days.


adding info about iCub CPUs

all possible CPU boards installed on iCub robot

I Agree with @pattacini : I'd rather put the above info in a dedicated page under "iCub HW" section rather then under "iCub OS", then we can add a link from the "The OS on the iCub Head" section there

I Agree with @pattacini : I'd put the above info in a dedicated page under "iCub HW" section rather then under "iCub OS", then we can add a link from the "The OS on the iCub Head" section there

You are right, it's HW-related but it reports info that are more useful to people installing the OS/SW rather than HW guys. That's why I thought it could be placed here. I could remove the imgs because they are quite useless.
If you agree we can leave the table here until there will be a proper page for the iCub Head with all the HW specs.

I prefer to have a link in this section to  separate page under "HW" with this table.
To have here is really misleading

I can propose a PR with the modifications I meant

I can propose a PR with the modifications I meant

Hold on, @maggia80 is on this.

Fine! thanks


Dynamic print statements if verb = True in core and modules

Dynamic printing has been successfully achieved and will be implemented to all subroutines

All subroutines have been updated with dynamic printing


Problem in vim.schedule callback

In file lua/completion/matching.lua line 50, vim.b (I guess for buffer variables ?) is indexed without checking if it's nil, which creates an error for me since it is (nil).
So maybe it could be replaced with something like :
    local matcher_list
    if (vim.b and vim.b.completion_matching_strategy_list) then
        matcher_list = vim.b.completion_matching_strategy_list
    else
        matcher_list = vim.g.completion_matching_strategy_list
    end

However, changing this I have an other error that pops up during the display of autocompletion menu (see picture)

I used the minimal test.vim for this, and I run the nightly build.
Any idea where the problem is ?

vim.b is buffer variables which neovim have bulit-in in a PR(https://github.com/neovim/neovim/pull/12268), if you're running into errors like this, please update to the latest nightly release or manually build neovim from master branch.

Close this for now, feel free to reopen if you still have any issue.

Thanks man, indeed I thought I used the latest build but I had a bad alias for
it.


NioSocketChannelTest falis on lastest 4.1 branch

Expected behavior
There should be no test failures on lastest branch
Actual behavior
git status
On branch 4.1
Your branch is up to date with 'origin/4.1'.
nothing to commit, working tree clean
./mvnw -test
[ERROR] Failures:
[ERROR]   NioSocketChannelTest.testFlushCloseReentrance:107
Expected: is <3>
but: was <0>
[ERROR] Errors:
[ERROR]   NioSocketChannelTest.testFlushAfterGatheredFlush:155 » EOF
[INFO]
[ERROR] Tests run: 327, Failures: 1, Errors: 1, Skipped: 7
Environment
./mvnw -v
Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: /Users/mrdevitt/.m2/wrapper/dists/apache-maven-3.9.5-bin/b0241faf/apache-maven-3.9.5
Java version: <IP_ADDRESS>, vendor: Homebrew, runtime<EMAIL_ADDRESS>Default locale: zh_CN_#Hans, platform encoding: UTF-8
OS name: "mac os x", version: "14.2", arch: "aarch64", family: "mac"
More
I tried to debug these two tests. It looks like the channelActive method of the childHandler is not invoked, but I can't figure out why. Can somebody help?

After hours of debugging, I finally find that the issue is caused by my proxy client ClashX. When I turn it on,  Socket s = new Socket(NetUtil.LOCALHOST, ((InetSocketAddress) address).getPort()); will connect to the proxy server instead of the netty test server. So the channelRead method of ServerBootstrapAcceptor will not be invoked. Turning off the proxy or add  ProxySelector.setDefault(null); to the test method fixed the issue.


Karma Proxies have never worked

Please read http://karma-runner.github.io/4.0/intro/troubleshooting.html first
There's over 7,000 questions on StackOverflow concerning Karma Proxies
Over the past three years I keep trying to get it to work but it never does.
Is there a working example somewhere that shows how this works, what it does, what it doesn't do etc.  As far as I can tell; there's no way to redirect anything that goes to the default Karma port.  The idea being that I don't want 404 errors; I want test data from the real site.
The real question is shouldn't this work?

// trying to redirect ports.

      proxies: {
         "http://localhost:9876/Configuration/SettingGroups": {
            target: "http://localhost:8180/Configuration/SettingGroups",
            changeOrigin: true,
         },
      },

//or this...

      proxies: {
         "/Configuration/SettingGroups": {
            target: "http://localhost:8180/Configuration/SettingGroups",
            changeOrigin: true,
         },
      },

//or this...

      proxies: {
         "/Configuration/SettingGroups": "http://localhost:8180/Configuration/SettingGroups"
      },

The official documentation of proxies provides usage examples. Depending on your setup one of the last two samples should work. There is a test verifying this behaviour and it passes.
Please follow the advice from http://karma-runner.github.io/4.0/intro/troubleshooting.html and run Karma with --log-level debug. Look for records like DEBUG [proxy]: proxying request - /Configuration/SettingGroups to localhost:8180. This means that the proxy is sending request to your server. Check logs on your server to verify that these requests are reaching the server and are processed successfully.

Thanks... I did get it to work, here's the rules:

In first part do not include this part "http://localhost:9878", it already "knows" the port

Starting with first slash, put in complete path on first part. e.g. /Configuration/SettingsGroups

In the 2nd part include only the URL portion (with new port)
proxies: {
"/Configuration/SettingGroups": "http://localhost:8180",
"/Identity/Info": "http://localhost:8180",
},

Partial paths do not work in 1st part
  proxies: {
     "/Configuration": "http://localhost:8180",
     "/Identity": "http://localhost:8180",
  },

Wild Cards do not work either:
proxies: {
"/Configuration/": "http://localhost:8180",
"/Identity/": "http://localhost:8180",
},
If you make any changes to karma.config you must save and bring up new instance of 'ng test', if using Angular.

I wrote an article documenting my findings and how to configure the proxy. There's probably more to it, but this got me going.  Thanks!
https://dev.to/jwp/angular-karma-proxy-configuration-1kbb

Thanks again...

Good writeup @Javaman2! Couple of corrections:

The right side which is the "redirection". It includes the Schema, port but not the path. This is because the proxy redirects to the same path.

You can actually specify the path on the right side as well. It allows to proxy request to a different path than original. But it will use the path from the right side by default if you omit it.

You still need to configure CORS support on the back-end because the outbound requests look like this:

A changeOrigin option is an alternative solution. As pointed out in the documentation: changeOrigin Whether or not the proxy should override the Host header using the host from the target (default false).

Karma Proxy Configuration Internals

This has nothing to do with Karma specifically. Any TCP connection consists of two sockets (host + port pairs). I would recommend to read up on how TCP works.


Explicitly initiate sidebar with display: none.

In the end I actually thing that the missing display: none is coming from the NeXT theme. This patch actually does fix the issue for me.
Fixes #239

Thanks @mcepl. But the sidebar currently is hidden via setting its width to 0. I need to check that if it can be set to display: none without effecting existing behavior.

You are right ... something fixed this problem between 7df7a6b and 05c00e8 . I cannot reproduce it anymore with the current master.


[SPARK-20214][ML] Make sure converted csc matrix has sorted indices

What changes were proposed in this pull request?
_convert_to_vector converts a scipy sparse matrix to csc matrix for initializing SparseVector. However, it doesn't guarantee the converted csc matrix has sorted indices and so a failure happens when you do something like that:
from scipy.sparse import lil_matrix
lil = lil_matrix((4, 1))
lil[1, 0] = 1
lil[3, 0] = 2
_convert_to_vector(lil.todok())

File "/home/jenkins/workspace/python/pyspark/mllib/linalg/__init__.py", line 78, in _convert_to_vector
  return SparseVector(l.shape[0], csc.indices, csc.data)
File "/home/jenkins/workspace/python/pyspark/mllib/linalg/__init__.py", line 556, in __init__
  % (self.indices[i], self.indices[i + 1]))
TypeError: Indices 3 and 1 are not strictly increasing

A simple test can confirm that dok_matrix.tocsc() won't guarantee sorted indices:
>>> from scipy.sparse import lil_matrix
>>> lil = lil_matrix((4, 1))
>>> lil[1, 0] = 1
>>> lil[3, 0] = 2
>>> dok = lil.todok()
>>> csc = dok.tocsc()
>>> csc.has_sorted_indices
0
>>> csc.indices
array([3, 1], dtype=int32)

I checked the source codes of scipy. The only way to guarantee it is csc_matrix.tocsr() and csr_matrix.tocsc().
How was this patch tested?
Existing tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Test build #75528 has started for PR 17532 at commit f88eb6b.

cc @jkbradley @MLnick @holdenk

Test build #75530 has started for PR 17532 at commit 10be94a.

Test build #75528 has finished for PR 17532 at commit f88eb6b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75528/
Test PASSed.

Test build #75530 has finished for PR 17532 at commit 10be94a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75530/
Test PASSed.

I don't think is directly related, but, I tried to make a similar change to the Spark Scala implementation of this type of conversion and couldn't make it work, just because it changed a bunch of little behaviors. (I could look up the JIRA.) This could be fine, being more narrow.

Are you able to write a unit test which passes data through _convert_to_vector and fails before this fix?

Btw, I'd really like to get this into 2.2, which will be cut soon.  Let me know if you'd like me to take it over.  Thanks!

@jkbradley Thanks for comment. I will add the unit test now.

@jkbradley An unit test is added. Please check this again. Thanks.

Test build #75560 has started for PR 17532 at commit 2612d66.

Test build #75560 has finished for PR 17532 at commit 2612d66.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75560/
Test PASSed.

LGTM
Merging with master and branch-2.1, branch-2.0
Thanks a lot!


Transparent Spatial Materials clip with Sprite3Ds

Godot version
3.6
System information
Windows 10, Ryzen 5 2600, GLES 3, Nvidia GTX 1080
Issue description
Transparent spatial materials often clip with objects like Sprite3Ds, quads, and other transparent materials, causing these affected objects to render in front of said material.

Steps to reproduce

Create a Spatial object (such as a mesh) and apply a SpatialMaterial on the object
Give the SpatialMaterial the "Transparent" flag and give it some kind of texture with transparency on it.
Create another Spatial object (a mesh or Sprite3D) with the same properties as above

Place these objects anywhere, and if one is in front of the other, the object that is behind it will render on top in certain angles.
Minimal reproduction project
N/A

This is a common limitation of transparency sorting.
IIRC there is a Z priority setting on your 3d spatials, play around with that value to improve things

This is not a bug: https://docs.godotengine.org/en/stable/tutorials/3d/3d_rendering_limitations.html#transparency-sorting


Missing explicit 'title' attributes in layer options

The 'title' attribute is not present in the BaseLayer constructor options, nor in its class accessors.
I understand this attribute is not part of the core OL object model, but it is a de facto necessary attribute in certain use cases (f.i. in the layer switcher), and is (IMHO) a legitimate core attribute of a layer.
The reason I consider this now necessary is that in a typescript context, as the OL types (https://www.npmjs.com/package/@types/ol) do not advertise that attribute, it is impossible to use it.
It can be argued that this is the responsability of the OL types author, but he would probably be reluctant in advertising an attribute that's not officially part of the API (and rightfully so).
This issue has been raised once already (#9115), but closed automatically for the lack of an answer.

Hi,
This could be argued for other properties such as name, label... What would be considered acceptable or not then? This is IMO something to be dealt with in the types definition, e.g. by allowing unknown properties in the constructor options type.

Thank you for your answer.
My personal opinion as a developer is that the 'title' has become a de facto primary attribute of a layer, and maybe some others have too. Leaving those as undocumented attributes forces the typed Options class to accept unspecified attributes (as suggested in #9115 ; not good i think)
, or to move such attributes in an untyped bag of 'extra' attributes (would break current implementations).
But being a user and not a developer in this case, I leave it up to the OL team and the types author (@hanreev ?) to come to an agreement.
My criteria as a user is : I need to be able to set a title while respecting the published types.

IMO the right solution would be to have the constructor accept a TileOptions & {[prop: string]: any} type.

I have implemented those types in my personal project with ol v5.
Please take a look to this commit: hanreev/types-ol@4617c9d78c347170f24c4f6cf4e64e08476ef1b7

Pros:

We can set extra properties to constructor options

Cons:

If there are typos in the declared option, the compiler won't show us any alert

Alternatives:

set
setProperties

I may publish those types to @hanreev/types-ol but not to @types/ol


Adding Read ROI option, Change Read FMR function to allow latest FMR version

Based on the voi.py file, I added the option to read the latest BV roi files (version 6)

Looks good, thanks @ju-ec :)

Looking at df47dbb94cc6d2f7f2fb91cd5f85928d8d98815d @ju-ec , are you sure that ResolutionY is NrOfRows and ResolutionX is NrOfColumns?
Do you have some new fmr data that is created in the latest version of Brainvoyager? If so can you run https://github.com/ofgulban/bvbabel/blob/main/examples/read_fmr_export_nifti.py on them to see if the conversion looks right? You can also send me the data.
I have encountered a case that makes me suspect that  actually ResolutionX is NrOfRows and Resolution is ResolutionY.

No, I am not 100% sure. I extracted that information from the New Document Wizard and the resulting FMR:

When I run https://github.com/ofgulban/bvbabel/blob/main/examples/read_fmr_export_nifti.py on the created FMR, the resulting NIfTI is incorrect.
I will send you an example DCM.

Also when checking the final FMR: Resolution X represents the Nr of Columns and Resolution Y Nr of Rows.

I checked again and I think the problem is the communication between the fmr.py and the stc.py.
In the parameter description of stc.py it states that:
res_x: integer
Number of voxels along each row in each slice. Referred to as
"ResolutionX" within the FMR text file.
res_y: integer
Number of voxels along each column in each slice. Referred to as
"ResolutionY" within the FMR text file.
However, I believe it is the other way around: res_x should represent ResolutionY/NrOfRows, as you describe correctly it represents the number of voxels along each row, hence the number of columns.


Is dialtion_rate useful in keras DepthwiseConv2D layer ?

Hi, I read the document  and found dialtion_rate seems not a hyperparameter in DepthwiseConv2D layer.
But you used it in your model
x = DepthwiseConv2D((kernel_size, kernel_size), strides=(stride, stride), dilation_rate=(rate, rate)
I made a toy example to check this:
model=Sequential()
model.add(DepthwiseConv2D(3,strides=1,padding='valid',depth_multiplier=2,\
                          dilation_rate=(2,2),input_shape=(9,9,3)))
model.summary()

Output:
_________________________________________________________________
Layer (type)                 Output Shape              Param #
=================================================================
depthwise_conv2d_6 (Depthwis (None, 7, 7, 6)           60
=================================================================
Total params: 60
Trainable params: 60
Non-trainable params: 0
_________________________________________________________________

If dilation_rate is useful in DepthwiseConv2D , I think Output shape should be (5,5,6) not (7,7,6)
My English is pretty limited, plz don't mind

The dilation rate IS useful in this model. The correct output shape in your example is (7,7,6), so it's working perfectly fine. The dilation_rate is not specified explicitly, but it's passed upstream to tf depthwise conv, you can understand it looking and the code of DepthwiseConv2D layer.

Thanks for your answer , I'll check the source code later.
But there are still something I don't understand.
In example, I don't use padding in this layer. The input shape is still (9,9,3).
I use kernel_size=3 ,strides=1 and dilation_rate=2 in this layer. So ,the effective kernel size should be 5
Why the output shape is (7,7,6)?
I test the dilation_rate in Conv2D layer
dilation rate =1
model_input=Input(shape=(9,9,3))
x=Conv2D(filters=3,kernel_size=3,strides=1,\
         dilation_rate=1,padding='valid')(model_input)
model=Model(model_input,x)
model.summary()

Output:
_________________________________________________________________
Layer (type)                 Output Shape              Param #
=================================================================
input_9 (InputLayer)         (None, 9, 9, 3)           0
_________________________________________________________________
conv2d_8 (Conv2D)            (None, 7, 7, 3)           84
=================================================================
Total params: 84
Trainable params: 84
Non-trainable params: 0
_________________________________________________________________

dilation rate =2
model_input=Input(shape=(9,9,3))
x=Conv2D(filters=3,kernel_size=3,strides=1,\
         dilation_rate=2,padding='valid')(model_input)
model=Model(model_input,x)
model.summary()

Output:
Layer (type)                 Output Shape              Param #
=================================================================
input_10 (InputLayer)        (None, 9, 9, 3)           0
_________________________________________________________________
conv2d_9 (Conv2D)            (None, 5, 5, 3)           84
=================================================================
Total params: 84
Trainable params: 84
Non-trainable params: 0
________________________________________

If dilation_rate is work in DepthwiseConv2D layer, why output shape is (7,7,X) , not (5,5,X)?

hmmm. maybe it automatically pads the input to preserve shape? You can check that output with dilation_rate=2 is different from dilation_rate=1

made a PR to main Keras branch https://github.com/keras-team/keras/pull/12526 which explicitly adds dilation rate to DepthWiseConv2d arguments

Hi, bonlime
After my test , the dilation rate is work in DepthwiseConv2D layers
But I found there is a bug about calculating output shape in Keras  when  I use the dilation_rate in DepthwiseConv2D.
In my test, I use Input shape = (9,9,channel) , kernel = 3, strides=1, dilation_rate=2
model.summary() shows the output shape is (7,7,channels), but the true output shape is (5,5,channels)
Thank you for discussing this problem with me!

I'll test it tomorrow, but if there is a bug, you should open an issue in keras main repo or if you manage to fix - to make a pull request

@Pofatoezil
First of all, I was wrong in my first comment. The right shape in your example should be (5, 5, 6) as you said. I tested it on my machine and it works perfectly fine though.
model=tf.keras.Sequential()
model.add(tf.keras.layers.DepthwiseConv2D(3,strides=1,padding='valid',depth_multiplier=2,\
                          dilation_rate=(2,2),input_shape=(9,9,3)))
model.summary()

Model: "sequential"
_________________________________________________________________
Layer (type)                 Output Shape              Param #
=================================================================
depthwise_conv2d (DepthwiseC (None, 5, 5, 6)           60
=================================================================
Total params: 60
Trainable params: 60
Non-trainable params: 0

print("TF: {}. Keras: {}".format(tf.__version__, tf.keras.__version__))
>> TF: 2.0.0-dev20190317. Keras: 2.2.4-tf

My TF version is 1.9.0 , maybe the bug has been fixed in new version.
I'll upgrade my tensorflow , thank you.

@Pofatoezil
I found the source of bug you noticed and fixed it. The issue was that DepthWiseConv2D().compute_shape didn't support dilation_rate, and it led to the wrong output_shape calculation. Check the PR I mentioned above for additional info

Hi , @bonlime
Thanks you for  check this bug and fixed it.
In your testing example, the calculation of output shape is perfectly right .
The bug seems to be fixed in newest tenseorflow.
But I am struggling in tensorflow-gpu vr 2.0.0a0 installation.
The problem is like tensorflow#22794
Would you mind telling me your tensorflow environment?
Thank you
My environment:
OS Platform and Distribution: Windows 10 Pro
Mobile device: None
TensorFlow installed from: pip install
TensorFlow version: 2.0.0a0
Python Version: 3.6.6
Bazel version: not installed
CUDA/cuDNN version: CUDA 9.0, cuDNN 7.3
GPU model and memory: GF-GTX1060 6G
Visual Studio :visual studio 2015 community


[Feature request] Option to cache results to disk

For sentinelhub integration it would be nice to have an option to cache results to disk.
Requirements:

Cache protobuf results using read/write as string
Cache implementation should be generic. E.g cache object that implements asynchronous get/set operations
The cache object is passed to the main initialiser as an optional object
The FileCache should have options directory (where to put temporary files) and max_age (maximum age in seconds a cached result should be used)
Later we may add cache implementations for redis or memcache
Before caching data, it should be compressed with gzip. The compression logic should be inside the FileCache. The gzip compression level should be controlled with compression_level in the initialiser of FileCache
Cache key should be derived for as a hash from the query (md5 or similar)
Cached results should use sub directories e.g. a hash 2h19e4f3450a should be placed as ./2h/19/e4f3450a
A async cleanup() function should delete old cached results that are older than max_age
If possible it should use file locks, to prevent issues with parallel execution
EDIT: file locks have a high risk for deadlocks. Write a protobuf result to a file with a tilde at the end ./2h/19/e4f3450a~ and then perform a move like mv ./2h/19/e4f3450a~ ./2h/19/e4f3450a

cache = meteoblue_dataset_sdk.FileCache(directory="/tmp", max_age=24*3600, compression_level=6)
# Delete old cached results from that are older than max_age
await cache.cleanup()
client = meteoblue_dataset_sdk.Client(apikey="xxxxxx", cache=cache)

done in #4


Convert readthedocs links for their .org -> .io migration for hosted projects

As per their blog post of the 27th April ‘Securing subdomains’:

Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

Test Plan: Manually visited all the links I’ve modified.

The link on the Github repo description also needs updating.

The HTTPS domains will be redirected to insecure HTTP domains by readthedocs - I tested this for both domains changed by you. Displaying these links as secure links might create a false sense of security with users. Therefore I would change these back to HTTP as long as readthedocs behaves this way.

Thanks guys. Repo description has also been updated.

It depends on what your browser has cached as to the HTTPS redirect I
think, I get HTTPS fine
On Monday, 20 June 2016, Josh Friend<EMAIL_ADDRESS>wrote:

Thanks guys. Repo description has also been updated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flask-restful/flask-restful/pull/596#issuecomment-227258160,
or mute the thread
https://github.com/notifications/unsubscribe/AA0WCRhy4kpzYQZUzlwIgvelJaGnPsGWks5qNvbhgaJpZM4I45yw
.

--
Adam


Make client session a BugValidator instance attribute

Probably due to https://github.com/openshift/elliott/pull/441, we occasionally get this exception while promoting a release:
ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

This happened systematically while promoting a new RC, a task that usually involves sending multiple asynchronous requests to the Errata API. By leaving the client session open during the CLI execution, we should not incur into these server side errors anymore.

/lgtm


Anthropic stats missing

When proxy-ing stats to Helicone using Anthropic model there's some stats missing from the page. Here's the one I've found

Total tokens
Latency
LLM Response

Total tokens and latency seems to be missing from the API request to the server. So maybe worker issue? Here's a snapshot of /api/request result.
{
    "data": [
        {
            "response_id": "<There was an id but now it's redacted>",
            "response_created_at": "2023-10-14T04:30:24.031Z",
            "response_body": {
                "body": {
                    "stop": "|END|",
                    "model": "claude-instant-1.2",
                    "log_id": "<There was and id but now it's redacted>",
                    "completion": " <There was some text but now it's redacted>\" ",
                    "stop_reason": "stop_sequence"
                },
                "helicone_error": "error parsing response",
                "parse_response_error": "error parsing response, TypeError: Fetch API cannot load: undefined, {\"completion\":\" <There was some text but now it's redacted>" \",\"stop_reason\":\"stop_sequence\",\"model\":\"claude-instant-1.2\",\"stop\":\"|END|\",\"log_id\":\"<There was an id but now it's redacted>\"}"
            },
            "response_status": 200,
            "request_id": "6ebc5890-93b6-4234-8d69-292449b83c92",
            "request_created_at": "2023-10-14T04:30:19.674Z",
            "request_body": {
                "model": "claude-instant-1.2",
                "prompt": "<There was some text but now it's redacted>",
                "metadata": {
                    "user_id": "52dd058ca49105049bc7ca02b66b39814cc7ada4"
                },
                "temperature": 0.5,
                "stop_sequences": [
                    "|END|"
                ],
                "max_tokens_to_sample": 512
            },
            "request_path": "https://anthropic.hconeai.com/v1/complete",
            "request_user_id": "<There was an id but now it's redacted>",
            "request_properties": {
                <There was an object but now it's redacted>
            },
            "request_formatted_prompt_id": null,
            "request_prompt_values": null,
            "provider": "ANTHROPIC",
            "request_feedback": null,
            "helicone_user": "<There was an id but now it's redacted>",
            "delay_ms": -1,
            "total_tokens": null,
            "completion_tokens": null,
            "prompt_tokens": null,
            "prompt_name": null,
            "prompt_regex": null,
            "node_id": null,
            "feedback_created_at": null,
            "feedback_id": null,
            "feedback_rating": null,
            "request_prompt": "<There was some text but now it's redacted>",
            "response_prompt": null
        }
    ],
    "error": null
}

But for LLM response being missing I think it's related to #929. Now it doesn't result in an error, but I think what was passed to body shouldn't be an object, but a string, maybe?

So I've been testing it in my local machine and the result is somehow flipped. First I tried to start a Anthropic Proxy worker by setting WORKER_TYPE = "ANTHROPIC_PROXY", and there's no problem at all getting all the stats in the sidebar (shown below).

And yet after flipping it back to WORKER_TYPE = "OPENAI_PROXY" it results in the same missing stats as reported here.

After a bit of digging around I found parseResponse to behave weirdly. In line 266 - 268, where (I assume) it's a conditional for request that's sent to OpenAI and is successful (thus status = 200), it instead check if the status !== 200. Shouldn't that be the other way around?
Here's a pic from the inspect window, as you can see the current request is successful. And yet it responds with parsing error otherwise.

This is resolved right? @fauh45

Haven't really checked, but with the recent PR it should be. Thank you @chitalian!


retry interval exponential

You need to update the tasks patch version in order to consume this change.

Already updated all azure-arm-modeule dependent task in this PR .It is going in same release.


OmniSharp Using Visual Studio 2019's MSBuild, not it's own.

Issue Description
OmniSharp seems to look on the system for versions of MSBuild. It finds the version installed with Visual Studio 2019 and it's own internal version. But it then chooses to use the VS2019 version, not it's own. How can I specify for it to use it's own version?
Steps to Reproduce
Launch VSCode, watch the Output window as OmniSharp loads
Expected Behavior
Choose Extension's version of MSBuild, or allow a choice to be made.
Actual Behavior
OmniSharp picks VS2019's MSBuild (perhaps the first in the list?)
OmniSharp log
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Visual Studio Enterprise 2019 16.3.29209.152 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin"
            2: StandAlone 16.0 - "c:\Users\John Tsombakos\.vscode-insiders\extensions\ms-vscode.csharp-1.21.1\.omnisharp\1.34.1\.msbuild\Current\Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Visual Studio Enterprise 2019 16.3.29209.152 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin"

C# log
Post the output from Output-->C# here
Environment information
VSCode version: 1.38.0-insider
C# Extension: 1.21.1
Dotnet Information
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100-preview8-013656
 Commit:    8bf06ffc8d
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.18362
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview8-013656\
Host (useful for support):
Version: 3.0.0-preview8-28405-07
Commit:  d01b2fb7bc
.NET Core SDKs installed:
2.1.700 [C:\Program Files\dotnet\sdk]
2.1.800 [C:\Program Files\dotnet\sdk]
2.2.300 [C:\Program Files\dotnet\sdk]
2.2.301 [C:\Program Files\dotnet\sdk]
2.2.400 [C:\Program Files\dotnet\sdk]
3.0.100-preview8-013656 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0-preview8.19405.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0-preview8-28405-07 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0-preview8-28405-07 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

Angular2
johnpapa
8.1.1

auto-close-tag
formulahendry
0.5.6

auto-rename-tag
formulahendry
0.1.0

azure-account
ms-vscode
0.8.4

csharp
ms-vscode
1.21.1

debugger-for-chrome
msjsdiag
4.11.7

fabulous
raathigeshan
0.12.0

material-icon-theme
PKief
3.8.1

ng-template
Angular
0.802.2

night-owl
sdras
1.1.3

night-wolf
MaoSantaella
1.7.3

output-colorizer
IBM
0.1.2

quicktype
quicktype
12.0.46

vetur
octref
0.22.2

vscode-azurefunctions
ms-azuretools
0.17.1

vscode-cosmosdb
ms-azuretools
0.10.2

vscode-eslint
dbaeumer
1.9.0

vscode-peacock
johnpapa
3.1.0

vscode-typescript-tslint-plugin
ms-vscode
1.2.2

vscodeintellicode
VisualStudioExptTeam
1.1.9

winteriscoming
johnpapa
1.3.0

this is by design - the VS instance of MsBuild offers a lot more features than what is bundled with OmniSharp (for various reasons), same happens with Mono. The bundled version is always used as a fallback (unless we only find VS2017, not 2019).

Ah, ok. That sounds reasonable.

Let us choose ffs we dont care about those extra features ! or you could make it work with VS version than we wouldn't complain

There is an OmniSharp options for this https://github.com/OmniSharp/omnisharp-roslyn/pull/2038


Spyder hands with complex numbers in Pandas DataFrame

Description
If my .py file contains a pandas.DataFrame with complex values in it, Spyder will become non-responsive and I have to force quit.
An example of the code is below:
import numpy as np
import pandas as pd

A = np.array([[1+1j, 2+2j],[3+3j,4+4j]])
df_A = pd.DataFrame(A) # This is the problem
print df_A

This code crashes Spyder on my machine but runs as expected in the command prompt.
I have tried uninstalling and reinstalling Spyder through Anaconda but this problem persists.
Thanks for the help!
Version and main components

Spyder Version: 2.3.6
Python Version: 2.7.10
Qt Versions:  4.8.6, PyQt4 (API v2) 4.11.3 on Windows

Optional dependencies
IPython >=1.0   :  4.0.0 (OK)
jedi >=0.8.1    :  0.9.0 (OK)
matplotlib >=1.0:  1.4.3 (OK)
pandas >=0.13.1 :  0.16.2 (OK)
pep8 >=0.6      :  1.6.2 (OK)
pyflakes >=0.5.0:  1.0.0 (OK)
pygments >=1.6  :  2.0.2 (OK)
pylint >=0.25   :  None (NOK)
qtconsole >=4.0 :  4.0.1 (OK)
rope >=0.9.2    :  0.9.4 (OK)
sphinx >=0.6.6  :  1.2.3 (OK)
sympy >=0.7.3   :  <IP_ADDRESS> (OK)
zmq >=2.1.11    :  14.7.0 (OK)

This is a duplicate of issue #2654, and it was fixed in Spyder 2.3.7.
This new version will be available in Anaconda in a couple of days :-)

Sorry about that!

Don't worry about it :-) It's just such an annoying bug that people have all the right to open as many bugs as they want about it ;-)


[jdbc, solr] Fix JDBC checkstyle and skip Solr 5.x with JDK 9

Checkstyle redundant throws is unreliable and is removed from newest version of checkstyle.

https://github.com/checkstyle/checkstyle/issues/5#issuecomment-52593242
Updated checkstyle and removed redundant throws from checkstyle.xml

Solr 5.x doesn't work with JDK 9.

Skip the tests on JDK 9
solr pom.xml had spaces and tabs.
Solr 6.x supports JDK 9 - PR #716

Relates to #705

@busbey FYI to fix current remaining JDK 9 items

Thanks @busbey


Block:FAQ

Seen on https://www.caesars.com/caesars-palace/things-to-do/garden-of-the-gods-pool-oasis

@arumsey should i use columns block for FAQ or worth having a distinct block ?

Added Phase One label, since it's needed for phase one.


Allow sorting of * [x]

Solves #5

@ryangomba let me know if that is enough for the PR and if you'll merge and update the plugin. thanks

@ryangomba please take a look


Why are currencies enforced in ParameterResolver.php ?

Hello there,
I'm working on an application that allows administrators to enable/disable currencies in a backoffice, but the problem is that the allowed currencies for paybox are set in the config.
What is the point of enforcing the list of currencies in the config file ?
Also, i couldn't find out which currencies are supported by paybox, any idea ?
Thanks for the great work !

The currencies' list specified in the configuration, is just the list of authorized currencies.
The actual currency of a transaction is specified in the parameter "DEVISE" for DirectPlus or "PBX_DEVISE" for System.
You can find currencies' iso code on http://en.wikipedia.org/wiki/ISO_4217
Good luck :moneybag:

yeah i know this, i have a service to get the numeric code from the text code.
You mean my only solution is to put all the currency codes in the config ?
I can already use many currencies, i was just wondering what was the point of limiting the currencies from config file ?

The point is just to validate currency code. Juste a simple way to avoid error due to a bad currency code.
You're right, with the current implementation, you have to set all the currencies' code you whant to use.
As an evolution, it could be interresting to be able to set the "currencies" parameter to "false" to disable validation.


tests: prepare for custom invoices and templates

There is limited amount of real invoices included in the project and not
everything can be tested using them. To extend tests coverage add place
for storing custom invoices & templates. That way we can write more
complex templates that use more complex syntax.

This depends on https://github.com/invoice-x/invoice2data/pull/411


Denon 1500H shows idle when switched on via remote control.

I use home assistant to read the status of my denon 1500H receiver.
The information I get is correct if I use the HEOS app, spotify or another network based application.
If I switch on the receiver with the remote control the status does not change from idle to playing as it does when using an app.
The volume setting is received though, even when changed via remote controller.
Is this a bug in the software or am I using the denon integration in the wrong way?

@caddyblack not sure why the power status does not sync, it schould.
However note that it can take a while before HomeAssistant sees the power change, the polling intervall is I think 10 seconds.
So i think it could take up to 10 seconds for HomeAssistant to notice a change...

The denonavr integration is perfect for status. Off an on are registered immediately. My HEOS GO speakers are not supported by this integration. For that I installed HEOS integration. That integration does support both devices. Only the HEOS integration does not detect the on / off of my 1500 receiver. Bottomline I have both integrations and use parts of both.


Roll engine 5467f6f63046..649e025f7008 (11 commits)

https://github.com/flutter/engine/compare/5467f6f63046...649e025f7008
git log 5467f6f63046620b0ef1edc72ae06f9fad941cee..649e025f7008b895cb78153833b98f19f572c0f5 --no-merges --oneline
649e025f7 Removed PlatformViewsController if-statements from TextInputPlugin (#34286). (flutter/engine#9938)
ede88d7df Roll src/third_party/skia aa861a1907a1..4a13119a60e2 (9 commits) (flutter/engine#9950)
48b1340ad Fix the geometry test to reflect that OffsetBase comparison operators are a partial ordering (flutter/engine#9925)
971c3f24a Roll fuchsia/sdk/core/linux-amd64 from XG_fYb35A8mJpnMG_I9iBm7yHJyNZYZRgG69a88us_sC to kKw24ZxMzd4Hx6mCaVBSxBJxx7wIKmxP8txe9Cp0dxIC (flutter/engine#9947)
3d7f93a2e Removed logic from FlutterAppDelegate into FlutterPluginAppLifeCycleDelegate (flutter/engine#9893)
273f4cfe8 Split out lifecycle protocol (flutter/engine#9922)
f41be3ea6 Roll src/third_party/skia 58d1f76fc008..aa861a1907a1 (7 commits) (flutter/engine#9946)
53f620f45 [platform view] do not make clipping view and interceptor view clipToBounds (flutter/engine#9937)
a1faebb8f Roll fuchsia/sdk/core/linux-amd64 from IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC to XG_fYb35A8mJpnMG_I9iBm7yHJyNZYZRgG69a88us_sC (flutter/engine#9945)
309ad63e6 Roll src/third_party/skia 95528752e2bd..58d1f76fc008 (1 commits) (flutter/engine#9944)
d852e8a64 Roll src/third_party/skia 19547c91b983..95528752e2bd (1 commits) (flutter/engine#9943)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (aaclarke@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4885910481534976

Commit queue failed; closing this roll.


Clantag Changer doesnt work.

whatever u set it on its always empty -_-'

Idk what ur talking about fam. It works, and with animation too

It doesnt for me, maybe its cuz i already have one from the game setttings? @furioushell98

Yes maybe disable the one from the game and try again cuz it works

i dunno i just recompiled again, still doesnt work, i found a "workaround" if i literally just hit animated clantag real fast and disable it straight away i will have my clantag on but if i dont do that then its empty lol and im not that retarded to not know how to tick a box.

You have to enable first and write the clan tag next.
And if you want to put animated clan tag do all I am saying and enable animated clan tag next.


vid2vid

When will video to video be supported via the SDK?

Hi @GuyARoss, we have nothing to report about V2V in the API at this time.


[Bug]

Hi,
I have one problem with docker composer project.
If I access via <IP_ADDRESS>:8083 login works fine.

But if I access externaly or localhost the login fails.

Best Regards,
Joao

Hi @jot4p!
Have you changed the default username from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Otherwise, pls provide the tbmq logs (tbmq container logs) so I can search for a specific issue.

ahhaa,
a litle big difference !! xD
Thanks