Missing files in sdist

It appears that the manifest is missing at least one file necessary to build
from the sdist for version 0.3.5. You're in good company, about 5% of other
projects updated in the last year are also missing files.
+ /tmp/venv/bin/pip3 wheel --no-binary reppy2 -w /tmp/ext reppy2==0.3.5
Looking in indexes: http://<IP_ADDRESS>:9191/root/pypi/+simple/
Collecting reppy2==0.3.5
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/6f2/4d760a9389276/reppy2-0.3.5.tar.gz (10 kB)
Collecting python-dateutil
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/75b/b3f31ea686f11/python_dateutil-2.8.1-py2.py3-none-any.whl (227 kB)
  Saved /tmp/ext/python_dateutil-2.8.1-py2.py3-none-any.whl
Collecting requests
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/439/99036bfa82904/requests-2.23.0-py2.py3-none-any.whl (58 kB)
  Saved /tmp/ext/requests-2.23.0-py2.py3-none-any.whl
Collecting url
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/8c6/e4a117bfc1566/url-0.4.2.tar.gz (140 kB)
Collecting six>=1.5
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/8f3/cd2e254d8f793/six-1.14.0-py2.py3-none-any.whl (10 kB)
  Saved /tmp/ext/six-1.14.0-py2.py3-none-any.whl
Collecting chardet<4,>=3.0.2
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/fc3/23ffcaeaed0e0/chardet-3.0.4-py2.py3-none-any.whl (133 kB)
  Saved /tmp/ext/chardet-3.0.4-py2.py3-none-any.whl
Collecting idna<3,>=2.5
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/a06/8a21ceac8a4d6/idna-2.9-py2.py3-none-any.whl (58 kB)
  Saved /tmp/ext/idna-2.9-py2.py3-none-any.whl
Collecting certifi>=2017.4.17
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/1d9/87a998c75633c/certifi-2<IP_ADDRESS>-py2.py3-none-any.whl (157 kB)
  Saved /tmp/ext/certifi-2<IP_ADDRESS>-py2.py3-none-any.whl
Collecting urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/882/06b0eb87e6d67/urllib3-1.25.9-py2.py3-none-any.whl (126 kB)
  Saved /tmp/ext/urllib3-1.25.9-py2.py3-none-any.whl
Skipping python-dateutil, due to already being wheel.
Skipping requests, due to already being wheel.
Skipping six, due to already being wheel.
Skipping chardet, due to already being wheel.
Skipping idna, due to already being wheel.
Skipping certifi, due to already being wheel.
Skipping urllib3, due to already being wheel.
Building wheels for collected packages: reppy2, url
  Building wheel for reppy2 (setup.py): started
  Building wheel for reppy2 (setup.py): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: /tmp/venv/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-wheel-k26q4ofp/reppy2/setup.py'"'"'; __file__='"'"'/tmp/pip-wheel-k26q4ofp/reppy2/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-r1w3b7xn
       cwd: /tmp/pip-wheel-k26q4ofp/reppy2/
  Complete output (32 lines):
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib
  creating build/lib/reppy
  copying reppy/exceptions.py -> build/lib/reppy
  copying reppy/cache.py -> build/lib/reppy
  copying reppy/__init__.py -> build/lib/reppy
  copying reppy/parser.py -> build/lib/reppy
  installing to build/bdist.linux-x86_64/wheel
  running install
  running install_lib
  creating build/bdist.linux-x86_64
  creating build/bdist.linux-x86_64/wheel
  creating build/bdist.linux-x86_64/wheel/reppy
  copying build/lib/reppy/parser.py -> build/bdist.linux-x86_64/wheel/reppy
  copying build/lib/reppy/__init__.py -> build/bdist.linux-x86_64/wheel/reppy
  copying build/lib/reppy/cache.py -> build/bdist.linux-x86_64/wheel/reppy
  copying build/lib/reppy/exceptions.py -> build/bdist.linux-x86_64/wheel/reppy
  running install_egg_info
  running egg_info
  writing reppy2.egg-info/PKG-INFO
  writing dependency_links to reppy2.egg-info/dependency_links.txt
  writing requirements to reppy2.egg-info/requires.txt
  writing top-level names to reppy2.egg-info/top_level.txt
  warning: Failed to find the configured license file 'LICENSE'
  reading manifest file 'reppy2.egg-info/SOURCES.txt'
  writing manifest file 'reppy2.egg-info/SOURCES.txt'
  Copying reppy2.egg-info to build/bdist.linux-x86_64/wheel/reppy2-0.3.5.egg-info
  running install_scripts
  error: [Errno 2] No such file or directory: 'LICENSE'
  ----------------------------------------
  ERROR: Failed building wheel for reppy2
  Running setup.py clean for reppy2
  Building wheel for url (setup.py): started
  Building wheel for url (setup.py): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: /tmp/venv/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-wheel-k26q4ofp/url/setup.py'"'"'; __file__='"'"'/tmp/pip-wheel-k26q4ofp/url/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-657k0jvw
       cwd: /tmp/pip-wheel-k26q4ofp/url/
  Complete output (258 lines):
  Building from C++
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib.linux-x86_64-3.8
  creating build/lib.linux-x86_64-3.8/url
  copying url/__init__.py -> build/lib.linux-x86_64-3.8/url
  creating build/lib.linux-x86_64-3.8/url/psl
  copying url/psl/2016-08-16.psl -> build/lib.linux-x86_64-3.8/url/psl
  running build_ext
  building 'url.url' extension
  creating build/temp.linux-x86_64-3.8
  creating build/temp.linux-x86_64-3.8/url
  creating build/temp.linux-x86_64-3.8/url/url-cpp
  creating build/temp.linux-x86_64-3.8/url/url-cpp/src
  x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -Iurl/url-cpp/include -I/tmp/venv/include -I/usr/include/python3.8 -c url/url-cpp/src/url.cpp -o build/temp.linux-x86_64-3.8/url/url-cpp/src/url.o -std=c++11
  x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -Iurl/url-cpp/include -I/tmp/venv/include -I/usr/include/python3.8 -c url/url-cpp/src/utf8.cpp -o build/temp.linux-x86_64-3.8/url/url-cpp/src/utf8.o -std=c++11
  x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -Iurl/url-cpp/include -I/tmp/venv/include -I/usr/include/python3.8 -c url/url-cpp/src/punycode.cpp -o build/temp.linux-x86_64-3.8/url/url-cpp/src/punycode.o -std=c++11
  x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -Iurl/url-cpp/include -I/tmp/venv/include -I/usr/include/python3.8 -c url/url-cpp/src/psl.cpp -o build/temp.linux-x86_64-3.8/url/url-cpp/src/psl.o -std=c++11
  x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -Iurl/url-cpp/include -I/tmp/venv/include -I/usr/include/python3.8 -c url/url.cpp -o build/temp.linux-x86_64-3.8/url/url.o -std=c++11
  url/url.cpp: In function ‘PyObject* PyInit_url()’:
  url/url.cpp:10054:34: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10054 |   __pyx_type_3url_3url_StringURL.tp_print = 0;
        |                                  ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10054:34: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10054 |   __pyx_type_3url_3url_StringURL.tp_print = 0;
        |                                  ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10054:34: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10054 |   __pyx_type_3url_3url_StringURL.tp_print = 0;
        |                                  ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10059:35: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10059 |   __pyx_type_3url_3url_UnicodeURL.tp_print = 0;
        |                                   ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10059:35: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10059 |   __pyx_type_3url_3url_UnicodeURL.tp_print = 0;
        |                                   ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10059:35: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10059 |   __pyx_type_3url_3url_UnicodeURL.tp_print = 0;
        |                                   ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10063:52: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10063 |   __pyx_type_3url_3url___pyx_scope_struct__deparam.tp_print = 0;
        |                                                    ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10063:52: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10063 |   __pyx_type_3url_3url___pyx_scope_struct__deparam.tp_print = 0;
        |                                                    ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10063:52: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10063 |   __pyx_type_3url_3url___pyx_scope_struct__deparam.tp_print = 0;
        |                                                    ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10066:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10066 |   __pyx_type_3url_3url___pyx_scope_struct_1_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10066:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10066 |   __pyx_type_3url_3url___pyx_scope_struct_1_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10066:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10066 |   __pyx_type_3url_3url___pyx_scope_struct_1_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10069:59: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10069 |   __pyx_type_3url_3url___pyx_scope_struct_2_filter_params.tp_print = 0;
        |                                                           ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10069:59: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10069 |   __pyx_type_3url_3url___pyx_scope_struct_2_filter_params.tp_print = 0;
        |                                                           ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10069:59: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10069 |   __pyx_type_3url_3url___pyx_scope_struct_2_filter_params.tp_print = 0;
        |                                                           ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10072:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10072 |   __pyx_type_3url_3url___pyx_scope_struct_3_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10072:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10072 |   __pyx_type_3url_3url___pyx_scope_struct_3_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10072:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10072 |   __pyx_type_3url_3url___pyx_scope_struct_3_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10075:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10075 |   __pyx_type_3url_3url___pyx_scope_struct_4_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10075:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10075 |   __pyx_type_3url_3url___pyx_scope_struct_4_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp:10075:53: warning: ‘_typeobject::tp_print’ is deprecated [-Wdeprecated-declarations]
  10075 |   __pyx_type_3url_3url___pyx_scope_struct_4_genexpr.tp_print = 0;
        |                                                     ^~~~~~~~
  In file included from /usr/include/python3.8/object.h:746,
                   from /usr/include/python3.8/pytime.h:6,
                   from /usr/include/python3.8/Python.h:85,
                   from url/url.cpp:4:
  /usr/include/python3.8/cpython/object.h:260:30: note: declared here
    260 |     Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int);
        |                              ^~~~~~~~
  url/url.cpp: In function ‘void __Pyx__ExceptionSwap(PyThreadState*, PyObject**, PyObject**, PyObject**)’:
  url/url.cpp:12497:24: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_type’; did you mean ‘curexc_type’?
  12497 |     tmp_type = tstate->exc_type;
        |                        ^~~~~~~~
        |                        curexc_type
  url/url.cpp:12498:25: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_value’; did you mean ‘curexc_value’?
  12498 |     tmp_value = tstate->exc_value;
        |                         ^~~~~~~~~
        |                         curexc_value
  url/url.cpp:12499:22: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_traceback’; did you mean ‘curexc_traceback’?
  12499 |     tmp_tb = tstate->exc_traceback;
        |                      ^~~~~~~~~~~~~
        |                      curexc_traceback
  url/url.cpp:12500:13: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_type’; did you mean ‘curexc_type’?
  12500 |     tstate->exc_type = *type;
        |             ^~~~~~~~
        |             curexc_type
  url/url.cpp:12501:13: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_value’; did you mean ‘curexc_value’?
  12501 |     tstate->exc_value = *value;
        |             ^~~~~~~~~
        |             curexc_value
  url/url.cpp:12502:13: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_traceback’; did you mean ‘curexc_traceback’?
  12502 |     tstate->exc_traceback = *tb;
        |             ^~~~~~~~~~~~~
        |             curexc_traceback
  error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for url
  Running setup.py clean for url
Failed to build reppy2 url
ERROR: Failed to build one or more wheels

This is a dup of issue #122

Most of the error is, but the line error: [Errno 2] No such file or directory: 'LICENSE' is the one that I was looking for.  I think this is on 3.8.2 btw

Ah, indeed, the LICENSE thing is not Cython-related.
BTW my travis-ci build with 3.8 doesn't get any Cython complaints. It is 3.8.0.


BindingSource won't stop registering BindingList.Child_PropertyChanged

Firing PropertyChanged event in a class implementing INotifyPropertyChanged causes new registration of BindingList.Child_PropertyChanged method each time it is fired given the following circumstances:

There is a BindingSource and its DataSource is set to that class instance
There is a Binding using that BindingSource and its DataMember is a property path (contains a dot)

For some reason the ParentCurrencyManager_CurrentItemChanged method wraps the changed object in BindingList triggering the HookPropertyChanged method call.
Tested on .Net Framework 4.5.2 and 4.6.1
WindowsFormsApp2.zip
This is the callstack from the reproductive sample I'm attaching above:
WindowsFormsApp2.exe!WindowsFormsApp2.NotifyPropertyChangedBase.PropertyChanged.add(System.ComponentModel.PropertyChangedEventHandler   value) Line 95
System.dll!System.ComponentModel.BindingList<System.__Canon>.HookPropertyChanged(System.__Canon   item) Line 549
System.dll!System.ComponentModel.BindingList<WindowsFormsApp2.Foo>.InsertItem(int   index, WindowsFormsApp2.Foo item) Line 232
mscorlib.dll!System.Collections.ObjectModel.Collection<WindowsFormsApp2.Foo>.Add(WindowsFormsApp2.Foo   item) Line 68
mscorlib.dll!System.Collections.ObjectModel.Collection<WindowsFormsApp2.Foo>.System.Collections.IList.Add(object   value) Line 276
System.Windows.Forms.dll!System.Windows.Forms.BindingSource.WrapObjectInBindingList(object   obj) Line 1374
System.Windows.Forms.dll!System.Windows.Forms.BindingSource.ParentCurrencyManager_CurrentItemChanged(object   sender, System.EventArgs e) Line 1071
System.Windows.Forms.dll!System.Windows.Forms.CurrencyManager.OnCurrentItemChanged(System.EventArgs   e) Line 829
System.Windows.Forms.dll!System.Windows.Forms.CurrencyManager.List_ListChanged(object   sender, System.ComponentModel.ListChangedEventArgs e) Line 725
System.Windows.Forms.dll!System.Windows.Forms.BindingSource.OnListChanged(System.ComponentModel.ListChangedEventArgs   e) Line 1009
System.Windows.Forms.dll!System.Windows.Forms.BindingSource.InnerList_ListChanged(object   sender, System.ComponentModel.ListChangedEventArgs e) Line 892
System.dll!System.ComponentModel.BindingList<System.__Canon>.OnListChanged(System.ComponentModel.ListChangedEventArgs   e) Line 168
System.dll!System.ComponentModel.BindingList<WindowsFormsApp2.Foo>.Child_PropertyChanged(object   sender, System.ComponentModel.PropertyChangedEventArgs e) Line 614
WindowsFormsApp2.exe!WindowsFormsApp2.NotifyPropertyChangedBase.Fire()   Line 107
WindowsFormsApp2.exe!WindowsFormsApp2.Form1.Test1()   Line 35
WindowsFormsApp2.exe!WindowsFormsApp2.Form1.Form1_Load(object   sender, System.EventArgs e) Line 19

Hi @miloszkukla Thank you for reporting this issue. Can you give us a bit more of an understanding of the behavorial impact of this issue - what happens in the client app to the user? This is an issue that appears to reproduce from .NET 3.5 onward, so isn't a regression. If we understand the business impact of the issue we'll be better able to determine where to create a potential fix. Given that this isn't a regression and we're not seeing other customer comments, we're inclined currently to put this in the backlog for WinForms in .NET Core 3. Is there a reason why this wouldn't be sufficient?

Thank you for reviewing. Fortunately end-user isn't really impacted except marginal performance difference I believe. Who is really impacted is developer while debugging and being interrupted by redundant event handling. Intrigued by your statement about .NET 3.5 I checked and it even reproduced on .NET 2.0 :)
Until it is fixed I thought about following workaround:
`
PropertyChangedEventHandler propertyChangedEventHandler;
public event PropertyChangedEventHandler PropertyChanged
{
add
{
if (new StackTrace().GetFrames().Any(x => x.GetMethod().Name == "Child_PropertyChanged"))
return;
            propertyChangedEventHandler += value;
        }
        remove
        {
            propertyChangedEventHandler -= value;
        }
    }

For 10,000Fire` method calls from my sample it's about 4x faster when workaround is applied but I guess it doesn't matter since nobody really fires that event that often.


#139: Updated ODBC driver source for integration test

fixes #139

Temporarily changed compile configuration for cpp tests such that warnings are not treated as errors. Will be reverted with #142


Update tools.py

This pull request extends the existing functionality to support reading and processing multiple file types, including DOC, DOCX, PPT, PPTX, and CSV files. The changes ensure that these file types are dynamically handled based on their extensions without altering the existing metadata.
Changes Made:
Enhanced File Loaders:
Updated UploadFileLoader, BytesFileLoader, LocalFileLoader, and URLLoader classes to handle additional file types (DOC, DOCX, PPT, PPTX, CSV). Implemented functions to extract text content from these file types. Improved Error Handling:
Added detailed error handling in file loaders to provide informative error messages. Ensured that unsupported file types are correctly identified and handled. Dependencies:
Included necessary libraries (python-docx, pandas, python-pptx) for handling the new file types. Updated requirements.txt to include these libraries.
unit testing is left will do it soon and post the results

Deprecated, closing for now


Function name in a field inside class is incorrectly highlighted

Description:
getName function name is incorrectly highlighted.

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
class className {
    public int name = 10;

    function () returns string getName;

    # Description
    #
    # + b - Parameter Description
    @deprecated
    function nameIt(int b) {

    }
}

Related Issues:

The above mentioned is an invalid ballerina configuration, and it's underlined as an error from LS diagnostics.


fix(frontend): Nodes list loads slowly on switching tabs

Switching between validating and non-validating tabs on the Nodes list page takes 10 seconds, so I assume we don't call re-fetch the data immediately and rely on autorefresh handler. We should force fetch the data when switching the tabs
Acceptance Criteria

[ ] Nodes list loads quickly on switching the tabs
[ ] Manually tested

I tried this and my fix would be give componentDidUpdate in Nodes.tsx. The situation is this:
first time the data loads for several seconds, but after that it will be quick and no loading. is this okay for you? @frol


Fix the glvis symlink install path when serac is used as a submodule

When serac is used as a submodule, this was pointing to a non-existing location which caused a build failure.

LGTM


[youtube] fix: mix playlist title

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Fixes #109

Just a quick feedback. This code works fine and extracts the title of the entire mix playlist correctly. Cool!
Mix playlist is I used: RDKR9wGi7gVLQ
However, is it possible to extract each individual video title? Just like in regular playlists. Right now, Json for individual videos comes up looking like this:
{"url": "ZKtNB9jiHV0", "_type": "url", "ie_key": "Youtube", "id": "ZKtNB9jiHV0"}, {"url": "ltXEhPLHccw", "_type": "url", "ie_key": "Youtube", "id": "ltXEhPLHccw"}, etc...
Maybe, it’s just the way YT handles this particular case, otherwise it would be a nice addition to a fix.

that's definitely possible


[CDS-85930] Documentation for CDS-74294 - CG Git Sync parity in GitX …

…NG - additional update
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[x] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

CDS-85930

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://656ddae978668a616a7fd28e--harness-developer.netlify.app


*** WIP *** Revert to the CJD image using fixes on Jenkins docker scripts

This PR revert the changes in the Dockerfile to use the CJD image again using the new environment variables created in the docker scripts of Jenkins:

JENKINS_WAR env var
REF env var

This PR cannot be merged until the changes in the docker repo of Jenkins are merged and released.

I suggest testing it with a staged Docker image which includes fixes in the
official Jenkins image
On Wed, Aug 14, 2019 at 4:46 PM Ramon Leon<EMAIL_ADDRESS>wrote:

@MRamonLeon https://github.com/MRamonLeon requested your review on: #8
https://github.com/cloudbees-oss/cjd-jcasc-demo/pull/8 *** WIP ***
Revert to the CJD image using fixes on Jenkins docker scripts.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/cloudbees-oss/cjd-jcasc-demo/pull/8?email_source=notifications&email_token=AAW4RIAX7OX4N5HQ3WYM2PTQEQLEXA5CNFSM4ILVWYHKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTBTIZYA#event-2556857568,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAW4RIF32D5NCRUPREO5K5DQEQLEXANCNFSM4ILVWYHA
.

--
Best regards,
Oleg Nenashev
Engineering Team, CloudBees Inc.
www.cloudbees.com


allow sealling pack files which turn them into ZIP archives

This PR addresses #124 and potentially also #123.
The PR is still a work in process. My current aim is to have both two issues addressed here.
Brief summary
When writing to pack files, a ZIP-style local header is written before each record. To seal a pack, its integrity is checked and the local headers are updated with checksums, and a central header directory is appended to the end. This operations does not block and any concurrent read access. A new table is introduced to storage the status of each pack file. Technically, writing to a sealed pack works just fine, and the pack can still be resealled, but this would waste some spaces. Hence the table is consulted and sealed packs will not be selected for writing.
After sealing, the pack file becomes a ZIP archive. Each record is a file named by the first 16 characters of its hash value (there can be duplicated names, but the chance is low due to the fine sizes of each sealed pack). The raw data may access by simply extracting the archive using any ZIP compatibe tools.
Todo

[ ] Address #123

Thanks @zhubonan ! Is there a reason to limit the filename to 16 characters only?

Thanks @zhubonan ! Is there a reason to limit the filename to 16 characters only?

It is just for spacing savingand the file name has to be included in both the central directory and the local header. Including the full hash (taking 64 bytes as ASCII) is not really necessary since that cab be computed from the content.
We can check for clash when sealing the data perhaps.

For 10 million objects the cost would be ~600MB (times two = ~1.2GB) with the full hash. So with 16 bytes we spare ~ 900MB. I'm tempted to say it's OK not to spare this space but we have a simpler code? (also, 10 million objects would most probably fill many packs, so the 900MB will most probably be a small % of the total size in most cases).

Hmm I see, in that case I will just go with the full hash. The part that gets simplied is that we don't have to check for any duplications when assigning file names during the sealing process. When updating the filename length still has to be verified, otherwise there is a risk of overwriting the actual data.
Another added benefit with full hash filename is that the sealed pack can be loosened by simple decompression and copying the files to the loose object folder. This might be useful when one want to move data from one repository to another.

Another added benefit with full hash filename is that the sealed pack can be loosened by simple decompression and copying the files to the loose object folder. This might be useful when one want to move data from one repository to another.

But in this case you need to store the hashkey sharded (e.g. 01/839ab302...), depending on the settings of the container. (The default is 1 level of length 2, but it's configurable).
I don't know if this in total might increase or decrease the size of the ZIP? Filenames are 2 bytes shorter (I don't know if only the actual filename or the full path should be put in front of every file?), but now we have also to store in which folder, so probably this makes things even more expensive?

Oh I see, my bad. I thought that the loose files are stored in a flat directory 😓
Whith sharded directory, one should in principle be able to write a simgple bash script to put the file in the correct folder with correct name. Maybe it is a bit stretched as intented usage though.

Just want to recap on what we have discussed previously. The sealing would be treated as a slow operation similar to repack. I wil try to see if we can use the zipfile stdlib to directly construct a zip file and have the offsets/size/length of each entry recorded in the sqlite. This way the code can be simplified a lot and easier to maintain.
I also did some investation on my repository. It is true that most of the objects are small files. The median size is just only 2kytes! But the small files also take relatively small portion of the total size, despite in large number. So a overhead of about 100-200 bytes per object is a lot for the small objects, but the overall impact on the total size is much smaller. My repo is 80G on disk, and the estimated overhead based on total number of object is about 100-200MB. So I think that having archived pack files would still have minimal overalls impact on the total size on disk.


Document structured logging

It is rather concise, but probably enough for first draft.

The doc LGTM but should we keep the Structured logging doc and the Configuring error grouping settings doc in the same directory (ie: section)?
As it is, this one is in the Features directory and Configuring error grouping settings is in the "Airbrake FAQ" directory. Either is fine with me.

I put it in features folder, because it is a feature, not a frequently asked question...

Merging as is, but I don't mind if someone who knows better about the docs moves it in faq folder.


Error: unpack requires a string argument of length 4

Interestingly, when trying to use ttx to inspect the file contents I get a similar error, which makes me believe this is a case of corrupted TTF files:

More detailed info at:
https://github.com/googlefonts/fontbakery/issues/1596

To replicate this bug, you can run ttx on the ofl/seoulnamsan/SeoulNamsan-Bold.ttf from the google/fonts git repo (at commit bb5c17d9c67039166a4f1f5894cdd2629156d13d).

the font looks broken, nothing we can do


Added Reverting

This PR comes from #24
We can continue the discussion about this and what to do about finding undone changes here

Copied from #24:
We're going to need a way to check if the commit is being reverted, that is something that is currently ill-defined in the spec files. This is the kind of situation where we can create a python file and extend the BasicChallenge class to give us what we need. We can write a test.spec file to test if C0, C1 and C2 are all created correctly, and then the commit denoted C2', which reflects a reverted commit, we can check manually for it. We can also change test_level to allow for extra branches to be present. Currently, if there are extra branches, then the test will fail, but we can change it so that if we have an extra "pushed" branch that isn't checked for (only master/local are checked for correctness) then we should be okay. In our test function, we can then separately check to make sure pushed has file 2 deleted and that its parent is commit 2.

That earlier comment is just for reference. After some thought, I think it would make the most sense to represent reverted commits with a negative, so if we have files 1,2,3 and we want to revert the commit that adds file 2, we add another commit as -2.
This seems logical and should be consistent. We'll need to update the parser. Let me know if you agree that this is the best thing to do

I've modified the instructions and added a new test and setup. In theory, it works if the "-#" syntax works. Also, I think that's good syntax, you should proceed with that idea!

Great, looks like the only thing left is the modifications to make the -3 stuff work

I'm not sure how to do this, but I have some pieces.
My plan:
In line 156 of util.py, we check if test commit names are present in level commit. Add an elif that detects a '-' using array slicing. In this block, check if there is a file with the same name as commit_name[1:] (a number of variable digits). If yes, do something; if not throw false. Here's what I don't understand: where do I get the names of files that are in the repository? Don't I need an Operator object?
Another problem: I said above that if we find that the file is deleted we need to do something. From here on I'm not sure what is going on. It looks like the section starting from 168 checks if the length of the parents and the parent ID's are the same. But this goes back to the problem of having no control over the revert commit names, we can't check the ID part if we don't know the names.

So you're right, we don't have control over the commit names for reverts. The same is true for reverts. If you look at the first section of the code in test_level,  I do a very hacky job of finding the names of each of the merge commits, and I'll need to change this. The test_level code is really only responsible for checking equality and shouldn't have the responsibility of assigning names to each of the commits, which is why you don't see any Operators in there.
Take a look at BasicChallenge. It uses the file operator to get the current tree and to parse the spec files. You'll see that the methods parse_spec, level_json and file_operator.get_current_tree are used. I don't think you'll need to modify parse_spec or level_json since we have control over the names there, but you'll probably need to modify file_operator.get_current_tree. You'll have access to the commit objects there and can change their names to be whatever you want. To figure out the name, you could either parse it to see if the name contains "Revert" and then look for the number. You can just change Revert "4" to -4, etc.
Eventually, I think we'll want to actually look at the diff and check for the files that are changed, but that would work best if we have a larger PR working on doing that for normal commits, reverts, and for merges. Merges will be a little more complicated, but we can ignore that and the rest of this paragraph for now.

@parkmichael777 how's it going? Do you need any help?

@bthayer2365 Hey! I haven't tried any of your latest suggestions yet—all my work is due on Wednesday, and I've got an exam tomorrow. I'll probably look at this on Thursday or next Tuesday.

Okay, no problem. Good luck on your exam!

I opened this up as a new issue - #91. If you start working on it, open up a new pull request and reference that issue.

Just made a note on #91 that we should be doing 1- for reverting 1 instead of -1 so that we can use the name as a tag as well.

I've updated the naming of levels and challenges as well as the data structures that contain them, so you'll need to update the __init__.py files. See #23 and #94 for details

Hey, so do you want me to change the spec syntax and init.py for this PR and then do the parsing changes in the other?

The purpose of different pull requests in different branches to separate work that should be separated. If you want to work on another level that has reverting then you should do it in a different pull request, but otherwise it's fine to do it here
For the changes to __init__.py, keep them here since it's part of this level

Also to resolve conflicts use git merge master from this branch. It should make it clear what needs to happen

No, I mean for tasks left on this PR do you only want me to do those two things (change reverting/test.spec and init.py) or is there more for this PR?

Ohh, nevermind lol. I added the new syntax and init.py. Working on the parsing changes now

fixes #91

Done! I didn't think to do list slicing because I didn't know if the length of the message is different every time lol. Changed, and added goal stuff.

I modified the goal, but otherwise, things looked good, and I merged!


Does install_prod run post-install?

If not, what flow should be run to install my package while running the post-install as well?

The steps included in a flow can vary if you've customized the flow. Use cci flow info install_prod to see a full list of the flow steps.


Add generic type for $c->get method

https://phpstan.org/blog/generics-by-examples#function-accepts-any-string%2C-but-returns-object-of-the-same-type-if-it’s-a-class-string
Generics could not be applied because we use as classes and as string types as well.
So due to that in case of using combining types it would not work, and we get an error

due to type normalizing.
And in case we use just class-string and returning type T it works for classes but doesn't work for string in $c->get('string-service') in case we use primitives


[WIP] Add colab examples for objective functions

The readme.md already has an example using dockstring, which is a not-trivial-to-install black box.


_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

:green_heart:
mvninstall
5m 31s
master passed

:green_heart:
compile
0m 56s
master passed

:green_heart:
checkstyle
1m 19s
master passed

:green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 37s
master passed

:blue_heart:
spotbugs
4m  5s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
4m  3s
master passed

_ Patch Compile Tests _

:green_heart:
mvninstall
4m 55s
the patch passed

:green_heart:
compile
0m 56s
the patch passed

:green_heart:
javac
0m 56s
the patch passed

:broken_heart:
checkstyle
1m 17s
hbase-server: The patch generated 4 new + 33 unchanged - 0 fixed = 37 total (was 33)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:broken_heart:
shadedjars
3m 44s
patch has 10 errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 42s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 36s
the patch passed

:green_heart:
findbugs
4m 11s
the patch passed

_ Other Tests _

:green_heart:
unit
160m 27s
hbase-server in the patch passed.

:broken_heart:
asflicense
0m 35s
The patch generated 2 ASF License warnings.

216m 21s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/764

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 36d6c6a00d47 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-764/out/precommit/personality/provided.sh

git revision
master / d7deafa120

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/1/artifact/out/diff-checkstyle-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/1/artifact/out/patch-shadedjars.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/1/testReport/

asflicense
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
4321 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

:green_heart:
mvninstall
5m 25s
master passed

:green_heart:
compile
0m 56s
master passed

:green_heart:
checkstyle
1m 21s
master passed

:green_heart:
shadedjars
4m 38s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 36s
master passed

:blue_heart:
spotbugs
4m  9s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
4m  7s
master passed

_ Patch Compile Tests _

:green_heart:
mvninstall
4m 53s
the patch passed

:green_heart:
compile
0m 57s
the patch passed

:green_heart:
javac
0m 57s
the patch passed

:broken_heart:
checkstyle
1m 17s
hbase-server: The patch generated 1 new + 33 unchanged - 0 fixed = 34 total (was 33)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 36s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 36s
the patch passed

:green_heart:
findbugs
4m  8s
the patch passed

_ Other Tests _

:broken_heart:
unit
161m 48s
hbase-server in the patch failed.

:green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

219m 32s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAsyncTableGetMultiThreaded

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/764

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 03ec804aab44 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-764/out/precommit/personality/provided.sh

git revision
master / 9a80618765

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/2/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/2/testReport/

Max. process+thread count
4594 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

:green_heart:
mvninstall
5m 33s
master passed

:green_heart:
compile
0m 54s
master passed

:green_heart:
checkstyle
1m 20s
master passed

:green_heart:
shadedjars
4m 37s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 37s
master passed

:blue_heart:
spotbugs
4m 12s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
4m 10s
master passed

:yellow_heart:
patch
4m 19s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

:green_heart:
mvninstall
4m 52s
the patch passed

:green_heart:
compile
0m 55s
the patch passed

:green_heart:
javac
0m 55s
the patch passed

:broken_heart:
checkstyle
1m 21s
hbase-server: The patch generated 5 new + 33 unchanged - 0 fixed = 38 total (was 33)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 37s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 38s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 35s
the patch passed

:green_heart:
findbugs
4m  9s
the patch passed

_ Other Tests _

:broken_heart:
unit
32m 36s
hbase-server in the patch failed.

:green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

89m  6s

Reason
Tests

Failed junit tests
hadoop.hbase.util.TestIdReadWriteLockStrongRef

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/764

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 24e3cc629795 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-764/out/precommit/personality/provided.sh

git revision
master / 2a969e1d8b

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/3/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/3/testReport/

Max. process+thread count
681 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

:green_heart:
mvninstall
5m 25s
master passed

:green_heart:
compile
0m 57s
master passed

:green_heart:
checkstyle
1m 16s
master passed

:green_heart:
shadedjars
4m 41s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 38s
master passed

:blue_heart:
spotbugs
4m 13s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
4m 10s
master passed

:yellow_heart:
patch
4m 20s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

:green_heart:
mvninstall
5m  3s
the patch passed

:green_heart:
compile
0m 56s
the patch passed

:green_heart:
javac
0m 56s
the patch passed

:broken_heart:
checkstyle
1m 17s
hbase-server: The patch generated 1 new + 33 unchanged - 0 fixed = 34 total (was 33)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 35s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 41s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 37s
the patch passed

:green_heart:
findbugs
4m 16s
the patch passed

_ Other Tests _

:green_heart:
unit
157m 31s
hbase-server in the patch passed.

:green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

214m 19s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/764

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 73b8af647a7c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-764/out/precommit/personality/provided.sh

git revision
master / 2a969e1d8b

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/4/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/4/testReport/

Max. process+thread count
4391 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

:green_heart:
mvninstall
5m 22s
master passed

:green_heart:
compile
0m 57s
master passed

:green_heart:
checkstyle
1m 17s
master passed

:green_heart:
shadedjars
4m 34s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 39s
master passed

:blue_heart:
spotbugs
4m 12s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
4m 10s
master passed

:yellow_heart:
patch
4m 19s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

:green_heart:
mvninstall
5m  5s
the patch passed

:green_heart:
compile
0m 55s
the patch passed

:green_heart:
javac
0m 55s
the patch passed

:green_heart:
checkstyle
1m 16s
the patch passed

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 49s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 36s
the patch passed

:green_heart:
findbugs
4m  9s
the patch passed

_ Other Tests _

:green_heart:
unit
157m 21s
hbase-server in the patch passed.

:green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

214m 15s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/764

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 5197005f807f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-764/out/precommit/personality/provided.sh

git revision
master / 2451c2c532

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/5/testReport/

Max. process+thread count
4183 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

If use strong reference obj pool, should we limit the capacity of the pool? otherwise, there will be the risk of OOM. maybe an StrongObjectPool with RingBuffer based is more suitable? just a suggestion.

Yeah, i am agree with you,if user modify the default config of bucketcache's blocksizes,the possible count of the offset maybe uncontrollable, so i make it configable,and the soft still as default.
Consider in most time the count of offset is limited, so i think it is not a problem easily occur,maybe we can improve it in future.
BTW,i have running with it in my live cluster than a week, with 32g heap,70g bucketCache and 16k blockSize,and seems good.
Thanks for comment.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  1s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

:green_heart:
mvninstall
5m 23s
master passed

:green_heart:
compile
0m 58s
master passed

:green_heart:
checkstyle
1m 18s
master passed

:green_heart:
shadedjars
4m 34s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 38s
master passed

:blue_heart:
spotbugs
4m 10s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
4m  9s
master passed

:yellow_heart:
patch
4m 18s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

:green_heart:
mvninstall
5m  0s
the patch passed

:green_heart:
compile
0m 55s
the patch passed

:green_heart:
javac
0m 55s
the patch passed

:green_heart:
checkstyle
1m 18s
the patch passed

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 39s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 36s
the patch passed

:green_heart:
findbugs
4m 16s
the patch passed

_ Other Tests _

:broken_heart:
unit
157m  9s
hbase-server in the patch failed.

:green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

214m  4s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestBlockEvictionFromClient

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/764

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux cb6ae4768e09 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-764/out/precommit/personality/provided.sh

git revision
master / ea5c572963

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/6/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/6/testReport/

Max. process+thread count
4433 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-764/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

The ut failure seems not related to the patch.

Thanks for the updates @bsglz ! Latest refactorings lgtm!

If use strong reference obj pool, should we limit the capacity of the pool? otherwise, there will be the risk of OOM. maybe an StrongObjectPool with RingBuffer based is more suitable? just a suggestion.

Very good point, @chenxu14 !

Consider in most time the count of offset is limited, so i think it is not a problem easily occur,maybe we can improve it in future.

Agreed, I think a subtask jira of this current one would be great.

BTW,i have running with it in my live cluster than a week, with 32g heap,70g bucketCache and 16k blockSize,and seems good.

That's good. Would u mind collecting&sharing some heap usage/GC stats, together with overall RS metrics (such as write/read requests, compactions, etc) from few days period?

That's good. Would u mind collecting&sharing some heap usage/GC stats, together with overall RS metrics (such as write/read requests, compactions, etc) from few days period?
I has added a doc for it as a attachment of issue,link at below：
https://issues.apache.org/jira/secure/attachment/12984751/HBASE-23223-RS metrics with patch.pdf

@wchevreuil Any other questions?

Thanks, who can help to merge it?

Done! Thanks for the contribution, @bsglz !

@wchevreuil  Thank you.


Badges support

I noticed that there was a badges.html being included in the page-header.html but the styles were never defined, and the badges weren't showing up in the component view.

added badge support to component-category.html'
refactored badges.html to account for the component-category.html using componentPage.status instead of page.status
added various statuses to the three components in the Blocks and Cards component directory to test
added some basic badge styles (should we be worried about font size/accessibility?)
converted tabs to spaces on style-guide.scss, hopefully not messing things up too badly 😬

Hey @KatieMFritz! Thanks so much for the tremendous contribution. Thanks for the eagle-eye on noticing the badges in the first place, and for bringing them to life. The project the Style Guide Guide was born from made ample use of the badges, but I clearly didn't get around to translating them into this project. Thanks again!


Remove SubField API

This PR removes the subfield API from FieldAPI, as:

We're removing the implicit ability to create a new FieldAPI from a parent's name in react-core (#588)
This API adds a ton of complexity (especially around typings)
It's just as easy to new FieldAPI with a new name

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.76%. Comparing base (b28f6d8) to head (b167a4c).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   87.78%   87.76%   -0.03%
==========================================
  Files          31       31
  Lines         819      817       -2
  Branches      184      184
==========================================
- Hits          719      717       -2
  Misses         95       95
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


admin: streaming C++ API

Currently the admin API is designed so the implementation must collect and return the entire response in one contiguous block. This means that very long responses such as /stats and /config_dump may introduce significant delay and memory pressure.
Specificallly:
https://github.com/envoyproxy/envoy/blob/7bd0c0f4fe6b30e88a77c5739a70a78bc7400ef8/source/exe/main_common.h#L52
https://github.com/envoyproxy/envoy/blob/7bd0c0f4fe6b30e88a77c5739a70a78bc7400ef8/envoy/server/admin.h#L254
These two interfaces should be changed so they allow for streaming. Note that we have a dependence on the current non-streaming versions so we might need to have both old and new versions at least temporarily.
This is related to https://github.com/envoyproxy/envoy/issues/31082

I have a prototype of this interface locally. Want to get some internal review then I'll publish a PR.


the mean of range

hello
What do range, signal  mean respectively ?

Hi.
Range is the euclidean distance from each point to the origin of the sensor reference frame. This means sqrt(x^2+y^2+z^2).
Signal refers to the remission, which is a measure of the "intensity" of the reflected lidar beams. Its actual meaning varies from sensor to sensor (different technologies).
You don't need to open a new issue every time. You can keep commenting on the other issue you opened and I closed.

Hi,  @tano297 , thanks for open sourcing your work!
Your mean-values: (12.12, 10.88, 0.23, -1.04, 0.21)
But I get x-value around 0. (sequence 00-10 except 08)
I also wonder why X-coordinate is around 10?
Thanks!


bug: Thumbnail of Adhoc and DSA classes are not loaded

Description:It seems that there is an issue where the thumbnails for the ad-hoc and DSA (Data Structures and Algorithms) classes are not visible.
Below is the image attached for reference:-

I guess they were updating the image at that time. Thumbnails are visible now.

yeah i noticed it so i could now close the issue.


Sharing maintenance of OCAML and OPAM

Comment:
@fasiha can we add you as a maintainer for https://github.com/conda-forge/ocaml-feedstock too please? I got stuck there and it needs updated.

Please go ahead, I’m not sure how much help I’ll be since I’m an OCaml noob but happy to try!

Well, if you can get a more recent version of OCAML itself to work that'd be great.


Bump Neo4j to v4.3

Neo4j 4.3 should be out in the coming weeks

Fixed by 03def8eef21b5138e69d77a1d7bcf6d25fe413e8


Randomic listening port on docker execution

Hi, i'm working with Node 20.11.0 and the following package.json:
"devDependencies": {
    "fastify": "^4.26.2",
    "typescript": "^5.4.2"
  },
  "dependencies": {
    "@platformatic/db": "^1.28.1",
    "platformatic": "^1.28.1"
  },

I have two main issues:

Plugin not start in time

2024-03-19 14:52:22 {"level":50,"time":1710856342852,"pid":7,"hostname":"7726d3494555","name":"mizar","err":{"type":"FastifyError","message":"Plugin did not start in time: 'platformaticDB'. You may have forgotten to call 'done' function or to resolve a Promise","stack":"FastifyError: Plugin did not start in time: 'platformaticDB'. You may have forgotten to call 'done' function or to resolve a Promise\n    at Timeout._onTimeout (/home/platformatic/node_modules/avvio/lib/plugin.js:112:31)\n    at listOnTimeout (node:internal/timers:569:17)\n    at process.processTimers (node:internal/timers:512:7)","code":"AVV_ERR_PLUGIN_EXEC_TIMEOUT","name":"FastifyError","statusCode":500},"msg":"Plugin did not start in time: 'platformaticDB'. You may have forgotten to call 'done' function or to resolve a Promise"}

When i create the docker container it automatically change the PORT with a random one and server listen on it. I defined the port inside the .env file

Following dockerfile:
FROM platformatic/platformatic:latest

USER root

RUN corepack enable && corepack prepare pnpm@latest --activate

WORKDIR /app

COPY package.json pnpm-lock.yaml tsconfig.json ./

COPY ./services/mizar/global.d.ts ./services/mizar/platformatic.json ./

COPY ./services/mizar/migrations   migrations
COPY ./services/mizar/types        types
COPY ./services/mizar/routes       routes
COPY ./services/mizar/plugins      plugins
COPY ./services/mizar/public       public

RUN pnpm install --fix-lockfile --frozen-lockfile
RUN pnpm run build

EXPOSE 5004

CMD ["platformatic", "start"]

#ENTRYPOINT ["tail", "-f", "/dev/null"]

Here my docker-compose:
name : mizar-compose

services:
  mizar-api-new:
    image: mizar-api
    container_name: mizar-api-new
    restart: unless-stopped
    environment:
      - PLT_SERVER_HOSTNAME=<IP_ADDRESS>
      - PORT=5004
      - PLT_SERVER_LOGGER_LEVEL=info
      - PLT_MIZAR_DATABASE_URL=postgresql://postgres:changeme@postgresql:5432/mizardb
      - PLT_MIZAR_APPLY_MIGRATIONS=true
      - PLT_SERVER_CORS_ORIGIN=http://localhost:3004/
    ports:
      - 5004:5004

Finally the server listening to random PORT (in this execution is the 42779). So the container became unreachable
2024-03-19 14:52:37 {"level":30,"time":1710856357497,"pid":7,"hostname":"7726d3494555","name":"mizar","msg":"All routes loaded! Check your console for the route details."}
2024-03-19 14:52:37 └── / (GET, HEAD)
2024-03-19 14:52:37     ├── documentation (GET, HEAD)
2024-03-19 14:52:37     │   └── /
2024-03-19 14:52:37     │       ├── json (GET, HEAD)
2024-03-19 14:52:37     │       ├── yaml (GET, HEAD)
2024-03-19 14:52:37     │       └── @scalar/fastify-api-reference/js/browser.js (GET, HEAD)
2024-03-19 14:52:37     └── shop
2024-03-19 14:52:22 The runtime exited before the operation completed
2024-03-19 14:52:37         ├── carts (GET, HEAD, POST, PUT)
2024-03-19 14:52:37         │   └── / (GET, HEAD, POST, PUT)
2024-03-19 14:52:37         │       └── :uuid (GET, HEAD, PUT, DELETE)
2024-03-19 14:52:37         │           └── /shopitems (GET, HEAD)
2024-03-19 14:52:37         └── items (GET, HEAD, POST, PUT)
2024-03-19 14:52:37             └── / (GET, HEAD, POST, PUT)
2024-03-19 14:52:37                 └── :uuid (GET, HEAD, PUT, DELETE)
2024-03-19 14:52:37                     └── /uuid (GET, HEAD)
2024-03-19 14:52:37
2024-03-19 14:52:37 {"level":30,"time":1710856357509,"pid":7,"hostname":"7726d3494555","name":"mizar","msg":"Server listening at
http://<IP_ADDRESS>:42779"}

How can i solve these issues? Thanks

what's your config file?

It does not seem you are copying platformatic.json inside the image

It depends if you want to deploy your platformatic runtime application or just your service individually.
Your repo is configured for the platformatic runtime but you are trying to build your dockerfile for the individual service.
What's the case?

My use case is service

You need to add a "server": { ... }" config block in the platformatic.json` inside your service folder.


Add benchmark on collection load time

Introduce BENCHMARK_STRATEGY env variable to control the experiments, possible values: default | tenants | collection-reload
Add a new server config qdrant-continuous-benchmarks-snapshot with QDRANT_NUM_CPUS: 4 to ensure no optimizations are triggered after snapshot recovery
Add a new column collection_load_time_ms into database. Fetch the value from /telemetry response.

Prepare snapshots for cases,  upload them to GCP:

500k points with all possible payloads, 768x, all default values
500k points with all possible payloads, 768x, on_disk:true (all possible on_disk places)
500k points with all possible payloads, sparse vectors, all default values
500k points with all possible payloads, sparse vectors, on_disk:true (all possible on_disk places)

Example run: https://github.com/qdrant/vector-db-benchmark/actions/runs/11033744818

@KShivendu @generall I wanted to run the runLoadTimeBenchmark job in parallel almost everything in code is ready, but it not possible since the 2nd server has ARM architecture and we don't have Docker images for ARM.

I updated the code to run the benchmark in parallel with tenants benchmark. The benchmark runs in a separate server machine and only the client machine is shared.
https://github.com/qdrant/vector-db-benchmark/actions/runs/11051637232


Multiline curl command & -d params

I've tried to convert command below but it didn't work:
curl -X GET 'http://fiddle.jshell.net/echo/html/'\
    -H 'Origin: http://fiddle.jshell.net'\
    -d msg1="value1"\
    -d msg2="value2"

First, since it is multi line command, yargs will throw an error.
Secondly I guess this library only support for --data not -d.

@NickCarneiro Thanks, sure. :+1:


Playnite Sounds integration

So I've taken to using Playnite Sounds rather than the video trailer audio. The soundtracks are much nicer to hear versus the sometimes obnoxious audio from the trailers.
Unfortunately the combination of muted video and soundtracks is clunky in eMixedNiteMC today. Ideally the theme would link the playback of video and the music playback so that stopping one would stop the other. Since Playnite Sounds also supports multiple tracks it'd be nice to see which soundtrack is playing somewhere... maybe as transparent text over the video window.

Nice idea, I like it! But unfortunatly, I dont see aything related to theme integration in Playnite Sounds Github, so I dont think there is a way to show a list of soundtracks or make the video and soudtrack stop at the same time.
For the clunky part, you will need to be a little more specific. I understand that you play a soudtrack and mute the video but I dont understand what you mean by clunky.

Since there are no controls for the soundtrack it makes it impossible to mute. Using the eMixedNiteMC video controls don't work obviously.

Since there are no controls for the soundtrack it makes it impossible to mute. Using the eMixedNiteMC video controls don't work obviously.

I'm trying to replicate this on my end to see if I can help. I get controls popup for me, including a volume slider. The thing is, whilst trying to pause the trailer, I notice I'm only getting the controls for Playnite Sounds. I do remember when I reinstalled back in the summer I installed PS before the plugin that has the trailer support. I have a feeling like Playnite may only be able to show one of these at a time, but I'm no expert.

It will have to be for the next update (in the next few weeks), v3.5 took more time than anticipated and I did not have enough time to work on it.

Found this issue about this.

Finally done in version 3.75. Update will be released this weekend! I added the play/pause control and the name of the currently playing song + an option to toggle visibility in ThemeModifier
Here a little preview!
The control are located in the bottom right corner of the window so it will stay there even when scrolling.


As a student user I would like to have my projects kept in a database for future review

Postgresql DB will save new projects


Reuse Parameters doesn't work

Ever since I updated, there seems to be some issues with either writing or reading metadata. For example, when I drag and drop an image onto Stable Swarm UI and I click the "Reuse Parameters" button, I get a popup error message: "No parameters to copy!"
Here is one such example image:

When I inspect the file, I see that the metadata is there:

{ / "sui_image_params": { / "prompt": "a whimsical and colorful graceful and soft and cute reptilian creature with colorful soaring creative gentle wings, set in an treetops environment. It has large translucent, green wings that resemble those of a stingray or manta ray, with shades of deep blue and emerald green that glow as if reflecting light from the water's surface. Its body is slender, covered in scales that shimmer in hues of green, contributing to its magical appearance. The creature has elongated, whisker-like appendages near its mouth, adding to its fish-like characteristics. Surrounding it are plant-like tendrils and other jungle canopy flora, which are illuminated by a bioluminescent glow, casting a serene light on the scene. The overall atmosphere is one of enchantment and canopy wonder", / "negativeprompt": "(worst quality, low quality:1.4)", / "images": 500, / "seed":<PHONE_NUMBER>, / "steps": 50, / "cfgscale": 5.0, / "aspectratio": "1:1", / "width": 1024, / "height": 1024, / "model": "SDXL/realcartoonXL_v5.safetensors", / "loraweights": [ / "0.3" / ], / "clipstopatlayer": -3, / "swarm_version": "<IP_ADDRESS>", / "date": "2023-12-05", / "generation_time": "8.01 (prep) and 15.58 (gen) seconds" / } / }

But when I drag and drop a different image I generated with an older version of Stable Swarm then it works, no error, and parameters get applied properly, for example this one:

And this is the metadata I see when I inspect that file:

{"4": {"class_type": "CheckpointLoaderSimple", "inputs": {"ckpt_name": "SDXL\kohakuXL_alpha7.safetensors"}}, "15": {"class_type": "LoadImage", "inputs": {"image": "init_image_sui_backend_0_1.png"}, "is_changed": ["fa09b9dba251deda0d79437460340fb9646235ce07820950b162d93f3c8a3610"]}, "5": {"class_type": "VAEEncode", "inputs": {"pixels": ["15", 0], "vae": ["4", 2]}}, "6": {"class_type": "CLIPTextEncodeSDXL", "inputs": {"clip": ["4", 1], "text_g": "concept art of alien lava fish teenage humanoid creature mermaid siren, fire and lava melting and flowing, skin made of molten lava, hair made of fire, attractive, hot, cute, perfect body proportions, sirenoid, mermaidoid, molten lava, lava skin, fire, lava, molten flowing lava skin, glowing", "text_l": "concept art of alien lava fish teenage humanoid creature mermaid siren, fire and lava melting and flowing, skin made of molten lava, hair made of fire, attractive, hot, cute, perfect body proportions, sirenoid, mermaidoid, molten lava, lava skin, fire, lava, molten flowing lava skin, glowing", "crop_w": 0, "crop_h": 0, "width": 664, "height": 1192, "target_width": 664, "target_height": 1192}}, "7": {"class_type": "CLIPTextEncode", "inputs": {"clip": ["4", 1], "text": "(worst quality, low quality:1.4), (zombie, sketch, interlocked fingers, comic), human"}}, "10": {"class_type": "KSamplerAdvanced", "inputs": {"model": ["4", 0], "add_noise": "enable", "noise_seed": 757224405, "steps": 20, "cfg": 7.0, "sampler_name": "dpmpp_2m_sde", "scheduler": "karras", "positive": ["6", 0], "negative": ["7", 0], "latent_image": ["5", 0], "start_at_step": 8, "end_at_step": 10000, "return_with_leftover_noise": "disable"}}, "8": {"class_type": "VAEDecode", "inputs": {"samples": ["10", 0], "vae": ["4", 2]}}, "9": {"class_type": "SaveImage", "inputs": {"filename_prefix": "StableSwarmUI_1FB4E4F1_", "images": ["8", 0]}}}

The value you copied from the second image is comfy metadata. The actual swarm metadata in old versions was under a different key (Model). In new versions it was moved to Parameters. The Model metadata for reference is indeed present on that image with swarm's data.
I'm... very confused what happened / why, with your more recent image -- the metadata is indeed there in the file, and won't load in swarm for me either.
My own images look identical in a local exif metadata checker tool, and mine load fine.

But for whatever reason, the metadata reader lib used in swarm's JS side - https://github.com/MikeKovarik/exifr - doesn't seem to like it?
This issue is the same holds true on the web exif tool made by the same developer - https://mutiny.cz/exifr/
Everything looks correct, and exifr doesn't give an error, it just ... won't load. I'm so confused what's going on.
Here's my own test image if you can think of any way to test to figure out what's different in metadata.

Update: after testing a bit, I discovered something about it: it's linked to length. If I write a very long prompt, the metadata fails to load in exifr.
The relevant docs for the image library for how it's set say:

So I suspect that potential that iTXt, tEXt, zTXt choice varies based on length, and exifr only supports a subset of them.

Despite the presence of iTXt references in exifr, it seems unable to load those in my testing when I force it to use that.
The above two commits aggressively force tEXt to always be used, by disabling non-ASCII characters (requires iTXt) and compression (swaps to zTXt), ensuring metadata should always wind up in a format exifr can read.


Tests for Broker Card

What does this PR do?
Adds Tests for Broker Card Component
[ X] Tests for the proposed changes have been added/updated.
[ X] Code linting and formatting was performed.
Functionality Before
NA
Functionality After
NA

All good. Thx.


Localize and polish Profile page navigators

Summary of the Pull Request
Adds some polish around the navigators in the profile page (i.e. "appearance" and "advanced" button) by doing the following:

use the localized resources for the pivot on the navigators
simplify the navigators to be buttons instead of toggle buttons

Doing so has Narrator identify these as buttons rather than toggle buttons. So now Narrator won't say that the button is "off", which just makes more sense.
Validation Steps Performed
✅ Narrator says "Advanced button" or "Appearance button" on the navigator
✅ The navigators look the same as before

@msftbot merge this in 5 minutes


RUM-6314: Use layout text to display textview overflow correctly

What does this PR do?
Fix the Session Replay issue that text view overflow could not be displayed properly
Motivation
RUM-6314
Demo

App screen
Before
After

Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (26c28e2) to head (150f273).

Files with missing lines
Patch %
Lines

...id/sessionreplay/recorder/mapper/TextViewMapper.kt
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2279      +/-   ##
===========================================
- Coverage    70.06%   70.05%   -0.01%
===========================================
  Files          732      732
  Lines        27224    27221       -3
  Branches      4580     4580
===========================================
- Hits         19073    19068       -5
+ Misses        6877     6868       -9
- Partials      1274     1285      +11

Files with missing lines
Coverage Δ

...id/sessionreplay/recorder/mapper/TextViewMapper.kt
89.90% <0.00%> (ø)

... and 31 files with indirect coverage changes


Add w803 not in the same subnet (incl. HowTo)

Problem:
w803 is not in the same subnet as the iobroker. UDP search does not work.
Possible implementation:

Make subnet selectable
Specify the Ip of the w803

I can see when I find time to enhance this. What you can do is the following:
Create an object "ph803w.0.myph803w" with the following content:

type "device"

{
  "type": "device",
  "common": {
    "name": "PH803W device myph803w"
  },
  "native": {
    "ip": "192.168.XXX.XXX",
    "id": "myph803w"
  }
}

it can be that you need to enablce Expermode in admin and only can create a "Folder" object using UI ... do that. Then clock the pencil of that object and change the JSIN definieion to above.
In IP enter your IP
Then start the adapter and provide log please. Should detect that device and load it and then initialize the communication. All places where "myph803w" above are used tze value needs to be the same ... so you can rename it, but needs to stay the same in these locations.

Hi, I pick up this issue again, since I am having an iobroker running in a Synology docker on my LAN#1: 192.168.0.*. This iobroker is used to manage 2 MQTT (ESP_8266) devices and also 2 Homematic CCU-2 (with plenty of homematic devices)  connected to LAN#1 but also to LAN#2 (192.168.178.**) ; LAN#1 and LAN#2 are permanenty connected via a VPN using two AVM Fritzbox devices. This iobroker installation works since many months flawlessley.
Pls. let me confirm that your proposed implementation works very well in my case where I today conected the PH-803W to LAN#2. Immediately after putting in the object (and code with the correct IP adress) into iobroker as perfectly desbribed by you beyond the PH-803W was found!
Thx!


OAK-10786: oak-lucene: use copy of lucene-core 4.7.2 source code

I have structured the PR so that each step should be easy to follow.

I'm still struggling with bundling warnings like:
[WARNING] Bundle org.apache.jackrabbit:oak-lucene:bundle:1.63-SNAPSHOT : Split package, multiple jars provide the same package:org/apache/lucene/document
Use Import/Export Package directive -split-package:=(merge-first|merge-last|error|first) to get rid of this warning
Package found in   [Jar:., Jar:lucene-core, Jar:lucene-misc]
Class path         [Jar:., Jar:osgi.core, Jar:org.osgi.annotation.versioning, Jar:org.apache.felix.scr.annotations, Jar:oak-shaded-guava, Jar:oak-api, Jar:jcr, Jar:oak-core-spi, Jar:jackrabbit-jcr-commons, Jar:oak-jackrabbit-api, Jar:oak-commons, Jar:oak-store-spi, Jar:commons-io, Jar:oak-query-spi, Jar:oak-core, Jar:oak-security-spi, Jar:org.osgi.service.component.annotations, Jar:org.osgi.service.metatype.annotations, Jar:oak-blob-plugins, Jar:oak-store-document, Jar:oak-blob, Jar:tika-core, Jar:jakarta.xml.bind-api, Jar:jakarta.activation-api, Jar:oak-search, Jar:lucene-analyzers-common, Jar:lucene-core, Jar:lucene-queryparser, Jar:lucene-sandbox, Jar:lucene-queries, Jar:lucene-suggest, Jar:lucene-highlighter, Jar:lucene-memory, Jar:lucene-misc, Jar:lucene-facet, Jar:slf4j-api, Jar:annotations, Jar:jackrabbit-data, Jar:commons-codec, Jar:jcl-over-slf4j]

Any ideas?

Which JARs have the mentioned package?

Which JARs have the mentioned package?

AFAIR, lucene-core and lucene-msic have overlaps (but there may be more).