Index out bounds for axis 0?

@karolzak
Thank you very much for your awesome repo. I am using you code for getting patches and reconstructing from patches, but it produces the following error:
When I use plot_patches:
Image Shape: (3648, 5472, 3)  ### original image
Image_crop shape:  (169, 512, 512, 3)
Traceback (most recent call last):

 runfile('E:/PythonSampleCode/SliceMerge/slicemerge1.py', wdir='E:/PythonSampleCode/SliceMerge')
Reloaded modules: cv2, cv2.cv2, cv2.data
Image Shape: (3648, 5472, 3)
Image_crop shape:  (169, 512, 512, 3)
Traceback (most recent call last):

  File "<ipython-input-31-b244771ea495>", line 1, in <module>
    runfile('E:/PythonSampleCode/SliceMerge/slicemerge1.py', wdir='E:/PythonSampleCode/SliceMerge')

  File "C:\ProgramData\Anaconda3\lib\site-packages\spyder_kernels\customize\spydercustomize.py", line 786, in runfile
    execfile(filename, namespace)

  File "C:\ProgramData\Anaconda3\lib\site-packages\spyder_kernels\customize\spydercustomize.py", line 110, in execfile
    exec(compile(f.read(), filename, 'exec'), namespace)

  File "E:/PythonSampleCode/SliceMerge/slicemerge1.py", line 195, in <module>
    org_img_size=(x.shape[0], x.shape[1]), stride=256, size=256) # required - original size of the image

  File "E:/PythonSampleCode/SliceMerge/slicemerge1.py", line 110, in plot_patches
    axes[i, j].imshow(img_arr[jj])

IndexError: index 169 is out of bounds for axis 0 with size 169

when I use reconstruct_from_patches:
    stride=256) # use only if stride is different from patch size

  File "E:/PythonSampleCode/SliceMerge/slicemerge1.py", line 166, in reconstruct_from_patches
    ] = img_arr[kk, :, :, layer]

IndexError: index 169 is out of bounds for axis 0 with size 169

The crop size is 512 and stride is 256
Is there any suggestion?

Hi @ibrahimLearning !
Thanks for submitting this feedback1
Just checked and indeed there's a problem with get_patches function. Because of how it is implemented right now it will only work for square images as input. It's an obvious mistake...
I'm marking this as a bug and will update this thread once it's fixed.


Merge from 129x

Merge from 129x

If no files changed, do we still need this?

Yes, it is usually the case that no files are changed when upmerging from previous release branch. But we still need so git knows the merge was done.


consider adding dunder-bool

would you consider adding a __bool__ magic method? see https://docs.python.org/3/reference/datamodel.html#object.bool
it would mean that if result and if not result would do the obvious thing.
note that type checkers like mypy will not infer types based on the result. unfortunately, it seems the newly added typing.TypeGuard functionality only applies to regular functions, not to methods.

Hmm, not sure if I'd understand what someone was intending if I read if result. I think your #69 is_ok, is_err provider a much nicer approach no?

yep, it seems this can never be made to work in a type-safe manner.
typing.TypeGuard does allow methods to be used as type guards, but only if they take one arg after the implicit self:

If a type guard function is implemented as an instance method or class method, the first positional argument maps to the second parameter (after "self" or "cls").
– PEP 647

and on top of that def __bool__(self) would be a ‘magic’ method that is not called directly.
while i think code like this reads elegantly:
res = do_something(...)
if res:
    do_something_with(res.value)

... type checkers would disagree, and that makes it not a good fit for this library.

Does the walrus operator make sense (:=)? I've never used it but I came across this Rust syntax,
if let Ok(lines) = lines_from_file(filename) { ... }

it would become
if res := do_something(...):
    do_something_with(res.value)

this would shave off one line of code, and a unnecessary repetition of the variable name, but it suffers from the same problem: type checkers will not be able to narrow type inside the if block to only Ok, which brings us back to the problem described in my previous comment


xmark modals

          It's a really small detail, but now the x-mark is not aligned on the x-axis.

Originally posted by @exezbcz in https://github.com/kodadot/nft-gallery/issues/7660#issuecomment-1765153374

👋

happens in sidebars too


Update API doc

Some fields in API doc are missing. Either add them or remove it if it's not suppose to be accessible.

Utility functions in the C++ API which are not meant to be exposed are now hidden with Doxygen conditional statements.
API documentation can be further improved by the following:

Documentation for constructors shows an optional arguments dictionary *args, but it should explicitly show the expected arguments (presumably this happens when
Class documentation should show inherited members
If possible, URIProperty, TextProperty, IntProperty, VersionProperty, OwnedObject, ReferencedObject classes should be grouped together
SWIG instantiations of templated classes such as listOf*, owned*, or *Property should NOT be documented

Fixed by commit SynBioDex/libSBOL@1de702e5ebe47484c6918a24bafd5c5d213d9678


add Massachusetts Maritime Aademy

@whaynes Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


feat: add dropdown viewport ui behaviour

This PR aims to make <DropDown /> drop up or drop down depending on its position in the viewport.
Render

Alright, thanks for the remeinder!

This PR is not relevant anymore since DropDown component and it's multiselect variant are separately created, respectively in https://github.com/okp4/dataverse-portal/pull/444 and https://github.com/okp4/dataverse-portal/pull/448.


[New chain]: Shape Sepolia Testnet

Summary
I would like to add the Shape Sepolia Testnet network
Chain ID
11011
Chain detail URL
https://chainlist.org/chain/11011
RPC URL
https://sepolia.shape.network
Blockscout Client URL
No response
Etherscan Client URL
https://explorer-sepolia.shape.network
Etherscan Client API URL
https://explorer-sepolia.shape.network
Version
1.3.0
Address (Master copy)
0x69f4D1788e39c87893C980c06EdF4b7f686e2938
Deployment Tx hash (Master copy)
No response
Block explorer URL (Master copy)
https://explorer-sepolia.shape.network/address/0x69f4D1788e39c87893C980c06EdF4b7f686e2938
Address (Master copy L2)
0xfb1bffC9d739B8D520DaF37dF666da4C687191EA
Deployment Tx hash (Master copy L2)
No response
Block explorer URL (Master copy L2)
https://explorer-sepolia.shape.network/address/0xfb1bffC9d739B8D520DaF37dF666da4C687191EA
Address (Proxy factory)
0xC22834581EbC8527d974F8a1c97E1bEA4EF910BC
Deployment Tx hash (Proxy factory)
0x3252d8eaa161cecbfa1565f808d0b90ceeab5a329148e293aa5a1e32f49419e5
Block explorer URL (Proxy factory)
https://explorer-sepolia.shape.network/address/0xC22834581EbC8527d974F8a1c97E1bEA4EF910BC

/execute


updated template titles and reformated code

Signed-off-by: Ravi Pawar<EMAIL_ADDRESS>Fixes #1
Changes
added title support to templates
reformatted code

Closes #1


Feature/51 update to net 5

Todo

[x]  I cant build the frontend. Angular CLI/packages are bugged. Stuck in extract:rxjs: sill extract<EMAIL_ADDRESS>[x] DirectoryNotFound even when using as a NugetPackage
[ ] Fix @angular/materialcss styles not working

Its mostly finished, needs only style fix. Im a reactjs guy not angular, so that could take a while to figure it out. If anyone has any idea please reply.
.NET 5, Angular 13, Node 16

The diagram is there, but the entityt settings window is blocking the view :D

Are you going to finish this issue?

Are you going to finish this issue? I have the DictionaryNotFound exception on .NET 6 and ASP Core 6.

DictionaryNotFound is out of scope for this PR, i was mean to be only a workaround.
In the meantime i've found https://github.com/ErikEJ/EFCorePowerTools
If you are a frontent ninja you can fix the css problem with the PR and then i'll deliver a new deployment system which wont cause DictionaryNotFound Exceptions

I figured out whats going on with the diagram visualizer, so the current state is:
somehow there are missing icons and some styles from material ui and @angular/cdk packages that we need to deal with to have it fully working.


Removed unused Apache modules in SSO examples.

OAuth example does not need SAML module, so it can be removed from Dockerfile.
SAML example does not need AOuth module, so it can be removed from Dockerfile.

Thank you!


Add a list of available viable providers per chain

We need to maintain a list of viable providers for each chain (where viable means 99%+ availability and good support of all endpoints). This is a proposal to do that in this repo. Otherwise, this will be done in another package that imports @api3/chains.

This repo sounds like the correct place to me. Do you have a data structure in mind?
We could change providerUrl to an array of strings but that also raises some questions about which one someone should pick. Should they pick the first/last/random one? Or should this be in addition to the existing providerUrl field?
{
  providerUrls: [
    'https://rpc-1.xyz',
    'https://rpc-2.xyz'
  ]
}

This needs to cover paid providers as well, in which case it won't be possible to specify a provider URL. (Arguably we can do something like https://mainnet.infura.io/v3/{YOUR-API-KEY} like in ethers but that's just busywork imo.) I was thinking of something like
{
  "providers": [
    {
      "alias": "alchemy",
      "homepageUrl": "https://www.alchemy.com/"
    },
    {
      "alias": "public",
      "rpcUrl": "https://rpc.gnosischain.com"
    }
  ]
}

This would replace providerUrl.

We can expose the monitor.reblok.io status through an API to the CI of this repo such as
{
  "100": [
    {
      "alias": "alchemy",
      "healthy": true
    },
    {
      "alias": "public",
      "healthy": true
    }
  ]
}

where health is a function of many factors (is the response rate over 95%, does it respond to eth_getLogs, what is the repsonse time for a 1,000,000 gas static call, etc.), which would ultimately indicate if it does more harm than good if it was used as a redundancy.
This would then supersede the daily provider ping.
@bdrhn9 for visibility

Closing this again as it's included in the recently released v4.0.0


Replace frame stream with replay

Now that we have a nice way to use vipc from python, we no longer need camera_frame_stream. We still need a default camera driver for PC, so I think it would be nice to replace it with a replay using one of the public test routes.

@deanlee interested in this one?

do we need to support driver camera in camera_pc? there is no dcamera in public test ruotes

I’d like to support it. Here’s a public route with dcam: 534ccd8a0950a00c|2021-06-08--12-15-37.

https://commadataci.blob.core.windows.net/openpilotci/534ccd8a0950a00c/2021-06-08--12-15-37/0/dcamera.hevc:
BlobNotFoundThe specified blob does not exist

#21241


[Static analysis] - try adding detekt

Coverage increased (+0.5%) to 84.0% when pulling 9f18b1d31dd10de1e09b484148eca72470ea946a on add-detekt into 3c250fe0153b7779d1a363a0e0584491c66d6710 on master.


rexml: 3.2.8 -> 3.3.0

Fixes #319714
REXML accidentally added a version pin on a default gem (strscan) without bumping the major version. It broke a bunch of gems
REXML removed the pin on strscan in 3.3.0
https://github.com/ruby/rexml/commit/f1df7d13b3e57a5e059273d2f0870163c08d7420#diff-75d0a867bbfd5e375164c17cf7a9df96761fb050e7308f3918ad6fe1fe12d27dL58
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ryantm this should allow removing the pin added here: https://github.com/replit/nixmodules/pull/350

I didn't pick up the issue on the first upgrade, because the gemspec dependency resolution only runs through bundler. I tested the previous update by loading REXML in irb, but it was not sufficient as it doesn't run dependency resolution.
This one fixes the dependency issue.

@h7x4 Sorry I forgot to mention. This needs a backport to the stable branches.

Sure :+1:. Whenever you need to packport something, you can add a label to do so, and the github bot will try to construct a backport PR automatically (although in rare cases when it fails, you might have to create the backport manually).

Thank you! :raised_hands:

Hi, I'm on Nixos stable 24.05.2150.89c49874fb15
when running "rails new whatever" I get this error:
An error occurred while installing strscan (3.1.0), and Bundler cannot continue.
In Gemfile:
  selenium-webdriver was resolved to 4.22.0, which depends on
    rexml was resolved to 3.3.1, which depends on
      strscan

shell.nix
{ pkgs ? import <nixpkgs> {} }:
  pkgs.mkShellNoCC {
    packages = with pkgs; [
      ( ruby_3_2.withPackages (ps: with ps; [ rails ]))
    ];
}

Also tried:
( ruby.withPackages (ps: with ps; [ rails ])) - builds (ruby version: 3.1.5)
( ruby_3_2.withPackages (ps: with ps; [ rails ])) - fails (ruby version: 3.2.4)
( ruby_3_3.withPackages (ps: with ps; [ rails ])) - fails (ruby version: 3.3.2)


drop support for node < 4

Start using ES6 classes!

Thank you for your interest. But there are projects out there that rely on form-data and still using older versions of node. So I don't see the point to intentionally break other people's code.


display Console button broken?

When I click the Console button while my server is live, I get this error

error connecting to /tmp/tmux-1003/default (No such file or directory)

What game server are you running? The console button doesn't actually work for all game servers because not all LGSM game servers have a console. For example for Battlefield 1942 there is no game server console.
I do have plans to address games like Battlefield 1942 where buttons like update and console do nothing. But I haven't gotten there yet.

I get this error on L4D2 and TF2 server

Okay I've just pushed a fix for this! Tested it for a couple of game servers and it appears to be working again. Let me know if you have any problems.
All you need to do is ssh to your server, cd to your web-lgsm directory, and run git pull to pull in the new changes. You might want to back up your main.conf before doing that (cp main.conf main.conf.bak) because git pull will overwrite that file if you've made any settings changes. A comprehensive update mechanism is coming in version 1.4, till then its just git pull.
Once again thanks for reporting this and let me know if you have any other issues!


ensured UTF-8 as Velocity engines input encoding (fixes #642)

…arset
The velocity engine enforced the ISO-8859-1 input encoding (i.e. Velocity defaults) instead of the designed UTF-8.

Thanks


[json-rpc] add new integration test suite for better code coverage and adding tests easier

It is challenge to add more json-rpc tests to cover interface definition (like parent vasp role account) in existing unit tests, because it's hard to create test data by mockdb.
This change creates an integration test with local libra validator node and json-rpc service, so that setup data is accurate and easier by executing specific transactions.
Along with new integration test, I converted existing metadata, currency info, unknown role type account and dd role type account tests, and added new tests to cover: parent vasp role account, child vasp role account, peer to peer transaction with events.

This PR may have modified JSON-RPC server code.
Breaking changes policy:

Chaning JSON-RPC method signatures or removing/modifying fields
in the response in /V1 will not be accepted.
Adding fields is ok.
Adding a new JSON-RPC method is ok.

Please ensure you have also done the following to update the docs:

Update json-rpc/API-CHANGELOG.md.
Add/update type/method documentation under json-rpc/docs.

@bors-libra land

How do I download this?
Is there a way for contributing\mining\to increase value before it's live
On Fri, Sep 18, 2020, 11:26 AM bors-libra<EMAIL_ADDRESS>wrote:

Merged #6084 https://github.com/libra/libra/pull/6084 via 4d655ca
https://github.com/libra/libra/commit/4d655cac12406a0c079955a1a6110f8b8fc67fe8
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/libra/libra/pull/6084#event-3783570784, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ARBVBEMT6UFHTQC3FXSBRKTSGOJ5ZANCNFSM4RQ7WOCA
.


Submit Form

The form section seems to lack clear visual boundaries. Consider adding a shadow or border to the form box to make it stand out from the background.
Use placeholder text inside the input field to guide the user about what they need to type (e.g., "Enter your feedback here...").

I am interested in this issue.Assign me

@GarimaSingh0109 add level1 to it


chore: Refine detect-secrets hook and add it to CircleCI workflow

The type of this PR is: Chore

This PR resolves CX-1628
Description

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Refine detect-secrets hook and add it to CircleCI workflow - ole

This PR contains the following changes:

Dev changes (Refine detect-secrets hook and add it to CircleCI workflow - ole)

  Generated by :no_entry_sign: dangerJS against 6606d5f5eed51ef641d0e93dffcdd009e27bbd3b


Implement diffusive filter util

As described in Equation (23) in https://eartharxiv.org/repository/object/1751/download/3694/.

Hi @jwallwork23 , just wondering if I can take this issue?


about smoothing

Hi thanks for this interesting research.
I recognized, after the smoothing, that first 2 and last 2 frames (total 4 frames) are removed when back to video, right?
Formally, video_frames[2:-2] is actually survived. That's because of the smoothing formula. it starts computing the smoothing with frame number 2 (index i-2 for non-negative as paper).
Is there any way to include those 4 frames while maintaining the smoothness ?
Best,

i copied the first and the last frame latents and concatenate them with the original. This approach is not fancy but, it does not hurt the consistency and can match the original frame length. it works well because the adjacent latents are already quite close and smooth procedure is just giving the latent vectors a bit of consistency. i did this with video of 25 fps.
i hope it helps someone.


Added deoplete sap-icon plugin

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


⚠ Bofrost.at has degraded performance

In 2541943, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2093 ms

Resolved: Bofrost.at performance has improved in f232481 after 7 minutes.


[Question]: index.docstore is empty after persisting nodes in chromadb

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Hello,
I have persisted the nodes in ChromaDB along with the storage context. However, when retrieving the vector index, the index.docstore is empty, how can I get the nodes later to use for BM25Retriever? Here is the code used for persisting and retrieving:
# node transformation
node_parser = SentenceSplitter(chunk_size=1024, chunk_overlap=20)

# collect llama index documents
documents = process_documents(df)

# initialize chroma client, setting path to save data
db = chromadb.PersistentClient(path=chroma_db_path)

# create collection
chroma_collection = db.get_or_create_collection(collection_name)

# assign chroma as the vector_store to the context
vector_store = ChromaVectorStore(chroma_collection=chroma_collection)
storage_context = StorageContext.from_defaults(vector_store=vector_store)

# Embedding Model
embed_model = HuggingFaceEmbedding(model_name=hf_model_name, device=hf_device)

# create your index
index = VectorStoreIndex.from_documents(
        documents,
        storage_context=storage_context,
        show_progress=True,
        transformations=[node_parser],
        embed_model=embed_model,
)

# Here we save the index to the path we want
index.storage_context.persist(persist_dir=os.path.join(chroma_db_path, "llamai"))

# initialize chroma client, setting path to save data
db = chromadb.PersistentClient(path=chroma_db_path)

# create collection
chroma_collection = db.get_or_create_collection(collection_name)

# assign chroma as the vector_store to the context
vector_store = ChromaVectorStore(chroma_collection=chroma_collection)
storage_context = StorageContext.from_defaults(
      vector_store=vector_store, persist_dir=os.path.join(chroma_db_path, "llamai")
)

# Embedding Model
embed_model = HuggingFaceEmbedding(model_name=hf_model_name, device=hf_device)

# get the index
index = VectorStoreIndex.from_vector_store(
      vector_store=vector_store,
      storage_context=storage_context,
      embed_model=embed_model,
)

# return the index
return index

This is correct. The docstore is disabled with most 3rd party vector stores to simplify storage, since the nodes are stored in chroma itself
You can override this if you want: VectorStoreIndex.from_documents(...., store_nodes_override=True)

I understand. Could you please clarify the correct way to use BM25Retriever? Instead of providing the nodes during initialization, I supplied a reference to the docstore, but it resulted in an error.
  File "/usr/local/anaconda3/envs/rag-search/lib/python3.9/site-packages/llama_index/retrievers/bm25/base.py", line 73, in from_defaults
    return cls(
  File "/usr/local/anaconda3/envs/rag-search/lib/python3.9/site-packages/llama_index/retrievers/bm25/base.py", line 40, in __init__
    self.bm25 = BM25Okapi(self._corpus)
  File "/usr/local/anaconda3/envs/rag-search/lib/python3.9/site-packages/rank_bm25.py", line 83, in __init__
    super().__init__(corpus, tokenizer)
  File "/usr/local/anaconda3/envs/rag-search/lib/python3.9/site-packages/rank_bm25.py", line 27, in __init__
    nd = self._initialize(corpus)
  File "/usr/local/anaconda3/envs/rag-search/lib/python3.9/site-packages/rank_bm25.py", line 52, in _initialize
    self.avgdl = num_doc / self.corpus_size
ZeroDivisionError: division by zero

You'll need to either manually populate the docstore or use the flag above. And then persist the dcostore somewhere.
Or, you can directly save the nodes somewhere

Got it! Thanks for your help @logan-markewich


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_02c868e3-daa7-4d74-bbef-8843eb8e3add/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_02c868e3-daa7-4d74-bbef-8843eb8e3add.git

Docs Build status updates of commit 62debf7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-07-12-06-53-16 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Unable to Play large file video from Google Drive Link

I am trying to play a video from a google drive link, the video is more than 300 MB, so getting a warning itself to download it anyway from the link when I open it in the browser. So I just want to play the video bypassing the message download it anyway from the link
But getting errors like this:
I/ExoPlayerImpl(28303): Release da45690 [ExoPlayerLib/2.18.1] [sakura_india, Redmi 6 Pro, Xiaomi, 28] [goog.exo.core, goog.exo.exoplayer, goog.exo.decoder, goog.exo.datasource, goog.exo.extractor] I/ExoPlayerImpl(28303): Init b6c8f9 [ExoPlayerLib/2.18.1] [sakura_india, Redmi 6 Pro, Xiaomi, 28] D/AudioManager(28303): getStreamVolume isRestricted mode = 0 E/ExoPlayerImplInternal(28303): Playback error E/ExoPlayerImplInternal(28303):   com.google.android.exoplayer2.ExoPlaybackException: Source error E/ExoPlayerImplInternal(28303):       at com.google.android.exoplayer2.ExoPlayerImplInternal.handleIoException(ExoPlayerImplInternal.java:632) E/ExoPlayerImplInternal(28303):       at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:602) E/ExoPlayerImplInternal(28303):       at android.os.Handler.dispatchMessage(Handler.java:102) E/ExoPlayerImplInternal(28303):       at android.os.Looper.loop(Looper.java:201) E/ExoPlayerImplInternal(28303):       at android.os.HandlerThread.run(HandlerThread.java:65) E/ExoPlayerImplInternal(28303):   Caused by: com.google.android.exoplayer2.source.UnrecognizedInputFormatException: None of the available extractors (FlvExtractor, FlacExtractor, WavExtractor, FragmentedMp4Extractor, Mp4Extractor, AmrExtractor, PsExtractor, OggExtractor, TsExtractor, MatroskaExtractor, AdtsExtractor, Ac3Extractor, Ac4Extractor, Mp3Extractor, AviExtractor, JpegExtractor) could read the stream. E/ExoPlayerImplInternal(28303):       at com.google.android.exoplayer2.source.BundledExtractorsAdapter.init(BundledExtractorsAdapter.java:92) E/ExoPlayerImplInternal(28303):       at com.google.android.exoplayer2.source.ProgressiveMediaPeriod$ExtractingLoadable.load(ProgressiveMediaPeriod.java:1017) E/ExoPlayerImplInternal(28303):       at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:412) E/ExoPlayerImplInternal(28303):       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) E/ExoPlayerImplInternal(28303):       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) E/ExoPlayerImplInternal(28303):       at java.lang.Thread.run(Thread.java:764) E/flutter (28303): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(VideoError, Video player had error com.google.android.exoplayer2.ExoPlaybackException: Source error, null, null) E/flutter (28303):
Please help me out, I am not pretty sure that  this error is because of google warning download it anyway from the link

Any update?


Image Size

Hi, is it possible to set image size? currently it's using the size of the image itself. problem with this if i have an image from the web i want to show in CRToast and want to use the x2 version of the image for retina. Any possible solution for this?

Right now you will need to resize the image in code

@Ashton-W that's what i did. I want to show the image as 40x40 but the original image size is 80x80 so it won't be blurry for retina devices. I tried to resize to image to 80x80 it shows the image as 80x80 points still it's blurry. i think the CRToast image is using the image size itself. let me know if i'm doing something wrong.

how do i Set image on Toast and its showing very small , i think the Reason is Slide over status bar is not customized , how can i show this toast on overlay of  ViewController ??

@Ashton-W is there a fix for workaround for this already?


Update status after configuration

Set the status to active after the vhost has been reconfigured

I actually disagree with this code. Just because nginx is installed doesn't mean layers above it are ready.

Won't the layers above it override this status anyway?

if the configure_site function sets the state to "maintenance", IMHO it should also unset it.
An alternative would be not to set it at all, and leave to the calling code to handle states when needed.
Prior to this change, a simple call to configure_site would leave the unit in "maintenance" unless the charm using the layer implements workload status

I like the status_set telling us that NGINX is active (ready) and then letting the top layers set their own statuses when needed

I think layers other than the top should not be able to set_status. They need to advise their parent layer of their state, but don't have enough of a view on things to be able to set the status of the unit as a whole.
I totally agree with the idea of the symmetry though, if Nginx layer is saying it's in maintenance, it definitely needs to say when it's not in maintenance too.


Format

Add formatter and run formatter on source files.

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3d4be2b) 61.37% compared to head (b1bad3a) 77.63%.

Files
Patch %
Lines

diagnostics-extension/src/utils.ts
50.00%
2 Missing :warning:

diagnostics-extension/src/controllers/telemetry.ts
66.66%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #71       +/-   ##
===========================================
+ Coverage   61.37%   77.63%   +16.26%
===========================================
  Files          25        4       -21
  Lines         466      161      -305
  Branches       51       21       -30
===========================================
- Hits          286      125      -161
+ Misses        177       36      -141
+ Partials        3        0        -3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ArgumentError: wrong number of arguments (1 for 0)

I saw a similar problem at #52.
[2] pry(main)> User.first.send_message(User.last, 'body body', 'subject')
  User Load (0.3ms)  SELECT  "users".* FROM "users"   ORDER BY "users"."id" ASC LIMIT 1
  User Load (0.2ms)  SELECT  "users".*  AND "mailboxer_conversation_opt_outs"."unsubscriber_type" = 'User' AND "mailboxer_conversation_opt_outs"."unsubscriber_id" = 2  [["conversation_id", 9]]
ArgumentError: wrong number of arguments (1 for 0)
from /home/pills/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.4/lib/active_record/attribute_methods.rb:45:in `__temp__56d61696c6'

Everything is saved correctly but there is an error at the end, here is my config:
Mailboxer.setup do |config|

  #Configures if you application uses or not email sending for Notifications and Messages
  config.uses_emails = true

  #Configures the default from for emails sent for Messages and Notifications
  config.default_from =<EMAIL_ADDRESS>
  #Configures the methods needed by mailboxer
  config.email_method = :email
  config.name_method = :name

  #Configures if you use or not a search engine and which one you are using
  #Supported engines: [:solr,:sphinx]
  config.search_enabled = false
  # config.search_engine = :solr

  #Configures maximum length of the message subject and body
  config.subject_max_length = 255
  config.body_max_length = 32000
end

And my model:
class User < ActiveRecord::Base
  acts_as_messageable

  ...

User model has name and email methods:
[3] pry(main)> User.first.name
  User Load (0.2ms)  SELECT  "users".* FROM "users"   ORDER BY "users"."id" ASC LIMIT 1
=> "Juan David Pastás"
[4] pry(main)> User.first.email
  User Load (0.4ms)  SELECT  "users".* FROM "users"   ORDER BY "users"."id" ASC LIMIT 1
=><EMAIL_ADDRESS>

This is part of the trace:
/home/pills/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.4/lib/active_record/attribute_methods.rb:45:in `__temp__56d61696c6'
/home/pills/.rvm/gems/ruby-2.1.2/gems/mailboxer-0.12.5/lib/mailboxer/mail_dispatcher.rb:16:in `block in call'
/home/pills/.rvm/gems/ruby-2.1.2/gems/mailboxer-0.12.5/lib/mailboxer/mail_dispatcher.rb:15:in `each'
/home/pills/.rvm/gems/ruby-2.1.2/gems/mailboxer-0.12.5/lib/mailboxer/mail_dispatcher.rb:15:in `call'
/home/pills/.rvm/gems/ruby-2.1.2/gems/mailboxer-0.12.5/app/models/mailboxer/message.rb:38:in `deliver'
/home/pills/.rvm/gems/ruby-2.1.2/gems/mailboxer-0.12.5/lib/mailboxer/models/messageable.rb:83:in `send_message'

It says email_to = recipient.send(Mailboxer.email_method, mailable).

Hey,
I have the same error.
I'm adding more info to what @juanpastas posted.
 AND "mailboxer_conversation_opt_outs"."unsubscriber_type" = 'Trainee' AND "mailboxer_conversation_opt_outs"."unsubscriber_id" = 1  [["conversation_id", 4]]
ArgumentError: wrong number of arguments (1 for 0)
from /Library/Ruby/Gems/2.0.0/gems/activerecord-4.1.6/lib/active_record/attribute_methods.rb:45:in `__temp__56d61696c6'

And my config is:
Mailboxer.setup do |config|

  #Configures if you application uses or not email sending for Notifications and Messages
  config.uses_emails = true

  #Configures the default from for emails sent for Messages and Notifications
  config.default_from =<EMAIL_ADDRESS>
  #Configures the methods needed by mailboxer
  config.email_method = :email
  config.name_method = :name

  #Configures if you use or not a search engine and which one you are using
  #Supported engines: [:solr,:sphinx]
  config.search_enabled = false
  config.search_engine = :solr

  #Configures maximum length of the message subject and body
  config.subject_max_length = 255
  config.body_max_length = 32000
end

And I think the error is somehow related to email sending because I did some tests and it appears only when config.uses_emails is set to true. If you don't use emails then you don't get this error.

In my  case I needed to create a mail method with argument.
def mailboxer_email(messageable)
  email
end

You might not use messageable argument.

@juanpastas thank you.
Yes, didn't read carefully the specification and didn't saw the argument for mailboxer_email

@juanpastas thanks!


[FEATURE]: Possible to add a "Play Url" like the spotify plugin?

Consent

[X] I have searched the existing issues and verified that there is no open issue for the same subject.
[X] I understand that the YTMDesktop Elgato Plugin has NO affiliation with Google, YouTube or the YTMDesktop application.

Feature
The feature would be a button that you can assign the Url of a song/video or playlist that you can press to immediately swap to that specific song/video or playlist
Solution
No response
Alternatives
No response
Anything else?
No response

Hey. Thank you for your request.
I'll check what I can do, but can't promise anything (especially due to the Holiday season in my country).
But can you give me some more information on how you would like it? Just a field where you post a link to a YouTube Music Video / Playlist? Or do you really mean Videos/Playlists from youtube.com?

But can you give me some more information on how you would like it? Just a field where you post a link to a YouTube Music Video / Playlist? Or do you really mean Videos/Playlists from youtube.com?

Yes you would have a field to enter a Youtube Music Video / Playlist link and then when you press the button it would start playing that Video/Playlist in Youtube Music immediately
(sorry that I didnt make it clear the first time)

Hey! I'm currently working on the V2 support and tried to implement your suggested feature.
Sadly I've to inform you, that it's not possible, to implement this in the current plugin architecture. I've tried it in multiple ways but it seems no matter what I try, I can't use custom URI schemes (the only thing YTMDesktop supports to do something like that). Elgato seems to block it and like mentioned before, YTMDestkop, even in V2, doesn't support such things through their API.
That's why I've considered to /close this issue for now. I'll re-investigate it in the future to look if support gets added.


[CP] Increase the recommended Xcode version to Xcode 15

Issue Link
https://github.com/flutter/flutter/issues/144582
Target
beta
PR Link
https://github.com/flutter/flutter/pull/146440
Changelog Description
Increase the flutter doctor recommended Xcode version to Xcode 15.
Impacted Users
Flutter app developers targeting iOS or macOS
Impact Description
Update the flutter doctor validator to suggest Xcode 15 if installed version is lower.
This is to encourage upgrades, as Apple will soon be enforcing this during iOS App Store submissions.

Please note that as of April 2024 all iOS and iPadOS apps submitted to the App Store must be built with a minimum of Xcode 15 and the iOS 17 SDK.

https://developer.apple.com/ios/submit/
It's also to encourage updates before Swift Package Manager requires this version in https://github.com/flutter/flutter/pull/146256.
Workaround
N/A
Risk
low
Test Coverage
yes
Validation Steps
Install and xcode-select Xcode 14.x or lower.  Run flutter doctor.  See

I guess this issue is no longer necessary if we use the automatic workflow https://github.com/flutter/flutter/pull/146440.


Concealed Blade Perk in Roguery

The concealed blade perk in rogue don't work. Any chance a fix can be implemented?

Yeah, we'll look into it.

Should work as from v0.1.0-rc7+


Add new subscription fails for already known subscription

If the subscription is known in a different profile, it can't be added to the current profile. Follow up of #5.

updated title

fixed bug for adding new stream with same name in different profile.
pushing the branch, some fixes for Adding subscription are pending.
once done will update the issue.


Some open applications and windows move when switching between virtual desktops

Microsoft PowerToys version
0.60.1
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones Editor
Steps to reproduce
Installed Power Tools to try out FancyZones on a quad-display workstation that utilizes multiple Windows Virtual Desktops.
Created zones for each display. Assigned some applications to zones and some applications NOT assigned to any zones. Example of an application not assigned to any zone would be git bash consoles (2x), windows file explorer, and one or more Edge browser windows.
Upon moving between virtual desktops I find that the bash consoles, windows file explorer, edge browser window, etc all get relocated from their original positions on the non-primary monitors over to the primary display. This happens consistently even if I move those applications back to the non-primary displays, after I navigate my virtual desktops again I will find the windows moved.
This is 100% unacceptable. Open applications that I did not move should not and shall not move just because I switched between a couple of my virtual desktops.
PowerToysReport_2022-07-18-09-39-29.zip
✔ Expected Behavior
No open applications or windows will move or relocate themselves when I switch between my various virtual desktops.
❌ Actual Behavior
Found that certain applications and windows consistently relocate themselves to the primary display upon switching between windows virtual desktops (after setting up FancyZones). The applications that move were NOT assigned to any specific zone.
Other Software
Microsoft Windows Virtual Desktop feature in Windows 10 Pro.

Discovered this appears to be related to the use of the FancyZone setting "Move newly created windows to the current active monitor". After disabling that setting the issue appears to have stopped. Please update that setting to only affect newly opened windows so I can re-enable it.

I disabled FancyZones to make this go away. Thank you, now I can use it again and just disable "Move newly created windows to the current active monitor"!

I'm glad that helped @Niklas but personally I really hope they fix the "Move newly created windows to the current active monitor" feature because that was essentially the main reason that I installed power tools and tried out FancyZones.

Unfortunately, I have the same issue, but disabling the option 'Move newly created windows to the current active monitor' and this did not fix the error. It did seem to initially, but the issue returns.

I have also noticed since I first submitted this bug that even with 'Move newly created windows to the current active monitor' disabled there are still some windows that get moved or adjusted as I switch between my virtual desktops. An example would be using fancy zones to snap a window into one third of a screen, then resize it slightly, and after that if I navigate to another virtual desktop that application gets resized again.
This is really limiting the usefulness of the fancyzones feature. If it's going to clash this hard with existing windows features like virtual desktops then I'm going to have to uninstall it completely and not use it.

It's the same issue as this, right?:
https://github.com/microsoft/PowerToys/issues/19409
I think it will be a general problem to everyone using multi-screen, multi-workspace (multi-resolution?) setup. For now, the workaround seems to be to disable "Move newly created to their last known zone" as well as  "Move newly created windows to the current active monitor".
Just my input on its apparent behavior:

It happens on windows that are not assigned a zone through fancyzones. So on windows that are resized, maximized or use the native snap features. (and also have a history of once being placed in a zone)
when you switch workspaces and back, the window will fit itself into its last known fancyzone, except (en this is what was so confusing about its behavior):
It also happens when you have two windows open of the same app on different workspaces (like a chrome browser on each). One positioned with fancyzone, the other not. When you switch workspaces, the one that is not in a fancyzone, will position itself in the zone where the other one on the other workspace is placed.

I hope that clarifies the issue a bit.

@ChristopheVandePoel I would not describe it as the same issue as #19409, although it's possible the underlying causes of these bugs is the same but I feel that we are observing a different unwanted behavior in this particular issue.
The desired outcome is the same: "No open applications or windows will move or relocate themselves when I switch between my various virtual desktops."

@ChristopherVandePoel
While this does seem similar to #19503 it is not resolved by disabling "Move newly created to their last known zone" as well as "Move newly created windows to the current active monitor".
Thank you.

Is it reproducible on 0.65? Thanks!
/needinfo

My comment above doesn' t reproducible on 0.65.

Works fine for me as well, thank you very much!

I've been using it happily for a few days now and I think that although it is not perfect it is "good enough" to close the issue. I still have some minor hiccups with things moving once in a great while, or a window failing to open on the active monitor as requested, but for the most part it works and is no longer causing me angst during my day. Thank you again for addressing this problem.


JSRuntime call from js to blazor breaks after use at least one binding in page

Describe the bug
Call JSInvokable method of instance or static class, from js event, dont work after i change value of any html element with binding to field or property.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core NET Core 3.0 Preview 9
create helper class:

public class JsHelper
    {
        [JSInvokable]
        public static Task ReturnArrayAsync()
        {
            return Task.FromResult(0);
        }
    }

create any blazor page with elements:
<select class="select form-control" onchange="{alert('Hello 10'); DotNet.invokeMethodAsync('WebApplication3', 'ReturnArrayAsync'); return; }">
    <option value="1">1</option>
    <option value="2">2</option>
</select>

    <input class="form-check-input" type="radio" name="typeRadios" id="sellCheck" @onchange="(e=> { IsSale = true; })" />

            sell online

    <input class="form-check-input" type="radio" name="typeRadios" id="buyCheck" @onchange="(e=> { IsSale = false; })" />

        buy online

create code:
 private bool? IsSale = null;
Expected behavior
After loading the page to change the radio value, the 'Hello 10' alert will work and the ReturnArrayAsync method will be called. This is normal.
But if you first change the values of select or any other element with binding, then after changing the value of select, 'Hello 10' will be called, but ReturnArrayAsync will not be called.
Additional context
c:\Users\Coding\source\repos\WebApplication3>dotnet --info
Пакет SDK для .NET Core (отражающий любой global.json):
Version:   3.0.100-preview9-014004
Commit:    8e7ef240a5
Среда выполнения:
OS Name:     Windows
OS Version:  10.0.18362
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview9-014004\
Host (useful for support):
Version: 3.0.0-preview9-19423-09
Commit:  2be172345a
.NET Core SDKs installed:
2.1.801 [C:\Program Files\dotnet\sdk]
2.2.401 [C:\Program Files\dotnet\sdk]
3.0.100-preview7-012821 [C:\Program Files\dotnet\sdk]
3.0.100-preview8-013656 [C:\Program Files\dotnet\sdk]
3.0.100-preview9-014004 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0-preview7.19365.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0-preview9.19424.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0-preview7-27912-14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0-preview9-19423-09 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0-preview7-27912-14 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.0.0-preview9-19423-09 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Thanks for contacting us, @zefir01.
@javiercn can you please look into this? Thanks!

@zefir01 Can you provide a minimal repro project we can use to investigate the issue?

very strange, but in a minimal project there is no such bug. send you the whole project?

@zefir01 I would suggest you start adding things back from the minimal repro to your project until you find out what is causing it.
You can also turn on more detailed logging to get insights on how the app is working.
Replace  with the snippet below in _Host.cshtml

This turns debug logging on the server. (replace it in appSettings.development.json)
{
  "Logging": {
    "LogLevel": {
      "Default": "Debug",
      "System": "Debug",
      "Microsoft": "Debug"
    }
  }
}

I turned on debugging as you recommended. now I get the error:
createAdvertisement:183 [Violation] 'change' handler took 1384ms
blazor.server.js:8 Uncaught (in promise) Error: No .NET call dispatcher has been set.
    at u (blazor.server.js:8)
    at c (blazor.server.js:8)
    at Object.e.invokeMethodAsync (blazor.server.js:8)
    at HTMLSelectElement.onchange (createAdvertisement:183)
u @ blazor.server.js:8
c @ blazor.server.js:8
e.invokeMethodAsync @ blazor.server.js:8
onchange @ createAdvertisement:183

@zefir01 From the error it seems like you are invoking the change event before blazor is fully initialized.
Instead of attaching the event handler inline, define a function you can call through JS interop in (OnAfterRender(firstRender)) and call that function to programatically attach the event handler there. That should solve your problem.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


Update README.md

Updated documentation use of alternativeButtonTitleColor
On top of that the screenshot should probably be updated with the correct color for the alternativeButton:

Checklist

[ ] I've tested my changes.
[ ] I've read the Contribution Guidelines.
[ ] I've updated the documentation if necessary.

Motivation and Context

Description

Nice catch! Thanks for fixit it :D


Can not echo map_array topic

Hi,
I am trying to echo the map_array topic to get som more information about it. But i get the following error message:
Traceback (most recent call last):
  File "/opt/ros/foxy/bin/ros2", line 11, in <module>
    load_entry_point('ros2cli==0.9.11', 'console_scripts', 'ros2')()
  File "/opt/ros/foxy/lib/python3.8/site-packages/ros2cli/cli.py", line 67, in main
    rc = extension.main(parser=parser, args=args)
  File "/opt/ros/foxy/lib/python3.8/site-packages/ros2topic/command/topic.py", line 41, in main
    return extension.main(args=args)
  File "/opt/ros/foxy/lib/python3.8/site-packages/ros2topic/verb/echo.py", line 71, in main
    return main(args)
  File "/opt/ros/foxy/lib/python3.8/site-packages/ros2topic/verb/echo.py", line 86, in main
    message_type = get_msg_class(node, args.topic_name, include_hidden_topics=True)
  File "/opt/ros/foxy/lib/python3.8/site-packages/ros2topic/api/__init__.py", line 99, in get_msg_class
    msg_class = _get_msg_class(node, topic, include_hidden_topics)
  File "/opt/ros/foxy/lib/python3.8/site-packages/ros2topic/api/__init__.py", line 144, in _get_msg_class
    return get_message(message_type)
  File "/opt/ros/foxy/lib/python3.8/site-packages/rosidl_runtime_py/utilities.py", line 28, in get_message
    interface = import_message_from_namespaced_type(get_message_namespaced_type(identifier))
  File "/opt/ros/foxy/lib/python3.8/site-packages/rosidl_runtime_py/import_message.py", line 30, in import_message_from_namespaced_type
    module = importlib.import_module(
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'lidarslam_msgs'

I cant find the msg type in the interface list either.. I am kind of new to ROS, is there something I am missing?

You must enter "source /install/sewtup.bash" before doing "ros2 topic e

Thanks for your reply! That worked


Broken Footer Links & Validation Additions for Login and SignUp Forms

1.  Footer section links are broken :

2. Add Validation for login Form:

3. Add Validation for SignUp button:

@kushalkumar1362 this has been done


Rework Electron Auth

Pulling Electron Authorization out into @iTwin/electron-authorization (PR link).

Renamed NativeAppAuthorization as ElectronAppAuthorization and simplified setup. Configuration is done entirely on the backend and the ElectronAppAuthorization simply makes IPC calls to the backend. It is no longer created automatically by NativeApp, but instead must be passed in as a part of the NativeAppOpts like this opts.iModelApp.authorizationClient on startup and it will then be assigned to IModelApp.authorizationClient.
Renamed NativeAppAuthorizationBackend as ElectronAuthorizationBackend. Separate from the ElectronHost it must be created and assigned to IModelHost.authorizationClient and also initialized.
Removed ImsAuthorizationClient and subsequently flattened the MobileAuthorizationClient hierarchy.
NativeAppAuthorizationConfiguration has been moved to core-mobile and renamed to MobileAppAuthorizationConfiguration.

I am unable to run display-test-app. Are you? Error: Cannot find module '@itwin/core-geometry'
Steps:
git pull
# optionally rimraf common\temp
rush install
rush build --to display-test-app
cd test-apps\display-test-app
start npm run start

Result:
><EMAIL_ADDRESS>start D:\j2\s\imodeljs\test-apps\display-test-app
> cross-env NODE_ENV=development run-p start:webserver start:electron

><EMAIL_ADDRESS>start:webserver D:\j2\s\imodeljs\test-apps\display-test-app
> cross-env DISABLE_NEW_JSX_TRANSFORM=true SKIP_PREFLIGHT_CHECK=true DISABLE_NEW_ASSET_COPY=true BROWSER=none USE_FULL_SOURCEMAP=true DISABLE_ESLINT=true TRANSPILE_DEPS=false USE_FAST_SASS=true DISABLE_TERSER=true  react-scripts start

><EMAIL_ADDRESS>start:electron D:\j2\s\imodeljs\test-apps\display-test-app
> electron ./lib/backend/DtaElectronMain.js

App threw an error during load
Error: Cannot find module '@itwin/core-geometry'
Require stack:
- D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+core-common<EMAIL_ADDRESS>- D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+core-common<EMAIL_ADDRESS>- D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+electron-authorization<EMAIL_ADDRESS>- D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+electron-authorization<EMAIL_ADDRESS>- D:\j2\s\imodeljs\test-apps\display-test-app\lib\backend\Backend.js
- D:\j2\s\imodeljs\test-apps\display-test-app\lib\backend\DtaElectronMain.js
-<EMAIL_ADDRESS>-
    at Module._resolveFilename (internal/modules/cjs/loader.js:892:15)
    at Function.n._resolveFilename (electron/js2c/browser_init.js:245:1128)
    at Module._load (internal/modules/cjs/loader.js:737:27)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:964:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+core-common@3.0.0-extension.1_f2c3418fbeb77077b236020c30c9aae4\node_modules\@itwin\core-common\lib\cjs\AnalysisStyle.js:11:25)
    at Module._compile (internal/modules/cjs/loader.js:1083:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1113:10)
    at Module.load (internal/modules/cjs/loader.js:940:32)

I am unable to run display-test-app. Are you? Error: Cannot find module '@itwin/core-geometry'
Steps:
git pull
# optionally rimraf common\temp
rush install
rush build --to display-test-app
cd test-apps\display-test-app
start npm run start

Result:
><EMAIL_ADDRESS>start D:\j2\s\imodeljs\test-apps\display-test-app
> cross-env NODE_ENV=development run-p start:webserver start:electron

><EMAIL_ADDRESS>start:webserver D:\j2\s\imodeljs\test-apps\display-test-app
> cross-env DISABLE_NEW_JSX_TRANSFORM=true SKIP_PREFLIGHT_CHECK=true DISABLE_NEW_ASSET_COPY=true BROWSER=none USE_FULL_SOURCEMAP=true DISABLE_ESLINT=true TRANSPILE_DEPS=false USE_FAST_SASS=true DISABLE_TERSER=true  react-scripts start

><EMAIL_ADDRESS>start:electron D:\j2\s\imodeljs\test-apps\display-test-app
> electron ./lib/backend/DtaElectronMain.js

App threw an error during load
Error: Cannot find module '@itwin/core-geometry'
Require stack:
- D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+core-common<EMAIL_ADDRESS>- D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+core-common<EMAIL_ADDRESS>- D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+electron-authorization<EMAIL_ADDRESS>- D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+electron-authorization<EMAIL_ADDRESS>- D:\j2\s\imodeljs\test-apps\display-test-app\lib\backend\Backend.js
- D:\j2\s\imodeljs\test-apps\display-test-app\lib\backend\DtaElectronMain.js
-<EMAIL_ADDRESS>-
    at Module._resolveFilename (internal/modules/cjs/loader.js:892:15)
    at Function.n._resolveFilename (electron/js2c/browser_init.js:245:1128)
    at Module._load (internal/modules/cjs/loader.js:737:27)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:964:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (D:\j2\s\imodeljs\common\temp\node_modules\.pnpm\@itwin+core-common@3.0.0-extension.1_f2c3418fbeb77077b236020c30c9aae4\node_modules\@itwin\core-common\lib\cjs\AnalysisStyle.js:11:25)
    at Module._compile (internal/modules/cjs/loader.js:1083:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1113:10)
    at Module.load (internal/modules/cjs/loader.js:940:32)

I'm pretty sure this has to do with a lack of peer dependency on core-geometry within the @itwin/electron-authorization package. I've created a PR in the auth-clients repo to address that and once it is merged and published to NPM this should hopefully be resolved.

I've created a PR in the auth-clients repo to address that and once it is merged and published to NPM this should hopefully be resolved.

Ok. let's make sure not to merge this PR until that happens.

@pbell97 if I install+build display-test-app on this branch again should I expect to be able to sign in successfully now?

@pbell97 if I install+build display-test-app on this branch again should I expect to be able to sign in successfully now?

@pmconne Yes it should fix that error now that I updated the @itwin/electron-authorization version. I just tested locally and it worked. Definitely let me know if it doesn't for you.

I pulled branch and ran ui-test-app, I am able to open a local file in electron. But, If I try to open an iModel from QA, using iModelOpen stage, I get the following...
Unhandled Rejection (Error): API request error: {"errorNumber":0,"name":"Error","description":"cannot GET https://qa-api.bentley.com/projects/?$top=10 (401)","_data":{"error":{"code":"Unauthorized","message":"IDX10214: Audience validation failed. Audiences: 'https://qa-ims.bentley.com/as/token.oauth2, https://qa-imsoidc.bentley.com/as/token.oauth2, https://qa2-ims.bentley.com/as/token.oauth2, https://qa2-imsoidc.bentley.com/as/token.oauth2, https://qa-imsoidc.bentley.com/resources, https://qa2-ims.bentley.com/resources, itwinjs-services'. Did not match: validationParameters.ValidAudience: 'null' or validationParameters.ValidAudiences: 'bentley-api-management'."}},"status":401,"message":"{\"error\":{\"code\":\"Unauthorized\",\"message\":\"IDX10214: Audience validation failed. Audiences: 'https://qa-ims.bentley.com/as/token.oauth2, https://qa-imsoidc.bentley.com/as/token.oauth2, https://qa2-ims.bentley.com/as/token.oauth2, https://qa2-imsoidc.bentley.com/as/token.oauth2, https://qa-imsoidc.bentley.com/resources, https://qa2-ims.bentley.com/resources, itwinjs-services'. Did not match: validationParameters.ValidAudience: 'null' or validationParameters.ValidAudiences: 'bentley-api-management'.\"}}"}

I am also getting following prompt each time I run.

@bsteinbk Would you mind testing the same workflow on master and see if you get the same result? I was able to reproduce that exact error on both this branch and master while using app credentials I created on qa-developer.bentley.com.

@calebmshafer @pbell97 Yes, I see the same problems on master. so I guess this PR didn't make it worse (or better).  Is it not an authorization problem if we can't get to iModels on QA?

@bsteinbk mind giving this another try? The ui-test-app should be working properly now.

@calebmshafer I still get the following permissions message every time I start electron and I still get an error if I just try to use the iModelOpen stage. The only thing I can do is to open a local bim file.

@bsteinbk does your .env have a IMJS_OIDC_ELECTRON_TEST_SCOPES with the offline_access scope? With this scope you should only see that screen once as it caches a refresh token on your behalf.
Also, if you press the accept button on that page does it not redirect you back to the app properly signed in? If not, what happens when you click on it?

@calebmshafer If I hit accept I can open a local file with no issues. Each time I restart I am prompted to Accept again.
Here are my scopes - IMJS_OIDC_ELECTRON_TEST_SCOPES="openid profile organization email itwinjs"
I can NOT open a file from hub ... I get the following
Unhandled Rejection (Error): API request error: {"errorNumber":0,"name":"Error","description":"cannot GET https://qa-api.bentley.com/projects/?$top=10 (401)","_data":{"error":{"code":"Unauthorized","message":"IDX10214: Audience validation failed. Audiences: 'https://qa-ims.bentley.com/as/token.oauth2, https://qa-imsoidc.bentley.com/as/token.oauth2, https://qa2-ims.bentley.com/as/token.oauth2, https://qa2-imsoidc.bentley.com/as/token.oauth2, https://qa-imsoidc.bentley.com/resources, https://qa2-ims.bentley.com/resources, itwinjs-services'. Did not match: validationParameters.ValidAudience: 'null' or validationParameters.ValidAudiences: 'bentley-api-management'."}},"status":401,"message":"{\"error\":{\"code\":\"Unauthorized\",\"message\":\"IDX10214: Audience validation failed. Audiences: 'https://qa-ims.bentley.com/as/token.oauth2, https://qa-imsoidc.bentley.com/as/token.oauth2, https://qa2-ims.bentley.com/as/token.oauth2, https://qa2-imsoidc.bentley.com/as/token.oauth2, https://qa-imsoidc.bentley.com/resources, https://qa2-ims.bentley.com/resources, itwinjs-services'. Did not match: validationParameters.ValidAudience: 'null' or validationParameters.ValidAudiences: 'bentley-api-management'.\"}}"}
ProjectsAccessClient.getByQuery
D:/github/electron/itwinjs-core/common/temp/node_modules/.pnpm/@itwin+projects-client@0.2.0/node_modules/@itwin/projects-client/src/ProjectsClient.ts:64
async IModelOpen.componentDidMount
D:/github/electron/itwinjs-core/test-apps/ui-test-app/src/frontend/appui/imodelopen/IModelOpen.tsx:76
  73 |
  74 |    const accessToken = await IModelApp.getAccessToken();
  75 |    const client = new ProjectsAccessClient();
> 76 |    const iTwins = await client.getAll(accessToken, { pagination: { skip: 0, top: 10 } });
     | ^  77 |    this.setState({
  78 |      isLoadingITwins: false,
  79 |      isLoadingIModels: true,

@bsteinbk can you try adding that offline_access scope and see if that helps?

@calebmshafer - offline_access has stopped the constant Accepting of scopes.  I still can NOT open an iModel from the Hub. I still get the message I already sent containing _data":{"error":{"code":"Unauthorized","message":"IDX10214: Audience validation failed. Audiences

@calebmshafer - I have tried the clientId you sent me
IMJS_OIDC_ELECTRON_TEST_CLIENT_ID="native-eZqfqqx57bcMA6pTq4NZc4zPr"
and I even tried creating my own using https://qa-developer.bentley.com/my-apps which is
IMJS_OIDC_ELECTRON_TEST_CLIENT_ID="native-JdDMoB4966MyN7jrxdzJbYzgJ"

@calebmshafer - I finally figured it out - I needed the projects:read scope - so the minimum set of scopes for ui-test-app seems to be "openid profile organization email itwinjs offline_access projects:read"

@Mergifyio Update

@mergifyio update

Is this still required for 3.0 release candidate? Is something besides approvals blocking it? @calebmshafer

@pmconne yes, it is required and no just approvals at this point. Was about to bother @MichaelBelousov and/or @ColinKerr to give the final approval.


Using momentum and react instead of Blaze?

Is it possible to make this work as a pure react solution? I can convert most of the stuff but not sure how to get momentum to work in react instead of blaze.

momentum uses uihooks which are implemented in blaze. I don't know if these exist in react.

closing this. See explanation in #13 .


Ardent patch1 release

Summary of changes:

numerous changes to support Windows
fixed an issue with docking windows initially
added camera display
moved to ogre 1.10.11
(re)migrated TF display
fixed a potential memory leak
added image display
moved to assimp 4.1.0
moved point cloud displays to rviz_default_plugins

(updated changes):

fixed rendering of point clouds where valid points were not rendered
fixed a crash that occurred when removing a display
port polygon display
make rviz runnable with ros2 run
disable robot model until it is properly ported
various other fixes

It will affect API and ABI, but rviz is not considered stable in ardent.
Connects to ros2/ros2#454

#189 would also be important to be included into the patch release, since the PointCloud2 display is broken right now.

We're just updating our comments when something new comes up or we find a fix for any of the problems.

@wjwwood We've now done some extensive testing and these are all issues we found.
Please tell us which issues you think we should still try to fix or whether there is anything else, otherwise we're done.

Please tell us which issues you think we should still try to fix or whether there is anything else, otherwise we're done.

I think the plan is to move forward with the current state (sans anything still needing review from me).
Thanks for helping test it out!


Live Schedule Page

Live schedule page is ready and will be using a CloudKit container.
@imex94 can decide when to publish?


Remove EOL Release platforms Debian Jessie, Fedora 23 and 24

This is a follow on to https://github.com/ros-infrastructure/ros_buildfarm_config/pull/118
Holding until we've confirmed jessie is shutdown cleanly.

Since it's been close to a week and there's been no known issues I will merge this.

@tfoote Some jobs seem to not be disabled yet on build.ros.org - I noticed e.g. the PR job for Debian Jessie.

This change breaks rosdep for jessie:
$ rosdep resolve catkin

ERROR: No definition of [catkin] for OS [debian]

No definition of [catkin] for OS [debian]
        rosdep key : catkin
        OS name    : debian
        OS version : jessie
        Data: _is_ros: true
osx:
  homebrew:
    packages:
    - ros/kinetic/catkin
ubuntu:
  xenial:
    apt:
      packages:
      - ros-kinetic-catkin

Not sure if this was intended.

It's not directly intended but is actually basically correct. Since the rosdistro hasn't diverged much right now it would mostly keep working. However in general it should not be expected to keep working. New packages would incorrectly resolve etc. We likely should take a snapshot of the current state of the repository and export that as a jessie specific rosdep rules file that users can add to their rosdep sources.

We likely should take a snapshot of the current state of the repository and export that as a jessie specific rosdep rules file that users can add to their rosdep sources.

To keep the maintenance easy: perhaps just a jessie_eol tag and a sources list that references these EOL distros with a higher priority?
(Haven't had a look yet at how rosdep handles this internally..)

I just stumbled upon this because rosdep still works for hydro on 12.04. Users might be confused that rosdep update breaks their set-up on jessie.


Parts Unlimited Lab Missing TF Files

Hi,
I'm trying to complete the Azure Devops lab for automating infrastructure https://azuredevopslabs.com/labs/vstsextend/terraform/  ,but this lab is missing the terraform branch needed to complete it.

Hi, @lust4boost
Looks like you are having a different repository. Kindly try creating a new project - Terraform
This is how the repository and branches looks

Thanks!


Azure: Error 500 when trying to get https://slackinXXX.azurewebsites.net/favicon.ico

I freshly deployed. However, when opening the site in a browser, it immediately fails when trying to get the favicon.ico. Any idea?

Azure Application Logs say:
IIS received the request; however, an internal error occurred during the processing of the request. The root cause of this error depends on which module handles the request and what was happening in the worker process when this error occurred.

IIS was not able to access the web.config file for the Web site or application. This can occur if the NTFS permissions are set incorrectly.

However, that might be completely misleading. Further investigating the logs:
ActivityId="{B1867D46-783B-4621-A3A5-80ED62095B7A}", Message="iisnode was unable to establish named pipe connection to the node.exe process before the process terminated"

Please help!

I'm having same problem.
Fresh Deployment, home page just blank. And other pages give me Error 500.
using MS Azure too.

Had the same problem.
I used the deploy link https://deploy.azure.com/?repository=https://github.com/niftylettuce/slackin#/form/setup
and it works. The niftylettuce repo fixed the issue

Any solution for this besides doing a deploy link?  I have the same issue cant seem to figure it out.

https://deploy.azure.com/?repository=https://github.com/niftylettuce/slackin#/form/setup

Holle


Feature request: Possibility to access random pages via launchpad

Hello!
It would be really nice to have that feature.
Maybe by using some launchpad buttons combination and editing parameters via launchpad columns.
Thanks ;)

I should first invest some time on the generators before adding launchpad UI support for them. Adding this to the backlog.


Only suppress warnings in Vite dev mode and on client

We can't use this package unless this fix gets merged.
As I commented, suppressWarnings currently kills our node server, which is pretty wild, because it only gets "uninstrumented" on the client, so the console.warn call stack just grows and grows.
This is an improvement to the currently open PR #63.
The warnings are only logged in dev mode, so we can leave console.warn alone if we know that we're not in dev mode.
And we certainly don't want to touch globals in node/on the server.
I did my best to determine dev mode and client without assuming we're running in a Vite app.
If the code is not running in a Vite app, then we can't detect dev mode, so it will behave the same in the browser as it did before.
Except that I made the filter a bit smarter, so that it should only suppress warnings that are actually caused by markdown renderers.

@pablo-abc thank you for approving this but it looks like it still needs to be merged? Could you do that, or add someone else as maintainer? 🙏


Links to images being failed with html-has-lang and image-alt when scanning local files

Describe the bug
It seems like when you use the action to scan local files then links to image files are resulting in false positives.
My guess is that this could be because loading files from a directory does not provide MIME types like they would get if scanning over HTTP, or how the plain images are rendered by the browser.
To Reproduce

Given a page that has a link to a local image from another image (eg. like a thumbnail image that has a link that lets you load the full image
Run the scanner on the original page
Notice errors are returned for the URL to the image.

eg.
Calling the action in a workflow like this:
      - uses: actions/checkout@v2

      - uses: ./.github/actions/jekyll-build-pages
        with:
          verbose: false

      - run: |
          sudo find -type f ! -regex ".*\.\(html\|svg\|gif\|css\|jpg\|png\)" -delete
        name: Remove non-HTML

        # https://github.com/microsoft/accessibility-insights-action
      - name: Scan for accessibility issues
        uses: microsoft/accessibility-insights-action@v2
        with:
            repo-token: ${{ secrets.GITHUB_TOKEN }}
            site-dir: ${{ github.workspace }}/_site
            scan-timeout: 6000000
            max-urls: 1500
            localhost-port: 12345
            scan-url-relative-path: /

and there's one or more pages that render HTML like this:

Expected behavior
Non-HTML pages should not be scanned
Screenshots

Context (please complete the following information)

OS Name & Version: ubuntu-latest
AI-Action Version & Environment: v2

Are you willing to submit a PR?
Depends how easy it would be to fix

Hello! Thanks for reaching out. Would you be able to provide a bit more information about the structure of the pages where the images are displayed? From your example, it seems that you have some html pages which solely display a link to an image.  Your example was:

If this is all that's included on the page, you may be able to fix these issues by adding alt text to the thumbnail image and wherever you display the full one, and by ensuring that you have set the language attribute at the top of the page. If I've misunderstood the setup of your html, please feel free to correct me and we can dig deeper into this issue.

Hi @jlperkins, the original page does contain more HTML than that, and it does include alt text.
For example, the first URL flagged in the screenshot above is a URL for an image linked to on this page - https://david.gardiner.net.au/2015/01/2014-in-review.html
eg. this bit:

And as I understand it, it isn't https://david.gardiner.net.au/2015/01/2014-in-review.html which is being flagged, rather it is https://david.gardiner.net.au/assets/2015/01/wp_20150102_001[4].jpg (the direct URL to the image, not a HTML page at all).
If I load https://david.gardiner.net.au/assets/2015/01/wp_20150102_001[4].jpg a browser, and then press F12, can see what I assume is the browser's internal way of rendering an image file. eg.

The HTML I can see there looks pretty much the same as what is being flagged by the action.

To be clear, this is nothing to do with my content. This will be true for any image URL. eg. you can see the same thing for this image (currently linked to from www.microsoft.com)

The Accessibility Insights team understands the problem you are experiencing, we are investigating next steps on how to handle these cases where the scanner is scanning some files (non-html) it perhaps should not.

Thank you for following up! I hadn't understood your situation correctly but that makes sense--we don't intend for our accessibility rules to be run against any pages besides HTML. We will investigate further how we will best exclude those pages. Thank you for bringing this to our attention.

Hi @flcdrg - I took a closer look this week and was hoping you can help. I made this demo repository using the latest action release (v3). I'm unable to reproduce accessibility errors on the image URL itself, only on the home index.html page.
Do you have a link handy to your repository or a modified version of my demo that fails? That would help me debug further. So far I'm seeing valid MIME types when I use the GitHub action to host the website. Thanks!

Let me take another look and see if I can still reproduce it.


v28.2

We'll need this to match our current pinning; also, I think it should be fine to delete the tests folder from https://github.com/protocolbuffers/protobuf/tree/main/bazel

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.


Manually clearing the cache for a model

I was wondering if there is a way to clear the cache for a specific model, or with a certain path prefix?
We have models that are queried and cached, but can be updated en-masse, using the class update, increment, decrement, and Sequelize query methods. As such, the values in the cache will need to be cleared on these occurrences. Is there a way to do this through this library, or will I need to go directly to redis and do it manually?

Hi!
I think this is a valid use case, not yet supported. You are more than welcome to contribute this functionality ;)

Hi! It's not that easy to delete the set of values in most of cache systems, see discussion in here:
https://github.com/DanielHreben/sequelize-transparent-cache/issues/48
If you need to do that, you probably using cache in a wrong way.
Maybe you could just use short TTL's?

The way I'm currently using it is that I have a model that is 1 to 1 with users, but not primary keyed by the user ID.
The controller that retrieves that model for a user uses a manual cache key based on the User ID.
However certain infrequent operations will edit many instances of that model, and so the cache for all of those will need to be cleared. I suppose it's possible to clear each one individually by finding what user IDs were effected with an extra query and calling Model.cache(userId).clear() for each userId.
Currently, I go straight to the redis adapter to clear using this function
const clearCache = (pattern) => new Promise((resolve, reject) => {
  var stream = redis.scanStream({
    match: pattern
  });

  const clearer = function (keys) {
    try {
      if (keys.length) {
        var pipeline = redis.pipeline();
        keys.forEach(function (key) {
          pipeline.del(key);
        });
        pipeline.exec(function(err, results) {
          resolve();
        });
      } else {
        resolve();
      }
    } catch (e) {
      reject(e);
    }
  };

  const ender = () => {
    stream.off('data', clearer);
    stream.off('end', ender)
  }

  stream.on('data', clearer);
  stream.on('end', ender);
})

But seemingly, according to the linked issue, this may not be a good idea


CheckReturnValue annotation on *Assert objects

A common mistake programmers make when using assertj is to create an assertion object but forget to call any methods on it (e.g. assertThat(obj); vs. assertThat(obj).isTrue();).
By adding the@CheckReturnValue annotation to public static *Assert assertThat(*) methods, static analysis tools will warn when programmers forget to call any methods on the returned assertion object.

Good idea, addresses https://github.com/joel-costigliola/assertj-core/issues/157.
Will have a look at it soon.

One blocking problem : the dependency on com.google.code.findbugs annotations, by design assertj does not depend on anything to avoid dependency version constraints for users.
Is there another way of solving this issue ?

I'm closing this PR as assertj-core does not ship with dependencies.

I think you can use the maven shade plugin to avoid depending on an external library?
From what I saw, error-prone checks the annotation's class simple name and ignores the package. So this should work.
Am I right @cushon?
Would that work for you @joel-costigliola?

@JnRouvignac I believe this has been addressed by https://github.com/joel-costigliola/assertj-core/pull/695 as findbug detects any CheckReturnValue annotations.

Great! I had not seen this.
@sul3n3t I guess you may give it a try!


Created a file of FED IT

Its the FED ID for Wise

this file is not related to code, not accepting pull reques


Implement Word Input Component

Design file:
https://xd.adobe.com/embed/66ee6520-e5f3-46a8-916e-b1c6fac69c1e-33bd/screen/909625fc-a5da-4db0-ae94-ed62394a21eb/?fullscreen
Requirements:
Negative words

Static array of negative words (or get values from internet json file)
For example
Should affect styling of detected words on user input

Input

User can input maximum of 50 characters

Header

Display inputted text styled as per design
Should only be updated if play button is pressed
Should only be shown if visible
Show negative words with different style

Words separated as tags

Display inputted text styled as per design
Updated when text is inserted
Show negative words with different style
Space does not show as a tag

Play -button

Pressing play button should update header
Should be disabled when no input is given
Uses icon update-text.svg

Progress bar

Fill progress bar depending on number of characters used
Bar color depends on how much of the bar is filled
Green if less than 50%
Yellow if less than 80%
Otherwise red
If input includes any negative words then progress bar color should always be red
Should be animated

Header toggle -button

Toggle visibility of the header text
Uses icon show-text.svg
Styled as per design

Reset -button

Reset all variables and the input to default
Uses icon reset-ui.svg
Styled as per design

This task must be started by checking out the branch subfeature-input to your local machine
Origin branch feature-input must be merged to local checked out branch subfeature-input
Conflicts from the merge must be resolved in a sensible matter


Storage check -- can it be removed?

https://github.com/caddyserver/certmagic/blob/76f61c2947a20d86ca37669dbdc0ed7a96fc6c5f/config.go#L456-L461
Depending on the storage this check can be quite expensive (in our case a remote KV store), and it happens in a rather "hot" area: Right when setting up a TLS connection. If we need to get a certificate from a CA this doesn't matter too much in the grand scheme of things, but if our storage has one we triple our roundtrips (1 to get the cert information from storage, and 2 for a write/read from storage to check it).
I think this check might have some value, but not here:

If the storage is generally trustworthy, it should be checked before it gets configured for certmagic
If the storage is generally untrustworthy and needs regular checks, it should be part of that specific storage

So, I'd propose to just drop these lines here, and possibly move the implementation of checkStorage as an example into documentation. WDYT?

I'm open to optimizations, but first:
It should only do the check if a certificate is needed, which should only be "hot" once every 60 days or so -- and even that runs in the background except the very first time. Shouldn't be blocking a TLS handshake after the first time it gets a certificate.
What kinds of performance impacts are you experiencing? How have you verified that the storage checks are causing performance problems?

When the server using on-demand TLS with certmagic starts up, its in-memory caches are empty, and that's what I'm trying to optimize right now. Our Storage is using AWS DynamoDB (based on https://github.com/silinternational/certmagic-storage-dynamodb), and as much that scales, it does see quite some load I'd like to get rid off.
But, you're right indeed ... before it would do the storage check, obtainCert first checks with storageHasCertResourcesAnyIssuer for any existing resources. This call should return true (our implementation of Exists internally does a Load and checks for whether that worked), and following the code from there I think it will pick up the certs through an actual Storage.Load in Config.CacheManagedCertificate/Config.loadManagedCertificate.
Leaves me still with some not-so-nice performance if the above is true: I should end up with 3 distinct read requests in storageHasCertResourcesAnyIssuer, and another 3 in loadManagedCertificate. I'll have to measure this more closely to confirm this theory. Ideally I'd like this number to be 1, of course :)
I guess I could get there by
a) Have a tiny internal cache with a short expiration for Load, so that the second load just grabs from that cache rather than roundtrip
b) recognize the storageHasCertResourcesAnyIssuer and pre-load all keys into that cache (in DynamoDB through BatchGetItem or possibly by using a smart query/index operation)
It also IMHO still leaves the question open whether the storage check would not be better in the storage itself, so that an implementation could decide how to check?

The point of the storage check is to ensure the storage is properly configured, it's not really dependent upon how "trustworthy" the storage mechanism is.
It's tempting to say that just the file system needs such a check to ensure there's enough disk space, but actually most problems I've heard of in production stem from getting its CertMagic config wrong, or the actual storage system itself is misconfigured.
Maybe we could make storage checks optional, but disabling them poses a risk too.
(I suppose ideally we'd optimize them. I have a TODO that they don't need to happen so frequently, but haven't gotten around to implementing that. Even if it's just a simple memory of last time the storage was checked.)

What about sth like this:
diff --git a/config.go b/config.go
index ed155d5..266415d 100644
--- a/config.go
+++ b/config.go
@@ -976,11 +976,19 @@ func (cfg *Config) getChallengeInfo(ctx context.Context, identifier string) (Cha
 	return Challenge{Challenge: chalInfo}, true, nil
 }

-// checkStorage tests the storage by writing random bytes
-// to a random key, and then loading those bytes and
+// checkStorage tests the storage
+//
+// If the storage implements `StorageChecker` its StorageChecker.Check
+// method will be called, otherwise the storage is checked by writing
+// random bytes to a random key, and then loading those bytes and
 // comparing the loaded value. If this fails, the provided
 // cfg.Storage mechanism should not be used.
 func (cfg *Config) checkStorage(ctx context.Context) error {
+	if sc, ok := cfg.Storage.(StorageChecker); ok {
+		// Storage knows how to check itself, so let it do that.
+		return sc.Check(ctx)
+	}
+
 	key := fmt.Sprintf("rw_test_%d", weakrand.Int())
 	contents := make([]byte, 1024*10) // size sufficient for one or two ACME resources
 	_, err := weakrand.Read(contents)
diff --git a/storage.go b/storage.go
index 0bb34cd..4fc0cfe 100644
--- a/storage.go
+++ b/storage.go
@@ -81,6 +81,12 @@ type Storage interface {
 	Stat(ctx context.Context, key string) (KeyInfo, error)
 }

+type StorageChecker interface {
+	// Check returns whether the storage is "good to go" or
+	// whether it cannot be used right now
+	Check(ctx context.Context) error
+}
+
 // Locker facilitates synchronization across machines and networks.
 // It essentially provides a distributed named-mutex service so
 // that multiple consumers can coordinate tasks and share resources.

For me it would allow me to implement the Check method (for instance by only checking once), for existing code nothing would change, and other more advanced storages could indeed implement some "once in while" behavior without needing a change in certmagic itself?

Maybe, I still feel like storage problems are more related to configuration than actual implementation (usually -- assuming a proper implementation and a capable storage backend).
I feel like a switch on or off in the config is probably a better solution to this. Would that be OK with you?

I feel like a switch on or off in the config is probably a better solution to this. Would that be OK with you?

Sure, that would work for us! Shall I make a PR to that effect?

@ankon Sorry for my delayed reply. Yes, I'd be happy to review that. Probably have the checks enabled by default, with the option to disable them.

@mbardelmeijer That's good to know. But be aware that S3 is not safe to use as a storage backend by itself, since it cannot support atomic operations.

@mbardelmeijer @ankon I've implemented this in 5357574. Please feel free to try it out!

Thanks a lot!
We just rolled this out for a spin, and according to our database statistics this looks great -- no more rw_test_ keys in the "top contributors" diagrams at all. We're going to leave it running for a while now, and see whether overall statistics also show improvements.

Awesome, thanks for giving it a spin!


adding check for imageURL length

Issue #, if available:
Description of changes:
Assigning imgUrlLength to 0 in case image URL is not provided in the Response card.
Fixes : https://github.com/aws-solutions/qnabot-on-aws/issues/492
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rstrahan @greengangsta The changes look good to me as well. Once they are merged into the develop branch I can pull and test against my dev site.

Hi @greengangsta, FYI, I have changed the branch base for your PR to the develop branch. Typically, we merge code to develop branch first, and later to main branch after testing.
Thanks!.


[GLCC] GitLink Code Camp, Support C# Server SDK

The issue is about the GitLink Code Camp activity.
Requirement
We need a server-side C# SDK, which can work as other FeatureProbe server side SDKs, take Java SDK for example.
You need to be familiar with C#, have knowledge of network and multi-thread programming in C#.
Expectation
The C# SDK should work as Java SDK, including Targeting calculation and metrics report, and should pass all the acceptance tests including performance test.
Contact
@dengfeige
email<EMAIL_ADDRESS>

I have interesting in this issue， and I will send a proposal in the next week.


ec2 network-interfaces support

Title: Import ec2 network interfaces
Description:
Import all EC2 Network Interfaces, so that ELB IPs can be identified from the database
Import the output of ec2 describe-network-interfaces call.
I assume everything is there the only new relation which will come in will be
(LoadBalancer|LoadBalancerV2)-[NETWORK_INTERFACE]->(NetworkInterface)

I implemented this iin https://github.com/krisek/cartography/tree/%23407-ec2security-group-fix, there are some things to align.

I had to create a new node for the IP addresses --- one network interface can have several IP addresses, these are not 'public' AWS objects, but still I couldn't come to a better solution to put them in the database. Actually it is not so bad (*)... this way we can query IP addresses directly. The respective relation looks like this:
(NetworkInterface)-[:PRIVATE_IP_ADDRESS]->(EC2PrivateIp)

As the NetworkInterface data model consist of a lot of optional elements (Attachment, Association, PublicIp) I implmeneted a filter cycle that extracts the relevant records from the overall NetworkInterfaces data structure. Is this OK? Maybe I can recfactor it to be more elegant -- I'm not 100% sure how missing attributes in input data are handled by Neo4j.

I still need to write the schema update and the tests, so this is the right point to change anything if required.
(*) It is actually very bad: the cloud/SDN is about to get rid of IP dependencies, and what am I doing here: I keep track of IP addresses --- on the other hand environments needs to be managed and people seem liking IP addresses :smile:.

I think we can use multiple labels:
Use the :EC2PrivateIp label and also add the more generic :Ip label (kinda like how we have :Instance:EC2Instance and :Instance:GCPInstance).
What do you think?

the cloud/SDN is about to get rid of IP dependencies, and what am I doing here: I keep track of IP addresses

Ha, I feel like having viz on IPs will always be important regardless of the abstractions eventually used by SDN; we'll see.

Use the :EC2PrivateIp label and also add the more generic :Ip label

Agreed, implemented with 9f3a00
I've started working on the test cases, then schema update and the PR comes.

Use the :EC2PrivateIp label and also add the more generic :Ip label

Agreed, implemented with 9f3a00

As I update the documentation it became appearent that the Ip node is not appropriate here, as the id of an Ip node is the ip address: this doesn't work in AWS (and actually I doubt it works anywhere) as an IP is always in context with an interface. Duplicate ips in an environment would be abstracted as single nodes which doesn't work.
I revert now the change and we align later if this needs to be resolved (ever).


Can't hide navigation bar vs22

Describe the bug
Seems like I can't hide the navigation bar while a .py file is open in vs2022, work fine in vs2019
Steps to Reproduce

Open a .py file in vs2022
Uncheck the Navigation bar option from the options window and click OK
See how the navigation bar is still there

Expected behavior
The navigation bar disabling option work like in python (vs2019) or c++  (vs2022)
Additional context and screenshots

The code that shows/hides navigation bar was deleted when integrating the new language server client. Maybe the .py file isn't registered as a "Python" file on the VS side, so the python options page doesn't apply, similar to the cause of issue #6784

LSPClient people said that they don't support dynamically disabling it during an LSP session. But if we have access to the option on startup, we can set DocumentSymbolProvider in server capabilities to false and that should prevent the navbar from being created.


GH-36760: [Go] Add Avro OCF reader

Rationale for this change

What changes are included in this PR?
Avro reader

Are these changes tested?
Local integration tests, no unit tests yet.

Are there any user-facing changes?
New Avro reader API

Closes: #36760

I've resynced my branch and removed the memfile caching in the example avro2parquet program to avoid adding a non-essential package import.
Are there any other issues that need to be addressed?

@loicalleyne looks like you need to rebase and update the go.mod (run go mod tidy?)

Static check was failing because error variable name did not conform to ErrFoo.
Renamed NullStructData to ErrNullStructData.

Now the builds are failing because of the bug in SchemaEqual(). Can I remove that test until we figure out what's wrong with that function? The test that compares the schema string representation is passing.

@loicalleyne I'd say sure you can remove that test until we figure out the issue there as I'd wager it's not related to this change at all and should be addressed separately. Could you try creating a reproducer of that failure separate from these changes and file a separate issue?

Gotta fix for 32-bit builds:


it worked for the wrong code

Challenge http://www.freecodecamp.com/challenges/waypoint-give-your-javascript-slot-machine-some-stylish-images has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

@Wrapmeh thanks for posting this issue!
Note that your issue is a duplicate of https://github.com/FreeCodeCamp/FreeCodeCamp/issues/2111 so I'll close it. You can continue further discussion there.
And, please, provide the description of your issue next time, thanks!.

Please review the Guidelines for Contributing, thank you!.


tcn update

afaik, "PanelPlanesFighter" do not include bombers with Anti-Air value (like Zero Fighter Model 62), so it can't be translate as "plane that can join the anti-air stage", imo.