feat(PrimitiveArray): Add minItems functionality to array rendering

Add minItems functionality to array rendering

Will be revisiting this, but closing for now.


Support for base & sealed classes

Environment

Nuget Package: JsonSchema.Net.Generation
Nuget Version: 1.5.0

Can this library make doing something simpler?

Refactoring base class requirements into an allOf.
Sealed classes would add an additionalProperties: false

I can see going down a deep rabbit hole here, so I want to work out some rules first.

This should be behind an option.  There no reason to make schemas unnecessarily complex.
This should include interfaces.
Inherited types should only receive a schema if they define properties.  Otherwise they should be ignored.

For example, System.Int32 implement five interfaces.  But all of them only define methods, so they'd end up with empty object schemas.

Each type should have a schema independent from annotations.  If there is only a single reference to that type it can be collapsed to the reference.


Python 3.6.5 OpenBabel build fails due to test fails

157/160 Test #157: pytest_pdbformat .................***Failed    0.03 sec
        Start 158: pybindtest_bindings
158/160 Test #158: pybindtest_bindings ..............***Failed  Error regular expression found in output. Regex=[FAIL]  0.23 sec
        Start 159: pybindtest__pybel
159/160 Test #159: pybindtest__pybel ................***Failed    0.11 sec
        Start 160: pybindtest_example
160/160 Test #160: pybindtest_example ...............***Failed  Error regular expression found in output. Regex=[FAIL]  0.10 sec

98% tests passed, 4 tests failed out of 160

Total Test time (real) =  35.07 sec

The following tests FAILED:
        157 - pytest_pdbformat (Failed)
        158 - pybindtest_bindings (Failed)
        159 - pybindtest__pybel (Failed)
        160 - pybindtest_example (Failed)
Errors while running CTest
Makefile:127: recipe for target 'test' failed
make: *** [test] Error 8
The command '/bin/sh -c make test' returned a non-zero code: 2

Seems like these tests are failing for two reasons:
i) tab characters in test/testpdbformat.py, which lead to an error with Python 3.6
ii) broken import DLFCN in scripts/python/openbabel.py, because DLFCN was merged into the os module in Python 3.x
Both problems are fixed with the patch in https://github.com/easybuilders/easybuild-easyconfigs/pull/7614/files#diff-f07033ab146a0de07881b78c27e94845

Hi Harry,
I am trying to build this on a python 3.x version. I copied verbatim but I am getting and import error about DLFCN not found. I found this site:
https://bugs.archlinux.org/task/52409 [bugs.archlinux.org]
It builds/tests fine but when I run my code it gives me the import error. If this patch fixes it, how can I implement it? It seems that the newest version of open babel should have already taken care of this fix? I have been trying different things for several hours now and can’t get anywhere. I’m new to docker.
Would you be so kind to provide some assistance? Thanks so much.
Best regards,
Spencer

Hi @trinhsk,
It looks like there hasn't been a stable OpenBabel release version covering this fix (the stable version remains the same as in the Dockerfile).
One option to try is changing the Dockerfile  to clone the latest development version of OpenBabel and build in there (as per http://openbabel.org/wiki/Git), rather than wgetting the stable release. Then build the image with docker build and see if that version fixes it.

I was having the same problem. I solved it by simply deactivating the conda environment I was in.
conda deactivate
Then try again.


chore: promisify events

Let me know what you think?
I think the next step would be to define events, so we don't use any.

I am revisiting to make work after the first time

@jrainville @PascalPrecht @michaelsbradleyjr thx for your feedback, I just made a new push,
This is not the final version but I feel I am getting closer and If you could give feedback again that would be great.
Thx

Nice work!  Can you explain how the next, error, and complete methods come into play?

@alaibe As discussed in our one on one chat, here are some further thoughts on designing this API:
The eventbus takes care of a couple of things

Emitting events
Listening/Subscribing to events
Registering command handlers
Requesting and subscribing to commands

Currently, the equivalents of those are

embark.events.emit(name: string)
embark.events.on(name: string, cb: fn)
embark.events.setCommandHandler(name: string, handler: fn)
embark.events.request(name: string)

The goal is to come up with an eventbus API that is:

Typesafe
Based on Observables

API Design Proposal
abstract class Event {
  type: string;
}

abstract class EventWithPayload<T> extends Event {

  public readonly payload: T;

  constructor(payload: T) {
    this.super();
    this.payload = payload;
  }
}

export class DeployContractsEvent extends EventWithPayLoad<Contract> {
  static readonly type = "DeployContractsEvent"
}

emit(new ContractsDeployedEvent(contract: Contract));
observe(ContractsDeployedEvent).subscribe(deployed => {...});

// this actually only has to be a function that returns an observable
setCommandHandler(DeployContractsEvent, handler)
requestCommand(new DeployContractsEvent(contract: Contract)).subscribe(deployed => {...});

As you can see, setCommandHandler actually doesn't need to return an observable. We can simply register handlers that do return an observable. Once somebody requestCommand(), we basically pipe through the returned observable of the requested event, with the payload type being attached to the event type.

@PascalPrecht I can see that our thinking got us to more or less the same direction. My only doubt is on the setCommandHandler.
IMO the handler should be more dynamic and you should be able to do:
observe(ContractsDeployedEvent).subscribe(payload => handler(payload));

Also one problem we haven't solve yet, is how to return values, and avoid the payload to have a function.
To your knowledge, is it possible with subscribe?

IMO the handler should be more dynamic and you should be able to do:

I'm not sure I follow. The code snippet above was actually doing exactly that:
observe(ContractsDeployedEvent).subscribe(deployed => {...});

That however, is unrelated to setCommandHandler().
observe() is more the equivalent to on()
So assuming that ContractsDeployedEvent can be emitted multiple times, one could do:
eventbus.observe(ContractsDeployedEvent).pipe(
  filter(deployed => !!deployed)
).subscribe(_ => console.log('yay'));

PR updated (again), let me know what you think.
I haven't done: Also one problem we haven't solve yet, is how to return values, and avoid the payload to have a function.
As I feel we should not use event for that but a state

can you explain a bit more?

I'd be interested in that as well. If we implement the eventbus the way I've proposed it actually never stores state, but only pipes it through. As a matter of fact, with observable APIs you can get very far without the need of anything like state pattern.

But is it also intended as a global state manager among various modules running concurrently in an embark process?

As mentioned above, it's actually not keeping state. State stays in the dedicated services. Eventbus only propagates state.

If it is headed toward a global state manager and we're set on using Rx, I wonder if it would make sense to build our bus on top of a well thought out design like redux-observable?

Yea I think this is not the case here, but happy to discuss this.

Hey, thx for making this PR very active, I love the thinking.

can you explain a bit more?

About redux. The way I can imagine this beast to work is by using CQRS (also rebranded FLUX and implemented by redux). In this PR I am taking care only of the command part.
In order to do the Query, you need a state and selector. IMO the state should be module based, for example the state for the scaffold module is quite simple and is only a list of files as it is today.
So instead of re-implementing it totally and probably introducing bugs, why not just reuse what is already there.

About redux-observable

It is only for effects, most of what we are doing in embark as of today don't need effects, but that could make it only more powerful, so why not. My feeling is that the need for embark today is simply redux, not saga nor observable. It is because we don't do cancelation or error handler very well, indeed those feature would be interesting to have.

. If we implement the event-bus the way I've proposed it actually never stores state

My knowledge being limited I might see things wrong, however if we have to propagate event back from the module to, let's say the controller, I feel it is an anti-pattern. Example of bad flow IMO:
controller: listen scaffold files generated
scaffold: listen generate
controller: emit scaffold generate
scaffold: do the generation
scaffold: emit files generated
controller: do work once files generated
You can see we are always going to have this back and forth and will likely cause spaghetti relationships. However I might be wrong and would love to hear it :)

My knowledge being limited I might see things wrong, however if we have to propagate event back from the module to, let's say the controller, I feel it is an anti-pattern. Example of bad flow IMO:

So I actually believe, that in most of the cases, we'll get away with

Controller requests action and receives response

Pretty much like what we're doing already, just with observable APIs. So instead of listening to a certain event and have the module that causes that event emit that event, we just keep "requesting".
So we actually do very little listening and emitting.

Controller requests action and receives response

This is the part I am not sure on how to do it. For example how would you replace the callback function with the list of files in this PR to get a reply.
Feel free to add a commit to the PR or write pseudo code and I will try it.


Responsive style issue in project admin view

Describe the bug
The content header in the project admin container (e.g. team, list or ontology view) is not responsive enough and the tab bar (main project header) disappears on mobile phones.
To Reproduce
Activate the device toolbar in Chrome developer tools, go to project team administration (e.g. http://localhost:4200/project/0001/collaboration) and play around with the various views.
Expected behavior

Margin (or separate line) between content header elements: Content-title, Select from list, "Create new"-button
Keep tab bar activated (if possible on smarthpones; otherwise activate navigation menu).

Screenshots
iPad portrait mode

iPhone portrait mode; no tab bar anymore

this issue has been moved to YouTrack: DSP-375


Problem with plasmid_contigs.fasta

The contigs are not complete

I added seqtk to get the fasta and I wanted the file name in the contigs. So add these things in the write_plasmid_contigs.sh
for contig in $plasmid_contigs; do
        echo $contig >> $out_dir/contig.txt
        #grep -A 1 $contig $input >> $out_dir/plasmid_contigs.fasta
done

TAG="$(basename $input .fasta)"
seqtk subseq $input $out_dir/contig.txt >> $out_dir/"${TAG}"_plasmids.fasta
sed -i "s/^>/>${TAG}_/" $out_dir/"${TAG}"_plasmids.fasta

Because the -A 1 in grep does grep only subsequent line after the header.
-A, --after-context=NUM   print NUM lines of trailing context

The contigs from spades are never in a single line.

Hi Varun,
I had indeed not realised that this script doesn't work for contigs spanning multiple lines, thanks for notifying!
It has been adjusted now (584750d9625a7f78457c301744e1d22982041daa)

Thank you for the updates.
I just wanted to check what are your thoughts on running the tool for multiple samples? And combining the results together?

Actually, in a previous version of the tool a directory was used as input, and plasmidEC would output the combined result for all files in this directory. However, I changed this to a one file in --> one file out approach, so that the tool can be more easily integrated in pipelines (e.g. Snakemake) and users can run multiple jobs in parallel, using whatever job scheduler they like. So more possibilities for costumisation, with the cost that you'll have concatenate the results of multiple samples yourself.


Excluding tools/launcher test on OpenJ9

This PR fixes runtimes/openj9-openjdk-jdk11-zos/issues/652.
Signed-off-by: Pasam Soujanya<EMAIL_ADDRESS>

FYI @JasonFengJ9

This test passes in other platforms, can it be limited on JDK11 zOS only?

Updated exclude list as per https://github.com/adoptium/aqa-tests/pull/2648#issuecomment-861835475. Removed this exclusion from other releases and limited only to JDK11 z/OS. Thank you.

@Mesbah-Alam Could you please review the PR. Thanks.


🐛 [fireflyiii] Error 500, Firefly III broke

Which addon?

Addon name : Firefly III
Addon version : 5.7.17

Describe the bug

Since the installation of Firefly III in HomeAssistant more and more sites become unavailable with the Error-Code 500 in the header and the info Firefly broke. At first only some edit-pages for Bank-Accounts didnt work, but now i have even no access to the Piggy-Bank-Site. The Error was also present in Version 5.7.16

To Reproduce

Go to the Firefly III Website.
Browse the site.
Some sites (edit-pages and Piggy-Bank for me) gives an Error-Code 500.

Full addon log

Docker Log: https://pastebin.com/5YeFzsbD
Firefly Debug Page: https://pastebin.com/xWD8Ca7B

Full addon config
https://pastebin.com/WCF3R7KK
System

Supervisor version: Supervisor 2022.12.1
Host system version: Home Assistant 2022.12.8
Operating System: 9.4
Frontend: 20221213.1 - latest

same here, 5.7.17

Hi, I think it's this issue in the upstream app : https://github.com/firefly-iii/firefly-iii/issues/6787

Hi, i think i found a workaround.
I changed the database to mariadb and its working for me now.
Unfortunately i didnt know how to move my data to the new db, so i had to start from scratch.

Hi, strange! It would mean it's specific to sqlite... Well anyway in the long run Mariab is much more stable for large database. Beware of backups though : you need to backup the Mariadb addon, and it's preferable to stop the Addon before
performing the backup

Thanks for the info! I had to restore HomeAssistant from a backup today because i played a little with my network and couldnt reach it! Luckily Firefly and everything else still works fine.

I use this mighty app for automation : https://github.com/sabeechen/hassio-google-drive-backup which allows stopping addons before backups

Then I used the right app for my backups ;) I use this add-on since my first installation.

This has been fixed in version 5.7.18 from around three days ago, is it possible to update the addon to the latest upstream?

Hi, automated updates are on Saturday morning, it should be good tomorrow


Change message order not possible

if st.session_state['generated']:
    for i in range(len(st.session_state['generated'])-1, -1, 1):
        message(st.session_state['past'][i], is_user=True, key=str(i) + '_user', avatar_style='personas')
        message(st.session_state['generated'][i], key=str(i), avatar_style='identicon')

Using a positive step in the messages should be possible. However, it stays one behind if using a positive step (1),
The library seems to only work if step on the for loop is set to -1.

Sorry I didn't get what you mean, if you mean the step value in the range(), then it has nothing to do with this library, streamlit-chat is just a UI component, you might want to look at how the data is stored in the session_state


Example for how to change imagery set used by Bing

Adds an example for how to change the imagery set used by Bing and a short description.

Thx for that :)


Split out the compiler crate

Many users will likely only be interested in the snarkvm-compiler crate, so it makes sense to isolate it.
An alternative would be to introduce a compiler feature for snarkvm (in a fashion similar to the other features that are currently there), but it results in a much larger lockfile (in an empty project using just that dependency): 2561, compared to 1548 when importing an isolated snarkvm-compiler crate.
In addition, the dev-dependencies of snarkvm-parameters are also made more granular, making its compilation faster.

The CI failures are unrelated.
Cc https://github.com/AleoHQ/snarkVM/pull/1092 for the clippy one.

@ljedrz let's wait on this PR until #1100 is merged, which introduces time-sensitive changes for snarkVM

Sounds good; it's simple enough to redo 👌

Once #1100 is merged, let's move to the testnet3.2 branch and pursue the approach in #1165.

Done in https://github.com/AleoHQ/snarkVM/pull/1201.


[ FEAT ] Add support for terminal variables

Shell Parameter Expansion is a very useful feature available on operating systems terminals.
They allow you to define system variables, so, it becomes easy to use terminal.
For example,
SELECT NAME FROM $HOME

It's much easier than write
SELECT NAME FROM /home/my_user

We can get the environment variable from this lib call.
In windows, we can have something like this

We could create a standard ...
For example: $VAR_NAME.
Example:
SELECT NAME FROM $HOME

Where $HOME is a terminal/environment variable.
At the source code, we would need to remove the $, then, the name would be only: HOME.  Then, in linux, we would call this library function. In Windows, we would use this
Example: Linux:
#include <stdlib.h>  // for getenv
#include <stdio.h>   // fot printf

int main (int argc, char *argv[]) {

  if (argc == 1) {
     fprintf(stderr, "Usage: %s <VAR_NAME> ...\n", argv[0]);
     return 0;
  }
  for(int index = 1; index < argc; index++) {
     if ( argv[index][0] != '$' ) fprintf(stderr, "Variable name should start with: \"$\"! Value provided: %s\n", argv[index] );
     // Pass only the value. Without the $ character
     char *variable = argv[index]+1;
     char *var_result = getenv(variable);
     if (!var_result) {
         fprintf(stderr, "Variable value not found for: %s.\n", variable);
         continue;
     }
     printf("Variable: %s, Value: %s", variable, var_result);
  }
   return 0;
}

Tried to use getenv on Windows, but, Windwos says that this function is unsafe, and, should not be used ...
Compiler message:

D:\a\Termsequel\Termsequel\src\system.cpp(822,30): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.

So, we maybe use the "secure" version of getenv, or, as the compiler suggests ...

At the Windows example of getenv_s, they call two times the library ... The first one to get the size ... And, the second to get the value ...
This is the code of the example:
   char* libvar;
   size_t requiredSize;

   getenv_s( &requiredSize, NULL, 0, "LIB");
   if (requiredSize == 0)
   {
      printf("LIB doesn't exist!\n");
      exit(1);
   }

   libvar = (char*) malloc(requiredSize * sizeof(char));
   if (!libvar)
   {
      printf("Failed to allocate memory!\n");
      exit(1);
   }

   // Get the value of the LIB environment variable.
   getenv_s( &requiredSize, libvar, requiredSize, "LIB" );
 ...
}


Various of warnings on install, run, and deploy

When I last cleared my local Github clone of this repo, cloned from https://github.com/Kong/docs.konghq.com, and followed the README steps to install, run, and deploy, everything worked smoothly - that was a few days ago.
Today, when I did the same thing, I got lots of errors and warnings that ended up requiring I do the steps with sudo - and while that made them work, I still got many more errors and warnings in the terminal than I'd previously seen.
The experience of cloning and running the Docs site should be smooth and friendly for everyone. Errors and warnings, and use of sudo, should be avoided.
Steps To Reproduce

Start with a local environment with no clone of this repo
Clone this repo locally
Follow the README instructions to install and run the docs site - note the errors and warnings you see in the terminal, and note how you may need to use sudo when running some commands.

I'm no longer getting these warnings.


In in SignIn is truncated from command names

Given an operationId of reports_ListApplicationSignInDetailedSummary, AutoREST.PowerShell currently generates a command name of Get-ReportApplicationSign instead of Get-ReportApplicationSignInDetailedSummary. It looks like AutoREST.PowerShell treats the In in SignIn as a preposition thus truncating everything after the preposition in: https://github.com/Azure/autorest.powershell/blob/8baf63ed52e31aa70d91708832c2b3a3e290dbb6/powershell/plugins/create-commands-v2.ts#L80-L89.
Possible Solutions

Exclude compound words such as SignIn and SignOut from being broken into two distinct words.
Provide a configuration that customers can use to bypass the truncation of prepositions if they desire. Certain APIs use prepositions in their paths to communicate meaning. e.g., https://graph.microsoft.com/v1.0/users/{id}/memberOf.

Workaround
We can use rename directive to target the affected command variants and rename them to the proper name as a workaround. While this works well when targeting a handful of commands, it doesn't scale when the directive needs to be applied to hundreds of APIs/commands since we need to know ahead of time which command variants are affected.

@dolauli , please look into it and fix it as soon as possible.


HTTP/2 API POC

Motivation
Netty 4 HTTP/2 APIs have organically grown over time and has the following notable shortcomings:

Two distinct API approaches (Connection API and child channel API) causes confusion for users.
Few extension points like flow control handling is only available through the connection API hence forcing child channel API users to also know about the connection API.

In addition, over time we have got the following additional insights:

Our experience implementing HTTP/3 provided us with more insights into how these APIs can be layered such that usage and maintenance becomes easier.
In some cases we experienced that child channel API has performance overhead of creating a channel per stream.
Control frames for a stream do not always flow on the stream, making it harder to analyze activity on the stream. eg: WINDOW_UPDATE for a stream is written directly on the parent channel.
Per stream state is split between parent and child channel as the frame codec is present on the parent channel, even when using child channels.
Some of the auto-magical details like close and go_away coupling is not ideal for higher level frameworks where more control is required and hence such features may be opt-in rather than opt-out.

Goals

Propose a single API that uses a channel per stream and the parent channel only acts as the physical socket for I/O.
Experiment on reducing “channel per stream” performance overhead.

Non Goals

Backward compatibility with Netty 4.1 HTTP/2 APIs.

Control flow overview

Notable API changes
SSL Context
This proposal introduces two new abstractions to create SSLConext instances for client and servers; Http2ClientSslContextBuilder and Http2ServerSslContextBuilder. Apart from encapsulating the ALPN configuration, it provides a way for server to specify HTTP/1.x support (via ALPN).
Http2Channel
A new Http2Channel interface is introduced by this proposal. Apart from extending Netty’s Channel it provides methods to create new streams (local peer initiated).
Http2StreamChannel
A new Http2StreamChannel interface is introduced by this proposal. It will map HTTP/2 stream states to netty channel interactions/states as follows:

H2 Stream Idle → Http2StreamChannel creation
H2 Stream Reserved(remote/local) → Not reflected on the Http2StreamChannel as this happens on the parent stream for the push promise.
H2 Stream Open → Http2StreamChannel#channelActive() is invoked.

This will be incorrect as frames like PRIORITY can arrive before HEADERS which will violate Netty’s pipeline semantics of invoking channelRead() before channelActive().
We will send channelActive() as soon as the stream is registered and stream OPEN state can be inferred when required by looking for the first header frame.

H2 Stream Half closed (remote) → ChannelInputShutdownReadComplete event is sent on the pipeline.
H2 Stream Half closed (local) → ChannelOutputShutdownEvent event is sent on the pipeline.
H2 Stream Closed → Http2StreamChannel#channelInactive() is invoked.

HTTP2 Codec builders
Http2ClientCodecBuilder and Http2ServerCodecBuilder are used to create a ChannelInitializer instance that is to be added to the parent channel for HTTP/2 channels. This initializer then provides the functionality defined under Control flow overview for the parent channel. After initializing, the parent channel, it is wrapped in an Http2Channel instances and emitted to the Consumer provided at build time. Child channels per stream are handled as follows:

Remote peer initiated streams: Implicitly created when reading a header frame and then emitted on the parent channel using the channelRead() flow. Created Http2StreamChannel instance is stored in the muxer handler.
Local peer initiated streams: Http2Channel#createStream() creates the stream and writes the stream instance on the parent channel, for the muxer handler to store it locally.

Validators
Influenced by HTTP/3 validators approach, all validation for frame validity is done using the validation handlers added to the individual stream channels.
Flow control
Outbound (write)
Flow control management is done by a handler on the parent channel and the handling is split into two parts:

Per stream credit distribution: The algorithm for distribution is owned by the aforementioned handler and the streams are notified using a newly added API: ChannelFlowControlledBytesDistributor. This instance is available as a channel attribute which individual stream instances can retrieve and listen for distributed bytes.
Parent channel credit management: This state is held by the aforementioned handler by reading WINDOW_UPDATE frames for the channel and for the streams.

The feedback to the algorithm in the handler is also when data is read on different streams or when streams are closed. This feedback is received on package local methods on this handler from the flow control handler added to each stream.
Inbound (read)
HTTP/2 parent channels always work with AUTO_READ enabled so that individual streams can then manage reads as regular for netty channels. When AUTO_READ is enabled for a child channel, data frames will be read or buffered based on the WINDOW_UPDATE frames written to that channel either internally by netty or by the user. The WINDOW_UPDATE frame feedback to the stream channel Unsafe is provided by the flow control handler added to each stream.
Experimental raw HTTP/2 channel
This proposal also adds an option to create a “raw HTTP/2 channel” which does not mux data over individual stream channels but provide the same functionality by managing state per stream. This is an attempt to completely eliminate the overhead of per stream channel creation but adds overhead on users to read/write HTTP/2 frames. Example of these can be found here and here. This is still experimental and may be removed as part of the proposal review.

@ejona86 @trustin @njhill Please share your thoughts on the APIs when you get a chance.
Although the basic example works, this is no way complete and the intent is to work on this as a POC in a different branch and then cherry-pick specific smaller chunks of work in to the 5.x branch.

Is it possible to get the stream ID right away after creating a new stream?

Gave this  a rebase, got things compiling again, replaced more use of ByteBuf with Buffer, and got the examples running again.

ready? thanks! nice.

ready?

@chrisvest Any updates on this?

@hyperxpro No, I've been busy with http headers and other stuff.


Add Prison information screens

Changes in this PR
This PR adds two new pages for fetching information from NOMIS and including it in the Apply form.
Screenshots of UI changes

Release checklist
Release process documentation.
Pre-merge checklist

[ ] Are any changes required to dependent services for this change to work?
(eg. CAS API)
[ ] Have they been released to production already?

Post-merge checklist

[ ] Manually approve
release to test
[ ] Manually approve
release to preprod
[ ] Manually approve
release to prod

 Add Prison information screens

On the ACCT screen underneath the navigation bar can we include the full name for ACCT. For example:
"Assessment, Care in Custody and Teamwork (ACCT)"
And can we change the button text from 'Save and continue' to 'Continue'
Can we also include guidance on this screen above the navigation bar:
"Review the adjudication and ACCT information provided below to help inform your referral.
This information will be included as part of your referral."
This guidance might change depending on how we decide to handle this screen but that's probably good enough for now.

@selina-dxw Do we definitely want this to be "continue"? When I flagged with Barry that this does save data imported data into our form, he said in that case to go with "Save and continue" - https://mojdt.slack.com/archives/C052G56JS5P/p1687517171640279

Ah sorry I forgot about that, yep stick with 'Save and continue'. I thought about changing the guidance but I think it's better to keep it simple for now.

@selina-dxw Done ✅


Mailer_devise_authetication

Remove current_user method in ApplicationController, devise will provide us with one.
Install and setup devise

Can register a new user.
User logs in with a combination of email and password.
Hashed password should be stored in the database.
Ask for confirmation of email.
Can reset password.

Thank you @Whoistolu


Cities not loading bug fixed

Notion :
https://www.notion.so/saeloun/The-cities-list-loading-only-when-the-user-starts-typing-ccd736741ce741fbb3a0b6682694d7e0?pvs=4
What :

Cities not loading bug fixed

Why :

When we click on city dropdown the city list should be displayed

Preview :
Before:

After:

Todos (for testing):
Tested if cities are loading on selecting the city field, or changing the state field.

@Shruti-Apte The same fix needs to be done on the team details page, while creating a new company and editing it.

@Shruti-Apte The same fix needs to be done on the team details page, while creating a new company and editing it.

@Shruti-Apte Gentle reminder

@Shruti-Apte If a city is already selected then its not showing cities list. We have to change state or country first to change the city.

There are no cities present for central district state, If you select different country and state it's working properly.

@Shruti-Apte Can't access edit org. page. Please check all the pages once where we can create/edit address.

@Shruti-Apte Have you updated the seed data and tested the timezone and fiscal year that we discussed yesterday?

@Shruti-Apte Have you updated the seed data and tested the timezone and fiscal year that we discussed yesterday?

Yes, In seed data fiscal year is stored as jan-dec  but in code we are accepting only single month value like Dec,  Nov we need to update it from seed data

@prasanthchaduvula Please review this PR.
The bug:
Earlier  the cities list on the “Setup org”, “Edit Org” & “Edit Personal Details” were loading only when the user starts typing on the field.  Also the city value was not updating if user changes the state or country.
Bug Fix:
Now the list of cities  is populating on click of city dropdown. also if user changes the country or state the City value will be removed.
we can connect for demo.

@Shruti-Apte Please update the seed data to support cities


POST request with caching enabled and a body containing different data is treated as same request

Would it be possible to cache requests based on the content of the body of the request and not only the path?
E.g. right now with caching enabled
If I make this request
const data = await $party(
  'some-url',
  {
    method: 'POST',
    body: {
      foo: 'bar'
    },
)

and afterwards the same request but with a different body
const data = await $party(
  'some-url',
  {
    method: 'POST',
    body: {
      bar: 'foo'
    },
)

the request won't return the correct data as it will hit the cache.

Good idea.


Fix links on mobile view?

Hi,
When I look at my site on a mobile device, it appears that the navbar for static pages isn't visible, but that the footer with links is visible.  That's good, except that the way the page loads, the links all kind of  stomp on each other:
https://dl.dropboxusercontent.com/u/5473387/bj-mobile.jpg
Brian

Closing as I've moved to a new platform.


iPhone X lost jailbreak after successful jb

I used uncover to jailbreak my iPhone X running iOS 12.1.2. It took about 5 tries and then cydia finally showed up.
It did not open however and crashed immediately.  After selecting reset cydia cache and trying 3 more times it worked.
I installed a few tweaks which worked only sometimes, so I decided to reboot. After the reboot, none of my tweaks showed up and cydia would not open.
I tried more than 5 times to re jailbreak but after a reboot no tweaks show up and cydia doesnt open :/

It is my understanding that unc0vered is a semi-tethered jailbreak. It will require the device to be re-jail broke if hard rebooted.

I did not realize it was semi-tethered jb, thanks !
You can close this now.


ENOENT: no such file or directory

Describe the bug
Using the provisioncomposer.js to deploy new resources I get the below error:
Login to Azure:
To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code FX4PU32FB to authenticate.

Creating App Registration ...
Create App Id Success! ID: d5533a00-475a-46e7-9104-84b3a87ca691
Creating resource group ...
Validating Azure deployment ...
Deploying Azure services (this could take a while)...
| > Validating QnA deployment ...
[Error: ENOENT: no such file or directory, open 'C:\Users\TE\bots\VirtualAssistant\scripts\DeploymentTemplates\qna-template.json'] {
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\Users\TE\bots\VirtualAssistant\scripts\DeploymentTemplates\qna-template.json'
}

Version
1.1.1
OS

[ ] macOS
[x ] Windows
[ ] Ubuntu

Expected behavior
After it fails, it does not give me the JSON to populate the publishing component on the composer. It just gets stuck.

node provisionComposer.js --subscriptionId=xxx --name=lh-john --appPassword=xxx --tenantId=xxx --environment=dev --customArmTemplate=DeploymentTemplates/function-template-with-preexisting-rg.json
That is the command I used.

@luhan2017 can you please take a look at this issue? Thank you!

@tekram  Hi, could you please try copy this qna template fileto your target folder (C:\Users\TE\bots\VirtualAssistant\scripts\DeploymentTemplates)?

@tekram did you tried to copy the qna-template.json as well? If your bot is created from an old version of composer, you should copy both provisionComposer.js and qna-template.json to your bot to make it work.  Or you can add a param  -createQnAResource false.

Assuming resolved. Please reactivate in case it's not the case.


preparations for js-ipfs 0.29.0

Similar to https://github.com/orbitdb/ipfs-log/issues/124. Here I was less lucky, some tests failed with always the same error, example bellow:
 6) orbit-db - Automatic Replication (js-ipfs)
       automatic replication exchanges the correct heads:

      Uncaught AssertionError [ERR_ASSERTION]: must be a valid cid
      + expected - actual

      -false
      +true

Thanks @diasdavid for keeping us up to date! ❤
Will try to work the new release into OrbitDB asap. Any ideas what the ^ must be a valid cid comes from? PubSub (as mentioned in https://github.com/orbitdb/ipfs-log/issues/124)?

It doesn't look like orbit-db or ipfs-log has js-ipfs-block in its dependency tree though.

My recommendation is to update all deps.


Fatal error: Access to undeclared static property: Kirki_GoogleFonts_Manager

Fatal error: Access to undeclared static property: Kirki_GoogleFonts_Manager::$font_weights in E:\WebMatrix\wp-base\wp-content\plugins\kirki\includes\googlefonts\class-kirki-googlefonts-field-processor.php on line 74

Maybe a typo? Should it be Kirki_Google_Fonts_Manager. Sorry I couldn't be more helpful.

Hey there! This should be fixed now, can you please try pulling the master branch again and testing?
We completely rewrote the googlefonts implementation yesterday, so if you find any more bugs please do let us know (no matter how small)

Hi @aristath !
Master seems to be fixed. Will there be a version bump for this fix or just retro fitted into v<IP_ADDRESS>?
Thanks
Mike

this will be 2.2.0 when released :+1:

Magic, thank you again for this and all the hard work!
:cake:


Flutter icon Added, Flutter Language Added in readme.md file

Project URL

Category

Description

Why it should be included to Awesome macOS open source applications  (optional)
Checklist

[ ] Edit applications.json instead of README.md.
[ ] Only one project/change is in this pull request
[ ] Screenshots(s) added if any
[ ] Has a commit from less than 2 years ago
[ ] Has a clear README in English

I have Added Flutter icon in icon folder and Flutter Language in Readme.md file.


Add Legal Name for Organization SignUp form in the Expense Flow

This is with regard to the following conversation, https://github.com/opencollective/opencollective-frontend/pull/6818#discussion_r713235892
It seems that we have missed adding the Legal Name to the organizational signup form within the expense flow. So when a user invite another user to submit and expense that user can then create an organization within the expense flow and I think we need to add the legal name to this flow as well. 😄

cc: @Betree

Good catch, feel free to ask @opencollective/design if you also need some feedback from them.

User
Organization

We can follow the same logic from the contribution form, the incognito profile will likely exist for expenses as well after https://github.com/opencollective/opencollective/issues/3422
@SudharakaP

@Memo-Es : Just to clarify, this is the new design for the contribution flow correct? We do not have this yet if I am not mistaken? 🤔 😄


[BUG] Extractor Pipeline fails creating Pull Request

Release version
v4.0.2
Describe the bug
Extractor writing files to /home/vsts/work/1/s/artifacts while export, but in publishing the artifact it is looking for files in
/home/vsts/work/1/a. This is shown as No files in artifacts and fails in creating a Pull request.
Expected behavior
Publishing artifacts should look for the files in directory where the extractor exported them(in this case /home/vsts/work/1/s).
Actual behavior
Extractor writing files to /home/vsts/work/1/s/artifacts while export, but in publishing the artifact it is looking for files in /home/vsts/work/1/a. This is shown as No files in artifacts and fails in creating a Pull request.
Reproduction Steps
Run run-extractor.yaml

This seems to be an issue with your paths you are passing. The s is the source code. The a is the artifacts directory. Make sure you are setting the right paths in your devops pipelines. This is not a tool issue. I think at one point there is some other issue that they had the same mistake so please look at some of the closed issues.

In my case, it relates to this https://github.com/Azure/apiops/issues/170. Passing values as parameters instead of using variable groups resolved this. Thanks! @waelkdouh


Kokoro migration

Initial kokoro build with language

How do we know the integration works? Will Kokoro update PRs like CircleCI and Travis-CI do?

I see the check added to the GitHub PR now. It links to source.cloud.google.com.
The build only appears to be performing a bundle update, and only for Ruby 2.5. Is this PR still a WIP? Should it have the do not merge label?

Yeah, still working on it. Good call on the label. I'm gonna try to have it just more or less mirror what circleCI's set up to do for now, with the option to have it diff and test individual updated gems later on.

Nothing stands out. I’ll look at it.

I think the failure is due to an encoding difference. Is the default Kokoro encoding UTF-8?
I have pushed a change to the storage tests on this branch to see if it un-sticks the build. If it does, we can push that change in a separate PR so it won't clutter this one.

Wait, Kokoro tails the output for you?!? Sign me up!

@TheRoyalTnetennba Do you want me to submit the test fix on a different PR so you can rebase and remove my commit from this PR?

Good catch. Yeah, I'll rebase and set the locales for the images.

Will Windows and OS X builds be part of this PR?

Windows and OS X will come later.  For now we're trying to get it working end-to-end for Linux.


Doesn't work with IE11 and ES6 scripts

Environment

Plugin Version: 0.5.6
Webpack Version: 4.35.3
OS Version: Windows 10 x64
Node Version: 10.11.0
NPM Version: 6.7.0
Browser Version: IE 11

Current Behavior
The browser stucks with error in main scripts (since ES6 incompatibility) and there is no any actions from obsolete.js
Expected Behavior
The browser should show the default obsolete-message
Detailed Description
How to reproduce

Create any project with webpack 4 and obsolete-webpack-plugin
Add to .browserslistrc with 'excluding of IE11' and any incompatible ES6 browsers (you can set the only last 5 Chrome version string)
Add any ES6 script to index.js
Compile and look into results in IE11 - browser finds the error in main.js and there are no actions from obsolete.js

It may be issue IE11, but how can it be resolved?

https://github.com/ElemeFE/obsolete-webpack-plugin#configuration-book
Just set promptOnNonTargetBrowser  to true.

Yep. I can't imagine that this property is false by default.... Thanks a lot.


[Extensibility Enhancement] Provide access to Caption and Request Page Caption through Report Extension

Describe the request
When you create a Report Extension you can modify existing fields on the Request Page of the report, changing captions and behavior of those fields but you cannot change the caption on the report or on the request page.
We would like the Caption of the Report and the Request Page to be accessible through the Report Extension object the same way as it is in a Page Extension object.
Additional context
When extending the functionality of an existing report we would like to be able to reflect this in the Caption.
E.g. if the existing Request Page caption says "Create Sales Invoice" but we extended the report, adding the ability to create Sales Order, we would like to be able to change the Request Page caption to "Create Sales Document".
However, in the current setup we cannot just extend the existing report; we will have to copy the entire standard report to a new object and modify it to get this result.

Good idea, but is not something we can do via AL. Instead, create a new idea on aka.ms/bcideas for the platform.

Thanks, Bardur - will do...


Chinese fonts monospace rendering is not correct

VSCode Version: 1.42.1; c47d83b293181d9be64f27ff093689e8e7aed054; x64
OS Version: Windows 10.0.18363 Build 18363

Steps to Reproduce:

Without any configurations or steps to reproduce
Just open a file contains some Chinese characters, Chinese characters could not be aligned correctly, just like the screeshot under below.

I have tested other Chinese fonts with monospace like "黑体", "Microsoft Yahei". The problem is same as default settings.
Does this issue occur when all extensions are disabled: Yes

The width of characters is defined by the font. If you want to have 1 wide character = 2 latin characters, then please use a font which defines that. e.g. Inconsolata.

The width of characters is defined by the font. If you want to have 1 wide character = 2 latin characters, then please use a font which defines that. e.g. Inconsolata.

Thanks for your reply，I have try your suggestion to set Inconsolata as my default font settings. The problem has been solved. Thank you.


fix crash on searching a room #634

changed room count from Integer to int (adapted related code)
minor refactoring

I could be wrong, but I think that the room count can be an int (instead of Integer).
This way it does not have to be null checked and can be used more safely.
I also couldn't quite resist and did some minor refactoring where I changed code.
If this is too much of a change for this small issue, you could just do this instead:
/**
* @return the matched public rooms count
*/
public int getMatchedPublicRoomsCount() {
    return null == mMatchedPublicRoomsCount ? 0 : mMatchedPublicRoomsCount.intValue();
}

Your PR does not really fix the issue : we should not open the public rooms list until it is retrieved.

Not quite sure what you mean.
The changes are not made where the actual crash happened, maybe that is the problem.
The crash happened in VectorSearchRoomsListFragment.java:140 mAdapter.getMatchedPublicRoomsCount() > 0 because of the auto unboxing of a null Integer.
Here the full code that prevents the opening of the room list, if there are no rooms (unchanged by this PR):
if (TextUtils.isEmpty(mAdapter.getSearchedPattern()) || (mAdapter.getMatchedPublicRoomsCount() > 0)) {
    Intent intent = new Intent(getActivity(), VectorPublicRoomsActivity.class);
    intent.putExtra(VectorPublicRoomsActivity.EXTRA_MATRIX_ID, mSession.getMyUserId());

    if (!TextUtils.isEmpty(mAdapter.getSearchedPattern())) {
        intent.putExtra(VectorPublicRoomsActivity.EXTRA_SEARCHED_PATTERN, mAdapter.getSearchedPattern());
    }
    getActivity().startActivity(intent);
}

A null-check could be added there instead.
I just try to fix it more solidly, because a null-check of a count is quite easy to forget and there didn't seemed to be a good reason why this could not be a primitive int.

=> #690
Thanks.


Not support @TableIndex() to create Index with Postgresql

Describe the bug
Use @TableIndex() on table defination, with postgresql, call: createAll() failed!
error message:
Failed assertion: line 36 pos 7: 'sql.containsKey(dialect)': Tried running SQL optimized for the following dialects: Closure: ([String]) => String from Function 'join':.. However, the database is running SqlDialect.postgres. Has that dialect been added to the dialects drift builder option?
drift version : 2.22.1
callstack:
'package:drift/src/runtime/query_builder/helpers.dart': Failed assertion: line 36 pos 7: 'sql.containsKey(dialect)': Tried running SQL optimized for the following dialects: Closure: ([String]) => String from Function 'join':.. However, the database is running SqlDialect.postgres. Has that dialect been added to the `dialects` drift builder option?
dart:core                                                      _AssertionError._throwNew
package:drift/src/runtime/query_builder/helpers.dart 36:7      WriteDefinition.pickForDialect
helpers.dart:36
package:drift/src/runtime/query_builder/migration.dart 544:38  Migrator._issueQueryByDialect
migration.dart:544
package:drift/src/runtime/query_builder/migration.dart 402:12  Migrator.createIndex
migration.dart:402
package:drift/src/runtime/query_builder/migration.dart 92:13   Migrator.create
migration.dart:92
package:drift/src/runtime/query_builder/migration.dart 80:13   Migrator.createAll

build.yaml
targets:
  $default:
    builders:
      drift_dev:
        options:
          sql:
            dialect: postgres
          store_date_time_values_as_text: true
          databases:
            pg_database: bin/postgres_db/database.dart

order table source:
@TableIndex(name: 'idx_preparer', columns: {#preparer})
class Order extends Table
{
        TextColumn get preparer => text().references(Account, #id)();
}

Thanks for the report! This is a bug in drift_dev when generating code. As a workaround for this, you can enable a second dialect even if you don't need it:
targets:
  $default:
    builders:
      drift_dev:
        options:
          sql:
            dialects:
              - sqlite
              - postgres
          store_date_time_values_as_text: true
          databases:
            pg_database: bin/postgres_db/database.dart

Thank you for your excellent work. It's really appreciated!


Add searchable cradle dependencies

Extends hie.yaml file format with the "dependencies" object.
Extends Bios cradle type with an optional FilePath to
obtain cradle dependencies from.
Set for each cradle type the cradle dependencies.
Reorganise parsing of "hie.yaml".

[x] For each cradle type, implement a function that returns dependencies common to the respective cradle type.
[x] Test the parsing of hie.yaml a bit more, smoke testing succeeded

Note: parsing of hie.yaml is less strict now, if there is a field such as "dependecies" (note missing 'n'), it will parse, assuming the correct field "dependencies" is not defined.
Closes #35
Makes #39 obsolete

I think just needs a update to the README.

Surely the dependencies field should be at the top level, like cradle? What's your reasoning for the way you have implemented it?

Surely the dependencies field should be at the top level, like cradle? What's your reasoning for the way you have implemented it?

My reasoning was these are the depedencies of a cradle and a cradle specification consists of a type of cradle and dependencies to that cradle.
But no technical reasoning.

Can you change the dependencies to be on the top level of the yaml file?
Then I will merge it. The cradle option is really specifying the CradleType.


How to run the detekt plugin in Android Studio

Hi, there.
Just a silly question, I have installed the detekt plugin from the marketplace in the Android Studio and also enable it and tick "Enable Detekt", "Enable Formatting rules", "Build upon the default configuration" and "Enable all experimental rules". I also define the path for the Configuration File.
So what should I do next step for reviewing the related output of Detekt ? Just click the run or build? where is the output
Thanks a lot.

So what should I do next step for reviewing the related output of Detekt ? Just click the run or build? where is the output

You should see the Detekt reports inline in your code. The code that gets reported will be highlighted and you can use the quick edit menu to understand what is the error and how to fix it.


Add crystal 0.36 to https://dist.crystal-lang.org/rpm/

It still provides 0.35.1-1.

The repository at dist.crystal-lang.org is not supported anymore. New releases are available at bintray. See the announcement blog post.

The repository at dist.crystal-lang.org is not supported anymore. New releases are available at bintray. See the announcement blog post.

Ah, thanks for the heads up.

Ah, thanks for the heads up.


Automated cherry pick of #5181: aws listener sync fix

Cherry pick of #5181 on release/3.1.
#5181: aws listener sync fix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.1@c0c26c7). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             release/3.1   #5185   +/-   ##
=============================================
  Coverage               ?   6.73%
=============================================
  Files                  ?     547
  Lines                  ?   95752
  Branches               ?       0
=============================================
  Hits                   ?    6451
  Misses                 ?   88763
  Partials               ?     538

Flag
Coverage Δ

#aFlag
6.73% <0%> (?)

Impacted Files
Coverage Δ

pkg/multicloud/aws/loadbalancerlistener.go
0% <0%> (ø)

pkg/multicloud/aws/instance.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c26c7...71499e7. Read the comment docs.

/lgtm

/approve


Lint the code

Make sure our code mostly follows https://google.github.io/styleguide/cppguide.html and use their lint tool.
Ideally, we'd have a clear subset of the Google rules we adopt and a corresponding lint script (based on cpplint.py).

Default settings for cpplint applied to HEAD return this: http://pastebin.com/BZH6MF6J Looks pretty sane to me, but we may want to make it stricter.


Fetch redirect URLs from referrer chain and alert if there are many redirects

Fetch redirect URLs from referrer chain and alert if there are many redirects
Add a new signal examining the redirect chain to provide more information that's helpful in determining if a site is suspicious. This patch also provides the setup for other signals related to the redirect chain, such as whether the site redirected through a TLD associated with a high rate of spam/abuse.

Cool! This is, I believe, the first check that relies on data from the specific navigation, rather than the from just the FQDN.
This means that any cache we create can't simply use the url's domain name as a key.
(The current cache isn't key'd at all, which causes #8)

Cool! This is, I believe, the first check that relies on data from the specific navigation, rather than the from just the FQDN.
This means that any cache we create can't simply use the url's domain name as a key.
(The current cache isn't key'd at all, which causes #8)

Yes, good point! We probably need something like a combination of url's domain name with tab id in this case.


feetless 2.0 issues: option to turn off auto-removal of corners and disabling of edges in update_boundaries

While author understands the reasoning behind this, the auto-removal and -disabling can cause disruptions... (for instance, users may use corners as key markers/datums, etc....)

Not sure if it is worth having a special override for the corner edges of a quad mesh though. Seems like this particular situation is quite specific to your problem, so maybe you could find a temporary work-around for this?
@brgcode thoughts?

I believe this has been discussed and either addressed or removed from consideration.
Disabling of auto-removal of anchored corners (whose neighbors are also anchors) would result in unnecessary edges in the force diagram whose length will be 0 anyway. Workaround would be to leave them as free vertices, then change the 'is_anchor' attribute to True once the formdiagram has been created.


Parse Exception

Hi there,
I would like to report the following issue I have experienced.
`
$logMessage = "2019-01-02T15:36:25+00:00 myfqn myuuid OWQ pam_unix(sshd:session): session closed for user mynewuser "
$groupNames = @('Var1', 'Var2', 'Var3', 'Var4')

Graph G {

    Node -Name "My new Node"
    Node -Name $logMessage

    Edge $groupNames -FromScript { $logMessage } -ToScript { $_ }

} | Show-PSGraph

}`
Exception message:
Show-PSGraph : System error. At C:\myfilepath\myscript.ps1:82 char:9} | Show-PSGraph          ~~~~~~~~~~~~     CategoryInfo          : NotSpecified: (:) [Write-Error], ParseException     FullyQualifiedErrorId : System.Management.Automation.ParseException,Show-PSGraph
It looks like the colon in the $logMessage variable seems to cause problems.
Can you please look into this?
If you need any further information feel free to message me.
Cheers,
Tom Maier

Hi @KevinMarquette,
thanks for your reply. Unfortunately I have to deal with obscurely formatted strings in my PSGraph. I look forward to your solution on this.
Cheers,
Tom

This is confirmed working in 2.1.19 but is broken in 2.1.37. I need to dig into those releases to see what changed. I thought I had resolved this before.


error reporting

Import can silently fail.  For example, specifying a csv file that doesn't exist does not give an error in the log but obviously doesn't work

Fixed


ZEPPELIN-367 Sync with secondary storage when listing notebooks

This PR resolves https://issues.apache.org/jira/browse/ZEPPELIN-367 by synchronizing with secondary storage when reloading all notebooks into memory. Currently, existing ZEPPELIN_NOTEBOOK_RELOAD_FROM_STORAGE from https://github.com/apache/incubator-zeppelin/pull/331 is used as a flag since these functionalities are correlated, however it can be separated into distinct flag as well.

triggering CI build

Tested and LGTM

Looks good. But could you rebase and trigger CI again?

@Leemoonsoo done with that

LGTM. merge if there're no more discussions


[question] Missing/wrong chunks with CommonChunksPlugin and dual-import

My configuration makes extensive use of the CommonsChunkPlugin to bundle common dependencies into async chunks. Unfortunately, this causes issues the babel-plugin-dual-import and this plugin, as the CSS files the modules within the commons chunk refer to are no longer in the location they assume, but within a combined commons chunk.
For example, if I have src/moduleA and src/moduleB, the importCSS call injected via babel-plugin-dual-import assumes that each of their stylesheets are in src/moduleA.css and src/moduleB.css respectively. However, when these are combined into an async chunk using CommonsChunkPlugin, say named common, both stylesheets now actually reside at common.css.
webpack-flush-chunks gives the "correct" output of these chunks when looking at the CSS Hash, but obviously since babel-plugin-dual-import has no knowledge of the output chunks, the stylesheets it refers to are not in the hash e.g.
var cssHashWithoutCommonsChunkPlugin = {
   "src/moduleA": "output/moduleA.css",
   "src/moduleB": "output/moduleB.css"
}

var cssHashWithCommonsChunkPlugin = {
   "common": "output/common.css" // <- moduleA and moduleB have no entries now :(
}

Is there a recommended approach to solving this? The only way I can think of doing it is to inject an entry into the CSS hash for src/moduleA and src/moduleB, which points to the bundled common.css. This will however result in multiple  tags being injected that point to the same stylesheet which obviously isn't ideal.

This is a very interesting (and should be common) use case. I can't think right now how to support it.
But here's a userland solution:
Rewrite the hash manually on the server to be:
var cssHashWithoutCommonsChunkPlugin = {
   "src/moduleA": "output/common.css" ,
   "src/moduleB": "output/common.css"
}

I guess that's exactly what you said at the end. The dual import plugin could be PRed to not inject anything if a stylesheet with the given href already exists, right around here:
https://github.com/faceyspacey/babel-plugin-dual-import/blob/master/importCss.js#L27
Also I'm not sure if you saw and if it applies to you, but there's now also a babel-plugin-universal-import:
https://medium.com/faceyspacey/announcing-react-universal-component-2-0-babel-plugin-universal-import-5702d59ec1f4
It adds additional features to apply to React Universal Component. If you're using RUC, you probably want to upgrade to the 2.0 and use that plugin. Both babel plugins share the same css injection code.

the one caveat with this approach is that it's not DRY, as it's not resilient when it comes to changing the location of modules in your file system. You could make it such, and to do so you'd have to use the chunkName trimming here:
https://github.com/faceyspacey/babel-plugin-dual-import/blob/master/index.js#L8
It's probably not the biggest deal, but I thought I'd point it out.

Yes I thought that might be the case for an interim solution. Not ideal! Especially because my file names use output hashes so they're not static :(. I wonder if there's a way to process the stats using some naming convention for async chunks and generate these entries after flushChunks is called? The information must be in there somewhere!
As for the universal component, I'm not using React in this specific use case so opted for the dual-import as is detailed on the repo guide. Is this still valid or should I upgrade?

No, it's valid. It's fine.
the assets are here:
stats.assetsByChunkName

The implementation of this function should help you:
https://github.com/faceyspacey/webpack-flush-chunks/blob/master/src/flushChunks.js#L192
the key on the above object should be common. Unfortunately for autodll it cant get in there because the plugin cant add to stats. But maybe optimizeChunks can.

For those of you having this issue, I've temporarily worked around it by forcefully excluding any module that has CSS extracted via the extract-css-chunks-webpack-plugin. You can do this by adding the following logic into your minChunks property of your CommonsChunkPlugin:

const moduleHasExtractedCss = (module) => {
	if (!module.dependencies) {
		return false;
	}

	return module.dependencies.some((dep) => {
		if (!dep.module) {
			return false;
		}

		return /extract-css-chunks-webpack-plugin/.test(dep.module.request);
	});
};

new CommonsChunkPlugin({
   // ...other options here
   minChunks(module, count) {
      if (moduleHasExtractedCss(module)) {
         return false;
      }

      // ...other logic here
   }

solid!

closin this out for now, as I'm not sure what we can do beside your manual strategy.


samples: net: cellular_modem: Add additional overlay for nrf7002dk

This overlay is for the nrf7002dk. The modem tested was the Telit ME310G1-WW, but should work for any of the supported modems provided that the UART lines are defined and hooked up correctly.

For local board modifications, one should use snippets locally. Local board modifications can't go upstream since overlays apply to the base board, so the overlay would be applied, likely incorrectly, to everyone elses local board, which could be configured very differently :)
To run the cellular sample with snippets, you would create the snippet with the overlay you add in this PR (named "nrf7002dk_telit" in this example), then build the sample like
west build -p -b nrf7002dk/nrf5340/cpuapp --snippet nrf7002dk_telit zephyr/samples/net/cellular_modem

With the base board and snippet, you have a "custom" local board you use for any in-tree sample

@bjarki-andreasen Isn't this already done with some of the DT overlays already present?
I mean yeah, I see why we might not want to have something like a "hardcoded" modem compatible in such an overlay. But having at least part of that overlay readily available could be useful to users, if something like that is feasible.

We can add the overlay as a snippet to tbe sample

Ok so I should name the overlay nrf7002dk_telit.overlay or nrf7002dk.snippet? And what should I do for the various pin numbers? Just add a comment saying something like "make sure these are correctly defined for your board"?


don't mutate input args

When writing multidat I noticed the input args were being mutated; this fixes that. Thanks!

published in 1.3.2


Categorize components to install

the list is starting to be bigger, it might useful to categorize them, not sure around which criteria.
This came to my mind while thinking that it would be easier if I have a single checkbox for installing Fuse for all possible platforms

This feature request is similar what we call "Channels UI".
I can suggest possible categories that would trigger selection for specific components and possibly hide irrelevant ones:

Java Development
[x] OpenJDK
[x] Developer Studio
Container Development
[x] OpenJDK
[x] Developer Studio
[x] CDK
[x] Kompose
Fuse Development
[x] OpenJDK
[x] Developer Studio
[x] Fuse Tooling
[x] Fuse Platform on Apache Karaf
[ ] Fuse Platform on JBoss EAP
Runtimes
[x] OpenJDK
[x] Fuse Platform on Apache Karaf
[x] Fuse Platfrom on JBoss EAP
[x] JBoss EAP
Red Hat Products
[x] OpenJDK
[x] Developer Studio
[x] CDK
[x] Fuse Platform on Apache Karaf
[x] Fuse Platfrom on JBoss EAP
[x] JBoss EAP
Community projects
[x] Kompose
All
We would need to find good way to let user select those categories in installer:

as additional page before selecting components
special UI control on selection page

For Fuse development, we also need the CDK, it is for the FIS 2.0 (Fuse Integration Services) part.
In runtimes, I'm attempted to put the CDK too, it is more or less a "deployment target".


Nodescanner now works with right click

About the PR
Added a context menu action for scanning artifacts for the node scanner.
Why / Balance
Because container artifacts prioritized putting items in them over scanning it.
#25436
Technical details
Just added a context menu verb.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

https://github.com/space-wizards/space-station-14/assets/62134478/4bde4ebc-9969-4f02-a6e8-d397d794b91c
Changelog

:cl:

add: Added context menu action for scanning artifacts.

Don't really know how easy it'd be to move this to Shared, I think that ArtifactComponent also needs to be moved to Shared to determine whether the context action should be shown.

Don't really know how easy it'd be to move this to Shared, I think that ArtifactComponent also needs to be moved to Shared to determine whether the context action should be shown.

Fair enough. I might look into that at some point in the future, but don't worry about it for now.

Because container artifacts prioritized putting items in them over scanning it.

Should be fixed by changing the priority so insertion is after scanning. While this PR is certainly nice, it's not a proper fix for the root issue.

Yeah, it would be best to have both.

Because container artifacts prioritized putting items in them over scanning it.

Should be fixed by changing the priority so insertion is after scanning. While this PR is certainly nice, it's not a proper fix for the root issue.

At first this is what I tried to do, but after digging around a while, I decided that this method was a bit too burdensome for the time being.
At least with this PR people will stop complaining about this specific issue, assuming they discover this context action.

Now this seems to be working, though it isn't predicted.
https://github.com/space-wizards/space-station-14/assets/62134478/a39ad6cf-5bae-4e98-8b9d-e60671307139


HBASE-23146 Support CheckAndMutate with multi conditions

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 18s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  1s
The patch appears to include 8 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 51s
master passed

+1 :green_heart:
compile
3m 36s
master passed

+1 :green_heart:
checkstyle
3m  8s
master passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 20s
master passed

+0 :ok:
spotbugs
1m 37s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
12m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 34s
the patch passed

+1 :green_heart:
compile
3m 39s
the patch passed

+1 :green_heart:
cc
3m 39s
the patch passed

+1 :green_heart:
javac
3m 39s
the patch passed

-1 :x:
checkstyle
0m 32s
hbase-client: The patch generated 9 new + 103 unchanged - 8 fixed = 112 total (was 111)

-1 :x:
checkstyle
1m 20s
hbase-server: The patch generated 11 new + 455 unchanged - 4 fixed = 466 total (was 459)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 36s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
3m 30s
the patch passed

+1 :green_heart:
javadoc
2m 17s
the patch passed

+1 :green_heart:
findbugs
13m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
0m 28s
hbase-protocol in the patch passed.

+1 :green_heart:
unit
2m  0s
hbase-client in the patch passed.

+1 :green_heart:
unit
158m  7s
hbase-server in the patch passed.

+1 :green_heart:
unit
3m 45s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
5m 16s
hbase-rest in the patch passed.

+1 :green_heart:
asflicense
2m 39s
The patch does not generate ASF License warnings.

273m  8s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1114

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 9ff26235c8c8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1114/out/precommit/personality/provided.sh

git revision
master / 5a3ad6f08f

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/1/artifact/out/diff-checkstyle-hbase-client.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/1/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/1/testReport/

Max. process+thread count
4744 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 8 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 52s
master passed

+1 :green_heart:
compile
3m 39s
master passed

+1 :green_heart:
checkstyle
3m 13s
master passed

+1 :green_heart:
shadedjars
5m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 21s
master passed

+0 :ok:
spotbugs
1m 37s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
12m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 36s
the patch passed

+1 :green_heart:
compile
3m 43s
the patch passed

+1 :green_heart:
cc
3m 43s
the patch passed

+1 :green_heart:
javac
3m 43s
the patch passed

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-protocol-shaded

+1 :green_heart:
checkstyle
0m 11s
The patch passed checkstyle in hbase-protocol

+1 :green_heart:
checkstyle
0m 33s
hbase-client: The patch generated 0 new + 85 unchanged - 26 fixed = 85 total (was 111)

+1 :green_heart:
checkstyle
1m 18s
hbase-server: The patch generated 0 new + 449 unchanged - 10 fixed = 449 total (was 459)

+1 :green_heart:
checkstyle
0m 41s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 15s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 39s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
3m 22s
the patch passed

+1 :green_heart:
javadoc
2m 23s
the patch passed

+1 :green_heart:
findbugs
13m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 45s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
0m 27s
hbase-protocol in the patch passed.

+1 :green_heart:
unit
2m  3s
hbase-client in the patch passed.

-1 :x:
unit
161m 27s
hbase-server in the patch failed.

+1 :green_heart:
unit
3m 47s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
5m 12s
hbase-rest in the patch passed.

+1 :green_heart:
asflicense
2m 36s
The patch does not generate ASF License warnings.

273m 14s

Reason
Tests

Failed junit tests
hadoop.hbase.quotas.TestClusterScopeQuotaThrottle

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1114

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux d30055d5e41c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1114/out/precommit/personality/provided.sh

git revision
master / ab0039974d

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/2/testReport/

Max. process+thread count
4821 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

The test failures in the last QA are not related to the patch. I ran the failed tests locally and they were successful.

I just force-pushed the new patch with changing the new API. I added a new method which accepts a row and filter as parameters to construct a Builder.
@Apache9 Could you please review it when you get a chance?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 8 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 50s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
7m 29s
master passed

+1 :green_heart:
compile
4m 22s
master passed

+1 :green_heart:
checkstyle
3m 18s
master passed

+1 :green_heart:
shadedjars
5m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 28s
master passed

+0 :ok:
spotbugs
1m 43s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
13m 20s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 46s
the patch passed

+1 :green_heart:
compile
3m 52s
the patch passed

+1 :green_heart:
cc
3m 52s
the patch passed

+1 :green_heart:
javac
3m 52s
the patch passed

+1 :green_heart:
checkstyle
0m 11s
The patch passed checkstyle in hbase-protocol-shaded

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-protocol

+1 :green_heart:
checkstyle
0m 34s
hbase-client: The patch generated 0 new + 85 unchanged - 26 fixed = 85 total (was 111)

-1 :x:
checkstyle
1m 22s
hbase-server: The patch generated 1 new + 449 unchanged - 10 fixed = 450 total (was 459)

+1 :green_heart:
checkstyle
0m 47s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 55s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
3m 26s
the patch passed

+1 :green_heart:
javadoc
2m 20s
the patch passed

+1 :green_heart:
findbugs
13m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 43s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
0m 27s
hbase-protocol in the patch passed.

+1 :green_heart:
unit
1m  0s
hbase-client in the patch passed.

-1 :x:
unit
96m 49s
hbase-server in the patch failed.

+1 :green_heart:
unit
3m 16s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m 16s
hbase-rest in the patch passed.

+1 :green_heart:
asflicense
2m 18s
The patch does not generate ASF License warnings.

217m 46s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestNamespaceReplication

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1114

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 016c0766d222 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1114/out/precommit/personality/provided.sh

git revision
master / c4fb1cd234

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/3/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/3/testReport/

Max. process+thread count
6837 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 8 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 50s
master passed

+1 :green_heart:
compile
3m 39s
master passed

+1 :green_heart:
checkstyle
3m 11s
master passed

+1 :green_heart:
shadedjars
5m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 16s
master passed

+0 :ok:
spotbugs
1m 46s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
12m 30s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 52s
the patch passed

+1 :green_heart:
compile
3m 45s
the patch passed

+1 :green_heart:
cc
3m 45s
the patch passed

+1 :green_heart:
javac
3m 45s
the patch passed

+1 :green_heart:
checkstyle
0m 10s
The patch passed checkstyle in hbase-protocol-shaded

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-protocol

+1 :green_heart:
checkstyle
0m 33s
hbase-client: The patch generated 0 new + 85 unchanged - 26 fixed = 85 total (was 111)

+1 :green_heart:
checkstyle
1m 21s
hbase-server: The patch generated 0 new + 449 unchanged - 10 fixed = 449 total (was 459)

+1 :green_heart:
checkstyle
0m 41s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 15s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 27s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
3m 24s
the patch passed

+1 :green_heart:
javadoc
2m 16s
the patch passed

+1 :green_heart:
findbugs
13m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 43s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
0m 27s
hbase-protocol in the patch passed.

+1 :green_heart:
unit
1m  0s
hbase-client in the patch passed.

-1 :x:
unit
95m  3s
hbase-server in the patch failed.

+1 :green_heart:
unit
2m 50s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 53s
hbase-rest in the patch passed.

+1 :green_heart:
asflicense
2m 21s
The patch does not generate ASF License warnings.

203m 24s

Reason
Tests

Failed junit tests
hadoop.hbase.util.TestHBaseFsckCleanReplicationBarriers

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1114

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 4757529ac9ad 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1114/out/precommit/personality/provided.sh

git revision
master / be4b6d6824

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/4/testReport/

Max. process+thread count
6247 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1114/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

It looks like the test failures in the last QA is unrelated to this patch. I ran the failed tests locally and they were successful.

It looks like Duo is very busy.
@mistyhacks @joshelser Could you please review it when you get a chance? I would like to include it in hbase-2.3 if possible.


E2E tests failing in cloned repo

Using loom build 288:
I've just cloned a fresh loom-js repo, and I'm seeing some end-to-end test failures (most pass, all the unit tests pass).
Client nonce retry strategy
    ✖ [object Object]
    ------------------
      operator: fail
      at: Object.<anonymous> (/Users/paulbarclay/loom-js-original/dist/tests/e2e/client-tests.js:155:19)

Calls via HTTP
    ✖ Error: Failed to resolve contract address
    --------------------------------------------
      operator: fail
      at: Object.<anonymous> (/Users/paulbarclay/loom-js-original/dist/tests/e2e/contract-tests.js:197:19)

EVM Contract Calls
    { code: -32603,
      message: 'Internal error',
      data: 'name is not registered' }

Hey @paulbarclay, some tests need a prep before tests, which needs few contracts to be deployed on Loomchain:

BluePrint
SimpleStore

We're are working for a better e2e test, I mean totally automatic so any will be able to test smoothly. Btw thanks for the report

Ok, good to know. For tests on my projects, I have “deploy contracts” as a
beforeAll step in the testing flow; the same approach would work well here.
On Fri, Jul 27, 2018 at 4:13 AM, Eduardo Pereira<EMAIL_ADDRESS>wrote:

Hey @paulbarclay https://github.com/paulbarclay, some tests need a prep
before tests, which needs few contracts to be deployed on Loomchain:

BluePrint
SimpleStore

We're are working for a better e2e test, I mean totally automatic so any
will be able to test smoothly. Btw thanks for the report
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/loomnetwork/loom-js/issues/67#issuecomment-408388755,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMazlTZl4FidkHCicS7PhyytfWZ_vDkgks5uKvXbgaJpZM4VihYz
.


Form save

@BryanGK Okay you might as well review this for now. I ended up disabling a bunch of the form stuff that requires the database as that is the issue right now, it is just running the docker file with no database so it can't continue.
That is likely out of the scope of this sprint but I am going to look into it, I saw they do it in cas so there is an example at least.

@BryanGK Okay you might as well review this for now. I ended up disabling a bunch of the form stuff that requires the database as that is the issue right now, it is just running the docker file with no database so it can't continue.
That is likely out of the scope of this sprint but I am going to look into it, I saw they do it in cas so there is an example at least.

Was that related to the e2e tests?

@BryanGK Okay you might as well review this for now. I ended up disabling a bunch of the form stuff that requires the database as that is the issue right now, it is just running the docker file with no database so it can't continue.
That is likely out of the scope of this sprint but I am going to look into it, I saw they do it in cas so there is an example at least.

Was that related to the e2e tests?

Not 100% sure because they used to run locally with the Docker image. Though due to changes made in this such as creating an application in the db when the start form button is clicked it just flat out won't work. I suppose I should open up an issue because this is some tech debt I knew was incoming.

Let's ship it!

:partying_face:


Fix a typo in the build_deploy.sh script COMPONENT variable

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.01%. Comparing base (eae211c) to head (b5acbc0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   52.26%   52.01%   -0.25%
==========================================
  Files          82       83       +1
  Lines        1257     1263       +6
  Branches      266      266
==========================================
  Hits          657      657
- Misses        600      606       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


rvi-sota-client: Add openssl as a dependency

Fix an issue when reusing sstate cache for
building RVI SOTA client by adding openssl as a
dependency.
[GDP-249] go.cd pipelines failing to compile rust (issue in rustc)
Signed-off-by: Leon Anavi<EMAIL_ADDRESS>

Thanks for the work on this @leon-anavi

All target pipelines testing the PR were successful, so this is showing the missing ca certs problem from sstate sharing in the CI to be fixed +1


Ex8 Q3

I think I did things right, but I can't find this genes on IGV (YDL083c    YEL003W    YKL180W    YNL162W).
I uploaded the reference genome file - S288C_reference_sequence_R64-2-1_20150113.fasta
the annotation - S288C_reference_annotation_proc.gff
and the indexed (by samtools) STAR BAM file - star_mapAligned.sortedByCoord.out.bam
Where I might be wrong?

I'm not sure, sounds like you did right
Can you upload an IGV screenshot for region ChrIV:304,926-309,789?

ok, now its working, i can find the genes.
ty


moving commands speed parameter

Hi,
I would like to know what is the unit used in implementing the speed parameter in the moving functions like "forward", "backward", "left" and "right". It says in the documentation that the speed are from 0 to 100 but what it is in term of what? like meter/sec? I need this information urgently as I am trying to make bebop moves in certain distance.
regards,

I think it's the amount of forward tilt the drone has. Pretty sure you change it in the settings too but I guess that doesn't help you much. Can't you use the gps?

@johan-olsson Hi, I didn't get what do mean by "forward tilt" could you please clarify it more? I really appreciate it. And for the GPS no I can't use it because in our project we are restricted to indoor experiments and the characteristic of our work is to plan autonomous navigation based on image processing (track target).

I actually meant pitch I guess :) Aircraft_principal_axes. If you can't use GPS maybe this event is helpful SpeedChanged

@johan-olsson I think you are right, I was reading /lib/bebop.js file and the forward function documented as the change in the pitch value somehow.
Thank you very much for your response.


Kubernetes: add support for secrets

Great to have this! Can you add an integration test and update the schema documentaion?

@ramonpetgrave64 sure, will do!

Should be all set now @ramonpetgrave64. Thanks a lot for your reviews!

One more place for docs update https://github.com/lyft/cartography/blob/5e3955d3a3b38cf45c22e915ad4c77e38f0878b8/docs/root/modules/kubernetes/index.rst#L4

Almsot forgot: please add a cleanup job.

I think I covered all your remarks here. Thanks!

@ryan-lane @marco-lancini


Red Alert Message Staying in RECAptCHA

Describe the bug
After i completed the setup via powershell install, i make changes to match my info. When I navigate to teh portal, the Red "This recaptcha is for testing purposes only, please contact admin if I see it" message. I am not sure how to get rid of it. Also, I have put in our ldap info, and I keep getting error that it could not find my account when trying to change a password. But, I wonder if the red alert over the recaptcha area is causing the "cannot find account error."

You need to setup the Recaptcha key. Check Customization.

I have gone to google/recaptcha and obtained site and private key. I have
loaded those in the correct places in .json file, but I am still getting
the red alert across the recaptcha area.
Is that the process you are referring to?
Thank you for the quick response.
On Wed, Aug 8, 2018 at 3:42 PM Geovanni Perez<EMAIL_ADDRESS>wrote:

You need to setup the Recaptcha key. Check Customization
https://github.com/unosquare/passcore#customization-and-configuration.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/unosquare/passcore/issues/191#issuecomment-411527895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoQ5Xq4NRz-tMc63t12kcCDDHhybGoEHks5uOz8VgaJpZM4V0iOf
.

--
Rick Hogan - Systems Administrator
Mid-East Career and Technology Centers
(740) 454-0105 Ext 6232
--
CONFIDENTIALITY NOTICE:****
This message may contain confidential
information, including, but not limited to, student personally identifiable
information. Such information is intended only for the use of the
individual or entity named above. If you are not the intended recipient,
you are hereby notified that any disclosure, copying, printing,
distribution, or the taking of any action in reliance on the contents of
the information contained herein is strictly prohibited. If you receive
this e-mail message in error, please immediately notify me by telephone at
740-454-0105 to arrange for the return of the original document to me.
Please also delete the message from your mailbox. Thank
you.****http://www.mideastctc.org http://www.mideastctc.org

Thank you for your response. I was able to get the app working perfectly! The recaptcha is now working.


Improve Get_Minimum_time(...)

Try to improve the working of the Get_Minimum_time(...) function in Main.java
Note:
You may improve the existing algorithm or you may suggest some better data structure/algorithm for the same.

me and @kunal work on this .

can you please assign me this i wish to work on this

Assigned..


Couple bugs in the demo

Load the demo, click to focus on body (not the editor), then click back on editor and type. The placeholder text isn’t removed. Similarly, delete doesn’t work.
Cool project: good luck!

Got a device / browser? I see it working for both issues.

I saw this on Safari
On Wed, Jan 11, 2023 at 6:55 AM Konnor Rogers @.***>
wrote:

Got a device / browser? I see it working for both issues.
—
Reply to this email directly, view it on GitHub
https://github.com/KonnorRogers/rhino-editor/issues/25#issuecomment-1378707000,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNSREWUYGZWPCS434ON5MDWR2UTRANCNFSM6AAAAAATXWFRM4
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
This e-mail message and any attachment to this e-mail message contains
confidential information that may be legally privileged and/or deemed to be
material non-public information.  The recipient may not reproduce, copy or
forward (whether electronically or otherwise) any of the information or
materials contained herein to any other person, except to the receiver's
professional advisors.  If you are not the intended recipient, you must not
review, retransmit, convert to hard copy, copy, use or disseminate this
e-mail or any attachments to it. If you have received this e-mail in error,
please immediately notify us by return e-mail and delete this message.
E-mail transmissions cannot be guaranteed to be secure or error-free as
information could be intercepted, corrupted, lost, destroyed, arrive late
or incomplete, or contain viruses.  The sender therefore does not accept
liability for any errors or omissions in the contents of this message which
arise as a result of e-mail transmission. If this e-mail contains a
forwarded message or is a reply to a prior message, the sender may not have
produced some or all of the contents of this message or any attachments. If
verification is required, please request a hard-copy version.

I saw this on Safari Version 16.3 (176<IP_ADDRESS>.4, 17614) on macOS Monterey
https://user-images.githubusercontent.com/9854/229006007-d8e5f767-0ddf-46cb-b8df-affb921e4021.mp4
As can be seen in the video, bold and italics are also not properly applied to the text selected.

I believe this is fixed. Feel free to re-open.


Fixes ring not applied to right side

Fix: #355

Hey @CorwinDev,
Thanks for the PR - when I focus/click on a tab there are no focus styles. Is this just local to me or is this what you want to apply? I think that the solution would be to keep the focus styles and state but make sure that it shows correctly regardless of which one is being focused.

Cheers,
Zoltan


Add hash/checksum/md5 to object info in REST API

Desired behavior
"https://fuel.ignitionrobotics.org/1.0/{username}/models/{model_name}"

The endpoint above provides metadata about the model at this endpoint, which is very cool. An example response may look like this:
Query: https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Construction%20Cone

{
  "createdAt": "2018-01-27T00:22:54Z",
  "updatedAt": "2021-08-05T16:56:43Z",
  "name": "Construction Cone",
  "owner": "OpenRobotics",
  "description": "An orange construction cone",
  "likes": 0,
  "downloads": 3710,
  "filesize": 622427,
  "upload_date": "2018-01-27T00:22:53Z",
  "modify_date": "2018-01-27T00:22:53Z",
  "license_id": 1,
  "license_name": "Creative Commons Zero v1.0 Universal",
  "license_url": "https://creativecommons.org/publicdomain/zero/1.0/",
  "license_image": "https://i.creativecommons.org/p/88x31.png",
  "permission": 0,
  "url_name": "",
  "thumbnail_url": "/OpenRobotics/models/Construction%20Cone/tip/files/thumbnails/1.png",
  "version": 2,
  "private": false
}

What would be very cool is to have it include some form of checksum (e.g. md5). This way a client can verify that nothing nefarious or unfortunate happened while downloading the model and that it is indeed the correct model.
My background is that I am currently writing unit tests for the fuel-support that I added to ropy's SDF bindings (see this forum discussion for a brief primer on the bindings: https://community.gazebosim.org/t/sdformat-data-bindings-for-python-all-sdf-versions/1054/4).
Currently, I download the file externally, compute the md5, and then download it again with ropy and compute that md5 to see if (a) it crashes, and (b) if it downloads the correct file. It would be nice (for server load and test speed) if this could be done with one call to the model info (much lighter) and one single download of the full model (by ropy).

I'll just drop a link here to the web server's source code, since this issue would probably be tackled there:
https://gitlab.com/ignitionrobotics/web/fuelserver

Thanks for the pointer @chapulina . I migrated the issue there. Should this one be closed in favor of the other?
Link: https://gitlab.com/ignitionrobotics/web/fuelserver/-/issues/9

Should this one be closed in favor of the other?

Yeah let's do that. Thanks!