outputcore: correctly use dev mode to apply configuration

encoders.BuildEncoder relies on the development bool argument to assess whether to apply our dev config for easier-to-read output. It looks like we no longer call BuildEncoder with anything except development: false - I don't recall what it used to be, but setting it to globallogger.DevMode() should fix it.
We can't place this in BuildEncoder itself because that would cause an import cycle between package encoders and globallogger.

Codecov Report

Merging #50 (28207f1) into main (b7a37de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   59.83%   59.83%
=======================================
  Files          15       15
  Lines         600      600
=======================================
  Hits          359      359
  Misses        220      220
  Partials       21       21

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


evaluate optimization for instanceof-interface

It might be possible to optimize ischecks if we know that the target is an interface and that all implementations of that interface are also derived from a common base class that implements such interface. For example in this code:
class I {}
class A implements I {}
class B extends A {}
class C extends B implements I {}

...
[new A(), new B(), new C()].forEach((x) => print(x is I));

We should be able to compile x is Ias x is A. That would allow us to tree-shake the interface entirely and possibly make the check more efficient.
/cc @rakudrama

In the above example we tell from the type hierarchy that testing an interface type is equivalent to testing an extended-only type. We can change all x is I to x is A and remove I from the program. The optimization works regardless of what is in the list.
I'd rather implement type test strength reduction on a per-check basis. The type hierarchy might not support the cheaper test, but we might know enough about x to know that a cheaper tests can be used.  If all tests reduce to a cheaper test then we have optimized out the demand for is I.
Is there something similar to be done with as I and type assertions? These produce errors containing the type name so a similar strength reduction would change the error message.


Error message when hold more than 30000 sockets

When I create more than 30000 sockets to connect to another machine, the connect action is successful.
when I try to close all sockets, the ans process would output like this
 Run ./build/app/ans -c 0x3 -n 1 -- -P -p 0 --config="(0,0,1)"
USER8: lcore 0 has nothing to do
USER8: LCORE[1] Close or shutdown tcp pcb failed, errno: 12
USER8: LCORE[1] Close or shutdown tcp pcb failed, errno: 12
USER8: LCORE[1] Close or shutdown tcp pcb failed, errno: 12
USER8: LCORE[1] Close or shutdown tcp pcb failed, errno: 12
USER8: LCORE[1] Close or shutdown tcp pcb failed, errno: 12
USER8: LCORE[1] Close or shutdown tcp pcb failed, errno: 12

When use multicore, output like this
./build/app/ans -c 0x1ff -n 1 -- -P -p 0 --config="(0,0,1),(0,1,2),(0,2,3),(0,3,4),(0,4,5)(0,5,6),(0,6,7),(0,7,8)"
USER8: LCORE[5] Getting tcp seg failed
USER8: LCORE[5] tcp_create_segment: no memory.
USER8: LCORE[5] Close or shutdown tcp pcb failed, errno: 12

Do you invoke anssock_close() or anssock_shutdown to close the fd?
You run so many lcore, so you shall update ans_main.c to increase the mbuf pool size.

If can't malloc mbuf from pool, will print error code 12 (NOMEM).
Please increase the mbuf pool size.
And share your detail test steps.

After I increase the mbuf pool size, It works fine. Thanks.
Maybe you treat the close of connection as a EPOLLIN event and would malloc a mbuf to store the data,
It confused me at first.

Yes, if remote send 'fin' to ANS, ANS will notify application via EPOLLIN event.

Could you please share the test result?

I want to verify whether I could use it to hold 1M connection, the result is OK.
Then I would test if it works OK when read and write on such a mount of connections, especially If it would block when do connect, read or write action.

Good.
What is your ENV?  CPU? NIC?
How many lcores are reserved for ANS?
How many hugepage are reserved?

I use Cenos6.5, kernel 3.18
CPU:Intel(R) Xeon(R) CPU E5-2620 0 @ 2.00GHz
NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01)
alloc 4 cores for ANS
4096 * 2MB hugepages, if increase the mbuf pool size, more hugepages needed.
Create 1M sockets and connect to another directly (without any router and switcher), cost about 8 minutes.

Alse there is a serious problem, the connect action would blocking, It must considered in high load environment.

Yes, anssock_connect() API is always block API, it block there to wait remote server reply.

Any result for your reading/writing case?


Repository links in the student view appear to be broken

It looks like the student view repository links to the Course info, 'Assignments', and -labs repositories aren't working anymore.

The reason for this:
Backend makes Repositries.URLs (map[string]string) with urls[repoType.String()] = repo.GetHTMLURL().
Frontend receives this in the following format:
repos:

["INFO"]: <URL>,
["ASSIGNMENTS"]: <URL>,
["USER"]: <URL>

However, it accesses the map with, for example, repo[Repository_Type.INFO]} and so on, which is repo[1] and does not exist in the map.

Seems like the appropriate fix for this would be something like:
message Repositories {
    map<Repository.Type, string> URLs = 1;
}

I guess this issue could be fixed in #942 as well, since they are related.

map<Repository.Type, string> URLs = 1;

Repository.Type won't compile because it is Enum, but, for example, uint32 works just fine.


Deprecated script MIME type not omitted on inline scripts

Deprecated MIME type not omitted on inline scripts:
<script type="text/javascript">alert("Hello");</script>

minifies to:
<script type=text/javascript>alert("Hello");</script>

should minify to:
<script>alert("Hello");</script>

https://validator.w3.org/ flags this as

Warning: The type attribute is unnecessary for JavaScript resources.

Thanks for the bug report and for the fix. It's fixed in version 4.3.0


Change Saturn table back - FAKE CHANGE

This is a comment

Another comment
Another comment
Another comment
Another comment
Another comment
Another comment

Another comment

Branch deployed to staging: http://staging.pds.seti.org/pull_requests/rf_240715_fake2


Set X-Frame-Options header

If no X-Frame-Options header is set, the control panel should set one to 'SAMEORIGIN'
Don't ask why :)

Added. This prevents an exception at the end of a sync when using Sitecore 8.1 update-3 and later.

Released in 3.3.1


Mosaicml logger robustness improvements

What does this PR do?
Mosaicml logger robustness improvements
What issue(s) does this change relate to?
CO-2408

Weren't people seeing runs crash due to mapi timeouts also?

I changed exception to be all exceptions instead of MapiExceptions


cannot translate com.annimon.stream

Cannot translate com.annimon.stream library, which provided stream and others java8 goodies back to java 6.
here is the build.gradle:
buildscript {
  repositories {
    maven {
      url "https://plugins.gradle.org/m2/"
    }
  }
  dependencies {
    classpath "gradle.plugin.com.github.j2objccontrib.j2objcgradle:j2objc-gradle:0.6.0-alpha"
  }
}

apply plugin: 'java'
apply plugin: "com.github.j2objccontrib.j2objcgradle"

repositories {
    mavenCentral()
}

dependencies {
    j2objcTranslation 'com.annimon:stream:1.1.2:sources'
}

j2objcConfig {
    // Include Java line numbers in Objective-C source files.
    translateArgs '-g'
    autoConfigureDeps true
    translateOnlyMode true
    minVersionIos '7.0'
    j2objcVersion '1.0.2'
    finalConfigure()
}

task wrapper(type: Wrapper) {
  gradleVersion = '2.8'
}

commands to to execute:
gradle wrapper
./gradlew build

output:
error: /tmp/sample/build/mainTranslationExtraction/com/annimon/stream/Optional.java:143: Type mismatch: cannot convert from Optional<capture#6-of ? extends U> to Optional<U>
error: /tmp/sample/build/mainTranslationExtraction/com/annimon/stream/Stream.java:1387: Type mismatch: cannot convert from Optional<capture#137-of ? extends T> to Optional<T>

thank you for any help :blush:

Can't help until you expand those errors. :-)
BTW, why bother transpiling this library? J2ObjC 1.2 was just released and supports java.util.stream and probably the other "goodies" you want.

Thank you for the quick response tom :blush:
I have to use my library in both iOS and Android, and ( AFAIK ) I cannot use java 8 on Android.
This is why I use that cute library.
I made a gist with the build output :wink:

You need to upgrade j2objc past 1.0.2 (1.2 is currently released). I just successfully translated the latest com.annimon.stream with 1.2:
$ git clone https://github.com/aNNiMON/Lightweight-Stream-API.git
Cloning into 'Lightweight-Stream-API'...
remote: Counting objects: 3523, done.
remote: Compressing objects: 100% (65/65), done.
remote: Total 3523 (delta 38), reused 0 (delta 0), pack-reused 3402
Receiving objects: 100% (3523/3523), 728.99 KiB | 804.00 KiB/s, done.
Resolving deltas: 100% (1442/1442), done.
Checking connectivity... done.
$ cd Lightweight-Stream-API/
$ j2objc -d /tmp/j2objc -sourcepath stream/src/main/java `find stream/src/main/java -name *.java`
translating stream/src/main/java/com/annimon/stream/AbstractSpinedBuffer.java
translating stream/src/main/java/com/annimon/stream/Collector.java
translating stream/src/main/java/com/annimon/stream/Collectors.java
translating stream/src/main/java/com/annimon/stream/Compat.java
translating stream/src/main/java/com/annimon/stream/Exceptional.java
translating stream/src/main/java/com/annimon/stream/function/BiConsumer.java
translating stream/src/main/java/com/annimon/stream/function/BiFunction.java
translating stream/src/main/java/com/annimon/stream/function/BinaryOperator.java
translating stream/src/main/java/com/annimon/stream/function/Consumer.java
translating stream/src/main/java/com/annimon/stream/function/Function.java
translating stream/src/main/java/com/annimon/stream/function/FunctionalInterface.java
translating stream/src/main/java/com/annimon/stream/function/IntBinaryOperator.java
translating stream/src/main/java/com/annimon/stream/function/IntConsumer.java
translating stream/src/main/java/com/annimon/stream/function/IntFunction.java
translating stream/src/main/java/com/annimon/stream/function/IntPredicate.java
translating stream/src/main/java/com/annimon/stream/function/IntSupplier.java
translating stream/src/main/java/com/annimon/stream/function/IntUnaryOperator.java
translating stream/src/main/java/com/annimon/stream/function/ObjIntConsumer.java
translating stream/src/main/java/com/annimon/stream/function/Predicate.java
translating stream/src/main/java/com/annimon/stream/function/Supplier.java
translating stream/src/main/java/com/annimon/stream/function/ThrowableConsumer.java
translating stream/src/main/java/com/annimon/stream/function/ThrowableFunction.java
translating stream/src/main/java/com/annimon/stream/function/ThrowablePredicate.java
translating stream/src/main/java/com/annimon/stream/function/ThrowableSupplier.java
translating stream/src/main/java/com/annimon/stream/function/ToDoubleFunction.java
translating stream/src/main/java/com/annimon/stream/function/ToIntFunction.java
translating stream/src/main/java/com/annimon/stream/function/ToLongFunction.java
translating stream/src/main/java/com/annimon/stream/function/UnaryOperator.java
translating stream/src/main/java/com/annimon/stream/IntPair.java
translating stream/src/main/java/com/annimon/stream/IntStream.java
translating stream/src/main/java/com/annimon/stream/LazyIterator.java
translating stream/src/main/java/com/annimon/stream/LsaExtIterator.java
translating stream/src/main/java/com/annimon/stream/LsaIterator.java
translating stream/src/main/java/com/annimon/stream/Objects.java
translating stream/src/main/java/com/annimon/stream/Optional.java
translating stream/src/main/java/com/annimon/stream/OptionalInt.java
translating stream/src/main/java/com/annimon/stream/PrimitiveExtIterator.java
translating stream/src/main/java/com/annimon/stream/PrimitiveIterator.java
translating stream/src/main/java/com/annimon/stream/RandomCompat.java
translating stream/src/main/java/com/annimon/stream/SpinedBuffer.java
translating stream/src/main/java/com/annimon/stream/Stream.java
Translated 41 files: 0 errors, 0 warnings
$ j2objcc -c -I. `find com -name *.m`

oh, thank you for your time Tom, I kept the old version as I have Xcode 6 and manually built j2objc for iOS.
I'll upgrade to version 1.2 then :blush:
Sorry for being so silly :sweat:


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter alexa-timer-vis for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.alexa-timer-vis
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for text at admin/jsonConfig.json/items/_options/unitHour3
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for text at admin/jsonConfig.json/items/_options/unitMinute3
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for text at admin/jsonConfig.json/items/_options/unitSecond3
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for text at admin/jsonConfig.json/items/_options/valHourForZero
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for text at admin/jsonConfig.json/items/_options/valMinuteForZero
[ ] :heavy_exclamation_mark: [E510] responsive check: maximum issues reached, please fix reported ones and recheck

:thumbsup: No warnings found
:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Sat, 09 Nov 2024 18:58:29 GMT based on commit bc1468941f5e8fd7c41273fd95327907a91e73de
ioBroker.repochecker 3.2.2

@iobroker-bot recheck


feat: stringify dataset column contents during data loading

Issue #, if available:
Description of changes:
Currently, the JSON parsing code extracts raw data from the input dataset using user-provided JMESPath expressions. This raw data can be of any data type, such as booleans, floats, etc.
This PR adds code that converts the raw extracted data into strings, so that the final Ray Dataset that is produced contains only string data.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @danielezhu ! Just got a question. Will this convert any field of the dataset into a string?
If so, I would strongly recommend against it.
We should only convert fields that are required to be strings by the eval algorithms (most notably input and targets, if present).

Luca raised a good point about not casting every column. It is clear why we shouldn't do this if we consider the log probability columns. I will update this PR after Luca sends me the list of columns that should be converted to strings, and those that should not.

However I have another question. Can in principle be the fields also lists? like having a list of target output(s) ? Or do we prohibit this?


test: Forge::addColumn() and null

Needs #7301
Description
See #7235

add test for Forge::addColumn() and null

Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Rebased to resolve conflicts.

This PR just adds test for the current implementation.
Merge.


make input arg positional, add -o/--output-file option

This adds a new -o/--output-file CLI flag to tell fontc where to save the output file. It keeps defaulting to the existing build/font.ttf like before (we may want to change that to use, say, the font's postscript name e.g. Oswald-Regular.ttf, so one could build more than one font in the same default build directory without overwriting them? but that's a separate issue).
Also, I changed so that the input source is a positional argument, but I didn't want to break existing usages of -s/--source option so I kept the latter and made them two methods mutually exclusive, and require at least one of the two is not None before the final Args can be constructed.
So the old way of calling fontc continues to work (e.g. fontc --source Oswald.glyphs or fontc -s Oswald.glyphs), but now you can simply do fontc Oswald.glyphs -o Oswald.ttf which looks nicer. Or even fontc -o Oswald.{ttf,glyphs} :)

another thing to note is the build directory is only created if we are doing incremental builds (to save the IR files) or if the user didn't provide an explicit --output-file, because we want to continue saving our build/font.ttf in the same old location so we need the build/ directory.
Otherwise, if one doesn't do incremental (which is now disabled by default) and has provided an explicit output file, then no build directory is required and all is done in memory.


Having SkewFit deal with stochastic environments

Hi,
The environment I'm applying SkewFit over has changing background colors that change upon the environment's reset, meaning naively sampling goals from the VAE doesn't really work here. I changed the goal sampling mode in sawyer_push.py from "vae_prior" to "env" to make stochastic environments work, but it doesn't seem to ever start training. I've changed the number of eval/expl steps to be very low, but it seems to still never really start. Is directly sampling goal images from the environment not quite supported?

I recommend using presampled goals in that case. Sampling from the env is extremely slow when you use images (there should be a warning about it). The door example is an example.  Let me know if this makes sense and I can look into adding an example of this

Thanks for the response! I actually experimented exactly with what you said using the presampled goal methods you have in open door/pick and place, but the VAE reconstructions were very poor despite many things I tried, so I'm in the middle of swapping the online VAE implementation with a pre-trained loading. Not sure if it would be helpful for users to want to use a pre-trained VAE (it should at least be much more stable), but let me know if it's worth pushing to the repo.


Basic C-Program added - (Entered character is an alphabet/not)

Mark it as Hacktoberfest-accepted

PR accepted @MuhammadNoorani
Successfully merged to HacktoberFest_22 repo.
🚀🚀👍


[Request] Possible to make it Responsive ?

This is a great and beautiful theme - however I would like to know if it can be made to work on mobiles too (smartphones) since right now the current settings are not optimal for displays on such screens.

Just mention, there are 2 great apps available f.e. in playstore that work well on phone and tablet.

which apps do you recommend ?
On Friday, January 6, 2017, smartshogu<EMAIL_ADDRESS>wrote:

Just mention, there are 2 great apps available f.e. in playstore that
work well on phone and tablet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci5.googleusercontent.com/proxy/SX51gQNTbc7JFwbLiTpgHG_Bd7R7fb0xhGVj7nFFhJAXaK6iMhfaFexBA_cCH3je6wgPBuO0TK8NUWmEuDF4gaB_3gBvROYyzvfWPPRiGlAqYfdo4ekln6UUJhakugw73w1_4aPY9PqjC4siMwaWLQHFBscwwQ=s0-d-e1-ft#https://github.com/notifications/beacon/ACWMmPnj_QCbnWw8PCLMyeChtxC8rLiPks5rPfwWgaJpZM4LcgEc.gif

--
Raphael

they are called ttrss. the pay app from andrew dolgov is the best. have fun.

Hi @ekianjo, unfortunately it's not so easy as it should be. It's because Tiny Tiny RSS uses Dojo for the UI. Dojo does all the layout stuff, so it's hard to override with a theme. Also, Dojo widgets are not very touch-friendly and can't be replaced with a theme.
I personally use News+, with a Tiny Tiny RSS plugin:
https://play.google.com/store/apps/details?id=com.noinnion.android.newsplus
https://play.google.com/store/apps/details?id=com.noinnion.android.newsplus.extension.ttrss
It hasn't been updated for a while but still works well for me.

I'd avoid recommending News+... it is abandonware and has some big bugs (including ones that specifically hamper TT-RSS functionality, even with the ttrss plugin). I found it totally unreliable when it came to syncing because of some of these bugs.

I just tested a few apps and I agree, the official app seems to be the best option right now.


Nested model in settings required even when all fields have defaults

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
When a sub-model in a BaseSettings class contains defaults for all fields, the settings class still requires at least one of the fields to be passed when instantiating it.
Example Code
from pydantic import BaseModel, BaseSettings

class SubModel(BaseModel):
    field_with_default: int = 0

class SettingsModel(BaseSettings):
    sub_model: SubModel

SettingsModel()  # raises error for sub_model, would expect a model with the default to be generated

Python, Pydantic & OS Version
pydantic version: 1.9.1
            pydantic compiled: True
                 install path: C:\Users\miso1\.virtualenvs\random310\Lib\site-packages\pydantic
               python version: 3.10.7 (tags/v3.10.7:6cc6b13, Sep  5 2022, 14:08:36) [MSC v.1933 64 bit (AMD64)]
                     platform: Windows-10-10.0.19043-SP0
     optional deps. installed: ['typing-extensions']

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

ye, you haven't set a default. Try sub_model: SubModel = {} or similar.


RequestMapping.value can be empty at class level

It fixes #218

This doesn't make any sense... this is the same pull request than #340 and now fails all the test. How can this be possible?


Missing DialogPrimitive.Portal in Dialog demos

Hi, I'm new to the library, I was learning how to use radix + tailwind and discovered an issue with the dialog demo.

There is a side effect when using flex + gap because the Transitions aren't wrapped with DialogPrimitive.Portal component.
<DialogPrimitive.Root open={isOpen} onOpenChange={setIsOpen}>
      <DialogPrimitive.Trigger asChild>
        <Button>Click</Button>
      </DialogPrimitive.Trigger>
      <DialogPrimitive.Portal> // <---- Here!
          <Transition.Root show={isOpen}>
            <Transition.Child
              as={Fragment}
              enter="ease-out duration-300"
              enterFrom="opacity-0"
              enterTo="opacity-100"
              leave="ease-in duration-200"
              leaveFrom="opacity-100"
              leaveTo="opacity-0"
            >

Thank you for the library, and the demos are fantastic!

Good to know, I'll update the examples (you might need the forceMount prop when using the Transition)


fix(material/datepicker): change calendar cells to buttons

Makes changes to the DOM structure of calendar cells. Previous, the DOM
structure looksed like this
Existing DOM structure of each calendar body cell

</>

Using the gridcell role allows screenreaders to use table specific
navigation and some screenreaders would announce that the cells are
interactible because of the presence of aria-selected. However, some
screenreaders did not announce the cells as interactable and treated it
the same as a cell in a static table (e.g. VoiceOver announces element
type incorrectly #23476).
This changes the DOM structure to use buttons
inside of a gridcell to make it more explicit that the table cells can
be interacted with and are not static content. The gridcell role is
still present to table navigation will continue to work, but the td
elements are now buttons. The gridcell wrapper is only for adding
information to the a11y tree and not used for visual purposes.
Updated DOM structure:

  </>
<button>

I also tried another approach of keeping the  as a
gridcell, and rendering a button inside of it. This turned out to be
much more complicated with getting the keyboard navigation and focusing
logic to work correctly. It also make writing the tests more complicated
because tests need to know if they should select the body cell or the
button nested inside of it. This approach also avoids interferring with
the styles.
Fixes #23476

Here's the first approach I tried, which is not working: https://github.com/angular/components/pull/24099

Although this seems to work when I tested with VoiceOver screenreader, closing this because it's unfortunately invalid HTML. I'll try another way and open a new PR.


[BUG] - Get-PnPTenantSite - CommentsOnSitePagesDisabled always returns FALSE

Reporting an Issue or Missing Feature
When fetching all sites via Get-PnPTenantSite, the field CommentsOnSitePagesDisabled always returns FALSE. That is incorrect.
Expected behavior
When pulling all sites via Get-PnPTenantSite the field CommentsOnSitePagesDisabled field returns the proper value of TRUE or FALSE.
Actual behavior
When fetching all sites via Get-PnPTenantSite, the field CommentsOnSitePagesDisabled always returns FALSE. That is incorrect.
Steps to reproduce behavior
When fetching all sites via this command, and exporting the data to a CSV the field CommentsOnSitePagesDisabled always returns FALSE. That is incorrect.
$allSites = Get-PnPTenantSite
$allSites | Export-CSV -Path "\csv\allSites.csv" -Force
When fetching individual sites via this command and exporting to CSV, the field CommentsOnSitePagesDisabled returns the proper value TRUE or FALSE. That is correct.
$allSites = Get-PnPTenantSite
$allSites | ForEach-Object {
Get-PnPTenantSite -Identity $_.Url | Export-CSV -Path '\csv\DataValidation.csv' -Append
}
What is the version of the Cmdlet module you are running?
2.2.0
Which operating system/environment are you running PnP PowerShell on?

[X] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Hi,
Have you tried the -Detailed parameter? Without this, some attributes will show default values that may not be correct.
Get-PnPTenantSite

Yes. In both cases the column was included, and all values returned FALSE.
On Wed, Feb 14, 2024 at 2:52 PM Aimery Thomas @.***>
wrote:

Hi,
Have you tried the -Detailed parameter? Without this, some attributes
will show default values that may not be correct.
Get-PnPTenantSite
https://pnp.github.io/powershell/cmdlets/Get-PnPTenantSite.html#-detailed
—
Reply to this email directly, view it on GitHub
https://github.com/pnp/powershell/issues/3755#issuecomment-1944572132,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMJ2HNIKWS2ZIMYBMV3AWTYTUPYXAVCNFSM6AAAAABDIU6UBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUGU3TEMJTGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Can you please try a newer version of the module?
I am on 2.3.36 and everything works fine for my tenant:
PS >$ts = get-pnptenantsite  https://contoso.sharepoint.com/sites/t2
PS >$ts.CommentsOnSitePagesDisabled
False
PS >$tss = get-pnptenantsite
PS >$t = $tss.Where({$_.Url -eq "https://contoso.sharepoint.com/sites/T2"})
PS >$t.CommentsOnSitePagesDisabled
False
PS >set-pnptenantsite  https://contoso.sharepoint.com/sites/t2 -CommentsOnSitePagesDisabled
PS >$ts = get-pnptenantsite  https://contoso.sharepoint.com/sites/t2
PS >$ts.CommentsOnSitePagesDisabled
True
PS >$tss = get-pnptenantsite
PS >$t = $tss.Where({$_.Url -eq "https://contoso.sharepoint.com/sites/T2"})
PS >$t.CommentsOnSitePagesDisabled
True

I got different results. I tried it with 2.3.0 and the same issue is
present.  Also tried with 2.3.56 nightly build and the same issue is there
as well.
I did force the proper minimum version on PnP when using the Import-Module
command.
Try piping the results to a CSV export just as I have described.
On Wed, Feb 14, 2024 at 4:10 PM Konrad K. @.***> wrote:

Can you please try a newer version of the module?
I am on 2.3.36 and everything works fine for my tenant:
PS >$ts = get-pnptenantsite  https://contoso.sharepoint.com/sites/t2
PS >$ts.CommentsOnSitePagesDisabled
False
PS >$tss = get-pnptenantsite
PS >$t = $tss.Where({$.Url -eq "https://contoso.sharepoint.com/sites/T2"})
PS >$t.CommentsOnSitePagesDisabled
False
PS >set-pnptenantsite  https://contoso.sharepoint.com/sites/t2 -CommentsOnSitePagesDisabled
PS >$ts = get-pnptenantsite  https://contoso.sharepoint.com/sites/t2
PS >$ts.CommentsOnSitePagesDisabled
True
PS >$tss = get-pnptenantsite
PS >$t = $tss.Where({$.Url -eq "https://contoso.sharepoint.com/sites/T2"})
PS >$t.CommentsOnSitePagesDisabled
True
—
Reply to this email directly, view it on GitHub
https://github.com/pnp/powershell/issues/3755#issuecomment-1944778199,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMJ2HKZDGUBSPJ3I5BC7RTYTUY6RAVCNFSM6AAAAABDIU6UBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUG43TQMJZHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I was able to reproduce the issue.
It looks like the problem is in CSOM, not PnP.PowerShell module.
Method GetSitePropertiesFromSharePointByFilters from class Microsoft.Online.SharePoint.TenantAdministration.Tenant is always returns CommentsOnSitePagesDisabled='false', whereas GetSitePropertiesByUrl method from that same class returns proper values.
I think it would be best if CSOM would fix this, as any methods to fix the value on the fly in the cmdlet may result in poor performance (especially for tenants with a large number of sites).

hi @robertcaretta , as @wilecoyotegenius  mentioned this is a server side issue.
We display whatever value is returned by the API.
Wont be able to fix this in PnP PowerShell, you would need to raise one MSFT support ticket for this. Only MSFT can fix this.
As mentioned in above comment, specifying the Identity parameter does help in getting accurate values. If not specified, it uses a different method which returns inaccurate data in some cases.
Closing this as by we can't do anything.

For anyone that finds this, I posted a thread to the SharePoint feedback forum. I didn't feel this merited a support ticket.
https://feedbackportal.microsoft.com/feedback/idea/2062c8f6-0ccc-ee11-92bd-000d3a7a5824


Add user id to share recipient object in dataset details output.

Curious where you are getting the basic user info (firstName, lastName, org). In the future, that should only be available via a separate request to the OAuth server.

We are querying AccountDB for them at the moment, so when the OAuth server goes live we will need to somehow get this info from that server.  It's going to be painful though because right now we are doing bulk queries for the user details.


Research for integration of Python driver with networkx

networkx is one of well-known library for working with graphs in python. Our goal is to integrate networkx with AGE and bridge both open source tool. This will provide more liberty to developers working with Python and AGE to perform in-depth graph\ analytics.

This is cool @muhammadshoaib . . . I'm doing the same with drivine.org in NodeJS. You can then use this lib to build a higher level of abstraction, eg a GraphQL library that leverages the GraphDB to reduce boilerplate (generate all the CRUD), for example.

Is this feature implemented or is currently under process?


HDF5 nav_shape reshaping and sync_offset

This adds HDF5DataSet nav_shape reshaping and sync_offset, which respond partially to #441 .
As I mentioned there, because the navigation dimension is always flat in LT (internally) it's quite easy to let the DataSet display one shape to the rest of the architecture while treating the array in the file as having a different shape. This code does not touch anything related to choice of partition size, chunking, tileshape etc, essentially it just changes the shape we use when reshaping flat result buffers into final results.
sync_offset and reshaping into a different size nav space are also supported by adjusting the positions of partitions relative to the underlying slice_nd which access the hdf5 data.
sig_shape reshaping will be quite a lot more complicated to implement as we have to constrain tile shapes to be compatible under reshaping (and handle corrections). It might not be so hard when the array on disk has a flat signal dimension as if we constrain tiles to occupy full 'sig-reshaped rows' (in-nD) then any reshape from the flat form to a tile is valid.
If this is something we want to include then I would need to add the nav_shape option in the web interface too, before merging.
Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[x] I have added a changelog entry for my contribution
[x] I have added/updated documentation for all user-facing changes
[x] I have added/updated test cases
[x] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed
[x] No import of GPL code from MIT code

That would be great. Maybe the parameter form component for reshaping then needs to be configured to not show or disable the offset and sig_shape parts. Let me know if you need help with that!

Disabling certain inputs is within my TS-fu, but what I can't currently work out is how to update or clear the values of, say, nav_shape if I change the selected HDF5 dataset (i.e. in response to changing the dropdown). It would be nice if (where possible) the values update to the defaults for the chosen dataset (or were blanked if not possible), but I can't see a setter (only the setter from field to values that get sent back to Python).

I think the idea behind sig reshaping is mostly completeness (support for any ND reshape, if possible) and having a symmetric and consistent API.

As an aside, do we (generally) expect to be able to support setting a shape which doesn't match the underlying data size ? e.g. nav_shape (10, 10) in an on-disk dataset of 110 frames, with (optionally) a sync_offset to choose where the 100 desired frames come from? The implementation here requires the detected nav_size and desired nav_size are identical, and sync offset is applied as normal (as shifting before/beyond the full space).

/azp run libertem.libertem-data

Some observations:

the HDF5DataSet accepts a min_num_partitions argument, but I don't think the value is used anywhere in the codebase
We only support frame-by-frame processing when using an ROI. I don't see why this is the case necessarily (though I'm not volunteering to change it right now! :D )
With this change I've removed a call to io.dataset.base.roi._roi_to_nd_indices, leaving only one call in the whole codebase at io.dataset.base.coordinates.get_coordinates

/azp run libertem.libertem-data

/azp run libertem.libertem-data

I think the web client support is now complete, we have the Reshapecomponent on the HDF5 page, a customValidation function which will reject a sig_shape not matching the dataset native sig shape, and the form fields now update with the ds_path dropdown.
I haven't enable the sync_offset / frame info display part of the Reshape component, as I think making it update correctly with the dropdown box will require some new plumbing (it's not a Formik field that I can see).
Obviously we'll need to test this manually for the release. Here I generated some dummy files with multiple arrays of various shapes and they all seem to work as expected, but there are a lot of combinations to look through!
@sk1p if you could take a quick look at the TS that would be appreciated!


Connectors: Clear up confusing documentation

The example source here doesn't make much sense...
Let's fix that!
Issues addressed:

What MongoDBConnector is doing behind the scenes is extremely vague

provide a snippet for the mongoDB connector
demonstrate cohesive usage of the connector in the Author model

Author model's constructor arguments in step 3, do not match those passed during its' instantiation on step 4

Commit to the approach in step 3
Update the resolver function in step 4 to reflect this change

TODO:

[ ] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
[ ] Make sure all of the significant new logic is covered by tests
[ ] Rebase your changes on master so that they can be merged easily
[ ] Make sure all tests and linter rules pass
[ ] Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

This is a great change thank you!


Refactor buffer to use DTypePointer

DTypePointer currently still uses LegacyPointer underneath but I imagine they will refactor in the future. And later we might have to migrate to UnsafePointer once all the functionality is available.

Thanks for the PR! Could you please describe the benefits of using DTypePointer vs Legacy or UnsafePointer?

Thanks for the PR! Could you please describe the benefits of using DTypePointer vs Legacy or UnsafePointer?

UnsafePointer doesn't have the alignment functionality as you pointed out in your PR on the Mojo repo that solved it.
LegacyPointer is getting deprecated.
DTypePointer is made to be able to be used with SIMD. DType defines the MLIR dialects that Mojo supports and is used to define the Scalars that exist in the Mojo language.

Sounds good - congrats on having your first PR merged!


Referencing elements inside XML

How can I reference a sibling by its name inside an xml file? Let's say I'd like to have a couple of buttons aligned vertically. For now I found that I can only use top attribute with value relative to the elements parent (thus making it bigger the lower I want my button to go).
Can I somehow write an expression that I want my current button have vertical spacing of 8pt to the button before it?

You can reference properties of the previous or next siblings using previous and next respectively. So to position a button 8pts below the previous element, you'd say:
<UIButton top="previous.bottom + 8"/>

If there is no previous sibling, previous.bottom will be zero.

This works. Thanks!

Can we use the outlet property to reference the layout node  My use case is that I want a layout which is similar to the below layout.
[Label]

Some Text Lorem ipsum dolor sit amet, ut eos dicta malorum detracto, eruditi sensibus vix in, oblique
      [View]

The view start should be aligned to the end of the label. Instead of traversing the previous node, referencing by an identified would be a better option.

This is not currently possible, although I’m working on a solution. Using previous.previous.right should work for now, although I agree it’s not ideal.

I ended up doing it. Thanks for confirming.

@silentninja I've put up a PR for referencing nodes by ID, so that should be included in the next release: https://github.com/schibsted/layout/pull/61


Not valid rust error from stubgen

Running stubgen on this schema throws:
thread 'main' panicked at 'not valid Rust: Error("expected expression")', /home/u9g/.cargo/registry/src/index.crates.io-6f17d22bba15001f/trustfall_stubgen-0.2.0/src/root.rs:130:70
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Yeah, it doesn't do any escaping yet. The schema has an edge named type which is a Rust keyword and causes a parse error when generating the adapter code.
I need to add escaping, but to get you unblocked in the meantime — rename the edge to type_ and it should generate a valid adapter. Then you can keep the module name as type_ etc. but change the edge name back.


Removed May folder because this API version is not published

Removed extra-folder to avoid customers' confusion according to the discussion with @dsgouda

Will merge on CIs passing

Automation for azure-sdk-for-node

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

@lmazuel  @dsgouda looks like github/travis lies to us - all checks are passed.


Implemented the method : getTimeBefore(Date beforeTime)

Implemented the method : getTimeBefore(Date beforeTime) in CronExpression.java

Hello @CShawn thank you so much for interested in Quartz project and providing this PR. Sorry it took us so long to respond!
As you have noticed that this PR actual duplicate the work already submitted in #148. Given the other PR has less redundant code, we will close this PR and proceed to work on other PR instead.
Again, thank you for your contribution!


0.3.0

This version is maintained here: https://github.com/ducdigital/money.js
Feel free to give comment, add more tests and new feature in a PR.
In this version all API of money.js remain the same but introduce new features to this project.
Change Log
0.3.0

Factory for money.js. Allow create multiple instance of money.js in the same app. Thanks @starsirius: (https://github.com/starsirius/money.js/commit/a736a83912d7f62f360f8d623c785f148e8f50d4). For: #25
Proper error message instead of showing fx error. Thanks @sliptree:  (https://github.com/sliptree/money.js/commit/c76476456f1acef18c0b2441d36de3f55ae3650b). For: #24
Unit test. Inpired by (@PierrickP) (https://github.com/PierrickP/money.js/commit/b2b5e32b2b0cbf13a334e4590b3ac2356c545b89). For: #14
Expose fx.getRate(to, from) allow getting rate from any 2 currencies. Inspired by (@thewarpaint): (https://github.com/thewarpaint/money.js/commit/85eed2df55c3022ac6fe7fe83911ecf2a2b8a25d). For: #4
Fix small bug cause value not passed to getRate()

:+1:

Hi @ducdigital!
This PR looks so promising.
Multiple instance support is definitely needed.
What stops it from being merged?
Is there anything I can do to help?

Bump. Is this project abandoned?

Hi there @asfktz and @jsw
I am just contributing to this opensource project and have no right to merge this branch to master.
If you use it, just use git format in your package.json like ff:
    "money": "github:ducdigital/money.js",

It seems like the PR is not gonna get merge anytime soon.

Hi, @ducdigital!
How about releasing it as an NPM package?
Something like money2 sounds good to me 😊


Fine-tune InternVL2 using SFTTrainer from hugging face

Is the fine-tuning of InternVL supported by hugging face SFTTrainer?
I got the following error when using the SFTTrainer:

model = AutoModel.from_pretrained(
            "OpenGVLab/InternVL2-8B",
            device_map="auto",
            torch_dtype=torch.float16,
            trust_remote_code=True
)

tokenizer = AutoTokenizer.from_pretrained(
        "OpenGVLab/InternVL2-8B",
        trust_remote_code=True
    )

trainer = SFTTrainer(
        model=model,
        args=training_arguments,
        train_dataset=train_dataset,
        dataset_text_field="text", # dummy field
        data_collator=collate_fn,
        max_seq_length=args.max_seq_length,
        tokenizer=tokenizer,
        peft_config=peft_config,
        packing=args.packing,
        dataset_kwargs={"skip_prepare_dataset": True},
   )

The issue is probably related to model.language_model.get_input_embeddings() from this issue, but I'm not sure how to fix this here.
Traceback (most recent call last):
  File "/home/lytang/MMCheck/sft.py", line 306, in <module>
    trainer = SFTTrainer(
  File "/data/users/lytang/miniconda3/envs/MM/lib/python3.10/site-packages/huggingface_hub/utils/_deprecation.py", line 101, in inner_f
    return f(*args, **kwargs)
  File "/data/users/lytang/miniconda3/envs/MM/lib/python3.10/site-packages/trl/trainer/sft_trainer.py", line 268, in __init__
    model = get_peft_model(model, peft_config)
  File "/data/users/lytang/miniconda3/envs/MM/lib/python3.10/site-packages/peft/mapping.py", line 179, in get_peft_model
    return PeftModel(model, peft_config, adapter_name=adapter_name, autocast_adapter_dtype=autocast_adapter_dtype)
  File "/data/users/lytang/miniconda3/envs/MM/lib/python3.10/site-packages/peft/peft_model.py", line 164, in __init__
    model = self._prepare_model_for_gradient_checkpointing(model)
  File "/data/users/lytang/miniconda3/envs/MM/lib/python3.10/site-packages/peft/peft_model.py", line 613, in _prepare_model_for_gradient_checkpointing
    model.enable_input_require_grads()
  File "/data/users/lytang/miniconda3/envs/MM/lib/python3.10/site-packages/transformers/modeling_utils.py", line 1761, in enable_input_require_grads
    self._require_grads_hook = self.get_input_embeddings().register_forward_hook(make_inputs_require_grads)
  File "/data/users/lytang/miniconda3/envs/MM/lib/python3.10/site-packages/transformers/modeling_utils.py", line 1780, in get_input_embeddings
    raise NotImplementedError
NotImplementedError

Hello, we are using the Trainer from the transformers library for fine-tuning in our code. Could you please explain why the SFTTrainer is being used instead?
https://github.com/OpenGVLab/InternVL/blob/main/internvl_chat/internvl/train/internvl_chat_finetune.py#L816

I see. I was using SFTTrainer since I previously trained LLMs with it, so I'm wondering how to minimally change the code to enable SFTTrainer for InternVL.
Another thing I found is that there is no apply_chat_template implemented for InternVL, which makes it not easy to integrate it to the code base with other models having apply_chat_template defined. Are you planning to add the apply_chat_template function to InternVL? Thanks!


WIP : Finagle backend

👍

Released in 2.0.0-RC5. Thanks!

Released in 2.0.0-RC5. Thanks!

Thanks @adamw ! I wanted to add some documentation as well - https://github.com/softwaremill/sttp/pull/380


Update to grants dashboard

Change "Grants" to "Your Grants"
Add Subtitle to Grants that reads "Your grant records come from Johns Hopkins grant management system, COEUS. If you find any issue with these grant records, please contact us  "

Link "contact us" to contact page


Crash in Sentry after Code Push restart [iOS]

OS:

[ ]  Windows
[x]  MacOS
[x]  Linux

Platform:

[X]  iOS
[ ]  Android

Output of node -v && npm -v && npm ls --prod --depth=0
Node - v8.2.1
Yarn - 0.47.5

├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>
Config:
<EMAIL_ADDRESS>{
   deactivateStacktraceMerging: true,
}).install()

I have following issue:
We have seen the following crash in production. It occurs after a code push restart, we were thinking maybe Sentry is holding on to a reference?
Crashed: io.sentry.RNSentry
0  libobjc.A.dylib                0x189018bb4 objc_loadWeakRetained + 156
1  Example                     0x100246d70 facebook::react::RCTNativeModule::invokeInner(unsigned int, folly::dynamic const&&) + 109060
2  Example                     0x100246c94 ___ZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEi_block_invoke + 108840
3  libdispatch.dylib              0x1894529e0 _dispatch_call_block_and_release + 24
4  libdispatch.dylib              0x1894529a0 _dispatch_client_callout + 16
5  libdispatch.dylib              0x189460ad4 _dispatch_queue_serial_drain + 928
6  libdispatch.dylib              0x1894562cc _dispatch_queue_invoke + 884
7  libdispatch.dylib              0x189460fa8 _dispatch_queue_override_invoke + 344
8  libdispatch.dylib              0x189462a50 _dispatch_root_queue_drain + 540
9  libdispatch.dylib              0x1894627d0 _dispatch_worker_thread3 + 124
10 libsystem_pthread.dylib        0x18965b100 _pthread_wqthread + 1096
11 libsystem_pthread.dylib        0x18965acac start_wqthread + 4

Sorry we don't have any more useful information, any help would be useful.

Looks very similar to https://github.com/getsentry/react-native-sentry/issues/228
We will try the fix.

@AndrewJack Are you sure that Sentry is the cause of the crash?
I fixed a bug in the latest version regarding a similar crash, but only if stack trace merging is active.

@HazAT This may be a code push issue. Crashed: io.sentry.RNSentry could just be a result of another issue. I still see this issue after disabling the sentry native library.

OK, I will close this now. I've also updated the docs about CodePush since it wasn't complete.
https://docs.sentry.io/clients/react-native/codepush/


Hex color getting converted to RGB while rendering

I'm using vue3 on our email builder since some email clients don't support RGB/RGBA I will need to use HEX code but it seems vue3 convert Hex code to RGB while rendering
Version
3.0.5
Reproduction link
https://codesandbox.io/s/sad-cherry-vy3tr?file=/src/App.vue
Screenshot:

Steps to reproduce
Just write an inline CSS color using hex code, it will render RGB color instead of rendering original hex
What is expected?
#ffffff
What is actually happening?
rgb(255, 255, 255)

see https://developer.mozilla.org/en-US/docs/Web/CSS/color

If the value is translucent, the computed value will be the rgba() corresponding one. If it isn't, it will be the rgb() corresponding one. The transparent keyword maps to rgba(0,0,0,0).

Meaning that no matter what is your input, the computed value always results in either rgb or rgba.
document.getElementById('xxx').style.color = "#f66";
this also will be convert to RGB.

see https://developer.mozilla.org/en-US/docs/Web/CSS/color

If the value is translucent, the computed value will be the rgba() corresponding one. If it isn't, it will be the rgb() corresponding one. The transparent keyword maps to rgba(0,0,0,0).

Meaning that no matter what is your input, the computed value always results in either rgb or rgba.
document.getElementById('xxx').style.color = "#f66";
this also will be convert to RGB.

@edison1105 Thanks for the Information.

@edison1105 Thanks for the Information.

maybe you can use color name instead hex-color: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value

maybe you can use color name instead hex-color: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value


Get App Approved

Need to get Google app approved so that "unsafe" warning doesn't appear.
Need a privacy policy to make this happen.

Duplicated by #7


Created a new file with my two Trinkets.

@eah13 don't merge this branch yet, I need to add my reflection

Roger that.


typeahead: Fix stream+topic completions for empty query.

Fixes #16599 .
I'm not sure whether I have to add any tests for this as I dont see any topic completion tests under content_typeahead_selected in node_tests/composebox_typeahead.js.

@ryanreh99 @aero31aero I'd really like to integrate this because the bug it fixes is pretty nasty; can you both spend some more time on it?

Sure! I'm debugging this right now. Re: the test, we should add a test like:
    // topic_list
    fake_this.query = "Hello #**Sweden>test**";
    fake_this.token = "test";
    actual_value = ct.content_typeahead_selected.call(fake_this, ['testing']);
    expected_value = "Hello #**Sweden>testing** ";
    assert.equal(actual_value, expected_value);

@ryanreh99 for tests, you can add this block:
diff --git frontend_tests/node_tests/composebox_typeahead.js frontend_tests/node_tests/composebox_typeahead.js
index e3cdba609a..86aaa31e77 100644
--- frontend_tests/node_tests/composebox_typeahead.js
+++ frontend_tests/node_tests/composebox_typeahead.js
@@ -481,6 +481,21 @@ run_test("content_typeahead_selected", () => {
     expected_value = "#**Sweden** ";
     assert.equal(actual_value, expected_value);

+    // topic_list
+    fake_this.completing = "topic_list";
+
+    fake_this.query = "Hello #**Sweden>test";
+    fake_this.token = "test";
+    actual_value = ct.content_typeahead_selected.call(fake_this, 'testing');
+    expected_value = "Hello #**Sweden>testing** ";
+    assert.equal(actual_value, expected_value);
+
+    fake_this.query = "Hello #**Sweden>";
+    fake_this.token = "";
+    actual_value = ct.content_typeahead_selected.call(fake_this, 'testing');
+    expected_value = "Hello #**Sweden>testing** ";
+    assert.equal(actual_value, expected_value);
+
     // syntax
     fake_this.completing = "syntax";

@ryanreh99 for tests, you can add this block:

Thanks for the help.
I left the conditional to point out this special case.
@timabbott updated this.

Merged as b38cbc8f34d9a4da55bb388ae0c072ec9985749d, thanks everyone!


enhancement: better diff for result mismatch

We use space as separator for actual, but expected might use tab. This can look bad.
This can be tricky since we support custom validator.
https://github.com/risinglightdb/sqllogictest-rs/blob/27eb9f50993e10b36c1f4f68ad3afe499adbbb49/sqllogictest/src/runner.rs#L749-L759

Here's an example from @BugenZhao
https://github.com/risingwavelabs/risingwave/pull/9671#issuecomment-1542102712

Maybe we can:

change validator to sth like normalizer and output normalized results.
Output normalized output if default_validator is used.

I'm curious what's the use case for validators? 👀

Original added by @Xuanwo  https://github.com/risinglightdb/sqllogictest-rs/pull/15
As indicated by its signature, the actual result is separated by columns Vec<Vec<String>>, but the expected result is not. So we need to normalize the results. validator is the most flexible form to achieve this, but not sure if it's really needed.
https://github.com/risinglightdb/sqllogictest-rs/blob/27eb9f50993e10b36c1f4f68ad3afe499adbbb49/sqllogictest/src/runner.rs#L411-L426

I think we can parse both space and tab as separator in parser?

Okay well this is not handled by parser. Then it might be a good idea to split by both space and tab in default validator :(


Provide output of task_role_name

I had to add an IAM policy to the task execution role for the ECS task definition in order to give it permission to GetParameters from the SSM parameter store.  In order to do this via Terraform I needed to reference the role that your terraform-aws-atlantis module creates.  I wasn't sure how to do it other than to fork the code and create an output that did this, and then reference it in my module that wraps terraform-aws-atlantis:
output "task_role_name" {
  description = "The Atlantis ECS task role name"
  value       = "${aws_iam_role.ecs_task_execution.name}"
}

Would it be possible to create this output for the 1.x and 2.x branches of this repo?

@mlcooper this functionality is available now with v2.21.0 per #144


assorted nits to blog post

Spell checks, consistent capitalization, italicized highlight points, etc.

Jenkins job istio.github.io/presubmit passed


Kelly sworn in replacing McSally; bump Loeffler end date to the run-off election date

When I added Loeffler in ea7c90d7, I set her end date to the special election date, since usually replacement senators take office immediately after that. But that has come and gone and she is still the appointed senator.

Continued in the PR with adding Mark Kelly and McSally removed.

LIS ID added.


SQLite cursor timeout in tests

I occasionally see timeouts in unit tests run on GitHub, stemming from the sqlite module. I'm not sure whether we simply need to increase the timeout for these tests, or if there is something more subtle like a race condition between tests using the db.
https://github.com/bluesky/databroker/blob/b7846d5e4d921338bf51fa73fafe4375e1b148ec/databroker/assets/sqlite.py#L121-L123
The failures are infrequent, but could be suggestive of being "on the edge" of an instability that might be triggered by the timing of usage on systems in the wild.

https://github.com/padraic-shafer/databroker/actions/runs/8826890932/job/24233297726#step:7:1431
https://github.com/bluesky/databroker/actions/runs/8823364014/job/24223636169#step:7:1491
https://github.com/bluesky/databroker/actions/runs/8716193593/job/23909335292#step:7:1774

The SQLite usage here is coming from a databroker backend that was experimental in ~2015 and never used on the floor at NSLS-II (or anywhere else, to my knowledge). There is a strong aversion to deleting any code from this project, but perhaps we could xfail these tests….

Or mark them as flaky?
https://docs.pytest.org/en/latest/explanation/flaky.html#plugins


Cannot send serializable classes in Camel messages

Using the normal Hazelcast component, I can send any message body that's Serializable. Using HazelcastMQ in Camel, I get the following exception when I try to send a Serializable message body:
Caused by: org.apache.camel.RuntimeCamelException: Unsupported message body type: com.example.DataObject
	at org.mpilone.hazelcastmq.camel.DefaultMessageConverter.fromCamelMessage(DefaultMessageConverter.java:64)
	at org.mpilone.hazelcastmq.camel.HazelcastMQCamelProducer.process(HazelcastMQCamelProducer.java:102)
	at org.apache.camel.util.AsyncProcessorConverterHelper$ProcessorToAsyncProcessorBridge.process(AsyncProcessorConverterHelper.java:61)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:190)
	at org.apache.camel.util.AsyncProcessorHelper.process(AsyncProcessorHelper.java:109)
	at org.apache.camel.processor.UnitOfWorkProducer.process(UnitOfWorkProducer.java:68)
	at org.apache.camel.impl.ProducerCache$2.doInProducer(ProducerCache.java:412)
	at org.apache.camel.impl.ProducerCache$2.doInProducer(ProducerCache.java:380)
	at org.apache.camel.impl.ProducerCache.doInProducer(ProducerCache.java:270)
	at org.apache.camel.impl.ProducerCache.sendExchange(ProducerCache.java:380)
	at org.apache.camel.impl.ProducerCache.send(ProducerCache.java:221)
	at org.apache.camel.impl.DefaultProducerTemplate.send(DefaultProducerTemplate.java:124)
	at org.apache.camel.impl.DefaultProducerTemplate.sendBody(DefaultProducerTemplate.java:137)

DataObject is pretty simple:
public class DataObject implements Serializable {
	public UUID id;
	public String name;
}

Edit: upon further investigation, even though camel-hazelcast does accept non-serializable objects, it doesn't seem to transmit them. Tested with hazelcast:seda.

The HzMq Camel configuration will use the DefaultMessageConverter to convert from Camel messages to HazelcastMQ messages. The default converter only supports text and byte[] message bodies. You have two options:

Serialize the object in the route before sending it to the HzMq endpoint.
or
Implement your own MessageConverter that performs object serialization.

Either solution should be fairly trivial. Take a look at o.m.h.camel.DefaultMessageConverter for an example of how to implement the converter as well as the documentation on the limitations of that implementation.

Thanks for the patch. It is merged into the 1.5 develop branch.


Allow users to specify a custom output length when resampling

Close #13

Good point. I'll make the range check more permissive. But should output_length=0 really be allowed? That seems counter-intuitive.
I prefer to leave the full parameter for future work

thanks for the update!

I'll push a new version of julius to PyPI tomorrow.

Sweet, thanks for the swift response!

I made some minor edits https://github.com/adefossez/julius/commit/3804ada9ecd61d1566dfd786714cfc2ec55eb3f4 and I added the full parameter.
The new version has been released to PyPI as 0.2.5.


retrain this library

hello everybody,i can to provide many images dataset for train face recognition,now i have a question
how i can retrain this library for increase accuracy??
i want to better detect my country people,

Because the backend of face_recognition module is dlib machine learning, therefore, if you want to retrain the model, you should use dlib to do so.
http://blog.dlib.net/2017/02/high-quality-face-recognition-with-deep.html?m=1
And there’s a sample code of it.
You may want to check the code
“deep metric learning” which is the algorithm of face recognition that dlib use.
https://github.com/davisking/dlib/blob/master/examples/dnn_metric_learning_ex.cpp
However, because dlib is written by cpp, so you need to build dlib from source.
Thanks.

Would be nice if we can do this in Python


Add EtlToSpeedScope UserCommand

Resolves #1688
Adds a UserCommand to convert etl files to .speedscope.json for data parsing.  Added some parameters to filter the data down as well that are also used for other commands like process to filter on and warm symbol lookups.

its been a couple of months since this was looked at - just wanted to throw a quick bump here


AlphaZero Approach

Hi,
Great work with your repository, impressive stuff, Just interested to see when you are running the software, with self-play and optimise at the same time, how many self-play games do you aim to complete between the optimiser releasing a new model? I wonder as I would have thought if not enough games are completed the model would over-fit?
Thanks jack

Hi @JackThomson2

how many self-play games do you aim to complete between the optimiser releasing a new model?

I think that "training/self-play ratio" mentioned in #38 is important.
Ideally almost 1 is best.
In my current environment,

self-play

about 250 self-games per hour
about 400 positions per game
so, generate 100k positions per hour

optimize

200 step per 215 seconds(no wait)

200 step per 430 seconds(including wait)

256 positions per step
3600/430 * 200 * 256 ≒ 428k positions per hour

so the ratio is 4.28.

I wonder as I would have thought if not enough games are completed the model would over-fit?

I think so too.
Actually when the ratio was high(30~), training loss tended to be low.
However, I felt that the model did not get better than a certain extent.

Thanks for this detailed reply, very insightful. In my project, I see much better results the AlphaGo approach not sure what I am doing wrong. Keep up the great work with this though, look forward to seeing your progress.


Data loading

Hi,
I would like to thank you for doing such a great contribution to the community, I've one quick question
I've a data list of json array object of 500 records which I'm trying to render with Alphabetlistview it renders fine but only shows 25 or 20 at a time when I click the alphabet , if I jump to M or Z it still loads data of A so I've to click like multiple times until it loads all the data and then it works normal ,How can I load all the 500 records first and then enable section headers for clicking , Is there a way to do that. Am I missing something..?
Any help is highly appreciated !!
Thanks!
Rahul

500 is not a small number. So you may need carefully tweaking and still may not get a safisfying result.
I don't have much time to investigate, all I can suggest is to read the offical ListView doc, and try to use some performance-related props(initialListSize , pageSize, etc) on AlphabetListview(they will be directly passed to the underlying ListView) to see a difference. And of course try to simplify you row structure.

I figured it out.. thanks for the tip , I had to set the initialListSize property , that fixed it.

@rrawla thanks for mentioning which prop resolved this for you. Saved me some time :smile:

@rrawla but this makes the page rendering slowly ...


Cannot handle GRBL G-code yet

GRBL has some additional commands like $I or ? and some other idiosyncracies.

[ ] Send replies to LightBurn when GRBL-specifig codes are received
[ ] LB sometimes sends only X123 without G1 before it. Check if the laser understands this, otherwise add appropriate G command (G0 or G1 depending on the last seen command).
[x] LB leaves out the spaces beween parameters, like in G1 X5Y10S0F1000. Check if the laser understands this, otherwise add spaces.

As per that thread in the lightburn forum I was directed to a 'developer mode' for the laserbox software Friday. Clicking around there highlighted some interesting things, one of which was that the software sends a '$H' as a homing command. That is very grbl like when I thought the software on the machine side was a derivative of marlin.

Interesting. Does it also send that command using the HTTP cnc/cmd interface? Can you try to send other grbl-specific commands (like ? or $I) in developer mode, and can you see responses to those commands (other than ok) somewhere in Wireshark?
If the firmware is really based on grbl (instead of just imitating the commands), that would mean that xTool would have to publish the source code of their firmware (or at least of that part of the firmware) according to the GPL.

Okay, findings:

The M1 understands G-code without spaces between parameters like "G1 X0Y0F1000".
The M1 does not understand plain coordinates like "X100" without a G-command in front of it (at least not through the HTTP cmd interface).
The M1 understands $H for homing.
The M1 really does not like grbl jogging commands like "$J=X100 Y100 F1000" and responds with {"result":"failed"} via HTTP. This is literally the only command I know where the result is not "ok". According to grbl documents, this means that the jogging move was not valid (e.g. hitting soft limits, which should not have been the case here).

So definitely more like Marlin than Grbl. Wonder why they chose to do $H instead of just using G0.

I have picked back up my java equivalent for the LaserBox to this project. Looking over the discussion here to see what I had forgotten in the meantime. I am having some pretty good success and I think I will be able to get to where I want to go....complete LightBurn streaming control of the machine without any XTools software. I believe the biggest piece to figure out is how to throttle things such that my proxy software only responds 'ok' to LightBurn after the previous movement has completed. As it stands the HTTP interface seems to buffer commands and response immediately.

"By the way: Have you figured out a way to get the current position from the Laser?"
Not from the source of truth...the laser. However, the laser only deals in absolute coordinates and I have a layer in my software that stores current position such that it can convert relative coordinates to absolute when LightBurn demands relative mode.
Finding a way to get real position or command completion status will be paramount for streaming to work. But if I don't find that, the real motivation for streaming is really work positioning and I probably can get to a workflow I want by manually jogging, finding an absolute coordinate that I want, and moving stuff in the design to that. Using the camera in XCS or the old LaserBox software is always a little off and using an led, and known offsets from the cutting beam, will be more reliable.

I got everything working the way I wanted, for flat laser jobs, working last night sans the throttling issue. After depackaging the electron app that is XCS and inspecting the obfuscated javascript, I see one call that looks promising for asking the machine if it is idle/completed the last gcode command. I need to do some testing to see if that pans out. If so that gives me everything I need to stream.


gke 1.10 istio 1.0 helm chart deploy with tracing, kiali is looking for tracing on localhost

Describe the bug
I recently deployed istio1.0 to gke 1.10 with grafana, kiali and tracing using the helm chart.  on deploy kiali is not able to resolve distributed tracing as it is looking for jaeger tracing at localhost.  An option to overwrite the url for grafana and jaeger in the kiali deployment seems to make sense here.
Expected behavior
Helm deployment of istio1.0 with value overrides for grafana and jaeger tracing urls so kiali can read from the kube dns name, for example istio-tracing.istio-system.svc.cluster.local or grafana.istio-system.svc.cluster.local.
Steps to reproduce the bug
Deploy with helm chart enabling tracing, grafana and kiali.  kiali will not be able to access distributed tracing as it is looking at localhost by default.
Version
istio1.0 pulled from github and deployed with helm chart
k8s gke 1.10.5-gke.4ds
Is Istio Auth enabled or not?
stable
Environment
GKE
Cluster state
that's a lot of data from our cluster if it is necessary I can update it later

cc @linsun @kyessenov

Hello @JohnDzialo,
Could you test with the new istio-release-1.0 kiali image ?
https://hub.docker.com/r/kiali/kiali/tags/
We had a reported issue in kiali: https://github.com/kiali/kiali/issues/416 and it would help us to test it on GKE.
Thanks.

Hi @lucasponce!  Thanks for the reploy.
I was using the kiali :latest tag previously I now have moved over to the istio-release-1.0 tag for kiali.  And the problem appears to be the same.
Let me know if there is anything else I can do to help diagnose a method.

I still see the error even with the new docker image istio-release-1.0.

Thanks @JohnDzialo.
A couple of checks:

Could you run a kubectl get services -n istio-system (or equivalent in GKE) to check if the jaeger-query service is up an running in the expected port ?
What is the output of the http://localhost:20001/api/jaeger ?

Basically, Kiali uses a simple proxy to serve jaeger-query under the port 32439, to not manually expose the jaeger-query service, but for some reason in your scenario it is not working.
Let me know and I can investigate.
Thanks again for the feedback.

@JohnDzialo @lucasponce I'm having the same issue so hopefully you guys won't mind me jumping in the middle.
To answer your question:

jaeger-query is running: jaeger-query               ClusterIP      x.x.x.x   <none>            16686/TCP      1h

kubectl port-forwarding kiali and curl'ing http://localhost:20001/api/jaeger gives me this:

*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 20001 (#0)
> GET /api/jaeger HTTP/1.1
> Host: localhost:20001
> User-Agent: curl/7.61.0
> Accept: */*
>
< HTTP/1.1 401 Unauthorized
< Content-Type: text/plain; charset=utf-8
< Www-Authenticate: Basic realm="Kiali"
< X-Content-Type-Options: nosniff
< Date: Thu, 23 Aug 2018 17:35:06 GMT
< Content-Length: 13
<
Unauthorized

I have it freshly installed (using 1.0.0 tag) and can provide more details if needed.

@awdrius @JohnDzialo Thanks for your details.
Definetely there is some issue with the networking configuration.
I'm trying to reproduce same environment to see if I can get same scenario and propuse a fix.

Ok, it seems the Helm Chart is missing here the kiali-jaeger port:
https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/charts/kiali/templates/service.yaml
There is a PR coming to fix this:
https://github.com/istio/istio/pull/8115/files
Basically, kiali exposes the jaeger-query service with a proxy using an additional port, and it seems the Helm installation won't take it:
https://github.com/kiali/kiali/blob/master/deploy/kubernetes/kiali.yaml#L26
Sorry, for the inconvenience, the workaround would be to pull and install kiali manually, following similar steps as the kiali makefile:
https://github.com/kiali/kiali/blob/master/Makefile#L245
Please, let me know if that would solve this issue (until the PR is merged and it can be applied to future versions).
Thanks !

@lucasponce thanks for an update.
I've created that missing service manually.
apiVersion: v1
kind: Service
metadata:
  name: kiali-jaeger
  namespace: istio-system
  labels:
    app: kiali
spec:
  type: NodePort
  ports:
  - name: jaeger
    protocol: TCP
    nodePort: 32439
    port: 20002
  selector:
    app: kiali

The only downside is that now I need to kubectl port forward both kiali and kiali-jaeger to make "Distributed Tracing" work:
kubectl port-forward svc/kiali 20001 -n istio-system

kubectl port-forward svc/kiali-jaeger 32439:20002

It makes sense as http://localhost:20001/api/jaeger return an address to the jaeger:
{"url":"http://localhost:32439"}

I get why it's implemented that way but I wish kiali would proxy requests to jaeger by itself intead of relying on exposing jaeger.

Thanks @awdrius for the update.
Yes, the long term is to embed jaeger internally as a UI component to not need this proxy.
It is something we had in Kiali backlog and we hope to start working on next Sprint.
https://issues.jboss.org/browse/KIALI-1405
So, with the workaround put it in place, you can now get Jaeger correctly from Kiali pages ?
(Specially, it propagates the filter from the service details pages).
Thanks.

No worries, thanks for the speedy reply.
Jaeger is fully embedded and I can use its UI and see traces/spans. I do not have any complex services deployed yet so I do not know if complex queries work (I see no reason why they shouldn't). I'll try getting more of the stuff deployed and will post an update.

Great @awdrius.
One of the features is to link this one from the service details page.
If you navigate from Services -> Details -> Tab Traces, you will see same info but filtered.

Ah yes, it works: I can navigate directly to "Distributed Tracing" traces from "Services" tab meaning that that feature works. That is a neat integration!

Just following up on this. Based on the conversation above, it looks like this problem is resolved. Anything else to follow through on the Istio side?

I think that this issue has been resolved and/or is better tracked via kiali's tracking. Closing.


fix some typo

fix some typo

only
41) s1.difference(s1) -> s1.differences(s2)
please restore other changes into original version
and send me another pull request


Fix UI colors

Thanks a lot for contributing!
Hey, I just found some more UI inconsistencies and tried fixing them all at once.
I removed the "TalkerScreenTheme" class and changed that option with the LogColors property. So now by default all colors for text and background and such just use the theme set by the user.
The LogCards still use the color that is found in the LogColors map. The border of the card uses the color as it is provided and the background is the log color with some opacity added to it. The makes it readable on any theme (at least the colors I tested).
I also changed the default state of the expanded logs to false, if you don't want this I can revert that. I changed that so that the main feed can contain more data and you can then only expand those you want to see more details about. To give errors some more info I set the message to the errorType if no message is given. Errors always show some minor information this way.
If users want to set some custom theme in the log screen they can still wrap it in a Theme widget. Perhaps if needed someone can make a "TalkerTheme" widget that can be used to wrap the talkerScreen?

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.78%. Comparing base (32fe34e) to head (e0a72a8).
Report is 6 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   98.80%   98.78%   -0.02%
==========================================
  Files          28       28
  Lines         584      576       -8
==========================================
- Hits          577      569       -8
  Misses          7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hello @XanderD99 !
I've already looked at how the updated log screen looks like
For my opinion it's looks very nice. But it's huge breaking change for develeopers who already used talker_flutter to create self logging packages or logs screen customization.
And now I'm thinking about how we can support old TalkerScreenTheme with Deprecated annotation and new UI

I think the best way to have that backwards compability is to keep the TalkerScreenTheme (bring it back in this case) but indeed mark it depricated.
Then when someone uses the TalkerScreenTheme in there project just wrap the whole TalkerScreen in a Theme that uses the colors set in TalkerScreenTheme.
That way the TalkerScreenTheme is removed from al the UI itself but is still available to the other developers until it is completely removed after some time.

It would be batter to change typedef LogColors from Map<TalkerLogType, Color> to Map<String, Color> it's will allow to create custom log types with custom colors

hey @Frezyx I updated the code and added TalkerTheme back to TalkerScreen. I marked is as depricated however, but when it is set it uses logColors from the talkerTheme and it wraps the TalkerView with a theme that should set background and card colors accordingly.
I haven't fully tested this yet so this should be verified.


Master

Adding a new field called  List in ReservedIP parameters.
RDFE changes for the data contract are live
Updated all session record jsons to take new version of RDFE
Wrote new tests which will test the new field
CreatePaasDeployment will be created with shouldrun parameter = true

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[ ] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@skomarag please provide details as to what this PR is about including updating the title of the PR.
Please have someone approve this PR from your team.


tests(ajax): add base tests

Coverage increased (+2.7%) to 86.187% when pulling ef639e589a59242eb44038f39c1202c8f71c6365 on tests/ajax into 4ef22ff19e5838dbf7c5ae6f4c64f20803bc984a on master.


Drop base64 dependency

Description
#1066 added base64 as a dependency to silence warnings under Ruby 3.3
The digest gem already comes with its own base64 method. Just use that and drop the base64 gem dependency.
These methods are equivalent:
https://github.com/ruby/digest/blob/d39b684f9131186b994639be0e324e854eae4b1d/lib/digest.rb#L55-L57
https://github.com/ruby/base64/blob/9669a7d3b0e3b9a739969404daf58f912c58c6b3/lib/base64.rb#L273-L275

ah, squash merge commit log becomes redirecting to this PR...
anyway thanks!


fix: filter out mediator connections from contact list

Signed-off-by: Akiff Manji<EMAIL_ADDRESS>Summary of Changes
Mediator connections are filtered out from contact list
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[ ] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[ ] Updated documentation as needed for changed code and new or modified features;
[ ] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@amanji Missing check boxes above.


Doc test tool failure: xt/aspell.t

Problem or new feature
When running “make xtest” on classtut.pod6 I get the following error:
xt/aspell.t …
    A react block
        in block at xt/aspell.t line 102
     Died because of the exception:
         Malformed UTF-8 near bytes 79 e2 20

Suggestions
I see no obvious bad char, and running “file” on the file returns “C++ source, UTF-8 Unicode text, with very long lines”

It's only on one host, but on each of the couple of branches I've tried. I've reinstalled aspell and the en files to no avail. I need to investigate my LC_* env vars, too.

Closing as a one-off error on my local host.


[StyleGuide] About style guide / Guide stracture and development

Code style guide - know everything there is
The best this style guide stracture
only GitHub or own site?

Examples:

https://google.github.io/styleguide/, https://developers.google.com/style
http://getbem.com/, http://getbem.com/introduction/
https://style.tidyverse.org/index.html
https://webkit.org/code-style-guidelines/

Why:

https://medium.com/level-up-web/what-is-a-programming-style-guide-and-why-should-you-care-9019e51bb7ad
https://www.smashingmagazine.com/2012/10/why-coding-style-matters/

Others:

https://syllabus.codeyourfuture.io/guides/code-style-guide
https://www.pullrequest.com/blog/create-a-programming-style-guide/

Basic

I want to create all style guides in one, so basic structure should be like below

Basic Structure
Style Guides:

JS

General
React

Styles

General
SCSS
StyledComponents


Update izumi-reflect to 2.3.7

About this PR
📦 Updates dev.zio:izumi-reflect from 1.1.3 to 2.3.7 ⚠
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "izumi-reflect" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "izumi-reflect" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #417.


RESTEASY-1323 / RESTEASY-1325

Extended timeouts to fix travis problems.

I'm going to go ahead and commit this, since it (seems to) fix a couple of tests that have been breaking travis runs.

+1

However  a build of master has failed after this commit, so looks like the changes are not enough (https://travis-ci.org/resteasy/Resteasy/builds/128555441)

Damn.


ACLs

In this storycard, we expect the behavior to be:
User ACLs:

properties of user:

threebot_id
email
pubkey
ipaddr

behavior of access:

Read
Write

Circle ACLs:

properties of user:

name
description
user_members (corresponds to users)
circle_members (correspondes to circles)

behavior of access:

Read
Write

This means that if a user has write access, but the circle is read-only, the user keeps the right access
if the circle gives right access, all its users have right access, even if the user itself has only read-only access. Thereby, getting write access.

Access Control List
An access-control list (ACL), with  BCDB, is a list of permissions attached to an object. An ACL specifies which users or circles are granted access to objects
User ACLs:

properties of user:

threebot_id
email
pubkey
ipaddr

behavior of access:

Read (r)
Write (w)

Circle ACLs (groups):

properties of user:

name
description
email
threebot_id
user_members (corresponds to users)
circle_members (correspondes to circles)

behavior of access:

Read
Write

example
bcdb = j.data.bcdb.get("test")

#create user
u = bcdb.user.new()
u.name = "kds_1"
u.email =<EMAIL_ADDRESS>u.threebot_id = "user1.ibiza"
u.save()

#create circle
g = bcdb.circle.new()
g.name = "circle_1"
g.email =<EMAIL_ADDRESS>g.dm_id = "circle1.ibiza"
g.user_members = [1] # you can add all users need
g.save()

# create new model and will add our acl to this model
schema = """
    @url = despiegk.test5.acl
    name = ""
    an_id = 0
        """

model = bcdb.model_get_from_schema(schema)
a = model.new()

# that will add right to the circle and all users in the circle
a.acl.rights_set(userids=[], circleids=[1], rights="rw")

assert a.acl.rights_check(1, "r") is True
assert a.acl.rights_check(1, "rw") is True
assert a.acl.rights_check(1, "w") is True

run the test
j.data.bcdb.test(name="acl")

Ran the test :
JSX> j.data.bcdb.test("acls")
Go the following error:

My code is on the latest and this is a new installation.
3BOTDEVEL:3bot:jumpscaleX: git log -1
commit 2de63cfe6d9f79a45d80bd3eebc7e9367ea05e30 (HEAD -> development_jumpscale, origin/development_jumpscale)
Author: kristof de spiegeleer <>
Date:   Sun Jul 28 10:24:14 2019 +0200

    isntaller fix for root install

3BOTDEVEL:3bot:digitalmeX: git log -1
commit dc0feede4c2e389076e78019234c461a6ae17abe (HEAD -> development_jumpscale, origin/development_jumpscale)
Author: kristof de spiegeleer <>
Date:   Sat Jul 27 12:24:08 2019 +0200

    reformat?

@siddiquagig
please check you system or your old data you have
it works good ( i have last commit)

Working now, Tried on a new installation again.

3BOTDEVEL:test:jumpscaleX: git log -1
commit 95f10743d28bc5508036ad5bb263e9fe7a08271b (grafted, HEAD -> development_jumpscale, origin/development_jumpscale)
Author: kristof de spiegeleer <>
Date:   Sun Jul 28 15:52:34 2019 +0200

    Merge branch 'development_jumpscale' of github.com:threefoldtech/jumpscaleX into development_jumpscale


issues with installation module

my new issue now is i have all extensions enabled yet i am still getting the error that they are not enabled

I've just added some debugging tools to the repository to help with sorting this out. To help you further, I will need some information.

Please download this script and put it in your public folder. Then, go to [BANK URL]/checkmods.php and screenshot the output for me
Please give me your PHP version
Please attach a copy of your PHP.ini file

i'm using php 7.1

7
it wouldn't let me attach my php file  but you can download it here: https://www.mediafire.com/file_premium/qyoykw2rq8etngv/php.ini/file

You haven't enabled any of the PHP extensions in your config file. You'll need to remove the semi-colon at the start of the line for each extension that the error mentions. It seems that sodium and zip are built in to your version of PHP. I've attached a picture of what it should look like once finished. The line numbers in the screenshot are the ones you will want to change.

ok after making the changes its still giving me the error. I ran the check mod script and its say now its missing sodium. omg this so frustrating but worth it if i can get this dang thing to work.

It is likely that it isn't installed then. The easiest thing to do is probably to re-install XAMPP (or update to the latest version if that option exists).
On later versions, when you edit the extensions part of the php.ini, it won't read exactly the same and the ".dll" part at the end will probably be missing. Just ignore this and remove the semi-colon like before.

I'm also encountering the same issue, on both xampp and mamp on multiple different version I encounter "The module sodium is missing Please install or enable this module." on checkmods.php

@Owen000 Does that mean that you solved the issue then?

As we've got some advice for solving this from users in the thread, I'm going to mark this as completed. @jester223, please feel free to re-open if you run in to any more issues.

As we've got some advice for solving this from users in the thread, I'm going to mark this as completed. @jester223, please feel free to re-open if you run in to any more issues.

For anybody experiencing this issue with the sodium module, please use the later v0.1.5-alpha version, which does not require sodium for installation.


Create 0000-01-02-nithish95.md

Add nithish95's file

Add nithish95's file

Add nithish95's file


Salt representation

Salts can be represented either as their ionic form or semi-covalent bonds. For example:
Ionic: [Fe+3].[Fe+3].[O-2].[O-2].[O-2]
Covalent: O=[Fe]O[Fe]=O
Should we have a standard that we convert to? Should we allow users to select which one they want?

the commit 148058c9eb49863d5359c0f3fe28a3e9837f545e adds the capability to choose to disconnect more ions when salts are encountered.

Great work  - thanks Simon!


Screenshot tools

Possibility of screenshot of a selected area giving the option of copying to clipboard or saving the image to disk. Similar to lightshot tools, prtscr, ...

Win+Shift+S can basically do this now?

Win+Shift+S can basically do this now?

This is news to me. Exactly

Win+Shift+S

Great tip Renato!  I'm going to make sure the Windows key shortcut guide is updated with this.

Great tip Renato! I'm going to make sure the Windows key shortcut guide is updated with this.

ok!


Environment variables object

Extracted logic for getting/setting variables into a separate EnvironmentVariables object in order to have a clear separation of responsibilities between loading values from a file and accessing values using native PHP facilitators.
EnvironmentVariables object can be used standalone, for read-only purposes, as an alternative for using getenv() function or global variables. It can also injected into a DI container so that environment variables are available when constructing services. For example:
$container->set('env', EnvironmentVariables::createImmutable());

$container->set('service', function (ContainerInterface $container) {
    $env = $container->get('env');
    return new My\Service($env['FOO'], $env['BAR']);
});

This looks like a worthwhile refactoring, and makes a lot of sense from a concerns and testing perspective.  You've even used protected variables for open/closed principles!
I'm not a maintainer I'm afraid, but see this as valuable, particularly as it opens the door for people to extend EnvironmentVariables to put their own end to the $_ENV  vs $_SERVER vs putenv in a clean and swappable fashion.

+1

Any updates would be much appreciated.

Why is the build failing, those error messages does not make any sense? Race condition or something, I guess I should sync my branch with changes on the master.

Note that after syncing with changes on the master branch introduced with https://github.com/vlucas/phpdotenv/pull/215, I had to slightly adapt them. To be honest, I really don't understand why those changes were needed at the first place.

It's sometimes helpful to load variables into an array without setting them in environment.
My use case is populating phinx environments config file as it allows migrations on specific environment from CLI:
phinx migrate --environment=testing

I like this overall. What are your thoughts on reading in all the ENV vars (maybe merging $_ENV, $_SERVER, etc. and caching them locally, then having getreturn those cached env vars first? I only bring this up because many people seem to have issues withgetenv`, etc. being called from multiple different areas in their project at different times.

@vlucas That is definitely something that can be considered, but I think it kinda goes beyond the scope of the initial idea. This was a simple refactor for a better separation of concerns, as well as to encapsulate/abstract logic for dealing with environment variables, and use it in an object-oriented fashion, as opposed to using getenv() or $_ENV directly. I didn't want to introduce any changes that might affect existing behaviour.
Therefore, I see yours and many other ideas as a follow up on this one, which after being merged opens opportunities for other improvements as well. I would rather improve things gradually, in smaller increments, rather than having one big PR with lots of (unrelated) changes in it.

@GrahamCampbell any news about this approval ?
(since the self() has been replaced by static())

Replaced by https://github.com/vlucas/phpdotenv/pull/300.

https://github.com/vlucas/phpdotenv/pull/300. Gone with a more abstract approach, so it can be truly flexible.

Replaced by #300. Gone with a more abstract approach, so it can be truly flexible.


Escaping characters in Strings is misbehaving

Problem
Escaping characters leaves the backslash in the resulting string.
Steps to Reproduce

Create a script with the following (try replacing the second backslash with " or n to test quotemark literal characters and newline characters):

pub fun main(): String {
   return "\\";
}

run flow scripts execute [path-to-file] --network testnet

Expected result
(note: the output is always wrapped with quote marks)
Output:

Result: ""

With " character instead:

Result: """

Actual result
Output:

Result: "\"

With " character instead:

Result: """

When interacting with this script via @onflow/fcl, result is the following error:

[Error Code: 1101] cadence runtime error Execution failed:
error: invalid end of string literal: missing '"'

@dsainati1 should this be moved to Cadence or do you think it's a CLI issue?

I see. Will try to pinpoint the issue and solve it.

I think this is not bug it is by design ( the reason Result is always wrapped in double quotes)
What is inside double quotes, is always escaped string.

I think it's fair to close this issue then.


Please invite me to the Recode-Hive GitHub Community Organization

Name
Pasupuleti Revanth
Discord Username (if applicable)
revanth1325
Additional Context
To learn and contribute.

sir, i have not added to the community

@revanth1718 can you check your email for any invitation to this org. you need to accept it

i opened but it showing like this

@Asymtode712 can you look into it?

@revanth1718 Try it now


fix: Maintenance & typo fix

Current coverage is 100.00%

Merging #39 into master will not affect coverage as of 9e4c5a8

@@            master     #39   diff @@
======================================
  Files            2       2
  Stmts           76      76
  Branches         0       0
  Methods          0       0
======================================
  Hit             76      76
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 9e4c5a8

Powered by Codecov. Updated on successful CI builds.


Add infrataster-plugin-firewall description and link

Hi,
I have created infrataster-plugin-firewall to test firewalls.
I have added description and a link.
Please introduce this on README.md.

[Jenkins] Can one of the admins verify this patch? (say "test this please")

Great plugin!!
Thank you for introducing it!

Thank you!


fireflow

Link to project (GitHub): https://github.com/horaciocome1/fireflow
Describe the project in 2-3 sentences: Uses the power of kotlin flows to listen for document changes on android.
Why would Firebase developers be interested in this project?: It might be considered for the -ktx
Have you added a .opensource/project.json file to your site: No

@horaciocome1 Happy to add your project, but before that, please add a .opensource/project.json file to your repository. You can see some examples here:

https://github.com/invertase/react-native-firebase/blob/master/.opensource/project.json
https://github.com/sgarciac/fuego/blob/master/.opensource/project.json
https://github.com/firebase/emberfire/blob/master/.opensource/project.json

Hi @thatfiredev
Thank you! The examples really helped sorting this out
Added a .opensource/project.json ✅

@horaciocome1 It's live https://firebaseopensource.com/projects/horaciocome1/fireflow/


INetworkNode needs to be a capability

Hi @raoulvdberge
I was having a look at this issue (before I try to have a look at enderio cables), and I'd like to suggest a few refactoring on the INetworkNode:

Remove getNodeWorld() and add getDimension() to IWirelessTransmitter
Remove canConduct(...) and use tile.hasCapability(...) instead (it has face check)
Remove getPosition() and replace with getItem()

And at last one I'm not really sure about:

Remove isConnected(), replace with getNetwork() != null

I can work on a pull request for that if that helps.

How is getItemStack() a valid replacement for getPosition()?
getNodeWorld() is needed

getNodeWorld() is only used to get the dimension of a IWirelessTransmitter. That's why I'd like to remove it after putting getDimension()
getPosition() is only used to get the item of a node, for displaying in the controller UI, so I think a getItemStack() would be more appropriate - maybe with a better name.

Ah. Good point. You were ahead of me there :)
In that case, feel free to work on the PR but wait til I make the 1.11 branch in that case (which should be later today).

My current work is there
I'm waiting your new branch to rebase and open a pull request.
The changes were pretty big regarding the refactoring of isConnected(), and rework of rebuild() to integrate the capability. By the way, is there an actual need to getConnectableConditions() ?

At first sight, most changes seem OK (I like the network graph refactor). However, a proper PR will be needed for further review.
For the justification of the connectable conditions see #650

@Volune The 1.11 branch is now public


ScrollView can not  be scrolled vertically.

I have tried to place my button bar view and container view in mid of a scroll view
After that, I can't scroll my scrollView anymore.
Is there anyone have the same issue?

yeah same issue.

yeah same issue.