Is .Net Framework 4.5.1 required .Net Core Windows Hosting by force?

From @tloo on March 8, 2017 21:8
Is .Net Framework 4.5.1 required .Net Core Windows Hosting by force?
Steps to reproduce
On Windows Server 2008, we have .Net Framework 4.5.5 installed.
Expected  behavior
.Net Core Windows Hosting should be installed correctly.
Actual behavior

The logs
dd_DotNetCoreWinSvrHosting__20170308155829.log.txt
Environment data
Copied from original issue: dotnet/core-setup#1673

From @gkhanna79 on March 8, 2017 21:53
@glennc @DamianEdwards Can you please loop in the right folks? Also, is there a more appropriate repo to move this issue to?
CC @leecow

From @glennc on April 10, 2017 16:9
I think @joeloff is the right person for this, and can move it to where it should belong.

From @gkhanna79 on March 30, 2017 2:15
@DamianEdwards Can you help move this to appropriate repo and assign to right folks?

From @gkhanna79 on April 10, 2017 17:5
@joeloff Is not on the assigned to list - @joeloff Can you please move this bug to appropriate repo?

Yup, you can assign to me. The requirement though is a minimum version
@tloo Can you share your setup logs? We specifically look at HKLM\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full and examine the Release value.

@joeloff I have shared the setup logs. Please check the attachment.

According to the logs, the version we detected is 378389, and the minimum version we're looking for is 378675.
[380C:6CD8][2017-03-08T15:58:29]i000: Setting string variable 'NetFx45Release' to value '378389'
378389 is .NET 4.5
You can find the full set of version numbers here

So .Net 4.5 is required by force? I have another setup Windows Server 2008 which doesn't have .Net 4.5 installed. But it seems .Net Core runtime can be installed correctly.  We just just want to figure out the prerequisites for .Net Core runtime.

@tloo The 4.5 requirement seems to be a leftover from when we shipped DNX and was probably never reviewed again. The only other component we have in the server bundle right now is the ASP.NET Core Module and that also doesn't require 4.5 AFAIK.
For now, the only way around is to either install .NET 4.5.1 or to temporarily change the value of the registry key to bypass the check.

@joeloff Changing the registry key might not be a good solution for us. Because we are planning to package .Net Core runtime in our installer and deploy on the customer's setup.  And installing .Net 4.5.1 might not be a good solution either. because it will increase our installer package size.
In fact, we have two Window Server 2008 setup, one is asking for .Net Framework 4.5, the other one doesn't.  I'm pretty sure that 378675 was not installed on both of them. So I'm thinking it should be a bug.

@tloo Yes, the check should be removed, but until that happens and we ship a new bundle you're limited in what you can do to install the server bundle. Are you planning on packaging just .NET Core runtime or the server bundle (which contains the .NET Core runtime and ANCM)?

@joeloff The server bundle, this is the suggestion from the documentation:
https://docs.microsoft.com/en-us/aspnet/core/publishing/iis#deploy-the-application

@joeloff Any updates on this?

@tloo This will get fixed for the preview2 version of the bundle.

I am getting same error while installing Windows (Server Hosting)(NET Core 1.0.5) installer  downloaded from
https://github.com/dotnet/core/blob/master/release-notes/download-archives/1.1.2-download.md

@joeloff : Could you please guide what is preview 2 version, will there be a new bundle for DotNetCore.1.0.5_1.1.2-WindowsHosting or will this issue get fixed only in Version 2.0.

@joeloff Any update on this? Is there any separate/new thread?

@ChouhanSandeep This was fixed in Preview 2 of the 2.0 bundle.


Check Divisions, Enable Lazy Sync Operations on Divisions-enabled Ensembles, Overhaul Object Table Generation

This PR does a few things that maybe I should have split up into different PRs, but there's also a decent amount of overlap. In this PR, I added more explicit support for Dask Divisions. In particular, checking if they are set after loading in data and warning the user if they are not. Divisions are also checked during sync operations to enable a new completely lazy sync that doesn't need to load the index fully into memory. In addition, the object table generation off the source table has been made lazy as well, removing the current unscalable implementation that loads the entire index into a pandas dataframe.

@wilsonbb updated as per your suggestions, thank you!


Scores should be normalized

Ideally we should be normalizing scores so that we can compare feature contributions uniformly.  Quick and dirty method would be to divide all scores by max(scores).

@slangevi suggested that we could also try just taking the top N scores, or the top K percent of scores.


Comprehensive Model Evaluation section added to credit risks Model

Implemented a "Comprehensive Model Evaluation" section with advanced metrics and visualizations for a deeper understanding of model performance.
In "Hedging-of-Financial-Derivatives/Credit Risk /CreditRisk.ipynb"  Used a variety of metrics like ROC-AUC, Precision-Recall, F1-score, and Confusion Matrix in addition to accuracy to get a more comprehensive understanding of model performance.

Resolves #171

Hi @Akshat111111 , I have resolved all the merge conflicts in this PR. Now you can check it again and please tell me if anymore changes needed.

I will suggest to create a new PR, so that it will not have unnecessary commits.

Sure, I will create a new PR.


Fix wrong wording

Issue

Solution

Context

Testing

Release Notes

This PR cannot be merged AS IS and requires changes on Patroni first.
IMHO, to keep the house clean, @marceloneppel please create an GitHub->Jira issue to replace master->primary when it will be technically possible. With this PR can be abandoned.

This PR cannot be merged AS IS and requires changes on Patroni first. IMHO, to keep the house clean, @marceloneppel please create an GitHub->Jira issue to replace master->primary when it will be technically possible. With this PR can be abandoned.

Done. Created https://github.com/canonical/postgresql-k8s-operator/issues/101.


Compatibility with electron21, electron22 …

% pkg info -x electron
electron19-19.0.15_1
electron21-21.2.0
%

Chimeracord currently requires devel/electron19. Might it gain an update to also, or alternatively, work with devel/electron21?
Thanks

I'm sorry for not checking github, I just haven't been feeling like playing around with freebsd for a bit, Will get that done soon! Plus, maybe I should work on some extra stuff!

Hey, thanks. No rush. Incidentally there's now also 22:
% pkg iinfo electron
electron19-19.1.9_1
electron22-22.3.5
%

should work. remember that all deps are installed through install.sh.

I updated the repo, ran sudo ./install.sh then deleted electron19.
% chimeracord &
[1] 91082
%
><EMAIL_ADDRESS>start
> electron19 .

sh: electron19: not found

[1]    Exit 127                      chimeracord
%

https://github.com/RoboChimera/ChimeraCord/blob/aed4b5ea1a7ef15f15f17ecf3c5424177c28e16f/chimeracord/package.json#L7

Oh.. I am so sorry, I'm going to be honest and say I didn't put much time or effort on getting it to work, I had to use a vm for it and I got tired of having to install freebsd because I must have deleted it out of not having much space, but now I am back on FreeBSD, I'll work more on chimeracord, maybe.


InitCallback not working at first call

Hello everybody, when i call the "BackgroundLocator.registerLocationUpdate" function, the first time. The initCallback is not being called. But the normal callback does work. On the second call of the function, everything runs perfect. Any idea why this happens? Im at version 1.4.0+1

Hi @LeoHub-dev
Thank you for opening an issue;
Please use the latest version  and see if this behavior still persists;

Hello @mehdok, ok i will test in a new project just to check. Sadly in the actual project right now is not exactly posible to migrate to null safety, since is a large project.

Greate, thanks;

I can confirm this issue also occurs in v1.6.6

Hello @mehdok, this issue is still present in v1.6.12.
Any idea how to work around this issue?
Thank you.

Congratulations for you great package! unfortunately this issue makes it completely unfeasible since there is no other way to pass data to background serve


Add legal entity

I've seen GitHub do this a few times recently. The PR remains open even though the commits have been merged in. It's weird


K2cli migration to Kraken

This covers issue: https://github.com/samsung-cnct/k2cli/issues/135
I changed all references to K2 and k2cli and followed the style that was already there. Used my best judgement on when to use Kraken vs Krakenlib for K2 based on the references in https://github.com/samsung-cnct/k2/pull/741, I would like feedback if there's a better approach on some of these changes.

This is blocked by: #104

Question about the Jenkinsfile: Should I also convert the references to k2cli in here?

Per discussion with @coffeepac: yes, but it is basically for consistency reasons.

CI failed on
FAILED - RETRYING: Wait for etcd cluster to form (1 retries left). failed: [localhost] (item=5) => {"attempts": 30, "changed": true, "cmd": ["ssh", "-o", "StrictHostKeyChecking=no", "-o", "UserKnownHostsFile=/dev/null", "-F", "/var/lib/docker/scratch/kraken-PR-139-3/aws//kcapr-139-3/ssh_config", "etcd-5", "etcdctl", "--ca-file=/etc/etcd/ssl/client-ca.pem", "--cert-file=/etc/etcd/ssl/client.pem", "--key-file=/etc/etcd/ssl/client-key.pem", "--endpoints=https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:4001", "cluster-health"], "delta": "0:00:02.532538", "end": "2017-08-18 22:54:04.297339", "failed": true, "idx": "5", "rc": 4, "start": "2017-08-18 22:54:01.764801", "stderr": "Warning: Permanently added 'ec2-13-58-193-88.us-east-2.compute.amazonaws.com,<IP_ADDRESS>' (ECDSA) to the list of known hosts.\r\nError:  client: etcd cluster is unavailable or misconfigured\nerror #0: client: endpoint https://<IP_ADDRESS>:4001 exceeded header timeout\nerror #1: client: endpoint https://<IP_ADDRESS>:2379 exceeded header timeout", "stderr_lines": ["Warning: Permanently added 'ec2-13-58-193-88.us-east-2.compute.amazonaws.com,<IP_ADDRESS>' (ECDSA) to the list of known hosts.", "Error:  client: etcd cluster is unavailable or misconfigured", "error #0: client: endpoint https://<IP_ADDRESS>:4001 exceeded header timeout", "error #1: client: endpoint https://<IP_ADDRESS>:2379 exceeded header timeout"], "stdout": "cluster may be unhealthy: failed to list members", "stdout_lines": ["cluster may be unhealthy: failed to list members"]}

Question about Jenkinsfile:
Line 6: k2_image_tag = "${env.K2_VERSION}" ?: "latest"
Should I update this to krakenlib_image_tag = "${env.KRAKENLIB_VERSION}" ?: "latest" or to kraken_image_tag = "${env.KRAKEN_VERSION}" ?: "latest" or leave it as is?

I would skip the Jenkinsfile for now.  Its requires changes be made to the Jenkins job in lockstep.


Removed "android:supportsRtl"

Removed "android:supportsRtl" attribute from manifest because of "Manifest merger failed"
adding tools:replace"android:supportsRtl" to my application element didn't fix the problem.

I signed it!

@samtstern I think it was valid! but this is okay too :)

Oops you're right it was valid!  So what we really want is your XML but without removing the xmlns from the Manifest tag and the label from the application tag.

@samtstern So will you merge it please ?


irregular icon layout

Yesterday my polybar was fine, but today my polybar compilation is broken while the polybar config has not changed

this is my module bspwm
[module/bspwm]
type = internal/bspwm

ws-icon-0 = I;
ws-icon-1 = II;濫
ws-icon-2 = III;
ws-icon-3 = IV;
ws-icon-4 = V;
ws-icon-5 = VI;
ws-icon-6 = VII;
ws-icon-7 = VIII;
ws-icon-8 = IX;
ws-icon-9 = X;
#ws-icon-default =

format = <label-state> <label-mode>

label-focused = %icon%
label-focused-background = ${colors.accent}
label-focused-padding = 1

label-occupied = %icon%
label-occupied-foreground = ${colors.foreground}
label-occupied-padding = 1

label-urgent = %icon%
label-urgent-padding = 1

label-empty = %icon%
label-empty-foreground = ${colors.foreground}
label-empty-padding = 1


How to unit test with this package?

So I'm writing some code using this library.
I want to know how to unit test, or how you advise doing it.
Basically the better practices to set up and tear down agents and intents with the sole purpose of testing.

Hi @perojas3. You can take a look at this code https://github.com/googleapis/python-speech/blob/master/samples/snippets/speech_model_adaptation_beta_test.py


str.repr should use double quotes when value needs escaping

This is what CPython does:
>>> s = "hello"
>>> repr(s)
"'hello'"
>>> s = "hello'"
>>> repr(s)
'"hello\'"'

Code compiled with VOC is currently working like this:
>>> s = "hello"
>>> repr(s)  # this works as expected ...
'hello'
>>> s = "hello'"
>>> repr(s)  # ... but this results in broken representation
'hello''

It would be nice to have Str.__repr__ handling these cases, this will make testing easier.

If anyone is tackling this, Bytes.__repr__ also needs similar logic.
For reference: cpython bytesobject.c

Actually, should this issue be generalised to include escaping within the quotes, or should it be a separate issue? There is a partial fix that handles edge cases for representing/escaping various non-printable characters (but not the outer quotes) in newly-closed #465, and I'm wondering where to track that.
CPython ref: unicodeobject.c

Well the first issue (created by @eliasdorneles) would be fixed by #578 but still there things to be done to get this closer to the CPython ref.

@eliasdorneles can i take up this issue?

This seems to be up for grabs, so I'm going to see what I can do with it. If I don't make traction, I will come back and restore the "Up for grabs" tag.

@jonkiparsky feel free to have a look around!
However, I was just checking and the specific case I reported seems that it was already implemented... Did you find anything?

@eliasdorneles
Yep, looks good from here.
(env) [jpk@Jons-MacBook-Pro-2/~/code/voc-dev/jpk_test: Sun May 20 15:45]:547 $ java -classpath ../voc/dist/python-java-support.jar:. python.quote_test
'hello'
hello'
'hello
"'hello"'
(env) [jpk@Jons-MacBook-Pro-2/~/code/voc-dev/jpk_test: Sun May 20 15:45]:548 $ python3 quote_test.py
'hello'
hello'
'hello
"'hello"'
(env) [jpk@Jons-MacBook-Pro-2/~/code/voc-dev/jpk_test: Sun May 20 15:45]:549 $ cat quote_test.py
class quote_test(object):
    s = "'hello'"
    t = "hello'"
    u = "'hello"
    v = '"\'hello"\''
    print(s)
    print(t)
    print(u)
    print(v)
(env) [jpk@Jons-MacBook-Pro-2/~/code/voc-dev/jpk_test: Sun May 20 15:46]:550 $

I suppose this issue can be closed?

Yup, seems like it!
Closing it now, thanks for digging! :+1:


Support Python 3 and some additional future/refactors

Hi,
In these set of commits, I refactored the codebase and added some features to it. Currently implemented features are:

[x] Python 3 support (And compatible with Python 2.7)
[x] Bootstrap a Tor instance directly and use it instead of system-wide version (Enables us to add features on customizing Tor itself).
[x] Timeout support
[x] Packaging (No requirements.txt and installable through pip)
[x] Install onioff script in the user's PATH
[x] Formatted output instead of text files (JSON, TSV)
[x] Progress bar
[x] Specific messages for other inactive states (Timeouts, Inaccessible server, SSL Error)

Yet still I plan to develop the following as soon as I have some free time:

[ ] Unit tests
[ ] Tox test runner to confirm complete support on all supported Python versions
[ ] Make SSL verification optional
[ ] Custom Tor configuration
[ ] Update Readme

Hi there @shahinism. Just yesterday I sat and converted ONIOFF to Python 3... 😬 I am planning on pushing it tonight. However, I will look through your code and see if there's any added features that you could push as separate pull-requests to ONIOFF v2.1. Thanks again for your commits! I will look through everything tonight.

@shahinism I have just pushed v2.1. You can create a new pull-request for each added feature, if you'd like. Thanks again!

Hi,
Thank you for your time. I'm not sure if it is possible to port these features to version 2.1 directly. I've moved Tor/Onion related tasks to a separate (more general) module which handles an independent Tor connection (not using system-wide instance and is possible to configure directly). This also reduces the number of requests (No need for IP check). All other features have been developed around this module.

Maybe you could integrate the Tor-handling class within the main script? @shahinism

Well that is what I've already done in this branch 😅
Before starting this branch, I just wanted to develop some unit tests (for fun) and then add the features I needed for another project (something to continually watch a list of onions and produce programmable results). But to have a testable code base (with separation of concerns) I ended up with applying some general best practices toward having a more Pythonic code base. Actually that Tor module is the part that allows having a non-cli interface (something programmable from within another python script), and that is why I added the packaging part.
Anyway, it's entirely cool if you don't like this massive list of changes. You can just deny it, or cherry-pick changes as you wish.

Sounds good. Thank you. :)

Hello.run scrip error:
python onioff.py -h
Traceback (most recent call last):
File "onioff.py", line 11, in
from urllib.request import urlopen
ImportError: No module named request
python3 onioff.py
Traceback (most recent call last):
File "onioff.py", line 10, in
import socket, socks, requests, sys, os, time, optparse, datetime, re
ModuleNotFoundError: No module named 'socks'
run the kali linux
Help me please.Thanks.

Hi @grubster2020. pip3 install pysocks should solve your issue.

Actually, if you are using this branch, you can try pip install . (or pip install -e . for development mode) which uses setup.py to set it up as a package with command line script in the path onioff  (no need to call with python :wink:)


SVG XML Updates

#3956
there are issues in the rendered SVG XML when you use unicode characters, such as superscripts.  This update is to keep a backward compatible SVG XML export, it's currently ascii, this introduces an optional parameters to the GetXml functions to export using UTF8 instead.

@swharden  would like feedback, if I should just make the default UTF8 and not bother with the backward compatibility?


Add ability to add custom VideoStream (e.g. for iOS)

It would be super awesome to say:

hello openwebrtc,
this is my own video stream
send it to my peer.

Basically I would like to have GStreamer class, that would allow to hook in my own AVCaptureVideoDataOutput with my own sampleBufferDelegate, so the Video Frames from my own implementation of - captureOutput:didOutputSampleBuffer:fromConnection: can be used in openwebrtc.
So, as @superdump mentioned in the IRC channel, I guess I need to implement GStreamer elements that do what I need using Apple's AVFoundation. He mentioned to modify owr to add them into the pipeline in an appropriate place.
So I hope I can use this ticket, to get some help to find the appropriate places, to add the needed functionality :-)

@VladimirTechMan sounds like something we discussed in Paris for your infrared camera :smile:


str() to accept optional length

Fixes https://github.com/iovisor/bpftrace/issues/199. For small strings, at least.
sudo bpftrace -e 'tracepoint:syscalls:sys_enter_write /pid == 23506/
{
  printf("<%s>\n", str(args->buf, args->count));
}'
# type pwd into terminal 23506
<p>
<w>
<d>
# press enter in terminal 23506
<
>
</home/anon
>
# notice that this string got truncated; we don't allocate sufficiently large strings (by default)
<anon@anon-VirtualBox:

# meanwhile, here's what terminal 23506 looks like:
anon@anon-VirtualBox:~$ pwd
/home/anon
anon@anon-VirtualBox:~$

By default, the largest string it can support is 64 bytes. We can tune this with the environment variable BPFTRACE_STRLEN — which fixes the string truncation in this particular situation:
sudo BPFTRACE_STRLEN=240 bpftrace -e 'tracepoint:syscalls:sys_enter_write /pid == 25783/ { printf("<%s>\n", str(args->buf, args->count)); }'
<
>
</home/anon
>
<anon@anon-VirtualBox:~$ >

Caveat: str() allocates strings on the BPF stack, so we reach the 512-byte limit very quickly (especially since we pay the toll again when printf() composes a perf event output buffer).
I explored the possibility of storing the strings off-stack. The main problem there is that probe_read_str() will only write upon on-stack memory. I have ideas for workarounds (and some code progress towards those workarounds), but they're too big to be included in the scope of this pull request.

Here's some code that I built to explore the possibility of storing strings off-stack:
https://github.com/iovisor/bpftrace/compare/bd038f9110009f282c657c393fae60fdb7dd50ba...Birch-san:c5088c9a5d731165e1005a6a800e611bb63f3dc3
It introduces (in codegen) a "StrCall" specialization of "Call".
StrCall has a PERCPU_ARRAY BPF map, to hold large data off-stack.
We cannot use probe_read_str() to output directly into the BPF map, but maybe we could allocate a small on-stack buffer, and ferry bytes (one buffer at a time) from BPF stack into BPF map.
Next, printf() poses a few problems:

composes the perf event output struct on the BPF stack
doesn't use runtime information to decide length of strings inside the perf event output struct

composes a fixed-size structure
determines size of structure during semantic analysis

I think PerfEventOutput can transfer data from BPF map to userspace (that's what "join" does), so we could compose the perf event output struct inside a BPF map.
We may find that we want a dynamically-sized perf event output structure. Like, imagine we see that args->count is just 3 bytes. We wouldn't want to send MAX_STRLEN bytes to userspace, if we know at runtime a smaller, more specific amount.
Here's some (horrifying) code I wrote to make print decide the size of its MEMCPY based on runtime information rather than semantic analysis:
https://github.com/iovisor/bpftrace/compare/master...Birch-san:6c1f19a3a4c3cf253aa23db79f5f637b6823e5b2
Notice how expr2_ is used to pass down a strlen at runtime, instead of using the strlen provided during semantic analysis.
And notice how the str call uses a parameterised AllocInst, so instead of isArrayTy(), its expr_ type has isPointerTy(). (it's a pointer to dynamically-allocated memory)
I reached a dead-end here because printf() allocates a buffer based on an LLVM StructType. It can store strings in ArrayType members, but you need to declare the size of the ArrayType up front. You cannot use an LLVM Value to dynamically size it.
The workaround here would be to stop using StructType and instead use a basic AllocInst. These support dynamic sizes based on LLVM Value. Or even better: we can use off-stack memory (a BPF map) instead of doing an allocation inside printf().
====
In conclusion: there may be a path to supporting arbitrarily-large strings. Bonus points if we can also make the perf event output buffer dynamically-sized, so we can transfer the smallest message possible (instead of our maximum buffer size). A big advantage of dynamic sizing is that the user wouldn't have to tune their maximum buffer size for the sake of performance.

Thanks for this work, and that's a good investigation for future support of larger strings -- for which we probably will need a string map that can be implemented similar to join's needs_join_map_ etc. I'd create a new ticket for this "str() to accept large lengths" and refer to this PR comment.
As for this PR:

The USAGE message is getting too big and wide (I avoid >80 char width). I'd reduce it to just:

ENVIRONMENT:
    BPFTRACE_STRLEN    [default: 64] bytes on BPF stack by str().

(which needs an extra std::endl at the end), and then put a section in the reference guide with a longer explanation. Maybe under the first Usage section, a new "7. Environment Variables". The docs should be as short as possible.

If a user sets strlen to be something large, I imagine they'll get a compiler error. I'd put a check when the environment variable is read for some sane maximum -- eg, 400 bytes -- and then print a detailed error message if that is exceeded. Something like:

ERROR: str() length %d exceeds the current maximum of 400 bytes.
This limitation is because strings are currently stored on the 512 byte BPF stack.
A future enhancement will remove this limitation.

I'd create a new ticket for this "str() to accept large lengths"

Done: https://github.com/iovisor/bpftrace/issues/305

USAGE message is getting too big and wide

I've committed the following docs changes:

shortened the -h message
changed method signature in README.md
detailed str() and env in reference_guide.md
added learnings to internals_development.md

check when the environment variable is read for some sane maximum

Experimentally, the largest buffer I've fit into the stack (with a str() and a print()) is 240 bytes. I've added a friendly 200-byte limit + error message that will protect the user in the average case.
If they have a deep stack, or multiple calls to str() in their program, then the parameter validation won't save them. But the message from the verifier (stack limit exceeded, large on-stack variables) is pretty instructive anyway.

Excellent, and thanks for all the additions to the internals development guide!


If the grid box like gridstackjs would be better

Here is the grid stack http://gridstackjs.com/#demo
But it is not an Angular component.


Fixes #1914 The info dialog for image description opens only on touch of info icon.

Title (required)
Fixes #1914 Description info dialog opens when tapped on the EditText in the blank space between hint and info icon.
Description (required)
Fixes #1914
The motionEvent.getRawX() used inside the onTouch callback won't work properly if the EditText's parent is not aligned with the left of the screen. Using motionEvent.getX() instead will give the correct value. This will allow the icon to be considered only where it is seen and the dialog is opened on tapping the 'i' icon.
Tests performed (required)
Tested on Moto G4 Plus (Android 7.0 API 24), with 2.8.3-debug-master build.
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

Codecov Report

Merging #1915 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #1915   +/-   ##
======================================
  Coverage    3.71%   3.71%
======================================
  Files         192     192
  Lines        9915    9915
  Branches      886     886
======================================
  Hits          368     368
  Misses       9520    9520
  Partials       27      27

Impacted Files
Coverage Δ

...r/free/nrw/commons/upload/DescriptionsAdapter.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825a1a0...dacafc5. Read the comment docs.


Move documentation forward.

As a future project manager, I will take on the role of moving the documentation forward. This will include following up on the contents/assignee of the ReadMe and Wiki.
ReadMe revisions (Related #91)
Wiki - Home (Related #173)
Wiki - Application Architecture (Related #174)
Wiki - Editing user permissions in Home Assistant (Related #175)
Wiki - Notes Alexi (Related #177)
Wiki - Wiregaurd VPN Setup (Related #178)

Added myself to this issue as I didn't think it was totally necessary for the few changes I made in PR #172, so I figured I'd reference this issue since it helps move the documentation forward in a very small way.


Make it easy to delete forks

You know the drill. You want to contribute, so you create a fork, do a simple change and create pull request.  Can we do something about this? Make it easier to delete fork repos? Or maybe toggle to hide such repos?

We have added a link to delete your fork on a merged PR in #49 and fixed it in #321:

However, I think this has been broken again for some time now. I'll mark this issue as a bug.
@ostrolucky Are you willing to look into the code from the mentioned pull requests, find the cause why it's not working and submit a pull request? That would be awesome!

I am seeing this even if i dont have access. Can we test the link to see if its leads to 404?

How can you not delete the fork if you can delete a branch (of a fork)? Where are you seeing this?

@bfred-it very simple if you have write access to a repo and that repo made a pull request to a fork

I think this can be verified by looking for the Settings tab in the repo. You can’t access that page, right?
PRs welcome

GitHub provides deleting a fork after merge/close out the box now:

https://github.com/sindresorhus/refined-github/issues/1786


Archive was empty for icon

When dev-building icon out-of-source from an empty folder, this error happens:
==> Error: FetchError: Archive was empty for icon

/users/hdominic/spack-c2sm/spack/lib/spack/spack/package.py:1562, in do_stage:
       1559            self.do_fetch(mirror_only)
       1560            self.stage.expand_archive()
       1561
  >>   1562            if not os.listdir(self.stage.path):
       1563                raise FetchError("Archive was empty for %s" % self.name)
       1564        else:
       1565            # Support for post-install hooks requires a stage.source_path

This is an artefact from our workaround to make out-of-source builds work, even though Spack doesn't support it.
I think we should create a dummy file to avoid the error, something like .dummy_file_for_spack.

I made out-of-source builds work for environments. In that case you need to copy the config/cscs/spack/... folder in your build directory.
Using dev-build is not tested nor did I intend to make it work, since C2SM only supports environment.
But still you can add docs an claim to touch fake_file in case of dev-build

It also happens with an environment and a dev path and spack install.

Copying the folder into the build directory fixes this issue.


Check for non-ISA operation inside operation flow blocks

Summary
Fixes a bug, where some of the ISA checks were skipped in dynamic circuits.
Details and comments
Fixes #1717.
I'll add a release note in a minute.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.204%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
6125

Relevant Lines:
7451

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.204%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
6125

Relevant Lines:
7451

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.204%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
6125

Relevant Lines:
7451

💛  - Coveralls


Rename Cargo.lock

Cargo.lock as a name has a few problems:

It doesn't play well with tab completion (as reported before in #7603).
It is never edited by hand and yet it has a very user-friendly name which is similar to Cargo.toml (despite it being completely different from the user's perspective). This is potentially misleading.
It doesn't have the .toml extension despite being TOML (although this doesn't matter too much).

To solve this, I recommend adding support for another name as well as Cargo.lock that will solve the above three problems. Cargo.lock will continue to be supported forever, but the new name will take precedence and cargo new will use the new name.
This new name should start with ., to emphasize that it is only used by programs and not people. Doing this will also reduce clutter in root directories as it will be hidden or tucked away at the top. It should also not drastically change the name (e.g. adding package/Lockfile etc), so that existing Rustaceans won't be confused. Something like .cargo.lock.toml, .Cargo.lock.toml or .cargo-lock.toml would be ideal.

With the benefit of hindsight, perhaps we would have used another name for the lockfile. (And in particular, we ideally would have used a name that ended in .toml.) But at this point, a transition would be a substantial amount of churn.
Also, I don't think we should use a hidden file for something that appears in every crate, affects the build of the crate, and will often be checked into version control. I could imagine using cargo.lock.toml, though.
Given the amount of churn this would entail, and the fact that for the foreseeable future we'd have two names rather than one, versus the amount of benefit this would provide, I don't think we should rename this file.

In addition we would need a plan for the transition. One that does not have different versions of Cargo successfully building the same project but using different lockfiles.

Also, I don't think we should use a hidden file for something that appears in every crate, affects the build of the crate, and will often be checked into version control.

I think a hidden file is appropriate, since at least from the user's perspective Cargo.lock is merely an implementation detail of Cargo. Most users will never even touch it, so it makes sense to hide it. If someone tries manually editing their Cargo.lock, having it be a dotfile lets them know what they're getting in to - something that you don't have to think about in 99% of cases.
I don't see what churn this would cause. Most external Cargo tools rely on the cargo crate and don't implement Cargo.lock finding themselves. No existing crates would have to change, and new crates wouldn't even notice the difference.

One that does not have different versions of Cargo successfully building the same project but using different lockfiles.

Crates that commit their Cargo.lock would have to stick to the old system for a while to support old Cargo versions. Maybe cargo new --bin would use the old Cargo.lock for a while until everyone has updated their Cargo.

A third issue about the same thing: https://github.com/rust-lang/cargo/issues/8624
Would it be possible to change this with a rust edition, such as 2024?

See https://github.com/rust-lang/cargo/issues/5707#issuecomment-2231276362
There is no plan to support different filename now.


custom-editor-field hook not working as expected: reference custom component by type and not by name

https://github.com/burdy-io/burdy/issues/61
because field.name could be another one for each cms content type,
I think the reference to a custom component may be done by the type which is fixed by adding the hook

Hi @manzsolutions-asc, thank you very much I will check it out now!

You are correct, this was a typo from our side while migrating to GitHub, I'll merge PR just now!
Thanks again!


Sentry does not send events

How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.13.0
Steps to Reproduce

Follow the installation Python/Django tutorial - my project has Django Channels and Uvicorn, but I've worked before with another projects and they used to work well.
Add a path to test the error sending
Nothing was sent to my sentry.io issues panel

Expected Result
Bunches of ZeroDivisionError at /sentry-debug/ on issues panel at sentry.io
Actual Result
Nothing shows up on issues panel at sentry.io. Turning on the debug option on the sentry_sdk.init() function, I was able to see an ERROR: Internal error in sentry_sdk. Here's the log when I access the admin home page:
[sentry] DEBUG: [Tracing] Starting <http.server> transaction <generic ASGI request>
reload-backend-django-1  | INFO:     <IP_ADDRESS>:50232 - "GET /admin/ HTTP/1.1" 200 OK
reload-backend-django-1  |  [sentry] ERROR: Internal error in sentry_sdk
reload-backend-django-1  | Traceback (most recent call last):
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/django/__init__.py", line 441, in event_processor
reload-backend-django-1  |     DjangoRequestExtractor(request).extract_into_event(event)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/_wsgi_common.py", line 72, in extract_into_event
reload-backend-django-1  |     elif self.raw_data():
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/django/__init__.py", line 484, in raw_data
reload-backend-django-1  |     return self.request.body
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/http/request.py", line 340, in body
reload-backend-django-1  |     self._body = self.read()
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/http/request.py", line 404, in read
reload-backend-django-1  |     return self._stream.read(*args, **kwargs)
reload-backend-django-1  |   File "/usr/local/lib/python3.8/tempfile.py", line 728, in read
reload-backend-django-1  |     return self._file.read(*args)
reload-backend-django-1  | ValueError: I/O operation on closed file.
reload-backend-django-1  |  [sentry] DEBUG: Sending envelope [envelope with 1 items (transaction)] project:4504521306406912 host:o4504408550998016.ingest.sentry.io
reload-backend-django-1  |  [sentry] DEBUG: [Tracing] Adding `sentry-trace` header 657f4ff9d1224574b2d3507f2ff9bf6c-8040eea479b5717f- to outgoing request to https://o4504408550998016.ingest.sentry.io/api/4504521306406912/envelope/.

More logs from different pages. Here's the log when I access some 404 page:
reload-backend-django-1  |  [sentry] DEBUG: [Tracing] Starting <http.server> transaction <generic ASGI request>
reload-backend-django-1  | Not Found: /
reload-backend-django-1  | INFO:     <IP_ADDRESS>:52852 - "GET / HTTP/1.1" 404 Not Found
reload-backend-django-1  |  [sentry] ERROR: Internal error in sentry_sdk
reload-backend-django-1  | Traceback (most recent call last):
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/django/__init__.py", line 441, in event_processor
reload-backend-django-1  |     DjangoRequestExtractor(request).extract_into_event(event)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/_wsgi_common.py", line 72, in extract_into_event
reload-backend-django-1  |     elif self.raw_data():
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/django/__init__.py", line 484, in raw_data
reload-backend-django-1  |     return self.request.body
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/http/request.py", line 340, in body
reload-backend-django-1  |     self._body = self.read()
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/http/request.py", line 404, in read
reload-backend-django-1  |     return self._stream.read(*args, **kwargs)
reload-backend-django-1  |   File "/usr/local/lib/python3.8/tempfile.py", line 728, in read
reload-backend-django-1  |     return self._file.read(*args)
reload-backend-django-1  | ValueError: I/O operation on closed file.
reload-backend-django-1  |  [sentry] ERROR: Internal error in sentry_sdk
reload-backend-django-1  | Traceback (most recent call last):
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/sessions/backends/base.py", line 187, in _get_session
reload-backend-django-1  |     return self._session_cache
reload-backend-django-1  | AttributeError: 'SessionStore' object has no attribute '_session_cache'
reload-backend-django-1  |
reload-backend-django-1  | During handling of the above exception, another exception occurred:
reload-backend-django-1  |
reload-backend-django-1  | Traceback (most recent call last):
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/django/__init__.py", line 445, in event_processor
reload-backend-django-1  |     _set_user_info(request, event)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/django/__init__.py", line 512, in _set_user_info
reload-backend-django-1  |     if user is None or not is_authenticated(user):
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/django/__init__.py", line 79, in is_authenticated
reload-backend-django-1  |     return request_user.is_authenticated
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/utils/functional.py", line 266, in inner
reload-backend-django-1  |     self._setup()
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/utils/functional.py", line 419, in _setup
reload-backend-django-1  |     self._wrapped = self._setupfunc()
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/auth/middleware.py", line 25, in <lambda>
reload-backend-django-1  |     request.user = SimpleLazyObject(lambda: get_user(request))
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/auth/middleware.py", line 11, in get_user
reload-backend-django-1  |     request._cached_user = auth.get_user(request)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/auth/__init__.py", line 191, in get_user
reload-backend-django-1  |     user_id = _get_user_session_key(request)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/auth/__init__.py", line 60, in _get_user_session_key
reload-backend-django-1  |     return get_user_model()._meta.pk.to_python(request.session[SESSION_KEY])
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/sessions/backends/base.py", line 53, in __getitem__
reload-backend-django-1  |     return self._session[key]
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/sessions/backends/base.py", line 192, in _get_session
reload-backend-django-1  |     self._session_cache = self.load()
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/sessions/backends/db.py", line 42, in load
reload-backend-django-1  |     s = self._get_session_from_db()
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/contrib/sessions/backends/db.py", line 32, in _get_session_from_db
reload-backend-django-1  |     return self.model.objects.get(
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/db/models/manager.py", line 85, in manager_method
reload-backend-django-1  |     return getattr(self.get_queryset(), name)(*args, **kwargs)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/db/models/query.py", line 646, in get
reload-backend-django-1  |     num = len(clone)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/db/models/query.py", line 376, in __len__
reload-backend-django-1  |     self._fetch_all()
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/db/models/query.py", line 1867, in _fetch_all
reload-backend-django-1  |     self._result_cache = list(self._iterable_class(self))
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/db/models/query.py", line 87, in __iter__
reload-backend-django-1  |     results = compiler.execute_sql(
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1396, in execute_sql
reload-backend-django-1  |     cursor = self.connection.cursor()
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/utils/asyncio.py", line 24, in inner
reload-backend-django-1  |     raise SynchronousOnlyOperation(message)
reload-backend-django-1  | django.core.exceptions.SynchronousOnlyOperation: You cannot call this from an async context - use a thread or sync_to_async.
reload-backend-django-1  |  [sentry] DEBUG: Sending envelope [envelope with 1 items (transaction)] project:4504521306406912 host:o4504408550998016.ingest.sentry.io
reload-backend-django-1  |  [sentry] DEBUG: [Tracing] Adding `sentry-trace` header be102b4a7870413e9bbd8a8f432e3ade-93e388b45326ca99- to outgoing request to https://o4504408550998016.ingest.sentry.io/api/4504521306406912/envelope/.

And a log from the sentry-debug/ (the one that should log the ZeroDivisionError on sentry.io):
reload-backend-django-1  |  [sentry] DEBUG: [Tracing] Starting <http.server> transaction <generic ASGI request>
reload-backend-django-1  |  [sentry] DEBUG: Sending event, type:null level:error event_id:c5d7c162e75346caa2badfb9ad46745d project:4504521306406912 host:o4504408550998016.ingest.sentry.io
reload-backend-django-1  |  [sentry] DEBUG: [Tracing] Adding `sentry-trace` header cc274ca2d2cf473db60129906323cbd5-99b745e74f4b5ddf-1 to outgoing request to https://o4504408550998016.ingest.sentry.io/api/4504521306406912/store/.
reload-backend-django-1  |  [sentry] DEBUG: [Tracing] Adding `baggage` header sentry-trace_id=cc274ca2d2cf473db60129906323cbd5,sentry-environment=local,sentry-release=7ae0bd10ef7eeb6675e64186f6685ec137fd6c00,sentry-public_key=14ca142749174fffbbb2d6aa4083c121,sentry-transaction=/sentry-debug/,sentry-sample_rate=1.0 to outgoing request to https://o4504408550998016.ingest.sentry.io/api/4504521306406912/store/.
reload-backend-django-1  | Internal Server Error: /sentry-debug/
reload-backend-django-1  | Traceback (most recent call last):
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/asgiref/sync.py", line 486, in thread_handler
reload-backend-django-1  |     raise exc_info[1]
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/core/handlers/exception.py", line 42, in inner
reload-backend-django-1  |     response = await get_response(request)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/django/core/handlers/base.py", line 253, in _get_response_async
reload-backend-django-1  |     response = await wrapped_callback(
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/asgiref/sync.py", line 448, in __call__
reload-backend-django-1  |     ret = await asyncio.wait_for(future, timeout=None)
reload-backend-django-1  |   File "/usr/local/lib/python3.8/asyncio/tasks.py", line 455, in wait_for
reload-backend-django-1  |     return await fut
reload-backend-django-1  |   File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
reload-backend-django-1  |     result = self.fn(*self.args, **self.kwargs)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/asgiref/sync.py", line 490, in thread_handler
reload-backend-django-1  |     return func(*args, **kwargs)
reload-backend-django-1  |   File "/root/.local/share/virtualenvs/app-4PlAip0Q/lib/python3.8/site-packages/sentry_sdk/integrations/django/views.py", line 79, in sentry_wrapped_callback
reload-backend-django-1  |     return callback(request, *args, **kwargs)
reload-backend-django-1  |   File "/app/./core/urls.py", line 14, in trigger_error
reload-backend-django-1  |     division_by_zero = 1 / 0
reload-backend-django-1  | ZeroDivisionError: division by zero
reload-backend-django-1  | INFO:     <IP_ADDRESS>:36108 - "GET /sentry-debug/ HTTP/1.1" 500 Internal Server Error
reload-backend-django-1  |  [sentry] DEBUG: Sending envelope [envelope with 1 items (transaction)] project:4504521306406912 host:o4504408550998016.ingest.sentry.io
reload-backend-django-1  |  [sentry] DEBUG: [Tracing] Adding `sentry-trace` header 5f47086be226463e87e8a2e89611a74f-a256ea31bfc84bf8- to outgoing request to https://o4504408550998016.ingest.sentry.io/api/4504521306406912/envelope/.

I can't see an Internal error in sentry_sdk on that one, but the log isn't on sentry.io panel anyway.

The event seems to be captured, as shown on the performance panel:

But they don't show as an error on the issues panel:

The event seems to be captured, as shown on the performance panel:

But they don't show as an error on the issues panel:

The event seems captured on the perfomance tab:

But it doens't show on the issues tab:

Sorry, it appears that was a "usage limit reached" thing that I was not aware of. Closing it.


NumPad and oem keys are not recognized.

Hi,
When trying to enter commas, dots and numpad keys the chars are not valid.
You can use the following GetCharFromKey method to fix :
        public enum MapType : uint
        {
            MAPVK_VK_TO_VSC = 0x0,
            MAPVK_VSC_TO_VK = 0x1,
            MAPVK_VK_TO_CHAR = 0x2,
            MAPVK_VSC_TO_VK_EX = 0x3,
        }

        [DllImport("user32.dll")]
        public static extern int ToUnicode(
            uint wVirtKey,
            uint wScanCode,
            byte[] lpKeyState,
            [Out, MarshalAs(UnmanagedType.LPWStr, SizeParamIndex = 4)]
            StringBuilder pwszBuff,
            int cchBuff,
            uint wFlags);

        [DllImport("user32.dll")]
        public static extern bool GetKeyboardState(byte[] lpKeyState);

        [DllImport("user32.dll")]
        public static extern uint MapVirtualKey(uint uCode, MapType uMapType);

        public static char GetCharFromKey(Key key)
        {
            char ch = ' ';

            int virtualKey = KeyInterop.VirtualKeyFromKey(key);
            byte[] keyboardState = new byte[256];
            GetKeyboardState(keyboardState);

            uint scanCode = MapVirtualKey((uint)virtualKey, MapType.MAPVK_VK_TO_VSC);
            StringBuilder stringBuilder = new StringBuilder(2);

            int result = ToUnicode((uint)virtualKey, scanCode, keyboardState, stringBuilder, stringBuilder.Capacity, 0);
            switch (result)
            {
                case -1:
                    break;
                case 0:
                    break;
                case 1:
                    {
                        ch = stringBuilder[0];
                        break;
                    }
                default:
                    {
                        ch = stringBuilder[0];
                        break;
                    }
            }
            return ch;
        }

Hi, I know that issue and now working on it about one year.
I will implement your code on hexaeditor this week :)
Thank you for your help. Best regards :)

It's implemented and work fine. I can't test numpad on my laptop. Can you check this please ?

Works


Sorting by Date

Awesome Plugin.
The documentation doesn't give much detail on other objects to sort on or how to customize sort.
How would you suggest I go about ordering a column by date?
`

                            Customer

                            Date

                            Phone #

                            Address

                 `

I am wanting to add the code to this block of javascript:
`    dateOrder(row){
      ?

    }`

Thank you.

Thanks for checking out the plugin. As of right now you cannot do custom sort, but that is my next item to implement. I will have time to implement it today or tomorrow, so bear with me a little bit I will add that functionality very soon.

That sound good to me!
Let me know if I can contribute 👍

I have added the option to provide a custom sorting function. Please check the sorting section of the documentation.
https://tochoromero.github.io/aurelia-table/

Worked like a charm 💯

One sec,
I did try to sort on a more "complicated" date string, and the sorting function doesn't seem to like it. Nothing happens (no crash, or no sorting).
This is an example the date string coming from the server:
2002-10-04T03:05:07.65
which  converts to a date object like this:
Thu Oct 04 2002 23:05:07 GMT-0400 (Eastern Daylight Time)
After the call to:
let date1 = new Date(a.creationTime);
in the dateSort function.
Any thoughts?

Hmm not sure here, have you debugged your method to see if it is doing the comparation correctly? I wonder if you need to specify the date format when creating the new Date object.

We were using some dummy data generator that returned some unparseable stuff.
Thanks again.


Flag is not changing with phone number

Hi,
I am facing a problem while changing my phone number. when I pick a country from the modal Picker and tries to change my phon number then sometimes the phone number does not reflect with that country code. Also, my flag got vanish from the input. Please see the below screenshot
https://user-images.githubusercontent.com/45659052/108027275-edd7c400-704f-11eb-8716-5ae6ad5b0082.png
https://user-images.githubusercontent.com/45659052/108027355-0ea01980-7050-11eb-96d8-fa67afe34af1.png

Same issue..

Its happening on android only.
Working fine on IOS.
Facing same issue.

+1

I found the problem:
in PhoneNumber.js line: 48
isNumeric(n) {
   return !Number.isNaN(parseFloat(n)) && Number.isFinite(n);
}

should be:
isNumeric(n) {
   return !Number.isNaN(parseFloat(n)) && !Number.isFinite(n);
}

Number.isFinite needs to be negated

https://github.com/rili-live/react-native-phone-input/pull/2

Has this problem been fixed?


The gutter doesn't have colors for collaborators

I saw there is such feature that can show the collaborator's active line in the gutter by a highlighted color.
While I didn't see such colored gutter when I used the normal shared session ID method to collaborate.

Maybe this is because I have a custom theme?


ds-dropdown-menu enhancements

This PR aims to bring drought.ca.gov compatibility to the ds-dropdown-menu component.
The Drought site does not yet have enough content for dropdown lists, so the menu component needs to allow proper spacing and alignment for simple static links (without the dropdown arrow icon).
This PR also includes a fix to the scenario shown in the following screenshot. When a desktop screen is narrow, the right-most dropdown menu can get clipped.

The fix included here aligns that last dropdown to the right edge of the design, like this.

We may want to treat this scenario differently. Let me know if so.

FYI We are getting more drought content which will probably require some drop down menus
Love that you fixed the focus outline. Good catch @kkoryaka
I don't have a solution for this padding issue. We want less padding when there is no visible arrow

I am thinking maybe aligning all menu items to the left side, that way at least we don't have to worry about the right side alignment, and it also go in line with figma prototypes designs. We can play with padding/or negative padding on the left to make it look aligned  where text starts (not necessarily where actual button starts)

That makes a lot of sense, @kkoryaka. Should I merge these changes now, then we'll address padding and menu-items-left-alignment in an upcoming change?

@kkoryaka I've applied some changes here. Menu items are now left aligned, with a gap between of 24px. I've also fixed the padding within menu items, so focus looks better.

Let me know if you think this is ready to go. I'll need to put a couple of changes into Cannabis and Drought afterwards.


Create CITATION.cff

Please check your affiliations!

Please make changes by the 19th of April. I will merge this pull request regardless of missing approvals.


Seeing some weird issues on syncing only z-index changes in collab mode.

Sometimes z-order changes undo on sync. i was looking around at the code and tests and added this test to replicate it which fails. Not sure if i understand things right but should this test pass which is what im doing.
reconciliation.test.ts
test(["B:1","A:2"], ["A:1", "B:1"], ["B:L", "A:L"]);

We've reworked reconciliation based on fractional indices (#7359) and we've recently shipped improvements for undo/redo (#7348) on excalidraw.com & will be shipped on plus.excalidraw.com soonish.
Hence your issues should not be anymore reproducible. In any case, feel free to reopen otherwise!


[Event Request] Table 39 Purchase Line - procedure GetLineAmountToHandle - OnBeforeGetLineAmountToHandle

Please add an Event OnBeforeGetLineAmountToHandle in procedure GetLineAmountToHandle in Table 39 Purchase Line
[Event Request] Table 39 - Purchase Line - procedure GetLineAmountToHandle
var
    LineAmount: Decimal;
    LineDiscAmount: Decimal;
    IsHandled: Boolean;
begin
    if "Line Discount %" = 100 then
        exit(0);

    IsHandled := false;
    OnBeforeGetLineAmountToHandle(Rec, Currency, QtyToHandle, LineAmount, LineDiscAmount, IsHandled); // <-- NEW EVENT
    if IsHandled then
        exit(LineAmount - LineDiscAmount);

    GetPurchHeader();

    if "Prepmt Amt to Deduct" = 0 then
        LineAmount := Round(QtyToHandle * "Direct Unit Cost", Currency."Amount Rounding Precision")
    else
        if Quantity <> 0 then begin
            LineAmount := Round(Quantity * "Direct Unit Cost", Currency."Amount Rounding Precision");
            LineAmount := Round(QtyToHandle * LineAmount / Quantity, Currency."Amount Rounding Precision");
        end else
            LineAmount := 0;

    if QtyToHandle <> Quantity then
        LineDiscAmount := Round(LineAmount * "Line Discount %" / 100, Currency."Amount Rounding Precision")
    else
        LineDiscAmount := "Line Discount Amount";

    OnAfterGetLineAmountToHandle(Rec, QtyToHandle, LineAmount, LineDiscAmount);
    exit(LineAmount - LineDiscAmount);
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeGetLineAmountToHandle(PurchaseLine: Record "Purchase Line"; var Currency: Record Currency; QtyToHandle: Decimal; var LineAmount: Decimal; var LineDiscAmount: Decimal; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 46009.


RSS template in theme is not overriding __internal/rss.xml

If i understand the docs correctly, putting a template in:
/themes/THEME/layouts/_default/rss.xml

should override the default in
__internal/rss.xml

However, the only way I can get this to work is by putting the rss template in the main site, i.e.,
/layouts/rss.xml

Maybe I am missing something or did I find a bug?
Maybe this is related to #532 since I am using:
permalinks:
  post: /:year/:month/:slug/

I have an issue with my .xml file as well. It's a bit different, I can't see the RSS links working www.wasim.blog/index.xml and I didn't change the template "Cactus Plus" files.


bug fix: lockout user throws error

When using Email address as username:
Login blocked after several failed login attempts. So the user is locked out for a few minutes, but the problem is user does not see a proper message indicating the locked out state, instead he/she receives  an error!

This is a fix for https://dnntracker.atlassian.net/browse/DNN-9194

@galatrash-at-dnn just noticed in my git graph that this was merged into release/8.0.4 instead of development

@bdukes,  I reverted this PR as #1900. Will you please rebase this fix on the development branch and submit a new PR?

@ehsanshirazi, will you please rebase this fix on the development branch and submit a new PR?


[Rest-server] reset killAllOnCompletedTaskNumber default value to 1

Coverage increased (+18.0%) to 67.068% when pulling 5775b44286143b42f549ff429500bd250e508506 on canwan/reset-default-value into fdd08fbd27743026918d397ab765dd6b5b38d5d2 on master.

Coverage increased (+18.0%) to 67.068% when pulling 5775b44286143b42f549ff429500bd250e508506 on canwan/reset-default-value into fdd08fbd27743026918d397ab765dd6b5b38d5d2 on master.


Lots of mscorlib issues with 3rd party packages

Hi
I'm getting a lot of mscorlib issues with 3rd party nuget packages, any idea how to fix these?

Running on Windows 7.1, targeting .net 4.5.2, Atom 1.0.2, omnisharp-atom 0.19.1.

I moved your issue here https://github.com/OmniSharp/omnisharp-roslyn/issues/265

Thanks
On Fri, Jul 10, 2015 at 2:38 PM, Jason Imison<EMAIL_ADDRESS>wrote:

I moved your issue here OmniSharp/omnisharp-roslyn#265
https://github.com/OmniSharp/omnisharp-roslyn/issues/265
—
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/omnisharp-server/issues/204#issuecomment-120400321
.

Fixed in omnisharp-roslyn v1.4.1


Error when used with Django CMS 3.6

Traceback (most recent call last):
File "./manage.py", line 22, in
execute_from_command_line(sys.argv)
File "/data/djangocms/lib/python3.7/site-packages/django/core/management/init.py", line 364, in execute_from_command_line
utility.execute()
File "/data/djangocms/lib/python3.7/site-packages/django/core/management/init.py", line 338, in execute
django.setup()
File "/data/djangocms/lib/python3.7/site-packages/django/init.py", line 27, in setup
apps.populate(settings.INSTALLED_APPS)
File "/data/djangocms/lib/python3.7/site-packages/django/apps/registry.py", line 116, in populate
app_config.ready()
File "/data/djangocms/lib/python3.7/site-packages/cms_articles/apps.py", line 10, in ready
from . import signals
File "/data/djangocms/lib/python3.7/site-packages/cms_articles/signals/init.py", line 10, in
from .plugins import post_reorder_plugins, pre_delete_plugins, pre_save_plugins
File "/data/djangocms/lib/python3.7/site-packages/cms_articles/signals/plugins.py", line 3, in
from cms.signals.plugins import get_placeholder
ModuleNotFoundError: No module named 'cms.signals.plugins'

Hi Eman, thank You for Your report. I know about it and I'd like to fix it soon. There may however be some more things to do support django CMS 3.6. I'll notify You here once it is ready.

django CMS 3.6 is supported in version 1.3.


android: UnifiedPush unregister doesn't remove the subscription from the list

I'm using the UnifiedPush SDK.
When calling unregister on an existing endpoint, my onUnregistered callback gets triggered as expected, however the subscription remains listed in the ntfy app. This causes the list in the app to grow in an unbounded fashion, ending up with hundreds of subscriptions after a month or so.

my onUnregistered callback gets triggered as expected

This sounds like a bug in the Flutter connector sadly:
https://github.com/UnifiedPush/flutter-connector/blob/main/unifiedpush_android/lib/unifiedpush_android.dart#L50

I am always happy to help, but this seems like it should not be a bug report in ntfy, no?
I am respectfully closing this ticket, but feel free to comment and we can discuss more.


Add consistency option to summarize

Describe the bug
The summarize endpoint should support the consistency option

Adding this today


FilePond#addFiles ignores options.type

When calling pond.addFiles(fileIds, { type: 'local' }), the type is ignored and the files are processed. I expect the files to be loaded instead, like pond.addFile(fileId, { type: 'local' }). The expected behaviour was observed in FilePond 3.7, but not in 4.2.
I am using Chrome 72 on Ubuntu 18.04.

addFiles should not be used for setting initial files only for adding new files, please use files for setting initial files.

In this case, we are also support adding new local files to the widget after FilePond has been initialised. Should we use pond.setOptions({ files: allFileIds }) in this case, or this not supported?
For what it is worth, pond.addFile(newId, { type: 'local' }) seems to work correctly, triggering load and all that.

Yes updating the files property should work. I'll look into the addFile thing just to be sure.

Confirmed the problem. Fixing now.

Fixed in version 4.3.0


unreachable flow control

cppcheck messages:
{{{
src/tests/osal-core-test/osal-core-test.h:347: style: Consecutive return, break, continue, goto or throw statements are unnecessary.
}}}
Yes, the code does have two return statements in a row (this is not the
case where cppcheck was getting hideously confused in a header).

Imported from trac issue 131.  Created by glimes on 2015-12-10T14:36:46, last modified: 2016-01-14T11:33:37

Trac comment by glimes on 2015-12-31 15:28:21:
[changeset:f287965] is ready to go.

Trac comment by sstrege on 2016-01-05 17:15:27:
Recommend/accept

Trac comment by sduran on 2016-01-08 14:20:29:
recommend accept

Trac comment by glimes on 2016-01-11 13:11:43:
Per discussion on CFS CCB telecon,
marking the proposed tickets with
the "osal-4.2" Milestone.

Trac comment by glimes on 2016-01-14 11:31:23:
Included in the 2016-01-11 CCB merge.

Trac comment by jphickey on 2016-01-11 14:09:19:
recommend accept

Trac comment by glimes on 2016-01-14 11:33:37:
Development advanced to include the 2016-01-11 merge.


Include trimOffsetRight & trimOffsetBottom

Feature request
After trimming an image with .trim() you receive an info object, which includes the trimOffsetLeft and trimOffsetTop properties.
However, a picture can be asymmetric, meaning that .trim() will remove differing amounts of border on each side => trimOffsetLeft !== trimOffsetRight.
The current workaround is to calculate the right and bottom offset by hand, with the use of pre-processing metadata and properties included in the resulting info object,
This is the formula used:

Other Offset = Original Length - New Length - |Opposite Offset|

const image = sharp(inputFile);

const data = await image.metadata();
const buffer1 = await image
    .trim()
    .toBuffer({ resolveWithObject: true }); // we get new data after .trim()

const info = buffer1.info;

const trimOffset = {
    left: Math.abs(info.trimOffsetLeft),
    right: data.width - info.width - Math.abs(info.trimOffsetLeft),
    top: Math.abs(info.trimOffsetTop),
    bottom: data.height - info.height - Math.abs(info.trimOffsetTop),
};

Additionally, perhaps the original pre-processing values, such as original width & original height could be included in the resulting info object.

Your approach to calculate these values looks correct and matches the advice previously given at https://github.com/lovell/sharp/issues/3696#issuecomment-1587898783
I'm unsure if this logic needs adding to and therefore fall under the maintenance burden of sharp.

Closing as I'm not keen to add this logic to sharp itself - all the data required to calculate this is already exposed.


Add a license to the repository

I recently came across your project qiskit-zone and I noticed that the repository github.com/708-145/qiskit-zone currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

This repo is meant for "I play around with Qiskit and if anybody can use the files and notebooks just do".
Apache 2.0 fits very well.
PS: Most scripts were written for old versions of Qiskit and do not run anymore. No API stability.

Thanks!


Style fixes for Phoenix Release 3

:star2: What does this PR do?
Fixes two visual bugs

Text on the review button not being centred
Before:

After:

Description and duration on the new entry style not lining up
Before:

After:

:bug: Recommendations for testing
Check appearance of both on PR3 and this branch

@tcrammond I've made some changes to hopefully fix the issues from #1600 (hover styles and integration-filter clear button), works for me at least 🙏

added some padding to make the clickable area bigger :)
@tcrammond could you check the positioning still looks ok for you after this change, since I've had some issues with it previously?

Looks great @lise-toggl 👍


Scoop download doesn't suport redirecting follow

Basicly two issues.

[ ] checkver.ps1 does not support downloading using aria2c
[ ] Scoop basic downloading does not respect redirects

Example manifest **Still in development
When you want to update manifest (-u || -f) scoop will failed because downloading does not support redirection.
No aria2c download even it's set to true
###### Checking for updates
ScoopAsh258 master * = $ .\bin\checkver.ps1 Nox TODO -f # I tweaked that binary little bit
Nox: <IP_ADDRESS> (scoop version is <IP_ADDRESS>)
Forcing autoupdate!
Autoupdating Nox
Downloading fullPackage to compute hashes!
The remote server returned an error: (302) Moved Temporarily.
URL https://www.bignox.com/en/download/fullPackage#/cosi.exe is not valid
Could not find hash!
ERROR Could not update Nox

###### Normal installation without aria2c
ScoopAsh258 master * = $ scoop install .\TODO\Nox.json
Installing 'Nox' (<IP_ADDRESS>) [64bit]
The remote server returned an error: (302) Moved Temporarily.
URL https://www.bignox.com/en/download/fullPackage#/cosi.exe is not valid

# Downloading with aria2 enabled
ScoopAsh258 master * = $ scoop config aria2-enabled true
ScoopAsh258 master * = $ scoop install .\TODO\Nox.json
WARN  Scoop uses 'aria2c' for multi-connection downloads.
WARN  Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
Installing 'Nox' (<IP_ADDRESS>) [64bit]
Starting download with aria2 ...
Download: [#7975c0 0.9MiB/306MiB(0%) CN:5 DL:2.4MiB ETA:2m4s]
Download: [#7975c0 3.2MiB/306MiB(1%) CN:5 DL:2.4MiB ETA:2m6s]
Download: [#7975c0 6.0MiB/306MiB(1%) CN:5 DL:2.5MiB ETA:1m57s]
Download: [#7975c0 8.6MiB/306MiB(2%) CN:5 DL:2.6MiB ETA:1m54s]
Download: [#7975c0 11MiB/306MiB(3%) CN:5 DL:2.6MiB ETA:1m52s]
Download: [#7975c0 13MiB/306MiB(4%) CN:5 DL:2.6MiB ETA:1m51s]

Curl is working as expected if you pass -L argument (curl https://www.bignox.com/en/download/fullPackage -o foo.exe -L)

Does it redirect from https to http? Normally redirects work just fine, but PowerShell doesn't like redirecting to an unsecure connection.

It's from https to http (https://www.bignox.com/en/download/fullPackage => http://res06.bignox.com/full/20180721/fc48166fcf3b4e99a872de2b7926d33a.exe?filename=nox_setup_v<IP_ADDRESS>_full_intl.exe)

It redirects to https://res06.bignox... on my machine. 😕
I didn't want to break the auto-update service, so checkver.ps1 doesn't support aria2. It still has some flaws. 😁

That redirection is now into HTTPS. Maybe some temporary issue 🤔


Initial focus no longer works

For some reason, initial focus does not rest on the first element. This is odd and not intended, as the code is set up to specifically set focus on the first element after building the tree.

Update: I was mistaken - not sure how I missed this.


Various small improvements

This PR:

updates the files from the service template
makes the Crypt4GH tests faster and run with different file sizes
switches to modern type annotations where possible
adds a py.typed file

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 90.865%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
746

Relevant Lines:
821

💛  - Coveralls


KAFKA-6082: Fence zookeeper updates with controller epoch zkVersion

This PR aims to enforce that the controller can only update zookeeper states after checking the controller epoch zkVersion. The check and zookeeper state updates are wrapped in the zookeeper multi() operations to ensure that they are done atomically. This PR is necessary to resolve issues related to multiple controllers (i.e. old controller updates zookeeper states before resignation, which is possible during controller failover based on the single threaded event queue model we have)
This PR includes the following changes:

Add MultiOp request and response in ZookeeperClient
Ensure all zookeeper updates done by controller are protected by checking the current controller epoch zkVersion
Modify test cases in KafkaZkClientTest to test mismatch controller epoch zkVersion

Tests Done:

Unit tests (with updated tests to test mismatch controller epoch zkVersion)
Existing integration tests

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@lindong28 Dong, I have updated the PR to address the comments. Could you take a second look? Thanks!

Hey @hzxa21, is this patch ready for review?

@lindong28 Yes. Can you help take a look?

@hzxa21 Sure. Can you rebase the patch to resolve the conflict?

@lindong28 Rebased onto trunk.

@lindong28 I have updated the PR to add more logging and address the naming issues. Could you take a look again? Thanks!

Thanks Dong for the review. I have addressed the comments and will add more tests for the controller behavior.

Rebased.

Hey @junrao, I have finished reviewing this patch except tests. I will wait for @hzxa21 to add tests. Would you like to review this patch as well?

@junrao @lindong28 Thanks for the comments. I have added some controller integration tests for the patch and address the comments. I will do some perf testing and post the results once I get the numbers.

Also, we didn't have the protection against a stale controller deleting \controller znode when ControllerMovedException is thrown in onControllerFailOver() during controller initialization. This can cause controller switch storm. Consider the following events:

broker A creates /controller znode
broker A reads the controller epoch zkVersion
broker A lose its zk session -> /controller node gets deleted
broker B creates /controller znode
broker B reads the controller epoch zkVersion
broker B increments the controller epoch and bumps the zkVersion of /controller_epoch znode
broker A tries to update zookeeper (e.g. update /admin/reassign_partitions) but fails because /controller_epoch zkVersion mismatch. A ControllerMovedException is thrown.
broker A removes the /controller znode (currently owned by broker B) because we didn't explicitly catch ControllerMovedException in elect() and trigger a controller move in the following code block:

try {
  ...
  onControllerFailOver()
} catch {
  ...
  case e2: Throwable =>
        error("Error while electing or becoming controller on broker %d".format(config.brokerId), e2)
        triggerControllerMove()
}

broker C creates /controller znode
...

This loop may never end and the controller role will keep switching across brokers without making any progress. I have also updated the PR to include the fixes:

Catch ControllerMovedException in elect() without triggering the controller move. This makes sense because when the ControllerMovedException is thrown, the new controller has been elected and there is no need to trigger another round of controller election.
Guard against the \controller deletion by controller epoch zkVersion. This ensures stale controller cannot delete \controller znode.

looks like tests are getting stuck while shutting down the controller.
Observed while running tests  using ./gradlew cleanTest :core:test.
Not able to reproduce If i run individual tests .
"Test worker" #11 prio=5 os_prio=31 tid=0x00007fb95b8e1800 nid=0x5603 in Object.wait() [0x00007000015d2000]
   java.lang.Thread.State: WAITING (on object monitor)
        at java.lang.Object.wait(Native Method)
        at java.lang.Object.wait(Object.java:502)
        at scala.concurrent.forkjoin.ForkJoinTask.externalAwaitDone(ForkJoinTask.java:295)
        - locked <0x0000000795b0f330> (a scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask)
        at scala.concurrent.forkjoin.ForkJoinTask.doJoin(ForkJoinTask.java:341)
        at scala.concurrent.forkjoin.ForkJoinTask.join(ForkJoinTask.java:673)
        at scala.collection.parallel.ForkJoinTasks$WrappedTask$class.sync(Tasks.scala:378)
        at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.sync(Tasks.scala:443)
        at scala.collection.parallel.ForkJoinTasks$class.executeAndWaitResult(Tasks.scala:426)
        at scala.collection.parallel.ForkJoinTaskSupport.executeAndWaitResult(TaskSupport.scala:56)
        at scala.collection.parallel.ExecutionContextTasks$class.executeAndWaitResult(Tasks.scala:558)
        at scala.collection.parallel.ExecutionContextTaskSupport.executeAndWaitResult(TaskSupport.scala:80)
        at scala.collection.parallel.ParIterableLike$class.foreach(ParIterableLike.scala:463)
        at scala.collection.parallel.immutable.ParVector.foreach(ParVector.scala:38)
        at kafka.utils.TestUtils$.shutdownServers(TestUtils.scala:191)
        at kafka.admin.ReassignPartitionsClusterTest.tearDown(ReassignPartitionsClusterTest.scala:77)

"ForkJoinPool-1-worker-7" #229 daemon prio=5 os_prio=31 tid=0x00007fb961c0f800 nid=0xcc07 waiting on condition [0x00007000019e0000]
   java.lang.Thread.State: WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x00000007b236f8e0> (a java.util.concurrent.CountDownLatch$Sync)
        at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:997)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304)
        at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:231)
        at kafka.utils.ShutdownableThread.awaitShutdown(ShutdownableThread.scala:57)
        at kafka.controller.ControllerEventManager.close(ControllerEventManager.scala:64)
        at kafka.controller.KafkaController.shutdown(KafkaController.scala:180)
        at kafka.server.KafkaServer$$anonfun$shutdown$14.apply$mcV$sp(KafkaServer.scala:601)
        at kafka.utils.CoreUtils$.swallow(CoreUtils.scala:86)
        at kafka.server.KafkaServer.shutdown(KafkaServer.scala:601)
        at kafka.utils.TestUtils$$anonfun$shutdownServers$1.apply(TestUtils.scala:192)
        at kafka.utils.TestUtils$$anonfun$shutdownServers$1.apply(TestUtils.scala:191)

 "controller-event-thread" #1914 prio=5 os_prio=31 tid=0x00007fb961d3f000 nid=0x1ba07 waiting on condition [0x000070000beca000]
   java.lang.Thread.State: WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x00000007b236f250> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
        at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
        at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
        at kafka.controller.ControllerEventManager$ControllerEventThread.doWork(ControllerEventManager.scala:80)
        at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:82)

@omkreddy Thanks for the comments. There is indeed a race condition between clearing the queue when handling ControllerMovedException and closing ControllerEventManager. Because we use a special event to interrupt and shutdown the controller event thread, if  ControllerMovedException happens after we put the shutdown event into the queue and before event thread picks it up, the shutdown event get cleared when handling ControllerMovedException.
To resolve it, I added the isShuttingDown flag to ensure that the event queue will not be cleared if the shutdown event has been put into the queue.

@omkreddy @lindong28 @lindong28 Thanks a lot for the review and I really appreciated the comments. I have updated the PR to address the issues. Could you take a look again?

@hzxa21 It seems that if controller receives ControllerMovedException, the controller should not simply remove all events from the controller queue. Events such as Reelect and ControlledShutdown probably should stay in the queue as these events need to be processed even if the broker is not controller. If we do this, we can solve the race condition without having the additional isShuttingDown. And we can also make the change that Jun suggested previously without worrying about Reelect event being removed from the controller event queue. What do you think?

@lindong28 Thanks for the comment. You brought up a very good point. We need to differentiate between events that need to be processed by the active controller and events that need to be processed by every broker. Because ControllerMovedException only indicates active controller role switched, we shouldn't try to stop processing events in the latter category.
From the implementation point of view, we can just mark the controller as inactive and resign without touching the event queue at all instead of doing a conditional clear operation on the queue. The reason why we want to clear the queue before is that if controller has moved, we don't want the event thread to waste cycles on unnecessary events and want it to get to Reelect as soon as possible by clearing the potential backlog. Since we already have logic like if (!isActive) return to guard against events related to active controller, we just need to preempt the "mark inactive and resign" operation when ControllerMovedException happens. This will ensure correctness as well as simplicity and resolve the event queue backlog with small overhead (most cases we just dequeue controller event and do a boolean check)

I have done perf testing for this PR and here are the results

@hzxa21 : Thanks for the perf results. They look good.

@junrao Thanks so much for all of your comments and suggestions.

@lindong28 Thanks a lot for the reviews.

Did we check the performance impact of this change? If so, it would be great to include the details in the PR description.

@ijuma : There were some perf results. See the above comment on Sep. 4.

Thanks @junrao. That's great. I suggest adding a summary of the results to the PR description.


Manual Instrumentation - create new root activities - example unlcear.

It is unclear where source comes from in the code example about setting up a new root.
Should source in the example given be replaced by MyActivitySource?
public static void DoWork()
{
    var previous = Activity.Current;
    Activity.Current = null;

-    var newRoot = source.StartActivity("NewRoot");
+    var newRoot = MyActivitySource.StartActivity("NewRoot");

    // Re-set the previous Current Activity so the trace isn't messed up
    Activity.Current = previous;
}

If not, can we explain what the source variable holds?

@open-telemetry/dotnet-approvers please take a look

Look like that particular doc page is broken.
In the 1st snippet var serviceName = "MyServiceName"; is done, presumable to use for OTel Resource. But the next snippet var serviceName = "MyCompany.MyProduct.MyService"; looks like trying to define ActivitySource name... But the 3rd snippet public static readonly ActivitySource MyActivitySource = new(TelemetryConstants.ServiceName); is defining ActivitySource with a name from TelemetryConstants class, which is not shown before... There is also usage of DemoSource but that is not defined either.
I think the following should get what you are looking for
var newRoot = MyActivitySource.StartActivity("NewRoot");
(The name of ActivitySource used to create Span/Activity must be added to the TracerProvider via AddSource() calls. This is the key thing.)
Please check if this helps. The doc fixes might take some time.

Yes, for this specifically it should just use MyActivitySource

Fixed in https://github.com/open-telemetry/opentelemetry.io/pull/3250


Always use build kit on deploy

Using Docker 20.10 commands we used before now break like this:
image with reference sha256:6deb7d92f59f205ddaf95230bec403fd117ab8f509074f09a3fc6b108276d744 was found but does not match the specified platform: wanted linux/arm64, actual: linux/amd64

This switches to always use BUILDKIT=1 when pushing images, as Docker
changed behavior in 20.10 and it is more complex to figure out if we are
20.10 or not, and would be annoying to figure out what later versions
would do.
See https://github.com/moby/moby/issues/41552

This didn't work, so reverted it until things in Docker 20 stabalize, ideally to the point it is possible to use the same syntax for both 19 and 20 31b4d18ba72da6aa3bc82c2fb3461e8e1f99da27


Update to @sanity/client v3.x

Update to @sanity/client v3.x, versus the current v2.11.0

Submitted a PR for this, but it may have to wait for the next major version before being merged (if semver is strictly followed).
@mitchuman I've published my own fork to npm registry (which have a version 3.1.0 as peerDeps) if you'd like to use it. I am using it in my own project, run npm install @fevernova90/next-sanity-image to get it.
Warning: Use it at your own risk, also put a note somewhere for your project to change back to the this origin repo/package once there's a new version has been released/merged.

This is fixed from PR 36 and released in version 4.0.0!


"Clear all except" option

Would be good to have an option that, instead of blacklisting domains/urls users could whitelist the ones that can show up in history, deleting all others

I was looking for some kind of whitelist addon myself. This should be a feature. I mean you have this behavior in cookies auto delete extensions. I don't see why it should't be allowed in this one.

Eventually I'll start work on HAD again when I have time.

Was this ever implemented?

@Yapja nop!
The only add-on I'm aware of that allows you to do this is:
History Zebra
( https://addons.mozilla.org/en-US/firefox/addon/history-zebra/ )
It works pretty well, but the GUI is not great.

@ maverick74 That looks promising. I'll disable History AutoDelete until it's implemented.
BTW, do you know if History Zebra can do something like "delete all history from reddit.com except for reddit.com/r/insertsubreddithere"?

@yapja i don't believe so, because i think it can only work with white list or with black list.
It can delete everything but reddit.com/r/insertsubreddithere but to delete just reddit.com execept for reddit.com/r/insertsubreddithere it would require it would include reddit.com on the Black List and reddit.com/r/insertsubreddithere on the white list (and whitelist overpower blacklist).
Meanwhile, last night i made a few searches about the topic and found: History Delete ( https://addons.mozilla.org/en-US/firefox/addon/delete-history/ ) that might solve all the cases


Unable to retrieve records from database

I'm trying to retrieve a record with this:
var users = User.find({ username: "andy" }).then(function(users){
	return users;
});

console.log(users);
return res.send(users);

But I get returned:
{
    "isFulfilled": false,
    "isRejected": false
}

Hi @andyjessop, you have your console.log() outside the then() statement hence it's being executed before User.find() completes and all you get is and unfulfilled promise (not the query results). Try:
    var users = User.find({ username: "andy" }).then(function(users){
	  console.log(users);
	  res.send(users);
          return users;
	});

I suggest you read more about asynchronous development, callbacks and promises.


feat: Better model and model provider serialization

Instead of implementing Display manually, I've used serde(rename) for the Model and ModelProvider enums. The Display trait is then derived from the serialization logic, allowing for what-you-see-is-what-you-get for serialization & stringification.
For example, before this PR Phi3Mini enum was stringified as phi3:3.8b but serialized as "Phi3Mini" due to how serde treats enums. This fixes it so they both are phi3:3.8b and such.
Also changed serde::Serialize, serde::Deserialize to just Serialize, Deserialize

Also helps with code-repetition where we wrote the strings both within TryFrom and Display

oh, this is cool


Update color byte packing

Colors are now packed in little-endian u32s rather than big-endian which lets us get rid of some swizzling within the shaders.
We also get to take advantage of the new to_u8_array functions to simplify the image creation for some tests.

If anything breaks, then it'll just be another step towards having consistent color byte encoding!


user: handle unknown superuser passwords

Currently, it's not possible to define configuration like this:
resource "redshift_user" "terraform" {
  name      = "terraform"
  superuser = true
  password  = random_password.terraform.result
}

resource "random_password" "terraform" {
  length      = 64
  min_lower   = 1
  min_upper   = 1
  min_numeric = 1
}

Given this configuration, the provider returns an error:
Users that are superusers must define a password.

Upon further investigation, this error is returned from CustomizeDiff. This hook runs before a plan is rendered. This means that on first run, before the Create method for random_password has run, the value for result is not yet known.
GetOk will still return _, true, because it is known that some value is set. When the value is unknown, Get will return the zero value. Any plan time inspection can only occur when the new value is known at plan time.
While I didn't set up real cluster credentials to run the acceptance tests to success for this, I did execute them to ensure that the added test case fails with the original error and proceeds to a connection error with the fix.

does this also fix https://github.com/brainly/terraform-provider-redshift/issues/56 ?

This only changes the behavior when password is unknown, not when it is unset.
I did find the validation implemented in the CustomDiff helpful. Originally I planned to use IAM auth only for the superuser but added a generated password as above since it's required. A viable approach to #56 that doesn't remove this plan-time validation might be something like this:
old, _ := d.GetChange(userPasswordAttr)
if d.Id() != "" && old.(string) == "" {
  # valid: resource is not being created (has id) and no existing password is in state (was imported)
}

Where d is ResourceDiff.

There's probably some logic missing there though. Like you'd also need to check whether superuser's value has changed. If the user was previously not a superuser and had no password but is being converted, a password is presumably required.


interface conversion: antlr.RuleContext is *parser.IdentifierPathContext, not *parser.StateVariableDeclarationContext

Well this one is because grammar file is not supported. It will be sorted out by implementing <6.0 AST grammar changes.

Can be triggered by calling 0x8942A64c1834A926268eb031b80f25336F962bcC


Doesn't listen for all types of geometry loading?

While I was playing around with Kevin's text-geometry component I noticed that adding the physics component from HTML on the page or from the inspector on an entity that already had text-geometry, it loads physics, but doing it programmatically, like say:
var newText = document.createElement('a-entity')
newText.setAttribute('text-geometry', 'value', "foo")
newText.setAttribute('dynamic-body', 'shape', 'box')
this.el.sceneEl.appendChild(newText)

the physics never loads -- the best indication I have is that no debug wireframe appears and the elements don't seem to get pushed in the sim tree in the physics system. Per my @donmccurdy's discussion in the Slack, probably need to listen for different type of attaching geometry?
Glitch for example ("dog?" falls because it's initialized at page load, but the text generated when you click doesn't get simulated behavior event though it has a valid dynamic-body attribute)

Was wanting to explore the combination of these libraries again, and I'd be happy to go hunt down the fix if you @donmccurdy could hazard a guess as to where the bug is/what the fix might look like?

Thanks for filing this, and sorry for the delay —  there are two underlying issues.
(1) physics should be listening for object3dset, which I'll fix shortly.
(2) https://github.com/ngokevin/kframe/issues/105


(pdms)should support monitor pd microservices

Feature Request
Is your feature request related to a problem? Please describe:

Describe the feature you'd like:
After deploy pdms in master as followings:

No related monitor in dashboard.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

/assign @rleungx


allow boxen runs to continue without saving config

From what I can tell, Boxen will always fail when it can't access the OS X keychain, even when its possible to continue running. I hit this issue when trying to run boxen --token abc12345... after ssh-ing in. When that happens, I see the following:
Boxen Keychain Helper: Encountered error code: -25308
Error: User interaction is not allowed.
Boxen Keychain Helper: Encountered error code: -25308
Error: User interaction is not allowed.
Boxen Keychain Helper: Encountered error code: -25308
Error: User interaction is not allowed.
/opt/boxen/repo/.bundle/ruby/2.0.0/gems/boxen-2.6.0/lib/boxen/keychain.rb:48:in `set': Can't save GitHub API Token in the keychain. (Boxen::Error)
        from /opt/boxen/repo/.bundle/ruby/2.0.0/gems/boxen-2.6.0/lib/boxen/keychain.rb:30:in `token='
        from /opt/boxen/repo/.bundle/ruby/2.0.0/gems/boxen-2.6.0/lib/boxen/config.rb:73:in `save'
        from /opt/boxen/repo/.bundle/ruby/2.0.0/gems/boxen-2.6.0/lib/boxen/cli.rb:48:in `run'
        from /opt/boxen/bin/boxen:80:in `<main>'

Even though its possible for Boxen to run successfully without saving.
My solution is to change a failed save to a warning and move forward. Perhaps its possible to do this some other way; if so, please let me know. Another approach might be a flag that allows Boxen to ignore this when set, but continuing on if possible seems like a better default to me, which is why I implemented it this way.

Closing due to inactivity. Please let me know if you are still having this issue or want to pursue it further.


Unable to package solution using v3 createsolution.ps1

Describe the bug
Unable to package solution using v3 createsolution.ps1
To Reproduce
After adding playbook content

Am running createSolution.ps1 with data path as input
/Users/<username>/Azure-Sentinel/Solutions/IllumioSaaS/data

This leads to,
Generating Playbook using Playbooks/Illumio-Port-Blocking-Switch/azuredeploy.json
Error occured in catch of createSolutionV3 file Error details are Exception calling "Add" with "2" argument(s): "Value cannot be null. (Parameter 'key')"
Expected behavior
Solution package should work as expected.

Hello @ashwinvenkatesha, As discussed we will be working on this and try to resolve it from our.
Will be checking with MS team if needed

Here is the fix which helped unblock me
https://github.com/Azure/Azure-Sentinel/pull/11515/commits/d40340c9ed51e75b6d9186e7fd797c12e15866ba

Hi @ashwinvenkatesha , I wanted to check in and see if the issue has been resolved from your end. Please let me know at your earliest convenience.

Here is the fix which helped unblock me d40340c

@ashwinvenkatesha, As mentioned in above comment, closing this issue.