Detach event listeners on destroy

If on receives this, it attaches eventListeners array to this and stores { element, type, callback } hash in there. Later, during the destruction process, all the entries from this array will be processed by unbindListeners helper to detach all the event listeners.
Link to related issue (if applicable)
None
Summary of proposed changes
Detach event listeners on destroy
Checklist

[x] Use develop as the base branch
[x] Exclude the gulp build (/dist changes) from the PR
[x] Test on supported browsers

Sidestory
In one of the projects in which I participate, we ensure that all of the event listeners detach on destroy. To do this, we use a little homemade karma plugin, that started to complain about the abandoned event listeners after the upgrade from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Failed: Some module attached element-listeners on init but did not detach them on destroy:
  [Function: function (event) { // We only care about space and ⬆ ⬇ ➡ if (![32, 38, 39, 40].includes(event.which)) { return; } //...] as "keydown" event listener has been attached to <button class="plyr__control plyr__control--forward">
  [Function: function (event) { // We only care about space and ⬆ ⬇ ➡ if (![32, 38, 39, 40].includes(event.which)) { return; } //...] as "keyup" event listener has been attached to <button class="plyr__control plyr__control--forward">
  [Function: function (event) { if (event.which !== 13) { return; } controls.focusFirstMenuItem.call(_this2, null, true); }] as "keyup" event listener has been attached to <button class="plyr__control plyr__control--forward">
  [Function: function () { showMenuPanel.call(_this10, type, false); }] as "click" event listener has been attached to <button class="plyr__control plyr__control--forward">
  [Function: function (event) { // We only care about <- if (event.which !== 37) { return; } // Prevent seek event.preventDefault(...] as "keydown" event listener has been attached to <div id="plyr-settings-1116-captions">
  [Function: function () { showMenuPanel.call(_this10, 'home', false); }] as "click" event listener has been attached to <button class="plyr__control plyr__control--back">

Notes about testing in various browsers:

Plyr is not displaying correctly in IE10 (screenshot), I suggest to drop the support of IE10 officially.
I couldn't run the demo after the rebuild because of the Uncaught ReferenceError: %name% is not defined until I removed Raven and Shr usage.

https://github.com/sampotts/plyr/blob/aa51719a5534eced78e9f0f9f90bc5926673e0b5/src/js/plyr.js#L1153-L1156
This approach provokes problems as callbacks don't check the existence of media element or elements hash.  To get rid of annoying Cannot read property '%%' of null type errors, I wrote and use this patch, maybe you will find some food for thought there:
From 2941533e783766f16913cf238feb4fa4b019a2e1 Mon Sep 17 00:00:00 2001
From: nskazki<EMAIL_ADDRESS>Date: Thu, 18 Jul 2019 16:11:00 +0300
Subject: [PATCH] avoid possible race conditions caused by the destroying of plyr

---
 src/js/plyr.js | 37 +++++++++++++++++++++++++++++++++----
 1 file changed, 33 insertions(+), 4 deletions(-)

diff --git a/src/js/plyr.js b/src/js/plyr.js
index f30d334a..22239f56 100644
--- a/src/js/plyr.js
+++ b/src/js/plyr.js
@@ -34,6 +34,37 @@ import { parseUrl } from './utils/urls';
 // TODO: Use a WeakMap for private globals
 // const globals = new WeakMap();

+const myDumpDiv = document.createElement('div');
+const myDumpVideo = document.createElement('video');
+const myDumpAudio = document.createElement('audio');
+const myDumpInput = document.createElement('input');
+const myDumpProgress = document.createElement('progress');
+
+const myIsElm = (v) => is.element(v);
+const myIsVideo = (v) => myIsElm(v) && v.nodeName === 'VIDEO';
+const myIsAudio = (v) => myIsElm(v) && v.nodeName === 'AUDIO';
+const myIsInput = (v) => myIsElm(v) && v.nodeName === 'INPUT';
+const myIsProgress = (v) => myIsElm(v) && v.nodeName === 'PROGRESS';
+
+const myIsObject = (v) => v !== null && typeof(v) === 'object';
+
+const myMock = (obj) => {
+    const keys = is.array(obj) ? Object.keys(obj) : Object.getOwnPropertyNames(obj);
+    const dumb = is.array(obj) ? [] : {};
+    for (let index = 0, length = keys.length; index !== length; index+=1) {
+        const key = keys[index];
+        const val = obj[key];
+        if (myIsVideo(val)) dumb[key] = myDumpVideo;
+        else if (myIsAudio(val)) dumb[key] = myDumpAudio;
+        else if (myIsInput(val)) dumb[key] = myDumpInput;
+        else if (myIsProgress(val)) dumb[key] = myDumpProgress;
+        else if (myIsElm(val)) dumb[key] = myDumpDiv;
+        else if (myIsObject(val)) dumb[key] = myMock(val);
+        else dumb[key] = val;
+    }
+    return dumb;
+};
+
 // Plyr instance
 class Plyr {
     constructor(target, options) {
@@ -1150,10 +1181,8 @@ class Plyr {
                 this.ready = false;

                 // Clear for garbage collection
-                setTimeout(() => {
-                    this.elements = null;
-                    this.media = null;
-                }, 200);
+                this.elements = myMock(this.elements);
+                this.media = myIsAudio(this.media) ? myDumpAudio : myDumpVideo;
             }
         };

--
2.22.0

@sampotts, look at me :cat2:

Think this may solve my issue as well. :)


Update message parser to make it possible to reuse the arg as a scope

So for example the plugin pluginIfNotEmpty/pluginIfNotUndefined can be used without a scope and will insert their arg as scope.
This should reduce many redundant calls where the arg and the scope are the same and since the scope can still be added it doesn't break any existing functionality.

Implemented in version v1.0.27 (4ac036334da19c5be020f7217341a7f54f465959)


Remove e.preventDefault() to solve conflict with passive event listeners

When I use lory.js in Google Chrome 65 (mobile design mode), I got lots of errors in my console as below screenshot.

In the article Making touch scrolling fast by default, I found that we can't use preventDefault in a passive event listener, they will conflict.

If you call preventDefault() in the touchstart or first touchmove events then you will prevent scrolling. The problem is that most often listeners will not call preventDefault(), but the browser needs to wait for the event to finish to be sure of that. Developer-defined "passive event listeners" solve this. When you add a touch event with a {passive: true} object as the third parameter in your event handler then you are telling the browser that the touchstart listener will not call preventDefault() and the browser can safely perform the scroll without blocking on the listener.

I removed e.preventDefault(); line, there's no errors in my console now (mobile design mode).

https://github.com/meandmax/lory/blob/master/src/lory.js#L466
I think that is already done, anyways thank you for contributing.


Edit Collection page

What this PR does / why we need it:
Adds the edit collection page in the SPA.
Reuses the form to create a collection with a few refactors to be able to work for both modes (create and edit).
Which issue(s) this PR closes:

Closes #545

Special notes for your reviewer:
This can be reviewed as it is now, but for QA purposes I would wait until these two issues are merged first:

https://github.com/IQSS/dataverse-client-javascript/pull/215
https://github.com/IQSS/dataverse/pull/11026

Suggestions on how to test this:
Step 1: Run the Development Environment

Execute npm i.
Navigate with cd packages/design-system && npm i && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
Navigate with cd dev-env.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the feature
Create subcollections and edit them, go to edit them again and validate that the fields are changed.
Validate that works similar as in the JSF version.
Also validate that when editing the root collection the form also looks the same way as in JSF.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No, pretty much the same UI from the create collection page.
Is there a release notes update needed for this change?:
No
Additional documentation:
No

coverage: 97.754% (+0.2%) from 97.561%
when pulling 900f8aa65bd1d471ec570eeab74c51edeb255654 on feat/545-edit-collection-page
into 53a6a3f7e014ea34024597ee3f8f3bc507f04759 on develop.

@ekraffmiller all requested changes have been addressed, let me know if I have missed anything.

Removing waiting tag since https://github.com/IQSS/dataverse-client-javascript/pull/215 and https://github.com/IQSS/dataverse/pull/11026 have been merged.

Tested in local no issues found during testing.
https://github.com/user-attachments/assets/0a5e69c9-a553-45ff-9bc0-e850b1db15ef
One observation made during testing of storybook > Pages /Edit Collection

The two messaging boxes aren't aligned the same


Azure blob storage issues after 4.6.0 -> 4.6.1 update

After updating from 4.6.0 to 4.6.1 we are getting the following error:
2024-09-17T04:41:33.5625408Z TypeError: this.source.on is not a function
2024-09-17T04:41:33.5626232Z at RetriableReadableStream.setSourceDataHandler (/www/node_modules/@azure/storage-blob/dist/index.js:10723:21)
2024-09-17T04:41:33.5626280Z at new RetriableReadableStream (/www/node_modules/@azure/storage-blob/dist/index.js:10711:15)
2024-09-17T04:41:33.5626333Z at new BlobDownloadResponse (/www/node_modules/@azure/storage-blob/dist/index.js:10822:35)
2024-09-17T04:41:33.5626370Z at BlobClient.<anonymous> (/www/node_modules/@azure/storage-blob/dist/index.js:12982:47)
2024-09-17T04:41:33.5626403Z at step (/www/node_modules/tslib/tslib.js:141:27)
2024-09-17T04:41:33.5626509Z at Object.next (/www/node_modules/tslib/tslib.js:122:57)
2024-09-17T04:41:33.5626547Z at fulfilled (/www/node_modules/tslib/tslib.js:112:62)
2024-09-17T04:41:33.5626583Z at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2024-09-17T04:41:33.5641075Z Killing web server because initial health check failed

Similear issues we found:
https://github.com/Azure/azure-sdk-for-js/issues/25552
https://github.com/oven-sh/bun/issues/4067

Investigation:
import-map-deployer's initial health check reads the import map, then writes it, then reads it again. Based on the BlobDownloadResponse portion of the stacktrace, my guess is that it's failing during the read. This line might be the line calling into @azure/storage-blob and triggering the error.
https://github.com/single-spa/import-map-deployer/blob/e84f66033ae6d17cf58b26f74106a7b47cb80629/src/io-methods/azure.js#L57
import-map-deployer upgraded some dependencies, but the dependency for @azure/storage-blob was not upgraded (see git blame). Perhaps a dependency of azure/storage-blob was upgraded. I will try to replicate the issue.

I have replicated the issue locally and fixed it. It's related to Azure Storage's tslib dependency not working in Node 20. Upgrading to<EMAIL_ADDRESS>fixes it.
Unfortunately, the import-map-deployer tests don't work because the @azure/core-rest-pipeline dependency doesn't function the same in Jest as in normal Node. See related https://github.com/Azure/azure-sdk-for-js/issues/28940

Released the fix for this in 5.0.0. The upgrade to Node 20 is a breaking change to import-map-deployer and shouldn't have been released as a patch.


job list --open handle to only display open jobs

this should be relatively easy as it is already implemented in cli-subgraph-b

pretty sure this already exists in cli-subgraph-a via openlab job list open?

yes! thank you for finding this - @acashmoney take note.


Fixed typo in example

Changed GraphQl to GraphQL.
Typo prevented class ArrayConnection to be found.

Thank you!


create-react-app build fails to minify

Hi, just today i discovered this project - looks very nice so far.
However, i have the following issue when trying to create the production build with the create-react-app build step:
$ yarn build
yarn run v1.6.0
(node:49) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
$ react-scripts build
Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

 	./node_modules/styled-icons/fa-brands/FiveHundredPx.js:4

Read more here: http://bit.ly/2tRViJ9

Hey, thanks for the report - I’d be happy to take a look.  Can you provide the following, if you are able:

What version of NodeJS are you using?
What does your package.json contain (especially the version of react-scripts)?
Can you post an example of how you are importing styled-icons?

What version of NodeJS are you using?
I am running in the docker image node:alpine.
docker run -it -v ${PWD}:/workdir node:alpine sh
/ # node --version
v10.0.0

You can actually take a look at my repo here: (make sure to stick with that revision, unfortunately i kicked styled-icons after this)
https://gitlab.com/spawnia/franke.tech/tree/c8cccd6b421b2b4c24325b805728fca08f389633
I am using the icons in here:
https://gitlab.com/spawnia/franke.tech/blob/c8cccd6b421b2b4c24325b805728fca08f389633/src/pages/index.js

Thanks again for the report and the link to your repo, I was able to track down the issue.  It appears that I had not properly tested this repo against Create React App, as the app I tested it with was modifying UglifyJS's minification settings.
I just released v2.0.0 which fixes that issue.  I opened a merge request against your repo to demonstrate using the updated version: https://gitlab.com/spawnia/franke.tech/merge_requests/1.

Thank you for the fix, it worked perfectly. This package is great, it is so nice i can actually use it now.


tvOS issues

As for tvOS, I targetted it and other than compile errors for things "unavailable in tvOS" it looks good?!?!?! If those were all wrapped with #if not :tvOS -like conditionals would that be good and maybe it would work?
Screenshot 2023-08-16 at 8.51.35 PM.png

SLACK THREAD: https://dockyard.slack.com/archives/C02E1GA5THB/p1692237243808879
David Bluestein II
18 hours ago
As for tvOS, I targetted it and other than compile errors for things "unavailable in tvOS" it looks good?!?!?! If those were all wrapped with #if not :tvOS -like conditionals would that be good and maybe it would work?
Screenshot 2023-08-16 at 8.51.35 PM.png
Screenshot 2023-08-16 at 8.51.35 PM.png
1 reply
Carson Katri
7 hours ago
Can you try the tvos-build branch? I think I fixed all of those build errors

SLACK THREAD: https://dockyard.slack.com/archives/C02E1GA5THB/p1692237243808879
David Bluestein II
1 day ago
As for tvOS, I targetted it and other than compile errors for things "unavailable in tvOS" it looks good?!?!?! If those were all wrapped with #if not :tvOS -like conditionals would that be good and maybe it would work?
Screenshot 2023-08-16 at 8.51.35 PM.png
Screenshot 2023-08-16 at 8.51.35 PM.png
New
Carson Katri
22 hours ago
Can you try the tvos-build branch? I think I fixed all of those build errors
David Bluestein II
15 hours ago
I tried it, fixed my non-tvOS items, and got two errors:
Undefined symbols:
Linker command failed with exit code 1 (use -v to see invocation)
which are beyond my experience. I am trying the simulator, so that might be it. But there are no other errors. I can try to get my AppleTV on 17 if you think that might fix that.
Carson Katri
15 hours ago
That's the same issue I've run into
Carson Katri
15 hours ago
I haven't had time to look into it further yet
David Bluestein II
15 hours ago
Did you try on real hardware, or just simulator?
Carson Katri
15 hours ago
Only a simulator
David Bluestein II
15 hours ago
Also, neither charts nor mapkit work with the tvOS branch. Same two different revision-based requirements we saw earlier with Charts I think a week or two ago like this.
Screenshot 2023-08-17 at 3.27.52 PM.png
Screenshot 2023-08-17 at 3.27.52 PM.png
David Bluestein II
15 hours ago
I'll try real hardware and see what happens.
David Bluestein II
15 hours ago
(after googling how to do that)
Carson Katri
15 hours ago
That's expected, they require the main branch of liveview-client-swiftui
David Bluestein II
15 hours ago
That's what I figured
David Bluestein II
14 hours ago
Jumped through all the hoops to get the hardware updated etc. AND success (sort of)!!!
David Bluestein II
14 hours ago
Second screen after intro screen
IMG_2493
IMG_2493
David Bluestein II
14 hours ago
But navigating to next page has an error.
IMG_2494
IMG_2494
David Bluestein II
14 hours ago
But it RAN. :confetti_ball:
David Bluestein II
14 hours ago
So question is what will it take to get the tvOS-build branch merged? Is it ready, or need more work/review?
David Bluestein II
14 hours ago
FYI this development was done on apple silicon
David Bluestein II
14 hours ago
Ok, so I re-started it, still had an issue. But I wanted to screenshot it, so I restarted it with the Device window open so I could get a clear picture of the error, and it worked!!!!!! But the click from item on page did not show the detail page, just a blank screen. But now it look like it is really close, and the apple menu shows up at the top
David Bluestein II
14 hours ago
Screenshot from within Xcode to Device
Screenshot 2023-08-17 at 4.33.39 PM.png
Screenshot 2023-08-17 at 4.33.39 PM.png
David Bluestein II
14 hours ago
FYI, NO changes to my swiftui heex. Just had to #if !os(tvOS) a couple of places for a call to gestures and something else not tvOS.
Carson Katri
10 hours ago
Awesome! I guess I'll have to test on my TV too, since Rust doesn't seem to have a tvOS simulator target. I'm not sure the priority of tvOS right now though, fyi
@alex.zholtkevych
alex.zholtkevych
1 minute ago
It is a bit lower than other stuff, but still the case


Invalid document breaks compilation, shows wrong output

When working in a monorepo and using the following standard configuration:
schema: api/src/resolvers/**/*.ts

generates:
  api/src/api-types.ts:
    plugins:
      - typescript
      - typescript-resolvers

  web/src/web-types.ts:
    config:
      documents: web/src/**/*.tsx
    plugins:
      - typescript
      - typescript-operations

If a valid but breaking change is made to an api resolver, the entire compilation process will error when trying to generate the web-types, and the new api-types will never get created.
This is a confusing workflow for a backend developer, since the output shows:
  ✔ Parse configuration
  ❯ Generate outputs
    ✔ Generate api/src/api-types.ts   <-- This is a lie
    ❯ Generate web/src/web-types.ts
      ✔ Load GraphQL schemas
      ✔ Load GraphQL documents
      ✖ Generate
        →     at web/src/pages/Home.tsx:3:5

I believe the tool should output whatever it can, regardless of other errors it encounters (that is, do what the output says it does). Is this expected behavior?
I'm not completely sure, but might this have something to do with using Promise.all on this line? Instead, Promise.allSettled would ensure to not throw on the first error

Thank you for reporting the issue you had but we need you to follow our issue template in order to help you better;
Especially we need a minimal and clear reproduction to debug the issue on Github, Stackblitz or CodeSandbox

@ardatan you can just make the document.graphql file invalid in your sandbox (add asdf) and see that with that error, no files will be generated

@ardatan if you really need a sample repo, here it is: https://codesandbox.io/s/elastic-cerf-xrwo4d you can see that because of the error in documents.graphql that the file schema.json will never be generated

Bump: Any update on this? Or workaround suggestion? It is a daily problem in our monorepo, any breaking change to a frontend query or api resolver completely blocks compilation of the entire app until you fix it


Running into invalid class errors after upgrade to 1.6, does not occur on lower versions.

Running into the following errors as the PeriodicJobBuilder.GetAllJobs(); method is called and it loops through all classes within the assembly looking for the recurring job attributes. Is there a way to exclude/include types that would use the attribute rather than looking at all types?
Could not load type 'Microsoft.EntityFrameworkCore.Metadata.RelationalModelAnnotations' from assembly 'Microsoft.EntityFrameworkCore.Relational, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
Could not load type 'Microsoft.EntityFrameworkCore.Metadata.RelationalPropertyAnnotations' from assembly 'Microsoft.EntityFrameworkCore.Relational, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
Could not load type 'Microsoft.EntityFrameworkCore.Metadata.Internal.RelationalFullAnnotationNames' from assembly 'Microsoft.EntityFrameworkCore.Relational, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'. <s:Microsoft.AspNetCore.Hosting.Diagnostics>
System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Could not load type 'Microsoft.EntityFrameworkCore.Metadata.RelationalModelAnnotations' from assembly 'Microsoft.EntityFrameworkCore.Relational, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
Could not load type 'Microsoft.EntityFrameworkCore.Metadata.RelationalPropertyAnnotations' from assembly 'Microsoft.EntityFrameworkCore.Relational, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
Could not load type 'Microsoft.EntityFrameworkCore.Metadata.Internal.RelationalFullAnnotationNames' from assembly 'Microsoft.EntityFrameworkCore.Relational, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'.

   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeModule.GetTypes()
   at Hangfire.RecurringJobAdmin.PeriodicJobBuilder.GetAllJobs()
   at Hangfire.RecurringJobAdmin.ConfigurationExtensions.UseRecurringJobAdmin(IGlobalConfiguration config, Assembly assembly)

Hi, @geoffreytran thanks for report this issue, I will fix this issue in the next release.
In the next release, I changed the way how the plugin gets all jobs by attribute.
Please wait for the next release.

Hi @geoffreytran, I released a new version, try it and let me know.

Great! thanks! I did find another issue, I'll create a new one for that.


Copy constraints: Connect PIL with witgen

In #1276, we implemented witness generation for machines with copy constraints. However, the actual copy constraints are not yet passed from the PIL code.

There is already a test that uses copy constraints (but the witnesses do not need to be generated for that test).
We should decide if we want the RHS in the connect statement to be row-column pairs or certain multiples of roots of unity.
If we use row-column, then the translation to roots of unity must be done in the export to estark part.
Both for witgen and the pil code, it is probably easier to use row-column pairs.

I'll vote for row-column pairs; I think the fixed columns of the connect statement leak the implementation of the copy constraints.

One we have this, we should re-activate the pipeline test secondary_machine_plonk


blog: UIButton introduction post

I kept this pretty brief - let me know if there's anything that'd be good to go into more detail on.
Also, I'm wordy so don't feel shy about proposing edits 😝
Marking as draft because we need tilt-dev/tilt-extensions#183 merged first.


Range Slider problems

Hello there,
My problem is that when I update a product (Laravel, but I'm not using Scout, I'm using the php library) and I increase the price, no problem, everything works perfectly, however when I decrease the price of the same product, the problems start.
I would use range slider widget to filter the price. It is clear that it will not show up in the range or it will disappear the products from the list, if I take it out it will show up but it will be the last product.
I put the a row widget in ascending order, it works fine in this case, if descending it will also be at the bottom of the list.
I have downloaded the product data and everything seems to sync in the meilisearch, however on the frontend if I decrease the price, the above problems occur. And again if I increase it, it works perfectly.
What could be the problem?
Please help me!

hardly, but i figured it out, that the problem on the meilisearch side.
It works, if I use the update document route, just update the price, and what is weird, that it is only works if I send the price attribute as a string, and then i have to use the add document route, which is replace the document, the price "transform" to int and it works.
but it's super weird.

hardly, but i figured it out, that the problem on the meilisearch side.
It works, if I use the update document route, just update the price, and what is weird, that it is only works if I send the price attribute as a string, and then i have to use the add document route, which is replace the document, the price "transform" to int and it works.
but it's super weird.


a union of attributes first lit up 3 nodes, and later lit up 4 nodes

A union of two attributes first lit up 3 nodes, and later lit up 4 nodes.
To reproduce:

use CKCC/v1_nbl on production
select KRAS and NRAS mutations
do a union
sometimes 3 nodes are lit up, sometimes 4

No longer reproducible (after repeating 6 times).


[ARM] Fix #25715: az bicep install/upgrade: Fix the configparser.NoSectionError: No section: 'bicep'

Related command

az bicep install
az bicep upgrade

Description

In #25541, we are checking for the current value of bicep.use_binary_from_path config value and updating it to false when bicep is installed via Azure CLI.
This check was missing a default value, throwing an error in the process. This PR fixes this.
resolves #25715, resolves #25710
Testing Guide

az bicep upgrade
az bicep install

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

ARM

Type
Test Case
Error Message
Line

Failed
test_run_bicep_command_check_version
E AssertionError: Expected 'warning' to be called once. Called 0 times.
azure/cli/command_modules/resource/tests/latest/test_resource_bicep.py:91

Failed
test_run_bicep_command_raise_error_if_not_installed_and_not_auto_install
E AssertionError: CLIError not raised
azure/cli/command_modules/resource/tests/latest/test_resource_bicep.py:24

Could you please resolve these CI issues?

@shenglol @zhoxing-ms Looks like the tests are failing intermittent (based on my local tests) either because of the local value or bicep already being installed. Are there any best practices here for tests apart from the fix I'm just pushed?
Also, this issue has been unfortunately breaking lots of pipelines. Would it be possible to push this out as a patch release?

@shenglol @zhoxing-ms Looks like the tests are failing intermittent (based on my local tests) either because of the local value or bicep already being installed. Are there any best practices here for tests apart from the fix I'm just pushed?
Also, this issue has been unfortunately breaking lots of pipelines. Would it be possible to push this out as a patch release?

Looks like the issues were because the build agents perhaps now have bicep installed and the new functionality was picking up that, failing the tests.

@shenglol Since quite a few customers are affected by this, I was hoping you could help validate these changes to be double sure that customer's build problems will be resolved before we merge and release this?
@zhoxing-ms Once validated, would it be possible to release this fix as a hot fix/patch release?

/azp run

Awesome to see this merged! Any idea when this will be live?


Can't get it to work...

Is there any way to know if the UDP packing is being sent?
Because I keep issuing:
Myapp.Statix.increment("page_view", 100)
:ok

and everything seems to work, but data dog is not showing anything.

FYI I'm running on docker swarm, with an overlay network, and using one agent per host.
Additionally my host is set to "localhost" in statix.
I tested sending to localhost from bash and it works.

Hey @drozzy any luck? Does this work locally when using something like statsd-server debugger?

Sorry, haven't been back to test this.
Please ignore this bug - I'm sure it was something I did wrong.


ResourcesView in dialog

This is a major priority. It should be possible to search through any resource using the standard browse/search interface but in a dialog window. This is crucial when creating collections and corpora and when specifying the morphological analysis for a form.

Fixed by 0195cb1


Bug: SVG Scaling issue with image cropping

@dwelle, legacy drawings that include SVGs without the width and height attribute get scaled incorrectly. Here's an example: Untitled-2024-10-28-2103.excalidraw.zip
Load this excalidraw to https://staging.excalidraw.com and resize the svg.
re: #8710

Will take a look tomorrow. But it doesn't seem related to #8710, rather the #8613 itself as it can be reproduced there already: https://excalidraw-gfa5xk5ry-excalidraw.vercel.app/#json=OgEtPh49zeqt6__0Zfsk7,QB_FZ3u4noVBAeLYa6MXSA


Wipro Stock Price Prediction using LSTM, SVR, KNN

🛠 Related Issue
Fixed: #456
📝 Description
Predicting Wipro Stock Prices involves using various machine learning models like LSTM (Long Short-Term Memory), SVR, KNN to analyze historical stock data and forecast future trends. Each model leverages different algorithms and methodologies to enhance prediction accuracy and reliability.
🔍 Type of PR

[x] ✨ Feature enhancement
[x] 📚 Documentation update

✅ Checklist

[x] I have performed a self-review of my code.
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Hi @Akshat111111 , Please assign labels GSSOC and level 2 to this PR.
Resolves #456

@Akshat111111 Sir


Feature: Use nvim buffers for Telescope preview

⚠ only affects Telescope extension

Advantages:

highlight search
similar to builtin telescope git pickers

Disadvantages:

Removes support for pagers

I made a release before merging this PR so one can easily go back to the previous behavior. You can "opt in" by downgrading at the moment. I already have to maintain 2 extensions (telescope + fzf), and I will not maintain different previews for both. With this change, I chose to follow the default Telescope git commit behavior.
The reasoning: I received a lot of issues where pagers would cause problems. Therefore, I chose to follow Telescopes default behavior. This was also requested by a user and since it gives me more control over the preview buffer, it is a nice improvement.
Regarding "Gitsigns": I will not add another dependency to this plugin. I really would like to go the other way and remove dependencies as much as possible.
Can you give some extra info about the following things:

nvim version
telescope version
git version

Please make an issue where I can track the bug


Review the Docker annotation BAL file

Purpose
This is review and fix typos and issues of [1].
[1] https://github.com/ballerina-platform/ballerina-lang/blob/master/stdlib/docker/src/main/ballerina/src/docker/annotation.bal
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/19684
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Note that this same fix should be sent to ballerina-1.1.x branch

Note that this same fix should be sent to ballerina-1.1.x branch

This is adressed via https://github.com/ballerina-platform/ballerina-lang/pull/20597.

Codecov Report

Merging #20580 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20580   +/-   ##
=======================================
  Coverage   15.21%   15.21%
=======================================
  Files          50       50
  Lines        1341     1341
  Branches      208      208
=======================================
  Hits          204      204
  Misses       1121     1121
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562a2f7...4d41c90. Read the comment docs.


Installing istio for perf testing

Use tools/perf/istio-install install istio for perf testing.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: utka
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

prow/OWNERS [utka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, utka
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

prow/OWNERS [utka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@utka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
1f20c9270ddc363b85f9ffe9ed1fba1488e0c73f
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
7cc95280c22f56a632202bb403e46b39f03d2574
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
7cc95280c22f56a632202bb403e46b39f03d2574
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
7cc95280c22f56a632202bb403e46b39f03d2574
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, utka
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

prow/OWNERS [utka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
7cc95280c22f56a632202bb403e46b39f03d2574
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
7cc95280c22f56a632202bb403e46b39f03d2574
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
7cc95280c22f56a632202bb403e46b39f03d2574
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
7cc95280c22f56a632202bb403e46b39f03d2574
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


wow...

The rude answer is something like "go away, you freakin ****. However, I am a polite guy, so I am just asking you: are you sure you want deploy that? Who should I send the bill to, fore the removal of an unwanted feature in my organization?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77fb57a0-9af1-8ade-5846-4a44c6e1a702
Version Independent ID: 24c49cab-e850-df1f-5050-bac2c37c96bd
Content: Microsoft Search in Bing and Office 365 ProPlus
Content Source: DeployOffice/microsoft-search-bing.md
Service: o365-proplus-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

Based on customer feedback, we're making a few changes to the plan to roll out the extension for Microsoft Search in Bing. For information about the changes, read this announcement. This article will be updated when more details are available.

Oh, finally some common sense kicked in. Thanls for the update


Grafana with NodePort Fails with InfluxDB Error

Grafana UI shows the following error:
Dashboard init failed
Template variables could not be initialized: InfluxDB Error: 404 page not found
I'm using a NodePort to externally expose grafana/influxdb. I am able to hit these endpoints using the node ip/port. However, grafana is displaying: Dashboard init failed
Template variables could not be initialized: InfluxDB Error: 404 page not found. Additionally, no data or graphs are present.
Per documentation, I commented out the grafana env's used for proxy api. Here is a gist that provides more details of my environment: https://gist.github.com/danehans/ffbf7642863ab9845b39
Any insight you can provide would be appreciated.

I'm having the same issue with 1.2, did you made any progress?

i just went to the settings on the left and it was set on influxdb 0.8, i've set mine to whats installed 0.9 and the error is gone but im getting empty dashboards now with no data

@innovia I had the same issue with 1.2 as well. I've been working on something else and have not made progress on this issue. Please provide an update if you get it working. Thanks.

here's the issue:
1003
i'll link  this ticket  to it

New Grafana config and dashboards were pushed in https://github.com/kubernetes/kubernetes/pull/22347. Please reopen if the problems persist.


DBeaver Enterprise 24.0 stuck on startup

Description
I have upgraded DBeaver Enterprise to 24.0
It failed to start and I uninstalled it and installed again.
Still it is stuck on starting in step "Total database drivers (141)" in the Splash Screen.
The last entry in the debug log file is:
2024-03-27 09:12:16.409 - QMDB connected
2024-03-27 09:12:16.461 - --> Call: https://dbeaver.com:443/lmp/checkLicense
2024-03-27 09:12:16.665 - 	Check QMDB deployment
2024-03-27 09:12:16.686 - 	QMDB server started (H2 2.1.214 (2022-06-13))
Debug log is attached.
dbeaver-debug - Copy.log
DBeaver Version
Enterprise 24.0
Operating System
Windows 11
Database and driver
SAP HANA
Steps to reproduce
No response
Additional context
No response

Hello @SAPJens
Could you please generate a thread dump and attach it here? Here is the instruction: https://dbeaver.com/docs/wiki/Making-a-thread-dump/
Thank you.

@LonwoLonwo Here is the thread dump.
Thanks,
Jens
dbeaver_thread_dump.txt

Do you have a project or master password?
Did you see the dialog for it?
DBeaver: Load registry" #38 prio=5 os_prio=0 cpu=0.00ms elapsed=3612.12s tid=0x000001c4d7f84f30 nid=0xadc waiting on condition  [0x000000ae61dfe000]
   java.lang.Thread.State: TIMED_WAITING (parking)
	at<EMAIL_ADDRESS>Method)
	- parking to wait for  <0x0000000083392610> (a java.util.concurrent.Semaphore$NonfairSync)
	at<EMAIL_ADDRESS>Source)
	at<EMAIL_ADDRESS>Source)
	at<EMAIL_ADDRESS>Source)
	at<EMAIL_ADDRESS>Source)
	at org.eclipse.ui.internal.PendingSyncExec.acquire(PendingSyncExec.java:39)
	at org.eclipse.ui.internal.PendingSyncExec.waitUntilExecuted(PendingSyncExec.java:88)
	at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:142)
	at org.eclipse.swt.widgets.Display.syncExec(Display.java:4802)
	at org.jkiss.dbeaver.ui.UIUtils.syncExec(UIUtils.java:1983)
	at com.dbeaver.ee.runtime.ui.security.UIServiceSecurityImpl.askForPassword(UIServiceSecurityImpl.java:57)
	at com.dbeaver.ee.runtime.LocalProjectAdvanced.acquireSecretKey(LocalProjectAdvanced.java:93)
	at com.dbeaver.ee.runtime.LocalProjectAdvanced.getLocalSecretKey(LocalProjectAdvanced.java:70)
	at org.jkiss.dbeaver.registry.DataSourceSerializerModern.loadConfigFile(DataSourceSerializerModern.java:332)
	at org.jkiss.dbeaver.registry.DataSourceSerializerModern.readSecureCredentials(DataSourceSerializerModern.java:851)
	at org.jkiss.dbeaver.registry.DataSourceSerializerModern.parseDataSources(DataSourceSerializerModern.java:424)
	at org.jkiss.dbeaver.registry.DataSourceRegistry.loadDataSources(DataSourceRegistry.java:841)
	at org.jkiss.dbeaver.registry.DataSourceRegistry.loadDataSources(DataSourceRegistry.java:767)
	at org.jkiss.dbeaver.registry.DataSourceRegistry.loadDataSources(DataSourceRegistry.java:739)
	at org.jkiss.dbeaver.registry.DataSourceRegistry.<init>(DataSourceRegistry.java:98)
	at org.jkiss.dbeaver.registry.DataSourceRegistry.<init>(DataSourceRegistry.java:91)
	at org.jkiss.dbeaver.registry.BaseProjectImpl.createDataSourceRegistry(BaseProjectImpl.java:215)
	at org.jkiss.dbeaver.registry.BaseProjectImpl.lambda$0(BaseProjectImpl.java:197)
	- locked <0x000000008190e2b8> (a java.lang.Object)
	at org.jkiss.dbeaver.registry.BaseProjectImpl$$Lambda$735/0x000000010068b798.run(Unknown Source)
	at org.jkiss.dbeaver.registry.BaseProjectImpl.lambda$1(BaseProjectImpl.java:207)
	at org.jkiss.dbeaver.registry.BaseProjectImpl$$Lambda$736/0x000000010068b9b8.run(Unknown Source)
	at org.jkiss.dbeaver.utils.RuntimeUtils$MonitoringTask.run(RuntimeUtils.java:722)
	at org.jkiss.dbeaver.utils.RuntimeUtils$1.run(RuntimeUtils.java:264)
	at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:114)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

I see one of the processes is waiting for a password.

@LonwoLonwo Yes, I have a master password. And no, I do not get a popup to enter it.

Okey, here is the list of possible solutions:

You can reset your workspace https://github.com/dbeaver/dbeaver/wiki/Reset-UI-settings. It looks like one of your previous editors is open and waiting for the password
You can check our latest Early Access version: https://dbeaver.com/files/ea/. Some of the issues with the master password we fixed already.
You can return to the previous version. Here is the list of previous versions: https://dbeaver.com/files/

@LonwoLonwo Thanks, you are right: a previous editors was open!
I did go back to 23.x and closed it.
Now it opens with 24.0.1.
Is this something you can improve?

closed it

Could you please say what exactly did you close? Which editor? For our testing.

Yes, I did close the editor!

Actually, it were two editors!

Actually, it were two editors!

Which editors?

This is how it looked.
I have multiple projects, each with a password.
I had one sql script open from project A.
And a folder from project B.
In DBEaver 23.x this resulted in multiple popups on startup.

Thanks for your investigation @SAPJens

Okey, here is the list of possible solutions:

You can reset your workspace https://github.com/dbeaver/dbeaver/wiki/Reset-UI-settings. It looks like one of your previous editors is open and waiting for the password
You can check our latest Early Access version: https://dbeaver.com/files/ea/. Some of the issues with the master password we fixed already.
You can return to the previous version. Here is the list of previous versions: https://dbeaver.com/files/

It work for me. Thank you.


Simplification of requirements.txt

Happy to make a PR for this if required, but I found that many of the modules in requirements.txt are not needed for this tutorial.
If using the AWS Deep Learning Ubuntu AMI, you can simply clone the repo and then just
source activate tensorflow_p36
pip install ktext annoy nltk pydot

Thanks for this great tutorial, it's one of the few deep learning tutorials that just works out of the box.

Glad to hear that!  I don’t want to make this tutorial AWS dependent.
What do you think  about removing requirements.txt in favor of relying on the Docker container?

What do you think about removing requirements.txt in favor of relying on the Docker container?

Sounds good to me! Here's what I needed to do to get the Docker container running - might be useful for Docker noobs like me :)  I had no problems running it with the latest Nvidia-Docker.
curl -s -L https://nvidia.github.io/nvidia-docker/gpgkey |   sudo apt-key add -
distribution=$(. /etc/os-release;echo $ID$VERSION_ID)
curl -s -L https://nvidia.github.io/nvidia-docker/$distribution/nvidia-docker.list |   sudo tee /etc/apt/sources.list.d/nvidia-docker.list
sudo apt-get update
sudo apt-get install nvidia-docker

sudo nvidia-docker run hamelsmu/seq2seq_tutorial

Ok, what about a PR?  It will be good for you to get credit for your idea


Golang idioms

I was browsing and made some suggestions, which I will annotate.

Thanks, I will apply these idioms to the rest of the code.


Broken link

The link in the Note section at the top takes you to a Not Found page.
https://developer.microsoft.com/en-us/games/xbox/docs/gdk/provisioning-role

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fcb57bfe-69f7-e1d0-cd63-d28360727985
Version Independent ID: ece8efc3-9422-0103-3ed7-94e8427fcb7c
Content: Xbox One Developer Mode activation - UWP applications
Content Source: windows-apps-src/xbox-apps/devkit-activation.md
Product: uwp
Technology: games
GitHub Login: @M-Stahl
Microsoft Alias: kevinasg

Link is working now. Maybe just a glitch.

I am clicking on the above link right now
https://developer.microsoft.com/en-us/games/xbox/docs/gdk/provisioning-role

and it always takes me to
https://developer.microsoft.com/en-us/games/xbox/docs/gdk/en-us/Home/Error

Derek

The note specifies "If you're a managed partner". Could that be the issue?

Are you logged in with an associated account? Have you contacted the xbox team directly? Sounds like you might need product team support.


Allow multiple Auth0 client secrets to prevent downtime

It is now impossible to update the Auth0 client secret at Auth0 without downtime at Graphcool. Auth0 describes the option in the documentation to store a list of client secrets, so you can add the new one first, then change it at Auth0, and then remove the old one.
Reference: https://auth0.com/docs/tutorials/how-to-update-applications-client-secret#updating-authorized-clients

With the custom resolver authentication options, this isn't an issue.


Request for missing videos.

Hi, I submitted a missing video request on February 13, 2023. But after a week I don't get the link to the missing videos. Can you check if my request was submitted successfully? Thanks!

您好，您发给我的信件已经收到，我会尽快查看。


Cannot find the template file example

It would be great having an example template with supported variables.
The link in Settings doesn't take you to one: https://github.com/CMorooney/obsidian-game-search-plugin#example-template

@andrezgz thanks for pointing this out I completely forgot to come around and put some basic info in the README for templating...I've done so now
sorry for also missing this for so long


chore: bump to released version of TS4

Description:
What it says in the title. 🎉
Related issue (if exists): None

🎉


GracefulMasterTakeover fail

I use 'orchestrator-client -c graceful-master-takeover '  to make a switch,  but  it failed, What should I do to resolve  this problem?
The version of orchestrator  is 3.2.2.
The following is the log:
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO GracefulMasterTakeover: Will let slave1:3306 take over its siblings
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO moveReplicasViaGTID: Will move 2 replicas below slave1:3306 via GTID, max concurrency: 5
Sep  3 00:27:25 orchestrator-master orchestrator: [mysql] 2020/09/03 00:27:25 packets.go:123: closing bad idle connection: EOF
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO Will move slave2:3306 below slave1:3306 via GTID
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO auditType:begin-maintenance instance:slave2:3306 cluster:master:3306 message:maintenanceToken: 41, owner: orchestrator-master, reason: move below slave1:3306
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO Stopped replication on slave2:3306, Self:mysql-bin.000004:113098787, Exec:mysql-bin.000626:478452597
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 DEBUG ChangeMasterTo: will attempt changing master on slave2:3306 to slave1:3306, mysql-bin.000043:1033432939
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO ChangeMasterTo: Changed master on slave2:3306 to: slave1:3306, mysql-bin.000043:1033432939. GTID: true
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO Started replication on slave2:3306
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 WARNING executeCheckAndRecoverFunction: ignoring analysisEntry that has no action plan: AllIntermediateMasterReplicasNotReplicating; key: slave1:3306
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO auditType:move-below-gtid instance:slave2:3306 cluster:master:3306 message:moved slave2:3306 below slave1:3306
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO auditType:end-maintenance instance:slave2:3306 cluster:master:3306 message:maintenanceToken: 41
Sep  3 00:27:25 orchestrator-master orchestrator: [mysql] 2020/09/03 00:27:25 packets.go:123: closing bad idle connection: EOF
Sep  3 00:27:25 orchestrator-master orchestrator: [mysql] 2020/09/03 00:27:25 packets.go:123: closing bad idle connection: EOF
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO auditType:move-replicas-gtid instance:slave1:3306 cluster:master:3306 message:moved 1/2 replicas below slave1:3306 via GTID
Sep  3 00:27:25 orchestrator-master orchestrator: [mysql] 2020/09/03 00:27:25 packets.go:123: closing bad idle connection: EOF
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 INFO moveReplicasViaGTID: Will move 1 replicas below slave1:3306 via GTID, max concurrency: 5
Sep  3 00:27:25 orchestrator-master orchestrator: [mysql] 2020/09/03 00:27:25 packets.go:123: closing bad idle connection: EOF
Sep  3 00:27:25 orchestrator-master orchestrator: [mysql] 2020/09/03 00:27:25 packets.go:123: closing bad idle connection: EOF
Sep  3 00:27:25 orchestrator-master orchestrator: [mysql] 2020/09/03 00:27:25 packets.go:123: closing bad idle connection: EOF
Sep  3 00:27:25 orchestrator-master orchestrator: 2020-09-03 00:27:25 ERROR Relocating 1 replicas of master:3306 below slave1:3306 turns to be too complex; please do it manually
Sep  3 00:27:25 orchestrator-master orchestrator: [martini] Completed 500 Internal Server Error in 263.61955ms

GracefulMasterTakeover  move 2 replicas below slave1:3306 via GTID.
but one replica may be in bad state: packets.go:123: closing bad idle connection: EOF
more logs needed here
relate issue
https://github.com/openark/orchestrator/issues/1160

@yangeagle what's the bad state? There is no any warning or error messages when do GracefulMasterTakeover action.

https://github.com/openark/orchestrator/blob/cbbade0344dceb9ea7934eba722932b123d95f21/go/logic/topology_recovery.go#L1922
The fourth parameter of the returned result is ignored.
if printed， more information will be found.
You can add the log and reproduce it.
The result will be more obvious.


List of face gestures goes off screen

The list of scroll gestures goes out the bounds of the window. This means that depending on where the window is some face gestures are in accessible. You can move the window and access them but its a tad annoying and if the list gets longer the issue will get worse.
I would suggest maybe forcing the dropdown to somehow stay in the bounds of the window and then making is scroll, similar to how a normal select element would work.

Hi, I'm wondering if it would be better to have a page with the map from gestures to actions, instead of having the gestures on a drop-down at all?

@sjjhsjjh thats a great idea, i think that is better UX for new users aswell, being able to see all the gestures at once.

Hi, I'm wondering if it would be better to have a page with the map from gestures to actions, instead of having the gestures on a drop-down at all?

I like this a lot. This would allow us to trigger actions with multiple gestures

Hi again, Maybe a silly question but would we ever want the same gesture with difference sizes to trigger different actions?

Everything is feasible with Assistive Technology! I would say it's definitely not a primary use case but it definitely could occur. Take for example blinking it's possible you may have a short blink and a long blink to do two different actions or say open for a period of time. equally a little smile or a large smile different actions. Difficult to use it for sure.

I think what those options are for is to control the keyboard interaction.
Dynamic - Holds the key for the entire time you are over the threshold
Rapid - Does a very quick click
Single - 'Normal' click
Hold - Long holds the keypress
Toggle - Is like a latch
As will says they are useful to have. That being said, the UI could be improved so its clearer what they do.

Same gesture sizes to trigger different actions

Whilst I agree with Will everything is possible and it would be nice to allow it. However, I think I would rather improve the UI for the 'standard' usage first of one gesture to one action. Then down the line we can come up with a clean way to do the multiple gestures and actions.
So for now, lets just assume one gesture to one action and we can improve it down the line

Thanking you both.
I'll call the dynamic etc the Modifier.
Can a Modifier be applied to a mouse action? If it can then a user could do a drag and drop (DnD) interaction like this.

Configure Open Mouth to do Action: Left Click Mouse with Modifier: Dynamic.
Activate face control of the pointer.

Turn their head to position the pointer over the DnD object.
Open their mouth, which will select the object.
Turn their head again to drag the object to its target.
Close their mouth, which will release the object.

It seems like the ultimate mapping structure could be like Gesture+SizeRange => Action+Modifier.
The current simplification is that the top of the SizeRange is always the maximum.

Sorry for the confusion. Altough the description needs some work I did add it to the readme file.

I think what those options are for is to control the keyboard interaction.

Yes, but also for mice

Dynamic - When the threshold of the gesture is reached, the key or mouse button is clicked once but if certain amount of time has passed the key is being kept pressed until the gesture is under the threshold again
This is necessary when you are using FaceCommander as a direct replacement for the mouse. If the button was held immediately after reaching the threshold, you would always drag everything.

Rapid - This should be called rapid fire. Mostly useful in shooters or quick time events

The others are as described by @gavinhenderson

Single - 'Normal' click
Hold - Long holds the keypress
Toggle - Is like a latch

NB fixed this for now just adding a scroll bar to this dropdown https://github.com/AceCentre/FaceCommander/commit/4b591b5f2cdce40ce653209b7fa1a9c2c2f8f1d8
I'll leave this open for now though as @sjjhsjjh  ideas for a seperate page is better..
just gonna have to find time to do it


Dialog: Broken resize on south border when minHeight is set

If you reach the minimum height of dialog and continue with the shrink of the dialog you demage the south border resizer.

Fixed only in the development branch for version 1.0.0


⚠ Bofrost.de has degraded performance

In f0b149a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1312 ms

Resolved: Bofrost.de performance has improved in 128a8c1 after 6 minutes.


Revert change from NonFatal to Throwable

Commit eaced24055fa5e40a42bf3eef54662f447f92cb0 changes NonFatal to Throwable in SemanticDB-based tools. I can't approve this change since I've been badly bitten by code that catches Throwable swallowing critical errors I definitely want to stop the entire application.
I propose instead we additionally catch StackOverflowException in code paths that use recursion.

Could you give some examples of situations when catch _: Throwable could create problems?

Out of memory errors, stack overflow (when the configured stack size is too small) and any other VM errors. I don't think we should allow our applications to produce partial results because the VM is mis-configured. In those cases we should restart the applications with larger stack sizes and more memory.

I don't think we should allow our applications to produce partial results because the VM is mis-configured.

Why not? We're not talking about producing partially constructed big results, we're talking about producing as many fully complete small results as possible. From what I can see, there is no downside to catching all throwables (e.g. we don't compromise on correctness), but there is an upside of having a chance to make more progress than otherwise.
To be more concrete, the commit linked in the ticket changes the following four tools: A) Metacp, B) Metai, C) Metap, D) Metac (which stands for both the semanticdb-scalac plugin and metac itself).
A-B) In the case of Metacp and Metai, individual jars/dirs are processed independently from each other, so I think it makes sense for them to succeed/fail independently from each other.
For example, if a Metacp or a Metai classpath has several hundred entries (and internally we run on even bigger classpaths), I wouldn't want an OOM in the middle of a run to crash everything. Indeed, that OOM can be caused by a ridiculously small -Xmx, and then all subsequent entries will fail. However, what can also happen is that this particular entry was too big, but then subsequent GC frees up the memory, and other entries succeed.
This may sound overly theoretical, but this is all based on experience with running our tools on inputs that are bigger than usual. In situations like that, I found it the most productive to do one big invocation, then collect the results with all successes and errors in one place, then triage everything in one go and repeat. For big inputs, rerunning an application is not free, and it becomes problematic pretty quickly.
C) I haven't yet had a need to run Metap on huge inputs, but the same logic applies here too. If there's a bug in Metap (or a misconfiguration of the JVM) that makes metap crash on one out of thousands of files, there is a possibility that it won't affect other files. Maybe it's a minor one, but improving the UX even slightly is worth it if there are no downsides.
D) Metac is somewhat different, because this strategy can lead to partially correct results, since by default exceptions caught in handleCrash in semanticdb-scalac only produce warnings, not errors. (This also raises a tangential question of why the default is still warning and whether we want to change that).
However, one can argue that the very existence of -P:semanticdb:failures encourages partially correct results, so it's not the problem of catch _: Throwable. However, I don't feel strongly about this particular tool, so this particular point is fine to me either way.
Summary. It would seem that the introduced change is a strict UX improvement (no downsides, some upsides) for Metacp, Metai and Metap. Evaluating the effects on Metac is non-trivial, but I'm willing to concede that one without further discussion.

Fixed in #1738. I am happy with keeping Throwable in metacp, metai and metap as long as metac uses NonFatal. I don't want to catch Throwable in metac because that's the most end-user-facing integration and I think it's bad UX to catch OOM and other VM errors.


Cancelling node selection with Escape breaks shape editing undo

Godot version
4.0 964fc6e
System information
Windows 10 x64
Issue description
Tested with CollisionShape nodes. When you start dragging a shape, but press Escape without releasing the mouse button, the node gets deselected and the new size gets applied. You can't undo this action:

In case of 2D shapes it's worse, because when you click the node afterwards, it will stick to cursor until you click again:

Steps to reproduce

Add a CollisionShape (2D or 3D)
Add any editable shape
Drag shape's handle to change it size
Without releasing mouse button, press Escape

Minimal reproduction project
N/A

I assume this is the desired behaviour?

Escape Pressed
Revert to previous value, no commit made to undo/redo.

Interestingly moving nodes in the editor does not work like this. Pressing escape while drag-moving a node does nothing.
https://user-images.githubusercontent.com/41730826/211537227-b2fce170-2e9e-4c4c-a8c9-38130a095d48.mp4


Improve Docker setup and update dependencies (related to #10)

Hi,
This PR does two things:

Improve Docker compose's behaviour when running tests
Update the Spark and spark-xml version dependencies

The second is fairly straightforward, but to explain the changes in the first:

The volume definition is removed. Because the volume is persistent, it will overrule the COPY command in the Dockerfile which copies to the same location. Under the old version this meant you had to remove the volume before rebuilding if the local code had been changed. There is no reason to maintain the volume contents between runs of the container, so the volume is not necessary.

Additionally, the volume was originally mounted into the repository directory which meant that any test output, such as __pycache__ directories, was placed in the user's directory as the root user. This avoids that inconvenience.

The download_spark.sh script now sets -x, so that its commands are output before they are executed. This gives a similar output to what Docker does when running the Dockerfile.
wget is called with the "not-verbose" flag instead of the "quiet" flag. Quiet suppresses all output including errors, which in my case meant I couldn't see that I was getting a 404 for the old URL.

Thanks!

Released in 0.5.2. Please find it on pypi


Make DVC called through CLI

Summary

How to test

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Apparently, this PR is not required.


Added functions to fill team slots with bot or yourself

'Cause if you create a lobby, you might occasionally want to spectate some bots duking it out against eachother

One might, indeed.


[1.18.2] Crash with mobs form EvilCraft

I got crash while encountering some mobs from EvilCraft (Netherfishes). Had Apotheosis armor and sword while encountering. Now when I try to run save I have this crash message in launcher:
The game crashed whilst ticking entity
Error: java.lang.IllegalArgumentException: Can't find attribute apotheosis:current_hp_damage

Detailed crash report is attached:
crash-2022-08-24_08.51.22-server.txt.
Apotheosis version 5.5.1, EvilCraft version 1.2.6.

Duplicate of #629
(evilcraft bug)


docs: fix suggested VimEnter autocmd

Adds nested = true to the suggested VimEnter autocmd, as per https://github.com/stevearc/resession.nvim/issues/44#issuecomment-2027345600.
Fixes #44

LGTM thanks!


TemplateBinder is removing matched route values

Issue described in this comment. https://github.com/microsoft/reverse-proxy/issues/56#issuecomment-885487612
TemplateBinder removes route values which have already been matched. This is an issue when re-trying the request - no route values available to retry.

https://github.com/dotnet/aspnetcore/blob/23b704915cdb9a73df7a61ff1aaa894712098615/src/Http/Routing/src/Template/TemplateBinder.cs#L556

Triage: We need some mitigation (e.g. copying the dictionary before applying the Transform) ... @tratcher to find out more from ASP.NET point of view design.


CommandBar Improvements

I'm testing out the current V1.1.0 release and I love it, really amazing work!
However, I just had some suggestions/improvements for the CommandBar. Here is my xaml for reference:
<ui:CommandBar HorizontalAlignment="Stretch" VerticalAlignment="Top" DefaultLabelPosition="Right">
    <ui:CommandBar.PrimaryCommands>
      <ui:CommandBarButton Label="Add" Icon="Add"/>
    </ui:CommandBar.PrimaryCommands>

    <ui:CommandBar.SecondaryCommands>
      <ui:CommandBarButton Label="Open" Icon="Open"/>
    </ui:CommandBar.SecondaryCommands>
</ui:CommandBar>

The first thing is when the label is displayed to the right, the text is off-centered of the icon, as you can see below:

Another request, is to have the CommandBar use the same background (or at least a darker color to show it is a bar of some sort) as the NavigationView and MenuBar:

Regarding this, ^, is there a DynamicResource brush or something I can set for the background that would match the same brush used as the background of the NavigationView and MenuBar?

The first thing is when the label is displayed to the right, the text is off-centered of the icon, as you can see below:

Sometimes sizes/margins/paddings don't port very nicely. I had to make the Viewbox holding the icon in the template bigger so it better matches WinUI (it's 16px in WinUI, I bumped to 20px, as it was too small, but I don't know why) adjusting that makes the margins wrong and pushes the icon too far down. This is a simple fix. The other thing, which I don't think is the primary issue here, and is where taking WinUI cross platform has issues, is the margins applied to TextBlocks in many WinUI templates are based on the Segoe UI font, which doesn't necessarily exist outside of Windows, and other fonts don't always align the same. So it may not be 100% possible to perfectly align

Regarding this, ^, is there a DynamicResource brush or something I can set for the background that would match the same brush used as the background of the NavigationView and MenuBar?

The NavigationView pane and MenuBar are transparent by default (that's just what MS decided) so the darker color is the default Window/page color, which I believe is SolidBackgroundFillColorBaseBrush
All colors & brushes are here for v2 styles (the resource keys are the same for dark theme):
https://github.com/amwx/FluentAvalonia/blob/master/FluentAvalonia/Styling/StylesV2/LightResources.axaml

The other thing, which I don't think is the primary issue here, and is where taking WinUI cross platform has issues, is the margins applied to TextBlocks in many WinUI templates are based on the Segoe UI font, which doesn't necessarily exist outside of Windows, and other fonts don't always align the same. So it may not be 100% possible to perfectly align.

Would we be able to add SegoeUI Font file to the framework or something and use it in the styles?

The NavigationView pane and MenuBar are transparent by default (that's just what MS decided) so the darker color is the default Window/page color, which I believe is SolidBackgroundFillColorBaseBrush

That was it! Thanks :)

@amwx I changed the background to match however I'm experiencing another issue:

Notice how when I go to click ... to display the secondary commands, the background becomes transparent on the command bar. When I close the secondary commands, it goes back to what i set it to.

When the CommandBar IsOpen=true, the background is changed (it also adds a border), which was added as part of the v2 Fluent styles, e.g., in WinUI XamlControlsGallery:

To not do this, you'll have to override this Style Selector to set the background to whatever (replace CommandBarBackgroundOpen with the resource you want.
https://github.com/amwx/FluentAvalonia/blob/7e508a34f1cf5f32799143daeba455763b2a671c/FluentAvalonia/Styling/Controls/CommandBar/CommandBar.axaml#L271-L275

That worked! Thanks for all the help again :)


Publish symbols to prodcon feed

Here are notes on what the symbol publish step will be looking for in the manifest:https://github.com/dotnet/core-eng/blob/master/Documentation/Orchestrated-Build/Api/publish.md#publish-symbol-packages-to-symbol-server. (Something that might not be clear is that it’s looking for Blob elements, not Packages.)
Placeholder for what do with profiling (.ni.pdb) pdbs produced as part the build.

cc @natemcmaster \ @JunTaoLuo \ @dagood

We confirmed that this made its way onto the Prodcon feed.

@ryanbrandenburg Is the prodcon feed something can be access externally/publicly?

It is not. To my knowledge there has not been a decision on where/how/if to make symbols publicly available.

Is there another issue for making the publicly available? If not, can you make one and link it here?

The ProdCon feed is available for each build, for example this is the 2.1.1 build: https://github.com/dotnet/versions/blob/726018548f536bb1176c25792a6bf18f88b5d989/build-info/dotnet/product/cli/release/2.1/build.xml. That said, it's not easy to navigate these and ProdCon feeds aren't terribly useful as a symbol source.
When we release a build, symbols should be available on https://msdl.microsoft.com/download/symbols. In Visual Studio, this is the default location called "Microsoft Symbol Servers".


Write nice documentation for connecting to mobile web from a phone in the development environment

Because your development server has, by default, a firewall limiting outside access, some care needs to be taken.  There are two options:

Use a remote development environment (docs/development/remote.md)
Do some e.g. port-forwarding and IP address discovery setup work that most developers won't be able to quickly do off the top of their heads

I think the mobile project has something good that mostly covers this second case for mobile app development, I'll ask them for the link and we can try to incorporate that.

https://github.com/zulip/zulip-mobile/blob/master/docs/howto/debugging.md#webview has the mobile app docs, which we can probably integrate with.

This is valuable and I think definitely belongs in these docs, but it answers a different question than I believe you asked.
The linked section is about connecting your browser developer tools, on your nice laptop/desktop with a keyboard and big screen, to a webview on your phone to debug behavior happening inside the webview. The same steps can also connect those dev tools to a mobile browser; @borisyankov added in chat some remarks on how that translates:

On iOS you are always looking at an ebedded Safari even when using Chrome (maybe it is actually WKWebView, but can be thought of as 'Safari)
So you would want to use desktop Safari for the debugging, just as we have explained for our WebView debugging.
Since Apple has stopped developing Safari for Windows, this can probably only be done on a Mac (or Hackintosh)
For Android, it's easy and simple, connecting with any Chrome desktop browser on any platform should work.

The original question in this thread was about connecting your mobile browser to a dev Zulip server. The mobile app's doc for that is here:
https://github.com/zulip/zulip-mobile/blob/master/docs/howto/dev-server.md
I believe those steps will be exactly the same for mobile web, up until the (trivial) last step: enter the identified URL in the browser location bar instead of in the app's "organization URL" box.

I think it's worth a brief comment explaining how to test small-screen stuff from the laptop:
https://developer.mozilla.org/en-US/docs/Tools#Responsive_Design_Mode
(there may be a better link out there)

Here's a doc for a similar feature on Chrome: https://developers.google.com/web/tools/chrome-devtools/device-mode#viewport


TypeScript Compilation with Microsoft.TypeScript.MSBuild not working

Microsoft.TypeScript.MSBuild nuget package compiles typescript as part of the project build.
The usage is straightforward, just a package reference and a tsconfig.json.
However, I'm having troubles getting it working with this SystemWeb sdk target.
Any ideas on I can get Microsoft.TypeScript.MSBuild to play nice with the SystemWeb sdk type?
Things I've tried
I've run several experiments. I can confirm that these instructions successfully compile typescript in

a default Asp.Net core MVC template
a .net 8 class library
a net472 class library on sdk style

Adding Microsoft.TypeScript.MSBuild to a classic non-sdk style Asp.Net project using the Visual Studio nuget package UI also successfully compiles TypeScript during the project build.
Examining the project file, installing Microsoft.TypeScript.MSBuild to a non-sdk project adds these two import statements
<Import Project="..\packages\Microsoft.TypeScript.MSBuild.2.4.1\build\Microsoft.TypeScript.MSBuild.props"
 Condition="Exists('..\packages\Microsoft.TypeScript.MSBuild.2.4.1\build\Microsoft.TypeScript.MSBuild.props')" />

<Import Project="..\packages\Microsoft.TypeScript.MSBuild.2.4.1\build\Microsoft.TypeScript.MSBuild.targets"
 Condition="Exists('..\packages\Microsoft.TypeScript.MSBuild.2.4.1\build\Microsoft.TypeScript.MSBuild.targets')" />

However, installing the nuget package and adding these imports to a template SystemWeb project does not similarly enable typescript compilation.
Update: I realized these Import tags expect nuget to create a packages directory, but SystemWeb with PackageReference doesn't do that. I found absolute paths to the prop and target files and updated the import tags. Unfortunately that didn't work either.

I can't replicate any issue with this.
You simply add the package as normal for an SDK project (e.g. copy from the nuget package page).
I created an example project using the template and added a couple of TS files (including one with an error) and the build files work including showing errors.
I only had to add that I wanted to include the *.js output files as content to the template (along with the package reference) - and this step was not strictly required for testing - only for publishing.
https://github.com/CZEMacLeod/SystemWeb-SDK-with-TypeScript
  <ItemGroup>
    <PackageReference Include="Microsoft.TypeScript.MSBuild" Version="5.6.2">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
    <Content Include="Scripts\**\*.js" />
  </ItemGroup>

Please provide an example project that doesn't work.
N.B. In (all) SDK projects, you don't need to add the imports for the .props/.targets files in nuget packages - they are imported automatically.
If you want to - check the imports section when you select to show hidden files in the solution explorer...

Thanks for the insight!
The problem seems to be our TypeScript version.
I cloned your example and changed the import to

  <PackageReference Include="Microsoft.TypeScript.MSBuild" Version="2.4.1">
    <PrivateAssets>all</PrivateAssets>
    <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
  </PackageReference>

That was enough to break the build.
Conversely, updating my own example project to Microsoft.TypeScript.MSBuild 5.6.2 fixed my build.
The package version is supposed to correspond to the typescript version,
so it looks like we'll have to bite the bullet on updating our typescript.
Thanks again!

Looking at the TypeScript documentation Compiler Options in MSBuild it looks like you can force the tools version seperately from the MSBuild version:
  <PropertyGroup>
    <TypeScriptToolsVersion>2.4</TypeScriptToolsVersion>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.TypeScript.MSBuild" Version="5.6.2">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
    <Content Include="Scripts\**\*.js" />
  </ItemGroup>

Looking at detailed build logs, it looks like the Microsoft.TypeScript.MSBuild package is overwriting TypeScriptToolsVersion.
We hypothesize that TypeScriptToolsVersion is an artifact of some other approach, but we haven't clearly identified its usage yet.
Also, I gathered up my experiments and published them to a repo.
https://github.com/WesternCapital/TSCompile-SystemWeb-Experiment
It looks like the build might not be as smooth with Asp.Net as I thought.
I had "compileOnSave": true, in the tsconfig, which I think led me to think Asp.Net Core and Classic Asp.Net were building out of the box with Microsoft.TypeScript.MSBuild 2.4.1. When clean up the examples, I noticed that both vanilla Asp.Net projects were not building. The class libraries still build with 2.4.1.

I noticed a couple things that might shed some light on the odd behaviors you are seeing

In the TSCompile-AspCore sample explicitly set the "Build Action/ItemGroup" of the tsconfig.json to None instead of Content
In the TSCompile-classlib sample explicitly set the "Build Action/ItemGroup" of the tsconfig.json to None instead of Content
In the TSCompile-classlib-net4 sample explicitly set the "Build Action/ItemGroup" of the tsconfig.json to None instead of Content
In the TSCompile-SystemWeb-Experiment sample did not have a tsconfig.json file at all

During the build, the TypeScript engine looks for a tsconfig.json file, it only looks in the Content ItemGroup, not the None (Not sure why they made it that way, but you can check the FindConfigFiles target in the Microsoft.TypeScript.targets  file), so in all the above cases , it ran as if it did not have a tsconfig.json file.
When the build runs WITH a tsconfig.json it assumes the developer used the appropriate settings in the config file to choose the desired .ts files, and performs a preCompute step to look under the project root directory for files that satisfy the config file settings, and then passes those through to the CompileTypeScriptWithTSConfig target
When the build runs WITHOUT a tsconfig.json it requires that all desired .ts files be included to the TypeScriptCompile ItemGroup and if that ItemGroup is empty then the CompileTypeScript target is completely skipped. (Note that the 2.4.1 version of the package does not make the TypeScriptCompile ItemGroup available so it will be empty).
Although long term you likely want to be looking to upgrade, in the short term I think you can still get the 2.4.1 version working for you with one of the following
If your real project uses tsconfig.json already, ensure that it is Content (not None)
If you do not have one, consider incorporating one, ensuring that it is Content (not None)
If you do not want to add a tsconfig.json consider the following project file tweak that will need to be removed later when you do upgrade TypeScript Compiler. Which will allow you to set the "Build Action/ItemGroup" for all your desired .ts files so tehy can be found during build.
<ItemGroup>
  <AvailableItemName Include="TypeScriptCompile" /?
</ItemGroup>

Wow. I did not expect that the tsconfig.json had to have a Content build action.
That did it though! Thank you!


heapless on const generics: status

I tried to port heapless types from GenericArray to usize const generics.
Here is branch.
Today I managed to compile it in release mode.
For testing you can use: cargo test --release.
Issues:

In debug mode compile fails.
Queue doesn't work. Fails on type inference. I think the problem is in the interaction of default types and const generics. pub struct Consumer<'a, T, U = usize, C = MultiCore, const N: usize>
I don't know how to set PowerOfTwo restriction for indexmap.

Everything else is pretty good.
rustc 1.37.0-nightly (8aa42ed7c 2019-06-24)

Hi,
this is a very interesting and strategical step forward for the heapless crate.
Porting heapless to const generics was on my mind aswell, but time is limited.
Here are my thought on the PowerOfTwo restriction:
In general what is needed is a static assertion for the const generic.

There exists a thread which discusses exactly this feature as a language feature, but to no conclusion (Link)[https://internals.rust-lang.org/t/idea-static-assertions/7753/6]
The const_assert macro of the (static_assert crate)[https://crates.io/crates/static_assertions] might help.
An internal new type Foo<const N: usize>(PhantomData) with a trait PowerOfTwoMarker that is only implemented for Foo<2>, Foo<4>, Foo<8>, Foo<16> and so on might be possible, but limits the allowed values to an enumerable range for which this trait is imlememted. (I'm not sure about the PhantomData part though)

@burrbull thanks for trying this out. I think the compiler team will appreciate all the bug reports.
From my side, I would prefer not to make heapless depend / use const generics in any form (even behind a Cargo feature) until the feature has been (partially) stabilized. Nightly features are a maintenance burden that I would prefer to avoid.

It's a good day.
https://github.com/rust-lang/rust/pull/65652
https://github.com/rust-lang/rust/pull/65092

See #168 for up to date version of this.


rput raises PDHTTPError from JSONDecodeError when adding a user to a team

Adding a user to a team with client.rput(f'teams/{team}/users/{user}') raises PDHTTPError from JSONDecodeError encountered trying to decode response text. The raw response from put is a 204 with no content.
Removing a user from a team with client.rdelete(f'teams/{team}/users/{user}') does not raise the same error even though the raw response is also a 204 with no content.

Hi @mpjura,
The r* methods assume that the endpoint they are used on has entity wrapping. That does not apply in the case of this endpoint.
One can get around this by simply using put instead of rput.
Nevertheless, it isn't explicitly listed as an endpoint that the r* methods don't support, so the documentation shall be updated.

got it, thanks @Deconstrained


[Infrastructure] Data scaling and hosting infrastructure

Data scaling infrastructure
Making design choices that impact the usability of astropile when it comes to large data. The data volumes we are discussing and planning to have are not normal, and we cannot treat them naively without massive downsides.
Contacts: @mb010,
Participants: @mb010,
Goals and deliverable
Having a clear hosting and access plan which has been benchmarked and validated on at least two HPC systems.
Resources needed
Access to HPC facilities of our choice and a large test data set. Interest, reading skills for various documentations of different softwares are all that is required. Having experience with data pipelines or TB scale data products would be a benefit to thinking about this.
Detailed description
If we want this data to be used, we have to think about how it is going to be accessed. Data loading is one of the main bottlenecks to training neural networks. As such, we should carefully consider how this data can be hosted and how it can be processed in an effective and practical way to enable and allow for different applications.

To get an idea of how smaller data sets can cause issues, have a read of this issue I found which highlights the differences clever data infrastructure can have on loading.

Some functionality to consider include:

Data sharding
Memory mapping
Huggingface hosted datasets streaming capability: loading in streaming
academic torrents

Should we host data like this?
How do we handle data updates?
The 1 vs multi torrent discussion: Do we have one torrent and so encourage everyone to have all of the data (+better upload speeds for niche data subsets) (- not everyone will be able to participate) or do we have torrents for (reasonable) subsets of data so that institutes can host their science case without requiring >10TB storage for any normal user (+ more users and large institutes can hots all of the data) (-Potentially resulting in niche subsets to be hosted at suboptimal data rates as they are not required for many science cases)?
Software infra to automatically select appropriate magnet links for specific data selection.

Data format currently expected to be HDF5, should it be? options. Arrow might be more useful depending on expected usage.

Thanks Micah, some thoughts from me:
Torrent vs HuggingFace

A two-pronged approach to hosting is probably best, with HuggingFace (should be okay to O(10)TB) and torrents. HuggingFace would give us a central space for data consolidation, hosted in a place where DL practitioners are already familiar. A great benefit of HuggingFace is its data streaming feature which we would not (easily) get with torrents.

HuggingFace would require us to use either parquet files, or to push our hdf5 backend fork upstream however.

Torrenting thoughts

I think that several torrents is the way to go here for dissemination of the dataset. Best way to do this is probably serving subsets of our *parquet, *hdf5 or *arrow files grouped roughly by subject (i.e. galaxy imagery, spectra, text, timeseries...).
Data updates would be tricky, but we can leave that to downstream scripts and simply append to the torrents as more data is added (and of course update the central HF dataset in the usual way).
Torrenting may not be allowed on some datacentres, and would induce substantial egress charges in cloud providers. Something to think about as we look for volunteer HPC nodes to host tens of terabytes.

Splitting this issue soon (links to be added when the respective issues are created)
I guess these issues can all be split to make the discussions clearer. I will open up new issues before lunch for file format, torrenting, benchmarking data speeds, and data serving (torrenting and HF).
HF Datasets Streaming and Torrenting
I agree on using both HF datasets and torrents, which should be parameterisable in the data loaders provided by astropile. I don't intend us to use any paid cloud providers. If we don't have a single facility that can host the entire pile then there are other larger issues than whether or not we can manage the torrent files. I am optimistic in having multiple full mirrors: I think, as @EiffL was saying yesterday, that multiple large collaborations or archival data providers would be keen to host this data set for their researchers.

I can fairly easily benchmark local HF data vs HF streaming via code in AstroPT. This data is all in arrow format as per HF guidelines. From previous training runs the latency is surprisingly similar, but I will get some hard numbers and post here.

In https://github.com/AstroPile/AstroPile_prototype/blob/hf_benchmarking/benchmarks/data_throughput.py there is a script to check HF local vs HF remote streaming speed. I ran the code on my local machine, and local HF parquets allow us a ~4x speedup. Bare in mind that this difference can be mitigated with multiple workers, and will be less significant if we need to preprocess the data before model ingestion.
Here is the code output for those can can't run the code:
gal/s local<PHONE_NUMBER>290433
gal/s remote<PHONE_NUMBER>5196582
ratio 0.2526852992917515

Interested in following along with this :)

Interesting! So, note that I think the reason for slow local access from HF in non-parquet format probably has to do with the way HF handles sequences. I found in some experiments that if you store a sequence as an array it loads much faster.

I think these are actually experiments to be run for a version 2 potentially given our time constraints? With all of the discussions around various formatting options for the different science data, I'm pretty sure that benchmarking will need to be done for each format that we eventually add. I think I will draw up some benchmarks that we will have to run eventually but leave them for now until everything else settles a little bit.
The experiments we should run are against streaming vs specific dataset subsets. We should be able to infer what sort of formats work for our use case. We should test mounted: SSD vs HDD vs direct from HF, single vs various threadcounts, parquet vs internal custom formats (if applicable).


DOC: Fix link to test/README.external in INSTALL.md

CLA: trivial

Checklist
NA

This pull request is ready to merge

Merged
1b495200436b57309ca958a7a72affaf75171c1a DOC: Fix link to test/README.external in INSTALL.md


add beta_neg_binomial_lcdf

Summary
With this PR the lcdf of beta negative binomial distribution are added.
See issue #3115
Fix a few typos in beta_neg_binomial_lccdf, pr #3114.
Expressions involved (almost the same as #3114 , just add the chain rule from log ccdf to log cdf):
$$
\begin{align}
& P(Y \leq y) = F(r,\alpha,\beta) = 1-C(r,\alpha,\beta) = 1-\frac{\Gamma (r+y +1) B(r+\alpha ,\beta +y +1) {}_3F_2(...)}{\Gamma (r) B(\alpha ,\beta ) \Gamma (y +2)}
\end{align}
$$
where $C(r,\alpha,\beta)$ is ccdf, we denote ${}_3F_2({1,r+y +1,\beta +y +1}; {y +2,r+\alpha +\beta +y +1};1)$ as ${}_3F_2(...)$
Then the partial derivatives w.r.t log ccdf:
$$
\begin{align}
\frac{\partial \log C(r,\alpha,\beta)}{\partial r} &= \psi(r+y+1) + \psi(\alpha+r) - \psi(\alpha+\beta+r+y+1) - \psi(r) + \frac{\partial \log {}_3F_2(...)}{\partial r}, \
\frac{\partial \log C(r,\alpha,\beta)}{\partial \alpha} &= \psi(\alpha+r) - \psi(\alpha+\beta+r+y+1) + \frac{\partial \log {}_3F_2(...)}{\partial \alpha} - \psi(\alpha) + \psi(\alpha+\beta), \
\frac{\partial \log C(r,\alpha,\beta)}{\partial \beta} &= \psi(\beta+y+1) - \psi(\alpha+\beta+r+y+1) + \frac{\partial \log {}_3F_2(...)}{\partial \beta} - \psi(\beta) + \psi(\alpha+\beta).
\end{align}
$$
where
$$
\begin{align}
\frac{\partial \log {}_3F_2(...)}{\partial r} &=  \frac{\partial {}_3F_2(...)}{\partial r} /  {}_3F_2(...) \
&= \left[ _3F_2(...)^{({0,1,0},{0,0},0)}(...) + _3F_2(...)^{({0,0,0},{0,1},0)}(...) \right]  / _3F_2(...), \
\frac{\partial \log {}_3F_2(...)}{\partial \alpha} &=  {}_3F_2(...)^{({0,0,0},{0,1},0)}(...)  / {}_3F_2(...), \
\frac{\partial \log {}_3F_2(...)}{\partial \beta} &= \left[ _3F_2(...)^{({0,0,1},{0,0},0)}(...) + _3F_2(...)^{({0,0,0},{0,1},0)}(...) \right]  / _3F_2(...).
\end{align}
$$
By chain rule,
$$
\begin{align}
\frac{\partial \log F(r,\alpha,\beta)}{\partial r} &= - \frac{1}{F(r,\alpha,\beta)} \cdot \frac{\partial C(r,\alpha,\beta)}{\partial r} &= - \frac{C(r,\alpha,\beta)}{1-C(r,\alpha,\beta)} \cdot \frac{\partial \log C(r,\alpha,\beta)}{\partial r}
\end{align}
$$
Therefore, the partial derivatives w.r.t log cdf:
$$
\begin{align}
\frac{\partial \log F(r,\alpha,\beta)}{\partial r} &= - \frac{C(r,\alpha,\beta)}{1-C(r,\alpha,\beta)} \cdot\frac{\partial \log C(r,\alpha,\beta)}{\partial r} , \
\frac{\partial \log F(r,\alpha,\beta)}{\partial \alpha} &= - \frac{C(r,\alpha,\beta)}{1-C(r,\alpha,\beta)} \cdot\frac{\partial \log C(r,\alpha,\beta)}{\partial \alpha}, \
\frac{\partial \log F(r,\alpha,\beta)}{\partial \beta} &= - \frac{C(r,\alpha,\beta)}{1-C(r,\alpha,\beta)} \cdot\frac{\partial \log C(r,\alpha,\beta)}{\partial \beta}.
\end{align}
$$
Tests
Test is written follow the guide.
Side Effects
No.
Release notes
beta_neg_binomial_lcdf is available if merged.
Checklist

[x] Copyright holder: Zhi Ling
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

@lingium while it is very useful to keep each feature in a separate PR (thanks for doing this!), if you do have multiple things you want to add you can open several PRs at once, which might help with review lag-time. I think you said you also have an RNG for this distribution, and if so feel free to open a separate PR before this one is merged

Hi @WardBrian , got you, Just thought this modification is too minor so I didn't open another PR. I'll make sure to open separate PRs for different things next time. Yes, there is a RNG. I can open it in parallel.
BTW I'm encountering problems adding signatures to the compiler, still trying to understand the OCaml thing. Would you mind me to submit a PR anyway later and then you can tell me where the problem lies?


add primary scool school Szkoła podstawowa im. Mieczysława Kaczyńskiego

@skneroniii Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@skneroniii You might miss my previous comment. Please react.

@skneroniii I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Question mark for childless parents

closing in favour of #100 since this includes both and I also merged into the latest development to avoid conflicts.


how to get the latest 1-5 tweets of some people using their twitter user name?

Got confused by
"
users = scraper.users(['foo', 'bar', 'hello', 'world'])
users = scraper.users_by_ids([123, 234, 345])  # batch-request
tweets = scraper.tweets([123, 234, 345])
likes = scraper.likes([123, 234, 345])
tweets_and_replies = scraper.tweets_and_replies([123, 234, 345])
media = scraper.media([123, 234, 345])
following = scraper.following([123, 234, 345])
followers = scraper.followers([123, 234, 345])
scraper.tweet_stats([111111, 222222, 333333])
"
have tried:

from twitter.scraper import Scraper
email, username, password =<EMAIL_ADDRESS>'myuserName', 'password'
scraper = Scraper(email, username, password)
Traceback (most recent call last):
File "", line 1, in
TypeError: Scraper.init() takes 3 positional arguments but 4 were given

Thanks for the question. Please ensure you've installed version 0.9.6 or greater. Those values in the readme are just placeholders.