Vulkan: Random Crashes

Hi,
encounter random crashes on startup of vulkan programs (with both 32bit and 64bit executable),even after the fix #230 is applied, not sure what the cause this. It happens even with the vulkan sdk samples tri and cube (with both 1.0.3 and 1.0.5 sdk).
Even after changing the default calling convention to __stdcall the random crashes do persist.
Compiled with vc 2015 Update 2 and vc 2013.
Also when the cube demo of the sdk sometimes run, then with --validate a lot of errors pop up about mismatching values and some semaphore usage errors.

As a additional info, the vulkan-1.dll is a freshly compiled one with the latest github src.

Can you give any details about your environment or more information about what the crashes actually are? Have you attached in the debugger to see what the crash is? I've not seen anything like this locally so I'd need more information to either reproduce or estimate how to fix.

When the layer VK_LAYER_LUNARG_standard_validation is used then it crashes inside vkGetPhysicalDeviceSurfaceSupportKHR of the object tracker. With attached debuger it shows that the dispatch table lookup fails and it tries to read from a null pointer and crashes. This happens only if the layer of renderdoc is active, without it it does not crash.

What operating system and vulkan driver are you using?

Windows 8.1
Nvidia 364.72

I've had one other report from someone on nvidia with kind of similar symptoms. It could be the same and they weren't using the validation layers. After some debugging, it turned out that some nvidia driver thread was overwriting some of the information inside the renderdoc wrapped object, which ended up causing a crash under a sort of race condition.
Unfortunately I can't reproduce it so I'm not able to prove anything or investigate further. This might be because I'm on windows 7, I don't know. I'll ask the other user to see whether they got a response from nvidia about what's happening.
In the meantime, are you able to test on another IHV's hardware to test if the crash still happens?

Sorry, i can't test it on a different implementation, only nvidia available :(

OK. It seems like it's the same problem, which went away on AMD for the other user I mentioned. I will leave this bug open for now but I can't do anything more unless I have some information or a way to reproduce. I don't get it on my nvidia machine, possibly since it is Win7.
If I hear back from nvidia I will update.

The really strange thing is, it worked just fine until some time ago and then suddenly starting to crash all over the place and only if renderdoc active.
Tried to roll back to older drivers but no luck.

Some other things to try, just in case it shows anything interesting: does it work if you only enable renderdoc, no validation layers? What if you roll back to an older renderdoc build (in case something has been subtly broken since 0.27)?

I crashes with and without enabled debug layers.
Simple tests like renderdoccmd C:\VulkanSDK\<IP_ADDRESS>\Bin\cube.exe, crash, don't start or just work at random.
I will try a older version.

Now i am really confused...
i rolled back to 144a91ea9797674db8f4d2ecd5c5eeeaf574979e where i am sure that it worked fine.
And its crashing too, so something is very odd here.
I just reinstalled the vulkan sdk (<IP_ADDRESS>) and the restributable, no change.

I was able to reproduce what I think is this bug on one machine of mine while investigating #236. I think I've found what the problem is, but I caught it at 2am last night so I will need to try to fix it tonight, but I'll keep this bug updated.

Did also more testing, rolling back to a older driver and rolling back to the sdk 1.3.1 fixed it.
As soon as i update to the 1.5.1 sdk it starts crashing again so i would assume its the loaders fault?

I think that commit will fix it. Let me know what you find.
The problem seems to be that the loader now since this commit will free() and then malloc() the physical devices every time they are enumerated. This means the pointers are different each time. RenderDoc was wrapping the pointers once since I need to serialise the initialisation data, and then returning the same wrapped objects each time.
The problem is the second time, I return a valid wrapped object but the unwrapped pointer is now pointing at free'd memory. If you're lucky then nothing overwrites that memory and it still works, but if you're unlucky then the dispatch table is corrupted when some other heap allocation jumps into that spot.
Instead now I just re-wrap the returned physical devices every time, modifying my wrapped object.

Hi,
it is working fine now, tanks!


Working on Issue The aggregate is not getting designated as local tier.   #16

#16

Defaulting to patch aggregate - STEP 12 - all the time


Add base64 decoding for gitiles.

This is a workaround for #394. Tested with googlesource.com.

If we don't want to add more exemptions, I can audit the added packages.


Floating resolvConf of KubeletConfiguration breaks migration from Ubuntu 22.04 to RHEL9

TC:

Deploy cluster on Ubuntu 22.04 with services.resolv.conf section.
Add node on RHEL9

AR: Node is not joined. journalctl for kubelet contains error "open /run/systemd/resolve/resolv.conf: no such file or directory".
Possible W/A it to use services.kubeadm_patches.

For new Kubernetes versions this may be fixed in https://github.com/kubernetes/kubeadm/issues/3034


Countryside stewardship grants

This PR contains the work necessary to enable creation of DEFRA/Natural England Countryside Stewardship Grants from Specialist Publisher. The facets are still undecided so they will be added at a later date. One thing to note is this scheme is owned by DEFRA and Natural England so this will require some refactoring of the permission checker, but this will also happen at a later date. Ticket.

Looks good :+1:
I mean, it's a lot of copy-pasting, which suggests we could probably make things better in many places. But this will get the job done.

@evilstreak I've already amended the commits you commented on. This should be good to go now.


Remove abs.yaml

Remove abs.yaml file to push to defaults.

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_73qbg8m9fd/clone/recipe/meta.yaml:55: missing_doc_source_url: The recipe is missing a doc_source_url
WARNING: /tmp/abs_73qbg8m9fd/clone/recipe/meta.yaml:55: missing_license_url: The recipe is missing a license_url
Warnings were found


style: summary grid

Motivation
For the new design we need some sort of "summary grid".
Might not be exactly what's in the design but, it's a start.
Changes

new media breakpoints for xlarge that amend the menu width
new .summary-grid

Screenshots
Design:

On hold. Will probably never happen.


Chore: clean up dead code after DocSearch switch

Note: I turned Travis CI on for PRs to test this out. I think we should leave it on, but please let me know if you disagree with me.
I started digging into why CI has been failing, and it appears to me to be because the script we're trying to run in Travis CI is bundle exec jekyll algolia, however, we removed the algolia gem last year.
This commit is the first commit to start consistently failing CI, and it looks like that's the first commit to be run with Travis (in other words, Travis has been failing since we turned it on).
I believe all the deletions here are no longer used. The only I'm not 100% sure about is _plugins/search.rb, but it looks like we're using Algolia's DocSearch API which runs entirely in JS and that we don't use this plugin any more. I've run the build locally and, as far as I can tell, search continues to function normally.
If/once we merge this, I'll also remove the ALGOLIA_API_KEY environment variable in Travis, since we it doesn't seem like that is used either any more.
Please let me know if I'm missing something important and deleting something I shouldn't be!

Yes, your guesses were correct. Once we removed Algolia gem, build was no longer needed at all. I just never got around to removing it.

In addition to merging this, I have also deleted the ALGOLIA_API_KEY environment variable in the Travis build.


Add files via upload

Kryptosjay, thank you for the work here!
These cannot be merged, because we have a working design system now. However, your contribution is meaningful and worthy of applause. Well done! ❤


Multinode Config file for knife vsphere vm clone

The tool have some functional for use config file parameters with multiply host some like
# Config json
"NewNode": {"template": "UbuntuTemplate",
"cspec" : "StaticSpec",
    "cips": ["<IP_ADDRESS>/24","<IP_ADDRESS>/24"]
}

and use it for provision and bootstrap multinode in knife vsphere vm clone like
 vsphere vm clone -config config.json

???

Hi Oleg, we don't have anything exactly like that. It's possible to do with a plugin, for example this one does something similar with Windows installations.
If everything you do is already available as a command line option, it may be faster to wrap knife vsphere vm clone with a script to do what you want rather than making a plugin. For example, I rarely call this gem directly when cloning, I have a shell script that passes some defaults and does some sanity checking for my particular environment, before calling knife vsphere vm clone.


Can you give the xflickrco test split images pre-extracted features?(2000 images)

Hi, please find them in the IGLUE repository here.


Enhance Makefile to detect obsolete replace statements

Description
Replace statements in go.mod file become obsolete when the underneath library gets updated and becomes free of vulnerabilities. Unnecessary replace statements don’t get automatically removed even when they become obsolete.
The finally used dependencies during compilation time are visible in the go.sum file or as //indirect marked dependency in the go.mod file (last block in the file normally when using Go > 1.17)
AC:

A script is required which parses the go.mod file: it drops a replace statement, regenerates the go.mod + go.sum  file and verifies if this replace statement is still required. If the finally used indirect library:

is newer than the version in the replace statement, the replace statement can be dropped
is older than the version in the replace statement, the replace statement is still needed

the script has to be executed whenever the go.mod file was changed (e.g. adding it to Makefile and run it when compilation happens)

Reasons
Minimise the amount of replace statement and recognise outdated replace statements.
Attachments

Please check the features of the pender-bot


Improve content of source tarball

Linux distributions usually source themselves from PyPI, as it is currently the case for the Debian package. The source tarball is currently missing the test suite (for CI purposes), the licensing terms governing the distribution (LICENSE file) and some form of documentation (README.md file).
You might want to distribute the examples as well, if so just add a new line with include example*.py).

LICENCE and README.md are clearly a good idea. I'm unsure about the testsuite, which isn't supposed to be helpful to the end user.
I had bad experience trying to distribute a testsuite in another context (my testsuite contained non-standard stuff like empty files which the distribution didn't like), but this one should be OK and can also be seen as example.
I think adding the examples would be a good idea.
I'm leaving this open in case others want to comment, but it seems OK to me.

I'm unsure about the testsuite, which isn't supposed to be helpful to the end user.

The end-user is likely to install the wheel, not the source tarball.
I would however need the tests to check the module when the Debian package is being built, and to run the CI tests against the binary packages whenever one of its install dependencies (including a new version of Python) is changed.

I think adding the examples would be a good idea.

I can add the examples if you want.

Any news?

Swamped by work, but I've just merged your pr. Another pr with examples would be nice IMHO.


Support array-return values in contract

Contract::ParseResponse does not support array-return types (X_len:felt, X: felt*). Instead the current method returns two variables with the length & the first value.
I am not clear whether Cairo intends to support struct return values, which also would entail changes to this function.

Is this related to #105 or #106 ?

Waiting on this to use with Multicall Contract Response.
https://github.com/dhruvkelawala/argent-contracts-starknet/blob/main/contracts/Multicall.cairo

This is covered by the release v3.5.1 and is now part of the lib.
https://github.com/0xs34n/starknet.js/releases/tag/v3.5.1


command in datahub-ingestion-cron values.yaml is incorrect

This command is incorrect
https://github.com/acryldata/datahub-helm/blob/ee2bc53a7695567072f505f4430829719ee1d6b1/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml#L26
This error occurs:
client.go:142: [debug] creating 1 resource(s)
Error: INSTALLATION FAILED: 1 error occurred:
        * CronJob in version "v1" cannot be handled as a CronJob: json: cannot unmarshal array into Go struct field Container.spec.jobTemplate.spec.template.spec.containers.command of type string
        *

The command is already duplicated:
["/bin/sh", "-c", is already in the helm template:
https://github.com/acryldata/datahub-helm/blob/ee2bc53a7695567072f505f4430829719ee1d6b1/charts/datahub/subcharts/datahub-ingestion-cron/templates/cron.yaml#L52
This caused a few problems tracking this down, however it is a simple misconfiguration in values.yaml
command: "datahub ingest -c <recipe.fileName>"
After that it deploys into cluster as expected.

@jimsmith Thanks for reporting and figuring out the issue. I have raised a PR for fixing the issue.

@sachinsaju I looked at the PR and noticed you have the square brackets they did not work for me in the workaround

@jimsmith I have updated the PR.


fix OC pod error

GzipSwift does not specify a Swift version and none of the targets

@1024jp   merge please

@qyhongfan Sorry for my late reaction. I've just merged.


write_selection_file on macOS does not work properly

Discussed in https://github.com/ghostty-org/ghostty/discussions/3594

Originally posted by newtonapple December 27, 2024
I'm on MacOS macOS Sequoia 15.2 with default text editor TextEdit.  This is my ghostty config file:
copy-on-select = true
focus-follows-mouse = true

# keybinds
keybind = super+f=write_screen_file:open
keybind = super+shift+f=write_selection_file:open

write_selection_file doesn't seem to work properly.
When I select multiple lines, the file TextEdit opens is empty.

But when I select one word, the text in the selection.txt is the entire line.

Also tried it with write_selection_file:paste, the contents in the temp files were the same as the ones in screenshots.

Use discussions. Issues are only for maintainers to create.


MSSQL 2017 GDR repo not found (HTTP 404)

Hi,
MSSQL 2017 GDR repo is not found (URL copy pasted from the documentation):
$ wget https://packages.microsoft.com/config/rhel/8/mssql-server-2017-gdr.repo
--2022-01-27 16:55:10--  https://packages.microsoft.com/config/rhel/8/mssql-server-2017-gdr.repo
Resolving packages.microsoft.com (packages.microsoft.com)... <IP_ADDRESS>
Connecting to packages.microsoft.com (packages.microsoft.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2022-01-27 16:55:10 ERROR 404: Not Found.

Hope this helps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0f184b8-7d7c-9376-06bf-a08f10ccf30f
Version Independent ID: 5c233e69-31e2-51ec-7820-2b5326a7a64c
Content: Configure Linux repositories for SQL Server 2017 and 2019 - SQL Server
Content Source: docs/linux/sql-server-linux-change-repo.md
Product: sql
Technology: linux
GitHub Login: @VanMSFT
Microsoft Alias: vanto

Related to #7250.
@es-fabricemarie -- Fabrice, thank you for your feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@VanMSFT -- Van, please look into this potential documentation issue.

Thanks for reporting this, @es-fabricemarie. We appreciate your help! The doc has been updated. https://github.com/MicrosoftDocs/sql-docs-pr/pull/21096


In index view, users without the role editors should not see Add match button

Currently users logged in as "reviewers" (or anything other than editors) in the index view can see a "Matched" column with links to "/match/", which all lead to 403 errors.
Instead, they should see a "Match" column, which should show:

If there is a proxy (i.e. proxy_id is truthy), a button linking to the proxy dataset, with the text "Proxy dataset". Use the JSON field "proxy_url", see 8c45e36085b0fdc1ae1fe7ffa984248ae8063b22.
If there is a match type but no proxy_id, then display "No match needed"
Else display "Unmatched"

You can get the user role with {{ config.role }} in the template, see an example here.

What should be displayed for 'editors' role?

They see the "add match" button as it currently is now. But people without the role "editors" can't add matches, so there is no point showing them that option.

What should be dsiplayed if current row has matched parameter?

For editors, nothing changes. For non-editors, see the section "Instead, they should see a "Match" column" in the initial issue description, giving three different possibilities.
I hope that is clear, please feel free to come back if we are still not understanding each other!

What should be displayed for 'editors' role?

They see the "add match" button as it currently is now.

Before all links were sent to the page /match, which is absent. What address should I use instead for now?

What should be dsiplayed if current row has matched parameter?

For editors, nothing changes. For non-editors, see the section "Instead, they should see a "Match" column" in the initial issue description, giving three different possibilities.

I can't see nothing about matched -- there only references to match_type (if I've got it right). (Before it used only to generate different icons and texts.) Should we use it somehow now?

Updated the PR: Added link to /match/{process_id} for editors. Parameter matched still not used.

Made some fixes for recent updates (in ProcessesListDataRender.js) -- there were some errors, see diagnostic screenshot:

Fixed code for matched column content generation on process list template.
Restored matched parameter, code localized in renderMatchCellContent method, for editors role and unmatched condition generated primary button styled link (is it neccessary?), link text generating as before (match_type or 'Edit' for matched row, else 'Add').
See commit 4912ec9.

PR #113.


disable flying in scene file

It would be great to have the ability to diable flying mode ( f key ) via the scene file so that we can stop players being able to see behind the scenes of our scenes.
It might also be useful in many cases to be able to disable the super fast dash mode (not sure what its called) too.

+1 for this please. So we can toggle on with wearbles etc and banish cheating if we wanna make a platformer :)

Noticed this little snippet from from the bridge-game example that works for a stop gap fix
// add the useLocalPlayer and useFrame hook from metaversefile useFrame() => {     if(localPlayer.avatar) {       if (localPlayer.hasAction('fly') ){           localPlayer.removeAction('fly');       }     } }

@lalalune @pigloo This issue was fixed in https://github.com/webaverse/app/pull/3348
Please check that and give me feedback.


undefined method `addresses' for #Mailgun::Base:0x007fc2c1dd8cf0

I'm trying to validate an email according to the docs, but I keep getting this error. I thought maybe the docs are out of date but after digging I'm not actually sure how to call it properly.

It appears because the hosted gem version is so insanely old... is this even maintained anymore? Can we get a fresh version on rubygems?

@9mm I'll release a version today. Thanks for reminding me.

Awesome, thanks

Any luck with this?

@9mm published 0.11 to rubygems. Thanks for giving me the push.


Add Support for Expecting an Error

We would like to be able to formally expect errors in tests. This would help formalizing cases where an engine should fail to execute. Today there are tests with comment tags that say something to the effect of "this should be an error", making this change would formalize these cases.
Option One:
Add an  tag for tests where we expect the test to return an error
Option Two:
Place tests that we expect to return error in a different location.
Out of scope:
We could have a discussion on formalizing error representations in CQL engines but for the purposes of this issue we should just worry about whether or not a test should return an error.

The current test specification supports this, and the runner takes advantage of this capability, see the evaluation of test results here:
https://github.com/cqframework/cql-tests-runner/blob/main/cql-tests-runner.js#L65
and here:
https://github.com/cqframework/cql-tests-runner/blob/main/cql-tests-runner.js#L185
Note that one of the topics we discussed at the WGM was creating error codes for the errors so that we can test error codes, rather than testing that specific messages are coming out, but that's a different issue.


Fix/unicode

Fixes https://github.com/marpple/FxTS/issues/148
Instead of handling unicode with the Array.from function in dropRight (reverse and takeRight), the unicodeToArray function of lodash.js is provided, so that the user can directly process the unicode as needed.

@shine1594
I don't know if FxTS should provide this function. I think I can definitely use it from the outside...

@shine1594 Additionally, I don't know if FxTS should provide this function. I think I can definitely use it from the outside...

@hg-pyun
Do you mean by using  unicodeToArray if a string value is entered in an operation like toArray? without exposing the function?

@ppeeou It meant that the user could define and import it himself.


lock: change locking to a mutex

I suggest changing the locking mechanism behind SpiceLock to a mutex.
Mutexes have the advantage that they allow for blocking waits natively. These are typically handled by some external sync mechanism. Thusly, threads will be put to sleep by the OS until the other place has unlocked it.
The old atomic-bool solution required a busy-wait to achieve this.
This changed implementation has the disadvantage that it requires rustc version >= 1.70.0 which, as of commiting this, still is in beta (it is stabilized however, so its just a small wait, not an indeterminate one!) . However OnceLock avoids having to pull in once_cell or lazy_static as dependencies. So i think its best to wait until june to merge this.
Have a great week!
EDIT: Oh and since you did the original legwork, what are your thoughts on this @mclrc ?
~mkalte

Sorry for the super late response, I missed the notification somehow. I don't really know a lot about the lower level details, but it sounds like it makes sense! And by now everything needed is stable, right?


[test] Add system level test for jtag initiated sram execution

Add a test point for the case where jtag loads a program into sram and then jumps the ibex core to execute from sram.

@sriyerg this might be in the test plan already, i need to double check again, but i don't think i saw it.

This is not in the testplan yet. I will add it.

@sriyerg has this been added to the testplan?

This should now be in the testplan - closing.


Fixed Illustrator template link + fixed typo

What is the purpose of this pull request?

[ ] New Icon
[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other:

Description

Fixed the links to the Adobe Illustrator template file in illustrator-guide.md and CONTRIBUTE.md
Although I couldn't find a way to access the illustrator template from the website domain (i.e. https://lucide.dev/guide/illustrator-template.ai) so I just used the github link.
I also fixed a small typo in illustrator-guide.md
Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

My apologies I accidently pushed my other PR to this branch


wiki: add description of write-protect feature

quick and dirty: https://github.com/larshp/abapGit/wiki/Write-protected-repository


Reduce the impact of large messages sent to unlocated or migrated chare array elements

Original issue: https://charm.cs.illinois.edu/redmine/issues/67

Currently, any message sent to a chare array element (the target) whose location is uncached or has migrated is reflected off the object's home PE. For large messages (size threshold unspecified), this is both wasteful of network bandwidth and potentially slower than just sending a few small messages around to determine the recipient PE where the target lives and then sending the large message there directly.
The direct solution to this performance issue is to transfer large messages directly from the sender to their ultimate destination. The portable implementation of that would be to buffer large messages in the location/array manager on the sending PE  until a message indicating the current location is received. Less portable solutions will be presented in another issue.
In the migration case (as opposed to uncached lookup), how does the sending PE know that the target object has moved before sending? There's probably a big gap here for all sorts of location management improvements.

Original date: 2013-03-02 00:23:50

On systems that transmit even large messages directly, e.g. net-*, the explicit latency is only improved by buffering when the transmission time of the message payload is greater than the cost of an additional HR: 2a + 2nb when reflecting off the home PE vs 3a + nb when buffering at the sender. The reduction in network utilization may justify always buffering all but the smallest messages, though.

Original date: 2013-05-06 13:40:42

As I work on this, I realize there's a potential problem with always buffering messages when one doesn't definiteively know where the recipient resides. In the case where the recipient is actually on the home PE, this strategy would add the latency of a full round-trip plus however long messages take to get through the queues (requesting current location from home PE, and waiting for the reply), and various additional processing.
Depending on the application, that could be the very common case, or the really rare case. In the mostly-on-home-PEs case, this problem would only occur early in execution, and fade away after locations are cached, but that makes this a real tradeoff and not an unequivocal win.

Original author: Ramprasad Venkataraman
Original date: 2013-05-06 16:26:30

Watch out for the massive upheaval of cklocation code that is happening on branch ramv/locmgr-cleanup. Any changes that involve locmgr or the msg delivery paths in arrmgr / locmgr are likely to have significant conflicts. One fix would be to merge early and often from the cleanup branch into master.

Original date: 2013-05-06 16:29:02

I'm not making this change yet due to the uncertainty in the tradeoff between optimizing for objects on their home PEs and objects residing elsewhere.
Regardless, though, the implementation would have a very narrow scope, limited entirely to CkLocMgr::deliverUnknown() I think.

Original date: 2013-06-04 02:03:49

Discussion in the core group suggested making this a runtime flag, so that impact can be easily tested and application developers and users can choose either way. It may as well take the payload size to use as a cutoff as an argument. The appropriate comparison is to the size of the message to request the recipient's location - messages within some delta of that should be sent directly.

Original date: 2013-07-01 23:50:15

Implemented on branch ramv/locmgr-cleanup. Adds a new runtime flag +messageBufferingThreshold that controls how large messages must be before they are buffered. Passes make test in tests/charm++ (after fixing an issue on that branch). Needs application correctness and performance testing.

Original date: 2013-08-28 19:26:38

Could grab the same implementation technique to mainline, since the location manager cleanup is somewhat stalled. However, it's not clear that there's an application use case for this that isn't better addressed by other mechanisms. Basically, we need a realistic benchmark that will actually show a benefit.

Original date: 2013-10-07 19:09:28

Someone else can identify a relevant usecase and port the code to mainline if it matters. Either way, I'm not going to the effort to port non-useful code over just for the release.

Original date: 2015-11-06 20:48:35

As noted, it has been implemented on Ram's location manager cleanup branch, on which the 64-bit ID work is built. Still not clear whether it's worthwhile/useful to anything real.

Original date: 2016-09-23 16:02:56

This was merged with the 64-bit ID work.


Align with new Microsoft.Extensions.ApiDescription.Client package

aspnet/AspNetCore#8487
NSwag.ApiDescription.Design -> NSwag.ApiDescription.Client

match newer Microsoft package and clear way for an NSwag.ApiDescription.Server package

@(CurrentServiceFileReference) -> @(CurrentOpenApiReference)
remove @(ServiceProjectReference) support; coming in NSwag.ApiDescription.Server package
use %(Options) metadata instead of %(GenerateNSwagCSharpOptions) and %(GenerateNSwagTypeScriptOptions)
use %(FirstForGenerator) metadata to avoid (some) compilation errors due to duplicate class definitions
use supported (LTS) runtime when executing dotnet-nswag.dll

@RicoSuter as discussed a few weeks ago…
I'll update this PR once the new package is available on NuGet. But, let's resolve any questions / issues up front.

@dougbu Looks good to me.

@RicoSuter this is ready to go. Preview 5 bits are now available on NuGet.org and I used the public version of the Microsoft.Extensions.ApiDescription.Client package while rebasing on your 'master' branch

v12.3.0


cmd/jv: flag parsing and usage fixes

Codecov Report
Patch coverage has no change and project coverage change: -0.23% :warning:

Comparison is base (bbc9f89) 89.21% compared to head (e0c304c) 88.98%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   89.21%   88.98%   -0.23%
==========================================
  Files          10       10
  Lines        2652     2652
==========================================
- Hits         2366     2360       -6
- Misses        237      241       +4
- Partials       49       51       +2

see 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Looks like this is half obsolete as of 6.0.1, reworked remainders in https://github.com/santhosh-tekuri/jsonschema/pull/177, closing here.


README does not specify XCode requirements

When using brew to install, I'm getting this error:
$ brew install lazydocker
==> Installing lazydocker from jesseduffield/lazydo
Error: Your Xcode (10.0) is too outdated.
Please update to Xcode 10.2.1 (or delete it).
Xcode can be updated from the App Store.

Error: Xcode alone is not sufficient on Mojave.
Install the Command Line Tools:
  xcode-select --install

OS: MacOS Mojave.
I have an XCode 10.0, and cannot delete it (using it for development), or upgrade it yet (company-managed software).
I would like to confirm if the above version is really needed by lazydocker before I badger our IT services about an upgrade 😃 .
If so, shouldn't it be in the README as well?

@john20xdoe
You can try this:
xcode-select --install
# mac will popup xcode install interface to confirm

brew install lazydocker

Hi @justintien , thanks for the reply. I haven't tried it with my XCode 10.0 since I found I already have XCode 10.2.1, but it was not named XCode.app.
I swapped their names in my Applications folder. 10.2.1 to XCode.app, while the 10.0 to XCode 10.0.
But I did run xcode-select --install after the rename, and brew install lazydocker is now working.


feat(docs): Nuke CLI from docs

removes CLI from docs
updates aztec-cli codegen -> aztec-compile codegen
removes everything from quickstart except setting up sandbox

blocked until aztec-builder is introduced

Docs Preview
Hey there! 👋 You can check your preview at https://6627a2bdacc40d15882726ac--aztec-docs-dev.netlify.app


Dataset recognition is not robust

When having dataset names with multiple underscores, Scaden will fail to read the single datasets correctly as it simply splits but underscores.
This has to be made more robust.

Fixed by new release v1.0.1

Fixed by new release v1.0.1


Property setter rules ignored

I am trying to limit so my health doesn't go below 0, this is what I've done so far.
    [SerializeField] private IntReactiveProperty health = new IntReactiveProperty(MaxHealth);
    public IntReactiveProperty Health
    {
        get => health;
        set
        {
            health = value;
            Debug.Log(value.Value);
            if (health.Value < 0)
            {
                health.Value = 0;
            }
        }
    }

    public void TakeDamage(int amount)
    {
        Health.Value -= amount;
        Debug.Log($"You took {amount} damage and has {Health} health left");
    }

It seems like the property is not used when using the Health.Value. Is there a simpler way to do this kind of logic or am I missing a crucial step here? As of now the health can still go below 0.

Hi,
The getter and setter sets the reactive property itself whereas the takeDamage fn sets the Value property of an existing reactive property.
Do something like this:
IntReactiveProperty HealthObservable = new IntReactiveProperty(0);
Public int Health {
Get => HeathObservable.Value;
Set {
If(value > 0)
HeatheObservable.Value = value;
}}
Simplest thing, you could also look at using commands to validate input.  Not an expert on that though.
Cheers
Jean-Marc

On Nov 23, 2019, at 4:14 AM, Robert Brunhage<EMAIL_ADDRESS>wrote:
I am trying to limit so my health doesn't go below 0, this is what I've done so far.
[SerializeField] private IntReactiveProperty health = new IntReactiveProperty(MaxHealth);
public IntReactiveProperty Health
{
    get => health;
    set
    {
        health = value;
        Debug.Log(value.Value);
        if (health.Value < 0)
        {
            health.Value = 0;
        }
    }
}

public void TakeDamage(int amount)
{
    Health.Value -= amount;
    Debug.Log($"You took {amount} damage and has {Health} health left");
}

It seems like the property is not used when using the Health.Value. Is there a simpler way to do this kind of logic or am I missing a crucial step here? As of now the health can still go below 0.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hello @jmprimeau, thanks for the answer!
The problem with that would be then my getter is of type int and I can't subscribe to it in another class.

Right but then you have two methodes.
Int Health { get; set; }
And
IReadOnlyRP HealthIObservable { get }
Use health to set and have it looking clean with no .Value everywhere.
But that’s basically it, you just always do
X prop {get; set;}
IRORP propObservable { get; }
Jean-Marc

On Nov 23, 2019, at 8:07 AM, Robert Brunhage<EMAIL_ADDRESS>wrote:
Hello @jmprimeau, thanks for the answer!
The problem with that would be then my getter is of type int and I can't subscribe to it in another class.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

But I can't set a ReadOnlyReactiveProperty, except in the initialization or am I missing something?
And I also want it to be Serializeable as I am using a scriptable object.

Correct, you would set this at construction time or at initialization.
Here is a sample from my project
`  public abstract class EffortBasedLevel where DEFINITION:IEffortBasedLeveledDefinition
{
public DEFINITION Definition { get; protected set; }
// straight accessor for Effort; supports get and set while hiding the observable implementation
// This is the field that would get serialized...
public long Effort { get => EffortObservable.Value; set => EffortObservable.Value = value; }
public ReactiveProperty EffortObservable { get; protected set; }
public long Level => LevelObservable.Value;
public IReadOnlyReactiveProperty LevelObservable { get; protected set; }
public static long LevelFromEffort(double currentEffort, double baseEffort, double researchEffortIncrease, long maxLevels) ...
public static long EffortFromLevel(int level, double baseEffort, double researchEffortIncrease) ...
public virtual void Initialize(DEFINITION definition)
{
  Definition = definition;
  EffortObservable = new ReactiveProperty<long>(0);
  LevelObservable = EffortObservable.Select(accumulatedEffort => LevelFromEffort(accumulatedEffort,Definition.BaseNextLevelEffort,Definition.NextLevelEffortIncrease, Definition.MaxLevels) ).ToReadOnlyReactiveProperty();
}

}`
So here, I'm doing basically what I described above.
I have effort and level; effort can be set through the Effort property and Level is derived from Effort.
Both have straight accessors and both have observables.
Now, to your point, the ReactiveProperties are set only once in the Initialize() method.
I haven't tackled serialization yet in this project, but I'm thinking that only the straight accessors will be marked as Serialized; the observable ones will have to come back from Initialize or the constructor.  Probably more from the ctor as the deserializer will probably need the objects to be initialized.
This is a simple example, but I'm doing this pattern at scale in this project and it seems to be working out.

I see your point and tried implementing it like the following. It works great but still don't really understand what you mean on the serialization part. Properties can't be serialized for the inspector or can they?
public IntReactiveProperty healthObservable { get; private set; } = new IntReactiveProperty(MaxHealth);
    public int Health
    {
        get => healthObservable.Value;
        set => healthObservable.Value = value;
    }

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在忙碌中，无法亲自回复您的邮件，之后将尽快给您回复。


Fix for: "EyeTrackingTarget not triggering OnLookAway when passing from collider with EyeTrackingTarget to collider without"

Overview
Fixes https://github.com/microsoft/MixedRealityToolkit-Unity/issues/10106
Changed assignmnet in accordance to variable documentation:
"GameObject eye gaze is currently targeting, updated once per frame. null if no object with collider is currently being looked at."
Previous behaviour only changed variable if gameobject that was hit had an EyeTrackingTarget attached, if no collider was hit it was set to null and if a collider was hit on a gameobject that did not have any eyetrackingtarget then it was not updated.
Documentation specifies it should be the "GameObject eye gaze is currently targeting", and not anything relating to if it has eyetrackingtarget or not. Not sure if intention is/was for it to be null if the gameobject does not have eyetrackingtarget, but then documentation as well as code should be updated for this.
Changes
Added on line 264 of EyeTrackingTarget.cs
 LookedAtTarget = hitInfo.collider.transform.gameObject;
Removed from line 264 of EyeTrackingTarget.cs
if(LookedAtEyeTarget != null)
{
    LookedAtTarget = LookedAtEyeTarget.gameObject;
}

/azp run

this is not fixed in 2.8.3


Restart kubelet on update in deployment-type host on update

Restart kubelet if the binary on the host is changed, see #1714

Nevermind, notify is still there, mobile diff is just cropped.

ci check this

I can say this isn't the best approach, but it definitely achieves what you want. I'll open a new issue to move this task to downloads role. We should approach this issue in stages (along with other files we copy out of containers):

pull container
sync it over to other hosts as necessary
copy file out of container to release/download dir
copy file to its proper location

The actual process should be repeatable and set as a role dependency. Let's merge your PR after it passes CI.

@mattymo As said in the original issue, I'm open to discuss the best approach to this. Can't say I'm profound in the bigger design goals, I'd glady take advice. I just tried to achieve the goal with minimum changes because nobody replied to the original issue.
Since I dorked up anyway with trailing spaces, I'll update the PR tomorrow when back at work and include your review.


Engine from default provider cannot be stopped because stopSig is never initialized

Hello,
Great library !
One small note if I may: In my opinion the internal/engine/provider.go file needs an extra line around line 33
from:
	e := &Engine{
		op:           op,
		bot:          bot,
		dir:          dir,
		monitors:     list.New(),
		userMonitors: make(map[string]*list.Element),
	}

to:
	e := &Engine{
		op:           op,
		bot:          bot,
		dir:          dir,
		monitors:     list.New(),
		userMonitors: make(map[string]*list.Element),
		stopSig:      make(chan bool),
	}

Otherwise the uninitialized channel blocks forever and calling Stop on the Engine will never reach the code to trigger e.stop = true in the Run method
	for !e.stop {
		select {
		case <-e.stopSig:
			e.stop = true

My regards again, and all the best,
Silviu

Thank you for reporting!


Defender update

Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Renames ASC to Microsoft Defender for Cloud
Renames Azure Sentinel to Microsoft Sentinel
Separate initiative for Gov deployment for Microsoft Defender for Cloud

Hey @krnese,
Are you planning to do the same for Mooncake in this PR to fix #867 also ?
cc: @faister


Add support for ASP.NET Razor to languages

Razor views mix HTML with a specialised C# or VB.NET style syntax.
This would need two languages to be supported:

cshtml
vbhtml

Would be very useful for .NET FE projects

This has been around for a while now... is there any solution yet?

Hi! any plans to fix this soon?

Either the coming of razor pages and blazor this is getting more important

We are happy to accept PRs for new language definitions! Let us know if you have any questions about the documentation.


Fix API change and block inconsistent version v0.107.14

v0.107.14 of adguardhome introduces an inconsistency in the API that is fixed in v0.107.15.
This PR fixes the API change from string to json payload in the '/filtering/set_rules' POST method.
It remains backward compatible with older versions.
v0.107.14 seem so have an inconsistent check in the API and can not be uses with adguardhome-sync therefore the version is blocked ad replica targets.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 18 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 60.779%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
733

Relevant Lines:
1206

💛  - Coveralls


MT: secure graphite endpoint

as of #176 we have a very basic graphite endpoint, without search/autocomplete, wildcards, functions.
goals are 1) support direct testing of a specific instance 2) move over alerting queries cause they don't  use fancy graphite logic and 3) long term use it directly as a graphite replacement.
we should make sure tenants are only capable of seeing the data they have access to. we could do a simple org-id check like graphite-raintank does. it's just that it's clunky to use since our grafana fork (and the litmus app presumably) just has 1 hardcoded raintank datasource, and when you add the new datasource as a graphite datasource it won't set the right header..or maybe we can add it as a built-in datasource as well ("raintank-beta") or something, that way we can make sure it sets the header
@woodsaj am i thinking along the right lines or am i way off?

users should not ever be hitting metric-tank directly.  They need to go via a proxy which can handle the authentication and routing to one of many metric-tank instances.  As we move to grafana.net this will look something like
https://github.com/raintank/raintank-apps/tree/master/tsdb
as for the new graphite endpoint add in https://github.com/raintank/raintank-metric/pull/176, it will not work as it is not multi-tenant.  You are indexing the metricDefs by the Name field, but this name field is only unique to 1 user.

closing this ticket since the question was answered and there's tickets for everything else


Post-Publication Tasks

[ ] Update GitHub citation file with formal publication
[ ] Commit the citation file as a tagged 'release' of the repository
[x] update readme link to publication DOI
[ ] update OSF project wiki
[x] update OSF preprint metadata with publication DOI
[ ] create blog post

@Peter-Kedron I think the majority of content in the OSF project wiki https://osf.io/5yeq8/wiki/home/ for this is outdated. We should probably replace with the Annals citation and a link to the shiny app component.


Cannot set headers after they are sent to the client - ^ 4.3.0

Describe the bug
Error on server middleware (server.use(nextI18NextMiddleware(nextI18next))) when res.writeHead({ Location: "/" }) from _app.tsx happen in version  4.3.0 (next-i18next) but works fine in 4.2.0 (next-i18next)
Occurs in next-i18next version
next-i18next - 4.3.0
yarn - 1.22.4
Steps to reproduce
Basic setup and add res.writeHead(302, { Location: "/" }); in _app.jsx
Screenshot

Expected behaviour
Should work normally like in version  4.3.0 (next-i18next)
OS (please complete the following information)

Device: MBP 2019 16
Browser: Chrome  81.0.4044.138

Please provide a reproducible repo.

Maybe related: https://github.com/i18next/i18next-http-middleware/pull/4#issuecomment-627270885

I'm sorry, i just noticed i give you the wrong version. The issue was happening on version  "next-i18next": "^4.3.0".
With 4.4.2, all works fine i just have a message "no possibility found to set header"

no possibility found to set header is quite annoying, especially given that it is printed unconditionally, both in dev and prod 🤔 @cfaure004, did you manage to find the workaround or the root cause?

@kachkaev This is a different issue... The log comes from here: https://github.com/i18next/i18next-http-middleware/blob/master/lib/httpFunctions.js
PRs are welcome

Ahh you mean the second time... when the header is already sent...?
Will probably change the logic to return in that case

@kachkaev should be better with<EMAIL_ADDRESS>

Many thanks for releasing the new version @adrai! I can confirm that I no longer see log statements with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>🎉

This must be somewhere in next-i18next or in userland... 🤷♂
any help is welcome

We'll need @cfaure004 to provide a reproducible example.

About what ? The message "no possibility found to set header" ?
This initial issue is not happening on latest version.

I think we can close this issue.

Can you create an example with the old version which reproduces the error?
This would be very helpful to investigate the root cause.

Ok no problem, i'll do that

👍 make sure you use i18next-http-middleware <= 1.0.6

On my side, i've always used middleware included in next-18next package
const next = require('next') const nextI18NextMiddleware = require('next-i18next/middleware').default

I've been able to reproduced the message "no possibility found to set header" but not to reproduce the initial error
https://github.com/cfaure004/next-i18next-issues-716

Finally i've been able to reproduce the initial issue using<EMAIL_ADDRESS>all is in my repo 👍

On my side, i've always used middleware included in next-i18next package

Yes, that's what you should be doing. We need a repro of that, not using i18next-http-middleware/cjs directly.

thx @cfaure004 I found somethig... it's caused by the redirect... here: https://github.com/cfaure004/next-i18next-issues-716/blob/master/pages/_app.jsx#L48
which seems correct (I'm not a nextjs expert)...
I also found in i18next-http-middleware that certain header values can be set twice (because of the languageChanged event), so I tried to optimize this with<EMAIL_ADDRESS>

On my side, i've always used middleware included in next-i18next package

Yes, that's what you should be doing. We need a repro of that, not using i18next-http-middleware/cjs directly.

@isaachinman  I have not been able to reproduce the issue using previous versions of next-i18next library, i think it was an outdated dependency. I just created this exemple to help @adrai to identify where does the issue was coming from.
Great @adrai !


U-Boot updates

Oh, someone would have to push tiboot3.bin updates to resolve the boot warning since TF-A 2.5.

Oh, someone would have to push tiboot3.bin updates to resolve the boot warning since TF-A 2.5.

Pushed to master...
Protection Rule added


Build MGTANet on the TransFusion-L.

Hi, MGTANet is an excellent work. I found that MGTANet utilized the CenterHead on the nuScenes, so I want to try to replace the CenterHead of  MGTANet with TransFusion-L head, did you try it? I think the performance will be better.

Hi, did you conduct experiments on MGTANet and the TransFusion-L head?


⚠ Mobitopup has degraded performance

In 78b42bc, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 5503 ms

Resolved: Mobitopup performance has improved in c6b5c71.


Not working anymore

Hello, BetterDiscord was doing fine before the last update. Now it doesn't even show. I tried to reinstall Discord + BetterDiscord not working, tried the last index.js, same.
The installation of BetterDiscord is fine everything is ok, no errors.
But in Discord its like i have not BetterDiscord.
Thanks !
ps : i don't know if there is a log that i can give you

Unable to reproduce.
Try running discord from console: cmd /K  "%localappdata%\Discord\app-0.0.280\Discord.exe"
and see if it loads at all.

Not launching with the command.

Not launching with the command.

Try manually deleting the app folder from %localappdata%\Discord\app-0.0.280\resources
and BetterDiscord folder from %localappdata%\Discord\app-0.0.280\resources\node_modules
and run the latest installer again.

Seems to be working :)
Thanks !

Awesome :)


Refactor: Minor code style improvements

I have revised the variable assignment style and removed redundant code.

As every PR requires CI testing, we discourage submitting PRs to fix one typo, one warning, etc. We recommend fixing the same issue at the file level at least (e.g., fix all typos in a file, fix all compiler warnings in a file, etc.)

I have read the above, but I wasn't sure if it applied to my case, so I submitted the PR for now. If this PR falls under the kind that should be avoided, I will close it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How can we avoid stylis used as a transitive dependency?

Hi, we are using styled-components in a project we are using, but we are getting some problems when transpiling out project. Basically we are creating a component to be used in another project and for this to work on IE11 we must transpile using ES5. However, for some reason, we get a problem with our transpiled code:
var cursorptn = /zoo|gra/
var transformptn = /([,: ])(transform)/g

Has been transpiled into
var cursorptn = /zoo|gra/var transformptn = /([,: ])(transform)/g

Which gives us a javascript error.
We see that this code comes from stylis and for some obscure reason the ES5 transpiler cant handle the lack of semicolon / lack of /g at the end of regex.
Now, we see that in node_modules/styled-components/dist/styled-components.js stylis is shipped with semicolons, and would therefore solve the problem nicely, but it seems that the distribution of styled components is not used, instead the code from stylus is being used.
Our package.json looks like this:
...
  "dependencies": {
    ...
    "styled-components": "^3.3.2"
  },
...

And our package-lock.json looks like this:
    "styled-components": {
      "version": "3.3.2",
      ....
      "requires": {
        ...
        "stylis": "^3.5.0",
        "stylis-rule-sheet": "^0.0.10",
        "supports-color": "^3.2.3"
      },
....
    },
    "stylis": {
      "version": "3.5.0",
      "resolved": "https://registry.npmjs.org/stylis/-/stylis-3.5.0.tgz",
      ...
    },
    "stylis-rule-sheet": {
      "version": "0.0.10",
      "resolved": "https://registry.npmjs.org/stylis-rule-sheet/-/stylis-rule-sheet-0.0.10.tgz",
      ...
    },

I can´t understand why, when we use styled-components, instead of using it´s own dist styled-components uses the stylis code, can anyone offer some help?

@richardborge You don't need to transpile styled-components or its dependencies. It's already transpiled to working ES5 code.


Fix: issue #98 restyle close button + close animation

#98

Close button isn't accessible from a keyboard. Please make it focusable and focus it when panel is opened

@Guria Pls check PR.

Yes, my fault. Fixed.


Is this project still maintained?

Codebase looks really interesting and I was looking to extend it little bit. Created license in #97

Hey @wtrocki, thanks for reaching out.
We are not actively maintaining this project currently, as we have all moved to different stages in our professional careers. We certainly welcome any improvements that you'd like to add, and will review/merge any Pull Requests that you open to that end. This project was intended to be an open-source improvement on other libraries, so we are happy to merge your code and collaborate.
Cheers!

@fairlycasual I have forked project to graphql-heroes and going to improve it there while still trying to push things back to your repo.
I'm at the phase of exploring the cache and checking internal architecture to check how I can adjust that for general needs etc. Applying Apache License opens door for contributions so thank you for that.

Shameless plug: In case you're looking for a dedicated GraphQL caching solution, you may wanna have a look at https://graphcdn.io
I'm building that right now because there's no proper caching solution in the ecosystem.

Shameless plug: In case you're looking for a dedicated GraphQL caching solution, you may wanna have a look at https://graphcdn.io
I'm building that right now because there's no proper caching solution in the ecosystem.

Hi @timsuchanek
Worth to check some existing projects for inspiration:
Apollo Server has CDN cache and persistent queries.
Wundergraph does have it as well.
Most of those come with some tradeoffs - if you looking to get some real use cases for CDN cache ping me

Hi @timsuchanek
Worth to check some existing projects for inspiration:
Apollo Server has CDN cache and persistent queries.
Wundergraph does have it as well.
Most of those come with some tradeoffs - if you looking to get some real use cases for CDN cache ping me

Thanks @wtrocki I'm aware of what Apollo Server has built-in and also Wundergraph.
Both don't really focus on caching though (it's just one of many features), are not that powerful, and harder to set up.
Awesome, will ping you!

Thanks @wtrocki I'm aware of what Apollo Server has built-in and also Wundergraph.
Both don't really focus on caching though (it's just one of many features), are not that powerful, and harder to set up.
Awesome, will ping you!


Screenshots not actual

The screenshots and steps used in this article are not up to date with the lsatest changes introduced in the Azure Portal.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25ec88c2-d5ff-e727-cbe1-69bac94141ae
Version Independent ID: 0b6d31a9-7767-73cb-857b-ad8aa81cdce5
Content: Manage App Service plan - Azure
Content Source: articles/app-service/app-service-plan-manage.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

what is the timeframe for resolution? I need to know how to switch the App Service Plan from Standard to Free pricing. The option within the interface appears to be missing, and the only section that shows the pricing tier (Properties) doesn't let you change it.  If someone can quickly just tell me how to change it I'd appreciate it!

@lordneeko are you following this doc: https://docs.microsoft.com/en-us/azure/app-service/manage-scale-up? The screenshots there are updated and you should be able to change the pricing tier. There's a link in this doc to go there as well.

ah! thanks!

@ratocego Sorry for the delay. I've made the update to the steps in the doc and the screenshots. It should be published sometime today. #please-close


'redirect_uri' cant be changed

Hi,
i changed the redirect_uri to what i have set in my instagram developer site, but it always starts with the original address:
python sample_app.py
Bottle v0.12.7 server starting up (using WSGIRefServer())...
Listening on http://localhost:8515/
Hit Ctrl-C to quit.
edit:
it requires a manually change the following lines:

@route('/oauth_callback')
run(host='localhost', port=8515, reloader=True)

is there a reason why this info is not extracted from the CONFIG?
Thanks,
Gerald

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

took you some time to reply :)


Longhorn volumes detached after node reboot

Rancher 2.1.5
K8n: v1.11.6
Host: Ubuntu 16.04.5 LTS
Docker: 17.03.3-ce, build e19b718
Deployment:
~ $ kubectl describe deployment www-example-com-joomla-joomla -n www-example-com
Name:                   www-example-com-joomla-joomla
Namespace:              www-example-com
CreationTimestamp:      Sat, 19 Jan 2019 10:42:11 +0100
Labels:                 app=www-example-com-joomla-joomla
                        chart=joomla-4.0.3
                        heritage=Tiller
                        io.cattle.field/appId=www-example-com-joomla
                        release=www-example-com-joomla
Annotations:            deployment.kubernetes.io/revision: 3
                        field.cattle.io/publicEndpoints:
                          [{"addresses":["<IP_ADDRESS>"],"port":32202,"protocol":"TCP","serviceName":"www-example-com:www-example-com-joomla-joomla","allNodes":true},{"addresses...
Selector:               app=www-example-com-joomla-joomla,release=www-example-com-joomla
Replicas:               1 desired | 1 updated | 1 total | 0 available | 1 unavailable
StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  25% max unavailable, 0 max surge
Pod Template:
  Labels:       app=www-example-com-joomla-joomla
                chart=joomla-4.0.3
                release=www-example-com-joomla
  Annotations:  cattle.io/timestamp: 2019-01-19T10:46:59Z
                field.cattle.io/ports:
                  [[{"containerPort":80,"dnsName":"www-example-com-joomla-joomla-","name":"http","protocol":"TCP","sourcePort":0},{"containerPort":443,"dnsName":...
  Containers:
   www-example-com-joomla-joomla:
    Image:       docker.io/bitnami/joomla:3.9.2
    Ports:       80/TCP, 443/TCP
    Host Ports:  0/TCP, 0/TCP
    Requests:
      cpu:     300m
      memory:  512Mi
    Environment:
      ALLOW_EMPTY_PASSWORD:      yes
      JOOMLA_DATABASE_NAME:      bitnami_joomla
      JOOMLA_DATABASE_USER:      bn_joomla
      JOOMLA_EMAIL<EMAIL_ADDRESS>      JOOMLA_USERNAME:           admin
      MARIADB_HOST:              www-example-com-joomla-mariadb
      MARIADB_PORT_NUMBER:       3306
      JOOMLA_DATABASE_PASSWORD:  <set to the key 'mariadb-password' in secret 'www-example-com-joomla-mariadb'>  Optional: false
      JOOMLA_PASSWORD:           <set to the key 'joomla-password' in secret 'www-example-com-joomla-joomla'>    Optional: false
    Mounts:
      /bitnami/apache from apache-data (rw)
      /bitnami/joomla from joomla-data (rw)
  Volumes:
   joomla-data:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  www-example-com-joomla-joomla-joomla
    ReadOnly:   false
   apache-data:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  www-example-com-joomla-joomla-apache
    ReadOnly:   false
Conditions:
  Type           Status  Reason
  ----           ------  ------
  Available      True    MinimumReplicasAvailable
  Progressing    True    NewReplicaSetAvailable
OldReplicaSets:  www-example-com-joomla-joomla-8695c9779d (1/1 replicas created)
NewReplicaSet:   <none>
Events:          <none>

Pod:
~ $ kubectl describe pod www-example-com-joomla-joomla-8695c9779d-hw49c -n www-example-com
Name:               www-example-com-joomla-joomla-8695c9779d-hw49c
Namespace:          www-example-com
Priority:           0
PriorityClassName:  <none>
Node:               cl1-node-1/<IP_ADDRESS>
Start Time:         Sat, 19 Jan 2019 11:49:33 +0100
Labels:             app=www-example-com-joomla-joomla
                    chart=joomla-4.0.3
                    pod-template-hash=4251753358
                    release=www-example-com-joomla
Annotations:        cattle.io/timestamp: 2019-01-19T10:46:59Z
                    cni.projectcalico.org/podIP: <IP_ADDRESS>/32
                    field.cattle.io/ports:
                      [[{"containerPort":80,"dnsName":"www-example-com-joomla-joomla-","name":"http","protocol":"TCP","sourcePort":0},{"containerPort":443,"dnsName":...
Status:             Running
IP:
Controlled By:      ReplicaSet/www-example-com-joomla-joomla-8695c9779d
Containers:
  www-example-com-joomla-joomla:
    Container ID:   docker://7fec2c8f75c4e6a7fc5aecbe72e4f72f7063385cc2ba4f5398f530bb0cf47b51
    Image:          docker.io/bitnami/joomla:3.9.2
    Image ID:       docker-pullable://bitnami/joomla@sha256:956f7aa312630912ce59c191ad0ff46e3954bbdb050cd67d75feb380195d6846
    Ports:          80/TCP, 443/TCP
    Host Ports:     0/TCP, 0/TCP
    State:          Terminated
      Reason:       Completed
      Exit Code:    0
      Started:      Sat, 19 Jan 2019 11:51:38 +0100
      Finished:     Tue, 22 Jan 2019 20:22:03 +0100
    Ready:          False
    Restart Count:  0
    Requests:
      cpu:     300m
      memory:  512Mi
    Environment:
      ALLOW_EMPTY_PASSWORD:      yes
      JOOMLA_DATABASE_NAME:      bitnami_joomla
      JOOMLA_DATABASE_USER:      bn_joomla
      JOOMLA_EMAIL<EMAIL_ADDRESS>      JOOMLA_USERNAME:           admin
      MARIADB_HOST:              www-example-com-joomla-mariadb
      MARIADB_PORT_NUMBER:       3306
      JOOMLA_DATABASE_PASSWORD:  <set to the key 'mariadb-password' in secret 'www-example-com-joomla-mariadb'>  Optional: false
      JOOMLA_PASSWORD:           <set to the key 'joomla-password' in secret 'www-example-com-joomla-joomla'>    Optional: false
    Mounts:
      /bitnami/apache from apache-data (rw)
      /bitnami/joomla from joomla-data (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-mfb5d (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  joomla-data:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  www-example-com-joomla-joomla-joomla
    ReadOnly:   false
  apache-data:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  www-example-com-joomla-joomla-apache
    ReadOnly:   false
  default-token-mfb5d:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-mfb5d
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason       Age                 From                 Message
  ----     ------       ----                ----                 -------
  Warning  FailedMount  20m (x11 over 27m)  kubelet, cl1-node-1  MountVolume.SetUp failed for volume "pvc-7ebd02851bce11e9" : rpc error: code = Internal desc = exit status 1
  Warning  FailedMount  20m (x11 over 27m)  kubelet, cl1-node-1  MountVolume.SetUp failed for volume "pvc-7eb60f6d1bce11e9" : rpc error: code = Internal desc = exit status 1
  Warning  FailedMount  48s (x13 over 25m)  kubelet, cl1-node-1  Unable to mount volumes for pod "www-example-com-joomla-joomla-8695c9779d-hw49c_www-example-com(e8056c70-1bd7-11e9-b009-000c2958f9e1)": timeout expired waiting for volumes to attach or mount for pod "www-example-com"/"www-example-com-joomla-joomla-8695c9779d-hw49c". list of unmounted volumes=[joomla-data apache-data]. list of unattached volumes=[joomla-data apache-data default-token-mfb5d]

YAML:
apiVersion: v1
kind: Pod
metadata:
  annotations:
    cattle.io/timestamp: 2019-01-19T10:46:59Z
    cni.projectcalico.org/podIP: <IP_ADDRESS>/32
    field.cattle.io/ports: '[[{"containerPort":80,"dnsName":"www-example-com-joomla-joomla-","name":"http","protocol":"TCP","sourcePort":0},{"containerPort":443,"dnsName":"www-example-com-joomla-joomla-","name":"https","protocol":"TCP","sourcePort":0}]]'
  creationTimestamp: 2019-01-19T10:49:33Z
  generateName: www-example-com-joomla-joomla-8695c9779d-
  labels:
    app: www-example-com-joomla-joomla
    chart: joomla-4.0.3
    pod-template-hash: "4251753358"
    release: www-example-com-joomla
  name: www-example-com-joomla-joomla-8695c9779d-hw49c
  namespace: www-example-com
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: ReplicaSet
    name: www-example-com-joomla-joomla-8695c9779d
    uid: 8c62bfea-1bd7-11e9-b009-000c2958f9e1
  resourceVersion: "4084953"
  selfLink: /api/v1/namespaces/www-example-com/pods/www-example-com-joomla-joomla-8695c9779d-hw49c
  uid: e8056c70-1bd7-11e9-b009-000c2958f9e1
spec:
  containers:
  - env:
    - name: ALLOW_EMPTY_PASSWORD
      value: "yes"
    - name: JOOMLA_DATABASE_NAME
      value: bitnami_joomla
    - name: JOOMLA_DATABASE_USER
      value: bn_joomla
    - name: JOOMLA_EMAIL
      value<EMAIL_ADDRESS>    - name: JOOMLA_USERNAME
      value: admin
    - name: MARIADB_HOST
      value: www-example-com-joomla-mariadb
    - name: MARIADB_PORT_NUMBER
      value: "3306"
    - name: JOOMLA_DATABASE_PASSWORD
      valueFrom:
        secretKeyRef:
          key: mariadb-password
          name: www-example-com-joomla-mariadb
          optional: false
    - name: JOOMLA_PASSWORD
      valueFrom:
        secretKeyRef:
          key: joomla-password
          name: www-example-com-joomla-joomla
          optional: false
    image: docker.io/bitnami/joomla:3.9.2
    imagePullPolicy: IfNotPresent
    name: www-example-com-joomla-joomla
    ports:
    - containerPort: 80
      name: http
      protocol: TCP
    - containerPort: 443
      name: https
      protocol: TCP
    resources:
      requests:
        cpu: 300m
        memory: 512Mi
    securityContext:
      capabilities: {}
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /bitnami/joomla
      name: joomla-data
    - mountPath: /bitnami/apache
      name: apache-data
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: default-token-mfb5d
      readOnly: true
  dnsPolicy: ClusterFirst
  hostAliases:
  - hostnames:
    - status.localhost
    ip: <IP_ADDRESS>
  nodeName: cl1-node-1
  priority: 0
  restartPolicy: Always
  schedulerName: default-scheduler
  securityContext: {}
  serviceAccount: default
  serviceAccountName: default
  terminationGracePeriodSeconds: 30
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300
  volumes:
  - name: joomla-data
    persistentVolumeClaim:
      claimName: www-example-com-joomla-joomla-joomla
  - name: apache-data
    persistentVolumeClaim:
      claimName: www-example-com-joomla-joomla-apache
  - name: default-token-mfb5d
    secret:
      defaultMode: 420
      secretName: default-token-mfb5d
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: 2019-01-19T10:49:33Z
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: 2019-01-22T19:23:22Z
    message: 'containers with unready status: [www-example-com-joomla-joomla]'
    reason: ContainersNotReady
    status: "False"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: null
    message: 'containers with unready status: [www-example-com-joomla-joomla]'
    reason: ContainersNotReady
    status: "False"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: 2019-01-19T10:49:33Z
    status: "True"
    type: PodScheduled
  containerStatuses:
  - containerID: docker://7fec2c8f75c4e6a7fc5aecbe72e4f72f7063385cc2ba4f5398f530bb0cf47b51
    image: bitnami/joomla:3.9.2
    imageID: docker-pullable://bitnami/joomla@sha256:956f7aa312630912ce59c191ad0ff46e3954bbdb050cd67d75feb380195d6846
    lastState: {}
    name: www-example-com-joomla-joomla
    ready: false
    restartCount: 0
    state:
      terminated:
        containerID: docker://7fec2c8f75c4e6a7fc5aecbe72e4f72f7063385cc2ba4f5398f530bb0cf47b51
        exitCode: 0
        finishedAt: 2019-01-22T19:22:03Z
        reason: Completed
        startedAt: 2019-01-19T10:51:38Z
  hostIP: <IP_ADDRESS>
  phase: Running
  qosClass: Burstable
  startTime: 2019-01-19T10:49:33Z

Manager Log:
https://gist.github.com/dnauck/79be754c5983487a20aed99d76df4a0f

Sometimes yes ... but sometimes the "detach" status is infinitely and you need to reboot the node where it hangs.

@dnauck How many worker nodes in the cluster? It seems the log is only from one manager.
I saw the manager detected the reboot of pvc-7f1b88ff1bce11e9 on node cl1-node-1 detected. It seems there are three other volumes reboot with the node, but no reboot detection shown in this manager's log. Is there more than more node? If that's the case, I would need the logs from other managers as well.

Hey @yasker,
yes there're 3 worker nodes, but only this node was rebooted.
The reboot was 13 days ago, i don't think the logs are available anymore.

Cannot reproduce at the moment. Added some precautious log in the v0.4, and let's wait and see...

I had the same Issue Today with:
Rancher: 2.2.5
Longhorn: 0.5
On a Single Node RKE (0.2.5) Cluster with Kubernetes 1.15.0
After an update of Docker to Version 18.9.8 and a reboot of all containers, longhorn was not able to attach the discs to the workload container.
After scale down to 0 and rescale to 1 of the container the discs could be attached again.
Hopefully this will be fixed.

We had also trouble at mounting the pvc to a pod.
Event of the pod:
MountVolume.SetUp failed for volume "pvc-0135e5d7-ae18-11e9-9f9e-005056a722c2" : rpc error: code = Internal desc = exit status 1
This was issued by the multipathd. The solution was to add a blacklist of the vendor "IET" at the /etc/multipath.conf and reload the daemon.
multipath.conf - add:
blacklist {         device {                 vendor "IET"         } }
Environment: physical Server with SAN attached Volumes
K8s: v1.13.5
Rancher: v2.2.4
Longhorn: 0.50
CentOS: 7.6

Same issue., perfectly reproducible
Rancher 2.2.7, Longhorn 0.5
2 nodes , 3 volumes. Stop docker on one node , wait until rebuilding finished and all volumes are healthy.  The start docker again.
During this some volumes get detached and don't automatically reattach. What always helps is attaching them manually.
Event below.
Great fan of Rancher and Longhorn, keep up the good work !
Chris
2019-08-16T19:39:24Z
2019-08-16T19:39:24Z
1
pvc-6f00b60a-c03a-11e9-84d2-005056be2537
Volume
Normal
Detached
longhorn-volume-controller	volume pvc-6f00b60a-c03a-11e9-84d2-005056be2537 has been detached
2019-08-16T19:39:22Z
2019-08-16T19:39:22Z
1
pvc-e7f942c5-c017-11e9-84d2-005056be2537
Volume
Normal
Detached
longhorn-volume-controller	volume pvc-e7f942c5-c017-11e9-84d2-005056be2537 has been detached
2019-08-16T19:39:17Z
2019-08-16T19:39:11Z
2
pvc-6f00b60a-c03a-11e9-84d2-005056be2537
Volume
Warning
Faulted
longhorn-volume-controller	Engine of volume pvc-6f00b60a-c03a-11e9-84d2-005056be2537 dead unexpectedly, detach the volume
2019-08-16T19:39:17Z
2019-08-16T19:39:11Z
2
pvc-e7f942c5-c017-11e9-84d2-005056be2537
Volume
Warning
Faulted
longhorn-volume-controller	Engine of volume pvc-e7f942c5-c017-11e9-84d2-005056be2537 dead unexpectedly, detach the volume
2019-08-16T19:38:37Z
2019-08-16T13:00:34Z
9
pvc-e7d8ca41-c017-11e9-84d2-005056be2537
Volume
Normal
Healthy
longhorn-volume-controller	volume pvc-e7d8ca41-c017-11e9-84d2-005056be2537 became healthy

@chrisbulgaria Thanks for reporting.
Longhorn will automatically attach the volume if the node reboot happened, but it depends on Kubernetes node bootID to tell if the reboot happened or not. Restart the docker daemon doesn't trigger the change of Kubernetes node ID so Longhorn cannot decide why the engine was suddenly crashed thus it keeps it there as detached.
The volume will become faulted if all of its replicas are unexpectedly disconnected since Longhorn won't be able to serve the user then. Then the salvage option will show up for the user to manually recover the volume.
Since it's not normal to have all the replica or engine disconnected, some steps may be taken to troubleshooting the issue, we decide not to automatically recover from it unless we know what caused it, e.g. the node reboots. Seems many reports regarding upgrade/reboot of Docker, which is not what we currently have in scope. Probably worth starting another issue for the scenario.


Refactor

Working package that can be imported into webpack 5 app.  see https://github.com/arkavo-org/client-web/pkgs/npm/client

What is the goal here? Getting rid of the monorepo?


Speech bubble styles applied to wrong pieces of text

Reported by Lilian on the forums.
See here recording of the bug here: https://york.cloud.panopto.eu/Panopto/Pages/Viewer.aspx?id=2212fd24-b513-43f2-8144-b1930092e342
When applying a speech bubble style to a piece of text in a text field, if there are other text fields shown in the editor, the style is applied to text in the final text field and not the one you are editing. Any other styles (panels, highlights etc.) are applied correctly

This is a really odd one. @ronm123 - I think it was you who first added the speech bubble styles, any ideas where to start with working out what's going on? I'm assuming this bug must be new as I imagine it would have come up before if not.

@FayCross yes this is very odd indeed! I was offline earlier when I saw your message so couldn't test but I've been testing now and went through a few things...
At first I wondered if it was specific to the newer page/project intro functionality because that obviously didn't exist in some earlier versions but it's not that.
We obviously don't have too many page types that display multiple text editor boxes at the same but we've had orientation and summary page types for years and it happens on them too!
So using the orientation page as a test case I tested with 3.9, 3.10 and 3.12 and the same thing happens with all of them!
I could understand if it happened in 3.12 but not say 3.9 or 3.10 but it happens in all of those versions and that just raises the question how has this not cropped up before?
I did initially add the speech bubble styles but I think it was @JohnSmith-LT who got that working in CKE. The styles still work correctly if added via source view e.g.

speech text here

so I'm guessing it's the script involved in identifying what is selected that is going wrong now and I wonder if that is perhaps written in a way that worked fine previously but has been impacted by browser compatibility or something like that otherwise how have we not noticed it before. Possibly style-wrap or the script that adds that?
I'll reply to the forum thread with a suggested workaround for now.

Yes, I tested with orientation page too. I think there's a chance it's always been there and we just haven't had it reported to us or tried it ourselves. We probably should upgrade to CKEditor 5...


docs: new website

Codecov Report

Merging #461 (38af026) into master (1e4aa15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   50.75%   50.75%
=======================================
  Files          15       15
  Lines         532      532
  Branches      124      124
=======================================
  Hits          270      270
  Misses        190      190
  Partials       72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4aa15...38af026. Read the comment docs.


Use email input type on the email field of the job submission form

I think we should validate each field like email should contain a valid email other than any string , company url must be a url etc

Most of the fields are already validated using HTML5 input types. In particular, the e-mail field has no validation. This should be changed. I will need to review the others.
I will update this issue accordingly.

Hello there, I have submitted a pull request regarding this issue. Please verify the changes. Thanks :)


Debug: show statement that is stopped

Here is how a stopped line looks like:

Compared to devtools:

It really helps me to see at what part of the line the debugger is currently at.

Especially useful when we break inline:

We can do this, we just decided to only show the inline decoration when the stop is on the same line as the previous stop.
Assigning to this milestone to investigate this week

I just tried this out to always show this decoration and I really like it. However I prefer to push start of debt week to have a whole milestone to gather feedback

Pushed this. Let me know your thoughts.

I see how this can be useful in languages that actually support stepping throw multiple statements on a single line.
In languages that don't, though, this is unnecessary and distracting. I do most of my debugging in C++ these days, and now the lines of source code wiggle right and left as I step through them, for no benefit. This is quite annoying. The current statement indicator in the gutter on the left is totally sufficient for such languages.
I would like to be able to turn this off (ideally per language). Or better yet, it should be off automatically for C++. (I don't see breakpoints in the middle of a line either in C++, which is good.)

Please try vscode insiders from today, it should be better. Though this build might not yet be out since we froze it for another reason. Anyways next build should be better.
We now only render this when the language provides a column > 1. C++ probably provides column = 1

I am using today's insiders (30dcb112b4), I was hoping that 6a1404a6f80e3 would fix this.
It doesn't though, the column is usually > 1 in C++. It does actually put the indicator at the beginning of statements (e.g. after the opening ( of an if statement). It's still useless though, as it's not possible to break on different columns of a line.

Ok thanks. So it seems like the C++ debugger sends the correct column even though it does not support stepping on mulitple statements on a line.
@weinand @connor4312 let me know you think here. I see two options:

We go back to previous approach
We introduce a capability for this (debugger supports step into column or something)

I guess 1) is the easiest solution

Actually I take that back. It turns out that it is actually possible to get the indicator to show up at different positions in a line, for example with chained function calls, and using combinations of Step Into and Step Out to move through the chain. In this situation the indicator could actually be useful to show you where you are. I suppose I'll try a bit longer to get used to the wiggling.

@stefanhaller previously we had heuristic to only show the indicator when the previous step location is the same as the current one (which means that you stepped and remained on the ine)

Ah, I see. But that means that you don't get the indicator in this one, somewhat rare situation where it could actually be useful even in C++: for a statement like obj.method().othermethod();, and then stepping into method and out again.

Correct.

Adding bug so we get this verified in the endgame


CI: Add additional project approver

Add @grahamwhaley as an additional project approver.
Fixes #93.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

/me is starting to get irritated with Travis.

Coverage remained the same at 74.781% when pulling 3c80d1e03c727a8da0a4c07abb61f3d3695caff1 on jodh-intel:add-extra-pullapprove-approver into 273bc17b99e8b391bc10761fa59216b1bc43a3b8 on clearcontainers:master.

for the PR:
lgtm
For travis - meh, shoot it now....

lgtm

Travis fixed (sometimes gometalinter makes travis timeout, haven't dug into it yet). Merging!


OMG the non-uniform sampling doesn't matter

If I switch the _distort_times function to have zero amplitude, the result stands -- this does not depend on having a non-uniform sampling grid!  It only depends on looking at the right frequency range...  Interesting and scary...

That said, we still have to get the generative model for the real data correct.  So we do have to care about the BJD conversion.


Reformat scalameta/semanticdb

@olafurpg I just want to explicitly say that I'm interested in these particular values, because I have tried other values and didn't like the result.
By settings these values explicitly, we are making sure that:

Potential changes in defaults in future versions of scalafmt will not affect us.
Hypothetical future contributors that would like to change .scalafmt.conf will know that we're not just accidentally using the defaults, but are conscious in that choice.


⚠ Bofrost.at has degraded performance

In 4d365a8, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1097 ms

Resolved: Bofrost.at performance has improved in dd0caf6.


Stack render broken?

I am not sure what I am doing wrong.
Without stack, looking good:

With stack, all messed up:

Code is at https://github.com/KTamas/imdbinder/blob/master/Tinder.js

I'm not really sure why the renderStack function had these values inside, so I'm not making a PR, but I found that if you change the lines 331-335 (SwipeCards.js) to:
      let offsetX = "50%"
      let lastOffsetX = this.props.stackOffsetX;

      let offsetY = "50%"
      let lastOffsetY = this.props.stackOffsetY;

it was originally:
      let offsetX = this.props.stackOffsetX * cards.length - i * this.props.stackOffsetX;
      let lastOffsetX = this.props.stackOffsetX;

      let offsetY = this.props.stackOffsetY * cards.length - i * this.props.stackOffsetY;
      let lastOffsetY = this.props.stackOffsetY;

I believe it will work just fine. still scaling as well

@esganzerla thanks, this fixes it!

@esganzerla That's exactly what gives the stacky look of it. Every card available gets slightly shifted  to the lower-right.

I figured out what I messed up: some default styles of create-react-native-app mess with it.

@KTamas mind sharing what that was?

the default CRNA App.js has this:
const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: '#fff',
    alignItems: 'center',
    justifyContent: 'center',
  },
});

alignItems: center and justifyContent: center messes up react-native-tinder-swipe-cards.

Right. I'm not using CRNA tho.

Yeah. The default app.js add this style to the main container and that breaks things so it's not really a CRNA but more like a stylesheet issue I guess.

you need to set the stackOffsetX i guess two will be good because  try out stackOffsetX={2}


rbx_binary implement Color3uint8

As part of this PR I have made serializer.rs use canonical property names when fetching property values to write, rather than the serialized names. This became an issue because deserializer.rs uses canonical names as keys for property maps. This caused the serializer to erroneously write default prop values since instance.properties.get("Color3uint8") results in a None. I alternatively could have made deserializer.rs use "Color3uint8" as the key, but that seems smelly to me.
I have also updated the test files submodule.

Leaving that problem alone, I've made the other changes.


Update from microsoft.sql 2021-05-01-preview to base branch

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

add a new API version 2021-05-01-preview for SQL RP.
Carry all the swagger updates from SQL RP for the 2021-05-01-preview release

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

The validation pipeline has been passed.
The failed ones are not due to this new API version change.
@zhenglaizhang  can you help to take a look? Thanks!

@jianyexi @fengzhou-msft
can you please take a look? Thanks!
we expect this PR can be merged soon and the 2021-05-01-preview will be released by September 30th.

Hi @jianyexi Jianye Xi FTE do you know how to fix the track 2 validation failure https://github.com/Azure/azure-rest-api-specs/pull/16184/checks?check_run_id=3724619480 ?

Can be ignored

compare with 2021-02-01-preview, there are three new groups of APIs added:

preview/2021-05-01-preview/DistributedAvailabilityGroups.json
preview/2021-05-01-preview/ServerConnectionPolicies.json
preview/2021-05-01-preview/ServerTrustCertificates.json


added test case 'can handle messages longer than the key'

I just saw an exercise implementation of somebody who did not account for messages longer than the key and I figured this needs to be in the spec.

Capital idea!  We just accepted a PR to the ecmascript track for a similar test.  Although the example.js in that track handles these cases correctly, there was no test there either.  You might take a look if you're curious.
Thanks for your contribution!

@matthewmorgan: Github does this automatically if you enable it in the merge settings of your repository:
https://github.com/blog/2141-squash-your-commits
https://help.github.com/articles/about-pull-request-merges/
You can even enforce "squash only".
So you don't have to wait for contributors to squash their commits themself. ;-)
(I have no local setup right now for my branch, that's why I'm telling you.)

@Vankog I'm aware of that, thank you.  We ask contributors to do it because for many of them, knowing how to do so locally is a useful skill, and many have not learned how.
If squashing locally is old hat to you, I can do it during the merge.

Ah I see, being pedagogical. Now I remember this repo being showcased on the github homepage as newbie friendly. Now I see why. :-)
OK then, I use TortoiseGit anyways. So it was just a matter of selecting the commits and hitting squash.

Indeed :) teaching is part of the goal!
Thanks for your contribution.


[grid_map_cv] Conversion to OpenCV force NaN to 0

When converting a GridMap to an OpenCV image with the method grid_map:GridMapCvConverter::toImage, the cv::Mat is initialized with zeros (black pixels)  (here) then, only finite values are copied from the GridMap to the cv::Mat (here).
In other words the NaN values are automatically translated into black pixels.
For my use case (processing a map during a SLAM), I have a lot of NaN values and I need that information in OpenCV.
So maybe, setting the value of the pixels to the mid value between lowerValue and upperValue is more interesting than forcing to 0 by default.

Are you using an image with a channel for the alpha layer? There's a round trip unit test that passes for the CV_8UC4 CV image type and I just added a nan-value/transparent pixel here.
If this does not solve your problem, could you please create a PR with a failing unit tests that shows the issue?

Ah no, I forgot to mention that I am using a CV_8UC1 grayscale image, that is why, there is no other solution to translate a NaN to a mid value between Free and Occupied.

So is there anything you would like to see differently in the behavior of Grid Map or should I close this issue?

What do you think about setting NaN values to the mid value between lowerValue and upperValue?

*if there is no alpha channel, of couse.

I would keep the current behavior, since I feel it's the one with the least assumptions. Your use case is very special, and if I'm not mistaken, you could achieve your desired behavior by setting your empty/nan cells to the mid-value before converting it to the image format.

Yes, of course, it is what I have done.
But for the map_server for example, a unknown cell is a pixel with value 128 that is why I was surprised that grid_map did not picked a middle value.
Anyway, as you said, my use case may be special for the gird_map because I did not managed to find an easy way to convert pixels position to grid_map coordinates then OccupancyGrid coordinates. So I have ended up writing my own conversion methods.
Maybe you could add in the doc that the NaN values are converted to the value 0 for images with no alpha layer.

I have also encountered this problem.
The issue is that the output of SLAM algorithms for unknown area is -1 in occupancy grids, that gets transformed into NaN in Grid maps that gets transformed into 0 in cv::Mat. That causes cv::Mats to make no difference between occupied cells and unknown cells.
I don't think changing NaN cells to a middle value before converting to grid map is a good solution because an occupancy grid is supposed to give a probability of occupancy of each cell and is not supposed to give a value to unknown space.


min_mask_region_area not working correctly

I created a new mask generator:
mask_generator_2 = SamAutomaticMaskGenerator(
model=sam,
points_per_side=32,
pred_iou_thresh=0.86,
stability_score_thresh=0.92,
crop_n_layers=1,
crop_n_points_downscale_factor=2,
min_mask_region_area=600000,  # Requires open-cv to run post-processing
)
My image generated 39 masks with min_mask_region_area=100 with the maximum mask being 64000 second max is around 3000. The parameter min_mask_region_area works weirdly as setting the value to 600000 results in 35 masks, which is not logical. Looking into the source to try to find why...

Could be solved easily after mask generation,
Specify the minimum and maximum area value you want to filter by
min_area = 6000
max_area = 30000
new_dict = []
for i in masks:
if i['area'] > min_area and i['area'] < max_area:
new_dict.append(i)
#Now new_dict is your new mask

Please see code here for detailed implementation.


Update resource.jl

the header "Content-Encoding" => "gzip" triggers the unzipping to happen twice (once by the chromium engine, and a second time by the package manager).  It is better to remove it and replace by the same header that the Package Server uses, i.e. "Content-Type" => "application/octet-stream".

I'm not at all an expert on HTTP headers but I'm curious in which scenario a package reaches the package manager via the chromium engine.

I should have revised my comment here. I did some testing using chrome to inspect the response from our LocalPackageServer. The chromium engine then unzipped the file, which we believe is what is happening also when requesting the package with a Julia package manager. We then get an error when the package manager tries to unzip the file a second time. Does this clarify?

As far as I know this is closer to how Julia's package manager receives packages from a package server:
$ curl https://xxx.xxx.xxx.xx/package/7876af07-990d-54b4-ab0e-23690620f79a/46e44e869b4d90b96bd8ed1fdcf32244fddfb6cc -o Example0.5.3
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2685  100  2685    0     0   201k      0 --:--:-- --:--:-- --:--:--  218k
$ file Example0.5.3
Example0.5.3: gzip compressed data, max compression, from Unix, original size modulo 2^32 16384
$ tar tvfz Example0.5.3
-rw-r--r-- 0/0            1098 1970-01-01 01:00 .appveyor.yml
-rw-r--r-- 0/0              15 1970-01-01 01:00 .codecov.yml
-rw-r--r-- 0/0              62 1970-01-01 01:00 .gitignore
-rw-r--r-- 0/0            1030 1970-01-01 01:00 .travis.yml
-rw-r--r-- 0/0            1194 1970-01-01 01:00 LICENSE.md
-rw-r--r-- 0/0             186 1970-01-01 01:00 Project.toml
-rw-r--r-- 0/0            1070 1970-01-01 01:00 README.md
-rw-r--r-- 0/0              90 1970-01-01 01:00 docs/Project.toml
-rw-r--r-- 0/0             147 1970-01-01 01:00 docs/make.jl
-rw-r--r-- 0/0              77 1970-01-01 01:00 docs/src/index.md
-rw-r--r-- 0/0             206 1970-01-01 01:00 src/Example.jl
-rw-r--r-- 0/0              86 1970-01-01 01:00 test/runtests.jl

If this PR solves your problem something must be working differently than it does in my environment, and I'd like to understand what that is. What version of Julia and on what OS are you running?

I am using Julia 1.7.3 on a windows machine. I think I have figured out why there is double unzipping of the file. It seems that since Julia 1.6, the Pkg.jl uses libcurl (https://github.com/JuliaLang/Downloads.jl/blob/master/src/Downloads.jl#L1-L13) to download packages and libcurl seems be configured to unzip automatically when the header on Content encoding is present (https://curl.se/libcurl/c/CURLOPT_ACCEPT_ENCODING.html)

Thanks for the analysis. PkgServer.jl sets the content type to application/x-gzip (and content encoding to identity, which I assume is the same as omitting it) since https://github.com/JuliaPackaging/PkgServer.jl/pull/106. Unless there are good reasons to do differently I'd prefer to follow their lead, since that's where large parts of this code originated.

Sounds good to me! Shall I close the pull request?

Please see if #8 works for you.

Closed in favor of #8.


Feature: Admin ban player by SteamID (offline).

Added with push request https://github.com/11TStudio/SquadStatsJSPRO/pull/25


Improve navbar style

Make it match the style in the design document.

Ok I think it looks passable now 6e74cbf2f80d66909efbbb8e8782c01cc8bdd6d9