Slow execution using a single query

When using Microsoft.EntityFrameworkCore 2.1.4 (and also 2.2.0-preview3-35497) in a Console application to retrieve data for XmlSerialization I'm finding that retrieving the data in a single LINQ query is very slow taking almost 7 minutes to complete whereas if I do this in two steps to get the equivalent result the total time is less than 30 seconds.
Executing both sets of generated SQL against the database (SQL Server 2016) in SQL Server Management Studio both provide a similar execution time of around 10 seconds.
I haven't spotted any issues with my DbContext or classes and there is sufficient indexes in database so what is causing the slow execution between the two queries?
using (var context = new AppDbContext())
{
	context.ChangeTracker.QueryTrackingBehavior = QueryTrackingBehavior.NoTracking;

	var fullSubmission = context.CYP000
		.Include(p => p.CYP001)
			.ThenInclude(p => p.CYP002)
		.Include(p => p.CYP001)
			.ThenInclude(p => p.CYP101)
				.ThenInclude(r => r.CYP201)
					.ThenInclude(c => c.CYP202)
		.SingleOrDefault(x => x.SubmissionId == submissionId);

	// Retrieved full submission in 00:06:46.8583712

	var submission = context.CYP000
		.Single(s => s.SubmissionId == submissionId);

	// Retrieved submission in 00:00:01.1036359

	var patients = context.CYP001
		.Include(p => p.CYP101)
			.ThenInclude(r => r.CYP201)
				.ThenInclude(c => c.CYP202)
		.Include(p => p.CYP002)
		.Where(p => p.SubmissionId == submissionId)
		.ToList();

	// Retrieved patients in 00:00:21.0496461

	submission.CYP001 = patients;
}

This is the log when using a single LINQ query
info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (12ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT TOP(2) [p].[SubmissionId], [p].[C000010], [p].[C000020], [p].[C000030], [p].[C000040], [p].[C000050], [p].[C000060]

      FROM [CYP000] AS [p]

      WHERE [p].[SubmissionId] = @__submissionId_0

      ORDER BY [p].[SubmissionId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (15ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP001].[SubmissionId], [p.CYP001].[PatientId], [p.CYP001].[C001010], [p.CYP001].[C001020], [p.CYP001].[C001030], [p.CYP001].[C001040], [p.CYP001].[C001050], [p.CYP001].[C001060], [p.CYP001].[C001070], [p.CYP001].[C001080], [p.CYP001].[C001090], [p.CYP001].[C001100], [p.CYP001].[C001110], [p.CYP001].[C001120], [p.CYP001].[C001130], [p.CYP001].[C001140], [p.CYP001].[C001150], [p.CYP001].[C001160], [p.CYP001].[C001170], [p.CYP001].[C001180], [p.CYP001].[C001190], [p.CYP001].[C001200], [p.CYP001].[C001210], [p.CYP001].[C001220], [p.CYP001].[C001230], [p.CYP001].[C001240], [p.CYP001].[C001901]

      FROM [CYP001] AS [p.CYP001]

      INNER JOIN (

          SELECT TOP(1) [p0].[SubmissionId]

          FROM [CYP000] AS [p0]

          WHERE [p0].[SubmissionId] = @__submissionId_0

          ORDER BY [p0].[SubmissionId]

      ) AS [t] ON [p.CYP001].[SubmissionId] = [t].[SubmissionId]

      ORDER BY [t].[SubmissionId], [p.CYP001].[SubmissionId], [p.CYP001].[PatientId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (14ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP001.CYP002].[SubmissionId], [p.CYP001.CYP002].[PatientId], [p.CYP001.CYP002].[C002020], [p.CYP001.CYP002].[C002010], [p.CYP001.CYP002].[C002030], [p.CYP001.CYP002].[C002040], [p.CYP001.CYP002].[C002901]

      FROM [CYP002] AS [p.CYP001.CYP002]

      INNER JOIN (

          SELECT DISTINCT [p.CYP0010].[SubmissionId], [p.CYP0010].[PatientId], [t0].[SubmissionId] AS [SubmissionId0]

          FROM [CYP001] AS [p.CYP0010]

          INNER JOIN (

              SELECT TOP(1) [p1].[SubmissionId]

              FROM [CYP000] AS [p1]

              WHERE [p1].[SubmissionId] = @__submissionId_0

              ORDER BY [p1].[SubmissionId]

          ) AS [t0] ON [p.CYP0010].[SubmissionId] = [t0].[SubmissionId]

      ) AS [t1] ON ([p.CYP001.CYP002].[SubmissionId] = [t1].[SubmissionId]) AND ([p.CYP001.CYP002].[PatientId] = [t1].[PatientId])

      ORDER BY [t1].[SubmissionId0], [t1].[SubmissionId], [t1].[PatientId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (184ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP001.CYP101].[SubmissionId], [p.CYP001.CYP101].[ReferralId], [p.CYP001.CYP101].[C101010], [p.CYP001.CYP101].[C101020], [p.CYP001.CYP101].[C101030], [p.CYP001.CYP101].[C101040], [p.CYP001.CYP101].[C101050], [p.CYP001.CYP101].[C101060], [p.CYP001.CYP101].[C101070], [p.CYP001.CYP101].[C101080], [p.CYP001.CYP101].[C101090], [p.CYP001.CYP101].[C101901], [p.CYP001.CYP101].[C101902], [p.CYP001.CYP101].[C101912], [p.CYP001.CYP101].[PatientId]

      FROM [CYP101] AS [p.CYP001.CYP101]

      INNER JOIN (

          SELECT DISTINCT [p.CYP0011].[SubmissionId], [p.CYP0011].[PatientId], [t2].[SubmissionId] AS [SubmissionId0]

          FROM [CYP001] AS [p.CYP0011]

          INNER JOIN (

              SELECT TOP(1) [p2].[SubmissionId]

              FROM [CYP000] AS [p2]

              WHERE [p2].[SubmissionId] = @__submissionId_0

              ORDER BY [p2].[SubmissionId]

          ) AS [t2] ON [p.CYP0011].[SubmissionId] = [t2].[SubmissionId]

      ) AS [t3] ON ([p.CYP001.CYP101].[SubmissionId] = [t3].[SubmissionId]) AND ([p.CYP001.CYP101].[PatientId] = [t3].[PatientId])

      ORDER BY [t3].[SubmissionId0], [t3].[SubmissionId], [t3].[PatientId], [p.CYP001.CYP101].[SubmissionId], [p.CYP001.CYP101].[ReferralId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (151ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP001.CYP101.CYP201].[SubmissionId], [p.CYP001.CYP101.CYP201].[ContactId], [p.CYP001.CYP101.CYP201].[C201010], [p.CYP001.CYP101.CYP201].[C201020], [p.CYP001.CYP101.CYP201].[C201030], [p.CYP001.CYP101.CYP201].[C201040], [p.CYP001.CYP101.CYP201].[C201050], [p.CYP001.CYP101.CYP201].[C201060], [p.CYP001.CYP101.CYP201].[C201070], [p.CYP001.CYP101.CYP201].[C201080], [p.CYP001.CYP101.CYP201].[C201090], [p.CYP001.CYP101.CYP201].[C201100], [p.CYP001.CYP101.CYP201].[C201110], [p.CYP001.CYP101.CYP201].[C201120], [p.CYP001.CYP101.CYP201].[C201130], [p.CYP001.CYP101.CYP201].[C201140], [p.CYP001.CYP101.CYP201].[C201150], [p.CYP001.CYP101.CYP201].[C201160], [p.CYP001.CYP101.CYP201].[C201902], [p.CYP001.CYP101.CYP201].[C201903], [p.CYP001.CYP101.CYP201].[C201906], [p.CYP001.CYP101.CYP201].[C201909], [p.CYP001.CYP101.CYP201].[C201912], [p.CYP001.CYP101.CYP201].[ReferralId]

      FROM [CYP201] AS [p.CYP001.CYP101.CYP201]

      INNER JOIN (

          SELECT DISTINCT [p.CYP001.CYP1010].[SubmissionId], [p.CYP001.CYP1010].[ReferralId], [t5].[SubmissionId0], [t5].[SubmissionId] AS [SubmissionId1], [t5].[PatientId]

          FROM [CYP101] AS [p.CYP001.CYP1010]

          INNER JOIN (

              SELECT DISTINCT [p.CYP0012].[SubmissionId], [p.CYP0012].[PatientId], [t4].[SubmissionId] AS [SubmissionId0]

              FROM [CYP001] AS [p.CYP0012]

              INNER JOIN (

                  SELECT TOP(1) [p3].[SubmissionId]

                  FROM [CYP000] AS [p3]

                  WHERE [p3].[SubmissionId] = @__submissionId_0

                  ORDER BY [p3].[SubmissionId]

              ) AS [t4] ON [p.CYP0012].[SubmissionId] = [t4].[SubmissionId]

          ) AS [t5] ON ([p.CYP001.CYP1010].[SubmissionId] = [t5].[SubmissionId]) AND ([p.CYP001.CYP1010].[PatientId] = [t5].[PatientId])

      ) AS [t6] ON ([p.CYP001.CYP101.CYP201].[SubmissionId] = [t6].[SubmissionId]) AND ([p.CYP001.CYP101.CYP201].[ReferralId] = [t6].[ReferralId])

      ORDER BY [t6].[SubmissionId0], [t6].[SubmissionId1], [t6].[PatientId], [t6].[SubmissionId], [t6].[ReferralId], [p.CYP001.CYP101.CYP201].[SubmissionId], [p.CYP001.CYP101.CYP201].[ContactId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (210ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP001.CYP101.CYP201.CYP202].[SubmissionId], [p.CYP001.CYP101.CYP201.CYP202].[ContactActivityId], [p.CYP001.CYP101.CYP201.CYP202].[C202010], [p.CYP001.CYP101.CYP201.CYP202].[C202020], [p.CYP001.CYP101.CYP201.CYP202].[C202030], [p.CYP001.CYP101.CYP201.CYP202].[C202040], [p.CYP001.CYP101.CYP201.CYP202].[C202050], [p.CYP001.CYP101.CYP201.CYP202].[C202060], [p.CYP001.CYP101.CYP201.CYP202].[C202070], [p.CYP001.CYP101.CYP201.CYP202].[C202080], [p.CYP001.CYP101.CYP201.CYP202].[C202090], [p.CYP001.CYP101.CYP201.CYP202].[C202100], [p.CYP001.CYP101.CYP201.CYP202].[C202110], [p.CYP001.CYP101.CYP201.CYP202].[C202903], [p.CYP001.CYP101.CYP201.CYP202].[C202904], [p.CYP001.CYP101.CYP201.CYP202].[ContactId]

      FROM [CYP202] AS [p.CYP001.CYP101.CYP201.CYP202]

      INNER JOIN (

          SELECT DISTINCT [p.CYP001.CYP101.CYP2010].[SubmissionId], [p.CYP001.CYP101.CYP2010].[ContactId], [t9].[SubmissionId0], [t9].[SubmissionId1], [t9].[PatientId], [t9].[SubmissionId] AS [SubmissionId2], [t9].[ReferralId]

          FROM [CYP201] AS [p.CYP001.CYP101.CYP2010]

          INNER JOIN (

              SELECT DISTINCT [p.CYP001.CYP1011].[SubmissionId], [p.CYP001.CYP1011].[ReferralId], [t8].[SubmissionId0], [t8].[SubmissionId] AS [SubmissionId1], [t8].[PatientId]

              FROM [CYP101] AS [p.CYP001.CYP1011]

              INNER JOIN (

                  SELECT DISTINCT [p.CYP0013].[SubmissionId], [p.CYP0013].[PatientId], [t7].[SubmissionId] AS [SubmissionId0]

                  FROM [CYP001] AS [p.CYP0013]

                  INNER JOIN (

                      SELECT TOP(1) [p4].[SubmissionId]

                      FROM [CYP000] AS [p4]

                      WHERE [p4].[SubmissionId] = @__submissionId_0

                      ORDER BY [p4].[SubmissionId]

                  ) AS [t7] ON [p.CYP0013].[SubmissionId] = [t7].[SubmissionId]

              ) AS [t8] ON ([p.CYP001.CYP1011].[SubmissionId] = [t8].[SubmissionId]) AND ([p.CYP001.CYP1011].[PatientId] = [t8].[PatientId])

          ) AS [t9] ON ([p.CYP001.CYP101.CYP2010].[SubmissionId] = [t9].[SubmissionId]) AND ([p.CYP001.CYP101.CYP2010].[ReferralId] = [t9].[ReferralId])

      ) AS [t10] ON ([p.CYP001.CYP101.CYP201.CYP202].[SubmissionId] = [t10].[SubmissionId]) AND ([p.CYP001.CYP101.CYP201.CYP202].[ContactId] = [t10].[ContactId])

      ORDER BY [t10].[SubmissionId0], [t10].[SubmissionId1], [t10].[PatientId], [t10].[SubmissionId2], [t10].[ReferralId], [t10].[SubmissionId], [t10].[ContactId]

24/10/2018 15:43:44 - Retrieved full submission in 00:06:50.1565598

This is the log when retrieving the data in 2 steps:
warn: Microsoft.EntityFrameworkCore.Model.Validation[30000]

      No type was specified for the decimal column 'C000010' on entity type 'CYP000'. This will cause values to be silently truncated if they do not fit in the default precision and scale. Explicitly specify the SQL server column type that can accommodate all the values using 'ForHasColumnType()'.

info: Microsoft.EntityFrameworkCore.Infrastructure[10403]

      Entity Framework Core 2.1.4-rtm-31024 initialized 'AppDbContext' using provider 'Microsoft.EntityFrameworkCore.SqlServer' with options: None

24/10/2018 15:36:34 - Getting data

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (82ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT TOP(2) [s].[SubmissionId], [s].[C000010], [s].[C000020], [s].[C000030], [s].[C000040], [s].[C000050], [s].[C000060]

      FROM [CYP000] AS [s]

      WHERE [s].[SubmissionId] = @__submissionId_0

24/10/2018 15:36:35 - Retrieved submission in 00:00:00.8605259

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (17ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p].[SubmissionId], [p].[PatientId], [p].[C001010], [p].[C001020], [p].[C001030], [p].[C001040], [p].[C001050], [p].[C001060], [p].[C001070], [p].[C001080], [p].[C001090], [p].[C001100], [p].[C001110], [p].[C001120], [p].[C001130], [p].[C001140], [p].[C001150], [p].[C001160], [p].[C001170], [p].[C001180], [p].[C001190], [p].[C001200], [p].[C001210], [p].[C001220], [p].[C001230], [p].[C001240], [p].[C001901]

      FROM [CYP001] AS [p]

      WHERE [p].[SubmissionId] = @__submissionId_0

      ORDER BY [p].[SubmissionId], [p].[PatientId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (175ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP101].[SubmissionId], [p.CYP101].[ReferralId], [p.CYP101].[C101010], [p.CYP101].[C101020], [p.CYP101].[C101030], [p.CYP101].[C101040], [p.CYP101].[C101050], [p.CYP101].[C101060], [p.CYP101].[C101070], [p.CYP101].[C101080], [p.CYP101].[C101090], [p.CYP101].[C101901], [p.CYP101].[C101902], [p.CYP101].[C101912], [p.CYP101].[PatientId]

      FROM [CYP101] AS [p.CYP101]

      INNER JOIN (

          SELECT [p0].[SubmissionId], [p0].[PatientId]

          FROM [CYP001] AS [p0]

          WHERE [p0].[SubmissionId] = @__submissionId_0

      ) AS [t] ON ([p.CYP101].[SubmissionId] = [t].[SubmissionId]) AND ([p.CYP101].[PatientId] = [t].[PatientId])

      ORDER BY [t].[SubmissionId], [t].[PatientId], [p.CYP101].[SubmissionId], [p.CYP101].[ReferralId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (149ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP101.CYP201].[SubmissionId], [p.CYP101.CYP201].[ContactId], [p.CYP101.CYP201].[C201010], [p.CYP101.CYP201].[C201020], [p.CYP101.CYP201].[C201030], [p.CYP101.CYP201].[C201040], [p.CYP101.CYP201].[C201050], [p.CYP101.CYP201].[C201060], [p.CYP101.CYP201].[C201070], [p.CYP101.CYP201].[C201080], [p.CYP101.CYP201].[C201090], [p.CYP101.CYP201].[C201100], [p.CYP101.CYP201].[C201110], [p.CYP101.CYP201].[C201120], [p.CYP101.CYP201].[C201130], [p.CYP101.CYP201].[C201140], [p.CYP101.CYP201].[C201150], [p.CYP101.CYP201].[C201160], [p.CYP101.CYP201].[C201902], [p.CYP101.CYP201].[C201903], [p.CYP101.CYP201].[C201906], [p.CYP101.CYP201].[C201909], [p.CYP101.CYP201].[C201912], [p.CYP101.CYP201].[ReferralId]

      FROM [CYP201] AS [p.CYP101.CYP201]

      INNER JOIN (

          SELECT DISTINCT [p.CYP1010].[SubmissionId], [p.CYP1010].[ReferralId], [t0].[SubmissionId] AS [SubmissionId0], [t0].[PatientId]

          FROM [CYP101] AS [p.CYP1010]

          INNER JOIN (

              SELECT [p1].[SubmissionId], [p1].[PatientId]

              FROM [CYP001] AS [p1]

              WHERE [p1].[SubmissionId] = @__submissionId_0

          ) AS [t0] ON ([p.CYP1010].[SubmissionId] = [t0].[SubmissionId]) AND ([p.CYP1010].[PatientId] = [t0].[PatientId])

      ) AS [t1] ON ([p.CYP101.CYP201].[SubmissionId] = [t1].[SubmissionId]) AND ([p.CYP101.CYP201].[ReferralId] = [t1].[ReferralId])

      ORDER BY [t1].[SubmissionId0], [t1].[PatientId], [t1].[SubmissionId], [t1].[ReferralId], [p.CYP101.CYP201].[SubmissionId], [p.CYP101.CYP201].[ContactId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (190ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP101.CYP201.CYP202].[SubmissionId], [p.CYP101.CYP201.CYP202].[ContactActivityId], [p.CYP101.CYP201.CYP202].[C202010], [p.CYP101.CYP201.CYP202].[C202020], [p.CYP101.CYP201.CYP202].[C202030], [p.CYP101.CYP201.CYP202].[C202040], [p.CYP101.CYP201.CYP202].[C202050], [p.CYP101.CYP201.CYP202].[C202060], [p.CYP101.CYP201.CYP202].[C202070], [p.CYP101.CYP201.CYP202].[C202080], [p.CYP101.CYP201.CYP202].[C202090], [p.CYP101.CYP201.CYP202].[C202100], [p.CYP101.CYP201.CYP202].[C202110], [p.CYP101.CYP201.CYP202].[C202903], [p.CYP101.CYP201.CYP202].[C202904], [p.CYP101.CYP201.CYP202].[ContactId]

      FROM [CYP202] AS [p.CYP101.CYP201.CYP202]

      INNER JOIN (

          SELECT DISTINCT [p.CYP101.CYP2010].[SubmissionId], [p.CYP101.CYP2010].[ContactId], [t3].[SubmissionId0], [t3].[PatientId], [t3].[SubmissionId] AS [SubmissionId1], [t3].[ReferralId]

          FROM [CYP201] AS [p.CYP101.CYP2010]

          INNER JOIN (

              SELECT DISTINCT [p.CYP1011].[SubmissionId], [p.CYP1011].[ReferralId], [t2].[SubmissionId] AS [SubmissionId0], [t2].[PatientId]

              FROM [CYP101] AS [p.CYP1011]

              INNER JOIN (

                  SELECT [p2].[SubmissionId], [p2].[PatientId]

                  FROM [CYP001] AS [p2]

                  WHERE [p2].[SubmissionId] = @__submissionId_0

              ) AS [t2] ON ([p.CYP1011].[SubmissionId] = [t2].[SubmissionId]) AND ([p.CYP1011].[PatientId] = [t2].[PatientId])

          ) AS [t3] ON ([p.CYP101.CYP2010].[SubmissionId] = [t3].[SubmissionId]) AND ([p.CYP101.CYP2010].[ReferralId] = [t3].[ReferralId])

      ) AS [t4] ON ([p.CYP101.CYP201.CYP202].[SubmissionId] = [t4].[SubmissionId]) AND ([p.CYP101.CYP201.CYP202].[ContactId] = [t4].[ContactId])

      ORDER BY [t4].[SubmissionId0], [t4].[PatientId], [t4].[SubmissionId1], [t4].[ReferralId], [t4].[SubmissionId], [t4].[ContactId]

info: Microsoft.EntityFrameworkCore.Database.Command[20101]

      Executed DbCommand (14ms) [Parameters=[@__submissionId_0='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']

      SELECT [p.CYP002].[SubmissionId], [p.CYP002].[PatientId], [p.CYP002].[C002020], [p.CYP002].[C002010], [p.CYP002].[C002030], [p.CYP002].[C002040], [p.CYP002].[C002901]

      FROM [CYP002] AS [p.CYP002]

      INNER JOIN (

          SELECT [p3].[SubmissionId], [p3].[PatientId]

          FROM [CYP001] AS [p3]

          WHERE [p3].[SubmissionId] = @__submissionId_0

      ) AS [t5] ON ([p.CYP002].[SubmissionId] = [t5].[SubmissionId]) AND ([p.CYP002].[PatientId] = [t5].[PatientId])

      ORDER BY [t5].[SubmissionId], [t5].[PatientId]

24/10/2018 15:36:53 - Retrieved patients in 00:00:18.1113376

Entity Classes
public class CYP000
{
    [XmlIgnore]
    public int SubmissionId { get; set; }

    // CYP000 Properties

    [XmlElement("CYP001")]
    public List<CYP001> CYP001 { get; set; }
}

public class CYP001
{
    [XmlIgnore]
    public int SubmissionId { get; set; }

    [XmlIgnore]
    public long PatientId { get; set; }

    // CYP001 Properties

    [XmlIgnore]
    public CYP000 CYP000 { get; set; }

    [XmlElement("CYP101")]
    public List<CYP101> CYP101 { get; set; }

    [XmlElement("CYP002")]
    public List<CYP002> CYP002 {get;set;}
}

public class CYP002
{
    [XmlIgnore]
    public int SubmissionId { get; set; }
    [XmlIgnore]
    public long PatientId { get; set; }

    // CYP002 Properties

    [XmlIgnore]
    public CYP001 CYP001 { get; set; }
}

public class CYP101
{
    [XmlIgnore]
    public int SubmissionId { get; set; }
    [XmlIgnore]
    public long ReferralId { get; set; }
    [XmlIgnore]
    public long PatientId { get; set; }

    // CYP101 Properties

    [XmlIgnore]
    public CYP001 CYP001 { get; set; }
    [XmlElement("CYP201")]
    public List<CYP201> CYP201 { get; set; }
}

public class CYP201
{
    [XmlIgnore]
    public int SubmissionId { get; set; }
    [XmlIgnore]
    public long ContactId { get; set; }
    [XmlIgnore]
    public long ReferralId { get; set; }

    // CYP201 Properties

    [XmlIgnore]
    public CYP101 CYP101 { get; set; }
    [XmlElement("CYP202")]
    public List<CYP202> CYP202 { get; set; }
}

public class CYP202
{
    [XmlIgnore]
    public int SubmissionId { get; set; }
    [XmlIgnore]
    public long ContactId { get; set; }
    [XmlIgnore]
    public long ContactActivityId { get; set; }

    // CYP202 Properties

    [XmlIgnore]
    public CYP201 CYP201 { get; set; }
}

DbContext
public DbSet<CYP000> CYP000 { get; set; }
public DbSet<CYP001> CYP001 { get; set; }
public DbSet<CYP002> CYP002 { get; set; }
public DbSet<CYP101> CYP101 { get; set; }
public DbSet<CYP201> CYP201 { get; set; }
public DbSet<CYP202> CYP202 { get; set; }

protected override void OnModelCreating(ModelBuilder modelBuilder)
{
    // CYP000
    modelBuilder.Entity<CYP000>()
        .HasKey(e => e.SubmissionId);

    modelBuilder.Entity<CYP000>()
        .HasMany(e => e.CYP001)
        .WithOne(e => e.CYP000)
        .HasForeignKey(e => e.SubmissionId)
        .HasPrincipalKey(e => e.SubmissionId);

    // CYP001
    modelBuilder.Entity<CYP001>()
        .HasKey(e => new { e.SubmissionId, e.PatientId });

    modelBuilder.Entity<CYP001>()
        .HasMany(e => e.CYP101)
        .WithOne(e => e.CYP001)
        .HasForeignKey(e => new { e.SubmissionId, e.PatientId });

    modelBuilder.Entity<CYP001>()
        .HasMany(e => e.CYP002)
        .WithOne(e => e.CYP001)
        .HasForeignKey(e => new { e.SubmissionId, e.PatientId });

    // CYP002
    modelBuilder.Entity<CYP002>()
        .HasKey(e => new { e.SubmissionId, e.PatientId, e.C002020 });

    // CYP101
    modelBuilder.Entity<CYP101>()
        .HasKey(e => new { e.SubmissionId, e.ReferralId });

    modelBuilder.Entity<CYP101>()
        .HasMany(e => e.CYP201)
        .WithOne(e => e.CYP101)
        .HasForeignKey(e => new { e.SubmissionId, e.ReferralId });

    // CYP201
    modelBuilder.Entity<CYP201>()
        .HasKey(e => new { e.SubmissionId, e.ContactId });

    modelBuilder.Entity<CYP201>()
        .HasMany(e => e.CYP202)
        .WithOne(e => e.CYP201)
        .HasForeignKey(e => new { e.SubmissionId, e.ContactId });

    // CYP202
    modelBuilder.Entity<CYP202>()
        .HasKey(e => new { e.SubmissionId, e.ContactActivityId });
}

@maumar to investigate

@maumar please see attached project for full test case, these are my results with this data:

02/11/2018 12:52:54 - Retrieving data in 2 steps...
02/11/2018 12:52:54 - Step 1/2 patients (CYP001)...
02/11/2018 12:53:15 - Retrieved patients (CYP001) in 00:00:20.7037593
02/11/2018 12:53:15 - Step 2/2 submission (CYP000)...
02/11/2018 12:53:15 - Retrieved submission (CYP000) in 00:00:00.0352636
02/11/2018 12:53:15 - Retrieving data in 1 step...
02/11/2018 12:59:17 - Retrieved data in 00:06:02.8767495

CreateXml.zip

@mheptinstall thanks for the project, now I am seeing the performance difference.

Problem is because of Contains call here:

collection has over 300k elements at the end, so the check takes time.

Triage: This is essentially a duplicate of #13518 and should also be fixed by removing identity resolution from no-tracking queries. Until then, another workaround would be to use a HashSet as the navigation property since Contains on a HashSet is much faster in these circumstances.


Question: around testing boundaries

https://github.com/Elderjs/elderjs/blob/b19dba3d336a62311c664d960249f7564d4716d9/src/routes/__tests__/routes.spec.ts#L3-L7
Hey @halafi, would you be able to help me understand what value we get from reimplementing path here?

Hi,
to be honest, probably not much, I just tried to keep unit tests as isolated as possible - so no external change would break a single test - that's anyway not kept up 100%.
In hindsight I probably would/will not chose to mock it again, so feel free to drop that.

👍 Thanks for clarifying @halafi, appreciate the ambition here but I am worried that creating mock implementations of system internals means we end up creating a test environment which does not accurately represent the target execution environment.

It looks like removing it from routes.spec.ts is painless but some of the other tests which are stubbing path do not pass locally when using the instance of path from the node distribution. 🤔

Working on a branch here:
https://github.com/Elderjs/elderjs/compare/master...thisislawatts:test/remove-mocks-for-nodejs-internals?expand=1

@halafi for example this looks like a legitimate test failure which was being masked by the mock implementation:
../elderjs/src/__tests__/hooks.spec.ts
TypeError: The "path" argument must be of type string. Received undefinedTypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
      269 |     run: async ({ settings, request, htmlString, errors }) => {
      270 |       if (settings.build) {
    > 271 |         const file = path.resolve(settings.distDir, `.${request.permalink}/index.html`);
          |                           ^
      272 |         try {
      273 |           fs.outputFileSync(file, htmlString);
      274 |         } catch (e) {

      at Object.run (src/hooks.ts:271:27)
      at Object.<anonymous> (src/__tests__/hooks.spec.ts:159:18)

@thisislawatts Thanks man! Got your branch merged.


Infinite Loop in split_frame Function of SAM2 Video Tracking Example

I'm using the SAM2 video tracking example, and I encountered an issue where the program goes into an infinite loop due to an incorrect condition in the split_frame function. Specifically, the issue was that the counter was never incremented under certain conditions, which caused the loop to continue indefinitely without reaching an exit point. This bug made the video tracking example unusable in its current form.
I have identified and fixed the issue by correcting the loop condition, ensuring that the function properly iterates through the frames and exits as expected. With this fix, the code is now working properly, and the video tracking example can proceed as intended without any infinite looping behavior.
I've prepared a pull request with the fix, but since I'm not a collaborator, I'm unable to submit it directly. I would greatly appreciate it if a collaborator could review the changes I've made and apply the fix to the main repository. This would help other users who may encounter the same issue and improve the overall stability of the example.
Here is the corrected code snippet for the split_frames function:
   def split_frames(self, video_path, temp_dir, start_frame=0, end_frame=100):
       logger.debug(f'Opening video file: {video_path}')
       video = cv2.VideoCapture(video_path)

       if not video.isOpened():
           raise ValueError(f"Could not open video file: {video_path}")

       logger.debug(f'Number of frames: {int(video.get(cv2.CAP_PROP_FRAME_COUNT))}')

       frame_count = 0
       while True:
           success, frame = video.read()

           if not success:
               logger.error(f'Failed to read frame {frame_count}')
               break

           if frame_count < start_frame:
               frame_count += 1
               continue

           if frame_count >= end_frame:
               break

           frame_filename = os.path.join(temp_dir, f'{frame_count:05d}.jpg')

           if not os.path.exists(frame_filename):
               cv2.imwrite(frame_filename, frame)

           logger.debug(f'Frame {frame_count}: {frame_filename}')
           yield frame_filename, frame
           frame_count += 1

       video.release()

resolved


Will we update to pytorch v2.2.0 ?

pytorch v2.2.0 has already release, will we update the next version? the version v2.1.2 has a bug which will cause oom while the newest version has already fixed. https://github.com/pytorch/pytorch/issues/106294

Not supported yet, I tied to built it, but failed.

Closing as a duplicate of #2722


about evaluation

Hi,
How do you get "26.0" FID on mscoco using DM-GAN? Because the official result reported in https://github.com/MinfengZhu/DM-GAN is 26.55.
I ran DM-GAN myself and managed to get a similar result(26.54), instead of "26.0".

@FrankCast1e

yes.
No. Apparently, there will not be duplicated ones after removal.
I think you misunderstand the process of evaluation. the blurred images are blurred original images, and the other set are generated images. Their captions are the same.

sorry, I'm confused.
2. For example, there are two images, A and B. A has 3 captions(no.1, no.2, no.3). B has 3 captions(no.4, no.5, no.6). Sample two captions from 6(3+3) captions. The sampled set may be (no.1, no.2), which belong to the same image A.
3. Following dalle, I think generated images should be applied with a gaussian filter too?


Callback for when component is loaded

Hi @jasonslyvia, wondering if there is any callback that is provided to know when the component is being loaded? This is super useful in advanced cases to do things when the component is loaded.
Thank you!

It is supported out of box, please refer to #65 for further information.

Ah, missed this PR and didn't find it in the README. But thank you - this is what I was looking for!


Differences between vue3 click events and vue2.7 click events

Vue version
2.7
Link to minimal reproduction
www
Steps to reproduce
function getDialogInfoMap(currentDialogType: DialogType) {
dialog1: {
confirm: () => handle(true),
cancel: () => handle(false),
},
dialog2: {
confirm: () => xxxxxx(),
cancel: () => xxxxxxxxx(),
},
}
In the above code, the click event through the template, why vue3 can be triggered, vue2.7 can not be triggered
What is expected?
vue2.7 also triggers
What is actually happening?
function getDialogInfoMap(currentDialogType: DialogType) {
dialog1: {
confirm: () => handle(true),
cancel: () => handle(false),
},
dialog2: {
confirm: () => xxxxxx(),
cancel: () => xxxxxxxxx(),
},
}
In the above code, the click event through the template, why vue3 can be triggered, vue2.7 can not be triggered
System Info
No response
Any additional comments?
No response

Please provide a runnable reproduction.


Add Azure Event Hub, ServiceBus queue and topic liveness

Pending functional testing strategy for non app veyor builds, to plan something global with existing Azure packages like Azure Storage. We can open an issue with it and start a discussion.
Liveness were implemented as discussed @lurumad.

PR conflicts fixed


TextField: Add Forward Ref

TODO

[ x] Accessibility checkup
[ x] Update documentation
[x ] Add/update Tests
[ x] Format PR title: ComponentName: Description.

Just merged #901 so closing this one out. @jennyscript & @simkessy thank you both for also driving this forward! This PR also made the other PR better.


[Fix]Dark Mode needs an overhaul - [LARGE PROJECT]

Dark mode is not following the current color scheme and breaks on half the sections. I would like a complete overhaul of dark mode. This will require a lot of work. Either the colors need to be updated everywhere to follow the global.css variable and use those. Or lots of lines of JavaScript need to be added/edited. I'll accept either implementation, but prefer CSS as it's easier to modify and change later.

  Hi Brittney,

Unfortunately, I don't have to much experience in this area but I can give it a  try to resolve this.
What colors do you want to use for dark mode?

This doesn't look the best, but I threw it together. Just something using the color variables from global.css.

Here's the figma link. https://www.figma.com/file/NY0Do1PFf4xl0ZuSTA1X9U/Keiko-Corp-Hacktoberfest-Project?node-id=2%3A8

Alright, thank you :)

@RedSquirrrel there have been changes, make sure you run a git pull upstream master to get the latest version.


Product Page Header

part of https://github.com/BlueBrain/nexus/issues/989
0.5 sp

Are you all happy with the icons I used in the design doc?
We should have consistent icons across the website. If you have better ideas, feel free to propose them.


Remove setTimeout(). Fix behavior of create menu.

Details
@Beamanator @luacmartins I don't think we need this setTimeout() anymore. Since this was moved into WelcomeActions it seems to open the create menu on iOS just fine.
I removed the setTimeout() and tested on a few versions of iOS and it works fine.
Fixed Issues
$ https://github.com/Expensify/App/issues/5296
Regression caused by: https://github.com/Expensify/App/pull/8692
Tests (iOS)

Sign in as a new user
Verify the create menu opens

[ ] Verify that no errors appear in the JS console

PR Review Checklist

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

Sign in as a new user
Verify the create menu opens

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS
https://user-images.githubusercontent.com/32969087/165857583-28af9f11-cee4-4ac7-b080-4da6c245f296.mp4
Android

Thanks for the comments @Beamanator. Updated!

Maybe we can wait for a boolean value to be added for NVP_IS_FIRST_TIME_NEW_EXPENSIFY_USER in Onyx and then open the create menu if necessary?

componentDidMount passes show/hide methods to WellcomeActions
WellcomeActions subscribe to Onyx
When boolean value is returned from the subscription it disconnects
If the value is true the "create menu is displayed"

Longer delays recreate the bug more consistently

Thanks @kidroca, just to clarify here the bug is:
The create menu is showing when we are not a new user because we must wait to know the true value of isFirstTimeNewExpensifyUser from the server
?

Does seem like we would probably want to wait for the reports and policies in that case as well 🤔

Gonna try something else here. I think it will be too confusing to have this logic in the view and we can't get around the fact that we need to wait for data to arrive from the server in this case 😄

Ok tried a different approach. I'm not sure if it's super great, but I believe it to be more correct than what we had before and here's my full reasoning...
Fact 1:

The "welcome action" must only happen until after we have read these values from the server:

isFirstTimeNewExpensifyUser
allPolicies
allReports

I can't think of a way around this right now, but that seems like the primary reason why we have the setTimeout()
Fact 2:

We can't trigger the "welcome task" until the Sidebar mounts so calling WelcomeActions.show() once in componentDidMount() seems correct. This guarantees the modal is ready to open, etc.

Fact 3:

We don't have a great way to detect whether the data we need has loaded from inside the SidebarScreen.

This is a new one for me, but I observed that the value of something like isReportDataLoading can be quickly set before the SidebarScreen even mounts. If we wanted to move that logic into the view layer it would be kind of ugly and require we do some checks inside componentDidUpdate() to see if the data has "loaded" yet. But if it loads before the component even mounts then we'd never be able to know that happened from inside the component because we can:

quickly fetch the report data
mount the SidebarScreen
no way to tell from within SidebarScreen that we have loaded all the reports, policies, or anything else

Sometimes a component needs to know whether we have at least attempted to load data from the server once and that the data it gets from withOnyx is the most up to date based on that data load.
It's not clear how often we might run into this situation, but I feel a more correct approach would be one where the component that needs to know whether this data has loaded would be the one to trigger it. Or we could create some kind of "monitor" that allows any component or lib to know if data has been loaded from the server for the current session.

Should we add videos for all platforms?

I can. It will take me some time to do :D

Updated, thanks for the spot @kidroca

Gonna be bold and merge this since I think it is blocking the deploy...?

@sketchydroide my CP staging label didn't seem to work here 🤔  despite this comment and this one I am pretty sure this needs to staging. But let me know if I missed something.

@marcaaron
Login- Create menu is not open
Action Performed:

Go to staging.new.expensifail.com
Sign in as a new user
Go back to your email and click on Link
Change the URL to staging and set a password for a new user
Verify the create menu opens

Expected Result:
The create menu opens
Actual Result:
Create menu is not open
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/167160761-44bfa9ba-ab47-4414-83e5-1723305b7ae6.mp4

@kbecciv doesn't appear to be on staging yet...

the code seems to be on staging, let me check if the build for it was deployed

@sketchydroide We tested on <IP_ADDRESS> build and it failed


Fix typos in lazy.md and cache.md

This PR fixes a few typos in the documentation:

Fixed missing ";" and corrected an extra ")" in the code examples in cache.md.
Removed an unnecessary space before the closing </Suspense> tag in the Lazy guide.

Thanks for maintaining such great documentation!

Thanks for sending a PR. but currently we aren't merging stylistic code changes.

@harish-sethuraman
Thank you for the feedback!
I just wanted to clarify that the issue in cache.md is actually a syntax error, not just a stylistic change.
The extra ")" in the code example would cause an error if the code were run.
Here's the problematic code:
function WeatherReport({record}) {
  const avgTemp = useMemo(() => calculateAvg(record)), record);
  // ...
}

Could we perhaps reconsider merging this change?

Sorry my bad. Merging this 👍🏻 thanks for following up.


Upgrade to Jakarta JAXRS #2897

Upgrade to latest package names

Signed-off-by: Paul Bastide<EMAIL_ADDRESS>

Leaving notes in the Issue...


Duplicated Rules 920340 and 920341

the following rules seems to be duplicated (same variables, operators, expressions and message). Can we just keep the one at PL1?
920340 PL1
https://github.com/coreruleset/coreruleset/blob/5cc6e2ac77f6a8ce05a22f7f744f9a8a702d44e6/rules/REQUEST-920-PROTOCOL-ENFORCEMENT.conf#L701-L719
920341 PL2
https://github.com/coreruleset/coreruleset/blob/5cc6e2ac77f6a8ce05a22f7f744f9a8a702d44e6/rules/REQUEST-920-PROTOCOL-ENFORCEMENT.conf#L1336-L1354

just missed that at PL1 the action is "pass" and not "block".
it would be nice to remove 920340 at PL2 in order to not log twice the same event.
closing for now.


Basic setup to be able to walk on some fields

A basic board with 2 players and 10 Fields are created. Players can roll and earn money when passing Go.
The PlayerIterator now has an array of players. With the replace method, the iterator doesn't have to be reinstantiated, but the rule of immutability is violated.

This change is

Will be reopened after fixing Iterator

That looks like a pretty solid foundation for the game. Well done. The iterator looks good. And everything else is kept nice and simple

I deleted the first branch after I merged it, should i continue? I will wait before deleting this one. If you read this and agree, just delete it yourself :)

Branch can be deleted. There are tests that are not in the coveralls report. I don't know why they are not included in the coverage.
There are still tests missing anyway.


Finish button for profile page

Profile page should have either a finish or submit button or save. It should redirect to the home page.

I'm also going to make the search boxes focus when the collapse expands.


Index calls itself recursively

https://github.com/moonlitesolutions/SolrClient/blob/master/SolrClient/solrclient.py#L130-L142.
My guess is that the code is intended to be:
data = json.dumps(docs)
return self.index_json(collection, data, params, **kwargs)

I see (belatedly) that both open PR's attempt to address this issue.

Yikes....
Thanks for another ping on this, kind of dropped the ball on that PR for a while.


Friend

[Hi my name is Felicia](i am and hookup girl please u like me please comment)

Sorry, I am not interested


Allow storage-driver options

Storage options can be passed to migrator with --storage-opt dm.key=val like in the daemon.
Fixes #5
Fixes #6
Signed-off-by: Tonis Tiigi<EMAIL_ADDRESS>

@ceecko @patryk-s Can you confirm that this fixes the issues for you?

Worked for me. Thank you very much!


texturerect set mouse filter is pass, scrollcontainer mouse enter signal cannot detected

Godot version:
3.2rc1
OS/device including version:
windows
Issue description:
texturerect set mouse filter is pass and follow cursor, scrollcontainer mouse enter signal cannot detected
same issue：
#6362   #20881
Steps to reproduce:*
Minimal reproduction project:
bug.zip

I don't really see issue here. The signal is properly detected when I connect it. Also

same issue：

closing as duplicate.
I can reopen if you provide more details and the issue is valid (i.e. bug and not duplicate).


classify-text example broken.

$ node analyze.v1beta2.js classify-text "Android is a mobile operating system developed by Google."
ERROR: { Error: Invalid text content: too few tokens (words) to process.
    at /home/pi/NBT/nodejs-language/samples/node_modules/grpc/src/client.js:554:15
  code: 3,
  metadata:
   Metadata {
     _internal_repr:
      { 'google.rpc.badrequest-bin': [Object],
        'grpc-status-details-bin': [Object] } },
  note: 'Exception occurred in retry method that was not classified as transient' }

This is an API error that we are simply passing back. Given more words, the "classifyText" function works as expected. If you need to know more about this method, you can contact the Language team directly (see https://cloud.google.com/natural-language/docs/support).

Oh, thanks. I didn't realize that was the example in the repo.

@jmdobry do I just update samples/README.md, or is there more to it than that?

Would need to update https://github.com/googleapis/nodejs-language/blob/master/samples/analyze.v1beta2.js#L397 and then do npm run generate-scaffolding


[ACS][Chat] Version Bump

Purpose

updated the Chat SDK version in file sharing sample
Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

closing off this PR sine Emlyn has updated the repo


Position of the app and the reading time

Hi,
I think maybe the timing is a little too much. If you calculate the ASCII characters for estimating the time perhaps me having a Persian site that the letters should be Unicode make the app think it is a long text. But I have a 11 minutes for a 5 min max article.
And I think the counter could be somewhere next to the post like Medium. Or it could have the option for users to decide it should be a floating text or an static element.
Great day and thanks for the apps,

Hi Shahab,
Thanks for reaching out to us. We've recently updated Reading Time to count Unicode characters more accurately. This update also allows the installer to set their words per minute if the default 250 isn't accurate to the site's language.
I've shared your positioning feedback with the team and have included it in our requested feature list. We don't an exact date on if this will be added, but it's on our radar :)
Cheers,
Teffen


AspectRatio

why is it that if i should make targetAspectRatio = 1.0; then, while trying to capture a video, the width looks so long??? @memfis19 @memfis19
Image can be seen here

What do you mean? Can you please explain more clearly what you are doing and what trying to achieve?


Added a helper file to handle API stuff.
Removed browser data (thx again will)

lol, just doing my job
On Thu, Oct 26, 2017 at 3:59 PM, Nick Teets<EMAIL_ADDRESS>wrote:

Merged #17 https://github.com/nicktu12/spotify-app/pull/17.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nicktu12/spotify-app/pull/17#event-1312913108, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABLrjXaDUHkP-fgipZnKuXURVz65WuNIks5swQDLgaJpZM4QIRuB
.

--
Will Mitchell
WVM Development
www.wvm-dev.com


Sets 'repository' metadata on published Rust crates

This sets the repository crate metadata to this GitHub repo and the homepage metadata value to Oso's homepage. This makes for a more enjoyable experience because I (and potentially other fellow Rustaceans) tend to always look for the repository link on <docs.rs> or <crates.io> and I get confused when it's not set (or when unexpectedly the homepage points to the repo).

I have read the CLA Document and I hereby sign the CLA


Change label GO:0097351 toxin-antitoxin pair type II binding

GO:0097351 toxin-antitoxin pair type II binding is defined as "Binding to a toxic protein, disabling its function. There may be more than one antitoxin to a toxic protein. Instances of this activity are known only in prokaryotes, where the toxic protein may be a ribonuclease, a DNA gyrase, or other." @federicaquaglia and the DisProt group requested a term to represent "toxin sequestering activity", which is a better label for this function, and would classify this as a sequestering activity, rather than just a binding function.
I will change the term label for GO:0097351
Thanks, Pascale

Also, add PMID:24806488 as a cross reference.

Are the toxin always proteins in this system @federicaquaglia @genegodbold ? If not I will adjust the definition as well.
Thanks, Pascale

As far as it concerns DisProt yes, the toxins and antitoxins we annotate are proteins with intrinsically disordered regions


teacher tool: initial theming from target

Initial support for styling from target theme. Only tested with microbit. Target themes are a bit messy. It will take another PR or two before we have it nicely wrapped, I think.
I updated app startup to download targetconfig.json, but the local pxt server puts it behind a gate. This is for legacy reasons that I doubt apply anymore, but can't know for sure. As a workaround, run pxt serve with the --noauth option. We don't actually use targetconfig.json yet, so you won't notice anything if you forget to add --noauth.
I also updated loggingService.ts to accept a message as any, because I like to log JSON objects to the console and they'll be expandable there. @thsparks I'm curious what you think of my changes.
I tried to update the name of BackendRequests.ts --> backendRequests.ts, but I'm unsure if it worked.

I've temp renamed BackendRequests.ts -> ackendRequests.ts. Will fix it in the next PR.


CI: add regression testing with apisix:dev

Currently, we will use the latest version of APISIX for e2e testing to ensure the compatibility of APISIX Ingress and APISIX.
But we don't know about some of the latest changes in APISIX.
I suggest we add a scheduled job to use apisix:dev image for regression testing.
We used to use apisix:dev for e2e testing by default, but this way would affect our development experience, and sometimes we found that e2e failed, but it was actually just due to some changes in APISIX.

https://hub.docker.com/layers/apache/apisix/dev/images/sha256-d56ffe4f1722cb6ee2d779360bc93837a6d2f0953af77588993e54978709943d?context=explore

I wish to work on this issue. Kindly assign this to me.

#1721 has been merged. I will close this one. Thanks


Use dispatch instead of next (fix #153)

This might be a good idea to play the suffixed actions through the whole middleware stack instead of just the next actions. It could be a breaking change for some implementations though and the tests should reflect it.
Please add a test for this and I think it would be worth considering more pros and cons to this approach.

I like the idea of exploring this. @amaurymartiny, can you update the PR with tests and a description that explains why this change is useful?

Unfortunately I won't have time now to dig deeper into this. Maybe in July, but not before. So if one of you guys wants to investigate it might be better.

Alright, let's do this then: I'm going to close the PR and when you have time, @amaurymartiny, just reopen it and update the description with commentary on what this change will enable/fix.


WIP: Introducing the '--inject-output-values' flag

If implemented, this PR will...

Add 'Value' as an attribute of the output module
Add '--inject-output-values' to settings
Create a 'TerraformOutput' struct to unmarshal user inputted file into
Check if user file path input is valid
Inject values from 'terraform output > outputs.json' into outputs

Prerequisites
Put an x into the box(es) that apply:

[ ] This pull request fixes a bug.
[x ] This pull request adds a feature.
[ ] This pull request enhances existing functionality.
[ ] This pull request introduces breaking change.

For more information, see the Contributing Guide.
Description
This PR introduces the '--inject-output-values' flag, which injects output values from the JSON generated by the terraform output --json command into terraform-docs various outputs.
Checklist
Put an x into all boxes that apply:

[ ] I have read the Contributing Guidelines.

Tests

[ ] I have added tests to cover my changes.
[ ] All tests pass when I run make test.

Documentation

[X] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Code Style

[ ] My code follows the code style of this project.

Merged upstream :tada:


Ensemble function

Dear authors,
Thanks for your work. And I want to know where is the code of the integrated function? Is it convBBOXCOCO.py?
Is it to merge the prediction frames of the two networks together, use different weights to predict the results of different networks, and then pass the NMS?
Thanks for your reply.

Hello friend, have you resolved your problem?


Move from bionic to focal

This PR updates the K docker image used in CI from ubuntu 18.04 to 20.04; this is in preparation for the 18.04 image being deprecated.

I am aware of what is causing the cabal tests to fail and am uploading a fix as soon as I can verify the fix locally.

Thanks @JKTKops!


api: accept enclave-cc runtimeName

Currently, only kata is allowed as runtimeName in the API. The field is copied to CcRuntimeStatus but other than that it's unused.
The first non-kata runtime is nicknamed 'enclave-cc'. Add support for it as a runtimeName identifier.

Agree to add "enclave-cc" here, since all the CoCo sub projects need to share the same general operator.
But how about this file: deploy.yaml.
In current CoCo operator installation document uses below command to deploy the operator first:
kubectl apply -f https://raw.githubusercontent.com/confidential-containers/operator/main/deploy/deploy.yaml
I suppose the new runtime enum name("enclave-cc") should take effect there also.
One more concern is on the ccruntime.yaml. Also in the above INSTALL.md, we tell customer to use the operator repo's ccruntime.yaml to create the new CR, but currently in this file, the runtime class definition are all Kata specific. So where should enclave-cc' ccruntime.yaml be located?

One more concern is on the ccruntime.yaml. Also in the above INSTALL.md, we tell customer to use the operator repo's ccruntime.yaml to create the new CR, but currently in this file, the runtime class definition are all Kata specific. So where should enclave-cc' ccruntime.yaml be located?

you can create a new ccruntime yaml eg. ccruntime-enclave-cc.yaml and update the documentation

Agree to add "enclave-cc" here, since all the CoCo sub projects need to share the same general operator. But how about this file: deploy.yaml. In current CoCo operator installation document uses below command to deploy the operator first: kubectl apply -f https://raw.githubusercontent.com/confidential-containers/operator/main/deploy/deploy.yaml
I suppose the new runtime enum name("enclave-cc") should take effect there also.
One more concern is on the ccruntime.yaml. Also in the above INSTALL.md, we tell customer to use the operator repo's ccruntime.yaml to create the new CR, but currently in this file, the runtime class definition are all Kata specific. So where should enclave-cc' ccruntime.yaml be located?

right. make manifests bundle generate does not seem to be enough. I need figure our how it's done.

deploy the operator first: kubectl apply -f https://raw.githubusercontent.com/confidential-containers/operator/main/deploy/deploy.yaml
I suppose the new runtime enum name("enclave-cc") should take effect there also.

right. make manifests bundle generate does not seem to be enough. I need figure our how it's done.

 // NOTE: json tags are required.  Any new fields you add must have json tags for the fields to be serialized.

-// +kubebuilder:validation:Enum=kata
+// +kubebuilder:validation:Enum=kata;enclave-cc
 type CcRuntimeName string

 const (
        // Kata
        KataCcRuntime CcRuntimeName = "kata"

+       EnclaveCcRuntime CcRuntimeName = "enclave-cc"
+
        // Other Cc Runtime
 )

and then make generate && make bundle should update the manifests

and then make generate && make bundle should update the manifests

@bpradipt It does not seem to touch deploy.yaml. Do you want be to keep these unused consts?

you can create a new ccruntime yaml eg. ccruntime-enclave-cc.yaml and update the documentation

Agree, this means we still need to change document in this repo. Also, I am thinking about if this file change needed?

and then make generate && make bundle should update the manifests

@bpradipt It does not seem to touch deploy.yaml. Do you want be to keep these unused consts?

Ah yes.. The deploy.yaml was created as a convenience all-in-one single yaml file for deployment using kubectl instead of running make deploy IMG=quay.io/confidential-containers/operator:latest.
I used the following changes to the Makefile to create the deploy.yaml. May be we can add it as a separate build target.
 git diff Makefile
diff --git a/Makefile b/Makefile
index e77154e..3be6e7f 100644
--- a/Makefile
+++ b/Makefile
@@ -140,7 +140,7 @@ uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified
 .PHONY: deploy
 deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config.
        cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
-       $(KUSTOMIZE) build config/default | kubectl apply -f -
+       $(KUSTOMIZE) build config/default | tee deploy/deploy.yaml | kubectl apply -f -

Do you want be to keep these unused consts?

We don't seem to be using it so it's fine to remove it for now imho.

/test-kata-qemu

@arronwy can you please re-run the TDX CI for this PR ?

/test-kata-qemu-tdx

rebased on force pushed


[Bug]: Part of downloaded video cannot decrypted and merged

What happened?
Part of video cannot be decrypted and merged as below.
It is personal plan courses.   and not just this course, other personal plan courses have same issue.
I am pretty sure the Key is right.

I've test two courses all have this issue. :
https://www.udemy.com/course/build-undetectable-malware-using-c-language-ethical-hacking/
https://www.udemy.com/course/kali-linux-hacking/learn/
Expected Result
decrypted - downloaded video.
Branch
feat-selenium
What operating systems are you seeing the problem on?
Windows
Relevant log output
Status Legend:
(OK):download completed.
[02:19:13] [udemy-downloader] [process_caption:1495] INFO:     > Converting caption to SRT format...
[02:19:13] [udemy-downloader] [process_caption:1497] INFO:     > Caption conversion complete.
[02:19:13] [udemy-downloader] [parse_new:1586] INFO:   > Processing lecture 4 of 23
[02:19:13] [udemy-downloader] [parse_new:1610] INFO: Processing 1 caption(s)...
[02:19:13] [udemy-downloader] [process_caption:1482] INFO:     >  Downloading caption: '004 How To Make An .EXE Transform Into Any Other File Type (.jpg,
.pdf, .mp4 ... )_en.vtt'

10/13 14:19:13 [NOTICE] Downloading 1 item(s)

10/13 14:19:13 [ERROR] Exception caught
Exception: [DefaultBtProgressInfoFile.cc:211] errorCode=1 Failed to write into the segment file E:/Udemy/Tool/udemy-downloader-feat-selenium/out_dir/build-undetectable-malware-using-c-language-ethical-hacking/01 - Introduction & Welcome To Hacking With C!/004 How To Make An .EXE Transform Into Any Other File Type (.jpg, .pdf, .mp4 ... )_en.vtt.aria2

10/13 14:19:13 [NOTICE] Download complete: E:/Udemy/Tool/udemy-downloader-feat-selenium/out_dir/build-undetectable-malware-using-c-language-ethical-hacking/01 - Introduction & Welcome To Hacking With C!/004 How To Make An .EXE Transform Into Any Other File Type (.jpg, .pdf, .mp4 ... )_en.vtt

Download Results:
gid   |stat|avg speed  |path/URI
======+====+===========+=======================================================
37621e|OK  |   8.7MiB/s|E:/Udemy/Tool/udemy-downloader-feat-selenium/out_dir/build-undetectable-malware-using-c-language-ethical-hacking/01 - Introduction & Welcome To Hacking With C!/004 How To Make An .EXE Transform Into Any Other File Type (.jpg, .pdf, .mp4 ... )_en.vtt

Status Legend:
(OK):download completed.

Other information
No response

This is simply an issue with the file path being too long. reduce the path length, and use the --id-as-course-name option


spinning animation

Does Iconify come with a way to make an icon actively spin? If not then it might be worth considering.
I'm migrating one of our sites to Iconify, one of the most occurring icons is a spinning mdi-loading, using just materialdesignicons you would achieve it with mdi-spin:

My current implementation with Iconify is the following, which of course is fine on it's own:
.spin {
  animation-name: spin;
  animation-duration: 2000ms;
  animation-iteration-count: infinite;
  animation-timing-function: linear;
}
@keyframes spin {
  from {
    transform:rotate(0deg);
  }
  to {
    transform:rotate(360deg);
  }
}

No, Iconify only provides icons. Any custom css is up to user. The only css it injects is this:
span.iconify, i.iconify, iconify-icon { display: inline-block; width: 1em; }

That causes placeholders to have 1em width, so text around icon doesn't suddenly move when icon loads. Usually its not an issue at all, but if computer is slow it could be noticed, so that css prevents it.
All icons keep custom attributes and classes, so you can keep that "spin" class in your css and add it to list of classes for icon you want to spin:

Thanks :)


Problems with abf import via AxonIO

We are currently trying to import .abf files using io.AxonIO. While the loading of the file appears to work correctly, subsequent operations all return errors. The .abf version is 1026.00. Our code is as follows:
from neo import io
import os
os.chdir('/somedir/') # Directory where file is located
r = io.AxonIO(filename='recording.abf')
type(r)
# return: 'neo.io.axonio.AxonIO'
r.read()
# return: Traceback + 'TypeError: 'str' object cannot be interpreted as an integer'
'r.read_segment()
# return: 'AssertionError: This type is not supported by this file format for reading'
If necessary, we can provide an .abf recording for troubleshooting.

AxonIO.readable_objects = [Block] so AxonIo.read_segment() is not implmented so the second error is natural.
r.read() should return a list of Block. Are you on python3 or python2.
Could you send me the abf file ?

Using Python 3.
Abf file: https://mega.nz/#!JZYUCbwT
!_2eJj3rIWCI30qtAuX7uzT0u7rCDzcoPvhSqAhSg8xI
Thanks for your help.
Kind regards,
Luke
On 28 October 2015 at 09:48, Garcia Samuel<EMAIL_ADDRESS>wrote:

AxonIO.readable_objects = [Block] so AxonIo.read_segment() is not
implmented so the second error is natural.
r.read() should return a list of Block. Are you on python3 or python2.
Could you send me the abf file ?
—
Reply to this email directly or view it on GitHub
https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151768504
.

The file is c2_bwnoise.h5.
Is it an error ?
Le 28/10/2015 13:04, Luke Edward Rogerson a écrit :

Using Python 3.
Abf file: https://mega.nz/#!JZYUCbwT
!_2eJj3rIWCI30qtAuX7uzT0u7rCDzcoPvhSqAhSg8xI
Thanks for your help.
Kind regards,
Luke
On 28 October 2015 at 09:48, Garcia Samuel<EMAIL_ADDRESS>wrote:

AxonIO.readable_objects = [Block] so AxonIo.read_segment() is not
implmented so the second error is natural.
r.read() should return a list of Block. Are you on python3 or python2.
Could you send me the abf file ?
—
Reply to this email directly or view it on GitHub

https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151768504

.

—
Reply to this email directly or view it on GitHub
https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151822921.

Error on my part. Correct link:
https://mega.nz/#!JNhyGAxa!ERf1u2-IbdYuIHvpwJsGAkECxMpZbw7M16YgvDBI09g
Kind regards,
Luke
On 28 October 2015 at 13:12, Garcia Samuel<EMAIL_ADDRESS>wrote:

The file is c2_bwnoise.h5.
Is it an error ?
Le 28/10/2015 13:04, Luke Edward Rogerson a écrit :

Using Python 3.
Abf file: https://mega.nz/#!JZYUCbwT
!_2eJj3rIWCI30qtAuX7uzT0u7rCDzcoPvhSqAhSg8xI
Thanks for your help.
Kind regards,
Luke
On 28 October 2015 at 09:48, Garcia Samuel<EMAIL_ADDRESS>wrote:

AxonIO.readable_objects = [Block] so AxonIo.read_segment() is not
implmented so the second error is natural.
r.read() should return a list of Block. Are you on python3 or python2.
Could you send me the abf file ?
—
Reply to this email directly or view it on GitHub

<
https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151768504

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151822921
.

—
Reply to this email directly or view it on GitHub
https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151825867
.

Hi again,
it works for both in python2 and python3
try this script please:
import neo
import numpy as np
bl= neo.AxonIO(filename = 'C2_BG.abf').read()[0]
for seg in bl.segments:
print(seg)
for ana in seg.analogsignals:
print('  ', ana, ana.size, ana.max(), ana.min(), ana.times[0],
ana.times[-1], ana.sampling_rate)
Note that recetly I push something on github for axonio
https://github.com/NeuralEnsemble/python-neo/pull/209
Could you re install python-neo from lastest git master ?
Samuel
Le 28/10/2015 13:26, Luke Edward Rogerson a écrit :

Error on my part. Correct link:
https://mega.nz/#!JNhyGAxa!ERf1u2-IbdYuIHvpwJsGAkECxMpZbw7M16YgvDBI09g
Kind regards,
Luke
On 28 October 2015 at 13:12, Garcia Samuel<EMAIL_ADDRESS>wrote:

The file is c2_bwnoise.h5.
Is it an error ?
Le 28/10/2015 13:04, Luke Edward Rogerson a écrit :

Using Python 3.
Abf file: https://mega.nz/#!JZYUCbwT
!_2eJj3rIWCI30qtAuX7uzT0u7rCDzcoPvhSqAhSg8xI
Thanks for your help.
Kind regards,
Luke
On 28 October 2015 at 09:48, Garcia Samuel<EMAIL_ADDRESS>wrote:

AxonIO.readable_objects = [Block] so AxonIo.read_segment() is not
implmented so the second error is natural.
r.read() should return a list of Block. Are you on python3 or
python2.
Could you send me the abf file ?
—
Reply to this email directly or view it on GitHub

<

https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151768504

.

—
Reply to this email directly or view it on GitHub
<

https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151822921

.

—
Reply to this email directly or view it on GitHub

https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151825867

.

—
Reply to this email directly or view it on GitHub
https://github.com/NeuralEnsemble/python-neo/issues/219#issuecomment-151828110.

Hi, I seem to have a related error in python 3: testing the doc example for AxonIO, I ran into the following error
/home/me/.local/lib/python3.5/site-packages/neo/io/axonio.py in read_block(self, lazy, cascade)
    155
    156
--> 157         header = self.read_header()
    158         version = header['fFileVersionNumber']
    159

/home/me/.local/lib/python3.5/site-packages/neo/io/axonio.py in read_header(self)
    340         that contain more information.
    341         """
--> 342         fid = struct_file(self.filename,'rb')
    343
    344         # version

TypeError: 'str' object cannot be interpreted as an integer

which comes from the bl = r.read_block(lazy=False, cascade=True) line.
Lastest git master does not correct this error.


Make chart_test.go idempotent

Due to the fact that in the charts/redpanda/Chart.yaml file the version needs to be bumped every time when Redpanda helm chart release happen, the charts/redpanda/Chart.lock in local environment will change over time. To make snapshot testing idempotent the helm.sh/chart label is overwritten during helm templating. During implementation of that feature it was discovered that merging of the commonLabels variable is wrongly used in FullLabels and the statefulset-pod-labels named template did not handle clash in user provided commonLabels for the following labels:

app.kubernetes.io/name
app.kubernetes.io/instance
app.kubernetes.io/component

As the development of the test suite revealed that current merge function, that uses built-in maps package, does not work as the sprig equivalent, the helmette package tests where extended with the same test case as with sprig.
The gotohelm test suite also changed, so that any implementation of function that will be transpiled to helm template would not change the values in the dot context. During the course of merge function implementation the values.commonLabels was changed, so potentially other (next) usage of commonLabels would be malformed.
https://github.com/Masterminds/sprig/blob/581758eb7d96ae4d113649668fa96acc74d46e7f/docs/dicts.md?plain=1#L125-L182
https://github.com/Masterminds/sprig/blob/581758eb7d96ae4d113649668fa96acc74d46e7f/dict_test.go#L142-L197

Ah, sorry I thought I added a commit message and marked this as non-draft but https://github.com/redpanda-data/helm-charts/pull/1112 should achieve a similar effect (Though it'll make automatic version bumps stop working for a bit).
The two PRs are compatible either way. I think I'm leaning towards your strategy as we'll reduce the total churn in the generated files. Can we change the version to something like VERSIONPLACEHOLDER in this PR so it's obvious that it's a placeholder value? If it needs to be semver maybe we set it to something like 9.9.9?

Internally we agree that release process needs to change and Chart.yaml would have placeholders for version and appVersion. That way the labels would be stable for chart_test suite.


Stop Recording is not working in functional components

Version of react-native-audio-recorder-player
"react-native-audio-recorder-player": "^2.6.0-rc3",
Platforms you faced the error (IOS or Android or both?)
IOS
onStopRecord = async () => {
const result = await audioRecorderPlayer.stopRecorder();
audioRecorderPlayer.removeRecordBackListener();
setRecordSecs(0);
console.log(result);
};
Expected behavior
Stop recording
Actual behavior
when I change the class based comp to functional
onStopRecord is not working any more and shows already stops in console
Steps to reprodue the behabior

Version of react-native-audio-recorder-player
"react-native-audio-recorder-player": "^2.6.0-rc3",
Platforms you faced the error (IOS or Android or both?)
IOS
onStopRecord = async () => {
const result = await audioRecorderPlayer.stopRecorder();
audioRecorderPlayer.removeRecordBackListener();
setRecordSecs(0);
console.log(result);
};
Expected behavior
Stop recording
Actual behavior
when I change the class based comp to functional
onStopRecord is not working any more and shows already stops in console
Steps to reprodue the behabior

Move
const audioRecorderPlayer = new AudioRecorderPlayer();

in useEffect or move it outside the component


[plog] Update to 1.1.8

What does your PR fix?

Updates plog to 1.1.8.

Which triplets are supported/not supported? Have you updated the CI baseline?

all

Does your PR follow the maintainer guide?

yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

Thanks for the update!


test_data/system_tests missing from repo

A lot of tests refer to files in test_data/system_tests, which is missing from master branch.

Hi, in the README, there is a section reproducing-data-analyses-from-the-paper. There you are instructed how to download these files. Let me know in case there is any problem


[Design] Preparations for contacts page design

Preliminaries for #309

@brenzi did minor cleanup, can be merged IMO, but you need to approve


Suggestion:  Add compile time check for computed method names, and automatically assigned string constant

Typescriipt allows you to define computed names for methods, which is very useful:
const country_change_handler = 'country_change_handler';
export class FlagIcon extends HTMLElement {
     [country_change_handler](newVal: string, oldVal: string){
        //country change handler
    }
}

However, using this "dynamic" method is less convenient than using a standard method -- no intellisense / compile time checks when invoking the method on an instance object.
     const fi = new FlagIcon();
     fi.country_change_handler(); //doesn't compile.  Typing fi. gives no dropdown / autocomplete.

Proposal:

Define a special type that echos the name of the constant.

i.e.:
    const country_change_handler : StringConstant; // say

Typescript would emit:
    const country_change_handler = 'country_change_handler'

References to this constant, within Typescript, would be treated as a non null string.
Of course, this has the benefit of making the constant match the actual string, even after refactoring.

For such types, Typescript would give intellisense / compile time checks to computed properties:

const country_change_handler: StringConstant;
export class FlagIcon extends HTMLElement {
     [country_change_handler](newVal: string, oldVal: string){
        //country change handler
    }
}

const fi = new FlagIcon();
fi.country_change_handler(); //compiles

duplicate of https://github.com/Microsoft/TypeScript/issues/5579?

I can sort of see how they are related, trying to accomplish similar goal.  With 5579, it's not clear to me whether you would be able to get autocomplete support when you type instanceObject followed by a dot , or if you have to use brackets and refer to a symbol that may not match the symbol in the class.  Perhaps I'm not grokking where that's spelled out.

With 5579, it's not clear to me whether you would be able to get autocomplete support when you type instanceObject followed by a dot , or if you have to use brackets and refer to a symbol that may not match the symbol in the class.

once the type system can tell what this property is, completion, find all refs, quick info, etc.. all should work normally.

I guess I would like to see the final suggestion explicitly for how 5579 would work, for me to agree that what I'm proposing is a duplicate.  As it stands 5579 looks like a jumble of different suggestions, with no accepted proposal fully fleshed out, in a way that appears to me to be a duplicate of this suggestion.

I guess you can trust me on this one :) 5579 tracks making the compiler understand the computed properties in types if their expression is a constant expression. Once the type system knew about that, things just fall in place and they behave like normal properties. Unless there is a different request, I would close this in favor of 5579.

Okay, if you say so, feel free to close ;-).

thanks.


Change the color pallet of navbar

What is the change?
Improve the Color pallet of the navbar used the shades of Green from the following colour palette

And Changed the name from "Daily Journal" => "Quotidian Blogs" Quotadian is a synonym of Daily and bit of attractive.

/reviewed

/gssoc/

@Pranav016  please review and merge the PR

I think if the color of the whole navbar changes then that would be cool..
Also I think a better color palate can be chosen, I like the color you chose for this, just a little brighter would do.
Change base branch to develop
I think the headline isn't very catchy/ attractive Quotidian BLOG'S
I think a smaller word and either both words capitalized or only first letter looks subtle. Like DAILY JOURNAL or Daily Journal
Resolve merge conflicts

Change base branch to develop as mentioned here. Take help from this on how to change

Name it ALPHAVIO BLOGS.
Otherwise looks good to merge.

How to change base branch to develop ?

I think if the color of the whole navbar changes then that would be cool..
Also I think a better color palate can be chosen, I like the color you chose for this, just a little brighter would do.
Change base branch to develop
I think the headline isn't very catchy/ attractive Quotidian BLOG'S
I think a smaller word and either both words capitalized or only first letter looks subtle. Like DAILY JOURNAL or Daily Journal
Resolve merge conflicts

Change base branch to develop as mentioned here. Take help from this on how to change

Name it ALPHAVIO BLOGS.
Otherwise looks good to merge.

@hrushikesh-git You can refer to the image attached above. You need to click on the button and then select develop.

Sir I have made the things correct please look into it and guide me

Sir I have made the things correct please look into it and guide me

Hi @hrushikesh-git .Can you attach the new screenshot of the navbar so I can have a look at the color?

The color e same as above but the title is Changed according to the instruction to  ALPHAVIO BLOGS. The title is changed

The color is same as above but the title is Changed according to the instruction to ALPHAVIO BLOGS. The title is changed

everytime I solve one conflict a new conflict arise and I this time conflict is inside the CSS where I have changed the navbar colors I am not understanding what to do now

The color is same as above but the title is Changed according to the instruction to ALPHAVIO BLOGS. The title is changed

everytime I solve one conflict a new conflict arise and I this time conflict is inside the CSS where I have changed the navbar colors I am not understanding what to do now

Don't worry I'll fix it.

Hey @hrushikesh-git! Thanks for contributing! Actually, there have been some major changes to the code base to fix the bug that was in production also, there are still some more changes that need to be done therefore please pull the updated code tomorrow and make a new pr according to that else there will be a lot of merge conflicts.


Drop remove subcommand

Removes remove.go along with all the test files and harness tests.
Fixes #481

easy enough, though I want to pump the breaks on this one for a second - just enough for a pass over the CLI help text to make sure there are no references to anything like this command's behavior (removing items from the manifest), either implicit or explicit.

Rebase for feature branch integration, please 😄

@sdboyer rebased onto current master :)

I never actually made the feature branch for this, and I'm likely not to do so, as I'd rather just merge these directly.
So...one more rebase? 😄

rebased! 😁

excellent - thank you 😄


rocmPackages.hsa-amd-aqlprofile-bin: 5.7.0 -> 5.7.1

Tracking: #197885
Made a nice little update script for this finally.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Tried the update script via nix-update -u ..., and it works. The ELF binaries in results/rocmPackages.hsa-amd-aqlprofile-bin/lib/ however are not marked executable.

Didn't notice that, thank you for noting it!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2816

Result of nixpkgs-review pr 262750 run on x86_64-linux 1

2 packages built:

rocmPackages.hsa-amd-aqlprofile-bin (rocmPackages_5.hsa-amd-aqlprofile-bin)
rocmPackages.rocprofiler (rocmPackages_5.rocprofiler)


Plugin being maintained?

Just wanted to check in and firstly say thanks for all the work on this plugin, then secondly see what the plans for this plugin are, and whether it's still being maintained? Last update was a year ago, and there's an open issue about it not working on Craft 2.6. I love the idea and an audit log is REALLY useful on some client sites. If not, does anyone know of any alternatives or someone who might take over?

I'm interested in seeing this ported to upcoming Craft 3 version. @boboldehampsink do you think it's in the pipeline? Can I help somehow?

Hey. Currently I don't really have time to maintain it. Also, with Craft 3 coming up, there's little chance I will invest more time. A Craft 3 version might be developed once Craft 3 is out.


0.2.3 - UART and stdio integrations

Need to test out a picotool workflow: https://github.com/vkottler/config/pull/12.


jQuery migrate warning: jQuery.fn.attr('selected') might use property instead of attribute

We want to remove jQuery migrate from our app, but the only thing that remains is this warning:
"jQuery.fn.attr('selected') might use property instead of attribute" coming from line 622 of "bootstrap-select.js".
if ($opt.attr('selected') === undefined && this.$element.data('selected') === undefined) {
    titleOption.selected = true;
}

This is similar to this issue here: https://github.com/silviomoreto/bootstrap-select/issues/94
Is there any reason why 'attr' is used here instead of 'prop'?
NPM packages:
"bootstrap-select": "1.12.4"
"jquery": "3.2.1"
"jquery-migrate": "1.4.1"

attr retrieves/sets the actual selected attribute (i.e. the defaultSelected value). This attribute determines the initial selected state of the option. prop retrieves/sets selected "internally." Basically, that line of code is checking to see if the option was set to be selected manually in the DOM e.g. <option value="1" selected></option> vs being set programmatically via JS. As it's just a warning, I'd say it's safe to be ignored.

That makes sense. Thanks for clearing that up.


⚠ Fetchers has degraded performance

In 8001418, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 289 ms

Resolved: Fetchers performance has improved in 9cf9e88.


Issues

Hey thanks for sharing!
Just tried it and i have a few observations.
The photo taken inside the square, is not the same as the photo saved. I think the bottom of the saved photo needs a bit of cropping.
If the phone goes into landscape mode the result picture looks kinda streched.
Front camera, try flipping the image. By default the image produced looks weird, you need to invert it

Thanks for your feedbacks.
The cropping issue is now solved in the latest commit.
I have set the library to only in Portrait. I know this is not the best solution, but due to the time constraint I have, following the behaviour of most other camera apps seems to be the next logical step for me to take.
Same goes to using the front camera, the camera apps that I have (nexus 5 & s2) are showing the same inverted image. Hence, I keep it that way to stay in line with what the user might expect.


chore(consensus): move the todo on ProposalFin to Matan

This change is

#2664  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Introduce Search by workitem number

fixed https://github.com/fabric8-services/fabric8-wit/pull/1999


InAppMessaging is displayed even if specified app's version changes after auto-update

InAppMessaging is displayed after the iOS app is auto updated.
The trigger conditions are based on the previous version of the app.
Expected result is that the in-app message cannot be displayed.
[READ] Step 1: Are you in the right place?
Yes
[REQUIRED] Step 2: Describe your environment
Xcode version: 10.1
Firebase SDK version: 5.14
Firebase Component: InAppMessagingDisplay
Component version: 0.12.2
[REQUIRED] Step 3: Describe the problem
Steps to reproduce:

login to web console (https://console.firebase.google.com/)

Grow > In-App Messaging, select

Target > App(iOS), and "Version" (https://console.firebase.google.com/project/${PROJCET ID}/inappmessaging/compose)
ex) this settings "include" version. 3.3.6

Scheduling : "Now" and "No end date"

Trigger : "app_lunch"

Publish, campain

the app's (version. 3.3.6) install and show In-App Messaging

the app's new version (version. 4.0.0) release / TestFlight release.

my iPhone "Settings" appli, iTunes Store & App Store > Updates "ON"

the app's updated (version. 4.0.0)

the app's lunch, show In-App Messaging

@christibbs can you update this issue?

Couldn't actually reproduce this.


ga_faster_rcnn._coco_1x.py问题

Hello, I would like to consult why I run ga_faster_rcnn framework without results

你好，我想咨询一下，为什么我运行ga_faster_rcnn框架没有结果
Hello, I would like to consult why I run ga_faster_rcnn framework without results

Could you follow the issue template to report what command did you use and what dataset did you run on?

More details, please.


rfctr: skip CheckBox elements during chunking

CheckBox elements get special treatment during chunking. CheckBox does not derive from Text and can contribute no text to a chunk. It is considered "non-combinable" and so is emitted as-is as a chunk of its own. A consequence of this is it breaks an otherwise contiguous chunk into two wherever it occurs.
This is problematic, but becomes much more so when overlap is introduced. Each chunk accepts a "tail" text fragment from its preceding element and contributes its own tail fragment to the next chunk. These tails represent the "overlap" between chunks. However, a non-text chunk can neither accept nor provide a tail-fragment and so interrupts the overlap. None of the possible solutions are terrific.
Give Element a .text attribute such that all elements have a .text attribute, even though its value is the empty-string for element-types such as CheckBox and PageBreak which inherently have no text. As a consequence, several cast() wrappers are no longer required to satisfy strict type-checking.
This also allows a CheckBox element to be combined with Text subtypes during chunking, essentially the same way PageBreak is, contributing no text to the chunk.
Also, remove the _NonTextSection object which previously wrapped a CheckBox element during pre-chunking as it is no longer required.

Thanks @christinestraub! :)


Remove eval()

Remove eval() for security reasons

Coverage remained the same at 100.0% when pulling 26f79b2c5cd87575382525cbf08373cdcb8873a6 on MyCryptoHQ:remove-eval into 65b3898c4eecc919477dce9c6e41bb0be1b65219 on emn178:master.

Coverage remained the same at 100.0% when pulling 26f79b2c5cd87575382525cbf08373cdcb8873a6 on MyCryptoHQ:remove-eval into 65b3898c4eecc919477dce9c6e41bb0be1b65219 on emn178:master.

removed in v0.7.0


Add demo for Junit 5 to check exception absence/presence

Please add some Junit 5 demo to check exceptions:

assertAll()
Asserts that all supplied executables do not throw exceptions.

assertDoesNotThrow()
Asserts that execution of the supplied executable/supplier does not throw any kind of exception.

assertThrows()
Asserts that execution of the supplied executable throws an exception of the expectedType and returns the exception.

See also : https://stackoverflow.com/a/51768474/938111

It's easy to say that eight months after the fact (so sorry!), but have a look at AssertTest - it contains most of what you're asking. Not, assertDoesNotThrow, though, because I find it weird.


Now scale throws error for docker deployments in BUILDING status

Now scale cannot be called immediately after deployment (e.g. inside a script),
if attempted the following error occurs:
now scale --debug https://upload-service-aqlyobpave.now.sh 1

[debug] /list: 964.816ms
Deployment is currently in 0 replicas, preparing deployment for scaling...
[debug] #1 POST /deployments/zI5gXiMWlSkcLqMIiHtohh7G/instances: 891.363ms
Error! An unexpected error occurred

Same thing happens if alias is called for a new instance of a pre-scaled deployment:
now alias content-service-ktesmqrzja.now.sh https://content-service.xxxxx

Alias content-service.xxxxx points to content-service-aekxwisoip.now.sh (1 instances)
Scaling content-service-ktesmqrzja.now.sh to 1 instances atomically
Error! An unexpected error occurred

@OlliV @jamo Any ideas?

I'd say it's a feature. You should query it's state and scale it only after its status is set to READY.

Perhaps I don't understand, but I'm curious why should this be a feature?
Wouldn't it be more sensible to let 'now' know that you want to scale, and 'now scale' deal with it internally?
Our use case is to run the whole deployment from a script (and bunch of other stuff), and it would be much easier to simply call 'now scale' right after deployment (without waiting for deployment to finish), the same way 'now alias' works. Any thoughts on how to accomplish this?

Unless I misunderstand, this logic prevents a CI from auto-aliasing on a scaled instance, no? Running now immediately followed by now alias is always going to fail?

@OlliV is there any update on this? we've removed any scaling configuration from our staging build so that we can now then now alias in our CI service for staging builds, but knowing that our server may spin down after inactivity, can't do the same for production. is there a solution or any foreseeable changes to support this?

now alias will probably work just fine after running now but why do you want to do it like that? What if the build stage fails, what's the use case for an aliased and scaled deployment that fails to even start?


Remove alert groups

/v1/alert/groups has been removed
https://github.com/prometheus/alertmanager/pull/1525
I'm unsure if its available for v2. Honestly we need to update to support the v2 api anyway

https://github.com/ABORGT/PylertAlertManager/blob/master/alertmanager/alertmanager.py#L335
And the corresponding test
https://github.com/ABORGT/PylertAlertManager/blob/master/tests/alertmanager_test.py#L45-L47

Hello, how do I remove an alert that I no longer need? There's a post alert method but I can't see how to delete alerts. Thanks :)

/v1/alert/groups has been removed prometheus/alertmanager#1525
I'm unsure if its available for v2. Honestly we need to update to support the v2 api anyway

👋 api v2 #38 (+ single silence get fix)


Chemical Wiki Descriptions, Recipe Tweaks & Effect Tweaks

About the PR
o Changes almost all wordings in the chemical wiki section to have up-to-date, consistent and relevant information.
o Tweaked chemical recipes, namely:

All plasma catalysts were reduced from 5u to 1u
Epinephrine no longer requires diethylamine, creates 5u epinephrine
Dexalin requires 2u hydrogen,1u oxygen, 1u plasma catalyst, creates 3u dexalin
Lexorin requires 1u heartbreaker toxin, 1u fluorine, 1u plasma, creates 3u lexorin
Ultravasculine requires 1u dylovene, 1u sodium, 1u plasma catalyst
Sigynate requires 1u iodine, 1u kelotane, 1u sugar, creates 3u sigynate
Phenol requires 1u oxygen, 1u hydrogen, 1u carbon
Diphenymethylamine requires 1u ethyloxyephedrine, 1u phenol, 1u sodium carbonate, makes 3u diphenylmethylamine
Ammonia reaction creates 3u instead of 4u
Sodium carbonate no longer requires ammonia, creates 3u sodium carbonate

o  Tweaked chemical effects, namely:

Bicaridine no longer causes drunkness
Dermaline no longer causes drunkness on slight overdose
Nocturine no longer causes poison damage on overdose (60u to deal 2 poison per second are you real)
Sigynate cures 2 caustic a second instead of 6

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Alekshhh

tweak: The chemical page of the wiki has been heavily reworded, and a few chemicals had their recipes tweaked and effects changed a little

Great PR. This has been needed for a while now, thank you. I don't have anything negative to comment on, everything here is good.
...fantastic licoxide description btw

if anyone has suggestions for desc recipes or effects lemme know since I already have it open

o Tweaked chemical effects, namely:
* Bicaridine no longer causes drunkness

* Dermaline no longer causes drunkness on slight overdose

keep both of these

@Alekshhh You coming back to this? (also you committed the engine)

FUCK

I'll prob just make a new one with only the wiki tweaks and recipe tweaks


(PUP-7222) Add RubyMethod annotation and let RubyGenerator act on it

This PR adds the Annotation type RubyMethod. It can be used on derived Object attributes and on Object functions. The annotation has two attributes. body which is mandatory and parameters which is optional and only indended for function annotations (needed since we don't have a Callable that uses named parameters).

CLA signed by all contributors.


initialPos -> initialPosition

This was a typo

[x] fixes #427
[x] fixes #338

Docs Build status updates of commit 23a6261:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/customize-settings/startup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update yml issues (->main, ->cname)

The action won't run since it uses master not main. And I believe the CNAME should be the user's own.

the cname key is optional btw if you're using a sub-path (example.com/my-dendron)


'noindex'  meta tag in redirect pages and SEO results

I am moving my old site pages to the new domain address. To redirect (301) old pages to new pages, I am using redirect_to: in the YAML front matter of old pages.
The redirect is working great, but it adding noindex meta tag in the old pages. Due to this, my old pages are not indexed and I lost the old page from google search results. It caused a significant reduction in web traffic to my new website. When I checked google search console, it says No: 'noindex' detected in 'robots' meta tag.
My new domain pages are not also showing up in google search results. I need to keep old pages in google search results until it is replaced by new pages without losing google ranking. As per google docs, it says keep the "Keep the redirects for as long as possible, and consider keeping them indefinitely".
Please, let me know how can I remove noindex meta tag and keep the old page in google search results until it is replaced by a new page. Thank you.

I'm running into this same problem. Would be nice to be able to configure/disable this

I'm running into this same problem. Would be nice to be able to configure/disable this

@ChrisHammond
Yes, the developer should check this issue and fix it. As a workaround, you can create a new layout in Jekyll (under _layout folder) for redirect pages and remove the noindex meta tag.  It helped me a lot and successfully replaced the old pages with new pages on google search results.

@ChrisHammond
Yes, the developer should check this issue and fix it. As a workaround, you can create a new layout in Jekyll (under _layout folder) for redirect pages and remove the noindex meta tag.  It helped me a lot and successfully replaced the old pages with new pages on google search results.

@reneshbedre thank you I just remembered the layout fix as well and was coming back here to tell you the same thing :D

@reneshbedre thank you I just remembered the layout fix as well and was coming back here to tell you the same thing :D


[Doc] add azure&gcs docs

Signed-off-by: amber-create<EMAIL_ADDRESS>What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

Fixes #
Problem Summary(Required):

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@@mergify backport branch-3.0

@mergify backport branch-3.0