Support PHP 8.0

This pull request add support for PHP 8.0 and bumps minimum version for package to 7.2 (instead of 7.1).

Bumps PHPUnit to ~8.0|~9.0.
Update all tests to be compatible with the new PHPUnit version.

Update the test to the expected behavior, that its thrown an exception instead of returning 0x0. (test/unit/OptionalQuantityFormatterTest.php).

The wrong preg_match with this test that broke the tests to PHP 8.0. The phpseclib returns empty when sending an invalid hexadecimal string using PHP 7 (making the old test pass),  but for PHP 8 it throws an exception (since the correct behavior is to send only hexadecimal strings).

Thanks, it works on php8.0.
I'll push another fix for the 7.4 / 7.4 CI.

@sc0Vu The tests were supposed to be passing. But in the "Cache composer packages" step it is fetching a cache of an incorrect composer.lock file.
The cache key is not taking into account the version of PHP being run in the test. I will add a commit that fixes this.
Explanation:
For PHP 7.x the guzzlehttp/guzzle requires symfony/deprecation-contracts in version ^2.2.
For PHP 8.x the guzzlehttp/guzzle requires symfony/deprecation-contracts in version ^3.0.
The test was getting a cached version of composer.lock that was generated by PHP 8, that locked  symfony/deprecation-contracts to version ^3.0, which consequently doesn't work in PHP 7.x.


Logger configuration in ServerSettings doesn't seem to change to change logger output.

Informations
Type | Version
Bug|4.0.5

Description
Modifying the logger configuration in ServerSettings does not do anything. I've tried this in v2.7 as well, and it wasn't working then either.
I'm setting up my server with a limited subset of logger requestfields (or even none at all), but it still prints the whole request. This is an issue because I'd like to keep the request body hidden.
backend_1        | [Node] [2018-02-21T02:34:47.439] [INFO ] [TSED] - settings.logger => { requestFields:
backend_1        | [Node]    [ 'reqId',
backend_1        | [Node]      'method',
backend_1        | [Node]      'url',
backend_1        | [Node]      'headers',
backend_1        | [Node]      'query',
backend_1        | [Node]      'params',
backend_1        | [Node]      'duration' ] }

body is missing, but when my server receives a request, it still prints `request.body.
backend_1        | [Node] [2018-02-21T02:34:48.506] [DEBUG] [TSED] - {
backend_1        | [Node]   "status": ...,
backend_1        | [Node]   "reqId": "1",
backend_1        | [Node]   "method": "POST",
backend_1        | [Node]   "url": ...
backend_1        | [Node]   "duration": ...
backend_1        | [Node]   "headers": ...
backend_1        | [Node]   "body": {
backend_1        | [Node]     "username": "...",
backend_1        | [Node]     "password": "...."
backend_1        | [Node]   },
backend_1        | [Node]   "query": {},
backend_1        | [Node]   "params": {}
backend_1        | [Node] }

Normally the log come from this class https://github.com/Romakita/ts-express-decorators/blob/master/src/common/mvc/components/LogIncomingRequestMiddleware.ts#L102-L110
I'll test if there is a problem. If you find a fix before me you can create a PR :)
See you,
Romain

Sorry about the late reply, but looks like that fixed it. I had set debug on the top level to false, too, though.

Hi @dennisli92
I confirm with v4.4.1, the configuration given previously works fine.
You can checkout this example https://github.com/Romakita/example-ts-express-decorator/tree/4.0.0/example-basic
I don't know in you case why the body is printed. Possible reasons are:

You have a overridden the LogIncomingRequestMiddleware,
You have a bad configuration on ServerSettings level.

Can you send me you ServerSettings Configuration ?
See you
Romain

oh oops, i dropped a word there. I meant to say that i had to also set debug in the top level to false, too. Here are my current ServerSettings:
@ServerSettings({
  rootDir,
  port: PORT,
  httpsPort: false,
  mount: {
    '/api/v1/': `${rootDir}/controllers/**/*.js`,
  },
  acceptMimes: ['application/json'],
  debug: false,
  componentsScan: [
    `${rootDir}/services/**/**.js`,
    `${rootDir}/middlewares/**/**.js`,
  ],
  logger: {
    debug: false,
    logRequest: true,
    requestFields: ['reqId', 'method', 'url', 'headers', 'query', 'params', 'duration'],
  },
})

This config works, but if I throw an error in the controller then it seems that the original request gets printed. e.g.
backend_1        | [Node] [2018-03-09T07:57:46.274] [ERROR] [TSED] - {
backend_1        | [Node]   "error": {
backend_1        | [Node]     "status": 500,
...
backend_1        | [Node]   },
backend_1        | [Node]   "body": {
backend_1        | [Node]     "username": "...",
backend_1        | [Node]     "password": "..."
backend_1        | [Node]   },

Hooo the log is an error level...
Actually the filters rules are applied only on the log level info.
Debug print all field and Error level too.
I think you need to override the LogIncomingRequestMiddleware. Here the documentation to do that:
https://romakita.github.io/ts-express-decorators/#/configuration?id=request-logger
See you,
Romain

@lwallent What do you think about filtering the console output when a request error is logged ?


Support for Metro DR (Sync Mode)

This commit adds support for Metro DR (sync mode)
The following changes are added -

Add DRType to MirrorPeer (sync/asyn)
Add annotation to ManagedClusterAddon for custom handlers
Changes to test to include DRType for MirrorPeer
Changes to spoke deployment and addition of handlers flag
Sync = S3ProfileSync only, Async = Just like before

https://issues.redhat.com/browse/RHSTOR-2542

Will add tests specific to sync mode soon . @umangachapagain Can you confirm if this approach works (annotation of MCA) i don't see any other proper way to tune the controllers at runtime


Test build is expected be unstable and gets failed if there is no specified test

Scenario:
https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_Sandbox/380/
BUILD_LIST=thirdparty_containers/lucene-solr
Target=lucene_solr_nightly_smoketest_OpenJ9
JDK_IMPL=openj9
JDK_VERSION=11
Under this scenario there actually is no 'make target' generated, which caused the build fail ( the test is not supposed to run against JDK11). This could also happens if test target is not spelled correctly and there is only testcase under the specified BUILD_LIST, subset and impl.
FYI @renfeiw

Close it as it is addressed.


Code lacks LICENSE file

Many thanks for uploading an implementation of  "Fitting B-spline Curves to Point Clouds
by Curvature-Based Squared Distance Minimization" on github.
Unfortunately, the code does not contain information about the licensing terms for reuse.
Can you please add a file LICENSE (e.g. a two clause BSD license, or what you prefer) to clarify whether modification and use of the code in a BSD or GPL licensed project is permitted?

No license often means public domain code.

Thanks, I add MIT license.


nixos/autorandr: added new KillMode

Prevents Udev Rule from killing processes started by autorandr
I did test it on my system and it did work (nixos-rebuild -I nixpkgs=$nixpkgs switch). I'm not entirely sure how to do the rest of the testing (is it applicable?).

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This is my first contribution, so let me know if there is anything else I need to do to get this merged!


Change gather for gather_for_metrics in eval.

Otherwise the assert at L259 breaks. It's also the thing to do to get more accurate metrics.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Depend upon libbinaryen v111.1.0 and widen the jsoo range

When https://github.com/ocaml/opam-repository/pull/24057 is merged

I'm just widening this in #184 because the jsoo we were using was hanging in CI. This seems to be working currently.


Recalculate line graph when subtree is drawn

I'm not sure if a previous version did this, but when you select a clade, it would be useful that the peaks at the bottom were recalculated for that clade.

Still works for me!
What data-types / actions do you do that don't cause a second (gray) line to be displayed?

Ahh!! I can see it now! But you need to select the whole tree, when it is blue (selected), then the grey line appears. I was thinking more of a clade-scaled plot, just to display the info for the selected clade, but that way you loose the big hotspots, and it is useful to have both.
What about making a 3rd axis on the right to have both lines scaled at their own maximum? The thing is that small hotspots in one clade are so small in the overall scale that you cannot see them. Or maybe if in the future you add options when right-clicking, giving the option of showing one line or the other could also be helpful.
Just a suggestion for future improvements!

OK, so when a subclade is displayed (by right clicking on the tree) the black line plot must be redisplayed?

In my opinion it could be rescaled just to the selected taxa, which is the grey line. But if the black line has very high peaks, then the grey line can be very flat. But it is a suggestion, maybe other people prefer to keep both this way!

I think James has the best resolution - when a subtree is drawn recalculate the plot. James, is it possible to make this more general. i.e. could it calculate the plot for displayed blocks only, so recalculate when selecting a subtree or a new tree is dropped?

Yes, there are (already) listeners for subtree and loaded so just a matter of triggering line re-calculation then. Will have to re-write linegraph code so it only considers blocks with (all?) taxa in activeTaxa (i.e. displayed by tree)

Sounds good!!


[Tabs] Nested tabs cause console error

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Given the page contains a tab with tabs:
┌-------┓
| FIRST | SECOND
|       └––––––––┓
| ┌---┓          |
| | A | B        |
| |   └–––┓      |
| | lorem |      |
| └–––––––┛      |
└––––––––––––––––┛

When the user switches to the second tab, MUI logs an error:

MUI: The value provided to the Tabs component is invalid.

Expected behavior 🤔
No error 😄
Steps to reproduce 🕹

Open https://codesandbox.io/s/frosty-fast-k5whqv
Click on the 'SECOND' tab header
An error occurs in the console

Context 🔦
This bug appeared in react-admin, when a user tried to nest <TranslatableInputs> inside a <TabbedForm> (https://github.com/marmelab/react-admin/issues/7922)
Your environment 🌎

Chrome
MUI 5.9.1

Thanks for the report. Agree, it looks strange. Maybe we can update the condition for the warning to not do it if the whole tabs element is hidden, maybe something like this would be better:
index 4dbc2a5dee..052b96a54b 100644
--- a/packages/mui-material/src/Tabs/Tabs.js
+++ b/packages/mui-material/src/Tabs/Tabs.js
@@ -359,7 +359,9 @@ const Tabs = React.forwardRef(function Tabs(inProps, ref) {
             !warnedOnceTabPresent &&
             tabMeta &&
             tabMeta.width === 0 &&
-            tabMeta.height === 0
+            tabMeta.height === 0 &&
+            // if the tab list element is hidden, don't warn
+            tabsMeta.clientWidth !== 0
           ) {
             tabsMeta = null;
             console.error(

Would be great if we can cover these two scenarios with tests. Would you be interested in creating a PR for this?

Maybe we can update the condition for the warning to not do it if the whole tabs element is hidden

As long as it fixes the warning in the case I described, it's fine by me.

Would you be interested in creating a PR for this?

No, sorry - I have my own bugs to fix in react-admin!

This one's getting me, too
Here's my scenario:
<Box display={{ xs: "none", lg: "block" }}>
   <Tabs ...
</Box>

Annoying because of the debug error messages dumped into console.  But everything still works.

I added commits to wrap up the PR: https://github.com/mui/material-ui/pull/34026


python311Packages.google-cloud-translate: 3.12.0 -> 3.12.1

Changelog: https://github.com/googleapis/python-translate/blob/v3.12.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 262947 run on x86_64-linux 1

4 packages failed to build:

python310Packages.wagtail-localize
python310Packages.wagtail-localize.dist
python311Packages.wagtail-localize
python311Packages.wagtail-localize.dist

4 packages built:

python310Packages.google-cloud-translate
python310Packages.google-cloud-translate.dist
python311Packages.google-cloud-translate
python311Packages.google-cloud-translate.dist

Result of nixpkgs-review pr 262947 at 247a6e56 run on x86_64-linux 1

4 packages failed to build:

python310Packages.wagtail-localize
python310Packages.wagtail-localize.dist
python311Packages.wagtail-localize
python311Packages.wagtail-localize.dist

4 packages built successfully:

python310Packages.google-cloud-translate
python310Packages.google-cloud-translate.dist
python311Packages.google-cloud-translate
python311Packages.google-cloud-translate.dist


Report rate-limits

Context
This PR makes use of the new callback introduced by https://github.com/GitGuardian/py-gitguardian/pull/83 to show a message when GGShield hits a rate-limit.
What has been done

1st commit does more conversion to ContextObj.get().
2nd commit shows a warning message when the rate-limit is hit.

What it looks like

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5a6f8a5) 91.58% compared to head (4efc5dd) 91.57%.

:exclamation: Current head 4efc5dd differs from pull request most recent head 218665d. Consider uploading reports for the commit 218665d to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   91.58%   91.57%   -0.02%
==========================================
  Files         167      168       +1
  Lines        6896     6919      +23
==========================================
+ Hits         6316     6336      +20
- Misses        580      583       +3

Flag
Coverage Δ

unittests
91.57% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add versobe loglevel,fix report path

Add possibility to run job on beanches.
Regression test job should be fixed on Gitlab.
Relates-To: OLPEDGE-1911
Signed-off-by: Yaroslav Stefinko<EMAIL_ADDRESS>

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #348   +/-   ##
===========================================
  Coverage   89.3547%   89.3547%
===========================================
  Files            66         66
  Lines          1813       1813
  Branches        207        207
===========================================
  Hits           1620       1620
  Misses          111        111
  Partials         82         82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2ab44...14c0683. Read the comment docs.


3rd party dependecies under Linux

Hi Christoph,
I'm trying linking upscale library but I'm getting linking errors. What are the 3rd party libraries that should be linked under Linux? Maybe those libraries would be helpful in documentation.
PS I'm trying using cista serialization library for storing values in db. It is a nice library competing against protobuffer, flatbuffer, etc.
Regards
Flaviu

After several search on stackoverflow I found all dependecies:

/usr/local/lib/libupscaledb.a
boost_thread
crypto
dl
pthread
ssl
z

Hi Flaviu,
it depends which features you use... the file configure.ac lists all dependencies; it might be helpful (although you have to navigate through the script a bit).
BR
Christoph

Using Qbs build tool, I needed all dependent library names.
Thank you
Flaviu


german translations for new solidus 1.3 admin backend

added major translations in german for the new solidus 1.3 admin backend

The build errors are because of a deprecation. The latest master of Solidus core raises if deprecated APIs are used. Will fix that.

#64 fixes the build failures. Please rebase once it's landed in master

@florianguenther any news on this?

@florianguenther Can we ping you again? I think the discussion here has been helpful, can you add in the changes?


Parse/Node: Problems with select and include after merging GH-2809 GH-2737

I use
Parse = require('parse/node');

After upgrade parse-server to 2.2.22, I have problems with my code:
var query = new Parse.Query(ClassA);
query.select(['field1', 'field2', .., 'createdBy']); // createdBy is pointer of Parse.User
query.include('createdBy');
query.include('createdBy.shop'); // shop is pointer of Class Shop

I tracked on github, I think problems from 2 pull-request GH-2809, GH-2737.
Please suggest for me solution for this problems.
Many thanks.

this should be fixed by #2809 actually, can you try using in your package.json:
"parse-server": "parseplatform/parse-server#latest"
?

@flovilmart I am having the same issues, destroyed my node_modules, did a reinstall and got the same error with basic query. As soon as I use a select the include goes away and the funny thing is that when you use both the __type attribute changes from Pointer to Object, so I am not sure if that is normal or not?

after reviewing your new update for select keys, I see that the select needs to have the __type as Pointer rather then Object, do you think that is where the issue resides? @flovilmart

@developerX what version are you running? Are you running on the #latest instead of 2.2.22?

@flovilmart yeah I am running the latest with your code snippet from above inside my package.json file

What query are you using exactly? Is it similar to: https://github.com/ParsePlatform/parse-server/pull/2809/files#diff-a6c5eb08fd4bf0d5b33da1eae79112f3R1972

Yeah I am so I did a little more testing and it seems like you have to be specific on what you would like to include when using a select statement.
Here is what I am running into. When I run a query and use include with no select it will include the entire pointer the way I would like.
When I use a select that same pointer return only the the special indexes (objectId, createdAt, updatedAt, etc.) and nothing else.
With the provided information above by @uluru-phatnguyen he would be able to achieve what he wants by simply adding "createdBy.shop" into his select statement and it should do what they want.
Looking at the test that was written for "gameScore" it would pass because it provides an ID and the other field is not defined.
if you try writing a test with nested pointers the test will fail because the select strips all additional information before the include can even include the other fields.
Does that make any sense?

@flovilmart

@developerX why don't you write a failing test for showing exactly what you mean or even better, propose a PR?

@flovilmart
I use parse/node for client, not in cloud code. I not use directly parse-server.
DO NOT specific:

"parse-server": "parseplatform/parse-server#latest"

Any the best solution?
@developerX
Thanks.

If you don't use parse-server then this is not an issue.
When using select in conjunction with include, you should also call add all the keys you want to have with your include.


Time - Vera

React Tic Tac Toe
Congratulations!  Please reflect on the assignment with these questions.
Reflection

Prompt
Response

How are events / event handlers and useState connected?
updateValue is the event handler for clicking on each square. Every time one square is clicked setPlayer1Turn, display X and Pass the turn to player2. SetPlayer1Turn, now the player1 turn is over.

What are two ways to do "dynamic styling" with React? When should they be used?
We can use inline styles or separate styleSheets. We should separate them from the logic and just link each file to the stylesheet file.

Much like Rails works with the HTTP request->response cycle, React works with the browser's input->output cycle. Describe React's cycle from receiving user input to outputting different page content.
The user input happens inside of App.js and we are not displaying different pages, we are just displaying at the same place, rendering different components based on the events.

CS Fundamentals Questions

Question
Answer

What do you think is the BigO complexity of the method you use to compute a winner?
To compute the winner my solution is O(n^2) since I have a loop inside of another loop to get a flat array.

Consider what happens when React processes a state change from setState -- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?Speculate wildly about what the Big-O time complexity of that code might be.
I think the components are objects (JSON). I think react traverses over the components and makes a filter base in what is looking for. Components are like functions. Could be O(n) where n are the number of components?

React Tic Tac Toe

Major Learning Goals/Code Review

Criteria
yes/no, and optionally any details/lines of code to reference

Demonstrates proper JavaScript coding style.
✔

Correctly passes props to child components.
✔

Correctly passes callback functions to child components and calls them to respond to user events.)
✔

Maintains the status of the game in state.
✔

Practices git with at least 6 small commits and meaningful commit messages
✔ So many good little commits!

Uses existing stylesheets to render components
✔

Functional Requirements

Functional Requirement
yes/no

The Square component renders properly and executes the callback on a click event.
✔

The Board component renders a collection of squares
✔

The App component renders a board and uses state to maintain the status of the game.
✔

Utilizes callbacks to UI events to update state
✔

Overall Feedback

Overall Feedback
Criteria
yes/no

Green (Meets/Exceeds Standards)
5+ in Code Review && 3+ in Functional Requirements
✔

Yellow (Approaches Standards)
4+ in Code Review && 2+ in Functional Requirements, or the instructor judges that this project needs special attention

Red (Not at Standard)
0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Additional Feedback
Great work!! Love the pretty styling you added!

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality
Yes?

Perfect Indentation
✅

Elegant/Clever
✅

Descriptive/Readable
✅

Concise
✅

Logical/Organized
✅


Block gossip optimization by early reject and ignore in BlockValidator

PR Description

changed invalidBlockRoots from a Set to a Map holding INVALID import result

new executionFailedBlockRoots Set of blockroots of blocks failed with FAILED_EXECUTION_PAYLOAD_EXECUTION

new failure reasons:

FAILED_DESCENDANT_OF_INVALID_BLOCK: whenever BlockManager tries to import a block child of a block contained in invalidBlockRoots, it immediately returns this result.
if the imported block is contained invalidBlockRoots, we immediately return with its previous invalid reason.

in gossip import (validateAndImportBlock) if block is in invalidBlockRoots (or is a child of one of those blocks) we immediately reject with Block (or its parent) previously marked as invalid.

Fixed Issue(s)
fixes #4920 by closing the last nice to have task
Documentation

[ ] I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

[ ] I thought about adding a changelog entry, and added one if I deemed necessary.

I added invalidity propagation in validateAndImportBlock too, so we early reject all invalid blocks and all the descendants, without trying to validate\import them.
It seems reasonable to me.


Handling conditional require errors

The jugglingdb issue comes down to the following:
require(node6 ? '../package.json' : './package.json')
where webpack is reporting that one of those paths is not found, since it only ever goes down the one path in production.
We could take one of two approaches here:

Improve static analysis to the point where we know that node6 is true, and that we must go down the one path (will be a little bit of work to improve this analysis, and may have some performance implications).
Detect all branched require cases like this with static analysis, and automatically inline the not found error into the not found branch.

(2) would be slightly less work, while (1) seems like the better fix that will also reduce the bundle size by a half (currently we are bundling both the legacy and modern builds of jugglingdb together).

Fixed in #301.


📝 Url 수정

수정사항

https://github.com/uber/streetscape.gl -> https://github.com/oka1313/streetscape.gl 으로 수정

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


python3Packages.ansitable: init at 0.10.0

Description of changes
Adds ansitable to Python packages.
One part of many to add roboticstoolbox to Python packages.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 321907 run on x86_64-linux 1

4 packages built:
  python311Packages.ansitable
python311Packages.ansitable.dist
python312Packages.ansitable
python312Packages.ansitable.dist

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4134

Result of nixpkgs-review pr 321907 run on x86_64-linux 1

4 packages built:

python311Packages.ansitable
python311Packages.ansitable.dist
python312Packages.ansitable
python312Packages.ansitable.dist

Result of nixpkgs-review pr 321907 run on x86_64-linux 1

4 packages built:

python311Packages.ansitable
python311Packages.ansitable.dist
python312Packages.ansitable
python312Packages.ansitable.dist


Do we need ui.qt.uic in the repo?

I am not very sure what pyfocal.ui.qt.uic is supposed to do in the package.

Somewhat related: The following files in the repo claims to be generated by something else, so do they really need to be version controlled if they can be generated on-the-fly?

ui/qt/icon_resource_rc.py
ui/qt/mainwindow.py
ui/qt/plotsubwindow.py

The uic directory contains the sources for the qt files used with the Qt Creator program to generate gui objects. I want these versioned, so, yes, I very much want to keep them in the repo.

The following files in the repo claims to be generated by something else

These are the results of the conversion from the source files to python. These are what are actually used when you launch the application. They are necessary.

Okay.


Implementing datastructures to store and retreive the data from API

After getting the data from API, to avoid multiple calls to the server, the data needs to be represented in terms of Objects so that thay are easily accessible to the other parts of the system
Outcome:

Data classes that holds the nodes, ways and relations

There are 3 domains within the application for representing Nodes and Ways
Overpass API -> used with SwiftOverpassAPI. The objects in this domain are with prefix of OP
Eg. OPNode, OPWay and base OPElement
Storage -> used for storage of elements.
Eg. StoredNode, StoredWay
Filtering. This representation is used to filter out the quests applicable for a specific element. These donot have any prefix. These are available in osmparser target.


add consolidate to single_zarr

I think this is ready for review.
I opened https://github.com/fsspec/kerchunk/issues/441 to think about writing to json in the function a bit more


help me gang whats the cheat directory

Not a problem with my cheat, learn how to use your computer first.


Use the correct function in README.md

Please note that the correct function name is set_virtual_terminal, not enable_virtual_terminal.

Hi, I never noticed that mistake before. Thanks for the fix!


Show folder name on the file being edited (Multiple Folders in workspace)

When editing a file which has the same name as other folders in a workspace example header.php it can be difficult to tell which file is from which folder.
If you could add in the ability to show the folder name maybe in the title of the editor or something instead of just showing
Before:
filename --- WorkspaceName (Workspace)
After
filename --- FOLDERNAME --- WorkspaceName (Workspace)
Keep in mind the editor does this already when two files of the same name are opened but not if only one is opened. When you start opening many files from different workspace folders you easily get lost in which file belongs to where.

@jasonbronson  check out the window.title setting in the settings editor. You can configure what  your window title should be.


[Usability] Dash in environment config key resolves value to NaN

Insomnia Version: Version 5.7.14 (<IP_ADDRESS>1)
Operating System: macOS 10.13 Beta (17A352a)

Details
Environment keys containing dash - resolve their value to NaN.
Base environment
{
  "mykey": "myvalue",
  "my-key": "my-value"
}

URL
http://{{ mykey  }}/{{ my-key  }}

URL PREVIEW
http://myvalue/NaN

Hmm, I swear there was an issue on this before but I can't find it.
There is currently a warning that shows up after editing an environment if one of your variables contains dashes. This is because nunjucks (the rendering engine Insomnia uses) interprets this as subtraction. Maybe a more prominent message is needed?

After updating I have this visual message al well.
Good enough.

I ran into this today testing insomnia as a potential replacement for postman for my small team.  I feel like somewhat of a goon having now actually read the error message, but I did just spend 10 minutes trying to figure out what was going on and only found the solution when going to file a bug and finding this first.
Perhaps it's because I saw it as a warning message rather than an error?  I expect errors to be red, not orange, and it seems a little weird that it'd even let me save a config it knows it's broken.  Wouldn't it be better to disable the "Done" button while it's invalid?

@seangarner it's a warning because technically there are use cases where a dash is acceptable.
One way to make this better might be to treat the scenario as an error but provide an "I know what I'm doing" button to dismiss the error in the future. Thoughts?

Yes that'd work well @gschier.
I'm very curious what the use case for doing maths in a property name is. :thought_balloon:

Well, it's only math if you use it as a variable like {{ foo-bar }}. You may want dashes in a key name for other reasons, like if you wanted to store free-form JSON in your environment that happens to use dashes. Plugins can also reference the environment, which may or may not use dashed key names for the use case.
There definitely aren't very many use cases, but even if there's only a small chance that it might be useful, I don't want to fully prevent it from happening.

had the same issue using "api-token" my post was then sending NaN. At least now I know a work around which is to use apiToken

@gschier , this one is actual in 6.5.4 and there is no such warning shown

@gschier I just ran into this problem. No error or warning message is shown.

Same here on latest version.  There are no errors when setting up environment, but the resolution is "NaN".

Can confirm, too

Is there any workaround to this? A way to escape the dash?

I ran into this today and was extremely confused by it, only this post lead me to understanding what I was doing wrong.

This problem still persists in version 7.0.1.

Hi guys! Is there something to expect for fixing the issue with keys, written with dash? In 7.0.3 if I write key with dashes it will be replaced with NaN. Should I rewrite all params in camelCase or without dashes?

I am still getting variables resolving to NaN, when the environment variables have hyphens in them in v7.0.3.

Same problem in v7.0.5

Due to using Nunjucks as the underlying template engine, there is no way to support names with dashes.
The UI should be updated to ensure the user cannot make this mistake by accident.

Guys, comment under #1666 because it's still open. Cheers!

This is a ridiculous limitation

Re-opening this as a potential fix is in the works, and there was a lot of activity on this (and duplicate) issues. 😄


Clock dont run!

The clock does not advance but after a moment the key changes . The key works sometimes and sometimes not.
The reinstallation solves the problem , but I have 500 users so it is not a viable solution.

Any idea?

The uninstall and reinstall solve the problem.

Reinstall may destroy all your data, remember to backup your data.


[Explorer Dialog Path Selector] Does not run when configured to launch from Task Scheduler

I set up a task scheduler task to start the tool as admin on logon, without a UAC prompt.
This works for almost every program out there. The only exception I've found is HWiNFO64, and this program.
How the task is configured:

Images

But when I right click on task and click Run, nothing happens. The Last Run Result is 0x800702E4.
The program works normally if I launch it normally (as user or admin) from a File Explorer window.

Apologies, it turned out something else was interfering with this tools functionality in elevated applications. The "elevated applications" workaround suggested in the YouTube video now works for me.

Ok i'll close this then


able to get arbitrary mouse position

inspired by vim-rainbow-trails, i want to show trails across windows. so i will compute the line of points between the two cursor absolute positions when cursor moving, when drawing them, i have to convert them to window-local for matchaddpos().
but i found no easy way to convert an absolute coordination to window-local position with proper care of: the width of tab, multibyte character, zl.
and i managed to know that the getmousepos() just offers what i want exactly, except it only returns the current 'mousepos', so in such case, i propose to add parameters to it so that it can accept arbitrary mouse position.

it's been a week and this interests nobody, and as i'm not able to make a pr by myself. i'm closing it.


Feedback: 30AWG wire (X3, X4, X5, X6) too difficult to work with.

As of August 2019, the wires for carrying wheel drive motor encoder data were 30AWG wires. For disambiguation there were four colors (X3 through X6). They are intended to connect to side-entry terminal blocks E3 on rover PCB.
Their small diameter are useful for routing through small gaps, helped by the flexible insulator. However, when trying to insert bare wires into E3, their small size is easily bent out of position. Once in position, they are so thin the screw-down terminal can't make solid contact, leading to electrical gremlins and/or wires falling out.
Akin's Australia and US rover build teams both independently came to the same conclusion these wire needed larger and more durable ends. (We didn't realize this until weeks after the fact.) The Australian rover got soldered headers, the USA rover received crimped-on connectors.
Low-impact solution:
Switch X3 - X6 to larger diameter wires.
High-impact solution:
For a future PCB revision, switch from side-entry terminal blocks to commodity wire-to-board electrical connectors. (JST-XH or similar.) It will require more up-front work to wire up the connector, though note in this case we ended up doing similar work anyway. The payoff is ease of disassembly for diagnosis and repair. For each wheel, one single plug by hand versus 6 individual wires and screwdrivers.
(Or do both: larger diameter wires AND wire-to-board connectors)

Log from Australia rover build team:

Photo of USA rover PCB:

Looking at making this change to upgrade the wire to be more accomidating to work with. Thinking about the following cables:
@Achllle I think I saw something where you were discussing motor currents and wire current, I tried digging through a few places I thought that discussion was and couldnt find it. Feel free to weigh in.

Purpose
AWG
Link

Motor +
16
https://www.digikey.com/product-detail/en/cnc-tech/1569-16-1-0500-004-1-TS/CN645R-25-ND/9450426

Motor  -
16
https://www.digikey.com/product-detail/en/cnc-tech/1569-16-1-0500-001-1-TS/CN642B-25-ND/9450423

Encoder +
24
https://www.digikey.com/product-detail/en/nte-electronics-inc/WH24-06-25/2368-WH24-06-25-ND/11646871

Encoder -
24
https://www.digikey.com/product-detail/en/nte-electronics-inc/WH24-05-25/2368-WH24-05-25-ND/11646835

Encoder A
24
https://www.digikey.com/product-detail/en/nte-electronics-inc/WH24-04-25/2368-WH24-04-25-ND/11647079

Encoder B
24
https://www.digikey.com/product-detail/en/nte-electronics-inc/WH24-09-25/2368-WH24-09-25-ND/11647824

What's driving the change to 16AWG wire for the motors? It seems like overkill. 4ft of 20AWG has a voltage drop of 0.25 volts or so at 4A. 16AWG is less than 0.1 volt. The PWM going into the motors will change things a bit, but I'm not sure how much. Going with wire that size limits connector options.

It's not the voltage drop that's the issue, it's the current draw from the motors. The idea is to replace the default motors with beefier ones (which a lot of folks have done already) and current draw for a single motors could peak ~10A or more which is dangerous. Perhaps 18AWG is a middle ground?

Voltage drop and heating due to current are two sides of the same coin. When sizing the wires, steady-state current matters more than transients. Except for the protective wire braid, our motor wires are basically exposed to air, as opposed to being enclosed in a wall or in conduit. That helps with any extra heat from transients and we are not worried so much about the total heat produced in the length of wire. The default battery is good for 8A at 16.8 V, so less than 135W total into the rover for a fully charged battery. 120W is probably a good number for when you've been driving for a while. That gives you 20W average for each drive motor. (The multimeter thing is good for 20A, so we can ignore that as a limit.)
The worst case is if the motors can pull the 20W at 6V, so that gives you a bit over 3A. My estimate of worst-case steady-state current is 4A. That's 4A into each motor as you drive across the prairie. At that current, assuming I did my math correctly, the power loss in each motor wire is 1W for 20AWG, and some fraction of that for bigger wires. At 10A, it's only 2.5W, which will only occur for a short time. I'm using the beefy 45 RPM Servo City planetary gear motors, and 10A into those motors for very long when stalled will destroy them. These motors come with 24AWG wire and JST PH series connectors, and anything much bigger is probably a waste of copper. (The battery has 16AWG wire.) The PH connectors are good for 2A steady state. My first thought when I was looking at the project was that the 20AWG motor wires were overkill, but they do help reduce the losses between the motor controllers and the motors.
I'll see if I can do a better characterization of the motors from the specs, just to see how they might look.

So here's a screenshot of a table calculating voltage drop and wire losses for 1m length of wire. I got the resistances from some random place on the internet. I think the sweet spot is 20AWG for the motors. 22AWG for the motors would make it easier to find board connectors that would work for both the encoders and motors, but 20AWG will work.

I don't think everyone uses the default battery. I switched to a 9Ah 100C LiPo... The battery leads are 12AWG...

120W is probably a good number for when you've been driving for a while. That gives you 20W average for each drive motor.

Aside from using the battery upper limit as the starting point, I don't think I trust dividing that number by the number of drive motors. Loads are often very unbalanced, and it's also common to turn and drive at the same time.

These motors come with 24AWG wire

Wow that seems crazy, are you sure of that? The website seems to show 16AWG. I have the GoBilda planetary gear motors and they come with 16AWG wires.

I don't think everyone uses the default battery. I switched to a 9Ah 100C LiPo... The battery leads are 12AWG...

The leads on your battery are so big because your battery has an extremely high discharge capacity. It appears to be a multi-rotor battery. The same size battery with a lower discharge capacity could get by with smaller wires.

Aside from using the battery upper limit as the starting point, I don't think I trust dividing that number by the number of drive motors. Loads are often very unbalanced, and it's also common to turn and drive at the same time.

Dividing by six gives you an upper estimate for sizing the drive motor wires. Turning at the same time reduces the amount of current available for the drive motors, but that's a short-term impact and it wouldn't impact the size of the wires. If anything, it would make them smaller.

These motors come with 24AWG wire

Wow that seems crazy, are you sure of that? The website seems to show 16AWG. I have the GoBilda planetary gear motors and they come with 16AWG wires.

Yes, they have 24AWG wires. The JST PH connectors they come with are limited to 24AWG.

Dividing by six gives you an upper estimate for sizing the drive motor wires.

If you assume that all drive motors draw the same current at all times. When there is more friction on one wheel or it's stuck and the other wheels are spinning freely, that one motor is going to draw quite a bit more.
In my case (and I think with quite a few people who decided to upgrade the battery), since the discharge capacity is so high, there's practically no limit on the 'current available'. For the case of a limited discharge, I agree with your point, but we want to support different batteries and discharge currents.
Regarding the wires on those motors: on the product page in the recommendations section they link the 16AWG wires and on that page they show the original motors so I'm still not convinced 24AWG is a good idea 🙂

You are correct that some motors may be pulling more power than others for whatever reason, but 20W is still a good baseline for steady-state (average) power calculations. So the question is what happens if you start to deviate from normal.
Here are estimates of torque-speed and power-speed curves for those motors. I just took values from the provide torque-speed curves and calculated the output power. You are not going to get much more than 20W out of these motors no matter what you do. The current requirements are going to go up, but it will require more effort to calculate that and I'm not sure I could do it correctly right now. (I'm not entirely sure I got this right.) You certainly don't want to push more than 7A steady-state out of the RoboClaws for any extended period of time. Transients can certainly be higher than 20W, but as I said before, you really don't care about those WRT the wires from the RoboClaws to the motors.
If you look on the ServoCity page with the encoder versions of those motors, you will see the 24AWG wires and connectors. These are what you want for the drive motors.
I'm not saying to use 24AWG, I'm saying to stick with 20AWG unless there is a good engineering reason to make the wires bigger, and I'm not sure there is one. Tradeoffs include getting the wires from the motor to the body and connectors on the board. The blue connectors currently used for the battery connections are only good for 15A steady state. I am updating the PCB and will incorporate better connectors for the motors and encoders. The 24AWG-20AWG range of wire sizes is a sweet spot for connectors. We could use JST XA connectors and have a single connector for each motor/encoder combination. Anything larger than 20AWG means going up to JST VH connectors for the motors and hope they fit while using a different connector for the encoders. I'm also looking at incorporating an PI-interfaceable device for current and voltage measurements (per your request) and the AdaFruit device is only good for 15A steady state.

Thanks for the thorough analysis. I'm on the same page now!

Alright, so is the conclusion here to use 20 AWG for Motor +/-, and 24 AWG for the encoder wires?


[FEAT]How can I use  graph.zoomIn();

  buttons.appendChild(DomHelpers.button('+', function () {     graph.zoomIn();   }));   buttons.appendChild(DomHelpers.button('-', function () {     graph.zoomOut();   }));
v0.12.0

Hi @pccai
Can you provide more details about your question?
What are you trying to achieve,  what is not working, what information is missing?
I guess the code extract in the description is coming from the storybook example.
What is wrong with this code in your use case?

Using graph.zoomIn() or graph.zoomOut() is known to work.
Isn't it working for you?

No answer so closing for clearing the backlog.
Feel free to comment or create a new issue if you want to provide more details.


The percentages calculation looks to be missing a * 100

https://github.com/rh-aiservices-bu/fraud-detection/blob/7b42799d2072531f5787f8057b5024e9321a4c95/1_experiment_train.ipynb#L553
I think this should read
print("{:.5f}".format(np.squeeze(prediction) * 100) + "%")

so that the result is between 0 and 100 as a proper percentage, and not from 0 to 1.

Fixed in #50


Renaming \SI

I love this package, but it collides with the siunitx package, which defines the \SI command. I have hacked my copy, changing the \SI command to \SIc, and making the corresponding updates to simpleiconsglyphs-xeluatex.tex.

Would it not be possible to alter your package to avoid this conflict? Please!

Hi @pnsaeta,
Thanks a lot for opening an issue here and bringing this to my notice. I sincerely apologise for not responding earlier as I was on holiday. I shall surely get into renaming the command to avoid future conflicts and hope to release it by Friday (if Simple Icons also release a new version).


Add PostGIS 2.3.1 scripts package

It must be a packaging issue but the core 2.3.1 dfsg package does not include the postgis.control file that is needed by liquibase.  Adding the scripts package solves the issue and allows the database update to complete.

We didn't notice this PR before we merged another PR that solved this same problem. :anguished:


[5.3] Mark non-foreign entry points of @objc dynamic methods in generic classes dynamically_replaceable

Description:

class Generic<T> {
  @objc dynamic func method() {}
}

extension Generic {
  @_dynamicReplacement(for:method())
  func replacement() {}
}

The standard mechanism of using Objective-C categories for dynamically
replacing @objc methods in generic classes does not work.
Instead we mark the native entry point as replaceable.
Because this affects all @objc methods in generic classes (whether there
is a replacement or not) by making the native entry point
[dynamically_replaceable] (regardless of optimization mode) we guard this by
the -enable-implicit-dynamic flag because we are late in the release cycle.

Scope: Before this patch @_dynamicReplacement(for:) was not allowed on
objective c methods in generic classes.

Risk: Medium. Should only affect entry points that did not work before.

Reviewed by: Slava Pestov

Testing: Regression test added

rdar://63679357

@swift-ci Please test


Spin Flax(Magic) Plugin

In the plugin it could have a two options in which I can think of.
Show how many casts left via overlay, would take the amount of flax in your inventory and / 5.
time before next cast? so a timer of some sort.
idk how complicated this would be to make but would be a nice "quality of life" plugin

I feel like this isn't necessary now that we have the Inventory Viewer plugin--it can be used for all of the lunar spells that affect inventory items.

I agree, we can close this


Port to use libgpiod instead of the RPi-specific libs

Lightly tested. Edge detection not yet implemented.
Already using it in my Home Assistant deployment ;) https://codeberg.org/raboof/homeassistant-sbc/commit/597e37e57154ece76bcbb41b00b0b5f354af90a2
Refs #210

Still relevant.
I guess maybe someone should fork this project as ha-gpio? I don't really have the energy right now though.

:wave:

Great work @raboof. Almost working fine for me. The only thing is that ports are in an inconsistent state after rebooting HA (reports state off, but are on). Any idea why? Could be related to the release of the lines? It seems it is not working
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/rpi_gpio/__init__.py", line 36, in cleanup_gpio
    gpiod_lines.close()
    ^^^^^^^^^^^^^^^^^
AttributeError: 'LineRequest' object has no attribute 'close'```

Great work @raboof. Almost working fine for me. The only thing is that ports are in an inconsistent state after rebooting HA (reports state off, but are on). Any idea why? Could be related to the release of the lines? It seems it is not working
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/rpi_gpio/__init__.py", line 36, in cleanup_gpio
    gpiod_lines.close()
    ^^^^^^^^^^^^^^^^^
AttributeError: 'LineRequest' object has no attribute 'close'

Oops, that's very possible. I don't expect to have much time to look into this in the next weeks, but if you can come up with and verify a fix I'm happy to incorporate it.

Another comment. For Raspberry Pi 5 I had to switch to gpiochip4
gpiochip0 [gpio-brcmstb@107d508500] (32 lines)
gpiochip1 [gpio-brcmstb@107d508520] (4 lines)
gpiochip2 [gpio-brcmstb@107d517c00] (17 lines)
gpiochip3 [gpio-brcmstb@107d517c20] (6 lines)
gpiochip4 [pinctrl-rp1] (54 lines)

Aha. I guess we want to make it configurable anyway. Would there be a nice way to auto-detect a sensible default (i.e. that picks gpiochip0 for rpi3 and gpiochip4 for rpi5)?

Aha. I guess we want to make it configurable anyway. Would there be a nice way to auto-detect a sensible default (i.e. that picks gpiochip0 for rpi3 and gpiochip4 for rpi5)?

I have a pi3 and a pi5. Once I have time I will have a look to it.
One more thing. I need to do a minor change also for the setup of the ports. Im using inverted logic for some of them and were not properly initialised. Not sure if this is fine for all cases.
https://github.com/raboof/ha-rpi_gpio/compare/port-to-libgpiod...aguedob:ha-rpi_gpio:port-to-libgpiod

Hi all,
Great job for the integration of new gpiod for Home Assistant.
Thanks @raboof for the updates.
I have tested, it's working weel, but how add edge detection ?
I can't find a correct documentation of the lib.
Thanks in advance for your answer and support.

I have tested, it's working well

Good to hear!

but how add edge detection ? I can't find a correct documentation of the lib.

I haven't looked into edge detection as I don't use that yet myself. Indeed the docs can be a bit hard to find and spotty. Indeed the Python README doesn't seem to have any documentation on reading, but there are some 'watch' examples, maybe those help?

I have tested, it's working well

Good to hear!

but how add edge detection ? I can't find a correct documentation of the lib.

I haven't looked into edge detection as I don't use that yet myself. Indeed the docs can be a bit hard to find and incomplete - the Python README doesn't seem to have any documentation on reading, but there are some 'watch' examples, maybe those help?

Thanks for your answer. I have find the same documentation of the API ;)
I have made some update, I can now get the change of the input in live, but it's quick and dirty.
I propose to commit it, quickly.
I wish you an happy new year and the health.

Given upstream hasn't participated in this thread yet, I wonder if we should fork this into a separate ha-gpio module (and rename some stuff)? Would you be willing to help maintain that @aguedob @stevaedrum?

Given upstream hasn't participated in this thread yet, I wonder if we should fork this into a separate ha-gpio module (and rename some stuff)? Would you be willing to help maintain that @aguedob @stevaedrum?

Same here

I did a bunch of renames and am now running https://codeberg.org/raboof/ha-gpio on my pi - seems to work fine! I'll stop providing updates here now, see you on the other side ;)


Improve the Google Authentication Provider UI

Issues below broken out from rancher/dashboard#2667
Issue 1
Can we have different sections and demarcations for the Authentication section and Access section.
Issue 2
Can the "Authorized Users and groups " section be aligned correctly?

Closing this as it seems to be a stale issue.


Activity example

Core initializes successfully, Discord is open, code (just like in the example) executes without problems, but nothing happens in Discord. How can this be debugged in any way?

Somehow it started working.

I am also having this issue.


feat: add new community template

this PR adds a new template for ogImage.
the default look will be like:

and in a project:

Looks great, thanks ❤


Reduce number of binaries travis builds to minimum

Builds on #11245.

Hm, how to get travis to pick this up?

Looks like this shaves off 30 seconds or so. @thockin @erictune

Actually, I think "does everything build" is a useful part of this sanity check, so I am thumbs-down on this

Looks like it's keeping up now, so this isn't needed anyway. We can revive it if it gets bogged down in the future.


feat: update everything changing within one year

Update dependencies
Add linting
Migrate example to null-safety
Deprecate [onLinkTap] in favor of [beforeLaunch]
Update known URI schemes and TLDs
Refactor code
Semantic adjustments using Link widget

Signed-off-by: TheOneWithTheBraid<EMAIL_ADDRESS>

So, I think it's fine for review again.

dart 3.0 and flutter 3.10 are in stable now, could you re-review this?

@selfisekai two of the comment threads were resolved despite soru not having seen them as such. Re-opened them now.

Superseeded by #3


请教下怎么列出被删除好友或黑名单的列表，然后怎么批量删除他们？

请教下怎么列出被删除好友或黑名单的列表，然后怎么批量删除他们？

If web wechat cannot do this, then wechaty cannot.
Because wechaty is based on web wechat.

ok,thx

It might be able to be done by wechaty-puppet-padchat
@callmesoul Could you please close this issue because your question had been answered?


ROI and infolabel update.

Added column headers to ROI saved CSV files.
Update open ROI saved files.
Enhanced error checking in ROI.
Added ROI stats output.
Fix LongMessage modeless to display.
Fixed a minor bug for Python 2.6
Added a tool reset button.
Updated infolabel.

This takes care of a few comments from both @tjlang and @pfhein Issues #53 and #47 .
I also updated some ROI functionality, which led to a hopefully more robust modeless dialog window.
I also added a tooltip to self.canvas in plot_radar.py, but I need suggestions on how to get the filename over the Display class. I balked at putting it in the new infolabel box at top after remembering how long file names can be. A subtle solution is a hover-over on the plot that will give the name. Of course this could cause problems with using the tools. Thoughts?
Maybe we could attach the tooltip to another feature?

About the filename, I am sure in my mind, the only legal way of passing it from Menu to Display is with a shared variable, however a Vfilename variable does not make sense, since I can not image of a use for component having Vradar unrelated to Vfilename. So if the official doors are closed, you smuggle it in. And radar is perfect for that.

I spent some time floating through the code and looking online and yes it seems you are right given our setup. And I agree that a Vfilename seems unnecessary. As Tim pointed out, since the title is able to be changed (by design) it may not be the best way to tell what file you are reading at the moment. Plus, I've had instances of really not knowing from the auto-generated title. A quick reference would be nice here.
I may try the smuggle route with Vradar, attaching the filename as you previously suggest in Menu. This can always be changed later if we deem it not worthy.

Okay, updated the titles per conversation in #53 and also smuggled the filename into Display as discussed in #65 . The hover tool is now over the info label to see what file you are working on.

I also made the change to LinkDisplay per #53 . Using the grep command it wasn't too bad, just need to be diligent in doing that.
Other changes I'm considering is RadarDisplay to AddDisplay and ROI to SelectRegion. This might mean renaming roi.py to select_region.py also, but this is actually more clear. Thoughts?

Yes, SelectRegion is more descriptive than ROI.  I like the changes.
On 08/05/2015 05:27 PM, Nick wrote:

I also made the change to LinkDisplay per #53
https://github.com/nguy/artview/issues/53 . Using the grep command
it wasn't too bad, just need to be diligent in doing that.
Other changes I'm considering is |RadarDisplay| to |AddDisplay| and
|ROI| to |SelectRegion|. This might mean renaming |roi.py| to
|select_region.py| also, but this is actually more clear. Thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/nguy/artview/pull/66#issuecomment-128182887.

I don't like AddDisplay, Radar is important to separate from display, and add don't make sense as class name. If you want you can put add before all entries:
"add " + comp.__name__ in  here

See #53 for my comment on AddDisplay, I agree and didn't change this.
Unfortunately I don't think "add" is appropriate as we're not really adding atteuation calculation they are being performed. And I like those names already.
I would go for LinkPlugins instead of LinkDisplay.

would "start" be better than "add"?

Okay, the check is added and will be pushed with next commit.
I also changed the name from LinkDisplay to LinkPlugins. Does that work?

yes, it does

Okay, the points.py has been added to core directory. I'm going to go ahead an merge.

Ok, go on and merge. By the way are you planning any more alterations?

I will hold off for a bit. Are you going to implement something?

May be just some minor stuff to further round the edges.

Sounds good. I have a couple of thoughts of things to do. One more addition
to SelectRegion and make the masking plugin.
On Aug 6, 2015 11:41 AM, "Anderson"<EMAIL_ADDRESS>wrote:

May be just some minor stuff to further round the edges.
—
Reply to this email directly or view it on GitHub
https://github.com/nguy/artview/pull/66#issuecomment-128455073.

Do you want to do that before or after I convert SelectRegion to use Points?

Let me see if I can knock this out in the next day or two. If not I'll post here again.
Using the points won't change the functionality of SelectRegion, correct?

correct, the functionality will not change, just how the data is stored.

I'm going to make just a couple quick changes and then I'll do another small PR.
I may have found a slightly more elegant test solution for the _check_default_field in plot_radar.py. We'll see what others think. It came out of a conversation with @pfhein about how another software works.


Test methods with UITestMethod attribute are not discovered.

Description
Issue is the same as described here, but it appears with current version too (1.1.17)
Steps to reproduce

Create a new UWP test project.
Build. Notice that TestMethod1 shows up in the Test Explorer.
Change [TestMethod] to [UITestMethod] on TestMethod1.
Build.

Expected behavior
TestMethod1 still appears in Test Explorer.
Actual behavior
It disappears.
Environment
VS Enterprise 2017
MSTest.TestAdapter - 1.1.17
MSTest.TestFramework - 1.1.17

@bmourat : I cannot repro this. Can you turn on the following diagnostic logs and share them here please:

Assuming you aren't on the latest preview, set a system wide environment variable VS_UTE_Diagnostics to '1'. Logs would show up in Output -> Tests pane in VS.
Set TPTrace to 4 in %ProgramFilesx86%\Microsoft Visual Studio\2017\Enterprise\Comon7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.discoveryengine*.exe.config. Logs for this would go to %temp%.

Sorry for this one, seems like it was some visual studio related behaviour.


Does not honor once option in addEventListener

https://glitch.com/edit/#!/dandy-jury?path=index.html:3:8
Expected behavior: 'myEvent Handled' logged exactly once
Observed behavior: 'myEvent Handled' logged every 100ms

Thanks, I didn't know this was a thing. 👌

Oh wow, I also did not know this was a thing! No more self-removing event handlers.


Add Noah 3.2 and NoahMP 4.0.1

Description
Update the NCAR license to include Noah 3.2 and NoahMP 4.0.1.

This PR successfully updates the NCAR license to include Noah 3.2 and NoahMP 4.0.1 while removing the errant listing Noah 3.0 and Noah 3.4.  Since only documentation is updated, no additional testing is needed.


Optimize show popup method

Please fix conflicts.

Nice fix.
Please report the update to showPopupTimer method in sandbox.html


Can using immer in this way cause performance issues?

🙋♂ Question
I'm using the last Immer version with React and I've a special situation in which i need to have a class as state. This class contains the actual model and some method to modify it. So it works like a "proxy" for the actual state that is not directly accessible outside the class.
My app is big, but I've made a little fully working CodeSandbox example to show you how i need to use Immer.
It works perfectly, but, as the title says, using Immer in this way is safe and correct or it can cause performance issues?
Thank you for your attention,
Regards,
VL

Well, that depends on whether you want to be able to update 1 or 1 million instances in 10ms. In general, determine your requirements, then measure? Unless proven otherwise, it's gonna be fast enough, and it is quite unlikely that Immer is going to be your performance bottleneck in contrast to for example rendering.


Python implementation doesn't handle unicode properly

Is this really relevant anymore? After all the Python implementation is more of an exercise than a full featured implementation, right? May be worth closing as wontfix?

You're right, python extension is not actively used.


libmwaw: 0.3.13 -> 0.3.14

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/libmwaw/versions.
These checks were done:

built on NixOS
ran ‘/nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14/bin/mwawFile -v’ and found version 0.3.14
ran ‘/nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14/bin/mwawZip -v’ and found version 0.3.14
ran ‘/nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14/bin/mwaw2csv -v’ and found version 0.3.14
ran ‘/nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14/bin/mwaw2html -v’ and found version 0.3.14
ran ‘/nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14/bin/mwaw2raw -v’ and found version 0.3.14
ran ‘/nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14/bin/mwaw2raw --version’ and found version 0.3.14
ran ‘/nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14/bin/mwaw2svg -v’ and found version 0.3.14
ran ‘/nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14/bin/mwaw2text -v’ and found version 0.3.14
found 0.3.14 with grep in /nix/store/a9gm0j8p8v4i0psq5jx3kyxvphhpz8rs-libmwaw-0.3.14
directory tree listing: https://gist.github.com/e6bf3abafc8b9634a51796eb8969b268

cc @7c6f434c for review

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: libmwaw
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: libmwaw
Partial log (click to expand)
shrinking /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14/bin/mwaw2html
shrinking /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14/bin/mwaw2csv
shrinking /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14/bin/mwawZip
shrinking /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14/bin/mwawFile
shrinking /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14/lib/libmwaw-0.3.so.3.0.14
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14/lib  /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14/bin
patching script interpreter paths in /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14
checking for references to /build in /nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14...
/nix/store/0rz4sv2gw5qf641lvgs4xarxgwysdr1b-libmwaw-0.3.14


[Probable Bug] Pet Quality numbers have shifted

Sorry, this may not be an actual issue but I'm not really sure of a good resource to ask for script help.
my scripts, which I have used for years, are not working now. They worked properly last time I played in Dragonflight.
I'm not sure if something is wrong, or if I'm doing something wrong.
--Quit if no Rares
quit [enemy(#1).quality!=4 & enemy(#2).quality!=4 & enemy(#3).quality!=4]
quit [enemy(#1).quality!=4 & enemy(#2).quality!=4 & !enemy(#3).exists]
quit [enemy(#1).quality!=4 & !enemy(#2).exists & !enemy(#3).exists]
test(Rare pet found!)

this should only quit if there are no Rare enemy pets found, however instead it quits every single time.
and in another script, my pets killed a blue quality pet despite
catch [enemy.quality>3]

its almost as if the quality is being ignored or returned incorrectly?
again, if I've made a mistake here please let me know!
including a screenshot of the script editor test result being "quit" despite there being a rare enemy in slot 3.

I have done further testing and discovered that the values for quality appear to have changed at some point recently.
I'm now seeing these results:
Poor: <1 (0 returned an error)
Common: 1
Uncommon: 2
Rare: 3
Epic: 4
Legendary: 5
I came to this conclusion by running this script on various enemy types:
if [enemy.quality=x]
test(success!)
ei

I believe this is now a bug of some sort, so I've edited my issue title.

Should be fixed by v1.10.6.


Interpreting the results

I trained the model with the default parameters, and evaluated at the step 27847. (I didn't do the coverage training, just launched the training with default parameters)
These are the results I got:
ROUGE-1:
rouge_1_f_score: 0.6100 with confidence interval (0.6087, 0.6113)
rouge_1_recall: 0.5746 with confidence interval (0.5726, 0.5767)
rouge_1_precision: 0.6785 with confidence interval (0.6767, 0.6803)
ROUGE-2:
rouge_2_f_score: 0.4800 with confidence interval (0.4788, 0.4813)
rouge_2_recall: 0.4533 with confidence interval (0.4515, 0.4552)
rouge_2_precision: 0.5325 with confidence interval (0.5311, 0.5339)
ROUGE-l:
rouge_l_f_score: 0.5986 with confidence interval (0.5973, 0.5999)
rouge_l_recall: 0.5638 with confidence interval (0.5618, 0.5659)
rouge_l_precision: 0.6658 with confidence interval (0.6640, 0.6676)
How to interpret these with respect to the results in the paper ? Where can be the problem, given that the paper reports a rouge-1 of 0.3953 and the above one is 0.61 ?

Have you looked at the output files themselves?

I did, and they don't seem too good. That is why I am a bit puzzled about the numbers. Are these numbers (the ones reported by the "single_pass" arg) the ones that were used in the paper ? Or there is some other way to get them ?
This is actually my goal: to make sure that the model I have trained reproduces the results in the paper.

Yes, we used this code and the single_pass flag to get the results reported in the paper.
The code we've released here is a cleaned-up version of the code we used to get our results (removing a lot of extra unnecessary stuff and making things easier to understand). As you can see there've been a few bugs that were introduced by the clean-up, that we've needed to fix. But the code should essentially be the same.
Could you post some examples of your outputs here? How many files do you have in your decoded and reference files?

I did multiple tests, on the whole test set (11490 files in both decoded and reference) and on the first 1000, and the results are similar.
These are some samples:
reference:
marseille prosecutor says "so far no videos were used in the crash investigation" despite media reports .
journalists at bild and paris match are "very confident" the video clip is real, an editor says .
andreas lubitz had informed his lufthansa training school of an episode of severe depression, airline says.
decoded:
marseille prosecutor says the agency is not aware of any video footage from on board .
marseille prosecutor says it was not aware of any video footage from on board .
marseille prosecutor says it was not aware of any video footage from on board crash .
reference:
many girls in nima,one of accra's poorest slums, receive little or no education .
achievers ghana is a school funded by the community to give the next generation a better chance of success .
girls are being taught to code by tech entrepreneur regina agyare, who believes her students will go far .
decoded:
regina project achievers explains up to comes, project .
tech entrepreneur says the students proved quite we are teaching the girls .
[UNK] has one of the densest populations in education project .
the ghana has one of the densest populations .
reference:
thunderstorms with large hail are predicted for the midwest and the plains .
tornadoes could strike thursday night and friday .
decoded:
severe weather is perilous anytime, of national weather service .
severe weather is hit parts of indiana and kentucky. oklahoma .
severe weather is hit parts of indiana and kentucky. residents .
severe weather is perilous anytime, of illinois .
Do you think my pyrouge / ROUGE-1.5.5 install may have a problem ? Is there a way to simply check that my rouge setup is the same as yours ? pyrouge tests pass.

I'm not sure what's going on here. Your output seems pretty reasonable but not the kind of thing we'd expect to get such high ROUGE scores. I'd recommend the following:
Look in decode.py at the code that runs pyrouge eval. It's fairly simple. Run the same commands to run the pyrouge eval again on your decoded and reference directories (in my experience, this takes several minutes). See if you get the same ROUGE numbers again. I think there might be some pyrouge options that will give you more verbose output (like ROUGE scores per file) - this could be helpful.
By the way, are you aware of this fix to the data-getting code?

I think I figured out the problem: the pyrouge package in python 2.7 generates the rouge_conf.html configuration file differently from the pyrouge in python 3.5. More precisely, the one in 3.5 generates <INPUT-FORMAT TYPE="SEE"> whereas 2.7 generates <INPUT-FORMAT TYPE="SPL">.
SPL makes the rouge script interpret the html tags as words as well (is per line matching), which explains the high ROUGE scores. SEE is the correct one for HTML.
Now I get these scores, which seem more reasonable:
1 ROUGE-1 Average_R: 0.28443 (95%-conf.int. 0.27736 - 0.29145)
1 ROUGE-1 Average_P: 0.22913 (95%-conf.int. 0.22278 - 0.23556)
1 ROUGE-1 Average_F: 0.24776 (95%-conf.int. 0.24154 - 0.25383)
1 ROUGE-2 Average_R: 0.07891 (95%-conf.int. 0.07356 - 0.08464)
1 ROUGE-2 Average_P: 0.06283 (95%-conf.int. 0.05836 - 0.06727)
1 ROUGE-2 Average_F: 0.06816 (95%-conf.int. 0.06340 - 0.07314)
1 ROUGE-3 Average_R: 0.03494 (95%-conf.int. 0.03079 - 0.03904)
1 ROUGE-3 Average_P: 0.02780 (95%-conf.int. 0.02446 - 0.03128)
1 ROUGE-3 Average_F: 0.03016 (95%-conf.int. 0.02665 - 0.03381)
1 ROUGE-4 Average_R: 0.01884 (95%-conf.int. 0.01577 - 0.02204)
1 ROUGE-4 Average_P: 0.01507 (95%-conf.int. 0.01263 - 0.01766)
1 ROUGE-4 Average_F: 0.01630 (95%-conf.int. 0.01373 - 0.01907)
1 ROUGE-L Average_R: 0.25577 (95%-conf.int. 0.24911 - 0.26218)
1 ROUGE-L Average_P: 0.20593 (95%-conf.int. 0.20012 - 0.21176)
1 ROUGE-L Average_F: 0.22271 (95%-conf.int. 0.21701 - 0.22858)
1 ROUGE-W-1.2 Average_R: 0.12043 (95%-conf.int. 0.11713 - 0.12381)
1 ROUGE-W-1.2 Average_P: 0.15987 (95%-conf.int. 0.15547 - 0.16443)
1 ROUGE-W-1.2 Average_F: 0.13347 (95%-conf.int. 0.13015 - 0.13704)
1 ROUGE-S* Average_R: 0.07204 (95%-conf.int. 0.06810 - 0.07603)
1 ROUGE-S* Average_P: 0.04788 (95%-conf.int. 0.04503 - 0.05083)
1 ROUGE-S* Average_F: 0.05255 (95%-conf.int. 0.04972 - 0.05523)
1 ROUGE-SU* Average_R: 0.08544 (95%-conf.int. 0.08127 - 0.08949)
1 ROUGE-SU* Average_P: 0.05661 (95%-conf.int. 0.05361 - 0.05966)
1 ROUGE-SU* Average_F: 0.06245 (95%-conf.int. 0.05946 - 0.06531)
I'll try retraining with the fix you mentioned for data preprocessing.
Thanks for the help.

 Looks like you figured it out!

Seems like the model is overfitting quite early i am training on the complete dataset with default parameters

On what kind of hardware are you running this on?

a GTX 1080 Ti machine

This is how mine is looking:

The model is at about 15k with values of eval and train at 3.4 & 4.02 and is still on. Lets say the train and eval are terminated, checkpoints backed up, run eval and train with coverage=true options followed by decode; if it is not satisfactorily decoding the summary, is it possible to resume running train and eval after restoring the ckpt files (backed up before converge was done) with coverage=false?

@makcbe  If I understand your question correctly: yes you should be able to restore a non-coverage model to continue training with coverage=false.

Hi, I also try to replicate results shown in the paper. I trained the model without changing any parameter, and evaluated at the chekpoint-44550. There are loss and results I got:

ROUGE-1:
rouge_1_f_score: 0.3405 with confidence interval (0.3381, 0.3427)
rouge_1_recall: 0.3506 with confidence interval (0.3480, 0.3532)
rouge_1_precision: 0.3536 with confidence interval (0.3507, 0.3564)
ROUGE-2:
rouge_2_f_score: 0.1384 with confidence interval (0.1362, 0.1405)
rouge_2_recall: 0.1421 with confidence interval (0.1398, 0.1443)
rouge_2_precision: 0.1447 with confidence interval (0.1421, 0.1471)
ROUGE-l:
rouge_l_f_score: 0.3074 with confidence interval (0.3051, 0.3097)
rouge_l_recall: 0.3164 with confidence interval (0.3138, 0.3189)
rouge_l_precision: 0.3195 with confidence interval (0.3168, 0.3222)
Some examples are shown below:
000000
REF:marseille prosecutor says so far no videos were used in the crash investigation '' despite media reports . journalists at bild and paris match are very confident '' the video clip is real , an editor says .
andreas lubitz had informed his lufthansa training school of an episode of severe depression , airline says .
DEC:french prosecutor : `` one can hear cries of ` my god ' in several languages , '' french prosecutor says .
french prosecutor says he was not aware of any video footage from on board the plane .
the video was recovered from a phone at the wreckage site .
the video was recovered from a phone at the wreckage site .
000001
REF:membership gives the icc jurisdiction over alleged crimes committed in palestinian territories since last june .
israel and the united states opposed the move , which could open the door to war crimes investigations against israelis .
DEC:the palestinian authority officially became the 123rd member of the international criminal court on wednesday .
the icc opened a preliminary examination into the situation in palestinian territories .
they also accepted its jurisdiction over alleged crimes committed `` in the occupied palestinian territory , including east jerusalem , since june 13 , 2014 ''
000002
REF:amnesty 's annual death penalty report catalogs encouraging signs , but setbacks in numbers of those sentenced to death .
organization claims that governments around the world are using the threat of terrorism to advance executions .
the number of executions worldwide has gone down by almost 22 % compared with 2013 , but death sentences up by 28 % .
DEC:amnesty international alleges in its annual report on the death penalty .
amnesty international alleges in its annual report on the death penalty .
`` it is shameful that so many states around the world are essentially playing with people 's lives , '' the report says .
000003
REF:amnesty international releases its annual review of the death penalty worldwide ; much of it makes for grim reading .
salil shetty : countries that use executions to deal with problems are on the wrong side of history .
DEC:armed soldiers were found guilty of a range of offenses linked to violent attacks in the region and jailed .
55 people were found guilty of a range of offenses linked to violent attacks in the region and jailed .
000004
REF:museum : anne frank died earlier than previously believed .
researchers re-examined archives and testimonies of survivors .
anne and older sister margot frank are believed to have died in february 1945 .
DEC:anne frank died of typhus in a nazi concentration camp at the age of 15 .
researchers re-examined archives of the red cross , the international training service and the bergen-belsen memorial , along with testimonies of survivors .
they concluded that anne and margot probably did not survive to march 1945 .
they concluded that anne and margot probably did not survive to march 1945 .
Machine  I used is GTX 1080-ti. Since I also encountered the problem of NAN  loss on the other machine, I follow the solution in another issue and change the training set to chunked data  after checkpoint at 38432(it took me about 5 days, got Rouge-2 recall 0.0882 at this checkpoint). The results seem good in Rouge scores and decoded abstract are not too weird I think.
I am wondering did I do right? Because iterations are much less than 230k (yet it spent 2 times of days on training). By the way, is there any phenomenon can be viewed as clue to start coverage mechanism or stop training rather than training time?
Thanks for any help!

@joy369 Congratulations, looks like you've got some fairly reasonable results! Remember that ROUGE scores are not a perfect measure of quality (see the discussion in section 7.1 of the paper) so you will need to do a lot of manual inspection of your summaries to gauge their quality. Are you aware of the attention visualizer tool? We find that it gives some useful clues to understand why the model produces what it does.

By the way, is there any phenomenon can be viewed as clue to start coverage mechanism or stop training rather than training time?

Coverage is designed to reduce repetition. We turned it on for a short training period at the end of training. See the paper for more details and explanation.
Mostly we stopped training when the loss on the dev set stopped dropping, or started to rise. You may find other strategies work better.

@joy369 I can see that you have succeeded in generating the result. For that, I would like to congratulate you. I have a request, please can you share with me the model or the checkpoint that gives you the result. I will be glad by your help. As I am trying to get the similar results but failing. I have tried many other tools but they failed me. Hence, I would like to test the model, if you share that with me.
Please consider my humble request.

@JafferWilson I have uploaded my checkpoint above in here:
https://drive.google.com/open?id=0B9ERf9Fj8Gh6bW1fVm5VaHQ3ams
I hope this may help you.

@joy369 I will surely test it. And I am grateful to you for your check point upload. But I guess this is GPU based Checkpoint. Is there CPU version or how I can convert? It will be helpful.

@raduk i have run decode with single_pass=1, ref and decode file are there but no rough_result.
i am using python 3.6, can you help regarding it.

I think I figured out the problem: the pyrouge package in python 2.7 generates the rouge_conf.html configuration file differently from the pyrouge in python 3.5. More precisely, the one in 3.5 generates <INPUT-FORMAT TYPE="SEE"> whereas 2.7 generates <INPUT-FORMAT TYPE="SPL">.
SPL makes the rouge script interpret the html tags as words as well (is per line matching), which explains the high ROUGE scores. SEE is the correct one for HTML.
Now I get these scores, which seem more reasonable:
1 ROUGE-1 Average_R: 0.28443 (95%-conf.int. 0.27736 - 0.29145)
1 ROUGE-1 Average_P: 0.22913 (95%-conf.int. 0.22278 - 0.23556)
1 ROUGE-1 Average_F: 0.24776 (95%-conf.int. 0.24154 - 0.25383)
1 ROUGE-2 Average_R: 0.07891 (95%-conf.int. 0.07356 - 0.08464)
1 ROUGE-2 Average_P: 0.06283 (95%-conf.int. 0.05836 - 0.06727)
1 ROUGE-2 Average_F: 0.06816 (95%-conf.int. 0.06340 - 0.07314)
1 ROUGE-3 Average_R: 0.03494 (95%-conf.int. 0.03079 - 0.03904)
1 ROUGE-3 Average_P: 0.02780 (95%-conf.int. 0.02446 - 0.03128)
1 ROUGE-3 Average_F: 0.03016 (95%-conf.int. 0.02665 - 0.03381)
1 ROUGE-4 Average_R: 0.01884 (95%-conf.int. 0.01577 - 0.02204)
1 ROUGE-4 Average_P: 0.01507 (95%-conf.int. 0.01263 - 0.01766)
1 ROUGE-4 Average_F: 0.01630 (95%-conf.int. 0.01373 - 0.01907)
1 ROUGE-L Average_R: 0.25577 (95%-conf.int. 0.24911 - 0.26218)
1 ROUGE-L Average_P: 0.20593 (95%-conf.int. 0.20012 - 0.21176)
1 ROUGE-L Average_F: 0.22271 (95%-conf.int. 0.21701 - 0.22858)
1 ROUGE-W-1.2 Average_R: 0.12043 (95%-conf.int. 0.11713 - 0.12381)
1 ROUGE-W-1.2 Average_P: 0.15987 (95%-conf.int. 0.15547 - 0.16443)
1 ROUGE-W-1.2 Average_F: 0.13347 (95%-conf.int. 0.13015 - 0.13704)
1 ROUGE-S* Average_R: 0.07204 (95%-conf.int. 0.06810 - 0.07603)
1 ROUGE-S* Average_P: 0.04788 (95%-conf.int. 0.04503 - 0.05083)
1 ROUGE-S* Average_F: 0.05255 (95%-conf.int. 0.04972 - 0.05523)
1 ROUGE-SU* Average_R: 0.08544 (95%-conf.int. 0.08127 - 0.08949)
1 ROUGE-SU* Average_P: 0.05661 (95%-conf.int. 0.05361 - 0.05966)
1 ROUGE-SU* Average_F: 0.06245 (95%-conf.int. 0.05946 - 0.06531)
I'll try retraining with the fix you mentioned for data preprocessing.
Thanks for the help.

@raduk do you get these numbers using Python3?
Another related question - How much time did it take to run for all 11.5k test samples?
CC: @abisee

I think I figured out the problem: the pyrouge package in python 2.7 generates the rouge_conf.html configuration file differently from the pyrouge in python 3.5. More precisely, the one in 3.5 generates <INPUT-FORMAT TYPE="SEE"> whereas 2.7 generates <INPUT-FORMAT TYPE="SPL">.
SPL makes the rouge script interpret the html tags as words as well (is per line matching), which explains the high ROUGE scores. SEE is the correct one for HTML.
Now I get these scores, which seem more reasonable:
1 ROUGE-1 Average_R: 0.28443 (95%-conf.int. 0.27736 - 0.29145)
1 ROUGE-1 Average_P: 0.22913 (95%-conf.int. 0.22278 - 0.23556)
1 ROUGE-1 Average_F: 0.24776 (95%-conf.int. 0.24154 - 0.25383)
1 ROUGE-2 Average_R: 0.07891 (95%-conf.int. 0.07356 - 0.08464)
1 ROUGE-2 Average_P: 0.06283 (95%-conf.int. 0.05836 - 0.06727)
1 ROUGE-2 Average_F: 0.06816 (95%-conf.int. 0.06340 - 0.07314)
1 ROUGE-3 Average_R: 0.03494 (95%-conf.int. 0.03079 - 0.03904)
1 ROUGE-3 Average_P: 0.02780 (95%-conf.int. 0.02446 - 0.03128)
1 ROUGE-3 Average_F: 0.03016 (95%-conf.int. 0.02665 - 0.03381)
1 ROUGE-4 Average_R: 0.01884 (95%-conf.int. 0.01577 - 0.02204)
1 ROUGE-4 Average_P: 0.01507 (95%-conf.int. 0.01263 - 0.01766)
1 ROUGE-4 Average_F: 0.01630 (95%-conf.int. 0.01373 - 0.01907)
1 ROUGE-L Average_R: 0.25577 (95%-conf.int. 0.24911 - 0.26218)
1 ROUGE-L Average_P: 0.20593 (95%-conf.int. 0.20012 - 0.21176)
1 ROUGE-L Average_F: 0.22271 (95%-conf.int. 0.21701 - 0.22858)
1 ROUGE-W-1.2 Average_R: 0.12043 (95%-conf.int. 0.11713 - 0.12381)
1 ROUGE-W-1.2 Average_P: 0.15987 (95%-conf.int. 0.15547 - 0.16443)
1 ROUGE-W-1.2 Average_F: 0.13347 (95%-conf.int. 0.13015 - 0.13704)
1 ROUGE-S* Average_R: 0.07204 (95%-conf.int. 0.06810 - 0.07603)
1 ROUGE-S* Average_P: 0.04788 (95%-conf.int. 0.04503 - 0.05083)
1 ROUGE-S* Average_F: 0.05255 (95%-conf.int. 0.04972 - 0.05523)
1 ROUGE-SU* Average_R: 0.08544 (95%-conf.int. 0.08127 - 0.08949)
1 ROUGE-SU* Average_P: 0.05661 (95%-conf.int. 0.05361 - 0.05966)
1 ROUGE-SU* Average_F: 0.06245 (95%-conf.int. 0.05946 - 0.06531)
I'll try retraining with the fix you mentioned for data preprocessing.
Thanks for the help.

@raduk do you get these numbers using Python3?
Another related question - How much time did it take to run for all 11.5k test samples?
CC: @abisee

You cam try find and replace all SEE values to SPL in rouge_conf.html.  In my case (12.5 K) it took about an hour.

I think I figured out the problem: the pyrouge package in python 2.7 generates the rouge_conf.html configuration file differently from the pyrouge in python 3.5. More precisely, the one in 3.5 generates <INPUT-FORMAT TYPE="SEE"> whereas 2.7 generates <INPUT-FORMAT TYPE="SPL">.
SPL makes the rouge script interpret the html tags as words as well (is per line matching), which explains the high ROUGE scores. SEE is the correct one for HTML.
Now I get these scores, which seem more reasonable:
1 ROUGE-1 Average_R: 0.28443 (95%-conf.int. 0.27736 - 0.29145)
1 ROUGE-1 Average_P: 0.22913 (95%-conf.int. 0.22278 - 0.23556)
1 ROUGE-1 Average_F: 0.24776 (95%-conf.int. 0.24154 - 0.25383)
1 ROUGE-2 Average_R: 0.07891 (95%-conf.int. 0.07356 - 0.08464)
1 ROUGE-2 Average_P: 0.06283 (95%-conf.int. 0.05836 - 0.06727)
1 ROUGE-2 Average_F: 0.06816 (95%-conf.int. 0.06340 - 0.07314)
1 ROUGE-3 Average_R: 0.03494 (95%-conf.int. 0.03079 - 0.03904)
1 ROUGE-3 Average_P: 0.02780 (95%-conf.int. 0.02446 - 0.03128)
1 ROUGE-3 Average_F: 0.03016 (95%-conf.int. 0.02665 - 0.03381)
1 ROUGE-4 Average_R: 0.01884 (95%-conf.int. 0.01577 - 0.02204)
1 ROUGE-4 Average_P: 0.01507 (95%-conf.int. 0.01263 - 0.01766)
1 ROUGE-4 Average_F: 0.01630 (95%-conf.int. 0.01373 - 0.01907)
1 ROUGE-L Average_R: 0.25577 (95%-conf.int. 0.24911 - 0.26218)
1 ROUGE-L Average_P: 0.20593 (95%-conf.int. 0.20012 - 0.21176)
1 ROUGE-L Average_F: 0.22271 (95%-conf.int. 0.21701 - 0.22858)
1 ROUGE-W-1.2 Average_R: 0.12043 (95%-conf.int. 0.11713 - 0.12381)
1 ROUGE-W-1.2 Average_P: 0.15987 (95%-conf.int. 0.15547 - 0.16443)
1 ROUGE-W-1.2 Average_F: 0.13347 (95%-conf.int. 0.13015 - 0.13704)
1 ROUGE-S* Average_R: 0.07204 (95%-conf.int. 0.06810 - 0.07603)
1 ROUGE-S* Average_P: 0.04788 (95%-conf.int. 0.04503 - 0.05083)
1 ROUGE-S* Average_F: 0.05255 (95%-conf.int. 0.04972 - 0.05523)
1 ROUGE-SU* Average_R: 0.08544 (95%-conf.int. 0.08127 - 0.08949)
1 ROUGE-SU* Average_P: 0.05661 (95%-conf.int. 0.05361 - 0.05966)
1 ROUGE-SU* Average_F: 0.06245 (95%-conf.int. 0.05946 - 0.06531)
I'll try retraining with the fix you mentioned for data preprocessing.
Thanks for the help.

@raduk do you get these numbers using Python3?
Another related question - How much time did it take to run for all 11.5k test samples?
CC: @abisee

You can try find and replace all SEE values to SPL in rouge_conf.html. In my case (12.5 K) it took about an hour.

Hello,
How to modify the conf file? it is generated while the rouge is calculated


Doesn't work migration with option default

Working with existing table I've detected that default value wasn't changed after migration.
In initial table we have column like:
user_id    int    default 0   not null,
I need to change it to nullable with default null value. In migration:
$this->table('record')
            ->alterColumn('user_id', 'integer', [
                'nullable' => true,
                'default' => null
            ])
        ->update();

After migration default value for this column was not changed:
user_id    int    default 0    null,
used driver is MySQL

Can not reproduce :(


Fixes #603 IronPython: Must remove paths from "Search Paths" and put …

Fixes #603 IronPython: Must remove paths from "Search Paths" and put them back for Intellisense to work
Triggers AnalysisDirectoryChanged in case search paths already exist.
Adds test

:+1:


Added some clarification about the state and origin of this project

Signed-off-by: Arnaud J Le Hors -<EMAIL_ADDRESS>

Signed-off-by: Arnaud J Le Hors -<EMAIL_ADDRESS>

@lehors I would suggest this change be on the repo (fabric) description rather than in the readme of the code, so that developers don't have to be sidetracked with anything else but set up instruction.

@binhn I understand. I don't have access rights to the repo description so, you'll have to make the change then.
I do think it is important to respond to the concerns expressed by several people that the status isn't clear enough and the name may lead people to believe this is the fabric of the Hyperledger Project rather than just an incubator.

@lehors Ok, I can bring your changes over to the repo description and close this PR. Thanks

@binh Please, change the link to the new project lifecycle page: https://github.com/hyperledger/hyperledger/wiki/Project-Lifecycle
We can close this PR after that.
Thanks.


Address cases where options passed to preprocessor would result in a TypeError

Fixes #345

Thanks :)

:tada: This PR is included in version 2.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


changes query according to requirement

Changes in query to also return months with 0 count in response.
{
  "type":"success",
  "title":"success",
  "result":[
    {
      "month":"december",
      "year":2022,
     "count":0
    },
   {
     "month":"January",
     "year":2023,
     "count":23363
   }
  ]
}

Can one of the admins verify this patch?

ok to test

retest this please

retest this please

retest this please


API Updates for usability and stability

Description
Generated classes are marked as Serializable, but they shouldn't be treated as such, especially when combined with the ability for instances to make API callbacks.
Related Issue
Fixes:

#29
#25
#24
#21

Motivation and Context
Through further use case testing, additional API capabilities and consumer protection was needed.
How Has This Been Tested?
Full suite of unit/functional tests provided.
Screenshots (if appropriate):
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Hey @badvision - any other recommendations? Thanks!


Add missing test cases to panda utilities

Relates to issue #550
Implemented test cases for CtCode class.
According to the coverage report, 100% coverage on the class under test.
Any feedback welcome.

Coverage increased (+0.3%) to 56.291% when pulling a372bc6c424c35e51f054e9987115b2b8cc0e104 on nitram509:Add_missing_test_cases_to_Panda_Utilities into 0d2029aabcf34a57def1ff3b9e89c2a8e39baf42 on panda-lang:master.

Thanks, it looks great! I'm ready to merge the PR.
Do you participate in Hacktoberfest? If so, I'll need to add an extra label :)

You're welcome.
and indeed, I'm participating in hacktoberfest.
I would appreciate it if you could add the "hacktoberfest-accepted" label.


Update Non-SD Subpanel.vi   - Abort if subpanel VI is not Idle after …

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Fixes issue #16 in the scan engine custom device (dev/fix16issue pull request in review).
Why should this Pull Request be merged?
Improves usability in configuring the scan engine custom device.  Similar changes are being reviewed in the scan engine custom device codebase, where this module libraries fix extends to the subpanels of the subpanels.
What testing has been done?
This custom device, along with a matching fix to the scan engine custom device (https://github.com/ni/niveristand-scan-engine-ethercat-custom-device/tree/dev/fix16issue), was built and tested interactively in VS 2018.

In SD_Module_UI.vi

[ ] Do we understand why this close call was disabled?

In Update Non-SD Subpanel.vi

[ ] Never send a boolean to do an enum's job. Use a case structure instead of an equality operator to check idle state. This allows for future handling of other states if needed.

[ ] Create a subVI for checking the VI execution state and aborting the sub panel. Call the new subVI from Update Non-SD Subpanel. This follows the principle of clean code where we have lots of small functional blocks instead one big functional block of code.

The FP.Close was disabled from the first submission of the custom device.  It is inconsistent with all other subpanel "page" VIs.  Likely used for initial debugging of this very issue, then left disabled unfortunately.
I've made the other recommended changes to both this and the scan engine modules custom device.

[ ] Remove the volumes of empty space in Update Non-SD Subpanels.vi. It should look something like this. Each block diagram change at this point of the release should aim to be small and surgical. Ideally it's just the original code with the new subVI inserted.


Add RPC support (services) [15364]

Merge after #249
Tasks:

[X] Implement RPC support for multiple clients
[X] Implement RPC support for multiple servers (in touch with same or different DDS-Router participants)
[x] Dynamically enable/disable services depending on the availability of servers
[x] Dynamically enable/disable services according to allowlist/blocklist (after configuration reload)
[x] Support repeater configuration option
[ ] Add docker-compose blackbox tests (with and without repeater)
[ ] (optional) Add new testing service example developed with Fast-DDS library
[x] Hard-code default service QoS (temporal)
[x] Improve error handling
[x] Improve log traces
[ ] Document code
[ ] Modify documentation if required
[x] Release notes

Caveats:

No synchronization between matching threads of proxy servers and clients. Add if frequent race conditions arise. Note that it is only possible to reduce the probability of occurrence, but it cannot be completely avoided.

Closed in favor of #281


Broken path to bower_components directory

When I run wct from the root of my project, I get an error telling me to install web-component-tester as a dependency. However, I've already installed web-component-tester as a dev-dependency using Bower.
My bower_components are installed at ./public/bower_components in my project but wct is looking for my bower components at ./bower_components
Does anyone know how I can change the path of where wct looks for my bower components?

You can try configuring your .bowerrc
https://bower.io/docs/config/
{
  "directory": "./public/bower_components"
}