3D visualization for room

I want to create 3D visualization for room, not the building.
So, I can click on a room and show its attribute.
Is it possible?

No, not directly, because the 3DCityDB Exporter can only export so-called "top-level features" like Building, Road etc. as visualization objects that are clickable.
But you can do a "hack" and use one (or maybe a few) SQL statement(s) and copy the tuples from the ROOM table into the table GENERIC_CITYOBJECT. Since GenericCityObjects are "top-level features" you can then export them as clickable objects using the KML/COLLADA/glTF exporter. If the attributes assigned to the rooms are generic attributes, you can also use the Spreadsheet Exporter to export them from the GenericCityObjects. When you export the rooms as GenericCityObjects, you should choose a slightly transparent coloring in the visualization export preferences.

You can export without SQL filter, if you do not have any other GenericCityObjects in your dataset. Just export the GenericCityObjects in LOD4.
I forgot to add that after the SQL statement you will also need to do a commit; statement. Otherwise your updates to the database are only visible within the current psql or pgAdmin session. Only after a commit the inserted tuples will be accessible and visible to other processes like the visualization exporter.

You can export without SQL filter, if you do not have any other GenericCityObjects in your dataset. Just export the GenericCityObjects in LOD4.
I forgot to add that after the SQL statement you will also need to do a commit; statement. Otherwise your updates to the database are only visible within the current psql or pgAdmin session. Only after a commit the inserted tuples will be accessible and visible to other processes like the visualization exporter.

i already use commit after SQL Statement. but still got info message No Top Level Feature when Vis-Export.
is any possibility this issue from my GML file ?

This simple hack will only work, if the room geometries in your CityGML file are attached as properties directly with the Room features (as lod4Solid or lod4MultiSurface). Is this the case with your dataset?
If the Room features do not have geometries, but only thematic surfaces like "FloorSurface", "CeilingSurface" and the geometries are associated only with them, you will need to collect all the individual surfaces which are related to each room (stored in the table THEMATIC_SURFACE) and create a new MultiSurface within the SURFACE_GEOMETRY table. But this is quite more tricky than just one SQL statement.

There is one more thing to consider: You have to add an additional entry in the cityobject table for each generic city object to make this workaround work. The reason is that the exporter first searches the cityobject table to find the top-level city objects to be exported.
This should be the sequence of steps to perform:

Query the room table to get the IDs of your room objects.
For each room, find its corresponding tuple in cityobject using the ID value from step 1. Create a new tuple in cityobject by copying the values from the room tuple (use insert into ... as select from). Be careful to not copy the ID value but create a new one using the cityobject_seq sequence. And do not copy the OBJECTCLASS_ID value but use 5 instead.
For each room, create a new entry in generic_cityobject as shown in the post from @thomashkolbe. Use the ID value just created from the sequence, and again use 5 for the OBJECTCLASS_ID.

I'm pretty sure you can do this with one SQL statement if the geometry is stored with the room objects in the room table as outlined by @thomashkolbe.

thanks @thomashkolbe and @clausnagel . i will check my GML first. if geometries attributes is exist i will try the SQL Statement again.

Thanks, @clausnagel, you are right; I forgot about the missing tuple in the CITYOBJECT table.
I mean, we are talking here about a "hack", and you could possibly simplify this by setting the OBJECTCLASS_ID of the tuples representing the rooms to 5. Then the exporter would recognize them as GenericCityObjects. This could be done with such a statement:
insert into GENERIC_CITYOBJECT (id, objectclass_id, class, function, usage, lod4_brep_id) as
           select id, 5, class, function, usage, lod4_solid_id from ROOM;
update CITYOBJECT set objectclass_id=5 where objectclass_id=41;
commit;

After these changes, you probably can no longer export the Buildings correctly. One possibility is to reverse the update statement above by reassigning 41 to the OBJECTCLASS_ID of those city objects, whose ID values are included in the set of ID values included in the ROOM table.
OF COURSE, DO NOT PERFORM SUCH EXPERIMENTS ON A PRODUCTION DATABASE, BECAUSE IT MAY / WILL CORRUPT YOUR DATABASE!

hi @thomashkolbe and @clausnagel i can show my room now. but i have another problem , my building have four floor but after i do your hack , only show first floor. it's possibilty on my GML or another possibilty ? thank you

Please check your GML file, if more than one room is included and that their geometries are represented as a direct property (lod4Solid or lod4MultiSurface) of the BuildingRoom objects. The hack only works, if the geometries of all rooms are represented by lod4Solid properties. If some rooms use lod4MultiSurface instead, then you would need to modify the insert statement and add another insert statement dealing with those rooms that use lod4MultiSurface. For visual inspection of CityGML datasets I recommend to use the free software FZKViewer https://www.iai.kit.edu/english/1302.php.
BTW, are you sure that your visualization only shows one room? When you move the mouse pointer along the vertical extent of the building, maybe different rooms on different storeys will be highlighted then. I recommend to render the rooms using a semi-transparent color, this way you can see, if maybe more rooms are hidden in the model.

BTW, are you sure that your visualization only shows one room? When you move the mouse pointer along the vertical extent of the building, maybe different rooms on different storeys will be highlighted then. I recommend to render the rooms using a semi-transparent color, this way you can see, if maybe more rooms are hidden in the model.
not only one room but only first floor (which have 12 room).
 I recommend to use the free software FZKViewer
i already using FME and FZKViewer before import to 3dcitydb. and the result each room can be clicked for all floors.

Can't say more without looking at the GML file. Could you provide it?

can i know your e-mail address ?

You'll find it here: https://www.asg.ed.tum.de/en/gis/our-team/staff/prof-thomas-h-kolbe/

already send to your email , thanks @thomashkolbe

Well, while the file is syntactically correct (it validates against the CityGML schema), it seems to have a number of problems. While I can visualize the model in FME, I can't using the FZKViewer nor the CityDoctor software. In FZKViewer the room geometries are not shown, which it normally does. CityDoctor issues a long list of problems including self-intersecting polygons, duplicate points in a number of LinearRings. I can't go further, because it is not clear what is causing the problem.
Please check, if the presented hack above works with this open dataset: http://www.citygmlwiki.org/index.php?title=File:FZK-Haus-LoD4-KIT-IAI-KHH-B36-V1.gml
If it works, the problem is most likely related to your dataset.
Also try to indentify and remove the errors from your dataset using the freely downloadable CityDoctor: https://www.citydoctor.eu/en/citydoctor_main.html

hello mr.thomas and mr.clausnagel, i am on same team project with @dikyridhlo.
we try new file for test. we have check the gml file on fkzviewer and citydoctor, and no error appear

this building have 10 room. but when i open with viewer, only 3 room can be clicked.

this is the sample gml i use
sample_gml.zip

hi @clausnagel and @thomashkolbe can you answer my team question, please?

Hi @dikyridhlo, the file has some issues, for example are the doors and windows not included in the building object. They are also in the wrong namespace (brid:). But this should not cause a problem with the rooms. However, you will have to look for the problem for yourself by inspecting the table data.
BTW, did you try the file I named before? Did it work? If yes, then inspect the contents of the involved tables (after having applied the hack) using pgAdmin and compare in which way the table contents look different from the contents when you have imported your model and have applied the hack then. You will need to look at every tuple in the tables and comprehend the way how CityGML data is being mapped onto the diverse tables as explained in the documentation (this is what I would do if it was my project).

I try your file @thomashkolbe and only 5 tiles can be clicked (mark on the red checklist), it is true?

Hi @dikyridhlo, the file has some issues, for example are the doors and windows not included in the building object. They are also in the wrong namespace (brid:). But this should not cause a problem with the rooms. However, you will have to look for the problem for yourself by inspecting the table data.
let me check my GML file for a while.

When you create a visualization export, only export the GenericCityObjects and not also the Buildings at the same time. You will have to configure the visualization exporter in such a way that it does not automatically pulls down the 3D objects to the ground (Altitude mode "absolute" in the "Elevation" submenu in the "VIS Export" menu). Otherwise all rooms on the higher levels will all be pulled to base height zero as shown in your figure above.


thirdeye data layer refactor

Refactoring data layer. Created AbstractEntity with common table fields. removing duplicate code across other entities.
TODO:

adding unit tests
utilizing JPA features

LGTM


#102 Onboarding Modal & Component Updates

New Onboarding Modal
For new users, when they land on the dashboard for the first time, they'll see a popup with a little carousel where we can add in content / graphics / icons. Feel free to customize this for what content you think will be useful. I left it kind of generic for now.

Homepage Updates
I noticed a behavior where the homepage would rerender the logged in view, before the instance creation widget was finished. This was causing a weird flash of content before the user was redirected to the dashboard. I realized that the entire instance generator widget was being unmounted right after it logged the user in, so instead I just added the instance generator for all users. Now if you're logged in and go to the homepage, you'll see the prompt to create a new instance. This way the "loading" state will persist even as the user is being logged into the site.
Component Updates
<AuthStateGuard>
Several components needed the <AuthStateGuard> wrapper, so these were moved into the component themselves so that random pages didn't need to import it in. This way the component handles all the logic related to the component itself.
<InstanceGeneratorWidget>
The Instance Creation Widget will now hide the email and password if it detects the user is logged in. It also skips the entire registration system if you are already logged in.
database.ts
The instance generator function was using a mix of promises and awaits. I simplified it all down to just awaits. Did you like the promise syntax more? If so I can switch it back. Let me know what you'd like.
<VerifyAccountBar>
This was causing a layout shift for about a second when the Instance Creation Widget was used. The delay between that and the redirect to the Dashboard cause the alert banner to show up. To fix this, the alert banner is now hidden until the user has dismissed the onboarding modal.
Bug Fixes

The <InstanceGeneratorWidget> component lost its goto() method at some point so this was added back in. Now creating an instance on the home screen will correctly send the user to the Dashboard page.
Removed unused fade import on the Dashboard
On mobile, the menu button was being pushed down because of the new version number, so the logo size is now reduced on mobile

Miscellaneous
Several console logs were removed across the site. They were looping and filling up the console and I couldn't read any of my own console logs lol.

This is the first pass at the onboarding modal. Let me know what you think and if you want me to change directions.
Next i'll make sure it looks fine on mobile and dark mode.

Dark mode and mobile looking fine for me now. Ready for review

Hey @brewhousedigital just a heads up that I have a pretty big PR coming in soon. You may want to wrap this up before it gets too far away from master.

Hey @benallfree ! Holidays + work picked up real fast and threw me off my groove. Just merged your PR on this and got everything synced.
Is setting the isFirstTimeRegistration value in the DB overkill? Since it's only used for like 5 seconds then discarded after the modal is dismissed?

What if we introduced a prefs field in the users table and it was just a generic json object? Then it could be used for other things as well without having to make schema changes. Thoughts?

Hey @brewhousedigital, check out https://github.com/benallfree/pockethost/commit/b17d9a477bd74c5cd1b82804ba0bf76c8c25c9df in master. I added a preferences field and model typings for it. As you can see, it is using PartialDeep to remind us that the preferences field is untrusted in the sense that no validation or schema is enforced at this time. PocketBase doesn't have a way to do JSON schema validation server-side, so for now we will leave it as an untrusted field where you need to manually verify that every key you use actually exists (as well as the JSON object itself).
If you like this approach, go ahead and merge. I don't think any backend changes are required at this time.

Hey @brewhousedigital We are about to lose this PR because I have a big merge coming in soon. Any chance we can get this merged first?

Hey Ben! I've been swamped with work. If you want, we can abandon this PR and I can come back to it once your new one is merged in.


Make the Getting Started example executable

The first thing most folks want to do on a Getting Started page is to run the example so this swaps out the local path for one present on all installs.
Also moves the os import down to where it is used to keep things simpler.

Thanks.


Ish doesn't support Old English

Ish doesn't support Old English, either written in Latin script or in Futhorc. My users often get confused as to where they've ended up in, as their time-travelling tools aren't great yet, and my application doesn't work very well for them.

They are, as I'm sure you know, "Ġēse" and "Nese" (i.e., '\u16b7\u16d6\u16cb\u16d6' and '\u16be\u16d6\u16cb\u16d6').

If you create a pull request adding these to the ish script (don't forget unit tests!) I will merge this essential improvement.

I'll make sure this gets done soon, even if it means working over the weekend.


docs: remove obsolete statement on ARM support

Coverage: 80.973%. Remained the same when pulling 11e79545e2bc28152d4fd803f87bd18e25fdf08e on fix-arm-statement into 920d90d13cfe338f97312cc0873d95e35ba86d87 on master.


Clarify the External Runs (and the names of each of them)

I know that this was a matter of long thinking and discusion, but I think two things might improve this:

Adding a tooltip on the 'External Runs' button. The tooltip could say "generate links to access the study externally" or "generate links to run the study from outside Jatos".

Changing the Open standalone, closed standalone, etc to:
-Personal multisession (aka Tester run)
-Personal single session (aka Closed Standalone)
-General single session (aka Open standalone)

I really agree that these names as we have them now don't make too much sense. the 'Standalone' part of the name just say that it's not MTurk. But then MTurk is somehow implied to be the default option. Also, 'Open' and 'Closed' aren't really as informative as they could be. I think that the alternatives are better. What do you think?

We shouldn't use 'session' in different contexts. We already use it in
study session. How about just 'Personal Multi' ...?
On Thu, Apr 23, 2015 at 5:14 PM, elisafilevich<EMAIL_ADDRESS>wrote:

I know that this was a matter of long thinking and discusion, but I think
two things might improve this:

Adding a tooltip on the 'External Runs' button. The tooltip could say
"generate links to access the study externally" or "generate links to run
the study from outside Jatos".
2.
Changing the Open standalone, closed standalone, etc to:
-Personal multisession (aka Tester run)
-Personal single session (aka Closed Standalone)
-General single session (aka Open standalone)
I really agree that these names as we have them now don't make too much
sense. the 'Standalone' part of the name just say that it's not MTurk. But
then MTurk is somehow implied to be the default option. Also, 'Open' and
'Closed' aren't really as informative as they could be. I think that the
alternatives are better. What do you think?
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81.

We could use 'Personal Multi’ alone. Or maybe ‘Personal Multiple’ or ‘Personal multiple access’.
But I thought that the “session” corresponds to the “study session data”. Don’t you think?

On 23 Apr 2015, at 17:54, Kristian Lange<EMAIL_ADDRESS>wrote:
We shouldn't use 'session' in different contexts. We already use it in
study session. How about just 'Personal Multi' ...?
On Thu, Apr 23, 2015 at 5:14 PM, elisafilevich<EMAIL_ADDRESS>wrote:

I know that this was a matter of long thinking and discusion, but I think
two things might improve this:

Adding a tooltip on the 'External Runs' button. The tooltip could say
"generate links to access the study externally" or "generate links to run
the study from outside Jatos".
2.
Changing the Open standalone, closed standalone, etc to:
-Personal multisession (aka Tester run)
-Personal single session (aka Closed Standalone)
-General single session (aka Open standalone)
I really agree that these names as we have them now don't make too much
sense. the 'Standalone' part of the name just say that it's not MTurk. But
then MTurk is somehow implied to be the default option. Also, 'Open' and
'Closed' aren't really as informative as they could be. I think that the
alternatives are better. What do you think?
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81.

—
Reply to this email directly or view it on GitHub https://github.com/JATOS/JATOS/issues/81#issuecomment-95632074.

I like 'Personal Multiple/Single' and 'General Multiple/Single'.
To be precise, what would it be?

Tester Run -> Personal Multiple
Closed Standalone ->  Personal Single
Open Standalone -> General Single

?
On Thu, Apr 23, 2015 at 5:56 PM, elisafilevich<EMAIL_ADDRESS>wrote:

We could use 'Personal Multi’ alone. Or maybe ‘Personal Multiple’ or
‘Personal multiple access’.
But I thought that the “session” corresponds to the “study session data”.
Don’t you think?

On 23 Apr 2015, at 17:54, Kristian Lange<EMAIL_ADDRESS>wrote:
We shouldn't use 'session' in different contexts. We already use it in
study session. How about just 'Personal Multi' ...?
On Thu, Apr 23, 2015 at 5:14 PM, elisafilevich<EMAIL_ADDRESS>wrote:

I know that this was a matter of long thinking and discusion, but I
think
two things might improve this:

Adding a tooltip on the 'External Runs' button. The tooltip could say
"generate links to access the study externally" or "generate links to
run
the study from outside Jatos".
2.
Changing the Open standalone, closed standalone, etc to:
-Personal multisession (aka Tester run)
-Personal single session (aka Closed Standalone)
-General single session (aka Open standalone)
I really agree that these names as we have them now don't make too much
sense. the 'Standalone' part of the name just say that it's not MTurk.
But
then MTurk is somehow implied to be the default option. Also, 'Open'
and
'Closed' aren't really as informative as they could be. I think that
the
alternatives are better. What do you think?
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81.

—
Reply to this email directly or view it on GitHub <
https://github.com/JATOS/JATOS/issues/81#issuecomment-95632074>.

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95632610.

How about:

Tester Run -> Personal Multiple Run
Closed Standalone ->  Personal Single Run
Open Standalone -> General Single Run

Agreed.
How about we change the logo from the play triangle to a little running
woman?
On 24 Apr 2015 10:32, "elisafilevich"<EMAIL_ADDRESS>wrote:

How about:

Tester Run -> Personal Multiple Run
Closed Standalone -> Personal Single Run
Open Standalone -> General Single Run

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95852348.

I personally like the play triangle better, and I think it’s clearer.
But I know that in at least one psychology experiment program (ePrime) there is a little running guy.
Can you send me a link to the icon?

On 24 Apr 2015, at 10:36, Kristian Lange<EMAIL_ADDRESS>wrote:
Agreed.
How about we change the logo from the play triangle to a little running
woman?
On 24 Apr 2015 10:32, "elisafilevich"<EMAIL_ADDRESS>wrote:

How about:

Tester Run -> Personal Multiple Run
Closed Standalone -> Personal Single Run
Open Standalone -> General Single Run

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95852348.

—
Reply to this email directly or view it on GitHub https://github.com/JATOS/JATOS/issues/81#issuecomment-95853309.

Unfortunately Bootstrap has no icon with a little running woman. But how
about an icon that depicts cutlery? Now you can eat your study? Look in
http://getbootstrap.com/components/ for glyphicon-cutlery.
On Fri, Apr 24, 2015 at 10:39 AM, elisafilevich<EMAIL_ADDRESS>wrote:

I personally like the play triangle better, and I think it’s clearer.
But I know that in at least one psychology experiment program (ePrime)
there is a little running guy.
Can you send me a link to the icon?

On 24 Apr 2015, at 10:36, Kristian Lange<EMAIL_ADDRESS>wrote:
Agreed.
How about we change the logo from the play triangle to a little running
woman?
On 24 Apr 2015 10:32, "elisafilevich"<EMAIL_ADDRESS>wrote:

How about:

Tester Run -> Personal Multiple Run
Closed Standalone -> Personal Single Run
Open Standalone -> General Single Run

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95852348.

—
Reply to this email directly or view it on GitHub <
https://github.com/JATOS/JATOS/issues/81#issuecomment-95853309>.

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95853770.

Bupo says no cutlery! Keep the play triangle.
But how about the globe glyphicon for the external runs?

On 24 Apr 2015, at 12:22, Kristian Lange<EMAIL_ADDRESS>wrote:
Unfortunately Bootstrap has no icon with a little running woman. But how
about an icon that depicts cutlery? Now you can eat your study? Look in
http://getbootstrap.com/components/ for glyphicon-cutlery.
On Fri, Apr 24, 2015 at 10:39 AM, elisafilevich<EMAIL_ADDRESS>wrote:

I personally like the play triangle better, and I think it’s clearer.
But I know that in at least one psychology experiment program (ePrime)
there is a little running guy.
Can you send me a link to the icon?

On 24 Apr 2015, at 10:36, Kristian Lange<EMAIL_ADDRESS>wrote:
Agreed.
How about we change the logo from the play triangle to a little running
woman?
On 24 Apr 2015 10:32, "elisafilevich"<EMAIL_ADDRESS>wrote:

How about:

Tester Run -> Personal Multiple Run
Closed Standalone -> Personal Single Run
Open Standalone -> General Single Run

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95852348.

—
Reply to this email directly or view it on GitHub <
https://github.com/JATOS/JATOS/issues/81#issuecomment-95853309>.

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95853770.

—
Reply to this email directly or view it on GitHub https://github.com/JATOS/JATOS/issues/81#issuecomment-95883177.

Dev is sad. But the globe is a good idea. I'll do it.
On Fri, Apr 24, 2015 at 12:24 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Bupo says no cutlery! Keep the play triangle.
But how about the globe glyphicon for the external runs?

On 24 Apr 2015, at 12:22, Kristian Lange<EMAIL_ADDRESS>wrote:
Unfortunately Bootstrap has no icon with a little running woman. But how
about an icon that depicts cutlery? Now you can eat your study? Look in
http://getbootstrap.com/components/ for glyphicon-cutlery.
On Fri, Apr 24, 2015 at 10:39 AM, elisafilevich <
<EMAIL_ADDRESS>wrote:

I personally like the play triangle better, and I think it’s clearer.
But I know that in at least one psychology experiment program (ePrime)
there is a little running guy.
Can you send me a link to the icon?

On 24 Apr 2015, at 10:36, Kristian Lange<EMAIL_ADDRESS>wrote:
Agreed.
How about we change the logo from the play triangle to a little
running
woman?
On 24 Apr 2015 10:32, "elisafilevich"<EMAIL_ADDRESS>wrote:

How about:

Tester Run -> Personal Multiple Run
Closed Standalone -> Personal Single Run
Open Standalone -> General Single Run

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95852348.

—
Reply to this email directly or view it on GitHub <
https://github.com/JATOS/JATOS/issues/81#issuecomment-95853309>.

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95853770.

—
Reply to this email directly or view it on GitHub <
https://github.com/JATOS/JATOS/issues/81#issuecomment-95883177>.

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95883639.

It could look like this. With triangles and globe. What do you think?
On Fri, Apr 24, 2015 at 12:57 PM, Kristian Lange<EMAIL_ADDRESS>wrote:

Dev is sad. But the globe is a good idea. I'll do it.
On Fri, Apr 24, 2015 at 12:24 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Bupo says no cutlery! Keep the play triangle.
But how about the globe glyphicon for the external runs?

On 24 Apr 2015, at 12:22, Kristian Lange<EMAIL_ADDRESS>wrote:
Unfortunately Bootstrap has no icon with a little running woman. But how
about an icon that depicts cutlery? Now you can eat your study? Look in
http://getbootstrap.com/components/ for glyphicon-cutlery.
On Fri, Apr 24, 2015 at 10:39 AM, elisafilevich <
<EMAIL_ADDRESS>wrote:

I personally like the play triangle better, and I think it’s clearer.
But I know that in at least one psychology experiment program (ePrime)
there is a little running guy.
Can you send me a link to the icon?

On 24 Apr 2015, at 10:36, Kristian Lange<EMAIL_ADDRESS>wrote:
Agreed.
How about we change the logo from the play triangle to a little
running
woman?
On 24 Apr 2015 10:32, "elisafilevich"<EMAIL_ADDRESS>wrote:

How about:

Tester Run -> Personal Multiple Run
Closed Standalone -> Personal Single Run
Open Standalone -> General Single Run

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95852348.

—
Reply to this email directly or view it on GitHub <
https://github.com/JATOS/JATOS/issues/81#issuecomment-95853309>.

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95853770.

—
Reply to this email directly or view it on GitHub <
https://github.com/JATOS/JATOS/issues/81#issuecomment-95883177>.

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95883639.

Like what?

Updated the last comment with the screenshot.

Looks nice, I think.

Do your job, dear bupo. Decide!
On Fri, Apr 24, 2015 at 1:47 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Looks nice, I think.
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95907694.

Yes!
Developers! They don’t understand language nuances!

On 24 Apr 2015, at 13:53, Kristian Lange<EMAIL_ADDRESS>wrote:
Do your job, dear bupo. Decide!
On Fri, Apr 24, 2015 at 1:47 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Looks nice, I think.
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/81#issuecomment-95907694.

—
Reply to this email directly or view it on GitHub https://github.com/JATOS/JATOS/issues/81#issuecomment-95908274.

Good!
Now to the tooltip. How about:

Personal Multiple Run: Creates a link to a run that can be used multiple times and uses always the same worker.
Personal Single Run: Creates a link to a run that can be used only once and uses always the same worker.
General Single Run: Creates a link to a run that can be used only once and creates a new worker with each run. Be careful: To determine whether a certain worker did a study already JATOS uses a cookie stored in the workers browser. Potentially the worker can delete this cookie and do the study several times.

A few changes:

Personal Multiple Run: Creates a link to a run that can be used multiple times and always assigns the results to the same JATOS worker.
Personal Single Run: Creates a link to a run that can be used only once and always assigns the results to the same JATOS worker.
General Single Run: Creates a link to a run that can be used only once and creates a new JATOS worker with each run. Warning: If a worker deletes their browser’s cookies, or uses a different browser or computer, JATOS will not realise that the worker already ran the study. This way workers can potentially run the same study several times.

agree? Also, because tooltips might be annoying here (the text is long), I would put a little information “i” here, so the tooltip doesnt appear when you hover on any place in the button

On 24 Apr 2015, at 14:37, Kristian Lange<EMAIL_ADDRESS>wrote:
Good!
Now to the tooltip. How about:
Personal Multiple Run: Creates a link to a run that can be used multiple times and uses always the same worker.
Personal Single Run: Creates a link to a run that can be used only once and uses always the same worker.
General Single Run: Creates a link to a run that can be used only once and creates a new worker with each run. Be careful: To determine whether a certain worker did a study already JATOS uses a cookie stored in the workers browser. Potentially the worker can delete this cookie and do the study several times.
—
Reply to this email directly or view it on GitHub https://github.com/JATOS/JATOS/issues/81#issuecomment-95919277.

Nicely written my bupo! :+1:
Mostly agreed. I have to remove the JATOS from every worker, because a JATOS worker exists already, e.g.

Personal Multiple Run: Creates a link to a run that can be used multiple times and always assigns the results to the same worker.

I see. Very well then!
Decided.

On 24 Apr 2015, at 15:31, Kristian Lange<EMAIL_ADDRESS>wrote:
Nicely written my bupo!
Mostly agreed. I have to remove the JATOS from every worker, because a JATOS worker exists already, e.g.
Personal Multiple Run: Creates a link to a run that can be used multiple times and always assigns the results to the same worker.
—
Reply to this email directly or view it on GitHub https://github.com/JATOS/JATOS/issues/81#issuecomment-95932767.

Ah wait. I don't like these little i's. I'd strongly recommend to stick with normal tooltips.

If you strongly recommend, then I accept your decision!

On 24 Apr 2015, at 15:36, Kristian Lange<EMAIL_ADDRESS>wrote:
Ah wait. I don't like these little i's. I'd strongly recommend to stick with normal tooltips.
—
Reply to this email directly or view it on GitHub https://github.com/JATOS/JATOS/issues/81#issuecomment-95934283.

I will close this, I think it's done


Fix bug 459

What kind of change does this PR introduce? (check one with "x")

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Cannot find file 'datatable.component.scss' and the AoT compilation fails.
What is the new behavior?
AoT compilation does not fail anymore
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x] No, but

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
It isn't pretty. I'm not sure why the relative path loading does not work. It might be an issue with a webpack loader or something.
I've tested before and after the change with an angular-cli app and an angular-class-starter app. Both had the same issue, and this kind of path loading fixes is.

You shouldn't have to reference the scss like that :S .... its assuming you have scss running in your stack.
I think a simple replace ( ugh ) might fix this in the build step.

Yeah, i'm not happy about it either.
I actually expected the release version to NOT have any scss dependencies, or at least have the path of the styleUrls be wrapped in a webpack require, where the url it requires matches the one that it built.
It's the reason i tried this "solution", to make the path match more with the one it registers for the scss.
I don't have the webpack-knowledge to figure it out unfortunately.

This is actually ngc not webpack...

Ah, well.. explains why nothing worked when i was fiddling with webpack.
Do you have a solution for this, or at least know where to look?

I temp fixed the issue, need to figure out better way tho.


Create zafu.txt

added the following university to the domain: zafu.txt. Official website https://https://en.zafu.edu.cn/
Computer Science program introduction: https://en.zafu.edu.cn/info/1012/1071.htm which offers undergraduate program and masters program.

@ruanyaoping First stage of verification passed, official domain is en.zafu.edu.cn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://en.zafu.edu.cn/CONTACT_US.htm

@philipto Thanks for the verification. The official domain is zafu.edu.cn actually. The en.zafu.edu.cn is just for English version. Please correct. Thanks again.


Add coverage badge

Clear and concise description of the problem
Test coverage is hard to find (you would need to check all the stages).
Suggested solution
A UI config for

a step
a regex

that generates the badge, i.e.
step: test
regex: 'code coverage\: (\d+)

Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

@qwerty287  Thanks for your comment. I am not sure, if this is a good idea. Code coverage is something very common (like the build success badge) and it might turn out tedious: You would have to

find some badge generator
generate the badge
save it in artifact storage
make sure it gets overridden on every build
...

Therefore I would suggest that some common badges should be built in


[Docs] Add markdownlint

Add popular tool markdownlint-cli which runs markdownlint via a package.json script for documentation formatting consistency and best practices.
The majority of these changes were autofixed.
More info in this related PR:

https://github.com/jsx-eslint/eslint-plugin-react/pull/3367

There's a good markdownlint VSCode extension which highlights and autofixes these issues as well: https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint
This will make it easier and safer to edit docs going forward.

hmm, it seems like the node 4 build is failing; does markdownlint-cli depend on something that uses aliases? if it's bringing in jackspeak then that'll need to be pinned.


Wired Dashboard with the Planer for automatic ADP generation. Small fixes.

This PR integrates the planner with the dashboard. Currently there is no  way to test the functionality by using BOM due a problem with the catalog. Please the planner endpoint to http://<IP_ADDRESS>:1234 if you want to test it.
@rosogon could you review this?

Looks good. Merging.


Does argcomplete work for scripts which don't directly invoke the parse?

For example - a script that instantiates a class from another file which then handles the parsing there.

Yes, that should work, as long as the argcomplete.autocomplete(parser) method is called before the parser.parse() method is called.
It helps to understand what happens when argcomplete is activated. From the docs:
Argcomplete gets completions by running your program. It intercepts the execution flow at the moment argcomplete.autocomplete() is called. After sending completions, it exits using exit_method (os._exit by default). This means if your program has any side effects that happen before argcomplete is called, those side effects will happen every time the user presses  (although anything your program prints to stdout or stderr will be suppressed). For this reason it's best to construct the argument parser and call argcomplete.autocomplete() as early as possible in your execution flow.


Check formatting using built executable instead of action

Although I want to encourage others to use cabal-gild-setup-action, in this repo I should be testing against the actual cabal-gild executable that was just built. Doing so will make it possible for me to change the output format and still have the tests pass, for example.
I expect this to fail initially because --mode check doesn't quite work on Windows. The problem is that the input file has CRLF line endings but the output file has LF line endings. I was aware of this before (see 3023fc096154885300542c86f000cec9fc12efcb) but chose to ignore it until now.

I'm not sure how to proceed here. I have several options:

When using --mode check, succeed if the input is formatted modulo line endings. This feels like the most user friendly, but also kind of weird to say "yeah it's formatted" when the output would actually change.
When on Windows, emit CRLF rather than LF line endings. This feels like doing what the platform expects, but I think canonically Cabal files should use LF line endings (although I don't think this is specified).
Add an option, like --crlf, for controlling this behavior. This feels like passing the buck, and would be annoying for most Windows users.
Change the test suite itself to force the input file to have LF line endings. I think Git is automatically converting LF to CRLF on checkout, which is the source of this problem.


section is not included when added via the insert

when I insert a content after I call the section the content is not rendered in the section above the insert:
print1: https://i.imgur.com/GQ4aIUi.png
print2: https://i.imgur.com/3aF5aYL.png

@MarksEliel what version are you using? Can you also include a minimum example highlighting the bug?

I'm having a similar problem (using version 3.3):
Layout:
<!DOCTYPE html>
<html lang="de">
<head>
</head>
<body>
    <?= $this->section('header') ?>

    <main class="content">
        <?= $this->section('content') ?>
    </main>
</body>
</html>

Template:
<?php
	$this->layout('layouts/main');
?>

<?= $this->fetch('parts/header'); ?>

parts/header.php:
<?php $this->start('header') ?>
    test
<?php $this->stop() ?>

This will not render "test" in the main layout.
@MarksEliel: My workaround for the moment is using the start()/stop() methods in the main template:
<?php
	$this->layout('layouts/main');
?>
<?php $this->start('header') ?>
    <?= $this->fetch('parts/header'); ?>
<?php $this->stop() ?>

I think this makes sense, it'd be helpful if you could provide a PR with a broken test to cover this scenario and we can go from there.


Support for modeling queues and lists

Proposal
Reported by:  @ioanngolovko
In order to support modeling collections and messaging queues a new data container should be added. The current approach only has one state with CRUD operations. Adding a dynamic list is challenging.
Idea is to add a new container: list. The syntax can look like this:

serveEventListeners

recordState

{
  "context": "...",
  "list": {
    "addLast": {
      "stateValue": "..."
    },
    "addFirst": {
      "stateValue": "..."
    }
  }

deleteState{
  "context": "...",
  "list": {
    "deleteFirst": true,
    "deleteLast": true,
    "deleteIndex": 1,
    "deleteWhere": {
      "property": "...",
      "value": "...",
}

response{
 "jsonBody": {
    "id": "{{state context=... list.last='id'}}",
    "firstName": "{{state context=... list.first='firstName'}}",
    "lastName": "{{state context=... list.[1]='lastName'}}"
  }
}

Templating will be supported for all values.
References
No response

Syntax for recordState and deleteState is as described.
For Response Templating, the syntax had to be adapted:
{
 "jsonBody": {
    "id": "{{state context=... list.last='id'}}",
    "firstName": "{{state context=... list='[0].firstName'}}",
    "lastName": "{{state context=... list='[-1].lastName'}}"
  }
}

merged


Migration fails with utf8mb4 charset

Environment:

python (3.4.2)
django (1.8.16)
mysqlclient (1.3.7)
MariaDB (10.0.30)

Steps to reproduce:

CREATE DATABASE utf8mb4_test DEFAULT CHARACTER SET utf8mb4 DEFAULT COLLATE utf8mb4_unicode_ci;
python manage.py migrate

Output:
...
Running migrations:
  Rendering model states... DONE
  Applying auditlog.0001_initial... OK
  Applying auditlog.0002_auto_support_long_primary_keys... OK
  Applying auditlog.0003_logentry_remote_addr... OK
  Applying auditlog.0004_logentry_detailed_object_repr... OK
  Applying auditlog.0005_logentry_additional_data_verbose_name... OK
  Applying auditlog.0006_object_pk_index...Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/usr/lib/python3/dist-packages/django/db/backends/mysql/base.py", line 124, in execute
    return self.cursor.execute(query, args)
  File "/usr/lib/python3/dist-packages/MySQLdb/cursors.py", line 226, in execute
    self.errorhandler(self, exc, value)
  File "/usr/lib/python3/dist-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
    raise errorvalue
  File "/usr/lib/python3/dist-packages/MySQLdb/cursors.py", line 217, in execute
    res = self._query(query)
  File "/usr/lib/python3/dist-packages/MySQLdb/cursors.py", line 378, in _query
    rowcount = self._do_query(q)
  File "/usr/lib/python3/dist-packages/MySQLdb/cursors.py", line 341, in _do_query
    db.query(q)
  File "/usr/lib/python3/dist-packages/MySQLdb/connections.py", line 280, in query
    _mysql.connection.query(self, query)
_mysql_exceptions.OperationalError: (1071, 'Specified key was too long; max key length is 767 bytes')

The error is caused by the length (255) of the object_pk field. The InnoDB storage engine has a maximum index length of 767 bytes.

Given the maximum length of 767 bytes this error makes sense. However, it somewhat surprises me that even with utf8mb4 a VARCHAR can still be 255 characters but an index fails on this.
From the top of my head I can think of two solutions:

Optionally lower the length of the object_pk field
Optionally disable the index of the object_pk field

At the moment I think I like the first one a bit more because it does not result in very poor performance. Also, since primary keys are indexed we can assume that a primary key from a database using utf8mb4 is not longer than the mentioned 191 characters. (The issue may still be that the logs are stored in a separate database with another character set...)
This at least is an interesting problem, given the issues with other utf8 character sets in MySQL/MariaDB I think that the mb4 variant is/will become quite popular so this has to be addressed somehow.


Fix 311 databricks shim for AnsiCastOpSuite failures

fixes https://github.com/NVIDIA/spark-rapids/issues/3488
This fixes the databricks 3.1.1 build.  The only tests I saw there were unit tests which we don't run on databricks so I'm running the integration tests now.
Signed-off-by: Thomas Graves<EMAIL_ADDRESS>

build

@andygrove are there any integration tests that test this?

kicked branch on databricks jenkins build

@andygrove are there any integration tests that test this?

No, at least not with enough coverage. I've just filed https://github.com/NVIDIA/spark-rapids/issues/3492 to add this.


Package.loadSettings is deprecated.

Store package settings files in the settings/ directory instead of scoped-properties/
Package.loadSettings (/Applications/Atom.app/Contents/Resources/app/src/package.js:550:9)
<unknown> (/Applications/Atom.app/Contents/Resources/app/src/package.js:172:43)

I actually just fixed this! We're waiting on @freebroccolo to publish to apm.

Awesome! Thank you!!


Migrate Source Missing 'Clean Up' logic provided by Source Orbit

https://github.com/IBM/vscode-ibmi-projectexplorer/assets/59372176/d9ee81a2-2a09-4402-bb5d-31920a573460

@worksofliam added this code viahttps://github.com/IBM/vscode-ibmi-projectexplorer/pull/359

Researh say that
```bash
# In a VS Code extension written in TypeScript, the `exports` field in the `package.json` file sets the main entry point for the extension. It specifies the main JavaScript file that will be loaded when the extension is activated.

but I don't see where that was ever set


Comma handling error

Currently it is possible for the generator to output a comma at the end of a sentence, for example:
And good intentions and pull himself that several times without the door, holding himself to suffer grete grete she knew you needn't worry about things on those on the room,.

Fixed in ca905c8c930fa83fbe71acd934cba0b38d8e8ee8


Typos in Vehicle.cs

Reporting two small typos in v3 Vehicle.cs class. For IsTrain property, the vehicle type is compared to the wrong enum.
public bool IsTrain => Type == VehicleType.Bycicle;
And also the correct spelling is "Bicycle"

If you hover over the code of the line in question ... you can copy a link[like this].(https://github.com/crosire/scripthookvdotnet/blob/5200a3ae5b2f6dcaaafc4a2e7a518f8edc7f9fcf/source/scripting_v3/GTA/Entities/Vehicles/Vehicle.cs#L242)
Makes it super easy to reference exactly which part you refer too ;)


In-memory engine: fix problems of sub range scheduling load task of the whole range

What is changed and how it works?

Issue Number: Ref #16141

What's Changed:
fix problems of sub range scheduling load task of the whole range

This PR fixes a race of sub range scheluding load task of whole range. Say we are to load k1-k10 and k1-k5, and k5-k10 are ranges of two separete regions.
Now, the first one who calls prepare_for_apply will schedule the load of k1-k10 which can cause loss of data:

We can see k1 has not been written in rocksdb before acquiring snapshot and will not be written or cached in the in-memory engine. So it will be lost.
To fix it:
We should split the range of k1-k10 into k1-k5 and k5-k10 and only schedule k5-k10 in apply thread 2.
When k1-k5 calls prepare_for_apply again, it schedules the remaining k1-k5. Furthermore, k1-k5 may be splitted before next prepare_for_apply, and each child region is responsible for it's own range similarlly.
Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[ ] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

None

/merge

Is there any similar issue when region merge?

Is there any similar issue when region merge?

The range should be evicted when we detect a merge.


[ButtonBase] Unfocus does not clear ripple

keyboard tab between ButtonBase component does not clear the focus ripple. I can confirm that revert the code on this commit does not have this issue (in ButtonBase.js). https://github.com/mui-org/material-ui/commit/5f30983bfa16195237fde55a78d5e43b151a29fa
cc @michaldudak can you help take a look?

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Expected Behavior 🤔
it should clear the ripple element

Steps to Reproduce 🕹

Steps:

open https://next.material-ui.com/components/buttons/#main-content
tab through the docs

Context 🔦

Your Environment 🌎

`npx @mui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Yes, I've noticed that and I'm already working on a fix.

I think I've talked repeatedly about not doing the abstraction. The ButtonBase is integral to the codebase and shouldn't be jeopardized by the unstyled effort. The unstyled effort can be a separate experiment that doesn't need to affect the core product.

The ButtonBase is integral to the codebase and shouldn't be jeopardized by the unstyled effort

@eps1lon If you could expand on the why, I think that it would be great.
I was under the assumption that the value of using unstyled in the material design components is so that we can surface issues, like this one.

@eps1lon If you could expand on the why, I think that it would be great.

Why do I need to explain that a fundamental component should not be affected by experiments? Like what would you expect to hear?

I think I've talked repeatedly about not doing the abstraction.

You mean not to implement Button with useButton? If so, I suppose I may have missed that. In the useButton PR, both @mnajdova and @oliviertassinari suggested using the new hook in the ButtonBase and I haven't seen any objections from your side.
As for the issue itself, I already pinpointed it and I'm adding few tests to ButtonBase to help to avoid such problems in the future.

I remember we talked about this that if the unstyled abstraction does not introduce breaking change to the core, we will do it in the core.

As discussed today in the planning, we will restore the original implementation and create a separate private package with Material components (no matter if they have breaking changes or not) built using @mui/core.


chore: Add stories for assign permissions shortcut

What this PR does / why we need it:
This PR adds stories for ACL shortcut to assign permissions
Which issue(s) this PR fixes
7513
Verification steps
You can find the stories under

Kafka/ManageKafkaPermissions/components/ProduceTopicShortcut
Kafka/ManageKafkaPermissions/components/ConsumeTopicShortcut
Kafka/ManageKafkaPermissions/components/ManageAccessShortcut
Kafka/ManageKafkaPermissions/components/MultipleShortcutsView
Kafka/ManageKafkaPermissions/components/AssignPermissionsManual
Kafka/ManageKafkaPermissions/components/KafkaInstanceManualPermissions

Could you update this with the latest from main?

:tada: This PR is included in version 1.39.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Memcached persistent connections, SASL authentication, and custom options

Proposed additions to cache configuration file config/cache.php.
This PR makes the following extra configuration items are available for use with a memcached store:

persistent_id - [Memcached::__construct] (http://php.net/manual/en/memcached.construct.php)
explains how this is used
sasl - used by Memcached::setSaslAuthData
options - see Memcached::setOptions

These may be used in a store config like so:
'stores' => [
    'memcachedstorefoo' => [
        'driver'  => 'memcached',
        'persistent_id' => 'laravel',
        'sasl'       => [
            env('MEMCACHIER_USERNAME'),
            env('MEMCACHIER_PASSWORD')
        ],
        'options'    => [
            'OPT_NO_BLOCK'         => true,
            'OPT_AUTO_EJECT_HOSTS' => true,
            'OPT_CONNECT_TIMEOUT'  => 2000,
            'OPT_POLL_TIMEOUT'     => 2000,
            'OPT_RETRY_TIMEOUT'    => 2,
        ],
        'servers' => [
            [
                'host' => '<IP_ADDRESS>', 'port' => 11211, 'weight' => 100
            ],
        ],
    ],
],

When defining options you should set the config key to the Memcached constant name as a string.
This avoids any issues with local environments missing ext-memcached and throwing a warning about
undefined constants. The config keys are automatically resolved into Memcached constants by the
MemcachedPlus\MemcachedConnector which throws a RuntimeException if the constant is invalid.

The tests are going to need some tweaking. I can take a look but I'm not so familiar with this.

Closing until tests are updated.

Submitted new PR #13359 with tests


fixed detached sign/verify

https://github.com/sodium-friends/sodium-javascript/blob/07e1bc4ed671d0ff8a46766c0204b6e15d99a386/index.js#L1689 expects the arguments of crypto_sign_open to be in a different order than they are

detached sign/verify weren't working properly. made changes following https://github.com/dchest/tweetnacl-js/blob/master/nacl-fast.js

Cherry picked the first commit and fixed the other issue. Thanks a bunch!!

0.5.1

👍


Version 15

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

test

ok

ok

ok

test

merge somethin

dtyuikjythgrfedwsegthyjukilkjhgfdgi786u7y5tredfghj


about data.py

Thanks for your great job!  I have some doubt about the data sampling within a class_change_interval. Why not remove the picked selected_classes*(self.num_samples_per_support_class+self.num_samples_per_target_class) after one iteration of support set and target set generation, in order to avoid the duplicate samples among different support sets within a class_change_interval?

Hi @liujianzhao6328057 can you please be more specific? Please report the name of the file and the lines you are referring to.


Time Pruner should support queries where we're operating on the time column itself

Today, we only apply time pruning when the left hand side of an operand is strictly the time colum, https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/TimeSegmentPruner.java#L370-L373
But we should still be able to apply time pruning when an operand is applied to the time column. The main case we've seen is folks will run a query with where date_trunc('day', <ts_column>) < <static_time>. This causes the time pruner to not be used.
The most naive way here would be to rebuild the interval tree in the broker with the min/max time columns for each segment also truncated. Though this would be problematic for tables with tens of thousands of segments.
I'm opening this as an issue for now to brainstorm if there's a universal solution or if there's easy operands that can be supported.

We do have TimePredicateFilterOptimizer introduced in #6957. We should be able to enhance that to also support DATE_TRUNC

great link, ty jackie. I won't have time to work on this immediately (our user also just modified their query instead), but I'll try to come back to it in free time

@jadami10
Mind if I take a stab at this?

absolutely! feel free to tag me in to review


Esign crashes

Describe the issue
ESign crashes upon launching the most recent build of LiveContainer, it’s not too big of a deal but it is still noteworthy. There’s no errors, just crashes and goes back to LiveContainer.
Instructions to reproduce
Download any esign ipa file, no logs, or just regular esign. Install it using LiveContainer and launch it.
What version of LiveContainer are you using?
Recent build from actions tab
Other
No response

Well, I managed to make ESign run in LiveContainer by directly modifying its binary. If you wish I can send you the modified ESign. Not sure whether the modification will cause any problem since signing seems to be working correctly.

That’s good to hear, where can you send the modified esign to me?

@ThePizzaMan865 here
https://github.com/khanhduytran0/LiveContainer/issues/146#issuecomment-2559639723


Refactor shortcodes.php

This file is getting pretty large and should be refactored to be more object oriented.
This might be something that Nagarjuna can do. @rraub What do you think?

pushed changes to branch shortcode-refactor

Looks good to me. I might suggest having one file to be the entry point for all the shortcodes and it would just include all the shortcode definition files rather than maintaining a list of the shortcode files in functions.php.

Yeah, I like that idea as well, kind of like how we have our Scss code.

Closed in https://github.com/gios-asu/ASU-Web-Standards-Wordpress-Theme/pull/118


allow-nulls and nullable objects

Hi,
This change makes a few small tweaks to get nullable object arguments generally working, in pursuit of engaging with the wlr_data_control_unstable_v1 protocol.

the latter protocol uses an allow-null attribute as its nullability flag - the Xml reader has been extended to match this as well as the original nullable
a new WlClientObject.GetNullableObject helper has been added, which does the same as GetObject, except it also checks for an incoming null pointer, and returns T?
convertObject has been updated to prefer GetNullableObject when the method arg is marked as nullable

These all add up to a working prototype for my purposes. I notice the test suite isn't in a working state currently and so have opportunistically avoided adding any tests. If this is a blocker to getting these changes merged, I'd be very happy to revisit (and maybe existing broken tests can be fixed up)
Thanks a lot for this very helpful library - even though it's not complete I've found it very useful.

Thanks for the contribution!


Example Site

Hello,
First, thank you very much for the great dark-theme-editor hugo theme. it's awesome!
Second, would you kindly provide the sources for your own website that's located at https://jingwangtw.github.io/dark-theme-editor/?
It will be much easier for us to build our own if we have yours as an example.
I'm already using another template for my blog, named hugo-coder, but then, I'd like to use dark-theme-editor for more technical stuff.
Thanks a lot and best regards!
Happy new lunar new year!

Hi Rossano,
Thank you for your interest in this theme. It's so great to hear this during the Lunar New Year holiday. I was flattered.
The source code for the example site is published in the same repository, but in another branch, example-site. You should be able to find all the required files there.
I can’t wait to see your blog using this theme. Also, I'd be happy to hear any suggestions or comments from users after applying the template.
Thank you.

@JingWangTW I'll have a look as soon as I can into this my friend.
About the New Year Holiday, I'm living in Vietnam since 2016 so, I'm also enjoying these days, hehehehe.
And then, it's me who should say Thank you. Many thanks for sharing this template with the community!
Be seeing ya.


Doesn't push my links on Twitter

Hi ArthurHoaro,
do you know how to debug because I follow your install documentation, fill right the form and nothing is push to my twitter account. I try to regenerate tokens, nothing.
My php version 5.6 , curl present and my shaarli version is 0.8.
Thank !

Sorry, it was my theme who hide the twitter checkbox. Maybe you could update your readme to explain the need to check the twitter checkbox before sending a new link to your shaarli.
Thank !

Hi!
Yes I can, however your theme is supposed to contain plugin hooks. Which one are you using?

http://f.0x2501.org/s/
I use a crappy homemade theme who need some css fixes.


Fix mixed content warnings on SE.Precompilation

If someone could make the internal image uploader give HTTPS URLs to copy + paste, that would be lovely :lock:

Fixing, sec.


Get HTTP 400 resposne when attemp to create a new tag

I get http 400 response code when creating a new tag on RackHD.  I used the following command
curl -H "Content-Type: application/json" -X POST -d '{ "name": "newtag_JYNrtABT_ccdsffa_ccds", "rules": [ { "equals": "my server", "path": "dmi.System Information.Product Name" }]}' http://{IP}:8080/api/1.1/tags
And it get 400 http response. Error message is
 {"message":"required option nodeId for task Task.Catalog.GenerateTag in graph Graph.GenerateTags"}

I also reproduced this issue in my system, add @zyoung51 for awareness.

Known issue being tracked in : https://www.pivotaltracker.com/projects/1492890/stories/117246337

FYI @uppalk1

Created PR https://github.com/RackHD/on-http/pull/224

Code merged: https://github.com/RackHD/on-http/commit/23cf90b44ff3cda765334517e35dbe811a361f49
if you set the pull request message to read:
resolves RackHD/RackHD#169
then when this is merged, it will close the github bug

Closing bug


EOS-15800 Management: support graceful shutdown of a node

Goal of this task is to implement functionality using which
we can shutdown hare/motr services on local node.
Solution:
Create a new module utility so that shutdown code need not be
replicated.
Added code in hare-node to make it shut local node services
Testing:
Tried running hctl node shutdown and it does shutdown
services.

@mssawant  - certain things are not working. I am getting flake 8 and mypy errors. I am commenting what errors I am seeing.

@gshipra try these fixes,
diff --git a/Makefile b/Makefile
index 40b363a..d597e9e 100644
--- a/Makefile
+++ b/Makefile
@@ -458,7 +458,7 @@ uninstall:
 # Linters --------------------------------------------- {{{1
 #

-PYTHON_SCRIPTS := utils/hare-shutdown utils/hare-status utils/gen-uuid
+PYTHON_SCRIPTS := utils/hare-shutdown utils/hare-status utils/gen-uuid utils/hare-node utils/utilitity.py

 .PHONY: check
 check: check-cfgen check-hax flake8 mypy
@@ -485,7 +485,7 @@ override MYPY_OPTS := --config-file hax/mypy.ini $(MYPY_OPTS)
 mypy: $(PYTHON_SCRIPTS)
        @$(call _info,Checking files with mypy)
        @$(PY_VENV); \
-         set -eu -o pipefail; for f in $^; do MYPYPATH=stubs:hax mypy $(MYPY_OPTS) $$f; done
+         set -eu -o pipefail; for f in $^; do MYPYPATH=stubs:hax:utils mypy $(MYPY_OPTS) $$f; done

 # Tests ----------------------------------------------- {{{1
 #

mypy error is fixed and hare-node and utility is building now, fix the build errors reported after applying the above patch.

@knekrasov - Requesting review.

Please try to resolve as many codacy errors as possible.

done.

@mssawant @knekrasov - please re-review the code.

Output with the latest patch :
[root@ssc-vm-2090 hare]# hctl shutdown
Stopping m0d@0x7200000000000001:0xc (ios) at ssc-vm-2089.colo.seagate.com...
Stopping m0d@0x7200000000000001:0x30 (ios) at ssc-vm-2090.colo.seagate.com...
Stopping m0d@0x7200000000000001:0x54 (ios) at ssc-vm-2091.colo.seagate.com...
Stopped m0d@0x7200000000000001:0x30 (ios) at ssc-vm-2090.colo.seagate.com
Stopped m0d@0x7200000000000001:0xc (ios) at ssc-vm-2089.colo.seagate.com
Stopped m0d@0x7200000000000001:0x54 (ios) at ssc-vm-2091.colo.seagate.com
Stopping m0d@0x7200000000000001:0x9 (confd) at ssc-vm-2089.colo.seagate.com...
Stopping m0d@0x7200000000000001:0x2d (confd) at ssc-vm-2090.colo.seagate.com...
Stopping m0d@0x7200000000000001:0x51 (confd) at ssc-vm-2091.colo.seagate.com...
Stopped m0d@0x7200000000000001:0x2d (confd) at ssc-vm-2090.colo.seagate.com
Stopped m0d@0x7200000000000001:0x51 (confd) at ssc-vm-2091.colo.seagate.com
Stopped m0d@0x7200000000000001:0x9 (confd) at ssc-vm-2089.colo.seagate.com
Stopping hare-hax at ssc-vm-2089.colo.seagate.com...
Stopping hare-hax at ssc-vm-2090.colo.seagate.com...
Stopping hare-hax at ssc-vm-2091.colo.seagate.com...
Stopped hare-hax at ssc-vm-2090.colo.seagate.com
Stopped hare-hax at ssc-vm-2089.colo.seagate.com
Stopped hare-hax at ssc-vm-2091.colo.seagate.com
Stopping hare-consul-agent at ssc-vm-2089.colo.seagate.com...
Stopping hare-consul-agent at ssc-vm-2090.colo.seagate.com...
Stopping hare-consul-agent at ssc-vm-2091.colo.seagate.com...
Stopped hare-consul-agent at ssc-vm-2089.colo.seagate.com
Stopped hare-consul-agent at ssc-vm-2090.colo.seagate.com
Stopped hare-consul-agent at ssc-vm-2091.colo.seagate.com
Shutting down RC Leader at ssc-vm-2089.colo.seagate.com...
OK
[root@ssc-vm-2090 ~]# hctl start
2021-02-09 17:05:19: Starting Consul server on this node............. OK
2021-02-09 17:05:30: Importing configuration into the KV store... OK
2021-02-09 17:05:31: Starting Consul on other nodes.... OK
2021-02-09 17:05:32: Updating Consul configuraton from the KV store... OK
2021-02-09 17:05:34: Waiting for the RC Leader to get elected... OK
2021-02-09 17:05:34: Starting Motr (phase1, m0d)... OK
2021-02-09 17:05:39: Starting Motr (phase2, m0d)... OK
2021-02-09 17:05:43: Checking health of services...
Stopped m0d@0x7200000000000001:0x30 (ios) at ssc-vm-2090.colo.seagate.com
Stopping m0d@0x7200000000000001:0x2d (confd) at ssc-vm-2090.colo.seagate.com...
Stopped m0d@0x7200000000000001:0x2d (confd) at ssc-vm-2090.colo.seagate.com
Stopping hare-hax at ssc-vm-2090.colo.seagate.com...
Stopped hare-hax at ssc-vm-2090.colo.seagate.com
Stopping hare-consul-agent at ssc-vm-2090.colo.seagate.com...


Fabric crashlytics symbolication set up

@berkus I followed the instructions to upload symbols in fabric/firebase manuals.
crashlyticsUploadSymbols depends on crashlyticsGenerateSymbols task which fails because we are expected to set androidNdkLibsOut and androidNdkOut parameter if the symbols are not in the default folder "/obj" in module path. (And it's not).
I checked build folder and located a lib folder with twilio native library, but no obj, even if our dependency is "com.twilio:chat-android-with-symbols".
build/intermediates/transforms/mergeJniLibs/prod/release/0/lib
Where is it supposed to be generated and is there anything I missing here?
Originally posted by @sfseyhan in https://github.com/twilio/twilio-chat-demo-android/issues/56#issuecomment-577201842

@sfseyhan

Please post your crashlytics.log here
In demo app we have the simulate crash menu (see screenshot) After you setup your fabricApiKey in the demoapp - these simulated crashes should come into your crashlytics account. Please check that it works for you.

Here is crashlytics.log. There were apiKey and apiSecret in the logs so I removed those lines.
2020-02-03 13:36:00.155 [DEBUG] (Execution worker for ':' Thread 2) com.crashlytics  - Invoked Crashlytics Developer Tools with arguments:
-androidOutputManifestDirectories property(interface org.gradle.api.file.Directory, fixed(class org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedDirectory, /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devStage))
-injectableManifest true
-androidBaseManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/AndroidManifest.xml
-buildEvent true
-androidManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devStage/AndroidManifest.xml
-generateResourceFile true
-tool io.fabric.tools.gradle
-version 1.26.1
-properties /Users/furkan.seyhan/StudioProjects/scoober-android/app/fabric.properties
-buildId 3161798a-e397-4859-9fab-5176941ed88d
-targetResValueDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/fabric/res/dev/stage
-projectPath /Users/furkan.seyhan/StudioProjects/scoober-android/app
-androidRes /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/res
-androidAssets /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devStage/out
-googleServicesResDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/res/google-services/dev/stage
2020-02-03 13:36:00.163 [DEBUG] (Execution worker for ':' Thread 2) com.crashlytics  - Generating crashlytics resources
2020-02-03 13:36:00.163 [DEBUG] (Execution worker for ':' Thread 2) com.crashlytics  - Generating build info into assets folder: /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devStage/out
2020-02-03 13:36:00.163 [DEBUG] (Execution worker for ':' Thread 2) com.crashlytics  - Updating build properties at: /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devStage/out/crashlytics-build.properties
2020-02-03 13:36:00.164 [DEBUG] (Execution worker for ':' Thread 2) com.crashlytics  - Set build id to 3161798a-e397-4859-9fab-5176941ed88d
2020-02-03 13:36:00.165 [DEBUG] (Build Event Notification) com.crashlytics  - Build Event: com.takeaway.driver ID:3161798a-e397-4859-9fab-5176941ed88d Tool:io.fabric.tools.gradle 1.26.1 Base Package Name:com.takeaway.driver Twitter Client Application Id:null API Secret Null? false Extra Details:[null]
2020-02-03 13:36:00.170 [DEBUG] (Build Event Notification) com.crashlytics  - REQUEST: https://api.crashlytics.com/spi/v1/platforms/android/apps/com.takeaway.driver/built
2020-02-03 13:36:00.992 [DEBUG] (Build Event Notification) com.crashlytics  - POST response: [reqId=381655651fb87a8c37c8f919b9b777e4] 200
2020-02-03 13:38:21.867 [DEBUG] (Execution worker for ':') com.crashlytics  - Invoked Crashlytics Developer Tools with arguments:
-generateCSyms true
-androidOutputManifestDirectories property(interface org.gradle.api.file.Directory, fixed(class org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedDirectory, /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devStage))
-enableNDK true
-cSymArchive /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms_archive
-androidManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devStage/AndroidManifest.xml
-androidRes /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/res
-androidBaseManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/AndroidManifest.xml
-properties /Users/furkan.seyhan/StudioProjects/scoober-android/app/fabric.properties
-cSymGen /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/fabric/dev/stage/csyms
-cSymCache /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms
-buildId 3161798a-e397-4859-9fab-5176941ed88d
-androidNdkLibsOut /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/stripped_native_libs/devStage/out/lib
-googleServicesResDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/res/google-services/dev/stage
-targetResValueDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/fabric/res/dev/stage
-androidAssets /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devStage/out
-projectPath /Users/furkan.seyhan/StudioProjects/scoober-android/app
-androidNdkOut /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_native_libs/devStage/out/lib
2020-02-03 13:38:21.897 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics generating cSYM files from object files in /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_native_libs/devStage/out/lib:
2020-02-03 13:38:21.897 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /armeabi-v7a/libgmm-jni.so
2020-02-03 13:38:21.942 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:38:21.943 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /armeabi-v7a/libgmm-jni.so, skipping.
2020-02-03 13:38:21.943 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /armeabi-v7a/libcrashlytics.so
2020-02-03 13:38:21.952 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:38:21.953 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /armeabi-v7a/libcrashlytics.so, skipping.
2020-02-03 13:38:21.953 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /armeabi-v7a/libtwilio-rtd-native.so
2020-02-03 13:38:22.907 [DEBUG] (Execution worker for ':') com.crashlytics  - Using DWARF data for cSYM generation.
2020-02-03 13:39:00.833 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /armeabi-v7a/libconstant.so
2020-02-03 13:39:00.836 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:00.836 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /armeabi-v7a/libconstant.so, skipping.
2020-02-03 13:39:00.836 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /x86/libgmm-jni.so
2020-02-03 13:39:00.850 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:00.850 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /x86/libgmm-jni.so, skipping.
2020-02-03 13:39:00.850 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /x86/libcrashlytics.so
2020-02-03 13:39:00.853 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:00.853 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /x86/libcrashlytics.so, skipping.
2020-02-03 13:39:00.853 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /x86/libtwilio-rtd-native.so
2020-02-03 13:39:01.524 [DEBUG] (Execution worker for ':') com.crashlytics  - Using DWARF data for cSYM generation.
2020-02-03 13:39:18.615 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /x86/libconstant.so
2020-02-03 13:39:18.617 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:18.617 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /x86/libconstant.so, skipping.
2020-02-03 13:39:18.617 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /arm64-v8a/libgmm-jni.so
2020-02-03 13:39:18.629 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:18.629 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /arm64-v8a/libgmm-jni.so, skipping.
2020-02-03 13:39:18.629 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /arm64-v8a/libcrashlytics.so
2020-02-03 13:39:18.634 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:18.634 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /arm64-v8a/libcrashlytics.so, skipping.
2020-02-03 13:39:18.634 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /arm64-v8a/libtwilio-rtd-native.so
2020-02-03 13:39:19.550 [DEBUG] (Execution worker for ':') com.crashlytics  - Using DWARF data for cSYM generation.
2020-02-03 13:39:49.100 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /arm64-v8a/libconstant.so
2020-02-03 13:39:49.102 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:49.103 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /arm64-v8a/libconstant.so, skipping.
2020-02-03 13:39:49.103 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /armeabi/libcrashlytics.so
2020-02-03 13:39:49.105 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:49.105 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /armeabi/libcrashlytics.so, skipping.
2020-02-03 13:39:49.105 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /x86_64/libgmm-jni.so
2020-02-03 13:39:49.117 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:49.118 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /x86_64/libgmm-jni.so, skipping.
2020-02-03 13:39:49.118 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /x86_64/libcrashlytics.so
2020-02-03 13:39:49.120 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:39:49.120 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /x86_64/libcrashlytics.so, skipping.
2020-02-03 13:39:49.120 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /x86_64/libtwilio-rtd-native.so
2020-02-03 13:39:49.815 [DEBUG] (Execution worker for ':') com.crashlytics  - Using DWARF data for cSYM generation.
2020-02-03 13:40:05.830 [DEBUG] (Execution worker for ':') com.crashlytics  - Generating cSYM for /x86_64/libconstant.so
2020-02-03 13:40:05.844 [DEBUG] (Execution worker for ':') com.crashlytics  - Using ELF data for cSYM generation.
2020-02-03 13:40:05.845 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics found no symbols for /x86_64/libconstant.so, skipping.
2020-02-03 13:40:06.143 [DEBUG] (Daemon worker Thread 3) com.crashlytics  - Invoked Crashlytics Developer Tools with arguments:
-androidOutputManifestDirectories property(interface org.gradle.api.file.Directory, fixed(class org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedDirectory, /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devStage))
-enableNDK true
-cSymArchive /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms_archive
-androidManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devStage/AndroidManifest.xml
-androidRes /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/res
-androidBaseManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/AndroidManifest.xml
-properties /Users/furkan.seyhan/StudioProjects/scoober-android/app/fabric.properties
-cSymGen /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/fabric/dev/stage/csyms
-cSymCache /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms
-buildId 3161798a-e397-4859-9fab-5176941ed88d
-androidNdkLibsOut /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/stripped_native_libs/devStage/out/lib
-googleServicesResDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/res/google-services/dev/stage
-targetResValueDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/fabric/res/dev/stage
-androidAssets /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devStage/out
-projectPath /Users/furkan.seyhan/StudioProjects/scoober-android/app
-cacheCSyms true
-androidNdkOut /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_native_libs/devStage/out/lib
2020-02-03 13:40:06.153 [DEBUG] (Daemon worker Thread 3) com.crashlytics  - Crashlytics caching 4 code mapping files for upload.
2020-02-03 13:40:11.632 [DEBUG] (Execution worker for ':') com.crashlytics  - Invoked Crashlytics Developer Tools with arguments:
-androidOutputManifestDirectories property(interface org.gradle.api.file.Directory, fixed(class org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedDirectory, /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devStage))
-enableNDK true
-cSymArchive /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms_archive
-androidManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devStage/AndroidManifest.xml
-androidRes /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/res
-androidBaseManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/AndroidManifest.xml
-properties /Users/furkan.seyhan/StudioProjects/scoober-android/app/fabric.properties
-uploadCSyms true
-cSymGen /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/fabric/dev/stage/csyms
-cSymCache /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms
-buildId 3161798a-e397-4859-9fab-5176941ed88d
-androidNdkLibsOut /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/stripped_native_libs/devStage/out/lib
-googleServicesResDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/res/google-services/dev/stage
-targetResValueDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/fabric/res/dev/stage
-androidAssets /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devStage/out
-projectPath /Users/furkan.seyhan/StudioProjects/scoober-android/app
-androidNdkOut /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_native_libs/devStage/out/lib
2020-02-03 13:40:11.637 [DEBUG] (Execution worker for ':') com.crashlytics  - Crashlytics attempting to upload cSYM files.
2020-02-03 13:40:11.646 [DEBUG] (Execution worker for ':') com.crashlytics  - POST file: /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms/twilio-rtd-native-aarch64-34b2632e155ceb15e2941c9f3cb7ec997a91028c.cSYM.gz to URL: https://cm.crashlytics.com/api/v3/platforms/android/code_mappings
2020-02-03 13:40:22.278 [DEBUG] (Execution worker for ':') com.crashlytics  - POST response: [reqId=5199e0b7d27c468257ce3e584fabef0a7830dfebbd9e4c97] 202
2020-02-03 13:40:22.280 [DEBUG] (Execution worker for ':') com.crashlytics  - POST file: /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms/twilio-rtd-native-x86_64-81297bebb8cef627e1ece0d9ed01f82facd7961e.cSYM.gz to URL: https://cm.crashlytics.com/api/v3/platforms/android/code_mappings
2020-02-03 13:40:24.463 [DEBUG] (Execution worker for ':') com.crashlytics  - POST response: [reqId=4bb79e56bddd5b489a82fef110723a1dbd2739e8c5ceae17] 202
2020-02-03 13:40:24.465 [DEBUG] (Execution worker for ':') com.crashlytics  - POST file: /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms/twilio-rtd-native-x86-41c7bed8431c9ca6aa4b19dd1d8376aa63a9cac7.cSYM.gz to URL: https://cm.crashlytics.com/api/v3/platforms/android/code_mappings
2020-02-03 13:40:26.608 [DEBUG] (Execution worker for ':') com.crashlytics  - POST response: [reqId=a11b8509ef124932c8d3e0380da3b8caf5014a660aca1c9e] 202
2020-02-03 13:40:26.609 [DEBUG] (Execution worker for ':') com.crashlytics  - POST file: /Users/furkan.seyhan/Library/Caches/com.crashlytics/com.crashlytics.tools/app-4c2d6cda3ee098399ffbdba3a7e1dba683a6545b/dev/stage/csyms/twilio-rtd-native-armv7-b50d54f583f4ba234b62585b1e93b91151a1c4fb.cSYM.gz to URL: https://cm.crashlytics.com/api/v3/platforms/android/code_mappings
2020-02-03 13:40:28.757 [DEBUG] (Execution worker for ':') com.crashlytics  - POST response: [reqId=09bd78a7f9097e17d17ae368b454c061edb32bdbb259e296] 202
2020-02-03 13:40:28.758 [DEBUG] (Execution worker for ':') com.crashlytics  - cSYM file(s) uploaded.
2020-02-03 13:40:32.635 [DEBUG] (Daemon worker Thread 3) com.crashlytics  - Invoked Crashlytics Developer Tools with arguments:
-androidOutputManifestDirectories property(interface org.gradle.api.file.Directory, fixed(class org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedDirectory, /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devDebug))
-injectableManifest true
-androidBaseManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/AndroidManifest.xml
-buildEvent true
-androidManifest /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_manifests/devDebug/AndroidManifest.xml
-generateResourceFile true
-tool io.fabric.tools.gradle
-version 1.26.1
-properties /Users/furkan.seyhan/StudioProjects/scoober-android/app/fabric.properties
-buildId 508f28ac-e36a-4028-ab54-42d38bb9272a
-targetResValueDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/fabric/res/dev/debug
-projectPath /Users/furkan.seyhan/StudioProjects/scoober-android/app
-androidRes /Users/furkan.seyhan/StudioProjects/scoober-android/app/src/main/res
-androidAssets /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devDebug/out
-googleServicesResDir /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/generated/res/google-services/dev/debug
2020-02-03 13:40:32.643 [DEBUG] (Daemon worker Thread 3) com.crashlytics  - Generating crashlytics resources
2020-02-03 13:40:32.643 [DEBUG] (Daemon worker Thread 3) com.crashlytics  - Generating build info into assets folder: /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devDebug/out
2020-02-03 13:40:32.643 [DEBUG] (Daemon worker Thread 3) com.crashlytics  - Updating build properties at: /Users/furkan.seyhan/StudioProjects/scoober-android/app/build/intermediates/merged_assets/devDebug/out/crashlytics-build.properties
2020-02-03 13:40:32.644 [DEBUG] (Daemon worker Thread 3) com.crashlytics  - Set build id to 508f28ac-e36a-4028-ab54-42d38bb9272a
2020-02-03 13:40:32.645 [DEBUG] (Build Event Notification) com.crashlytics  - Build Event: com.takeaway.driver ID:508f28ac-e36a-4028-ab54-42d38bb9272a  Tool:io.fabric.tools.gradle 1.26.1 Base Package Name:com.takeaway.driver Twitter Client Application Id:null API Secret Null? false Extra Details:[null]
2020-02-03 13:40:32.649 [DEBUG] (Build Event Notification) com.crashlytics  - REQUEST: https://api.crashlytics.com/spi/v1/platforms/android/apps/com.takeaway.driver/built
2020-02-03 13:40:33.341 [DEBUG] (Build Event Notification) com.crashlytics  - POST response: [reqId=54e444b08caf88f79358d39bef9c3e54] 200

When I tried simulate crash, I got symbolicated crashes in crashlytics.
Crashed: Thread #1
SIGTRAP 0x00000075a95eabb0
libtwilio-rtd-native.so
ChatClient.cpp - Line 472
Java_com_twilio_chat_ChatClient_simulateCrash + 472
libtwilio-rtd-native.so
ChatClient.cpp - Line 466
Java_com_twilio_chat_ChatClient_simulateCrash + 466
libart.so
(Missing)
...
But the real crashes we get are still not symbolicated.
Crashed: Thread #1
SIGSEGV 0x0000000000000000
libtwilio-rtd-native.so
(Missing)
....

Apparently native libraries are compressed with app bundles. It's suggested to add the following line in gradle.properties > https://stackoverflow.com/a/56586785/5309676.
android.bundle.enableUncompressedNativeLibs=false
I will post after our next release if this worked.

@sfseyhan did that work for you?


[QUESTION] Image support

I've read some issues about image support being added, but also not there anymore?
I've added show_image = "Rune[i]"  to my config but it doesn't seem to do anything. Is opening it in external programs the only way right now or is there another?

The show_image keybinding no longer exists in the recent versions. Currently, Discordo opens the attachments of the selected message in the default application when the messages_text.open keybinding is pressed (default: Rune[o]).

alright, thanks for clarification :D, wonderful project, thanks for all the work


[BUG]Action parameters may be broken

Describe the bug
The charm does not have good parameters for its actions. When trying to execute an action, there is an error in validation because the parameter have underscores in their names (e.g. relation_id) and that throws an error.
To Reproduce
Steps to reproduce the behavior:
1- Execute any action with a parameter that contains an underscore. E.g. juju run tls-certificates-operator/0 get-outstanding-certificate-requests relation_id=0
Expected behavior
The action should execute without any errors.
Screenshots

Environment

tls-certificates-interface library version 2.12
Juju version: 3.1.5-genericlinux-amd64
Cloud Environment: Microk8s cloud
Kubernetes version 1.28

Hi @gtrkiller
I am working on the fix right now.
This is the PR to fix it.
Until then a workaround is to use a parameter.yaml file and pass it to the action with --params parameters.yaml


union / intersection has rounding issues

This simple example shows that union / intersection suffer from small rounding in values.
function main () {
    var c1 = cube({size: [44, 26, 5.0], center: true});
    c1 = c1.translate([0,0,-1.25]); // change to correct error
    var c1bounds = c1.getBounds();

    var c3 = cube({size: [44, 26, 1.8], center: true}); // change to correct error
    var c3bounds = c3.getBounds();

    var z = c1bounds[0].z - c3.getBounds()[1].z;
    console.log(z);
    c3 = c3.translate([0,0,z-0.000001]); // change to 0.1 to see effect on union
    var c3translate = c3.getBounds();

    console.log(c1bounds[0]);
    console.log(c3bounds[1]);
    console.log(c3translate[1]);

    var c1c2c3 = union(
        c1,
        c3
    );
    return c1c2c3.intersect(cube({size: 100, center: true}).translate([0, 50, 0]));
}

Shorter version.
function main () {
    var c1 = CSG.cube({radius: [22, 13, 2.5], center: [0,0,-1]});
    var c3 = CSG.cube({radius: [22, 13, 0.9], center: [0,0,-4.4]});
    var c4 = CSG.cube({radius: [50,50,50], center: [0,50,0]});

    var c1c3 = union(c1,c3);
    return c1c3.intersect(c4);
}

There seems to be an issue with mayOverlap(), as this union(c1,c3) is returning a combined geometry with ALL polygons from c1 and c3. I checked... mayOverlap() is returning 'false'.
    var overlaps = c1.mayOverlap(c3);
    console.log(overlaps);
    console.log(c1.getBounds());
    console.log(c3.getBounds());

but is that not coherent ?
if I do a union of disjointed (non overlapping) shapes , I would expect the union to contain all the polygons of both

Not in this case. c1 and c3 actually meet at Z = -3.5 but there's a rounding issue, which results in comparing -3.5 and -3.500000004. mayOverlap is just for optimization, but in this case the extra polygons cause intersection to fail.

ahh ok that makes it a lot clearer, sorry !

No problem. This only uncovered an issue in mayOverlap() function. I'm sure there are other precision issues. :(

Should just switch to integer math. ;)

the issues in mayOverlap() have been resolved and tested in V2


protractor timeout issue with $http asynchronous task

Hi there!
My angularJS application using event-steaming and it keeps open the http event-steam request and listening server events. So my problem is when protractor start testing of my angularJS application, it keeps wait to complete event-stream http request as i am using ignoreSynchronization=false so protractor waits until it gets timeout as event-stream http request never going to finish. So i would like to teach my protractor to ignore such event-stream $http tasks and proceed testing of my application. These event-stream is implemented throughout of my application so every time there is event-stream request then protractor getting timeout.
The following error i am getting when its timeout: Failed: Timed out waiting for asynchronous Angular tasks to finish after 300 seconds. This may be because the current page is not an Angular application. Please see the FAQ for more details: https://github.com/angular/protractor/blob/master/docs/timeouts.md#waiting-for-angular. The following tasks were pending: - $http: https://example.com/custom/xxx/sse
Can anyone please help me to get rid of this issue?
FYI: I am using angular 1.6 and protractor 5.x versions.

Hi there!
Your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!


Better error message for deserializing into array with more elements than expected

serde_json reports the error Error("trailing characters", line: ..., column: ...) whenever there are more elements in the JSON array than in the struct definition, which is very confusing as the JSON is valid.
Playground link: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=7aea3d19b21cea1292a7e8d9d8fae1d3
Perhaps it could detect if there are more elements and error with something like Error("more elements than array would contain", line: ..., column: ...)?

I came here with the same problem.
I even made a playground link as well:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=76db96837382e6f774f88c3110cc2201
I'd definitely be interested in writing a PR to fix this, although a couple tips about where to look would be greatly appreciated.
I suppose this would be the test case that we'd like to have pass:
    let more_elements_err: [f32; 2] = serde_json::from_str("[1.0, 2.3, 3.0]").unwrap_err();
    assert_eq!(more_elements_err.to_string(), "more elements than array should contain");

Alternatively, perhaps we should consider that we have a precedent to follow.
Unknown map fields are simply ignored.
If you think of arrays as maps with implied numerical keys, then it would make since for us to simply ignore the extra digits, so perhaps the test case should be:
    let two_list: [f32; 2] = serde_json::from_str("[1.0, 2.3, 3.0]")
        .expect("couldn't parse list with three elements into a list with two");
    assert_eq!(two_list, [1.0, 2.3]);


.mvnw results in issue on sonar-project.properties

After using the blueprint and trying to initialize using ./mvnw
I get following BUILD FAILURE exception:
[INFO] --- properties-maven-plugin:1.0.0:read-project-properties (default) @ campusrecruitment ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.752 s
[INFO] Finished at: 2019-05-12T16:29:44+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:properties-maven-plugin:1.0.0:read-project-properties (default) on project campusrecruitment: Properties could not be loaded from File: /Users/userid/Documents/jhipstervuejs/sonar-project.properties -> [Help 1]
I can see this file was not created during project creation.
After manually creating a file named sonar-project.properties (even if empty) the ./mvnw does continue.

Hi, did you use the latest version of the blueprint or the latest beta tag?

Hi, I believe I've used 1.0.0-beta2, is there anyway for me to check?

It depends how you installed it first. We should do a release soon we tons of fix and also, compatibility with JHipster 6.0.x. This is your problem here, as 1.0.0-beta2 do not work with JHipster 6.

Hi @strat1987, you can now use the latest version.

Hi @sabrinapayet , Thanks for your effort! This issue is now resolved by rerunning

yarn global upgrade generator-jhipster-vuejs
jhipster --blueprint vuejs
.mvwn
[INFO] BUILD SUCCESS


Tacotron Synthesis Notebook error

Pls please help. I dont know anything ab codeing so I have no idea what to do. What should I do? step by step
_RuntimeError                              Traceback (most recent call last)
 in ()
4 hparams.gate_threshold = 0.1 # Model must be 90% sure the clip is over before ending generation (the higher this number is, the more likely that the AI will keep generating until it reaches the Max Decoder Steps)
5 model = Tacotron2(hparams)
----> 6 model.load_state_dict(torch.load(tacotron2_pretrained_model)['state_dict'])
7 _ = model.cuda().eval().half()
1 frames
/usr/local/lib/python3.7/dist-packages/torch/serialization.py in init(self, name_or_buffer)
240 class _open_zipfile_reader(_opener):
241     def init(self, name_or_buffer) -> None:
--> 242         super(_open_zipfile_reader, self).init(torch._C.PyTorchFileReader(name_or_buffer))
243
244
RuntimeError: PytorchStreamReader failed reading zip archive: failed finding central directory_

Can you post a full code here? You probably have some issues with the paths


require or import not supported

Using flutter_liquidcore code like the following returns errors:
ReferenceError: require is not defined; or
ReferenceError: import is not defined.
if (_jsContext == null) {
_jsContext = new JSContext();
String code = """
const API = require('./local-api/index.js')();
API.login("${aEmail}", "${aPassword}").then((output) => {
API.Stats("${userTag}", "${platform}").then((output) => {
console.log(output);
}).catch((err) => {
console.log(err);
});
}).catch((err) => {
console.log(err);
});
""";
Being a node.js environment and not being able to break my javascript out of that _jsContext bubble to reference other .js files seems important for the utility of flutter_liquidcore.

You should read up on the original library's documentation.
If you want to use things like "require" or "import"s on local files, then you need to bundle it up, then use a microservice.
The jscontext is for simple JavaScript evaluations. It doesn't do any file management type stuff.


I need permission to add new branch

Hi
I have done some improvements to jeg, but I need permission to create a new branch.
Please help.
Cheers,
Gabriel

Hi,
usually you fork the project and work on (your) fork. To upstream the changes initiate a pull request (see https://help.github.com/articles/creating-a-pull-request-from-a-fork/). Pleased to see your changes!

thx