Getting elementKeyDownEventRemover() is not a function when removing file preview

We are using the drop as a file uploader where you can clear the files when the upload is finished.
When I clear a file, this is done by clicking the file, I get the error message:
this.elementKeyDownEventRemover() is not a function when removing file preview
This happens if I drop a file and clear it by clicking on it. If I however focus the droppable element beforehand, clicking on it and browse to the file. I don't get the error.
Since we're using react I can do a workaround like this:
componentDidMount() {   this.dropzone.focus() }
But it shouldn't be necessary.

Hey @Fralleee , thanks for reporting this ! I will fix it right away .
Cheers !

I believe I found the issue on #18 , included in release 2.1.3 #20 and released in a few minutes.

Hey @Fralleee , could you update your droppable package to 2.1.3 and try again?
npm update droppable --save should do it.

Hey, updated to 2.1.4 and I still get the error.
Screenshot of error+stack: https://imgur.com/a/dk0Sl

Hi @Fralleee .
For some reason the element you are making droppable does not trigger a focus event, so the event needed for accessibility support is never added.
I will fix the error by making sure the remover gets called only if the event was added but it would be great if you could give me some info on the type of element (div, input ... ) , if you have set thetabindex attribute manually and whether you are doing something with focus events.
This will help make the library more robust.
Thank you in advance! I'll ping you once the fix is released.

I am using a regular div as my element, not setting tabindex on the element.
Code I am using: https://gist.github.com/Fralleee/36657a6aeb5483d5665b7b75bf101b48
Is the droppable contructor supposed to focus the element?

Hi @Fralleee , the library adds a tabindex=0 attribute to make the element focusable, as the accessibility button spec requires. It then adds an event listener for focus to handle enter key down (also accessibility spec).
In your case, it seems, that the focusout event is called but the focus is not.
I'll set up a demo with your code and get to the core of the problem.

Hey @Fralleee , I believe fixed with #21 and deployed with #22 .
Please run npm update droppable --save once more.

Works great. Good job!


picard metrics from bcbio

Hi Brad and others,
When I tried to look more into the code I see that there is code implemented to parse different picard metrics. We are mostly interested in hsmetrics. The new version of bcbio no more places those results in the align folder. How can get them?
Thanks,
Diya

Diya;
Thanks for the suggestions and thoughts. We don't currently run Picard metrics in bcbio -- they'd been removed primarily due to speed issues. I do agree that HsMetrics has some useful stats that it might make sense to include for capture experiments. @lpantano has been refactoring the bcbio QC to use MultiQC:
https://github.com/ewels/MultiQC
which supports parsing and including these in the report. Maybe we should think about re-including this, or trying to get equivalent statistics with Qualimap. Happy to discuss more about how best to do this.

Hi,
I am happy to include other metrics here. I wasn’t here when bcbio was using that, but if you tell me kind of metrics you would like, I can dig into different tools to get them.
cheers

On Apr 13, 2016, at 4:38 PM, Brad Chapman<EMAIL_ADDRESS>wrote:
Diya;
Thanks for the suggestions and thoughts. We don't currently run Picard metrics in bcbio -- they'd been removed primarily due to speed issues. I do agree that HsMetrics has some useful stats that it might make sense to include for capture experiments. @lpantano https://github.com/lpantano has been refactoring the bcbio QC to use MultiQC:
https://github.com/ewels/MultiQC https://github.com/ewels/MultiQC
which supports parsing and including these in the report. Maybe we should think about re-including this, or trying to get equivalent statistics with Qualimap. Happy to discuss more about how best to do this.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/chapmanb/bcbio-nextgen/issues/1335#issuecomment-209638516

Thank you Brad and Ipantano.
I agree that having picard run will have speed issues. We ourselves faced it while we were using the older version of bcbio. Even if there are other tools to calculate the coverage and other stats which picard hs metrics provides we are more than happy to use them. We are mainly interested in getting the hs metrics (On bait bases, near bait bases, off bait bases, mean bait coverage, on target bases, mean target coverage, 10x coverage targets, zero coverage targets, fold enrichment).
We did try to run multi qc on our sample. I see it has few basic stats and figures from fastqc report. It is a good report but that won't be sufficient for our clients.

ngscat appears to be a faster alternative, with useful metrics:
http://www.bioinfomgp.org/ngscat
Hope it helps.
On Wed, Apr 13, 2016 at 2:29 PM, DiyaVaka<EMAIL_ADDRESS>wrote:

Thank you Brad and Ipantano.
I agree that having picard run will have speed issues. We ourselves faced
it while we were using the older version of bcbio. Even if there are other
tools to calculate the coverage and other stats which picard hs metrics
provides we are more than happy to use them. We are mainly interested in
getting the hs metrics (On bait bases, near bait bases, off bait bases,
mean bait coverage, on target bases, mean target coverage, 10x coverage
targets, zero coverage targets, fold enrichment).
We did try to run multi qc on our sample. I see it has few basic stats and
figures from fastqc report. It is a good report but that won't be
sufficient for our clients.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/chapmanb/bcbio-nextgen/issues/1335#issuecomment-209654053

Thanks.
I am currently working in getting coverage metrics, mean coverage, 10x coverage targets and similar. That would be in the next version of multiqc, I hope to add these features in the next week.
I will try ngscat, but the web is not working right now.
I guess off bait bases are off-target reads (meaning reads outside the target regions)? this should be in multiqc, the others related to target regions will come shortly and I can add more metrics since we calculate the data.  As well, if you did variant calling, it would have number of variants detected, known variants, other similar stats. As well, it would plot coverage ~ variant relationship, and CG content as well. In general should be quite better for stats related to variant calling pipeline and showing the targeted regions enrichment.

On Apr 13, 2016, at 5:29 PM, DiyaVaka<EMAIL_ADDRESS>wrote:
Thank you Brad and Ipantano.
I agree that having picard run will have speed issues. We ourselves faced it while we were using the older version of bcbio. Even if there are other tools to calculate the coverage and other stats which picard hs metrics provides we are more than happy to use them. We are mainly interested in getting the hs metrics (On bait bases, near bait bases, off bait bases, mean bait coverage, on target bases, mean target coverage, 10x coverage targets, zero coverage targets, fold enrichment).
We did try to run multi qc on our sample. I see it has few basic stats and figures from fastqc report. It is a good report but that won't be sufficient for our clients.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/chapmanb/bcbio-nextgen/issues/1335#issuecomment-209654053

Awesome. Can we expect the hs metrics results to be available by the end of the month? Since we are already using the stable version bcbio how can we upgrade just a single tool?

@lpantano , your list is better.. I guess you don't need to bother with ngscat in that case.
And I like your metrics on the variants, I wonder if you will separate the figures for somatic and germline variants.

For the record, I would not recommend TEQC because it has (used to have?) huge issues with parsing BAM files with different chromosome names ("chr1" vs "1").

Thanks Luca, it's good to know.
On Fri, Apr 15, 2016 at 12:12 AM, Luca Beltrame<EMAIL_ADDRESS>wrote:

For the record, I would not recommend TEQC because it has (used to have?)
huge issues with parsing BAM files with different chromosome names ("chr1"
vs "1").
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/chapmanb/bcbio-nextgen/issues/1335#issuecomment-210321865

Hi lpantano,
Just checking back with you if the stats from picard program are implemented in your multiQC report? Please let me know if this takes longer, we can implement picard in our master piepline to generate them for our researchers.
Thanks,
Diya

hi
i implemented multiqc-bcbio, that will try to adapt our metrics to multiqc.
you will need to update tools and probably the dev version of bcbio or wait to the next release.
But to have coverage information you will need to add to the yaml
file the coverage option pointing to a bed file with regions. Can be all the regions of your capture or anything.
As well, if you add tools_on: [qualimap_full] you should get
that into multiqc.
You can check if this is enough and work together to add more information you are missing or/and you can add picard as a backup
plan.
I will continue adding metrics to QC, and will try not to be dependent on bcbio develop code but stable version in the future, but i needed to do some low level changes.
cheers
sent not from my computer

On Apr 25, 2016, at 18:16, DiyaVaka<EMAIL_ADDRESS>wrote:
Hi lpantano,
Just checking back with you if the stats from picard program are implemented in your multiQC report? Please let me know if this takes longer, we can implement picard in our master piepline to generate them for our researchers.
Thanks,
Diya
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub

Hi Ipantano,
Thanks for the metrics. It took us long to go through all the data generated from the report. When we compare our recent reports with the previous ones we are still missing off bait, near bait percentages, and zero coverage metrics. Are we not running picard metrics to get all the stats?
It would be a great help if we can derive these through qulaimap and multiqc reports as you guys are already getting lot of information from different tools. If not then we need to run picard independently just for these.

Thanks for the feedback!, I will talk to Brad to get a plan how to integrate these missing metrics.

On May 9, 2016, at 2:45 PM, DiyaVaka<EMAIL_ADDRESS>wrote:
Hi Ipantano,
Thanks for the metrics. It took us long to go through all the data generated from the report. When we compare our recent reports with the previous ones we are still missing off bait, near bait percentages, and zero coverage metrics. Are we not running picard metrics to get all the stats?
It would be a great help if we can derive these through qulaimap and multiqc reports as you guys are already getting lot of information from different tools. If not then we need to run picard independently just for these.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub https://github.com/chapmanb/bcbio-nextgen/issues/1335#issuecomment-217952745

Hi Ipantano,
I see there is offtarget percentage in one of the multiqc report file. Does this mean off bait percentage?
Thanks,
Diya

i think so. Is the reads outside the target regions you used for the analysis.

On May 10, 2016, at 2:50 PM, DiyaVaka<EMAIL_ADDRESS>wrote:
Hi Ipantano,
I see there is offtarget percentage in one of the multiqc report file. Does this mean off bait percentage?
Thanks,
Diya
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/chapmanb/bcbio-nextgen/issues/1335#issuecomment-218253626, or mute the thread https://github.com/notifications/unsubscribe/ABi_HE-6SbX1xYn6WmiP339Aj7hufitOks5qANNygaJpZM4IGvYn.

Hi,
I think we cannot get near bait percentages if that means reads around the target regions right now.
Could you tell me exactly what is zero coverage metrics? If it is target with 0 reads, I can add that because we calculate the coverage for all the regions, so that would be easy to add as table or numbers.
thanks for helping with that.

Lorena and Diya;
I think the best approach would be to have a pluggable option to run Picard HsMetrics:
https://broadinstitute.github.io/picard/picard-metric-definitions.html#HsMetrics
and then ensure this gets integrated into the QC report. Diya, this is definitely something we'd like to work on as we continue to revamp the QC module to be more generic. If there are other equivalent reports for hybrid capture happy to consider those instead of Picard.

it makes sense. Multiqc has already the module for parsing HsMetrics, so we just need to add a option to run picard.

On May 17, 2016, at 9:42 AM, Brad Chapman<EMAIL_ADDRESS>wrote:
Lorena and Diya;
I think the best approach would be to have a pluggable option to run Picard HsMetrics:
https://broadinstitute.github.io/picard/picard-metric-definitions.html#HsMetrics https://broadinstitute.github.io/picard/picard-metric-definitions.html#HsMetrics
and then ensure this gets integrated into the QC report. Diya, this is definitely something we'd like to work on as we continue to revamp the QC module to be more generic. If there are other equivalent reports for hybrid capture happy to consider those instead of Picard.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub https://github.com/chapmanb/bcbio-nextgen/issues/1335#issuecomment-219721052

Thank you Lorena and Brad.
% Zero coverage is "targets which have no reads". I see there is a off target percentage in metrics.tsv file from the report folder. When we add off target and on target percentage, and subtract it from the 100% we get near target %. So for now we should be good with that. Getting the zero coverage solves the issue.
I definitely go with brad, for future we can have picard as a pluggable option.
Thank you both.
Diya

Hi Brad and lorena,
When we look at the qualimage report I see that been generated by using sort.bam file.
Your previous version report was based on recalub.realign.bam file.
Does it make more sense to have the report numbers on the recalib.realign bam file?? Previous you guys provided us with this bam. Now we no more see those intermediate files in bcbio align directories.
Either we need to have this bam file to do the stats ourselves or can you guys make qualumap use that bam file before they get deleted??
Thanks,
Diya

Diya;
We did switch over to using the standard aligned BAM file for quality control. The recalibrated/realigned BAM will still be produced, and saved in the output directory, if you have recalibrate: true and realign: true in your algorithm configuration.
We prefer using the aligned/de-duplicated BAMs, instead of the post-processed ones, for consistency between analyses. We generally don't use recalibration and realignment for standard runs. Either way, you shouldn't expect a lot of differences in results between these two so hopefully it won't impact any of your interpretations and downstream analysis. Hope this helps.

Hi Brad,
Thanks for your answers. Yes, we do use them in our sample.yaml file, but still we donot see them in the output folder.

Diya;
The sample/sample-ready.bam file in your output folder should be the realigned/recalibrated BAM file. We don't store two separate files (aligned only, plus this) to avoid disk space concerns. In general we like to have as few copies of BAM files around as we can. Hopefully that provides what you need.

Thank you Brad

Hi,
picard metrics now can be integrated with multiqc in the next version, and picard can be run with bcbio if it is in tools_on.
hopefully this will help you. We continue working to get the report as complete as possible with the default QC tools though.

Awesome. Will definitely give it a try for our next run. Thanks a bunch

Hi,
I will close this, but feel free to open if still what we have is missing some parts.
Thanks!


Ideas for new visualizations

Cord diagram of what user or orgs commit to code owned by what other user/orgs.

This will show members of the community who work on stuff other than their own.

Visualization to show in grid form what code is used by others. In other words, tool X is used by tools Y,W,Z and tool A is used by tools G, T, D, Z.

This would presumably show what projects are component tools that can be used as building blocks as opposed to to end-user tools.

What code projects in the list share the most number or % of dependencies with either a selected tool in the metadata or a list of dependencies provided via CSV, requirements.txt or other method?

Create repo personas and categorize each repo as a type. Something like below but need to do more work to establish the boundaries are easy to calculate as a metric without gaps between.

More than 10 contributors last 12 months, more than 100 stars but 90% of issues and pull requests stay open less than 2 months and 95% get a first response within 3 days and 70% within 1 day but response is one person 75% of the time =  attracted community and response excellent but potentially at risk for burnout
More than 10 contributors last 12 months, more than 100 stars but 90% of issues and pull requests stay open less than 2 months and 95% get a first response within 3 days and 70% within 1 day =  attracted community and response excellent
More than 10 contributors last 12 months, more than 100 stars but 20% of issues and pull requests stay open more than 2 months =  attracted community but response lags  a little
More than 10 contributors last 12 months, more than 100 stars but 30% of issues and pull requests stay open more than 2 months =  _attracted community but response lags _
More than 10 contributors last 12 months, more than 100 stars =  attracted community
More than 1 contributor but less than 6 contributors within past 18 months = puppy project
zero contributions in last 12 month but had a contribution after first 3 months. definitely grounded
zero contributions in last 6 month but had a contribution after first 3 months. probably grounded
zero contributions after 3 months on GitHub = published and did not attract contributions
single contributor and more than 3 months on GitHub = solo project
new to GitHub within 3 months = too little information to judge

Things to use as metrics.... some of these are already captured, are captured but need calculated, or still need collected from the GitHub API.

time:

date of data fetch is before or after 90 days repo started on GitHub (true/false)
calculate other metrics within the past 365 days
calculate other metrics within the first 90 days

Contributors

number of contributors within first 20 days (assuming these are team members)
number of contributors within first 90 days (any additional to first 20 days may be new members)
number of contributors all time (additional contributors may be new team members or external contributors attracted to the project.

Pull Requests

number within first 20 days
number within first 90 days
number overall
number within last 365 days if more than 1 year old.

Issues

number within first 20 days
number within first 90 days
number overall
number within last 365 days if more than 1 year old.

Stars

number within first 20 days
number within first 90 days
number overall
number within last 365 days if more than 1 year old.

Total activity (Stars, Issues, Pull Requests)
Ratios:

issues/pull requests
open/closed issues
open/closed pull requests
pull requests open after X unit of time
issue open after X unit of time.


when I use jquery UI effects the height behavior was very strange

I had an iframe in side a PopUp which is having minimize icon. When it was minimized there is a maximize icon to display that PopUp. By default It was maximized and displayed until user clicks on minimize icon everything working to be fine. When user clicks on minimize icon I need to hide the PopUp and need to show a maximize icon, here I'm using jquery UI effect to hide slowly with an duration of 1 sec. While Hiding the PopUp the height returning was very weird.
Is any thing I'm missing while initializing the iframeResizer. I'm using the basic settings which were shown in the example.
OR
Is there a way to stop and start the resizing observer when user clicks on minimize / maximize?

Is anybody there to respond this issue?

You say you are using the basic settings. Could you share your actual
settings? That might make it easier to offer some advice.
On Fri, 11 Dec 2015 06:21 psr1410<EMAIL_ADDRESS>wrote:

Is anybody there to respond this issue?
—
Reply to this email directly or view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/296#issuecomment-163854375
.

$('#iframe-container').iFrameResize({
log                     : false,                  // Enable console logging
inPageLinks             : true,
interval                : 300,
resizedCallback         : function(messageData){
contentHeight = parseInt(messageData.height);
//My height related modifications
}
});
$(document).on("click",".minimize-icon", function(){
$(".content-holder").hide(1000);
});
$(document).on("click",".maximize-icon", function(){
$(".content-holder").show(500,'swing');
});

You can force the iFrame to resize by doing this:
document.getElementById('myIFrame').iframeResizer.resize();


Make callbacks to a submodule

You want to make a PR to Talos
Thanks so much :) First, please take a moment to carefully check through
the below items:
Sanity

[ ] I'm aware of the implications of the proposed changes
[ ] Code is PEP8
[ ] I'm making the PR to master
[ ] I've updated the versions based on Semantic Versioning

[x] setup.py
[ ] talos/__init__.py
[ ] docs/index.html
[ ] docs/_coverpage.md

Docs

[ ] Docs are updated

Tests

[ ] Changes have gone through actual use testing
[ ] All local tests have passed (run ./test.sh in /talos)
[ ] Tests have been updated to reflect the changes

Hello @mikkokotila! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file talos/__init__.py:

Line 17:1: E402 module level import not at top of file

In the file tests/commands/test_latest.py:

Line 46:80: E501 line too long (89 > 79 characters)


Reactions don't modify isotope unless chemical element is specified for the product

Let's say I want to use a reaction to change atoms with isotope 13 to isotope 14, regardless of the chemical element. I would expect the reaction SMARTS '[13:1]>>[14:1]' to do the trick. Or maybe '[13*:1]>>[14*:1]'. But as shown below, it doesn't, even though the reaction matches and yields a product. If I specify the element on the product side of the reaction SMARTS, as in '[13:1]>>[14C:1]', I do get a product with the desired isotope.
>>> from rdkit import Chem
>>> from rdkit.Chem import AllChem
>>> mol = Chem.MolFromSmiles('C[13CH2]C')
>>> Chem.MolToSmiles(mol, isomericSmiles=True)
'C[13CH2]C'
>>> rxn = AllChem.ReactionFromSmarts('[13:1]>>[14:1]')
>>> prod = rxn.RunReactants([mol])[0][0]
>>> Chem.MolToSmiles(prod, isomericSmiles=True)
'C[13CH2]C'
>>> rxn2 = AllChem.ReactionFromSmarts('[13:1]>>[14C:1]')
>>> prod2 = rxn2.RunReactants([mol])[0][0]
>>> Chem.MolToSmiles(prod2, isomericSmiles=True)
'C[14CH2]C'

Why would I know which isotope I want to change and yet not know the chemical element of the atom? Admittedly, this was part of a hack where I tried using the isotope as an atom label of sorts (similar to what ReplaceCore() does).

After a quick look through the code, I believe that this should work, so I think this is a bug.
It certainly works ok with charge:
>>> rxn = AllChem.ReactionFromSmarts('[+1:1]>>[+2:1]')
>>> Chem.MolToSmiles(rxn.RunReactants((Chem.MolFromSmiles('CC[NH3+]'),))[0][0])
'CC[NH3+2]'

Thank you for looking into this so quickly!


Modify aws discovery

in addition to https://github.com/sansible/zookeeper/pull/9
I made the same changes for the Kafka role

Closed by #13


Add workflow to automatically set project

Needs a token.

see https://github.com/OpenSlides/openslides-icc-service/pull/85#issuecomment-1382733348


Remove generics for the superclass when generating inject adapters

This makes the generated code similar to how it was in Dagger 1.2.2 when generating the supertype field in inject adapters that have a generic superclass.
Closes #531

@swankjesse any thoughts?
lgtm

Works for me.

I'll do a dot release tonight or tomorrow


Dropdown settings to match headers theme

Have a follow up task for settings to match headers theme

Not required anymore


[BUG] Responsiveness of the website

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Description
The website is not at all responsive , elements are getting cut on different dimensions.

In the above images on different dimensions website elements are getting cut. It does'nt show responsiveness.
Steps to Reproduce
Include any relevant details like:

What page you were on...
What you were trying to do...
What went wrong...
I was on the homepage of the website, testing its responsiveness across different screen sizes and devices. The goal was to ensure that all elements adapt correctly when the viewport changes. However, I encountered the following issues:

The layout does not adjust properly on smaller screens (e.g., mobile devices). Elements either overlap or do not scale correctlly.
interactive components do not reformat as expected when the screen size changes.
Certain sections do not resize or realign, causing a broken layout or horizontal scrolling.
Screenshots
No response
Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this
No response

i assigned it to you

make sure you star repo ⭐  and follow on github , giving hacktoberfest tag after this step

I have followed you and also starred the repo please hacktoberfest tag .
Already started working on the issue.
Thanks!

completed


[AutoPR datafactory/resource-manager] Update Db2LinkedServiceTypeProperties

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7546

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/6153


cf release manifest

Can you post the url to the cf release manifest that is used when "cf dev start" runs.
I have delete the existing cf deployment and want to deploy an exact release
Thanks

Hi! Unfortunately, we do not host the cf release manifest anywhere since it is generated during the build process. However, it is pretty easy to retrieve if you have a cfdev up and running, as posted here, you can do:
$ eval "$(cf dev bosh env)"
$ bosh -d cf manifest > ./cf.yml

However, unfortunately Github issues is not the best platform for the sequential nature of questions that you're asking. We'll be very happy to provide more real-time assistance in the '#pcfdev' channel in https://cloudfoundry.slack.com. You've already posted there, so it's is completely our fault for not keeping a closer eye on it. We promise to do so now.


regexp: add S.regexEscape

This will obviate the need for dependencies such as escape-regexp when using Sanctuary.
I'm open to name suggestions. escapeRegexMetachars is more descriptive, but feels too long.
I copied the regular expression from XRegExp.
This is the first time I've used JSVerify. I'm impressed. We should write more tests this way!

Nice, I was only using escape-regexp last week. JSVerify looks great too.

LGTM, @davidchambers.


Fix sending customer coupon without newsletter signup.

v.2.5.1
change lines 878-879 to:
+++ $newsletter = $params['newCustomer']->newsletter;
+++ if (Validate::isEmail($email)&& $newsletter) {
----- if (Validate::isEmail($email)) {
for prevent sending new customer coupon without newsletter signup.

@tprzybysz-netsystem I think you have done mistakes because you don't take your repository as base.


Update README

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.00%. Comparing base (444435f) to head (af0cfcc).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   88.67%   89.00%   +0.32%
==========================================
  Files          18        6      -12
  Lines         777      200     -577
==========================================
- Hits          689      178     -511
+ Misses         88       22      -66

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Align command-line interface across all projects

There are a number of variations in CLIs across the various projects, which could be smoothed out to facilitate understanding for users.
The existing CLIs include:
@accordproject/concerto-cli
concerto -- for Concerto code generation / download
@accordproject/markdown-transform
markus -- for CommonMark/CiceroMark/Slate transform and generation
@accordproject/ergo-cli
ergoc -- for the Ergo compiler
ergorun -- for Ergo standalone execution
@accordproject/cicero-cli
cicero -- for template parsing/generation/execution

It would help if those use the same version of yargs as well since the usage/help output varies between them.

Ergo:

ergo <cmd> [args]                                                      // replaces ergorun & ergoc

Commands:
  generate      generate a markdown sample from contract data
  execute       execute a contract with a request
  invoke        invoke a clause within a contract
  init          initialize a contract
  compile       generate code for a target platform                    // replaces ergoc

Cicero:

cicero <cmd> [args]

Commands:
  parse         parse a markdown sample using a template
  generate      generate a markdown sample from template data          // used to be generateText
  roundtrip     roundtrip a markdown sample using a template           // new
  execute       execute a template with a request
  invoke        invoke a clause within a template                      // new
  init          initialize a contract template
  archive       archive a template directory
  compile       generate code for a target platform                    // used to be generate
  get           save local copies of external dependencies             // new

Markus:

markus <cmd> [args]

Commands:
  parse         parse a markdown sample
  roundtrip     rountrip a markdown sample

Concerto:

concerto <cmd> [args]

Commands:
  validate      validate JSON against model files
  compile       generate code from model files
  get           save local copies of external dependencies

Additional alignment could happen on the options for some of the commands. For instance:

--out / --outputDirectory --> --output for all commands
--format / --target --> --target for the compile command
--data / --contract --> --data for the generate command
...

A slightly more radical proposal (trying to take feedback from the Ergo call into account):

Ergo:

ergo <cmd> [args]                                              // replaces ergorun & ergoc

Commands:
  draft         create a contract text from data               // new
  request       send a request to the contract                 // used to be execute
  invoke        invoke a clause of the contract
  initalize     initialize a contract                          // used to be init
  compile       generate code for a target platform            // replaces ergoc

Cicero:

cicero <cmd> [args]

Commands:
  parse         parse a contract text using a template
  draft         create contract text from data                 // used to be generateText
  redraft       parse a contract text and re-create it         // new
  request       send a request to the contract                 // used to be execute
  invoke        invoke a clause of the contract                // new
  initialize    initialize a contract                          // used to be init
  archive       create a template archive
  compile       generate code for a target platform            // used to be generate
  get           save local copies of external dependencies     // new

Markus:

markus <cmd> [args]

Commands:
  parse         parse a markdown text
  draft         create markdown text from data
  redraft       parse a markdown text and re-create it

Concerto:

concerto <cmd> [args]

Commands:
  validate      validate JSON against model files
  compile       generate code for a target platform           // used to be generate
  get           save local copies of external dependencies

I mentioned this on the Ergo call, but will reiterate here for those who were not able to make it:
I do not use the CLIs very often, so this may not be a real concern (I would be interested in hearing opinions from those that do currently use it often), but my one thought is that it may be confusing for people who use the generate command currently, since that command will still exist but will be doing something different than before. In this case, it may be better to come up with a new term entirely to avoid confusion.

I mentioned this on the Ergo call, but will reiterate here for those who were not able to make it:
I do not use the CLIs very often, so this may not be a real concern (I would be interested in hearing opinions from those that do currently use it often), but my one thought is that it may be confusing for people who use the generate command currently, since that command will still exist but will be doing something different than before. In this case, it may be better to come up with a new term entirely to avoid confusion.

Thanks for the feedback @DianaLease
The second proposal above uses draft instead of generateText or generate.

ergo <cmd> [args]                                              // replaces ergorun & ergoc

Commands:
  draft         create a contract text from data               // new
  execute       send a request to the contract
  invoke        invoke a clause of the contract
  initalize     initialize a contract                          // used to be init
  compile       generate code for a target platform            // replaces ergoc

Cicero:

cicero <cmd> [args]

Commands:
  parse         parse a contract text using a template
  draft         create contract text from data                 // used to be generateText
  redraft       parse a contract text and re-create it         // new
  execute       send a request to the contract
  invoke        invoke a clause of the contract                // new
  initialize    initialize a contract                          // used to be init
  archive       create a template archive
  compile       generate code for a target platform            // used to be generate
  get           save local copies of external dependencies     // new

Markus:

markus <cmd> [args]

Commands:
  parse         parse a markdown text
  draft         create markdown text from data
  redraft       parse a markdown text and re-create it

Concerto:

concerto <cmd> [args]

Commands:
  validate      validate JSON against model files
  compile       generate code for a target platform           // used to be generate
  get           save local copies of external dependencies

Command changes:

generateText -> draft
init -> initialize
compile / generate --> compile
Ergo gets a new draft command (like Cicero)
Cicero gets a new get command (like Concerto)
CLIs with both parse and draft (Markus and Cicero) get a new command redraft for round-tripping

As per the working group call discussion, IMO:

redraft should become normalize
invoke should be removed from ergo
execute should become trigger

Comments from Technology Wg call:

Unsure about draft
People really do not like redraft, suggestions would be to move it back to an option (on --parse or --draft) or to rename it, e.g., to `normalize
Confusion about invoke what it is and whether a better name could be used.
execute has a very different legal meaning from the one here. It could be changed. e.g., trigger

As per the working group call discussion, IMO:

redraft should become normalize
invoke should be removed from cicero
execute should become trigger

I like trigger!
I don't love normalize which to me doesn't mean much to either a lawyer or to a developer unless explained (and it doesn't relate to either parse nor draft). With that said, I don't have a better idea so I'll use that. (there was some push back about roundtrip on the Ergo call two weeks ago).
if we remove invoke from cicero I feel it should be also removed from ergo. However this is a very fundamental call -- e.g., that's how init and draft are implemented. What is the rationale for removing it?

As per the working group call discussion, IMO:

redraft should become normalize
invoke should be removed from cicero
execute should become trigger

Additional question: should the API calls be renamed accordingly:
TemplateInstance.generateText -> TemplateInstance.draft
new TemplateInstance.normalize
Engine.execute -> Engine.trigger
Engine.init -> Engine.initialize
new Engine.invoke

Summary of discussion on this, I will implement the following:
cicero <cmd> [args]

Commands:
  parse         parse a contract text using a template
  draft         create contract text from data                 // used to be generateText
  normalize    parse a contract text and re-create it         // new
  trigger       send a request to the contract
  invoke        invoke a clause of the contract                // new
  initialize    initialize a contract                          // used to be init
  archive       create a template archive
  compile       generate code for a target platform            // used to be generate
  get           save local copies of external dependencies     // new

And I will update the API on the template instance and engine to reflect those commands.

The final, implemented proposal:

Ergo

ergo <cmd> [args]                                              // replaces ergorun & ergoc

Commands:
  draft         create a contract text from data               // new
  trigger       send a request to the contract
  invoke        invoke a clause of the contract
  initalize     initialize a contract                          // used to be init
  compile       generate code for a target platform            // replaces ergoc

Cicero:

cicero <cmd> [args]

Commands:
  parse         parse a contract text using a template
  draft         create contract text from data                 // used to be generateText
  normalize      parse a contract text and re-create it         // new
  trigger       send a request to the contract
  invoke        invoke a clause of the contract                // new
  initialize    initialize a contract                          // used to be init
  archive       create a template archive
  compile       generate code for a target platform            // used to be generate
  get           save local copies of external dependencies     // new

Markus:

markus <cmd> [args]

Commands:
  parse         parse a markdown text
  draft         create markdown text from data
  normalize     parse a markdown text and re-create it

Concerto:

concerto <cmd> [args]

Commands:
  validate      validate JSON against model files
  compile       generate code for a target platform           // used to be generate
  get           save local copies of external dependencies

Command changes:

generateText -> draft
init -> initialize
execute -> trigger
compile / generate --> compile
Ergo gets a new draft command (like Cicero)
Cicero gets a new invoke command (like Ergo)
Cicero gets a new get command (like Concerto)
CLIs with both parse and draft (Markus and Cicero) get a new command normalise for round-tripping

This work is now completed, part of the upcoming 0.20 release.


Security Problem.

Hello! I checked your code on Github Global Campus and these are some issues i saw:
In the "main.py" create_table function, there's a missing closing parenthesis in the "subject_name VARCHAR(255".
Your code constructs SQL queries by directly injecting user input, which can make your code vulnerable to SQL injection attacks.
You must use parameterized queries or prepared statements to safely handle user input.
Other than these issues, your code looks nice. Good work with the project!

Currently I have broken this project into subparts and will later combine them to main.py as this is a big project but your issue is really important so for that I have thought of validating the imports and then set a time limit


Remove method not sending as from data

Hi,
I am trying to send form data to server with DELETE request.
I am trying remove(), customDELETE() methods to send form data to server but they are passed as query parameters instead of form data.
My code is as fallows:
var items = ['1','2'];
var data = {"deleteFlag": 'xx', "eventIdList": JSON.stringify(items)}
Restangular.service('events', Restangular.one('user', 12)).one().remove(data);

@mgonto I think we should focus on supporting REST methods and leave more advanced usages up to users, especially when they have customOperation method :)
To all - please refer to customOperation as @luto stated and follow the #930 as we are trying to sort out why delete has stopped working.


React Native and Genesys live chat not working

Hi Team,
I am trying to integrate genesys live chat in react native project. But this react native wrapper is not working for me. I would like to know about the below things.

Which version of widget used for react native integration ?
What is this domain and tokenStoreKey from the widget configurations ?

GenesysCloud.startChat(deploymentId, domain, tokenStoreKey, logging);
Could you please help on this ?

Hi,
I can help you to get answers for your second question.
domain is the regional base domain address for a Genesys Cloud Web Messaging service. For example, "mypurecloud.com".
tokenStoreKey is a key that we use to access device local storage. see SharedPreferences(Android) / Keychain(iOS)

From: Manikandan707 @.>
Sent: Monday, December 27, 2021 6:38 AM
To: MyPureCloud/genesys-cloud-messenger-mobile-sdk-rn-wrapper @.>
Cc: Subscribed @.***>
Subject: [MyPureCloud/genesys-cloud-messenger-mobile-sdk-rn-wrapper] React Native and Genesys live chat not working (Issue #8)
Hi Team,
I am trying to integrate genesys live chat in react native project. But this react native wrapper is not working for me. I would like to know about the below things.

Which version of widget used for react native integration ?
What is this domain and tokenStoreKey from the widget configurations ?

GenesysCloud.startChat(deploymentId, domain, tokenStoreKey, logging);
Could you please help on this ?
—
Reply to this email directly, view it on GitHubhttps://github.com/MyPureCloud/genesys-cloud-messenger-mobile-sdk-rn-wrapper/issues/8, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADQ2YHJD6ML55W2WG5UCJV3UTA6ZBANCNFSM5K2EIZSQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Language request: GNU linker script.

Request for GNU linker script!
(I create this issue because I hope somebody can code and RP to support Linker Script, and if I have time, I will do this.  😁 )

Due to a network problem, I accidentally created a duplicate issue.


Add configurable bufferSize per GExpect instance

This PR makes bufferSize configurable.  This is particularly useful when
dealing with large PTY output.  The original default is maintained when
the BufferSize(...) option is not utilized.
Signed-off-by: Ryan Goulding<EMAIL_ADDRESS>

Nice stuff @ryandgoulding ! ..
As soon as the CLA is sorted I'd be happy to merge this in.

Thanks @skalle .  I am working with my management team at Red Hat to get the CLA sorted out.  Will update once we have signed.

@googlebot I signed it!

Hey @ryandgoulding thanks for contributing!.

resolves #64

Happy to contribute, @skalle!  Thank you for the review and merge.


Use flexvolume based notation for raw/qcow2 volumes

This is required by Stage 3 of Virtlet cloud-init metadata generation proposal
The volume handling in Virtlet needs to be consistent so the volumes can be defined like this:
  volumes:
  - name: config
    configMap:
      name: someconfig
  - name: secret
    secret:
      secretName: somesecret
  - name: extra
    flexVolume:
      driver: "virtlet/flexvolume_driver"
      options:
        type: qcow2
        capacity: 2048MiB
  - name: raw
    flexVolume:
      driver: "virtlet/flexvolume_driver"
      options:
        type: raw
        path: /dev/mapper/somevg
  - name: ceph
    flexVolume:
      driver: "virtlet/flexvolume_driver"
      options:
        type: ceph
        monitor: <IP_ADDRESS>:6789
        user: libvirt
        secret: ....
        volume: rbd-test-image
        pool: libvirt-pool

Of these, ceph flexvolume already works like above, but we need raw/qcow2 volumes to work like this, too.

Fixed by #317


starter-kit branch does not compile

Issue type
I'm submitting a ...  (check one with "x")

[*] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Issue description
Current behavior: code does not compile at all  on branch starter-kit

Expected behavior:

Steps to reproduce:

just download fresh version of code and try to run it
Related code:

Failed to compile.

src/app/@core/utils/ripple.service.ts:2:37 - error TS2307: Cannot find module '@angular/material/core'.

2 import { RippleGlobalOptions } from '@angular/material/core';
                                      ~~~~~~~~~~~~~~~~~~~~~~~~
src/app/@theme/theme.module.ts:3:33 - error TS2307: Cannot find module '@angular/material/core'.

3 import { MatRippleModule } from '@angular/material/core';

it is very outdated, this is why


[Bug]: While Saving a New Pipeline, HOP GUI Appends the Previously Opened Pipeline Names

Apache Hop version?
2.9.0
Java version?
11
Operating system
Windows
What happened?
Installation details:-
Download and extract the apache-hop-client-2.9.0.zip file from the official page: https://hop.apache.org/download/
apache-hop-client-2.9.0.zip
Java Version:- 11
Reproduction Steps:-

Open HOP GUI using hop-gui.bat.
Open any existing Pipeline.
Now try to Create a New Pipeline and click the Save button.
While saving a New Pipeline, the Hop GUI tool considers the names of all the opened Pipeline names.

Example:

Test1.hpl file is an existing file that is opened in the HOP GUI tool.
Create a New pipeline and Save it as Test2.hpl. During this process, the HOP GUI will append the previously opened file names along with the new name.

Refer to the attached screenshots:

Issue Priority
Priority: 3
Issue Component
Component: Hop Gui

Cannot reproduce on MacOs, @nadment could you check?

Yes, I can confirm that this bug exists in Windows. I'll try to catch it.


DateTime binding

@tpetry This PR includes the format of DateTime.
When we have DateTime bindings, we will occur the error: Error: Object of class DateTime could not be converted to string.
I have fixed with some unit test cases.

Thanks for the PR. I'll check it later. My original idea was to not do any conversions by myself and only rely on the Laravel ones to execute absolute identical. I have to research why that failed...

@tpetry thanks for your great package. You can see at https://github.com/laravel/framework/blob/6d690edda8c5b0d400a8753def02d9ecd3e98e40/src/Illuminate/Database/Connection.php#L721

Thanks for finding the issue. The fix is now released with version 1.0.2

thanks. it's nice


MultiStreamRecorder with pure audio/remote streams

Just a quick question, I'm implementing a conference call system using PeerJS, and want to record the local and remote objects all simultaneously into a single webm/wav file, I understand the MultiStreamRecorder can offer this for video streams, but don't see much support for just audio?
I have access to all of the MediaStream objects for every peer, but am unsure of the best way of recording these. Any help would be greatly appreciated :)
James

Please try this:
<script src="https://cdn.webrtc-experiment.com/MultiStreamsMixer.js"></script>
<script>
// pass array with single or multiple microphone streams
var audioMixer = new MultiStreamsMixer([firstMic, secondMic]);

var recorder = RecordRTC(audioMixer.getMixedStream(), {
    recorderType: StereoAudioRecorder
});

recorder.startRecording();

btnAddAnotherMic.onload = function() {
    var internal = recorder.getInternalRecorder();

    // pass array with single or multiple microphone streams
    internal.addStreams([anotherMic]);
};
</script>

Thank you for the help, although there isn't a method addStreams for the internal recorder? I think that's only on MultiStreamRecorder?

@jaymo107 @muaz-khan  well, any luck with only audio streams? =)
appendStreams not working for mixer,
https://stackoverflow.com/questions/58166881/webrtc-conference-call-recording-using-recordrtc/58215865#58215865
this solution works, but after disconnect - reconnect audio sounds like x10 speed and garbled?


关于代码是否开源问题

后期训练代码是否开源

Of course, please stay tuned, we will release all code and models soon.

请问调用gpt4进行评测的方式是什么

Hello everyone, we have release our all models and part of code now.


fix: check the list map instead of writing it

Hi Team,
This fixes https://github.com/nutsdb/nutsdb/issues/536.
Please see the example I've provided in https://github.com/nutsdb/nutsdb/issues/536
Kind Regards,
Yudha

I checked our code, finding the API of sorted set have some problem. Do you mind fix it together?

I checked our code, finding the API of sorted set have some problem. Do you mind fix it together?

In tx_zset.go

Updated @bigboss2063. sorry I thought it didn't impact on tx_zset.

Now your project should run normally 😁


Does it still work?

Hi,
I've seen that the app is about 2-3 years with no update. Is it still working?
Cheers,
Chim

From what I've seen, there were some legal issues with WhatsAPI.  The WhatsAPI repo is wiped.

so is there an alternative? @rgallison


Remove runserver.py

This project is already using the Flask-Script extension, which provides a built-in runserver command, so you don't need a separate module implementing it yourself.
Remove runserver.py and update the README to tell developers they can run the app with python manage.py runserver.
This new command also runs the Flask server on port 5000, which is the default port for Flask and a better choice than 5555.

Done!


vendor: Update statedb to v0.1.1

This commit updates the statedb vendored module to v0.1.1. This version contains a few improvements and bug fixes. This commit also updates the reconciler_metrics.go file since there was a minor API change.

@dylandreimerink It's being done in here

Ah, great, closing this PR in that case


MINOR: Remove FanoutIntegrationTest.java

This test has been completely subsumed by the coverage of reset integration test, and hence can be removed.

FAILURE
No test results found.
--none--

I am not sure if ResteIntegrationTest subsumed this. We split one stream but we write it also into an intermediate topic before one branch get's processed. If you think this is sufficient, LGTM.

SUCCESS
8051 tests run, 5 skipped, 0 failed.
--none--

SUCCESS
8051 tests run, 5 skipped, 0 failed.
--none--

I am not sure if ResteIntegrationTest subsumed this. We split one stream but we write it also into an intermediate topic before one branch get's processed. If you think this is sufficient, LGTM.

I think that is sufficient. What do you think is missing from that integration test that is covered in this one?

@guozhangwang Not sure -- just wanted to bring it up to double check.

@dguy could you give a look as well? WDYT about the coverage.

@guozhangwang i think it is ok t remove this integration test. We have unit tests that already cover mapValues sufficiently and we have other tests that cover to and using the same input stream that is mapped etc and sent to a different output topic

Retest this please.

SUCCESS
8056 tests run, 5 skipped, 0 failed.
--none--

SUCCESS
8056 tests run, 5 skipped, 0 failed.
--none--

FAILURE
7949 tests run, 5 skipped, 1 failed.
--none--

Merged to trunk.


Make CosmosClient mockable

Is your feature request related to a problem? Please describe.
Currently, we can't mock the CosmosClient class, which is essential for our unit tests. The previous version provided an IDocumentClient interface which we were able to use.
Describe the solution you'd like
Provide an interface for the CosmosClient that we can use to mock the client.
Describe alternatives you've considered
We considered wrapping the CosmosClient in another class, but that is too much work and prone to breaking when the CosmosClient is updated.
Additional context
An example of how we would like to use this (we're using FakeItEasy) is below:
var fakeCosmosClient = A.Fake<ICosmosClient>();
var fakeDatabases = A.Fake<CosmosDatabases>();
A.CallTo(() => fakeCosmosClient.Databases).Returns(fakeDatabases);

var someClass = new SomeClass(fakeCosmosClient);
await someClass.InitDatabaseAsync();

A.CallTo(() => fakeDatabases.CreateDatabaseIfNotExistsAsync(
               "TheDatabaseToCreate", A<int>._, A<CosmosRequestOptions>._, A<CancellationToken>._)).MustHaveHappenedOnceExactly();

@NateB2 CosmosDatabases is an abstract class and is fully mockable.
In practice most of the application will be centered around CosmosContainter which is an abstract class and fully mockable.

So what you're saying is that instead of passing the CosmosClient object to the classes, I should be passing the CosmosDatabases object, like this?
var fakeDatabases = A.Fake<CosmosDatabases>();

var someClass = new SomeClass(fakeDatabases);
await someClass.InitDatabaseAsync();

A.CallTo(() => fakeDatabases.CreateDatabaseIfNotExistsAsync(
               "TheDatabaseToCreate", A<int>._, A<CosmosRequestOptions>._, A<CancellationToken>._)).MustHaveHappenedOnceExactly();

And in the actual implementation, it would be something like this?
var client = new CosmosClient(endpoint, accountkey);
var someClass = new SomeClass(client.Databases);
await someClass.InitDatabaseAsync();

I updated my unit tests and was able to get everything working, but it would be great to have an example or two of unit tests that use this new pattern, either in the readme or as a sample, as it is quite different than the 2.x SDK version, and the 3.0 SDK unit tests I skimmed appeared to use a mock of the internal constructors which are not accessible to us. It would be really helpful, especially to those of us migrating from 2.x.

@NateB2 we will work on more samples once we get closer to GA and the contract stop changing. Is there any reason to not pass the CosmosContainer around?

That would be great - thanks!  Overall, the new SDK is definitely easier to use and looks cleaner - can't wait until it reaches GA.
The class I'm writing now is responsible for setting up Cosmos databases and containers. I want to be able to write unit tests against that class to make sure the databases/containers are named and configured appropriately.

@j82w So how to do purpose we register the cosmos container in the DI container?
Currently we're registering a singleton instance of the CosmosClient with DI, and then injecting that into services.


fix: Single speaker model occurs error

Hi! Thank you for your project!
I found an error while using it with single speaker model. When n_speakers = 1, it occurs error: AttributeError: 'SynthesizerTrn' object has no attribute 'emb_g'
I modified if n_speakers > 1: to if n_speakers >= 1: then it works.

@CjangCjengh Hi have you had time to consider this yet?


LRTS support for setting up a message to send and transmitting a GET handle

Original issue: https://charm.cs.illinois.edu/redmine/issues/68

On platforms that use GET-based RDMA for large messages, there are various circumstances where it is useful to be able to set up a message for transmission, and get a handle that an eventual recipient can be told to retrieve. Use cases generally involved large messages. Interacting use cases include constrained receiver-side memory, and message delivery to migrated objects.

Original date: 2013-09-17 20:34:25

Not on the release radar, and no implementation on the horizon within the time remaining.

Original date: 2016-12-22 23:27:22

Looks like the code for #1234 essentially addresses this desire. Try it out in CharmLU, perhaps.

Original date: 2017-01-26 18:33:07

Is this solved by #1234?

Original date: 2017-04-22 15:27:24

I think this issue is covered by the combination of the separate sender-side and receiver-side issues.


[Macros] Allow extension macros to suppress conformances that are stated in the original source.

If an extension macro can introduce protocol conformances, macro expansion will check which of those protocols already have a stated conformance in the original source. The protocols that don't will be passed as arguments to extension macro expansion, indicating to the macro that it should only add conformances to those protocols.
Resolves: rdar://111464321

https://github.com/apple/swift-syntax/pull/1871
@swift-ci please smoke test

@swift-ci please build toolchain

https://github.com/apple/swift-syntax/pull/1871
@swift-ci please build toolchain

https://github.com/apple/swift-syntax/pull/1871
@swift-ci please smoke test

https://github.com/apple/swift-syntax/pull/1871
@swift-ci please build toolchain


Leading auto annotation model doesnt work

Hello :slightly_smiling_face:, I am trying to use auto-labeling, but i cant figure out why it doesnt work. I've uplaoded some images, labeled few of them. Quickstart with an example ML backend is done, so http://localhost:9090/ works. model is added, but when i click start training nothing happens.
I couldnt inf any similar problems in the internet

hi i add similar issues with, in my current rca its that the
def _setup():
    data = request.json
    logger.debug(data)
    project = data.get('project')
    schema = data.get('schema')
    force_reload = data.get('force_reload', False)
    hostname = data.get('hostname', '')  # host name for uploaded files and building urls
    access_token = data.get('access_token', '')  # user access token to retrieve data
    model = _manager.fetch(project, schema, force_reload, hostname=hostname, access_token=access_token)
    logger.debug('Fetch model version: {}'.format(model.model_version))
    return jsonify({'model_version': model.model_version})

does not find any job in the jobmanager.
hard dirty hacking code like
model = _manager.fetch(project, schema, force_reload, hostname=hostname, access_token=access_token,model_version="INITIAL") solved the issue but then the model is always staying INITIALofc.


Add curation statements for the eLife articles tagged on Hypothes.is with "summary" and user "public_reviews"

TO get a JSON payload listing all eLife summaries:
curl "https://api.hypothes.is/api/search?user=public_reviews;tag=Summary"

To get a uri and hypothesis id:
curl "https://api.hypothes.is/api/search?user=public_reviews;tag=Summary" | jq '.rows | .[] | {id: .id, uri: .uri}' | sed -e 's/uri.*content\//articleId":"/'

/Users/linakinduryte/sciety/elife-author-responses-from-hypothesis-page-one.txt

elife-author-responses-from-hypothesis-page-one.txt

elife-curation-statement-evaluation-locators-page-one.txt

Reference for API calls:
https://h.readthedocs.io/en/latest/api-reference/v1/#tag/annotations/paths/~1search/get


How can I eval myself dataset

I have added Kitti Dataset to mmdetection. But how can i eval pretrained model. I found the code only reference coco_eval. What should i modify? Thank you for reply.

@shuoshuoa We recommend you to convert the KITTI annotation to COCO style. In that case, you can train and evaluate the model in this codebase conveniently. And then revert the results to the format KITTI needed and upload it to the official website.
You can also add your evaluation tools into the code directly. Just add another eval choice, such as 'kitti'.

Thanks very much. i got it!


Failed to connect to the Wayland display

It looks like you are using Ubuntu 20.04, but did you launch Wayland compositors like Weston?

I'll close the issue as no responses.


Opening VSCODE from CLI Resets Configuration

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.84.2
OS Version: Ubuntu 22.04 LTS

The Problem:
I installed Konsole Terminal and whenever I open vscode from CLI code .
VSCode loses all its configuration. Theme, font-family, font-size, icons, etc...
obs: It works if I open from command line using Tilix Terminal.
obs2: I also tried to re-enable Sync, it asks me to loging again and instead of updating the currently vscode with the synced configuration, it opens a random project I've worked in the past.
This happens all the time. It asks if I trust the authors of the project (even if I clicked YES before).
Steps to Reproduce:

Open VSCode from command line code . or code /my/project/path

I'm looking for help to solve this or at least understand what and why this is happening.

Still don't know the reason that caused the problem.
But installing the terminal from apt install konsole instead of from Ubuntu Software App solved the problem.


feat: add implementation for TopsortClient

wip

Please update README!
Add a test for auction or event that verifies that the url in the call made is stripped of a trailing slash


Added "Shared Path" localisation to en-AU

Shared path is the official and legal term in Australia for a path where cyclists and pedestrians can both legally travel on the same path together

I would suggest that "shared path" and "shared use path" should also be in included in the terms for the Cycle & Foot Path preset. The term is definitely heavily used in NZ and AU, but are also used worldwide: https://en.wikipedia.org/wiki/Shared_use_path

@TLDuhamel Sounds good, I added the terms 👍


Parallelize finding uncompressable strings.

I'm pretty new to go so I'm open to different approaches.

Maybe make concurrency a parameter with default being MAXPROCS?
Also maybe (need to benchmark) MAXPROCS - 1? This way the main goroutine merges the tables and the rest compress.

Added a flag.


Please add support for WSTrust

Per comments and replies in issue #476, I open this issue to request for WSTrust. While I knew that resources are limited and that the demands for a .Net core version for WSTrust is not as high as other passive profile use cases, this is really the last thing I need in order to port my big web application to Asp.Net Core 😄

@thuannguy i put this in the vNext milestone.
It is not our highest priority, can you let us know why you need it?
If others in the community needs this, then that might bump the priority.
Are you looking for creating WsTrust messages or just consuming?

@brentschmaltz Thank you :smile: In fact, I do all the things related to WSTrust messages: both client applications and WCF services that use WSTrust to do security stuff, and also an STS (similar to ADFS) that issue tokens using WSTrust.

@brentschmaltz @thuannguy Hello! finally, there is a WSTrust / STS support for .net core ?

I wonder when .NET framework is done, will the team developers be redistributed to other teams to speed up Core support for missing libraries, e.g. this one 😄

For reasons for why I need this:

I have many big enterprise applications that rely on WSTrust and SAML stacks. I believe I'm not the only one. OAuth/OIDC are good for "modern" applications, but those enterprise stacks won't go away anytime soon.
Some features I need won't be supported in .NET framework. When I asked for adding support for the features to the .NET framework, the answer is usually "why I need it", and "we won't add those features to .NET framework but instead will add missing features from .NET framework to core". That makes sense, except point (3) below
When I request for new features adding to core, the reply is usually that "we don't have enough resources, and the features are not high priority". As a developer, I can understand that every team has limited resources. The only problem is that I'm stuck 😢

@thuannguy WSTrust is a large spec: http://docs.oasis-open.org/ws-sx/ws-trust/200512/ws-trust-1.3-os.html
I hear you, you need it we used to have it in Desktop....
Can you express a set key features such as:

Version 1.3
RST/R without secondary parameters
Do we need BinarySecrets ?
What Bindings? Issuance?
etc....

@brentschmaltz My product offers all WS-Trust features that ADFS has to offer, plus a few more custom ones, so I guess I will need a whole lot of the spec.

Yes, 1.3. We also need one aspect of 1.4, but I don't remember exactly what it is. Maybe something that has to do with OnBehalfOf or ActAs.
I never heard about secondary parameters before, so I probably don't need it.
We can live without BinarySecrets.
Currently we are supporting Certificate binding, IssuedToken, UserName, Windows, Kerberos, and LibertySimpleSoapBinding (a custom one). The current .Net framework gives us enough flexibility to create all those bindings based on the Binding base class.
Honestly, I'm not competent enough to know what exact features in the big WS-Trust spec that are actually used by my code. I would be super happy if I have all the above 😋

@thuannguy thanks, this is a big help in scoping. As you see WS-Trust is a big spec.
1.4 did introduce OBO and ActAs.
Couple of additional scoping questions:

I assume you would need full RST/RSTR (inbound / outbound) processing.
When you wrote: Binding class, are you speaking to WCF?
Are you just communicating with ADFS?
Could you prioritize the different bindings?
i.   Certificate
ii.  IssuedToken
iii. UserName
iv.  Windows
v.   Kerberos
vi.  Extensibility (with this you could do anything).

@brentschmaltz  hi

Yes, you are right.
One example for it is https://github.com/IdentityModel/Thinktecture.IdentityModel.40/blob/master/IdentityModel/Thinktecture.IdentityModel/WSTrust/WSTrustBindingBase.cs
Nope. My product can do all ADFS can and more, e.g. eID profiles based on WS-Trust such as OIO Identity-based Web Services (OIOIDWS) which we are able to support .NET framework by defining a CustomBinding. Anyway, my product can federate with ADFS, or it can replace ADFS totally.
I would say i, ii, iii, and iv. I can leave without v and vi.

@thuannguy that is a WCF binding, so you need to craft up a WSTrust message and parse the response.
If we can scope to i., ii., iii. We can help.
Can you describe a bit about custom binding? Do you mean Custom WSTrust binding?
It looks like Thinktecture supports trust 1.3 and 2005 (which was an internal microsoft version before the spec was ratified).

One example for a custom binding is:
    public class LibertySimpleSoapBinding : CustomBinding
    {
        private SigningAlgorithm signingAlgorithm;
        public LibertySimpleSoapBinding(SigningAlgorithm signingAlgorithm)
        {
            this.signingAlgorithm = signingAlgorithm;
        }

        public override string Scheme
        {
            get
            {
                TransportBindingElement element = this.CreateBindingElements().Find<TransportBindingElement>();

                if (element == null)
                {
                    return string.Empty;
                }

                return element.Scheme;
            }
        }

        public override BindingElementCollection CreateBindingElements()
        {
            var elements = new BindingElementCollection();

            var textmessageEncoding = CreateMessageEncodingBindingElement();
            var messageSecurity = CreateSecurityBindingElement(this.signingAlgorithm);

            elements.Add(messageSecurity);
            elements.Add(textmessageEncoding);
            elements.Add(new HttpsTransportBindingElement());
            return elements.Clone();
        }

        private static AsymmetricSecurityBindingElement CreateSecurityBindingElement(SigningAlgorithm signingAlgorithm)
        {
            MessageSecurityVersion version =
                MessageSecurityVersion
                    .WSSecurity10WSTrust13WSSecureConversation13WSSecurityPolicy12BasicSecurityProfile10;

            var sec = SecurityBindingElement.CreateMutualCertificateBindingElement(version) as AsymmetricSecurityBindingElement;
            if (signingAlgorithm == SigningAlgorithm.Sha256)
                sec.DefaultAlgorithmSuite = SecurityAlgorithmSuite.Basic128Sha256;
            sec.MessageProtectionOrder = MessageProtectionOrder.EncryptBeforeSign;
            return sec;
        }

        private static MessageEncodingBindingElement CreateMessageEncodingBindingElement()
        {
            return new CustomTextMessageBindingElement(
                messageEncoderFactory => new CustomTextMessageEncoderFactory(messageEncoderFactory));
        }
    }

AFAICT, the WSTrust binding is also a form of a custom binding 😄 IIRC, originially .NET had it, then it was removed in version 4.0 (or 4.5?) so Thinktecture had to create that WSTrustBinding.

@thuannguy yeah those bindings were removed when WIF was integrated into .NET 4.0.
In terms of WCF binding, are you planning on using WCF?
The WSTrust message is part of an xml message and is carried in the body. The binding you are showing above is setting the characteristics of the message properties.
If you are using WCF, we would need a way to embed the WSTrust message into the Soap envelop before it is signed.
WIF used to do that but this library doesn't have much knowledge of WCF.

Ah yes, I will need to use WCF. Sorry for not mentioning it. I have used the two together for my product since day one so in my mind they are just one thing (which is definitely not the case).

@thuannguy ah, we don't have plans for full blown WCF in Core. This library is focusing on .NET Core usage. Are you using Core?

Yes, my plan is to migrate to core. It seems to me that some folks are asking for more WCF support in Core. My naive hope was that if in 18 months or 2 years Core have enough WSTrust and WCF supports, that will be a big boost for ones who need to maintain enterprise applications like me.

@thuannguy that is still up in the air. I will leave this in the 5.x milestone for now.

@brentschmaltz  whatever it takes! At least there is a chance I will get it out of 14000605 possibilities 😈  Thank you and happy weekend 😄

This will be very good to have for large enterprise. +1

@thuannguy 	@kabronkline @Mahe85 we are going to move forward on this. The goal is to make it possible for a WCF Client to easily make a WsTrust from a .net Core app.

@thuannguy  @kabronkline @Mahe85 we are making some progress on this. I marked it for 5.6.1 release. The topic branch is brentsch/wstrust.

@brentschmaltz Are you able to provide an estimate as to when 5.6.1 will be in a testable form at least? I have a project with dependency on both legacy WCF service calls via WSTrust and .NET Core. Thank you!

@ndneubauer current POR is for end of November for a preview.
Hopefully the preview is a short stop before GA.

@brentschmaltz I've looked in your topic branch but don't see support for wstrustchannel, it that pending or would it not be included in initial WSTrust support?

@johnthcall It's pending.
We are focused on SignedHttpRequest, we will get back to WsTrustChannel in about a week

@johnthcall this work is currently on topic branch brentsch/wstrust

@thuannguy @johnthcall @kabronkline @Mahe85 @ndneubauer we are closing on this for a preview WCF wsfederation binding release.
Now is the time to have a look and see if this feature meets your needs.

This would come in handy to glue our newer stuff to legacy stuff that relies on ADFS integration, are you guys planning to release it any time soon?

Since MSFT is not responding, posting what I found myself, for other developers' sake:
The changes in brentsch/wstrust topic branch have been merged; WsTrust functionality is available on NuGet as Microsoft.IdentityModel.Protocols.WsTrust (package version 6.7.2-preview-10803222715 and newer).
WS2007HttpBinding is available in System.ServiceModel.Http (package version 4.8.0-preview3.20412 and newer). See
WCF issue #4110 for more info.
WSTrustChannelSecurityTokenProvider featured in the topic branch is available in System.ServiceModel.Federation (package version 4.8.0-preview3.20412.3 or newer).

@brentschmaltz thank you for implementing the feature. I and my team will look at this next time when we evaluate if we are able to migrate our products to .NET core (we do that like once a year). Please feel free to close this request if other requesters find that the implementation meets their needs.

how does one make requests to get a token?
there is no RequestSecurityToken and WSTrustChannel class

found my answer
https://github.com/dotnet/wcf/issues/4542

@MariaCobretti we are added WSTrustChannel and WSTrustChannelFactory to WCF see: https://github.com/dotnet/wcf

you mean you are currently working on it? cause I certainly don't see it right now

you mean you are currently working on it? cause I certainly don't see it right now

bump. :)

@janniksam the code has been added to the WCF project a preview release is available.

@brentschmaltz Per https://github.com/dotnet/wcf/issues/4542, I thought code is released already (aka not in preview anymore). At least System.ServiceModel.XXX <IP_ADDRESS> works for me. Could you please elaborate? Is there still another preview release that has even more out of the box support for WSTrust?

@brentschmaltz Per dotnet/wcf#4542, I thought code is released already (aka not in preview anymore). At least System.ServiceModel.XXX <IP_ADDRESS> works for me. Could you please elaborate? Is there still another preview release that has even more out of the box support for WSTrust?

I guess you mean the preview version 4.10.0-preview1.22261.2 which has WSTrustChannelFactory added.
https://github.com/dotnet/wcf/commit/ab9b3c1cb00f558dcd6ac6f3b02663ace5e25750#diff-5154bdab4d937a2d8e7c3553d2a8df7ac2d6231d0d76bbca1c87f4f9e343dabd


Parameter annotations in AST are removed by visitor

I read that you're currently on holiday, I mainly just wanted to create these issues for tracking so I don't forget about them - please do enjoy your holiday before anything else, these issues are probably as unimportant as it gets ☺
While debugging the issue that led to #93, I noticed that ImportVisitor.register_function_annotations would remove the annotation fields from all function parameters:
https://github.com/snok/flake8-type-checking/blob/03e868ce7da81ece39373e622c1ea421662e9b69/flake8_type_checking/checker.py#L676-L678
To illustrate this, one can set a breakpoint before and after this statement, dumping the AST (node) and comparing:
https://github.com/snok/flake8-type-checking/blob/03e868ce7da81ece39373e622c1ea421662e9b69/flake8_type_checking/checker.py#L755
--- tree_orig   2022-07-08 23:36:55.687419100 +0200
+++ tree_new    2022-07-08 23:37:08.295574500 +0200
@@ -5,9 +5,7 @@
       args=arguments(
         posonlyargs=[],
         args=[
-          arg(
-            arg='x',
-            annotation=Name(id='int', ctx=Load()))],
+          arg(arg='x')],
         kwonlyargs=[],
         kw_defaults=[],
         defaults=[]),

From what I understand this is required for some checks, and while I unfortunately don't have a concrete example for it, I believe this could break other plugins running afterwards that rely on these annotations, since flake8 reuses the AST for all plugins (at least the version I'm using, 4.0.1, does).
Looking at other issues, something similar seems to have happened in #90, both possibly as a side effect of #89 (?) which removed the copy operation that allowed the code to freely mutate the AST without affecting other flake8 plugins.
I tried a few things in an attempt to make it work and create a PR with a fix that doesn't involve copying the entire AST, but sadly I couldn't manage it with my (very limited) knowledge of how the ast module works 😅

Hey @shiftinv! 🙂
Yes you're right, it's a bit of a weird problem to fix. The plugin needs that functionality (the removed annotations), the ast tree shouldn't be mutated to break other plugins, and copying the tree is slow and can raise RecursionErrors in large trees.
I was hoping that v2.0.2 would fix this, by substituting ast.NodeTransformer with ast.NodeVisitor (#91). Would you be able to test that version to see if the issue persists?

Hiya!
Yeah, it does seem like quite a tricky issue. It's definitely understandable that copying the tree isn't really viable, I suppose there's a good reason as to why flake8 shares the ast between plugins.
The tests above were done in v2.0.2, and while the switch to ast.NodeVisitor fixed a large portion of the mutation issue, the removal of annotation fields unfortunately still persists.

Ok good to know 👍 I'll take another look at this in a bit then. Thanks again 🙂

Fixed by #104 (thanks!).


Add symfony console - Create Upgrade Command

Questions
Answers

Description?
Add symfony console - Create Upgrade Command

Type?
new feature

BC breaks?
yes / no

Deprecations?
yes / no

Fixed ticket?
Fixes #{issue URL here}, Fixes #{another issue URL here}

Sponsor company
Your company or customer's name goes here (if applicable).

How to test?
Indicate how to verify that this change works as expected.

This PR should target a new major version, as the entrypoint changes
Do not forget to change the readme accordingly


miss output_dir in convert_only

miss output_dir in convert_only in demo_page.py line 219
save_path = f'{output_dir}/output.wav'

new version of gradio Audio component without info attribution,
if use gradio==4.19.2 the audio support multi sources ['upload', 'microphone'] which can be friendly to use user tone color
for the Error Related to Silero I reference this page https://github.com/myshell-ai/OpenVoice/blob/main/docs/QA.md#issues-with-installation

Just fixed the issue with the undefined output_dir. Thanks for helping me pinpoint the gradio version for this application! Appreciate the attention to detail.


osv-scanner: Callgraph analysis to help prioritize matched vulnerabilities

Meta-issue to track the feature of doing callgraph analysis as part of vulnerability scanning to help reduce false positives (or at least help prioritize vulnerabilities). Vulnerability databases are starting to include  metadata about which functions need to be called to actually be considered vulnerable (GHSA, Go at the very least).
Related idea from @jonathanmetzman: We can even go further with this analysis: We can completely disable the vulnerable code path to completely remove any possibly of the vulnerability being reached.
Current open issues:

Go: google/osv-scanner#10

Closing this as a duplicate of #476


how to enable all the debug, for example : LOG DLOG VLOG PLOG DPLOG

@serialx
I want to enable all the debug, what I should do?
thanks.

how to enable NDEBUG when I compile the code?

set(CMAKE_C_FLAGS_RELEASE "-DNDEBUG")  can resolve my question, thanks

please close the issue, thanks again.

@serialx
how to enable NDEBUG when I compile the code?
can you help me.
thanks

I do not know the specifics about Chromium logging infrastructure. Please consult Chromium documents and mailing list.


Got unauthorized when executing scheduleJob with REST action on security mode

🐞 Bug Report
Affected Services [REQUIRED]

 The issue is located in: support-cron-scheduler
Is this a regression?

 No
Description and Minimal Reproduction [REQUIRED]

Run command make run keeper mqtt-bus postgres arm64 under compose-build to deploy service
Generate JWT token by command make get-token
Create job with REST action

[
   {
      "scheduleJob":{
         "name":"job_1",
         "definition":{
            "type":"INTERVAL",
            "interval":"5s",
            "startTimestamp":{{startTime}},
            "endTimestamp":{{endTime}}
         },
         "actions":[
            {
               "type":"REST",
               "address": "http://edgex-core-data:59880/api/v3/event/age/0",
               "method": "DELETE"
            }
         ],
         "adminState":"UNLOCKED"
      },
      "apiVersion":"v3"
   }
]

Wait until the job was triggered.

🔥 Exception or Error

level=DEBUG ts=2024-10-07T03:30:31.424361618Z app=support-cron-scheduler source=gocron.go:102 msg="Failed to execute the rest action: request failed, status code: 401, err: {\"message\":\"Unauthorized\"}\n"
level=DEBUG ts=2024-10-07T03:30:31.432631753Z app=support-cron-scheduler source=manager.go:312 msg="A new schedule action record with type: REST and status: FAILED was added for job: job_1, record ID: b30b8179-495f-423b-ba5d-a449405b027f, action error: request failed, status code: 401, err: {\"message\":\"Unauthorized\"}\n, Correlation-ID: 00637a9f-7868-49c3-9056-6e256f58a1c6"

🌍  Your Environment
Deployment Environment: Ubuntu2204/arm64
**EdgeX Version [REQUIRED]:**Main
Anything else relevant?

@cherrycl to use RESTAction for EdgeX internal API, you have to set injectEdgeXAuth = true
Please see the RESTAction schema in the API docs
https://docs.edgexfoundry.org/3.2/api/support/Ch-APISupportCronScheduler/

Close with invalid issue.


Handle downstream impacts to union's behavioral changes.

Is your feature request related to a problem or challenge?
With this upstream change, an existing union() API had a behavioral change. This API is used to construct the UNION logical plan. Previously, it had been constructing the UNION plan node and performing type coercion. After the upstream change, it no longer perform the type coercion at logical plan construction (and instead relies upon a later logical plan optimizer pass).
This upstream change does not cause any failures in the upstream datafusion tests. However, for those constructing their own logical plans with UNION it does have significant downstream impacts. Explicitly:

we have a UNION logical plan construction using union() upstream API
we consume the schema & expr from the union, when deciding how to construct other logical plan nodes (e.g. sort, grouping, aggregates, limits)
then afterwards => we hand the logical plan to datafusion for optimization (including type coercion)

When the upstream change removed the UNION type coercion from step 1 above, our logical plan construction code (step 2) started creating incorrect logical plans.
Describe the solution you'd like
Update the union() API with how to handle the changed behavior if the user still requires UNION type coercion at logical plan construction. Something like:
let union_schema = coerce_union_schema(vec![prev, next])?;
let prev = coerce_plan_expr_for_schema(prev, &union_schema)?;
let next = coerce_plan_expr_for_schema(next, &union_schema)?;
union(prev, next)

The above code relies upon the already public coerce_plan_expr_for_schema. The coerce_union_schemaI is not yet public, therefore we recommend making it public.
Describe alternatives you've considered
The original change was put in by @jonahgao , whom may have some alternative ideas?
Additional context
We have made our own public (patched) version of the coerce_union_schema as a temporary measure to fix the issue, and can confirm it's sufficiently. Also open to other ideas.

Sorry for introducing this behavior change. There are two reasons we can't perform coercion when building unions.

We can't get a correct common schema without performing type coercion for expressions, just like the case in #11742.
Wildcard expansion was moved to the analyzer recently. When union  the two following projections, the number of their expressions will be different, resulting in an inability to perform type coercion.

create table t1(a int, b int);
create table t2(c int, d int);
select * from t1 union select c, d from t2;

I think it's reasonable to make coerce_union_schema public, allowing users to coerce unions if they are not affected by the aforementioned scenarios.
Another potential solution might be to manually run the necessary Analyzer rules, such as ExpandWildcardRule and TypeCoercion, after step 1.

Thank you for the explanation
I think for our use (which is a planner for the InfluxQL query language) we don't need to handle wildcards
I do think it would be interesting to try calling analyze rather than the lower level type coercion
I believe @wiedld  said she tried this and the additional coercion performed by TypeCoercion caused some other problem

Thank you @jonahgao . Agreed that the change was needed.
I was hoping for an update to the docs on how to handle the change (if the user needs to) when using the union() API. Such as adding an explanation & the example code snippet in the method docs.
If the user needs the exact same logical plan as before the change, then this is roughly how we did it:
let union_schema = coerce_union_schema(vec![prev, next])?;
let prev = coerce_plan_expr_for_schema(prev, &union_schema)?;
let next = coerce_plan_expr_for_schema(next, &union_schema)?;
union(prev, next)

If the user is ok with added CAST nodes (including timezone cast), then they could use the analyzers:
let mut plan = union(prev, next)?;
let wildcard_rewriter = ExpandWildcardRule::new();
plan = wildcard_rewriter.analyze(plan, context.inner().copied_config().options())?;
let type_rewriter = TypeCoercion::new();
type_rewriter.analyze(plan, context.inner().copied_config().options())

@alamb -- we have passing InfluxQL e2es with the second (analyzer) approach, diffing a lot of added CAST nodes. I'm not sure about the use case for other users whom build their own logical plans.

I can make this change. Just wanted input (such as the wildcard expansion explanation) before doing so. Are we good for this updated doc change? Or should we do anything else?

Thank you @wiedld 👍 .
I think we can remind users about wildcard expansion in the document.
Another thing is that I wonder whether it is necessary to expose coerce_union, allowing users to try using it first, as it is somewhat a high-level API.

take


Implement system to track successes & errors at each stage of workflow, at the file & tile level

Throughout the workflow, it would be helpful to integrate logged checks for files that error from input through staging, from staging through merging (if using the Ray workflow), and from merging through the rasterization step. Kastan noted that using the ray workflow resulted in approximately 2000 out of approximately 8 million files failing to process correctly.
To start, we should implement the minimum viable product (MVP) as a comparison of the filepaths at the conclusion of the staging step with the filepaths at the conclusion of the rasterization step. The initial filepaths list can pulled from the staged directory, or from the filepaths in staging_summary.csv.
Ideally, we will eventually implement more rigorous checks for all polygon vectors that are present in input files that error during staging and are therefore not fed into the merging or rasterization steps. However, this is more complex than the MVP, considering the following:

deduplication of polygons can occur during staging, rasterization, web tiling, etc. based on the user's config
polygons that cross tile boundaries are documented in all tiles in which a portion of the polygon is present
the input files may contain no polygons whatsoever
during staging, the data are in the form of polygons, but after rasterization, they are in the form of grid cells, which makes it impossible to track the files via file sizes
the CRS may need to be converted during staging, which changes polygon attributes such as area

Robyn noted that an expansion beyond the MVP might be best executed by using the footprints to determine if we expect a polygon within each file's bounds, and comparing the footprints to their respective processed files using an overlay method from geopandas.

Instead of relying on logging, we might want to implement a system that records the status of each file and all its tiles through workflow stages (input, staging, merging, rasterization). It should automatically summarize successes and failures.


Sync latest master to cpo may 14

Sync a few commits from master that did not make it here yet

@gonzolino @zetaab @wenlxie @databus23 Can you please verify if the changes (that you made in kubernetes/kubernetes master) that i am copying over to this repository are good?

/assign @hogepodge
/assign @dklyle

@dims  My fix is ok. Thanks

/approve

/approve


Ockam TCP Transport using smoltcp

https://github.com/smoltcp-rs/smoltcp

If you would like someone to help / mentor / pair program with you as you work on your first Ockam issue, please leave a comment on this discussion.

Indeed, this a great starting point. I guess, the next step is how do we layer ockam-transport on top of such an example? Do we have any examples for porting ockam onto a different transport layer?

We'll need to write a new transport crate - maybe we call it ockam_transport_tcp_ smoltcp
ockam_transport_tcp is a good reference for a transport implementation.
All the crates are here, ockam_transport_websocket is a good reference too.

Okay, I finally managed to get down to cloning the repo, today. I'm still trying to wrap my head around a couple of things, so I could be wrong here but here's what I've gathered.
To build the ockam-transport-smoltcp impl while retaining the existing api (more or less), we'll need 3 things

no_std ockam-node impl:

guess, we have a barebones impl for this i.e. a global executor to poll and execute futures.
For the absolute simplest impl, I guess we can simply collect all futures into a single async block and pass them to the executor.
And then use another (maybe interrupt driven) mechanism to register with a waker for notifications.

high-level ockam-transport layer wrapper:

This layer just spawns 3 ockam-workers - TCPRouter, TcpSendWorker, TcpRecvProcessor
I presume this layer doesn’t need to change much i.e. we'll just need new names for the types (maybe)
Question here - what are inlets and portals actually used for i.e. are they required to establish TCP connections (i.e. connect, listen, send, receive)?

replace tokio async-wrappers used to instantiate tcpsockets/streams with a smoltcp abstraction:

the high-level ockam-transport layer calls into tokio to get a TCPstream and send/receive data.
we'll need a similar api around smoltcp

Does this make sense i.e. is my understanding correct or am I missing something?
Quick note on testing during development: smoltcp can run in a no_std desktop environment as a user-space application, we can probably use this example (which uses TapInterfaces) to start-with, before we move to an actual embedded-device (to make it easier).

another question: for ockam-no-std nodes, is there a plan to build on the existing ockam_node_no_std impl which uses the executor crate or is that just a placeholder. The reason I ask is because it uses heap allocation and dynamic dispatch (via the alloc dependency) - both of which may not be available in embedded environments.

no_std ockam-node impl:

guess, we have a barebones impl for this i.e. a global executor to poll and execute futures.
For the absolute simplest impl, I guess we can simply collect all futures into a single async block and pass them to the executor.
And then use another (maybe interrupt driven) mechanism to register with a waker for notifications.

I'm busy putting the finishing touches on the Ockam no_std port.
Basically it ends up looking something like this:
https://github.com/ockam-network/ockam/blob/85030a8db437b8a565d7c629d758385f304c6e56/implementations/rust/ockam/ockam_node/src/lib.rs#L23-L26
You can follow the PR progress here: https://github.com/ockam-network/ockam/pull/1831
There's also a second PR in progress which drops the requirement for scheduling blocking functions in environments without pre-emptive multitasking: https://github.com/ockam-network/ockam/pull/1832
Please ask away if you run into any issues trying these out, I'm still polishing some of the rougher edges.

is there a plan to build on the existing ockam_node_no_std impl which uses the executor crate or is that just a placeholder. The reason I ask is because executor uses heap allocation and dynamic dispatch (via the alloc dependency) - both of which may not be available in embedded environments.

executor was just a placeholder.
For embedded targets we're currently using our own executor which supports most no_std + alloc configurations.
Once we have more data on how Ockam performs on embedded hardware we'll be in a good place to tackle a pure no_std environment for zero-alloc targets next.

high-level ockam-transport layer wrapper:

This layer just spawns 3 ockam-workers - TCPRouter, TcpSendWorker, TcpRecvProcessor
I presume this layer doesn’t need to change much i.e. we'll just need new names for the types (maybe)
Question here - what are inlets and portals actually used for i.e. are they required to establish TCP connections (i.e. connect, listen, send, receive)?

Paging @SanjoDeundiak 📟

replace tokio async-wrappers used to instantiate tcpsockets/streams with a smoltcp abstraction:
- the high-level ockam-transport layer calls into tokio to get a TCPstream and send/receive data.
- we'll need a similar api around smoltcp

Worth a look:
https://crates.io/crates/embedded-nal

Does this make sense i.e. is my understanding correct or am I missing something?

Perfect sense, great questions, thank you! :-)

Quick note on testing during development: smoltcp can run in a no_std desktop environment as a user-space application, we can probably use this example (which uses TapInterfaces) to start-with, before we move to an actual embedded-device (to make it easier).

Nice!

Hey @nihalpasham ! Inlets and outlets are additional features, which we probably want to have in the future, but don't think about them for first implementation. They are not necessary to make basic connections/exchange messages.

For anyone tracking this issue. no-std support landed last month, we're working towards an introductory guide, in the meantime checkout the examples here:
https://github.com/ockam-network/ockam/tree/develop/implementations/rust/ockam/ockam_examples/example_projects/no_std


Add Gameday Data

Are you planning to add Gameday data via MLBAM's traditional XML feeds? Or their Stats API?

I was probably going to use the GitHub packages that have already been
developed for that purpose. Would rather reuse code and consolidate good
existing solutions in the community.
On Mon, Jun 17, 2019, 11:53 AM Albert Lyu<EMAIL_ADDRESS>wrote:

Are you planning to add Gameday data via MLBAM's traditional XML feeds? Or
their Stats API?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/droher/boxball/issues/39?email_source=notifications&email_token=AELMKFCQJTUTKIAY6Z3FNLTP26XNZA5CNFSM4HYRUZWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3TVBQ#issuecomment-502741638,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELMKFA7KV5FJCAGK4RIU3DP26XNZANCNFSM4HYRUZWA
.

I've decided not to add any more data and instead focus on data integration in a different, yet-to-be-released project.


Generator text does not match functionality for alfresco:amp "Local AMP" option.

Overview of Issue
The generator text does not match functionality for alfresco:amp "Local AMP" option. The generator itself looks for amps and amps_share in the "customizations" folder. However, within the generator, the following text is shown:

This generator will create/install amps into your project files:
Source AMP: We'll create a new source code projects that you can add code/config to
Local AMP: Installs an amp file from ./amps or ./amps_share into this project
Remote AMP: Installs an amp file from a reachable Maven repository into this project
Common AMP: Offers to install common amps such as JavaScript Console and Support Tools

Additionally, the amps and amps_share folders are created at the base of the project structure, rather than under the customizations folder.
Steps to reproduce the problem

Create a new project using "yo alfresco"
Navigate to the root of the project
Run "yo alfresco:amp"
View the text for the "Local AMP" option

Expected behavior
Text shown in generator should say:

Local AMP: Installs an amp file from ./customizations/amps or ./customizations/amps_share into this project

Additionally, the amps and amps_share folders should be automatically created under the customizations folder.
Actual behavior
Text in generator says:

Local AMP: Installs an amp file from ./amps or ./amps_share into this project

The amps and amps_share folders are created at the base of the project structure.

It looks as though the project structure was fixed (amps and amps_share live under customizations folder) in a recent update, but the text was still incorrect in the code. Pull Request created with fix.