How to put list of strings as a variable?

Hello!
I have the following template:
{
  "labels": {{ .labels }}
}

I want to get the following result:
{
  "labels": ["label1", "label2"]
}

Note, it should be valid JSON.
Does this action support it? How can I do that?
Thanks in advance

Hi @emilt27,

Does this action support it? How can I do that?

It depends on how you want to pass list of labels to the action.
Option 1. Pass array of strings
If list of labels is static, you can pass it as an array of strings:
Workflow file:
      - name: Render template
        uses<EMAIL_ADDRESS>        id: render
        with:
          template: json.txt
          vars: |
            lables:
                - label1
                - label2
            labels_the_other_way: ["label1", "label2"]

Template:
{
  "labels": [
    {{- $first := true }}
    {{- range .labels }}
    {{- if $first }}{{ $first = false }}{{ else }},{{ end }}
    "{{ . }}"
    {{- end }}
  ]
}

Option 2. Pass JSON-encoded string
If list of labels is dynamic, the easiest way is to pass it as a JSON string:
Workflow file:
      - name: JSON encode labels
        shell: bash
        id: json
        run: |
          labels=("label1" "label2")
          labels_json=$(printf '%s\n' "${labels[@]}" | jq -R . | jq -s .)
          echo "::set-output name=json::$labels_json"

      - name: Render template
        uses<EMAIL_ADDRESS>        id: render
        with:
          template: json.txt
          vars: |
            lables: ${{ steps.json.outputs.json }}

Template:
{
  "labels": {{ .labels }}
}

Option 3. New template functions
I can add two template functions to split string into array and convert it to JSON array. This is how it may look like:
Workflow file:
      - name: Render template
        uses<EMAIL_ADDRESS>        id: render
        with:
          template: json.txt
          vars: |
            lables: label1,label2

Template:
{
  "labels": {{ .labels | split "," | json }}
}

Which option do you prefer?

I've added split and toJSON functions in v1.10, which should cover this use case. Let me know if this doesn't work for you. Meanwhile, I'll close this issue.


Check automatically for Driver Updates

Please add for a way to check automatically for driver updates, instead of paying for a driver update software.

What type of drivers? Isn't Windows doing this automatically?
Even then, this tool is all about offline helpers for dev tasks, checking online for a driver update seems out-of-scope?

@RexRode what you are looking for is Snappy Driver Updater Origin(https://www.snappy-driver-installer.org/)
It does automatic checking, downloading, and installing, online or offline. All for free with no ads or paid version.


Use HTML elements for accessibility #a11y

- Do you want to request a feature or report a bug?
Bug
- What is the current behavior?
Many HTML elements used in the app are <div>s rather than semantically correct and accessible HTML elements (such as <main>, <aside>, <li> etc.). This means accessibilty software such as screen readers can't navigate the screen as effectively.
This is a refinement on https://github.com/netlify/netlify-cms/issues/1333 Accessiblity #a11y issues
- If the current behavior is a bug, please provide the steps to reproduce.
Use a screen reader with the app. Alternatively, view source and see that eg the main content area nc-collectionPage-main uses a <div> rather than <main>.
- What is the expected behavior?
Use semantically correct HTML elements where possible 🙂

- Please mention your versions where applicable.

Netlify CMS version: 2.0.0-dev-dev
Browser version: 61.0

Node.JS version: v8.9.1
Operating System: MacOS 10.13.5
- Please link or paste your config.yml below if applicable.

Awesome, I've been wishing someone would do this! 😃

I think #1585 should've closed this correct?

Yeah, looks like 👍


Consider a switch to custom hdf5 layout

We use Pandas to write our data frames to HDF5, which records them in a way that optimizes for database-like queries. The problem is that we never use such a functionality but it costs storage space and makes the data harder to read from other languages. We should switch to a custom layout with h5py

After some further reading: I'm going to stick with PyTables and use it natively via PyTables rather than via Pandas. PyTables tables are just normal H5 datasets, but with a struct/compound data type row.


Pass logger config to mockserver

Configuration for mockserver is hardcoded in https://github.com/celestiaorg/optimint/blob/tzdybal/latest-cosmos/da/grpc/mockserv/mockserv.go#L18.
It would be great to have a possibility to pass this configuration.

The code has changed then, is this issue still relevant?

This is still relevant - ideally the logger should be passed to GetServer instead of creating it inside this function.
Current code location: https://github.com/celestiaorg/rollmint/blob/cc0a2950ea752b8905fb35062069a951c99ef115/da/grpc/mockserv/mockserv.go#L19


Support for java versions: jenv

Hi all, just started using powerlevel9k and I'm loving it so far, super customizable.
I'm wondering if there is support for jenv? It would be great if it could be added in the future, as I use it to manage multiple java versions on my machine much like node (nvm). It looks like we have pyenv, rbenv, nvm, so it would be nice to also have jenv. :)
Currently, if I add java_version, I get a message saying I need a JDK installed, probably because all of my java versions are installed through jenv.

Hi @devshawn ,
sure, why not? You could do a PR based on our next branch.
Thanks

Ah! The current java_version works with jenv when I added $HOME/.jenv/bin to my PATH.
The display correctly switches when using jenv local 1.8 -> jenv local 10.0 for example. Yay! 😄


Strict mode exception

@OneToMany MutableResult getVersions();
in other class we have
@ManyToOne Document getDocument();
insert some data with .getVersions().add() and when i call getVersions() strict mode throws exception
E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
              java.lang.Throwable: Explicit termination method 'close' not called
                  at dalvik.system.CloseGuard.open(CloseGuard.java:180)
                  at android.database.CursorWindow.<init>(CursorWindow.java:111)
                  at android.database.AbstractWindowedCursor.clearOrCreateWindow(AbstractWindowedCursor.java:198)
                  at android.database.sqlite.SQLiteCursor.fillWindow(SQLiteCursor.java:138)
                  at android.database.sqlite.SQLiteCursor.getCount(SQLiteCursor.java:132)
                  at android.database.AbstractCursor.moveToPosition(AbstractCursor.java:219)
                  at io.requery.android.sqlite.CursorResultSet.<init>(CursorResultSet.java:68)
                  at io.requery.android.sqlite.SqlitePreparedStatement.executeQuery(SqlitePreparedStatement.java:148)
                  at io.requery.sql.SelectResult.iterator(SelectResult.java:136)
                  at io.requery.query.BaseResult.iterator(BaseResult.java:111)
                  at io.requery.query.ModifiableResult.iterator(ModifiableResult.java:69)

beta11 version of the library

Thanks for reporting, looks like an easy fix will be in the next update.

Do you have the whole log from that stacktrace? there should be some more information before and after that will help solve it completely. Thanks

I am sorry but right now i am unable to reproduce it.

Looking at the code it should not iterate the result just by calling get. So will close for now please post back if it reoccurs.


Update benq-iam-tutorial.md

Hi, this is BenQ.
Correct the information about "set additional URLs".
Change Sign-on URL to Logout Url and update the URL itself.
Thanks!

@BarryHo03 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Same as other issue comment. Once you confirm it then we can accept this change.

@BarryHo03 Can you please confirm that you would like to remove the SP initiated SSO here and setup the Logout URL so that user can do the single sing out?

As we are not getting confirmation on this change, we are closing this ticket now.

#please-close


Libraries that needs patches to build in a path with space

The underlying build system of the following libraries needs patching to work if it is located in a path with space:
(checked = vcpkg has the needed patches)

[x] openssl - Patches upstreamed!
[ ] libvpx
[x] libxml2
[x] openblas - Patches upstreamed!
[x] libvorbis
[ ] icu
[ ] jsonnet
[x] readosm - No patching required
[x] FreeXL - No patching required

Hi @alexkaratarakis , thanks for reporting this issue!
Please open a new issue if this is still a problem for you.
Thx.


Unbound type constructor expression

Hi
I found this library trying to update the jbuild dependencies via opam pin. I understand it's under heavy development, so maybe you're aware of this.
When running opam pin add . I get the following build error:
# Command [5] exited with code 2:
# $ (cd _build/default && /home/andre/.opam/4.04.0/bin/ocamlc.opt -w -40 -g -bin-annot -I     /home/andre/.opam/4.04.0/lib/ocaml/compiler-libs -I /home/andre/.opam/4.04.0/lib/ppx_core -I    /home/andre/.opam/4.04.0/lib/ppx_traverse_builtins -no-alias-deps -I lifters -o    lifters/ppx_metaquot_lifters.cmo -c -impl lifters/ppx_metaquot_lifters.ml)
# File "lifters/ppx_metaquot_lifters.ml", line 5, characters 11-21:
# Error: Unbound type constructor expression

If I'm not mistaken, expression comes from ppx_core, though I have it pinned to the git HEAD version as of now and it still won't find it.
Thanks,
Andre

I guess I didn't have all other dependencies on git HEAD. I updated all repositories this morning and now I'm able to build ppx_metaquot without errors.
Sorry for the noise.

You can also use our development opam repository:
$ opam repo add janestreet https://github.com/janestreet/opam-repository.git

Nice to know :)
Thanks!
On Fri, Mar 3, 2017 at 9:33 AM, Jérémie Dimino<EMAIL_ADDRESS>wrote:

You can also use our development opam repository:
$ opam repo add janestreet https://github.com/janestreet/opam-repository.git
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/janestreet/ppx_metaquot/issues/2#issuecomment-283942184,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB2BQNNuvPOAwTYRrWhHn5Of5UCYv5bks5riAifgaJpZM4MRVLc
.


fix: serialisation for non-api errors

from sentry https://sentry.io/organizations/cognite/issues/1240621332/?environment=production&project=1206818&query=is%3Aunresolved

that's more like a guess, I tried to reproduce the initial error but didn't succeed with it.
so I believe this at least is a good start

:tada: This PR is included in version 2.7.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove "collapse" item from context menu

Expected Behavior
The context menu for the workspace should not include a "collapse" item.
Actual Behavior
The item exists, and has a broken behavior. We should probably remove it.

This is an option when creating the workspace. Moving to scratch-gui.

Moved to LLK/scratch-gui#1082


Bringing some Personally wanted changes to moonscraper

The list of Changes:

Drum Note Model
+ Ability to add custom resources by the name of drum notes

/ Correcting the colors of the sustain textures as they were wonky on my end having been shifted one off.

Usage of custom resources was created for this specific purpose, this pull seems very unnecessary and has a few empty commits on assets that didn't actually change. Will be doing my own pass over the manual as it's a little out of date in more ways than one.


App fails to start with Metor 1.1

Node version was updated.
Can be temporarily overridden by adding a 'nodeversion' file to the root of the project with contents "0.10.36".
Fixed by #11

Thanks for the PR.


Disable auto center adjust after change marker coordinates programmatically

Hi everyone
after change marker coordinates programatically leflet auto adust the center map. My app track device location but user can focus in other markers.
My map losses the marker focus each time user moves.
How disable this behavior?
Example http://angular-ui.github.io/ui-leaflet/#!/examples/dragging-markers

Hi, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features. For questions on using Leaflet, please use gis.stackexchange.com or stackoverflow.
If you are really sure that this is a bug in leaflet, or a feature request, please change the wording to make it look like a bug report.


Add/Replace audio track for a video

Q
A

Bug?
no

New Feature?
maybe

Version Used
master

FFmpeg Version
FFProbe N-84607-g9bcc5e8-tessus - ffmpeg version 3.2.4

OS
mac OSX Sierra 10.12.3

It is possibile to load an mp3 audio track and add (or replace) it to an existing video? If yes, I don't know how to do it. The audio and video formats doesn't matter for me.
Thanks.

no, it's not possibe yet using prewritten filters. But you can use the SimpleFilters to complete this.

Do you refer to https://github.com/PHP-FFMpeg/PHP-FFMpeg/blob/master/src/FFMpeg/Filters/Audio/SimpleFilter.php ?
What I have to do to properly use it?

yes, I do. If you know the ffmpeg command for this, it would be quite useful(I'm at mobile).
Basically, it is like this: https://github.com/PHP-FFMpeg/PHP-FFMpeg/blob/master/src/FFMpeg/Media/Video.php#L74
That way, you can add something that will be executed. (Use Video#addFilter to add it)

apologize for writing again but the ffmpeg cmd to mix audio and video is the follow:
ffmpeg -i input0 -i input1 -map 0:a -map 1:v -c copy output
and I have no idea about how to bind input0 and input1 (respectively the audio and video file in this sample) to real input files with my SimpleFilter. I have searched for samples in this repository but I didn't find anything useful.

I'll check wether this is possible today. Thanks for providing the command, it is quite helpful.

Hi think this should be a new filter, like a MergeFilter.
This needs a PR.
@Nonnis-M can you provide us with the link to FFMPEG documentation of this feature?

I'll do a pr once I created the "audio-muting" pr.

Has this been done? How do you accomplish this?

This is not yet implemented, feel free to file a Pull Request. :)


Channel Renderers should be configurable from node description.

i.e. min/max values for number channel.

Or should it be done through inheriting channel type? Or both?


EtherThief not detecting vulnerability when funds are acquired via remote contract

Description
I have a pair of contracts (deployed via ganache) where the first (Freemoney) has some ether while the second (Getmoney) is able to extract it and pass on to anyone who calls a extractMoney function:
pragma solidity ^0.4.20;
contract Freemoney {
    function Freemoney() public payable
    {
     	require(msg.value == 0.1 ether);
    }
    function extractMoney() public payable
    {
        msg.sender.transfer(address(this).balance);
    }
}

pragma solidity ^0.4.20;
import "./freemoney.sol";
contract Getmoney {
    Freemoney constant public fm = Freemoney(<address of Freemoney>);
    function() external payable {}
    function extractMoney() public payable
    {
        fm.extractMoney();
        msg.sender.transfer(address(this).balance);
    }
}

I analyze Getmoney on-chain via mythril's EtherThief module and expect it to detect a vulnerability. However it reports no issues found.
How to Reproduce

Deploy both above contracts (using 0.1ETH value when deploying the first and pasting it's address into the second contract before deploy) then run mythril  (I am on 579480b4) via
myth -v5 analyze --solver-timeout 600000 -m EtherThief --rpc <node URI> -a <Getmoney address>
I used solcx.compile_files with default arguments to compile the contracts.
Expected behavior

I expected mythril to detect a vulnerability - a call to extractMoney().

Some additional info. As is, mythril reports ~1.15s solver time and 65% and 70% coverage for two different bytecodes. However if I make the the balance of the Freemoney contract symbolic by adding the following line to DynLoader.read_balance:
        if address == "<Freemoney address>": raise Exception()

a vulnerability is actually detected when running the same command on the same contract. Solver time is now 2-3 minutes and coverage is 97.5% and 93%.
I only have a vague understanding of what I am talking about here but maybe this can be helpful in understanding the issue.

Thanks for the help, this seems to be an issue with extracting concrete balances for contracts from block chain.


replace android.util.Pair

Goal
Use kotlin.Pair instead of android.util.Pair
Testing
unit testing

#663
#662  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on  Graphite

Should be denylist this class with a detekt rule so if anyone accidentally uses it, it'll get flagged?

Should be denylist this class with a detekt rule so if anyone accidentally uses it, it'll get flagged?

Sounds good, will add it in this PR.


Improved logging of busiest tablets.

This is replacement of #1187 with the following improvements :

Uses deltas of counters
Refactored code so that its unit testable
Fixed a bug with the priority queue use, it was not properly tracking the top N.

@alerman would you be able to take a look at this?

The Travis build indicates some non-Java 7 stuff is being used for the 1.9 branch. These should be easier to catch after I implement #1236

Made further improvements in #1296


HamEvo modules are mutating the input state

e.g. here this means we have to deepcopy states to make tests pass. this should be fixed for example here.

https://github.com/pasqal-io/PyQ/pull/38 fixes this


Issue saving a typeorm entity

Environment

Operating System: Windows_NT
Node Version:     v16.14.2
Nuxt Version:     3.0.0-rc.10
Nitro Version:    0.5.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://github.com/damgem/sidebase-typeorm-test (only app.vue is modified - see commit)
Describe the bug
Saving an example entry does not work.
I've tried the 4 following approaches with all them producing an error in the browser console.
For the first two approaches the error message is DataSource is not set for this entity.  and appears on execution while the latter ones produce an connection.driver.options is undefined error on page load.
const exampleData = {
  description: 'blah',
  details: 'blub',
}

// Will throw `DataSource is not set for this entity.` error when executed
const example = new Example()
await example.update(exampleData) // internally calls `.save()`

// Will throw `DataSource is not set for this entity.` error when executed
await Example.save<Example>(exampleData)

// Will throw `connection.driver.options is undefined` error on page load
await AppDataSource.manager.save(Example, exampleData)

// Will throw `connection.driver.options is undefined` error on page load
const exampleRepository = AppDataSource.getRepository(Example)
await exampleRepository.save(exampleData)

Additional context
I'm not sure this is a bug or rather an user error - anyways some guidance / documentation is appreciated :)
Logs
Warning & Error on execution for approach 1 and 2
[Vue warn]: Unhandled error during execution of component event handler
  at <AButton onClick=fn<insertExample> >
  at <App key=1 >
  at <NuxtRoot> runtime-core.esm-bundler.js:38:16

Uncaught (in promise) Error: DataSource is not set for this entity.
    NuxtJS 2
    update Base.ts:31
    insertExample app.vue:13
    NuxtJS 4
    handleClick2 ant-design-vue_es.js:16419
    NuxtJS 49
BaseEntity.ts:115:18
    NuxtJS 5
    emit$1 self-hosted:1406
    get emit/< NuxtJS
    handleClick2 ant-design-vue_es.js:16419
    NuxtJS 48
    InterpretGeneratorResume self-hosted:1819
    AsyncFunctionNext self-hosted:807
    (Async: async)
    <anonymous> NuxtJS

Error on page load for approach 3 and 4
Uncaught TypeError: connection.driver.options is undefined
    NuxtJS 3
        create
        createEntityManager
        DataSource
    <anonymous> index.ts:5
EntityManagerFactory.ts:15:12

for context: index.ts:5 is a reference to server/database/index.ts starting on line 5 with
const AppDataSource = new DataSource({
  type: 'sqlite',
  // TODO: Only synchronize in production once we're stable
  synchronize: !isProduction || true,
  logging: false,
  database: ':memory:',
  entities: [Example],
})

Sorry to say: This is likely a user-error.
Looking at your code, it seems you're referencing these lines:
https://github.com/damgem/sidebase-typeorm-test/blob/3e115a8961f021f602f6d913812904da810fb3aa/app.vue#L1-L25
The app.vue is loaded on the client-side, so in your browser. That place does not have a connection to the database or the server, as it's the frontend, not the backend! On the backend, the data source is initialized on startup automatically, see: https://github.com/damgem/sidebase-typeorm-test/blob/3e115a8961f021f602f6d913812904da810fb3aa/server/plugins/initTypeOrmOnServerStartup.ts
Code like this will (hopefully) work right away on the server side, see the exmaples in the api/ folder.
Closing this issue now as it likely comes from a misunderstanding, feel free to re-comment here / open a new one if something else arises.


Instantly Kill Throttle

I need a way to instantly kill the throttle on the drone. I was going to use the RC Overrides but wondering if there's a better way?
Thanks in advance

On Thu, 12 Mar 2020, Alex Willis wrote:

I need a way to instantly kill the throttle on the drone. I was going to use the RC Overrides but wondering if there's a better way?

disarm the vehicle?  ArduPilot supports a "force" option to ensure that
works.
You could also turn the "hardware safety switch" on via a mavlink command.

Is there a dronekit function for this or do I need to generate the mavlink command myself?
I need to do it programatically in Python

On Fri, 13 Mar 2020, Alex Willis wrote:

Is there a dronekit function for this or do I need to generate the mavlink command myself?

I think you'll need to do it yourself.

Is there a dronekit function for this or do I need to generate the mavlink command myself?
I need to do it programatically in Python

Flight mode "Brake" might help you there.
https://ardupilot.org/copter/docs/brake-mode.html#brake-mode


App broke with new highchart upgrade

https://jakehp.github.io/carcalc/
Fixed. react-highcharts now pulls in highcharts dep.


Added a setting to disable the right click context menu animations

Closes #2381

I'll approve this extra setting only because our context flyout is too large today and the resultant animation isn't contributing to the user experience. Ideally, we'll improve it by simplifying the right click experience and eventually provide special treatment to actions/integrations from the Windows shell.
I hope to finalize a high-quality specification for this in the coming weeks.

This will likely be improved once we make the move over to the CommandBarFlyout so we can re-evaluate this setting once that happens.

I'll approve this extra setting only because our context flyout is too large today and the resultant animation isn't contributing to the user experience. Ideally, we'll improve it by simplifying the right click experience and eventually provide special treatment to actions/integrations from the Windows shell.
I hope to finalize a high-quality specification for this in the coming weeks.

This will likely be improved once we make the move over to the CommandBarFlyout so we can re-evaluate this setting once that happens.


Website: Cookbook recipes need individual pages

So they can be more easily linked to and so the preview window displays the title, description, and OG image specific to that recipe

resolved in #3081, #3080, and #3088


Database Initialization

This patch replaces the undocumented database initialization script with
a mechanism for automatic database initialization.

Before you resolve those conflicts: I will review this PR but have to research a bit about database migration and that stuff. I want to have some proper foundational knowledge before tackling this.

Fixing the conflict was easy enough. Done.

Since Lars doesn't have time for this right now, we decided that I will solve this DB migration stuff. I will create a new PR for that.


[AIRFLOW-1938] Remove tag version check in setup.py

Make sure you have checked all steps below.
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1938

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[ ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

yay.

Can you explain the why?

@Fokko it is a kind of runtime check that doesnt really seem to make sense

@Fokko it also just doesn't work with the apache release process. See description in JIRA.

LGTM

Merged!


drivers: disk: add fakefat disk driver

Fakefat disk emulates a disk formatted with the FAT file system.
The driver supports FAT16 and FAT32 emulation and multiple instances.
A backend can register at least 15 emulated files on a disk instance.
The file structure contain read and write callbacks that are called
when the filesystem driver accesses the volume. A backend can have
multiple files with read callbacks, but usually only one or zero with
write callbacks.
Fakefat disk can be used for testing or to map services such as
firmware updates to a file on the emulated disk.
Complementary to #53798
TODO:

[ ] sample README.rst
[ ] documentation
[ ] tests

@petejohanson You might find it useful for your fancy stuff.

@petejohanson You might find it useful for your fancy stuff.

Interesting.. possibly useful for some of our testing scenarios or development with the posix targets.

I don't expect this to work.
The "ffdisk" name is horrible because it looks like typo. Why are you using such ridiculously short names recently (that are completely unreadable)? What's wrong with just using "fakefatdisk"?

What exactly do you not expect to work? Or what is not working for you? Where did you find ffdisk? (Why would I use ridiculously long names?)

What exactly do you not expect to work? Or what is not working for you?

When the host reorders the files, e.g. deletes a file and then creates a new one things will break.

Why would I use ridiculously long names?

Code is written for humans. It is annoying when something that can be mistaken as a typo has some very special meaning behind it. In my opinion longer names are generally better because such names avoid ambiguity and are especially helpful for newcomers.


Adding rules for filtering traffic going up to enforcer

Description
Changes proposed in this pull request.
Test plan
Outline the test plan used to test this change before merging it.

Fixes #.

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "ackfilter",
    "component": "trireme-lib",
    "pr-id": "817",
    "commit-sha": "5e35afd1a7a09ed14abe4465ac5334683d38d37c"
  },
  {
    "project": "ackfilter",
    "component": "enforcerd",
    "pr-id": "1241",
    "commit-sha": "9e5ecceeb0b8bb74b963911d2f250db1ec6b4ef3"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "ackfilter",
    "component": "trireme-lib",
    "pr-id": "817",
    "commit-sha": "08d5e8b76bc7665481938303d48006ef42d8d6ab"
  },
  {
    "project": "ackfilter",
    "component": "enforcerd",
    "pr-id": "1241",
    "commit-sha": "9e5ecceeb0b8bb74b963911d2f250db1ec6b4ef3"
  }
]


Stop special characters (umlauts) from being converted into hexadecimal values within the whole file

I came across an issue with special characters whenever I parse my php file.
Letters such as:
Ä Ö Ü & % §

gets compiled into
Ä Ö Ü & % §

respectively. That's within the whole document, not just the images' alt attribute. Is there any way to stop this behavior?
<meta charset="utf-8">

is set in the document head.

Hi Nik,
Thanks for pointing this out. I will look into it and have it fixed with the next update coming this weekend.
Cheers,
Stephan

This is fixed now.


unspecified params in nested hashes are now present with include_missing=false

This behavior seems to have changed with: https://github.com/ruby-grape/grape/pull/1575
Here is a test case that demonstrates the change in behavior before and after commit 7a56fe9ae5875fb2735223b532037cdd7bf38440:
https://github.com/salsify/grape/compare/master...salsify:nested-include-missing-test-case
After the change above the test case fails with:
       expected: ["fourth"]
            got: ["fourth", "fifth"]

I.e. additional keys get included in the hash even with include_missing=false.

Looks like another bug, @tjwp since you have a spec maybe try a fix?

@tjwp Nice catch and thanks for the test. It looks like I missed some stuff when refactoring declared here is a pull request:
https://github.com/ruby-grape/grape/pull/1585
Let me know if that doesn't solve your problem.

@thogg4 Commented on the PR, but this fixed the issue for me. Thanks for the quick fix!


Arisilon/issue 20 - [merged]

In GitLab by @arisilon on Oct 30, 2019, 10:49
Merges arisilon/issue-20 -> master

In GitLab by @arisilon on Oct 30, 2019, 11:08
mentioned in commit f5c94192a16c9c3555cff86f17d9a017e18f9ee1

In GitLab by @arisilon on Oct 30, 2019, 11:08
merged


Wave Length

Is it possible to read the length (in seconds) of a wave file? Or is there an work around?

Sorry I never got back to you.  I don't actually have a workaround for you I'm afraid.  This is probably a feature I should add, so I'll mark this as an enhancement.
If you need the feature right now, you could probably load a javax.sound.sampled.Clip and ask for the length.  Sorry I don't have a better answer for you right now.

At the moment right now I use the AudioInputStream an compute the length this the framesize und framerate. But is is a kind of annoying to do it that way. I am looking forward to this feature in a further build.

Here's the code:
			AudioInputStream audio = AudioSystem.getAudioInputStream(musicFile);
			AudioFormat audioFormat = audio.getFormat();
			float frameRate = audioFormat.getFrameRate();
			long frameLength = audio.getFrameLength();
			float durationInSeconds = frameLength/frameRate;

Thanks, and sorry again, I simply haven't gotten around to adding this feature.


add some optional claims validation

this is restricted to boolean claims.
Note: the code is not ready to merge - it is rather a way to open a discussion on this
kind of feature and the best way to implement it

In fact a much better approach might be to provide an entry point to implement these claim checks. Either by subclassing the jwt authenticator, or by providing a callback.
What do you think?


Handling of static files, styling,...

I think we should discuss/decide on how static files or styling more generally,... should be handled now that most of our JS and CSS has been moved out of our templates and into separate files.
Discussion points:

file naming scheme
where should code go/how should it be split up  – relevant for overrideability, reusability

if/how to divide up Core code (1 file per app or more, if more: how/when/what),
file placement, file order, settings which impact load order (event listeners, defer attribute),
blocks (placement) for overrides (external code, external code + Core overrides, custom Core code),

custom styling for custom CSS vs. built-in semantic labelling (e.g. "warning", "danger" colours for elements)

Related recent comments re: naming of files https://github.com/acdh-oeaw/apis-core-rdf/pull/1234#pullrequestreview-2336720128, re: template tags https://github.com/acdh-oeaw/apis-core-rdf/pull/1242#pullrequestreview-2337663008

we put all JS in the header and use event listeners and defer to decide when to execute the JS


add --cpu-quota

units are CPU-µs per 100ms, so 100000 is 1 CPU per container.
closes #239

Great, thanks Min.


[BUG] The new symlink feature of ModelCheckpoint is broken when wrong link path

Bug description

As demonstrated in the above figure, the last.ckpt is linked to a wrong path. The correct path is just epoch:299-val_loss:0.ckpt instead of the long path from work_dirs.
https://github.com/Lightning-AI/pytorch-lightning/blob/628ee0cb61637d01a44884e0d805e238ea6b49bb/src/lightning/pytorch/callbacks/model_checkpoint.py#L692C25-L692C25
If we want to use the soft link, the above code should modify the filepath to start from the dirname of self._last_checkpoint_saved, instead of using the unchanged filepath, which is started from the current working dir.
In addition, though I agree with the idea of using the file link of last.ckpt to reduce the occupation of checkpoints on disk, it will be better to use the hard link instead of the soft link if possible on the local file system since the hard link will be more robust.
And the hard link use the relative path from the working dir, so the fix to this issue will be simply modifying the code in
https://github.com/Lightning-AI/pytorch-lightning/blob/628ee0cb61637d01a44884e0d805e238ea6b49bb/src/lightning/pytorch/callbacks/model_checkpoint.py#L406
to
                os.link(filepath, linkpath)

What version are you seeing the problem on?
v2.1
How to reproduce the bug
No response
Error messages and logs
# Error messages and logs here please

Environment

Current environment

CUDA:

GPU:

NVIDIA GeForce RTX 4090
NVIDIA GeForce RTX 4090
NVIDIA GeForce RTX 4090
NVIDIA GeForce RTX 4090
NVIDIA GeForce RTX 4090
NVIDIA GeForce RTX 4090
NVIDIA GeForce RTX 4090
NVIDIA GeForce RTX 4090

available:         True
version:           12.1

Lightning:

lightning:         2.1.3
lightning-template: 1.5.1
lightning-utilities: 0.10.0
pytorch-lightning: 2.1.3
torch:             2.1.2
torchmetrics:      1.2.1
torchvision:       0.16.2

Packages:

accessible-pygments: 0.0.4
aiohttp:           3.9.1
aiosignal:         1.3.1
alabaster:         0.7.16
annotated-types:   0.6.0
antlr4-python3-runtime: 4.9.3
anyascii:          0.3.2
anyio:             4.2.0
appdirs:           1.4.4
argcomplete:       3.1.6
astroid:           3.0.2
attrs:             23.2.0
babel:             2.14.0
beautifulsoup4:    4.12.2
build:             1.0.3
cachetools:        5.3.2
certifi:           2023.11.17
cfgv:              3.4.0
chardet:           5.2.0
charset-normalizer: 3.3.2
click:             8.1.7
colorama:          0.4.6
commitizen:        3.13.0
contourpy:         1.2.0
coverage:          7.4.0
cycler:            0.12.1
decli:             0.6.1
distlib:           0.3.8
distro:            1.9.0
docker-pycreds:    0.4.0
docstring-parser:  0.15
docutils:          0.20.1
filelock:          3.13.1
fonttools:         4.47.0
frozenlist:        1.4.1
fsspec:            2023.12.2
gensim:            4.3.2
gitdb:             4.0.11
gitpython:         3.1.40
googletrans:       2.4.0
h11:               0.14.0
httpcore:          1.0.2
httpx:             0.26.0
huggingface-hub:   0.20.2
identify:          2.5.33
idna:              3.6
imagesize:         1.4.1
importlib-metadata: 6.11.0
importlib-resources: 6.1.1
iniconfig:         2.0.0
jinja2:            3.1.2
joblib:            1.3.2
jsonargparse:      4.27.1
jsonnet:           0.20.0
jsonschema:        4.20.0
jsonschema-specifications: 2023.12.1
kiwisolver:        1.4.5
lightning:         2.1.3
lightning-template: 1.5.1
lightning-utilities: 0.10.0
livereload:        2.6.3
logmatic-python:   0.1.7
markdown-it-py:    3.0.0
markupsafe:        2.1.3
matplotlib:        3.8.2
mdit-py-plugins:   0.4.0
mdurl:             0.1.2
medclip:           0.0.3
mpmath:            1.3.0
multidict:         6.0.4
myst-parser:       2.0.0
networkx:          3.2.1
nltk:              3.8.1
nodeenv:           1.8.0
numpy:             1.26.3
nvidia-cublas-cu12: <IP_ADDRESS>
nvidia-cuda-cupti-cu12: 12.1.105
nvidia-cuda-nvrtc-cu12: 12.1.105
nvidia-cuda-runtime-cu12: 12.1.105
nvidia-cudnn-cu12: <IP_ADDRESS>
nvidia-cufft-cu12: <IP_ADDRESS>
nvidia-curand-cu12: <IP_ADDRESS>
nvidia-cusolver-cu12: <IP_ADDRESS>
nvidia-cusparse-cu12: <IP_ADDRESS>
nvidia-nccl-cu12:  2.18.1
nvidia-nvjitlink-cu12: 12.3.101
nvidia-nvtx-cu12:  12.1.105
omegaconf:         2.3.0
openai:            0.28.0
packaging:         23.2
pandas:            2.1.4
pillow:            10.2.0
pip:               23.3.1
platformdirs:      4.1.0
pluggy:            1.3.0
pre-commit:        3.6.0
project-template:  0.2.2.dev4+dirty
prompt-toolkit:    3.0.36
protobuf:          4.25.1
psutil:            5.9.7
pydantic:          2.5.3
pydantic-core:     2.14.6
pydata-sphinx-theme: 0.15.1
pygments:          2.17.2
pyparsing:         3.1.1
pyproject-api:     1.6.1
pyproject-hooks:   1.0.0
pytest:            7.4.4
pytest-cov:        4.1.0
python-dateutil:   2.8.2
python-json-logger: 2.0.7
pytorch-lightning: 2.1.3
pytz:              2023.3.post1
pyyaml:            6.0.1
questionary:       2.0.1
reconplogger:      4.12.0
referencing:       0.32.1
regex:             2023.12.25
requests:          2.31.0
rich:              13.7.0
rpds-py:           0.16.2
ruyaml:            0.91.0
safetensors:       0.4.1
scikit-learn:      1.3.2
scipy:             1.11.4
sentry-sdk:        1.39.1
setproctitle:      1.3.3
setuptools:        68.2.2
shell-command-launcher: 1.1.0
six:               1.16.0
smart-open:        6.4.0
smmap:             5.0.1
sniffio:           1.3.0
snowballstemmer:   2.2.0
socksio:           1.0.0
soupsieve:         2.5
speed-benchmark:   1.1.1
sphinx:            7.2.6
sphinx-autoapi:    3.0.0
sphinx-autobuild:  2021.3.14
sphinx-book-theme: 1.1.0
sphinx-design:     0.5.0
sphinxcontrib-applehelp: 1.0.7
sphinxcontrib-devhelp: 1.0.5
sphinxcontrib-htmlhelp: 2.0.4
sphinxcontrib-jsmath: 1.0.1
sphinxcontrib-qthelp: 1.0.6
sphinxcontrib-serializinghtml: 1.1.9
sympy:             1.12
termcolor:         2.4.0
textaugment:       2.0.0
textblob:          0.17.1
thop:              0.1.1.post2209072238
threadpoolctl:     3.2.0
timm:              0.9.12
tokenizers:        0.13.3
tomlkit:           0.12.3
torch:             2.1.2
torchmetrics:      1.2.1
torchvision:       0.16.2
tornado:           6.4
tox:               4.11.4
tqdm:              4.66.1
transformers:      4.24.0
triton:            2.1.0
typeshed-client:   2.4.0
typing-extensions: 4.9.0
tzdata:            2023.4
urllib3:           2.1.0
virtualenv:        20.25.0
wandb:             0.16.2
wcwidth:           0.2.13
wget:              3.2
wheel:             0.41.2
yarl:              1.9.4
zipp:              3.17.0

System:

OS:                Linux
architecture:

64bit
ELF

processor:         x86_64
python:            3.11.7
release:           5.15.0-91-generic
version:           #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023

More info
By the way, since we already implement the link of last.ckpt, how about adding a new feature on best.ckpt? Although we support saving the topk checkpoints, there is no consistent way to reference the top1 checkpoint. For example, in the above figure, I have to check the files under the folder work_dirs/medclip_resnet50_iu_xray_R2GenGPT_30x/2024.01.16_<IP_ADDRESS>7262/checkpoints to determine the file name epoch:5-val_loss:3.264.ckpt to reference the best checkpoint if I have not created the best.ckpt checkpoint. It will be more convenient if we implement the hard link of best.ckpt also. It can be implemented with the similar code as the last.ckpt part.
cc @carmocca @awaelchli

@shenmishajing Thanks for the investigation. I am not sure that I understand the problem fully from your description. We could make the linkpath relative to filepath before linking, would that fix the issue? A code example would be nice if you have one.
Regarding hardlinks, I vote against it. We need to support checkpoints as directories (i.e. FSDP/DeepSpeed sharded checkpoints) and hardlinks won't work for directories. Also, we would like that users can share their checkpoints from one filesystem to another, and hardlinks only work on the filesystem they were created on. For these reasons, I suggest to stay with symlinks.

FYI, we backed away from linking as the default in #19191 recently.

@shenmishajing Thanks for the investigation. I am not sure that I understand the problem fully from your description. We could make the linkpath relative to filepath before linking, would that fix the issue? A code example would be nice if you have one.

@awaelchli Yes, I think it will work. And, ok, I will try to implement this.

Regarding hardlinks, I vote against it. We need to support checkpoints as directories (i.e. FSDP/DeepSpeed sharded checkpoints) and hardlinks won't work for directories. Also, we would like that users can share their checkpoints from one filesystem to another, and hardlinks only work on the filesystem they were created on. For these reasons, I suggest to stay with symlinks.

Yeah, ok, I forget the sharded checkpoints, so the soft link will be better.

And, ok, I will try to implement this.

That would be wonderful. Your help is very appreciated!

@awaelchli Ok, I find that the os.path.relpath func already support to calculate a relative path from a given path, so it will be simple. Just change the code
https://github.com/Lightning-AI/pytorch-lightning/blob/628ee0cb61637d01a44884e0d805e238ea6b49bb/src/lightning/pytorch/callbacks/model_checkpoint.py#L406
to
                os.symlink(os.path.relpath(filepath, os.path.dirname(linkpath)), linkpath)

will fix this issue. Should I create a PR for it?
And how about the idea of the best.ckpt? I can implement it also.

Should I create a PR for it?

Yes that sounds good. It would also be good to have a test case to show how it fails.

And how about the idea of the best.ckpt? I can implement it also.

I suggest to open a separate feature issue about this request. I'd like to hear from others about this too. Currently, you can already achieve getting a best.ckpt by having a second model checkpoint callback.

@awaelchli I have created a PR #19303 for this. However, I found that the tmp_path in the unit tests return a abs path starting from \tmp leading to the false positive test results, since the code only breaks when the link path and file path are relative paths. But, how can I add tests for those cases? I'm not familiar with pytest and may need your help.

I suggest to open a separate feature issue about this request. I'd like to hear from others about this too. Currently, you can already achieve getting a best.ckpt by having a second model checkpoint callback.

@awaelchli I also create a new issue for it. Please see #19304.

leading to the false positive test results, since the code only breaks when the link path and file path are relative paths. But, how can I add tests for those cases? I'm not familiar with pytest and may need your help.

Yeah I can help with that, I will take a look in the next few hours


rebooting host, lose screen after bios screen

tiny pilot shows just a black screen.. no amount of rebooting the pi seems to bring it back.

a second reboot of the host brought it back.. maybe it was just a quirk.

@danmed  I had the same issue. It was a issue with the PC as connecting my portable hdmi monitor (before reboot) 'also showed black screen. Not sure if caused by the cheapo hdmi to usb device or not...


Filter out issues that are pull requests.

Fix #62 by filtering out issues that has the pull_request field.

@rhnonose you're machine!  Thank you so much for getting involved.  Let me know if you can think of any other improvements we could start making 👍

Thank you @rhnonose 👍


[Caloris] Add V1 endpoint to get FFs from connectors

See more context here: https://dust4ai.slack.com/archives/C050SM8NSPK/p1708069993476599.


[restclient-cpp] Fix portfile and update version.

This PR to update restclient library and fix portfile. Previously, the portfile had a command to delete the all compiled files (restclient-cpp.lib, restclient-cppd.lib), it is mistake.
I update library version from 0.5.1 tag to last commit. CMakeLists patches are no longer required in the new library version.
Library is updated and bugfixes, but the developer did not add new tags. Some people want tag updating (https://github.com/mrtazz/restclient-cpp/issues/145).

@et-nik
Could you please address the review suggestion?

Hello. I'll update this PR today.

It seems that the fix is not correct. Please refer to this doc to try it again.

Done

Bumped version to last tag 0.5.2
Removed old patches
Fixed descriptions

@NancyLi1013 Done
Hm. I see that all checks are succeeded https://dev.azure.com/vcpkg/public/_build/results?buildId=36451&view=results
But here check statuses are still "Waiting for..."

Cool, looks good to me! Thanks @et-nik :)


docs: Add documentation for Gateway API Addresses Support

Part of #33042

@lambdanis PTAL.

/test


🙈 Remove webkitgtk24x

Motivation for this change
I hope it goes without saying, but please 😂
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/issues/18312 basically did this in an elegant way, but we can for sure remove this now.

https://github.com/NixOS/nixpkgs/issues/18312 basically did this in an elegant way, but we can for sure remove this now.

Looks like there is no interest claws upstream https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3763
But emacs should support that: https://git.savannah.gnu.org/cgit/emacs.git/commit/configure.ac?id=d781662873f228b110a128f7a2b6583a4d5e0a3a

https://gist.github.com/GrahamcOfBorg/e121c3e97e1dfd6adf83bab9f193f157, is rather interesting...

See mmex in all-packages

@jtojnar Running unpackPhase on emacs25 shows
  WEBKIT_REQUIRED=1.4.0
  WEBKIT_MODULES="webkitgtk-3.0 >= $WEBKIT_REQUIRED"

So I think the source in nixpkgs predates this commit.

See mmex in all-packages

Did https://github.com/NixOS/nixpkgs/pull/75040/commits/3e1ee5b0eb343bba756afd3282e7c8bf5bbf5745.
This reminds me wxGTK needs to default to gtk3 https://github.com/NixOS/nixpkgs/pull/73145, but it's pretty tedious TBH.

https://git.savannah.gnu.org/cgit/emacs.git/commit/src/xwidget.c?id=a36ed9b5e95afea5716256bac24d883263aefbaf seems to apply:
diff --git a/pkgs/applications/editors/emacs/25.nix b/pkgs/applications/editors/emacs/25.nix
index f3989be52c0..15e9fbdd726 100644
--- a/pkgs/applications/editors/emacs/25.nix
+++ b/pkgs/applications/editors/emacs/25.nix
@@ -48,7 +48,16 @@ stdenv.mkDerivation rec {
     })
   ] ++ [
     # Backport patch so we can use webkitgtk with xwidgets.
-    ./0001-xwidget-Use-WebKit2-API.patch
+    (fetchurl {
+      name = "0001-Omit-unnecessary-includes-from-xwidget-c.patch";
+      url = "https://git.savannah.gnu.org/cgit/emacs.git/patch?id=a36ed9b5e95afea5716256bac24d883263aefbaf";
+      sha256 = "0a4ax1kjcn6g4c59a0wikplx47r6r3lh5igc9vrlqkpk5lw30j0j";
+    })
+    (fetchurl {
+      name = "0002-xwidget-Use-WebKit2-API.patch";
+      url = "https://git.savannah.gnu.org/cgit/emacs.git/patch?id=d781662873f228b110a128f7a2b6583a4d5e0a3a";
+      sha256 = "1m2fnblsk4dg3scxiawz6vsa83bvyg9bxis9mhrjd5f7cdmcnn4z";
+    })
   ];

   nativeBuildInputs = [ pkgconfig autoconf automake texinfo ]

@jtojnar Fetched those patches. I had to do it from the GitHub mirror because of the ongoing DOS (or maybe I'm blacklisted).

Claws Mail will build with a supported WebKit once it switches to GTK 3, which seems to progress well:
https://git.claws-mail.org/?p=claws.git;a=shortlog;h=refs/heads/gtk3
https://git.claws-mail.org/?p=claws.git;a=history;f=src/plugins/fancy;hb=refs/heads/gtk3
Meanwhile Claws Mail 3.17.4 has added a new litehtml-based HTML renderer plugin. I suppose I'll try to package it, since lack of HTML support noticebly reduces its usability. Alternatively it would make sense to provide a gtk3 branch snapshot of Claws Mail.

I have tried the litehtml plugin — it is as simple as adding gumbo to claws-mail build inputs (and enabling it in Configuration > Plugins) — but it's rendering is very bad, with huge spacing between words and lines, and the text can not be selected and copied.

Claws Mail will build with a supported WebKit once it switches to GTK 3, which seems to progress well:
https://git.claws-mail.org/?p=claws.git;a=shortlog;h=refs/heads/gtk3
https://git.claws-mail.org/?p=claws.git;a=history;f=src/plugins/fancy;hb=refs/heads/gtk3
Meanwhile Claws Mail 3.17.4 has added a new litehtml-based HTML renderer plugin. I suppose I'll try to package it, since lack of HTML support noticebly reduces its usability. Alternatively it would make sense to provide a gtk3 branch snapshot of Claws Mail.

It seems the only mostly working solution would be a gtk3 variant package. Though it's not good to distribute non-released/production code (some people even request that you don't), it's an option.

EDIT: Note that Claws Mail uses webkitgtk with javascript disabled, and therefore does not put its users at risk of known security issues.

While disabling JavaScript will reduce the attack surface greatly, I doubt JavaScriptCore is the only vulnerable component.


MAINT: lint: enable UP rules

Reference issue
https://github.com/scipy/scipy/pull/18353#issuecomment-1808711017
What does this implement/fix?

The UP rules are enabled in the linter
All existing violations are cleaned up

Quoting @stefanv :

The Ruff PyUpgrade rules ensure that SciPy uses modern Python constructs that work with all support Python versions.
While the linter only runs on files touched in any given PR, we have the option to apply these rules wholesale each time we drop support for another version of Python.
This keeps our code current, at low cost to maintainers.

Additional information
The vast majority of these changes were made automatically by Ruff's --fix, with the rest (changing from Union typing and to yield from) made by me.
Due to the automatic fixes, further (minor) style cleanups are possible here, but I don't know if they're worth the effort (or worth delaying this PR for).
The blame ignore will be added once this is ready.

If there is agreement on this change, we should add a commit with an entry in .git-blame-ignore-revs, and then merge (not squash merge) the PR.

If there is agreement on this change, we should add a commit with an entry in .git-blame-ignore-revs, and then merge (not squash merge) the PR.

Yes, I didn't yet in anticipation of a force push (which was immediately necessary since I forgot to mamba upgrade ruff). Perhaps there will be no force pushes from now on but no harm in holding off for a little longer.

CI is green (apart from the broken docs build). I've noticed some formatting issues (multiline strings off by 1 space, closing brackets on a new line). These will probably have to be looked at manually unfortunately.

These will probably have to be looked at manually unfortunately.

It would difficult to catch them later if we lose the .format() style. Because then the tool will not complain about anything.
I see quite a number of
    ('some long string'
    '')   # <- This looks like a tool bug to me

instances and I think ruff should be fixed about that.

This looks like a tool bug to me

IIUC this is because the linter is intended to be used in tandem with a formatter. This is difficult for SciPy to adopt short of formatting the entire codebase (far too disruptive).

Docs build failure is fixed in main, not related to this PR.

Thanks Matt, I added the needs-work label since I intend to do one full pass for style myself.

https://github.com/astral-sh/ruff/issues/8683 at least some of the formatting issues will be fixed in the next ruff release. I might wait for that and remake the PR (as long as a force push wouldn't be too disruptive?)

@lucascolley In the interest of time, consider using ruff from their main branch?

down to 22 errors which need to be fixed manually. There may be more once I rebase for gh-19529.

A slight change is needed for mypy from CI but I'lll wait until I've rebased on gh-19529 and fixed any additional errors. After that, I'll do a pass for style and check if any of the old comments still apply, then mark as ready for review. If everything looks good then, we may want to condense down to two commits for the purpose of the blame-ignore.

@j-bowhay @stefanv would either of you like to give this a look? No rush at all but I think it's ready. The safe auto fixes should be fine so perhaps just check the unsafe ones and my manual fixes?

OK, let's get this in before it goes stale. Do you want to make the .git-blame-ignore-revs commit(s)?

OK, let's get this in before it goes stale. Do you want to make the .git-blame-ignore-revs commit(s)?

👍 I'll address Jake's comment, squash down to 1 clean-up commit and add it to the ignored revisions (tomorrow). Thanks all for the quick review!

@stefanv good to go once CI is okay?

I see the same failure on PRs recently merged to main, so let's get this in before it becomes impossible to merge.

Thanks very much @lucascolley.

thanks all!
I imagine there isn't appetite for any more big changes soon, but if there are any other rules which you think are worth our time @stefanv, let me know and I'm happy to look into them.


Create Breathe First Search.java

Added an Alogrithm.

Create a issue first. It's a documentation project


Pass connection data to runners

Currently, the connection data for the protocol connection back to the judge needs to be hardcoded in the VM application of the runner. It would be nice if we could pass this along as an environment variable or sth, as it'd make developing with it much nicer

Currently solved by identifying connections through the hostname of the runner machine, which is in part randomly generated by Azure


Adding bloop results in Boxed Exception

I'm trying to use mill in Metals. Mill version: 0.7.3.
This needs bloop to be installed.
Both manual and automatic installation failed with Boxed Exception.
build.sc
import mill._
import mill.scalalib._

import $ivy.`com.lihaoyi::mill-contrib-bloop:0.7.3`

object main extends SbtModule {
  def scalaVersion = "2.13.2"
}

$ mill mill.contrib.Bloop/install
Failed to resolve ivy dependencies:Boxed Exception

@lihaoyi What do you think ?

This works on current Mill:
import mill._
import mill.scalalib._

import $ivy.`com.lihaoyi::mill-contrib-bloop:` // This will set the correct version

object main extends SbtModule {
  def scalaVersion = "2.13.2"
}

mill mill.contrib.bloop.Bloop/install

Passes correctly:
[build.sc] [23/59] resources.super.mill.scalalib.JavaMo
[build.sc] [26/59] mill.scalalib.ZincWorkerModule.zincL
[build.sc] [27/59] mill.scalalib.ZincWorkerModule.worke
[build.sc] [29/59] sources.super.mill.scalalib.JavaModu
[31/32] main.bloop.writeConfigFile
Wrote /Users/lorenzo/scala/repro/.bloop/main.json
[32/32] mill.contrib.bloop.BloopImpl.install

@lolgab
Wow. Fixing bug after 4 years :)

I think the bug was fixed long ago, it got just forgotten in the issue tracker.


use php_script_no_limit instead of php_script_limit, do not introduce db log write operation when there 's no DB configed

I think maybe php_script_no_limit is better
when no limit is true, we know that it'  unlimited
set php_script_limit to 1 then it is unlimited, I think is ambiguous  and confused.

app/Configs.php is a Base helper class
Logs::notice(__METHOD__, __LINE__, "hasImagick : false");
this call will cause composer install failure,
because when there is no imagick extension loaded,
artisan package:discover will fail, because no DB configed now

Hi @ttys3 thank you for your PR.
Commit 3c5744d is not useful, this has already been fixed: https://github.com/LycheeOrg/Lychee-Laravel/commit/5e13f3e1a31585974e5f0244d2e5600065043348 :)

thanks for the migration file


Stats don't show, everything is at 0%

What it looks like:
I'm running in a docker container.
Docker Log: https://pastebin.com/ByxGi1Jc
I'm running some custom Ubuntu Server 22.04 OS from Orange Pi and it's running on an Orange-Pi ( off-brand Raspberry Pi )
The old version of Ward was working on the same setup.
Docker command:
sudo docker run --restart unless-stopped -it -d --name ward -p 4000:4000 -e WARD_PORT=4000 -e WARD_THEME=light --privileged antonyleons/ward

Okay, so one of my chrome extensions are interfering with the panel which caused the status to show 0.

mad


Add a TracingMacros module providing the @Traced macro

This provides a @Traced macro which adds a tracing span around the body of the function. This macro allows customizing the operationName, the context, and the kind of the span, same as the withSpan function. It also exposes the span itself into the scope of the function, with a customizable name.
This doesn't attempt to support automatically adding parameters as attributes, because the scoping rules of attached macros aren't very amenable to controlling that. That could be added in the future if it's judged necessary.
Examples:
@Traced("preheat oven")
func preheatOven(temperature: Int) async throws -> Oven {
    span.attributes["oven.targetTemperature"] = temperature
    await sleep(for: .seconds(6))
    return Oven()
}

expands to:
func preheatOven(temperature: Int) async throws -> Oven {
    withSpan("preheat oven") { span in
        span.attributes["oven.targetTemperature"] = temperature
        await sleep(for: .seconds(6))
        return Oven()
    }
}

Notes:
This places the macros into a separate product so that users who don't want to pay the compile-time cost of macros don't have to use it, you opt-in to that cost by depending on the TracingMacros module.
This adds minimum OS versions for Apple platforms in order to be able to depend on SwiftSyntax. This applies to the whole package since there are no per-target platform specifications. Most notably: This raises the macOS minimum deployment target from the (implicit) 10.13 to 10.15 (matching SwiftSyntax).
Resolves #125

(Sorry @Traced that the commit messages tag you, I didn't mean to do that! 🙇🏻♀)

My bad with the trailing commas, I tested on 5.9 but not on 6.0, and I was using a toolchain with https://github.com/swiftlang/swift-evolution/pull/2344

Replaced by: in https://github.com/apple/swift-distributed-tracing-extras/pull/42 -extras


How can I downgrade?

Sorry to say that I don't like the new version.
How can I downgrade to v2?

Sorry for the delay. I believe Firefox will let you install older versions but I don't think it is possible with Chrome. I hope you closing this means you have changed your mind. If there is anything in particular you would like to comment on I can see what I can do about it.

Thanks for your reply.
I just found an old verison and did some tricks to prevent it upgrade automatically, therefore I colsed this issue :)


Group builds by build status

this helps with identifying what to re-run

I don't think it's worth it for now

@creydr can we merge and see to do that in the future? I'm spending too much time reconciling the status of the prod builds

/lgtm
/hold in case you want to check on https://github.com/openshift-knative/hack/pull/477 for this too


Adding help text for resourceTypes

Pull Request Test Coverage Report for Build 538845776

4 of 18 (22.22%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.006%) to 43.538%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/resource-deployment/src/services/resourceTypeService.ts
4
9
44.44%

extensions/resource-deployment/src/ui/toolsAndEulaSettingsPage.ts
0
9
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
1
73.46%

extensions/resource-deployment/src/ui/toolsAndEulaSettingsPage.ts
1
2.63%

Totals

Change from base Build 538808559:
-0.006%

Covered Lines:
24933

Relevant Lines:
52476

💛  - Coveralls


Remove a few useless shebang lines

Remove shebang lines from a few files that do not need them.
A shebang line is only meaningful in a file with the executable bit set in its permissions. These files are already correctly non-executable, as they have no “main routine” or interesting side effects and are purely importable modules.
Slightly more detail is available in the commit messages.

Looks good, thanks for the contribution.


Fix reade header

@filiph – feel free to squash-merge & delete this branch if you like

Coverage remained the same at 27.618% when pulling e3ec99867949beb6f185023af3f84bcdd16a9161 on kevmoo-patch-1 into 594677f81d3cf5bfb01cf5aa9324166473a240b5 on master.


Single-targeting net20 results in MSB4086

With <TargetFramework>net20</TargetFramework>, you get MSB4086:

A numeric comparison was attempted on "$(_TargetFrameworkVersionWithoutV)" that evaluates to "" instead of a number, in condition " '$(_TargetFrameworkVersionWithoutV)' >= '4.5' ".
(C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.Sdk.BeforeCommon.targets, line 86)

With <TargetFrameworks>net20</TargetFrameworks> all is well.
Build 15.0.26014.0

This issue was moved to dotnet/sdk#533


Last Opened Page

Helli,
How can i setup to open at last page viewed? i do not want to open pdf all time from first page.
Thanks.

I want this option too , Did you find a solution for that ?
Can you tell it to me if you found some thing ?!?!

No, i could not yet.
zahraasg<EMAIL_ADDRESS>9 Mar 2019 Cmt, 14:52 tarihinde şunu
yazdı:

I want this option too , Did you find a solution for that ?
Can you tell it to me if you found some thing ?!?!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Alua-Kinzhebayeva/iOS-PDF-Reader/issues/85#issuecomment-471170596,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAr9b1k0o4-zP4_QJbeto4lF_zGDu2Vpks5vU6BvgaJpZM4SSQf8
.

Hi.
Has anyone got solution for this?


Adding API schema for initial means assessment process

What
https://dsdmoj.atlassian.net/browse/LASB-775
An apo schema definition has been added for the initial means assessment processing.
Describe what you did and why.
Checklist
Before you ask people to review this PR:

[ ] Tests should be passing: ./gradlew test
[ ] Github should not be reporting conflicts; you should have recently run git rebase master.
[ ] Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
[ ] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[ ] You should have checked that the commit messages say why the change was made.

schema completed


Transaction History

As a user
I want to have access to my transaction history
So I am able to review past transactions for malicious transactions and to be able to tie transactions to a certain time and user/account.
AC:

[ ] User is able to see outgoing and incoming transactions for a selected account
[ ] User is able to see time, quantity, token type and accounts of every transaction

Note:

Should users be able to see block height of every transaction?
Should the transactions be filterable?
Should the user be able to get detailed information on transaction partners?
Should the user be able to see bonded atoms as well?

First proposal for transactions-format (extracted from CardTransaction.vue and extended):
(Please revise critical, as I am a noob on the topic)
[{   tx: {     inputs: [{       sender: String,       coins: [{         amount: Number,         denom: String       }]     }]     receiver: String   },   time: DateTime }]

We'll probably want a height field in there somewhere, possibly in the outer object

That would be the block height of the transaction?
I revised the format.

What about transaction-id and fees?

First look seems okay. Question about multi-input/outputs. Either we support them fully or not at all. The simple form is:
[{
  tx: {
    input: {
      sender: String,
      coins: [{
        amount: Number,
        denom: String
      }]
    },
    receiver: String
  },
  time: DateTime,
  height: Number
}]

which is perfect for one sender and receiver (turned array of inputs into one item).
If we want to support multiple senders/receivers (which is allowed in the app, but not exposed in the ui at all):
[{
  tx: {
    inputs: [{
      sender: String,
      coins: [{
        amount: Number,
        denom: String
      }]
    }],
    outputs [{
      receiver: String,
      coins: [{
        amount: Number,
        denom: String
      }]
    }]
  },
  time: DateTime,
  height: Number
}]

then we show every transaction that includes this account as any input or any output.
Note: I discussed the indexing with anton, and it seems the indexer doesn't support indexing multiple sender and receivers on one transaction. It might be simple to enforce only one sender and receiver, in the ui and the api. The app supports this since forever, but it is never used afaik. But enforcing only one in the UI would require approval from someone (probably @jaekwon )

I also think we should allow attaching short notes to each tx (data field to be processed by receiver eg. ref number for paying an invoice), but that is not supported in the backend

I vote for the complex format you posted. If it is possible to have multiple in- and outputs (using the cli) this needs to be reflected in the UI somehow or users will miss crucial information.
@melekes is it possible, that the indexer supports multiple senders/receivers in the future or will this never be possible?

Summing up a discussion with Frey:

There will be no default availability of transaction history

Only selected nodes will provide a full history you can query
You can setup you own full-node that provides you with the history

This appears to be desired so people setup full-nodes...
We then strongly need to have a manual selection of the full-node

You can subscribe to transactions based on sender/receiver

You will only get those transactions you are currently subscribed on (no historical ones)

Identifying use cases

Get transactions by sender X
Get transactions by receiver X

@nylira here we discussed the transaction format

that the indexer supports multiple senders/receivers in the future or will this never be possible?

so multiple keys can be indexed
  "sender": "Adam",
  "sender": "John"
}

but there is no way right now to query for both
ideally, we need OR
sender = 'Adam' OR sender = 'John'

or IN
sender IN ('Adam', 'John')

In the future, it will be totally possible to provide complex queries. I am going to push for implementing https://github.com/postgrespro/jsquery format (or a subset), which allows for building complex queries.

All single parts are tested. Waiting for the release of gaia-2-dev network with activated indexing.


Specify that Platforms SHOULD NOT reuse IDs

What is the problem this PR solves?
Closes #447
Checklist:

[x] The swagger.yaml doc has been updated with any required changes
[x] The openapi.yaml doc has been updated with any required changes

This PR conflicts with PR #680. If the ID can be reused, which state should last_operation return?

I think that same logic could apply elsewhere in the spec (fetching an instance maybe?), but the mitigation here is that there is an operation field which could be used to reference a specific operation.

We discussed this on today's call, and we concluded that we don't believe Platforms should reuse IDs. Some brokers wouldn't support this anyway, and in reality it seems very unlikely to happen since both CF and svc-cat generate a new GUID for each service instance.
Our options:

Close this PR and do nothing about this
Change the spec to say that platforms SHOULD NOT reuse IDs, and advise brokers what they should do in case that does happen

Review please @jberkhahn @tinygrasshopper


add the maid_status tag so it can be used downstream in emails

i'm extremely wary of actions having to modify the cached resource representation to reflect their activity, its not something that can be extrapolated generally and rather than doing it piecemeal, i'd rather avoid it entirely. in this specific case its unclear what the value add is, the policy that generated the message is available at render time re the actual tag message template, and is the same across the resources, so modifying each resource to the value extraneous.

If I infer the future date of an action from the policy, if the mailer runs say 2 days after c7n put the message on the sqs queue, I would tell the user the wrong future date of an action. In practice this isn't likely to happen, since the mailer keeps running in a loop.
Another concern is needing to parse the various actions and print them out in jinja (it's easier if I have the tag).
Can you comment with your jinja function that parses a policy to get the future action?


Empty body returned by the Cleaner. clean() method if a dirty document has style tag containing css/js attributes.

I am trying to sanitize a HTML document, the document has script as well as style tag. Now the problem I am facing is, the clean method returning the cleaned document with an empty body if the dirty document has  attribute containing CSS attributes/scirpt. I have added style tag in the whiltelist.relaxed ()..addTags("script","style"), still it is ignoring the whole body content and returned the empty body.
Here is the Whitelist defined:
private final static Whitelist WhiteListNoImg =  Whitelist.relaxed().
preserveRelativeLinks(true)
.addTags("span", "head", "body", "html", "div")
.addTags("script","style")
.addAttributes("head", "script","meta")
.addAttributes("script", "type")
.addAttributes("div", "id","class","span")
.addAttributes("span", "class")
.addAttributes("img", "src","class")
.addAttributes("body", "id","class","script","div","span","table", "style")
.addAttributes(":all","script")
.addAttributes(":all", "style")
.addAttributes("table", "border","img","class")
.addAttributes("table", "style")
.addAttributes("table", "cellpadding")
.addAttributes("table", "cellspacing")
.addAttributes("a", "target", "style")
.addAttributes("td", "valign")
.addAttributes("td", "align").
addAttributes("td", "height")
.addProtocols("img", "src", "cid", "data");
and here is the representation of a HTML document content that I am trying to sanitize/clean.
`


Agriculture AR

          Nils will try to find the missing datasets.

Originally posted by @ratnanil in https://github.com/sunwell-foss/sonnenland/issues/8#issuecomment-1540607436

I ordered this dataset, hoping to get it soon..

I got this data


[Apache] rename to apache package

Feature Description (功能描述)
we expect apache package name like: org.apache.hugegraph.xx

As the package changing could introduce some side effects, please change the package name after the project is accepted as poddling project.

@WillemJiang Thank you. Ok, we suspend this task and restart it until it is accepted.


Import BOM reflectivity nc files, and converting from dBZ to rainrate or raindepth

Working on a project to compare radar data for two historical floods using the AURA historical ground reflectivity dataset.
Firstly, when trying to import BOM nc using the bom_rf3 importer, it only works where there is a "precipitation" key. However, the ground reflectivity uses a "reflectivity" key. Would it be best to create my own importer plugin? For now, I've just manually changed the importers.py in my python environment to add an additional elif statement to check for "reflectivity".
https://github.com/pySTEPS/pysteps/blob/917c83b28e17af9bff9e064df800f8e136bc0463/pysteps/io/importers.py#L459
    if "precipitation" in ds_rainfall.variables.keys():
        precipitation = ds_rainfall.variables["precipitation"][:]
    elif "reflectivity" in ds_rainfall.variables.keys():
        precipitation = ds_rainfall.variables["reflectivity"][:]
    else:
        precipitation = None

https://github.com/pySTEPS/pysteps/blob/917c83b28e17af9bff9e064df800f8e136bc0463/pysteps/io/importers.py#L540
    if "precipitation" in ds_rainfall.variables.keys():
        if "units" in ds_rainfall.variables["precipitation"].ncattrs():
            units = getattr(ds_rainfall.variables["precipitation"], "units")
            if units in ("kg m-2", "mm"):
                geodata["unit"] = "mm"
    elif "reflectivity" in ds_rainfall.variables.keys():
        if "units" in ds_rainfall.variables["reflectivity"].ncattrs():
            units = getattr(ds_rainfall.variables["reflectivity"], "units")
            if units in ("dBZ"):
                geodata["unit"] = "dBZ"

Also converting from dBZ to mm/hr should first be converted to linear units before applying the ZR function?
https://github.com/pySTEPS/pysteps/blob/917c83b28e17af9bff9e064df800f8e136bc0463/pysteps/utils/conversion.py#L96
        R = (10**(R/10) / zr_a) ** (1.0 / zr_b)

Or is this working as intended, and I should just convert dBZ to linear units first before passing to the conversion function? E.g.
R, metadata = conversion.to_rainrate(10**(R/10), metadata)

Hi @jandye , I think it'd make sense to extend the existing BOM importer to reflectivity values. Perhaps @cvelascof can provide a quick feedback on this, but I think we would welcome a PR in that sense.
Concerning your question for the conversion from dBZ to rainrates, the transformation to linear units is already included in the method, see https://github.com/pySTEPS/pysteps/blob/917c83b28e17af9bff9e064df800f8e136bc0463/pysteps/utils/conversion.py#L57, so you don't need to do it (provided that the metadata transform is correctly set to dB). Does this answer your question?


"error":{"code":-32601,"message":"Method not found"},"jsonrpc":"2.0"}

I cant't getbalances
curl <IP_ADDRESS>:8197/json_rpc  -d '{"method":"getbalances","params":{"address":""}}'
why Method ont found?

RPC Walletd: gets the HASH value by transaction received, ID.
How to get transaction received, ID?
Thanke you!

What did you try to do?
you can use getTransaction with the txHash


Unexpected Strings must use singlequote error - Conflicting with another rule

module.exports = {
  env: {
    browser: true,
    es6: true,
    node: true,
    jest: true,
  },
  parser: '@typescript-eslint/parser', // Specifies the ESLint parser
  extends: [
    'plugin:react/recommended', // uses react-specific linting rules
    'plugin:@typescript-eslint/recommended', // uses typescript-specific linting rules
    'plugin:import/errors',
    'plugin:import/warnings',
    'plugin:import/typescript',
    'plugin:prettier/recommended', // enables eslint-plugin-prettier and eslint-config-prettier
    'prettier/react', // disables react-specific linting rules that conflict with prettier
    'prettier/@typescript-eslint', // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier
    'plugin:jsonc/recommended-with-json', // JSON formatting
    'plugin:jsonc/prettier', // JSON formatting
  ],
  rules: {
    quotes: ['error', 'single', 'avoid-escape'], // single for .js
    'jsonc/quotes': ['error', 'double', { avoidEscape: false }], // double for .json
  },
}

yarn eslint src/app/locales/en-US.json

...
  2314:7   error  Strings must use singlequote  [quotes]
  2314:9  error  Strings must use singlequote  [quotes]
  2314:20   error  Strings must use singlequote  [quotes]
...
etc

eslint 7.32.0
eslint-plugin-jsonc 2.3.1
Any ideas? :)

I can't reproduce your problem. Please provide a repository to reproduce the problem.

Ok, ill try creating one :)

I may have just predicted your problem. You may need to respecify the parser.
https://github.com/ota-meshi/eslint-plugin-jsonc#parser-configuration
If you don't configure the parser, eslint will usually try to parse JSON as JS and you'll get a parsing error, but you may happen to have JSON that can be parsed as JS. But it's not JS, so the check rules report incorrectly.

Yes im trying to work with that at the moment:
  overrides: [
    {
      files: ['*.json', '*.json5', '*.jsonc'],
      parser: 'jsonc-eslint-parser',
    },
    {
      files: ['*.ts', '*.tsx'],
      parser: '@typescript-eslint/parser',
      parserOptions: {
        project: './tsconfig.json',
      },
    },
  ],

But getting the error:
Error: Error while loading rule '@typescript-eslint/naming-convention': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.

Even though parserOptions.project is clearly defined now.. 🤷♂

@typescript-eslint/naming-convention cannot check JSON. That's because JSON parser doesn't provide type information. You need to turn off the rule for *.json or configure extends for each extension in the overrides section.

Oh cool.
I moved ALL existing rules into the .ts/tsx block
works now 🎉 thanks alot


DS2 T5 model is released now

Dear authors,
I saw that your paper experimented with our code so quickly, and I'm very happy to see such great progress from your work.
I released the T5 versions recently so if you want to compare it on 2.4, you can check our repository for the updates.
Note that our code used the 40GB NVIDIA Tesla A100 GPU (single GPU) to fine-tune the T5-large model so it may not work well with DDP with smaller ones, as we did not try.
Please let me know if there are any issues.
p.s. if you could modify the citations to the bibtex I posted in the code, that would be also much appreciated!
Best,
Jay

Thanks for letting us know! We will update the numbers and the bibtex in later versions of this paper


Add test for querying limited transmission with specified slug and date range

Test GET API /transmission/slug/{slug}/start/{start}/end/{end}/{limit}
Original issue https://github.com/edgexfoundry/edgex-go/issues/1335

I test on my side, but it works fine. I thought the docker image is not updated before the test run.
I will check the test result after the Jenkins run test again.
source ./bin/env.sh
docker-compose pull
sh deploy-edgeX.sh
sh ./bin/run.sh -sn
...
...

↳ Query limited transmissions with specified slug and created date range
  GET http://edgex-support-notifications:48060/api/v1/transmission/slug/notice-025/start/1558653868391/end/1558654168391/5 [200 OK, 1.85KB, 13ms]
  ✓  Status code is 200
  ✓  Response time is less than 800ms
  ✓  Content-Type is present
  ✓  Response count is correct
  ✓  Content-Type is application/json
  ✓  Response body is correct
  ✓  Is valid response schema

the Allure report is clean now.  close this issue


Compile for android error

[DCC Error] superobject.pas(642): E2154 Type 'TSuperTableString' needs finalization - not allowed in variant record
[DCC Error] superobject.pas(643): E2154 Type 'TSuperArray' needs finalization - not allowed in variant record

@devzonetrack I guess this library is not compatible with Android, as it uses windows specific libraries as winhttp and wininet for connectivity. Even if you are able to compile it will most certainly not work.
You might want to use Delphi's REST Client as it is compatible with Android: http://docwiki.embarcadero.com/RADStudio/Tokyo/en/Tutorial:_Using_the_REST_Client_Library_to_Access_REST-based_Web_Services

@fabioxgn, Thank for advice...


[scan] Taint Analysis Queries & Re-use

The goal of this is to re-use as much of the query DB mechanisms as possible, while only having reachableByFlows run once for this subset.
Right now, queries define some subset of sources and sinks, but any source flowing to any sink is a problem. This changes allows queries tagged with taint + [source|sink|sanitizer] to be included in the taint analysis scan, where flows and results are gathered dynamically.
Additionally, only the language's semantics are included in this scan.
Note: It appears that joern-scan options regarding query filtering are not being propagated.

Will be following up with some rules for JavaScript and Python based on some benchmarks I'm running

I feel this might be best as a standalone tool somewhere else, closing this for now


feat: add error tracker (sentry.io)

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #834

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

so it's already working? duh :D

ok let's try to have it


Stopped working again

Describe the issue
Since 8 hours ago the service stopped work (no sensor updates or no service)
Expected behavior
be able to get data and send service commands
Which Home Assistant version are you using?
core-2021.8.6
What was the last working version of Home Assistant Core?
core-2021.8.6
What is your region?
Rest of world
ConnectedDrive website

[X] I can still successfully login to the BMW ConnectedDrive website and the car status is available there.
[X] I have ConnectedDrive enabled for my vehicle.

Number of cars

[ ] I have 2 or more cars linked to the ConnectedDrive account.
[ ] I have a Mini vehicle linked to my account.

Output of bimmer_connected fingerprint
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response

Where are you located? rest_of_world works for me.
Can you provide the output of bimmerconnected status ...?

Sweden (rest_of_world)

File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service
await self._hass.async_add_executor_job(handler.job.target, service_call)
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/init.py", line 239, in execute_service
function_call()
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/remote_services.py", line 196, in trigger_remote_air_conditioning
self._trigger_remote_service(_Services.REMOTE_AIR_CONDITIONING, post=True)
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/remote_services.py", line 209, in _trigger_remote_service
return self._account.send_request(url, post=post, data=data)
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/account.py", line 213, in send_request
raise IOError(msg)
OSError: The BMW Connected Drive portal returned an error: UNKNOWN_ERROR (received status code 400 and expected 200).
2021-08-13 10:27:19 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [xxx] Error handling message: Unknown error
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 25, in _handle_async_response
await func(hass, connection, msg)
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 525, in handle_execute_script
await script_obj.async_run(msg.get("variables"), context=context)
File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 1219, in async_run
await asyncio.shield(run.async_run())
File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 353, in async_run
await self._async_step(log_exceptions=False)
File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 371, in _async_step
await getattr(self, handler)()
File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 571, in _async_call_service_step
await service_task
File "/usr/src/homeassistant/homeassistant/core.py", line 1491, in async_call
task.result()
File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service
await self._hass.async_add_executor_job(handler.job.target, service_call)
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/init.py", line 239, in execute_service
function_call()
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/remote_services.py", line 196, in trigger_remote_air_conditioning
self._trigger_remote_service(_Services.REMOTE_AIR_CONDITIONING, post=True)
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/remote_services.py", line 209, in _trigger_remote_service
return self._account.send_request(url, post=post, data=data)
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/account.py", line 213, in send_request
raise IOError(msg)
OSError: The BMW Connected Drive portal returned an error: UNKNOWN_ERROR (received status code 400 and expected 200).
2021-08-13 10:29:17 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [xxx] The BMW Connected Drive portal returned an error: UNKNOWN_ERROR (received status code 400 and expected 200).
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 185, in handle_call_service
await hass.services.async_call(
File "/usr/src/homeassistant/homeassistant/core.py", line 1491, in async_call
task.result()
File "/usr/src/homeassistant/homeassistant/core.py", line 1526, in _execute_service
await handler.job.target(service_call)
File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 213, in handle_service
await self.hass.helpers.service.entity_service_call(
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 658, in entity_service_call
future.result()  # pop exception if have
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 856, in async_request_call
await coro
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 695, in _handle_entity_call
await result
File "/usr/src/homeassistant/homeassistant/components/lock/init.py", line 149, in async_unlock
await self.hass.async_add_executor_job(ft.partial(self.unlock, **kwargs))
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/lock.py", line 56, in unlock
self._vehicle.remote_services.trigger_remote_door_unlock()
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/remote_services.py", line 174, in trigger_remote_door_unlock
self._trigger_remote_service(_Services.REMOTE_DOOR_UNLOCK, post=True)
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/remote_services.py", line 209, in _trigger_remote_service
return self._account.send_request(url, post=post, data=data)
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/account.py", line 213, in send_request
raise IOError(msg)
OSError: The BMW Connected Drive portal returned an error: UNKNOWN_ERROR (received status code 400 and expected 200).
2021-08-13 10:30:26 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [xxx] The BMW Connected Drive portal returned an error: UNKNOWN_ERROR (received status code 400 and expected 200).
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 185, in handle_call_service
await hass.services.async_call(
File "/usr/src/homeassistant/homeassistant/core.py", line 1491, in async_call
task.result()
File "/usr/src/homeassistant/homeassistant/core.py", line 1526, in _execute_service
await handler.job.target(service_call)
File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 213, in handle_service
await self.hass.helpers.service.entity_service_call(
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 658, in entity_service_call
future.result()  # pop exception if have
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 856, in async_request_call
await coro
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 695, in _handle_entity_call
await result
File "/usr/src/homeassistant/homeassistant/components/lock/init.py", line 141, in async_lock
await self.hass.async_add_executor_job(ft.partial(self.lock, **kwargs))
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/lock.py", line 47, in lock
self._vehicle.remote_services.trigger_remote_door_lock()
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/remote_services.py", line 162, in trigger_remote_door_lock
self._trigger_remote_service(_Services.REMOTE_DOOR_LOCK, post=True)
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/remote_services.py", line 209, in _trigger_remote_service
return self._account.send_request(url, post=post, data=data)
File "/usr/local/lib/python3.9/site-packages/bimmer_connected/account.py", line 213, in send_request
raise IOError(msg)
OSError: The BMW Connected Drive portal returned an error: UNKNOWN_ERROR (received status code 400 and expected 200).

Ah, yes. Remote services are not yet available again (see https://github.com/home-assistant/core/issues/54524, #310).
Closing this one as it is already tracked.


Reduce highest version to TLS 1.2 for non TLS 1.3 Cipher Preferences

Please note that while we are transitioning from travis-ci to AWS CodeBuld, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Issue # (if available):
#1608, #1439
Description of changes:

this allows tls 1.3 to be enabled safely without affecting existing connections using tls1.2 only/non-tls1.3 ciphers cipher preferences
add test_all_tls12 cipher preference for all non tls1.3 ciphers
renamed test_tls13_null_key_exchange_alg to test_all_tls13

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (tls12_cipher_versions@08d84ff). Click here to learn what that means.
The diff coverage is n/a.