PT-BR translation for README.md

I'm thinking in writing a translation for the readme file in pt-br. I know a lot of friends here in Brazil that uses this lib and actually can't speak/read english. What do you guys think about it and how should we make that? (I'm willing to translate)

This seems like a great idea. One example I know of is https://github.com/casey/just which has a Chinese README.中文.md file and a message at the top of the English README.md linking to it.
One way to improve that could be to make a README/ folder and put all translated copies of the README.md file in that folder.

Nice! I'll aproach to the link in the top of readme. Could you assign me the task plz?

Fantastic, I've assigned you @gustavomfb!

Done! Alredy linked the PR

Fantastic, I've assigned you @gustavomfb!

Let me know when u guys can make the review. It's a college project for Open Dev that i have to full translate a big git project!
@AetherUnbound


Fix a minor REPL bug with commented out lines.

REPL should clean out the comments when breaking down the query text.
Otherwise it's possible to make REPL submit an empty query (type up a
comment and hit Alt+Enter) and cause a ProtocolError by not having an
actual query.

Sure. There is a test for that: https://github.com/edgedb/edgedb-rust/blob/master/edgeql-parser/tests/preparser.rs#L38-L43


route all errors not explicitly mapped to the sad cloud error page to hide tomcat server information

Coverage remained the same at 86.039% when pulling a9eba3f82f2708cef43e02d4a59ee94ec8ac7441 on GESoftware-CF:patch/route-all-errors-to-error-page-to-hide-tomcat-default into 6ed5d1254b9880d0a54817651e85a8f81653b75a on cloudfoundry:develop.

Coverage remained the same at 86.039% when pulling 4dfe832d24d60cb345e3b682fa7eddfef1028fca on GESoftware-CF:patch/route-all-errors-to-error-page-to-hide-tomcat-default into 6ed5d1254b9880d0a54817651e85a8f81653b75a on cloudfoundry:develop.

Coverage decreased (-2.6%) to 83.45% when pulling 4dfe832d24d60cb345e3b682fa7eddfef1028fca on GESoftware-CF:patch/route-all-errors-to-error-page-to-hide-tomcat-default into 6ed5d1254b9880d0a54817651e85a8f81653b75a on cloudfoundry:develop.


Add support for mermaid visualizations

:sparkles: Add support for Mermaid JS visualizations.

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   99.96%   99.96%
=======================================
  Files         166      166
  Lines        2924     2924
=======================================
  Hits         2923     2923
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f7a44...4588431. Read the comment docs.


[FEATURE] altering table can't support to add new partition column？

Describe the feature
iceberg table has the feature of Partition Evolution。
so，Can  gravitino api support this feature like this？
Table sampleTable = ...;
sampleTable.updateSpec()
.addField(bucket("id", 8))
.removeField("category")
.commit();
Motivation
No response
Describe the solution
No response
Additional context
No response

Yes, it's not supported yet, is this a product requirement for you?

yes ,tbds's product requirement

@mygrsun, reasonable requirement, we have not planned yet, do you have any interest or time to work on this?


New version: kevinboss.port version 1.6.2

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot run

/AzurePipelines run


Feature Requests - stats & pruning

Hi,
Some useful features to consider integrating into this plugin.
Podman disk stats
A very useful ability is seeing podman disk size usage presented in the GUI as some stats.
Maybe as a stats section after the tree section?
Why is this useful, podman disk usage includes overlays (or stacked if using VFS) as separate counts giving a true representation of consumed size, not just actual disk usage. Handy when using overlays and yet wanting to see disk consumption impacts for those living with VFS, or seeing container leaking over time, or just needing to claw back disk space.
As the system call is expensive, perform once asynchronously on startup and maybe once every hour or on explicit demand. Separate to normal refresh.
> podman system df
TYPE           TOTAL       ACTIVE      SIZE        RECLAIMABLE
Images         28          2           42.61GB     39.42GB (93%)
Containers     2           0           2.097GB     2.097GB (100%)
Local Volumes  1           2           364.1MB     0B (0%)

Podman container stats
See container resource usage in a similar manner to disk stats. Useful for container development and packaging and understanding resource consumption. Bonus points if over time graphing is available.
> podman stats -a --no-stream
ID            NAME           CPU %       MEM USAGE / LIMIT  MEM %       NET IO       BLOCK IO    PIDS        CPU TIME    AVG CPU %
1baa6a2d3bef  cool_goldberg  0.12%       204.8kB / 4.105GB  0.00%       430B / 110B  0B / 0B     3           613.006ms   0.12%
745878eb12e4  reverent_jang  0.12%       213kB / 4.105GB    0.01%       430B / 220B  0B / 0B     3           617.938ms   0.12%

Ability to prune
Podman / Docker does not clean up after itself. Having ability to do house keeping is nice. Especially when seeing disk stats grow!

Remove all images not associated to containers (dangling):   podman image prune -f
Remove all images not in use by containers (unused and dangling): podman image prune -a -f
Remove podman building cache: podman builder prune -a -f

Show all images
Have a new separate tree arm that lists all images (includes dangling and unused) or every image but used to complement the existing image arm. Example below shows all images. Explains why reclaimable images percentage is so high and disk space disappearing (especially for those using VFS). Using a separate arm or separate display to normal images reduces noise.
> podman image list -a
REPOSITORY                                                                                TAG         IMAGE ID      CREATED      SIZE
localhost/vsc-fgtlint-8fda9119732bb8ec300cf3b85c265d4f998531c1a72ec8b8abe8b920b5a49c38-uid  latest      5b985f37b68d  2 days ago   1.6 GB
<none>                                                                                <none>      88eeafb0e5bd  2 days ago   1.6 GB
<none>                                                                                <none>      7714ca47bda1  2 days ago   1.6 GB
<none>                                                                                <none>      7cd451bf8385  2 days ago   1.6 GB
<none>                                                                                <none>      65f7f8d0847e  2 days ago   1.6 GB
<none>                                                                                <none>      d66f004d8377  2 days ago   1.6 GB
<none>                                                                                <none>      a9cbfec9d055  2 days ago   1.6 GB
<none>                                                                                <none>      7e5db97c6188  2 days ago   1.6 GB
localhost/vsc-fgtlint-8fda9119732bb8ec300cf3b85c265d4f998531c1a72ec8b8abe8b920b5a49c38      latest      c507893ba791  2 days ago   1.6 GB
localhost/vsc-gatus-c8c17f4cfe5f8c84b924659c4dc01e53f7d29686fdfc31554167fd57774a4d7d-uid    latest      21f72f45d592  2 days ago   1.6 GB
<none>                                                                                <none>      f3555827d62a  2 days ago   1.6 GB
<none>                                                                                <none>      52c360a7fd18  2 days ago   1.6 GB
<none>                                                                                <none>      e76bfebafe97  2 days ago   1.6 GB
<none>                                                                                <none>      054b5f9a0000  2 days ago   1.6 GB
<none>                                                                                <none>      86dee9ee395c  2 days ago   1.6 GB
<none>                                                                                <none>      771f31edf1c1  2 days ago   1.6 GB
<none>                                                                                <none>      96f6f6d9e6ea  2 days ago   1.6 GB
localhost/vsc-gatus-c8c17f4cfe5f8c84b924659c4dc01e53f7d29686fdfc31554167fd57774a4d7d        latest      7c524681c86b  2 days ago   1.6 GB
<none>                                                                                <none>      35332a1996b4  2 days ago   1.6 GB
<none>                                                                                <none>      6b33fd6394dd  2 days ago   1.54 GB
<none>                                                                                <none>      b7bb890de10d  2 days ago   1.54 GB
<none>                                                                                <none>      ad008383e5fb  2 days ago   1.54 GB
<none>                                                                                <none>      9da399370b3d  2 days ago   1.54 GB
<none>                                                                                <none>      2b43342bd06a  2 days ago   1.54 GB
<none>                                                                                <none>      440fbe4e6010  2 days ago   1.54 GB
mcr.microsoft.com/devcontainers/go                                                          1-bullseye  fed459442993  9 days ago   1.54 GB
mcr.microsoft.com/vscode/devcontainers/go                                                   1-bullseye  fed459442993  9 days ago   1.54 GB
docker.io/library/alpine                                                                    latest      324bc02ae123  5 weeks ago  8.09 MB

@NothingTooSerious ok...I will add these in later updates🤝

The colour indicator works well! Immediate visual impact of what is and isn't required.
Overview info is great. Just having that info in the same place saves time and increases awareness. Only nit-pick is the formatting is off, but that is a very minor visual impact and is because of being part of a tree element rather than a table element.
Very cool to have this now available!
Looks like the podman stats command has unmet requirements. Cgroup V2 is needed where podman is running for stats to work. This is documented in podman stats man page. Looks like it is a feature that relies on the server being configured correctly.
Regardless of the extension, be interesting to know why your podman and cgroups v2 is broken.

@NothingTooSerious Thanks😊...I am not sure why is the stats not working..I am trying to find it out😊

Nicely done. Thank you.


Refactor with Swift 4 String API

As you know, Swift 4 has new String API. I have refactored all warnings related to deprecated substring(from:) method.

Hm, which Swift version used in Travis CI?..


ACT-683: Edit and Delete target periods Vue modal

What is the Purpose?

Finish Update and delete functionality for target periods

What was the approach?

Updated Django view to enable delete and update multiple target periods.
Update modal to be dynamically created with target periods if they exist and allow users to edit them.
Delete target periods if they existed.

Are there any concerns to addressed further before or after merging this PR?
The create target periods' logic changed a bit. Please test the entire CRUD operation, from creating target periods to deleting them.
Mentions?
@andrewtpham @ninetteadhikari @IvyMMutiso
Issue(s) affected?
ACT-683
ACT-557
ACT-722

Small change: change label from Add/Edit Target Periods to Target Periods


[PW-3652] bug fix in payment methods filter

Summary

Fixed bug in payment methods filter for checkout page, that allowed PMs not returned by the /paymentMethods call to still be displayed in checkout
Tested scenarios

iDeal does not show up for Belgium address
OneClick PMs do show up if they exist

Could you also add OneClick PMs to the tested scenarios? Basically checking if OneClick PMs do show up

@acampos1916 yes this is also tested and they do show up. I've updated the PR description.


fix(connlib): roaming whilist having dns as a resource

With this changes, we resolve a list of known hosts at the start of the program.
We use this, to prevent going to a DNS resolver as a resource, since if we roam, we don't have a connection to actually resolve the portal IP.
TODO: I'll write a better description

I opened https://github.com/firezone/firezone/pull/5574 to give us debug Android builds from CI so you don't have to build it locally for testing.

@thomaseizinger Should we merge this to test new clients on main?

@thomaseizinger Should we merge this to test new clients on main? I don't know if we can get a release build for Windows in this PR

Yeah we can merge it. I'll test it on my phone as well though.

@thomaseizinger Should we merge this to test new clients on main? I don't know if we can get a release build for Windows in this PR

Yeah we can merge it. I'll test it on my phone as well though.

Roaming works flawlessly now with the Quad9 policy enabled.


Redis cluster host configuration

Hello, could you help me out? I am trying to configure redis-cluster with Spring Boot Java application, but I can't link my app server with redis cluster, docker-compose:
version: '2.1'
services:

app:
    image: my-app
    command: -m 512m
    ports:
     - "8000:8000"
    environment:
      - REDIS_CLUSTER_NODES=redis-cluster:7000,redis-cluster:7001,redis-cluster:7002
    depends_on:
      - redis-cluster

 redis-cluster:
    image: grokzen/redis-cluster:4.0.8
    environment:
     - CLUSTER_ONLY=true
    ports:
     - '7000-7005:7000-7005'

but, it does not work, I get:
org.springframework.data.redis.RedisConnectionFailureException: Could not get a resource from the pool; nested exception is redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool

I have a similar issue. The issue seems to be related to this update: ccd7f28b7456a3c2dc3c6e3cdd3860509e6708b3
CLUSTER SLOTS look like this now
redis-cluster:7000> CLUSTER SLOTS
1) 1) (integer) 10923
   2) (integer) 16383
   3) 1) "<IP_ADDRESS>"
      2) (integer) 7002
      3) "775e23a8a5351fd0a8eb0de7dd1861409b036cbc"
   4) 1) "<IP_ADDRESS>"
      2) (integer) 7005
      3) "b69c482fb6271e48321caf2320f5b6ff696a15d8"
2) 1) (integer) 5461
   2) (integer) 10922
   3) 1) "<IP_ADDRESS>"
      2) (integer) 7001
      3) "ae6467d2cf3189ee0f3443b8cdbdabcae19bd8d3"
   4) 1) "<IP_ADDRESS>"
      2) (integer) 7004
      3) "8f1638ab65435a115a4477f6639cad6b1a31250a"
3) 1) (integer) 0
   2) (integer) 5460
   3) 1) "<IP_ADDRESS>"
      2) (integer) 7000
      3) "039978e2f9fbb2f5a8434f431fda768c6e45a4b2"
   4) 1) "<IP_ADDRESS>"
      2) (integer) 7003
      3) "559118efacb2cc80c3cd299742aa3da87327972b"

I'm not too sure about the inner working of redis-cli, but it looks like the application can connect correctly to the cluster, is then given the IP of a subsequent node to connect to, and then fails, because it's given <IP_ADDRESS> instead of the containers ip. (the app and the cluster run on different containers).
I tested on grokzen/redis-cluster:3.2.11. Reverting the commit that I pointed above solves the issue.

I agree. I am having the exact same issue. Reverting the above commit fixes the problem. Why was the <IP_ADDRESS> setting added?

@yinzara The change was done becuase of Mac users that had issues with connecting to their redis instances on OSx. The change was tested on linux systems as well and it was working there so i merged the changes. My guess is that you have some difference in your docker setup, different versions, network setup or something that gives you some other IP address internally in redis when a cluster is built and you are not able to connect to that IP address from your host machine. I would suggest that if you have issues after the mentioned commit that you investigate your local docker env, upgrade docker, compose, check network config etc

If you have all redis nodes accessible on different ports on the host, you can effectively access all nodes using the same IP (the host IP) as long as you are on the host when resolving that <IP_ADDRESS>.
That's the assumption that's been made with the commit that I pointed.
But take the 2 following cases:

An app on the same docker subnet as the redis cluster
An app on a different machine than the host, accessing the cluster through the host port

In those 2 situations, the application will try to connect to a cluster node by hitting <IP_ADDRESS> (it's own IP), which will obviously fail.

This affects me too. In my case I'm trying to set up CI on GitLab and using the docker image as a service during my testing. As the image is spun up in it's own linked container I hit the same issue.
As far as I can tell there's no good way to configure around this for my pipeline. I can add aliases for the redis container, or change the entrypoint or the command, but that's it. I've had to go back to an image based on dc4a63e872 to get things working.
Perhaps a toggle could be added to the entrypoint script to change between the two behaviours? Happy to submit a PR if that's an acceptable solution.

Yes i have been thinking about a toggle/env variable aswell for this. Basically reverting back to the old way and have a option to specify what IP you want to use in the shell script.


Updating bigint with FromStr trait for issue 81

This is my intent for issue 81
https://github.com/LNP-BP/rust-amplify/issues/81

We need to fix CI and add tests here. Please let me know if you would like to proceed with this PR further

We need to fix CI and add tests here. Please let me know if you would like to proceed with this PR further

Ok, i will see tonight or tomorrow. I will continue if you think it's worth it


SAK-31895 Wicket 6.25.0

https://jira.sakaiproject.org/browse/SAK-31895

@payten any issues with this minor wicket upgrade?

I looked at this the other day, all good.


Can not build ARM due to \build\bin\ARM\Release\GameAssembly.lib is missing

I'm trying to deploy my app to my HoloLens 2 and after "Start Without Debugging" I'm getting this error
Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK1181	Input file"C:\Users\MyName\MyOneDrive\Desktop\MyProject\build\bin\ARM\Release\GameAssembly.lib" was unable to open.	MyProject	C:\Users\MyName\MyOneDrive\Desktop\MyPrject\MyProjectName\LINK	1

I've worked through https://docs.microsoft.com/en-us/windows/mixed-reality/develop/platform-capabilities-and-apis/using-visual-studio#deploying-an-app-over-usb---hololens-2 this tutorial.
Versions:

Unity 2019.4.4f1
VS2019 16.7.6

Note: I have 2 errors in the Unity console.
First error:
Error: Could not load signature of Microsoft.Azure.Storage.Core.Auth.BlobSharedAccessSignatureHelper:GetSignature due to: Could not resolve type with token 01000030 (from typeref, class/assembly Microsoft.Azure.Storage.UserDelegationKey, Microsoft.Azure.Storage.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35) assembly:Microsoft.Azure.Storage.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 type:Microsoft.Azure.Storage.UserDelegationKey member:(null) signature:
Second error:
Unloading broken assembly Assets/Plugin/Microsoft.Azure.Storage.Blob.dll, this assembly can cause crashes in the runtime
But the build in Unity just worked fine for me.

@pbarnettms Can you assist or mention someone who can? (You're listed as the doc author)

Hi @Seajanjan, the issues with the Azure dll isn't related to the doc you're following or Visual Studio. Please see the support info on this page: https://docs.microsoft.com/en-us/hololens/hololens-feedback

@Seajanjan , did you figure out the origin?


Spike2IO chan_info problem

Apologies in advance - I am new to spike2 and to neo... I have a large number of smr files and would like to write some code to scrape the data all into one place in python.
I am trying to open smr files in python3.7 using neo v0.9.0.dev as follows:
reader = neo.Spike2IO(filename='example1.smr')
reader.read()[0]
but get the following error:
chan_info['type'] = dict_kind[chan_info['kind']]
KeyError: 255

I get this error for all smr files I have tried. Could it be a problem with how channels are defined in my files?
I have uploaded two example smr files
Cheers!
Dave

Hi Dave,
inded I can reproduc the bug.
Any idea what could be the channel with kind 255 ?
Is there something special in your recording.
What I can do is to bypass the channel with key 255 but maybe you will miss something in your file.
Would you be agree if if put in public acces your file to integrate it in our test suite ?
Samuel

Hi Dave,
the problem with theses file is more complicated.
It is not only a prblem of kind=255 with unknown channel type.

In short the channel binary header is somehow corrupted.
How did you get this file.
Is it a true smr generated by offcial spike2 ? Or a file converted by an external tools ?

Hi Samuel
thanks for looking into this.
I got these files by processing an initial smrx file with raw data using a Spike2 script witten by someone in the lab (who has since left). However, I also get the issue when trying to load the smrx file. Can smrx files be loaded? I have uploaded the original smrx file used to generate the original smr example files, as well as its associated s2rx file, to the same directory as before.
I don't believe there is anything in chanel 255.
I am happy for all the files shared to have public access and to be integrated into your test suite.
Thanks!
Dave

Hi Dave,
the smrx cannot be loaded. It is not implemented yet in neo.
Which tools did the conversion ?
Samuel

The files were converted within Spike2 itself using its scripting language. Perhaps the channel binary header is left over from the smrx file or something...

I get the same error when I try to read a .smrx file from Spike2. The code reader = neo.io.Spike2IO(filename='filename.smrx') produces KeyError: 255. I believe .smrx are 64 bit files and .smr are 32 bit. Hopefully, .smrx support can be added as neo seems like a great tool to help with processing ephys data.

Is there any update on this issue? I am interested in reading .smrx files from spike2 using neo package but it seems impossible like you mentioned. Is there any other way i could do this? May be using spikeinterface? any suggestions in this direction would be really helpful.

We could implement the smrx file format but we need the file format specification and a small file for testing.
If a spike2 user could contact CED for this and give us the format spec I would be happy to help for the implementation.

@samuelgarcia Thank you for your response. I have already contacted spike2 ced people they told me that they are developing pyson (matson is already available) library to read .smrx in python though it is work in progress and it will only work on windows. I can provide example .smrx file and the specifications too. Could you please provide me with your email id? Thank you.

Maybe if pyson is opensource maybe we should be able to infer the specification from the code. But my guess is that pyson will be only a wrapper on top of windows dll. So it will be very retrictive to use (win + closed dll). I think users should insist to have  spec.

http://ced.co.uk/de/downloads/contributed#SONPython This only supports .smr though.

I'm not sure if this helps you, but the workaround that I'm using is to use Spike2 to export the .smrx as a .mat, then read that .mat in Python using the h5py library.

@IanGMalone I thought about it already. There are many indirect solutions but we would like to minimise these steps.

@threefrenchhens @deeptimittal12 @IanGMalone :
could you check if the fix #824 (already merge in master) fix the problem ?
I think I lost theses files.

Sorry for the slow reply. I still get the same error message... I installed
what I believe is the latest merge using:
pip install git+git://github.com/NeuralEnsemble/python-neo
Altgough it still says I have version 0.9.0.dev...
On Thu, 23 Jul 2020, 14:38 Garcia Samuel<EMAIL_ADDRESS>wrote:

@threefrenchhens https://github.com/threefrenchhens @deeptimittal12
https://github.com/deeptimittal12 @IanGMalone
https://github.com/IanGMalone :
could you check if the fix #824
https://github.com/NeuralEnsemble/python-neo/pull/824 (already merge in
master) fix the problem ?
I think I lost theses files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NeuralEnsemble/python-neo/issues/777#issuecomment-663012173,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFPKEGBO3XY5VJL54SX4WBTR5A4N5ANCNFSM4JV3HFCQ
.

To be sure. Could you try pip uninstall neo and then pip install git+git://github.com/NeuralEnsemble/python-neo ?

Tried but still get the error...
On Mon, 24 Aug 2020, 10:49 Garcia Samuel<EMAIL_ADDRESS>wrote:

To be sure. Could you try pip uninstall neo and then pip install
git+git://github.com/NeuralEnsemble/python-neo ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NeuralEnsemble/python-neo/issues/777#issuecomment-679027709,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFPKEGFJ7DTAGPBZ7A4S5DDSCIZQ3ANCNFSM4JV3HFCQ
.

Hi all.
We have implemented CedIO (based on sonpy) that read both smrx and smr.
Could you try it on your files ?

Hi all.
We have implemented CedIO (based on sonpy) that read both smrx and smr.
Could you try it on your files ?

Not OP, but tested CedIO on smrx file.
The analogue channels are loaded normally but event channels are not loaded.
The API seems to be inconsistent with the SpikeIO from 0.9.0?


Use forked processes instead of pods to generate ignition payload

What this PR does / why we need it:
Before this commit, ignition payloads for nodepools were generated by
orchestrating MCO components using pods. This was a performance problem because
ignition server restarts (e.g. during upgrades) resulted in thundering herds of
ignition payload generation pods, limiting overall cluster capacity.
This commit refactors ignition payload generation away from pods and to a
mechanism that extracts MCO binaries (and supporting files) from release
payloads so they can be forked as subprocesses of the ignition server
controller, removing all pod scheduling overhead. This change should be
completely transparent to the end user and is a drop-in replacement for the old
implementation.
The current implementation has the following limitations:

Extracted payload contents are not cached across executions per release image.
This is possible, but not worth doing unless subsequent performance analysis
justifies it.

All payload generation executions are serial. Concurrent executions are
possible, but not worth doing unless subsequent performance analysis justifies
it.

This commit also enables metrics collection for the ignition server component and
adds the following metrics:

ign_server_token_rotation_total
ign_server_payload_cache_miss_total
ign_server_payload_generation_seconds
ign_server_payload_cache_total

TODO:

[x] Fix Azure support
[x] Fix mDNS support

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/test e2e-aws

/retest

/retest

can you please add the local ignition provider to the list here https://github.com/openshift/hypershift/tree/main/ignition-server#ignition-provider

cc @relyt0925

Thanks! lgtm overall now. This was failure from previous run https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_hypershift/1214/pull-ci-openshift-hypershift-main-e2e-aws/1509604004080914432/artifacts/e2e-aws/test-e2e/artifacts/TestUpgradeControlPlane_PreTeardownClusterDump/machine-console-logs/example-8bjch-us-east-1a-ntkg5.log
The WorkDir flag it's a breaking change for N-1 atm given we are still exercising reconcile from the HC controller, right? I suggest we merge this, then we move reconciliation down to the CPO. Then if needed we codify any transition path from N-1 as we put CI in place. cc @relyt0925

I took out all the ign server flag references from the hypershift-operator and just rely on assumptions about the default values for those new flags, so that the operator is compatible with both the new and old ign servers. Seems good enough for now...

It looks like the kubevirt-gcp job is failing... we don't have any periodics I can compare with for baselines, so I think I'll take a look and see if this is breaking kubevirt. I don't know how it handles ign yet.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_hypershift/1214/pull-ci-openshift-hypershift-main-e2e-kubevirt-gcp/1509649644202758144
Looks like the kubevirt tests fails because it's rolling out NodePools with quay.io/openshift-release-dev/ocp-release:4.10.6-x86_64 which don't contain the MCO fixes that make this new ign implementation possible.

@relyt0925 there's a major implication of this change as-is which is that once the hypershift-operator containing these changes is deployed, ignition server will no longer work for any existing clusters which do not contain the MCO fixes. I brought this up to the team before and I'm not sure I came away totally confident this is acceptable, so I want to call it out one more time and make sure everyone understands exactly what the consequences are.
To maintain backwards compatibility would imply doing something like choosing the internal ign server implementation based on nodepool release versions. That's just an example, there may be other ways to achieve backwards compatibility. But I do want to pin down definitively whether we need backwards compatibility for existing clusters.
cc @alvaroaleman @csrwng @enxebre @sjenning

To maintain backwards compatibility would imply doing something like choosing the internal ign server implementation based on nodepool release versions.

It might actually be even more complicated than that, because there's only 1 ign server per control plane and it must service all nodepools, and nodepools have independent release versions. Does that mean the implementation would have to be selected on a per-request/nodepool basis? If so that's another wrinkle.

After merging this, we'll want to move reconciliation down to the HCP, same for mapprover and autoscaler, so more breaking changes...
I'd suggest we get the PR to the state we think is optimal and merge it. The backwards compatibility will only be solved when we put CI in place to validate it, otherwise we are just guessing things and letting guesses to drive PRs.

Also, this PR breaks kubevirt-gcp on main because that test is pinned to the latest stable OCP from https://amd64.ocp.releases.ci.openshift.org/api/v1/releasestream/4-stable/latest (which doesn't yet include the MCO fixes)

I believe what we will need to do is the following:
We need to get all the backports merged and built into a release image (that's in progress)
Then IBM needs to go with a promotion moving to that latest release image
Then we can move to this being the new process.

/hold until prereqs met with a published release image

can we include the local ign provider into the ign-server readme and link the backports needed in the PR desc?

/lgtm
/hold
We will get this in when a release image is produced with necessary downstream backports for 4.9

release image has been released but not yet in fast channel

In my tests: I do not see any custom config getting accepted: it only uses the base config (custom config as in the config that is specified on the nodepool

I think we need to validate the custom path here is what I did

Create a nodepool with a custom config entry using release payload release-4.9 (verified it contains backports)

apiVersion: hypershift.openshift.io/v1alpha1
kind: NodePool
metadata:
  annotations:
    hypershift.openshift.io/nodePoolCurrentConfig: 22392d0d
    hypershift.openshift.io/nodePoolCurrentConfigVersion: 456a9ca1
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"hypershift.openshift.io/v1alpha1","kind":"NodePool","metadata":{"annotations":{},"labels":{"clusterid":"prtesting49-67235058"},"name":"prtesting49-67235058-mynodepool","namespace":"master"},"spec":{"clusterName":"prtesting49-67235058","management":{"replace":{"strategy":"OnDelete"},"upgradeType":"Replace"},"platform":{"ibmcloud":{"providerType":"UPI"},"type":"IBMCloud"},"release":{"image":"us.icr.io/armada-master/ocp-release:4.9.26-x86_64"}}}
  creationTimestamp: "2022-04-16T00:29:02Z"
  finalizers:
  - hypershift.openshift.io/finalizer
  generation: 5
  labels:
    clusterid: prtesting49-67235058
  name: prtesting49-67235058-mynodepool
  namespace: master
  ownerReferences:
  - apiVersion: hypershift.openshift.io/v1alpha1
    kind: HostedCluster
    name: prtesting49-67235058
    uid: 2a22ddbd-248a-4071-a3c7-598c2c18d9f2
  resourceVersion: "240680094"
  uid: 2e28a3e9-fdbe-4d4a-a446-86b2feb5753b
spec:
  clusterName: prtesting49-67235058
  config:
  - name: ignition-config-97-ibm-master-endpoints-prtesting49-67235058
  - name: ignition-config-97-ibm-machineconfig-base-prtesting49-67235058
  - name: ignition-config-98-ibm-machineconfig-satellite-prtesting49-67235058
  management:
    autoRepair: false
    replace:
      strategy: OnDelete
    upgradeType: Replace
  platform:
    ibmcloud:
      providerType: UPI
    type: IBMCloud
  release:
    image: registry.ng.bluemix.net/armada-master/ocp-release:4.9.29-x86_64

where the config has some well known unique file
apiVersion: v1
data:
  config: |
    apiVersion: machineconfiguration.openshift.io/v1
    kind: MachineConfig
    metadata:
      name: 97-ibm-master-endpoints
      labels:
        machineconfiguration.openshift.io/role: worker
    spec:
      config:
        ignition:
          version: 2.2.0
        storage:
          files:
            - contents:
                source: data:text/plain;base64,UFVCTElDX1NFUlZJQ0VfRU5EUE9JTlRfRU5BQkxFRD0iZmFsc2UiClBSSVZBVEVfU0VSVklDRV9FTkRQT0lOVF9FTkFCTEVEPSJmYWxzZSIKI05PVEU6IGR1ZSB0byBiYXNoIElGUyBwcm9jZXNzaW5nIGFjdHVhbGx5IHdhbnQgY29tbWEgb24gdGhlIGVuZC4KTUFTVEVSX0VORFBPSU5UU19DU1Y9ImJ0cy1vYzQtcmhjb3MtcHJ0ZXMtMTViMGJmMzcxNGIyZDlkMzQ0YzNiODY0N2VkYjc4NjAtMDAwMC51cy1zb3V0aC5zdGcuY29udGFpbmVycy5hcHBkb21haW4uY2xvdWQsIgpNQVNURVJfU0VSVkVSX1BPUlQ9IjMwOTAwIgpNQVNURVJfUFJPWFlfSVA9IjE3Mi4yMC4wLjEiCk1BU1RFUl9QUk9YWV9QT1JUPSIyMDQwIgpJQUFTX1BST1ZJREVSPSJ1cGkiCkNBX1JPVEFUSU9OX1BIQVNFPSIiCg==
              filesystem: root
              mode: 420
              path: /etc/sysconfig/ibmmasterendpointsmetadata
kind: ConfigMap
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: '{"apiVersion":"v1","data":{"config":"apiVersion:
      machineconfiguration.openshift.io/v1\nkind: MachineConfig\nmetadata:\n  name:
      97-ibm-master-endpoints\n  labels:\n    machineconfiguration.openshift.io/role:
      worker\nspec:\n  config:\n    ignition:\n      version: 2.2.0\n    storage:\n      files:\n        -
      contents:\n            source: data:text/plain;base64,UFVCTElDX1NFUlZJQ0VfRU5EUE9JTlRfRU5BQkxFRD0iZmFsc2UiClBSSVZBVEVfU0VSVklDRV9FTkRQT0lOVF9FTkFCTEVEPSJmYWxzZSIKI05PVEU6IGR1ZSB0byBiYXNoIElGUyBwcm9jZXNzaW5nIGFjdHVhbGx5IHdhbnQgY29tbWEgb24gdGhlIGVuZC4KTUFTVEVSX0VORFBPSU5UU19DU1Y9ImJ0cy1vYzQtcmhjb3MtcHJ0ZXMtMTViMGJmMzcxNGIyZDlkMzQ0YzNiODY0N2VkYjc4NjAtMDAwMC51cy1zb3V0aC5zdGcuY29udGFpbmVycy5hcHBkb21haW4uY2xvdWQsIgpNQVNURVJfU0VSVkVSX1BPUlQ9IjMwOTAwIgpNQVNURVJfUFJPWFlfSVA9IjE3Mi4yMC4wLjEiCk1BU1RFUl9QUk9YWV9QT1JUPSIyMDQwIgpJQUFTX1BST1ZJREVSPSJ1cGkiCkNBX1JPVEFUSU9OX1BIQVNFPSIiCg==\n          filesystem:
      root\n          mode: 420\n          path: /etc/sysconfig/ibmmasterendpointsmetadata\n"},"kind":"ConfigMap","metadata":{"labels":{"clusterid":"prtesting49-67235058","ignition-config":"true","rhcos-config-clusterid":"prtesting49-67235058"},"name":"ignition-config-97-ibm-master-endpoints-prtesting49-67235058","namespace":"master"}}'
```

/rm lgtm

/test e2e-aws-all

/retest

/unhold
/lgtm

/cherry-pick release-4.10

/cherry-pick release-4.9


Argv list not endswith NULL in stack initialization

I found that ckb-vm's argv has not endswith null, and then I did a simple test.
The C Standard <IP_ADDRESS>.1/2 says:

argv[argc] shall be a null pointer.

so create a c program:
#include <stddef.h>

int main(int argc,  char *argv[]) {
	if (argv[argc] == NULL) {
		return 0;
	}
	return 1;
}

When built by gcc, and run on Linux, it returns "0".
When built by riscv-unknown-elf-gcc, run on ckb-vm, it returns "1".
You might add a NULL here: https://github.com/nervosnetwork/ckb-vm/blob/develop/src/machine/mod.rs#L160

We could make this change but has to do it in a non-breaking way, I will give it a thought on how we can achieve this, thanks for the report

Fixed in #99


Plugin not working on all configurations

Some user is reporting issues after I have added this plugin to my kiwi installation. They can't see what other users type anymore and they do have some other issue.
It seems they're all using Google Chrome (last available version), but I was not able to reproduce it, unfortunately.
You can see all the issues in the screenshot and check differences connecting to http://www.echatta.net/client

I can't replicate the issue either. I need more information such as if they're using a vanilla install of Chrome (no plugins) and if they are which ones, as well as the exact version they're using.

It seems it happens if you have Avira installed with its Google chrome extension. Can you do something about it?

Avira as in the Antivirus for windows/mac? If so, I run Linux so it might take some time to figure out how to fix this. I assume it has to do with the program blocking the CDN. Maybe try running it as a local install?

Ok, so I installed Avira and it's chrome extension on a Windows laptop I have laying around. As I predicted, it is blocking MaxCDN as a "tracker". If you open the browser extension to view the list of blocked trackers you can unblock it by clicking the "unblock" toggle. Here is what it looks like:

Since this is a client side chrome extension there is nothing I can do besides suggest running the plugin generator as a local install instead of using the CDN.

I will run it locally, not a problem, thank you very much.


client.ListOptions issue with apiregistration.APIService

Bug Report
I am getting teh following error when creating a controller that watches on apiregistration.APIService:
E0707 15:31:47.150068  248720 reflector.go:178] pkg/mod/k8s.io/client-go@v0.18.2/tools/cache/reflector.go:125: Failed to list *apiregistration.APIService: v1.ListOptions is not suitable for converting to "apiregistration.k8s.io/__internal" in scheme "pkg/runtime/scheme.go:101"

unfortunately, no more logs are emitted.
I have seen: https://github.com/kubernetes/apiextensions-apiserver/issues/4 and https://github.com/operator-framework/operator-sdk/issues/2633 it seems that everytime people don't get to the bottom of the issue, but it looks like changing the package where the resource is defined might help. So, does apiregistration.APIService exist in different packages besides: "k8s.io/kube-aggregator/pkg/apis/apiregistration"?
If not can someone help me debug this issue?
What did you do?
created a controller that watches on apiregistration.APIService:
	err = c.Watch(&source.Kind{Type: &apiregistration.APIService{
		TypeMeta: v1.TypeMeta{
			Kind: "APIService",
		},
	}}, &handler.EnqueueRequestForObject{}, isAnnotatedAPIService)

What did you expect to see?
no errors and the watch created correctly.
What did you see instead? Under which circumstances?
I go this error:
E0707 15:31:47.150068  248720 reflector.go:178] pkg/mod/k8s.io/client-go@v0.18.2/tools/cache/reflector.go:125: Failed to list *apiregistration.APIService: v1.ListOptions is not suitable for converting to "apiregistration.k8s.io/__internal" in scheme "pkg/runtime/scheme.go:101"

Environment

operator-sdk version:

operator-sdk version: "v0.18.1", commit: "7bf7b6886d647dc202525daec16fab67dcc52a3d", kubernetes version: "v1.18.2", go version: "go1.13.6 linux/amd64"

go version:

go version go1.14.3 linux/amd64

Kubernetes version information:

Client Version: 4.4.3
Server Version: 4.4.10
Kubernetes Version: v1.17.1+9d33dd3

Kubernetes cluster kind:

OCP

Are you writing your operator in ansible, helm, or go?

go
Possible Solution
I have not found a workaround.
Additional context
none.

Hi @raffaelespazzoli,
What is apiregistration.APIService? Is this from your own API's and/or a third-party API?
Note that your project requires RBAC roles to have permission to do actions over the resources (list/get/update/delete/patch, etc) in the clusters. In this way, you need to update the deploy/role.yaml accordingly. More info: https://kubernetes.io/docs/reference/access-authn-authz/rbac/
Also, if you are using a third-party API then, you need adds its schema to the manager. For more info see the blog How to use third-party APIs in Operator SDK projects which I believe that will help you with since has all consolidate. However, its information also can be found in the SDK docs. You might need to also customize the default metrics exported as well. See; https://sdk.operatorframework.io/docs/golang/quickstart/#default-metrics-exported-with-3rd-party-resource.

@camilamacedo86 answering your questions:
What is apiregistration.APIService? Is this a third-party API? Could you add its import?

apiregistration.APIService is a standard kube object: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#apiservice-v1-apiregistration-k8s-io
in my cluster the following apiservice are present (OCP default):
oc get apiservice
NAME                                            SERVICE                                                      AVAILABLE                  AGE
v1.
Note that your project requires RBAC roles to have permission to do actions over the resources (list/get/update/delete/patch, etc) in the clusters. In this way, you need to update the deploy/role.yaml accordingly. More info: https://kubernetes.io/docs/reference/access-authn-authz/rbac/

I am running this operator locally with a cluster-admin user.
Also, if you are using a third-party API then, you need adds its schema to the manager. For more info see the blog How to use third-party APIs in Operator SDK projects which I believe that will help you with since has all consolidate.

I do this:
	if err := apiregistration.AddToScheme(mgr.GetScheme()); err != nil {
		log.Error(err, "")
		os.Exit(1)
	}

However, its information also can be found in the SDK docs. You might need to also customize the default metrics exported as well. See; https://sdk.operatorframework.io/docs/golang/quickstart/#default-metrics-exported-with-3rd-party-resource.

I have disabled metrics:
	// Add the Metrics Service
	// this operator does not define any CRD so it does not need to serve metrics
	//addMetrics(ctx, cfg)

I am running this operator locally with a cluster-admin user.

When you run the project locally it will still be using the k8s api. You need to apply the permissions for your operator is able to list resource. You are logged as admin and because of this you can perform actions with this level of permissions, however, the operator project uses the RBAC permissions defined to it via the service-account and not assume your user permissions.
Also, what is the scope of your operator? Did you change it to be cluster-scope? More info: https://sdk.operatorframework.io/docs/operator-scope/#cluster-scoped-operator-usage
See that it is a cluster-scoped and you will be unable to List it with a namespaced-scoped operator:
$ kubectl api-resources --namespaced=false | grep APIService
apiservices                                    apiregistration.k8s.io         false        APIService

PS.: Note that it is a k8s schema and then you do not need to do apiregistration.AddToScheme(mgr.GetScheme()).
Shows that the problem here are that your project is NOT cluster scoped and has not permissions to List the APIService.
Looking for your confirmation/reply for we are able to close this one.

When you run the project locally it will still be using the k8s api. You need to apply the permissions for your operator is able to list resource. You are logged as admin and because of this you can perform actions with this level of permissions, however, the operator project uses the RBAC permissions defined to it via the service-account and not assume your user permissions.

this is news to me and does not corresponds to my experice with developing operators. Which service account are you referring to?
To be clear, I am running the operator like this:
OPERATOR_NAME="cert-utils-operator" operator-sdk run local --operator-flags "--systemCaFilename $(pwd)/README.md --zap-level=debug" --watch-namespace=""

this has always used the permissions of the currently logged in user, which in my case has the cluster-admin role.
As you can see from the way the operator is launched, yes, i believe I am running it at the cluster level.
PS.: Note that it is a k8s schema and then you do not need to do apiregistration.AddToScheme(mgr.GetScheme()).

this is not true, only the api under the api package are added directly.
Please take a look at the error message that I am getting, nothing there is hinting a permission issue or a namespace vs cluster level issue. It's saying the the list option is incompatible.
E0707 15:31:47.150068  248720 reflector.go:178] pkg/mod/k8s.io/client-go@v0.18.2/tools/cache/reflector.go:125: Failed to list *apiregistration.APIService: v1.ListOptions is not suitable for converting to "apiregistration.k8s.io/__internal" in scheme "pkg/runtime/scheme.go:101"

what concern me about that error message is that __internal scheme, what does it mean?

Hi @raffaelespazzoli,
Following some comments inline and a few questions.

The k8s.io/kube-aggregator/pkg/apis/apiregistration is not part of the k8s schemas added by default. Then, you are right it would need to add the schema to the manager.

In the comment https://github.com/operator-framework/operator-sdk/issues/3353#issuecomment-655424961 you run oc get apiservice and you have many apis and kinds which has a similar name but none of them shows be k8s.io/kube-aggregator/pkg/apis/apiregistration. What api and kind exactly you are trying to use in your project and why?

Could you please provide for example the oc get to check the resource that you are trying to watch?

What you are trying to achieve with the watch?  What is the problem that you are trying to solve with?

I  am looking for your answer in order to be able to better assist.

@camilamacedo86
1. In the comment #3353 (comment) you run oc get apiservice and you have many apis and kinds which has a similar name but none of them shows be k8s.io/kube-aggregator/pkg/apis/apiregistration. What api and kind exactly you are trying to use in your project and why?

The api I am listing is:
apiVersion: apiregistration.k8s.io/v1
kind: APIService

what you see in the list are the instances of this type in a cluster ... not sure what you are asking, but if I pick one of them:
oc get apiservice v1beta1.mcm.ibm.com -o yaml
apiVersion: apiregistration.k8s.io/v1
kind: APIService
metadata:
  creationTimestamp: "2020-06-28T15:02:18Z"
  labels:
    installer.name: multiclusterhub
    installer.namespace: open-cluster-management
  name: v1beta1.mcm.ibm.com
  resourceVersion: "451895"
  selfLink: /apis/apiregistration.k8s.io/v1/apiservices/v1beta1.mcm.ibm.com
  uid: 535668cf-3f83-4719-b6e6-9001b533568f
spec:
  group: mcm.ibm.com
  groupPriorityMinimum: 10000
  insecureSkipTLSVerify: true
  service:
    name: mcm-apiserver
    namespace: open-cluster-management
    port: 443
  version: v1beta1
  versionPriority: 20
status:
  conditions:
  - lastTransitionTime: "2020-06-28T15:42:19Z"
    message: endpoints for service/mcm-apiserver in "open-cluster-management" have
      no addresses with port name "secure"
    reason: MissingEndpoints
    status: "False"
    type: Available

this particular one is failing but it should not be an issue with regards to getting/listing/watching it.
Could you please provide for example the oc get to check the resource that you are trying to watch?

is the above answer good enough?
What you are trying to achieve with the watch? What is the problem that you are trying to solve with?

I am trying to create an operator that will inject the CABundle into a APIService because sometimes the CABundle is not known at deploy time. this is going to be an extension of the cert-utils-operator (https://github.com/redhat-cop/cert-utils-operator), which already has many of these injectors.

Hi @rafaelvanoni,
Your issue is not clear for me. I understand that you can configure your cluster to inject the CA. See: https://kubernetes.io/docs/tasks/extend-kubernetes/configure-aggregation-layer/
However, when you say:

what you see in the list are the instances of this type in a cluster ... not sure what you are asking, but if I pick one of them:
oc get apiservice v1beta1.mcm.ibm.com -o yaml

and

APIService because sometimes the CABundle is not known at deploy time.

It shows that what you would like to do is to watch the GKV v1beta1.mcm.ibm.com which lead to me believes that it is a CRD and then, update it or the Deployment that is created via the Operator which manages it.
If the above information is not helpful, wdyt about you add here all steps via the command line that you are trying to do via the operator? It might help us to better help you with.

@camilamacedo86 the object type I am trying to list is:
apiVersion: apiregistration.k8s.io/v1
kind: APIService

this type is defined in my cluster and there are instances of it as I have demonstrated
The content of one of them is an api service that responds to mcm.ibm.com/v1beta1.
This should not be confusing.
It doesn't matter what the apiservice is about, the issue is that I cannot list them from the operator code...

Hi @raffaelespazzoli,
Note that, when you run oc get apiservice v1beta1.webhook.certmanager.k8s.io -o yaml you are using a command which will do a request to the API service to check the API's registered on it. It is not the same of kubectl get Kind name which returns the resource X of the kind Y. Example:
$ kubectl describe apiservice  v1.batch
Name:         v1.batch
Namespace:
Labels:       kube-aggregator.kubernetes.io/automanaged=onstart
Annotations:  <none>
API Version:  apiregistration.k8s.io/v1
Kind:         APIService
Metadata:
  Creation Timestamp:  2020-07-08T12:18:53Z
  Resource Version:    17
  Self Link:           /apis/apiregistration.k8s.io/v1/apiservices/v1.batch
  UID:                 e398ff41-6a5f-4ba7-a3b6-9cf046f79bb8
Spec:
  Group:                   batch
  Group Priority Minimum:  17400
  Version:                 v1
  Version Priority:        15
Status:
  Conditions:
    Last Transition Time:  2020-07-08T12:18:53Z
    Message:               Local APIServices are always available
    Reason:                Local
    Status:                True
    Type:                  Available
Events:                    <none>

The above command shows the result of the request made to the APIService endpoint for the API v1.bach which is registered on it but it is not returning resources of the Kind v1.Batch.
Then, when you are using a project built with SDK you have a controller which is an implementation that comes from the project controller-runtime where a client is provided by it. So, by doing a code as client.List for example, it will perform requests to the cluster to List the resources which shows not the same as the command kubectl get apiservice.
You can do for example :
   // Get a config to talk to the apiserver
    cfg, err := config.GetConfig()
    if err != nil {
        log.Error(err, "")
        os.Exit(1)
    }

    // Get a list of all API's on the cluster
    apiGroup, apiResourceList , err := discoveryClient.ServerGroupsAndResources()
    if err != nil {
        log.Error(err, "Unable to get Group and Resources")
        os.Exit(1)
    }

The above code will use the discoveryClient.ServerGroupsAndResources() to get list the API resources via the metav1.APIResourceList from metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" which would be more equivalent the usage of the command line kubectl get apiservice.
In this way, it is not clear for me the solution watch results from the "APIService" endpoint to solve the problem sometimes the CABundle is not known at deploy time. In POV shows that you would need to manage/watch the Deployment and/or the Kind/CRD who is the owner of this deploy instead of it.
However, it is not an SDK tool-specific issue indeed. It is an issue/question which is more about the controller-runtime/k8s domain. So, if the information provided still not satisfactory then, I'd like to kindly ask for you re-formulate it and raise against the project/repo controller-runtime which is responsible to hold/provide the client and controller implementation and would be the most appropriated channel to get help with.
I hope that it helps you with and I am closing this one, but feel free to ping us if for any reason you still thinking that it should be re-opened.


esp_event: fix crash when unregistering a handler instance in itself (IDFGH-1940)

When a handler instance is the last one in the list und unregisters itself, the handler iterator will be invalidated by entering free'd memory. Same applies for event base and id, if they become empty.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

After further debugging, I've detected a heap corruption when using event profiling. When unregistering event handlers in themselves, the handler instance is free'd, during execution, but its fields are still written to from profiling code afterwards:
https://github.com/espressif/esp-idf/blob/0a0f2caa1d30e0f8cbfe31475093492e09995763/components/esp_event/esp_event.c#L132-L140

Hi @xentec, can you open a new issue to track this? I only noticed your reply now.


Strong Number in python

Given input number is Strong number or not
EX : 1! + 4! + 5! => 1 + 24 + 120 => 145
I am GSSOC'2021 participant.
Please assign this issue to me.

Hey , I am participant in GSSOC'21. Can you please assign this to me under GSSOC'21?


Update

Thanks, its a great app, I would like to be able to update the app with the latest yt-dl updates. Please advice, many thanks.

As explained in the docs, running ./devscripts/setup-gae.sh and reuploading to GAE should work.


[FEAT] - Add comunitypro watermark

Is your feature request related to a problem? Please describe.
This is to ensure users can give attribution to the efforts of the community members that built this.
Describe the solution you'd like
Add a badge on the bottom of the social icons that says Template by Communitypro
Describe alternatives you've considered

Use badges

A stylish font
A button, etc.

Additional context
None

I will be working on this now.

Awesome, I've assigned you to it.

Made this custom badge but can't generate the image url.

I had to download it manually. Maybe you could use this one I have already generated.

Alright


[REQ] Time format in UI should be user preference specific

Read from user time format setting?

does not seem to be exposed to intergration (I asked on Discord).


WikiExchangeYT

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

Pre-requisites

[X] My application to the GitHub Technology Partner Program is approved.

Tasks

[X] MUST follow our general contributing guidelines for voice and markup format.
[X] MUST emphasize how the third-party product works with GitHub.
[X] MUST be written in Markdown format, using one of the templates provided.
[X] MUST include the name and URL of the GitHub technology partner responsible for maintenance of the documentation being contributed. This should be added via the contributor.name and contributor.URL properties in the template's YAML frontmatter.
[X] MUST be proposed via a pull request to this repo following the GitHub Flow.
[X] MUST be located in the root of the content folder. Your filename MUST match the GitHub technology partner name, and use the .md file extension.

Pull Request

[X] MUST reference this issue, e.g. via closes [this issue number].
[X] MUST pass the automated CI checks.
[X] MUST include links to supporting material demonstrating the functionality being documented (this can be a link to a public GitHub repo, or a video / screencast walkthrough).

ikiExchange #Rank1 TWEETS TWITTER MyGoogleBusiness @WikiExchangeYT https://youtube.com/@WikiExchangeYT also YouTube WikiMeadia Wordpress WebsiteOwner Daniel B Leahy https://bitcoins.net #TWITTER MIT BTCAUD GitHub DEV Apache 2.0TELEGRAM t.me/coinmarketcapbtc
I rated five stars excellent little way to understand the bitcoin minerals mining.
<EMAIL_ADDRESS>Daniel Benjiman Leahy
Victoria Australia Google LLC Investor
DanielBLeahy:https://www.btc-to-usd-converter.com/crypto-arbitrage-services.php
Blockchain Blockchair
Name: Daniel Benjiman Leahy  BlockNo:1477411
<EMAIL_ADDRESS>Etherscan:COINMARKETCAPAUSTRALIANFTs
DanielBLeahy:https://developer.bitcoin.org/reference/rpc/
DanielBLeahy:https://cryptobrowser.site/en/superboost/
DanielBLeahy:https://bitcoins.net
DanielBLeahy:https://coinmarketcap.com/currencies/bitcoin/markets/
https://investurl.com/Reff-F019
https://wordpress.org
https://youtube.com/channel/UCAY600P4m3zaB_w9i-fDDTNg
G©2021 YOUTUBE.YT.COM


Add Localization Guide

Adds translation instructions and guidelines
Details of the files being added

TRANSLATIONS.md: Instructions on how to join the Qiskit Textbook localization project
LOCALIZAIONT_CONTRIBUTORS: File for community members to sign up and join the localization project and ensure that they sign the CLA if they are first-time contributors to Qiskit

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix: yad status should be updated according to the new created ControllerRevision (#1879)

What type of PR is this?

/kind bug
/kind good-first-issue

What this PR does / why we need it:
After editing yad's spec, there is a new created ControllerRevision.
However, yad's status isn't updated because the function updateStatus use param currentRevision, instead of the updated value. We can see that in https://github.com/openyurtio/openyurt/blob/master/pkg/yurtmanager/controller/yurtappdaemon/yurtappdaemon_controller.go#L203
So, when invoking function updateStatus, we just need to replace currentRevision to expectedRevision to solve this problem.
Which issue(s) this PR fixes:

Fixes #1879

/rerun

@YTGhost PTAL

/LGTM

/LGTM

Let's wait for @huangchenzhao to fix the same problem at yurtappset.

/LGTM

Let's wait for @huangchenzhao to fix the same problem at yurtappset.

I have updated the commit to solve the same problem at yurtappset, thanks for nicely reviewing :）

@huangchenzhao Thank you for your contribution!


Appstudio update test-component-pac-yjec

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-yjec-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
40 seconds
build-container

✅ Succeeded
26 seconds
inspect-image

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
18 seconds
clair-scan

✅ Succeeded
14 seconds
sbom-json-check

✅ Succeeded
25 seconds
label-check

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-yjec-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
40 seconds
build-container

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
18 seconds
clair-scan

✅ Succeeded
26 seconds
inspect-image

✅ Succeeded
14 seconds
sbom-json-check

✅ Succeeded
25 seconds
label-check

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


Adds support for yahoo oauth2

customHeaders option
customParams option
updated docs

Could you make sure that the tests pass?

@andris9 good to go

Thanks!


Number of Grading Assignments Completed is Larger than Total Allotted

I have been assigned 26 assignments to grade, if I start grading from the back (number 26) I see this at the top of the screen.
29/26 Complete

Hi @reecemartin,
I am unable to recreate this issue with the information you have given. I just see 4/26 (or some other value less than 26) in each view where this counter is displayed.
If you can add any additional information that can be used to recreate your problem that would be useful:

which MarkUs instance does this problem occur in (which course are you a TA for?)
how many assignments have you graded when the problem occurs?
which page does the problem occur on? (screenshots are helpful)
does this problem persist when you grade at least 1 assignment?

Thanks

If you modify the grades of students you can sometimes see it, I also saw 119/26.

In case it's of any value, I can say this also happens to me. An uninformed guess would be that it's sometimes counting other TA's current completions as my own, since it doesn't happen when I'm marking at unusual hours. That could be just coincidence, though.
(I'm a TA for CSC369, and it seems to happen at any number of assignments marked.)


update CI\CD for beta

pushing to https://beta.frontendweekend.ml on beta branch push

done in https://github.com/nuxdie/frontendweekend/commit/7853881126a103c81f5d90b5f84a30a01c7d1196


The privacy option in #25581 triggers a microphone permission request on iOS app start

Godot version: 3.1

OS/device including version: iOS 10.0+

Issue description: Upon iOS app launch a permission request for microphone access is triggered due to the presence privacy/microphone_usage_description in the export options

Steps to reproduce: Leave the default description in place for microphone privacy string.
Minimal reproduction project:

Related issues: #23682, #25130

CC @BastiaanOlij @marcelofg55

Thats weird, with the camera permission it only triggers when you actually
access the camera. Unless godot uses the microphone API at startup
(possibly as part of initialisibg the audio) it shouldn’t be triggering the
message.
We could leave it empty by default but that feels like a workaround
On Thu, 28 Feb 2019 at 11:55 pm, Rémi Verschelde<EMAIL_ADDRESS>wrote:

CC @BastiaanOlij https://github.com/BastiaanOlij @marcelofg55
https://github.com/marcelofg55
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/26265#issuecomment-468262209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2vaZb4EprV3YZjIh4LhvwhLBiHgHVHks5vR9GwgaJpZM4bPSgS
.

--
Kindest regards,
Bastiaan Olij
https://www.facebook.com/bastiaan.olij
https://twitter.com/mux213
https://www.youtube.com/BastiaanOlij
https://www.youtube.com/channel/UCrbLJYzJjDf2p-vJC011lYw
https://github.com/BastiaanOlij

Ok, reading that first issue that was referenced, looks like Godot accesses
the microphone API at startup (wonder why i didn’t run into that before,
there must be more to this) even if we’re not using it, hence the privacy
message comes up and is mandatory
If so we shouldn’t access the microphone API unless we plan to use it
I’ll have a closer look over the weekend.
On Fri, 1 Mar 2019 at 10:12 am, Bastiaan Olij<EMAIL_ADDRESS>wrote:

Thats weird, with the camera permission it only triggers when you actually
access the camera. Unless godot uses the microphone API at startup
(possibly as part of initialisibg the audio) it shouldn’t be triggering the
message.
We could leave it empty by default but that feels like a workaround
On Thu, 28 Feb 2019 at 11:55 pm, Rémi Verschelde<EMAIL_ADDRESS>wrote:

CC @BastiaanOlij https://github.com/BastiaanOlij @marcelofg55
https://github.com/marcelofg55
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/26265#issuecomment-468262209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2vaZb4EprV3YZjIh4LhvwhLBiHgHVHks5vR9GwgaJpZM4bPSgS
.

--
Kindest regards,
Bastiaan Olij
https://www.facebook.com/bastiaan.olij
https://twitter.com/mux213
https://www.youtube.com/BastiaanOlij
https://www.youtube.com/channel/UCrbLJYzJjDf2p-vJC011lYw
https://github.com/BastiaanOlij

--
Kindest regards,
Bastiaan Olij
https://www.facebook.com/bastiaan.olij
https://twitter.com/mux213
https://www.youtube.com/BastiaanOlij
https://www.youtube.com/channel/UCrbLJYzJjDf2p-vJC011lYw
https://github.com/BastiaanOlij

@BastiaanOlij We only init the microphone if audio/enable_audio_input is enabled for the project.

That explains that, imho things work correctly then.
If that setting is disabled we don’t initialise the microphone api, iOS
won’t ask the message.
If that setting is enabled, we do initialise the microphone api and iOS
rightfully asks the user for permission
On Fri, 1 Mar 2019 at 10:50 am, Marcelo Fernandez<EMAIL_ADDRESS>wrote:

@BastiaanOlij https://github.com/BastiaanOlij We only init the
microphone if audio/enable_audio_input is enabled for the project.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/26265#issuecomment-468486197,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2vaWBNao5JbCxyc_aXq4_QPqC9uD0lks5vSGtBgaJpZM4bPSgS
.

--
Kindest regards,
Bastiaan Olij
https://www.facebook.com/bastiaan.olij
https://twitter.com/mux213
https://www.youtube.com/BastiaanOlij
https://www.youtube.com/channel/UCrbLJYzJjDf2p-vJC011lYw
https://github.com/BastiaanOlij

Well, did you enable audio/enable_audio_input @samgreen? If not, iOS does appear to show the message regardless.

Settings is disabled in project input.

We might need to find an elegant way to allow developers to request authorization statuses from GDScript.
https://developer.apple.com/documentation/avfoundation/cameras_and_media_capture/requesting_authorization_for_media_capture_on_ios?language=objc
In terms of UX, it's pretty rare that you'd want to prompt for permissions on launch, and instead wait for the user to attempt to use that feature before asking for permission. We can't really remove the plist value or the app will just close when attempting to use those permissions.

We might need to find an elegant way to allow developers to request authorization statuses from GDScript.

I agree, and the same is necessary for Android (#26506), but in both cases that requires significant work and we are running out of time (3.1-stable is expected within a week), so we'd need a hotfix to prevent make all games request this permission (even if it means the feature won't work in 3.1, we can fix it properly for 3.1.1).

I’ll do some testing this evening and try to find a low risk fix.

The issue is still present (as expected) in beta 10.
I was able to manually export a project and delete the plist entry describing the privacy option. This removes the prompt, and removes the app from the "Settings" app under "Privacy > Microphone". We could temporarily remove this from the plist and document how to manually add it via Xcode?

@samgreen wouldn't it have been enough to just make sure the default description in the project export was empty? Sorry i haven't had any time to try things on my Mac.

In my testing, the mere presence of the key was enough to trigger the microphone dialog with the default description. Note that developers will need to manually add this key in the mean time if they actual use the microphone and they plan to deploy to the App Store.


Extension should offer to install the "opa" executable when it's not found

Introduce new 'opa.path' configuration
Refactor opa-related helpers into opa.ts
Refactor display utilities into util.ts
Consolidate to using a single output channel called "OPA"
Introduce install-opa module which will prompt to install, fetch releases from GH, choose appropriate release and install it
Tested on Linux (Ubuntu 18.04) and Mac OS X 10.12.6 with VS Code 1.23.1
TODO: Test on windows pls?

This looks great! I ran into a problem while trying to test it out though. The prompt told me OPA was not installed and then I clicked install but got this error immediately.

Oh, are you using a proxy by any chance?
On Thu, May 17, 2018, 12:33 PM Torin Sandall<EMAIL_ADDRESS>wrote:

This looks great! I ran into a problem while trying to test it out though.
The prompt told me OPA was not installed and then I clicked install but got
this error immediately.
[image: screen shot 2018-05-17 at 12 27 58 pm]
https://user-images.githubusercontent.com/238885/40199486-7b245332-59ce-11e8-8fa7-bfb49b19f087.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tsandall/vscode-opa/pull/4#issuecomment-389983038,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABekgJRz7z491aytD8hlSi3L77LIlX4xks5tzdCegaJpZM4UAg7W
.

Not that I know of 😂 I'll debug it a bit and see if I can figure it out.

Here's what my VS code proxy settings looked like while testing. I added a TODO for supporting proxy settings but maybe I need add support for it.

It could also be that the GH url redirected to a null URL though I'm not sure why that would happen. The localhost address and 443 port make me think that the https.get() method is getting a null URL

I'll debug it a bit and see if I can figure it out.
Let me know if I can help. I tried it again on my end and couldn't get it to repro
The node HTTPS documentation says that the default for url is localhost and default for port is 443

The logs indicate the URL is correct. I added a console.log line right before https.get() and it's printing the right value...

There's a second https.get() on on line 106 that handles the redirect. Is that getting the right URL as well?

It's not getting there. Here's the URL struct from running in debug.

Interesting. Add a breakpoint to the reject(e) on line 116 to see if GH is crapping out?

This is an odd one.

One more data point. Calling https.send in the console returns an HTTP request where the Host header is set to localhost.

OK, that's most definitely a proxy issue. Can you search your VS code settings for 'http' and see if you have a proxy set?

OK, not a proxy problem then 👎
Try changing line 101 to
https.get({
            hostname: url.host,
            path: url.pathname
        }

just to eliminate incompatibility.
Not sure what I expect though.

OK this is bizarre. Setting the hostname field to "github.com" fails like we've seen before. Setting the hostname field to anything else (e.g., api.github.com, google.com, etc.) succeeds (but does not download the right file obviously.)

OK, now I'm completely lost. Unless your /etc/hosts file is mapping "github.com" to <IP_ADDRESS>, I have no idea what's going on 😕

Added a comment as to why a token is required

Different network. Same thing. Σ(￣□￣lll)

I'll try it out on another box and see...

When you get some time, try running
import * as dns from 'dns';

dns.lookup('github.com, (err, address, family) => {
  console.log('address: %j family: IPv%s', address, family);
});

in the VS code context.

Added
dns.lookup('github.com', (err, address, family) => {
  console.log('address:', address, 'family:', family, 'err:', err);
});

Output:
address: <IP_ADDRESS> family: 4 err: null

That's GitHub's IP address alright. This is some mystery.

I'm going to merge this and push to the marketplace so that I can easily test in a VM.

💯


Deserializing properties with internal setters should throw if the property is present in the JSON

If an object has an internal setter on a property that isn't marked as JsonIgnore, the object cannot be cleanly round-tripped. For example, take this object:
public class NonGenericObjectTest
    {
        public IDictionary<string, Uri> SyncedObjects { get; set; }
        public SyncState BadDeserialization { get; internal set; }
        public IDictionary<string, ObjectSyncResult> Results { get; set; }
    }

Serializing it, we might end up with output like this:
{"SyncedObjects":{"Test":"https://google.com"},"BadDeserialization":1,
"Results":{"Test":{"Created":false,"Errors":[],"Id":"Test","Success":true}}}

The internal set property BadDeserialization is written to the output. However, it can't be roundtripped, because the setter is internal, and deserializing the object and reserializing it results in the following:
{"SyncedObjects":{"Test":"https://google.com"},"BadDeserialization":0,
"Results":{"Test":{"Created":false,"Errors":[],"Id":"Test","Success":true}}}

Notice that the value is flipped to the default value for the enum, leading to hard-to-track-down bugs.
IMO, if a property with an internal setter is present in the JSON, the deserializer should throw an exception saying that it can't cleanly deserialize this object, or be able to be configured to do so. This would help catch hard-to-diagnose bugs like this one (I spent about 3 hours tearing my hair out and cursing software before spotting the internal setter).

MissingMembersHandling.Error will error if JSON can't be deserialized to a property.

@JamesNK I tried this just now, and it didn't throw when deserialising? I have an object Response with a List<Item> Results { get; internal set; } property. The Item type is just a simple Name+Guid object.
Calling JsonConvert.DeserializeObject<Response>(stringResponse); with a string that should work, results in an object with Results = Null. I tried using MissingMembersHandling.Error, but still, just silent fail with Results = Null. Changing Results so that the set is not just internal fixes it, I now get a Response object with the correct Results List. But I would have found it quicker if I could tell DeserializeObject to throw when it can't create the Results list.
I can maybe cook up a git example if needed.


More thought needed about classes...

Need an action to make class immutable (as have removed the optional keyword). Possibly find away to allow it to be specified initially, but only added retrospectively via an action.
Should we do the same for making it abstract? Since deleting someone's constructor is a but harsh.
Also think about inheritance.  Need to be able to add any missing members automatically, and mark them as required (conditional upon the inheritance).

Superseded by #175


LoginLDAP plugin cannot work together with Admin plugin

Hi,
First of all, thanks a lot for the plugin!
When trying to install LoginLDAP plugin from admin panel, I have this error:
The Login plugin needs to be disabled.
// This plugin is meant to be used in place of Login plugin, Login should not be enabled
        if ($this->grav['config']->get('plugins.login.enabled')) {
            throw new \RuntimeException('The Login plugin needs to be disabled.');
        }

If I disable the login plugin, then I got this error:
One of the required plugins is missing or not enabled
// Check for required plugins
        if (!$this->grav['config']->get('plugins.login.enabled') || !$this->grav['config']->get('plugins.form.enabled') || !$this->grav['config']->get('plugins.email.enabled')) {
            throw new \RuntimeException('One of the required plugins is missing or not enabled');
        }

In file /user/plugins/admin/admin.php
So, it's a deadlock! I cannot install LoginLdap but cannot disable Login either! In order to make it work, I had to hack the admin plugin to check for existence of login OR loginldap.
Is there any way to make this work without hacking the admin plugin? Maybe for future versions?
Thanks a lot for the plugin!

https://github.com/getgrav/grav-plugin-admin/pull/1076

I commented here:
https://github.com/getgrav/grav-plugin-admin/pull/1076
Unfortunately, there does not seem to be a straightforward solution.  I'll try to look into it when I get some time.  It looks like combining @drymonsoon and @AdamEttenberger commits may work for now.

Any updates? I would love to see this happening!


Update to Julia 1.8.2

Can we please get Julia 1.8.2 (or very soon: 1.8.3) ? It seems this is still at 1.8.0 which unfortunately crashes for me in my code (due to a bug fixed in 1.8.2)

Fixed by https://github.com/julia-vscode/julia-devcontainer/commit/1dc6fa02bb9fb9e2b856488146a664444039ad24


Memory leak on AMD CPUs

Bevy version
0.5
OS: Windows 10
CPU: AMD Ryzen 7 4800HS with Radeon Graphics 2.90 GHz
GPU: RTX 2060 with Max-Q Design
Any bevy project with default plugins has a memory leak of about 200mb/s I think it might also be influenced by framerate.
Additional information
I ran the same executable on two computers with Intel chips and it runs perfectly.

maybe related to #1488
Could you check with wgpu-rs examples? See this comment about an example to run and how to change the backend used between dx12 and vulkan

I tried setting "BEVY_WGPU_BACKEND=vulkan" and I get:
"thread 'main' panicked at 'Unable to find a GPU! Make sure you have installed required drivers!'"
This is because there is a known bug with AMD integrated graphics not allowing Vulkan to initialize. https://github.com/KhronosGroup/Vulkan-Loader/issues/552
setting "DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1=1" fixed it for me
However, I don't know if this is related to the DX12 memory leak.

hello, guys, I came here from #1804 (I am using Ryzen 3500U with its Vega 8 on Windows 10) and I also have a memory leak-like behavior except for it is less 'tragic' (but leak is leak) although setting rendering backend to vulkan actually helps (but who wants to use env variables)

this should have been fixed after a dependency update, could you check after a cargo update?

Closed following #1804. Feel free to reopen if you still have an issue.


test(dataproc): make quickstart test delete before retry and E2E

I ran the test locally (with E2E enabled) and it passed. Hopefully this helps with some of the flakiness.
The error from today was:
quickstart_test.go:152: stderr: 2020/08/28 17:23:30 error submitting the cluster creation request: rpc error: code = AlreadyExists desc = Already exists: Failed to create cluster: Cluster projects/golang-samples-tests-8/regions/us-central1/clusters/go-qs-test-golang-samples-tests-8

So, it seems the previous retry created the cluster but didn't delete it. Then, the quickstart tried to create the cluster again and couldn't.
Fixes #1646.

LGTM, thanks for fixing @tbpg


transition-group has stutter when component updated elsewhere

Version
2.6.10
Reproduction link
https://jsfiddle.net/zncxud6q/
Steps to reproduce
Use test1, test2, or test3 buttons to see transition without stutter.
Use test4, test5, or test6 buttons to see transition with stutter.
What is expected?
No stutter
What is actually happening?
While the DOM is updating, the transition restarts, even though the portion updating isn't a child of anything transitioning

It's even more noticeable with non-linear transitions. As a workaround, you can wrap the content into a component and pass the content through a Store instead of props but that's quite cumbersome.

What's the workaround for this?


local.sh: update ports, add correct RBAC rules, allow "kind"

I remembered that this existed today, and it's been very helpful.  I tweaked a few things to make it potentially work for more people, mostly me.  (The base64 command burned me again; MacOS's version wants different flags than Linux's -- so I just did the transform in jq instead.)
I also added the RBAC rules; the default service account in kube-system didn't have the necessary permissions.  I extracted a minimal manifest out of the currently-checked-in helm chart and that works for me.  Putting a heredoc in the script is distasteful... we can replace this with something that convinces helm to apply the correct manifests, but that is a bigger change and will do it later ;)

Good point on the connect-back-to-pachd stuff.  I agree that this method of testing PPS is sub-optimal, but it's good for everything else.


v2.4 YOPAN-165 and YOPAN-168

This PR brings in workaround against anomaly 165 and 168 for the nRF5430 SoC.
KRKNWK-19361

Some fromlists should be fromtrees as they’re already merged

Fixed, there are now [nrf fromtree]

Some fromlists should be fromtrees as they’re already merged

Fixed, there are now [nrf fromtree]

Some cherry-picks contain two lines for "cherry picked from", should only be one

Some cherry-picks contain two lines for "cherry picked from", should only be one

fixed


[WIP] #8056 separate table display

@LeeTZ
This is extracted version of table display javascript/typescript files.
As you can see some files were duplicated

src/contextMenu/*
src/plot/*
src/shared/*
src/tree/*
and maybe others

What I'm trying to achieve now is move those files to its own folder/package.
I'm trying to use them then as a local package in package.json (never tried that before)
I started with BkoContextMenu.ts
and I probably misconfigured sth because after using it from local package I'm getting loader errors in our typescript tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: piorek:white_check_mark: rootty:white_check_mark: EfimovVladimir:x: jaroslawmalekcodeteYou have signed the CLA already but the status is still pending? Let us recheck it.


fix: support dynamic options to TreeDropdown component

Description
This adds support for dynamic options to the TreeDropdown component. Earlier, if we changed the options passed to the TreeDropdown, the updated options were not getting reflected in the component.
Type of change

Bug fix (non-breaking change which fixes an issue)

Fixes #307
How Has This Been Tested?
Tested in the main app.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Thanks for the PR, Ravi! LGTM.
I've created an alpha release for this branch - you can use<EMAIL_ADDRESS>to test the fix on your branch in the main repo (esp for perf issues) before it goes in.
Once a QA confirms things look fine on your branch in the main repo, or another branch in the main repo, we can merge this in. This is to ensure that breakages on this repo don't propogate quickly downstream or block other work.
Please use dependabot to tag this branch to depend on the branch you create in the main repo, after which I will mark your changes as approved.

@tanvibhakta I'm getting this error while using the version you mentioned in the above comment.

I was able to do install the alpha; check out the branch chore/test-tree-dropdown-dynamic-options in the main repository.
Is this how you were adding the package to the repository?


Restore patch for previous Nektar version.

Restores patch for version Nektar version "5.3.0-2e0fb8".

In our nektar package we have "5.3.0-2e0fb8" which is a commit between the tag for 5.2 and the tag 5.3. I chose this commit (I think) as it was main when the MPI init fixes I upstreamed were merged (and VERSION was 5.3.0 ) (MPI fixes on 9b6bcd26a0fba8a5ab7d5674b5c8221396ca1ced).
Maybe I should have called this 5.2.0-2e0fb8.

It is possible we run fine with the actual 5.3.0 release - this is untested I think.

I like Owen's proposal.

ok, I'll see if NESO builds with 5.3.0 (hopefully without changing the original nektar patch)
If that works, can we drop all but 5.3.0 and 5.4.0?

The 5.3.0 and 5.4.0 parts look fine. I don't think we can unilaterally make a 5.2.1 for Nektar and would call the 5.2.1 5.2.0-2e0fb8 (or 5.3.0-2e0fb8).

Just read this more carefully. I see what you're saying. One of the issues with adding hashes at the end is Spack doesn't necessarily sort them properly when determining what is the most recent version. Perhaps we should use the date of the commit instead?
Better yet, how about I just try building with the (real) 5.3.0 and see if it works

Date versions [1] do look like they solve the problem?
    version("5.2.0_2022_09_03", commit="2e0fb86da236e7e5a3590fcf5e0f608bd8490945", preferred=True)

Unless it should be 5.3.0_2022_09_03 - I don't know what the convention is here. Fortunately that was the last commit on that day.
[1] https://spack.readthedocs.io/en/latest/packaging_guide.html#date-versions

The original patch seems to work for nektar 5.3.0, but almost all of the NESO changes required for 5.4.0 are also required for 5.3.0, so it's a bit fiddly...
I'd be inclined to change the existing version string as Will suggested. So just have "5.2.0_2022-09-03" and "5.4.0" and the two corresponding patches.

I've made changes as suggested. I'm trying to build it now. @oparry-ukaea could you take a quick look over my changes as well?

Think the 5.3.0 commit is "f286f809cfeb26cb73828c90a689a048898971d2"
https://gitlab.nektar.info/nektar/nektar/-/tags/v5.3.0

Fixed that.

Looks good to me.
Are we adding<EMAIL_ADDRESS>with the<EMAIL_ADDRESS>dependency in a different MR?

I was thinking:

merge this.
Use https://github.com/ExCALIBUR-NEPTUNE/NESO-Spack/pull/24 to create the NESO-Spack commit that has the NP v.0.3.1 + NESO v0.1.0 (as a tag) + Nektar 5.2.0-2022-09-02.
Merge that into NESO main to make the NESO sub module for NESO v0.1.0 have the NS release we made in 2.
Think about repeating steps 2 and 3 for NESO 0.2.0 with Nektar 5.4

I'm happy to combine steps 1 and 2 above into this PR if preferred?

I think Will's proposal makes sense. Let's get this merged and version 0.1.0 released before we worry about 0.2.0

I heard the tag idea from @oparry-ukaea.

merge this.
Use NESO v0.1.0 #24 to create the NESO-Spack commit that has the NP v.0.3.1 + NESO v0.1.0 (as a tag) + Nektar 5.2.0-2022-09-02.
Update NESO sub module for NESO-Spack to the commit in 2) Then actually make NESO v0.1.0 release (this way NESO v0.1.0 has the NESO-Spack submodule that knows about NESO v0.1.0).
Think about repeating steps 2 and 3 for NESO 0.2.0 with Nektar 5.4

Makes sense to me. Happy to merge this when you are.


Use config subscriber for slobroks config

This needs more work, standalone-container and application do not work with these changes

What is the functional difference here?

The change is to use a config subscribe, Register will then get new slobroks when config changes (if I understand the code correctly) and take care of registering container.

@gjoranv please have a look

Is the purpose to avoid the container restart when slobroksConfig changes?

The purpose is to make sure that container is registered in slobrok when slobroks move (e.g. when retiring a node with slobrok on it).

Yes, and that is now handled by the container restarting and reading the slobroks config again. This is the same for QrConfig, but while QrConfig requires internal changes in the container, the slobroksConfig is only used internally in ´ConfiguredApplication`. Therefore, I assume it's safe to not restart the container when slobroksConfig changes.
If you agree, I suggest to add a comment in the "slobroks area" of in the class header.

👍


Issue #SB-3658: Telemetry share event

closing because of files included which are not part of this PR


community: Updating default PPLX model to supported llama-3.1 model.

Issue
As of late July, Perplexity no longer supports Llama 3 models.
Description
This PR updates the default model and doc examples to reflect their latest supported model. (Mostly updating the same places changed by #23723.)
Twitter handle
@acompa_ on behalf of the team at Not Diamond. Check us out here.

That's embarrassing, my IDE ate these diff conflicts. Thanks for catching @hwchase17.


Access to this site is by invitation only. Your email is not authorized.

When I tried to login to your site with my Forge account, I got below error.
Access to this site is by invitation only. Your email is not authorized.
site:
https://inventor-config-demo.autodesk.io/

forge-configurator-inventor/WebApplication/appsettings.json
"InviteOnlyMode": {
"Enabled": true,
"Domains": [ "autodesk.com" ],
"Addresses": [<EMAIL_ADDRESS><EMAIL_ADDRESS>]
},
master code has this, so clone it and change the "Enabled":true, to false

Thanks @thickiran that's what I was thinking as a workaround too.


_meta

Can you confirm what is meant by the _meta version of drug_meta?

I believe you found this in the UK-IPOP/open-data-pipeline repository. The documentation suggests that column is the "*" (anything) category column. It would be adapting the metadata column from this tool to wide form thus being drug categories (drug_meta = drug related, fentanyl_meta would contain all fentanyl related cases).


Add comment directive

https://www.chordpro.org/chordpro/directives-comment/
All comments should be in the format {comment: Repeat}
Account to the chord prod format it should be italic and smaller by default.
I also added ChordLyricsLine tests since its has logic inside of it.
If you merge this Please squash to one commit I was watching TV while doing this ha.
Here is a pic of the lyrics and the song rendering.

I also added a trim in all the model methods I feel like this should be included.
I removed flutter format in the workflow and replaced with dart format since this is the recommend way now.

@paurakhsharma  Let me know if this is a wanted change or not. If not then ill publish a fork so im not pulling from git.


Allow vpn-client in kube-apiserver to talk to seed apiserver in case of HA VPN.

How to categorize this PR?

/area networking
/kind bug
What this PR does / why we need it:
Allow vpn-client in kube-apiserver to talk to seed apiserver in case of HA VPN.
In the HA VPN, the ip address management of the vpn clients on the seed is done via annotations. Therefore, vpn-client container of the kube-apiserver needs to be able to communicate with the seed's apiserver. In case the seed is a gardener shoot this most likely causes vpn-client to use the external address of the seed's apiserver. This is due to the apiserver-proxy pod mutator injecting the KUBERNETES_SERVICE_HOST environment variable with the external name. However, in other seed scenarios vpn-client might also connect to the seed's apiserver via other means, e.g. through in-cluster communication. For this general case, the existing network policies were not sufficient. This change adds allowance to the seed's apiserver via the corresponding network policy.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Release note:

Fixed bug that cause HA VPN to fail in case the seed's apiserver was not targeted by kube-apiserver's vpn-client via a public address

/milestone v1.64

/cherry-pick release-v1.62

/cherry-pick release-v1.63

/test pull-gardener-e2e-kind-operator

/test pull-gardener-e2e-kind-operator

@ScheererJ or @MartinWeindel, can you make sure of opening respective cherry-pick PRs for the release branches? Automatic PRs don't work in this case, unfortunately.


Cache 301 redirect with a default timeout

Currently 301 redirects are not cached at all unless the website returns a satisfying cache-control header. This is not how browsers work.
https://stackoverflow.com/questions/9130422/how-long-do-browsers-cache-http-301s
There should be a setting to cache 301 redirects for an arbitrary default time.

The spec says:
https://tools.ietf.org/html/rfc7231#section-6.4.2

A 301 response is cacheable by default; i.e., unless otherwise
indicated by the method definition or explicit cache controls (see
Section 4.2.2 of [RFC7234]).

So caching it would be a good idea indeed. It can probably be similar setting to the default cache time heuristic.


Error 500 when trying to charge from Android App - NoMethodError - undefined method indifferent_params

I have deployed the sample backend on heroku but when I charge I get an error 500 :

2018-06-11T08:39:43.833591+00:00 heroku[router]: at=info method=POST path="/charge" host=myapp.herokuapp.com request_id=f4b4e2b2-0000-1111-9999-e9542b146e2b fwd="XX.YYY.ZZ.00" dyno=web.1 connect=0ms service=716ms status=500 bytes=685 protocol=https
2018-06-11T08:39:43.834101+00:00 app[web.1]: 2018-06-11 08:39:43 - NoMethodError - undefined method indifferent_params for #Sinatra::Application:0x00000000023e0970:
2018-06-11T08:39:43.834111+00:00 app[web.1]: 	web.rb:45:in block in main
2018-06-11T08:39:43.834114+00:00 app[web.1]: 	/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.1/lib/sinatra/base.rb:1634:in `call'

I have just created a pull request that fixed the issue for me on my heroku deployed app

Ah nice! I'll take a look.


Can not build go-r3

go build and go tool cgo has the same error
 # go tool cgo r3.go
In file included from /usr/local/include/r3/r3.h:17:0,
                 from /root/go/src/github.com/freehaha/go-r3/r3.go:7:
/usr/local/include/r3/r3_str.h:52:7: error: conflicting types for 'strndup'
 char *strndup(const char *s, int n);
       ^
In file included from /usr/local/include/r3/r3.h:12:0,
                 from /root/go/src/github.com/freehaha/go-r3/r3.go:7:
/usr/include/string.h:183:14: note: previous declaration of 'strndup' was here
 extern char *strndup (__const char *__string, size_t __n)
              ^

I guess it seems to cgo problem.

It seems to be related to some flag issue related to c9s/r3#91. I believe you can just add
#cgo CFLAGS: -D_GNU_SOURCE=1

as a workaround. Let me know if it works (seems to work alright for me), thanks!


Error when make run_tests on ubuntu14

Hi,
I am working on ubuntu 14.04.
I've compiled the latest grpc(with libc-ares-dev (1.13.0)) and protobuf.
but when make run_tests:

ar: creating googleapis.ar
g++ transcribe.o parse_arguments.o googleapis.ar -L/usr/local/lib pkg-config --libs grpc++ grpc -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -lprotobuf -lpthread -ldl -o transcribe
/usr/local/lib/libgrpc.so: undefined reference to `ares_set_servers_ports'
collect2: error: ld returned 1 exit status
make: *** [transcribe] Error 1

Seems like I've picked the wrong version for the c-ares, so how can I fix the error? Thanks.
Besides, the libc-ares-dev (1.11.0) will fail the make of grpc, so I manually make the 1.13.0 for grpc.

Thank you for the bug report.  We need your help to reproduce the problem (and then fix it!)
What exactly do you mean by "latest grpc"?
Did you compile and install the master branch?  Or v1.6.x?  Or v1.4.x?
Can you include the command you used to download grpc?
If you used git to clone the grpc repository, can you include the output from git status and/or git rev-parse HEAD?

I have tested the build on Ubuntu 14.04 against the v1.4.x version of grpc, it works without problem.  You can find the shell script and Dockerfile I used here:
https://github.com/coryan/cpp-docs-samples/tree/fix-issue-24/speech/api/ci
I think the main difference is that we normally compile grpc against the c-ares submodule.  That is, grpc is not compiled against libc-ares-dev, it is compiled against the submodule in third_party/cares.  The commands to compile and install grpc are:
git clone https://github.com/grpc/grpc.git
cd grpc
git checkout v1.4.x
git submodule update --init
make -j 2
make install
cd third_party/protobuf
make install

I suppose ur point is to install the protobuf from the grpc/third_party/protobuf/ instead of https://github.com/google/protobuf/blob/3.1.x/src/README.md
So, I've tried the method which is similar to

WORKDIR /var/tmp/build-grpc
RUN (git clone https://github.com/grpc/grpc.git &&
cd grpc && git checkout v1.4.x && git submodule update --init &&
make -j 2 && make install &&
cd third_party/protobuf && make install)

But there is error when

cd third_party/protobuf
make install

which give me:

/grpc/third_party/protobuf$ -> make install
make: *** No rule to make target `install'.  Stop.

I've checkout the v1.4.x grpc already, did I missed something?Thanks

I suppose ur point is to install the protobuf from the grpc/third_party/protobuf/ instead of
https://github.com/google/protobuf/blob/3.1.x/src/README.md

I did not make that point explicitly, but yes, you want to install the dependencies from grpc/third_party instead of trying to find matching versions from somewhere else.

So, I've tried the method which is similar to

You say "similar", do you mean to say you used exactly those commands, or something else?  If something else, would you mind showing the exact commands that you used?


Check parallelization code throughout scrnaseq2

We already use future, but somebody should go through the code and potentially optimise?

Different number of cores for different modules?
Adapt based on experience, and suggest defaults
E.g. difference SCTransform and log normalization

Test how many cores should be used for small, middle and big datasets (previously issue #22)


feat: Map error response type

Rather than just returning string/number these new types give developers a better idea of what errors the might receive.
This setup was inspired by how TRPC types it's codes: https://github.com/trpc/trpc/blob/main/packages/server/src/rpc/codes.ts
I think it would be great and take this one step further by unifying the return types. There's no reason type, status, and message couldn't exist on the returned success value too.

Thanks a lot @ivoilic ❤