Modify run_clairs to take normal vcf as input and start there

Hi, thanks for making this tool, it is really great!
Summary of change:
Modify run_clairs to take normal vcf as input to skip germline calling of normal sample.
Why I want this feature:
In my research, we often do not have a matched normal pair so we default to using a technical control as "normal" to identify and flag error-prone regions. Therefore, when we call somatic variants on multiple tumor samples, we would like to use the same germline vcf and avoid recalling it for every tumor sample in order to cut down runtime. I've modified the code entry point to add an option to pass in an optional normal vcf: --normal_vcf_fn where, when not null, skips normal germline calling.
Testing done:
I have attached outputs of  ont_quick_demo.sh from both branches for comparison.
master.log
input_normal_vcf.log
Note:
I know this feature might not promote the best use of ClairS. If my use case is too niche, please feel free to ignore this pull request -- I can build my own docker image.

@xingyaoc,
I think the --normal_vcf_fn option a great solution if no control normal sample provided. We will mark the option as "EXPERIMENTAL" (means an option for advanced users) before extensive testing, thanks!
Zhenxian


Expect text token response

The Braintree Node.js documentation demos sending the client token as raw text. For users who followed their documentation with Node.js, Angular's http library would fail to parse the text response. Adding {responseType: 'text'} to the GET request fixes this.
The http parsing bug is discussed here.
Braintree Node.js documentation found here.

Worth noting that I only tested this with a node express server. Not sure how this will affect .NET and other servers.

All other servers' documentation on Braintree are demonstrated by returning raw text as well. In order to maintain consistency with the Braintree server code examples, using { responseType: 'text' } makes sense. I'll highlight a note in the readme of npm/github stating the users to return client token as plain text. Thank you.


Consecutive work- and non-working days

I like this concept, but I'd like to see two changes:

I don't like methods like date. non_working_day over using the language idiom !date.workday, for several reasons.. first, it increases the size of the gem. Second, it's one more thing to remember when the language construct works just fine.  Third, it is an opportunity to. Reed inconsistency, which this does... in the api language of workday vs. working_day.

I don't think a runtime error is an appropriate use when passing in a non work day for your consecutive days function.  I'd like to see it return an empty array instead... that way users of the API don't. We'd to worry about runtime exceptions... they can simply use the returned empty array with functions like .each, and their code automatically does the right thing.

@bokmann thanks for the feedback, I updated this pull request for further review.

I'll be merging this next week. Sorry for the delay, but I was saving it for an internal class on release management at work.


Skip replace direct and nic couple when vswitch exists in NICDEF

In couple_nic_to_vswitch, Image Directory is replaced by adding
vswitch to NICDEF statement. If the user directory NICDEF
statment already included the specified switch, means the NIC has
already coupled to the vswitch, error happens when running above
actions.
This commit is to skip replace direct and nic couple when
vswitch exists in NICDEF. A user scenario is when a VM is migrating
to a target host. The target host detected the device add and call
into couple nic to vswitch.

@jichenjc @SeanHQF @bjhuangr Please help review.


Support for arrays of textures and images in convert-to-sampled-image pass

Currently, the convert-to-sampled-image pass only works for single samplers and images.
I would like to extend this pass to support arrays of samplers and images, as this is required for [[vk::combinedImageSampler]] support for arrays of samplers and textures in DXC, for which there has been community interest (https://github.com/microsoft/DirectXShaderCompiler/issues/4988, https://github.com/microsoft/DirectXShaderCompiler/issues/5092).
My vision for the feature is as follows:

If both there is both a dynamic array of images and a dynamic array of samplers bound to the specified set + slot, combine them into a dynamic array of sampled images
Same for fixed-sized arrays is their sizes match, otherwise it's an error
If only an array of images samplers or and array of images is bound to the specified set + slot, convert it into an array of sampled images

See https://github.com/microsoft/DirectXShaderCompiler/issues/5092 for plans on how this will be done.


Update devcontainer.json

Backwards compatibility to the Genesis block.

Hi 👋
Can you help me explain why this change is necessary? Thanks!

This change is necessary to fix a potential vulnerability in Bitcoins early code


refactor out most grpc calls and switch to http

Http is generally quicker to build and this would reflect real world practices more consistently

Can we use grpc-gateway to proxy the grpc API to http? It have two benefit:

support both grpc and http
easy to set up http server.

Moot point with new build times


Fix #169 issue

Hardcoding no_excerpt_field=True in deconstruct() method of SplitField class

attempt № 2

Did this fix the problem for you?

@carljm  Yes, now it creates only one migration with makemigrations and migrate command works well both with sqlite and postgres.

Great, thanks! Merging.


ConsoleProcess

Description
A helpful wrapper around Process for running console applications.  This came out of a need to start the Azure Functions local runtime in a testing scenario.

:it: :ship: :ship: :ship: :it: :ship: :it: :ship: :it: :ship: :ship: :ship: :it: :ship: :ship: :ship: :it:
:it: :ship: :it: :it: :it: :ship: :it: :ship: :it: :it: :ship: :it: :it: :ship: :it: :ship: :it:
:it: :ship: :ship: :ship: :it: :ship: :ship: :ship: :it: :it: :ship: :it: :it: :ship: :ship: :ship: :it:
:it: :it: :it: :ship: :it: :ship: :it: :ship: :it: :it: :ship: :it: :it: :ship: :it: :it: :it:
:it: :ship: :ship: :ship: :it: :ship: :it: :ship: :it: :ship: :ship: :ship: :it: :ship: :it: :it: :it:

LGTM :shipit:


Missing setActorFlag function

PxActor is missing the setActorFlag function so you have to retrieve the flags with getActorFlags first, modify them and then set them with setActorFlags which adds quite a bit of JNI overhead.
Function definition can be found here: https://docs.nvidia.com/gameworks/content/gameworkslibrary/physx/apireference/files/classPxActor.html

Version 1.1.0 contains the binding to PxActor.setActorFlag()


[Bug]: BOT GETTING STUCK

Version of the software
0.2.5
Operating system
10
Browser / Native
Native
What happened?
Right Now I’m Running Puppeeter and
The Bot runs fine for few checks and then they starts to get stucks one by one
until u have left with Single Bot.
sometimes they get stucks on different blocks in my case
Its getting stuck on Viewport and After Bot Returns Fail Status
The above bug could be easily reproduced by using a slow selenium or puppeeter config
on like 5-6 bots and then u will notice that the amount of browser is reducing till one or two browsers.
Here I have Attached SS of the JOB where its stuck on fail error for a while and is waiting

Ref
Relevant LoliCode if needed
No response

If the developer need the config i will send it to him/her.


Feat/test install script

Description:
This PR introduces several improvements to the validator-dashboard installer script to enhance usability, error handling, and compatibility for both interactive and non-interactive environments, especially in CI/CD pipelines such as GitHub Actions.
Key Updates:

Support for Non-Interactive Execution:

The script can now run in both interactive and non-interactive modes.
Default values are automatically applied in non-interactive environments (e.g., when running in GitHub Actions), allowing the installer to proceed without requiring user input.
Interactive prompts are retained when run in a local, interactive shell for flexibility.

Improved Error Handling:

Better handling of common errors, such as missing directories, with clear and descriptive error messages.
Error trapping and reporting have been added to improve debugging, including capturing and displaying output from failed Docker builds.

Docker Image Build Improvements:

Docker image build output is now captured and displayed in the event of a failure, making troubleshooting easier.
The installer now lists the built Docker images after a successful build, providing visibility into the build process.

SSL Handling in Curl Requests:

The script now supports running curl with the -k option, which allows bypassing SSL verification issues (e.g., self-signed certificates) for testing environments.
curl is used with -f and -k in combination to fail gracefully on HTTP errors while ignoring SSL certificate problems.

Directory Setup and Feedback:

The script now ensures the target directory for the installation exists and provides feedback when creating or validating directories.
Status messages have been added throughout the script for better transparency and progress reporting, especially for critical steps like writing the .env file and building Docker images.

Benefits:

CI/CD Compatibility: Improved support for automated environments like GitHub Actions, enabling seamless integration with non-interactive build pipelines.
Enhanced Debugging: Better error reporting ensures issues are easier to identify and resolve.
User-Friendly Prompts: Interactive and non-interactive modes offer flexibility, while new status messages improve clarity during the installation process.

I just bumped the version of the checkout action in the new workflow to clear out some deprecation warnings and. it looks like that worked so i'll approve and merge this in a sec

i'm bypassing this, i approve but it's not letting me approve now since i made changes but the changes are minor enough it doesn't really matter

Giving my retroactive approval :+1:


doc: add rules priorities description

resolves #32
Signed-off-by: Triple-Z<EMAIL_ADDRESS>

Please resolve the conflicts. Thanks!


Added GrapeCity FlexGrid Showcase sample

Summary
Added GrapeCity FlexGrid Showcase sample

You don't need to close and open a new one, just push/make changes in your existing branch and they will be reflected here automatically.

Thanks @gc-deniszmitrichenko @Youssef1313 @RussKie for working at making the sample better!
@gc-deniszmitrichenko There are a few more suggestions and comments to handle and then I think this is good to go! Sorry for so much back-and-forth! We do have an .editorconfig in the root of the repo that you can use catch some of the small items, such as using the type instead of var when the type isn't implied on the right of the = operator.

@gc-deniszmitrichenko Thanks a bunch! I think this is ready now. Just give me one last sign-off to indicate you're happy with it and then I'll merge it. 👍

@adegeo as indicated by @merriemcgaw we need to make sure all samples meet the accessibility bar.
@gc-deniszmitrichenko could you please run Accessibility Insights for Windows over the sample.
Run the Fast Pass over the impacted control(s) and provide a snapshot of the passing results along with before/after snapshots of the UI. More info: https://accessibilityinsights.io/docs/en/web/getstarted/fastpass

@RussKie I've run accessibility insights over application.
Please, take a look into the attached results.
TestResults.zip
App:

Accessibility Insights:

@adegeo I want to fix readme and check screenshots one more time.
I'll inform when I'm done.
Thanks.

@adegeo @RussKie @Youssef1313 thank you so much for helping me to make the sample better.
I really appreciate your work and spent time.
@adegeo I've finally changed readme like @RussKie suggested, so I think that I've finished with the sample.
But I'm not sure about accessibility issues which were found with Accessibility Insights, so possibly there will be need to make some other changes.
Thank you all for your help!

We'll check into the accessibility insights results. I've never used it but I've forwarded the results on to the team.

@adegeo thank you so much!


Tags

Coverage remained the same at 61.546% when pulling d4ce2ca9ab379a450bcec5db4dd8a83c410175a9 on vrpolakatcisco:tags into 424d836484ed38da935fff4209d79a01964d6ac3 on contiv:dev.


Removed CakePHP

After all the discussions with @alayek, I put the CakePHP part in a different repo.
So now the box creates an empty web development for PHP. Here is the test following the README
Before merging:
@byteknacker I'll need your help to integrate the provision.sh with Zeus : now the user should have two options : an empty PHP dev environment, or a CakePHP3 dev environment. If you can guide me on this, that would be perfect.
On my side, I have to polish the zeus-php-cakephp3 repo and test it.

I did a vagrant up and tested that php, postgres etc. are in correct version.
Looks alright, but next time, also share how to test your PR.
LGTM :+1:
Let's :shipit: :package:

LGTM :+1:

Sorry about the tests part, had no time to write somethin else than the index.php file. It contains a big phpinfo button wich will return all the php dependencies and environment. I'll specify it in next PRs


Don't support primary keys with Hive

Hive doesn't support primary keys. This PR makes sure, that when a column is defined as a primary key, then  this is ignored in the create table statement.

And finally a small request: Can you please create a JIRA issue for this improvement. That makes the life of the committer easier so that we (or you) can add a referenced entry into CHANGES.md when it is merged.

Made the JIRA Issue: https://issues.apache.org/jira/browse/METAMODEL-1194

LGTM. What about you @arjansh ?

@kaspersorensen LGTM too then.


jupyter-activity-snapshot

jupyter-activity-snapshot
https://github.com/coding-to-music/jupyter-activity-snapshot

https://nbviewer.jupyter.org/github/choldgraf/jupyter-activity-snapshot/blob/master/reports/monthly/2019-01-01_2019-02-01/github.ipynb


WCAG 2.2: Cookie banner || Focus not obscured

Description of the issue
As part of my testing and calculations for the WCAG 2.2 'Focus not obscured' criteria (restricted document), I tested the GOV.UK Design System cookie banner.
I found that while our cookie banner doesn't use any 'sticky' or fixed positioning, its an element that's at high risk of being made sticky by others. Similar to our assessment of the phase banner being at risk of being made sticky.
Recommended action
Add guidance on not making cookie banners sticky.
Copy the format from the 'Phase banner' drafted WCAG 2.2 guidance we've been working on, which is in the big WCAG 2.2 content guidance document (restricted document).
Initial draft
WCAG 2.2 Do not make the cookie banner ‘sticky’ to the top of the page by using position: fixed or any other method. This is to make sure it does not cover or obscure any content which has a focus applied. This is to comply with WCAG 2.2 success criterion 2.4.11 Focus not Obscured (minimum).
Recommend guidance placement
Add at the bottom of the ‘How it works’ section under the final line: “Position the cookie banner after the opening <body> tag and before the ’skip to main content‘ link. If you’re using the Nunjucks page template, use the bodyStart block.”]

This has been added to the 'WCAG 2.2 content updates' document.

Closing issue – content has been drafted, reviewed and added to pull request #3090 as part of https://github.com/alphagov/govuk-design-system/issues/3276.


Support autoscaling in dynamic shared zones

Test started failing (or become unstable) after this for opensource builds:
16:29:12 [ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.755 s <<< FAILURE! - in com.yahoo.vespa.hosted.provision.maintenance.HostCapacityMaintainerTest
16:29:12 [ERROR] test_minimum_capacity(com.yahoo.vespa.hosted.provision.maintenance.HostCapacityMaintainerTest)  Time elapsed: 0.182 s  <<< FAILURE!
16:29:12 java.lang.AssertionError: expected:<2> but was:<0>

Yes ... unstable. Fixing.


Bugfix, update rsa's library name

error: Could not find suitable distribution for Requirement.parse('python-rsa')

Once you sign the CLA I can merge this in

I signed it!


fix: tracing root use appDir as fallback

Description
We were relying on values relativeAppDir and outputFileTracingRoot that were optional, and don't exist for every version of Next.js.
relativeAppDir was introduced in https://github.com/vercel/next.js/pull/46393.
appDir was introduced in https://github.com/vercel/next.js/pull/22915.
outputFileTracingRoot was introduced in https://github.com/vercel/next.js/pull/30857.
This PR makes it so that we fall back to use appDir if outputFileTracingRoot and relativeAppDir aren't available.
Documentation

Tests

You can test this change yourself like so:

TODO

Relevant links (GitHub issues, etc.) or a picture of cute animal

We could've caught this earlier, if strictNullChecks were enabled:

https://github.com/netlify/next-runtime/blob/8e1936f352eb9b8b040e82a6c7e9713a02787333/tsconfig.json#L31

@orinokai do you think it'd make sense to enable TypeScript strict mode for this repo?

Ha, looks like there's failures! Turning into a draft.


[BUG] Cannot create recipe for SentencePiece

Describe the bug
A clear and concise description of what the bug is.
A recipe created for SentencePiece fails in the checks.
To Reproduce
Steps to reproduce the behavior:

Create recipe on website
Substitute current meta.yamlwith grayskull recipe
Run @conda-forge-admin, please rerender
Checks fail

Expected behavior
A clear and concise description of what you expected to happen.
The created recipe should successfully be built.
Outputs
If applicable, add the output to help explain your problem.
Every error can be seen here: https://github.com/conda-forge/sentencepiece-feedstock/pull/14
Environment:
conda-forge test environment
Additional context
Add any other context about the problem here.
We're having some problems transferring SentencePiece to MacOS and I tried using GraySkull to see if that could maybe fix it, but, unfortunately, it failed.

Closing due to impossibility. We have added sentencepiece in https://github.com/conda-forge/sentencepiece-feedstock/pull/19 and it is outside of the scope of what grayskull is supposed to be able to do.


Self test issue: JPP_0201

Previously in test case JPP_0201 the JsonPreprocessor returned values, but with a parameter not resolved in a proper way:
Error:
Found deviating return values
(1) '[DICT] (22/22) > {milestone_2} [STR]  :  'MILESTONE-2 (new value)''   > (expected)
(2) '[DICT] (22/22) > {innermost_milestone_name${m${ilstr()o}ne}_str(2)} [STR]  :  'MILESTONE-2 (new value)''   > (returned)

The latest version of JsonPreprocessor does not return values any more, but throws the following exception:
'Could not overwrite parameter ${m${ilstr(${innermost_milestone_name})o}ne}_str(${milestone_number}) due to wrong format.
           Please check key '${m${ilstr(${innermost_milestone_name})o}ne}_str(${milestone_number})' in config file!!!'

But what is wrong with the format? This error message is not helpful.
The expectation is still that the expression is resolved to parameter name "milestone_2".

Addendum:
In a lot of other test cases (e.g. JPP_0207) the error message
The variable ... is not available
has been exchanged by
Could not overwrite parameter ...
Why this?
The problem is not a wrong format, but a not properly working dollar operator substitution, that needs to be fixed.

@namsonx : What is the status of this issue?

Issue was retested and is solved.


Issue with tf.nn.softmax_cross_entropy_with_logits when label value is 100+

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): YES
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):  Installed from Docker official repo
TensorFlow version (use command below): Ver 1.12.0
Python version: python 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:  7.4
Cuda Toolkit: 10.1
GPU model and memory: Tesla P100

I have written a custom CNN for a semantic segmentation problem. For the loss function, I have used
tf.nn.softmax_cross_entropy_with_logits(labels=tf.cast(tf.squeeze(one_hot_labels),dtype=tf.float32),logits =tf.squeeze(pred))
Here is the interesting part, when some of my components within the image are labelled with values such as 100+(such as 105) the network fails to converge during training. If the same components are labelled with less than 100 such as (97) the loss converges. What could be the root cause of this issue here?

@Raj-08 In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!


[Suggestion] Support for multiple models to exist

I've noticed that there is a check for any model existing as part of the autoDownload. However, it only checks if there are  > 0 models rather than checking if the autoDownloadModelName already exists.
if (existingModels.length > 0) {
	if (verbose) {
		console.log('[Nodejs-whisper] Models already exist. Skipping download.')
	}
	return 'Models already exist. Skipping download.'
}

It this by design or is it a bug? My suggestion would be to allow more than one model existing.

I added a Pull Request for this as well in case you'd be interested

@SimonRosengren Thanks for pointing out this issue. Yeah, initially it was by design, but I completely agree with you. I will review the PR soon.

@SimonRosengren Merged the PR


test-cmd.sh failed on master HEAD

$ test-cmd.sh
....
...
+++ Testing kubectl(:pods)
E0227 14:29:00.817800   23923 server.go:315] Unable to listen for secure (open /var/run/kubernetes/apiserver.crt: no such file or directory); will try again.
E0227 14:29:15.817965   23923 server.go:315] Unable to listen for secure (open /var/run/kubernetes/apiserver.crt: no such file or directory); will try again.
 Error in /usr/local/google/home/deyuan/code/source/go-workspace/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/test.sh:34
  'res=$(kubectl get $object -o template -t "$request")' exited with status 255
Call stack:
  1: /usr/local/google/home/deyuan/code/source/go-workspace/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/test.sh:34 kube::test::get_object_assert(...)
  2: hack/test-cmd.sh:143 main(...)

Curiously travis shows a similar error message regarding /var/run/kubernetes, but it isn't failing:
+++ Testing kubectl(:pods)
Successful get pods {{range.items}}{{.id}}:{{end}}:
valid-pod
Successful get pods {{range.items}}{{.id}}:{{end}}: valid-pod:
Successful get pod valid-pod {{.id}}: valid-pod
Successful get pods {{range.items}}{{.id}}:{{end}}: valid-pod:
valid-pod
Successful get pods {{range.items}}{{.id}}:{{end}}:
Successful get pods {{range.items}}{{.id}}:{{end}}:
E0228 00:57:55.256740   16044 server.go:309] Unable to generate self signed cert: mkdir /var/run/kubernetes: permission denied
E0228 00:57:55.256789   16044 server.go:315] Unable to listen for secure (open /var/run/kubernetes/apiserver.crt: no such file or directory); will try again.
valid-pod
Successful get pods {{range.items}}{{.id}}:{{end}}: valid-pod:
Successful get pods {{range.items}}{{.id}}:{{end}}: valid-pod:
valid-pod
...

I suspect the /var/run/kubernetes issue is not what's causing the failure here.

However, I am able to reproduce the failure on my machine.
I note that in your case, the fatal error says
F0227 14:29:16.110382   23988 get.go:151] Get https://<IP_ADDRESS>/api/v1beta1/pods?namespace=default: dial tcp <IP_ADDRESS>:443: i/o timeout
For me, it says
F0227 17:26:30.505929   18618 get.go:151] Get https://<IP_ADDRESS>/api/v1beta1/pods?namespace=default: dial tcp <IP_ADDRESS>:443: i/o timeout
The ip addresses showing through here (which appear to be in the GCE space?) are worrying.

It seems it still failing. I've run it locally and it failed with the following error:
FAIL!
Get pods {{range.items}}{{.id}}:{{end}}
Expected:
Got:      elasticsearch-logging-controller-fplln:kibana-logging-controller-gziey:kube-dns-oh43e:
143 ./hack/test-cmd.sh
The aforementioned line:
Pre-condition: no POD is running
kube::test::get_object_assert pods '{{range.items}}{{.id}}:{{end}}' ''
I think it is expected that there are some pods started by k8s (e.g. elasticsearch). Does it mean the test has a bug?

Strangely the same code (#4810) passes tests on travis (https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/52755393)

I think you're reading it backwards. The test is expecting no pods to be started, but finding the k8s add-on pods, which is normal if it were running against a normal master.
In Travis, it's a synthetic environment with no add-ons.
This should be assigned to whoever added the checks (on mobile.. I know I merged the PR but don't remember who :)). We need to exclude the add-ons (perhaps by finally getting around to putting them in a separate namespace).

@lhuard1A added the assertions, so CC'ing for comment.

I looked into this with @rsokolowski and it seems that test-cmd.sh may fail locally depending on the kubeconfig. Some commands are using defaults for kubectl and thus sometimes they contact another cluster. I'll send a PR to fix this.


Documentation issue for duplicates()

The POD for duplicates asserts:

In scalar context, returns the number of elements occurring only once in LIST.

Should be "more than once".

Seems to but a duplicate of #33 :)

Ah my bad, I had checked only the open issues before creating this one!


Session Management (Inactivity timeouts)-too short

Describe the bug
Inactivity timeout it too short @ 30 seconds
To Reproduce
Identify if any Prequisites:
Version 1.3.0 installed
Steps to reproduce the behavior:

Go to account creation
Wait 30 sec

Expected behavior
Locked out but is too short - should be longer
Screenshots
https://slack-files.com/TDVFB45LG-F026L3KC1J7-dc9dd0e072.
Additional context
Add any other context about the problem here.
Defect Type

[ ] Regression
[x] New
[ ] Escape

Happy path works ok - with existing known issues from other entry points - I am passing this with a caveat that I did have a scenario in which the the timer ran over and never triggered, ever since it is a CNR, when I do reproduce in future will raise a bug - for now Tested - Passed.

Closing this issue as resolved. There is another ticket to cover the problems locking from other screens.


Accept input rule file

It would be nice if users can upload its own rule file in order to review it, or expand it or improve it. From time to time we tend to review/adapt our rules to different new projects.

yeaa that is very nice ^ ^
El sáb., 22 sept. 2018 a las 11:39, Javier Calzado (<
<EMAIL_ADDRESS>escribió:

It would be nice if users can upload its own rule file in order to review
it, or expand it or improve it. From time to time we tend to review/adapt
our rules to different new projects.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/crsanti/tslint-generator/issues/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/AN3dR3Yu3FZjk8-6B1MGUSl9wrzh8Unbks5udgVmgaJpZM4W1Mld
.

One thing to note here is to track the current status of every rule. Cases to consider:

I configure some rules, then I import a file. Should the dirty rules override the imported ones or the other way around? Maybe a dialog with "You have changed some rules. Do you want them to be applied in the imported configuration?"

There are two ways to write a rule. The old one uses an array format. E.g:
"max-line-length": [true, 120]
"max-line-length": [true, { "limit": 120 }]
"max-line-length": [true, { "limit": 120, "ignorePattern": "^(im|ex)port (.*)" }]

The standard format conforms an object with severity? and options?. E.g:
"max-line-length": {
  "options": { "limit": 120 }
}
"max-line-length": {
  "options" { "limit": 120, "ignorePattern": "^(im|ex)port (.*)" }
}
"max-line-length": {
  "options" { "limit": 120 },
  "severity": "warning"
}
"max-line-length": {
  "options" { "limit": 120, "ignorePattern": "^(im|ex)port (.*)" },
  "severity": "warning"
}

The question is, should the object format override the array format? Maybe another dialog asking to rewrite the old rules using the object format?
Maybe every rule could have a status like pristine | imported | dirty where pristine rules won't be added, imported rules won't be touched and dirty rules will be written using the standart format (touching an imported rule and reverted back to its imported value would yield imported status instead of dirty)

What do you think?


Changing battery level unit to "V" instead of "%"

The as the API reports output voltage, not percentage.
This value matches with Settings > Technical Information's Battery information.

Here's how the unit actually shows the value: http://i.imgur.com/5IJPSJf.jpg

Thanks! :beers:


PDI config not validated enough

In GitLab by @croussel on Sep 29, 2016, 10:27
Multiples issues when parsing variable name:

[ ] invalid variable names is not detected (e.g. with arithmetic operators +, -, %, ...)
[ ] multiple declaration of the same name is not detected

I believe invalid names are now detected. Do you confirm?

Changed title: P{-arsing config in PDI-} → P{+DI config not validated enough+}

closed

In GitLab by @croussel on Sep 29, 2016, 10:39
BTW, errors are often hard to catch in the config file.
While reading the config file, no data are actually used by PDI so:

unused variables
types mismatched
bad dimensions (for arrays)
and so on...can't be checked.

I think this can only be checked during export or import time but should not be done all the time.
Maybe a debug plugin should do that ?

Part of this is solved. I update the description

mentioned in commit 5b9e53ce4ca006d31469b8f3ccc8c9a4eef4e956

mentioned in commit 47aa6d25d03bba53df74458e492a71f54e55c5fc


Update README.md

update readme -> -r

I don't think we need pull requests for stuff this small 😄


feat: home-hero section [#2]

Made the PR, please review.

Hi @ansisme Please commit your changes to development branch instead of main. Thanks


Remove unused variables

After merging https://github.com/magnusvk/counter_culture/pull/282 I think these two variables are no longer used 🧹

Thank you, you are right of course. 🤦🏻♂


Wedisagree theme and git weird behaviour

The wedisagree theme has a weird behaviour on git folders.
On regular folders everything works perfectly, but when I get to a git folder the terminal cursor is 4 columns to the left of where it was supposed to be. I know it was a bad description, but it's easy to reproduce and, hopefully, the attached screenshot will help.
I'm using arch linux, awesome and terminator.

When I've seen stuff like this before, it's often been an issue with communicating character widths to the terminal: either non-printing (0-width) characters not being properly escaped, or the terminal and your font not agreeing on how wide characters are.
wedisagree looks fine for me in Terminal.app and iTerm2 on OS X 10.9.5. (Except for the RPROMPT shifting around a couple characters when resizing the terminal.)

It doesn't look like there are any unescaped non-printing characters in wedisagree. (Unless they're hidden in the ZSH_THEME_TIME_SINCE_* variables.) These are usually the color-setting escape sequences. In wedisagree, it looks like they're all properly escaped with the zsh prompt expansion %{...%} escapes.
It could be that Terminator thinks that some of those special characters in the RPROMPT are wider than your font thinks they are, such as ☂, ☀, and 𝝙. Then the terminal or curses could be mis-counting how many characters it needs to allot to that RPROMPT section, and how many characters it needs to move the cursor back to get back to the original location. The fact that the right prompt is right-aligned a few characters short of the right side of the terminal is consistent with this.
To test this out, make a customized copy of wedisagree and replace those characters with regular English letters. They're in this section. Also try out this theme in a couple other terminals and see how it behaves.
If that fixes things, then you've probably got a terminal/font width disagreement. (Or an issue with curses or a similar library.) This could be a configuration or application problem.
It could be that you have your locale configured for a single-byte encoding. Then, when there are multibyte characters like those special symbols used, the terminal or cursor library over-counts how many characters are being displayed. Check your locale output and make sure that it's a UTF-8 locale, and that Terminator supports that. And check that your Terminator profile is set up for UTF-8, and not ASCII or something else.
Or if you are set up for UTF-8. it could be that Terminator expects those special characters to be multiple cells wide when displayed. That's not something you could fix in OMZ or configuration; you'd need to report that to Terminator.

That's right! My terminal locale was wrong.
Setting
export LC_ALL=pt_BR.UTF-8 export LANG=pt_BR.UTF-8
on my '.zshrc' solved the problem, even though my config on /etc/locale.gen was correct.

I wrote the wedisagree theme a fair while ago... Good to see it being used by others! Let me know if it needs updating as I haven't used zsh in a while.


some issues with two examples from the tutorials directory

tutorial/00_LisaInANutshell: should be trying to set ENERGY_AWARE scheduling as root, otherwise permission will be denied (i haven't tested the rest of the file)
tutorial/UseCaseExamples_SchedTuneAnalysis: was not using the path that was set to load the trace file and the ASCII trace file is missing, therefore need to generate it
there are more issues, at least with the latter one.

i hope i addressed the concerns - ?

it's been two months and nobody seems to be using the tutorial. in that case it's probably better if the tutorials were deleted?

Hi @v0lker,
Sorry about that. Notebooks are quite a pain to maintain because you can't really add a Travis job to make sure they still work (you can translate them to a Python script, but then you have nothing to check that e.g. the plots got rendered correctly).
Some of those Notebooks serve a dual purpose - both API documentation and tutorial/example code. This stems from the fact that currently our API documentation is in a poor shape, and that sometimes writing pure code is simpler than writing text...
A non negligible work that remains to be done on https://github.com/ARM-software/lisa/tree/next is to do a summer cleaning of those notebooks - remove redundant ones, remove those serving as pure API documentation, and only keep a few useful example ones. The rest should live in the documentation, and that can actually be CI-tested via https://docs.python.org/3.5/library/doctest.html.


seeing multiple annotations in Mondo

On this branch (issue-3170) (PR https://github.com/monarch-initiative/mondo/pull/3326)- I see two seeAlso annotations and three source annotations. I've seen duplicate source annotations on other branches, and sometimes I don't see it. I don't know which one we're supposed to use.
They are coming from different sources:
Source:

http://purl.obolibrary.org/obo/mondo#source
http://geneontology.org/formats/oboInOWl/#source
http://geneontology.org/formats/oboInOWl#http://purl.obolibrary.org/obo/mondo#source

SeeAlso:

http://geneontology.org/formats/oboInOWl#http://www.w3c.org/2000/01/rdf-schema#seeAlso
http://www.w3c.org/2000/01/rdf-schema#seeAlso

I cant confirm the seeAlso - it looks fixed on master. I fixed the rest in the above PR!

thank you @matentzn!


Add new EVM LLVM code emitter

Add new emitter which looks a lot like the existing llvm code emitter, however it should emit 256 bit registers.
https://github.com/etclabscore/evm_llvm

Unfortunately the llvm evm backend is no longer in development, which is a shame :disappointed:


"Unsupported architecture" exception on Raspberry Pi

Trying to execute the following command on a Raspberry Pi...
edge-impulse-linux-runner --download modelfile.eim
...results in an "unsupported architecture" error that seems to contradict itself:
[RUN] Failed to run impulse Error: Unsupported architecture "aarch64", only armv7l or aarch64 supported for now
    at RunnerDownloader.getDownloadType (/usr/lib/node_modules/edge-impulse-linux/build/cli/linux/runner-downloader.js:31:27)
    at async RunnerDownloader.getLastDeploymentVersion (/usr/lib/node_modules/edge-impulse-linux/build/cli/linux/runner-downloader.js:55:28)
    at async /usr/lib/node_modules/edge-impulse-linux/build/cli/linux/runner.js:123:31

Hi @rdlauer on the forum people have seen this with 64-bit Raspbian, switching to 32-bit should work fine. We're investigating.


Updated repos and added changes for Xcode 10.2

@VerizonAdPlatforms/video-partner-sdk-developers: Please review.

@RomanTysiachnik any updates here?

Should be merged as we have failing tutorials, that use old version of SDK that is not working on Xcode 10.2


Add mesh builder with examples

Here is a first proposal for #47
I am not sure about the documentation section could someone assist me there maybe?

Thank you @dotlogix


Send multiple parameters for searchParams in getStatements

Not exactly an issue, but I cant find anything related to this in the documentation.
Suppose I want to query for multiple parameters like all statements with verbs pause or play.
Or all Users whose id(mail) is on a particular domain, etc. How do I do such queries? If possible please
direct to a complete documentation on the searchParams object as it looks quite essential.
Thanks.

You're limited to the search functionality of xAPI. See the spec for search parameters: https://github.com/adlnet/xAPI-Spec/blob/master/xAPI.md#723-getstatements
As for how to use the wrapper with search parameters, refer to  https://github.com/adlnet/xAPIWrapper#get-statements-based-on-search-parameters
I will add another example to the readme

If it helps your use case, the xAPIDashboard project has a much more advanced querying interface, but has the downside of still requiring the download of unneeded statements as above. Use as desired.


cat shows 42 bytes for all files (emulator)

As indicated in the title, the cat command shows 42 bytes for all files within the emulator. Not tested on hardware.
Release: v0.12.0
Perhaps NeoBasic figured out the ultimate question and came up with the same answer.

It works on the real hardware :) it's just an emulator bodge.


Refactor React applications state management

This issue is created for tracking the $subject migration task.
There are multiple possibilities to do this task. Some of them are

Manage states using React Hooks and context API
Use Flux pattern implementation

MobX
Redux

With the introduction of React hooks, There react community has come up with many patterns that could replace a state management library with hooks + context API ,  After examining those pattern, We believe that we would able to survive with hooks + context API for API-Manager 3.x.x releases.
Because of that, We will close this issue.


React-scripts/fork-ts-checker-webpack-plugin constant high CPU usage when using material/icons

Is this a bug report?
Yes

Did you try recovering your dependencies?

Yes.
Which terms did you search for in User Guide?

fork-ts-checker-webpack-plugin and react-scripts combined with:
slow
stuck
cpu 100%
cpu pegged
Environment

npx: installed 1 in 2.147s
Path must be a string. Received undefined
C:\Users\Tamas\AppData\Roaming\npm\node_modules\create-react-app\index.js
Environment:
OS:  Windows 10
Node:  8.11.4
Yarn:  Not Found
npm:  5.6.0
Watchman:  Not Found
Xcode:  N/A
Android Studio:  Not Found
Packages: (wanted => installed)
react: ^16.8.1 => 16.8.6
react-dom: ^16.8.1 => 16.8.6
react-scripts: 2.1.8 => 2.1.8
Steps to Reproduce

Install @material/icons
import { AccessAlarm } from "@material-ui/icons"; in App.tsx
npm start

Expected Behavior

Once it has finished building, the cpu usage should become minimal.
Actual Behavior

One of the node processes, more specifically the fork-ts-checker-webpack-plugin, flips out and pushes the CPU non-stop (I left it there overnight and was still running high the day after)
Importing an icon in the wrong way (https://www.npmjs.com/package/@material-ui/icons) completely kills the node process.
Reproducible Demo

Demo:
https://stackblitz.com/edit/react-gv75il
A more illustrative way to see this happening is by trying it out locally. Then monitor the cpu usage of the fork-ts-checker-webpack-plugin.

I'm experiencing this exact same issue on OSX. I've noticed the CPU usage of the fork-ts-checker-webpack-plugin idling at around 70% and going even higher when the development server via yarn start is recompiling.
My project is only a handful of files but I too am using @material-ui/icons and after seeing this post, removed the module, and now the fork-ts-checker-webpack-plugin is idling at a much more reasonable 10% via htop or so. That still seems a bit high but I'm not sure what is typical for the process and it is at least 7 times better.
Just to add to the original post with some additional information since @CloneXpert is on Windows...
OS: Mac OSX 10.13.6 (High Sierra)
NodeJS: v10.15.3
npm: 6.4.1
create-react-app: 2.1.8
yarn: 1.15.2

package.json dependencies...
"dependencies": {
    "@material-ui/core": "^3.9.3",
    "@material-ui/icons": "^3.0.2",
    "@types/jest": "24.0.11",
    "@types/node": "11.13.0",
    "@types/react": "16.8.12",
    "@types/react-dom": "16.8.3",
    "axios": "^0.18.0",
    "react": "^16.8.6",
    "react-dom": "^16.8.6",
    "react-scripts": "2.1.8",
    "typescript": "3.4.2"
  }

Can anyone help at least with identifying what packages can cause this? I removed material icons completely and still have the same issue in my bigger application.

This is most likely related to https://github.com/Microsoft/TypeScript/issues/30663, and is not the fault of fork-ts-checker-webpack-plugin, but typescript itself. Pinning to<EMAIL_ADDRESS>should do the trick.

@CloneXpert were you able to try an older version of TypeScript to confirm?

Thanks for the suggestion. I did try and it was much faster as others were suggesting. However it doesn't solve the issue reported here. The fork-ts-checker-webpack-plugin still has a never ending high CPU usage. It works if I kill it, but it will respawn immediately after I save a change. I am still unable to point out what's causing it.

/cc @johnnyreilly have you seen this before?

Haven't experienced it myself - I've heard about memory issues with a recent release of TypeScript; possibly related.

although new TS versions don't work properly, I found out version above 2.1.4 of 'react-scripts', cause high cpu usage and CPU temperatures pikes.
Using 2.1.3 and everything fine.
Can somebody else confirm this please?

Thanks Pedro, that's super helpful.
Downgrading to 2.1.3 does indeed work much better. CPU usage dropped almost completely. So I guess it's a matter of finding out what change may be related to this in 2.1.4. Thanks everyone for looking into this.

@CloneXpert One good feature was async type check.
Files were deployed right after compiling, and you could browse through the website while type checks were made (that usually take some seconds)
It was a really good improvement from 2.1.5+
But I don't really want a flying MacBook Pro.
Even 1 build would spike CPU temperatures and max Fans.
Got reports from other developers using macbooks, with the same issue.
Linux and Window users don't seem affected with v2.1.8, hope this helps

There's some suggestions here that might be worth looking into: https://github.com/Realytics/fork-ts-checker-webpack-plugin/issues/236#issuecomment-484049558
I'm open to PRs that remedy any issues.

See https://github.com/Realytics/fork-ts-checker-webpack-plugin/pull/256 - we're currently mulling what the best way forward is.  But for now, setting this environment variable will resolve woes by all accounts: TSC_WATCHFILE=UseFsEventsWithFallbackDynamicPolling

I confirm the fix works like a charm

Ok
On Thu, Apr 18, 2019, 2:41 PM John Reilly<EMAIL_ADDRESS>wrote:

There's some suggestions here that might be worth looking into: Realytics/fork-ts-checker-webpack-plugin#236
(comment)
https://github.com/Realytics/fork-ts-checker-webpack-plugin/issues/236#issuecomment-484049558
I'm open to PRs that remedy any issues.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/create-react-app/issues/6792#issuecomment-484634661,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACMNNMRV7ARRWVZIRMBYHTPRC6GHANCNFSM4HFAROBA
.

Thanks, can confirm too that the setting fixes it.

To spread the knowledge about this issue (and the workaround) I've blogged it here: https://blog.johnnyreilly.com/2019/05/typescript-and-high-cpu-usage-watch.html
Hope it helps people reading this!

@johnnyreilly's solution woked for me. THANKS!! crying

Seems like updating to Typescript 3.5 improved the situation

Also still have this issue, but the fix did work!


Read and Write file actions and UT

Codecov Report

Merging #255 into trunk will increase coverage by 0.36%.
The diff coverage is 74.28%.

@@            Coverage Diff             @@
##            trunk     #255      +/-   ##
==========================================
+ Coverage   48.86%   49.22%   +0.36%
==========================================
  Files         144      144
  Lines        5192     5227      +35
  Branches      763      769       +6
==========================================
+ Hits         2537     2573      +36
+ Misses       2406     2404       -2
- Partials      249      250       +1


FORMS-9364 Changes for the name in panel edit.

Description
Changes for Missing name in panel.

Related Issue
FORMS-9364 -  Name field is showing empty for Panel component.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

@AnurudraS There are test case failure due to your changes.

Can you reformat the file ? Please run the build command before raising a PR.

Can you reformat the file ? Please run the build command before raising a PR.

Build was success in local checking and correcting


Why if not connect sending «uncaught exception» and script die?

Hello! Im use your cool lib but I have a question:
Why in Absrtact class, if not connect to server sending uncaught exception? Why not wrap it in try...catch.. block that script not died?

if (!$this->_hSocket) {
throw new ApnsPHP_Exception(
"Unable to connect to '{$sURL}': {$sError} ({$nError})"
);
}

you can use ApnsPHP_Exception to catch the exception
	try {
		$push->connect();
	} catch (ApnsPHP_Exception $e) {
		//log($e->getTraceAsString(), LOG_ERR);
	} catch (Exception $e) {
		//log($e->getTraceAsString(), LOG_ERR);
	}

Even I'm facing a similar issue. I am using this library in a cron job and if there are any exceptions thrown, then the code just exits! This stalls processing of other items in the loop resulting in same push notifications being sent multiple times cause they all end up getting stuck on the one errornous device token. I will have to now sit and re write all thrown exceptions to have catch statements. At least the library should've had an option to log the exceptions instead of just throwing them without catching them.


LIBXSMM v2 - Open Items

Rename at least functions which are exported and not adhering to best practices and typical API conventions. For example:

Replace term "create" with "get", i.e., by convention (and for a clean API), the term "create" is reserved for function pairs like "create" and "destroy", and it signals user's responsibility for taking ownership of some allocated data.
Alphabetical order of functions can matter and should prioritize function domains to sort together into a common group, e.g., libxsmm_matrix_eqn_create_exec_plan sorts together with all other functions of "libxsmm_matrix_eqn" domain.

Rename "_v2" functions.

GEMM fusing for ASIMD/SVE512/SVE256
Merging the SVE256 PR (#653)
SSE support eltwise
FP64 support across all archs and all kernels

Port implementation of C++ interface to v2-dispatch.

Document TPP and in particular the meaning of structure members like "primary" ... "quaternary". This should (re-)use the file documentation/libxsmm_be.md. The level of detail may be high-level ("general meaning"), and also start documenting particular items like "libxsmm_gemm_param".

Issue #460.

CI-test matequations.

Issue #592.

Matrix equation API allocates resources (create) but seems to miss companion function to release resources ("destroy"). The current implementation seems to leak memory in FE (API) and BE (code generator).

Improve documentation:

LIBXSMM: update outdated information
LIBXSMM-DNN: own minimal doc and reference with LIBXSMM
TPP Specification


function _sigmoid() question

Hi, I found in function _sigmoid(), you clamp the value between (1e-4, 1-1e-4) after sigmoid, why need to do this?
Here is the code:
def _sigmoid(x):
x = torch.clamp(x.sigmoid_(), min=1e-4, max=1-1e-4)
return x

We did it to make the training more stable.


--internal--only flag

Hello,
There is a typo in docs: --internal--only flag should be --internal-only

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: aa31b07f-e029-84da-4390-071cddebd0ee
Version Independent ID: 67b8a1e7-c45b-8ffa-3551-02c9c5cbb285
Content: Create a Consumption + Dedicated workload profiles environment (preview)
Content Source: articles/container-apps/workload-profiles-manage-cli.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@lukaskostial
Thanks for your feedback! We will investigate and update as appropriate.


dolibarr: 16.0.3 -> 16.0.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dolibarr/versions.
meta.description for dolibarr is: A enterprise resource planning (ERP) and customer relationship manager (CRM) server
meta.homepage for dolibarr is: https://dolibarr.org/
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 16.0.4 with grep in /nix/store/jb7qdlmih0wxvl0ivx7vryia3n2rffzm-dolibarr-16.0.4
found 16.0.4 in filename of file in /nix/store/jb7qdlmih0wxvl0ivx7vryia3n2rffzm-dolibarr-16.0.4

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
dolibarr

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jb7qdlmih0wxvl0ivx7vryia3n2rffzm-dolibarr-16.0.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dolibarr https://github.com/r-ryantm/nixpkgs/archive/e961b3bf8d28e0007069e8cd01a31af986601dc0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jb7qdlmih0wxvl0ivx7vryia3n2rffzm-dolibarr-16.0.4
ls -la /nix/store/jb7qdlmih0wxvl0ivx7vryia3n2rffzm-dolibarr-16.0.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dolibarr

Maintainer pings
cc @RaitoBezarius for testing.

Result of nixpkgs-review pr 216015 run on aarch64-darwin 1

Result of nixpkgs-review pr 216015 run on aarch64-darwin 1

I have no idea why passthru tests were considered as passing when they were clearly failing, alas. This is now fixed with the latest commit.


Cannot find module 'models' - Should be relative path ../models

Hey,
I imported "@sidetree/core": "^0.1.1-unstable.19", into a playground project and have problems building / running with the following: The error seems correct, since it apparently should reference a relative folder.
Changing 'models' to '../models' in both occurrences fixes the issue.
node_modules/@sidetree/common/dist/interfaces/IBlockchain.d.ts(1,37): error TS2307: Cannot find module 'models' or its corresponding type declarations.
node_modules/@sidetree/common/dist/interfaces/ICas.d.ts(2,37): error TS2307: Cannot find module 'models' or its corresponding type declarations.
I would do a PR, but forking and PRing from a remote seems a little overkill for two lines :)

@rado0x54 thanks for raising this.

@rado0x54 lmk if the deployment resolves it

Yes @OR13, that resolves it. Thanks for the quick turnaround.


default-centos-64 is not available

I am using Chef DK 0.4.0 on MacOSX 10.10.3. I got this message when I run "kitchen create default-centos-64" right after I installed Chef-DK.
default-centos-64 is not available now. The default platforms on .kitchen.yml should be ones on the list here: https://github.com/chef/bento.
-----> Creating <default-centos-64>...
       Bringing machine 'default' up with 'virtualbox' provider...
       ==> default: Box 'centos-6.4' could not be found. Attempting to find and install...
           default: Box Provider: virtualbox
           default: Box Version: >= 0
       ==> default: Adding box 'centos-6.4' (v0) for provider: virtualbox
           default: Downloading: centos-6.4
An error occurred while downloading the remote file. The error
       message, if any, is reproduced below. Please fix this error and try
       again.

       Couldn't open file /Users/yohei/work/test-kitchan-sample/.kitchen/kitchen-vagrant/kitchen-test-kitchan-sample-default-centos-64/centos-6.4
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: Failed to complete #create action: [Expected process to exit with [0], but received '1'
---- Begin output of vagrant up --no-provision --provider virtualbox ----
STDOUT: Bringing machine 'default' up with 'virtualbox' provider...
==> default: Box 'centos-6.4' could not be found. Attempting to find and install...
    default: Box Provider: virtualbox
    default: Box Version: >= 0
==> default: Adding box 'centos-6.4' (v0) for provider: virtualbox
    default: Downloading: centos-6.4

STDERR: An error occurred while downloading the remote file. The error
message, if any, is reproduced below. Please fix this error and try
again.

Couldn't open file /Users/yohei/work/test-kitchan-sample/.kitchen/kitchen-vagrant/kitchen-test-kitchan-sample-default-centos-64/centos-6.4
---- End output of vagrant up --no-provision --provider virtualbox ----
Ran vagrant up --no-provision --provider virtualbox returned 1]

centos should be "centos-66" or "centos-71".

Sorry this is an issue for test-kitchen..


wont exit loop

which loop ?

I fixed the problem. derserialiseCanvas was using setPixel which redraws the canvas (ie. Massive lag)


Update limits-and-config.md

@PriyaKodukula : Thanks for your contribution! The author(s) have been notified to review your proposed change. @msftman

@PriyaKodukula : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Refactor cloudevent implementation

Refactor cloud event implementation https://github.com/eclipse-uprotocol/up-cpp/tree/main/include/up-cpp/cloudevent
Update and write new unit-tests

@stevenhartley has clarified cloudevent is not needed yet. We can address in the future when cloudevent is needed. Closing issue as won't fix.


Add runstatus component

Related to: https://github.com/go-gitea/gitea/pull/23212#discussion_r1122856231
Decrease duplication of SvgIcon when display a run status svg.

Codecov Report

Merging #23259 (44646a9) into main (33e556e) will increase coverage by 0.11%.
The diff coverage is 55.64%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main   #23259      +/-   ##
==========================================
+ Coverage   47.44%   47.55%   +0.11%
==========================================
  Files        1140     1143       +3
  Lines      150804   151077     +273
==========================================
+ Hits        71549    71851     +302
+ Misses      70788    70729      -59
- Partials     8467     8497      +30

Impacted Files
Coverage Δ

cmd/serv.go
2.59% <0.00%> (-0.06%)
:arrow_down:

models/actions/run.go
1.72% <0.00%> (+0.01%)
:arrow_up:

models/actions/run_list.go
0.00% <0.00%> (ø)

models/actions/status.go
22.85% <0.00%> (-1.39%)
:arrow_down:

models/actions/task.go
1.69% <0.00%> (-0.01%)
:arrow_down:

models/auth/oauth2.go
60.52% <ø> (ø)

models/auth/twofactor.go
19.73% <ø> (ø)

models/db/engine.go
44.80% <ø> (ø)

models/unittest/testdb.go
12.92% <0.00%> (ø)

modules/auth/password/hash/pbkdf2.go
69.69% <ø> (ø)

... and 115 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

A question about the structure, why isn't runstatus.js put into the js/components folder?

A question about the directory structure, why isn't runstatus.js put into the web_src/js/components folder?

I didn't notice this problem, as svg.js was in web_src/js.
Then,
I also have a question, why .vue files are in web_src/js/components.
And,
we also have a folder called webcomponents, what is the difference between them.

we also have a folder called webcomponents, what is the difference between them.

See  Add document for webcomponents #23261

It should be another vue file.

Should we backport this PR?

Should we backport this PR?

I think yes.

I was unable to create a backport for 1.19, please send one manually. :tea:


How do you handle parentheses when building the expression?

Hey Dave,
Nice little library. Just wondering how you would approach building in parenthesis?

Hi natiki,
I'm taking a look into it and may have found a way to implement it. But, as I'm still not sure of it, would you mind helping me think of examples where that approach would be useful? I'm struggling a bit to find valid test cases that I could use.
The best that I could come up with so far was this:
var company = new Person.Company { Name = "Back to the future", Industry = "Time Traveling Agency" };

People = new List<Person>
{
        new Person { Name = "John Doe", Gender = PersonGender.Male, Birth = new Person.BirthData { Date = new DateTime(1979, 2, 28), Country = "USA" }, Employer = company },
        new Person { Name = "Jane Doe", Gender = PersonGender.Female, Birth = new Person.BirthData { Date = DateTime.Now.AddYears(-16), Country = " " } },
        new Person { Name = "Wade Wilson", Gender = PersonGender.Male, Birth = new Person.BirthData { Date = new DateTime(1973, 10, 9), Country = "USA" } },
        new Person { Name = "Jessica Jones", Gender = PersonGender.Female, Birth = new Person.BirthData { Date = DateTime.Now.AddYears(-16), Country = "USA" } },
        new Person { Name = "Jane Jones", Gender = PersonGender.Female, Birth = new Person.BirthData { Date = new DateTime(1980, 12, 20), Country = "USA" } },
        new Person { Name = "Fulano Silva", Gender = PersonGender.Male, Birth = new Person.BirthData { Date = new DateTime(1983, 5, 10), Country = "BRA" }, Employer = company },
        new Person { Name = "Fulana da Silva", Gender = PersonGender.Male, Birth = new Person.BirthData { Date = DateTime.Now.AddYears(-16), Country = "BRA" } },
        new Person { Name = "John Hancock", Gender = PersonGender.Male, Employer = company }
};

var eighteenYearsAgo = DateTime.Now.AddYears(-18);
//Selecting people younger than 18 years in USA and older than 18 in BRA at once
People.Where(p => ((p.Birth != null && p.Birth.Date != null && p.Birth.Date > eighteenYearsAgo) && p.Birth.Country == "USA")
                || ((p.Birth != null && p.Birth.Date != null && p.Birth.Date < eighteenYearsAgo) && p.Birth.Country == "BRA"));

What do you reckon? Could you think of something else?
Many thanks,
David

Hi Donovan,
I uploaded a release candidate version to NuGet today that finally has support for "complex expressions" (parentheses handling).
If you add the reference through the "Manage NuGet packages" option in Visual Studio, don't forget to tick the "Include prerelease" option (otherwise, this version won't be listed).
Many thanks,
David


[BEAM-8213] Split up monolithic python preCommit tests on jenkins

See the Jira issue for details: https://issues.apache.org/jira/browse/BEAM-8213#

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @lgajowy
R: @kkucharc
R: @echauchot
R: @robertwb
R: @udim
Well, I tried my hand at this, but it's not showing the new jobs, so I'm not sure whether there's something I need to update to make the Jenkins config pull from this PR, or if we've got a chicken/egg situation wrt to testing if this new configuration works.

Run PythonLint PreCommit

I believe you need to run a seed job to get the new jobs recognized by Jenkins.
R: @yifanmai could help with the specifics of seed job.
R: @tvalentyn for reviewing wrt to python 3 jobs.

To run a seed job on your PR you can say "Run Seed Jøb" (using ø to avoid triggering the job by this comment).
After seed job finishes (~10 min), run you can run jenkins jobs defined in this PR.
Note that seed job launched on the PR will affect other test executions, so consider giving a heads-up on dev. Seed job runs periodically, so at some point we will restore to the job specs using SOT in master.

Overall, this LGTM. We need to make sure that trigger phrases work, are visible, and by default all precommits run on python PRs .
Main concern: this change may increase precommit queue, since each job will require a jenkins slot, of which we have 16 VMs * 2 slots per VM. What required 1 slot will now require 5. @yifanzou  what's your take on this? We may want to increase the amount of slots, and should monitor the precommit queue time after this is merged.

/cc @youngoli on the last comment. Daniel was pointing out to long queue times due to the increase in number jobs.

We're still doing the same amount of work, so IIUC, assuming we get similar CPU-utilization in this new configuration, these 5 jobs should finish in the time it took the previous single job to finish, plus whatever overhead is required per job to bootstrap the tests.

I think the concern is that we may have higher test concurrency since we splitting the big python job into multiple pieces. The Jenkins job waiting queue cloud be longer. In addition, this may also lead higher stress on gcp resources usage, such as CreateJobPerMinutePerUser, and computing engine quotas.

I think the concern is that we may have higher test concurrency since we splitting the big python job into multiple pieces.

I don't really follow this point. We can't have higher concurrency than the 32 slots that are available, right?  Splitting the work previously done by one job across 5 jobs only affects the amount of work done concurrently at times when all the slots in the queue were not previously full, i.e. there were more slots that could have been expanded to, but not enough jobs to fill them.  But even in the case where we might now make use of those free slots (which is a good thing!), the number of slots in use would still be less than or equal to 32.
I'm new to this project so there are some important details that I may be overlooking, but that's how it looks to me based on my experience with work queues.

In addition, this may also lead higher stress on gcp resources usage, such as CreateJobPerMinutePerUser, and computing engine quotas.

After this change it will be slightly more likely that multiple slots are consumed by python jobs than before, since there are now more python job types (if we assume the type of job in each spot is a random sample of all job types).  So in terms of CPU resources, there would be more stress than before if we think that the python jobs are using more CPU resources than the Java and Go jobs, which I find quite unlikely.  However, If we're talking about IO usage, it is plausible that there will be more stress on the system because it will be more likely than before that two or more jobs are accessing the same data for integration tests.
But all-in-all, since we're doing exactly the same work as before, and we have a limit on the number of jobs that can run concurrently, it seems unlikely to me that there will be a significant increase in resources used, time spent waiting for the queue to clear, or stress on the existing resources.

Note that seed job launched on the PR will affect other test executions, so consider giving a heads-up on dev.

Can you describe how other jobs will be affected so that I can send out a proper warning, pease?

As far as queue times go, I think the impact of this should be minimal. Like Chad mentioned, although it will take up 5 Jenkins slots, the overall work is equivalent they should take about 1/5 as long (or slightly longer if you include setup time).
I think the main mitigation here is that these are precommits and not postcommits. Since it's not set to run on any kind of regular schedule I'm less worried about sudden spikes in Jenkins usage. And even if the slots do all get full, the shorter time for these precommits means that slots would be available sooner.
So I don't think this is worth blocking on for that reason. But I'd measure how long the tests take to check that splitting the test didn't drastically increase the total amount of work, and I'd keep an eye on overall latency via these two pages:
http://<IP_ADDRESS>/d/_TNndF2iz/pre-commit-test-latency?orgId=1
https://builds.apache.org/label/beam/load-statistics?type=min

Can you describe how other jobs will be affected so that I can send out a proper warning, pease?

If you do seed job then it will update Jenkins and the github setup here in total, not just for this PR. So during that time where your change is live, all PRs will run the split precommits. If those precommits are failing for whatever reason then you'll be blocking those PRs. So ideally you'll want to warn devs first and if it causes problems, the do it again with a clean environment to undo your changes (this also occurs automatically in 8 hour intervals, but that's too long if the precommits are failing).

the overall work is equivalent they should take about 1/5 as long (or slightly longer if you include setup time).
I don't think we will have 1/5 reduction, since currently Python 2.7, 3.5, 3.6, 3.7 precommits are already executing in parallel (by way of gradle parallelism) on the same Jenkins worker taking up one slot, so we will still have a parallel execution but will require 4x more slots.

Increasing slots per worker may help, but there are some potentially heavy-weight tests, such as portable python precommit tests that bring up Flink, that may cause jenkins VMs to OOM if we run a lot of them in parallel on the same VM. I have heard of a second hand account that parallelizing  portable precommit tests 4x on the same Jenkins worker caused OOMs, but did not verify myself. Perhaps not an issue, but we need a reliable way to monitor Jenkins worker health / utilization to be confident.

I don't think we will have 1/5 reduction, since currently Python 2.7, 3.5, 3.6, 3.7 precommits are already executing in parallel (by way of gradle parallelism) on the same Jenkins worker taking up one slot, so we will still have a parallel execution but will require 4x more slots.

I believe he was saying that each of the 5 jobs will take on average 1/5th the time it took before.  Each job will continue to run in parallel, so that I think this is basically true, excepting for the fact that there are some differences between the jobs (lint is fast, some python versions run IT, some don't), but I agree in principle.

Increasing slots per worker may help, but there are some potentially heavy-weight tests, such as portable python precommit tests that bring up Flink, that may cause jenkins VMs to OOM if we run a lot of them in parallel on the same VM.

This PR does not split up the Python_Portable PreCommit tests that start up flink.

Run Seed Job

Run PythonLint PreCommit

I believe he was saying that each of the 5 jobs will take on average 1/5th the time of the current monolithic job.

The monolythic job already runs 4 out of 5 tasks in parallel - I do not see where 80% speedup will come from.

Increasing slots per worker may help, but there are some potentially heavy-weight tests, such as portable python precommit tests that bring up Flink, that may cause jenkins VMs to OOM if we run a lot of them in parallel on the same VM.

This PR does not split up the Python_Portable PreCommit tests that start up flink.

My comment refers to a possible mitigation option for the increased demand for Jenkins slots as a result of this PR. Such option is to increase amount of Jenkins slots per Jenkins VM (for example, 5 slots instead of 2 slots). However it can possibly create as scenario where Jenkins VM has to run several high-demanding jobs, and will be overutilized.

Retest this please

@youngoli @tvalentyn   I could use a little help.  I ran the seed job phrase, waited 20 minutes, and tried to retrigger the tests, but no luck.

Run Seed Job

The monolythic job already runs 4 out of 5 tasks in parallel - I do not see where 80% speedup will come from.

I think this is just a communication error.  We're saying that the sum of the running time of all the 5 jobs will be the same or more than the old monolithic job, but each will be on average 1/5th the time of the old monolithic job.  We're not saying that the sum of all 5 jobs will be faster.

I now see: Jenkins: "Seed Job Pending — Build triggered for merge commit." - once started, you should be able to monitor status at https://builds.apache.org/job/beam_SeedJob/

I now see: Jenkins: "Seed Job Pending — Build triggered for merge commit." - once started, you should be able to monitor status at https://builds.apache.org/job/beam_SeedJob/

I don't see the new jobs listed at https://builds.apache.org/job/beam_SeedJob/.  Should I?

I think this is just a communication error. We're saying that the sum of the running time of all the 5 jobs will be the same

I think the walltime run of new jobs will be the same or slightly faster, since lint will run in parallel.

but each will be on average 1/5th the time of the old monolithic job.

I don't see why this would be the case - lint job will run much faster, precommits - same time as now minus time to run lint, so slightly faster, but not 1/5th of the time.

This is the seed job: https://builds.apache.org/job/beam_SeedJob/4938/. Once this job completes, you should be able to trigger the jobs defined in this PR using respective trigger phrases.

I don't see why this would be the case - lint job will run much faster, precommits - same time as now minus time to run lint, so slightly faster, but not 1/5th of the time.

I think I see your point now.  Gradle runs tasks in parallel, but after this change each job will have only one or two Gradle tasks, instead of the 7 or 8 it had before.  How many CPUs does each VM have?
We could mitigate this by running nose tests in parallel:  https://nose.readthedocs.io/en/latest/doc_tests/test_multiprocess/multiprocess.html
I've done this with nose and also with pytest using the xdist plugin.

The monolythic job already runs 4 out of 5 tasks in parallel - I do not see where 80% speedup will come from.

I think this is just a communication error. We're saying that the sum of the running time of all the 5 jobs will be the same or more than the old monolithic job, but each individual job will be on average 1/5th the time of the old monolithic job. We're not saying that the sum of all 5 jobs will be faster.

What Valentyn means is that the monolithic job is already running the tests in parallel within one Jenkins slot. I didn't know that, but if that's the case then splitting the tests wouldn't make them finish faster, it would just continue running the tests in parallel, but using 5 Jenkins slots instead of 1.

Increasing slots per worker may help, but there are some potentially heavy-weight tests, such as portable python precommit tests that bring up Flink, that may cause jenkins VMs to OOM if we run a lot of them in parallel on the same VM. I have heard of a second hand account that parallelizing portable precommit tests 4x on the same Jenkins worker caused OOMs, but did not verify myself. Perhaps not an issue, but we need a reliable way to monitor Jenkins worker health / utilization to be confident.

Is there a way to distribute tests to workers with the lowest resource utilization? Or even better, have resource benchmarks for our various test suites so we can avoid sending resource-intensive tests to workers that don't have enough available resources? I don't really know how Jenkins works so that might be a little advanced, but it would definitely avoid that problem and let us increase the number of slots in the workers without hitting resource limits.

PythonLint completed successfully in 3:40!

Python35, 36, and 37 all finished successfully in about 46 minutes.   Python2 is still going.
So the total is definitely going to be higher.  It was about 75 minutes total before.

Run CommunityMetrics PreCommit

Python2 completed successfully in 75 minutes.

All new tests passing.  This PR looks good to go.
I'll peek in at the PR for porting tests to pytest to see about using xdist there to speed these up.
Perhaps in the meantime we can consider more jenkins slots per VM, as discussed.

Should not we address the jenkins slots issue before merging this PR. Based on my understanding so far, we are reducing a 75 min job to 4 40 something jobs. This will increase the queue lengths and will impact the developer experience for everyone. Am I missing something?

No, I think you're right. These tests shouldn't be seperated just yet (with the possible exception of PythonLint. At less than 5 minutes it seems ok to split). I think the best approach is to look into increasing the number of jenkins slots open, along with trying to find some solution that can load balance the resource usage between VMs.
If we can do that, then this change should be a net positive, since it doesn't actually increase resource usage (just jenkins slots used), and splitting up the precommits makes logical sense. I think it would be helpful to find someone who knows a lot about Jenkins to see if that load balancing idea is possible.

Should not we address the jenkins slots issue before merging this PR. Based on my understanding so far, we are reducing a 75 min job to 4 40 something jobs. This will increase the queue lengths and will impact the developer experience for everyone. Am I missing something?

It's actually worse than that.  The total time for all 5 python jobs was 217 minutes, which is 142 minutes longer than before.
Heres a break down of the time:

Python (old): 75
Metrics: 2
Go: 3.5
Java: 56
JavaBeamZetaSQL: 2.5
JavaPortability: 14
Java_Examples_Dataflow: 15
Portable_Python: 22
Python_PVR_FLink: 12
RAT: 0.5
Spotless: 1
Website: 5
Website_Stage_GCS:  4.5

Total: 213 minutes
Adding 142 minutes to this is a 66% increase.  That's pretty bad.
I'll leave it up to you all to decide the best course of action.  Longer term, I think parallelizing the python tests at the runner level (nose or pytest) is the best solution, but in the short term increasing the number of slots per VM is worth exploring, but not without risks.  Not merging this is the other option.

I support the idea of separating PyLint for immediate benefit. I see this impacts most first time contributors. And separately figuring out how are we going to parallelize the other tests.

I looked at Python 2 tests. The reason they are slower is that they run 2 precommit integration tests - batch and streaming wordcount tests, taking up 33 min.
We used to have a task  ":sdks:python:test-suites:dataflow:py37:preCommitIT", and these tests were supposed to run in Python 3.7 in addition to Python 2.7. This was added in https://github.com/apache/beam/pull/8728/. We decided to pick only one Py3 version for these tests to save quota. I looks that we may have stopped running these ITs on Python 3.

Nevermind, we still run wordcounts  them on Python 3.7.

https://builds.apache.org/job/beam_PreCommit_Python2_Commit/1/testReport/ says Py2 suite completed in 56 min, while it took 75 mi as per https://builds.apache.org/job/beam_PreCommit_Python2_Commit/1, not including waiting time. Not sure where the 20 min difference comes from.

But, if we get to run precommit IT suites in parallel, we should significantly lower the execution time. I think it makes sense to move them into separate jenkins job.

I support the idea of separating PyLint for immediate benefit. I see this impacts most first time contributors. And separately figuring out how are we going to parallelize the other tests.

I might not have time to get back to this until Friday.  What should we do in the meantime?

I think I see your point now. Gradle runs tasks in parallel, but after this change each job will have only one or two Gradle tasks, instead of the 7 or 8 it had before. How many CPUs does each VM have?

We use n1-highmem-16 (16 vCPUs, 104 GB memory)

We use n1-highmem-16 (16 vCPUs, 104 GB memory)

Ah yeah, that's a lot of CPUs for these python tests.

But, if we get to run precommit IT suites in parallel, we should significantly lower the execution time. I think it makes sense to move them into separate jenkins job.

Should I try that first and see how it goes, or do the idea of just creating a separate Lint job first?

Is there a way to distribute tests to workers with the lowest resource utilization? Or even better, have resource benchmarks for our various test suites so we can avoid sending resource-intensive tests to workers that don't have enough available resources

We could classify the jobs into high-demand and low-demand, and use separate jenkins worker pools for them. Low-demand can use workers with a lot of slots.
Perhaps we can somehow configure Jenkins to not take more than X jobs of type Y, if that is possible. Folks familiar Jenkins could advise here. Do you have any thoughts @yifanzou ?

We use n1-highmem-16 (16 vCPUs, 104 GB memory)

Ah yeah, that's a lot of CPUs for these python tests.

But, if we get to run precommit IT suites in parallel, we should significantly lower the execution time. I think it makes sense to move them into separate jenkins job.

Should I try that first and see how it goes, or do the idea of just creating a separate Lint job first?

+1 for separting linter, we can just do it and since this job completes fast, it will be an immediate benefit with little/no overhead on the submission queue.
Separating Precommit ITs,  and the other precommit tests,  and parallelizing running unit test all seems worthwhile. Increasing a number of slots I think is very possible here, we may need someone from test infrastructure help us to do this without breaking workers and decreasing the submission  queue. CCing a few more folks (@alanmyrvold @yifanzou @markflyhigh )

Should I try that first and see how it goes, or do the idea of just creating a separate Lint job first?

+1 for separting linter, we can just do it and since this job completes fast, it will be an immediate benefit with little/no overhead on the submission queue.

Consider doing this in separate PR, to keep the history of jenkins runs on this PR.

And, thanks a lot for helping with making precommits faster, @chadrik !

I suggest move this discussion to dev@ since we had similar discussions before and many other people also have insights to this problem.
For me, I don't see big benefit to do this split (1 job to 5 jobs).

The painpoints you mentioned about pylint failure doesn't require this change. I agree with the approach to split pylint alone. Similar thing is done in Java (RAT) and we could move pylint into that as well (or put in a separate job).
For logging, Gradle scan organize logs by task and provide a pretty good UI to surface the error. The link is in Jenkins job page. Did you have a chance to explore that?
For efficiency, this split will not shorten the walltime of the precommit run, on the contrary, adding requirement of extra 4 job slots. Given that those are precommit and the run frequency is very likely high (triggered by each commit push and manual in PR), it's likely to increase the precommit queue time.
I agree with Daniel's proposal in https://github.com/apache/beam/pull/9642#issuecomment-535241993 if we want to proceed this change.

Closing this until we move to pytest and xdist


[Fixes #6224] Add logging variants of system piping

Objective
Fixes #6224, add dbg, info, warn and error system piping adapter variants to expand #5776, which call the corresponding re-exported bevy_log macros when the result is an error.
Solution

Added dbg, info, warn and error system piping adapter variants to system_piping.rs.
Modified and added tests for these under examples in system_piping.rs.

I am so keen to get these added to Bevy itself: this pattern is incredibly useful.
I've left some suggestions for better documentation.

Great! I will try to implement these suggestions right away.

Please run cargo fmt --all =)

Once you've fixed up reviewers' comments, please resolve the conversation so others can see what still needs to be fixed :)

Very nice.
In the future, I think we should look into ways of including the input system's name in these error messages.

Yeah, I agree. I thought about implementing something like that.

@Edwox if you get a chance before I merge this, can you add these adaptors to the bevy_ecs prelude? These seem widely useful.

@Edwox if you get a chance before I merge this, can you add these adaptors to the bevy_ecs prelude? These seem widely useful.

Sure, I'll get right on it!

@Edwox Once CI is passing I'll merge this. Please ping me if I forget!

bors r+


Add custom script tutorial

Pull Request Test Coverage Report for Build 92

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 70.442%

Totals

Change from base Build 91:
0.04%

Covered Lines:
2009

Relevant Lines:
2852

💛  - Coveralls

Fix 11241c75198d51f10f9ac9242851eb2387915b67 commited.


Feature/lifj

Codecov Report

Merging #65 into develop will decrease coverage by 4.16%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop      #65      +/-   ##
===========================================
- Coverage    70.62%   66.45%   -4.17%
===========================================
  Files          200      200
  Lines        10569    10572       +3
===========================================
- Hits          7464     7026     -438
- Misses        3105     3546     +441

Impacted Files
Coverage Δ

framework/render/video/vsync/VSyncFactory.cpp
100% <ø> (ø)
:arrow_up:

framework/muxer/ffmpegMuxer/MetaToCodec.cpp
91.89% <66.66%> (-2.23%)
:arrow_down:

framework/tests/dataSource/ipList.h
0% <0%> (-100%)
:arrow_down:

framework/tests/demuxer/demuxerUnitTest.cpp
0% <0%> (-100%)
:arrow_down:

framework/tests/decoder/decoderUnitTest.cpp
0% <0%> (-93.48%)
:arrow_down:

framework/tests/dataSource/dataSourceUnitTest.cpp
0% <0%> (-93.34%)
:arrow_down:

framework/tests/demuxer/demuxerUtils.cpp
0% <0%> (-76%)
:arrow_down:

framework/data_source/ffmpeg_data_source.cpp
9.37% <0%> (-65.63%)
:arrow_down:

framework/demuxer/AVBSF.cpp
25.27% <0%> (-42.86%)
:arrow_down:

mediaPlayer/subTitle/subTitlePlayer.h
50% <0%> (-37.5%)
:arrow_down:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a74103...ee68f85. Read the comment docs.


Any prediction code example?

First off, thanks for your great work. And I wonder more code example of prediction .

I'm also wonder the code for prediction , thanks if you can provide  it.

First off, thanks for your great work. And I wonder if you can provide the data process code.I want to the same thing as using associated contours to draw the tumor area.


Uncaught TypeError: Cannot read properties of undefined (reading 'call')

Bug report

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?

Other relevant information:
webpack version:
Node.js version:
Operating System:
Additional tools:

Hey, this is not completed, still facing this issue https://github.com/module-federation/universe/issues/866


feature: command line interface

creating an openssl style cli would increase the accessibility and usability of this library

This one wont be too hard. It will simply involve a lot of console input scanning and println!s. Our ultimate goal is produce something similar to the openssl cli. Heres an example of hashing a file with openssl:
openssl dgst -sha256 /path/to/your/file.txt

We want our library for now to expose a CLI that would allow it to be used in a similar manner above:
capycrypt compute_sha3_hash "So long and thanks for all the fish" -256

Where 256 is the security strength passed after the message to digest.

This project can probably be started as an entirely separate repo. Heres some starter code that exposes compute_sha_3_hash to a CLI:
use structopt::StructOpt;
use capycrypt::{Hashable, Message};

#[derive(StructOpt, Debug)]
#[structopt(name = "hasher")]
enum Opt {
    Sha3(Sha3Opts),
    // Add other subcommands as needed
}

#[derive(StructOpt, Debug)]
struct Sha3Opts {
    /// String to be hashed
    #[structopt(short, long)]
    input: String,

    /// Number of bits for the SHA3 hash
    #[structopt(short, long, default_value = "256")]
    bits: u16,
}

fn main() {
    match Opt::from_args() {
        // Here is where compute_sha_3_hash in handled and executed
        Opt::Sha3(opts) => {
            let mut data = Message::new(&mut opts.input.into_bytes());
            data.compute_sha3_hash(opts.bits as usize);

            match data.digest {
                Some(digest) => println!("Hash: {}", hex::encode(digest.to_vec())),
                None => eprintln!("Error: Hash computation failed"),
            }
        }
        // Handle other subcommands, such as compute_tagged_hash for ex
    }
}

Heres some nifty starter code that takes full advantage of rust's unique functional style paradigm. You can use this to get started:
use structopt::StructOpt;
use capycrypt::{Hashable, Message};

#[derive(Debug, StructOpt)]
#[structopt(name = "capycrypt-cli", about = "A simple hashing CLI")]
enum Command {       //enums and structs in rust can be used almost interchangeably.
    #[structopt(name = "compute_sha3_hash")]
    Sha3 {
        #[structopt(help = "The input string to hash")]
        input: String,

        #[structopt(help = "Number of bits for the SHA3 hash", short, long, default_value = "256")]
        bits: u16,
    },
}

fn main() {
    match Command::from_args() {
        Command::Sha3 { input, bits } => {
            let mut data = Message::new(&mut input.into_bytes());
            data.compute_sha3_hash(bits as usize);

            match data.digest {
                Some(digest) => println!("Hash: {}", hex::encode(digest.to_vec())),
                None => eprintln!("Error: Hash computation failed"),
            }
        }
    }
}

Next, build the library (might take awhile, imo this is the only bummer about rust)
cargo build --release

Next, navigate to the target/release directory:
cd target/release

Then, run as follows:
./capycrypt-cli compute_sha3_hash "so long and thanks for all the fish" --bits 256

Some of this syntax might look kind of wild at first, but don't be intimidated, its actually really easy and logical to use! This is a great project to take on and become familiar with rust and capycrypt. The more complex functions involving keypairs may be a bit more involved, but Im here to help at every step of the way. This is something that a beginner can definitely take on with no problem at all.

For writing a CLI for the library, or other functionalities that use the public API of the library, one needs to define a SecParam enum in their own code and pass it as an argument to the function (for example, compute_hash_sha3).
However, since functions like compute_hash_sha3 are intended for public access, I believe it would be better to accept an integer as input (instead of SecParam). This integer can then be converted to SecParam inside the compute_hash_sha3 function.
If this is correct, I can proceed to open an issue on this.

Yeah I think thats exactly correct. The CLI can have machinery behind the scenes that can parse the input from the arguments passed into it. So we really want this syntax for a good CLI:
capycrypt compute_sha3_hash "Test message" -256
The CLI can parse that 256 into the supported enum behind the scenes and then throw an error back if it was an unsupported value

heres a more up-to-date example of how the initial CLI can be built around:
use structopt::StructOpt;
use capycrypt::{Hashable, Message, SecParam, OperationError};

#[derive(Debug, StructOpt)]
#[structopt(name = "capycrypt-cli", about = "A simple hashing CLI")]
enum Command {
    #[structopt(name = "compute_sha3_hash")]
    Sha3 {
        #[structopt(help = "The input string to hash")]
        input: String,

        #[structopt(help = "Security parameter for the SHA3 hash", short, long, default_value = "256")]
        sec_param: String, // Changed to String to directly parse into SecParam later
    },
}

fn main() {
    let result = Command::from_args();
    match result {
        Command::Sha3 { input, sec_param } => {
            let mut data = Message::new(&mut input.into_bytes());
            let sec_param = match sec_param.as_str() {
                "224" => SecParam::D224,
                "256" => SecParam::D256,
                "384" => SecParam::D384,
                "512" => SecParam::D512,
                _ => {
                    eprintln!("Unsupported security parameter. Use 224, 256, 384, or 512.");
                    return;
                }
            };

            match data.compute_hash_sha3(&sec_param) {
                Ok(_) => match data.digest {
                    Some(digest) => println!("Hash: {}", hex::encode(digest.to_vec())),
                    None => eprintln!("Error: Hash computation failed"),
                },
                Err(OperationError) => eprintln!("An error occurred during hash computation."),
            }
        } // Next command here, i.e., compute tagged hash
    }
}

This how you could build it out while ensuring that the security parameter is instantiated correctly


Allow uploading of files

Quasar has ways to upload files. We should allow file-uploads, restrcited mind you, so users do not have to copy'n'paste their raw json into the field. Said field will stay, it is just that allowing file uploads should also be possible.

After looking into this, it appears that implementing this feature is impossible without some form of backend which handles the file upload. Webpack/Vue prevents the use of fs and thus working with files, which in turn means that we either need some NodeJS server or some other form of backend to recieve the file we want to upload.
Possible solutions:

NodeJS backend to recieve the file and return the text said file contains (personally no experience)
Spring Boot backend, (REST API) to handle file uploads (personally limited experience)


Standard object/dynamic type

All classes are fully dynamic right now but there is no default class to use when wanting to act in a fully dynamic way. Adding a new type to the standard classes, where list currently lives, that meets this common need is a good idea rather than every script that wants to act in a dynamic way having to create it's own empty class to do so.
In langs like js or lua you might do var obj  = {}; and then go from there.

The ={} approach would make sense if we supported tuples in the language, but we don't right now so a class with no default vars or methods is a straightforward answer.


Make this package's dependency on the Serilog UPM package explicit

I intentionally did not make a dependency on xoofx's nuget project for a few reasons:

Some people use other alternatives: NuGetForUnity, custom build tasks, or just putting DLLs into version control, and adding this dependency will break those
If they host their own NuGet registry, with a different name than the one used by xoofx's it will break that too

Other than that the dependency setup is documented in the readme

Fair points; thanks for clarifying 👍


improvement: retrieve current locale used

Sometimes the translations are not in a resource bundle but in the beans themselves. For instance, imagine an Article which may have a name translated to multiple languages. The best way to handle this would be to have the locale parameter available directly on the template.

If you are using pebble-spring3, I have just maded a pull request (https://github.com/mbosecke/pebble-spring3/pull/5) to access the current locale.

@ebussieres that looks amazing!. Sadly I'm using Pebble calling it directly to generate an email from a template. I'll check your commit and I can try to pull the same functionality for no-spring use.

You can just create a simple function like this
public class LocaleFunction implements Function {
    @Override
    public Object execute(Map<String, Object> args) {
        EvaluationContext context = (EvaluationContext) args.get("_context");
        return context.getLocale();
    }

    @Override
    public List<String> getArgumentNames() {
        return null;
    }
}

I'll use that function and, if I can vote, I'd put it on the core list of available functions.

Added a global variable called "locale" in commit 4862f9d. It can be accessed just like any other user-provided variable:

The current locale is: {{ locale }}


build: Update SPIRV-Tools and glslang to latest

CI Vulkan-ExtensionLayer build queued with queue ID 186736.

CI Vulkan-ExtensionLayer build # 919 running.

CI Vulkan-ExtensionLayer build # 919 passed.


08/01/2018 18:12 : Create Pull Request for branch master -> prTesting1_2018080118

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remove unnecessary lineTo calls in immediate polygon rendering

This removes unnecessary lineTo() calls in ring drawing in the canvas immediate API.
As the current tests demonstrate, we do two unnecessary lineTo() calls to the last point of the ring before calling closePath().  Instead, we can omit the lineTo() call to the last point altogether (since it should be the same as the first point) and just call closePath().
The rendering tests demonstrate that things work as expected.  And the unit tests are updated to avoid making assertions about the unnecessary lineTo() calls.
This means that we are not tolerant of open rings in the immediate API.  We could always do a lineTo() to the last point in a ring and then call closePath() if we want to tolerate open rings.

This is great. Couldn't the canvas replay get the same optimisation?
Please merge.


Fixes for compatibility with latest versions of Matplotlib

This includes a bunch of miscellaneous fixes to make sure that the GUI works properly with the latest versions of Python and Matplotlib. This also supersedes https://github.com/radio-astro-tools/pvextractor/pull/74 by making it so we use the default Matplotlib colormap (now viridis). There is still more cleanup that could be done, but just trying to get things working properly again.

Coverage decreased (-0.2%) to 54.905% when pulling f9c285da30b2b38900e7584de95f7e7ffc9a2406 on astrofrog:misc-fixes into a118486010a46dcbbdcbe01634a656a8d55618ed on radio-astro-tools:master.


if  we have more user features or item features,how to do for input file

information  as follows:
userid  user_features  itemid item_feature rating

Hi,
Okay so no answers provided here and I'm having the same question, that how can I add more features of either items or users, to improve the recommendations?

If you look at the CIFAR-10 sample, it shows how to build your own training and inference pipeline.
If that's too complicated, Amazon to the best of my knowledge has deprecated this framework and will not be throwing additional resources at supporting it, so I would focus on making use of TF or PyTorch instead, pressing them for better sparse data performance because TF has made zero progress in that direction since 2016 and PyTorch could use some sparse TLC as well.