LolloDev5123 Contribution Pack

Hey everyone! This will be a very big pull request, that's why I call it a Contribution Pack, feel free to look at the commits, they should all have a proper title and description, this is now ready to be merged! I may add stuff sometime, but please merge this ASAP! Please look at the commits and check if there's nothing that could break stuff, thanks!
Adonis Bulletin Board:

[x] Optimize some messages displayed to the player or logged
[x] Testfilter command
[x] AdonisEncrypt functionality
[x] Add Reason to Time/Temp Ban
[x] Anti Exploit Notifications
[x] Synapse Chunk Error Detection and AE lookFor Table Updates
[x]  Automatically update list when Search Text changes
[x]  :restart (Soft Shutdown)
[x]  Make :puke command have more vomit
[x]  Remove very short Admin aliases

Current issues with Adonis Ban Commands
The problem
Unfortunately, it is very confusing to ban players using adonis. Right now, :ban bans players from the server only, letting them join other servers, :gameban solves this, but it makes it confusing, to fix this, :gameban should be flipped leaving the original :ban as :serverban or :softban and :gameban as the default :ban.
:databan is also confusing, but it's commented out.
Another issue with Adonis is the Admin Levels, since Adonis is level based, not permission based, running :admin on someone,
and then :unmod, the user is instantly demoted to Players, since :unmod, :unheadadmin, and :unadmin are all aliases.
Here's some simple steps to make the over-all essential moderation commands lighter, easier to use, and less confusing:
ADONIS ADMIN CMDS REWRITE:

Setrank sets rank / level, takes both Owner/HeadAdmin/etc. as input but also the Rank Level (900/etc.)
Unrank removes any rank the player has and resets it to Player

For every rank that there is, there should be a :rank (eg. :admin :headadmin :owner :moderator) command that uses setRank with the rank level
Example of this in action:

[[

:setrank Lxi099 Admin -- Lxi099 becomes Admin
:setrank Lxi099 300 -- Lxi099 is promoted to Head Admins
:moderator Lxi099 -- Lxi099 is demoted to moderator
:unrank/unmod/unadmin/unheadadmin/etc. Lxi099 -- Lxi099 is demoted/ranked to Players/0

:ban Lxi099 [reason] -- Lxi099 has been banned and cannot rejoin the game(any server) until he is unbanned.
:unban Lxi099 [reason] -- Lxi099 can now continue to play the game
:tempban Lxi099 <time> [reason] -- Lxi099 has been banned for TOT. time, Lxi099 will be unbanned when the time passes or when :unban is used.

:serverban, tempserverban -- Same as all previous ban commands but takes action only for the current server that the command is ran on. This could be considered a Soft Ban; :unban is **still used** to unban the player, there **shouldn't** be a :unserverban command.
]]

Suggestions that were locked away in my Notepad++

Redesigned Search for Lists like Simple Admin does it (Title button that when clicked opens search textbox)
Sort Title Button for Lists (A-Z, Z-A, Time, etc.)
PrivateChat: Send Image AssetIDs, Send Audio AssetIDs, send your location (displays message with view and teleport buttons), Redesign (Check out my concept for Unity)
"^Chunk %w+, at Line %d+" is the string pattern that can be used to detect when a synapse script errors and internal ui is disabled
:inspect: Actively show with InputService if the User is using another window that's not roblox
:inspect: Add non-messy option to refresh data that could have changed (Focused, Bio, Groups, etc.)
:integrity Command

Displays GUI with tips about improving Adonis Security
Has an  image with a shield badge depending on security points
Flags:
Not Default Datastore Name: +1 Security Points
Different MainModule ID: -1 Security Points
Different Loader ID: -1 Security Points
Different Urgent Messages ID: -1 Security Points
Default Datastore Key: -1 Security Points
Client Allowed_API_Calls true: -1 Security Points
Settings Allowed_API_Calls true: -1 Security Points
Datastore Allowed_API_Calls true: -1 Security Points
Core Allowed_API_Calls true: -2 Security Points
Detected module.PremiumID: -5 Security Points

Reintroduce short aliases for perm admin, etc. detect if player is using a short alias, and bring up a confirmation prompt (eg. You are using the short alias for :permadmin, are you sure you want to perm-admin Lxi099?)
Make a new window element, the Codeblock, will have a Lua Lexer and could be used in GUIs that use a textbox for putting in scripts (idek scriptbuilder redesign? built-in adonis lua sandbox?)
Adonis Packages: Groups of Plugins that could even contain themes, etc.
In the Wiki every screenshot should have a different theme ;)
Adonis Custom-Made Themeable DEX-Like + FEX-Like Explorer+BTools
Make Server-PlayerFinder_Restrictor.lua built-in into Adonis (totally not to compete with HD Admin)

Would probably be better to use this pre-existing shutdown script and convert it to Adonis.
https://devforum.roblox.com/t/soft-shutdown-script/47588

Would probably be better to use this pre-existing shutdown script and convert it to Adonis.
https://devforum.roblox.com/t/soft-shutdown-script/47588

Alright thanks. WIll look into it

* [ ]   Group Bans (Ban a whole group)

... group bans are already a thing tho?

... group bans are already a thing tho?

I think what he means is the ability to group ban from a command

... group bans are already a thing tho?

I think what he means is the ability to group ban from a command

Yes

Did some changes that were stuck on my local machine, please review

Tested, :restart command, works beautifully! Someone should test the AE Notifications, im not sure they will work

This pull request is mergeable! Please check out the AntiExploit Notifications, and feel free to change the settings name and add a description, im too lazy to add it to the userpanel game section but please do! Unity v2 Theme will come in a future pull request

I think gameban should be renamed to pban/permenantban and the bormal one ban/serverban
gameban is a weird name and should be removed totally

I think gameban should be renamed to pban/permenantban and the normal one ban/serverban
that would be the least confusing name
gameban is a weird name and should be removed totally
also i notived that you have "tban"for trelloban and tempban ehich may cause some issues

Yes, current ban sys is SO messy, i think i would do that in a different pr for now,
we'll need an urgent announcement and change:

Old :ban to :serverban/softban (also introduce :tempserverban)
Old :gameban to ban (also introduce :tempban)
:timeban becomes tempban :timeban is still an alias
:unban will remove any type of ban (trello, game, soft, temp)

That's the basic we need, if we want to make it less confusing, it does not fit current roblox admin standards, but at least competes with the widely used minecraft essentialsx plugin, which is essentially adonis for minecraft

Just updated my PR Description with tons of suggestions I had that I don't plan to include nor make, feel free to use these as ideas for stuff in your PRs

gameban
i think permban is a better name

I think a ban would already be permenent, I guess keep it how it is, but for sure you are going to need the :tempban and :tempgameban aliases

Hoh boy. Conflicts are why you should never pack everything into one massive pull. Always better to do a pull per major change/addition/subtraction.

Lemme solve it :)

I made a pull request and uhh I hope that this one doesn't conflict with mine. I checked and I didn't find the parts of code that im editing to be affected but idk

Fixed merge now please don't merge other stuff after this im sleep deprived

So I've just noticed that I accidentally removed ObjRLocked cause I saw that it wasn't used in Anti, but i didn't search in the script, lemme revert a commit ;)

More conflicts :)
Also I really don't want to read through all of this in one sitting qq

I think gameban should be renamed to pban/permenantban and the normal one ban/serverban
that would be the least confusing name
gameban is a weird name and should be removed totally
also i notived that you have "tban"for trelloban and tempban ehich may cause some issues

Yes, current ban sys is SO messy, i think i would do that in a different pr for now,
we'll need an urgent announcement and change:

Old :ban to :serverban/softban (also introduce :tempserverban)
Old :gameban to ban (also introduce :tempban)
:timeban becomes tempban :timeban is still an alias
:unban will remove any type of ban (trello, game, soft, temp)

That's the basic we need, if we want to make it less confusing, it does not fit current roblox admin standards, but at least competes with the widely used minecraft essentialsx plugin, which is essentially adonis for minecraft

Just a note: it would probably be a good idea to deliver an urgent announcement before updating :ban to have :gameban's functionality in case there are games where ban's permission requirement has been changed (maybe for junior mods).

gameban

i think permban is a better name
:permban is misleading... it'd be better to make it just :ban

:permban is misleading... it'd be better to make it just :ban

it is less misleading than gameban. Also most afmin commands ban is serverban

:permban is misleading... it'd be better to make it just :ban

it is less misleading than gameban. Also most afmin commands ban is serverban

gameban implies they get banned from the game, whereas permban implies bans made with this command are permanent, which isn't true

gameban implies they get banned from the game, whereas permban implies bans made with this command are permanent, which isn't true

i disagree. gameban IS permenant, unlike ban


Onsite tests

[x] #475 requires a special div to be added to the non-standard category in the non-standard country
[ ] A13 has the BottomLayer inside the GrayLayer.  Check the content is being found
[x] Test Windows-specific dita.bat command runs properly
[x] Double-check how hfefs must be provided to dita (in both DITA-OT and Oxygen transformations)
[x] Capture folder shortcuts in x-Net, they will change in 2 weeks time.
[x] Move top:0px to 1px in a20. Check the header gets picked up
[ ] Test if any anchors are generated in the top level (as discussed here). Check if that pattern occurs in file A3
[ ] File a20 has an unusual structure (no parent PageLayer). See if it is a common pattern.  It looks-like we can just give the div an id of PageLayer.

Done.


Don't lose order of tasks in coordinator console

The "recently completed" tasks were correctly sorted in a reverse chronological order on the java side, but while building the table in ui, the library would re-sort them by name.

Hmm, some upstream merge commits got in here, too. Should I get rid of them, or is this ok?

Does this make the table columns no longer sortable? If possible, I think ideally the table would start out in the order returned by the server, but then be re-sortable after that.
We just want 1 commit, but I think github would squash the commits on merge, so that might happen automatically. If you do it that's cool too.

@gianm Good point, sorting would be broken by this change indeed. Re-created a PR without this problem here: https://github.com/druid-io/druid/pull/3404


None UTF-8 character in Custom Properties [MPSat] preventing load

Version 3.0.9
OS: Windows 10 64bit
Whilst writing a Custom Property, STG Reachability Analysis, I entered a non UTF-8 character "¬" without realising. I updated the property, and then ran the property. I received an error message when running, similar to the standard error you receive when entering in correct syntax of the Reach language.
After this you're unable to open the Custom Property panel, receiving the following error message in the Problems output:
Exception in thread "AWT-EventQueue-0" java.lang.RuntimeException: com.sun.org.apache.xerces.internal.impl.io.MalformedByteSequenceException: Invalid byte 1 of 1-byte UTF-8 sequence.
	at org.workcraft.plugins.shared.presets.PresetManager.<init>(PresetManager.java:56)
	at org.workcraft.plugins.mpsat.MpsatPresetManager.<init>(MpsatPresetManager.java:13)
	at org.workcraft.plugins.mpsat.tools.MpsatCustomPropertyChecker.run(MpsatCustomPropertyChecker.java:40)
	at org.workcraft.util.Tools.run(Tools.java:22)

When you go into the xml file where the Custom Properties are store and remove the character this fixes the problem and you're able to open the Custom Property panel again.
It's also worth mentioning if you don't update the property and just run it with the character in the problem doesn't happen, only when properties are saved.

I could not reproduce it in Linux (Ubuntu 16.04) -- the error message is very detailed (incorrect character in a specific position). The Custom property editor can be opened and the the character can be removed with no issues.
Now I need to find a Windows computer to see why it is a problem there...

Let me know if I can provide any more details or help, I'd be more than happy to.

We had a similar issue last year. The reason was that when storing this property in an XML file, a non-XML character was inserted. Then, when trying to open that dialog again, the parser fails to parse the file.

Yes, I remember fixing that problem -- now I can save/load UTF8 and UTF16 characters to/from presets, at least in Linux.


feat: use OTLP gRPC exporter by default

docs: replace " "(NSBP) with space
feat: swap http proto exporter with grpc
feat: implement auth and fix tests for grpc exporter
docs: update migration guide

Description
Replace this with a description of the PR. Explain the problem it solves and the proposed solution.
List Github/JIRA issue(s) this PR fixes.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Internal change (a change which is not visible to the package consumers)
[ ] Documentation change or requires a documentation update

How Has This Been Tested?

[ ] Tested manually
[ ] Added automated tests

Checklist:

[ ] Unit tests have been added/updated
[ ] Documentation has been updated
[ ] Change file has been generated (npm run change:new)
[ ] Delete this branch (after the PR is merged)

@theletterf, could you please proofread the changed docs?

Codecov Report

Merging #319 (97aa90b) into main (3f09fb8) will increase coverage by 0.06%.
The diff coverage is 100.00%.

:exclamation: Current head 97aa90b differs from pull request most recent head 1716ea5. Consider uploading reports for the commit 1716ea5 to get more accurate results

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   94.91%   94.98%   +0.06%
==========================================
  Files          10       10
  Lines         295      299       +4
  Branches       76       77       +1
==========================================
+ Hits          280      284       +4
  Misses         15       15

Impacted Files
Coverage Δ

src/options.ts
98.93% <100.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f09fb8...1716ea5. Read the comment docs.

Nice! Thanks for all the copy suggestions, @theletterf!


Add a MongoDB-backed demo

With cursor-based pagination, see https://github.com/codegram/hyperclient/issues/106.

Closed via #8.

Closed via #8.


Hi , I am new to wezterm. Can u tell me how to apply your config to the Wezterm.

I uses Windows 11 + neovim. I installed weterm but don't know how to install your config. Also i want to know unlike in powershell when we press shift + enter or ctrl + enter, it doesn't work properly for me(don't go to new line). is this the same case with wezterm?

Hi buddy. You want to locate this file: $HOME/.config/wezterm/wezterm.lua in your machine. Replace it with my own and make sure you move over all other folders and files in my repo as well for it to work as intended. wezterm.lua will be the equivalent to index.html for a web project, so target it for any future changes you want to apply. From there, you can work into modularising it.
I'm currently on Windows and got befriended to MS Terminal, so I haven't been using Wezterm lately. I will make sure to install it to double check my indications though. Have a nice day and let me know if anything isn't working.


[nixos] agetty: Add autologinUser config option

This option causes the specified user to be automatically logged in at
the virtual console. Tested on x86_64 in virtualbox.
It might be useful to set autologinUser = "root" for the installation CDs as well.

:+1: also for the installation cd

:+1:

Added the installer change to this PR, please let me know if a separate PR would be preferrable. I left the comment about empty root password in in case something (su?) explicitly asks for it.

I've tested the installation cd, worked fine. Thanks.


3+ partials not possible?

Hello!
I've come across a weird problem. I'm not able to include more than 2 partials in a template.
{{ partial "header.html" . }}
<---- html --->

{{ partial "footer.html" . }}

works fine, but
{{ partial "header.html" . }}
{{ partial "topmeny.html" .}}
<---- html --->

{{ partial "footer.html" . }}

doesn't.
Haven't been able to figure this one out, and the only error that I get is:

ERROR: 2015/01/18 Error while rendering homepage: html/template: "index.html" is an incomplete template

Independent of what command I run.
Any ideas?

Hmmm, managed to get rid of the error by rewriting the whole file. Might have been a hidden character.
However, the error is really hard to read anything from, would be nice with something with a better output, or at least something pointing to the file where the problem is originating from. A stack-trace if possible would be great!

Usually these problems is due to the "." context changing.
Saving that context in a variable and pass it on makes it clearer.
And then there is the magic $. context.
See http://discuss.gohugo.io/t/templates-multiple-parameters/600/3 for related discussion.

@bjornerik thanks!


doc: fix header file location

fix incorrect header file location in CONTRIBUTING.md
include/uv-unix.h -> include/uv/unix.h
include/uv-win.h -> include/uv/win.h

Landed in e8644693, cheers!


Post Join Diagnostics User Account Name

In the post join diagnostics field, my device on the insiders build is showing Executing Account Name with my domain account and UPN as an additional field. Is there any information on this field and when it was added?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b4f913c-1b09-1679-a69e-2960ca6f9231
Version Independent ID: 21752bbd-e188-a826-0b95-1110834b55dd
Content: Troubleshoot using the dsregcmd command - Azure Active Directory
Content Source: articles/active-directory/devices/troubleshoot-device-dsregcmd.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@mapalko
Thanks for your feedback! We will investigate and update as appropriate.

@mapalko
Would you be able to provide a screenshot of what you're seeing, and confirm you're using the new Windows 10 Insider Preview Build.
-Is your device Azure AD Joined or Hybrid Azure AD Joined?
-Are you having any syncing issues?
Additional Link:
Review on-premises AD users UPN support for Hybrid Azure AD join
Please let me know if this helps with your issue. Otherwise, any additional information would be greatly appreciated.
Thank you for your time!

I am running an internal build and I am not having any functional issues. This is my output:

@mapalko
Thank you for the quick response. I'll reach out to my team and see if we have any info on this for you.
I'll update as soon as I hear back.
Thank you again!

@mapalko
Please see below for the response from our PG team. If you don't have any other questions regarding this, I'll go ahead and close out your issue at the end of the day.
PG: "Executing Account Name" shows who ran dsregcmd command to help in troubleshooting. This has been added in 2004 version.
Thank you for your time!


Show profile icon on bottom bar of web

On current version of web, when width of browser is narrow, bottom bar is shown as follows:
<Light, user profile not selected>

<Light, user profile selected>

<Dark, user profile not selected>

<Dark, user profile selected>

User profile icon is not shown on the bottom bar on the web version although shown on the iOS / Android version. Thus user cannot recognize current account by the profile icon.
I have implemented that user profile is shown on the web version same as iOS / Android version as follows:
<Light, user profile not selected>

<Light, user profile selected>

<Dark, user profile not selected>

<Dark, user profile selected>

Along with this fix, I have changed the border width when a user profile is selected from 1px to 2px. This is because border do not display correctly in lower resolution environments (for example, low-end smartphones and 96dpi PCs). This change has been applied both web (BottomBarWeb.tsx) and app (BottomBar.tsx) version of bottom bar.
[Note] Please review and confirm this modification based on these points:

I have confirmed this modification on Web (PC), Android (real device) and iOS (simulator). I cannot confirm on real iOS device because I do not own it.
I have confirmed by using my personal Bluesky account, but I cannot confirm by using labeler account.

I have recognized that fine tune is needed. After applying it, I will post new pull request.


Examples

Show examples of the rules via a screenshot, poweshell command, and json

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc46ceac-e45e-6f29-dd5b-6453c614d9b2
Version Independent ID: b8b3bb83-5204-1f8b-787f-eb3da444e22e
Content: Working with VMs and NSGs in Azure Bastion
Content Source: articles/bastion/bastion-nsg.md
Service: bastion
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

Thanks for your suggestion. I'll take it on as a doc bug for when we move out of the preview phase.

#please-close


Re-prioritize @windowForPaths and currentWindow

Description of the Change
Currently, @windowForPaths() being non-null inhibits addToLastWindow, thus rendering the -a switch at least partially useless on ArchLinux with XFCE/Gnome desktop. The patch restores its claimed ability to open documents in an Atom window the user was last working with.
The fix leaves existingWindow equal to @windowForPaths() only if there are no windows more suitable to become an existingWindow.
Alternate Designs
No alternate designs were considered, as the one in this PR is the least invasive. Here`s the only place in the whole Atom codebase where addToLastWindow value is actually used.
Why Should This Be In Core?
This is a bugfix.
Benefits
Restoration of documented functionality.
Possible Drawbacks
Calling currentWindow.hasProjectPath(), isFile?() and isDirectory?() for all opened entries even if @windowForPaths() is non-null.
Applicable Issues
https://stackoverflow.com/questions/43526384

Can someone please review this?

Hey @hidefromkgb. Apologies for not looking into this on time. I know this PR has been here for a very long time, during that time Atom has seen a number of changes. Due to the changes, this PR has now become outdated. Is it possible for you to resolve the conflicts?

Hey @hidefromkgb. Apologies for not looking into this on time. I know this PR has been here for a very long time, during that time Atom has seen a number of changes. Due to the changes, this PR has now become outdated. Is it possible for you to resolve the conflicts?

I abandoned Atom long ago in favour of less resource-hungry alternatives, so I guess it`ll be better to just close this PR.


Multiple sort key fields on index (GSI) breaks AppSync queries

How did you install the Amplify CLI?
yarn
If applicable, what version of Node.js are you using?
v16.15.1
Amplify CLI Version
10.0.0
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
no
Describe the bug
I added a global secondary index to one of my schema.graphql models. It contained two sortKeyFields sortKeyFields: ["name", "username"]. Noticed that the query wasn't working in AppSync when testing. No matter what inputs I used, it returned zero items. It didn't matter whether I provided the sort key fields or not.
I eliminated the second field in my GSI (sortKeyFields: ["name"]) and now it works as it's supposed to. Therefore the problem is related to there being multiple fields passed to "sortKeyFields".
This is happening with every index in my schema.graphql that uses multiple sort key fields.
Example below:
`
BREAKS:
eventId: ID! @index(name: "getEntry", sortKeyFields: ["movieId", "personId", "songId"], queryField: "getEntry")
WORKS:
eventId: ID! @index(name: "getEntry", sortKeyFields: ["movieId"], queryField: "getEntry")
`
Expected behavior
When using multiple sort key fields, it shouldn't break the query
Reproduction steps
Using any model in schema.graphql:
Create a GSI with one sortKeyFields
Create a GSI with two sortKeyFields
Test each in AppSync
Project Identifier
b8d65120b18181dc43f4d8a2ad24c4f7
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hi @justinjaeger, Could you please let us know whether backfill indexes resolved your issue?

Hi @justinjaeger 👋, We are closing this issue as we have not received any response from you. However, if you are still facing the same issue and require our assistance, please don't hesitate to leave a comment. This way, we can reopen the issue and provide you with better assistance.
Thank you!


Update README.md

update version specified in readme to latest supported with bug fix.

Thank you!


Ansible roles re-downloaded on each provision

Since 3.0.0, the Ansible roles are being re-downloaded each time vagrant provision is run.

It's a feature https://github.com/geerlingguy/drupal-vm/pull/611. My main reason for standing behind that commit was that we had suggested the ansible-galaxy install command ~29 times here in the issue queue. Also I believe that the common user does want to re-install the roles whenever they re-provision the VM.
There's a fairly easy workaround for power users though. Add a Vagrantfile.local with the following content:
# Disable the galaxy role re-installation during provisions.
config.vm.provisioners[0].config.galaxy_role_file = nil

@geerlingguy maybe this should be brought up for more debate though? Or we could add some way to toggle it of. I still feel it should be the default for the common case though.

OK, cool. I was just wondering if it was intentional or not.
I was assuming that it would download the roles once unless told to do so, sort of how vagrant reload --provision works, but I can see why it would be useful to automatically download them each time when provisioning to ensure that everyone has the latest specified versions.

If only there was an galaxy update option -- https://github.com/ansible/ansible/issues/6466

https://github.com/ansible/galaxy-issues/issues/49

Nice! I ended up using ansible to install roles so it could be idempotent --
https://github.com/beetboxvm/beetbox/blob/master/provisioning/ansible/playbook-roles.yml
However, it also clones the roles from github in debug mode to make it easier to push PR's which would also be a nice feature for galaxy...

Yeah, it's the lesser of two evils. An extra minute or two each provision by default, but a lot of extra issues not opened up in here. It's what the Vagrant Ansible (built in) provisioner does, and it's also what the windows.sh script does (in JJG-Ansible-Windows), so now it's consistent.
Power users (or people like me who provision all day long) can override, so it's not a huge issue.
It also helps boost my download counts :D https://galaxy.ansible.com/explore#/

It also helps boost my download counts :D

LOL


Introduce Jinja2 templates for code generation

This change significantly refactors the way how code generation
works. Previously, pysmi code generator has been responsible for
producing a well-formed text document (e.g. JSON or pysnmp).
With this change, all code generations should be done through
Jinja2 templates by rendering them in the context of the parsed MIB
taking shape of the intermediate MIB representation which other parts
of pysmi provide.
By way of moving pysnmp code generation to Jinja2 template, the
Python code layout of pysnmp modules improved dramatically - it
is just one little step from being PEP8-compliant.
This template-based pysnmp code generator drops some backward
compatibility aids that keep Python MIB modules compatible with
older pysnmp versions. Perhaps in the followup patch we should
make the Python MIB module failing early and clearly on import
when it's old pysnmp importing it.

Codecov Report

Merging #41 into master will increase coverage by 13.86%.
The diff coverage is 86.18%.

@@             Coverage Diff             @@
##           master      #41       +/-   ##
===========================================
+ Coverage   60.95%   74.81%   +13.86%
===========================================
  Files          30       31        +1
  Lines        2922     2351      -571
===========================================
- Hits         1781     1759       -22
+ Misses       1141      592      -549

Impacted Files
Coverage Δ

pysmi/codegen/pysnmp.py
100% <100%> (+19.15%)
:arrow_up:

pysmi/codegen/jsondoc.py
22.35% <50%> (+10.95%)
:arrow_up:

pysmi/codegen/intermediate.py
85.81% <85.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11a5a0...7d8ee49. Read the comment docs.


Add an ipython notebook example of generating libraries from fragments

This adds an example I worked up for SMIRFF testing which generates a large library of molecules from substructure SMILES strings using SMIRKS for reactions.
It follows a trick Christopher Bayly explained to me, using dummy atoms to cap SMILES strings for fragments, then using SMIRKS pattern matching to create artificial "reactions" which remove these dummy atoms and link the connected fragments together. This allows easy and straightforward generation of combinatorial libraries containing specific substructures.
I expect this approach will likely be useful for generating molecules for QM reference calculations in the future. Specifically, if we find that we need more QM reference data on molecules containing a specific substructure SMIRKS (perhaps we've got JUST enough data to suggest a specific substructure needs a new parameter, but not enough data to pin this down well) we can easily use this type of approach to generate a large library of compounds containing that substructure in various environments for additional QM reference calculations.
This particular example notebook at present focuses only on the space of AlkEthOH plus phenyl.

(Merging, since this only contains an IPython notebook and does not contain anything which is tested. And tests on this repo fail anyway while waiting for #20 ).


Only one request when changing between tabs

This PR solves the ticket: AGPUSH-2052
It is an alternative for #784.
Reason
After a lot of debugging, the problem seems to be the "ngLink" directive, that generates an url starting with . instead of #.
Solution
Although one solution would be changing all . for # in the declaration of the directive (ngLinkDirective function in app/scripts/angular.router.es5.js) I find more readable and clean to simply specify the reference.
I think the best way to deal with this behaviour would be to create a method setTab to the appDetail controller. By updating the tab property this way, the component would be shown and refreshed. However, the current implementation requires the URL to be the one to update in order to fetch the components data.

#784

I am not able to click on the Activity log tab

@edewit @lholmquist @odra can one of you guys take a look as well?
Besides actual testing, in terms of code-change, I am not really familiar w/ Angular at all

@matzew It's solved now. I mistyped the href and point both sender and activity tabs to sender.

I haven't tested yet,  just wanted to comment on the changes.  It does seem a little hacky since it goes a little against the way i think angular wants you to code,  but at the same time,  the router that is being used here is no longer supported.  Its also a file that has had updates made to it,  and not part of any dependency manager(like bower or npm),  so i think if these changes work, then they should be ok.  Unless someone wants to re-write the whole UI over again :)
that might be a better option if the decision is made to move this(the admin UI) to its own repo,  but thats a whole other issue

I noticed that with this change clicking on the current TAB has no effect anymore.
I am not really sure, but I guess it was designed to fetch data when clicking on the (current) tab.
I see the dobule requests are gone, when transitioning from A->B, but no request is triggered on clicking on the current TAB.
@edewit any comments?

@lholmquist I think the whole UI is a bit tricky, that's why a think it should be rewritten too.

Not sure why the build fails... hrm

Me neither, it's building locally.

Hrm,
the admin ui module take oddly long, in the maven build:
[INFO] UnifiedPush Admin UI ............................... SUCCESS [08:31 min]

rebuilding to double check

second build of the branch went well :-)

@josemigallas do you mind creating a new, different PR for 1.1.x-dev brnach, of this fix ?
thanks!

build fails due to travis time out, known issue


⚠ Bofrost.at has degraded performance

In 8b55750, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2188 ms

Resolved: Bofrost.at performance has improved in 9a9d921 after 313 days, 5 hours, 34 minutes.


lang

zh and zh-tw has the wrong placeholder key for most replayed posters.
missing key played duration for now but there might be more than one incorrect during translation process

fixed on https://github.com/Loco-CTO/Rystal-V6-Experiments/pull/8


Rename "Artifact Store" to "Evidence Store"

We currently use the term "artifact store" to refer to the component that stores serialized Results. However, perhaps "artifact" is an unnecessarily -imprecise term for the things that we intend to store. Should we change the name to something else that is more descriptive, like "Evidence Store"?

Will need input from @krmaffey and @JennyNiemann on this one.

I like evidence store better! Especially since it's more consistent with what we say in the paper in terms of collecting evidence against requirements. The only question I have then is maybe we should call results 'evidence' instead? Or maybe that's too much. We can discuss further

Closing this one. "Artifact Store" is the appropriate name because it stores more than just evidence now.


Crash after name change.

changed the name of my Minecraft instance to. Now it crashes on start up and i get this log.
Time: 2024-10-10 15:19:35
Description: Initializing game
java.io.FileNotFoundException: \curseforge\minecraft\Instances\hALLOWEEN_\essential\Essential (forge_1.20.1).jar (The system cannot find the path specified)
at java.io.FileInputStream.open0(Native Method) ~[?:?] {re:mixin}
at java.io.FileInputStream.open(FileInputStream.java:216) ~[?:?] {re:mixin}
at java.io.FileInputStream.(FileInputStream.java:157) ~[?:?] {re:mixin}
at java.io.FileInputStream.(FileInputStream.java:111) ~[?:?] {re:mixin}
at sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:86) ~[?:?] {}
at sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:189) ~[?:?] {}
at java.net.URL.openStream(URL.java:1161) ~[?:?] {re:mixin}
at gg.essential.util.HelpersKt.findCodeSource(helpers.kt:175) ~[Essential%20(forge_1.20.1).jar%231721!/:?] {re:mixin,re:classloading}
at gg.essential.util.HelpersKt.addEssentialResourcePack(helpers.kt:205) ~[Essential%20(forge_1.20.1).jar%231721!/:?] {re:mixin,re:classloading}
at net.minecraft.server.packs.repository.PackRepository.handler$cee000$addEssentialResourcePack(PackRepository.java:540) ~[client-1.20.1-20230612.114412-srg.jar%231002!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:mixins.essential.json:resources.MixinResourcePackList from mod

I am 99% certain that your issue is with the Essential mod, which is not the mod this issue tracker is for. Feel free to reopen this issue if you're sure the mod causing issues is the Essentials vanilla+/automation mod.


Add functions to remove sections.

Hi!
I needed to remove sections, so that run-time changes could be seen when printing the config. Is this interesting at all?
Maybe I should free(opt->values) at the end of cfg_opt_rmnsec() if opt->nvalues drops to zero?
Cheers,
Peter

Any comment on this pull request? It is possible to programmatically add sections at runtime by feeding a (possibly generated) string such as "foo answer {\n  value=42\n}" to cfg_parse_buf(), but I need the functions in the pull request to remove sections at runtime.
Cheers,
Peter

Haven't had a chance yet to go through all the pull requests.  But generally speaking this sounds like an interesting idea.  I'll give it a go in the v2.9 release cycle, and unless I see any regressions it'll probably be included.

Now with a test! (and adjusted to work around the no-deep-copy-of-searchpath problem).

Rebasing on top of master had conflicts due to whitespace changes in the makefiles. I resolved that, but also made changes so that these conflicts will be less frequent for here on.


TabView can get desynchronized with its tab controller's current index

Steps to Reproduce

Run this minimal repro on dartpad: https://dartpad.dev/?id=552bae9af960da7b2abd2bbcac0d9254&null_safety=true
Click Tab 2. Observe the app now displays the content of Tab 2 (✔).
Click Toggle Tab 2. Observe the app now displays the content of Tab 1 (✔).
Click Toggle Tab 2 again. Observe the app still displays the content of Tab 1 (✔).
Click Tab 2. Observe the app still displays the content of Tab 1 (❌).

Expected results:
After step 5, the app should display the content of tab 2.
Actual results:
The app still displays the content of tab 1.

Code sample
See https://dartpad.dev/?id=552bae9af960da7b2abd2bbcac0d9254&null_safety=true

Logs
No relevant application log

No issues found! (ran in 34.1s)

[√] Flutter (Channel stable, 2.5.3, on Microsoft Windows [Version 10.0.19042.1288], locale en-US)
    • Flutter version 2.5.3 at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (3 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\agersant\AppData\Local\Android\sdk
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2020.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code (version 1.62.0)
    • VS Code at C:\Users\agersant\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.28.0

[√] Connected device (3 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 31) (emulator)
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 95.0.4638.69
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 94.0.992.50

https://user-images.githubusercontent.com/817256/140720170-a341f089-2260-448a-8ca7-6a7462c47517.mp4

Hi @agersant , thank you for filing this issue.
I tested this on the latest master and stable channel and the issue is reproducible

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.5.3 at /Users/flo/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (3 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A5212g
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (5 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone (mobile)            • 2cb2f234cda6637b9ad960bd3eae4f38fb3a5896 • ios            • iOS 15.0.2 19A404
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.624, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.6.0-12.0.pre.624 at /Users/flo/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0b0b21ecb5 (22 hours ago), 2021-11-07 01:37:35 -0700
    • Engine revision 5140e30cec
    • Dart version 2.15.0 (build 2.15.0-268.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (5 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone (mobile)            • 2cb2f234cda6637b9ad960bd3eae4f38fb3a5896 • ios            • iOS 15.0.2 19A404
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

Thank you

Checked it on latest stable Flutter, the issue is reproducible. Thanks for reporting 👍🏻

Thank you @xu-baolin !


fix: remove a false condition that sets the dynamic mode

hasDynamicNSSelector should only be set to true when the mode is set to dynamic explicitly. It was probably a merging issue that mistakenly sets the flag to true for unknown mode.

Does this need to be cherry-picked for 1.17.1?

Does this need to be cherry-picked for 1.17.1?

It was already cherry-picked in #1076.


Removing old docs and adding new ones

This PR updates a ton of the backend docs, adds relevant fixtures, and updates the readme.
@lpasselin this should help you when your playing around with code. If you could, please take an look at the readme to make sure I don't have any typos. Thanks!

Thanks for taking a look at this!


JAMES-3680 Capability should be aware of request URL prefixes

Avoids a uggly if
Allows extension capability to access resolved prefixes.

    org.apache.james.jmap.core.JmapUrlEndpointResolverTest.JmapUrlEndpointResolverTest should succeed to configuration urlPrefix when provided
    org.apache.james.jmap.routes.SessionRoutesTest.get should return correct session

Will have a look...

Read it


Abnormal calorie count

When i pulling the calories data to tasker, it's giving in millions, am i missing something or it is actually wrong data.
"BasalMetabolicRateRecord_BASAL_CALORIES_TOTAL":1649193.3324504,
"TotalCaloriesBurnedRecord_ENERGY_TOTAL":1725825.5371496629

Can you compare the data for the exact same time range with the Health Connect Toolbox mentioned in the readme, and add the full output of both, formatted properly

This is the following data i get when i pull it from tasker, it is aggregate data of 1 day ago
I've also checked the data in health connect tool box

[{"startTime":"2024-09-04T18:30:00.061Z","endTime":"2024-09-05T18:30:00.061Z","ExerciseSessionRecord_EXERCISE_DURATION_TOTAL":14,"SleepSessionRecord_SLEEP_DURATION_TOTAL":356,"BasalMetabolicRateRecord_BASAL_CALORIES_TOTAL":1649193.3324504,"TotalCaloriesBurnedRecord_ENERGY_TOTAL":1721060.084339048,"DistanceRecord_DISTANCE_TOTAL":1030.4000244140625,"HeartRateRecord_BPM_AVG":102,"HeartRateRecord_BPM_MIN":51,"HeartRateRecord_BPM_MAX":114,"HeartRateRecord_MEASUREMENTS_COUNT":798,"StepsRecord_COUNT_TOTAL":6783},{"startTime":"2024-09-05T18:30:00.061Z","endTime":"2024-09-06T18:30:00.061Z","SleepSessionRecord_SLEEP_DURATION_TOTAL":572,"BasalMetabolicRateRecord_BASAL_CALORIES_TOTAL":1649193.3324504,"TotalCaloriesBurnedRecord_ENERGY_TOTAL":1649193.3324504,"HeartRateRecord_BPM_AVG":71,"HeartRateRecord_BPM_MIN":60,"HeartRateRecord_BPM_MAX":95,"HeartRateRecord_MEASUREMENTS_COUNT":72,"StepsRecord_COUNT_TOTAL":3350},{"startTime":"2024-09-06T18:30:00.061Z","endTime":"2024-09-07T12:05:10.064Z","BasalMetabolicRateRecord_BASAL_CALORIES_TOTAL":1208454.106771005,"TotalCaloriesBurnedRecord_ENERGY_TOTAL":1208454.106771005}]

You're using the wrong option on the health connect toolbox, you need to go to "Read Aggregate Data" for aggregate data, which is what the output from the Tasker plugin is.
Also the plugin outputs in Calories not KiloCalories that's why the number seems high, divide by 1000 to get KCal

Thank you for the clarification, but still I'm getting the data wrong,
I'm using samsung health app to get the health data, when i compare samsung health data with health connect toolbox data they doesn't match

That doesn't really have anything to do with this Tasker plugin though, that's just a discrepancy between Samsung Health and Health Connect. Not really anything I can do about that 🤷


Not sure I understand the need for two settings for workbench.editor.enablePreview

Testing #7854
Why is there a special setting workbench.editor.enablePreviewFromQuickOpen ?
AFAIK editors can be opened via ctrl+click to go to definition, via ctrl+click to follow a link, from the extension host, etc.
Do you plan to add a config key for each of those? If not, why the special workbench.editor.enablePreviewFromQuickOpen

@alexandrudima yes we have some people asking for globally enable or disable preview and some users that want to have an editor in non-preview mode when you use quick open. I do agree that eventually we would need settings for all those places.

So the usecase you mention is
workbench.editor.enablePreview = true, workbench.editor.enablePreviewFromQuickOpen = false ?
But what does it mean when I set workbench.editor.enablePreview = false, workbench.editor.enablePreviewFromQuickOpen = true

@alexandrudima yes you found the issue with that solution, what I really need is a way to provide settings that impact other settings below. If I had UI it would be something like VS solution to this:

With using JSON I am not sure how to express this.

:+1: I don't know either. Maybe @aeschli knows
workbench.editor.enablePreview could be of type false | { quickOpen: boolean; }
I wasn't fishing for the issue, I simply didn't realize these two settings are hierarchical when I saw the settings description.

Yeah, some UI would totally help here, just the keys is not enough.


UITS

University of Information Technology and Sciences (UITS)

@philipto  Is everything ok in my files. Is it going to add on the list?
Thanks

@anaethoss Yes, everything is OK. Pull request merged. Thank you!


Isolated mode

I have an application that is intended to run clustered, but e.g. for local development it might be convenient to be able to run a single, isolated instance without connecting etcd/consul.
What would be a convenient way to achieve that? Perhaps we could introduce a 'dummy' coordination backend and I could introduce an option to select that one in my application?

ConstructR already supports that: If you define seed nodes (akka.cluster.seed-nodes), then it won't create and use the ConstructRMachine. Should work out of the box. Please try and let me know if you have issues.

That works - perhaps a bit less 'direct' but a suitable solution.


Does extensionsGallery slow down startup?

build vs code locally via npm run gulp vscode-darwin
start/restart (not reload) it a few times and keep note of the "[renderer] window.loadUrl() => begin to require(workbench.main.js)". On my machine this is around ~390ms
copy the product.json file from Insiders to your build
release step 2, and note that the times for "[renderer] window.loadUrl() => begin to require(workbench.main.js)" got worst, on my machine ~450ms

"Wer misst, misst Mist" but I believe this is the extensionsGallery entry because (a) I imagine it being used on the main side (maybe too early) and (b) because removing that (and keeping everything) changes the times again.

@joaomoreno Do you have insights when/how extensionsGallery is being used or what from product.json is being used very early (before code loading, so most likely on the main side)

We do use it to check for updates... but AFAIK it all happens in the shared process. @sandy081 can provide more insight.

false. measured a few more times and no more difference between the times...

Just to update, we do use product.json for extension recommendations on the main side. I think we can delay collecting tips and recommendations until workbench is ready. IMO they are not mandatory to be read during workbench start up.
@ramya-rao-a FYI

false. measured a few more times and no more difference between the times...

@jrieken no more difference between keeping extensionGallery and removing it?


1173 host prefix

closes #1173
Runs all 4 vcs and grabs the vcs type from the repo (defaulting to github) instead of grabbing it from the config.
Couldn't run it locally as i don't have bitbucket set up. If anyone could try it it would be awesome

I think this PR can then be closed, as the issue it is referring to (#1173) has been closed.

Right. I've been running another instance for GitLab repositories for some time now and it works like a charm. I currently don't see any advantages we would gain if one process can work with multiple Git repository managers.


add gmm, klarmobil, spritpreise & tgtg

Description

Fixes #(issue)

Type of change

:x: Bug fix (non-breaking change which fixes an issue)
:x: Icon addition (non-breaking change that adds/modifies Lawnicons's icons)
:x: General change (non-breaking change that doesn't fit the above categories, such as copyediting)

Icons addition information

Icons added

App Name (package.name) - added from icon request form
App Name (package.name)
App Name (package.name)

Icons updated

App Name (package.name)
App Name (package.name)

Icons linked

App Name (linked package.name to @drawable/package)
App Name (linked package.name to @drawable/package)

What do I miss? It reports too_good_to_go_foreground is missing, but icon request says this is the line I have to add:
 <item component="ComponentInfo{com.app.tgtg/com.app.tgtg.activities.login.SplashActivity}" drawable="too_good_to_go"/>

@peterge1998
I think you should delete too_good_to_go_foreground.svg and add "o" to the svg file name, because you have a drawable in appfilter.xml that says the svg should be called too_good_to_go, but the svg file is called to_good_to_go.

@peterge1998
I think you should delete too_good_to_go_foreground.svg and add "o" to tgtg svg file name, because you have a drawable in appfilter.xml that says the svg should be called too_good_to_go, but the svg file is called to_good_to_go. A typo.

fcking typo :) thx!

too_good_to_go.svg and klarmobilde.svg need to have their strokes changed to whole numbers

Yep, you are correct. I always forget to set to whole numbers when I resize the paths at the end to 160x160.
I fixed klarmobil to 12 px.
But tgtg "needs" to stay at 7.5 for the right circle, otherwise the width does not look even compared to the left & middle circle:

The icon already has a bump. Either the icon will be changed to fit the guidelines or it can't be merged

The icon already has a bump. Either the icon will be changed to fit the guidelines or it can't be merged

KK, done, its all 8 px now.


Openshift operator 'exporters': unknown type: "loki"

I am using Openhift 4.12, and i have installed an operator Red Hat build of OpenTelemetry 0.93.0-3 provided by Red Hat. I created a resource of type OpenTelemetryCollector
apiVersion: opentelemetry.io/v1alpha1
kind: OpenTelemetryCollector
metadata:
  name: otel
  namespace: openshift-opentelemetry-operator
spec:
  observability:
    metrics: {}
  deploymentUpdateStrategy: {}
  config: |
    extensions:
      health_check:
      pprof:
        endpoint: <IP_ADDRESS>:1777
      zpages:
        endpoint: <IP_ADDRESS>:55679

    receivers:
      otlp:
        protocols:
          grpc:
            endpoint: <IP_ADDRESS>:4317
          http:
            endpoint: <IP_ADDRESS>:4318

      opencensus:
        endpoint: <IP_ADDRESS>:55678

      # Collect own metrics
      prometheus:
        config:
          scrape_configs:
            - job_name: 'otel-collector'
              scrape_interval: 10s
              static_configs:
                - targets: [ '<IP_ADDRESS>:8888' ]

      jaeger:
        protocols:
          grpc:
            endpoint: <IP_ADDRESS>:14250
          thrift_binary:
            endpoint: <IP_ADDRESS>:6832
          thrift_compact:
            endpoint: <IP_ADDRESS>:6831
          thrift_http:
            endpoint: <IP_ADDRESS>:14268

      zipkin:
        endpoint: <IP_ADDRESS>:9411

    processors:
      batch:

    exporters:
      debug:
        verbosity: detailed
      loki:
        endpoint: "http://<HOSTNAME>:3100/loki/api/v1/push"
        tls:
          insecure: true
        default_labels_enabled:
          exporter: true
          job: true

    service:

      pipelines:

        traces:
          receivers: [ otlp, opencensus, jaeger, zipkin ]
          processors: [ batch ]
          exporters: [ debug ]

        metrics:
          receivers: [ otlp, opencensus, prometheus ]
          processors: [ batch ]
          exporters: [ debug ]

        logs:
          receivers: [ otlp ]
          processors: [ batch ]
          exporters: [ loki ]

      extensions: [ health_check, pprof, zpages ]

But i got this error on the pod otel-collector
* error decoding 'exporters': unknown type: "loki" for id: "loki" (valid values: [prometheus kafka awscloudwatchlogs debug logging otlp otlphttp])

Hi @alexlionnel. loki exporter is not part of the Red Hat OTEL Collector distribution

I solved the issue by using a specific image tag
apiVersion: opentelemetry.io/v1alpha1
kind: OpenTelemetryCollector
metadata:
  name: otel
  namespace: openshift-opentelemetry-operator
spec:
  image: 'otel/opentelemetry-collector-contrib:0.93.0'
  ...

Hi @alexlionnel, in your solution you are referring to a different collector distribution.
We may add the lokiexporter in the future. In the meantime, observe the upcoming otlp ingestion support from loki as an alternative/preferred solution.


Possible to use in an editor window?

Hey there,
Is it possible to use this in an editor window? I was hoping to use it in a current small project that is using 2017.1.5, but I can't seem to get it. I looked around a bunch and saw that for this type of thing you typically have to use something similar to this:
		list = serializedObject.FindProperty("list2");
		EditorGUILayout.PropertyField(list, new GUIContent("My List Test"), true);

Unfortunately, though, I have been unable to get it working successfully, so I just wanted to see if it was even possible?
Thanks,
-MH

Yes. But it only supports SerializedProperties. So you would need to manually create a SerializedObject for your EditorWindow, which contains your array data and handle. Something like this (Untested):
`class MyEditorWindow : EditorWindow {
[SerializeField] private float[] myArray = new float[0];

private SerializedObject so;
private ReorderableList list;

void OnEnable() {

    so = new SerializedObject(this);

    list = new ReorderableList(so.FindProperty("myArray"));
}

void OnDestroy() {

    so.Dispose();
}

void OnGUI() {

    so.Update();

    list.DoLayoutList();

    so.ApplyModifiedProperties();
}

}`

Great, this worked. Thanks, I appreciate it.

Sorry, I had one more question about it. I tried to make the list paginated, but I am guessing that it needs to be done a different way in this case?
I attempted to simply do:
    [SerializeField, Reorderable(paginate = true, pageSize = 5, elementNameProperty = "myString")]
     private float[] myArray = new float[0];

but there didn't seem to be any sort of change to what was displayed in the window.


[HOLD for payment 2022-01-27] Chat moves up a bit when new message is received - Reported by @K4tsuki

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a room and scroll to earlier message (fastly)
Stay on specific message (to read it  or something)
Send new message to that room
Notice chat view is moving around when new message is received

Expected Result:
User should stay at the same position
Actual Result:
User moves up by a size of the new message, when it is received
Not repro on Web/Desktop
Workaround:
Unknown
Platform:

Where is this issue occurring?

iOS
Android

Version Number: 1.1.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/149064955-22fdc8a9-f8bc-4029-a558-6290a5243fac.MP4
Expensify/Expensify Issue URL:
Issue reported by: @K4tsuki
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641188993370400
View all open jobs on GitHub

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I am fine if this issue is duplicate of https://github.com/Expensify/App/issues/6491, because fixing that issue might be fixing this issue too.

I think this should weekly because it's not too critical. Here is another video showing the bug on IOS.
https://user-images.githubusercontent.com/26260477/149182902-b856c778-ea7f-4c9b-865d-15c275cf1889.mp4

On it!

Posted!
Internal: https://www.upwork.com/ab/applicants/1482023251637559296/job-details
External: https://www.upwork.com/jobs/~0195002504c8fcf973

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal for IOS only
Adding maintainVisibleContentPosition prop to FlatLIst solve this issue or IOS.
Code change
src/components/InvertedFlatList/BaseInvertedFlatList.js
  <FlatList
                // eslint-disable-next-line react/jsx-props-no-spreading
                {...this.props}
                ref={this.props.innerRef}
                inverted
                renderItem={this.renderItem}

                // Native platforms do not need to measure items and work fine without this.
                // Web requires that items be measured or else crazy things happen when scrolling.
                getItemLayout={this.props.shouldMeasureItems ? this.getItemLayout : undefined}

                // We keep this property very low so that chat switching remains fast
                maxToRenderPerBatch={1}
                windowSize={15}
                removeClippedSubviews={this.props.shouldRemoveClippedSubviews}
+                maintainVisibleContentPosition={{minIndexForVisible: 0}}
            />

https://user-images.githubusercontent.com/21364901/149600512-999970a6-0d9c-493d-b54c-24c92eabae2d.mov

for android, there is pull request on react native still not merged yet
so the previous solution will work also on android when it gets merged in the next versions.
https://github.com/facebook/react-native/pull/29466

Nice find! It might take months for RN to merge that PR (29466). And then we'll have to upgrade RN, or merge the changes into a fork. Until then we can keep this issue on hold.
Alternative proposals which also fix the root cause (ie not workarounds) are welcome!
cc: @mountiny what do you think?

Thank you for the review @rushatgabhane. I think it is better to fix this for iOS when we have a simple tool for it and then just keep an eye on the RN PR so we can update whenever that goes out for Android too. Do you agree or are there any reasons why it might be better to hold for the feature to be finished in Android too?

@mountiny my bad, this proposal needs work. It's causing this janky animation when sending a message.

I think it is better to fix this for iOS when we have a simple tool for it and then just keep an eye on the RN PR so we can update whenever that goes out for Android too

Yep, I agree. If we go this route, no need to hold.
cc: @ahmdshrif
https://user-images.githubusercontent.com/29673073/149643066-a220fb27-4cf0-4e4d-a06b-d6f0cdb43c1f.mov

@rushatgabhane  just adding  autoscrollToTopThreshold: 0  will solve this issue
maintainVisibleContentPosition={{minIndexForVisible: 0, autoscrollToTopThreshold: 0}}

https://user-images.githubusercontent.com/21364901/149667812-8a6e9aad-22b9-42c2-b836-04b1c219a77f.mov

🎀👀🎀 C+ Reviewed
@ahmdshrif's proposal looks good! We'll fix it for Android by upgrading RN in future. I'll keep an eye on it.
cc: @mountiny

📣 @ahmdshrif You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Great! Thank you for the review Rushat!
@ahmdshrif Can you please apply for the job on Upwork and create the PR? Thank you very much!

yes already applied
my account https://www.upwork.com/freelancers/~0143a705fba636cfd8

can you please hire me @dylanexpensify?

@ahmdshrif offer sent! 😄

We have discovered the solution has an edge where it still fails, since the issue description originally has not stated mobile Web as a platform where the issue persists, we should not hold that as a regression. I have created a follow-up issue to look into this problem which occurs only on safari mWeb iOS for some reason. @ahmdshrif has looked into it already in the Pr and could not find a straightforward solution.

thanks, @mountiny, I am happy to do my first merged Pr here.
do I need to wait for more steps or I can submit work now?

do I need to wait for more steps or I can submit work now?

If there isn't any regression in staging and production, your contract will be paid out. There's more info on it in contribution.md
I hope this answers your question!

ok, thanks @rushatgabhane

@ahmdshrif Likewise, it was very lovely to work with you and I hope this was not our last mutual PR 😊
I would recommend you to look around the Help Wanted labelled issues and see if there is anything you might be interested in. However, you should wait til your PR is deployed to production before writing proposals. I think that should not take long given it is in staging and the QA has passed (except the nasty edge case).

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.31-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/7271

If no regressions arise, payment will be issued on 2022-01-27. :confetti_ball:

@dylanexpensify Should I apply to upwork job too for reporting this issue?

Sending payment now, @K4tsuki I'll create a job for you to apply to for the reporting!!

@ahmdshrif payment sent and contract ended!
@K4tsuki please apply here for reporting issue! https://www.upwork.com/jobs/~01a90138a351b9386f

Hi
The solution for this issue has been deployed to production  in version 1.1.31-1 and is now subject to a 7-day regression period

@dylanexpensify I have applied to the upwork job.

Sent the offer @K4tsuki !

@dylanexpensify I have accepted the offer. Thank you.

Payment sent, contract ended, and job closed!


Move NFS back to the database server

As the title says. Check out #18 and #20 for more info, but basically, I think having the NFS share files on the external USB SSD would be better for reliability, longevity, and performance, than having it all on the Redis server (which is still not yet being used).

Closing this issue due to results of #20 - I'm not going to use NFS anymore.


Init Sam 2 base model

This PR is a first step towards integrating SAM 2 models into hugging face transformers. It constructs the HieraB+ base model inheriting from hugging face PreTrainedModel. Note that this PR only support loading the base model but doesn't implement the image/video predictors. Sample usage:
from transformers.models.sam2.modeling_sam2 import Sam2Model
model = Sam2Model.from_pretrained("hkhedr93/sam2_hiera_base_plus")

For review, mainly check the configuration_sam2.py file, as well as Sam2Model class in modeling_sam2.py, the rest of this file is copying all the needed modules/functions from our codebase
TODO:

Documentation
Add Image/Video predictors
Push Hiera-S/T/L models

Do you plan to implement these trough HF transformer interfaces or on the original repo?
https://github.com/facebookresearch/segment-anything-2/issues/115
https://github.com/facebookresearch/segment-anything-2/issues/114
https://github.com/facebookresearch/segment-anything-2/issues/12


question regarding supported hosts

how many hosts are supported to run this bot?

well it depends on your host

what about other methods like linux and mac os

personally i don't think i officially supported them but if you have enough knowledge of linux and mac os then you could figure out, because i haven't tested bot code on these platforms (as well as windows itself) but i am pretty sure they will work no doubt

np, closing this issue as solved

what about other methods like linux and mac os

yes, you can vscode on your macOS/Windows/Linux


Channel Overrides Don't Hold Value

Hi, we are attempting to autonomously control a quad-copter inside using the dronekit software but we are having some issues with channel overrides. Obviously being inside we cannot get gps lock so we wanted to set the forwards values and backwards e.c.t. to the drone over the channel override system but the sent values aren't held.
Is there a way to get the sent values to hold their value until we clear it and if not perhaps it would be valuable to have this?

On Tue, 5 Jul 2016, dpal887 wrote:

Hi, we are attempting to autonomously control a quad-copter inside using the
dronekit software but we are having some issues with channel overrides.
Obviously being inside we cannot get gps lock so we wanted to set the
forwards values and backwards e.c.t. to the drone over the channel override
system but the sent values aren't held.
Is there a way to get the sent values to hold their value until we clear it
and if not perhaps it would be valuable to have this?

Recent versions of ArduCopter require you to set the channel overrides
every  seconds.
You will either need to do that in your control loop, or create a thread
for a vehicle to periodically send any channel overrides (patches
welcome!).
Peter

I've tried sending these commands in a while loop with very little delay and varying levels of delay but it would appear to be reset almost instantaneously (perhaps it can't be done fast enough using python).
Regardless this results in the quad-copter "bouncing" and eventually crashing.
Cheers
Daniel

On Tue, 5 Jul 2016, dpal887 wrote:

I've tried sending these commands in a while loop with very little delay and
varying levels of delay but it would appear to be reset almost
instantaneously (perhaps it can't be done fast enough using python).

Gah, sorry, brain outage.  The timeout I was thinking of was for
guided-velocity.  That timeout is 3 seconds.

Regardless this results in the quad-copter "bouncing" and eventually
crashing.

Using channel overrides to control flight, while possible, is not
recommended.  That being said, this example works for me:
https://github.com/peterbarker/dronekit-python/blob/source-system-filtering-tmp/examples/rc_override_flight/rc_override_flight.py

Thanks.
So just in the last few minutes I've worked it out a little.
First we disconnected any joysticks from the quadcopter.
We then had to use this command in a while loop with a 100ms delay between sending commands:
vehicle.channels.overrides[3] = throttle

It would appear that there is very little interference when using it this way. I will have a look and see if I am able to create some sort of library that deals with non-gps movement.

I have been using Dronekit-Python to do RC_overrides for a while, I am now able to arm, take off, hover, and land in a GPS-denied environment. I am currently working with Pixhawk v2, and a Raspberry 3B, but I will probably move onto APM2.6 for some other reasons.
My questions are:
1.By lots of experiments, I found out that the minimum time interval between each overrides is 0.393s. Once set shorter, some values will be ignored. But my project concerns some real-time controls, so is it possible to cut down the time intervals?
2.And since setting RC_channel values is not equal to setting the attitudes (yaw/pitch/roll), a specific override, for example, with channel 2, will cause the UAV to go forward or backward(depending on your value) at a different speed. Can you provide an example concerning the control of movements via setting attitudes(yaw/pitch/roll)?
3.I understand that in a GPS-denied environment, I can not arm in guided mode. Hence, I can not take off using simple_take_off or do any velocity controls. But I am up to modify and compile the source of AC 3.2.1, can you give me some hints to start with. I want to take off using simple_take_off and hover at a desierd altitude. My quad has a sonar (MB1240 to be specific), so it should have the necessary feedback to do the trick.
Thank you.

Hi Andrew,

Have you considered using some kind of FIFO queue? Perhaps with a timeout.
I can't really provide that example yet. I will once I have finished writing some libraries. You could try running multiple threads (i.e. one for each channel) and then having a main program which sets these values based on user input commands. I aim to have something that writes say unguided_movement( direction, distance) or unguided_movement (direction, velocity) or something like that.
If you start in stabilize mode and have all the controls set to their respective (center) positions as they would be on your radio, then your quad-copter should hover relatively well. Of course you can read in the inputs from your altitude sensor (I think its an ADC of some kind) and then implement a PID controller that helps it maintain altitude. We are actually going to be using that in conjunction with image processing to give us a more accurate altitude stabilization.

@AndrewOak Perhaps this is a basic question, but what is your range of RC values? My range is 1000 - 2000, but it appears this only corresponds to one direction, i.e. counterclockwise yaw and not clockwise yaw. I'd like to reverse the RC input, but it cannot accept negative values due to the range and I am not seeing any method to reverse the channel. I'm using Dronekit. Any ideas? Thanks.

So the range of 1000-2000 comes from the RC world. Where the RC Receivers would output PWM values in that range. 1500 would be center stick, 1000 would be full Left and 2000 would be full right.
Best regards,
Jaime Machuca Mercado
CTO | Droidika | www.Droidika.com
Mail<EMAIL_ADDRESS>Tel. +52 (33) 3777 5327
Cel. +52 1 (33) 3945 3350
Este correo electrónico y cualquier archivo transmitido en él, son confidenciales y para uso exclusivo de los individuos y entidades a quienes está dirigido. Si usted no es el destinatario previsto o la persona encargada de recibirlo, y tiene por error este mensaje, queda prohibido y sin validez el uso, difusión, re-envío, reimpresión o copia. Toda oferta y/o aceptación de propuestas comerciales, celebración de contratos u otros actos tendientes a la adquisición de bienes o servicios, así como el establecimiento de cualquier clase de obligación legal para Droidika S.A. de C.V., deberá confirmarse por escrito firmado autógrafamente por funcionario competente, excepto que se cuente con un contrato vigente que autorice el uso de este medio para tales fines. Si usted recibió este correo por equivocación, favor de notificar inmediatamente por este medio a su remitente, y después borrarlo de su correo

On Apr 4, 2017, at 12:03 PM, Lexie Roberts<EMAIL_ADDRESS>wrote:
@AndrewOak https://github.com/AndrewOak Perhaps this is a basic question, but what is your range of RC values? My range is 1000 - 2000, but it appears this only corresponds to one direction, i.e. counterclockwise yaw and not clockwise yaw. I'd like to reverse the RC input, but it cannot accept negative values due to the range and I am not seeing any method to reverse the channel. I'm using Dronekit. Any ideas? Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/dronekit/dronekit-python/issues/643#issuecomment-291566099, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlllcXpS_KIWmp00LJpztsPB76fK7Ctks5rsnf_gaJpZM4JFq2f.

@jmachuca77 Thanks for your reply! In testing my Solo 3DR drone, however, it appeared that an RC value of 1000 was a minimum value. The motors were not spinning very quickly. As the RC input increased, the speed also increased. Any insight on this? Thanks.

Same thing, low throttle would be 1000, and the motors will spin at the THR_MIN parameter setting. 1500 would be 50% and 2000 would be 100%, Though this is not directly related to motor speed if you are in a flight mode other than one that controls the throttle directly (like loiter, alt_hold, etc…) In this case 1500 would mean hold current altitude, values lower would mean descend at a speed proportional to how big the difference is from 1500. And higher values mean ascend at a proportional speed to the difference from 1500.
Best regards,
Jaime Machuca Mercado
CTO | Droidika | www.Droidika.com
Mail<EMAIL_ADDRESS>Tel. +52 (33) 3777 5327
Cel. +52 1 (33) 3945 3350
Este correo electrónico y cualquier archivo transmitido en él, son confidenciales y para uso exclusivo de los individuos y entidades a quienes está dirigido. Si usted no es el destinatario previsto o la persona encargada de recibirlo, y tiene por error este mensaje, queda prohibido y sin validez el uso, difusión, re-envío, reimpresión o copia. Toda oferta y/o aceptación de propuestas comerciales, celebración de contratos u otros actos tendientes a la adquisición de bienes o servicios, así como el establecimiento de cualquier clase de obligación legal para Droidika S.A. de C.V., deberá confirmarse por escrito firmado autógrafamente por funcionario competente, excepto que se cuente con un contrato vigente que autorice el uso de este medio para tales fines. Si usted recibió este correo por equivocación, favor de notificar inmediatamente por este medio a su remitente, y después borrarlo de su correo

On Apr 4, 2017, at 12:12 PM, Lexie Roberts<EMAIL_ADDRESS>wrote:
@jmachuca77 https://github.com/jmachuca77 Thanks for your reply! In testing my Solo 3DR drone, however, it appeared that an RC value of 1000 was a minimum value. The motors were not spinning very quickly. As the RC input increased, the speed also increased. Any insight on this? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/dronekit/dronekit-python/issues/643#issuecomment-291568331, or mute the thread https://github.com/notifications/unsubscribe-auth/ABllleSXEs4PJVVyvfNQbY3ZL4zqNwfNks5rsnnhgaJpZM4JFq2f.

By the way using RC overrides is the worst way of controlling a copter. It is better to use guided mode and send position or velocity commands.
Best regards,
Jaime Machuca Mercado
CTO | Droidika | www.Droidika.com
Mail<EMAIL_ADDRESS>Tel. +52 (33) 3777 5327
Cel. +52 1 (33) 3945 3350
Este correo electrónico y cualquier archivo transmitido en él, son confidenciales y para uso exclusivo de los individuos y entidades a quienes está dirigido. Si usted no es el destinatario previsto o la persona encargada de recibirlo, y tiene por error este mensaje, queda prohibido y sin validez el uso, difusión, re-envío, reimpresión o copia. Toda oferta y/o aceptación de propuestas comerciales, celebración de contratos u otros actos tendientes a la adquisición de bienes o servicios, así como el establecimiento de cualquier clase de obligación legal para Droidika S.A. de C.V., deberá confirmarse por escrito firmado autógrafamente por funcionario competente, excepto que se cuente con un contrato vigente que autorice el uso de este medio para tales fines. Si usted recibió este correo por equivocación, favor de notificar inmediatamente por este medio a su remitente, y después borrarlo de su correo

On Apr 4, 2017, at 12:12 PM, Lexie Roberts<EMAIL_ADDRESS>wrote:
@jmachuca77 https://github.com/jmachuca77 Thanks for your reply! In testing my Solo 3DR drone, however, it appeared that an RC value of 1000 was a minimum value. The motors were not spinning very quickly. As the RC input increased, the speed also increased. Any insight on this? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/dronekit/dronekit-python/issues/643#issuecomment-291568331, or mute the thread https://github.com/notifications/unsubscribe-auth/ABllleSXEs4PJVVyvfNQbY3ZL4zqNwfNks5rsnnhgaJpZM4JFq2f.

Yes, I understand RC values are not the best way to accomplish this. But I am not able to use GPS and the ArduPilot software on Solo does not support the positioning command I need, SET_ATTITUDE_TARGET.
So, if I am understanding correctly, the meaning of the values differs between yaw and throttle? I am mostly concerned with pitch and yaw. The yaw is at maximum left speed at 1000, and maximum right speed at 2000, correct? Is it the same for pitch? Please correct me if I'm wrong, I need a good understanding of this so I can implement this in code. I haven't found much documentation on RC overrides.

The reason I am unsure about how the RC values are behaving is because during testing, I only saw the drone yaw counterclockwise, and never clockwise. Likewise, it only pitched in one direction. When it was given a command to yaw clockwise, the drone appeared to instead yaw counterclockwise much too quickly. So it seemed that the yaw values corresponded to the maximum and minimum of counterclockwise yaw only. It's possible something else went wrong in the code, though.

@lroberts99  The answer above by jmachuca77 is really explicit. Though I'd like to add that you can always change those default settings by digging into the Full Parameter List[1] of your flight control firmware once your drone is connected to your computer with Mission Planner.
However, If your drone behaves strangely, you should always calibrate all your sensors, controls, and ESC first (though actually all those calibration is done by tuning and updating the Full Parameter List).
If you are interested in how RC values are translated into ESC control signals based on various feedback on board, understanding the source code of the ardupilot firmware is your best option.
Good luck and be careful!
[1]http://ardupilot.org/copter/docs/parameters.html
P.S. Also, please check out this page for further information: http://ardupilot.org/copter/docs/common-advanced-configuration.html

Thanks for your help, @jmachuca77 and @AndrewOak. My parameters in APM planner do have 1000 as the RC#_min and 2000 or 1900 as RC#_max. I understand that 1000 is supposed to be the maximum in a certain direction, but the motors can't even spin at 1000 pwm and spin very slowly at 1100. So something must be reversed, I just don't know what it is. Is there some parameter I can change in APM planner or in dronekit to fix this? Honestly, I'm ok with the drone turning slowly because I don't want it flying so fast it can't track objects effectively. I do need it to turn in both directions at a reasonable speed, though. Thanks for your insight so far!

Also, I should add that my controller reflects the correct pwm values as well. Full left yaw is about 1000 pwm, and full right is about 2000. Yet, manually setting pwm = 1100 in code makes it turn slowly....

but the motors can't even spin at 1000 pwm and spin very slowly at 1100

This is correct for throttle. 1000 is the minimum value so the motors will spin very slowly here.

I understand that 1000 is supposed to be the maximum in a certain direction

This is true for other commands (roll, pitch, yaw). But if you have the throttle set to 1000, and you give one of the other commands like yaw 1100, it will still spin the motors too slowly. Can you post a log of the flight you are doing? Or how are you testing?
Best regards,
Jaime Machuca Mercado
CTO | Droidika | www.Droidika.com
Mail<EMAIL_ADDRESS>Tel. +52 (33) 3777 5327
Cel. +52 1 (33) 3945 3350
Este correo electrónico y cualquier archivo transmitido en él, son confidenciales y para uso exclusivo de los individuos y entidades a quienes está dirigido. Si usted no es el destinatario previsto o la persona encargada de recibirlo, y tiene por error este mensaje, queda prohibido y sin validez el uso, difusión, re-envío, reimpresión o copia. Toda oferta y/o aceptación de propuestas comerciales, celebración de contratos u otros actos tendientes a la adquisición de bienes o servicios, así como el establecimiento de cualquier clase de obligación legal para Droidika S.A. de C.V., deberá confirmarse por escrito firmado autógrafamente por funcionario competente, excepto que se cuente con un contrato vigente que autorice el uso de este medio para tales fines. Si usted recibió este correo por equivocación, favor de notificar inmediatamente por este medio a su remitente, y después borrarlo de su correo

On Apr 11, 2017, at 10:08 AM, Lexie Roberts<EMAIL_ADDRESS>wrote:
Thanks for your help, @jmachuca77 https://github.com/jmachuca77 and @AndrewOak https://github.com/AndrewOak. My parameters in APM planner do have 1000 as the RC#_min and 2000 or 1900 as RC#_max. I understand that 1000 is supposed to be the maximum in a certain direction, but the motors can't even spin at 1000 pwm and spin very slowly at 1100. So something must be reversed, I just don't know what it is. Is there some parameter I can change in APM planner or in dronekit to fix this? Honestly, I'm ok with the drone turning slowly because I don't want it flying so fast it can't track objects effectively. I do need it to turn in both directions at a reasonable speed, though. Thanks for your insight so far!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/dronekit/dronekit-python/issues/643#issuecomment-293294078, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlllYB5jMH0BFPE-ZBT4p1MsWjoirTCks5ru5dsgaJpZM4JFq2f.

Ok, that makes sense. I'll need to test more to see how the yaw responds with throttle input. So if I want to keep the current altitude, I'll just give the throttle 1500 pwm, correct? I'll email you the log file, as github won't accept that type of file for upload.

This seems like its resolved, and was more of a support issue.


Enable hidden visibility by default with clang

Tested only with the local runtime and clang 12.
Pushing to see what the other clang builders think about this change.
@hkaiser any memory of why this was disabled in the first place?

I suppose all the clang setups failing is part of the reason this was off... We'll have to come back to this at a later point. If someone feels like picking this up to investigate what the problem is feel free to do so.


Change GSON options to serialize long as a string

When serializing long, by default GSON will store it in scientific notation which makes it a little tricky to deserialize.

It looks like this is an issue with how GSON handles numbers -- it makes no distinction between integer and floating-point numbers and provides no ability to 'peek' at future values.
Currently, your best bet is probably to use the jackson-based implementation of configurate (configurate-json) -- it still gets this wrong in the current release, but I've been able to fix it to work properly in the future, starting with commit a682bbe.
If you really need gson for some reason you'll have to bring this issue up with a) the gson devs and b) mojang, since we're stuck to the version of gson that minecraft uses.


Error TS1086: An accessor cannot be declared in an ambient context.

After installing the recent version, that fixes PNG problems, I have encounter these errors:
ERROR in node_modules/pdf-lib/cjs/core/streams/Stream.d.ts:20:9 - error TS1086: An accessor cannot be declared in an ambient context.
get isEmpty(): number;
node_modules/pdf-lib/cjs/core/streams/Stream.d.ts:20:9 - error TS1086: An accessor cannot be declared in an ambient context.
get isEmpty(): boolean;

I'm recieving the same error.  tried to uninstall/reinstall typescript.  I am using webpack v 4.34 & typescript v 3.5.3

@demalmar @doug-gov
Version 1.4.0 is now published. It contains additional TypeScript declarations for older version of TypeScript that should resolve this issue. The full release notes are available here.
You can install this new version with npm:
npm install<EMAIL_ADDRESS>
It's also available on unpkg:

<EMAIL_ADDRESS><EMAIL_ADDRESS>
As well as jsDelivr:

<EMAIL_ADDRESS><EMAIL_ADDRESS>


Enhancement to support case-insensitive URL parameters

ApplicationBase.json and the app have case-sensitive URL parameters.  We’ve had user problems because people are used to generally ignoring case in the URL, so case-sensitive query parameters get mistyped.
Can we change map[key] in _urlToObject() to map[key.toLowerCase()] and the urlParams list in ApplicationBase.json to all lowercase?

👍

Actually, I don't think we want to do this because these values get mixed into the config. things like basemapUrl need to be the correct case to be easily mixed in.


Tomato routing update

Fixed lat/long mismatch in isBMLTServerOwned
Changed compare method in isBMLTServerOwned
Changed getHelplineRoutingBMLTServer to check for tomato conditions, return tomato and in all other cases use getAdminBMLTRootServer - did this to break down conditions when tracking down
Added check for tomato_helpline_routing in getBMLTRootServer - fixed issue of unable to use tomato for meeting search
simplified getHelplineRoutingBMLTServer since getAdminBMLTRootServer performs the same listed function - no real functional change
Changed check_auth to reference getAdminBMLTRootServer for the admin panel
Admin, meeting search, helpline routing all accurate - except now when going to a YAP volunteer setup, it fails to call any volunteers and sits on indefinite hold

At the moment, the remaining issue I am running into is the volunteer routing isn’t dialing out. It correctly determines owned server or tomato, it correctly determines whether it is a YAP volunteer setup or not, it gets all the way to announcing it is connecting you, then sits on hold music and dials no one.

At the moment, the remaining issue I am running into is the volunteer routing isn’t dialing out. It correctly determines owned server or tomato, it correctly determines whether it is a YAP volunteer setup or not, it gets all the way to announcing it is connecting you, then sits on hold music and dials no one.

Perhaps we should drop into Slack for this so I can understand exactly how your server is configured.

There is no issue with the IDs that is the expected local ID coming from your root server (not the Tomato ID).

Sounds good - let me know when everything is ready so I can test on NNY this evening


Fix #4172 donation validation display error

Resolves #4172
Description

donation items are now correctly displayed after invalid edit would bring inventory to below distributed amount
rspec request test for above

Alternatives considered

in the rspec, not sure how specific to be in the error message test, I added tests for both using Events and not using Events
in the rspec, not sure if it's better to use factorybot create(:distribution) instead of PUT

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

manual testing
bundle exec rake

Screenshots

Looks good to me! @cielf did you want to take a look?

Passes my manual testing


Pluralizing "people" broken

inflector.pluralize("people") # "peoples" and I've no idea how to add a rule to make this work. When I added it to uncountable, then pluralizing "person" stopped working 😓

@solnic I think it's working as it is.
"One person -> Two people" # "people" here is plural
"The english people" -> "All peoples of the world" # "people" here is singular
See this: http://www.pearsonlongman.com/ae/azar/grammar_ex/message_board/archive/articles/00048.htm
What do you think?

Not really, it's not correct to create peoples as plural form of people, I know that in some contexts it's correct to use peoples from english grammar POV, but it's way less common and we should not do it as default inflection, also this:
irb(main):001:0> ActiveSupport::Inflector.pluralize('people')
=> "people"
irb(main):002:0> Inflecto.pluralize('people')
=> "people"

Well, I'm not completely convinced.
If somebody provides an already plural word to a pluralize function he is providing a bad entry.
The library can protect from most of the cases but not all of them.
If you give 'dogs' to pluralize it'll return the same 'dogs'.
But at the corner case of the word 'people' it's reasonable to the library to think "if the user is giving the word 'people' to a pluralize function that's because 'people' at this context must be a singular word and must be pluralized".
But I think you should decide on this, you're much more experienced than me. You're probably seeing implications that I'm not aware of. 👍
By the way, you're right. You should put the rule on accountables.
But It's tricky.
If you put the rule on "uncountables" it'll break people -> person singularization.
If you put the rule on "irregular" happens the same.
So, the way it should work is putting the rule on plural.
inflector = Dry::Inflector.new { |inflect| inflect.plural(/people\z/i, "people") }
inflector.pluralize("people") # => "people"

This is one of the rare cases where the same word has a singular meaning and a plural one.
About ActiveSupport, they have publicly stated that they wouldn't fix any inflexions rules because this would break a lot of systems that already depend on the wrong ones.

The Rails core team has stated patches for the inflections library will not be accepted in order to avoid breaking legacy applications which may be relying on errant inflections. If you discover an incorrect inflection and require it for your application or wish to define rules for languages other than English, please correct or add them yourself (explained below).
Source: http://api.rubyonrails.org/classes/ActiveSupport/Inflector.html

@solnic I'm with @abinoam
Are we going to make all the pluralizations (and singularizations) idempotent? IMO giving a string which is already pluralized is a wrong input.

However, I backported that feature from inflecto v0.0.2. https://github.com/dry-rb/dry-inflector/pull/10
**Please read carefully the description of this PR ☝ **

So, I closed this, I used a custom inflection rule for rom like you suggested, because you know, I can now do it since we have an instance instead of a singleton :D


getCountryFlag does not return correct URL

Describe the bug
The function getCountryFlag does not return the correct URL for flag, except for USA and UEA 9 (the hardcoded exceptions).
The URL is now constructed as https://flagcdn.com/w40/bahrain.png, if should be https://flagcdn.com/w40/bh.png
To Reproduce
To reproduce simple create the documented card for the next race and the last race. The first race being in Bahrain displays a broken link, the last race in Abu Dhabi displays the correct flag.
Expected behavior
Correct URLs for every country
Screenshots
No flag for Bahrain

Correct flag for Abu Dhabi

Desktop (please complete the following information):

not browser specific.

Smartphone (please complete the following information):

not browser specific.

Additional context
The function appears the expect country codes, whereas the country field contains (partial) country names (Netherlands instead of NL, Bahrain instead of BH).

Thanks for the quick fix, but this fix seems to have broken the last result card (or maybe related to the coded exceptions)

You are right! Fix incoming :)

Version 2.2.3 resolved the issue. Thanks again!