Tagging another user in a request comment

As an FOI analyst
I want to tag another user in a request comment
so that they know to review information included in the request

Assumptions & Scope
What are the assumptions for this story?
Display only name, not ministry or idir info
What is IN scope?
Tagging users only, not team.
IAO can tag all users x-gov. MInistries can tag anyone within their ministry and any IAO user.
What is NOT in scope?
Notifications when a user is tagged
Acceptance Criteria
Scenario 1: Generating a list of users when tagging

GIVEN ... I am on the comments tab and have clicked in the conversation window
WHEN ... I type the "@" symbol
THEN ... a list will appear above where I'm typing with system users listed alphabetically from A to Z
AND only the first 5 users full names would appear (e.g. Andrews, Arielle)

Scenario 2: Generating a list of users when tagging

GIVEN ... I am on the comments tab and have clicked in the conversation window
AND  I have typed the "@" symbol
WHEN I type a letter (e.g. M)
THEN ... a list will appear above with all the users who have a FIRST NAME or LAST NAME beginning with that letter (e.g. M)
AND only the first 5 users full names would appear (e.g. Andrews, Arielle)

Scenario 3: Generating a list of users when tagging

GIVEN ... I am on the comments tab and have clicked in the conversation window
AND  I have typed the "@" symbol
WHEN I type more letters (e.g.ma...)
THEN ... a list will filter by user's who have that letter sequence in their FIRST NAME or LAST NAME
AND if more than one user has that letter sequence, only the first 5 users full names would appear (e.g. Prodan, Matt)

Scenario 4: Selecting a user when tagging

GIVEN ... I am on the Comments tab and trying to tag a user in a comment
AND a user's name is listed
WHEN .I click the user's name I am trying to tag
THEN ... the name will appear in blue coloured text within the conversation window and I can continue typing
AND the list will close

Scenario 5: Submitting a comment with a tagged user(s)

GIVEN ... I am on the Comments tab and have selected a user to tag
WHEN ... I click on the "Submit" icon
THEN ... the tagged name will remain highlighted in a different colour text within the comment history

...
Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Notifications

Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

cc: @lmullane I've indicated notifications as a dependency to this story (see AC #3)

Do we need to add to scenario 1 - the functionality of the list continuing to filter as you type out a name? (Ie: when I use the tagging feature in zenhub, as I type out a name it filters closer and closer to the user I want).... I assume the library we choose will have this kind of thing baked into it, but just thought I would flag it

@m-prodan, I think so. I've added two additional scenarios based on how Team's functions for your review. cc @JHarrietha-AOT
I expect the dev team will want the notification in Scenario 4 in a separate story.

@lmullane I would agree that notifications for when a user is tagged in a comment should be a different story,
@m-prodan Agreed, I think listing the first three usernames would be enough and there should be a story around the idea that this list is refreshed with each character a user adds

I've removed the notification clause in the last scenario and added the dynamic filtering as additional characters are typed in.

I included tagging users in #855 - events that trigger notifications, so no need to write up a new story. If the devs want them separated out we can do so.

@JHarrietha-AOT This meets all testing criteria. Since there was no prototype to reference with this one, are you happy with the way the text displays for AC#5?

@mpilchar It passes the AC I think it would be a tech debt/bug ticket for the design changes that I would make.


MMC: w_previous referenced before assignment

While running MMC with diagonal set to True, I get the following error.
mmc.py, line 277 in fit_diag_
UnboundLocalError: local variable 'w_previous' referenced before assignment.

Interesting. This is probably indicating that your objective value is NaN, because w_previous will only be undefined when obj < obj * 1.1:
https://github.com/all-umass/metric-learn/blob/84dbcbef3896e62b664dbbdf83fa673d4976ec40/metric_learn/mmc.py#L266
In any case, we should fix the code to raise a more informative error here.

In MMC code, if the projection of 1 and 2 failed,  or obj <= obj_previous due to projection of 1 and 2, the matrix A is moved in the direction of the gradient of similarity constraint whereas in another case it is moved in the direction of the gradient of dissimilarity constraint.
Isn't it moved always in the gradient of dissimilarity constraint?
Thanks for help

@shalan12 Thanks for reporting this error. I agree with @perimosocordiae that something is wrong with the objective. Could you provide a minimal example to reproduce the error ?
@kpriyadarshini you are referring to the full case right ? (the one with projections is the full case) When you say "in another case", do you mean another "if" case within the full case, or do you refer to the diagonal case ? Looking at the code I have the impression that for the full case, in any case we are moving in the normalized direction of the gradient of the dissimilarity constraint projected on the orthogonal subspace of the gradient of the similarity constraint. This is similar to the paper (http://ai.stanford.edu/~ang/papers/nips02-metric.pdf, at the top of page 4, figure 1, and note 5 at bottom of page) (although I'm not sure why this direction needs to be normalized: I did not find any mention of this in the paper).
If you were comparing the full case and the diagonal case, maybe note this: while the full case maximizes the dissimilarity constraint (under inequalities constraints including the similarity constraint), the diagonal case minimizes the similarity constraint minus the log of the dissimilarity constraints function. (see the paper)
These are two equivalent views of the same problem: trying to maximize distances between dissimilar samples and minimize distances between similar samples.
I hope this answers your question: tell me if I missed something here

obj >= obj * 1.1 can also hold when w is the zero vector (which is a valid solution / initialization). Using addition instead of multiplication to initialize obj_previous would fix this. Regarding NaN, one should probably raise a specific error.

obj >= obj * 1.1 can also hold when w is the zero vector (which is a valid solution / initialization).

@bellet I agree, and it can also happen when obj is negative, which can happen in practice if dissimilar points are very close to each other (because then _D_objective will be very negative since:
https://github.com/metric-learn/metric-learn/blob/84dbcbef3896e62b664dbbdf83fa673d4976ec40/metric_learn/mmc.py#L337-L338
And therefore this term could be negative:
https://github.com/metric-learn/metric-learn/blob/84dbcbef3896e62b664dbbdf83fa673d4976ec40/metric_learn/mmc.py#L265)
Here is a small example where this happens:
import numpy as np
from metric_learn import MMC

X = np.array([[0, 0.1], [0, 0.1001], [1, 1], [2, 2]])
a, b, c, d = np.array([2]), np.array([3]), np.array([0]), np.array([1])

mmc = MMC(diagonal=True)
mmc.fit(X, [a, b, c, d])

Returns:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/will/Code/metric-learn-bis/metric_learn/mmc.py", line 74, in fit
    return self._fit_diag(X, constraints)
  File "/home/will/Code/metric-learn-bis/metric_learn/mmc.py", line 276, in _fit_diag
    w[:] = w_previous
UnboundLocalError: local variable 'w_previous' referenced before assignment

Using addition instead of multiplication to initialize obj_previous would fix this

Agreed, I'll submit a PR to fix this using addition rather than multiplication

Regarding NaN, one should probably raise a specific error.

Agreed, I'll include a check of finiteness in the PR


InkSplash and InkRipple have many pieces of identical code

We should combine those duplicate code pieces into a single one. See https://github.com/flutter/flutter/pull/20751#discussion_r211378022

CC @HansMuller

Hello @liyuqian I am interested in working on this as my first PR. I shall look at the comment (20751) you reference above and raise a PR for it.
I hope I can get some feedback from you 🙂

Cool! I'm happy to review your PR and give feedback. I'm currently in China
and I'll return to MTV next week. So before the next week, I might be slow
to reply due to the time difference and traveling.
On Thu, Sep 20, 2018 at 5:55 PM Bruce Elbert Bigirwenkya <
<EMAIL_ADDRESS>wrote:

Hello @liyuqian https://github.com/liyuqian I am interested in working
on this as my first PR. I shall look at the comment (20751) you reference
above and raise a PR for it.
I hope I can get some feedback from you 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/21014#issuecomment-423119869,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV7DMOPPgOtE13mPwsMQNkpzXy64X5KAks5uc2YZgaJpZM4WMItU
.

HI @liyuqian, I would like to work on this..
So far I've made a mixin
abstract class InkSplashRippleMixin {
  // This class is intended to be used as a mixin, and should not be
  // extended directly.
  // Reduces duplicate code between InkSplash and InkRipple
  factory InkSplashRippleMixin._() => null;

  final BorderRadius _borderRadius;
  final ShapeBorder _customBorder;
  final RectCallback _clipCallback;
  Animation<double> _radius;

  void paintInkCircle(Canvas canvas, Matrix4 transform, Paint paint, Offset center){
    final Offset originOffset = MatrixUtils.getAsTranslation(transform);
    canvas.save();
    if (originOffset == null) {
      canvas.transform(transform.storage);
    } else {
      canvas.translate(originOffset.dx, originOffset.dy);
    }
    if (_clipCallback != null) {
      final Rect rect = _clipCallback();
      if (_customBorder != null) {
        canvas.clipPath(_customBorder.getOuterPath(rect, textDirection: _textDirection));
      } else if (_borderRadius != BorderRadius.zero) {
        canvas.clipRRect(RRect.fromRectAndCorners(
          rect,
          topLeft: _borderRadius.topLeft, topRight: _borderRadius.topRight,
          bottomLeft: _borderRadius.bottomLeft, bottomRight: _borderRadius.bottomRight,
        ));
      } else {
        canvas.clipRect(rect);
      }
    }
    canvas.drawCircle(center, _radius.value, paint);
    canvas.restore();
  }
}

This can be used directly in both ink_splash.dart and ink_ripple.dart
I would like to ask -

An appropriate name for this Mixin?
Where should I declare this mixin?
Should I also extract the following variables into the mixin?

  final Offset _position;
  final double _targetRadius;
  final TextDirection _textDirection;

Sorry for holding this up. Got overwhelmed with something else

Thank you @mannprerak2 ! Overall your mixin looks good. Unfortunately, I'm currently out-of-office. My colleague @goderbauer may be able to provide you faster and better feedback on naming and where to put this mixin.


There is no more GitHub Pull Requests: Manually Provide Authentication Response. Isn't it? What is alternatives?

There is no more GitHub Pull Requests: Manually Provide Authentication Response. Isn't it? What is alternatives?
Originally posted by @seriousran in https://github.com/microsoft/vscode-pull-request-github/issues/1067#issuecomment-723696585

After you start the sign in process, you can click on the "Signing into GitHub..." status bar item to enter a token:

After you start the sign in process, you can click on the "Signing into GitHub..." status bar item to enter a token:

That, however, does not work for me (no URL is open in my browser). We definitely should have an option to copy the URL (everywhere in VS Code, not just here).

After you start the sign in process, you can click on the "Signing into GitHub..." status bar item to enter a token:

That, however, does not work for me (no URL is open in my browser). We definitely should have an option to copy the URL (everywhere in VS Code, not just here).


Refresh cannot be performed by workflow non-owner after changing Git repo

Feature Request
Provide way for Workflow or Tool to update in Dockstore when public Git repo is changed by a person other than the Dockstore Workflow or Tool owner
Desired behaviour
Perhaps Dockstore could be notified of changes to the Git repository and refresh automatically?
Steps to reproduce the behaviour
Developer A creates a workflow in Dockstore that points to the workflow code in a public Git repository
Developer B makes a change to workflow code in the public Git repository that should be reflected in the workflow in Dockstore
Developer B cannot click on 'Refresh Workflow' because he does not own the workflow in Dockstore
Developer A must be notified to go to Dockstore and 'refresh' the workflow so that the changes to the workflow code in the public Git repository can be seen in Dockstore

I was discussing this with Walt, and we're going to research this some more tomorrow with Developer B, who may remember some more details of exactly what happened.

We looked at with Michael (Developer B), and what happened is that he had joined the org before the workflow repo had been created, so the workflow in question wasn't showing up in his My Workflows.
It wasn't obvious to them that they needed to click the refresh button for the org; we just did that and the workflow now shows up.

Might be a documentation or interface improvement then


DbgModelClientEx.h IDataModelManager4, IDeconstructableConcept  and IFilteredNamespacePropertyToken Don't Exist

The IDataModelManager4  and IDeconstructableConcept COM interfaces do not exist anywhere and the client library cannot compile.  I have to replace the manager with the only existing version (2) inside DbgModel.h and completely comment out the IDeconstructableConcept code in the client to get it to compile.  Would be great to get this fixed asap since it makes the client library unusable.
Thanks!

Any updates here?  Can't be a difficult fix and again, crucially, DbgModelClientEx.h is unusable  in its current state.

You can find the latest version of DbgModel.h in a nuget package here. I just checked and it does define both IDataModelManager4 and IDeconstrutableConcept.

Thanks!  Can close the issue.  Guess it is time to accept Nuget here on my end :)

Mm, how to use the DbgModel.h  from nuget package from here ?
I am using Visual Studio 2022 Preview. After install the nuget, my project is still using <DbgModel.h> from SDK.
I have tried my best to solve the problem by myself, but I do not know how to use the head from
packages\Microsoft.Debugging.Platform.DbgEng.20230731.1609.0\build\native\inc
Gentlemans, please help. I used many hours on this problem.  Thanks!

I am using Visual Studio 2022 Preview. After install the nuget, my project is still using <DbgModel.h> from SDK.

You will need to check your INCLUDE path. The path is searched in the order specified, so to ensure you pick up the version you want, you must ensure the nuget location appears before the SDK path.


[Hexagon][QNN] Improve performance wo QNN canonicalization

This commit improves performance of different models tuned with MetaScheduler for Hexagon target and without QNN canonicalization.
Benchmarking of several models on Snapdragon 8gen1 and tuned with MS:

Model
QNN canon enabled, ms
QNN canon disabled, ms
speedup

ResNet, int8
50
48
+4.2%

Inception, int8
103
106
-2.8%

SRGAN, int8
348
431
-19.3%

What was done:

Added 2 new passes: QnnLegalize and QnnCanonicalize. But this is just wrappers for Legalize("FTVMQnnLegalize") and Legalize("FTVMQnnCanonicalize").

Added ability to disable inline for specific blocks in MetaSchedule AutoInline rule. For example, it can be done through the T.block_attr({"meta_schedule.inline_rule": "disable"}).

Implemented compute, alter op and legalization functions for qnn.conv2d operation (for Hexagon target).

cc @junrushao @masahi


redo wallet/staked balance query

I believe these two queries are currently at the top of the most heavy queries (apart from commit). I wonder if this actually is faster or not. It does not do two joins but instead two queries.

I'm not 100% certain these are the queries reflected.

We may want to wait with merging this until we have all crons to prod level


Add support for FTDI probes

This probe driver does not work reliably yet, but already capable of accessing debug interface registers of GD32VF103 and FE310-G000 chips.

Speed setting also needs to be implemented

Now one can debug LoFive R1 boards through a FTDI-based adapter :tada:
On GD32V some probe-rs-cli debug commands work, but some fail. FE310-G000 chips are not supported by now (they implement debug spec 0.11). Communication with K210 fails for different reason, needs some investigation.

Seems like the crate libftdi1-sys broke the CI check

@Disasm I think I found a solution for the CI problem, it seems to work when the vendored feature is not used. Unfortunately this also means that libftdi1-dev is now a requirement on Linux and macOS as well.

Wow, thank you for fixing this CI problem!

@Disasm Do you want to continue working on this PR? I would be happy to merge it as it is now, then we can continue working on RISC-V support with addtional PRs. Feel free to merge when you think it's ready.
bors d+

I'd say it's ready in its current state. I'd like to work on JTAG support with CMSIS-DAP and for this I will have to rework the FTDI driver. But for now... good enough.

bors merge

Thanks for implementing this! :clap:


Azure-Estatement

The issue text was copied to the clipboard.  Please paste it into this window.

Dupe of https://github.com/microsoft/vscode-azurefunctions/issues/2116


Added info in the docs that we don't support Camel until CAMEL-11430 …

…gets fixed
fixes #386

Codecov Report

Merging #387 into 2.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             2.0.x    #387   +/-   ##
=======================================
  Coverage     59.6%   59.6%
  Complexity    1647    1647
=======================================
  Files          221     221
  Lines         6853    6853
  Branches       907     907
=======================================
  Hits          4085    4085
  Misses        2253    2253
  Partials       515     515

Impacted Files
Coverage Δ
Complexity Δ

...ntract/stubrunner/spring/StubRunnerProperties.java
56.25% <0%> (ø)
18% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee80fa...ff63e8e. Read the comment docs.


want something else

i am assuming fo a handler that can handle both message and slash commands in a single command file so we dont need to create separate files for both type of commands

You can simply do it yourself since creating separate files is more organized.


Bug: Try to use RustArc<dynamic> after it has been disposed

Describe the bug
I'm stuck on an error that seems to be an error in the serialization strategy for inner opaque objects.
In calling a function that serializes a Vec, it causes a Try to use RustArc after it has been disposed. In the code below, it occurs on the second call to getItemContents.
In the example below, the VecDeque can be replaced by any other type.
It doesn't make a difference if I have full_dep: true or not, or whether I label the offending function serialize to try to get the SSE codec. Haven't managed to find any workaround yet.
Steps to reproduce
Up-to-date flutter.
Confirmed  to occur on frb 32 or 33.
Error occurs in flutter web in up-to-date Chrome.
simple.rs: (Here, we take VecDeque as a placeholder for an arbitrary opaque object.)
pub use std::collections::VecDeque;

pub struct ItemContainer {
    pub items: Vec<Item>,
}

pub struct Item {
    pub contents: VecDeque<u8>,
}

#[flutter_rust_bridge::frb(sync)]
pub fn new_container() -> ItemContainer {
    ItemContainer {
        items: vec![
            Item {
                contents: VecDeque::from(vec![1, 2, 3]),
            },
        ],
    }
}

#[flutter_rust_bridge::frb(sync)]
pub fn get_item_contents(container: &ItemContainer) -> Vec<Vec<u8>> {
    container.items.iter().map(|item| item.contents.iter().copied().collect()).collect()
}

#[flutter_rust_bridge::frb(init)]
pub fn init_app() {
    // Default utilities - feel free to customize
    flutter_rust_bridge::setup_default_user_utils();
}

import 'package:flutter/material.dart';
import 'package:dispose_repro/src/rust/api/simple.dart';
import 'package:dispose_repro/src/rust/frb_generated.dart';

Future<void> main() async {
  await RustLib.init();
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    final container = newContainer();

    final contents = getItemContents(container: container);
    final contents2 = getItemContents(container: container);

    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(title: const Text('flutter_rust_bridge quickstart')),
        body: Center(
          child: Text(''),
        ),
      ),
    );
  }
}

Launching lib/main.dart on Chrome in debug mode...
This app is linked to the debug service: ws://<IP_ADDRESS>:62285/4aYkKf0lhmQ=/ws
Debug service listening on ws://<IP_ADDRESS>:62285/4aYkKf0lhmQ=/ws
Connecting to VM Service at ws://<IP_ADDRESS>:62285/4aYkKf0lhmQ=/ws
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following DroppableDisposedException was thrown building MyApp(dirty):
Try to use `RustArc<dynamic>` after it has been disposed

The relevant error-causing widget was:
  MyApp MyApp:file:///Users/aran/Projects/dispose_repro/lib/main.dart:136:16

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 297:3        throw_
packages/flutter_rust_bridge/src/droppable/_common.dart 24:16                      dangerousReadInternalPtr
packages/flutter_rust_bridge/src/rust_arc/_common.dart 13:42                       get [_ptr]
packages/flutter_rust_bridge/src/rust_arc/_common.dart 44:17                       intoRaw
packages/flutter_rust_bridge/src/misc/rust_opaque.dart 52:18                       cstEncode
packages/dispose_repro/src/rust/frb_generated.dart 346:15                          cst_encode_Auto_Owned_RustOpaque_flutter_rust_bridgefor_generatedRustAutoOpaqueInnerItem
dart-sdk/lib/internal/iterable.dart 425:31                                         elementAt
dart-sdk/lib/internal/iterable.dart 354:26                                         moveNext
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 1140:20  next
dart-sdk/lib/_internal/js_dev_runtime/patch/core_patch.dart 555:14                 of
dart-sdk/lib/internal/iterable.dart 224:7                                          toList
packages/dispose_repro/src/rust/frb_generated.web.dart 125:13                      cst_encode_list_Auto_Owned_RustOpaque_flutter_rust_bridgefor_generatedRustAutoOpaqueInnerItem
packages/dispose_repro/src/rust/frb_generated.web.dart 113:7                       cst_encode_item_container
packages/dispose_repro/src/rust/frb_generated.web.dart 106:12                      cst_encode_box_autoadd_item_container
packages/dispose_repro/src/rust/frb_generated.dart 97:20                           <fn>
packages/flutter_rust_bridge/src/main_components/handler.dart 25:24                executeSync
packages/dispose_repro/src/rust/frb_generated.dart 95:20                           getItemContents
packages/dispose_repro/src/rust/api/simple.dart 14:26                              getItemContents
packages/dispose_repro/main.dart 147:23                                            build
packages/flutter/src/widgets/framework.dart 5550:22                                build
packages/flutter/src/widgets/framework.dart 5480:15                                performRebuild
packages/flutter/src/widgets/framework.dart 5196:7                                 rebuild
packages/flutter/src/widgets/framework.dart 5462:5                                 [_firstBuild]
packages/flutter/src/widgets/framework.dart 5456:5                                 mount
packages/flutter/src/widgets/framework.dart 4335:15                                inflateWidget
packages/flutter/src/widgets/framework.dart 3846:18                                updateChild
packages/flutter/src/widgets/framework.dart 5505:16                                performRebuild
packages/flutter/src/widgets/framework.dart 5196:7                                 rebuild
packages/flutter/src/widgets/framework.dart 5462:5                                 [_firstBuild]
packages/flutter/src/widgets/framework.dart 5456:5                                 mount
packages/flutter/src/widgets/framework.dart 4335:15                                inflateWidget
packages/flutter/src/widgets/framework.dart 3846:18                                updateChild
packages/flutter/src/widgets/framework.dart 5505:16                                performRebuild
packages/flutter/src/widgets/framework.dart 5643:11                                performRebuild
packages/flutter/src/widgets/framework.dart 5196:7                                 rebuild
packages/flutter/src/widgets/framework.dart 5462:5                                 [_firstBuild]
packages/flutter/src/widgets/framework.dart 5634:11                                [_firstBuild]
packages/flutter/src/widgets/framework.dart 5456:5                                 mount
packages/flutter/src/widgets/framework.dart 4335:15                                inflateWidget
packages/flutter/src/widgets/framework.dart 3846:18                                updateChild
packages/flutter/src/widgets/framework.dart 5505:16                                performRebuild
packages/flutter/src/widgets/framework.dart 5196:7                                 rebuild
packages/flutter/src/widgets/framework.dart 5462:5                                 [_firstBuild]
packages/flutter/src/widgets/framework.dart 5456:5                                 mount
packages/flutter/src/widgets/framework.dart 4335:15                                inflateWidget
packages/flutter/src/widgets/framework.dart 3846:18                                updateChild
packages/flutter/src/widgets/framework.dart 5505:16                                performRebuild
packages/flutter/src/widgets/framework.dart 5196:7                                 rebuild
packages/flutter/src/widgets/framework.dart 5462:5                                 [_firstBuild]
packages/flutter/src/widgets/framework.dart 5456:5                                 mount
packages/flutter/src/widgets/framework.dart 4335:15                                inflateWidget
packages/flutter/src/widgets/framework.dart 3846:18                                updateChild
packages/flutter/src/widgets/view.dart 291:16                                      [_updateChild]
packages/flutter/src/widgets/view.dart 314:5                                       mount
packages/flutter/src/widgets/framework.dart 4335:15                                inflateWidget
packages/flutter/src/widgets/framework.dart 3846:18                                updateChild
packages/flutter/src/widgets/framework.dart 5505:16                                performRebuild
packages/flutter/src/widgets/framework.dart 5196:7                                 rebuild
packages/flutter/src/widgets/framework.dart 5462:5                                 [_firstBuild]
packages/flutter/src/widgets/framework.dart 5456:5                                 mount
packages/flutter/src/widgets/framework.dart 4335:15                                inflateWidget
packages/flutter/src/widgets/framework.dart 3846:18                                updateChild
packages/flutter/src/widgets/binding.dart 1354:16                                  [_rebuild]
packages/flutter/src/widgets/binding.dart 1323:5                                   mount
packages/flutter/src/widgets/binding.dart 1276:16                                  <fn>
packages/flutter/src/widgets/framework.dart 2844:11                                buildScope
packages/flutter/src/widgets/binding.dart 1275:12                                  attach
packages/flutter/src/widgets/binding.dart 1088:26                                  attachToBuildOwner
packages/flutter/src/widgets/binding.dart 1070:5                                   attachRootWidget
packages/flutter/src/widgets/binding.dart 1056:7                                   <fn>
dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 48:11            internalCallback

════════════════════════════════════════════════════════════════════════════════════════════════════

Logs
N/A

Expected behavior
No response
Generated binding code
No response
OS
No response
Version of flutter_rust_bridge_codegen
No response
Flutter info
No response
Version of clang++
No response
Additional context
No response

Hi, could you please firstly check whether ItemContainer is opaque or non-opaque? If it is opaque then it should be a bug; otherwise, if it is non-opaque, then the code is that a Vec<Item> is obtained - which is a vec of owned Item, thus it cannot be obtained twice.

Yes, ItemContainer is non-opaque, and the bug does not occur in this repro when it is opaque. I don't understand why that makes it not a bug though, can you explain a little more?
getItemContents receives the ItemContainer by reference, so it shouldn't be possible for owned data to escape. The error seems caused just by calling the function twice, thereby serializing the data twice, and doesn't seem to depend on what are the contents of the function. But if we look at the function, maybe I misunderstand, but looks likeget_item_contents doesn't leak the items themselves, it processes them and returns copied data.
In my real app, there's an ergonomics issue too. If this isn't a bug, adding one opaque leaf field then requires converting the entire object tree to opaque to keep correctness?

As a bit more context, I was hoping to keep as much data non opaque as possible.  To make them opaque, in the original data crate I need to add a boilerplate impl full of getters that clone, and then mirror that impl as an external in the FRB crate to expose the getters to the Dart code.

I don't understand why that makes it not a bug though, can you explain a little more?

When ItemContainer is non-opaque (i.e. like a "plain old java object (POJO)"), the whole object (with each of its field) is constructed each time it is called, no matter whether there is & or not, because there is no way to keep a single Rust object. Then you can see that, surely we cannot construct two ItemContainer objects.

I was hoping to keep as much data non opaque as possible.

Btw I am thinking about another feature: Even if something is opaque, if it has pub fields, we can automatically generate getters and setters for it. For example,
#[frb(opaque)]
pub struct S {
  pub a: i32,
  b: i32,
}

Then we get this in Dart
class S {
  int get a => ...auto call rust;
  set a (int value) => ...auto call rust;
}

What do you think?

I like the automatic getters and setters. It would be nice to have an annotation to turn them off if I want to write my own impl for them.
I think maybe there should be an error if combining & with non-opaque containing opaque because it is not safe and doesn't respect the semantics of &.

Oh one more point, not sure if it's relevant, but my Item.contents implements Clone. So you could safely clone the rust-side object when constructing new ItemContainer from the same Rust obj.

It would be nice to have an annotation to turn them off if I want to write my own impl for them.

I guess one way is to only generate for pub and ignore for non-pub, since the semantics for pub means "it should be publicly accessible (from external code like Dart)".

I think maybe there should be an error if combining & with non-opaque containing opaque because it is not safe and doesn't respect the semantics of &.
Oh one more point, not sure if it's relevant, but my Item.contents implements Clone. So you could safely clone the rust-side object when constructing new ItemContainer from the same Rust obj.

Yes, the semantics is somehow a problem. Some more discussions are in https://github.com/fzyzcjy/flutter_rust_bridge/issues/1906#issuecomment-2112119752

I ran into this issue once again, because many of my non_opaque structs had one opaque struct deeply nested inside. I do not really understand why this causes issues, but it seems like having structs which are made up of opaque structs essentially makes them kinda "poisoned", if they are not also opaque. Seems to me that having the ability to create explicitly non_opaque structs does not really make sense then if its so easy to misuse, and the idea with the automatically gen getters would solve the problem, right? Or would that not change a thing either?

I am considering some changes like: For non-opaque structs, support code such as
pub struct MyNonOpaqueStruct {
  a: String,
  b: RustAutoOpaque<MyAnotherOpaqueType>,
}

Then, you can use MyNonOpaqueStruct as non-opaque type and freely access its field, and no worries about the issue above, because RustAutoOpaque is essentially an Arc.

Now auto getters/setters of opaque types is supported: https://cjycode.com/flutter_rust_bridge/guides/types/arbitrary/rust-auto-opaque/properties
And, opaque types can also be inside non-opaque types: https://cjycode.com/flutter_rust_bridge/guides/types/arbitrary/rust-auto-opaque/opaque-in-translatable
Thus closing this. Feel free to reopen if needed!


[5.4] Always put Mailable on queue if ShouldQueue contract exists

Documentation says:

If you have mailable classes that you want to always be queued, you may implement the ShouldQueue contract on the class. Now, even if you call the send method when mailing, the mailable will still be queued.

With this change, even if I use the send() method, will be queued, because the ShouldQueue interface was implemented:
class OrderShipped extends Mailable implements ShouldQueue
{
    use Queueable, SerializesModels;

    // todo
}

Then:
Mail::send(new OrderShipped()); // Will be queued
Mail::queue(new OrderShipped()); // Will be queued

@taylorotwell Is this makes sense for you?

@tomcoonen Have you tested? How can I recreate this? Because I have tested on my app Mail::send(new OrderShipped()); and all worked fine.

@KennedyTedesco I have tested this, keeps queuing.
I simply added your commit to \Illuminate\Mail\Mailer locally to test:
    public function send($view, array $data = [], $callback = null)
    {
        if ($view instanceof MailableContract) {
            if ($view instanceof ShouldQueue) {
                return $view->queue($this->queue);
            }

            return $view->send($this);
        }

@KennedyTedesco No good. Like I said, it keeps queuing without sending.

@tomcoonen Now I see! I'll send a PR to fix this ASAP.


Add Rust support to gdb

 Issue by brson
Thursday Dec 04, 2014 at 20:10 GMT
For earlier discussion, see https://github.com/rust-lang/rust/issues/19531
This issue was labelled with: A-debuginfo in the Rust repository

Calling functions in gdb among other things requires direct debugger support. We'll have to start modifying gdb.

I started work on this: https://github.com/tromey/gdb/commits/rust

Seems this was done; https://www.reddit.com/r/rust/comments/4merw3/gdb_now_supports_debugging_programs_written_in/ so I am closing this.


Double Door Opening Conflict with Quark

Minecraft version
1.19.2
LibX version
1.19.2-4.2.8
UtilitiX version
1.19.2-0.7.7
Forge version
43.2.4
The latest.log file
https://gist.github.com/kcddagger/095c732abfac357f5081e27ba38b776e#file-latest-log
Issue description
I noticed that double doors would not open.  They would instead make a door rattle sound and act as if they are locked.  Single doors work as intended.  If an illager opened one of the doors and I was fast enough to click the other door, the door I clicked would stay open when the illager used door closed.
A person in a discord server pointed out that Quark does things with doors so I used that as a starting point.
I removed quark, and the double doors started working again.
I then did a binary search for the mod(s) that would be in conflict with quark and found that UtilitiX was the only other mod to conflict in such a way that the double doors stopped working.
I have disabled UtilitiX until such time as this can be resolved.  However I would like to say that I really like some of the other things this mod brings into the game and would like to play with both enabled.
Steps to reproduce
No response
Other information
I am using quark-3.4-394

For now, you could disable this feature in the config, should be called "doubleDoor" in utilitix.json5.
For me, I like to link this issue:

https://github.com/MelanX/UtilitiX/issues/36

I wanted to link the issue where someone reported exactly the same with Quark and double door. Sadly, I think this was only reported on Discord. I hate it 🗡
Thanks for reporting!

Thank you.  being able to disable that resolved the conflict.
I'll pass this on to the friends that also play on my server so we can all be on the same page


Posting a message results in slackconnector.impl.SlackConnectorException: The slackconnector does not support multiple sessions

Any idea how to work around this issue? Or can it be solved in the connector?
If so, then that would be really appreciated.
The complete stack trace of the error we get when posting a message to Slack is:
com.mendix.core.CoreException: com.mendix.core.CoreRuntimeException: com.mendix.systemwideinterfaces.MendixRuntimeException: slackconnector.impl.SlackConnectorException: The slackconnector does not support multiple sessions at com.mendix.core.component.InternalCore.execute(InternalCore.java:422) Caused by: com.mendix.core.CoreRuntimeException: com.mendix.systemwideinterfaces.MendixRuntimeException: slackconnector.impl.SlackConnectorException: The slackconnector does not support multiple sessions at com.mendix.core.actionmanagement.ActionManager.executeSync(ActionManager.java:176) Caused by: com.mendix.systemwideinterfaces.MendixRuntimeException: slackconnector.impl.SlackConnectorException: The slackconnector does not support multiple sessions at com.mendix.util.classloading.Runner.doRunUsingClassLoaderOf(Runner.java:40) Caused by: slackconnector.impl.SlackConnectorException: The slackconnector does not support multiple sessions at slackconnector.impl.SlackConnector.<init>(SlackConnector.java:29) at slackconnector.actions.PostMessageToChannel.executeAction(PostMessageToChannel.java:37) at slackconnector.actions.PostMessageToChannel.executeAction(PostMessageToChannel.java:18) at com.mendix.systemwideinterfaces.core.UserAction.execute(UserAction.java:49) at com.mendix.core.actionmanagement.CoreAction.doCall(CoreAction.java:260) at com.mendix.core.actionmanagement.CoreAction.call(CoreAction.java:248) at com.mendix.core.actionmanagement.ActionManager$1.execute(ActionManager.java:168) at com.mendix.util.classloading.Runner.doRunUsingClassLoaderOf(Runner.java:36) at com.mendix.core.actionmanagement.ActionManager.executeSync(ActionManager.java:172) at com.mendix.core.component.InternalCore.execute(InternalCore.java:414) at com.mendix.modules.microflowengine.actions.actioncall.JavaAction.execute(JavaAction.scala:52) at com.mendix.modules.microflowengine.microflow.impl.MicroflowObject.execute(MicroflowObject.java:47) at com.mendix.modules.microflowengine.microflow.impl.MicroflowImpl.executeAfterBreakingIfNecessary(MicroflowImpl.java:192) at com.mendix.modules.microflowengine.microflow.impl.MicroflowImpl.executeAction(MicroflowImpl.java:149) at com.mendix.systemwideinterfaces.core.UserAction.execute(UserAction.java:49) at com.mendix.core.actionmanagement.CoreAction.doCall(CoreAction.java:260) at com.mendix.core.actionmanagement.CoreAction.call(CoreAction.java:248) at com.mendix.core.actionmanagement.ActionManager$1.execute(ActionManager.java:168) at com.mendix.util.classloading.Runner.doRunUsingClassLoaderOf(Runner.java:36) at com.mendix.core.actionmanagement.ActionManager.executeSync(ActionManager.java:172) at com.mendix.core.component.InternalCore.execute(InternalCore.java:414) at com.mendix.core.Core.execute(Core.java:165) at microflowscheduler.actions.ExecuteMicroflow.executeAction(ExecuteMicroflow.java:32) at microflowscheduler.actions.ExecuteMicroflow.executeAction(ExecuteMicroflow.java:17) at com.mendix.systemwideinterfaces.core.UserAction.execute(UserAction.java:49) at com.mendix.core.actionmanagement.CoreAction.doCall(CoreAction.java:260) at com.mendix.core.actionmanagement.CoreAction.call(CoreAction.java:248) at com.mendix.core.actionmanagement.ActionManager$1.execute(ActionManager.java:168) at com.mendix.util.classloading.Runner.doRunUsingClassLoaderOf(Runner.java:36) at com.mendix.core.actionmanagement.ActionManager.executeSync(ActionManager.java:172) at com.mendix.core.component.InternalCore.execute(InternalCore.java:414) at com.mendix.modules.microflowengine.actions.actioncall.JavaAction.execute(JavaAction.scala:52) at com.mendix.modules.microflowengine.microflow.impl.MicroflowObject.execute(MicroflowObject.java:47) at com.mendix.modules.microflowengine.microflow.impl.MicroflowImpl.executeAfterBreakingIfNecessary(MicroflowImpl.java:192) at com.mendix.modules.microflowengine.microflow.impl.MicroflowImpl.executeAction(MicroflowImpl.java:149) at com.mendix.systemwideinterfaces.core.UserAction.execute(UserAction.java:49) at com.mendix.core.actionmanagement.CoreAction.doCall(CoreAction.java:260) at com.mendix.core.actionmanagement.CoreAction.call(CoreAction.java:248) at com.mendix.core.actionmanagement.CustomActionMonitorImpl$$anonfun$run$1.apply(CustomMonitoredAction.scala:14) at com.mendix.core.session.Worker$$anonfun$receive$3$$anonfun$2$$anon$1.execute(ActionDispatching.scala:143) at com.mendix.util.classloading.Runner.doRunUsingClassLoaderOf(Runner.java:36) at com.mendix.core.session.Worker$$anonfun$receive$3$$anonfun$2.apply(ActionDispatching.scala:145) at scala.util.Try$.apply(Try.scala:192) at com.mendix.core.session.Worker$$anonfun$receive$3.applyOrElse(ActionDispatching.scala:139) at akka.actor.Actor$class.aroundReceive(Actor.scala:465) at com.mendix.core.session.Worker.aroundReceive(ActionDispatching.scala:135) at akka.actor.ActorCell.receiveMessage(ActorCell.scala:516) at akka.actor.ActorCell.invoke(ActorCell.scala:487) at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:238) at akka.dispatch.Mailbox.run(Mailbox.scala:220) at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:393) at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

Worked around the issue by created a bot user specifically for the Mendix node.


Destroying the infrastructure leaves the Azure API Management in an invalid state

Doing a destruction with terraform (terraform apply -destroy -auto-approve) does not fully deletes the Azure API Management (APIM), and the  following error is reported:
╷
│ Error: Failed to delete resource
│
│ deleting Resource: (ResourceId "/subscriptions/c23dfe1f-222e-4aa1-a8b6-6624b45373aa/resourceGroups/rg-aihub-0096a/providers/Microsoft.ApiManagement/service/apim-aihub-0096a" / Api Version
│ "2023-05-01-preview"): the response did not contain a body
╵

The issue Impossible destroy API Management StandardV2  was created in the terraform-provider-azapi repo to report this behaviour.
It seems that this problem only happens in the latest api-version 2023-05-01-preview, and that it seems to work as expected in version 2023-03-01-preview.
Thus, let's change the version of the API for the APIM an check the issue is solved.

It seems that the issue is actually an upstream API issue. The team behind the terraform-provider-azapi have created another issue to track it: https://github.com/Azure/azure-rest-api-specs/issues/29387


Make it really easy to install the examples locally

I've been updating the README https://github.com/holoviz/hvplot/pull/817 and thinking about what would be helpful for potential new users. I believe being able to install the example notebooks locally and spin them up in Jupyter easily would be very beneficial.
You can do it with git clone ... and then manually navigate. But that will clone everything and you would have to navigate a bit.
Instead I would propose some command in the terminal like
hvplot examples

and then a description of this process. For example under installation instructions.
This would be similar to how Panel works.

Yes actually there's bits of code in the repo that should allow to do that, except that the hvplot entry point isn't configured.


chore: add image on readme.md

#18 fix.
When uploading this code to the master, switch to use the github link inside the .github folder in the blob

@SuzeShardlow and @simonprickett i think now its fixed

Thanks, @LuizHAP!  If you are a member of our Discord (https://discord.com/invite/ueQwKUh5Z3), please drop your handle here and we will give you the Hacktoberfest 2021 role :) and if you'd like a shout out on Twitter, drop your handle!


COS configuration addtion

Description
Adding the ability to configure COS to SCC instance
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[x] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

I have successfully set up email notifications without any S2S auth policy between SCC and EN services. I received the notifications without any issues. I triple checked and found no auth policy between SCC and event notification services.
Additionally, I created a trial version of SCC in my cloud account, where no S2S authorizations were created, and observed the same outcome. Attached the email notifications received.
mtest-scc is from my ibm cloud account and test-scc-en-sender is from our dev account.
However, I put in the code to optionally create S2S between these services.

SCC team have confirmed the auth policy is no longer needed for event notifications.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Forward Flow moved to Module

The initial purpose was to get rid of delegatecalls for security reasons.
However, after considering discussions in the EIP-6900 group decided that delegatecalls should be access controlled instead of being removed.
Delegatecalls are currently possible for:

Forward Flow txns (execTransaction)
Modular flow (execTransactionFromModule)

Considering that:

We will need access control for Modules anyways
Forward Flow will be rarely to never used soon

decided to move Forward Flow to a separate module.
This will allow for:

Lighter and prettier codebase for SmartAccount.sol
Unified access control over delegatecalls in the future through Modules access controls, as FF now goes through execTransactionFromModule as well.

Now the only way of making delegatecalls is through execTransactionFromModule. It's up to the user now to enable or not a potentially dangerous module that uses Enum.Operation.delegatecall.
In any case, such a module can be quickly disabled.
In the future can introduce access control for delegatecalls in execTransactionFromModule through Guards-like architecture.
Check this file for more details on how FF txns are working now.
p.s. SmartAccount became now completely stateless, as both owner var and nonces mapping has been moved to the corresponding Modules and deprecated.

reviewed

Addressed the comments/questions, waiting for the feedback


ALL JOIN inflating numbers

Hi there,
imagine a simple query with a join like the following. When using an ANY join I get the same result as without a join but as soon as I use ALL, the result from the local fields (impressions, value..) is inflated. Usually this inflation is just 1-4% but in some cases it is 10-100 times. What would be the best course of action here?
SELECT
    category,
    count() AS impressions,
    uniq(sessionId) as sessions,
    sum(value) as value,
    sum(visible) AS visible,
    sum(engaged) AS engaged
FROM impressions ALL LEFT JOIN
(
    SELECT
        CounterID,
        engaged,
        visible
    FROM visits
    GROUP BY CounterID
) USING CounterID
GROUP BY category

If I understand your question correctly, this is how ALL JOIN is expected to behave.
(And ALL JOIN is the default behaviour of JOIN in other relational DBMSs)
If there are multiple rows in the right table with corresponding CounterID, it will create multiple rows in the result.

Usually this inflation is just 1-4% but in some cases it is 10-100 times.
CH always gives exact numbers. If you experience some inflation, even 0.00001% it means something wrong with design or it's some unknown CH's bug.

GROUP BY CounterID ) USING CounterID
means that the right table has only one row with each CounterID, so it should not be any difference with ALL vs ANY.
Can you show exact table DDLs and exact SQL, because your example is too vague and wrong for the right table engaged and visible are not a SUMS and they are not in GROUP BY section.

Here is a real query and the result:
Both tables are a simple MergeTree.
SELECT
    date,
    count() AS impressions,
    uniq(sessionUUID) as sessions,
    sum(value) as value,
    sum(visible) AS visible,
    sum(engaged) AS engaged
FROM `impressions` ANY LEFT JOIN
(
    SELECT
        impressionUUID,
        visible,
        engaged
    FROM `meta`
    WHERE date = yesterday()
) USING impressionUUID
WHERE date = yesterday()
GROUP BY date;

NO JOIN
┌───────date─┬─impressions─┬─sessions─┬──────────value─┬─visible─┬─engaged─┐
│ 2018-12-30 │     4353169 │   123935 │ 5636888.545389 │         │         │
└────────────┴─────────────┴──────────┴────────────────┴─────────┴─────────┘

ANY LEFT JOIN
┌───────date─┬─impressions─┬─sessions─┬──────────value─┬─visible─┬─engaged─┐
│ 2018-12-30 │     4353169 │   123935 │ 5636888.545389 │ 2662372 │    2274 │
└────────────┴─────────────┴──────────┴────────────────┴─────────┴─────────┘

ALL LEFT JOIN
┌───────date─┬─impressions─┬─sessions─┬───────────value─┬──visible─┬─engaged─┐
│ 2018-12-30 │    41745815 │   123935 │ 17641794.240708 │ 39908334 │  148958 │
└────────────┴─────────────┴──────────┴─────────────────┴──────────┴─────────┘

So probably meta has duplicates for some reason
SELECT      impressionUUID, count() cnt
FROM meta WHERE date = yesterday() group by impressionUUID having cnt > 1
What table engine is used by meta ? Replacing ?

Both tables are a simple MergeTree.

Your query returns: 13 rows in set. Elapsed: 0.485 sec. all with a cnt of 2

OK. Is it valid to have duplicates?
The observed difference is because these duplicates multiply select's result rows with ALL and does not with ANY.

Yes, these are not really duplicates, visible and engaged are treated separately.

so are they flags?
visible 0  engaged  1
visible 1  engaged  1
or numbers?
What CH version do you use?

They are boolean (numbers which can only be 0 and 1).
It is not possible that one row has visible and engaged set. It is always
impressionA visible 1 engaged 0
impressionA visible 0 engaged 1
18.16.1 revision 54412

OK. So is any difference in result

SELECT
    date,
    count() AS impressions,
    uniq(sessionUUID) as sessions,
    sum(value) as value,
    sum(visible) AS visible,
    sum(engaged) AS engaged
FROM `impressions` ANY LEFT JOIN
(
    SELECT
        impressionUUID,
        sum(visible) visible,
        sum(engaged) engaged
    FROM `meta`
    WHERE date = yesterday()
    GROUP BY impressionUUID
) USING impressionUUID
WHERE date = yesterday()
GROUP BY date;

the same with ALL LEFT JOIN

You are right, it works with the group by. I guess it was my mistake.
Btw. is there any way to tell ANY to pick the latest record? (go through it staring with the latest)

It's in your data. Just check what is going on for one of these (of 13) impressionUUID.
There is no mystery or magic or inflation.

Btw. is there any way to tell ANY to pick the latest record? (go through it staring with the latest)
No.
It will be something like that

select mx.1 impressionUUID, sum(mx.2) visible, sum(mx.3) engaged from
( select argMax((impressionUUID,visible,engaged),date) mx
  from `meta`
  group by impressionUUID, visible, engaged)
group by impressionUUID

I see. Thank you.


Add Trips Record Page

Add the ability to record trips for each guest along with their FlightAware information.

Fixed trips records.  Done.


query6 in 04_select.ipynb, 05_join.ipynb does not work

Thanks for making these tutorials! I am learning how to analyze Gaia data and use ADQL, and the notebooks have been very helpful.
I am having trouble running query6. It was an exercise in notebook 04 and the answer was given in notebook 05; when I try to run it it returns
HTTPError: Error 500:
null

I tried to submit query6 on https://gea.esac.esa.int/archive/ under the "Search", then "Advanced (ADQL) tab. It gives me this error:
Cannot parse query 'SELECT source_id, ra, dec, pmra, pmdec FROM gaiadr2.gaia_source WHERE parallax < 1 AND bp_rp
BETWEEN -0.75 AND 2 AND 1 = CONTAINS(POINT(ra, dec), POLYGON(135.306, 8.39862, 126.51, 13.4449, 163.017, 54.2424,
172.933, 46.4726, 135.306, 8.39862)) AND 1 = CONTAINS(POINT(pmra, pmdec), POLYGON( -4.05037121,-14.75623261,
-3.41981085,-14.72365546, -3.03521988,-14.44357135, -2.26847919,-13.7140236 , -2.61172203,-13.24797471,
-2.73471401,-13.09054471, -3.19923146,-12.5942653 , -3.34082546,-12.47611926, -5.67489413,-11.16083338,
-5.95159272,-11.10547884, -6.42394023,-11.05981295, -7.09631023,-11.95187806, -7.30641519,-12.24559977,
-7.04016696,-12.88580702, -6.00347705,-13.75912098, -4.42442296,-14.74641176)) ' for job '1691464891205O':
[esavo.adql.validator.OutOfRangeException] Coordinate 0 [esavo.adql.query.operand.NegativeOperand@6aa06ef2] of POLYGON
is out of range.

I wasn't able to figure out the issue even after some googling and documentation reading. Any chance you see the problem?

Thanks for letting me know about these issues. I will look into them as soon as I can, but in the meantime, you might want to switch to the Foundations of Astronomical Data Science, a curriculum based on the material in this repo and maintained by The Carpentries:
https://datacarpentry.org/astronomy-python/

Thanks for pointing me to the Carpentries curriculum site.
I went through their lessons and actually found the answer to this issue in https://datacarpentry.org/astronomy-python/05-select.html:

You may be wondering why we used BETWEEN for proper motion when we previously used POLYGON for coordinates. ADQL intends the POLYGON function to only be used on coordinates and not on proper motion. To enforce this, it will produce an error when a negative value is passed into the first argument.


Bug with serialisation of objects from activity when there are 2 types

Hi, a function like
function activityMethod(): FooData|false

returns an strObject instead of FooData object.
(FooData is Spatie Data)

Right now this cannot be implemented because the data converted doesn't know the types in the union (the type provided by temporal sdk is mixed).
To workaround this limitation I usually create a Result wrapper data object:
class ActivityResult extends Data {
    public function __construct(
        public bool $success,
        public ?FooData = null,
    ) {}
}


Exposing quaternion of THREE.Object3D

Hello,
I would like to be able to get the quaternion (rotation) of the camera or THREE.Object3D in general. Essentially I want to be able to use functions like this:
import * as THREE from 'three'

export function getSideVector(object: THREE.Object3D): THREE.Vector3 {
  // create default plane using normal vector
  const normalVector = new THREE.Vector3(0, 1, 0)
  const normalPlane = new THREE.Plane(normalVector, 0)

  // copy rotation of object to plane
  normalPlane.normal.set(0, 1, 0).applyQuaternion(object.quaternion.clone())

  // get new normal vector
  const newNormalVector = normalPlane.normal

  // create new vector from cross product
  const crossVector = new THREE.Vector3()
  crossVector.crossVectors(newNormalVector, getForwardVector(object))

  return crossVector
}

With this function I we would be able to move an object no matter its rotation perfectly sideways.
I haven't done so before, but I could try to create a pull request.
Best regards

At this point in time, the little pieces that I've picked up on from @Rich-Harris's talks/interviews is that he's focusing on svelte/svelte.kit . There's been a bunch of us waiting for this particular release for a while which is why there's a bunch of PR's already but my guess is that we should set our expectations accordingly. To be clear on my thoughts, a PR is welcome but it's probably going to take Rich some time before getting back to us.
If you haven't already seen it, here's a link to one of his talks from this playlist


Update how-to-configure.md

We had previously setup cloud sync with a new domain controller and a new domain to sync into our tenancy, we scrapped this VM/DC and started a fresh but the cloud sync on-prem account UPN remained, we were unable to setup cloud sync until this identity was deleted.

@billmath
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Error message for distance parameter.

If the distance parameter isn't included, we should throw a 401 with a little json that says: invalid request: the distance query parameter is required

I would suggest using 400 Bad Request or 406 Not Acceptable to better represent the error.

I would suggest using 400 Bad Request or 406 Not Acceptable to better represent the error.


Redstone improvements [SEE DESC]

Partially implemented comparators
Wires now power on/off simultaneously

Potential performance improvements
Improvements to linked powering
Fixes #1887
Fixes #1763
Fixes #1083
Fixes #2009

And we're back with the [SEE DESC] PR's ;)

@tigerw Can you write up a post on the forum about the general architecture of the simulator. Because no one else really understands it, so we can't review your code.

😜
I will try.
From: worktycho
Sent: Thursday, 28 May 2015 12:59
To: mc-server/MCServer
Cc: Tiger Wang
@tigerw Can you write up a post on the forum about the general architecture of the simulator. Because no one else really understands it, so we can't review your code.
—
Reply to this email directly or view it on GitHub.

Do you think it is a good idea, to reduce the size of IncrementalSim.cpp, to place the various redstone handler functions in their respective BlockHandlers?
From: worktycho
Sent: Thursday, 28 May 2015 12:59
To: mc-server/MCServer
Cc: Tiger Wang
@tigerw Can you write up a post on the forum about the general architecture of the simulator. Because no one else really understands it, so we can't review your code.
—
Reply to this email directly or view it on GitHub.

I think its a good idea to move things out of IncrementalSim, but I would not move them to the blockHandlers. I would create a separate set of redstoneHandler classes.

@tigerw Can you rebase this onto master?

Yes, though I must need address your comments first.

Ah, encountering the same problem as #1916. Is there no way no specialise std::hash with GCC/Clang?

Not in the current releases. Use a custom hash object instead.

What are all the note blocks binary files? And if you delete them please remove them from the history compleatly.

@tigerw wants to archive his world and stats on GitHub :)

It's my legacy, xoft.

About the style checker, I disagree that
return
{
   1, 2, 3
}

should be favoured over
return {
    1, 2, 3
}

since we use
if (
   (1 == 1) &&
   (2 == 2)
)
{
}

as opposed to
if
(
   ...
)
{
}

Merge?

I'm not going to merge this because you haven't addressed all my comments.

About std::pair:
I still don't fully agree with your recommendations. If a structure is used, the descriptiveness of the members would be that of m_BlockType and m_Chunk. In a pair, this would be given as BLOCKTYPE and cChunk by either reading the declaration or by the IDE. If one wanted to know what they did, one would still need to explore further.
About splitting large functions and the file in general:
I agree this is a good idea, but this pull request is already quite large and isn't relevant to it. I will be sure to do so sometime in the future.

I'm just not going to merge this. But I won't object if someone else does.

:/

I view of the guideline not to add unrelated changes to requests, what would you like me to do? Neither std::pair nor splitting have anything to do with performance/bug fixes, which are the primary concern of this request.
Are you sure this can't go in? None of the issues mentioned are being caused by these changes, merely raised by them.

If making a refactor would improve the code you're changing, make it part of the PR. Otherwise the refactors never happen. The problem is adding multiple feature/bug fixes to a PR, which you keep doing.

Also, whilst the changes do not cause a lot of the problems, they exacerbate them, which brings those problems in scope.

Could I sway you if I promise to refactor after exams?

No

Well.
That's that.

Merging, as I don't think it's likely tiger is going to refactor for a few weeks, due to exams. A proper refactoring of the redstone code should hopefully follow.


Dynamically support algorithms by detecting the derivation code from the provided digest

Perceived Problem
Being bound only Blake3-256 limits the usefulness of the library.
Ideas / Proposed Solution(s)
Open this up by detecting the derivation code from the SAID (qb64 text).

https://github.com/kentbull/saidify/pull/10 brings in additional algorithms.


Status update request on getting users through consent for graph token

Hi,
We're coming up on late 2022, so I'm wondering what the status of the userPrincipalName and email attributes of the GetConversationPagedMembers API. Has there been any progress on making it easier to get the user through consent? I noticed the note was removed, but I'm not sure if the underlying problem has been resolved.
For reference, we discussed this previously in https://github.com/MicrosoftDocs/msteams-docs/issues/2432
Here's the diff from when the note about getting users through consent was removed:
commit eeaabe76f95695c8b81942335ab9e98c4049a7bb
Author: TheBluLion<EMAIL_ADDRESS>Date:   Thu Apr 7 15:29:58 2022 -0500

    Update team-chat-member-api-changes.md

    removed internal comment stating that it must be made easier for bots to retrieve an access token

diff --git a/msteams-platform/resources/team-chat-member-api-changes.md b/msteams-platform/resources/team-chat-member-api-changes.md
index 72b6c358e..466d4409e 100644
--- a/msteams-platform/resources/team-chat-member-api-changes.md
+++ b/msteams-platform/resources/team-chat-member-api-changes.md
@@ -67,4 +67,4 @@ Following are the upcoming API changes:
     > `objectId` is changed to `aadObjectId` to match what is called in the `Activity` object of a Bot Framework message. The new API is available with version 4.8 or later of the Bot Framework SDK. It is also available in the Teams S
DK extension Bot Framework 3.x. Meanwhile, you can use the [REST](/microsoftteams/platform/bots/how-to/get-teams-context?tabs=json#get-single-member-details) endpoint.

 * `TeamsInfo.GetMembersAsync` in C# and `TeamsInfo.getMembers` in TypeScript or Node.js is formally deprecated. Once the new API is available, you must update your bots to use it. This also applies to the [underlying REST API that the
se APIs use](/microsoftteams/platform/bots/how-to/get-teams-context?tabs=json#tabpanel_CeZOj-G++Q_json).
-* By late 2022, bots cannot proactively retrieve the `userPrincipalName` or `email` properties for members of a chat or team. Bots must use Graph to retrieve them. The `userPrincipalName` and `email` properties are not returned from the new `GetConversationPagedMembers` API starting in late 2022. Bots have to use Graph with an access token to retrieve information. It must be made easier for bots to get an access token and streamline and simplify the end-user consent process.
+* By late 2022, bots cannot proactively retrieve the `userPrincipalName` or `email` properties for members of a chat or team. Bots must use Graph to retrieve them. The `userPrincipalName` and `email` properties are not returned from the new `GetConversationPagedMembers` API starting in late 2022. Bots have to use Graph with an access token to retrieve information.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c780d605-b1b2-716f-5888-503608769b5a
Version Independent ID: 53c724f8-d9a2-4af6-6d75-ddeaef084137
Content: Bot API changes for team and chat members - Teams
Content Source: msteams-platform/resources/team-chat-member-api-changes.md
Service: msteams
GitHub Login: @ojasvichoudhary
Microsoft Alias: ojchoudh

@ryfow -We are looking into this I will get back to you soon.

@ryfow -We are checking the method ,We are able to get the  userPrincipalName /email using the GetConversationPagedMembers API.
We are update the document accordingly.

@surbhigupta12 -Could you please help us to update the document?
Now we are able to retrieve the  userPrincipalName /email using the GetConversationPagedMembers API.
So please remove the below point(Last bullet point) on the below documentation.
"By late 2022, bots can't proactively retrieve the userPrincipalName or email properties for members of a chat or team. Bots must use the Graph APIs to retrieve the required information. The new GetConversationPagedMembers API can't return the userPrincipalName and email properties from late 2022. Bots must use Graph API with an access token to retrieve information"
Doc-https://docs.microsoft.com/en-us/microsoftteams/platform/resources/team-chat-member-api-changes#api-changes

here is PR for this: https://github.com/MicrosoftDocs/msteams-docs/pull/6280


New component proposal: full page error

For error states that block all app functionality. Example: LCD Failure (#228).

Will work on this tomorrow.


[FIX] Stop empty stripped song names from getting returned

[FIX] for #1896
In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the contributors guide.
[x] I have checked that another pull request for this purpose does not exist.
[x] I have considered, and confirmed that this submission will be valuable to others.
[x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
[x] I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

[ ] I have never used the project.
[x] I have used the project briefly.
[ ] I have used the project extensively, but have not contributed previously.
[ ] I am an active contributor to the project.

This fix prevents songs with only non-Latin characters in the title from being passed ahead. The query is terminated and the song shows up as unsupported instead.

Hello @Tantan4321! Thanks for opening this PR.

In the file swaglyrics/cli.py:

Line 38:3: E117 over-indented
Line 72:3: E117 over-indented

Do see the Hitchhiker's guide to code style

Changes implemented

Ok, fixes added

Hello @Tantan4321! Thanks for updating this PR.

In the file swaglyrics/cli.py:

Line 69:3: E117 over-indented

Comment last updated at 2019-12-07 20:34:26 UTC

can you take care of this? @Tantan4321


Properly declare as a client mod via the file's game versions

Colorful-hears gets downladed by https://github.com/itzg/docker-minecraft-server
The docs mentiots that mods properly declare as a client mod via the file's game versions to avoid this issue.
https://docker-minecraft-server.readthedocs.io/en/latest/types-and-platforms/mod-platforms/auto-curseforge/#exclude-client-mods

My bad, I forgot to mark the latest version files as such. I've marked the files as client only now. It might take some time for the change to sync through curseforge.

Thanks <3


Incorrect "Percent of Total" calculation when applying filters to leaderboards

To reproduce:

Enable the "Percent of Total" column on a leaderboard and apply a filter to it.
Check a different leaderboard's "Percent of Total" column.

Expected Behavior: The denominator in the "Percent of Total" calculation should adjust to reflect the filtered dataset.
Actual Behavior: The "Percent of Total" column remains unchanged, failing to account for the applied filter.

I had originally implemented the percent of total as you describe it, but it was specifically requested that we change the behavior to use the unfiltered total for calculating percentages. That update was made here and approved by Nishant who was involved in those conversations. https://github.com/rilldata/rill/pull/2799.
I'm not sure the current behavior is the best possible approach, but it's what was requested and approved, so I think we need a proposal/PRD before making change. Closing this issue as the calculation is actually correct according to the most recent spec.

@begelundmuller, do we have an API that would support use case of getting per-leaderboard totals that would sum to 100% including the case of leaderboards with some rows that are shown but filtered out? Would calculating these extra totals run into any of the same perf issues described in the discussion of the "others" line? (IIRC there was some concern about summing per leaderboard in that context, don't know if this would be similar)
(see also https://rilldata.slack.com/team/U03BKKKLV6F)

I think the spec is wrong, the percent should be the percent in the remaining filtered set from all our use cases that is what is useful (just like how measures only include the filtered set).

@avaitla Hey just wanted to let you know that we have discussed this and agree with you, and we're looking into a solution

@bcolloran The toplist API does not return per-leaderboard totals. Previously, I believe the dashboard separately called the totals API for each toplist.
We can look into adding it to the toplist API if needed – but under the hood, it's two different queries, so whether one API runs the two queries or it's two different APIs running one query is not a big difference from a performance perspective.
IIRC, there was previously a desire to use two APIs instead of one for this (for more incremental rendering, I would guess).
To unblock this work, I would probably recommend going with the two calls approach, and then we can separately investigate baking it into the toplist API if needed.

fixed in https://github.com/rilldata/rill/pull/3331


Can't import other script/lib in worker

⚠ IMPORTANT ⚠ Please check the following list before proceeding. If you ignore this issue template, your issue will be directly closed.

[x] Read the docs.
[x] Use Vite >=2.0. (1.x is no longer supported)
[x] If the issue is related to 1.x -> 2.0 upgrade, read the Migration Guide first.

Describe the bug
1, I can't import other script/lib in worker,  when Import other script, worker init failed and not error msg.
2, How can I use sharedworker in vite? I use import url, but it also can't import other script
I try this way, but  failed. chrome inspect can see error log:
import SW_URL from "./sharedworker.js?url";
const sw = new SharedWorker(SW_URL);

Reproduction
github/vite2-worker-bug。
System Info

vite version: ^2.0.0-beta.65
Operating System: windows10
Node version: 14
Package manager (npm/yarn/pnpm) and version: yarn 1.22.4

You should be using named imports....
- import random from "lodash-es";
+ import { random } from "lodash-es";
- import { msg } from "./msg.js";
+ import msg from "./msg.js";

Looks like Chrome currently doesn't log any import errors in module workers - that's not a Vite problem though.


slackcat --help

when I run slackcat --help before I configure, I get an error, not the help message.
for new users, I think it makes sense for the --help message to be visible even before configuration is available, just a suggestion though.

I'm not able to replicate this in the latest version; --help message displays without error when no config file is present. Can you specify your platform and version?

My platform osx 10.9
On Fri, May 20, 2016 at 11:54 AM, bradley<EMAIL_ADDRESS>wrote:

I'm not able to replicate this in the latest version; --help message
displays without error when no config file is present. Can you specify your
platform and version?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/vektorlab/slackcat/issues/35#issuecomment-220659873

I'm still unable to replicate this with the latest version of slackcat; closing for now


request for "gevoelstemperatuur"

Hi,
In the datastream coming from KNMI also a piece of data for "gevoelstemperatuur" is available.
As I am not quite known with merge requests, I kindly ask to take a look into the following addon:
In const.py to add in "SENSORS:"
{"name": "Gevoelstemp", "unit": "°C", "icon": "mdi:thermometer", "key": "gtemp"},
and in weather.py section "class KnmiWeather(KnmiEntity, WeatherEntity):"
@property
def gtemperature(self):
    """Return the temperature."""
    return float(self.coordinator.data["gtemp"])

@property
def gtemperature_unit(self):
    """Return the unit of measurement."""
    return TEMP_CELSIUS

This works for me quite well...
Thanks for looking.
Michel

Thanks Michel, will pick this up soon!

Hi @golles
As my knowlegde about github is not so high, I was not able  to get the branch from the site... sorry for that.
But instead I copied the 4 updated files manually ;-) The last 24 hours are running with the updated files.
So at this moment running version 1.1.4. And it looks OK!
As far as I can see right now everthing works accordingly.
Thanks.

Good to hear, I made a few more updates and merged it.
Dauwpunt and gevoelstemperatuur are now also added in the long term statistics of HA


Postgres container not building

🐛 Summary
What's wrong? The Postgres docker container is failing to build when following the Quickstart directions.
The log in the crossfeed_db_1 container says:

chmod: changing permissions of '/var/lib/postgresql/data': Operation not permitted
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.
The database cluster will be initialized with locale "en_US.utf8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".
Data page checksums are disabled.
initdb: error: could not change permissions of directory "/var/lib/postgresql/data": Operation not permitted
fixing permissions on existing directory /var/lib/postgresql/data ...

The npm start command results in the following error inline

backend_1   | (node:18) UnhandledPromiseRejectionWarning: Error: getaddrinfo ENOTFOUND db
backend_1   |     at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:71:26)
backend_1   | (node:18) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 20)

To reproduce

I'm using WSL (Ubuntu) on Windows 10 .
Node v14.20.1
Docker-compose 1.29.2, build 5becea4c

Expected behavior
A local version of Crossfeed
Any helpful log output or screenshots
See above

I changed the volume statement for the db container to
./postgres-data:/var/lib/postgresql/whatever:z
and things appear to have built.
It appears that you are not able to write /var/lib/postgresql/data and this needs to routed to a different directory.

@epicfaace @courtneyc1 - I doubt you want to put this is in the production version but here is my docker-compose file that I run locally to make it work - https://github.com/mbachtell-nais/crossfeed/blob/master/docker-compose.yml .

I just helped a person build this on a Mac and the original docker-compose file work without an issue.  When I try and run this in WSL on Windows I need to change the volume statement like I mentioned previously.  I don't have an explanation.

Is this still an issue with the latest check-ins?

I still experience it.  Have no technical explanation why.
If I add any string after the /data in the volume store for PostGRES the container will start.  Has to be a permission issue

I had a similar issue in the beginning.
I deleted the container, image then docker image prune -f,  docker volume prune -f, docker builder prune -f. Then deleted the postgres-data (using sudo) in wsl. Then synched,  npm start.


The window maximize button doesn't work on some Linux OS

Lapce Version
At least form 0.2.0 to the latest 0.2.3
System information
OS: LMDE 5
Kernel: 5.10.0-19-amd64
DE: Cinnamon 5.4.12
Describe the bug
On LMDE5(with Cinnamon desktop environment), the window maximize button doesn't work. I clicked it but nothing happened.
However the minimize button works well.
Additional information
I saw issue 1571, it seem that on KDE the window maximize works(but window is still able to be resized). I guess it may be a DE relevant issue.
I only have Cinnamon DE now, but if you need more information I will test more OS and DE.

I can confirm this is an issue on Gnome:

Gnome 42
Wayland
Pop!_OS 22.04

Pressing the maximize button or double clicking the header bar (which usually has the same effect) does not maximize the window. Minimize works, as does the "restore" icon (what the "maximize" icon becomes once you toggle it).

Shouldn't be an issue after we switched to Floem

Confirmed that this is fixed in latest.


Add s3 as storage backend

How it looks on the editor:

How it looks after posted:

@drodil, thanks for the quick feedback; I changed the config strings to be required; instead of using config.getOptionalString, I'm using config.GetString, which throws an error. Let me know if this is enough or you want me to throw another Error.

Thanks. Actually the secret and access keys can be optional. What comes to bucket, it should be optional in the config; if the user is using for example database to store images, he should not need to set the bucket value in the config. So only option is to throw the error yourself.
Does this make sense? 😄

I did some refactoring in #133, will merge that and close this one. Thanks again for the contribution!


Backticks are escaped even if sync function is not written to a file

Bug Report
The sync-function-loader module automatically escapes all occurrences of the backtick character as it is reading the document definitions. This is so that the generated sync function can be inserted into a Sync Gateway configuration file where the backtick character is used to denote a multi-line string. However, this could be problematic for a caller of the sync-function-loader module's load method if, for example, they need to perform some sort of processing on the generated sync function string before manually writing it to a file or they'd like to run it in their own Node.js VM. While certainly an edge case, it is still worth addressing.
Steps to reproduce
Consider if the following expression were to appear in a document definitions file:
originalString.replace(/\\\`/g, () => '`')

Actual behaviour
When read by the sync-function-loader, the expression would become
originalString.replace(/\\\\`/g, () => '\`')

which would match the wrong substring.
Expected behaviour
The expression should be read verbatim:
originalString.replace(/\\\`/g, () => '`')

Backticks in the document definitions should only be escaped at the point that they are written to a file.
Environment

Synctos: 2.2.1
Couchbase Server: 5.5 Developer Build
Sync Gateway: 1.5.1
Operating system: macOS High Sierra

Satisfied by #290


Set up GitHub Pages

Go to repository Settings and set up GitHub Pages (from the main branch), update repository description with the proper website link. Follow the link to check if everything is fine - you should see your index.html content.

https://holovashcenko.github.io/homepage/


BackupsCTA Rendering Incorrectly

https://github.com/linode/manager/blob/e1f34e93eb2c220d7aca2d178a72ca41e61bc6ab/packages/manager/src/features/Backups/BackupsCTA.tsx#L37
I think this line is evaluating to false somehow because all my Linodes have backups enabled and my /preferences data has no existence of the backups cta notification dismissal, which gets me a CTA that opens a drawer with no Linodes to backup:

Hey Martin 👋🏼 Hope you are doing well!
This component recently underwent a refactor (https://github.com/linode/manager/pull/9517) which has fixed this behavior 🎉
You can expect the fix to land in Cloud Manager v1.100.0 which is expected to release around Aug 21st 🗓🧰

Fixed by https://github.com/linode/manager/pull/9517 and released in v1.100.0


bench/test: add tests for the official lib of arrow.

What have you changed? (mandatory)
Add bench tests for the official lib of arrow, it seems the official lib behaves similarly to the implementation of tidb in iterating the rows, while behaves worse to build the chunk. Since we only build chunk and do not support compute with arrow in tikv, we will still use tidb's implementation now. Attention: we may consider to change the arrow lib to official lib once we support computation with arrow
What are the type of the changes? (mandatory)

Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
bench tests
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Benchmark result if necessary (optional)
test coprocessor::codec::chunk::bench_chunk_build_offical            ... bench:      48,382 ns/iter (+/- 4,548)
test coprocessor::codec::chunk::bench_chunk_build_tidb               ... bench:      24,833 ns/iter (+/- 2,955)
test coprocessor::codec::chunk::bench_chunk_iter_offical             ... bench:      27,042 ns/iter (+/- 1,714)
test coprocessor::codec::chunk::bench_chunk_iter_tidb                ... bench:      27,727 ns/iter (+/- 2,146)

@breeswish @zz-jason PTAL

em, why the official iterator is much better than ours...

Sorry, I've forgotten to check null in the test for the official lib, the iterator performance is similar then. I will update the tests later. @siddontang

nice job. Does it mean that we can replace our impl with officials later?

@breeswish
From the benchmark result, I think we don't need to move to the official implementation. but we can refer its alignment allocation.

We won't refer the official lib's alignment allocation in this PR with the following reasons @siddontang :

The official lib only supports push data column by column, while we push data row by row since we storage it row by row. If we change it, the performance of the chunk building is not very pretty.
We've already considered the alignment allocation in the current implementation, and it seems not bad.
The change may be very large, we'd better implement it in an independent PR if needed.

LGTM

@breeswish PTAL

@siddontang @zz-jason PTAL

LGTM.


C26951: escaping URLs that must be shown as text

Hello, @mairaw  ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.

Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.
Many thanks in advance.

Thanks @mairaw


is .wslconfig file NOT supported in Windows Home edition?

i've been trying for many hours to run the .wslconfig file and read pretty much everything about the problem online and for some reason its still not configured properly to run at my system.
is there any chance this feature is disabled on Windows Home edition?
thanks a lot for your time (=

Do you mean "wslconfig.exe"? That only existed prior to Windows 10 version 1903. Now you should use "wsl.exe" instead.
See: https://docs.microsoft.com/en-us/windows/wsl/wsl-config#managing-multiple-linux-distributions-in-earlier-windows-versions

hi @shawnz , thanks for your answer.
thats not what i meant.  ".wslconfig" file is the file for configuring global WSL options.
You can configure global WSL options by placing a .wslconfig file into the root directory of your users folder: C:\Users\<yourUserName>\.wslconfig. Many of these files are related to WSL 2, please keep in mind you may need to run wsl --shutdown to shut down the WSL 2 VM and then restart your WSL instance for these changes to take affect.

from https://docs.microsoft.com/en-us/windows/wsl/wsl-config

im trying to add a different kernel.
i opened another issue regarding this - #6728


add NCCO Notify

https://developer.nexmo.com/voice/voice-api/ncco-reference#notify

Added in #c67faa1 will be in 3.1.0 release


Refactor code used for pulling a package from central

Purpose

This PR will refactor the code used for pulling a package from central

Closing this PR in favor of https://github.com/ballerina-platform/ballerina-lang/pull/8394


Addressing feedback for instance sizes

Refactor sizes to introduce better handling:

Dot not sent plan for trial kafka. There is no concept of plan for those
Fix bypas_ams_check flag breaking creation
Rename flag to better reflect what it does.

We are still blocked to remove x1,x2 values due to lack of backend support.

Because of compatibility layer we can avoid specifying size for standard instance. @pb82 do you plan to remove that capability at some point. It is important for us to not break existing clients that create kafka with just specifying name.

@wtrocki there are no plans to remove the ability to skip the plan field at that time.


Outputs vs-2017.3.host.json file

This should now write out the correct file for VS to pick up. The icon is missing since I'm not totally sure about how we should inject that into the .template.config folder. Also, is there a description of each template we can use?

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Thanks! This is now merged, along with the icons, and a vague attempt at a description property.
Later on I'll change the sources so that instead of generating .template.config contents at build time, they are just plain files in source control. Then it will be easier to make per-template tweaks. I'll just change the Yeoman template generator to exclude the .template.config dir entirely.

Also I'll push an updated template package later today, hopefully.


feat: Update starknet_call

update starknet_call
Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?

Issue Number: #403
What is the new behavior?

In beerus_core and beerus_rpc, the starknet_call method receives a BlockId as a parameter.
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

As seen during the sync, @dpinones we can first focus on the original idea to add BlockId instead of the number which is great.
And then see in a second time and other PRs / Issues / Discussions the validation process which may be revised to fit the Beerus needs. :+1:

lgtm


:art: Re-add logo and icon with a higher resolution version

Change logo with a high resolution version.

Looks neat! 👌


installer.sh: update TPM2TOOLS_VER to 5.4 to fix the bug of parsing for MokListTrusted using the tpm2_eventlog command.

In tpm2-tools, https://github.com/tpm2-software/tpm2-tools/commit/b3dac7d32f9cdc6154720ecb01d0220cca6d2f79 fix the error Cannot allocate memory when using --eventlog-version=2. In keylime, https://github.com/keylime/keylime/blob/master/keylime/tpm/tpm_main.py#L711 also uses the tpm2_eventlog command to pasre MokListTrusted, which gets a similar error  - root - ERROR - Parsing of binary boot measurements failed with: ['{"message": "running tpm2_eventlog failed"}']
So we need to 5.4 to fix the bug of parsing for MokListTrusted using the tpm2_eventlog command.
Fixes: #1396
Signed-off-by: YiLin.Li<EMAIL_ADDRESS>

We can also update to 5.5 and cherry-pick https://github.com/tpm2-software/tpm2-tools/commit/9735dc332b782ce94371aff8746ce6a68094b038 and https://github.com/tpm2-software/tpm2-tools/commit/576a31bcc910da517067b29667f45fbe78e812e0. This would cover parsing for most newer logs.
@mpeters for packagers: if they want to use the measured boot feature on a modern distro they would need to update also tpm2-tools to a recent version.


Disable tooltip on the menubar

Hi!
Is there an option to disable the menubar icons tooltip?

:tada: This issue has been resolved in version 1.25.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

<el-tiptap :tooltip="false">
</el-tiptap>


Missing Project License

Hi everyone!
As I was working yesterday during the workshop and correcting the bug I mentioned on issue #43, I noticed the codebase doesn't include a license. Are there any restrictions or rules on how the code can be used, modified, and distributed? And how can one contribute, if desired? If so, would it be possible for it to be included in a license (And also perhaps on a CONTRIBUTING file at the root of the project?
Thank you for your consideration! Wish you an excellent day 😁
Jose

done, we always use MIT license for our Open Source work


Can't change text color or icon color?

Seems like quite a basic thing. I tried using some of the available methods however they did nothing.
For example setting the TextAppearance worked on the default tab only, but even then after you move to a different tab, and then back again, the text color reverted back to white.
This is not very useful when the background of the bottom bar is also white. I have assets that are the correct color I want, and this library turns them to white for some reason. Is there a way I can change the tint?
I'm either missing something, or there are just a lot of bugs with this library and basic features missing.

To change color of text and icon use this in your tabs
activeColor="#FAFAFA"
inActiveColor="#FAFAFA"

One of my tab is like this
<tab
            id="@+id/tab_favorite"
            icon="@drawable/ic_favorite_white_24dp"
            title="Favorite"
            barColorWhenSelected="#FFA726"
            activeColor="#FAFAFA"
            inActiveColor="#FAFAFA" />


Translate configuration/resource-bin-packing.md in Korean.

This is a Feature Request
What would you like to be added
Translate configuration/resource-bin-packing.md in Korean.
Why is this needed
The following files are not translated into Korean.

[ ] /en/docs/concepts/configuration/resource-bin-packing.md

Comments
Page to update: https://kubernetes.io/docs/concepts/configuration/resource-bin-packing/
I am translating this document.
The translated document will be submitted to dev-1.18-ko.2 branch.
/language ko

/assign

/close


Error when running tinyMMLU

Getting an error - IndexError: index 5 is out of bounds for axis 0 with size 5  when running tinyMMLU on my gguf model.

Does the same fail if you try running using --model hf ?

@haileyschoelkopf  Sorry, I have not tried that my main objective is only for GGUF converted models.


Apply the Istio patch to istio.yaml

The istio.yaml published as part of the Knative Serving release is too
heavy in both the number of replicas and reservations. We previously
scaled it back using a "patch" yaml that duplicates the resources that
needed to change. Now we use a single yaml file with the patch applied.
The diff from the Knative version is also published.

Could we use kustomize to patch the istio resource or is the approach too fragile?

@glyn the rational is threefold:

applying one file is more efficient than applying two files for the same result. Within k8s we no longer mutate a resource that was just created
we can avoid images published using the registry v1 api as their digests will mutate in certain conditions making the digest not very useful as a digest.
the "patch" file is actually more work to maintain since it must contain a full copy of the resource being modified. We needed to make sure that any other changes are also applied in the patch file.

@fbiville you're welcome to try using kustomize to generate the file.


UnknownTokenException: Unknown token found: value_json.power_on_behavior

using zigbee2mqtt with HA auto-discovery.
I am getting lots of error log entries with the following message:
Executing the JINJA-transformation failed: An error occurred while transformation. UnknownTokenException: Unknown token found: value_json.power_on_behavior
Environment:
OpenHAB 3.4.2
JINJA transformation service with Zigbee2MQTT Home-assistant Auto-Discovery option.
{
  "availability": [
    {
      "topic": "zigbee2mqtt/bridge/state"
    }
  ],
  "device": {
    "identifiers": [
      "zigbee2mqtt_0x60a423fffed2e99f"
    ],
    "manufacturer": "TuYa",
    "model": "Socket module (TS011F_socket_module)",
    "name": "wallplug16A"
  },
  "enabled_by_default": false,
  "entity_category": "config",
  "icon": "mdi:power-settings",
  "json_attributes_topic": "zigbee2mqtt/wallplug16A",
  "name": "wallplug16A power on behavior",
  "state_topic": "zigbee2mqtt/wallplug16A",
  "unique_id": "0x60a423fffed2e99f_power_on_behavior_zigbee2mqtt",
  "value_template": "{{ value_json.power_on_behavior }}"
}

This appears to be an issue with something using jinja, not with jinja itself.


Add babel-plugin-transform-class-properties to babel

If I try to use this tool together with react-native-web several libraries don't work, because in react-native it's common to use syntax like this:
class Test extends Component {
  handleBackPress = () => {
    this.goBack();
    return true;
  }
}

So we should add the babel-plugin-transform-class-properties plugin to babel.

It's already enabled for application code. We don't plan to enable unstable proposals for library code. It creates a ton of churn in the ecosystem when those proposals are dropped or change semantics.


Performing upgrade of Grafana from 10.1.7 to 10.1.9, Server Status Panels are corrupt (vertical/horizonatal bars masking data)

After upgrade when installing latest Grafana Plugins,  the latest status panel (vonage-status-panel) is downloaded and
extracted to the server.
When grafana-server was restarted the following anomaly was observed on the Server Current Performance panel, or status panel:

As can be seen the data CPU / Memory usages figures are masked out by vertical/horizontal bars.
The dashboard JSON file shows this panel is of type vonage-status-panel, and a recent release of this plugin v2.0.0
(May 23-26 2024) introduced this anomaly.
I have attached dashboard JSON.

Customer System Health Dashboard-1717069800243.json

Facing the same issue with v2.0.0 on Grafana v10.4.2
For now, I've rolled back Status Panel to v1.0.10 which seems to fix the panels using the plugin. Of course, the panels now have the Angular warning on them.

Any solution for this plugin?

@mccannm1 sorry for taking a while to get back to you.
Could you provide more info?
It would be helpful to have the

screenshot before (working in previous version)

screenshot after (how it looks like after update - I assume same as above in the issue description)

A cleaner reproduction case - since we don't have your data it is hard to reproduce the case, for that you can either create a simple dashboard and use testdata datasource to populate it with dummy data and then give us dashboard.json working (old version) vs. not working (new version).

Alternatively you can use "More -> Get Help" (Here is how)

Make sure there is no sensitive information in there and then just reply and attach the information to this issue.
If you are facing the same issue your data might also be helpful @LochMessMonster