smpcall: add nxsched_smp_call_async and nxsched_smp_call_single_async

Summary
reason:
The old implementation of the SMP call, even when using the "no wait" parameter, could still result in waiting, if invoking it within a critical section may lead to deadlocks. Therefore, in order to implement a truly asynchronous SMP call strategy, we have added nxsched_smp_call_async.
https://github.com/apache/nuttx-apps/pull/2822
https://github.com/apache/nuttx/pull/14656
These two pull requests (PRs) must be merged together.
Impact
smp call
Testing
ci ostest
Build Host:

OS: Ubuntu 20.04
CPU: x86_64
Compiler: GCC 9.4.0

Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic
-machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx

[Experimental Bot, please feedback here]
The PR appears to partially meet the NuttX requirements.  While it provides a reason for the change and identifies the affected functional area, it lacks crucial details. Here's a breakdown:
Missing/Insufficient Information:

Summary:  While the reason for the change is stated, the "what" and "how" are insufficiently explained. It mentions adding nxsched_smp_call_async, but doesn't describe how this new function differs from the existing implementation and what changes were made to achieve the asynchronous behavior.
Impact: Simply stating "smp call" isn't descriptive enough.  The PR needs to address all the impact points listed in the requirements:

Is new feature added? Is existing feature changed? (Yes, a new function is added)
Impact on user:  Will users need to modify their code to use the new asynchronous call?
Impact on build:  Are there any new build dependencies or configuration options?
Impact on hardware: Does this change affect specific architectures or boards?
Impact on documentation: Is documentation updated to reflect this new function and its usage?
Impact on security:  Are there any potential security implications of this change?
Impact on compatibility:  Does this break backward compatibility?

Testing: While the build host details are provided, the target information is vague ("arch(sim,RISC-V,ARM,..), board:config").  It specifies qemu-armv8a:nsh_smp, which is better, but still lacks details about the specific configuration used.  More importantly, the "Testing logs before change" and "Testing logs after change" sections are empty.  These are crucial for demonstrating the change's effectiveness and for verifying that the new function works as intended.  Include actual log output showcasing the previous behavior (e.g., demonstrating the unwanted wait) and the improved behavior after the change (showing the asynchronous operation).

Recommendations for Improvement:

Summary:  Elaborate on how nxsched_smp_call_async works and what specific code modifications were implemented.  For example, explain the mechanism used to achieve asynchronicity (e.g., using a separate worker thread, sending a signal, etc.).
Impact: Address all the impact points listed in the requirements with specific details.  Don't just state "NO" or "YES"; explain why.
Testing:

Provide complete target details, including the specific qemu-armv8a configuration used.
Fill in the testing logs! This is the most important part. Show the output of relevant commands or tests before and after the change to demonstrate the improvement and verify the fix.  The logs should clearly illustrate the difference in behavior.

By providing the missing information and following these recommendations, the PR will better meet the NuttX requirements and increase the likelihood of it being accepted.

@hujun260
A deadlock happens with esp32-devkitc:smp (QEMU)
/home/ishikawa/opensource/QEMU/qemu-esp-develop-8.2.0-20240122/build/qemu-system-xtensa -nographic -M esp32 -smp 2 -drive file=/home/ishikawa/qemu_efuse.bin,if=none,format=raw,id=efuse -global driver=nvram.esp32.efuse,property=drive,value=efuse -drive file=./nuttx/nuttx.merged.bin,if=mtd,format=raw
==12842==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Adding SPI flash device
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x12 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3ffb40f0,len:1056
load:0x40080000,len:23844
entry 0x40082858
*** Booting NuttX ***
dram: lma 0x00001020 vma 0x3ffb40f0 len 0x420    (1056)
iram: lma 0x00001448 vma 0x40080000 len 0x5d24   (23844)
padd: lma 0x00007178 vma 0x00000000 len 0x8e80   (36480)
imap: lma 0x00010000 vma 0x400e0000 len 0x1e914  (125204)
padd: lma 0x0002e91c vma 0x00000000 len 0x16fc   (5884)
dmap: lma 0x00030020 vma 0x3f400020 len 0x9c84   (40068)
total segments stored 6

NuttShell (NSH) NuttX-12.0.0
nsh>
nsh> uname -a
NuttX 12.0.0 904b6ff85b Nov  6 2024 13:47:16 xtensa esp32-devkitc
nsh> mount
  /proc type procfs
nsh> ps
  PID GROUP CPU PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK            STACK    USED FILLED COMMAND
    0     0   0   0 FIFO     Kthread   - Assigned<PHONE_NUMBER>000000 0003056 0000744  24.3%  CPU0 IDLE
    1     0   1   0 FIFO     Kthread   - Running<PHONE_NUMBER>000000 0003056 0000432  14.1%  CPU1 IDLE
    2     2   0 100 RR       Task      - Running<PHONE_NUMBER>000000 0003016 0002104  69.7%  nsh_main
...
End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena       4bc5c    4bc5c
ordblks         7        6
mxordblk    2acd0    2acd0
uordblks     6c64     6c64
fordblks    44ff8    44ff8

user_main: smp call test
smp_call_test: Test start
smp_call_test: Call cpu 0, nowait

@hujun260
A deadlock happens with esp32-devkitc:smp (QEMU)
/home/ishikawa/opensource/QEMU/qemu-esp-develop-8.2.0-20240122/build/qemu-system-xtensa -nographic -M esp32 -smp 2 -drive file=/home/ishikawa/qemu_efuse.bin,if=none,format=raw,id=efuse -global driver=nvram.esp32.efuse,property=drive,value=efuse -drive file=./nuttx/nuttx.merged.bin,if=mtd,format=raw
==12842==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Adding SPI flash device
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x12 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3ffb40f0,len:1056
load:0x40080000,len:23844
entry 0x40082858
*** Booting NuttX ***
dram: lma 0x00001020 vma 0x3ffb40f0 len 0x420    (1056)
iram: lma 0x00001448 vma 0x40080000 len 0x5d24   (23844)
padd: lma 0x00007178 vma 0x00000000 len 0x8e80   (36480)
imap: lma 0x00010000 vma 0x400e0000 len 0x1e914  (125204)
padd: lma 0x0002e91c vma 0x00000000 len 0x16fc   (5884)
dmap: lma 0x00030020 vma 0x3f400020 len 0x9c84   (40068)
total segments stored 6

NuttShell (NSH) NuttX-12.0.0
nsh>
nsh> uname -a
NuttX 12.0.0 904b6ff85b Nov  6 2024 13:47:16 xtensa esp32-devkitc
nsh> mount
  /proc type procfs
nsh> ps
  PID GROUP CPU PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK            STACK    USED FILLED COMMAND
    0     0   0   0 FIFO     Kthread   - Assigned<PHONE_NUMBER>000000 0003056 0000744  24.3%  CPU0 IDLE
    1     0   1   0 FIFO     Kthread   - Running<PHONE_NUMBER>000000 0003056 0000432  14.1%  CPU1 IDLE
    2     2   0 100 RR       Task      - Running<PHONE_NUMBER>000000 0003016 0002104  69.7%  nsh_main
...
End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena       4bc5c    4bc5c
ordblks         7        6
mxordblk    2acd0    2acd0
uordblks     6c64     6c64
fordblks    44ff8    44ff8

user_main: smp call test
smp_call_test: Test start
smp_call_test: Call cpu 0, nowait

Ok, let me check this issue

@hujun260
raspberrypi-pico:smp has the same issue.

Sorry @hujun260: maix-bit/knsh_smp build is failing due to g_call_data:
Configuration/Tool: maix-bit/knsh_smp
Error: smp_call.c:36:31: error: 'g_call_data' defined but not used [-Werror=unused-variable]
   36 | static struct smp_call_data_s g_call_data;
      |                               ^~~~~~~~~~~

https://github.com/nuttxpr2/nuttx/actions/runs/11697271041/job/32575765356#step:7:181

@masayuki2009
please help me verify  this patch https://github.com/apache/nuttx/pull/14663

@hujun260 I just confirmed that maix-bit/knsh_smp is failing in our NuttX Mirror due to g_call_data. Does the new patch fix the build? Thanks!
Configuration/Tool: maix-bit/knsh_smp
Error: smp_call.c:36:31: error: 'g_call_data' defined but not used [-Werror=unused-variable]
   36 | static struct smp_call_data_s g_call_data;
      |                               ^~~~~~~~~~~

https://github.com/NuttX/nuttx/actions/runs/11698181980/job/32578126735#step:7:181

@hujun260 I just confirmed that maix-bit/knsh_smp is failing in our NuttX Mirror due to g_call_data. Does the new patch fix the build? Thanks!
Configuration/Tool: maix-bit/knsh_smp
Error: smp_call.c:36:31: error: 'g_call_data' defined but not used [-Werror=unused-variable]
   36 | static struct smp_call_data_s g_call_data;
      |                               ^~~~~~~~~~~

https://github.com/NuttX/nuttx/actions/runs/11698181980/job/32578126735#step:7:181

https://github.com/apache/nuttx-apps/pull/2825


Events not behaving as expected

I'm using bevy 0.3.0 and kurinji 1.0.1, and I was attempting to implement a proof of concept using events to register the following flow:

When the user clicks the left mouse button: A single message is printed indicating that the mouse button has just been pressed down
When the user holds the left mouse button: After the prior message, a different message is repeated for as long as the button is held
When the user lets go of the left mouse button: A single message says that the mouse button has been let go and no further messages appear until the button is clicked again

I did this by looking at the event example from the repo. I implemented a struct with three eventreaders, for OnActionBegin, OnActionActive and OnActionEnd. Then I added three systems, one for each reader, that take the entire struct in and attempts to read the latest action to see if it is what is needed. Unfortunately instead of the expected behavior;

mouse button clicked
mouse button held
mouse button held
...
mouse button released

What I see is the following:

mouse button clicked
mouse button held
mouse button clicked
mouse button held

Repeated until I release the mouse button with no trace of my OnActionEnd message. The following is my code for the event reader struct and the systems
#[derive(Default)]
pub struct ActionState {
    begin_reader: EventReader<OnActionBegin>,
    active_reader: EventReader<OnActionActive>,
    end_reader: EventReader<OnActionEnd>,
}

fn player_action_begin(
    mut state: Local<ActionState>,
    action_begin_event: Res<Events<OnActionBegin>>,
    mut query: Query<&mut Player>,
) {
    let action = match state.begin_reader.latest(&action_begin_event) {
        Some(value) => value,
        None => return,
    };
    let player = match query.iter_mut().next() {
        Some(value) => value,
        None => return,
    };

    if action.action == "MOVE_TO_MOUSE" {
        println!("{:?} MOVE TO MOUSE", SystemTime::now());
    }
}

fn player_action_active(
    mut state: Local<ActionState>,
    action_active_event: Res<Events<OnActionActive>>,
    mut query: Query<&mut Player>,
) {
    let action = match state.active_reader.latest(&action_active_event) {
        Some(value) => value,
        None => return,
    };
    let player = match query.iter_mut().next() {
        Some(value) => value,
        None => return,
    };

    if action.action == "MOVE_TO_MOUSE" {
        println!("{:?} keep moving to mouse", SystemTime::now());
    }
}

fn player_action_end(
    mut state: Local<ActionState>,
    action_end_event: Res<Events<OnActionEnd>>,
    mut query: Query<&mut Player>,
) {
    let action = match state.end_reader.latest(&action_end_event) {
        Some(value) => value,
        None => return,
    };

    let player = match query.iter_mut().next() {
        Some(value) => value,
        None => return,
    };

    if action.action == "MOVE_TO_MOUSE" {
        println!("{:?} stop moving TO MOUSE", SystemTime::now());
    }
}

Big fan of this plugin, and I hope I can get it to work the way I wanted!

Hey @Sheepyhead, Glad you like the plugin. Yes there is something definitely wrong with the events you are receiving. I will check it out.

I have published a patch release on crate.io. @Sheepyhead Can you try it and let me know if it solved your issue.
Kurinji v1.0.3
Changelog

fixed* issue Events not behaving as expected #36
fixed* not all action's prev str are cached
fixed* on action end not fired

I have published a patch release on crate.io. @Sheepyhead Can you try it and let me know if it solved your issue.
Kurinji v1.0.3
Changelog
* fixed* issue Events not behaving as expected #36

I can confirm that 1.0.3 now behaves exactly as expected! Thanks so much for the quic response

closing ticket


Escape sequences displayed on running 'groovy -h'

Environment
Win32NT 10.0.18363.0 Microsoft Windows NT 10.0.18363.0
Windows Terminal Version: 1.4.3243.0
groovy 3.0.4 windows binaries
Cygwin

Steps to reproduce
run groovy -h
Expected behavior
escape sequence characters should be interpreted correctly, like on Cygwin terminal:

Actual behavior

Groovy, or the runtime it uses, is explicitly disabling escape character handling when it is talking to the Windows console.

@DHowett  I'm not sure if this adds anything useful, but the colors show correctly under windows console
this is in windows console; cmd

Besides, windows console and Cygwin terminal behaving correctly suggests that this is an issue with windows terminal!

How about when you run it from Cygwin in the Windows Console? That's closer to the scenario you're testing out in Terminal.
The whole thing of it is that behind every pane or tab in Terminal is a copy of the Windows Console. It's just named OpenConsole.exe instead of conhost.exe.
You've tested two scenarios out of four possible so far.

x
console host
mintty

launched from cmd
✔ works fine
untested

launched from cygwin bash
:x: doesn't work properly
✔ works fine

If you launch Cygwin Bash in conhost the same way you launch it in Terminal (that is, by running "bash.exe -l -i" directly and not using the mintty shortcut), what happens?
If you launch Groovy from CMD inside Terminal, what happens?
Further, what version of the Cygwin runtime are you using?
What is the content of the $TERM environment variable in the broken scenario?

(I have a suspicion that two things are happening here. This could be backed up with some console host tracing.

Cygwin is disabling VT mode before spawning Groovy

cmd doesn't do this.

Groovy, or Java, or whatever took a dependency on VT mode being enabled, but they didn't explicitly enable it, which makes them a poor citizen on Windows.

)

you are right, I've tested it under in windows console under bash like you've suggested, same weird behavior.
same for when run under cmd in mintty.

x
console host
mintty

launched from cmd
✔ works fine
❌ doesn't work properly

launched from cygwin bash
❌ doesn't work properly
✔ works fine

Still, I'd expect Windows Terminal to behave the same way as mintty when running Cygwin bash. maybe this needs some fixing?!

unfortunately, we don't have control over that. Cygwin has a special contract with mintty because they are not using the windows console APIs. This is unfixable from our perspective: since they are (in mintty's case) not using the windows console APIs and (in conhost's case) using the Windows console APIs in a way that contravenes reality, we cannot help them.
Trust me: we've tried! Terminal explicitly enables VT parsing mode for all applications by default! Groovy, or Cygwin, *still explicitly turns it off and then expects it to work. There's nothing we can do about that.


Remove unused lru-cache dependency

Fixes: #83
Motivation and Context
lru-cache is an unused dependency.
Description
lru-cache has been removed using yarn remove.
How has this been tested?
This change has not been manually tested as it is not expected to change any functionality.

Thanks for submitting the PR @alexparish - the js-commons continues to have a dependency on lru-cache. Is this causing a problem for your integration?

@leoromanovsky I’m not having any problems at all. I just spotted the unused dependency and wanted to clean it up, inspired by the e18e initiative 🧹


Incorrect use of SemVer

In Semantic Versioning, x.y.z-anything is a lower version than x.y.z. The fact that the latest release (at time of writing) is 3.4.9-3 and there also seems to be a 3.4.9 is confusing npm outdated:
➜  git:(remove-redundant-port-variable) ✗  npm outdated
Package    Current  Wanted   Latest  Location
zookeeper  3.4.9-3   3.4.9  3.4.9-3  zookeeper-updater

➜  git:(remove-redundant-port-variable) ✗  npm update zookeeper

...
...
...

➜  git:(remove-redundant-port-variable) ✗  npm outdated
Package    Current  Wanted   Latest  Location
zookeeper    3.4.9   3.4.9  3.4.9-3  zookeeper-updater

My package.json contains:
"zookeeper": "^3.4.9-3"
The weird thing is I don't see a 3.4.9 release anywhere :/

node-zookeeper versioning is connected to zookeper versioning.
Let's take 3.4.9-3 as an example, 3.4.9 is zookeper version which was used, -3 is the version of node-zookeeper based on given zookeeper version.
Last time we talked about this we've decided we are not going to change this, but maybe other contributors have changed their minds in meantime.

In a fork with ongoing work for adding Windows support, I have used semver. That is because of breaking features in the fork (dropping support for really old nodejs versions).
Semver will help users of this package to not break any automated builds. Example: a dependencies section with wildcard for this package (zookeeper: "3.4.x")
See this issue for more info (and a cry for C/C++ help!):
https://github.com/yfinkelstein/node-zookeeper/issues/78#issuecomment-453748000


EXLM 1984 - Temporarily hide error message in Role and Industry

Please always provide the Jira Issue your PR is for, as well as test URLs where your change can be observed (before and after):
Jira ID: https://jira.corp.adobe.com/browse/EXLM-1984
Test URLs:

Before: https://main--exlm--adobe-experience-league.hlx.live
After: https://EXLM-1984--exlm--adobe-experience-league.hlx.live

This PR is no longer required.


Custom templates don't work well with NestedModels

When you create a custom template that references a data-editor that is a NestedModel, it hoses up various input fields.
See http://jsfiddle.net/bpardee/zqXU3/1/
The text and select fields aren't rendered or the nested model fields.  If you comment out the template option in the Form constructor or comment out the address field in the custom template then it works.

I'm having trouble with this particular use case as well -- I noticed in your case, though, that making the address field a value of 'data-fieldsets' seemed to solve the problem.

as of now this problem still persists, has anyone figured a way to address this ?, happens also with Objects


To-Do General

GameManager. Some things to consider are what area the player is in, whether or not they have the key, if they died (0 hp), their inventory, maybe a scene leading up to the boss. We'll use a template to streamline the process.
Camera is top down perspective
Multiple weapons to choose from
Whether or not the player is fighting (battle screen)
Some dungeons leading up to the boss as well as a tutorial room to guide the player and at the end fight a weak enemy. After that, they will enter the real game
Background for each screen, battle screen can just be a solid color (or pattern)
Spritesheet for tiles in background
UI that displays player health, MP, inventory
Canvas Script
Music(?)
Credits screen featuring the team
(Will be expanded on later)

Way to implement the tiles for overworld - have gameobjects with sprite renderers and colliders and place them like you would tiles in another game that has level editing.


Can we please add Debian 12 (i.e bookworm) in manifests/params.pp file?

Hi,
I'm trying to setup NFS on a Debian 12 server and come across a problem that it is trying to check the status for idmapd service (which is in default code) whereas the actual service is nfs-idmapd. This can be resolved by adding bookworm in the manifests/params.pp file.
Thanks in advance

Hi,
You can use this as a workaround :
  class { 'nfs':     server_enabled => true,     nfs_v4 => true,     server_nfsv4_servicehelper => ['nfs-idmapd'],   }

Hi @PiR-B,
Thank you so much for letting me know.


SW-6253 Implemented project overall scores table and endpoints

This will replace project scores once we deprecate the V1 endpoints.

#2639  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Nov 26, 3:49 PM EST: A user merged this pull request with Graphite.


NIFI-4828: Fix MergeContent to process all ready bins

NOTE to reviewers
This pull request has 3 commits intentionally. The first one is sufficient to address NIFI-4828. The other two commits are further refactoring those are not required, but should be incorporated, too. I didn't create dedicated JIRAs for those since they're too trivial.
Please squash commits and merge if all of those look fine. Or remove the 2nd or 3rd commit if it looks over engineered. Thank you!

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ijokarumawak thanks for addressing! Code review looks good. All unit tests pass (including the ones that were @ignored previously!) and some local testing all worked out exactly as expected. +1 merged to master.


Stop SWF execution when too many errors are encountered.

SWF: 5de16d1f3b9b2a42cd1df9b089bc05c27d9d6d97cc3323c702ff36a17af15182 (Direct Link)

Ad doesn't work at all, anymore. Including in the Flash Player.


Disallow empty logger fields

Empty logger fields should never be allowed. They do not serve a purpose and can only happen due to an accident. Also this will ensure issues with logging software like elasticsearch which does not allow that.

I'll add another PR for this, as the case for different types than map[string]interface was not handled.


Roll Flutter Engine from 679c4b42e222 to 76dc4f9895ec (3 revisions)

https://github.com/flutter/engine/compare/679c4b42e222...76dc4f9895ec
2023-02-02<EMAIL_ADDRESS>Roll Skia from c3c5c6f61421 to 532c04c00ad7 (1 revision) (flutter/engine#39333)
2023-02-02<EMAIL_ADDRESS>Roll Skia from 934ef0660509 to c3c5c6f61421 (1 revision) (flutter/engine#39332)
2023-02-02<EMAIL_ADDRESS>Add missing file to artifacts.zip and win platform. (flutter/engine#39310)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Chart & Operator support for replica configuration

Context: Today BRO chart and operator logic isn't designed or intended to have multiple replicas. This is a known aspect of the BRO design and for now it's intended to be a "singleton" pod.
https://github.com/rancher/backup-restore-operator/pull/41#discussion_r497810179
To consider:

[ ] Manage lease when more than one operator pods(controllers) are running
[ ] Adjusting the Chart to allow replicas to be configured

This is a ticket to track tech debt that was pointed out in a review of an old PR that had been merged.

It seems the consideration here is to have a failover/redundancy mechanism for BRO.
If we aim to accomplish redudancy, then adding a leader election to the BRO operator is a 3 line code change, and a trivial CRD change to deploy the number of replicas. However, I don't see this as useful.
Although a nice improvement, we haven't seen any of these issues in production. The scenarios where redundancy is useful as a failure mechanism is if the pod fails critically due to a sporadic software bug (in which case the software bug should be fixed, and redundancy will only speed up recovering) or if resource saturation is reached.
When resource saturation is reached, either the cluster is having problems which is outside the scope in which BRO can fix itself or the resource limits are improperly configured, becoming a user configuration issue. A useful use case of redundancy is in the case of node failures and to deploy BRO as a daemon-set, but a singleton will still attempt to recover on healthy nodes, so the only gain here is speeding up failure recovery scenarios.
If the idea here is instead to scale up the BRO operator (optimized), then redundancy isn't useful unless we shard the backup and restore workloads, but that isn't incredibly useful as the workloads are IO (and thus CPU) bound. The only speed up feasible I see with sharding the operator workloads is to shard across node resources, but that requires more sophisticated techniques beyond kubernetes leases, controller runtime leader election or any kind of network load balancing.


Make web app warning banner in the middle of the screen and simpler

Before:

After:

I would not say 'web app may have breaking changes', just has bad optics.

I would not say 'web app may have breaking changes', just has bad optics.

Okay but I do think we should say something that explains why the desktop app is more reliable. People think web apps are less reliable than desktop apps already, and the reason our desktop app is more reliable is more about it being on a slower release cycle than anything.

Maybe just, "the web app is not officially supported", that kinda implies that we not fixing web app specific issues. and than maybe "proceed at my own risk" instead of "okay I understand"?

I also think the "download desktop app" should be more of a CTA button, stand out more.

Love @Irev-Dev 's suggestions. Yes this would work well I believe. It biases people toward the desktop app while not shitting on the web app. :laughing:

Sounds good, can do


Added python3 version of cairosvg

Please add the following dependency to the rosdep database.
Package name:
python3-cairosvg
Package Upstream Source:
https://github.com/Kozea/CairoSVG
Purpose of using this:
Converting SVG into PDF and PNG, the python2 version is already in use by aruco_detect for marker generation.
Distro packaging links:
Links to Distribution Packages

Debian: https://packages.debian.org/stable/python3-cairosvg

REQUIRED

Ubuntu: https://packages.ubuntu.com/focal/python3-cairosvg

REQUIRED

Fedora: https://src.fedoraproject.org/rpms/python-cairosvg

IF AVAILABLE

Arch: https://archlinux.org/packages/community/any/python-cairosvg/

IF AVAILABLE

Gentoo: https://packages.gentoo.org/packages/media-gfx/cairosvg

IF AVAILABLE

I am not familiar with RPM systems, so I wasn't sure how to parse that page. Thanks for catching the error.

I am not familiar with RPM systems, so I wasn't sure how to parse that page.

No worries! That's why we review changes :smiley: Thanks for updating the PR.


zig build system: cache build artifacts and detect cache invalidation

migrated from #204

[ ] in zig itself, cache objects by creating a sha256 hash of all the inputs that goes into it, such as the list of source files used with their mtimes, the compile variable values set, the modification time of the zig binary itself as well as the recursive modification time of the dynamic libraries the zig binary depends on. Verify that builtin.o, compiler_rt.o, test_runner.o, and all objects made with zig only have to be created when zig is recompiled or when their sources are changed.

@embedFile should add the target to the hash
c_import should detect when a file is looked at by libclang and add that to the hash
various command line arguments may need to go into the hash

[ ] in zig itself, cache executables built with a similar strategy. Additionally hash the list of dynamically linked libraries
[ ] in zig itself, keep cached objects in ~/.zig/cache/. Let's have a file ~/.zig/config which has an option where you can set the maximum size of the LRU cache, with some nice default like 100.
[ ] cache build.zig -> ./build executable using this strategy
[ ] for compiling c objects, use the feature of c compilers that computes dependencies to get a list of files that are dependencies, and then avoid unnecessarily recompiling C objects. Also put into the hash environment variables, other build options, as well as the modification date of the detected compiler, and its recursive dynamic libraries. You should be able to modify the build.zig file and then, provided that the same options were chosen for compiling a given C object, the step does not needlessly be repeated.

Just a note to ~/.zig/ directory. I would strongly recommend following XDG [1] [2] variables and only if they're not create and use this directory. On my system it looks e.g. like this:
$ env | grep XDG
XDG_PUBLICSHARE_DIR=/home/my_user/
XDG_CONFIG_HOME=/home/my_user/.config/
XDG_DOCUMENTS_DIR=/home/my_user/doc/
XDG_VTNR=1
XDG_DOWNLOAD_DIR=/home/my_user/
XDG_SESSION_ID=c1
XDG_VIDEOS_DIR=/home/my_user/video/
XDG_TEMPLATES_DIR=/home/my_user/
XDG_MUSIC_DIR=/home/my_user/audio/
XDG_DATA_DIRS=/usr/local/share/:/usr/share/:/home/my_user/.local/share/
XDG_PICTURES_DIR=/home/my_user/pics/
XDG_SEAT=seat0
XDG_CACHE_HOME=/home/my_user/.cache/
XDG_RUNTIME_DIR=/run/user/1000
XDG_DATA_HOME=/home/my_user/.local/share/
XDG_CONFIG_DIRS=/etc/xdg/
XDG_DESKTOP_DIR=/home/my_user/

Good call, using the XDG directories.

See the updated cache explanation here: https://github.com/zig-lang/zig/issues/298#issuecomment-297609316

Just to add a quick note here, zig doesn't quite follow XDG Base Directory Specification (XBDS) and the commenter who dumped a load of non-XBDS environments probably didn't realise it.
Instead of checking the XDG_DATA_HOME environment, zig hardcodes HOME/.local/share.  This is the required fall back if XDG_DATA_HOME is not set (and not an absolute path).
Lots of information about the XBDS here: https://wiki.archlinux.org/index.php/Xdg_support


Crash

Fabric 1.20.1
Crash sometimes when I open the chest by sneak + right click
crash-2024-03-10_19.53.13-server.txt

Are you using the 1.20.4 version of the Not Interested mod on 1.20.1? I can't guarantee that that mod it the reason of the crash, but it would be nice if you could check if the crash persists when you remove that mod.

You are right. I noticed it. I didn't have time to close the ticket. 😰


Unable to create port mapping with host-ip

Rancher versions:
rancher/server: 1.6.12
rancher/agent: 1.2.9
Steps to Reproduce:
Create a service with port-mapping of style [host-ip:host-port:container-port] Eg. <IP_ADDRESS>:8080:80
Results:  Failed to allocate instance [container:1i1450]: Bad instance [container:1i1450] in state [error]: Allocation failed: No healthy hosts meet the resource constraints: [<IP_ADDRESS>:8080:80/tcp portReservation, instanceReservation: 1
Expected: Port Mapping should only listen on specified Host-IP
The corresponding Docker CLI Comman "docker run ... -p <IP_ADDRESS>:8080:80 ..." works as expected.

Did you configure scheduler IPs? http://rancher.com/docs/rancher/v1.6/en/rancher-services/scheduler/#scheduling-onto-multiple-ips-of-a-single-host

That's it! Thank you for the right hint. Maybe one could add this hint to the Port Mapping section of the services docs (https://rancher.com/docs/rancher/latest/en/cattle/adding-services/#port-mapping) I was googling for hours, but found nothing relevant.


Stuck on node-gyp rebuild error on Ubuntu

Your version of node-gyp is pretty old.  What happens when you update it to the latest?

I am using<EMAIL_ADDRESS>because<EMAIL_ADDRESS>requires node version to be ">=0.10.28 <3".

The same issue after updating node-gyp.

You're still using node-gyp v2.0.1 in that last screenshot.

No follow-up, closing.


chore(circleci): change default branch to main

Codecov Report

Merging #18 (b208b9c) into master (ecc0e3f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   98.31%   98.31%
=======================================
  Files          24       24
  Lines         415      415
  Branches       50       50
=======================================
  Hits          408      408
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc0e3f...b208b9c. Read the comment docs.


Music: Added support for Clementine and Pragha

Description
Self explanatory.
Clementine is a Qt-based music player.
Pragha is the default Music Player in openSUSE XFCE.

LGTM :+1:


feat(dui2/rhino/revit): better reporting and previews

Description
This is a major PR that includes changes in:
Core

new ApplicationObject: this is scoped in notion and replaces the old ApplicationPlaceholderObject class. Breaking change Old files with saved streams will not deserialize correctly and would have to be re-saved

DUI2

moved Report to a tab in StreamEditView: this will display old report logging if no ApplicationObjects are saved in ProgressViewModel or display a list of ApplicationObjects if they are present
new connector bindings: PreviewSend, PreviewReceive, ResetDocument, and an updated SelectClientObjects
[ ] Todo: add copy report button that summarizes all ApplicationObjects

Rhino

Refactored Receive method quite heavily, including the FlattenCommitObject method to work with the new ApplicationObject for reporting
Implemented PreviewSend and PreviewReceive
Known issues:
[ ] previewing blocks and views, which are created during conversion. Should be resolved with new block helper method and skipping views.

Revit

IMPORTANT Refactored conversions to only return a single ApplicationObject instead of a List - the old nested elements should be stored in the converted and createdIds prop of the parent ApplicationObject
Updated report for receive
Known issues:
[ ] update report for send as well
[ ] check structural conversions as some of these didn't quite make sense with how they were handling the old ApplicationPlaceholderObject

ETABS/CSI
Known Issues:

[ ] report not scrollable
[ ] preview recieve crashes plugin

Other sharp connectors

added new connector bindings

Fixes #1447

Fixes #1448

Fixes #1449

Type of change

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Manual Tests: Rhino sends and receives
Requires more thorough testing to check for build errors and breaking behavior in:
[ ] Revit @teocomi
[x] Structural connectors @Reynold-Chan
[ ] Bentley

Docs

Will be updated ASAP

report not scrollable for ETABS

clicking preview for recieve in CSI causes connector to crash

looks good with the minor bugs

I fixed the old report not being scrollable, it was hidden behind the new one! ;)


Page Render Issue.

I have 13 pages long PDF which I am loading from Assets. Each time it takes a few seconds to fully render the first page. But as I scroll it's showing white pages and then slowly rendering pages one by one. What I want is the smooth scrolling between the pages.
I have tried adding enableAntialiasing(true) but it's not working.
I am new to this library so I am not sure if I am missing something obvious but a little help would be appreciated.
Thank you in advance.

same issue for me also...please help


fix images not beeing embeded into stream

The documentation of WriteGltfSceneToStream states that buffers and images will be embeded. When testing I had quite some trouble to teach the exporter to include my images (I am building the gltf (including images) from scratch for exporting). I noticed embedImages was set to false when calling WriteGltfSceneToStream. I assume this is a bug, so this PR fixes that.

Thanks! Merged!
TODO: Make WriteGltfSceneToStream API more flexible https://github.com/syoyo/tinygltf/issues/359


Can't get address from pubKey

link https://github.com/Bit-Wasp/bitcoin-php/issues/481
In my local regtest network
getrawtransaction bf6ea04bcb18121567bcaaebf8a60e7422cdb2d03b2c9153a93e42893408b1ee 2
{
  "hex": "02000000010000000000000000000000000000000000000000000000000000000000000000ffffffff035a0101ffffffff0300c2eb0b00000000232103fc674ba5d28299d87df7f4d176e3e01314dbfd59652c4169dd43b3e1d39e35baac80f0fa0200000000232103ae6efe9458f1d3bdd9a458b1970eabbdf9fcb1357e0dff2744a777ff43c391eeac0000000000000000266a24aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf900000000",
  "txid": "f8e371d717d103a690ce65a555e00d1d19000707089da2e1a4a847d9701c3c97",
  "hash": "f8e371d717d103a690ce65a555e00d1d19000707089da2e1a4a847d9701c3c97",
  "size": 189,
  "vsize": 189,
  "version": 2,
  "locktime": 0,
  "vin": [
    {
      "coinbase": "5a0101",
      "sequence":<PHONE_NUMBER>
    }
  ],
  "vout": [
    {
      "value": 2.00000000,
      "n": 0,
      "scriptPubKey": {
        "asm": "03fc674ba5d28299d87df7f4d176e3e01314dbfd59652c4169dd43b3e1d39e35ba OP_CHECKSIG",
        "hex": "2103fc674ba5d28299d87df7f4d176e3e01314dbfd59652c4169dd43b3e1d39e35baac",
        "reqSigs": 1,
        "type": "pubkey",
        "addresses": [
          "mydh6FosH4eWXpfdyJxssCPw7d54ekjFtg"
        ]
      }
    },
    {
      "value": 0.50000000,
      "n": 1,
      "scriptPubKey": {
        "asm": "03ae6efe9458f1d3bdd9a458b1970eabbdf9fcb1357e0dff2744a777ff43c391ee OP_CHECKSIG",
        "hex": "2103ae6efe9458f1d3bdd9a458b1970eabbdf9fcb1357e0dff2744a777ff43c391eeac",
        "reqSigs": 1,
        "type": "pubkey",
        "addresses": [
          "myRFm464BquEzYxuLyEEHh4F99A9gdVSgz"
        ]
      }
    },
    {
      "value": 0.00000000,
      "n": 2,
      "scriptPubKey": {
        "asm": "OP_RETURN aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf9",
        "hex": "6a24aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf9",
        "type": "nulldata"
      }
    }
  ],
  "blockhash": "09ddbb662bc40ba167ceb03787241e500e8a347735aee2b3498937d0627adae6",
  "confirmations": 93,
  "time":<PHONE_NUMBER>,
  "blocktime":<PHONE_NUMBER>
}

$transaction = TransactionFactory::fromHex($rawTransaction);
foreach ($transaction->getOutputs() as $n => $item) {
    $addrCreator = new AddressCreator();
    $address = $addrCreator->fromOutputScript($item->getScript());
}

Hi @wirwolf, thanks for the issue. I'm sorry I didn't get to the post you mentioned, it must have gotten lost in my notifications.
Not all output scripts have an address, hence the code fails on output 2 which is an OP_RETURN script. Use a try/catch, or rewrite your code to deal with not all outputs having addresses.

Closing this due to inactivity, as it seems the question has been answered. Feel free to reopen if not!


Edit .abcde.conf from web gui

Is your feature request related to a problem? Please describe.
A page for editing the abcde config would make things easier, as everything else can now be done from the web.
Describe the solution you'd like
n/a
Describe alternatives you've considered
n/a
Are you able to help code/implement this feature ?
Yes/No
Additional context

I was thinking about an accordion styling, similar to Radarr/Sonarr/etc. but obviously a much simpler version

https://imgur.com/a/oN9TR1h for preview images


Incompatibility issue

Hello,
The plugin is no longer compatible with the latest WebStorm build as per seen here:

Thank you for the time that you puts in this very useful plugin!
Cheers.

Hello! Please, remove the old plugin and install a new one by JetBrains https://plugins.jetbrains.com/plugin/24562-stimulus. It is a fork of the plugin and it has new features.

Oh I was writting a message about that. Sorry I didn't catch it before opening an issue.
Thank you for your answer, have a nice day!


Add Appveyor CI

Appveyor is a continuous Integration solution for Windows: https://www.appveyor.com
Follow this guide: http://david-grs.github.io/cpp-clang-travis-cmake-gtest-coveralls-appveyor/

Implemented on commits 426e1887a040a721adc9d33bcad94ce97b70e254 and 68c94846acd4030f8ef51dcd6048500d35d77506.
Heavily based on the work done by @benvenutti for the project https://github.com/benvenutti/hasm


Explained int main()

Return value of main function explained

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Looks good @Shubhamjainagrawal, congratulations on your first contribution to freeCodeCamp!


Rename the plugin jar that's published to JCenter/Maven Central

Currently the plugin jar is published as net.rdrei.android.buildtimetracker:gradle-plugin; the artifact name is too general to be useful. Perhaps it can be called build-time-tracker-plugin, same as the repo name.

I remember taking this naming convention from some other plugin. I'm a bit hesitant as those changes are quite disruptive. Is this breaking anything in particular for you?

is this breaking

Matter of fact, it is. We use common build.gradle files that are included on various builds. For backward compatibility, and since buildscript section is not included, but plugins are, we try to apply new plugins conditionally after checking the buildscript path. If a plugin is found on the path, we will apply it. The overly generic name of the build time tracker plugin is a problem because many other plugins also have the words gradle-plugin in their names, like the spring-boot-gradle-plugin for example.
If the name changes with a new version, people updating their biild files to pick up the new version should be able to update a few more characters to pick up the new name. It's not the end of je world.


chore: set anonymous to false on auth:login

https://coveord.atlassian.net/browse/CDX-743
Proposed changes
Once you run auth:token, the the anonymous is set to true which cause the UA events from not having a user ID (which is what Amplitude recommends).
However, nothing sets back the anonymous value back to false.

Testing

[x] Unit Tests:

[ ] Functionnal Tests:

[x] Manual Tests:

chore? I'd say fix? 🤔


Add hostname, record_type to DNS model

Hey @cccs-rs, could you add a comment next to the DNS hostname specifying: # This is the query hostname


allowing creation of dynamic properties in php8.2 to ignore deprecated warnings

@jamesiarmes would be great if you can merge this :D


Setting innodb_log_file_size causes server to crash with Percona Cluster

When using Percona Cluster, if ['percona']['server']['innodb_log_file_size'] is set, MySQL will crash after 'my.cnf' is built from the template with an error similar to this:

InnoDB: Error: log file ./ib_logfile0 is of different size 0 5242880 bytes
InnoDB: than specified in the .cnf file 0 8388608 bytes!

+1
I'm running into this as well. On a fresh install it seems to start up with default options, finish the provisioning with the incorrect innodb settings, and then won't run past the first restart when the correct settings get tossed in my.cnf.  I'm still tracing down what's going on, but this is definitely an issue.
I'm using percona-5.5 on Ubuntu 14.04 and 12.04 btw.

Closing due to inactivity.
If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


Property such as "ChildHorizontalAlignment" is not work in run time,when I use custom controls

AutoGrid.Children‘s count is 0.

public AutoGrid()
{
    Loaded += AutoGrid_Loaded;
}

private void AutoGrid_Loaded(object sender, RoutedEventArgs e)
{
    Loaded -= AutoGrid_Loaded;
    if (Children.Count == 0)
    {
        return;
    }
    foreach (UIElement elem in Children)
    {
        SetChildLayout(elem);
    }
}
    void SetChildLayout(UIElement child)
    {
        if (ChildMargin.HasValue)
        {
            child.SetValue(ChildMarginProperty, ChildMargin);
        }

        if (ChildHorizontalAlignment.HasValue)
        {
            child.SetValue(HorizontalAlignmentProperty, ChildHorizontalAlignment);
        }

        if (ChildVerticalAlignment.HasValue)
        {
            child.SetValue(VerticalAlignmentProperty, ChildVerticalAlignment);
        }
    }


Fix minor things

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4e86536) 89.80% compared to head (6962829) 89.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   89.80%   89.80%
=======================================
  Files          10       10
  Lines         206      206
  Branches       22       22
=======================================
  Hits          185      185
  Misses         18       18
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


deepspeed-chat: handle overflow for bf16_optimizer

DeepSpeed's bf16_optimizer does not have an overflow attribute. This is ok since bf16 dtype has same range as fp32 and is not expected to overflow.
Therefore, for bf16, always return no overflow.
Change-Id: I66a2204f3af81e52e7fa8d024afafdbbc7494327

The formatting error is not due to this commit.
"applications/DeepSpeed-Chat/training/utils/ds_utils.py:6:1: F401 'torch' imported but unused"

The formatting error is not due to this commit. "applications/DeepSpeed-Chat/training/utils/ds_utils.py:6:1: F401 'torch' imported but unused"

Yes, you are correct. I actually have a pending PR to take of this.


Added customizable header  formats

I was just about to add this same feature. Any idea on the status of merging these?

@volker-holz the names for the properties don't seem to match the view they are used in. I would expect the DayView to use daysHeaderFormat, instead it uses minutesHeaderFormat. The ultimate values seem correct but the names of the variables don't match the views they are used in.

@shaunbowe that seemed counter-intuitive for me too in the first place - but if you take a look at the provider though you will notice that the DayView uses a provider variable named hoursFormat - I wanted the [x]HeaderFormat to have a somehow corresponding name in the provider, that's why I picked "hoursHeaderFormat". You might translate it to "the format of the header when picking hours" Do you get what I'm out for? Does it make sense that way?

It seems strange still but I agree it is consistent with the original code and changing it would have been more confusing.


Need a newer version of pims

@danielballan what version of pims can you do from pims import pipeline?

I'm getting an error on the csxtools build

===== testing package: csxtools-0.1.2-np110py34_0 =====
import: 'csxtools'
/opt/conda/envs/_test/lib/python3.4/site-packages/matplotlib/font_manager.py:273: UserWarning: Matplotlib is building the font cache using fc-list. This may take a moment.
  warnings.warn('Matplotlib is building the font cache using fc-list. This may take a moment.')
/opt/conda/envs/_test/lib/python3.4/site-packages/matplotlib/font_manager.py:273: UserWarning: Matplotlib is building the font cache using fc-list. This may take a moment.
  warnings.warn('Matplotlib is building the font cache using fc-list. This may take a moment.')
Traceback (most recent call last):
  File "/opt/conda/conda-bld/test-tmp_dir/run_test.py", line 25, in <module>
    import csxtools
  File "/opt/conda/envs/_test/lib/python3.4/site-packages/csxtools/__init__.py", line 8, in <module>
    from .utils import get_fastccd_images
  File "/opt/conda/envs/_test/lib/python3.4/site-packages/csxtools/utils.py", line 4, in <module>
    from pims import pipeline
ImportError: cannot import name 'pipeline'
TESTS FAILED: csxtools-0.1.2-np110py34_0

no rush, im done for the evening and will check again tomorrow, thanks!

Latest tag 0.3.3 should work.
Sent from Outlook Mobilehttps://aka.ms/qtex0l
On Fri, Feb 19, 2016 at 4:24 PM -0800, "Eric Dill" <notifications<EMAIL_ADDRESS>wrote:
===== testing package: csxtools-0.1.2-np110py34_0 ===== import: 'csxtools' /opt/conda/envs/_test/lib/python3.4/site-packages/matplotlib/font_manager.py:273: UserWarning: Matplotlib is building the font cache using fc-list. This may take a moment.
warnings.warn('Matplotlib is building the font cache using fc-list. This may take a moment.') /opt/conda/envs/_test/lib/python3.4/site-packages/matplotlib/font_manager.py:273: UserWarning: Matplotlib is building the font cache using fc-list. This may take
a moment. warnings.warn('Matplotlib is building the font cache using fc-list. This may take a moment.') Traceback (most recent call last): File "/opt/conda/conda-bld/test-tmp_dir/run_test.py", line 25, in  import csxtools File "/opt/conda/envs/_test/lib/python3.4/site-packages/csxtools/init.py",
line 8, in  from .utils import get_fastccd_images File "/opt/conda/envs/_test/lib/python3.4/site-packages/csxtools/utils.py", line 4, in  from pims import pipeline ImportError: cannot import name 'pipeline' TESTS FAILED: csxtools-0.1.2-np110py34_0
—
Reply to this email directly or view it on GitHubhttps://github.com/NSLS-II/auto-build-tagged-recipes/issues/7#issuecomment-186464568.

Thanks @danielballan . I have added the pims 0.3.3 recipe to this repo and added pims >=0.3.3 in csxtools. cc @stuwilkins


Feature request - Allow API listeners to take a list of IP addresses

I run frigate in a docker container that is attached to both an IPvlan and a bridge network. The bridge network IP is <IP_ADDRESS>
However the way docker works with IPvlans is that even if you don't put ports in your docker compose, if the service (container) binds to a port on all IP addresses * or <IP_ADDRESS> it will be exposed on the ipvlan ip addresses as well. The only way to fix that is to only allow the service to bind to specific IP addresses rather than all.
Frigate does the same thing so I had to modify the nginx file to listen on the bridge network IP <IP_ADDRESS>:5000 and <IP_ADDRESS>:5000 but go2rtc doesn't let me do the same which means I'm exposing 1984 to my isolated camera IPvlan.
Frigate nginx
server {
     listen <IP_ADDRESS>:5000;
     listen <IP_ADDRESS>:5000;

What I'm looking for is to do this with go2rtc
api:
  listen:
  - <IP_ADDRESS>:1984
  - <IP_ADDRESS>:1984
  origin: '*'

I don't see the point of not using <IP_ADDRESS>. It's just a cosmetic tweak

What I'm looking for is to do this with go2rtc
api:
  listen:
  - <IP_ADDRESS>:1984
  - <IP_ADDRESS>:1984
  origin: '*'

the solution is unix sockets:
api:
  listen: <IP_ADDRESS>:1984
  unix_listen: "/tmp/go2rtc.sock"  # default "", unix socket listener for API

and in frigate's nginx config
upstream go2rtc {
         server unix:/tmp/go2rtc.sock;
}

(look into my PR https://github.com/blakeblackshear/frigate/pull/8693)


RUM-7489 Handle readOnly additionalProperties

What does this PR do?
Make sure that the readOnly setting on additional properties is taken into account when converting Json Schema into a Kotlin data class.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.17%. Comparing base (4923861) to head (8d6434a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2423      +/-   ##
===========================================
+ Coverage    70.13%   70.17%   +0.04%
===========================================
  Files          769      769
  Lines        28530    28530
  Branches      4782     4782
===========================================
+ Hits         20007    20019      +12
+ Misses        7179     7169      -10
+ Partials      1344     1342       -2

Files with missing lines
Coverage Δ

.../android/rum/internal/domain/scope/RumViewScope.kt
94.50% <ø> (ø)

... and 32 files with indirect coverage changes


Unable to update the advanced config fields

Unable to adjust the configuration fields
When trying to adjust these fields, the input is not received.  The field does not change, and the console shows the following message:
[Violation] 'input' handler took 243ms
Steps to Reproduce
Run the nerdpack, select the configuration menu option, and attempt to change a field value
NOTE: # ( Please be as specific as possible. )
Expected Behaviour
The fields would show the changed value and upon exit/save update the multiplier, inclusion period etc.

Relevant Logs / Console output
[Violation] 'input' handler took 198ms
[Violation] 'input' handler took 194ms
[Violation] 'input' handler took 187ms
[Violation] 'input' handler took 195ms
[Violation] 'input' handler took 217ms
[Violation] 'input' handler took 186ms
[Violation] 'input' handler took 186ms
[Violation] 'input' handler took 184ms
[Violation] 'input' handler took 241ms
[Violation] 'input' handler took 221ms
[Violation] 'input' handler took 216ms
[Violation] 'input' handler took 253ms
[Violation] 'input' handler took 230ms
[Violation] 'input' handler took 244ms
[Violation] 'input' handler took 244ms
[Violation] 'input' handler took 260ms
[Violation] 'input' handler took 243ms
[Violation] 'input' handler took 248ms
[Violation] 'input' handler took 235ms
[Violation] 'input' handler took 234ms
[Violation] 'input' handler took 254ms
[Violation] 'input' handler took 238ms

Your Environment

NR1 CLI version used:
$ nr1 --version
@datanerd/nr1/1.22.2 darwin-x64 node-v10.16.3

Browser name and version:
Chrome Version 81.0.4044.122 (Official Build) (64-bit)
Firefox 75.0 (64-bit)

Operating System and version:
MacOS Catalina

Additional context

@rjusselrelic thanks for raising.
Just debugged the issue, it has broke on this PR https://github.com/newrelic/nr1-cloud-optimize/pull/40
cc @tangollama @devfreddy @danielgolden

:tada: This issue has been resolved in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cupcake website page creation - Resources category

chsanche created the following on Sep 24:

User Story

As an IBM.com page creator

I need to: know where to find resources

so that I can: do my day to day work efficiently.

Additional information

Cupcake website page development priority can be viewed via #1664.
The Resources page on the Carbon Design website can be viewed here
We are going to combine all the resources into one page for the Cupcake version.

Task

Collaborate with Wonil and Jeff for the content creation.

Acceptance criteria

[x] Content and design created and reviewed with the stream lead, the developer and Wonil.
[ ] Shared with the Carbon and IDL team for feedback.
[ ] Content and design accepted by Wonil and Linda.
[ ] Create the dev. issue for coding as the next step.

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1759

On Oct 01, chsanche commented:
@Jeff-Chew @Benjamin-Hansen1 @Wonil-Suh1
Please take a look at the content for the Resources page below and let me know if anything is missed.

On Oct 10, Jeff-Chew commented:
We will have storybook for patterns, as well as JSDoc for services and utilities.
Is it confusing to add the v19 repo here? I think that should stay with the old standards site.

On Oct 11, chsanche commented:
@linda-carotenuto @Wonil-Suh1
Resources Page update completed.

v19a Github repo card deleted.
IBM.com Pattern React Storybook (experimental) card added.
IBM Research card added.
Slack logo SVG on the cards updated.

On Oct 10, linda-carotenuto commented:
I agree...don't need V19 repo here.

Added the IBM style guideline card (see request via issue 746 for detail) to the Resources page.
Final design:


Generate rust-toolchain.toml at configure time

According to kernel configuration, generate a dedicated rust-toolchain.toml file in order to build rust uapi with the exact same option than c code (i.e. target, FPU, PIC, etc.).

#80 duplicate


Perminssions and Tokens

Adding Authentications

Basic Authentications Assigned Using:
'DEFAULT_AUTHENTICATION_CLASSES','DEFAULT_PERMISSION_CLASSES'

Using Token Keys to Each User

Allowing only Author of Post to permit Actions, by using IsAuthorOrReadOnly class inherited from rest_framework BasePermission Class.


JSON Patch updates fail when column names have slashes (/) or tildes (~)

Describe the bug
When applying a JSON patch com.linkedin.metadata.aspect.patch.template.TemplateUtil#populateTopLevelKeys uses a JsonPatch as a template for a node to transform.
JsonPatch objects will have / and ~ encoded as ~1 and ~0 respectively. This needs to be converted back when creating an object based on the paths of a JSON Patch
To Reproduce
Steps to reproduce the behavior:

Trigger a metadata change that will apply a patch to a column name with a / in it:

{\"op\": \"add\", \"path\": \"/fineGrainedLineages/NONE/urn:li:schemaField:(urn:li:dataset:(urn:li:dataPlatform:snowflake,my_database.my_schema.my_table,PROD),slash is ~1)", \"value\": {\"confidenceScore\": 1.0}}

Run ingestion pipeline
See error

Expected behavior
The "target" object should have a key with the slash unescaped so it looks something like this:
{"/fineGrainedLineages/NONE/urn:li:schemaField:(urn:li:dataset:(urn:li:dataPlatform:snowflake,my_database.my_schema.my_table,PROD),slash is /)" : {}}

However, the target retains the encoded / so it looks like this:

{"/fineGrainedLineages/NONE/urn:li:schemaField:(urn:li:dataset:(urn:li:dataPlatform:snowflake,my_database.my_schema.my_table,PROD),slash is ~1)" : {}}

However, the JSON Pointer logic correctly tries to find:
"/fineGrainedLineages/NONE/urn:li:schemaField:(urn:li:dataset:(urn:li:dataPlatform:snowflake,my_database.my_schema.my_table,PROD),slash is /)"
Additional context
This logic would fix it
public static JsonNode populateTopLevelKeys(JsonNode transformedNode, JsonPatch jsonPatch) {
        JsonNode transformedNodeClone = transformedNode.deepCopy();
        List<Pair<PatchOperationType, String>> paths = getPaths(jsonPatch);
        for (Pair<PatchOperationType, String> operationPath : paths) {
            String[] keys = (String[]) Arrays.stream(
                            operationPath.getSecond().split("/"))
                    .map(k -> k.replace("~1", "/").replace("~0", "~")).toArray();

Here is the PR with the fix
https://github.com/datahub-project/datahub/pull/10717


Compatibility with python 3.x

As I tried this package I could not use it with python 3.5 on windows. So I just added 3 lines to Sphero.py and now it works.
# ... other imports
import sys
if sys.version_info > (3,):
    buffer = bytes
# ...

basically this replaces all uses of buffer with bytes, due to buffer being unsupported in python 3.x
I don't know if there are other issues, but this worked for me (I use pybluez 0.22)

Merged in the pull request.


Use ReactUSWdS CTA instead of shared/Alert onRemove prop

Use ReactUSWdS CTA instead of shared/Alert onRemove prop
Summary
For MB-16271 (https://github.com/transcom/mymove/pull/11159) we added in these alerts, however I used the shared alert because I noticed it had an inbuilt onRemove prop (which no other part of the app was using at the time). I didn't know about the ReactUSWDS cta prop, which we already use elsewhere (example).
This PR makes use of the ReactUSWDS Alert and removes dependence on the (I assume) legacy shared alert component
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Use the test harness to generate an HHGMoveWithAddressChangeRequest, take note of the move code/locator
Login to office as TOO
Go to the move code/locator from step 1
Click edit shipment
Review the request
Click submit
Note the success modal

Screenshots
https://github.com/transcom/mymove/assets/15805554/8698a407-564d-49ca-8475-752c3e3ce8f8

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against d5dcb5363f4f084805831817b2ef8e415b5ebe5f


Finding selectors for Jira?

Howdy. This works great in Confluence but I can't figure out what selector I need to use for Jira. I'm not a web person, but inspecting a page where I added mermaid, I found div.code.panel, div.codecontent.panelcontent, div.user-content-block, and div.pre.code-java (I tried adding it as a default code block, which I guess is java). How would I try those in the selector? I tried "pre > code-java" and "div.user-content-block > p", but neither worked.
Here's what that part looks like in the inspector...

 == $0
"```mermaid flowchart LR; A["
(and then the mermaid lines)
(and then these lines exiting out of that code block, so we're in the main user-content-block)

== $0
"```mermaid"
(and then another block of mermaid, this time not in a code block)

jira and confluence code blocks cannot select the mermaid language, so can only use None or PlainText instead.

Perhaps you can try adding the selector code.language-text to the atlassian.net domain.

Then refresh the page, you can see that it has taken effect.

Using the above configuration, it works fine in Confluence, but there seems to be a styling issue in Jira's boards.

Thanks for looking.  Oddly, for Confluence what I figured out what that using markdown code blocks works, using "pre > code". (That's pretty easy to set up: "{", then "markd", then [enter]).  What you provided doesn't work on our Confluence (self-hosted?); I tried that, tried td.code, tried div.codeContent. So there are options for confluence, but yeah, Jira is a PITA. I appreciate you looking!

Using the above configuration, it works fine in Confluence, but there seems to be a styling issue in Jira's boards.使用上述配置，它在 Confluence 中工作正常，但 Jira 的面板中似乎存在样式问题。

The newly released version, v1.4.4, added an experimental feature called Sandbox mode, which can solve the styling issues of the open-source version of Jira. (You can enable it through the settings page.)

For a self-hosted Jira, the required selector configuration may vary depending on the version. You can use Chrome Developer Tools to locate the specific DOM element and find the corresponding selector.

GOT IT!
So when I create a code block in our Jira, the selector says pre.code-java.  I created a selector "pre.code-java" for our Jira site, and it's more finicky than I expected (the block can ONLY contain "graph LR" and "A --> B", with that precise spacing), but it works.
And I just found a weird difference in how I'm doing it. Originally because I misread things (how the three tick marks work).
On Confluence, I do this inside a markdown block, and it works:
[markdown block begins]
graph LR
A-->B

[markdown block ends]
(and if I do it without the three tick marks and mermaid, it doesn't resolve)
but in Jira, I have to do JUST:
graph LR
A --> B

Jira doesn't work:
graph LR
A-->B

Jira doesn't work:
mermaid
graph LR
A --> B
Jira works:
graph LR
A --> B

It seems that your problem has been solved. If you still have problems, you can reopen it.


What needs to be done to get integrate long_callbacks with dash-extensions?

Curious to see what you need to do to get long_callbacks working with dash-extensions and I'm happy to pitch in if you'd like. Also I love this library and have used it all the time these past few years!

Thanks! I am working on a major update that adds tests and interactive documentation, so I haven't looket at it yet. But I imagine creating an intermediate layer, similar to the one implemented for callbacks and clientside callbacks.

Gotcha sounds good, I'll have to work on better understanding how your intermediate layer works for the regular callbacks.

The update has now been migrated into master. Hence, I will expect the structure to remain more stable from now on :)

Ok sounds good thanks! I'll update my master then

I think this can be closed now that long_callback is being deprecated in favor of background callbacks: https://dash.plotly.com/background-callbacks. This has worked for me in conjunction with dash-extensions.


SetOutput to stream doesn't work (3.4.0-alpha1)

Description
We're attempting to capture the output to a stream. It is never called.
*Note: This used to work in the Iron Python 2 version - we're using the same codebase.
Steps to Reproduce
This example will demonstrate how the stdout isn't being captured by the stream assignment. The iron python script is running in a thread in a loop printing to the stdout. The assignment to the SetOutput stream is set but the stream is never written to.
     public class StreamWriteEvent : MemoryStream {

      public event EventHandler<string> OnNewText;

      public override void Write(byte[] buffer, int offset, int count) {

        OnNewText?.Invoke(this, Encoding.Default.GetString(buffer, offset, count));

        base.Write(buffer, offset, count);
      }

      public override Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken) {

        OnNewText?.Invoke(this, Encoding.Default.GetString(buffer, offset, count));

        return base.WriteAsync(buffer, offset, count, cancellationToken);
      }

      public override void WriteByte(byte value) {

        OnNewText?.Invoke(this, value.ToString());

        base.WriteByte(value);
      }

      public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count, AsyncCallback callback, object state) {

        OnNewText?.Invoke(this, Encoding.Default.GetString(buffer, offset, count));

        return base.BeginWrite(buffer, offset, count, callback, state);
      }
    }

    ScriptEngine _engine;
    ScriptScope _scope;

    // Run a python script in a new thread
    private void button2_Click(object sender, EventArgs e) {

      Thread ts = new Thread(runScript);
      ts.Start();
    }

    // This thread is running the python script
    void runScript() {

      var streamWriter = new StreamWriteEvent();
      streamWriter.OnNewText += StreamWriter_OnNewText;

      _engine = IronPython.Hosting.Python.CreateEngine();

      _engine.Runtime.IO.SetErrorOutput(streamWriter, Encoding.ASCII);
      _engine.Runtime.IO.SetOutput(streamWriter, Encoding.ASCII);

      _scope = _engine.CreateScope();

      // Run a script that loops
      // We will test both capturing the output stream & the Shutdown command to stop the running script
      var sc = _engine.CreateScriptSourceFromString(@"
while True:
  print('This should output something')
");

      var ret = sc.Execute(_scope);

      // This doesn't do anything. It doesn't stop the running script.
      Console.WriteLine("Shut down");
    }

    private void StreamWriter_OnNewText(object sender, string e) {

      // This should output but never does
      Console.WriteLine("From steam writer" + e);
    }

    // This is the button that should stop the running python script
    private void button3_Click(object sender, EventArgs e) {

      Console.WriteLine("Shutting down...");

      // This shutdown command doesn't work. The script will continue running.
      _scope.Engine.Runtime.Shutdown();
    }

Expected behavior:
The stream contains the output of the print() statement
Actual behavior:
No output from print() statements in the stream
Versions
3.4.0-alpha1 for .Net Framework 4.7.2 from nuget

This is probably the same as https://github.com/IronLanguages/ironpython3/issues/961. A potential workaround is noted in that issue:
var runtime = IronPython.Hosting.Python.CreateRuntime();

runtime.IO.SetErrorOutput(streamWriter, Encoding.ASCII);
runtime.IO.SetOutput(streamWriter, Encoding.ASCII);

_engine = IronPython.Hosting.Python.GetEngine(runtime);

Thank you - that works. It's a strange workaround but it works :D

Thank you - that works.   NB

Hi, I am using IronPython 3.4.0 and having a same problem.
I am trying to redirect outputs to std IO. The default behavior does not work. So, I tried to redirect it explicitly, but it still doesn't work.
Then I found this github issue and wanted to try the workaround.
But there is not an overload of SetOutput() that taking TextWriter as its first parameter.
Is it removed?

@KanaHayama There is no overload with TextWriter as the first parameter, the streamWriter in the workaround is a Stream. If you need to use a TextWriter you can try wrapping it as described in the documentation on redirecting output.


Model config setting for SerializeAsAny

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
I understand the reason serialisation was changed from v1 to not serialise as "duck types", and I find the solution of using SerializeAsAny ok, but I have a large project where I always need it wherever I have models as field types for other models.
Would it be possible to add a setting to model_config to imply SerializeAsAny automatically?
Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[X] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[X] Model Config
[X] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Hi @berzi,
Thanks for your question. 2 potential solutions:

Create a subclass of ConfigDict where SerializeAsAny is always True, then use that as the config for all of your models.
Create a subclass of BaseModel with your desired config + use that as the parent class for all of your models for which you need these settings.

Let me know if neither of these work for you and we can figure out a better solution! 😄

Hi @berzi,
Thanks for your question. 2 potential solutions:

Create a subclass of ConfigDict where SerializeAsAny is always True, then use that as the config for all of your models.
Create a subclass of BaseModel with your desired config + use that as the parent class for all of your models for which you need these settings.

Let me know if neither of these work for you and we can figure out a better solution! 😄

ConfigDict doesn't have SerializeAsAny, that's exactly what my proposal is. Right now it can only be applied to individual fields, so there's no way to have as default.

Ah, thanks for following up. I misunderstood your original question. We've had a few requests for this already, and we have an open issue re this discussion: #6423.
I'm going to close this in favor of continuing discussion on the mentioned issue 😃


Update Theme: Super Url Bar

Added Dropdown with 5 options for Blur Intensity (https://github.com/JLBlk/Zen-Themes/issues/24)
Added Custom Colors for the Url Bar Background#
Added option to show hidden icons on hover (https://github.com/JLBlk/Zen-Themes/issues/25)
Fixed Issue where 1px corners of browser are grey
New Image
Increased Version to 1.3.0

Pls don't merge yet, something doesn't seem to be working correctly all of the sudden :(


Create grading sheets as part of panel pack

Background
User Story
Feature(s) Description

[ ] Feature

Acceptance Criteria
Definition of Done

[ ] User stories/acceptance criteria met
[ ] Internal reviews passed (feedback actioned)
[ ] User testing passed
[ ] Relevant technical documentation updated
[ ] User guidance updated
[ ] Deployed and merged without errors

User Testing Steps
Specify for users what is being tested (but not how to test it.)

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @HalcyonJAC @tomlovesgithub @warrensearle

Please add your planning poker estimate with Zenhub @KoWeiJAC

@drieJAC let's pair on this ticket!
Just to clarify this is a digital-platform task, no UI is needed as part of this ticket.
In the first iteration (spike) please could you look at creating a Sheet on Google Drive (as part of the panel pack export) and see if you can create fields/columns which restrict what values can be entered (I guess like a dropdown). For example we would like to have columns on the sheet with the following input types:

Grade (only allow A, B, C or D as input value)
Yes / No (only allow Yes or No as input value)
Pass / Fail (only allow Pass or Fail as input value)
Level (only allow None, Basic, Medium, High as input value)

For the Document we create on google drive we cheat slightly by creating HTML and then converting this to a Google Doc. In this instance I think we'll need to do things properly and use the Drive API (or Sheets API?) so that we can (hopefully) define the input values as described above.
Let me know when you are done with the above as at that point I should have a defined data model for you to use. Essentially there will be an array of columns where each column has a ref and a type, for example:
[
  { ref: 'PQE', type: 'grade' },
  { ref: 'Welsh questions', type: 'level' },
]


Working with local ember-cli

I can't use this tasks with ember installed to './node_modules/ember-cli/bin/ember'
I use capistrano nvm and and capistrano npm gems.
[c8c7900c] Command: cd /u/apps/Example/releases/20150819141119/frontend && ( PATH=/opt/rbenv/shims:$PATH NODE_VERSION=v0.12.7 /usr/bin/env ./node_modules/ember-cli/bin/ember build --environment production --output-path dist/ )
DEBUG [c8c7900c] 	/usr/bin/env: node: No such file or directory
(Backtrace restricted to imported tasks)
cap aborted!
SSHKit::Runner::ExecuteError: Exception while executing as<EMAIL_ADDRESS>./node_modules/ember-cli/bin/ember exit status: 127
./node_modules/ember-cli/bin/ember stdout: /usr/bin/env: node: No such file or directory
./node_modules/ember-cli/bin/ember stderr: Nothing written

But it works with global ember cli (installed to my nvm directory):
set :nvm_map_bins, %w{node npm bower ember}
set :ember_cli_binary, :ember

Hey,
I somehow missed this issue. Do you need any help or is the solution you wrote above good enough for you? I haven't had any trouble with using binaries straight from node_modules, and we don't have ember-cli installed globally on our servers, so I've never run into this issue.
Cheers!

@mamut I've just installed node globally (previously it was in nvm directory only).


Remove merge block processor as block rewards are already disabled in protocol schedule

PR description
Remove the merge block processor as block rewards are already disabled in the protocol schedule by using skipZeroBlockRewards=false and blockreward=0.
Fixed Issue(s)

Part of #5354

Testing that syncing still works

[ ] Bonsai snapsync on Goerli
[ ] Bonsai snapsync on Sepolia
[ ] Bonsai snapsync on Mainnet


adding cross platform feature

Can we add cross platform feature to this project? great and useful charts

what you mean by cross platform feature?

cross platform means that we can add frameworks that make it possible to deploy these charts on both iOS and android!

This is already cross platform

You can look at REAMDME and it indeed tells you there is android portion.

Literally the very first sentence of the project description (which you can find on the starting page of ios-charts) states this!
Amazing, really...

I guess this can be closed then.
So much clutter in the bug reports here...

Yes it's a lot of clutter. My personal life stole some time from Charts ;-)
I'll do some order here soon, along with some bug fixes a features


Add link to documentation

@myronmarston @JonRowe To make it easier for others to find the matcher protocol.

Thanks!


Bugfix: Add missing '/' when constructing the Autosave S3 put path

This issue prevented the autosave to push to s3 since it was pushing to the wrong path.

Codecov Report

Merging #538 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #538   +/-   ##
=======================================
  Coverage   38.06%   38.06%
=======================================
  Files          46       46
  Lines        3145     3145
=======================================
  Hits         1197     1197
  Misses       1752     1752
  Partials      196      196

Impacted Files
Coverage Δ

core/controlplane/cluster/cluster.go
43.33% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9038a0e...5c2ca23. Read the comment docs.

@jollinshead LGTM. Thanks for the fix 👍


RTD replaces branch/release with branch-release and 404's "Edit on Github" URL to docs

Details
RTD adds a broken "Edit on Github" URL to docs.
Repro:

https://netapp-trident.readthedocs.io/en/stable-v18.01/
click on "Edit on Github".

Project URL: https://github.com/NetApp/trident
Build URL (if applicable): https://github.com/NetApp/trident/releases/tag/v18.01.0
Read the Docs username (if applicable): netapp-trident (https://netapp-trident.readthedocs.io/en/stable-v18.01/)

Expected Result
Edit on Github should not be broken.
Actual Result
RTD replaces our stable/v18.01 with stable-v18.01 which breaks Edit on Github URLs (and possibly some other links to the repo).
(Ref: https://github.com/NetApp/trident/issues/90)

Thanks for the report. This is an already known bug and it's addressed at #1989 and a PR already merged at #3545 so, this should be solved in the next deploy.

Thanks. I did search open issues but not the closed ones :-)


TST: Remove test for lookup of future contract by symbol.

The lookup of future contract by individual symbol is a constraint on
incoming changes of changing how the asset finder stores data.
(i.e. the asset finder is changing so that there are separate tables for
both futures and equities.)
Since this lookup is not yet fully supported, we can add it back in on
top of the new asset finder.
Other Notes
@jfkirk this is the small reduction in features of the asset finder that we discussed in person. It should be possible to add the lookup back in, but since symbol('AFUTURE') is not yet used, it was easier to do the port of the underlying engine without supporting the feature, but shouldn't be too much work to add back in once that port is finished.

Makes sense to me. I expect that, at some juncture, we will want to support future look-up by symbol, but it is not critical ATM.
:+1:

Thanks for the quick review! Merging.


Adds 'marketplace.gcr.io' as a default registry.

marketplace.gcr.io is an alias used by Google Cloud Launcher, and it requires authentication.

Given that there's a non-zero performance cost to adding new default registries, I'm wondering if it might be a better idea to allow for greater configuration during setup. Currently, users can use d-c-gcr to authenticate to arbitrary registries by manually adding the entry to the docker config and running docker-credential-gcr config --default-to-gcr-access-token.


No 'main' module

I've installed and linked the repo, and the code builds successfully but when importing it I'm met with an error indicating there's no main module. This is likely due to no index.js or similar file for the import to land on.
This is the error:
error: bundling failed: Error: While trying to resolve module `react-native-twitter-signin` from file `/Users/danfein/Desktop/native/components/Authentication/index.js`, the package `/Users/danfein/Desktop/native/node_modules/react-native-twitter-signin/package.json` was successfully found. However, this package itself specifies a `main` module field that could not be resolved (`/Users/danfein/Desktop/native/node_modules/react-native-twitter-signin/index`. Indeed, none of these files exist:

  * `/Users/danfein/Desktop/native/node_modules/react-native-twitter-signin/index(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)`
  * `/Users/danfein/Desktop/native/node_modules/react-native-twitter-signin/index/index(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)`
    at ResolutionRequest.resolveDependency (/Users/danfein/Desktop/native/node_modules/@react-native-community/cli/node_modules/metro/src/node-haste/DependencyGraph/ResolutionRequest.js:65:15)
    at DependencyGraph.resolveDependency (/Users/danfein/Desktop/native/node_modules/@react-native-community/cli/node_modules/metro/src/node-haste/DependencyGraph.js:283:16)
    at Object.resolve (/Users/danfein/Desktop/native/node_modules/@react-native-community/cli/node_modules/metro/src/lib/transformHelpers.js:261:42)
    at dependencies.map.result (/Users/danfein/Desktop/native/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:399:31)
    at Array.map (<anonymous>)
    at resolveDependencies (/Users/danfein/Desktop/native/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:396:18)
    at /Users/danfein/Desktop/native/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:269:33
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/danfein/Desktop/native/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:87:24)
    at _next (/Users/danfein/Desktop/native/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:107:9)

Any ideas to remediate?

Resolved by removing node_modules and running npm install, and then closing metro and reopening.


Document Github access token scopes required for release

I had no scopes applied and the release failed:
 ✖ Generate GitHub Release
   → Not Found (404)
   Publish to npm
Not Found (404)
GitHubError: Not Found (404)
    at stream.catch.then.data (/Users/alan/Code/protocol-labs/interface-ipfs-core/node_modules/got/index.js:182:13)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Applying all scopes fixed this, but it would be good to not have to create an access token that has access to everything.

dupe of https://github.com/ipfs/aegir/issues/238


libmkl_intel_lp64.so: cannot open shared object file: No such file or directory

I just did conda install gmt into a Python 3 environment on an openSUSE Leap 42.1 (x86_64) system:
(IOOS3) rsignell@gamone:~> conda list gmt
# packages in environment at /home/rsignell/miniconda3/envs/IOOS3:
#
gmt                       5.3.3                         0    conda-forge

When when I try to run a GMT command, I get:
(IOOS3) rsignell@gamone:~> xyz2grd --help
xyz2grd: error while loading shared libraries: libmkl_intel_lp64.so: cannot open shared object file: No such file or directory

gmt is linking to mkl because defatuls numpy was pulled during the build. The workaround for now is to force install mkl (and it should also change your numpy but it did not in my case resulting in a broken numpy :weary:).
The real solution is to avoid the linkage on the build so gmt can work with both versions of numpy installed. My next PR should do that.


[BUG] Exporting a map generates an error

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Whenever I export a map, no matter the file type, I get a 400 error.

Browsers

[X] Chrome
[ ] Safari
[ ] Firefox
[ ] Brave
[ ] Microsoft Edge
[ ] Internet Explorer
[ ] Other

Reproduction steps
No response
Developer console logs
No response
Additional information
No response

Thanks for the report. I can reproduce and will look in to it.

@tiger1974 The servers are load balanced and your session is sticky. You got stuck to the a machine that doesn't have your exported map. One of the others has it. :/ You'll be stuck to that machine for 5 minutes. After 5 minutes of no connections, you'll get load balanced again and have a chance to get the right machine containing the file. This is bad.
We're exploring solutions with better odds, like 100%, as this is affecting printing on every website we have.

this has been solved.


filamat: generate spirv 1.0 rather than spirv 1.3

Since we are still on Vulkan 1.0, we cannot use SPIR-V 1.3.
If we try to do so, this error is generated:
Invalid SPIR-V binary version 1.3 for target environment SPIR-V 1.0

In non-optimized builds, we were already generating spirv 1.0, but
when we enabled the shader optimizer, we generated spirv 1.3.
This bug has actually been around forever, but we did not notice because
we were only invoking the optimizer in release builds, which does not
enable validation.
We cannot upgrade to Vulkan 1.1 because the latest LunarG SDK for macOS
does not support it.

Don't we need 1.1 for external memory (for camera streams)?

Don't we need 1.1 for external memory (for camera streams)?

Which raises the question of how many devices support only 1.0?

This PR does not change the version of Vulkan that we use.  We use Vulkan 1.0, and always have.  (Yes, I think we should consider upgrading to Vulkan 1.1 after the next release of the LunarG SDK for macOS, and after doing research at https://vulkan.gpuinfo.org/.)
This PR fixes an assert that started to occur after we enabled the SPIRV optimizer in debug builds, which revealed a mismatch between the SPIR-V version and the Vulkan API version.


Add SimpleEventDispatcher::clearEvents() + Fix psalm errors

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
-

Tagged 1.1.0.


Extracting Future queuing logic from AsyncBase

Adding FutureQueue, a structure that essentially takes in (S, Future[T]) and gives back (S, Try[T]).
I didn't mean to totally gut AsyncBase, but it's mostly become a shim integrating its own interface (apply, tick), the OperationContainer interface (execute, executeTick), and its FutureQueue.
Making this private for now; ultimately we may want to move it to algebird.
Adding a few more tests while I'm at it.  Cleaning up Node.scala style since it does that automatically.
The next step would be to integrate this with AggregatingOutputCollector.

These comments should be addressed.  On review, there is sort of a dependency on Queue, so maybe the dream of moving this out of summingbird is a bit farfetched?
I'm thinking about moving it up into the online package next to Queue.  Mixed feelings about leaving is private vs. not.

Any remaining concerns on this one?  I've verified that the current diff works fine with my planned changes to AggregatorOutputCollector.

+1 this is really great work, @jnievelt
I think the FutureQueue is really a general rate-limiter on S => Future[T] now.


Make tabs stack by default on phones

I'm currently tweaking Bootstrap 2.3 in my app so that tabs ("nav nav-tabs") switch to being stacked tabs ("nav nav-tabs nav-stacked") at phone sizes (<480px), because it looks much better that way if your tabs are long enough to line wrap.
Since Bootstrap 3 is "mobile first", I thought that you might want to consider that as the default behavior, with an opt-out class for those that want their tabs to remain in either of the two states permanently (for example if you know your tab content ahead of time is going to be very narrow, just icons perhaps).
Similar may apply to other related navs, I've used them less so I don't have a firm opinion.

3 years and still "passing" on this?. Sad.

I believe this falls under the "Rewrite tabs and pills to be mobile-first" todo item of #17021.


returning 'undefined' instead of 'World' when using curl

When deployed to OpenShift, this booster performs as follows:
$ curl http://ROUTE_NAME/api/greeting
{"content":"Hello, undefined from a ConfigMap !"}

it should be:
$ curl http://ROUTE_NAME/api/greeting
{"content":"Hello, World from a ConfigMap !"}

Steps to reproduce:

Follow instructions in docs to deploy booster, e.g. https://appdev.openshift.io/docs/nodejs-runtime.html#deploying-the-configmap-booster-using-the-oc-cli-client_configmap-oso
Run curl http://ROUTE_NAME/api/greeting

FYI @Ladicek

@rhoads-zach i see the issue,  should be an easy fix

Thanks @rhoads-zach @lholmquist!


[RFC] Rename AppProvider export for Next.js and react-router integrations

What's the problem?
I followed the example and found the example fails (keep refresh the whole page when click the nested links) when import the "AppProvider" with
import { AppProvider } from "@toolpad/core/AppProvider";

but works when use
import { AppProvider } from "@toolpad/core/react-router-dom"'

It's very confusing with the same name export but actual different. And not type 'Navigation' found of the 'core-vite' example line:
import { AppProvider, type Navigation } from '@toolpad/core/react-router-dom';

What are the requirements?
No response
What are our options?
Rename the export name and mention it in the documentation would be perfect.
Proposed solution
No response
Resources and benchmarks
No response
Search keywords:

One option that I considered before and thought about bringing up for consideration again was to export the router with React router only, to be passed as a prop to the standard AppProvider.
This requires creating an extra component sometimes, but when using createBrowserRouter instead of BrowserRouter that's already needed anyway, and it probably makes more sense.
Besides that or a possible rename, we can also consider exporting all the types from the standard AppProvider in the other AppProvider alternatives.

My idea is to add a type declaration file called "AppProviderTypes.ts", export it globally and remove the "AppProvider" export at the same time, but the changes are huge. Or add "AppProviderComponent.ts", keep the types in "AppProvider.ts", that would be a better idea.

I think we eventually want to be able to do more in the next.js app provider than just routing. A hook may be a but limited in that sense?
I'm not sure it's a good idea to export the same interfaces from multiple places (barrel filles excluded). We don't do that anywhere, it could become confusing.
I think renaming it to something like AppRouterAppProvider makes quite a lot of sense, it would be analog to the AppRouterCacheProvider we have in @mui/material-nextjs.

we lately created a new project with the toolpad and mistakenly imported the AppProvider from the wrong url, this was vaery hard to find out! each time we navigated between routes in the sidebar the app reloaded instead smoothly navigation

Note: make sure we also solve the confusion in https://github.com/mui/toolpad/pull/4513 with this.


Fixed JsExpression() error in 'eventClick'

Added "new" before "\Edofre\Fullcalendar\JsExpression()" instantiation

Should probably solve issue https://github.com/Edofre/laravel-fullcalendar/issues/23

Thanks for the PR, will be added to upcoming releases.


1750 primary language field

closes #1750
advances https://github.com/pulibrary/orangelight/issues/1129

closing in favor of https://github.com/pulibrary/bibdata/pull/1828


Suggestion: Support per-file-extension configuration of "files.trimTrailingWhitespace"

Generally I set "files.trimTrailingWhitespace" to true as a best practice, however some file formats (such as markdown) consider trailing whitespace to be significant.

There already is support for language specific settings pls see https://code.visualstudio.com/docs/getstarted/settings#_language-specific-editor-settings.


Tie new Cafes together with Cloudflare geo routing

Current setup:
*US West 1*
- Cafes
  - https://cafe.us-west-1a.textile.io (<IP_ADDRESS>)
  - https://cafe.us-west-1c.textile.io (<IP_ADDRESS>)
- Gateway
  - https://gateway.us-west-1.textile.io

*US East 2*
- Cafes
  - https://cafe.us-east-2a.textile.io (<IP_ADDRESS>)
  - https://cafe.us-east-2b.textile.io (<IP_ADDRESS>)
- Gateway
  - https://gateway.us-east-2.textile.io

*EU West 3*
- Cafes
  - https://cafe.eu-west-3a.textile.io (<IP_ADDRESS>)
  - https://cafe.eu-west-3b.textile.io (<IP_ADDRESS>)
- Gateway
  - https://gateway.eu-west-3.textile.io

Ok, the gateways are all tied together with https://gateway.textile.io/, based on geo steering.