Homebrew install not finding readline

I am trying to install via Homebrew on OSX v10.11.6, readline was automatically installed and I have tried force linking it, but I still get:
$ brew install gitsh
==> Installing gitsh from thoughtbot/formulae
==> Downloading http://thoughtbot.github.io/gitsh/gitsh-0.11.1.tar.gz
Already downloaded: /Users/bappelt/Library/Caches/Homebrew/gitsh-0.11.1.tar.gz
==> ./configure --disable-silent-rules --prefix=/usr/local/Cellar/gitsh/0.11.1
Last 15 lines from /Users/bappelt/Library/Logs/Homebrew/gitsh/01.configure:
	--without-termcap-include=${termcap-dir}/include
	--with-termcap-lib
	--without-termcap-lib=${termcap-dir}/
	--with-readline-dir
	--without-readline-dir
	--with-readline-include
	--without-readline-include=${readline-dir}/include
	--with-readline-lib
	--without-readline-lib=${readline-dir}/
	--with-ncurseslib
	--without-ncurseslib
	--with-readlinelib
	--without-readlinelib
extconf.rb:51:in `<main>': readline not found (RuntimeError)
configure: error: Failed to configure Ruby extension

I've hit the same issue on macOS 10.12.2
Using system ruby (via rbenv):

ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]

Process
$ export CPPFLAGS=-I/usr/local/opt/readline/include CPPFLAGS=-I/usr/local/opt/readline/include
$ ./autogen.sh
configure.ac:12: installing './compile'
configure.ac:6: installing './install-sh'
configure.ac:6: installing './missing'
Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'

$ ./configure
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for ruby... /usr/bin/ruby
checking for ruby... (cached) /usr/bin/ruby
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for ruby version... ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]
checking for tgetnum() in -lncurses... yes
checking for readline/readline.h... yes
checking for readline/history.h... yes
checking for readline() in -lreadline... yes
checking for rl_set_screen_size() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completion_append_character in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completion_suppress_quote in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_editing_mode in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_line_buffer in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_char_is_quoted_p in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completion_quote_character in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_getc() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_getc_function() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_filename_completion_function() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_username_completion_function() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_completion_matches() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_refresh_line() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_deprep_term_function in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completer_word_break_characters in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completer_quote_characters in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_attempted_completion_over in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_library_version in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_point in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_event_hook in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_catch_sigwinch in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_catch_signals in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_pre_input_hook in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_special_prefixes in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_cleanup_after_signal() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_free_line_state() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_clear_signals() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_get_screen_size() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_vi_editing_mode() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_emacs_editing_mode() in stdio.h,readline/readline.h,readline/history.h... no
checking for replace_history_entry() in stdio.h,readline/readline.h,readline/history.h... yes
checking for remove_history() in stdio.h,readline/readline.h,readline/history.h... yes
checking for clear_history() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_redisplay() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_insert_text() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_delete_text() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_hook_func_t* in stdio.h,readline/readline.h,readline/history.h... yes
checking for rb_obj_reveal() in ruby.h... no
checking for rb_obj_hide() in ruby.h... no
creating Makefile
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating INSTALL
config.status: executing depfiles commands
$ make
depbase=`echo src/gitsh.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
	gcc -DPACKAGE_NAME=\"gitsh\" -DPACKAGE_TARNAME=\"gitsh\" -DPACKAGE_VERSION=\"0.11.1\" -DPACKAGE_STRING=\"gitsh\ 0.11.1\"<EMAIL_ADDRESS>-DPACKAGE_URL=\"\" -DPACKAGE=\"gitsh\" -DVERSION=\"0.11.1\" -I.  -DGITSH_RB_PATH="\"/usr/local/share/gitsh/ruby/gitsh.rb\"" -I/usr/local/opt/readline/include  -g -O2 -MT src/gitsh.o -MD -MP -MF $depbase.Tpo -c -o src/gitsh.o src/gitsh.c &&\
	mv -f $depbase.Tpo $depbase.Po
gcc  -g -O2   -o gitsh src/gitsh.o
sed -e 's|@RUBY[@]|/usr/bin/ruby|g' -e 's|@rubylibdir[@]|/usr/local/share/gitsh/ruby/lib|g' -e 's|<EMAIL_ADDRESS>-e 's|<EMAIL_ADDRESS>./src/gitsh.rb.in > src/gitsh.rb
chmod +x src/gitsh.rb
sed -e 's|@RUBY[@]|/usr/bin/ruby|g' -e 's|@rubylibdir[@]|/usr/local/share/gitsh/ruby/lib|g' -e 's|<EMAIL_ADDRESS>-e 's|<EMAIL_ADDRESS>./lib/gitsh/version.rb.in > lib/gitsh/version.rb
cd ext/gitsh && /Library/Developer/CommandLineTools/usr/bin/make
compiling src/line_editor.c
linking shared-object gitsh/line_editor_native.bundle
$ make install
cd ext/gitsh && /Library/Developer/CommandLineTools/usr/bin/make
make[1]: Nothing to be done for `all'.
 ./install-sh -c -d '/usr/local/bin'
  /usr/bin/install -c gitsh '/usr/local/bin'
mkdir -p "/usr/local/share/gitsh/ruby/lib/gitsh"
cp ext/gitsh/line_editor_native.* "/usr/local/share/gitsh/ruby/lib/gitsh"
 ./install-sh -c -d '/usr/local/share/man/man1'
 /usr/bin/install -c -m 644 man/man1/gitsh.1 '/usr/local/share/man/man1'
 ./install-sh -c -d '/usr/local/share/gitsh'
 ./install-sh -c -d '/usr/local/share/gitsh/vendor/gems'
 /usr/bin/install -c -m 644  ./vendor/gems/setup.rb '/usr/local/share/gitsh/vendor/gems'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby/lib/gitsh/git_repository'
 /usr/bin/install -c -m 644  lib/gitsh/git_repository/status.rb '/usr/local/share/gitsh/ruby/lib/gitsh/git_repository'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby/lib/gitsh/arguments'
 /usr/bin/install -c -m 644  lib/gitsh/arguments/composite_argument.rb lib/gitsh/arguments/string_argument.rb lib/gitsh/arguments/subshell.rb lib/gitsh/arguments/variable_argument.rb '/usr/local/share/gitsh/ruby/lib/gitsh/arguments'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby/lib/gitsh/input_strategies'
 /usr/bin/install -c -m 644  lib/gitsh/input_strategies/file.rb lib/gitsh/input_strategies/interactive.rb lib/gitsh/input_strategies/string.rb '/usr/local/share/gitsh/ruby/lib/gitsh/input_strategies'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby/lib/gitsh/commands'
 /usr/bin/install -c -m 644  lib/gitsh/commands/error_handler.rb lib/gitsh/commands/factory.rb lib/gitsh/commands/git_command.rb lib/gitsh/commands/internal_command.rb lib/gitsh/commands/noop.rb lib/gitsh/commands/shell_command.rb lib/gitsh/commands/tree.rb '/usr/local/share/gitsh/ruby/lib/gitsh/commands'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby/lib/gitsh/parser'
 /usr/bin/install -c -m 644  lib/gitsh/parser/character_class.rb '/usr/local/share/gitsh/ruby/lib/gitsh/parser'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby/lib/gitsh'
 /usr/bin/install -c -m 644  lib/gitsh/argument_builder.rb lib/gitsh/argument_list.rb lib/gitsh/capturing_environment.rb lib/gitsh/cli.rb lib/gitsh/colors.rb lib/gitsh/completer.rb lib/gitsh/completion_escaper.rb lib/gitsh/environment.rb lib/gitsh/error.rb lib/gitsh/exit_statuses.rb lib/gitsh/file_runner.rb lib/gitsh/git_repository.rb lib/gitsh/history.rb lib/gitsh/interpreter.rb lib/gitsh/line_editor.rb lib/gitsh/line_editor_history_filter.rb lib/gitsh/magic_variables.rb lib/gitsh/module_delegator.rb lib/gitsh/parser.rb lib/gitsh/program_name.rb lib/gitsh/prompt_color.rb lib/gitsh/prompter.rb lib/gitsh/quote_detector.rb lib/gitsh/shell_command_runner.rb lib/gitsh/string_runner.rb lib/gitsh/terminal.rb lib/gitsh/transformer.rb '/usr/local/share/gitsh/ruby/lib/gitsh'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby/lib/gitsh'
 /usr/bin/install -c -m 644 lib/gitsh/version.rb '/usr/local/share/gitsh/ruby/lib/gitsh'
 ./install-sh -c -d '/usr/local/share/gitsh/ruby'
 /usr/bin/install -c src/gitsh.rb '/usr/local/share/gitsh/ruby'
$ gitsh
/usr/local/share/gitsh/ruby/lib/gitsh/line_editor.rb:1:in `require': dlopen(/usr/local/share/gitsh/ruby/lib/gitsh/line_editor_native.bundle, 9): Symbol not found: _rl_char_is_quoted_p (LoadError)
  Referenced from: /usr/local/share/gitsh/ruby/lib/gitsh/line_editor_native.bundle
  Expected in: flat namespace
 in /usr/local/share/gitsh/ruby/lib/gitsh/line_editor_native.bundle - /usr/local/share/gitsh/ruby/lib/gitsh/line_editor_native.bundle
	from /usr/local/share/gitsh/ruby/lib/gitsh/line_editor.rb:1:in `<top (required)>'
	from /usr/local/share/gitsh/ruby/lib/gitsh/environment.rb:3:in `require'
	from /usr/local/share/gitsh/ruby/lib/gitsh/environment.rb:3:in `<top (required)>'
	from /usr/local/share/gitsh/ruby/lib/gitsh/cli.rb:2:in `require'
	from /usr/local/share/gitsh/ruby/lib/gitsh/cli.rb:2:in `<top (required)>'
	from /usr/local/share/gitsh/ruby/gitsh.rb:6:in `require'
	from /usr/local/share/gitsh/ruby/gitsh.rb:6:in `<main>'

In addition, I made this change to prevent the compile error below:
diff --git a/ext/gitsh/src/line_editor.c b/ext/gitsh/src/line_editor.c
index 059ca79..5cff4dd 100644
--- a/ext/gitsh/src/line_editor.c
+++ b/ext/gitsh/src/line_editor.c
@@ -72,9 +72,6 @@ static ID id_special_prefixes;
 #ifndef HAVE_RL_FILENAME_COMPLETION_FUNCTION
 # define rl_filename_completion_function filename_completion_function
 #endif
-#ifndef HAVE_RL_USERNAME_COMPLETION_FUNCTION
-# define rl_username_completion_function username_completion_function
-#endif
 #ifndef HAVE_RL_COMPLETION_MATCHES
 # define rl_completion_matches completion_matches
 #endif

$ make
cd ext/gitsh && /Library/Developer/CommandLineTools/usr/bin/make
compiling src/line_editor.c
src/line_editor.c:1524:37: error: use of undeclared identifier 'username_completion_function'; did you mean 'rl_username_completion_function'?
                                    rl_username_completion_function);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                    rl_username_completion_function
src/line_editor.c:76:42: note: expanded from macro 'rl_username_completion_function'
# define rl_username_completion_function username_completion_function
                                         ^
/usr/local/opt/readline/include/readline/readline.h:465:14: note: 'rl_username_completion_function' declared here
extern char *rl_username_completion_function PARAMS((const char *, int));
             ^
1 error generated.
make[1]: *** [line_editor.o] Error 1
make: *** [all-local] Error 2

Any help much appreciated, every time I have to use git without gitsh I feel like I'm lost in the distant past, where life was hard, and we had to walk up hill both ways.

Thanks for the reports. I couldn't reproduce this on my machine, but I've confirmed it can be reproduced on a macOS system that doesn't already have gitsh installed.
@tomlea I think your problems building from source might result from not setting LDFLAGS (see the INSTALL file for an example). That could explain the Readline functions that weren't found by configure, the linking error when you ran make, and maybe even the edit you needed to make to the C.

Oops, copy pasta error on the first line of my build. Oops.
So it seems with correct env vars, I'm back to the same place as we were with homebrew. Explains the whole 'not linking right' ball game.
Continuing to investigate.
$ CPPFLAGS=-I/usr/local/opt/readline/include LDFLAGS=-L/usr/local/opt/readline/lib ./configure
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for ruby... /usr/bin/ruby
checking for ruby... (cached) /usr/bin/ruby
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for ruby version... ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]
checking for tgetnum() in -lncurses... yes
checking for readline/readline.h... yes
checking for readline/history.h... yes
checking for readline() in -lreadline... no
extconf.rb:51:in `<main>': readline not found (RuntimeError)
configure: error: Failed to configure Ruby extension

$ CPPFLAGS=-I/usr/local/opt/readline/include  ./configure
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for ruby... /usr/bin/ruby
checking for ruby... (cached) /usr/bin/ruby
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for ruby version... ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]
checking for tgetnum() in -lncurses... yes
checking for readline/readline.h... yes
checking for readline/history.h... yes
checking for readline() in -lreadline... yes
checking for rl_set_screen_size() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completion_append_character in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completion_suppress_quote in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_editing_mode in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_line_buffer in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_char_is_quoted_p in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completion_quote_character in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_getc() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_getc_function() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_filename_completion_function() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_username_completion_function() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_completion_matches() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_refresh_line() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_deprep_term_function in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completer_word_break_characters in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_completer_quote_characters in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_attempted_completion_over in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_library_version in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_point in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_event_hook in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_catch_sigwinch in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_catch_signals in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_pre_input_hook in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_special_prefixes in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_cleanup_after_signal() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_free_line_state() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_clear_signals() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_get_screen_size() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_vi_editing_mode() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_emacs_editing_mode() in stdio.h,readline/readline.h,readline/history.h... no
checking for replace_history_entry() in stdio.h,readline/readline.h,readline/history.h... yes
checking for remove_history() in stdio.h,readline/readline.h,readline/history.h... yes
checking for clear_history() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_redisplay() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_insert_text() in stdio.h,readline/readline.h,readline/history.h... yes
checking for rl_delete_text() in stdio.h,readline/readline.h,readline/history.h... no
checking for rl_hook_func_t* in stdio.h,readline/readline.h,readline/history.h... yes
checking for rb_obj_reveal() in ruby.h... no
checking for rb_obj_hide() in ruby.h... no
creating Makefile
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating INSTALL
config.status: executing depfiles commands

I think I've found the root of this issue, in the mkmf.log generated by extconf.rb:

ld: symbol(s) not found for architecture i386

Confirmed with:
nm -jg -arch x86_64 /usr/local/opt/readline/lib/libreadline.a
nm -jg -arch i386 /usr/local/opt/readline/lib/libreadline.a

I think what's going on here is that we need a universal Readline binary in order to build the C extension for the universal Ruby binary that ships with macOS.
There are two work arounds:

Install Ruby via Homebrew before installing gitsh, i.e. brew install ruby && brew install gitsh
Build Readline from source as a universal binary, there are detailed instructions in this comment: https://github.com/thoughtbot/gitsh/issues/281#issuecomment-291033098

I'll see if I can improve the Homebrew formula to build correctly against system Ruby and Homebrew Readline. If that fails, I'll make Homebrew Ruby a specific dependency.

Confirmed brew install ruby && brew install gitsh works for me!
❤ ❤  You made me so happy ❤ ❤
Thanks @georgebrock!

brew install ruby && brew install gitsh worked for me as well
Thank You!

In looking at whether or not Homebrew Readline can be installed as a universal binary, I discovered that until very recently it was installed that way be default: https://github.com/Homebrew/homebrew-core/pull/10907
There's a whole series of recent PRs dropping calls to ENV.universal_binary from formulae, one of which contains some limited discussion of why it's happening: https://github.com/Homebrew/homebrew-core/pull/9641#issuecomment-280746019

PR opened against Homebrew to change the readline formula's architecture back to universal. If they accept it, I'll close this issue without making further changes to gitsh.

Thanks to some feedback on the Homebrew PR, I've learnt that it's always possible to link non-universal and universal things with the right flags. In this case, I was missing the extconf.rb argument --with-arch-flag.

Fixed in #291.

Released in 0.11.2. No need to brew install ruby anymore!


Fix #1767 - NPE on OptionSpec.getValue() (IScoped)

This PR fixes https://github.com/remkop/picocli/issues/1767, based on the IScoped approach discussed in the issue

Merged. Thank you for the PR!


Document VM API discussion

There were some offline discussions relatde to VM API, the conclusion should be documented.

we can either add another section to vm-configuration.md or config-and-instances.md, or create a new one, like detailed-vm-configuration.md or something like that.
Things like "no strict 1:1 mapping", backend/frontend split are already covered, so perhaps just add a section with guidelines and examples to cover the complete libvirt xml expressiveness
Afterwards it makes sense to revisit the current config-and-instances.md text, as it would likely make sense now to make VMConfig look very similar to VM, reuse the spec.

I think we've moved past the discussion phase and have a plan for implementation. #532 can be used to track the implementation


Adding auto mode

I was able to migrate my Blazor Server app from .NET7 to .NET8 and it works. I would like to further add auto mode to the project by adding a client project to this. Guidance on how to accomplish that would be appreciated. I think such a guide will be helpful to many developers who are migrating there .NET7 Blazor server apps to .NET8.

Thanks for this feedback! I've opened https://github.com/dotnet/AspNetCore.Docs/issues/30471 to track adding this documentation.


Add meta functions

Intended to fix #12

@baparham what is remaining to land this PR? It's incredible that you willing to pick up the whole meta section (I'm happy to pick up some of the work though) but it might be better to land integrations 1 by 1?

@tobrun It was rather arbitrary to lump these all together, so perhaps progress can be faster if it's slimmed down to just geomEach and new PRs/issues are created to work the remaining meta functions. Perhaps tracking the overall completion of them in one top level issue or something?


Adds gpp_suppoorted flag

Adds the current adapters that support gpp. Adds gpp_supported into all docs on how to create an adapter.

https://github.com/prebid/Prebid.js/issues/9390


java.lang.ClassNotFoundException running spring cloud stubrunner in spring-boot-cli 2.2.0.M3 and 2.2.0.M4

I have installed the latest version of spring-cloud-cli 2.1.0.RELEASE and trying to usespring cloud stubrunner with spring-boot-cli 2.2.0.M4 but I got the error below. It is running ok with spring-boot-cli versions 2.0.x, 2.1.x and until 2.2.0.M2
Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory
    at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
    at org.springframework.boot.loader.LaunchedURLClassLoader.loadClass(LaunchedURLClassLoader.java:92)
    at org.springframework.boot.loader.thin.ThinJarLauncher$ThinJarClassLoader.loadClass(ThinJarLauncher.java:479)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
    ... 34 more

Probably need a new version of thin launcher @dsyer

Looks like just a missing dependency to me (it's the app that's barfing, not the launcher).

I can reproduce this though. Kind of a head scratcher. Will keep digging.

Fixed (you need 2.2.0 though for Spring Boot 2.2.x).

Thanks @dsyer


Ronnie/postgress over igal

@ronniel1 where can we see the logs of the DB? is there an option to set it to stdout?


Multiple controllers

I understand that this is a hack, however, it is one of the only solution I got to work in some games where even x360ce doesn't.
However, it only reports one xinput controller, even if I have 4 controllers connected.
Can you fix it in order to report multiple xinput controllers for each connected device?

I'm seeing 4 controllers reported on my system when using xboxdrv.

This seems to work now, at least in XInputTest.exe.

I can confirm it works for me in actual games.


Add Roberto Orozco to Contributors.md

Thank you for this great repo.

Hi  @robertoissc, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hey @Roshanjossey, the tutorial is great, I've been exploring multiple projects looking to contribute but I haven't been able to break the first-contribution-barrier until now. This exercise definitely encourages me to find a project for my next pull request and to continue contributing. Thanks!

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


Remove mock test fallback

Please describe the change you are making
This PR solves https://github.com/oVirt/go-ovirt-client/issues/191.
It removes the fallback to the mock client when creating the live client creation fails (e.g. missing env variables or typo in env variable name) during tests. Also, the function to create a test helper with a mock client is exported and the tests were rewritten so that each test is executed with a mock and live client in sub tests. This also enables to explicitly run the tests either with the mocked backend or a live connection.
Are you the owner of the code you are sending in, or do you have permission of the owner?
yes
The code will be published under the BSD 3 clause license. Have you read and understood this license?
yes

I wonder if the same could be accomplished with the TestMain function. It's a bit of magic, but it would make reading the tests a whole lot easier.

I wonder if the same could be accomplished with the TestMain function. It's a bit of magic, but it would make reading the tests a whole lot easier.

Good point. I haven't used TestMain yet, though. Will have a look into it.

Looks good, let's see what OST says.

/ost


Broken multipart upload in 2.4.1

Using TransferManager to upload a File with version 2.4.1 throws exception:
com.ibm.cloud.objectstorage.SdkClientException: Failed to mark the file position
        at com.ibm.cloud.objectstorage.internal.ResettableInputStream.mark(ResettableInputStream.java:148)
[...]
Caused by: java.nio.channels.ClosedChannelException
        at sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:122)
        at sun.nio.ch.FileChannelImpl.position(FileChannelImpl.java:265)
        at com.ibm.cloud.objectstorage.internal.ResettableInputStream.mark(ResettableInputStream.java:146)

Sample code:
// test file created with head -c $((15*1024*1024)) /dev/random > fileLargerThanOnePart.rnd
File localFile = new File("fileLargerThanOnePart.rnd");
PutObjectRequest putRequest = new PutObjectRequest(bucketName, key, null, metadata);
putRequest.setFile(localFile);
Long partSize = 5 * 1024 * 1024L;
TransferManager transferManager = TransferManagerBuilder.standard() //
	.withS3Client(this.client) //
	.withMinimumUploadPartSize(partSize) //
	.withMultipartCopyPartSize(partSize) //
	.withMultipartUploadThreshold(partSize) //
	.build();
Upload upload = transferManager.upload(putRequest);
upload.waitForCompletion();

Expected:
Successful upload, as it happens with version 2.0.0
Observed:
 java.nio.channels.ClosedChannelException
        at sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:122)
        at sun.nio.ch.FileChannelImpl.position(FileChannelImpl.java:265)

Version tested:
v2.4.1

@elder-cb I'm looking into this now.
Is there a reason you're using 2.4.1? The current version is 2.4.3

@elder-cb do you have any more informaiton on this? I'm currently unable to recreate the issue.

@paul-carron
I've uploaded a sample project to replicate the issue, updating also to version 2.4.2 (I was using 2.4.1 'cause it was the latest when I started coding with it and never updated): https://github.com/elder-cb/cos-sdk-issue-16

Ticket CSAFE-51255, has been raised to track this issue internally.

FYI, I've added docker support in the sample code using ibmcom/ibmjava:8-sdk base image

The fix for this issue has been released within the 2.4.4 version of the Java SDK.  Please confirm if this release resolves your issue.

Tested again with the sample code after updating the dependency version: it now works fine, thank you! :)

close #16


Error message in English: 'When using GetX, an additional exception occurred: setState() or markNeedsBuild() called during build.'

“”“
Obx(
() => circularProgressBar(context,
builder: (context, value, __) => Container(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
Text(
"${(value / 2 * 100).toStringAsFixed(1)}%",
style: Theme.of(context)
.textTheme
.titleMedium
?.copyWith(
color: Colors.white,
)),
Text(
"完成率",
style: Theme.of(context)
.textTheme
.labelSmall
?.copyWith(
color: Colors.white,
fontSize:
ScreenAdapter.width(8)),
)
],
),
),
valueNotifier:
controller.todayCompletionRateValueNotifier,
progress: controller.currentCompleted.value,
maxProgress: controller.todayCompletion.value),
),
”“”
“”“
Widget circularProgressBar(
context, {
required Widget Function(BuildContext, double, Widget?) builder,
required ValueNotifier valueNotifier,
required double progress,
required double maxProgress,
}) {
return Container(
width: ScreenAdapter.width(100),
height: ScreenAdapter.width(100),
child: DashedCircularProgressBar.aspectRatio(
aspectRatio: 1,
// width ÷ height
valueNotifier: valueNotifier,
corners: StrokeCap.round,
progress: progress,
maxProgress: maxProgress,
startAngle: 225,
sweepAngle: 270,
foregroundColor: Colors.green,
backgroundColor: const Color(0xffeeeeee),
foregroundStrokeWidth: 10,
backgroundStrokeWidth: 10,
animation: true,
animationDuration: const Duration(milliseconds: 700),
// animationCurve: Curves.linear,
seekSize: 0,
seekColor: Colors.green,
child: Center(
child: ValueListenableBuilder(
valueListenable: valueNotifier, builder: builder),
),
));
}
”“”
controller
“”“
class HeaderWidgetController extends GetxController {
late ValueNotifier todayCompletionRateValueNotifier= ValueNotifier(0.0);
@override
void onReady() {
super.onReady();

init();

}
init(){
xxx
xxx
xxx
todayCompletion.value = totalCompletion.toDouble();
currentCompleted.value = currentCompletion.toDouble();
todayCompletionRateValueNotifier.value = currentCompletion.toDouble();

}
}
”“”
When I trigger init() update through a button,
The console keeps reporting an error message:
Another exception was thrown: setState() or markNeedsBuild() called during build.
Another exception was thrown: setState() or markNeedsBuild() called during build.
Another exception was thrown: setState() or markNeedsBuild() called during build.
Another exception was thrown: setState() or markNeedsBuild() called during build.
Another exception was thrown: setState() or markNeedsBuild() called during build.
...
...
...
controller.currentCompleted.value，  It needs to change every time the button is clicked.
The following error still occurs after the project is rebuilt：
The following assertion was thrown while dispatching notifications for ValueNotifier:
setState() or markNeedsBuild() called during build.
This ValueListenableBuilder widget cannot be marked as needing to build because the
framework is already in the process of building widgets. A widget can be marked as needing to be
built during the build phase only if one of its ancestors is currently building. This exception is
allowed because the framework builds parent widgets before children, which means a dirty descendant
will always be built. Otherwise, the framework might not visit this widget during this build phase.
The widget on which setState() or markNeedsBuild() was called was:
ValueListenableBuilder
The widget which was currently being built when the offending call was made was:
TweenAnimationBuilder

This is not stackoverflow.


SDK-1136: precommit hooks

Initial attempt at a pre-commit configuration based on existing
recommendations from CONTRIBUTING.md.

I'm going to manually checkout the precommit config and use it for a week before I merge into development to make sure it doesn't break anything.


Fix Bond.CSharp.targets to support BondOptions

A bug in the condition for the _BondCodegenWithDefaultOptions items was
causing a separate instance of gbc.exe to be launched per BondCodeGen
item when BondOptions wasn't empty.

This change breaks Linux/Mono build. Maybe the alternative of not adding global option to BondCodegen options would be better?

I couldn't find a build log to see what fails.  Did you understand what didn't work?
Sent from my Windows Phone

From: Adam<EMAIL_ADDRESS>Sent: 4/22/2015 12:20 AM
To<EMAIL_ADDRESS>Cc: Ran<EMAIL_ADDRESS>Subject: Re: [bond] Fix Bond.CSharp.targets to support BondOptions (#53)
This change breaks Linux/Mono build. Maybe the alternative of not adding global option to BondCodegen options would be better?
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/bond/pull/53#issuecomment-95056838.

https://travis-ci.org/Microsoft/bond/jobs/58008885


adding helwan university

@sheriff-kurdi I am sorry, the domain commerce.helwan.edu.eg is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


I want to change the model during the XRSession.

Is it possible to change the model during the XRSession
while locating a new model at the same location and fitting size of the new model at camera?

For the experiment, I have used the ar-floor demo.
I added a button using DOM overlays. and linked a changeModel function to the button.
In the changeModel function, I executed the below step by step.

I loaded the new model by using GLTFLoader().load.
After loading model, I called view3d.display(model...)

The code that I used is below.
function changeModel() {   var model_path = "<model_path>"+".glb"   loader.load(model_path)   .then(model => {     view3d.display(model, {       applySize: false,       size: 100,       resetView: false     });   });
The video that is the result of my code.
https://user-images.githubusercontent.com/16498206/144455591-134c72dc-41df-452e-ae2f-a90dc359c99d.mp4

When the new model was changed and displayed, the new model was located at camera origin, and I cannot control the new model.

Hello @littleanti!
Try setting the old model's position into the new one's position.
Like,
const oldModel = view3d.model;
const oldModelPosition = oldModel.scene.position;

newModel.scene.position.copy(oldModelPosition);
// Adjust Y val by the size of model's bbox
newModel.scene.position.setY(newModel.scene.position + oldModel.bbox.min.y - newModel.bbox.min.y);

view3d.display(newModel, { applySize: false, resetView: false });

P.S.
We're preparing the next major version of this component right now.
I'll definitely make an API for this use case :)

Thank you for reply.
When I commented the below code, it works properly.
//newModel.scene.position.setY(newModel.scene.position + oldModel.bbox.min.y - newModel.bbox.min.y);
By the way, after changing oldModel to newModel, the OrbitControl was broken, so I could not control loaded newModel.
How to restart model controller for newModel??
Thank you.
Yoon.

@littleanti
I think maybe there's some issue with calculating the bounding box, I didn't check the actual model so I'm not sure about that though.
_initModelPosition should not be called again, as we're using the old model's position.
Was there an error when changing the model? Or, what exactly do you mean floor control is broken? Do you mean the model is just rotating wherever you click?

https://user-images.githubusercontent.com/16498206/145138258-09c26d7e-7d27-42f8-b328-9f31e33065fb.mp4
In the video, I cannot control newModel after model changing.
I mean that AR controller does not work.

Can you wait for me to release v2? I'll promise to include that feature in the next version.
v2 will be released within this month.

I see!
When the v2 will be opened, could u leave a comment to this thread?

Sure, I'll do that :)

Is there any update?

@littleanti
It's almost done, and I'm working on the demos and documents. The estimated release date is this Friday :)

@littleanti Hello!
I've just released a preview of the next version with the tag next.
You can install it like this:
npm i @egjs/view3d@next

Check the document & demo on here (I've also included the example of change model during AR session):

https://woodneck.github.io/egjs-view3d/

Thank you so much!..
I'd love this version 2!!


feat: add fullstory and auto capture

Let's shelve / cancel this for now, as it seems Sentry Replay has made this need, obsolete.


Searching for a deployment makes Kaoto crash

Describe the Bug
Trying to search for a deployment, makes Kaoto crash, this seems to come from @patternfly, a similar issue that @apupier reported a couple of weeks ago because of the parameter reorder.
Steps to Reproduce the Bug or Issue

Go to the hamburger menu at top-left
Select Deployments
Use the search box to look for a specific deployment
As soon as a letter is entered, Kaoto crashes with TypeError: query.trim is not a function

Screenshots or Videos
Screencast from 2023-03-10 12-14-22.webm
Platform

OS: [Linux]
Browser: [Firefox]
Version: [0.7.2-dev]

a similar issue that @apupier reported a couple of weeks ago because of the parameter reorder.

right. The fix consisted in aligning the patternfly dependencies

based on yarn.lock, react-core is asked in several versions:
"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>and use  version "4.276.6"

kietools requires ^4.157.3
@patternfly@react-log-viewer requires ^4.273.1
but I do not see why these dependencies would be implied when doing a search for deployments. And anyway, in theory it resolves with latest version of react-core in yarn.lock. Do we have other micro-frontends than step-extensions? (that would use a different version)

kietools requires ^4.157.3 @patternfly@react-log-viewer requires ^4.273.1
but I do not see why these dependencies would be implied when doing a search for deployments. And anyway, in theory it resolves with latest version of react-core in yarn.lock. Do we have other micro-frontends than step-extensions? (that would use a different version)

@apupier I believe that we might be facing the same issue about the function parameters switched :thinking:

Ugh right, breaking change in the minor release...
https://github.com/patternfly/patternfly-react/commit/1995c5f2808e842443483421951b114e1f841fbd#diff-e866d1da7570edec768365d7c93bad516e9921a953f37586488e5d1d72abbe08L99
This change is already in<EMAIL_ADDRESS>which is specified in kaoto-ui package.json, so we'd be better to align with the new arg order I guess... @kahboom WDYT? Otherwise we'll need to downgrade @patternfly/react-core.

@igarashitm I think that sounds good, otherwise we'd just be postponing a minor change that we'll have to do eventually anyway


OIPA-2119

https://app.zenhub.com/workspaces/iaticloud-5b8e865bb2cc7b6c78ece322/issues/zimmerman-zimmerman/iati.cloud/2119

drop parse-only-validated-dataset process

:tada: This PR is included in version 5.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Needs Update

This guide is outdated. lot of options are changed or not available anymore so please update this as soon as possible.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f43472af-a9d3-8bef-0f24-b81f8f6cd2dd
Version Independent ID: 42cfbea5-0b4c-a0a3-4cce-1edf5523f605
Content: Preparing an Application for Release - Xamarin
Content Source: docs/android/deploy-test/release-prep/index.md
Product: xamarin
Technology: xamarin-android
GitHub Login: @conceptdev
Microsoft Alias: crdun

Are there specific areas that should be updated? Many of these options still exist today and are relevant to the release process. A couple of screenshots could use updates, but they are still correct today. Please let us know!

r8 replaces the need of proguard

This part is no longer valid (or from a xamarin forms perspective I don't understand where to put this code)
#if DEBUG
[assembly: Application(Debuggable=true)]
#else
[assembly: Application(Debuggable=false)]
#endif

@sjorsmiltenburg you can put that in the AssemblyInfo.cs in your Android project. Create the file if it doesn't already exist.

Thanks for submitting an issue and we apologize for the delayed response. The requested updates haven't been made since the creation of the issue, and the timeline for resolution may vary based on resourcing, so the issue is being moved to an internal repo to better track it.


Change the error message so users without calendar can use the app

Overlays only timetable, so other controls are still accessible.

Resolves #49

I have just a question about muting an error; you're now passing an onMute prop to Error component; do you think there will be a reason for user to mute an error?

do you think there will be a reason for user to mute an error?

Yes, when there are connection issues. I was thinking about the situation: I'm sitting in bus/train, data has been loaded and I want to do some actions with the loaded data. Internet is unstable, alright, error message yells at me 'Your internet connection is gone', but I can hide that thing and click on my event and show loaded information or do something else.

I see two problems here. The error message may be misleading. We must distinguish between non-existing calendar (404), unauthorized access (401) and some other error. We should make unauthorized access very clear for users – explain to students why they can’t see other students calendar.
The error message is also too small and not well positioned (Golden ratio FTW!).

@MMajko Could you please fix the issues I wrote above?

@MMajko I will take a look at this first thing in the morning, so just ping me when you are done.
The build seems to be broken because of missing constants. Perhaps you didn't solve merge conflicts properly?

So I assume this one is ready for review?

Okay,

HIDE_ERROR is a misleading name since we can have multiple errors in various domains, as discussed, one error won't crash the whole UI. Rename HIDE_ERROR action to something which is associated with data or events, e.g. DATA_ERROR_HIDE
same for hideError action, plus move it to the dataActions with tests
fix the lying test for dataReducer

Also we need to squash some of those commits, I can do that, just let me know and I'll do that before merge.

Fixed, I guess.

@jnv, review and/or comment plz

Okay, the only remaining stuff is renaming hideError to hideDataError and we're done. I'll do it ASAP.

I have squashed this in d44c77fcc1a5a27f53fda7a8f9b4afe205a152ff


Please update the django-phonenumber-field dependency to allow version 5.0.0

Please update the django-phonenumber-field dependency to allow version 5.0.0.
Currently only up to version 3.99 is allowed, and in the meantime version 4.0.0 and 5.0.0 came out in the past year.

Are there any changes in those versions that might effect django-two-factor-auth users?

Not sure how your latest release can claim 'Django 3.1 support' when your dependencies do not.
Django 3.1 support was only added to django-phonenumber-field in 5.0 (see https://github.com/stefanfoulis/django-phonenumber-field/blob/master/CHANGELOG.rst)

That changelog also claims that support for Django 2.2 has been dropped. Is that a mistake?

Apparently yes, it is a mistake https://github.com/stefanfoulis/django-phonenumber-field/issues/382#issuecomment-684765218

ping @moggers87

Closed by #401


Automatically handle NotReady kubelets

User Story
- As a person doing oncall, I want kubelets in a NotReady status to be automatically handled, so I don't need to.
Details, Background
Currently, when a kubelet entires a NotReady status (and doesn't exit it on its own in time), a human gets alerted and we take care of the failing kubelet. With the increasing number of kubelets under our responsibility, this becomes fatiguing for operations, as well as a poor customer experience.
If a kubelet that had entered a NotReady status (and wasn't recovering) was automatically handled (e.g: by reboot, terminating the instance, etc), this would be better for operations and customers.
Blocked by / depends on
Nothing I'm aware of.
Providers

[x] AWS
[ ] Azure
[ ] KVM

fyi @marians @MartaD, from discussion in sig product sync on monday

this is just a big ol' tracker, feel free to throw away and use other issues or w/e <3

cc: @nprokopic

KVM team will add feedback from kvm perspective and do the needful to continue conversation with product/teams.

This is already implemented for AWS. The documentation on how to enable the feature is available at: https://docs.giantswarm.io/basics/automatic-termination-of-bad-nodes/ .

@yulianedyalkova Is this released already, and if yes, should that info be added to  https://docs.giantswarm.io/basics/automatic-termination-of-bad-nodes/ ?
@MartaD According to the above docs page, this is implemented on Azure. However, the box above is not yet ticked.
If this is in fact done and released for all providers, the issue could be closed.

@yulianedyalkova Is this released already, and if yes, should that info be added to  https://docs.giantswarm.io/basics/automatic-termination-of-bad-nodes/ ?
@MartaD According to the above docs page, this is implemented on Azure. However, the box above is not yet ticked.
If this is in fact done and released for all providers, the issue could be closed.

@marians it's not released yet but I forgot about the docs - I'll update them. Thanks!

@marians it's not released yet but I forgot about the docs - I'll update them. Thanks!

@marians Azure v13.1.0 is not released yet, docs were updated immediately to not forget about it once it is released.

@marians Azure v13.1.0 is not released yet, docs were updated immediately to not forget about it once it is released.


Added start of claims support

TODO:

[ ] Add config option to disable the integration
[ ] Fix problem where added members do not persist across reloads
[ ] Name the claim the teams name
[ ] Cancel transferOwnership event (I have requested this be added to the other plugin) unless the player is a team owner (else the plugin will get confused)

closes #63

How would that work @booksaw ? The claiming system...

How would that work @booksaw ? The claiming system...

Claims will be associated with teams instead of players.
All members of a team will be trusted in the claim.
The owner of the team can manually trust other players outside of their team.

It would be cool if you could buy claims with team points or if you invite new players to your team!

I had not thought of adding team score as a possible currency to keep the claim alive.
I will look into doing this, but I think it may have to be done by ultimateClaims instead of by me


[explorer][wip] Change explorer e2e tests to local transaction serializer

This is currently failing due to a No more params error.

The execution api on fullnode takes another parameter, see here. IIRC @666lcz  mentioned this new API is supported in ts sdk already


Support Request:

Describe Your Problem:
I have only a switch to start / stop roomba
where are the switches for the different rooms?
Model: i7+ and Bravaa M6
Room by room support = yes
But your plugin says = false:
Expected behavior:
No response
Logs:
[2/25/2022, 6:19:26 PM] [iRobot] Logging into iRobot...
[2/25/2022, 6:19:26 PM] [iRobot] Adding new accessory: Roomba

Config:
{
            "name": "iRobot",
            "manualDiscovery": true,
            "roombas": [
                {
                    "name": "Roomba",
                    "blid": "XXX",
                    "password": "xxx",
                    "ip": "<IP_ADDRESS>"
                }
            ],
            "lowBattery": 20,
            "offAction": "stop:dock",
            "status": "cycle:clean",
            "platform": "iRobotPlatform"
        }

Node Version:
v16.14.0
NPM Version:
8.3.1
Homebridge Version:
v1.4.0
Plugin Version:
2.1.16 / 3 beta 11
Operating System:
Other

I have not added room-by-room support to version 3 yet. It is still being worked on


migrate HTML examples to JSON

What's included in this PR

Implement a vite plugin, which will scan the new examples folder and compose all the JSON schemas into one JSON file.
Migrate all the HTML examples to JSON, which lets us re-use examples across packages.

Changes to developers
Instead of visiting multiple URLs, now runtime package developers can visit localhost:3000 to visit all the examples.
The format of an example is:
{
  "modules": [] // if you have a custom module, can be declared here. custom traits and components should be implemented in the same way.
  "app": { ... } // the app schema
}

And there are some limitations of the new JSON format examples:

Multiline strings are not supported by JSON, so we need \n to format multiline strings.
We could not use typebox in JSON, so we need to write raw JSON schema as an alternative.

The new dev playground

Some examples seem broken, but not sure it's caused by this migration.


CString::Replace escape chars?

Are there any? When the Replace fails, how do I know which characters it can fail on without a list of characters that need escaping.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0a9ec5a-f8e2-f739-1b39-74b4a775ee98
Version Independent ID: c1eaf2d0-1cd3-25a1-c44d-3aae49be555b
Content: CStringT Class
Content Source: docs/atl-mfc-shared/reference/cstringt-class.md
Product: visual-cpp
Technology: cpp-mfc
GitHub Login: @mikeblome
Microsoft Alias: mblome

Closing as part of backlog grooming. We have accrued more issues than our resources can manage.
Criteria for closing include severity of the issue, how broadly applicable it is, whether the issue enough information is provide to act on the issue, etc.
If you think this issue should not have been closed, reopen it with a comment explaining why.


Link doesn't work in - Minikube for Kubeflow installation

Now that you have a Kubernetes cluster running - the Minikube cluster - follow the existing Kubernetes cluster  instructions for installing Kubeflow.

The above link doesn't work on this page
Link should be changed to https://www.kubeflow.org/docs/started/k8s/overview/

@lionshk
I try today and the link works properly for me. Can you please retry?

Yeah, it works now


Update apache-kafka-get-started.md

@mayankmishrakp : Thanks for your contribution to the Azure documentation! The author, @blackmist, has been notified to review your proposed change.

@nitinme @cjgronlund

@mayankmishrakp Good catch! Thank you for this helpful correction. I'm pulling your commit into another PR, which will then be accepted. Thanks again for your contribution to Azure documentation!

#sign-off


Documentation Issue

No proper documentation is provided

Hi there, As this repo is a part of the blog post, I  thought adding documentation isn't necessary. If you want to add documentation, then please feel free to add documentation in your forked repo and create a pull request. I'll be happy to merge this


[BUG] kanctl resource validation is buggy for native resources if they are being provided as --objects

Describe the bug
If we want to give pod as subject while creating the actionset the validation of that pod fails stating couldn't find the resource. But if we create the yaml using --dry-run flag and then create the actionset using kubectl create -f things work, it means the resource validation has some issues and we should resolve that.
To Reproduce
Steps to reproduce the behavior:
Try to create an actionset and give a pod details using --object flag
... --object api/v1/pods/podnamespace/podname

Expected behavior
The actionset should be created successfully if podname is there in the podnamespace the , but it is not getting created stating
resource podname not found in podnamespace.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

A PR has been raised https://github.com/kanisterio/kanister/pull/638
Here is how we can provide the pod now.
kanctl create actionset \
--action backup \
--namespace kanister \
--blueprint etcd-blueprint \
--objects /v1/pods/kube-system/etcd-minikube \
--profile kube-system/s3-profile-xhgl9

@viveksinghggits Can this be closed?

Yes. Fixed in
https://github.com/kanisterio/kanister/pull/638


support stdlibrary logging

Hey,
for me it would be great if metaflow used the standard library logging module instead of the current setup with printing (or would at least support to add some logging handler to the current procedures).
This would enable one to not only see this in cloudwatch but also to add custom handlers (filehandlers, google cloud logging, ...) and integrate metaflow better in existing infrastructure which is using the logging module often.
tbh, I did not dig that much into the code for now to understand how much work this would be, but consider this a really nice feature.
Please drop your thoughts on this, I'd like to discuss if this is possible :)

@nicoa Excellent point. We do something similar internally as well where all the execution logs are pushed into our data warehouse via an event stream enabled by a side-car. You can take a look at the debugLogger implementation for starters.

Thanks! I will have a look. Already thought about that but wasn't sure how to use in the CLI with own SideCar Class - do I have to patch this into the implementation or can I somehow implement in a file and point there?
Will for sure try out the debugLogger - this should be simple by invoking with --event-logger=debugLogger, correct?

Currently, you will have to patch this into the metaflow code base. Going forward, we should make it easier to do BYOC but we are not there yet. Yes, right now you should be able to do --event-logger=debugLogger to execute - here is the pointer to relevant CLI args.

@nicoa Please comment and re-open this issue if needed.

I think the logging thing would still be interesting (aka on initialization add some python logging handler or manipulate instead of passing the event-logger param), what would you think?

Also looking forward to having standard logging supported. I just don't like seeing print(...) in my code.
As a workaround (and I don't think this really addresses the other concerns in this issue), I have implemented something like this:
import logging

from metaflow import FlowSpec

class PrintLogger(logging.Logger):
    def handle(self, record):
        print(f'{record.name}: {record.msg}')

class MyFlow(FlowSpec):
    @property
    def logger(self):
        """
        Get the logger for this class
        """
        logger = PrintLogger(name=self.__class__.__name__, level=logging.INFO)
        return logger

    @step
    def start(self):
        self.logger.info('Starting flow')

Standard python logging support would also be greatly appreciated in order to get logs from libraries that use it (that is, most of them). It also helps in the rarer case of having to reuse code between projects which includes logging via stdlib. This would also give the users full control over logging formats, log levels in various libraries and external log aggregator support.


FI-2701: Migrate to HL7 validator wrapper

Summary
This PR migrates the test kit from the Inferno validator-wrapper to the HL7 validator-wrapper. This is similar to most of the other test kits, with one significant difference that his test kit used the inferno validator's FHIRPath endpoint, so this now includes the fhirpath-service in the docker-compose files and nginx.background.conf.
Other changes:

add the hl7_validator service to docker-compose and nginx. The old validator components are left commented out in case someone really wants the old validator UI
Bump the core dependency
Migrate validator blocks to fhir_resource_validator and specify the IG
Update the generator with ^ and re-generate the suite
Update the fhirpath evaluation method to call the appropriate endpoint (based on #2 )
Add a README to the IGs folder explaining when it's necessary for the files to be there
Fixes an issue where the custom validation logic tries to validate against native profile urls with the IG's version, in particular http://hl7.org/fhir/StructureDefinition/PractitionerRole|2.0.1 . The validator doesn't have this profile loaded which results in a 500 error and a purple test result
Updates the preset and sample bundles to remove relative links, eg  . A new check in the validator has strict requirements for these and produces "Hyperlink does not resolve" errors. The replacement was See above \((.*?)\) --> \1, eg, See above (Patient/SubscriberExample) became just Patient/SubscriberExample

Testing Guidance
From a user's perspective there should be no visible difference between this and using the old validator. Run through the tests and make sure everything works

Failing on the old one and passing on the new one is unexpected. I can look more into that

Here's my test run: https://inferno.healthit.gov/suites/davinci_pas_server_suite_v201/b8L0hB6WlyK#davinci_pas_server_suite_v201-Group01-pas_server_v201_approval_use_case

I wonder if the prod validator instance may have been in an inconsistent state somehow when you tried it before, because test <IP_ADDRESS> with the preset input is passing now https://inferno.healthit.gov/suites/davinci_pas_server_suite_v201/cvEQvFrwC2p#1.1

Ignore the previous (now-deleted) message if you saw that. I wonder if the prod validator instance is in an inconsistent state because running that same test locally on main passes for me:

Ok I see the difference now. That error we're seeing on prod is for a CRD extension http://hl7.org/fhir/us/davinci-crd/STU2/StructureDefinition-ext-coverage-information.html and so the validator will only check that when the CRD IG is loaded, either explicitly or as a dependency of another IG. When you run this test kit by itself on main, you don't get those errors. But on prod the old validator instance is running for a few test kits and one of them may be bringing in a different version of CRD. If you load all the same IGs into the validator locally as are running on prod, the same error happens. (davinci-pdex-2.0.0.tgz, davinci_pas_2.0.1.tgz, uds-plus-external-package.tgz, davinci_dtr_2.0.1.tgz, udsplus-101.tgz)
So, I think this should be good, in terms of matching the old behavior when running in isolation. Let me know if you disagree @tstrass or @karlnaden , otherwise I'll merge this in

Just for posterity, turns out that constraint that was failing is bad anyway. https://jira.hl7.org/browse/FHIR-46087 (thanks fhir-at-mitre slack channel)


update hed description to clarify trial_type

Still trying to clarify tags associated with general classes of events and those associated with event instances.

This looks good to me. To clarify - does this PR replace #26?

Yes, this is a replacement for #26

However, as explained in the section above, trial-types have HED tags stored in a map

Could somebody point me to this "map" or the trial_type dictionary as you name it in this PR? I can't find anything on this in the specification. @chrisfilo can you help out?
and even if there is such a map ... who updates this map? As long as there are no clear rules for the trial_type column, people can come up with whatever description they deem sensible (which is good!). The map would thus become rather hard (read: impossible) to maintain ... and on the other hand - if we had strict rules for the trial_type column, we might as well just use the HED rules.

,
Lines 29 through 34 of 03-hed.md   define this.  This was there when I
joined the group. I think it is a good idea. It is the only really
practical way to do Hed tagging.  The natural way (outside of BIDS) is to
provide a spreadsheet of unique event codes and columns that give
corresponding HED tags.  This is the way HED validators work.  The user
then only has to tag a small number of items.  Tools map these into the
event structure and assure consistency across events. The user can also
provide additional spreadsheets that have one line for each event to give
instance specific tags (which are often used to just give the
instance-specific annotation of the event such as numerical).  Tools then
map everything. The code-specific HED goes into the .usertags field of the
EEG.event structure and the instance specific goes into the .hedtags
field.  This allows consistent editing of tagging later.
On Fri, Oct 5, 2018 at 1:45 AM Stefan Appelhoff<EMAIL_ADDRESS>wrote:

However, as explained in the section above, trial-types have HED tags
stored in a map
Could somebody point me to this "map" or the trial_type dictionary as you
name it in this PR? I can't find anything on this in the specification.
@chrisfilo https://github.com/chrisfilo can you help out?
and even if there is such a map ... who updates this map? As long as
there are no clear rules for the trial_type column, people can come up
with whatever description they deem sensible (which is good!). The map
would thus become rather hard (read: impossible) to maintain ... and on the
other hand - if we had strict rules for the trial_type column, we might
as well just use the HED rules.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-427262825,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIkumMwUKGBKl1B57OHi8Jb9ax3u4Q2ks5uhv_2gaJpZM4XJNpL
.

link for convenience: HED appendix
Okay, thanks for the explanation! I think I see what you mean but I am not sure how it will work.
See this events.tsv file ... I have added a column actual_event just for the sake of the example ... imagine it was not actually present in the file.
onset    duration    trial_type    *actual_event*
1.1    n/a    go    fixation cross onset
1.3    n/a    go    stimulus onset left of fix cross
1.5    n/a    go    participant reaction to stimulus
2.1    n/a    no-go    fixation cross onset
2.3    n/a    no-go    stimulus onset left of fix cross
...

Now with your approach, we would provide an events.json file with a key trial_type that has as its value a json object {}.
One key of this trial_type json object is HED, which is containing a mapping between each trial_type and an HED tag:
{
  "trial_type": {
    "HED": {
      "go": "some/HED/tag; that/goes/like/this",
      "no-go": "some/HED/tag; that/goes/differently",
    }
  }
}

Did I understand you correctly up to this point? If yes, there are two questions that I have:

Concretely: How would you define the HED tags in the present example (i.e., please replace  some/HED/tag; that/goes/like/this by the actual HED tag one should use in such a case)
What would you do if this mapping was not supplied by the dataset curator ... i.e., no "HED" key in the events.json, or even no events.json at all?

Hmmm --- that isn't what I thought trial_type meant. I see where the
confusion is.  I think there is a problem here.  You need to have the
facility to have users HED tag event codes as well as individual event
instances. The trial_type can be HED tagged but that conveys different
information than is used during a practical implementation of HED tags.  I
think you need to have maps for both trial_type and actual_event.  In
answer to item (2) above, the user can give any or all of the information
and the tags are merged.  When we write tools to map bids into the
EEG.event structure, we would map the trial_type and HED column tags into
the .hedTags field and the actual-event tags into the userTags field.  I
would call the actual event column   'event_type'.   At  analysis time,
there is no distinction between the two types of tags --- they are merged
in a consistent way. However, from a practical tagging viewpoint, almost
everyone will just tag event_type for most experiments.  The HED tools take
whatever is there.
go:    Attribute/Condition/Go
No go:  Attribute/Condition/No-go
Event_type:
Fixation cross:  Event/Category/Miscellaneous, Event/Label/Fixation,
Event/Description/Display fixation cross at center of screen to indicate
start of trial, Item/2D shape/Cross, Attribute/Visual/Fixation point
Stim left: Event/Category/Experimental stimulus, EventLabel/Square,
Event/Description/Display a red square on the left of the screen, /Item/2D
shape/Rectangle/Square, Attribute/Visual/Color/Red,
Attribute/Location/Screen/Left
I could do a better job tagging if I had a description of the experiment.
On Fri, Oct 5, 2018 at 8:12 AM Stefan Appelhoff<EMAIL_ADDRESS>wrote:

@sappelhoff requested changes on this pull request.
needs clarification before merging (see comments in conversation)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/33#pullrequestreview-162027429,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIkumiftUfCNeqdBCgukXdyergUCSv6ks5uh1rMgaJpZM4XJNpL
.

Thanks for providing the example tags! Of course these are minimal because the example is constraint, but they give a good idea of what it would be like to use HED tags here.

You need to have the facility to have users HED tag event codes as well as individual event instances.

I don't understand what you mean by that. Are you saying that a single column "HED" is not sufficient to exhaustively describe an event?

I think you need to have maps for both trial_type and actual_event.

Sorry, but I don't think I can follow this reasoning. I think we have now clarified that the trial_type column is truly separate from the HED column. Just think of it as two ways to describe events.

The trial_type is arguably very limited and idiosyncratic ... but quick and simple.  (imagine an experiment where a participant lifts a hand during a trial)

onset    duration    trial_type
1.1    n/a    left
2.3    n/a    left
4.5    n/a    right
...

In the accompanying events.json, we can have the following map:
{
    "trial_type": {
        "LongName": "trial type",
        "Description": "Which hand was lifted by the participant.",
        "Levels": {
            "left": "Left hand was lifted",
            "right": "Right hand was lifted"
        }
}

now completely separate from this, you can describe each event using the HED tag column ... it's also possible not to use trial_type at all. The HED column allows for a standardized and exhaustive description of the event, albeit at the cost that it is harder to do and there is currently no inbuilt validator (see this issue: https://github.com/bids-standard/bids-validator/issues/537). Note that for the HED column, a "map" in the events.json is not really possible, because all HED tags are already standardized and defined - there is no room for interpretation (which is the big plus over the simple trial_type column), and with no room for interpretation there is no need to document in the events.json. Instead, users can simply refer to the HED tag documentation at http://www.hedtags.org/ or similar.
With these premises, could you try to explain what the problem is?

I think we need to have additional discussion about this.  I don't think
having not having a validator at this point is really an issue.  We are
starting to work on a javascript validator --- and I don't see any
obstacles, but it will take a while to do and there are a number of
questions about what should be validated. However, I think we need to get a
usable incorporation of HED into the BIDS standard.
I am not sure we are talking about the same things and I am VERY concerned
that the single HED column does not cover 99% of the use cases of HED in
practice.  In practice, a typical experiment will have on the order of
10,000 events, but these events are characterized by a small number of
event classes (types of codes). Usually not more than 100.  The current tag
each event individually doesn't work from a manual perspective.  People are
not going to write 10,000 lines of HED tags.  They will tag there unique
codes and then they will have to write a script to write the tags into the
spreadsheet one line at a time. What happens if you have to change or
refine the tags?  Do you write something to make sure that you have the
same tags for the same kinds of events --- its a mess.
The trial_type as given by the example specifies an experimental condition
and not an event class and so it does not solve the problem.
My proposed solution is this:

HED column has HED tags.
Any other named column (except things like latency and duration) can
have a map in event.json and if one of the key's is HED, those HED tags are
also used.
All of the HED tags from all of the relevant columns will be validated.
(This is not at all difficult.  Just look for HED in the events.tsv and
look for maps corresponding to the named columns in events.json.   Then you
can have trial_type   or event_code  or whatever you want.)

The downstream tools are supposed to union the tags from the various
sources.  Those are validated against the schema. The statement "Note that
for the HED column, a "map" in the events.json is not really possible,
because all HED tags are already standardized and defined - there is no
room for interpretation (which is the big plus over the simple
trial_type column), "
doesn't make any sense to me.
Thanks!
On Fri, Oct 5, 2018 at 2:17 PM Stefan Appelhoff<EMAIL_ADDRESS>wrote:

Thanks for providing the example tags! Of course these are minimal because
the example is constraint, but they give a good idea of what it would be
like to use HED tags here.
You need to have the facility to have users HED tag event codes as well as
individual event instances.
I don't understand what you mean by that. Are you saying that a single
column "HED" is not sufficient to exhaustively describe an event?
I think you need to have maps for both trial_type and actual_event.
Sorry, but I don't think I can follow this reasoning. I think we have now
clarified that the trial_type column is truly separate from the HED
column. Just think of it as two ways to describe events.

The trial_type is arguably very limited and idiosyncratic ... but
quick and simple. (imagine an experiment where a participant lifts a hand
during a trial)

onset    duration    trial_type
1.1    n/a    left
2.3    n/a    left
4.5    n/a    right
...
In the accompanying events.json, we can have the following map:
{
"trial_type": {
"LongName": "trial type",
"Description": "Which hand was lifted by the participant.",
"Levels": {
"left": "Left hand was lifted",
"right": "Right hand was lifted"
}
}
now completely separate from this, you can describe each event using the
HED tag column ... it's also possible not to use trial_type at all. The
HED column allows for a standardized and exhaustive description of the
event, albeit at the cost that it is harder to do and there is currently no
inbuilt validator (see this issue: bids-standard/bids-validator#537
https://github.com/bids-standard/bids-validator/issues/537). Note that
for the HED column, a "map" in the events.json is not really possible,
because all HED tags are already standardized and defined - there is no
room for interpretation (which is the big plus over the simple trial_type
column), and with no room for interpretation there is no need to document
in the events.json. Instead, users can simply refer to the HED tag
documentation at http://www.hedtags.org/ or similar.
With these premises, could you try to explain what the problem is?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-427471805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIkuspZJ4ciI8KOwyheMo5REF0Jvp5cks5uh7BCgaJpZM4XJNpL
.

@sappelhoff let me try to explain what the problem is
Imagine the following scenario
_events.tsv
onset    duration    trial_type HED
1.1    1    left  HedTagA
2.3    1    left  HedTagB
4.5    1    right HedTagC

Accompanied by the following _events.json
{
    "trial_type": {
        "HED": {
            "left": "HedTagB",
            "right": "HedTagD"
        }
}

Currently the spec is unclear how the information about HED tags from _events.tsv and _events.json should be combined. The proposal in this PR states that a sum of two sets should be taken therefore:

Event 1 HED tags: HedTagA and HedTagB
Event 2 HED tags: HedTagB
Event 3 HED tags: HedTagC and HedTagD

Does this make more sense now?

I think spec needs clarification and this PR provides it. I just added an example to the discussion to help @sappelhoff understand the context.

I'm not seeing any new examples on the spec..... could you point me in the
right direction?
To continue on (sorry if I am belaboring a point) .....I am still concerned
about usability...... I have participated in the tagging of more than 30 of
other people's EEG studies and then used the results in analysis so I have
some experience in what works and what doesn't work and what you can
reasonably persuade people to do to annotate their studies. I would like
this to be as convenient and transparent as possible.
As I mentioned in a previous posting, most experimenters work by having
spreadsheet with a table of study-specific "event codes" or "event labels"
that identify event classes common to all of the recordings in the study.
They also keep spreadsheets of events for each recording with the
instance-specific information such as the event latency and duration and
the event class (or multiple classes)--- there might also be other columns
with specific information about events.  (The latter recording-specific
spreadsheets are currently what BIDS  specifies for events, but BIDS misses
the underlying global event information.)
Experimenters then write scripts to map the study-specific spreadsheet and
the recording-specific spread sheets into the structures needed for
whatever analysis software they are using. People look at the
study-specific event table when they want to understand or enhance the
event descriptions.
I would like there to be event.json files allowed at higher levels in the
BIDS file structure that have these maps that apply to lower levels in the
hierarchy.  The typical use case is that the experimenter specifies one
events.json file at the top level that specifies the event classes (again
--- it doesn't have to be a single event-type as you could specify for
example two or three of these (say   event_type and trial_type)  each with
HED tag maps.  The recording specific xxx_event.tsv  could have columns
with some or all of event_type and trial_type and HED and all that are
specified would be used.
On Sun, Oct 7, 2018 at 10:31 PM Chris Filo Gorgolewski <
<EMAIL_ADDRESS>wrote:

I think spec needs clarification and this PR provides it. I just added an
example to the discussion to help @sappelhoff
https://github.com/sappelhoff understand the context.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-427714157,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIkuuhfiPrij6o0DDnsCBreWOBHHtfaks5uisb4gaJpZM4XJNpL
.

I'm not seeing any new examples on the spec..... could you point me in the
right direction?

When I mentioned "examples" I was referring to the one I posted in this thread as a comment (https://github.com/bids-standard/bids-specification/pull/33#issuecomment-427706151). If you think it would be useful to add this to the spec please update the pull request (https://egghead.io/lessons/javascript-how-to-update-a-pull-request-on-github).

I would like there to be event.json files allowed at higher levels in the
BIDS file structure that have these maps that apply to lower levels in the
hierarchy.  The typical use case is that the experimenter specifies one
events.json file at the top level that specifies the event classes (again
--- it doesn't have to be a single event-type as you could specify for
example two or three of these (say   event_type and trial_type)  each with
HED tag maps.  The recording specific xxx_event.tsv  could have columns
with some or all of event_type and trial_type and HED and all that are
specified would be used.

This is already allowed since the inheritance principle applies to events.tsv and events.json. If you think it's useful it might be worth fleshing this out in the context of HED and "global tags" in the HED appendix.

Thanks for providing the example @chrisfilo. I understood the point now - adding the mentioned example to the spec would be a valuable contribution.
Regarding @VisLab's previous comment:

The statement "Note that for the HED column, a "map" in the events.json is not really possible, because all HED tags are already standardized and defined - there is no room for interpretation (which is the big plus over the simple trial_type column), " doesn't make any sense to me.

replace "not really possible" with "not really necessary"

Sorry, I was reading these threads from my email rather than github and the comments got out of sync.  I will make a first pass at a clarifying explanation of global tags. I agree the HED column shouldn't have a map.  It is designed for instance-specific tags.

I added something on current branch.  However, in doing so, I realized that I don't completely understand the BIDS naming convention.  Could someone clarify the naming convention for  _events.json files at higher levels in the hierarchy.  Thanks....

This segment should explain the naming convention for higher levels of hierarchy: https://github.com/bids-standard/bids-specification/blob/master/src/02-common-principles.md#the-inheritance-principle Please let me know if something is not clear.

Yes that is clear.  However, can you have something above subj01.... that is the global HED files usually apply to all subjects.  Can you do it above subject?  Otherwise if you have 20 subjects in your experiment, you have to repeat 20 times.
Also, I corrected the typo, but pressed the commit before writing the explanatory comment.  Sorry, I'll be more careful next time....

You can have task-nback_events.json in the root of your dataset and it will apply to all events files for task nback across participants and sessions. This is where global HED tags could be specified.

You should be able to annotate any column.  I'll try to clarify in the
spec.
I would like to comment that IMO the current BIDS specification of events
will make analysts very unhappy.   The trial_type isn't something you can
time-lock to. Every EEG analyst that I know time-locks to events of
specified type when doing EEG analysis.  trial_type does not correspond to
event_type.  The only saving grace is that with the extension we are
proposing with HED, they can get around this by defining their own column
and then annotating with HED.
On Mon, Oct 8, 2018 at 1:28 PM Chris Filo Gorgolewski <
<EMAIL_ADDRESS>wrote:

@chrisfilo commented on this pull request.
In src/99_appendices/03_hed.md
https://github.com/bids-standard/bids-specification/pull/33#discussion_r223458627
:

1.2 0.6 fixationCross Event/Category/Experimental stimulus, Event/Label/CrossFix, Event/Description/A cross appears at screen center to serve as a fixation point, Sensory presentation/Visual, Item/Object/2D Shape/Cross, Attribute/Visual/Fixation point, Attribute/Visual/Rendering type/Screen, Attribute/Location/Screen/Center
5.6 0.008 target  Event/Label/Target image, Event/Description/A white airplane as the RSVP target superimposed on a satellite image is displayed., Event/Category/Experimental stimulus, (Item/Object/Vehicle/Aircraft/Airplane, Participant/Effect/Cognitive/Target, Sensory presentation/Visual/Rendering type/Screen/2D), (Item/Natural scene/Arial/Satellite, Sensory presentation/Visual/Rendering type/Screen/2D)
500 0.008 nontarget Event/Label/Non-target image, Event/Description/A non-target image is displayed for about 8 milliseconds, Event/Category/Experimental stimulus, (Item/Natural scene/Arial/Satellite, Participant/Effect/Cognitive/Expected/Non-target, Sensory presentation/Visual/Rendering type/Screen/2D), Attribute/Onset

-Alternatively if the same HED tags apply to a group of events with the same `trial_type` they can be specified in the corresponding data dictionary (`_events.json` file) using the following syntax:

trial_type is defined here:
https://github.com/bids-standard/bids-specification/blob/master/src/04-modality-specific-files/03-task-events.md.
I see your point and I guess this uncovers another lack of clarity in the
current description - can one annotate any column from events.tsv with HED
tags in events.json or only trial_type? If the answer is any column this
needs to be clarified and could be part of this PR.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/bids-standard/bids-specification/pull/33#discussion_r223458627>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABIkugdCa6HY3wefWac6jPQ753Hh4nEuks5ui5lJgaJpZM4XJNpL>
.

The issue may be my understanding of trial_type as indicated by the example
in the spec. To me, this says that it is a condition.  Say we have an
experiment in which in one condition the subject is supposed to press a
button when they see a square and in another condition, they are just
supposed to think about pressing the button when they see a square.  The
trial itself consists of 3 standard event types (cue, square, maybe button
press) and possibly some other not connected events such as blink events.
All of the events in a given trial will have the same trial_type.  The
analyst might want to time-lock to any of these events (including blinks)
or use all of them (for temporal regression).   There is nothing in the
standard except the optional HED that will give an analyst any idea of the
what these events are. With the standard as it stands --- I would have no
idea what to do with the data.  It's almost as if there is an underlying
assumption that there will be only one event in each trial?
On Mon, Oct 8, 2018 at 4:24 PM Chris Filo Gorgolewski <
<EMAIL_ADDRESS>wrote:

Great - this is shaping very nicely.
Regarding your comment about unhappy analysts: I don't understand why you
would not be able to do look for time-locked responses to events with a
specific value of trial_type (or a custom column to be honest). It is
basically categorization of events and whether a time-locked analysis can
be done should depend on the design of the experiment.
It seems that you have a specific definition of event_type that is
different from trial_type. Would be good to know what is it precisely and
how does it differ from trial_type.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-427984018,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIkurwehvcuq7h48vKaM9gt0OJnwrGIks5ui8KKgaJpZM4XJNpL
.

I don’t see the problem with your example. The trial_type column will have 3 different values (“cue”, “square”, “maybe”) (or a 4th, “blink”), allowing the analyst to select the events of a desired type.
What values were you thinking trial_type would have?

With the standard as it stands --- I would have no idea what to do with the data.

With BIDS EEG we are introducing a new column called event_value. This marks a TTL marker value to an event. Then, there will be a json object in the corresponding _events.json which will map the TTL marker values to their meaning. Please read the BEP 006, which is very relevant to the HED discussion as well --> https://docs.google.com/document/d/1ArMZ9Y_quTKXC-jNXZksnedK2VHHoKP3HCeO5HPcgLE
Example for the events.tsv
onset    duration    trial_type    event_value
1.1    n/a    left    1
1.3    n/a    left    2
1.6    n/a    left    3
2.0    n/a    left    4
...

Example for the corresponding events.json
{
    "trial_type": {
        "LongName": "trial type",
        "Description": "Which hand was lifted by the participant.",
        "Levels": {
            "left": "Left hand was lifted",
            "right": "Right hand was lifted"
        }
    },
    "event_value": {
        "LongName": "event value",
        "Description": "Value of a TTL trigger that was sent to mark the event",
        "Levels": {
            "1": "onset of fixation cross",
            "2": "onset of stimulus",
            "3": "response of participant",
            "4": "feedback displayed",
        }
    }
}

I think that all the "infrastructure" we need for HED tagging the events is already present but might be a bit scattered across BEPs and the spec / or not adequately documented. This is also why this PR is important.

Stefan's example clears things up --- however, I think there is confusion about what trial_type can be. I read the EEG proposed extension and am basically happy with it, though there are several points that are not perfectly clear.
Does the BIDS standard allow the researcher to include as many additional named columns as they want and can those named columns can have optional maps to HED tags in the _events.json?   This would give the most flexibility.  Where should this be clarified?  Should there be examples?   When the EEG bids extension is adapted, will the event_value column be included in BIDS as a whole, or only when it pertains to EEG studies.

Does the BIDS standard allow the researcher to include as many additional named columns as they want?

Yes. As per https://github.com/bids-standard/bids-specification/blob/master/src/04-modality-specific-files/03-task-events.md "An arbitrary number of additional columns can be added."

Can those named columns can have optional maps to HED tags in the _events.json? This would give the most flexibility. Where should this be clarified? Should there be examples?

This is currently unclear, but I don't see why not. This could be clarified in this PR in the HED appendix. Examples will be useful.

When the EEG bids extension is adapted, will the event_value column be included in BIDS as a whole, or only when it pertains to EEG studies.

This is a bit of a separate discussion - I don't know what is the current scope of the EEG proposal.

@VisLab this seems to be close to ready to merge. Only a couple of clarifications and rebase to resolve conflicts left. Are there any outstanding questions we can help with?

I will make another pass at it tomorrow and let you know when it is ready.
On Thu, Oct 25, 2018 at 11:54 AM Chris Filo Gorgolewski <
<EMAIL_ADDRESS>wrote:

@VisLab https://github.com/VisLab this seems to be close to ready to
merge. Only a couple of clarifications and rebase to resolve conflicts
left. Are there any outstanding questions we can help with?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-433126829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIkuv-KTKXWm6xl4KaN76f8ZIIJH7koks5uoezFgaJpZM4XJNpL
.

Great! Thanks!
On Thu, Oct 25, 2018 at 10:47 AM VisLab<EMAIL_ADDRESS>wrote:

I will make another pass at it tomorrow and let you know when it is ready.
On Thu, Oct 25, 2018 at 11:54 AM Chris Filo Gorgolewski <
<EMAIL_ADDRESS>wrote:

@VisLab https://github.com/VisLab this seems to be close to ready to
merge. Only a couple of clarifications and rebase to resolve conflicts
left. Are there any outstanding questions we can help with?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-433126829
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABIkuv-KTKXWm6xl4KaN76f8ZIIJH7koks5uoezFgaJpZM4XJNpL
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-433143945,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkpxoWELntaK0BSn1yDgOuE96NZg2gks5uofk0gaJpZM4XJNpL
.

Okay, I think this is ready to merge unless you spot some issues.
On Thu, Oct 25, 2018 at 12:57 PM Chris Filo Gorgolewski <
<EMAIL_ADDRESS>wrote:

Great! Thanks!
On Thu, Oct 25, 2018 at 10:47 AM VisLab<EMAIL_ADDRESS>wrote:

I will make another pass at it tomorrow and let you know when it is
ready.
On Thu, Oct 25, 2018 at 11:54 AM Chris Filo Gorgolewski <
<EMAIL_ADDRESS>wrote:

@VisLab https://github.com/VisLab this seems to be close to ready to
merge. Only a couple of clarifications and rebase to resolve conflicts
left. Are there any outstanding questions we can help with?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/bids-standard/bids-specification/pull/33#issuecomment-433126829

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ABIkuv-KTKXWm6xl4KaN76f8ZIIJH7koks5uoezFgaJpZM4XJNpL

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-433143945
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAOkpxoWELntaK0BSn1yDgOuE96NZg2gks5uofk0gaJpZM4XJNpL
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/33#issuecomment-433147329,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIkuoHs4ydCWq3DSNU8PZGA92CrB7BQks5uofuGgaJpZM4XJNpL
.

I still see conflicts - could you rebase or merge master?

These suggestions look good to me.  It is good to go.  I would appreciate someone else doing the actual merge.  Thanks.

Thank you @VisLab.
I am pretty busy right now - @sappelhoff would you mind helping out and opening a new PR based on @VisLab branch but synced with master and with conflicts resolved. It would be a great help.


Support scheduelling systems

Is it possible to integrate DIGITS with a cluster schedueler like slurm?
For example, if you could have a local instance of the digits server running and then submit a job to the queue for training.
Similar to the way nvvp handles remote nodes.

We briefly considered using a tool built on top of nvidia-docker but had to abandon it for other priorities.

See related discussion at https://github.com/NVIDIA/DIGITS/issues/108.

A message queueing system might be nice indeed (rabbitmq/zmq), where workers can register themselves be assigned jobs. But that could turn into a docker bonanza and setting it up would not be as turn-key as it is now.


Application Error

The whole application seems to be down. Does this happen often? I'm teaching a React class and wanted to use webpackbin in the beginning to lower the threshold.

webpackbin 2  is coming soon:
https://github.com/cerebral/webpackbin/
https://webpackbin-test.firebaseapp.com/

Thanks for the info. I decided to use webpackbin in the class, and I think the students were happy with it. It crashed during the first assignment, but quickly got up on its feet again. After that, it worked perfectly. Can't wait for webpackbin2! It seems to have the features that I've sorely missed.


The library uses MD5 hashing algorithm, i need to change it to SHA512, any idea where to change it?

Hi ! Thank you for reporting an issue, but we would like to remind you, we have a trouble shooting page in our wiki.
You may want to take a look on that page or find issues tagged "trouble shooting" :p

please provide the version of installed library and RN project.
a sample code snippet/repository is very helpful to spotting the problem.
issues which have been tagged as 'needs feedback', will be closed after 2 weeks if receive no feedbacks.
issues lack of detailed information will be closed without any feedback

https://github.com/RonRadtke/react-native-blob-util/blob/e73e2791890fa02066ac89fb4cfaad7cfb47772c/android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtilFS.java#L906
In general we do support that, so you just need to specify the algorithm correctly whe calling the hash function


Removed cz fixing for comoving distances

When is_comoving_dist is set, cz is actually comoving distance, therefore fixing the inputs by speed of light doesn't make sense, as simplest resolution of this problem I don't set fix_cz then. Fixes #274.

@misharash Thanks for that. Do you mind adding an entry to the Changelog - something to the effect of "Only perform z vs cz check if co-moving distance is not set"
@lgarrison Good to merge?

Sure, added a line to the changelog under 2.5.0 fixes.

I'm traveling right now but will check this on Friday!
On Thu, May 12, 2022, 12:45 AM misharash @.***> wrote:

Sure, added a line to the changelog under 2.5.0 fixes.
—
Reply to this email directly, view it on GitHub
https://github.com/manodeep/Corrfunc/pull/275#issuecomment-1124524713,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLA7S2L3LB7PRPLBVQJ3I3VJSEFXANCNFSM5VTQOPHQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for the fix @misharash


Cycle Prohibited error

Trying to login with version 0.0.5 occasionally gives this error on Yahoo's end:
Cycle Prohibited
Description: Could not process your request for the document because it would cause an HTTP proxy cycle. Please check the URL and your browser's proxy settings.

The URL for this error page is: https://api.login.yahoo.com/oauth/v2/request_auth?oauth_token=b4nybbq
Refreshing the page (one or more times) usually resolves this. This error happens about 50% of the time. Other times, the login flow works completely fine.
Does it have anything to do with this gem using Oauth 1.0 flow on an OAuth V2 (as indicated in that URL) end-point?

Iam also facing the same problem
i am using hybrid auth
sometimes it will work sometimes Cycle Prohibited

Any progress?  I'm not using this gem myself any more, but if you guys send me your sample code I can take a look.

The error is happening because when we ask yahoo server for secret token it will send token sometime sometime error and since the error is coming from yahoo server we cannot do anything .

I had to switch to Yahoo's OpenID login because of this issue. With OpenID, I don't get access to user's data but at least my users don't experience this error while logging in. I noticed that Discourse also does the same.
There seems to be something wrong at Yahoo's end.

I have already implemented hybridauth in our website all other log-ins  are working gmail, hotmail etc but only yahoo has this problem , can yahoo look in to it and solve it ...

OK thanks.  I guess I'll close this issue for now then :)

dude the problem is there if u close it then people will think the problem is solved but it isn't solved login with yahoo with hybridauth will work sometime and sometime it wil not base on yahoo server some mechanism should be there to solve this error so the users don't face this error

am facing the same issue, if you guys found any solution please let me know.

its yahoo server problem yahoo has to handle the call to its server can anyone inform yahoo about this bug.

@Jollingeorge Do you know if yahoo got it sorted?
If anyone figures this out, please share here as well:
https://github.com/hybridauth/hybridauth/issues/651