feat: run jx secret populate earlier in boot sequence

Hi @chrismellard. Thanks for your PR.
I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

got this failure in gsm:
# populate secrets from filesystem definitions
VAULT_ADDR=https://vault.secret-infra:8200 -VAULT_NAMESPACE=secret-infra jx secret populate --source filesystem --secret-namespace secret-infra
# lets make sure all the namespaces exist for environments of the replicated secrets
/bin/sh: -VAULT_NAMESPACE=secret-infra: not found
make[1]: [versionStream/src/Makefile.mk:67: fetch] Error 127 (ignored)

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test kube

vault
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test kube

vault
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test vault

gsm
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test vault

gsm
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
568f8fa07ba7b909b82b1d6d9b421e3c6193eb9a
link
/test vault

gsm
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test gsm

tls
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test gsm

tls
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test tls

vault
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

so vault is failing in an expected way; its trying to populate vault before its deployed vault...
# populate secrets from filesystem definitions
VAULT_ADDR=https://vault.secret-infra:8200 VAULT_NAMESPACE=secret-infra jx secret populate --source filesystem --secret-namespace secret-infra
WARNING: failed to read field metadata.name for path docs/releases.yaml
WARNING: failed to read field kind for path docs/releases.yaml
waiting for vault pod vault-0 in namespace secret-infra to be ready...

so I guess we'll have to change the terraform to deploy vault first

Yep - I expect vault to fail so all good. Need to decide on how we structure that terraform module and I can make the required changes there. i.e. shared module vs. not

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test gsm

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test vault

gsm
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test vault

gsm
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
2f1dbce7d28f8f32dc0086f78b40fb21b60693cf
link
/test vault

gsm
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test gsm

tls
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test tls

vault
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test vault

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test tls

vault
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test vault

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test vault

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

tls
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
4ca7be65d6d81c5d1ad77adf9a6b275a7a5e6d22
link
/test vault

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

tls
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

tls
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test tls

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

tls
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test tls

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test tls

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

gsm
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test tls

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

gsm
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test tls

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

gsm
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

gsm
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test gsm

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test gsm

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

vault
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test gsm

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test gsm

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

vault
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test vault

kube
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test kube

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

vault
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test vault

kube
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test kube

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

I think kube is OK.
gsm seems to cause an issue we've seen from time to time; but the early external secrets seems to make it happen very frequently now; that Preview environments can't pull private images from GCR. I think its timing related with Workload Identity; creating namespace and then trying to access images quickly before the workload identity stuff has replicated or something.
vault is blocked with:
# lets wait for the ExternalSecrets service to populate the mandatory Secret resources
VAULT_ADDR=https://vault.jx-vault:8200 jx secret wait -n jx
waiting for the mandatory Secrets to be populated from ExternalSecrets...
jenkins-x-chartmuseum: key secret/data/jx/adminUser missing properties: password, username
jx-basic-auth-user-password: key secret/data/jx/basic/auth/user missing properties: password, key secret/data/jx/basic/auth/user/password missing properties: username
lighthouse-hmac-token: key secret/data/lighthouse/hmac missing properties: token
lighthouse-oauth-token: key secret/data/lighthouse/oauth missing properties: token
nexus: key secret/data/nexus missing properties: password
tekton-container-registry-auth: key secret/data/tekton/container/registry/auth missing properties: .dockerconfigjson
tekton-git: key secret/data/jx/pipelineUser missing properties: token, username

earlier in the pipeline it looks like its populating fine. I think its external secrets related - I see this in the log:
{"level":50,"time":1612346885020,"pid":17,"hostname":"kubernetes-external-secrets-75bd48dc68-l2rgz","payload":{"response":{"statusCode":400,"body":{"errors":["invalid role name \"secret-infra\""]}}},"msg":"failure while polling the secret jx/tekton-container-registry-auth"}

there are no role/rolebindings in the secret-infra namespace or clusterrole(binding) with containing "secret-infra"

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

kube
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test kube

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

kube
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test kube

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

gsm
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test gsm

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

vault
2a0d261f3f1aa036b837687f52b62fe5bd9b76fe
link
/test vault

gsm
43b4762dd0635adae3699edc126617b90b91824c
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
f894479231f34ba4de31e9ac7d1f0941c515f4ef
link
/test tls

gsm
43b4762dd0635adae3699edc126617b90b91824c
link
/test gsm

vault
43b4762dd0635adae3699edc126617b90b91824c
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
43b4762dd0635adae3699edc126617b90b91824c
link
/test gsm

vault
43b4762dd0635adae3699edc126617b90b91824c
link
/test vault

tls
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
43b4762dd0635adae3699edc126617b90b91824c
link
/test gsm

vault
43b4762dd0635adae3699edc126617b90b91824c
link
/test vault

tls
43b4762dd0635adae3699edc126617b90b91824c
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
43b4762dd0635adae3699edc126617b90b91824c
link
/test vault

tls
43b4762dd0635adae3699edc126617b90b91824c
link
/test tls

gsm
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
43b4762dd0635adae3699edc126617b90b91824c
link
/test vault

tls
43b4762dd0635adae3699edc126617b90b91824c
link
/test tls

gsm
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test gsm

kube
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
43b4762dd0635adae3699edc126617b90b91824c
link
/test vault

tls
43b4762dd0635adae3699edc126617b90b91824c
link
/test tls

gsm
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test gsm

kube
43b4762dd0635adae3699edc126617b90b91824c
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
43b4762dd0635adae3699edc126617b90b91824c
link
/test tls

gsm
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test gsm

kube
43b4762dd0635adae3699edc126617b90b91824c
link
/test kube

vault
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
43b4762dd0635adae3699edc126617b90b91824c
link
/test tls

gsm
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test gsm

kube
43b4762dd0635adae3699edc126617b90b91824c
link
/test kube

vault
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
6f08377638ad6cda70f4188a8ac8ddd67d6cca37
link
/test gsm

kube
43b4762dd0635adae3699edc126617b90b91824c
link
/test kube

vault
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test vault

tls
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
43b4762dd0635adae3699edc126617b90b91824c
link
/test kube

vault
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test vault

tls
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test tls

gsm
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test vault

gsm
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test gsm

tls
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
d6cb763c1e46d057d529b03d3863288487e8df3e
link
/test vault

tls
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test tls

gsm
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test tls

gsm
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test gsm

vault
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test tls

gsm
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test gsm

vault
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test tls

gsm
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test gsm

vault
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test tls

gsm
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test gsm

vault
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test gsm

vault
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test vault

tls
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
c48cfc052b2a816751e80cb1e5d269e69ee3ed16
link
/test gsm

tls
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test tls

vault
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test tls

vault
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test vault

gsm
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test tls

gsm
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test gsm

vault
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test tls

gsm
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test gsm

vault
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test tls

gsm
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test gsm

vault
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test tls

gsm
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test gsm

vault
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test vault

kube
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test tls

gsm
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test gsm

vault
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test vault

kube
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test gsm

kube
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test kube

vault
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
6405ebe612e0ce0bef925000b76e48b7f728897e
link
/test gsm

kube
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test kube

vault
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test kube

vault
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test vault

gsm
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test kube

gsm
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test gsm

vault
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test kube

gsm
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test gsm

vault
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test vault

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test kube

vault
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test vault

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
52de27808d517d4c911033ce4b9f7257a0126bb5
link
/test vault

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

/test tls

/test kube

/test gsm

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test gsm

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

kube
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test kube

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

/test tls

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test tls

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test vault

tls
ac3ffb2579791ba8cffa3522267b0b6dde729c80
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest


DNN-31325 : 'No search results' text shown although no search was performed.

Fixes #3184
Summary
Code change was the removal of showing the message when no search operation was a actually performed. Previously the code showed the message and stopped further processing. As of now it just does not show the message if no search is performed and also does no further processing.
Demo Video

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dinesh-jain-aurea sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This is targeting the development branch which targets Dnn 10. If you want to resubmit targeting release/9.4.x we could merge this sooner, if not it will only get merged for Dnn 10.

Closing this PR as this even though approved was created against "development". Created #3203 instead.


No way to have tab show as eight spaces, indent with something else

It does not appear to me that there is a way to make it so tabs show up as 8 spaces distinct from the actual indent size or tabs/spaces preference.
Pretty simple feature request, actually.  I have an existing codebase that I am converting over piecemeal to use 4 space indents.  Trouble is, the codebase is already full of a mixture of spaces and tabs which assumes that a tab character indents by 8 spaces, despite nominally having an indent of four spaces.  So you get fun horrors like:
····foo();
····if (bar) {
⭾       baz();
····}

It'd be nice to have it both ways.  VS Community seems to allow this, but I haven't found a combination of features that allows this in VS Code

Dup of #10339?

Yes, this is a duplicate.


module 'numpy' has no attribute 'int'

Hey there,
After painful local success installation of AICoverGen, I wasn't able to generate anything. When I hit Converting voice using RVC I immediately hit error:
"module 'numpy' has no attribute 'int'.
np.int was a deprecated alias for the builtin int. To avoid this error in existing code, use int by itself. Doing this will not modify any behavior and is safe. When replacing np.int, you may wish to use e.g. np.int64 or np.int32 to specify the precision. If you wish to review your current use, check the release note link for additional information.\nThe aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:\n https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations"
And there is traceback from console:
Traceback (most recent call last):
  File "D:\AICoverGen\src\main.py", line 275, in song_cover_pipeline
    voice_change(voice_model, main_vocals_dereverb_path, ai_vocals_path, pitch_change, f0_method, index_rate, filter_radius, rms_mix_rate, protect, crepe_hop_length, is_webui)
  File "D:\AICoverGen\src\main.py", line 187, in voice_change
    rvc_infer(rvc_index_path, index_rate, vocals_path, output_path, pitch_change, f0_method, cpt, version, net_g, filter_radius, tgt_sr, rms_mix_rate, protect, crepe_hop_length, vc, hubert_model)
  File "D:\AICoverGen\src\rvc.py", line 150, in rvc_infer
    audio_opt = vc.pipeline(hubert_model, net_g, 0, audio, input_path, times, pitch_change, f0_method, index_path, index_rate, if_f0, filter_radius, tgt_sr, 0, rms_mix_rate, version, protect, crepe_hop_length)
  File "D:\AICoverGen\src\vc_infer_pipeline.py", line 549, in pipeline
    pitch, pitchf = self.get_f0(
  File "D:\AICoverGen\src\vc_infer_pipeline.py", line 368, in get_f0
    f0_coarse = np.rint(f0_mel).astype(np.int)
  File "C:\Users\PinkiePie\AppData\Roaming\Python\Python39\site-packages\numpy\__init__.py", line 305, in __getattr__
    raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'int'.
`np.int` was a deprecated alias for the builtin `int`. To avoid this error in existing code, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `np.int`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\PinkiePie\AppData\Roaming\Python\Python39\site-packages\gradio\routes.py", line 442, in run_predict
    output = await app.get_blocks().process_api(
  File "C:\Users\PinkiePie\AppData\Roaming\Python\Python39\site-packages\gradio\blocks.py", line 1392, in process_api
    result = await self.call_function(
  File "C:\Users\PinkiePie\AppData\Roaming\Python\Python39\site-packages\gradio\blocks.py", line 1097, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "C:\Users\PinkiePie\AppData\Roaming\Python\Python39\site-packages\anyio\to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "C:\Users\PinkiePie\AppData\Roaming\Python\Python39\site-packages\anyio\_backends\_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
  File "C:\Users\PinkiePie\AppData\Roaming\Python\Python39\site-packages\anyio\_backends\_asyncio.py", line 807, in run
    result = context.run(func, *args)
  File "C:\Users\PinkiePie\AppData\Roaming\Python\Python39\site-packages\gradio\utils.py", line 703, in wrapper
    response = f(*args, **kwargs)
  File "D:\AICoverGen\src\main.py", line 293, in song_cover_pipeline
    raise_exception(str(e), is_webui)
  File "D:\AICoverGen\src\main.py", line 81, in raise_exception
    raise gr.Error(error_msg)
gradio.exceptions.Error: "module 'numpy' has no attribute 'int'.\n`np.int` was a deprecated alias for the builtin `int`. To avoid this error in existing code, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `np.int`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information.\nThe aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:\n    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations"
2023-08-27 11:39:25 | INFO | httpx | HTTP Request: POST http://<IP_ADDRESS>:7860/api/predict "HTTP/1.1 500 Internal Server Error"
2023-08-27 11:39:25 | INFO | httpx | HTTP Request: POST http://<IP_ADDRESS>:7860/reset "HTTP/1.1 200 OK"

Could be that fixed?
I am using Windows 11, 22621.1413 build with Python 3.9.13.
And I want to do it more locally as I do not support Google Services at all, so I prefer local over cloud. And I have even good GPU (RTX 3070), kinda powerful, so I guess it can run pretty good.
Thanks

If your current version of numpy is not 1.23.5, you can try pip uninstalling numpy and installing numpy==1.23.5.

Okay, thank you so much for that tip.
Even though I have to do it like 3 or 4 times and it started to work somehow.
Can be now closed, at it is fixed.


/home/user/.zshenv:5: command not found: rustc

Error as title: /home/sugar/.zshenv:5: command not found: rustc
I installed rust with modify path: y and checked with print $path and observed /home/user/.cargo/bin in first elemnt of $path array. So I have no clue why rustc is not found. Also tried to add .cargo/bin in .zshrc instead of .zshenv but also didn't work.

I asked in unix.stackexchange.com: https://unix.stackexchange.com/q/466685/256195 and at the end even modify path is yes we still have to put ~./cargo/bin in path in front of RUST_SRC_PATH=$(rustc --print sysroot)/lib/rustlib/src/rust/src/ in .zshenv.
Note even RUST_SRC_PATH in .zshrc still error so maybe modify path at the begining of .zshrc or end of .zshenv is good idea.

Good to know. Thanks :)


CORS configuration doesn't work on Module, only by Mapping

Describe the bug
CORS configuration applies correctly by mapping but not globally by module.
To Reproduce
Steps to reproduce the behavior:

Apply the following ambassador module

apiVersion: getambassador.io/v2
kind: Module
metadata:
  name: ambassador-global-config
spec:
  config:
    buffer:
      max_request_bytes: 22020096 #21MiB
    cors:
      origins: '*'
      methods: "GET, PUT, POST, DELETE, HEAD, OPTIONS"
      headers: "Origin, Content-Type, Accept, Authorization, X-Request-With, X-GENERAL-TOKEN"
      credentials: true
      max_age: 86400

Send correct OPTIONS request to one of the services

Expected behavior
Ambassador replies to this pre-flight request correctly and doesn't route the request to the backend service.
Versions (please complete the following information):

Ambassador: 1.4.3 (Helm Chart 6.3.5)
Kubernetes environment: Google Kubernetes Engine
Version: 1.14.10-gke.27

Additional context
The same YAML applied per mapping works correctly

I am seeing the same problem. It works as a mapping, but not as a module+ingress.

AES(Ambassador): 1.5.0 (Helm Chart 6.4.1)
Kubernetes: 1.18.2

I wonder if this is related to https://github.com/datawire/ambassador/issues/2283

Having this issue myself.  Anyone else?

Also just saw this; if I only have cors settings at the Module level, OPTIONS requests are sent upstream (resulting in a 404 since we didn't implement those routes). If I have cors settings at the Mapping level ambassador responds with a 200.

Yes, I'm seeing this too.  Tried multiple settings at mapping level.

This issue seems to appear for me starting with version 1.11.2.

The issue still exists with the v3alpha1 version of the Module resource as of emissary-ngress v2.2.2.

Why this so sad...

I'm try on module with v2.2.2 and this is config
  cors:
    origins: http://localhost:8000
    methods: POST, GET, OPTIONS
    headers: Content-Type
    credentials: true

and result of envoy config with
"cors": {
                                "allow_credentials": true,
                                "allow_headers": "Content-Type",
                                "allow_methods": "POST, GET, OPTIONS",
                                "allow_origin_string_match": [
                                  {
                                    "exact": "h"
                                  },
                                  {
                                    "exact": "t"
                                  },
                                  {
                                    "exact": "t"
                                  },
                                  {
                                    "exact": "p"
                                  },
                                  {
                                    "exact": ":"
                                  },
                                  {
                                    "exact": "/"
                                  },
                                  {
                                    "exact": "/"
                                  },
                                  {
                                    "exact": "l"
                                  },
                                  {
                                    "exact": "o"
                                  },
                                  {
                                    "exact": "c"
                                  },
                                  {
                                    "exact": "a"
                                  },
                                  {
                                    "exact": "l"
                                  },
                                  {
                                    "exact": "h"
                                  },
                                  {
                                    "exact": "o"
                                  },
                                  {
                                    "exact": "s"
                                  },
                                  {
                                    "exact": "t"
                                  },
                                  {
                                    "exact": ":"
                                  },
                                  {
                                    "exact": "8"
                                  },
                                  {
                                    "exact": "0"
                                  },
                                  {
                                    "exact": "0"
                                  },
                                  {
                                    "exact": "0"
                                  }
                                ],

But it's works fine on mappings config.

@LukeShu Did you think some lines around here will create a bug with Module ?
        # 'origins' cannot be treated like other keys, because we have to transform it; Envoy wants
        # it in a different shape than it is in the CRD.
        origins = kwargs.get('origins', None)
        if origins is not None:
            new_kwargs['allow_origin_string_match'] = [{'exact': origin} for origin in origins]

I confirmed this still broken on v2.3.2 too.

Thanks for that suggestions, @mrnonz .  We'll check it on our end.

No it's not working. I've tested 3.4.0

No it's not working. I've tested 3.4.0

How about v3.9.0? that still occur right?


bug in opening 3D matrix

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "/Users/zenko/Documents/OPT/anaconda3/lib/python3.6/site-packages/spyder/widgets/variableexplorer/collectionseditor.py", line 449, in createEditor
if not editor.setup_and_check(value, title=key, readonly=readonly):
File "/Users/zenko/Documents/OPT/anaconda3/lib/python3.6/site-packages/spyder/widgets/variableexplorer/arrayeditor.py", line 619, in setup_and_check
self.data.flags.writeable = True
ValueError: cannot set WRITEABLE flag to True of this array
Version and main components

Spyder Version: 3.2.6
Python Version: 3.6.3
Qt Versions: 5.6.2, PyQt5 5.6 on Darwin

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.25.0 (OK)
numpy >=1.7      :  1.16.4 (OK)
sphinx >=0.6.6   :  1.6.6 (OK)
rope >=0.9.4     :  0.10.7 (OK)
jedi >=0.9.0     :  0.11.1 (OK)
psutil >=0.3     :  5.4.3 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.27.3 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.2.1 (OK)
pylint >=0.25    :  1.8.2 (OK)

This is fixed in our latest version. Please update by opening Terminal.app and running there
conda install spyder=3.3.6

I still have the same problem, despite the fact that I updated the version.
Do you need more information? or the message error that pops up?
best,
VZ
Le mer. 6 nov. 2019 à 19:25, Carlos Cordoba<EMAIL_ADDRESS>a
écrit :

Closed #10628 https://github.com/spyder-ide/spyder/issues/10628.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/10628?email_source=notifications&email_token=ANWLKRMXKDE7YDC2KSWQQBTQSMDXXA5CNFSM4JJZDWFKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUV6GJFQ#event-2776392854,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANWLKRK7XMLMWNGWMW3MPMTQSMDXXANCNFSM4JJZDWFA
.

That's not possible. Please verify that Spyder is at version 3.3.6 or install it in a different environment if necessary.

I am a beginner with Python and programming in general. So, when I install
the 3.3.6 version in the terminal, the last step shows
Proceed ([y]/n)?.... What am I supposed to do here? and how do I know in
which environment is the new version installed?
Le jeu. 7 nov. 2019 à 17:34, Carlos Cordoba<EMAIL_ADDRESS>a
écrit :

That's not possible. Please verify that Spyder is at version 3.3.6 or
install it in a different environment if necessary.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/10628?email_source=notifications&email_token=ANWLKRO27QHBYZVXCFQOXUDQSQ7QZA5CNFSM4JJZDWFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDNAG3A#issuecomment-551158636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANWLKRLSNCIGR4CGJDKP3CLQSQ7QZANCNFSM4JJZDWFA
.

Hello,
it's all good, I fixed the problem.
Many thanks for the help.
Best regards,
VZ
Le jeu. 7 nov. 2019 à 21:02, vjollca zenko<EMAIL_ADDRESS>a
écrit :

I am a beginner with Python and programming in general. So, when I install
the 3.3.6 version in the terminal, the last step shows
Proceed ([y]/n)?.... What am I supposed to do here? and how do I know in
which environment is the new version installed?
Le jeu. 7 nov. 2019 à 17:34, Carlos Cordoba<EMAIL_ADDRESS>a
écrit :

That's not possible. Please verify that Spyder is at version 3.3.6 or
install it in a different environment if necessary.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/10628?email_source=notifications&email_token=ANWLKRO27QHBYZVXCFQOXUDQSQ7QZA5CNFSM4JJZDWFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDNAG3A#issuecomment-551158636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANWLKRLSNCIGR4CGJDKP3CLQSQ7QZANCNFSM4JJZDWFA
.


List repository tree implementation

See https://github.com/gitlabhq/gitlabhq/blob/master/doc/api/repositories.md#list-repository-tree
Tests included.

Many thanks for this.
This project was "on hold" for some time, but now were back ;)


Add  transitionOnUserGestures to true on SnackBar for back swipe

Fixes https://github.com/flutter/flutter/issues/100782
Before :
https://user-images.githubusercontent.com/9378033/160168461-a3af92b2-377f-4570-85b9-b60eab5dd3a5.mp4
With this PR :
https://user-images.githubusercontent.com/9378033/160168566-3d36aa34-794d-4694-8f47-2e5ea8f330f8.mp4
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I've added some documentation but I was not sure how to explain this behavior shortly. Let me know how to improve the documentation if it's not ok.

Oh! We need a secondary review, I will find another reviewer.

Yeah it looks like it got stuck, I checked and it passed. Merging manually.


ARXIVNG-983 Support searches for seven-digit arXiv ID partials

The arXiv ID partial ("papernum") detection is stricter than in the classic search but unlike classic search, if a papernum is detected the query is not limited to the paper ID field. In other words, if a user enters what looks like a papernum in the "all fields" search, that term will actually get queried across all fields.

Coverage increased (+0.01%) to 82.355% when pulling 9e29adc243964a37a33dbfc7ac838c1d2b07e03e on ARXIVNG-983 into b8b2e97581387c8d22306682f6ae2fd371a21761 on develop.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

merge


Training - Hands-on Labs & Activities

Hands-on Labs & Activities:

[x] Hands-on Labs Setup
[x] Module 1: Introduction to GitHub Actions
[x] Module 2: Syntax
[x] Module 3: Environments and Secrets
[x] Module 4: Workflow Templates
[ ] Module 5: Custom actions
[ ] Module 6: Self-hosted runners
[ ] Module 7: CI/CD

taco


Add more repo search tests and /api/repo/search integration tests

Add some more tests. Also fixes #2446.
Two integration tests will not pass with current implementation of repo search api because it doesn't return all repositories accessible to user if he is not logged or is different from logged user

CI failed.

@lunny I told you it will and why.
I've added 8 new repositories to tests, 4 (2x public, 2x private) are owned by user15, 2 (1x public, 1x private) owned by user16 and user15 is collaborator in both of them and 2 repositories (1x public, 1x private) owned by organization which is owned by user15. That means if you search for public repositories accessible (and related) to user15, you should get 4 public repositories (2 owned by user15, 1 owned by user16 and 1 owned by organization he owns).
You should get only public (directly owned or accessible + related by any other non-private rules) repositories of user if it is anonymous search or logged user is different to that user. Am I thinking right?

Fixed tests and added 2 new tests for pages and pagesize limit

Tests failed as expected with current implementation of api and repo search function. I've done tests with #2371 and it will pass these new tests (#2371 rebased on this PR can be found in test-repo-search-implementation).

Merged to #2371.


fine-tune the cross encoder to rerank tools

Why don't you fine-tune the cross encoder for the tool retrieval task? Have you tried it? I have tried fine-tuning the cross encoder for the tool reranking task, but it performs very poorly, mostly resulting in false negatives.

We haven't tried it.


Add to and from XContent to ClusterBlock and ClusterBlocks

Description
We need to upload the ClusterBlocks object to remote to enable the cluster state publication flow from remote. To do that we need to parse ClusterBlocks object to and from XContent.
Related Issues
Resolves #13692

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
~- [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
[x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Created a new issue for unrealted failing test org.opensearch.common.cache.stats.DefaultCacheStatsHolderTests.testConcurrentRemoval - #13695

Failing test already identified as flaky
org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards - #10152

❌ Gradle check result for https://github.com/opensearch-project/OpenSearch/commit/d69ae202b4d1849b3832edddce88fd8bbf796174: FAILURE

#11979

https://github.com/opensearch-project/OpenSearch/pull/13576#issuecomment-2155375388


Nanoshooter Roadmap

We need a well defined story map for Nanoshooter's future, that we can decompose into open work issues.

0.0.0
0.1.0
0.2.0

Cover this in the wiki.

Roadmap is on Trello.


Prepend https:// to supporter website if it doesn't exist already

The front page's supporters section has a lot of broken links where donors forgot to add a scheme in front of their domain of their website. All the links not containing schemes are broken.
This PR prepends a https:// scheme in front of the website URL's that need it.

@xdamman Do you think this could be solved in OpenCollective website?

Good idea. Anyone up to do a quick pull request to the Open Collective codebase?
This would be the place to do it: https://github.com/opencollective/opencollective-api/blob/master/server/models/Collective.js#L190-L199

Done. That's a much better place to fix it. Closing this PR

Thanks @Munter !


Add language server extension "ballerinaProject"

Purpose
This extension handles requests related to a whole ballerina project.
Currently the only request is "modules" which returns ASTs of all the modules the project contains.
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #15599 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #15599      +/-   ##
============================================
- Coverage      12.3%   12.23%   -0.08%
  Complexity     1579     1579
============================================
  Files           934      943       +9
  Lines         36205    36389     +184
  Branches       5244     5261      +17
============================================
- Hits           4456     4453       -3
- Misses        31264    31451     +187
  Partials        485      485

Impacted Files
Coverage Δ
Complexity Δ

...llerina/document/BallerinaDocumentServiceImpl.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../extensions/ballerina/project/ModulesResponse.java
0% <0%> (ø)
0 <0> (?)

...lerinalang/langserver/BallerinaLanguageServer.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../langserver/extensions/VisibleEndpointVisitor.java
0% <0%> (ø)
0 <0> (?)

...r/extensions/ballerina/project/ModulesRequest.java
0% <0%> (ø)
0 <0> (?)

...ballerina/project/BallerinaProjectServiceImpl.java
0% <0%> (ø)
0 <0> (?)

...main/java/org/ballerinalang/net/http/HttpUtil.java
31.62% <0%> (-0.29%)
79% <0%> (ø)

...ain/java/org/ballerinalang/net/http/BHttpUtil.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...erinalang/net/http/actions/httpclient/Execute.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...nalang/net/http/nativeimpl/connection/Respond.java
20.51% <0%> (ø)
3% <0%> (ø)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b720a...cbd33e5. Read the comment docs.


Implementation of OPCR1

Hello,
I have written an implementation for the OPC-R1. I have tested methods: on(), off(), histogram() and reset(). I have not yet tested the other methods.
Would it be possible to publish it?
With best wishes,
Florentin.

Coverage decreased (-2.3%) to 13.676% when pulling edd78addce9ca827342b241e570881319e0cb7db on FlorentinBulotUoS:master into 2c8f19530fb64bf5fd4ee0d694a47850161ed8a7 on dhhagan:master.

Coverage decreased (-2.3%) to 13.676% when pulling edd78addce9ca827342b241e570881319e0cb7db on FlorentinBulotUoS:master into 2c8f19530fb64bf5fd4ee0d694a47850161ed8a7 on dhhagan:master.

I do not know much about code coverage. Do you have a script with unit testing that I should add methods to ?

Hi @FlorentinBulotUoS - don't worry about the code coverage - hardware products are difficult to test in this way (at least in my experience). I'll check the code and merge the PR after my committee meeting today. Thanks!

Hi @dhhagan,
Let me know if there is any issue with the code for me to fix.
With best wishes.

Hey @FlorentinBulotUoS I will do my best to get to this tonight/tomorrow - currently swamped trying to finish up a manuscript...

Hey @FlorentinBulotUoS Thanks so much for this work - I'm almost done going through it and will give any feedback if needed, otherwise I will merge it in to master. If possible, it would be ideal to have more than 1 person test it before the actual release to pip - do you know of anyone else who could test it? If not, I can try to reach out to Alphasense...

Hi @dhhagan, thanks a lot for going through the code.
I will check with one of my colleague who may be able to test it on Friday. I have sent the code to Alphasense last week but I have not heard back from them yet (although I have not asked them explicitly if they could test it...).

Hi @dhhagan, sorry for the late answer. I have done the changes you have requested. The code has not been tested yet by somebody other than me.
Let me know if everything is fine with it.
Kind regards

Hi @dhhagan,
I have fixed a couple of issues that appeared while running the code for an extended period of time on multiple OPCR1. I have also fixed the read_config() and pm() methods which were broken. I was wondering if you could merge it with the master so people can test it?
Thanks a lot,
With best wishes.

Hi there,
I was looking for the OPC-N3 implementation. You are talking about the OPC-R1, which on the product page is mentioned in the last alinea. They switch from OPC-N3 to OPC-R1. This is the same device?
I have 6 of them here up for testing and will look at code and lab results if we are indeed talking about the same device.
cheers

Hi @Smeedy ,
The OPC-R1 and the OPC-N3 are two different models. The OPC-N3 is more expensive and can measure particles <40um diameter while the OPC-R1 measures particles <10um.
I do not know whether they use the same commands though so I am not sure whether the implementation of the OPC-R1 will work for the OPC-N3. I do not have any OPC-N3 to test it so I cannot tell you more.
I hope that helps,
With best wishes

Dear contributors,
Just to let you know that I needed to reference the software for the OPC-R1 so have made a release of my fork for the OPC-R1 and have obtained a DOI for it: https://zenodo.org/record/3571966
I have used the information I had on GitHub about each of you. Let me know if you want me to edit your details on the DOI (names, ORCID and affiliations).
With best wishes,
Florentin.

I am trying to use Florentin's code in Python3 on a pi zero. It is returning false on alpha.on(). Would anyone have any suggestions on what I should check to figure out if it is working?


handleSilentRefresh does not start the checkAccessToken loop

Hi,
I also posted about this in discord. handleSilentRefresh never gets the ball rolling on checkAccessToken.
Here is the diff that solved my problem:
diff --git a/node_modules/lucia-sveltekit/client.js b/node_modules/lucia-sveltekit/client.js
index cecee87..5c5d82b 100644
--- a/node_modules/lucia-sveltekit/client.js
+++ b/node_modules/lucia-sveltekit/client.js
@@ -94,6 +94,8 @@ export const handleSilentRefresh = (errorHandler = () => { }) => {
             }
         }, 5000);
     };
+    checkAccessToken();
+
     const refresh = async (session) => {
         if (!session)
             return;

This issue body was partially generated by patch-package.

I have no idea how I missed that, thanks for pointing that out. Will be fixed with v0.10.0 (which might take a while)

I'll fix this in a separate update if v0.10.0 is going to take some time to finish

Fixed with v0.10.0


BIDS community review for BEP030: Near Infrared Spectroscopy

The BIDS community is preparing to merge the BIDS Extension Proposal 30 (BEP030) for Near Infrared Spectroscopy (NIRS). The updated draft is available for review at:
https://bids-specification.readthedocs.io/en/bep030/04-modality-specific-files/11-functional-near-infrared-spectroscopy.html
Note that the content of that HTML page may change as suggestions are accepted during the review process.
Comments and suggestions may be submitted on GitHub at:

https://github.com/bids-standard/bids-specification/pull/802

The community review will close on Wednesday (Sept 14th) at 23:59 UTC.
If no larger issues occur, all open comments and suggestions will be resolved in the following days and merged into the BEP. Afterwards, the BEP will be merged into the BIDS specification, followed by a 5-business-day long feature freeze and the release of BIDS 1.8.0 (then containing NIRS as a modality, among several more minor changes as documented in the BIDS changelog).
For more details on the release protocol, please see:
https://github.com/bids-standard/bids-specification/blob/da68bd9543f597a1019ad68e14dffe14a6f45e35/Release_Protocol.md?plain=1#L1
We look forward to hearing your feedback!
The BIDS maintainers

@rob-luke @lpollonini please feel free to share this widely among the NIRS community :rocket:


git-credential-gopass not working

Summary
According to the description, git-credential-gopass should be configured as follows:
git config --global credential.helper gopass
However, when I push something to a private repo after configuration I get the error message: git: 'credential-gopass' is not a git command. See 'git --help'.
Steps To Reproduce

Install and init gopass
Install git-credential-gopass
Run the command: git config --global credential.helper gopass
Push something to a private repo

Expected behavior
git-credential-gopass should cache the git credentials.

All my git repos use the ssh support.
Maybe someone who does use it can help here.

Hi
I'm using the git-credentials with gopass at a regular basis.
I tried to reproduce your problem in a clean VM, but failed.
One thing that pops into my mind with that error, is that either gopass or git-credentials-gopass isn't in your $PATH.


Add poethepoet to the development dependencies

Feature Request
At the development guide: https://starknetpy.readthedocs.io/en/latest/development.html there are poe commands but there is no mention about poethepoet at dependencies.

Hi, there is a mention of poethepoet in pyproject.toml, but in the dev section. The commands should work after invoking poetry install.

I am not sure what was the issue but poetry install didn't install poe for me. After manually installing poe I am able to use poe commands.

What is your computer and operating system (and is it by any chance MacBook with M1/2 processor)?

It was debian 11 droplet from digital ocean.


Turning with joystick when on boat is very abrupt?

Hi, on Steam Deck here. Loving this mod, it works really well! I'm just having a small issue and considering Ive seen no reports about it, I'm wondering if something is just wrong on my side?
When using boats, turning is extremely abrupt... It's like if suddenly, my left joystick is mimicking WASD controls. The boat will not turn until I push the joystick almost completely left, and then it starts turning on itself in a circle, until I push the stick completely forward again.
However, when I'm just walking, the joystick works fine as intented, I can smoothly turn / walk diagonally without issue.
Is this known, or is something wrong on my side? This makes boats extremely hard to control
Thank you!

Might be linked to #135?


one-line config for using rust-lld

Problem
I'm thinking of if it is possible to use rust-lld installed by rustup component add llvm-tools-preview using a one-line config like linker=rust-lld. Currently configuring it on macOS is relatively hard.
Basically what I'm doing now is like:
rustflags = [
    "-Clink-arg=-fuse-ld=/Users/skyzh/.rustup/toolchains/nightly-2022-10-16-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/bin/gcc-ld/ld64.lld",
]

Probably we can do something to make the configuration easier?
Proposed Solution
If linker = 'rust-lld' in config.toml, we can automatically generate the args for rustc by appending
 "-Clink-arg=-fuse-ld=${RUSTUP_TOOLCHAIN_PATH}/lib/rustlib/${ARCH}/bin/gcc-ld/ld64.lld"

to rustflags, so that we can easily use the rust-lld linker installed with rustup.
Notes
No response

Adding a -Clinker-flavor=rust-lld option for rustc may be a better design?


Clean up, document and refactor

:tada: This issue has been resolved in version 1.0.0-dev.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[SPARK-43137][SQL] Improve ArrayInsert if the position is foldable and equals to zero.

What changes were proposed in this pull request?
Currently, Spark supports the array_insert and array_prepend. Users insert an element into the head of array is common operation. Considered, we want make array_prepend reuse the implementation of array_insert, but it seems a bit performance worse if the position is foldable and equals to zero.
The reason is that always do the check for position is negative or positive, and the code is too long. Too long code will lead to JIT failed.
Why are the changes needed?
Improve ArrayInsert if the position is foldable and equals to zero.
Does this PR introduce any user-facing change?
'No'.
Just change the inner implementation.
How was this patch tested?
Exists test cases.

ping @infoankitp @navinvishy cc @cloud-fan

https://github.com/apache/spark/pull/40833 merged, so close this one.


Support method / object callbacks instead of class name

Thanks for nice piece of software.
I have just started using MockServer I love it however I feel I miss one feature. While mocking I'm able to specify HttpCallback which will be executed on server invocation. However HttpCallback may contain only class name. For some use cases I would like something more dynamic. I wonder if you considered allowing to put instance rather than class into HttpCallback so user could define behavior more dynamically.
That would be more similar to Mockito's when(something).thenAnswer(code_to_execute_here)
What do you think?

The problem with this is that the expectation is serialised to the server using JSON.  Typically the server runs as a separate process and so has no access to local objects.  So currently there is no way to support executing an instance object.
What you can do as a work around is make sure the MockServer is running in the same JVM by using the API such as ServerAndClient then use static methods.  However, this is pretty much a hack that I don't recommend as you would have no test separation.
I'm going to close this ticket as it is not possible due to limitation in Java.

However I could implement this using web sockets, so I'll re-open this ticket and implement it when I get a chance.

You are right. I missed the fact that everything goes through the wire even when we use junit Rule and server runs inside the same JVM process. Websockets is nice solution for that. We simply need a way to invoke code on MockServerClient's side and pass created response back to server. I see also other option here (very similar to websockets) - expose some kind of server endpoint on client side (could be HTTP server).
When API user records behavior (creates expectations) with instance of given interface (similar to ExpectationCallback) client could assign unique identifier and map this unique identifier to that expectation instance. That unique id could be later passed to server and then server finds that should invoke expectation it calls client giving id and gets HttpResponse back. This is how I see that now.
Thank you for quick response.

For now I think web sockets is the best approach as it works really nicely in Netty which is used for both the client and the server.  I've previously implemented web sockets with Netty before and they provide a really solid and simple implementation.

When using MockServer via the JUnit MockServerRule, is everything running in the same JVM such that passing a ExpectationCallback instance would be possible? In Spock tests, this would be quite powerful, as a Closure could be used to implement the callback...

Although when using the MockServerRule everything is running in the same JVM. The MockServer is running in a separate set of threads managed by Netty and so it wouldn't be immediately straight forward to pass a closure in.  In the next couple of weeks I'll start implementing a WebSocket approach as this would likely be the simplest solution even in the same JVM and would additionally work when the MockServer was in another JVM.  I just need to improve the Ruby client and finish improving the web site / documentation then this issue is next on the list.

May be we can also extend HttpCallback to include some kind of tag-id (or callback-id) - it will help to distinguish requests on server side with same callback (and callback will be able to use static map to get proper responce).

Yes exactly the server may need to maintain a list (probably UUIDs) against WebSocket to know which socket to call back on.  Alternatively it may also be possible avoid any hash map / lookup table and if the objects can be structured correctly.
I'm just working on updating the documentation, once this is completed and the ruby client is fixed this is the next item on the list, and is likely to be completed in the next month or so.

Some additional information about my use-cases. Maybe it will be helpful (or just interesting :) )
I use gridkit (https://github.com/gridkit/nanocloud) to instantiate MockServer on a per test basis.
Sometimes I need to do some external things on http-request (drop some other service, change state of components, etc).
On different http-requests it can be different external tasks.
Currently I forced to create new callback classes for each task: I am using javassist to create classes with common superclass and static Map<Class, Runnable> to specify callback behavour on a per-class basis.
public class ExpectationCallbackImpl implements ExpectationCallback {
    private static final Map<Class, RequestAndCallbackAndResponse> requestToResponse = new ConcurrentHashMap<>();

    @Override
    public HttpResponse handle(HttpRequest httpRequest) {
        final RequestAndCallbackAndResponse callbackAndResponse = requestToResponse.get(this.getClass());
        callbackAndResponse.callback.run();
        return callbackAndResponse.getResponse();
    }

public void invokeCallbackAndRespond(final HttpResponse httpResponse, final RemoteRunnable callback) {
            final ExpectationCallbackImpl.RequestAndCallbackAndResponse remoteCallback = new ExpectationCallbackImpl.RequestAndCallbackAndResponse(request, httpResponse, callback);

            final String callbackClass = node.exec(new Callable<String>() {
                @Override
                public String call() throws Exception {
                    // create new class
                    ProxyFactory factory = new ProxyFactory();
                    factory.setSuperclass(ExpectationCallbackImpl.class);
                    Class c = factory.createClass();

                    // register callback
                    ExpectationCallbackImpl.addCallback(c, remoteCallback);

                    //return class name
                    return c.getName();
                }
            });
            client.when(request).callback(new HttpCallback().withCallbackClass(callbackClass));
        }

thanks code examples are always used to fully understand how people use things.
The original use case for the callback class was completely different and it only required a single static class, but it should be possible to extend it to cover your requirements.
I'll implement it so the object instance you pass in will have to implement a Single Abstract Methods (SAM) interface (i.e. interface with a single method).  This will mean those using Java 6+ can just implement the interface and those using Java 8+ can pass in a closure if they like.  Even though MockServer is compiled with Java 6 for maximum support this approach should make the API nice for those using Java 8.

Note: see #160 and make sure the solution uses WebSockets so that function callbacks can be used from JavaScript in browser or node.js

@jamesdbloom any update on this ? are you planning to complete this anytime soon ?

The dynamic callback have been completed, except the following items:

ruby client support (although the ruby client will be completely re-written, asap)
performance testing (not tested supporting 100s of simultaneous dynamic callback handlers, this would result in 100s of open WebSockets and need to confirm this will scale safely)
documenting feature on website
adding new examples to the mockserver-examples project

Neither of these two remaining items will change the API and so it should be safe to use this functionality.  The Java, browser javascript and node javascript clients all support it now, as follows:
Java
import org.junit.Rule;
import org.junit.Test;
import org.mockserver.client.server.MockServerClient;
import org.mockserver.junit.MockServerRule;
import org.mockserver.mock.action.ExpectationCallback;
import org.mockserver.model.HttpRequest;
import org.mockserver.model.HttpResponse;

import static java.util.concurrent.TimeUnit.SECONDS;
import static org.mockserver.matchers.Times.exactly;
import static org.mockserver.model.HttpRequest.request;
import static org.mockserver.model.HttpResponse.response;
import static org.mockserver.model.StringBody.exact;

/**
 * @author jamesdbloom
 */
public class DynamicMethodCallback {

    @Rule
    public MockServerRule mockServerRule = new MockServerRule(this);

    private MockServerClient mockServerClient;

    @Test
    public void doSomethingJava7() {
        mockServerClient
                .when(
                        request()
                                .withMethod("POST")
                                .withPath("/login")
                                .withQueryStringParameter(
                                        "returnUrl", "/account"
                                )
                                .withCookie(
                                        "sessionId", "2By8LOhBmaW5nZXJwcmludCIlMDAzMW"
                                )
                                .withBody(exact("{username: 'foo', password: 'bar'}")),
                        exactly(1)
                )
                .callback(
                        new ExpectationCallback() {
                            public HttpResponse handle(HttpRequest httpRequest) {
                                return response()
                                        .withStatusCode(401)
                                        .withHeader(
                                                "Content-Type", "application/json; charset=utf-8"
                                        )
                                        .withHeader(
                                                "Cache-Control", "public, max-age=86400"
                                        )
                                        .withBody("{ message: 'incorrect username and password combination' }")
                                        .withDelay(SECONDS, 1);
                            }
                        }
                );
    }

    @Test
    public void doSomethingJava8() {
        mockServerClient
                .when(
                        request()
                                .withMethod("POST")
                                .withPath("/login")
                                .withQueryStringParameter(
                                        "returnUrl", "/account"
                                )
                                .withCookie(
                                        "sessionId", "2By8LOhBmaW5nZXJwcmludCIlMDAzMW"
                                )
                                .withBody(exact("{username: 'foo', password: 'bar'}")),
                        exactly(1)
                )
                .callback(
                        (HttpRequest httpRequest) -> response()
                                .withStatusCode(401)
                                .withHeader(
                                        "Content-Type", "application/json; charset=utf-8"
                                )
                                .withHeader(
                                        "Cache-Control", "public, max-age=86400"
                                )
                                .withBody("{ message: 'incorrect username and password combination' }")
                                .withDelay(SECONDS, 1)
                );
    }
}

Javascript
mockServerClient("localhost", 1080).mockWithCallback(
    {
        'method': 'GET',
        'path': '/two'
    },
    function (request) {

        // some callback logic

        if (request.method === 'GET' && request.path === '/two') {
            return {
                'statusCode': 202,
                'body': 'two'
            };
        } else {
            return {
                'statusCode': 406
            };
        }
    }
)
.then(
    function () {

        // expectation setup now test something

    },
    function (error) {

        // failed to setup expectation

    }
);

FYI your'll need to use mockserver-netty version 3.10.7<EMAIL_ADDRESS>or the latest docker container

Hello @jamesdbloom,
Your previous DynamicMethodCallback example for Java works fine for me. However, if I add a subsequent verification to your example, it fails:
mockServerClient
                .verify(
                        request()
                                .withMethod("POST")
                                .withPath("/login"),
                        VerificationTimes.once()
                );

More over, mockServerClient.retrieveRecordedRequests(null) returns an empty array.
Is it the expected behavior?

That is not expected behaviour and I will submit a fix very soon.

The bug you raised is now fixed, closing this ticket and migrating the remaining documentation part to #115 which is the next highest priority issue.


Fixed #30064 -- Added form to validate admin search fields query input.

Follow-up from #10895 (because GH is being naughty.)

GOTO #11701