Can't add page:

Adds a md file, but I can't access it via the page.
PS D:\Leonard\OneDrive\Dokument\random flask wiki thing\content> wiki web
Traceback (most recent call last):
  File "C:\Python27\Scripts\wiki-script.py", line 11, in <module>
    load_entry_point('wiki2==2.0.3', 'console_scripts', 'wiki')()
  File "c:\python27\lib\site-packages\click\core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "c:\python27\lib\site-packages\click\core.py", line 697, in main
    rv = self.invoke(ctx)
  File "c:\python27\lib\site-packages\click\core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\python27\lib\site-packages\click\core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\python27\lib\site-packages\click\core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "c:\python27\lib\site-packages\click\decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\cli.py", line 38, in web
    app = create_app(ctx.meta['directory'])
  File "c:\python27\lib\site-packages\wiki\web\__init__.py", line 38, in create_app
    os.path.join(app.config.get('CONTENT_DIR'), 'config.py')
  File "c:\python27\lib\site-packages\flask\config.py", line 132, in from_pyfile
    exec(compile(config_file.read(), filename, "exec"), d.__dict__)
  File "D:\Leonard\OneDrive\Dokument\random flask wiki thing\content\config.py", line 2, in <module>
    SECRET_KEY=JvoGTgriz6yn8WsJhOdf9gHv4A5f8braI2jA9IPNSE2ZT8MMqgVpSqFxf6lzR4hicD0rlxMAGHI61PAyrs5gr0h0sYFqqlum8EAP
NameError: name 'JvoGTgriz6yn8WsJhOdf9gHv4A5f8braI2jA9IPNSE2ZT8MMqgVpSqFxf6lzR4hicD0rlxMAGHI61PAyrs5gr0h0sYFqqlum8EAP' is not defined
PS D:\Leonard\OneDrive\Dokument\random flask wiki thing\content> wiki web
 * Serving Flask app "wiki.web" (lazy loading)
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
 * Running on http://<IP_ADDRESS>:5000/ (Press CTRL+C to quit)
<IP_ADDRESS> - - [30/Nov/2020 13:14:16] "←[37mGET / HTTP/1.1←[0m" 200 -
<IP_ADDRESS> - - [30/Nov/2020 13:14:18] "←[37mGET /static/pygments.css HTTP/1.1←[0m" 200 -
<IP_ADDRESS> - - [30/Nov/2020 13:14:18] "←[37mGET /static/responsive.css HTTP/1.1←[0m" 200 -
<IP_ADDRESS> - - [30/Nov/2020 13:14:18] "←[37mGET /static/bootstrap.css HTTP/1.1←[0m" 200 -
<IP_ADDRESS> - - [30/Nov/2020 13:14:18] "←[37mGET /static/bootstrap.min.js HTTP/1.1←[0m" 200 -
<IP_ADDRESS> - - [30/Nov/2020 13:14:19] "←[32mGET /favicon.ico HTTP/1.1←[0m" 308 -
<IP_ADDRESS> - - [30/Nov/2020 13:14:19] "←[33mGET /favicon.ico/ HTTP/1.1←[0m" 404 -
c:\python27\lib\site-packages\wiki\web\routes.py:66: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
  form = EditorForm(obj=page)
<IP_ADDRESS> - - [30/Nov/2020 13:14:25] "←[37mGET /edit/home/ HTTP/1.1←[0m" 200 -
c:\python27\lib\site-packages\wiki\web\routes.py:66: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
  form = EditorForm(obj=page)
[2020-11-30 13:14:54,778] ERROR in app: Exception on /edit/home/ [POST]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 71, in edit
    page.save()
  File "c:\python27\lib\site-packages\wiki\core.py", line 199, in save
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:14:54] "←[35m←[1mPOST /edit/home/ HTTP/1.1←[0m" 500 -
[2020-11-30 13:15:23,920] ERROR in app: Exception on /edit/home/ [POST]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 65, in edit
    page = current_wiki.get(url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 255, in get
    return Page(path, url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 174, in __init__
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:15:23] "←[35m←[1mPOST /edit/home/ HTTP/1.1←[0m" 500 -
[2020-11-30 13:15:27,490] ERROR in app: Exception on /edit/home/ [GET]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 65, in edit
    page = current_wiki.get(url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 255, in get
    return Page(path, url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 174, in __init__
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:15:27] "←[35m←[1mGET /edit/home/ HTTP/1.1←[0m" 500 -
c:\python27\lib\site-packages\wiki\web\routes.py:134: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
  form = LoginForm()
<IP_ADDRESS> - - [30/Nov/2020 13:15:33] "←[37mGET /user/login/ HTTP/1.1←[0m" 200 -
c:\python27\lib\site-packages\wiki\web\routes.py:55: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
  form = URLForm()
<IP_ADDRESS> - - [30/Nov/2020 13:15:35] "←[37mGET /create/ HTTP/1.1←[0m" 200 -
c:\python27\lib\site-packages\wiki\web\routes.py:55: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
  form = URLForm()
<IP_ADDRESS> - - [30/Nov/2020 13:15:41] "←[32mPOST /create/ HTTP/1.1←[0m" 302 -
c:\python27\lib\site-packages\wiki\web\routes.py:66: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
  form = EditorForm(obj=page)
<IP_ADDRESS> - - [30/Nov/2020 13:15:41] "←[37mGET /edit/e/ HTTP/1.1←[0m" 200 -
c:\python27\lib\site-packages\wiki\web\routes.py:66: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
  form = EditorForm(obj=page)
[2020-11-30 13:15:44,602] ERROR in app: Exception on /edit/e/ [POST]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 71, in edit
    page.save()
  File "c:\python27\lib\site-packages\wiki\core.py", line 199, in save
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:15:44] "←[35m←[1mPOST /edit/e/ HTTP/1.1←[0m" 500 -
PS D:\Leonard\OneDrive\Dokument\random flask wiki thing\content> wiki web
 * Serving Flask app "wiki.web" (lazy loading)
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
 * Running on http://<IP_ADDRESS>:5000/ (Press CTRL+C to quit)
[2020-11-30 13:16:47,305] ERROR in app: Exception on / [GET]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 32, in home
    page = current_wiki.get('home')
  File "c:\python27\lib\site-packages\wiki\core.py", line 255, in get
    return Page(path, url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 174, in __init__
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:16:47] "←[35m←[1mGET / HTTP/1.1←[0m" 500 -
[2020-11-30 13:16:58,552] ERROR in app: Exception on / [GET]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 32, in home
    page = current_wiki.get('home')
  File "c:\python27\lib\site-packages\wiki\core.py", line 255, in get
    return Page(path, url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 174, in __init__
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:16:58] "←[35m←[1mGET / HTTP/1.1←[0m" 500 -
[2020-11-30 13:17:20,540] ERROR in app: Exception on / [GET]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 32, in home
    page = current_wiki.get('home')
  File "c:\python27\lib\site-packages\wiki\core.py", line 255, in get
    return Page(path, url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 174, in __init__
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:17:20] "←[35m←[1mGET / HTTP/1.1←[0m" 500 -
<IP_ADDRESS> - - [30/Nov/2020 13:17:31] "←[32mGET /wiki HTTP/1.1←[0m" 308 -
<IP_ADDRESS> - - [30/Nov/2020 13:17:32] "←[33mGET /wiki/ HTTP/1.1←[0m" 404 -
[2020-11-30 13:17:36,720] ERROR in app: Exception on / [GET]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 32, in home
    page = current_wiki.get('home')
  File "c:\python27\lib\site-packages\wiki\core.py", line 255, in get
    return Page(path, url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 174, in __init__
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:17:36] "←[35m←[1mGET / HTTP/1.1←[0m" 500 -
<IP_ADDRESS> - - [30/Nov/2020 13:17:38] "←[33mGET /wiki/ HTTP/1.1←[0m" 404 -
[2020-11-30 13:17:40,086] ERROR in app: Exception on /index/ [GET]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 41, in index
    pages = current_wiki.index()
  File "c:\python27\lib\site-packages\wiki\core.py", line 316, in index
    page = Page(path, url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 174, in __init__
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:17:40] "←[35m←[1mGET /index/ HTTP/1.1←[0m" 500 -
<IP_ADDRESS> - - [30/Nov/2020 13:17:41] "←[33mGET /wiki/ HTTP/1.1←[0m" 404 -
<IP_ADDRESS> - - [30/Nov/2020 13:17:44] "←[32mGET /wiki/e HTTP/1.1←[0m" 308 -
<IP_ADDRESS> - - [30/Nov/2020 13:17:44] "←[33mGET /wiki/e/ HTTP/1.1←[0m" 404 -
[2020-11-30 13:17:54,742] ERROR in app: Exception on /e/ [GET]
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flask\app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "c:\python27\lib\site-packages\flask\app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "c:\python27\lib\site-packages\flask\app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "c:\python27\lib\site-packages\flask\app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "c:\python27\lib\site-packages\wiki\web\user.py", line 147, in wrapper
    return f(*args, **kwargs)
  File "c:\python27\lib\site-packages\wiki\web\routes.py", line 48, in display
    page = current_wiki.get_or_404(url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 259, in get_or_404
    page = self.get(url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 255, in get
    return Page(path, url)
  File "c:\python27\lib\site-packages\wiki\core.py", line 174, in __init__
    self.render()
  File "c:\python27\lib\site-packages\wiki\core.py", line 184, in render
    processor = Processor(self.content)
  File "c:\python27\lib\site-packages\wiki\core.py", line 92, in __init__
    'tables'
TypeError: __init__() takes exactly 1 argument (2 given)
<IP_ADDRESS> - - [30/Nov/2020 13:17:54] "←[35m←[1mGET /e/ HTTP/1.1←[0m" 500 -
<IP_ADDRESS> - - [30/Nov/2020 13:17:56] "←[33mGET /wiki/e/ HTTP/1.1←[0m" 404 -

Hey @arduino5144. 🙂
the configuration file is a python file, so you need to quote strings in it like such:
SECRET_KEY="JvoGTgriz6yn8WsJhOdf9gHv4A5f8braI2jA9IPNSE2ZT8MMqgVpSqFxf6lzR4hicD0rlxMAGHI61PAyrs5gr0h0sYFqqlum8EAP"

However it looks like there is another bug there as well. Can you tell me how you installed wiki? Via pip or by pulling the git repo?

Pip

@arduino5144 this issue should already have been resolved in the master branch, so if you install it from the github repo, it should not appear. I will make sure to release an update some time soon to address this also on pip

@arduino5144 this issue should already have been resolved in the master branch, so if you install it from the github repo, it should not appear. I will make sure to release an update some time soon to address this also on pip


Tweet and Retweet timeline buttons gone

Twitter seems to have updated somehow and the Tweet and Retweet timeline buttons have disappeared for me and are no longer clickable.
Using script v57 via ViolentMonkey on Firefox v103.0.2

Twitter changed their layout a bit, more significantly on the mobile version than the desktop version.
This should be fixed in v2.15.1 of the extension / v58 of the user script:
https://github.com/insin/tweak-new-twitter/releases/tag/v2.15.1

@insin The addon Version 2.15.0 on the firefox store has not been updated. Please push an update soon. Thanks for the bug fix and the extension in general! 👍

I pushed it 4 days ago, AMO haven't approved the new version. It usually only takes a few minutes.

That's a shame on their part. Either way, thanks for the update and follow up!


feature: Only show cmdline_popup when entering ex mode manually ":"

Did you check the docs?

[X] I have read all the noice.nvim docs

Is your feature request related to a problem? Please describe.
Hello! I hope you're doing well. I'm reaching out because I noticed that every time I execute a command using a keybinding, such as '0' for 'NvimTreeToggle', the command-line view pops up and executes the command. Although this is the natural behaviour of the built-in command-line, I find it a bit distracting to have the command-line pop up every time I execute a command. I understand that 'Noice' is actually modifying the user interface of the command-line so therefore expected, but I was wondering if there is any way to suppress the command-line from opening when I execute commands via keybindings. It would be amazing if I could seamlessly execute commands without being interrupted by the command-line interface. Thank you so much for your time and consideration, and let me know if you have any questions or suggestions!"
https://user-images.githubusercontent.com/8395044/220348848-69c90525-76dc-40b9-93e2-6f5a815e5db3.mov
Describe the solution you'd like
I'm not entirely sure if this is possible, but I thought it might be worth asking. Currently, we're using the built-in command-line, but with a different view. My question is whether it's possible to show only the popup menu when we manually execute a command using ':', and suppress the command-line popup window or change the view to the classic command-line whenever we run a command using a keybinding.
Describe alternatives you've considered
I read the documentation but couldn't find any related options to fix it. But feel free to point me in the right direction. :)
Thanks for creating all these amazing plugins!!
Additional context
No response

use silent in your mappings?


[Bluetooth] Fix auto-connect for BR/EDR devices

https://jenkins.code.rdkcentral.com/job/github-triggered/424/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/519/ started


Expose label background color and hover color in settings

Hey,
currently it's not possible to color the label color when hovered or the background which makes it very hard to use on dark background. Currently I have set the font color to grey so it's visible on the dark background and the white hover background. As labelColor is already an object it would be suitable to add these settings to.
labelColor: {     color: '#fff',     hover: '#000',     background: '#fff' }

@Bytenex this can be dealt with using a custom label renderer such as this one here: https://github.com/medialab/ipysigma/blob/master/src/custom-label.ts (or if you want to customize the hover part: https://github.com/medialab/ipysigma/blob/master/src/custom-hover.ts)You can easily make your own to add support for a background color. Then you can pass those functions to your sigma instances in the settings as labelRenderer & hoverRenderer.

After having been thinking a lot on this issue, I decided to not implement it. Right now, sigma's APIs is made so that people who have advanced usecases should write their own label renderers. That's what we do in the demo for instance.
Also, labels rendering APIs might change in the near future (to handle #1319 for instance), so I don't want to commit more code/debt into it.


Two new Themes

Fixed the problems and the nameing! Would be nice to have this merged

Can someone take a look into merging this?

@robengrobban as I already said here please fix the typo and your pull request will be merged and be patient it's Sunday and nobody is gonna die if your pull request (once you will fix your typo) is gonna be merged next week

Hi! I don't know if you looked into this new pull request (This one). But in this one, it is named corectly... And i think that is what you mean with typo... Other wise, responde


To include GENERIC_RESPONSE_PROFILE instance for the release "2.1.1"

For each entry in the release history list in the http-server-capability , there will be a GENERIC_RESPONSE_PROFILE for the API /v1/inform-about-release-history-in-generic-representation ,
In the current config file , for release "2.1.1" , the GENERIC_RESPONSE_PROFILE entry is missing.
Proposing to include the following GENERIC_RESPONSE_PROFILE instance(that points to the 2nd index of the release-history array)

{
                    "uuid": "eatl-2-1-0-response-p-009",
                    "profile-name": "response-profile-1-0:PROFILE_NAME_TYPE_GENERIC_RESPONSE_PROFILE",
                    "response-profile-1-0:response-profile-pac": {
                        "response-profile-capability": {
                            "operation-name": "/v1/inform-about-release-history-in-generic-representation",
                            "field-name": {
                                "field-name-reference": "/core-model-1-4:control-construct/logical-termination-point=eatl-2-1-0-http-s-000/layer-protocol=0/http-server-interface-1-0:http-server-interface-pac/http-server-interface-capability/release-list=2/release-number"
                            },
                            "description": "Represents the first entry in the list of releases",
                            "datatype": "string"
                        },
                        "response-profile-configuration": {
                            "value": {
                                "value-reference": "/core-model-1-4:control-construct/logical-termination-point=eatl-2-1-0-http-s-000/layer-protocol=0/http-server-interface-1-0:http-server-interface-pac/http-server-interface-capability/release-list=2/changes"
                            }
                        }
                    }
                }

Note : This issues is not blocking. Fixed this in the server side in this issue https://github.com/openBackhaul/ExecutionAndTraceLog/issues/387.

Covered in pull-request #393


Work in progress: split quickstart last part into 2 distinct pages

As discussed with @vikram-dagger .
We split the last part of the quickstart into 2 pages, to introduce the concept of installing dependencies and calling them from the CLI, before writing code for your own functions. The goal is to make the learning curve smoother.
Unfinished content is marked with FIXME

I need to rebase... stand by.

Unfinished content is marked with FIXME

@shykes I've attempted to add in the missing bits, also some other consistency fixes which I came across. Please review and add further thoughts. Thanks!

Added back section headings as discussed

I'm going to rebase this and mark it as ready

Rebased

I'm getting an error on preview deploy... No idea why :( Any ideas @vikram-dagger  @gerhard @matipan ?

I'm getting an error on preview deploy... No idea why :( Any ideas @vikram-dagger @gerhard @matipan ?

Just checked, deploy preview and checks are green so guessing you found and fixed the issue.


Add resources requests and limits to the operator

Signed-off-by: brunopadz<EMAIL_ADDRESS>Which problem is this PR solving?

Resolves #1514

Short description of the changes

Adds default resources requests and limits to the Operator container

Thank you!


Having issues building the environment.

I've been trying to get this to work on my local. I'm running Ubuntu 22.04. Nvidia-smi 560.35.03 Cuda Version: 12.6.
I keep getting this error, no matter what I do. Which is confusing, because I was able to get this working initially, and then something required the appropriate system user credentials, so I thought to reinstall the environment to fix the user credentials i had set wrong the first time. Upon reinstallation of this environment, i was not prompted to provide a different uid or gid, as I believe I was prompted to provide this the first time, I could be wrong. regardless, I ended up removing and re-installing my nvidia drivers, and cuda drivers, making sure to install the proper toolkits for them as well. I believe at least. Half the time I feel a bit gaslit, because I still may have messed things up. I have removed and cleaned away the docker images, containers and volumes. I have added specific verbiage to my docker daemon files as listed here https://github.com/NVIDIA/nvidia-docker/issues/838 . I have updated the project Dockerfile to reflect my environment nvidia and cuda versioning. However, i understand that runtime cuda drivers are indicative of being managed by python.
All that to say, should I be trying to enter the docker environment to sort out the appropriate versioning of the python runtime packages? Should I try and modify the user_script.bash to install updated runtime python packages? This reddit post mentions that they had to reinstall the appropriate runtime packages https://www.reddit.com/r/comfyui/comments/1cw33fy/comfy_installation_broken_for_anyone_else/
Should I utilize that to match the appropriate versioning I have installed? I do not know how to proceed. I have been trying to get this working for three days. Please advise.
comfyui-nvidia  | -- COMFYUI_PATH: /comfy/mnt/ComfyUI
comfyui-nvidia  | == You will need to run ComfyUI-Manager a first time for the configuration file to be generated, we can not attempt to update its
security level yet
comfyui-nvidia  | == Container directory: /comfy/mnt/ComfyUI
comfyui-nvidia  | == Checking for user script: /comfy/mnt/user_script.bash
comfyui-nvidia  | ===================
comfyui-nvidia  | == Running ComfyUI
comfyui-nvidia  | -- Running: python3 ./main.py --listen <IP_ADDRESS> --disable-auto-launch
comfyui-nvidia  | [START] Security scan
comfyui-nvidia  | [DONE] Security scan
comfyui-nvidia  | ## ComfyUI-Manager: installing dependencies done.
comfyui-nvidia  | ** ComfyUI startup time: 2024-09-29 00:24:19.563793
comfyui-nvidia  | ** Platform: Linux
comfyui-nvidia  | ** Python version: 3.10.12 (main, Jul 29 2024, 16:56:48) [GCC 11.4.0]
comfyui-nvidia  | ** Python executable: /comfy/mnt/venv/bin/python3
comfyui-nvidia  | ** ComfyUI Path: /comfy/mnt/ComfyUI
comfyui-nvidia  | ** Log path: /comfy/mnt/ComfyUI/comfyui.log
comfyui-nvidia  |
comfyui-nvidia  | Prestartup times for custom nodes:
comfyui-nvidia  |    0.2 seconds: /comfy/mnt/ComfyUI/custom_nodes/ComfyUI-Manager
comfyui-nvidia  |
comfyui-nvidia  | Traceback (most recent call last):
comfyui-nvidia  |   File "/comfy/mnt/ComfyUI/./main.py", line 90, in
comfyui-nvidia  |     import execution
comfyui-nvidia  |   File "/comfy/mnt/ComfyUI/execution.py", line 13, in
comfyui-nvidia  |     import nodes
comfyui-nvidia  |   File "/comfy/mnt/ComfyUI/nodes.py", line 21, in
comfyui-nvidia  |     import comfy.diffusers_load
comfyui-nvidia  |   File "/comfy/mnt/ComfyUI/comfy/diffusers_load.py", line 3, in
comfyui-nvidia  |     import comfy.sd
comfyui-nvidia  |   File "/comfy/mnt/ComfyUI/comfy/sd.py", line 5, in
comfyui-nvidia  |     from comfy import model_management
comfyui-nvidia  |   File "/comfy/mnt/ComfyUI/comfy/model_management.py", line 143, in
comfyui-nvidia  |     total_vram = get_total_memory(get_torch_device()) / (1024 * 1024)
comfyui-nvidia  |   File "/comfy/mnt/ComfyUI/comfy/model_management.py", line 112, in get_torch_device
comfyui-nvidia  |     return torch.device(torch.cuda.current_device())
comfyui-nvidia  |   File "/comfy/mnt/venv/lib/python3.10/site-packages/torch/cuda/init.py", line 878, in current_device
comfyui-nvidia  |     _lazy_init()
comfyui-nvidia  |   File "/comfy/mnt/venv/lib/python3.10/site-packages/torch/cuda/init.py", line 314, in _lazy_init
comfyui-nvidia  |     torch._C._cuda_init()
comfyui-nvidia  | RuntimeError: No CUDA GPUs are available
comfyui-nvidia  | ComfyUI failed or exited with an error
comfyui-nvidia  | == user -- uid: 1024 / gid: 1024
comfyui-nvidia  | Wrong GID (1024), exiting
comfyui-nvidia exited with code 0
edit: I also have no idea how to change the GID and UID that's been provided. I changed the Dockerfile and init.bash to uid / gid 1000 respectively, but still. it keeps being set as 1024.

To confirm: are you running this within Docker?
I see RuntimeError: No CUDA GPUs are available which makes me wonder if it is an issue with the NVIDIA container toolkit?
Can you check this post https://blg.gkr.one/20240404-u24_nvidia_docker_podman/ and confirm that
docker run --rm --runtime=nvidia --gpus all nvidia/cuda:11.6.2-base-ubuntu20.04 nvidia-smi

returns a valid output of nvidia-smi
This will tell you if the runtime is functional. You can modify the default-runtime after.
For the UID/GID, see the WANTED_UID and WANTED_GID environment variables detailed in the "Running the container" docker run section of the GitHub's README.md
PS: is 560 finally official?

Thank you for your apt response.
It seems that I need to restart completely from scratch to match the appropriate versioning.
nvidia-smi by itself returns
Sat Sep 28 20:36:58 2024
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 560.35.03              Driver Version: 560.35.03      CUDA Version: 12.6     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA GeForce RTX 4080        On  |   00000000:01:00.0  On |                  N/A |
|  0%   36C    P8             13W /  320W |     828MiB /  16376MiB |      7%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
+-----------------------------------------------------------------------------------------+
| Processes:                                                                              |
|  GPU   GI   CI        PID   Type   Process name                              GPU Memory |
|        ID   ID                                                               Usage      |
|=========================================================================================|
|    0   N/A  N/A      6167      G   /usr/lib/xorg/Xorg                            545MiB |
|    0   N/A  N/A      6350      G   /usr/bin/gnome-shell                           48MiB |
|    0   N/A  N/A      8445      G   ...seed-version=20240927-160657.442000        205MiB |
|    0   N/A  N/A      9260      G   gnome-control-center                            3MiB |
+-----------------------------------------------------------------------------------------+
however within the docker container by utilizing the command provided returns
Failed to initialize NVML: Unknown Error
560 I believe is official for Ubuntu 24.04. However. I do not know if it is for Ubuntu 22.04, and within the nvidia documentation I cannot find right now, I remember that the Ubuntu 22.04 versioning did not go that high yet in the document, so I do not fully know if it is official. I just know that it was the provided LTS available as an install without providing a specific version number.
It seems that the current path forward is to wipe nvidia and cuda, their respective toolkits, and install fresh to ensure the correct versioning is applied.
Thank you for your time, and I will let you know if this line of action resolves the issue.

Can you reboot the host?
I have seen the NVML error sometimes happens when the kernel and the container runtime are not in sync with the installed version of the driver

So again, thank you for your apt response. Terribly sorry for my late one as lots of life things happening right now.
I uninstalled my nvidia and cuda drivers and toolkits and reinstalled them. I downgraded to nvidia driver 550 and cuda 12.4 . While following the podman tutorial linked in the readme, I came across an error with this command.
podman run --rm --device nvidia.com/gpu=all ubuntu nvidia-smi
Error: stat nvidia.com/gpu=all: no such file or directory
Upon researching, I found that a common issue was that after so long, within 48 hours, probably less, docker stops working with the gpus. This stack overflow post however seems to have helped resolve the issue.
https://stackoverflow.com/questions/72932940/failed-to-initialize-nvml-unknown-error-in-docker-after-few-hours
However, I don't think I would have stumbled upon this had I not received your input to make sure the basics were in fact, all lined up. Especially since it was only at the end of the podman tutorial that I found this out.
So I believe I can say with confidence, that the issue I had is now resolved. Thank you so much for your time.


Documentation link on https://crates.io/crates/log is a 404.

Cargo.toml says "https://docs.rs/log" but somehow crates.io links to https://doc.rust-lang.org/log?

Interestingly, looking inside log-0.4.0.crate, the Cargo.toml is correct. Is this a crates.io bug?

I think this'll be fixed by https://github.com/rust-lang/crates.io/pull/1207.

The link works now. This issue can probably be closed.

https://doc.rust-lang.org/log appears to redirect now, and the 0.4.* crates point to docs.rs. Thanks!


chore(dcos-ui): update package

High-level description
Update the DC/OS UI package to include the latest fixes, improvements and features.
Corresponding DC/OS tickets (obligatory)

DCOS_OSS-2054 Make icons light grey
DCOS-21122 fixes focus/change/blur behaviour
DCOS_OSS-2063 show progress of deployments
DCOS-19219 fix variable reference
DCOS-20080 disabled review and run button
DCOS-20080 Fix disabled review and run button
DCOS-21229 add sorting for region and zones
DCOS-19301 open to form when deploying
DCOS_OSS-2063 show progress of deployments
DCOS-21122 fixes focus/change/blur behaviour
DCOS-21173 Update status bar styles
DCOS-21229 Sorting in pods table
DCOS-21158 Add flush horizontal to secondary buttons in full screen form flows
DCOS-21229 fix sorting in tables
DCOS-21304 Remove spaces from endpoints list
DCOS-21135 display mesos start and elected time
DCOS-20309 adds empty state behavior to Packages
DCOS-21135 display mesos start and elected time
DCOS-21229 add sorting for region and zones
DCOS-21044 flag all SDK tasks
DCOS-20976 renames terminal to command prompt
DCOS_OSS-1553 Add vip input to virtual networks
DCOS-19301 open to form when deploying
DCOS-21115 fallback to type: "object" for config
DCOS_OSS-1341 stay in group view when service/group deleted
DCOS-21115 fallback to type: "object" for config
DCOS-20978 Fix CLI install link
DCOS-21063 set default value for dsl Filters
DCOS-21063 set default value for dsl Filters
DCOS-21044 flag all SDK tasks
DCOS-20331 Update DSL filter results in real time
DCOS-20956 disable id field on service edit
DCOS-20956 disable id field on service edit
DCOS-20976 renames terminal to command prompt
DCOS-20975 node link throwing error
DCOS-20978 update to correct link for install cli
DCOS-20978 update to correct link for install cli
DCOS-20948 keep unknown attributes
DCOS-19693 fix labels reducer to accept empty strings
DCOS-19693 fix labels reducer to accept empty strings
DCOS-20331 update DSL filter results in real time
DCOS_OSS-1341 stay in group view when service deleted
DCOS-20332 DSL show dropdown on focus
DCOS-14753 adds unanchored property to marathon errors
DCOS-14753 adds unanchored property to marathon errors
DCOS-20939 add version query
DCOS-20332 show dropdown on click
DCOS-20468 upload build to S3 bucket
DCOS-20468 upload release to S3 after build

Checklist for all PRs

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[X] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[X] Test Results: [https://jenkins.mesosphere.com/service/jenkins/job/Frontend/job/dcos-ui-oss-release/job/master/64/]
[X] Code Coverage (if available): [https://jenkins.mesosphere.com/service/jenkins/job/Frontend/job/dcos-ui-oss-release/job/master/64/]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@orsenthil could you please close this one as well as the respective enterprise PR?


⚠ Samsung has degraded performance

In 0d4727e, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2319 ms

Resolved: Samsung performance has improved in 9e40420.


Zero infinity xpu support

Currently AIO kernel has gap using on XPU device.
This PR fixes issues that

cpu buffer only detect CUDA tensor in aio threads
make is_pinned() more general in all kinds of accelerator
io_getevents() stopped by signal on XPU

Developed and Tested on Megatron Deepspeed.

Some change seems not necessary. I wonder if it's model related. For example, assert(_num_pending_ops > 0); should not raise error if thread's queue works fine. But in Megatron-deepspeed it fails. For io_pgetevents, I will test it more to reply you. Thanks.

Hi @tjruwase , I did a modification to current PR.  Removed env variable dependence. Let me explain some change that this PR has.

use io_pgetevents instead of io_getevents
It's indeed more general and it sometimes can help to block signals from interrupting the io process. The performance of these two are same.

2)More copy on XPU
This is because Async IO requires aligned mem to be used as buffer. Currently it needs manually set to allocate an aligned place, otherwise io would fail. This could be optimized in future.

changes in _swap_out_unpinned_tensors
In deepspeed/runtime/swap_tensor/partitioned_optimizer_swapper.py, def swap_in_optimizer_state read data into buffer whose sizes are all swap_info.numel(). But for def _swap_out_unpinned_tensors in def swap_out_optimizer_state, write buffer sizes are numel of each tensor. This could be a mismatch in some cases.

2)More copy on XPU This is because Async IO requires aligned mem to be used as buffer. Currently it needs manually set to allocate an aligned place, otherwise io would fail. This could be optimized in future.

Requiring aligned buffers is a deliberate design decision to simplify the library and ensure high performance.  We prefer for the alignment issues to be addressed on the client side where there is more flexibility. For example, clients can easily add padding in a way that minimizes perf impact. However, I think the library needs to be improved to assert on unaligned buffers to make this requirement more explicit.

3. changes in _swap_out_unpinned_tensors
In deepspeed/runtime/swap_tensor/partitioned_optimizer_swapper.py, def swap_in_optimizer_state read data into buffer whose sizes are all swap_info.numel(). But for def _swap_out_unpinned_tensors in def swap_out_optimizer_state, write buffer sizes are numel of each tensor. This could be a mismatch in some cases.

Can you please share an example of this failure case, perhaps in the form of a unit test?

2)More copy on XPU This is because Async IO requires aligned mem to be used as buffer. Currently it needs manually set to allocate an aligned place, otherwise io would fail. This could be optimized in future.

Requiring aligned buffers is a deliberate design decision to simplify the library and ensure high performance. We prefer for the alignment issues to be addressed on the client side where there is more flexibility. For example, clients can easily add padding in a way that minimizes perf impact. However, I think the library needs to be improved to assert on unaligned buffers to make this requirement more explicit.

The buffers that get used in swap in and out are all created and initialized in deepspeed python codes. In client side we cannot affect it by changing model codes. By the way, I see that in link deepspeed test has a flag that can create aligned tensor which also calls posix_memalign to initialize buffer. And this flag seems not get used in deepspeed. What about adding it to let client choose how to create their buffer?

changes in _swap_out_unpinned_tensors
In deepspeed/runtime/swap_tensor/partitioned_optimizer_swapper.py, def swap_in_optimizer_state read data into buffer whose sizes are all swap_info.numel(). But for def _swap_out_unpinned_tensors in def swap_out_optimizer_state, write buffer sizes are numel of each tensor. This could be a mismatch in some cases.

Can you please share an example of this failure case, perhaps in the form of a unit test?

In my env of Megatron-deepspeed with Adam on xpu devices, when run to def _update_param_state_info, the optimizer state that get added to swap_info can be a shape of [1, 22843136, 22843136], which will result in mismatch of swap in&out optimizer states. Because in swap_in the buffer is set to [22843136, 22843136, 22843136] and [256, 22843136, 22843136] in swap_out(aligned).  There is an assert to check this mismatch in link.

@tjruwase Any comments? Thanks!

The buffers that get used in swap in and out are all created and initialized in deepspeed python codes. In client side we cannot affect it by changing model codes.

Actually, the expectation is that the client side send aligned buffers to the library. This is why the tensor swapping utility of deepspeed has many alignment codes to guarantee this condition.  Can you share a bit about your client side? Perhaps, deepspeed can expose another wapper to provide this alignment. Would that help?

By the way, I see that in link deepspeed test has a flag that can create aligned tensor which also calls posix_memalign to initialize buffer. And this flag seems not get used in deepspeed. What about adding it to let client choose how to create their buffer?

Yes, good observation. Our plan is to use this functionality within deepspeed and also expose to clients. We hope to do that soon.

In my env of Megatron-deepspeed with Adam on xpu devices, when run to def _update_param_state_info, the optimizer state that get added to swap_info can be a shape of [1, 22843136, 22843136], which will result in mismatch of swap in&out optimizer states. Because in swap_in the buffer is set to [22843136, 22843136, 22843136] and [256, 22843136, 22843136] in swap_out(aligned).

I am very curious about how this mismatch could happen. It concerns me that our swapping logic is making wrong assumptions. Is it possible to share more details of the training run? Or is it possible to create unit test? Thanks!

I am very curious about how this mismatch could happen. It concerns me that our swapping logic is making wrong assumptions. Is it possible to share more details of the training run? Or is it possible to create unit test? Thanks!

I find the root cause of this mismatch now. The reason is that Deepspeed assumes that optimizer state tensors have same numel and so swap_in&swap_out can use each tensors' numel or param's numel as length. But the truth is different optimizer have different situation. It could be different numel.
For apex.optimizers.FusedAdam, the optimizer states have same numel as param: apex optimizer states init
For torch.optim.Adam, the optimizer states have three tensor and the first one is scalar: torch adam
I found that my previous change is naive and not enough. So I fallback to use sgd optimizer whose state has same numel as param to bypass this issue. For this part, it can be in another PR or do you want to fix it? @tjruwase

I add the alignment in get_accelerator(), which will be easy for different platform to create or adjust their buffer and don't

This solution is fine with me. Thanks!

I found that my previous change is naive and not enough. So I fallback to use sgd optimizer whose state has same numel as param to bypass this issue. For this part, it can be in another PR or do you want to fix it? @tjruwase

Thanks for the amazing debugging effort to discover the root issue. I think it is better to fix in another PR. Are you able to help fix this?

After reviewing your alignment changes, I have shared some questions. One idea is that perhaps we could extend the existing pin_memory() API to take an alignment flag as well. So that way, clients can request pinned buffers that are also aligned. Also, accelerators would have flexibility in handling such requests. What do you think?
Below are two possible APIs. The second one seems more general. I am curious if this could help your work. Thanks.

@tjruwase Good idea. In this way we can implement alignment in pin_memory and reduce swap code complexity. I choose the first API because I think it's better get sysconf(_SC_PAGESIZE) as align bytes rather than let user do the setting. So then is_align() is not needed anymore. The code is done.

I found that my previous change is naive and not enough. So I fallback to use sgd optimizer whose state has same numel as param to bypass this issue. For this part, it can be in another PR or do you want to fix it? @tjruwase

Thanks for the amazing debugging effort to discover the root issue. I think it is better to fix in another PR. Are you able to help fix this?

Yes sure. I can do that.

@tjruwase Good idea. In this way we can implement alignment in pin_memory and reduce swap code complexity. I choose the first API because I think it's better get sysconf(_SC_PAGESIZE) as align bytes rather than let user do the setting. So then is_align() is not needed anymore. The code is done.

Sorry :). I think the second API is better so that clients have the option of different alignments, such as super pages.

Another thing is that in previous workflow checks, I found that io_pgetevents cannot be found in your unittest env when building AIO ops. I am not sure if it's because the testing env is outdated or any other reason. Could you pls help to check with it? @tjruwase
reference code: libaio

It's ok:). I think we can modify it like this to let clients use default page size:
    @abc.abstractmethod
    def pin_memory(self, tensor, align_bytes=1, sc_page_align=False):

I think it could be confusing to provide two flags to control the alignment bytes. But I also see the value of allowing users to request the default system alignment without having to know the number of bytes. So how about we adjust the second API so that -1 value for alignment_bytes means to use system default such as sysconf(_SC_PAGESIZE)? We will document this behavior. What do you think?

I think it could be confusing to provide two flags to control the alignment bytes. But I also see the value of allowing users to request the default system alignment without having to know the number of bytes. So how about we adjust the second API so that -1 value for alignment_bytes means to use system default such as sysconf(_SC_PAGESIZE)? We will document this behavior. What do you think?

Yes, I agree. It will be clear more.

Another thing is that in previous workflow checks, I found that io_pgetevents cannot be found in your unittest env when building AIO ops.

I will pay attention to the new workflow for this issue.

@tjruwase Thanks! btw can you help to trigger workflow once again? Seems it stops when I push new commits.:)

@Liangliang-Ma, this PR looks good to me after addressing the final suggestions. Thanks so much for this great work.

@tjruwase I committed the change as you suggested. Thanks for your reviewing these days!

Another thing is that in previous workflow checks, I found that io_pgetevents cannot be found in your unittest env when building AIO ops.

I will pay attention to the new workflow for this issue.

I think this is failing because the unittest env is ubuntu 18.04 which does not have io_pgetevents available. Is it possible for the code to use io_getevents or io_pgetevents as appropriate? I will also investigate if ubuntu version of the unittest can be updated. Thanks!

Another thing is that in previous workflow checks, I found that io_pgetevents cannot be found in your unittest env when building AIO ops.

I will pay attention to the new workflow for this issue.

I think this is failing because the unittest env is ubuntu 18.04 which does not have io_pgetevents available. Is it possible for the code to use io_getevents or io_pgetevents as appropriate? I will also investigate if ubuntu version of the unittest can be updated. Thanks!

This should be updated to be 20.04 now.  cc: @tjruwase and @Liangliang-Ma
Is there somewhere we should specify a min libaio version/Ubuntu version required for this?

@loadams, thanks for updating the CI ubuntu. I think the package version is tied to the OS version, so we need a way to specify minimum Ubuntu version. Unfortunately, I don't know how to do that. I am not sure we have done this previously.
@mrwyattii, @jeffra any thoughts here? Thanks!

@Liangliang-Ma, it looks like CI issues are resolved, except for formatting. Can you please address that? Thanks!

@loadams, thanks for updating the CI ubuntu. I think the package version is tied to the OS version, so we need a way to specify minimum Ubuntu version. Unfortunately, I don't know how to do that. I am not sure we have done this previously.
@mrwyattii, @jeffra any thoughts here? Thanks!

I think we should at a minimum put this in the README in the requirements section?  Also perhaps list the failure mode if one doesn't have this?

I think we should at a minimum put this in the README in the requirements section? Also perhaps list the failure mode if one doesn't have this? Thanks!

Great point @loadams. @Liangliang-Ma, could please replace io_submit with io_pgetevents in the following compatibility checker function?
https://github.com/microsoft/DeepSpeed/blob/28b9d5c2313addde94a1aa17c09eeb97cb792d7e/op_builder/async_io.py#L76-L82

@tjruwase Thanks for solving CI issue! Checker function and formatting modification is committed.

@tjruwase seems this PR has been blocked by a cpu inference unit test in merge queue, which is out of this PR's scope. Can you please help to check it? Thanks!

@tjruwase seems this PR has been blocked by a cpu inference unit test in merge queue, which is out of this PR's scope. Can you please help to check it? Thanks!

Hi @Liangliang-Ma - this is a known issue, should be resolved in this PR then we can unblock the merge queue.


Browse

browse interface with minimal logic

Coverage increased (+0.05%) to 91.398% when pulling 8a2faa552e39b36c6a50667dd40182a12d9b7644 on marqh:browse into c018ac8e5f7707d225e0f63e19cd0cba2db9ecbd on SciTools:master.

some more comments added, but not addressing all your points yet @corinnebosley
also x and y coord select added

nb: untested, perhaps a testing pattern is a follow on PR, perhaps not
@bjlittle thoughts?

Coverage decreased (-0.3%) to 91.053% when pulling 41eb06e8c22b998c882901b5aecff38ed4283d48 on marqh:browse into c018ac8e5f7707d225e0f63e19cd0cba2db9ecbd on SciTools:master.

Coverage decreased (-0.3%) to 91.053% when pulling 1f3c5fefcc44831d45b7b8fee22be6cfc96706d6 on marqh:browse into c018ac8e5f7707d225e0f63e19cd0cba2db9ecbd on SciTools:master.

Coverage decreased (-0.2%) to 95.32% when pulling a448e99edc406b5e0583c6b3451fdbcb48fa7a31 on marqh:browse into 1701fbbf3334908816aed56f6b6504be09a19486 on SciTools:master.

Coverage decreased (-0.1%) to 96.488% when pulling f787cf59def33fbf7d171c5579d297834ebe120e on marqh:browse into 3e65c92de2baab7a268063d6258b84c4506d05f7 on SciTools:master.

Coverage decreased (-0.1%) to 96.488% when pulling 972d7053af8fa632d400b8c692de78e2fde94557 on marqh:browse into 3e65c92de2baab7a268063d6258b84c4506d05f7 on SciTools:master.

@marqh Move this into waffle review when you want me to take a look again ...

ping @bjlittle

Coverage decreased (-0.1%) to 96.482% when pulling dc4c9e17d59d940650fd1d8d2f4ee644a20a73c2 on marqh:browse into 3e65c92de2baab7a268063d6258b84c4506d05f7 on SciTools:master.


⚠ ClamAV has degraded performance

In 9359a30, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 442 ms

Resolved: ClamAV performance has improved in 82713ad after 11 minutes.


Deploy to Bintray

Use the gradle-bintray-plugin to deploy to Bintray JCenter. Example build.gradle

Resolved by #17


For external types reject deferred initializer calls if disableimplicit call is set

If JIT has disabled implicit call, we should not call the DeferredTypeHandler
initializer as it can potentially go out of engine and change stuff.

@curtisman please take a look

:shipit:

Thanks @curtisman


key-file support.

Hi, it would be cool to add support for databases that use key-file in addition to password.
Thanks for the program.

Hey, thanks for opening the issue!
I will try taking a look tomorrow and come back with an ETA for you

Hey @rodin-ia
It's been a while I have been working on this project, and I forgot that in fact that is already supported :sweat_smile:
You should be able to do so using
keydex open database.kdbx -k key.key

Was there a specific problem you are facing that you cannot solve?

Shit, right. I hadn't noticed. Thank you!


ToDo list component needed

Web3uiKit needs a nice to do list maker.
Features from the design:

button is disabled when the input is empty
input has no placeholder but has a label, this label could be from the to do list components name prop
when a value is added the button will become clickable
when clicked the value of the input will be placed into an array and cleared
each array item is displayed like in the design, a full width option might be nice, you can get creative but the default should match the design please
each array item should be an <li> and be grouped in a <ul>
if an array / listed item is clicked on the 'x' it should be removed, you should be able to use <Button /> for this, check out this demo in our Storybook, https://web3ui.github.io/web3uikit/?path=/story/2-forms-button--primary&args=theme:secondary;size:small;color:blue;icon:x;iconLayout:icon-only;isTransparent:true
most importantly the component should return the array any time it changes

Design
https://www.figma.com/file/U8bUpFlNkqVyCmoB701Y3u/[Developer]Moralis-Dashboard-Design?node-id=1923%3A30472

@BillyG83
i think there's an error with the  second point

input has no placeholder but has a label, this label could be from the to do list components name prop

from the design: there's a placeholder but no label...

haha @akinolu52 yeah it looks like that, but checkout Input... the label jumps up when you focus on the input
https://web3ui.github.io/web3uikit/?path=/story/2-forms-input--default-input
it all yours bro GO GO GO!


cable.nml read from N processors

|    by<EMAIL_ADDRESS>
cable.nml is currently READ from within CABLE, definitely N decomposed processors accesing the same file. Other namelists are read at toplevel in UM and broadcast over N processors. This seems to work, however better fix would be to implement as other UM/JULES namelists. This has been implemented previosusly for other CABLE namelists, however decommisioned in the debug/development stages to elimimnate a potential source of error and hard-wired alternatives assumed.
If the working arrangement is considered OK, please close this ticket

Issue migrated from trac:338 at 2024-01-31 18:31:43 +1100

<EMAIL_ADDRESS>changed component from ACCESS model to ACCESS-CM2


HIVE-21218: KafkaSerDe doesn't support topics created via Confluent

Jira issue: https://issues.apache.org/jira/browse/HIVE-21218
Hive kafka handler doesn't read data stored with Confluent serializer, because it add 5 bytes at the beginning of each value that should represent schema ID in Schema registry.
CREATE EXTERNAL TABLE kafka_table   (id string )   STORED BY 'org.apache.hadoop.hive.kafka.KafkaStorageHandler'    TBLPROPERTIES    (    	"kafka.topic" = "kafka-topic",    	"kafka.bootstrap.servers"="kafka1:9092",    	"kafka.serde.class"="org.apache.hadoop.hive.serde2.avro.AvroSerDe",    	"avro.schema.url"="http://localhost/SimpleDocument.avsc",   	"avro.serde.magic.bytes"="true"  );
In this example "avro.serde.magic.bytes"="true" switch AvroBytesConverter to ConfluentAvroBytesConverter which only remove 5 bytes from value byte array.
Well, this is easy fix and it works.

Over all look good to me, had some minor comments. Thanks @xbaran  for Contribution.

 can the user provide schema literal ? As per this example the user can provide avro.schema.literal
@cricket007 you are correct maybe that need to be added, @xbaran can you please add it?

@davidov541 Could you review this?

@b-slim What was the status on this?


[Bug Report]: War Crate issue

Spark link
No response
Server Version
1.20.4
Server Platform
Paper
Describe the bug
While opening a War Crate, if players exit when they get the item (before the menu automatically dissapears) an error will be sent out to them when they try to open any other crate that says "You are already opening a crate." for the rest of their session.
Crate Type
War
Steps to reproduce

Open a War Crate
Choose a box inside the crate to get an item
Quickly hit ESC your on keyboard to close the menu
Try opening the same, or any other crate

Additional context
No response
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[ ] I ticked all the boxes without actually reading them
[X] My version of Minecraft is supported by CrazyCrew.

A "fix" was applied but they have to wait a bit after closing the gui themselves otherwise it'll close any active gui they have open including if they open a new crate.
I can't put the "fix" in the close event because to open a new inventory, it has to close it: A limitation of the current implementation.


Design > Toolbar component seems to be problematic with https pages

when trying to view design handles on pages served over https get a mixed content warning in chrome devtools console indicating the page was loaded over https, but requested an insecure XMLHttpRequest endpoint
https://mydomain.com/sheep_debug/design/viewHandle/default/store/1/area/frontend/ . This request has been blocked; the content must be served over HTTPS.

Hi @tvby,
I've pushed a bigger update few minutes ago. Can you check if this still is happening?
I cannot reproduce this issue. My secure and unsecure domains are both configured over https.
Thanks,
Mario

Closing for now. Please reopen if you see same issue on latest release.

The problem no longer exist. It just now if you are on a https page and access anything through the toolbar the result will switch over to http instead of leaving you on the https page

Previous version was generating url for ajax calls on http even when current page was rendered on https.  Due to this error, ajax call on https pages were not executed.
Current version doesn't contain any ajax call on the actual toolbar. So problem solved :)
All its urls are generated based on current unsecure domain. I don't see any reason why we should stick to https protocol when clicking on some menu item on toolbar. Magento out of the box switches to http when customers goes away from checkout (that's on https) to some category page.
Thinks that we might reconsider:

Should we always use secure domain for toolbar urls? Because these requests contain sensitive information we should be handled similar to '/account/' or '/checkout/' urls. This will make a lot of sense when we will have some sort of authentication that will allows to 'safely' deploy the extension on external environments.

Is this making any sense?

Yes I understand your reasoning now.


How to set mandatory updates and miniversion

It is my first time to use this library.
When the update program is started, the update window does not seem to have the focus and can be closed alone.
How can I set the forced update?
In addition, can I set the minimum update version?
Thank you.

@howzew
Thanks for your questions.

How can I set the forced update?

This is intentional behavior. You can do a few things if you want to try to get the user to update their software:

Set the app cast version as critical. You can use this via the app cast generator via the --critical-versions flag, e.g. --critical-versions 1.0.1.
Use the UIFactory.ProcessWindowAfterInit function to make any modifications to the window you want to make after it's been created.
Use your own UIFactory implementation to do what you want and show windows how you want to show them (e.g. as a dialog, etc.)
Don't use a built-in UI at all and run your own UI. There's a sample called HandleEventsYourself that will help you know how to do this.

In addition, can I set the minimum update version?

This is not a built-in feature, but you can filter app cast items yourself based on the version of the software you're using and the versions in the app cast. Implement the IAppCastFilter XMLAppCast.AppCastFilter class member and run your own filtering.
In other words, for both of your questions, you can implement things in a custom way to get things running just as you'd like them. :-)

@Deadpikle
Thanks for your reply. It seems that I need to implement it myself.
These two functions are commonly used functions. so it would be very convenient if they can be built-in in 3.x.
However, thank you for the method you provided, I will test it.


Add the run-example-docker.sh

It creates a docker image with also Samtools and BWA in order to run the
"Prohla"-typing: section of the README.md with the reads in
tools/test_reads.fastq.

My github fu is not so good, so the rebased version of this PR is #145


Search doesn't search on static storybooks

Describe the bug
Search doesn't search on staticly deployed Storybooks.
To Reproduce
Steps to reproduce the behavior:

Go to a static storybook here or the official SB
Click on the search input
Start typing
See that it doesn't instantly filter

Expected behavior
It begins filtering the stories list
Screenshots
A deployed SB (bad)

On localhost (good)

if interested, there is a workaround identified in #5907 (and a pr to fix in #5907)

Closing as duplicate to #5907. Community is one step ahead @domyen 😘


Update bnc-onboard

Onboard updated their WalletConnect dependency here which is a recommended update: https://github.com/blocknative/onboard/blame/develop/package.json#L70
How to test
Just a quick test that logging in and confirming transactions with WC still works.

why a different eslint action :O? the current one works pretty nice

@mikheevm because it's failing on this PR: https://github.com/gnosis/safe-react/runs/3240039357?check_suite_focus=true

@katspaugh it's pretty clear why it is failing, why not just update node version?

@mikheevm from what I see it's already version 14. The same as we use in the test job. The test job somehow doesn't have any issues.

@katspaugh it wants >=14.17 and we have 14.15

Oh, OK, I'll try that.
In general, the idea of supporting our own fork for a very standard thing like eslint seems to be an unnecessary maintenance overhead. I'd rather use an upstream version that is supported by the someone else.
But for this particular PR, let me update the Node version like you said.

In general, the idea of supporting our own fork for a very standard thing like eslint seems to be an unnecessary maintenance overhead. I'd rather use an upstream version that is supported by the someone else.

Fully agree, but these things just didn't compile with our project, as you can see in the fork I had to add some libraries to make it work. The one you added looks nice, we can evaluate switching if it works well

Thanks for the help @mikheevm 🎉

https://github.com/gnosis/safe-react/pull/2149 uses onboard 1.32.0 too, maybe it makes sense to do QA in a different PR

Safe used for testing:
https://pr2606--safereact.review.gnosisdev.com/bsc/app/#/safes/0xabD33ecC5E2a586AC7A4000528BeF293c56f9AE2/transactions
It worked fine for the most part.
At some point I had issues with a JSON-RPC error that corrected itself after resetting the MM app in the phone
I'll leave the snapshots to see if this issues have something to do with the WC connection. (since after resetting the MM app it worked fine I'll assume it doesn't)

@francovenica please don't do any further qa, we have other PRs that touch wallet integration too, we'll merge them and then test it once. See my comment above

Closing in favor of https://github.com/gnosis/safe-react/pull/2149/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R186

#2149 is blocked, so I'm reopening this.

I was testing it again, it connects fine but creating a safe gets stuck. Tx succeeds on the wallet side (a safe with the WC app) but the receiving safe doesn't see it. The same happens on production, so it's not a regression in this PR.

@katspaugh should we update to 1.33? 1.32 is not the latest anymore

The initial connection itself is fine for me.

I'm having the same problem in https://github.com/gnosis/safe-react/pull/2149 with the same onboard version. I recently saw that we removed the blocknative API key, can it be related?

People in blocknative discord complain too https://discord.com/channels/542403978693050389/542406894677917699/874553014948614154

Should we bring changes from this pr https://github.com/gnosis/safe-react/pull/2626 to this one?

@mikheevm we shouldn't blow up the scope of PRs. This one is just about updating one particular package.
That PR adds a wallet and from what I understood we don't add new wallets unless the PO asks us.

How does adding a wallet blow up the scope?
Afaik we've been in touch with keystone for some time and got a test wallet from them

The title of the PR defines its scope, @mikheevm.
If Keystone must be added (and again, this is something the PO decides), it needs to be in another PR. I dunno why #2626 was closed.

Closing because @dasanra says it needs to be fixed on the onboard side.


Disable agent if not running on Linux

If the agent is running on OSX or some other OS it should disable itself to avoid raising errors while attempting to collect Linux-specific telemetry data.

If no one objects, I could try to implement this in the next few days.
I could take advantage of a built-in: sys.platform (py docs) and raise a warning if it's not linux ie.
if not sys.platform.startswith('linux'):
    warning.warn('...')

and than disable IOpipe.

@mislavcimpersak No objections. :)
We're planning some major updates to the Python agent in the upcoming months, but this and #96 will definitely be included.

We still report when using sls invoke and other "local invoke" mechanisms on NodeJS, and we've made this work on MacOS by having os-dependent functions (mostly replacing with mock values, currently)
It would be nice if we can do the same on Python!

Here's the mock system in the node agent that @ewindisch  is referring to:
https://github.com/iopipe/iopipe/blob/master/src/mockSystem.js
I've started breaking out the system functions into a separate module similar to the way the node agent does it:
https://github.com/iopipe/iopipe-python/pull/98/files#diff-8fade00045091f378ca7f96cf522b080
I think an equivalent mock_system module would make sense.


docs: ✏ remove doc for deleted /hub-cache endpoint

followup for #1826

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

btw let's also remove /valid no?

yes, the PR is already ready: https://github.com/huggingface/datasets-server/pull/1777


Make asciidoctor truly optional

https://github.com/newsboat/newsboat/commit/dcb6038ee0222274e4b9f02a10fbacb462d4765e introduced a check for commands needed to build Newsboat: Asciidoctor and Cargo. However, Asciidoctor is optional because it's only used for building docs (https://github.com/newsboat/newsboat/issues/1885). This commit removes the check, so Newsboat can truly be built with just the necessary dependencies installed.
This makes the build process slightly less nice, because the user won't get an up-front warning about the missing Asciidoctor. To regain that warning, I think we'd need to check for the program from within Makefile iff doc target is being built (or any target that depends on doc). This sounds too complicated to be worthwhile, though.
Fixes #2353.

Correct me if I'm wrong, but 'doc' target, according to Makefile spec, should not be included in 'all' target:
‘all’
Compile the entire program. This should be the default target. This target need not rebuild any documentation files; Info files should normally be included in the distribution, and DVI (and other documentation format) files should be made only when explicitly asked for.
One should be able to build and install newsboat, podboat and mo-files with just 'make && make install' and manpages optionally with 'make doc'. This would make patching source based install scripts, such as Gentoo ebuild (https://bugs.gentoo.org/831123) much more straightforward.

@ossimoi Interesting point! I moved that discussion to https://github.com/newsboat/newsboat/issues/2446 so we can focus on the immediate changes here.


Move ecdsa from extras_require to install_requires

ecdsa is imported by btchipKeyRecovery.py which is imported by btchip.py. Importing btchip.py results in an ImportError without ecdsa installed, so it is a required module.

First of all, yes, fully agree, ecdsa is a required dependency, so please merge this PR if you just want the easy fix.

However, btchipKeyRecovery.py, the only module that imports ecdsa is all just broken dead code (assuming python3).
https://github.com/LedgerHQ/btchip-python/blob/17f27c1996c75145b8eb5d16583bddcb6e2bf691/btchip/btchipKeyRecovery.py#L10-L13
It is copied from old electrum code, from python2 times.
import msqr is not valid in python3; it should be replaced with from . import msqr
In light of of no one complaining for years, maybe btchipKeyRecovery.py should just be removed (along with references), and then ecdsa would not be a dependency at all.

@btchip please either make ecdsa a required dependency in setup.py as in this PR, or change the code so that ecdsa is not required for using the library
Electrum no longer requires ecdsa since https://github.com/spesmilo/electrum/commit/5a2d588e8bfa36889117b205ae6b04ec7e0ddd3a, and this is now causing troubles here (see https://github.com/spesmilo/electrum/issues/6928)

First of all, yes, fully agree, ecdsa is a required dependency, so please merge this PR if you just want the easy fix.

However, btchipKeyRecovery.py, the only module that imports ecdsa is all just broken dead code (assuming python3).
https://github.com/LedgerHQ/btchip-python/blob/17f27c1996c75145b8eb5d16583bddcb6e2bf691/btchip/btchipKeyRecovery.py#L10-L13
It is copied from old electrum code, from python2 times.
import msqr is not valid in python3; it should be replaced with from . import msqr
In light of of no one complaining for years, maybe btchipKeyRecovery.py should just be removed (along with references), and then ecdsa would not be a dependency at all.

@btchip please either make ecdsa a required dependency in setup.py as in this PR, or change the code so that ecdsa is not required for using the library
Electrum no longer requires ecdsa since https://github.com/spesmilo/electrum/commit/5a2d588e8bfa36889117b205ae6b04ec7e0ddd3a, and this is now causing troubles here (see https://github.com/spesmilo/electrum/issues/6928)

Please merge this and do a release.
Since Electrum no longer requires ecdsa, we keep getting support requests due to this from Ledger users.


256-color terminal support

Very nice project, I've been pondering abut something like this for a while, and existing Python console support projects seem to have died a quiet death.
A small feature request: Most terminals these days support 256 color (gnome, konsole, even old xterm/mrxvt). It'd be awesome if you could use these colors in Clint (for example, by setting colors as RGB and choosing the closest color). We're now in 2011 and 8-color text is old-fashioned :)
I might get around to implementing this myself and submitting a patch. I have code for this in one of my other projects. (As for lists of R/G/B values,  and/or color names, IPython could be an inspiration as it has a module for it)

I read the linked doc but I don't know why tput colors is not a good method.

The “tput colors” command shows the amount of colors specified in the terminfo entry specief by TERM.

So this means in theory there would not be any need to keep a list of supported TERMs. If tput colors says 8, it's up to the user to configure the terminal to display more colors, and clint should probably do what other programs do, fall back to an approximate value within those available colors.
What is really blockiing this merge?

Yes, in theory you're right. But if you want it to work out of the box in for example Ubuntu (gnome terminal), just taking the tput value for granted is not enough. It returns 8... :(

That's right, but what I mean is that we still should rely on what tput says. Other programs like Vim or Tmux use the 8 color approximations until I set the TERM properly. It's a pain, but the bug is in the distros or the terminals, I guess. It shouldn't be a blocker for Clint, I think.

Fine with me, the checks for TERM/COLORTERM can always be added in later.


Update rippled-example.cfg

The quorum (minimum number of validators needed to accept consensus) is now calculated internally

Jenkins Build Summary
Built from this commit
Built at 20171220 - 03:29:16
Test Results

Build Type
Result
Status

Author Check
intelliot is not a collaborator!
FAIL :red_circle:

While you're at it ...
RocksDB default node store ??


[libfv] Add new port

Describe the pull request

What does your PR fix?
add new port libfv

Which triplets are supported/not supported? Have you updated the CI baseline?
Support for all platforms, because only copy header files, so I have no test

Does your PR follow the maintainer guide?
Yes.

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

something is wrong :(
command log
D:\GitHub\_\vcpkg>vcpkg x-add-version --all
warning: there are uncommitted changes for fawdlstty-libfv
warning: can't obtain SHA for port fawdlstty-libfv
-- Did you remember to commit your changes?
***No files were updated***
internal error: D:\a\_work\1\s\src\vcpkg\commands.add-version.cpp(556): vcpkg has crashed; no additional details are available.
Please open an issue at https://github.com/microsoft/vcpkg/issues/new?template=other-type-of-bug-report.md&labels=category:vcpkg-bug with detailed steps to reproduce the problem.

Thanks for the PR!


Scripts automatically open when switching between scenes, causing unnecessary popups when working with external IDEs

Tested versions

Tested and reproducible in v4.2.1.stable.mono.official

System information
Godot v4.2.1.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 3GB (NVIDIA; <IP_ADDRESS>23) - Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 Threads)
Issue description
When disabling the godot engine's script editor through Editor > Manage Editor Features, the editor continues to open up files automatically. This is particularly annoying if you are working with an external IDE, as you will continue to get popups from script files asking if they should reload.
When switching between scenes, the script editor will randomly open code files. This is annoying in of itself, but when the script editor is disabled this makes it impossible to go and close those scripts.
I should note that this only appears to happen if the script is in the root node of a scene, but it is incredibly annoying and is driving me nuts.
Steps to reproduce

Create a script file
Create 2 scenes
Add the new script to the root of the first scene.
Close the script in the script editor if it is open.
Switch between different scene tabs and the file will re-open itself.
Close the file in the script editor
Go to editor > manage editor features
Disable the script editor
Switch between scenes
Edit the script in an external editor
A popup will appear asking what action you would like to take.

Minimal reproduction project (MRP)
Reproduction.zip

Do you have distraction free mode active? If so this would be a duplicate of:

https://github.com/godotengine/godot/issues/90654

And should be fixed in 4.3 by:

https://github.com/godotengine/godot/pull/91168

Do you have distraction free mode active?

No, this happens with distraction free mode is enabled or disabled. This happens because when you switch to another scene, if the root node has a script attached to it then it will automatically open in the script editor. This is really annoying if you are using an external IDE for editing scripts as it will constantly ask you if you want to reload or overwrite the changes, and causes loss of data ocassionally even if you reload.

Can reproduce in Godot v4.2.1.stable and master v4.3.dev.custom_build [2042420bd] - Windows 10.0.22631
I don't think #90654 is related.
It looks like the Script Editor opens it and keeps working even if it is disabled.
What external editor are you using?
I can only get it to happen with certain ones like notepad but not VSCode.
Try turning off this Editor Setting that opens the root node's script: text_editor/behavior/files/open_dominant_script_on_scene_change
Also, there is an external editor setting that doesn't have this issue: text_editor/external/use_external_editor
But this requires the Script Editor EditorFeature to be enabled to work.

With open_dominant_script_on_scene_change disabled, the issue no longer happens as scripts are not opened in the background anymore.
I am using visual studio 2022, however I believe this will work with all editors since the message pops up whenever the file is edited while it is open in the Godot script editor. The issue is that even if the script editor is disabled, it will continue to open up the dominant script on scene change and while files are open in Godot's script editor, the file change message will continue to appear when you modify those files.


Notice about react-router

I found that Link of react-router doesn't pass activeClassName property after changing the history (e.g. I have product categories and clicked on next category).
It works only with with shouldComponentUpdate: true. I think it's because of mobx-react uses pure render and there were no update of properties or state.
You can try the script with/without @observer and @inject.
import React, {
  Component
} from 'react';

import {
  observer,
  inject
} from 'mobx-react';

import Category from '../atoms/Category';

@inject((allStores) => ({
  items: allStores.store('categories')
})) @observer
class CategoriesList extends Component {
  shouldComponentUpdate() {
    return true;
  }

  render() {
    const {
      items
    } = this.props;

    // let items = [{
    //   id: 1,
    //   permalink: '1111',
    //   pretty_name: '1111'
    // }, {
    //   id: 2,
    //   permalink: '2222',
    //   pretty_name: '2222'
    // }];

    const categoriesRender = items.map((elem) => {
      return (
        <Category key={elem.id} data={elem} />
      );
    });

    return (

        {categoriesRender}

    );
  }
};

export default CategoriesList;

import React, {
  Component
} from 'react';

import {
  Link
} from 'react-router';

class Category extends Component {
  render() {
    const {
      data
    } = this.props;

    return (

          <Link to={`/all/${data.permalink.toLowerCase()}`}  activeClassName="active"> {data.pretty_name}</Link>

    );
  }
};

export default Category;

Try to upgrade to react-router 3.0 alpha. I think they have found a workaround for https://github.com/facebook/react/issues/2517

@jtraub did you try withRouter? see also https://github.com/reactjs/react-router/issues/3439

I tried react-router 3.0.alpha2 and it fixes this problem but makes some other. So I'll leave it as is and change it later.
But it was very helpful. I found that it's not only my problem and fix is in the changelog:
https://github.com/reactjs/react-router/blob/a30defc3875e1abbb3978b5728db4b7d049a52f3/CHANGES.md


Needs helper text

Right now, this tool can only really be used by people who know what they're doing. To be more intuitive, some info should be added.
Some questions I had while using it:

Which of these fields are required for the datapackage format?
What do these fields mean? (Particularly important considering how confusing "title" and "name".
A link back to the datapackage specs to answer any other questions would be good too.

@sanjaypoyzer +1 - we are working on it.

FIXED. @sanjaypoyzer see http://datapackagist.okfnlabs.org/ which is a much more powerful version of the demo app available since last year.


Register Support and Training Info

Hi thanks for your work. I want to ask that if this repo supports the register added version of dinov2. Also I want to ask that I am planning to do a training with 112x112 images, do you have any experiments with low resolution images for DinoV2 training?
And last question, in your experiments, how much time does it take to finetune the model (On which gpu also) ?
Thanks.

You can just resize your imgs and labels in data transformation part. And finetuning on single 4080, it takes me several hours to train one epoch.

Thank you


[CompactGate] Compile-time detection of steps that are narrowed but never trigger send in the protocol

Goal
Enable compile-time detection of steps that are narrowed but never trigger send in the protocol.
Context
Descriptive gate allows unnecessary narrow even if the step doesn't trigger send. There are a couple of reasons this could happen:

(a) A step is narrowed, but doesn't trigger send before the next narrow. It could be intentional (e.g., grouping, safe-guard) or unintentional (e.g., sub-protocol used to require the caller to narrow in advance, but the design changed).
(b) A step is narrowed, but the send is conditionally executed. (i.e., do_the_binary_tree_thing, fallback)
(c) PRSS value generations
(d) any more cases?

We want to detect these cases at compile time and fail the build but need to be able to support (b). To support (b), we could use an attribute to a proc macro, but this requires #704. Also read #706 for a similar case that we need to take into account.

fixed with #767


Why!?

I have to ask - why would anyone in the financial industry possibly need this feature?!
Thanks for the amusement!

For important business reasons.


Universal jest string fromat

The problem:
Jest needs to support different platforms when it prints its output (terminal, nuclide, html, terminal with no color support, snapshots)
There's a few ways we can implement that, but after our discussion with @kentaromiura we focused more on investigating some universal jest format.
Here's my thought on what it may look like:

A jest-print-utils package that will export the following API:

type JestFormatedString = string;

type JestPrintUtils = {
  green: (input: string) => JestFormatedString,
  red: (input: string) => JestFormatedString,
  bold: (input: string) => JestFormatedString,
  dim: (input: string) => JestFormatedString,
 // ...
};

JestFormattedString type is jest a string that follows jest specific print format (a string with XML-like tags describing fonts)
Example:
import {red, green} from 'jest-print-utils';

const jestFormattedString = `hey, i'm ${green('green')}. and i'm ${red('red')}`;
console.log(jestFormattedString);
// hey i'm <JEST_GREEN_TAG_UUID>green</JEST_GREEN_TAG_UUID>. and i'm <JEST_RED_TAG_UUID>red</JEST_RED_TAG_UUID>

where UUID tags can be found in a common constant definition (to make sure they're unique and don't overlap with hmtl markup or similar)
JEST_UUID_TAGS: {
  RED: `RED_${uuid.gen()}`,
  GREEN: `GREEN_${uuid.gen()},
  // ...
}

A jestFormattedString converters that can convert JestFormattedString type to any other string types (html, ASCII, strip tags completely, or something else)
Example:

import {green, toHTML, toASCII, toNoColors, toSnapshotFormat} from 'jest-print-utils';

const str = `i'm ${green('green')}` // => 'i'm <JEST_GREEN_UUID>green</JEST_GREEN_UUID>

toHTML(str); // i'm green
toASCII(str); // i'm 0[m21green (or whatever the format is)
toNoColors(str) // i'm green
toSnapshotFormat(str) // i'm <green>green</green>

cc @kentaromiura @thymikee

A couple of thoughts:

Let's please not call it "util".  I want to get rid of all the files and packages called "util" in Jest.
If we do this, we gotta stop using red and green and give semantic meaning to the way we format text. Instead of red, we should use error. This will also allow to change what that looks like in different places, like Nuclide.
I'm a bit worried that the end result here is a slightly more structured string format that we'll regex over to turn it from one format to another, the added value isn't actually that much. How about we start using JSX with different renderers? That seems to me like the best way to build a structured data format for Jest.

Are we seriously considering JSX to format messages? If so, I think I could give it a try and implement this (after we settle this is actually a good idea).
I imagine formatting message like this:
const {JestFormat, Default, Error} = require('jest-format');
const jsx = <Default>Some <Error>text</Error> message</Default>;

Which then would go through Babel to output something like this:
const jsx = JestFormat.createElement(
  Default,
  null,
  'Some ',
  JestFormat.createElement(Error, null, 'text'),
  ' message',
);

Which would format to something like this:
JestFormat.createElement = function(type, props, children) {
  const result = {
    $$typeof: Symbol.for('JEST_FORMAT'),
    props,
    type: Default,
  };
  return result;
};

This way we could easily write recursive renderers for html, ansi, etc and custom ones for editors support, as they would need to deal with JSON only.
Let me know what you think @dmitriiabramov @kentaromiura

Yeah I think this could work. We don't need React, we just needn't JSX with the @jsx pragma. Curious what this would look like.

that actually looks amazing. How will we send serialized objects to other processes though?

A message will be JSON data after all, so it shouldn't be problematic.

As per Christoph suggestion, using the jsx pragma it will be possible to create a function like:
/** @jsx format */

const format = (type, _, ...parts) => {
  return {
    type,
    parts,
    [Symbol.for('custom-format')]: true
  }
}

var message = (
  <message>
    Error: expected value to be (using ===):
    <expected>"bar"</expected>
    Received:
    <received>"foo"</received>
  </message>
);

Then we could just feed pretty-format the most appropriate plugin to have that message output how we wants;
and example of the html render might be similar to this:
{
    test: x => x[Symbol.for('custom-format')],
    print: (val,print,opt,color) => (
      '' + val.parts.map(val => {
        if (typeof val === 'string') return val;
        return print(val, print, opt, color)
      }).join('') + '')
}

https://jsfiddle.net/fjfuabya/

@kentaromiura that looks amazing!
we only need to fix the whitespace. but i think we can just add some padding to elements like <expected> and <received>

Actually we could adjust whitespace and indentation in props:
<message indent={1}>
    Error: expected value to be (using ===):
    <expected indent={1}>"bar"</expected>
    Received:
    <received indent={1}>"foo"</received>
</message>

Also, it's going to be a ton of work to change all the messages 😐

and what about newlines? :)
how to we tell
this is <green>green</green>

from
this is
<green>green</green>

I don't think there's any way to detect the new line from code.
/* @jsx h */

  foo
  bar

/* @jsx h */
h(
  "div",
  null,
  "foo bar"
);

Could have a <linebreak> or {'\n'}.

Almost 5 years without movement, I think we can close this (doing something like #7910 makes more sense to me, and if that ever happens, it would unblock doing the work discussed heree)


1867 in app reporting implement charts and graphs for in app reporting

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #1867
Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

Chart UI scoping is still pending. Closing this PR for now.


"Array access is not valid for client expressions", page fields

Describe the request
To be able to create at least somewhat generic lists without hundreds of copypasted lines and variables, we would need to be able to have array access in client expressions. Is there a specific reason this works:
field(Col1; Col[1])
  {
      CaptionClass = '3,' + GetColumnHeading(LeftMostColumn + 1);
      ToolTip = '-', Locked = true;
      Visible = MaxColumns >= 1;
  }

but this (array access) does not?
field(Col1; Col[1])
  {
      CaptionClass = '3,' + GetColumnHeading(LeftMostColumn + 1);
      ToolTip = '-', Locked = true;
      StyleExpression = FieldValidated[1];
  }

If the caption can be fetched from a function during runtime, and properties such as visibility, style, enabled, can be evaluated from a boolean OR expression, why could they not be taken from an array?
It would be great to have this for all the modifiable page field properties.
An array we can handle reasonably in a loop, even if we couldn't use a function directly
  trigger OnAfterGetRecord()
  var
      i: Integer;
  begin
      for i := 1 to PAGEMAXCOLUMNS - 1 do
          FieldValidated[1] := GetFieldValidated(i);
  end;

Additional context
Generic code with a loop instead of copypasting hundreds of lines and tens of variables improves quality, makes for better maintainability and readability etc. and this would also make BC a better platform for new solutions.

Hi,
I agree, just FYI, the problem is not with the array expressions but with StyleExpr. You can have a look at places like SalesAnalysisMatrix.Page.al, InventoryAnalysisMatrix.Page.al, PurchaseAnalysisMatrix.Page.al. It is solved by using individual variables for each field.
Unfortunately, this repository is only for tracking extensibility requests (through existing AL constructs, i. e. AL events and interfaces), what you ask for is out of this scope.
However this would be great, so I encourage you to bring it up in https://aka.ms/bcideas , where we monitor these kind of requests. Ideas with enough votes get considered for planning in next waves.
I'll close the issue in this repo.

.

Closing as not planned.


Updated AWS plugin

Fixed export option to work in Mac (I think)
Added remove option
Other minor changes

Seems that the Mac fix don't work, so I need to change the code again :_(

Ready for merge!

@nwinkler, @tswicegood can you validate this PR and proceed with the merge?
Thanks!

Sorry, I can't really verify this, since I'm not using AWS...

@nwinkler no problem, thanks!

This is working fine, so I will proceed to merge this PR.


Suggestions

Some things to add:

Under IDE's, Visual Studio Code
Under Browsers, Chromium
Under graphics, Piskel, Inkscape, Pinta

Visual Studio Code binaries are actually under a proprietary Microsoft license: https://code.visualstudio.com/license. Only the source code is released under the MIT license, which is kind of deceptive. I would not feel comfortable adding this piece of software to the list.
However, the others are great suggestions! I have added them.

Thank you for taking my suggestions!


Debug SSE's in digital ocean

Currently the SSE endpoint (https://lobster-app-zabc8.ondigitalocean.app/metadata) is not providing an active event stream. Instead, it craps out after 50s and returns an improper connection error. It is unknown if this is an issue with digital ocean's app platform specifically, or SSEs in general, but both will need to be researched further. Ideally I'd rather work with SSEs over the app platform, as it's providing fairly essential functionality with the metadata push

The issue was with digital ocean
https://www.digitalocean.com/community/questions/does-app-platform-support-sse-server-sent-events-application
I will be weary about using the app platform for long-term deployment, but for now, this seems functional.


[RFC] Supports Api-Platform

Hi,
I have been working on a project using api-platform to generate the api and we made a bridge between api-platform and this bundle.
Do you want to integrate this bridge ? It's ready to use and I could make an PR for that, this generate an api using the history of one entity

Sorry, but we do not have the resources to maintain further integrations. The plan is to split this project in a library and bundle. If we are done with it, then we can see if someone wants to maintain it.