[PDPI] Add gmock matcher that tests that a P4Runtime message is a packet in.

PR Description :
[PDPI] Add gmock matcher that tests that a P4Runtime message is a packet in.
Build Results :
bibhuprasad@eaba4ee0062c:/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 252 targets (1 packages loaded, 166 targets configured).
INFO: Found 252 targets...
INFO: Elapsed time: 5.152s, Critical Path: 3.84s
INFO: 10 processes: 5 internal, 5 linux-sandbox.
INFO: Build completed successfully, 10 total actions
bibhuprasad@eaba4ee0062c:/sonic/src/sonic-p4rt/sonic-pins$
UT Results :
bibhuprasad@eaba4ee0062c:/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS gutil/...
INFO: Analyzed 22 targets (0 packages loaded, 0 targets configured).
INFO: Found 14 targets and 8 test targets...
INFO: Elapsed time: 0.341s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//gutil:collections_test                                        (cached) PASSED in 0.5s
//gutil:io_test                                                 (cached) PASSED in 0.4s
//gutil:proto_matchers_test                                     (cached) PASSED in 0.4s
//gutil:proto_test                                              (cached) PASSED in 0.3s
//gutil:status_matchers_test                                    (cached) PASSED in 0.4s
//gutil:table_entry_key_test                                    (cached) PASSED in 0.0s
//gutil:testing_test                                            (cached) PASSED in 0.2s
//gutil:version_test                                            (cached) PASSED in 0.2s
Executed 0 out of 8 tests: 8 tests pass.
INFO: Build completed successfully, 1 total action
bibhuprasad@eaba4ee0062c:/sonic/src/sonic-p4rt/sonic-pins$
bibhuprasad@eaba4ee0062c:/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS p4_pdpi/...
INFO: Analyzed 84 targets (0 packages loaded, 0 targets configured).
INFO: Found 48 targets and 36 test targets...
INFO: Elapsed time: 0.861s, Critical Path: 0.35s
INFO: 2 processes: 1 internal, 1 linux-sandbox.
INFO: Build completed successfully, 2 total actions
//p4_pdpi:ir_tools_test                                         (cached) PASSED in 0.4s
//p4_pdpi:sequencing_util_test                                  (cached) PASSED in 0.5s
//p4_pdpi/netaddr:ipv4_address_and_network_address_test         (cached) PASSED in 0.5s
//p4_pdpi/netaddr:ipv6_address_test                             (cached) PASSED in 0.2s
//p4_pdpi/netaddr:mac_address_test                              (cached) PASSED in 0.2s
//p4_pdpi/packetlib:packetlib_fuzzer_test                       (cached) PASSED in 15.2s
//p4_pdpi/packetlib:packetlib_matchers_test                     (cached) PASSED in 0.2s
//p4_pdpi/packetlib:packetlib_test                              (cached) PASSED in 0.1s
//p4_pdpi/packetlib:packetlib_test_runner                       (cached) PASSED in 0.1s
//p4_pdpi/packetlib:packetlib_unit_test                         (cached) PASSED in 0.9s
//p4_pdpi/string_encodings:bit_string_test                      (cached) PASSED in 0.4s
//p4_pdpi/string_encodings:byte_string_test                     (cached) PASSED in 0.7s
//p4_pdpi/string_encodings:decimal_string_test                  (cached) PASSED in 0.2s
//p4_pdpi/string_encodings:decimal_string_test_runner           (cached) PASSED in 0.1s
//p4_pdpi/string_encodings:hex_string_test                      (cached) PASSED in 0.1s
//p4_pdpi/string_encodings:hex_string_test_runner               (cached) PASSED in 0.1s
//p4_pdpi/string_encodings:readable_byte_string_test            (cached) PASSED in 0.3s
//p4_pdpi/testing:helper_function_test                          (cached) PASSED in 0.3s
//p4_pdpi/testing:info_test                                     (cached) PASSED in 0.1s
//p4_pdpi/testing:info_test_runner                              (cached) PASSED in 0.0s
//p4_pdpi/testing:main_pd_test                                  (cached) PASSED in 0.0s
//p4_pdpi/testing:mock_p4_runtime_server_test                   (cached) PASSED in 0.3s
//p4_pdpi/testing:packet_io_test                                (cached) PASSED in 0.1s
//p4_pdpi/testing:packet_io_test_runner                         (cached) PASSED in 0.0s
//p4_pdpi/testing:rpc_test                                      (cached) PASSED in 0.1s
//p4_pdpi/testing:rpc_test_runner                               (cached) PASSED in 0.1s
//p4_pdpi/testing:sequencing_test                               (cached) PASSED in 0.1s
//p4_pdpi/testing:sequencing_test_runner                        (cached) PASSED in 0.0s
//p4_pdpi/testing:sequencing_util_test                          (cached) PASSED in 0.0s
//p4_pdpi/testing:sequencing_util_test_runner                   (cached) PASSED in 0.0s
//p4_pdpi/testing:table_entry_gunit_test                        (cached) PASSED in 0.3s
//p4_pdpi/testing:table_entry_test                              (cached) PASSED in 0.1s
//p4_pdpi/testing:table_entry_test_runner                       (cached) PASSED in 0.1s
//p4_pdpi/utils:annotation_parser_test                          (cached) PASSED in 0.4s
//p4_pdpi/utils:ir_test                                         (cached) PASSED in 0.4s
//p4_pdpi:p4_runtime_matchers_test                                       PASSED in 0.3s
Executed 1 out of 36 tests: 36 tests pass.
INFO: Build completed successfully, 2 total actions
bibhuprasad@eaba4ee0062c:/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS p4rt_app/...
INFO: Analyzed 106 targets (0 packages loaded, 0 targets configured).
INFO: Found 68 targets and 38 test targets...
INFO: Elapsed time: 0.406s, Critical Path: 0.01s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//p4rt_app/event_monitoring:app_state_db_port_table_event_test  (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:app_state_db_send_to_ingress_port_table_event_test (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:config_db_node_cfg_table_event_test (cached) PASSED in 0.6s
//p4rt_app/event_monitoring:config_db_port_table_event_test     (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:debug_data_dump_events_test         (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:state_verification_events_test      (cached) PASSED in 0.5s
//p4rt_app/p4runtime:ir_translation_test                        (cached) PASSED in 0.5s
//p4rt_app/p4runtime:p4info_verification_schema_test            (cached) PASSED in 0.4s
//p4rt_app/p4runtime:p4info_verification_test                   (cached) PASSED in 0.6s
//p4rt_app/p4runtime:packetio_helpers_test                      (cached) PASSED in 0.5s
//p4rt_app/sonic:app_db_acl_def_table_manager_test              (cached) PASSED in 0.4s
//p4rt_app/sonic:app_db_manager_test                            (cached) PASSED in 0.5s
//p4rt_app/sonic:app_db_to_pdpi_ir_translator_test              (cached) PASSED in 0.4s
//p4rt_app/sonic:hashing_test                                   (cached) PASSED in 0.4s
//p4rt_app/sonic:packetio_impl_test                             (cached) PASSED in 0.3s
//p4rt_app/sonic:packetio_port_test                             (cached) PASSED in 0.3s
//p4rt_app/sonic:response_handler_test                          (cached) PASSED in 0.3s
//p4rt_app/sonic:state_verification_test                        (cached) PASSED in 0.5s
//p4rt_app/sonic:vrf_entry_translation_test                     (cached) PASSED in 0.4s
//p4rt_app/sonic/adapters:fake_sonic_db_table_test              (cached) PASSED in 0.2s
//p4rt_app/tests:acl_table_test                                 (cached) PASSED in 1.0s
//p4rt_app/tests:action_set_test                                (cached) PASSED in 0.7s
//p4rt_app/tests:api_access_test                                (cached) PASSED in 0.6s
//p4rt_app/tests:arbitration_test                               (cached) PASSED in 0.7s
//p4rt_app/tests:fixed_l3_tables_test                           (cached) PASSED in 2.3s
//p4rt_app/tests:forwarding_pipeline_config_test                (cached) PASSED in 3.4s
//p4rt_app/tests:grpc_behavior_test                             (cached) PASSED in 5.0s
//p4rt_app/tests:p4_constraints_test                            (cached) PASSED in 0.1s
//p4rt_app/tests:p4_constraints_test_runner                     (cached) PASSED in 0.2s
//p4rt_app/tests:p4_programs_test                               (cached) PASSED in 1.0s
//p4rt_app/tests:packetio_test                                  (cached) PASSED in 3.3s
//p4rt_app/tests:port_name_and_id_test                          (cached) PASSED in 0.9s
//p4rt_app/tests:response_path_test                             (cached) PASSED in 3.0s
//p4rt_app/tests:role_test                                      (cached) PASSED in 0.7s
//p4rt_app/tests:state_verification_test                        (cached) PASSED in 1.1s
//p4rt_app/tests/lib:app_db_entry_builder_test                  (cached) PASSED in 0.1s
//p4rt_app/utils:event_data_tracker_test                        (cached) PASSED in 0.1s
//p4rt_app/utils:table_utility_test                             (cached) PASSED in 0.8s
Executed 0 out of 38 tests: 38 tests pass.
INFO: Build completed successfully, 1 total action

Co-authored-by: Steffen Smolka<EMAIL_ADDRESS>

@kishanps, Could you please review.
Thanks.


Microsoft.Bot.Builder.Solutions Points to this Repo as its Source Repository

The Microsoft.Bot.Builder.Solutions Nuget Package points as this Repo as the Project Url
On Nuget this Project is also listed as the Source Repository
However neither is accurate Likely not an issue with this project as much as with the project that has this project listed but given I cant find that repository to log the issue.
Any guesses who or where Microsoft.Bot.Builder.Solutions actually is?

I am looking into this....

For what it's worth the bug that sent me on this quest was in part that Microsoft.Bot.Builder.Solutions has recently deprecated a huge chunk of code in favour of the code in  Microsoft.Bot.Solutions which I think is the code at https://github.com/microsoft/botframework-solutions. However Microsoft.Bot.Solutions also seems to claim this site as its Project url and source repository.


Add optional signature and certificate values to JSON requests

These changes allow the cJSON requests we pass to hold request signatures and certificate values, along with their respective lengths. If these values are not passed by the user, they are given empty placeholder values instead. Additional assertions and test cases have been added to reflect these changes.

I've gone ahead and fixed the parameters for those functions. I had to change a lot of the test suite to get rid of the errors, so those will have to be fixed alongside the new function you mentioned in the email.


Error when deploying

Describe the bug
when deploying the project to Netlify - it causes an error. It cannot carry out the npx vite build.

Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-gkszhg
Steps to reproduce

click the deploy button.

Expected behavior
I expect it not to fail.
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 128
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 154128822,
  "usedJSHeapSize": 131005186,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = dice_troubles
Chat ID = 24e8e4f2a537

Additional context
Error:
An error occured while streaming this message.

@dice-troubles thanks for your patience during this beta period! This issue is being tracked and investigated in #1022 so please subscribe there for updates!


unzipped the zip file

There are several files in the request, along with file.zip. It must not be there. Please remove file.zip and make pull request again.  I have to close this request without merging. Thank you for your understanding.


Expose parentNode to custom nodes

Exposing parentNode to custom nodes so that they can react to the parentNode changing.
This implementation is only done for Svelte as I haven' t used and don't fully understand were and how to add it. The NodeProps type in system was changed which may affect the react types. I could try to make the changes I think would needed.

Thanks, I think it's a good idea :) We will check it.

Thanks for your input! We will rename parentNode to parentId and expose it.


Step dependencies

Consider a typical set of hooks:
{
  "type": "python",
  "venvActivate": ".venv/bin/activate",
  "steps": [
    {
      "name": "Format Code",
      "command": "blue ."
    },
    {
      "name": "Sort Imports",
      "command": "isort ."
    },
    {
      "name": "Ensure Style (flake8)",
      "command": "flake8 my_project"
    },
    {
      "name": "Ensure Style (pylint)",
      "command": "pylint my_project -E"
    }
  ]
}

This works great, however when the formatter fixes a long line, the linter still can complain about it because it seems like the linter is run in parallel. It would be nice to be able to specify dependencies or have a flag to label a step as something that could perform modifications so that they could be run serially. Something like:
{
  "type": "python",
  "venvActivate": ".venv/bin/activate",
  "steps": [
    {
      "name": "Format Code",
      "command": "blue .",
      "serial": true
    },
    {
      "name": "Sort Imports",
      "command": "isort .",
      "serial": true
    },
    {
      "name": "Ensure Style (flake8)",
      "command": "flake8 my_project"
    },
    {
      "name": "Ensure Style (pylint)",
      "command": "pylint my_project -E"
    }
  ]
}

Which would force execution like:
Format Code -> Sort Imports -> Ensure Style (flake8)
                            -> Ensure Style (pylint)

I see, this is a legit request and indeed, steps are completely parallelized as of now. However, in the example you provided above, a few questions remain :

Do we have to wait for serial steps to be executed to run the non-serial ones ?
What happens if a serial step fails ? Do we stop them all or keep execution going

So the way I see this, I would add a feature for serializing execution at the hook level (one level above the step level as you proposed) so that either we run everything in parallel, either everything is parallelized.
In any case, this will be a piece to get done, because the hook-package file, responsible for running the steps of a json hook file is completely built around the parallelization of steps. I'll need time if not help to have it correctly designed :)

Just to drop in my thoughts: not sure what the best choices are in the general case, but I would guess that having some set of autoformatters followed by some set of linters/style checkers would be the most common case. So I'd imagine a good choice is whatever naming and behavior works well with the case of 2+ formatters and 2+ checkers.

Hey @MatthewScholefield !
Sorry for the delay, summer is here in Paris. I implemented something that might match your usage for the serial step option :)
Feel free to review this

This has been release with 0.0.24 version :)


[5.0] Cherry-pick: Speedup for NSString -getCharacters:range

See https://github.com/apple/swift-corelibs-foundation/pull/1928

@swift-ci please test 5.0

@swift-ci please test

LGTM.

@weissi I tested this on Ubuntu18.04 and it seems to cause the swift-5.0-branch to fail some (unrelated) tests.
Where reverting back to before this commit, the tests pass. Most odd.
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:175: error: TestURLSession.test_dataTaskWithHttpInputStream : Asynchronous wait failed - Exceeded timeout of 12.0 seconds, with unfulfilled expectations: POST http://<IP_ADDRESS>:36679/echo: with HTTP Body as InputStream
Test Case 'TestURLSession.test_dataTaskWithHttpInputStream' failed (12.001 seconds)
Test Case 'TestURLSession.test_downloadTaskWithURL' started at 2019-04-19 17:04:29.634
Test Case 'TestURLSession.test_downloadTaskWithURL' passed (8.0 seconds)
Test Case 'TestURLSession.test_downloadTaskWithURLRequest' started at 2019-04-19 17:04:37.634
Test Case 'TestURLSession.test_downloadTaskWithURLRequest' passed (8.0 seconds)
Test Case 'TestURLSession.test_downloadTaskWithRequestAndHandler' started at 2019-04-19 17:04:45.634
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:214: error: TestURLSession.test_downloadTaskWithRequestAndHandler : Asynchronous wait failed - Exceeded timeout of 12.0 seconds, with unfulfilled expectations: Download GET http://<IP_ADDRESS>:36679/country.txt: with a completion handler
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:210: error: TestURLSession.test_downloadTaskWithRequestAndHandler : XCTAssertNil failed: "URLError(_nsError: The operation could not be completed)" - error = URLError(_nsError: The operation could not be completed)
Test Case 'TestURLSession.test_downloadTaskWithRequestAndHandler' failed (20.002 seconds)
Test Case 'TestURLSession.test_downloadTaskWithURLAndHandler' started at 2019-04-19 17:05:05.636
Test Case 'TestURLSession.test_downloadTaskWithURLAndHandler' passed (8.001 seconds)
Test Case 'TestURLSession.test_finishTaskAndInvalidate' started at 2019-04-19 17:05:13.637
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:161: error: TestURLSession.test_finishTaskAndInvalidate : XCTAssertNotNil failed -
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:162: error: TestURLSession.test_finishTaskAndInvalidate : XCTAssertNotNil failed -
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:163: error: TestURLSession.test_finishTaskAndInvalidate : XCTAssertNil failed: "URLError(_nsError: The operation could not be completed)" -
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:167: error: TestURLSession.test_finishTaskAndInvalidate : failed - response (nil) invalid
Test Case 'TestURLSession.test_finishTaskAndInvalidate' failed (3.998 seconds)


WIP: Update GetXXAddressForProxy

Please provide a description of this PR:

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test release-notes

unit-tests-arm64_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test release-notes

unit-tests-arm64_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests-arm64

unit-tests_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test release-notes

unit-tests-arm64_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests-arm64

unit-tests_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests

integ-basic-arm64_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests-arm64

unit-tests_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests

integ-basic-arm64_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test integ-basic-arm64

release-notes_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests

integ-basic-arm64_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test integ-basic-arm64

release-notes_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test release-notes

unit-tests-arm64_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test unit-tests

integ-basic-arm64_istio
f520d6e0469ab8c425d6d7b5adf9f8bbabb87cb1
link
true
/test integ-basic-arm64

release-notes_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test release-notes

unit-tests-arm64_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests-arm64

lint_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test release-notes

unit-tests-arm64_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests-arm64

lint_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test lint

unit-tests_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cc @howardjohn @jewertow will fix ut if it makes sense

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test release-notes

unit-tests-arm64_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests-arm64

lint_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test lint

unit-tests_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests-arm64

lint_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test lint

unit-tests_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

release-notes_istio
33c3eaad8159b4abce4df0364fd21451f6e21d92
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test lint

unit-tests_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

release-notes_istio
33c3eaad8159b4abce4df0364fd21451f6e21d92
link
true
/test release-notes

unit-tests-arm64_istio
33c3eaad8159b4abce4df0364fd21451f6e21d92
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

unit-tests-arm64_istio
33c3eaad8159b4abce4df0364fd21451f6e21d92
link
true
/test unit-tests-arm64

release-notes_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

unit-tests-arm64_istio
33c3eaad8159b4abce4df0364fd21451f6e21d92
link
true
/test unit-tests-arm64

release-notes_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test release-notes

gencheck_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

unit-tests-arm64_istio
33c3eaad8159b4abce4df0364fd21451f6e21d92
link
true
/test unit-tests-arm64

release-notes_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test release-notes

gencheck_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test gencheck

lint_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test unit-tests

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

release-notes_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test release-notes

gencheck_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test gencheck

lint_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test lint

unit-tests-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

release-notes_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test release-notes

gencheck_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test gencheck

lint_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test lint

unit-tests-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests-arm64

unit-tests_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
640ef395f0fe82b3e7bbbe22a279088b486d4332
link
true
/test integ-pilot-multicluster

release-notes_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test release-notes

gencheck_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test gencheck

lint_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test lint

unit-tests-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests-arm64

unit-tests_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests

integ-basic-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-basic-arm64

integ-security_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test release-notes

gencheck_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test gencheck

lint_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test lint

unit-tests-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests-arm64

unit-tests_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests

integ-basic-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-basic-arm64

integ-security_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-security

integ-pilot-multicluster_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test release-notes

lint_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test lint

unit-tests-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests-arm64

unit-tests_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests

integ-basic-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-basic-arm64

integ-security_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-security

integ-pilot-multicluster_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-pilot-multicluster

gencheck_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test lint

unit-tests-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests-arm64

unit-tests_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests

integ-basic-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-basic-arm64

integ-security_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-security

integ-pilot-multicluster_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-pilot-multicluster

gencheck_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test gencheck

release-notes_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests-arm64

unit-tests_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test unit-tests

integ-basic-arm64_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-basic-arm64

integ-security_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-security

integ-pilot-multicluster_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-pilot-multicluster

gencheck_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test gencheck

release-notes_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test release-notes

lint_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-security

integ-pilot-multicluster_istio
8b691e6c8479041ec9cb646934bc8ff6fb028df2
link
true
/test integ-pilot-multicluster

gencheck_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test gencheck

release-notes_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test release-notes

lint_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test lint

integ-basic-arm64_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test integ-basic-arm64

integ-distroless_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test gencheck

lint_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test lint

integ-basic-arm64_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test integ-basic-arm64

integ-distroless_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test integ-distroless

release-notes_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test integ-basic-arm64

integ-distroless_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test integ-distroless

release-notes_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test release-notes

unit-tests_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test integ-basic-arm64

integ-distroless_istio
85cd8032d735f279c810ae209aff93a10cd88b18
link
true
/test integ-distroless

release-notes_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test release-notes

unit-tests_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test unit-tests

unit-tests-arm64_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test release-notes

unit-tests_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test unit-tests

unit-tests-arm64_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test unit-tests-arm64

integ-ambient_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test unit-tests

unit-tests-arm64_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test unit-tests-arm64

integ-ambient_istio
6cd83bb40a19388c68c7f55388c6107b1bad4a27
link
true
/test integ-ambient

release-notes_istio
faa00b121f80f5c9720ee25011bfd6463d8aeaa9
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
faa00b121f80f5c9720ee25011bfd6463d8aeaa9
link
true
/test release-notes

integ-ambient_istio
faa00b121f80f5c9720ee25011bfd6463d8aeaa9
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn Anyother caveats that doesnot considered

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0740422d7bb6a68b9bd202e211711deb630e766a
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Preloading firebase storage assests(images and videos)

Hi, how can this package be used to preload firebase storage assests like images and videos before building the widget? and displaying a skeleton text while loading.  I wanted using it with this package: https://pub.dev/packages/skeleton_text

It can be achieved with CachedNetworkImage. You can add a shimmer while the image is being loaded by setting placeholder in the widget. It depends on how you are implementing each item inside the itemBuilder.

Thanks, I was able to achieve using this method: CachedNetworkImage(
imageUrl: 'imageUrl',
imageBuilder: (context, imageProvider) => Container(
decoration: BoxDecoration(
image: DecorationImage(
image: imageProvider,
fit: BoxFit.cover,
),
),
),
placeholder: (context, url) => CircularProgressIndicator(),
errorWidget: (context, url, error) => Icon(Icons.error),
),
But how do ensure the image has looaded before showing the text?

The imageBuilder accepts any Widget. You can put your text widget inside that as well and shimmer it.


shelley update mechanism

This is my WIP proposal for adding an update mechanism to Shelley. I'll add more of a description soon.

Are we still using these?

Should s be slot? Or vice-versa ...

BTW, you might want to check these:
Latexmk: List of undefined refs and citations:
  Label `fig:funcs:epoch-helper' multiply defined
  Label `fig:funcs:epoch-helper@cref' multiply defined

One thing I forgot to ask, do we check that the update proposal is stable before counting them? Otherwise what happens in the case of a rollback?

One thing I forgot to ask, do we check that the update proposal is stable before counting them? Otherwise what happens in the case of a rollback?

good question @dnadales.  New updates cannot be supplied near the end of the epoch:

SlotsPrior is the same constant used to ensure that the Praos nonce is stable at the beginning of the next epoch. Sometimes I call it "2k", but I think the precise value is being worked out.
Does this relieve your concern?

Does this relieve your concern?

Yes :)


Refactor sim merge merge

Brief description
[add description here, including any linked issues]
Type(s) of change

[ ] Bugfix
[ ] Refactor
[ ] New feature
[ ] Other

Checklist

My code follows the style guide

[ ] Yes
[ ] N/A

I've commented my code

[ ] Yes
[ ] N/A

I've incremented the version number

[ ] Yes
[ ] N/A

I've updated the changelog

[ ] Yes
[ ] N/A

I've added tests and checked code coverage

[ ] Yes
[ ] N/A

closing for a new version that incorporates paula's changes


pct-encoded reserved character(%2F) was encoded twice

PHP version: 8.1.3
Description
As of a community reporting, while the uri was already contains the pct-encoded(reserved characters) component, eg: AIO%2FFR. The {+var} syntax is explained this one as of AIO%252FFR. It is leading to misinterpreting the original percent data octet string.
I've also checked the RFC3986 and RFC6570 specifications.
RFC3986 2.4.  When to Encode or Decode was mentioned there:

Because the percent ("%") character serves as the indicator for
percent-encoded octets, it must be percent-encoded as "%25" for that
octet to be used as data within a URI.  Implementations must not
percent-encode or decode the same string more than once, as decoding
an already decoded string might lead to misinterpreting a percent
data octet as the beginning of a percent-encoding, or vice versa in
the case of percent-encoding an already percent-encoded string.

RFC6570 3.2.1.  Variable Expansion was mentioned there:

The allowed set for a given expansion depends on the expression type:
reserved ("+") and fragment ("#") expansions allow the set of
characters in the union of ( unreserved / reserved / pct-encoded ) to
be passed through without pct-encoding, whereas all other expression
types allow only unreserved characters to be passed through without
pct-encoding.  Note that the percent character ("%") is only allowed
as part of a pct-encoded triplet and only for reserved/fragment
expansion: in all other cases, a value character of "%" MUST be pct-
encoded as "%25" by variable expansion.

The pct-encoded reserved character(%2F) may pass through but it was encoded the char(%) to %25. It is mismatched the specs.
How to reproduce
<?php

require_once './vendor/autoload.php';

use GuzzleHttp\UriTemplate\UriTemplate;
echo UriTemplate::expand('merchant-service/images/{+slot}', ['slot' => 'AIO%2FFR']);
// result: merchant-service/images/AIO%252FFR
// Actually, there was required the url like this: `merchant-service/images/AIO%2FFR`

Possible Solution

Additional context

Thanks for the report.

Related: uri-templates/uritemplate-test#41.

Copy that. I've also strange that the RFC6570 wasn't any samples about double pct-encode.
It sugguest that this library should be followed the RFC3986 Implementations must not
percent-encode or decode the same string more than once. If upgrading with this suggestion, it may works well with Guzzle\Psr7\Uri::filterPath (https://github.com/guzzle/psr7/blob/2.5/src/Uri.php#L693-L697)

If you have any time to prepare a PR, or half of a PR, that would be much appreciated. I am spread thin these days, lol.


Concerning possible matching design flaw when losing events

The matching queue is configured with the setting clean_start: true. I assume this is because when initializing matching we load all wait orders and try to match them, and we do not have a straightforward way to know if a submit event in the queue corresponds to an already-loaded order or not, which might trigger processing an order twice.
Consider the following case:

Market maker publishes an order A, Peatio answers 201
matching crashes, starts restarting
Market maker cancels order A, Peatio answers 201
matching finishes restarting, purging its queue, deleting all cancel events
Market maker assumes it has no active orders

This is not a design flaw.
The market maker should listen for websocket events and then cancel the order from its memory.
When exchange replies 201 for orders api it means instruction received not executed.

This is not a design flaw.
The market maker should listen for websocket events and then cancel the order from its memory.
When exchange replies 201 for orders api it means instruction received not executed.

I understand that you may do a workaround by listening to the websocket, but note that the cancellation event has been lost and thus the order status will not be updated to cancel. You can only know about this situation and how to create a hacky workaround by understanding the underlying exchange implementation.
Second consideration, what exchange (or just any popular service in general) in the world asks you to implement a client for a RESTful API along with a websocket client to check if your request has actually been processed successfully?

I understand what you mean but don't expect any changes.
You should implement your own matching engine and use 2.6.
Crypto.com is the exchange that does this or at least it used to do this.
To cancel the order immediately you have to be using in memory trading engine to be effective.
We have developed our own implementation of this if you are interested.
Note: I'm not related to openware.


Kuma Adapter URL missing

Description
Adapter URL with port 10007 that is the URL for Kuma adapter is missing.
Expected Behavior

Screenshots/Logs

Environment:

Meshery Version: Latest

To Reproduce
Steps to reproduce the behavior:

Go to Makefile
See error on the top

I would like to work on this issue, could you please guide me through it?

Hey, @Ayush-Khandelwal-007, I just need to add mesherylocal.layer5.io:10007 to the Makefile right??

@debjani1413  Here the constant contains all the URLs that are passed on when the server starts so these ports are listened for the Adapters when the sever is up. So you just need to add one more URL that have same base URL but the missing port, i.e., the port for Kuma adapter, further which is set default to 10007 in the adapter.

Okay great, will do that right away!


Gate.io integration

Add support for Gate.io cryptocurrency exchange:

spot trades channel
https://www.gate.io/docs/developers/apiv4/ws/en/#public-trades-channel

spot orderbook channel
https://www.gate.io/docs/developers/apiv4/ws/en/#order-book-channel

perpetual futures trades channel
https://www.gate.io/docs/developers/futures/ws/en/#trades-api

perpetual futures orderbook channel
https://www.gate.io/docs/developers/futures/ws/en/#order-book-api

completed spot trades + quotes, parking perps for later


Fix typo

@mrinaldi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks @mrinaldi.


Incorrect use of for  for checkbox

Hi, here is the issue description:
Chrome is reporting an error regarding the incorrect use of the  syntax.
The issue occurs when using the following HTML structure for the checkbox :

  <input type="checkbox" class="noneSelected">

Error message: "Incorrect use of . The for attribute must be associated with a valid form element ID."
The current implementation of the label element is not properly associated with a form element ID. This can lead to accessibility issues and potential inconsistencies in form behavior.
To resolve this issue, the label element should be associated with a valid form element ID using the for attribute (the input tag).
Thank you for your attention to this matter.

hello, just write the code below :


fix scenario stream51 docs

https://continuum.readthedocs.io/en/latest/_tutorials/scenarios_suites/Stream51.html

Should be fixed in 49850ce..b50228e


onPremise requirements

With onPremise deployments like Baremetal, oVirt, VMware, HyperV we also need to support existing infrastructure components like AD/LDAP/PROXY/DNS/NTP...., right?

I'd go with the most common scenario; assume there is DHCP/DNS, use AD/LDAP with optional selection (deploy your own or provide the server and DNs) and use public NTP (assuming internet access possible).

Making everything as option/selection will make the scripts complicated, instead I'd try to keep these as variables so making them options becomes easier later.

I understand that we want to make it as simple as possible, on the other hand we also need a way to customize the different environments and parameters.
At the moment I have no idea how to implement this easily, ex. I found some hardcoded information like LDAP in Ansible!
I would recommend that we outsource these things in a separate config folder/config file and make it configurable for the deployment if required.

I totally agree to make these parameterised. Let me know what is the best way and I can work on that. Or if you already had these separated, we can replace them in place.

I am testing a way to provide additional parameters directly into the ansible inventory file, and it works for VMWare deployment now. We can expand this to all targets.
So the playbooks can check if a variable exist (such as http_proxy) and then run the necessary tasks.


5.x.x: Update validate-json to use spl_autoload_register

Fixes #574

spl_autoload_register exists since PHP 5.1, so this shouldn't be a problem backward-compatibility wise.
There's was a more drastic change (#401 & 9fe7822) in the master to fix the same root issue, but it wasn't backported to 5.x. Hence the need for this fix.

Thank you @sanmai :-).

Guys, could you please tag a new release with this fix?

@maks-rafalko Yes. I want to roll a few other backported fixes in too.

A release with just this fix will be very appreciated because it is a major deprecation since PHP 7.2. Almost everyone these days is getting PHP 7.3 from the start, e.g. because Debian stable includes one. Thank you very much for considering this request.

@sanmai Are you requesting a release ASAP, or are you specifically wanting a release with that fix only in it? Because I'm doing the backports now, and should be tagging stuff in a few minutes.

@sanmai I've just tagged v5.2.9 with all current backports merged in.
Please let me know if you need an additional release that contains only the autoload fix - that seems like a rather strange thing to ask for, so I'd prefer not to do it without a good reason.

Thank you!

Please let me know if you need an additional release that contains only the autoload fix

This wasn't necessary absolutely. I meant that if you're busy with other things tagging a release with just this fix would be a big help. But else any release works. Thank you again.


Do we actually want to support parsing 32-bit ELFs on 64-bit machines?

If we didn't support this, it would make the ELF parser implementation SIGNIFICANTLY easier, since the word width could be defined at compile time.
Or alternatively, if we didn't support ELFs with mixed 64- and 32-bit sections (which I am not sure if we do anyway). Hmm.
Can a 64-bit machine actually run a 32-bit ELF without Some Kind of Magic, anyway? That might influence design direction here...

Okay, never mind, it looks like all sections in a file have to have the same word size (as I kind of suspected). Never mind.


Change the name of go package to pipecd

What this PR does / why we need it:
Which issue(s) this PR fixes:
A part of #3024
Does this PR introduce a user-facing change?:

NONE

/trigger test

/golinter fmt

Go bold 👍
/lgtm

/approve


Yarn version

Carbon uses yarn version 1.22.19
Yarn version 1.x.x is in maintenance mode since January 2020.
I think we could migrate to version 3.x.x (Documentation)

how about we switch to pnpm? What are your thoughts on that?

I'll evaluate the 3 options :

<EMAIL_ADDRESS>pnpm
bun package manager

@zavelevsky how would you like to proceed with this? should we allocate time for such tech enhancement?


nixos/users: Allow mutable shells for declarative users

Motivation for this change
I want to manage users centrally via declarativeUsers,
but allow users to change their shell as they please,
similar to how they can change passwords at will
if none of the password-related NixOS settings are set for their user.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This only works together with #51270 ?
I assume, I can get both behaviours? Declarative users, who can't change their login shell and declarative users, who can change their login shell? How to select between those behaviours (if both are present.)

@typetetris https://github.com/NixOS/nixpkgs/pull/51270 was mainly for non-declarative users. You can get both behaviors:

if you set the shell for a user in the NixOS config to some actual shell, that shell should be applied on every nixos-rebuild
if you set a null shell for a user in the NixOS config, NixOS won't enforce any given shell for them and they can change it as they wish

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/313

Merging based on multiple reviews.


Replacing FloatingActionButton with Action Button

Hello again,
I would like to replace the FloatingActionButton in your example by this component
So in your example's code, in the GoogleMapsView.js file,  basically this:
  renderFloatingActionButton = () => {
    const { bottomSheetColor } = this.state
    const isExpanded = bottomSheetColor === 1
    return (
      <FloatingActionButton
        ref={(floating) => { this.floating = floating }}
        elevation={18}
        rippleEffect={true}
        icon={'directions'}
        iconProvider={IconMDI}
        iconColor={!isExpanded ? WHITE : PRIMARY_COLOR}
        onPress={this.handleFabPress}
        backgroundColor={isExpanded ? WHITE : PRIMARY_COLOR}
      />
    )
  }

turned into this:
  renderFloatingActionButton = () => {
    return (
      <ActionButton ref={(floating) => { this.floating = floating }} buttonColor="rgba(231,76,60,1)">
        <ActionButton.Item buttonColor='#9b59b6' title="New Task" onPress={() => console.log("notes tapped!")}>
          <Icon name="md-create" style={styles.actionButtonIcon} />
        </ActionButton.Item>
        <ActionButton.Item buttonColor='#3498db' title="Notifications" onPress={() => {}}>
          <Icon name="md-notifications-off" style={styles.actionButtonIcon} />
        </ActionButton.Item>
        <ActionButton.Item buttonColor='#1abc9c' title="All Tasks" onPress={() => {}}>
          <Icon name="md-done-all" style={styles.actionButtonIcon} />
        </ActionButton.Item>
      </ActionButton>
    )
  }

However, I get the following error:
undefined is not a function (evaluating this.floating.setAnchorId(this.bottomSheet))
Is it at all possible to use this component as I intend, or is it meant only to be used with the FloatingActionButton component?
Thank you.

No, you can't, FloatingActionButton is a completely native component, and react-native-action-button doesn't, they don't work together, and the setAnchorId is a internal function from FloatingActionButton, not react-native-action-button or something from react-native.
react-native-action-button intent to work as absolute position, and doesn't support anything further than that, such as relative parents.


remove whitespace from data URIs

closes #1540
Replaces all spaces with + symbol's (#1527), then removes all remaining whitespace (newlines, tabs etc)

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @RedSparr0w!

  Generated by :no_entry_sign: dangerJS


chore(main): release 1.0.2

:robot: I have created a release beep boop
1.0.2 (2024-01-10)
Bug Fixes

add node (#7) (3f80ca2)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/achieveagility/nx-publish/releases/tag/v1.0.2 :sunflower:


Starting to type action name fails due to missing quotes

So uh...

Not sure how this should be fixed. One idea would be automatically insert the quotation mark on auto-complete, since you more often need it than not. I know I could just start writing with ", but since the actions appear, I wouldn't expect them to disappear.
(similar thing I think happened with load)

It does. You can select something with arrows and press Enter, but if you want to autocomplete some action, you need to start with ", otherwise the list disappears.

This is partially fixed with #29626 and #31450, but still applies to Input actions and probably some more stuff that doesn't use the new completion.


bugfix:initialized id,may cause the transaction to fail

Ⅰ. Describe what this PR did
initialized id，may cause the transaction to fail
Ⅱ. Does this pull request fix one issue?
fix #1046
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1047 into develop will increase coverage by 0.04%.
The diff coverage is 65%.

@@              Coverage Diff              @@
##             develop    #1047      +/-   ##
=============================================
+ Coverage      38.51%   38.56%   +0.04%
- Complexity      1067     1072       +5
=============================================
  Files            218      218
  Lines           8722     8737      +15
  Branches        1088     1093       +5
=============================================
+ Hits            3359     3369      +10
- Misses          4941     4944       +3
- Partials         422      424       +2

Impacted Files
Coverage Δ
Complexity Δ

server/src/main/java/io/seata/server/Server.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...r/src/main/java/io/seata/server/UUIDGenerator.java
61.53% <50%> (-0.97%)
4 <1> (+1)

.../seata/server/session/FileBasedSessionManager.java
55.67% <70.58%> (+2.09%)
19 <10> (+4)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df41c30...2945e3c. Read the comment docs.


[Feature] Timeline support node layout mode

What problem does this feature solve?
https://github.com/ant-design/ant-design/pull/11490
What does the proposed API look like?
<nz-timeline
+  nzMode="alternate">
   ...
</nz-timeline>

API

Property
Description
Type
Default

[nzMode]
By sending alternate the timeline will distribute the nodes to the left and right.
left | alternate | right
left

Implemented in #2515.


Is it possible to specify files to ignore?

Describe the bug
I don't want react-native-rename to touch my package.json file
To Reproduce
Just run npx react-native-rename newName
Expected behavior
Add flag -i or -ignoreFile package.json
Don't change specified file

+1. I also want to know if there is anything similar. I want to ignore some files from being replaced, like strings.xml, since I am taking the values from the ENV.


Temporarily disable bpf clock probe

When enabling the bpf clock probe, the garbage collector is sometimes removing valid conntrack entries, likely due to some error in the jiffies calculation.
Until we figure out a permanent solution, let's disable the the bpf-clock-probe by default.
Fixes: #26955
Temporarily disable bpf-clock-probe to avoid causing interruptions for long-lived connections during upgrades

/test

/test

/test

/test

I agree that we should add some docs to describe this behaviour to users, but that can be submitted separately.


ACS AEM Commons /apps/cq/core/content package may cause node-constraint conflicts

Removing menu items from the nav using an overlay in another package results in the following errors when installing packages.
Error: org.apache.jackrabbit.vault.packaging.PackageException: javax.jcr.nodetype.ConstraintViolationException: OakConstraint0001: /apps/cq/core/content[[nt:folder]]: No matching definition found for child node nav with effective type [nt:unstructured]
Resolve by updating ACS AEM Commons overlay to mimic the OOTB node type structure

I am very new to CRXDE and believe I need to do the above but have no idea how to actually do it.  Do I create the folder structure /apps/cq/core/content/nav/tools and I am uncertain how to create a node?  I have installed CQ v6.2 and the hotfix 12785.  I am getting node constraint conflicts when doing so.  Can someone point me in the right direction?  I am trying to do the CQ install on localhost and can't even get it working to learn it better.

Here's my actual error:  Could not Install Package
"org.apache.jackrabbit.vault.packaging.PackageException: javax.jcr.nodetype.ConstraintViolationException: OakConstraint0021: /apps/nscorp/install/nscorp-bundle-1.6.10.jar/jcr:content[[nt:resource, cq:ReplicationStatus]]: Mandatory property jcr:data not found in a new node"

@charlie2869 that error doesn't look related to this issue (which was resolved almost 2 years ago). The particular error you have posted seems to be a problem in the package. I'd suggest working with support to troubleshoot.


Loading ExampleApp.html generates no application set message

Loading the exampleApp.html file generates an osx dialog error message "There is no application set to open the URL wvjbscheme://BRIDGE_LOADED.  Is there a way to suppress the dialog while allowing the HTML content to load?   As of now,  canceling or ignoring the about:blank url does not load the html but gets rid of the dialog. I am doing this with the below to ignore about:blank but this is no good, in that i dont get the subsequent wvjbscheme:// url request for proper setup and use of the api.  Any ideas why?
if ([url.scheme isEqualToString:@"about"]) {
[listener ignore];
}

If you check out a clean copy of WVJB and open the example project file, does that work?

Running a clean copy of the example WVJB project works without issue.  The issue arises when I attempt to manually include the unchanged  example code into my existing project.
Additionally when I debug the example project, I can see the JS processing of the about:blank and wvjbscheme url requests, but in my project, I only see the about:blank request followed by the unintended dialog prompt.

I recommend eliminating the differences between the two projects until the
behavior disappears. If I want able to deduce what was causing it, that's
how I'd proceed.
Cheers!
On Fri, Sep 9, 2016 at 12:03 AM Patrick Spears<EMAIL_ADDRESS>wrote:

Running a clean copy of the example WVJB project works without issue. The
issue arises when I attempt to manually include the unchanged example code
into my existing project.
Additionally when I debug the example project, I can see the JS processing
of the about:blank and wvjbscheme url requests, but in my project, I only
see the about:blank request followed by the unintended dialog prompt.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/marcuswestin/WebViewJavascriptBridge/issues/229#issuecomment-245813614,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIDfzr0GAMSaRE7yojx82bk_xBHw7dNks5qoNp7gaJpZM4J2PWt
.

--
-- while mobile

Feel free to reopen with more info.


coverlet.msbuild is not accurate for .Net 5.0

It seems like coverlet.msbuild does not give correct Code Coverage results for .Net 5.0.
Please add that as a note after instructing the reader to reference coverlet.msbuild. It does work with coverlet.collector, but I haven't been able to get it to integrate smoothly with the dev-op pipeline.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec716c61-248c-75c9-2bc7-262749cc7421
Version Independent ID: 45f47edc-e800-2c42-416a-92cd93c9e892
Content: Build, test, and deploy .NET Core apps - Azure Pipelines
Content Source: docs/pipelines/ecosystems/dotnet-core.md
Product: devops
Technology: devops-cicd-ecosystems
GitHub Login: @juliakm
Microsoft Alias: jukullam

@dpomBF I'll update the docs. For reference, this pipeline yaml worked for me. I had to use the UseDotNet@2 and DotNetCoreCLI@2 tasks.
trigger:
- main

pool:
  vmImage: 'ubuntu-latest'

variables:
  buildConfiguration: 'Release'

steps:
- task: UseDotNet@2
  inputs:
    version: '5.0.x'
    includePreviewVersions: true # Required for preview versions

- task: DotNetCoreCLI@2
  displayName: 'dotnet build'
  inputs:
    command: 'build'
    configuration: $(buildConfiguration)

- task: DotNetCoreCLI@2
  displayName: 'dotnet test'
  inputs:
    command: 'test'
    arguments: '--configuration $(buildConfiguration) /p:CollectCoverage=true /p:CoverletOutputFormat=cobertura /p:CoverletOutput=$(Build.SourcesDirectory)/TestResults/Coverage/'
    publishTestResults: true
    projects: 'MyTestLibrary' # update with your test project directory

- task: PublishCodeCoverageResults@1
  displayName: 'Publish code coverage report'
  inputs:
    codeCoverageTool: 'Cobertura'
    summaryFileLocation: '$(Build.SourcesDirectory)/**/coverage.cobertura.xml'

@dpomBF I'll update the docs. For reference, this pipeline yaml worked for me. I had to use the UseDotNet@2 and DotNetCoreCLI@2 tasks.
trigger:
- main

pool:
  vmImage: 'ubuntu-latest'

variables:
  buildConfiguration: 'Release'

steps:
- task: UseDotNet@2
  inputs:
    version: '5.0.x'
    includePreviewVersions: true # Required for preview versions

- task: DotNetCoreCLI@2
  displayName: 'dotnet build'
  inputs:
    command: 'build'
    configuration: $(buildConfiguration)

- task: DotNetCoreCLI@2
  displayName: 'dotnet test'
  inputs:
    command: 'test'
    arguments: '--configuration $(buildConfiguration) /p:CollectCoverage=true /p:CoverletOutputFormat=cobertura /p:CoverletOutput=$(Build.SourcesDirectory)/TestResults/Coverage/'
    publishTestResults: true
    projects: 'MyTestLibrary' # update with your test project directory

- task: PublishCodeCoverageResults@1
  displayName: 'Publish code coverage report'
  inputs:
    codeCoverageTool: 'Cobertura'
    summaryFileLocation: '$(Build.SourcesDirectory)/**/coverage.cobertura.xml'

Thank you @juliakm that did work and now shows the coverage amount.

However, I have one more question, do you know how I can have the pipeline break if the coverage is under the threshold? With coverlet.msbuild, I used /p:Threshold=27.

Thank you @juliakm that did work and now shows the coverage amount.

However, I have one more question, do you know how I can have the pipeline break if the coverage is under the threshold? With coverlet.msbuild, I used /p:Threshold=27.


Example on Smart Shopping ads issue

I am having a problem with the example shown in the smart shopping ads. In the doc it says that "Bidding Strategy must be set directly on the campaign" , but it is not set there.
When I try to run this example I am having this errors:
Request ID tAGY_PKNVPO_HqD2q2ZOgg failed due to GoogleAdsException. Underlying errors:
  Error 0: error_code {
  field_error: REQUIRED
}
message: "The required field was not present in the resource."
trigger {
  string_value: ""
}
location {
  field_path_elements {
    field_name: "operations"
    index {
    }
  }
  field_path_elements {
    field_name: "create"
  }
  field_path_elements {
    field_name: "campaign_bidding_strategy"
  }
}

  Error 1: error_code {
  mutate_error: RESOURCE_NOT_FOUND
}
message: "Resource was not found."
trigger {
  string_value: "131646244"
}
location {
  field_path_elements {
    field_name: "operations"
    index {
    }
  }
  field_path_elements {
    field_name: "create"
  }
  field_path_elements {
    field_name: "shopping_setting"
  }
  field_path_elements {
    field_name: "merchant_id"
  }
}

I tried setting the biddingStrategyType, but it did not work and looking in the source code, it seems to be something different than biddingStrategy.
I am not sure what the other error is btw.
Thanks for the help!

The error message shows you have two errors.
The first is that a bidding strategy must be set on the campaign. The bidding_strategy_type field is read-only (docs). To set campaign_bidding_strategy refer to the (docs, same link as above, scroll down to campaign_bidding_strategy) which shows that campaign_bidding_strategy is a union field, and one of the the available options should be set. The example uses maximise conversion value.
Additionally, the merchant center ID you have specified is not found. Please link the merchant center account to Google Ads and try again. You can view the linked account IDs in the Google Ads UI under tools -> linked accounts.


Create LICENSE

The other getlantern projects have an Apache-2.0 license. I presume that this one is also to be licensed under the same as the others. This commit adds the LICENSE file, addressing #1

This pull-req can be closed, there is now a license in the repo:
https://github.com/getlantern/hidden/blob/master/LICENSE


feat: add cdn type to edge_applications

WHAT

Add cdn type to edge_application web application types. This is a very simple type with only an edge application and domain.
Update init, build and publish commands to verify if type is cdn before anything else, as the whole process is different.

LGTM


Epic_1: Ontology Registration (Austac Perspective)

Standards for Digital Twins are key to the success of autonomous driving. However, almost every physical asset can have a Digital Twin. This makes it hard to establish a standard.

Addressing this problem, the Automotive Standardization Consortium (Austac) defines standardized ontologies ( data models) for Digital Twins in the context of autonomous driving. The standards are used by car manufacturers, suppliers, and others as foundation for creating and operating with Digital Twins.

Ontologies can describe different car types, e.g., passenger cars, vans , or trucks, and for different driving scenarios, e.g., motorway exit road, lane switching in urban traffic, keeping lanes in roundabouts. They determine the data structure and sensor types to be used to generate the data. To describe ontologies, the Digital Twins Definition Language (DTDL) can be used.

To establish Digital Twin ontology standards, Austac anchors them as the required data sharing format in a public data marketplace, called TAIA-X: for a dataset to be offered on the marketplace it must comply with one of the registered ontology standards.

To register its ontology standards on TAIA-X, Austac first needs to create a user account on the marketplace. Therefore, it uses the web-based interface. Once created, Austac can upload ontologies. (…)

Closed because epic is split into smaller user stories in #55 #56 #57 .


Equality and hashcodes on collections

Most immutable classes uses EquatableMixin from equatable package that helps to implement equality without needing to explicitly override == and hashCode.
For this library these questions apply at least for

DataObject and DataObjectView
DataArray and DataArrayView

Analyze how Equatable library works on collections.
See also built_collection for reference about deep comparisions on hash and equals.

Similar open issues on geocore too:
https://github.com/navibyte/geospatial/issues/12

DataObjectView and DataArrayView are defined with EquatableMixin
It has deep hash and deep equality.
However calculated hash value is not cached.
DataObjectView and DataArrayView is some case may contain mutable data maps or data lists. So can't cache hash value.
Let's keep implementation as it's now with trusting hashCode and equality checks implemented by EquableMixin.


Label line spacing can become "corrupted"

Godot version
4.0.3
System information
Windows 10, Forward+, Nvidia GTX1060
Issue description
Label line spacing can become "corrupted". In our project, everything seemed OK running from the editor but in the release build multi-line text had a big line spacing and even setting explicit line spacing to 0 didn't help.
When I created the test project everything worked correctly and then I tried a saved scene from our project, that label didn't work correctly in the release build.
I created a reproduction project with a fresh Label and matched configuration and text. In the main.tscn scene file text, there is no difference, yet the corrupted one break in the release build.
Maybe related to #74351
PS. Converting "Corrupted" Label into RichTextLabel keeps the corrupted state.
Steps to reproduce
In the reproduction project saved corrupted_label_scene.tscn that contains the label.
Copy that label into a new scene.
Build a release and the label line spacing is not working correctly.
Minimal reproduction project
Label Release Line Spacing.zip

Duplicate of https://github.com/godotengine/godot/issues/74351 (same cause).


Can't define an entity field as having 'any' type.

I wish to define a field of one of my responses as having 'any' type. It's an 'extra' field
in errors that has some extra structured information that depends on the error.
I believe the way to do this in JSON schema is to omit the 'type' declaration for that
field, but I don't believe that is possible with grape-swagger.
Specifically
class SomeEntity < Grape::Entity
   expose :extra,
                documentation: {
                  type: <ANY>
                }
end

I'm not sure what the best way to declare this would be.
(I filed this here as despite me using grape-entity, I believe it is this project that generates the swagger for this, rather than grape-swagger-entity)
Thanks,
James

@james-w … please refer to the OAPI spec, there a type of any isn't foreseen.
OAPI/swagger is based on JSON spec, but differs in some points
think on, you have an API, where some elements of the response have no/any datatype,
and now a consumer of your API (maybe it is written in C), how should the consumer be handle the response? By given a type of any the consumer has to implement additional logic to find out what for type it is.
But to achieve a similar behaviour, I would be suggesting to set the type to string.

Hi, I hadn't notice that the Swagger spec restricted the types in that manner.
I see there is some discussion in the swagger bugtracker about changing this a bit.
I have some disagreement with their rationale for this, but it is what it is.
Thanks for your time.
James

feel free to be a part of the discussion and introduce results here 😉


Existing types in schema.sql are preventing new migrations to be generated

I am using:
atlas version
atlas version v0.9.2-3f62ed7-canary
https://github.com/ariga/atlas/releases/latest

I am seeing an issue where when I create a new migration (adding some new tables), the generation script always complains about a type I added a in a previous migration.
Command I am runnning:
atlas migrate diff $(MIGRATION_NAME) --dir "file://configs/pgdb/migrations" --to "file://configs/pgdb/schema.sql" --dev-url "docker://postgres?search_path=public"

Output:
Error: sql/migrate: read migration directory state: sql/migrate: execute: executing statement "CREATE TYPE \"mode\" AS ENUM ('some-val-1', 'some-val-2');" from version "20230302203552": pq: type "mode" already exists
make: *** [gen-migrate] Error 1

Thanks in advance for the help!

@a8m I know you worked on this issue - https://github.com/ariga/atlas/issues/1503
I wondered if these 2 things were related.
I wanted to make sure that the version that I am using includes your first for 1503 or if we need a new fix here.
Thanks

Thanks for reporting this, @oneill-c. I was able to reproduce this. I'll investigate and update this issue.

Hey! I just tested it on the example based on #1503, and it works for me (ignore the comment above, I used an old version):
➜  pgtest git:(master) cat schema.sql
CREATE TYPE entity_type AS ENUM ('business', 'individual');
CREATE TYPE entity_relationship AS ENUM ('direct', 'indirect');
CREATE TYPE mode_anything AS ENUM ('live', 'sandbox');

CREATE TABLE IF NOT EXISTS table_1 (
  "id" varchar PRIMARY KEY,
  "entity_type" entity_type NOT NULL,
  "entity_relationship" entity_relationship NOT NULL,
  "mode_anything" mode_anything NOT NULL
);

CREATE TABLE IF NOT EXISTS table_2 (
  "id" varchar PRIMARY KEY,
  "mode_anything" mode_anything NOT NULL
);

➜  pgtest git:(master) atlas migrate diff initial \
--to file://schema.sql \
--dev-url "docker://postgres/15/test?search_path=public"

➜  pgtest git:(master) cat migrations/20230309202841_initial.sql
-- Create enum type "entity_type"
CREATE TYPE "entity_type" AS ENUM ('business', 'individual');
-- Create enum type "entity_relationship"
CREATE TYPE "entity_relationship" AS ENUM ('direct', 'indirect');
-- Create enum type "mode_anything"
CREATE TYPE "mode_anything" AS ENUM ('live', 'sandbox');
-- Create "table_1" table
CREATE TABLE "table_1" ("id" character varying NOT NULL, "entity_type" "entity_type" NOT NULL, "entity_relationship" "entity_relationship" NOT NULL, "mode_anything" "mode_anything" NOT NULL, PRIMARY KEY ("id"));
-- Create "table_2" table
CREATE TABLE "table_2" ("id" character varying NOT NULL, "mode_anything" "mode_anything" NOT NULL, PRIMARY KEY ("id"));

➜  pgtest git:(master) echo 'CREATE TABLE "table_3" ("id" character varying NOT NULL, PRIMARY KEY ("id"));' >> schema.sql

➜  pgtest git:(master) atlas migrate diff second \
--to file://schema.sql \
--dev-url "docker://postgres/15/test?search_path=public"

➜  pgtest git:(master) cat migrations/20230309203044_second.sql
-- Create "table_3" table
CREATE TABLE "table_3" ("id" character varying NOT NULL, PRIMARY KEY ("id"));

Any chance you provide an example that reproduces this issue? Thanks

@a8m Ok, just first of, given the version that I put in the description, should I have your fix for #1503?
atlas version
atlas version v0.9.2-3f62ed7-canary
https://github.com/ariga/atlas/releases/latest

EXAMPLE

I have already applied a migration that included

CREATE TYPE mode AS ENUM('some-val-1', 'some-val-2');

Note: At this point the migrations are completely up-to-date at this point.

Then, I add a new table to the schema.sql

CREATE TABLE IF NOT EXISTS
    some_table (
        "id" varchar PRIMARY KEY,
        "some-id" varchar UNIQUE NOT NULL
);

Then when I run

atlas migrate diff $(MIGRATION_NAME) --dir "file://configs/pgdb/migrations" --to "file://configs/pgdb/schema.sql" --dev-url "docker://postgres?search_path=public"

I get this error

Error: sql/migrate: read migration directory state: sql/migrate: execute: executing statement "CREATE TYPE \"mode\" AS ENUM ('some-val-1', 'some-val-2');" from version "20230302203552": pq: type "mode" already exists
make: *** [gen-migrate] Error 1

I used the latest canary build: atlas version v0.9.2-f1b6be5-canary. You can update your version using the following command:
curl -sSf https://atlasgo.sh | sh

I have the same issue when using schema apply. If I the enum is already exists, an error is occurred:
pq: type "field_type" already exists

@oxilor, what version do you use? Use the following command:
docker run --rm arigaio/atlas version

In any case, I'll release a new version now.

atlas version v0.9.2-f1b6be5-canary
https://github.com/ariga/atlas/releases/latest

I'm looking forward to the update. Thank you!

@oxilor, this is the latest canary build. Do you have any example that reproduces this bug?

Thanks, @oxilor. I will give it a look.
You can use the docker driver for now, in case you are blocked on this. e.g.,
--dev-url "docker://postgres/15/test?search_path=public"

@a8m
When I update to the latest canary I now a slightly different error.
Install latest canary:
curl -sSf https://atlasgo.sh | sh
Install 'atlas-darwin-amd64-latest' to '/usr/local/bin/atlas'? [y/N] y
Downloading https://release.ariga.io/atlas/atlas-darwin-amd64-latest
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 69.7M  100 69.7M    0     0  2600k      0  0:00:27  0:00:27 --:--:-- 3242k
Password:
atlas version v0.9.2-f1b6be5-canary
https://github.com/ariga/atlas/releases/latest
Installation successful!

Error:
make gen-migrate MIGRATION_NAME=new-migration
atlas migrate diff new-migration \
      --dir "file://configs/pgdb/migrations" \
      --to "file://configs/pgdb/schema.sql" \
      --dev-url "docker://postgres?search_path=public"
Error: replacing or reordering enum ("mode") value is not supported: ["some-val-1", "some-val-2"] != ["some-val-2", "some-val-1"]
make: *** [gen-migrate] Error 1

If I flip the values I can successfully generate a new migration but this doesn't seem like a viable fix to me.

Thanks for reporting this, @oneill-c. Atlas does not support reordering enums at this stage because there's no easy way to implement this:

Existing values cannot be removed from an enum type, nor can the sort ordering of such values be changed, short of dropping and re-creating the enum type.

You can read more about it here: https://www.postgresql.org/docs/current/datatype-enum.html#id-<IP_ADDRESS>.8

@a8m To be clear, reordering is not my use case and I have no idea why it it erroring in this way. The only thing I would like to do is my original use case of adding new migrations without previously added types complaining.

Is there any chance that the enum defined in the schema is different from the one defined in the migrations directory?
Also, can you please provide a small example that reproduces this? A schema + migrations directory. Thanks 🙏🏻

@a8m The enum is defined the same in schema.sql and the migrations directory.
Example
schema.sql
-- ONLY DDL definitions (CREATE, ALTER, DROP) into this file. For DML definitions (insert, update), seeds definitions, you must create a manual migrations with Atlas, see README
--ENUMS
CREATE TYPE mode AS ENUM('some-val-1', 'some-val-2');

--TABLES
CREATE TABLE
    table_1(
        "id" varchar PRIMARY KEY,
        "name" varchar NOT NULL,
        "created_at" timestamp NOT NULL,
        "updated_at" timestamp NOT NULL,
        "disabled" boolean NOT NULL DEFAULT false);

CREATE TABLE
    table_2 (
        "id" varchar PRIMARY KEY,
        "name" varchar NOT NULL,
        "created_at" timestamp NOT NULL,
        "updated_at" timestamp NOT NULL,
);

CREATE TABLE
    table_3 (
      "id" varchar PRIMARY KEY,
      "mode" mode NOT NULL DEFAULT  'some-val-1',
      "created_at" timestamp NOT NULL,
      "updated_at" timestamp NOT NULL,
);

CREATE TABLE
    table_4 (
        "id" varchar PRIMARY KEY,
        "mode" mode NOT NULL DEFAULT 'some-val-1',
        "created_at" timestamp NOT NULL,
        "updated_at" timestamp NOT NULL,
);

// This table is what I want to generate a new migration for
CREATE TABLE
    table_5 (
        "id" varchar PRIMARY KEY,
        "some-id" varchar UNIQUE NOT NULL
);

Migration 1 -<PHONE_NUMBER>1719_init_schema.sql
-- create "table_1" table
CREATE TABLE "public"."table_1" ("id" character varying NOT NULL, "name" character varying NOT NULL, "created_at" timestamp NOT NULL, "updated_at" timestamp NOT NULL, PRIMARY KEY ("id"));
-- create "table_2" table
CREATE TABLE "public"."table_2" ("id" character varying NOT NULL, "name" character varying NOT NULL, "created_at" timestamp NOT NULL, "updated_at" timestamp NOT NULL, PRIMARY KEY ("id"));

Migration 2 -<PHONE_NUMBER>1756_seed_data.sql
-- table_1
INSERT INTO table_1
(id, name, created_at, updated_at)
values
    ('uuid'-1, 'some-name-1', now(), now());

-- table_2

INSERT INTO table_2
(id, name, created_at, updated_at)
values
    ('uuid-2', 'some-name-2', now(), now()),
    ('uuid-3', 'some-name-3', now(), now()),
    ('uuid-4', 'some-name-4', now(), now());

Migration 3 -<PHONE_NUMBER>3552_create_table_3_and_table_4_and_types.sql
-- create enum type "mode"
CREATE TYPE "mode" AS ENUM ('some-val-1', 'some-val-2');
-- create "table_3" table
CREATE TABLE "table_3" ("id" character varying NOT NULL, "mode" "mode" NOT NULL DEFAULT 'some-val-1', "created_at" timestamp NOT NULL, "updated_at" timestamp NOT NULL, PRIMARY KEY ("id"));
CREATE TABLE "table_4" ("id" character varying NOT NULL, "mode" "mode" NOT NULL DEFAULT 'some-val-1', "created_at" timestamp NOT NULL, "updated_at" timestamp NOT NULL, PRIMARY KEY ("id"));

Then when I try to generate a migration for table_5, it fails how I described above.

Hey! This example has a few problems. Maybe this is the cause of the issue, because once I fixed them, I was able to generate this diff.
schema.sql:
CREATE TABLE
    table_2 (
        "id" varchar PRIMARY KEY,
        "name" varchar NOT NULL,
-       "created_at" timestamp NOT NULL,
+       "updated_at" timestamp NOT NULL
);

CREATE TABLE
    table_3 (
      "id" varchar PRIMARY KEY,
      "mode" mode NOT NULL DEFAULT  'some-val-1',
      "created_at" timestamp NOT NULL,
-     "updated_at" timestamp NOT NULL,
+     "updated_at" timestamp NOT NULL
);

CREATE TABLE
    table_4 (
        "id" varchar PRIMARY KEY,
        "mode" mode NOT NULL DEFAULT 'some-val-1',
        "created_at" timestamp NOT NULL,
-       "updated_at" timestamp NOT NULL,
+       "updated_at" timestamp NOT NULL
);

20230223221756_seed_data.sql:
INSERT INTO table_1
(id, name, created_at, updated_at)
values
-    ('uuid'-1, 'some-name-1', now(), now());
+    ('uuid-1', 'some-name-1', now(), now());

What is the command you use for generating this diff? Because if it's related to https://github.com/ariga/atlas/issues/1523#issuecomment-1463812315, try to use the docker driver for the --dev-url:
--dev-url "docker://postgres/15/test?search_path=public"

@a8m Hey, thanks for testing this.
All of the things you pointed out were typos on my end as I removed some sensitive data from my example in order to post it here. They do not exist when I actually run this example.
So, you generated each of the diffs separately? That is the key here since the type gets created in one migration then it breaks in the next one saying that it already exists.
Yes, I am using the docker driver
--dev-url "docker://postgres/15/test?search_path=public"

Did you better understand or manage to work around these erros?
I have a simple schema with create type, and getting same exceptions when attempting to run atlas migrate diff (for ex)

Hey @pedroteixeira 👋
Thanks for reporting this. What version do you use?


Inconsistency in Message (and Struct) Codec Registration Name

Mostly in the bonds module, which uses for example cosmos-sdk/MsgBuy rather than bonds/MsgBuy when registering the MsgBuy concrete with Amino.

Closed by #109


Fix Paycheck Calculator from Components

Created calc that works, however after moving them to components it broke. So I need to fix

Resolution to this issue was to rewrite the code with better understanding.


Enable JIRA actions

This reverts commit e9bd4d9d968cbb9085d4236a8e2847a7645b3230.

Codecov Report

Merging #101 into dev will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             dev     #101      +/-   ##
=========================================
+ Coverage   88.6%   88.95%   +0.35%
=========================================
  Files         41       41
  Lines       1132     1132
  Branches     134      134
=========================================
+ Hits        1003     1007       +4
+ Misses        87       85       -2
+ Partials      42       40       -2

Impacted Files
Coverage Δ

...n/jira/authorization/JiraAuthorizationManager.java
73.29% <0%> (+2.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc4a4c...ccd64c3. Read the comment docs.


Apply narrow_table format to ASOF join blog post

The formatting does not work yet for blog posts but I'm adding these comments as they do not cause any regression.


Current song time?

Is it possible to grab the current play time that the song is at?

idk probably, I don't have a system to test it at the moment.
try dbus-send --print-reply --dest=org.mpris.MediaPlayer2.spotify /org/mpris/MediaPlayer2 org.freedesktop.DBus.Properties.Get string:'org.mpris.MediaPlayer2.Player' string:'PlaybackStatus' and see what data you get.

That command returns:
variant       string "Paused"
or
variant       string "Playing"

dbus-send --print-reply --session --dest=org.mpris.MediaPlayer2.spotify /org/mpris/MediaPlayer2 org.freedesktop.DBus.Properties.Get string:'org.mpris.MediaPlayer2.Player' string:'Position'
http://www.frandieguez.com/blog/2010/11/playing-with-d-bus-interface-of-spotify-for-linux/

hmm, the Position always comes back as 'int64 0'
I found this from 2012 with the same issue https://community.spotify.com/t5/Desktop-Linux-Windows-Web-Player/Spotify-DBus-position-property-always-returns-0/m-p/1015074
Apparently it has still not been fixed 6 years later? :/

ya I'm honestly surprised their backend still supports the linux player all these years later
if you really want you could try keeping track of time yourself. maybe start and stop a clock by reading the PlaybackStatus frequently.
might take a while to get working :p


Integrate llvm-project at 6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f

Reset third_party/llvm-project: 6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f (2022-06-23 12:46:00 +0200): [Clang] Don't test register allocation

Looks like a lot of NFC stuff with a handful of other adaptations: round intrinsic, and transform dialect stuff that looks ok but a bit unexpected that the integrate required such extensive local fixups.

Apart from the header file renames, I had an issue with iree-dialects. Some files were deleted and when I just copied into integrations/tensorflow those files remained there. Had to manually delete those. Don't know if there was a better way.
What were the changes that you didn't expect?

That might have been it. It looks fine now


renamed areacella to areacello in sea ice tests

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #481

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
Minor change in sea ice test.

Does this PR introduce a breaking change?
No

Other information:

Pull Request Test Coverage Report for Build 2019

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.787%

Totals

Change from base Build 2011:
0.0%

Covered Lines:
2696

Relevant Lines:
3511

💛  - Coveralls


Merge "Refactor" branch

Hi @n400peanuts, sorry for the bad request a min ago. I forgot to remove all the old unit tests there. Now I should have things done in a good manner and let's try it again :).

Sorry again for this weird error on the no-test case, good job GitHub...


Incorrect Transaction List report parameter names in ReportService.php

The parameter name "both_amount" on line 1236 should be "bothamount".
array_push($uriParameterList, array("both_amount", $this->getBothAmount()));

should be:
array_push($uriParameterList, array("bothamount", $this->getBothAmount()));

Similarly, the parameter name "doc_num" on line 1242 of ReportService.php should actually be "docnum".
array_push($uriParameterList, array("doc_num", $this->getDocNum()));

should be:
array_push($uriParameterList, array("docnum", $this->getDocNum()));

As is, they are silently ignored when running a Transaction List report.

Fixed in version 6.1.2