Authentication decryption error

signature changed in latest snap of recovery build/insiders. This causes users to have to re-log in to everything on Windows.

Happened second Insiders update in a row
Version: 1.60.0-insider (user setup)
Commit: af770c2dc85ef6835197a8bd7eb416fe0a022c44
Date: 2021-08-17T19:06:19.805Z
Both extensions have same error Getting token failed: Error: Decryption failed

Fixed in latest insiders and latest recovery build

Verification steps:

Be logged in in current stable
Upgrade to recovery build
be still logged in

Do I understand correctly that Insiders build that will be tomorrow morning (2021-08-18) should no longer log out users?

@IllusionMH I released an insiders today (~3hrs ago) with the fix. If you logged in again with the bad build from this morning, then you'll have to re-log in with the good build.
In short, yes. If you log in with the latest insiders right now, you will not be forced to log in again tomorrow.

using the windows build or the snap?

This issue only applies to the windows build.

signature changed in latest snap of recovery build/insiders

Verified on windows, you aren't talking about the snap package though?

Oh sorry... "snap" in that case is like "snap a build" or like "specific build" or like "fire off a build" it has nothing to do with our snap(craft) build. lol

Worked as expected in during update from
Commit: af770c2dc85ef6835197a8bd7eb416fe0a022c44
Date: 2021-08-17T19:06:19.805Z
to
Commit: 0214d59846f265d9e50f53b61e2267407d81cbfb
Date: 2021-08-18T05:14:14.284Z
OS: Windows_NT x64 10.0.19041

/verified


Make the ping frequency from the server to the client configurable

Before it was hard-coded to 30 seconds, but this was not clear from the log output which showed the server config as having the ping frequency set to None.
With this PR, we align the options for the server and the client, and we add the possibility to disable pings altogether by setting the frequency to zero.

Thank you for that :pray:
Going to make a new release in the coming week after I get back to my desk/computer


Add backend support for multiple connections

This PR updates our handling of lnd configuration to provide the following features:

Support for multiple connection / wallet configurations
Remembering the current active configuration
Isolated lnd data directory for each connection / wallet

This will allow us add support for switching between multiple wallets / connections in the UI.
Support for multiple saved connection configurations
The connections.json data store is now capable of storing multiple connection configurations keyed under the defining properties ([type],[currency].[network].[wallet]). For example:
{
  "custom": {
    "bitcoin": {
      "testnet": {
        "wallet-1": {
          "host": "mynode:10009",
          "cert": "~/.lnd-mainnet/tls.cert",
          "macaroon": "~/.lnd-mainnet/admin.macaroon"
        }
      }
    }
  },
  "local": {
    "bitcoin": {
      "testnet": {
        "wallet-1": {
          "alias": "tom2",
          "autopilot": true
        }
      }
    }
  }
}

This allows for supporting multiple currencies, networks, and wallets for both local and remote connections).
Setting for current active connection configuration
After completing the onboarding process, the we save the current active connection key into settings.json electron store.
Isolated lnd data directory
When we start up lnd in local mode, we run it with a unique data directory derived from the connection config. For example, when using the connection config keyed at local.bitcoin.testnet.wallet-1 we will create/use a dedicated lnd data directory located at lnd/local/bitcoin/testnet/wallet-1 within the electron userData dir.
This means that we will have isolation between our internal lnd and any other lnd that the user may be running on their system.
NOTE: This PR builds on the changes in https://github.com/LN-Zap/zap-desktop/pull/656 and will therefore be easier to review in isolation after that PR has been merged.

Pull Request Test Coverage Report for Build 3692

58 of 120 (48.33%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-60.6%) to 3.076%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/lib/utils/log.js
0
1
0.0%

app/lib/lnd/util.js
3
4
75.0%

app/lib/lnd/lightning.js
0
2
0.0%

app/lib/lnd/config.js
55
59
93.22%

app/lib/lnd/neutrino.js
0
7
0.0%

app/lib/lnd/walletUnlocker.js
0
9
0.0%

app/reducers/onboarding.js
0
12
0.0%

app/lib/zap/controller.js
0
26
0.0%

Totals

Change from base Build 3687:
-60.6%

Covered Lines:
428

Relevant Lines:
3300

💛  - Coveralls

Tested ACK 56c6c59 🎊


Support ExtendedSecret certs signed by the Kube API Server

#167555390

Added two options to support CSR for ExtendedSecret:

SignerType       SignerType        `json:"signerType,omitempty"`
Usages           []certv1.KeyUsage `json:"usages,omitempty"`

Added CSR controller to watch CSR and approve it and then persists certificate signed by Kube API Server

Verification steps:
$ k apply -f ./docs/examples/extended-secret/certificate.yaml

$ k get secret
NAME                                   TYPE                                  DATA   AGE
...
nats-deployment.var-nats-cert    # This cert signed by API Server

operator can consume following CR and create cert signed by API server
---
apiVersion: fissile.cloudfoundry.org/v1alpha1
kind: ExtendedSecret
metadata:
  name: generate-certificate
spec:
  request:
    certificate:
      alternativeNames:
        - foo.com
        - '*.foo.com'
      commonName: routerSSL
      signerType: cluster
      usages: ["server auth", "client auth"]
  secretName: gen-certificate
  type: certificate


[FIX] pc.GraphNode#reparent error when passed self

fixes #1696
Currently there is no check for something like:
entity.reparent(entity);

Which gets stuck in a recursive loop.
This PR updates pc.GraphNode#reparent to check if the parent
is equal to this and throw an error before getting stuck in a
loop if so.
I confirm I have signed the Contributor License Agreement.

@vkalpias @willeastcott - I've added checks for deeper causes of infinite loops, and wrapped all checks inside DEBUG to avoid effecting production performance. Please re-review.

Nice and thorough!


History reports only a few minutes

Hi,
The tracking history doesnt work on my server. As you see it keeps only track of a few minutes and then the line disappears.
Is there a config file fix for this?

Used reports to look up


Factor media query min-width into rule-comparator

In order for larger sizes to override smaller ones and thus allow examples like grid grid-cols-3 md:grid-cols-4 lg:grid-cols-6 to work, the larger minimum sizes need to come later in the output file.

It looks like a good suggestion 👍 . I will try to review the MR this weekend.


Add items action

The action should have these arguments (item, index, items) => boolean
https://github.com/fabian-hiller/valibot/issues/487#issuecomment-2105362570
Here is an example where I have called the action "items":
import {
  _addIssue,
  type BaseIssue,
  type BaseValidation,
  type ErrorMessage,
} from 'valibot';

/**
 * Items issue type.
 */
export interface ItemsIssue<TInput extends unknown[]>
  extends BaseIssue<TInput> {
  /**
   * The issue kind.
   */
  readonly kind: 'validation';
  /**
   * The issue type.
   */
  readonly type: 'items';
  /**
   * The expected input.
   */
  readonly expected: null;
  /**
   * The validation function.
   */
  readonly requirement: (input: TInput[number]) => boolean;
}

/**
 * Items action type.
 */
export interface ItemsAction<
  TInput extends unknown[],
  TMessage extends ErrorMessage<ItemsIssue<TInput>> | undefined,
> extends BaseValidation<TInput, TInput, ItemsIssue<TInput>> {
  /**
   * The action type.
   */
  readonly type: 'items';
  /**
   * The action reference.
   */
  readonly reference: typeof items;
  /**
   * The expected property.
   */
  readonly expects: null;
  /**
   * The validation function.
   */
  readonly requirement: (input: TInput[number]) => boolean;
  /**
   * The error message.
   */
  readonly message: TMessage;
}

/**
 * Creates an items validation action.
 *
 * @param requirement The validation function.
 *
 * @returns An items action.
 */
export function items<TInput extends unknown[]>(
  requirement: (input: TInput[number]) => boolean
): ItemsAction<TInput, undefined>;

/**
 * Creates an items validation action.
 *
 * @param requirement The validation function.
 * @param message The error message.
 *
 * @returns An items action.
 */
export function items<
  TInput extends unknown[],
  const TMessage extends ErrorMessage<ItemsIssue<TInput>> | undefined,
>(
  requirement: (input: TInput[number]) => boolean,
  message: TMessage
): ItemsAction<TInput, TMessage>;

export function items(
  requirement: (input: unknown) => boolean,
  message?: ErrorMessage<ItemsIssue<unknown[]>>
): ItemsAction<unknown[], ErrorMessage<ItemsIssue<unknown[]>> | undefined> {
  return {
    kind: 'validation',
    type: 'items',
    reference: items,
    async: false,
    expects: null,
    requirement,
    message,
    _run(dataset, config) {
      if (dataset.typed) {
        for (let index = 0; index < dataset.value.length; index++) {
          const item = dataset.value[index];
          if (!this.requirement(item)) {
            _addIssue(this, 'item', dataset, config, {
              input: item,
              path: [
                {
                  type: 'array',
                  origin: 'value',
                  input: dataset.value,
                  key: index,
                  value: item,
                },
              ],
            });
          }
        }
      }
      return dataset;
    },
  };
}

Now you can write the following code:
import * as v from 'valibot';
import { items } from './your-path';

const Schema = v.pipe(
  v.array(v.string()),
  items((item) => item.startsWith('foo'), 'Your message')
);

Originally posted by @fabian-hiller in https://github.com/fabian-hiller/valibot/issues/487#issuecomment-2105006587

Thank you!

I have started to work in this issue.

Nice, thanks for letting me know.

I am still unsure of the correct name. The advantage and difference of this action is that a issue is automatically associated with the item that caused the problem. items and iterate do not reflect this in my eyes. What do you think about checkItem or forEach? The name checkItem is very clear and easy to read. forEach might also work as I plan to add actions for the other iterator methods like sort and filter as well.

I ran into another problem. Since we already have a map schema, I can't add a map action for transforming arrays due to the name collision. One solution to this problem is to call the map action forEach. Another solution might be to add the suffix Item or Items to these functions: everyItem, filterItems, findItem, mapItems, reduceItems, someItem. The last solution would also work well with checkItems.

What about checkEach? I think it reflect what it does.

checkEach is great, but I really like the Item and Items suffixes for the iterator actions. This makes it even clearer and prevents other naming conflicts in the future. If we go this way, checkItems would make more sense in my eyes.

I can see that. I'm OK with checkItems, so go on :D.

Valibot v0.33.1 is now available 🎉

Thank you. I saw you have created more Items actions, which is nice :)


Feedback - Add link to Bundlephobia

It will be a nice feature to have even a link to Bundlephobia for size of packages.
P.S. there is a plan to make this extension framework agnostic?

I will implement that.
Thanks for the feedback.

Implemented in version 0.3.0


[Bug]: Truncate method for too many nodes drops info dramatically

Bug Description
When using a query engine with a response_synthesizer of simple_summarize response mode with too many nodes, truncate method  truncates each node to very few tokens that theoretically no info is preserved (and if number of nodes are sufficiently big enough it crashes due to negative chunk size).
A better behavior would be reducing number of nodes that chunks can fit into the context window or combination of this and existing behavior. ****
Version
latest
Steps to Reproduce
make a query engine using an index that has sufficiently big enough chunks and ask a question
similarity_top_k = a very big number
index.as_query_engine(
        similarity_top_k=similarity_top_k,
        response_synthesizer=get_response_synthesizer(
            response_mode="simple_summarize",
        ),
    )

Relevant Logs/Tracbacks
No response

@qiisziilbash this module is called simple summarize because its very simple :)
If you need to summarize across variable number of nodes, I recommend using tree summarize

totally understand; would not truncating the chunks list be simpler tho :D ?

@qiisziilbash probably these two steps should just be swapped in the code
truncated_chunks = self._service_context.prompt_helper.truncate(
            prompt=text_qa_template,
            text_chunks=text_chunks,
        )
node_text = "\n".join(truncated_chunks)

Merge first, then truncate

agreed

I agree that it makes more sense to merge first and then truncate, but the merged solution introduced another problem: truncated_chunks now contains a list with a single string in it instead of just the string, so when you pass that on to the LLM class the context_str gets formatted like this ['{truncated_str}'].


Share IRRegExp generated code when passing RegExp between isolates

From https://github.com/dart-lang/sdk/issues/50082#issuecomment-1336983627
RegExp code is generated for every isolate, which can be improved if several fields are moved from object pool to RegExp class fields.

Closing this based on the commit above


Update documentation about minimum and maximum number of threads

See #1997 for the details.

Coverage remained the same at 84.479% when pulling 0e45876e18f015a0c922780a2a262bb628c0bce1 on zloster:documentation-threads into 4705f38cccddf9f15cb95c6f1db8c15a600c8078 on dropwizard:master.


print history blob as JSON string

update util methods to be able to print history event including JSON blob

Coverage decreased (-93.3%) to 5.303% when pulling 63c9bfe1984fe321db91dd4bab24cb91982efce8 on yiminc:print_history into 5a748bd362f7d350e7d448d3f5fccf22638de1fb on uber-go:master.

Coverage decreased (-98.6%) to 0.0% when pulling 63c9bfe1984fe321db91dd4bab24cb91982efce8 on yiminc:print_history into 5a748bd362f7d350e7d448d3f5fccf22638de1fb on uber-go:master.


Render quality seems worse than instant-ngp for nerf synthetic data (lego)?

Is there something that I mess up? Thank you.

Thanks for reporting the bug! It seems to be caused by the weight regularization on encoder, I have fixed this in https://github.com/ashawkey/torch-ngp/commit/17d992488baad4932995993d9279596845d4e587, it should train better now.


Taskbar won't hide when in use

When I am using this driver (is that what its calles?) the taskbar doesnt hide.
Edit: Found fix, disable notifications and actions for DS4

This Version from Jays2Kings will no longer be updated.
Please use this Version: https://github.com/Ryochan7/DS4Windows


LOD issue

Hello,
Can the LOD be adjusted to render all the tiles in the viewport?
The tiles rendered every time the camera updates seem to be only the 4 in the center.
Thanks

Yes you can change the parameters in the LOD Control object.
For LODFrustum and LOLDRadial increase the value of "subdivideDistance" to have more detail in the tiles.

by doing do I get this issue, top and bottom of the screen not on the same level :S (LODRadial, this.subdivideDistance = 100; this.simplifyDistance = 300;)

You can use the LODRadial or LODRaycast for this scenario instead.
Would be more suitable than LODFrustum

the screenshot is actually LODRadial
(LODRadial, this.subdivideDistance = 100; this.simplifyDistance = 300;)

also, the height_shader is no longer working.

@laraduarte  I have confirmed that the height shader is broken.
Please opena new issue for this. I will take a look into it.

About the lod issue described above any suggestions?!
I sti think the lod system has some issues and is also the reason why some tiles are white and not loading


Problems with D-Pad

I can connect my wiimote on dolphin-emu perfectly, all buttons works fine.
However, I would also like to use it as an ordinary joystic on linux.
I can connect it using the bluetoothctl, everything works fine but the D-pad does not work.
The command: cat /dev/input/js0
Responds to every button, but the D-pad does not respond.
I have an original wiimote, wiimote with motion plus inside and a classical controller.
In none of them the D-pad works.
Thanks in advance.

I made it work as a keyboard using xf86-input-xwiimote. In case some one want to try, I added details here.


Adds benefits of rhdh

IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.3, 1.4

Issue: https://issues.redhat.com/browse/RHIDP-4569

Link to docs preview:

Reviews:

[ ] SME: @dzemanov
[ ] QE: @ mention assignee
[ ] Docs review: @themr0c
[ ] Additional review: @mention assignee (by writer)

Additional information:

From SME point of view, looks alright :)

I really like the latest changes, the scanability has been greatly improved. Nice work!

/cherrypick release-1.3


test: gpu: add fake target for grpc.Dial

In preparation for grpc 1.52.0.
Signed-off-by: Tuomas Katila<EMAIL_ADDRESS>

Needed for #1298 to go in clean.


Module Upload Error

OData Version
OData V2
Draft
Yes
Scenario
Excel Upload - User Data
Environment
BAS and BTP Workzone
UI5 Spreadsheet Component
V0_33_4
What happened?
We consumed this Spreadsheet Module in our Custom Module and we did all the steps suggested in the below document. It was working good when we run the application. But when deployed into the Cloud Foundry we are facing the issue. Module Load Error. Please need your help as soon as possible.
URL:
Steps we followed: https://docs.spreadsheet-importer.com/pages/Button/
Error:
"severity": "error",
"text": "Error in application dependency 'cc.spreadsheetimporter.v0_33_4': No descriptor was found"
Error likely caused by:
ModuleError: failed to load 'cc/spreadsheetimporter/v0_33_4/Component.js' from ../18e1a763-6b87-4098-848a-0388d13dc63d../~020524193055+0000~/thirdparty/customControl/spreadsheetImporter/v0_33_4/Component.js: 404
Thank you.
Relevant log output
Log-dbg.js:499 2024-05-02 14:45:07.951500 The issue is most likely caused by application <Our Project Module Name>. Please create a support incident and assign it to the support component of the respective application. - Failed to load UI5 component with properties: '{
    "name": "<Our Project Module Name>",
    "url": "/18e1a763-6b87-4098-848a-0388d13dc63d.<Our mta project>.<Our Project Module Name>/~020524193055+0000~/",
    "manifest": true,
    "asyncHints": {
        "libs": [
            {
                "name": "sap.ui.table",
                "lazy": false
            },
            {
                "name": "sap.m",
                "lazy": false
            },
            {
                "name": "sap.suite.ui.generic.template",
                "lazy": false
            },
            {
                "name": "sap.ui.generic.app",
                "lazy": false
            },
            {
                "name": "sap.ui.comp",
                "lazy": false
            },
            {
                "name": "sap.f",
                "lazy": false
            },
            {
                "name": "sap.ui.fl",
                "lazy": false
            }
        ],
        "components": [
            {
                "name": "cc.spreadsheetimporter.v0_33_4",
                "lazy": false
            }
        ],
        "waitFor": []
    },
    "messages": [
        {
            "severity": "error",
            "text": "App '<Our Project Module Name>' has errors and will possibly not run properly"
        },
        {
            "severity": "error",
            "text": "Error in application dependency 'cc.spreadsheetimporter.v0_33_4': No descriptor was found"
        }
    ],
    "version": "0.0.1",
    "id": "application-so_ma_cr_dr_req-display-component",
    "componentData": {
        "startupParameters": {}
    }
}'. Error likely caused by:
ModuleError: failed to load 'cc/spreadsheetimporter/v0_33_4/Component.js' from ../18e1a763-6b87-4098-848a-0388d13dc63d.<Custom MTA Project>.<custom module name>/~020524193055+0000~/thirdparty/customControl/spreadsheetImporter/v0_33_4/Component.js: 404
    at we (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:6645)
    at ge.failWith (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:4709)
    at qe (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:13312)
    at Oe (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:15314)
    at Object.r [as require] (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:18696)
    at https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:451:36449
    at new Promise (<anonymous>)
    at https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:451:36416
    at async Promise.all (index 0)
    at async Promise.all (index 8)
Caused by: XHRLoadError: 404
    at n (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:9251)
    at XMLHttpRequest.<anonymous> (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:9504)
    at je (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:9596)
    at qe (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:13287)
    at Oe (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:15314)
    at Object.r [as require] (https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:15:18696)
    at https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:451:36449
    at new Promise (<anonymous>)
    at https://sapui5.hana.ondemand.com/1.120.8/resources/sap/fiori/appruntime-min-0.js:451:36416
    at async Promise.all (index 0)

Spreadsheet Component Init
<core:ComponentContainer
      id="_compcont"
      width="100%"
      usage="spreadsheetImporter"
      propagateModel="true"
      async="true"
      settings="{
          standalone:true,
          columns: ['COLUMN1',
                    'COLUMN2',
                    'COLUMN3'
                     ],
          componentContainerData:{
            uploadButtonPress:'uploadButtonPress',
            buttonText:'Excel Upload'
            }
          }"
      />
      <Button id="_IDGenButton1" text="Submit" class="btn_name"
              press="onPressSubmit"
              ariaDescribedBy="defaultButtonDescription genericButtonDescription" />

Manifest
MANIFEST.JSON BELOW CODE ADDED

"resources": {
            "css": [
                {
                    "uri": "css/style.css"
                }
            ]
        },
        "componentUsages": {
            "spreadsheetImporter": {
                "name": "cc.spreadsheetimporter.v0_33_4",
                "settings": {},
                "componentData": {},
                "lazy": false
            }
        },
        "resourceRoots": {
            "cc.spreadsheetimporter.v0_33_4": "./thirdparty/customControl/spreadsheetImporter/v0_33_4"
        },

PACKAGE.JSON WE DID BELOW

    "dependencies": {
        "ui5-cc-spreadsheetimporter": "^0.33.4"
    },

Hi,
did you follow the Guide and did the BTP specific part:
https://docs.spreadsheet-importer.com/pages/GettingStarted/#btp-environment-deployment
Please check again if you followed all parts

Hi Marian, Thank you for your response, we missed this step you mentioned, we implemented it and it is working now. Thank you for your help. Also do you have any sample error handling example kindly share the link :) . Thank you again for your help.

What kind of error handling? Backend error?

no response

Hi Marian
From BAS we are able to deploy the application and we can see the preview of the application all good. But at the Build Workzone the application is not available. when we synced we got the below error regarding spreadsheet.
It was working good but when we did the redeployment we were facing this issue. Kindly respond as early as possible.

"AppId_cc.spreadsheetimporter.v0_33_4": {
"error": [
"Replication failed for HTML5 app 'zmacreditdebitrequest' and manifest 'thirdparty/customControl/spreadsheetImporter/v0_33_4/manifest.json'",
"Service name 'spreadsheetimporter_v0_33_4' and public setting 'true' in embedded manifest.json have to be equal to service name 'ManualAdjustment' and public setting 'true' of root manifest.json"
],
"warning": []
}

I´ve seen this from another customer.
I´d recommend the standalone deployment.
If you like you can open a ticket on this one with SAP and report back. I have not got a feedback on that one.

Many thanks Marian for your response.
Standalone Deployment means deploying from the SAP BAS directly? Even then
we are facing the issue. How can we fix this? SAP tickets will take time.
On Thu, May 30, 2024 at 6:04 AM Marian Zeis @.***>
wrote:

I´ve seen this from another customer.
I´d recommend the standalone deployment.
If you like you can open a ticket on this one with SAP and report back. I
have not got a feedback on that one.
—
Reply to this email directly, view it on GitHub
https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/issues/544#issuecomment-2139310466,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIHUI4FGFU2GLBABA6WOV4LZE4BTNAVCNFSM6AAAAABHELN56CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZGMYTANBWGY
.
You are receiving this because you authored the thread.Message ID:
<spreadsheetimporter/ui5-cc-spreadsheetimporter/issues/544/2139310466@
github.com>

--
Best Regards
Raghavendra Marelle
309 445 4901


Revert to no dependencies

As per #34, there are problems with the dependency. It seems not to be very straightforward to make things work on all environments, so I decided to revert to not having dependencies after all.

No, let's do this another way.


Missing exposure attribute in the document

Looks like the exposure attribute is missing in the document.
https://googlewebcomponents.github.io/model-viewer/

Thanks for catching this!


Opening this scene freezes the SDK

When I open this scene, the SDK freezes for several seconds. The OpenGL scene composer is sometimes made visible before the freeze happens, in which case the water in the scene keeps on moving but I can't interact with either it or the rest of the SDK.
scene.zip

This error occurs when opening it in the terrain editor. There doesn't seem to be any way to copy/paste the text out of the dialog.

You're simply running out of direct memory, you can increase that in the jmonkeyplatform.conf file.

Also see here:
https://wiki.jmonkeyengine.org/doku.php/sdk:increasing_heap_memory
Without having viewed the file: Your Scene might be huge and you might consider splitting it in parts where possible and only merge it in the game itself (and maybe not even there, only load parts of it)


combine() parsl_app returns exception if cached

** DESCRIPTION **
parsl_app throws exception when cached.
** TO REPRODUCE **
The following construction will cause an exception to be returned:
@python_app(executors=['cori-login'],cache=True)
def combine(inputs=[]):
return
Where inputs is a list of futures.
'cori-login' is defined as:
ThreadPoolExecutor(
label='cori-login',
max_threads=2
),
The exception is:
unknown type for memoization: <class 'parsl.dataflow.futures.AppFuture'>
** ENVIRONMENT **
Parsl branch lsst-dm-202103
Running at NERSC/Cori

The closest I've been able to replicate this (knowing what you've been working on) is if an earlier app returns a Future in its return statement - as if it was a join app (but without a @joinapp or join=True annotation).
In that case, that behaviour is expected: a Future can't be used as a key for checkpointing.
Here's my incorrect code that gives this exception:
import parsl

@parsl.python_app
def noop():
  import time
  time.sleep(10)
  return

@parsl.python_app
def n2():
  return noop()

@parsl.python_app(cache=True)
def combine(inputs=[]):
  return

parsl.load()

nf = n2()

combine(inputs=[nf]).result()

combine(inputs=[nf]).result()

print("done")

By replacing the definition of n2 with:

@parsl.join_app
def n2():
  return noop()

(joinapp vs pythonapp)
then this code works ok.

Ben has instructed me to use 'join_app' in this case and my tests are now running successfully.  Case closed.


Fix weak reply name for Request() call.

Current implementation of NewInbox() could generate identical names when several Request() calls could be done from different threads at the close time.
The problem is that Random() uses Environment.TickCount as a seed. When program makes several Request() calls in the same system tick (500 ms), the several Random().NextBytes() calls will generate identical inbox names for reply for different requests. In that case both requests will get the first server response.
To solve it I suggest to use more strongly generator like Guid.NextGuid() for inbox name.

Perhaps a better approach would be to use a hash value of a new GUID as the seed? This would enable using the higher performance of the Random without the expense of a new GUID creation on every request/reply.
Conceptually, if #158 gets implemented using a GUID as the inbox (or something with similar uniqueness) then that would solve this problem.

Let me compare current implementation and the new one by performance:
var tr = Stopwatch.StartNew();
var r = new Random();
for (int i = 0; i < 1000000; i++)
{
	byte[] buf = new byte[13];
	r.NextBytes(buf);
	var bits = BitConverter.ToString(buf).Replace("-", "");
}
Console.WriteLine($"Elapsed Random(): {tr.Elapsed}");

var tg = Stopwatch.StartNew();
for (int i = 0; i < 1000000; i++)
{
	var guid = Guid.NewGuid().ToString("N").ToUpperInvariant();
}
Console.WriteLine($"Elapsed GUID:     {tg.Elapsed}");

The result is:
Elapsed Random(): 00:00:00.7047381
Elapsed GUID:     00:00:00.6231147

If uppercased name is not required, then it is possible to omit ToUpperInvariant(). Finally the "guid used" implementation will be just about twice faster then the current one:
Elapsed Random(): 00:00:00.7164708
Elapsed GUID:     00:00:00.4075821

Good timing information to have, but I saw the opposite on my laptop (interestingly enough). Of note, I made the following change to the loop to avoid throwing away the result of the operation:
string[] keepThisValue = new string[1];
// ...
    keepThisValue[0] = BitConverter.ToString(buf).Replace("-", "");
// ...
    keepThisValue[1] = Guid.NewGuid().ToString("N").ToUpperInvariant();

Giving me:
Elapsed Random(): 00:00:01.0181849
Elapsed GUID:     00:00:02.9218345

Your test give me the next results (i7-6700 CPU 3.4GHz Win10):
Elapsed Random(): 00:00:00.7384288
Elapsed GUID:     00:00:00.5470446

It appears that my old MacBook Pro (Core 2 Duo) is showing its age!

Christopher , I've changed the code as you suggested.
I hope this will ensure the uniqueness of names at high performance on every platform.

@alexanderinochkin , the code looks good to me; I'm glad you've caught this.
Just a few things...   Can you add a test for this that fails with the current code to ensure it is fixed?  Also, it looks like tabs/alignment have been changed.  If you could remove the whitespace changes that'd be great.

@ColinSullivan1 , the test is added to the pull request.


Security: Marten logging exposes connections strings to logs

In the past we have had issues with MartenCommandException including the NpgsqlCommand in the exception. This led to PII issues where sensitive information in the sql query parameters was exposed in logs.
Last week we had a security incident when we identified secure database credentials including passwords had been sent to our centralized logging system. The underlying exception was a System.OperationCancelledException - a query running too long. But the resulting log had the following included in the Error.StackTrace.Data property:
{
    "NpgsqlCommand": {
        "AllResultTypesAreUnknown": false,
        "CommandText": "select data, type, mt_dotnet_type, seq_id, id, stream_id, version, timestamp, tenant_id, correlation_id, causation_id, headers, is_archived from <censored>.mt_events as d WHERE (d.is_archived = FALSE and  d.tenant_id = :p0 and  d.stream_id = :p1) ORDER BY d.seq_id",
        "CommandTimeout": 30,
        "CommandType": 1,
        "Connection": {
            "CanCreateBatch": true,
            "CommandTimeout": 30,
            "ConnectionString": "Host=<censored>.rds.amazonaws.com;Port=5432;Database=<censored>;Username=<censored>",
            "ConnectionTimeout": 15,
            "DataSource": "",
            "Database": "<censored>",
            "FullState": 0,
            "IntegratedSecurity": false,
            "Port": 0,
            "Settings": {
                "Database": "<censored>",
                "Host": "<censored>.rds.amazonaws.com",
                "Password": "<censored!!!!!!!!!!!!!!!!>",
                "Port": "5432",
                "Username": "<censored>"
            },
            "State": 0,
            "UserName": "<censored>"
        },
        "DesignTimeVisible": false,
        "IsPrepared": false,
        "Parameters": [
            {
                "DataTypeName": "text",
                "DbType": 16,
                "Direction": 1,
                "IsNullable": false,
                "NpgsqlDbType": 19,
                "NpgsqlValue": "<censored>",
                "ParameterName": "p0",
                "Precision": 0,
                "Scale": 0,
                "Size": 0,
                "SourceColumn": "",
                "SourceColumnNullMapping": false,
                "SourceVersion": 512,
                "Value": "<censored>"
            },
            {
                "DataTypeName": "text",
                "DbType": 16,
                "Direction": 1,
                "IsNullable": false,
                "NpgsqlDbType": 19,
                "NpgsqlValue": "<censored>",
                "ParameterName": "p1",
                "Precision": 0,
                "Scale": 0,
                "Size": 0,
                "SourceColumn": "",
                "SourceColumnNullMapping": false,
                "SourceVersion": 512,
                "Value": "<censored>"
            }
        ],
        "Statements": [],
        "UpdatedRowSource": 3
    }
}

This is the full content of the NpgsqlCommand object, complete with connection string (note that the password is not in the string, as the setting Persist Security Issue=false was configured). Inside the connection class though there is a "settings" class which contains the connection string again including password.
As a workaround, we have modified our opentelemetry to include a filter that strips the "data" property from exceptions.
The command object is attached here and here. The intention appears to be to help include the query in logs for debugging, but far too much sensitive information is also included, and it appears that neither NpgsqlCommand nor any of its child properties were ever intended to be safely serialised.
Is it possible to get a review of the value of adding the command to console logs, and if there is still command, an option to disable this functionality in production environments? Or maybe some cleverness needs to be done to extract the important information from the command object for logging.

As a cheesy, quick fix, I'm having that exception do in effect a clone of the NpgsqlCommand so that you get the command information, but not the connection.

@jeremydmiller This definitely fixes the connection string issue but there is still the concern that by including the sql parameters that sensitive client information will be logged (eg serialised events)


fix: fixed the broken testcases

We notice that there are some errors when run the testcases. There are three broken testcases in factly, each of them are smaill error.
I also find the travis-ci is not free now. The auto test is not triggered when new pull request is merged to master or new commit is push to master. I will make a pull request to switch travis-ci to github action.

I also add .vscode to the .gitignore in this pull request, since the .vscode diretory will be auto created when someone do breakpoint debug on vscode.


source code of matchpoint algorithm?

Hi, where could I get the source code of matchpoint algorithm(like rigidicp)?
Also, if I want to add other custom matchpoint algorithm, what is the procedure to import it?(if I have the cpp code of coherent point drift algorithm, what is the algorithm template and what should I do to import it?) Thank you!

only find dll file in bin folder

Hi, thank you for your question and the interest in MITK/MatchPoint. If you want to add you own algorithm in an MITK base application, the easiest way to do it is to shown in module MatchPointRegistration
You can do the same in your own module.
In MatchPointRegistration you can find two directories:

algorithms: It contain the MatchPoint algorithm classes that should be ultimatly deployed and there profile information (the one you e.g. see in the MatchPoint browser). Here you have the full range of possibilities (from just typenaming and specifying template classes (like in mitkMultiModalRigidHeadNeckRegistrationAlgorithm.h) to complete new classes derived from the MatchPoint algorithm base clases (like mitkMultiModalTransDefaultRegistrationAlgorithm.h)
deployment: here you decide which classes (and with which templating (e.g. pixel type or dimension) should be compiled into shared objectes. It is always the same pattern and you can see it in the cpps. The lifting is done by mapDeployAlgorithmMacro if one provides a class.
The last thing that is needed is to generate a cmake target for that. You can see that in depoyment/CMakeLists.txt (using mitkFunctionCreateMatchPointDeployedAlgorithm; see its documentation in CMake/mitkFunctionCreateMatchPointDeployedAlgorithm.cmake).

I hope that information will help you.

The MatchPoint source code is an external project. It can be found in your build tree under ep\src\MatchPoint.
It is pulled from https://github.com/MIC-DKFZ/MatchPoint.git.
But you don't need to change that repo to implement new algorithms. You can do that directly in a using project (like in an MITK module).


Fix layout of advanced build settings

Aligned labels with checkbox
Reduced space between last row and previous row
Changed labels to sentence case
Changed word slightly

Before:

After:

Tagged:

This includes https://github.com/dotnet/roslyn-project-system/pull/173, so for actual changes - see last two commits #82786c1 and #00868d5

tag @dotnet/roslyn-analysis

Any remember the magic incantation in the comments section mark resources as "non-localizable"? Looks like error reporting and debugging information aren't expected in the code to be localized.

These four commits make up the changes:
https://github.com/dotnet/roslyn-project-system/pull/175/commits/82786c1c1aa2700f44c8ea952382423dff823471
https://github.com/dotnet/roslyn-project-system/pull/175/commits/00868d53992e6090c58767a3dcf311f2ada6124d
https://github.com/dotnet/roslyn-project-system/pull/175/commits/a0e3246dbbf3042a94bfc4f74b12479ccf6a161a
https://github.com/dotnet/roslyn-project-system/pull/175/commits/9fc45337d240fd4421d86101b851268e8ea60563
I removed an extra 3 "designer" px from the dialog that hosts the control to reduce space between buttons and page:

Side note, those buttons aren't currently "AutoSized" - trying to figure out how to do that nicely with dynamically added controls (the content of the dialog), without double auto-sizing it.

This has been updated.

👍

I figured out how to not localize these strings @jinujoseph, got to figure out the real localization for these here: https://github.com/dotnet/roslyn-project-system/issues/52.

:+1:


Android - Back navigation breaks with nested page-router-outlets.

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI: 5.3.0
Android Runtime: 5.1.0
NativeScript-Angular: 7.1.0
Angular: 7.1.0

Describe the bug
On Android, navigation history is broken when navigating backward via nested page-router-outlets. Note: This works as expected on iOS just fine.
To Reproduce

Create a NS Angular project with routes like so...

{ path: "", redirectTo: "/home/(homeoutlet:lounge)", pathMatch: "full" },
{ path: "home", component: HomeComponent, children: [
    { path: "lounge", component: LoungeComponent, outlet: "homeoutlet" },
    { path: "garage", component: GarageComponent, outlet: "homeoutlet" }
] },
{ path: "work", component: WorkComponent }

On the Lounge page, add a button to navigate to "/home/(homeoutlet:garage)"
On the Garage page, add buttons to navigate "routerExtensions.back()" and to "/work".
On the Work page, add a button to navigate "routerExtendsion.back()".
Run the app.
Starting at Home/Lounge, navigate to Home/Garage then to Work. Then go back() and attempt to go back() again.
The page will remain on the Home/Garage page despite that not being the start of the nav stack.

Expected behavior
If I navigate from home/lounge -> home/garage -> work, then i press back() twice, I should return to home/lounge.
Sample project
https://github.com/sbknick/ns-android-nested-back-nav
Additional context
On iOS, this functions as expected.

HI @sbknick,
Thank you for the provided sample project. I was able to recreate the issue on my side and I will log it as a bug, which we will investigate further.  As a temporary solution. You can replace the router-outlet with page-router-outlet.

I have a similar issue and the router.navigate Promise resolves on the second try with the value null. Maybe that's a bit of extra information.

I'm having exactly the same issue, are there possible workarounds?

I'm also struggling with this issue. any solution for this issue?

I am also running into this issue. Guess there's been no progress?

I found a kind of workaround, by forcing the back event on homeoutlet, when the back button leads to one of children page of HomeComponent.
Considering than /home/(homeoutlet:lounge) is the starting page, I simply added in ngOnInit method in HomeComponent :
application.android.off(application.AndroidApplication.activityBackPressedEvent);
application.android.on(application.AndroidApplication.activityBackPressedEvent, (args : application.AndroidActivityBackPressedEventData) => {
       if(this.routerExtensions.router.url.indexOf("/home/(homeoutlet:") != -1 && this.routerExtensions.router.url.indexOf("/home/(homeoutlet:lounge") == -1) {
            args.cancel = true;
            this.routerExtensions.back({ relativeTo: this.activeRoute, outlets: ['homeoutlet'] });
       }
})

That was enough for me to have the behaviour expected
Impact on this workaround:  if you use a modal page in one of a children page of HomeComponent, then the back button will not close the modal

@sbknick
The behavior you observe is expected. Calling routerExtensions.back(); or routerExtensions.backToPreviousPage(); navigates back on the last navigated outlet.
When you navigate from lounge to garage, you navigate inside the homeoutlet, back at this point means going back in the homeoutlet, so you can successfully go back to lounge.
When you navigate to work, this is effectively navigation from home to work which happens inside the primary outlet, back at this point means going back in the primary outlet to home (which remembered its state so the homeoutlet is still on garage). Going back again is an attempt to navigate back in the primary outlet which is not possible as there is no route before home.
In order to perform the navigation inside the homeoutlet, you can call routerExtensions.back({ relativeTo: this.route; });, where route is the ActivatedRoute service injected through the component’s constructor:
export class GarageComponent {
    constructor(
        private route: ActivatedRoute,
        private routerExtensions: RouterExtensions
    ) {
        console.log("garage loaded");
    }

    goBack() {
        // Don't navigate to previous page:
        // this.routerExtensions.backToPreviousPage();
        // Navigate relative to the activated route instead:
        this.routerExtensions.back({ relativeTo: this.route });
    }
    goToWork() {
        this.routerExtensions.navigate(["work"]);
    }
}

Nested navigation is thoroughly explained in this excellent article by Alexander Djenkov.

Hi Team ,
Any fix available for this issue?


Error re-creating stream

Provider Version
0.76.0
Terraform Version
1.3.9
Describe the bug
I want to re-create an existing stream, which can be done by marking the Terraform state as tainted. Once done that the Terraform plan will say the following about the object:

 is tainted, so must be replaced

Once the plan is applied Terraform will fail with:

Error: error creating stream  err = 002002 (42710): SQL compilation error:
Object '<FQ_NAME>' already exists.

Expected behavior
Should not fail. Either it drops the stream first of uses CREATE OR REPLACE STREAM, which I can see in the activity the provider is not doing.
Code samples and commands
Please add code examples and commands that were run to cause the problem.
Additional context
Add any other context about the problem here.

Hi @elventear 👋
Sorry for the late response. We've released a new v0.98.0 version (release, migration guide) with new stream resources, based on stream type in CREATE STREAM. Please upgrade to this version and use one of the relevant resources. Note that stream is now deprecated.

Closing due to inactivity. Please create a new issue if the problem persists in the newest version.


tests(queues): disable the flaky queues shutdown test

Summary
disable the flaky queues shutdown test

Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference
internal issue KAG-2612

Fix #[issue number]

There is a proper fix so close this one.


Duplication of events

Steps

Configure Activity One to use EventForwarder for some event
Raise this event (Activity Two opened)
Rotate the screen
Press Back

Expected

Activity One on screen

Occurred

Activity Two opened again

EventBus no more supported.


[Possible FR] migrate: safe for join tables

Hello,
I am using migrate: safe in production on all my models, but there seems to be no way to enforce that for join tables. I would like to be able to use migrate:alter in development / test and migrate:safe in production on join tables as well.
Is there some kind of configkey for that already?

Looks fixed!


what is payerId and nonce in this const and how can i get this

const {
nonce,
payerId,
email,
firstName,
lastName,
phone
} = await requestOneTimePayment(
token,
{
amount: '5', // required
// any PayPal supported currency (see here: https://developer.paypal.com/docs/integration/direct/rest/currency-codes/#paypal-account-payments)
currency: 'GBP',
// any PayPal supported locale (see here: https://braintree.github.io/braintree_ios/Classes/BTPayPalRequest.html#/c:objc(cs)BTPayPalRequest(py)localeCode)
localeCode: 'en_GB',
shippingAddressRequired: false,
userAction: 'commit', // display 'Pay Now' on the PayPal review page
// one of 'authorize', 'sale', 'order'. defaults to 'authorize'. see details here: https://developer.paypal.com/docs/api/payments/v1/#payment-create-request-body
intent: 'authorize',
}
);

These are returned by calling the requestOneTimePayment function, you don't have to provide them. Closing this, let me know if you have further issues.


Newsletters: add 107 (2020-07-22)

[ ] Releases and RCs @harding
[x] Services and clients @bitschmidty
[x] Merge summary @adamjonas

Thanks mschmidts. Changes look good!

ACK 6171584c13f9d5370b1d16515e9602b1e584a496

Small commit to remove unused fee overpayment link (from previous RC draft). Squashed.

Cant stop the Optech 🚅
@jonatack @jnewbery and @adamjonas with reviews this week
@harding and @adamjonas authoring!


Possible inconsistency in type unification

Suggesting was made in fsharp/fsharp#422 to open this issue here instead
let foo (a: seq<seq<'a>>) = a
let someCharArAr()        = [|[| 's' |]|]
let quack                 = [|[| 's' |]|]
let moo : char [][]       = quack

foo [|[| 's' |]|]  |> ignore // OK

foo (someCharArAr()) |> ignore // Fails
foo moo   |> ignore // Fails
foo quack |> ignore // Fails

I would think that if foo [|[| 's' |]|] type checked, that the other applications of foo would type check too, but they do not. Type checking for each of the others fails with:
The type 'seq<'a>' does not match the type 'char []'

I am working with the version of the compiler packaged with VS2015pre, fsi reports a version of '14.0.22810.0'. It seems to be reproducible in 3.0 as well though.

This is to do with how array expressions [| ... |] are checked as of F# 3.x. . See 6.3.4 in the F# 3.1 Language spec.   The rule says that where if the element type is known before checking the array expression then each element may upcast to that element type, e.g. cases such as let x : Widget[] = [| Label(); Button() |] .  We have generally been hesitant about adding such rules precisely because of the kind of effect shown above - this is one case where we eventually made an exception.
The workaround suggested in fsharp/fsharp#422  is the right one (use a flexible type in the signature of the function)


implement urlquery

Implement urlquery

Codecov Report

Merging #34 (c70a47d) into main (b92c00b) will increase coverage by 10.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
+ Coverage   33.16%   43.24%   +10.08%
===========================================
  Files          32       32
  Lines        1541     1547        +6
===========================================
+ Hits          511      669      +158
+ Misses       1030      878      -152

Impacted Files
Coverage Δ

src/builtins/impls/mod.rs
0.00% <ø> (ø)

src/builtins/mod.rs
89.28% <ø> (+89.28%)
:arrow_up:

src/builtins/impls/urlquery.rs
100.00% <100.00%> (+100.00%)
:arrow_up:

tests/smoke_test.rs
100.00% <100.00%> (ø)

src/types.rs
66.66% <0.00%> (+1.19%)
:arrow_up:

src/funcs.rs
66.81% <0.00%> (+8.73%)
:arrow_up:

src/policy.rs
66.29% <0.00%> (+11.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92c00b...c70a47d. Read the comment docs.


Menu-Entry swap for runecrafting altars

I accidentally craft fire runes pretty frequently when doing Lava rune crafting, so hiding that option would help a lot to stop making that mistake.
I think adding a menu entry swap option for it would be great, as it would just make you walk to the altar rather than craft the fire runes.
I have tried making it myself, but my knowledge of Java is very limited and I did not get very far. It showed up in the menu for menu-entry swapping, but I could not get anything in-game to change.

Duplicate of #4960


ARTEMIS-2582: EmbeddedActiveMQ.stop() should check for null

PR is created to as response for https://issues.apache.org/jira/browse/ARTEMIS-2582
cc @clebertsuconic

hello @clebertsuconic
do you have any suggestions or comments on this?

it may as well have a little test, to ensure there is no regression in the future

I added a test during merge. Thanks, @nbrendah!


resin-supervisor: Update to v7.25.8

Changelog-entry: Update resin-supervisor to v7.25.8
Change-type: patch
Signed-off-by: Pablo Carranza Velez<EMAIL_ADDRESS>
Contributor checklist

[ ] Changes have been tested
[ ] Change-type present on at least one commit
[ ] Signed-off-by is present
[ ] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

When submitting a review, please pick:

'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@resin-ci retest


Update expensify-common to updated commit hash

Details

Additional regex rule was added to replace
\
...\

 with \
...\

Fixed Issues

$ https://github.com/Expensify/App/issues/8089
Tests

[x] Verify that no errors appear in the JS console
1- Open the app
2- Navigate to any chat with another user.
3- Write a text in one or more line
4- On next line start codeblock.
5- After codeblock ends write some more text(without any extra line)
6- Send message and check there will be no extra space above or below codeblock.

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

[x] Verify that no errors appear in the JS console
1- Open the app
2- Navigate to any chat with another user.
3- Write a text in one or more line
4- On next line start codeblock.
5- After codeblock ends write some more text(without any extra line)
6- Send message and check there will be no extra space above or below codeblock.
7- Test the above steps on all platforms

Screenshots

Web

Mobile Web

Desktop

iOS

Android
Unfortunately rn can't run on android simulator is broken :( Though i tested on real device when fixed but couldn't take screenshot at that time

@aneequeahmad, don't delete the default PR template from the description. Copy and paste it into the description of the PR and mark the checkboxes accordingly:

Details

Fixed Issues

$ GH_LINK
Tests

[ ] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcochavezf  Ahhh yes, added the PR template. Thanks.

I included screenshots or videos for tests on all platforms

@aneequeahmad I don't see you included the screenshots/videos for the tests 😅

I linked the correct issue in the ### Fixed Issues section above

The issue should be linked with the $ at the beginning:

I wrote clear testing steps that cover the changes made in this PR

The testing steps are not included in the Tests section.
Also, follow the instructions that are commented in the template:

@marcochavezf oh yes, I've learned the whole process. Apologies for the back and forth and Thankyou for bearing with me

@marcochavezf Actually i'm unable to run the project atm 403 forbidden error is thrown by api. I raised this issue in slack channel as well but couldn't find any way to fix this issue :(
Will look into this issue as soon as my project is in running state

@aneequeahmad how's it looking?

@rushatgabhane unfortunately, I can't run the android app. Will run the project on another machine today and will look into it over the weekend. Thanks

https://github.com/Expensify/App/pull/8872#issuecomment-1121406516

@marcochavezf the PR tests well for me on Android.
I don't see any extra space between the first line and the code block.

@marcochavezf anyway, a more up-to-date commit for expensify-common has been deployed to production in this PR.
I'd suggest that we

Ask QA to test https://github.com/Expensify/App/issues/8089
Close this PR

What do you say?

Oh I see thanks @rushatgabhane @aneequeahmad! Probably I didn't update the npm package properly at that time, but it's great to know it's working fine on Android!

What do you think? Is there something else that we should do?

Yup, that sounds like a plan! I'm going to ping QA team to test the issue again

@marcochavezf Thats great! Its already in production. Lets ask the QA team to do the testing.
@rushatgabhane thanks for verifying on android.


[Enhancement] Add columns name message for generated and auto columns

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

cc @kangkaisen @silverbullet233 @fzhedu https://github.com/StarRocks/starrocks/pull/34135 change to this pr , thanks

FE Cover Checker failed, could you add more test cases to cover your change?

FE Cover Checker failed, could you add more test cases to cover your change?

ok，I would add more testcase @silverbullet233

@silverbullet233 all fe ut cover had passed


For scalability branch: strange ContainerInfo triggers panic

In my experimental environment, I changed the clock between some nodes(includes heapster) to nonsynchronous , i got a panic.
Then i take a debug, found that:
when call function getAllContainers:
https://github.com/kubernetes/heapster/blob/heapster-scalability/metrics/sources/kubelet/kubelet_client.go#L118
func (self *KubeletClient) getAllContainers(url string, start, end time.Time) ([]cadvisor.ContainerInfo, error) {
	// Request data from all subcontainers.
	request := statsRequest{
		ContainerName: "/",
		NumStats:      1,
		Start:         start,
		End:           end,
		Subcontainers: true,
	}
	...

the respone of container info does not contains any stat, like this:
{
"/": {
"name": "/"
"subcontainers": [...6]-
"spec": {...}-
}-
"/0410ffb12de5b16669727cb8d30dd64c7d065b21859d6e235916e2d9d0b13409": {
...

So, the panic will occur  in funciton decodeMetrics, when get c.Stats[0]
https://github.com/kubernetes/heapster/blob/heapster-scalability/metrics/sources/kubelet/kubelet.go#L146
	for _, metric := range StandardMetrics {
		if metric.HasValue(&c.Spec) {
			cMetrics.MetricValues[metric.Name] = metric.GetValue(&c.Spec, c.Stats[0])
		}
	}

I will take a PR to fix this.
And i want to mention the clock synchronization once more ^_^ https://github.com/kubernetes/heapster/pull/814
@mwielgus

We don't panic anymore. Fixed


MatLab error evaluating method 'outputs' in readWrite 2motors/read

Hello any help with this error would be greatly appreciated.

Dear Ollie,
Apologies for the delayed answer. From your screenshot it seems that a library is not correctly added or there is a duplicate library causing a problem. Have you followed the steps noted in the Github description for adding the C and MATLAB libraries in MATLAB path with all their subfolders? This should solve the problem.
@.***
Best Regards,
Georgios Andrikopoulos
@.***
Georgios Andrikopoulos
Assistant Professor in Mechatronics with focus on Robot Design
KTH Royal Institute of Technology
Engineering Design Department / Mechatronics Unit / Robot Design Laboratory
Brinnellvägen 83, SE-114 28 Stockholm, Sweden
Phone: +46-8-790 63 31
Email<EMAIL_ADDRESS>Site: https://www.kth.se/profile/geoand?l=en
Personal Site: https://www.researchgate.net/profile/George-Andrikopoulos
From: ollie-wiltshire @.>
Sent: Wednesday, November 29, 2023 5:54 PM
To: geoand-robotdesign/Dynamixel_Library_MATLAB_Simulink @.>
Cc: Subscribed @.***>
Subject: [geoand-robotdesign/Dynamixel_Library_MATLAB_Simulink] MatLab error evaluating method 'outputs' in readWrite 2motors/read (Issue #1)
Hello any help with this error would be greatly appreciated.
MicrosoftTeams-image.png (view on web)https://github.com/geoand-robotdesign/Dynamixel_Library_MATLAB_Simulink/assets/150293667/abe0e625-59e2-44c2-be7d-6f0df66a288a
—
Reply to this email directly, view it on GitHubhttps://github.com/geoand-robotdesign/Dynamixel_Library_MATLAB_Simulink/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZEBEVPVIAVLCVHXMFOQTQ3YG5SBHAVCNFSM6AAAAAA77ZMLEGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTOMBSGQ2DGNI.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>

Hi Georgios,
i got the same issue. I double checked the description and cant find the error.
Using the corresponding .m file works fine, also the MatLab examples.
Do you have any idea what could be the problem?
Kind regards,
Benjamin


Override license information of ibrowse under erland_rebar.

Failing the build because :fatal_licensing_warnings is set in the configuration.
Error(s):

    Dependency 'ibrowse' version '8f3f6a3a30730b193cc340a8885a960586dc98de' under 'erlang_rebar' is missing license information.
    Dependency 'ibrowse' version '8f3f6a3a30730b193cc340a8885a960586dc98de' under 'erlang_rebar' is missing license information.
    Dependency 'ibrowse' version '8f3f6a3a30730b193cc340a8885a960586dc98de' under 'erlang_rebar' is missing license information.

👍


I couldn't even compile a contract

Describe the bug
I couldn't deploy any contract on the site
Oops, There is an Issue!!!
Sorry about this
Issue loading project: "Cannot read properties of undefined (reading 'mutable')"
Click  to go to home page or last loaded project
To Reproduce
Expected behavior
Oops, There is an Issue!!!
Sorry about this
Issue loading project: "Cannot read properties of undefined (reading 'mutable')"
Click  to go to home page or last loaded project
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: WINDOWS 11
Browser BRAVE AND CHROME
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Do you happen to know the project id of the project trying to be loaded?

Try again, we released a new backend version.

assuming fixed, user hasn't responded.


"make check" giving error on CentOS 6 (64-bit)

Currently I'm getting the following error when running make check:
PASS: version_t
ok 1 - stdout for c++ /tmp/QjcTVYR2gP/open.cpp -I/usr/local/share/libmaxminddb/include -L/usr/local/share/libmaxminddb/src/.libs -lmaxminddb -o/tmp/QjcTVYR2gP/open
ok 2 - stderr for c++ /tmp/QjcTVYR2gP/open.cpp -I/usr/local/share/libmaxminddb/include -L/usr/local/share/libmaxminddb/src/.libs -lmaxminddb -o/tmp/QjcTVYR2gP/open
ok 3 - exit status was 0 for c++ /tmp/QjcTVYR2gP/open.cpp -I/usr/local/share/libmaxminddb/include -L/usr/local/share/libmaxminddb/src/.libs -lmaxminddb -o/tmp/QjcTVYR2gP/open
Permission denied at /usr/local/lib/perl5/site_perl/5.8.8/IPC/Run3.pm line 426.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 13 just after 3.
FAIL: compile_c++_t.pl
ok 1 - mmdblookup script is executable
ok 2 - stdout for mmdblookup -h
ok 3 - stderr for mmdblookup -h
ok 4 - exit status was 0 for mmdblookup -h
ok 5 - stdout for mmdblookup -?
ok 6 - stderr for mmdblookup -?
ok 7 - exit status was 0 for mmdblookup -?
ok 8 - stdout for mmdblookup --help
ok 9 - stderr for mmdblookup --help
ok 10 - exit status was 0 for mmdblookup --help
ok 11 - stdout for mmdblookup
ok 12 - stderr for mmdblookup
ok 13 - exit status was 1 for mmdblookup
ok 14 - stderr for mmdblookup --file foo
ok 15 - exit status was 1 for mmdblookup --file foo
ok 16 - stdout for mmdblookup --version
ok 17 - stderr for mmdblookup --version
ok 18 - exit status was 0 for mmdblookup --version
ok 19 - stdout for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS>
ok 20 - stderr for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS>
ok 21 - exit status was 0 for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS>
ok 22 - stdout for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS> --verbose
ok 23 - stderr for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS> --verbose
ok 24 - exit status was 0 for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS> --verbose
ok 25 - stdout for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS> location latitude
ok 26 - stderr for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS> location latitude
ok 27 - exit status was 0 for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS> location latitude
ok 28 - stderr for mmdblookup --file this/path/better/not/exist.mmdb --ip <IP_ADDRESS>
ok 29 - exit status was 2 for mmdblookup --file this/path/better/not/exist.mmdb --ip <IP_ADDRESS>
ok 30 - stderr for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip not-an-ip-address
ok 31 - exit status was 3 for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip not-an-ip-address
ok 32 - stderr for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS>
ok 33 - exit status was 6 for mmdblookup --file /usr/local/share/libmaxminddb/t/maxmind-db/test-data/GeoIP2-City-Test.mmdb --ip <IP_ADDRESS>
1..33
PASS: mmdblookup_t.pl
====================================
1 of 17 tests failed
Please report to<EMAIL_ADDRESS>====================================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/usr/local/share/libmaxminddb/t'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/usr/local/share/libmaxminddb/t'
make: *** [check-recursive] Error 1

Thanks for the report. It sounds like some sort of permission issue. It is likely safe to ignore that failure.

Yep, I was getting the following at PHP Startup:
Warning: PHP Startup: Unable to load dynamic library '.../maxminddb.so' - libmaxminddb.so.0: cannot open shared object file: No such file or directory in Unknown on line 0

...solved the problem with the following (but I'm sure it's not related to the permission issue reported by make check):
sudo sh -c "echo /usr/local/lib  >> /etc/ld.so.conf.d/local.conf”
sudo ldconfig


Add support for per-page header/footer

Needs a bigger discussion around whether this is practical, and what the implementation would look like.
Considerations:

We can't guarantee a page source has 7 days in a row, nor that a page source has the same number of days in all rows. For example, assuming a row has 7 days in order to add weekday labels is not viable
We should preserve type safety as much as possible
We should not force any particular type of header. For example, the user may want to display the current month, the date range, both, or none

I'm wondering if the best approach would be to create empty interfaces for CalendarHeader and CalendarFooter. The user would be required to check the type when binding their headers, but this has the advantage of allowing different header/footer types on different pages if they so desire


Fix the yield from expression

Now that this is working, I'm planning on implementing async def coroutines :)

Could I get a review from someone? I've already got async/await working locally, and I'd like to get this merged before opening a PR for that.

Now I'm curious to how you did the async/await thingy. Nice job!


update and remove win32

Description
There was an issue while updating to flutter 3.10, one of the plugins WIN32 uses an old plugin chiew 1.0.0, so had to remove it and it didn't break anything so far
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.
e.g.

Fix #123
Related #456

Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I titled the PR using Conventional Commits.
[ ] I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[ ] No, this is not a breaking change.

There was an issue while updating to flutter 3.10, one of the plugins WIN32 uses an old plugin chiew 1.0.0, so had to remove it and it didn't break anything so far

There are no issues with building projects with Flutter 3.10 and current version of share_plus. Also, win32 doesn't use any chiew dependencies that you mentioned. So you need to deal with your build config in the project and not touch plugins that have nothing to do with your setup.

I was getting this error,
Because no versions of share_plus match >7.0.0 <8.0.0 and share_plus 7.0.0 depends on win32 ^4.0.0, share_plus ^7.0.0 requires win32 ^4.0.0.
Because wakelock_windows >=0.2.1 depends on win32 ^3.0.0 and wakelock_windows <0.2.1 depends on win32 ^2.0.0, every version of wakelock_windows requires win32 ^2.0.0 or ^3.0.0.
Thus, share_plus ^7.0.0 is incompatible with wakelock_windows.
And because chewie >=1.3.5 depends on wakelock ^0.6.2 which depends on wakelock_windows ^0.2.0, share_plus ^7.0.0 is incompatible with chewie >=1.3.5.
So, because app depends on both chewie ^1.4.0 and share_plus ^7.0.0, version solving failed.
exit code 1

The issue is that wakelock_windows (a dependency of chewie) relies on an old version of win32. I've sent the author a PR to fix this:
https://github.com/creativecreatorormaybenot/wakelock/pull/203

You could try this in your pubspec.yaml to workaround the issue with pub get:
dependency_overrides:
  win32: ^4.0.0


Only update class docstring if ipython is available

Currently param updates class docstrings to help with tab completion. I think this behavior is useful (and can be disabled by setting the docstring_signature variable to False but it might be worth considering two tweaks to this behavior:

Only doing this for ParameterizedFunction (might be tricky, currently the logic is on ParameterizedMetaclass)
Only doing this when in an ipython context. This may also be hacky as it might mean trying to detect get_ipython in the namespace (or similar).

I just want to consider these options as I would prefer to mutate docstrings only when tab-completion is actually relevant.

@jlstevens was this resolved by https://github.com/holoviz/param/pull/774?


Not enough vertical space for horizontal scrollbar leads to unnecessary vertical scrollbar

Version: 1.52.1 (user setup)
Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523
Date: 2020-12-16T16:34:46.910Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041
Not enough vertical space for horizontal scrollbar leads to unnecessary vertical scrollbar, EG in "Open editors" view.
Steps to Reproduce:

Enable horizontal scrolling
Create some files which require horizontal scrolling
Observe unnecessary vertical scrollbar in "Open editors" view (see screenshots below)

This seems to have been automatically closed in issue #67441 by vscodebot, but I don't think it should have been, and I don't know how to re-open the issue.
As stated by olegbl, "To solve both issues, what needs to grow by the height of the scroll bar is the container not the content."
This issue is quite annoying, and has been around for a while, so would be great if it could be fixed!

Does this issue occur when all extensions are disabled?: Yes/No

@joaomoreno do we have some master issue for this scrollbar should not show up?

@joaomoreno do we have some master issue for this scrollbar should not show up?

@isidorn This is not an issue with the tree. It's an issue with the view. You have to add horizontalScrollbarHeight pixels to the height of the Open Editors view.

@isidorn This is not an issue with the tree. It's an issue with the view. You have to add horizontalScrollbarHeight pixels to the height of the Open Editors view.

Yeah makes sense.
However that would add unneceserry height to the view imho, thus leaving this in the backlog.

Yeah makes sense.
However that would add unneceserry height to the view imho, thus leaving this in the backlog.


Support for GitHub Enterprise implemented here

This is pretty rough right now but it gets the job done.
https://github.com/0xtavian/shhgit
Things changed:
Added basic auth functionally for Cloning repos which is required by GHE https://github.com/0xtavian/shhgit/blob/master/core/git.go
Implemented baseURL here https://github.com/0xtavian/shhgit/blob/master/core/session.go#L65

Would the creds better be suited for the config file? Isnt this then hardcoding your username/token?

i have tried to build it but it just keeps saying
You need to provide at least one GitHub Access Token. See https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line

@Phil-ThePower-Pearce were you able to build it?

I got away with only using the token in #38. Please give at spin and see if it works for you.

Closed. See #38


[Python][Docs] Document behavior of to_pandas with flat and nested timezone arrays

Describe the enhancement requested
In https://github.com/apache/arrow/issues/41162 it was reported that PyArrow's to_pandas method silently drops timezone information from nested Timestamp arrays. For example,
import pandas as pd
import pyarrow as pa

ts = pandas.Timestamp('2024-01-01 12:00:00+0000', tz = 'Europe/Paris')

# unnested, we get a timezone-aware result
pa.Array.from_pandas([myts]).to_pandas()[0]
# => Timestamp('2024-01-01 13:00:00+0100', tz='Europe/Paris')

# nested, we get a timezone-naive result
pa.Array.from_pandas([[myts]]).to_pandas()[0][0]
# => numpy.datetime64('2024-01-01T12:00:00.000000')

The reason for this is explained the comments of https://github.com/apache/arrow/issues/41162 and the upshot is of that is that we may not change the behavior at the moment. Therefore, I think it would be good to at least document the current behavior, including what workarounds may exist.
Component(s)
Documentation, Python

take


Upgrade to Node 16

Is it possible to get an update that upgrades this to node 16
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: TriPSs/conventional-changelog-action

This would be great!


feat(autoware_map_based_prediction): improve frenet path generation

Description

Add backlash within lanelet when predict paths. (Background: Small bikes are tend to drive side within the lane. However, the predictor yields the paths always to the center of the lane.)

Before : The target path is to center line position of the target lanelet.
After : The target path allows offset if the momentum (lateral position + 0.5 * lateral velocity * lateral_duration) is within the backlash width. The backlash width is determined by the path width - the object width. The bias is modeled by a continuous function.

Before
https://github.com/user-attachments/assets/ecfebfdf-47da-4fc3-bb44-e57bc71a9cca
https://github.com/user-attachments/assets/84b1d6b9-be35-4f28-8c25-df0b9eb479f9
After
https://github.com/user-attachments/assets/c4ca2ebd-44a5-429d-8877-2644bc9a8457
https://github.com/user-attachments/assets/573753aa-907c-47bf-bb60-d3abdd757661

Considering proper starting reference path for Frenet path generation

Since the reference path and the starting point of the Frenet path is important, related logic has been changed.

Before: Search the closest path position and calculate the Frenet path boundary condition. If the angle of the closest path is steep, the generated path could be extremely curved.
After: The starting path in the reference path will be found considering the object motion. If the path is not suitable to generate proper path, the path prediction will be replaced by a straight path.

Before
https://github.com/user-attachments/assets/d752db4f-911e-4543-ab4c-a3f20de7beb5
https://github.com/user-attachments/assets/5b6a5600-2262-4456-bb6c-c88ea078bddb
After
https://github.com/user-attachments/assets/3f5d20ed-ecbc-4617-a3a4-ae3c6db936a0
https://github.com/user-attachments/assets/c9fc76ea-1076-4a75-9ed5-036886ee19d0

Interpolation and extrapolation of the path generation is customized to support 2

4, Bug fix related to the initial position of the Frenet path generation
Related links
Parent Issue:

Link

How was this PR tested?
TIER IV Cloud
4127/4130
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

I confirmed T4 CI results, no problem
https://evaluation.tier4.jp/evaluation/reports/7a00c6c1-d977-5d10-8990-ead641680a61?project_id=prd_jt

Worst case performance in my laptop seems to be OK.
⏰ Worst Case Execution Time ⏰
100.00% objectsCallback: total 11.79 [ms], avg. 11.79 [ms], run count: 1


Add admin logs for butchering

About the PR

Adds an admin log for when someone successfully butchers something. The attempt was already logged.
Why / Balance

Fixes #25278
Technical details

Added a couple dependencies and the log at the end of SharpSystem's OnDoAfter.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: Admin logs now include successful butchering!

This isn't player facing so doesn't need a changelog.


Will the 2nd edition reference Language-Ext?

Just discovered that you're writing a 2nd edition! Excellent news, my copy is getting very dog-eared from having been read many times!
Anyway, without wishing to be rude, may I make a request (that may be too late). The only drawback I felt the book had was that you used your own library, instead of using Language-Ext. I understand the educational reasons for developing a library as you went along, but at the end of the day, you yourself recommend Language-Ext as "a more fully-fledged functional library."
Thing is, Language-Ext suffers badly from a lack of good documentation. Your book could easily be that documentation, making it even more useful than it already is. Even if you just added a small paragraph at the end of each section showing how the concepts and code you just described would be done in Language-Ext, it would give a kick-start to those of us who are keen to put your ideas into practice, but are struggling to translate them.
This is NOT meant in any way to put down La Yumba, it's meant as a constructive comment to give the book a whole new dimension.
Thanks for listening, and thanks for writing what is (in my opinion anyway) probably the most important C# book ever written. Really, I mean that, no flattery here!

Hi @MrYossu,
thanks for your enthusiasm and your suggestion.
Indeed, it is a bit late, as the 2nd edition is in the production phase and should be available soon (the MEAP is already available, of course).
I do understand your suggestion. The thing is, the "release cycle" of a book and an open source library are so different, that they would be inevitably become out of sync. For example, I was able to make all the code for the 2nd edition target .NET 6 and C# 10. So at this moment my book is "ahead" of language-ext, and I can illustrate functional features in the latest C# language and .NET libraries. But in, say, 3 years, my book will likely have fallen behind language-ext.
In the future, language-ext may introduce breaking changes, new ways of doing things, or be superseded by another, similar library (say, one developed by the .NET foundation, you never know). That would "break" the code in the book, or render it obsolete, and that would be a nuisance to anyone reading the book then. That's why I choose to decouple the book from language-ext.