NameError: name 'ipyleaflet' is not defined

I am trying to get using Plot Tide Forecast.ipynb to get a time series of the earth and ocean tide at a certain point, but in string:
m = pyTMD.tools.leaflet(center=(LAT,LON), zoom=3,
    zoom_control=True, marker_control=True)

I ran into the following problem:
NameError                                 Traceback (most recent call last)
Cell In[3], [line 3](vscode-notebook-cell:?execution_count=3&line=3)
      [1](vscode-notebook-cell:?execution_count=3&line=1) # default coordinates to use
      [2](vscode-notebook-cell:?execution_count=3&line=2) LAT,LON = (-76.0, -40.0)
----> [3](vscode-notebook-cell:?execution_count=3&line=3) m = pyTMD.tools.leaflet(center=(LAT,LON), zoom=3,
      [4](vscode-notebook-cell:?execution_count=3&line=4)     zoom_control=True, marker_control=True)
      [5](vscode-notebook-cell:?execution_count=3&line=5) # show map
      [6](vscode-notebook-cell:?execution_count=3&line=6) m.map

File [~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3)+gef78f74-py3.10.egg/pyTMD/tools.py:217, in leaflet.__init__(self, projection, **kwargs)
    [215](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3+gef78f74-py3.10.egg/pyTMD/tools.py:215) # create basemap in projection
    [216](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3+gef78f74-py3.10.egg/pyTMD/tools.py:216) if (projection == 'Global'):
--> [217](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3+gef78f74-py3.10.egg/pyTMD/tools.py:217)     self.map = ipyleaflet.Map(center=kwargs['center'],
    [218](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3+gef78f74-py3.10.egg/pyTMD/tools.py:218)         zoom=kwargs['zoom'], max_zoom=15, world_copy_jump=True,
    [219](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3+gef78f74-py3.10.egg/pyTMD/tools.py:219)         attribution_control=kwargs['attribution'],
    [220](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3+gef78f74-py3.10.egg/pyTMD/tools.py:220)         basemap=ipyleaflet.basemaps.Esri.WorldTopoMap)
    [221](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3+gef78f74-py3.10.egg/pyTMD/tools.py:221)     self.crs = 'EPSG:3857'
    [222](https://untitled+.vscode-resource.vscode-cdn.net/~/bin/jupiter/.venv/lib/python3.10/site-packages/pyTMD-2.1.1.dev3+gef78f74-py3.10.egg/pyTMD/tools.py:222) elif (projection == 'North'):

NameError: name 'ipyleaflet' is not defined

What could be the problem? There were no problems when installing pyTMD. I am grateful in advance for any help!

Hi @glukvit!
As part of #156 and other issues, I removed dependencies that were part of the example notebooks but not needed as part of the "core code". These are now listed in the documentation as "Optional Dependencies". I think if you still build using environment.yml you can get the full build. Sorry for the trouble!!

I'm going to close this issue, feel free to reopen it.


[improve][broker] enhance grant permission module to reduce zk metadata

Motivation
related to https://github.com/apache/pulsar/issues/16768
Modifications
pulsar old version

partition (e.g., persistent://public/default/mytopic-partition-0)
based topic (e.g., persistent://public/default/mytopic)

grant
only partition
grant all partition and then grant based topic

revoke
only partition
revoke all partition and then revoke based topic (shutdown if throw exception)

get
only partition
only based topic

check
check partition and then check based topic
only based topic

pulsar new version

partition (e.g., persistent://public/default/mytopic-partition-0)
based topic (e.g., persistent://public/default/mytopic)

grant
based topic
only based topic

revoke
revoke all partition granted in previous version then revoke based topic
revoke all partition granted in previous version then revoke based topic

get
get this partition and then get based
only based topic

check
check partition and then check based topic
only based topic

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

@nodece @Technoboy- @codelipenghui PTAL, this problem would result in permission can not be revoked

Hi @TakaHiR07, Thanks for your contribution! I think you should consider the compatibility here.

I have changed the proposal and I think it is the better way to solve this problem and meet the compatibility.
pulsar old version

partition (e.g., persistent://public/default/mytopic-partition-0)
based topic (e.g., persistent://public/default/mytopic)

grant
only partition
grant all partition and then grant based topic

revoke
only partition
revoke all partition and then revoke based topic (shutdown if throw exception)

get
only partition
only based topic

check
check partition and then check based topic
only based topic

pulsar new version

partition (e.g., persistent://public/default/mytopic-partition-0)
based topic (e.g., persistent://public/default/mytopic)

grant
only partition
only based topic

revoke
only partition
revoke based topic and then revoke partition

get
only partition
only based topic

check
check partition and then check based topic
only based topic

I have changed the proposal and I think it is the better way to solve this problem and meet the compatibility.
pulsar old version
partition (e.g., persistent://public/default/mytopic-partition-0)	based topic (e.g., persistent://public/default/mytopic)
grant	only partition	grant all partition and then grant based topic
revoke	only partition	revoke all partition and then revoke based topic (shutdown if throw exception)
get	only partition	only based topic
check	check partition and then check based topic	only based topic
pulsar new version
partition (e.g., persistent://public/default/mytopic-partition-0)	based topic (e.g., persistent://public/default/mytopic)
grant	only partition	only based topic
revoke	only partition	revoke based topic and then revoke partition
get	only partition	only based topic
check	check partition and then check based topic	only based topic

/pulsarbot rerun-failure-checks

This table looks confused, I think you should follow the https://github.com/apache/pulsar/pull/16792?notification_referrer_id=NT_kwDOAPe6cbM0MDcwMTQyMTMyOjE2MjM1MTIx&notifications_query=repo%3Aapache%2Fpulsar#discussion_r938428577, you also need to improve the get action.

It looks like you didn't update the org.apache.pulsar.broker.authorization.PulsarAuthorizationProvider#checkPermission.

It looks like you didn't update the org.apache.pulsar.broker.authorization.PulsarAuthorizationProvider#checkPermission.

Yes,  I didn't update this for compatibility.

As you saw, the CI fails.

As you saw, the CI fails.

@nodece As you suggest, I have completely change the implementation of grant/revoke/get/check permission. Therefore many relevant unittest become flaky.
What do you think of this new implementation？ If there are no other problems, I would fix the relevant flaky test.

Thanks for your contribution @TakaHiR07. This is a great start. However, I think we'll need some additional work before it is ready to be merged.
First, I think this work will need to be two PRs.
There will be a PR to update how permissions are revoked. Essentially, we should not fail a request that attempts to remove permission from a partition of a topic that was not already granted permission. We will need to determine how to handle the case that a non-partitioned topic or all of the partitions of a partitioned topic (including the partitioned topic itself) does not have permission. This PR will be backwards compatible and will therefore be able to be cherry picked to existing release branches.
Then there is a PR that will change what the PersistentTopicsBase passes to the AuthorizationService. This PR is an optimization to limit the amount of metadata stored in ZK. Instead of passing each topic partition to the grantPermissionsAsync method, we'll just pass the topic that the user is attempting to grant permission on. This will technically be a breaking change for custom implemenations of the AuthorizationProvider interface, so we cannot cherry pick this change.
In order to be upgrade and downgrade compatible, we'll need to leave the revoke permission logic the same for a multiple minor versions. This work could be tracked in an issue.
Since both PRs will have to do with authorization and what the Pulsar Broker passes to the pluggable AuthorizationProvider, I think we should give a notice on the<EMAIL_ADDRESS>mailing list to get consensus. I expect that this will not be a blocker for the feature/bug fix.

I agree with it. I open another PR to update how permissions are revoked.
This PR remain as the second PR to optimize  the implementation of permission. I am not familiar with how to get consensus, so I would wait for update this pr until the implementation is approved.

Thanks for your contribution @TakaHiR07. This is a great start. However, I think we'll need some additional work before it is ready to be merged.
First, I think this work will need to be two PRs.
There will be a PR to update how permissions are revoked. Essentially, we should not fail a request that attempts to remove permission from a partition of a topic that was not already granted permission. We will need to determine how to handle the case that a non-partitioned topic or all of the partitions of a partitioned topic (including the partitioned topic itself) does not have permission. This PR will be backwards compatible and will therefore be able to be cherry picked to existing release branches.
Then there is a PR that will change what the PersistentTopicsBase passes to the AuthorizationService. This PR is an optimization to limit the amount of metadata stored in ZK. Instead of passing each topic partition to the grantPermissionsAsync method, we'll just pass the topic that the user is attempting to grant permission on. This will technically be a breaking change for custom implemenations of the AuthorizationProvider interface, so we cannot cherry pick this change.
In order to be upgrade and downgrade compatible, we'll need to leave the revoke permission logic the same for a multiple minor versions. This work could be tracked in an issue.
Since both PRs will have to do with authorization and what the Pulsar Broker passes to the pluggable AuthorizationProvider, I think we should give a notice on the<EMAIL_ADDRESS>mailing list to get consensus. I expect that this will not be a blocker for the feature/bug fix.

This PR remain as the second PR to optimize the implementation of permission. I am not familiar with how to get consensus, so I would wait for update this pr until the implementation is approved.

You can do this simply by sending an email to the<EMAIL_ADDRESS>email indicating the change you'd like to make. If you are unable to do this, I can send the email.

Guide: https://pulsar.apache.org/contributing

This PR remain as the second PR to optimize the implementation of permission. I am not familiar with how to get consensus, so I would wait for update this pr until the implementation is approved.

You can do this simply by sending an email to the<EMAIL_ADDRESS>email indicating the change you'd like to make. If you are unable to do this, I can send the email.

Thanks for your guide, I have sent an email to<EMAIL_ADDRESS>

@TakaHiR07 Any updates?

@TakaHiR07 Any updates?

Haven't updated. I would update the implementation in a few day.

The code has been updated. PTAL. @michaeljmarshall @nodece
With #17393, we can simply change the grantPermission() at AuthorizationProvider, and internalGetPermissionsOnTopic() at PersistentTopicsBase

@TakaHiR07  hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.

Since we will start the RC version of 3.0.0 on 2023-04-11, I will change the label/milestone of PR who have not been merged.

The PR of type feature is deferred to 3.1.0
The PR of type fix is deferred to 3.0.1

So drag this PR to 3.0.1

@TakaHiR07 - I am so sorry for losing track of this PR. Are you interested in continuing your work on it? If not, I am going to pick up the work in a couple weeks. Thank you for your valuable observations and contributions so far!

@TakaHiR07 - I am so sorry for losing track of this PR. Are you interested in continuing your work on it? If not, I am going to pick up the work in a couple weeks. Thank you for your valuable observations and contributions so far!

There is another pr about this work, you can take a look of it. https://github.com/apache/pulsar/pull/18222. I am glad to continue improve this work


spoc: abort apparmor recording if BPF LSM is not enabled

What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
https://github.com/kubernetes-sigs/security-profiles-operator/issues/2384
Does this PR have test?
Yes.
Does this PR introduce a user-facing change?
Fix a bug where spoc would generate empty AppArmor profiles on systems without BPF LSM enabled.

/lgtm cancel
The unit tests seem to fail now.

Codecov Report
Attention: Patch coverage is 41.30435% with 27 lines in your changes missing coverage. Please review.

Project coverage is 42.08%. Comparing base (11d77f4) to head (6dd7503).
Report is 373 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2385      +/-   ##
==========================================
- Coverage   45.50%   42.08%   -3.42%
==========================================
  Files          79      109      +30
  Lines        7782    15916    +8134
==========================================
+ Hits         3541     6698    +3157
- Misses       4099     8722    +4623
- Partials      142      496     +354

Fixed. :)


Version 1.0 RC

It would be nice to use bower for the UI JS dependencies rather than committing them to the repo

@Page- I still have to test the last changes, but I think these last commits address all of your comments.

Ok, and it's good to ping when they're done because github doesn't notify when a PR gets changed (or at least it doesn't notify for me :(  )

@Page- done, except for the last note, as I think it's wontfix, what do you think?

@Page- :+1:

LGTM


Create windows_logo.py

Type of change
Added a new program to generate a windows logo on the python screen.

[x] Added new project
[ ] Bug fix
[ ] New features
[ ] Enhanced documentation

Changes proposed in this pull request

Project name : Windows Logo

Short description : A windows logo is generated with the help of Python GUI.

Checklist

[x] The code is Python 3 compatible
[ ] I have added relevant comments in my file to make code understandable
[x] I have added my project in a folder which includes all the necessary files

Add image also


Update to wrong dependencies, seem connected to net5.0

Description
Update to wrong dependencies
Repro steps
update the dependencies
.paket/paket.exe update --no-install
.paket/paket.exe restore

Expected behavior
paket.dependecies
framework: netcoreapp3.1,netstandard2.1

nuget System.Management.Automation
nuget Microsoft.Powershell.Commands.Diagnostics
nuget Microsoft.Powershell.Commands.Management
nuget Microsoft.Powershell.Commands.Utility
nuget Microsoft.Powershell.ConsoleHost

Got warning like below:
 - System.Management.Automation 7.1.0
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 7.1, please tell the package authors
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 12.0.3, please tell the package authors
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 2.15, please tell the package authors
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 5.0, please tell the package authors
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 2.0, please tell the package authors

And my project can't compile due to frameworkk is, not compatible
Package Microsoft.PowerShell.Commands.Management 7.1.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Microsoft.PowerShell.Commands.Management 7.1.0 supports: net5.0 (.NETCoreApp,Version=v5.0)

Actual behavior
Can't compile after running these two commands

Can you please upload a zip with the repro? Thanks
Qiu Hao<EMAIL_ADDRESS>schrieb am Fr., 20. Nov. 2020, 07:14:

Description
Update to wrong dependencies
Repro steps
update the dependencies
.paket/paket.exe update --no-install
.paket/paket.exe restore
Expected behavior
paket.dependecies
framework: netcoreapp3.1,netstandard2.1
nuget System.Management.Automation
nuget Microsoft.Powershell.Commands.Diagnostics
nuget Microsoft.Powershell.Commands.Management
nuget Microsoft.Powershell.Commands.Utility
nuget Microsoft.Powershell.ConsoleHost
Got warning like below:

System.Management.Automation 7.1.0
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 7.1, please tell the package authors
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 12.0.3, please tell the package authors
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 2.15, please tell the package authors
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 5.0, please tell the package authors
Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 2.0, please tell the package authors

And my project can't compile due to frameworkk is, not compatible
Package Microsoft.PowerShell.Commands.Management 7.1.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Microsoft.PowerShell.Commands.Management 7.1.0 supports: net5.0 (.NETCoreApp,Version=v5.0)
Actual behavior
Can't compile after running these two commands
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/3948, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOANB6FUFHN2D5JCOLHM3SQYCM7ANCNFSM4T4LEYYQ
.

Can you please upload a zip with the repro? Thanks Qiu Hao<EMAIL_ADDRESS>schrieb am Fr., 20. Nov. 2020, 07:14:
…
Description Update to wrong dependencies Repro steps update the dependencies .paket/paket.exe update --no-install .paket/paket.exe restore Expected behavior paket.dependecies framework: netcoreapp3.1,netstandard2.1 nuget System.Management.Automation nuget Microsoft.Powershell.Commands.Diagnostics nuget Microsoft.Powershell.Commands.Management nuget Microsoft.Powershell.Commands.Utility nuget Microsoft.Powershell.ConsoleHost Got warning like below: - System.Management.Automation 7.1.0 Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 7.1, please tell the package authors Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 12.0.3, please tell the package authors Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 2.15, please tell the package authors Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 5.0, please tell the package authors Could not detect any platforms from 'net5.0' in package System.Management.Automation >= 2.0, please tell the package authors And my project can't compile due to frameworkk is, not compatible Package Microsoft.PowerShell.Commands.Management 7.1.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Microsoft.PowerShell.Commands.Management 7.1.0 supports: net5.0 (.NETCoreApp,Version=v5.0) Actual behavior Can't compile after running these two commands — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3948>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOANB6FUFHN2D5JCOLHM3SQYCM7ANCNFSM4T4LEYYQ .

Sorry, can't do that

Need to manually pin-up their assemblies to the version support dotnetcore3.1


style(menu table): replace add category button with new bottom row

Restyle adding a menu category
Grey out edit button when another window is opened

@cchyung Just uploaded a new plus icon, thanks!


[pscustomobject] / [psobject] instances aren't auto-converted to strings in .NET method calls

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Generally, objects of any type are auto-convertible to strings when passed to string-typed .NET method parameters.
[pscustomobject] a.k.a [psobject] is the curious exception.
There is no reason for [pscustomobject] instances to act differently than instances of any other type (irrespective of whether implicit stringification makes sense in a given situation); to give a simple (but contrived) example:
If (42).ToString((Get-Item /)) works,
there's no reason why (42).ToString(([pscustomobject] @{ foo=1 })) shouldn't.
Note:

The problem doesn't just affect locally constructed custom objects, but also the [psobject] instances that the serialization infrastructure produces on deserialization, for the emulation of types it cannot re-create with type fidelity.

Implicit stringification in the context of cmdlets / functions / script is not affected; e.g., Get-Date -Format ([pscustomobject] @{ foo=1 }) doesn't cause an error.

Possibly related:

#6163

Expected behavior
PS> (42).ToString(([pscustomobject] @{ foo=1 }))
@{foo=1}  # I.e. the equivalent of (42).tostring('@{foo=1}')

Actual behavior
The method call fails, because the [pscustomobject] isn't auto-converted to a string, and method overload resolution fails.
Error details
MethodException: Cannot find an overload for "ToString" and the argument count: "1".

Environment data
PowerShell Core 7.3.0-preview.2

Visuals
No response

The Engine WG discussed this yesterday. Initially we were unsure if this was done purposefully and decided it needed more research.
After looking into it, I'm pretty confident it is a bug. LanguagePrimitives internally replaces the fromType with InternalPSObject if the pso has no base object. The code in core adapter sort of tries to emulate LanguagePrimitives' code to fall back to the base object, but it omits the translation from an empty PSO to InternalPSObject.
The fallback code from DotNetAdapter:
https://github.com/PowerShell/PowerShell/blob/b46ac16e09dce433dbc1ecb19ab949754eef4978/src/System.Management.Automation/engine/CoreAdapter.cs#L860-L868
And from LanguagePrimitives:
https://github.com/PowerShell/PowerShell/blob/b46ac16e09dce433dbc1ecb19ab949754eef4978/src/System.Management.Automation/engine/LanguagePrimitives.cs#L4786-L4812
Marking up for grabs.


SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

Changes:
Currently the input topic partitions assigned to a container of a samza job is stored in the coordinator stream(aka kafka topic).
In samza-yarn ApplicationMaster startup sequence, the JobModel from the previous run of the samza job is read from the coordinator stream.
JobModel is read multiple times(3 times) from the same kafka topic with different connections. These redundant reads prolongs the launch of containers by the samza-yarn ApplicationMaster. This fix is to remove the inefficieny by reading the coordinator stream only once with one connection.
Please do note that the above two problems had slowed down ApplicationMaster startup and did not break functional correctness.
Note:

In addition to the above problem,  KafkaSystemAdmin is created multiple times for same topic/system multiple times in ApplicationMaster/Container and it will be fixed in SAMZA-2157.
Tested this patch with a test samza-yarn job inside linkedin and with a beam job.

@prateekm
You have the most context about this, would you please review this when you have a chance.
In a follow-up patch, I will move ChangelogpartitionManager to use metadata-store as well.

@prateekm
I have attached the application master logs before and after the fix:

To highlight the reduction in the coordinator stream reads.
To document the reduction in the samza yarn Application Master startup time.

Here're the relevant application master logs: https://gist.github.com/shanthoosh/bb5fd478f2ac4da76855fd43eebe0f58


q: Delimited by comma instead of space

See https://github.com/opengeospatial/ogcapi-records/issues/295

Potentially relevant for STAC Browser's Collection Search implementation and the server-side implementation from Spacebel @ycespb


dbt profiles should have environment schemas called out

dbt run should take an environment argument:
dbt run --dev
dbt run --prod
This isn't a massive deal, but at the moment you have to go into profiles.yml and switch the schema. And that's vulnerable to forgetting that, in the future, you have in fact switched the schema and accidentally deploying to production when you didn't mean to.

(I don't actually care about the specific commands. If you think dbt run --env=prod is better that's fine.

dbt debug --target dev # use "dev" target of default "user" profile
dbt debug --profile org-2 --profile "dev" # use "dev" target of "org-2" profile
dbt debug --profile org-2 --profile "prod" # use "prod" target of "org-2" profile

This works for dbt (debug|compile|run|test)
If this gets annoying, consider using a makefile:
org1-dev:
  dbt compile --profile org-1 --profile dev
  dbt run --profile org-1 --profile dev

org1-prod:
  dbt compile --profile org-1 --profile prod
  dbt run --profile org-1 --profile prod

dbt run should invoke dbt compile in the future, so this is just a stopgap solution


Unbalanced parens in mapping.lisp

The opening defmacro is never closed.

Fixed in the latest commit.


Allow urls for files to be relative to a common base url

Expected Behavior

Allow for a base url variable to be set in the configuration, which would be prepended the urls of the files themself if they aren't an absolute url.
Current Behavior

Currently, if you only wish to use files from a different repository and it has the exact same file structure, you'll need to edit every url in the configuration.
Possible Solution

Read a base url variable and store it, then read the url/path for the file the user wishes to download. If that url/path isn't an absolute url, then append that path to the base url.
Context

Makes it cumbersum to use the extension if you wish to use a different repository with the same file structure.
Your Environment
Not really relevant, as it isn't a bug.

This is an interesting idea!


Update Czech.xml

Added missing strings (such as DCH settings or Text17)
Overall translation improvements

Thanks


[Feat]: Adding macro invocation for Github issues

This PR partially address issue #232
Changes

You can now trigger Openhands for Github issues by leaving a new comment on the issue with the macro @openhands-agent
Openhands only considers the new comment with macro, and the original title/body of the issue as context
If you want Openhands to use every comment on an issue as context, the fix-me label should be used instead of the macro

Sample test with macro
Workflow log

Future work
I'm thinking of doing the following work on separate PRs

Starting the resolver from comments containing macro on PRs
Allowing users to customize the macro that triggers the resolver

I think it only partially fixes #232; need to add similar functionality for PR comments as well 🙂


[SPARK-43314][CONNECT][PYTHON] Migrate Spark Connect client errors into error class

What changes were proposed in this pull request?
This PR proposes to migrate all Spark Connect client errors into error class
Why are the changes needed?
To improve PySpark error
Does this PR introduce any user-facing change?
No API changes, only error improvement.
How was this patch tested?
This existing CI should pass.

merged to master


Propose to remove versioned files

I notice there is two copies of latest version in dist directory. One without version number and the other has. I think this is not a good practice, as other popular projects do not follow this pattern.
I will usually

create a vendor directory and then
run npm install foo manually (out of the vendor directory) and then
create a new sub directory with its version number and then
copy the minified version (or maybe also the unzipped version) there
in HTML code, I will manually upgrade the version number.

Hope this can change your mind to remove the extra copy from dist directory.

in version 0.11.16 there will be no versioned files in npm

0.11.16 had versioned file as main file fixed in 0.11.17.


(PDB-5484) Add clj-kondo

Recommend looking at this in something like gitk that keeps the commits in branch order, and likely with ignore blanks turned on.  There are also references to related commits, providing some context, in some of the commit messages.
I've marked it work-in-progress because if nothing else, I'm not sure about keeping the final commit, and we also need to be sure the new logic is accurate in the important respects (also wondered if we could simplify it further).  If we're not sure, or don't want to think about it, I'll just drop it.


ERR: between_time now checks for argument types

Closes #11818

do you think passing non-time like strings are also an error?
e.g.
2015-01-01 09:00 would be valid (previously and after this one). We could restrict to Timedelta parsables I think (not exactly the same thing but would work).

Unfortunately, I don't know how to check that.  How it currently works is the dateutil parser is used to parse the time string but a datetime.datetime is returned regardless if it's a time string or date string.
>>> from dateutil.parser import parse
>>> parse("2015-12-13 10:10")
datetime.datetime(2015, 12, 13, 10, 10)
>>> parse("10:10")
datetime.datetime(2015, 12, 13, 10, 10)
>>>

I see what your idea is but I'm just not sure that the Timedelta and dateutil parser are completely the same.
>>> Timedelta("10:10")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "pandas/tslib.pyx", line 2277, in pandas.tslib.Timedelta.__new__ (pandas/tslib.c:41085)
    value = np.timedelta64(parse_timedelta_string(value, False))
  File "pandas/tslib.pyx", line 2862, in pandas.tslib.parse_timedelta_string (pandas/tslib.c:49601)
    raise ValueError("expected hh:mm:ss format")
ValueError: expected hh:mm:ss format

the timedelta parser is a bit strick for this, can prob make a mini one by doing something like:
try:
    return time.strptime(s, '%H:%M:%S')
except:
    try:
        return time.strptime(s, '%H:%M')
    except:
        # rise here

Seems like we should also do a milliseconds parse for safe measure.
>>> parse("10:10:10.123")
datetime.datetime(2015, 12, 13, 10, 10, 10, 123000)

don't use dateutil.parse we want a time only

My only comment was that it's currently supported so we need that additionally.

easiest might be to loop thru a list of allowed formats until u match (or exhaust the list and raise)
using strptime is strict (which is good)

I'm confused as to why this fails on 2.6.  I created a 2.6 environment and the test works fine there.
Python 2.6.9 |Continuum Analytics, Inc.| (unknown, Aug 21 2014, 18:28:52)
...
In [1]: from datetime import datetime

In [2]: datetime.strptime("2:00am", "%I:%M%p").time()
Out[2]: datetime.time(2, 0)

Ah, it's because that test uses the am/pm from it_IT locale.  Skipped if there is a locale present.

Hopefully we are all good here.

small comments.
pls run: git diff master | flake8 --diff and fix the PEP8 issues (this is going to become standard shortly).
this looks really good. I think we could expose this via pd.to_time. Though I we do need better time support. Pls create an issue so we can consider this in the future.
ping when green.

@jreback Green.  I feel more comfortable leaving the ability to add another format given that we do not know how much people were relying on dateutil's parser.  It's two lines of code and innocuous.

merged via https://github.com/pydata/pandas/commit/9c71dbf7e5149ca37e454d33f04fb81dc282a54c
thanks.


feat(lang): add French language

Issue : https://github.com/Bitnoise/react-scheduler/issues/99
Here is the result in French:

French has already been added and will be available with the next release.
Thank you for your contribution.


added a --location option to Curl in order to follow a link in case o…

…f permanent move of the index-url

This was a great idea, though I think with the update to the new location this shouldn't be necessary in the future. Please reopen this if you feel it's still useful. Thanks for the PR!


btcpayserver: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

The package builds and passes the nix-bitcoin VM test suite.
You can run the tests with this self-contained script.
@erikarvstedt

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115954 run on x86_64-linux 1

1 package built:

btcpayserver

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

btcpayserver:

warning: unused-argument
Unused argument: writeScript.
Near pkgs/applications/blockchains/btcpayserver/default.nix:2:39:
  |
2 |   dotnetPackages, dotnetCorePackages, writeScript, bash
  |                                       ^

warning: unused-argument
Unused argument: bash.
Near pkgs/applications/blockchains/btcpayserver/default.nix:2:52:
  |
2 |   dotnetPackages, dotnetCorePackages, writeScript, bash
  |                                                    ^

See #115954 (comment)

Fixed

@jonringer can we merge?

do you mind squashing the two commits? otherwise LGTM

do you mind squashing the two commits? otherwise LGTM

Squashed


Added cask for bordertool 2

I've added a cask for the BorderTool 2 save editor for Borderlands 2 authored by xvi, available here
It is important to note that this is not a sequel or a different version of the BorderTool cask I've submitted in a separate request.  This is an entirely different application.

Please remove the hyphen from the name, and add a comment.


Update getting started - Ubuntu style

Updates to Readme

Add some hints for non-mac users :)

Add info about forking project and adding upstream repo

Remove call to gem install rails which will download the wrong version of Rails given usage of 4.1.7.  The bundle install command should take care of getting Rails for the user because Rails is in the Gemfile

Add .ruby-version so rvm picks up the correct ruby version every time without user having to do rvm use 2.2.1 every time in the repo

Nice! Especially also the fork/upstream info - thanks!


Global DNS UI: page should not be shown unless on HA

Version: 2.2 master (1/22/19)
What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Have a single-node rancher install notice you can see Global DNS on the top nav bar even though this is only supported today with HA setup.

Result:
User can see page they should not be able too since we don't support global DNS on non-ha today.

@davidnuzik @sangeethah with the final design, Global DNS should be enabled only on the setups having a local cluster. That means it won't be disabled on HA if addLocal is passed as false on helm install.
@sangeethah feel free to close as a duplicate of https://github.com/rancher/rancher/issues/18603

Validation for this issue is tracked in https://github.com/rancher/rancher/issues/18603#issuecomment-471093906


generate automatic CHANGELOG.md file

We need to investigate what's the effort to create and generate a CHANGELOG.md automatically for every release

Will grab this)

Will grab this)

@zivl
So does the question for "CHANGELOG.md file VS releases github page" has already been resolved, or we could discuss that?
For now I mention that some known libraries are migrated to releases page only: https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md
Don't know is there an ability to support both approaches, will try to dig there.
Or we are ok with one of approaches, which one?)

@zivl
So does the question for "CHANGELOG.md file VS releases github page" has already been resolved, or we could discuss that?
For now I mention that some known libraries are migrated to releases page only: https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md
Don't know is there an ability to support both approaches, will try to dig there.
Or we are ok with one of approaches, which one?)

sure!
up until now, i was not using the tag and releases options of github.
I manually published it.
I've started something to make it automatic upon tag, as can be seen in travis.yml file, but I've never tagged...
i guess i got used to manually publishing

sure!
up until now, i was not using the tag and releases options of github.
I manually published it.
I've started something to make it automatic upon tag, as can be seen in travis.yml file, but I've never tagged...
i guess i got used to manually publishing


Wrong namespace reference to Event in RDF Guide table 3.7

In Table 3.7 in the DwC RDF Guide, there are two references to dcmitype:Event.  I think this text was written when there was still uncertainty about the fate of the DwC type vocabulary.  In the end, we dumped dcmitype:Event and went exclusively with dwc:Event.  So I think the namespaces on those references should be changed to dwc:Event.

Fixed in commit 4edd067d6c047f861255a7d511ab27d6aa118c0f.


Ruby On Rails Group Project

In this pull request, the following tasks were implemented:

Login page and registration page:
-built with Devise.
Food list:

display a list of food added by the logged-in user as in the wireframe (display also quantity of a given food).

lead to a form that allows users to add new food.

Recipes list:

display a list of recipes created by the logged-in user as in the wireframe.

lead to recipe details.

If the user owns the recipe, should allow the user to delete it.

Public recipe list:

display a list of all public recipes ordered by the newest as in the wireframe.
lead to recipe details.

Recipe details:

display a toggle button allowing a recipe to be made public or private.
If the recipe is public or the user owns the recipe, should display the recipe details as in the wireframe.
If the user is the owner of the recipe, should lead to the form that allows the user to add new food.

General shopping list view:

Show the list of food that is missing for all recipes and food that are not sufficient enough for the recipe for the logged-in user.
Count the total food items and the total price of the missing food.

Made sure there are no N+1 queries happening.

Created a navigation menu allowing users to open all the pages you created.

Add unit and integration tests

Thanks so much for the review @tufoinnkuo10


Allow setting a font size on IconButton

It would be wonderful to be able to change the size of an IconButton, right now, it seems you can only do so with the Button component.

The icon size follow iconButton size in the 0.2.0-preview.


lightbox and sunlamp validation

Hello,
I want to validate the model on lightbox and sunlamp images but you said "The testing is only supported for the synthetic validation set.". What does it mean? Is it just that I need to create the labels in CSV format on my own?
Many thanks!

Hi,
That was before lightbox and sunlamp test labels were released, so please disregard that statement. You can use the same method to perform testing on lightbox and sunlamp. Sorry for the confusion!
Jeff


doc: document python build scripts

We have a collection of python scripts that are part of our build
system.  This PR collects docstring comments added to these scripts into
a summary document.  Previous references to just the script name in
other documentation are updated to point to this build tool
documentation.
Some of the scripts needed an update to be processed (via include
directives) consistently.
Signed-off-by: David B. Kinder<EMAIL_ADDRESS>

@marc-hb https://builds.zephyrproject.org/zephyrproject-rtos/zephyr/16535/docs/guides/build_tools.html

@marc-hb https://builds.zephyrproject.org/zephyrproject-rtos/zephyr/16535/docs/guides/build_tools.html

Thanks! Now I can see. @nashif could this linking be automated and if yes is there already a ticket for it? If not I'll file it. If nothing else it'll be a place to share the format of the magic URLs.
So from a doc structure perspective,

the higher-level  (and very good) introductions are somewhat hidden under "API Reference » User Mode", while
these corresponding, relatively obscure scripts and low-level implementation details are being given higher visibility at  "User and Developer Guides » Build tools".

If I'm new to something, I'm going to read "Guides" before any "(API) reference". I may never read "Reference" section actually, rather just search them.

We need the documentation to be about the build process and what steps we take to generate the final binary, so there is a leading section that is missing here and probably some workflow diagram describing the build process.

Agreed, a bird's eye view of the build process and flow would be awesome. One of the reasons I started the #13805 "experiment" is because I missed that high-level view. However: 1. there's no such section about this yet AFAIK, 2. I'm still not sure it would be a better place for specific implementation details details like these scripts. Maybe sometimes but in this case I think having everything user mode in the "User Mode" section makes more sense. The number of "long links/jumps" crossing all that distance is IMHO a sign they should just be together.


Not clear how to set channel for messaging

There's value mentions of android_channel_id in some stackoverflow posts, but nothing in the docs or in this repo. How do you set the channel? The console has a field for it even though the API makes no mention of it.

NotificationMessagePayload type is defined as follows:
type NotificationMessagePayload = {
    tag?: string;
    body?: string;
    icon?: string;
    badge?: string;
    color?: string;
    sound?: string;
    title?: string;
    bodyLocKey?: string;
    bodyLocArgs?: string;
    clickAction?: string;
    titleLocKey?: string;
    titleLocArgs?: string;
    [key: string]: string | undefined;
  };

Since it allows arbitrary keys, I would expect that if you just add android_channel_id under notification, it will just work.

Can something be added to the docs? It's strange the web console has a field for this and nothing is mentioned in the docs for how to do it programmatically.

You can still use the legacy APIs for this. The new REST API doesn't support it as far as I can tell: https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#AndroidConfig
SDK's admin.messaging.send() API cannot support it until it's exposed in the REST interface.

hey guys, bringing this old thread back to live. it took me a few days to find out how to use firebase admin sdk with node.js and assign a channel ID to a notification. thanks for the post above I just added "android_channel_id" to my notification payload object, see below.
It works, but is it the correct way?
                        //prepare firebase cloud messaging push notification
                        var notification_message =  {                                                                                notification: {
                                        title: topic.toString(),                                                                                body: message.toString(),
                                        android_channel_id: config.mqtt_subscriptions[index].channelID
                                }
                        };

That looks correct for the legacy API.
Channel ID is also supported by the new (v1) API now: https://firebase.google.com/docs/reference/admin/node/admin.messaging.AndroidNotification#optional-channelid


[ACCOUNTING] Create Invoice

[x] Determine all side effects and add to this issue
[x] Migrate legacy code to new accounting service controller
[x] Identify all existing code that uses the legacy endpoint and create a follow up ticket to update the call sites to use the new endpoint
[x] Handle distinct types (Regular invoice, Party mode, Zap)

Side effects: This endpoint generates an invoice for a user who wants to send a LN payment to a piece of content. There are actually two separate endpoints for this: one for standard invoices POST /ln/generate-amp-invoice and one for zap requests GET /zap/create-request. They are mostly the same, both endpoints take a content id and an amount as arguments (also metadata as part of the LNURL payRequest flow in the case of the standard invoice). The zap request logic also stores a copy of the request in the db to later publish as part of the zap receipt once the invoice has been paid.
New implementation will use POST``/invoice/ and GET``/invoice/zap as replacements.

When creating the follow up [ACCOUNTING CLIENT] ticket for this, we need to include updates to the embed player, which calls generate-amp-invoice

Resolved in https://github.com/wavlake/catalog/pull/404 and https://github.com/wavlake/wavlake.com/pull/523


Gatineau, QC

Closes: https://github.com/openaddresses/openaddresses/pull/5346

Note for the order of addresses in conform,
"NOM_VOIE" : "Lacaune",
"LIEN_VOIE" : "de",
"TYPE_VOIE" : "Rue"
The street name here is "Rue de Lacaune", so the order should be TYPE, LIEN, NOM, ORIENTATION.
Not sure why it's failing, the log from data-pls suggests it's a compression thing, but it looks like Nick has already removed the compression?

The source file has a BOM (byte order marker and it looks like our GeoJSON pipeline doesn't properly remove it. We'll probably need to add some code to the downloader to work around it.

@iandees just a note, I've broken out the downloader here: https://github.com/openaddresses/batch-machine for the purposes of batch. Whoever takes a look we can back/forward port it to machine/batch-machine


Depth buffer precision and reverse-z

Just this moment, I wanna ask if our filament has the reverse-z buffering or logarithmic z buffering...

It does not. We'd love to add support for reverse Z but OpenGL ES 3.0 unfortunately prevents us from getting it to work on mobile (I don't recall if what we need was ever added to 3.1/3.2).


BUG - Add Maintenance behaviour is inconsistent when no vehicle added to the app

Describe the bug
When no vehicle has been added (or all vehicles have been deleted) the Add Maintenance view is available but is not fully functional as a vehicle is required to add a maintenance record.
As a consequence of this:

on the Add Maintenance screen the "Add" button is enabled as soon as a title has been added but does not commit the record and does not present any alert detailing why it can't.  Could leave the user hanging.
The Vehicle section of the form says "select vehicle" but there's no picker available.

To Reproduce
Steps to reproduce the behavior:

Use either a clean install or delete all vehicle entries
Go to the Dashboard
Click the "+" button to add a maintenance record
Add a title
At this point see that

the "Add" button is enabled
clicking "Add" has no obvious behaviour to the user, and give no indication of where to go next
the lack of a picker on the Vehicle entry

Expected behavior
Several possible behaviours (some app architecture-dependent):

clicking on the "+" gives an alert saying "add a vehicle" if none present rather than entering the Add Maintenance view
clicking on  the "+" loops the "Add Vehicle view in before the Maintenance view
clicking the "+" open the maintenance view, put a "no vehicle" entry in the picker, keeps the "Add" button disabled, and presents an alert explaining where to go

In all instances, and as a minimum, the "Add" button should not enable until all the mandatory fields have been completed.
Screenshots

Device Info (please complete the following information):

Device: Simulator
OS: 17.0
1.0

Additional Context
N/A

@darrengillman yes this is an issue! But I'm going to be fixing this before shipping the app, by adding an onboarding view, that has the user enter their vehicle info. So this won't be an issue. I'll leave it open, and assign myself to this issue for now

@mikaelacaron fair enough.  And I was going to volunteer to fix it for you :-)  Although will need to mod the maintenance view to cope with the user deleting their vehicles.
Do you still want us to offer to pick up issues, or would you rather just ship now?

If you could pick up #6 that would be great! (a person already did the work and the PR is closed, but there were some edits they never made in time, before Hacktoberfest ended)
Overall I didn't really expect many people to keep contributing after Hacktoberfest, and yeah at the moment I might just pause most of the issues until I ship the app, because I'll be making some big changes. See #260 for the list of things I'll be doing before shipping

@mikaelacaron apologies for dropping the ball on this.  A third party API our primary business app uses withdrew it services without notice or documentation, so it's been a manic couple of weeks building an alternative solution.  Fun though, in a type 2 way!

No worries! I'll be picking this up when I implement the onboarding. I'm using #260 to track all the tasks left before I ship the app

Fixed with #287


Add Ensemble wrapper i.e TTA, other Ensembling techniques.

Im thinking to add an ensembling wrapper for the ensembling of models .
i.e
from tinygrad import ensemble
# example 1
ensembled_model_object = ensemble(models=[efficientnet_model_object], type='tta', aug=['original','fliplr'] )
out = ensembled_model_object.forward(image)
# tta improves results by 2-3 MaP units.

# example 2
ensembled_model_object = ensemble(models=[efficientnet_model_object, other_model_obj], type='parallel_ensemble', aug=None )
# two models will be running in parallel processes may be using ray, and save time but this might have memory  constraints
# so if used type='ensemble', internally will build sequential graph.
out = ensembled_model_object.forward(image)

@geohot thoughts?

I'm not sure why this would need to be in the library. Even model isn't in the library (difference between tinygrad and pytorch)

Actually yeah, you're right!
Tinygrad shouldnt have this!


Support font size on the output window

We should probably use a Monaco editor for the output window anyway...
Requested at embo: https://twitter.com/janwilmans/status/972115489605541889

Why do you think we should switch the output to be a Monaco editor?

Closed by d20e6be

Available now on the site


Error: ProviderError: Gas required exceeds allowance or always failing transaction

My contract below is always failing when running zos create Collectibles --init initialize --args Collectible,cc,[0xB1Fe3d2FD237bF06496F61bCFdC032743B07A600],[0xB1Fe3d2FD237bF06496F61bCFdC032743B07A600] -n rinkeby. The error is ProviderError: gas required exceeds allowance or always failing transaction. The logic contract gets deployed fine, but when I use the create function, it will fail. Using a local environment, I do not have the same error.
import “zos-lib/contracts/Initializable.sol”;
import “openzeppelin-eth/contracts/token/ERC721/StandaloneERC721.sol”;

contract Collectibles is Initializable, StandaloneERC721 {

    function initialize(string name, string symbol, address[] minters, address[] pausers) initializer public {
        StandaloneERC721.initialize(name,symbol,minters,pausers);
    }
}

Any help is much appreciated!

Just to confirm you do have the proper 'ETH' on each network?

Hi Jeff, Thank you for responding! Yes I do:
https://rinkeby.etherscan.io/address/0x8FF7Cdb0063D5551B80a25c3AdC74B6D088EC1b0 = 3.5 ETH
https://ropsten.etherscan.io/address/0x6Dd675a950E39E0feB7d22a84AdD077A64aD3054 = 6.7 ETH

@jeffanthony Actually I am getting the error if I use made up Private Keys and Mnemoic's...

UPDATE: zos create Collectibles --network rinkeby works. However there is a warning that it recognizes the initialize function which needs to be done manually. Trying to figure that out now

Had the same issue, but with the zos update, solved it by adding --from "address_goes_here".
Funny thing is - it already knows the correct address, so if you type in the wrong one - it will give the correct one to you, saying that this is the address of current admin!
However, if you provide nothing - just fails with this meaningless:
ProviderError: gas required exceeds allowance or always failing transaction.

@dimonkov It seems that that error message is too generic. I solved the issue by changing the contract code in StandaloneERC721. renounce(this) was a "always failing transaction".

@patrikdevlin could you please elaborate on (1) if this issue is solved and (2) if so, what actually solved it?

@ajsantander Of course!

I solved the issue, but not sure if It has been reflected on ZeppelinOS' end. Description is below.

It seems that the issue (error message) can occur for many different things. As shown by @dimonkov. I can only speak for the issue that I was dealing with which stemmed from the StandaloneERC721 code.

`    // Initialize the minter and pauser roles, and renounce them
ERC721MetadataMintable.initialize(address(this));
renounceMinter();
ERC721Pausable.initialize(address(this));
renouncePauser();

When deploying locally on Ganache there is no error. However when deploying to Rinkeby and I believe mainNet this is the source of the problem.  renouncePauser() and renounceMinter() is attempting to renounce the wrong address which causes the transaction to always fail. Thus when you runzos create ...` it is always failing.
Let me know if you would like me to expand on this any further.
Best,
Pat

I see this has been fixed here: https://github.com/zeppelinos/zos/commit/57f7e3134085ae9cc399fae97c541cc7c9f55a97 but could we get a fix for this in 2.0.0? Perhaps 2.0.2?

@ConnorChristie Where do you see the fix in the commit you mentioned? It is solidity code that is causing the error.

@patrikdevlin The issue has something to do with the way estimate gas is being called for a contract method. That commit I pointed out changes the estimate gas method to use the one on the contract itself

Hey @ConnorChristie, @patrikdevlin sorry for the late response! It seems that this issue was indeed related to the way in which gas was being estimated when calling a contract method. As Connor said, we fixed this in https://github.com/zeppelinos/zos/commit/57f7e3134085ae9cc399fae97c541cc7c9f55a97.
I'm closing this issue for now, but please do not hesitate on commenting here if you face this problem again.


Import file with same folder name ('./module' instead of './module/module')

Do you want to request a feature or report a bug?
Feature.

What is the current behavior?
If I'm not wrong, currently, using import module from './module', Webpack resolves it with this priority:

Checks if the file ./module.js exists.
If not, checks if ./module/index.js exists.

However, Webpack completely ignores modules with the same name of the directory, i.e. ./module/module.js will always be ignored.
In fact, in this case you have to manually repeat the word "module":
import module from './module/module'.

What is the expected behavior?
Using import module from './module', Webpack could resolve it with this priority:

Checks if the file ./module.js exists.
If not, checks if ./module/index.js exists.
If not, checks if ./module/module.js exists.

Adding it as the "last" check, it won't break current projects, but it will only add a possibility.
Is this possible for Webpack to implement it? Would it be a good thing?
What is motivation or use case for changing the behavior?
My question/issue was the same as this: https://stackoverflow.com/questions/42870801/webpack-import-from-folder-folder-js-instead-of-folder-index-js. I saw many people using this folder/file structure, avoiding the index.js, so I thought it would be great to implement this.
I was just wondering if Webpack in this case, instead of giving an error, would check for the file with the same folder name, without installing any plugin (like https://www.npmjs.com/package/directory-named-webpack-plugin) or doing any "tricky" thing, like creating package.json to each folder, as suggested in the post I linked above.
What do you think? Am I missing something, or thinking wrongly?
Where appropriate, if you think it would be good, I'd like to contribute if possible! 🙂
(I'm currently using Webpack v4.28.3)

Is this possible for Webpack to implement it? Would it be a good thing?

Yes, possible, as there is already a plugin doing so: https://www.npmjs.com/package/directory-named-webpack-plugin
But there is a spec for the resolving logic (inferred from node.js) so the default should not do this, as it will create incompatibility in the ecosystem.

@sokra Thanks for the immediate response!
Yes, I already mentioned that plugin, in fact I was talking about a “by default” feature.
However, I understood, I assumed it.
Thanks!


Interface ordering for interfaces that have no prefix

Issue type
[ ] Feature request
[x] Bug report
[ ] Documentation

Environment

Python version:  3.5.1
NetBox version:  2.2.2

Description
We use Brocade ICX switches, based on FastIron, and the interface names do no have a prefix. Unless you show details of a specific interface using show interfaces ethernet 1/1/1 the interfaces will always be listed based on STACKID/SLOT/PORT and in order (e.g. 1/1/1, 1/1/2, etc..).
In Netbox when I add all these interfaces to a device or device type, I see interfaces which are listed like so:
1/1/1
1/1/10
1/1/11
1/1/12
1/1/13
1/1/14
1/1/15
1/1/16
1/1/17
1/1/18
1/1/19
1/1/2
1/1/20
1/1/21
1/1/22
and so on ... (please see screenshot in the link below)
https://www.dropbox.com/s/weq5bxnlyrrv5em/Screenshot 2017-10-26 07.20.43.png?dl=0
I would prefer to have them show up in Netbox ordered in sequence (e.g. 1/1/1, 1/1/2 .....1/2/1, 1/2/2, etc...), without having to prefix them with (e.g. "ge-"). In FastIron you don't show inteface using a prefix so it would great if I could list them in Netbox the same way.
Thanks for your help.

Hi,
Same interface naming standard on Nokia platforms.
I don't have access to Netbox < 2.2 currently, but I do believe that the ordering for these kind of interface names changed with the works done in #1523.

Is it normal that the Interface Ordering "Name (alphabetically)" is not ordering by Name in the Device View? It's actual ordering by the Chars from the Interfacename until the first Number.
querysets.py
TYPE_RE = r"SUBSTRING({} FROM '^([^0-9]+)')"
The name "ge-1 b" results in _type  "ge-"


Bug: empty taxonomicRankName when manually specified

When filling hierarchy for "Robina pseudoacacia" using ITIS, a virtually-empty return is presented to the user. Manually selecting the "Species" Taxon Rank, then Save and Continue, results in an empty taxonomicRankName element in the downloaded EML.

Running into this issue again, but now the name of the saved organism is not showing up in the web-form displayed list of Taxonomic Coverage unless I back out, "Add Taxonomic Coverage", enter the "Taxon Scientific Name", select "Taxon Rank", and THEN "Save and Continue".
Attempting to "Fill Hierarchy" and then when it fails to resolve to the "Taxonomic Authority", manually specifying the "Taxon Rank", creates some state that prevents "Save and Continue" from adding the taxon to the list.

Fixed in Release 2021.08.05.


URL highlighter stops at % character

In the following text, the URL highlighter stops at the '%' character:
Visit https://developer.mozilla.org/en-US/docs/Web/CSS/%3A%3Afirst-line for more information. This message is displayed up to 10 times.
It should allow this character in URLs because it is used for URL encoding.

Fixed text highlighter.


fixes #230

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks! Can you run the formatter so CI becomes green?


Caching of provisioned tools

The description of your action suggests that the provisioned tool will be cached.
But this is not the case, it will be re-downloaded on every workflow run.
Unfortunately the name and description of @actions/tool-cache is pretty misleading.
Just using it does not put anything to the GHA cache.
Only to the tool-cache directory or taking it from there if it is available,
so you can switch back and forth between different version, or have some tools already present in the hosted runners or also custom tools if you use custom runners.
Only between steps of the same workflow this "cache" for a newly downloaded tool could work.
Is this the intended behavior of your action?
If not, this is bug report.
If yes, this is a feature request. :-)
To put the downloaded stuff to the GHA cache, you need to additionally use @actions/cache.
You can an example algorithm for that in my setup-wsl action, it is implemented in Kotlin though: https://github.com/Vampire/setup-wsl/blob/master/src/main/kotlin/net/kautler/github/action/setup_wsl/SetupWsl.kt
Basically I have a use-cache input that you can set to true or false.
If it is not set isFeatureAvailable of @actions/cache is used to determine and if true it is also used to verify the cache is available.
And then if the cache should be used I use restoreCache and saveCache accordingly to restore a cache or save it if there was no cached version available.

The description of your action suggests that the provisioned tool will be cached

Whoops, I've fixed this. I was indeed thrown off by tool-cache when I first set up this repo, and didn't update the description after actually implementing and understanding the situation.

Is this the intended behavior of your action?

Yes. My belief is that, given the primary use-case is downloading a binary, there would be little time saved, if any, by downloading and extracting that binary instead.
So I'm unlikely to implement this myself at this time. I would accept a PR that implements, if it also linked to some example workflow runs that showed the caching indeed saves time. Maybe you have some workflows that use setup-wsl where we can compare cache hit-vs-miss runs to see if it's worth the complexity to implement.

Well, it's not only about performance, also about reliability.
I've run a certain workflow multiple times in parallel to reproduce a failure situation.
At that time I just used wget to download the tool.
This resulted in some of the tries fail due to download error.
Maybe it was an API ban for triggering the download too often in two little time, or it was a server outage, I don't know.
That was when I searched for an action that does the downloading and also caches the downloaded file / unpacked tool.
If your action wouldn't have stated it does caching, I probably wouldn't have tried it after all.
It's not too likely I'll contribute the implementation.
Initially I've written setup-wsl in typescript.
It was a real PITA like every time when I have to touch JS or TS.
So I rewrote it in Kotlin/JS which then was real fun and working much better. :-)

Well, the work-around is easy enough, adding a actions/cache action in front. :-)
I just fear that I can then also switch back to using wget, as for this occasion I think your action then does not add any value.
But good to have the improvements and typings for the next time I need something like this. :-)


fix: update hooks for aio-cli-plugin-asset-compute@v4

Description
The plugin version at v4, uses oclif@v2, which had this quirk we relied upon, where we didn't need to specify the command topic beforehand.
Depends on:

https://github.com/adobe/generator-add-action-asset-compute/pull/3
https://github.com/adobe/aio-cli-plugin-asset-compute/pull/95

How Has This Been Tested?
Pending.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

@shazron Are you familiar with the adobe-asset-compute executable referenced in the generator? Should this be aio?

@MichaelGoberling that should be correct, that is the bin name in node_modules: https://github.com/adobe/aio-cli-plugin-asset-compute/blob/fd906b3c7d7348ab78fa0226ac16df1ab0f20cc1/package.json#L64 (it is installed as a devDep: https://github.com/adobe/generator-add-action-asset-compute/blob/61b84edf14f87275f18522a037b9227e1d1f8ae5/index.js#L38)


Transport stream H264 video track not playable due to keyframes not being detected

Version
Media3 main branch
More version details
Video track does not seem to be playable. Upon further investigation, it seems to be related to key frames.
Specifically the H264Reader never seems to detect a keyframe, and for that reason no frames are actually submitted to the decoder for decoding.
Looking at the H264Reader#setSampleIsKeyframe function call I can see that plenty of NAL_UNIT_TYPE_NON_IDR frames seem to be read; however both allowNonIdrKeyframes and randomAccessIndicator flags seem to always be false resulting in none of the frames being marked as key frame.
I've experimented a bit, and removed the logic which waits for a keyframe and the video plays just fine with seemingly no artifacts.
Devices that reproduce the issue
Samsung S23
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps

Play attached media

Expected result
Media plays with video and audio
Actual result
Only audio plays, even though video track is detected
Media
https://hospitality-dev.codemeup.net/images/spiric-test/<IP_ADDRESS>_1510.ts
Bug Report

[x] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

however both allowNonIdrKeyframes and randomAccessIndicator flags seem to always be false resulting in none of the frames being marked as key frame.

You can set FLAG_ALLOW_NON_IDR_KEYFRAMES yourself: https://developer.android.com/media/media3/exoplayer/troubleshooting#why-do-some-mpeg-ts-files-fail-to-play


Add RTCDataChannel interface

TypeScript#23300
webrtc#dom-rtcprioritytype

@saschanaz can you please review as well.

@mhegazy I've checked widl is not stable for now, and generated type is not correct. I decided to define missing type in addedTypes.json.

We are trying to move away from adding types directly, and instead use the widl. why is not that stable? can we add the widl, then update specific declarations/properties?

@saschanaz can you review the latest version of the change?

The code has a bug about partial dictionaries, I will open a separate PR for this.

?

#428 is merged, please rebuild. Thanks! 👍

thanks @saschanaz for the help!


Fix dependencies and bad merge

2 versions of WIL were referenced across the projects. Updated to consistently reference the newer one.
2 versions of C++/WinRT were referenced across the projects. Updated to consistently reference the newer one.
Removed test\ToastNotificationsTests project remnant (no such project there anymore; leftover from bad merge?)
LRPTests was a VS2019 project (PlatformToolset=v142); updated to VS2022 (=v143)
LRPTests and Test_DeploymentManagerAutoInitialize\CPP* projects didn't fully declare build order dependencies so on a fast enough machine and Rebuild All you could get out-of-order build and thus build errors; fixed.

/azp run

/azp run


CircularMenuItem onTap not working

I tried out the  package with image selection app.
Both of these approaches were used,
onTap: () => getImage(ImageSource.gallery)
onTap (){getImage(ImageSource.camera)}
but none trigger getImage method.

Hi @ebena107
Thanks for opening this issue,
Circular menu seems to work fine, maybe the issue  is related to something else.
Please provide more info about your widget tree so I can have a closer look at what's happening there.

@hasan-hm1 Thank you for the good work you are doing. The package is beautiful.
However, what I found out is that the problem is with Transform widget, as stated here https://github.com/flutter/flutter/issues/27587 .It doesn't transfer hit area with each menu item, thereby making it impossible to accept onTap or callback.
The hack or work around may be to wrap Inkwell widgets with Container widget that will cover expected hit area.

Hi @ebena107
Please notice that Circular Menu is designed to be the direct child of a Scaffold
Scaffold(body: CircularMenu()
and the actual page content be assigned to the property backgroundWidget
Scaffold(body: CircularMenu( backgroundWidget: PageContent() , ), )
to make sure that the parent is big enough to transfer the tappable area so it can accept a callback.
However, you can use any widget not only a Scaffold but you always have to make sure that the parent is big enough.


How to controller Tab actions

user is click any tab in . viuew pager ,how   to handle that actionin

i got it


Fix bug where announce_identity could be undefined

Let me preface this by saying that I have no idea if this patch is correct or not and if this is really a bug or I'm doing something wrong ^_^.
I'm trying out the Announce example and I noticed that when I set aspect_filter to None, the callback would error out with:
[2023-01-26 19:50:58] [Error] Error while processing external announce callback.
[2023-01-26 19:50:58] [Error] The contained exception was: local variable 'announce_identity' referenced before assignment

Looking at the codebase, it makes sense since we never assigned the announce_identity variable. We're only assigning it if aspect_filter is not None, but I think we should be assigning it regardless of aspect_filter's value.
if this isn't a bug, is there something else I'm missing?

Thanks for reporting this and submitting a PR!
There's definitely a bug here, since that error message should not occurr, and the reported error message and behaviour is not very helpful.
I'll need to look into this a bit more closely first. I'm not even sure that the behaviour without an aspect filter makes any sense at all actually ;)
So let me just have a look and see what's going on!

All good, merging this


Update Azure.md

Removing virtual machine PowerShell module related to ASM
PR Summary

PR Checklist

[ ] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[ ] Summary: This PR's summary describes the scope and intent of the change.
[ ] Contributor's Guide: I have read the contributors guide.
[ ] Style: This PR adheres to the style guide.

It seems that this is a very old document and no one may use it anymore. Why is it being modified? Did a user report an issue?

@Pallu1809, The documentation for the Azure PowerShell Service Management module will retire when the service retires. For information about the retirement of Azure Service Manager, see Azure Service Manager retirement.

@Pallu1809 thanks for your contribution.
While classic VMs have retired since Sept 2023, associated commands are still present in the Azure module. We should keep this information in our doc for accuracy with what is shipped. As mentioned by @mikefrobbins we will retire the documentation once the service has retired.


check if one of the players can still make a move/place a block on the gameboard

https://github.com/sopra-fs23-group-40/Server/commit/b7bc47f0fb73538fd083a817235aa310bcc35617


Paperdoll editing support

Some of the sub-features for this issue depend on Issue #53 (Item inventory support).
Support editing of player's paperdoll. This involves

Open paperdoll via "Paperdoll" button in inventory
Display of equipped items in paperdoll dialog
Drag+drop items from inventory to paperdoll dialog
Double-click to equip items in inventory
Updating character's avatar when items are equipped

High level ToDo list for above items:

Convert old paperdoll dialog into new coding paradigm
Implementing handlers for paperdoll and item equip packets
Handling double-click to equip in item inventory
Adding drag+drop onto paperdoll dialog
Removing old code related to paperdoll dialog and item equip/paperdoll packets
Making sure paperdoll avatar packets are properly handled

See pull request #122.


feat(just): Created 70-nix.just with nix installation, uninstallation, and configuration

there were quite a bit of nix stuff added possibly with more nix stuff added

Not every image has that imageinfo file, maybe check for the presence of mutter instead.

Not every image has that imageinfo file, maybe check for the presence of mutter instead.

can you submit a review for that so I can just press a button for it to be applied. I have no idea how to do it.

Not every image has that imageinfo file, maybe check for the presence of mutter instead.

I made it hidden for now. Can I get this merged pls?


merge from arlac77/template-arlac77-github,arlac77/template-esm-only

package.json

chore(package): add src/worker.mjs (exports..)

Coverage remained the same at 95.161% when pulling 09175f01e8fb597d0f1c4cbabd9d8810783fb857 on npm-template-sync/arlac77/template-arlac77-github,arlac77/template-esm-only into ce3b016e39d481b18e81bae698ad461af89f689c on master.

:tada: This PR is included in version 2.1.17 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add delayed queue by Dead-Letter-Exchange

Inspired by this article i tried to do it in nameko
https://medium.com/@dotbox/delayed-requeuing-with-rabbitmq-dcbdf0026bf0

Theres a nameko retry package that has retry functionality. I am not sure if its exactly the same implementation though


ITERATOR_DEBUG_LEVEL madness

On Windows basisu.h does #define ITERATOR_DEBUG_LEVEL 1 when compiling for debug. Since VC++'s default level is 2 this leads to a large number of errors from the compiler about an ITERATOR_DEBUG_LEVEL mismatch when you try to use basisu alongside other code.
The comment where this is set says you need to disable iterator debugging or the encoder is unusable. What exactly are the problems it causes? I have defined BASISU_NO_ITERATOR_DEBUG_LEVEL  to prevent changing the level and in my very limited experiments the encoder seems to be working okay.

If iterator debugging is enabled, the encoder is just too slow in debug. If you build with BASISU_NO_ITERATOR_DEBUG_LEVEL, this problem should go away.
Considering you're not having problems, I'll make this the default.

For now, we're going to leave the BASISU_NO_ITERATOR_DEBUG_LEVEL macro in, which the user can use.


MM-36593 RHS performance improvements

There's two big changes here:

The ThreadViewer uses makeGetPostsForThread to get its posts, but due to how we store posts, that returns a new array any time a new post is received, loaded, reacted to, etc. Since posts are "immutable", we can use createIdsSelector here which shallowly compares the result against the previous one and prevents a new array from being returned if it contains exactly the same posts.
The SearchResults component constructs a map of channels for use when rendering its children, but it didn't memoize that map, so it would cause constant re-rendering. That's fixed by making the children of SearchResults responsible for getting their own channels from the store.

Ticket Link
https://mattermost.atlassian.net/browse/MM-36593
Related Pull Requests
https://github.com/mattermost/mattermost-webapp/pull/8291
https://github.com/mattermost/mattermost-webapp/pull/8293
Release Note
Minor improvements to performance of posts in the RHS

Skipping QA since there's nothing really to test


Fix fortio Docker image not building

The fortio Docker image, used in some of our perf tests, was not working anymore when built from scratch (it currently works in our repo because we have cached images, but it will fail next time we try to build it).
Logs show failures:
fortio: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by fortio)
fortio: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by fortio)

The reason seems to be that:

Fortio is built with CGo enabled
The builder image was golang:1.20 which recently switched to be based on Debian 12 Bookworm (released just a few days ago)
The runtime image was debian:buster-slim (Debian 10), which uses a different version of libc. That causes fortio to fail to start

It seems that Go doesn't publish Docker images based on Debian 10 Buster anymore. So I've updated all images (builder and runtime) to be based on Debian 11 Bullseye.

/ok-to-perf service_invocation_http


Algorithm Problem

Hi, sorry to bother you again! When I use the lstm_rl algorithm, the navigation paths show oscillation and freezing behavior, why is this? Could you give me some suggestions?

hi @2529342549 these networks are trained end-to-end and it's hard to interpret individual policy's behavior. Although I don't really know, this behavior could actually be indicating what could be done for improvement :)

Hi, sorry to bother you again!
The hidden state of this part of the predict in lstm-rl is assigned zero each time, not the hidden state in the previous state. What is the role of LSTM in this case?

@2529342549 I was not aware of that at all. Could be a bug. Have you debugged it?


ERROR

ERROR: rasa-core 0.14.5 has requirement rasa-core-sdk~=0.14, but you'll have rasa-core-sdk 0.13.1 which is incompatible.
I have installed python 3.5
Tried changing requirement with the latest version of rasa-core
Also having   ERROR: Failed building wheel for cytoolz this as well

Thanks for raising this issue, @wochinge will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

@HarshitaSahai rasa-core was deprecated about a year ago. I recommend migrating to the rasa package which unifies rasa-core and rasa-nlu and makes a lot of things way easier.


[BUG] url re-direction after login does not work

Describe the bug
A qualified / saved URL for a plugin or visualization etc. after login fails to redirect the user, instead he user is sent to the home page
To Reproduce
Steps to reproduce the behavior:

open a saved url from new browser session
post login, instead of the url resource; the user is sent to the home

@anirudha can you share what the url looks like when it is on login screen?

@anirudha We just pushed fix around url redirection, there is a high likelyhood that this issue was resolved.  When the 2.0.0 release is available could you double check your scenario?
I'll update this issue when we have a docker image that contains this fix

@anirudha RC image is available, see https://github.com/opensearch-project/opensearch-build/issues/1624#issuecomment-1105736225
We will close this issue assuming the problem has been resolved.

@peternied I have this issue with the 2.0.0 release. Authentication via OpenID, hash got lost after login.

@peternied based on @ibrambe this still seems to be an issue with the 2.0.0 release. Also, will the fix for re-direct be backported to a 1.x or has been backported already?

Indeed, this is not fixed yet.
#831 + #1001 are related to this same problem.

I'm guessing, instead of going directly to the basepath, you should go to /app/home#/.
In the AuthenticationType implementations, nexturl is only assembled if isPageRequest is true (path contains /app/ or /goto/).

@peternied @davidlago Can we open this ticket back up and see what we can do to resolve? Or should we track the new here: https://github.com/opensearch-project/security-dashboards-plugin/issues/831?

Is this still happening after 2.2? it looks like it did go out in that version https://github.com/opensearch-project/security-dashboards-plugin/pull/1054

I'm guessing, instead of going directly to the basepath, you should go to /app/home#/.
In the AuthenticationType implementations, nexturl is only assembled if isPageRequest is true (path contains /app/ or /goto/).

I'm also experiencing behavior like this. Except I'm not even able to log in if the login url does not contain /app/home. We're currently upgrading from 1.2.3 to 2.4 and OIDC was working correctly in 1.2.3. There are some other changes with our config as well though, like using https instead of http on port 9200.

@Martin-Kemp There was a change included in 2.5.0 that resolved an issue with OIDC redirect.
Link to PR: https://github.com/opensearch-project/security-dashboards-plugin/pull/1282
Link to original issue: https://github.com/opensearch-project/security-dashboards-plugin/issues/1098
Does this fix resolve the issue you are facing?

Thanks for the quick reply @cwperks . That PR looks very promising, I'll test it and report back.

@cwperks I can confirm this works in 2.5. Thanks!

@Martin-Kemp Thank you for confirming! :)

This looks again broken in 2.13 and OIDC (Keycloak).
I can reproduce it with:

Navigate to any dashboards and save the url
Log out
Paste the url in the browser
After login, instead of the dashboard indicated by the url, the user is sent to the dashboards home.

Following the indication found in this discussion , I have tried to use the "short URL" from the Share->Permalink button, and it works indeed.
So while there is a workaround, the actual expected behavior appears to be broken.

@Rockhard80 Are you using a basePath? There is a known issue with basePaths in 2.13 that is planned to be resolved in 2.15: https://github.com/opensearch-project/security-dashboards-plugin/pull/1899

thx  @cwperks , but I'm not using basePath.
I have only the base_redirect_url in place, which points to the server root URL (i.e. https://myOpenSearch.my.test.com).
Besides that, the following ones are commented out (i.e. default values):
#server.basePath: ""
server.name: "your-hostname"
#server.rewriteBasePath: false


CSE Integrations Index

Made changes as per the Open Source Docs Migration Plan.
Purpose of this pull request
This pull request (PR) to edit the CSE Integrations Index page.
Issue number:

Select the type of change:

[x] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

Looks good, @Melvin-CnC. Approved.

Thank you, John!


Toolkit Not Embedding Install Files

I recently discovered this tool as I work from an Office with extremely slow internet so downloading and creating a MSI install file to distribute office products in my environment is a great tool.
Unfortunately when I am using the tool and I try to create an .msi file and embed the office files... I always end up with either a 2mb or 4mb install file.
I'm not sure if I'm doing something wrong but I hope this is a tool that is continuing development.
EDIT
So after doing A LOT of reading through the issues section it became known that it is by design that it does this, but what is NOT said is that when it embeds the files it actually doesn't and you will end up with two files.
File 1 = .MSI or .EXE
File 2 = Folder called "Office"
I assume the .MSI or .EXE is linked to install from this folder and will be testing shortly.

the Tooklike USED to embed everything into a single file. single MSI is what I've told our customers to use, and it appears that now it is not working as originally designed

I'm experiencing the same issue, the result of using the option to embed the files is not working anymore

I created an MSI with my the files embedded with no issues, took a long time but it worked. Only issue was I had more software than I needed and also wanted to change the auto activate to no. Now I cannot get it work no matter what I try, every time it fails with a time out or

I have deleted the program, deleted my download files and restarted, still no go

This is the other error I get

I can create an msi if I don't embed anything but the product will not activate no matter what I try, it shows my account but once I logged out it will never let me log back in

Having the same problems


Cards tab is hidden

The dorako UI (at least in dark mode) seems to hide the card tab.

Which version are you using? This issue should have been fixed as of 1.7.0

You are so right. One should update to the newest version before making a bug report

I'd rather have a bug report about something I've already fixed, than be missing a bug report about an issue I've never heard of!


ETCD with authentication: Granting permission to create Snapshot?

In my setup, etcd runs with enabled authentication and I need to automatically create snapshots.
Is it required that my backup-user has to be member of the root-group?
Or is it possible to grant snapshot-rights to a specific user?

/cc @mitake

@ChrisCavegn yes, your user for backup purpose needs to have root role.

@mitake Thank you for your clarification


Messaging error

https://github.com/fullstackreact/FirestackApp/blob/master/app/views/Messaging/Demos/Setup.js
TODO:

Any update on the fix for this error? At the moment can't figure out a work around and due to xCode failing the build, I can't run app on my iPhone device. Works with failed build in simulator interestingly.

I haven't had a chance to look at it yet. If anyone else has a chance to check it out, lmk.


Fix onPress handler mapping on web elements

Summary
So onPress handlers are not working on web elements like <Path />. I've noticed that because I am creating a graph in react-native-svg that works on all platforms and I needed the onPress functionality on a Path element. I've searched for some issues and saw that others are suffering the same problem:

608
599
#1078

I think that this problems are related to this line that validates if the prop name is a valid prop for touchables on the web so what I did (to be as simple as possible) is to map the onPress handler to onClick handler on the web. Only impacts the web implementation.
obs: I don't actually know if the current behaviour is the desired one and if this is
actually a problem that should be fixed, or we won't have touchables events on path
elements.

Test Plan
What's required for testing (prerequisites)?
No prerequisites.
What are the steps to reproduce (after prerequisites)?
Draw a simple <Path /> element and add some onPress handler on the web.
Compatibility

OS
Implemented

Web
✅

Android
N/A

IOS
N/A

Checklist

[x] I have tested this on a device and a simulator
[x] I added the documentation in README.md (N/A)
[x] I mentioned this change in CHANGELOG.md
[x] I updated the typed files (TS and Flow)(N/A)
[x] I added a sample use of the API in the example project (example/App.js) (N/A)

Great, thanks for this. You can remove the note from the changelog, it's created automatically, I should update the pr template not to include it in instructions. Additionally, could you check that there's no onClick property from before? In case someone has different event handlers for web and native, then it would be better not to override the existing web handler.

For sure, I made the changes you requested. Should we try to map other web events? onPressIn and onPressOut like in the docs? I mean we could possibly map them to other web events(onTouchEnd, onTouchStart), but maybe we should discuss them idk...

Looks good for now, can make another pr if more handlers are needed. Thanks!

:tada: This PR is included in version 9.13.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

View has onLayout, but it looks like SVG components do not? Where should I look for adding that support?


Ark support for Swift backend protocol

Describe the solution you'd like
Can Ark use restic to talk to Swift backend like the ones provided with Openstack? If not what would be required to get it working?
Anything else you would like to add:
restic can talk to Swift repos, but at first glance there doesn't appear to be anyway to get Ark to use them. It seems to like to talk S3.

Hi @NeilW,
I think Ark's restic support could back up to Swift if an S3 API layer was used. Right now, our Restic support uses the credentials for providers like S3 (and compatibility layers), GCP, and Azure inserted via the restic DaemonSet. See https://github.com/heptio/ark/blob/master/examples/aws/20-restic-daemonset.yaml, for example.
To use Swift natively, I think if there was a DaemonSet manifest that specified the OpenStack environment variables needed as described at  https://restic.readthedocs.io/en/latest/030_preparing_a_new_repo.html#openstack-swift, it should work, but I don't know know for sure.
I do know that backup manifests won't be sent to Swift without a Swift plugin or an S3 compatibility layer in front. We've had community interest in writing a Swift plugin, but I don't believe it's been published yet. See #119 and #528.

Hi, any idea if a plugin targeting swift has been created by the community in the end ?

https://github.com/cisco-sso/velero-plugin-openstack

This openstack plugin should probably referenced on the support matrix page.
@nrb what do you think ?

@drekle Is the Cisco OpenStack plugin still supported by your team?

Thanks for this request. We are not currently prioritizing this item within our roadmap, and as such will be closing out the issue. Please feel free to reach out as needed in this issue or a new one.


ENH: Optimise CLI Usage of ctree

Summary by Sourcery
Enhancements:

Refactor the dvs_par_ctree class to use a mixin for shared functionality, improving code modularity and reusability.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

44 of 59 (74.58%)  changed or added relevant lines in 3 files are covered.
16 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-2.0%) to 89.932%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/diverse_seq/cli.py
3
4
75.0%

src/diverse_seq/cluster.py
40
43
93.02%

src/diverse_seq/distance.py
1
12
8.33%

Files with Coverage Reduction
New Missed Lines
%

src/diverse_seq/data_store.py
2
87.82%

src/diverse_seq/distance.py
14
75.51%

Totals

Change from base Build<PHONE_NUMBER>3:
-2.0%

Covered Lines:
1188

Relevant Lines:
1321

💛  - Coveralls


#1028 support for WebP

I'd love to review the change and report back to here as to whether it fixed the issue or not, but I simply don't know how. What I mean to say is I am using FROM amazeeio/php:7.2-cli-drupal in my dockerfile but the change you have made is against the base image higher up the stack (obviously expected).
How would I test it and am I even required too? Happy to help out if I can.


Js docker machine env fix

@thieman @paetling  I think the default should be to pass the current environment to the subprocess, I'm not sure why we're not already doing that
Also for reasons I haven't investigated, docker-machine env now wants the --shell flag passed to it
Fixes #611

+testonce

:ghost: :cow: conditional on tests

I believe the test failure will be fixed after a rebase


Make ExpandableStickyListHeadersAdapter public

https://github.com/emilsjolander/StickyListHeaders/blob/master/library/src/se/emilsjolander/stickylistheaders/ExpandableStickyListHeadersAdapter.java
Can't really figure out why it's not.

+1. It is not even in the documentation.


Multi version setup from docs is not working

I tried to create a multi version setup according to the docs, and blog posts on angulararchitects. However, I keep running into the same issue NG0203. I created a reproduction repo here https://github.com/mte-bad/ng-module-federation-example.

@manfredsteyer any updates on this?

Hi,
for this to work, you need to wrap your micro frontends into web components.


"Cache is found" if the signature is incorrect

The old directory cache code in travis-build would calculate an incorrect signature for non-us-east-1 buckets. When the URL was handed to casher, casher still said that it could find and download the cache, and that it could upload the cache, even though this never happened (when looking at the logs I saw a 'signature error' from S3).

Closing, as it's become stale.


dispose the ShaderWarmUp picture/image

Disposes of native resources created by ShaderWarmUp.execute.
Does this by adding some new debug instrumentation to that method so we can capture its internals for assertions in a test.
Previously attempted here: https://github.com/flutter/flutter/pull/84669
I thought I'd have to write a benchmark for this but .. I do not.

@Piinks - any idea about the failure here? I can't reproduce it locally and it's only happening on Cirrus... Seems unrelated to this change.

I'm pulling in master and merging it just in case I had bad luck on my commit branch point...

Ok, I'll keep an eye on it. :)

Run passed after merging to master.


Error 103 CTR: Firm Vers could not be retrieved.

After enabling the robot, I get "Error 103 CTR: Firm Vers could not be retrieved." I have updated all the firmware to the newest version, could this be an issue with gradlerio not supporting Phoenix <IP_ADDRESS>?

I hadn't upgraded gradlerio to work with the newest version of phoenix, closing this now.


Missing icons

Hi,
Thanks for this great plugin.
Can you please tell me what font package I need to install to see the icons.
The icons do not render properly in my terminal. I'm using KDE-Konsole.

I missed the mention about fonts in the configuration section. I'll try installing codicons and see if my issue gets resolved.

Patched the fonts as mentioned, and it's all OK now. Closing this.


NotImplementedError: Cannot copy out of meta tensor; no data!

the whisper model can not be loaded. why?
if use whisper out side of project, it's normal, so weired.

I'll close it for now, please feel free to re-open.


Update package.json

Allow to get loaded by steal as lib/ results into lib/lib -> lib/lib/index
Summary
(If you have not already please refer to the contributing guideline as described
here)

[ ] Tell us about the problem your pull request is solving.
[ ] Are there any open issues that are related to this?
[ ] Is this PR dependent on PRs in other repos?

If so, please mention them to keep the conversations linked together.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.
If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.
Thanks for contributing to Feathers! :heart:

Thank you but this package should not be used on the client.
The same change for https://github.com/feathersjs/socketio-client, https://github.com/feathersjs/primus-client and https://github.com/feathersjs/rest-client would be great though.

@daffl hmm that makes sense :)


Fix WASM vs. WASI options

I went through all the places where we mention WASI and WASM, and tried to make sense of which places need which options. See also https://github.com/rust-lang/cc-rs/issues/1126#issuecomment-2460394021. Still with the caveat that I have no idea if any of what I'm doing here is correct.
The effect to the options for wasm32-unknown-unknown is that we no longer pass -fPIC, and that we now pass -fno-exceptions.
Fixes https://github.com/rust-lang/cc-rs/issues/1126.
Fixes https://github.com/rust-lang/cc-rs/issues/1275.

Yeah, can confirm this fixes the compilation compared to latest released cc version.