Update repo to docs / issues for migration

See https://github.com/GoogleCloudPlatform/google-cloud-intellij/tree/migrate-repo to view the new structure.
Migrating this repo to be docs + issue tracking

I think we need to keep kubernetes/README as part of the docs?

oof. good catch. added back


Version 0.5 crashes on load

Whether it's opened by tapping the home screen icon or using the "bowser://" URL scheme, the app crashes before finishing initializing.

What device are you using? It seems to work fine on my iPhone 6 Plus

Works on my iPhone 5S as well FWIW.
On Thu, May 21, 2015 at 2:54 PM, Robert Swain<EMAIL_ADDRESS>wrote:

What device are you using? It seems to work fine on my iPhone 6 Plus
—
Reply to this email directly or view it on GitHub
https://github.com/EricssonResearch/bowser/issues/45#issuecomment-104260621
.

I have the same experience on iPad with iOS 8.1.1

@mostafar - which iPad?
My suspicion is that older devices struggle to process the language bindings resource-wise. We had added pre-generated language bindings to the app bundle I thought, which should have sped up first start and avoided such problems.

iPad (first gen), now after some tries I think it crashes less than a second after initialization is finished, I can see the url in the box for one second.

I've noticed that if I type an url (which should redirect to https) without
including https:// I get "Frame error", but if I indeed include https:// in
the url input box it works.
On Thu, May 21, 2015 at 1:29 PM, Mostafa Rokooie<EMAIL_ADDRESS>wrote:

iPad (first gen), now after some tries I think it crashes less than a
second after initialization is finished, I can see the url in the box for
one second.
—
Reply to this email directly or view it on GitHub
https://github.com/EricssonResearch/bowser/issues/45#issuecomment-104344768
.

--
Alvaro

Thanks @zevarito but, I can not change the url because it crashes on start, and the url is the default url (openwebrtc.io/bowser)!

A first generation iPad is very likely really going to struggle with real-time audio/video even in optimal circumstances.
In order to add WebRTC support to a UIWebView from outside of the iPhone platform SDK has led us to use a suboptimal rendering method where all video frames are decided to bitmaps which are then displayed by the UIWebView as images, just that the image is updated rapidly. That is, Bowser is not optimal.
You may be able to use the WebRTC data channel though. :)
Regardless, this crash issue is a real issue.

Thank you guys for creating the Bowser, Actually I am not experienced in WebRTC and iOS and even apple devices, I am a web and low-level developer. Just was trying to make sure one of my customers can use my QR-Code scanner using his iPhone.
The weird thing for me is when I was trying Bowser on this brand-new iPad (1st gen) yesterday, everything was fine, and I was able to work with my online QR-Code scanner tool (unless some errors in rendering the page). But now after installing some random apps and enabling Siri on the iPad, the Bowser crashs!
By the way I think my customer may be still able to use Bowser on his iPhone 5 to work with my website.

I am using an iPhone 4S with iOS 8.3. Upon further testing, I found that if I launch Bowser from the home screen, it first says "Initializing: Please wait..." After that dialog fades, it starts to load the previously opened page (in my case, http://www.openwebrtc.io). Almost immediately, the app crashes. However, if after the dialog disappears I start repeatedly pressing the reload button, it alerts me with" Bowser has a problem: The operation couldn't be completed. (WebKitErrorDomain error 101.)" When I click close, the app works fine.
Using the "bowser://" URL scheme still doesn't work, though.

Oh, I just found out the new version 0.5 is released today! So it answers my question why it was working yesterday, maybe I need to find a way to install version 0.4!

I'm also having this problem on 3rd generation iPad. Would appreciate a fix!

I just received a feedback from my customer, he tested Bowser on three different iPhones (5 and 5s), and has the same problem.

We will investigate tomorrow.

We have managed to reproduce all of the above on an iPad 2. We will investigate further as soon as we can.

I have identified the issue as likely being a problem with armv7 libffi. armv7s and arm64 seem to work fine.
https://gist.github.com/superdump/996d8550beaf491c99e3
Tracking it in the main OpenWebRTC repository here: https://github.com/EricssonResearch/openwebrtc/issues/385

Getting a crash on iPhone 5. Takes a while to initialise. When done, when I click the address bar, it crashes. On iOS 8.1.3

Bowser (from App Store) crashes on iPad mini while trying to initialize.  (Running latest iOS)

I'm having the the crash-after-opening problem on an iPhone 5. Downloaded today from the Apple AppStore. I just updated iOS, no fix to the problem (though the app stays open maybe 1-2 extra seconds before crashing than it did before the update).

Just tried on an iPhone 5s - same problem.

I just tried 0.5 on my iPhone 5s, and it works FWIW.
On Sat, Jun 6, 2015 at 1:55 AM, pearcetm<EMAIL_ADDRESS>wrote:

Just tried on an iPhone 5s - same problem.
—
Reply to this email directly or view it on GitHub
https://github.com/EricssonResearch/bowser/issues/45#issuecomment-109485807
.

The 5S is ARM64 so that should be fine. I'm still trying to find libffi that builds with the current Xcode/iOS SDK and works on ARMv7/ARMv7S

To follow-up from a couple of comments ago, the 5s that was having problems with Bowser had very little disk space left. After freeing up space, Bowser loads without crashing. So as others have reported, only the 5 (and presumably below) is having trouble.

The iPad mini fails.   Even with disk space cleared.  It dies on boot of Bowser.

trying out in ipad mini, same problem here. crashes on initialization.

I have been testing libffi versions for a few weeks that used to work on armv7 / armv7s and I have so far been unable to find anything that works anymore. I suspect something has been broken as a consequence of an Xcode upgrade.
https://github.com/EricssonResearch/openwebrtc/issues/385 <--- someone reported that they got something working there but I have been unable to get the same changes to work here.

It's failing for me on both iPad  mini and iPad 3 (updated to most recent iOS 8.4).
Is there anything I can do to help?

I spent a few weeks trying many different libffi versions and those that supposedly worked for armv7 seemed to have stopped working or no longer built.
Libffi needs fixing so that it builds and works correctly on armv7, armv7s and arm64 for iOS

Any news on this? It's starting to feel like I won't get to use WebRTC on iOS until such time as I buy a new iDevice :-)

I need to re-test the various libffi versions with iOS SDK 8.4 to see if that helps anything.

Nice work.... Same question, any progress on this? I'm failing on Bowser 0.5 with ios 8.3 on iPhone 5.

This has been one bad bug :(

I agree and I have spent a lot of time on it already trying to find a version of libffi that builds and works on armv7 but have not yet succeeded.
It will at least get less bad with time as more people upgrade to 64-bit CPUs.

I think there is an option in iOS 9 to only support 64-bit devices. Even if that leaves a lot of devices out, it is perhaps a more honest approach until we have resolved this issue.

Dear God please fix this bug. We can't use bowser anymore after upgrading to ios 9.

@Firegarden are you sure this is the same issue? I can start Bowser on my iPhone 5s (64-bit device) running iOS 9. Please file a separate Issue on iOS 9 compatibility otherwise.

OK absolutely iPad Air 2 16GB does not work after upgrading to ios 9.-1
so there you have it I need to open a ticket but Im 2 busy coding 4 life
feel me. Tupac is 4 real.
On Sun, Sep 20, 2015 at 7:44 PM, Stefan Ålund<EMAIL_ADDRESS>wrote:

@Firegarden https://github.com/Firegarden are you sure this is the same
issue? I can start Bowser on my iPhone 5s (64-bit device) running iOS 9.
Please file a separate Issue on iOS 9 compatibility otherwise.
—
Reply to this email directly or view it on GitHub
https://github.com/EricssonResearch/bowser/issues/45#issuecomment-141881513
.

--
FIREGARDEN https://www.google.com/?q=firegarden
1877.222.7818

This has been fixed in a updated version of OpenWebRTC. Let us know if you still have problems after re-building latest OpenWebRTC from master. Closing.

I get crash in iphone 6 ios 10 - is this known issue ?


Using navigateTo in side the role redirects it to /about:blank

The code below causes the test to redirect to /about:blank after it redirected to the url.
const role = Role(url, async t => {
  await t
      .typeText('#UserName-field'<EMAIL_ADDRESS>      .typeText('#Password-field', 'password')
      .click('#submit-button')
      .navigateTo(url)
})

If I redirect after the role:
const **roleTest** = Role(url, async t => {
  await t
      .typeText('#UserName-field'<EMAIL_ADDRESS>      .typeText('#Password-field', 'password')
      .click('#submit-button')
})

test('Login test', async t => {
    await t
    .useRole(**roleTest**)
    .navigateTo(url)
    .expect(getLocation())
    .contains(url)
})

then it doesn't redirect to /about:blank, it redirects to the url successfully.

@LOUKOUKOU
Hello,
I suggest you use one of the following ways:

Set the preserveUrl: true option  to "save the URL to which the browser was redirected after logging in".
Specify your start page in the test.page function.


make install fails on gcc 7.1.1-64bit

Hi, I've just learned about this library and decided to try. However, 'make install' failed in various occasions
First:
cereal/archives/json.hpp:211:33: warning: this statement may fall through [-Wimplicit-fallthrough=]
and failed because CMake sets -Werror by default.
After disabling it, it couldn't find  <gnu/stubs-32.h> in cereal/unittests/memory.cpp:28
After installing 32-bit development libraries for glibc (I am on a 64-bit system), it passed that one and failed at

Linking CXX executable test_memory_32:
cannot find -lgcc

I suppose I need to recompile gcc with multilib support to fix this because I couldn't find gcc-multilib in openSuse repositories. It would be quite useful if cereal didn't require 32-bit libraries in an 64-bit system.
I've installed the library and skipped tests for now, but I thought it would be useful to share my experience.
If any more information is needed to reproduce, I can provide

Are you attempting to compile 'master' or a different directory?  The 28th line of memory.cpp is "#include "memory.hpp", which includes "common.hpp", but a grep of the source base doesn't show a single reference to stubs-32.h.
As far as the fallthrough, it seems that we disable it in rapidjson/internal/regex.h (possibly not re-enabling it?), but a fresh compile of cereal seems to work for me.  However, it DOES seem that we still have the problem in the code, so perhaps the disable is working?

Additionally, I note the disable in regex.h is only #ifdef clang.

First of all I am sorry that I got the stacktrace backwards and it looks like gnu/stubs came from type_traits in libstdc++, but 32-bit libraries still were a problem. I am not sure if it is a compiler, cmake or library bug but it required 32-bit libstdc++ and 32-bit gcc. After installing both of those, now make works fine.
I'll update here after make and the tests finish

Apparently the fallthrough warning is new in GCC 7 (https://dzone.com/articles/implicit-fallthrough-in-gcc-7). We actually do want the switch statement to fall through here - since the [[fallthrough]] attribute is c++17, it looks like the easiest fix is to add a /* fall through */ comment before appropriate cases.
cereal doesn't actually require 32 bit to work, we just try to build unit tests for both 32 and 64 bit. You can disable the 32 bit tests with the CMAKE flag SKIP_PORTABILITY_TEST.

It looks like 32-bit library thing is related to gcc and reported  Bug 54444, and I am supposing gcc-32 bit is necessary for linkers (though not sure). However, after installing both it now completed all of the tests except the said errors.

merged PR to fix


[HOTFIX]  fix spot check error

What changes were proposed in this pull request?
fix splot check error
Why are the changes needed?
ci failed for spotless check
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests

I added a backport label to test if the github workflow really works.

@FANNG1 can you please check the ci failure?

@FANNG1 can you please check the ci failure?

updated


Winui3 typography guidance and Wpf.Ui.Gallery improvements

Started using Winui3 typography guidance for TextBlock.
Added TextBlock typography styles.
Added custom TextBlock with FontTypography property and Appearance property.
Added a Typography page in Wpf.Ui.Gallery.
Implemented IsTextSelectionEnabled in TextBox and RichTextBox.
Added DynamicScrollViewer to the NavigationViewContentPresenter by default.
Pull request type

[x] Update
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes

Other information
It is necessary to use ContentControl to display FontIcon if FontSize is used.

@pomianowski  By the CardAction does not know how to decrease.

@pomianowski what does it mean ?

@pomianowski Hi, review this pull request please.

Hey @IvanDmitriev1, thanks for more ideas and improvements in WPF UI. Some controls like Snackbar need improvement, but we can fine-tune it in the development branch.


Port column-hiding-toolbar-style sample

@skrustev this change were already ported as this PR:
https://github.com/IgniteUI/igniteui-xplat-examples/pull/305/files

@HUSSAR-mtrela There's no need to close this PR since the sample config itself is here.
Once https://github.com/IgniteUI/igniteui-xplat-examples/pull/305 is merged, I'll resolve the conflicts here.


Model training terminated

Hi, one other issue I wanted to point out was that the training process seemed to terminate about 27 epochs in, due to a diverging loss.
Thanks!

As I say in the paper, the best thing to do when the model diverges is to
increase the number of mcmc steps or decrease the learning rate. EBMs are
very finicky creatures! Thankfully, there's been lots of work on improving
and stabilizing the training. One thing I read recently found smooth
nonlinearities to make training considerably more stable. So, you could try
a Swish and see if that helps out.
Cheers
On Mon, Nov 23, 2020 at 1:42 PM Divyanshu Murli<EMAIL_ADDRESS>wrote:

Hi, one other issue I wanted to point out was that the training process
seemed to terminate about 27 epochs in, due to a diverging loss.
Thanks!
[image: Screenshot 2020-11-23 at 08 46 08]
https://user-images.githubusercontent.com/38363539/100001813-ea9aa800-2d80-11eb-8376-6f7ac75a9970.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wgrathwohl/JEM/issues/8, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADYQS4QZO6HJLC4VBPE237TSRKUJXANCNFSM4T73SUOQ
.

--
Will Grathwohl
Graduate Student Researcher
Machine Learning Group
University of Toronto / Vector Institute

Ah, and by MCMC steps do you mean SGLD (sorry not super familiar with MCMC)?

Related question: so just to be clear, the code in the repo isn't the code used to create the results in the paper?

It is, but as we write in Appendix H.3:
"We find that when using PCD occasionally throughout training a sample will
be drawn from the replay buffer that has a considerably higher-than average
energy (higher than the energy of a random initialization). This causes the
gradients w.r.t this example to be orders of magnitude larger than
gradients w.r.t the rest of the examples and causes the model to diverge.
We tried a number of heuristic approaches such as gradient clipping, energy
clipping, ignoring examples with atypical energy values, and many others
but could not find an approach that stabilized training and did not hurt
generative and discriminative performance."
I will be the first to admit that EBM training in this way is a nightmare
and requires pretty consistent baby-sitting. At the moment these models are
basically where GANs were in like 2014. Not easy to train. Requires a lot
of hand-tuning. The main point of this paper was to demonstrate the utility
of these models if they can be trained. There have been a number of
improvements which can stabilize EBM training.
You should be able to train these models with some combo of restarts, lr
decrease, and mcmc step increase. I hope that helps.
On Mon, Nov 23, 2020 at 1:53 PM Milan Cvitkovic<EMAIL_ADDRESS>wrote:

Related question: so just to be clear, the code in the repo isn't the code
used to create the results in the paper?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wgrathwohl/JEM/issues/8#issuecomment-732357442, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADYQS4X7ZBKVDMDFS2X5S5TSRKVSPANCNFSM4T73SUOQ
.

--
Will Grathwohl
Graduate Student Researcher
Machine Learning Group
University of Toronto / Vector Institute

Definitely helpful, and much appreciated.  I'm just curious whether the line of code in the README worked for you, but isn't working for @divymurli.
That would be surprising considering that random draws from the buffer should be deterministic under the random seeds you set in the training scripts.  I can't see what the source of randomness would be.

As I say in the paper, the best thing to do when the model diverges is to increase the number of mcmc steps or decrease the learning rate. EBMs are very finicky creatures! Thankfully, there's been lots of work on improving and stabilizing the training. One thing I read recently found smooth nonlinearities to make training considerably more stable. So, you could try a Swish and see if that helps out. Cheers
…
On Mon, Nov 23, 2020 at 1:42 PM Divyanshu Murli @.***> wrote: Hi, one other issue I wanted to point out was that the training process seemed to terminate about 27 epochs in, due to a diverging loss. Thanks! [image: Screenshot 2020-11-23 at 08 46 08] https://user-images.githubusercontent.com/38363539/100001813-ea9aa800-2d80-11eb-8376-6f7ac75a9970.png — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYQS4QZO6HJLC4VBPE237TSRKUJXANCNFSM4T73SUOQ .
-- Will Grathwohl Graduate Student Researcher Machine Learning Group University of Toronto / Vector Institute

Thanks, increasing MCMC steps helps a lot.


⚠ Secret Website 3 has degraded performance

In 75abd74, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2399 ms

Resolved: Secret Website 3 performance has improved in 18505b9.


Uncaught InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList': The token provided ('u...

Atom Version: 1.0.5
System: Mac OS X 10.10.4
Thrown From: linter package, v1.3.4
Stack Trace
Uncaught InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList': The token provided ('unterminated-string meets end of fil') contains HTML space characters, which are not valid in tokens.
At /Users/user/.atom/packages/linter/lib/views/message.coffee:30

Error: Failed to execute 'add' on 'DOMTokenList': The token provided ('unterminated-string meets end of fil') contains HTML space characters, which are not valid in tokens.
  at Error (native)
  at Function.Message.renderRibbon (/Users/user/.atom/packages/linter/lib/views/message.coffee:30:18)
  at linter-message.Message.attachedCallback (/Users/user/.atom/packages/linter/lib/views/message.coffee:5:26)
  at linter-panel.<anonymous> (/Users/user/.atom/packages/linter/lib/views/bottom-panel.js:49:12)
  at Array.forEach (native)
  at linter-panel.updateMessages (/Users/user/.atom/packages/linter/lib/views/bottom-panel.js:48:14)
  at LinterViews.renderPanelMessages (/Users/user/.atom/packages/linter/lib/linter-views.coffee:107:12)
  at LinterViews.render (/Users/user/.atom/packages/linter/lib/linter-views.coffee:42:6)
  at /Users/user/.atom/packages/linter/lib/linter-plus.coffee:29:14
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at MessageRegistry.updatePublic (/Users/user/.atom/packages/linter/lib/message-registry.js:104:20)
  at UpdateMessages (/Users/user/.atom/packages/linter/lib/message-registry.js:35:17)

Commands
     -0:46.7.0 core:move-left (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:46.5.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
 30x -0:45.7.0 core:move-right (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:42.2.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:41.6.0 core:move-down (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:41.1.0 core:move-up (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
 13x -0:40.9.0 core:move-left (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
 20x -0:38.6.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:31.5.0 core:move-down (atom-text-editor.editor.vim-mode.is-focused.insert-mode.autocomplete-active)
     -0:31.2.0 autocomplete-plus:confirm (atom-text-editor.editor.vim-mode.is-focused.insert-mode.autocomplete-active)
     -0:22.7.0 core:save (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:15.5.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:12.3.0 core:move-down (atom-text-editor.editor.vim-mode.is-focused.insert-mode.autocomplete-active)
     -0:12.1.0 autocomplete-plus:confirm (atom-text-editor.editor.vim-mode.is-focused.insert-mode.autocomplete-active)
  8x -0:07.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:01.4.0 core:save (atom-text-editor.editor.vim-mode.is-focused.insert-mode)

Config
{
  "core": {
    "disabledPackages": [
      "relative-numbers"
    ]
  },
  "linter": {
    "lintOnFly": false,
    "showErrorPanel": false
  }
}

Installed Packages
# User
autocomplete-ruby, v0.1.0
git-plus, v5.3.4
linter, v1.3.4
linter-rubocop, v0.3.1
linter-ruby, v1.0.0
pigments, v0.9.3
relative-line-numbers, v0.1.5
tab-numbers, v0.2.0
vim-mode, v0.57.0

# Dev
No dev packages

I thought it had been fixed, can you please provide us some repro case?

@steelbrain This bug has occured only one time - after I installed your new update. But after a while, it hasn't occured

Can confirm multiple occurs:
Atom: 1.0.2
System: 14.04.1-Ubuntu
Thrown From: linter package, v1.3.4
Error: Failed to execute 'add' on 'DOMTokenList': The token provided ('unknown-type of ') contains HTML space characters, which are not valid in tokens.
  at Error (native)
  at Function.Message.renderRibbon (/home/troush/.atom/packages/linter/lib/views/message.coffee:30:18)
  at linter-message.Message.attachedCallback (/home/troush/.atom/packages/linter/lib/views/message.coffee:5:26)
  at linter-panel.<anonymous> (/home/troush/.atom/packages/linter/lib/views/bottom-panel.js:49:12)
  at Array.forEach (native)
  at linter-panel.updateMessages (/home/troush/.atom/packages/linter/lib/views/bottom-panel.js:48:14)
  at LinterViews.renderPanelMessages (/home/troush/.atom/packages/linter/lib/linter-views.coffee:107:12)
  at LinterViews.render (/home/troush/.atom/packages/linter/lib/linter-views.coffee:42:6)
  at /home/troush/.atom/packages/linter/lib/linter-plus.coffee:29:14
  at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at MessageRegistry.updatePublic (/home/troush/.atom/packages/linter/lib/message-registry.js:104:20)
  at UpdateMessages (/home/troush/.atom/packages/linter/lib/message-registry.js:35:17)

@Troush do you have steps to reproduce it?

This bit of fat-fingered ruby reproduces it for me
hash_missing_equals {
  'key' => 'value',
  'other key' => 'value missing closing tick
}

For me, this happens regarding rails haml views.
@Arcanemagus For me, this can simply be reduced by clicking anywhere in the file. I have vim-mode turned on btw.

As @KurtRMueller reported, this is happening everytime I do some action in a haml file.

So at least with the code @adamvaughan posted (thanks!) it looks like this is a mistake in the regex they are using that is causing this. It's trying to use "unterminated string meets end of fil" as the error type, which obviously doesn't match "error" :wink:.
Working on a better regex for that.

A confirmed fix is up in https://github.com/atom-community/linter/pull/827

Closing as invalid since it's a provider bug.


Marie can't see received shares inside shared with you

When Marie receives a share she can see it inside the Shared with you section with pending status, But when she accepts a share she can not see that share anymore.

https://reva.link/docs/tutorials/share-tutorial/
it can provide some work around about local testing

Yes, this link shows how we can start two reva instances in same machine. I'll try that.

This was fixed


Double output on failures in hooks using Protractor & Mocha

When using Mocha and Protractor, if an error occurs (i.e. AssertionError) inside a hook, output is printed twice.
When using Mocha without Protractor, this behaviour does not occur.
To reproduce:
Clone https://github.com/eswets/mocha-double-output
To run with Protractor:
Run npm install, npm run update-webdriver-dependencies, npm run protractor
Produces output:
[16:24:35] I/launcher - Running 1 instances of WebDriver
[16:24:36] I/direct - Using ChromeDriver directly...

  Some spec
    1) "before all" hook: Failing before

  0 passing (10ms)
  1 failing

  1) Some spec "before all" hook: Failing before:

      AssertionError: expected true to equal false
      + expected - actual

      -true
      +false

      at Context.<anonymous> (someSpec.js:6:25)
      at runTest (node_modules/selenium-webdriver/testing/index.js:166:22)
      at node_modules/selenium-webdriver/testing/index.js:187:16
      at new ManagedPromise (node_modules/selenium-webdriver/lib/promise.js:1067:7)
      at controlFlowExecute (node_modules/selenium-webdriver/testing/index.js:186:14)
      at TaskQueue.execute_ (node_modules/selenium-webdriver/lib/promise.js:2970:14)
      at TaskQueue.executeNext_ (node_modules/selenium-webdriver/lib/promise.js:2953:27)
      at asyncRun (node_modules/selenium-webdriver/lib/promise.js:2860:25)
      at node_modules/selenium-webdriver/lib/promise.js:676:7
  From: Task: Some spec "before all" hook: Failing before
      at Context.ret (node_modules/selenium-webdriver/testing/index.js:185:10)

  0 passing (16ms)
  1 failing

  1) Some spec "before all" hook: Failing before:

      AssertionError: expected true to equal false
      + expected - actual

      -true
      +false

      at Context.<anonymous> (someSpec.js:6:25)
      at runTest (node_modules/selenium-webdriver/testing/index.js:166:22)
      at node_modules/selenium-webdriver/testing/index.js:187:16
      at new ManagedPromise (node_modules/selenium-webdriver/lib/promise.js:1067:7)
      at controlFlowExecute (node_modules/selenium-webdriver/testing/index.js:186:14)
      at TaskQueue.execute_ (node_modules/selenium-webdriver/lib/promise.js:2970:14)
      at TaskQueue.executeNext_ (node_modules/selenium-webdriver/lib/promise.js:2953:27)
      at asyncRun (node_modules/selenium-webdriver/lib/promise.js:2860:25)
      at node_modules/selenium-webdriver/lib/promise.js:676:7
  From: Task: Some spec "before all" hook: Failing before
      at Context.ret (node_modules/selenium-webdriver/testing/index.js:185:10)

[16:24:36] I/launcher - 0 instance(s) of WebDriver still running
[16:24:36] I/launcher - chrome #01 failed 1 test(s)
[16:24:36] I/launcher - overall: 1 failed spec(s)
[16:24:36] E/launcher - Process exited with error code 1

To run only Mocha:
npm test
Produces output:
Some spec
    1) "before all" hook: Failing before

  0 passing (8ms)
  1 failing

  1) Some spec "before all" hook: Failing before:

      AssertionError: expected true to equal false
      + expected - actual

      -true
      +false

      at Context.<anonymous> (someSpec.js:6:25)

Relevant misc information:

Node Version: 6.9.4
Protractor Version: 5.1.1
Operating System and Version MacOS Sierra 10.12.4
Protractor config:

exports.config = {
    specs: '*Spec.js',
    directConnect: true,
    maxSessions: 1,
    framework: 'mocha',
    mochaOpts: {
        reporter: 'spec',
        bail: true,
        colors: true,
    },
};

This behaviour seems to be caused by including the bail: true flag.

@eswets
Is this solved now for you? If so, can we close the issue?

Sorry for the late reply, but the issue still persists. Not using Mocha's bail functionality works around the issue, but this means losing out on the bail functionality (stop running a testsuite on a failure).

Ok, sorry for closing. Will look into it the coming days


C#: Non-instantiable GodotObject can't be GC-collected.

Tested versions
4.x
System information
Win11
Issue description
Non-instantiable classes including SceneTreeTimer, DirAccess, and PhysicsDirectSpaceState2D, etc.
These types of managed instance cannot be collected by GC (even if they are disposed).
Steps to reproduce
Use MRP below. I add a button to manually GC.Collect().
Case 1:
for (var i = 0; i < 1000; i++)
{
    var atlas = new AtlasTexture(); // instantiable RefCounted
    var fa = DirAccess.Open("res://"); // non-instantiable RefCounted
}

After forcing GC.Collect(), only AtlasTextures are collected (and freed). You can check this on Profiler tab in the editor.
Case 2:
for (var i = 0; i< 1000;i++)
{
    using var node = GetNode("Button"); // instantiable GodotObject
    using var state = GetWorld2D().DirectSpaceState; // PhysicsDirectSpaceState2D, non-instantiable GodotObject
}

This actually creates 1000*2 temp instances referring to one same native object, and they should be collected on next GC.
However, after GC.Collect(), only the instances of node are collected. The 1000 instances of state are still alive.
You can check this using memory inspector like dotMemory or Visual Studio:

Memory capture after forcing GC, PhysicsDirectSpaceState2D (and DirAccess in case 1) are still alive.
Minimal reproduction project (MRP)
gc_collect_test.zip

This may be caused by incorrect C# binding generation.
Default constructor for instantiable class:
public AtlasTexture() : this(true)
{
    unsafe
    {
        _ConstructAndInitialize(NativeCtor, NativeName, CachedType, refCounted: true);
    }
}

However non-instantiable class don't call _ConstructAndInitialize directly:
internal DirAccess() {}

Instead, its base class RefCounted calls _ConstructAndInitialize -> TieManagedToUnmanagedWithPreSetup:
https://github.com/godotengine/godot/blob/74c32faa78b54863f8f25c538083907c2bf71791/modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/InteropUtils.cs#L79-L88
Here DirAccess != RefCounted, so the managed instance has a strong GC handle by accident.


Add Stylus/custom CSS support

I don't know how feasible this would be to implement and maintain, but it would be cool as hell if you could implement theming of websites via CSS. Common sites like YouTube, Twitter, various Fediverse clients such as Pleroma, Mastodon, Misskey etc. It would really take things to the next level, but it would probably be extremely hard to do not to mention maintain and deal with bugs and things that look funny. I'm just throwing this out here as a idea, and maybe someone can do something with it or discuss it

Certainly possible, but you're right about it being a lot of work.

In case popular browsers, like Firefox, provide extensions to which we only have to provide the Stylix color palette, then it should not be much of a burden.


[Feature Request] Support for the RichTextBox target in an UserControl

The RichTextBox target can be used to log text to a Rich Text Box control in an existing or new form. I have the requirement to log messages to a Rich Text Box control in an existing UserControl. I tried to configure the target for the User Control, but as I expected, that didn't work (a new form is created by NLog). Therefore I request to make that target work within a Rich Text Box inside an User Control.
I am currently developing an application-level add-in for Microsoft Word 2010 and I want to utilize NLog to write application event messages to a custom task pane. Since a custom task pane can only contain custom user controls, I can't use a form.

Closed as this doesn't seem needed by other people. But please create new issue in the NLog/NLog.Windows.Forms repository if necessary.


The CKEditor is Not Working On Certain UseCase

https://github.com/GrapesJS/mjml/assets/119593989/ed9ee27d-ef96-4db8-8298-6e69f8e0b116
Once the Text is in Edit Mode and Update any styles then again try to use the ckeditor its not working

CKEditor is not part of this repo


Redisson 3.21.0 not support record

to be confirmed

We have supported to record and replay of this version of redisson.


terminate called after throwing an instance of 'ReadSocketException'   what():  std::exception Aborted

After inference processes terminate on all workers and master, is there a way to keep the process going?
terminate called after throwing an instance of 'ReadSocketException'   what():  std::exception Aborted

Here's my solution:
while true; do sudo nice -n -20 ./dllama worker --port 9998 --nthreads 4; done


Changed navbar animations

Demo Video is here have look once
https://github.com/HimanshuNarware/CareerZunction_Intern/assets/123359660/3122d006-389b-461b-bb5b-666257d44d4d

@Syed0206 keep the animation effect minimal, not that aggresive

Sir okay changed as per your instructions as design to minimal .Please review here is demo video .If you don't like this also please mention which type of design I should add please .
https://github.com/HimanshuNarware/CareerZunction_Intern/assets/123359660/380dd043-217d-4fdd-9bb0-90b3029415f8

@Syed0206 use left to right underline effect

Sur added underline effect Sir.Please review and merge my PR Sir.Here is demo video Sir.
https://github.com/HimanshuNarware/CareerZunction_Intern/assets/123359660/22951f2e-4727-4861-92f3-0e88830a3285


 After migrating its usage to winrt::event, I noticed there was two major differences between them:

Event<> can be copied, and it didn't seem complex to allow copying winrt::event.
In C++/CX, calling the destructor (or Dispose from C#) would clear the list of event handlers right away. In C++/WinRT, while manually implementing IClosable, you cannot achieve the same: the memory associated with the event handlers (and any of their captures) is only released upon the reference count reaching 0.

So, I implemented and tested both features to achieve parity

/azp run

/azp run

/azp run


scala 2.12 requires jre8

minor fix for issue #22439: Scala 2.12 requires JRE8

This should be undone, as there is no more jre7


Support modules

 Issue by roonyh
Wednesday Jul 20, 2016 at 05:29 GMT
Originally opened as https://github.com/storybooks/react-native-storybook/issues/48

At the moment react-native storybook helps mostly app developers. The documentation assumes its added to an existing app.
We can make it work also for module developers, so instead of sample apps they can use storybook.

@roonyh Maybe you can explain this further?

By "module" i meant "library". https://nativebase.io/ seems to be such a component library.
Its not an app. At the time rn-storybook was difficult to be used for such library development. It was targeting app development. The web storybook can be used instead of an sample app by web component library developers. I thought the RN version should work the same.
I haven't used RN-storybook in a while so don't know how this has changed.

You can certainly create a new "modules" project if you will by creating a new project using create-react-native-app and then adding storybook/react-native on top of it.
Please reopen if there's still a problem.


Pass Cylance's 100 test

Cylance is proud of what they call the "AV 100" test.
In order to be considered an AntiVirus, this must pass the "AV 100" test.
The test works as follows:

Download 100 random samples from VT.
Scan 100 samples downloaded.
Detect 100 samples scanned.
PROFIT.

To be fair, I think this dataset was developed from samples from VirusTotal
It would likely pass due to the dataset


Release API service version 0.6.0

Fixes #168

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 45.461%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1262

Relevant Lines:
2776

💛  - Coveralls


Follow the latest CODEOWNER in main to the dev-ja branch

Describe your changes
To make latest CODEOWNERS in main branch work for dev-ja branch, I update the CODEOWNERS file in dev-ja branch.
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Hi folks!
Preferred way to update dev-ja branch is merging existing commits in main branch into the dev-ja.
(team needs to avoid modifying content outside /ja/* in the dev branch directly. it is to avoid merge conflict and to assign a proper reviewer)
@naonishijima Please use following method.
https://github.com/cncf/glossary/compare/dev-ja...main
If you meet any merge conflict, you need to rebase the dev branch locally and resolve the conflicts manually.

@seokho-son  Thank you for advice.
I send new PR & will close this PR.


Feature/redis reconnection

If Redis connection time is exceeded, you can not delete the key, so reconnect with Redis.

If Redis connection time is exceeded, you can not delete the key, so reconnect with Redis.

If Redis connection time is exceeded, you can not delete the key, so reconnect with Redis.


Add docs for typed-dict

as titled

the example here depends on #3830

Made a few wording suggestions.  Looks good once #3830 is ready to merge.

@sklam, docs look good, few suggested changes here: https://github.com/stuartarchibald/numba/commit/a66a753807d0165ef7dde34887b9ea6735893ae7, you are welcome to use any subset of them as you see fit!

Applied https://github.com/stuartarchibald/numba/commit/a66a753807d0165ef7dde34887b9ea6735893ae7 as a patch and added other suggestions from seibert.

Looks good.  I think we can skip CI for these docs changes.


TTOOLS-598 SQL editor highlighting and autocomplete

Would just like comments on these changes.
The intention is to enable SQL highlighting for the codemirror component, and enable auto-complete hints.  The hightlighting is working ok, but auto-complete hints seem to be hidden, at least in dev environment.

PR Storybook available here

PR Storybook available here

Ah, this will need a rebase, @riccardo-forina did some much needed refactoring of the text editor component to sort out some problems.

PR Storybook available here

@riccardo-forina I think still the following import is missing from refactoring.
import 'codemirror/addon/hint/show-hint.css';

Sure, just open a new PR with that add!


Implement schema-based validation for USDM JSON data

The DDF team has identified some generic checking requirements which might be best implemented through the checking of USDM JSON data against a defined USDM schema (e.g., JSON-Schema).  These checks include confirming conformance with characteristics defined in the USDM API specification, including such things as :

Primitive data types
Correct class usage
Cardinalities
Required properties

This was the proposal I made at the beginning of April: USDM Schema Validation.pptx

Given that schemas in API specs based on OpenAPI v3.1 or higher are JSON-Schema compliant (and the USDM v3.0 API spec is OpenAPI v3.1), I have shown that it's possible to extract a usable USDM JSON-Schema definition directly from the USDM API spec, pass it into the JSON-Schema validator currently used by the CORE Engine to validate Dataset-JSON files (jsonschema), and use it to generate a list of schema violations found in a USDM JSON data file (e.g.,
CDISC_Pilot_Study_sv_edit-2024-05-16T13-19-27.xlsx).
The following would be needed from the CORE team to implement this proposal:

Define a new Rule Type (e.g., "JSON Schema Check") that would trigger:

Retrieval of the appropriate schema (probably based on the specified standard and standard version). We'd need to figure out the best way to provision USDM schemas:

Is a separate specification needed or will the API spec alone be sufficient?
Access route: e.g., direct from GitHub, direct from CDISC Library, from GitHub via CDISC Library, etc.?

Execution of the JSON-Schema validation and gathering of validation errors (which should probably be cached so that repeated validation is not needed)
Comparison of rule specifications against validation errors and reporting of rule success/failure. We'll need to determine:

How the comparison is made. The jsonschema validator creates a hierarchical tree of validation errors, which can be interpreted in different ways (e.g., should an error found when comparing against one of the "subschemas" of an anyOf be reported individually or should there be a single error for the anyOf: 'xxx' is not valid under any of the given schemas).
The specificity of rules (e.g., one rule per schema component, per class, per attribute, etc.)
What information needs to be presented with each error message to make it interpretable.

In order to develop and test schema-based rules, the Rules Editor would need to be updated:

To not report the new Rule Type as an error (schema update)
Allow JSON files containing test data to be loaded.

Any new operators needed to assess schema validation errors.  However, this proposal primarily involves defining rules according to schema validation error property values (e.g., message contains "xxx", validator equals "yyy"), so a need for new operators is not anticipated.

This is a table of the JSON-Schema attributes that are handled by the jsonschema validator:

Schema Attribute
Message(s)

$dynamicRef

$ref

additionalItems
Additional items are not allowed (%s %s unexpected)

additionalProperties
{joined} {verb} not match any of the regexes: {patternProperties}Additional properties are not allowed (%s %s unexpected)

allOf

anyOf
{instance!r} is not valid under any of the given schemas

const
{const!r} was expected

contains
{instance!r} does not contain items matching the given schema

dependentRequired
{each!r} is a dependency of {property!r}

dependentSchemas

enum
{instance!r} is not one of {enums!r}

exclusiveMaximum
{instance!r} is greater than or equal to the maximum of {maximum!r}

exclusiveMinimum
{instance!r} is less than or equal to the minimum of {minimum!r}

format

if

items
Expected at most {prefix} items, but found {total}

maxItems
{instance!r} is too long

maxLength
{instance!r} is too long

maxProperties
{instance!r} has too many properties

maximum
{instance!r} is greater than the maximum of {maximum!r}

minItems
{instance!r} is too short

minLength
{instance!r} is too short

minProperties
{instance!r} does not have enough properties

minimum
{instance!r} is less than the minimum of {minimum!r}

multipleOf
{instance!r} is not a multiple of {dB}

not
{instance!r} should not be valid under {not_schema!r}

oneOf
{instance!r} is not valid under any of the given schemas{instance!r} is valid under each of {reprs}

pattern
{instance!r} does not match {patrn!r}

patternProperties

prefixItems

properties

propertyNames

required
{property!r} is a required property

type
{instance!r} is not of type {reprs}

unevaluatedItems
Unevaluated items are not allowed (%s %s unexpected)

unevaluatedProperties
Unevaluated properties are not allowed (%s %s unexpected)Unevaluated properties are not valid under the given schema (%s %s unevaluated and invalid)

uniqueItems
{instance!r} has non-unique elements


Add missing resource for jgit

Without it, publish local fails when locale are set en_pl

IIRC, this wasn't making things fail, this was only printing garbage in the console, then publishing keeps going.


Typo "@publication"→"@publication"

Bold with escape characters
https://docs.microsoft.com/en-us/sql/relational-databases/replication/publish/manage-partitions-for-a-merge-publication-with-parameterized-filters?view=sql-server-2014

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Create Polyadic.CodeStyle

Should we define our own code style?

Is this related to the suppressions in https://github.com/polyadic/funcky-lexer/pull/3/files?

Not directly, but Polyadic depends on Messerli repos.

I started an experiment in #785. There are a lot of code style options built into roslyn. Thanks to EnforceCodeStyleInBuild we might not need StyleCop anymore (which would be great because StyleCop usually takes a while to catch up with new C# versions).


Refactoring data API

Attempt to clean up the top level API.
Changes:

withData methods renamed and given documentation. New ones hopefully are easier to understand. Feedback welcome on better names though...
Top-level namespace was getting quite polluted. Pruned it a bit, and put some operations under objects (i.e. AggOps.Sum)
Added support for encoding values that are Dates (basically just formatted to the ISO-8601)
Added support for overriding how Any values are converted to JS friendly values, via an implicit argument.
Refactored various "type detecting code" into a vegas.data.* package. Added unit tests for this code.
Added unit tests for WindowRenderer, and tidied up some of that code (I didn't really understand what I was doing with JavaFX. Still don't really, but understand a little more I guess).

LGTM. Merged into master. Thanks.


Added changes to scoping to the release notes

The changes to name scoping and variable scoping are important breaking changes and should be listed as major changes.

Can one of the admins verify this patch?

@martinwicke per your request, the same pull request as #4745 to r0.11 as well


Android Ionic DevApp missing from Play Store

The DevApp appears to be missing from the Google Play store.
https://ionicframework.com/docs/appflow/devapp links to https://play.google.com/store/apps/details?id=io.ionic.devapp&hl=en, which shows "We're sorry, the requested URL was not found on this server." Searching the store for DevApp also doesn't turn anything up. The iOS link appears to work.

facing same issue

Any updates on this? Missing since 12/26/2019 at least.

Is there at least an apk available for use while this problem isn't solved?

DevApp is back on the Play Store. Thanks for letting us know!


Tracing with /level3 results in FAILURE_MERGE_TRACES

When trying to analyze a project of our solution with vcperf /level3 it's not possible to successfully stop the tracing session. I've also tried to use /nocpusampling together with /stopnoanalyze but the error still occurs. The Sprout example from the blog works fine.
vcperf /start /level3 MySessionName
Microsoft (R) Visual C++ (R) Performance Analyzer 1.3.20031402
Starting tracing session MySessionName...
Tracing session started successfully!
vcperf /stop /templates MySessionName outputFile.etl
Microsoft (R) Visual C++ (R) Performance Analyzer 1.3.20031402
Stopping and analyzing tracing session MySessionName...
Dropped MSVC events: 0
Dropped MSVC buffers: 0
Dropped system events: 0
Dropped system buffers: 0
Failed to stop trace.
ERROR CODE: FAILURE_MERGE_TRACES

How long is the build you are tracing, and how much space do you have available on your drives? Traces for long builds are larger. This error could mean there isn't enough space on your system drive (normally the C: drive) as vcperf tries to save the temporary non-analyzed trace in a temp directory.

The build of the single project takes ~ 2:30 min. I have 220GB of free space on my disk.
Smaller projects that needed only 20 sec to build worked fine.
Our whole solution currently takes 25 minutes to build. Is there a way to specify the temp directory?

You can override the temporary directory by setting the TMP or TEMP environment variable in the same console where you invoke vcperf. I would suggest using a directory on that 220 GB drive.

Were you able to successfully stop your trace?

Hi,
I've just set the TEMP folder to a drive that has ~770GB. The generated etl-files reached ~3GB. However it still fails with the same error message. I guess it doesn't seem to be a problem with the file size.

Thanks for the information. Does this only happen with /level3? Does it happen every time or just occasionally? Yes if you could provide a dump file it could be useful. Opening an issue on Developer Community might be better for submitting a dump file.

The same problem happens to me on a custom build of vcperf (freshly merged with this repo's master).
I have hundreds of GB on both drives, and I build only one project, which takes 10 minutes.
I also have Dropped MSVC events: 7, although I suppose it is not critical.
I tried to build the same project again, and got the same exact error.
I tried to build some other projects: did not see the error there.
Tried to build with /level2 instead of /level3: the problem went away too.

hi @kevcadieux
first of all, thank you for all this great work, has been a real ~life~time saver
second we are seeing a similar issue only with /level3
etl trace uploaded here - https://developercommunity.visualstudio.com/t/vcperf-fails-to-stop-trace-for-C-fail/10731427?sort=newest
tried debugging it but seems cpp_insights dll returns RESULT_CODE_FAILURE_STOP_MSVC_TRACE without any other error or exception :(
I assume the code for this dll is not available for debugging ?
Cheers!


Rename some classes to be more expressive

Rename a few things in preparation for #139 - better get this in early so we don't run into friction working in parallel :)

I'm not sure whether Dashboard should be the same as the whole LightningWallet screen. I think having the ability to not see trading prompts for when I'm looking through my transaction history would be cool. In other words, I'm not too keen on Dashboard rename.

I think if we want a Dashboard it should be on a different level. For me Dashboard is an abstract word that does not add any benefit in the current context. We have a wallet view, and we are in a wallet context.
I can imagine that in the future we might have another hierarchy level on top where one can see all kind of activities of what happened - that could be a Dashboard then, but I don't think that's what we currently have. I think Wallet makes more sense in what was implemented so far - and even more with the changes outlined by #139 and #113

Note: For implementing #139 I will have to rename Dashboard to be in a lightning wallet context because there will be another view that is the Bitcoin wallet. I might be able to keep the Dashboard terminology as widget on top, but I don't think this makes sense in the current modularization.
In the future we can hopefully get rid of needing a Bitcoin hot-wallet in the application, but for now we need it. cc @bonomat

maybe I'll rephrase: the current widget, with big buttons about trading, is not perfect for the "wallet view" IMHO. this might be subjective, so if others I happy with the rename, I will not stop you :-)

maybe I'll rephrase: the current widget, with big buttons about trading, is not perfect for the "wallet view" IMHO. this might be subjective, so if others I happy with the rename, I will not stop you :-)

I agree and recorded this observation in https://github.com/itchysats/10101/discussions/138#discussioncomment-4081307

I suggest we finish this #122 discussion, before we renaming / restructuring things.

Note: @holzeis and me had a discussion including wireframe walkthrough and he will have anoher look at the changes.
I think #122 makes sense, but I would probably see most of that discussion as post-tournament task. I don't expect to extend the POC we build, see #138 :)

@holzeis should this still be blocked? You re-requested a review from yourself, but it seems no review was done? 😅

Closing in favor of https://github.com/itchysats/10101/pull/146
Sorry for the back and forth, it was not a good idea to try to do these changes separate.


Revise figure captions & attributions

I noticed some problems with the figures that had been added, so I went through and revised them. Sorry I wasn't paying closer attention, I should have caught this sooner!
If you look at the "files changed" you'll see a diff showing the changes I'm proposing.
A few notes:

Don't use [...] for link text and (...) for urls - that is only when you're adding a link to text content; only include the text and the url when you are using the figure shortcode.
What you had as attribution text (attr) in most cases I have converted to the caption. The attribution should be for the source of the image; caption is a description / brief label.  (The source isn't styled properly yet, question about that below.)
We may want to revisit the alt text; it's more important to convey the intent of the image in context than to describe it visually. I suggest we review and revise the alt text in an additional pass after all the images have been added.

questions:

What source makes sense for the various newspapers from the Papers of Princeton archives? Does it make sense to just attribute these as Princeton University Library? (I can update them if you all agree.)
Do we want a label for source links? (something like "from: " or "source: "). I can add it in the templates when we decide.

We can ask Gissoo about design for attribution/source links. (Maybe could be smaller or on a separate line, to separate from the caption.)

Should we come up with a convention for language when we link to other resources? I think a couple of words would be helpful, otherwise it isn't clear why the link is there. In some places we have language like "read more.." or "read a passage", which I found more helpful.

We can ask Gissoo about some kind of icon / indicator when a link is taking you to another site and also if we want to indicate if the link goes to a pdf or jpeg (best practice to signal this).

Thank you for these notes @rlskoeser. We should share these set directly with Ivan @im2484 so that he is sure to implement going forward.
What source makes sense for the various newspapers from the Papers of Princeton archives? Does it make sense to just attribute these as Princeton University Library? (I can update them if you all agree.) Yes, PUL will be fine.
Do we want a label for source links? (something like "from: " or "source: "). I can add it in the templates when we decide.
We can ask Gissoo about design for attribution/source links. (Maybe could be smaller or on a separate line, to separate from the caption.) Yes...I prefer "From:" but not strongly over Source.
Should we come up with a convention for language when we link to other resources? I think a couple of words would be helpful, otherwise it isn't clear why the link is there. In some places we have language like "read more.." or "read a passage", which I found more helpful. Agree 100%. Read more will cover all the possibilities. We may also need See more for images that are either cropped or not full size in the panel
We can ask Gissoo about some kind of icon / indicator when a link is taking you to another site and also if we want to indicate if the link goes to a pdf or jpeg (best practice to signal this). Nice idea.


fix: Ensure trail_event_origin is constructed from strings

Hello! Currently looking at trying out this project to reduce clickops 😄
Ran into an error when running the example in standalone mode
[ERROR] TypeError: can only concatenate str (not "set") to str
Traceback (most recent call last):
  File "/var/task/app.py", line 199, in handler_standalone
    event_json["logGroup"]

This appears to be due to the concatenation of trail_event_origin being a mix of strings and sets. The message payload looks something like this
  ...
  "logGroup": "some_group",
  "logStream": "some_stream",
  "subscriptionFilters": ["some_filter"],
  "logEvents": [
    {
     ...
    }
   ]

Instead - i think the concatination should look something like
     trail_event_origin = (
            event_json["logGroup"]
            + ":"
            + event_json["logStream"]
            + "\n"
            + ":".join(event_json["subscriptionFilters"])
        )

I've manually the change on my test account and it seems to be working OK 😄
Thanks!

LGTM, thanks for the contribution!


How can I see the list of events?

How can I see the list of events as I did in re-frisk?

You can go to the Trace tab and select to show only events, and disable the "Only show traces for this epoch?" checkbox.

I think that's what you're looking for? Let me know if I've got it wrong and you're thinking of something else.


KERNEL: Refine logger and error

The logger should only log the "BIG" events, which are not error. In addition, logger should support context. The errors should, not only the error code, but indicates the context such as the stack and description. For detail information about errors, please read https://gocn.io/article/348.
For SRS, it confuses the error and logger, that is SRS output error in logger and in each function calls. There is a example, when error cames from SrsSource::on_video_imp, each function will print a error:
int SrsSource::on_video_imp(SrsSharedPtrMessage* msg) {
    if ((ret = hub->on_video(msg, is_sequence_header)) != ERROR_SUCCESS) {
        srs_error("origin hub error, ret=%d", ret);
        return ret;
    }
}

int SrsOriginHub::on_video(SrsSharedPtrMessage* shared_video, bool is_sequence_header) {
    if ((ret = format->on_video(msg)) != ERROR_SUCCESS) {
        srs_error("Codec parse video failed, ret=%d", ret);
        return ret;
    }
}

int SrsFormat::on_video(int64_t timestamp, char* data, int size) {
    return video_avc_demux(buffer, timestamp);
}

int SrsFormat::video_avc_demux(SrsBuffer* stream, int64_t timestamp) {
    if (!stream->require(4)) {
        ret = ERROR_HLS_DECODE_ERROR;
        srs_error("avc decode avc_packet_type failed. ret=%d", ret);
        return ret;
    }
}

Let's have a look what happends when there is a decode error:
avc decode avc_packet_type failed. ret=3001
Codec parse video failed, ret=3001
origin hub error, ret=3001

Is it useful? Yes, it's useful than just an error code like Failed, code is 3001, but it's not enough:

There is no stack info.
The logs are not simply enough.

I'll be better if the error is like this:
Error processing video, code=3001 : origin hub : codec parser : avc decoder
[100] video_avc_demux() at [srs_kernel_codec.cpp:676]
[100] on_video() at [srs_app_source.cpp:1076]
[101] on_video_imp() at [srs_app_source:2357]

For logger, it should log some important events, the error should be one event.

We use variable ret:int as simple error code, while using err:srs_error_t for complex error.

Here we confused the log and error:
            if ((ret = rtsp->send_message(res)) != ERROR_SUCCESS) {
                if (!srs_is_client_gracefully_close(ret)) {
                    srs_error("rtsp: send SETUP response failed. ret=%d", ret);
                }
                return ret;
            }

Instead, we should return a error:
            if ((ret = rtsp->send_message(res)) != ERROR_SUCCESS) {
                return srs_error_new(ret, "send message");
            }

Finally at the top of call, such as the thread cycle or main cycle, we can decide whether to print the error or not.

Fixed.


 Some of them definitely seem related to the addition of SQFormMultiValue. This issue should be used to fix them.
is there a particular reason we don't have the tests in the CI pipeline?

There's an issue to add it to the pipeline #167. We were holding off on adding that until we were more comfortable with implementing tests (ref) - I think it's probably time to get that running though

There's an issue to add it to the pipeline #167. We were holding off on adding that until we were more comfortable with implementing tests (ref) - I think it's probably time to get that running though

Approved.
I'd also consider this a high priority issue.
The main question is do we want this as part of our pre-commit to avoid pushing up code that doesn't pass our tests?
The other option is to omit it from our pre-commit and get used to running these tests in Jest watchmode while developing like we should be doing now anyway.
Then ensure tests are passing in our ci GitHub Action

Pretty sure we had a slack discussion about this a while back - I think the conclusion may have been no pre-commit, run jest watch locally, double check with ci

There's an issue to add it to the pipeline #167. We were holding off on adding that until we were more comfortable with implementing tests (ref) - I think it's probably time to get that running though

Approved.
I'd also consider this a high priority issue.
The main question is do we want this as part of our pre-commit to avoid pushing up code that doesn't pass our tests?
The other option is to omit it from our pre-commit and get used to running these tests in Jest watchmode while developing like we should be doing now anyway.
Then ensure tests are passing in our ci GitHub Action

That's always the ten million cpu cycle question.
My opinion is that we get into the habit of running in watch mode, and checking tests before we commit. However, I don't think it should be a part of the pre-commit script as that'll just slow down committing. If all i did was change a typo for some PR feedback it seems silly to have to run all the tests.
Plus the Github Action that'll run these tests is so much more valuable for our testing and code quality than running tests locally. So if our github action fails I consider that a win, as it prevented us from merging a bug and/or failing tests to master.

I would think eventually everyone would get used to running tests locally when they get tired of ci failing because they didn't run tests locally


use select one column, one column one search

but another bug is :i search quickly，the datatables will let my user auth logout, what happen?

You mean you got logged out? This issue was mostly raised when using artisan serve. If you're using serve then I suggest you change your environment to some LAMPP/WAMP stack.

I use server is xammp ,
remove the check for name index : the "function isColumnSearchable" is check a column is searchable or not, remove that not effect the "searching and ordering", i test this change in my program, do not  have any problems .
datatables::of($query)->make();

datatables::of($query)->make(true);

I see.. since we have a setupColumnName method that magically fetch the proper column name then we can indeed remove the check for the name index.
            if ($this->request->isColumnSearchable($i)) {
                $column  = $this->setupColumnName($i);

haha .you found it

Yeah makes sense now. ^_^ Thanks! Released on v5.12.3


Integrate a Chatbot for Instant User Support

Is your feature request related to a problem? Please describe.
Enhance the website's user experience by integrating a chatbot that provides instant answers to user inquiries. The chatbot should be easily accessible, provide relevant responses, and offer seamless assistance for common queries, improving user engagement and support.
Describe the solution you'd like
Add a chatbot icon or button that floats on the bottom-right corner of the site.
When clicked, the chatbot window should expand with a smooth animation, displaying an input field and previous chat history.
The chatbot should respond to frequently asked questions (related to the FAQ section) and common inquiries about products or services.
Implement a fallback response for questions outside the chatbot's scope (e.g., "Sorry, I don't have an answer for that. Please contact our support team.").
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
@DeadmanAbir please assign this to me under gssoc-ext and hacktoberfest

which chatbot provider are you thinking to integrate?

@DeadmanAbir it will be a chatbot built using gpt4o and this will be specific to the website so i can answer any questions related to the website too as well as general questions.

@DeadmanAbir it will be a chatbot built using gpt4o. It will be a site specific chatbot which will be able to answer any queries related to site

It will be a headache for us to manage and  gather credits for api key, so not much needed for now.


Type annotations

This PR adds type annotations and mypy checks to pdfminer. This can catch bugs early, and helps developer productivity -- besides serving as documentation, it also enables a much richer experience with autocompletion, type hints, intellisense, etc. in modern editors.
Many of the annotations are non-trivial (e.g. unions, generics, and more use of Any than one might prefer) because much of pdfminer is highly dynamic in its use of types, and the codebase has lots of sites where multiple types are possible (partly due to PDF parsing, and partly as a result of Python2 legacy, e.g. with str and bytes).
My general strategy to dealing with type errors raised by mypy was:

If the code would obviously crash at runtime, add an assertion
(e.g. assert x is not None)
Otherwise, if there's an unchecked conversion between object types
(that might be violated, e.g., by a non-conforming PDF file), or if
there's a valid conversion that mypy cannot recognise (e.g. the size of
tuples returned by chop and friends, or the type of struct.unpack), add
a cast. This has no runtime effect, but serves as documentation that
something potentially-fishy is going on. With some refactoring and stronger
annotations, some of these casts could be removed in the future.
Otherwise, add a # type: ignore comment to silence the issue -- the goal
should eventually be to remove these as annotations expand to cover
more of the code.

Related: issue #362.

I believe this is a definite bug (if the code is reachable):
pdfminer/pdfdevice.py:191: error: Argument 1 to "write" of "IO" has incompatible type "str"; expected "bytes"

@pietermarsman, @jstockwin -- this got far out of hand from what I originally intended in scope (I've now annotated nearly the entire codebase), but feels like it is ready for review and discussion. There's plenty of scope for changes, but I'm hoping the value is obvious just from the number of issues it has already uncovered (see comments in the PR).

@0xabu Thanks for this big effort! I'm going to check the code again in a while (when I'm less drowsy) and merge it if everything looks good.

No worries. Hopefully it makes life easier in the future. I have a few improvements of my own I can now tackle.


3D visualization: ValueError: 'arr' does not have a suitable array shape for any mode.

Thanks for your great work!
I want to visualize the grad-CAM figure for my 3D data image. However, I met some problem at this line:
       grads = visualize_cam(model, layer_idx, filter_indices=20,                                seed_input=img, backprop_modifier=modifier)
in the code block:

import numpy as np
import matplotlib.cm as cm
from vis.visualization import visualize_cam
for modifier in [None, 'guided', 'relu']:
plt.figure()
f, ax = plt.subplots(1, 2)
plt.suptitle("vanilla" if modifier is None else modifier)
for i, img in enumerate([img1, img2]):
# 20 is the imagenet index corresponding to ouzel
grads = visualize_cam(model, layer_idx, filter_indices=20,
seed_input=img, backprop_modifier=modifier)
# Lets overlay the heatmap onto original image.
jet_heatmap = np.uint8(cm.jet(grads)[..., :3] * 255)
ax[i].imshow(overlay(jet_heatmap, img))

It returns the error:

Traceback (most recent call last):
File "CNN_vis_CAM.py", line 319, in
seed_input=img, backprop_modifier=modifier)
File "/usr/local/lib/python2.7/dist-packages/vis/visualization/saliency.py", line 239, in visualize_cam
return visualize_cam_with_losses(model.input, losses, seed_input, penultimate_layer, grad_modifier)
File "/usr/local/lib/python2.7/dist-packages/vis/visualization/saliency.py", line 186, in visualize_cam_with_losses
heatmap = imresize(heatmap, input_dims, interp='bicubic', mode='F')
File "/usr/local/lib/python2.7/dist-packages/scipy/misc/pilutil.py", line 480, in imresize
im = toimage(arr, mode=mode)
File "/usr/local/lib/python2.7/dist-packages/scipy/misc/pilutil.py", line 289, in toimage
raise ValueError("'arr' does not have a suitable array shape for "
ValueError: 'arr' does not have a suitable array shape for any mode.

My data size is 49-41-40, and I succeed in drawing the saliency figure. Do you know how to fix this problem? Thanks for your reading! And looking forward to your reply.

I would also be interested in whether this can be used for 3D inputs.

I think the direct cause of the error has already been corrected in current master branch.
But, the problem I wrote in issues#113 also occurs here.
If you are using Conv2D, please execute the step in issue#113.

keras-vis 0.4.1
https://github.com/raghakot/keras-vis/blob/e6ef1d7c0dee7fc90e57c82ff720dc3eafc9c365/vis/visualization/saliency.py#L185-L186

current master branch
https://github.com/raghakot/keras-vis/blob/e019cc43ce6c00b2151941b18dbad63164ad632a/vis/visualization/saliency.py#L184-L188

I am having the same issue. I have a 3D VGG.  Saliency Maps are generated by visualize_cam doesnt work.

@jalilahmed , Can I see the error log of  your issue ?

@keisen The library was NOT UPDATED. Doing an UPDATE removed the error. Thanks for your quick response.

@keisen The library was NOT UPDATED. Doing an UPDATE removed the error. Thanks for your quick response.
I also have the problem(Saliency Maps are generated by visualize_cam doesn't work.), can u tell me which library u updated? my current version is :keras-vis 0.4.1  keras2.1.0  TF 1.4.0.Looking forward to your reply.

@jalilahmed  The library was NOT UPDATED. Doing an UPDATE removed the error. Thanks for your quick response.
I also have the problem(Saliency Maps are generated by visualize_cam doesn't work.), can u tell me which library u updated? my current version is :keras-vis 0.4.1 keras2.1.0 TF 1.4.0.Looking forward to your reply.

@jalilahmed I also have the problem(Saliency Maps are generated by visualize_cam doesn't work.), can u tell me which library u updated? my current version is :keras-vis 0.4.1 keras2.1.0 TF 1.4.0.Looking forward to your reply.

I also have the problem(Saliency Maps are generated by visualize_cam doesn't work.), can u tell me which library u updated? my current version is : keras-vis 0.4.1   keras2.1.0    TF 1.4.0.  Looking forward to your reply.

@jalilahmed I also have the problem(Saliency Maps are generated by visualize_cam doesn't work.), can u tell me which library u updated? my current version is : keras-vis 0.4.1 keras2.1.0 TF 1.4.0. Looking forward to your reply.

@keisen , I'm trying to visualize on InceptionV3. I got same error:
`InvalidArgumentError                      Traceback (most recent call last)
/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py in _create_c_op(graph, node_def, inputs, control_inputs)
1863   try:
-> 1864     c_op = c_api.TF_FinishOperation(op_desc)
1865   except errors.InvalidArgumentError as e:
InvalidArgumentError: slice index 20 of dimension 1 out of bounds. for 'strided_slice_5' (op: 'StridedSlice') with input shapes: [?,2], [2], [2], [2] and with computed input tensors: input[1] = <0 20>, input[2] = <0 21>, input[3] = <1 1>.
During handling of the above exception, another exception occurred:
ValueError                                Traceback (most recent call last)
12 frames
/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py in _create_c_op(graph, node_def, inputs, control_inputs)
1865   except errors.InvalidArgumentError as e:
1866     # Convert to ValueError for backwards compatibility.
-> 1867     raise ValueError(str(e))
1868
1869   return c_op
ValueError: slice index 20 of dimension 1 out of bounds. for 'strided_slice_5' (op: 'StridedSlice') with input shapes: [?,2], [2], [2], [2] and with computed input tensors: input[1] = <0 20>, input[2] = <0 21>, input[3] = <1 1>.
`


Support Gradle Configuration Caching

@fractalwrench and I talked about this offline, filing to track here!
https://docs.gradle.org/nightly/userguide/configuration_cache.html

I think this is done now but will let y'all make the final call on closing 👍

Did this support regress since 2020? It doesn't appear to work on 7.2.0
com.bugsnag:bugsnag-android-gradle-plugin:7.2.0
FAILURE: Build failed with an exception.

* What went wrong:
Configuration cache state could not be cached: field 'manifestInfo' from type 'com.bugsnag.android.gradle.BugsnagReleasesTask': error writing value of type 'org.gradle.api.internal.provider.DefaultProperty'
> Configuration cache state could not be cached: field 'provider' from type 'org.gradle.api.internal.provider.MappingProvider': error writing value of type 'org.gradle.api.internal.provider.TransformBackedProvider'
   > Configuration cache state could not be cached: field 'transformer' from type 'org.gradle.api.internal.provider.TransformBackedProvider': error writing value of type 'com.bugsnag.android.gradle.BugsnagPlugin$registerBugsnagTasksForVariant$1$manifestInfoProvider$2'
      > Configuration cache state could not be cached: field '$output' from type 'com.bugsnag.android.gradle.BugsnagPlugin$registerBugsnagTasksForVariant$1$manifestInfoProvider$2': error writing value of type 'com.android.build.gradle.internal.api.ApkVariantOutputImpl'
         > Configuration cache state could not be cached: field 'services' from type 'com.android.build.gradle.internal.api.ApkVariantOutputImpl': error writing value of type 'com.android.build.gradle.internal.services.BaseServicesImpl'
            > Configuration cache state could not be cached: field 'projectServices' from type 'com.android.build.gradle.internal.services.BaseServicesImpl': error writing value of type 'com.android.build.gradle.internal.services.ProjectServices'
               > Configuration cache state could not be cached: field 'deprecationReporter' from type 'com.android.build.gradle.internal.services.ProjectServices': error writing value of type 'com.android.build.gradle.internal.errors.DeprecationReporterImpl'
                  > Configuration cache state could not be cached: field 'issueReporter' from type 'com.android.build.gradle.internal.errors.DeprecationReporterImpl': error writing value of type 'com.android.build.gradle.internal.errors.SyncIssueReporterImpl'
                     > Configuration cache state could not be cached: field 'messageReceiverImpl' from type 'com.android.build.gradle.internal.errors.SyncIssueReporterImpl': error writing value of type 'com.android.build.gradle.internal.errors.MessageReceiverImpl'
                        > Configuration cache state could not be cached: field 'mGson' from type 'com.android.build.gradle.internal.errors.MessageReceiverImpl': error writing value of type 'com.google.gson.Gson'
                           > Configuration cache state could not be cached: field 'constructorConstructor' from type 'com.google.gson.Gson': error writing value of type 'com.google.gson.internal.ConstructorConstructor'
                              > Configuration cache state could not be cached: field 'accessor' from type 'com.google.gson.internal.ConstructorConstructor': error writing value of type 'com.google.gson.internal.reflect.UnsafeReflectionAccessor'
                                 > Configuration cache state could not be cached: field 'overrideField' from type 'com.google.gson.internal.reflect.UnsafeReflectionAccessor': error writing value of type 'java.lang.reflect.Field'
                                    > Configuration cache state could not be cached: field 'root' from type 'java.lang.reflect.Field': error writing value of type 'java.lang.reflect.Field'
                                       > Configuration cache state could not be cached: field 'overrideFieldAccessor' from type 'java.lang.reflect.Field': error writing value of type 'jdk.internal.reflect.UnsafeBooleanFieldAccessorImpl'
                                          > Unable to make field protected final java.lang.reflect.Field jdk.internal.reflect.UnsafeFieldAccessorImpl.field accessible: module java.base does not "opens jdk.internal.reflect" to unnamed module @4966d1cf

HI @Naitbit,
There are still some parts of the plugin that do not support configuration caching. This is still on our backlog to address but I'm afraid I don't have any further updates at this time

Hi @hackertronix - unfortunately we do not have any further updates at this time. We'll look into this when priorities allow.

Would you be open to a community-contributed PR?

As of v7.3.0 we have support for Gradle Configuration Caching for our ProGuard (R8) support (but not NDK just yet), we're still working on adding support for our other tasks.

FYI it looks like this has regressed in 7.4.0 as NdkToolchain.baseDir is incorrectly annotated as a Property<File> rather than a DirectoryProperty. Will send a PR, but it would be helpful if some tests could be added that ensured configuration cache didn't regress.

Thanks @ZacSweers, we will look into this asap.

With Gradle 8.1, its failing with
external process started 'git --version'
See https://docs.gradle.org/8.1/userguide/configuration_cache.html#config_cache:requirements:external_processes

due to the following external process execution
https://github.com/bugsnag/bugsnag-android-gradle-plugin/blob/908e6186bff7badf24ee214c852599b26f71abb9/src/main/kotlin/com/bugsnag/android/gradle/BugsnagReleasesTask.kt#L140

Hi @rohilchodankar Thanks for raising, we are investigating this now.

Hey @rohilchodankar, our latest version v8.0.1 has just been released. This should address the issues you were seeing with Gradle 8.1.


mega rings lost on update to 7.0

On update, some users no longer have mega rings, as shown.
Users are still tagged with having the ring serverside, and so it cannot be returned via commands or by defeating a boss
Update: After more testing, mega evolution works outside battle, but not during battle.

Fixed for 7.0.1


Investigate what to do with deprecated stable/dex helm chart

This chart is deprecated https://github.com/helm/charts/tree/master/stable/dex and it does not contain a link to a new home.
What to do?

Fork and maintain it ourselves
...

Relevant PR https://github.com/dexidp/dex/issues/1709

We are going to provide an official chart as soon as we can. Until then you can use our maintained fork: https://github.com/banzaicloud/banzai-charts/tree/master/dex

the dex-shim image sadly doesn't have multi-arch support

See https://github.com/dexidp/helm-charts

See https://github.com/dexidp/helm-charts

Replaced by: https://github.com/elastisys/compliantkubernetes-apps/issues/274


make possible to use http basic auth with guzzle http client at Crate/PDO

Ok thanks for the last reply. I hope this will work for you.
Test added and asserted the http client parameters given for Crate/PDO.
with credentials from doctrine dbal connnection parameters user and password
@see: http://guzzle.readthedocs.org/en/latest/clients.html
@see: http://doctrine-dbal.readthedocs.org/en/latest/reference/configuration.html

pls check travis failure

@xeroxzone could you please add a changelog entry in CHANGES.txt too.
also, did you sign a CLA already?
then, after squashing commits, we're good to go :)
thanks,
christian

CLA signed. This is very nice. Thanks to the Team. Solid and very good work you do here. Love this.
Looking forward to next contribution ;)
Best regards,
Ralph

@xeroxzone perfect!
please squash the commits into a single one and I'll merge :)

Is coming… ;)

Have I to do something about the Scrutinizer?

@xeroxzone scrutinizer has the hickup ;)

@chaudum thanks, then all is fine now. So I experienced all necessary things, that the next contribution will get more flawless. Superb! :)
Greets to the complete Team! Bye for now!

@xeroxzone we've very happy to have a new contributor on board.
thanks for your effort!

It's released! Very happy :) Was currently changing my projects composer to use the exact commit with the new feature. That make a lot easier. Thanks :)
Looking forward that crate-dbal composer.json also get an update for the new crate-pdo version ;)

@xeroxzone crate-dbal:0.2.0 is released https://packagist.org/packages/crate/crate-dbal

Very nice! All my project here updated. Thank you!
A short lookout what I am doing next with a friend is building a crate-orm package, with generated entities and embeddables complete from annotations and mapping types with nested object_arrays and other typed arrays in deep recursion. All doctrine commands like schema:create, :update, :validate, and drop are supported. The first prototype rocks already here. Hope it's ready to deploy in the near next time.
Best regards,
Ralph


Derive hash on Call

For convenience Call should derive Hash

This change is

hey @orizi,
lmk if a decision is taken, I wouldn't mind doing it :)


Width adjustment in responsive is not enabled when toolbar is balloon.

This is a fixed part in v2.35.0, but when the mode is balloon or inline and the toolbar is not always displayed, it seems that the button arrangement in responsive width is not displayed well.
https://github.com/JiHong88/SunEditor/blob/master/src/lib/core.js#L6674
The value is obtained using offsetWidth, but in the state of "display: none" such as balloon, it becomes undefined or 0, so I think that it is because the conditional branch is not done well.

The 2.36.2 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

I confirmed the correction contents.
Thank you.


[FEATURE] Add Font to Profile

Description
I want to add fonts to profile. Currently, the website is using the default web browser font, however we can use a custom font.
Screenshots
No response
Additional information
So, please assign it to me, I'll add a google font that will look good.

Can I take this issue ? @eddiejaoude

I think we need to discuss the pros/cons of adding a not default font

Can I take this issue ? @eddiejaoude

yes @eddiejaoude I will discuss with you on discord

@eddiejaoude, I would love to discuss. Thanks!

It would be interesting to see the performance of the app before/after - I see some sites loading 7MB for fonts and I just leave
But TBH for now I think let's focus on performance and other improvements

Going to close this as we have many other more features being requested


Add PoolFee and Network to Pool Information

Make pool designation configurable (as per the specification for VSP design)
Show PoolFee and Network in Pool Information

Closes #93

Nicely done 👍


Can't resolve '/bin-package' via webpack

I'm trying to use this module for a chrome extension using webpack. When I run npx webpack I receive the following error:
 ERROR in ./node_modules/question-answering/node_modules/tokenizers/bindings/native.js Module not found: Error: Can't resolve '/bin-package' in '....\node_modules\question-answering\node_modules\tokenizers\bindings'  @ ./node_modules/question-answering/node_modules/tokenizers/bindings/native.js 1:15-38  @ ./node_modules/question-answering/node_modules/tokenizers/bindings/decoders.js  @ ./node_modules/question-answering/node_modules/tokenizers/implementations/tokenizers/bert-wordpiece.tokenizer.js  @ ./node_modules/question-answering/node_modules/tokenizers/implementations/tokenizers/index.js  @ ./node_modules/question-answering/node_modules/tokenizers/index.js  @ ./node_modules/question-answering/dist/qa.js  @ ./node_modules/question-answering/dist/index.js
Is this module compatible with webpack?
P.S. If not, how can I run huggingface models using TFJS?

Unfortunately, the Tokenizers library used internally for tokenization doesn't provide bindings for the browser but only for Nodejs (see https://github.com/huggingface/tokenizers/issues/63), so you can't use this library with webpack (I suppose you're trying to use it in the browser).

SAME! THIS IS SO ANNOYING!!!


OCSP_request_add0_id() inconsistent error return

There are two failure cases for OCSP_request_add_id():

OCSP_ONEREQ_new() failure, where |cid| is not freed
sk_OCSP_ONEREQ_push() failure, where |cid| is freed

This changes makes the error behavior consistent, such that |cid| is
not freed when sk_OCSP_ONEREQ_push() fails. OpenSSL only takes
ownership of |cid| when the function succeeds.

FYI, this fix should better be back-merged .

Yes. This is easily ported back to 1.0.2, the function formatting and contents are basically the same.

+1 for both 1.1.0 and 1.0.2

pushed to master and 1.0.2 (see the 'pushed a commit' notices above).  closing.  thanks.


Fixed toastr js/css upstream locations

Related to #53 and potentially #83 if you check https://cdnjs.com/libraries/toastr.js/latest# the actual links provided there for both the toastr.min.js and toastr.min.css are under: http://cdnjs.cloudflare.com/ajax/libs/toastr.js/latest/ with no /js/ or /css/ suffixed URI.
https://cdnjs.cloudflare.com/ajax/libs/toastr.js/latest/js/toastr.min.js and http://cdnjs.cloudflare.com/ajax/libs/toastr.js/latest/css/toastr.min.css both 404.

that's weird as it work for me, I don't get 404.
Thanks for finding that !


Add pixels for snooze

Task/Issue URL: https://app.asana.com/0/0/1205947647495715/f
Description
See attached task description
Steps to test this PR
https://app.asana.com/0/0/1206000100414551/f

Current dependencies on/for this PR:

develop

PR #3869

PR #3897   👈

This stack of pull requests is managed by Graphite.


Deterministic hang in to_torch depending on deallocate location

We've tracked down a deterministic hang with a very strange trigger based on when an intermediate tensor is deallocated.
To reproduce:
Checkout 4c917440c47577050a4374f01caa2465616d2c8a and run:
pytest models/demos/mistral7b/tests/test_mistral_perf.py::test_mistral_model_perf[32-15-0.16]
Hanging configuration
Here's where things get interesting. This is the configuration (as seen in commit xxx) that causes the hang:
Decoder:
attn_norm = self.attention_norm(x) # <- attn_norm is the problematic tensor
# Attention module expects a list of inputs, attn masks (multi-device support)
r = self.attention.forward(
    [attn_norm],
    current_pos,
    [attn_masks],
)
# ttnn.deallocate(attn_norm) <- attn_norm is deallocated inside attention.forward() in this version

Attention:
xqkv_fused = ttnn.linear(
    attn_norm,
    wqkv,
    program_config=self.wqkv_program_config,
    memory_config=self.model_config["XQKV_MM_OUTPUT_MEMCFG"],
    compute_kernel_config=self.compute_kernel_config,
    dtype=self.dtype,
)

ttnn.deallocate(attn_norm, force=False) # <- when deallocated here, the final to_torch on the model output hangs!

Working configuration
Now, if instead we comment out the deallocate call in the attention block and instead deallocate attn_norm in the decoder after the attention block returns, there is no hang, e.g. in this configuration:
Decoder:
attn_norm = self.attention_norm(x) # <- attn_norm is the problematic tensor
# Attention module expects a list of inputs, attn masks (multi-device support)
r = self.attention.forward(
    [attn_norm],
    current_pos,
    [attn_masks],
)
ttnn.deallocate(attn_norm) # Deallocating here avoids the hang?!

Attention:
xqkv_fused = ttnn.linear(
    attn_norm,
    wqkv,
    program_config=self.wqkv_program_config,
    memory_config=self.model_config["XQKV_MM_OUTPUT_MEMCFG"],
    compute_kernel_config=self.compute_kernel_config,
    dtype=self.dtype,
)

# ttnn.deallocate(attn_norm, force=False) <- no longer deallocate here even though unused in the rest of this function

This is weird AF and I hope it helps someone debug the actual cause of this hang, which might also be presenting elsewhere in the stack but less deterministically.

high bw discussion here - https://tenstorrent.slack.com/archives/C065NUB85K3/p1714041186227089

@yieldthought @mtairum we have been asked to try this with fd2.0 in case with some weird interaction, it goes away

FD 2.0 update
This still hangs on today's main, but now the workaround (moving the deallocate) also hangs, e.g. this code now hangs every time regardless of where the deallocate call is made from. The version pushed in yieldthought/7822-fd2 is the configuration that would run cleanly on fd 1, but both this and the hang configuration hang on FD 2.

@yieldthought does it mean mistral completely is broken?  I don't have /mnt/MLPerf or /proj_sw. I am not sure why both are missing. Maybe one of them can be mounted. But is it possible to make this test run without relying on any directory? And  just using /tmp directory or something like that to store the store the weights?

@jvasilje this issue looks like it's deeper in the stack. Can someone who has a better understanding of watcher be assigned to re-run this test and see what's causing the hang?

@uaydonat This only occurs on the new attention implementation branch and does not occur on the current main, so not a P0 imo.

@arakhmati This is an artefact of not having a consistent share file system across sites unfortunately. The instructions to download the weights are here: https://github.com/tenstorrent/tt-metal/tree/main/models/demos/wormhole/mistral7b#details but in general we should provide a way to run tests with random weights to avoid every dev having access to a copy in cases like this in which the weights themselves do not matter.

We have merged a version of this code that does not hang to main.

@yieldthought , would you take a look at https://github.com/tenstorrent/tt-metal/commit/17d0e26ed4a9f8bd72d6a79d66a7e50cac3528da
I've not been able to reproduce the hang with the latest code from main.  Does it look like the changes should have caused it to hang?

Thank you @yieldthought !
The stack track is showing us at:
void HWCommandQueue::finish() {
    ZoneScopedN("HWCommandQueue_finish");
    tt::log_debug(tt::LogDispatch, "Finish for command queue {}", this->id);
    std::shared_ptr<Event> event = std::make_shared<Event>();
    this->enqueue_record_event(event);
    if (tt::llrt::OptionsG.get_test_mode_enabled()) {
        while (this->num_entries_in_completion_q > this->num_completed_completion_q_reads) {
            if (DPrintServerHangDetected()) {
                // DPrint Server hang. Mark state and early exit. Assert in main thread.
                this->dprint_server_hang = true;
                this->set_exit_condition();
                return;
            } else if (tt::watcher_server_killed_due_to_error()) {
                // Illegal NOC txn killed watcher. Mark state and early exit. Assert in main thread.
                this->illegal_noc_txn_hang = true;
                this->set_exit_condition();
                return;
            }
        }
    } else {
        while (this->num_entries_in_completion_q > this->num_completed_completion_q_reads);
    }
}

This needs to be prioritized to the Metal Runtime team.

This hang reminds me of the underlying code in our lockfree queue tt_metal/impl/dispatch/lock_free_queue.hpp.
Could we swap out this implementation with https://github.com/cameron314/concurrentqueue and verify whether this could be the source of the problem and verify that we do not have an issue here?

@pgkeller @davorchap  - @eyonland  needs help from Runtime team

Have a fix pr #9273. Was a program cache issue not updating addresses.

The fix is now merged to main. Closing this issue.


Docker Hub V1 API is not returning all the tags

I have a script that generate a data container base on a version of my package.json (to avoid installing npm modules if there is no new modules). I have a script that check if there is a container in docker hub for the current version of my package.json. This script is doing a curl request to get all the available tags of my image. It's a public container so I don't need authentication.
It was working great the first few weeks but now I can see that tags returned by the API are missing.
https://index.docker.io/v1/repositories/maxwell2022/tuna-solutions-api-data-dev/tags is only returning 5 tags.
[
  {
    "layer": "97dde7ca",
    "name": "0514e84fe1"
  },
  {
    "layer": "5cceba5d",
    "name": "223261f5d5"
  },
  {
    "layer": "cfe67742",
    "name": "7a8232d99c"
  },
  {
    "layer": "334ad2ee",
    "name": "7accd171a3"
  },
  {
    "layer": "082a28bf",
    "name": "e0b1759ef6"
  }
]

However there is more than this more:
https://hub.docker.com/r/maxwell2022/tuna-solutions-api-data-dev/tags/
I've looked into v2 API of the docker registry, and it's returning the expected tags. However I don't really want to use v2 because it requires authentication even for public containers. Alslo the token delivered is valid just for a minute or so.
I tried to look if there were some sorting or limit parameter for v1 but I could not find anything. Also if I tried to request a specific tag that does exists, I get a 404 page:
https://index.docker.io/v1/repositories/maxwell2022/tuna-solutions-api-data-dev/tags/0b69706847

Tag not found

The v1 API has been deprecated and you will need to switch to the v2 to get the full list of tags. The registry implementations are completely different and images pushed to v2 will not necessarily be available via the v1 API. This is a decision by registry operators and I believe the hub turned off v2 to v1 sync awhile ago. If you are unsure you can contact support for the hub.
As for the tokens, I think you are right that the hub is giving out tokens with pretty short expirations. This is also a decision by registry operators and I think this may be more configurable in the future. My advice would be to build in token caching and fetching into your transport code and just go with v2. If you are using go you can use the implementation in this repository, if other languages I am not sure what is available to you.

Thanks for the quick clarification @dmcgowan.
I've ended up using V2 requesting a new token each time I want to request the list of tags. I'm using a Makefile for my scripts so it's not trivial to enable caching. Also because there is no information about the validity duration of the delivered token, it's difficult to know for how long we can cache this token. I'm thinking building an internal API to simplify our Makefile.
Thanks again,
Maxime


Publish new version of collins_client and collins_shell

Hey!
Can someone who has access to publish new gems update both of these ruby gems so that I can take advantage of the master version of collins?
Thanks!

@roymarantz @defect

Hey Michael, sorry for the super long delay. The missing versions should now be available. I also rekindled my hatred for jeweler :)


3.x 版本中 package.json 缺失 sideEffects 字段

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link
https://github.com/antvis/F2/blob/3.x/package.json
Steps to reproduce

Environment
Info

g2
3.5.19

System
-

Browser
-

F2 问题提交到 https://github.com/antvis/F2/issues