Fixed bandcamp track and album links

LGTM!

Thank you for doing this. This PR looks like it will close #526 , but I had one discrepancy while trying out this PR and testing it. When I load in https://deaddiskdrive.bandcamp.com/album/artificial-os, it misses track number 3 while gathering the songs (https://deaddiskdrive.bandcamp.com/track/3d-demo-disc). Other than this one issue I have not found anything else wrong with this PR and it looks good to go.

Is there no error? the track is part of the extracted JSON, and nothing looks unusual about it.
for reference, the JSON
For reference, this is the `trackinfo` section of JSON as found on the album website:
"trackinfo": [
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/4fa6df97c59f958d34466cc4c089fbf0/mp3-128/2658197655?p=0&ts=1601489979&t=247214d221d40d7e3b24d72e43903059bffa928c&token=1601489979_6342229967bc23704b7e04b1b6db4e001c7cae3b"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Installation Complete!",
        "track_id":<PHONE_NUMBER>,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 12.8167,
        "title_link": "/track/installation-complete",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id":<PHONE_NUMBER>,
        "video_source_id": null,
        "track_num": 1
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/006a7e10031148f170e5476683b99ac4/mp3-128/2296155045?p=0&ts=1601489979&t=eb864756e6015e7603670a56fdc883fe62617a8c&token=1601489979_92df9c4d5756710c878938bd3438d4c2892ce8e9"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Brand New OS",
        "track_id":<PHONE_NUMBER>,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id": 995673547,
        "video_caption": null,
        "video_id": null,
        "duration": 165.612,
        "title_link": "/track/brand-new-os",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id":<PHONE_NUMBER>,
        "video_source_id": null,
        "track_num": 2
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/c7616731f751907267ab6c7b4882a5ce/mp3-128/3400146095?p=0&ts=1601489979&t=e20771ebbaee0a16ed308b2fc7b2c949b5c808d6&token=1601489979_87a28715964a613232d494e11fb54e8c95e19afc"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "3D Demo Disc",
        "track_id":<PHONE_NUMBER>,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id": 984993413,
        "video_caption": null,
        "video_id": null,
        "duration": 170.266,
        "title_link": "/track/3d-demo-disc",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id":<PHONE_NUMBER>,
        "video_source_id": null,
        "track_num": 3
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/597e4247af25f386a652ecb8a9fba6ca/mp3-128/280398431?p=0&ts=1601489979&t=7f0baccdf3dc0f519c89edd358b64a89f86cd053&token=1601489979_2c28df20e5de5955289449a913faa5f3a1017154"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Underwater Screensaver",
        "track_id": 280398431,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 145.608,
        "title_link": "/track/underwater-screensaver",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id": 280398431,
        "video_source_id": null,
        "track_num": 4
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/8de505c0ce2c631f3ba15a43fb8959e6/mp3-128/1845346583?p=0&ts=1601489979&t=d9ed8030215c8fb482f6e2f336d2aa0c9230f8e8&token=1601489979_2b6bd0c7c03832d5ae7bc1eae7f952124a07570b"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Animated Cursor Set",
        "track_id":<PHONE_NUMBER>,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 164.005,
        "title_link": "/track/animated-cursor-set",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id":<PHONE_NUMBER>,
        "video_source_id": null,
        "track_num": 5
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/2054a0ede07261bfb61f8788c74d7bb0/mp3-128/1681310860?p=0&ts=1601489979&t=024c944e0fbf8bf6ac0bd5891e0a5a86abfa3249&token=1601489979_1b82fa943ddf8cc00ba4c272bceb7085deb97de6"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Vanity Programs",
        "track_id":<PHONE_NUMBER>,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 145.737,
        "title_link": "/track/vanity-programs",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id":<PHONE_NUMBER>,
        "video_source_id": null,
        "track_num": 6
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/d928d0e5e3e8e530ea5a90767993e820/mp3-128/582878897?p=0&ts=1601489979&t=e0cd6ca7d531c1e48addfbf3c00286789a1da872&token=1601489979_d7389cca747b925fcdc1f03c9295c0eaa09b7429"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Connected to the Chatroom! (feat. Mac Bandit)",
        "track_id": 582878897,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 271.312,
        "title_link": "/track/connected-to-the-chatroom-feat-mac-bandit",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": true,
        "id": 582878897,
        "video_source_id": null,
        "track_num": 7
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/e54a801172cc1228dee3195cca998211/mp3-128/2965490929?p=0&ts=1601489979&t=cdc9e5c126d039ed1a65e34be7d3ff235570bbef&token=1601489979_380dcf41cd860c4d239d570680bfcadd762a6ac6"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Online Shopping Experience",
        "track_id":<PHONE_NUMBER>,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 129.49,
        "title_link": "/track/online-shopping-experience",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id":<PHONE_NUMBER>,
        "video_source_id": null,
        "track_num": 8
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/47faf9a1c74506c02a20d92d47bda228/mp3-128/910396513?p=0&ts=1601489979&t=46118acdbea4a713611a227d1edc6b69047e3773&token=1601489979_1b596b8fc67d833f38458bcd25c50fe679460126"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Finding Folders...",
        "track_id": 910396513,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 124.142,
        "title_link": "/track/finding-folders",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id": 910396513,
        "video_source_id": null,
        "track_num": 9
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/f83b52c5bf16c68f2d0f5341916bd787/mp3-128/1212054135?p=0&ts=1601489979&t=983155998b35b6b075fd53e34e680200fc082f52&token=1601489979_ade40f866541ff601426b4e86835af1684256ee6"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Through the World Wide Web",
        "track_id":<PHONE_NUMBER>,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 142.743,
        "title_link": "/track/through-the-world-wide-web",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id":<PHONE_NUMBER>,
        "video_source_id": null,
        "track_num": 10
    },
    {
        "encoding_error": null,
        "is_downloadable": true,
        "license_type": 1,
        "file": {
            "mp3-128": "https://t4.bcbits.com/stream/55671664de0453c8c36df95c77847d03/mp3-128/2798771237?p=0&ts=1601489979&t=e9e8affb96fc7b492b12f9bece632dc2e185e2e1&token=1601489979_16a5d47dbd0b5f5556d4949ba76af730318eefe5"
        },
        "video_mobile_url": null,
        "album_preorder": false,
        "encoding_pending": null,
        "has_free_download": null,
        "video_poster_url": null,
        "unreleased_track": false,
        "title": "Shattered Macintosh Dreams",
        "track_id":<PHONE_NUMBER>,
        "track_license_id": null,
        "play_count": null,
        "is_draft": false,
        "free_album_download": false,
        "encodings_id":<PHONE_NUMBER>,
        "video_caption": null,
        "video_id": null,
        "duration": 133.418,
        "title_link": "/track/shattered-macintosh-dreams",
        "is_capped": null,
        "sizeof_lyrics": 0,
        "video_featured": null,
        "streaming": 1,
        "has_lyrics": false,
        "private": null,
        "video_source_type": null,
        "alt_link": null,
        "lyrics": null,
        "has_info": false,
        "id":<PHONE_NUMBER>,
        "video_source_id": null,
        "track_num": 11
    }
],

There were no errors. The Discord embed indicated 12 songs and 11 were picked up by the bot. Would be interested to know if anyone else can repro this with this album link.
2020-09-29 19:48:03.181  INFO 4908 --- [  XNIO-1 task-1] l.server.player.AudioLoaderRestHandler   : Got request to load for identifier "https://deaddiskdrive.bandcamp.com/album/artificial-os"
2020-09-29 19:48:03.212  INFO 4908 --- [   XNIO-1 I/O-1] lavalink.server.io.SocketServer          : {"op": "voiceUpdate", "guildId": “redacted”, "sessionId": "redacted", "event": {"token": "redacted", "guild_id": "redacted", "endpoint": "us-east6.discord.media:443"}}
2020-09-29 19:48:04.416  INFO 4908 --- [ader-2-thread-1] lavalink.server.player.AudioLoader       : Loaded playlist Artificial OS
2020-09-29 19:48:04.494  INFO 4908 --- [   XNIO-1 I/O-1] lavalink.server.io.SocketServer          : {"op": "play", "guildId": "redacted", "track": "QAAAugIAD1Zhbml0eSBQcm9ncmFtcwAWQ29ycnVwdGVkIERhdGEgQ29ycOKEogAAAAAAAjlJADhodHRwczovL2RlYWRkaXNrZHJpdmUuYmFuZGNhbXAuY29tL3RyYWNrL3Zhbml0eS1wcm9ncmFtcwABADhodHRwczovL2RlYWRkaXNrZHJpdmUuYmFuZGNhbXAuY29tL3RyYWNrL3Zhbml0eS1wcm9ncmFtcwAIYmFuZGNhbXAAAAAAAAAAAA=="}

I think it is issue with bandcamp itself, because in this album total 11 songs, just compare what tracks in your bot queue and what tracks has on album

There were no errors. The Discord embed indicated 12 songs and 11 were picked up by the bot. Would be interested to know if anyone else can repro this with this album link.
Edit: I'm a Lavalink user but I'm using Devoxin's Lavaplayer fork @ 1.3.53 with this fix applied on top.
2020-09-29 19:48:03.181  INFO 4908 --- [  XNIO-1 task-1] l.server.player.AudioLoaderRestHandler   : Got request to load for identifier "https://deaddiskdrive.bandcamp.com/album/artificial-os"
2020-09-29 19:48:03.212  INFO 4908 --- [   XNIO-1 I/O-1] lavalink.server.io.SocketServer          : {"op": "voiceUpdate", "guildId": “redacted”, "sessionId": "redacted", "event": {"token": "redacted", "guild_id": "redacted", "endpoint": "us-east6.discord.media:443"}}
2020-09-29 19:48:04.416  INFO 4908 --- [ader-2-thread-1] lavalink.server.player.AudioLoader       : Loaded playlist Artificial OS
2020-09-29 19:48:04.494  INFO 4908 --- [   XNIO-1 I/O-1] lavalink.server.io.SocketServer          : {"op": "play", "guildId": "redacted", "track": "QAAAugIAD1Zhbml0eSBQcm9ncmFtcwAWQ29ycnVwdGVkIERhdGEgQ29ycOKEogAAAAAAAjlJADhodHRwczovL2RlYWRkaXNrZHJpdmUuYmFuZGNhbXAuY29tL3RyYWNrL3Zhbml0eS1wcm9ncmFtcwABADhodHRwczovL2RlYWRkaXNrZHJpdmUuYmFuZGNhbXAuY29tL3RyYWNrL3Zhbml0eS1wcm9ncmFtcwAIYmFuZGNhbXAAAAAAAAAAAA=="}

Hi.  I'm just a spectator here - a heavy user of Bandcamp who has used a couple of programs and web sites to convert many Bandcamp tracks to WAV files.   As of about a week ago, I am no longer able to produce large WAV files.   Someone told me it has something to do with "youtube-dl"...?  I am guessing it's a result of some changes made by people at Bandcamp....?     Is anyone else aware of this and has anyone tried to address this?   Either here, or in a different place (pull request?) on this site?   I am very new to this site and am having trouble navigating.  I'm just desperate to get this issue resolved.   Can anyone please help, or tell me where to go to find help?    Thank you!

@JDCourtney1969 You can try this https://github.com/Otiel/BandcampDownloader and if you have any issues with their program create issue in their repository

@JDCourtney1969 You can try this https://github.com/Otiel/BandcampDownloader and if you have any issues with their program create issue in their repository

@JDCourtney1969 You can try this https://github.com/Otiel/BandcampDownloader and if you have any issues with their program create issue in their repository

Thanks so much for the link!  However, my excitement was dashed when I learned that this is a Windows application.  I have a MacBook Pro laptop.....


Adjust latest-tag-button's size

From https://github.com/sindresorhus/refined-github/pull/3353#issuecomment-659260733
Before:
After:

The smaller size was on purpose

This class exists (or more precisely, is added) in the feature's first commit (https://github.com/sindresorhus/refined-github/pull/1049/files#diff-041e2c7f28122df0efbf5dbb6ee3c2adR22), in which I don't see any reason except matching GitHub's style.

https://github.com/sindresorhus/refined-github/pull/3221 by @FloEdelmann, in the very first post

Missed that one. But that PR is made when design update is in progress, do you still think it looks fine with different button size?

do you still think it looks fine with different button size?

I do; you can see how the buttons also become wider and the space on that line might be limited already

I will override it with the following style:
/* https://github.com/sindresorhus/refined-github/pull/3356 */
#branch-select-menu ~ .btn,
#branch-select-menu + .BtnGroup .btn,
#branch-select-menu ~ .flex-self-center .btn {
  padding: 5px 16px;
  font-size: 14px;
}

#branch-select-menu ~ .btn .octicon,
#branch-select-menu + .BtnGroup .octicon,
#branch-select-menu ~ .flex-self-center .octicon {
  vertical-align: text-bottom;
}


Recent Workspaces list broken with UNC paths and root of a drive

VSCode Version: compiled local from master branch
OS Version: Windows 10

Steps to Reproduce:

Open a folder and select the root of a partition drive
Open a network folder
Close the folder

Does this issue occur when all extensions are disabled?: Yes

Got this while I was trying to fix #48403
The was a similar problem in issue #38546

@aeschli you introduced the splitName so you would be the better one to review this.
Though I do agree that path.basename and path.dirname should do the thing for the welcome page.
@chrmarti also assigning to you since you own the welcome page
Feel free to assign back to me and I will just stop using splitPath here

I thought about putting a .replace(/[\/\\]$/, '') in the parameter of splitPath before calling it, but I didn't like it.


Update classifier core config file

PR Summary
Commit  36d989bff1848d529d9de3645063c93677ca21a1 renamed the classifier core config file. This PR adjusts sources to changes.

Thanks @emmanuel-ferdman !


Transpiler updates for optional registers.

Summary
Following #5504 updates transpiler and in-tree passes to support optional registers, and to prefer inspecting bits over registers where possible.
Details and comments
on-hold until #5504 .
Commits in this PR (without #5504, #5498 and #5486): https://github.com/Qiskit/qiskit-terra/pull/5515/files/51db5270a21a98ca408ad9eca470b715b92639d0..cdfd7ddbbe7542d949426b7c90a7ac723e202569
WIP:

[x] ~Skips test.python.compiler.test_transpiler.TestTranspile.test_wrong_initial_layout which raises a KeyError from Layout instead of the expected DAGCircuitError~ (Resolved by #5526 .)
[ ] ~Some cases where we build qubit_indices might be better as Layout.generate_trivial_layout~

Thanks for the update I think it LGTM. The one thing I think would be good to have before we merge is some testing of the passes without registers, especially for ones not in the default pipeline (like the hoare optimization pass).

Good idea, added in 3d745bb .


EH debugging: reload window or open project results in two reloads

VSCode Version: Insider
OS Version: macOS

Steps to Reproduce:

run Hello World extension from VS Code
in EH window reload window (e.g. 'Cmd-R') or open another project

Observe: EH reloads twice
VS Code stable does not show this behaviour.

@weinand I think this is what I reported in https://github.com/Microsoft/vscode/issues/14895
lets continue there


Some systems failed to build for Quicklisp dist

Building with SBCL 2.0.5 / ASDF 3.3.1 for quicklisp dist creation.
Trying to build commit id c1cf19290d87901aca1e8a90a46ec8c8d58d9b42
neural-classifier fails to build with the following error:
Unhandled SB-KERNEL:SIMPLE-PACKAGE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {1000A10083}>: Error finding package for symbol "*KNOWN-BACKENDS*":

neural-classifier/mnist fails to build with the following error:
Unhandled SB-KERNEL:SIMPLE-PACKAGE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {1000A10083}>: Error finding package for symbol "*KNOWN-BACKENDS*":

neural-classifier/tests fails to build with the following error:
Unhandled SB-KERNEL:SIMPLE-PACKAGE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {1000A10083}>: Error finding package for symbol "*KNOWN-BACKENDS*":

Full log here

Hi! This is probably due to recent incompatible update of rigetti/magicl . You may have to update it in the first place.

I'm already using the latest release of magicl and I still get this error.

I see. But the error is during compilation of magicl, not neural-classifier. Can you compiler magicl separately?
Missing magicl.backends package is in src/packages.lisp which belongs to magicl/core system. Maybe some fasl cache needs to be cleaned?

I think I can close this now :)


Docker fails to run containers

Describe the bug
docker fails to run containers since go has been updated to go1.20.6.
Issue is known upstream: https://github.com/moby/moby/issues/45935 (concise explanation in https://github.com/docker/cli/issues/4437#issuecomment-1637715017)
Steps To Reproduce
Steps to reproduce the behavior:

Update from the channel nixos-23.05-small
Try a docker run alpine sh. Fails with http: invalid Host header

Expected behavior
I can run containers on my server :sob:
Quickfix
While I'm waiting for a released fix on nixpkgs, how can I circumvent this? Easiest way seems to downgrade go version used to compile various docker binaries, but docker's https://github.com/nixOS/nixpkgs/blob/master/pkgs/applications/virtualization/docker/default.nix can't accept overrides as various packages are built in a let...in.
Is there an easy way to revert commit e5a213cdcef7cebd8c2e2e07767fc943370dfbb5 in nixpkgs?
Or is there any easy way to fix this?
Thanks y'all!
Notify maintainers
docker: @offlinehacker @tailhook @vdemeester @periklis @mikroskeem @maxeaubrey
go: @kalbasit @Mic92 @zowoq @qbit
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
- system: `"x86_64-linux"`
 - host os: `Linux 6.1.38, NixOS, 23.05 (Stoat), 23.05.2067.5f621193137`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `"nixos-23.05-small, nixos-unstable"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-to-downgrade-go-version-used-to-compile-docker-tools/30634/1

Same issue here, all my containers died on last auto upgrade.

Quickfix
While I'm waiting for a released fix on nixpkgs, how can I circumvent this? Easiest way seems to downgrade go version used to compile various docker binaries, but docker's https://github.com/nixOS/nixpkgs/blob/master/pkgs/applications/virtualization/docker/default.nix can't accept overrides as various packages are built in a let...in.
Is there an easy way to revert commit e5a213c in nixpkgs? Or is there any easy way to fix this?

You can also pin nixpkgs to a working commit.

I find it very strange that I'm the first one reporting this issue, as #242949 has been merged on the 12th.
Also I don't get why I already have it on my production system while nixpk.gs indicates it is not in production yet

That is tracking the master -> nixos-unstable path. The commit was backported to 23.05. It went through the staging branches first, that's why it took some time to show up in the stable branches. That's why it took so long to show up in production after the initial commit.

For anyone who don't want to rollbak, exec into docker container without docker exec:

docker inspect --format '{{.State.Pid}}' ${CONTAINER_NAME}
sudo nsenter --target ${PID} --mount --uts --ipc --net --pid
nsenter --target ${PID} --mount --uts --ipc --net --pid

Hello, I also have this problem. On one machine, I did a rollback as suggested by the author of the topic - everything works as it should. On another system, I upgraded to the latest version, but unfortunately nothing has changed:
~ # nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.38, NixOS, 23.05 (Stoat), 23.05.2143.fa793b06f56`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `"nixos-23.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

~ # docker --version
Docker version 20.10.25, build v20.10.25

~ # docker run alpine sh
http: invalid Host header

It is worth noting that all my docker-based services work fine on this machine, although I do not run them directly, but through docker-compose.
Does anyone reproduce this bug after the "fix" merge, or is it just me who is so "lucky"? To be honest, the breakdown of such an important basic component as docker surprised me very unpleasantly. I would like more stability and predictability of the software on the servers, but I don't really want to go back to debian :(

Same for me, not working with 23.05.2143.fa793b06f56 (docker 20.10.25)

I have updated my nixos-23.05 channel that is supposed to have received backported fix by now:
https://nixpk.gs/pr-tracker.html?pr=244310
However, I still get the same error. I may be missing something, though.
Currently, I am using the (not) so yummy hack to soothe the pain:
docker context create localhost --docker "host=ssh://localhost"

.., and then:
docker --context localhost run -it hello-world

I prefer replacing just docker client with working value like this:
environment.systemPackages =
let
pinnedPkgs = import(pkgs.fetchFromGitHub {
owner = "NixOS";
repo = "nixpkgs";
rev = "b6bbc53029a31f788ffed9ea2d459f0bb0f0fbfc";
sha256 = "sha256-JVFoTY3rs1uDHbh0llRb1BcTNx26fGSLSiPmjojT+KY=";
}) { config = config.nixpkgs.config; };
pinnedDocker = pkgs.runCommand "pinned-docker" {} ''
mkdir -p $out/bin
ln -s ${lib.getBin pinnedPkgs.docker}/bin/docker $out/bin/docker
'';
in
[
(pkgs.hiPrio pinnedDocker)
];

You can also use an overlay in your Nix configuration (/etc/NixOS/configuration.nix on NixOS) to pin the version of the docker derivation to an older revision of nixpkgs similar to the comment above:
  # pin docker to older nixpkgs: https://github.com/NixOS/nixpkgs/issues/244159
  nixpkgs.overlays = [
    (let
      pinnedPkgs = import(pkgs.fetchFromGitHub {
        owner = "NixOS";
        repo = "nixpkgs";
        rev = "b6bbc53029a31f788ffed9ea2d459f0bb0f0fbfc";
        sha256 = "sha256-JVFoTY3rs1uDHbh0llRb1BcTNx26fGSLSiPmjojT+KY=";
      }) {};
    in
    final: prev: {
      docker = pinnedPkgs.docker;
    })
  ];

+1. Still broken for me without the workaround of pinning to an older version.

I find it very strange that I'm the first one reporting this issue, as #242949 has been merged on the 12th. Also I don't get why I already have it on my production system while nixpk.gs indicates it is not in production yet

The linked PR is not in some channel yet, so the status of this hasn't changed and it doesn't help anyone if more people comment that they still have the problem. Please refrain from commenting that. If the PR has landed and the problem isn't fixed yet, please make you heard.

I prefer replacing just docker client with working value like this:

You rather want to use the option virtualisation.docker.package.

The linked PR is not in some channel yet, so the status of this hasn't changed and it doesn't help anyone if more people comment that they still have the problem. Please refrain from commenting that. If the PR has landed and the problem isn't fixed yet, please make you heard.

yes, it has landed, and the problem still isn't fixed. that's why people are commenting.
#244310 backported the change to 23.05. that change has made it to the release channel.
looking at the release-23.05 commit history, that backport went in as b8f0f72fce33bec8332cb2670d073dcc34684088 on July 19th.
on a test box running 23.05, which I just upgraded to make sure I've got the latest from the release channel:
$ nixos-version
23.05.2162.6da4bc6cb07 (Stoat)

6da4bc6cb07 went in to release-23.05 yesterday (the 21st). so by all accounts the version on my running system should include the backported patch. and yet:
$ docker run alpine sh
http: invalid Host header

With my solution, only docker client is replaced, not docker daemon.

This is still an  issue on 23.05

A patch was missed in the first workaround, see #245178

This seems fixed now (at least in the stable-small channel), so I'm closing this again :)

It's still broken for me on default channel nixos-23.05
kido@vivec ~> sudo nix-channel --list
nixos https://nixos.org/channels/nixos-23.05

kido@vivec ~> sudo nixos-rebuild switch --upgrade
unpacking channels...
building Nix...
building the system configuration...
activating the configuration...
setting up /etc...
reloading user units for kido...
setting up tmpfiles

kido@vivec ~> sudo docker run hello-world
http: invalid Host header

Should I wait some more?

You can track the fix in https://nixpk.gs/pr-tracker.html?pr=245179
As you can see it has not yet reached the 23.05 channel

Why are we downgrading go when this issue was already fixed in docker 24.0.5?

We are not downgrading go, we're just patching docker to work with the newer go. These patches will disappear when the docker package is upgraded later

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/docker-run-and-docker-exec-error/30848/6

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/docker-run-and-docker-exec-error/30848/7

Still broken for me on release-23.05, after a nix flake update (nixos.verison 23.05.20230727.9462344), even though it seems like this has been backported.
# docker compose up
[+] Building 0.0s (0/0)
http: invalid Host header

That is working for me (not using flake)
nixos-version: 23.05.2274.6dc93f0daec

Still broken for me on release-23.05, after a nix flake update (nixos.verison 23.05.20230727.9462344), even though it seems like this has been backported.
# docker compose up
[+] Building 0.0s (0/0)
http: invalid Host header

EDIT: Looks like it might be a docker vs docker compose issue, docker run hello-world works.

I observed the same. Docker compose exhibits the issue and Docker doesn’t…

For compose please see and test #245782.
Note the issue also likely exist for buildx, the corresponding upstream PR is https://github.com/docker/buildx/pull/1953
Feel free to take a look, I will not have time to deal with it before this week end.

https://github.com/NixOS/nixpkgs/pull/245782 works great, thank you!

Bumped into this issue today and my workaround was to build Docker with Go v.1.18 for reasons outlined in https://github.com/NixOS/nixpkgs/issues/245365#issuecomment-1656806031.
virtualization.docker.package = docker.override {
  buildGoPackage = pkgs.buildGo118Package;
}

Quickfix
1. Add this to `/etc/nixos/configuration.nix` to [pin nixpkgs](https://nix.dev/reference/pinning-nixpkgs) to just before the [offending commit](https://github.com/NixOS/nixpkgs/commit/e5a213cdcef7cebd8c2e2e07767fc943370dfbb5):

  nix.nixPath = [
    "nixpkgs=https://github.com/NixOS/nixpkgs/archive/b6bbc53029a31f788ffed9ea2d459f0bb0f0fbfc.tar.gz"
    "nixos-config=/etc/nixos/configuration.nix"
    "/nix/var/nix/profiles/per-user/root/channels"
  ];

2. Run `sudo nixos-rebuild switch` once. It updates the `NIX_PATH` for future invocations.

3. Run `sudo nixos-rebuild switch` a second time. It rebuilds your system taking into account the new `NIX_PATH`.

Just hope that downgrading all the other software updated since then won't break anything else crossed_fingers (It didn't on my server)

It looks dangerous. What are the consequences?

My version is still 23.05.2162.6da4bc6cb07 - how can I upgrade? (I'm newbie on NixOS)

That is working for me (not using flake) nixos-version: 23.05.2274.6dc93f0daec

My version is still 23.05.2162.6da4bc6cb07 - how can I upgrade? (I'm newbie on NixOS)

For compose please see and test #245782.
Note the issue also likely exist for buildx, the corresponding upstream PR is docker/buildx#1953 Feel free to take a look, I will not have time to deal with it before this week end.

Now that this has been merged into 23.05, I did a rebuild and this fixed my devcontainers, thank you for the patch.

That is working for me (not using flake) nixos-version: 23.05.2274.6dc93f0daec

My version is still 23.05.2162.6da4bc6cb07 - how can I upgrade? (I'm newbie on NixOS)

It depends on how you've set up your system, but I'm assuming you're not using flakes.
sudo nixos-rebuild switch --upgrade

You can also check how to update & manage channels in the NixOS Manual (for the inevitable 23.11 release)

It appears buildx is still affected by this.
❯ docker buildx build .
[+] Building 0.0s (0/0)
ERROR: http: invalid Host header

❯ nixos-version
23.05.20230801.bd836ac (Stoat)

❯ docker version
Client:
 Version:           20.10.25
 API version:       1.41
 Go version:        go1.20.6
 Git commit:        v20.10.25
 Built:             Thu Jan  1 00:00:00 1970
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server:
 Engine:
  Version:          20.10.23
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.20.4
  Git commit:       v20.10.23
  Built:            Tue Jan  1 00:00:00 1980
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.7.1
  GitCommit:        v1.7.1
 runc:
  Version:          1.1.4
  GitCommit:
 docker-init:
  Version:          0.19.0
  GitCommit:

That is working for me (not using flake) nixos-version: 23.05.2274.6dc93f0daec

My version is still 23.05.2162.6da4bc6cb07 - how can I upgrade? (I'm newbie on NixOS)

It worked for me:
sudo nix-channel --update
sudo nixos-rebuild switch

Confirmed that this is now resolved for me on nixos-unstable branch of nixpkgs at commit 18036c0be90f4e308ae3ebcab0e14aae0336fe42.

It appears buildx is still affected by this.

Same here using https://releases.nixos.org/nixos/23.05-small/nixos-23.05.2799.771b86d407c5,  released on 2023-08-14 06:44:13


No email to confirm delist from blocklist.

I followed the instructions to apply for being delisted from the blocklist.  We bought a dedicated IP from SendGrid 2 weeks ago.  Now we're seeing only hotmail/outlook emails bounce as blocked.  The IP we send from (SendGrid) is different from the IP we receive email at, which is a pop we setup so we can receive replies to the emails we send out.  I've tried twice to get the confirmation email and there is no sign of it in spam/trash or any other folder.
Is there another way to confirm our IP is clean & safe?
Sincerely,
<EMAIL_ADDRESS>50% of profit pledged to worthy causes!

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 390d461b-7fce-d4ac-1c90-97b7b81dc0c2
Version Independent ID: 9f8c7285-627f-13c6-1c7a-88fa7e14ed86
Content: Remove yourself from the blocked senders list - Office 365
Content Source: microsoft-365/security/office-365-security/use-the-delist-portal-to-remove-yourself-from-the-office-365-blocked-senders-lis.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@dzirnhelt Thank you for your feedback. It may take up to 24 hours or results can vary widely before restrictions are removed. After the IP address is removed from the blocked sender's list, email messages from that IP address will be delivered to recipients who use Microsoft 365. So, make sure you're confident that email sent from that IP address won't be abusive or malicious; otherwise, the IP address might be blocked again. If the restrictions are not removed, it is important you report this to the support team via the need help button on the admin center, so that they can investigate and help or escalate.
Hope this helps!
@yogkumgit There are no changes required in the document as such. This issue can be closed.
Thanks
Sri

Thanks very much Sri.
ᐧ
On Fri, Oct 9, 2020 at 12:17 PM Sriraman M S<EMAIL_ADDRESS>wrote:

@dzirnhelt https://github.com/dzirnhelt Thank you for your feedback. It
may take up to 24 hours or results can vary widely before restrictions are
removed. After the IP address is removed from the blocked sender's list,
email messages from that IP address will be delivered to recipients who use
Microsoft 365. So, make sure you're confident that email sent from that IP
address won't be abusive or malicious; otherwise, the IP address might be
blocked again. If the restrictions are not removed, it is important you
report this to the support team via the need help button on the admin
center, so that they can investigate and help or escalate.
Hope this helps!
@yogkumgit https://github.com/yogkumgit There are no changes required
in the document as such. This issue can be closed.
Thanks
Sri
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3092#issuecomment-706359412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC2MAD7VNBNMYH67MGQLRYLSJ5OU3ANCNFSM4SH4AGUQ
.

@msbemba Thank you very much for the contribution and sharing this explanation. @dzirnhelt Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


implement fix for hp-ux version parsing

What does this PR do?
Fixes #1474
Add an extra runtime property elastic.apm.disable_bootstrap_checks that allows to bypass JVM version check when it's value is set to true.
Checklist

[x] This is a bugfix

[ ] I have updated CHANGELOG.asciidoc
[x] I have added tests that would fail without this fix

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: [Pull request #1477 opened]

Start Time: 2020-11-06T14:15:29.425+0000

Duration: 27 min 56 sec

Test stats :test_tube:

Test
Results

Failed
1

Passed
1285

Skipped
3

Total
1289

Test errors
Expand to view the tests failures

Name: Tests / Smoke Tests 01 / testVersions[2.4.0] – co.elastic.apm.agent.kafka.KafkaClientVersionsIT

Age: 1 (took 30.011 sec)
Error Details:  Expecting: <false> to be equal to: <true> but was not.
Error Stacktrace:

org.opentest4j.AssertionFailedError:

Expecting:
<false>
to be equal to:
<true>
but was not.
   at co.elastic.apm.agent.kafka.KafkaClientVersionsIT.testVersions(KafkaClientVersionsIT.java:59)

Steps errors
Expand to view the steps failures

Name: Shell Script (took 7 min 2 sec) . View log details on here

Description: ./scripts/jenkins/smoketests-01.sh

Log output
Expand to view the last 100 lines of log output

[2020-11-06T14:42:20.860Z]
[2020-11-06T14:42:20.860Z]   _____          _
[2020-11-06T14:42:20.860Z]  / ____|        | |
[2020-11-06T14:42:20.860Z] | |     ___   __| | ___  ___ _____   __
[2020-11-06T14:42:20.860Z] | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
[2020-11-06T14:42:20.860Z] | |___| (_) | (_| |  __/ (_| (_) \ V /
[2020-11-06T14:42:20.860Z]  \_____\___/ \__,_|\___|\___\___/ \_/
[2020-11-06T14:42:20.860Z]                               Bash-20201104-3e6f2fc
[2020-11-06T14:42:20.861Z]
[2020-11-06T14:42:20.861Z]
[2020-11-06T14:42:20.861Z] ==> Jenkins CI detected.
[2020-11-06T14:42:20.861Z]     project root: .
[2020-11-06T14:42:20.861Z] --> token set from env
[2020-11-06T14:42:20.861Z]     Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
[2020-11-06T14:42:20.861Z] ==> Running gcov in . (disable via -X gcov)
[2020-11-06T14:42:20.861Z] ==> Python coveragepy not found
[2020-11-06T14:42:20.861Z] ==> Searching for coverage reports in:
[2020-11-06T14:42:20.861Z]     + .
[2020-11-06T14:42:21.027Z] + curl -sSLo codecov.sh https://codecov.io/bash
[2020-11-06T14:42:21.411Z] + bash codecov.sh
[2020-11-06T14:42:21.411Z]
[2020-11-06T14:42:21.411Z]   _____          _
[2020-11-06T14:42:21.411Z]  / ____|        | |
[2020-11-06T14:42:21.411Z] | |     ___   __| | ___  ___ _____   __
[2020-11-06T14:42:21.411Z] | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
[2020-11-06T14:42:21.411Z] | |___| (_) | (_| |  __/ (_| (_) \ V /
[2020-11-06T14:42:21.411Z]  \_____\___/ \__,_|\___|\___\___/ \_/
[2020-11-06T14:42:21.411Z]                               Bash-20201104-3e6f2fc
[2020-11-06T14:42:21.411Z]
[2020-11-06T14:42:21.411Z]
[2020-11-06T14:42:21.411Z] ==> Jenkins CI detected.
[2020-11-06T14:42:21.411Z]     project root: .
[2020-11-06T14:42:21.411Z] --> token set from env
[2020-11-06T14:42:21.412Z]     Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
[2020-11-06T14:42:21.412Z] ==> Running gcov in . (disable via -X gcov)
[2020-11-06T14:42:21.430Z]     -> Found 30 reports
[2020-11-06T14:42:21.430Z] ==> Detecting git/mercurial file structure
[2020-11-06T14:42:21.431Z] ==> Reading reports
[2020-11-06T14:42:21.431Z]     + ./apm-agent-core/target/site/jacoco/jacoco.xml bytes=1162843
[2020-11-06T14:42:21.431Z]     + ./apm-agent-plugin-sdk/target/site/jacoco/jacoco.xml bytes=21672
[2020-11-06T14:42:21.431Z]     + ./apm-agent-plugins/apm-jaxws-plugin/target/site/jacoco/jacoco.xml bytes=4575
[2020-11-06T14:42:21.431Z]     + ./apm-agent-plugins/apm-es-restclient-plugin/apm-es-restclient-plugin-common/target/site/jacoco/jacoco.xml bytes=13807
[2020-11-06T14:42:21.431Z]     + ./apm-agent-plugins/apm-es-restclient-plugin/apm-es-restclient-plugin-6_4/target/site/jacoco/jacoco.xml bytes=9808
[2020-11-06T14:42:21.431Z]     + ./apm-agent-plugins/apm-jmx-plugin/target/site/jacoco/jacoco.xml bytes=43084
[2020-11-06T14:42:21.432Z]     + ./apm-agent-plugins/apm-error-logging-plugin/target/site/jacoco/jacoco.xml bytes=9923
[2020-11-06T14:42:21.432Z]     + ./apm-agent-plugins/apm-java-concurrent-plugin/target/site/jacoco/jacoco.xml bytes=30509
[2020-11-06T14:42:21.432Z]     + ./apm-agent-plugins/apm-redis-plugin/apm-redis-common/target/site/jacoco/jacoco.xml bytes=2973
[2020-11-06T14:42:21.432Z]     + ./apm-agent-plugins/apm-redis-plugin/apm-jedis-plugin/target/site/jacoco/jacoco.xml bytes=7959
[2020-11-06T14:42:21.432Z]     + ./apm-agent-plugins/apm-redis-plugin/apm-lettuce-plugin/target/site/jacoco/jacoco.xml bytes=25198
[2020-11-06T14:42:21.432Z]     + ./apm-agent-plugins/apm-redis-plugin/apm-redisson-plugin/target/site/jacoco/jacoco.xml bytes=4968
[2020-11-06T14:42:21.432Z]     + ./apm-agent-plugins/apm-jdbc-plugin/target/site/jacoco/jacoco.xml bytes=90469
[2020-11-06T14:42:21.678Z] ==> Python coveragepy not found
[2020-11-06T14:42:21.678Z] ==> Searching for coverage reports in:
[2020-11-06T14:42:21.678Z]     + .
[2020-11-06T14:42:21.692Z]     + ./apm-agent-plugins/apm-grpc/apm-grpc-plugin/target/site/jacoco/jacoco.xml bytes=38140
[2020-11-06T14:42:21.692Z]     + ./apm-agent-plugins/apm-okhttp-plugin/target/site/jacoco/jacoco.xml bytes=34132
[2020-11-06T14:42:21.692Z]     + ./apm-agent-plugins/apm-jdk-httpclient-plugin/target/site/jacoco/jacoco.xml bytes=15313
[2020-11-06T14:42:21.692Z]     + ./apm-agent-plugins/apm-grails-plugin/target/site/jacoco/jacoco.xml bytes=6261
[2020-11-06T14:42:21.692Z]     + ./apm-agent-plugins/apm-jms-plugin/target/site/jacoco/jacoco.xml bytes=45220
[2020-11-06T14:42:21.692Z]     + ./apm-agent-plugins/apm-httpclient-core/target/site/jacoco/jacoco.xml bytes=5470
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-mongoclient-plugin/target/site/jacoco/jacoco.xml bytes=12863
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-servlet-plugin/target/site/jacoco/jacoco.xml bytes=77804
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-jaxrs-plugin/target/site/jacoco/jacoco.xml bytes=19262
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-apache-httpclient-plugin/target/site/jacoco/jacoco.xml bytes=41708
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-micrometer-plugin/target/site/jacoco/jacoco.xml bytes=20044
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-asynchttpclient-plugin/target/site/jacoco/jacoco.xml bytes=17685
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-hibernate-search-plugin/apm-hibernate-search-plugin-5_x/target/site/jacoco/jacoco.xml bytes=5904
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-hibernate-search-plugin/apm-hibernate-search-plugin-6_x/target/site/jacoco/jacoco.xml bytes=5802
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-profiling-plugin/target/site/jacoco/jacoco.xml bytes=335712
[2020-11-06T14:42:21.693Z]     + ./apm-agent-plugins/apm-log-correlation-plugin/target/site/jacoco/jacoco.xml bytes=14068
[2020-11-06T14:42:21.694Z]     + ./apm-agent-plugins/apm-api-plugin/target/site/jacoco/jacoco.xml bytes=84778
[2020-11-06T14:42:21.694Z] ==> Appending adjustments
[2020-11-06T14:42:21.694Z]     https://docs.codecov.io/docs/fixing-reports
[2020-11-06T14:42:22.406Z] --> No coverage report found.
[2020-11-06T14:42:22.406Z]     Please visit http://docs.codecov.io/docs/supported-languages
[2020-11-06T14:42:22.426Z]     -> No adjustments found
[2020-11-06T14:42:22.426Z] ==> Gzipping contents
[2020-11-06T14:42:22.426Z] ==> Uploading reports
[2020-11-06T14:42:22.426Z]     url: https://codecov.io
[2020-11-06T14:42:22.426Z]     query: branch=SylvainJuge%2Ffix-hpux-version-parsing&commit=f30119fcdcccb1b799e68150df9d35cf69789ed8&build=1&build_url=https%3A%2F%2Fapm-ci.elastic.co%2Fjob%2Fapm-agent-java%2Fjob%2Fapm-agent-java-mbp%2Fjob%2FPR-1477%2F1%2F&name=&tag=&slug=elastic%2Fapm-agent-java&service=jenkins&flags=&pr=1477&job=&cmd_args=
[2020-11-06T14:42:22.426Z] ->  Pinging Codecov
[2020-11-06T14:42:22.427Z] https://codecov.io/upload/v4?package=bash-20201104-3e6f2fc&token=secret&branch=SylvainJuge%2Ffix-hpux-version-parsing&commit=f30119fcdcccb1b799e68150df9d35cf69789ed8&build=1&build_url=https%3A%2F%2Fapm-ci.elastic.co%2Fjob%2Fapm-agent-java%2Fjob%2Fapm-agent-java-mbp%2Fjob%2FPR-1477%2F1%2F&name=&tag=&slug=elastic%2Fapm-agent-java&service=jenkins&flags=&pr=1477&job=&cmd_args=
[2020-11-06T14:42:22.763Z] Failed in branch Smoke Tests 02
[2020-11-06T14:42:23.365Z] ->  Uploading to
[2020-11-06T14:42:23.366Z] https://storage.googleapis.com/codecov/v4/raw/2020-11-06/9D96A76C16FC0F1A9E828BAAD4B02DD6/f30119fcdcccb1b799e68150df9d35cf69789ed8/db8a9e5c-1751-4884-810c-2d0cdb9666eb.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EQX6OZVJGHKK3633AAFGLBUCOOATRACRQRQF6HMSMLYUP6EAD6XSWAAY%2F20201106%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20201106T144223Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=8a87ccf8a1eabc817ed100ef1dab9bb235b42f73c81358f8d1cd732960268b27
[2020-11-06T14:42:23.366Z]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[2020-11-06T14:42:23.366Z]                                  Dload  Upload   Total   Spent    Left  Speed
[2020-11-06T14:42:23.625Z]
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  157k    0     0  100  157k      0   741k --:--:-- --:--:-- --:--:--  741k
[2020-11-06T14:42:23.625Z]     -> View reports at https://codecov.io/github/elastic/apm-agent-java/commit/f30119fcdcccb1b799e68150df9d35cf69789ed8
[2020-11-06T14:42:23.885Z] Failed in branch Unit Tests
[2020-11-06T14:42:24.129Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-11-06T14:42:24.211Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-11-06T14:42:24.246Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-11-06T14:42:24.559Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1477
[2020-11-06T14:42:24.650Z] [INFO] getVaultSecret: Getting secrets
[2020-11-06T14:42:24.762Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-11-06T14:42:25.655Z] + chmod 755 generate-build-data.sh
[2020-11-06T14:42:25.655Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1477/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1477/runs/1 FAILURE 1615963
[2020-11-06T14:42:25.905Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1477/runs/1/steps/?limit=10000 -o steps-info.json
[2020-11-06T14:42:26.456Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1477/runs/1/tests/?status=FAILED -o tests-errors.json

Codecov Report

Merging #1477 into master will increase coverage by 4.80%.
The diff coverage is 63.33%.

@@             Coverage Diff              @@
##             master    #1477      +/-   ##
============================================
+ Coverage     59.25%   64.05%   +4.80%
- Complexity       92     3101    +3009
============================================
  Files           392      305      -87
  Lines         17604    15225    -2379
  Branches       2437     2107     -330
============================================
- Hits          10431     9753     -678
+ Misses         6458     4804    -1654
+ Partials        715      668      -47

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/co/elastic/apm/agent/bci/AgentMain.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...java/co/elastic/apm/agent/util/JvmRuntimeInfo.java
81.81% <86.36%> (+3.38%)
25.00 <1.00> (+25.00)

...ic/apm/agent/profiler/collections/LongHashSet.java
16.66% <0.00%> (-1.59%)
12.00% <0.00%> (+12.00%)
:arrow_down:

...t/urlconnection/UrlConnectionPropertyAccessor.java

...nt/dubbo/AlibabaResponseFutureInstrumentation.java

.../springwebmvc/ExceptionHandlerInstrumentation.java

...stic/apm/agent/kafka/BaseKafkaInstrumentation.java

...tic/apm/agent/jsf/JsfLifecycleInstrumentation.java

...ava/co/elastic/apm/opentracing/ElasticApmTags.java

...pentracing/impl/ApmSpanBuilderInstrumentation.java

... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f3854...f30119f. Read the comment docs.


ci: Mac build takes forever

Usually, I would try out my changes in a dev environment and also wait for all ci checks to go green before pushing.
But the Mac build takes like 20-30 minutes....

Not really critical, but just wanted to know what makes it so slow in that platform?


Preinstall Git

Preinstall Git as in the following guide.

Skipping this enhancement, preinstallation of Git will be handled by the threeal-bot-workspace.


global search function for project managers

hi,
this is a cool project and tool, thanks!
is it possible to extend the search function to all projects for the role "project manager"?

With the current development version, you can search globally in all projects you are member.


Resolves #72 by overriding an img style

This commit fixes the issue where Google Translate bubbles were not displaying correctly. The issue is that img {max-width: 100%} was breaking the images in the bubble since everything inside the bubble is absolutely positioned (therefore 0px width for images).
I've added a CSS selector to override the img selector above it in cases where the Google Translate bubbles pop up. The best selector I could create was using the .gmnoprint class as it's one of the main containers of the images inside a Google Translate bubble.

Thanks so much for tackling this, Ben.
Fix looks good! :+1:


Update tdr-auth-utils to 0.0.200 in scala-steward-dependencies

About this PR
📦 Updates uk.gov.nationalarchives:tdr-auth-utils from 0.0.198 to 0.0.200
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "uk.gov.nationalarchives", artifactId = "tdr-auth-utils" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "uk.gov.nationalarchives", artifactId = "tdr-auth-utils" }
}]

labels: library-update, early-semver-major, semver-spec-patch, commit-count:1

Superseded by #67.


Facets: "free x-scale" has no effect on histogram.

See discussion: https://github.com/JetBrains/lets-plot/issues/955#issuecomment-2191425769
Two ways this issue can be fixed:

Introduce an option similar to "trim" in geom_density()  (in this case historgram can't be stacked)
Remove empty bins from the data (by default or optionally).

Coming in the next release :) : https://nbviewer.org/github/JetBrains/lets-plot/blob/master/docs/f-24e/geom_histogram_threshold.ipynb


Submit callback wrong execution order when no auto upload

Note: I'm using version 5.2.1.
I believe the on submit callback function should look like this:
_onSubmitCallbackSuccess: function(id, name) {
    this._onSubmit.apply(this, arguments);
    this._uploadData.setStatus(id, qq.status.SUBMITTED);
    this._onSubmitted.apply(this, arguments);

    if (this._options.autoUpload) {
        this._options.callbacks.onSubmitted.apply(this, arguments);
        this._uploadFile(id);
    }
    else {
        this._storeForLater(id);
        this._options.callbacks.onSubmitted.apply(this, arguments);
    }
}

Why? Because the file id needs to be stored in the _storeForLater array before executing the custom onSubmitted event handler. In my application I don't want to use the autoUpload as there are numerous factors important when deciding to start the upload. At the moment, my custom onSubmitted event handler triggers some algorithm to check if the upload can start. Part of that check is the following:
var filesWaiting = fineUploader.getUploads({
    status: ['submitted']
 });

 if(filesWaiting.length) {
      fineUploader.uploadStoredFiles();
 }

The problem now is that when the user selects one file, the filesWaiting array will contain one file, but as the _storeForLater array not yet, it throws an error that there are no files selected.

Sorry, I'm not sure what specific problem you are trying to work around. If you can provide a clear description of the problem followed by a series of steps required to reproduce along with any code required to reproduce, that would be great.

Well, basically it all comes down to the following question: Do you agree that if you get a result back from the following function
fineUploader.getUploads({
    status: ['submitted']
});

that you should then be able to call the following without getting an error message:
fineUploader.uploadStoredFiles();

Because if you agree with that, then I presented a case above where this is not like that, therefore a bug, and also provided a solution for that.

Check this JSFiddle:
http://jsfiddle.net/usegz49v/8/

Ah, I see. Then this appears to be a duplicate of #1106. Let me know if I've missed something.

Confirmed duplicate. Well, at least you have a suggestion for a fix then :)


feat:  email verification on signup

Pull Request Details
Description

Enhanced email verification process, including the ability to resend verification emails.
Added custom verfication page for redirect when user clicks on the verify link in the email
Added toast notifications for successful actions.
Updated authentication flow to include email verification checks.

Solution
For Github sign up
https://www.loom.com/share/41dc0293f5d2451e954f6e2cfc6df51f?sid=6f9b66b5-8881-4527-a45c-bf140d2bf6d1
For sign up using email and passowrd
https://www.loom.com/share/ca6662f806044ecc87d338a18c9f8d04?sid=fff69202-2139-424b-b705-6a71111b8dc8
For not email verified users
https://www.loom.com/share/47a679e7061b4bd2b6382fafc764c547?sid=383c6da4-9824-4973-bc1b-a55b6f877519
Fixes
#538
Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Refactoring
[ ] Other (specify): _______________

Summary
[Summarize the changes made in this PR.]
Screenshots (if applicable)
[If your changes include UI updates, provide screenshots to illustrate the changes.]
Additional Notes
configure the action url for the redirect to website for verification

Checklist

[x] I have read and followed the Pull Requests and Issues guidelines.
[ ] The code has been properly linted and formatted using npm run lint:fix and npm run format:fix.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, snapshots, and videos after making the changes.
[x] I have not borrowed code without disclosing it, if applicable.
[x] This pull request is not a Work In Progress (WIP), and only completed and tested changes are included.
[x] I have tested these changes locally.
[x] My code follows the project's style guidelines.
[ ] I have updated the documentation accordingly.
[x] This PR has a corresponding issue in the issue tracker.

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Introduced ResendEmailVerification and VerifyEmailPage components for enhanced email verification management.
Added routes for ResendEmailVerification and VerifyEmailPage.

Enhancements

Updated user authentication to include additional checks for email verification.
Improved GitHub sign-in process with better user information handling and email verification status updates.
Enhanced GithubAuthButton to ensure proper user reload and navigation flow.

Bug Fixes

Adjusted navigation behavior post-verification link sending to improve user experience.

Documentation

Added necessary import statements and updated logic for various components to support new features and enhancements.

@Ajen07, can you please add a recording on how the flow is going? Like if user signed up - which page does he land without verification? If he reloads or tries to goto dashboard without verification? - and last - if he verifies. You can use loom for recording.

@Ajen07, can you please add a recording on how the flow is going? Like if user signed up - which page does he land without verification? If he reloads or tries to goto dashboard without verification? - and last - if he verifies. You can use loom for recording.

okay I will do it

@pranshugupta54  I have added the recordings in the description . Let me know if any more changes are required ?

@Ajen07, how about using - https://ui.aceternity.com/components/background-beams - for designing those pages?

Why do we have 2 routes? resend-email-verification and user-email-verification?

It's gonna be much better if you could add comments to different functions - going to help future contributors

@Ajen07 could u check the reviews by coderabbit?

If you changed the design, can u please add new screenshots

This is the current background of the verification pages
https://www.loom.com/share/e18c2e3b92434bda8388e582fa744248?sid=17339117-1cf5-409c-a446-f917caa32bd4

This is the modified background of the verification pages.
https://www.loom.com/share/e18c2e3b92434bda8388e582fa744248?sid=17339117-1cf5-409c-a446-f917caa32bd4

@Ajen07, we don't really want a different background but the text could be improved or like button center etc. Please keep the background uniform like other screens.

@Ajen07, we don't really want a different background but the text could be improved or like button center etc. Please keep the background uniform like other screens.

But you suggested  for backgroud-beams  in a review . So, now only  design changes for text and buttons are required .

@Ajen07, we don't really want a different background but the text could be improved or like button center etc. Please keep the background uniform like other screens.

But you suggested for backgroud-beams in a review . So, now only design changes for text and buttons are required .

@Ajen07, oh sorry for the confusion. I actually meant the text design -> https://ui.aceternity.com/components/background-beams
Not the background but the text there

@Ajen07, please keep the buttons uniform for all those pages

This is the updated buttons

🚀 Congratulations on the successful PR merge! 🌟
Thank you for your valuable contribution! 🎉
Let's continue to make waves in open source. Share your achievement on social media and tag Digitomize to help spread the word.
Thank you for your dedication!
@all-contributors please add @Ajen07 for code
@holopin-bot @Ajen07 c-av


Add service to safe infrastructure

[ ] Mention the service in safe-infrastructure.
[ ] If wallet infra team adds support for the service in the client gateway we could setup the service also.

@hectorgomezv @fmrsabino It would be posible to add the price service as an alternative API for the cgw?
Ithink it could be useful so we can fallback if our provider does not support a network and we need to deploy the price service

I don't see any major downside to adding the Price Service as an alternative, it seems a good idea @Uxio0 🙂
Having that said, I would like to include some context:

It seems the main goal of having this service as an alternative is to cover the case where a network is not supported by our current token prices provider. I think that's a valid reason. Just for context, I would like to say that we implemented the CGW prices client having in mind that it should work without an API Key for getting the token prices: using it in safe-infrastructure with no API Key would also work and prices would be retrieved (the provider rate-limits its free tier, of course).
We dropped all the code related to rate conversions between fiat currencies (as our current provider does that job for us), and we also plan to cancel the subscription to the fiat rates provider we have been using in the past. I guess safe-price-service only gets USD prices, correct? If that's the case we need to either reconsider getting back the code and keep paying for the subscription, or either accept that when using safe-price-service as a fallback, only USD prices would be available, is that acceptable?

You are exposing 2 really good points @hectorgomezv . The idea for this service is not letting the logic of price calculation to be lost, and for the community to use and maintain this service. As it doesn't seem really straightforward to add support in the CGW for the reasons you are exposing, I wouldn't work on that unless:

A lot of users demands it
We need it for a network where our price provider is not working.

What do you think if we evaluate it in the future in case any of these conditions meet and I close this issue for now? (cc @moisses89 )


Updating pattern matching

I have been updating the pattern matching implementation and I figured it's best to write an issue for it.
https://github.com/bryanjos/elixirscript/pull/74
I'm replacing the pattern matching. There is a JavaScript library called funcy that can create pattern matching functions. I forked it here and updated it to suite the needs of the project and added some tests as well. I have been playing with the idea of writing a JavaScript pattern matching library influenced by it, but for now, this will due. The reason I wanted to create a new one is for making something that could be used for binding variables.
The good thing about adding this is it simplifies most of the implementations and I feel more confident that this will work better. I have updated most of the implementations except for the try expressions.The match? implementation needs to be updated as well.

Added this into 0.8.0


Consider making MeasureMap abstract.

Making MeasureMap abstract would allow us to optimize the implementation more easily.  It would also allow the stats implementation to access state that isn't exposed through the API.  These are the same reasons that we made TagContext abstract.

I made a PR that doesn't expose MeasureMap in the API: #676

Implemented in #676.


--require-hashes option does not work as with pip

so I was trying to install my requirements.txt with uv pip install --require-hashes requirements.txt
My file contains urls with hashes. Example: borgbackup @ https://3rdparty.s3.amazonaws.com/borgbackup-1.2.8-cp312-cp312-macosx_11_0_universal2.whl#sha256=aca0a62c0e359b7663ebd4ee65e7bf7cdcbaecc8a001838eb49e8c886948ae6d
But uv is complaining saying that there is no hash. Is this expected?

What does the requirements.txt contain exactly, in the above command?

Right now you need to do:
borgbackup @ https://3rdparty.s3.amazonaws.com/borgbackup-1.2.8-cp312-cp312-macosx_11_0_universal2.whl --hash sha256:aca0a62c0e359b7663ebd4ee65e7bf7cdcbaecc8a001838eb49e8c886948ae6d

But I thought we supported reading hashes from the fragment directly. I'll look into it.

Fixed in the next release.


Please bring back keepalive option

The keepalive option was recently removed in 91fcfec45640c9ac684fa1740c26d34fedd965a2. I would like to request that it be brought back because it is necessary to be able to run other tasks after the initial build is complete such as starting an Express server or watching other files with watch/chokidar.

Sorry, that I conflict with your usecase. I can see what you are needing this option for, but I'm not sure if it is the job of the webpack plugin to keep the grunt process alive. If you use the webpack plugin for watching grunt, or using dev-server it should stay alive, but for a simple normal run it isn't.
You could use grunt-keepalive or maybe the express plugin you use can keep the process alive.
I don't want to block this completely, but want to ensure it is not just there for non webpack related stuff which could be done with other plugins. More options also make the code and the option handling more complicated.
What do you think?

Thanks for listening to my situation. Based on your feedback, I think I should have been more clear about my use case. I actually don't want the webpack task to keep the grunt process alive.
With the keepalive option gone, now when watch is true or when using the webpack-dev-server task, it is as though keepalive is always true, but I actually want it to be false so that I can run other grunt tasks afterward. Here's a simplified version of my Gruntfile:
grunt.initConfig({
  webpack: {
    build: {
      // normal build
    },
  },

  'webpack-dev-server': {
    dev: {
      webpack: {
        // mostly the same as webpack:build
      },
      inline: true,
      // keepalive: false, // <- need this
    },
  },

  express: {
    // starts Express server in the background
  },

  chokidar: {
    express: { // restart Express when app, controllers, models, etc. change
      files: ['app.js', 'api/**/*.js'],
      tasks: 'express',
      options: {
        livereload: true,
        spawn: false,
      },
    },
  },
});

grunt.registerTask('build', ['webpack']);
grunt.registerTask('dev', ['webpack-dev-server', 'express', 'chokidar']);

Without being able to set keepalive: false, the grunt task will never get to the 'express' or 'chokidar' steps because the 'webpack-dev-server' step blocks the whole task.

Thank you! 😃


fixes issue#65

Should fix issue #65 with a new fancy config option. Now you can not only disable the recipes for netherite, but any item you enter into the config. Was not able to disable repair recipes due to certain circumstances (combining armor in crafting bench)
please check config on how to do it. Tested and works, enable and disable without any errors in config.
And unlike some config options it does not crash the plugin when putting in something wrong. ;) (Please don't test if this is true I only did a few basic checks)

We decided to go with CraftEnhance - a custom crafting plugin, rather than hand coding recipe changes. I appreciate the work you put into this though


About the bug of oauth2_auth_client_secret_jwt

func:oauth2_auth_client_secret_jwt
if ((auth->client_secret_jwt.client_id == NULL) ||
(auth->client_secret_jwt.jwk == NULL) ||
(auth->client_secret_jwt.aud = NULL))
goto end;
Correction：
auth->client_secret_jwt.aud == NULL
The affected branch is: master and liboauth2-1.1.1,Please check other branches

I don't follow. Can you provide an actual patch/PR that shows what you'd like to change and why?


D365 Business Central App & Azure functions

Hi,
Currently we are working on a D365 Business central app and we have logic running in azure function which is hosted in US region.
Just to give quick overview about our app, we help users maintain their contract and it is date sensitive.
For example: When user create a contract from Jan 1 2018 to Dec 31 2018 with monthly frequency, we create billing detail from jan 1 - jan 31 , feb 1 - feb 28 and soon. The logic to create the billing detail is written in azure function.
It works perfectly fine if we download BD docker image for US and region is US. (date format MM/dd/yyyy)
If we change the region (in business central) to English (united kingdom) or any other region where date format is DD/MM/YYYY it fails because Jan 31 2018 in DD/MM/YYYY format is 31/01/2018 and azure function is still considering it as MM/DD/YYYY (Don't know why..May be because Azure function is hosted in US region) and its erroring out.
How do we handle this situation. We don't want to duplicate the azure function for all the regions as it is redundant/duplication.
Do any one came across this situation and please suggest the right approach!!

Thank you for your request. We are currently setting up the process around handling of issues in this new GitHub repository and you should hence expect a short delay in the processing of this request. But we will be on your case shortly!

This GitHub repository is dedicated to handling issues with published apps and extensibility requests for the latest release of Business Central.
To get help on general questions please use one of the following resources:
Business Central Community
mibuso forum
Dynamics User Group


No warning or error count in airline

I'm using a very basic airline and ALE config, but don't get any counts in my airline. See the image below... This file actual has 2 errors and 5 warnings. The location window and gutter do show the errors and warnings, it's just airline that doesn't show them:

Airline config:
let g:airline_powerline_fonts = 1
let g:airline_theme = 'murmur'
let g:airline#extensions#whitespace#enabled = 1
let g:airline#extensions#default#layout = [
      \ [ 'a', 'b', 'c' ],
      \ [ 'x', 'y', 'z', 'error', 'warning' ]
      \ ]
call airline#parts#define_raw('go', '%#goStatuslineColor#%{go#statusline#Show()}%')
call airline#parts#define_condition('go', '&filetype=="go"')
let g:airline_section_x = airline#section#create(['go'])
function! s:AirlineInit()
  let g:airline_section_y = airline#section#create(['ffenc', ' %{strftime("%H:%M")}'])
endfunction
autocmd VimEnter * :call <SID>AirlineInit()

ALE config:
let g:ale_go_gometalinter_options = '
  \ --aggregate
  \ --fast
  \ --sort=line
  \ --vendor
  \ --vendored-linters
  \ --disable=gas
  \ --disable=goconst
  \ --disable=gocyclo
  \ '
let g:ale_linters = {'html': [], 'javascript': ['eslint'], 'go': ['gometalinter']}
let g:ale_set_highlights = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 1
let g:ale_sign_error = '✖'
let g:ale_sign_warning = '⚠'
let g:ale_warn_about_trailing_whitespace = 0

I did notice a couple of examples using the snippet below, but then I'm not using the airline extension right?
call airline#parts#define_function('ALE', 'ALEGetStatusLine')
call airline#parts#define_condition('ALE', 'exists("*ALEGetStatusLine")')
let g:airline_section_error = airline#section#create_right(['ALE'])

So did I miss anything? Do I have to config any additional things to make things work as expected?
Thanks!

You shouldn't have to do any of that. Remove all of the code you have for adding ALE to your airline status bar, and do this.
let g:airline#extensions#ale#enabled = 1

Then the built in airline extension will be used.

Thank for the quick response @w0rp! But any of what? I don't have that last part in my vim config, I just put it there for reference.
This being the part I do NOT have in my vim config:
call airline#parts#define_function('ALE', 'ALEGetStatusLine')
call airline#parts#define_condition('ALE', 'exists("*ALEGetStatusLine")')
let g:airline_section_error = airline#section#create_right(['ALE'])

The airline and ALE config is of course in there :wink:

The line above should enable it.

Well... It doesn't... And isn't that line the default? So I don't have to declare that myself right?

It's disabled by default, you have to enable it in your vimrc file. Then look at a file which has some problems. You should see some error or warning counts appear on the far right. Try removing any other configuration you have for airline, as that might be removing it.

Added the line, but nothing changed. Strange thing is that the docs say it is enabled by default and that this did work before for this exact same setup.
But somehow it just seems to be inconsistent. A while ago it suddenly switched the error and warning counts. But then an update later it was sorted again. And now this morning I updated my plugins again and now the count is gone.
So was the default changed very recently?

https://github.com/vim-airline/vim-airline/commit/6ab0098cedd35bc3edee69da8d57e14d98355104#diff-cbdfee73143fd6232683bc04739421a2 Hmm, it looks like someone recently went in there and messed it all up.
I'll create a pull request for airline.
I don't know why this "caching" was added. That's not needed at all.

Check, thanks!

Confirmed that after reverting the airline changes it works as expected again 👍

@svanharmelen Try it again with the latest version of airline. I convinced the author to remove the problematic caching code for now.

@w0rp works as expected again with the latest versions. Thanks!

Cool. :+1:


build: simplify Android build

We only need Android NDK to build quiche for Android platform.
Simply use rust image from Travis and install NDK.

It saved 30-40sec in android build time in Travis.


Use spring.config.import for env

We can use something like spring.config.import=optional:file:localhost.env[.properties] in the application.properties file
This is how you can import env variables into an application file using spring methods

This task was made in a pull request #114


Move favicon.ico  to accommodate Chrome

Chrome requests favicon.ico on every route change, but stops if the <link> for it occurs early enough in the page. Several other people have been running into this issue since at least February 2016.

I just signed the CLA. Is it just me, or are the CI failures unrelated to my change?

@thejohnfreeman it's unrelated, #4890 should fix the CI 👍

/cc @jeffposnick is this a thing?

It's not something that I've heard folks complain about. I'd recommend folks who can reproduce the behavior and believe it's a bug in Chrome to open an issue at https://crbug.com with details.
That being said, this seems like a harmless change to make in c-r-a in the meantime?


Update CONTRIBUTING to reflect latest changes in build and deployment

Update the CONTRIBUTING section to reflect the latest changes in building and deploying the dashboard into a cluster.

I typically just deploy the image directly onto the cluster by modifying the image field -- I guess since you remove it from the KfDef, this will manage it all via the makefile?
We'll have to update our steps when the KfDefs get swapped out for the new operator & CR.

You mean modifying the image field in the deployment right?
This method allows you to also deploy new resources if the manifest folder is changed, you can achieve the same result changing the repo reference in the kfdef spec to point at some PR. But with this method, you can even test changes without raising a PR.

@pnaik1 can you re-review it please?

/lgtm

@lucferbux  Can you take a look at the test , its failing

@pnaik1 don't worry, this is due to an issue in the cache, let me fix it


UI for Adding / Updating / Deleting videos

Should be able to both update the name of the video and the order of the videos

Most of this is done, the only things remaining are:

Deleting a video
A bug where the last video can't move up
Should really have drag / drop UI


Using named capturing groups in RegEx for replacement

Hello.
First I want to thank for this extension! I have a proposal to expand the expansion possibilities. In regular expressions can use named capture groups. The names of these groups could be used to replace the page title.

Hey @XelaNimed
Thanks for your feedback. The development is currently inactive.
Sorry but I'm not sure to later implement this (very) advanced feature.
Best

#84 also mentions trying to access regex capture groups


Epic: VS Code for the Web / GitHub Codespace MVP

A minimal set of high impact DevEx improvements the VS Code extension could bring.
### Tasks
- [ ] https://github.com/noir-lang/vscode-noir/issues/37
- [ ] https://github.com/noir-lang/vscode-noir/issues/10
- [ ] https://github.com/noir-lang/vscode-noir/issues/33

Would assign P-MEDIUM to this issue (if vscode-noir is monorepo'd into noir), as this could greatly improve UX for quick development, codebase review and learning Noir.

Closing as we can and already have examples on how to support GitHub Codespaces.


Range spec seq docs

Description
A few small changes involving RangeSpecSeq and friends, and a lot of higher level documentation for the entire iroh-bytes sync protocol.
Notes & open questions
Is this the right place for such docs? I mean, I like it. If it is close to the code it is least likely to become stale...
Change checklist

[x] Self-review.
[x] Documentation updates if relevant.
[x] Tests if relevant.

Note that some details like how exactly the errors work can only be properly documented once https://github.com/n0-computer/iroh/pull/1362 is merged...


[FLINK-2206] Fix incorrect counts of finished, canceled, and failed jobs in webinterface

The number of finished, canceled, and failed jobs is no longer bound by the size of the job archive and updated every 2 seconds.

Tested locally and works fine. +1

OK, will merge


"Regardless of the number of scaled-out instances, each app has a single inbound IP address"

This statement is not correct.
Or perhaps it is correct for web apps, but not for Functions Consumption/Elastic Premium plans?
I can supply an example of a function app that has 3 different inbound IP addresses (3 DNS 'A' records)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c32dd6f-050f-e3f7-569f-42b5efdf3918
Version Independent ID: 1b3c9880-c5fc-53b2-c8d5-04c5ed4c21b4
Content: Inbound/Outbound IP addresses - Azure App Service
Content Source: articles/app-service/overview-inbound-outbound-ips.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@ishepherd Thanks for the feedback! We are currently investigating and will update you shortly.

@ishepherd Thanks again for the feedback! Request you to provide screen shots on this to help you better on this.

Thanks @SnehaAgrawal-MSFT, sure, may I have an email address to send the screenshot privately?

@ishepherd Thanks for the reply. Could you please send an email to AzCommunity[at]Microsoft[dot]com referencing this issue, we would like to work closer with you on this matter.

@ishepherd just checking if you have chance to see previous response. Will now close this thread here. waiting for your mail here AzCommunity[at]Microsoft[dot]com.

Thanks @SnehaAgrawal-MSFT, emailing now.


compiler.Colset can't distinguish .a.b from .["a.b"]

@mccanne pointed out to me that I broke compiler.Colset's ability to distinguish .a.b (a top-level record named a with a field named b) from .["a.b"] (a top-level field named a.b) in #1845.

Maybe we can just get rid of compiler.Colset... it seems to have been added prematurely.

If Colset is used only by computeColumns, maybe we can just get rid of both as they're unused (looks like they were introduced prematurely).

In discussing this one with @mccanne he indicated the code related to this gone and so this issue is no longer relevant. He intends to add a final comment here and close it.

#1916 removed compiler.Colset.


Run linters from yarn scripts instead of github actions

Ideally also setup travis to run them on pull requests.

This is not necessary. Linters are already triggered from yarn scripts and the Lint workflow is already configured to be triggered on pull requests.

I was wrong regarding the linters being run from yarn scripts, as they're not. It would make sense adding them as yarn scripts to make it easier for people to run them if they're not using any editor extensions to do so.
Nevertheless, those yarn scripts shouldn't be used on the GitHub Actions Lint workflow, at least at for the moment, as right now it would force a full yarn install on each run.


Dev

Adding swagger spec for RemoteApp client

Hi @calexan, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (calebal). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@calexan - Please squash your git commits http://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

"host": "management.azure.net",
I have never seen this before. Usually the host is "management.azure.com". Is RemoteApp a special case ?

Line 21 remove empty line
Tabbing for entire document : 2 spaces. If you are using Visual Studio then set the tabs for JSON to 2 spaces and then CTrl + A, Ctrl + K + D

Are ActivateAccountBilling and UpdateAccount long running operations. If so then you need to add the extension x-ms-long-running: true. Please check all our extensions over here and apply them wherever applicable https://github.com/Azure/autorest/blob/master/Documentation/swagger-extensions.md

operation TemplateImage_GetTemplateImages needs x-ms-pageable extension

We prefer a naming convention of Noun_Verb for operationId. The noun becomes an operation group and the verb is the method under the operation group
Current Operation    -> Recommended Approach  --> This is how customers will call from generated client
Operations_GetAvailableOperations --> Operations_GetAvailable --> client.Operations.GetAvailable()
Account_GetAccountInfo   --> Account_Get -> client.Account.Get()
Account_ActivateAccountBilling --> Account_ActivateBilling  -> client.Account.ActivateBilling()
TemplateImage_GetTemplateImages --> TemplateImage_List --> client.TemplateImage.List()
TemplateImage_GetTemplateImage --> TemplateImage_Get --> client.TemplateImage.Get()

Operation Collection_ListResourceGroupCollections misses the definition of resourceGroupName path paameter

Please make sure that all the description properties are well documented. There is an ongoing project to turn the swagger spec into API reference docs. The description will also turn into the documentation of your generated client. So please make sure you update all your descriptions.

Collection_GetPublishedApp missing resourceGroupName parameter

@amarzavery
Get_TemplateImages isn't pageable, we restrict the number of template images they can have to ~12 or so.
ActivateBilling and UpdateAccount are not long running operations.

@calexan - I understand that Get_TemplateImages isn't pageable. However, you can add the extension with explicitly specifying nextLink: null in the extension. StorageManagement does the same thing. They only provide one page of storage accounts. The benefit is that you get a better client side API.
Take a look at the storage spec over here: https://github.com/Azure/azure-rest-api-specs/blob/master/arm-storage/2015-06-15/swagger/storage.json#L299
and the corresponding code in C#
https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/src/ResourceManagement/Storage/Microsoft.Azure.Management.Storage/Generated/StorageAccountsOperations.cs#L1246
public async Task<AzureOperationResponse<IEnumerable<StorageAccount>>> ListWithHttpMessagesAsync(Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));

It gives you an IEnumerable of StorageAccount objects.
//basically we flatten the value property and directly give you the array of desired objects.

@amarzavery
Thanks for the tip, you should find the spec updated with it.


Edited chips do not load IO pin wire type correctly.

IO pins for viewed chips are always Simple, regardless of what the actual chip has. Loaded chips in the chip selector still load correctly, it's only during viewing and resaving that issues arise.
Pins can be changed back to their correct values before updating designs to preserve correctness, but resaving chips with invalid wire connections is possible.

Fixed in #59


Add Analytical Principle Code to MP System Component  [Backend]

MATS/GNP is adding a new column to the camdecmps.component table called analytical_principle_cd which will reference a new analytical_principle_code table in camdecmpsmd schema. This file will need to be added to the monitor plan system component screen where we can view/add/edit a system component (part of the base component table).

[x] add new code table (tech team)
[x] add new field to component table (tech team)
[x] update monitor plan schema component section to add new property
[x] update monitor plan api to accept new property import/export/add/edit

Private Zenhub Image

Private Zenhub Image

Private Zenhub Image

Updates have been completed


completion server doesn't recover after putting vim into the background

repro:

open vim in shell with fsharp file
run a long running command, say :!dotnet run
Ctrl-C to end the command
queue a bunch of broken pipe errors

We probably need to try to restart the completion  server on failures. IT's been a long time coming.

closing as I'd got that wrong.


chore(deps): Use googleapis from the Bazel Central Registry.

Most of the patches are already present in the BCR module.

This change is

/gcbrun

This seems like a good cleanup, but I am not sure we want to wait for BCR in order to update the commit SHA of googleapis we are pinned to.

Thanks, I guess this is also why some of the tests are failing. Let me close this then.


Create a start page

Add useFirstPageAsStartPage: boolean (false by default) property to the survey.
A user will not be able to return on this page. It will not be count as a first page.
The navigation button for this page, will be name as "Start Survey".

Set this property to true:
survey.firstPageIsStarted = true;


[BUG] v2.0.2-folia Cannot work on 1.20.4

Here is logs, is that truly cannot support 1.20.4? If that's ture, I suppose to downgrade plugin

If it is old Folia build you have to use Backuper-2.0.2, not Folia edition

Does it work now?

Thanks for your report


parser or bouncer not functional for reference: pam_unix(sshd:auth): authentication failure

Hello,
I’m new on crowdsec
I have a problem with parser ssh because it does not detect multiple attempts intrusions and connection testing on my server
Here are the log references that appear several times per second with multiple IPs or users and that are not blocked by crowdsec:par crowdsec :
pam_unix(sshd:auth): authentication failure; logname= uid=0 euid=0 tty=ssh ruser= rhost=<IP_ADDRESS> user=root
pam_unix(sshd:auth): authentication failure; logname= uid=0 euid=0 tty=ssh ruser= rhost=<IP_ADDRESS> user=root
pam_unix(sshd:auth): authentication failure; logname= uid=0 euid=0 tty=ssh ruser= rhost=<IP_ADDRESS>
Etc…
Like making all detect and block properly please.
Have a good day

For additional info crowdsec works well for some log reference other than the one previously mentioned because with the following command the result indicates a lot of ban already performed or in progress but not on the references of parser containing pam_unix(sshd:auth): authentication failure; apparently.
sudo cscli decisions list
|  ID   |  SOURCE  |    SCOPE:VALUE     |          REASON           | ACTION | COUNTRY |           AS           | EVENTS |     EXPIRATION      | ALERT ID |
| 41213 | crowdsec | Ip:<IP_ADDRESS>   | crowdsecurity/ssh-bf      | ban    | NL      |                        |      6 | 23h59m26.651560831s |     3680 |

Si j'utilise la commande qui permet de rajouter la règle avant la règle ouverture ssh
sudo ufw insert 1 deny from <IP_ADDRESS>/16
cela block correctement les IPs en cause et arrête les tentatives

sorry error closed

Hi @vincent1890,
The logs you pasted are properly parsed.
Following what you said, I think you didn't install a bouncer, Is it the case ?


Implement Camera-Lidar sensor model

We want to add constraints between camera keypoints and lidar maps.
We can most likely use the singleton LidarMap class in beam_slam_common, but we will likely need a way to pass the keypoints from the VIO to this sensor model. We can simply making a topic that the VIO publishes to, then this sensor model will just subscribe to that topic and also get an instance of the lidar map. We could investigate other ways to do this without having to publish the keypoints, (such as using the graph) but it also likely won't be much overhead and the lidar maps lag behind the vision anyways so it's not bad if there's a bit of a delay.
This was my idea for doing the correspondence search:

For each keyframe, do:

For each scan in LidarMap, do:

For each point in scan, do:

Project point into camera frame
Store point if it lands within FOV, and its associated timestamp

For each keypoint, do:

Find nearest 3 neighbors in lidar map
Consistency check: check that there's no occlusion issues (see LVI SAM or SuperOdometry - can't remember which one)
Take closest point as correspondence
Take 3 points as corresponding plane
Add point to plane constraint, or optionally point to point, or point to line

Subscribe to visual measurements
For each visual measurement, try to get the pose from the graph for it (wait until this can be achieved)
Once it the pose can be retrieved, transform the current lidar map into frame
Add point to plane constraints between visual landmarks and lidar cloud
a. project lidar into image, for each landmark get nearest 3 points, compute plane


Does TrustKit support pinning domains used in an SFSafariViewController?

I was originally going to report this as a bug, but upon further investigation it's probably more of a question.
I am using the AppAuth library to implement OpenID Connect flow for authorization. All of this is done in a web browser flow from within the app. On iOS 10 it uses SFSafariViewController, and on iOS 11 it uses SFAuthenticationSession (which I think might use SFSafariViewController under the hood).
AppAuth does a series of requests to sso.mycompany.com within a SFSafariViewController, but none of the requests get pinned. I am using swizzling of network delegates, which I was hoping would work here.
Here's my config:
let trustKitConfig: [String: Any] = [kTSKSwizzleNetworkDelegates: true,
                                     kTSKPinnedDomains: ["api.mycompany.com": [kTSKIncludeSubdomains: false,
                                                                               kTSKEnforcePinning: true,
                                                                               kTSKPublicKeyAlgorithms: [kTSKAlgorithmRsa2048],
                                                                               kTSKPublicKeyHashes: [apiServerPublicKeyHash, backupKeyHash]],
                                                         "sso.mycompany.com": [kTSKIncludeSubdomains: false,
                                                                               kTSKEnforcePinning: true,
                                                                               kTSKPublicKeyAlgorithms: [kTSKAlgorithmRsa2048],
                                                                               kTSKPublicKeyHashes: [ssoServerPublicKeyHash, backupKeyHash]]]]

TrustKit.initSharedInstance(withConfiguration: trustKitConfig)

I tried a direct GET request to sso.solium.com via AFNetworking and it does get pinned, as expected.
I'm guessing there is probably no way to hook into the auth challenges there, and maybe SFSafariViewController is using different networking requests under the hood so they don't get affected by kTSKSwizzleNetworkDelegates?
Thank you!

Hello,
You guessed right: there is no way to do any SSL pinning in SFSafariViewController, for two reasons:

The SFSafariViewController class does not provide any API for customizing SSL validation and handling authentication challenges.
When used, the SFSafariViewController is actually run in a separate process and the app's code has no access to it at all. Hence swizzling does not affect the SFSafariViewController as it only happens in the app's process.

Hope this clarifies...

Lastly, the only way to do pinning in a webview is to use WKWebView.

Thanks for clarifying, I appreciate it!

I've also been looking into this and found the following open issue. https://github.com/openid/AppAuth-iOS/issues/324 . I'm not an ios developer, but it looks like it may be possible to pin here?

@sattaman It only allows pinning for non-SFSafariViewController connections.

@nabla-c0d3: As of now can we consider it as there is not an option to pin the certificate through appAuth in iOS?


Enable multi-cluster for ns scheduler

# github.com/kcp-dev/kcp/pkg/reconciler/namespace [github.com/kcp-dev/kcp/pkg/reconciler/namespace.test]
Error: pkg/reconciler/namespace/namespace_test.go:119:5: cannot use dynClient (type *"k8s.io/client-go/dynamic/fake".FakeDynamicClient) as type dynamic.ClusterInterface in field value:
	*"k8s.io/client-go/dynamic/fake".FakeDynamicClient does not implement dynamic.ClusterInterface (missing Cluster method)
Error: pkg/reconciler/namespace/namespace_test.go:193:5: unknown field 'namespaceClient' in struct literal of type Controller

👍 re test compilation failures. I'm waiting to rebase on top of #428 before I tackle them.

@ncdc #428 has merged.

Thanks! I'll maybe get to it tonight, or Monday

@marun yes, thanks, will fix next!

cluster/scheduler e2e updated (bonus: it found a bug in my code!)

@ncdc What (if any) change is suggested for the namespace scheduler e2e test to validate scheduling across more than one workspace?

LGTM


[FEATURE] TSX support?

Does this library work with tsx? https://github.com/privatenumber/tsx
Which is effectively the successor of ts-node

I assume this is why the lib doesn't work. Usage of Assert<> doesn't appear to transpile anything.

Looks like tsx uses esbuild, support for esbuild will come really soon!

Really looking for this too!


Add FluxCD Helm Controller v0.21.0

What this PR does / why we need it
Releasing v0.21.0 of fluxcd-helm-controller
Adding latest version v0.21.0 of fluxcd-helm-controller compatible with source-controller latest version
Describe testing done for PR
Create a kind cluster and attach it to TMC.
Submit the metadata.yaml and 0.21.0/package.yaml files
Install the package using the tanzu cli
tanzu package install fluxcd-helm-controller -p helm-controller.fluxcd.community.tanzu.vmware.com -v 0.21.0
/ Installing package 'helm-controller.fluxcd.community.tanzu.vmware.com'
| Getting package metadata for 'helm-controller.fluxcd.community.tanzu.vmware.com'
| Creating service account 'fluxcd-helm-controller-default-sa'
| Creating cluster admin role 'fluxcd-helm-controller-default-cluster-role'
| Creating cluster role binding 'fluxcd-helm-controller-default-cluster-rolebinding'
| Creating package resource
/ Waiting for 'PackageInstall' reconciliation for 'fluxcd-helm-controller'
\ 'PackageInstall' resource install status: Reconciling
Added installed package 'fluxcd-helm-controller'
Added installed package 'fluxcd-helm-controller'

@seemiller I am unable to merge this PR. All checks are passed but still it shows "Some checks haven't completed yet".


Updated version in bower.json, component.json and package.json, refs #56

Solved the version mismatch between the declared and resolved one.

LGTM