search router polish

Details

This pr fixes following problems mentioned in https://github.com/Expensify/App/issues/50250:

parsing error with special characters
amount display value in cents
improve performance of filter validation
fix reordering of standard filters
Using the router  and putting a link removes the link for the search results

Fixed Issues

https://github.com/Expensify/App/issues/50250
https://github.com/Expensify/App/issues/50988
PROPOSAL:
Tests

Open Search Page

Enter custom search query with amount

Verify that filters except default filters and free text don't change order

Verify that amount filter is not displayed in cents

Verify that special characters e.g. emoji can be used in search input

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open Search Page

Enter custom search query with amount

Verify that filters except default filters and free text don't change order

Verify that amount filter is not displayed in cents

Verify that special characters e.g. emoji can be used in search input

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/9924d6ff-a062-409a-8ac6-a8754440c4be

Android: mWeb Chrome

iOS: Native

https://github.com/user-attachments/assets/69e28171-c633-46e9-8df6-fd15632eca0e

iOS: mWeb Safari

https://github.com/user-attachments/assets/3a7b25f8-f9b1-46b4-bc4b-e1597054a12e

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/7d7c333d-722a-402c-a6d7-38377d8f8ef8

MacOS: Desktop

@rayane-djouah I am not sure why but no reviewer has been assigned to this pr. You have reviewed https://github.com/Expensify/App/pull/49838 and I think you can review this one as a follow up pr to https://github.com/Expensify/App/pull/49838.

Yes, the link dropping issue was a parsing problem. When you pasted the link parsing error occurred and router navigated to search page with the last query without error.

@289Adam289 we have conflicts and some tests are failing

We also have conflicts now

@rayane-djouah I fixed both bugs and resolved conflicts

all yours @rayane-djouah

I gave it a try and I think it works. Unit tests pass but further testing is needed because I've heavily changed important rules. cc @rayane-djouah

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Hi! I haven't confirmed yet but it seems like this is related to https://github.com/Expensify/App/issues/51661 - can you take a quick look?


Always allow data-uri on custom logo

Is your feature request related to a problem? Please describe.
Please allow the usage of the data-uri format in the custom logo configuration. It is already possible to use this format, if you set it with the --logo flag on the very first setup. Then the URL-format check is not executed and the value successfully set. Later in the UI you can't choose that format anymore, as it's not a "real" url. Nevertheless the data-uri is a valid format for images in HTML an it is also rendered correctly if used with the workaround.
Example:

Data-URI used:
data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4NCjwhLS0gR2VuZXJhdG9yOiBBZG9iZSBJbGx1c3RyYXRvciAyMy4wLjEsIFNWRyBFeHBvcnQgUGx1Zy1JbiAuIFNWRyBWZXJzaW9uOiA2LjAwIEJ1aWxkIDApICAtLT4NCjxzdmcgdmVyc2lvbj0iMS4xIiBpZD0iTGF5ZXJfMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayIgeD0iMHB4IiB5PSIwcHgiDQoJIHZpZXdCb3g9IjAgMCA4MCA4MCIgc3R5bGU9ImVuYWJsZS1iYWNrZ3JvdW5kOm5ldyAwIDAgODAgODA7IiB4bWw6c3BhY2U9InByZXNlcnZlIj4NCjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+DQoJLnN0MHtmaWxsOiNFRDM4MzM7fQ0KPC9zdHlsZT4NCjxnPg0KCTxjaXJjbGUgY2xhc3M9InN0MCIgY3g9IjQwIiBjeT0iNDAiIHI9IjMyIi8+DQo8L2c+DQo8L3N2Zz4NCg==
P.S: On custom logos for templates, this format could already be used

Just add a check if payload.LogoURL starts with 'data:' here:
	if payload.LogoURL != nil && *payload.LogoURL != "" && !govalidator.IsURL(*payload.LogoURL) {
		return errors.New("Invalid logo URL. Must correspond to a valid URL format")
	}

portainer/api/http/handler/settings/settings_update.go

This would be a great feature, as it wouldn’t need to access an additional URL for loading the logo and kinda stores it locally.

Would there be any security implications?

I think there are fewer security issues than using an external url for the image

We would need to validate the format of the data URI is correct per https://datatracker.ietf.org/doc/html/rfc2397


sast: Add sast-unicode-check task for testing

Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@tkdchen I want to test this task, do you know how to run the CI? thanks!

Missing task/task-name/OWNERS as well.

updated, added OWNERS, thanks

@hanchuntao Please also include a reference to https://issues.redhat.com/browse/OSH-739 in the commit message.

@hanchuntao Please rename the task to sast-unicode-check as stated in the summary of OSH-739.

updated

@hanchuntao Please also include a reference to https://issues.redhat.com/browse/OSH-739 in the commit message.

updated

@hanchuntao Please close all review threads that have been resolved.  I do not have privileges to close them myself.

I did the changes and I am testing them. The pipeline is right now full and the tasks are not being scheduled

@hanchuntao The code changes look good. I believe you tested the latest revision.

yes, I have tested the latest version and fixed all of the lint issues, now waiting for Konflux team review

/ok-to-test

/ok-to-test

/ok-to-test

Failure snippet:
task check-task-pipeline-repo-existence has the status "Failed":
Please contact Build team - #forum-stonesoup-build that the missing repos should be created in:
- https://quay.io/organization/redhat-appstudio-tekton-catalog
- https://quay.io/organization/konflux-ci

@dheerajodha, do you know how to fix this issue in the CI pipeline?

/retest

@dheerajodha, do you know how to fix this issue in the CI pipeline?

The Konflux build PLR has passed now, @tkdchen has opened a PR that fixes the 1 final failing PR check. It shouldn't take long for that PR to get merged, and then I'll merge this PR after that if you don't mind.

@dheerajodha Because all of the checks passed, what should we do next? Can somebody with write access merge the code?

@hanchuntao Are you sure you tested the changes before they were merged?
I do not think this could work.  See https://github.com/konflux-ci/build-definitions/pull/1524/commits/82046fa03133b5d5f1bdcaf33b0ba56881a18a07 for details.

@hanchuntao Are you sure you tested the changes before they were merged?
I do not think this could work. See 82046fa for details.

I tested all of the changes. I don't know what happened, let me check it first, thanks


NIFI-9205 - Update prioritizer configuration

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
This PR updates the prioritizers configuration on the UI. To test in the UI, create a flow and open the connections configurations. In the settings tab, try the following:

select a prioritizer by double clicking a prioritizer from the available list
remove a selected prioritizer, by clicking the "x" icon
the available prioritizers list is now an ordered list and the order cannot be rearranged

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Reviewing now...

Reviewing...


[Fix]: code weights for anchor3d_head

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi!
@lliuz
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤


Make project more modular and easier to use

Dicom, pynetdicom, dicom-rs I have been trying to understand and use them with varying degrees of success for 1 week, so as you can see my experience is limited, but I have noticed that it is quite difficult to use this library).
However, there are a few things that I found while trying to implement worklist(only find), so that for scheduled examinations from a given day I could send patient data(name, id, date of birth, etc.) to another application via e.g. Redis.
Apparently, I could try to parse the string output from findscu, but it would not look very good(additionally worklist not supported in this project).

There is no way to use imported code from findscu in external projects. I'm forced to copy almost the whole code from project and modify parts of it.
E.g. functions find_req_command, parse_queries, term_to_element could go into some more general module so that they could be used without having to copy all that code.

The code in the run function in the findscu tool has about 200 lines of code and a similar implementation in python has with imports ~60 lines(code below) so it making much harder to understand entire app.
Python code is more forgiving and ignores a mass of errors but is also much easier to use.
E.g. the code that creates commands to send and sends them should be split into pieces and generalized.

https://github.com/Enet4/dicom-rs/blob/1ab8b09c9d76c10caeb0890937cf4983b88e8467/findscu/src/main.rs#L207-L243
import sys
from builtins import *
from pydantic import BaseModel
from pynetdicom import (
    AE,
    BasicWorklistManagementPresentationContexts,
    QueryRetrievePresentationContexts,
)
from pynetdicom.apps.common import create_dataset
from pynetdicom.sop_class import ModalityWorklistInformationFind

from typing import Optional

class Temp(BaseModel):
    addr = '<IP_ADDRESS>'
    port = 4242
    keyword = [
        'PatientID',
        'PatientName',
        'PatientBirthDate',
        'PatientSex',
        'ScheduledProcedureStepSequence[0].ScheduledStationAETitle',
        'ScheduledProcedureStepSequence[0].ScheduledProcedureStepStartDate=19951015',
        'ScheduledProcedureStepSequence[0].ScheduledProcedureStepStartTime'

    ]
    file: Optional[str] = None

def main():
    args = Temp()

    identifier = create_dataset(args, None)
    ae = AE()

    ae.requested_contexts = QueryRetrievePresentationContexts + BasicWorklistManagementPresentationContexts

    query_model = ModalityWorklistInformationFind

    assoc = ae.associate(
        args.addr,
        args.port,
    )
    if assoc.is_established:
        responses = assoc.send_c_find(identifier, query_model)
        for (status, rsp_identifier) in responses:
            if status and status.Status in [0xFF00, 0xFF01]:
                print(status)
                print(rsp_identifier)
                print(f"RRRR    {rsp_identifier.PatientID}")

        # Release the association
        assoc.release()
    else:
        sys.exit(1)

if __name__ == "__main__":
    main()

Thank you for your well informed feedback, @qarmin! I can comment on the two points in particular, but the short version is that I not only agree that the library APIs can be extended with better abstractions for building high level DICOM software, it is also in my plans to have them in the project.

dicom-findscu currently only exists as a command line tool, but it definitely makes sense for it to also incorporate a library. dicom-dump went through the process of starting out only as a tool, and now it is also a library (that is even used in findscu!). One of the reasons for this is that such a library would depend on the constructs for building full-fleshed SCUs and SCPs, which are still in their infancy.
A good portion of the code bloat found in the tool is due to having to work with lower level abstractions. Creating a DICOM object representing the command needs to be done manually (including the command group length, which admittedly is an error-prone process) and encoded into a PDU, so that it can be sent through the client association. This appears to have been better streamlined in Pynetdicom, which already offers common presentation contexts by name and a function to turn command-line arguments into data sets.
Not having to wait for the aforementioned abstractions for creating DICOM network application entities meant that the project could have a proof of concept sooner, and from which further work and design decisions could be made. With that said, a better direction for developers to embed SCUs in their own software should indeed be made moving forward.

This does not quite have to do with the lack of modularity in the project, but with missing pieces in these modules which need time and effort to develop. I have not had much of these two lately, and attracting contributors to close these tasks is one of the open challenges, but we will get there! I can try to split the feedback into separate issues in the meantime. See also the project roadmap.

Hello,
As I am using dicom-rs for FindScu and FindSCP myself, I will contribute
this part of higher level API in the future.
Unfortunately, contributing a piece of good code takes much more time than
baking together some thing that works for my private project. So it might
take some time.
The FindScu client is almost ready.
Juraj Mláka
Dňa pi 2. 6. 2023, 13:28 Eduardo Pinho @.***>
napísal(a):

Thank you for your well informed feedback, @qarmin
https://github.com/qarmin! I can comment on the two points in
particular, but the short version is that I not only agree that the library
APIs can be extended with better abstractions for building high level DICOM
software, it is also in my plans to have them in the project.

dicom-findscu currently only exists as a command line tool, but it
definitely makes sense for it to also incorporate a library. dicom-dump
went through the process of starting out only as a tool, and now it is also
a library (that is even used in findscu!). One of the reasons for this
is that such a library would depend on the constructs for building
full-fleshed SCUs and SCPs, which are still in their infancy.
A good portion of the code bloat found in the tool is due to having
to work with lower level abstractions. Creating a DICOM object representing
the command needs to be done manually (including the command group length,
which admittedly is an error-prone process) and encoded into a PDU, so that
it can be sent through the client association. This appears to have been
better streamlined in Pynetdicom, which already offers common presentation
contexts by name and a function to turn command-line arguments into data
sets.
Not having to wait for the aforementioned abstractions for creating
DICOM network application entities meant that the project could have a
proof of concept sooner, and from which further work and design decisions
could be made. With that said, a better direction for developers to embed
SCUs in their own software should indeed be made moving forward.

This does not quite have to do with the lack of modularity in the project,
but with missing pieces in these modules which need time and effort to
develop. I have not had much of these two lately, and attracting
contributors to close these tasks is one of the open challenges, but we
will get there! I can try to split the feedback into separate issues in the
meantime. See also the project roadmap
https://github.com/Enet4/dicom-rs/wiki/Roadmap#networking-and-service-class-implementation
.
—
Reply to this email directly, view it on GitHub
https://github.com/Enet4/dicom-rs/issues/352#issuecomment-1573583477,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARWGC3BXYRU7UT7S33HQRO3XJHE6NANCNFSM6AAAAAAYYEQCLA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Vue with three.js

Is it possible to contribute Vue with three.js library ?

Hi, can you give me a little more context?

Is it possible to include development of 3D scenes using three.js with vue

@uditgogoi sounds interesting. If you want to create a PR go for it.

Ok thanks the reply. I will try to contribute towards it

Looking forward to it =)


CMCD data is being appended multiple times when playing HLS live streams

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.3.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
What browser and OS are you using?
Chrome, Firefox
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?

What configuration are you using?  What is the output of player.getConfiguration()?

{
  cmcd: {
    enabled: true
  }
}

What did you do?

Load any HLS live stream
Let content play until the manfiests/playlists are re-requested

What did you expect to happen?
There should only be one set of CMCD data appended to the query string
What actually happened?

Each re-request appends another CMCD arg.

@joeyparrish I have a fix for this issue, but it uses URLSearchParams. I'm not sure if this meets the minimum browser support requirements. I've tried using the closure library's goog.Uri and goog.Uri.QueryData classes, but the ones that are loaded in the library don't seem to match the documentation. Specifically, I need goog.Uri.QueryData.set, and its coming up undefined.
https://google.github.io/closure-library/api/goog.Uri.html
https://google.github.io/closure-library/api/goog.Uri.QueryData.html#set

WebOS 3.X uses Chromium 38, see https://webostv.developer.lge.com/discover/specifications/web-engine/
The first version of Chromium that includes URLSearchParams is 49…
Sorry…

I figured  URLSearchParams wouldn't meet the minimum requirements. The question is: Do we polyfill it, update the Closure library to a version that supports goog.Uri.QueryData.set,or write yet another manual query string manager (👎)?

I don't think we need to use either of those types, we should check where the params are getting added twice.  We should just take the base URL and add the params once, so using a type like that shouldn't be needed.

The safest way to replace a query param is to use to parse the search params, replace/add the CMCD values, then serialize the string. Using URLSearchParams it's as simple as:
const url = new URL(uri);
url.searchParams.set('CMCD', query);
return url.toString();

Otherwise, we need to manually parse the string, or write a regex that accounts for all the possible use cases (does the search string have only one param or multiple, etc). It seems hack to my to manipulate the string manually when the w3c and the closure library both provide utilities for doing this exactly thing.

The problem with the closure library is that it is very difficult to get "just" one feature.  In for a penny, in for a pound.  We've tried to depend only on the dependency system (goog.require/goog.provide), which is relatively independent.  To use the closure URI classes without dependencies on a million pounds of nonsense (bloating our binary in the process), we have had to fork and strip down the implementation.
If you really want an updated closure URI implementation, I believe we should update our fork in third_party/closure-uri/.
Alternately, this polyfill has no dependencies: https://www.npmjs.com/package/url-search-params-polyfill
As for web standards vs other utilities like Closure, I tried at one time to replace closure-uri entirely with the web standard URI, and I ultimately failed.  It parsed differently on different browsers, specifically with non-standard URI schemes like our "offline://".  We decided to stick to a JS implementation for consistency.
So in this case, I think it might be best to update the closure-uri folder.  Since we already depend on that internally, it's not any additional bloat to the library.


add package.json so npm is supported

This allows the package to be installed via npm/git.
If you want to publish it to npm, you can run npm publish in command line to publish it.

I always assumed that npm was for JavaScript, but I don't see any harm in merging this


Soft dependency on Doctrine ORM

In one of the projects we are using DBAL only. So we were disappointed that ramsey/uuid-doctrine requires the whole ORM package we don't need. The hack is to use the replace composer directive which feels hackish.
This change feels a bit dangerous. But I think that projects using ORM do/should require it explicitly in the root composer.json rather than rely on the fact that it's a second level dependency.
Also closes https://github.com/ramsey/uuid-doctrine/issues/63.

Any chance, that this PR will be merged?

@vudaltsov orm should appear also in suggest section
@ramsey can you look at this?

@snapshotpl , why ORM should appear in the suggest section?
The question of using or not using ORM is completely orthogonal to a UUID DBAL type.

@snapshotpl , why ORM should appear in the suggest section?

Because ORM is actually used in generator.

Because ORM is actually used in generator.

I know that, but is it a valid reason to install Doctrine ORM just because the library has a bridge for it?
What is the point of such a suggestion?
Don't get me wrong, I am not strictly against the suggestion. I just cannot imagine a situation when it could make sense. AFAICS in this very case the decision to (not) install ORM is always driven by some architectural reasonings.

I think the best solution for that is create separate repository for ORM stuff.

@vudaltsov I think it's fair to suggest every dependency that could be needed

Thank you for contributing! 🎉


Dynamic switching of "check-in" and "check-out" for long press menu

An easy alternative is to remove check-in option first.

A more robust (assertive) way of achieving the same idea:
Check in activity rejecting all check-in attempts to currently checked-in locations


Improve several hyprctl commands

Describe your PR, what does it fix/add?
This adds better help for some hyprctl subcommands, particularly dispatch, keyword,
hyprpaper and setcursor. It also makes them return a nonzero exit status to the shell
when they do not have enough arguments.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No, not that I am aware of.
Is it ready for merging, or does it need work?
Works for me (tm), but yes, it should be ready to merge.

I'm all in for this PR, but why those commands in those particular?

Mostly because they were ones that took additional arguments, and gave somewhat unclear
error messages when not enough arguments were provided. getoption also takes another argument
but since it is just one, its a little easier to understand IMO; also changing it would be more
complicated. If you think the others should be improved, though, I can work on it.

can you plox squash


How to RESTART bot

I know, how to stop bot. It's - bot.stopPolling(); than bot will off.
But how to restart my bot? Is There any ways?

.startPolling :)

i tried it, no result(, another idea?

Use a package like pm2 or forever and use pm2 restart or forever stop and next start. But startPolling must work, what error prints?

I think the idea is to restart the script here. We can shut it down with process.exit() and forever will resurrect it.
However when I try to use a command like /die with the bot, then restart it, it seems it keeps the last message in memory, and the script shuts down immediately (same if I ask it to send a message then die: the message is sent and the process exits).
Full example below:
teleMessenger.startPolling();
teleMessenger.on("text", msg => {
  switch (msg.text) {
    case "/die":
      teleMessenger.sendMessage(msg.chat.id,'I died 😵')
        .then(() => {
          process.exit();
        });
      break;
    default:
  }
});

Do you know a workaround for that?

+1
@timothe did you find a nice solution to restart the bot without keeping last message in memory?

Hi @ouya99 !
I did, using the forever package and killing the process with a message as in the example below:
Utils.teleMessenger.on('text', msg => {
  if (Date.now() - msg.date * 1000 < 1000) {    // Check if the message is not old
    switch (true) {
      // Text example with "die now" in the msg
      case /die now/iu.test(msg.text):
        Utils.teleMessenger.sendMessage(msg.chat.id, 'I dieded 😵').then(() => {
          process.exit(); // Kill the node process, forever will restart it
        });
        break;
      default:
    }
  }
});


Build cleanup

Not really done, but need to ask our CI bots to verify..

rebased and merged as https://hibernate.atlassian.net/browse/HHH-13428


[FLINK-26848][JDBC]Support to write data when disable flush-interval and max-rows

What is the purpose of the change

sink.buffer-flush.interval
The flush interval mills, over this time, asynchronous threads will flush data. Can be set to '0' to disable it. Note, 'sink.buffer-flush.max-rows' can be set to '0' with the flush interval set allowing for complete async processing of buffered actions.

sink.buffer-flush.max-rows
The max size of buffered records before flush. Can be set to zero to disable it.

Asynchronous thread flush is disabled  when set sink.buffer-flush.interval = 0,  then disable sink.buffer-flush.max-rows, which causes the data is not written out.
The data are not written when disable flush.interval and max-rows. I think it should write out when the data arrive.

@flinkbot run azure

Hi @MartijnVisser , have a look when you are free.

@hehuiyuan I'm not a JDBC expert, so I can't review this PR.

Thanks for the PR @hehuiyuan , I'm also not an expert in connectors/JDBC.
@fapaul, @JingsongLi, maybe you could take a look?

hi  @fapaul @JingsongLi  ,     have a look this pr.

We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc


Add support for Ollama, Palm, Claude-2, Cohere, Replicate Llama2 CodeLlama (100+LLMs) - using LiteLLM

This PR adds support for the above mentioned LLMs using LiteLLM https://github.com/BerriAI/litellm/
LiteLLM is a lightweight package to simplify LLM API calls - use any llm as a drop in replacement for gpt-3.5-turbo.
Example
from litellm import completion

## set ENV variables
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["COHERE_API_KEY"] = "cohere key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# cohere call
response = completion(model="command-nightly", messages)

# anthropic call
response = completion(model="claude-instant-1", messages=messages)

I was actually searching for a wrapper to do this my self, but couldn't find one. Thanks for this @ishaan-jaff

@jianghuyihei @callanwu can I get a review on this PR ?

It sounds great,we will review it soon.


No sudo chown

some slight tweaks to the code path so that sudo chown isn't needed as often

tests pass: http://jenkins.rcb.me/job/devstack-test/6/


[Site] Add routing

As a Mineral UI consumer, I would like a way to directly link to components on the demo site, so that I get to specific pages without needing to navigate from the home page.
As a Mineral UI developer, I would like routing in the site, so that it is easier to manage, matches the design, has readable urls, is bookmarkable, etc.
AC:

Route for each component
Update component README's to point to permalink

Other Considerations:

Site is currently deployed as an SPA

We either need to

statically generate the files prior to deploying
use github 404 page to redirect 404 to root and use push state router
switch to Netlify - which supports both redirects and static deploy

Still need to consider the "Other considerations" in the description above


Update Posts “lorem-ipsum”

Automatically generated by Netlify CMS

👷 Deploy Preview for benevolent-pika-f5fbe0 processing.

Name
Link

🔨 Latest commit
d87d4016c1fb7610cd9809bdef645d8b9dc5156e

🔍 Latest deploy log
https://app.netlify.com/sites/benevolent-pika-f5fbe0/deploys/62e2ea5a4cef07000a89ece3


fga model write second example doesn't work

On fga version v0.3.0(commit:22466caec32a8e93a3db4a4ceb319781c1813587, date: 2024-03-28T21:40:05Z)

help text is odd, see below
the second example doesn't work, it needs --format json

The ModelFormat text is because that's what we return in the Type function, maybe we should just return format as I think in an enum based option a lowercase of the option is more common, wdyt @miparnisari?
The default default I'm not sure what we can do about that as the default for that default. I think maybe we could refactor the code to remove that and potentially use an empty string value in place of default but that might be a bit more involved.

The ModelFormat text is because that's what we return in the Type function, maybe we should just return format as I think in an enum based option a lowercase of the option is more common, wdyt @miparnisari?

Why not put type string?

use an empty string value in place of default

Based on the example that i tried, it looks like the default is fga

Based on the example that i tried, it looks like the default is fga

The default depends - it's either fga if you paste the string directly, or autodetected from the file name if you pass in the file

Why not put type string?

It's not a string though - it's an enum, you can't say yaml for example.


Issues with Windows.Storage dll referenced in FileHandlerUWP.cs?

First, thank you for making this toolkit, it had made something I'm working on a ton easier.
Second, I've been trying ot figure out why my HL2 only creates the headers for the gaze data in the .csv on my HL2 but no actual data, and today, for seemingly no reason, the prefabs and scripts can no longer compile.  I get three compilation errors, all in FileHandlerUWP.cs.

I changed nothing since the last time I successfully built the project.  Very odd. Also, my build settings are set to UWP.  This is very strange. Any other issues like this?

Nice to hear that the toolkit helps you in your work!
What version of Unity are you using and what exactly are your build settings?
The errors look to me like the build environment is configured incorrectly as the missing Windows namespace is only included in the UWP environment. However, if the build settings aren't set for UWP this should be handled by the toolkit and the UWP file handler shouldn't be included in the build if it isn't a UWP build.
Have you tried completely emptying or deleting your build folder and making a new Unity build from scratch?
The incremental building into an existing build folder sometimes breaks for me with a full rebuild from scratch being an easy fix.
Regarding the issue with only a header and no gaze data in the csv file:
Did you give the application gaze permission and also made sure that the wearer of the device has a valid eye tracking calibration? It also has to be worn to produce data, i.e. not just sitting on a table.
I have run into some issues where the HoloLens reports an existing valid calibration (and granted gaze permissions), however the calibration is actually missing resulting in no actual gaze data. As the toolkit relies on the information provided by the HoloLens to be accurate this can lead to cases as you observe where the toolkit thinks that everything is set up for recording, the HoloLens however doesn't actually provide gaze data.

"I have run into some issues where the HoloLens reports an existing valid calibration (and granted gaze permissions), however the calibration is actually missing resulting in no actual gaze data. As the toolkit relies on the information provided by the HoloLens to be accurate this can lead to cases as you observe where the toolkit thinks that everything is set up for recording, the HoloLens however doesn't actually provide gaze data."
How did you fix this?  Sounds alot like my situation.  I've calibrated numerous times, and have all the providers setup.  Also, I'm wearing it while I try to collect data.

For me simply running the calibration again always fixed it. Maybe you can try the eye tracking example from the MRTK to check if the issue is with your application/ARETT or if the HoloLens does not provide eye tracking data at all.
What version of Unity and which Windows Version on the HoloLens 2 are you using? Is the same issue present when you create a new clone of the ARETT example project on your PC and create an unmodified build?
Sadly I'm not able to further test these issues right now but maybe I can have a look at it later.


Docs folder is fully translated to russian

Uff... It took me two hours to do it, according to commits history. I really hope that this PR will be approved.
Things like true and false cannot be translated to russian. I mean, they can, but the meaning is kinda different. Some other words are left with no translation, too.
OnePieceJoker was going to make a translation to chinese. Thanks to you, I got inspired by your issue
If translations for another languages will appear, so we can make a folder for each one. But now I think it still looks OK.
I am sorry for the last commit, you can see it. I am just not really good at resolving conflicts and the file I was editing was corrected right before I did it. So, I accidently deleted a comment...

Thanks! This is very much appreciated. I'll try review through Google translate when I get home but it looks great so far

Omg, thank you so so much for the effort here! Really appreciated ❤
I'd be happy to merge this, but I would like if we could put it into a subfolder if possible. Let's get it started off right :)
So all the Russian translation would live under
docs/ru/the_file_name.md

Thanks again!!!

Omg, thank you so so much for the effort here! Really appreciated ❤
I'd be happy to merge this, but I would like if we could put it into a subfolder if possible. Let's get it started off right :)
So all the Russian translation would live under

docs/ru/the_file_name.md

Thanks again!!!

I agree with this file directory format because that's what I'm going to do

Thank you so much for this! I'm excited to see our documentation is becoming accessible to more people 🎉


Omde 272 fix field type

It looks like it would be far more useful to get the actual manifest rather than it's class. This is a problem for us as we need to evaluate the manifest of a field in our application.

You don't have a version update.

Please squash commits and add update the version before merging :+1:

Please squash commits and update the version before merging :+1:

Awesome. Can you please tell me where to change the version.

In case you are not aware, please use fast forward merge.

@knservis next time please don't introduce merge commits. As you can see from our past history we use fast forward merges to create a linear git history.


DASK Q05 SF1k Groupby Failing  with list object has no attribute groupby

Command
python tpcx_bb_query_05.py --config ../../benchmark_runner/benchmark_config.yaml

Trace:
Using default arguments
{
  "type": "Scheduler",
  "id": "Scheduler-c21fba8f-8539-41b0-bf54-b427d45b09d7",
  "address": "ucx://<IP_ADDRESS>:8786",
  "services": {
    "dashboard": 8787
  },
  "workers": {}
}
Connected!
Encountered Exception while running query
Traceback (most recent call last):
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/xbb_tools/utils.py", line 280, in run_dask_cudf_query
    config=config,
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/xbb_tools/utils.py", line 61, in benchmark
    result = func(*args, **kwargs)
  File "tpcx_bb_query_05.py", line 266, in main
    results_dict = client.compute(*ml_tasks, sync=True)
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/distributed/client.py", line 2930, in compute
    result = self.gather(futures)
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/distributed/client.py", line 1992, in gather
    asynchronous=asynchronous,
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/distributed/client.py", line 833, in sync
    self.loop, func, *args, callback_timeout=callback_timeout, **kwargs
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/distributed/utils.py", line 340, in sync
    raise exc.with_traceback(tb)
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/distributed/utils.py", line 324, in f
    result[0] = yield future
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/tornado/gen.py", line 762, in run
    value = future.result()
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/distributed/client.py", line 1851, in _gather
    raise exception.with_traceback(traceback)
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/dask/utils.py", line 29, in apply
    return func(*args, **kwargs)
  File "/raid/vjawa/conda/envs/rapids-tpcx-bb/lib/python3.7/site-packages/dask/dataframe/groupby.py", line 279, in _groupby_aggregate
    return aggfunc(df.groupby(level=levels, sort=sort, **dropna), **kwargs)
AttributeError: 'list' object has no attribute 'groupby'

Env:
cudf                      0.17.0a201105   cuda_10.2_py37_g1556a4997c_171    rapidsai-nightly
dask-cudf                 0.17.0a201105   py37_g1556a4997c_171    rapidsai-nightly
libcudf                   0.17.0a201105   cuda10.2_g1556a4997c_171    rapidsai-nightly
(rapids-tpcx-bb) vjawa@exp01:/raid/vjawa/tpcx-bb/tpcx_bb/queries/q05$ conda list | grep dask
dask                      2.30.0+22.g2b45fdb9          pypi_0    pypi
dask-cuda                 0.17.0a201105           py37_30    rapidsai-nightly
dask-cudf                 0.17.0a201105   py37_g1556a4997c_171    rapidsai-nightly

Can confirm that #129  was the root cause, closing this issue in favor of that one.


Communication Services - Chat: Fix incorrect tests

Fixing tests with wrong assumptions.

/azp run java - communication -tests

Thanks for these changes @danielgerlag.
Is it necessary to update all the recorded files when only 2 tests have been updated? For better readability, I suggest only update the related recordings.

/azp run java - communication - tests

\azp run java - communication - tests

/azp run java - communication - tests


Move the cache cleaner definition into the loris-infrastructure repo

https://github.com/wellcomecollection/dockerfiles/tree/master/cache_cleaner
It's a key part of the Loris infrastructure, and shouldn't be sitting off to the side.

Closes by https://github.com/wellcomecollection/platform/issues/4884


Fixes for bugs found in the test deployment

Subject says it all. :wink:

Skimmed through the code and can say that it looks good to me. I say, we run this on the test deployment again to check if it works before merging. What do you say @siddharthvipul?

Skimmed through the code and can say that it looks good to me. I say, we run this on the test deployment again to check if it works before merging. What do you say @siddharthvipul?

Since these are what Nils already tried on stg, we can merge it directly
but if you want double reassurance, we can do that

since these were hot fixes, were also tested right away
merging it


fix(entrypoint.sh): security issue; replace 'set-output' with new GITHUB_OUTPUT env var

see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Copied from GitHub Actions:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
"To avoid untrusted logged data to use save-stateand set-output workflow commands without the intention of the workflow author we have introduced a new set of environment files to manage state and output.
Starting today runner version 2.298.2 will begin to warn you if you use the save-state or set-output commands via stdout. We are monitoring telemetry for the usage of these commands and plan to fully disable them on 31st May 2023. Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error."


Fix compilation with change from poem 1.2.x

This fixes the issue when compiling with poem 1.2.x where Error::new_with_status was renamed to Error::from_status.
Previously, it was failing with
error[E0599]: no function or associated item named `new_with_status` found for struct `poem::Error` in the current scope
  --> integrations/poem/src/subscription.rs:33:35
   |
33 |             .ok_or_else(|| Error::new_with_status(StatusCode::BAD_REQUEST))
   |                                   ^^^^^^^^^^^^^^^ function or associated item not found in `poem::Error`

Thanks! 😁


list is still cut off

My list is still being cut off

genestealers hordes - Copy.zip

I tried increasing Ui Width and height but they did nothing

I've not heard about this from anywhere else. Please try again with a new army and the latest mod, I expect you'll no longer see this issue.


Generalize ClusterID reservation mechanism for clustermesh

766e62b83c20 ("clustermesh: Introduce ClusterID reservation mechanism") recently implemented a ClusterID reservation mechanism to ensure the uniqueness of the ClusterIDs associated with remote clusters. Let's generalize a bit this approach so that we can optionally replace the current implementation with different ones if necessary.

/test

Closed and reopened to retrigger the workflows. Image building appears to have previously failed due to a quay blip.

Woops, it was back to draft. Rerequesting review by myself.

After some offline discussion, we decided to wait generalizing the approach until this pattern shows up again. Marking as ready to merge given that no change has been applied since Yutaro's approval, and all checks are green.

@giorio94 this needs rebase, merge conflicts are present :)

/test

Checks are green. Marking as ready to merge again.


Implement the New Landing Page

Implement the new landing page as can be seen in the Figma designs. The current landing page shares some identical or similar sections as the new designs, but the new designs also feature new content. Your designs should work on both Mobile and Desktop. There are no UI designs for tablet mode, so you can decide exactly what this would look like.
The current landing page is stored at frontend/src/screens/LandingPage.js, so you'll be editing this file as well as any other components that needs changing. The landing page shows whenever you go to Dolphin Flashcards and you are not signed in.
We need this change because:

Right now, the landing page for Dolphin flashcards isn't properly optimized to encourage users to use it
While it's good, we need to further improve it to improve the click-through-rate
This will enourage more people to use the site

Let me know if you have any questions!

Hey I'd like to claim this issue, thanks!


remove menu top

i need remove or hide menu top in choose time. please help me.
thanks,

Is this this the thing where the date shows as 1899?
I have a workaround (that comes from a comment made against #416): set startView and maxView to 1. You still get a header with the date on (which might be a problem for you) but the date is today's date and the UI is actually better, I think?


add pipestat link functionality to create symlinks

add pipestat link functionality to create symlinks

user can call pass an output_dir or, if none is given, pipestat will read its associated filebackend and create symlinks grouped by file types.

For:
https://github.com/pepkit/pipestat/issues/89
https://github.com/pepkit/looper/issues/72

[ ] add CLI

about the CLI: should it just run through looper?

I think CLI functionality would be nice to have for pipestat users independent of looper.

Ok, I believe this is in a more desirable state after yesterday's discussion.


FFmpeg returned an error: Did you mean file: ...?

Hi,
I went through the installation with success (running Kubuntu 20.04), destreamer seems to work (I can log into chromium), but then suddenly stops and I get the following message :

[ERROR] FFmpeg returned an error: Did you mean file:https://euno-1.api.microsoftstream.com/api/videos/manifest?api-version=1.0&playbackurl=https://streameuno1su011.azureedge.net/76167dc0-fa2d-416a-a7eb-1132f61fa250/v.ism/manifest(format=m3u8-aapl)?
[FATAL ERROR] Unknown FFmpeg error

I'm trying to download a Teams's meeting record but the video is available in Stream (from which I copy the link, in that case it is "https://web.microsoftstream.com/video/f8f492dd-077d-4eb8-831a-5673100f2138"), and I tried with a random non-Teams video and still get the same error, so I thought the issue should come from ffmpeg.
I do have one of the lastest release of ffmpeg, but I still tried to install some others just in case. Same results.
I have no clue of where the issue is coming from, nor what is this kind of file ffmep doesn't like. Any help would be greatly appreciated :) Thanks !

I just saw there is a verbose mode, my bad. If it can give anyone some idea, here's what I get :

./destreamer.sh -i "https://web.microsoftstream.com/video/d036af81-9d99-459f-a69f-0eae4966db38" -v
[VERBOSE] Using ffmpeg version N-100427-g2d02cf7 Copyright (c) 2000-2020 the FFmpeg developers
Access token still good for 57 minutes.
[VERBOSE] Session and API info
API Gateway URL: https://euno-1.api.microsoftstream.com/api/
API Gateway version: 1.4-private
Parsing video/group urls
[VERBOSE] List of GUIDs and corresponding output directory
https://web.microsoftstream.com/video/d036af81-9d99-459f-a69f-0eae4966db38 => videos
Fetching videos info...
Downloading Video:
[VERBOSE] Extra video info
Video m3u8 playlist URL: https://euno-1.api.microsoftstream.com/api/videos/manifest?api-version=1.0&playbackurl=https://streameuno1su021.azureedge.net/4b94409f-f99d-4125-bbc2-4b136ad27c36/v.ism/manifest(format=m3u8-aapl)
Video tumbnail URL: https://euno-1-content.api.microsoftstream.com/api/thumbnails/2/356c6d23-2e58-4002-8748-237dcd349e85/MS0yY3J3bnFpeW13bnphNmJnbmdoZTZ4c3FkZV8xXzMyMHgxODAucG5n?validTill=2020-12-26T00%3A00%3A00.0000000Z&aadUserOId=1f547ecb-a747-4cc2-9735-df618a61e437&encoding=base64&api-version=1.4-private&signature=TAwDEDAxXRcFyA%2BcRNFljz%2BXSOr2pc3%2Fx8labDgpAwE%3D
Video subtitle URL (may not exist): undefined
Video total chunks: 43.43333333333333
Spawning ffmpeg with access token and HLS URL. This may take a few seconds...
progress [░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░] 0% 0 0s
[ERROR] FFmpeg returned an error: Did you mean file:https://euno-1.api.microsoftstream.com/api/videos/manifest?api-version=1.0&playbackurl=https://streameuno1su021.azureedge.net/4b94409f-f99d-4125-bbc2-4b136ad27c36/v.ism/manifest(format=m3u8-aapl)?
[FATAL ERROR] Unknown FFmpeg error

I got this error as well on Ubuntu 16.04, npm 6.14.10 and ffmpeg 4.3.1.

I just saw there is a verbose mode, my bad. If it can give anyone some idea, here's what I get :

./destreamer.sh -i "https://web.microsoftstream.com/video/d036af81-9d99-459f-a69f-0eae4966db38" -v
[VERBOSE] Using ffmpeg version N-100427-g2d02cf7 Copyright (c) 2000-2020 the FFmpeg developers
Access token still good for 57 minutes.
[VERBOSE] Session and API info
API Gateway URL: https://euno-1.api.microsoftstream.com/api/
API Gateway version: 1.4-private
Parsing video/group urls
[VERBOSE] List of GUIDs and corresponding output directory
https://web.microsoftstream.com/video/d036af81-9d99-459f-a69f-0eae4966db38 => videos
Fetching videos info...
Downloading Video:
[VERBOSE] Extra video info
Video m3u8 playlist URL: https://euno-1.api.microsoftstream.com/api/videos/manifest?api-version=1.0&playbackurl=https://streameuno1su021.azureedge.net/4b94409f-f99d-4125-bbc2-4b136ad27c36/v.ism/manifest(format=m3u8-aapl)
Video tumbnail URL: https://euno-1-content.api.microsoftstream.com/api/thumbnails/2/356c6d23-2e58-4002-8748-237dcd349e85/MS0yY3J3bnFpeW13bnphNmJnbmdoZTZ4c3FkZV8xXzMyMHgxODAucG5n?validTill=2020-12-26T00%3A00%3A00.0000000Z&aadUserOId=1f547ecb-a747-4cc2-9735-df618a61e437&encoding=base64&api-version=1.4-private&signature=TAwDEDAxXRcFyA%2BcRNFljz%2BXSOr2pc3%2Fx8labDgpAwE%3D
Video subtitle URL (may not exist): undefined
Video total chunks: 43.43333333333333
Spawning ffmpeg with access token and HLS URL. This may take a few seconds...
progress [░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░] 0% 0 0s
[ERROR] FFmpeg returned an error: Did you mean file:https://euno-1.api.microsoftstream.com/api/videos/manifest?api-version=1.0&playbackurl=https://streameuno1su021.azureedge.net/4b94409f-f99d-4125-bbc2-4b136ad27c36/v.ism/manifest(format=m3u8-aapl)?
[FATAL ERROR] Unknown FFmpeg error

I got this error as well on Ubuntu 16.04, npm 6.14.10 and ffmpeg 4.3.1.

I just saw there is a verbose mode, my bad. If it can give anyone some idea, here's what I get :

./destreamer.sh -i "https://web.microsoftstream.com/video/d036af81-9d99-459f-a69f-0eae4966db38" -v
[VERBOSE] Using ffmpeg version N-100427-g2d02cf7 Copyright (c) 2000-2020 the FFmpeg developers
Access token still good for 57 minutes.
[VERBOSE] Session and API info
API Gateway URL: https://euno-1.api.microsoftstream.com/api/
API Gateway version: 1.4-private
Parsing video/group urls
[VERBOSE] List of GUIDs and corresponding output directory
https://web.microsoftstream.com/video/d036af81-9d99-459f-a69f-0eae4966db38 => videos
Fetching videos info...
Downloading Video:
[VERBOSE] Extra video info
Video m3u8 playlist URL: https://euno-1.api.microsoftstream.com/api/videos/manifest?api-version=1.0&playbackurl=https://streameuno1su021.azureedge.net/4b94409f-f99d-4125-bbc2-4b136ad27c36/v.ism/manifest(format=m3u8-aapl)
Video tumbnail URL: https://euno-1-content.api.microsoftstream.com/api/thumbnails/2/356c6d23-2e58-4002-8748-237dcd349e85/MS0yY3J3bnFpeW13bnphNmJnbmdoZTZ4c3FkZV8xXzMyMHgxODAucG5n?validTill=2020-12-26T00%3A00%3A00.0000000Z&aadUserOId=1f547ecb-a747-4cc2-9735-df618a61e437&encoding=base64&api-version=1.4-private&signature=TAwDEDAxXRcFyA%2BcRNFljz%2BXSOr2pc3%2Fx8labDgpAwE%3D
Video subtitle URL (may not exist): undefined
Video total chunks: 43.43333333333333
Spawning ffmpeg with access token and HLS URL. This may take a few seconds...
progress [░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░] 0% 0 0s
[ERROR] FFmpeg returned an error: Did you mean file:https://euno-1.api.microsoftstream.com/api/videos/manifest?api-version=1.0&playbackurl=https://streameuno1su021.azureedge.net/4b94409f-f99d-4125-bbc2-4b136ad27c36/v.ism/manifest(format=m3u8-aapl)?
[FATAL ERROR] Unknown FFmpeg error

Did it happen again? Did you try any other video?
Sorry for the very late response, I was busy

Yes, the same issue with any video.
No problem, it's already honorable from you to spend time on that.

@yylliw Could you try to update both ffmpeg and Destreamer to the lastest version possible please?

Looks like a nightly built ffmpeg. Get a stable version of ffmpeg. Stable versions are numbered 4.x.x.

Problem solved. Seems to me that the latest stable version of ffmpeg didn't change the result, but updating destreamer to the latest version (v3.0) did. For now I did not encounter any other bug, destreamer is working fine. Sorry for the late response, and thank you very much for your help.


Robot-name, v1

More practice with short methods, readable code, and good style.

Closed because there were a bunch of commits that I didn't know how to remove in the pr.


Expose a debugger port on the backend to allow to connect IDE debugger

@mushketyk I guess this is a duplicate of https://github.com/FightPandemics/FightPandemics/pull/215 ?

@robinv85 #215 closes this issue


Javascript

JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

completed module 3.4.5 on 07-30-24


Invalid Hazelcast documentation for 7.x & 8.x docs

I am working on an upgrade from v6 and I found the docs are not valid.
They state the BucketConfiguration build method requires 2 params, but it has 0.

The key is not passes to the BucketConfiguration builder but to the Bucket builder.

If it's ok, this is an easy fix, I can work on the current asciidoctor branch alongside other minnor doc fixes.

Yes, it is bug, right example should be as you described above.

documentation has been fixed for 7.6.0 and 8.0.1


[bug] last char of all game responses missing

dfrotz returns all game responses ending with "\n>"
The API fixes this by stripping the last three characters. But since \n is a single newline character and not a literal backslash-n, it's only two characters that need stripping. The last character of every response is cut off.

whoops


Umm

I dont know where to contact u, but how do i use it? i don't understand, how can i open console, when i use ctrl shift and i it doenst work and where exactly to paste the code

Hello, if you're on browser, it might be F12. However on default Discord the combination is CTRL + SHIFT + I. You have to press "Console" in one of the tabs where you paste the code.


docs(README): improve caching explanation DOC-8

https://fingerprintjs.atlassian.net/browse/DOC-8

:tada: This PR is included in version 1.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Chile spreadsheet content to transifex

Chile content is updated on the spreadsheet, please can this be moved to Transifex for translation.

This is done now.

Thanks Karolis. Can you remind me about the tagging of country content in Transifex. I remember you had a work around/solution so that a country would only see the text being used in their version of the app to prevent them needless translating content they don't need. Can you share details of how a coutry achieves that please.
Thanks
Jim

@JimChiazzese1 Here you go https://flumens.notion.site/Filtering-translations-6275210fbcb94ab5a53413a1a31cd833


Use modern OpenGL to draw light paths and scene representation

Fixes #2393
Uses OpenGL 3.3 core to draw the light paths visualization. Drastically improves performance on more complex scenes and scenes with many light paths.

Uses instanced drawing to draw multiple instances of the same object in the same draw call
Currently does not update positions or other data of the scene objects based on changes in appleseed.studio after the first data load has completed. (This is for the scene object representations only; light paths are updated dynamically based on user input). If this is a significant issue to have this merged then I can fix it first.
Uses glad to load OpenGL now.
Adds a triangle_count_hint to begin_object on ObjectRasterizer which allows the rasterizer to preallocate a buffer of the appropriate size.
Adds get_vertex_count to LightPathRecorder to get the total number of vertices stored in all light paths, also for use in preallocating space for a buffer

Rebased working version and edited the original description. This is now ready for review!

@oktomus Thanks for the review so far!
As far as the glad dependency, I'd asked @dictoon about it and he was good with it. However, since #2509 is needed for this to work on macOS anyway, we can/should drop glad and use the built-in Qt 5 way of doing this, which is by using QOpenGLWidget instead of QGLWidget and then QOpenGLFunctions; in this case, QOpenGLFunctions_3_3_Core (see https://doc.qt.io/qt-5/qopenglwidget.html)

Ok, I would like to see how it could be done using Qt wrappers. And I like the idea of not adding another dependency.

@oktomus Addressed your comments and also moved this to work on Qt 5, so glad is no longer needed and it works on macOS.

I'll review as soon as I can.

Unfortunately, it's also showing the base Qt 5 changes from #2509 in the diff for this PR because of the way that I rebased on top of it. Thankfully it's not too much noise...
And awesome, thanks @oktomus :D

Then we are going to wait that the other PR gets merged if it's not a problem for you.

No problem, makes sense to me :)

Addressed last comment, I think this is ready for merge now that qt5 got merged :)

Manually rebased to remove Reinhard tonemapping that was merged in another PR and to squash the two commits into one.


Unable to log into Procurement

[13-12-2015 19:31] Error downloading stash for Hardcore Talisman, exception details: System.Net.WebException: The remote server returned an error: (500) Internal Server Error.
at System.Net.HttpWebRequest.GetResponse()
at POEApi.Transport.HttpTransport.GetStash(Int32 index, String league, Boolean refresh)
at POEApi.Transport.CachedTransport.GetStash(Int32 index, String league, Boolean refresh)
at POEApi.Model.POEModel.GetStash(Int32 index, String league, Boolean forceRefresh)
at POEApi.Model.POEModel.GetStash(String league, String accountName)
[13-12-2015 19:31] System.Exception: Downloading stash for Hardcore Talisman, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues
at POEApi.Model.POEModel.GetStash(String league, String accountName)
at Procurement.ViewModel.LoginWindowViewModel.LoadStashItems(Character character)
at Procurement.ViewModel.LoginWindowViewModel.d__6.MoveNext()
at System.Collections.Generic.List1..ctor(IEnumerable1 collection)
at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass2.b__1()
at System.Threading.Tasks.Task.Execute()

Procurement 1.9.7 has been released which fixes this issue!
https://github.com/Stickymaddness/Procurement/releases/tag/1.9.7


runtime GPU， server docker 启动报错，找不到swig_decoder

E0602 02:21:56.364861 139 model_repository_manager.cc:487] Invalid argument: ensemble 'streaming_wenet' depends on 'wenet' which has no loaded version. Model 'wenet' loading failed with error: version 1 is at UNAVAILABLE state: Internal: ModuleNotFoundError: No module named 'swig_decoders'

E0602 02:21:56.364861 139 model_repository_manager.cc:487] Invalid argument: ensemble 'streaming_wenet' depends on 'wenet' which has no loaded version. Model 'wenet' loading failed with error: version 1 is at UNAVAILABLE state: Internal: ModuleNotFoundError: No module named 'swig_decoders'

Thanks, I will investigate this issue. There are 2 WAR for you:

Would you mind trying this container first ， docker pull soar97/triton-wenet:22.12
You may install swig decoder manually in the container https://github.com/wenet-e2e/wenet/blob/main/runtime/gpu/Dockerfile/Dockerfile.server#L10.

E0602 02:21:56.364861 139 model_repository_manager.cc:487] Invalid argument: ensemble 'streaming_wenet' depends on 'wenet' which has no loaded version. Model 'wenet' loading failed with error: version 1 is at UNAVAILABLE state: Internal: ModuleNotFoundError: No module named 'swig_decoders'

@hmylk Thanks, I will investigate this issue. There are 3 WAR may work for you:

Would you mind trying this container first ， docker pull soar97/triton-wenet:22.12
You may install swig decoder manually in the container https://github.com/wenet-e2e/wenet/blob/main/runtime/gpu/Dockerfile/Dockerfile.server#L10.
export PYTHONPATH=$PYTHONPATH:/path/to/swig_decoders

@yuekaizhang   thanks for your reply，OK， I  ever tried  2 ,  also not work.
i just tried 3,  error occur like

i am now tring the 1 .
hope to get your advice,thks very much.

@hmylk swig_decoder installed in /root/.local/lib/python3.8, you should  setting PYTHONPATH ：
export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH

thankyou very much， now， docker server can run  successful。 But , when  i run  docker triton client :
cmd like ：
AUDIO_DATA=
docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client:latest
cd /ws/client
python3 client.py --audio_file=/ws/test_data/mid.wav --url=localhost:8001
Error occur ：

this error perpelx me  for a several days， hope to get your advices，thank you.

@hmylk swig_decoder installed in /root/.local/lib/python3.8, you should setting PYTHONPATH ： export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH

@iron-js   thank you very much， now， docker server can run successfully。 But , when i run docker triton client :
cmd like ：
AUDIO_DATA=path to client test  wavs
docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client:latest
cd /ws/client
python3 client.py --audio_file=/ws/test_data/mid.wav --url=localhost:9001
Error occur ：

This error perplex me  for serveral days，hope to get advices ，thank you very much

@hmylk swig_decoder installed in /root/.local/lib/python3.8, you should setting PYTHONPATH ： export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH

@iron-js thank you very much， now， docker server can run successfully。 But , when i run docker triton client : cmd like ： AUDIO_DATA=path to client test wavs docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client:latest cd /ws/client python3 client.py --audio_file=/ws/test_data/mid.wav --url=localhost:9001
Error occur ：
This error perplex me for serveral days，hope to get advices ，thank you very much

Would you mind changing client.py by yourself to remove the multi-threads related parts? The error you showed is caused by multi-thread call rather than the root cause.
Could you try this client? https://github.com/yuekaizhang/Triton-ASR-Client/blob/main/client.py#L37-L43. You may check the project readme.md first and test it with single wav.

@hmylk swig_decoder installed in /root/.local/lib/python3.8, you should setting PYTHONPATH ： export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH

@iron-js thank you very much， now， docker server can run successfully。 But , when i run docker triton client : cmd like ： AUDIO_DATA=path to client test wavs docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client:latest cd /ws/client python3 client.py --audio_file=/ws/test_data/mid.wav --url=localhost:9001
Error occur ：
This error perplex me for serveral days，hope to get advices ，thank you very much

Would you mind changing client.py by yourself to remove the multi-threads related parts? The error you showed is caused by multi-thread call rather than the root cause.
Could you try this client? https://github.com/yuekaizhang/Triton-ASR-Client/blob/main/client.py#L37-L43. You may check the project readme.md first and test it with single wav --audio-path.

@yuekaizhang thank you for your reply。 I tried remove the multi-threads related code，this error doesn't occur .
But，another error :

ds related code，this error doesn't occur .

Could you paste your code about the server launch and client launch? Make sure your client and server could communicate first.

ds related code，this error doesn't occur .

Could you paste your code about the server launch and client launch? Make sure your client and server could communicate first.

Server:
1.sudo docker run --gpus '"device=0"' -it -v $PWD/model_repo_stateful:/ws/model_repo -v $onnx_model_dir:/ws/onnx_model -p 9000:9000 -p 9001:9001 -p 9002:9002 --shm-size=1g --ulimit memlock=-1  wenet_server_new:latest
2. export PYTHON path ： export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH
3. /workspace/scripts/convert_start_server.sh
Client：

docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client_new:latest
cd /ws/client
python3 client.py --wavscp=/ws/test_data/wav.scp --data_dir=/ws/test_data/ --trans=/ws/test_data/trans.txt --model_name=streaming_wenet --streaming

One situation needs to be explained：
Becase the default port of 8000 is used by others ，so when i launch server docker， i just change ports parameters of docker run command。
BUT NOW  ,   I tried chang the server port from 9000 to 8000，  can run successfully
Thank you very much @iron-js @yuekaizhang .

ds related code，this error doesn't occur .

Could you paste your code about the server launch and client launch? Make sure your client and server could communicate first.

Server: 1.sudo docker run --gpus '"device=0"' -it -v $PWD/model_repo_stateful:/ws/model_repo -v $onnx_model_dir:/ws/onnx_model -p 9000:9000 -p 9001:9001 -p 9002:9002 --shm-size=1g --ulimit memlock=-1 wenet_server_new:latest 2. export PYTHON path ： export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH 3. /workspace/scripts/convert_start_server.sh
Client：

docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client_new:latest
cd /ws/client
python3 client.py --wavscp=/ws/test_data/wav.scp --data_dir=/ws/test_data/ --trans=/ws/test_data/trans.txt --model_name=streaming_wenet --streaming

One situation needs to be explained： Becase the default port of 8000 is used by others ，so when i launch server docker， i just change ports parameters of docker run command。 BUT NOW , I tried chang the server port from 9000 to 8000， can run successfully
Thank you very much @iron-js @yuekaizhang .

You can use the port as:
-p 9000:8000 -p 9001:8001

You need to make sure the right port(inside the docker) should alway be 8000, 8001 if you didn't change the port when starting triton server.  For the left port (your local server port), you may use any port number that is not occupied by others.

ds related code，this error doesn't occur .

Could you paste your code about the server launch and client launch? Make sure your client and server could communicate first.

Server: 1.sudo docker run --gpus '"device=0"' -it -v $PWD/model_repo_stateful:/ws/model_repo -v $onnx_model_dir:/ws/onnx_model -p 9000:9000 -p 9001:9001 -p 9002:9002 --shm-size=1g --ulimit memlock=-1 wenet_server_new:latest 2. export PYTHON path ： export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH 3. /workspace/scripts/convert_start_server.sh
Client：

docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client_new:latest
cd /ws/client
python3 client.py --wavscp=/ws/test_data/wav.scp --data_dir=/ws/test_data/ --trans=/ws/test_data/trans.txt --model_name=streaming_wenet --streaming

One situation needs to be explained： Becase the default port of 8000 is used by others ，so when i launch server docker， i just change ports parameters of docker run command。 BUT NOW , I tried chang the server port from 9000 to 8000， can run successfully
Thank you very much @iron-js @yuekaizhang .

You can use the port as:
-p 9000:8000 -p 9001:8001

@hmylk You need to make sure the right port(inside the docker) should alway be 8000, 8001 if you didn't change the port when starting triton server. For the left port (your local server port), you may use any port number that is not occupied by others.

oh,  so it is. Thanks  very much for your advices @Slyne
I want to  confirm that  the right port(inside the docker ) only be 8000,80001?

ds related code，this error doesn't occur .

Could you paste your code about the server launch and client launch? Make sure your client and server could communicate first.

Server: 1.sudo docker run --gpus '"device=0"' -it -v $PWD/model_repo_stateful:/ws/model_repo -v $onnx_model_dir:/ws/onnx_model -p 9000:9000 -p 9001:9001 -p 9002:9002 --shm-size=1g --ulimit memlock=-1 wenet_server_new:latest 2. export PYTHON path ： export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH 3. /workspace/scripts/convert_start_server.sh
Client：

docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client_new:latest
cd /ws/client
python3 client.py --wavscp=/ws/test_data/wav.scp --data_dir=/ws/test_data/ --trans=/ws/test_data/trans.txt --model_name=streaming_wenet --streaming

One situation needs to be explained： Becase the default port of 8000 is used by others ，so when i launch server docker， i just change ports parameters of docker run command。 BUT NOW , I tried chang the server port from 9000 to 8000， can run successfully
Thank you very much @iron-js @yuekaizhang .

You can use the port as:
-p 9000:8000 -p 9001:8001

@hmylk You need to make sure the right port(inside the docker) should alway be 8000, 8001 if you didn't change the port when starting triton server. For the left port (your local server port), you may use any port number that is not occupied by others.

oh, so it is. Thanks very much for your advices @Slyne I want to confirm that the right port(inside the docker ) only be 8000,80001?

if you want to use other port in start tritonserver,  add --grpc-port=9990 --http-port=9991 --metrics-port=9992.
https://github.com/wenet-e2e/wenet/blob/6b0dcd24f4f75fb4724a5185ff3bc9b985119262/runtime/gpu/scripts/convert_start_server.sh#LL26C1-L26C130
tritonserver --model-repository=${model_repo} --pinned-memory-pool-byte-size=1024000000 --cuda-memory-pool-byte-size=0:1024000000 --grpc-port=9990 --http-port=9991 --metrics-port=9992

ds related code，this error doesn't occur .

Could you paste your code about the server launch and client launch? Make sure your client and server could communicate first.

Server: 1.sudo docker run --gpus '"device=0"' -it -v $PWD/model_repo_stateful:/ws/model_repo -v $onnx_model_dir:/ws/onnx_model -p 9000:9000 -p 9001:9001 -p 9002:9002 --shm-size=1g --ulimit memlock=-1 wenet_server_new:latest 2. export PYTHON path ： export PYTHONPATH=/root/.local/lib/python3.8/site-packages:/root/.local/lib/python3.8/site-packages/swig_decoders-1.1-py3.8-linux-x86_64.egg:$PYTHONPATH 3. /workspace/scripts/convert_start_server.sh
Client：

docker run -ti --net host --name wenet_client -v $PWD/client:/ws/client -v $AUDIO_DATA:/ws/test_data wenet_client_new:latest
cd /ws/client
python3 client.py --wavscp=/ws/test_data/wav.scp --data_dir=/ws/test_data/ --trans=/ws/test_data/trans.txt --model_name=streaming_wenet --streaming

One situation needs to be explained： Becase the default port of 8000 is used by others ，so when i launch server docker， i just change ports parameters of docker run command。 BUT NOW , I tried chang the server port from 9000 to 8000， can run successfully
Thank you very much @iron-js @yuekaizhang .

You can use the port as:
-p 9000:8000 -p 9001:8001

@hmylk You need to make sure the right port(inside the docker) should alway be 8000, 8001 if you didn't change the port when starting triton server. For the left port (your local server port), you may use any port number that is not occupied by others.

oh, so it is. Thanks very much for your advices @Slyne I want to confirm that the right port(inside the docker ) only be 8000,80001?

if you want to use other port in start tritonserver, add --grpc-port=9990 --http-port=9991 --metrics-port=9992. https://github.com/wenet-e2e/wenet/blob/6b0dcd24f4f75fb4724a5185ff3bc9b985119262/runtime/gpu/scripts/convert_start_server.sh#LL26C1-L26C130 tritonserver --model-repository=${model_repo} --pinned-memory-pool-byte-size=1024000000 --cuda-memory-pool-byte-size=0:1024000000 --grpc-port=9990 --http-port=9991 --metrics-port=9992

ok， thank you very much.

Can I specify the installation location of swig I want to install in conda environment

Can I specify the installation location of swig I want to install in conda environment

You may try conda install -c anaconda swig


message.content is empty

message.content is empty can anyone help me?

Solution: https://github.com/3ddelano/discord.gd/issues/21#issuecomment-2106169648


feat: increase read buffer size to accomodate large bearer token headers

@HomelessDinosaur can you check to see if the mod/sum is up to date for this PR. Looks like there is an issue with dependencies in testing.

Codecov Report

Merging #292 (c81aed3) into develop (481e3ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #292   +/-   ##
========================================
  Coverage    61.40%   61.40%
========================================
  Files           43       43
  Lines         4350     4350
========================================
  Hits          2671     2671
  Misses        1504     1504
  Partials       175      175

Flag
Coverage Δ

unittests
61.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 481e3ac...c81aed3. Read the comment docs.


Add external linter

I added an external linter that detects some issues regarding our coding standards (and some basic rules).
Not covered are the following:

Final newlines: It seems to be a little bit complicated to read a file with its final space characters. Since the refactoring fixes any such issues, I didn't include a check for it here for now. I'll look into adding it to the linter.
Breaks in blocks, loops, etc.: I think this is a very subjective feature and can't really be checked automatically. If you have any ideas, feel free to contribute.
Alphabetical sorting of instance / class variables: I didn't have the time yet to check for this, but I'll look into it.

I decided to split up the errors in "correctable" and "uncorrectable" issues where correctable issues may be fixed by the auto-refactoring. I decided to fail the linter any time any issue occurs, even though it's correctable since I want to encourage the use of the refactoring to improve the code quality.
Feel free to leave your thoughts on this, including further check ideas.
Note that the pipeline will currently fail as there are several issues the linter detects.

I think I won't do much more for this respecting the time remaining.


Consider alpine or slim docker base images

I would recommend to switch the docker base image to an -alpine or -slim image. The single python script does not need all the fancy stuff from the full image and image size qwould be considerably smaller.

This should still be considered. I built the current version 0.6.0 image with a -slim image without problems.
Due to the recent code changes I wouldn't recommend an -alpine image anymore for this project. The additional work to get pandas working under alpine isn't worth it.


ported remaining read filters and added tests

ported all filters requested by @vdauwera in #429
and added tests for all of them.
@lbergelson please review

Coverage increased (+0.12%) to 70.83% when pulling 70518b799b942cbbce582ee86bd96d7c7603eefc on ak_read_additional_filters into f1eefec854289bf7ad007d0d2b9d572fb7d794b6 on master.

A few typos.
I think that makeReaderMaybeGzipped and it's ilk should be throwing UserExceptions instead of GATKException.  IOException is almost always a user issue.

Back to you @akiezun

I changed utility classes that deal with IO to throw IOExceptions and application-level classes will deal with them in application-level way (eg, say "blacklist file is missing")

back to @lbergelson

Probably the right move to replace with IOException.  Let the client figure out what to do with it.

@akiezun Back to you.  Looks good but it's conflicting with master now.

Coverage increased (+0.12%) to 72.71% when pulling 204f12cda0a2f7f3a605bc687f05d40099f8ebfe on ak_read_additional_filters into 0cd1c9a886be886ea81d46cdfe0bbd54e16edfd0 on master.

Coverage increased (+0.12%) to 72.76% when pulling c7db80f4314b72a808e560f20bcbaf25e31413a9 on ak_read_additional_filters into 758f3969522676cc49e9109266b702dc3a05329d on master.


Feature/autoreg multirealm

FEAT: Implemented multi-realm support and automatic user registration
This is done through a two new configuration parameters that control this behaviour. Setting this two to null will proved the same behaviour as before.
The multi-realm support is done through a cookie that should hold the realm name to use in every request. The realm public keys are downloaded on demand from the IDMS if not cached.
The automatic user registration is made in order to ease the functionality of the plugin in environments that have the IDMS as the only source of truth. Thus an unknown user can be logged into the app and still be a valid behaviour. This parameter allows a closure with the Access Token of this requests as the only parameter. The developer is responsible of wiring this call to a code which properly registers the user to be usable according to the plugin original behaviour.

Hi thanks for PR!
I really like the "auto register" user and plan to support it on up coming releases.
About multi-realm feature, i  am not sure about implementation. If you depend on third party online connections we can issue future  problem.
As you can notice laravel-keycloak-guard package is "stateless" and validate tokens "offline", because we set up everything is necessary. So it is not reponsible for "authenticate" or similar tasks. It is a simple middleware.

Hi, thanks for the rapid response!
Yeah, I completely agree that depending on third-parties always add some risks along the way. But I am thinking about the following:
This is to be configured for the IDMS you trust, the IDMS that provides the authorization mechanism for your app, and probably the IDMS from which your user just came from (Thinking of the login step). So, if that IDMS cames down, you have a more severe problem, as your user cannot login back to the application neither. It's a true problem for IDMS's that are behind VPN's and so, but this is a rare case. By no means we are doing authorization here, only avoiding harcoding public keys and retrieving them on demand.
Another solution would be to hardcode each realm public keys on an array with the realm code as the key of this array. But this would not fit my business case, where new realms are created only at the IDMS and then the users login into the app out of the sudden, without any other intervention.
I truly don't know what you prioritise in this project, if "stateless" operation or any sort of flexible interoperation.  So it's on your hands. If you think about any other mechanism allowing this sort of functionality without compromising reliability, I am all ears.
Have a nice day!


GDScript 2.0: @onready @export var n: Node = $Default breaks.

Godot version
4.0.alpha11
System information
Linux
Issue description
Consider the following line:
@onready @export var n: Node = $Node2D:

This is an export for a Node with a default value. The default value forces me to use onready.
However due to initialisation order, if I set a custom export value in the inspector, the following happens:

the exported value is set on init
since the variable is onready, the default value is then set on ready, overriding the exported one, meaning you can't actually export.

Even worse, if a setter is defined the setter is called when setting the exported value before simply overriding this value with the default one and without calling the setter:
extends Node3D

@onready @export var n: Node = $Foo:
	set(value):
		print("setter n was ", n, " now ", value)
		n = value

func _init() -> void:
	print("init ", n)

func _ready() -> void:
	print("ready ", n)

prints:
init null
setter n was null now Bar:[Node2D:24763171212]
ready Foo:[Node2D:24746393997]

Steps to reproduce
extends Node

@onready @export var five := 5

func _ready() -> void:
	print(five)

Minimal reproduction project
No response

Hi @mieldepoche! Sorry for the delay, I was combing through the GDScript issues today when I stumbled upon your issue.
Just a quick note: I had trouble understanding the issue, but I think I was able to create a minimal reproduction project that represents what you were trying to explain:
62741.zip
But please, especially when the code seems simple to reproduce but involves creating and assigning nodes, please create and join a MRP to the issue. It saves time for the contributors and you make sure that they are on the same page of you.

Personally, I think that it doesn't break, that it does exactly what it says on the tin.
The @onready annotation is defined as this in the docs.

var my_label

func _ready():
   my_label = get_node("MyLabel")

This can get a little cumbersome, especially when nodes and external references pile up. For this, GDScript has the @onready annotation, that defers initialization of a member variable until _ready() is called. It can replace the above code with a single line:
@onready var my_label = get_node("MyLabel")

Is this frustrating to use? Maybe. I suggest you to rather add inside your _ready() method:
extends Node3D

@export var n: Node

func _ready():
    if n == null:
        n = $Foo

@anvilfolk just made me realize that every instance of @onready @export would overwrite the exported value with the defined value, no matter the circumstances.
Maybe @onready should always check if a value was assigned first before assigning the value.

I only think this applies to nodes. Can anyone think of another situation where @onready @export@ would be used together? The documentation describes the usage of @onready as basically to obtain node references at runtime.
For example, I don't think the following scenario makes any sense.
@onready @export some_var_from_child : int = $child_node.some_var

There is no point in the @export because either 1) $child_node exists, and therefore the default value should be overwritten, or 2) $child_node does not exist and the code explodes.
So basically, I think this issue describes the only situation in which both @onready @export annotations would be used. So if there's only one use case, nothing else is broken by changing current behavior, and current behavior is unintuitive and unhelpful, it probably makes sense to have it behave as expected?

I guess the alternative is to do what you did in 3.5, which is @export a NodePath and @onready a Node based on the exported NodePath - but the whole point of being able to use nodes is to avoid that mess :)

This is partially fixed by #72487.

Fixes (kind of) https://github.com/godotengine/godot/issues/62741 by making this case an error by default. I believe we can discuss better behavior for a later release (which might break compatibility but get to be actually useful).

Moving to 4.x milestone then as the immediate problem is addressed for 4.0.

Previous PR was reverted, and then superseded by https://github.com/godotengine/godot/pull/72608. The same note as above applies.


Move notification to its own module

Most mobile app will need notifications. We'll keep it in the framework. @hemish11 @snehmehta.


First sketch of schemas for computational provenance in EBRAINS

I'm not sure about how the extension mechanism works, so this will almost certainly need work.

It would be interesting how some interesting information could be retrieved later using this schema such as

Resource utilization patterns for different software of a computations, i.e. how much and which resources were used by a specific computation (In this case, more utilization data might be needed to be stored than just the core hours),
This could further be decomposed to the specific software of a computation such that how much and which resources were used by a specific software of a computation (this could help later in identifying the most resource hungry component of the cosim framework),
Correlation between different environment/hardware/parameter settings and the execution time (performance) of a (given software of a) computation, etc.

Could it be possible to also store the power/energy consumption data for computations i.e. how much power is consumed by a given computation?

From the json files,
the resourceUsage type should be array to capture more data than just core hours (that's what I pointed to in the comment).
Further It is not clear whether the computation data is stored for models and software as it has 1 to many relationship with them but the json files does not include any link to them... I'm not sure if the relations are already defined in the schemas (in other repos such as core/research/protocolExecution.schema.tpl.json) which it is extending. So, I just left a comment to mention the case to be covered.
Lastly, based on the current design the model version schema can further be decomposed to a set of simulation actions and plan. I left it however so we could finalize the schemas for that ourselves in tomorrow's meeting before pointing it out here.

Michael Denker commented here:
Regarding the Computation component, it may be worth considering adding a log entry that would point to a resource (e.g., a File) that contains the execution logs. Although these log files are in a way part of the output, at the same time they play a very special role in the context of workflow execution and a user may want to be able to quickly access these info.

Michael Denker commented here:
Regarding Protocol, I find the term fitting, and it relates to the existing schemas. However, I could imagine some people may not associate an execution call as computational protocol, but rather only an experimental process. One may consider a different name as alias ('Execution', 'Call", "Spawn",...), or a more generic term.

@mfahdaz @w-klijn as you suggested I've made "resourceUsage" an array so we can track consumption of different types of resource.
@w-klijn I've added Optimization as a specific sub-class of Computation that can have ModelVersion as output. For now, I've removed the "output" link to SoftwareVersion from the diagram, although we may wish to add a new computation sub-class "CodeGeneration" (for NESTML, etc.)
@mdenker re: log files, I think we could handle this by giving the FileInstance representing the log files a specific content type, but this should be discussed further.
@mdenker re: Protocol. I agree, this is the weakest part of the current proposal; the name comes from the parent class of Computation, core.ProtocolExecution. However, we may consider having an abstract parent class from which both Computation and Protocol Execution will inherit, in which case a more appropriate name and type could be chosen.


Change class styles

In c++, class is usually written like this "Transaction"  not a "transaction" etc. Why did you change class name styles? And, variables is usually written like this "nameTable" not a "name_table".
Example
class string
class transaction

Define usually. All the C++ standard and Boost classes, for example, are lowercase.


Is80 refatorar frontend

Refatoramos o front end e melhoramos o workflow do site.

Pull Request Test Coverage Report for Build 349

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.273%

Totals

Change from base Build 295:
0.0%

Covered Lines:
1290

Relevant Lines:
1354

💛  - Coveralls