Add libhvee as alternative Hyper-V driver on Windows

Fixes #3811
Basic functionality for:

create
start
stop
delete

rebase broke the build:
Error: pkg\crc\preflight\preflight_checks_windows.go:14:2: cannot find package "." in:
	D:\a\crc\crc\vendor\github.com\crc-org\crc\pkg\crc\constants
Error: pkg\crc\machine\driver_windows.go:7:2: cannot find package "." in:
	D:\a\crc\crc\vendor\github.com\crc-org\crc\pkg\crc\machine\config
Error: pkg\crc\machine\driver_windows.go:8:2: cannot find package "." in:
	D:\a\crc\crc\vendor\github.com\crc-org\crc\pkg\crc\machine\libhvee
Error: pkg\crc\machine\driver_windows.go:9:2: cannot find package "." in:
	D:\a\crc\crc\vendor\github.com\crc-org\crc\pkg\drivers\libhvee
Error: pkg\crc\machine\driver_windows.go:10:2: cannot find package "." in:
	D:\a\crc\crc\vendor\github.com\crc-org\crc\pkg\libmachine
Error: pkg\crc\machine\driver_windows.go:11:2: cannot find package "." in:
	D:\a\crc\crc\vendor\github.com\crc-org\crc\pkg\libmachine\host

and for my local build I get:
go: finding module for package github.com/crc-org/crc/pkg/crc/constants
go: finding module for package github.com/crc-org/crc/pkg/crc/machine/config
go: finding module for package github.com/crc-org/crc/pkg/libmachine
go: finding module for package github.com/crc-org/crc/pkg/drivers/libhvee
go: finding module for package github.com/crc-org/crc/pkg/libmachine/host
go: finding module for package github.com/crc-org/crc/pkg/crc/machine/libhvee
pkg/crc/preflight/preflight_checks_windows.go:14:2: cannot query module due to -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)
pkg/crc/machine/driver_windows.go:7:2: cannot query module due to -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)
pkg/crc/machine/driver_windows.go:8:2: cannot query module due to -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)
pkg/crc/machine/driver_windows.go:9:2: cannot query module due to -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)
pkg/crc/machine/driver_windows.go:10:2: cannot query module due to -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)
pkg/crc/machine/driver_windows.go:11:2: cannot query module due to -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)
make: *** [Makefile:105: out/windows-amd64/crc.exe] Error 1

Not sure what the problem is

These are the results for this PR on windows https://crcqe-asia.s3.amazonaws.com/nightly/ocp/4.13.12/20231005/11-pro/qe-results/e2e-non-ux.xml all green except the known issue with the latest version for the pipelines operator

Want to incorporate 9P, but the current codebase for this lives in the PR https://github.com/containers/gvisor-tap-vsock/pull/280

Want to incorporate 9P, but the current codebase for this lives in the PR containers/gvisor-tap-vsock#280

The code from this gvisor-tap-vsock PR is short, and thus easy to add to the daemon when we need it. But there's also some guest code involved, which might be trickier https://github.com/mheon/libpod/commit/334e213662adcd71097df07e1090db53c03d15f7

@cfergeau it basically is the same/similar code as the 9p-ufs that I tested with earlier, so I am not so concerned. I am more curious if this will therefore be part of a library, or the changes for libpod remain seperate?

ref: #3870

This PR needs https://github.com/containers/libhvee/pull/66

Rebased again, and added support for disk resize in https://github.com/cfergeau/crc/tree/libhvee (untested)
Seeing that the branch is in github.com/crc-org, I'll just force push to it instead of keeping my own branch.

rebasing isn't straightforward due too much fumbling in vendor. I'll drop the other 3 commits, as they aren't related to this change.

This is still WIP, but I've tested that this works, including disk resize.
The 9p code needs more work which is described in the relevant commit log.

Given https://github.com/crc-org/crc/issues/3870#issuecomment-2074870282 , I'd punt 9p support for now.

Given #3870 (comment) , I'd punt 9p support for now and work on merging the libhvee code with no changes to the file sharing code.

Maybe we need to use https://github.com/aperezdc/9pfuse?tab=readme-ov-file or something similar.

work on merging the libhvee code with no changes to the file sharing code.

Do you mean to target SMB or leave as in the current PR (no support)

Ideally, use the same SMB support as what we have now. I haven't checked if this PR removes some SMB support, but hopefully it's still there?

Originally the PR removed it, but part of it is there... just never tested. Note: we have no automated tests for this :-s.

Tested this PR on windows and the SMB based file sharing and it is working as expected, have to use the windows MSI installer, then the following config options needs to be set before crc start
$ crc config set host-network-access true
$ crc config set shared-dir-password <login_user_pass>
$ crc config set enable-shared-dir true

While testing i also noticed that error messages from the libhvee driver is a bit concise than the older hyperv driver, e.g
from libhvee..

from hyperv driver

@anjannath this is a side effect of the WMI use. The powershell interface is more verbose, though also not always right. When WMI is used, you only get return codes back from the 'queries' and 'requests' that are performed. This would need to be a refinement in the libhvee library. Perhaps file an issue upstream for this?

/me tested and concludes: "works as expected"

Everlasting rebasing

Everlasting rebasing

Rebase done.

@lilyLuLiu @adrianriobo For this change, the proxy tests are failing. Do we have more information aroudn this?

@gbraad those are mainly failing due to timeout on the full suite, let me check downstream running only that one I will ack if it is green (and will increase the timeout for the suite here)

@gbraad @adrianriobo Download stream test of this PR is green for Windows.

:pray: hold till today mid day need to check something else

Full green on downstream windows env

Didn't we wait too long though? We held this PR a while back as we did not want to land it at the same time as the switch to 4.16. The next crc release could be 4.17-based, should we delay this again by one release?

Since it is pass the pipeline, I don't think we should hold it any longer. I am merging this now.

Since it is pass the pipeline, I don't think we should hold it any longer. I am merging this now.

We held it last time because QE had concerns about their capacity to deal with 2 large changes at once, would have been nice to wait for their input before merging this..

No worries, I am fine with it, as @praveenkumar this already passed  (and actually has been passing for a while now). So I think we should be good.

Thank you all


add greysec and bluesec loaduts

Why / Balance
it's good
resolves #27018
Media

:cl:

tweak: Grey and blue security jumpsuits are now available in the security officer loadout.

blue sec should be removed from the game

blue sec should be removed from the game

why???

Remove the blue sec equipment

can we at least get a reason for why?

Remove the blue sec equipment

ok

Remove the blue sec equipment

Why no blue sec? We have it in the sec drobe already, its not like its a forbidden item.

I just enjoy it since
A. Actually look like a cop
B. HL1 reference
grey is just cold and red is well, aggressive. Blue is great for playing a good friendly sec. Side note I love the tie.

Honestly I think I prefer blue sec to red sec.

Yeah resprite sec to be navy blue
No red because sec not syndies, no grey because sec not greytide :trollface:


TypeScript 4 error: accessors overriding properties in AzExt*TreeItem

Thanks to a new error in TypeScript 4, many errors get thrown when trying to build vscode-azureextensionui (or, a consumer of its TreeView framework) against TS 4.0.

I think fixing this would require defining these "properties" as abstract, which means consumers would have to implement them (which would make this a breaking change). If they are abstract, the implementer can implement them either as properties or as accessors.

@EricJizbaMSFT I'm happy to help with the fix here. Do you have any thoughts on how to go about it? I think that changing the class declarations to interfaces would work, but my understanding of libraries / declare / etc. is not very strong.

Yeah we don't have any immediate plans to upgrade to TypeScript 4, so I probably wouldn't get to this any time soon. You're welcome to take a shot at it and feel free to make breaking changes if necessary

I got started and immediately realized this is going to be a nightmare. There are probably 50+ files in the Docker extension alone that would need changes...

I found a somewhat less-intrusive solution that unblocked Docker without needing changes here: https://github.com/microsoft/vscode-docker/pull/2348
In short, I have intermediate abstract classes that redefine the parent (AzExtTreeItem, AzExtParentTreeItem) properties as abstracts, allowing inheriting classes to implement the abstract as either a property or an accessor. I don't think that solution is applicable to this repo though.


Text element inside VictoryLabel

Is there any chance to use Text element from react-native? I want to display icons as labels and I use react-native-vector-icons, this library wraps SVG icon element with Text element from RN and for now it's not visible.

@bear-junior unfortunately no. You can't include a non-svg element within an svg tag without the help of foreignObject, and I don't believe it has been implemented in react-native-svg.


dev release channel for augur app

Once this is done, please be sure to re-test the bug we were seeing where installing a pre-release and then attempting to upgrade was preventing upgrades from working properly (https://github.com/AugurProject/augur-app/issues/423).


text-lighten class not documented?

I was reading http://materializecss.com/footer.html page and I saw that
<a class="grey-text text-lighten-3" href="#!">

was being used, so I headed to http://materializecss.com/color.html but I can't see text-lighten-* class mentioned anywhere. There's lighten-* but it's not the same. So I am mildly confused.
I think there's a docs issue here.

Turns out it is actually documented, kind of hard to see.


[Bug]: Rspack build stuck if using splitChunks.maxSize and import CSS

System Info
System:
OS: macOS 13.6.3
CPU: (10) arm64 Apple M1 Pro
Memory: 2.73 GB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Yarn: 1.22.19 - ~/Library/Application Support/fnm/node-versions/v18.19.0/installation/bin/yarn
npm: 10.2.3 - ~/Library/Application Support/fnm/node-versions/v18.19.0/installation/bin/npm
pnpm: 8.15.3 - ~/Library/Application Support/fnm/node-versions/v18.19.0/installation/bin/pnpm
Browsers:
Chrome: 121.0.6167.184
Safari: 16.6
npmPackages:
@rspack/cli: 0.5.4 => 0.5.4
@rspack/core: 0.5.4 => 0.5.4
Details
Rspack build paused when settting minSize/maxSize in splitChunks and import CSS:
const config = {
  mode: "production",
  optimization: {
    splitChunks: {
      chunks: 'all',
      cacheGroups: {},
      minSize: 10 * 1000,
      maxSize: 50 * 1000
    }
  },
  experiments: {
    css: true,
  },
};

Webpack succeed:

Rspack stuck:

Rsbuild stuck:

Reproduce link
https://github.com/chenjiahan/rsbuild-repo-split-by-size
Reproduce Steps

git clone git@github.com:chenjiahan/rsbuild-repo-split-by-size.git
pnpm i
pnpm build:rspack

Should be fixed by #5700


fails on iojs v2

the error messages are pretty annoying =/

can you please elaborate ?

i'm getting the following message after upgrading:
[Error: Module did not self-register.]
js-bson: Failed to load c++ bson extension, using pure JS version

let me add iojs v1 and 2 to the travis. if those pass, i'll be happy. it's currently failing though https://travis-ci.org/imlucas/bson-ext/jobs/61629492

that looks like you just built the extension on one version of node and then switched versions of node or iojs that does not support the v8 c++ api the extension was originally compiled against. you need to clean  NPM and recompile all the extensions with the new node/iojs runtime


[KeyVault] - Address architecture review comments

Packages impacted by this PR
@azure/keyvault-keys
Issues associated with this PR
N/A
Describe the problem that is addressed by this PR
A running PR addressing any and all architect review comments before releasing
keyvault keys.
Changes made so far:

updateKeyRotationPolicy: rename name to keyName
getKeyRotationPolicy: rename name to keyName

Are there test cases added in this PR? (If not, why?)
Checklists

[x] Added impacted package name to the issue description.
[x] Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
[ ] Added a changelog (if necessary).

API changes have been detected in @azure/keyvault-keys. You can review API changes here
API changes
-     getKeyRotationPolicy(name: string, options?: GetKeyRotationPolicyOptions): Promise<KeyRotationPolicy>;
+     getKeyRotationPolicy(keyName: string, options?: GetKeyRotationPolicyOptions): Promise<KeyRotationPolicy>;
-     updateKeyRotationPolicy(name: string, policy: KeyRotationPolicyProperties, options?: UpdateKeyRotationPolicyOptions): Promise<KeyRotationPolicy>;
+     updateKeyRotationPolicy(keyName: string, policy: KeyRotationPolicyProperties, options?: UpdateKeyRotationPolicyOptions): Promise<KeyRotationPolicy>;


Adding check for isyieldable.

I recently synced my plugins and it seems like #1583 did cause an issue. Specifically what was happening is that when getting sources, the couroutine.isyieldable method would not exist. I did some research looking through neovim's docs/help-pages and found no reference to this function both online and in the help-pages. My rudimentary conclusion is that potentially I am running an outdated version of neovim where this method does not exist on coroutines yet and I potentially need to upgrade.
If I am right in this I suggest either adding a note to the breaking changes page or refine/merge this PR so that other versions of neovim continue to work here.
My current running version of neovim is v0.9.0 Release with LuaJIT 2.0.4

I think LuaJIT supports coroutine.isyieldable.
https://github.com/LuaJIT/LuaJIT/blob/v2.1/doc/extensions.html#L367

So that explains the discrepancy. So would it be a good idea to potentially add a note in the breaking changes doc? I would find it surprising if I was the only person with an outdated LuaJit.

Yes. I agree your suggetion. We should add breaking change announcement.
but wait, what the version of the coroutine.isyieldable was added to LuaJIT?
I can't find any version related note from above page.

Yes. I agree your suggetion. We should add breaking change announcement.
but wait, what the version of the coroutine.isyieldable was added to LuaJIT? I can't find any version related note from above page.

I've been having trouble finding reference to it too. In the file you linked to it seems to imply that version 5.3 is the version that it was added.

IMO, my link seems to say LuaJIT has extention feature that's come from Lua5.3.

I ran into that issue as well and being new to Lua, LuaJIT and neovim plugins in general, I am glad I found this issue because I don't know how to upgrade LuaJIT in neovim.  Thank you @hrsh7th for the plugin too.
Question though: isn't neovim Lua tied to 5.1 though?  When I go to :help lua-compat, it sounds like the interface is anchored to 5.1.

@hrsh7th this can be closed, since I already removed coroutine.isyieldable in my PR you just merged :)


credhub export/import loses 'signs' and 'signed_by' fields

What version of the credhub server you are using?
Server Version: 2.5.6
What version of the credhub cli you are using?
CLI Version: 2.6.2
If you were attempting to accomplish a task, what was it you were attempting to do?
Migrate certificates from one credhub server to another credhub server by using
$ credhub export > test-export
$ credhub import --file=test-export

What did you expect to happen?
Certificates with filled signs and signed_by fields:
CA:
{
  "id": "ac06b2ea-3ac4-4f11-a6bd-f3ee7a5ef071",
  "name": "/dns_healthcheck_tls_ca",
  "signed_by": "/dns_healthcheck_tls_ca",
  "signs": [
     "/dns_healthcheck_server_tls",
     "/dns_healthcheck_client_tls"
  ],
}

Signed certificate:
{
  "id": "5a1e0e4d-301e-41ac-92c8-c934ae9aec17",
  "name": "/dns_healthcheck_server_tls",
  "signed_by": "/dns_healthcheck_tls_ca",
  "signs": [],
}

What was the actual behavior?
The signs and signed_by fields were empty:
CA:
{
  "id": "ac06b2ea-3ac4-4f11-a6bd-f3ee7a5ef071",
  "name": "/dns_healthcheck_tls_ca",
  "signed_by": "/dns_healthcheck_tls_ca",
  "signs": [],
}

Signed certificate:
{
  "id": "5a1e0e4d-301e-41ac-92c8-c934ae9aec17",
  "name": "/dns_healthcheck_server_tls",
  "signed_by": "",
  "signs": [],
}

Please confirm where necessary:

[ ] I have included a log output
[ ] My log includes an error message
[x] I have included steps for reproduction

If you are a PCF customer with an Operation Manager (PCF Ops Manager) please direct your questions to support (https://support.pivotal.io/)

@KaiHofstetter thank you for this submission. We have received this request before. The TL;DR is that the export/import CLI feature was contributed to the CLI via a community PR and thus is missing some features. It is expected behavior that the post-import in-API certificate forest would be missing the signed_by and signs information, because that information is never written out in the export.
Would you be amenable to submitting a PR for this behavior?

Also, can you tell me why you use this export/import command flow, as opposed to, say, bbr? We are doing some research on these two CLI commands.

@ankeesler thank you for your feedback.
We are using {{export / import}} to migrate certificates/credentials between CredHub instances. It seemed to be the easiest way.
We were not aware of the fact that it does not include the {{signed_by}} and {{signs}} fields.
I'll look into it and provide a PR if it is feasible.

@ankeesler I looked into to the issue.
The problem is that credhub export exports the ca value of a signed cert instead of the ca_name and credhub import only fills the signed_by and signs fields if the cert contains the ca_name:
- name: /cert
  type: certificate
  value:
    ca_name: /ca
    certificate: ...
    private_key: ...

I think there are two ways to fix it:
a) credhub export exports ca_name instead of the ca value for signed certs
or
b) credhub import tries to find in the import file the ca_name for used ca values
I would opt for option a) and provide a PR if that is ok.

@ankeesler I just added the feature to the export code. The import code already handles ca_name correctly and also ensures the correct import order of certificates and cas (see here)

@KaiHofstetter Thanks for the PR, we'll review it.


Removed step to set ID on sent activities

Background
At present in C# we set an ID on outgoing activities in the SendActivitiesThroughAdapter method on the TurnContext.
https://github.com/microsoft/botbuilder-dotnet/blob/d085ac8220bbd990565db75639fa53d9816bf6bf/libraries/Microsoft.Bot.Builder/TurnContext.cs#L270-L285
This is not something that is done in the corresponding JS method.
https://github.com/microsoft/botbuilder-js/blob/7d861550bd1548b230a073275356c510a9da3b28/libraries/botbuilder-core/src/turnContext.ts#L297-L306
This step of setting the ID causes issues, such as RetryPrompt activities being sent with the same ID multiple times, which causes side effects such as subsequent activities not being shown in the emulator.  Multiple issues concerning this have been reported.
https://github.com/microsoft/BotFramework-Emulator/issues/1888
https://github.com/microsoft/botbuilder-dotnet/issues/2689
https://github.com/microsoft/botbuilder-dotnet/issues/2690
This change removed the step of setting the activity ID from C#.
I do not see any side effects of removing this, especially given that parity between the two languages should have been maintained elsewhere.  @cleemullins / @tomlm please chime in if you know of a reason we should leave this in.
Also considered
I also considered leaving the ID setting in, but altering the prompts to send a copy of the retry activity, as opposed to changing the TurnContext.  This would have the effect of fixing the reported bugs, but would leave the C# and JS repos out of sync and would also leave the underlying issue in place, which could show up again. As @mdrichardson pointed out in one of the issue threads, there is a possibility that a developer may have written code expecting that some activities may have a duplicate ID, but I don't believe we have any concrete examples of this.  Therefore, I think it is a better approach for us to bring the two languages in line.

Pull Request Test Coverage Report for Build 82920

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.003%) to 78.594%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs
1
76.24%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs
1
57.23%

/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs
2
50.0%

/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs
2
86.09%

/libraries/Microsoft.Bot.Builder/TurnContext.cs
5
89.29%

Totals

Change from base Build 82882:
-0.003%

Covered Lines:
5401

Relevant Lines:
6872

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

Code-wise, I approve. Backwards-compat-wise, I'm not sure--I agree that I haven't come across any customer code this would affect (that I can recall). I'm going to remove myself as reviewer and leave it up to the big guns to decide.

Adding you @johnataylor as I believe you added this line in initially, so I would be interested in your thoughts.

I'm going to close this PR for now, on the basis of @EricDahlvang's comment and the fact that this will likely affect logging. I will reopen another PR once I test another approach. Right now I am thinking we could clone the activity, but not specifically the RetryPrompt - I'm thinking we clone the activity before we add it to the buffered activities collection.


Unable to install extensions in VS Code Tests using the CLI

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Latest Insiders.
OS Version: Mac

Steps to Reproduce:

Run the VS Code-Jupyter tests on CI and it fails.

Here are the logs where we use the VS Code test cli to download VS Code and install the Python extension
Basically it looks like we cannot install any extension into VS Code
I have tried this locally as well and the same code falls over
Here is the code used to isntall the extension
    const cliPath = resolveCliPathFromVSCodeExecutablePath(vscodeExecutablePath, platform);
    spawnSync(
        cliPath,
        [
            '--install-extension',
            PythonExtension,
            '--pre-release',
            '--extensions-dir',
            extensionsDir,
            '--disable-telemetry'
        ],
        {
            encoding: 'utf-8',
            stdio: 'inherit'
        }
    );

here are the logs
Start Standard tests
Found existing install in /Users/donjayamanne/Desktop/development/vsc/vscode-jupyter/.vscode-test/vscode-darwin-insiders. Skipping download
Installing Python Extension ms-python.python to /var/folders/fv/524cyb9j03s16612v0f52g4h0000gn/T/vscode_jupyter_exts
ENOENT: no such file or directory, open '/Users/donjayamanne/Desktop/development/vsc/vscode-jupyter/.vscode-test/vscode-darwin-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js'

If i try this manually in the terminal this fails
'/Users/donjayamanne/Desktop/development/vsc/vscode-jupyter/.vscode-test/vscode-darwin-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/bin/code' --install-extension ms-python.python --pre-release --extensions-dir=/Users/donjayamanne/Desktop/development/vsc/vscode-jupyter/tmp/x
ENOENT: no such file or directory, open '/Users/donjayamanne/Desktop/development/vsc/vscode-jupyter/.vscode-test/vscode-darwin-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js'

Here is the same CLI with the stable version of VS Code
/Users/donjayamanne/Desktop/development/vsc/vscode-jupyter/.vscode-test/vscode-darwin-1.75.1/Visual Studio Code.app/Contents/Resources/app/bin/code' --install-extension ms-python.python --pre-release --extensions-dir=/Users/donjayamanne/Desktop/development/vsc/vscode-jupyter/tmp/x
Installing extensions...
Installing extension 'ms-python.python'...
(node:13548) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Electron --trace-deprecation ...` to show where the warning was created)

Thanks, I was not aware that upstream modules depend on the path to our CLI. I will revert that part of the move.


Minor list formatting issue

The sample app does not render the list "brief summary of the various attributes" without this whitespace before the start of the list.

Docs Build status updates of commit 9c3d58d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/mvvm/generators/INotifyPropertyChanged.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


ldaps contact error

[root@MiWiFi-R3P-srv certs]# ldapsearch -x -d 1 -v -H ldaps://localhost -b dc=example,dc=org -D "cn=admin,dc=example,dc=org" -w admin
ldap_url_parse_ext(ldaps://localhost)
ldap_initialize( ldaps://localhost:636/??base )
ldap_create
ldap_url_parse_ext(ldaps://localhost:636/??base)
ldap_sasl_bind
ldap_send_initial_request
ldap_new_connection 1 1 0
ldap_int_open_connection
ldap_connect_to_host: TCP localhost:636
ldap_new_socket: 3
ldap_prepare_socket: 3
ldap_connect_to_host: Trying ::1 636
ldap_pvt_connect: fd: 3 tm: -1 async: 0
attempting to connect:
connect success
TLSMC: MozNSS compatibility interception begins.
tlsmc_intercept_initialization: INFO: entry options follow:
tlsmc_intercept_initialization: INFO: cacertdir = (null)' tlsmc_intercept_initialization: INFO: certfile = (null)'
tlsmc_intercept_initialization: INFO: keyfile = (null)' tlsmc_convert: INFO: trying to open NSS DB with CACertDir = (null)'.
tlsmc_convert: INFO: cannot open the NSS DB, expecting PEM configuration is present.
tlsmc_intercept_initialization: INFO: altered options follow:
tlsmc_intercept_initialization: INFO: cacertdir = (null)' tlsmc_intercept_initialization: INFO: certfile = (null)'
tlsmc_intercept_initialization: INFO: keyfile = `(null)'
tlsmc_intercept_initialization: INFO: successfully intercepted TLS initialization. Continuing with OpenSSL only.
TLSMC: MozNSS compatibility interception ends.
TLS trace: SSL_connect:before/connect initialization
TLS trace: SSL_connect:SSLv2/v3 write client hello A
TLS trace: SSL_connect:SSLv3 read server hello A
TLS certificate verification: depth: 1, err: 19, subject: /C=US/O=A1A Car Wash/OU=Information Technology Dep./L=Albuquerque/ST=New Mexico/CN=docker-light-baseimage, issuer: /C=US/O=A1A Car Wash/OU=Information Technology Dep./L=Albuquerque/ST=New Mexico/CN=docker-light-baseimage
TLS certificate verification: Error, self signed certificate in certificate chain
TLS trace: SSL3 alert write:fatal:unknown CA
TLS trace: SSL_connect:error in error
TLS trace: SSL_connect:error in error
TLS: can't connect: error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed (self signed certificate in certificate chain).
ldap_err2string
ldap_sasl_bind(SIMPLE): Can't contact LDAP server (-1)
can not centact LDAP over ldaps

把域名改成自己的，如果没有 ssl 证书把它关了试下


Fix execution_count, and only show new_data if it not empty

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.64%. Comparing base (5937b88) to head (516e24c).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   75.75%   79.64%   +3.89%
==========================================
  Files          70       65       -5
  Lines        4615     4908     +293
==========================================
+ Hits         3496     3909     +413
+ Misses       1119      999     -120

Flag
Coverage Δ

python-3.11
79.64% <100.00%> (+3.97%)
:arrow_up:

python-3.9
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


JSON build args are escaped incorrectly.

👋
Behaviour
Example run: https://github.com/ruslandoga/analytics/actions/runs/3502829623/jobs/5867478399
Note that the second tag is not quoted.
/usr/bin/docker buildx build --build-arg BUILD_METADATA={"tags":["ghcr.io/ruslandoga/analytics:pr-13",ghcr.io/ruslandoga/analytics:build-upstreamed-clickhousex,ghcr.io/ruslandoga/analytics:d3e5448,"ghcr.io/ruslandoga/analytics:build-upstreamed-clickhousex-d3e5448"]

Steps to reproduce this issue
I can prepare a separate repo to reproduce the problem if needed.
Expected behaviour
The build args are copied as is:
build-args: BUILD_METADATA={"tags":["ghcr.io/ruslandoga/analytics:pr-13","ghcr.io/ruslandoga/analytics:build-upstreamed-clickhousex","ghcr.io/ruslandoga/analytics:d3e5448","ghcr.io/ruslandoga/analytics:build-upstreamed-clickhousex-d3e5448"],"labels":{"org.opencontainers.image.title":"analytics","org.opencontainers.image.description":"Simple, open-source, lightweight (< 1 KB) and privacy-friendly web analytics alternative to Google Analytics.","org.opencontainers.image.url":"https://github.com/ruslandoga/analytics","org.opencontainers.image.source":"https://github.com/ruslandoga/analytics","org.opencontainers.image.version":"pr-13","org.opencontainers.image.created":"2022-11-19T08:50:55.539Z","org.opencontainers.image.revision":"d3e544892b4bfe260d10dbbd579de08cf9936a1c","org.opencontainers.image.licenses":"AGPL-3.0"}}

Actual behaviour
Something happens to build args before they are passed to buildx and they lose their initial structure.
# paste your YAML workflow file here and remove sensitive data

Logs
logs_392.zip

🙈 wrong repo.


AutoForm.getFieldValue don't return value after upgrade into 5.4.1

I just upgraded autoform from 5.4.0 into 5.4.1 and now AutoForm.getFieldValue('field_name') returns undefined. After downgrade back into 5.4.0 everything works well.

same problem here...

Same problem here. It seems like putting the form Id into the last parameter helps for some reason.
Every instance where I use the global helper afFieldValue also broke.

Same behavior here. Breaking on version 5.4.1 but supplying formId works.
For context I'm calling AutoForm.getFieldValue via a template helper within the #autoForm block.

I can confirm that afFieldValueIs is broken in 5.4.1.

Yep, I do confirm, too.
I'm declaring autoform options within the schema. Since the schema is not aware of which form (insert/update) it is being called from, how do I obtain a valid formId to pass to getFieldValue so that I can work around the problem?

I also confirm the issue with 5.4.1.  Unsurprisingly, it's still broken in 5.5.0.

A rather not-so-elegant workaround is:
var formId = Autoform.getFormId();
var fieldValue = Autoform.getFieldValue('field', formId);

For me it looks like it has a problem with getting the value on the first time its rendered (so 'afFieldValueIs/AutoForm.getFieldValue' returns undefined while the form is not fully rendered)
I removed two !template.view._domrange checks but now I am stuck as he is trying to read in the DOM what the current value of the field is.
I will look more into it, but unfortunately I don't know Blaze/Meteor very well yet, so if anyone knows how automatically rerun the function when the DOM is ready please answer ;-)
For now I will look more into Autoform and try to see if I somehow get to the form data.

I've merged some PRs. Please see whether this is fixed for you with 5.6.0 release

Unfortunately it's still broken.

In 5.7.1 it's still broken. I have to use @serkandurusoy proposed workaround.

I can confirm that it is still broken.
I use the same workaround and my code looks messy :(

BTW, as an alternative in schema I use @siblingField("field_name").value

+1

@aldeed any updates on this?


Allow user to provide a desired code coverage level.

Many customers are asking for the ability to run RSpec-puppet via Bamboo or Jenkins and enforce a certain level of code coverage.
This should be an option and not a default requirement.

https://github.com/rodjek/rspec-puppet/pull/369

i assume this can be closed now


⚠ Bofrost.at has degraded performance

In 5d0195a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1984 ms

Resolved: Bofrost.at performance has improved in 7997f2b.


Real-time change mode/theme

Hello, I need to change the mode (light/dark) of an application while it is running, how can this be implemented correctly? I tried it:
import tkinter as tk
from tkinter import ttk
import TKinterModernThemes as TKMT

class SetUp(TKMT.ThemedTKinterFrame):
    def __init__(self, theme, mode, usecommandlineargs=True, usethemeconfigfile=True):
        def changethemecolor():
            mode = self.mode
            if mode == 'light':
                mode = 'dark'
            elif mode == 'dark':
                mode = 'light'
            self.master.destroy()
            SetUp(theme, mode)
        button_qwer = tk.Button(self.master, text="Change themecolor", command=changethemecolor, highlightthickness=0, bd=0, anchor='ne')
        button_qwer.grid(row=1, column=3, padx=3, pady=0)
        self.run()

But my application restarts by itself, but one of the buttons is in a separate window for some reason. If I remove the function of closing the old window self.master.destroy(), the mode changes for the old application too, but without calling the new window it doesn't change in any of the windows :(

Ok, I solved the problem with the button appearing in a new window: it needed to be given a parent (self.master) as the first argument. However, still with such a crummy theme change an empty window appears:

You can swap the theme in real time by using self.root.tk.call("set_theme", "light") or self.root.tk.call("set_theme", "dark") in the application class.
import TKinterModernThemes as TKMT

class App(TKMT.ThemedTKinterFrame):
    def __init__(self, theme, mode, usecommandlineargs=True, usethemeconfigfile=True):
        super().__init__("Theme Demo", theme, mode,
                         usecommandlineargs=usecommandlineargs, useconfigfile=usethemeconfigfile)

        self.frame = self.addLabelFrame("Accent Button Frame")
        self.frame.AccentButton("Accent Button", self.handle_button_click)
        self.run()

    def handle_button_click(self):
        self.root.tk.call("set_theme", "light")

if __name__ == "__main__":
    App("park", "dark")

I added some example code to show swapping between light and dark themes.
https://github.com/RobertJN64/TKinterModernThemes/blob/master/TKinterModernThemes/examples/theme_swap.py
Please let me know if you need anything else!

thank you, that helped for me. However, I had to change the theme button image along with the theme update, which I easily fixed through reinitializing the button and self.run().
Again, thanks


Add myself as a "code owner" for some files in need of review

Details
Several areas of this codebase are performance sensitive and/or complex areas that require extra care. I would like to temporarily watch these areas for some time and help make sure C+ and our contributors are making the best decisions they can.
Fixed Issues
No Issue.
Tests
No QA

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @nickmurray47 in version: 1.1.46-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Timeout running condition variable signal_spec.rb

Timeout::Error: execution expired running: spec/core/conditionvariable/signal_spec.rb

Probably a duplicate of #1966 but I'm leaving it here because the error is slightly different and I want double the satisfaction for fixing it. 😃

I worked on this a bit this morning. I got a smaller reproduction of the issue, though it still takes about 5 minutes of repeatedly running with multiple processes to trigger the bug.

I marked the place in the code where the thread never joins.
m = Mutex.new
cv = ConditionVariable.new
repeats = 25
in_synchronize = false

t1 = Thread.new do
  m.synchronize do
    in_synchronize = true
    repeats.times do
      cv.wait(m)
      cv.signal
    end
  end
end

# Make sure t1 is waiting for a signal before launching t2.
Thread.pass until in_synchronize
Thread.pass until t1.stop?

t2 = Thread.new do
    m.synchronize do
      repeats.times do
      cv.signal
      cv.wait(m)
    end
  end
end

puts 'stuck here?'

# Check that both threads terminated without exception
t1.join # <================================================== NEVER JOINS

puts 'stuck here?'
t2.join
#puts 'stuck here?'
p m.locked?

With this code:
m = Mutex.new
cv = ConditionVariable.new
repeats = 5
in_synchronize = false

t1 = Thread.new do
  m.synchronize do
    in_synchronize = true
    repeats.times do
      puts 't1 wait'
      cv.wait(m)
      puts 't1 signal'
      cv.signal
    end
  end
end

# Make sure t1 is waiting for a signal before launching t2.
Thread.pass until in_synchronize
Thread.pass until t1.stop?

t2 = Thread.new do
  m.synchronize do
    repeats.times do
      puts 't2 signal'
      cv.signal
      puts 't2 wait'
      cv.wait(m)
    end
  end
end

puts 'stuck here?'

# Check that both threads terminated without exception
t1.join # <================================================== STUCK HERE
puts 'stuck here?'
t2.join
#puts 'stuck here?'
p m.locked?

When the process eventually hangs -- this took way longer to reproduce because all the printing seems to make it more stable -- it produces this output:
t1 wait
stuck here?
t2 signal
t2 wait
t1 signal
t1 wait
t2 signal
t2 wait
t1 signal
t1 wait
t2 signal
t2 wait
t1 signal
t1 wait
t2 signal
t2 wait

This is what is happening here.
Thread 1 calls ConditionVariable#wait which uses Mutex#sleep internally. Mutex#sleep calls Mutex#unlock followed by Thread#sleep. But before Thread#sleep does its thing, Thread 2 gets unlocked and sends a Thread#wakeup to Thread 1. But since Thread 1 isn't yet sleeping, that wakeup gets lost and the thread gets stuck forever.
thread 1                       thread 2
==========================     ==========================
ConditionVariable#wait
  Mutex#sleep
    Mutex#unlock
    Thread#sleep
                               ConditionVariable#signal
                                 Thread#wakeup
                               ConditionVariable#wait
                                 Mutex#sleep
                                 Mutex#unlock
# thread 1 gets woken up
# before thread 2 sleeps
ConditionVariable#signal
  Thread#wakeup
                                 Thread#sleep


Wrong definition it yaml config naming

Hi,
Just working on getting VolantMQ up and running, was having an issue with the default out of the box build, worked out that the Auth Config Order has wrong name :
was
Order     []string yaml:"order"
Should be I think from the default config.
Order     []string yaml:"defaultOrder"
I hope this helps, and is correct.
Cheers
Jason

Same error, add a pull to fix it pull-112.

Merged


MicrosoftDependencyResolver seems to forgot disposing ServiceProvider

https://github.com/EcsRx/SystemsRx/blob/37f8d2d93dc17629da10d734dbdc86cbe60af471/src/SystemsRx.Infrastructure.MicrosoftDependencyInjection/MicrosoftDependencyResolver.cs#L38-L41
Actual type of IServiceProvider _serviceProvider is ServiceProvider, which releases resolved services in it's Dispose() or DisposeAsync(). Additionally, the provider instance is built by MicrosoftDependencyRegistry.BuildResolver().

Hmm the problem is the interface doesnt expose the IDisposable just the underlying implementation, and I think Microsoft let you provide different implementations if you are using lets say AutoFac via the MS abstractions.
We can possibly add a reflection check or something to see if it implements IDisposable as dispose.

Following code might be useful
if (_serviceProvider is IDisposable disposableProvider)
    disposableProvider?.Dispose();

Change has been merged in, release is going out now, thanks for reporting.


Rename crypto->tcrypto and service->tservice

Renaming the trusted crates crypto and service to have a t prefix
to match the linked libraries

Current dependencies on/for this PR:

develop

PR #47   👈

This comment was auto-generated by Graphite.


Implement a webpack watch command over all functions

As I mentioned in #55, with the serverless-offline plugin the current Simulate API Gateway locally feature is pretty outdated and doesn't have so reach features as serverless-offline has. Nevertheless this plugin is great for bundling functions with webpack.
By working with this plugin and serverless-offline the only feature I miss is a watcher for changes in functions code with auto rebuilding.
This plugin has a watch command for separate function only. And a serve is overkill as it not only watches changes but hosts functions too.
It would be great to have a command for watching changes of the whole project code. In this case we probably want the plugin to run separately from serverless-offline so both can do their jobs.

I don't mind having both plugins serve. How did you get serverless-offline work with serverless-webpack's output? All I can do is have them both serve at the same time. One's output is not piped to other's input.

@utkuturunc,
Watch #55, basically I added a hook into serverless-webpack so it makes a build before executing serverless-offline.  And I just run serverless offline and it builds my code and then serves it locally.

@miltador I am using a similar solution. I want to implement watching feature to this solution.

@utkuturunc, I got it. I see it as 2 separate tasks running, one is webpack watcher and another one is serverless offline. serverless-offline plugin doesn't need a restart on code changes. Another approach I see is that webpack watcher will rebuild on code changes and then start serverless-offline plugin. I would prefer the second one as it is simpler for end users.

I think the first choice is better. I am not sure how to handle node_modules though.

I agree that we should have this plugin just do the build and leave the "offline" part to other plugins.
I still haven't grasped how to handle the hot-reloading though. I think it's a must have feature. I'll play around with #55. Any idea is welcome!


Latest release does not have correct export templates

I just downloaded Godot_v2.0_stable_20160223_win32.exe
And then I used this to export my game to windows (.exe) and got an error saying:
godot pack created with newer version of engine
So I redownloaded the new export template from the main website and installed it.
Now it all works wonderfully!
But I think the latest export templates should be included in the latest Godot release? Just a suggestion, thx. Engine works great now though, very fast, love it

No the templates are always distributed separately. For Windows users we could have an installer that bundles both the engine + the templates, but generally speaking each time you update the engine you have to download the new templates too.

Alrighty, no problems thank you!

We should see about having Godot optionally download the export templates
somehow.. and warning you about incorrect version :|
On Sat, Mar 5, 2016 at 11:59 AM, McFarts<EMAIL_ADDRESS>wrote:

Alrighty, no problems thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3929#issuecomment-192665180.


Move repo under haskell org

To have all the official ide components in the same org and make easier its administration (https://github.com/haskell)

//cc @mpickering @fendor @jaspervdj

I can transfer the repo if I am given the permissions needed.

I can transfer the repo if I am given the permissions needed.

@mpickering Sounds good, thanks!  I've sent you an invite that will allow you to move the repo.

We are already here, thanks you all!


Designed & Added favicon in website

Issue Number :
.
.
.
Modified File Path :
.
.
.
Description :
.
.
.
Mentions :
@ShreyamMaity

rename the favicon to icon.png and place it under the assets folder.

placed check it out


use $addFields and $project in aggregation pipelines

Replaces all usages of $set and $unset in aggregation pipelines with $addFields and $project: {XXX: False}, respectively.
This is being done as part of an effort to broaden the compatibility of FiftyOne with older MongoDB versions and other technologies like DocumentDB.

I mean, I think it's the main effect right? No other reason to replace those stages.
There are also many ViewExpression functions that are incompatible such as trim and ceil. Probably not as big of a deal for it to just not work in doc db

I figured the main push was for compatibility with the older mongo versions.
If we're going to target documentDB as a first-class second-class citizen, I think it would be worth it to abstract the db access out further so swapping is a lot easier....which brings up the mongoengine conversation, as well. That's why I was curious if it was a targeted goal from a larger perspective


[WIP] stats: support histogram bucket

Please provide a description of this PR:
implement for: https://github.com/istio/api/pull/2539

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
868bc1550b7aab118d155863a6ec3a3ededcb12c
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
868bc1550b7aab118d155863a6ec3a3ededcb12c
link
true
/test release-notes

gencheck_istio
868bc1550b7aab118d155863a6ec3a3ededcb12c
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
868bc1550b7aab118d155863a6ec3a3ededcb12c
link
true
/test gencheck

release-notes_istio
d0ccf67236fe91ea5ce8aa1da347549ad091ccb9
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d0ccf67236fe91ea5ce8aa1da347549ad091ccb9
link
true
/test release-notes

gencheck_istio
d0ccf67236fe91ea5ce8aa1da347549ad091ccb9
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Feature request: being able to follow internal links in the documentation

Hello,
It would be great if we could follow links in the code documentation / comments in the same way rustdoc handle it.
For example for this snippet of code:
#[async_trait::async_trait]
#[cfg_attr(test, automock)]
pub trait DumpActorHandle {
    /// Start the creation of a dump
    /// Implementation: [handle_impl::DumpActorHandleImpl::create_dump]
    async fn create_dump(&self) -> Result<DumpInfo>;

    /// Return the status of an already created dump
    /// Implementation: [handle_impl::DumpActorHandleImpl::dump_info]
    async fn dump_info(&self, uid: String) -> Result<DumpInfo>;
}

I would like to put my cursor on the handle_impl::DumpActorHandleImpl::create_dump and jump to the definition.

That is actually already implemented, but our doc path resolution isn't fully working yet(I'm currently trying to fix that up) which is why it doesn't work in your case here.

As such I'll close this as an indirect dupe of #9694


ClientProfile reconcile

Describe what this PR does
Initial implications for clientprofiles.csi.ceph.io controller

Controller validation against a cephconnection.csi.ceph.io resource
Shared owner logic for attached cephconnection.csi.ceph.io logic
Shared owner logic for Ceph CSI Config, config map
Reconcile a Ceph CSI Config record into the shared config map
Handle clean-up upon resource deletion (removal of owners, removal of configmap record, etc.)

Is there anything that requires special attention

PR does not include test code. Test code will be added in a new PR
Controller name might need to change as of pending discussion on config.csi.ceph.io name change

@nb-ohad can you please resolve merge conflicts?

can below be included in this PR?
diff --git a/config/rbac/kustomization.yaml b/config/rbac/kustomization.yaml
index c26ae59..3d0a21b 100644
--- a/config/rbac/kustomization.yaml
+++ b/config/rbac/kustomization.yaml
@@ -28,3 +28,21 @@ resources:
 - operatorconfig_viewer_role.yaml
 - driver_editor_role.yaml
 - driver_viewer_role.yaml
+- csi_cephfs_ctrlplugin_clusterrole.yaml
+- csi_cephfs_ctrlplugin_clusterrole_binding.yaml
+- csi_cephfs_ctrlplugin_role.yaml
+- csi_cephfs_ctrlplugin_role_binding.yaml
+- csi_cephfs_ctrlplugin_service_account.yaml
+- csi_cephfs_nodeplugin_clusterrole.yaml
+- csi_cephfs_nodeplugin_clusterrole_binding.yaml
+- csi_cephfs_nodeplugin_service_account.yaml
+- csi_rbd_ctrlplugin_clusterrole.yaml
+- csi_rbd_ctrlplugin_clusterrole_binding.yaml
+- csi_rbd_ctrlplugin_role.yaml
+- csi_rbd_ctrlplugin_role_binding.yaml
+- csi_rbd_ctrlplugin_service_account.yaml
+- csi_rbd_nodeplugin_clusterrole.yaml
+- csi_rbd_nodeplugin_clusterrole_binding.yaml
+- csi_rbd_nodeplugin_role.yaml
+- csi_rbd_nodeplugin_role_binding.yaml
+- csi_rbd_nodeplugin_service_account.yaml

@Madhu-1 I am adding the hold label on this one to make sure that https://github.com/ceph/ceph-csi-operator/pull/65 is merged first. That PR contains a small fix for map-to-string serialization needed in the code supporting Kernal and Fuse mount options.
I cannot just rebase this PR on top of the fix PR because this PR is already rebased on top of the API changes which is not yet merged

can below be included in this PR?
diff --git a/config/rbac/kustomization.yaml b/config/rbac/kustomization.yaml
index c26ae59..3d0a21b 100644
--- a/config/rbac/kustomization.yaml
+++ b/config/rbac/kustomization.yaml
@@ -28,3 +28,21 @@ resources:
 - operatorconfig_viewer_role.yaml
 - driver_editor_role.yaml
 - driver_viewer_role.yaml
+- csi_cephfs_ctrlplugin_clusterrole.yaml
+- csi_cephfs_ctrlplugin_clusterrole_binding.yaml
+- csi_cephfs_ctrlplugin_role.yaml
+- csi_cephfs_ctrlplugin_role_binding.yaml
+- csi_cephfs_ctrlplugin_service_account.yaml
+- csi_cephfs_nodeplugin_clusterrole.yaml
+- csi_cephfs_nodeplugin_clusterrole_binding.yaml
+- csi_cephfs_nodeplugin_service_account.yaml
+- csi_rbd_ctrlplugin_clusterrole.yaml
+- csi_rbd_ctrlplugin_clusterrole_binding.yaml
+- csi_rbd_ctrlplugin_role.yaml
+- csi_rbd_ctrlplugin_role_binding.yaml
+- csi_rbd_ctrlplugin_service_account.yaml
+- csi_rbd_nodeplugin_clusterrole.yaml
+- csi_rbd_nodeplugin_clusterrole_binding.yaml
+- csi_rbd_nodeplugin_role.yaml
+- csi_rbd_nodeplugin_role_binding.yaml
+- csi_rbd_nodeplugin_service_account.yaml

@leelavg is this request still relevant? Aren't these changes already in main?

is this request still relevant? Aren't these changes already in main?

Yep, should have been part of fixes PR that was merged. In main the manifests are defined but will not be included in the bundle unless referenced in Kustomization.yml

is this request still relevant? Aren't these changes already in main?

Yep, should have been part of fixes PR that was merged. In main the manifests are defined but will not be included in the bundle unless referenced in Kustomization.yml

This request is out of scope of this PR. If you have the solution please provide a PR. If not please open a gitissue to track

@Madhu-1
PR refreshed, hold removed.


Pagination results change when moving through pages

Overview
The results are updated when you move through the pages.
Steps:

Go to transactions
Turn off live transactions
Note the first transaction
Move to the second page by clicking next
Move again to the first page by clicking prev
See the first transaction has changed

Note: see https://hyperion.docs.eosrio.io/api/v2/#v2historyget_actions global_sequence, may need to update param/return types
Acceptance criteria

When live transactions are off, the transactions should not be updated regardless of page navigation
If the user goes to a very old page, the older transactions should be persisted

THe solution should use a range on the global_sequence parameter like this:
https://testnet.telos.net/v2/history/get_actions?sort=desc&skip=0&limit=10&global_sequence=0-284532688
This always returns the same range paginated by skip and limit


Fix doc CI

Circle CI doc build fails.
It would seem that the support for the parameter use_2to3 was dropped in the last version (58.0) of setuptools (as it was deprecated for some time now). But sphinx-bootstrap uses it.
Setuptools developers are working on some fixes since the release, but in the mean time maybe we should pin the version to build the doc.

thx @tanglef


MaskedTextBox InsertKeyMode

My application needed a text box with user entry restricted to OverType mode.  I created a MaskedTextBox with the InsertKeyMode set to Overwrite.
This did not work -- any user entry operated in Insert mode.  The keyboard Insert key also had no effect.  It appears that entry into a MaskedTextBox is always in Insert mode.
The problem can be reproduced by creating a C# forms application with the following code in Form1.cs:
public Form1()
{
InitializeComponent();
MaskedTextBox mask1 = new MaskedTextBox();
mask1.Text = " mask1 ABCDEFGHIJKLMNOP";
mask1.Location = new Point(28, 39);
mask1.Width = 400;
mask1.InsertKeyMode = InsertKeyMode.Overwrite;
mask1.Show();
Controls.Add(mask1);
}
When you type into the box, it will always be in Insert mode, not Overwrite.
I have tried this with WDExpress.exe (6/20/2016) in Visual Studio 14.0, desenv.exe (1/30/2019 in Visual Studio 2017, and devenv.exe (5/27/2019) in Visual Studio 2019.  My operation system is Windows 10, running on a desktop PC.
Ken Van Mechelen
<EMAIL_ADDRESS>

@mairaw Can you please take a look at this issue?

@russkie @merriemcgaw can you please look at this issue? It seems to be for WinForms. Should it be moved somewhere else?


Network serial support & bug fixes

I've added support for the ESP-Link serial port to wifi adapter I've put into my system, and I've fixed a few exceptions that I ran into.
The only change that might be controversial here is replacing the serial port GUI element with an Autocomplete element where the user needs to type in the first 3 letters of the target port before the autocomplete will provide the ability to select it.

Thanks for the pull request. I'm happy with the changes except that I'd prefer that the GUI changes to support connectivity if using a TCP - serial bridge was done slightly differently.
I'm thinking that a pair of radio buttons could be used to select either a local serial port using the current pull down menu of local ports of a pair of fields to enter the device address and TCP port. A TCP-serial radio button could then enable these fields (disabling the local serial port pull down) so that the user can enter the address and port.

The changes from this pull request were largely incorporated into the repo but the GUI changes was changed to present the user with fields to edit the address and port.

Sorry, I haven't gotten a chance to update this MR yet! I agree that that is better UI.
I don't think you've pushed your code up, I don't see it in the repo. I'd like to test it out as well.


Add handling for ManagePackageVersionsCentrally

It would be nice if your scripts are working with this
https://github.com/NuGet/Home/wiki/Centrally-managing-NuGet-package-versions
Maybe a condition on the property group (setting ManagePackageVersionsCentrally) here https://github.com/CZEMacLeod/MSBuild.SDK.SystemWeb/blob/main/src/MSBuild.SDK.SystemWeb/Sdk/MSBuild.SDK.SystemWeb.DefaultPackages.props
Maybe an additional check on line 12 https://github.com/CZEMacLeod/MSBuild.SDK.SystemWeb/blob/main/src/MSBuild.SDK.SystemWeb/Sdk/MSBuild.SDK.SystemWeb.DefaultPackages.targets is also required for setting ManagePackageVersionsCentrally....

I don't need this change, as I can set in addition to ManagePackageVersionsCentrally  the setting UsingMicrosoftCentralPackageVersionsSdk to true


1000s logs/second about network or external storage

Platform:

[x]  Flutter Android or iOS

split-debug-info and obfuscate (Flutter Android or iOS) or CanvasKit (Flutter Web):

[x]  Disabled

Platform installed with:

[x] pub.dev

The version of the SDK (See pubspec.lock):
5.1.0

"Not possible to read external files directory"

This is one device, span of 24h. It's running Android 10, Lenovo TB-X505F.

The histogram legend shows ~3500 messages in the span of one second.

Comes from an Android 9, Lenovo TB-7305F
This one is quite concerning since it seems to be stuck in some loop aggressively checking for connectivity.

Not possible to read external files directory

it's just a debug logging, which means the device didn't have an external sdcard.
if you run a Flutter App/ on debug mode, Sentry debug mode is enabled by default, that's why you see such logs, you shouldn't if running on release mode.

This one is quite concerning since it seems to be stuck in some loop aggressively checking for connectivity.

that's indeed concerning since this check is only called when an event is captured, and sentry itself does not capture events in a tight loop, what else do you see in the logs? can you provide a reproducible example? I don't experience this when running our examples, thanks

@matejkramny any news?

Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated.
Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it.
Cheers!

Happening for me too, getting more than 1000 logs a second in debug builds, this is making it impossible for me to actually filter out useful logs, event tried by setting debug to false while initialising
eHint.waitFlush(DirectoryProcessor.java:105)         at io.sentry.OutboxSender.waitFlush(OutboxSender.java:245)         at io.sentry.OutboxSender.processEnvelope(OutboxSender.java:137)         at io.sentry.OutboxSender.processFile(OutboxSender.java:70)         at io.sentry.DirectoryProcessor.processDirectory(DirectoryProcessor.java:66)         at io.sentry.OutboxSender.processDirectory(OutboxSender.java:29)         at io.sentry.SendCachedEnvelopeFireAndForgetIntegration$SendFireAndForgetFactory$-CC.lambda$processDir$0(SendCachedEnvelopeFireAndForgetIntegration.java:42)         at io.sentry.-$$Lambda$SendCachedEnvelopeFireAndForgetIntegration$SendFireAndForgetFactory$0LBM9z6C34iFlGwSY7l9z84nZSY.send(Unknown Source:8)         at io.sentry.SendCachedEnvelopeFireAndForgetIntegration.lambda$register$0(SendCachedEnvelopeFireAndForgetIntegration.java:79)         at io.sentry.-$$Lambda$SendCachedEnvelopeFireAndForgetIntegration$MeVfZg8XM9fBl32kxrltlaaZLh0.run(Unknown Source:4)         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:458)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)         at java.lang.Thread.run(Thread.java:764) 2021-09-28 18:50:51.000 7549-10890/com.tresscommas.threedots.stage W/Sentry: Timed out waiting for event id submission: 28ac309cf8b94c3383e6a6ac18b7eb2b 2021-09-28 18:50:51.000 7549-10890/com.tresscommas.threedots.stage D/Sentry: File '/data/user/0/com.tresscommas.threedots.stage/cache/sentry/outbox/377ad869-97c2-4297-a782-8d9ec0c9598e' is done. 2021-09-28 18:50:51.002 7549-10890/com.tresscommas.threedots.stage D/Sentry: Failed to delete: /data/user/0/com.tresscommas.threedots.stage/cache/sentry/outbox/377ad869-97c2-4297-a782-8d9ec0c9598e 2021-09-28 18:50:51.002 7549-10890/com.tresscommas.threedots.stage D/Sentry: File /data/user/0/com.tresscommas.threedots.stage/cache/sentry/outbox/546d6b60-22e0-493c-a10d-efa6b11cdf75 is not a File. 2021-09-28 18:50:51.003 7549-11278/com.tresscommas.threedots.stage I/Sentry: Not possible to read external files directory 2021-09-28 18:50:51.003 7549-10890/com.tresscommas.threedots.stage D/Sentry: File /data/user/0/com.tresscommas.threedots.stage/cache/sentry/outbox/814af9ed-ff3a-43c0-91c6-d6897be8409c is not a File. 2021-09-28 18:50:51.003 7549-10890/com.tresscommas.threedots.stage D/Sentry: Processing file: /data/user/0/com.tresscommas.threedots.stage/cache/sentry/outbox/ee86d2ec-599a-473b-9455-3e4bc1dbebd8

@marandaneto please help

even get these error logs
2021-09-28 18:52:37.564 7549-10638/com.tresscommas.threedots.stage E/Sentry: Exception while awaiting on lock.     java.lang.InterruptedException         at java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1350)         at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:278)         at io.sentry.DirectoryProcessor$SendCachedEnvelopeHint.waitFlush(DirectoryProcessor.java:105)         at io.sentry.OutboxSender.waitFlush(OutboxSender.java:245)         at io.sentry.OutboxSender.processEnvelope(OutboxSender.java:137)         at io.sentry.OutboxSender.processFile(OutboxSender.java:70)         at io.sentry.DirectoryProcessor.processDirectory(DirectoryProcessor.java:66)         at io.sentry.OutboxSender.processDirectory(OutboxSender.java:29)         at io.sentry.SendCachedEnvelopeFireAndForgetIntegration$SendFireAndForgetFactory$-CC.lambda$processDir$0(SendCachedEnvelopeFireAndForgetIntegration.java:42)         at io.sentry.-$$Lambda$SendCachedEnvelopeFireAndForgetIntegration$SendFireAndForgetFactory$0LBM9z6C34iFlGwSY7l9z84nZSY.send(Unknown Source:8)         at io.sentry.SendCachedEnvelopeFireAndForgetIntegration.lambda$register$0(SendCachedEnvelopeFireAndForgetIntegration.java:79)         at io.sentry.-$$Lambda$SendCachedEnvelopeFireAndForgetIntegration$MeVfZg8XM9fBl32kxrltlaaZLh0.run(Unknown Source:4)         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:458)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)         at java.lang.Thread.run(Thread.java:764)

@akul1994 can you set up a sample project that reproduces the issue and upload it to github? since I can't reproduce myself.


Pyro5 Upgrade

Recently pyro4 was upgraded to pyro5 (see: https://github.com/irmen/Pyro5) and django is version 3.
Would it be possible if you upgrade this library to support these recent changes? Thank you!

To be perfectly honest, I'm no longer using this project, and haven't touched it in years.
If you're interested in taking over maintenance, I can pass it over to you :)


Consider storing background-process R commands in files

Many of VSCode-R's features use a background R process to perform tasks (e.g., help providers, previewing and knitting documents). We currently define the calls to R in-line, e.g.
      const cmd = (
            `knitr::opts_knit[['set']](root.dir = ${knitWorkingDirText});` +
            `cat('${lim}', rmarkdown::render(` +
            `'${filePath.replace(/\\/g, '/')}',` +
            `output_format = rmarkdown::html_document(),` +
            `output_file = '${outputFile.replace(/\\/g, '/')}',` +
            `intermediates_dir = '${tmpDir().replace(/\\/g, '/')}'), '${lim}',` +
            `sep='')`
        );

I think that long-term this could get hard to maintain. Also, it can be difficult to wrap your head around all the quoting!
Describe the solution you'd like
I think that it might be neater and easier to maintain if we instead stuck these calls in their own R files, and then sourced them. For instance:
cp.spawn(`R -f test.R`)

We can use the commandArgs method to pass values to a given file. E.g.
# test.r
print(commandArgs(trailingOnly = TRUE))

R --silent --slave --no-save -f test.r --args "arg1" "arg2" "arg3"
#> [1] "arg1" "arg2" "arg3"

That's true. If we want more simplicity and don't need to show up the arguments in the command line, we could even use environment variables to pass arguments into the scripts.


add chainer.training.extensions.snapshot_json

Add chainer.training.extensions.snapshot_json and it's test.
There are no way to save dict or list object with trainer carefree, like settings or texts.

I think it is better to provide a function that dumps an object to a json file, and just let user to combine snapshot_object with that function specified at the savefun argument. It is still ok to provide a wrapper of it as a dedicated function (named like snapshot_json), but I think we do not need to introduce a new extension for it, because the functionality is fully covered by snapshot_object.

Thank you. I think so.


Ability for cert to be installed in Machine Store instead

[Please allow cert to be installed and referenced in Local machine store. Installing it on user store ties it to a specific user which is less than ideal. If the user leaves the project  this will cause a problem.]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2cfafdf-cbe9-2ffe-eabe-becc66d51728
Version Independent ID: 4a46c8a8-dc70-d877-271e-6679c465a6d5
Content: App-only authentication
Content Source: exchange/docs-conceptual/exchange-online/exchange-online-powershell-v2/app-only-auth-powershell-v2.md
Service: exchange-online
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

Hi @sukh-ava, thank you for your feedback.
Feedback in docs.microsoft.com is available to help us to improve it. As it seems to be more a feature request I have to suggest you that try with these channels:
https://office365.uservoice.com/
https://docs.microsoft.com/powershell/exchange/exchange-online/exchange-online-powershell-v2/exchange-online-powershell-v2#report-bugs-and-issues

@sukh-ava  Thank you very much for your kind feedback. Considering your valuable feedback, as advised please log this issue as a User Voice. Concerning team will evaluate and take the appropriate action, as per their schedule. We proceed here to close it. Thanks again for taking out some time and sharing your feedback.


Fix arm64 tick timer

Summary
WIP: fixed arm64 tick timer
Not going to merge before upstreaming. The first patch (arch alarm) is just cleanup to make it understandable to myself. The two others actually correct something.
Impact
Testing

Updated to clean cherry-picks from upstream


Filtering on Recommendations table

Context
On our recommendations page we would like to present data in a way that inspires action. One essential part of this is the ability to organize and play with the data and recommendations, and that can be achieved through filtering.
Out of Scope

message to expand filter selection when all data is filtered out

A/C's

[ ] When I view the table on the recommendations page, I see indicators next that I can filter the Cloud Provider, Region, and Recommendation Type next to each corresponding header label
[ ] When I click on the cloud provider filter button, I see a list of all three cloud providers
[ ] When I click on the cloud provider filter button, I can select multiple cloud providers
[ ] When I click on the region filter, I can select multiple regions
[ ] When I click on the recommendation type filter, I can select multiple recommendation types
[ ] When I have data sorted and I apply a filter, the data remains sorted and the filter is applied
[ ] When I have a filter applied, I can apply additional filters and they are applied as well

I did some research on how to implement this and there are different options:
Option 1: Use out of the box DataGrid filtering
Pros: - minimal implementation
- easy and fast to incorporate in our table
- nice CSV export feature
- can be customized to our needs
- offers quick search filtering
Cons: - does not offer multiple filters
Option 2: Use out of the box XGrid filtering
Pros: - minimal implementation
- easy and fast to incorporate in our table
- cool export feature
- can be customized to our needs
- offers multiple filters, you can add as many as you'd like
- offers quick search filtering
Cons: - we would have to install a new dependency but we could remove DataGrid since we would switch to XGrid instead
Option 3: Use the FilterBar of the Home page dashboard
Pros: - fully customizable to our needs
- no need to install new dependencies
Cons: - we would have to do a big and somewhat complex refactor to make the component reusable by a different data type because right now it accepts data of type EstimationResult[], and we would need to pass data of type ReccomendationsResult[]
I also worked on some designs:


Fix activation functions not being broadcasted

Only applies when not merged into flux layer
Fix combining of reshape due to Reshape OP being moved
Workaround for joinpath no longer giving valid webpaths?
Fix #17

Codecov Report

Merging #18 into master will increase coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   89.76%   89.79%   +0.02%
==========================================
  Files          12       12
  Lines         684      686       +2
==========================================
+ Hits          614      616       +2
  Misses         70       70

Impacted Files
Coverage Δ

src/deserialize/combine.jl
87.50% <50.00%> (ø)

src/deserialize/ops.jl
96.80% <100.00%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5670b7...bbf58f4. Read the comment docs.


⚠ Samsung has degraded performance

In 4574219, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3008 ms

Resolved: Samsung performance has improved in f41fa65.


run worker error

root@ubuntu-Z690:/mnt/workspace/.cache/modelscope/BAAI/Bunny-v1___0-3B# python -m bunny.serve.model_worker   --host <IP_ADDRESS>   --controller http://localhost:10000   --port 40000   --worker http://localhost:40000   --model-path /mnt/workspace/.cache/modelscope/BAAI/
2024-04-26 11:49:04.450276: I tensorflow/core/util/port.cc:111] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable TF_ENABLE_ONEDNN_OPTS=0.
2024-04-26 11:49:04.451693: I tensorflow/tsl/cuda/cudart_stub.cc:28] Could not find cuda drivers on your machine, GPU will not be used.
2024-04-26 11:49:04.469047: E tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:9342] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2024-04-26 11:49:04.469064: E tensorflow/compiler/xla/stream_executor/cuda/cuda_fft.cc:609] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2024-04-26 11:49:04.469078: E tensorflow/compiler/xla/stream_executor/cuda/cuda_blas.cc:1518] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-04-26 11:49:04.472914: I tensorflow/tsl/cuda/cudart_stub.cc:28] Could not find cuda drivers on your machine, GPU will not be used.
2024-04-26 11:49:04.473033: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-04-26 11:49:04.905731: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
Traceback (most recent call last):
File "/opt/conda/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/opt/conda/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/Bunny/bunny/serve/model_worker.py", line 20, in
from bunny.model.builder import load_pretrained_model
File "/Bunny/bunny/model/init.py", line 1, in
from .language_model.bunny_phi import BunnyPhiForCausalLM, BunnyPhiConfig
File "/Bunny/bunny/model/language_model/bunny_phi.py", line 11, in
from ..bunny_arch import BunnyMetaModel, BunnyMetaForCausalLM
File "/Bunny/bunny/model/bunny_arch.py", line 6, in
from .multimodal_projector.builder import build_vision_projector
File "/Bunny/bunny/model/multimodal_projector/builder.py", line 5, in
from timm.layers.norm_act import LayerNormAct2d
ModuleNotFoundError: No module named 'timm.layers'

Have you done Installation?

Have you done Installation?

Yes, installation is complete。I started it in the modelscope container, And I start 'python -m bunny.serve.gradio_web_server --controller http://localhost:10000 --model-list-mode reload --share 'and' python -m bunny.serve.controller --host <IP_ADDRESS> --port 10000 'are started normally. My cuda environment is also normal.

Thanks!!

Have you done Installation?

Yes, installation is complete。I started it in the modelscope container, And I start 'python -m bunny.serve.gradio_web_server --controller http://localhost:10000 --model-list-mode reload --share 'and' python -m bunny.serve.controller --host <IP_ADDRESS> --port 10000 'are started normally. My cuda environment is also normal.
 We use 0.9.16.

may be the timm version? We use 0.9.16.

It didn't work, I use the registry.cn-beijing.aliyuncs.com/modelscope-repo/modelscope:ubuntu22.04-cuda12.1.0-py310-torch2.1.2-tf2.14.0-1.12.0 'The mirror image should be fine

may be the timm version? We use 0.9.16.

Or can I ship a docker image of a full environment

Well, I notice that there are some tensorflow errors, which is strange:
2024-04-26 11:49:04.469047: E tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:9342] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2024-04-26 11:49:04.469064: E tensorflow/compiler/xla/stream_executor/cuda/cuda_fft.cc:609] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2024-04-26 11:49:04.469078: E tensorflow/compiler/xla/stream_executor/cuda/cuda_blas.cc:1518] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
BTW, it shoule be python -m bunny.serve.model_worker --host <IP_ADDRESS> --controller http://localhost:10000/ --port 40000 --worker http://localhost:40000/ --model-path /mnt/workspace/.cache/modelscope/BAAI/Bunny-v1___0-3B --model-type phi-2

Well, I notice that there are some tensorflow errors, which is strange:
2024-04-26 11:49:04.469047: E tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:9342] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered 2024-04-26 11:49:04.469064: E tensorflow/compiler/xla/stream_executor/cuda/cuda_fft.cc:609] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered 2024-04-26 11:49:04.469078: E tensorflow/compiler/xla/stream_executor/cuda/cuda_blas.cc:1518] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
BTW, it shoule be python -m bunny.serve.model_worker --host <IP_ADDRESS> --controller http://localhost:10000/ --port 40000 --worker http://localhost:40000/ --model-path /mnt/workspace/.cache/modelscope/BAAI/Bunny-v1___0-3B --model-type phi-2

So can you release a docker image of a complete environment? Thank you

Hi @chenzhu005774 , thank you for your interest in our work.
Please try our docker: docker pull russellrobin/bunny:latest. You may also want to refer to Installation and update local codes in our docker.
Regards
Russell
BAAI

docker pull russellrobin/bunny:latest

Thank you. I'll try.

Hi @chenzhu005774 , thank you for your interest in our work.
Please try our docker: docker pull russellrobin/bunny:latest. You may also want to refer to Installation and update local codes in our docker.
Regards Russell BAAI

Thank you the environment should be usable. But I couldn't download the model online due to network problems. So I put I manually download good model in the ". / root/cache/huggingface/" directory, Then run the python -m bunny.serve.model_worker --host <IP_ADDRESS> --controller http://:10001 --port 40000 --worker http://localhost:40000 --model-path BAAI/Bunny-v1_0-3B --model-type phi-2 "Let me download it. So I would like to ask how to load the locally downloaded model

--model-path points to the absolute path
change mm_vision_tower to the absolute path of siglip in config.json in Bunny-v1.0-3B

2. mm_vision_tower
Yes I am the absolute path，but I still have to download

--model-path points to the absolute path
change mm_vision_tower to the absolute path of siglip in config.json in Bunny-v1.0-3B

So what parameters should the version use here .Thanks

change mm_vision_tower to the absolute path of siglip in config.json in Bunny-v1.0-3B

I'm sorry, but I understand where are mm_vision_tower, config.json and Bunny-v1.0-3B respectively


Considerations for import absolute-first when using ES2020 Dynamic imports?

I would assume the use case for dynamic imports.
IE:
import("foo").then( foo => {} )

Would be more likely used throughout the body of the document as opposed to being constrained to the head of the document considering the nature of code splitting.
Would it be possible to ignore import first in cases where import is followed by then?
Going off of:
https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/first.md

I’m not sure what you mean - only static imports should be reported by this rule, and I’m not sure how code splitting (an invisible implementation detail of bundlers) would be relevant.

This is how this came to my attention.

In this use case I'm given an eslint error of
Parsing error: 'import' and 'export' may only appear at the top level
For the given import in the screen cap.

That’s not an eslint rule error - that just means your config isn’t set up to support parsing dynamic imports.

"config isn’t set up to support parsing dynamic imports."
I assume you mean the eslint config?
Where can I learn to configure that then?

Yes. You’ll need an ecmaVersion of 2020 in parserOptions, or to use babel-eslint as your parser.

Thanks for the help, that looks to have addressed my concerns.


[🐞] yarn create qwik@latest fails

Which component is affected?
Starters / CLI
Describe the bug
Miskos-MacBook-Pro~/work/repros(:|✔) % yarn create qwik@latest
yarn create v1.22.19
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
success Installed<EMAIL_ADDRESS>with binaries:
      - create-qwik
/bin/sh: /opt/homebrew/bin/create-qwik@latest: No such file or directory
error Command failed.
Exit code: 127
Command: /opt/homebrew/bin/create-qwik@latest
Arguments:
Directory: /Users/misko/work/repros
Output:

info Visit https://yarnpkg.com/en/docs/cli/create for documentation about this command.

Reproduction
yarn create qwik@latest
Steps to reproduce
yarn create qwik@latest

System Info
System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1
    Memory: 44.84 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.5.0 - ~/.nvm/versions/node/v18.15.0/bin/npm
    pnpm: 8.7.0 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 116.0.5845.110
    Safari: 16.5.1

Additional Information
No response

Hi @mhevery
I gonna close this one since yarn does not support the latest flag (https://qwik.builder.io/docs/getting-started/#create-an-app-using-the-cli)


Latest Source: Failed loading ModPlug_Tell: [not found]

When using libmodplug-1.dll, I get the above run time error from the latest source build.

It is correct that libmodplug-1.dll files under VisualC/external/lib/x86
and VisualC/external/lib/x64 don't have that symbol, however the source
is supposed to be attempting to load it at runtime and not fail if it is
not found:
https://github.com/libsdl-org/SDL_mixer/blob/main/src/codecs/music_modplug.c#L84
Such an error could have only happened if MODPLUG_DYNAMIC is not defined
and MODPLUG_HAS_TELL is defined during SDL2_mixer build, and we do not
define MODPLUG_HAS_TELL anywhere.
How are you compiling SDL2_mixer?

I am curious though: How do you actually see the error you reported?
Does the library actually work fine, but you just call SDL_GetError and see
the error that way? If it really happens that way, do you actually receive any
failures and is that the reason you are calling SDL_GetError, or do you intend
to check presence of any errors by calling SDL_GetError (which would be a
wrong thing to do)?

Everything still works fine, yes. The error is set by Mix_Init(). I've relied on SDL_GetError() reporting no problem up to now.

Mix_Init should return 0 on failure: If you don't hit that but still call SDL_GetError, you can get error even though it is irrelevant to you. I.e.: Only check Mix_Init return value for error. This is not a bug, closing.

While triaging https://github.com/libsdl-org/SDL_mixer/issues/435#issuecomment-1214063419,
I saw this message when building SDL_mixer using CMake, and setting the log priority to SDL_LOG_PRIORITY_VERBOSE:
cmake_minimum_required(VERSION 3.20)
project(myproject C)

include(FetchContent)

set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}")

FetchContent_Declare(
    SDL2
    GIT_REPOSITORY https://github.com/libsdl-org/SDL.git
    GIT_TAG release-2.0.22
    GIT_PROGRESS TRUE
)
FetchContent_Declare(
        SDL2_mixer
        GIT_REPOSITORY https://github.com/libsdl-org/SDL_mixer.git
        GIT_TAG release-2.6.1
        GIT_PROGRESS TRUE
)
FetchContent_MakeAvailable(SDL2 SDL2_mixer)

file(WRITE main.c [[
#define SDL_MAIN_HANDLED
#include "SDL.h"
#include "SDL_mixer.h"
#include <stdio.h>
#include <stdlib.h>

#define MIX_INIT_FLAGS (MIX_INIT_FLAC | MIX_INIT_MOD | MIX_INIT_MP3| MIX_INIT_OGG | MIX_INIT_MID | MIX_INIT_OPUS)

int main(int argc, char *argv[]) {
    int ret;
    SDL_SetMainReady();
    SDL_Init(SDL_INIT_AUDIO);
    SDL_LogSetAllPriority(SDL_LOG_PRIORITY_VERBOSE);
    ret = Mix_Init(MIX_INIT_FLAGS);
    printf("Expected 0x%x, got 0x%x\n", MIX_INIT_FLAGS, ret);
    if (ret != MIX_INIT_FLAGS) {
        printf("WRONG!\n");
        abort();
    }
    Mix_Quit();
    SDL_Quit();
    return 0;
}
]])
add_executable(main main.c)
target_link_libraries(main PRIVATE SDL2::SDL2 SDL2_mixer::SDL2_mixer)

While triaging #435 (comment),

Can someone change the title of that ticket? I still don't know whact exactly it is about.

I saw this message when building SDL_mixer using CMake, and setting the log priority to SDL_LOG_PRIORITY_VERBOSE:

If you are seeing that Failed loading ModPlug_Tell: [not found] message, it doesn't mean
anything, really. If it's another error message, please post.

I went ahead and pushed https://github.com/libsdl-org/SDL_mixer/commit/de25435d2d8e7c2f3e5db15b161e313a868af149 to avoid confusions like this.


Seq and Buffers: updating a large number of elements can't be done easily

When calling the FStar.buffer or the FStar.Seq update functions a large number of times in a raw, verification explodes, which seems fair. We can do it in several steps but it is annoying, so we should look at it at some point...
In the case of some crypto primitives, this pattern goes to update 64 elements or more forcing us to only lax typecheck those functions.
let set_k state =
  let k = FB.sub state pos_k size_k in
  k.(0ul)  <- 0x428a2f98ul;
  k.(1ul)  <- 0x71374491ul;
  k.(2ul)  <- 0xb5c0fbcful;
  k.(3ul)  <- 0xe9b5dba5ul;
  k.(4ul)  <- 0x3956c25bul;
  k.(5ul)  <- 0x59f111f1ul;
  k.(6ul)  <- 0x923f82a4ul;
  k.(7ul)  <- 0xab1c5ed5ul;
  k.(8ul)  <- 0xd807aa98ul;
  k.(9ul)  <- 0x12835b01ul;
  k.(10ul) <- 0x243185beul;
  k.(11ul) <- 0x550c7dc3ul;
  k.(12ul) <- 0x72be5d74ul;
  k.(13ul) <- 0x80deb1feul;
  k.(14ul) <- 0x9bdc06a7ul;
  k.(15ul) <- 0xc19bf174ul;

One solution could be using functions such as
private inline_for_extraction val upd_5:
  tmp:buffer t -> s0:t -> s1:t -> s2:t -> s3:t -> s4:t ->
  Stack unit
    (requires (fun h -> live h tmp))
    (ensures (fun h0 _ h1 -> live h1 tmp /\ get h tmp 0 == s0 /\ get h tmp 1 == s1 /\ get h tmp 2 == s2 /\ get h tmp 3 == s3 /\ get h tmp 4 == s4 /\ modifies_1 tmp h0 h1))
private inline_for_extraction let upd_5 tmp s0 s1 s2 s3 s4 =
  tmp.(0ul) <- s0;
  tmp.(1ul) <- s1;
  tmp.(2ul) <- s2;
  tmp.(3ul) <- s3;
  tmp.(4ul) <- s4;
  let h1 = ST.get() in
  Seq.lemma_eq_intro (as_seq h1 tmp) (seq_upd_5 s0 s1 s2 s3 s4)

Then you can compose such function to build larger ones etc. No very pretty, but it does work.


Feature request: Autozoom + Crop

Though there is still no autozoom and crop yet, you can crop the size of the webcam window with the mouse at the sides of the window and then afterwards drag the window larger at the corners again.


JSX interface v2

Background
We have a virtual node interface of JSX element, to manipulate nodes easily for ergonomic templating. But it also has caused of always using a complex render function JSXSlack().
I suppose jsx-slack wants to have a simple interface without confusion and hesitation. It's the world JSXSlack() isn't needed.
v1.5.0 had a provisional improvement about usage of JSXSlack(): Some JSX components make serializable implictly due to implementing toJSON() function. However, there is ambiguous in the usability for developer. When developer wanted to manipulate raw JSON, still have to convert JSX into JSON by calling JSXSlack() explicitly.
In the new JSX interface, get rid of ambiguous and make developer use generated JSON simpler.
Proposal
The functional component for jsx-slack will return the actual JSON for output, and store meta data for JSX element in not-enumerable key of the object.
/** NOTE: The following is psuedo-code */

// Component returns JSON object
const Divider = () => ({ type: 'divider' })

// JSXSlack.h defines JSX metadata to the output
JSXSlack.h = (type, props, ...children) =>
  Object.defineProperty(
    type({ ...props, children }),
    '$$jsxslack',
    { value: { type, props, children } },
  )

console.log(JSON.stringify(<Divider />))
// => {"type":"divider"}

console.log((<Divider />).$$jsxslack)
// => { type: Divider, props: {}, children: [] }

JSON.stringify() ignores not-enumerable key so developer can use JSX element as serialized JSON for Slack API without using JSXSlack().
JSX metadata is required by built-in components to manipulate children nodes.

In TypeScript, JSX element must have JSX.Element type but it is incompatible with Slack Node SDK. See also #132.
For compatibility with v1 and as a helper for type casting into any, JSXSlack() would keep providing in v2 (Pass through wrapped JSX with no operations).


[IVANCHUK] Tenant changes changes miq product features on all servers

This is ivanchuk version of https://github.com/ManageIQ/manageiq/pull/20772 It is needed in ivanchuk branch because of https://bugzilla.redhat.com/show_bug.cgi?id=1898730
@miq-bot add_label bug
@miq-bot add_reviewer @kbrock

think the bot glitched and forgot to remove the unmergable tag once this was rebased / pushed

thanks @mzazrivec It looks like a save won't sent a queue message across to reset a name change here in all regions. I wonder if that was an oversight or the desire to avoid continuous sending of update events for the same record.

not sure if I need to cc @simaishi when changes get merged into previous branches - so sorry for the noise if I wasn't supposed to ping you

It looks like a save won't sent a queue message across to reset a name change here in all regions. I wonder if that was an oversight or the desire to avoid continuous sending of update events for the same record.

Not sure if I understand the above correctly -- did I miss some additional changes for the thing to work correctly in ivanchuk?

not sure if I need to cc @simaishi when changes get merged into previous branches - so sorry for the noise if I wasn't supposed to ping you

Thanks @kbrock  We sometimes freeze branches when build is in progress. To avoid getting extra fixes included unexpectedly, please approve PR and assign to me for any branch specific PRs in the future, so I can merge when appropriate.  Thanks!

not sure if I need to cc @simaishi when changes get merged into previous branches - so sorry for the noise if I wasn't supposed to ping you

Thanks @kbrock  We sometimes freeze branches when build is in progress. To avoid getting extra fixes included unexpectedly, please approve PR and assign to me for any branch specific PRs in the future, so I can merge when appropriate.  Thanks!

@mzazrivec can this be hammer/yes?

@simaishi I think yes (as long as it cherry-picks cleanly).

Hammer backport details:
$ git log -1
commit 3704d392ad6279eae417097618081142c44142a6
Author: Keenan Brock<EMAIL_ADDRESS>Date:   Tue Dec 22 12:03:32 2020 -0500

    Merge pull request #20886 from mzazrivec/invalidate_all_caches_for_ivanchuk

    [IVANCHUK] Tenant changes changes miq product features on all servers

    (cherry picked from commit f2010188db9b63e4f7f0afcad3b24565d5657d91)

Travis is now failing in hammer branch...  @mzazrivec please take a look.
  1) ContainerImage::Purging .purge_queue submits to the queue
     Failure/Error:
       MiqQueue.broadcast(
         :class_name  => name,
         :method_name => "invalidate_caches"
       )
     NoMethodError:
       undefined method `broadcast' for #<Class:0x000000000152fb60>
     # ./app/models/miq_product_feature.rb:119:in `invalidate_caches_queue'
     # ./app/models/tenant.rb:328:in `update_miq_product_features_for_tenant_nodes'
     # ./spec/models/container_image/purging_spec.rb:5:in `block (4 levels) in <top (required)>'

@simaishi We also need the following PR cherry-picked into hammer: https://github.com/ManageIQ/manageiq/pull/19122
It's already in ivanchuk, but I forgot to mention that PR for hammer.

Thanks @mzazrivec, backported #19122 to hammer branch.