Add pagination to recent order view

I want to merge this change because...
Fixes #1432

Pull Request Checklist
(Please keep this section. It will make maintainer's life easier.)

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[ ] JavaScript code quality checks pass: eslint.

Codecov Report

Merging #1477 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
- Coverage   82.44%   82.41%   -0.03%
==========================================
  Files         131      131
  Lines        5668     5671       +3
  Branches      647      647
==========================================
+ Hits         4673     4674       +1
- Misses        831      833       +2
  Partials      164      164

Impacted Files
Coverage Δ

saleor/userprofile/views.py
34.21% <0%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc99c2e...21cbb69. Read the comment docs.

Pagination links are too close to the orders table, there should be more spacing between them. Also,  changing tab to "Change password" and then back to "Recent orders" results with this bug:

@dominik-zeglen Take a look when you have time.

According to @dominik-zeglen, the issue with switching tabs should we resolved after upgrading Bootstrap to the latest version: #1498.


Java - simultaneous Client

Hello,
I use TDLib in a Spring Boot api.
Sometimes, the app manage requests from different Telegram account so I create one Client for each account (with separated databaseDirectory).
Each request is runned in separete thread.
All works fine except when one of these Client (that I will call client1 bellow) is in AuthorizationStateWaitCode or AuthorizationStateWaitPassword.
In that case, for all other Client, I don't receive any answer when a I send a command (client.send) as long as I don't send a code or password for client1. It looks like these Client are waiting that client1 pass in client1
send(new TdApi.CheckAuthenticationCode(authCode), new AuthorizationRequestHandler()); or client1
.send(new TdApi.CheckAuthenticationPassword(authPasswd), new AuthorizationRequestHandler());
After sending code or password, all other Client receive answer to her send command.
This "problem" is after reapeating as long as client1 is not in state differend as AuthorizationStateWaitCode or AuthorizationStateWaitPassword.
Is it normal or did I something wrong ?
I see some similar issues that speak about ClientManager but this classe is not implemented in Java example. I have to implement them by myself ?
Best Regards

Updates and responses for all clients are processed in the same thread. The code for authorization update handling blocks the thread and makes impossible to process other responses. You need to make processing of the authorization states asynchronous or to move it to another thread.

@levlam Ok, thanks for your quick answer :-)


Creative Development

Quiz using app lab in code.org: https://studio.code.org/projects/applab/jau_YPo5u3K2kjagwJ9Ow50YORprzrWIiwIWRQOfrSw
Quiz plan post on my fast page: https://antonyrc6.github.io/Antony-s-fast-page/markdown/2022/09/11/quiz-plan.html

I bet Anthony deserves a 2.8. His quiz is completely organized. He even put up notifications to figure out if an answer is right or wrong. When the quiz was finished, the message said that all answers were correct. He did really well on the College Board Task as well.


Add YOOX NET-A-PORTER GROUP

This PR adds the YOOX NET-A-PORTER GROUP company

Hey, @alfogrillo I see from the job posts that the employees are working remotely only during the emergency:
 Remote until it’s safe to return to the office

I agree. full remote is not "remote until..."

Hey @alessandromr,
the company has been providing an hybrid remote work policy even before the pandemic (up to 2 days remotely per week).
Now we can stay 60% of our time remotely, on a monthly or weekly basis.
In the long run probably we'll get back to the previous model.


added extra keypress event for keyCode 13 ( enter key ) it never gets fired otherwise.

Essentially I forgot to test the enter key yesterday, I realized it didn't get fired because there was no keypress event for keyCode 13. This just sends the extra keypress event in that case and solves the issue.

I had considered adding this in the JS side with something like
sendKeyDown(key, modifiers) {
    this.browser && this.browser.sendKeyDown(key, modifiers);
	if(key === 13){
		this.browser.sendKeyPress(key, modifiers);
	}
  }

But i guess after our discussion on the previous PR its better to add this to the GLFW code instead.
I haven't tested this on linux / mac either.

cool beans will revert to the js solution!


Ability to set new instance default value to nothing for random Minecraft seed.

This is not for requesting support for new games/applications
To do this you should go to https://github.com/CubeCoders/AMPTemplates and first attempt to build a configuration yourself - otherwise you can request a template from this repo.
Feature Request
I am trying to make my new instance default have a random world seed for minecraft. How you would do it in the normal settings is by putting nothing in the "World Seed" box. I tried putting nothing into the value box of the new instance defaults but it wont let me because you must specify both a key and a value. Because of that I cant put nothing as the world seed.
Feature Information:
Ability to put nothing or something of the same value in the value box of the new instance default settings

I confirm:

[x] that I have searched for an existing feature request matching the description.

Updated to allow keys with empty values in next update.


Documentation for order

On the page for order option it is said that:

The order must be an array of arrays

However for single column sorting array also works, see below:
var table = $('#example').DataTable({
   order: [2, 'desc']
});

See this jsFiddle for code and demonstration.

It actually only partly works. It was something I wanted to have that, but it causes issues for some plug-ins so I removed it from the documentation. It is something I would like to make more robust in future, but at the moment I'd rather not have it documented.

Do you discourage such use?

Yes :-). It works for basic use, but it can cause issues with more complex tables.


[sfdebris] Added new extractor

This fixes #7039.
The extractor is based on TeamFourIE in youtube_dl/extractor/screenwavemedia.py.

Screenwave is already supported by youtube-dl and http://sfdebris.com/videos/animation/transformerss1e01.php is processed by generic extractor just fine.


Hackathon project: datalad-catalog cleanup, upgrade, and release 0.1.0

Overview
This process has been dragging for a while now because of continuously changing priorities, but it would be great to get the datalad-catalog extension into somewhat stable state that it can be released on PyPI. The definition of such a "somewhat stable state" is not concrete, and can be decided by those involved in the process. But there are definitely a few minimum requirements that need to be fulfilled, such as formatting to adhere to PEP8, adding/updating docstrings to functions, and ensuring that automated tests run on Appveyor. The main developer of the tool up to this point (me) was learning Python and programming/packaging best practices on the job, so be prepared for inefficiencies, missing components, and probably ugly code.
Familiarize yourself with datalad-catalog
If you haven't used this tool at all, the best way to do this is to:

Read the DataLad Catalog Primer
Run through the DataLad Catalog tutorial. Click the "launch binder" button below and, once the environment is loaded, navigate to tutorials/notebooks/catalog_tutorials, and open datalad_catalog_getting_started.ipynb

Project goals
Concretely, all but a few existing issues need to be addressed in order to achieve the main outcome of the project.
On a more general level, there are a number of topics that require attention (not all are necessarily required in order to release v0.1.0):

PEP-8 compliance: mostly line length is non-conforming, but there could be other aspects that require attention. Side note: perhaps it's useful to include suggestions in the README (under contributing) for code formatters / style checkers?

https://github.com/datalad/datalad-catalog/issues/98

Docstrings: these are currently not added for all functions, and their styling is not consistent. These need to be added/updated. This will also be useful for including the API in the Sphinx documentation (which is currently omitted).

https://github.com/datalad/datalad-catalog/issues/71

Testing: there are existing unit tests, although these are probably not sufficient as a full test suite. A few integration tests are needed, especially to test complicated and/or recently developed cases e.g. the addition of top_display and additional_display metadata to a catalog. This extension uses pytest but tests were developed without considering the migration of datalad's tests from nose to pytest. Perhaps there are now reusable snippets of code from datalad.

issue to be added

User messaging and error handling: the implementation of logging, exceptions, and datalad results rendering in this extension is inconsistent. This stems from my unfamiliarity with these concepts as I started developing. The code base could benefit a lot from an experienced datalad developer going through the code to identify places where the current implementation needs changes.

https://github.com/datalad/datalad-catalog/issues/99

Web assets: a generated catalog consists of an HTML file and local assets and metadata, all of which can be served via http to render the browser-based catalog. The HTML and Javascript (VueJS-based) code is not tested in any way, and will benefit from attention in this regard. The Javascript code is also not necessarily structured according to best practices for styling (a la PEP8) or object/class oriented programming, and could use an expert eye to make changes/suggestions.

issue to be added

Issues related to core functionality: some existing issues are core to the eventual stable functioning of datalad-catalog (at least based on what we currently know and think), and these need to be addressed before the release.

Issues with the core-functionality tag

Documentation: the current documentation is out of sync with the code base, since it was not updated simultaneously. But with a release, the docs should ideally be correct and up-to-date. Many new illustrations relevant for the docs are available here: https://github.com/jsheunis/ohbm-2022. The full API should be added to the docs, and a few new items should be included/expanded (Examples, Design, Contributing).

issue to be added

General cleanup: creating a more sustainable package structure, especially related to data, and cleaning up code.

https://github.com/datalad/datalad-catalog/issues/100
Issues with the cleanup tag

Project tracking
This kanban board has been used before in an ongoing project to release datalad-catalog. It could be revived for the purposes of this project.
Time estimation
This is difficult. If I were to work solely on this, alone, with zero other distractions (i.e. no meetings, no other work, no kids, no life duties), I would probably be able to do this in a week (i.e. 5 working days). So if we have a team of competent people working on it together, especially in parallel on unrelated topics, I think a 2 day hackathon would be suitable. It's difficult to estimate time on a more granular level.
Next steps

@jsheunis to create main top-level issues related to the topics listed above
If you are interested in joining this effort, please comment below. If anything is unclear, let me know.
Decide together on a date(s) and time(s) for the hackathon

I would like to join

Tagging interested people @christian-monch @loj

Summary of goals and achievements
Goal
Initial goal
Get datalad-catalog ready for release on PyPI. The high-level goals were summarised upfront in: #97 . Repeated here:

PEP-8 compliance
Add docstrings
Improve testing (more tests and improved integration)
User messaging and error handling
Fix/enhance issues related to core functionality
Update documentation
General cleanup

Updated goal
After the first hour of Day 1, we discussed and agreed that we won't be ready for release in 2 days. But we can aim to achieve some of the core high-level goals, and we are fine with any outcome.
Format

2 days, more or less 09h00-17h00 with people going to some meetings in between, taking lunch, and taking care of kids.
Started Day 1 with a 1h overview talk with questions, to give everyone enough context for the tool and what we want to achieve

What we achieved
💫 Enhancements and new features

Styling improvements to all existing python code to make it PEP-8 compliant (using black). #104 (by @adswa)
Restructuring of package data for a more logical delineation of catalog development content, demo catalog content, schema files. #122 (by @jsheunis)
Refactoring of the main catalog.py module, particularly w.r.t. internal function argument handling. #127 (by @christian-monch)
Updating of exception handling, user messages, and results rendering. #120 and #139 (by @adswa)
Orderly create, update, and take down validation progress bars. #145 (by @adswa)
Refactoring of datacite_gin extractor. #146 (by @christian-monch)

🐛 Bug Fixes

Fix failing doc test workflow. #118 (by @loj)
Fix off-by-one error in month (JavaScript). #144 (by @mslw)
Fix syntax error in action workflow. #154

📝 Documentation

Added docstrings to catalog.py, the module containing the main Interface class. #117 (by @mslw)
Adds examples to catalog.py to improve user onboarding. #117 (by @mslw) and #113 (by @adswa)
Updates user docs with recent installation, usage and pipeline information. #126, #133, and #143 (by @loj)
Adds general readme to be added to any newly created catalog. #130 (by @jsheunis)

🏠 Internal

Updating requirements-devel.txt with more recent package versions. #109 (by @christian-monch)
Make import statements comply with datalad design docs. #112 and #142 (by @adswa)
Unify command line and Python API command name. #116 (by @adswa)
Add subcommand validation for Python API. #132 (by @adswa)

🛡 Tests

Updates crippled filesystem tests to run using pytest #114 (by @christian-monch)
Addition of a complete set of tests for Catalog call argument handling #127 (by @christian-monch)
New test module for datacite_gin extractor. #146 (by @christian-monch)

🚧 Infra

Added workflow to run PEP8 compliance check on all new PRs (using black) #104 (by @adswa)
Added coverage upload to codecov for crippled filesystem test #114 (by @christian-monch)
New workflow to push demo catalog changes to gh-pages on merge to main. #147 (by @jsheunis)

Authors:

Adina Wagner (@adswa)
Christian Mönch (@christian-monch)
Laura Waite (@loj)
Leonardo Muller-Rodriguez (@Manukapp)
Michał Szczepanik (@mslw)
Stephan Heunis (@jsheunis)

Procedural question: Given that this has been scheduled and done, shall this project be closed and moved to "done"?

Fine by me. Will do.

Closing issue, since hackathon is completed and summarised, even though originally stated goal of releasing on PyPI was not achieved.


Allow to specify the pattern for unused bits

The purpose of this is to avoid undefined behavior when encoding frames that contain bits which are not used by any signal. Currently, this pattern implicitly is 0xff if encoding with the padding argument set to True, and 0x00 otherwise. ARXML allows to specify something arbitrary, so let's also support this in cantools. IMO, this is quite a fringe feature and I'm not even completely sure if it is implemented fully correctly here: I assumed that a single byte gets specified as an integer (thus, endianness does not matter) and that the bit pattern is not aligned with the beginning of unspecified sections, i.e., the encoded message starts out as a sequence of the unspecified bit pattern bytes and then the parts which define signals get overwritten by actual data.
Andreas Lauser<EMAIL_ADDRESS>on behalf of MBition GmbH.
Provider Information

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 18 (83.33%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.03%) to 95.9%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cantools/database/can/message.py
13
16
81.25%

Totals

Change from base Build<PHONE_NUMBER>:
2.03%

Covered Lines:
5964

Relevant Lines:
6219

💛  - Coveralls

Do you need to rebase to get the linter satisfied?

Are you sure that Vector uses 0xff as a default? Will the behavior change when you do not enable padding?

if you set the padding argument of encode() to true, cantools will currently set all unused bits  to 1 if it is false, they are set to 0 (i.e. not touched by the codecs). If nothing else gets specified, this should hopefully stay the identical after the patch. I have no idea if the current behavior is what Vector does, though...

Do you need to rebase to get the linter satisfied?

probably. I'll have a look...

yay! the linter is happy now :)


the Administrative category not contain things about authorization -> evidence at all

the Administrative category not contain things about authorization -> evidence at all

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f918b451-a085-0e6c-07a5-60e9f68ce33b
Version Independent ID: c0379388-f860-d770-d6a9-cca59064ec85
Content: Azure Activity Log event schema - Azure Monitor
Content Source: articles/azure-monitor/essentials/activity-log-schema.md
Service: azure-monitor
Sub-service: essentials
GitHub Login: @bwren
Microsoft Alias: bwren

@hod-harush
Thanks for your feedback! We will investigate and update as appropriate.

@hod-harush Thanks for your feedback.
Assigning to content author @bwren  for review.

@hod-harush Thanks for your feedback,
Can you please add a bit more detail to your comment. Are we missing information or is there something that is incorrect?

you are missing this pattern which shown in activity logs when they exported to a storage account

Thanks @hod-harush. I have updated the docs.

Thanks


when i open the game i only see pink and white rectangles is that a graphics related issue?

Hello there! Apologies for the late reply, life been busy and I haven't checked on any of my repos in a while.
That is a rather strange glitch. What version of the engine have you got?


Improve mincer performance for "cached" restarts

Need contributors!
Due lack of time, i don't know when this topic will be covered. If you wish to participate - start creating test with big number of files, that can be profiled.

Mincer 0.5.7 finally resolved all significant restart slowdowns, when no assets changed and file cache used. However, some timings look suspisious.
For nodeca start it takes ~600-900 ms, on SSD drive. That's not much in general, but too strange for modern hardware. At first glance, that should be < 100 ms.
If someone has time for mincer profiling - you are welcome :)

Closing. We dropped mincer from nodeca. No need to keep endless tivkets.


chore: derive enum-iter for builtin enum

This change is

Used here: https://reviewable.io/reviews/starkware-libs/mempool/319#-O0dQfSM82y-CzMbpSck

src/transaction.rs line 934 at r3 (raw file):
Previously, yair-starkware (Yair) wrote…
Changing the order requires  a storage migration in Papyrus
@dan-starkware

Another option is to add a function that will return the order of the builtin

We are during a major storage version change as it is. So if this can be merged into papyrus before the 13.2 corresponding version we should be fine


LOG: print Info when a strategy step starts

In the log, I can only see DebugProofState when a strategy step finishes. However, there is no log entry gets printed when a strategy step starts.

@andreiburdusa For every case of transitionRuleWorker that has a Profile.timeStrategy step, there should also be a log entry. We will have a single sum type with a constructor for each strategy operation:
data InfoReachability goal
    = Simplify !goal
    | RemoveDestination !goal
    | DeriveSeq ![Rule goal] !goal
    | DerivePar ![Rule goal] !goal

When you have to define some instances like Entry, it's fine to use a concrete type for goal, for example, instance Entry (InfoReachability (ReachabilityRule Variable)).


Fixed an erroneous comment on texture usage

Very minor change. I assume we can get it the "internal" label? (I cannot set labels myself)


Add Parser for Generic Renewable Models

To do:

[ ] Add Test. Requires adding a new .dyr file to the PowerSystemsTestData repo, and maybe modifying the CaseBuilder repo.
[x] Not sure if we need a keyword constructor for the new constructor of the DynamicInverter that splits the OuterControl into the Active and Reactive part.

@rodrigomha you can use this branch https://github.com/NREL-SIIP/PowerSystemCaseBuilder.jl/pull/24 to add the tests locally. The system is built with the function sys = build_system(PSYTestSystems, "psse_renewable_parsing_1")

Tests are expected to fail until a new version of PSB with the test systems is released


Reduce dependencies

This trino library has far more dependencies than the old presto one, like github.com/Microsoft/go-winio, and specifically github.com/docker/docker, which isn't clearly related to trino, but conflicts with my application's dependencies. Is it possible to reduce these?

I am not a go person but this sounds reasonable. Any insights here @nineinchnick ?
Also @sjones94549 .. if you have any specific improvements please send PRs..

We only use docker for tests. I can try to separate tests into another package, if that's not tej case already.

I cannot reproduce the issue.
I tested this by creating a new project:
mkdir trino-go-example
cd trino-go-example
go mod init github.com/nineinchnick/trino-go-example
cat <EOF >main.go
package main

import (
	"database/sql"
	"fmt"
	"log"

	_ "github.com/trinodb/trino-go-client/trino"
)

func main() {
	db, err := sql.Open("trino", "http://example@localhost:8080")
	if err != nil {
		log.Fatal(err)
	}
	defer db.Close()

	var name string
	err = db.QueryRow("select node_id from system.runtime.nodes limit 1").Scan(&name)
	if err != nil {
		log.Fatal(err)
	}
	fmt.Println(name)
}
EOF
go mod tidy
# just to make sure this compiles and runs
go run ./...

This produces the following go.mod:
module github.com/nineinchnick/trino-go-example

go 1.20

require github.com/trinodb/trino-go-client v0.311.0

require (
	github.com/hashicorp/go-uuid v1.0.3 // indirect
	github.com/jcmturner/gofork v1.7.6 // indirect
	golang.org/x/crypto v0.9.0 // indirect
	gopkg.in/jcmturner/aescts.v1 v1.0.1 // indirect
	gopkg.in/jcmturner/dnsutils.v1 v1.0.1 // indirect
	gopkg.in/jcmturner/gokrb5.v6 v6.1.1 // indirect
	gopkg.in/jcmturner/rpc.v1 v1.1.0 // indirect
)

Can you give a bit more details about the conflict you're seeing?

But you're using the docker client explicitly in main.go. You're not creating a Trino client there, but a Docker client. That's why it shows up in dependencies.

that's my scenario -- I have code that uses a docker client at version 1.13, but if I go get the trino client, it upgrades to an incompatible docker client 20.10. I'd like to use the trino client, but can't with the incompatible docker upgrade, unless I exclude it in go.mod

Two thoughts:

I wish go had test scope dependencies like Maven
From what I can tell the recommendation for Go is to have a separate module for the tests

And I might be wrong ..

I've prepared #80 earlier, but now we have a better reproduction scenario. I'll try it out tomorrow and will update the description of that PR.

Extracting tests into a separate package doesn't help, dependencies are processed at the module level.
The only workaround for this is to exclude the particular dependency version, like you mentioned before:
go mod edit -exclude<EMAIL_ADDRESS>
which adds this to go.mod:
exclude github.com/docker/docker v20.10.17+incompatible

Thanks for trying, @nineinchnick and @mosabua -- it's odd that one has to know these details of external libraries to know what to exclude. Maybe one day this will be improved.

Dependency management is a big issue in every language ecosystem. Some do it better .. others are worse. Sorry there is nothing better at the moment for Go.


Support for multiple tables

we have scenarios where a notebook cell returns multiple tables which I would like to be visualized.
as of now I think thats not possible - are there any plans to support this in the future?
either using multiple custom MIME types or some specific JSON to hand over the data from the notebook to the renderer?
just an idea though

no immediate plans to support this extra/edge case. see our comments in your original repo issue request: https://github.com/paiqo/Databricks-VSCode/issues/158#issuecomment-1560141839


Allow for .cpd.yml in addition to .cpd.yaml

We are using .yml suffixed-files in our repo, so we thought it would be great if you could support both extensions.  I tested it by moving test/.cpd.yaml to test/.cpd.yml and running npm test.

Thanks!


Fixes outdated link to Zalando's tech blog on Patroni

Correct link is https://engineering.zalando.com/posts/2016/02/zalandos-patroni-a-template-for-high-availability-postgresql.html

can you please also change it here?
https://github.com/patroni/patroni/blob/7dcb9b9840dd86f93aa5cb90d1b28fdf20522089/docs/README.rst?plain=1#L12

@hughcapet yes, done.


make compile should remove deployment files that are out of sync

Currently, make compile_contracts update data/contracts.json but it does not update or remove data/deployment*.json.  So make compile_contracts leaves the data directory out of sync.  This issue keeps track of making sure that make compile_contracts remove stale deployment files.
Shall we try to remove only the broken deployment files?   Or can we simply remove all deployment files?

This depends on #1309


Menu not showing, error when opening menu

detailed error: error during NUI callback appearance_get_locales: @illenium-appearance/game/nui.lua:4: attempt to index a nil value (field '?')

No I have not done anything in files nor in config.

Read the docs again. You have not set the right locales


Suricata agent invalid repos

The url that is used to build the Suricata agent, http://downloads.suricata-ids.org/, is no longer valid. See error below:
curl http://downloads.suricata-ids.org/
curl: (6) Could not resolve host: downloads.suricata-ids.org

I suggest the following install for suricata agent:
RUN mkdir suricata
WORKDIR /src/suricata
RUN wget http://www.openinfosecfoundation.org/download/suricata-${SURI_VERSION}.tar.gz
RUN tar -xvzf suricata-${SURI_VERSION}.tar.gz
WORKDIR /src/suricata/suricata-${SURI_VERSION}
# configure, make, and install
RUN ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var && make && make install && ldconfig

Happy to work on this issue if it gets approved. Thanks!

I just saw this PR, great timing: https://github.com/secureworks/dalton/pull/153. That should address the issue, thanks.


Starting multiple servers

What happens when you try to run multiple different servers? how to kill just one of them then?
Thanks.

We don't support multiple servers yet, but this would be pretty trivial to add.

Are you considering adding this feature any time soon?

The changes were contributed by @gurrie but unfortunately we still have some failing tests. I'll see if I get some time to fix it and publish a new version over the weekend.

I have created a pull request fixing that test. Good be nice to have new release :)

I saw the pull request was merged. Do you have plans for creating a new release?

Okay, I've released version 0.7.0 of the plugin, but want to ask that the README is also updated to reflect the new changes. Maybe @chiquitinxx can make some updates according to what he has implemented.


api: check for an output to be unspent.

Fixes a bug where we would assume outputs are unspent although they were not.
Example:
while sweeping the remote close of this channel:
https://mempool.space/address/bc1q96vq7jhl552ucgy79q7zqny27jmlgq6nmspmcvuw97dgsdedlpusnxamhj
the to_remote addr has unfortunately two outputs of two different channel closures (prob. some kind of LND bug), so when querying for the unspent addr utxos, we need to make sure before including the utxo we query the mempool for the spendness of this UTXO.
to_remote addr has two channel closures associated with it:
https://mempool.space/address/bc1qkvtux0hk28qtn7njdjlym2pmhtq799r36yt8a4cuqs0ejm6z520sz4xkqe

PR was tested by the person who run into this problem, and it worked for him.

Hey Ziggie. Thanks for the fix. But is it possible you're using an old base? I fixed this in 83aa752d, which just hasn't been in a release yet. Can create a release if that helps.

True, always a step ahead :).
I think it makes sense to release a new version with this bugfix.

https://github.com/lightninglabs/chantools/releases/tag/v0.13.2


push: add pushing to a desired depth

As explained by issue #409, I should be able to push items present locally to a desired depth.

Addressed by PR https://github.com/odeke-em/drive/pull/411


Create function for post-blossom height adjustments

Is your feature request related to a problem? Please describe.

It feels like we do post-blossom height adjustments in a few different parts of the code.
Is there a way to abstract them into a new function?

https://github.com/ZcashFoundation/zebra/pull/1170#discussion_r508879222
Describe the solution you'd like
Create a function that can be used from at least 2 places.
Describe alternatives you've considered
Leave it as it is.
Additional context
https://github.com/ZcashFoundation/zebra/pull/1170
This is not an urgent task.

The problem i see with this is that the adjustments made post post blossom are not the same in the 2 places we need to do them.
There is one adjustment we do in halving_divisor():

And the other one in founders_reward_address():

The are some differences that i cant see how to abstract:
1- The height for pre blossom is scaled in the halving calculation while the height pre blossom for the founders reward is not modified.
2- I cant find any point of coincidence in the post blossom calculations of the 2 spec points, they even use different constants. Maybe my algebra is not good enough or there is something i am not seeing.

I would strongly suggest to follow the spec as literally as possible here. It took quite some thinking to get it right.

If the calculations are different, they should use different functions, which should have function docs describing the differences and pointing to the relevant sections of the spec. Since the existing functions are fairly simple, you could add explanations to them.
Here are the different places that a blossom adjustment happens:
https://github.com/ZcashFoundation/zebra/pull/1170/files#diff-1e411c4dd6dc3ad59094c14b82cba0fdd4fee34f841ede1ab092d87a65ff77f9R51-R54
https://github.com/ZcashFoundation/zebra/pull/1170/files#diff-1e411c4dd6dc3ad59094c14b82cba0fdd4fee34f841ede1ab092d87a65ff77f9R71-R75
https://github.com/ZcashFoundation/zebra/blob/128643d81e357157bfb3af3725bac653abfb402e/zebra-consensus/src/block/subsidy/general.rs#L64-L68
Can you match each one with the relevant part of the spec?
(You only quoted two spec sections above, but there are 3 adjustments.)
Are there any other adjustments?

In my view we should not do the changes proposed here not because we are checkpointing on canopy but iirc just because is clearer to leave it as it is now as it follows the spec more closely. We can always do this if we need/want but i don't think we need an open ticket. Closing.


Add a comment telling folks not to fix the typo due to Back Compat

We have a typo in the DocumentStoreItem Class. The serialized property is correct, so things work.
This is a private classe used (only) by the CosmosDB class. It could probably be changed, but I'm super-paranoid about this as breaking it invalidates stored state for everyone using this provider. We should just continue to live with the typo.

Pull Request Test Coverage Report for Build 63122

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 71.155%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorage.cs
3
49.74%

Totals

Change from base Build 63104:
0.0%

Covered Lines:
4349

Relevant Lines:
6112

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll


Display the Bokeh HTML file in the notebook

Expands on PR ( https://github.com/nanshe-org/nanshe_workflow/pull/27 ).
Instead of displaying Bokeh's Notebook output, display the HTML file that we wrote out to disk in the Jupyter Notebook. This allows us to view the file as it was written and with any modifications that are relevant. This way things like other formatting changes that are out of the scope of Bokeh still show up. Also any dependencies that we add will also be available within the page. Overall this should also reduce the differences between what is displayed in the Jupyter Notebook and the HTML file that one views later.
We need to use an iframe when displaying the HTML instead of including the full HTML as Jupyter Notebooks do not handle the latter. This likely has to do with some formatting they do in the background to make sure it fits within the cell and the page overall. We have also found this is necessary to make sure external JavaScript dependencies work correctly (e.g. BokehJS and others). More details can be found in issue ( https://github.com/jupyter/notebook/issues/749 ).
The iframe is formatted to allow the width to expand to the full width of the cell (whatever that might be). The height is determined based on the plot size with an approximate formulation that should be sufficient for fitting both plots. In general, these settings should minimize the need for scrolling in the iframe. Particularly it should avoid scrolling in the vertical direction. Also it should make it easy to view the traces and ROIs in the same field of view given the default settings. However, scrolling within the iframe may still be necessary if the plots are resized.

Tried out with some real data to make sure the iframe has the right dimensions to fit it properly and it does.


className attribute is always overwritten regardless of what lineProps returns

Describe the bug
lineProps is currently unable to set the className because its always overwritten, regardless of what lineProps does.
 var properties = typeof lineProps === 'function' ? lineProps(lineNumber) : lineProps;
properties['className'] = className;
https://github.com/react-syntax-highlighter/react-syntax-highlighter/blob/master/src/highlight.js#L108
A super-simple fix would be to simply change those two lines to this:
var properties = {className: className, ...typeof lineProps === 'function' ? lineProps(lineNumber) : lineProps};
This affects both Prism and Highlight.js, as well as countless third-party dependencies that use this behaviour to change props on a per-line basis.
This is currently making this package, as well as those that rely on it, completely unusable for me, is there any sort of roadmap as to when this issue is going to be resolved?
To Reproduce
Steps to reproduce the behavior:

set className using lineProps
value is always overwritten

Expected behavior
Class names set in lineProps shouldn't be blindly overwritten.

React will complain at you but a workaround is possible by passing

lineProps={{class:"class-name"}


Not more available?

Microsoft Pay is not more available since Feb. 8th, 2020. Customers should change to Paypal Extension instead.
What about Stripe? Is there an Extension available?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b764f2b-a5ce-1fb1-e1bc-6d7d55887717
Version Independent ID: 7705cfbe-0625-1103-9c12-98f757ca2bc0
Content: Microsoft Pay Standard - Business Central
Content Source: business-central/ui-extensions-microsoft-pay-payments.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Hello,
Thank you for your feedback. Since your question is not about the Help, we suggest that you submit a feature request here: https://aka.ms/businesscentralfeedback


Remove some duplicate code

This line of code was here twice, along with its comment; likely a copy and paste error at some point.

Ah, thanks. :cake: :icecream:

Whoa whoa whoa @mattrobenolt! Talk about haste! There are plenty of good reasons why this code is duplicated!!!!

jk :+1:

While you guys are here, what I was trying to investigate when I noticed this duplicate code is how exactly "release" is handled. Some Sentry docs suggest using a tag "version", but then Raven JS has this config option to pass "release", separate from tags, and it's rendered as if it were a tag in Sentry as far as I can tell. Is "release" special in some way? Can you point me at code or docs?

Yeah, we handle release as a first class citizen in the API, but internally it gets transformed into a tag. It's more like a "special" tag, since we use it for internal purposes to manage releases and whatnot.

Also, those docs are misleading. We should update that. A tag "version" is not the same thing as a release. It's likely these docs were written before releases were a native thing.

Okay, all understood. I'll switch my code to send "release" as well. Found how to send it properly in PHP Raven, too. Thanks!


5.1

Does this work with 5.1 ?

Homestead has nothing to do with Laravel, except that it shares the brand
name. So it works with any framework, or without a framework. It's just a
virtual machine setup.
--
Bruno Skvorc
PHP editor, SitePoint.com
Devangelist, Diffbot.com
Twitter: @bitfalls http://www.twitter.com/bitfalls
G+: google.com/+BrunoSkvorc
Skype: bruno.skvorc
On Wed, Jul 1, 2015 at 2:09 PM, keithwhyman<EMAIL_ADDRESS>wrote:

Does this work with 5.1 ?
—
Reply to this email directly or view it on GitHub
https://github.com/Swader/homestead_improved/issues/5.

oh sorry, misunderstanding my side


docker group attribute/method

Hi,
is there a way to get the current group used for docker?
group 'docker' do
  members [node['jenkins']['master']['user']]
  append true
  action :modify
end

feels so wrong

you can get the gid from node['etc']['group']['docker']['gid']

well. this does not solve my problem. I would like to find out the name of the group for the docker installation. not the gid of a known name.

The group name is always docker

it is? this line got me thinking: https://github.com/chef-cookbooks/docker/blob/master/libraries/helpers_service.rb#L144 which indicates a customization option.
but yes. I'll default to the hardcoded docker string for now

If the user is specifying a group then they need to be creating that on their own as this docker library just directly passes the property string to the docker daemon.
iirc the docker binary install runs as root while packages install runs as docker - I haven't seen it as a different group name so far.
Hope this help!

I guess so. we'll see. for now it is fine. I just would have used an obvious attribute/helper method if there would have been one.


[ISSUE-293][REFACTOR] Init worker rpc endpoint in parallel

What changes were proposed in this pull request?
Why are the changes needed?

What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

LGTM.


Guard functions

Implemented type guards to improve readability and type safety in the diff function. Specifically, added helper functions isObject, isArray, and isRichType to encapsulate type checks. It pretty much fixes redundancy and improves clarity, feel free to make any changes if needed. I hope this helps!

Thanks! I can see some of the benefits, but I am not sure if this is necessary given the increased code size, performance cost, and complexity brought by it, especially for isArray, as that is essentially just an alias for Array.isArray. However, I am still open to this if you have any other thoughts.

I understand the code size concern, guess it really is a problem in this situation. isArray indeed can be removed to conserve space.
As for the main concept, I just thought that it's a good idea to create simple, reusable functions for guard checks (mostly for cases where the same things need to be put in multiple places).
However, if the performance/size cost is too high, then the PR probably should be closed.

I am closing this for the aforementioned reasons


Migrate Task does not Fail when it fails

Version 2.1.5
We had 2 failures today, one was access denied bad password, an another where the package already exists.  Both legit errors but the Migrate task did not fail it juts moved on.
Have not looked at the code yet, just wanted to get this logged.

Hi,
I would expect this is already fixed in the latest version. At least according to the source code.
Regards,
Joris

Can this be closed. Also the latest version v2.5.0 is not using the deprecated fetch api anymore.

Sure let's close it.   I will grab the latest release and do some more testing.  Thanks Joris!


Move docs towards users without SI XML experience

I'm aware of the concepts behind Spring Integration and I'm comfortable with them. I'm also a Spring user very comfortable with Java Config and Spring Boot. I don't, however, have experience with Spring Integration's XML configuration. I find it quite difficult to read Spring Integration's documentation and (to a lesser extent) the DSL's docs here because of the XML indirection. I imagine over time there will be more and more users like me--those approaching SI via the DSL only. I'd like to offer my plea here to cater more to me and a like audience. There's some great work in here, but it's nearly unapproachable sometimes, and it deserves to be seen.

Yes, we recognize that more and more people are using Java Configuration; we started adding more comprehensive annotation support in 4.0, by allowing EIP annotations on @Beans and went further in 4.1 providing support for the DSL. The DSL still has gaps, and we are using community feedback to flesh it out. When it is more complete, it (and its documentation) will be folded into the core project.
We do have a plan to add more and more java config/DSL documentation and samples. But this will take some time, due to the sheer volume; the reference manual is already in excess of 450 pages and the effort to supplement all the configuration examples is quite large.
As with the DSL, ongoing work to improve the documentation is, by necessity, prioritized by user requests; we recently added documentation and enhanced the sample directly as a result of a user request about how to configure a TCP outbound gateway using Java Configuration.
So, please feel free to request some specific requirements "how do I do X, Y" etc and we will do our best to respond with documentation changes as time permits, while giving you a short-term answer to your specific questions, either here or on Stack Overflow (with the spring-integration tag).
Thanks for the feedback!

Thank you both as for feedback as well for answer!
Many DSL cases and configuration variants are covered with our tests:
https://github.com/spring-projects/spring-integration-java-dsl/tree/master/src/test/java/org/springframework/integration/dsl/test
So, you can choose a required protocol specific package (amqp, kafka, sftp etc.) and take a look how you can configure appropriate adapter. E.g. JMS Message Driven Channel Adapter: https://github.com/spring-projects/spring-integration-java-dsl/blob/master/src/test/java/org/springframework/integration/dsl/test/jms/JmsTests.java#L223

Starting with Spring Integration 4.2 we are adding more and more Java DSL samples to the Spring Integration Reference Manual, for example the File Reading Component: http://docs.spring.io/spring-integration/reference/html/files.html#_configuring_with_the_java_dsl_6.
We are going to move Java DSL into the Core project since version 5.0.
So, I'm considering this issue as fixed, because the work is being done on the matter.
Thank for the feedback anyway!

Much appreciated!


putInTube switching default tube.

When using putInTube, the current tube for the connection is switched. This is a side-effect that is not ideal.
Consider the scenario:

I have a connection to beanstalk.
I have set the tube to use to "this-is-my-default"
I call $pheanstalk->put(...) and as expected it puts it in the default tube listed above.
I call $pheanstalk->putInTube("some-tube", ...) and as expected it puts it in the tube passed as first argument.
I call $pheanstalk->put(...) and it puts it in the some-tube tube listed above.

Since the beanstalk connection might be passed around throughout the application how can I ever make sure the default is not inadvertently changed by someone using putInTube?
In my opinion useTube() should change the connection state, but putInTube() should not.

This one is a little awkward. putInTube() could be made to reuse the previously used tube after inserting the job. However:

If an exception is thrown while trying to reuse the previous tube, developers are left to handle the difference between "an exception was thrown before the job could be inserted (ie: real failure), vs. "the job was successfully inserted, but an exception was thrown trying to reset tube state". Most developers would not understand that this distinction even exists, leading to scenarios where a job is being treated as not inserted even when it was.

Developers using putInTube inside a loop to batch insert many jobs into a single queue would be performing a ridiculous number of round trips to the server if the queue being inserted to is different than the previously selected one. Example: $queue->useTube('A'); foreach (range(1, 100) as $id) { $queue->putInTube('B', $id); }. That code would do 300 commands instead of 101. It would take an ugly internal tracking hack to prevent those unnecessary commands.

If you are in a position to find putInTube a hazard, you should simply not use it. You could go one step further on a team project and extend the Pheanstalk\Pheanstalk class to throw an exception from putInTube to explicitly forbid its use.

I think having a side effect is worse than having 2 exceptions... Exceptions are explicit and must be handled; side effects are implicit and will create hard to track down bugs.

I still agree with my own idea...
Requirements for an implementation:

Must not switch tubes excessively.
Must not switch tubes needlessly.
Must support persistent connections.

I just noticed that these functions also change state:

peekReady
peekBuried
peekDelayed

This means that either we patch all of these and make the code more complicated, or we simply remove the functionality to dynamically switch tubes.
We could offer something like withTube(string $tube, \Closure $closure) if we really need it.
Could could then look like this:
$pheanstalk->withTube('other', function(Pheanstalk $p) {
    $p->peekBuried();
    $p->put($x);
}

Instead of this:
$tube = $pheanstalk->listTubeUsed();
try {
    $pheanstalk->useTube('other');
    $pheanstalk->put($job);
} finally {
    $pheanstalk->useTube($tube);
}

@frickenate what do you think?

@dmcfaul what's your opinion? You mentioned you use it pretty extensively.
My goal for v4 is to modernize the library using PHP typehinting; also I want to get rid of all side-effects.


AimBot and C4 timer not working anymore

After latest offsets update the AimBot and C4 timer not working anymore.
Also there is a lag in buy menu.

fixed


Organization service, interface and tests

Description:
Added service that fethces organization list / object
Unit Tests:

/frontend/src/app/organization/organization.service.spec.ts

What tests do I need to run to validate this change:
ng test
Description of testing workflow and potential affected places.

Codecov Report

Merging #649 into master will decrease coverage by 0.2%.
The diff coverage is 63.15%.

@@            Coverage Diff            @@
##           master    #649      +/-   ##
=========================================
- Coverage   92.11%   91.9%   -0.21%
=========================================
  Files          80      81       +1
  Lines        2649    2668      +19
  Branches        2       2
=========================================
+ Hits         2440    2452      +12
- Misses        207     213       +6
- Partials        2       3       +1

Impacted Files
Coverage Δ

...ntend/src/app/organization/organization.service.ts
63.15% <63.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ba257...1e8e847. Read the comment docs.


Issue 529 - Various cmdlets for the As Built Report module

This PR addresses the need for various cmdlets to be built in order to support retrieving data from a Rubrik cluster for the As Built Report
Resolve #529
This allows for the As Built Report to display more information about the Rubrik cluster.
Tested within the TM lab against Cluster_B
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION document.
[x] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@shamsway @jaapbrasser - pushed some more commits to fix the failing unit tests and to properly filter Get-RubrikArchive by ID as it doesn't support having {id} in URI


Apply solver builder to Rosenbrock

Modifies the Rosenbrock solver to be creatable using the SolverBuilder class. This work coincidentally also removed the remaining template template parameters. Also, moves the rate constant calculation step out of the solver function, and modifies the GH Action for coverage to run on pushes to main, so that CodeCov diffs stay up-to-date
closes #529
closes #538
closes #539
closes musica/134

Codecov Report
Attention: Patch coverage is 89.47368% with 16 lines in your changes missing coverage. Please review.

Project coverage is 92.74%. Comparing base (555be4e) to head (db81148).
Report is 10 commits behind head on main.

Files
Patch %
Lines

include/micm/solver/solver_result.hpp
27.27%
8 Missing :warning:

include/micm/solver/solver_builder.inl
90.00%
4 Missing :warning:

include/micm/solver/jit_rosenbrock.hpp
75.00%
3 Missing :warning:

include/micm/util/sparse_matrix.hpp
90.90%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   92.25%   92.74%   +0.49%
==========================================
  Files          45       46       +1
  Lines        3407     3322      -85
==========================================
- Hits         3143     3081      -62
+ Misses        264      241      -23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@mattldawson can you give a brief flowchart or introduction about the general steps to use the new solverbuilder class to build a solver for CPU/GPU? Thanks.

A CPU solver is built in the README example here:
https://github.com/NCAR/micm/blob/6b973a054282386cf03a86fec916ec07b95cfe00/test/tutorial/test_README_example.cpp#L34-L37
I don't think we have a full CUDA Rosenbrock example yet in the tutorial, but I think it would follow logic similar to the JIT solver:
https://github.com/NCAR/micm/blob/6b973a054282386cf03a86fec916ec07b95cfe00/test/tutorial/test_jit_tutorial.cpp#L104-L108

Thanks @mattldawson for working on this giant PR. It is lots of work!
It seems that two tests on the windows platform fail the CI workflow somehow and the error message indicates an internal compiler error. Are they just old versions and should be removed? Or do they indicate a potential code bug somewhere?

They just mean there is a bug in the compiler code. I don't think there is a way to infer anything beyond that. I will create a separate issue to look into that.

Does this also close #496?

Does this also close #496 and #499?

I think it closes #496, but I didn't include the analytical tests for Backward Euler because they were failing (probably needs different solver tolerances, or lower expectations as @sjsprecious mentioned)


[question] Node ID skipping numbers

Call it an OCD thing, but why is it when something gets messed up like the security requirement getting skipped, do node IDs that are removed/excluded get skipped on the next inclusion? If I remove my kitchen switch and re-add it due to an error, why can’t it have the same ID?

This is something zwave-protocol specific, in order to re-use same ids you should use replace failed node instead of exclusion. Once a node is excluded that id cannot be taken again. The only way is to factory reset the stick and add back each one one by one


Issue with underscore being inserted into username

From a user on our google groups forum on 13 Sep:

Hi,
thanks for your great app.
Since some days, the app doesn't add, the date of the picture into the template. Is this my fault (wrong settings) or is this a problem with the app?
And the app puts an underscore into my username. Normally it is “Z thomas“. But since two days it is turned into “Z_thomas“

Very strange bug! I don't recall making any changes in 2.8.3 or 2.8.2 that should affect usernames? @maskaravivek @neslihanturan

Oops, I just realized that we already had an issue for the date at #1854 . I'll modify this issue to make it solely about the underscore.

For me, this issue started between 4th and 13th August - see my contribs at https://commons.wikimedia.org/wiki/Special:ListFiles/Vojtěch_Dostál

@misaochan @VojtechDostal Hi guys, the underscore issue should have been present from 15 Jun 2017. Older posts from @VojtechDostal are with underscore as well. I did not check all of them but it seems to be isolated to his pictures with "Uploaded using Commons Mobile App" in detail. Oldest one from them is https://commons.wikimedia.org/wiki/File:N%C3%A1m%C4%9Bst%C3%AD_Jana_Pernera_2018.jpg.
My guess is that issue is caused by "String username = canonicializeUsername(usernameEdit.getText().toString());" canonicializeUsername replace space with "_" . I can probably fix that, however i cant predict if that will cause more errors, because there might be some reason why the Author of PageTitle.java normalized usernames like that.

Fixed in #1982


Robot uses deprecated require.extensions prevents using Jest for testing

Node.js global require.extensions was deprecated since v0.10.6 and appears to have been removed from the documentation as of v8 LTS:
This block of code causes problems when testing with Jest and hubot-test-helper: https://github.com/hubotio/hubot/blob/ea182fa73852177897db51e119ce78e4c645bacc/src/robot.js#L352-L355
The module hubot-test-helper uses const Hubot = require('hubot/es2015'); to require in Hubot: https://github.com/mtsmfm/hubot-test-helper/blob/master/src/index.js#L5
Global require.extensions is undefined running under the default Jest test runner (logging added to diagnose problem):
failing scenario
  console.log node_modules/hubot-test-helper/src/index.js:161
    script /Users/REDACTED/scripts/REDACTED.js

  console.log node_modules/hubot/src/robot.js:351
    filepath /Users/REDACTED/scripts filename REDACTED.js

  console.log node_modules/hubot/src/robot.js:354
    full /Users/REDACTED/scripts/REDACTED ext .js

  console.log node_modules/hubot/src/robot.js:356
    in robot require undefined

  console.log node_modules/hubot/src/robot.js:361
    not require extensions

Related: https://github.com/facebook/jest/issues/281 (workarounds are not working for Hubot)
Is there another recommended way to use Jest with Hubot, or is the preferred/recommended testing framework Mocha?
Would it be better to remove this check that is relying on a deprecated object to exist? The code does indeed run in Jest with the default runner and minimal config changed when the above block is removed. I don't know if https://github.com/hubotio/hubot/issues/1355 is still a concern. It does attempt to load non-js files (and folders that may not have an index.js) but the try/catch block can avoid problems if process.exit(1) is removed.
working modified scenario
    console.log node_modules/hubot-test-helper/src/index.js:161
      script ../scripts
    console.log node_modules/hubot/src/robot.js:351
      filepath /Users/REDACTED/scripts filename deploy-queue.js
    console.log node_modules/hubot/src/robot.js:354
      full /Users/REDACTED/scripts/deploy-queue ext .js
    console.log node_modules/hubot/src/robot.js:356
      in robot require undefined
    console.log node_modules/hubot/src/robot.js:369
      required /Users/REDACTED/scripts/deploy-queue
    console.log node_modules/hubot/src/robot.js:373
      loaded script as function
    console.log node_modules/hubot/src/robot.js:351
      filepath /Users/REDACTED/scripts filename error-handler.js
    console.log node_modules/hubot/src/robot.js:354
      full /Users/REDACTED/scripts/error-handler ext .js
    console.log node_modules/hubot/src/robot.js:356
      in robot require undefined
    console.log node_modules/hubot/src/robot.js:369
      required /Users/REDACTED/scripts/error-handler
    console.log node_modules/hubot/src/robot.js:373
      loaded script as function
    console.log node_modules/hubot/src/robot.js:351
      filepath /Users/REDACTED/scripts filename foo.yaml
    console.log node_modules/hubot/src/robot.js:354
      full /Users/REDACTED/scripts/foo ext .yaml
    console.log node_modules/hubot/src/robot.js:356
      in robot require undefined
    console.log node_modules/hubot/src/robot.js:380
      Unable to load /Users/REDACTED/scripts/foo: Error: Cannot find module '/Users/REDACTED/scripts/foo' from 'robot.js'
          at Resolver.resolveModule (/Users/REDACTED/node_modules/jest-resolve/build/index.js:221:17)
          at Resolver._getVirtualMockPath (/Users/REDACTED/node_modules/jest-resolve/build/index.js:338:16)
          at Resolver._getAbsolutePath (/Users/REDACTED/node_modules/jest-resolve/build/index.js:324:14)
          at Resolver.getModuleID (/Users/REDACTED/node_modules/jest-resolve/build/index.js:301:31)
          at Runtime._shouldMock (/Users/REDACTED/node_modules/jest-runtime/build/index.js:766:37)
          at Runtime.requireModuleOrMock (/Users/REDACTED/node_modules/jest-runtime/build/index.js:460:14)
          at MockRobot.loadFile (/Users/REDACTED/node_modules/hubot/src/robot.js:368:22)
          at Helper.createRoom (/Users/REDACTED/node_modules/hubot-test-helper/src/index.js:165:17)
          at Object.createRoom (/Users/REDACTED/test/REDACTED.test.js:36:31)
          at Object.asyncJestLifecycle (/Users/REDACTED/node_modules/jest-jasmine2/build/jasmine_async.js:63:37)
    console.log node_modules/hubot/src/robot.js:351
      filepath /Users/REDACTED/scripts filename REDACTED.js
    console.log node_modules/hubot/src/robot.js:354
      full /Users/REDACTED/scripts/REDACTED ext .js
    console.log node_modules/hubot/src/robot.js:356
      in robot require undefined
    console.log scripts/REDACTED.js:8
      /Users/REDACTED/scripts/REDACTED.js loaded
    console.log node_modules/hubot/src/robot.js:369
      required /Users/REDACTED/scripts/REDACTED
    console.log node_modules/hubot/src/robot.js:373
      loaded script as function
    console.log node_modules/hubot/src/robot.js:351
      filepath /Users/REDACTED/scripts filename lib
    console.log node_modules/hubot/src/robot.js:354
      full /Users/REDACTED/scripts/lib ext
    console.log node_modules/hubot/src/robot.js:356
      in robot require undefined
    console.log node_modules/hubot/src/robot.js:380
      Unable to load /Users/REDACTED/scripts/lib: Error: Cannot find module '/Users/REDACTED/scripts/lib' from 'robot.js'
          at Resolver.resolveModule (/Users/REDACTED/node_modules/jest-resolve/build/index.js:221:17)
          at Resolver._getVirtualMockPath (/Users/REDACTED/node_modules/jest-resolve/build/index.js:338:16)
          at Resolver._getAbsolutePath (/Users/REDACTED/node_modules/jest-resolve/build/index.js:324:14)
          at Resolver.getModuleID (/Users/REDACTED/node_modules/jest-resolve/build/index.js:301:31)
          at Runtime._shouldMock (/Users/REDACTED/node_modules/jest-runtime/build/index.js:766:37)
          at Runtime.requireModuleOrMock (/Users/REDACTED/node_modules/jest-runtime/build/index.js:460:14)
          at MockRobot.loadFile (/Users/REDACTED/node_modules/hubot/src/robot.js:368:22)
          at Helper.createRoom (/Users/REDACTED/node_modules/hubot-test-helper/src/index.js:165:17)
          at Object.createRoom (/Users/REDACTED/test/REDACTED.test.js:36:31)
          at Object.asyncJestLifecycle (/Users/REDACTED/node_modules/jest-jasmine2/build/jasmine_async.js:63:37)
    console.log node_modules/hubot/src/robot.js:351
      filepath /Users/REDACTED/scripts filename REDACTED.js
    console.log node_modules/hubot/src/robot.js:354
      full /Users/REDACTED/scripts/REDACTED ext .js
    console.log node_modules/hubot/src/robot.js:356
      in robot require undefined
    console.log node_modules/hubot/src/robot.js:369
      required /Users/REDACTED/scripts/REDACTED
    console.log node_modules/hubot/src/robot.js:373
      loaded script as function
    console.log node_modules/hubot/src/robot.js:351
      filepath /Users/REDACTED/scripts filename REDACTED.js
    console.log node_modules/hubot/src/robot.js:354
      full /Users/REDACTED/scripts/REDACTED ext .js
    console.log node_modules/hubot/src/robot.js:356
      in robot require undefined
    console.log node_modules/hubot/src/robot.js:369
      required /Users/REDACTED/scripts/REDACTED
    console.log node_modules/hubot/src/robot.js:373
      loaded script as function

modified test code
    /*
    // see https://github.com/hubotio/hubot/issues/1355
    if (!require.extensions[ext]) { // eslint-disable-line
      console.log('not require extensions')
      return
    }
    */

    try {
      const script = require(full)
      console.log(`required ${full}`);

      if (typeof script === 'function') {
        script(this)
        console.log(`loaded script as ${typeof script}`);
        this.parseHelp(path.join(filepath, filename))
      } else {
        console.log(`Expected ${full} to assign a function to module.exports, got ${typeof script}`)
        this.logger.warning(`Expected ${full} to assign a function to module.exports, got ${typeof script}`)
      }
    } catch (error) {
      console.log(`Unable to load ${full}: ${error.stack}`)
      this.logger.error(`Unable to load ${full}: ${error.stack}`)
      // process.exit(1)
    }
  }

@jeremygaither did you ever figure out a workaround for this?

@dtothefp I really haven't tried again with Jest, since I ran into considerable problems. The async nature of Jest made many things with hubot and hubot-test-helper much harder versus Mocha, if I recall correctly.

No
On Thu, Oct 10, 2019, 3:54 PM David Fox-Powell<EMAIL_ADDRESS>wrote:

@jeremygaither https://github.com/jeremygaither did you ever figure out
a workaround for this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hubotio/hubot/issues/1483?email_source=notifications&email_token=ANK56DJGONXBDV4EHH42HZTQN6I6ZA5CNFSM4GHE2AOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA54WMI#issuecomment-540789553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANK56DME7GQEUHAD65LZCXTQN6I6ZANCNFSM4GHE2AOA
.

This was fixed in https://github.com/hubotio/hubot/pull/1581


Saml Client impl deprecated; blocked on Java 17 or other impl

SAML2Client is deprecated as of pac4j 5.7.0.
Per the docs the recommended one requires Java 17.

Not currently using SAML, but we should fix it at some point in case someone wants to use it, and need to fix Java 17 issues first.


Fix forms browse focus/shortcut issues

If a form button is focused when you press Esc, the form will be collapsed, but focus will be gone. Focus should move up to the entire form.

If the "first" or "last" paginator buttons are pressed and then are disabled by the pagination logic, focus is again lost. Focus should be moved to some default position on the paginator menu.

single-key shortcuts should also not fire when the Option or Command meta-keys are active. One conflict is pressing Command-F on Mac to bring up the browser's in-page search, which will bring you to the first page, which is not what you want.

10139d20d3073fb8af52ecd6dc8c06a3356bbabc


[Network] Application Gateway - mTLS and SSL Profile GA Status

mTLS and SSL Profile are now GA - removing preview flag
https://azure.microsoft.com/en-us/updates/general-availability-application-gateway-mutual-authentication/
Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Network


Do not for review: Build test

Pull Request Test Coverage Report for Build 312

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 74.341%

Files with Coverage Reduction
New Missed Lines
%

internal/internal_task_pollers.go
2
73.76%

Totals

Change from base Build 308:
0.0%

Covered Lines:
8431

Relevant Lines:
11341

💛  - Coveralls


"command" in the code should be "macro"

Though, people on the latex stackoverflow also say "command"...


Unable to find 'RWNode' when installing in fresh Pharo 9

Hi, I just created a new (development) Pharo 9 image and tried to install Woden using the suggested method, and after a while I got the following error;

Is there something missing from the baseline maybe?

However, when I clicked 'Proceed' just to see what happened, the rest of the installation went fine. Strange, but OK

I have just pushed the latest version onto this repository. Try loading it again on a clean image.


Single numbers entered will double after losing and regaining vs code focus

VSCode Version: 1.25.1
OS Version: MacOS X El Capitan 10.11.6

Steps to Reproduce:

Have a single number in code. Like just a single '1'.
Put your cursor directly after the 1.
Move focus away from VSCode (e.g. via Alt-Tabbing)
Move focus back to VSCode (Alt-Tab back)
Type the same number ( 1 ). 2 number 1s are placed instead of only 1 - it will now read '111'.
If you do this again and again, the number of repeats will get bigger by a factor of n*2+1 => 1, 111, 1111111,<PHONE_NUMBER>11111,<PHONE_NUMBER>111111111111111111111,<PHONE_NUMBER>11111111111111111111111111111111111111111111111111111, [...]

This is if you alt-tab away & back, and just type the same number that was before.
This will work for symbols and single numbers.

Does this issue occur when all extensions are disabled?: Yes/No
Yes.
p.s. the least you could do was make it a fibonacci sequence or something instead of n*2+1

I can not reproduce this behavior with latest vscode insiders.
Can you reproduce with latest vscode insiders https://code.visualstudio.com/insiders/
Can you reproduce with no extensions?


[develop] Create session middleware

I'm thinking that session handling should be removed from the core and left up to the user to implement via middleware. This would make it far easier to switch out session handling strategies and completely decouples it from the core routing & despatch systems.
Arguments for/against? If agreed I'll submit a PR once the middleware interface stabilises

I am for this, I currently use the Laravel Session library through a middleware I created instead of the built in Session handling.

I'm OK with this so long as we provide at least one good session middleware in the Slim-Middleware repo. @silentworks Do you want to get that going?

Can the middleware be split out into separate repos? If i only want the Session handler middleware, i don't want to have to pull in the 10 other middlewares along with it that i'm not going to use.
Make slim/middleware a collection package of the other repos

Seems reasonable to me.

Yeah I will get this sorted.

@silentworks Thanks! Send a PR to the develop branch when ready.

Since we're extracting sessions from Slim core, I guess we can do away with the hard dependency on Zend/Crypt, correct? We'd lose encrypted cookies, but I'm not entirely sure that's necessary anyway due to the inherent 4Kb limitation on cookie data. I definitely want the new Session middleware to offer encryption as an option.
How close are you on this?

I'd like to lose the encrypted cookies from core if we can. It feels like something that could also be in middleware.

Agreed. I'll work on stripping out the encryption stuff today.

I have started working on this now, should have something up on the weekend. I will need to touch base with you @codeguy over irc or on hangout before then.

I'll be on irc all day. Just open a private query when you want.

Don't forget to also accommodate flash messaging. The original Flash class still exists in the core repo. Feel free to migrate this class if necessary.

I've removed sessions from core, so renaming this to something more appropriate for the new session middleware.

@silentworks How's this coming along?

@codeguy getting there, but slower than anticipated due to workload. Hit me up when ur on irc or hangout.

@silentworks I'll be on irc most of the day if you need to chat.

This can wait until after the 3.0.0 release if need be. So there's no super rush on this.

Ok cool, sorry just got was too busy lately with other work. Downtime is currently minimal.

No worries. That's what I figured.

I am going to revive this topic for discussion. What features are we looking for in the middleware ?
$app->add(function ($req, $res, $next) {
    session_start();
    $next($req, $res);
});

https://github.com/geggleto/SessionMiddleware
Takes _SESSION injects into Request via Attributes.

My question is... do we even need this? Can we recommend another PSR-7 middleware that already exists? If not, more than happy to have this built

I don't know of any but I would imagine its built already ?

Can this issue be closed? A repository exists for a Slim implementation of sessions, although no work has been done for a while.
I would assume Slim is not offering session handling as there are plenty of available libraries out there.

Yeah - We'll have a Slim session implementation if someone cares enough...

:)


E2E: go push main SLSA3 config-noldflags

Repo: https://github.com/ianlewis/example-package/tree/main
Run: https://github.com/ianlewis/example-package/actions/runs/2465749356
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/ianlewis/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Thu Jun  9 03:33:57 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2465829899
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Thu Jun  9 03:57:32 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2470239676
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Thu Jun  9 18:08:48 UTC 2022
Tests are passing now. Closing this issue.


fix: nock now returns 500 when cassette missing

:tada: This PR is included in version 4.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Can you please use explicit tf-core dependency versioning that matches face-api

It forces me to use a skipLibCheck and clutters my dependency tree since it will almost always download a higher version of tf-core then required by face-api
This issue is a direct result of that https://github.com/justadudewhohacks/face-api.js/issues/415
Is there any reason why setting an explicit version wouldn't be a good idea?

Is there any reason why setting an explicit version wouldn't be a good idea?

The only real reason is that we would enforce other code bases using tfjs-image-recognition-base to use the same tfjs-core version as face-api.js
To be honest, I do not understand, why your package manager does not install the tfjs-core version that is explicitly set in the package.json of face-api.js. Are you using yarn or npm?


model run fine without OPTIMIZED_KERNEL_DIR=xtensa in tflm, but model run exception with OPTIMIZED_KERNEL_DIR=xtensa.

model run fine without OPTIMIZED_KERNEL_DIR=xtensa in tflm, but model run exception with OPTIMIZED_KERNEL_DIR=xtensa.
model.zip
error-log.txt

@cad-audio please have a look into this issue.

XTENSA_TOOLS_VERSION=RI-2020.5-linux
compile cmd：make -f tensorflow/lite/micro/tools/make/Makefile TARGET=xtensa OPTIMIZED_KERNEL_DIR=xtensa TARGET_ARCH=hifi5 XTENSA_CORE=Amlogic_v9 micro_speech_test BUILD_TYPE=release -j4

micro_speech_test.zip
you can use this application to  reproduce the issue.

@jiayue198509 this seems to be binary ,could you please share the tflm test application source code that uses your model.

src.zip

@nyadla-sys have any progress？
If you need any more information, please let me know. Thanks！

@jiayue198509 we could reproduce issue from our end and looking into our nnlib-hifi5 that we recently pushed on to Github.

we found the issue with our NNLib-hifi5 and working on to fix the issue

@nyadla-sys have any progress？

@cad-audio Bhanu could you please respond to his query?

Hi @jiayue198509,
The issue is related to some alignment in xa_nn_matXvec_sym8sxasym8s_asym8s_circ().
and It is fixed in the latest HiFi 5 NN Library(v1.7.0).
I think tflite-micro master code uses the previous version of HiFi 5 NN Library (i.e. v1.6.0).
Thanks,
Bhanu


feat(clearAll): New widget

Uses #407 's autoHideContainer instead of hideContainerWhenNoResults. We might want to wait until this is implemented in all widgets before merging.
Closes #405

This is also missing tests

Expected, I'm waiting for the helper update before implementing them.

I'm waiting for the helper update before implementing them

Which update? I mean do you just need a release of the helper?

No I (or we) need to fulfill algolia/algoliasearch-helper-js#195 before going further. Relying on state.XXXRefinements is highly risky : at the beginning we only had facetsRefinements and disjunctiveFacetsRefinements, now we have 6 of them. Knowing that we need to update one method on the helper when adding a new type of refinements seems way safer than having to remember to update instantsearch.js at the same time on all widgets which require these.

No I (or we) need to fulfill algolia/algoliasearch-helper-js#195 before going further.

If it's right now working we can move on because we are not in the way to add any new type of refinements to the helper in the coming weeks.
Would be good to iterate on this widget and then implement in the helper.

@vvo , I will actually need to fullfill algolia/algoliasearch-helper-js#195 for currentRefinedValues, so let's not create tests and everything for something that will be replaced just afterwards.

Ready for review

If it's right now working we can move on because we are not in the way to add any new type of refinements to the helper in the coming weeks.

Actually, I didn't update the documentation in the README, working on this now.

Actually, I didn't update the documentation, working on this now.

Forgot to clearTags and to add CSS empty classes.

Ready for review

@Jerskouille could you maybe squash the commits together to make it cleaner?

Otherwise, looks :+1: @Jerskouille -> once you've done the updates I'm happy to merge it!

Done

Oh btw, do you manage to render it from the Documentation page; because since we don't have any active refinements I assume it auto-hides?

What code are we using to instantiate the widget, the one in {% highlight javascript %}... ? If yes, I'll just add autoHideContainer: false.

Checking right now

Done, displaying in the docs.

:+1:


Add a release note for external istiod

[ ] Configuration Infrastructure
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@linsun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dbec3c24dc8662700198a3c854124f30d9f25fb9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dbec3c24dc8662700198a3c854124f30d9f25fb9
link
/test release-notes_istio

lint_istio
dbec3c24dc8662700198a3c854124f30d9f25fb9
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dbec3c24dc8662700198a3c854124f30d9f25fb9
link
/test release-notes_istio

lint_istio
dbec3c24dc8662700198a3c854124f30d9f25fb9
link
/test lint_istio

integ-pilot-k8s-tests_istio
dbec3c24dc8662700198a3c854124f30d9f25fb9
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3f304db008bc86d5d280bf53ce8364fc7fcd25d9
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@linsun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3f304db008bc86d5d280bf53ce8364fc7fcd25d9
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f304db008bc86d5d280bf53ce8364fc7fcd25d9
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f304db008bc86d5d280bf53ce8364fc7fcd25d9
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f304db008bc86d5d280bf53ce8364fc7fcd25d9
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: new pull request created: #28676


File "github.sql" not found

Hi,
This necessary file to run the demo gitrec app is not available
in this URL :
https://cdn.gorse.io/example/github.sql
Can we download this file otherwise?
Thanks

The new github.sql is now available: https://cdn.gorse.io/example/


There is no unit tests for discoveryAdvertisingStateUpdateNonTCP of thaliMobileNative.js #868

This change is

PR is added to the queue for testing as 1. task. (aab4ee7)

@opetkevich,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Test 111941151 (aab4ee7) build started.

Test (Fail) 111941151 build is completed (aab4ee7)
See https://github.com/ThaliTester/TestResults/tree/111941151aab4ee7_There_is_no_unit_tests_for_discoveryAdvertisingStateUpdateNonTCP_of_thaliMobileNative_js__868_opetkevich/ for the logs

PR is added to the queue for testing as 1. task. (3ed0d6e)

Test 111941151 (3ed0d6e) build started.

Test (Fail) 111941151 build is completed (3ed0d6e)
See https://github.com/ThaliTester/TestResults/tree/1119411513ed0d6e_There_is_no_unit_tests_for_discoveryAdvertisingStateUpdateNonTCP_of_thaliMobileNative_js__868_opetkevich/ for the logs

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Documentation on the bootstrap dependency

Following the setup, it suggested the requirement to:
import "bootstrap/dist/css/bootstrap.min.css";
It would be very useful to know which version of bootstrap is currently supported.
I don't see such a dependency from the module's package.json neither.

I guess any version of Bootstrap 3 or 4 should work. There is not much
difference between these versions of Bootstrap; they keep compatibility
with most of the classes used by this Vue plugin (specifically, styles of
buttons, tables, pagination).
Thanks for the issue. I'll add the supported Bootstrap versions to the
documentation.
To be honest, I'm considering removing Bootstrap as a dependency, because
this plugin only uses a few classes of Bootstrap. Requiring users to
install Bootstrap may make their CSS bundle large. Copying the few CSS
classes from Boostrap into the stylesheet of this plugin seems to make
more sense to me. I'll think about it.

Thanks for the prompt reply, and the great work btw!
You are right, Bootstrap syntax should be largely the same. I was just concerned there will be some breaking or unexpected behaviour changes between releases, so it'd be nice to specify the tested version range; it'd also save the user from having to install it separately if they don't already use Bootstrap.
Boostrap breaking changes reference:

https://getbootstrap.com/docs/4.0/migration/
https://getbootstrap.com/docs/5.0/migration/

The idea of removing the dependency is the approach that other similar libraries, vuetify, ag-grid, have taken. As you said, they wrap into the package a css or scss export that the user will have to import at app.vue or component level.
This'd probably mean it'd make sense to add custom classes than using the Bootstrap ones to provide some flexibility to override some styles without affecting other Bootstrap elements. But that's a subjective call. :)
PS: I'm coming from a context migrating vue-2 to vue-3, and moving away from Bootstrap-Vue (Bootstrap-4) to native Boostrap 5, and also away from Vuetify (v-data-table) as their Vue 3 release is not out until Feb 2022 and it doesn't look like data-table is in their alpha documentation yet. So I think your great work will gain attract some attention in the coming months.
Thanks for answering my question!

It is no longer necessary to install bootstrap to use this plugin.
I copied some of the bootstrap styles (actually, they are just a few) to
this plugin's internal stylesheets.
Thanks for the issue.


Header: Document Angular snippets

Document common patterns for Angular applications interacting with the header:

[ ] Persisting language selection
[ ] Setting the correct language or getting the currently set language from the header
[ ] Adding or updating a custom config

[ ] Add language options to the blueprint


Python version 3.7 raises import error

Comparing
https://github.com/shahriyardx/easy-pil/blob/cf259c0f9d370506d8d0bc2ef521f040467499a3/setup.py#L36
to
https://stackoverflow.com/q/70210001/2988730
Seems like 3.7 needs a tweak for full support.

I have updated it. Should fix the issue

Looks good. The commit shows that almost every file was touched, probably because of line endings. Couple of comments:

The new requirement typing-extensions==4.0.1 could be future-proofed using >=.
Would you consider using version tags in Git?

Looks good. The commit shows that almost every file was touched, probably because of line endings. Couple of comments:

The new requirement typing-extensions==4.0.1 could be future-proofed using >=.
Would you consider using version tags in Git?

Every file changed because I opened the folder using pycharm. And it somehow changed every line of code 🥴
For your suggestions you can do a PR with suggested changes.

I think I'll do that, but I won't be able to make tags on the master branch.

@shahriyardx. I've gone ahead and did some mods to the setup code in #4. Hope you like them.


[1.10] Fix travis integration tests

Backport of #2158

/retest
LGTM

/retest

/test kata-containers

/test kata-containers

Merging this since kata is broke on 1.10.


[Bug]: Block break doesn't count for skills record

Describe the Bug
I'm trying to progress on Skills Record but the challenges not count my block breaks
To Reproduce
1.craft skills record
2.put mining skill card, pen and paper
3.break the challenge blocks
4.progress bar not moving
Catch the bug In Action!
No response
Crash Report or Log
No response
OS
windows 11
Minecraft Version
1.20.1
ModLoader
Forge
Mod Version
0.1.1a-beta

Does this happen in Singleplayer or Multiplayer?
And is the block you are trying to break placed by a player or block placer thing?
And can you demonstrate this issue on a video? Because on my side, I couldn't recreate this.

I'm playing on singleplayer https://streamable.com/hqiht9

Oh, I see. The mod is supposed to work like this! If the required block is placed by a Player or Block Placer from any mod, It will not count toward the challenge.
For now. If you don't like it, there is a way to bypass this system! You can add the blocks you desire in a tag named "ultimine_addition:deny_is_placed_by_entity" through Datapack.
P.S. I'm about to release a new update for the mod that includes an ON/OFF option in the config for this matter.


The plugin should be able remove its comments

I removed some rules on sonar but the associated plugin comments are still there after another analyse.
I suppose the plugin only add/update comments but don't remove them.

To optimize the request number to Stash, plugin does not delete its comments, this task is delegated to Stash, Indeed, Stash automatically removes a comment if the line is modified. But in this case, like code does not moved, I do confirm, comments will not be deleted...
This ticket is relevant but we need to take care not to impact plugin performance.

And why not having an option (disabled by default) where the description will give the potential perfomance issue?

Pull-request #29 submitted.
Through a new option, the plugin will be able to delete all comments submitted during previous SQ analysis. This reset is the initial action run by the plugin and it deletes only comments submitted by the SonarQube user.
Strong effort has been done to optimize the reset not to impact to much plugin performance.

:+1:

Feature available on master branch and will be release with plugin version 1.1.0.


Performance: Item copy service

Copying of a large nested structure with lots of expressions takes a lot of time (in excess of 1 minute). Needs investigation to see where is the bottleneck and if this could be made faster. If not, progress feedback should be created on composer side and ingress timeouts adjusted accordingly.

Duplicate. Closed