Enable more flags to check for concurrency compatibility

Discussed in https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/discussions/3442

Originally posted by mattmassicotte October 17, 2024
Hello friends! There are two additional flags that, while technically can be source-incompatible, can also have a meaningfully-positive impact on warnings produced by strict concurrency.
InferSendableFromCaptures: https://github.com/swiftlang/swift-evolution/blob/main/proposals/0418-inferring-sendable-for-methods.md
GlobalActorIsolatedTypesUsability: https://github.com/swiftlang/swift-evolution/blob/main/proposals/0434-global-actor-isolated-types-usability.md
I've had to use both of these to address warnings that I would otherwise not be able to fix. I think it may make sense to consider enabling these as well. Thoughts?

I'm not sure how much of an impact these will have on the totals but we should make sure to mark the date when these flags went into effect on the Ready for Swift 6 charts in case their impact is significant.

I've tried applying these flags with Xcode 16.1 but I'm struggling to find a variant that works with SwiftPM builds:
🖥 env DEVELOPER_DIR=/Applications/Xcode-16.1.0.app xcrun swift build --arch arm64 -Xswiftc -Xfrontend -Xswiftc -stats-output-dir -Xswiftc -Xfrontend -Xswiftc .stats -Xswiftc -strict-concurrency=complete -Xswiftc -enable-upcoming-feature=InferSendableFromCaptures -Xswiftc -enable-upcoming-feature=GlobalActorIsolatedTypesUsability
Building for debugging...
[0/3] Write sources
[1/3] Copying Documentation.docc
[2/3] Write swift-version--7754E27361AE5C74.txt
error: unknown argument: '-enable-upcoming-feature=InferSendableFromCaptures'

I've tried all manner of variations:

with/without -Xswiftc
with both -enable-... and --enable-...
with both ...-feature=XXX and ...-feature XXX

It does appear to be working when setting OTHER_SWIFT_FLAGS for the xcodebuild builds.

cc @mattmassicotte

hmmm. How about this:
-Xswiftc -enable-upcoming-feature -Xswiftc GlobalActorIsolatedTypesUsability`

Ah, of course, it's a -Xswiftc per flag! That works, thanks a lot for the pointer.
We're currently reprocessing with 16.1 so these new flags won't land straight away (so we don't mix results). It'll go live later this week.

So I have this in place and passing our builder tests but I'm having second thoughts whether we should run with these flags.
We're already seeing discrepancies between what we report and what users see and these custom flags will make it even harder for authors to compare their local results with what we show. Enabling complete concurrency checking or running in language mode 6 are well enough documented but setting upcoming feature flags is trickier.
While this would presumably help with the error and compatible package counts, shouldn't we be testing as plain a build config as possible?
To you point, @mattmassicotte

I've had to use both of these to address warnings that I would otherwise not be able to fix. I think it may make sense to consider enabling these as well. Thoughts?

On reflection, I don't think we want to achieve the minimum number of warnings, we want to show the number of warnings you're getting when you run the stock compiler with concurrency warnings enabled.
This may guide the decision on defaults but it can't do so if we part with the defaults.

While this would presumably help with the error and compatible package counts, shouldn't we be testing as plain a build config as possible?

I agree wholeheartedly with this 👍

Makes total sense! It's true that the only way to get a valid picture of Swift 6 mode compatibiilty is by running with Swift 6 mode. That's not the same thing as Swift 5 + StrictConcurrency, but that may not be what you want. Totally trust your judgement here!

the only way to get a valid picture of Swift 6 mode compatibiilty is by running with Swift 6 mode

We run in Swift 5 mode with -strict-concurrency=complete because it's the only way to get stats for concurrency warnings. It's an attempt at running as close as possible to Swift 6 mode with something like "continue build on error".
If we ran in Swift 6 mode we could only really report a boolean "worked" / "didn't work" and no error or warning count, unfortunately.

This is not as close as possible to Swift 6 mode though! Swift 6 mode is, roughly, all flags on + concurrency warnings become errors.
But, I totally get that these things are in tension. If you turn on the ~ 20 upcoming feature flags, you are almost at Swift 6 mode while preserving warnings.  I think keeping things simple is very desirable though.

I actually almost raised that question yesterday, if including these flags is closer to mode 6 than just mode 5 + -strict-concurrency=complete. So you're saying we'd have to pass in 20 additional flags in this awkward -Xswiftc -enable-upcoming-feature -Xswiftc X style...? 😵💫
One of the questions is what users are more likely interested in:

an issue count if the package was compiled with language mode 6
an issue count if the package was compiled with language mode 5 + complete concurrency checking

When planning the feature we assumed these two to be the same but if that's not the case, we should revisit that assumption.
A few more observations/thoughts:

We'd be changing a setting while we're gathering data (earlier data points were gathered with different settings). We can highlight this in the plot.
Unless we add the flags we're unlikely to actually see any changes to the issue count from the compiler side. Language mode + concurrency is not going to materially change going forward, so we'd only be measuring package authors' efforts.
I wish there was an easier way to opt-into mode 6 that captures all issues other then running mode 5 + all the flags. The reason we don't want to run with mode 6 is that it will stop at the first error and not give us a complete picture. We lack a mode 6 + errors as warnings.

I think we may want mode 5 + all the flags, awkward as it is. It's about language mode 6 and mode + complete concurrency doesn't seem to cover it well enough.

One of the questions is what users are more likely interested in:

an issue count if the package was compiled with language mode 6
an issue count if the package was compiled with language mode 5 + complete concurrency checking

The answer to this is clear to me. Swift 5 mode + extra concurrency warnings is no longer a real world situation now that Swift 6 is released.
Developers want the results as if Swift 6 mode were switched on.
It's truly a shame that we can't get the error numbers in that situation, but in my opinion that's clearly what we're aiming for.

Just to record a link here as well, there might be a resource to track what flags we should be using in the making here: https://toot.iamkonstantin.eu/@konstantin/113464415244283221

Also cc-ing @hborla for awareness/review of the idea to include additional build flags.

Looking through the list of flags here: https://flags.swiftythemes.com/language-features/6.0.html I've come up with the following list of "upcoming" feature flags to include:

DisableOutwardActorInference
DynamicActorIsolation
GlobalActorIsolatedTypesUsability
GlobalConcurrency
InferSendableFromCaptures
IsolatedDefaultValues
RegionBasedIsolation
StrictConcurrency

I don't think we want to include any of the "experimental" ones, do we?
cc @mattmassicotte @hborla

The answer to this is clear to me. Swift 5 mode + extra concurrency warnings is no longer a real world situation now that Swift 6 is released.

This is not quite true. I work on a large project migrating to Swift 6, and the thing we found is that mixing Swift 5 and Swift 6 mode in different packages in the same codebase is actually really dangerous, so we are new running our "Swift 6" code as Swift 5 + all flags and will keep doing it until we can switch to Swift 6 for every part of the codebase at once.

@DagAgren  This is a well-understood (but terrible) situation. You have Swift 5 code that is incorrectly annotated, combined with the DynamicActorIsolation flag (which is on with Swift 6 mode). You can selectively disable the runtime assertions, if you want to admit data races though. If you have turned on DynamicActorIsolation with Swift 5 code, you should also see these assertions trip.
One thing is StrictConcurrency automatically turns on IsolatedDefaultValues, GlobalConcurrency, and RegionBasedIsolation.
What I think you want is:

StrictConcurrency
DisableOutwardActorInference
GlobalActorIsolatedTypesUsability
InferSendableFromCaptures

@mattmassicotte The problem is less that it is incorrectly annotated, but that it is not annotated at all, and Swift 5 will sometimes eagerly infer @MainActor annotations incorrectly - such as when calling a function that takes an unannotated closure from a function that is @MainActor. In this case, Swift 5 will treat the closure as if it were @MainActor, and allow you to call correctly-annotated @MainActor functions in a Swift 6 module, causing a crash.
I think we have all of those except GlobalActorIsolatedTypesUsability, which I had not heard about. I did notice that Swift 5 mode was less good at inferring things than Swift 6 mode, so rolling back from 6 to 5 + flags introduced new warnings, could that flag affect that?
Also, since you seem to know this stuff: Everywhere seems to document StrictConcurrency as being .enableExperimentalFeature("StrictConcurrency") in Package.swift (rather than .enableUpcomingFeature). Is this correct, or something that has changed?

@DagAgren you are right, I wasn't being precise enough. I use "incorrect" and "missing" interchangeably sometimes and I should not. You can read more about the phenomenon here: https://www.swift.org/migration/documentation/swift-6-concurrency-migration-guide/incrementaladoption#Unmarked-Sendable-Closures
All of the possible flags that apply to Swift 5 are documented here: https://www.swift.org/migration/documentation/swift-6-concurrency-migration-guide/sourcecompatibility
But the only ones that will have a material impact on concurrency-related warnings when in Swift 5 mode are the ones I included above. The others could still produce warnings/errors/problems though. So turning them all on is the way to get closest to the 6 language mode. Again, this really depends on what you want the output to represent.
The difference between enableUpcomingFeature and enableExperimentalFeature is always confusing and poorly documented. But, you can use .enableExperimentalFeature("StrictConcurrency") for both a Swift 5 and Swift 6 compiler.

Do enableUpcomingFeature and enableExperimentalFeature use the same namespace or different ones?

I'm not sure, I'm afraid.

This is now live with builder 4.58.0 and the following flags:
    static let defaultSwift6Flags = [
        // https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/issues/3443#issuecomment-2485604275
        "StrictConcurrency",  // implies GlobalConcurrency, IsolatedDefaultValues, RegionBasedIsolation
        "DisableOutwardActorInference",
        "GlobalActorIsolatedTypesUsability",
        "InferSendableFromCaptures",
    ]

It'll impact individual builds immediately. The next full rebuild will happen with the release of Xcode 16.2 or on Nov 26, whichever comes sooner.
Thanks again for the help and input, @mattmassicotte !

I flip-flopped a couple of times on re-opening this but instead opened a new issue here: https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/issues/3552


Strings for next release

@Dragondarn1993 @TheRaytheone @qjv @Linkaaaaa @dinckelman
Could you please update the respective translation files? They will be bundled in the next release! :)

I'm in. Pull request coming immediately


7 refactor aws cli script

-[ ] Refactor AWS CLI into bash script
-[ ] Provide eny var example for AWS
-[ ] Set our eny vars for AWS using gp eny


[Outlook] (Script Lab) Add workaround to run snippets in Outlook on the web

Documents the workaround to run Script Lab snippets in Outlook on the web.
Related issue: https://github.com/OfficeDev/script-lab/issues/1037

Do we have longer-term plans to fix Script Lab to account for this browser behavior change?

Long-term plans are still being discussed.


Tests: Integration tests using data from JPMaQS via DQ

Using the DataQuery interface to download JPMaQS data, run the functionality of the code with the data.
Tests must be generic enough to handle outliers and issue with the data.

Closed here ? https://github.com/macrosynergy/macrosynergy/blob/67fb077e2f7e1424d7c1324f58ba55608c4c437d/tests/integration/dataquery/test_dataquery.py#L29


typos in the tutorial

In steps 4 and 5 of the tutortial (https://codelabs.developers.google.com/codelabs/first-flutter-app-pt1/#5), the same name is sometimes referred to as _RandomWordState and sometimes as _RandomWordsState

_RandomWordState is mentioned once as above, while _RandomWordsState is mentioned at rest of places.

Hi @Omer1Yuval1 , I would like to fix this issue. Would appreciate if you could provide me with the follow-up steps.

This seems to be corrected with this merge https://github.com/flutter/website/pull/4289

I still see the typo as mentioned originally, unless I am looking at wrong place.
https://codelabs.developers.google.com/codelabs/first-flutter-app-pt1/#5

@TahaTesser I cross checked with another similar issue with the same codelab and found that the actual documents in the repo are updated and correct. I believe the website needs a poll scm trigger.

@Aman9026
That's true, please open an issue in flutter/website to update codelab for these changes

@Aman9026
That's true, please open an issue in flutter/website to update codelab for these changes

Done :smile:
https://github.com/flutter/website/issues/4530


Added PP radial grid cutoff as input paramter

Currently, in SIRIUS, there is a hard coded cutoff of 10 a.u. on the PP radial grids for integration. This is a protection against badly generated PPs that do not have a properly vanishing tail. The exact value is inherited from Q.E. (see PR #196 ).
Other codes may use different values for this. There are also codes, such as DFTK, which allow passing this value as an input parameter.
This PR introduces the cutoff as an input parameter. The default value is 10 a.u., which insures back compatibility. The test04 was modified to include a non-default grid cutoff.

cscs-ci run default

cscs-ci run


Failed to load resource:unsupported URL wkwebview-bridge://invoke

Logs are not getting recorded in wkwebview.
Here is the screenshot of error that I got in the safari remote debugger

Any help to fix this is appreciated !

I was overriding the decidePolicyForNavigationAction in my viewcontroller.
- (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy))decisionHandler
I stopped overriding and it worked.
@Naituw Please consider adding this in ReadMe


Still preview?

Is this still in preview as the (Preview) is not included anymore in PPAC

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 277a1fe4-c324-9dc6-b2f0-3f3d7efd83cb
Version Independent ID: 277a1fe4-c324-9dc6-b2f0-3f3d7efd83cb
Content: View license consumption for Power Apps and Power Automate (preview) - Power Platform
Content Source: power-platform/admin/view-license-consumption-issues.md
Service: power-platform
Sub-service: admin
GitHub Login: @amiyapatr-zz
Microsoft Alias: ampatra

Thanks for your comment, @petepuu. This issue has been assigned to the doc author for review.


does it work for RNN model

does it work for RNN+CNN model whose task is text classification

Is it CNN+RNN model? @ran337287
I found some resources that may be helpful for your reference. Once Grad-CAM applies, so does Score-CAM.
https://discuss.pytorch.org/t/cam-grad-cnn-lstm/88679
https://github.com/OverLordGoldDragon/see-rnn/issues/4

Not active. Closed.


Debug does not load snupkg

Hi,
I am using:
Visual Studio 2017 Version: 15.9.17
Nuget Version: 5.3.1
My UWP App project file got following settings in "Debug|AnyCPU" and "Debug|[Specific Platform]"
<DebugSymbols>true</DebugSymbols>
<EmbedAllSources>true</EmbedAllSources>
<DebugType>portable</DebugType>

I am using nuspec file to customize my requirement:
<package >
  <metadata>
    <id>DebugNuget2017</id>
    <version>1.0.2</version>
    <title>$title$</title>
    <authors>SUCHIL</authors>
    <owners>SUCHIL</owners>
    <description>This library will help you to learn Nuget Debugging</description>
    <releaseNotes>Checking something important</releaseNotes>
    <copyright>Copyright 2019</copyright>
    <tags>Learn,Nuget,Debugging</tags>
    <dependencies>
		<group targetFramework="uap10.0.16299">
			<dependency id="Microsoft.NETCore.UniversalWindowsPlatform" version="6.2.9" />
		</group>
    </dependencies>
  </metadata>
  <files>
	  <file src="bin\Debug\DebugNuget2017.dll" target="lib\uap10.0.16299\DebugNuget2017.dll" />
	  <file src="bin\Debug\DebugNuget2017.pdb" target="lib\uap10.0.16299\DebugNuget2017.pdb" />
	  <file src="bin\Debug\DebugNuget2017.pri" target="lib\uap10.0.16299\DebugNuget2017.pri" />
  </files>
</package>

Package command used is:
nuget pack DebugNuget2017.nuspec -Symbols -SymbolPackageFormat snupkg
I copied my nupkg and snupkg file to network path.
On another machine Visual Studio 2017 Debug settings in Options:
1. Symbols: Symbols cache directory set, Load all modules unless excluded is selected
2. General: Enable Just My Code is checked
3. General: Require source files to exactly match the original version

With same settings when I tried debugging nuget package on another machine, it use to download DebugNuget2017.pdb folder and show source code. But now it is not working and debug does not step into source code. Did I miss any point?

I even tried with Visual Studio 2019 and still could not debug nuget package. Am I missing any critical settings?

Logged in wrong location.


Completely Silence Slurm logs

Hello there,
I use dask_jobqueue.SLURMClusteris to simulate year-simulations. I always get a shitlaod of  logs in the slurm_logs folder.
Is there a handy way to completely silence these logs?
The parameter silence_logs is default on error in JobQueueCluster(SpecCluster).
Greetz
Jan

Hi @jwiemer112,
If you're talking about the logs of the worker emitted through Python logging module, you should look at https://docs.dask.org/en/latest/how-to/debug.html#logs.
silence_logs parameter is only affecting the Scheduler started into your Python process building the SlurmCluster object.
Hope this helps!

Thanks for your response. In my jobqueue.yaml is no logging section. But I will play around with logging a bit and try to figure it out. :)

Actually, as long as you're putting Yaml files in ~/.config/dask/, the name doesn't matter. You can put one jobqueue.yaml, and one distributed.yaml file, or everything in the first one. And in these config files, you put whatever Dask configuration you want to put.
See https://docs.dask.org/en/latest/configuration.html#yaml-files.

Thanks for your help and all the information.


Rule: max-imports

Curious what you would think about a max-imports rule. Usually if a module has, say, more than 10 imports or so, that is code smell and the module should be split up into smaller pieces.
Would you accept such a rule as a PR, or should such a rule live somewhere separately? Or does it already exist and I'm not aware? :)

Can be an interesting rule.
I'm guessing this would count both imports and requires. Would you count the number of modules, or functions imported. Like if you import the default and 2 named functions of a module, does that count as 1 or 3? I'd say its better to count it as 1.

I'd be up for this.
I agree with @jfmengels that it should count imported modules, not names. (though I could imagine having a parameter that limits names imported per-module, which would coerce you to import a namespace instead if you need more than X...)

name: import/max? (something longer is fine, but I want to avoid restating import right of the /)

Great! Yes agreed a shorter name probably makes more sense. I personally like import/max, I'll go with that for now. Will try and get a PR ready today or tomorrow, appreciate any help. Thanks!

I'd go for import/max-dependencies or import/max-imports or something, as max could be applied to many things (like max number of named imports for instance).

@jfmengels but wouldn't that be under the purview of this rule, though?

To me, this should only limit the number of modules/dependencies your file uses, not how you import it. If you want to use destructuring to use 10 lodash methods, that should still be counted as 1 dependency

PR #489 ready for review.


Create Invitation Entity

One Invitation has One ProjectUser (Sender).
One ProjectUser has Zero to Many Invitations (Invitations).
One Invitation has One User (Receiver).
One User has Zero to Many Invitations (Invitations).
An Invitation can be Active or Inactive. (IsActive = default -> false).
An Invitation can be Accepted, Awaiting or Declined. (State = default -> Awaiting).
An Invitation can have a Message (Message).

Requires #1


remove shared memory usage

Background

Why we need a shared memory  before?

it helps php generating unique transaction id, even php-fpm crash
the same as python

why removed it ?
I come up with a new idea, use collector-agent.
All agent connect collector-agent via a long-connection, so it can help generating a unique id.

done


Cpu usage doesn't work on ubuntu 21.10

Cpu usage doesn't work on ubuntu 21.10 (impish), show 0%

But if I run it via docker it works

And no IO R/W
ctop version 0.7.6, build 8f0c9f5 go1.16.5
Docker version 20.10.12, build e91ed57
Linux 5.13.0-28-generic #31-Ubuntu SMP Thu Jan 13 17:41:06 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Exactly the same on Debian Bullseye :-(

I have the same on
Manjaro Kernel 5.16.7
Docker version 20.10.12, build e91ed5707e
ctop version dev-build, build none go1.16.5
And also you can notice that memory usage is differ from docker stats command

And last thing if I try open Single View I ended with

Duplicate of #276. Fixed in #281 but not released yet by the maintainer.

this is resolved in the latest release; feel free to reopen if otherwise


FluidDataSet .print and .free ordering

I observed some behaviour today that went against my intuition so I'm curious to hear what @weefuzzy makes of it. I noticed that this prints the dataset:
(
fork{
	var point = Buffer.alloc(s,1);
	var ds = FluidDataSet(s);
	s.sync;
	10.do{
		arg i;
		point.set(0,i);
		ds.addPoint("point-%".format(i),point);
		s.sync;
	};
	ds.print;
};
)

but this does not
(
fork{
	var point = Buffer.alloc(s,1);
	var ds = FluidDataSet(s);
	s.sync;
	10.do{
		arg i;
		point.set(0,i);
		ds.addPoint("point-%".format(i),point);
		s.sync;
	};
	ds.print;
	ds.free;
};
)

So it seems what is happening is the DataSet is getting freed before it can print (in this case the .print to nothing isn't showing me an error though). In my heart what I want to happen is for the print and free to be lined up on the OSC cue one after the other so the .free can't be executed until after the print takes place. Why is this not the case?

Hmm. My guess would be that, server side free is able to do its shizzle on the command FIFO thread straight away, whereas dispatching the result of a message like print has to wait for an additional round of exchange between RT and NRT threads (if you remember the weird four-step thing that all NRT commands go through). Presumably if free were always deferred to this later stage, then it would remain correctly ordered

But actually, irrespective of that, you still want to wait until print has cleared the server before calling free, because it's still asynchronous and presumably(?) free entails making the object available for GC language side?
What do you get with
ds.print;
s.sync;
ds.free;
``

Yes, now that's clear enough to me: because free has language-side effects as well, and is getting called immediately, then the issue isn't to do with the OSC queue ordering so much as that the instance will have been garbage collected in the language by the time print calls back, and so its OSC handler is no longer active.
In short: use a sync, or a custom action.

the instance will have been garbage collected in the language by the time print calls back, and so its OSC handler is no longer active.

Ah yes, and this is also why there's no error.

If you wanted to experiment with this then it might be as simple as changing include/wrapper/NonRealtime.hpp line 333 to say stage4 rather than stage2.

So this suggestion is no longer applicable?


Enable Modern Drawer in react-navigation

Details

Upgrade to Modern drawer in react-navigation
Use react-freeze to prevent rendering issues caused by the upgrade (explained here)

Fixed Issues
$ https://github.com/Expensify/App/issues/11426
$ https://github.com/Expensify/App/issues/11479
Tests

Navigate from the LHN to a chat and back several times (one that is in view and not in view)
Via the Search page navigate to a chat (one that is in view and one not in view)
Verify the navigation happens normally.

[ ] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps (Web/Desktop)

Open the app
Verify that you can switch between chats using the LHN
Open the search page
Verify that you can switch chats using the chat switcher.

QA Steps (iOS/Android/mWeb)

Open the app
Open and close the same chat a few times. Verify that this happens quickly and you only see the "skeleton UI" the first time you open the chat (if at all). Be sure to use the swipe gesture as well as normal taps. While swiping, the other view that you're swiping in should be visible.
Switch between chats quickly. You should briefly see the "skeleton UI" as you switch between chats. Again, be sure to test the swiping gesture as well as tap-only.
Via the Search page navigate to a chat (one that is in view and one not in view)
Verify the navigation happens normally.

[ ] Verify that no errors appear in the JS console

Screenshots

Web
https://user-images.githubusercontent.com/32969087/195205103-76f01572-01ed-4473-aa4c-967213ae277d.mp4
Mobile Web - Chrome
https://user-images.githubusercontent.com/32969087/195210816-80616297-f715-4587-963d-80d4062fe9b9.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/32969087/195728657-d0b729e3-5af6-4f90-90aa-bd56365343e8.mp4
Desktop
https://user-images.githubusercontent.com/32969087/195207422-105d60cb-b238-43ff-9691-2b06e7171d84.mp4
iOS
https://user-images.githubusercontent.com/32969087/195728267-bf385b09-a1f4-44dd-8722-de3753258eee.mp4
Android
https://user-images.githubusercontent.com/32969087/195730277-f79fac49-216f-471f-afe9-c6ca1cb45b15.mp4

Making pretty good progress with this PR. Though hitting a bit of a snag with the Android changes.
Though the initial animation happens now with much less delay it seems like the ReportActionsView unmounts, but the views do not get dropped on the Android side.
To prove this, I tried wrapping the methods that setState() on withOnyx() component in a setTimeout() and saw that the loading animation I've hooked up then works fine - so there's a traffic jam of some kind.
Without setTimeout() things are responsive when tapping - but the previous view hangs bad
https://user-images.githubusercontent.com/32969087/193723787-6c518f7d-7a18-41b3-a6be-06f73b90d8aa.mp4
With the setTimeout() things work as intended. The previous view clears and the loading state is shown
https://user-images.githubusercontent.com/32969087/193724489-cf15af15-8148-40e6-a32e-7d72d43ca8ae.mp4
I'll keep looking into it tomorrow, but it seems like it would be useful to move these specific updates into the componentDidMount() of ReportActionsView

Hey @marcaaron, great progress!
I was assigned to look into upgrading to reanimated v3 in an effort toward enabling fabric.
I figured that your PR is essential for that upgrade, as it removes usage of REA v1 code (which v3 dropped support for).
I am not sure if one of your goals was to bump to REA v3 as well, however, I already created a PR for that, that is based on yours:
https://github.com/Expensify/App/pull/11567
The most important commit is this one where I removed legacy setup code:
https://github.com/Expensify/App/pull/11567/commits/05f07b5e6223c18fcc0fd2a9d5b4dba737687bcd
This could be very well also incorporated into your PR?

I am still stuck on the Android side for this one (and after testing iOS see that the problem also exists there).

The reportID changes and isTransitioning variable returns true

https://github.com/Expensify/App/blob/5084f318a9f82f2b024b1201ebf7b55a0381cf3a/src/pages/home/ReportScreen.js#L210

The ReportActionsView unmounts

https://github.com/Expensify/App/blob/5084f318a9f82f2b024b1201ebf7b55a0381cf3a/src/pages/home/ReportScreen.js#L254-L269

But still the previous view is hanging instead of the loading animation that I would expect

https://user-images.githubusercontent.com/32969087/194403346-8cb2565b-2e40-4d2d-ba4d-8b2609b9f0c6.mp4

@marcaaron if you want me to, I can have a look at it?

@hannojg yeah that would be great. I'm going to leave my latest notes on the linked issue here if you have any thoughts or ideas. I think maybe found a solution that works to solve the above native problem for now, but maybe we can improve it further.

Going to test this PR on all platforms today and then open for reviews.

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

The only thing I noticed during testing was in iOS when navigating to a new chat from searching there's a delay and I temporarily see the "Hmm... it's not here" view.

Oh weird. Lemme take a look at that and add a new test case. I definitely missed that in my manual testing. Thanks!

Ok, so looking into the issue @NikkiWines found and kind of confused about how this code is intended to work:
https://github.com/Expensify/App/blob/44c75aada4405bbff7b1c992e690b616c2c659d4/src/pages/home/ReportScreen.js#L212-L213
Unsure what situation we have were there is a report object but no report.reportID and why we are assuming the report is "not found" in that case. I tested this on main though and the behavior appears to be the same so I think it's not a blocker.
I was confused about this here -> https://github.com/Expensify/App/pull/10452/files#r983731454 as well and seems like it is getting resolved here.

Ah so fun stuff - white screen is resolved now and there is a way to fix it h/t to @vladamx. I don't know why it didn't work when I tried it before but it works now. The result with a fake header component is pretty nice too.
https://user-images.githubusercontent.com/32969087/195728197-06ac8b7a-1b3e-42f2-af35-b75afb49c6b9.mp4

Updated some things.

Re-tested, but only changed the videos for Android and iOS since there is more or less no visual difference for web, desktop, etc.

iOS
https://user-images.githubusercontent.com/47436092/195736246-b3a86eb1-8442-4035-8b3b-f0246dfa4e5b.MP4
iOS Chrome
https://user-images.githubusercontent.com/47436092/195736846-d6c07788-9d2c-4a99-be27-fc9951bec748.MP4
iOS Safari
https://user-images.githubusercontent.com/47436092/195737207-7caa39cf-7bdb-4649-a408-7792a24bf221.MP4
Android
Android Chrome
Desktop Chrome
https://user-images.githubusercontent.com/47436092/195737081-7a539a2b-c632-49e8-89fa-6fe4f3eeb32c.mov

🚀 Deployed to staging by @roryabraham in version: 1.2.15-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Yo! Coming from here, this looks like the most likely PR in the deploy checklist to cause this regression:

Type a draft message in the chat composer
Switch chats
Observe the draft message remains in the composer

Will leave the DB label off for now until we get a gut check.

There is another regression with TextInputs. I opened an issue and PR at react-navigation already, so we'd be in the position to use a patch until they merge the changes.
Description of regression here: https://expensify.slack.com/archives/C035J5C9FAP/p1665727193558759
Issue ticket: https://github.com/react-navigation/react-navigation/issues/10927

Also it seems to have introduced this regression, I'm guessing we''ll need to exclude the Input state from remaining when switching between reports.

Yeah, this seems to be confirmed now @trjExpensify

🚀 Deployed to production by @yuwenmemon in version: 1.2.15-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


fix(recipe-grouped-chip): update to use fixed width

PR Title
Update chip width to fixed size.
:hammer_and_wrench: Type Of Change

[X] Fix
[ ] Feature
[ ] Refactoring
[ ] Documentation

:book: Description
Update chip width to fixed size.
:bulb: Context
Update chip width to fixed size. This prevents the calltimer chip from pulsing with constant time updates.
:pencil: Checklist

[X] I have reviewed my changes
[ ] I have added tests
[ ] I have added all relevant documentation
[ ] I have validated components with a screen reader
[ ] I have validated components keyboard navigation
[ ] I have considered the performance impact of my change
[ ] I have checked that my change did not significantly increase bundle size
[ ] I am exporting any new components or constants in the index.js in the component directory
[ ] I am exporting any new components or constants in the index.js in the root

:crystal_ball: Next Steps
N/A
:camera: Screenshots / GIFs

closing since design reqs has changed. Will open a new PR


Fix for the preload attribute for breaking styling

A simple fix to add stylesheet in the rel attribute when preload is set
(Sorry if my IDE changed the entire file because of end of line and invisible tab spaces)

merging this change provided by @Chrissdroid, thank you


Target scale and pure orientation-only experience

Describe the bug
Target scale and pure orientation-only experience doesn't work as expected on build while fine in the editor. 'Orientation Only' target scale mode on build seems like any other one.
The result I want to achieve is like on Oculus GO, or in other words completely orientation-only.
https://docs.microsoft.com/en-us/windows/mixed-reality/coordinate-systems-in-unity
Applying the solution above causes a problem described on https://github.com/Microsoft/MixedRealityToolkit-Unity/issues/1376 . I can't see if it had been solved, but seems like it hadn't.
To reproduce
Steps to reproduce the behavior:

Set 'Target scale' in MRTK profile to 'Orientation Only'
See in editor that everything works as expected while only orientation is tracked and you can't move.
Build the app
See that you can still move around the scene if you walk IRL like if room scale is set.

Expected behavior
If you move IRL you would still stay straight in the scene like you're holding position.
Your setup

Unity Version 2019.1.9f1
MRTK Version v2.0 and v2.2

Target platform

Immersive HMD (Lenovo explorer) both UWP and standalone with Mixed reality for SteamVR

This issue is supposed to be fixed by now, but I am facing the same problem.
I am using Unity 2019.4.22f1, with MRTK <IP_ADDRESS>.
I set the Target experience scale set to  Orientation Only.
When I build the project (UWP) and deploy it to HoloLens 2, the position is still tracked, as for other experience scales.
Is there any fix to that?


Add support for CUDA 9.0 in jenkins

Codecov Report

Merging #401 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   96.72%   96.72%   +<.01%
==========================================
  Files         102      102
  Lines        7271     7272       +1
==========================================
+ Hits         7033     7034       +1
  Misses        238      238

Impacted Files
Coverage Δ

...es/Search/src/details/DTK_DetailsTreeTraversal.hpp
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d745720...2d80284. Read the comment docs.

Build 570 on Jenkins does not have CUDA 9


Add new straps/macros to define Caliptra Subsystem addressing

Caliptra should have new Read-only registers added to report addressing information from the Subsystem perspective. These will be used to facilitate AXI transactions via the AXI Manager/DMA block. The Read-only registers are populated by macros, defined at synthesis time. Macro definition is an integration responsibility.
Macros should be defined for:

Caliptra SHA Accelerator base address (or AXI Sub base address) from SoC interconnect map
Base address for Recovery Interface
OTP Fuse Controller secret registers base address
WRITE address for UDS Seed, for Manufacturing flow
Adding Passive vs Active Caliptra strap
DEBUG_INTENT_STRAP

UDS Seed is input to Caliptra via power on straps in other flows.

Also:
Strap to indicate base address of MCI.


Add FFmpeg

Add FFmpeg for homebridge-camera
Proposed Changes

(Describe the changes and rationale behind them)

Related Issues

(Github link to related issues or pull requests)

I'm sorry, this would increase the size of the container big time.
Secondly, v2.0.0 is almost done, maybe we can look for a better solution from that point on.


Venly

Is there any documentation for integrating Venly as a provider? I know there's this link below here, but it's not well documented.
https://demo.arkane.network/pages/web3modal

Hei, i'm lookin for a solution too, it's look like the documentation is not working with Venly, did you find out something?

With stable version 2.0.0 of Web3Modal now released, we are officially dropping support for version 1.x
Due to this this issue/pr was marked for closing. It is highly recommended to upgrade as 2.x will be receiving further updates that will enable functionality for some of our newer sdks like auth and push as well as support for WalletConnect v2 (See this post about WalletConnect v1 being deprecated https://medium.com/walletconnect/walletconnect-v1-0-sunset-notice-and-migration-schedule-8af9d3720d2e)
If you need to continue using Web3Modal 1.x and require this feature/fix implemented, we suggest adding it via forking V1 branch.


Update scalatest to 3.2.17

About this PR
📦 Updates org.scalatest:scalatest from 3.2.11 to 3.2.17
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (3.2.11).
You might want to review and update them manually.
build.sbt

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Codecov Report
Patch coverage has no change and project coverage change: +5.55% :tada:

Comparison is base (274a71f) 36.11% compared to head (796d67b) 41.66%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   36.11%   41.66%   +5.55%
==========================================
  Files           1        1
  Lines          36       36
  Branches        1        1
==========================================
+ Hits           13       15       +2
+ Misses         23       21       -2

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Superseded by #302.


merge from arlac77/template-esm-only,arlac77/template-github

package.json

chore(package): add ^17.0.7 remove ^17.0.6 (devDependencies.semantic-release)

:tada: This PR is included in version 9.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


L&S - Domino piece (tree) art assets

Moar weird "tree" shapes!
Reference: http://forum.movingblocks.net/attachments/chessworld2-png.1018/
Might be a smaller differently textured version of the Card Crags (#553). I don't think we really need the grooves / dents in the dominos ...
Edit: I think the textures from here could double as normal blocks so they can be used as roads in "Domino Dominion" - yet the upright ones might need custom thinner shapes? A 2-tall one block thick standing domino would seem really "fat"
Alternatively larger 2x8 standing dominos might work and double as roads.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/486355-l-s-domino-piece-tree-art-assets?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github).

Moved to https://github.com/Terasology/LightAndShadow/issues/18.


Adding more UI/entities to Order Details!

Hi community,
How can I add more entities to the UI, since I was able to see .TS files with right blue arrow, but if I add manually I'm seeing a C# at the top of sheet, is there any tool to create/generate all those files? I want to add a new table called 'Additional Cost' and populate with a UI below of Order Detail. But I can see about 12 o 13 files regarding to OrderDetail for example Row, Column, Service, Dialog, EndPoint, Form, cshtml, page, Repository. can you provide a tutorial to add more classes, please? and the relational model.

Please read the tutorial first.

can you provide URL please?

@amonragz  Do you know how to google ?

yup, thanks, can you help me with one issue? I was able to add more entities/tables but just wondering if you can help for once?

please read README page first, it is homepage of serenity github repository https://github.com/volkanceylan/Serenity
so after you read it, you will see something like this:
See Serenity Developer Guide at https://www.gitbook.com/book/volkanceylan/serenity-guide for documentation, and step by step tutorials.

Got It Thank you!


normalize paths when root is /

When devenv.root is "/", devenv.state becomes "//.devenv/state," and similar with devenv.dotfile.  Avoid this by normalizing using builtins.toPath to normalize the path (it strips extra slashes).
This is a fork of the python-rewrite branch, for better or worse.

TIL
nix-repl> builtins.toPath "//a"
"/a"


tests fail with windows installation only

After having added windows and mac-os build with PR #80 (requested by the partners), I noticed that all the builds pass except for the windows' ones.
In particular, two tests fail, both relative to test_reproduce_experiment, when the random seed passed to trials = task.generate_trials(ntrials=NTRIALS, random_seed=random_seed) is None. You can see the details of the failed actions here for python 3.11 and here for python 3.12.
I checked the error and it doesn't make sense to me, since when it appears on line 502, trials["random_seed"] should be an integer and the integers check should pass, and indeed it does on my mac (and on ubuntu GitHub image as well). Not having a windows OS myself I can't really dig into it and reproduce it locally.
In general, maintaining all three operative systems requires extensive maintenance (and indeed I've already agreed that in the future if we encounter too many issues we may drop some of the builds, also depending on the target audience), but for the current state of the package it shouldn't be a problem at all.

Issue closed as we have decided to implement similar functionality within the NeuroGym package.


Handle paginated responses better

Sometimes, drf-yasg can't figure out the appropriate serializer for a class. That's not a problem if we have a serializer on hand to pass to schema:
@schema(responses={200: MySerializer})
def get(...):
    """ My view """

For paginated views, this becomes a problem, because we don't have a paginated serializer to give schema.
I see two solutions to this:
1. Help drf-yasg figure out paginated serializers better
Why can't drf-yasg generate a correct paginated response schema? Are we missing a class variable on our views? Are we using DRF wrong?
2. Provide a manual paginate_serializer function as a fall-back
In the case where drf-yasg just can't figure out the response schema, it'd be great to be able to do something like:
@schema(responses={200: paginate_serializer(MySerializer, MyPaginationClass)})
def get(...):
    """ My paginated view """

This PR would provide paginate_serializer for edx-platform, but it'd be better to add this at the api-doc-tools level.


Implement saml provider

Autowiring function for the saml provider which has parameters name, description and url

Could you add the ticket number to the title TNUM: ...

@ychen-atlassian hey, could you have another look to unblock this PR?


Missing branches in the handshake state machine

Summary
This PR fixes two incorrect indices and one missing entry in the handshakes array in s2n_handshake_io.c. The fix has been verified against an RFC-based specification with SAW.
Background
The TLS handshake is implemented in tls/s2n_hadnshake_io.c using a state machine encoded with two arrays: state_machine and handshakes. The handshakes is a 2-dimensional array, indexed by the message_number and handshake_type fields of the s2n_handshake struct for the current connection (see the ACTIVE_MESSAGE macro). Each value in the array is used to index into the state_machine array that encodes expected message, protocol types and message direction. The handshakes array is sparse, encoding expected message sequences for every type of handshake expected by s2n. The components that are not initialized explicitly are initialized to zeroes. Hence, indexing with an invalid handshake_type or a message_number that is out of bounds will cause the end-point to expect CLIENT_HELLO be sent by the client repeatedly.
The state machine is driven by two functions:

s2n_advance_message that increases the message_number monotonically, progressing in the sequence of expected messages.

s2n_conn_set_handshake_type that can append flags to the handshake_type field and change the expected message sequence.

Bug
The bug has to do with the interaction of s2n_conn_set_handshake_type, the handshake_type field and the handshakes array. The array is not initialized for indices that are the values of the 'handshake_type' field present after calling s2n_conn_set_handshake_type.
Specifically, the missing indices are NEGOTIATED | FULL_HANDSHAKE | OCSP_STATUS, NEGOTIATED | FULL_HANDSHAKE | OCSP_STATUS | WITH_SESSION_TICKET and NEGOTIATED | FULL_HANDSHAKE | OCSP_STATUS | CLIENT_AUTH. The first two are likely due to a typo in the code that has the indices NEGOTIATED | OCSP_STATUS and NEGOTIATED | OCSP_STATUS | WITH_SESSION_TICKET (note the absense of the FULL_HANDSHAKE flag), which will never be produced by s2n_conn_set_handshake_type because setting of the OCSP_STATUS flag for handshake_type is always preceded by the setting of the FULL_HANDSHAKE flag.
Impact
This bug will likely prevent certain valid TLS handshakes from completing. Advancing through the message sequence will not change the expected message, and the state machine will expect the next message to be a CLIENT_HELLO as well, which is incompatible with the standards. In the case of a client, the client will keep sending CLIENT_HELLO. In the case of a server, the connection will likely time out since the server will keep waiting for the client to send a second CLIENT_HELLO.
CC: @colmmacc, @smagill, @atomb

Awesome find @achudnov ! I think if you update from the latest master, the travis build will go green.

Thanks, @raycoll. The build is good now.


Remove an unneeded object from DockExample prefab

The DocExample's Model_Bucky had a random CINEMA_4D_Editor object which wasn't necesary.
https://github.com/microsoft/MixedRealityToolkit-Unity/issues/8076

/azp run


Failing on training; trainer.train()

Hey,
I am trying to run a simple text classification on IPUs with PopTorch and Optimum. When I initilize the training by;
trainer.train()

I get the following error:
Traceback (most recent call last):
  File "IPUs/train.py", line 117, in <module>
    trainer.train()
  File "FOLDER/env/lib/python3.6/site-packages/optimum/graphcore/trainer.py", line 904, in train
    self._compile_model(model, next(iter(train_dataloader)), log=True)
  File "FOLDER/env/lib/python3.6/site-packages/optimum/graphcore/trainer.py", line 375, in _compile_model
    model.compile(**sample_batch)
  File "FOLDER/env/lib/python3.6/site-packages/poptorch/_poplar_executor.py", line 651, in compile
    self._compile(in_tensors)
  File "FOLDER(env/lib/python3.6/site-packages/poptorch/_impl.py", line 259, in wrapper
    return func(self, *args, **kwargs)
  File "FOLDER/env/lib/python3.6/site-packages/poptorch/_poplar_executor.py", line 569, in _compile
    self._executable = poptorch_core.compileWithTrace(*trace_args)
poptorch.poptorch_core.Error: In poptorch/python/poptorch.cpp:1371: 'std::out_of_range': basic_string::replace: __pos (which is 5) > this->size() (which is 0)
Error raised in:
  [0] Compiler::initSession
  [1] LowerToPopart::compile
  [2] compileWithTrace

Can someone please help me with this error?

Hi @rohullaa,
sorry for not seeing this earlier, optimum and transformers do not support python 3.6 anymore so the error might be related to that.
If you still encounter it on Python 3.8 I would need to know which model from Optimum you are trying to run when you get the failure.


Add an option to show empty cells.

Had a situation where display of the empty cells was needed.
A 'showEmptyCells' setting was added, which will show these empty cells. The default setting is false so that it is backward compatible with earlier versions.

Thanks @jerrylow. I just realised that I didn't update jquery.basictable.min.js.


Initial work on fixing unc paths and reports

This is caused by https://github.com/rust-lang/rust/issues/42869


upgrade to dart2

I think you should not commit your IntelliJ configuration files.

@yjbanov Please review.


susie_finemapper-No overlapping variants in the LD Index

Describe the bug
A clear and concise description of what the bug is.
"No overlapping variants in the LD Index" when running susie finemapper step
Observed behaviour
A clear and concise description of what happened.
when using study index and study locus file, returned no overlap error
Expected behaviour
A clear and concise description of what you expected to happen.
To Reproduce
Steps to reproduce the behaviour:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Additional context
Add any other context about the problem here.
I wonder if this is a bug,  this line seems only take the very first line from the study locus object: https://github.com/opentargets/gentropy/blob/397f1e99f1c12c48ae0c91887e10640115fa492e/src/gentropy/susie_finemapper.py#L97.
Is that the reason for the error, this step only takes in a row instead of a full spark df of study locus?

Hi @klaythompson37, thanks for showing an interest.

"No overlapping variants in the LD Index" when running susie finemapper step

This error will occur whenever there is no overlap between the summary statistics and the default gnomad LD index we use. Currently we're using gnomad 2.1.1, and we'll update this as better options become available. If this is unexpected, it could be that you're using an ancestry with poor coverage in gnomad?

Is that the reason for the error, this step only takes in a row instead of a full spark df of study locus?

The fine mapping pipeline is in active development, and one of the challenges we've had is extracting LD block matrices via hail across multiple loci in parallel. For now we are doing this by submitting each row of the StudyLocus dataframe as an individual batch job in GCP. In the future the code will also allow to fine map iteratively over a whole table, say if you have a small subset of loci you would like to run locally.


Adding Training to TorchSharp: First Step

The new version of TorchSharp with training requires the addition of a C API over libTorch. The C API is contained into an external repository called LibTorchSharp. I chose to have a separate repo because I expect eventually LibTorchSharp to go away because:

libtorch will directly provide the C API, or
LibTorchSharp will be merged into libtorch, or
LibTorchSharp will be automatically generated from PyTorch / libtorch.

Anyway, it will be great if we can move LibTorchSharp from my local repo to a xamarin repo and while we do this:

we do code review,
we make sure that it compiles over different platforms (for the moment I only tested it on Windows)
we add Azure Pipeline to automate compilation and the creation of nuget
we add the nuget to TorchSharp.

After all these, I think I can submit the PR adding training to TorchSharp.

Closing because the discussion is happening in #79.


Update Screwed-Purple.css

More tweaks, bug fixes and some fancy animations

  ->
Still not fully happy with that, but i don't see a pure css way of doing it better. (that isn't very messy)
depending on how difficult it would be, it would make styling for these easier if they had typical row -> colum structure, but it's not the end of the world.


Katakoda instruction text gets huge when window is large

When I maximize my window, the instruction text in katakoda gets huge.

@benhall the resolution for this example is 2542 × 1021 this be fixed?

This was an intentional design, however I've never been 100% sure about it.
I've removed it and I'll deploy the change tomorrow.


Easy increase of user-friendlyness

Hi,
I came across two things that might be of help when working with nutils.
(1) Add a button 'second last run' next to the existing 'latest overall'. Often I look at a sequence of experiments using a shell script and then a new computation starts right after the previous finishes. So when I click on 'latest run' I do not get the just finished  results which I am interested in.
(2) Add a funtionality to re-name tabs in a browser from within python. This has nothing to do with nutils, but could help a lot in managing multiple experiments.

Hi Manuel,
@1: how about running the sequence of experiments from your python script? This gives you access to not only the second-last, but all of the experiments in the series, which might also be useful for later reference. Something like this:
from nutils import *
main = lambda param=0: log.info(param)
sequence = lambda: [main(param) for param in range(3)]
cli.choose(main, sequence)
Hope this helps!


Code Quality: Use view models in Widgets

Summary
Stage1 and stage2. I had to do stage2 in this PR.
PR Checklist

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Related #14760
[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[x] Did you remove any strings from the en-us resource file?

[x] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Go to Home page
Check if widget will be shown if you enabled the widget in the Settings. Also, check if the setting is retained even if you open a new tab with Home page.
Right click on a card and check if context menu will be shown.
Click/middle-click on a card and check if the page will be navigated.

Screenshots
None

Code wise it looks good (hopefully @d2dyno1 can look it over as well since he did a lot of the original work on this) but I want to test it before merging. Which steps were taken to validate these changes?

Added steps to the body!

Can you confirm if disabling a widget will no longer construct that view model?

There seems to be a performance regression. In the main branch, opening a new tab to the home page loads it almost instantly whereas in this branch it seems to need to reload the items.

I'll look into that, thanks for the heads up.

There seems to be a performance regression. In the main branch, opening a new tab to the home page loads it almost instantly whereas in this branch it seems to need to reload the items.

This issue has been fixed by using DI for each widget view model, and this introduces some performance improvements because the app uses the same instance and event invokers.

Ready for Review!

@hishitetsu When you got some time, would you mind if I ask you to review this PR?

@hishitetsu When you got some time, would you mind if I ask you to review this PR?

No, I'll take a look when I have time.

I've found following issues:

In Tags widget, Open with and Send to in the right-click menu appear in the overflow.
In Tags widget, the right-click menu of folders has become that of files.
In Recent Files widget, the right-click menu can't open.

Thanks for the testing, I will fix this night.

In Tags widget, Open with and Send to in the right-click menu appear in the overflow.

Not for me. Also, Send To should be in the overflow so duplicated one which was in the primary flyout menu has been removed.

In Tags widget, the right-click menu of folders has become that of files.

What do you mean by "become that of files"?

In Recent Files widget, the right-click menu can't open.

Fixed, thanks!

Open with and send to should be in the main menu.

Not for me. Also, Send To should be in the overflow so duplicated one which was in the primary flyout menu has been removed.

I agree with Yair. We should keep Open with and Send to in the primary flyout and ones in the overflow should be removed.

What do you mean by "become that of files"?

The right-click menu of folders should be like this.

But in this PR, it is like this. This is the same menu as of files.

I agree upon "Open With" but "Send To" is a shell menu.
Flyout for folders and files shows it in the submenu actually.

I agree upon "Open With", but "Send To" is a shell menu.
Flyout for folders and files shows it in the submenu actually.

I'm just pointing out what is different from the current release version. I don't think we should change anything in the UI with this PR.

You are right, sorry, I will fix it anyways.

Open with and Send to still appear in the overflow. They should be removed from the overflow and their submenus should be available from the main menu.

All fixed.

The context menu for files in Tags widget has the placeholder for Send to, but the one for folders in Tags widget and the one in Recent files widget don't. There should be the placeholder to maintain the height of the context menu when Send to submenu is added.

Maybe it takes a while since loading shell items (async waitable but not waited) is executed after displaying finished (non-async)
It does for me...


Console main layout and settings page

This change is

looks like the failure might be only due to a (hopefully easy to fix) formatting issue?


swagger serve keep active connection to document

Problem statement
Swagger serve does not reload or refresh the UI when the underlying swagger.yaml changes
Swagger specification
generate spec
Environment
swagger version: v0.21.0
commit: 7c0fc3ee340f9d99d85573bc54a57e303a639692
go version go1.13.1 darwin/amd64
OS: OSX

no swagger server actually bakes the document in memory the file is no more using once it is loaded:
https://github.com/go-swagger/go-swagger/blob/04b61d1faf78cd4a031574ae0876ca0accd5e0f3/cmd/swagger/commands/serve.go#L40

So can this be a feature request?

load the swagger.yaml when/if changed


Incoherent naming for additional domainNames variable (code vs. documentation)

Helm-Chart and CRD documentations mentions a additionalDomainNames variable to provide further domainNames.
However, the CRD itself parses additionalDomains only.

The approach we have to take (for back-compat as well as rules around minor & patch releases) is:

For v0.5.1 update the documentation (#415)
For v0.6.0 add the new field, and auto-populate with the value from the old field. Add upgrade notes, deprecate the old field. (#416)
For v0.7.0 remove the old field from the CRD

@HoustonPutman thanks for taking over. I was the last week (unfortunately) on vacation and therefore could not take care of it.
Thank you!


Modify existing Tracing documentation

We should modify the existing Tracing documentation to:

Show Tracer creation independently
Show how the Tracer created in 1 above is used to configure both WebServer and GrpcServer.

Closed by #42


Make OrderFixture more realistic (include rounding keys)

If we try to view the order created with this fixture data in the admin panel, the admin panel breaks with a nasty Vue JS error (tries to read decimals on null).
This improves this and makes developers live easier when debugging tests.

1. Why is this change necessary?
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ not applicable] I have written tests and verified that they fail without my change
[ will do ] I have created a changelog file with all necessary information about my changes
[ not necessary ] I have written or adjusted the documentation according to my changes
[ not necessary ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-21866
Please use this issue to track the state of your pull request.

@fschmtt Thank you for the quick processing and fix-up :-) :blue_heart:


ci: use ghcr for ci

Fixes #
Description

Checklist

[ ] PR is rebased to/aimed at branch develop
[ ] PR follows Contributing Guide
[ ] Added tests (if necessary)
[ ] Extended README/Documentation (if necessary)
[ ] Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

Codecov Report

Merging #622 (d5dfac6) into develop (165f518) will increase coverage by 3.16%.
The diff coverage is 97.04%.

@@             Coverage Diff             @@
##           develop     #622      +/-   ##
===========================================
+ Coverage    93.52%   96.69%   +3.16%
===========================================
  Files           15       22       +7
  Lines          633     1179     +546
===========================================
+ Hits           592     1140     +548
+ Misses          41       39       -2

Impacted Files
Coverage Δ

connaisseur/__main__.py
0.00% <0.00%> (ø)

connaisseur/kube_api.py
87.50% <66.66%> (ø)

...naisseur/validators/notaryv2/notaryv2_validator.py
80.00% <80.00%> (ø)

connaisseur/flask_application.py
92.63% <92.63%> (ø)

connaisseur/validators/static/static_validator.py
93.75% <93.75%> (ø)

connaisseur/util.py
95.45% <95.45%> (-4.55%)
:arrow_down:

connaisseur/logging_wrapper.py
96.15% <96.15%> (ø)

connaisseur/config.py
97.29% <97.29%> (ø)

connaisseur/alert.py
97.97% <97.97%> (ø)

...naisseur/validators/notaryv1/notaryv1_validator.py
98.30% <98.30%> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329fa37...d5dfac6. Read the comment docs.


fix: add support for eth_call Historical Blocks

Description:
Adding support for eth_call historical blocks, also for receiving a blockHash in the format: { "blockHash": "" } or BlockNumber in the format: { "blockNumber": "0x0" }
Also allow 1 retry to mirror node, due to possible 504 or timeout when querying historical blocks
Related issue(s):
Fixes #2119
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eadca19) 75.15% compared to head (cc6c414) 75.15%.

:exclamation: Current head cc6c414 differs from pull request most recent head e0d73ad. Consider uploading reports for the commit e0d73ad to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2125   +/-   ##
=======================================
  Coverage   75.15%   75.15%
=======================================
  Files          13       13
  Lines         644      644
  Branches      118      118
=======================================
  Hits          484      484
  Misses        115      115
  Partials       45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Validate tutorial zip files for v0.8

This is related to PR https://github.com/api3dao/api3-docs/pull/899 as a follow-up. The tutorial zip files for v0.8 need to be verified.  @kolenic-martin They cannot be tested as the docker image  v0.8.0 is not available yet
I will work on this issue right after merging the fore-mentioned PR.

@kolenic-martin This is ready. I think the only test is to verify that the downloaded files have the proper directory structure changed by @dcroote . I downloaded them and they look good to me.

I confirmed the 3 zip files have the expected flat directory structure, moving to Done.

Hi @dcroote, I preiously had some issues (the zip files were not updated in the preview site) but that was probably an issue on my side.

@kolenic-martin - oh strange, perhaps it was an issue with the preview site? I confirmed on the live  docs.api3.org site under Airnode v0.8.

Ah, yes; this was probably an issue with the preview. The other issue (892)
seems to exhibit the same problem.
Dňa st 20. 7. 2022, 9:23 Derek Croote @.***> napísal(a):

@kolenic-martin https://github.com/kolenic-martin - oh strange, perhaps
it was an issue with the preview site? I confirmed on the live
docs.api3.org site under Airnode v0.8.
—
Reply to this email directly, view it on GitHub
https://github.com/api3dao/api3-docs/issues/900#issuecomment-1189922903,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGYB42D62WGWE3HPA2WLF3VU6SQRANCNFSM535HT7QA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Onstream event on Firefox with iOS as sender not fired

Hello Muaz,
I have a problem to solve following issue:
Receiver: Firefox latest
Sender: iOS via Cordova (App)
Problem: Video is not shown on receiver-site
Workaround: Triger a function via socket to request getusermedia on receiver end
The connection.onstream event is not fired, but why? Do you have a suggestion for this?
Thanks in advance!

Hi Patrick, are you using latest codes from github?

Hi Muaz,
thanks for your reply.
I tested the lastest version 30 seconds ago. It's not possible to show the iOS-Video in Firefox (Receiver) until a gUM-Request is triggered, so that even the receiver needs a camera :(


improve a little the readme

this plugin works fine but to make it working I had to study and debug because I've used the class CapacitorFirebaseDynamicLinks instead of FirebaseDynamicLinks with the result that events aren't registered and triggered. I think a couple of lines with an example like this can be enough:
import {FirebaseDynamicLinks} from '@pantrist/capacitor-firebase-dynamic-links';
// ...
FirebaseDynamicLinks.addListener('deepLinkOpen', (data: { url: string }) => {
    // ....
);

do you need a PR for this?

Thanks for your issue! I just added an example that clarifies the usage of the plugin


PHOENIX-6516 Phoenix-connectors uses hbase-testing-util but does not …

…list it as a dependency
Change-Id: I223171606540ef0d8b8d60e5de22f9173534fca5

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
27m 23s
master passed

+1 :green_heart:
compile
0m 35s
master passed

+1 :green_heart:
javadoc
0m 16s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
20m 15s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
11m  9s
phoenix5-hive in the patch passed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

61m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-59/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/59

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux a4b6b88500d3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 8eed3e7

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-59/1/testReport/

Max. process+thread count
1996 (vs. ulimit of 30000)

modules
C: phoenix-hive-base/phoenix5-hive U: phoenix-hive-base/phoenix5-hive

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-59/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


RUMM-3403: Write migration guide for SDK v2

What does this PR do?
This PR contains migration guide describing the necessary steps to move from SDK v1 to SDK v2.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1516 (2c4924a) into feature/sdkv2 (9c2d460) will increase coverage by 0.14%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           feature/sdkv2    #1516      +/-   ##
=================================================
+ Coverage          83.34%   83.49%   +0.14%
=================================================
  Files                426      426
  Lines              14618    14618
  Branches            2212     2212
=================================================
+ Hits               12183    12204      +21
+ Misses              1850     1831      -19
+ Partials             585      583       -2

see 18 files with indirect coverage changes

@DataDog/documentation This is the first doc for the upcoming v2 release of Android SDK which cover essential changes. More docs changes to come in the later PRs.

Thanks! I created https://datadoghq.atlassian.net/browse/DOCS-5810 to get a writer assigned to review it. Is this intended only for the SDK github repo, or do you (or the PM) want it also published to docs.datadoghq.com?

@kayayarai We would like to keep it in the repository until the GA, and then probably have it published on the website.


Don’t highlight underlined source with mark color

This should make it easier to implement grouped labels in the future (see #100), as we won’t have to deal with overlapping colours in the source - only overlapping underlines!

Sure!
Before:

After:

A more involved example:
Before:

After:

Hmm, I don't have a strong preference either way. I do think the case looks better without highlighting though. If this makes #100 easier I say go for it :)

Yeah, I could always make it so that the primary highlight takes precedence, but yeah, I'd rather just simplify the code more \in an attempt to make my life easier 😅


Design change if possible

@Sanster Hi there...Hoping everything is going well.
It has been awhile since I checked the repo for updates. I have noticed that after dragging and dropping to canvas and after I save the photo,I realized the button function is changed to upload new,which opens explorer to load a new photo from a location on the pc which is fine but this took away the previous functionality which was cleaning the canvas and return to welcome screen,we can drag and drop a new photo to inpaint.Now the only way to drag and drop is when the gui is first launched.
Is it possible for you to revert changes back to the original design,or maybe you can add the old button back next to "upload new" if you want.That was a good functionality.

Also thanks for the zitz model and updates,I forgot to say :)

Complete remove landing page: https://github.com/Sanster/lama-cleaner/releases/tag/0.22.0
https://user-images.githubusercontent.com/3998421/194713446-c22e8320-1f12-4910-814b-ae2b0f1a3ade.mov
https://user-images.githubusercontent.com/3998421/194713757-21b637a1-fc5d-408a-987b-337627a3f33b.mov


Mobile menu label: Show all categories - Not really fitting

Description
As the menu is actually used to also show landing pages that might not be related to products at all, calling the back button show all categories seems kind of wrong.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Image Restoration

Hello, congratulations on creating an amazing model. I was amazed by what you did. I need some guidance, can you please help me? I just want to use the Image Restoration feature. What should I do? I think I just need to do steps 6, 7, and 8. Is that correct?"

Yes, that is correct.


Fixes/orders placed by

Don't merge yet.

niiiiiiiiiiiiiice updated controller means we don't need a service to grab usernames!
would also like to add project name to alerts if possible... for giggles n such


Refactors repeated string literals

Proposed change
The code smell addressed is regarding code duplication. There was a string literal "scb:statistic:EnergyFlow" that was repeated 56 times in one file. If a developer wanted to make a change in the future, all of these occurrences would need to be changed manually. This increases development time and decreases the readability and overall maintainability of the code.
A dictionary was defined with relevant strings as elements. This makes it possible to reference the string constant inside the dictionary when used in code. Now you can change the string from the dictionary and have it applied everywhere it is being used.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] I have followed the perfect PR recommendations
[x] The code has been formatted using Ruff (ruff format homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Tested changes with (In Dev container):

Cmd + Shift + P – Tasks: Run Task – Install all test requirements
pytest tests/components/kostal_plenticore


factor other supported parameters and formats into iapp_parser

The iapp_parser util supports the common formats for iapps but does not support all of them, particularly those that are part of the iapp templates that F5 releases on downloads.f5.com

my bad i put the wrong issue number, reopening


feat: WIP port Logic.Function.Basic

So far I've done the merge with the existing file, using previously ported proofs where the mathport proof is broken.
But I haven't attempted to

fix the remaining broken proofs
rename statements as appropriate (with #aligns)
edit for style

The problem with congr has been fixed in Lean 4, but we can't move to nightly-2022-10-29 because of https://github.com/leanprover/lean4/issues/1791.

Depends on #522

bors merge


process.argv.slice(2) not good enough

need to check for existence of node exec options.

resolved, process.execArgv are separated from process.argv


I get the following message "command 'sftp.config' not found".

After the last update the extentions doesn't work, I get the following message "command 'sftp.config' not found".

Nevermind, I had to update vsCode.


Create RoyElt.yml

@RoyElt Hi Im sorry for my delay in responding to this! Ive been developing the new github template and didnt realize anyone had seen this. I am still finishing up some of the workflows on the new templates, and the final version of this template will be on a new repository that will displace this one. I will approve this so you get the commit, but please be noted now that we have a new automated workflow to generate a next gen version of this template, I will be archiving this repository. Sorry for the inconvenience while I am getting these new processes setup.


2.6.0 Release

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-654

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-654


Remove the restriction on supported types for Godot Android plugins

The first commit updates the Android plugin implementation to use JavaClassWrapper which was fixed in https://github.com/godotengine/godot/pull/96182, thus removing the limitation on supported types.
The second commit builds on that change to expose the Android runtime to developers by introducing a bundled AndroidRuntime plugin.
For example, the following logic can be used to check whether the device supports vibration:
var android_runtime = Engine.get_singleton("AndroidRuntime")
if android_runtime:
       print("Checking if the device supports vibration")
       var vibrator_service = android_runtime.getApplicationContext().getSystemService("vibrator")
       if vibrator_service:
               if vibrator_service.hasVibrator():
                       print("Vibration is supported on device!")
               else:
                       printerr("Vibration is not supported on device")
       else:
               printerr("Unable to retrieve the vibrator service")
else:
       printerr("Couldn't find AndroidRuntime singleton")

Those changes put together have significant impact for Godot developers on Android platforms as it removes the need for complex plugins in order to access Android libraries and SDKs.
So long as the library or SDK is written in Java or Kotlin, it only needs to be included in the build process via EditorExportPlugin#_get_android_libraries (...) or EditorExportPlugin#_get_android_dependencies(...) to be directly accessible to the script logic!

cc @reduz @akien-mga This PR may drastically simplify access to Android SDKs for Godot developers!

Thanks!


Comment Tree Sorting Documentation

I've created some basic documentation for configuring comment sorting. Refs #436

Thank you.


[flaky] networking.TestDialTLSWithBackoffSuccess

Failed run: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2500/unit-tests_pkg_main/1519305375889756160
=== RUN   TestDialTLSWithBackoffSuccess
2022/04/27 13:21:09 http: TLS handshake error from <IP_ADDRESS>:46468: EOF
2022/04/27 13:21:09 http: TLS handshake error from <IP_ADDRESS>:46472: EOF
2022/04/27 13:21:09 http: TLS handshake error from <IP_ADDRESS>:46470: EOF
    transports_test.go:167: Dial error = timed out dialing after 0.22s
2022/04/27 13:21:09 http: TLS handshake error from <IP_ADDRESS>:46474: write tcp <IP_ADDRESS>:42715-><IP_ADDRESS>:46474: use of closed network connection
--- FAIL: TestDialTLSWithBackoffSuccess (0.23s)

/assign @cardil

This is the problem of parallel tests that are choosing the same ports as free ones. Sometimes, most likely on contested servers, the OS is taking longer to allow running the port again.
We can:

prolong the back off period https://github.com/knative/pkg/blob/2d552be030f69a4b9f74e49b5ab57256590dae74/network/transports_test.go#L194-L195
pre-allocate free ports before the tests, and use them withing. This requires to integrate tests within a single group, and use t.Run to invoke the specific cases.

IDK, which is better?!?

Let's prolong the backoff to begin with.
Looking at the httptest.Server it uses <IP_ADDRESS>:0 but internal Serve call is on a goroutine so things could race.
Oddly this test fails consistently on my machine.
$ go test
--- FAIL: TestDialWithBackoffTimeout (0.00s)
    transports_test.go:134: Unexpected success dialing

You can sorta repro slower machines by limiting concurrency to a single OS thread - ie.  GOMAXPROCS=1

Looking at the fail you posted, it looks to me like the problem will not be solved by prolonging the backoff. The tests are executed in parallel, and clearly TestDialWithBackoffTimeout connected successfully to other test port, which succeeded.
$ go test
--- FAIL: TestDialWithBackoffTimeout (0.00s)
    transports_test.go:134: Unexpected success dialing

I think to make it robust, the only way is to put all those tests into a single Test, and synchronize subtest setup, and execution.

@dprotaso I think the https://github.com/knative/pkg/pull/2504 should fix this flakiness.
I've tested it on a local machine and my CI machines, and I couldn't reproduce the flake on my branch.