Calendar prototype

Basic functionality for 2 standalone widgets. Both still need tweaks.

@sjain28 Usually when we submit a PR that includes a UI change/addition we include an image of all the new screens so that people can view and comment without building themselves - could you add this? This might be useful: http://stackoverflow.com/questions/20983351/taking-screenshot-on-emulator-from-android-studio

General UI thoughts:

The text on the calendar widget could be bigger
The buttons on the calendar widget could be bigger
Instead of the grey with sharp edges I think we've been moving towards more of a blue/white aesthetic with bevelled edges
Applies to text backgrounds too
The calendar-toggle-button could be bigger (probably commcare blue too?)
The button with a "Red X" I think should be an ImageView (like the calendar) with a red X image instead

But again, all of these changes are probably good to bring to Biyeun/Jenny

General functional Thoughts:

When you click the calendar button and the calendar comes up, you have to hit the grey "X" in order to accept the date - this seems unintuitive, possibly should be a green check instead?
the calendar widget doesn't have an "X" button to give a null answer (maybe by design?)
the second prototype autocomplete (which is really cool btw) the suggestions are very small, will be hard to click for some users
you should probably disable keyboard suggestions when auto completing: http://stackoverflow.com/questions/4281838/how-to-disable-displaying-suggestions-on-the-soft-keyboard
Is it intentional or by design that autocomplete doesn't start until the second letter is typed?
If I type a bad an unallowed month (IE "Will) and then swipe forward, it reverts back to the initial suggested month - is that by design? Possible we should block that as an unallowed answer?

Good questions for @dimagi/product and kevin

Higher Level design feedback:
Might be worth thinking about a refactor whereby the CalendarWidget is no longer itself a QuestionWidget, but rather a separate UI/functional piece that can be optionally added to a widget (perhaps a Fragment: https://developer.android.com/reference/android/app/Fragment.html). then it could operate on the same core Date object as the GregorianDateWidget itself.
also curious: It seems like Prototype1 contains a GregorianDateWidget, P2 contains P1, and P3 contains P2. Did you consider using an inheritance pattern here?

yeah, screenshots would be great

Thoughts on ux:

"X" button should probably have a different style (check with Biyeun), same for the arrow buttons in the calendar
(Prototype 1) Calendar icon jumps around as the length of the day of week string changes
Month dropdown could use more spacing around the individual dropdown items (text is too close to the left edge, and the items are a little short overall, seems easy to tap the wrong one)
In calendar, grey out the days that aren't in the current month
In calendar, don't show weeks that are entirely in a different month (June 2016 calendar also shows July 3-9)
In calendar, add background color or some other visual differentiator to day of week headers
In calendar, highlight (delicately, maybe a lighter blue? biyeun probably has an opinion on color) today's date
When calendar is showing, don't show the day of week that's currently in line with the checkmark
(Prototype 2) Year text box is too small
(Prototype 2) Calendar icon is squashed, too wide, should be a circle
Validation: shouldn't silently blank out bad dates, should show error message
Calendar icon is distorted in landscape mode
(Prototype 1) Alignment of day of week text & calendar icon is weird in landscape mode (they get displayed towards the middle of the screen, but they should probably still be aligned with the left and right edges of the widget)
(Prototype 3) Would be nice if the << < > >> buttons didn't jump around as the length of the day of week text changes
Test on whatever the smallest likely android screen size is
(Prototype 3) In the calendar, go to Sept 2016, and the "2016" is split onto two lines
(Prototype 3) In the calendar, pick a Wednesday, and the word breaks over two lines

Ok had a thorough look-through this evening. @sjain28 great functionality and speedy execution! yes!
A couple notes:

The calendar widget should be a pop up. Otherwise, the navigation along the same plane as the form is confusing to the user. Think of it like pieces of paper and the form is a long scroll that moves left and right. The current calendar widget doesn't fit inside that mental model, therefore it makes more sense that it floats on top of the form in a dialog. @sjain28 would be a good exercise to skim through the google material design docs, which we base our UIs on. :)

Here are my suggested edits. I'll send the pngs + pdfs to the people involved in this discussion via email too.

realizing on the first prototype  we should probably approach the button layout like:

@sjain28 let's hold off on some of these higher fidelity design elements until you have implemented some of the feedback from @orangejenny and @wspride.  As we test out our prototypes, we may find that we have a winner and don't need to take the time up front with all of the visual elements if we don't have to.  @biyeun feel free to push back if this doesn't make sense - the images look fantastic!

@krsdimagi makes sense. I was also thinking that there might be use cases where each one of these prototypes could be more valid / useful than the other.

Cross requested with https://github.com/dimagi/javarosa/pull/302

These look and behave great Saumya, well done. Two small UI NITs:

The buttons on this are different sizes, and the calendar button on prototypes 2 and 3 aren't the CommCare teal color. Some more space between the two buttons would probably be good too.
Second, on the calendar pop up the green check mark is a bit small and hard to click - might be good to size up.

#Screenshots;

Looks really great Saumya! Nice work.
On Fri, Jun 17, 2016 at 5:32 PM, Saumya Jain<EMAIL_ADDRESS>wrote:

#Screenshots;
[image: screenshot_20160617-172702]
https://cloud.githubusercontent.com/assets/9773036/16165355/6072434e-34b1-11e6-924e-e623046d3e96.png
[image: screenshot_20160617-172709]
https://cloud.githubusercontent.com/assets/9773036/16165358/607748da-34b1-11e6-808b-418d50387439.png
[image: screenshot_20160617-172714]
https://cloud.githubusercontent.com/assets/9773036/16165356/60730f5e-34b1-11e6-9529-aee142b30381.png
[image: screenshot_20160617-172717]
https://cloud.githubusercontent.com/assets/9773036/16165357/6075ed96-34b1-11e6-8e07-0e1d4dd15f97.png
[image: screenshot_20160617-173013]
https://cloud.githubusercontent.com/assets/9773036/16165354/60713c9c-34b1-11e6-978e-94abd8416c6f.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dimagi/commcare-odk/pull/1289#issuecomment-226886651,
or mute the thread
https://github.com/notifications/unsubscribe/ACL9SNKSSnGFhhwLNhrbUGC3Iwr73n9gks5qMxJegaJpZM4IrmUD
.

Pending big questions:
-Have heard several different opinions about validation of user input, should make a point to bring this up during testing

Pending big questions:
-Validation choices should be brought up during testing
-Check for timezone bug #1144

Hey Saumya!  Here are the major takeaways/changes we can make at this point post-hallway testing.  We can definitely go to voice to clear up any confusion, but these were the most-cited issues that we can use to improve usability at this point:

The arrow functionality of the third prototype wasn’t well-received - we can drop this one and focus on the other two prototypes now.
For both prototypes: the X/clear functionality was not understood.  Because of this, we can drop the ability to clear.
Default value should always be today’s date (rather than incrementing based on the last entry option)
For text entry:

It was not very usable because when you click on an entry field it should select the entire field and            the cursor should start at the beginning in order to avoid any typing problems, instead of the current behavior that allows you to select the middle of an entry.
Additionally, there was a bug on my motorola where after changing the year it would cut off the last number for some reason - this could be some kind of device-specific sizing issue, I can show you if this doesn’t make sense.
When in landscape mode, there was a “done” option as well as a check mark option - would it be possible to have this in portrait mode?  Users were nervous about clicking the check mark, and didn’t know if this would lock in an incorrect date, potentially.

The calendar:

This was the most-appreciated feature.  Could we move it to the upper-righthand corner of each widget instead of under the date entry, as that is the expected location?
Testers wanted to be able to do text entry on the popout in the year and date, so they wouldn’t have to click the arrow buttons only - it might be nice to see if we can add this functionality.
It would be good to have an x next to the check mark on the popout, as only having a check mark made users nervous in the event that they just wanted to leave the calendar.
The calendar is not a fixed size - it would be good to fix the size so that when going from month-to-month it doesn’t seem to move around.

@krsdimagi Awesome feedback Kevin, thanks. Definitely want to agree with Saumya on the clear date functionality - the ability to submit an empty date is one of the most in demand changes and in my mind a major win from this refactor. If the "X" was unclear I think we should rethink the design rather than scrap the functionality altogether. Maybe @biyeun or @orangejenny would have ideas.
Sorry if I'm out of the loop on this. @sjain28 Are next steps clear or should we schedule a follow up meeting?

@krsdimagi It looks like Will isn't in the meeting invite for this afternoon. Could you add him?

@damagatchi please retest this

@damagatchi retest this please

Hey, with all the PNG image resources added in this PR and the audio recorder, do you have the original SVG versions? There is a way to perform auto-scaling by importing SVG files into Android Studio and using them as vector resources.
The current issue with just using one large PNG image resource is that on different screen dimensions Android will over consume memory resources. In the past this has cause devices to consistently crash. If you don't have the SVG versions (and Biyeun doesn't either) we can use a tool to create different versions for different screen densities.

💯 📅 👍 👍 awesome work! You did a great job fitting this new feature into our existing infrastructure, which is no easy feat!

🎉 🎆 🎉


Add logging middleware (411) draft

PR Checklist

[x] Have you followed the guidelines in CONTRIBUTING.md?
[ ] Have you got 100% test coverage on new code?
[ ] Have you updated the prose documentation?
[ ] Have you updated the reference documentation?

Hello,
This is a draft PR for #411 because I am unsure of what is required to satisfy the issue. It's actuall my my first PR on public repo and I've got a lot of questions.

I've chosen to configure logging at startup => is it a good idea ?
Logging configuration is in starlite.logging not in starlite.config => should we move it ?
I've chose to put Logging middleware in starlite.middlewares but I could have put it in starlite.logging => what would be the best ?
My test, although it cover my code at 100% is very small (but the also is the middleware) => do you have any idea of edge case that I should add ?
I log both incoming and outgoing event. Most web framework log only outgoing. What do you think should be the default ? Should I add specific configuration in LoggingConfig for activate incoming, outgoing, both ?
I log those informations : '{hostname}:{port} - {method} {path} {scheme}/{http_version} {result}' (outgoing example: testserver:8000 - GET /my/path HTTPS/1.1 200), do you want more or less informations ?
I've got the port from request.base_url.port, is it the good one (there also are ports in scope with server and client) ?

I need help on one failing test: test_request_body_logging_middleware in tests/middleware/test_middleware_handling.py. Initialize logging breaks capslog fixture. Anyone encouter this situation and knows how to make capslog working ?
Improvements:

In order to ease making custom LoggingMiddleware, I am thinking adding a get_logging_middleware() to LoggingConfig. Is it a good idea ? Should I do that in that PR or make another one ?

Thank you all for your help and recommandations.
Swann

I'll try to take a look at this tonight if this is still an issue.
We probably also need to add tests using the picologging logger as well.

@Swannbm please convert this PR to a draft (it should be on the right side pane)l.

Converted this PR to a draft

Here the minutes of my (quick) discussion with Goldziher:

Copy SessionMiddleware to fetch the middleware from Config instance
Do not init logging up front, let the user do the job
Extend LoggingConfig with properties only for the middleware
keep current file organization to avoid breaking change (LoggingConfig will stay in logging.init.py)

All this points are opened to discussion.

Here the minutes of my (quick) discussion with Goldziher:

Copy SessionMiddleware to fetch the middleware from Config instance
Do not init logging up front, let the user do the job
Extend LoggingConfig with properties only for the middleware
keep current file organization to avoid breaking change (LoggingConfig will stay in logging.init.py)

All this points are opened to discussion.

Rebase on development 😉, the LoggingConfig was moved.

I have made the change (and necessary revert). I havn't check test coverage yet, I will do it later, my free time is comming to an end for today. @Goldziher and @cofin (even @john-ingles ) could you have a code review please ?

any updates?


Is this still maintained?

I can see that there is MapBox Navigation SDK 2.0 but I haven't seen an update of this project for couple of months is someone still working on it?

I think it is a great question and is important to know for some projects that are in progress

This project is still used in production, just not in active development. Pull requests are welcome. We are trying to dedicate time to the active development of this library and will hopefully have some progress in the coming months.

Hi @joe307bad  who do i talk to if i wish to contribute?

Hey @haizenburg, thanks for reaching out. I am the point of contact for contributing to this repo. Please feel free to open a PR and I'd be happy to review and merge ☺

Hey @JorgeQuevedoC, thats a good question. I would say that any PR would probably benefit from also adding an example app to this project? That seems like the best way to test any changes. If someone were to put up a pull request I would be happy to make some time to also a minimal example project.

Hi @joe307bad I have done some changes but I don't know how to test them on my project before I create the PR. Any suggestion?

Hey @JorgeQuevedoC, thanks for taking the time to work on this, I really appreciate it.
I would say the best way to test is to add an /example directory to the root of this repo and use npx react-native init to add an example application. Once the example app is created, we can create a basic implementation of react-native-mapbox-navigation within this repo. I have seen other packages do this and I think its probably the best practice, what do you think think?
Also, I wouldn't worry about testing your changes before posting the PR. Feel free to post the PR without an example app and I would be happy to work with you to figure out the best way to test.

@joe307bad would you mind having a call to ask you a couple of thing about it?

Hey @JorgeQuevedoC, I would be more than happy to have a call but lets exhaust some options before we try to coordinate a phone call. Could you post your PR and allow me to take a look? Do you have a specific error you may be running into?

@joe307bad There are no errors because I don't know how to run the changes locally to see if it works

Thanks @JorgeQuevedoC, feel free to post a PR and we can communicate about any new code within that PR. I would be happy to coordinate a call when I can look at some code and formulate a strategy for testing the changes you would like to make 😄

@joe307bad

Can you give me access ?


No such file or directory: 'sensor_pretrain.pth.tar.r50'

I thought the pretrained weight would be on internet and download it by api. but error message says about no file sensor_pretrained.pth.tar.r50, is there any solution?
``
========= Preparing RouteScenario_3 (repetition 0) =========

Setting up the agent
build model...

Could not set up the required agent:

[Errno 2] No such file or directory: 'sensor_pretrain.pth.tar.r50'

Traceback (most recent call last):
File "leaderboard/leaderboard/leaderboard_evaluator.py", line 270, in _load_and_run_scenario
self.agent_instance = getattr(self.module_agent, agent_class_name)(args.agent_config)
File "/home/dohyun/LMDrive/leaderboard/leaderboard/autoagents/autonomous_agent.py", line 45, in init
self.setup(path_to_conf_file)
File "/home/dohyun/LMDrive/leaderboard/team_code/lmdriver_agent.py", line 205, in setup
model = model_cls(preception_model=self.config.preception_model,
File "/home/dohyun/LMDrive/LAVIS/lavis/models/drive_models/drive.py", line 86, in init
pretrain_weights = torch.load(preception_model_ckpt, map_location=torch.device('cpu'))['state_dict']
File "/home/dohyun/miniconda3/envs/lmdrive/lib/python3.8/site-packages/torch/serialization.py", line 791, in load
with _open_file_like(f, 'rb') as opened_file:
File "/home/dohyun/miniconda3/envs/lmdrive/lib/python3.8/site-packages/torch/serialization.py", line 271, in _open_file_like
return _open_file(name_or_buffer, mode)
File "/home/dohyun/miniconda3/envs/lmdrive/lib/python3.8/site-packages/torch/serialization.py", line 252, in init
super().init(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: 'sensor_pretrain.pth.tar.r50'

I had the same problem.Did you solve it?

Maybe you can download in https://huggingface.co/OpenDILabCommunity/LMDrive-vision-encoder-r50-v1.0/tree/main

Thank you so much!


Fix some links

I figure we may as well send them straight to /v4/introduction since they're getting sent there anyway, also fixes the broken Python reference link again

:+1: thanks!


Only update browser state on pjax success

When an ajax request fails and you return false in the pjax:error event, I don't think pushState() should still be executed. When this happens you end up with an incorrect URL in the address bar. In my case, on a failure I display an alert to the user (404 not found, etc). In this case the user ends up with an inconsistent state, they see different content than the URL should provide, and if they refresh the page they'd get a whole new set of content.

I did the failing tests manually and the behavior is what I'd expect after a failed request (both when returning true & false).

Please stop all patch
On Jan 8, 2017 00:10, "nickelfault"<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/defunkt/jquery-pjax/pull/660
Commit Summary

Only update browser state on pjax success

File Changes

M jquery.pjax.js
https://github.com/defunkt/jquery-pjax/pull/660/files#diff-0 (16)

Patch Links:

https://github.com/defunkt/jquery-pjax/pull/660.patch
https://github.com/defunkt/jquery-pjax/pull/660.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/defunkt/jquery-pjax/pull/660, or mute the thread
https://github.com/notifications/unsubscribe-auth/AInlWMnm_1wdOxArNsVNiGTIp0IvWSbwks5rP_9CgaJpZM4Ldhx5
.

I'm not sure what you mean by "please stop all patch"?


Kindle gets Series instead of Author

Current returned layout is sometimes (depends on book, but often) the # in Series, and then the 'by Author'.
Code assumes the first is the Author.  Probably better to look for the By, and use that as Author, and of course returning the correct Series and # in that series is also good metadata.

I think this has been now completed in release https://github.com/ahobsonsayers/abs-tract/releases/tag/v0.2.0. Can you let me know if this resolves your issue?
If it doesn't can you give me an example of the book you are still seeing it for?


KtLint failed to parse file

Hi, I get KtLint failed to parse file: when I run it on IdeaVim project. The file to blame: https://github.com/JetBrains/ideavim/blob/master/vim-engine/src/main/kotlin/com/maddyhome/idea/vim/api/VimSearchHelperBase.kt
Ktlint version: 0.48.2, ktlint gardle plugin: 11.3.1

Please specify following:

What is the content of your .editorconfig file?
What is the exact command which you executed?
What is the output?


QC change requests/questions

Hello!
Here's what I found during QC
ReadMe Page
Can we shorten the intro to two paragraphs (no lists or bullets)? Looking for just enough information from the customer situation to make them curious and explore the rest of the workshop.
Before HOL
Line 123 - When moved to MS MCW site, link will need to change, correct?
Line 127 - Will image change when we move this to MS?
Step-by-step HOL
Lines 262-268 - Need to indented to match the rest of the instructions please. (I have no business touching codes sections, EEK!)
Trainer Guide
Preferred solution - The diagram shows a logic app but doesn't mention it in the explanation. Is it obvious to technical people or should it be added to all the docs. with a preferred solution?
Line 456 - Need the "Title" code at the end of the alt-text.
Line 462 - Please update to the alt-text.  It just says An IoT hub and no "title" code at the end.
Student Guide
Perfect.
Trainer Presentation (PPT)
Missing slides after Design the solution slide 8.  Should have slides that tell students what they're supposed be answering (Duplicate the design section of student guide):

High-level architecture (1 question)
Environment modeling (4 questions)
Data ingestion and monitoring (4 questions)
Preferred solution - same question from Trainer guide....do we need to add about the Logic app?

Let me know if anything doesn't make sense.
Dawnmarie

Addressed and merged.


Make backend endpoint that gives temporary STS tokens for pushes to ECR

Following on from https://github.com/Garden-AI/garden/issues/347, make a new endpoint like GET /docker-push-token that dispenses STS tokens that grant temporary permission for end users to push to our ECR repo.
Assumptions:

This should point to the dev or prod ECR repo depending on what environment it's running in

I'm picking this up from Max now that finals week is hitting. He has a WIP branch that I'll work off of that I think is most of the way there: https://github.com/Garden-AI/garden-backend/tree/max/docker_auth


bug(material/chip): viewValue of any HTML element inside mat-chip-row is being appended to FormControl value on focus out (blur) event

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
14
Description
When there is any HTML element inside <mat-chip-row>, or even just the delete button is wrapped inside some <ng-container> (like with *ngIf, checking if the user has the privilege to delete), then the whole chip-row's viewValue contains this element's (button with <mat-icon>cancel</mat-icon> in this case) textContent.
So for example, value ["Apple"] becomes ["Apple cancel"] (because cancel is part of <mat-icon>'s viewValue).
<mat-chip-row *ngFor="let fruit of formControl.value">
  {{ fruit }}
  <ng-container *ngIf="true">
    <button matChipRemove>
      <mat-icon>cancel</mat-icon>
    </button>
  </ng-container>
</mat-chip-row>

Reproduction
StackBlitz link:
https://stackblitz.com/edit/ovb2sn-s41kjs?file=src%2Fapp%2Fchips-autocomplete-example.html,src%2Fapp%2Fchips-autocomplete-example.ts
Steps to reproduce:
Click on the text input and then focus it out.
This will run Material's blur/focusOut code and update the form control value with the chips' viewValue which becomes ["Apple cancel"].
More focus in/out clicks will keep appending  cancel to the form control's value.
Expected Behavior
Not appending HTML elements' viewValue to chip's form control value
Actual Behavior
HTML element's viewValue is being appended to chip's form control value
Environment

Angular: 15+
CDK/Material: 15+
Browser(s): Any browser
Operating System (e.g. Windows, macOS, Ubuntu): Any OS

Setting [value]="fruit" param for <mat-chip-row> fixes the issue (as described here: https://github.com/angular/components/issues/26358#issuecomment-1712203405).
The issue is caused by the textContent of the whole element being used as a default value for this param: https://github.com/angular/components/blob/16.2.x/src/material/chips/chip.ts#L201


More events to trigger changelog check

/azp run

We put a delay on the action that adds the changelog label to PRs when they are opened, which I think cut down the false errors we were seeing.
Should this be closed?

We put a delay on the action that adds the changelog label to PRs when they are opened, which I think cut down the false errors we were seeing.
Should this be closed?


Allow empty genesets?

There are 354 genesets with empty gene lists:
http://mygeneset.info/v1/query?q=count:0&facets=source
The counts by source are as follows:
go: 190
ctd: 156
reactome: 6
msigdb: 1
smpdb: 1
The front end seems to be handling this well, it simply displays their metadata, and shows no genes.
Two questions arise:

Is there any value in keeping empty genesets for curated sources? (My guess is probably not, in which case we can delete these.)
Should we allow users to create empty genesets? (Have to check if the frontend handles this)

Update: the frontend displays empty user genesets correctly, and I think it is fine to allow users to create them.
As for empty curated genesets, I think that for now it is better to leave them, since genes that could not be found are displayed under the not_found field. In general, it's better to display information rather than hide it.


cannot add some IPv6 addresses

Cannot add some IPv6 addresses as server ip or client ip.
Working examples: fabc:1234::/64, fabc:1234::2/128
Non-working examples: fabc:1234:5678::/64, fabc:1234:5678::2/128

Hi,
What do you mean by server IP and client IP?
Those examples didn't work because of /64 and /128 character I think. Try to remove it. Also, the error is returned from PDNS though

Should we turn this bug into a feature request instead of closing it?


[FEATURE]: SLES SP4 Support for CSI Unity XT driver

Describe the solution you'd like
Qualification and support for CSI Unity XT driver on SLES SP4.

Closing this as it is completed.


feat(robot-server): Executor for protocol session

Overview
This PR is a step towards running protocols via sessions API and not RPC. It is not achieving parity with RPC. It adds a few features and doesn't support others.
This PR fills out the ProtocolSession with command execution. Features supported:

Protocol sessions support session commands startRun, startSimulate, pause, resume, singleStep, and cancel
support python files can be imported using import {name}
support files can be opened using open({name})

What this PR does not address:

The schema for the protocol session detailed response. Specifically the command history.
Extra labware arg to Session.

Changelog
Added three classes:
ProtocolCommandExecutor - This class is derived from CommandExecutor. Its jobs:

To create a Worker and ProtocolRunner
to validate whether a command can be executed in the current state.
to delegate commands to a Worker
to listen for command from a ProtocolRunner

ProtocolRunner - This class wraps a opentrons.api.session.Session and Broker. It synchronously loads, simulates, and runs protocol. Listeners can be provided to monitor and control flow of the protocol (basically just creating a Broker and dispatching the COMMAND topic.)
Worker- This manages a ProtocolRunner in response to commands received via ProtocolCommandExecutor. An asyncio task runs in the background to process protocol jobs from commands (run, simulate, exit). A ProtocolRunner listener is used to control the flow of the protocol (pause, resume, cancel, singleStep). Calls to ProtocolRunner are run in a separate thread using loop.run_in_executor.
Review requests
Still a WIP. A lot of unit tests are needed. Plus robust error handling.
Risk assessment
Very little. The RunApp does not use this API. This feature will initially be released for "power" users as HTTP only.
closes #6192
closes #6194
closes #6195
closes #6196

As @sfoster1  pointed out, a big lacking in this PR as it is is that it doesn't support the ProtocolContext pause, resume, and delay features. I see two choices:

Use the Session/Hardware Controller pause/resume mechanism
Monkey patch ProtocolContext to hook into the Worker pause / resume.

What do we think?
Was I too quick in adding pause/resume to this PR?


ETA when Update Management will support Ubuntu 20.04 LTS

Hello,
Any ETA if and when Azure Update Management will also support Ubuntu 20.04 LTS ?
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cda4ec71-9492-2ac6-1030-dcd004826aa0
Version Independent ID: 7720d2be-0dd6-36c7-6eba-e1acee46d598
Content: Azure Automation Update Management overview
Content Source: articles/automation/update-management/overview.md
Service: automation
Sub-service: update-management
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@giovannifl Thanks for your comment! We will review and provide an update as appropriate.

@giovannifl Thanks for your comment! We will review and provide an update as appropriate.

@giovannifl - Support for Ubuntu 20.04 LTS is planned for this year, but I can't share an ETA for when it will be released at this time since things can slip.

@giovannifl - Support for Ubuntu 20.04 LTS is planned for this year, but I can't share an ETA for when it will be released at this time since things can slip.

I hope this answers your question satisfactorily, and because this isn't a doc-related issue I'm closing this GitHub issue. #please-close

I hope this answers your question satisfactorily, and because this isn't a doc-related issue I'm closing this GitHub issue. #please-close

@MGoedtel - do you have an update on the schedule? The release was a year ago now.

@RobinBeismann - Support for Ubuntu 20.04 has slipped to sometime later this quarter as a result of an Azure service dependency. Once it is supported, the table of supported versions will be updated. Thanks for checking in.

@MGoedtel - looks like the support is still not there.. do you have any update on this?

@RobinBeismann - Ubuntu 20.04 LTS is listed as supported by Update Management. It was updated back in July if I remember correctly.  Thanks.

@RobinBeismann - Ubuntu 20.04 LTS is listed as supported by Update Management. It was updated back in July if I remember correctly.  Thanks.

Thanks for the fast reply, however I just tried to deploy the update management agent on a Ubuntu 20.04 Azure VM today and it failed with an unsupported operating system error, it works fine with on premises oms agents on 20.04 through.

@RobinBeismann - Update Management is supported on Ubuntu 20.04 on Azure and non-Azure machines. Because you are encountering a supportability issue, I recommend you open a support case with Microsoft Support. Closing this GitHub issue as it is not related to an issue with the article.  #please-close


Increase the max line length for pep8speaks to 120 characters

Based on the example config from https://pep8speaks.com/.
Rationale: The default PEP8 line length is sometimes not enough for expressivity. See also https://medium.com/@drb/pep-8-beautiful-code-and-the-tyranny-of-guidelines-f96499f5ac17 .

We are in 2019, 120 chars I think would fit even in most cellphones... utACK https://github.com/dtr-org/unit-e/pull/1052/commits/dbed8b955f587db72092a4be33abfd596b1a1f91

ACK dbed8b9
Existing codebase does not really fit into 79 chars. So enforcing 79 chars will only make our life harder

Although this PR already has 4 approvals, I would like to ask not to commit it immediately after travis finishes. Because this topic is very hot and I believe people should have some time to express their concerns. So let's merge it in the evening or something

My concern is not relevant to this PR, but I missed a point we started using this bot. I personally do not like such things because they spam into the comments with no real benefit, because their reports are not something we will discuss, and it converts comments from discussion to developer log or alike. In my opinion, the pep8 checks should go to the Travis linter phase instead.

My concern is not relevant to this PR, but I missed a point we started using this bot. I personally do not like such things because they spam into the comments with no real benefit, because their reports are not something we will discuss, and it converts comments from discussion to developer log or alike. In my opinion, the pep8 checks should go to the Travis linter phase instead.

What in my view works best is a tool which actually comments on the code where the issues are. Something like https://houndci.com/. This is more like a normal review discussion than the one comment where pep8speaks collects all issues. If it is set up in a way that it only comments on the style issues we actually want to fix, then the bot takes the burden of nitpicking, which I think is a real benefit.

In my opinion, the pep8 checks should go to the Travis linter phase instead.

That is already the case, but failing the lint check doesn't currently stop the build. I've created issue #1054 for it.

I added pep8speaks which is an App which this pull request targets the configuration for it.
We have been thinking about this for some time already. The idea is that linting in travis might fail the build but could happen in parallel instead. Ideally you would get a report like "unit tests pass", "functional tests pass", "linting fails". This also eases review.
The app is not a mandatory check but adds one comment which is continuously updated and it only targets the touched lines, which is quite nice and would require a lot of effort in travis config otherwise.

Also see issue https://github.com/dtr-org/unit-e-project/issues/76


Remove jackson-databind and jackson-annotations dependencies now coming from core

jackson-databind and jackson-annotations were added as api dependencies in server of opensearch core.  Therfore, all plugins now have these as transitive dependencies.  Plugins that currently consume these dependencies directly will break while building unless the direct dependencies are removed.  If your plugin does not consume jackson-databind or jackson-annotations directly, feel free to close the related issue in your plugin's repository.
Example of solution in security plugin: https://github.com/opensearch-project/security/pull/2325

AD-Dashboard doesn't consume jackson directly. AD backend plugin will have make appropriate fixes.


Font PT-SANS problem is still there.

I recommend adding the PT-San in assets folder it's a free font.

@iharshit009 can you look into it.
I think you forgot to implement in some screen

@sahilit I have just now checked but it worked correctly in my local...

Fixed

Fixed


Amend typos

@ammen99 there is also one in protocol/wlr-gamma-control-unstable-v1.xml, should I add that too or leave it be?

I think it won't be a problem to add it to this PR.

@ammgws Can you also send a PR for the protocols repo? https://github.com/swaywm/wlr-protocols/blob/master/unstable/wlr-gamma-control-unstable-v1.xml#L113

@ammen99 Done

Thanks!


Blank Card Issue

Hello -
I am trying to send an adaptive card via webhook but the card is showing up blank with no data. Here is my current JSON:
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"version": "1.2",
"summary": "Daily Newsletter",
"body": [
{
"type": "Container",
"items": [
{
"type": "TextBlock",
"text": "{{}}",
"weight": "Bolder",
"size": "Medium"
},
{
"type": "Image",
"url": "{{}}",
"size": "auto"
},
{
"type": "Image",
"url": "{{}}",
"size": "small"
},
{
"type": "TextBlock",
"text": "{{}}",
"wrap": true
},
{
"type": "TextBlock",
"text": "Sent by: {{}}",
"wrap": true,
"size": "Small",
"weight": "Lighter"
}
]
}
],
"actions": [
{
"type": "Action.OpenUrl",
"title": "Assemble",
"url": "..."
}
]
}

having the same issue after the recent Microsoft update on IOS and Android.

@bennnglorfield, can you replicate the issue on https://adaptivecards.io/designer?


[v2024.07.01] Disable strace for arm32 jdk11

Unable to cherry-pick the revert #1079, so apply change to release branch via this PR

/merge

/approve


About Loss Calculation

Hello everyone,
I am wondering how does classification and regression losses calculated in loss_single function in anchor_head. I tracked anchors, matched ground truths and labels up to the loss_single function. Each variable that I mentioned before contains all levels of FPN, but when I checked those variables inside loss_single function they only contain the first level of the FPN? How does loss calculation mechanism work? I am trying to hook loss values of anchors that place in every level of FPN.
Notes:
I am working on the RetinaNet model with ResNet-50 backbone.
Thank you.
Baris.

https://github.com/open-mmlab/mmdetection/blob/master/mmdet/models/anchor_heads/anchor_head.py#L190


[dart2js] lib_2/html/js_interop_constructor_name/error2_test Crash (expected Pass)

There are new test failures on [dart2js] createFromStaticType for LegacyType.
The test
language_2/mixin/implicit_covariance_test RuntimeError (expected Pass)

is failing on configuration
dart2js-hostasserts-weak-linux-x64-chrome

org-dartlang-sdk:///sdk_nnbd/lib/_internal/js_runtime/lib/interceptors.dart@15497+1:
Internal Error: Cannot create subclass type mask for uninstantiated class j:class(JavaScriptObject).

This appears to be an 'impacts' inconsistency.
Prior to the change no calls were generated to getNativeInterceptor.
After the change, getInterceptor calls called getNativeInterceptor.

@joshualitt or @fishythefish - could one of you take a look?
It appears this failure is a new regression in weak mode.
Here is an example stack trace from the bots:
https://dart-ci.appspot.com/log/dart2js-nnbd-linux-x64-chrome/dart2js-hostasserts-weak-linux-x64-chrome/1164/lib_2/html/js_interop_constructor_name/error2_test

Please update if this is a blocker for the unfork.  Thanks!

Is @rakudrama already investigating? If not, I can try poking at it.

Go for it, thanks!

Any update?

Still investigating. I've been juggling multiple bugs this week and haven't gotten around to all of them yet.

@fishythefish one question we have: is this affecting only weak mode or also the legacy+unforked mode? If only the former is affected, we could consider this a non-blocker.

Unfortunately, this does affect legacy+unforked as well. I've narrowed down the root cause, working on a fix today.


Consistent use of access modifiers for fields

All other files except for this service have access modifiers for private fields.

Thansk @bartlannoeye ! PR merged.


one issue about code

Hello, sorry to bother you again. I think the above error may be due to the incorrect json file, which results in the data not being successfully imported and unable to run. I would like to ask if you have done any other operations, because the data processing is according to your instructions on github. The steps are to first perform dataset_conversation and nnUNet_plan_and_preprocess.py -t 82 --verify_dataset_integrity, but the generated json file seems to be wrong. Sorry for taking up your time. I look forward to your reply. Thank you very much.

Yes, there are only two parts in the data processing part: dataset_conversation.py and nnUNet_plan_and_preprocess.py. You can refer to the code of the nnunet project. This project is based on the open source project nnunet, and the default settings of the data processing part are the same as nnunet.


Allow PowerToys Run to use Win key combination (Win + Space)

Summary of the new feature/enhancement
Allow the PowerToys Run to be able to receive key combination with Windows key, preferably Win + Space.
For me, it feels more natural for Windows, because, well, we have Windows key. Also since PowerToys Fancy Zone already have that feature `Win + `` why not PowerToys Run as well?

Seems related to my bug report #3496

This is being tracked by #2325 which is the larger work item.


nodeos not working on mac osx

i'm unable to get nodeos working. I don't know what information I'm missing. It seems to freeze half way.
$nodeos

Thn it just ends there. What should I do? What am I doing wrong?

Can you shared your config.ini?


Add configuration param to C-0050 to optionally check cpu limit

Overview

Currently C-0050 checks if both cpu requests and cpu limits are set. Optionally a min/max value for both values can be configured.
Problem

Setting a cpu limit can have unwanted side effects, a good article on this topic is f.e. https://home.robusta.dev/blog/stop-using-cpu-limits. Enforcing the cpu requests, on the other hand, is a good idea.
The controls for checking resource requests and limits are C-0004, C-0009 and C-0050. But we cannot make a combination to check only memory requests, memory limits and cpu requests.
Adding an exception does not work as it can not differentiate between just missing the cpu limit or missing the cpu requests as well.
Solution

Add an additional configuration param to C-0050 to opt-out of the cpu limit check, so only cpu requests is checked.
Alternatives

Additional context

Would love to see this feature added as we are looking into same option for scans !!

if you change this, C-0050 is not longer C-0050
I'm ok if someone writes another control instead.


Plug-in crashing, RangeError: Invalid array length

Today OpenRGB container I use got updated and among new things this version have (03 dic build) adds support for an ssd I have (s40g), but it seems that the updated version or the addition of the new device is crashing the homebridge-openrgb plug-in.
Logs:
[12/3/2021, 11:40:00 PM] Homebridge v1.3.8 (HAP v0.9.7) (OpenRGB) is running on port 54244.

/homebridge/node_modules/homebridge-openrgb/node_modules/openrgb-sdk/src/device.js:79
                flagcheck = Array(8 - flagcheck.length).concat(flagcheck.split("")).reverse()
              ^
RangeError: Invalid array length
    at readModes (/homebridge/node_modules/homebridge-openrgb/node_modules/openrgb-sdk/src/device.js:79:15)
    at new Device (/homebridge/node_modules/homebridge-openrgb/node_modules/openrgb-sdk/src/device.js:21:46)
    at Client.getControllerData (/homebridge/node_modules/homebridge-openrgb/node_modules/openrgb-sdk/src/client.js:78:10)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at OpenRgbPlatform.rgbConnection (/homebridge/node_modules/homebridge-openrgb/src/platform.ts:229:33)
    at OpenRgbPlatform.discoverDevices (/homebridge/node_modules/homebridge-openrgb/src/platform.ts:102:7)
    at HomebridgeAPI.<anonymous> (/homebridge/node_modules/homebridge-openrgb/src/platform.ts:68:9)
[12/3/2021, 11:40:00 PM] [OpenRGB] Child bridge process ended
[12/3/2021, 11:40:00 PM] [OpenRGB] Process Ended. Code: 1, Signal: null`

Plugin Config:
{
    "name": "OpenRGB",
    "discoveryInterval": 600,
    "servers": [
        {
            "name": "ZF7-SERVER",
            "host": "localhost",
            "port": 6742
        }
    ],
    "platform": "OpenRgbPlatform",
    "_bridge": {
        "username": "0E:DA:BB:7C:19:5B",
        "port": 54244
    }
}

Environment:
Unraid 6.10rc2, OpenRGB docker container

Plugin Version: homebridge-openrgb v1.2.0
Homebridge Version: v1.3.8
Node.js Version: v16.13.1
NPM Version: v8.1.2
Operating System: Unraid 6.10rc2

From the stack trace you posted, I can see that the error is coming from the OpenRGB SDK, not his plugin, so I won't be able to fix it so that the SSD will work correctly with this plugin. The most I can do is stop it from crashing the plugin. I encourage you to open an issue on the OpenRGB SDK's repo about this error. I'll post a fix for the crash in a bit.

Thank you for your quick response! I will report it to OpenRGB, thank you for fixing the crash!

I think i have fixed the bug in my very recent version (openrgb-sdk@0.5.0-beta.2).  The old one is pretty broken, so if it is working it would be a huge improvement to update the package to the newest openrgb-sdk version.

Ok i have found another another bug with the same error message for openrgb version smaller than 0.7, i have fixed it in a an new beta version<EMAIL_ADDRESS>

Thanks for your work on the SDK, @Mola19!
@arturoovf Since I don't have the SSD, it would be great if you could test that. If everything looks good to you, I'll make a release of the plugin that uses the new SDK version, along with the better error handling. Here's how you can update your NAS's version of SDK:
In the terminal, navigate to the install directory of the plugin.
cd /homebridge/node_modules/homebridge-openrgb
Then, run this (using sudo if necessary) to update the version of the SDK that the plugin uses.
npm install<EMAIL_ADDRESS>Finally, restart the Homebridge service and test things out.

I followed instructions and everything is working fine as expected (no errors, s40g control works).
Thank you so much both of you for your work on this, that was a very quick response !

Thank you for testing. I am making a few test and if successful i will release 0.5.0. My suggestion for you would be to require 0.5 or higher, since i have found some fundamental flaws in my earlier implementation.

About how long until you plan to release 0.5.0? If it's pretty soon, I'll just hold off a bit on making a release so that I can go ahead and include 0.5.0 in it.

I hope 1 or 2 days, maybe a week.

Also can I see this issue as closed? I would like to close the one on my repo, but I will use this issue to tell you when I have pushed the new version.

I've posted a release with the latest SDK version, but I'm now having my own issues with Homebridge. It could be unrelated, but I'm going to leave this issue open until I have a chance to investigate.

@Mola19 I've had to rollback the SDK version. Something has changed between versions 0.4.3 and 0.5.0 with the connection logic that is causing it to crash the Homebridge process when attempting to connect to a device that is offline.
Previously, I could handle this by timing out the call to the connect method. Now, the call to connect for offline devices succeeds, and the call to getControllerCount crashes the process with the error: Error: getaddrinfo ENOTFOUND dallas-pc.local at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)
Here is the relevant code:
const timeout = async () => await new Promise((resolve, reject) => setTimeout(() => reject(), SERVER_CONNECTION_TIMEOUT));

try {
  await Promise.race([client.connect(), timeout()]);
} catch (err) {
  this.log.warn(`Unable to connect to OpenRGB SDK server at ${serverHost}:${serverPort}`);
  return 1;
}

let controllerCount = 0;

try {
  controllerCount = await client.getControllerCount(); // *** Crashes here ***
} catch (err) {
  this.log.warn(`Unable to enumerate RGB devices on OpenRGB SDK server at ${serverHost}:${serverPort}`);
}

Give some time. This seems to need a deeper rework of the error handling

Okay i think i have a fix. Could you copy client.js from my repo to your /node_modules/openrgb-sdk/src/ folder

That looks to be working correctly. Nice work. You can go ahead and release that patch, and I'll bump my plugin to use 0.5.1.

done

Great! @arturoovf if you could update the plugin to version 1.2.3 and confirm everything is working for you, I'll close out this issue.

Looks good!! Thank you both so much!

And thank you for taking the time to report the issue you had.


$rtl variable is right-to-left when false

Using the SCSS version, I made a test using the sample code provided in the README:

1

2

3

4

section {
  @include cf;
}

figure {
  @include block('1/2');
}

However, it seems that right-to-left mode is the default. The list of numbers displays as: "2, 1, 4, 3" by default. When $rtl is set to true, it displays the way I would expect it to if $rtl was false: "1, 2, 3, 4". Either I've overlooked something or there is a faulty $rtl conditional in the code.

You might be right. I'll check this out and push a fix in the next hour or so. Thanks for pointing this out!

Thanks!
I'm not sure if it's related, but it also seems that this logic:
Every element gets a float: left and margin-right: $gutter applied to them except the last one in the row.

is also reversed; the $gutter seems to be applied to only the last row rather than all except the last row.

Which version of Lost are you using? I'm testing 4.1.1 (the latest) on CodePen here and it seems to work fine: http://codepen.io/corysimmons/pen/wBbzJb

Hmm, I'm also using 4.1.1. I'm taking another look through my code to see if there's an issue elsewhere.

Super weird. :x:

Please update me when you find out what it is so I can make sure Lost isn't broken anywhere. =)

It seems the issue may be caused by a difference in compilation of the Lost SCSS by gulp-sass (I'm using the latest stable v1.3.3) compared to CodePen's compiler. I forked your CodePen and pasted in the gulp-sass compiled CSS so you can see the result I'm getting: http://codepen.io/teddybradford/pen/Ggajmw

Found the problem: gulp-sass is having trouble with the nth-child parameters.
figure:nth-child(n)
...
figure:nth-child(n+1)

vs.
figure:nth-child(2n)
...
figure:nth-child(2n + 1)

@teddybradford Thanks for your help! I've filed a bug with gulp sass. Hopefully they'll fix it soon.

In the meantime, might I suggest you try out the absolutely amazing and beautiful glory that is Stylus?

gulp-sass is just a wrapper for libsass, so my guess is that the bug is probably in libsass. Maybe CodePen uses the Ruby version of Sass for it's compilation.
I'll definitely play around with Lost using Stylus. I was just trying to see if I could merge this grid system into an existing SCSS code base I have.

I'll wait until the Gulp Sass people reply on the bug and then file it at LibSass if that's the case.
SassMeister is about to add Lost to their site so I'll be able to test it there (I'm not a Sass guy so I don't know how to use LibSass and all that confusing jazz).

@teddybradford This is fixed in LibSass 3.2.0 which should be released sooner than later. In the meantime enjoy Stylus or Sass w/o LibSass.

Awesome. Glad we figured it out!

Again, thanks for pointing this out and I hope you enjoy the rest of your experience with Lost. =)


mask image cannot be recorded.

Hi wysaid,
if i Apply mask image over Camera, it cannot be recorded with video or cannot be captured with image.
Can you help in that.
Thank you

It's designed so.
A simple feature for previewing in irregular shapes.

so, how can i record it with video?

write a filter

ok


Preload audio

Interesting and useful in the right situation, however, it would be good to preload the audio on page load rather than on trigger.  Haven't tried it, but may be possible to load a new player for each instance of the audio on the page?  Or Only do it if you have a preload="true" attribute on it?
Without preload, the hover and the click just lag too much to be useful.
Thanks for making this!

Thanks @steinhot , yeah preloading the sounds is my next step, I'll try to update it this weekend and hopefully I'll get it right.
Thanks for your comment and suggestion, glad to hear that you like it.

Check:
![image](https://cloud.githubusercontent.com/assets/1320709/12721820/a3867464-c8cf-11e5-8767-a34b42d77f73.png)

I'm sorry but I don't get the image, are you saying that the load time is
too long or you want to point out the 2 canceled assets with 0B ?
On Mon, Feb 1, 2016 at 4:36 PM, Oxicode<EMAIL_ADDRESS>wrote:

Check:

—
Reply to this email directly or view it on GitHub
https://github.com/MahdiF/loud-links/issues/2#issuecomment-178026232.

206 means that you are just checking e-tags where the assets are already cached locally on your machine.  Clear your cached assets and try again and the asset will not begin downloading until you do the hover.
To provide the best user experience, the assets should begin downloading the moment the page is rendered so that by the time the user gets to click on the button or does the hover, all it has to do is start playing.
Certainly if someone was using this library to “audition” a list of sounds you would only want to download them on demand, but for “accent” sounds, I would want them without lag.
Best,
Thom
From: Mahdi Al-Farra
Reply-To: MahdiF/loud-links
Date: Monday, February 1, 2016 at 7:47 AM
To: MahdiF/loud-links
Cc: Thom Steinhoff
Subject: Re: [loud-links] Preload audio (#2)
I'm sorry but I don't get the image, are you saying that the load time is
too long or you want to point out the 2 canceled assets with 0B ?
On Mon, Feb 1, 2016 at 4:36 PM, Oxicode <notifications<EMAIL_ADDRESS>wrote:

Check:

—
Reply to this email directly or view it on GitHub
https://github.com/MahdiF/loud-links/issues/2#issuecomment-178026232.

—
Reply to this email directly or view it on GitHubhttps://github.com/MahdiF/loud-links/issues/2#issuecomment-178035167.

Oh, thanks a lot for explaining this to me Thom.
I'm sorry, I'm still learning all these things, I'm new to Javascript and to all these things including Git.
I hope I get sometime this week to work on adding the option to preload sounds.
Thanks again Thom & Christian for the feedback, I appreciate it.

The first method off the top of my head to preload audio would be on initialization to create an  element for each sound, set the sources, add the preload attribute, then link all the events for that source to that audio element. That way the browser has a chance to preload all the audio files before triggered.
Some rough pseudo code:
var elements = {};
for (i = 0; i < hoverLength; i++) {
var src = getSource(hoverLinks[i]);
if ( ! elements[src] ) { // if the element for this src hasn't been created yet, let's create it now.
elements[src] = document.createElement('audio');
// add preload attribute & sources to new element...
}
trackHover(hoverLinks[i],elements[src]); // Set up hover events, but now it has a second parameter for the  element to trigger.
}


Labels removed when adding data

Fixed.  Issue was session data resets when launching view.  This was put in place due to the inital demo data that is loaded and when the user adds their own data, that data should be overwritten.  I've implemented a check ot see whether the session/network has been launched manually already, so the session should not be reset as new.

@roxy


Proposal: Package Structure

This is my initial proposal to kick of the discussion on npm packages for OpenTelemetry Node.

opentelemetry/types
A separate package with only TS interfaces and enums. Originates from https://github.com/open-telemetry/opentelemetry-node/issues/3

opentelemetry or opentelemetry/api or opentelemetry/core
This is the core npm package for OpenTelemetry. It contains the public API which is used by the various plugins. Also contains interfaces for traces, metrics, tags, etc.
Q: What do we want to name the new packages: opentelemetry or opentelemetry/api or opentelemetry/core?

opentelemetry/basic-tracer
With this users will have a full control over instrumentation and span creation. The base package doesn't load Continuation Local Storage (CLS) or any instrumentation plugin by default.

opentelemetry/context-propagation or opentelemetry/context-cls
Separate package for CLS (Continuation Local Storage). The primary objective of CLS is to implement a transparent context API, that is, we don't need to pass around a ctx variable everywhere in application code.
Q: What do we want to name the new packages: opentelemetry/context-propagation or opentelemetry/context-cls?

opentelemetry/cls-tracer or opentelemetry/automatic-tracer
Automatic tracer with CLS: opentelemetry/basic-tracer wrapped with opentelemetry/context-propagation.
Q: What do we want to name the new packages: opentelemetry/cls-tracer or opentelemetry/automatic-tracer?

opentelemetry/exporter-*
Contains standard trace and stats exporters. For instance, Jaeger, Zipkin, Stackdriver, Instana, Prometheus, oc-agent, z-pages etc.

opentelemetry/instrumentation-*
mongodb, redis, ioredis, express, hapi etc.

opentelemetry/transport-*
gRPC, HTTP/2/s, kafka etc.

opentelemetry/propagation-*
B3, BinaryFormat, TraceContext

opentelemetry/resource-util
It contains a collection of utilities for auto detecting monitored resource when exporting stats, based on the environment where the application is running.

New updates:
Changes as compared to OC:

api and sdk (basic-tracer and automatic-tracer) are separate packages
stats has been merged into metrics

Any thoughts about this?

opentelemetry/instrumentation-*
mongodb, redis, ioredis, express, hapi etc.

There is a discussion on how to call it: https://github.com/open-telemetry/opentelemetry-specification/issues/30

What's the motivation for having a separate opentelemetry/transport-* package group rather than opentelemetry/instrumentation-[transport] like opentelementry/instrumentation-http, etc.? Are transports interestingly different because of the need to propagate context and so are a different group?
I'm fine with it, just wanted to clarify!

Are transports interestingly different because of the need to propagate context and so are a different group?

Absolutely. To me, transport sounds more familiar when it comes to HTTP/2 and GRPC protocols. Having said that, I am fine with re-using opentelemetry/instrumentation-[transport] name.

opentelemetry or opentelemetry/api or opentelemetry/core

It's a bit unclear where the no-op implementations are stored. Should it be a different package or should it be part of this one?
My vote goes to core if it contains any behavior, or api if it's only interfaces.

opentelemetry/context-propagation or opentelemetry/context-cls

As discussed in https://github.com/opentracing/opentracing-javascript/issues/112#issuecomment-433982906, this package should be split into multiple different packages.
For example:

opentelemetry/context-base: The base implementation that doesn't propagate the context but handles things like binding.
opentelemetry/context-async-listener: Implementation based on @datadog/async-listener for Node <8. If our fixes for promise binding + memory leak + interoperability can be merged back into async-listener then that should be used instead.
opentelemetry/context-async-hooks: Implementation based on async_hooks for Node >=8.
opentelemetry/context-zones: Implementation based on Zones for the browser.

My vote goes to context-* for the various implementations.

opentelemetry/cls-tracer or opentelemetry/automatic-tracer

My vote definitely goes to automatic-tracer as cls would be an implementation detail (which would probably be incorrect too).

opentelemetry/propagation-*

Where would the base classes/interfaces go?

opentelemetry/instrumentation-* / opentelemetry/transport-*

As discussed above, separating these may require patching the same module multiple times.
In general, I think the structure looks good with a few changes. The most important part I think will be to ensure that each of them can be used on its own, and have many hooks to allow altering the behavior based on vendor needs. This is one area where both OpenCensus and OpenTracing were lacking, which I think is the main reason that prevented adoption.

Since a lot of the packages above could be used for the browser as well, should the name of this repo be changed to something like opentelemetry-js?

opentelemetry/context-propagation or opentelemetry/context-cls

Thinking about this a bit more, I think this could be externalized as an external project since context propagation is a generic cross-cutting concern. Maybe opencontext?
The benefits would be that users could use this to store anything, so they could use it as a replacement for continuation-local-storage and cls-hooked. The former is no longer supported with new versions of Node and the latter only supports specific versions and has some very difficult to fix issues. None of them support the browser.
I think providing a universal implementation could be beneficial outside the realm of OpenTelemetry.

I like the idea of calling this opentelemetry-js. It will require more complex CI checks since we would want to test out the browser packages in multiple browser and the Node packages on multiple Node versions, but it would enable us to keep everything in sync much better than separate repos.

opentelemetry or opentelemetry/api or opentelemetry/core

IMO this package will have api interfaces and no-op implementations. This might look like this,
opentelemetry/core
   |__ trace/
   |__ metrics/
      |__ stats/
   |__ tags/
   |__ resources/
   |__ utils/

I am in favor of core, but I think other languages(Java, Python and Go) are going with api.

Would you expect the core implementation to be Node-specific or would it be shareable with the browser (similar to the OpenTracing tracer)?
The benefit of making it cross-platform would be code sharing, but then we need separate hooks for the platform specific parts. Alternatively, as long as the api keeps a clean set of types that core implements, we could have a core-web that is optimized for the web platform but implements the same interfaces, and then core could use Node-specific utilities as well.
It seems like with OpenTracing, the API package had shared code but was pretty lean and allowed for plugging it into either Node or web needs (see e.g. https://github.com/elastic/apm-agent-nodejs and https://github.com/elastic/apm-agent-rum-js both of which integrate with OpenTracing)

I would try to keep as much code as possible shareable, and add more modules for platform specific code. Then some parent module can compose the correct modules together and register them with each other.
For example, say there is a web-tracer. It would use automatic-tracer and register context-zones on it as the context propagator.
I think this approach could allow more different combinations of modules, even unrelated to the platform. This is just a theory however, so I'd like to know if anyone has used this kind of approach for this use case specifically.

My coworker @crdgonzalezca is doing some experimental work to build a Zone-based tracer for the browser. You can check out some of his very early stage work here: https://github.com/census-instrumentation/opencensus-web/pull/87
Since we haven't built it yet, I'm not really sure what it will take to make Zone.js do what we want. I like the idea of sharing code between the browser and Node, but I think it will require some discipline to make sure Node-specific stuff doesn't creep in since likely the Node use case will be more fully built out sooner than the web-specific one.
I think we could mitigate this by setting up a web build of the intended-to-be-shared packages very early on with some simple integration test that exercises the webpack compile+build process and makes sure it can get spans correctly in the browser.

@crdgonzalezca is doing some experimental work to build a Zone-based tracer for the browser.

There was also some work done for context propagation specifically in https://github.com/opentracing/opentracing-javascript/pull/113/files#diff-e02a2e69cef841e50802298da59382a3

I think we could mitigate this by setting up a web build of the intended-to-be-shared packages very early on with some simple integration test that exercises the webpack compile+build process and makes sure it can get spans correctly in the browser.

I definitely agree with that. Otherwise, the more we wait, the more difficult it will be to support the browser because of things we won't have thought about. In general I find that tests are a lot more difficult to share between Node and the browser than the actual code, but I'm not sure that it's necessary either.

As mentioned in the SIG meeting, these are the new package names I would like to advocate.

opentelemetry/basic-tracer -> opentelemetry-basic-sdk
By default basic-sdk contains support for all the telemetry signals i.e. tracing, metrics, logs etc. It is possible to have separate packages for each telemetry signal, but currently not covered under default SDKs(basic-sdk and node-sdk) implementation.

opentelemetry/node-tracer -> opentelemetry-node-sdk
This package should help users/vendors to load specific plugin(s). Mostly applicable for advanced usres.

opentelemetry-node
This package should load all the provided plugins, we expect most of the applications to use this package.

The rest should stay as it is : opentelemetry-types, opentelemetry-core, opentelemetry-exporter-,  opentelemetry-plugin-.
/cc @OlivierAlbertini @vmarchaud  @rochdev @hekike @draffensperger @bg451 @markwolff @danielkhan

What about having opentelemetry-basic-sdk just re-export the exported symbols from opentelemetry/basic-tracer (and perhaps in the future opentelemetry/basic-metrics and opentelemetry/basic-logs, etc.)?
That way if someone wants to use e.g. just traces or just metrics as a power user they still can

I'm going to close this issue via #408. Do add a comment if you think this is incorrect.


c# serialisation bug

I don't have all the details, but when running a k8s createorupdate to update an object, I think I posted
...
metadata:
  generation: 2
...

and I got some error back from k8s that makes me think that the yaml->json c# incorrectly serialised that to "metadata": {"generation": "2"} (i.e. "2" as a string, not a number).
are you able to recreate this?

c# is serialising both ints and bools to strings when converting yaml to json - this blocks creating/updating a lot of k8s objects.  @asalkeld please investigate as a priority.

PR here https://msazure.visualstudio.com/One/_git/Compute-ARO-GenevaActions/pullrequest/2871614


feat: collect telemetry information for un-identified devices

With this PR, we detect at the end of an interview whether the device could be identified but we don't have a config file for it. In that case, we collect some basic information that helps us create said config file:

Whether the device supports Configuration CC V3+ - if yes, the detected config parameters are recorded
Whether the device supports AGI CC - if yes, the association group names are recorded
Whether the device supports Z-Wave+ and which version of the standard it implements

/cc @blhoward2

Currently not. But it does not collect any information that can be used to identify a user. Even the anonymous fingerprint we use for crash reporting gets removed.


[[REGARDER/TV]]Napoli-Inter 2024 In DIRETTA Streaming gratis TV Serie A 10 novembre 2024

Inter-Napoli In DIRETTA Gratis tv e in Inter-Napoli gratis.
Oggi, sabato 10 novembre, l'Allianz Stadium di Napoli sarà il teatro della sfida tra Inter e Napoli, valida per la 12esima giornata di campionato. La partita promette scintille, con i bianconeri reduci da un pareggio in Champions League contro il Lilla. Ma cosa fare se ti trovi all'estero e vuoi seguire il match in diretta su DAZN con telecronaca in italiano? Ecco una guida completa su come vedere Inter-Napoli in Inter-Napoli ovunque tu sia, grazie a NordVPN.
La partita tra Inter e Napoli si disputerà sabato 10 novembre alle ore 20:45 all'Allianz Stadium. Il derby sarà trasmesso in Inter-Napoli su DAZN, piattaforma che detiene i diritti di co-esclusiva dell'evento. Per accedere alla diretta è necessario avere un abbonamento DAZN: la partita fa parte del pacchetto Goal Pass, disponibile a 13,99 euro al mese. La telecronaca sarà affidata a Edoardo Testoni, con il commento tecnico di Massimo Ambrosini.
I due allenatori, Thiago Motta per la Inter e Vanoli per il Napoli, hanno dovuto fare i conti con diversi infortuni. Secondo i pronostici, la Inter parte favorita grazie al fattore campo e alla posizione in classifica, ma il derby della Mole è sempre imprevedibile e il Napoli potrebbe riservare qualche sorpresa.
Se sei un tifoso bianconero o granata e ti trovi all'estero durante il match, potresti avere difficoltà a seguire la diretta Inter-Napoli a causa delle limitazioni geografiche imposte dalle piattaforme. Tuttavia, esiste una soluzione semplice ed efficace: utilizzare una VPN come NordVPN per accedere a DAZN dall'estero e goderti la telecronaca in italiano. greddgjgfsfsasgdsd

dcvdgr

bnbn

💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live
💻Best NFL Streams for PC/MAC 1080p/720p 👇👇
🔴Full HD:🏈 https://tinyurl.com/NFL-Week-10-Live
..
📲Mobile friendly 1080p/720p 👇👇
🔴Mobile Free:🏈 https://tinyurl.com/NFL-Week-10-Live


Bullet points in Flash Update

Is your feature request related to a problem? Please describe.
When creating a Flash Update, I want to be able to use bullet points in the Situational Overview
Describe the solution you'd like
Add the bullet points icon in the edit-bar
Describe alternatives you've considered
I can use an asterisk or a dash, but this will not look that well with the alignment...
Additional context

This (bullet point) really should be possible.
On Admin page it is allowed, and could be allowed on frontend also.


chore(clippy) fix clippy warnings

Fix new clippy warnings reported by latest Rust nightly (verified locally with rustup update).

coverage: 90.849%. remained the same when pulling 606b7e6cb8da4d0bd54f76f8696afa088323904b on chore/fix-clippy-warnings into d67dc2ffdab74c71e531cad6909c6a67af2a54d5 on main.


Add ability for custom environment variables

-This is useful for build systems
-It's a list because sometimes there are multiple setups

:+1:


load saved model error

model = keras.models.load_model('snapshots_voc/resnet50_voc_best.h5', keras_retinanet.custom_objects)
error as follows:
#####################################
TypeError                                 Traceback (most recent call last)
 in ()
1
----> 2 model = keras.models.load_model('snapshots_voc/resnet50_voc_best.h5', keras_retinanet.custom_objects)
3
4 #model = keras_retinanet.models.ResNet50RetinaNet(image_input, num_classes=21, weights='imagenet')
5
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras/models.pyc in load_model(filepath, custom_objects, compile)
237             raise ValueError('No model found in config file.')
238         model_config = json.loads(model_config.decode('utf-8'))
--> 239         model = model_from_config(model_config, custom_objects=custom_objects)
240
241         # set weights
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras/models.pyc in model_from_config(config, custom_objects)
311                         'Maybe you meant to use '
312                         'Sequential.from_config(config)?')
--> 313     return layer_module.deserialize(config, custom_objects=custom_objects)
314
315
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras/layers/init.pyc in deserialize(config, custom_objects)
52                                     module_objects=globs,
53                                     custom_objects=custom_objects,
---> 54                                     printable_module_name='layer')
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras/utils/generic_utils.pyc in deserialize_keras_object(identifier, module_objects, custom_objects, printable_module_name)
137                 return cls.from_config(config['config'],
138                                        custom_objects=dict(list(_GLOBAL_CUSTOM_OBJECTS.items()) +
--> 139                                                            list(custom_objects.items())))
140             with CustomObjectScope(custom_objects):
141                 return cls.from_config(config['config'])
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras/engine/topology.pyc in from_config(cls, config, custom_objects)
2495                 if layer in unprocessed_nodes:
2496                     for node_data in unprocessed_nodes.pop(layer):
-> 2497                         process_node(layer, node_data)
2498
2499         name = config.get('name')
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras/engine/topology.pyc in process_node(layer, node_data)
2452             if input_tensors:
2453                 if len(input_tensors) == 1:
-> 2454                     layer(input_tensors[0], **kwargs)
2455                 else:
2456                     layer(input_tensors, **kwargs)
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras/engine/topology.pyc in call(self, inputs, **kwargs)
600
601             # Actually call the layer, collecting output(s), mask(s), and shape(s).
--> 602             output = self.call(inputs, **kwargs)
603             output_mask = self.compute_mask(inputs, previous_mask)
604
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras_retinanet-0.0.1-py2.7.egg/keras_retinanet/layers/_misc.pyc in call(self, inputs, **kwargs)
19
20         # generate proposals from bbox deltas and shifted anchors
---> 21         anchors = keras_retinanet.backend.anchors(base_size=self.anchor_size, ratios=self.anchor_ratios, scales=self.anchor_scales)
22         anchors = keras_retinanet.backend.shift(features_shape, self.anchor_stride, anchors)
23         anchors = keras.backend.expand_dims(anchors, axis=0)
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras_retinanet-0.0.1-py2.7.egg/keras_retinanet/backend/common.pyc in anchors(base_size, ratios, scales)
71     base_anchor = keras.backend.expand_dims(base_anchor, 0)
72
---> 73     ratio_anchors = _ratio_enum(base_anchor, ratios)
74     anchors = _scale_enum(ratio_anchors, scales)
75
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/keras_retinanet-0.0.1-py2.7.egg/keras_retinanet/backend/common.pyc in _ratio_enum(anchor, ratios)
98     w, h, x_ctr, y_ctr = _whctrs(anchor)
99     size = w * h
--> 100     size_ratios = size / ratios
101     ws = keras.backend.round(keras.backend.sqrt(size_ratios))
102     hs = keras.backend.round(ws * ratios)
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/tensorflow/python/ops/math_ops.pyc in binary_op_wrapper(x, y)
854       if not isinstance(y, sparse_tensor.SparseTensor):
855         try:
--> 856           y = ops.convert_to_tensor(y, dtype=x.dtype.base_dtype, name="y")
857         except TypeError:
858           # If the RHS is not a tensor, it might be a tensor aware object
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/ops.pyc in convert_to_tensor(value, dtype, name, preferred_dtype)
609       name=name,
610       preferred_dtype=preferred_dtype,
--> 611       as_ref=False)
612
613
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/ops.pyc in internal_convert_to_tensor(value, dtype, name, as_ref, preferred_dtype)
674
675         if ret is None:
--> 676           ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
677
678         if ret is NotImplemented:
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/constant_op.pyc in _constant_tensor_conversion_function(v, dtype, name, as_ref)
119                                          as_ref=False):
120   _ = as_ref
--> 121   return constant(v, dtype=dtype, name=name)
122
123
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/constant_op.pyc in constant(value, dtype, shape, name, verify_shape)
100   tensor_value = attr_value_pb2.AttrValue()
101   tensor_value.tensor.CopyFrom(
--> 102       tensor_util.make_tensor_proto(value, dtype=dtype, shape=shape, verify_shape=verify_shape))
103   dtype_value = attr_value_pb2.AttrValue(type=tensor_value.tensor.dtype)
104   const_tensor = g.create_op(
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/tensor_util.pyc in make_tensor_proto(values, dtype, shape, verify_shape)
374       nparray = np.empty(shape, dtype=np_dt)
375     else:
--> 376       _AssertCompatible(values, dtype)
377       nparray = np.array(values, dtype=np_dt)
378       # check to them.
/home/q/seven.wang/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/tensor_util.pyc in _AssertCompatible(values, dtype)
300     else:
301       raise TypeError("Expected %s, got %s of type '%s' instead." %
--> 302                       (dtype.name, repr(mismatch), type(mismatch).name))
303
304
TypeError: Expected float32, got {u'type': u'ndarray', u'value': [0.5, 1.0, 2.0]} of type 'dict' instead.
#####################################

Model loading is currently broken. I'll try to look into this soon. In the meantime you can load models by first creating an identical model (or loading the model definition from the <model>.h5 file) and then calling model.load_weights. That should work until this is fixed.

Reopening since this is an issue that still needs to be addressed.

model.load_weights () requires the file to be saved with model.save_weight(), right?
Tried load_weights from save_model file, got an error:"ValueError: Dimension 3 in both shapes must be equal, but are 180 and 324 for 'Assign_346' (op: 'Assign') with input shapes: [3,3,256,180], [3,3,256,324]."

Either save_weights or save should work (I usually just do save). From when is this model you're trying to load? Since this repository is under active development the architecture changes some times. It sounds like your saved model is from an older architecture.

It's from latest codes, the model was saved hours ago.

Could it then be that the number of classes changed in between saving and loading? Looks like one of your models has 5 classes whereas the other has 9 classes, does that make sense? Or depending on which layer is going wrong, it could also be 20 classes vs 36 classes.

You are right, forgot to change num_classes when constructed the model from saved file. Thanks --figured out this particular issue on my own, but much appreciation to your efforts on the project.

This issue is addressed in PR https://github.com/fizyr/keras-retinanet/pull/48.


Button class on login screen has the icon-spinner by default

It appears that the sign-in button has the icon-spinner class by default. This results in the spinner appearing, although you haven't clicked on the Sign in button.
<button type="submit" class="button-longrunning" tabindex="3" data-clicked-text="Signing in...">

     Sign in
</button>

Hi @sebworks,
The "sign in" button should look like this, so my guess is that your CSS has not properly loaded:

Please check in your browser's Developer Tools (under Network) that all CSS files are being served correctly.

@gasman, is the button font-size in login.css being intentionally overridden? I notice the Sign In button is significantly smaller.

Ah, good catch! Looks like the 'large button' style wasn't reinstated when the CSS was tweaked in cc7a936cd5f3c00bf3c808332d639739d066d992. Will work on a fix now...

I think you can just provide specificity like:
button.button


SSZ Union improvement proposal

The current Union type is not used in Phase0, and largely not yet implemented in client implementations (exception: lighthouse). In more dynamic contexts, it's could be very useful however.
The direct motivation for this is the Merge block format, in which we may see different transaction types that need to be encoded. To avoid overhead of lots of unused zero fields (SSZ does not truncate zeroes like RLP does), you would need different transaction type definitions. And how do you mix these different transactions in the same list, with a Union type.
One problem is that it takes 4 bytes per Union selector index (the switch between the type options), and we only really see a few type options in the common use case. This is a simple proposal to parametrize (at the type level, compile-time) the selector byte length. E.g. Union[4, [uint256, Bitvector, uint8]] would be backwards compatible with the already specified Union[uint256, Bitvector, uint8]. This would allow us to specify something like Union[TRANSACTION_SELECTOR_LENGTH, [LegacyTransaction, BetterTransaction, SuperTransaction, AbstractedTransaction]] (and yes, the selected index is part of the merkleization, no confusion between types in the merkle proof)
For the merge specifically, an alternative is to use opaque transactions (List[byte, max_size], a.k.a. Bytes[max_size] to encode an RLP transaction, instead of structured data). The pro is that the beacon-spec does not have to care about transaction types, the con is that we miss out on SSZ merkleization of transactions into the block-root, one of the very primary places that merkle-proofs would actually be very useful (you can construct a merkle proof about any transaction detail).
As a proof of concept, I implemented this new Union behavior in remerkleable, the SSZ library used in the python specification. See here. (Note for code reader: it represents the data as binary tree, and overlays it with views, it's focused on merkle proofs and data sharing more so than structural efficiency).

This makes sense to me. Opaque bytes or empty fields seem inferior to using a Union type and reducing the byte footprint is simple enough.
Any reason the type def has selector length prior to union types?
Union[selector_length, [types...]] rather than Union[[types...], selector_length]

Learning from the mistakes of the Contract ABI, I would suggest to consider some forward compatibility.
I am not sure if this is the case yet, but if the first byte is used as length/kind, a potential option is to block out the highest bit as an indicator for "future/extended version". That is only to allow unions where the highest bit not-set currently for the first byte (b[0] & 0x80 == 0).

@djrtwo I think I prefer Union[selector_length, [types...]] because of the symmetry of the typing with key, value (selcted_index, selected_value) and because the [types...] parameter is constrained by the first parameter (can't have more than 256 types with selector_length == 1). And with long lists of types it doesn't end up at the very end:
class Block(Container):
  transactions: Union[TRANSACTION_SELECTOR_SIZE, [
    BasicTransaction,
    SpecialTransaction,
    FoobarTransaction,
    AnotherTransaction
  ]]

For more similarity with List and Vector we could instead define it as N reserved options, and derive the selector byte length to cover the reserved count.
Another change we could make is to parametrize it with a map, like: Union[selector_size, {0: BasicTransaction, 0x42: SpecialTransaction}] if we want to use specific selector bytes.
@axic Good point, indicating something is reserved for extension purposes can be part of the Union spec. It's not a bitfield though, so reserving just the 0xff selector, or some small range, could be sufficient.

I dislike having to specify the selector size, it makes it a lot less elegant.
Given that it hasn't been used yet in any formal specification, can we simply reduce it to one byte now and assume that nobody will ever actually want a 4 byte selector in practice? I personally deem it very unlikely that anyone will run into it.
If we want to be super safe, we could simply compromise on two bytes.

@dankrad Good point, we can just do single-byte Union, nobody uses the current 4 byte version (or even implemented it). There's one exception I know of: Lighthouse uses it in their storage format, but that's outside of consensus. So let's simplify to a 1 byte selector, if we can confirm with Lighthouse? @paulhauner

I'm fine with dropping the selector to one byte. I would prefer one-byte instead of a variable-length selector. Although variable-length is more powerful, I think single-byte adheres better to the first S (simple) of SSZ. A union with more than 256 variants would be pretty gross and I don't think we should add complexity to the simple case (a few variants) to cover this.
On the lighthouse end, we only use Union for the Option Rust type (which is either None or Some(value)). If we wanted to avoid a DB migration (at the expense of some technical debt) we could introduce a LegacySszOption type which serializes in the old way. That's fairly painless for us.
Looping in @michaelsproul as well :)

Cries in Golang 😢. No preference from our end as we will not be able to use this regardless

@rauljordan protobuf and generated Go code support something like it (can't do Union[A, A, B] though, because multiple same types): https://developers.google.com/protocol-buffers/docs/reference/go-generated#oneof
Alternatively, you can emulate it with a struct of pointer fields, and just check only a single field is set. No interfaces or weak typing that way. And manageable if there's only a limited amount of fields anyway.

I would vote for 1 byte selector + @axic suggestion to reserve the highest bit for potential backward compatible extension (to protobuf varint for example).
I.e. Union selector would be 1 byte with the max value of 127


Connect image to plane events and expose them

Description
Currently, the image layer does not have a plane event. This prevents linking layers e4ffectively: currently, plane position and orientation is never synced between linked volumes. Note that this is the kind of stuff that would be better handled by #5060 (instead of needing ad hoc solutions like this).

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Agree with the need but I remember some discussion about connecting to lambdas being bad, it leaves objects lying around which aren't cleaned up - @Czaki might have more details

I just found out that I have a pending comment about exactly this. Yes, connecting lambda may keep the object alive longer than we want and lead to often crash in tests (maybe also some problem in usage).
Please create a dummy method for this instead of using labmda.

Right, I forgot about that. Does this look like what you had in mind @Czaki ?

@Czaki could you check if you like the current event connection?


Outdated cask: nulloy

Outdated cask: nulloy.
Info:

version: 0.8.
appcast url: https://github.com/nulloy/nulloy/releases.atom.

0.8.2

Updated in #18410.


Support push notification via EU server

Thanks for the helpful tool.
Please update to offer CLI option to specify EU API (api-eu.customer.io) when sending push notification.
(I was able to download project and manually change the endpoint to get it to work, and don't have time to fork and offer patch atm)

Hey @letam. Thank you for reaching out and sharing your feedback. We haven't considered this yet, but I'll take notes and share with the team internally so we can discuss and prioritize it. We have linked this with our internal ticket and will keep updating this issue with any progress we make on it.
Thanks for sharing. Please don't hesitate to ask any further questions or share more feedback you have. Have a great day.


Review existing internal technical documentation and identify documentation which should be external

What
Review documentation held with our team Google Drive and identify which should be publicly available.
Why
We believe there are docs which would be beneficial to users.
Who needs to know about this
Tech Writer, team (for review)
Done when

[x] Review team Google Drive
[ ] Remove any duplication
[ ] Agree list of documentation which we would like to host externally

The whole team has now fed back about Drive docs that contain publishable content.
This table shows:

which Drive docs contain useful content
the corresponding issue to make the content public

Drive doc
GitHub issue
Assignee(s)

Currency input
#1528: Publish currency input content on Design System
Content Designer

Acknowledging contributions
#1546: Update Community homepage with content about acknowledging contributors
Content Designer

Design System content patterns
#1547: Move patterns content-template from Drive to GitHub
Content Designer and Technical Writer

How the Design System team onboards new starters
#1579: Document our onboarding process
?

How to support our products AND Common redirects/responses
#1580: Publish content to help users understand our support processes
?