Revert PR 150

Reverts Autodesk-AutoCAD/AutoLispExt#150.
With https://github.com/Autodesk-AutoCAD/AutoLispExt/pull/150, in order to release v1.5.0, an incomplete work was temporarily reverted.
Since we have now published v1.5.0 to the market place, the reverted code can be added back.

@JD-Howard
should we revert this PR, if we don't have time to implement this option right now?


chore: Removing React import

Next.js automatically adds the React import when JSX is used indeed.

@orivelton thank you.


Report Resource Usage Statistics When a dbt Command Finishes

resolves #8342
Adds performance metrics to the CommandCompleted event, so that dbt's resource usage characteristics can be more easily monitored in production systems.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank Yeah. It seems that it is not implemented on Windows. I'm going to skip the event on Windows for now.


Add support for shared code between chapters

It's as easy as copying Swift files into the Sources folder, we would need to document how playgrounds on the mac need to reference these and not copy them.

This is really tricky, since Playgrounds on macOS will only copy files and not reference them from outside the playground. It may just be a matter of having to duplicate the code across chapters. Not ideal, but might be good enough. Since I haven't had a need to references files across chapters yet, I can't prioritize/figure out the best solution for this issue.

Maybe editing the playground workspace xml manually could be used?

I have a playground book I want to try building over the next week or so that's going to rely on some shared code stuff, so I'll hopefully get a better sense of that stuff.

Cool! I tried symlinks and macOS shortcuts without success.

See the discussion on https://github.com/ashfurrow/playgroundbook/pull/34
The .playgroundbook format has 3 different Source folders:

Root Source folder shared by every chapter
.playgroundchapter/Source folder (similar to .playground/Source)
.playgroundpage/Source folder (similar to .xcplaygroundpage/Source)

That said, I have not found a way to use the same file in multiple .playground.


tests/kernel/timer/starve fails to run on devices

Describe the bug
This test is marked build_only and is never run by any device. Trying to run it on a device results in an MPU fault.
To Reproduce
west build -b nrf52840dk_nrf52811
west flash
Expected behavior
Test runs
Impact
Bitrot, duplication? Maybe this can be folded into or removed into some other tests? timer_behaviour maybe?
 I cannot reproduce it with the recent main. For c4cc1621a5a2fc6d99287fe22aed324ba4e4e803 on nRF52840 DK (target nrf52840dk_nrf52811) I got the following output:
*** Booting Zephyr OS build v3.2.0-rc3-57-gc4cc1621a5a2  ***
Running TESTSUITE starve_fn
===================================================================
START - test_starve
Cycle clock runs at 32768 Hz
There are 1 cycles per tick (32768 Hz ticks)
[     0.399] 1: still running, would pass at 3600 s
[    60.070] 600: still running, would pass at 3600 s
[   120.058] 1202: still running, would pass at 3600 s
[   180.042] 1804: still running, would pass at 3600 s
[   240.024] 2406: still running, would pass at 3600 s
[   300.002] 3008: still running, would pass at 3600 s
[   360.088] 3611: still running, would pass at 3600 s
[   420.068] 4213: still running, would pass at 3600 s
[   480.065] 4815: still running, would pass at 3600 s
[   540.039] 5417: still running, would pass at 3600 s
[   600.010] 6019: still running, would pass at 3600 s
[   660.062] 6622: still running, would pass at 3600 s
[   720.011] 7224: still running, would pass at 3600 s
[   780.052] 7827: still running, would pass at 3600 s
[   840.096] 8430: still running, would pass at 3600 s
[   900.046] 9032: still running, would pass at 3600 s
[   960.080] 9635: still running, would pass at 3600 s
[  1020.027] 10237: still running, would pass at 3600 s
[  1080.063] 10840: still running, would pass at 3600 s
[  1140.027] 11442: still running, would pass at 3600 s
[  1200.087] 12045: still running, would pass at 3600 s
[  1260.035] 12647: still running, would pass at 3600 s
[  1320.097] 13250: still running, would pass at 3600 s
[  1380.060] 13852: still running, would pass at 3600 s
[  1440.024] 14454: still running, would pass at 3600 s
[  1500.072] 15057: still running, would pass at 3600 s
[  1560.020] 15659: still running, would pass at 3600 s
[  1620.064] 16262: still running, would pass at 3600 s
[  1680.003] 16864: still running, would pass at 3600 s
[  1740.040] 17467: still running, would pass at 3600 s
[  1800.090] 18070: still running, would pass at 3600 s
[  1860.007] 18672: still running, would pass at 3600 s
[  1920.031] 19275: still running, would pass at 3600 s
[  1980.054] 19878: still running, would pass at 3600 s
[  2040.095] 20481: still running, would pass at 3600 s
[  2100.030] 21083: still running, would pass at 3600 s
[  2160.071] 21686: still running, would pass at 3600 s
[  2220.006] 22288: still running, would pass at 3600 s
[  2280.053] 22891: still running, would pass at 3600 s
[  2340.097] 23494: still running, would pass at 3600 s
[  2400.048] 24096: still running, would pass at 3600 s
[  2460.090] 24699: still running, would pass at 3600 s
[  2520.021] 25301: still running, would pass at 3600 s
[  2580.043] 25904: still running, would pass at 3600 s
[  2640.082] 26507: still running, would pass at 3600 s
[  2700.033] 27109: still running, would pass at 3600 s
[  2760.075] 27712: still running, would pass at 3600 s
[  2820.020] 28314: still running, would pass at 3600 s
[  2880.058] 28917: still running, would pass at 3600 s
[  2940.016] 29519: still running, would pass at 3600 s
[  3000.083] 30122: still running, would pass at 3600 s
[  3060.035] 30724: still running, would pass at 3600 s
[  3120.085] 31327: still running, would pass at 3600 s
[  3180.017] 31929: still running, would pass at 3600 s
[  3240.053] 32532: still running, would pass at 3600 s
[  3300.004] 33134: still running, would pass at 3600 s
[  3360.052] 33737: still running, would pass at 3600 s
[  3420.096] 34340: still running, would pass at 3600 s
[  3480.049] 34942: still running, would pass at 3600 s
[  3540.096] 35545: still running, would pass at 3600 s
[  3600.059] 36147: still running, would pass at 3600 s
[  3601.060] 36156: Completed 36156 iters without failure
 PASS - test_starve in 3600.673 seconds
===================================================================
TESTSUITE starve_fn succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [starve_fn]: pass = 1, fail = 0, skip = 0, total = 1 duration = 3600.673 secons
 - PASS - [starve_fn.test_starve] duration = 3600.673 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

tried again with latest main commit and I do not have the issue, so something went wrong or I had a dirty tree.


feat: the header linter

This syntax linter checks that

the copyright statement is correctly formatted;
Mathlib.Tactic is not imported;
makes sure that the module docs are the first non-import command of each file.

The linter is off by default on projects downstream of mathlib, but it is on by default on mathlib.
This subsumes the corresponding text-based linters. These will be removed in a future PR.

[ ] depends on: #17660

For future reviewers: can you describe the difference of this linter to #15794? (Apart from the fact that this linter also check the copyright header and broad imports.)

!bench

bors merge


Handle empty author names (#21902)

Backport #21902
Although git does expect that author names should be of the form: NAME <EMAIL> some users have been able to create commits with: <EMAIL>
Fix #21900
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

make L-G-T-M work


autocomplete

In a basic form, this is supported in the input component via <datalist> now. A more elaborate live component might be added in the future.


Un-Accessibility

By removing your :focus outlines in your CSS, you have made your site unaccessible to anyone who needs to use a keyboard for navigation.
https://github.com/fac-14/Week3TakingAIME/blob/master/style.css#L99-L106

Tip: If you have problems with the way outlines look by browser default, they can also be styled with CSS 😉

Shit, I thought the outline was just a cosmetic feature and I didn't like the clashing colours. Who built the internet this way!?
We'll fix this.

Thanks for raising this.
Apparently, if an outline is really undesirable, there are alternative ways of improving accessibility:
http://www.outlinenone.com/

Fixed on Code-review -fixes branch

Fixed in #42


Refactor swagger onto embed

Codecov Report

Merging #21 (c63553c) into develop (ed0cc2d) will decrease coverage by 13.78%.
The diff coverage is 56.00%.

@@             Coverage Diff              @@
##           develop      #21       +/-   ##
============================================
- Coverage    69.76%   55.98%   -13.79%
============================================
  Files            4       10        +6
  Lines           43      209      +166
============================================
+ Hits            30      117       +87
- Misses          11       78       +67
- Partials         2       14       +12

Flag
Coverage Δ

unittests
55.98% <56.00%> (-13.79%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/swagger/helpers.go
47.82% <ø> (ø)

pkg/swagger/handlers.go
52.17% <52.17%> (ø)

pkg/grpc_proxy_server/server.go
67.21% <100.00%> (ø)

pkg/swagger/server.go
42.85% <100.00%> (ø)

pkg/grpc_server/server.go
43.33% <0.00%> (ø)

pkg/grpc_proxy_server/handlers.go
12.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0cc2d...c63553c. Read the comment docs.


deprecation message spammed when including ember-froala-editor in engines

DEPRECATION: ember-froala-editor: The default value for the 'plugins' option has change from 'true' to 'false'. Please update 'ember-froala-editor.plugins' in 'ember-cli-build.js' to indicate which plugin(s) you need; string = one plugin name, array = multiple plugin names, true = all plugins, false = no plugins.

This is spammed (even though set in ember-cli-build.js) when ember engines get access. I'm not sure if this means that there is a bug with showing the message where it should just not show at all in engines or if engines aren't getting the correctly configured package.

Interesting, I haven't used engines at this point so I'll have to investigate. Are you using an in-repo engine or "addon" engine?

in-repo engines.

Finally looking into this. Couple questions;

Is the ember-froala-editor dependancy located in /package.json or /lib/engine-name/package.json?
Is the ember-froala-editor config located in /ember-cli-build.js or /lib/engine-name/index.js?

it's in /package.json and then any engine that also uses it will have it in its package.json as well with version set to *, which basically just has ember link back to the applications version.
the config is only in the /ember-cli-build

This happens when ember-froalaeditoris in thedependencies` section of an addon as well.
Even with configuration in the consuming apps ember-cli-build.js the message still shows up.
This is probably because of https://github.com/froala/ember-froala-editor/blob/master/index.js#L57
many addons use a pattern like
https://github.com/FortAwesome/ember-fontawesome/blob/master/index.js#L158-L165
to get to the host app, I have no idea how correct this is, I've just been copying it.  There is also a private method called _findHost that I've seen used to do the same thing.

@jrjohnson yeah, I remember having to do some funny stuff like that before. I'm checking on Discord if that's the best solution or if there is something better. Thx for the point in the (probably) right direction.

Alright, I believe this should be fixed with https://github.com/froala/ember-froala-editor/commit/9ae40c65d4edfba4b943112cad81bd4f5ee921bb and https://github.com/froala/ember-froala-editor/commit/658946e5118fa51ed99fab9255e1326f3c457ec1. Anyone here able to test this from master?

@Panman8201 works

@robclancy great! Closing for now but can re-open if anyone continues to run into this issue. FYI, it will be in the next release, v2.8.6 (whenever Froala has their next release).

@Panman8201 any chance of a 2.8.5-1 release with this fix? In addition to the warning output this issue also means it's not possible to configure froala in an addon. It doesn't look like froala is on a fixed schedule and I'm worried about waiting a few more months for this fix.

I've been in contact with Froala and they have a release coming next week. However, I'll work on a +1 release today since several are waiting on this fix.

FYI, I tried to publish as 2.8.5+1 but NPM didn't like that. 2.8.5-1 would technically be a pre-release and fall lower than the current 2.8.5 in priority, so it wouldn't get installed. I need to determine what our best approach is here. I was considering +1, +2, +3... but it seems NPM won't like that. Release everything as -1, -2, -3.?. (sigh)

Damn! Sorry about that. If there is a release next week anyway then I can easily just be patient and run off of master for a bit. I was just concerned when I looked at the release history and saw some multi-month gaps. Sorry I wasted some of your time on this, thanks for taking a look.

 Here is what I have been using since this was patched. "ember-froala-editor": "froala/ember-froala-editor#658946e5118fa51ed99fab9255e1326f3c457ec1",

FYI, I've just publish v2.9.0


Issue:2108 - Adding files/tests to support PreServerShutdown - Take2

I closed the previous PR here:  https://github.com/go-swagger/go-swagger/pull/2109
I started with a clean branch.
Related to this issue: https://github.com/go-swagger/go-swagger/issues/2108
This feature should allow for consumers of go-swagger to add a PreServerShutdown hook to allow for completion of processing before the http(s) server is closed (stops accepting new connections).

I am not sure why codecov bot is complaining about this file:  generator/structs.go - I didn't make any changes there.

I should turn off this codecov stuff. it's confusing. And a lot of our tests don't even affect the coverage number

@casualjim  - Thanks a ton for the help and quick turnaround!


Reduce default NumberBox precision to 6 digits

Description
printf() defaults to 6 digits. 6 digits are sufficient for most
users under most circumstances, while simultaneously avoiding most
rounding errors for instance during double/float conversion.
Closes #3959
Motivation and Context
FLT_DECIMAL_DIG is 9. With 12 significantly exceeding this,
WinUI is incapable of presenting 32-bit floats. C defaults
to 6 digits for string conversions for this exact reason.
How Has This Been Tested?
Windows Terminal overrides its NumberBoxes the same way this PR does it.
Screenshots (if appropriate):
Before:

After:

The team will only be taking critical changes into WinUI 2.8 as our current focus is to assist our users in moving from WinUI 2 to WinUI 3. This change did not meet the bar for a WinUI 2.8 servicing release, but is approved to merge into the WinUI 2 main branch for a WinUI 2.9. That being said, at this time, we have no plans for a WinUI 2.9 as we focus on advancing WinUI 3. We will also port this change to WinUI 3 and it will be present for applications that have migrated to WinUI 3 in an upcoming WinAppSDK release.
Thank you for your contribution!
cc: @bpulliam

/azp run


local ledger improvements

Currently, when users interact with the LocalBlockchain their transactions are being applied via a ledger implementation in OCaml.
However, there are a few ways how this can be approved, and why it should. Let's collect ideas on how we can provide a better experience.

OCaml ledger is not really flexible, doesn't leave a lot of room for customizability

we already patch a lot of the ledgers problems in JS directly (eg checking permisisons)

OCaml ledger only provides a small set of functions

apply tx and getAccounts
lots of room for improvement here, see one example on Discord
no way of fine tuning ledger or account state - makes advanced testing very difficult

OCaml dependencies
..?

Impracticality and un-parity of network state comes to mind also


TensorBoard develop build failed due to npm dead loop and typescript error

What related GitHub issues or StackOverflow threads have you found by searching the web for your problem?
Environment info
Operating System: Ubuntu 16.10
npm 4.4.1
node.js v7.7.2
Installed version of CUDA and cuDNN:  CUDA 8.0, cuDNN 5.1
-rw-r--r-- 1 root root   558720 9月  15 07:02 /usr/local/cuda/lib64/libcudadevrt.a
lrwxrwxrwx 1 root root       16 9月  15 07:05 /usr/local/cuda/lib64/libcudart.so -> libcudart.so.8.0
lrwxrwxrwx 1 root root       19 9月  15 07:05 /usr/local/cuda/lib64/libcudart.so.8.0 -> libcudart.so.8.0.44
-rw-r--r-- 1 root root   415432 9月  15 07:02 /usr/local/cuda/lib64/libcudart.so.8.0.44
-rw-r--r-- 1 root root   775162 9月  15 07:02 /usr/local/cuda/lib64/libcudart_static.a
-rwxr-xr-x 1 root root 79337624 12月 12 18:46 /usr/local/cuda/lib64/libcudnn.so
-rwxr-xr-x 1 root root 79337624 12月 12 18:46 /usr/local/cuda/lib64/libcudnn.so.5
-rwxr-xr-x 1 root root 79337624 12月 12 18:46 /usr/local/cuda/lib64/libcudnn.so.5.1.5
-rw-r--r-- 1 root root 69756172 12月 12 18:46 /usr/local/cuda/lib64/libcudnn_static.a
If installed from source, provide

The commit hash (git rev-parse HEAD)
f1ffbc548906e379d423633f76edc558be8284e7
The output of bazel version
Build label: 0.4.4
Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Wed Feb 1 18:54:21 2017<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

minimal reproducible example
get a fresh clone
cd tensorflow/tensorboard
npm run prepare
and npm install some packages and goes into a dead loop without the bower and typings

<EMAIL_ADDRESS>prepare /home/baomingkun/Res/tensorflow/tensorflow/tensorboard
npm install && bower install && typings install

<EMAIL_ADDRESS>prepare /home/baomingkun/Res/tensorflow/tensorflow/tensorboard
npm install && bower install && typings install

<EMAIL_ADDRESS>prepare /home/baomingkun/Res/tensorflow/tensorflow/tensorboard
npm install && bower install && typings install

<EMAIL_ADDRESS>prepare /home/baomingkun/Res/tensorflow/tensorflow/tensorboard
npm install && bower install && typings install

What other attempted solutions have you tried?
I have moved global typings and typescript, but nothing works.
Logs or other output that would be helpful
(If logs are large, please upload as attachment or provide link).
  Variable 'shadowRoot' must be of type 'ShadowRoot', but here has  type'ShadowRootPolyfill'.
typings/globals/webcomponents.js/index.d.ts(48,5): error TS2687: All declarations of 'shadowRoot' must have identical modifiers.
typings/globals/webcomponents.js/index.d.ts(48,5): error TS2403: Subsequent variable declarations must have the same type.  Variable 'shadowRoot' must be of type 'ShadowRoot', but here has type 'ShadowRootPolyfill'.
typings/globals/webcomponents.js/index.d.ts(48,5): error TS2687: All declarations of 'shadowRoot' must have identical modifiers.
__lib.d.ts(7452,14): error TS2687: All declarations of 'shadowRoot' must have identical modifiers.
[23:27:41] TypeScript: 2 semantic errors
[23:27:41] TypeScript: 3 emit errors
[23:27:41] TypeScript: emit failed
then the demo/index.html is just a blank page.

webcomponents.js typescript binding issue at DefinitelyTyped

webcomponents.js typescript binding issue at DefinitelyTyped

@dandelionmane, do you have any insights on this?

Any update to this? It seems like the TensorBoard development workflow (at least on recent checkouts) is not possible due to this.

the npm run prepare issue is a result of npm 4.3. npm install will now run the prepare script, which runs install, which runs prepare... and so on. I am about to submit a PR for this.

Here's a relevant NPM issue regarding npm prepare https://github.com/npm/npm/issues/15226

@jart @chihuahua
The fact that the open-source TensorBoard build is broken is a known issue and one that frustrates us a lot. I think on the master branch chihuahua put out some new instructions in development.md that solve some of this. We're hard at work on getting a bazel build working so we can leave all this gulp/npm stuff behind.

The development.md file is quite helpful. I'm not sure if I should open an issue for each thing I'm currently encountering in "master" (some might be because I have no experience with the npm/bower ecosystem) but:

The webcomponents.js typings introduced that "shadowRoot" issue that people are hitting even outside of TensorBoard. See the "FYI, this line" part at https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10330/files/4a7781d7e31eb4b9d7b97ecc81c55bb630fd1ddc

Removing that line seemed to allow me to proceed further.

TypeScript does not like the use of "number|null" within vz_project/data.ts:97

Removing the "null" allowed me to proceed further.

The tf_storage component was updated at some point to have a "useLocalStorage" parameter on the get*/set* functions. However, not all of these methods use a default parameter for this. Therefore, storageTests.ts is now broken.

Ensuring this parameter is passed allowed me to proceed further.

The demo now loads partially but fails soon after because these scripts cannot be found (d3, lodash, etc). I figured these would be handled by bower, but I don't know why it's not placing those in some accessible place.

Furthermore, the "tf_imports" folder/dependency is not created and so many other tasks (gulp regenerate, bazel) all then fail at this point.

I'm in the process of upgrading TypeScript in package.json to 2.2.1, which might help. But there's a lot going on here. As @dandelionmane mentioned, we're going to be deprecating the Gulp build soon.

tsify and gulp-typescript both use their own versions of typescript as well. These seem to be the packages causing most of the issues.

So the upgrade to TypeScript 2.2.1 happened. Can we close this?

@jart fixed this; tensorboard now uses bazel to build instead of gulp/npm!
Check it out here: https://github.com/tensorflow/tensorboard


Replace Elisif with: Toccata Follower SE (With Elisif Replacer Option)

Request
https://www.nexusmods.com/skyrimspecialedition/mods/12713
Additional context
Has a gorgeous suitable as a queen. The mod can be used as a follower (Toccata) or replace the queen's appearance, or both.

nope


1click delete

When you delete a message with confirmations it automatically gets rid of the menu that shows the delete,react,share etc but with 1click delete it stays up and I find this rather annoying having to manually scroll down to get rid of main menu even if this was a setting that we could enable for this, that would be totally awesome!

oops

fixed, building now


Broken link in docs

This link xref:writing_contracts.adoc#modifying-your-contracts[remove or change the type of a contract state variable] is broken in this file.

@frangio If you have any instructions on the best way to modify the new .adoc files, I'd be happy to fix this!

@pcowgill Oh good catch. I renamed the files from underscores to dashes and forgot to fix the links to those files. :sweat_smile:
You can just edit the file that you linked to. I can't think of anything else that you should keep in mind. Let me know if you had any particular concern.

@frangio Haha oops, yes these files can be edited like any other type of files. I could have sworn the edit button wasn't appearing in the GitHub UI. My mistake. Thanks!

@frangio Opened a PR for this https://github.com/OpenZeppelin/openzeppelin-sdk/pull/1170


Add DOI to README.md (and/or CITATION.cff)?

Follow-up of https://github.com/Leaflet/Leaflet/issues/7931.
We may want to decide if we should add the Zenodo's DOI badge for the Leaflet repo to README.md, and/or add a CITATION.cff to this repo (the latter would allow people to Cite this repository).

I would do both :+1:

I'd say let's add the citation file only. Folks that are explicitly looking of this (small dedicated audience) will probably already know the citation functionality of GitHub already.
Unless somehow the badge has more relevant info I think it will just add noise for 'regular' users.


opentabletdriver: <IP_ADDRESS>-unstable-2024-11-25 -> <IP_ADDRESS>

Release: https://github.com/OpenTabletDriver/OpenTabletDriver/releases/tag/v<IP_ADDRESS>
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366791

x86_64-linux

:white_check_mark: 1 package built:

opentabletdriver


TypeError: "msecs" argument must be a number

I just downloaded Gekko, ran npm install and node gekko. I enabled tradingAdvisor, profitSimulator and mailer, with an empty password. Gekko prompted me with a password and right after I typed it, the following error showed up:
C:\sandbox\twlgekko\gekko>node gekko
2016-07-17 11:23:30 (INFO):     Gekko v0.3.2 started
2016-07-17 11:23:30 (INFO):     I'm gonna make you rich, Bud Fox.

2016-07-17 11:23:30 (INFO):     Setting up Gekko in realtime mode
2016-07-17 11:23:30 (INFO):
2016-07-17 11:23:30 (INFO):     Setting up:
2016-07-17 11:23:30 (INFO):              Candle writer
2016-07-17 11:23:30 (INFO):              Store candles in a database
2016-07-17 11:23:30 (INFO):

2016-07-17 11:23:30 (INFO):     Setting up:
2016-07-17 11:23:30 (INFO):              Trading Advisor
2016-07-17 11:23:30 (INFO):              Calculate trading advice
2016-07-17 11:23:30 (DEBUG):    The trading method requests 90000 seconds of historic data. Checking availablity..
2016-07-17 11:23:30 (INFO):

2016-07-17 11:23:34 (DEBUG):    Exchange has data spanning 20717 seconds, we need at least 90000 seconds.
2016-07-17 11:23:34 (INFO):              Unable to seed the trading method with locally stored historical candles (Gekko needs more time before it can give advice).
2016-07-17 11:23:34 (INFO):              Using the trading method: MACD
2016-07-17 11:23:34 (WARN):     Warning, trading method has no name
2016-07-17 11:23:34 (INFO):     Setting up:
2016-07-17 11:23:34 (INFO):              Mailer
2016-07-17 11:23:34 (INFO):              Sends you an email everytime Gekko has new advice.
2016-07-17 11:23:34 (WARN):

        You configured Gekko to mail you advice, Gekko needs your email
        password to send emails (to you). Gekko is an opensource project
        [ http://github.com/askmike/gekko ], you can take my word but always
        check the code yourself.

        WARNING: If you have not downloaded Gekko from the github page above we
        CANNOT guarantuee that your email address & password are safe!

prompt: password:  2016-07-17 11:23:34 (INFO):

Got it.
readline.js:953
            throw err;
            ^

TypeError: "msecs" argument must be a number
    at Object.exports.enroll (timers.js:285:11)
    at TLSSocket.Socket.setTimeout (net.js:321:12)
    at new SMTPResponse (C:\sandbox\twlgekko\gekko\node_modules\emailjs\smtp\response.js:66:11)
    at Object.exports.monitor (C:\sandbox\twlgekko\gekko\node_modules\emailjs\smtp\response.js:71:9)
    at Object.SMTP.connect (C:\sandbox\twlgekko\gekko\node_modules\emailjs\smtp\smtp.js:173:35)
    at Object.Client._connect (C:\sandbox\twlgekko\gekko\node_modules\emailjs\smtp\client.js:68:17)
    at Object.Client._poll (C:\sandbox\twlgekko\gekko\node_modules\emailjs\smtp\client.js:28:18)
    at C:\sandbox\twlgekko\gekko\node_modules\emailjs\smtp\client.js:102:21
    at Object.Message.valid (C:\sandbox\twlgekko\gekko\node_modules\emailjs\smtp\message.js:140:10)
    at Object.Client.send (C:\sandbox\twlgekko\gekko\node_modules\emailjs\smtp\client.js:83:14)

My node version is 6.3.0 and npm is 3.10.3, and it happens only if I enable mailer.
My mailer config:
config.mailer = {
  enabled: true,       // Send Emails if true, false to turn off
  sendMailOnStart: true,    // Send 'Gekko starting' message if true, not if false

  email<EMAIL_ADDRESS>   // Your Gmail address

  // You don't have to set your password here, if you leave it blank we will ask it
  // when Gekko's starts.
  //
  // NOTE: Gekko is an open source project < https://github.com/askmike/gekko >,
  // make sure you looked at the code or trust the maintainer of this bot when you
  // fill in your email and password.
  //
  // WARNING: If you have NOT downloaded Gekko from the github page above we CANNOT
  // guarantuee that your email address & password are safe!

  password: '',       // Your Gmail Password - if not supplied Gekko will prompt on startup.

  tag: '[GEKKO] ',    // Prefix all email subject lines with this

            //       ADVANCED MAIL SETTINGS
            // you can leave those as is if you
            // just want to use Gmail

  server: 'smtp.gmail.com',   // The name of YOUR outbound (SMTP) mail server.
  smtpauth: true,     // Does SMTP server require authentication (true for Gmail)
          // The following 3 values default to the Email (above) if left blank
  user: '',       // Your Email server user name - usually your full Email address<EMAIL_ADDRESS>  from: '',       //<EMAIL_ADDRESS>  to: '',       //<EMAIL_ADDRESS><EMAIL_ADDRESS>  ssl: true,        // Use SSL (true for Gmail)
  port: '',       // Set if you don't want to use the default port
  tls: false        // Use TLS if true
}

looking into it!

sorry for delayed response, could you update (run git pull && npm install and try again)?


fix: add bin fold into package.json files to make it published

Public-Facing Changes
None
Description
Currently, use pnpm install  this package will result WARN because bin folder is not publish to registery.
 WARN  Failed to create bin at xxxxxxx/node_modules/.bin/gendeps2. The source file at xxxxxxx/node_modules/.pnpm/@foxglove+rosmsg@4.2.1/node_modules/@foxglove/rosmsg/bin/gendeps2 does not exist.
 WARN  Failed to create bin at xxxxxxx/node_modules/.bin/gendeps2. The source file at xxxxxxx/node_modules/.pnpm/@foxglove+rosmsg@4.2.1/node_modules/@foxglove/rosmsg/bin/gendeps2 does not exist.

I think the fix is to publish it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ares seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


trying to buy subscription for a fresh new account while having running subscriptions results in gui fail

and then I chose a freshly created account

all the same

btw i can't click renew button. Had to remove other accounts from extensions

this resulted in infinite loading

@PaTara43 where do you test-  https://dev.robonomics.app/#/ or https://robonomics.app/#/ ?
If https://robonomics.app/#/ , then check again please, this night was new release on it.

same


Updates

Let me know if and what of these you need in separate PRs (not too many line changes though).

refactor: use fully ESM source
testing: check where right of BinaryExpression is itself a BinaryExpression (brings to 100% coverage)
chore: add source maps
chore: update devDeps (babel/preset-env, ava, coveralls, eslint); check Node 12 and 14 in Travis
chore: switch from --ignore-pattern to ignore file, allowing IDEs to avoid showing errors for ignored files

Coverage remained the same at 100.0% when pulling 98e3e0b902a0e44f2c0da8e5c2475be83d42f63b on brettz9:updates into e85d210481d1bec030ab694caa55cb13065f588b on dustinspecker:master.

This all looks great! I want to take a closer look at the export default later today after work. I thought there was a reason to prefer module.exports =  over export default back in the day. I don't know if that's still relevant. But either way, this looks like a nice change to eventually remove the need for babel.

Re: export default, ah yes, I forgot it needed a transform to create the module.exports which ESLint expects and which I've now added. I would expect a future ESLint supporting ESM would allow for consuming default ESM exports, so given that native ESM doesn't understand module.exports, it should be more future compatible to use the transform now rather than module.exports (and in any case, I think more appealing to be consistent).
Btw, I also added a target Node version for @babel/preset-env based on the minimum current engines.  As you may be aware, the higher the target we can use there, the shorter and more native the code.
Re: eventually removing Babel, while it is nice one can more easily go that route these days, there still seem to be a good steady stream of very appealing features, like optional chaining or the null coalescing operator, so I'm personally hesitant to drop it in my own projects as a result. :-)

I've also rebased, and it is indeed nice to see full coverage including index.js now (as a result of your commit).

Thank you for all of the enhancements!

Thank you very much for the reviews!


Cgc v2 address

This is Chris's changes from https://github.com/Bitcoin-com/rest.bitcoin.com/pull/73 merged w/ the TS additions.

Pull Request Test Coverage Report for Build 443

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.948%

Totals

Change from base Build 440:
0.0%

Covered Lines:
1370

Relevant Lines:
1951

💛  - Coveralls

:tada: This PR is included in version 1.0.0 :tada:
Your semantic-release bot :package::rocket:


mention OSX dependencies and use build for install

OSX was missing some dependencies, mentioned now in README
make failed after cloning libmill without these.
I tried to use make again after installing deps and it failed to clone since libmill already exists.
so with a build directory we can fix that

cool, thanks!
merged in<PHONE_NUMBER>1b3ec8a9cdad2b9be2f983fea4d262


chore: reorg package in prep for toolchain

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#277
#276  👈
#275
#274
#273
#266
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Review Generics

On all types referenced from Cache<K, V>:

CacheLoader & CacheWriters
Eviction & Expiry
Store
others... ?

I think we got some wrong... Sort of started at the EvictionPrioritizer (i.e. the Comparator), EvictionVeto (i.e. the Predicate) and the Expiry when working on #101, as I tried pushing the CacheConfigurationBuilder generics a bit further.

This may well be obsolete now, or around CacheLoader & CacheWriter unification at least...

I took a look at the generics in the API class they all look fine to me.
I believe this issue can be closed now.


Slack invite link has expired

Describe the bug
The Slack invite link(s) at https://nf-co.re/join have expired.
To Reproduce

Go to https://nf-co.re/join
Click on the Slack or "Get an invite to nf-core Slack" button
See error "This link is no longer active"

Expected behavior
Get an invite to the nf-core Slack.
Browser (please complete the following information):

OS: macOS
Browser: Chrome
Version: 27.0.6533.122

Additional context
I would like to join the Slack please 🙏

It appears this has been fixed. The link now works and I was able to join 😊


Any plans to include EC2 tags as inventory variables?

Sounds like a good idea to me. The Parser.Attributes method currently just returns the attributes from the state file as-is, which is usable but not terribly helpful. It would be much better to return the same vars which ec2.py does. I'll try to get to this soon, or feel free to submit a patch.

+1

+1

+1

+1

+1


Inkplate 5 batteryAndTemperatureRead.py fails

throws a Traceback when reading the temperature
Mono: clean 970ms (19ms ea), draw 381ms (63ms ea), total 1351ms
0
Mono: clean 971ms (19ms ea), draw 381ms (63ms ea), total 1352ms
Traceback (most recent call last):
  File "<stdin>", line 41, in <module>
  File "inkplate5.py", line 837, in readTemperature
  File "inkplate5.py", line 173, in read_temperature
OSError: [Errno 19] ENODEV

I'm using commit 103e107195186d86ce219b335b4c51a1d0b9105f

Hi @fovea1959
Sorry to hear you're experiencing this issue, I just tried to replicate it and you're right, the reason this is happening is because on the newer boards, VBAT_EN should be HIGH to enable the circuitry to measure the battery, I've fixed this in a quick patch, check out the commit here: https://github.com/SolderedElectronics/Inkplate-micropython/commit/1e896484466e7a21e8becceb149f94bffc0e354c
The temperature issue I bet has something to do with properly turning on the TPS65186, also via digital write, as it's not available over I2C when I try to scan it. I will have to look into the temperature issue more next week due to some time constraints, I hope the fixed readBattery functionality will be helpful to you.
-Rob


Does not show full cost

Hello, I am currently using version 0.1.2 and it does not show the fully calculated cost, I use Cura 5.4.0.

Thank you very much for your time and work

Hiho! Yeah, that's my bad. I assumed a few digits would be enough for power cost, but I didn't take into account countries with low value currencies. I'll increase the width and publish a new version. Thanks!

Thanks for the correction, I already installed it and it works great


test: assert convergence among Cloud Java client libraries

The assertions on the dependency convergence among Cloud Java libraries:
Managed dependency com.google.cloud:google-cloud-bigquery:jar:2.13.8 has dependency com.google.cloud:google-cloud-bigquerystorage:jar:2.14.2, which should be 2.15.0 (the version in the BOM).
Managed dependency com.google.cloud:google-cloud-nio:jar:0.124.7 has dependency com.google.cloud:google-cloud-storage:jar:2.9.0, which should be 2.9.2 (the version in the BOM).
Managed dependency com.google.cloud:google-cloud-notification:jar:0.123.2-beta has dependency com.google.cloud:google-cloud-storage:jar:2.7.2, which should be 2.9.2 (the version in the BOM).
Managed dependency com.google.cloud:google-cloud-notification:jar:0.123.2-beta has dependency com.google.cloud:google-cloud-pubsub:jar:1.119.1, which should be 1.120.0 (the version in the BOM).
Managed dependency com.google.cloud:google-cloud-spanner-jdbc:jar:2.7.4 has dependency com.google.cloud:google-cloud-spanner:jar:6.25.5, which should be 6.25.7 (the version in the BOM).
Managed dependency com.google.cloud:google-cloud-pubsublite:jar:1.6.1 has dependency com.google.cloud:google-cloud-pubsub:jar:1.119.0, which should be 1.120.0 (the version in the BOM)

Fixes https://github.com/googleapis/java-cloud-bom/issues/3710

java-pubsublite depending on google-cloud-bom fails.
https://github.com/googleapis/java-pubsublite/blob/7d0952d891a42f9b393d247accb651d12c75a769/pom.xml#L42


[ISSUE #4913] ReplicasManager#schedulingSyncControllerMetadata update controller metadata again after a while

Make sure set the target branch to develop
What is the purpose of the change
close #4913
Brief changelog
-ReplicasManager#schedulingSyncControllerMetadata update controller metadata again after a while
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4914 (30c5b75) into develop (2a46dbe) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4914      +/-   ##
=============================================
- Coverage      43.32%   43.23%   -0.09%
+ Complexity      7707     7696      -11
=============================================
  Files            994      994
  Lines          68938    68942       +4
  Branches        9132     9132
=============================================
- Hits           29865    29805      -60
- Misses         35330    35393      +63
- Partials        3743     3744       +1

Impacted Files
Coverage Δ

...he/rocketmq/broker/controller/ReplicasManager.java
43.09% <0.00%> (-0.55%)
:arrow_down:

...apache/rocketmq/remoting/netty/ResponseFuture.java
77.55% <0.00%> (-4.09%)
:arrow_down:

...rocketmq/remoting/netty/NettyRemotingAbstract.java
50.00% <0.00%> (-3.96%)
:arrow_down:

...a/org/apache/rocketmq/broker/BrokerController.java
43.84% <0.00%> (-3.52%)
:arrow_down:

...ache/rocketmq/store/AllocateMappedFileService.java
39.28% <0.00%> (-2.39%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...he/rocketmq/broker/processor/PopReviveService.java
38.35% <0.00%> (-1.80%)
:arrow_down:

...he/rocketmq/client/impl/consumer/ProcessQueue.java
61.46% <0.00%> (-0.92%)
:arrow_down:

...client/consumer/store/RemoteBrokerOffsetStore.java
68.42% <0.00%> (-0.61%)
:arrow_down:

...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java
75.84% <0.00%> (-0.38%)
:arrow_down:

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Multiple VCards in one file

Any specific reason for no support for this??

Hi @auro1, thanks for your issue :-D.
Well, I guess because I have never needed that functionality.
Feel free to PR such a feature :-P

I reopened this issue because this function could come in handy.

+1 this. I have a contacts app and it would be useful to be able to allow the user to export "all contacts" instead of just one at a time.

Any plans for this? Would be most useful!

Isn't https://github.com/jeroendesloovere/vcard/pull/101 a PR for this feature?

We are working on a new vCard version which handles this by default.
You can view the WIP over here: https://github.com/jeroendesloovere/vcard/tree/new-version


Core documentation

This commit documents most parts of the core/ crate, with a few modules, mostly the APEX ones and the commits saying "Document", being the notable exception.
Feel free to merge/squash/cherry-pick.

Rebased to 137e622ab2baeb41c187cab5b3ccbd2b67342523.
cc @wucke13

Please rebase on main. If the CI gets through, we'll merge.


[Event Request] Table 5741 „Transfer Line“ – ShowReservation

Could we please have a publisher OnBeforeShowReservation in function ShowReservation of Table 5741 „Transfer Line“?
    procedure ShowReservation()
    var
        OptionNumber: Integer;
        IsHandled: Boolean;
    begin
        // start kvsmed
        IsHandled := false;
        OnBeforeShowReservation(Rec, IsHandled);
        if IsHandled then
            exit;
        // stop kvsmed
        TestField("Item No.");
        Clear(Reservation);
        OptionNumber := StrMenu(Text011);
        if OptionNumber > 0 then begin
            Reservation.SetReservSource(Rec, OptionNumber - 1);
            Reservation.RunModal();
        end;
    end;

    procedure UpdateWithWarehouseShipReceive()
    begin
        if Location.RequireShipment("Transfer-from Code") then
            Validate("Qty. to Ship", 0)
        else

…
  // start kvsmed
    [IntegrationEvent(false, false)]
    local procedure OnBeforeShowReservation(var TransferLine: Record "Transfer Line"; var IsHandled: Boolean)
    begin
    end;
    // stop kvsmed

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


feat(readme): generate a composable README.md file for product consumers

TIP: Select the "Preview" Tab to help read these instructions.
1. Issue type

[x] Feature: I'm requesting an enhancement.

2. User story summary
As an open source product maintainer,
I need a consistent and succinct README file
In order to encourage consumption of my product.
3. Acceptance criteria

Replace the examples below with your own imperative, "true/false" statements for the behavior you expect to see, or the behavior that would be true if there were no errors (for defects).

[x] 1. Generated READMEs display a title that defaults to the package.json/#/name property.
- [ ] 2. Generated READMEs display an option logoPath under the title.
[x] 3. Generated READMEs display an optional section for badges.
[x] 4. Generated READMEs display a required short description section.
[x] 5. Generated READMEs provide an optional Overview section.
[x] 6. Generated READMEs provide a Table of contents section with anchor links that jump to subsequent sections.
[x] 7. Generated READMEs display a required Installation section with default Node.js installation instructions.
[x] 8. Generated READMEs provide an optional Configuration section.
[x] 9. Generated READMEs display a required Usage section.
[x] 10. Generated READMEs provide an optional API section.
[x] 11. Generated READMEs provide an optional Background section.
[x] 12. Generated READMEs provide an optional Security section.
[x] 13. Generated READMEs display a Contributing section.
[x] 13.1. The Contributing section provides a working link to a CODE_OF_CONDUCT document.
[x] 13.2. The Contributing section provides a working link to a CONTRIBUTING document.
[x] 13.3. The Contributing section provides a link that will pre-populate a new GitHub feature request.
[x] 13.4. The Contributing section provides a link that will pre-populate a new GitHub defect report.
[x] 14. Generated READMEs display a License section with a working links to the OSS license and its copyright owner.

Notes
There are several README generators available on the npm registry today. Evaluate:

[x] 1.  generator-standard-readme - Opinionated, but pretty good. Richard Littauer has even declared it a "specification."
[x]  2. generator-readme
[x] 3. generator-make-readme is a fork of generator-standard-readme, and it looks pretty good.
[x] 4. generator-badges add badges. I'll probably incorporate this.
[x] 5. generator-verb looks good, but it hasn't been touched in a long time.

@commonality/generator-community-core-team consensus is to

Create a package.json if one doesn't already exist, or
Update an existing package.json with different values.

Therefore, I'm blocking this issue till #4 has been completed.


Release 0.3.0

Codecov Report

Merging #8 (af81932) into main (6fa038a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   97.39%   97.41%   +0.01%
==========================================
  Files          13       13
  Lines         307      309       +2
==========================================
+ Hits          299      301       +2
  Misses          8        8

Impacted Files
Coverage Δ

...ources/PhantomKit/Swift/Extensions/Array+Ext.swift
100.00% <ø> (ø)

...mKit/Swift/Formatters/LocalizedDateFormatter.swift
90.62% <ø> (ø)

...antomKit/Swift/Formatters/LocalizedFormatter.swift
95.86% <100.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa038a...af81932. Read the comment docs.


Revisit the applicability of OverlayAddr

Under the hood, overlay addresses are currently a composition of interfaces:
func NewOverlayAddr(l3 addr.HostAddr, l4 addr.L4Info) (*OverlayAddr, error)

If the layer 3 and layer 4 headers are a valid combination, the object is constructed. Otherwise, an error is returned.
The two important methods to get back the interfaces are:
func (a *OverlayAddr) L3() addr.HostAddr
func (a *OverlayAddr) L4() addr.L4Info

The intention is for applications to be agnostic about the overlay they are running on. However, in practice OverlayAddr does not make this possible, and sometimes makes for awkward code.
Some disadvantages

Applications still need to construct a specific type of overlay socket. Once the type of the socket is chosen, applications construct the OverlayAddr from a HostAddr and L4Info that they themselves initialize. Since they know the concrete implementations of the HostAddr and L4Info, they could just use them directly.

APIs/libraries taking OverlayAddr that need to do overlay related operations need to check for all valid combinations. This is done by extracting layers 3 and 4 with methods L3() and L4() and checking whether their combination is a supported combination (e.g., a library that can only construct UDP/IP packets cannot accept an IP-only overlay). Because L3() and L4() return interfaces, the check needs to go into the concrete objects behind those interfaces. This amounts to a lot of checks (see 3. below).

Related to the point before, checking that an overlay address is supported must always be done by checking the concrete layer 3 and layer 4 types against all supported implementations:

if overlayAddr.L3().Type() == Foo || overlayAddr.L3().Type() == Bar {
  // overlay code
}

This is done to protect libraries against future overlay implementations, which might add new unsupported layer 3's or 4's. But since all the types are explicitly checked, this makes the code aware of the implementation again.

Method L3() returns interface addr.HostAddr. However, not all implementations of addr.HostAddr are valid. For example, addr.HostSVC is not a valid L3 for a combination. While the constructor of OverlayAddr protects against it, programmers need to always remember that the returned object can never be an invalid implementation of addr.HostAddr. While in the immediate call to L3() this is somewhat feasible, imagine if the result is stored in some other object, that gets passed in a different library. The library only sees addr.HostAddr, and needs to check against all invalid implementations again. This leads to more lines of code, more branching, and more testing.

Some overlays don't have an L4. Because method L4() can always return nil, every access needs to perform additional checking do defend against panics. The checks work against the flexibility the type aims to promote, because it exposes an implementation aspect of the interface (the fact that it is constructed without an L4), to a caller that shouldn't care about this aspect.

UDP/IP is the only overlay we need at the moment. While IP only could be used in the somewhat near future, nothing is stopping us from having an IP overlay address and an UDP/IP overlay address. Callers will need to understand what addresses they're constructing anyway (e.g., from an address string in the config file).

The need for precise conversion from OverlayAddr to concrete implementations can also be seen from OverlayAddr's API. Methods like ToUDPAddr() that return nil for every invalid internal combination of layer 3 and layer 4, and return a *net.UDPAddr for IP/UDP overlays, are basically a way for callers to say extract the concrete overlay they support, without going through all the checking. This works fine right now because we only support one combination, but as the number of overlays grows many more methods like this would appear.

Possible solution
A possible way to simplify this is to manager overlay addresses similarly to how the standard library net package manages addresses. The address interface is very lightweight, and gives very limited information about the internal type:
type Addr interface {
        Network() string // name of the network (for example, "tcp", "udp")
        String() string  // string form of address (for example, "<IP_ADDRESS>:25", "[2001:db8::1]:80")
}

This means that every data type that wants to use the address, must type assert to the implementation immediately. This works great for stuff like net.UDPConn and net.TCPConn, because they support a single address concrete type, and it can possibly work just as great for overlays.
For us, this would amount to having (maybe) an UDP/IP overlay connection type (net.UDPConn, basically) with UDP/IP overlay addresses (net.UDPAddr), and in the future we can add an IP overlay connection type (net.IPConn) with IP overlay addresses (net.IPAddr). Using the concrete types as soon as possible means libraries need to do less checking, and will be more robust. Whenever we want to pass an address around in higher-level logic, we can use net.Addr.
Thoughts?

Are we expecting to ever support mixed-overlay-type deployments? If not so, we can hardwire the overlay type at compile time.

OverlayAddr was removed by https://github.com/scionproto/scion/pull/3381 and https://github.com/scionproto/scion/pull/3552.


I encountered errors downloading the dataset and pre training model.

I would appreciate it if you could help me！

@Suelence-hu ,
This seems to be a network issue. If wget do not work, you can manually download the dataset using the provided url. Then unzip it and move it to a data directory under the root path.


[TECHDEBT] Fix mockgen tags

Description
Fix the mockgen build tags across the board
Issue

Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[x] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Using source mode instead of reflect mode across all mocked interfaces; more detailed here
Fixed make targets to mock cleanups

Testing

[x] make develop_test; if any code changes were made
[ ] make test_e2e on k8s LocalNet; if any code changes were made
[ ] e2e-devnet-test passes tests on DevNet; if any code was changed
[ ] Docker Compose LocalNet; if any major functionality was changed or introduced
[ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[ ] I have tested my changes using the available tooling
[ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

/reviewpad summarize


Inquirer-tree-prompt

Collapsed headings return children as undefined when expanded.
No built in method to prevent parent headings from being selected.

Possible that support has been shifted to new inquirer and no longer functions fully with ^8.2.4.

Resolved by removing inquirer-tree-prompt package in #6


Added A dice rolling sim

I also made a few note on how i made the thing and some other helpful notes on the random function and time function

Hmm, this could be a fun easter egg in the package.  I'll merge, but won't include docs for the sake of it ;)

just waiting for travis

Ok thanks i made this in 3.7 so somethings are just not liking it.

Ok thank you. hope this is what you needed.
On Thu, Oct 4, 2018 at 8:46 PM RDIL<EMAIL_ADDRESS>wrote:

Merged #7 https://github.com/RDIL/area4/pull/7 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RDIL/area4/pull/7#event-1886133752, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AkGKQ0XKMW86aRqmXFlpjdhN4L5gIwWoks5uhsfrgaJpZM4XJdaT
.


Does this works with Chinese?

Does this works with Chinese text corpus? Thanks!

Yes, it would work. Replace the pretrained model with GPT2 chinese model and then fine tune the target text in the same way.
Thanks

thanks!

Where can I replace the Chinese pre-training model


[DebugInfo] Emit distinct DILocation for different inline instances

LLVM seems to determine a variable instance as a combination of DILocalVariable
and DILocation. Therefore if multiple llvm.dbg.declare have the same
variable/location parameters, they are considered to be referencing the same
instance of variable.
Swift IRGen emits a set of llvm.dbg.declare calls for every variable
instance (with unique SILDebugScope), so it is important that these calls have
distinct variable/location parameters. Otherwise their DIExpression may be
incorrect when treated as referencing the same variable. For example, if they
have a DIExpression with fragments, we will see this as multiple declarations of
the same fragment. LLVM detects this and crashes with assertion failure:
DwarfExpression.cpp:679: void llvm::DwarfExpression::addFragmentOffset(const
llvm::DIExpression *): Assertion `FragmentOffset >= OffsetInBits &&
"overlapping or duplicate fragments"' failed.
The patch resolves #55703. The LIT test (debug_scope_distinct.swift) is the
reproducer from that issue.

@swift-ci please test

The LIT test is a bit too minimal - it has some undefs in IR, which does not play nicely with optimizations. I cannot reproduce CI failures locally, but the issue is obvious. I'll change the test to avoid undefs, and we can try again.

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test macos platform

@swift-ci please test macos platform

@swift-ci please test

@adrian-prantl ping :)

@adrian-prantl, can you please check if the patch is OK?

@adrian-prantl Gentle ping

(Sorry for the delayed response, I've been on vacation)
In the reproducer, the inlined-at locations are all at line 0 and it looks like that is the actual problem. I think it would be okay to emit line 0 inlined-at locations as distinct to avoid this problem, but a better solution would be to ensure the autodifferentiation transformation would assign meaningful line numbers. Inlined functions with no source location at the call site are not a great user experience.
Would you mind changing the patch to only apply the distinct locations to line-0 call sites?

Right, it seems that the compiler lost the actual line number somewhere, and it is better to fix this issue.
However, these locations are tied to the same local variable (multiple instances of it after inlining), so the correct line number would also be the same for both, and we're back to the same problem.

though I'd prefer we could assert that no function call is on line 0.

This is likely because these calls are artificial, and generated by the compiler to support differentiation.
I will check if this is the case.

However, these locations are tied to the same local variable (multiple instances of it after inlining), so the correct line number would also be the same for both, and we're back to the same problem.

I don't think that's true. If the same function is inlined multiple times, and locations are tracked correctly, then the inlined call sites would differ and the locations would be distinct.

Without the patch, all it takes to get a collision of inlinedAt locations is for them to have the same source line and scope.
Lines are not unique in general: we can have multiple inlined calls on the same source line.
Scopes (DISubprogram in this case) are not unique either, at least we don't have a unique scope for each inline instance.
I think this is the same problem that LLVM had back in the day:
https://github.com/llvm/llvm-project/commit/df706288fba670943e164893e1fa0ccda3e24895

Okay, if LLVM also generates all inlinedAt locations as distinct, we should match that behavior. One thing I was worried about here was that we would generate distinct inlinedAt information for two instructions originating from the same inlined call, however, these should share the same SILDebugScope on so the caching mechanism should prevent this from happening.
LGTM! And thanks for pointing this out.

This is failing on Android armv7, similar to previous tests that were disabled for 32-bit in #66879:
Command Output (stderr):
--
/home/ubuntu/jenkins/workspace/oss-swift-RA-linux-ubuntu-16.04-android/swift/test/IRGen/debug_scope_distinct.swift:10:11: error: CHECK: expected string not found in input
// CHECK: call void @llvm.dbg.value(metadata {{.*}} %[[ARG0]], metadata ![[VAR1:[0-9]+]], metadata !DIExpression(DW_OP_LLVM_fragment, 0, 64)), !dbg ![[LOC1:[0-9]+]]
          ^
<stdin>:1030:42: note: scanning from here
 %.sroa.013.0.copyload = load ptr, ptr %0, align 4, !dbg !286
                                         ^
<stdin>:1030:42: note: with "ARG0" equal to "\\.sroa\\.013\\.0\\.copyload"
 %.sroa.013.0.copyload = load ptr, ptr %0, align 4, !dbg !286
                                         ^
<stdin>:1078:2: note: possible intended match here
 call void @llvm.dbg.value(metadata i64 %22, metadata !280, metadata !DIExpression(DW_OP_LLVM_fragment, 40, 64)), !dbg !309
 ^

Input file: <stdin>
Check file: /home/ubuntu/jenkins/workspace/oss-swift-RA-linux-ubuntu-16.04-android/swift/test/IRGen/debug_scope_distinct.swift

-dump-input=help explains the following input dump.

 Can you put a REQUIRES on the test that limits it to 64 bit architectures?

@finagolfin, @adrian-prantl, thank you for letting me know, I missed the follow-up patch that disabled these tests for watchOS. Can you please check the patch #67699?


403 for any download

Getting a 403 error trying to download anything with this library. Maybe youtube changed something on their end?
Added a console.log to show the requests it's making, if that's helpful.
$ ytdl-mp3 https://www.youtube.com/watch?v=ZUJAxBIF1Yg
{
  host: 'api.github.com',
  hostname: 'api.github.com',
  path: '/repos/fent/node-ytdl-core/releases/latest',
  port: '',
  protocol: 'https:',
  maxRedirects: 10,
  maxRetries: 2,
  maxReconnects: 0,
  backoff: { inc: 100, max: 10000 },
  headers: { 'User-Agent': 'ytdl-core', referer: 'https://www.youtube.com/' }
}
{
  host: 'www.youtube.com',
  hostname: 'www.youtube.com',
  path: '/watch?v=ZUJAxBIF1Yg&hl=en',
  port: '',
  protocol: 'https:',
  maxRedirects: 10,
  maxRetries: 2,
  maxReconnects: 0,
  backoff: { inc: 100, max: 10000 },
  headers: {
    'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.101 Safari/537.36',
    referer: 'https://www.youtube.com/'
  }
}
{
  host: 'www.youtube.com',
  hostname: 'www.youtube.com',
  path: '/s/player/8eff86d5/player_ias.vflset/en_US/base.js',
  port: '',
  protocol: 'https:',
  maxRedirects: 10,
  maxRetries: 2,
  maxReconnects: 0,
  backoff: { inc: 100, max: 10000 },
  headers: {
    'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.101 Safari/537.36',
    referer: 'https://www.youtube.com/'
  }
}
{
  host: 'rr1---sn-nvopjoxu-nwjl.googlevideo.com',
  hostname: 'rr1---sn-nvopjoxu-nwjl.googlevideo.com',
  path: '/videoplayback?expire=1721337860&ei=pDOZZpyfGcP7sfIPpOeK0AM&ip=2001%3A5a8%3A4508%3Aa400%3A282d%3Ab7f8%3Ad8b%3Ac237&id=o-AM9sF5bFW5wzSpd87FK_WsuCorh6ZEnLt8uAjFoMg6aR&itag=251&source=youtube&requiressl=yes&xpc=EgVo2aDSNQ%3D%3D&mh=65&mm=31%2C29&mn=sn-nvopjoxu-nwjl%2Csn-n4v7snl7&ms=au%2Crdu&mv=m&mvi=1&pcm2cms=yes&pl=45&gcr=us&initcwndbps=1045000&bui=AXc671INsYyR19a09z4bS6Vp6mqtHc0vO5yNRgkAsDS9-DVPJUplSjbg84vxyo61ZeLeJ4T_4vX1GGXC&spc=NO7bAWzsySKtexnZEJx4Y0sVF8aAhKHe5cZ7BfV0gfIGlniqGbfdTzAsLszu&vprv=1&svpuc=1&mime=audio%2Fwebm&ns=6iLCMa4W3-dw_sqZgjDJnTUQ&rqh=1&gir=yes&clen=2583419&dur=144.521&lmt=1714691630616388&mt=1721315819&fvip=4&keepalive=yes&c=WEB&sefc=1&txp=2318224&n=Xc6hwxNJApWVya2FYQs&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cgcr%2Cbui%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cns%2Crqh%2Cgir%2Cclen%2Cdur%2Clmt&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpcm2cms%2Cpl%2Cinitcwndbps&lsig=AHlkHjAwRgIhAOKRIZhQVKnUTBMWd9U5bMjlJzjTd9CvVCUZ2wM45QMnAiEA78X3UwmqTjO1kTiXfYc_iJ8ISj6OnDcTUWcN8ZACpiI%3D&sig=AJfQdSswRQIhAKb8HSpSPHci-7AliKrxzvw4zXYCdODzRqXWiKkZhw8-AiAPFptTayk7twq2tTxDESVcAETyqMIS4ei4Q8v7AEX_Tg%3D%3D',
  port: '',
  protocol: 'https:',
  maxRedirects: 10,
  maxRetries: 3,
  maxReconnects: 6,
  backoff: { inc: 500, max: 10000 },
  headers: { Range: 'bytes=0-', referer: 'https://www.youtube.com/' }
}
/Users/isaacs/Downloads/el-jan-2023/node_modules/miniget/dist/index.js:208
                let err = new Miniget.MinigetError(`Status code: ${res.statusCode}`, res.statusCode);
                          ^

MinigetError: Status code: 403
    at ClientRequest.<anonymous> (/Users/isaacs/Downloads/el-jan-2023/node_modules/miniget/dist/index.js:208:27)
    at Object.onceWrapper (node:events:634:26)
    at ClientRequest.emit (node:events:519:28)
    at HTTPParser.parserOnIncomingClient (node:_http_client:698:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
    at TLSSocket.socketOnData (node:_http_client:540:22)
    at TLSSocket.emit (node:events:519:28)
    at addChunk (node:internal/streams/readable:559:12)
    at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
    at Readable.push (node:internal/streams/readable:390:5) {
  statusCode: 403
}

Node.js v20.13.1

Ah, that's me also putting the referer there, in case that was the issue, but it apparently isn't.

Related to https://github.com/fent/node-ytdl-core/issues/1295

The issue was user-agent. I hard coded in the UA header from my browser, and then it works.

I don't understand very well what you did. Where did you hard code the user agent header from the browser? In which source code file?

Have the same problem basically.
C:\Users\admin\AppData\Roaming\npm\node_modules\ytdl-mp3\node_modules\miniget\dist\index.js:206                 let err = new Miniget.MinigetError(Status code: ${res.statusCode}`, res.statusCode);
^
MinigetError: Status code: 403
at ClientRequest. (C:\Users\admin\AppData\Roaming\npm\node_modules\ytdl-mp3\node_modules\miniget\dist\index.js:206:27)
at Object.onceWrapper (node:events:634:26)
at ClientRequest.emit (node:events:519:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:698:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
at TLSSocket.socketOnData (node:_http_client:540:22)
at TLSSocket.emit (node:events:519:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
at Readable.push (node:internal/streams/readable:390:5) {
statusCode: 403
}
Node.js v20.15.0`
Can you guys some solution for solving this problem?

@joshunrau pls help if you know a solution. I've used your product for a while, you know ;)

I've created a PR that should fix this error #67

Thanks @ShaquilleSadiq ! Just confirmed this is fixed. Sorry, was very busy lately and didn't have time to look at this. The new version is up on npm let me know if any further issues.


[Key Vault - Certificates] Execute Samples failing in nightly runs

Key Vault - Certificates nightly test runs are failing with:

Error message:
There was a conflict while deleting the pending certificate 'operation-1669936728795'
Stack trace:
An error occurred: RestError: There was a conflict while deleting the pending certificate 'operation-1669936728795'. This can happen when multiple operations are performed in parallel against the pending certificate. To avoid this error, perform operations against the pending certificate in a sequential manner.
{
"name": "RestError",
"code": "Conflict",
"statusCode": 409,
"request": {
"url": "***certificates/operation-1669936728795/pending?api-version=7.4-preview.1",
"headers": {
"accept": "application/json",
"accept-encoding": "gzip,deflate",
"user-agent": "azsdk-js-keyvault-certificates/4.7.0-beta.1 core-rest-pipeline/1.10.1 Node/v14.21.1 OS/(x64-Windows_NT-10.0.17763)",
"x-ms-client-request-id": "7fbb8955-6065-428d-a51d-0e3159aef3ec",
"authorization": "REDACTED"
},
"method": "DELETE",
"timeout": 0,
"disableKeepAlive": false,
"streamResponseStatusCodes": {},
"withCredentials": false,
"tracingOptions": {
"tracingContext": {
"_contextMap": {}
}
},
"requestId": "7fbb8955-6065-428d-a51d-0e3159aef3ec",
"allowInsecureConnection": false,
"enableBrowserStreams": false
},
"details": {
"error": {
"code": "Conflict",
"message": "There was a conflict while deleting the pending certificate 'operation-1669936728795'. This can happen when multiple operations are performed in parallel against the pending certificate. To avoid this error, perform operations against the pending certificate in a sequential manner."
}
},
"message": "There was a conflict while deleting the pending certificate 'operation-1669936728795'. This can happen when multiple operations are performed in parallel against the pending certificate. To avoid this error, perform operations against the pending certificate in a sequential manner."
}
The script failed with exit code 1

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2026081&view=results

Haven't seen this issue in over a month now, closing for the time being.


Brainstorm about the functions of the app.

Think of all the functions will be implemented in milestone 2.

All functions have been designed for milestone 2.


I use pyAzureKinect to Get Calibration but it always null, could you tell me how to get calibration's Intrinsic

'
pyK4 = pyKinectAzure(modulePath)
pyK4.device_open(0)
config = pyK4.config
pyK4.device_start_cameras(config)
config.color_resolution = _k4a.K4A_COLOR_RESOLUTION_1080P
#config.depth_mode = _k4a.K4A_DEPTH_MODE_WFOV_2X2BINNED
config.depth_mode = _k4a.K4A_DEPTH_MODE_NFOV_UNBINNED
cali = None
pyK4.getDepthSensorCalibration(calibration=cali)
#Traceback (most recent call last):
File "D:/UE4Protect/pyKinect/pyKinectAzure/examples/Test3DReConstruct.py", line 25, in
pyK4.getDepthSensorCalibration(calibration=cali)
#File "../pyKinectAzure\pyKinectAzure.py", line 573, in getDepthSensorCalibration
#self.device_get_calibration(self.config.depth_mode, self.config.color_resolution, calibration)
#File "../pyKinectAzure\pyKinectAzure.py", line 280, in device_get_calibration
#_k4a.VERIFY(self.k4a.k4a_device_get_calibration(self.device_handle,depth_mode,color_resolution,calibration),"Get calibration failed!")
OSError: exception: access violation writing 0x0000000000000080
o3d_Intrinsic = o3d.camera.PinholeCameraIntrinsic
o3d_Intrinsic.width = cali.depth_camera_calibration.intrinsics.parameters.codx
o3d_Intrinsic.height = cali.depth_camera_calibration.intrinsics.parameters.cody
o3d_Intrinsic.fx = cali.depth_camera_calibration.intrinsics.parameters.fx
o3d_Intrinsic.fy = cali.depth_camera_calibration.intrinsics.parameters.fy
o3d_Intrinsic.cx = cali.depth_camera_calibration.intrinsics.parameters.cx
o3d_Intrinsic.cy = cali.depth_camera_calibration.intrinsics.parameters.cy
print(o3d_Intrinsic, cali.depth_camera_calibration.intrinsics.parameters)
`

following, also want to know how to retrieve the Kinect intrinsics!

following, also want to know how to retrieve the Kinect intrinsics!

here is to find the calibration intrinsics: build from source azure sdk using this https://github.com/microsoft/Azure-Kinect-Sensor-SDK/blob/develop/docs/building.md and then build a calibration_info.exe https://github.com/microsoft/Azure-Kinect-Sensor-SDK/tree/develop/examples/calibration which outputs the intrinsics. Hope this helps!

Well my output is as follows:
{"CalibrationInformation":{"Cameras":[{"Intrinsics":{"ModelParameterCount":14,"ModelParameters":[0.5014757513999939,0.49704870581626892,0.49203813076019287,0.49193161725997925,4.72473669052124,3.2092227935791016,0.17059645056724548,5.0558595657348633,4.775780200958252,0.88649415969848633,0,0,0.0001238211989402771,5.87981094213319E-6],"ModelType":"CALIBRATION_LensDistortionModelBrownConrady"},"Location":"CALIBRATION_CameraLocationD0","Purpose":"CALIBRATION_CameraPurposeDepth","MetricRadius":1.7399997711181641,"Rt":{"Rotation":[1,0,0,0,1,0,0,0,1],"Translation":[0,0,0]},"SensorHeight":1024,"SensorWidth":1024,"Shutter":"CALIBRATION_ShutterTypeUndefined","ThermalAdjustmentParams":{"Params":[0,0,0,0,0,0,0,0,0,0,0,0]}},{"Intrinsics":{"ModelParameterCount":14,"ModelParameters":[0.506722092628479,0.51457756757736206,0.47892501950263977,0.63847380876541138,0.40386343002319336,-2.6028842926025391,1.5118778944015503,0.28427526354789734,-2.4207212924957275,1.4354244470596313,0,0,-4.1651688661659136E-5,0.00089407846098765731],"ModelType":"CALIBRATION_LensDistortionModelBrownConrady"},"Location":"CALIBRATION_CameraLocationPV0","Purpose":"CALIBRATION_CameraPurposePhotoVideo","MetricRadius":0,"Rt":{"Rotation":[0.99999916553497314,-0.00080411869566887617,-0.0010013245046138763,0.00089394015958532691,0.99564725160598755,0.09319741278886795,0.00092202425003051758,-0.093198232352733612,0.995647132396698],"Translation":[-0.032077357172966,-0.0019188573351129889,0.0041174949146807194]},"SensorHeight":3072,"SensorWidth":4096,"Shutter":"CALIBRATION_ShutterTypeUndefined","ThermalAdjustmentParams":{"Params":[0,0,0,0,0,0,0,0,0,0,0,0]}}],"InertialSensors":[{"BiasTemperatureModel":[-0.010616951622068882,0,0,0,0.021280378103256226,0,0,0,0.010436063632369041,0,0,0],"BiasUncertainty":[9.9999997473787516E-5,9.9999997473787516E-5,9.9999997473787516E-5],"Id":"CALIBRATION_InertialSensorId_LSM6DSM","MixingMatrixTemperatureModel":[0.9957544207572937,0,0,0,-0.001605906174518168,0,0,0,0.0072632487863302231,0,0,0,-0.001582253840751946,0,0,0,1.0105862617492676,0,0,0,0.00074907898670062423,0,0,0,0.007269588764756918,0,0,0,0.00076094019459560513,0,0,0,0.99488413333892822,0,0,0],"ModelTypeMask":16,"Noise":[0.00095000001601874828,0.00095000001601874828,0.00095000001601874828,0,0,0],"Rt":{"Rotation":[-0.00031475935247726738,0.11594212800264359,-0.99325591325759888,-0.99999648332595825,0.0025804587639868259,0.00061811070190742612,0.0026347208768129349,0.99325263500213623,0.11594090610742569],"Translation":[0,0,0]},"SecondOrderScaling":[0,0,0,0,0,0,0,0,0],"SensorType":"CALIBRATION_InertialSensorType_Gyro","TemperatureBounds":[5,60],"TemperatureC":0},{"BiasTemperatureModel":[-0.01494935154914856,0,0,0,-0.045461028814315796,0,0,0,-0.0642952173948288,0,0,0],"BiasUncertainty":[0.0099999997764825821,0.0099999997764825821,0.0099999997764825821],"Id":"CALIBRATION_InertialSensorId_LSM6DSM","MixingMatrixTemperatureModel":[0.99677795171737671,0,0,0,-8.6717009253334254E-5,0,0,0,-0.0031037656590342522,0,0,0,-8.7303553300444037E-5,0,0,0,0.99007153511047363,0,0,0,0.00033213524147868156,0,0,0,-0.003125463379547,0,0,0,0.00033221009653061628,0,0,0,0.98985821008682251,0,0,0],"ModelTypeMask":56,"Noise":[0.010700000450015068,0.010700000450015068,0.010700000450015068,0,0,0],"Rt":{"Rotation":[0.00087367423111572862,0.11046438664197922,-0.99387967586517334,-0.99999916553497314,0.0010460560442879796,-0.00076279003405943513,0.00095539272297173738,0.99387955665588379,0.11046520620584488],"Translation":[-0.051448330283164978,0.0037394696846604347,0.0014938798267394304]},"SecondOrderScaling":[0,0,0,0,0,0,0,0,0],"SensorType":"CALIBRATION_InertialSensorType_Accelerometer","TemperatureBounds":[5,60],"TemperatureC":0}],"Metadata":{"SerialId":"000565500712","FactoryCalDate":"2/17/2020 11:32:29 AM GMT","Version":{"Major":1,"Minor":2},"DeviceName":"AzureKinect-PV","Notes":"PV0_max_radius_invalid"}}}
How can I get the intrinsic matrix? It is a little confused for me to understand these information


Level 2 step 5 can't get name from google when testting

Hi Guys,
when i'm testting Level 2 step 5 then

Can i help you plz,

I'm also having this issue. Any help is appreciated.


Selection styling isn't cleared after running command

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce

Open a new PowerShell terminal with (pwsh.exe) or without a profile (pwsh.exe -NoProfile).
Write any command, for example cd .
Select all or part of the command, for example with Ctrl+A or Shift+←.
Run the command with Enter.

Expected behavior
The command is deselected and executed.

Actual behavior
The command is executed, but retains the selection styling.

Error details
No response
Environment data
Reproducible both on Windows and Ubuntu in latest stable and latest preview releases, for example these two environments:

Name                           Value
----                           -----
PSVersion                      7.3.0-preview.4
PSEdition                      Core
GitCommitId                    7.3.0-preview.4
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Name                           Value
----                           -----
PSVersion                      7.2.4
PSEdition                      Core
GitCommitId                    7.2.4
OS                             Linux <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Wed Mar 2 00:30:59 UTC 2022
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals

Reproduced only in PSReadline.

I haven't installed PsReadLine. Is it installed and used by default? If yes, should this issue be moved to https://github.com/PowerShell/PSReadLine?


Add spectral rules to check patterns

Note that this also includes a script to strip $refs from patterns before validation. This is necessary as spectral isn't too smart about $refs and will aggressively follow them.
CLI also needs to be updated to run these checks, I will do this later

@jpgough-ms this is pending you resolving the change requests I believe


Add

When create a PR for new measurements to the library, please go the the Preview tab and select the power-profile template:
If you are issuing a new PR for other purpose you can remove all this text.

Power profile

Thanks for the PR.
Could you please update the PR title what you are trying to add. "Add" is not really suffice.
Also I notice you have a lot of old commits, which makes the PR really messy and that's also the reason why there are two profiles included in this PR.
Right procedure would be to first rebase your fork to the powercalc master branch. So everything is synchronous between powercalc repository and your own repository.
I think you can also click "Synchronize fork" button in your github repository.
Next for each profile following it is suggested to create a separate branch. This allows you to create multiple PR's for each bulb.
Example procedure with the command line:

git checkout master (Switch to master branch first)
git checkout -b feat/ikea-LED2106R3 (This created a new branch, and switches to it)
Make your changes, add files to data directory
git add . (Stage all files to be commited)
git commit -m "Add ikea LED2106R3 measurements"
git push --set-upstream origin feat/ikea-LED2106R3
Now you can make a new PR targetting your feat/ikea-LED2106R3 to powercalc master

Rinse and repeat for the other profiles.
You can also create separate branch with Github webpage.
Whenever rework is required for a particular PR you can just switch to that branch, so some additional changes and commit and push. That will update the corresponding PR for this light.


Fresh RN 0.68.2 : Build failed with 2 errors

Describe the bug
Bug at build on 0.68.2 : "FAILURE: Build completed with 2 failures."
1: Task failed with an exception.

Where:
Build file '/.../test_rn_qrscan/node_modules/react-native-camera-kit/android/build.gradle' line: 2

What went wrong:
A problem occurred evaluating project ':react-native-camera-kit'.

Plugin with id 'kotlin-android' not found.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.

What went wrong:
A problem occurred configuring project ':react-native-camera-kit'.

compileSdkVersion is not specified. Please add it to build.gradle

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.
==============================================================================

Get more help at https://help.gradle.org"

To Reproduce
Steps to reproduce the behavior:
1.on a fresh react native 0.68.2 ,  do what is specified on this repo : yarn add ...
2. copy what  is said here https://github.com/teslamotors/react-native-camera-kit
3. yarn run android
Expected behavior
a compilation without problems
Screenshots
Desktop (please complete the following information):

OS: linux

Smartphone (please complete the following information):
it was not that far !
Additional context
no : simple : fresh install on 0.68.2, do that you specify ....simple

hi, same errors on 0.69.1 fresh install.
how can I help to solve that please ?

same on my windows machine that runs many other projects - could be from this project
my Android and java config attached.
RN0691_Win.txt

configuration in link: https://github.com/teslamotors/react-native-camera-kit/blob/master/docs/kotlin.md
it worked for me.

hello,
thank you it works also , !
and  also change  :
minSdkVersion = 23 //changement from 21 to 23


AttributeError: 'EncodedMethod' object has no attribute 'is_external'

_, _, dx = AnalyzeAPK(a.apk)
dcg = dx.get_call_graph()
for node in dcg.nodes()
if node.is_external():
print(node)
AttributeError: 'EncodedMethod' object has no attribute 'is_external'
As per the 3.4 version, there is no is_external() method there.
how to fix it?
I would appreciate it if you could reply to me!

Closing this as the issue is old and the source has substantially changed.
Please feel free to open a new issue if this persists.


Route parameter types

Hello,
This is an awesome work ! It's almost fit my need !
I just found something missing, or maybe i dont understand something.
I use that lib with an express api to get request and response typing. The generator create needed types for request query/body and response body, that perfect, but i miss the request path params.
For exemple, from this schema:
    "/user/{userId}/edit": {
      "get": {
        "operationId": "userEditGet",
        "parameters": [
          {
            "in": "path",
            "name": "userId",
            "schema": { "type": "integer" },
            "required": true,
          }
        ],
        "responses": {
          ...
        }
      },
   }

I'd like to have :
  export namespace UserMeGet {
    export type RequestParams = { userId: number }; // Missing type
    export type RequestQuery = {};
    export type RequestBody = never;
    export type ResponseBody = {
      id: number;
      email: string;
    };
  }

I saw that we can make custom templates and use hook to parse needed things, but maybe i miss something simpler ?
Thanks for your help !

Hello @Fabiencdp !
Thanks for this issue, I'll add RequestParams at next near release!

I think also needs the RequestHeaders type which contains "in": "header" parameters

As quick dirty solution
route-type.eta
<%
const { route, utils, config } = it;
const { _, classNameCase, require } = utils;
const { routeParams } = route;
const { query, payload } = route.request
const { type: responseType } = route.response

const routeDocs = includeFile("./route-docs", { config, route, utils });
const routeNamespace = classNameCase(route.routeName.usage);
const queryType = (query && query.type) || '{}';
const bodyType = (payload && payload.type) || 'never';

const argToTmpl = ({ name, required, schema }) => `${name}${required ? '' : '?'}: ${utils.getInlineParseContent(schema)}`;

%>
/**
<%~ routeDocs.description %>

* <% /* Here you can add some other JSDoc tags */ %>

<%~ routeDocs.lines %>

*/
export namespace <%~ routeNamespace %> {
  export type RequestParams = {
    <%~ routeParams.path.map(argToTmpl) %>
  }
  export type RequestQuery = <%~ queryType %>;
  export type RequestBody = <%~ bodyType %>;
  export type ResponseBody = <%~ responseType %>;
}

@Fabiencdp types RequestParams and RequestHeaders has been added in 5.0.0 for --route-types option!
Thank you for this issue!

Yep !  i tried yesterday on the next release and it work well.
Thanks for your awesome work !


netpbm: 11.3.2 -> 11.3.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for netpbm is: Toolkit for manipulation of graphic images
meta.homepage for netpbm is: https://netpbm.sourceforge.net/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 11.3.3 with grep in /nix/store/x17z8f9gl28xgfyr32axy7bfn24c7pi1-netpbm-11.3.3-bin
found 11.3.3 in filename of file in /nix/store/x17z8f9gl28xgfyr32axy7bfn24c7pi1-netpbm-11.3.3-bin

Rebuild report (if merged into master) (click to expand)

66 total rebuild path(s)

66 package rebuild(s)

First fifty rebuilds by attrpath
asciidoc-full
asciidoc-full-with-plugins
auto-multiple-choice
bicgl
bicpl
cantor
clevis
conglomerate
cqrlog
denemo
diffoscope
diffoscopeMinimal
disorderfs
ezminc
fbcat
foomatic-db-ppds
foomatic-db-ppds-withNonfreeDb
fped
frescobaldi
img2pdf
kakounePlugins.rep
kstars
labplot
latex2html
libsForQt5.cantor
lilypond
lilypond-unstable
lilypond-unstable-with-fonts
lilypond-with-fonts
luksmeta
manga-cli
mpvScripts.convert
mup
netpbm
ocrmypdf
oobicpl
paperless-ngx
pcb
pdfarranger
pfstools
plasma5Packages.cantor
pnglatex
polymake
protontricks
pynac
python310Packages.img2pdf
python310Packages.ocrmypdf
python310Packages.pnglatex
python311Packages.img2pdf
python311Packages.ocrmypdf

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x17z8f9gl28xgfyr32axy7bfn24c7pi1-netpbm-11.3.3-bin \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A netpbm https://github.com/r-ryantm/nixpkgs/archive/d3c1d3f83801c6017be4ba099f833cf38a77b138.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x17z8f9gl28xgfyr32axy7bfn24c7pi1-netpbm-11.3.3-bin
ls -la /nix/store/x17z8f9gl28xgfyr32axy7bfn24c7pi1-netpbm-11.3.3-bin/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings

Result of nixpkgs-review pr 250323 run on x86_64-linux 1

7 packages marked as broken and skipped:

cqrlog
ezminc
pfstools
pfstools.dev
pfstools.man
spring
springLobby

2 packages failed to build:

sage
sageWithDoc

72 packages built:

asciidoc-full
asciidoc-full-with-plugins
asciidoc-full-with-plugins.dist
asciidoc-full.dist
auto-multiple-choice
bicgl
bicpl
cantor (libsForQt5.cantor ,plasma5Packages.cantor)
clevis
clevis.man
conglomerate
denemo
diffoscope
diffoscope.dist
diffoscope.man
diffoscopeMinimal
diffoscopeMinimal.dist
diffoscopeMinimal.man
disorderfs
fbcat
foomatic-db-ppds
foomatic-db-ppds-withNonfreeDb
fped
frescobaldi
frescobaldi.dist
img2pdf (python310Packages.img2pdf)
img2pdf.dist (python310Packages.img2pdf.dist)
rep (kakounePlugins.rep)
kstars
labplot
latex2html
lilypond
lilypond-unstable
lilypond-unstable-with-fonts
lilypond-with-fonts
luksmeta
manga-cli
mpvScripts.convert
mup
netpbm
netpbm.bin
netpbm.dev
ocrmypdf (python310Packages.ocrmypdf)
ocrmypdf.dist (python310Packages.ocrmypdf.dist)
oobicpl
paperless-ngx
pcb
pdfarranger
pdfarranger.dist
pnglatex (python310Packages.pnglatex)
pnglatex.dist (python310Packages.pnglatex.dist)
polymake
protontricks
protontricks.dist
pynac
python311Packages.img2pdf
python311Packages.img2pdf.dist
python311Packages.ocrmypdf
python311Packages.ocrmypdf.dist
python311Packages.pnglatex
python311Packages.pnglatex.dist
singular
sng
solfege
steamtinkerlaunch
tang
tang.man
tests.testers.nixosTest-example
tests.testers.runNixOSTest-example
tests.trivial-builders.references
xplanet
yad

Not sure about the build failure. Should we merge either way?

I don't want to get too deep into it because the sage build took quite a while, but it looks like it works on master.
https://hydra.nixos.org/build/231994495

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for netpbm is: Toolkit for manipulation of graphic images
meta.homepage for netpbm is: https://netpbm.sourceforge.net/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 11.3.4 with grep in /nix/store/ggg4y4c4h6zw454b7awp8za55sf4x4cz-netpbm-11.3.4-bin
found 11.3.4 in filename of file in /nix/store/ggg4y4c4h6zw454b7awp8za55sf4x4cz-netpbm-11.3.4-bin

Rebuild report (if merged into master) (click to expand)

66 total rebuild path(s)

66 package rebuild(s)

First fifty rebuilds by attrpath
asciidoc-full
asciidoc-full-with-plugins
auto-multiple-choice
bicgl
bicpl
cantor
clevis
conglomerate
cqrlog
denemo
diffoscope
diffoscopeMinimal
disorderfs
ezminc
fbcat
foomatic-db-ppds
foomatic-db-ppds-withNonfreeDb
fped
frescobaldi
img2pdf
kakounePlugins.rep
kstars
labplot
latex2html
libsForQt5.cantor
lilypond
lilypond-unstable
lilypond-unstable-with-fonts
lilypond-with-fonts
luksmeta
manga-cli
mpvScripts.convert
mup
netpbm
ocrmypdf
oobicpl
paperless-ngx
pcb
pdfarranger
pfstools
plasma5Packages.cantor
pnglatex
polymake
protontricks
pynac
python310Packages.img2pdf
python310Packages.ocrmypdf
python310Packages.pnglatex
python311Packages.img2pdf
python311Packages.ocrmypdf

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ggg4y4c4h6zw454b7awp8za55sf4x4cz-netpbm-11.3.4-bin \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A netpbm https://github.com/r-ryantm/nixpkgs/archive/916e8c9ae57e011922a7b69bfc4d2873523bfe8b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ggg4y4c4h6zw454b7awp8za55sf4x4cz-netpbm-11.3.4-bin
ls -la /nix/store/ggg4y4c4h6zw454b7awp8za55sf4x4cz-netpbm-11.3.4-bin/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings


Exchange EtherDelta: Switch to the new WebSocket API

I could use help on this one...

https://github.com/forkdelta/backend-replacement/issues/34
Thanks Nizero

ForkDelta API Reference: https://www.reddit.com/r/ForkDelta/comments/7pen41/api_for_forkdelta/


Cannot read property '_view' of undefined

When all data is null:
  type: 'line',
  data: {
    labels: ['A', 'B', 'C', 'D', 'E', 'F', 'G'],
    datasets: [{
      label: 'Foo',
      data: [null, null, null, null, null, null, null]
    }]
  },

It is working well in v2.2.0. Working Plunker
But it throw the error below in v2.2.1. Bug Plunker, and crash the app.
You can see the error in your console:

Cannot read property '_view' of undefined

I have a fix in #3067

+1.

Same error when the application was uploaded on the server but works fine on the local server in Laravel framework


Problem in adjust gamma function (tf.image.adjust_gamma)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Not applicable (NA)
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): NA
TensorFlow version (use command below):  2.5.0
Python version: NA
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: NA
GPU model and memory: NA

Describe the current behavior
Pixels values are manipulated using this equation: Out = gain * In**gamma
Describe the expected behavior
This function should preserve range of pixel values by first converting them between 0 and 1 and then again rescaling back to original range or atleast provide an argument for preserving range.
Contributing

Do you want to contribute a PR? (yes/no):  yes

@tejal567 ,
In order to expedite the trouble-shooting process, could you please provide the complete code and dataset to reproduce the issue reported here.Thanks!

You can take any image and call tf.image.adjust_gamma on it. You will see that range of image pixel values is changed. This should not happen. Suppose a person calls this function on RGB images where pixel value of each channel is between 0 and 255. After using this function it will no longer remain between 0 and 255. We can provide an argument in this function to preserve range.

@tejal567 ,
Without the reproducible code, it would be difficult for us to debug the issue. In order to expedite the trouble-shooting process, could you please provide a minimal code snippet you are using.Thanks!


teamcity coverage reporter

Module
jest 22.0.4

Config

"jest": {
    "collectCoverage": true,
    "coverageDirectory": "target/coverage",
    "coverageReporters": [
      "teamcity"
    ]
  }

Problem
No reports are generated. target/coverage folder not even created.

Note
Using the default coverage reporter, lcov, generates the reports

"jest": {
    "collectCoverage": true,
    "coverageDirectory": "target/coverage",
  }

How is this related to jest? If a teamcity reporter isn't working, that should be reported over there (I don't know which package it is)


Fix colour swatch styles for IE8

By default static breakpoints is set to desktop and those media queries get rasterised.
For colour swatches we have a custom breakpoint that is higher than desktop so IE8 never gets those styles.
To fix, we check if $govuk-is-ie8 == true and if true we set the custom breakpoint to match desktop.
Before

After

You can preview this change here:
Built with commit a841402758303cb047a89c15821b8c4a91167ba4
https://deploy-preview-276--govuk-design-system-preview.netlify.com

Since Jani is on Holiday, and this is broken in production, I'll merge.

🎉