Csdk 74: Add callback to ds3_client for net_callback, and refactor out GHashTable from ds3_net.c::net_process_request()

This is not a "real" pull request in that its not ready to be merged, but it is ready for code review.
Also, this diff format may help with the memory leak that valgrind has exposed and I've been unable to track down:
9974 ==20480== 920 (440 direct, 480 indirect) bytes in 5 blocks are definitely lost in loss record 102 of 103
9975 ==20480==    at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
9976 ==20480==    by 0x533B610: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
9977 ==20480==    by 0x535122D: g_slice_alloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
9978 ==20480==    by 0x532517D: g_hash_table_new_full (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
9979 ==20480==    by 0x50E6F9F: ds3_map_init (ds3_net.c:318)
9980 ==20480==    by 0x50E7F01: net_process_request (ds3_net.c:616)
9981 ==20480==    by 0x50E49A7: ds3_allocate_chunk (ds3.c:2142)
9982 ==20480==    by 0x4157A8: bad_checksum::test_method() (negative_tests.cpp:413)
9983 ==20480==    by 0x415620: bad_checksum_invoker() (negative_tests.cpp:383)
9984 ==20480==    by 0x409633: boost::unit_test::ut_detail::unused boost::unit_test::ut_detail::invokerboost::unit_test::ut_detail::unused::invoke<void ()()>(void (&)()) (callback.hpp:56)
9985 ==20480==    by 0x409513: boost::unit_test::ut_detail::callback0_impl_t<boost::unit_test::ut_detail::unused, void (*)()>::invoke() (callback.hpp:89)
9986 ==20480==    by 0x4E9F1F0: ??? (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.54.0)
9987 ==20480==.
This issue is always in ds3_map_init(), and happens with all the calls that provide a headers struct to fill:
ds3_get_available_chunks()
ds3_head_object()
ds3_get_object_with_metadata()
ds3_allocate_chunk()

==13199== LEAK SUMMARY:
==13199==    definitely lost: 0 bytes in 0 blocks
==13199==    indirectly lost: 0 bytes in 0 blocks
==13199==      possibly lost: 0 bytes in 0 blocks
==13199==    still reachable: 2,550 bytes in 16 blocks
==13199==         suppressed: 0 bytes in 0 blocks
==13199==
==13199== For counts of detected and suppressed errors, rerun with: -v
==13199== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
denverm@dm-lt:~/code/github/ds3_c_sdk/test$


Have the boss shoot regular bullets at just you during the circular bullet attack to prevent camping

When the boss is using his circular bullet attack, it's very easy to stand still and press shift in time with the waves. If he shot a small stream of bullets that targetted you individually at the same time then it would discourage camping.

I think it's okay as is, lol :) sorry pal


with Html5Mode(true), $state is not working as expect

when Html5Mode is turned on, I found there are somethings are not normal.
Here is the plunker
Before Html5Mode is turned on, $state.current returned the object correctly:
{"url":"","views":{"header-wrapper": {"templateUrl":"header.html","controller":"HeaderCtrl"}},"name":"root"}

However, when it is turned on, it showed:
{"name":"","url":"^","views":null,"abstract":true}

The problems are:

The state name was empty
the views was not loaded at all.
the url is different

I couldn't figure out what I have missed.
Thanks.

I'm using an abstract parent state for application wide dependency resolution, and after a recent push to staging we're seeing this after the user is dropped off from a django login page. Funny thing is if we reload the page, or navigate to any link everything behaves correctly. The first landing state (when I grab the reference via: angular.element(document.querySelector('html')).injector().get('$state') shows the current state as:
current: Object
    abstract: true
    name: ""
    url: "^"
    views: null__proto__: Object

Most confusing. Our dev boxes that don't have the login have no issues whatsoever.

Do you have a <base /> tag in your app? It's probably just an issue with the URL not matching. Adding:
app.run(function($state) {
  $state.go("root");
});

...makes it work fine.


Add 'Testing' and 'Contributing' sections to README

It would be nice to have following sections in README.md:
Running the tests
composer test

To get code coverage report, you can check php-code-coverage dashboard at ./build/coverage/index.html
Contributing
Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Should testing be its own section or should we rather move that into CONTRIBUTING.md?

Right, make sense to move "testing" to CONTRIBUTING.md. Will do PR(s)

PR to update CONTRIBUTING.md: https://github.com/amphp/amp/pull/206


Updating to latest react, using react hooks, converting to functional components from class components

This is only for backup my code purpose only.
If any one to see examples of react hook then use my branch.

I fork this repo and will upgrade


Improved onPaint performance

Use dirtyRects instead of the whole image when onPaint()
Use concurrency::parallel_for to take advantage of multiple cores

I used <ppl.h> but I don't know if it's available on Linux, the github build passed.
I only tested it on windows.

@eliopark-nsuslab thanks again, I was busy ! I'll test it on Linux tonight :)

@eliopark-nsuslab Concerning ppl.h I do not have it on my Debian they offer ppl.hh :( I dunno why it compiles on my CI (ubuntu). Why not using openmp ?

@eliopark-nsuslab hummmm when merging your commit the Linux CI finally failed lol :) I tried with OpenMP. In the build.py I added a setting (while it would have been better to check if openmp is present). I will check iff it passes CI. If you are interested on an interesting problem is to try to understand why the project a friend of mine made is slow with my CEF and keyboard broken https://www.exaequos.com/  (while the secondary process works well)


Question: How to download music with the highest possible quality with spotdl 4.0.1?

Requested Feature
Hi developers! I recently updated spotdl to version 4.0.1 with python-pip And I've noticed that the way to download music with the highest possible quality has changed. As an example I have a song downloaded with spotdl 3.9.6 with 240 kbps (spotdl <url>) Now that same song using this new version has 128 kbps (spotdl download <url>)
Also in 3.9.6 this command was invoked using yt-dlp: yt-dlp -x --audio-format mp3 --audio-quality 0 <url> But in 4.0.1 this doesn't seem to be the case.
Could any of you help me with this. Thanks!
Possible implementation
No response

+1 I see the bitrate is at 128kbps

Same issue with me - before it was at auto-highest. How do I fix this or do I need to downgrade?

Spotdl never downloads songs in bitrate higher than 128kbps (you can get 256 kbps with ytmusic premium and m4a output format).
In V3 spotdl would re-encode the song with variable bitrate (FFmpeg option -q:a 0). I’ve removed this option in V4 because bitrate option was added so now users can specify the bitrate that they want.

Spotdl never downloads songs in bitrate higher than 128kbps (you can get 256 kbps with ytmusic premium and m4a output format).
In V3 spotdl would re-encode the song with variable bitrate (FFmpeg option -q:a 0). I’ve removed this option in V4 because bitrate option was added so now users can specify the bitrate that they want.

yt-dlp with the best audio option ( yt-dlp -x --audio-format mp3 --audio-quality 0 ) can generate noticeable better AND higher bit rate songs. Also, I don't think that that's the case, since the bitrate seems to vary between songs semi-randomly, not stay at 128kpbs in my library -

Spotdl never downloads songs in bitrate higher than 128kbps (you can get 256 kbps with ytmusic premium and m4a output format).
In V3 spotdl would re-encode the song with variable bitrate (FFmpeg option -q:a 0). I’ve removed this option in V4 because bitrate option was added so now users can specify the bitrate that they want.

I confirm, you can use this command to download your music at 320k kbps (only conversion format not download):
spotdl --bitrate 320k download <url>

Also, I don't think that that's the case, since the bitrate seems to vary between songs semi-randomly, not stay at 128kpbs in my library -

I think this is due to ffmpeg. audio-quality 0 performs a higher bit conversion. However this doesn't seem to affect the source (128k, 192k or 256k).

Spotdl never downloads songs in bitrate higher than 128kbps (you can get 256 kbps with ytmusic premium and m4a output format).
In V3 spotdl would re-encode the song with variable bitrate (FFmpeg option -q:a 0). I’ve removed this option in V4 because bitrate option was added so now users can specify the bitrate that they want.

yt-dlp with the best audio option ( yt-dlp -x --audio-format mp3 --audio-quality 0 ) can generate noticeable better AND higher bit rate songs. Also, I don't think that that's the case, since the bitrate seems to vary between songs semi-randomly, not stay at 128kpbs in my library -

--audio-quality 0 basically just adds -q:a 0 to ffmpeg options for post-processing step.
I can re-add add option to use variable bitrate when re-encoding the songs, but I won't set is as default because I don't want to mislead users into believing that they are getting better quality songs because the bitrate is higher.

I can re-add add option to use variable bitrate when re-encoding the songs

That sound good! To be honest, I feel more comfortable with that option :D The --bitrate <kbps> option is also nice, please don't remove it, just consider re-adding by default the variable bitrate when calling spotdl download <url>

I can re-add add option to use variable bitrate when re-encoding the songs

That sound good! To be honest, I feel more comfortable with that option :D The --bitrate <kbps> option is also nice, please don't remove it, just consider re-adding by default the variable bitrate when calling spotdl download <url>

I will add the vbr option to the bitrate flag (I wasn't planning to remove it). I am not sure if I want to set is as default option for FFmpeg encoding, because producing higher bitrate files that are 2x bigger and don't have any significant change in quality isn't worth it in my opinion. Besides you can use config file to change the bitrate permanently.

I will add the vbr option to the bitrate flag (I wasn't planning to remove it).

Cool! The config file is a great idea. I guess it's okay to add the vbr as a tag, I have no problem with it. Thanks for taking it into account! :D

I confirm it works :
docker run --rm -v $(pwd):/music spotdl/spotify-downloader --bitrate 320k download \
https://open.spotify.com/playlist/xyz

Would it be possible to keep the vorbis format without any conversion to mp3 ?

What do you mean by this, the files we download from youtube are either webm/m4a. If you don't want any conversion you can use --format flac/m4a because they don't re-encode the files (also they are way faster because ffmpeg only copies the audio stream from one file to another)

I thought this app was downloading files from Spotify :-p . My bad.

Variable bitrate option has been added in v4.0.2, also now files should have slightly better bitrate in some cases than in the previous versions.

Would it be possible to keep the vorbis format without any conversion to mp3 ?

What do you mean by this, the files we download from youtube are either webm/m4a. If you don't want any conversion you can use --format flac/m4a because they don't re-encode the files (also they are way faster because ffmpeg only copies the audio stream from one file to another)

Just found your comment. Yesterday I opened an feature request because I couldn't find a way to avoid the ffmpeg conversion.
I did try using "--format m4a" and not specifying bitrate, but conversion is made anyway.
Could this be a bug?

Have you tried changing "ffmpeg" to "false" in the config.json file; linux path: $HOME/.spotdl?

Have you tried changing "ffmpeg" to "false" in the config.json file? (Linux path: $HOME/.spotdl)

Just did. Setting it to "false" gives me an error:
FFmpegError: FFmpeg is not installed. Please run spotdl --download-ffmpeg to install it, or spotdl --ffmpeg /path/to/ffmpeg to specify the path to ffmpeg.
Setting it to false (unquoted) returns:
TypeError: expected str, bytes or os.PathLike object, not bool
I'm on Windows, python 3.11, spotdl 4.0.5.
command is:
spotdl download {link} --format "m4a"

I did a search in the repository and found this thread. Basically there are no plans to implement this option; spotdl will always use ffmpeg. You can edit "format": "mp3" to "m4a", if you want to get this format.
If you don't know what changes you made in config.json, I recommend to use: spotdl --generate-config, to return to default values and edit only this option.
I hope this is helpful.

Thank you for your answer. Looking at the code I think I understand what's happening.
Because of the if statement on:
https://github.com/spotDL/spotify-downloader/blob/8f7cb2a7ab13f1244d1b9abc6635ccaa14b01ba7/spotdl/download/downloader.py#L448
self.bitrate is being set at 129k.
This means when the function convert is called, bitrate has a value. So
https://github.com/spotDL/spotify-downloader/blob/8f7cb2a7ab13f1244d1b9abc6635ccaa14b01ba7/spotdl/utils/ffmpeg.py#L285
is False, so the args that tells ffmpeg to copy the stream are not being passed.
I've commented out the if statement on line 448 in downloader.py, and conversion is now being disabled (since I specify "m4a" as the format).
I'm not sure if this change breaks something else, but it is working for me.

Great! I guess this would be a temporary solution. Let's see what happens, and as you say hopefully the change won't break the code.

That's a bug, next version will add --preserve-audio option to skip the conversion step for m4a and opus files.

Variable bitrate option has been added in v4.0.2, also now files should have slightly better bitrate in some cases than in the previous versions.

Hi, im using the .exe 406 windows file but besides the mp3 option i cant change the bitrate to 320kbps? When using cli there isnt an options choice... And the download only downloads 128kbps files. Is this normal or can this be changed?

Variable bitrate option has been added in v4.0.2, also now files should have slightly better bitrate in some cases than in the previous versions.

Hi, im using the .exe 406 windows file but besides the mp3 option i cant change the bitrate to 320kbps? When using cli there isnt an options choice... And the download only downloads 128kbps files. Is this normal or can this be changed?

what does spotdl --help return?

Variable bitrate option has been added in v4.0.2, also now files should have slightly better bitrate in some cases than in the previous versions.

Hi, im using the .exe 406 windows file but besides the mp3 option i cant change the bitrate to 320kbps? When using cli there isnt an options choice... And the download only downloads 128kbps files. Is this normal or can this be changed?

what does spotdl --help return?

Found it. Changed bitrate to 320K in the config file. Thanks


Allow ShootedSeed .spec.provider to be specified from "shoot.garden.sapcloud.io/use-as-seed" annotation

Currently shoot.garden.sapcloud.io/use-as-seed allows specifying Seed taints, parts of seed spec.
But the .spec.provider section of the Seed is populated according to the Shoot spec.
https://github.com/gardener/gardener/blob/5f4ccba25c2b1912e3eecb0db0a05f5f3e039c6c/pkg/gardenlet/controller/shoot/seed_registration_control.go#L311-L315
It might be handy in some cases to be able to specify .spec.provider.type and .spec.provider.region to allow ShootedSeed on given provider to have scheduled Shoots from a different provider type.

Should we close this one for now? Or do you really want to implement this?

/close


The naming convention of the maven artifacts is not good

From<EMAIL_ADDRESS>on February 10, 2010 16:44:37
Suggested changes are:
The groupId of all the artifacts should be: 'org.powermock'
What is the point of having a groupId if there is only one artifact per group?
This will allow better build tools than maven to use this naming convention:
Example:
group %w(powermock-utils powermock-api powermock-reflect), :under =>
'org.powermock', :version => '1.3.5'
The name of compound artifacts such as powermock-easymock-1.3.5-full.jar
should be: 'powermock-easymock-full-1.3.5.jar'
'full' is a description of the artifact and not part of a version.
Original issue: http://code.google.com/p/powermock/issues/detail?id=234

From<EMAIL_ADDRESS>on February 10, 2010 23:41:34
We're aware of this and I agree fully.
Status: Accepted
Labels: Milestone-Future

From<EMAIL_ADDRESS>on October 03, 2010 10:02:12
Status: Fixed


Add ACS airflow dag and terraform config

This is dependent on #162 , will update the diff once #162 is submitted


Fix useDndScroll when componentRef.current is initialized with null

if componentRef.current is initially null,   ScrollingMonitor will not initiate when ref changes later

@RHOOPH thanks! this is fixed in https://github.com/TechStark/react-dnd-scrolling/commit/a619edcaa7376b30c1534c920374c2fee6bfbb09


Use Function("return this") to get global?

Backbone currently breaks in 'strict' mode while trying to access properties on the global object. The global object is being set using the (function(root) { ... })(this) pattern. However, in this case, root remains undefined and hence the issue.
Using the Function("return this")() pattern instead alleviates the issue, though arguably ugly. Thoughts?
Steps to reproduce: Import backbone in a babel-jest test harness. (uses strict mode)

This issue affects Underscore as well. Relevant issue: jashkenas/underscore#2152


STU3 -> R4 Conversion Medication Request Date Issue

When using the STU3 -> R4 template for conversion.   I received an error trying to load the transformed data into the MSFT FHIR server.  The issue is specific to the date being converted occurrence date time.  This is data created with Synthea.
STU3 - Data for immunication
"fullUrl": "urn:uuid:9f5a4cc9-2d28-c259-3f74-9d4f76b7b0ba",     "resource": {       "resourceType": "Immunization",       "id": "9f5a4cc9-2d28-c259-3f74-9d4f76b7b0ba",       "status": "completed",       "notGiven": false,       "vaccineCode": {         "coding": [ {           "system": "http://hl7.org/fhir/sid/cvx",           "code": "140",           "display": "Influenza, seasonal, injectable, preservative free"         } ],         "text": "Influenza, seasonal, injectable, preservative free"       },       "patient": {         "reference": "urn:uuid:3d869c88-c6bb-443d-0c35-924c131af87c"       },       "encounter": {         "reference": "urn:uuid:c9894b58-a8c7-45ee-4168-71860a5d29ad"       },       "date": "2022-04-05T03:06:43-04:00",       "primarySource": true     },     "request": {       "method": "POST",       "url": "Immunization"     }   } ] }
R4 - Converted Data
{       "fullUrl": "urn:uuid:9f5a4cc9-2d28-c259-3f74-9d4f76b7b0ba",       "resource": {         "resourceType": "Immunization",         "id": "9f5a4cc9-2d28-c259-3f74-9d4f76b7b0ba",         "status": "completed",         "vaccineCode": {           "coding": [             {               "system": "http://hl7.org/fhir/sid/cvx",               "code": "140",               "display": "Influenza, seasonal, injectable, preservative free"             }           ],           "text": "Influenza, seasonal, injectable, preservative free"         },         "patient": {           "reference": "urn:uuid:3d869c88-c6bb-443d-0c35-924c131af87c"         },         "encounter": {           "reference": "urn:uuid:c9894b58-a8c7-45ee-4168-71860a5d29ad"         },         "primarySource": true,         "occurrenceDateTime": "4/5/2022 7:06:43 AM"       },       "request": {         "method": "POST",         "url": "Immunization"       }     }   ]
The Error when loading
{     "resourceType": "OperationOutcome",     "id": "8dc1e8bab75040651048e4442e8cad73",     "meta": {         "lastUpdated": "2023-02-15T20:03:39.1047298+00:00"     },     "issue": [         {             "severity": "error",             "code": "invalid",             "diagnostics": "Error occurred when parsing model: 'Type checking the data: Literal '2/18/2014 7:06:43 AM' cannot be parsed as a dateTime. (at Resource.entry[81].resource[0].occurrenceDateTime[0])'."         }     ] }
Perhaps the STU3 -> R4 Template could be modified to:
"occurrenceDateTime" : "{{ msg.date | date: "yyyy-MM-ddTHH:mm:ss.fff%K" }}",

Investigated the issue, the root cause is:

The value get converted at here: https://github.com/microsoft/FHIR-Converter/blob/main/data/Templates/Stu3ToR4/Immunization.liquid#L18
the Datetime type was converted to String type from here: https://github.com/dotliquid/dotliquid/blob/master/src/DotLiquid/Variable.cs#L75
The default IFormatProvider was used, so it didn't get printed out in expected format.

Now I'm exploring the fixing options.

@dadams300 Please feel free to use the code you pointed out when you run this template outside of the Azure FHIR service. I have tested it and it should work. But if you work depends on the Azure FHIR service, it will take some time.
In the meantime, I'm exploring other long-term solutions.

We have a few longer-term options but those would require more fundamental refactoring. The template update seems the best temporary solution at this point. It's consistent with the design and the usage of it in other templates as well.
@dadams300 Please feel free to submit a PR if you wanted. Thank you!

There is no response from the user who originally reported this issue and proposed the code to fix, I'm going to create a PR.

https://github.com/microsoft/FHIR-Converter/pull/461


Unify StorageKey and CacheKey

Description
Currently, StorageKey and CacheKey are equivalent types. They historically were different, but as the implementation evolved, they converged to have the same. However, StorageKey implements serialization, whereas CacheKey doesn't.
This limits our implementation as the conversion between the types may force us to take the key as owned for simple operations such as get, when a reference should suffice
https://github.com/Sovereign-Labs/sovereign-sdk/blob/01375688fcf719c5e20f32302374c70469e4dd3e/module-system/sov-state/src/scratchpad.rs#L187
Solution
Deprecate CacheKey and replace its usage by StorageKey. This will allow us to pass references downstream and make the map API more powerful, as the types are just borrowed references and can be passed downstream without any conversion. This will unlock a simplification requested on #427
Alternatives
We could unsafely cast one type to the other, but we have no clear gain to maintain the distinction and would create a potential undefined behavior if the layout of any of the types ever change. This would create a maintenance burden to cross-check both types whenever they are updated.
A working alternative suggested by @preston-evans98 is to use yoke to cast one type to the other. This will allow a zero-cost solution and will preserve both types, in case we want to maintain the distinction. The CacheKey is currently used for memory-only representation, and StorageKey is used for serialization. It might be desirable to maintain this domain separation if we want to have a layer that don't interact with I/O.

We could even have a single type StoargeSlot for keys and values.

As discussed on today's daily:

Keep Key and Value types for semantic
Rename CacheKey and CacheValue to SlotKey and SlotValue
Remove StorageKey and StorageValue in favour of SlotKey(previously CacheKey) and SlotValue (previously CacheValue)


App Framework forms with Integration Selector

Summary
This PR combines the contents of:

https://github.com/mattermost/mattermost-mobile/pull/6716
https://github.com/mattermost/mattermost-mobile/pull/6735

These efforts were done in parallel, but need to be properly tested together.
Ticket Link
Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on:
Screenshots

Release Note

Building app in separate branch.

@javaguirre @DHaussermann I created a branch off of my PR, and merged Javi's PR's contents into there, and created this PR with the result. The last 4 commits on this PR were needed to fix some things specific to App forms.
We can use this PR as the main testing branch to help find any remaining issues with the open PRs.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/26308
https://circleci.com/gh/mattermost/mattermost-mobile/26307

Artifact links:
https://output.circle-artifacts.com/output/job/6cd0ae9b-0a62-449d-b99f-0732d61f87b3/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/14c23ae2-bd9f-4919-a825-cc96be52ce90/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

Closing since https://github.com/mattermost/mattermost-mobile/pull/6716 has since been merged


menu: current file's folder menu item fix

For https://github.com/JunoLab/atom-julia-client/issues/649

thanks for the fix !


Add STDistanceSphere and Test to MySql

You have protected $platforms = array('mysql');  and  $this->supportsPlatform('postgresql'); in your test. Is it a typo ?

Hi @reneszabo  Please have a look at the tests https://travis-ci.org/creof/doctrine2-spatial/jobs/136486440#L310

I could use this.
@reneszabo are you able to fix that typo?

would be nice to have this :)


[FIXED JENKINS-37477] - Docs and snippet generator work properly for triggers.

JENKINS-37477

[x] Fix doc generation.
[x] Fix snippet generator

Snippet generator still not working, so more work to do.
cc @reviewbybees esp @jglick @kwhetstone

Note that I can't do a SNAPSHOT deploy any more thanks to changes to Artifactory configuration, so the PR I'm going to make on multibranch for the snippet generator fix eventually will fail. yay.

:bee:

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

:bee:

:bee:

Hmm, I don't think I saw any errors running locally. Retrying locally to make sure...

I was wrong. There are errors. Fun!

Yeah, so, dumb me, I looked at the wrong tab and was looking at test results before changing the config.jelly. Sigh! reconfigure is fixed now, so the tests should pass.

:bee:

re:bee:

:bee:

re:bee:


Reconciliation does not react on CR update

Reconciliation does not react on CR update

Build keda-manager
Apply kedas.operator.operator.kyma-project.io CRD on kubernetes cluster
Run operator
Apply sample kedas.operator.operator.kyma-project.io resource (config/samples)
Edit keda-sample resource and update operator logging level

spec:
  releaseName: "testM3"
  logging:
    operator:
      level: "info"

Result:

reconciliation loop is not called
re-installation is not triggered

It is not by design that you upgrade the crd during runtime without upgrading your operator to be able to deal with the upgraded crd. Thus it is not expected that the operator is reacting to the reconciliation update with a watch.

I think you mean CR :)
Yes :)

yes a typo,
the description was ok =)

This is due to the Ready / Error state not being implemented, @adityabhatia will look into this

It looks like the issue was not fix for us - it was reproduced in tests in this PR

Waiting for feedback from @m00g3n

Expecting that this got fixed, closing

Reopening as issue is not confirmed fix by @pPrecel Will get back here once I was able to confirm

Module-manager does not react to the CR deletion as well and it's not uninstalling previously installed components. Is it anything correlated or should I create a separate ticket?

Please leave the ticket here until I find out more.
Currently I noticed that the cached manifest.yaml is not rerendered, causing failure. I will propose a fix for this. After this I will take care of checking uninstallation. Sorry for the inconvenience.

Regarding the cleanup during deletion of the CR, keda-manager is missing a finalizer to listen on, e.g.:
For https://github.com/kyma-project/keda-manager/blob/main/controllers/keda_controller.go#L75-L79
Just inject a finalizer
return r.Inject(
		mgr, &v1alpha1.Keda{},
		declarative.WithManifestResolver(manifestResolver),
		declarative.WithResourcesReady(true),
		declarative.WithFinalizer("keda-manager.kyma-project.io/deletion-hook"),
)

After that declarative will wait in the deleting step for the finalizer and remove resources normally


For people unfamiliar with Lua syntax and lspconfig

Further suggestion from discussion in #382

Sorry. I'm closing this for now.


Element must be visible, or offset() will bring user to top of screen.

In case element is not visible offset() will return top:0, left:0
Use case: <input type="radio" required> where the first radio-item is
"hidden" in a collapsable div.
If you don't like this change, I can make a feature like
$.fn.validator.Constructor.INPUT_SELECTOR, but then for focusError.

I have the same problem. This PR is correct and should be merged.


STT Start Media | media_type

I've been getting this error when trying to set up Stream Assist with Fully Kiosk when sending an .mp3 sound through STT Start Media
Logger: homeassistant.core
Source: core.py:2751
First occurred: 2:14:55 PM (4 occurrences)
Last logged: 2:26:53 PM

    Error executing service: <ServiceCall media_player.play_media (c:01J276FX6EVF355SX82MY2SETE): entity_id=['media_player.lenovots_1'], extra=, media_type=audio, media_id=media-source://media_source/local/system-notification-199277.mp3>
    Error executing service: <ServiceCall media_player.play_media (c:01J276JN7N5CG4F8ZQYM3HP8R0): entity_id=['media_player.lenovots_1'], extra=, media_type=audio, media_id=media-source://media_source/local/system-notification-199277.mp3>
    Error executing service: <ServiceCall media_player.play_media (c:01J276Q38F10M26N8K49EXBPKJ): entity_id=['media_player.lenovots_1'], extra=, media_type=audio, media_id=media-source://media_source/local/system-notification-199277.mp3>
    Error executing service: <ServiceCall media_player.play_media (c:01J2775T601G3N18YH84331DHJ): entity_id=['media_player.lenovots_1'], extra=, media_type=audio, media_id=media-source://media_source/local/system-notification-199277.mp3>

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/core.py", line 2751, in _run_service_call_catch_exceptions
    await coro_or_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 2774, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 999, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1071, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/fully_kiosk/media_player.py", line 75, in async_play_media
    raise HomeAssistantError(f"Unsupported media type {media_type}")
homeassistant.exceptions.HomeAssistantError: Unsupported media type audio

When trying to replicate the service call that sends the .mp3 file over I notice that I get the same error when the content type is set to "audio".
However if i change it to "music", the error goes away and the .mp3 sound goes through without an issue.
service: media_player.play_media
target:
  entity_id: media_player.<media_player ID>
data:
  media_content_id: media-source://media_source/local/system-notification-199277.mp3
  media_content_type: music

Is there a way to change the Content Type in StreamAssist to send as "music" instead of audio to play nice with Fully Kiosk, or is there a setting im missing in Fully Kiosk that allows this Content Type through?

Adding some potential background that another user found may be the culprit via the View Assist discord

I'll leave only #36


Panic when encountering invalid UTF-8

It looks like the test suite for gpgme in nixpkgs outputs some broken UTF-8. colmena crashes when encountering that broken UTF-8 while using the -v flag:
aether.delroth.net | make[4]: Entering directory '/build/gpgme-1.17.0/tests/gpgsm'
<snip>
aether.delroth.net | BGk8wz3wVNQNL5C4mNEY69iyT0YVspSD
aether.delroth.net | -----END CERTIFICATE-----
aether.delroth.net | End Result.
aether.delroth.net | Begin Result:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: InvalidData, error: "stream did not contain valid UTF-8" }', src/util.rs:216:53
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Using colmena v0.2.2 from nixpkgs.

Thanks for the report! I've made it tolerate invalid UTF-8 (replace invalid sequences with \u{fffd}), which is acceptable for human-readable log outputs.


php 8 and pico not good

When running a default install of pice on xampp with php 8 I get this error:
Fatal error: Unparenthesized a ? b : c ? d : e is not supported. Use either (a ? b : c) ? d : e or a ? b : (c ? d : e) in C:\portable\XAMPP\xampp\htdocs\pico\vendor\twig\twig\lib\Twig\Node.php on line 42
Now in version 7 this Unparenthesized  stuff was named 'depreceated' already, so  the current pico will not run on php 8. I suppose

Please try Pico v3.0.0-alpha.2. There are no functional changes in comparison to stable v2.1.4 besides updated dependencies (which come with some, but rather small functional changes). This version is safe to use in production due to the very limited changeset, specifically aiming for Pico to support PHP 8.0+.


Create issue template to redirect people to TheCBProject

This issue template will show up in the submission box when people try to submit an issue here.
It should help with the confusion between the two projects.

@Chicken-Bones can you please pull this so people are directed to the right issue tracker?

@mezz @Chicken-Bones do it for all repos?


NavigationViewItems ignore Foreground property when in Top mode

Describe the bug

Setting the Foreground property of a NavigationViewItem has no effect when its parent NavigationView is in Top display mode.
Steps to reproduce the bug

Create simple repro app.
<muxc:NavigationView PaneDisplayMode="Top" x:Name="TestNavigationView">
    <muxc:NavigationView.MenuItems>
        <muxc:NavigationViewItem Icon="Home" Tag="Home" Content="Home" Foreground="Purple"/>
    </muxc:NavigationView.MenuItems>
</muxc:NavigationView>

Expected behavior

Icon and "Home" text foreground should be Purple.
Screenshots

Version Info

NuGet package version:

2.4.0-prerelease.200203002
Additional context

Issue ported from internal bug and originally reported by a customer on https://docs.microsoft.com/answers/questions/4461/uwp-navigationview-items-foreground-color-not-work.html
The problem does not repro when NavigationView is in Left / Auto display mode.

I think the reason for this bug is the following line in the NavigationViewPresenter style for DisplayModeTop:
https://github.com/microsoft/microsoft-ui-xaml/blob/0db781759437ca8580501649bc00ca1dc5f043be/dev/NavigationView/NavigationView_rs1_themeresources.xaml#L954
The corresponding for DisplayMode Left does not explicitly set the ForeGround property.


Support CPython 3.10, drop CPython 3.5

The final release is expected very soon (2021-10-04)

Number of downloads for Python 3.5 is very low, should be safe to remove it soon.
The majority of users seems to use 3.7 or 3.8.

Is there something I can do to help publish 3.10?

I think it would be nice to not use the python version as part of the pypi wheel tag, e.g. replace cp39-cp39 with py3. Right now when a new version of Python is released, users get a very old version of opendssdirect. This is what happens when I remove the dependency dss_python from opendssdirect:
Installing collected packages: OpenDSSDirect.py
  Attempting uninstall: OpenDSSDirect.py
    Found existing installation: OpenDSSDirect.py 0.2.14
    Uninstalling OpenDSSDirect.py-0.2.14:
      Successfully uninstalled OpenDSSDirect.py-0.2.14
  Running setup.py develop for OpenDSSDirect.py
Successfully installed OpenDSSDirect.py-0.6.1

For what it is worth, I downloaded the 3.9 wheel and renamed the file to dss_python-0.10.7.post1-py3-none-macosx_10_9_x86_64.whl, and it worked in 3.10.

I guess just adding wheels for the released versions shouldn't present any issues. Just remember that we can't replace the wheels without incrementing the version tag.

For what it is worth, I downloaded the 3.9 wheel and renamed the file to dss_python-0.10.7.post1-py3-none-macosx_10_9_x86_64.whl, and it worked in 3.10.

We can't rely on that. The CPython limited API would allow that for CFFI and remove the requirement of building separate wheels -- https://github.com/dss-extensions/dss_python/issues/24 -- but Cython still doesn't support it.
We could consider separating the compiled parts of DSS Python into separate modules -- one for the DSS C-API libraries, one for the CFFI backend, one for the Cython backend (this would be good for conda-forge too) -- and use whatever backend is available during import time. Using the limited API, the CFFI backend would be future-proof for a while.
Yet another option is to add a proper source release for DSS Python that downloads the Pascal binaries and builds everything locally. I never did that because nobody asked so far.
I should finally have more time starting next week (big project ending). I'll send you an email regarding lots of changes that need be integrated soon for the next DSS C-API (a lot besides what's in the master branch there). Probably doesn't make sense to launch the new version during the holiday season, but an alpha or beta would be useful to start testing things.

I guess just adding wheels for the released versions shouldn't present any issues.

Great! This works for me. I wonder if there’s some automated way of doing it for releases.
I think a source release would be good but I’m hesitant because people will have a frustrating experience if things don’t work. But also, right now pip silently downloading a older version of OpenDSSDirect is frustrating too. I wish pip / conda said something like “latest version is XXX, but installing YYY because of these constraints”.
I’m also making some helper classes for OpenDSSDirect that should make it easier to get data in a format that user expect. I’ll make a PR and tag you for review.

I'm also interested in this.  I'm attempting to build dss_python with the latest github version of dss_capi.  I'd be happy to contribute a PR for that if there's any interest.  Is there?

For what it is worth, I downloaded the 3.9 wheel and renamed the file to dss_python-0.10.7.post1-py3-none-macosx_10_9_x86_64.whl, and it worked in 3.10.

@kdheepak Good news: the extension modules were all built with Py_LIMITED_API, including the Windows ones. CFFI turned that on a couple of releases ago.
I downloaded the files (Py 3.9, 64-bit for Windows, Linux and macOS), edited the metadata (at least the WHEEL  file needs to be updated, but updating METADATA and RECORD is good too), renamed the .whls, uploaded them to TestPyPI, and tested them just to be sure. Since everything seems to work, I uploaded to the main PyPI.

I wonder if there’s some automated way of doing it for releases.

I didn't find any specific tool for that, but certainly looks like it could be automated without too much trouble.

I'm attempting to build dss_python with the latest github version of dss_capi. I'd be happy to contribute a PR for that if there's any interest. Is there?

@beroset I can merge some of my local changes for DSS Python and prepare a preview release for the latest public version of DSS C-API.
I'll keep working a bit on finishing my local work on DSS C-API during the holidays. A lot of code has been rewritten, so I might just squash nearly everything before pushing the code and preparing another pre-release for more extensive testing.

Sounds good to me.  Let me know if I can be of any help with this.

Happy New Year!
I just uploaded that first pre-release at https://pypi.org/project/dss-python/0.12.0a1/#files
These use Py_LIMITED_API as before but with the correct options during setup ( --py-limited-api cp36), so a single wheel per platform should work fine from Python 3.6 up to 3.10. For ARM (32 and 64-bit), for the time being, I'm building locally, everything else was migrated to GitHub Actions.
If Cython doesn't work with Py_LIMITED_API yet, it could be worth to create a separate package just for the future Cython backend and keep it optional.
For Anaconda, it seems Python 3.10 support is not there yet, but conda-forge seems OK. conda-build (and boa) is slow (>20 min) and error-prone, so I left the builds disabled. It might be worth adding Actions workflows to handle each platform separately, but I'm fine with building the packages locally when a stable release is ready.

Happy New Year!
I just uploaded that first pre-release at https://pypi.org/project/dss-python/0.12.0a1/#files
These use Py_LIMITED_API as before but with the correct options during setup ( --py-limited-api cp36), so a single wheel per platform should work fine from Python 3.6 up to 3.10. For ARM (32 and 64-bit), for the time being, I'm building locally, everything else was migrated to GitHub Actions.
If Cython doesn't work with Py_LIMITED_API yet, it could be worth to create a separate package just for the future Cython backend and keep it optional.
For Anaconda, it seems Python 3.10 support is not there yet, but conda-forge seems OK. conda-build (and boa) is slow (>20 min) and error-prone, so I left the builds disabled. It might be worth adding Actions workflows to handle each platform separately, but I'm fine with building the packages locally when a stable release is ready.


Update Grafana Dashboard

-Replaced old PerfCI-Regression-Summary.json file in perf folder with newly exported PerfCI grafana dashboard
-Added FuncCI-Regression-Summary.json file in func folder, containing newly exported FuncCI grafana dashboard
-Deleted regression-summary.json and benchmark-runner-ci-status-report.json files from func folder

Please change Pr name to meaningful name as 'update grafana dashboard'

done!

@kelchen123, I have updated the Grafana dashboard, can you please update the latest version ?
[Please rebase it before pull]


Change order schema

close #2

@ Document anotation from /src/main/kotlin/com/hrv/mart/orderlibrary/model/OrderResponse.kt is removed as app will not store OrderResponse in mongo db, instead /src/main/kotlin/com/hrv/mart/orderlibrary/model/order/Order.kt and /src/main/kotlin/com/hrv/mart/orderlibrary/model/order/ProductOrdered.kt will be sotred in database

Flow in which these models interact


Add a new show-executables package subcommand for all executables

The swift run subcommand runs executables that come from a variety of places. Typically, users
are expecting to be able to execute products and targets for their package, iterating quickly with
their code changes. You can also run executable products from packages that are part of the
dependency list. It turns out that all of the executable products of the root package's transitive
closure are available.
Discovery of the available executables is limited to either direct inspection of the Package.swift,
the swift package describe, and swift package completion-tool list-executables. However, these
only work to find the executables of the current package, not in the dependent packages. This has
real implications for a package maintainer since duplicate executable names are forbidden among the
closure of the package's dependencies.
Provide the ability to show the complete list of available executables from the package with a new
swift package show-executables subcommand. Qualify executables that aren't in the current package
with their package of origin for traceability purposes. The list can be formatted as JSON so that
this information can be used by third-party tools.

@swift-ci test

@swift-ci test this please

@swift-ci please test this

@swift-ci test

The failure in the macOS smoke test is sourceckit-lsp and appears to be unrelated to this change. @MaxDesiatov do you know how to kick off the windows platform test with the latest changes?

@swift-ci please test windows

@swift-ci test macos


README example built with --features=nightly fails when building quasi_macros

This is the "combine both approaches" text copied directly into a new (otherwise empty) project.
 % cargo build --features nightly
   Compiling serde_codegen v0.5.3
   Compiling quasi_macros v0.3.1
/home/cody/.multirust/toolchains/nightly/cargo/registry/src/github.com-0a35038f75765ae4/quasi_macros-0.3.1/src/lib.rs:19:29: 19:32 error: mismatched types:
 expected `&mut syntex::Registry`,
    found `&mut rustc::plugin::registry::Registry<'_>`
(expected struct `syntex::Registry`,
    found struct `rustc::plugin::registry::Registry`) [E0308]
/home/cody/.multirust/toolchains/nightly/cargo/registry/src/github.com-0a35038f75765ae4/quasi_macros-0.3.1/src/lib.rs:19     quasi_codegen::register(reg);
                                                                                ^~~
/home/cody/.multirust/toolchains/nightly/cargo/registry/src/github.com-0a35038f75765ae4/quasi_macros-0.3.1/src/lib.rs:19:29: 19:32 help: run `rustc --explain E0308` to see a detailed explanation
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
Could not compile `quasi_macros`.

To learn more, run the command again with --verbose.

Realized I needed to do
# correct
cargo build --features nightly --no-default-features

instead of just
# broken
cargo build --features nightly

@jmesmon: Yeah that would be nice. I'll update the readme to mention using --no-default-features so others don't run into this problem.


Add save functionality to ANN module.

Take a look at this
https://lazyprogrammer.me/how-to-save-and-load-a-neural-network-in-tensorflow-deep-learning-tips/

Added by 7492f15


Add support for adding message tag to bubbles to allow sending messag…

…es outside of the 24h window
https://developers.facebook.com/docs/messenger-platform/send-api-reference/tags

Thx, I will look into it this week!

Great, thanks. The ENUM I've added will later be able to be replaced with
an Enum from the FB library, but they are yet to add anything about it.
*Ronen Yacobi *| Co-Founder & CTO
Mobile: +972·54·5207111
Skype: ronen.yacobi
*Download Drippler on the **App Store
https://itunes.apple.com/app/drippler-updates-tips-apps/id619307903
& *Google
Play
https://play.google.com/store/apps/details?id=com.drippler.android.updates
!
On Mon, Apr 10, 2017 at 10:48 AM, Marcel Overdijk<EMAIL_ADDRESS>wrote:

Thx, I will look into it this week!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/marsbits/restfbmessenger/pull/8#issuecomment-292874471,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA8Oub_XfukQTslFh9YjYctwczs57qKZks5rud6ygaJpZM4M4AVv
.

Also raised https://github.com/restfb/restfb/issues/712

Hi @ryacobi I will pick this up as part of Messenger Platform v2.0 update released this week @F8 (https://github.com/marsbits/restfbmessenger/issues/9).

Great, are you merging in the meanwhile?

Hi Marcel,
Any updates?

Hi @ryacobi I will make a new release this weekend.

Closed as per v1.3.0 release.

@ryacobi v1.3.0 is published to Maven Central and should be available soon after sync.
Note I removed the MessageTagEnum in favour of a MessageTag class as the available tag are not limited to the initial 3.


IP Address Rule

Is it possible to include wild cards for the IP address rule?  E.g. 192.168.1.?  When I connect to college I have to use DHCP and it's so far impossible to tell the exact IP I will get, however I know that it's in the 172.16..* range.  Can ControlPlane introduce the ability to use wildcard asterisks in the IP address field?

It does, just not in a way you're probably used to.  The subnet mask value is what you want to change.  In your case, it is probably <IP_ADDRESS> with a subnet mask of <IP_ADDRESS>.  This will include a range of <IP_ADDRESS>  - <IP_ADDRESS>
On Jan 23, 2012, at 6:30 AM, Ollie Armstrong wrote:

Is it possible to include wild cards for the IP address rule?  E.g. 192.168.1.?  When I connect to college I have to use DHCP and it's so far impossible to tell the exact IP I will get, however I know that it's in the 172.16..* range.  Can ControlPlane introduce the ability to use wildcard asterisks in the IP address field?

Reply to this email directly or view it on GitHub:
https://github.com/dustinrue/ControlPlane/issues/125

When I have some time I'll write a better explanation for some of the rules in the wiki.

@dustinrue Thank you for the tip.
BTW, I used Online IP Subnet Calculator to calculate the IP range.


Not very detailed error info when a matcher fails

I'm trying out ShouldI for a new Elixir project I'm working on, and I really like it! However, I'm not very happy with the error I get when a matcher fails. For example, adding a failing matcher in test/context_matcher_test.exs gives me this output:
  1) test having 'another level': should have passing matchers (ContextMatcherTest)
     test/context_matcher_test.exs:2
     ** (ShouldI.MultiError) multiple matcher errors
     stacktrace:
       test/context_matcher_test.exs:2

Is it a feature or a bug that I get no line number information in the stacktrace? Is there any another way of finding out the specific matcher that failed?

Eric, what do you think? Is there an easy way to extract a line number? Can
you point Erik to the right direction for a potential pull request?
-bt
On Thu, May 26, 2016 at 2:55 AM, Erik Timan<EMAIL_ADDRESS>wrote:

I'm trying out ShouldI for a new Elixir project I'm working on, and I
really like it! However, I'm not very happy with the error I get when a
matcher fails. For example, adding a failing matcher in
test/context_matcher_test.exs gives me this output:

test having 'another level': should have passing matchers (ContextMatcherTest)
test/context_matcher_test.exs:2
** (ShouldI.MultiError) multiple matcher errors
stacktrace:
test/context_matcher_test.exs:2

Is it a feature or a bug that I get no line number information in the
stacktrace? Is there any another way of finding out the specific matcher
that failed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/batate/shouldi/issues/31

--
Bruce Tate  |  CTO  |<PHONE_NUMBER>
We are now part of ISA and SoapBoxSample – together leading the way in
online communities, sampling and research. Learn more.
http://www.soapboxsample.com/soapbox-expands-with-recent-acquisition/
icanmakeitbetter*.com* http://icanmakeitbetter.com
Innovation + Research. Made Simple

Fixed in the latest release.


Added a "name" attribute to ObservingBlock

Added a "name" attribute to ObservingBlock, which can be used to assign a user-defined name or ID to a block. Should probably be used in repr as well, if present.

Looks good, thanks @thusser.


Update setup.py

'sklearn' is depreciated, consider replacing it with 'scikit-learn' in the setup.py file.

Thank you!


Datagrid: Fix Dialog

Description

This PR restores the use of the MudDialog component within DataGrid and ensures it will always work correctly when nested within another Dialog.
How Has This Been Tested?

Existing tests pass
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] The PR is submitted to the correct branch (dev).
[ ] My code follows the code style of this project.
[ ] I've added relevant tests.

I'm not liking this test coverage. 😅

I don't know why CodeCov thinks coverage went down so much. I already noticed that it has some glitches. You have JetBrains, don't you? Check with DotCover.
By the way, why is this supposed to be breaking?

I am fine with reverting it back and do not see any significant performance problems with this component inside the data grid. Thanks.


Can't get this working with Webpack

I'm trying to use this package in conjunction with developing components in React Storybook, but I'm getting the following errors:
ERROR in ./~/entities/maps/xml.json
Module parse failed: /Volumes/SuperData/GitHub/react-sketchpad/node_modules/entities/maps/xml.json Unexpected token (1:6)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected token (1:6)

I followed the instructions and installed json-loader, and below is my webpack.config.js:
var path = require('path');
var webpack = require('webpack');

module.exports = {
  devtool: 'eval',
  entry: [
    'webpack-dev-server/client?http://localhost:9000',
    'webpack/hot/only-dev-server',
    './src/index'
  ],
  output: {
    path: path.join(__dirname, 'dist'),
    filename: 'bundle.js',
    publicPath: '/static/'
  },
  plugins: [
    new webpack.HotModuleReplacementPlugin()
  ],
  module: {
    loaders: [
      {
        test: /\.js$/,
        loaders: ['react-hot', 'babel'],
        include: path.join(__dirname, 'src')
      },
      {
        test: /\.json$/,
        loader: 'json',
      },
    ]
  }
};

Am I missing something?

My mistake - I was modifying the main project's webpack config, not React Storybook's!


When i am on docs there is no way to navigate to main website

I think Logo should navigate to main website instead it refering to current page itself : https://docs.lemonsqueezy.com/help

Thank you for your feedback!


quickActionBarDidCancel not being called when user clicks outside the bar

Hello, I hope you're well! I'm having an issue whereby after clicking outside the search bar, it stops showing up on subsequent calls, even though isPresenting is logging the correct values.
In other words, quickActionBarDidCancel is called when the user pressed esc but not when clicking outside the bar. Currently being called as so:
self.quickActionBar.present(placeholderText: "Search...", width: self.screenWidth)

Otherwise when presenting the bar with the completion handler, the statement is logged, but the bar stop showing up on subsequent calls to present.
self.quickActionBar.present(placeholderText: "Search...", width: self.screenWidth) {
			Swift.print("Quick action bar closed")
}

Any help would be greatly appreciated!

If your application is not frontmost (ie the window that accepts events), the quick action bar will not be presented (as the quick action bar window cannot become main window IF the application is not frontmost.)
Using the code you provided in #2, adding
NSApp.activate(ignoringOtherApps: true)

to the start of the toggleSearch function solves the issue.
@objc func toggleSearch(_ sender: Any?) {

   NSApp.activate(ignoringOtherApps: true)

   if quickActionBar.isPresenting {
      // Hide
      quickActionBar.cancel()
   } else {
      // Show
      self.quickActionBar.present(
         parentWindow: nil,
         placeholderText: "Search Filters",
         searchImage: NSImage(systemSymbolName: "books.vertical", accessibilityDescription: "books.vertical"),
         width: min(800, max(500, 200 + 50))
      ) {
         Swift.print("Quick action bar closed")
      }
   }
}

Please let me know if this solves your issue.

I'm not sure whether I should automatically call NSApp.activate(...) when presenting the window (is this more restrictive for the library user?)

Okay I've added the call to the present method within the library.  If you update to the current latest version (4.2.1) this should resolve your issue.

Perfect thank you! I've made changes to the bar to make copy/paste/cut/select all work in the NSTextField even with a menu bar app. I've also modified the appearance (background and height) to make it match Spotlight Search a bit more. Would you like me to submit a pull request?

Absolutely! I’d love to see what you’ve done.


fix #662 repeated loading DataSourceManager

Ⅰ. Describe what this PR did
fix repeated loading DataSourceManager
Ⅱ. Does this pull request fix one issue?

#662 #667
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #750 into develop will increase coverage by 0.09%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #750      +/-   ##
=============================================
+ Coverage      32.31%   32.41%   +0.09%
  Complexity       928      928
=============================================
  Files            230      228       -2
  Lines           9088     9060      -28
  Branches        1103     1103
=============================================
  Hits            2937     2937
+ Misses          5804     5776      -28
  Partials         347      347

Impacted Files
Coverage Δ
Complexity Δ

...libaba/fescar/rm/datasource/DataSourceManager.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../com/alibaba/fescar/rm/datasource/AsyncWorker.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a2824...12d41fc. Read the comment docs.


github.copilot.chat.experimental.codeGeneration.instructions does not seem to be working in workspace settings.json file

Does this issue occur when all extensions are disabled?: No (because then copilot would not work)

VS Code Version: 1.93.1
OS Version: Windows 11

Steps to Reproduce:

Open a workspace

Create a .vscode/settings.json file

Add the following to the file
{
"github.copilot.chat.experimental.codeGeneration.instructions": [
{
"file": ".vscode/codestyle.md"
},
],
}

Add some code style guidelines to the codestyle.md

Ask Copilot to generate code which should trigger a reference to codestyle.md

Copilot does not seem to be respecting the github.copilot.chat.experimental.codeGeneration.instructions property in my workspace .vscode/settings.json file.  If I put the same thing in my user settings.json file it works just fine, but it does not work when this option is in a workspace settings.json file.

I did try and do a reload to make sure my settings took effect and it is still not working.


Caret position goes to the end when clicked and typed in the middle or start

I see a very weird thing - when I write anything in the form field, click in the middle or start and start typing again, the caret goes to the end of the string.
I found similar issue with normalization ( #1396 ), but I don't use any. The only message I found - this one in PR.
I noticed that Field component is rerendered on every value change / focus / blur, maybe this is somehow related. I don't see this effect in the docs page though.

Issue gif

Form component (from getting started)
import React, { Component } from 'react'
import { Field, reduxForm } from 'redux-form'

class ContactForm extends Component {
  render() {
    const { handleSubmit } = this.props
    return (
      <form onSubmit={handleSubmit}>

          First Name
          <Field name="firstName" component="input" type="text" />

        <button type="submit">Submit</button>
      </form>
    )
  }
}

ContactForm = reduxForm({
  form: 'contact' // a unique name for this form
})(ContactForm)

class FormComponent extends React.Component {
  handleSubmit = (values) => {
    // Do something with the form values
    console.log(values)
  }
  render() {
    return (
      <ContactForm onSubmit={this.handleSubmit} />
    )
  }
}

export default FormComponent

Index file
import React from 'react'
import ReactDOM from 'react-dom'
import { combineReducers, createStore } from 'redux'
import { Provider } from 'react-redux'
import { Router, Route, browserHistory } from 'react-router'
import { reducer as formReducer } from 'redux-form'
import FormComponent from './FormComponent'
import './styles.scss'

const reducers = combineReducers({
  form: formReducer
})

const store = createStore(reducers)

ReactDOM.render(
  <Provider store={store}>
    <Router history={browserHistory}>
      <Route path="/test" component={FormComponent} />
    </Router>
  </Provider>,
  document.getElementById('app')
)

Package versions (latest)

react 15.3.2
react-router 3.0.0
redux 3.6.0
react-redux 5.0.0-beta.3
redux-form 6.1.1
node 7.0.0
npm 3.10.8
macOS 10.12.1
chrome / safari

I have the same issue. I use textarea and innput components in the same way and the issue only comes for  input fields:
case "text":
                return <Field name={setting.id} component="textarea" rows="3" placeholder={setting.description}/>;
            case "string":
                return <Field name={setting.id} component="input" type="text" placeholder={setting.description}/>;

I was tracking render and componentWillUpdate on the level of my component and there is no unnecessary calls from my side. So I guess the issue is somewhere in the implementation of the input component.

Same here. I just notice in my code a plain redux-form input field like this:
<Field name='email' type='text' component='input' />

Works as expected. The caret position works like a plain DOM input. But when I change react-router and back to the form caret position jumps to the end
Example:

Same here.
As a side note I can reproduce the issue only in Chrome 54, Firefox 49 works as expected (Linux).

After fighting all day with the annoying jumping cursor :/
The bug has disappear after upgrade:

react-router from 2.0.0 => 3.0.0
react-router-redux from 3.0.0 => 4.0.6.
react from 15.0.0 => 15.3.2

New version of router touch less redux state. Could be related in some way with re-render and jumping caret?
As I said the bug occurred when I navigated.
I hope this can help someone or least be a clue :)

This is very bizarre. If the bug went away when upgrading other libraries, the fault must lie with the other libraries, no?

If the bug went away when upgrading other libraries, the fault must lie with the other libraries, no?

Maybe. But why/how can affect react-router or react to caret position.
I can understand react. Maybe they changed some DOM/input internal. But react-router? I don't know. All this caret thing has been very frustrating. The only positive think is that I've studied all react-forms files :)

But why/how can affect react-router or react to caret position.

I think it could if it rerendered a new fresh set of DOM nodes, since the caret position is kept in the DOM node. If you remove your <input/> and add it again to the DOM, your caret position will be reset.

I think that was the issue. On a fresh browser refresh the jumping caret bug was not happening. But when I navigated with react-router the bug appeared.  Something happened and my app started to do extra renders.

I can confirm that updating react from 15.0.0=> 15.3.2 fixes the issue. Thanks a lot for testing this.
So it seems to be just a React related issue between this version.

Nice! :)

Unfortunately, I used react 15.3.2 when I found this bug. It can be related to react-redux 5.0.0-beta.3.
Issue - https://github.com/reactjs/react-redux/issues/525

Or a mixture. For me the react upgrade was sufficient. But you can have a look of the full list of dependencies here: https://gitlab.com/lobaro/iot-dashboard/blob/master/package.json
I do not use the latest react-redux so it could be that something breaks with that again.

this thread was really hard to find despite it being exactly the issue I was encountering. (1 day of debugging) - Adding the word "Cursor" in the hopes that search for this bug improves

think that was the issue. On a fresh browser refresh the jumping caret bug was not happening. But when I navigated with react-router the bug appeared. Something happened and my app started to do extra renders.

I had this bug regardless of react-router navigation. I have tried everything and simplified the code to be identical to the example (no normalization)

This behavior is also reproducible when you attaching normalize lifecycle hook to Field, e.g. uppercase all the values.

this just started happening & i have no idea why.
react: 15.4.2
react-router: 2.8.1
react-redux: 4.4.6 and 5.0.3 (tested both)
an ugly hacky solution:
<Textarea {...input} defaultValue={input.value} value={undefined}/>

Give it a try with other versions. Maybe we can narrow down the reason.

Just noticed this on my app with latest versions of react (15.5.4), react-redux (5.0.4), react-router-dom (4.1.1) and react-router-redux (next).
In the end, the culprit had been a thunk-like middleware we were using that made dispatch consistently return a promise so you could use dispatch(...).then() without having to worry if the parameter to dispatch was a simple object or a thunk action:
export default function thunk(thunkArgument: any = undefined) {
  return ({ dispatch, getState }: Object) => (next: F) => (action: F) => {
    return Promise.resolve(action)
        .then(resolvedAction => {
          if (typeof resolvedAction === 'function') {
            return resolvedAction(dispatch, getState, thunkArgument);
          } else {
            return next(resolvedAction);
          }
        });
  };
}

Making the middleware return next(action) with simple action objects fixed it for me:
export default function thunk(thunkArgument: any = undefined) {
  return ({ dispatch, getState }: Object) => (next: F) => (action: F) => {
    if (typeof action === 'function') {
      return Promise.resolve(action(dispatch, getState, thunkArgument));
    } else {
      return next(action);
    }
  };
}

Wrapping next(resolvedAction) in a promise was apparently breaking what would otherwise be an atomic store update into a series of asynchronous store updates and thus breaking some of the update/rerender checks. For instance, when initializing the form I'd see the following prints inside the reduxForm's componentShouldUpdate:
client.js:75744 registeredFields changed undefined ==> Object {name1: Object}
client.js:75744 registeredFields changed Object {name1: Object} ==> Object {name1: Object, name: Object}
client.js:75744 registeredFields changed Object {name1: Object, name: Object} ==> Object {name1: Object, name: Object, email: Object}
client.js:75744 registeredFields changed Object {name1: Object, name: Object, email: Object} ==> Object {name1: Object, name: Object, email: Object, password: Object}
client.js:75744 registeredFields changed Object {name1: Object, name: Object, email: Object, password: Object} ==> Object {name1: Object, name: Object, email: Object, password: Object, passwordRepeat: Object}
client.js:75744 registeredFields changed Object {name1: Object, name: Object, email: Object, password: Object, passwordRepeat: Object} ==> Object {name1: Object, name: Object, email: Object, password: Object, passwordRepeat: Object…}

Compared with the following when using redux-thunk or the modified thunk code mentioned above:
client.js:75740 registeredFields changed Object {name1: Object, name: Object, email: Object, password: Object, passwordRepeat: Object…} ==> Object {name1: Object, name: Object, email: Object, password: Object, passwordRepeat: Object…}

Sharing this in case someone else is also doing some kind of non-standard thunk shenanigans. I've since reverted our thunk to redux-thunk's implementation and everything is working fine :)

I've got the same problem as described with the jumping cursor(without e.g. number formatting). For me it works using<EMAIL_ADDRESS>but breaks again in rc.2(since they replaced the previous fix with another one). It's also rumored that it will be fixed in React with version 16. But seeing that the temporary fix in react-redux still doesn't play well with redux-form, there has to be some other problem making them incompatible?
I'm not sure how to reproduce it without using redux-form, as i have only seen the bug in combination with redux-form :confused:

Because this issue saw almost no activity for a few months, I'm closing it.


Update README.md timezone

Update README.md for Timezone support

Thank you very much for adding the TZ support to README!

You are very welcome!


Update README.md

match pattern was formatted without *

Many thanks for the clarification, and correction. Merging.


feat: Add ForTesting(t *testing.T) function

After some time of using this package we found ourselves often writing following piece of code in tests:
ua := useragent.UserAgent{
	Name:        t.Name(),
	Version:     runtime.Version(),
	Environment: runtime.GOOS,
}

What do you think about including this function in this package?

yes!


Fix rank extraction when using LLMs for reranking >10 docs

See the following PR and this comment.
This PR addresses the following issue when using the LLM Reranker:

I tried to use the llm based reranking for > 10 chunks to be reranked and I noticed again the reranked order made no sense, as the old "rank extraction" from the LLM response, just considers the first integer digits in the square brackets. I improved the rank extraction from the LLM response using regex in this commiet 1e292ef34bd0fef1e2dfbc47db13b57b3ad9c368. Consider the following:

e.g we have 11 documents with ranks [1] ... [11]
The LLM reranks the documents into the following order [11], [3], [2], ... [1]
Document 11 is the number one most important document
Using the current logic of results.append(result_map[int(rank[1])]), only the first digit of "[11]" would be extracted, which is 1, putting document number 1 on the first spot, even though it was ranked last by the LLM.

Thank you, will review.

@PrithivirajDamodaran - Reviewing this PR.

Thank you, will review.

@PrithivirajDamodaran PR looks quite key for people using list-wise rankers (me included).
Can you do a review and merge if it is good?

Hello @andreped - will review and merge. Thanks


Issue with Jmeter-InfluxDB Writer Plugin v1.1 with Jmeter 3.0

Hi
I have downloaded writer plugin v1.1 and trying to use this with Jmeter V3.0 but i am having issues. I got following error when i click jmeter.bat "An error occured: class com.google.common.collect.AbstractMapBaseMultimap overrides final methond setMap.<Ljava/util/Map;>V errorlevel=1 "
Can you tell me what is the issue? thanks

Hi I too am experiencing same error, I am using same versions as ciitronian25  and getting same error. this would be a great plugin to use in my case to leverage further benefits of jmeter and influxdb.
when would this be getting a look over...Thanks

Hi,
the only dependencies of this extension are to:

org.apache.jmeter:ApacheJMeter_core:3.1
org.apache.jmeter:ApacheJMeter_components:3.1
org.influxdb:influxdb-java:2.4

So I assume the problem is that this extension only works for JMeter 3.1 and higher. I didn't try to run it with JMeter 3.0.
Another thing you could try is to change the jmeter dependencies to 3.0 and rebuild the binaries after that.

@miteshlimbachia , @ciitronian25 can you confirm that this issue was related to using JMeter version 3.0 instead of JMeter 3.1 ?

Hi, I am trying to use this plugin with JMeter 4.0. I have installed influxdb 1.6 and grafana 5.3.2
I have downloaded the jar file and restarted jmeter after copying the jar file to lib/ext. When I run the test in Jmeter, I get the following error -
2018-11-01 14:30:08,264 WARN o.a.j.g.u.MenuFactory: Configuration error, probably corrupt or missing third party library(jar)? Could not create class: kg.apc.jmeter.reporters.LoadosophiaUploaderGui.
java.lang.NoClassDefFoundError: org/apache/commons/httpclient/methods/multipart/PartSource
and -
java.util.regex.PatternSyntaxException: Dangling meta character '*' near index 0
*
^
at java.util.regex.Pattern.error(Unknown Source) ~[?:1.8.0_181]
at java.util.regex.Pattern.sequence(Unknown Source) ~[?:1.8.0_181]
at java.util.regex.Pattern.expr(Unknown Source) ~[?:1.8.0_181]
at java.util.regex.Pattern.compile(Unknown Source) ~[?:1.8.0_181]
at java.util.regex.Pattern.(Unknown Source) ~[?:1.8.0_181]
at java.util.regex.Pattern.compile(Unknown Source) ~[?:1.8.0_181]
at java.util.regex.Pattern.matches(Unknown Source) ~[?:1.8.0_181]
at java.lang.String.matches(Unknown Source) ~[?:1.8.0_181]
at rocks.nt.apm.jmeter.JMeterInfluxDBBackendListenerClient.handleSampleResults(JMeterInfluxDBBackendListenerClient.java:107) ~[JMeter-InfluxDB-Writer-plugin-1.2.jar:1.2]
at org.apache.jmeter.visualizers.backend.BackendListener.sendToListener(BackendListener.java:267) ~[ApacheJMeter_components.jar:4.0 r1823414]
at org.apache.jmeter.visualizers.backend.BackendListener$Worker.run(BackendListener.java:239) ~[ApacheJMeter_components.jar:4.0 r1823414]
2018-11-01 14:35:11,916 INFO o.a.j.g.a.Start: Stopping test
Appreciate any help to proceed, please !

Also, I am running this on Windows 7.


Fatal Error:  The requested URL returned error: 403

Error encountered while pushing branch to the remote repository: Git failed with a fatal error.
I tried using github desktop, command line, git bash and via azure devops too, nothing seems to be working. I have an individual account and I am the owner, so I don't think I shouldn't have access. I can't push or fetch.
Attaching screenshots below -

Hi, I believe this is a question about GitHub.com, the platform. This issue tracker is for a command-line utility called hub, not git + GitHub itself. For reporting bugs and requesting features for GitHub the platform, please visit https://github.com/contact. Thank you!
You should check the token that your IDE is using for git operations https://help.github.com/en/articles/https-cloning-errors

What a worthless reply.


Create generic attributes component

I want to merge this change because... it adds generic attributes component for further usage in product, page and variant details pages.
According to design and according to schema, attributes are the same objects for products, pages and variants, and also it is easier to handle them in one component.

PR intended to be tested with API branch:  feature/page-types
Screenshots

Pull Request Checklist

[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Translated strings are extracted.
[x] Number of API calls is optimized.
[x] The changes are tested.
[x] Data-test are added for new elements.
[x] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-1660 Create generic component to use in product, variant and page details pages


最新版本已修复该问题，请及时更新

能帮忙指一下是哪个commit吗，线上版本，先打个补丁，不能快速升级到3.2.5。

https://github.com/vearch/gamma/commit/5de7389674e6b1abb5cc1114b9db4909ab9649db

https://github.com/vearch/gamma/commit/5de7389674e6b1abb5cc1114b9db4909ab9649db

thanks

thanks


why RedissonBoundedBlockingQueue pollAsync(int limit) not call redis incrby to increase the queue capacity?

i use the RedissonQueue 'pollAsync(int limit)' method,
after i poll some elements, the capacity of the queue did not recovery,
at last, the capacity becomes 0, wow , i can not offer element any more!!!!

#3020


Fix documents link path in grow preset

In order to be recognized as valid documents, grow needs the leading slash on the documents path.
Otherwise e.g.partial.path_format would return None

Thanks @sebil :)

Thanks @sebil :)


Allow to edit credit card's zip code

I have recurring contributions setup on OpenCollective. I have saved my credit card details on the website, and when registering it the first time I've added my zip code for my bank to allow the payment to be processed.
I've recently moved, changed my address with my bank, and my payments to OpenCollective started bouncing
There's currently no way to edit my credit card info to update my zip code info, nor is it displayed anywhere.
I had to re-enter my card details with the new zip code, and then had two entries with the same card number in my profile with no extra information to know which one is the correct one

Related: https://github.com/opencollective/opencollective/issues/4924


Add terminal as default Windows+X shortcut (instead of powershell)

Description of the new feature/enhancement
Like default in Windows 11, it would be neat to have the option to add it to Windows 10!

Unfortunately, the team that owns the Win+X menu isn't going to be looking to backport that feature any time soon.
addenda: An earlier thread of this was #1421, which got duped to the default Terminal work in #492, which all wholly predates the concept of Windows 11, despite defterm only landing in Windows 11. I could've swore we had a thread about this before...


[FLINK-22757][docs] Adding gcs documentation. Connecting flink to gcs.

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@afedulov could you please also take a look? I think you struggled with GCS as well. For now, I'd merge it into 1.12 and 1.13 and wait if https://github.com/apache/flink/pull/15599 changes things for master (we could also merge it into master and let that PR update it - might be a good reminder).

Hi, So I did try via copying jars to plugins/gcs. It does not work.
Deploying on k8s.

I think it does not harm to include this info for completeness.
Here is an example of the core-site.xml:
<?xml version="1.0"?>
<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
<configuration>
  <property>
    <name>google.cloud.auth.service.account.enable</name>
    <value>true</value>
  </property>
  <property>
    <name>google.cloud.auth.service.account.json.keyfile</name>
    <value>/flink/gcs-creds/gcs-key.json</value>
  </property>
</configuration>

If yes can you give me the configuration key of core-site.xml, I believe the configuration key in flink-conf.yaml is:

Yes, if the core-site is placed into /flink/etc-hadoop/core-site.xml then the correct configuration is:
flinkConfiguration:
  fs.hdfs.hadoopconf: /flink/etc-hadoop/

@afedulov Can you confirm that GCS works for checkpointing? If so, I think the page should mention that use case.

It does.

While it doesn't hurt to point out that this fs can be used for checkpoints, it's actually true for all filesystems. I think @alpinegizmo is confusing this property with exactly-once StreamingFileSink support.
For reference, for checkpoints, we use simple FileSystem class.
Only with this PR, users can write exactly-once to GCS. So I probably would mention that StreamingFileSink is not supported here with link to ticket.
We could merge it then to master, 1.13, 1.12, and when FLINK-11838 is done, then the page could be modified to reflect that it now supports SFS.

@AHeise I was reacting to two things:

All of the other filesystems with documentation pages adjacent to this one explicitly mention and include an example of using them for checkpointing. Not mentioning this use case on this page will raise questions in the minds of some readers.

While the hadoop-based implementation of a filesystem on S3 can be used for checkpointing, this should be avoided because that implementation makes a lot of expensive S3 HEAD requests and hits request rate limits very quickly. I'm wondering if this GCS filesystem has similar problems when used for checkpointing. @afedulov, do you know?

@AHeise I was reacting to two things:
1. All of the other filesystems with documentation pages adjacent to this one explicitly mention and include an example of using them for checkpointing. Not mentioning this use case on this page will raise questions in the minds of some readers.

2. While the hadoop-based implementation of a filesystem on S3 can be used for checkpointing, this should be avoided because that implementation makes a lot of expensive S3 HEAD requests and hits request rate limits very quickly. I'm wondering if this GCS filesystem has similar problems when used for checkpointing. @afedulov, do you know?

Good points, so I'd include it but also note that it's currently not possible to use SFS.
On a meta-note, it feels like we should have an individual page for all fs ;).

I manually merged this commit into release-1.12, release-1.13, and master together with a mock Chinese version.

@AnkushKhanna thank you very much for your contribution.


Decide whether we confine this operator to a namespace or make it cluster scoped

I happened across this project while searching for a registry agnostic version of Quay's container-security-operator: it looks just like what I'm looking for!
I'm assuming this issue is related to the OPERATOR_NAMESPACE value. I'd strongly favour it operating across all namespaces by default, with the option to constrain to a specific set.


Add support of "helmCharts" in kustomize

Starting from April 2021, kustomize supports "helmCharts" and "helmGlobal" attributes (https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv4.1.0).
Straight way to use kustomize and helm together is to pass "--enable-helm" command line parameter to kubectl kustomize command.
However, monokle doesn't support these attributes, highlighting them in UI. When I click "preview", it shows me an error

It would be perfect if user could manipulate the attributes of command line tool used for preview, e.g. add command line parameters.

Hi @zakharovzakhar ,
We were thinking about this a few days ago and it's super valuable for us to get this feedback from you.
Thanks for opening this issue!
We decided to add configurable previews for both Kustomize and Helm in the near future.
This will allow you to pass arguments for the preview and save the configuration to easily use it again at a later time.
Let us know if you have any other ideas or suggestions!

thanks @zakharovzakhar - as an intermediate solution which we could add to the upcoming 1.5.0 release, could we by default simply always add --enableHelm when invoking kustomize? Perhaps have a "Enable Helm with Kustomize" global setting to ensure compatibility with older versions of Kustomize that don't support this setting?

I think having a global setting should work. If it is possible for closest release, could you please also fix the validation rules for kustomize to prevent red highlighting of these attributes ?

I've added the updated kustomization schema in #1009 - will be in the upcoming nightly build and release. We'll add a global "Enable Helm with Kustomize" setting in the settings drawer which will add the corresponding cmdline argument when invoking kustomize

@ZakharZakharov do you know of any public repos that contain kustomizations with these properties?


when webstorage quota gets exceeded, recent work gets erased

(started here)
This is the error which is thrown:

DOMException: Failed to execute 'setItem' on 'Storage': Setting the value of 'excalidraw' exceeded the quota.

It's very difficult for a user to spot that an error takes place at all, so quite a lot of work can get lost 😭 (it did several times in my case and so I decided to investigate that...)
All in all excalidraw needs to support this. I'm willing to create a PR, but first I need some guidance:

I need to know which components to use for displaying the error. Is this the way to go (packages/excalidraw/components/ErrorDialog.tsx)?

        {errorMessage && (
          <ErrorDialog onClose={() => setErrorMessage("")}>
            {errorMessage}
          </ErrorDialog>
        )}

IMO we need a consistent "strategy" to deal with errors. I've searched places which use setItem:

and most of the calls are surrounded by try..catch, but these are pretty useless:
  try {
    localStorage.setItem(
      STORAGE_KEYS.LOCAL_STORAGE_ELEMENTS,
      JSON.stringify(clearElementsForLocalStorage(elements)),
    );
    localStorage.setItem(
      STORAGE_KEYS.LOCAL_STORAGE_APP_STATE,
      JSON.stringify(clearAppStateForLocalStorage(appState)),
    );
    updateBrowserStateVersion(STORAGE_KEYS.VERSION_DATA_STATE);
  } catch (error: any) {
    // Unable to access window.localStorage
    console.error(error);
  }

So 2 questions:

2.1: which setItem call actually dumps the "canvas" content into webstorage? saveDataStateToLocalStorage in LocalData.ts - or another one?
2.2: since that'd be my first contrib here, I'd make it simple, very more or less like this:

 // wherever is the call that I'm looking for
  } catch (error: any) {
    if (DOMException quota exceeded) {
      display error
    }
    // otherwise console.error (pretty useless, but no regression)
    console.error(error);
  }

WDYT? @dwelle @vjeux
I've got local setup working already (wonderfully quick and neat to get it done 👍)

Hi!
All the data-related local storage is handled in excalidraw-app/data/LocalData.ts
specifically this part:
https://github.com/excalidraw/excalidraw/blob/b5d7f5b4ba85db38aa2c13df88c68d258ae70828/excalidraw-app/data/LocalData.ts#L106-L116
You can extend the onFilesSaved to take an optional Error object as an argument, a handle it in excalidraw-app/App.tsx. Although onFilesSaved is named in such a way and used only for doing some post-work with files, so perhaps it should be renamed as well.
I'd also make sure that LS data (excalidraw elements + appState) failures doesn't interfere with saving images to IDB (so try catch them individually), as it's better to at least save something (images).
Also note that we don't use IDB for content for a purpose: we don't want people to store too much stuff in their browsers as browser storage is inherently unreliable. People clear cookies (and thus site data), or browsers decide to evict data if you're running low on disk storage.
But we should have definitely handled the errors in a way to let users know. It was planned, but got forgot.


feat: :sparkles: add favorites and able to toggle between the favorites and all

As we are seeing that the data source is increasing, this feature will allow users to add their own favorites and toggle selectively toggle to view the favorites only.
The data for favorites would be stored in the user's localStorage hence the favorites won't be accessible on different browser.

Preview URL: https://97949eb5.howtoprofessionallysay.pages.dev/


Potential performance optimisation around hierarchy-traversing matchers

Tl;dr: It's possible that Kakao could be more performant by reordering matchers to apply faster matchers first.

Since Kakao wraps Espresso, Espresso's view finding mechanism is used for actions and assertions. This mechanism will always iterate through entire view hierarchy looking for all views matching the requested predicate (source).
Most matchers should be pretty fast, however some of them will also iterate some part of view hierarchy as part of their check. For example HasDescendantMatcher or IsDescendantOfAMatcher will both go up or down the view hierarchy looking for views that match the requested descendant/ancestor. This means complexity of those matchers is not constant, contrary to simple matchers like WithIdMatcher. Moreover, when these matchers are nested, the overall performance decreases dramatically — for nested isDescendantOfA matchers, Espresso will go through every view in hierarchy, first matcher will go up in hierarchy and execute the nested matcher, which will also go up the hierarchy — I believe the complexity is non-linear in that case.
This is all unavoidable to an extent, but if those slow matchers are used within composite matchers like allOf() or anyOf(), the developer can easily improve Espresso performance by simply putting the expensive, view-traversing matchers later on the list. That way Espresso will short-circuit as soon as it can, potentially not invoking the expensive matcher at all.
If I read the code correctly, Kakao will sometimes put the slow matcher first on the list that is effectively transformed into an allOf() with same ordering, for example https://github.com/KakaoCup/Kakao/blob/da021333ba50d97c62548d07485c25bf8884fd68/kakao/src/main/kotlin/io/github/kakaocup/kakao/recycler/KRecyclerView.kt#L87-L90 or https://github.com/KakaoCup/Kakao/blob/da021333ba50d97c62548d07485c25bf8884fd68/kakao/src/main/kotlin/io/github/kakaocup/kakao/edit/KTextInputLayout.kt#L35-L38. Simply switching those lines would improve the performance essentially for free, with no obvious downsides. The faster matchers will run first and short-circuit the check if they fail, and the slower matcher will run a couple of times instead of for every single view.
This might look like a small change, but especially with nested matchers the performance impact can be significant —  in one project with ~270 UI tests, simply putting isDescendantOfA and hasDescendant matchers last in allOf calls cut total test run time in half (the project doesn't use Kakao).

Will be available in next release. Thanks.

Thanks! If you have any measurements/numbers before and after the changes, I'd be curious to hear if you saw any improvements :slightly_smiling_face:

@lwasyl we have 1k+ UI tests in prod. Ill tell ya about performance boost changes.


Server code?

I couldn't get this to work with a node.js server. Would it be possible to include the server code and maybe the thrift library itself (in case it's incompatible with other version)?

I will try digging this out. Obviously, this has been opened a long time ago but for nevertheless might be interesting for future reference. Not sure if this is going to work with latest thrift as the JS protocol has been through so many changes.


Update Block Hasher

Update the hashing functions in crypto.py to reflect on the new fields we added

[ ] Timestamp


Wrong line separators: '{\r\n  "ENABL...' at offset 1

This error exist for quite a while, and coz latly i have to develop on windows i would like to report it

@morovinger Thank you for submitting! 👍


Monitoring prompt down in TCP Port mode！

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
I don't understand why.
Please assist in making a judgment. thanks！

📝 Error Message(s) or Log
No response
🐻 Uptime-Kuma Version
1.22.0
💻 Operating System and Arch
CentOS Linux release 7.5.1804 (Core)
🌐 Browser
Google Chrome 114.0.5735.248
🐋 Docker Version
No response
🟩 NodeJS Version
No response

This address and port correspond to 1 router

What is your deployment model and versions?
Unrelated note (this likely won't affect the issue):
CentOS Linux 7 is EOL => migrating to CentOS Stream might be a good idea
CentOS Linux 8 is supported for about another year

Note that I tried to reporoduce this issue and came to the same conclusion as uptime-kuma


enable scroll to zoom control

Hi !
I haven't been able to activate scroll wheel zoom control.
Any idea on how to do that ?
Regards,
Jeremie

HI @jgastonraoul ,
you can pass it in the configuration, like
function SomeController() {
  var vm = this;
  ...
   vm.mapConfig = {
      ...
      interactions: {
         mouseWheelZoom: true
      }
   };
   ...
}

And bind it to the openlayers directive like
<openlayers ol-defaults="vm.mapConfig">
   ...
</openlayers>

Hope that helps. I'm closing the issue. Feel free to re-open it in case.

That's what I was doing, but there was a mistake in my directive : I was using "defaults" instead of "ol-defaults'.
Thanks for your help.

:+1:


[DO NOT MERGE] Berkeley refactor preparation

Long running branch to poise notebooks for conversion to Berkeley schema.
Leave "#TODO" notes in notebooks for where we will need to edit urls when berkeley schema is production
Workflows will check the validity of each notebook when a push is made to this branch.
R notebooks that have been updated and are passing checks in this branch:

[x] NEON metadata
[x] bioscales metadata
[x] taxonomy by soil layer
[ ] NOM visualization notebook

python notebooks that have been updated and are passing checks in this branch:

[x] NEON metadata
[x] bioscales metadata
[x] taxonomy by soil layer
[ ] NOM visualization notebook

@kheal After doing my changes I noticed that we can't just query workflow_execution_set, we need to specify the type as nmdc:MetagenomeAnnoation because it messes with the results. You'll see even in your diff that you are getting records that aren't metagenome annotation records. So in order to count for that, I added a type variable to the get_id_results function and added this in all the calls. Its not really necessary for the material processing steps or the data generation step (although it is nice to specify type is nmdc:NucleotideSequencing). But I would recommend doing this to your notebooks as well. My counts were back on a similar track to the original notebooks (they were a little off, but I assume this had something to do with re-iding).
Also, I noticed you still have two mentions omics processing in of your heading and description in step 6.

Tried to add you as a reviewer but looks like I can't cause its your PR

Good catches @brynnz22.  I'll fix those and review your changes this week.

@brynnz22 .  I've updated the R taxonomy notebook.
The python taxonomy notebook looks good, but I think we lost step 8's narrative (code looks good, but there's no text describing it anymore).
We also have dill as an import and reference it in the first chunk of text, but don't use it anymore.  I should have taken that out earlier (#47), but I missed it.  It works fine for me because I have dill loaded in my venv, but it's not consistent with the requirements if someone else pulls it locally to use.

Created branch berkeley_nom off of main to update NOM visualizations folder with Berkeley API calls. Didn't branch off of this berkeley_refactor branch because the branch was created after our notebooks. https://github.com/microbiomedata/nmdc_notebooks/pull/80

Created branch berkeley_nom off of main to update NOM visualizations folder with Berkeley API calls. Didn't branch off of this berkeley_refactor branch because the branch was created after our notebooks. #80

@samobermiller this works too! In the future though, you can just merge main into the Berkeley branch to get main's updates into the Berkeley branch and then branch off the Berkeley. But this way is fine too - it just means we'll have to merge a couple of PRs in after Berkeley.

@brynnz22 . I've updated the R taxonomy notebook.
The python taxonomy notebook looks good, but I think we lost step 8's narrative (code looks good, but there's no text describing it anymore).
We also have dill as an import and reference it in the first chunk of text, but don't use it anymore. I should have taken that out earlier (#47), but I missed it. It works fine for me because I have dill loaded in my venv, but it's not consistent with the requirements if someone else pulls it locally to use.

@kheal I added step 8 narrative back in and removed the dill import and reference.


[v0.9] update mbedtls-sys to 2.28.3

This PR upgrade the mbedlts-sys-auto to 2.28.3 by checkout the code under mbedtls-sys to tag mbedlts-sys-auto_v2.28.3.
This help the maintenance of the v0.9 branch, especially when we need to introduce new changes in mbedtls-sys folder.

bors try

bors try

bors r+


Store visibility does not work as expected in a distributed setup

API store visibility does not work as expected in a distributed setup. Specially when restricting an API from public to a role.

Fixed in latest master with https://github.com/wso2/carbon-kernel/pull/2346