accessibility options and newer themes

@torinfo @FayCross
I've committed the CESI theme now and following our discussion re the accessibility options and js code for that theme that isn't working at the moment I did some testing with the other newer themes that we have and there are definitely some issues with some of those too. The main issue is when selecting Invert. e.g. we have so many more colours and changes in themes now that the code behind that option isn't changing everything that is necessary to change and I'm not sure how easy it would be to do so. It's not just the newer themes there are some issues with some of the older themes too.
I'm wondering about the following and perhaps for further discussion and perhaps event development during the developer day next week...
Add new themes e.g. High contrast, Black on Yellow and have the accessibility options switch to those themes rather than try to invert colours in the existing theme.
and/or
Provide a select list of all the enabled themes so that a user can select from any of those themes if enabled by the author e.g. same option as disable theme change on url.
Possibly add a footer button for easily changing theme
Possibly include a browser cookie when viewing LO's to save choice of preferred theme to apply across all XOT projects
As I say maybe discuss further during the developer day.

Hi all
I committed a new High Contrast theme yesterday and added the following notes:
New High Contrast XOT template theme with the aim of replacing the Colour Changer > Invert option or rather what happens when that option is selected. That option hasn't really worked reliably for some time because we have so many more themes and variations compared with just the original default theme. I guess this needs agreement/discussion as to whether to change the invert option to switch to this theme when selected. On the one hand it would provide a more reliable high contrast solution but on the other hand does change the theme (including buttons etc) rather than just invert white and black.
Do we agree this is a better option?
If so I'll also work on a Black on Yellow theme too for that colour changer option.
Obviously changes need to be made to the colour changer code so that the theme is switched rather than the current invert functionality.

Hi all
I've committed the blackonyellow theme now too.
If we all agree then the colour changer code now needs changing so that if invert is selected the high contrast theme is loaded and if black on yellow is selected then the black on yellow theme is loaded.

@torinfo thanks for updating the accessibility options for black on yellow and invert to swich to the new themes. That bit works fine but a slight problem that we have missed is that after choosing one of those options and then selecting off the theme doesn't revert to or reload the orginal theme set by the author. Refreshing obviously achieves that but ideally we need to add code so that isn't needed.

BTW selecting to remove background images and then selecting off doesn't work now either.

@ronm123 Hmmm. The code is not in there. I'll find it and will add it.

@torinfo great thanks I see that you have now committed the change and after a clearing of cache it all seems to be working now so will close the issue.


Enforce no spaces in file names

This has caused a number of downstream issues in the past and we should enforce with a regex validation rule

Please work with @brynnz22 on this.
Do we enforce no spaces? no white space characters at all? no special characters?

the regex string ^\S*$ should be appropriate to capture start of string, any number of non-whitespace characters followed by the end of the string

From the docs this can be implemented as adding regex match ^\S*$ to the Validation Rules column for the attribute Filename

@brynnz22 do you think you try and open a PR to modify the data model to add the validation rule above. Happy to do so in a working session if preferable. We can try and deploy this branch to a testing instance and see the rule works appropriately.

Note to Brynn: Make a new branch titled based on this, then open a PR against main. Once PR done, work with Adam to run action: Should be able to run gh action on that branch to deploy to testing1

I've deployed this to the testing1 instance
To do this I:

Made a branch for HTAN-data-curator called develop-nospace-validation
edited the schematic_config.yml file to point towards the no-space-filenames branch of the data-models repo
This then automatically kicks off the shiny_deploy action. As it is started from a branch prefixed with develop, it deploys to the testing1 instance

Of course this will all change for the upcoming multi-tennant DCA

I'm getting a DCA disconnect when I try and generate a template in the testing instance. Will look at logs and see if I can see what the issue is.

Nothing in the logs to suggest the cause 😪

Is it the weird quotes and things that were inserted in the csv that could be causing this?

@brynnz22 Yeah I think it might be the quoted validation rule "url " highlighted in my review of the PR. Lets remove them (editing the csv directly in the Github web UI might be the easiest way to avoid any local formatting issues) and then we can redeploy to testing1 Thank you!

Hey @brynnz22 I've been trying to test this validation rule locally with a small test template based from OtherAssay
Component,Filename,File Format,HTAN Parent Biospecimen ID,HTAN Data File ID,Assay Type
OtherAssay,underscore_separated.csv,csv,HTA1_1_1,HTA1_2_2,Test
OtherAssay,space separated.csv,csv,HTA1_1_1,HTA1_2_2,Test

This should fail validation due to the space.... but schematic seems to trip up with error KeyError: 'Filename'
(data-models) ataylor@w152 test-nospace-validation % schematic model -c schematic_config.yml validate -mp other_assay_example.csv -dt "OtherAssay"
Starting schematic...
The (model > input > location) argument with value 'HTAN.model.jsonld' is being read from the config file.
The (model > input > file_type) argument with value 'local' is being read from the config file.
JSON schema successfully generated from schema.org schema!
JSON schema file log stored as HTAN.OtherAssay.schema.json
FileDataContext loading zep config
GxConfig.parse_yaml() failed with errors - [{'loc': ('xdatasources',), 'msg': 'field required', 'type': 'value_error.missing'}]
GxConfig.parse_yaml() returning empty `xdatasources`
Loading 'datasources' ->
{}
Loaded 'datasources' ->
{}
EphemeralDataContext has not implemented `_load_zep_config()` returning empty `GxConfig`
Loading 'datasources' ->
{}
Loaded 'datasources' ->
{}
warning: /Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/great_expectations/data_context/data_context/abstract_data_context.py:2590: DeprecationWarning: create_expectation_suite is deprecated as of v0.15.48 and will be removed in v0.18. Please use add_expectation_suite or add_or_update_expectation_suite instead.
warning:   warnings.warn(
warning: /Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/great_expectations/data_context/data_context/abstract_data_context.py:373: DeprecationWarning: save_expectation_suite is deprecated as of v0.15.48 and will be removed in v0.18. Please use update_expectation_suite or add_or_update_expectation_suite instead.
warning:   warnings.warn(
        0 expectation(s) included in expectation_suite.
Calculating Metrics: 0it [00:00, ?it/s]
Traceback (most recent call last):
  File "/Users/ataylor/miniforge3/envs/data-models/bin/schematic", line 8, in <module>
    sys.exit(main())
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/click/decorators.py", line 38, in new_func
    return f(get_current_context().obj, *args, **kwargs)
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/schematic/models/commands.py", line 209, in validate_manifest
    errors, warnings = metadata_model.validateModelManifest(
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/schematic/models/metadata.py", line 254, in validateModelManifest
    errors, warnings, manifest = validate_all(self, errors, warnings, manifest, manifestPath, self.sg, jsonSchema, restrict_rules, project_scope)
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/schematic/models/validate_manifest.py", line 253, in validate_all
    manifest, vmr_errors, vmr_warnings = vm.validate_manifest_rules(manifest, sg, restrict_rules, project_scope)
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/schematic/models/validate_manifest.py", line 208, in validate_manifest_rules
    vr_errors, vr_warnings = validation_method(
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/schematic/models/validate_attribute.py", line 666, in regex_validation
    validation_rules=self.sg.se.get_class_validation_rules(self.sg.se.get_class_label_from_display_name(manifest_col.name))
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/schematic/schemas/explorer.py", line 432, in get_class_validation_rules
    class_info = self.explore_class(class_label)
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/schematic/schemas/explorer.py", line 333, in explore_class
    if "subClassOf" in self.schema_nx.nodes[schema_class]:
  File "/Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/networkx/classes/reportviews.py", line 194, in __getitem__
    return self._nodes[n]
KeyError: 'Filename'

I think this actually related to something going on in the JSON-LD of the schema as it contains the following
        {
            "@id": "bts:filename",
            "@type": "rdf:Property",
            "rdfs:comment": "Name of a file",
            "rdfs:label": "filename",
            "schema:domainIncludes": {
                "@id": "bts:File"
            },
            "schema:isPartOf": {
                "@id": "http://schema.biothings.io"
            },
            "sms:displayName": "Filename",
            "sms:required": "sms:true",
            "sms:validationRules": [
               "regex search ^\\S*$"
            ]
        },

Note the lowercase filename for id and label while only displayName has the title case Filename.
Note also that only title case Filename is used in the CSV version of the model
If I manually edit the JSON-LD to have title case Filename for id and label the validation runs as expected, showing the expected error for the second row
        {
            "@id": "bts:Filename",
            "@type": "rdf:Property",
            "rdfs:comment": "Name of a file",
            "rdfs:label": "Filename",
            "schema:domainIncludes": {
                "@id": "bts:File"
            },
            "schema:isPartOf": {
                "@id": "http://schema.biothings.io"
            },
            "sms:displayName": "Filename",
            "sms:required": "sms:true",
            "sms:validationRules": [
               "regex search ^\\S*$"
            ]
        },

(data-models) ataylor@w152 test-nospace-validation % schematic model -c schematic_config.yml validate -mp other_assay_example.csv -dt "OtherAssay"
Starting schematic...
The (model > input > location) argument with value 'HTAN.model.jsonld' is being read from the config file.
The (model > input > file_type) argument with value 'local' is being read from the config file.
JSON schema successfully generated from schema.org schema!
JSON schema file log stored as HTAN.OtherAssay.schema.json
FileDataContext loading zep config
GxConfig.parse_yaml() failed with errors - [{'loc': ('xdatasources',), 'msg': 'field required', 'type': 'value_error.missing'}]
GxConfig.parse_yaml() returning empty `xdatasources`
Loading 'datasources' ->
{}
Loaded 'datasources' ->
{}
EphemeralDataContext has not implemented `_load_zep_config()` returning empty `GxConfig`
Loading 'datasources' ->
{}
Loaded 'datasources' ->
{}
warning: /Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/great_expectations/data_context/data_context/abstract_data_context.py:2590: DeprecationWarning: create_expectation_suite is deprecated as of v0.15.48 and will be removed in v0.18. Please use add_expectation_suite or add_or_update_expectation_suite instead.
warning:   warnings.warn(
warning: /Users/ataylor/miniforge3/envs/data-models/lib/python3.10/site-packages/great_expectations/data_context/data_context/abstract_data_context.py:373: DeprecationWarning: save_expectation_suite is deprecated as of v0.15.48 and will be removed in v0.18. Please use update_expectation_suite or add_or_update_expectation_suite instead.
warning:   warnings.warn(
        0 expectation(s) included in expectation_suite.
Calculating Metrics: 0it [00:00, ?it/s]
error: For the attribute Filename, on row 3, the string is not properly formatted. It should follow the following re.search pattern "^\S*$".
[['3', 'Filename', 'For the attribute Filename, on row 3, the string is not properly formatted. It should follow the following re.search pattern "^\\S*$".', 'space separated.csv']]

This seems related to this error reported on Slack: https://sagebionetworks.slack.com/archives/C01ANC02U59/p1671129949628629?thread_ts=1671068131.722179&cid=C01ANC02U59
I also wonder if we can't actually validate Filename as it is a Reserve-use special attribute per the Data Model Schema docs.
Does this make sense?

FYI @milen. We would like to add a regex validation rule to prevent spaces in filenames. But we seem to get a key error when adding a regex validation rule to this attribute. See above.
In further testing I can add other validation rules (eg int or str) for the Filename attribute but regex validation rules result in the same error.

Interestingly the schematic example.model.jsonld has titlecase Filename
https://github.com/Sage-Bionetworks/schematic/blob/b3468419d4e2ad880709274aae77771164d89fa6/tests/data/example.model.jsonld#LL2305-L2321C11

Yes this makes sense! I saw that Gianna is looking into it on Slack.

From slack

@adamjtaylor can you open an issue on this in the schematic repo? I think its more related to the conversion from csv to jsonld. I was able to add the regex rule to our example model and validate without issue. I also noticed that in our model and jsonld, Filename is capitalized. I tried converting the HTAN model with what's on develop and noticed that it was converted as filename like it was in yours. Something aside from the issue with the validation rule is going on and it'll likely take more time to diagnose and solve.

Just a note: Filename, should have this capitalization, since schematic treats this attribute specially. It's concerning that it gets lower cased.

Update ahead of the sprint review:

I think this issue is blocked by the lowercasing of Filename in our JSON-LD`
There is a schematic ticket open liked above but it has had no action yet (FYI @milen-sage )
Propose we move this to escalate to monitor resolution
It is a "nice to have" rather than "must have" feature so we can manage waiting
We can also implement this check at the data release stage (@clarisse-lau)

@adamjtaylor it's in the queue for next sprint triage: see here

@adamjtaylor FAIR Data team moved our issue tracking system to JIRA as of this week. Diagnosis of schematic issue is now tracked here.

Per Gianna's diagnosis, FAIR's recommendation is that "HTAN should move the Filename specification from the properties column of each attribute to the DependsOn column to resolve"

Confirmed in staging that this catches spaces in Filename.
Unfortunately, it also catches Not Applicable in the Channel Metadata filename.
Proposing that we remove the validation from Channel Metadata Filename as we expect deeper validation of these files and a possible transition to synapse IDs.

Confirmed in staging that this catches spaces in Filename.
Unfortunately, it also catches Not Applicable in the Channel Metadata filename.
Proposing that we remove the validation from Channel Metadata Filename as we expect deeper validation of these files and a possible transition to synapse IDs.


Upgrade to hibernate-jenkins-pipeline-helpers 1.18 -- and configure the version on CI instead of in Jenkinsfile

Upgrade to 1.18 to avoid buggy notifications.
See https://hibernate.zulipchat.com/#narrow/channel/132096-hibernate-user/topic/Jenkins.20Notifications
Full changeset: https://github.com/hibernate/hibernate-jenkins-pipeline-helpers/compare/1.13..1.18
Don't configure the version in Jenkinsfile so that it's easier to upgrade next time.
See https://ci.hibernate.org/manage/configure#global-untrusted-pipeline-libraries to change the (default) version globally for all projects.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

Should I backport it to maintained branches as well?

@marko-bekhta Thanks for merging.
I don't think a backport is necessary until someone shows up and tells us they've been spammed by CI builds on older branches. Which seems unlikely.


Endpoints urls with slash

Proposed changes:

revert stripping of trailing slashes for endpoint urls and replace it with a debug message
fixes https://github.com/RasaHQ/rasa/issues/3776#event-2412592607

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog
[x] reformat files using black (please check Readme for instructions)

Still doesnt solve the 404 issue. Please help

@Wing-e7 please open a bug report with full information and ideally reproducible behavior if you think there is still a bug!


Border that is passed as props doesn't change direction when changing document's direction

When changing direction the  doesn't change direction

[ x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
It should either be responsive to dir attribute of parent or have a css logical attribute.
Example:
Motivation 🔦
This is an important concept for RTL languages support

@daniel-ilan  please share a minimal reproducible codesandbox example that will illustrate the issue. It is not clear which component you are referring to, which version you are using etc.

@daniel-ilan See the docs, there are multiple steps to get RTL working: https://next.material-ui.com/guides/right-to-left/


Added rainbow sine animation

Animations generated in the below repository:
connorf25/xmas-tree-visualizer
Animation featuring a spinning rainbow wheel around the Z axis and a seperate sine wave which determines the maximum Z coordinate for a light to be illuminated.
Is somewhat normalized for the rgb values to be somewhere from 0-50 but a full spectrum 0-255 one can be found here

I like that you invested the time to create a more power-aware variant of your animation for the actual tree. But even then, you should be able to still use something between 100 and 150 as your max because you are only using about half of each LED (on average 1.5 color channels aren't addressed). Furthermore, Matt has plans to "normalize" the animations to his tree's capacities: #28 So, I wouldn't spend to much time on the power issue.
The animation is simple but still fun to watch. The spinning should look good on a tree, in a simulator there is always the problem with the depth not coming through.

Looks super cool - love it!


Fix #4060 by showing second line of commit

Fix #4060
strings.TrimSpace actually removes the \n at the end of the commit message. Because of that the comparison must be changed.

Codecov Report

Merging #4251 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4251      +/-   ##
==========================================
- Coverage   19.96%   19.95%   -0.01%
==========================================
  Files         153      153
  Lines       30521    30521
==========================================
- Hits         6094     6091       -3
- Misses      23513    23515       +2
- Partials      914      915       +1

Impacted Files
Coverage Δ

modules/process/manager.go
69.56% <0%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c919b07...14f243f. Read the comment docs.

@JonasFranzDEV please create backport


Unable to create notification (API 27)

I am on 8.1.0 (API 27)
final ArrayList<JcAudio> jcAudios = new ArrayList<>();
for(TrackVariable track : trackList) {
    jcAudios.add(JcAudio.createFromURL(
        track.getTrack_name(),
        track.getTrack_url()));
}
jcplayerView.initPlaylist(jcAudios);
jcplayerView.createNotification();

This doesn't create a notification for me.

I am writing that on the next version. If you really wish that right now, send a pull request or make a fork of this project. Thanks.


Width and auto column size for dockerized container

Python Version
3.12
Django Version
4.1
Package Version
No response
Description
Width is not properly detected for dockerized container. I can manually set the columns variable, but this is not a solution for multiple users.

This sounds like a Rich issue, not a Django-rich one, so gonna close this. Did you check the Rich docs and issue tracker? It sounds like your container may be missing some basic Unixy configuration that prevents such detection.


Setup error

I followed the setup instructions, but I get the following errors:
ERROR: Ignored the following versions that require a different python version: 1.25.0 Requires-Python >=3.9; 1.25.0rc1 Requires-Python >=3.9; 1.25.1 Requires-Python >=3.9; 1.25.2 Requires-Python >=3.9; 1.26.0 Requires-Python <3.13,>=3.9; 1.26.0b1 Requires-Python <3.13,>=3.9; 1.26.0rc1 Requires-Python <3.13,>=3.9; 1.26.1 Requires-Python <3.13,>=3.9; 1.26.2 Requires-Python >=3.9; 3.2 Requires-Python >=3.9; 3.2.1 Requires-Python >=3.9; 3.2rc0 Requires-Python >=3.9; 3.8.0 Requires-Python >=3.9; 3.8.0rc1 Requires-Python >=3.9; 3.8.1 Requires-Python >=3.9; 8.13.1 Requires-Python >=3.9; 8.13.2 Requires-Python >=3.9; 8.14.0 Requires-Python >=3.9; 8.15.0 Requires-Python >=3.9; 8.16.0 Requires-Python >=3.9; 8.16.1 Requires-Python >=3.9; 8.17.0 Requires-Python >=3.9; 8.17.1 Requires-Python >=3.9; 8.17.2 Requires-Python >=3.9
ERROR: Could not find a version that satisfies the requirement open3d==<IP_ADDRESS> (from versions: <IP_ADDRESS>, 0.11.0, 0.11.1, 0.11.2, 0.12.0, 0.13.0, 0.14.1, 0.15.2, 0.16.0, 0.17.0)
ERROR: No matching distribution found for open3d==<IP_ADDRESS>

Hi!
Maybe you can delete this package in the requirement.txt?
If the code cannot run, then you can pip install it again.

maybe you can try:
pip install -U pip setuptools


Feature/69

add simple CI without GUI and Headless Browser Testing

@Maksimall89 now, need to add Travis enabled image status to readme.md
https://docs.travis-ci.com/user/status-images/


[Release Tasks Migration] - Git Tag Workflow

As part of the Beam Release Process, the following PR includes the workflow to run the Git Tag described in the Beam Release Process
Files:

Git Tag Released Version Workflow: .github/workflows/git_tag_released_version.yml
CI.md

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@MarcoRob could you please add this job to CI.md?

@MarcoRob could you please add this job to CI.md?

@damccorm Done!


Use the .NET Core variant of Cake

This PR replaces the regular Cake library with its .NET Core compatible branch: Cake.CoreCLR. One of the big advantages is that we can completely ditch the Mono dependency, all you need to have installed is .NET Core.
Fixes #218

CircleCI is randomly failing, but as Travis an AppVeyor are working, I'll still merge this.


Can the mod_auth_openidc be configured to return a Authorization: Bearer header in redirect response?

I was wondering if mod_auth_openidc can be configured to return a standard Authorization: Bearer [jwtToken] Header in the response to the User Agent after the 302 redirect from the Identity Provider?
I am talking about the mod url mapping configured by OIDCRedirectURI : https://[server]/example/redirect_uri.
I can see the jwtToken is sent as a request header OIDC_access_token to the protected application but other than the mod_auth_openidc_session cookie in the Response to the user agent there is nothing a javascript application running in the user agent can use to make subsequent XHR requests with a standard Authorization: Bearer header.
This is required when building single page applications such as AngularJS which run solely in the clients browser and need to communicate Authorization context to REST services that may not be protected by the mod_auth_openidc but are capable of validating the JWT against the same issuer.

I tried copying the OIDC_access_token header and construct a Authorization: Bearer on the way out but that did not work :(
SetEnvIf ^OIDC_access_token$ (.*) AuthTokenFound
SetEnvIf ^OIDC_access_token$ "(.+)" AuthToken=$1
# only add header if the OIDC_access_token is present
SetEnvIf Header add Authorization "Bearer %{AuthToken}e" env=AuthTokenFound

Setting Authorization: Bearer [token] in a Headers seems backwards: this header is used to authorize the Client accessing the Resource Server and not the other way around. (I believe your attempt would also put the header in the Request, not the Response).  Putting it in another header that is actually returned in the Response may be more suitable, but I'm not sure the module needs to do that. After all you generate the Javascript yourself; it would not be too hard to pickup the OIDC_access_token value and include it in the Javascript returned to the browser.

The User Agent will send the Authorization header once presented with it. The single page web application is typically code served by an apache from a protected location. Any JavaScript part of this application runs in the User Agent hence would never see the OIDC_access_token header from the server side communication since it is scrubbed. However if the javascript application in the browser would want to get data from an API that is also protected and accepts the same issuer issued claims then a Authorization header would need to be sent there. I tried to draw it up below, hope that this clarifies this question a bit more (I left out the 2 auth redirects to keep it as simple as possible).

Also Header add / set will add response headers as per apache documentation http://httpd.apache.org/docs/2.2/mod/mod_headers.html. But I think when this code runs the server side OIDC_access_token header is probably already scrubbed.
Option 1
the mod_auth_openidc would set an environment variable on a per request basis and then one would be able to simply add a directive like this into the apache configuration to return the issued token to the client browser.
SetEnvIf Header set Authorization "Bearer %{OIDCAuthToken}e" env=OIDCAuthToken

Option 2
a configuration directive for the module to add an Authorization: Bearer [token] header to the response sent back to the client whenever this mod_auth_openidc_session cookie is sent would probably be more consistent:
<Location "/e">
  OIDCReturnBearerToken true
  AuthType openid-connect
  ...
</Location>

Are one of these options doable?

Option 1 would not work for the same reason that using the header does not work: mod_auth_openidc only does its work after the SetEnvIf is executed. You may be able to make this work by appying a workaround as mentioned in: https://github.com/pingidentity/mod_auth_openidc/issues/55#issuecomment-77259613
But: my previous point was that the Javascript may run in the user agent, but is served up by the backend. That backend does receive the OIDC_access_token header so it should be doable to pick it up on the backend and include it in the Javascript that is returned to the browser.

After some fiddling, I was able to make Option 1 work for me in the following way:
<Location "/protected/">
  AuthType openid-connect

  RewriteEngine On
  # a catchall that will incur an internal redirect, hitting the same path again with REDIRECT_PASS set
  RewriteCond %{ENV:REDIRECT_PASS} !1
  RewriteRule .* $1 [L,E=PASS:1]

  # this code is only executed the 2nd time around when the mod_auth_openidc headers/environment will have been set
  Header set Authorization "Bearer %{HTTP_OIDC_ACCESS_TOKEN}e" env=HTTP_OIDC_ACCESS_TOKEN

  Require valid-user
</Location>

Hello,
I have tried this code with the latest version with Apache 2.4 but did not seem to work. I had to change it the following way.
<Location "/protected">
AuthType openid-connect
Header set Authorization "Bearer %{OIDC_ACCESS_TOKEN}e" env=OIDC_ACCESS_TOKEN
Require valid-user

I am just adding this here as someone might need it in the future. is there a particular reason why the environment variables do not have the HTTP prefix anymore ?

See also: See also: https://github.com/pingidentity/mod_auth_openidc/issues/132#issuecomment-282280141

[We have deployed mod_auth_openidc-2.3.8-apache-2.4.x-win64 (openidc module) on Apache server. We have a jsp page deployed on Tomcat which is proxied by the Apache server. We intend to receive the access token on this jsp page either is the header or as JSON response. Please advise. The oidc.conf is pasted below.
httpd.zip


fix TVP issue with resultset for varchar(max)

for issue #248

Codecov Report

Merging #250 into dev will increase coverage by 0.03%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##                dev     #250      +/-   ##
============================================
+ Coverage     33.46%   33.49%   +0.03%
+ Complexity     1491     1483       -8
============================================
  Files            97       97
  Lines         23390    23392       +2
  Branches       3840     3840
============================================
+ Hits           7828     7836       +8
+ Misses        14001    13994       -7
- Partials       1561     1562       +1

Flag
Coverage Δ
Complexity Δ

#JDBC41
33.35% <50%> (-0.02%)
1475 <0> (-8)

#JDBC42
33.35% <50%> (ø)
1479 <0> (-2)
:arrow_down:

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
37.51% <50%> (+0.66%)
0 <0> (ø)
:arrow_down:

src/main/java/microsoft/sql/DateTimeOffset.java
37.14% <0%> (-2.86%)
8% <0%> (-2%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
23.63% <0%> (-0.38%)
167% <0%> (-3%)

.../microsoft/sqlserver/jdbc/SQLServerConnection.java
41.1% <0%> (-0.09%)
227% <0%> (-2%)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
45.13% <0%> (+0.07%)
182% <0%> (-1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598a3b4...326cd80. Read the comment docs.


Sampler support border wrap(clamp to zero), and fix mirror wrap

Note: this is not supported (yet) on WebGPU
Note: it clamps to transparent black
But other than that, seems good, should work for all textures from what I can see.


The Socket's function of send() or recv() takes too  much time sometimes (IDFGH-4015)

Recently, I am completing a project about Low power consumption. And I've got a sticky problem.
My needs is that when the ESP32 wakes up from deep sleep mode, send some data to server by WIFI.
But, sometimes, the function of send() or recv() takes time that is up to about 4 seconds. And sometimes, it  takes less than one seconds. All tests were performed when the WIFI signal was greater than -60dbm.
Is there any way to optimize this problem?
Environment
Module or chip used: ESP32-WROOM-32U
IDF version : v4.0.1
Build System: idf.py
Operating System:Windows
Using an IDE: Eclipse CDT
Power Supply: external 3.3V
Code snippet
int8_t send_to_server(server_handle_t handle, uint32_t len, uint8_t *pdata)
{
	/* 发送数据区 */
	int16_t tmp = 0;
	uint16_t cnt = 0;
        time_t useTime = time(NULL);
	while(len >= 1024)
	{
		tmp = send(handle->sock, pdata + cnt * 1024, 1024, 0);
		if(tmp < 0)
		{
			ESP_LOGE(TAG, "send_to_server:Error occurred during send: errno %d", errno);
			return -2;
		}
		len -= 1024;
		cnt++;
	}

	if(len != 0)
	{
		tmp = send(handle->sock, pdata + cnt * 1024, len, 0);
		if(tmp < 0)
		{
			ESP_LOGE(TAG, "send_to_server:Error occurred during send: errno %d", errno);
			return -2;
		}
	}

	ESP_LOGI(TAG, "send_to_server:Send OK!");

Thanks for reporting. Would you please help provide more details as suggested in the issue template? Information like elf, sdk configuration, backtrace, log outputs, commit ID, hardware and etc. would help us debug further. Thanks.

Hi @helittr
Could you please explain a bit your environment? Are you sending the data to a local server, which is always available or to an internet, how much data you're sending, get these data fragmented, are they sent in multiple packets?
As you know the TCP is not real time so might be tricky with the predictable throughput based on WiFi signal.
There are ways of course to adjust the TCP parameters, but need to understand what's happening on the network. In general we could:

Disable naggling  (TCP_NODELAY)
Adjusting buffer sizes
Adjusting low level TCP params, like time to retransmit, re-trasmit period, etc..


#82: Ups HBASE_VER to 1.2.1

Issue #82: Update: HBASE_VER=1.2.1
Signed-off-by: nps<EMAIL_ADDRESS>

Thanks for the update! merging


Pub/sub binding for Spring Boot ignores @PostMapping value

Expected Behavior
In my Spring Boot application, I have a @RestController annotated class with one method:
    @Topic(name = "speedingviolations", pubsubName = "pubsub")
    @PostMapping("/collectfine")
    public ResponseEntity<Void> registerViolation(@RequestBody final CloudEvent event) {
        // omitted for brevity
    }

I have added the io.dapr:dapr-sdk-springboot dependency, so I expect that this method will be invoked by the sidecar when a message is published on the "speedingviolations" topic.
Actual Behavior
The Dapr sidecar logs the following error:
ERRO[0031] non-retriable error returned from app while processing pub/sub event b411c8c6-e191-4853-b678-930c1183e4ab: {"timestamp":"2021-07-07T18:10:45.006+00:00","status":404,"error":"Not Found","path":"/speedingviolations"}. status code returned: 404  app_id=finecollectionservice instance=edsger scope=dapr.runtime type=log ver=1.2.2

The path "/speedingviolations" is not where the method is mapped to; the pub/sub message should be sent to "/collectfine".
Steps to Reproduce the Problem
See above. Crucial thing is that the @PostMapping annotation should use the value element rather than the path element.
Release Note

RELEASE NOTE: FIX Pub/sub binding for Spring Boot properly reads @PostMapping value

PS. If you feel this is indeed worth fixing, I am willing to give it a shot.

Hi @artursouza
I/we know you are super busy with the Dapr core development first and foremost.
And maybe it is vacation times in the US aswell, so please don't get me wrong.
But I do believe that for the Java SDK to be successful, there should me more maintainers
of this SDK so we can have a quite active discussion on the issues. Just my two cents and I hope
you can forward this to "the ones that decides about resources in the Dapr team at Microsoft" :-)
Thank you for your contribution and support and the other Java SDK maintainers. It is/has been great!
With hopes that you can get more help to maintain the Java SDK,
/Dan


Inactive Reserves roster display not listed properly.

Describe the bug
Inactive Reserves not displaying all information
To Reproduce
Steps to reproduce the behavior:

Go to inactive reserves roster listing, don't see anyone higher than CR-C

Expected behavior
All inactive reserve members are displayed.
Platform
Desktop Firefox

Unable to confirm


parseDirectives causes bad Uri to be created

I was migrating to use the build project and ran into an issue with the analyzer within parseDirectives
CompilationUnit parseDirectives(String contents,
    {String name, bool suppressErrors: false}) {
  if (name == null) name = '<unknown source>';
  var source = new StringSource(contents, name);
  var errorCollector = new _ErrorCollector();
  var reader = new CharSequenceReader(contents);
  var scanner = new Scanner(source, reader, errorCollector);
  var token = scanner.tokenize();
  var parser = new Parser(source, errorCollector);
  var unit = parser.parseDirectives(token);
  unit.lineInfo = new LineInfo(scanner.lineStarts);

  if (errorCollector.hasErrors && !suppressErrors) throw errorCollector.group;

  return unit;
}

Since name is null the name becomes <unknown source>. This then goes into the StringSource constructor.
  StringSource(this._contents, String fullName)
      : this.fullName = fullName,
        uri = fullName == null ? null : new Uri.file(fullName),
        modificationStamp = new DateTime.now().millisecondsSinceEpoch;

If fullName is null then everything works as expected. However since its <unknown source> then the Uri constructor will throw.
Commenting out the if statement that sets the value seems to work.
@jakemac53

Ah, I missed an occurrence. Yes, commenting out the line is the right fix.

https://codereview.chromium.org/1806843003/

:+1: guessing this will be in 0.27.3-alpha.3?

Yes. The next version will probably be published by the end of the week.

Awesome thanks for the fix @bwilkerson. Keep up the good work


MHA suddenly missing header analysis information

For about the last week, MHA show no information at all (except Original Headers) on the Summary tab, only one server on the Received tab, the Antispam tab template is void of any analysis data, Other is completely blank and the Copy function only shows one of the transit (originating?) servers.
I have tried changing the UI style but it made no difference. I have uninstalled the Add-In, rebooted, reinstalled the Add-In and the issue persists.
This is a very small shop on O365 E3 for all users and no changes have been made for at least 2 months.

I've also experienced exactly the same behaviour over the past week or so.

I'm seeing the same behavior across multiple tenants.  In the diagnostic messages all refer to a REST permissions issue.

I'm also not sure what has happened to MHA, but it makes it much more difficult to use. This has been one of my most valuable add-ins for the last couple of years.

I've heavily used MHA for the past couple of years and whatever has happened to this valuable add-in makes interpreting the header usage on these emails very difficult and extremely time-consuming.

I have also experienced this issue. The issue has also been reported on Microsoft's forums:
https://answers.microsoft.com/en-us/outlook_com/forum/all/mha-message-header-analyzer-no-longer-working-on/4b87ceaa-74e8-45c4-b105-bc5669fb6d5a

We experience the same problem using the installed Outlook for Office 365, New Outlook, and the web client. Does this have anything to do with this change?
https://admin.microsoft.com/AdminPortal/home?ref=MessageCenter/:/messages/MC734315

sorry - bad update - reverted

Awesome, looks like it's fixed now, working on mine.
Thanks @stephenegriffin

Thank you so very much.  Not only is it now very usable, but I like the visual layout better than the previous version--what a time saver. Have a great 2024...

Mine is working, too. I will follow up with my coworkers.

Fix deployed - sorry about missing this report earlier


[5.8] Fix manifest source generation for enableUpcomingFeature/`enableExp…

…erimentalFeature`.
Manifest source generation was previously transforming:
.enableUpcomingFeature("FeatureName")

to:
.upcomingFeatures(["FeatureName"])

because of how the build setting was stored internally.
This commit fixes the issue by switching the internal model for these build settings to match the external model so they can be properly regenerated. This also matches how other build settings (like linkedFramework) are modeled internally.
This addresses rdar://problem/104718971.
(cherry picked from commit 366e79b8f0a40252bb7a01e3ca8c0c35f2647450)

@swift-ci smoke test


Simple kubernetification of chardonnay

Dockerification and kubernetification of chardonnay.
RangeServer mocks the epoch service for now.

hopefully i didn't mess up the rebase :D

Noticed that you merged another PR that unmocks the warden. Not sure if the current setup will work, testing it.


[Avoiding Harm] Quizzes!

Purpose/implementation Section
What changes are being implemented in this Pull Request?
There's some draft quizzes here. Ethics multiple choice questions are hard to make. They always feel a bit obvious. But Claude and I did our best.

Claude and I made these together. @carriewright11 do you want to review or do we merge and review later?

Claude and I made these together. @carriewright11 do you want to review or do we merge and review later?

good job to you both haha - it looks good - I made some changes and added more, but it was pretty good!


Losing type inferences in marble tests

RxJS version:
master
Additional information:
Currently to enhance jsdoc test code readability, test scheduler interface is not being directly imported but accessed globally with implicit ambient declaration, so hot or cold observable generated does not support any type inference to Observable<T>
declare const {hot, cold, asDiagram, expectObservable, expectSubscriptions};

var e1 = hot(...);

e1.audit().subscribe() //e1 does not gives any type context

This is somewhat problem since all unit test cases are intended to be used as type definition test cases too, which current test cases are losing its benefit in lot of cases.

/cc @staltz for visibility, also @david-driscoll .
I've quickly tried if it's possible to use ambient declaration to test helper interfaces, but that wasn't successful since dependent types (Observable, Subject, Scheduler, etcs) are also need to be handcrafted since ambient declaration does not allow to import external type definition.
@staltz for asking idea if we can solve this in jsdoc perspective, @david-driscoll for asking type definition perspective I couldn't think of.

Currently to enhance jsdoc test code readability, test scheduler interface is not being directly imported but accessed globally with implicit ambient declaration

I don't understand what does jsdoc have to do with the marble tests. Can't we make hot() and cold() generic functions hot<T>() and cold<T>()?

Can't we make hot() and cold() generic functions hot() and cold()?

: no, this isn't about it.
Do you remember original refactoring was importing test helper directly like
import {hot} from ...

hot();

? it's transpiled by compiler something like
var hot_1 = require(...);

hot_1();

so jsdoc test case will display some kind of ugly name. Instead, https://github.com/ReactiveX/rxjs/pull/1378 introduced to remove explicit import to come over those limitation of jsdoc. Now test cases are not importing explicitly, none of type inferences for generated Observable from hot or cold, type verification / inference including intellisense from editor does not work.

Oh I see. Can't we declare the types of those functions in each file?
Like
declare hot: string => Observable<any>;

(Just an example, not sure if that compiles)
It would incur some repeated code, on the other hand.

Can be, but I'm feeling that'll be too much repeated code. (Should import HotObservable, etcs..) I'd consider it as last option. If I can't get feasible solution, I'll go in that way.

Can you build it with a custom typings file that includes these definitions?

Can you build it with a custom typings file that includes these definitions?

: bit doubt about it. First, can't create external type definition since this issue is result of avoid external import (import ...) for transpiled results. Ambient definition is technically possible, but I found it'll require too much handcraft effort (i.e need to convert most of operator signature into ambient. Maybe I'm missing some easygoing way though).
For now most realistic approach seems @staltz 's suggestion above even it has some amount of duplicated code around test cases, still I'd like to look for other alternative bit more.

Something like this won't do?
"build_spec": "tsc testing-types.d.ts --project ./spec --pretty",

Ambient definition is technically possible, but I found it'll require too much handcraft effort

I'm not sure I'd agree that handcrafting a typings file with ~8 definitions in it is going to be more work than adding definitions to every spec file.

Maybe I'm not understanding the issue here, though.

handcrafting a typings file with ~8 definitions

: it's not ~8, unfortunately. Let's say one signature as example:
hot(...): HotObservable<T>
now need to create interface
HotObservable<T>: Observable<T>
requires handcraft of Observable<T> as chain. Yes, can't import like import {Observable} .. in ambient type definition unfortunately, TypeScript seems consider it as non-ambient type definition if it contains any external type definition import. Means, all inhertance interface need to be handcrafted along with most operator signature bloating up effort of manual type definition.
Still this is based on my experiment and there might be better way to resolve this.. (:eyes: to @david-driscoll :) ?)

Is this really a "big deal", though? I mean, is this worth all of the trouble?
Is the real answer just to update our test helpers to be a TypeScript module and be more explicit about the usage?

Is this really a "big deal",

: I'm not considering this as serious problem, though it's bit unfortunate we've moved all test cases into typescript and losing one of benefits for dogfooding type verification.

Is the real answer just to update our test helpers to be a TypeScript module

: That was my original intention and I believe that's simplest solution. What we're trying to solve in here is bending module system in our way to bypass some issues (jsdoc).
I'd consider this as low-priority, good-to-have goals for now. But still believe eventually need to be resolved some way. Best scenario will be documentation system can understand original TS code as-is instead of lean on transpiled results, but that seems not likely to happen with jsdoc.

After experiencing regression issue like https://github.com/ReactiveX/rxjs/issues/2163 and now library try to follow semver strictly, I started thinking this might need to be looked again.
Originally test case supposed to serve as validating type definitions as well, but currently does not by due to this issue since all of hot/cold obsevable created via test interfaces are simply casted down to any type. We could possibly revisit this issue, or think about other way to guard type definition to not to regress .

One last thing for this issue is enabling hot(), cold() returns HotObservable<T>, ColdObservable<T> instead of HotObservable<any>, ColdObservable<any> - downcasting to value into any causes to lose some inference like
//this shouldn't work in current type signature with specific type T but casted `any` makes pass this
.filter(x => x)

Thanksfully default generic will be introduced soon enough (https://github.com/Microsoft/TypeScript/issues/2175#issuecomment-278453271), once we bump up compiler version with supported we can have like HotObservable<T = string> prevent downcasting to any but use string as default, but allow to specify generic if needed.

This is somewhat resolved and while there is lot to go, issue itself can be closed. Individual issue can be dealt via PR / separate issue.


FEAT Single turn crescendo

Is your feature request related to a problem? Please describe.

We don't support single turn crescendo yet. This should be added.
Paper: https://arxiv.org/pdf/2409.03131v1
GitHub repo (results only): https://github.com/alanaqrawi/STCA
Describe the solution you'd like

The tricky part is that for every goal/objective (e.g., "how to create a molotov cocktail") the conversation looks very different. We'll need to be able to generate the entire conversation until the n-th step and then put that into a single prompt. The assumption here has to be that the attack target is a single turn target (otherwise we can just use "normal" crescendo). So the red teaming LLM has to generate both sides of the conversation. An alternative (mentioned by Alan, the author of the paper), is to run full Crescendo and keep the questions and responses, then put them in a single prompt. That may or may not be possible in actual operations (and definitely not with single turn targets).
Importantly, the n should be configurable. The paper has some discussion of that and we probably want to be flexible.
The final solution needs to have tests and a simple notebook (like all orchestrators). There's some freedom in terms of how to do this that depends on how the conversation generation works best:

custom orchestrator: first generate conversation (which may be a single step or multiple), then send to target
converter: converter generates conversation from just the goal [It's not a typical converter, though....]
another way? If this is chosen please discuss here with dev team first.

Describe alternatives you've considered, if relevant

Alternatively, one could pregenerate such single turn crescendo templates for hundreds of goals, but that will never be comprehensive...
Additional context

One tricky aspect is that the responses need to be somewhat similar to how the target model responds. Otherwise, it may get "suspicious" (not trying to anthropomorphize here but it's the simplest way to explain what I mean) and refuse to comply.

Hey! I'm up for it!

Let me know if you have questions folks


[docs] Fix link to TYPO3 docs

I saw it was breaking existing tests (why you did it I assume) so pulled it.


Standardize Fuzzing

Fix the fuzzer so that it's standardized again
Fix validation of multisig addresses

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (200e11d) 91.96% compared to head (21fa9ae) 91.71%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   91.96%   91.71%   -0.25%
==========================================
  Files           8        8
  Lines         336      338       +2
==========================================
+ Hits          309      310       +1
- Misses         27       28       +1

Flag
Coverage Δ

unittests
91.71% <66.66%> (-0.25%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

src/transaction/deserialize.c
90.27% <66.66%> (-1.16%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Conv history documentation does not work

New to the tool... I tried to follow the conversation history fixture in the opening documentation but the example just doesn't work. I have tried many tweaks but the prompt.json never does what it says in the example.
My use case is i have a really big sys prompt which is followed by one assist prompt then I want to try multiple user prompts on the same large prompt... con history should do it but it does not work.. any ideas?

Hi @SeanyCochrane, thanks for flagging this.  You're right that there's a problem with the example in the docs - mainly that it used an inconsistent variable name.
I've corrected this and also added a full example here that you can reference.  Let me know if you encounter any issues!

Great thanks it's working now... one additional question. My default tests system prompt is large... how would I sub in a file to the yml... e.g.
Messages:
- system: [file with large prompt in it]

As of version 0.23.1 it is now possible to load a vars value directly from file using the file:// prefix.  Here's an example:
  - vars:
      system_message: file://path/to/system_message.yaml
      foo: some other var...

You may find it helpful to set the system_message var in defaultTest.  This will make the var available in every test.  Something like this:
defaultTest:
  vars:
    system_message: file://path/to/system_message.yaml

tests:
  - vars:
      previous_messages:
        # ...

I've updated the example to show an example of this: https://github.com/promptfoo/promptfoo/blob/main/examples/openai-chat-history/promptfooconfig.yaml
Hope this helps!

Thanks typo. I upgraded to 23.1 and it loads the prompt file... however my sys prompt is quite large and complex so now I have 'bad indentation' errors. I think we'll need something to process text prompts.

Aha... if I put the prompt as single line enclosed in double quotes it works... but would be nice to be able to auto strip line feeds.

Hi @typpo   - just to let you know... in order to load a multiline sys prompt I did a rough hack in the test case.js...
vars[key] = fs.readFileSync(value.slice('file://'.length), 'utf-8');
// Sort out quotes and new lines
vars[key] = "'" + vars[key].replace(/(\r\n|\n|\r)/gm, "").replace(/"/gm,"\"").replace(/'/gm,"") + "'";
This now allows me to easily edit a large prompt avoiding single quotes. Not perfect but worth considering for future releases...

@SeanyCochrane thanks, I see what you're saying here.  This change 64da64d4470a6a3169a5dd3c93f4961efa2b98ec strips newlines from imported vars and I've updated the separate test configs example to include a system message import.
There was a separate change a couple days ago that stopped files from being read as yaml, which should have solved the other indentation issue you mentioned.
I'm not sure the quote escaping is necessary, though.  Single and double quotes in vars are escaped if they are being included within strings in a JSON prompt.  So maybe there is something else about your setup that we need to troubleshoot?

Ok just tried it... I no longer need enclosing single quote or remove single quote but I still need to escape the double quotes.... i.e.
vars[key] = vars[key].replace(/(\r\n|\n|\r)/gm, "").replace(/"/gm,""")...
Incidentally the progress bar when I use this method seems to get replace with " system_mes ... looked everywhere trying to figure out why... might be to do with the test heading which is a print out of prompt json

Agh... the replace is being replaced in GitHub... double quotes replaced with backslash double quote...

Would you be able to show me how you're including the system message var in your main prompt?

(config yaml)
prompts: [prompts2.json]
defaultTest:
vars:
  system_message: file://mshare.txt

  previous_messages:

Prompts2.json
[
{

  "role": "system",

  "content": "{{ system_message }}"

},

{% for message in previous_messages %}

  {% for role, content in message %}

    {

      "role": "{{ role }}",

      "content": "{{ content }}"

    },

  {% endfor %}

{% endfor %}

{

  "role": "user",

  "content": "{{ question }}"

}

]
On Wed, 20 Sept 2023, 15:46 Ian Webster, @.***> wrote:

Would you be able to show me how you're including the system message var
in your main prompt?
—
Reply to this email directly, view it on GitHub
https://github.com/promptfoo/promptfoo/issues/136#issuecomment-1727878842,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7K7EGGF3BP65WSXJ7TTEM3X3L6TLANCNFSM6AAAAAA4YDXV54
.
You are receiving this because you were mentioned.Message ID:
@.***>

Conversation history support has improved, feel free to reopen/open a new issue if you're still running into problems!


Interfaces: Other Types: VXLAN needs additional constraints to prevent user error

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
In the GUI in Interfaces: Other Types: VXLAN in the mask Edit VxLan the fields Remote address, Multicast group and Device can all be populated, even though that prevents the operating system from creating a working vxlan interface.
If you populate Remote address and Device (other than none) at the same time, dmesg shows this:
vxlan2: cannot initialize interface: can only specify interface with a group address
If you populate Remote address andMulticast group and Device at the same time, the vxlan interface comes up, but it's in multicast mode, ignoring the "Remote address" parameter:
vxlan vni 42 local <IP_ADDRESS>:4789 group <IP_ADDRESS>:4789
To Reproduce

Go to "Interfaces: Other Types: VXLAN" in "Edit VxLan"

VNI: 42
Source address: <IP_ADDRESS>     (IP address of a firewall bound interface)
Remote address: <IP_ADDRESS>
Multicast group: empty
Device: LAN

Go to "Interfaces: Other Types: VXLAN" in "Edit VxLan"

VNI: 43
Source address: <IP_ADDRESS>     (IP address of a firewall bound interface)
Remote address: <IP_ADDRESS>
Multicast group: <IP_ADDRESS>
Device: LAN

Expected behavior

When a Multicast group is set, it should be required to have Remote address empty, and the Device has to be NOT none
When a Remote address is set, it should be required to have Multicast group empty, and the Device has to be none

Additional context
Heres the precise troubleshooting of my user error:
https://forum.opnsense.org/index.php?topic=36205.0
It was pretty hard to troubleshoot, so I think the additional constraints could be a valid addition.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 23.7.4-amd64
FreeBSD 13.2-RELEASE-p3
OpenSSL 1.1.1v 1 Aug 2023

The number of validations are quite limited indeed, if you want to take a shot at this one, just let me know. For inspiration, the vip model (https://github.com/opnsense/core/blob/master/src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php) contains quite some of them which are hard to catch with standard field validations (https://docs.opnsense.org/development/frontend/models_fieldtypes.html), custom ones (https://docs.opnsense.org/development/frontend/models_customfields.html) and/or constraints (https://docs.opnsense.org/development/frontend/models_constraints.html).

Sure I'll give it a try. Thank you for the examples, I will look at them.


Convert to net8 on release 1.13

Description
Converted quickstart projects to use .Net 8 SDK. The exception is the batch app, which uses the Swashbuckle assemblies which have not been upgrade to .Net8. Instead, the project has been reverted to .Net 6 to match the referenced Swashbuckle libraries.
Issue reference
Please reference the issue this PR will close: #980
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] The quickstart code compiles correctly
[x] You've tested new builds of the quickstart if you changed quickstart code
[x] You've updated the quickstart's README if necessary
[x] If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@paulyuk  I've created a new pull request rather than re-use the original pull request (#960 ) that you reviewed recently. This is because the changes are now based off branch release-1.13 rather than master, and I thought it would be tidier to start with a fresh pr.
I've incorporated the changes you suggested pull request #960. Note, I released that the batch project uses the Swashbuckle libraries which have not been updated to .Net 8. I've instead reverted this project to be based on .Net 6 to keep it consistent with all of the other dependencies.

Here to make life easier I edited base to be release-1.13 for you.

@pngan I spotted the issue why Validate C# test is failing.  It looks like the console output changes slightly using this combination of runtime and dapr.
Please change the following Line 37 in your Actors Readme from:
  - "Request finished HTTP/1.1 GET http://<IP_ADDRESS>:5001/healthz - - - 200"

to:
  - "Request finished HTTP/1.1 GET http://<IP_ADDRESS>:5001/healthz - 200"

Notice it just removes two dashes and spaces before the 200.
  You can test in your own actors/csharp/sdk folder (or any quickstart folder with a makefile) using make validate to see the error turns into all 200s.  If you get an error that you're missing Mechanical Markdown, do this first:
sudo pip3 install mechanical-markdown

hth, and let me know if you need help.

Also, I realized that the batch project uses the Swashbuckle libraries which have not been updated to .Net 8. I've instead reverted this project to be based on .Net 6 to keep it consistent with all of it's other dependencies.

@pngan It appears that some projects might reference the Swashbuckle libraries but not actually use them.  If that's preventing moving the project to .NET 8, I'd recommend just removing the Swashbuckle references.

Hey @pngan just wondering if you have some time to look at this again.  I'd love to get it in for this release.  I can also help.

Hi @paulyuk Thanks for rebasing the pull request on release-1.13 . There must be same procedural step I'm missing because the the branch I checked in seemed, to me at least, to be based on release-1.13 - it had commit 155578e97e0be6228acf6f872e298b6097aee2a0 in the git log. Nevertheless, thanks for resolving the issue for me. If that was the remaining issue, do you think this pull request is ready to be merged?
I notice that a C# pull request check is failing a /healthz end-point check. The output would suggest that that endpoint is completing fine. Is this something you could help with?

@philliphoff  I'd rather leave the upgrade to .net 8 for the binding project to someone else. Could we make a github issue specifically targeted to the upgrade of binding project? While the swagger library may no longer be referenced, it seems that the project may be in an indeterminate state if in the past there was OpenApi documentation being auto-generated - perhaps there is some work to restore the OpenApi generation. But this is something I don't want to sign up for at this time.

As a general comment about updating to .net 8 - I noticed words on the dapr public website references .NET 6+ . This should be updated to say .NET 8+. I've have not managed to locate those strings in this github repo, so presumably that content is stored elsewhere. We should update those instructions, in order for it to stay in sync with these changes (once release-1.13 is released!)

Hi @paulyuk Thanks for rebasing the pull request on release-1.13. If that was the remaining issue, do you think this pull request is ready to be merged?
I notice that a C# pull request check is failing a /healthz end-point check. The debugging output would suggest that that endpoint is completing fine. Is this something you could help with?

Hi @pngan.  Good point.  The /healthz endpoint is working well as you point out.  The issue with the test is simply that the output of the check now returns a string with less dashs.  The "fix" to this is to change Line 37 of the Readme to the new string, which is:
  - "Request finished HTTP/1.1 GET http://<IP_ADDRESS>:5001/healthz - 200"

If you want to make that change and validate the check works, that's great.  I can also help do this I think by contributing to your PR.

As a general comment about updating to .net 8 - I noticed words on the dapr public website references .NET 6+ . This should be updated to say .NET 8+. I've have not managed to locate those strings in this github repo, so presumably that content is stored elsewhere. We should update those instructions, in order for it to stay in sync with these changes (once release-1.13 is released!)

Great catch.  The docs have a richer copy of this readme and are maintained by @hhunter-ms and others.  She knows about this PR, so we can get that updated as well.  If you're curious the source for that website doc is here: https://github.com/dapr/docs/edit/v1.12/daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md

@philliphoff I'd rather leave the upgrade to .net 8 for the binding project to someone else. Could we make a github issue specifically targeted to the upgrade of binding project? While the swagger library may no longer be referenced, it seems that the project may be in an indeterminate state if in the past there was OpenApi documentation being auto-generated - perhaps there is some work to restore the OpenApi generation. But this is something I don't want to sign up for at this time.

Ok I'll take care of this.

Hey @pngan -- may I suggest you review and merge a few complementary changes in this PR and/or copy the changes into your branch and commit so this PR picks it up?  Then I'll be ready to sign off and merge this PR.  I ran all these tests, and with our collab on both sets of commits all tests pass for all quickstarts, including Actors and Bindings where we spotted challenges.

@paulyuk

Here's a trick I do to validate tests quickly on the local machine before you commit and try the long 30m+ CI/CD tests. You can test in your own actors/csharp/sdk folder (or any quickstart folder with a makefile) using make validate to see the error turns into all 200s. If you get an error that you're missing Mechanical Markdown, do this first:
sudo pip3 install mechanical-markdown

hth, and let me know if you need help.

Hi Paul,
I ran the make validate in the spirit of TDD before fixing the /healthz documentation testing. Interestingly, all tests passed locally, and the test on the PR check was not picked up. I'll fix the check, but letting you know about that.
phil@z420:~/github/forked/dapr/quickstarts$ make validate
mm.py -l -s "bash -c" README.md

External link validation:
	https://github.com/dapr/quickstarts/actions?workflow=samples Status: 200
	https://discord.com/channels/778680217417809931/778680217417809934 Status: 200
	https://www.apache.org/licenses/LICENSE-2.0 Status: 200
	https://docs.dapr.io/getting-started/install-dapr-cli/ Status: 200
	https://docs.dapr.io/getting-started/quickstarts/ Status: 200
	https://github.com/dapr/community/blob/master/CODE-OF-CONDUCT.md Status: 200

@paulyuk

Here's a trick I do to validate tests quickly on the local machine before you commit and try the long 30m+ CI/CD tests. You can test in your own actors/csharp/sdk folder (or any quickstart folder with a makefile) using make validate to see the error turns into all 200s. If you get an error that you're missing Mechanical Markdown, do this first:
sudo pip3 install mechanical-markdown

hth, and let me know if you need help.

Hi Paul,
I ran the make validate in the spirit of TDD before fixing the /healthz documentation testing. Interestingly, all tests passed locally, and the test on the PR check was not picked up. I'll fix the check, but letting you know about that.
phil@z420:~/github/forked/dapr/quickstarts$ make validate
mm.py -l -s "bash -c" README.md

External link validation:
	https://github.com/dapr/quickstarts/actions?workflow=samples Status: 200
	https://discord.com/channels/778680217417809931/778680217417809934 Status: 200
	https://www.apache.org/licenses/LICENSE-2.0 Status: 200
	https://docs.dapr.io/getting-started/install-dapr-cli/ Status: 200
	https://docs.dapr.io/getting-started/quickstarts/ Status: 200
	https://github.com/dapr/community/blob/master/CODE-OF-CONDUCT.md Status: 200

Hey @pngan thanks a lot for doing the local checks.  Also good call pasting in exactly what you tried.  I can see you're in the root of the quickstart folder when you run make validate.  Make validate is not recursive deep into the folders, so that only tested the readme in the root folder and it did not go deeper into any of the specific quickstarts like C# Actors.
Now please try make validate in your ~/github/forked/dapr/quickstarts/actors/csharp/sdk folder.  I'm going to guess you will see a different result before and after the changes merge.

@paulyuk  I've merged the branch with the additional changes. We're ready to run pull request checks workflow again.

Something to be aware of, on my local machine, the actor quickstart exercise, and validation fails, where the client is unable to establish a connection to the actor.  Not sure if this a problem on my machine specifically.  Retrying in 1s…" app_id=actorclient instance=z420 scope=dapr.runtime type=log ver=1.12.2
		== APP == Unhandled exception. Dapr.DaprApiException: error invoke actor method: failed to invoke target <IP_ADDRESS>:35937 after 3 retries. Error: rpc error: code = Unavailable desc = last connection error: connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:35937: connect: connection refused"
		== APP ==    at Dapr.Actors.DaprHttpInteractor.SendAsyncHandleUnsuccessfulResponse(Func`1 requestFunc, String relativeUri, CancellationToken cancellationToken)
		== APP ==    at Dapr.Actors.DaprHttpInteractor.SendAsync(Func`1 requestFunc, String relativeUri, CancellationToken cancellationToken)
		== APP ==    at Dapr.Actors.DaprHttpInteractor.InvokeActorMethodWithRemotingAsync(ActorMessageSerializersManager serializersManager, IActorRequestMessage remotingRequestRequestMessage, CancellationToken cancellationToken)
		== APP ==    at Dapr.Actors.Communication.Client.ActorRemotingClient.InvokeAsync(IActorRequestMessage remotingRequestMessage, CancellationToken cancellationToken)
		== APP ==    at Dapr.Actors.Client.ActorProxy.InvokeMethodAsync(Int32 interfaceId, Int32 methodId, String methodName, IActorRequestMessageBody requestMsgBodyValue, CancellationToken cancellationToken)
		== APP ==    at SmartDevice.Program.Main(String[] args) in /home/phil/github/forked/dapr/quickstarts/actors/csharp/sdk/client/Program.cs:line 68
		== APP ==    at SmartDevice.Program.<Main>(String[] args)
		ℹ

This may be unrelated to the pull request, but on my local machine, the actor quickstart exercise and the actor validation fails, where the client is unable to establish a connection to the actor. I suspect this is a problem on my specific machine because this error also occurs using .NET 7 and release-1.13 for me.  Retrying in 1s…" app_id=actorclient instance=z420 scope=dapr.runtime type=log ver=1.12.2
		== APP == Unhandled exception. Dapr.DaprApiException: error invoke actor method: failed to invoke target <IP_ADDRESS>:35937 after 3 retries. Error: rpc error: code = Unavailable desc = last connection error: connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:35937: connect: connection refused"
		== APP ==    at Dapr.Actors.DaprHttpInteractor.SendAsyncHandleUnsuccessfulResponse(Func`1 requestFunc, String relativeUri, CancellationToken cancellationToken)
		== APP ==    at Dapr.Actors.DaprHttpInteractor.SendAsync(Func`1 requestFunc, String relativeUri, CancellationToken cancellationToken)
		== APP ==    at Dapr.Actors.DaprHttpInteractor.InvokeActorMethodWithRemotingAsync(ActorMessageSerializersManager serializersManager, IActorRequestMessage remotingRequestRequestMessage, CancellationToken cancellationToken)
		== APP ==    at Dapr.Actors.Communication.Client.ActorRemotingClient.InvokeAsync(IActorRequestMessage remotingRequestMessage, CancellationToken cancellationToken)
		== APP ==    at Dapr.Actors.Client.ActorProxy.InvokeMethodAsync(Int32 interfaceId, Int32 methodId, String methodName, IActorRequestMessageBody requestMsgBodyValue, CancellationToken cancellationToken)
		== APP ==    at SmartDevice.Program.Main(String[] args) in /home/phil/github/forked/dapr/quickstarts/actors/csharp/sdk/client/Program.cs:line 68
		== APP ==    at SmartDevice.Program.<Main>(String[] args)
		ℹ

Very nice!  I kicked off tests.  I agree let's see how the formal CI tests do.  The timing of the actors test is very picky, and sometimes running it again will show different results.

Just waiting on tests, and then we'll merge.

@paulyuk  All tests have passed. You are all good to merge (I don't see the merge button)

It's great -- thank you @pngan for this important contribution!  We really needed .NET 8 support!


Adding Format Output to CLI

What would you like to be added:
I'd like to have the option to determine how the output of the CLI should look like. Right now we just fmt.Println but what's actually needed is similar like in kubectl itself the option to decide how the output should look like, e.g.: kubectl kudo get instance kafka -o yaml
Why is this needed:
This helps not just for testing the CLI behavior but also gives more options in how to format or sort the output of certain commands. It should be closer to kubectl itself ( see also https://kubernetes.io/docs/reference/kubectl/overview/#output-options ).

We need to be able to specify format type -o yaml and -o json

We've partially added it to some commands, let's rather open an issue per-command than have this big umbrella issue


Document name restrictions for multi-port services

Add note in documentation about port name restrictions.

/assign @steveperry-53

/approve
/lgtm


chore: Clean Up Repo Root

Description 📝
Why?

I'm trying to clean up the root of our repo because it is bloated with lots of random config files
We have a nice new readme and this will make it easier to see without needing to scroll on Github

Overview

Consolidates two eslint files into one
Deletes .npmignore because it is empty and I'm 99% sure it is doing nothing meaningful
Deletes old changelog tooling because we don't use it and haven't used it in years

How to test 🧪

Not much to test here but you can test the eslint still works

One way to do this is to create a duplicate variable  in a random component and ensure that your IDE shows an eslint warning

I'm thinking the empty .npmignore may have been put there deliberately to prevent npm from ignoring files that match our .gitignore patterns

I don't think it matters because api-v4 and validation's package.jsons specify "files": [ "lib" ] so when it comes to shipping those packages, they should pull only those files.


Cleanup resourceID/chainID/executeProposal tests

As far as renaming goes in these tests, it all seems fine to shift origin to source. However, I think semantically the tests aren't correct. It seems we:

Create a linkable anchor on the source chain
Vote on update proposals created with source chain ID on source chain anchor

Doesn't this seem wrong? We should be creating update proposals for dest chain ID no? The linkable anchor on source chain should be bridged (addEdge/updateEdge) with the dest chain. Can you verify that these tests include that?

All of the proposal tests have the Bridge instance instantiated on destChainID along with a corresponding handler and anchor on  destChainID. The vote and execute proposal calls are all voting and acting through the bridge on the destChainID chain after a deposit happens on the source chain so the update proposals are on the correct chain for all these tests. This design carries over from the chainBridge depositProposal tests that I didn't change.
Thank you for the help with the naming convention I have been a bit messy with that I understand. For future reference should a branch like this be called "kelton-clean-up" or what do you think would be a proper name.


Import and Export of security roles

The documentation does not talk about how to import and export security roles

Closing this issue as a duplicate of #1835


Add GSP national pipeline

Detailed Description
Add a pipeline that loads GSP national data.
Context
Useful for modelling PV national modelling
Dont need a spacial slice.
Might want to reduce NWP to 20KM grid, this would 100 smaller than large 1TB file
Possible Implementation

Load GSP, but only national data
Load NWP data
merge time periods
pick random time period

Later

add satellite data, as we are aiming to do a National forecast for +36 hours, where satellite data will be less useful
add pv data, as we are aiming to do a National forecast for +36 hours, where satellite data will be less useful

Ive added this to https://github.com/openclimatefix/ocf_datapipes/blob/main/ocf_datapipes/training/gsp_national.py. This only loads GSP and NWP data. @jacobbieker you might want to use this and expand it to use pv and satellite data

Or perhaps leave this one, and add another data pipeline. Then this can be used to benchmark

Sounds good! I'm adding this in #69


Added a note to highlight  difference between -AzureAD and -AzureADMS cmdlets

Docs Build status updates of commit d186cc3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d186cc3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azureadps-2.0/install-adv2.md
:white_check_mark:Succeeded
View (azureadps-2.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Fixes #607.

@CelesteDG , please review this.

Docs Build status updates of commit 435e444:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azureadps-2.0/install-adv2.md
:white_check_mark:Succeeded
View (azureadps-2.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @CelesteDG, correction made. Thanks.


Proposal for collaborative maintenance of this project

@swinton  Thanks for putting together this streamlined GitHub Action :pray: :100:
Would you consider adding other maintainers to help integrate outstanding pull requests and performing general maintenance ?
In the meantime, you will find the following pull requests:

https://github.com/swinton/screenshot-website/pull/35
https://github.com/swinton/screenshot-website/pull/36

I see a couple of warnings in my GitHub Actions workflow that I think stem from the<EMAIL_ADDRESS>GHA:

The following actions uses node12 which is deprecated and will be forced to run on node16<EMAIL_ADDRESS>For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/Show

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@jcfr I saw that you started this thread some months back. Did you have any luck reaching @swinton?
Would be great if we could collaborate here to get this GHA back into a state where we can all continue to uses it. And yes, that means that I am offering my help as well :)

Did you have any luck reaching @swinton?

I haven't received a response so far.

And yes, that means that I am offering my help as well :)

That is great. Thanks for offering to help.

back into a state where we can all continue to uses it.

I completely agree. It's essential to find a solution that ensures ongoing collaboration and maintenance.
I am thinking of a few options:
(1) https://github.com/jcfr
We could consider using my personal fork of the project as its new home.
(2) https://github.com/Slicer
Since we are currently using this action in the context of continuous integration for the slicer.org website^1, we might want to create a fork within the Slicer organization.
I'll make sure to discuss this with the community before making any decisions, but I don't anticipate any issues.
Other GitHub user or organization ?
If you have any other suggestions for a more suitable home, please feel free to share.

I don't have a strict preference.
Of course it would be best if we could keep it where it is (i.e. at https://github.com/swinton/screenshot-website) as that might allow us to make the fixes without breaking existing workflows of other users.
However I agree that currently it looks like that might not be possible.
In that case, we could start at https://github.com/jcfr and make all fixes that we need to make. Once we got things working, we can still to move the project into the https://github.com/Slicer org, if you want.
We probably don't have to think about the "where should it live" decision that much right now, as I assume that your fork at https://github.com/jcfr/screenshot-website doesn't have that many users right now, does it? :) i.e. we could move it later without much disruption?

Would you consider adding other maintainers to help integrate outstanding pull requests and performing general maintenance ?

Yes, definitely. Thank you for the proposal and apologies for my delay in responding.
@jcfr I've invited you to the repo, so you should have push access.

Happy to also discuss a more suitable long-term plan, perhaps under a dedicated org. Feel free to email me directly as well, stevewinton[at]gmail 🙏

To follow-up on this, @swinton invited me to collaborate :pray: , waiting we settle on a more longer term plan, this should allow to move forward :rocket:

Very awesome to hear!

Update

The set-output command is deprecated and will be disabled soon.

For future reference, this has been addressed in the following pull request:

https://github.com/swinton/screenshot-website/pull/64

Next
Release of v1.1.0 along with update of branch v1.x will happen soon.

@jcfr that's great.
I tested this in my workflow directly from /screenshot-website@main.
Can confirm that this made the set-output warning disappear :)

Can confirm that this made the set-output warning disappear :)

Thanks for confirming it works on your side :100:

@jcfr are you still planning to cut the v1.1.0 release, or did you run out of time? :) I totally understand in any case, this happens!


I made you a project logo

The value of logo in app.json was resulting in the Heroku deploy page looking like this 😞

I made you a logo so that it now looks like this (with this PR) 😄

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   98.03%   98.03%
=======================================
  Files           5        5
  Lines          51       51
=======================================
  Hits           50       50
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4708da...10a9fe8. Read the comment docs.

It's so beautiful 😌
Thanks!  👍


Sketch out high level gateway docs

Start documenting the Gateway by adding high level description of:

[x] What the gateway is
[x] The Gateway component and their interactions
[x] Local deployment of a Gateway (in dev env) and pointer to the recently added gateway-cli
[x] Add in-progress undocumented sections on gateway deployment and management, to be filled in as we evolve the gateway

Codecov Report
Base: 64.18% // Head: 64.18% // No change to project coverage :thumbsup:

Coverage data is based on head (204ddae) compared to base (d9e253e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #927   +/-   ##
=======================================
  Coverage   64.18%   64.18%
=======================================
  Files         112      112
  Lines       16391    16391
=======================================
  Hits        10520    10520
  Misses       5871     5871

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Travis fix

Travis is red on master.  Strangely enough the first red build was a change to only README.md ... sigh.  So gonna try a few things.
The build is already green on version-3.1.1-dev but having the red build on master is not a good look.

Well the build passes now ... still fails on my machine but I guess one thing at a time!


AssertionError: MMCV==1.7.2 is used but incompatible. Please install mmcv>=2.0.0rc4, <2.2.0.

Thanks for your error report and we appreciate it a lot.
Checklist

I have searched related issues but cannot get the expected help.
I have read the FAQ documentation but cannot get the expected help.
The bug has not been fixed in the latest version.

Describe the bug
A clear and concise description of what the bug is.
Reproduction

What command or script did you run?

A placeholder for the command.

Did you make any modifications on the code or config? Did you understand what you have modified?
What dataset did you use?

Environment

Please run python mmdet/utils/collect_env.py to collect necessary environment information and paste it here.
You may add addition that may be helpful for locating the problem, such as

How you installed PyTorch [e.g., pip, conda, source]
Other environment variables that may be related (such as $PATH, $LD_LIBRARY_PATH, $PYTHONPATH, etc.)

Error traceback
If applicable, paste the error trackback here.
A placeholder for trackback.

Bug fix
If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!

root@autodl-container-f77d11adac-3ed8119f:~/mask/mmdetection-master/mmdet/utils# python collect_env.py
No CUDA runtime is found, using CUDA_HOME='/usr/local/cuda'
Traceback (most recent call last):
File "collect_env.py", line 5, in
import mmdet
File "/root/miniconda3/lib/python3.8/site-packages/mmdet/init.py", line 16, in
assert (mmcv_version >= digit_version(mmcv_minimum_version)
AssertionError: MMCV==1.3.17 is used but incompatible. Please install mmcv>=2.0.0rc4, <2.2.0.
root@autodl-container-f77d11adac-3ed8119f:~/mask/mmdetection-master/mmdet/utils# A placeholder for the command.
i not good at using the github ,could u plz help deal with the problem? i  install the mmcv2.0.0rc4 but still with problems

it seems to solve it by update mmcv2.0.0rc4


Support for retrieving/storing large samples with multiple streams

S3 API allows storage and retrieval of large files in chunks for better efficiency.

For reference to others reading this, we have left this out on purpose and created an issue to document a potential enhancement. While this is a simple adjustment, it is not needed at this time as most of the analysis objects we support are small in size.


JavaScript/Typescript Upper_Snake_Case issues

Describe the issue
Wen you have non standard code style - using Upper Snake case in this instance - most types of Ids except for variable that is assigned arrow style function, have highlight that is composed of two colors, rendering only first part of Id correctly.
Which language seems to have the issue?
TypeScript/JavaScript
Are you using highlight or highlightAuto?
I noticed this issue on StackOverflow and ChatGPT and would like to see naming style I use highlighted properly
Sample Code to Reproduce
type Only_First_Is_Highlighted = any

const idCamel = "no highlight for basic id"
const snake_camel = "also as expected"
const PascalCase = "here is different Highlight"
const Upper_Snake = "this again breaks"
const SCREAMING_combined = "this is not highlighted as basic id"
const SCREAMING_SNAKE = "this is as ist should be"

const dict = {
	camelKey: "works",
	PascalKey: "different color, but still not broken",
	Upper_Snake_Case: "broken",
}

// everything in this case is consistend id is identified as
// const function and colored same way
const camelCaseFnWorks = () => {}
const snake_works = () => {}
const Upper_Snake_Works = () => {}
const SCREAMING_SNAKE = () => {}

//all below are broken
type Upper_Snake_Case = (min: number, max: number) => number

const Upper_Snake_Case: Upper_Snake_Case = function(min, max) {}

const SCREAMING_SNAKE: Upper_Snake_Case = function(min, max) {}

const Upper_Case = function(min, max) {
    return Math.floor(Math.random() * (max - min + 1)) + min;
}

// lower snake case here is consistent with camel case

const lower_snake_case = function(min, max) {}
const camelCase = function(min, max) {}

const lower_snake_case: Upper_Snake_Case = function(min, max) {}
const camelCase: Upper_Snake_Case = function(min, max) {}

Here github code for instance has no broken Upper Snake Case

Expected behavior
Single Id of any kind should not be colored in 2 separate colors.

I think we'd be open to a simple patch to NOT highlight identifiers Upper_Snake_Works.  This is no type of idiomatic JS I've ever seen.  If you have a pointer to some specific guides I'd be willing to check them out.  I checked out the GitHub guide just quickly and it had no mention I saw of this time of mix of camel case and snake case.
It looks like Github is tagging this smi and not highligthing it the same as the other variables.  Do we know what smi is?

for this non idiomatic JS.

Exactly. We don't care much about highlighting non idiomatic JS "correctly" or that we poorly highlight non idiomatic JS.  We're solving for the most common use cases here.  However, as I mentioned, if a simple enough patch was proposed to prevent poor highlighting of these mixed Camel+Snake case we'd likely accept it.  Probably a matter of matching on a word boundary in addition to a negative lookahead for the underscore.
We highlight only valid syntax and very popular idiomatic patterns that are common.
The highlighting is all based on regex patterns. You could indeed highlight these weirdly named variables/constants if you wrote a custom grammar to do so and wrote the appropriate regex.  If you want to modify grammars or buid your own I'd suggest reading our docs and then becoming familiar with regex patterns for describing matches.

Ok, I will let you know what I find about it and whether there is some simple solution, I started  go through some code and will look more into how this all works internally, thank you for comment.

Hi, so I created PR, I discovered one more case where it was working before changes (class declaration).
I looked into the code a little, made a tiny change to one regex, this didn't affect any highlighting that was working before, and all the naming is now consistent across the rules.
I just wasn't sure where to put new markups so I created new one inside TS markups which checks all the things that are common with JS but also has code with TS types.

Closing as #wontfix.  We will highlight idiomatic PascalCase class name only.


initial variant for support command

This was superseded by https://github.com/PANTHEONtech/StoneWork/pull/107


perf: faster test run

Makes npm run test more than twice as fast.

if you disable typescript, flow, esm, and jsx you can achieve the same speed without removing functionality.

Changed. It's faster... but not as far. 22s vs 14s

running code coverage for every run locally is important, otherwise prs will fail while it would pass locally.

running code coverage for every run locally is important, otherwise prs will fail while it would pass locally.

I'm original suggestion was to always run it through the pre-commit hook, but not when manually running npm test.

Ok, let's do that.

PTAL


Upgraded for CP4S version 1.9

Upgraded for IBM Cloud Pak for Security version 1.9
Issue #, if available:
Description of changes:
Updated CloudFormation templates, scripts and docs for Quick Start deployment guide.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vsnyc Please, merge for new updates.

@vsnyc please review and merge for latest updates. thanks.

@vsnyc please review and merge this request for the latest updates. thanks.

@ShinuShaju - acknowledging the PR. We have changed our documentation process slightly so this will need some more work. I'll come back to it next week.


More fixes to Asset.Command

Further argument reordering
Get rid of over verbose Sequence lookups
Add tests for Asset.Command

Coverage increased (+0.3%) to 29.899% when pulling 4302bcd071fc77521809ae4d3fcb8d5a6f7ac128 on asset-command-fixes into 653ae2c47f6f2014caf369e9e952e80116d05a0f on next.


#89 adding the react-helmet example.

I don't know if my code would be the best practice, but I'm sending this PR for making some progress for the issue #89

This doesn't change the title as you navigate on the client, does it?

it does change the title when you navigate on the client.
The current code both working on server and client.
I only implemented three pages for the title changes, Login, About and Home.

May be I should explain that the current practice for the title/meta tag navigate is by dispatching the action function updateTitleObj inside the fetchData method, then after the apptitle reducer changed, the page title / meta tag should be automatically changed, and it runs both on client and server if you are calling it from fetchData.

This cannot possibly work on the server, as you are not calling Helmet.rewind() anywhere, nor are you setting the values in Html.js.
I went briefly down the road of keeping meta tag data in the redux store, but I think it's a mistake. Doing it with a component in render() is sufficient. react-side-effect is excellent at managing this type of state.


CSR Commentary on Side Effects

From https://github.com/riscv/riscv-isa-manual/blob/master/src/csr.tex#L134-L137:
  The CSRs defined so far do not have any architectural side effects beyond
  raising illegal instruction exceptions on disallowed
  accesses.  Custom extensions might add CSRs with side effects on
  reads and/or writes.

I'm not sure exactly what is meant by "The CSRs defined so far", but if you are considering the floating point CSRs and mstatus from the privileged spec, then writing to any of the floating point CSRs should  have the side effect of setting the mstatus.fs bits to dirty.

Thanks, amended the comment so it only applies to read side effects, not writes.


chore: rename ceresdb to horaedb

Expect org name occurance.
This refers to https://github.com/CeresDB/horaedb/issues/1319.

I seem to have incorrectly changed the start year of the Apache protocol from 2022 to 2023 earlier, should we change this back to 2022?  https://github.com/CeresDB/horaedb/pull/1134

I seem to have incorrectly changed the year of the Apache license from 2022 to 2023 earlier, should we change this back to 2022? https://github.com/CeresDB/horaedb/pull/1134

Since we are doing the globally rename now, I think it's OK to go.

Closing..
There is a cycle dependecies on IT cases (due to rename CeresmetaRcpService -> HoraeMetaRpcService). I don't have time to resolve it today. Close for others pick up.