Wezterm (20230712.072601.f4abf8fd-1, stable) insta crash on hyprland main branch

Hyprland Version
9d2a5fb
Bug or Regression?
Bug
Description
It crashes instantly with error:
ERROR  wezterm_gui > running message loop: error during event_q.dispatch protocol_error=None: Bad address (os error 14); terminating

Here's working status matrix:
Wezterm | Hyprland | Status
---------------------------
Release | Release  | OK
---------------------------
Git     | Release  | OK
---------------------------
Release | Git      | Crash
---------------------------
Git     | Git      | OK

I would've use git version of wezterm, but it comes with it's own issues:
https://github.com/wez/wezterm/issues/4504
https://github.com/wez/wezterm/issues/4501
Which renders it... hard to use to say the least.
How to reproduce

Install release version of wezterm
Install git version of hyprland
launch wezterm

Crash reports, logs, images, videos
None

Also experiencing the exact same issue but with a different error:
interface 'wl_surface' has no event 2
08:29:47.391  ERROR  wezterm_gui > running message loop: error during event_q.dispatch protocol_error=None: Resource temporarily unavailable (os error 11); terminating
warning: queue 0x557f1410ed70 destroyed while proxies still attached:
  wl_data_offer@4278190081 still attached
  wl_data_offer@4278190080 still attached
  wl_buffer@55 still attached
  wl_buffer@54 still attached
  wl_buffer@29 still attached
  wl_buffer@31 still attached
  wl_callback@32 still attached
  wl_buffer@53 still attached
  wl_buffer@52 still attached
  wl_buffer@51 still attached
  wl_buffer@50 still attached
  wl_subsurface@49 still attached
  wl_surface@48 still attached
  wl_subsurface@47 still attached
  wl_surface@46 still attached
  wl_subsurface@45 still attached
  wl_surface@44 still attached
  wl_subsurface@43 still attached
  wl_surface@42 still attached
  wl_subsurface@41 still attached
  wl_surface@40 still attached
  xdg_wm_base@22 still attached
  wl_surface@21 still attached
  wl_data_device@18 still attached
  wl_pointer@16 still attached
  zwp_text_input_v3@15 still attached
  wl_keyboard@14 still attached
  zwp_primary_selection_device_v1@13 still attached
  zwp_primary_selection_device_manager_v1@3 still attached
  wl_data_device@12 still attached
  wl_output@11 still attached
  zwp_text_input_manager_v3@10 still attached
  zxdg_decoration_manager_v1@9 still attached
  wl_seat@8 still attached
  wl_data_device_manager@7 still attached
  wl_subcompositor@6 still attached
  wl_compositor@5 still attached
  wl_shm@4 still attached
  wl_registry@2 still attached

I'm running hyprland-git(AUR) and wezterm packages on Arch Linux

Not just Wezterm, OpenRGB and Dolphin (qt apps)
Only within the past few days, doesn't happen on stable branch
99% sure this is fractional scaling only problem
Latest git pull, same issue:
Error sending request: Resource temporarily unavailable
The Wayland connection experienced a fatal error: Resource temporarily unavailable

99% sure this is fractional scaling only problem

I did try with 1.0 scaling but the same error is still there. Also, wezterm works correctly on sway, mutter and kwin even with 1.25 scaling for me.

I have the same issue on the hyprland-git AUR package. It's working properly on the stable release (0.30.0-1) and crashes on git version (needed to try out the windows cycling patch).
I don't use fractional scaling, here's my monitor configuration:
monitor=DP-1,highrr,0x0,1,bitdepth,10
monitor=DP-2,preferred,2560x0,1,bitdepth,10,transform,3

And here's the same error people above are reporting:
interface 'wl_surface' has no event 2
15:17:38.818  ERROR  wezterm_gui > running message loop: error during event_q.dispatch protocol_error=None: Resource temporarily unavailable (os error 11); terminating
warning: queue 0x5602a9142330 destroyed while proxies still attached:
  zwp_primary_selection_offer_v1@4278190083 still attached
  zwp_primary_selection_offer_v1@4278190082 still attached
  zwp_primary_selection_offer_v1@4278190081 still attached
  zwp_primary_selection_offer_v1@4278190080 still attached
  wl_callback@35 still attached
  xdg_wm_base@23 still attached
  wl_surface@22 still attached
  wl_data_device@19 still attached
  wl_pointer@17 still attached
  zwp_text_input_v3@16 still attached
  wl_keyboard@15 still attached
  zwp_primary_selection_device_v1@14 still attached
  zwp_primary_selection_device_manager_v1@3 still attached
  wl_data_device@13 still attached
  wl_output@12 still attached
  wl_output@11 still attached
  zwp_text_input_manager_v3@10 still attached
  zxdg_decoration_manager_v1@9 still attached
  wl_seat@8 still attached
  wl_data_device_manager@7 still attached
  wl_subcompositor@6 still attached
  wl_compositor@5 still attached
  wl_shm@4 still attached
  wl_registry@2 still attached

@Zedo9  hey I'm having the exact same error on NixOS aswell! But I can open Dolphin just fine with scaling enabled
{ config, lib, pkgs, inputs, ... }:

let
  nvidia = if config.variables.machine.gpu == "nvidia" then true else false;
  machineScale = if config.variables.machine.buildType == "laptop" then
    ",highres,auto,1.25"
  else
    ",preferred,auto,auto";

in {
  #home.packages = with pkgs; [ kitty ];
  home.sessionVariables = {
    # toolkit-specific scale
    GDK_SCALE = "2";
    XCURSOR_SIZE = "32";
  };

  #imports = [ inputs.hyprland.homeManagerModules.default ];
  wayland.windowManager.hyprland = {
    enable = true;
    package = pkgs.inputs.hyprland.hyprland;
    enableNvidiaPatches = nvidia;
    settings = {
      # change monitor to high resolution, the last argument is the scale factor
      monitor = "${machineScale}";

      # unscale XWayland
      xwayland.force_zero_scaling = true;

      "$mod" = "SUPER";

      bind = let terminal = config.home.sessionVariables.TERMINAL;
      in [
        "$mod,RETURN,exec,${terminal}"
        "$mod, C, killactive,"
        "$mod, M, exit,"
        "$mod, E, exec, dolphin"
        "$mod, V, togglefloating,"
        "$mod, R, exec, wofi --show drun"
        "$mod, P, pseudo," # dwindle
        "$mod, J, togglesplit," # dwindle
      ];
    };
    /* extraConfig = ''
       '';
    */
  };
}

And as for what version of Hyprland I'm using, I'm the latest github version on my flake like this
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";

    home-manager = {
      url = "github:nix-community/home-manager";
      inputs.nixpkgs.follows = "nixpkgs";
    };

    hyprland.url = "github:hyprwm/Hyprland";
... more afterward

FYI: A few days ago a similar bug report was closed by vaxerski with the statement that it's not a bug in Hyprland but rather one in wezterm. I compiled the latest wezterm from the main branch and the error seems to be gone indeed (I get another error but it's non-fatal to wezterm, it runs fine.)

https://github.com/hyprwm/Hyprland/issues/3666
That's what I thought.


ss4 compatibility

hi @micschk Any plans on updating this for SS4?

We haven't worked with SS4 yet except for just checking it out. Once we start upgrading client projects to SS4 we will start updating modules which require this as well.
Unless someone beats us to it ;)
For now, the intention is there but no timeline yet, sorry..


Spacing and headers changed. Content unchanged.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/on-error-statement.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Pull request 591 is replaced by pull request 647, "Format the On Error statement."


VHS 1256 b spectral data ingest

Ingesting VHS 1256 b spectral data...
JHK band data from Gauza+2015, L band data from Miles+2018.
vhs1256b_spectra_Figure8_Gauza2015.txt
vhs1256b_spectra_Figure8_Miles2018.txt

Also:

2MASS photometry
other name: VHS 1256b

This is the data from Gauza+2015. No calibration and just normalised.
vhs1256b_optnir_werrors.txt

#285 just has photometry, no spectroscopy yet!

Progress on this in #276.
One issue is that the NIRSPEC spectrum from Miles2018 has a bunch of crappy data in it and really should have been trimmed. I'm having a hard time ingesting the noise and want to trim it in our converted version. What do other people think?

Closed by #296


Autoscale: Add preview release 3.9.0

Pull Request Template
Description
Bumping the preview version to 3.9.0-preview
Updating autoscale to api and bumping the preview release.

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

closes #1330, #1365

Nice. I will try this out soon in our own preview branch.


Allow user to specify origin location on Globus

Allow the user to tell us if their content is on Google Drive, Oak, or Sherlock so that we can send a more precise link that will open the Globus file manager with the origin open on one side and the destination open on the other side. This will make getting to the right place in Globus much easier for users, because it's very challenging to navigate around the Globus interface.
Allow the user to tell us if their content is on a different endpoint (by not selecting any of the fixed options) and provide us with the info we need to generate the more precise link to that endpoint. What we need from them may be the UUID for the endpoint, but we need to look into that.
The link in box/step 3 should go to https://docs.google.com/document/d/10b7y3yZCOfyVJ_uP4l7QHbkILQKnfdJi9hj-MpmmdIk/edit (top of the page) and not to a specific header (I'm not sure where that points now). Also, we are not including the "Print instructions" link show in this image.
Updated design:

See also #3116, #3021 and #3049
See designs at https://projects.invisionapp.com/share/YQ132HXFX2GR#/screens/472346509_Globus_Auto_Account
Information from the folks at Globus on how to create these links:

File Manager application links with pre-selected endpoints
— Query parameters supported: destination_id, destination_path, origin_id and origin_path
-- Example https://app.globus.org/file-manager?destination_id=ddb59aef-6d04-11e5-ba46-22000b92c6ec&destination_path=%2F~%2F&origin_id=2fde89c0-6fb4-11eb-8c47-0eb1aa8d4337

Note that we currently have Globus send the link to the shared folder, I think because we didn't know how to figure out what the direct link would be, but they say this is knowable:
origin_id is the endpoint id of source, origin_path is the source path. Those must be available from when you set permission for the user on a specific folder. You can use that to construct the URL.

@amyehodge needs to inquire with Karl Kornel what existing options there are, or how someone could provide us with a link for their GCP endpoint possibly.
@astridu Let's talk about the designs needed to implement this. For a list of things like Oak, Sherlock, etc. we may only need check boxes or a dropdown list. For providing a link to your own endpoint, that would require something else.

@amyehodge

Are items 2 and 3 in the description above the same?
Do we know what entering "other" does to the link we create?
Can I split these into two (or three) tickets?

@peetucket

Are items 2 and 3 in the description above the same?

They are mocked up as part of the same option, but I consider it a higher priority to provide the three checkboxes for Sherlock, Oak, and Google Drive that for users to be able to give us a link to a specific other endpoint. So I think these could be ticketed separately. Or not if it doesn't make sense to you to separate them out.

Do we know what entering "other" does to the link we create?

Users should only be entering a link to a Globus endpoint here. I've asked Astrid to update the option text to "Other Globus endpoint" and the GDrive to "Stanford Google Drive" (non-Stanford will not work).
There is info above about what we need to compose the link based on the info about the endpoint. Karl Kornel should be able to assist with how to do this. We may need to restrict users to entering a link formatted a certain way to make sure it's to a Globus endpoint?

Can I split these into two (or three) tickets?

Sure. However you think makes the most sense.

Get Astrid's input on:

eliminate text box next to "other"
reconsider use of radio buttons (allowing user to not do anything if not one of box/sherlock/gdrive)

Then update text descriptions of feature in ticket/docs to match and update designs.

@astridu a few thoughts on this after we discussed:

eliminate text box next to "other" (don't need it anymore)
reconsider use of radio buttons (allowing user to not do anything if not one of oak/sherlock/gdrive)

Then update text descriptions of feature in ticket/docs to match and update designs.

@peetucket @amyehodge
here are a couple of options. The second option doesn't require the user to select an option from the dropdown, but might just be more clear to have the radio buttons. The last option is more complicated in that if user selects 'Yes', then we have to present them with another set of radio buttons for them to select which one. Let me know which you prefer.

@astridu @peetucket I feel like the question in the last option is the clearest, but the added complexity of the design is a drawback. Can we somehow combine these? Perhaps use the first design with the radio buttons, but the question would be "Are your files on Stanford Google Drive, Oak, or Sherlock?" And the choices could be:

Yes, Stanford Google Drive
Yes, Oak
Yes, Sherlock
No, they are somewhere else.

Are those choices too wordy?

I think all of the 'yes' seems a a bit wordy to me.  I also like the compactness of the drop down menu vs radio buttons.
Another option:
"If your files are on Stanford Google Drive, Oak, or Sherlock, select it below."
-- drop down menu with those three options ---
If the user selects nothing, it's other.  So basically so action needed for other.  Even if it is one of those options and they do nothing, it doesn't close it off (they can still upload from those locations in the globus client, they just don't get a handy link shortcut).

Thanks @peetucket. That's better. I agree my suggestion was really wordy.

So maybe if @astridu agrees, she can update the design, I can update descriptions, we can remove "design needed" and move to ready.

Yes, sorry for the delay, here it is.

@peetucket 💬

So maybe if @astridu agrees, she can update the design, I can update descriptions, we can remove "design needed" and move to ready.

It looks like we're good to go. I'll read through the comments and work on this today.

@astridu 💬

Yes, sorry for the delay, here it is.

Thank you!

Thanks @astridu ... i updated the screenshot in the body of the ticket description to the new design.  If possible, would you mind updating https://projects.invisionapp.com/share/YQ132HXFX2GR#/screens/472346509 to avoid any potential future confusion (or at least mark that design as old)?

updated
https://projects.invisionapp.com/share/YQ132HXFX2GR#/screens/472346509

Google Drive: https://app.globus.org/file-manager?origin_id=e1c8858b-d5aa-4e36-b97e-95913047ec2b
Oak: https://app.globus.org/file-manager?origin_id=8b3a8b64-d4ab-4551-b37e-ca0092f769a7
Sherlock: https://app.globus.org/file-manager?origin_id=6881ae2e-db26-11e5-9772-22000b9da45e


Patch releases needed for CVE to remove unneeded major release churn (0.13.1?)

Feature Request
Is your feature request related to a problem? Please describe.
For OLM, we have seen that very few patch releases are put out (0.13.0 to 0.13.1) for fixing basic CVEs base image issues like we had with CVE-2019-1551 for packages libssl1.1libcrypto1.1
Right now I see a major release 0.14.1 being worked, but it contains a high level of changes unrelated to fixed the actual 0.13.0 CVE.   This causes unnecessary churn on our side to try to make everything work with a new major release, instead of just getting the base image fixed and a small patch release.
Describe the solution you'd like
For CVEs, would like to see more patch release to pick up simple base image package update.    This means a bit more release churn, but much easier to consume the patch releases without the need to also absorb the major release content.
It should be possible to create a 0.13.1 patch release with just the CVE package update, right?

@kramvan1 it is possible to create patch releases for CVE updates but actually not necessary. Despite the semver we are not deprecating APIs so far, so updating to new y-stream shouldn't break anything.

@dmesser   Agreed, but there's an additional risk with pulling in a bunch of new repo code changes/fixes for just a simple base OS change.   Maybe need to reduce the base OS footprint to reduce the CVEs.

@kramvan1 I agree on reducing the base footprint for upstream images. I do not think that at this point we will have the resources to z-stream releases for vanilla upstream.

ok, will continue as is for now, when we see a CVEs, will ask for a z-stream release to pick it up.


add bulk deletion feature

Make a MDELETE command. Implement atomic deletion.
Proper error handling for non existent keys as well.
points will be assigned based on your implementation.

can i get this assigned @reema-s1

!assign @kavin81

!extend 90

@reema-s1  #5


Fix library authors example's syntax issue

There were some syntax and scope issues on the example.
This should fix it.
(the code wouldn't without this fix, there were mismatched braces)
It would be nice to run prettier on the markdown, it can catch some of this bugs (: and provides a more consistent style throughout the docs

Thanks for the fixes!

It would be nice to run prettier on the markdown, it can catch some of this bugs (: and provides a more consistent style throughout the docs

Hmm, I thought it should have been running - I have
"lint-staged": {
    "*.{js,json,css,md}": [
      "prettier --write",
      "git add"
    ]
  },

in the package.json, so I'm not sure why it wouldn't be running? Though looking at that config again now that should definitely also include .ts 🤦♂


Enable SBOM generation in meta-elisa

SBOM generation can be done with latest yocto version used in needlefish. The idea is to switch this on for the instrument cluster demo. This would be input for the SBOM interested within the systems WG.

On Wed, 14 Dec 2022 at 09:08, Philipp Ahmann @.***>
wrote:

@sudipm-mukherjee https://github.com/sudipm-mukherjee provided a first
SBOM in "PRETTY" format to @kestewart https://github.com/kestewart and
Nicole for further analysis.
Continues creation to be added to CI.

There had been a small problem in adding SBOM pretty format to CI as the
pretty format generation is not part of  Yocto Kirkstone yet. I have
discussed this with Yocto people and have requested the maintainer to
backport the feature in next Kirkstone release which will be v4.0.6. Till
then, they suggested we will need to carry this as a patch. I will now
check how this can be done.
--
Regards
Sudip

Respective commit for the backport: https://git.yoctoproject.org/poky/commit/?h=kirkstone&id=99483cff5c358d847ceb077349321eb57d5143e4


Uncaught TypeError: Arguments to path.join must be strings

[Enter steps to reproduce below:]
I completed the installation instruction described here: https://github.com/JunoLab/atom-julia-client/tree/master/manual
And have the following packages installed:
julia> Pkg.status()
1 required packages:

Atom                          0.2.0
11 additional packages:
CodeTools                     0.2.0
Compat                        0.7.7
FactCheck                     0.4.1
Hiccup                        0.0.1
JSON                          0.5.0
JuliaParser                   0.6.3+             master
LNR                           0.0.2
Lazy                          0.10.1
MacroTools                    0.2.0
Media                         0.1.1
Requires                      0.2.1

Start with a blank document.
From command palette select Julia: Open Julia Home
Similar errors occur when selecting: Julia: Open Startup File

Atom Version: 1.1.0
System: Microsoft Windows 10 Home
Thrown From: julia-client package, v0.1.2
Stack Trace
Uncaught TypeError: Arguments to path.join must be strings
At path.js:190

TypeError: Arguments to path.join must be strings
    at f (path.js:190:13)
    at Object.filter (native)
    at Object.win32.join (path.js:195:38)
    at Object.module.exports.home (file:///C:/Users/szpakz/.atom/packages/julia-client/lib/utils.coffee:14:19)
    at Object.module.exports.juliaHome (file:///C:/Users/szpakz/.atom/packages/julia-client/lib/utils.coffee:16:44)
    at atom-workspace.subs.add.atom.commands.add.julia:open-julia-home (file:///C:/Users/szpakz/.atom/packages/julia-client/lib/utils.coffee:62:51)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\szpakz\AppData\Local\atom\app-1.1.0\resources\app.asar\src\command-registry.js:243:29)
    at C:\Users\szpakz\AppData\Local\atom\app-1.1.0\resources\app.asar\src\command-registry.js:3:61
    at CommandPaletteView.module.exports.CommandPaletteView.confirmed (C:\Users\szpakz\AppData\Local\atom\app-1.1.0\resources\app.asar\node_modules\command-palette\lib\command-palette-view.js:159:32)
    at CommandPaletteView.module.exports.SelectListView.confirmSelection (C:\Users\szpakz\AppData\Local\atom\app-1.1.0\resources\app.asar\node_modules\atom-space-pen-views\lib\select-list-view.js:338:21)

Commands
     -2:39.2.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -2:34.2.0 julia-client:start-julia (atom-text-editor.editor)
     -0:09.5.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -0:04.7.0 julia:open-julia-home (atom-text-editor.editor)

Config
{
  "core": {
    "themes": [
      "one-light-ui",
      "one-dark-syntax"
    ]
  },
  "julia-client": {}
}

Installed Packages
# User
ink, v0.1.1
julia-client, v0.1.2
language-julia, v0.4.1
latex-completions, v0.3.0

# Dev
No dev packages

Can't reproduce on master.
If you don't want to wait for the next tagged version (which should be out soon, I think), then follow the dev-install instructions.

Yup, seems to be fine on master. Let me know if you're still seeing it there.


add some CLI args to the create-solid command

Hi 👋
This PR proposes changes to allow create-solid to accept CLI arguments
As you can see from the command's help message here:

This allows flexibility for the user to make choices either via cli arguments or via the interactive interface.
For example, running the following will create a project without interactively asking the user for the project's name and if they want to use solidStart:
npx create-solid -p my-solid-project -s

This PR introduces just a couple of CLI arguments, more can be added later, but anyways I just wanted to test the water and see if there's interest in this and if the chosen approach (using commander) is accepted.
Please have a look and let me know what you think 🙏

By the way, I work at Cloudflare and a project I am part of is our create Cloudflare cli tool: https://developers.cloudflare.com/pages/get-started/c3/
C3 generates framework projects by running their create-x commands and then adds the Cloudflare integration to them (so that they can be deployed on our platform).
We've been supporting Solid using the old create-solid command up until now. Now that the package has changed we've noticed that we are no longer able to pass arguments to the create-solid command, making it very difficult for us to integrate with it (in a clean and reliable manner).
So that's why I came here trying to see if there is a willingness of adding back support to CLI arguments 🤞 (by the way, one that's really fundamental for us is the project name)

Hi @dario-piotrowicz,
Thanks so much for this PR! :)
I've merged this it into the add-cli-args branch and I've switched the library for parsing command line arguments from commander to cmd-ts, since that's what we use for the main CLI.
Would you mind verifying that this all works properly for you and does what you need it to?
If so, let me know and I can merge this into main :)

@Tommypop2 it works great! thank you so very much! ❤
Please feel free to merge and publish it whenever you can so that we can start using it on our CLI 🙏 ❤

@dario-piotrowicz Just released a new version with these changes :) Feel free to make an issue or PR if you need any more changes!

@Tommypop2 thank you so very much! ❤ 🙏

Feel free to make an issue or PR if you need any more changes!

Sure, will do! thanks so much for being so welcoming ❤


System variant: no scheduler

Enable a way to generate run scripts without scheduler instructions, for interactive runs or composing CI runs.
./bin/benchpark system init --dest=tioga-system tioga rocm=551 compiler=cce ~gtl scheduler=mpi

[x] Base class only has the no scheduler instructions option (mpi).
[ ] The AWS system doesn't need to define a new scheduler; should the scheduler code be removed from it?
[ ] The AWS system needs a dry run (should be addressed in response to #455)
[ ] Derived class still specifies the scheduler on the system, which will be used by default (when the scheduler is not specified during system init).
[ ] Is there a way to clean up the code in the system-specific system.py?  values=("flux", "mpi") with "flux" being the default option seems brittle.
[ ] Is there a way to make the scheduler a binary variant?  i.e., scheduler=True uses flux, scheduler=False uses mpi.

As per issue #485, we will do this differently.


Query did not return a unique result for "existsPage(String title)" after introduction of HSQL-DB tests

With the lastest changes introduced with #2, we encounter a regression and observe this stacktrace when working against a MySQL production backend:
org.hibernate.NonUniqueResultException: query did not return a unique result: 3
	at org.hibernate.query.internal.AbstractProducedQuery.uniqueElement(AbstractProducedQuery.java:1487)
	at org.hibernate.query.internal.AbstractProducedQuery.uniqueResult(AbstractProducedQuery.java:1457)
	at de.tudarmstadt.ukp.wikipedia.api.Wikipedia.existsPage(Wikipedia.java:633)
	at de.hshn.mi.tulum.graph.wikigraph.service.domain.impl.JWPLWikipediaSourceImpl.existsPage(JWPLWikipediaSourceImpl.java:45)

The reason for this that I removed ... COLLATE utf8_bin in #2 (as this is unsupported with HSQL-DB) from the native SQL query in this method.
The fix is simple:
Add this MySQL specific text fragment in case Wikipedia uses a MySQL-driven DatabaseConfiguration.
I will provide a fix for it (and potentially similar cases).

Is this something that should be handled in queries or rather in the database setup itself (i.e. setting the database-wide default collation during database creation)?

@reckart I'm only restoring existing code/functionality with this issue. For the HSQL-DB embedded scenario "collation" is not supported at all. Thus, we can not set a "default" collation any way.

The code handled the collation before, but I wonder if it is worth to introduce DB-specific code for something that could as well be documented and handled when the user manually creates the MySQL DB - the user has to do that anyway and could probably easily set the the default charset and collation for the DB at that point. It could maybe also be done at the time when JWPL is setting up the database schema - but I think it should not be necessary to handle this at query time.

Well, this could be an improvement. However, the current master is broken and lead to unexpected behaviour in projects depending on JWPL snapshots for integration / testing purposes.
I agree, that utf8_bin collation in queries should be removed from the query level and the code-base but we should first fix the master branch to reduce pain for other devs / projects.
I propose the following strategy:

(a) Fix the master branch by introducing a strategy to distinguish between HSQLDB and MYSQL at query level.

(b) Next (other issue), remove utf8_bin collation in queries and provide documentation on how to setup MYSQL with correct collation for using it with JWPL.

@rzo1 fine by me 👍


Source tarball does not build on NixOS

To reproduce:
$ tar -zxf traefik-migration-tool-0.9.0.tar.gz
$ cd traefik-migration-tool-0.9.0/
$ make
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
golangci-lint run
WARN Failed to discover go env: failed to run 'go env': exit status 2
ERRO Running error: context loading failed: failed to load program with go/packages: unsupported version of go: exit status 2: flag provided but not defined: -compiled
usage: list [-e] [-f format] [-json] [build flags] [packages]
[…]

Looks like it's not meant to be built outside of a Git repo, and it doesn't say which version of Go it needs. For reference:
$ go version
go version go1.4-bootstrap-20161024 linux/amd64

hello,
the source package is automatically created by Github for a release, so we cannot disable it.
I recommend to clone the repo instead of using this tarball.

For the record, it builds and runs after using nix-env -iA nixos.go rather than nix-env -iA nixos.go_bootstrap.


An error occurred: NextStaticAssetsS3Bucket - "bucket name" already exists.

seems to be a permissions issue with the latest version.
Did you create a custom permission called "NextStaticAssetsS3Bucket" and attach it to yourself?
Can you share or remove?

@garrettmac What error are you getting?

@danielcondemarin - Looks like this may have something to do with using the following S3 url format when defining assetPrefix in next.config.js:
https://mybucketname.s3.amazonaws.com
Note, the https://s3.amazonaws.com/mybucketname has officially been deprecated by AWS.
See https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/
When using the mybucketname.s3.amazonaws.com style of url in next.config.js, I get the following error:
Serverless Error ---------------------------------------
An error occurred: NextStaticAssetsS3Bucket - mybucketname already exists.
This error occurs when I've already created the bucket for assets, or if the plugin has created the bucket for me.

@danielcondemarin - This issue also occurs with serverless-nextjs-plugin version 1.8.0

Looks like the same thing happens when you set assetsBucketName in serverless.yml and remove the assetPrefix setting from next.config.js.
Sounds like the logic is reversed somewhere.
If the assetsBucketName is set in the serverless.yml, the plugin should not try to create a bucket - correct?

Setting uploadBuildAssets in serverless.yml to false works as intended.
And then I can manually upload my own assets.
Other than this one bug, this plugin is super !

Update: I think this has something to do with having existing .next or .serverless directories present before running serverless deploy.
Even with uploadBuildAssets set to false, I still get the following error when the .next/.serverless directories exist:
Serverless Error ---------------------------------------
An error occurred: NextStaticAssetsS3Bucket - mybucketname already exists.

This issue was driving me up the wall!
Finally figured it out--there's a parameter createAssetBucket which controls whether the stack update attempts to create the bucket.  You need to set this to false if the bucket already exists:
custom:
  serverless-nextjs:
    createAssetBucket:    false

I think this behavior should be documented or it should set createAssetBucket based on a describeBucket result since I dropped this plugin once before due to running into this.


Linting should be automated at every commit

To ensure consistency on code convention, code linter (isort and black) should be run before every commit made on this repository.

Trello card: [#91] Linting should be automated at every commit


Skip kustomization file in upstream-crds make cmd

This is part of the PR over at https://github.com/external-secrets/external-secrets/pull/1274

I was wrong, this isn't needed. The CRD manifests are extracted from the bundle.yaml and we don't pull in the kustomization.yaml here in this repo.
Closing this one. The changes in https://github.com/external-secrets/external-secrets/pull/1274 should be sufficient


Firebase GitHub Authentication

Can I take this ?

Work on LinkedIn authentication

Sure @anushbhatia

Hey @himanshusharma89, if the feature request still exists, I would like to work on it.

Sure, @rish07. We are planning to maintain this repository for Hacktoberfest.

Hey @rish07, are you working on this issue? Should I assign it to you? And if you need a reference do let me know.

Hey, @himanshusharma89, I have actually completed the code. Will create a PR in a while.

@rish07 Perfect! and BTW It is implemented with Firebase, right?

Yes, @himanshusharma89. You will just have to change the CLIENT ID and CLIENT SECRET in the code which you'll get when you create a GitHub oauth app.
I will put these instructions in the PR.

Great! @rish07. But we already have the ID and SECRET, I'll share those with you but before that share your email, I'll add you to the firebase console.

@himanshusharma89 it's<EMAIL_ADDRESS>


Add source to citation

Add the source to the citation when you select because we are cool

Done in #17


Please remove synthetic methods

In AS: Analyze, Run inspection by name, Private member access between outer and inner classes
Make the changes it suggests (basically change various fields to package-local instead of private if they are accessed from inner/anonymous classes).
This will lower the method count of the library by eliminating compiler generated synthetic wrapper methods.
For more info see this:
https://realm.io/news/360andev-jake-wharton-java-hidden-costs-android/

@jt-gilkeson thanks will look in to that. Great info


Memory leaking when using textChangedListener

I use Anko in my project together with LeakCanary, a library for detecting memory leaks. I have a simple scenario where user opens a fragment, fills some text fields in it, saves the result and returns to the previous screen (with popBackStack()).
To bind the content of an EditText to my model, I use textChangedListener. The problem is, oftentimes when I return back and the fragment is supposed to be destoyed, LeakCanary reports that it's leaked by AnkoContextImpl.owner. Looks like what is actually being leaked is a view created by Anko.
I have created a small project to reproduce this behavior. I may be missing something but the app seems to be simple enough. I would really appreciate it if anyone could take a look at it and tell me if I'm doing something wrong.
Project
LeakCanary log
Steps to reproduce (I used API 22):

Click "Open Fragment B",
Enter some text and click toolbar menu item,
Wait for a while for LeakCanary to dump memory and see notification.

Looks like this is a well-known problem and it's unrelated to Anko:
http://stackoverflow.com/questions/34631818/leakcanary-report-leak-in-inputmethodmanager.
https://code.google.com/p/android/issues/detail?id=34731

Indeed, I missed it somehow. Also, it does not reproduce on Android M.
Thanks.


Python 3 porting error in multiqc.py

Around line 486 in _merge_metrics (bcbio/qc/multiqc.py) we have:

        m = tz.get_in(['summary', 'metrics'], s)
        if isinstance(m, six.string_types):
            m = json.loads(m)
        if m:
            for me in m.keys():
                if isinstance(m[me], list) or isinstance(m[me], dict) or isinstance(m[me], tuple):
                    m.pop(me, None)
            sample_metrics[dd.get_sample_name(s)].update(m)

However this doesn't work in Python 3 because keys() is no longer a list (it's an iterator) so pop will try to change the dictionary size in-place during the iteration, causing a runtime error. A quick solution is to cast to list:
for me in list(m):

Luca;
Thanks for the detailed bug report and the fix. The latest development resolves this, and hopefully now works cleanly for you. If you're able to submit PRs for these, we'd be happy to merge them so you get formal credit in the history for finding and fixing the issue. Thanks again.


Option to add remote albums that are already in nextcloud

Is your feature request related to a problem? Please describe.
I have a a bunch of albums on my nextcloud and it would be cool to browse them from my phone.
Describe the solution you'd like
An option to add remote albums that do not live in the lespas directory structure.

You can copy or symlink folders to lespas's home folder. The next time you open lespas app, those folders will be synced to your phone as albums.

Hey, thanks for your fast reply, that does already sound promising, however lespas does not use the directory i select, it creates a lespas directory inside which i cannot edit because it is greyed out.
Why is this the case?
So this means that this feature request transforms to: Let the users choose lespas directory instead of creating a lespas named directory inside

You might be the one who make the same comment on reddit. The fixed name is there for a reason, Nextcloud's Share API treats all the shares a user made as a single image, e.g., you just can't tell which app shared which file/folder from the API output. So Les Pas needs this fixed folder name as a differentiator.

Ok so i guess lespas needs to know which stuff was shared by itself and not by the user in the nextcloud ui?
Where is the difference if i can choose whatever directory i want?
In both cases i am able to just create a new share in the nextcloud ui in the lespas home directory, no matter the directory name.
Or did i get this wrong?
I mean this is such a beautiful app and i will definitely use it, but a normal user with no background info will just assume that he can point lespas to a directory in nextcloud where all his photos are stored. And in my opinion should this be the case usability wise.

If you have some idea of how web server works, you can try out Nextcloud's OCS Share API by yourself. Just curl the Get All Shares API and you should understand what 'Single image of Shares' is and how it will affect apps like Les Pas when dealing with sharing. Sorry, I just can't explain this clearly.
The hard coded lespas is simply NOT a silly logo to show off.

Hey, i never said that the name is a show off. But it is not user friendly.
I played with the Share API and i get a normal xml or json answer with some shares inside, i don't get what you mean by 'Single image of Shares''.
I checked your code and you use the query param path like this (assuming Pictures is the selected root dir): ?path=Pictures/lespas to get all the shares created by lespas.
Lespas assumes all shares in it's directory (Pictures/lespas) is created by lespas, but in fact nothing is blocking me from creating a share in the Nextcloud UI inside the lespas directory to break this assumption. The same is true for the Pictures directory.
So once again i'm asking what would be the difference when we use Pictures instead of Pictures/lespas as directory?
It seems to me that it would behave exactly the same no matter how the directory is named, it just breaks the user experience.

Nextcloud return a single file with all the shares you received, within this xml/json file, no way to tell which app shared which resource, it's a single image of your shares map.
So without the help of hard-coded folder name, to find out which one is shared by Les Pas, app need to look inside each shared folder the user received, one by one with several http calls each to determind it's origin. Not only time consuming but also not friendly in mobile environment.

Ok again:
Even with this hardcoded directory name you cannot tell that a specific share inside this directory is created by lespas because i can just create a new one in this directory without using lespas and lespas would just assume it was created by itself....
So there would be no difference if you let the user select the directory they want.

If you create the folder in lespas/, Les Pas will happily see it as a new album. If the folder is created along side lespas/, no.

Your answer has nothing to do with my question.
I stand my point, the directory name is irrelevent and the user should be able to choose the directory the user wants. It would not make a difference for lespas since it has exactly the same infos as before: its own root directory.
"So it will never know which home folder the other user choosed. All it has it's this hard-coded name in the path."
-> Even with the hard-coded name lespas is not able to tell which directory another user has chosen because the other use can have its lespas directory in different subdirectories.
I don't understand why you don't get this, i would like to try this myself and proof to you that it works, can you please list the features you think will not work?

Please imagine this, if user A choose a 'folderA' as it's home, and shared 'folderA/albumA' to user B, how would user B know this is the folder he is interested in if he has no idea what user A's home folder name?

Ok, so in your example the root directory of userA is folderA/lespas, how does userB know the full path if he only knows the directory name lespas?

All shares a user received are in the "share_with_me" folder. Have you ever tried sharing and/or received shares?

Hey, sadly you did not answer my question.
My share_with_me is defined as /
I have just tried sharing again and i go with your example once again:
UserA shares folderA/lespas/share1 with userB, userB now has a share1 directory in the root of his nextcloud.
Then i query all shares from userB and there is not one field in the json that has something to do with lespas or the path folderA/lespas/share1 (this is the same for joint and solo shares) so first of all i fail to see why userB needs to know the directory name as you use the SHARED_WITH_ME_ENDPOINT endpoint for loading shared items, the PREVIEW_ENDPOINT for loading the preview i assume. And then you can just load the file from the path the SHARED_WITH_ME_ENDPOINT gives back, there is no need to know the directory structure of userA.
And the problem that i want you to see is the same as before: userB can not know the exact location in userA because userA can set the path for the root directory, so why do you keep telling me that the reason for this directory naming is so that userB can know where the files live if there is no way that userB will know.
Can you please address both of this requests?
Thanks a lot

ok, now you are on the right path. you have to think from user B's point of view. what he knows is a whole bunch of files, folders in his 'share_with_me' and the result from calling the list shares endpoint. these are the only two pieces of information he can get from the server. how would he decide which folders are the interested ones? you should look close in the json file for the answer.

So thanks again for your half baked answer.
I just checked everything and it is the same as before this directory name is not needed
I share a directory in lespas with userB, lespas creates the share and puts a json file inside

userB's app uses the ocs/v2.php/apps/files_sharing/api/v1/shares?format=json&shared_with_me=true to get the list of shares.

userB's app uses remote.php/dav/files/userB/shareName to get all the names of the items in the shared directory

userB's app uses remote.php/dav/files/userB/shareName/194554-content.json to query the lespas share info json

The app uses:
 webDav.getStream("${resourceRoot}${share.sharePath}/${share.albumId}.json", true, CacheControl.FORCE_NETWORK).use {                  JSONObject(it.bufferedReader().readText()).getJSONObject("lespas").let { meta ->
to check if the first json object name inside the json is lespas

userB sees the name lespas in the json and knows that this directory is shared by lespas

The directory structure of userA is never used nor known in the whole process, in fact it would be a security problem if userB would be able to see userA's directory structure.

Your step 2 and step 3 are exactly what the current implementation try to avoid, which is scanning all the received shared folders.
All information on shares are from API call result, so I would argue that there are no security issue what so ever.

You might have a point here. I need to revisit my code, since most of the codebase concerning sharing are more than one year old. Give me several days, I'm not with my dev machine, it's too difficult to check the code on my phone.

If userB can see the directory structure of userA then there would be a security issue, no discussion on this please, this sould be self explaining.
And you argue that is exacly what userB's app is doing, you argue that the app of userB somehow knows the full path of the lespas root directory and with this info the app is able to decide this is the directory it is interested in.
If this would be true there would be a problem if i just decide i want some lespas-named directories somewhere in my nextcloud
But thats not true, your app does not work that way, i checked it twice.
Step1 is happening in NCShareViewModel.kt Line 256
Step2 is not needed and not done by the app (sorry my fault) you get the name of the json lespas creates by the enpoint called in Step1 from the json field: item_source
Step 3 is happening in NCShareViewModel.kt Line 336 (in a loop for each result from Step1)
Step 4 is in Lines 336-337
So i have proven two things here:

that that you're answer : Your step 2 and step 3 are exactly what the current implementation try to avoid, which is scanning all the received shared folders is simply wrong, you are scanning all shared folders

Your app does not need the hardcoded directory name lespas for sharing, there is no code where this is cheched or something like that.

I am not able to understand why you don't get this, i do not want to criticize you nor your app, the app is amazing. I just want the app a whole lot user friendly by this.

Very nice, thank you very much
If i have some time and can wrap my head around kotlin android i'll try to create a PR for this issue.

PR is always welcome. But I had a feeling that it will take quite sometime to do a though-out testing for this refactoring, since lespasBase is being used 'everywhere'

Ok, finally get my hand on my machine. Your observation is right, the lespas/ can be eliminated. It will take a little bit longer to do the refactoring though. I'm working on it now.

Had done some tests lately on this issue, it's a surprisingly easy fix so far. But have to figure out a way to make the upgrade works without re-login.

You can copy or symlink folders to lespas's home folder. The next time you open lespas app, those folders will be synced to your phone as albums.

Maybe I'm missing something, but I could not find the way to symlink a folder into another folder in the way Nextcloud would pick it up. Could you please share the way if you know?

@dvalter I'm not sure if you can do that on Nextcloud's webpage, I always do it on command line.

Had done some tests lately on this issue, it's a surprisingly easy fix so far. But have to figure out a way to make the upgrade works without re-login.

I also would be interested in this! Having to re-login doesn't sound too much of a hassle, so if you'd be willing to release something with the code as -is, I'd be happy to test :)

Way had been found to prevent re-login after upgrade. The folder structure also need to incoporate changes from new device gallery backup update, so it's kind of hugh, need more time to smooth it out.

release 2.9.0 eliminated the need of the lespas sub-folder name

Very nice, how to migrate if already setup?

@0verEngineer please refer to announcement on sub Nextcloud/

What announcement and where?

in subreddit https://www.reddit.com/r/NextCloud/comments/14d8ym9/les_pas_290_brand_new_things/

Ahh thanks a lot, however because of the current problems reddit faces it would be good to also have this announcements somewhere else, like in the github release or so.
Thanks a lot for your work :)


Research Rust Driver

What do you need to know?

I will merge rust driver as soon as I'm sure the code quality is acceptable. Furthermore, the driver needs to cover following functionalities
[x] Creating unique indexes / constraints
[ ] Cypher query building (in progress)
[ ] Tests. More tests
[ ] Stabilized and documented API

Also, can anyone close this dangling issue?

The PMC members of the project have the ability

If you want, we can always contact via communicator of your choice and talk about details and your vision over driver

@JoshInnis I can see unit tests are in now: https://github.com/Dzordzu/rust-apache-age/tree/master/tests
What is required for:

Security verification and documentation


Fix a log statement in KafkaClient

The log statement I edited attempted to print the offset it was requested, but it is missing some curly braces. A simple fix.

The change looks fine, not sure why CI failed, kicked off CI again.

CI passed, thanks.


2FA code no longer valid

If i try to login it asks for my 2fa code wich i give it but it says code to old while the same code still works to authenticate a browser session.
version 4.9.6 from pip
on Ubuntu based Linux x86_64
Enter 2FA verification code: 015950 2FA error: This code is no longer valid. Please request a new one.
i cant login even if i disable totp based login and only use sms.

Duplicate of #1217


Cleanup after actions in UI

Hello. I run my acceptance test via selenium and webdriver, it creates a user order(row in db) by UI.
I have cleanup: true in config, then I expect that the dump will cleanup database with created order(according codeception documentation).
Either I do something wrong or the plugin(or codeception) does not cleanup.
My test:
public function testCreateOrder(AcceptanceTester $I, Example $example): void {
 $config =\Codeception\Configuration::config();
 $I->loginIfNotAuthorized(
    $config['users']['admin_full']['login'],
    $config['users']['admin_full']['password'],
    $config['users']['admin_full']['auth_cookie_value'] ?? null
 );
 $I->amOnPage('/services/new/');
 $I->selectOption('select#installment_payment_type', $example['installment_payment_type_friendly']);
 $I->selectOption('select#installment_term_type', $example['installment_term_type_friendly']);
 $I->click('Create order');
}

And config:
...
modules:
    enabled:
        - Codeception\Extension\MultiDb
    config:
        Codeception\Extension\MultiDb:
            connectors:
                connector_1:
                    dsn: "mysql:host=localhost;port=3306;dbname=db;charset=utf8"
                    user: 'sites_db_access'
                    password: '****'
                    dump: 'tests/_data/dump.sql'
                    populate: true
                    cleanup: true
...

Which version of Codeception are you using?
I haven't looked into maintaining MultiDb, in line with later developments in Codeception framework.
Codeception v2.0 and v2.1 are the last I tinkered with.
Also, if you are not using any of the "steps" based usage of MultiDb, you are probably better off using the Db module that comes with Codeception.

Which version of Codeception are you using?

I'm using Codeception 2.3.4.

Also, if you are not using any of the "steps" based usage of MultiDb, you are probably better off using the Db module that comes with Codeception.

I'm using them, and I need MultiDb features:)

Codeception v2.0 and v2.1 are the last I tinkered with.
Apparently, the only solution now is downgrade my codeception to this versions?

Сome up with a solution more like a hack: add method AcceptanceTester::setupCleanupTruncateDb() which cleanups affected tables in test, and call it on end of test or in _after(), but I do not really like this decision.
class AcceptanceTester extends \Codeception\Actor {
...
public function setupCleanupTruncateDb(): void {
   $this->setupCleanup(\Codeception\Extension\MultiDb\Utils\CleanupAction::runSql('
            SET FOREIGN_KEY_CHECKS = 0;
            TRUNCATE TABLE table_1;
            ...
            TRUNCATE TABLE table_n;
            SET FOREIGN_KEY_CHECKS = 1;
   '));
}
}

Sorry @GutsOut !

only solution now is downgrade my codeception to this versions?
It is more of a testing and adapting the code to changes if-any. Unfortunately, I am not in a position right now to spend some time on it.
If you could figure out what is breaking in newer version of Codeception, that would be very valuable.


Zen-browser: Fix Bookmark search

Description
I fixed #15129. Instead of using the bookmarkbackups directory, it using the SQlite DB.
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@Keyruu could you check my question?


Use forwarding references with std::forward()

As advised in C++ Core Guidelines:
F.19: For “forward” parameters, pass by TP&& and only std::forward the parameter

Thank you for this contribution and the explanation.


Is aws amplify stable enough for production?

I have read many github issues and stackoverflow question about amplify and the feature requests/bugs related to it, and most answers included 'we are still working on it' (clear many to many relationships, unique graphql fields etc). Some workarounds given were not usable for production environments (e.g. delete Stack when "Error: Only one resolver is allowed per field")
I am wondering, is AWS Amplify with GraphQL stable enough to use it in production of an app that will reach thousands of users, and heavily relies on a relational database (many-to-many relations)?

Yes, Amplify is stable, however it’s an Open Source Project and we operate in the open with the open-source community, who help us fix issues and also contribute on major features. We highly encourage you to submit bug fixes and PR’s for features when and where you encounter it.


File/Data read and read_text warnings

This task is automatically imported from the old Task Issue Board and it was originally created by James Dunkerley.
Original issue is here.

Any file access issues (e.g. not existing or no permission) is an error.
If the file format is not supported should be an error.
Unlike text.from_bytes encoding errors should be treated as warnings by default.
Likewise malformed CSV should also be treated as warnings (e.g. mismatched column count).
If the document is not parsable (e.g. invalid Excel, invalid JSON or unclosed " in CSV then an error should be raised.

TODO:

[ ] Tests for file access error (use chmod on Linux, for now ignore elsewhere)
[x] Tests for failure if unsupported format
[ ] Add tests for File.read/read_text encoding issues being warnings by default

The tests are there, we just need to verify defaults are Warning.

[ ] There are tests for invalid column count, just add verification that they default to Warning.
[ ] Make unclosed " in CSV a hard error.
[ ] Add a test for reading a corrupted Excel file, expecting a Corrupted File error.
[ ] Add a basic test for reading a .json file.
[ ] Add a test for reading a malormed .json file, expecting a Corrupted File error.

Open Questions:

Maybe the Mismatched_Quote error reported on unmatched " in CSV should be also merged to be the Corrupted_File error? cc: @jdunkerley


Introduce annotations for configuring an extension

Introduce annotations for configuring an extension. Currently, extension configuration must be passed to the super class in the extension constructor. However, this information is mostly static and best suited for annotations in the Java world.
Here's what is currently necessary (shown in Groovy):
class YellBlock extends BlockProcessor {
    YellBlock(String name, Map<String, Object> config) {
        super(name, [contexts: [':paragraph'], content_model: ':simple']);
    }
    ...
}

Here's an example of how this might look (shown in Java):
@Context(":paragraph")
@ContentModel(SIMPLE)
public class YellBlock extends BlockProcessor {
  ...
}

There should be annotations for each of the DSL methods in the Ruby APIs.

I looked through extensions.rb and I think that the Asciidoctor Ruby base classes currently support the config options below.
(I already translated them to dedicated annotations as in the initial approach)

DocInfoProcessor has

@Location(String)
Values are :header and :footer.
Would it make sense to define an enum for that or are other values conceivable?

BlockProcessor & MacroProcessor & BlockMacro have

@Name(String)
@Contexts(String[])
@ContentModel(String)
@PositionalAttributes(???)

I could not find any values in the Asciidoctor sources...

@DefaultAttributes(@DefaultAttribute[])

@DefaultAttribute(String, String) (Does it work out to simply have Strings mapped to Strings here? Or do we need to support list etc as well?)

InlineMacro has the same as MacroProcessor plus

@UsingFormat(String)

Values are :short and anything else (:long?).
Would it make sense to define an enum for that or are other values conceivable?

@Regexp(String)

Do you think it is reasonable to create these annotations?
If so it should not be too hard to evaluate the annotations when someone registers a class at the JavaExtensionRegistry.

@Location(String) Values are :header and :footer. Would it make sense to define an enum for that or are other values conceivable?

Not currently. Though, we have been considering an additional placement at the top of the content (not the head). Technically, a converter can request any placement key it wants when resolving the docinfo. However, for now probably best to start with an enum.

@PositionalAttributes(???) I could not find any values in the Asciidoctor sources...

These are attribute names, so they must be string values.

@DefaultAttribute(String, String) (Does it work out to simply have Strings mapped to Strings here? Or do we need to support list etc as well?)

Simple strings as attributes can only be strings.

@UsingFormat(String)

This should simply be @Format. Though, it really should have three values (even though this isn't implemented in Asciidoctor). It should be :long, :short or :custom (or :regexp). If custom (or :regexp, then a @Regexp annotation is required.

Do you think it is reasonable to create these annotations?

Am 22.05.2015 um 22:05 schrieb Dan Allen<EMAIL_ADDRESS>This should simply be @Format. Though, it really should have three values (even though this isn't implemented in Asciidoctor). It should be :long, :short or :custom (or :regexp). If custom (or :regexp, then a @Regexp annotation is required.

I think when having a @Regexp there is no need for a @Format("custom").
Maybe when registering an extension with @Format and @Regexp we could throw an exception that the extension is not configured correctly.
Or maybe only @Format("long"), @Format("short") or @Format(regexp=".*")?

Or maybe only @Format("long"), @Format("short") or @Format(regexp=".*")?

Now you've got it! The default value then should be "custom" (so you don't have to specify it when you set regexp).

One point I'd like to discuss is the following:
BlockProcessors and MacroProcessors are at the moment required to have a constructor that takes the block name or macro name.
Do we really need that?
I'd prefer to only have a no-arg constructor.
We could probably also check if the processor has a no-arg constructor or the old one and call the correct one.
Having the name in the constructor only makes sense if the processor is registered without the annotation. That would mean that it is a common case to register the same extension class with changing names.

@robertpanzer That's precisely the idea. The argument in the constructor is optional for the case when you want to reuse the processor in another context. In other words, whatever configuration you pass to the constructor overrides the annotations, which serve as the default / fallback configuration.

In other words, whatever configuration you pass to the constructor overrides the annotations, which serve as the default / fallback configuration.

Yes, that's really important!
My question was going more into the direction if it is required that there is a constructor that receives the block or macro name?
It can certainly invoke the super constructor passing any configuration, but it is really required to receive the name?
Maybe we could extend the logic to invoke a "specialized" constructor with the macro/block name if available and fall back to a no arg constructor?
I believe that a no arg constructor will cover 90% of the cases and that it makes it simpler getting started with writing own extensions.

Yes, I agree. That's how I see it too. We really want the extension classes to be a simple as they possibly can be.

Fixed with #341


jjui: init at 0-unstable-2024-12-10

This PR initializes jjui at the latest master (there are no release versions nor tags). jjui (~ Jujutsu UI) is a TUI for Jujutsu, the Git-compatible version control system.
(Edit: Should be fixed now by using postFixup.) I am not knowledgeable about Go toolchain. The issue with this package is that pkgs.buildGoModule builds the program as a binary cmd (since it is sometimes a convention to put the module with a main function of a Go program into a subfolder cmd). Is there a better way (more idiomatic, and with less code -- so no specifying the build and install phase manually) to name the package properly?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

All the issues raised so far have been addressed. I would kindly ask you, @getchoo, to re-review the PR. Thanks.

All issues raised so far have been addressed.


Calling receiveBatch twice leads to a hang

Assuming there are at least 2 messages in the queue, doing the following leads to a hang:
const msg = await client.receiveBatch(1);
const msg = await client.receiveBatch(1);

This is because the batching receiver will create a new batching receiver for every call, without closing the previous one.

This is as per design. It is expected to not close the batching receiver link. 2nd batch receive call should reuse the link created from the first one if the link is already open. This is done because link creation is expensive operation. Hence we try to minimize link creation wherever possible.
If you received the messages in peeklock mode then you are expected to settle the first message before you can get the second message.
Try setting the receiveMode property to receiveAndDelete and then run the test again OR when you receive the list of first set of messages, please dispose them and then call await receiveBatch again

2nd batch receive call should reuse the link created from the first one if the link is already open.

Agreed. But this isnt what is happening. What is happening is that we are creating a new batchingReceiver for every receiveBatch call.

If you received the messages in peeklock mode then you are expected to settle the first set of messages before you can get the second set of messages

Try setting the receiveMode property to receiveAndDelete and then run the test again

Even if we settle the messages using complete() before calling the next batch or if we change to receiveAndDelete, it doesnt change the hanging issue which is due to the fact that earlier batchingRecievers never get closed. Only the last one gets closed.
Checkout #32

Fixed with #32


how do you train the PULID model?

It seems PerceiverAttentionCA makes it reasonable to do attn-op between face features and flux latents, i'm curious how do you train that, would you mind share your experiences, thank you a lot!

The model was not trained by me! When you look at the Credits section of the REAME.md, you will see this link:
https://github.com/ToTheBeginning/PuLID
Go  and ask the authors.


Please Add to blacklist

(PORN)
pinayflix.com
pinayrare.net
kantotin.com
xtorjack.com
rbreezy.org
xxxjojo.com
xbree.net
kainpopoy.com
Thank you

Thanks @opensource008.  Ping @sinfonietta.

Added @StevenBlack.
Hey sorry for the delay, been busy.

Thanks @Sinfonietta I appreciate what you do, no issue for the delay.
Thanks for these, @opensource008.
Closing.


Insufficient color contrast

The color contrast is not sufficient on some elements (global issue).
Useful tools

axe DevTools to identify contrast issues.
Webaim color contrast checker. The contrast should at least satisfy the WCAG AA requirement.

Some examples:

##More information:

The visual presentation of text and images of text should have a contrast ratio of at least 4.5:1

If needed, I can supply hex codes for the closest color matches that are compliant (email: aaron.mccollough@ubiquitypress.com).
###On search results pages:

Number of results found = 3.76:1 against gray background
Number of results in facet lists = 3.76:1 against gray background
Deposit date label (White lettering on blue field) = 4.06:1
Resource type label (white lettering on gray field) = 4.03:1
Metadata-only label (while lettering on teal field) = 2.56:1

###On upload form:

invenio-accordion-field dividers (white lettering on blue background) = 4.06:1
Storage available labels (gray text on gray field) = 3.76:1
default field text prompts (gray on white background) = 1.68:1

###On community setup form:

invenio-accordion-field dividers (white lettering on blue background) = 4.06:1
default field text prompts (gray on white background) = 1.68:1

###On published record page:

Technical metadata (gray text on gray background) = 4.44:1
Resource type label (white lettering on gray field) = 4.03:1
Metadata-only label (while lettering on teal field) = 2.56:1


refactor: unify http client creation

Proposed changes
Unifies the httpclient used across the application.
No validation of server certificate
Types of changes
What types of changes does your code introduce to the repo? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have signed the commit for DCO to be passed.
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

maybe i miss something.... why not just daemon.downloadAndValidateImage() call to utils.doTLSRequest() ?
the method post vs get can be an argument
happy to discuss ....

@glimchb I kept them seperate because there were some extra http headers (basic auth etc) being passed in the post request, no sure if that was needed in the get version.
I had to change inject the http client to enable testing for the caching feature.

I had to change inject the http client to enable testing for the caching feature.

so this should be separate PR or separate commit just for injection

LGTM
if @h0lyalg0rithm is away for now, I'd be happy to cherry-pick the changes and open a new PR.


Use labels instead of zone

Add Labels maps to CassandraDatacenterSpec and replace zone in Rack by Labels too. Now Labels can be set at the DC level and at the rack level and they get merged.
Fixes #292

@jimdickinson I made the different changes that were asked. I'm not sure about the changes to make at the documentation or  examples level. Any guidance ?

@jimdickinson I made the different changes that were asked. I'm not sure about the changes to make at the documentation or examples level. Any guidance ?

First of all - this PR is looking really good - thank you!
If you'd like to take a stab at docs, looks like we have some vague ones here -> https://github.com/datastax/cass-operator/blob/master/docs/user/README.md#racks
The examples are more clear, but terse -> https://github.com/datastax/cass-operator/blob/master/operator/example-cassdc-yaml/cassandra-3.11.x/example-cassdc-full.yaml#L27

Thanks for this! Any ETA when this will land in a release?

Thanks for this! Any ETA when this will land in a release?


Multiple tables in single 'create migration' command

Feature request: can we have the capability to specify multiple tables simultaneously for the migration creator of the orator binary?

I might be useful however I don't how it would work with the --create option.


Can't add new database

Hi, i'm using last version of superset on docker
when i'm at step three of adding a mysql database (didn't try any other but i expect the same result) i click on "finish" and it does nothing
Except i get this error message :

Expect result: the modal close and a new database appear on the list
Happened result: nothing close and no database appear on the list

Get this when i click on empty label texts, dont know if it's related or not

@elestranobaron could you please specify whether your database is inside seperate docker or not? if you're using docker installation for you db then in hostname you need to give the docker IP( which you can get by using ifconfig) and if you have standard installation then you need to specify local IP... since superset docker might be searching in its own localhost.

ip given is in 172.0 so yes and has you can see the connection is successful
even i checked with wrong password or wrong db name and it reacts accordingly

It's like the connection has been done but no database has been saved

So Obviously it seems like the db is successfully created under the id 13 (which is my number of attempts right now)
But i can't access this very endpoint /13 cause apparently it dont exist wasnt created in fact ?

Ok my bad it was tricky, version was 4 month old the last one is good not shite as the other


Extraction of 'Python' from LLM code blocks

This PR contains:

[ ] a new test-case for the benchmark

[ ] I hereby confirm that NO LLM-based technology (such as github copilot) was used while writing this benchmark

[ ] new dependencies in requirements.txt

[ ] The environment.yml file was updated using the command conda env export > environment.yml

[ ] new generator-functions allowing to sample from other LLMs
[ ] new samples (sample_....jsonl files)
[ ] new benchmarking results (..._results.jsonl files)
[ ] documentation update
[x] bug fixes

Related github issue (if relevant): closes #80
Short description:

Fixing 'extract_python' function to also remove 'Python' in addition to 'python' if it was generated in the response of LLM code-blocks.
Moved 'extract_python' function to the data.py module
Removed duplicates of 'extract_python' and converted it to an import.
This CAN change the .jsonl files

How do you think will this influence the benchmark results?

More realistic results for llama3 models

Why do you think it makes sense to merge this PR?

Many of the llama3 tests are improperly labelled as incorrect when they have 'Python' in the preamble.

This PR is good to go! I didn't update the jsonl files here yet, but I tested the changes and the only jsonl files that are modified are the ones with improper completions. Here's the short summary of the PR:

Moved extract_python() function to the data.py module, removed duplicate functions
Fixed extract_python to include capital 'Python' from code strings
Cleaned up + vectorized retrieve_code_from_responses notebook
Tested dataframe differences, a total of 407 responses were modified between 4 models (about 4%).


lrgasp-tools ambiguous output

I installed lrgasp-tools and ran:
lrgasp-validate-models models.gtf.gz on one of my files. The command terminated without printing anything.
It's not very clear what the expected output is. Does absence of output mean valid file?
Same happens with
lrgasp-validate-read-model-map --models_gtf models.gtf.gz read_model_map.tsv.gz

Yes, confirmed with @diekhans that validation scripts exit quietly when no errors are detected


ORVIBO Allone WiWo-R1 support

It would be nice to have a support to the ORVIBO Allone WiWo-R1.

Closing this issue as feature requests should be posted in the forum.


Fix GroundPrimitive in 2D

Do not extrude volumes further in 2D or columbus view. Fixes #5075.
This is also a partial fix for #5026. If you zoom in to the polygons in the GeoJSON attached to that issue, the frame rate goes up. There is still a problem with low frame rates for the global view which I'm still looking into.

Thanks @bagnell!  I'll update CHANGES.md in master

@bagnell please update CHANGES.md in master.

@pjcozzi already taken care of


Not ignoring the static storybook folder.

Front End Review:

Made this a PR because it's important: the static sites will need the local directory storybook/storybook-static that gets generated by Storybook. Unfortunately, this cannot be git-ignored. It just needs to be known that this subfolder cannot/should not be committed to the repo and that the static script is only used by Travis.

The main landing page works https://nypl.github.io/nypl-design-system/ but the links don't because the folder is currently ignored by git.

Hmm is the reason why reuseable-components doesn't need this is because it doesn't have that extra landing page?

reusable-components does the same pattern, as in, the storybook-static directory is not in that repo's gitignore file. Besides the landing page (which I don't think is a big difference), the main difference is that in reusable-components I'm telling Travis to deploy a specific directory only. That directory has only the static site files.
Here, however, I cannot do that same subdirectory because of the dependencies from the other subdirectories. The main issue was storybook not being able to find ../../node_modules/src/react-components which made sense since those files didn't exist. So now it reverted back to pushing everything up to the gh-pages but unfortunately, having to be careful about not committing any static storybook files that a user could generate locally. Ideally, a developer wouldn't need to run the static storybook script anyway.

Is there a built-in mechanism to make and re-make storybook-static, then? I'm thinking about the situations where new components are added or old components are removed - for example there's a known issue where lib can get stale, but because it doesn't get committed it feels ok to remove and re-generate at any time.

The lib folder should be regenerated in each Travis container when it runs tests and when it runs the static command. So, there shouldn't be a problem with the lib folder getting stale. Every time a new PR is merged into development, Travis will run the storybook static command and push the new changes.


Parameter changes not propagated back to DAW UI

Hi Mike,
when implement my own plugin I noted an issue concerning parameter settings that can also be reproduced with the WPF sample:
Ableton has a built-in view of the registered parameters of any plugin.

When turning a knob in the Ableton view, the respective control also changes its value in the WPF plugin (right screenshot)
When turning the dial in the WPF sample, the corresponding Ableton button does not receive the update and stays where it was (left screenshot).

The actual processing takes place with the correct value anyway, so this is maybe just a matter of PropertyChange somewhere.
I checked a few commercial plugins which seem to get it right.

Let me know if you need any further assistance there and thanks in advance,
Dennis

I haven't yet implemented the VST3 API calls to report parameter changes to the DAW. I just had a quick look at it, and it seems like it may take some thought to get it right.

This is now fixed.


do you provide pre trained models for EfficientVit on your end？

I want to load a pre trained model and then train it, but I don't have it. Can you provide it？

Hi @Idol-Dou2021 ,
Thanks for your interest in our work. The pretrained models are provided here https://github.com/microsoft/Cream/blob/main/EfficientViT/classification/README.md#model-zoo
Best,
Xinyu

Close the issue. Feel free to reopen it if any problem.


nrf52 serial: use DMA

Serial implementation does not use DMA and this means it is quite interrupt intensive. This is problematic for time sensitive scenarios.

I created this just in case someone feels like doing so, otherwise it will sit in the very back of my backlog.


Null

Modloader
Forge
Minecraft version
1.19.2
Hex Casting version
0.10.3
Modloader version
Forge;43.4.0
Modpack info
0.10.3
The latest.log file
No response
Issue description
I want to select an item and it says NULL
latest.log
Steps to reproduce
https://github.com/user-attachments/assets/822b7788-1b08-4336-8d24-cb56ae90d6a7
Other information
No response

Hm, you are aiming at the item. Are you drawing Compass Purification clockwise or counterclockwise? You should be drawing it counter-clockwise.


Fix code scanning alert - Database query built from user-controlled sources

Maybe use mongo-sanitize to sanitize user input before sending it to mongo as query
Tracking issue for:

[ ] https://github.com/dxworks/illustry/security/code-scanning/1

rdy


Could the sui-sdk be migrated here?

Could the sui-sdk be migrated here?
In this way, it will be convenient for other libraries to conduct secondary encapsulation.

No, this is a full rewrite of the sui-sdk. JSON RPC will not be supported at some point and we'll have to move to GraphQL, thus this new complete SDK with GraphQL client support.

cool, are there any functions that need to be developed at an accelerated pace currently?
Is this SDK ready for use now? I've just finished developing the Rust SDK for Deepbook recently.
However, it was developed based on the original sui-sdk, and I found it too bulky.
I want to replace it with this one. I'm not sure whether it can be used or not.  @stefan-mysten

Is this SDK ready for use now?

Its still under development, but there is enough functionality to build/sign transactions but functionality for interacting with an RPC is limited at the moment and an area we're working on improving. I'm hoping for a lot of things to improve here over the next few weeks. In the meantime feel free to take a look and file issues for things you find missing/lacking and we'll work on filling the gaps!

However, it was developed based on the original sui-sdk, and I found it too bulky.

Yep this is exactly the reason why this project was started, to provide a lighter-weight base for people building on Sui.

That's awesome, thanks for the context @lispking.

Is this SDK ready for use now? I've just finished developing the Rust SDK for Deepbook recently.
Depends a lot on what you need.

If you need the core sui-sdk-types, that crate is almost ready to be used and it should be 100% compatible with sui-types from sui monorepo.
If you need JSON RPC, that is not really available here, so you can't use that.
If you need to use GraphQL, the GraphQL client crate is a very early version that works, but probably does not expose all the needed APIs. However, GraphQL service is not yet fully released, so expect changes to the schema and possible performance issues.

Is your Rust SDK for Deepbook open source? I can have a very quick look to see what you're using there and then I can understand if you could migrate to some of the code from this repo.

That's awesome, thanks for the context @lispking.太棒了，感谢上下文@lispking。

Is this SDK ready for use now? I've just finished developing the Rust SDK for Deepbook recently.这个SDK现在可以使用了吗？我最近刚刚完成 Deepbook 的 Rust SDK 的开发。
Depends a lot on what you need.很大程度上取决于你的需要。

If you need the core sui-sdk-types, that crate is almost ready to be used and it should be 100% compatible with sui-types from sui monorepo.如果您需要核心 sui-sdk-types ，该板条箱几乎已准备好使用，并且它应该与 sui monorepo 中的 sui-types 100% 兼容。
If you need JSON RPC, that is not really available here, so you can't use that.如果您需要 JSON RPC，那么这里实际上不可用，因此您不能使用它。
If you need to use GraphQL, the GraphQL client crate is a very early version that works, but probably does not expose all the needed APIs. However, GraphQL service is not yet fully released, so expect changes to the schema and possible performance issues.如果您需要使用 GraphQL，GraphQL 客户端 crate 是一个非常早期的版本，可以运行，但可能不会公开所有需要的 API。然而，GraphQL 服务尚未完全发布，因此预计架构会发生变化，并可能出现性能问题。

Is your Rust SDK for Deepbook open source? I can have a very quick look to see what you're using there and then I can understand if you could migrate to some of the code from this repo.你们的 Deepbook Rust SDK 是开源的吗？我可以非常快速地查看您在那里使用的内容，然后我可以了解您是否可以迁移到此存储库中的某些代码。

https://github.com/lispking/sui-deepbookv3

Yes, PTBs are used a lot in the Deepbook SDK you built, so I would say, you should wait for a bit before migrating as a transaction builder is not fully built up yet in this sui-rust-sdk repository.

When is it expected to be ready?

We don't have a date yet, sorry.


Ensure EPT Hooks Work on the Same Page

Ensure that EPT hooks function correctly when targeting the same page. When splitting 2MB pages into 4KB pages using the same pre-allocated Page Table (PT), it can cause an issue. Or when multiple hooks require a shadow page, it's essential that they share a single shadow page rather than each having its distinct shadow page. This requirement is crucial for the hooks to operate correctly and could potentially cause issues with the current setup if not handled properly.
We need a better way to manage and keep track of hooks, utilizing guest_page_pa to consistently track associated shadow pages and PTs. Investigate and refine our approach to guarantee the stability and effectiveness of EPT hooks, particularly after integrating a communication method to perform hooks/unhooks from user-mode, as noted in issue #20.

Kernel inline and syscall hooks appear to be working fine from user-mode and at boot-time. However, leaving this open, until I'm 100% certain there are no bugs and the hooks are robust and until more testing is done.


Better tests for Prepared Put in StorIOSQLiteDb

Closes #193
I tried to keep things as readable as possible
@nikitin-da please review

Much better!

Thanks!
чт, 2 апр. 2015, 1:23, Dmitrii Nikitin<EMAIL_ADDRESS>
Much better!
—
Reply to this email directly or view it on GitHub
https://github.com/pushtorefresh/storio/pull/196#issuecomment-88652374.


Generate code to access dataframe

Each node in the Trrack graph should have a pointer to a dataframe. The dataframes can be saved in Python dict with trrack node ids as keys and names formatted like df_{first 6 digits of trrack id}.
Clicking on the copy button should generate the dataframe in memory if it doesn't exist and copy a code snippet to retrieve the dataframe. E.g.  IDE.get_df(<dataframe name>)
The dataframe should be usable in downstream code as usual. On kernel restart the dataframe wouldn't exist in memory, so the code using the variable should fail. So the cell with trrack interaction needs to be re-run. This is expected even in basic python code.

There are two ways to generate the dataframe. Create dynamic dataframe generates a dynamic dataframe. This variable is kept in sync with the current node in the provenance graph. On restarting the kernel running the cell generates the variable.
Another way to create a dataframe is to use copy button on the provenance graph. This dataframe is associated with that specific node.
You must go to the node at least once after the kernel reset.

[ ] add a way to trrack dataframes and recreate them while running the cell.


Fix PartitionIdGenerator's multiplier initialization for VectorHasher

When having N columns, PartitionIdGenerator relies on N VectorHashers
to generate ValueIds, with each VectorHasher’s multiplier correctly set up.
However when having multiple bool columns, it triggers a corner case that
VectorHasher’s multipliers won’t be set at all.
Add multiplierInitialized flag and properly set it to fix this corner case.

Thanks!
Please, address Meng's comments before merging.
Also, does the new test fail with the old code?

Yes, it does, horribly


Editing Element vs Mixed Content

There is a bunch of things in JATS which are expressed using mixed content.
This creates a bit of confusion for Texture, because it is not clear how to edit this.
A form is in our opinion still the best UI for editing properties, but at the same time it is difficult for us to derive the textual form then, without relying on a rendering service.
I was wondering, if we could come up with a solution for that -- an idea which we discussed some years ago already: The idea is to primarily present a form, plus a rendered textual representation of the whole record. The user has some means to change the textual representation in a limited way, like a template string.

Example:
    <conf-loc><city>Denver</city>, <state>Colorado</state>, <country>United States</country></conf-loc>

    <conf-loc>
      <city>Denver</city>
      <state>Colorado</state>
      <country>United States</country>
    </conf-loc>

Having this UI we would have multiple options:

use mixed content as single source
apply a general pattern separating structured from textual content
introduce a dedicated element for textual content

No matter what we do, we must be able to keep presentation in sync with the structured representation, which the user would edit in first place.

@michael thoughts?
With the JATS -> TextureJATS transformation, we are facing the situation, that almost all of these cases are primarily mixed in JATS -- <element-citation> the only exception. Instead of introducing a lot of new elements into TextureJATS we could then stay closer to the original schema.

We agreed to keep one structured version and derive a mixed/or string version from it, which is a weak copy and gives users the ability to 'just render' it. Additionally we discussed keeping an 'original' record (e.g. when a reference has been imported from word).

We will only edit element-citations now and derive a display version from it. Closing.


using cuda9 branch of cusp with cuda-7.5

I was attempting to see if I can use the same cusp snapshot from cuda-7.5 to 9.1 [ tried only these 2 versions but nothing in between]
So when I use cusp/cuda9 branch with cuda-7.5 -  I get the following error:
                 from /sandbox/balay/petsc/src/mat/impls/aij/mpi/mpicusp/mpiaijAssemble.cu:11:
/sandbox/balay/petsc/arch-cuda-double/include/cusp/system/cuda/arch.h:27:44: fatal error: thrust/system/cuda/detail/arch.h: No such file or directory
 #include <thrust/system/cuda/detail/arch.h>
                                            ^

THRUST_VERSION for cuda-7.5 is:
$ grep '#define THRUST_VERSION' /soft/apps/packages/cuda-7.5/include/thrust/version.h
#define THRUST_VERSION 100802

So The following change gets this compile going.
$ diff -Nru cusp/system/cuda/arch.h~ cusp/system/cuda/arch.h
--- cusp/system/cuda/arch.h~	2018-03-07 17:05:59.346856000 -0600
+++ cusp/system/cuda/arch.h	2018-03-07 17:09:28.887263722 -0600
@@ -21,7 +21,7 @@
 #include <thrust/extrema.h>

 #if THRUST_VERSION >= 100900
-#elif THRUST_VERSION >= 100803
+#elif THRUST_VERSION >= 100802
 #include <thrust/system/cuda/detail/detail/launch_calculator.h>
 #elif THRUST_VERSION >= 100600
 #include <thrust/system/cuda/detail/arch.h>

Is this a suitable fix for cusp/cuda9 branch?

BTW: Also checked cuda-8.0 - cusp/cuda9 works with it.

Thanks Satish, I integrated your suggestion with support for cuda9. This should resolve your compilation issue.


[Hack Update] 056-CosmicTroubleshooting - support for Dev Containers

Adding support for Visual Studio Code Dev Containers and GitHub Codespaces for CosmicTroubleshooting

Hi Łukasz!  Thanks for your proposed update. The WTH v-Team is reviewing this and may consider adding this as an idea for multiple hacks to support students who may not have the ability to install tooling on their local workstations.
While the WTH repo is open source and public, we generally do NOT share it with hack attendees before or during a hack.  Instead, hack attendees should always use the WTH website, which features only the student guides: https://aka.ms/wth
We do NOT want students cloning the entire WTH repo (which has the Coach guides :)).   Instead, we provide students with a "Resources.zip" that contains all of the resources/code they will need to complete the challenges.  Currently, it is the coach/host's responsibility to create the "Resources.zip" file from the contents of the /Student/Resources folder of the hack.  We are looking into options to automatically create these ZIP files and publish them to an online location for downloading to make it easier for Coaches & Students.
With that said, we did some testing of both VS Dev Containers and GH codespaces this week.  The VS Dev Container works well, but requires students to install both Docker Desktop & WSL on their Windows workstations.  Installing Docker + WSL is often the biggest barrier for most organizations where they don't have administrator access on their workstations.  If they can install those two things, then there's likely not much more value a VS Dev Container would add IMO?
GH Codespaces makes things easier by being 100% in the browser.  However, it would require students to:
1.) Create/have a GitHub account.
2.) Unpack the Resources.zip file locally or in Azure Cloud Shell
3.) Commit the contents to a new Git repo and push it to GitHub.com.
4.) Use GH Codespaces from the newly hosted repo in the student's own account.
This seems like the better option to me.  However, I would question how much value does it add over having a student use the Azure Cloud Shell environment to complete the hack if they are not able to install the tooling locally?


Exclude gym==0.20.0

What does this PR do?
Fixes #747.
For reviewers: The related ci is only CI full testing. It hasn't got to green yet, but the AttributeErrors raised by RL models are now fixed in this PR.
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes?
[n/a] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

The failing test below is irrelevant to this PR. Should be addressed in another PR.
tests/models/test_mnist_templates.py::test_mnist - KeyError: 'train_loss'

https://github.com/PyTorchLightning/lightning-bolts/pull/748/checks?check_run_id=3778938469

Although this PR is written by me, let me label this pr "ready to go" as the change is obvious...


Additional name for all commands

Add openssl-foo as a name for the openssl "foo" command.
Recommended by a usability study conducted by Martin Ukrop at CRoCS, FI MU
Fixes: #4548

Merged, thanks!


Fix corrupted git checkout recovery.

This fixes an issue where cargo would not recover from a corrupted git checkout correctly when using net.git-fetch-with-cli.
Git dependencies have two clones, the "db" and the "checkout". The "db" is shared amongst multiple checkout revisions from the same repository. The "checkout" is each individual revision. There was some code in copy_to which creates the "checkout" that tries to recover from an error. The "checkout" can be invalid if cargo was interrupted while cloning it, or if there is fs corruption. However, that code was failing when using the git CLI.  For reasons I did not dig into, the "db" does not have a HEAD ref, so that special-case fetch was failing with a couldn't find remote ref HEAD error from git.
This changes it so that if the "checkout" is invalid, it just gets blown away and a new clone is created (instead of calling git fetch from the "db").
I believe there is some long history for this copy_to code where it made more sense in the past. Previously, the "checkout" directories used the GitReference string as-is. So, for example, a branch would checkout into a directory with that branch name. At some point, it was changed so that each checkout uses a short hash of the actual revision.  Rebuilding the checkout made sense when it was possible for that checkout revision to change (like if new commits were pushed to a branch).  That recovery is no longer necessary since a checkout is only ever one revision.
Fixes #10826

@ehuss: no appropriate reviewer found, use r? to override

Looks good to me.

@bors r+

:pushpin: Commit c46e57b0cf7489f8d6a41a42f4eebcc08201e195 has been approved by weihanglo

:hourglass: Testing commit c46e57b0cf7489f8d6a41a42f4eebcc08201e195 with merge 9c4bae65b743df07d10a58836a5ee09103050d02...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 9c4bae65b743df07d10a58836a5ee09103050d02 to master...


Add LICENSE.txt

This repository needs a license file. We'll be using the Apache 2 license.

Already done with initial commit from John.


Fix: Refactor CSS-Grid files location

What this PR does
Move assets to specific folders so things are a bit cleaner and the online server doesn't have any issue with the assets.
Open questions:

[x] We still need to say where we got the .wav files. @gregwhitworth? https://github.com/MicrosoftEdge/Demos/pull/374#pullrequestreview-81703899

Requirements
I've read and followed:

[X] All applicable accessibility requirements (See .github/ACCESSIBILITY_REQS.md).
[X] CSS code style guidelines (See .github/CSS_STYLE_REQS.md).

For the record, the sounds come internally from Microsoft and we have the right to distribute them as we please.
Jonathan Warman is the person who made this possible.


[Task]: Migrate native connectors to Java 17

Description
$Subject
Describe your task(s)
No response
Related area
-> Runtime
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Migration PRs have been added to each repositories and waiting on update 8 to be available in central to get all the workflows passed.

All of the Java 17 migration PRs of connectors have been merged. Hence closing this.