Resolves issues with ServicePort validation

Summary
Fixes #4238
Some small issues arose during testing of serviceports

Node Port and Listening Port now report errors when outside of port ranges
Node Port and Target Port no longer allow extra characters (note that decimal points with no numbers and/or 0s following them are simply trimmed by the input instead of caught by validation

Occurred changes and/or fixed issues
Reworked Serviceport validation. Potentially worth breaking up into several smaller validators in the future

Hm. For me the target input looks like it still allows letters.
I created a target port with letters in it and the backend didn't stop me either:

A couple of minor nits -

The node port name should have a red asterisk
I think the red error message shouldn't appear until the form has been touched

I think the error message should be on its own row so it doesn't look like it only goes with the first column

@catherineluse TargetPort is a bit of a special case because it could be a port or a dnsLabelIanaServiceName. It should complain if you use illegal characters for that like periods or the like.
These servicePort validators are on my list of "refactor for UX" things. Right now, all the rules are tied up into a single validator because that's how the model expects the validator to work but it prevents me from tying the validation message to a single field like I do elsewhere. I need to extend the mixin to optionally ignore certain rules from the model so I can break the servicePort validator up into several smaller ones that'll work much like all the others.


Updating docs and readme

This pull request contains changes to the documentation and github readme. Main motivation was to:

add calcium workflow
add imc data workflow
add animal tracking workflow / using DINOv2 as feature extractor
update figures
make references to VGG16 more general/mention other feature extractors in in-depth description part and readme.

Book builds locally, and videos seem to be playing. Happy for feedback, also pinging @StojiljkovicVetAna ! Let me know if you want me to restructure the book, for now I just added all new workflows to the examples section.
TODOs:

[ ] update API access?
[ ] update PDF references to paper with link once preprint is online
[ ] discuss cellpose backbone as feature extractor

Lovely examples!
I'm 😍 at the inverted LUT and minimum blended for the IMC!


Change webpack output from AMD to UMD to support global.sweet

In the Gitter room we got a question about using sweet in the browser. The editor already uses a webpack bundle 😄. But it's AMD ☹.
I changed the output type to umd to support all of the things. Now it should work with require.js, as a global and in node.

We should consider having a sweet-cli and a sweet-compiler package.


C#: Add documentation for Interfaces and Attributes

Adds documentation for the remaining publicly visible types/members in the GodotSharp "Attributes" & "Interfaces" folders

Could you rebase so we can run the CI again (which failed probably for unrelated reasons)?

We prefer Area: Message rather than [Area] Message, actually 🙂 But it's not worth it to change the commit message over this nitpick.


My Bookmarks is not working

Describe the feature
clicking on " my bookmarks"  leads to ano page found
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

sir please assign this to me @SiddharthBahuguna

@samarsajad You can start working on it.

@samarsajad You can start working on it.

Please review my pull request #84

Ok, I'll do it.
On Fri, May 31, 2024, 2:01 PM Samar Sajad @.***> wrote:

@samarsajad https://github.com/samarsajad You can start working on it.
Please review my pull request #84
https://github.com/SiddharthBahuguna/NEWS-AGGREGATOR-PROJECT/pull/84
—
Reply to this email directly, view it on GitHub
https://github.com/SiddharthBahuguna/NEWS-AGGREGATOR-PROJECT/issues/81#issuecomment-2141492704,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A24XZ7OBOOVBRFUWOFX44K3ZFAYPBAVCNFSM6AAAAABIRNV2CCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGQ4TENZQGQ
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


[#3151] aggregate agent's transaction data to show application's tran…

…saction data

Codecov Report

Merging #3162 into master will increase coverage by 0.12%.
The diff coverage is 89.14%.

@@            Coverage Diff             @@
##           master    #3162      +/-   ##
==========================================
+ Coverage   38.77%   38.89%   +0.12%
==========================================
  Files        2014     2017       +3
  Lines       66486    66646     +160
  Branches     9264     9273       +9
==========================================
+ Hits        25780    25924     +144
- Misses      38124    38142      +18
+ Partials     2582     2580       -2

Impacted Files
Coverage Δ

...ercorp/pinpoint/flink/process/TbaseFlatMapper.java
63.63% <ø> (ø)
:arrow_up:

...oint/common/server/bo/stat/join/JoinCpuLoadBo.java
88.7% <ø> (+2.09%)
:arrow_up:

...ollector/mapper/thrift/stat/TFAgentStatMapper.java
60% <0%> (-15%)
:arrow_down:

...npoint/flink/function/ApplicationStatBoWindow.java
0% <0%> (ø)
:arrow_up:

...lector/mapper/thrift/stat/TFTransactionMapper.java
0% <0%> (ø)

...nt/common/server/bo/stat/join/JoinAgentStatBo.java
61.53% <100%> (+4.39%)
:arrow_up:

...nk/mapper/thrift/stat/JoinTransactionBoMapper.java
100% <100%> (ø)

...mon/server/bo/stat/join/JoinApplicationStatBo.java
88.63% <100%> (+3.12%)
:arrow_up:

.../common/server/bo/stat/join/JoinTransactionBo.java
100% <100%> (ø)

...point/common/server/bo/stat/join/JoinMemoryBo.java
87.9% <100%> (ø)
:arrow_up:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28bf1f...b063f1d. Read the comment docs.

Leave a comment


 has no attribute 'fit_sync'

This probably is not an issue but a question: Does the error has no attribute 'fit_sync' when running on a model or something like RandomizedSearchCV mean, that this class is not yet supported by modeldb or am I just doing something wrong? If those methods are not supported yet, is there any way to store the model and its results in modeldb nevertheless?
To give an example, this works:
import modeldb.sklearn_native.ModelDbSyncer as mdb
linreg = mdb.linear_model.LinearRegression()
linreg.fit_sync(x_train, y_train)
test_pred = linreg.predict_sync(x_test)
syncer_obj.sync()

and this does not:
model = mdb.linear_model.ElasticNet()
model.fit_sync(x_train, y_train)

I experienced this yet with the ElasticNet and LassoCV models as well as the RandomizedSearchCV.

Yes, this is because those models are not yet supported.
However, it is pretty easy to add support. In the simple case where you are building a single model (e.g. ElasticNet), see https://github.com/mitdbg/modeldb/blob/master/client/python/modeldb/sklearn_native/ModelDbSyncer.py#L422. You can add the appropriate class there.
For a CV operator, you'll need something like https://github.com/mitdbg/modeldb/blob/master/client/python/modeldb/sklearn_native/ModelDbSyncer.py#L214
Both should not be too much effort and we'd welcome a PR with one or both of these patches. Happy to review code etc, just open a PR when you're ready!

I just did add the additional models: https://github.com/mitdbg/modeldb/pull/294
Also tried some more generic approache like additing the fit_sync etc. method for all models which have a fit method, but since this gave me some errors for a few of those, I did not commit that one.

Is there any chance the pull request gets merged?


Merge ngx_http_dyups_module new version to tengine

Directive dyups_upstream_conf has been deprecated
Added add/del upstream filter to make other modules operate upstream easily after upstream changed
Move upstream state update to upstream_check/rb_tree_upstream module to filter

现在的功能是否与以前一致？

 You should sign our Contributor License Agreement in order to get your pull request merged.


python newline cursor position off by a space

hi
currently when i type the following:
a = abc(hi,<return for new line>)
i get:
a = abc(hi,
       ho=cursor_on_new_line_starts_at_the_same_position_as_parenthesis)

however, when i type the newline without the closing parenthesis:
a = abc(hi,<return for new line>
i get the correct behavior:
a = abc(hi,
        ho=cursor_at_the_same_position_as_first_variable)

could we please fix the former to also behave correctly?
thanks a lot!

It is easy to fix:
// mode/python/python.js @379:
indent: function(state, textAfter) {
        if (state.tokenize != tokenBase)
          return state.tokenize.isString ? CodeMirror.Pass : 0;

        var scope = top(state), closing = scope.type == textAfter.charAt(0)
        if (scope.align != null)
         // original code is :
         // return scope.align - (closing ? 1 : 0)

         // to fix behaviour just assume that the user wants to continue typing
         // items when lastToken is a comma:
          return scope.align - (closing && state.lastToken !== ',' ? 1 : 0)
        else
          return scope.offset - (closing ? hangingIndent : 0)
      },

@valq7711 Would you be willing to submit a pull request for this?


Introduce installer using bash

Installer is configurable
Installer can be triggered by piping the curl output to bash
Installer supports both Linux and macOS, amd64 and arm64 architectures and HomeBrew or raw binary installation methods

Fix #25

@CollierCZ could you please take a look as well for the docs? If you're fine with it, we can also include it in our CLI installation page.

@pjcdawkins fixed your comments, feel free to take another look!

@pjcdawkins refactored the code a bit and added discovery for the gh CLI and initially trying to take the token from there. I think this should be more than enough for now.

@pjcdawkins replied/fixed all the comments, feel free to take another look.

@pjcdawkins as I understand there's nothing left here, I'm merging since we're already a bit behind the release schedule.


Docs tweaks: how to install with macOS Silicon / ARM

Hello, thanks for this excellent project!
Would you be open to a PR to tweak the docs to describe how to build with macOS Silicon? There isn't yet a pre-installed Protoc binary released through GitHub releases (https://github.com/protocolbuffers/protobuf/issues/8062), so I had to brew install protobuf. Looks like I didn't actually have to set PROTOC or PROTOC_INCLUDE; protoc being on the $PATH was sufficient iiuc.
I'd be happy to update some docs. Maybe these places?

The below error message. We can maybe detect if on macOS ARM and if so, append a suggestion to install Protoc, e.g. via brew install protobuf?

Failed to find the protoc binary. The PROTOC environment variable is not set, there is no bundled protoc for this platform, and protoc is not in the PATH

Maybe somewhere in the README, like https://github.com/danburkert/prost#using-prost-in-a-cargo-project
https://docs.rs/prost-build/0.7.0/prost_build/index.html#sourcing-protoc

Also, the docs from https://docs.rs/prost-build/0.7.0/prost_build/index.html#sourcing-protoc give an example for how to set Protoc via homebrew, but it looks like Homebrew has (recently?) changed its default install dirs. I'm happy to update this.
PROTOC=/opt/homebrew/bin/protoc
PROTOC_INCLUDE=/opt/homebrew/include

Let me know what would be helpful!

Are you running prost 0.6 or 0.7?   My understanding is that as of #394 prost-build should ‘just work’, and that PR is included in 0.7.  Happy to take a pr to update the brew example if it’s no longer accurate.

Are you running prost 0.6 or 0.7?   My understanding is that as of #394 prost-build should ‘just work’, and that PR is included in 0.7.  Happy to take a pr to update the brew example if it’s no longer accurate.

Actually it appears the  /opt location is specific to arm macs: https://docs.brew.sh/Installation

Actually it appears the  /opt location is specific to arm macs: https://docs.brew.sh/Installation

Are you running prost 0.6 or 0.7?

Ah! Indeed, we're using Prost 0.6.1 over at https://github.com/pantsbuild/pants. Sorry I hadn't caught #394 earlier, great to see that included.

Actually it appears the /opt location is specific to arm macs

Interesting, good catch. Thanks! The number of macOS Silicon users is so much lower that it makes sense to stick with the /usr/local path. Lmk if you'd like a tiny PR to clarify in those docs it's for Homebrew on macOS x86.

Are you running prost 0.6 or 0.7?

Ah! Indeed, we're using Prost 0.6.1 over at https://github.com/pantsbuild/pants. Sorry I hadn't caught #394 earlier, great to see that included.

Actually it appears the /opt location is specific to arm macs

Interesting, good catch. Thanks! The number of macOS Silicon users is so much lower that it makes sense to stick with the /usr/local path. Lmk if you'd like a tiny PR to clarify in those docs it's for Homebrew on macOS x86.

Ah, another possibility for the Homebrew example:
PROTOC=$(brew --prefix)/bin/protoc
PROTOC_INCLUDE=$(brew --prefix)/include

Ah, another possibility for the Homebrew example:
PROTOC=$(brew --prefix)/bin/protoc
PROTOC_INCLUDE=$(brew --prefix)/include

Ah, another possibility for the Homebrew example:

Ah, another possibility for the Homebrew example:


AWS Aurora

Hello there! Sorry if it isn't the correct place to ask such question, but I'd try. Amazon provides us their own implementation of RDBMS Aurora, that compatible with mysql. Question is: How can I use knex with it, if I can use it at all!?
Thanks,
Romain

Oh and HAPPY NEW YEAR :santa:

@vanesyan You should just be able to use the MySQL driver. According to the Aurora documentation it is fully compatible with MySQL APIs.

I'm using it with the mysql driver. Works like a charm. This issues can be closed. If you like you can add a PR for the docs letting others know to use the mysql driver.

how on earth is this issue still open....

I think some spring cleaning is in order guys XD

Thanks! @jpike88 would be great help if you can go more issues through and spot some other obviously closable ones 👍


Cannot use GH issue notebook extension in web selfhost

Steps to Reproduce:

selfhost on web locally
install GH issue notebook extension (installs fine)
click on a GH issue notebook from our repo

=> 🐛  Activating extension 'ms-vscode.vscode-github-issue-notebooks' failed: Unexpected token '.'
Visually I see:

Maybe related to auth?

Works just fine with 0.0.62

ping @sandy081 maybe the transition from web-enabled to not-web-enabled isn't working smoothly

Yeah I was suspecting an issue like that and I think previously I had this extension explicitly installed in the remote and now it probably installs in the web worker? not sure how I can control that from the extensions viewlet...

@jrieken Can you please check if you are still publishing this extension as web extension?

Not doing that

Has actually nothing to do with web. The extension tries to activate in the correct extension but it seems the nodejs version doesn't support the outputed JavaScript. This is the full error
SyntaxError: Unexpected token '.'
	at wrapSafe (internal/modules/cjs/loader.js:1053:16)
	at Module._compile (internal/modules/cjs/loader.js:1101:27)
	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
	at Module.load (internal/modules/cjs/loader.js:985:32)
	at Function.Module._load (internal/modules/cjs/loader.js:878:14)
	at Function.Module._load (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/node/extensionHostProcessSetup.js:37:33)
	at Function.load (/Users/jrieken/Code/vscode/out/vs/workbench/api/node/extHostExtensionService.js:23:37)
	at Function.load [as _load] (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/node/proxyResolver.js:331:37)
	at Module.require (internal/modules/cjs/loader.js:1025:19)
	at require (internal/modules/cjs/helpers.js:72:18)
	at Function.nodeRequire [as __$__nodeRequire] (/Users/jrieken/Code/vscode/out/vs/loader.js:1000:24)
	at ExtHostExtensionService._loadCommonJSModule (/Users/jrieken/Code/vscode/out/vs/workbench/api/node/extHostExtensionService.js:79:29)
	at ExtHostExtensionService._doActivateExtension (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionService.js:214:22)
	at ExtHostExtensionService._activateExtension (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionService.js:188:25)
	at Object.actualActivateExtension (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionService.js:56:33)
	at ExtensionsActivator._activateExtension (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionActivator.js:251:57)
	at /Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionActivator.js:236:58
	at Array.map (<anonymous>)
	at ExtensionsActivator._activateExtensions (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionActivator.js:236:42)
	at ExtensionsActivator.activateByEvent (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionActivator.js:127:25)
	at ExtHostExtensionService._activateByEvent (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionService.js:104:36)
	at /Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostExtensionService.js:521:33


to buffer and back again

I was looking for a way of applying a chroma key to the image (matching certain colour pixels and turning them transparent.) In fact I just want to turn black pixels transparent so fairly straight forward.
I can't see a way to do this currently - I could output to a raw buffer and do the operation, but then I couldn't turn that raw buffer back into a image (unless I have missed something).
Do you have any plans to add this support? Is it even possible and if so would you welcome a contribution?

I'm also stuck at the same place, though from the docs it looks like it's possible to get back to an image from a raw buffer. Unfortunately I can't figure out how it works. I'm sending output from sharp through jsfeat, but sharp doesn't define the format for the input and output (I think there are conventions for this, but I can't seem to get sharp to accept the data).
See the docs for the cunstructor. One thing it doesn't say, but I figured out from error messages and peaking into the source code, is how to specify the raw parameter on the options object. Here's the docs:

raw an Object containing width, height and channels when providing uncompressed data. See raw() for pixel ordering.

I assumed that the channels field was for supplying the channels (i.e. image data for each channel), but actually it's the number of channels (in the range 1 to 4).
Higher up, the docs for the constructor say:

input, if present, can be one of:

Buffer containing JPEG, PNG, WebP, GIF, SVG, TIFF or raw pixel image data, or
String containing the path to an JPEG, PNG, WebP, GIF, SVG or TIFF image file.

I think this means you can send in the raw image data as the input parameter. However, it's not accepting the format I get back from jsfeat (which is an array-like object with width*height elements, each from 0 to 255 (I think) (it's single-channel)).
I'm getting the raw image data from sharp with img.raw().toBuffer().then(...).
It appears to be array-like, with a length of width*height*channels, which makes sense (one byte for each color for each pixel) and is how the HTML5 canvas API works (as I understand it at least).
So my questions are:

What exactly do raw() and toBuffer() do? I see raw().toBuffer() in the docs, and I'm using it, but I don't fully understand the relationship between these two.
What format is "raw"? Is it an array-like object with width*height*channels elements, with each one in the range 0 to 255? Sharp is rejecting what I'm quite sure is just that (Unsupported input object   at Sharp._createInputDescriptor (/home/l/git/nodeoverlay/node_modules/sharp/index.js:186:11).
Given I have data described in the above point, how do I construct a sharp object?

I read the docs a bit more carefully. I think this is the intended use but I have not had time to test:
var width, height, channels;
image.metadata(function (metadata) {
   width = metadata.width;
   height = metadata.height;
   channels = metadata.channels;
}).raw().toBuffer().then(function (buffer) {
   // alter buffer

   // reconstruct
   sharp(buffer, { width: width, height: height, channels: channels})
});

I've made a little progress from digging into the code a bit. Here's how the constructor works:
// Where raw is the pixel data, as a flattened array (see my previous
// comment describing this data structure)
raw.width = someWidth;
raw.height = someHeight;
raw.channels = numChannels;
sharp(null, {
  raw: raw;
});

It accepts this. However, afterwards doing .toFile('somefile.jpg', function(cb)), it never calls the callback. Promises never get fulfilled either.
Here's what is returned, as reported by JSON.stringify(): {"isFulfilled":false,"isRejected":false}.
And here's what console.log() prints:
Promise {
  _bitField: 0,
  _fulfillmentHandler0: undefined,
  _rejectionHandler0: undefined,
  _promise0: undefined,
  _receiver0: undefined }

I'm not very good with promises, but I thought Bluebird (the promise implementation used by sharp) was supposed to make sure nothing silently failed. So I'm stuck again and uncertain whether this relates to the previous issue I was facing. I did get sharp working with opening images, modifying them, and saving, but in this case I can't get it to work.
@smremde Can you get an image constructed the way I have? Does it successfully save?

Just tested and this actually works fine for me:
sharp('/mnt/tank/temp/x.jpg').metadata(function(err, metadata) {
    width = metadata.width;
    height = metadata.height;
    channels = metadata.channels;
}).raw().toBuffer().then(function(buffer) {
    for (var i = 0; i < y.length; i += 3)
        buffer[i] = 255;
    sharp(buffer, {
        raw: {
            width: width,
            height: height,
            channels: channels
        }
    }).toFile('/mnt/tank/temp/y.jpg', function(cb) {
        console.log('cb')
    });
});

Changing y to buffer your code works for me too. So now I guess I need to find the root of the problem. I still don't know what format sharp wants, so maybe I have it wrong still. I'd be nice if it through an error though.

sharp(new Buffer([255, 0, 0]), {
raw: {
width: 1,
height: 1,
channels: 3
}
}).toFile('/mnt/tank/temp/test.jpg', function(err) {
console.log(err);
});
Works fine for me - it creates a 1x1 pixel red image.

Yes, the color order is specified in the docs where it talks about the raw() function, and it's RGBA (A for alpha, when applicable). And it does specify what the raw() format is, better than I remembered, but I'm still confused about it's relation to buffer().
I was wrong about how the constructor worked; apparently I was simply passing in no data at all, hence the behavior of the toFile() function.
I just tried converting my array-like object (which I get back from jsfeat) to a Buffer, but that fails. I need to look more at the data structure of jsfeat; I thought it was identical to the raw output that sharp produces.
Anyway, I hope I didn't lead you down the wrong path. :frowning: And thanks for helping figure out how the API works.

Anyway, I hope I didn't lead you down the wrong path. :frowning: And thanks for helping figure out how the API works. :smile:

Far from it - you helped me solve me problem!

Just for anyone who stumbles across this and has the same problem integrating with jsfeat, here's what worked for me:
// img is a jsfeat matrix_t
sharp(new Buffer(img.buffer.u8), {
  raw: {
    width: width,
    height: height,
    channels: 1
  }
})

Keep in mind that u8 means an unsigned 8-bit array. If you're working with more than one channel, this may differ.
I figured out the data structure by logging the data I was trying to pass to sharp, redirecting the process's output to a file, and then opening the file with nano (other text editors may become unresponsive trying to open 42MB of text). Then it was pretty easy to see the data structure. This same approach should help regardless of where you're getting the data you send to sharp.

Hello, in my absence it looks like you've both solved your respective problems. I should go on holiday more often :)

Just tested and this actually works fine for me:
sharp('/mnt/tank/temp/x.jpg').metadata(function(err, metadata) {
    width = metadata.width;
    height = metadata.height;
    channels = metadata.channels;
}).raw().toBuffer().then(function(buffer) {
    for (var i = 0; i < buffer.length; i += 3)
        buffer[i] = 255;
    sharp(buffer, {
        raw: {
            width: width,
            height: height,
            channels: channels
        }
    }).toFile('/mnt/tank/temp/y.jpg', function(cb) {
        console.log('cb')
    });
});

Why does this work?  I'm not sure I understand what the manipulation to the buffer is for.

I would like to follow on this task as I can't seem to get current solution work for me.  I have an sample.raw file, so I read them from filesystem and try to pass the buffer to sharp, let it convert to .jpg file.
fs.readFile("sample.raw", "utf8", function(err, buffer) {
sharp(buffer, {
raw: {
width: 7920,
height: 6004,
channels: 1
}
}).toFile('sample.png', function(cb) {
console.log(cb)
});
});
My cb is returning missing input file. Can anyone point to me how to properly read an .raw from file and convert it to other file format ?

@marzious Raw support refers to uncompressed pixel data without metadata and not "raw" camera images. Please open a new issue with a sample image if you're still having problems.


Use native memory properly

C.converter() func had an off-by-1, and SIGSEV'ed unluckily located messages.
C.GoString() shouldn't be used on non-zero-terminated strings anyway, so I've replaced it with a simple cast for use with C.GoStringN().

Good Catch!
:+1:


Cloud Firestore node.js invalid use of type “object” as a Firestore argument

[REQUIRED] Step 2: Describe your environment

Operating System version: MacOS
Firebase SDK version: 8.3.0
Library version: _____
Firebase Product: Firestore database
Node Version: 10.15.1

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
This issue (by someone else) describes both the problem and the resolution: https://stackoverflow.com/questions/55065567/cloud-firestore-node-js-invalid-use-of-type-object-as-a-firestore-argument
For prosperity, I am facing the same problem using Node-Red to send a JSON object like this:
    payload: {
        text: "hello world",
        createdAt: new Date(),
        user: { _id: 1000 } // This causes the issue
    }

Which is then called in the function:
this.firestore.collection(col).add(payload)

And throws the error:
Invalid use of type "object" as a Firestore argument

The workaround, as the SO thread explains is to edit
<EMAIL_ADDRESS>and change isPlainObject to
function isPlainObject(input) {
    return util_1.isObject(input);
}

Is there a more permanent solution that I can use? This is fine on my development environment, but I will need to deploy this to an environment where I cannot edit node_modules
Many thanks

@kiwicopple Thanks for sending this over.
Can you run the following on your local machine:
const obj = {
	payload: {
        text: "hello world",
        createdAt: new Date(),
        user: { _id: 1000 } // This causes the issue
    }
};

console.log('Node version: ' + process.version);
console.log('Prototype matches: ' + (Object.getPrototypeOf(obj) === Object.prototype));

For me this prints:
Node version: v10.15.3
Prototype matches: true

Thanks for the swift response @schmidt-sebastian
After sleeping on this I think it may be better/easier to solve this within the library using firebase-admin (found here: https://github.com/sichangi/node-red-contrib-cloud-firestore/blob/master/src/Write/WriteNode.js).
For more context and anyone who reads this, here was my solution
The issue is with the library above is that they do an Object.assign({}, load) with the payload, but this doesn't "go deep". So this is the result:
// See line 44 of the above where msg.payload = { "foo": "bar", "user": { "_id", 1000 } }
const payload = this.preparePayload(msg.payload)

// Top level has a "prototype"
console.log('Prototype matches: ' + (Object.getPrototypeOf(obj) === Object.prototype));
// -> Prototype matches: true

// Nested objects don't
console.log('Prototype matches: ' + (Object.getPrototypeOf(obj.user) === Object.prototype));
// -> Prototype matches: false

console.log('Node version: ' + process.version);
//  -> Node version: v8.16.0 - note this was different to my environment a NodeRed was running in a docker container

And I think the only way to solve it is to call JSON.parse(JSON.stringify(msg.payload))
Thanks for the help @schmidt-sebastian  - I'll close this for now


Initialiaze from FIREBASE_CONFIG environment variable

Can you give an example of the data that should be in the FIREBASE_CONFIG environment variable when calling initializeApp
I see that there should be an object in the 'credential' property
But it also checks for a method called 'getAccessToken'
firebase-app.js:203
if (typeof credential !== 'object' || credential === null || typeof credential.getAccessToken !== 'function') {
            throw new error_1.FirebaseAppError(error_1.AppErrorCodes.INVALID_APP_OPTIONS, "Invalid Firebase app options passed as the first argument to initializeApp() for the " +
                ("app named \"" + this.name_ + "\". The \"credential\" property must be an object which implements ") +
                "the Credential interface.");
        }

How can I create this method through the environment variable string?

You cannot set credential via FIREBASE_CONFIG. It is for setting other Firebase options (databaseURL, projectId etc). SDK will resort to using Application Default Credentials when initialized in this manner.
You can find some detailed info at https://medium.com/google-cloud/firebase-separating-configuration-from-code-in-admin-sdk-d2bcd2e87de6

[_****_]([url](

[ ]

[ ]

url

))


Email and Planner apps disabled in urls.py

You have the email and planner apps commented out in the main crm/urls.py.  Is this intentional as you are still developing this CRM?  Are you planning to add documentation on how to enable these features at http://django-crm.readthedocs.io ? These features/documentation would be very helpful!
# url(r'^emails/', include('emails.urls', namespace='emails')),
# url(r'^planner/', include('planner.urls', namespace='planner')),

Hello, What is the reason for emails and planners are commented? Are these modules ready to use?

I uncommented these modules and found the following:

the email module requires an email server, and fails when trying to send an email. When I have some more time I will try setting up FakeSMTP and seeing how far that goes.

The planner module does not seem to work as load_meetings function in the view references a "created_user" and "updated user" field while the model has a "created_by" and "updated_by" field

I can try to get these modules working, but I'm kind of shooting in the dark as to what the functionality is supposed to do. Is there any sort of test plan or set of requirements for these features?

I changed the backend to the Django Dummy backend. This seemed to fix the only issue I found with the email module. There was also a link to an inbox, but I saw no code to implement this feature. I removed the Inbox link from each of the pages. If anyone has some requirements around how the Inbox should would I would be happy to try to implement.
I submitted a pull request with my updates.

@smacktrace we planned to develop and release those at a later stage. We will start those and other enhancements as you are interested.

#16 merged.


Dynamic Content

Is there a good way of binding it to work on dynamic content.
Thanks

Is this possible to the current build. If not can you try it, i really need it!

Argh. I never go to this.  I'll see if I can work on this soon.
In the meantime this is very dirty but you can always re-initialize the plugin if possible after you add your dynamic content, however, just make sure to unbind the hover/click event before you do.
Insert your dynamic content, then execute the following again like:
$(".livepreview").unbind( "hover" );
$(".livepreview").unbind( "click" );
$(".livepreview").livePreview();

That is great, even being dirty... Thank you very match for the quick answer...
Greetings from Greece!


How to put the coordinator in Factory mode

For testing purpose , I need to get already initialized coordinator back to factory.
What could be a way to do a factory reset ?

What  i knowing is the SOC setting up the NVM in the flash (= NCP / TC key storage) then its booting the first time after being flashed. I have not finding any way deleting the NVM from the NCP firmware with commands and have only finding delete all key in the key storage.
If having SWD probe you can doing one flash erase and flashing new bootloader and APP and the firmware is making one new clean NVM.
PM upgrading NCP from some old version (6.5.x) is getting problem and need being reforming the network for working OK and i think its have to do with changed version of the format of the key storage Silabs have being made (was problems with tuya ZBGW fpr some user).


Add gitflow or improve the docs on methodology to help development

I created a pull request for something minor, probably something that does not deserve a release or something, however i sent it against the master branch on this repository.
The branch name does not give a clue about what is the development one, so it can be kinda confusing when someone wants to help. Clarifying this could be a good idea.

It is a common convention that the master branch is the main development branch. This is essentially what CI is about. gitflow does not make any sense with travis in my opinion...


Reaction recipe to make THC Oil

About the PR
Apparently there was no way to get the THC Oil since the seed would create Cannabis Leaves with THC in it.
So instead of deciding to just change all recipe to use THC, here's a recipe that makes THC Oil using 2 THC and 1 Oil and heating it up.
Is it how it's made in reality and does it make sense? Nope but it's THC + Oil = THC Oil so the math checks out.
Could make it cost more THC so the Oil price isn't too steep.
Changelog

:cl:

add: THC Oil can be now made by heating one part oil and two parts THC.

Can't you just get it from grinding cannabis leaves?

https://github.com/Nyanotrasen/Nyanotrasen/blob/fc9d656a5c8c2aae745503cf8cc03943e1dce3bc/Resources/Prototypes/Entities/Objects/Specific/Hydroponics/leaves.yml#L3-L19
Yes.

Can't you just get it from grinding cannabis leaves?

Cannabis seeds produces cannabis laves that contains THC and not THCOil like the spawnable version.

is there any reason for THC and THC oil to not be compressed into 1 reagent?

is there any reason for THC and THC oil to not be compressed into 1 reagent?

No clue. For some reason THCOil is from upstream and only used in that specific spawned in Cannabis Leave.
I can replace every mention of THCOil with THC and be done with it if it'd be simpler.

I think compressing them both into THC would be a preferable solution

Sounds reasonable to me. Some decisions will need to be made over what the final flavor, color, etc. should be, since they both seem to have different ones, and one of them affects plant growth and the other does not. Probably best to merge those together in the final product.

Actually I realized that the only recipe that makes use of THC Oil is my own drink recipes so all of this is actually not worth creating future merging issues if upstream touches upon THC and THCOil.

can you actually go and delete the THCOil reagent altogether? It can still spawn with e.g. oracle juice or vent clog event.

can you actually go and delete the THCOil reagent altogether? It can still spawn with e.g. oracle juice or vent clog event.

Sure thing


🚀 Feature: Add Sync with Meilisearch for Bun

Appwrite Functions allow you to extend and customize your Appwrite server functionality by executing your custom code. 🤩 You can learn more at our official Appwrite Functions docs.
Your task is to implement the Sync with Meilisearch function in Bun. You can look at the existing Appwrite Functions Templates in another coding language.
Your function should behave and be implemented similarly to existing Sync with Meilisearch Node.js template.
Tasks summary:

[ ] Fork & clone Appwrite's templates repository
[ ] Create a branch feat-implement-sync-with-meilisearch-bun
[ ] Write code for the function in folder bun/sync-with-meilisearch/.
[ ] Test the function using Appwrite, provide a video.
[ ] Write a README.md explaining what the function does, how to use it, and customize it. Here is an example.
[ ] Submit a pull request to our templates repository

If you need any help, contact us on our Discord server.
Are you ready to work on this issue? 🤔 Let us know, and we will assign it to you 😊
Happy Appwriting!

@gewenyu99  Hey, I would like to work on this issue

Hi @FreSauce, I've assigned the issue to you! Happy Hacktoberfest 🎃!
Notes:

Please update us with your progress every 3 days, so that we know you are working on it.
Join us on Discord - https://appwrite.io/discord to chat about Hacktoberfest and Appwrite!

@loks0n can you please review the #223 PR?


Fix aes-gcm building failures

Bump the version to 0.10.1 to fix some building failures.
Fix: #85
Signed-off-by: Jia He<EMAIL_ADDRESS>

/cc @jialez0


Weird error...

Hi there, I'm trying out your tftp server because I'm seeing weird issues with dnsmasq-tftp and the logging is really poor. Unfortunately, I'm also seeing a weird error with your server as well.
At first, I thought it might be the hard coded SetWriteDeadline/SetReadDeadline, so I increased those to 30 seconds. But this shows up in the logs immediately. The log below is built from a recent clone of master.
I think what stands out for me, is the 'client sent unexpected opcode' message. I'm not sure what it should be there, but maybe 0 is the wrong value.
This could entirely be my clients messing up.  They are downloading the first ipxe.efi file and then failing to get the next file, but the thing is, not all of my machines are doing this when I run it with dnsmaq. I think your server makes the issue worse though.
Any help is appreciated.
{"level":"info","ts":1651542087.789743,"caller":"logging/logging.go:39","msg":"Received request","args":[],"cmd":"serve","Addr":"<IP_ADDRESS>:2075"}
{"level":"info","ts":1651542087.7898347,"caller":"logging/logging.go:39","msg":"Parsed request","args":[],"cmd":"serve","Request":"Opcode: 1\nBlocksize: 1468\nTransferSize: 0, Mode: 1\nPath: ipxe.efi\n"}
{"level":"info","ts":1651542087.7898853,"caller":"logging/logging.go:39","msg":"Sending file...","args":[],"cmd":"serve","clientAddr":"<IP_ADDRESS>:2075","File":"ipxe.efi"}
{"level":"debug","ts":1651542087.7899106,"caller":"logging/logging.go:35","msg":"Establish fileTransferConnection","args":[],"cmd":"serve"}
{"level":"info","ts":1651542087.7900414,"caller":"logging/logging.go:39","msg":"Open fileTransferConnection","args":[],"cmd":"serve","ListenAddr":"<IP_ADDRESS>:43368","ClientAddr":"<IP_ADDRESS>:2075"}
{"level":"info","ts":1651542087.7900715,"caller":"logging/logging.go:39","msg":"Trying to send file to client","args":[],"cmd":"serve","File":"ipxe.efi"}
{"level":"debug","ts":1651542087.790096,"caller":"logging/logging.go:35","msg":"Found matching handler","args":[],"cmd":"serve","handler":"*handler.fsHandler"}
{"level":"debug","ts":1651542087.7901874,"caller":"logging/logging.go:35","msg":"Successfully opened file","args":[],"cmd":"serve"}
{"level":"debug","ts":1651542087.7902129,"caller":"logging/logging.go:35","msg":"Sending OACK","args":[],"cmd":"serve","blocksize":1468,"transfersize":994592}
{"level":"debug","ts":1651542087.7903159,"caller":"logging/logging.go:35","msg":"Package sent","args":[],"cmd":"serve","Bytes":28,"read deadline":30}
{"level":"warn","ts":1651542087.79041,"caller":"logging/logging.go:43","msg":"Read timeout","args":[],"cmd":"serve","Try":0,"error":"read udp <IP_ADDRESS>:43368-><IP_ADDRESS>:2075: recvfrom: connection refused","stacktrace":"github.com/gdatasoftwareag/tftp/v2/pkg/logging.logger.Warn\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/logging/logging.go:43\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*rrqResponse).sendBufferWithRetransmissionOnTimeout\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/rrq_response.go:303\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*rrqResponse).sendOACK\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/rrq_response.go:210\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*rrqResponse).SendFile\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/rrq_response.go:78\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*server).sendFile\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/server.go:199\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*server).rrqWorker\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/server.go:173"}
{"level":"warn","ts":1651542087.7905571,"caller":"logging/logging.go:43","msg":"client sent unexpected opcode","args":[],"cmd":"serve","Opcode":0,"stacktrace":"github.com/gdatasoftwareag/tftp/v2/pkg/logging.logger.Warn\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/logging/logging.go:43\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*rrqResponse).sendOACK\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/rrq_response.go:225\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*rrqResponse).SendFile\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/rrq_response.go:78\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*server).sendFile\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/server.go:199\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*server).rrqWorker\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/server.go:173"}
{"level":"error","ts":1651542087.7906504,"caller":"logging/logging.go:47","msg":"Failed to send file","args":[],"cmd":"serve","clientAddr":"<IP_ADDRESS>:2075","file":"ipxe.efi","error":"client sent unexpected opcode","stacktrace":"github.com/gdatasoftwareag/tftp/v2/pkg/logging.logger.Error\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/logging/logging.go:47\ngithub.com/gdatasoftwareag/tftp/v2/pkg/tftp.(*server).rrqWorker\n\tgithub.com/gdatasoftwareag/tftp/v2/pkg/tftp/server.go:177"}

Hi thanks for your feedback. We will have a look into the issue.

Thanks! fyi, I just switched to atftpd and that one seems to be working a bit better (or at least doesn't give me errors) and things seem to be recovering a bit. I have a lot (many thousands) of PXE booted machines so all of this is a bit eventually consistent...

I've created a PR to make the Read/WriteTimeout configurable in the config and added some debug logs with the sent/received packages but I was not able to reproduce your error with our TFTP Clients.
The opcode '0', one of your clients is sending is not part of the protocol. As you can see in the RFC section 5. TFTP Packets the first valid opcode is '1'.
If you could provide some debug logs we can have another look at it but if you are already using another TFTP server I will close this issue then.

That being said, we've merged https://github.com/GDATASoftwareAG/tftp/pull/24 and if it turns out that this is in fact just a bug and not a non-spec case, we'd be happy to have a look at it.


Allow env variable placeholders in config file

Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@htahir1 This works, but made me wonder: Do we want this just for the config file, or for any value configured on a pipeline? For example, should these placeholders also be allowed for stack component settings defined on the step decorator? Or really just the config file?

@avishniakov Yes correct, this works for all configs inside the yaml file, the pipeline and step decorators or values passed to .configure(...) or .with_options(...)


feedback on visual

Is this a useful visualisation?

It occurs as cute when teaching, but it doesn't really help understanding the embedding, does it?

I now have need of this. Make!

added.


Example for "Direct use of join table" not working by it self

The example for the direct use of the join table is missing the context configuration resulting in the following error:
Unable to create a 'DbContext' of type ''. The exception 'The entity type 'PostTag' requires a primary key to be defined. If you intended to use a keyless entity type, call 'HasNoKey' in 'OnModelCreating'. For more information on keyless entity types, see https://go.microsoft.com/fwlink/?linkid=2141943.' was thrown while attempting to create an instance. For the different patterns supported at design time, see https://go.microsoft.com/fwlink/?linkid=851728

This error is misleading as HasNoKey is not a solution here.
This would be the missing config:
builder.Entity<Post>()
    .HasMany<Tag>()
    .WithMany()
    .UsingEntity<PostTag>(
        r => r.HasOne(e => e.Tag).WithMany(e => e.PostTags).HasForeignKey(e => e.TagId),
        l => l.HasOne(e => e.Post).WithMany(e => e.PostTags).HasForeignKey(e => e.PostId)
        );

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9234f104-802f-8ee0-8a54-ff3b8f49857e
Version Independent ID: 9234f104-802f-8ee0-8a54-ff3b8f49857e
Content: Many-to-many relationships - EF Core
Content Source: entity-framework/core/modeling/relationships/many-to-many.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

@LunicLynx Are you running the code from the sample, or have you attempted to recreate the code in your own application? If the latter, then please attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Feature nonblocking

@andreasley @tannernelson I think the issue was something to do w/ float tolerances, can the two of you confirm that this is ready to merge 👍

Looks good to me!

@andreasley sounds good, I'll update that branch and give travis a moment to run w/ my changes.


feat(chore): remove support for node v14,v12

Description

Both node v12 and node v14 have reached their end of life

BREAKING CHANGE:-
End of life of node v14 and node v12

GH-1382
Fixes #1382
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[x] Performed a self-review of my own code
[x] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

@RaghavaroraSF  rebase


Inconsistent row counts reported by csvstat

Running csvstat with different options reports inconsistent row counts:
$ csvstat -c 1 gl_languages3.csv
  1. id
	<type 'unicode'>
	Nulls: False
	Unique values: 7939
	Max length: 8

Row count: 7939

vs.
$ csvstat --count gl_languages3.csv
Row count: 7941

Can you provide a minimal working example?
I suggest breaking gl_languages3.csv into halves to locate the source of the issue.
Without gl_languages3.csv (or another example) it's difficult to reproduce and diagnose this error.

Ok, I followed your advice splitting the file into ever smaller chunks. It turns out that in two rows a single " (double quote) appears. So apparently, the two rows in between these quotes are hidden, which may be correct behaviour:
$ csvstat -H --count problem.csv
Row count: 8
$ csvstat -H -c 1 problem.csv
  1. column1
	<type 'unicode'>
	Nulls: False
	Unique values: 8
	Max length: 8

Row count: 8

But the mystery remains, why csvstat --count on the big file reported a different row count.
It is also strange, that I couldn't get csvstat to ignore the " (double quote) as quote character:
$ csvstat -b  -H --count problem.csv
Row count: 8
$ csvstat -q _  -H --count problem.csv
Row count: 8

The 10-line chunk looks as follows:
asss1237,As,Austronesian,asz,Papunesia,0,-0.75,131.73
asum1237,Asumboa,Austronesian,aua,Papunesia,0,-11.3,166.5
auhe1237,"Auhelawa,Austronesian,kud,Papunesia,0,-10.10,151.00
bwan1241,Bwanabwana,Austronesian,tte,Papunesia,2,-10.66,151.03
oyao1237,Oyaoya",Austronesian,oyy,Papunesia,0,-10.54,150.66
aulu1238,Aulua,Austronesian,aul,Papunesia,2,-16.36,167.7
aust1304,Austral,Austronesian,aut,Papunesia,4,-23.38,-149.46
avau1237,Avau,Austronesian,avb,Papunesia,1,-6.24,150.43
awad1244,Awad Bing,Austronesian,bcu,Papunesia,5,-5.6,146.35
axam1237,Axamb,Austronesian,ahb,Papunesia,0,-16.48,167.71

So the real issue seems to be that with --count all other arguments except for the file, and "No header row" (such as the delimeter) are ignored.
This occurs because of the short circuit logic around line 60 of csvstat.py.

Makes sense. Meanwhile I narrowed the test file down to 360 lines. Cutting off 20 lines at the beginning makes the issue disappear, as well as cutting off 20 lines at the end.
And maybe I stumbled upon another issue: The double quotes in my example above have been inserted by csvsort. A diff of the sorted lines of my minimal example and a csvsorted file contains:
237,240c237,240
< ormu1248,Ormu,Austronesian,orz,Papunesia,0,-2.51,140.60
< otda1235,Ot Danum,Austronesian,otd,Papunesia,10,-0.40,113.47
< ouma1237,Ouma,Austronesian,oum,Papunesia,0,-10.23,149.10
< oyao1237,Oya'oya,Austronesian,oyy,Papunesia,0,-10.54,150.66
---
> ormu1248,Ormu,Austronesian,orz,Papunesia,0,-2.51,140.6
> otda1235,Ot Danum,Austronesian,otd,Papunesia,10,-0.4,113.47
> ouma1237,Ouma,Austronesian,oum,Papunesia,0,-10.23,149.1
> oyao1237,Oyaoya",Austronesian,oyy,Papunesia,0,-10.54,150.66

The diff is a bit messy, though, because csvsort does also normalize the float representation.
Again, I couldn't easily minimize this example beyond the 360 lines ...

This last bit does also mean, that the minimal example exhibiting the original issue doesn't actually contain any double quotes :) - just single quotes, which seem to have a special meaning for csvkit.

Probably the original issue had to do with the "CSV sniffing"; it tries to detect what the separator and quote are. I guess csvstat -c 1 guessed the separator as ', and csvstat --count guessed the separator as ". This is somewhat related to #166.
Maybe csvstat -c 1 -q '"' gl_languages3.csv would give the correct result.

@edwardros Indeed:
$  csvstat -c 1 -q '"' gl_languages3.csv
  1. id
	<type 'unicode'>
	Nulls: False
	Unique values: 7941
	Max length: 8

Row count: 7941
$ csvstat -c 1 gl_languages3.csv
  1. id
	<type 'unicode'>
	Nulls: False
	Unique values: 7939
	Max length: 8

Row count: 7939

But having the sniffing behaviour on by default seems wrong to me. It may lead to subtle bugs and errors which are hard to debug.

Agreed that CSV sniffing produces subtle bugs that are hard to debug. Centralizing discussion in #166.


Correct Spelling "wholes" to "holes"

Correct word: "wholes" should be "holes" in describing the interpolated method creation string.  A "hole" is an opening that can be filled in (as in this case).  The "whole" means the entirety of something and is not correct in this case.  There is no such word "wholes".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99a4410c-4c8d-0107-845b-9a951bb76682
Version Independent ID: f1ed9873-3e29-b4bd-2dbb-44dd9a05d790
Content: Source Generators
Content Source: docs/csharp/roslyn-sdk/source-generators-overview.md
Product: dotnet-csharp
Technology: csharp-roslyn
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks @pgfuller
I've opened a PR to address this.


use lib/concrete_holidays.rb as a manifest

@soulcutter does this look better in order to fix #1

Yeah, I think this is a good improvement! :+1:

^same


FileNotFoundException or ProxyCacheException

When the URL file does not exist, it throws FileNotFoundException and HttpProxyCacheServer, and at the same time causes ANR.
How to get the Listener When thows ProxyCacheException or FileNotFoundException

The same problem, some result?


Duplicate API documentation contents.

Version
4.1.3
Reproduction link
router.vuejs.org
Steps to reproduce
See the minimal link.
The main content describing this method has two return sections.
Also, the return section repeats the explanatory content exactly the same.
A lot of the API documentation is in this state.
I recommend checking the typedoc.
What is expected?
Non-duplicate document content.
What is actually happening?
Duplicate document content.

I've stopped the translation work because I think many parts of the document will probably change again.
Always thank you for your hard work.

This might be a bug in the generating lib or in the way the tsdocs are written

I can look into this if it's not taken!

Any news on this "issue"? I didn't realize this seemingly needless duplication of the docs until now, but I guess this is not the intention of the original authors I guess?

In my oppinion, the docs are really great, so it's not really bad, but it just unnecessarily bloats the docs and makes them less concise.

This issue has been fixed at some point, hasn't it?

I think so


Issue: Bug report Jul22 #1

Description
Steps to Reproduce
Expected Behavior
Relevant Logs / Console output
Your Environment

ex: Browser name and version:
ex: Operating System and version:

Additional context

comment flow to jira


dont know how to get it to run

i have filled in everything but the bot is not running and the commands are not working. What do i do?

Could you please provide me with a screenshot?

Please message me @riza.py on discord


Show a spinner in place of profile buttons, so that we don't say "Accept" while we're loading

@keybase/react-hackers

Are the Android changes necessary?

@mmaxim Nope, removed, thanks.


Refactor MemorySegmentManager add method

Refactor MemorySegmentManager add method
Resolve #404
Checklist

[x] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #405 (0c59b07) into main (8697bb4) will decrease coverage by 0.00%.
The diff coverage is 99.37%.

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   96.40%   96.40%   -0.01%
==========================================
  Files          50       50
  Lines       11427    11420       -7
==========================================
- Hits        11016    11009       -7
  Misses        411      411

Impacted Files
Coverage Δ

src/vm/runners/builtin_runner.rs
94.52% <80.00%> (ø)

..._processor/builtin_hint_processor/blake2s_utils.rs
97.44% <100.00%> (ø)

...int_processor/builtin_hint_processor_definition.rs
98.49% <100.00%> (ø)

...uiltin_hint_processor/cairo_keccak/keccak_hints.rs
95.31% <100.00%> (ø)

...rocessor/builtin_hint_processor/dict_hint_utils.rs
97.36% <100.00%> (ø)

...cessor/builtin_hint_processor/find_element_hint.rs
98.14% <100.00%> (ø)

...int_processor/builtin_hint_processor/math_utils.rs
97.53% <100.00%> (ø)

...cessor/builtin_hint_processor/memcpy_hint_utils.rs
100.00% <100.00%> (ø)

...hint_processor/builtin_hint_processor/pow_utils.rs
98.03% <100.00%> (ø)

...cessor/builtin_hint_processor/secp/bigint_utils.rs
98.30% <100.00%> (ø)

... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Contact Info?

I am trying to get in touch with you but<EMAIL_ADDRESS>bounces.

In case I wasn't clear<EMAIL_ADDRESS>😄


Move staging logic to separate file

Fixes

Fixes WB-NNNNN
Fixes #NNNN

Description
What does the PR do?
copilot:summary
Testing
How was this PR tested?
Checklist

[ ] Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
[ ] Ensure PR title compliance with the conventional commits standards

copilot:poem

Current dependencies on/for this PR:

main

PR #6048   👈

This comment was auto-generated by Graphite.


ci: Use GITHUB_OUTPUT envvar instead of set-output command

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.
This PR updates the usage of set-output to $GITHUB_OUTPUT
Instructions for envvar usage from GitHub docs:
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

Funnily enough we have never made a stable release with that workflow since the deprecation was announced, autobuild is more convenient, but I guess it's worth fixing.


”Bichiș” is listed in the drop-down menu

Description:
"Bichiș" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Bichiș" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Bichiș, MUREȘ".


cannelloni: move cmake to nativeBuildInputs

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

👍
What's the material benefit of using nativebuildinputs for a c/cpp derivation? Does this just mean that cmake isn't pulled in as a dependency of the built derivation?


Tab completion with aliases

Git Version: 2.30.1.windows.1
OS: Windows 10 Pro
Shell: Powershell 7
In my $PROFILE .ps1, I have set a permanent alias:
New-Alias g git
In the .gitconfig, I have aliases:
git as g and checkout as co as examples
Tab completion does not work for checkout or the branch names unless i use the full git command instead of my alias. This used to work in previous versions. This works in v2.29.2.windows.2.
Previously:
g [tab] => cycle through commands
g co [tab] => cycle through branches
g co branchName => checks out branch
Now:
g [tab] => nothing happens
g co [tab] => nothing happens
g co branchName => checks out branch
git [tab]=> cycles through git commands
git checkout [tab[ => cycles through branches
Desired outcome:
g co [tab] => cycle through branches
g co branchName => checks out branch

This is not a gitsh problem


chore: add korean readme translation

Summary
Added Korean README Translation!
Ticket
closes #3580

Hi Procrustes5! Thanks for your contribution :)
Have you some Korean reviewers to suggest?

@merri4
Thank you for review!
I've changed my code, plz check.


Removes dropped request parameter

Got removed here: https://github.com/GeoNode/geonode-mapstore-client/pull/1770
Closes: #38

Converted to draft as there's still another error appearing

Incorporated by https://github.com/geosolutions-it/geonode-subsites/pull/41


Invalid data ingestion cost control example

Example 4 under Controlling ingestion to reduce cost describes

modifying the following in the ConfigMap file

but the provided example (below) is a Job, not a ConfigMap.
apiVersion: batch/v1
kind: Job
metadata:
  name: pi-with-ttl
spec:
  ttlSecondsAfterFinished: 100

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4a5fcced-8ed8-0a33-3f64-333d8fd36adc
Version Independent ID: 9e60970c-d82b-ad7e-e263-c5866e228c9b
Content: Monitoring cost for Container insights - Azure Monitor
Content Source: articles/azure-monitor/containers/container-insights-cost.md
Service: azure-monitor
Sub-service: containers
GitHub Login: @bwren
Microsoft Alias: bwren

@pl4nty Thanks for your comment. We will review the issue and get back to you shortly.

@bwren Can you please provide your insights on this issue?

Apologies for the extreme delay in this. Taking care of some backlogged items here.  This shouldn't refer to the ConfigMap file, so I'll remove that. This is specifying that you should ensure that the job configuration specifies that jobs are to be autocleaned.
#please-close


Remove namespace when getting OpenModel

What this PR does / why we need it
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?

None

/lgtm
/approve
/kind cleanup

/triage accepted


Java master hangs on shutdown

MacOS 10.12.6
Java version "1.8.0_91"
Java(TM) SE Runtime Environment (build 1.8.0_91-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.91-b14, mixed mode)
I pulled and built the 2.0.x branch last night and was messing with the Java master-demo. When you type in quit it prints the following and never quits.
Channel state: CLOSED
Channel state: SHUTDOWN
I have not changed any of the code in the master-demo and am running it via
mvn -pl example exec:java@master-demo
In my own code I have even tried calling System.exit(0) after master.shutdown() and it still hangs. If I remove the call to master.shutdown() then everything exits as expected.
I did a little profiling and it looks like it's getting stuck in com.automatak.dnp3.impl.ManagerImpl.shutdown_native_manager [native] ()
and never exiting. I've never used JNI before so I'm not sure where this code lives to debug any further.
Also the outstation-demo exits correctly.
I was going to test this with the 2.2.0 tagged branch but it errors out compiling asiodnp3/ErrorCodes.cpp.  I can report this in another issue if you want.

Thanks for the report. I won't have time to test this out until week  12/11.
That JNI method invokes the destructor for the C++ DNP3 Manger.  That calls terminates everything in an ordered way, and then calls join() for each thread in the thread pool.  It sounds like something is not cleaning up properly.
Do you get the same results if you run the C++ master demos on MaxOS?

Sorry about the delay, I got really busy because of moving. When I try the C++ master and outstation they both exit cleanly.

Version of Clang? I can try this version on Ubuntu and see if I can replicate.

Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.7.0
Thread model: posix

I'd like to report a similar issue using a Python wrapper library that was created with pybind11.  We've got a working Python outstation and master.  Everything works fine except for shutting down the outstation.  I've traced the call to DNP3Manager.Shutdown() and see the channel calling its ShutdownImpl and the MasterStack resource being freed but something is keeping io_service::run() blocked.  One theory is that shared pointer references in Python are keeping certain destructors from getting called but it looks like the call to DNP3Manager.Shutdown() should invoke all the shutdown code that is also called from destructors in classes like DNP3Channel and MasterStack.  Any ideas about where I might look or how I might determine what is causing the run() method to block?

It is probably caused by the same underlying issue in the C++, that is somehow surfaced by both bindings. I plan to review this ticket when I have time in mid-May.

Update: I can replicate this on Linux.

The hang on shutdown problem occurring in our pydnp3 test code appears to be due to python references to opendnp3 objects, specifically the channel returned by manager.AddTCPClient(...) and the master returned by channel.AddMaster(...), perhaps this is not surprising.  If we explicitly delete these references before calling manager.Shutdown(), everything works as expected.  I think the Python bindings increment a shared_ptr reference on these objects.  That may be interfering with a shutdown process that expects the destructors of these to objects to be executed.

A user reported a similar issue in the C++ under the right conditions, which I have been able to resolve in this branch:
https://github.com/automatak/dnp3/tree/bug/deadlock_and_lifetimes
An infinite timer was being created that never exited, and this blocked the thread pool thread from exiting cleanly.
I just tested the master demo, and it also resolves this issue as well. This branch will get merged in 2.0.x for the upcoming 2.3.0-RC1 release.

Gday,
The merged fixes definitely improved the situation, but I can still produce a deadlock on cleanup using this example application built against 2.3.0 (700dc961d). And it crops up in the wild in my application tests for opendatacon.
main.cpp.txt
The main thread gets stuck in ThreadPool::Shutdown(), blocked on joining the threads. The rest of the threads are still in ThreadPool::Run. So there must still be some asio task that's keeping everything from exiting.
I'll have a go at identifying the offending asio task by turning on asio debug output, but I haven't had much luck trying to interpret that output before. So maybe you guys can take another look?
Regards,
Neil.

Thanks Neil. @emgre dived the ASIO debug mode to fix some of the issues, so shouldn't be a problem finding the issue.

ASIO debug mode put me straight onto the source of the problem:
After it locked up, I could see that there was still a post, callback cycle happening every few seconds, so I was able to just put a breakpoint in asiopal::Executor::Post(), and sure enough, there is a SocketChannel re-transmit cycle that is stopping asio run from exiting.

I can see that asiodnp3::IOHandler::isShutdown bool is still false, so I'm assuming that is the problem. ie. Shutdown() on the SocketChannel hasn't been called in the shutdown sequence. How to fix it... that's where I get lost. Over to you :-)
Regards,
Neil.

I think I've given you a bum steer, sorry.
The example code is using two separate DNP3Managers (I've forgotten why I did that now - probably just ruling things in/out when I was troubleshooting the original problem).
So the re transmit cycle I was observing was on the other DNP3Manager. The DNP3Managers each have a separate asio::io_context, so they shouldn't impact each other shutting down... so I'm back to not knowing what's stopping asio run from returning.
Regards,
Neil.

@neilstephens On what platform/compiler are you experiencing this? I compiled your main.cpp on my Windows machine using MSVC 2019, both Debug and Release, and the program looks fine. It doesn't hang and use a constant amount of memory.

@neilstephens
cc @jadamcrain
I think I found the issue. With ASIO_ENABLE_HANDLER_TRACKING enabled, I was able to track down the handler that was preventing the thread pool to finish. It's in TCPServer.
On Windows, if an acceptor already accepted a connection, putting the callback in ASIO handler queue, and you close the acceptor before being called back, the accepted socket becomes invalid. I added this check a few commits ago to prevent the fault.
On Linux, under the same circumstances, the socket is simply reported as valid. Therefore, the socket is accepted and the accept loop is continued even if the server was shutdown.
I'm working on a fix at the moment, I'll let you know when it's ready. It also affects the TLS server.
Thanks for the report!

You can try branch bugfix-tcpserver-shutdown and tell us if it fixes your issue.

Cool! I'll try out that branch in the next couple of hours. Sorry I didn't get around to forwarding those emails, but looks like you had enough info to go off anyway. Thanks.

Seems fixed to me. Nice work.
I'll have to look up some tutorials on using ASIO_ENABLE_HANDLER_TRACKING. It seems really powerful, and really neat how you can visualise what's going on with the handlerviz.pl script. I just have to figure out how to interpret the graphs and link the info back to the code.
Cheers,
Neil.

The fixes were merge in release 2.3.1.


chore: check source maps

This is a draft PR that checks if source maps are getting included in prod builds or not.

Summary by CodeRabbit

Refactor

Adjusted output path settings for airgapped and non-airgapped instances to enhance deployment flexibility.
Updated the handling of path configurations in widgets to improve dynamic assignment and merging.
Simplified the logic in table widget configuration for better maintainability and readability.
Modified the hideByColumnType function for efficiency in handling column types.

/build-deploy-preview recreate=true


Unable to add locationId in sqpayment form - ChallengeParameters is not defined

I was using the sqpaymentform without locationId but for buyerVerification I am required to use it. As i Add it I receive the following errors in the console.
Uncaught ReferenceError: ChallengeParameters is not defined
at Object. ((index):363)
at Object.1 ((index):371)
at t ((index):1)data.js:15
at (index):1
at Object.2.../../build/libs/3ds2-widget-js-1.0.138035.js ((index):372)
at t ((index):1)
at va ((index):1)
at (index):1
Uncaught TypeError: t.load is not a function
at HTMLScriptElement.i.onload (data.js:15)

Hey @raza-jahangir I believe we spoke on BuildWithSquare, but just wanted to close the loop here. We've added some code on Square's side to not break the payment form if the ChallengeParameters is not defined, but ultimately it seemed like it wasn't defined due to the partnership (WP Easy Pay) possibly had a bug since we were unable to replicate it. I'll close this issue out since we've made a change on our end, but please re-open if you feel otherwise. Thank you for reporting!


Use pool in search command

The Search command only used the upstream PyPi repository instead of the possible configured Pool of repositories.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.
If you have any questions to any of the points above, just submit and ask!  This checklist is here to help you, not to deter you from contributing!

NO.
The PR might be appeal only after #1008 being resolved and the consistency of repository setting between search and install commands being established.


Add direct IO network interface

The aim is to add a network interface which can be serviced just using two callbacks. Something like that would allow libmav to be integrated into MAVSDK.
The current implementation seems to hang somewhere and never actually move on. I'm not sure yet why. Any hints would be most welcome.

Hmm, you'd only need a "DirectIO" class if you want to use the threading of libmav and actually want it to spawn a thread for the interfaces. If you use the threading and interface classes of MAVSDK, you could directly interface with StreamParser class for parsing (eats bytes and spits out Message objects).
As long as you don't instantiate the NetowrkRuntime class, libmav is also just a bunch of functions and doesn't do any threads etc. - I believe that would be easier to integrate into MAVSDK

I should close this. I'll try StreamParser when I get to it, thanks @ThomasDebrunner!


feat: allow the ability to hide the dismissal button for the FluentMessageBar.

Pull Request
📖 Description
Adds the AllowDismiss property to the FluentMessageBar component.  Sometimes it would be beneficial to have a message bar displayed that is not dismissible by the user.  This adds the property and sets the default to true so that existing instances do not break.  I added another FluentMessageBar instance under the MessageBarSimple example to demonstrate the behavior and for documentation.
✅ Checklist
General

[ ] I have added tests for my changes.
[x] I have tested my changes.
[x] I have updated the project documentation to reflect my changes.
[x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[ ] I have added Unit Tests for my new compontent
[x] I have modified an existing component
[ ] I have validate Unit Tests for an existing component

Hi Steven, Thanks for this.
Before we can merge, please make sure the existing Unit Tests validate (pretty sure it will fial now with AllowDissmiss=false) and add some new Unit Tests to test this new behavior

I find this improvement interesting.
Could you include a screenshot of this new "design" in your PR, to check if the UI rules are respected?

Here is a screenshot of the demo app:

It appears to honor the UI rules and allows the content to fill up the entire space now.  I'll take a look at the unit tests to see what needs to be updated there.  Thanks for the consideration.

I added another unit test for this new property.  The existing unit test was still succeeding (as it should) since this property does not affect existing instances with the default set to true.  Please let me know if you need anything else to complete this PR.


Migrate to sigwin/infra (both local and generated packages)

Related to https://github.com/sigwinhq/infra/issues/7


RegExpMatchArray has incorrect type definition

TypeScript Version:  2.4.1
The strict option is enabled.
Code
const match = "a".match(/(a)?(b)?/);
if (match !== null) {
    const [, a, b] = match;
    alert(b.toUpperCase());
}

Expected behavior:
The compiler should warn that b might be undefined.
Actual behavior:
No compile errors, and run-time error.
interface RegExpMatchArray extends Array<string> should be Array<string|undefined>

This is intentionally less strict to avoid unnecessary friction with non-optional groups (which are by far more common IME). Maybe we'd have gone a different direction if we started with strict null checks from the beginning, but this isn't the sort of breaking change we would want to do now.

Kinda' old and everyone's probably already moved on but I thought I'd just put this here,
Less Intrusive
You could have a global.d.ts of sorts, and throw this in,
interface RegExpExecArrayOptionalItems extends Array<string|undefined> {
    index: number;
    input: string;
}

Then, where ever else,
const match : RegExpExecArrayOptionalItems|null = /^(\d+)?.+$/.exec("hahaha");
//match will be RegExpExecArrayOptionalItems
//match[1] will be undefined
//The type checker will work as intended

But, as you can see, you have to manually declare the type of match.

More Intrusive
I don't really like this one
You could have a global.d.ts of sorts, and throw this in,
interface RegExpExecArrayOptionalItems extends Array<string|undefined> {
    index: number;
    input: string;
}
interface RegExp {
    /**
      * Executes a search on a string using a regular expression pattern, and returns an array containing the results of that search.
      * @param string The String object or string literal on which to perform the search.
      */
    exec(string: string): RegExpExecArrayOptionalItems | null;
}

Then, where ever else,
const match = /^(\d+)$/.exec("123");
//match will be RegExpExecArrayOptionalItems
//match[1] will be string|undefined, even though our regex says to match only if the group exists

But, as you can see, even groups that are "guaranteed" to exist will be marked as potentially undefined


Create the Wireframes and Lo-fi for the Sign In and Sign up page

https://www.figma.com/file/HDodbxGZGTlpZFJKqWSV2C/Team-50-Chunk-Files?node-id=299%3A93

The assigned pages has been designed. Designed both mobile and web screens

Godlike also partake in this task


"beet ls" core dumps: SQLite problem with lyrics + sort

I'm currently trying to debug a problem with my database: I cannot do a "beet ls", for I then received Bus error (core dumped) with exit code 135. Debugging this leads me down a big hole, and the final error may lay on SQLite's side more than beets'. I'm still posting it here in hopes for debugging help. I use SQLite <IP_ADDRESS>.
The crash happens on beets/dbcore/db.py:808: rows = tx.query(sql, subvals). The query executed is the following: select * from items where (1) order by (case artist_sort when null then artist when "" then artist else artist_sort end) asc, album asc, disc asc, track asc;
I then tested several commands:
select id from items where (1) order by (case artist_sort when null then artist when "" then artist else artist_sort end) asc, album asc, disc asc, track asc; → DOESN'T CRASH
select lyrics from items where (1) order by (case artist_sort when null then artist when "" then artist else artist_sort end) asc, album asc, disc asc, track asc; → CRASHES
select lyrics from items where (1) → DOESN'T CRASH
If I apply a filter (beets ls foo),

If the filter is short (e.g. 1 letter) there will be many results and it crashes
If it's really discriminant the query will success

So there's a problem in sorting big sets of data? I'm kind of lost at this point, and help would be gladly received!

I rolled sqlite3 back to version 3.717, and instead of a core dump I got the message "disk or database is full"... / was full indeed.
There's not bug whatsoever, forget it!


feat: [playground] Add revert configs to default option

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?

What changes did you make? (Give an overview)
A "Reset" button has been added to restore the config to the default ESLint settings, matching what users see when they first open the playground.

Related Issues
#592
Is there anything you'd like reviewers to focus on?
The button is currently labelled "Revert Configs to Default," but I'm open to suggestions for a different name also.

How about just "Reset"?

Just to be clear, the button is resetting the config to what it was when the page was loaded correct? (So that it's either being read from localStorage or is the default for the playground?)

Personally, I support this proposal 👍 I've often been the guy who was looking for that button, only to realize it wasn't there every time again. Even so, I'm aware of recommendations not to use reset buttons in forms for various reasons like this one, or this one from MDN (in the note), so I'd be interested in other opinions.

we had some discussions related to naming the button reset @nzakas thats why we named it different.

Just to be clear, the button is resetting the config to what it was when the page was loaded correct? (So that it's either being read from localStorage or is the default for the playground?)

The button resets the config to the default ESLint configuration, which is the same as what users see when they first open the playground.

Then I definitely think "Reset" is a clearer title for the button.

Then I definitely think "Reset" is a clearer title for the button.

👍   I’ve updated the button name.

It's working for me. I'm not sure what you did in the video, but you need to add or remove some rules and then hit Reset to see it work.

Seems to be working fine. I was wondering if it would reset the playground's config to empty state.


Add Java8 AL2 Tests and Validation Handler

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hold on this PR, it may not be necessary.


Default ResponseType IOperationFilter with 5.0.0-rc3

I'm trying to set a default response type for every Resource:
    public class DefaultResponseTypeFilter : IOperationFilter {
        public void Apply(OpenApiOperation operation, OperationFilterContext context) {
            // -- Swashbuckle 4
            // var problemDetailsSchema = context.SchemaRegistry.GetOrRegister(typeof(ProblemDetails));
            // operation.Responses.Add("default", new Response { Description = "Error", Schema = problemDetailsSchema });

            // -- Swashbuckle 5
            var schema = context.SchemaGenerator.GenerateSchema(typeof(ProblemDetails), context.SchemaRepository);
            schema.Description = "Error";
            operation.Responses.Add("default", new OpenApiResponse {
                Description = schema.Description,
                Reference = schema.Reference,
            });
        }
    }

But the swagger.json (V2) does not look like i would expect it.
This is what I get:
"responses": {
	"200": {
		"description": "Success",
		"schema": {
			"type": "array",
			"items": {
				"type": "string"
			}
		}
	},
	"default": {
		"$ref": "#/definitions/ProblemDetails"
	}
}

And this is what I would expect:
"responses": {
	"200": {
		"description": "Success",
		"schema": {
			"type": "array",
			"items": {
				"type": "string"
			}
		}
	},
	"default": {
		"description" : "Error",
		"schema" : {
			"$ref": "#/definitions/ProblemDetails"
		}
	}
}

Not entirely sure if its a bug or I'm not doing it right, but my guess would be that its a bug...
This migrated vom v4 (obviously...) and the intend is to allow ProblemDetails as response type to indicate failure.
But if there is a better way to do it please let me know.
Thx!

Do to some structural changes between Swagger/OpenAPI V3 and the previous version of the spec, you'll need to structure your default response as follows:
internal class DefaultResponseOperationFilter : IOperationFilter
{
    public void Apply(OpenApiOperation operation, OperationFilterContext context)
    {
        operation.Responses.Add("default", new OpenApiResponse
        {
            Description = "Problem response",
            Content = new Dictionary<string, OpenApiMediaType>
            {
                [ "application/json" ] = new OpenApiMediaType
                {
                    Schema = context.SchemaGenerator.GenerateSchema(typeof(ProblemDetails), context.SchemaRepository)
                }
            }
        });
    }
}

That works as expected.
Thank you for clearing that up!


Amplify storage - change bucket

Hi,
as described in this tutorial:
https://docs.amplify.aws/lib/storage/getting-started/q/platform/ios#initialize-amplify-storage
I integrated Amplify storage with my iOS app. The thing is that this conf created a new S3 bucket, when what I was looking for was to link to my existing bucket.
Could someone please explain me how to achieve this?

This is not yet possible with the CLI. See the RFC for this feature: https://github.com/aws-amplify/amplify-cli/issues/3977

ok fyi as a work around I created a lambda script to copy each created object to the target bucket


Stroke on Text and Path not working on Android

I tried the Text example from the documentation and it does not work, it just shows up as plain white text.
What I can see is that fill is behaving like stroke on Path's.
"react": "15.4.2",
"react-native": "0.40.0",
"react-native-svg": "^4.6.1"

Solved by updating to react-native-svg 5.1.3 and running ./gradlew clear

Path is indeed working, but since I had scale 0.1 it was paper thin and hard to see.


#257 The cp -R command on Mac OS X behaves differently

The way is compatible with Mac OS X and Linux / UNIX
cp -r camel-quarkus/integration-tests/servlet .

The following is the description of the -R parameter in the man pages for cp on Mac OS X:
If source_file designates a directory, cp copies the directory and the entire subtree connected at that point. If the source_file ends in a /, the contents of the directory are copied rather than the directory itself. This option also causes symbolic links to be copied, rather than indirected through, and for cp to create special files rather than copying them as normal files. Created directories have the same mode as the corresponding source directory, unmodified by the process' umask.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/242/Build result: FAILURE[...truncated 535.71 KB...]Caused by: hudson.remoting.Channel$OrderlyShutdown: Command Close created at	at hudson.remoting.Channel$CloseCommand.execute(Channel.java:1273)	at hudson.remoting.Channel$1.handle(Channel.java:565)	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:85)Caused by: Command Close created at	at hudson.remoting.Command.(Command.java:68)	at hudson.remoting.Channel$CloseCommand.(Channel.java:1267)	at hudson.remoting.Channel$CloseCommand.(Channel.java:1265)	at hudson.remoting.Channel.close(Channel.java:1438)	at hudson.remoting.Channel.close(Channel.java:1405)	at hudson.remoting.Channel$CloseCommand.execute(Channel.java:1272)	... 2 moreERROR: H48 is offline; cannot locate JDK 1.8 (latest)ERROR: H48 is offline; cannot locate Maven 3.6.0ERROR: H48 is offline; cannot locate JDK 1.8 (latest)ERROR: H48 is offline; cannot locate Maven 3.6.0Adding one-line test results to commit status...ERROR: H48 is offline; cannot locate JDK 1.8 (latest)ERROR: H48 is offline; cannot locate Maven 3.6.0ERROR: H48 is offline; cannot locate JDK 1.8 (latest)ERROR: H48 is offline; cannot locate Maven 3.6.0Setting status of<PHONE_NUMBER>1fa2beee0189fbe745ef2dfed3d962 to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/242/ and message: 'FAILURE 20 tests run, 0 skipped, 0 failed.'Using context: default

Superceded by https://github.com/apache/camel-quarkus/pull/261 Please close this one whoever can.


Rewrite XenForo exclusion rules package into plugin

As agreed, all exclusion rules packages needs to be moved into plugins.

See: https://github.com/coreruleset/xenforo-rule-exclusions.
Needs someone to review before sign-off on this issue.

Looks good!
Few things:

Rules 9511155 and 9511315 are missing ver action.
Missing 'Testing' section in the readme, copy it for example from https://github.com/coreruleset/phpbb-rule-exclusions-plugin (it was written in cooperation with dune).
Remove me from CONTRIBUTORS.md as i haven't contribute into this one.

Thanks for reviewing this.
Good spot on the missing ver lines.

Missing ver lines added.
Testing paragraph added.
CONTRIBUTORS.md updated.

All outstanding issues addressed. Once CRS 4 is live then the plugin repo can be made public.
Closing this issue (but can be reopened if anyone wanted to add any further comments).


add a flag to upload to the Internet Archive

Checklist

[X] I'm reporting a feature request
[X] I've verified that I'm running yt-dlp version 2022.01.21. (update instructions)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
add a flag --upload-to-ia or --upload that uploads to the internet archive like tubeup dows. Add another flag, --delete-after-upload that deletes the files after it uploads it to the internet archive qualified.

Out of scope


20240211 goreleaser updates [skip ci]

The Issue
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview

Related Issue Link(s)
Release/Deployment Notes

Accidental - was supposed to be on ddev-test


Clean up the SystemJS build configuration

Get rid of the test-config.js file, incorporate changes appropriately into es-no-build. Figure out how to get rid of the dist/ folder if possible, so that the production and development html files can be identical. It is tricky figuring out how to tell if you are in production or development...

I've started using SystemJS builder for production. I don't have a clean way of building for production and development yet, but at least consumers of the app don't need to worry about any of es-no-build's dependencies.

Now using Zwitterion


final response can't be set on a network call with inline editor

Hi,
I've used inline editor and for my intent conv.ask works fine inside intent handler function.
But when I do a network call in the intent handler function and try to set conv.ask on success response from third party server, I get final_response must be set error.
PS: The network call on third party server is a success as I'm using the paid plan for google cloud functions and see the response in the debugger as well.
Kindly help!

Got it!
We need to return promise for async calls inside intent handler function.


CI: Modify how job success is verified for tests

Because of PyMechanical crash on exit (Known limitation : #85), the tests are verified using the outputs stored in text file. This will be fixed from next version of Mechanical and hence updating the jobs if version > 24R2.

@dipinknair please also take a look at the @@success@@ stdout workaround in the tests


Plausible wont show in WP dashboard

Plausible wont show in WP dashboard. I've followed all the instructions and even recreated the shared link twice. It says 'plausible.io unable to connect'. Pls see attached image.

hi @teeore! are you trying to embed a password protected shared link? this error normally shows for that. try to create a new non-password protected shared link and try to embed that one. you can read more here https://plausible.io/wordpress-analytics-plugin#how-to-view-your-stats-directly-in-your-wordpress-dashboard


Random Shrinking in state machine tests

Hello!
I am using proptest_state_machine  to write some tests. Whilst experimenting, i noticed that it appears that the input for shrinking the collection of transitions is the original collection of transitions, rather than the transitions that were able to be executed against the system under test.
here is a portion of the verbose log output:
proptest: Next test input: (initial_state, transitions) = (RefState { wallet_state: None }, [RegisterWallet, RegisterAlreadyRegisteredWallet, DeregisterWallet, RegisterDeregisteredWallet, DeregisterWallet, RegisterDeregisteredWallet, DeregisterWallet, RegisterDeregisteredWallet])

Running a test case with 8 transitions.

Applying transition 1/8: RegisterWallet

Applying transition 2/8: RegisterAlreadyRegisteredWallet
thread 'experiment::test_fn' panicked at libs/spbt/src/experiment.rs:178:17:
OMG2!
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
proptest: Test case failed: OMG2!
proptest: Next test input: (initial_state, transitions) = (RefState { wallet_state: None }, [RegisterWallet, RegisterAlreadyRegisteredWallet, DeregisterWallet, RegisterDeregisteredWallet, DeregisterWallet, RegisterDeregisteredWallet, DeregisterWallet])

Running a test case with 7 transitions.

Applying transition 1/7: RegisterWallet

Applying transition 2/7: RegisterAlreadyRegisteredWallet
thread 'experiment::test_fn' panicked at libs/spbt/src/experiment.rs:178:17:
OMG2!
proptest: Test case failed: OMG2!

As you can see after the abstract execution proptest generated a sequence of 8 transitions. When executing those transitions against the system under test it failed after the second transition. proptests current behavior appears to be attempting to shrink the original sequence of transitions from the abstract execution (8 transitions) rather than the transitions that were executed against system until it failed (2 transitions).
Is this behavior deliberate? Would it not be better to shrink based on the sequence of transitions that led to failure as this is more likely to lead to a minimally reproducible case?
Additionally it appears from my understanding of the code, that it only shrinks from the back until it removes the bad transition, and does not try to remove random transitions from before it.
https://github.com/proptest-rs/proptest/blob/d6f95d46e7d1a1875d16b6f9eb91906b52a5b8c6/proptest-state-machine/src/strategy.rs#L295-L322
My (naive) expectation would be that given a sequence of transitions leading to a failure, the shrinking would start from the failing sequence and discard intermediary transitions in order to determine the minimal sequence of transitions needed to reproduce the failure.
I am willing to help contribute a fix :)

Hi, what are you using for the number of transitions in the prop_state_machine! macro invocation? There's one thing that may be preventing shrinking of the number of the transitions; when you use a single value rather than a range, the minimum number of transition is set to this value, which prevents any DeleteTransition to be applicable (the condition if self.included_transitions.count() == self.min_size in fn try_simplify). I will open a PR to improve this so that the minimum doesn't prevent deletions, which is both unnecessary and unexpected.
If you use a range (e.g. ..20) for the number of transitions fn try_simplify first attempts to delete transitions from the back of the vec, as that cannot invalidate pre-conditions and once that's exhausted, it also tries to delete transitions anywhere else in the vec.

@henriiik pls let me know if this has solved your issue. If not, we can reopen this

@henriiik pls let me know if this has solved your issue. If not, we can reopen this

@tzemanovic  This does not solve my issue.
My main problem is that the shrinking only shrinks one transition from the end for each iteration.
If the initial transition list contains 100 transitions and the test fails after 10 transitions, the next iteration of the test will be initiated with 99 transitions and still fail after 3. It will take 90 test iterations to reduce the test down to a state where it can  start removing relevant transitions.
I use proptest to test networked services and every transition makes at least one network call and thus usually takes a minimum of 100ms but often longer. If the test failure is due to a timeout it's of course a lot worse.
Sorry for the slow reply, and thank you for the fix you did make! It was quite annoying to have to specify the minimum and sometimes get a very low transition counts in tests.


[BUG] OnHandLost and OnLastHandDeactivated is not invoked for a specific hand (UnityEditor)

Describe the bug
OnHandLost and OnLastHandDeactivated of the SolverHander are never called when tracking only one hand (Left).
Cannot test it on the HoloLens 2 right now, so this bug may only an Editor issue.
Interestingly, if the SolverHandlers Tracked Handedness is "Everything", all events work as intended.
To reproduce
Create a GameObject and add:

SolverHandler
HandConstraint

Edit the SolverHandler:

Tracked Target Type: HandJoint
- Tracked Handedness: Left
Tracked Hand Joint: Palm

Register a console output to all events of the HandConstraint.
Press play and use the left hand simulation.
You'll see that OnHandActivate and OnFirstHandDetected are called but OnLastHandDeactivated and OnHandLost are not.
Expected behavior
OnLastHandDeactivated and OnHandLost are called, when the left simulated hand disappears.
Setup

Unity 2022.3.7f1
MRTK3 (4.0.0-pre.1)

Target platform (please complete the following information)

Unity Editor, HoloLens 2

I've been looking into this. It appears the cause of the bug relates to the interplay between the SolverHandler class and the HandConstraint  class and the logic they use to determine if a hand is being actively tracked.
When the 'SolverHandler' is set to both/everything and 'AttachToNewTrackedObject' is called it looks to see if the preferred hand is being tracked and if not, if the other hand is being tracked. If neither hand is tracked it sets the 'currentTrackedHandedness' to None. Crucially, it's criteria for determining if a hand is tracked is the look at the relevant  'XRNode' (left/right) AND if 'HasValue' is true will also try to get the Palm joint. Which will fail if the hand is not actively being tracked. However, in summary, if the 'SovlerHandler' is set to 'both' mode when the hands are lost then 'currentTrackedHandedness' used by the 'HandConstraint' will change to 'Handedness.None' - that will then trigger the logic in 'SolverUpdate' in 'HandConstraint.cs' to fire an event - because 'trackedNode' will become none, triggering a state change.
When the 'SolverHandler' is set to left (or presumably right), 'SolverHandler.AttachToNewTrackedObject' will never update the 'currentTrackedHandedness' based on the tracked hand state - so it will remain set to left or right. When 'SolverUpdate' in 'HandConstraint.cs' is called in this state, the 'trackedNode' will remain the same - i.e. left or right. This would be fine IF when the hand stops being tracked the XRNode.HasValue flag would also change value to false, but it does not. I assume this is a quirk of how individual OpenXR providers interpret whether a hand is being tracked or not. If it adopted the same logic used in 'SolverHandler' and also checked to see if it could retrieve the palm position, then the state would change and the events would fire.
I'd recommend that 'HandConstraint::SolverUpdate' uses the same logic for determining whether a hand is tracked as 'SolverHandler' - ('IsHandTracked') and looks at both the XRNode.HasValue flag and whether it can actually retrieve the palm joint position. @keveleigh what do you think?