Little tweaks that would be useful or things I noticed

First of nice work with the API. Haven't worked too much with Ruby, so not sure if I'd be much help on the tech side (more a .NET dev), though considering making a Windows app (desktop, mobile, xbox).
Little tweaks that would be useful or things I noticed:

Setting up https://api.spacexdata.com/vehicles/ to return a list of vehicles would be useful
Falcon 1 seems to be missing
https://api.spacexdata.com/sites has a list of vehicles, but just looks to be a string. Should this be a list?
A link between different objects. E.g. Finding the launch site from a launch isn't straight forward (match "CCAFS LC-40" from a launch to "Space Launch Complex 40" in site)

Like I said above, I'm more a .NET dev, but if you want to bounce any ideas or problems of me let me know. My day job is working with MVC WebAPI. Nice work :)

Thanks for the feedback. It's nice that API's are generally platform agnostic, so anyone can easily contribute, regardless of programming language. Universal data! 👍
Regarding the tweaks,

Planning on allowing /vehicles to show the full list, waiting on an open pull request to finish some edits so I can merge and finish that.

Absolutely right about Falcon 1 being missing. I'm doing some digging to compile information to add a section for it.

It should be a list, I think I left it as a string originally because only one type of rocket is being launched currently. I'll change it to allow for better expansion. Actually in the process of revamping the sites info to have more detail, especially on the individual launchpads, similar to This page

Agreed. Consistency across the different results is key. When I revise the site data, I'll update it to match the rest of the data.

I appreciate the feedback, and I'll keep you updated on the fixes as I add them. If I run into any issues or have any other ideas, I'll be sure to reach out 👍

Site data is now under the endpoint
https://api.spacexdata.com/launchpads

Just to update this issue, only thing left to do is get Falcon 1 data together and in the api

Falcon 1 data has been added as of fe195477fb07139c23ab567c36d247267874c4cb

Cool, got a bit of spare time in the  coming week to have a proper go at connecting it up. Thanks
Sent from my Windows 10 phone
From: Jake<EMAIL_ADDRESS>Sent: Monday, 17 July 2017 10:15 PM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [r-spacex/SpaceX-API] Little tweaks that would be useful or things I noticed (#7)
Falcon 1 data has been added as of fe19547https://github.com/r-spacex/SpaceX-API/commit/fe195477fb07139c23ab567c36d247267874c4cb
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/r-spacex/SpaceX-API/issues/7#issuecomment-315738963, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AX797mVxXESuEgjcHOILlbn_-5zzIArLks5sO1A1gaJpZM4OEQ4t.


AsyncValue as a seperate package

I think that sperating AsyncValue as an indepedent library will be great idea for people who cannot use riverpod. It really helps to reduce a lot of boilerplate

Feel free to copy the source.
Alternatively you can still depend on riverpod. It's a pure dart package, and dart has tree-shaking.
I don't plan on making a package for this.


problèmes de compilation de la bibliothèque BleDevice

In file included from c:\Users\User\Documents\Arduino\libraries\ESP32_BLE_Arduino\src/BLEAdvertising.h:15,
from c:\Users\User\Documents\Arduino\libraries\ESP32_BLE_Arduino\src/BLEServer.h:19,
from c:\Users\User\Documents\Arduino\libraries\ESP32_BLE_Arduino\src/BLEDevice.h:18,
from C:\Users\User\Downloads\sketch_aug17a\sketch_aug17a.ino:2:
c:\Users\User\Documents\Arduino\libraries\ESP32_BLE_Arduino\src/FreeRTOS.h:61:28: error: 'ringbuf_type_t' has not been declared
Ringbuffer(size_t length, ringbuf_type_t type = RINGBUF_TYPE_NOSPLIT);
^~~~~~~~~~~~~~
exit status 1
Compilation error: exit status 1

yes, i also have this problem,have you solved it


Add contributing info to www

From an email thread:
A point that Dave brought up which is worth reiterating is regarding licensing and copyright assertion. I won't accept a non-BSD license. MIT license may be acceptable if BSD is impossible for you, but no GPL, Apache or other OSI approved licenses will be accepted. Additionally, I leave copyright assertion up to the contributor. When you send a patch or pull request it is your choice to also include your copyright information (or not). I will not limit acceptance of a patch based on copyright.
I will add that information to the website and documentation as soon as I can.

Base version up but still needs reviewing and more info: http://singularity.lbl.gov/#contributing

Good enough for now.


Improve documentation

The quest editor documentation is a bit out of date and written with only D2E in mind.  It could use some love.
https://github.com/NPBruce/valkyrie/wiki/QuestGuide

I'm on it.

Creating a MoM guide.
Translating both guides to spanish.

FYI I have updated this a lot, the manual section is now quite good and I have written a MoM tutorial.

This will never really be 'done' but I think the documentation is good enough for now, ongoing work required.


Verification logic does not ensure lexicographical ordering

The NMT guarantees lexicographical ordering and hence generated proofs follow this ordering as well. The verification logic does not enforce this though currently. This might not be a big deal as verification would fail if ordering is different though it makes it harder to reason about this and it is obviously better to enforce ordering there too.
@musalbas suggested to enforce ordering in the hasher directly. While it might seem better to follow the current pattern and fail much earlier (when adding data to the tree and not only later when hashing/creating the root), having the ordering enforced while hashing is better from a consistency perspective. it would also immediately resolve the ordering guarantee during verification as well.

The only downside I can think of, when incorporating the ordering into the hasher, is that it will have to happen on every inner node (instead of currently every leaf only), which will make proving and verification slower (probs negligible but should be confirmed in a benchmark too).

Note that the hasher is also exposed directly and indpependently of an NMT here: https://github.com/celestiaorg/nmt/blob/7d31915d17e5019abef8bdea89a3182842331cba/hasher.go#L22-L54
We should remove this code (looks like celestia-node is the only user of it and even that is about to change here . If we keep these functions there we actually must enforce the ordering in the hasher as otherwise this part of the public API can be misused.

closing in favour of https://github.com/celestiaorg/nmt/issues/95 (more actionable)


No executable on pub bin after global activate jaspr on windows

I tried activating jaspr global and it seems it doesn't have any executable on my pub bin.
Already tried to deactivate and activate it again, seems no avail. I also tried to activate other package for example rename without no issue at all.
However running
dart pub global run jaspr --help

seems to work
https://user-images.githubusercontent.com/1574722/171862828-97a65558-bb39-4e68-9ed4-d8da905f33f0.mp4

Fixed in v0.1.2


URGENT: Inconsistent formatting on iPhone device when using dynamic height

Hello,
I have noticed that when the app is deployed to an iPhone the column and row distance is not always consistent with what is generated on the simulator. Sometimes the distance is correct and at others its way more than what I have declared minimumColumnSpacing and minimumInteritemSpacing in my XML file. Does anyone know why is this happening? Has any one else experienced this issue? What is the best way to debug such an issue?

Adding shots of iPhone
Attempt 1 (way off column distance):

Attempt 2 (Incorrect column and item distance):

Note the inconsistent item distances as well in this attempt:

Attempt 3 (correct column distance but inconsistent item distance):

Again incorrect item distance:

How did you even get the differences in height in the pictures? My pictures sticks to a sqaure format.

@necov Please see my entries, both XML and .tss.

                       </View>
                </ItemTemplate>
        	</Templates>
		</ListView>

And .tss:
"#_listView": {
top: Alloy.Globals.ListViewTop,
left: 5,
right: 5,
width: Ti.UI.FILL,
height: Ti.UI.FILL,
},
"._offers": {
width: Ti.UI.FILL,
height: Ti.UI.FILL,
},
".mainView": {
width: Ti.UI.FILL,
height: Ti.UI.SIZE,
backgroundColor: "#fff",
borderRadius: '3dp',
},
".topView": {
width: Ti.UI.FILL,
height: 35,
//layout: 'vertical'
},
".infoView": {
height: 25,
width: "65%",
wordWrap: true,
left: 0,
},
".priceView": {
height: 25,
width: Titanium.UI.SIZE,
right: 5,
//borderRadius: 1,
//borderColor: "#e5e5e5",
//borderRadius: 3,
}
".priceClass": {
width: Titanium.UI.SIZE,
height: Titanium.UI.FILL,
color: 'gray',
font: {
fontFamily:'Arial',
fontSize: '9.5dp'
},
right: 5,
left: 5,
}
".lowerView": {
width: Ti.UI.FILL,
height: 35,
//layout: 'vertical'
},
".img": {
top: 5,
left: 5,
right: 5,
borderRadius: '3dp',
height: 'auto',
width: Ti.UI.FILL,
},
".providerView": {
height: 25,
width: "50%",
left: 0,
//top: 5,
//backgroundColor: 'red'
},
".likeView": {
layout: 'horizontal',
height: 25,
top: 5,
width: Ti.UI.SIZE,
right: 5,
backgroundColor: Alloy.Globals.BackgroundColor,
opacity: 0.85,
borderRadius: 3,
},
".hLine": {
width: Titanium.UI.FILL,
height: 1,
backgroundColor: "#cccccc",
//top: 5,
//bottom: 10,
left: 5,
right: 5,
},
".infoClass": {
width: Titanium.UI.FILL,
height: Titanium.UI.SIZE,
color: 'gray',
font: {
fontFamily:'Arial',
fontSize: '10dp'
},
left: 7,
right: 5
},
".providerName": {
height: Titanium.UI.SIZE,
width: Ti.UI.FILL,
color: 'gray',
font: {
fontFamily:'Arial',
fontSize: '10dp'
},
left: 7,
//top: 20,
},
".iconView": {
height: 15,
width: 15,
right: 5,
top: 5,
bottom: 5,
left: 5,
},
".imgIcon": {
height: 15,
width: 15,
image: "images/Like-White-Filled.png"
},
".likeCount": {
color: '#fff',
font: {
fontFamily:'Arial',
fontSize: '11dp'
},
top: 6,
right: 5,
}

Reopen if need, please test with module 2.0, thanks!


docs/Interesting-Taps-and-Forks.md: remove unsupported taps

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Remove taps that are no longer maintained.

Thanks @maxim-belkin!


Storage Allocation Visualizer

I want to know what's using space on my various storage devices.  I've used WinDirStat but it's dated and is certainly an un-modern UI, un-Fluent UI.
Would appreciate the ability to delete, recycle, or show items in Explorer.

Yes - so much this! I have also used WinDirStat among others, but the solutions are either very slow or unstable.

Yeah, something similar to WinDirStat but with better performance (other similar programs have achieved that), a modern UI, and future development would be a dream come true. 😊


Connection pooling behavior should be documented

I was experimenting with connection retries by using the options specified in the readme, but they were not behaving how I expected. After taking a look at the code, I realized the jackpot library is used for connection management and the factor property was increasing wait time between attempts.
I think this behavior should be documented, at very least by mentioning jackpot is managing the connections. Currently, playing with the documented options can be a bit confusing. Thoughts?

100& agree. This is really confusing. Have you found a way to config setting to not just sit in a hung state when the connection is broken. For example if memcahced is not running we should get a quick response on a .get that the connection is bad. But it seems to be retying for a long time.

I ended up using these options:
options: {
  factor: 1,      // exponential backoff factor, increases wait between attempts (feature of jackpot library)
  retries: 1,     // try to reconnect this many times
  retry: 30000    // if a server was unavailable, attempt to use it again in this many milliseconds
}

This will retry once if the connection is not available, and if it is still not available, will mark it as bad for 30 seconds. It is significantly faster than the default settings (primarily because of factor: 1). Hope this helps!

Would anyone mind sending a PR to update docs?

Hi, I am using memcached for storing express sessions via connect-memcached module, which uses memcached module. I am not able to get a pool of connections. My settings for session is as follows:-
var MemcachedStore = require('connect-memcached')(session);
var session = require('express-session');
var servers = [];
        if(typeof cacheAddr === 'string') servers.push(cacheAddr + ':' + cachePort);
        else {
                for(var i = 0; i < cacheAddr.length; i++)
                        servers.push(cacheAddr[i] + ':' + cachePort);
        }
        var store = {
            secret  : secret,
            key     : 'its',
            proxy   : 'true',
            store   : new MemcachedStore({
                hosts: servers,
                prefix: 'sess:',
                poolSize: 200
            }),
                saveUninitialized: true,
                resave: true,
                unset: 'destroy'
        };
}
var sessionStore = session(store);


⚠ LPDM Handbook (hosted on Divio) has degraded performance

In 4722516, LPDM Handbook (hosted on Divio) (https://repohubdev.tk) experienced degraded performance:

HTTP code: 500
Response time: 10088 ms

Resolved: LPDM Handbook (hosted on Divio) performance has improved in 37adcca.


Last step does not execute handleStep.

In our use case, the last step of the wizard is often the step where we have to save our data by sending an API call to our backend.
My initial thought was to use the handleStep property from the useWizard hook, so we can also enjoy the isLoading boolean and error handling.
Unfortunately, it looks like the last step never executes the handleStep function forcing us to circumvent the hook and implement our own function for executing an async function in the last step.
(And also implementing a second isLoading boolean)
Is this a known limitation of the library or did we stumble upon a bug?

I understand your use case, but at the moment this is expected behaviour. nextStep will only be invoked when the wizard detects there is "a next step" (aka a child)

I'll close this, feel free to re-open if you've any more questions


files with @ in filename have special meaning in svn

Files that contains @ in filename like, for example<EMAIL_ADDRESS>have special meanings in svn:
svn: E200009<EMAIL_ADDRESS>a peg revision is not allowed here
svn: E200009<EMAIL_ADDRESS>a peg revision is not allowed here
svn: E200009<EMAIL_ADDRESS>a peg revision is not allowed here
svn: E200009<EMAIL_ADDRESS>a peg revision is not allowed here
svn: E200009<EMAIL_ADDRESS>a peg revision is not allowed here
svn: E200009<EMAIL_ADDRESS>a peg revision is not allowed here
Problem arise also in cms module.
The problem is that these files can't be committed into svn.

Never had that problem when using Subversion myself.

According to googling, you should be able to work with these files as long as you double-quote the filename.

According to http://svnbook.red-bean.com/en/1.5/svn.advanced.pegrevs.html you can also append @ to the end of the path to make the prior symbol to be treated as a part of the filename.
Are you using svn cli? Which commands are you running which cause this error?

You're right, committing through the Netbeans cli works like a charm. Probably with svn cli it's sufficient to double-quote the filename.
Thanks and sorry for the non-issue :)


feat: the absolute discriminant of cyclotomic fields

We compute the absolute discriminant of cyclotomic fields.
From flt-regular.

LGTM
maintainer merge


Question about CPU or GPU error

I ran your code and found the following error, where are the parameters put into the GPU?
Traceback (most recent call last):
File "main.py", line 218, in
processor.start()
File "main.py", line 46, in start
seq_train(self.data_loader['train'], self.model, self.optimizer,self.device, epoch, self.recoder)
File "/home/quchunguang/sunday/CSLR/seq_scripts.py", line 24, in seq_train
loss = model.criterion_calculation(ret_dict, label, label_lgt)
File "/home/quchunguang/sunday/CSLR/slr_network.py", line 96, in criterion_calculation
label_lgt.cpu().int()).mean()
File "/home/quchunguang/anaconda3/envs/tf/lib/python3.6/site-packages/torch/nn/modules/module.py", line 547, in call
result = self.forward(*input, **kwargs)
File "/home/quchunguang/anaconda3/envs/tf/lib/python3.6/site-packages/torch/nn/modules/loss.py", line 1295, in forward
self.zero_infinity)
File "/home/quchunguang/anaconda3/envs/tf/lib/python3.6/site-packages/torch/nn/functional.py", line 1767, in ctc_loss
zero_infinity)
RuntimeError: Tensor for argument #2 'targets' is on CPU, but expected it to be on GPU (while checking arguments for ctc_loss_gpu)

I haven't met this problem before.
It seems like it is about switches between native and cudnn in earlier discussion about pytorch discussion
The recent version of pytorch adopt two different ways for different backends:
For native:
checkAllSameGPU(c, {log_probs_arg, targets_arg});
For cudnn:
  checkBackend(c, {*log_probs}, Backend::CUDA);   checkBackend(c, {*targets}, Backend::CPU);
You can debug based on your pytorch version and the backend used (torch.backends.cudnn.enabled).

what is your pytorch version?Thanks

1.10.0 and 1.10.1 works for me.

My pytorch is also 1.10.0，What is your ctcdecode version?
When I run main.py, the following error occurs:
(your) (base) quchunguang@ubuntu:~/sunday/CSLR$ python main.py
Loading model
Traceback (most recent call last):
File "main.py", line 207, in
processor = Processor(args)
File "main.py", line 33, in init
self.model, self.optimizer = self.loading()
File "main.py", line 96, in loading
loss_weights=self.arg.loss_weights,
File "/home/quchunguang/sunday/CSLR/slr_network.py", line 38, in init
self.decoder = utils.Decode(gloss_dict, num_classes, 'beam')
File "/home/quchunguang/sunday/CSLR/utils/decode.py", line 19, in init
self.ctc_decoder = ctcdecode.CTCBeamDecoder(vocab, beam_width=10, blank_id=blank_id,
AttributeError: module 'ctcdecode' has no attribute 'CTCBeamDecoder'

The version has been presented in Readme, it seems like you did not install ctcdecoder successfully.


perf(shared): throttle节流修改

Checklist

[ ] Fix linting errors
[x] Tests have been added / updated (or snapshots)

Change information
让最后一次更快的执行

Codecov Report

Merging #181 (89fd6f7) into dev (e1e6de2) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #181      +/-   ##
==========================================
- Coverage   96.43%   96.37%   -0.07%
==========================================
  Files         206      206
  Lines        4662     4664       +2
  Branches      970      970
==========================================
- Hits         4496     4495       -1
- Misses        164      167       +3
  Partials        2        2

Impacted Files
Coverage Δ

packages/varlet-ui/src/utils/shared.ts
83.69% <100.00%> (-2.98%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e6de2...89fd6f7. Read the comment docs.


KomikIndoID url change

Source information
KomikIndoID 1.4.14
Source language
Indonesia
Source new URL
https://komikindo.cz/
Other details
No response
Acknowledgements

[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL has not changed yet.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I will fill out all of the requested information in this form.

Add a :+1: reaction to issues you find important.

Superceded by #6513
The link you provided is for their website hub, rather than their manga site


Amazon text output in extended results is not split into lines

The extended output .txt file for Amazon isn't split into lines like is done for the output of the other services. This is just a flat-out bug in my code.

Fixed in commit 876baba.


Code scan issues

Hi.
I just scanned pptgen.js with SonarCube and it came back with the following issues:
Lines 2712, 2714  - "makeValueAxis" declared at line 3784 expects 2 arguments, but 3 were provided.
Line 3784 - "makeValueAxis" declared at line 3784 expects 2 arguments, but 4 were provided.
Lines 3695, 3794, 3858 - This conditional operation returns the same value whether the condition is "true" or "false".
Line 5563 - Change this condition so that it does not always evaluate to "true"; some subsequent code is never executed
Thanks!

Thanks @Brent321
The library is currently being converted to Typescript which has brought similar issues to our attention. These have been identified and will be fixed when version 3.0 is released.

Thanks @Brent321
The library is currently being converted to Typescript which has brought similar issues to our attention. These have been identified and will be fixed when version 3.0 is released.

when the 3.0 version is expected to be released? our team want to improvment the chart ability based on typescript.

Version 3.0 should be available this fall.
Feel free to check the 3.0 branch to see the progress.

Version 3.0 is tslinted now in addition to being TypeScript, so code quality is much better now.
The version-3.0 branch has the new version.


"Create repo from scratch" should change the topic name

"Create repo from scratch" is in fact the inner operation in git. So should change the topic name something like "Git object inner operation".
And create a user operation steps in "Create repo from scratch"?

I would keep "create repo from scratch" and inisde that page I will create two seperate approaches: using porcelain commands and using plumbing commands -- that would help us to understand better on git internal operations.
Thanks for valuable comment.

this is addressed with commit 0d8cfee.


TypeScript and React Native upgrade

Supersedes #437 and #438.

[x] The packager still doesn’t appear to pick up the TS files, rather it reads from ./build.
[x] Add types to remaining classes. I suppose this was meant to be about fixing all type errors?
[x] Make CI green.
[x] Fix hot-reloading.
[x] Fix TS->JS source-maps.
[ ] Fix disabled Gene view snapshot test.
[ ] Look into FlatList replacement for ListView on Home view.

@l2succes @sarahscott Can you give this a spin and see if it functions similarly well to the existing TS branch? If so, then we can go ahead and close those other 2 Hrs in favour of this one.

look at all those co-commits, this guy really knows how to use git correctly 🍡

The build references come directly from index.ios.js
import Containers from './build/lib/containers'
import Components from './build/lib/components'
import Routes from './build/lib/relay/routes'

import './build/lib/relay/config'
import './build/lib/app_registry'

export default {
  Containers,
  Components,
  Routes,
}

Yep:

Tests pass locally, re-running travis without cache

Fails

:no_entry_sign:
Please assign someone to merge this PR, and optionally include people who should review.

  Generated by :no_entry_sign: dangerJS

The build references come directly from index.ios.js

Doh, hahaha. Thanks for the catch 👌

The build is red because of other things than tests. I’ll see if I can make some progress there.

So all TS build errors are now fixed, but the build remains red because for some reason jest is not picking up any tests, eslint is failing to run, and danger is complaining about some validation.
$ yarn run lint
yarn run v0.20.3
$ eslint ./lib ./test
sh: 1: eslint: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn run lint" exited with 1.

$ yarn run danger
yarn run v0.20.3
$ danger
OK, looks good Travis CI on GitHub
Found some validation failure
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn run danger" exited with 1.

Theres the message for Danger ^
That lint error is because aslant was removed, re: JEst - probably test paths needs updating? I think the config name may have changed in jest 19

Theres the message for Danger ^

Aha. I didn’t link that from the general message on CI :)

That lint error is because aslant was removed

Ooohhhh, I see. Apparently the task still runs fine on my machine because I installed eslint globally at some point and yarn run command does not isolate.

re: JEst - probably test paths needs updating? I think the config name may have changed in jest 19

But yarn test runs fine locally 🤔

Alright, let’s get this in!

Ok, so there’s a couple of red screens that show during development when navigating back and forth. This is really annoying and requires a lot of reloading, however these problems do not manifest when building a release bundle.
So I say we :shipit: now and I’ll look into fixing the annoying dev bugs afterwards.

@alloy I double-checked all the views, I'm not sure if you noticed but the Gene refining page appears blank on initial load. You have to start scrolling for artworks to show. It only happens the first time though, after the data loads once it works fine.  Not sure if that's a real issue or not, if it is maybe we can tackle the bug in a separate PR.
Aside from that and the keyboard everything else looks good. If the issue mentioned above isn't a problem let's merge it.
Before scrolling:

After scrolling:

Good catch! That's definitely not supposed to happen, but I'm working on gene refining this week anyways, so I can PR that fix separately 👍

Congrats 🎉


Move Away from "Versioned"

https://docusaurus.io/docs/versioning

The repo I based on this on (https://github.com/easyops-cn/docusaurus-search-local) used versioned documentation but there is no reason for us to follow their example and it's kinda bad UI.
Not a high priority issue tho

Closed by https://github.com/solderq35/hitruns-wiki/commit/57ea9ffb8c57379ee4e5dd74cd23304389c1396a


Add a title attribute to the image displayed in an ImageChooserBlock

I've run into a small usability issue when using ImageChooserBlock, which is that after selecting an image there is no way to determine the title of the image without hitting "Edit this image" and viewing the full image in another tab.
I think it would be helpful if the title of the chosen image was available so that the editor has that additional contextual information close at hand.
This patch adds a title attribute to the image, so that hovering over it will display the title of the image (e.g.,):

A title isn't super salient obviously. You could argue that it should be even more obvious - e.g., the title printed below the image, but I went with a title as it will not affect the appearance of the block at all. I'm open to feedback/suggestions and happy to amend the PR accordingly.

Thanks @solarissmoke! Merged in 265d4baaf2f3dd5e31fb0bee4566d79ee1caef49 (with corresponding change to image-chooser.js to ensure that the title is updated when a new image is picked).


GULLogger - count errors and warnigns

logic to count error and warning messages added to GULLogger (https://github.com/firebase/firebase-ios-sdk/pull/1201 used as a base)

@paulb777 As per @davidair, the data will be sent along with other Firebase analytics data. It will be a separate CL.


Get parameters

Hello,
is it possible to have a get parameter?
@RestController("/foo")
public class FooController{
    @GET
    public String get(String id) {
       /* i want to use the route /foo/bar and get "bar" here in id */
    }

Unfortunately it doesn't look so:
https://github.com/skornei/restserver/blob/65d535236e3d2b888636c0c655d225af62c84654/src/main/java/ru/skornei/restserver/server/BaseRestServer.java#LL108C19-L108C32
Are you interessted in adding this?


Update preferences

Use PreferenceFragment, easier to maintain preferences, recommended way of doing it in API level > 11 (our minSdkVersion is 15). Also have updated SingleUploadFragment and Utils to work better, and use new arrays.xml.
I think the most controversial change is requiring Utils helper methods to be passed a context. This is to access the strings so we don't duplicate stuff e.g. creating Licenses in Prefs.java - there's already so many similar string names, we don't need more!
As this is quite a big change affecting a large number of files I think it's best if it is approved by at least 2 people before it's merged.
A quick explanation of what I've done:

Removed Licenses constant in Prefs, prefer using arrays.xml (which in turn inherits from strings.xml)
Move most of the code in SettingsActivity into SettingsFragment, and remove code no longer needed to force an ActionBar
setOnPreferenceChangeListener's on the spinner to update the summary as before, and recreate the activity to update the theme straight away when changed
Tidy up Utils, remove code blocks for API levels < 11 (current minSdkVersion is 15)
Require context to be passed to Utils to compare strings
Update SingleUploadFragment to not duplicate values again, use arrays.xml instead (which in turn inherits from strings.xml). May be an idea to move large if block getting license shorthand from name from SingleUploadFragment to Utils.
Move "Become a beta tester" link in settings to bottom

Please do ask any questions about anything else, will either help spot potential bugs or you'll be able to maintain it easier later :)

@domdomegg , have you tested that everything runs with at least API 21, 23 and 25? I'm a bit wary of the Utils change because there are many, many usages throughout the app, so high chance of stuff breaking. But if it has been thoroughly tested then the rationale behind it sounds good to me.

Tested with API 21, 23, 24 (physical device), 25 and 15 - found a bug in 15 that seemed to turn up in all the other ones only after I ran it through API 15 - more likely me just being crazy.
New commit should fix said bug, and it works on levels above (although with preferences its sometimes dodgy as to whether it saves it when reinstalling/uninstalling - but recreating 25 and 23 devices got same results in test).
Probably still worth someone else doing a checkout and testing it on one API level - should work first time, otherwise please do post a stacktrace.
The main things that probably need testing are:

Opening settings, messing around with them for a while - especially the license ListPreference
Logging in from a clean install (as this is where default preferences are set)
The license spinner on upload

@codacy-bot

But seriously, I think that's the best I'm going to get it for Codacy - just line lengths where I think it would be impractical to split a line and a Javadoc for a function I didn't really alter. Should be good to merge after someone tests it.

It looks like you are changing a lot in one PR. Personally I think it'd be better to split them into multiple PRs for two reasons:

Ease of testing the PR.
If we need to revert any changes and this PR is seen to be the problem, then we are reverting a lot of changes whereas if it was split into multiple PRs we would only need to revert the PR that caused the problem, hence isolating the issue would be a lot easier.

A lot of the bullet points could be made into one or two PRs themselves.

I think it looks like I'm changing a lot but that's probably just because of the stupid number of commits I made messing around with stuff (should probably squash and merge this one to avoid cluttering commit messages).
I mean potentially you could have 3 PRs:

Split PreferenceFragment and PreferenceActivity
Use arrays.xml in preferences.xml
Update Utils and SingleUploadActivity to use arrays.xml
But they are all quite linked, especially 2 & 3 there and trying to separate them would be a load of extra work rather than just updating them all at the same time.

In regards to your second advantage, because of how intertwined they are I doubt it would be easy to revert just the PR that caused the problem anyways as you'd end up with a load of merge conflicts everywhere.
I can split them up into various PRs if you wish. I'll take on board that I should probably make smaller PRs in the future though either way :)

Yeah it'd be good if you could squash them, it would be easier to understand the intent of the commits. As it is intertwined I wouldn't bother for now but in the future that'd be good. However, I'm not sure if I'll have time to review the PR so I guess it's up to the discretion of whoever reviews it.
Also I'd suggest rebasing as 2686a51 was done in #453.

I'll try to test and review later this weekend, and I agree that a 2nd reviewer would be a good idea for this PR. Sorry for the long wait @domdomegg , but it is truly massive. :)

No worries - thank you for reviewing it!
Will have a look at menu/fragment_contributions_list.xml when I get home

I wonder if it would be possible to extract the Utils.java changes into a separate PR at this stage? Those are the ones that I am most wary of due to extensive usage throughout the app. The other changes look okay to me so far and I would be happy to merge them, but having the Utils.java ones separated would help a lot.
Not sure if this is doable at this stage though?

I'm going to split this up later and do it without the horrible commit history mess that we have here.

Thanks @domdomegg !


A pass on the contributing doc

Successful PR Checklist:

[x] Documentation (optionally: run spell checking)
[x] Had a good time contributing? (if not, feel free to give some feedback)

Ping @linoor: I've added some details to the contributing doc. In particular, I've added the which python check that cost you a bit of time. Please feel free to review.

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          19     19
  Lines         743    743
  Branches       73     73
=====================================
  Hits          743    743

Impacted Files
Coverage Δ

procrastinate/testing.py
100% <ø> (ø)
:arrow_up:

procrastinate/aiopg_connector.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c983e...d810a6f. Read the comment docs.


Align scope defaults with Mastodon API

AppMethods.createApp() currently defaults to all scopes if none are given. The endpoint that is called defaults to only read scope if none is given: Mastodon documentation.
We should default to the same values, and not request more. Breaking change, because our current default value allows more than would be allowed after this change.
Other API methods that send a scope should also be checked.

Let's fix this in the 2.0.0 then.


Tensorrt execute inferences with cuda multi-streams

To maximize GPU utilization, what should I dou to parallel cuda multiple stream streams, enabling tensorrt to achieve simultaneous inference when executing inference enqueuev2 sequences?
Like This following pic :

For using stream in TensorRT, please refer here.


Add ManagedMap::range.

As mentioned here: https://github.com/m-labs/smoltcp/issues/209#issuecomment-388892966

Got it!

Thanks. What do you think about removing rustc version detection entirely? I was thinking about using impl Trait in smoltcp and that would imply 1.26. I don't think we care very much about 1.25 or earlier.

Okay. I currently have only rust 1.25 on my computer, but I can fix that.

I wonder if I should add "shortcuts", to skip a dichotomy if key_begin <= slice[0] or key_end > slice[slice.len()-1].
https://github.com/m-labs/smoltcp/issues/209 would be one use case, because we'll use <IP_ADDRESS>/0 or ::/0 as the key_begin.

I just improved my implementation to have an interface similar to BTreeMap::range, and support more range types than "left included, right excluded". (we'll need to include right in smoltcp.)
It uses the nightly feature "collections_range", but it is going to be stabilized soon; and ManagedMap already depends on "slice_rotate" anyway.

Thanks.


Incompatibility with Symfony 5

Hi!
It's impossible to use this plugin with Symfony 5.2. The issue is due to the use of the service 'templating' that is no more available in Symfony 5 (Check for example Sylius upgrade guide).

Should be working now on master branch and v2.0.0-alpha.1 release. Thanks!


Table

Bug type
Component
Component name
MudTable
What happened?
The MudTable show select all in footer
Expected behavior
MudTable not show select all in footer
Reproduction link
https://try.mudblazor.com/snippet/cOwGYNYPoXSixnes
Reproduction steps
.
Relevant log output
No response
Version (bug)
6.0.15
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The footer checkbox is there:

It just doesn't show up on the same line as the pager content.

How to fix it?


#274 - add template for management ssh documentation

Change Summary
add a template for management ssh documentation
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes)
[x] Documentation content changes
[ ] Other (please describe):

Related Issue(s)

fix #274
Component(s) name
eos_cli_config_gen role
Proposed changes

add a template for management ssh documentation
include the added template in the parent template

How to test

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated molecule CI testing accordingly
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Should we also include a table?
Or do we consider the configuration of this feature readable  enought (so there is no need to include a table in addition to the configuration)?

Should we also include a table?
Or do we consider the configuration of this feature readable enought (so there is no need to include a table in addition to the configuration)?

Table of content should be part of a different PR to make it easier to track


Add new OIDC attributes to DCR

PR - https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2173

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6561828561

Closing since new tests are addedt through pr - https://github.com/wso2/product-is/pull/17047


Upgrade EJB version to 4.0 in pom.xml files

Even if no side effect was detected so far, pom.xml files of EJB projects should reflect the version of EJB currently in use: 4.0 instead of 3.2.
To Reproduce
Steps to reproduce the behavior:

Open the pom.xml file of any of the EJB projects
 tag of maven-ejb-plugin is 3.2 instead of 4.0

Expected behavior
All  tags of pom.xml files should have the value 4.0.
Eclipse setup, build, deployment and execution should be OK after this change.
Environment:

Version 2.1.0

Test OK


Setup CI

CircleCI / TravisCI, etc... (other ones [0]
Maybe upload artififacts at the end to github releases, could use ghr with circleci [1][2] or TravisCI seems to be able to do it automatically [3]
[0] https://github.com/integrations/feature/continuous-integration
[1] https://github.com/tcnksm/ghr
[2] https://medium.com/@jgautheron/publish-your-golang-binaries-in-github-with-circleci-e0b64cb21bf8
[3] https://docs.travis-ci.com/user/deployment/releases/

TravisCI is setup now!
https://travis-ci.org/foodsharing-dev/foodsharing-light


feat: add diagnostic sources option vim_lsp

Hi!
I want diagnostics with vim-lsp.
Please review this pull request.
https://github.com/prabirshrestha/vim-lsp
vim-lsp has 1.9k stars, so it is popular.

[MEMO]
echo lsp#get_buffer_diagnostics_counts() returns {'information': 0, 'hint': 0, 'warning': 0, 'error': 5}

lgtm, thanks :smile:


Eng 1215 aa developer iwt remove duplicate code for storage canister

All tests passed.
Added networks to dfx.json
"networks": {
        "local": {
            "bind": "<IP_ADDRESS>:8000",
            "type": "ephemeral",
            "replica": {
                "subnet_type": "system"
            }
        }
    },

Closing this one. This code was merge into 0.1.4 PR #48


👩🌾 3 ➡ 4

➡ Forward port
Port ign-rendering3 to ign-rendering4
Branch comparison: https://github.com/ignitionrobotics/ign-rendering/compare/ign-rendering4...ign-rendering3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

https://github.com/osrf/buildfarmer/issues/161

The gaussian noise test failure is expected (#175)


Does this series include questions from HOOKS?

@jainayushi29 Yes, this series includes questions related to Hooks


[flutter_google_maps] Added isGesture to onCameraMoveStartedWith Gesture

Description
Google Maps Supports provide isGesture when camera starts to move on both iOS and Android but Flutter Google maps doesn't. This PR extends the Flutter Google Map dart code. No Java or Swift code touched because the channel actually provides the data, no idea why it was never implemented. To prevent breaking change, I created a new function. We can deprecate the old function later in the favour of this new function.
Related Issues
flutter/flutter#65755
flutter/flutter#50931 ( <- was a workaround )
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@googlebot I fixed it.

@googlebot I consent. yo

Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage you to file an issue and associate it with this PR.
We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).

You've indicated that you've added tests as required by our submission policy, but I'm not seeing them; please ensure that you haven't left files out of the push.

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!


How set up HTTPS for frontend?

I've enabled https, and it works with the self signed cert.
The documentation specifies that enabling https will gen a cert/key if one is not specified.. but not where to specify my cert/key(?).
If I copy or expose my my cert/key to the docker container, where can I specify what cert/key to use?

After digging around in the docker image, I found that it just generates the files in the store dir (cert.pm and key.pm).  I just softlinked them to my certificate, and it's working correctly now.
I'm set, thanks!

You can also reference to those files using env vars check SSL_KEY and SSL_CERTIFICATE


Add pragmas to disable msvc warning 4018

This commit will get rid of the signed/unsigned mismatch warnings that are generated by MSVC due to lack of explicit casting.
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4018?view=vs-2019

Damn line endings 😂


Carthage install BSImagePicker 2.3?

How?

I'd also like to know this, or a manual install would also be fine, since I can't have CocoaPods on my project.

Is this a question about Carthage in general? I.e: how do you build frameworks with it.
Or are you having specific problems with this framework in Carthage?

thank you for response, I'd like to know how to write the Cartfile to build BSImagePicker frameworks.
I can't find any information about this, and I'am new for Carthage.
Thank you very much.

Basically how to install without CocoaPods.

As per their documentation at https://github.com/Carthage/Carthage/blob/master/README.md :
github "mikaoj/BSImagePicker"

Put that into your Cartfile.

That doesn't work.
bs_presentImagePickerController is not available and I get an error when trying to present normally:
dyld: Library not loaded: @rpath/BSGridCollectionViewLayout.framework/BSGridCollectionViewLayout
  Referenced from: /Users/rodrigoruiz/Library/Developer/CoreSimulator/Devices/66770249-A0D6-4E18-AC96-4E83C11AC10A/data/Containers/Bundle/Application/BECE0C52-F376-4C56-9ED3-FA5CDC9FCD1F/Venusian.app/Frameworks/BSImagePicker.framework/BSImagePicker
  Reason: image not found

Cool, I'll look into it. Thanks for reporting it

any fix?  I really hate cocoaPods...

I'm working on 3.0 which wont depend so heavily on cocoapods.
ETA? Unknown :)

@mikaoj any update on the carthage install?

I just pushed version 2.8.1 which I got to work with carthage, please try it out.

@mikaoj  2.8.1 is still not work

What kind of errors do you get?

*** Building scheme "BSImageView" in BSImageView.xcodeproj
Build Failed
       	Task failed with exit code 65:
       	/usr/bin/xcrun xcodebuild -project /Users/zhujl/github/swift/musicode/MessageInput/Carthage/Checkouts/BSImageView/BSImageView.xcodeproj -scheme BSImageView -configuration Release -derivedDataPath /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSImageView/1.0.2 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/1p/04c4bjxs0_n5gf68zckj122c0000gn/T/BSImageView SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/zhujl/github/swift/musicode/MessageInput/Carthage/Checkouts/BSImageView)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/1p/04c4bjxs0_n5gf68zckj122c0000gn/T/carthage-xcodebuild.6kVQkB.log

And what does /var/folders/1p/04c4bjxs0_n5gf68zckj122c0000gn/T/carthage-xcodebuild.6kVQkB.log say?

/usr/bin/xcrun xcodebuild -workspace /Users/zhujl/github/swift/musicode/MessageInput/Carthage/Checkouts/BSGridCollectionViewLayout/Example/BSGridCollectionViewLayout.xcworkspace -scheme BSGridCollectionViewLayout -configuration Release -derivedDataPath /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/1p/04c4bjxs0_n5gf68zckj122c0000gn/T/BSGridCollectionViewLayout SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/zhujl/github/swift/musicode/MessageInput/Carthage/Checkouts/BSGridCollectionViewLayout)User defaults from command line:
    IDEArchivePathOverride = /var/folders/1p/04c4bjxs0_n5gf68zckj122c0000gn/T/BSGridCollectionViewLayout
    IDEDerivedDataPathOverride = /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2

Build settings from command line:
    CARTHAGE = YES
    CLANG_ENABLE_CODE_COVERAGE = NO
    CODE_SIGN_IDENTITY =
    CODE_SIGNING_REQUIRED = NO
    GCC_INSTRUMENT_PROGRAM_FLOW_ARCS = NO
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = iphoneos11.4
    SKIP_INSTALL = YES
    STRIP_INSTALLED_PRODUCT = NO

=== BUILD TARGET BSGridCollectionViewLayout OF PROJECT Pods WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
/bin/mkdir -p /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/Objects-normal/armv7
write-file /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/Objects-normal/armv7/BSGridCollectionViewLayout-OutputFileMap.json
write-file /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/unextended-module.modulemap
/bin/mkdir -p /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/Objects-normal/arm64
write-file /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/Objects-normal/arm64/BSGridCollectionViewLayout-OutputFileMap.json
write-file /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/BSGridCollectionViewLayout-project-headers.hmap
write-file /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/Objects-normal/arm64/BSGridCollectionViewLayout.LinkFileList
write-file /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/Objects-normal/armv7/BSGridCollectionViewLayout.LinkFileList
write-file /Users/zhujl/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/BSGridCollectionViewLayout/1.2.2/Build/Intermediates.noindex/ArchiveIntermediates/BSGridCollectionViewLayout/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/BSGridCollectionViewLayout.build/BSGridCollectionViewLayout-own-target-headers.hmap


Cursor is lost when entering Zen mode

VSCode Version: 1.25
OS Version: OSX 10.12.5

Steps to Reproduce:

Open a file with VSCode
Navigate to a line
Enter Zen Mode

Expected behavior
The cursor should remain in place and be usable in Zen Mode without clicking the screen.

Does this issue occur when all extensions are disabled?: Yes

I can not reproduce this, do you see this with latest vscode insiders?
Can you reproduce this issue if you simply go into full screen mode View > Toggle Full Screen?

I'll test with the latest insiders. The issue does not occur when toggling full screen, only Zen mode.

Have the same issue. Hotkey to Zenmode - Cool . But no cursor anywhere in my script. Have to grab  Mouse and click into the Script. its a pitty.

VSCode Version: 1.27.2
OS Version: macOS High Sierra 10.13.6

The same situation reproduced here. It's great if we fix it.

This was not the problem with Zen mode. It was the Centered Layout. You can disable Center Layout in Zen mode in settings.

Or add "zenMode.centerLayout": false, in User Settings.
Hopefully, cursor should be visible now in Zen mode. This Centered Layout bug is removed in latest VSCode Insiders.

OS Version: Windows_NT x64 10.0.17134

Appologies for people seeing the issue, I misunderstood the problem originally.
The point is -> this will be fixed in the next vscode stable release, and if you want it right now you can use vscode insiders
@itsmysterybox thanks for jumping in

Press F11. you'll exit the mode


BUG: Date and time is not matching with the blogpost shown in website.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The date and time which is given at the bottom of the blog is incorrect and is not matching with the correct one as every blog post is showing the same date and time . Hence it may leave negative impact on the user surfing through the website .Please allow me to fix this issue under GSSoC . I can fix it which will enhance the real time experience of the website.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Personalised blogs are being prepared after which the dates will be updated.


Current shortcut refactor

Based on task 326: Modify patient mode to use currentShortcut.
Glaring differences: The inputs for the shortcut are not persistent, and dissapear the moment a new shortcut is generated. This is due to the lack of unified patient model. We could try to patch together some kind of read/write architecture based on what we talked about yesterday, but I thought we might want to wait until we started using the SHR models. This is up for discussion.
Changes:

Removed several old functions/values used in updating TMN values, progression values, etc...
Removed any traces of two different shortcuts.
Change currentShortcut by typing into clinical notes, entering data into that shortcut as per usual.
TMN values now no longer require a double click to input data.
Progression reasons are now trimmed for leading and tailing whitespace before validation.
Suppressed some logging.
Data Summary Panel now displays based on currentShortcut, not the patient model passed. When we decide to publish data from currentShortcut to patient, this needs addressing.

I think that sums up most of what's new. Let me know if you see anything else worth mentioning, any feedback on what's described above, and any suggestions regarding the patient data publishing.
Thanks,

Dylan

looks pretty good. My only question is whether we can eliminate withinStructuredField within the FullApp and the associated methods handleStructuredFieldEntered and handleStructuredFieldExited.
Just changing currentShortcut should replace this behavior including setting it to null when the editor is not within a shortcut. This requires the editor to keep in its state the linkage between a # expression and the associated data object so that if they key into it, it can set currentShortcut to a shortcut that references the correct data object. We can merge what you have and create a new jira for this remaining work if you want

plus FullApp and ClinicalNotes both have code specific to staging and progression. we need to eliminate that

we should only have 1 place (probably in FullApp) that specifically references staging, progression, and toxicity as supported shortcuts

maybe just merge this one and then I'll create a new JIRA

Only SlimApp references progression and toxicity as a list of supported shortcuts passed into FormTray and then in the changeShortcut method. We need to achieve similar for FullApp

jira 359 created in product backlog

Great feedback -- yeah the minimal encapsulation still leaves something to be desired. I can take a look into some of this if we want. Though we might be able to tie some of those tasks in with the refactoring of Notes to use your new plugins.

For now, I'll merge

Yes totally agree may make sense as part of switching over to new editor and incorporation of new patient model. thanks!

did you want to do more on 326 or can we move the overall task to done?

Whichever you'd like -- If you want, for example, I can look into removing the withinStructuredField stuff as a first step. But as for the main task, I was done; just waiting to merge before moving to complete. Thanks for the reminder.

you did merge??? let's leave the new jira task in the product backlog and focus on sprint items for now

Yes, I did. I just didn't go to Jira right away. Hence the "thanks for the reminder".


Add Stack Data Structure

I want to add a new data structure to the repo, a stack.

#73 will resolve.

I will implement stack data structure.

https://github.com/divyanshu-rawat/Basic-JS-Algorithms/pull/81

@kyle-hall feel free to add more issues if you want 👍


Internal module mutability

Actually, it is often the case that modules have mutable data inside. Maybe somehow mark modules as containing mutable data inside to prevent the error?

Marking modules as containing mutable data probably shouldn't be done through an argument to ldump.require, but something that can be done only once.

Actually, the problem with modules with mutable data inside is more complex than I thought. Even if we mark some modules as containing mutable data, we don't prevent mutable data from becoming static -- we just prevent erroring. Then, some function may capture the current state of the mutable value and be serialized; then the value changes; then the function is deserialized, and now it has the wrong value, as the mutable data was wrongly marked as static.
My best idea is to go back to manually marking data as static. There is a silver lining -- the new logic would still have use. ldump.require can be redone as ldump.static; it would receive the value and the module's vararg parameter, containing the module path. Also, there could be ldump.static_module_at, that receives just the path to the module -- this could be called outside the module to handle external libraries. In partially mutable modules, ldump.static would be uncomfortable to use -- the user would need to provide the path over and over again. So, we introduce the third function -- ldump.get_static(...) -- it would just curry the ldump.static with the path. Maybe we can even unify get_static and static -- do a ldump.static(...)(value). Also, it should be possible to mark internally mutable values as static -- we would need non-recursive static mark.
This becomes too complicated for my tired brain, I am going to pick this up later.

So, the sketch of the new API:
ldump.const(path)(value)  -- mark as recursively static
ldump.static(path)(value)  -- mark as shallow static
ldump.const_module(path)  -- mark module as recursively static
ldump.static_module(path)  -- mark module as shallow static

The only issue is -- we can't use ldump.static anywhere except for the root of the module, as it does not receive the key path to itself. It is kind of important. Ideas?

So, const shouldn't be a double function, the same with static. Static may receive a schema, that indicates which of the fields are static.
ldump.const(value: T, path: string) -> T  -- (internal use) mark as recursively static
ldump.static(value: T, path: string, schema?: table) -> T  -- (internal use) mark as shallow static
ldump.const_module(...paths: string)  -- (external use) mark modules as recursively static
ldump.static_module(...paths: string | [string, table])  -- (external use) mark modules as shallow static

Schemas example:
ldump.static(module, select(1, ...), {
  _type_info = {
    name = true,
    fields = true,
    posix_path = true,
  },
  _statistics = true,
})

If the child is static, that should always mean that the parent is static too.
Immutable values with a static parent are not considered static by default, as they can be reassigned. Immutable values with immutable static parent should be considered static. Should the mutable values with immutable static parent be considered static? I think yes.
It would probably be helpful to mix static/const values in the tree. Like it is possible to have some_type module, which is static with mutable some_type._statistics table, that has some_type._type_info field, which is const. That means, that there shouldn't be separation between const-functions and static-functions in the API. Instead, there should be something like ldump.mark.

So, it would work like this:
ldump.mark(module, {
  _type_info = "const",
  _statistics = "static",
}, ...)

Or:
ldump.mark(module, "const", ...)
Or:
ldump.mark_module("lib.some_type", {
  type_info = "const",
  statistics = "static",
})

Actually, using const/static neologisms makes less sense here. We can mark statics with no static children with empty table, and for consts we can still say "const", this literal still seems good:
ldump.mark(module, {
  _type_info = "const",
  _statistics = {},
}, ...)

ldump.mark(module, "const", ...)

ldump.mark_module("lib.some_type", {
  type_info = "const",
  statistics = {},
})

2 issues:

There could be a fully constant library, such as tech.sound in fallen, with a bit of mutability inside (sound.cached and sound.multiple_cached). Of course, you can rewrite memoization to store values externally, but maybe ldump should not presume stuff about architecture? Two solutions: don't care, keep strict const, force to rewrite or redefine stuff as static; do an almost_const thing with defining non-static children instead of defining static ones.

Schemas are boilerplate. Maybe use them only for mark_module and revert to using fallen-style static/const keywords? Can we do that without overloading __newindex? Probably not, right?

Maybe later? Feels complicated.

The __newindex way is too complicated, it adds unnecessary __newindex logic and metatables, which would clash with user-defined metatables. Boilerplate is okay.

The resulting API:
ldump.mark(module: T, schema: table | "const", modname: string) -> T
ldump.mark_module(modname: string, schema: table | "const")


Errors

VM556:76 Syntax error @ "Surviv.io AIMBOT mods by VN BPM"!
##########################
JSHINT output:
##########################

SyntaxError: missing ) after argument list
at eval ()
at :4:80
at Object.t [as F_c] (:3:191)
at Object.E_u (:4:244)
at eval (eval at exec_fn (:2:115), :74:477)
at Object.create (eval at exec_fn (:2:115), :76:193)
at c (eval at exec_fn (:2:115), :15:231)
at :4:80
at i (eval at exec_fn (:2:115), :13:165)
at eval (eval at exec_fn (:2:115), :13:292)
eval @ VM556:76
(anonymous) @ VM541:13
v @ VM541:13
(anonymous) @ VM540 content.js:91
s @ VM540 content.js:91
n @ VM540 content.js:92
VM556:76 Uncaught SyntaxError: missing ) after argument list
at eval ()
at :4:80
at Object.t [as F_c] (:3:191)
at Object.E_u (:4:244)
at eval (eval at exec_fn ((index):2), :74:477)
at Object.create (eval at exec_fn ((index):2), :76:193)
at c (eval at exec_fn ((index):2), :15:231)
at :4:80
at i (eval at exec_fn ((index):2), :13:165)
at eval (eval at exec_fn ((index):2), :13:292)

Will fix soon


Data247logic

Please check the following conditions for your PR.

[ ] apiDefinition.swagger.json is validated using paconn validate command.
[ ] apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

Hi Doug,
Sorry for the delay, I was busy with other things, I have done all the
changes in suggested by you and your colleague. Can you please review and
let me know what is next step to proceed further.
waiting for your reply...
Regards,
M.i
On Tue, Dec 22, 2020 at 9:39 AM Doug Elliott<EMAIL_ADDRESS>wrote:

@dougelliott approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#pullrequestreview-556806881,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDU5JTRTD67YGMR3IOTSWALXZANCNFSM4UEHR3ZA
.

Hi Doug, Sorry for the delay, I was busy with other things, I have done all the changes in suggested by you and your colleague. Can you please review and let me know what is next step to proceed further. waiting for your reply... Regards, M.i
…
On Tue, Dec 22, 2020 at 9:39 AM Doug Elliott @.> wrote: @.* approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLGTDU5JTRTD67YGMR3IOTSWALXZANCNFSM4UEHR3ZA .

There seems few comments need to be fixed, Can you please resolve the comments (Click on "resolve conversation") you have already fixed.

Hi Doug,
Sorry for bugging you, I am new to Git can you please provide me what other
points are left to fix also how to find resolve button on comments.
waiting for your reply...
regards,
M.i
On Thu, Dec 24, 2020 at 6:53 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

Hi Doug, Sorry for the delay, I was busy with other things, I have done
all the changes in suggested by you and your colleague. Can you please
review and let me know what is next step to proceed further. waiting for
your reply... Regards, M.i
… <#m_1958340733201656667_>
On Tue, Dec 22, 2020 at 9:39 AM Doug Elliott @.*> wrote: @.** approved
this pull request. — You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#584 (review)
https://github.com/microsoft/PowerPlatformConnectors/pull/584#pullrequestreview-556806881>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDU5JTRTD67YGMR3IOTSWALXZANCNFSM4UEHR3ZA
.
There seems few comments need to be fixed, Can you please resolve the
comments (Click on "resolve conversation") you have already fixed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-750694967,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDV3KPRKB3F3G5SRKXLSWKJZVANCNFSM4UEHR3ZA
.

Hi Doug,
Sorry for bugging you, I am new to Git can you please provide me what other
points are left to fix also how to find resolve button on comments.
waiting for your reply...
regards,
M.i
On Thu, Dec 24, 2020 at 6:53 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

Hi Doug, Sorry for the delay, I was busy with other things, I have done
all the changes in suggested by you and your colleague. Can you please
review and let me know what is next step to proceed further. waiting for
your reply... Regards, M.i
… <#m_1958340733201656667_>
On Tue, Dec 22, 2020 at 9:39 AM Doug Elliott @.*> wrote: @.** approved
this pull request. — You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#584 (review)
https://github.com/microsoft/PowerPlatformConnectors/pull/584#pullrequestreview-556806881>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDU5JTRTD67YGMR3IOTSWALXZANCNFSM4UEHR3ZA
.
There seems few comments need to be fixed, Can you please resolve the
comments (Click on "resolve conversation") you have already fixed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-750694967,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDV3KPRKB3F3G5SRKXLSWKJZVANCNFSM4UEHR3ZA
.

@Data247logic I've gone ahead and resolved the comments that seem to have been addressed. So all the pending comments left by Srikanth and myself should be addressed in another commit. Please let us know if there are any questions about the feedback.

@Data247logic I've gone ahead and resolved the comments that seem to have been addressed. So all the pending comments left by Srikanth and myself should be addressed in another commit. Please let us know if there are any questions about the feedback.

Hi Doug,
All the comments are resolved and fixed, please review and let me know what
will be the next step in connector release. when it will be released on the
platform for users to use.
waiting for your reply..
regards,
M.I
On Wed, Jan 6, 2021 at 10:55 AM Doug Elliott<EMAIL_ADDRESS>wrote:

@Data247logic https://github.com/Data247logic I've gone ahead and
resolved the comments that seem to have been addressed. So all the pending
comments left by Srikanth and myself should be addressed in another commit.
Please let us know if there are any questions about the feedback.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-755087139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDTRKCNSK34WLCD6YNLSYPX6DANCNFSM4UEHR3ZA
.

Hi Doug,
All the comments are resolved and fixed, please review and let me know what
will be the next step in connector release. when it will be released on the
platform for users to use.
waiting for your reply..
regards,
M.I
On Wed, Jan 6, 2021 at 10:55 AM Doug Elliott<EMAIL_ADDRESS>wrote:

@Data247logic https://github.com/Data247logic I've gone ahead and
resolved the comments that seem to have been addressed. So all the pending
comments left by Srikanth and myself should be addressed in another commit.
Please let us know if there are any questions about the feedback.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-755087139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDTRKCNSK34WLCD6YNLSYPX6DANCNFSM4UEHR3ZA
.

Hi Doug,
Did you get my previous email?
can you please proceed further with the approval so that my connector can
be online in the marketplace.
waiting for your reply...
regards,
M.i
On Wed, Jan 6, 2021 at 1:16 PM Mohammad Istiyaq<EMAIL_ADDRESS>wrote:

Hi Doug,
All the comments are resolved and fixed, please review and let me know
what will be the next step in connector release. when it will be released
on the platform for users to use.
waiting for your reply..
regards,
M.I
On Wed, Jan 6, 2021 at 10:55 AM Doug Elliott<EMAIL_ADDRESS>wrote:

@Data247logic https://github.com/Data247logic I've gone ahead and
resolved the comments that seem to have been addressed. So all the pending
comments left by Srikanth and myself should be addressed in another commit.
Please let us know if there are any questions about the feedback.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-755087139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDTRKCNSK34WLCD6YNLSYPX6DANCNFSM4UEHR3ZA
.

Hi Doug,
Did you get my previous email?
can you please proceed further with the approval so that my connector can
be online in the marketplace.
waiting for your reply...
regards,
M.i
On Wed, Jan 6, 2021 at 1:16 PM Mohammad Istiyaq<EMAIL_ADDRESS>wrote:

Hi Doug,
All the comments are resolved and fixed, please review and let me know
what will be the next step in connector release. when it will be released
on the platform for users to use.
waiting for your reply..
regards,
M.I
On Wed, Jan 6, 2021 at 10:55 AM Doug Elliott<EMAIL_ADDRESS>wrote:

@Data247logic https://github.com/Data247logic I've gone ahead and
resolved the comments that seem to have been addressed. So all the pending
comments left by Srikanth and myself should be addressed in another commit.
Please let us know if there are any questions about the feedback.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-755087139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDTRKCNSK34WLCD6YNLSYPX6DANCNFSM4UEHR3ZA
.

@Data247logic I've already approved the PR, but it is now pending a review from my colleague, @sriyen-msft . He will provide another round of reviews on your changes soon, and will follow up with any further points of feedback.

@Data247logic I've already approved the PR, but it is now pending a review from my colleague, @sriyen-msft . He will provide another round of reviews on your changes soon, and will follow up with any further points of feedback.

Hi,
I am not getting you, can you please give me one example so that i can fix
it and finish this off.
waiting for your reply...
regards,
M.i
On Fri, Jan 15, 2021 at 5:41 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

@sriyen-msft requested changes on this pull request.
In certified-connectors/Data247logic/apiDefinition.swagger.json
https://github.com/microsoft/PowerPlatformConnectors/pull/584#discussion_r557766377
:

"contact":{

"name":"Data247 Support",

"url":"https://support.data247.com/"

}
},
"host": "api.data247.com",
"basePath": "/",
"schemes": [
"https"
],
"paths": {
"/v3.0": {},
"/v3.0/MT/": {

 "get": {

   "responses": {

     "default": {

Please replace ALL the "default" responses with expected status codes,
otherwise users may see errors about incorrect schema instead of real error
responses from your service in OpenAPI mode.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#pullrequestreview-568710357,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDTE5RZLSUWHZM2M2MDSZ6B2FANCNFSM4UEHR3ZA
.

Hi,
I am not getting you, can you please give me one example so that i can fix
it and finish this off.
waiting for your reply...
regards,
M.i
On Fri, Jan 15, 2021 at 5:41 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

@sriyen-msft requested changes on this pull request.
In certified-connectors/Data247logic/apiDefinition.swagger.json
https://github.com/microsoft/PowerPlatformConnectors/pull/584#discussion_r557766377
:

"contact":{

"name":"Data247 Support",

"url":"https://support.data247.com/"

}
},
"host": "api.data247.com",
"basePath": "/",
"schemes": [
"https"
],
"paths": {
"/v3.0": {},
"/v3.0/MT/": {

 "get": {

   "responses": {

     "default": {

Please replace ALL the "default" responses with expected status codes,
otherwise users may see errors about incorrect schema instead of real error
responses from your service in OpenAPI mode.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#pullrequestreview-568710357,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDTE5RZLSUWHZM2M2MDSZ6B2FANCNFSM4UEHR3ZA
.

Hi Doug,
I have updated the response, so please review and proceed further for
approval so it will be live on Marketplace.
waiting for your reply....
regards,
M.i
On Thu, Jan 21, 2021 at 5:48 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

Hi, I am not getting you, can you please give me one example so that i can
fix it and finish this off. waiting for your reply... regards, M.i
… <#m_2321327043759940115_>
On Fri, Jan 15, 2021 at 5:41 AM Srikanth Yenagandhula < @.*> wrote: @.**
requested changes on this pull request. ------------------------------ In
certified-connectors/Data247logic/apiDefinition.swagger.json <#584
(comment)
https://github.com/microsoft/PowerPlatformConnectors/pull/584#discussion_r557766377>
: > + "contact":{ + "name":"Data247 Support", + "url":"
https://support.data247.com/" + } + }, + "host": "api.data247.com", +
"basePath": "/", + "schemes": [ + "https" + ], + "paths": { + "/v3.0": {},

"/v3.0/MT/": { + "get": { + "responses": { + "default": { Please replace
ALL the "default" responses with expected status codes, otherwise users
may see errors about incorrect schema instead of real error responses from
your service in OpenAPI mode. — You are receiving this because you were
mentioned. Reply to this email directly, view it on GitHub <#584 (review)
https://github.com/microsoft/PowerPlatformConnectors/pull/584#pullrequestreview-568710357>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDTE5RZLSUWHZM2M2MDSZ6B2FANCNFSM4UEHR3ZA
.

Example - 365 Training
https://github.com/microsoft/PowerPlatformConnectors/blob/e953397c852a5afd6bc9f16740f5e7c958dec250/certified-connectors/365Training/apiDefinition.swagger.json#L44
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-764061751,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDWQZWJBSROQNUQ67D3S25XF7ANCNFSM4UEHR3ZA
.

Hi Doug,
I have updated the response, so please review and proceed further for
approval so it will be live on Marketplace.
waiting for your reply....
regards,
M.i
On Thu, Jan 21, 2021 at 5:48 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

Hi, I am not getting you, can you please give me one example so that i can
fix it and finish this off. waiting for your reply... regards, M.i
… <#m_2321327043759940115_>
On Fri, Jan 15, 2021 at 5:41 AM Srikanth Yenagandhula < @.*> wrote: @.**
requested changes on this pull request. ------------------------------ In
certified-connectors/Data247logic/apiDefinition.swagger.json <#584
(comment)
https://github.com/microsoft/PowerPlatformConnectors/pull/584#discussion_r557766377>
: > + "contact":{ + "name":"Data247 Support", + "url":"
https://support.data247.com/" + } + }, + "host": "api.data247.com", +
"basePath": "/", + "schemes": [ + "https" + ], + "paths": { + "/v3.0": {},

"/v3.0/MT/": { + "get": { + "responses": { + "default": { Please replace
ALL the "default" responses with expected status codes, otherwise users
may see errors about incorrect schema instead of real error responses from
your service in OpenAPI mode. — You are receiving this because you were
mentioned. Reply to this email directly, view it on GitHub <#584 (review)
https://github.com/microsoft/PowerPlatformConnectors/pull/584#pullrequestreview-568710357>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDTE5RZLSUWHZM2M2MDSZ6B2FANCNFSM4UEHR3ZA
.

Example - 365 Training
https://github.com/microsoft/PowerPlatformConnectors/blob/e953397c852a5afd6bc9f16740f5e7c958dec250/certified-connectors/365Training/apiDefinition.swagger.json#L44
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-764061751,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDWQZWJBSROQNUQ67D3S25XF7ANCNFSM4UEHR3ZA
.

@sriyen-msft Please re-review the changes that @Data247logic has made. Thanks!

@sriyen-msft Please re-review the changes that @Data247logic has made. Thanks!

@Data247logic Can you please remove extra files added to this PR

@Data247logic Can you please remove extra files added to this PR

Hi Doug,
I have removed icon.png, what else you need me to remove from PR ?
please let me know as soon as possible so that we can finish this.
waiting for your reply....
regards,
M.i
On Thu, Jan 28, 2021 at 7:56 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

@Data247logic https://github.com/Data247logic Can you please remove
extra files added to this PR
[image: image]
https://user-images.githubusercontent.com/56276394/106081063-20d00d00-60cd-11eb-9580-8303baaef5de.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-768751440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDQBUHSKK3NO5QZ3YG3S4DDNLANCNFSM4UEHR3ZA
.

Hi Doug,
I have removed icon.png, what else you need me to remove from PR ?
please let me know as soon as possible so that we can finish this.
waiting for your reply....
regards,
M.i
On Thu, Jan 28, 2021 at 7:56 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

@Data247logic https://github.com/Data247logic Can you please remove
extra files added to this PR
[image: image]
https://user-images.githubusercontent.com/56276394/106081063-20d00d00-60cd-11eb-9580-8303baaef5de.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-768751440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDQBUHSKK3NO5QZ3YG3S4DDNLANCNFSM4UEHR3ZA
.

Hi Doug,
Can you guys please close this and approve it?
its been a very long time for approval, please approve and let me know what
is next step.
waiting for your reply...
regards,
M.i
On Thu, Jan 28, 2021 at 2:23 PM Mohammad Istiyaq<EMAIL_ADDRESS>wrote:

Hi Doug,
I have removed icon.png, what else you need me to remove from PR ?
please let me know as soon as possible so that we can finish this.
waiting for your reply....
regards,
M.i
On Thu, Jan 28, 2021 at 7:56 AM Srikanth Yenagandhula <
<EMAIL_ADDRESS>wrote:

@Data247logic https://github.com/Data247logic Can you please remove
extra files added to this PR
[image: image]
https://user-images.githubusercontent.com/56276394/106081063-20d00d00-60cd-11eb-9580-8303baaef5de.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerPlatformConnectors/pull/584#issuecomment-768751440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLGTDQBUHSKK3NO5QZ3YG3S4DDNLANCNFSM4UEHR3ZA
.

@Data247logic I am not sure whether you are familiar or not with Github and PR pipeline, But please make sure that there is no "Swagger and Change Validation" errors in "checks" section of the PR whenever you push any commit. There are 10+ errors flagged, please fix them.
https://github.com/microsoft/PowerPlatformConnectors/pull/584/checks
##[error]The 'summary' value must end with alphanumeric character. ValuePath: /paths/~1v3.0~1MT~1/get/summary
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1MT~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1CU~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1CT~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1CI~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1VE~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1VA~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1VP~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AP~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AE~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1APR~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AER~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AR~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AN~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AG~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AZ~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AZR~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1GI~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1DC~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1TPC~1/get/responses/default

@Data247logic Checking in on the feedback that Srikanth provided above. Do you have any questions about that?


Peel off a ConnectionConfig value into SocketConfig

This split is hairy and seems error-prone. This is one reason I'm heavily considering just moving the whole ConnectionConfig into a SocketConfig. See https://github.com/ethereum/utp/issues/38

Closing. If we're going to move a config value at all, I expect it to be in the direction of #93 instead.


sti build hangs

I am using sti from the command line and in most cases, I notice that it "hungs".
When I am using log level 3 I see that the build output always hungs at exactly the same line.
What is strange though is that when I check the docker logs, I can see that the assemble script has successfully finished and also that the container has exited gracefully. The target image of course is never created.
The last couple of days I've made so many attempts and only two of them were successful (I haven't done anything different).

Can you give us steps to recreate?  what STI image, what STI scripts, what commit level of STI, etc?
(also what docker version)

I've been using the https://github.com/fabric8io/base-sti base image. The sti scripts are part of the image and they are referenced using their github url.
My docker is at 1.4.1 and I'll try to upgrade and see if it makes any difference.
Here's an example of how I use the command:
sti build https://github.com/fabric8io/example-camel-cdi.git fabric8/base-sti fabric8/camel-example --loglevel=3

yup, I was able to reproduce this just running your sti command.  and I do see the container has exited after running assemble successfully.
Given that the sti output hangs partway through the assemble script output, i'm guessing we're screwing up/overfilling a buffer somewhere.  @soltysh can you take a look?

The behaviour that I see makes me feel that the issue is related with the readers of the containers output and error. It seems like on of them stops reading and fails to close preventing the method to return? (limited understanding of golang here).

in the meantime, could you edit your assemble script to redirect the maven output to /dev/null?  that might let you make progress...

It does seem to make a difference.

Looking...

Using the latest master, I still have the same issue.

@iocanel can you please check this once more. I just did a fresh build of STI (this revision) and the command:
sti build https://github.com/fabric8io/example-camel-cdi.git fabric8/base-sti fabric8/camel-example --loglevel=3

worked without any problem resulting in fabric8/camel-example image. The only problem I hit was running that result image ended in:
$ docker run fabric8/camel-example
/tmp/scripts/run: line 3: deploy-and-start: command not found

But that is not a STI problem from what I see. If you're still hitting the problem, please include the entire output of the build here (with --loglevel=5), I'll try to have a closer look at it.

Will check and get back to you.

I'm seeing this too. It feels like the build is stuck on downloading some Maven artifacts in my case, but in fact, the build container already exited with status 0 and new image was created as it should. My example command is:
$ sti build --loglevel=5 --forcePull=false https://github.com/goldmann/openshift-examples --contextDir=spring-eap6-quickstart 8fffd6ce363a test-jee-app

Where the 8fffd6ce363a image is a custom EAP image, but probably the wildfly8-centos image could be used too.
One note: this does not happen every time. If I re-run the command, there is a high chance that I'll get the full output.

Any news on this? Since we added STI to our CI this is now failing our builds.

https://github.com/openshift/source-to-image/pull/160
@goldmann this might fix you (--assebleOutput=false)

@mfojtik Well, this is more like a workaround :) Is there a way to redirect the output to somewhere. We would still need the logs for further investigation.

@goldmann sorry but I can't still reproduce it and I'm still investigating the the source of the problem.

@soltysh Fair enough, update this issues if you have something. Thanks!

@goldmann still an issue?

Haven't seen it in a while.

closing, feel free to reopen if it recurs.

After we upgraded to ac0b2512c9f933afa985b056a7f3cbce1942cacb, there is no output at all on our CI and the STI process is waiting (hanging) forever for the container, which exited cleanly.
Last lines of the container log:
Downloading: https://maven.repository.redhat.com/techpreview/all/org/apache/apache/7/apache-7.pom
Downloading: https://repository.jboss.org/nexus/content/groups/public/org/apache/apache/7/apache-7.pom
[WARNING] Checksum validation failed, no checksums available from the repository for https://repository.jboss.org/nexus/content/groups/public/org/apache/apache/7/apache-7.pom
Downloaded: https://repository.jboss.org/nexus/content/groups/public/org/apache/apache/7/apache-7.pom (15 KB at 7.4 KB/sec)
Downloading: https://maven.repository.redhat.com/techpreview/all/org/apache/maven/plugins/maven-clean-plugin/2.4.1/maven-clean-plugin-2.4.1.jar
Downloading: https://repository.jboss.org/nexus/content/groups/public/org/apache/maven/plugins/maven-clean-plugin/2.4.1/maven-clean-plugin-2.4.1.jar
[WARNING] Checksum validation failed, no checksums available from the repository for https://repository.jboss.org/nexus/content/groups/public/org/apache/maven/plugins/maven-clean-plugin/2.4.1/maven-clean-plugin-2.4.1.jar
Downloaded: https://repository.jboss.org/nexus/content/groups/public/org/apache/maven/plugins/maven-clean-plugin/2.4.1/maven-clean-plugin-2.4.1.jar (23 KB at 13.5 KB/sec)
[INFO]
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ spring-eap6-quickstart ---
[INFO] Deleting /home/jboss/source/target
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.249s
[INFO] Finished at: Mon May 18 14:02:34 EDT 2015
[INFO] Final Memory: 17M/903M
[INFO] ------------------------------------------------------------------------
Copying all WAR and EAR artifacts from /home/jboss/source/deployments directory into /opt/eap/standalone/deployments for later deployment...
'/home/jboss/source/deployments/ROOT.war' -> '/opt/eap/standalone/deployments/ROOT.war'

@goldmann is https://github.com/openshift/source-to-image/issues/149#issuecomment-82372044 still a reproducer for this?

Just to let all know - we talked with @mfojtik and the issue is probably with the goroutines and wait when reading the container output.


CRRAutility gives ZeroDivisionError

Example:
> CRRAutility(0, 3)
---------------------------------------------------------------------------
ZeroDivisionError                         Traceback (most recent call last)
Input In [7], in <cell line: 1>()
----> 1 CRRAutility(0, 3)

File ~/projects/HARK/HARK/utilities.py:141, in CRRAutility(c, gam)
    139     return np.log(c)
    140 else:
--> 141     return c ** (1.0 - gam) / (1.0 - gam)

ZeroDivisionError: 0.0 cannot be raised to a negative power

I would expect an answer of -inf.
Could this be added as part of #1168 ?

The function behaves as expected if you pass an array that includes zeros
in the first argument. It comes up here because 1.0 / 0.0 --> division by
zero error in base Python, but np.array(1.0) / 0.0 --> np.array(np.inf) in
Numpy. The solution involves casting to an array if it's not already, and
also unpacking back to a single number. I.e. np.inf is not the same thing
as np.array(np.inf).
On Fri, Nov 18, 2022 at 4:18 PM Sebastian Benthall @.***>
wrote:

Example:

CRRAutility(0, 3)

ZeroDivisionError                         Traceback (most recent call last)
Input In [7], in <cell line: 1>()
----> 1 CRRAutility(0, 3)
File ~/projects/HARK/HARK/utilities.py:141, in CRRAutility(c, gam)
139     return np.log(c)
140 else:
--> 141     return c ** (1.0 - gam) / (1.0 - gam)
ZeroDivisionError: 0.0 cannot be raised to a negative power
I would expect an answer of -inf.
Could this be added as part of #1168
https://github.com/econ-ark/HARK/pull/1168 ?
—
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/1188, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKRAFNVXCHQ6LVYGWN55MDWI7XBXANCNFSM6AAAAAASE4NSRU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Just wanted to say I've run into this too, and that it permeates not only CRRAutility but also its derivatives.
Pretty easy to deal with, but it would be nice if it worked out of the box.
I think even with the numpy solution it throws up a warning. The warning is caught by this code in HARK.core whenever this comes up in the solution of a model
https://github.com/econ-ark/HARK/blob/cfaaf25ff4e23721473dbd0bee3bc2b78d3782a1/HARK/core.py#L406-L408
It might be nice to have this dealt with at the source functions themselves, for cases when they are used outside of solve?


[swift-3.0] Xcodeproj bug fixes

These are Xcode project generation related fixes picked for Swift 3 branch
rdar://problem/28998147&28998196&28998234&28998314&28998438&29022975

@swift-ci please test

@swift-ci please test linux

@swift-ci please test OS X

@swift-ci please test

@swift-ci please test

I built the linux swift-3.0 compiler locally and tested this patch with that
will wait for OS X CI to return

@swift-ci please test os x

OSX also fails due to unrelated reasons, tested locally and will go ahead and merge


Feature request - Adding theme with UI to add/manage and switch current theme

It would be nice if we can add .css theme into custom/gogs/conf
And having an UI to select and apply the current theme.

Duplicated to https://github.com/gogits/gogs/issues/1126.


How to add column to dataframe

I know I can use rconcat with a frame, but could we provide simpler solution?

You probably want joinS ...


Created initial, read-only newsletters web interface

created acmcsuf.com/newsletters.xml
created web interface for acmcsuf.com/newsletters using acmcsuf.com/newsletters.json
created web interface for each blog post

In order for the /newsletters pages to be rendered, a link to it must exist somewhere on the website. For now, maybe we can put a link to the /newsletters page on the footer next to the GitHub icon.


Back to top link improvements

This resolves the majority of issues raised by the recent accessibility audit relating to the back to top link, with only an investigation into NVDA's anchor link remaining.
https://github.com/alphagov/govuk-design-system/issues/899#issuecomment-541630246
Move the back to top link after the main content
This means that anyone using a keyboard can access the back to top link
if they're navigating to the bottom, whereas perviously the link was
just after the navigation.
Moving this forces us to have to change our approach having the back to top link follow the user.
We cannot use position: sticky, so have to make more use of
intersection observers and implement the desired behaviour ourself.
Move the link to the bottom of the page visually

mirrors the source order better
users with motor impairments this may be easier to access as it's
closer to the bottom of the page.
fallback for older browsers and JavaScript being disabled is the link at the bottom of the page.

Todo

[ ] Test in NVDA
[ ] Test cross browsers
[ ] Add before and after demonstrations

You can preview this change here:
Built with commit 504f2de6d1dfe41f614b450f231bcb5ee601f260
https://deploy-preview-1064--govuk-design-system-preview.netlify.com

How did the NVDA testing go?

I still need to do this but I'm assuming it's not something easy to fix given we're using standard anchor linking

I find it a bit weird when tabbing through the page that you can see the back to top link but you can't tab to it.

This is the same behaviour as it currently works but instead of having to top to the top of the page, you tab to the bottom.

I cannot reproduce the issues with NVDA, focus is taken back to the the top of the page 🤔