perf: don't inject new loggers in GetVolumes

Fixes #N/A
Description
This PR addresses a performance issue brought forward here. Based on the provided profile image in this comment we can see that GetVolumes is using a disproportional amount of CPU time (204 / 586 seconds).
The culprit line:
ctx = logging.WithLogger(ctx, logging.FromContext(ctx).With("pod", pod.Name))

At most scales this is negligible, however, for each scheduling loop this new logger with be injected n*p times, where n is the number of existing nodes on the cluster and p is the number of pods being considered in a given scheduling loop. Deferring the With calls to the log site rather than injecting a new logger into the context does reduce code maintainability, but is worth the performance tradeoff in this case.
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-2 of 7 (71.43%)  changed or added relevant lines in 1 file are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.05%) to 81.022%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/scheduling/volumeusage.go
5
7
71.43%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/disruption/drift.go
2
90.63%

pkg/test/expectations/expectations.go
2
95.96%

pkg/utils/atomic/lazy.go
2
87.88%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
8197

Relevant Lines:
10117

💛  - Coveralls


added  Install Pods (Offline only)  and the mac gem_path default value is /usr/local/bin also have update

added
Install Pods (Offline only)
to solve   which  country  visited  github  too  slow  .
when  pod  install

To use "Offline Mode", select "Update and Install Offline Only" from the menu.


In the nbdev1_migration tutorial, Final steps section, running nbdev_preview first and nbdev_prepare second doesn't work

I tried to follow the tutorial steps for migrating my repo. In my case, I had to run first nbdev_prepare first and nbdev_preview second, in order to have the preview after the new docs are built. If I run first nbdev_preview, it doesn't succeed.

What are the errors that you get?  Can you please share those?

You're quite right - the package needs to be exported before the docs can be previewed. I'll update the tutorial with the correct workflow.


Allow PactDslJsonArray to be at the root of a response

Allow PactDslJsonArray to be at the root of a response

Hi, this is my first pull request to this project. I have not changed anything that would have affected the building of the scala modules. Any advice on how to rectify this?

Awesome, thanks for that!


Map objects are not being handled properly during conversion from typescript to google apps script

(Note: Non-breaking issues are likely not to be prioritized. Please consider a PR in addition to your issue)

Expected Behavior
When pushing a project written in TypeScript, it would be expected that a for...of loop applied on a map iterator (such as the return of map.entries() and map.keys()) would result on an executable loop on google apps script.
Also, the piece of code [...map_object.entries()] should return an array that contains sub-arrays filled with key-value pairs (like [[key1, value1], [key2, value2], ... , [keyN, valueN]]).
Actual Behavior
When pushing a project, for...of loops applied to map iterators have their code replaced to non-executable loops (like for (var _i = 0, _a = map_object.entries(); _i < _a.length; _i++)
Also, the convertion does not handle the piece of code [...map_object.entries()] properly, since it's converted to a piece of code that returns an empty array (__spreadArray([], data_map.entries(), true)).
Steps to Reproduce the Problem

On a GAS project, add a .ts file.
Create a map object, such as const map_object = new Map();
Add an entry to the map object, such as map_object.set("key1", "value1");.
Write a for...of loop such as for (const entry of map_object.entries()).
Inside the loop, write Logger.log(entry);.
Outside the loop, add the line Logger.log([...map_object.entries()]);.
Push the project to GAS.
Check and run the code on GAS and check the log.

Specifications

Node version (node -v): v16.14.0
Version (clasp -v): 2.4.1
OS (Mac/Linux/Windows): Windows

I have also encountered this issue
I don't know why clasp can't just compile to ES6. This issue can easily be mitigated

The workaround is to use typescript and add this to the tsconfig.json:
{
    "compilerOptions": {
      "lib": ["esnext"],
      "experimentalDecorators": true,
      "target": "ES2015"
    }
}


Update AWS_network_activities.json (typo fix)

Typo fix.

Thanks for your comment.
We changed all the typos.


No input box to create new file in Explorer

Open a file like lua/language-cofiguration.json
Reload the workbench
Try to create a file in the root by collapsing all and clicking new file

The input box is at the layer of the focused file/folder. When you collapse all, it keeps focus on files and folders.

Is CollapseAction deprecated in favour of CollapseAction2?

Hello, sorry if this is a bit off-topic but my issue #68126 was closed as a duplicate of this one, and I wasn't told if it was because the underlying issue was determined to be related? But I experienced entirely different behaviour then what is being called out here I think.
Can anyone have a look?

The issue here is that the tree keps the item focused even when it is collapsed. Which makes sense.
However here we need to resolveTo to the focued item. For that we need tree api similar to what is needed for https://github.com/Microsoft/vscode/issues/68627

Fixed by @joaomoreno


KDE game KBounce

Hi,
is there working solution to package KDE games to appimage?
I tried many combinations (xenial, jessie, wheezy) (bintray,union) but no luck.
For example: KBounce (https://www.kde.org/applications/games/kbounce/)
app: KBounce
union: true

ingredients:
  package: kbounce
  dist: wheezy
  sources:
    - deb http://ftp.de.debian.org/debian/ wheezy main contrib

It launches but crashes if pressed start.
ERROR: ld.so: object '/home/user/Public/KBounce.AppDir/libunionpreload.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
[0xb968a8] main services discovery error: no suitable services discovery module
kbounce(1172) KXMLGUIClient::loadStandardsXmlFile: ui/ui_standards.rc not found in ("/home/user/.kde/share/config/", "/etc/kde4/", "/usr/share/kde4/config/")
kbounce(1172) KXMLGUIClient::setXMLFile: cannot find .rc file "kbounceui.rc" for component "kbounce"
kbounce(1172)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:
Segmentation fault (core dumped)

Have you tried binpatch: true instead of union: true yet?

Tried now but it's not working.
/bin/bash: symbol lookup error: /lib/x86_64-linux-gnu/libncurses.so.5: undefined symbol: _nc_putchar

looks better... try trusty please.

Works with trusty and union. Thank You for your time.
Recipe:
app: KBounce
union: true

ingredients:
  package: kbounce
  dist: trusty
  sources:
   - deb http://de.archive.ubuntu.com/ubuntu/ trusty main universe

How large is it? AppImages done in this way are not optimized for size, since all of Qt and many KDE libs are bundled; more than is actually needed for just this app. So if you want to publish this officially, let me know and I'll have a look at using linuxdeployqt.

43M KBounce-x86_64.AppImage
doesn't matter size for me, I just dont like installing bunch of KDE libs on GTK system.
There's just one problem, menu bar is not showing all properties, it just shows "No Text" as button.

Can you attach a screenshot please?

Now that is strange, never seen that. Do you get any error messages when running the AppImage from the command line?

zenity, kdialog, Xdialog missing. Skipping /home/user/Public/KBounce.AppDir/usr/bin/kbounce.wrapper.
kbounce(1926)/kdeui (KIconLoader): Error: standard icon theme "oxygen" not found!
kbounce(1926) KXMLGUIClient::loadStandardsXmlFile: ui/ui_standards.rc not found in ("/home/user/.kde/share/config/", "/etc/kde4/", "/usr/share/kde4/config/")
kbounce(1926): Couldn't start knotify from knotify4.desktop:  "KLauncher could not be reached via D-Bus. Error when calling start_service_by_desktop_path: The name org.kde.klauncher was not provided by any .service files"
kbounce(1926)/kdeui (KNotification) KNotification::slotReceivedIdError: Error while contacting notify daemon "The name org.kde.knotify was not provided by any .service files"
kbounce(1926)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:
kbounce(1926)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:

Not entirely sure, but this looks unrelated to me. @ScarlettGatelyClark, have you ever seem something like this?

Don't know if it has something to do with that but to run game I removed -caption %c from kbounce.desktop and symlinked kbounce binary (from /usr/games/ to /usr/bin) otherwise it would not start.
full line from kbounce.desktop:
Exec=kbounce.wrapper -caption %c


Netsec and Appsec Courses

I'm sure there have to be at least a few great courses in intro to netsec and appsec that would be invaluable for those looking to get into development.

Hey, @Nolski !
Do you have some courses in mind?

Hi @Nolski & @ericdouglas I found this one maybe it's along the lines of what you are looking for...
https://www.futurelearn.com/courses/introduction-to-cyber-security

@ericdouglas This is a bit more of a tutorial but I feel like the Intro to Metasploit also provides a good foundation in netsec. https://www.offensive-security.com/metasploit-unleashed/introduction/ Although I'm not super advanced in this field so I'm sure someone else may have a better idea of what to put.

Closing this issue. @waterlooSunset thanks for that suggestion, I'll add this course to our curriculum. :smile:


feat: improved particle api

Improves the Particle API by giving each particle with custom data its own class with well named methods to specify the data.
Removes the concept of supplying harmful particle data.
Example API change
Particle.BLOCK.withData(new BlockParticleData(Block.DIRT)) -> Particle.BLOCK.withBlock(Block.DIRT)

Superseded by #2166


Adds micro-benchmark performance tests.

@trxcllnt please use 3.0 which is the most current straight from GitHub instead of 2.5 which will not give you accurate results.

@mattpodwysocki I'm testing against the latest version in npm because that's what the public uses. I'm happy to bump the version when 3.0 is published.

@trxcllnt the actual .spec.js files need to be updated, they still are trying to go to perf/flatmap rather than perf/macro/flatmap


Getting log of sub-module?

Is it possible to get sub-module(s) log?

@okian Yes. In order to get a Submodule, you need to get a Worktree.
It would be something like:
r, err := git.PlainOpen("path/to/repo")
w, err := r.Worktree()
s, err := w.Submodule("mysubmodule") // you can also iterate with Submodules()
sr, err := s.Repository()
// Now you have a regular *git.Repository instance for your submodule in the `sr` variable.


Update compatibility version

Spring Cloud Azure 4.0 is compatible with Spring Boot 2.5.x and 2.6.x and we'd like to use the Spring Boot BOM to test the compatibility. The ideal case is to test both [2.5.0, 2.5.latest] and [2.6.0, 2.6.latest], but due to current implementation, our pipeline stages are run serially instead of concurrently, for reaching a balance of time and test, we decide to only test the latest versions of both 2.5.x and 2.6.x.

LGTM BTW, is this pr related to #27528? missed in #27528, so create this pr?

Not exactly，#27528 is to fix java-core-ci, and this pr is to choose the version for our pipeline.


Tune ECDSA example by adding codegen-units=1 to guest Cargo.toml

I happened to be looking at the ECDSA example today, and tried out adding codegen-units=1 to the guest Cargo.toml.
Result was reducing 1.17M cycles to a little less than 1M. As a result, the proof is one segment and is about 20% faster.

Is it possible you were running different versions of the toolchain? We recently released a new 1.70 guest toolchain where we've seen similar improvements in cycle count.

Is it possible you were running different versions of the toolchain? We recently released a new 1.70 guest toolchain where we've seen similar improvements in cycle count.

In this comparison, the 1.17M vs <1M numbers come from just changing the codegen-units=1 line, keeping all else constant.


Fix userdata append header restrictions

Description
This PR fixes the userdata header restrictions on the APPEND operation:

Allow the second userdata not having a header
In case the second userdata does not have a header, it uses the first userdata header as its format type

Fixes: #7918
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10766

@blueorangutan test

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@nvazquez  do you mean the second userdata2 should not contain #cloud-config as header?
Userdata1
#cloud-config
chpasswd:
  list: |
    root:password
  expire: False

Userdata2
write_files:
- path: /root/CLOUD_INIT_WAS_HERE

I have tried deploying a vm with 2 userdata but it was not successfull

@nvazquez do you mean the second userdata2 should not contain #cloud-config as header?
Userdata1
#cloud-config
chpasswd:
  list: |
    root:password
  expire: False

Userdata2
write_files:
- path: /root/CLOUD_INIT_WAS_HERE

I have tried deploying a vm with 2 userdata but it was not successfull

@kiranchavala
I think the idea is

userdata1 must have a header
userdata2 header is optional. If userdata2 does not have a header, it will be considered to have the same header as userdata1

@blueorangutan package

@kiranchavala thanks for testing, that was an issue on the simple append in case the second cloudconfig userdata didn't have a header, I have fixed it, Can you verify on the latest packages? Building them now

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10781

[SF] Trillian test result (tid-11151)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47353 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9575-t11151-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_list_cpvm_vm
Failure
0.05
test_ssvm.py

test_04_cpvm_internals
Failure
0.05
test_ssvm.py

test_01_secure_vm_migration
Error
134.38
test_vm_life_cycle.py

test_01_secure_vm_migration
Error
134.38
test_vm_life_cycle.py

@nvazquez @weizhouapache
Thanks for confirming
During testing found that
Test case 1 > works fine

Register userdata 1

#cloud-config
chpasswd:
  list: |
    root:password
  expire: False

Register userdata 2

write_files:
- path: /root/CLOUD_INIT_WAS_HERE

attach userdata 1 to template with append
Deploy vm  with advance settings userdata 2

Test case 2 : The user data doesn't append if we deploy the vm with manual userdata

Test case 3 :  Works fine if the manual userdata contains the header #cloud-config

@kiranchavala I could reproduce the issue for case 2) - it is related to the parameter sent in the UI when it is not encoded, it encodes with an extra character that makes cloud-init fail as it doesn't recognize the character:

As a workaround, I encoded the userdata first and passed it on the deploy VM manual entry

Thanks @nvazquez works fine with api call
is it possible to remove the limitation from the UI ?

@kiranchavala I've added a fix for the UI encoding, by invoking encodeURI instead of encodeURIComponent for the base64 encoded userdata, this prevents encoding base64 special characters

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10836

@kiranchavala I've added a fix for the UI encoding, by invoking encodeURI instead of encodeURIComponent for the base64 encoded userdata, this prevents encoding base64 special characters

(in the example, before the fix the last == chars were encoded as well by the encodeURIComponent function)
cc @shwstppr @weizhouapache

@nvazquez I tested a main branch env. I passed the following userdata in the deploy VM form,
abcdefghijklmnop

In the DB I could see the following,
mysql> select * from user_vm where id=5\G;
*************************** 1. row ***************************
               id: 5
           iso_id: NULL
     display_name: NULL
        user_data: YWJjZGVmZ2hpamtsbW5vcA==
     user_data_id: NULL
user_data_details: NULL
update_parameters: 1
     user_vm_type: NULL
1 row in set (0.00 sec)

ERROR:
No query specified

So I'm not sure if it is an UI issue

@shwstppr can you retry with the userdata Kiran was using?


Geek Train Edit.

Still needs the ticket links.

btw, I ended up PRing via @adron-orange for this, we can close this PR.


chore: bdd-nh-1583873863 to 0.0.1

chore: Promote bdd-nh-1583873863 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


False positive for D417 (Part 2)

Opening a new issue here to track the follow-on comment I left here:
https://github.com/charliermarsh/ruff/issues/792#issuecomment-1347239427
Transcribing that comment:
Thanks for the fix for #792! However, I've noticed that the error returns if there is more than one argument present:
# test.py
def f(x, y, z):
    """Do f.

    Args:
        x: the value
        y: Another thing
        z: A final argument

    Returns: the value
    """
    return x

$ ruff --version
ruff 0.0.177
$ ruff --select D test.py
Found 1 error(s).
test.py:1:1: D417 Missing argument descriptions in the docstring: y, z
The error again goes away if the Returns block gets a newline. Insisting on a newline there is actually fine for me, but the confusing error message is still unfortunate.

Thank you, sorry to miss that one.

Going out in v0.0.189.


Added function to save best-fit model spectra.

Changes:

Added new sampler predicted_spectra in BBCompSep.
Assign sampler-specific names to output files (emcee, predicted_spectra etc.) to avoid overwriting.

@kwolz I just realised there are conflicts. Do you mind resolving them?


Star Citizen: startup and general issues

I'm just wanting to open a topic related to Star Citizen, for me it fails to launch and also the launcher cannot verify files. Is there a trick to getting this title working under wine and dxvk?
My copy which is a new download of 3.1.4 has a red box when starting saying there was a issue.
Software information
Star Citizen via Launcher
System information

GPU: 1080ti
Driver: 396.24.02
Wine version: 3.9 Staging (PBA+FO4+Taskbar fixes)
DXVK version: dxvk-master b78130d

Apitrace file(s)

none

Log files

d3d11.log: not yet
dxgi.log: not yet

No log, no info what "fails to launch" means, no anything - how are we supposed to help with this?
Also I'd argue that if the game doesn't even get to the stage of initializing D3D11, this is not the right bug tracker to report the bug on.

Sorry I was hoping to get input from people who have actually confirmed it even works.
I'll try to get more info.

Isn't Star Citizen still in development and supposed to become a Vulkan-based game anyway? ...
"Wine version: 3.9 Staging (PBA+FO4+Taskbar fixes)"
I'd drop the PBA patches. They're know to cause crashes and hangs and are only meant for OpenGL anyway. I'd start with an unpatched WINE version and see to it that the game gets past the launcher at least. When the launcher cannot even verify files then you're having some non-graphical issues you first need to sort out.

Yeah you might be right about PBA.
Anyway I got dotnet462 installed fine, seems it likes windows7 setting, win10 etc causes crashes. Odd.
None the less it still does not verify correctly so I will attempt to download the data pack again. At this point I'm only trying to get it to install correctly and unpack the game files which its not doing, until then I won't worry about recompiling wine.

Updated with RSI Launcher under windows, attempted to launch the game today under wine but it seems to stall with a zombie StarCitizen.exe. Not sure what the issue is, doesn't appear to be any information regarding this with 3.1.4.
And once again, no log outputs are given, so wine doesn't even get this to proper startup stage.

I think dotnet 4.5.2 needs better work in 64 bit . I debugged it a while ago .  Tried with https://github.com/aftokinito/scleaksp4kbuster but ended up with an install from Windows.

Yeah I don't think I can.
It should be disabled for now until we can find a way to launch the game.
(and no doubt some rendering issues will exist at that point)

@jarrard looks like it works with latest wine
https://appdb.winehq.org/objectManager.php?sClass=version&iId=36822&iTestingId=102763

https://appdb.winehq.org/objectManager.php?sClass=version&iId=37275
This person seems to have launched it two days ago? How do I do it? The lutris installer opens the launcher but the game crashes.


error

Problem encountered on https://dotnet.microsoft.com/learn/web/aspnet-hello-world-tutorial/modify
Operating System: windows
In what folder do I find Pages/Index.cshtml

@c234234 as the previous step "Create your app" hints: Pages directory is in the app directory you created.


nose in requirements-dev.txt

I don't know why nose is still in requirements-dev.txt
however it seems like will be removed
b438f67 (#2134)
and still mentioned in this file
https://github.com/boto/botocore/tree/develop/tests/unit/response_parsing

Hi @andriyor,
Thanks for bringing this to our attention. We transitioned to pytest and looks like this can still be cleaned up a bit.

This will be addressed in all of our packages after the following PRs are merged. We'll go ahead and resolve this, tracking progress in the related PRs.
#2634
boto/boto3#3186
boto/s3transfer#236
aws/aws-cli#6775


[PE-D][Tester C] Unexplained technical term

Initial reading of the UG, term default course confused, and using the course c/CS2100 command and saw no field show confused me initially. Got it after playing around with the application though.
It was not a major issue, but it would be nice if there is a table/index for words that might not be very common / specific to your Target Audience.

Labels: severity.Low type.DocumentationBug
original: LicongHuang/ped#5

Resolved in #123


Fix type of cast (IDFGH-8910)

It's not important to the code but in terms of documentation it's worth getting things like this right.

Thanks for your contribution.

sha=2d047f54399f8e4eb50cd3f50fa9ff4cc70f529f


feat(#245): include workflows to d0-numerical

In this pull I've added workflows count to d0-numerical.csv dataset, and simplified naming.
ref #245
History:

feat(#245): workflows count
feat(#245): formatting
feat(#245): names
feat(#245): numerical, scores

PR-Codex overview
This PR focuses on updating the data handling and processing logic in the sr-data project to align with new column names in CSV files, enhancing the workflow management and ensuring accurate data representation.
Detailed summary

Updated column names in to-score.csv to match new schema.
Changed references from pulls_count to pulls in test_pulls.py, pulls.py, and scores.py.
Adjusted scoring calculations in scores.py to use new column names.
Added copying of numerical.csv to the collection in data.sh.
Updated JSON mappings in ghminer.json to reflect new field names.
Enhanced workflow tracking in workflows.py by adding workflow counts.
Introduced a new test in test_workflows.py to validate workflow counts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here.

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 12min).


Friendly printing kubectl get pediaclusterlifecycle and clusterimport…

Friendly kubectl get pediaclusterlifecycle and kubectl get clusterimportlifecycle printing
Signed-off-by: qiuming520<EMAIL_ADDRESS>What type of PR is this?
/kind feature

What this PR does / why we need it:
Friendly kubectl get pediaclusterlifecycle and kubectl get clusterimportlifecycle printing
Which issue(s) this PR fixes:
Fixes #https://github.com/clusterpedia-io/clusterpedia/issues/292
before：

after：

Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/cc @Iceber


exportedService with submariner do not provide remote load balancing

Hi dear!
actual implementation are two k8s cluster based on RHOS with ACM for global management.
Both cluster are deployed with submariner.
After linking them, we exposed adn imported between cluster some services. behind services there are multiple pod serving same apps.
What we find out, is that if curl from a remote endpoint on a cluster HUB trying to a expoerted remote service the answer is always provided by the same POD. Locally, generating a request inside the remote cluster from a endpoint to the same service (correspongin to the exported one) the answer is served in a round robin scenario, does it happend to someone in that community? Thanks!

With OVNK as CNI, OVNK is responsible also for distributing traffic to local service between backend pods (using OpenFlow rules).
I want to verify how OVNK load balance the traffic between the different pods for local services regardless of Submariner.
So, could you please share the results of the following tests:
A. On clusterA,  run netshoot pod (with pod networking) on the same node that submariner gateway pod is running
*  Curl local service on clusterA
Repeat step A, but this time run the pod with hostnetworking
You can use [1] and [2] (download as ZIP and apply it to your cluster) to deploy netshoot daemonset with hostnet or podnet
[1]
https://gist.github.com/yboaron/82494eaff925e186f8dc3662f48f21b6
[2]
https://gist.github.com/yboaron/bd5f913e59a0fb307b877b29e33d88a5

@giacomotontini @amargheritini Any feedback for @yboaron?

Closing for now, if there's any feedback feel free to re-open or open a new issue.


Update setup-google-maps.md

Hopefully this fixed the graphics issue and xref - it appears fine in the preview but not in Pandev

Status
Ready/In Progress/In Hold (Reason for hold)
Related Issues
fixes: link to the issue
Description
The graphics/Xrefs appeared ok in GitHub but not in Pandev. Hopefully this fixes it.
Screenshots
Paste here any images that will help the reviewer

I fixed all the links and xrefs You can see the changes in the preview site. Please approve and then you/I can merge to master. Thanks


Feature/teamsize

Teamsize is determined in the request for creating the environment. if you have a teamsize of ex. 4, 4 virtual machines will be added to share the same lab (containers etc.)
For VPN, we are currently trying to create a new scheme where instead of creating a new interface per environment, we will create a new interface per team. Then in theory each team would be able to download 254 different VPN configs which will grant access to the same lab.
So nothing really needs to be done other than for the browser labs.


Added window.term.fit

After 1.5 release with having react component,  window.term.fit is not exposed and unable to fit after changing font size. For example, window.term.setOption("fontSize", 24) but window.term.fit is undefined . This PR is to add back fit method.

Merged to master.


hostname:port is parsed as protocol:hostname

when entering hostname:port into the address field it is parsed as protocol:hostname and rejected with Unsupported Protocol
I would prefer it if it parsed the protocol parameter only as such when it does not include dots
e.g. gemini.lehmann.cx:11965 gives Unsupported Protocol

great, works as expected


OpenID Connect Back-Channel Logout

I suggest to implement helpers for OpenID Connect Back-Channel Logout:

This specification defines a logout mechanism that uses direct back-channel communication between the OP and RPs being logged out; this differs from front-channel logout mechanisms, which communicate logout requests from the OP to RPs via the User Agent.

Related tickets #292 #500 #561

Hi @azmeuk. Is this something you're working on or just something that you're identifying as work that should be done?

Hi @azmeuk. Is this something you're working on, or is it just something you've identified that should be worked on in future?

I think this is an interesting feature and a good complement of #500. The combination of both specs would allow a user disconnection from one client to disconnect for all the other clients. I have implemented #500 directly in Canaille but not this spec yet. Anyways the spec logic is better implement here in authlib so it can benefit everyone.


Running into an Error

Hi,
I am running into following error.
Are you able to help me with?
/Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:430:in `visit_Psych_Nodes_Alias': Unknown alias: defaults (Psych::BadAlias)
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:345:in `block in revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each_slice'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:167:in `visit_Psych_Nodes_Mapping'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:345:in `block in revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each_slice'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:167:in `visit_Psych_Nodes_Mapping'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:345:in `block in revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each_slice'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:167:in `visit_Psych_Nodes_Mapping'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:318:in `visit_Psych_Nodes_Document'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:335:in `safe_load'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:370:in `load'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:671:in `block in load_file'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:670:in `open'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:670:in `load_file'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/configuration/defaults.rb:27:in `load_file'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/configuration/defaults.rb:21:in `load_defaults'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/configuration/defaults.rb:16:in `block in included'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/static_file/convertible.rb:18:in `convert'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/static_file/convertible.rb:14:in `convertible?'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/static_graphic_file.rb:13:in `generable?'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/hooks.rb:11:in `block (2 levels) in <top (required)>'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/hooks.rb:9:in `each'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/hooks.rb:9:in `block in <top (required)>'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/hooks.rb:103:in `block in trigger'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/hooks.rb:102:in `each'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/hooks.rb:102:in `trigger'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:38:in `initialize'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/commands/build.rb:30:in `new'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/commands/build.rb:30:in `process'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `block in process_with_graceful_fail'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `each'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `process_with_graceful_fail'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/commands/serve.rb:86:in `block (2 levels) in init_with_program'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `block in execute'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `each'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `execute'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary/program.rb:44:in `go'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary.rb:21:in `program'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/exe/jekyll:15:in `<top (required)>'
	from /Users/tgermer/.gem/ruby/3.1.0/bin/jekyll:25:in `load'
	from /Users/tgermer/.gem/ruby/3.1.0/bin/jekyll:25:in `<top (required)>'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:58:in `load'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:58:in `kernel_load'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:23:in `run'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:484:in `exec'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:31:in `dispatch'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:25:in `start'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/gems/3.1.0/gems/bundler-2.3.5/exe/bundle:48:in `block in <top (required)>'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/friendly_errors.rb:103:in `with_friendly_errors'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/gems/3.1.0/gems/bundler-2.3.5/exe/bundle:36:in `<top (required)>'
	from /Users/tgermer/.gem/ruby/3.1.0/bin/bundle:25:in `load'
	from /Users/tgermer/.gem/ruby/3.1.0/bin/bundle:25:in `<main>'

Thank you very much.
Tristan

Hey @tgermer. Thanks for reporting this. Apparently, it's a change in the library Pysch v4 that is causing the issue, and ruby 3.1 has updated the library to 4.0.3.
I'll try to find a workaround for this, but for now, it won't work with ruby 3.1 😩

Thank you very much for your reply @afaundez
Hopefully you will finde a solution.
Finger crossed.


Abstract States, Non-Abstract Parent States and Default Child States

I know we went back and forth on this several times already, but I think I may have found a need for this feature again.
It seems as though we are trying to get to a place where states can function completely on their own without any url routing (correct?). So how would we know which child state to load automatically without specifying a url of ''? Seems like we would need a default boolean property or something similar.
Let me also attempt to define abstract states, and non-abstract parent states. Please let me know if I'm on the right track.
Abstract State

must be a parent state
a state that cannot be activated directly (via transitionTo method) without activating one of its children.
must have a default child state (either with empty url or default property)
if no default child state is set, first child state found will be used as default
can be navigated to via url, but this really just activates default child state

Non-Abstract Parent State

a normal state which has child states
can be activated and navigated to directly (via transitionTo method or url), though any view directives will not be populated until navigation to on of it's child state OR one of its child states is set as default child (either with empty url or default property)
default child state is optional

I agree with @kbaltrinic and @timkindberg's original request!  I have hit this exact use case with list, add and edit.  +1

I'm in favor of @ProLoser's proposed implementation. We can roll that in once Transition objects are fully integrated.

@nateabele  Hopefully we can support returning a string and (state, param) objects like the following:
.state('Account.Security', {
          redirectTo: 'Account.Security.ChangePassword', // OR
          redirectTo: { state: 'Account.Security.ChangePassword', params: { id: 123} }, // OR
          redirectTo: ['$state', 'authenticationService', function($state, authenticationService){
                //Some logic
                return 'Account.Security.ChangePassword'; // OR
                return { state: 'Account.Security.ChangePassword', params: { id: 123} };
            }]
        });

Personally I prefer redirectTo over abstract since it better explains what is happening.

@acollard yes and no. I feel it makes sense of you read it as "on entering this state directly" but it's not as intuitive when you think about going directly to a child state.
I would prefer documenting it as "the abstract key can be true or you can give it a redirectTo string or function"

The redirectTo concept is definitely more general, especially if you think about it as a way of having one state encapsulate logic to dispatch to several other states. I'll have to think about it.

There are two things which would be nice to have out-of-the-box.

A start state, so if you have a abstract state super which has two child states, child1 and child2 and marking child1 as default, then transitioning to super would automatically transition to child1.
A history state, so if you exit super from child2, transitioning to super again would automatically go to the child state that was previously active, i.e. child2.

It seems like both of these things are possible using the redirectTo functionality suggested by @acollard, but it would be nice to be able to do it explicitly.

I think allowing you to create a redirect callback will allow you to do the
"last state"  stuff yourself because I have worked with a lot of
implementations and I think it's outside the scope of this issue
On Apr 28, 2015 8:33 AM, "Jonas Rabbe"<EMAIL_ADDRESS>wrote:

There are two things which would be nice to have out-of-the-box.

A start state, so if you have a abstract state super which has two
child states, child1 and child2 and marking child1 as default, then
transitioning to super would automatically transition to child1.
A history state, so if you exit super from child2, transitioning to
super again would automatically go to the child state that was
previously active, i.e. child2.

It seems like both of these things are possible using the redirectTo
functionality suggested by @acollard https://github.com/acollard, but
it would be nice to be able to do it explicitly.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/ui-router/issues/27#issuecomment-97106946.

Probably so, but currently history management is weak bordering on non-existent, so that particular use case is part of a larger set of things that need to be considered.

I think redirectTo might be useful for non-abstract states, too (during refactoring of state names, it might be useful to redirect the old state name to a new state name), but is really a more general case.
FWIW, it's pretty easy to add basic support for a default child state configuration by decorating the $stateProvider (see angular-ui-router-default).  Adding support for specifying a {state, params} configuration would be easy as well.
BTW, one might also consider specifying the default child state configuration by assigning a string value to the abstractsetting instead of using a default property, e.g.:
.state({
  abstract: '.defaultChild'
})

UI-Router 1.0 preview is available: https://github.com/angular-ui/ui-router/tree/feature-1.0

God I am going to have to review this thoroughly because I don't like the component router

I don't like the component router

We've been getting a lot of that.

Is there an elegant version of this: https://github.com/angular-ui/ui-router/issues/948#issuecomment-75342784 that includes using resolved data? I'm racking my brain trying to come up with a way on the current router to have a default child based on resolved values. I'm getting a bit of redirect-loop-complexity with my old implementation thus far.

I do like to think that something like the following could be implemented, native to UI-Router:
https://github.com/nonplus/angular-ui-router-default

@cScarlson in 1.0 that is super easy: http://plnkr.co/edit/YskNwwmQPm6AA6PNj0Cz?p=preview

@christopherthielen: sorry to comment on this old post, but I'm thinking this answer is just what I need. When I try your code though, $state is always null, so the $state.target(val)  results in an error.
Can you maybe give me a hint what to look for in such a case?


JS: Array.fill() not working

Hi,
the following code works using babel-node on my local machine:
var largeArray = Array(1000).fill(0);

But on codewars this seems to create an array filled with undefined.

I am gettting TypeError: Object ... has no method 'fill'

Not the best workaround, maybe, but try this one instead:
new Array(1001).join("a").split("").map(a=>0);

is this still supposed to be happening?? The above helps, but it would be really cool to use fill instead.

@jhoffner  this doesn't has to be on the codewars runner cli repo as issue?

Confirmed this using Node v0.10.33/Babel, but closing because Node v6 is available now.
We should also start looking into removing Node v0.10.x as it reached end-of-life status on 2016-10-31. nodejs/LTS.


Would this package be useful in DataFramesMeta?

I just finished a big PR in DataFramesMeta to try and reduce latency.
Given an expression of the form
f(:x, :y)

we make an anonymous function
(x, y) -> f(x, y)

This carries a compilation cost of creating the anonymous function. So my PR made an optimization where if it saw f(:x, :y) it would just return f, since it's the same as the anonymous function above.
But more other expressions are still problematic. Consider
:x + 1

This will always have to turn into
x -> x + 1

for purposes of the src => fun => dest syntax in DataFrames.
It looks like this package will let me cash :(x -> x + 1) so that the anonymous function of that form is only compiled once, and later calls are taken from a lookup. Is that correct?
If so, DataFramesMeta seems like a good application of this package.

Yeah, it would just hash as the same function.
But do you want to compile so much? It seems like it would make it a Symbolics expression and then use substitute, you could get away without ever compiling just by interpreting the expression. If the runtime cost isn't a major factor then using interpreting could be the right approach.

This is great news. I will file an issue at DataFramesMeta to remind myself to add this eventually.
We definitely need to compile, unfortunately. DataFramesMeta is really just an easy way of making calls like transform(df, :x => f => :y). So we need f to exist and be a function.
And yeah, runtime cost is a major factor since DataFrames has untyped columns. So we need function barriers for performance.


Command Line Editor Access over SSH to Docker Container

It'd be great to have a user that can access the Docker Container and work on the content that way, VIM should be preinstalled and preconfigured to allow easy handling of .md files. That user has to only be able to view and edit the files in the content directory.

There will also have to be a command-line tool that gives the user some commands to execute to, for example, rebuild the cache (or devalidate it), create a new Subfolder or Page...

The command-line tool will execute php scripts that have access to all my helper classes so that the wheel will not be reinvented


fix map encoding

The order of keys and values in the serialized format of an Erlang map seems to be different than what was implemented.  It's (k1, v1, k2, v2, ...) instead of (k1, k2, ..., v1, v2, ...).

Coverage decreased (-33.2%) to 66.796% when pulling ac249d1b00d4f325c99eb08fda4a1742271c4ab3 on bsanyi:develop into 2f8f1ca261caf7be40401fa16e5066174644fb29 on potatosalad:develop.

@bsanyi Whoops, you're right.  The original map implementation was based on EEP 43 which appears to have changed a bit when it actually landed in OTP.
I'll get this merged in soon, but it looks like the tests might need some adjustments first.
Thanks!


Create Tagslist Component to be used on JobCards and JobDetailsPage

Fixes https://x-team-internal.atlassian.net/browse/XP-3366
Description
Creates TagsList component, which is being implement into JobCard and JobDetails Page, replacing code that was rendering the tags in the latter.
Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the PEER REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest) (NOTE: This is temporarily disabled. Skip it.)
[x] if added a new UI component that is meant to be used directly by other apps, remember to export that from the appropriate bundle file: src/index.js and/or src/registration.js
[x] once finished with all the changes, you run npm run build command and committed changed files to the branch
[x] manually tested the app by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!

Related PRs

branch
PR

xp_registration_branch_name | XP Registration
Steps to Test or Reproduce
Check My Applications page once this PR and the PR open on xp-registration are merged
Impacted Areas in Application
My Applications Page, Job Details page
Screenshots

hey @WagnerMoreira, can we not use TagsList name? :) We had similar name for a component in the past, using "tags", it doesn't ended very well, it's misleading. This is not really generic, it's reusable indeed but very specific for Jobs Skills, I would suggest to use JobSkills name or something like that.


Create library for common utils in kpt functions catalog

There are common methods which must be maintained as separate utility package in kpt functions catalog to maintain consistency across functions.
Ts example: https://googlecontainertools.github.io/kpt-functions-sdk/api/modules/types.html#kuberneteskey

Common utilities should be provided by the SDK, instead of have a library maintain in the catalog repo.

where are we on this issue?   Close?  Add to backlog?  Let's make a decision.

Let's add to backlog.


Move DitherPunk to JuliaImages

This is a very nice image processing package and I think it would be wonderful if we can put it in JuliaImages and increase its exposure.
To start the transfer, I think I'll need to invite @adrhill as a JuliaImages member first, so here I'm asking for approval from other members of JuliaImages
cc: @timholy @zygmuntszpak @evizero @SimonDanisch

It's a cool package! As long as @adrhill wants this outcome, I'd be delighted to have it in JuliaImages.
#11 seems relevant, but as long as there's a commitment to eventually getting that done I'd approve and will not be picky about whether it happens before or after the move.

@adrhill Just sent you an invitation to JuliaImages, feel free to migrate once you're ready.
After migration, we also need to submit a PR to the General registry by updating the URL: https://github.com/JuliaRegistries/General/blob/master/D/DitherPunk/Package.toml
If there're more questions or concerns, please feel free to comment here or ask me in slack.

Thank you for your interest in this package. I'd love to have it in JuliaImages!


chore: Make playground file limit consistent

Description
The playground file limit is (unfortunately) specified in two places, and we missed one of them in #750.

Raised https://github.com/cerbos/cerbos/issues/774 to avoid this problem in the future by making validate.rules the source of truth.


Libtiff: fix failing fetch of Debian patch

It appears someone fixed the issue ahead of me, so I'm closing the PR.


added CQL method to confluence

I saw the handy method for creating JQL queries in jira.py and decided to give it a try in order to have the same possibility for Confluence. It seems to work well:
confluence.cql('space=TEST AND created > now("-10y") AND type=page',0,1)

Thank you for PR


Dev and CI configs

Enforce import order
Configure jsx-tag-spacing to have a consistent tag spacing
Updates eslint file to ensure is consistent
Updated dependencies (latest minor)
Ensure dependencies are always pinned in package.json

Codecov Report

Merging #216 (47dc9f2) into master (4a62fe6) will not change coverage.
The diff coverage is 94.13%.


Hidden tab container gets re-rendered when lazy=true

Current behaviour
A tab with lazy = true that was previously visited gets re-rendered in the background when it is hidden and conditions changed that should make it re-render if lazy would have been true
This is a separate issue from
https://github.com/react-navigation/react-navigation-tabs/issues/78 as that initially started about the Modal, but if you feel like closing that one and continuing here, that might be even better as the core issue is reported here.
Expected behaviour
No action happening in the hidden tab
Code sample
https://snack.expo.io/@morriz/tab-issues:-hidden-tab-container-gets-re-rendered-when-lazy=true
Your Environment

software
version

ios or android
android 9 (qemu emulator)

react-native
expo 31

react-navigation-tabs
1.0.1

node
11.2

npm or yarn
npm 6.4.1

removing this as it's not reproducible, and the other issue is not related

I updated the snack to make it very clear.

@brentvatne I have located the exact issue in the above snack, and would like to know what you think

you seem confused about what lazy does. it does not unmount components when you switch away, it just lazy loads them, so the component is not mounted until you switch to it for the first time.

https://github.com/react-navigation/react-navigation.github.io/issues/324 as follow up since this is probably not clear enough in the docs

@morriz, you might enjoy the withNavigationFocus helper. That will let you decide not to render the modal just because your screen is being rendered “in the background”

@brentvatne I understand that it does not get dismounted. I just thought that 'lazy' views out of sight would not be active at all. Maybe old remnants of dom tree memories.
But thanks @fbartho, I did manage to disable based on willBlur already. Might be using the same stuff.


Fix Plex configuration field name

Description:
Name of "Do not verify SSL" field mismatch.
Checklist:

[x ] The code change is tested and works locally.
[x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x ] There is no commented out code in this PR.
[ x] I have followed the [development checklist][dev-checklist]

Hi @skarcha,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


New "hp" display is not localisable

The new "hp 1/12" display is not localised and may be confusing to people.
I'd like to ability to customise or hide this new functionality.
For my educational game I have modified it to read "self.nametag =  self.health".
For me this looks pretty cool, as it lets the kids see numbers without worrying about the D&D "hp" term.
Possible options:

Provide a minetest.conf parameter like:
mobs.hpdisplayformat ="{$hpleft} / ${hp}"
Provide a hook to provide the nametag.  (I already override this myself under some circumstances)
Provide a global option to switch it off:
mobs.hpdisplay=false

We already have a 'mob_show_health' flag in minetest.conf to turn the health text on.off...  Will look into customizing string though.

Changed to a simple "♥ 1/20" style text.

nice.
On Mon, Jan 16, 2017 at 6:30 AM, tenplus1<EMAIL_ADDRESS>wrote:

Closed #32 https://github.com/tenplus1/mobs_redo/issues/32.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tenplus1/mobs_redo/issues/32#event-923599855, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AL3B6xpppFH00awsQmRd_7IUOdRHNBrvks5rSoH1gaJpZM4LX_Qq
.


Values are not populated in second pass renderer if preliminary state parsing had failed

Hey hey !
I've tackled a small issue (maybe ? would love your feedback) when executing helmfile on our uber-templated helmfile hierarchy that we've built in the past week.
To illustrate it, here's a small reproducer:
# helmfile.yaml
environments:
  default:
    values:
      - ./values.yaml.gotmpl
---

{{ readFile "common.yaml.gotmpl" }}

releases:
  - name: {{ .Values.releaseName }}
    <<: *default

# common.yaml.gotmpl
templates:
  default: &default
    chart: charts/{{ .Values.chartName }}

# values.yaml.gotmpl
releaseName: pasten
chartName: pasten-chart

I spot the following behavior:

Using .Values.releaseName fails with: in helmfile.yaml: error during helmfile.yaml.part.1 parsing: template: stringTemplate:5:20: executing "stringTemplate" at <.Values.releaseName>: map has no entry for key "releaseName"
Chaging it to .Environment.Values.releaseName fixes it, and it renders correctly

After debugging this, what I've found is:

We mock readFile in the preliminary state to return an empty string
This makes the prestate rendering fail, because the yaml anchor is undefined
The failure is tolerated and we continue towards the second pass rendering
When the prestate fails, the values map stays empty, while the environment values are correctly populated due to the previous part (layer)

This can be easily overcome by using (the deprecated / not recommended) .Environment.Values.
If that's in fact an issue (albeit probably an esoteric one), I think that a potential solution could be to populate the values regardless of whether or not the prestate had succeeded.
Would love to hear your thoughts.
Thanks !

I have run into situations where helmfile gives bad error message. I'm going to wait until this is fixed to see if that fixes the problem I'm seeing before opening an issue, but if you have the inclination to look into it:
What seems to be happening is that some error in first-pass rendering does not trigger a reported error, but leads to problems with the setup for the second-pass, and then we get a second-pass error like <.Values.releaseName>: map has no entry for key "releaseName" that is no help in figuring out the first-pass error, which could be, for example, an improperly indented comment that causes the template to stop processing prematurely.

Works great in 0.111.0 btw - thanks for approving !


util: NodeGetVolumeStatsResponse.Usage may not contain negative values

Following the CSI specification, values that are included in the
VolumeUsage MUST NOT be negative. However, CephFS seems to return -1 for
the number of inodes that are available. Instead of returning a
negative value, set it to 0 so that it will not get included in the
encoded JSON response.
Updates: #2579
See-also: https://github.com/container-storage-interface/spec/blob/5b0d4540158a260cb3347ef1c87ede8600afb9bf/spec.md?plain=1#L2477-L2487

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

/retest ci/centos/mini-e2e-helm/k8s-1.20

Oct 20 06:11:16.357: failed to create PVC with error failed to get pvc: rpc error: code = Unknown desc = OK: HTTP status code 200; transport: missing content-type field

https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.20/detail/mini-e2e-helm_k8s-1.20/2844/pipeline

/retest ci/centos/mini-e2e-helm/k8s-1.20


Slack certificate signed by unknown authority

What did you do?
I setup a Slack receiver
What did you expect to see?
I expected to receive notifications in Slack
What did you see instead? Under which circumstances?
level=error ts=2018-07-04T01:12:25.705362686Z caller=notify.go:303 component=dispatcher msg="Error on notify" err="Post https://hooks.slack.com/services/XXXXXXX: x509: certificate signed by unknown authority"
where XXXXXX is the actual API webhook
Environment

System information:

Linux 4.14.19-coreos x86_64

Alertmanager version:

  build user:       root@37b6a49ebba9
  build date:       20180213-08:16:42
  go version:       go1.9.2

Alertmanager configuration file:

# external alertmanager yaml
global:
  resolve_timeout: 10m
route:
  group_by: ['job']
  group_wait: 30s
  group_interval: 1m
  repeat_interval: 1m
  receiver: 'slack-channel'
  routes:
  - match:
      alertname: DeadMansSwitch
    receiver: 'slack-channel'
receivers:
- name: 'slack-channel'
  slack_configs:
  - channel: #vince
    send_resolved: true
    username: 'vince'
    api_url: https://hooks.slack.com/services/XXXXX

Logs:
see above

We use Prometheus Operator to manage Prometheus and Alert manager. I hoped into the container of alert manager and was able to fire the Slack notification with wget (curl not available)
wget --post-data '{"text":"Hello, World!"}' https://hooks.slack.com/services/XXXXX
It could be an issue with our company proxy. For many cases we need to supply and install a CA certificate when accessing HTTPS service.
How do I install a custom CA certificate inside the Docker image of Prometheus Alert Manager?

This is a usage question, and would be better directed to our mailing list<EMAIL_ADDRESS>where others could benefit. This also sounds like more of a docker specific question, where you need to create a new container based on the alertmanager container with your cert.

closing and will ask on the right channels. tx


issue with cargo install

Rust Toolchain 1.65
~ ❯ cargo install hxt
    Updating crates.io index
  Installing hxt v0.1.1
error: failed to compile `hxt v0.1.1`, intermediate artifacts can be found at `/tmp/cargo-installmjgMXZ`

Caused by:
  failed to select a version for the requirement `funty = "~1.2"`
  candidate versions found which didn't match: 2.0.0, 1.1.0, 1.0.1, ...
  location searched: crates.io index
  required by package `bitvec v0.22.3`
      ... which satisfies dependency `bitvec = "^0.22.3"` of package `hext v0.4.0`
      ... which satisfies dependency `hext = "^0.4"` of package `hxt v0.1.1`

Oi, sorry! A few things made me two weeks late on this. Thank you! I published a new version of hxt and the library hext that fixed it.
funty was yanked and then there were edition 2021 issues, oops.


Audio doesn't seem to load in Firefox

I've supplied both MP3 and OGG formats, only to receive the following message:
The buffer passed to decodeAudioData contains an unknown content type.

This issue was raised by ArashB.

Hi,
any tips to manage that issue ?
Firefox should support mp3 apparently => http://caniuse.com/#search=mp3

I'm still not sure precisely what's causing the issue, but I did find a way to mitigate it somewhat.
The files are supported, but sometimes they don't load in a timely fashion. This is where the problems start.
For some reason, Firefox (and only Firefox so far as I can tell) will very quickly fail to load files, and pass on a failure while it retries. This results in invalid data going to the audio code, which rightfully rejects it. If a retry succeeds, the audio code will accept it.
This most frequently happens with larger audio files, like background music, but is generally unpredictable.
A quick fix is twofold:

Increase the number of retries (to memory, set somewhere on game.loader)
Implement an audio manager in-game, through which all calls to play sounds are passed, and which will fail safely if a desired sound does not exist. This might even try to reload files periodically.

This isn't a great fix. We want to find out what's happening too, so we can burrow into the file loading system and isolate the exact issue. "Retry more" isn't a great fix for a network resource.


How to pass arguments to bra?

Hello,
Thanks for sharing this tool with the community.
I'm having a difficulty using bra - how may I pass arguments into bra's command handling?
For example, I want to watch the backend while developing Grafana.
To do so, they recommend doing:
bra run
This led to the creation and usage of the following contents:
[run]
init_cmds = [
  ["go", "run", "build.go", "-dev", "build-server"],
        ["./bin/grafana-server", "cfg:app_mode=development"]
]
watch_all = true
follow_symlinks = true
watch_dirs = [
        "$WORKDIR/pkg",
        "$WORKDIR/public/views",
        "$WORKDIR/conf",
]
watch_exts = [".go", ".ini", ".toml", ".template.html"]
build_delay = 1500
cmds = [
  ["go", "run", "build.go", "-dev", "build-server"],
        ["./bin/grafana-server", "cfg:app_mode=development"]
]

This works fine for starting everything with default values, but what if i wanted to run grafana-server with arguments like this:
grafana-server -config $HOME/.grafana/grafana.ini -homepath $HOME/go/src/github.com/grafana/grafana/
What would be the correct way to edit the .bra.toml file to enable argument passing like this?
Thank you very much.

Hi, I don't think you can. A better solution would be write a Makefile, use it's builtin mechanism to accept command line arguments, and call make xx in .bra.toml

.

Or, if the values of CLI flags do not change, just update the line:
 ["./bin/grafana-server", "cfg:app_mode=development"]

with actual value. ($HOME must be expanded, bra does not read env vars)


METRON-569: Change acking to prevent duplicate tuples in enrichment topology

Adding this ack statement prevents duplicate messages from being sent through the enrichment topology. Previously, in the JoinBolt, when a message does not complete a join, it does not get acked - this cause the message to get re-sent through the topology, resulting in duplicate messages being indexed.
This is a show-stopping bug, impacting performance and resulting in duplicate data.
I have tested this in the Quick-Dev enrichment as well as in our production system at high velocity.

How does this result in duplicate data?  Either the message completes a join and it isn't failed or it does not complete the join, does not pass past the join bolt and is replayed from the last anchor (which I think is the split bolt).
The rationale for not acking there is to have the message replay under circumstances where one of the enrichments is experiencing transient failure.  A failure in the join would result in a replay of the message and a retry.

@DomenicPuzio - any chance you can introduce a unit or integration test that exhibits the behavior you're fixing here?

I do want to point out that it's really appreciated that you submitted a PR.  I have seen potential bugs similar to this one that turned out to be duplicate data being sent to kafka.  I just want to rule that out.

Here's what I was seeing:
We were running only one Enrichment. So our EnrichmentSplitter sends originalTuple to the Join and originalTuple to the Enrichment. Enrichment then sends enrichedTuple to Join. Join knows that there are two streams, so it waits for two tuples to join together.
When originalTuple comes in first, we put it in the cache and do nothing. When enrichedTuple comes in, we see that it has its mate in the cache, we join originalTuple and enrichedTuple, and then we ack the current tuple, in this case, enrichedTuple. This means that we have never acked originalTuple, which caused Storm to re-send that tuple unnecessarily from the EnrichmentSplitter.
Since none of the cached messages are ever acked, Storm does not know that they have been correctly handled. Adding in the ack statement completely resolved this for me.
Does this clarify?
And @dlyle65535, I'm not sure on the best way to do that. Now that I've explained the problem, can you provide some guidance on what you'd like to see?

Looking into this further, but I imagine that we do probably want to ack all tuples in the join bolt regardless of them being anchored or not. From what you're describing it looks like this would be an issue even in happy path scenarios without enrichments or workers failing. It's not clear to me how this would be possible and not see this in our testing the other numerous streams.

@mmiklavc I completely agree that we should ack every tuple that comes through in the JoinBolt.  I think, however, that they should be acked only on a successful join.
The failure scenarios are currently handled thusly:

A failure in an enrichment (e.g. exception, hbase or mysql going down, etc) is handled by the enrichment adapter being robust enough to send an empty message even on failure
A failure in an enrichment bolt's infrastructure (e.g. the process dying or a machine failure) should be handled by the join failing and the original message replaying.  We anchor the message coming on the message channel in the SplitBolt, so it should get replayed.

If we ack every message as they come down the pipe, we could be in a situation where we've acked a message that never joins and never gets through.  Instead, I think we should ack every message on a successful join.
As of now, the tuple that sends the last enrichment segment in will get acked, which is definitely wrong.  What I would like to see is for the streamMessageMap to get augmented to track the tuples as well as the messages and for a successful join to result in all of the tuples in the map to get ack'd.  Possibly it's time for that map to actually be a proper class and it really only has to keep track of the tuple from the message stream.
Thoughts?

Also, @DomenicPuzio would you mind renaming this PR to METRON-569: Change acking to prevent duplicate tuples in enrichment topology so that the PR comments get replicated properly?

@cestella, I made the change to the PR name; thanks for the tip there.
I completely agree that we don't want to miss out on catching failures due to an enrichment source (like MySQL) or in the enrichment infrastructure. However, after we have put a tuple into the JoinBolt's cache, isn't it already past the point where these pitfalls could occur? If there is a failure in an enrichment, then Storm will time out while waiting for an ack that never takes place, so this message will be re-sent; but if the message is already in the cache, isn't its journey complete?
My thought with placing the ack there was (1) at this stage of the topology, that tuple has been correctly processed, and (2) for simplicity's sake so that we wouldn't have to modify streamMessageMap. I do agree that acking everything after the join has taken place also makes a lot of sense, and I can work on that if you would like.
We saw the duplicate data while running this in our development environment in EC2. Perhaps this is due to different ack timeout settings in the Storm topologies? We've repeated the duplication of data many times on our end.

Hey @DomenicPuzio thanks man :)
The problem with placing the ack there is that in the situation where the enrichment adapter worker gets killed, we would like the data to replay from the anchor point (the SplitBolt) because Storm will have respawned the worker elsewhere and we'd like that enrichment to be captured.  If you keep the ack where you have it, the message will never join if the enrichment worker gets killed, so the message will ultimately get dropped, which isn't ideal.
Ultimately, I think we can all agree that we need to ack at LEAST the tuple on the message stream, but I think that we want to ack it AFTER the join has happened.
Regarding seeing dup data, I believe you.  I am just trying to wrap my head around how it happens, but, as they say, the proof of the pudding is in the eating. :)

It occurs to me that what may be happening is that an enrichment may be taking longer than the timeout that storm is using to wait on that ack.  If that is the case, I could see duplicated data.
Imagine the following situation, with the storm timeout x and an enrichment taking x + 1.  The enrichment would finish and send the enriched data from the enrichment adapter to the join bolt but storm would've already triggered a replay.  The enrichment completing would have triggered the join to happen and the joined message to be emitted and the replay would trigger another copy of the message.
In this case, I'd suggest ensuring that either your enrichment is capped at maximum http://storm.apache.org/releases/current/javadocs/org/apache/storm/Config.html#TOPOLOGY_MESSAGE_TIMEOUT_SECS or adjusting the message timeout in storm to be higher than this setting in storm.

Sorry for the delayed response, @cestella - I was taking some time off for the holiday.
While I don't believe custom enrichment is pushing us over the timeout (we've clocked it at 15ms at the worst), that's certainly a possibility and something that we should also guard against. With this in mind, we now have two tasks to look into:

Ensuring all messages get acked after a successful join by building out the streamMessageMap
Making sure that our cache refresh is set to some fraction of the Storm timeout interval

Are these both items that we would like to complete? Should we split these into separate JIRAs and PRs? Should I work on the acking changes within this PR?

Yep, so my personal suggestion is to make sure that all messages get acked on a successful join by augmenting streamMessageMap and ensure that the cache refresh is longer than the storm timeout (if it is shorter, then it'll never join because the partial messages will timeout before the final message comes through).
Anyone else have thoughts?

I think #603 should address this now.

@DomenicPuzio, this has been resolved by https://github.com/apache/metron/pull/603.  Can we close this PR?

Yep, we can wrap it up! Thanks, all!


Add music notation of the note

Hi, i'd like to add a feature that shows an image representing the position of the recognized note.
For example, if the C note is recognized, the app would have this output:

How can i do that?

Hi @stexniolo , this is no longer an active project but you are more than welcome to fork the project and use it yourself in accordance with the open source license.
As to your question, I'm sure you can come up with a solution to achieve this. Creating a custom Android View to draw dynamic notation will not be trivial but another option may be to use a predefined set of images. Then, when the Note is detected, match the Note name to an image resource and change the image in the ImageView beneath the Tuner View. One of the many things to consider, is that the notes detected can change rather quickly, so it might look harsh to the User if the images rapidly change.
Good luck!


How can i get a name of the currently loaded/used settings class?

I know I can use os.getenv but I'd like to be able to get the name of the currently used django-configurations settings class name in the code? How do I know I'm in Prod vs Development etc?

@brianhelba @striveforbest I think, that a utility for returning the configuration class itself would also be a nice feature... Even if it is as simple as:
from django.conf import settings
from django.utils.module_loading import import_string

def get_configuration_class():
    return import_string(settings.CONFIGURATION)

It could be LRU cached, of course...


Broken link on k8s_audit_config/README.md

this page has a broken link to
examle files
Could it please be updated?

Hi @haugom, will fix the broken link.
In the meantime here you will find step by step guide on how to enable the audit logs in minikube and deploy Falco: https://falco.org/docs/getting-started/third-party/learning/#falco-with-multiple-sources.
Thanks!

thanks for the fix and link!


Expected declaration of FUICustomAuthDelegate.swift

I'm facing build time error, declaration of FUICustomAuthDelegate function

Fixed in https://github.com/firebase/FirebaseUI-iOS/commit/f504bd46ab20ff574edd3999be6163b544c02d89,
Thanks!


Build issues with Lock

Any ideas?
:app:bundleDebugJsAndAssets SKIPPED
:app:processDebugManifest UP-TO-DATE
:app:processDebugResources
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:2 : Error retrieving parent for item: No resource found that matches the given name 'Lock.Theme'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:12:17-33 : No resource found that matches the given name: attr 'Auth0.Background'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:15:17-36 : No resource found that matches the given name: attr 'Auth0.CredentialBox'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:16:17-38 : No resource found that matches the given name: attr 'Auth0.CredentialField'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:17:17-44 : No resource found that matches the given name: attr 'Auth0.CredentialField.Email'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:18:17-47 : No resource found that matches the given name: attr 'Auth0.CredentialField.Password'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:19:17-47 : No resource found that matches the given name: attr 'Auth0.CredentialField.Username'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:20:17-30 : No resource found that matches the given name: attr 'Auth0.Message'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:13:17-41 : No resource found that matches the given name: attr 'Auth0.PrimaryButtonStyle'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:14:17-43 : No resource found that matches the given name: attr 'Auth0.SecondaryButtonStyle'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:21:17-38 : No resource found that matches the given name: attr 'Auth0.Separator.Color'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:10:17-33 : No resource found that matches the given name: attr 'Auth0.Title.Icon'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:11:17-33 : No resource found that matches the given name: attr 'Auth0.Title.Text'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:71:17-44 : No resource found that matches the given name: attr 'com_auth0_errorIconDrawable'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:70:17-45 : No resource found that matches the given name: attr 'com_auth0_normalIconDrawable'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:71:17-44 : No resource found that matches the given name: attr 'com_auth0_errorIconDrawable'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:70:17-45 : No resource found that matches the given name: attr 'com_auth0_normalIconDrawable'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:71:17-44 : No resource found that matches the given name: attr 'com_auth0_errorIconDrawable'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:70:17-45 : No resource found that matches the given name: attr 'com_auth0_normalIconDrawable'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:2 : Error retrieving parent for item: No resource found that matches the given name 'Lock.Theme.Title.Icon'.
/Users/giro/stardust-app/android/app/src/main/res/values/styles.xml:2 : Error retrieving parent for item: No resource found that matches the given name 'Lock.Theme.Title.Text'.
:app:processDebugResources FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:processDebugResources'.

com.android.ide.common.process.ProcessException: org.gradle.process.internal.ExecException: Process 'command '/usr/local/opt/android-sdk/build-tools/23.0.1/aapt'' finished with non-zero exit value 1

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Total time: 9.109 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/android-setup.html
vlt062:stardust-app giro$

I'm having the same issue. Haven't found a solution yet. If somebody jumps in here. I want to scrap Auth0 altogether. Anything I have to consider?

@GeoffreyPlitt
I have just made a fresh install on Linux and macosx
git clone ...
npm install
react-native run-android

and everything seems fine.
Which version of node and npm are you on, which system. What is the output of react-native -v?
you can also try to use gradlew directly to build and see if that makes any difference.
cd android
./gradlew assembleDebug
./gradlew installDebug

@stefanwuest I am not using Auth0 in my projects based on Pepperoni. Which auth module would you like to see and why

These are the versions I'm currently using:
$ react-native -v
react-native-cli: 1.0.0
react-native: 0.29.2
$ npm -v
3.10.2
$ node -v
v6.2.2

Building with gradlew threw the same error...
@fabriziomoscon Undecided — currently still looking at other options.

If that helps I am actually running an older react-native
react-native -v
react-native-cli: 0.2.0

I am using facebook-account-kit for auth, so I scraped most of auth0 out of the the project.

I resolved the problem for me by removing Auth0 stuff from the following files:
android/app/app.iml
<orderEntry type="module" module-name="react-native-lock" exported="" />

android/app/src/main/AndroidManifest.xml
      <!--Auth0 Lock-->
      <activity
        android:name="com.auth0.lock.LockActivity"
<EMAIL_ADDRESS>        android:screenOrientation="portrait"
        android:launchMode="singleTask">
      </activity>
      <!--Auth0 Lock End-->
      <!--Auth0 Lock Embedded WebView-->
      <activity
          android:name="com.auth0.identity.web.WebViewActivity"
<EMAIL_ADDRESS>      </activity>
      <!--Auth0 Lock Embedded WebView End-->
      <!--Auth0 Lock Passwordless-->
      <activity
          android:name="com.auth0.lock.passwordless.LockPasswordlessActivity"
<EMAIL_ADDRESS>          android:screenOrientation="portrait"
          android:launchMode="singleTask">
      </activity>
      <activity
          android:name="com.auth0.lock.passwordless.CountryCodeActivity"
<EMAIL_ADDRESS>      </activity>
      <!--Auth0 Lock Passwordless End-->

android/app/src/main/res/values/styles.xml
<style name="AppTheme.Lock.Theme.CredentialField" parent="Widget.AppCompat.EditText">
    <item name="android:layout_width">match_parent</item>
    <item name="android:layout_height">@dimen/com_auth0_credential_field_height</item>
    <item name="android:textSize">@dimen/com_auth0_credential_field_font_size</item>
    <item name="android:textColorHint">#ffffff</item>
    <item name="android:paddingLeft">@dimen/com_auth0_credential_field_padding</item>
    <item name="android:paddingRight">@dimen/com_auth0_credential_field_padding</item>
    <item name="android:paddingBottom">@dimen/com_auth0_credential_field_vertical_padding</item>
    <item name="android:paddingTop">@dimen/com_auth0_credential_field_vertical_padding</item>
    <item name="android:drawablePadding">@dimen/com_auth0_credential_field_icon_right_padding</item>
    <item name="android:background">@color/com_auth0_credential_field_background</item>
    <item name="android:textCursorDrawable">@drawable/com_auth0_cursor</item>
  </style>

  <style name="AppTheme.Lock.Theme.CredentialField.Email" parent="AppTheme.Lock.Theme.CredentialField">
    <item name="android:textColor">#ffffff</item>
    <item name="com_auth0_normalIconDrawable">@drawable/com_auth0_ic_email</item>
    <item name="com_auth0_errorIconDrawable">@drawable/com_auth0_ic_email_error</item>
  </style>

  <style name="AppTheme.Lock.Theme.CredentialField.Password" parent="AppTheme.Lock.Theme.CredentialField">
    <item name="android:textColor">#ffffff</item>
    <item name="com_auth0_normalIconDrawable">@drawable/com_auth0_ic_lock</item>
    <item name="com_auth0_errorIconDrawable">@drawable/com_auth0_ic_lock_error</item>
  </style>

  <style name="AppTheme.Lock.Theme.CredentialField.Username" parent="AppTheme.Lock.Theme.CredentialField">
    <item name="android:textColor">#ffffff</item>
    <item name="com_auth0_normalIconDrawable">@drawable/com_auth0_ic_person</item>
    <item name="com_auth0_errorIconDrawable">@drawable/com_auth0_ic_person_error</item>
  </style>

  <style name="AppTheme.Lock.Theme.Message" parent="TextAppearance.AppCompat.Small">
     <item name="android:layout_marginBottom">@dimen/com_auth0_lock_vertical_margin</item>
     <item name="android:textColor">#ffffff</item>
  </style>

got exactly same problem :(

@GeoffreyPlitt @chrisciszak thanks for reporting the issue. I am unable to reproduce it on OSX. These are the steps I tried, could you tell me what you are doing differently?
# clone fresh copy
git clone git@github.com:futurice/pepperoni-app-kit.git pepperoni-fresh && cd pepperoni-fresh

# install deps and configure
npm i
cp env.example.js env.js

# run (assumes running android emulator)
react-native run-android

I've got the same problem :(, thank's @stefanwuest for the workaround

Closing this issue now since we've now made Auth0 optional for pepperoni :)

still have same issue...

Hi @zzswang, have you tried cloning a fresh version of Pepperoni recently? It doesn't have the Auth0 dependency anymore. Or do you want to use Auth0?

I don't want to use Auth0 for the beginning. Maybe later.
I followed the steps listed above by jevakallio, then got the same issue.
# clone fresh copy
git clone git@github.com:futurice/pepperoni-app-kit.git pepperoni-fresh && cd pepperoni-fresh

# install deps and configure
npm i
cp env.example.js env.js

# run (assumes running android emulator)
react-native run-android

Hi @zzswang can you try to use another name for your repo (without a -) and rerun the same setup? You could also just clone a fresh copy of pepperoni and try to build it without the renaming script. If this doesn't help please post the error message you're getting here.

@tino-junge  remove "-" from the folder name. Everything is ok.
Thanks a lot. :)

Great, to hear :) will close this issue now


Format error for badly formed JSON file

What
The error when a user has badly formed JSON is not processed in a particularly helpful way e.g.
app/config.json:
{
  "serviceName": "Hello world",
  "aProperty": "set",
  "anotherProperty: "also set"
  "no comma before this property": "is a problem"
}

Has the output:
File: /Users/natalie.carey/projects/opensource/alphagov/govuk-prototype-kit/node_modules/jsonfile/index.js (line 52)

Error: /Users/natalie.carey/projects/prototype-kits/companion-prototype-kit/app/config.json: Unexpected token a in JSON at position 77

The file should really be app/config.json line 4 char 17.
Who needs to work on this

Developer

Who needs to review this

Developer

Done when

[ ] The error for a malformed app/config.json shows the JSON file as the problem (not the place where the JSON file is loaded)

We've discussed how to convert "position" into "line" and "column".  Here's an example:
async function getLineAndColFromFileContentsAndPosition(fileContents, position) {
  const lineArrUntilPosition = fileContents.substring(0, position + 1).split(/(?:\n|\r\n)/)

  return {
    line: lineArrUntilPosition.length,
    col: lineArrUntilPosition.at(-1).length
  }
}


Fails to build on 1.12.0-nightly (197be89f3 2016-08-15)

error[E0063]: missing field `test_threads` in initializer of `test::TestOpts`
   --> src/compiletest.rs:126:5
    |
126 |     test::TestOpts {
    |     ^^^^^^^^^^^^^^

The field was added in https://github.com/rust-lang/rust/pull/35414.

Any chance to get this fix published on crates.io?

@regexident this was published as 0.2.1.

Uh, yeah.
Had run cargo outdated and cargo add compiletest_rs to update compiletest_rs.
Apparently cargo add doesn't detect [dev-dependencies] and just added a second entry to [dependencies] .
[dependencies]
compiletest_rs = "0.2.1"

[dev-dependencies]
compiletest_rs = "0.1.3"

Changing Cargo.toml to…
[dev-dependencies]
compiletest_rs = "0.2.1"

…fixed it of course. Sorry for bothering you.


'document.queryCommandSupported' is deprecated

https://github.com/microsoft/vscode/blob/2fda9b1fa4abf8b121e93e99901a1b04e7ace6f2/src/vs/editor/contrib/clipboard/browser/clipboard.ts#L27-L32
Are there any plans to replace the usage of document.queryCommandSupported deprecated method?

Closing as there isn't a reason to replace it and it's only being used for Firefox

@mjbvz Any suggestion on how to work around this when testing with Vitest because this part of the code fails when running tests in both the happy-dom and jsdom environments?


feat: Annotating replicasets, statefulsets and daemonsets

Purpose of PR?:
When kubeArmor is installed it doesnt add annotation to already present replicaset and statefulset
Fixes #1180
Problems causing this error
1) Deployment Name
to get the deployment name we were using this pod.Metadata["deploymentName"]  and to update the annotation we need ownerref.name as the deployment name
2) Updating container list
To update the container list we used this
deploy, err := K8s.K8sClient.AppsV1().Deployments(pod.Metadata["namespaceName"]).Get(context.Background(), deploymentName, metav1.GetOptions{})

we cannot get replicaset and stateful set using this
logic is we loop through the containers and see if we annotations for that and update updateAppArmor variable as true which is required to go into PatchResourceWithAppArmorAnnotations() method
Solution
We again check for the kind of pod and use appropriate method to Get the the replicaset or statefulset
3) In PatchDeploymentWithAppArmorAnnotations Method
In this method we use this to patch the annotations but it only for deployments hence not updating replicaset and stateful set
	_, err := kh.K8sClient.AppsV1().Deployments(namespaceName).Patch(context.Background(), deploymentName, types.StrategicMergePatchType, []byte(spec), metav1.PatchOptions{})
	if err != nil {
		return err
	}

Solution
We send Kind of deployment and again check use the resource appropriate method to patch the annotations
Additional information for reviewers
Using Patch method to update annotation restarts the deployments and statefulset ,
but by default patching doesn't restart the replicaset
To restart we replicaset we have 2 options
1) Delete the replicaset (X)
we do not go with deleting the replicaset as it often permanently deletes the pod
2) Scale the replicaset to zero replicas and scale it back up (we use this one)

We need automated tests for this issue.

@achrefbensaad Merging is blocked. Please approve.


Dockerd.exe not found during task "Start docker as a Windows Service"

Hi,
Dockerd.exe does not ship anymore with the docker CLI from choco install. This causes "Start docker as a Windows Service" to fail.
Sorry for the initial empty posting.

Ia m not sure how you want to approach this but a possibility could be to use this script https://github.com/StefanScherer/packer-windows/blob/my/scripts/docker/install-docker.ps1 . I haven't dug into how it would handle the update case


Adding users via /admin/auth/user/add/ throws error because password field doesn't exist

Request Method:
GET

http://localhost/admin/auth/user/add/

1.11

KeyError

'password'

/usr/local/lib/python3.5/site-packages/admin_view_permission/admin.py in get_form, line 339

/usr/local/bin/python

3.5.5

['/usr/src/app',  '/usr/local/bin',  '/usr/local/lib/python35.zip',  '/usr/local/lib/python3.5',  '/usr/local/lib/python3.5/plat-linux',  '/usr/local/lib/python3.5/lib-dynload',  '/usr/local/lib/python3.5/site-packages']

5 Mar 2018 17:42:33 +0000

The offending code is https://github.com/ctxis/django-admin-view-permission/blob/master/admin_view_permission/admin.py  line 339,  at least in my case the form has two password fields: password1 and password2
this is part of the rendered form

   Password:
   <input type="password" name="password1" id="id_password1" required />

   Password confirmation:
   <input type="password" name="password2" id="id_password2" required />

Enter the same password as before, for verification.

@jlaso temporary you can use my branch #46
pip install -e git+https://github.com/Sinkler/django-admin-view-permission@exclude-models#egg=django-admin-view-permission

Hi all,
Thank you for the feedback.
The fix #43 has been merged to master. Tomorrow, I will push a new release.
Thanks,
Lefteris


[Security Flaw] Writing username and password to log file when logging in via the API

Currently the logRequest() function within azkaban-web-server/src/main/java/azkaban/webapp/servlet/LoginAbstractAzkabanServlet.java logs the full string of every API call. This includes the credentials used to login and obtain a session id for further API calls. For example, see below:
2017-04-17 14:50:39 INFO  LoginAbstractAzkabanServlet:171 - 0  -  "POST / action=login&username=azkaban_admin&password=PASSWORD HTTP/1.1" not-browser
2017-04-17 14:50:40 INFO  LoginAbstractAzkabanServlet:171 - 0 azkaban_admin "POST /executor ajax=reloadExecutors&session.id=7e5927e9-4c60-7465-9c26-897cd45b25d7 HTTP/1.1" not-browser
2017-04-17 14:50:40 INFO  ExecutorManager:194 - Initializing multi executors from database

This is a major security flaw as our admin and automation testing accounts frequently use the API, and we don't want those credentials being logged to the local file system in a plaintext file. Could we implement a solution to scrub the password value from the string before writing login requests to the log file? Does anyone else agree this is a security risk?

Yes. Can you consider contributing the necessary patch?

I'd love to, but unfortunately my hands are currently tied by legal at my company and I'm not allowed to publish any of my code back yet. From what I can tell, it would be a simple update to that one function within that one file, if anyone else wants to take a stab at it. Once I get approval from legal I'll submit a pull request.

ok no problem - We will try and fix it. Btw which company are you from? Can you share how you use Azkaban. Would love to get more details. Also - please share if you have any product ideas.

Sure, we currently use Azkaban as our batch scheduler for all our Java Batch processing jobs. In preprod, we have several instances set up, each managing multiple environments. For example, we have one Azkaban instance for all our dev regions, a separate Azkaban instance for our test regions, and then a separate Azkaban instance for our performance test regions. Each of these instances manage multiple environments, sending jobs to the correct executor depending on which project it is launched from. When a job is launched, it compared the project name to values stored in the properties file to determine which executor ID to send it to (internal code enhancement we have developed). This allows us to manage multiple independent environments within the same Azkaban console, without the worry of sending jobs to the wrong executor.
In production, we have one Azkaban instance that we use to schedule our Java Batch jobs across multiple executors. Currently we predefine the exact executor every job runs on, but eventually we plan to move towards letting Azkaban perform the load balancing for us.
We have also developed an LDAP plugin extension that allows the use of a bind account when authenticating for more secure connections.
We have also developed an HA set up that we use in production with a replicating MySQL database and active-passive webserver instances. In the event of a disaster, we will shut down the primaries and fail over to the secondary instance which will then be brought online. The executors are then reconfigured to hook into the secondary instance.
We have also developed a python based scheduling script that we use to load our job schedule on a weekly basis from a json inventory we manage in our cmdb. We created a few new API's for this that allow us to schedule everything to our needs and retire projects/environments at ease.
We have many other small bug fixes and internal enhancements that we plan to release back to the open source community here once we receive approval from legal. We transitioned over to Azkaban from an enterprise scheduler last Fall, and have been pleased with our decision and the ongoing activity here ever since. Our team is actively working on improvements to the system that we think will benefit everyone! (once we are able to contribute back of course)

@devangorder
what's your command to call the api, i tried this but not being able to see the issue.
curl  -X POST --data "action=login&username=cheng.ren&password=XXXX" http://localhost:8081

@devangorder are you still seeing this issue?
We're only observing it when passing login credentials through the URI like this:
curl -X POST http://localhost:8081/?action=login&username=azkaban&password=azkaban
Which leads to this line being logged:
2017/06/12 14:39:34.747 -0700 INFO [LoginAbstractAzkabanServlet] [Azkaban] 0  -  "POST / action=login&username=azkaban&password=azkaban HTTP/1.1" not-browser
It's common to log all information in the URI in this fashion. We expect users will pass sensitive information in the request body instead of in the URI like this:
curl -X POST -d "action=login&username=azkaban&password=azkaban" http://localhost:8081
Which leads to this line being logged:
2017/06/12 14:41:38.628 -0700 INFO [LoginAbstractAzkabanServlet] [Azkaban] 0  -  "POST / - HTTP/1.1" not-browser
Are we missing something? If so, could you provide the steps for reproducing the logging of the request body?
Also, do you think it would be valuable for us to explicitly tell users to pass sensitive information in the request body instead of in the URI in our documentation?
Thank you again for bringing this to our attention!


fix tests

fixes are already here https://github.com/Developer-Autodesk/forge-configurator-inventor/pull/270

duplicate