Feature Request - exportPath dynamic for each build variant.

About this issue

Briefly describe the issue
I currently use a command like this to generate my aboutlicense.json file

./gradlew app:exportLibraryDefinitions -PaboutLibraries.exportPath=src/main/assets/ -PaboutLibraries.exportVariant=dimensionRelease
Where dimension is different components of my build variant. Different variants will possibly have different included libraries e.g. a "pro" version of my app might include an extra library.
When building the different versions of my app, free/pro etc, I'd like the output json file placed in the correct src/free/assets or src/pro/assets folders.
It'd be great if exportPath could use the configuration of exportVariant to know where to place the file, perhaps making the path relative to dimension. e.g. -PaboutLibraries.exportPath=/assets/ PaboutLibraries.exportVariant=proRelease would place the file in src/pro/assets
Details

[ ] Used library version - 10.5.1
[ ] Used support library version
[ ] Used gradle build tools version - 7.3.3
[ ] Used tooling / Android Studio version - Android Studio Flamingo, Canary 8
[ ] Other used libraries, potential conflicting libraries - Jetpack Compose 1.3

Checklist

[x] Searched for similar issues
[x] Checked out the sample application
[x] Read the README
[x] Checked out the CHANGELOG
[ ] Read the MIGRATION GUIDE

@apkelly thank you for describing your usecase.
I may need some more information to better understand the benefit.
As you describe, you are passing the exportPath and exportVariant already. E.g. you will probably have multiple such export steps for the different variants.
What would the major benefit of the exportPath internally identifying the variant specific folder? As I assume this is only gonna be defined ones and then most likely stay for the most part like that?

Theoretically the android integration would do something like this: https://github.com/mikepenz/AboutLibraries/blob/develop/plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesPluginAndroidExtension.kt#L43
But personally I also prefer the "manual" approach, with the file being checked in as it allows for much more control of what's getting changed.

The app I work on is branded for different clients, and also runs on different vendor hardware (each with their own SDKs)....its not an app for mobile phones, so we have lots of different "release" builds.
I like the idea of manually running the export command, but I wanted to see if there was a way to cut down on the configuration, so that exportPath could be defined in my aboutlibraries section of my gradle file, and then depending on the exportVariant being created, the json file would be deposited in the correct /src/xxx/assets folder.

Oh I see. So it's not an Android project, as such the automatic registration for android build tasks won't work.
Not sure how much can be reproduced of that as part of the sample app. But it may be worth exploring to add some of these variants to the app-desktop sample we have, and then see if something similar like we do for Android (https://github.com/mikepenz/AboutLibraries/blob/develop/plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesPluginAndroidExtension.kt) would be possible for those desktop builds. 🤔
One thing I am not sure on is, if Gradle will have the appropriate folder per variant. I'd prefer not to base the folder path definition on assumptions which may break for other people.


ReferenceError: e is not defined

I am getting a Reference Error as soon as I start the bot, its from the API files.
Here is my log:
[15/4/2017 21:44:17] - info: LogLevel: info
[15/4/2017 21:44:17] - info: Connecting to pad
[15/4/2017 21:44:17] - info: Connecting to socket
/home/mqp-bot/node_modules/mqp-api/src/app.js:159
      logger.log('error', "Websocket error: " + e);
                                                ^

ReferenceError: e is not defined
    at WebSocket._this.ws.onerror (/home/mqp-bot/node_modules/mqp-api/src/app.js:159:49)
    at WebSocket.onError (/home/mqp-bot/node_modules/ws/lib/WebSocket.js:452:14)
    at emitOne (events.js:96:13)
    at WebSocket.emit (events.js:191:7)
    at ClientRequest.onerror (/home/mqp-bot/node_modules/ws/lib/WebSocket.js:711:10)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:191:7)
    at TLSSocket.socketErrorListener (_http_client.js:358:9)
    at emitOne (events.js:96:13)
    at TLSSocket.emit (events.js:191:7)
    at emitErrorNT (net.js:1283:8)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)

Can you send your bot config? There is probably an issue connecting to your websocket server.
It's weird that the error isn't defined though...

What config would that be? The config.json I made for the bot?

The object you pass to the bot API when initializing it.

var bot = new mqpAPI({
  autoreconnect: true,
  logging: {
    logLevel: 'info',
    logFile: './logs.json'
  }
});

bot.connect({
  useSSL: true,
  socketDomain: 'music.tfs-network.com',
  socketPort: 8002
}).then(() => {
  console.log('Connected!');
})```

fixed in c2189b657b86cc19879abaa24e7a9d6ca4344d50


Invoke-DbaWhoIsActive - Fix for CS collations and internal refactoring

Type of Change

[x] Bug fix (non-breaking change, fixes #7881 )
[x] New feature (non-breaking change, adds functionality, fixes #7881 )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Unit test is included
[ ] Documentation
[ ] Build system

See linked issue for details.

Nice! Solid changes, thank you 🙏🏼


Parser runs into no viable alternative exception - maybe nested performs with indexed variables ?

Parsing the attached file leads to the following error
Cobolfile: a2600215.CBL threw exception: {}
java.lang.RuntimeException: syntax error in line 339:71 no viable alternative at input 'DISPLAY '------------------------------------------'-'
	at io.proleap.cobol.asg.runner.ThrowingErrorListener.syntaxError(ThrowingErrorListener.java:20)
	at org.antlr.v4.runtime.ProxyErrorListener.syntaxError(ProxyErrorListener.java:41)
	at org.antlr.v4.runtime.Parser.notifyErrorListeners(Parser.java:544)
	at org.antlr.v4.runtime.DefaultErrorStrategy.reportNoViableAlternative(DefaultErrorStrategy.java:282)
	at org.antlr.v4.runtime.DefaultErrorStrategy.reportError(DefaultErrorStrategy.java:121)
	at io.proleap.cobol.Cobol85Parser.ifThen(Cobol85Parser.java:31532)
	at io.proleap.cobol.Cobol85Parser.ifStatement(Cobol85Parser.java:31335)
	at io.proleap.cobol.Cobol85Parser.statement(Cobol85Parser.java:24801)
	at io.proleap.cobol.Cobol85Parser.performInlineStatement(Cobol85Parser.java:35565)
	at io.proleap.cobol.Cobol85Parser.performStatement(Cobol85Parser.java:35488)
	at io.proleap.cobol.Cobol85Parser.statement(Cobol85Parser.java:24857)
	at io.proleap.cobol.Cobol85Parser.sentence(Cobol85Parser.java:24440)
	at io.proleap.cobol.Cobol85Parser.paragraph(Cobol85Parser.java:24376)
	at io.proleap.cobol.Cobol85Parser.paragraphs(Cobol85Parser.java:24293)
	at io.proleap.cobol.Cobol85Parser.procedureDivisionBody(Cobol85Parser.java:24151)
	at io.proleap.cobol.Cobol85Parser.procedureDivision(Cobol85Parser.java:23223)
	at io.proleap.cobol.Cobol85Parser.programUnit(Cobol85Parser.java:880)
	at io.proleap.cobol.Cobol85Parser.compilationUnit(Cobol85Parser.java:783)
	at io.proleap.cobol.Cobol85Parser.startRule(Cobol85Parser.java:727)
	at io.proleap.cobol.asg.runner.impl.CobolParserRunnerImpl.parseFile(CobolParserRunnerImpl.java:190)
	at io.proleap.cobol.asg.runner.impl.CobolParserRunnerImpl.analyzeFile(CobolParserRunnerImpl.java:94)
	at de.dvzmv.fabea.infrastruktur.csi.parser.SingleCobolParser.parseFile(SingleCobolParser.java:56)
	at de.dvzmv.fabea.infrastruktur.csi.parser.SingleCobolParser.main(SingleCobolParser.java:140)
[a2600215.CBL.txt](https://github.com/uwol/cobol85parser/files/1575474/a2600215.CBL.txt)

Ok, this one is tricky.

The problem is with following code, where we have a special line continuation:

055530             DISPLAY '------------------------------------------' 08.01.13
055540-                    '-------------------------------------'      08.01.13

Currently, the preprocessor is transforming these 2 lines to following 1 line with an invalid literal:

                   DISPLAY '------------------------------------------'-------------------------------------'

However it should be either (solution 1):

                   DISPLAY '-------------------------------------------------------------------------------'

or  it should be (solution 2):

                   DISPLAY '------------------------------------------''-------------------------------------'

Why is this: Currently the preprocessor is removing a leading ' or " in the continued line, because the NIST test suite that was used to develop the preprocessor has only line continuation examples such as the following, where in the continued line there is no trailing '

055530             DISPLAY '------------------------------------------ 08.01.13
055540-                    '-------------------------------------'     08.01.13

From documentation on the web, solution 2 seems to be correct. Also it is simpler to implement than solution 1, so I'll bug fix with solution 2. If this is not sufficient, please feel free to comment!

I would prefer a solution where the input format is considered.
In general all "my" provided samples are host/mainframe based and thus fixed column format: This would eliminate solution one, thus I would opt for solution 2.
kind regards

Argh, gets more complicated. NIST test case ST135A shows

If the trailing quote in the continued line opens a literal, the leading quote in the continuation line has to be removed (ST135A). E. g.

043500     IF      SORTOUT-NON-KEY-1 NOT EQUAL TO "                     ST1354.2
043600-    "              A" GO TO SORT-FAIL-1.                         ST1354.2

has to be processed to
           IF      SORTOUT-NON-KEY-1 NOT EQUAL TO "                                   A" GO TO SORT-FAIL-1.

If the trailing quote in the continued line closes a literal, the leading quote in the continuation line has to be kept (your example). E. g.

055530             DISPLAY '------------------------------------------' 08.01.13
055540-                    '-------------------------------------'      08.01.13

has to be processed to
                   DISPLAY '------------------------------------------''-------------------------------------'

I'll have to search for a solution, that's more robust than number_of_quotes_in_line % 2 == 0 :-)

Ok, added a fix in 2cbdd8eada9fa58c2c66b14ec336c1c9fbe11471. This issue was quite complex, so the commit had to establish data structures for looking back to the last line and ahead to the next line. Based on that, logic had to be implemented, which takes several constellations into account. Hopefully, all relevant constellations are covered. All tests are green.
I'm going to re-test it with the example provided by you in this issue thread. If that file parses successfully, I'm going to close this thread.
However I see, that in #37 you provided a similar issue, which potentially is fixed also by 2cbdd8eada9fa58c2c66b14ec336c1c9fbe11471. I'll check that as part of #37.

Added a passing unit test similar to the one provided by you 047512dee785314430a52ad36aac977d97a91b19.
Thanks again!

YES - thanks, the parser works, though ... (sorry)
Could you possibly add a BLANK between the literals, meaning
display '=======' '================'
so that no to quotes appear close to each other => IBM-Compiler does not like that all too much

Ok, no problem. Added in ea1322a1c7b4a203191d21fa0091aefc4ad188ee. Now it is display '=======' '================'.
There could be other edge cases with a combination of numeric and string literals such as display 1'================'. I would suggest to wait, whether such cases provoke errors, and fix on demand. The rule set for line indicators is already complex enough :-)


Merge back 0.5.5 patch release

Without this, we don't get the tag on master, and the latest HEAD indicates that we're running an outdated version.

I understand the need to merge back the tag, but I don't get exactly how this works.
Release 0.5.5 was a patch release on top of 0.5.4, where a few commits were cherry-picked from master. They are still in master, but in a different order. How can this tag go back into master at all?

the idea is that this makes the tag reachable from master branch, and I can see this fixes both my magit view as the annoying popup where latest HEAD was "not the latest version" :P
I'm not a git expert by any means though, so I can't comment more. Maybe there is a better way.

0 changes?

yes, because all of the changes happened to already be included on master.

bors r+


[Bug] Radioactive squiggles

Drawing long lines, especially within a small space, can make stroke width suddenly increase.
Shrinking the entire drawing causes these to become blown out of proportion. Screenshots:

These were made in https://beta.tldraw.com/r/todepond.com

A fix for this is on its way soon!

This has been fixed now! Thanks again for the report :)
(though I will miss those crazy squiggles)

Awesome! Thank you for fixing it!
RIP radioactivity


replace md5 NPM with Node.js crypto

https://github.com/uProxy/uproxy/issues/2464

This change is

:+1:


RFP - travis-cli

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://github.com/travis-ci/travis.rb
Direct download URL for the software / installer : https://github.com/travis-ci/travis.rb/releases/latest
Software summary / short description: This is the command line interface to interact with travis. You can read more on the project page. Travis CI is a well known and widely used CI/CD platform especially for open source repositories.
This is a package which is installed with gem. I suppose that means, that ruby has to be defined as a dependency.
Ruby luckily is a package already: https://chocolatey.org/packages/ruby

Notice to any upcoming maintainer, this request will require a request on ruby and installation to happen through a call to gem.

I will take up this. I have done an automatic updating package but when running in Appveyor, It gives an error like below
     Chocolatey v0.10.15 Attempting to push travis.1.8.8.nupkg to https://push.chocolatey.org An error has occurred. It's possible the package version already exists on the repository. (7.40s)

Is it due to anybody else working on this or is it reserved or something? But when I visit https://chocolatey.org/packages/travis I get a 404. Can anybody help on this?

It is possible that the package already exist but is hidden

@naveen521kk Have you packed Travis or the CLI? Your package name is travis not travis-cli.
See https://github.com/chocolatey/chocolatey.org/issues/613 for your issue.

@naveen521kk you are most likely being affected with a known problem on chocolatey.org (https://github.com/chocolatey/chocolatey.org/issues/613).
Unfortunately there isn't any known workaround AFAIK right now, the only thing you can do is to try again later.
@tunisiano187 even if the package is hidden (or unlisted, fully rejected, and so on) they will still show up when you go to the package url.

@pauby I would actually suggest that he would keep it with the travis id, as that would be consistent with what is used on other package managers (on linux): https://repology.org/project/travis/versions

I will try pushing it later. Also, I will keep the id as travis as it is consistent with other package manager.
Cheers

That error shows still now. Anything can be done?

Still doesn't allow me to push.

@naveen521kk I have just raised this issue on your repository:
https://github.com/naveen521kk/au-packages/issues/2
Which explains what is going on with this package.

Package has been successfully pushed. @gep13 Thanks for informing about that. :)

Approved


fix: Typo in README

A little note: fix:  is intended for bug fixes, this would be better as docs: xXX.


Use has_scope 0.7.0

Thank you for the pull request. Like explained in the README this gem is deprecated and it is not accepting new features.


Document the errors during nnUnet installation on rosenberg

These errors led to https://github.com/ivadomed/utilities/commit/1412fcdeff5b848f734858cb57148ba25914e818. I would suggest to document the history of the errors in this issue for track record.

The conda install pytorch torchvision pytorch-cuda=12.1 -c pytorch -c nvidia command installed pytorch CUDA correctly on romane but not on rosenberg.
romane:
$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2023 NVIDIA Corporation
Built on Fri_Jan__6_16:45:21_PST_2023
Cuda compilation tools, release 12.0, V12.0.140
Build cuda_12.0.r12.0/compiler.32267302_0
$ conda -V
conda 23.11.0
$ conda create --name nnunet_test python=3.9
$ conda activate nnunet_test
$ conda install pytorch torchvision pytorch-cuda=12.1 -c pytorch -c nvidia
$ python -V
Python 3.9.18
>>> import torch
>>> print(torch.cuda.is_available())
True

rosenberg:
$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2023 NVIDIA Corporation
Built on Fri_Jan__6_16:45:21_PST_2023
Cuda compilation tools, release 12.0, V12.0.140
Build cuda_12.0.r12.0/compiler.32267302_0
$ conda -V
conda 23.3.1
$ conda create --name nnunet_test python=3.9
$ conda activate nnunet_test
$ conda install pytorch torchvision pytorch-cuda=12.1 -c pytorch -c nvidia
$ python -V
Python 3.9.18
$ python
>>> import torch
>>> print(torch.cuda.is_available())
False

The CUDA version looks the same. The only difference is in the conda version.

I also tried conda install pytorch torchvision pytorch-cuda=11.7 -c pytorch -c nvidia on rosenberg (because my old conda env has pytorch-cuda=11.7), but conda seems unable to resolve environment (killing after 20 minutes):
$ conda install pytorch torchvision pytorch-cuda=11.7 -c pytorch -c nvidia
Collecting package metadata (current_repodata.json): \ WARNING conda.models.version:get_matcher(546): Using .* with relational operator is superfluous and deprecated and will be removed in a future version of conda. Your spec was 1.7.1.*, but conda is ignoring the .* and treating it as 1.7.1
done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Collecting package metadata (repodata.json): \ WARNING conda.models.version:get_matcher(546): Using .* with relational operator is superfluous and deprecated and will be removed in a future version of conda. Your spec was 1.8.0.*, but conda is ignoring the .* and treating it as 1.8.0
WARNING conda.models.version:get_matcher(546): Using .* with relational operator is superfluous and deprecated and will be removed in a future version of conda. Your spec was 1.9.0.*, but conda is ignoring the .* and treating it as 1.9.0
WARNING conda.models.version:get_matcher(546): Using .* with relational operator is superfluous and deprecated and will be removed in a future version of conda. Your spec was 1.6.0.*, but conda is ignoring the .* and treating it as 1.6.0
done
Solving environment: |

@namgo do you have any clue as to what could be different in our systems to explain such a discrepancy?

I don't know immediately, the first thing I notice is that the versions of conda differ between romane and rosenberg.
Both are installed in /usr/local/miniforge3/condabin/conda so it's not an environment variables issue.
https://github.com/neuropoly/computers/commit/5e6781a0d5b1c752a98921d3145666de629e6ca3 is probably the culprit, the update process was removed from ansible deployments. I'm running the update now.

Thanks for digging in @namgo!
I can confirm that I was able to successfully install pytorch-cuda=12.1 on rosenberg after you updated conda:
$ conda -V
conda 23.11.0
$ conda create --name nnunet_test python=3.9
$ conda activate nnunet_test
$ conda install pytorch torchvision pytorch-cuda=12.1 -c pytorch -c nvidia
$ python
Python 3.9.18 | packaged by conda-forge | (main, Dec 23 2023, 16:33:10)
[GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> print(torch.cuda.is_available())
True

I updated our installation instructions in https://github.com/ivadomed/utilities/commit/f366b72a243b620d1a8c331a014ab542568d3b84.

amazing work @namgo !


Decay penalty localization problem

An instructor reports the following bug:
The error message they quoted was
translation missing: en.submission_rules.penalty_decay_period_submission_rule.overtime_message
It doesn't seem to have affected the submission process itself (this student's submission was there), but I figured I would mention it in case it's something that would be easy to fix.

Working on this.


Feature Request: Group collections

First thanks for adding the option for view collections.
It would be helpful to Group the collections. Before the View Collection Type I guess this would not be so important. However, since we can create views, it would be helpful to be able to add groups whereby we can assign different collections to different groups.
If this is too much of a work, maybe start with grouping automatically the Base, Auth and View collections.
Thanks for all the hard work, and it's really amazing backend database, and the UI? is first class.

I'm not sure that I understand what do you mean by "grouping automatically the Base, Auth and View collections". Could you elaborate and/or give an example?

I'm closing this issue for now.
If you are asking for visual collections grouping in the Admin UI, aka. to have categories or folders, for now this is not planned since it may clutter the interface unnecessary.
Feel free to provide more details to your feature request but for now the above remains out of the v1 scope.

Sure, sorry for not making myself clear.
For axample in the list of all collections we will have something like this.
Auth Collections ( Name of the Group )
Users,
Tenants
any other Auth collection type
Base Collections ( Name of the Group )
Companies
Clients
Jobs
any other Base collection type
this list can grow to a lot of queries, and would be helpful if they are listed in a Group.
View Collections ( Name of the Group )*
all_users
posts_with_total_comments
I hope this is clearer :-)
If we can also create additional sub Group names in the views, this would help list the queries/views we create under our own Collection Group Name
for example Under Default Views Collection*, we can create additional Group Names for example Users View, Company Views, Accounts Views and so on.....
I sugests when we create or modify a collection, we can choose which Group to list the collection under. Or Drag and Drop :-)

I'm closing this issue for now.
If you are asking for visual collections grouping in the Admin UI, aka. to have categories or folders, for now this is not planned since it may clutter the interface unnecessary.
Feel free to provide more details to your feature request but for now the above remains out of the v1 scope.

I like this idea, but I can understand that it would clutter the UI. Do you think we could at least be able to rearrange the order of the collections?


Normalize paths for tests

On Windows the gltfPipelineSpec tests fail because the path uses backslashes instead of forward slashes. Normalize the paths so this doesn't happen.

Coverage remained the same at 94.049% when pulling c22bc06b0457d1bea2684fd61c37ef5d9997b465 on fix-pipeline-spec-test into 30a5565f26c8f5faaec020f34769b228338e171d on master.


Seek based on TotalMilliseconds, not ms component.

The Milliseconds property of a TimeSpan is just the milliseconds component (i.e., the fractional part of the second component).
This change uses the TotalMilliseconds property, which is the total milliseconds in a TimeSpan (and casts the value to a long, since it is a double).

Thanks! Good catch!


Option to prevent 'Untitled-1' when starting

Normally I don't need the untitled file when starting. If I want one, I can press Ctrl+N. It would be nice to have this as an option.

Even with the new Welcome page, I still get the Untitled-1 document and the Welcome tab.

Only having one of the two is tracked with #19689

I second this, an option would be nice. Something like workbench.startup, which would replace the current workbench.welcome.enabled with the following values:

none : start empty
welcome : show the Welcome page on startup
new-tab : show a new 'Untitled' tab on startup

@bpasero I'm about to replace the existing workbench.welcome.enabled boolean with a workbench.startupEditor enum with none, welcomePage (default) and newUntitledFile as possible values.
@Tyriar suggests to instead keep the boolean and simply make the new untitled file show in a 'preview' editor that would disappear when another editor opens (if it has no content at that point).
I'm more leaning towards the enum setting with 3 values, that is more explicit than the sometimes magical preview editor and will be easy to reuse if we find more startup scenarios we want to cover. What do you think?

For what it's worth @chrmarti, I like the idea of doing both. Have an enum value with the 3 options you suggested, and also change the behavior of the newUntitledFile option so that it shows in a "preview" editor. Having a blank tab open at startup can be convenient, but it doesn't typically make sense to keep it around when opening other files/projects (when it has no content).

What is the advantage of an blank tab vs. no tab?

What is the advantage of a blank tab vs. no tab?

Untitled file: Can start typing immediately, needs to be dismissed explicitly before it goes away.
Untitled "preview" file: Can start typing immediately, goes away if it hasn't been touched and another file is opened.
No tab: looks nice, shows common keybindings for new users:

I wasn't aware of the "untitled preview file" one. It sounds like we could have a single option with any of the 4 starting settings: Untitled-1 file, welcome screen, preview file, or nothing at all.

@Bill-Stewart I believe Untitled "preview" file would be a new concept. I'd prefer we opted on simplicity in this case, having either 2 or 3 options for the setting.

I'm happy with whatever, as long as we can have a "no tab" startup, which was my original intent.

@Tyriar Sounds like we are good with the 3 options setting? If so, I would like to push that and look into making the untitled file a preview editor separately.

@chrmarti good by me if this issue is wanted by people. I created https://github.com/Microsoft/vscode/issues/29474 to follow up the untitled preview concept as it's an improvement and a separate piece of work.

Sounds good to me also, thank you!


SSE support?

Are there any plans to support Server-Side Events in Wildfly?

we do not use github for issue tracking but jira at https://issues.jboss.org/browse/WFLY
for general discussion and questions you can use user forums https://developer.jboss.org/en/wildfly
for development discussions please use developer mailing list https://lists.jboss.org/mailman/listinfo/wildfly-dev


Fix VS editor's "Create Function" dialog

Fixed inputs not being completely cleaned up.
Made inputs be created in a ScrollContainer.
Minor touch-ups and visual enhancements.

Conflict fixed.

Thanks!


Release a version for terraform 0.13

The latest tag (4.2.0) is not compatible with terraform 0.13

https://github.com/terraform-google-modules/terraform-google-lb-http/pull/113
Needs a maintainer review I guess

The release seems to be stuck @jeremad ?

I am not maintainer. I am a basic user, waiting for a release :)


⚠ Mobitopup has degraded performance

In 3f81389, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 6756 ms

Resolved: Mobitopup performance has improved in dff8722.


twitter still requests token when consumer_key/secret not set

It has been observed on some installations of this plugin that where are set to empty, the plugin still attempts to open a connection and retrieve a token from twitter. This then appears to loop every second applying alot of load to the codebird-js api.
consumer_key: '',
consumer_secret: ''
A check should be added, that if a key or secret is not provided no initialisation of the script is attempted.

Why do you need to keep twitter configuration parameters ? If you don't need to show twitter posts, just remove the twitter configuration.


Issue when use SkeletonModification2DCCDIK

Godot version
4.0
System information
windows 10,  ryzen 5, radeon graphics vega 11, redering in every options
Issue description
I try to create a arm, I used polygon2d to the texture and after joined to the skeleton. Everything works until I add a modification to skeleton2d, I used SkeletonModification2DCCDIK and when I check "enable constraint", the texture increase and blicking until disappears. Sometimes this modification works but if I try to change the scale of the main node the problem with the texture it happens again. I dont use any script just nodes.

this is an example when only check the enable constraint

and this is a example the modification works but if I try to modify the scale of the main node the problem appears again

Steps to reproduce
1 create a node2d
2 add polygon2d to textures
3 add skeleton 2d and bones what need
4 add skeleton to polygon 2d
5 overwrite rest pose skelton2d
6 add  SkeletonModification2DCCDIK to skeleton2d
7 check "enable constraint" to any join data change the values
I case that this step works, try to change the scale of the main node only one axis
Minimal reproduction project
godot40issue.zip

The tip nodepath must not be a bone that is part of the IK chain. Add a Marker2D on your tip bone and assign that to Tip Nodepath


adding "-" as a legal seperator in identifiers section

This will help in comparing some linux kernel versions.  Ubuntu, for example, releases kernel version for 14.04, kernel v3, in the form of "3.13.0-76-generic" and "3.13.0-141-generic".  For 16.04 they have for kernel v4, "4.4.0-1049-aws" and so on.
Currently, they will not compare as expected since they are not decomposed on the dash.
This makes the identifiers work with the dash on the pre section only to support this syntax.

Thanks so much!


bluetooth: tester: LE Audio: Fix sending ISO data

The host app should increment the sequence number within SDU interval whether it has any data to send data to the controller or not.

I rebased and fixed some build errors introduced after recent updates.

@mkasenberg does this fix https://github.com/zephyrproject-rtos/zephyr/issues/58325 ?

@mkasenberg does this fix #58325 ?

Yes


Circuit breaker solution

Reference: #22
Implemented a circuit-breaker solution.
Broker options:
circuitBreaker: {
	enabled: false,
	maxFailures: 5,
	halfOpenTime: 10 * 1000,
	failureOnTimeout: true,
	failureOnReject: true
}

Coverage decreased (-0.4%) to 99.0% when pulling 0b3c4928b7aac85fe0adfeec52c03378dfdd217b on circuit-breaker into 51781e7f61d05a953e425d013a384fb9d01fc41a on master.

Coverage increased (+0.1%) to 99.5% when pulling dd9bd1fc0052ca7efbed3aebfb7d25a9f936dd23 on circuit-breaker into 51781e7f61d05a953e425d013a384fb9d01fc41a on master.

Coverage increased (+0.5%) to 99.916% when pulling 797587cdb941fa1e8896df0ef9ea80eb0e8f0fa4 on circuit-breaker into 51781e7f61d05a953e425d013a384fb9d01fc41a on master.

Coverage increased (+0.5%) to 99.916% when pulling b89f10e43cfbbae7381159b3838bd8eda4696da3 on circuit-breaker into 51781e7f61d05a953e425d013a384fb9d01fc41a on master.

Coverage increased (+0.5%) to 99.916% when pulling 552eebea232bd8585abdfed4f6835fa2ecef8390 on circuit-breaker into 51781e7f61d05a953e425d013a384fb9d01fc41a on master.

Coverage increased (+0.5%) to 99.916% when pulling be65dccaeb530bc74fa64fed3f07ceb4c48da425 on circuit-breaker into 51781e7f61d05a953e425d013a384fb9d01fc41a on master.


report

Type: Bug
there isn't any extension
VS Code version: Code 1.74.0 (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T16:38:16.075Z)
OS version: Windows_NT x64 10.0.16299
Modes:
Sandboxed: No

Can you please elaborate more about the issue?  If possible, please try tagging screenshots along with the issue.
Thanks.

This seems to be same as #533 which was created at around the same time. The extensions did not load as the requests to Gallery CDN were failing. This turned out to be a temporary issue. The users who original reported it are no longer seeing it. I will close this one.
@harunsalman02, if you are still facing this issue, please follow the steps as I mentioned in https://github.com/microsoft/vsmarketplace/issues/540#issuecomment-1411490797 and we will reconsider. It would also be helpful if you can add a comment below stating whether the issue is fixed or still persists.


implement ctag/etag based sync from (and maybe to) server

Hi,
the (old fashioned) sync-flow is described http://sabre.io/dav/building-a-caldav-client/ - it uses etags for event change tracking.
Could someone elaborate (give hints where what to change) if I want to have :
most important

date_search/events could return etag:

alongside calendar-data (for initial sync)
without calendar-data (to check for changes)
ps.: date_search seems to be generalization of events (but for now not DRY)?

less important

ctag
getctag, which is from "http://calendarserver.org/ns/" namespace which I don't find mentioned in source (should be similar to getetag)...

calendar-multiget REPORT (for batched get)

if-Match header support  (for "to server" update/delete)

ps.: I need this for SOGo and Google CalDaV API

At least I don't have any time to look into this in August, and probably not in September either.  In general I'm pretty liberal on accepting pull requests, though the test code needs to be run flawlessly against multiple server implementations before we're making a new minor-release.

my monkey-patch'es to use current caldav with google to sync via ctag/etag
https://gist.github.com/dz0/dbac261cf85b82a8146d41d2da21c6e8
ps.: sorry no time to play with patching caldav directly, but hopefully you can pick what seems worth

Sort of duplicated in #81 - and there it's written that sync-collection is to be used rather than ctag.  Hm.

https://github.com/apple/ccs-calendarserver/blob/master/doc/Extensions/caldav-ctag.txt is quite clear that ctag is deprecated.  I'll close this one and follow up with sync-collection in #87


[@xstate/react] rc.4 doesn't run actions when sending events from parent to child

Description
<EMAIL_ADDRESS>causes an issue with sending events from a parent machine to a child machine.
Expected Result
Sending an event from the parent machine to the child machine causes the child to transition and fire any actions associated with the transition.
Actual Result
The child seems to transition to the new state but doesn't run the actions
Reproduction
Steps to reproduce:

Go to sandbox https://codesandbox.io/s/xstate-react-reddit-example-with-actors-x4nk0?file=/src/machine.js
Using rc.4, clicking the button doesn't run the action
Using rc.3 (make sure to refresh sandbox), clicking the button runs the action

Additional context
Happens in<EMAIL_ADDRESS>Works in<EMAIL_ADDRESS>

Verified this - it's because invoked machines inherit options from the parent, and in rc.4, execute is set to false (because React executes side-effects in useEffect) and that is set in child interpreters as well.
The fix here is to not inherit the execute option. Will fix soon.


ToCode Solution: תרגול תחביר

please submit all the exercises in this part

As we are getting close to the finish line in this course I'd like to make sure there are no open questions left. If something is unclear with this or another exercise, do ask about the part that is unclear. I'll explain it in more detail.


make dm.EMNISTDataLOader

(Moved from https://github.com/PyTorchLightning/pytorch-lightning/issues/8110.)
It would be useful to have a DM for https://www.tensorflow.org/datasets/catalog/emnist.
Motivation
EMNIST is a much better dataset than MNIST, since it has more classes (0-9, a-z, A-Z), more data (4x), and more inherent ambiguity, yet it still easy to deal with computationally.

@murphyk Reopening this issue as I believe this would be a great addition to Bolts!


Daily number of blocks proposed from Flashbots Mev-Boost Relay blocks & Percentage of blocks proposed by Flashbots Mev-Boost Relay vs. other by day is redundant

As the title describes, I think these two graphs are redundant in the information they convey. The daily # of blocks proposed from mev-boost relay vs other isn't super helpful because the daily number of blocks stays the same every day (7.1k), so the percentage makes more sense. I was going to propose that we remove the daily number in favor of the percentage, but I see that we already have that below somewhere. Probably don't need both.

[ ] Remove Percentage of blocks proposed by Flashbots Mev-Boost Relay vs. other

The duplicate chart is removed. Issue can be closed


[SPARK-47121][CORE] Avoid RejectedExecutionExceptions during StandaloneSchedulerBackend shutdown

What changes were proposed in this pull request?
This PR adds logic to avoid uncaught RejectedExecutionExceptions while StandaloneSchedulerBackend is shutting down.
When the backend is shut down, its stop() method calls executorDelayRemoveThread.shutdownNow(). After this point, though, it's possible that its StandaloneDriverEndpoint might still process onDisconnected events and those might trigger calls to schedule new tasks on the executorDelayRemoveThread. This causes uncaught java.util.concurrent.RejectedExecutionExceptions to be thrown in RPC threads.
This patch adds a try-catch to catch those exceptions and log a short warning if the exceptions occur while the scheduler is stopping. This approach is consistent with other similar code in Spark, including:

https://github.com/apache/spark/blob/9b53b803998001e4b706666e37e5f86f900a7430/core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala#L160-L163
https://github.com/apache/spark/blob/9b53b803998001e4b706666e37e5f86f900a7430/core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala#L754-L756

Why are the changes needed?
Remove log and exception noise.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No new tests: it is difficult to reliably reproduce the scenario that leads to the log noise.
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master for Apache Spark 4.0.0.


Implements binary search for MultiStream & MultiStreamFree & Server scenarios.

There are two things are in progress.

A relation between the number of outstanding queries and target qps of server scenario. For now, I have no idea to find the exact equation of the number of outstanding queries that guarantee monotonous of the result of the Server scenario.
In my opinion, It is proper that the outstanding queries equation is handled by another issue.
unittest. This kinds of settings aren't familiar to me, but working on it to make test cases for the code.

Adopted all comments :)

Thanks Sol!


Update function-python-ai-textsummarize README

Update function-python-ai-textsummarize README to use azd init and azd up instead of azd up --template according to https://github.com/Azure/azure-dev/issues/1769.
@jongio, @rajeshkamal5050 for notification.

@jongio @paulyuk can you review and approve?

@paulyuk can you merge it?

Hi - when the user starts from a Git repo like this we should embrace the git flow (clone, restore, run, azd up) and not "initialize from template" which i would want to do if I didnt have a repo.


Rounded selection is broken

editor.roundedSelection is broken

If our selection doesn't span multiple lines, the selection is still squared.

@hashhar I cannot reproduce under windows:

Are you using a specific font or a specific OS?

Upon revisiting this I decided to check again and this time I was able to notice that the reason why the selection seems not rounded is because it gets highlighted twice (once for the selection and the other for the feature where the same text if found anywhere in the file is also highlighted) and then it feels like it's by design.
The wrong one....

The one where it gets fixed after I extend my selection....

I'm using Windows 10 Home November Update. No custom font, no display scaling and the font size is also set to default.

@hashhar Thank you for the additional details


SegmentControl UI not appearing in iOS Simulator

I got an error when importing SegmentedControl.FormsPlugin.Android;

@hyprstereo could you describe more detail about your problem?
I created a really simple project with this control and for iOS and Android, it's working as I'd expected.
Segmented Control Test Project


Update MutatingWebhookConfiguration example to match surrounding text

Currently the explanation text says "would match a CREATE of any resource with the label foo: bar:" but it was previously only matching resources, not subresources.
This rectifies that

Replaced by https://github.com/kubernetes/website/pull/39305


parse_quote! fails for Punctuated<Arm, Comma>

this code (minimal example)
/* using: syn = { version = "2.0.90", features = ["full", "extra-traits"] } */

use syn::{parse_quote, punctuated::Punctuated, token::Comma, Arm};

fn main() {
    let i: Punctuated<Arm, Comma> = parse_quote!(
        true => 12,
        false => 13,
    );
    println!{"{i:#?}"};
}

results in an error
  zsh ❯ RUST_BACKTRACE=full cargo run --example tt
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s
     Running `/Users/vic1707/Desktop/tests/target/debug/examples/tt`
thread 'main' panicked at examples/tt.rs:4:37:
expected `,`
stack backtrace:
   0:        0x10302c538 - std::backtrace_rs::backtrace::libunwind::trace::h6285d60e8a2c022a
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/../../backtrace/src/backtrace/libunwind.rs:116:5
   1:        0x10302c538 - std::backtrace_rs::backtrace::trace_unsynchronized::h21fc036d4b8dd7fe
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:        0x10302c538 - std::sys::backtrace::_print_fmt::h69654d1f9cd065f2
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/sys/backtrace.rs:66:9
   3:        0x10302c538 - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::h7adefaad4a31afc0
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/sys/backtrace.rs:39:26
   4:        0x103040448 - core::fmt::rt::Argument::fmt::h42151196bb7af094
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/fmt/rt.rs:177:76
   5:        0x103040448 - core::fmt::write::h381c0b0ce6ab972a
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/fmt/mod.rs:1186:21
   6:        0x10302a7b8 - std::io::Write::write_fmt::h75af97148630d8d3
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/io/mod.rs:1839:15
   7:        0x10302c3ec - std::sys::backtrace::BacktraceLock::print::h8baf33e22611de71
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/sys/backtrace.rs:42:9
   8:        0x10302d2a4 - std::panicking::default_hook::{{closure}}::h369c7295ef58c5b1
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:268:22
   9:        0x10302d0e8 - std::panicking::default_hook::h50746358288a9d6a
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:295:9
  10:        0x10302da58 - std::panicking::rust_panic_with_hook::h7d795911432661cb
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:801:13
  11:        0x10302d70c - std::panicking::begin_panic_handler::{{closure}}::h36f15310ecbde379
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:674:13
  12:        0x10302c9fc - std::sys::backtrace::__rust_end_short_backtrace::heed121414170e0c7
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/sys/backtrace.rs:170:18
  13:        0x10302d3c4 - rust_begin_unwind
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:665:5
  14:        0x10304651c - core::panicking::panic_fmt::h17b1b80ec02ffd19
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/panicking.rs:74:14
  15:        0x102f18ae0 - core::panicking::panic_display::h9cf75ef08a85cd9a
                               at /Users/vic1707/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/panicking.rs:264:5
  16:        0x103044ae4 - syn::parse_quote::parse::panic_cold_display::hc7b681656d96d5d8
                               at /Users/vic1707/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/panic.rs:100:13
  17:        0x102f19b4c - syn::parse_quote::parse::h5d8560acbbbb3812
                               at /Users/vic1707/.cargo/registry/src/index.crates.io-6f17d22bba15001f/syn-2.0.90/src/parse_quote.rs:121:21
  18:        0x102f19850 - tt::main::hbbf10e05f160921c
                               at /Users/vic1707/Desktop/tests/examples/tt.rs:4:37
  19:        0x102f1a070 - core::ops::function::FnOnce::call_once::h1077c19304ab5bf5
                               at /Users/vic1707/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
  20:        0x102f18e74 - std::sys::backtrace::__rust_begin_short_backtrace::h33eda7daadad9c5b
                               at /Users/vic1707/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/sys/backtrace.rs:154:18
  21:        0x102f18e0c - std::rt::lang_start::{{closure}}::hcf32816904f70aed
                               at /Users/vic1707/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:195:18
  22:        0x103028c18 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h1f2e4bfdaa1e9f55
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/ops/function.rs:284:13
  23:        0x103028c18 - std::panicking::try::do_call::hf5f5fcb9152f95d7
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:557:40
  24:        0x103028c18 - std::panicking::try::hc37bea4722ea5011
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:520:19
  25:        0x103028c18 - std::panic::catch_unwind::h59a2106aa502b0e8
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panic.rs:358:14
  26:        0x103028c18 - std::rt::lang_start_internal::{{closure}}::h130ec563acce7cfd
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/rt.rs:174:48
  27:        0x103028c18 - std::panicking::try::do_call::h406987cb4ab94a01
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:557:40
  28:        0x103028c18 - std::panicking::try::h3095cbba23c315df
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:520:19
  29:        0x103028c18 - std::panic::catch_unwind::hc35a49412f9c6ccf
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panic.rs:358:14
  30:        0x103028c18 - std::rt::lang_start_internal::h77891a2543177e4b
                               at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/rt.rs:174:20
  31:        0x102f18dd8 - std::rt::lang_start::h912d3342bd4e7f74
                               at /Users/vic1707/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:194:17
  32:        0x102f199bc - _main

Code is parsed properly when one arm is here, but the second you add another one it fails (trailing comma or not).
I'll clone syn and try to find why + a solution but would love some advices or a fix if someone already knows where the problem is

fn main() {
    let i: Punctuated<Arm, Comma> = parse_quote!(
        true => 12,,
        false => 13,
    );
    println!{"{i:#?}"};
}

is getting parsed, this is incorrect syntax but it "works"
[
    Arm {
        attrs: [],
        pat: Pat::Lit {
            attrs: [],
            lit: Lit::Bool {
                value: true,
            },
        },
        guard: None,
        fat_arrow_token: FatArrow,
        body: Expr::Lit {
            attrs: [],
            lit: Lit::Int {
                token: 12,
            },
        },
        comma: Some(
            Comma,
        ),
    },
    Comma,
    Arm {
        attrs: [],
        pat: Pat::Lit {
            attrs: [],
            lit: Lit::Bool {
                value: false,
            },
        },
        guard: None,
        fat_arrow_token: FatArrow,
        body: Expr::Lit {
            attrs: [],
            lit: Lit::Int {
                token: 13,
            },
        },
        comma: Some(
            Comma,
        ),
    },
    Comma,
    Arm {
        attrs: [],
        pat: Pat::Lit {
            attrs: [],
            lit: Lit::Bool {
                value: false,
            },
        },
        guard: None,
        fat_arrow_token: FatArrow,
        body: Expr::Lit {
            attrs: [],
            lit: Lit::Int {
                token: 13,
            },
        },
        comma: Some(
            Comma,
        ),
    },
]

I feel like the comma is part of the Arm struct itself, so punctuated requires a second one.
This makes sense but also implies parse_quote! can't parse multiple match arms or am I mistaking it ?

The optional trailing comma is already included inside Arm, so Punctuated<Arm, Token![,]> is never a type that would make sense to use.
You can use Vec<Arm> instead, which is also the form in which Expr::Match holds the match arms.

Thank you for this, I didn't consider asking for Vec<Arm> it works great 👍
quick question:
a Vec<Attribute> like that works
let i: Vec<Attribute> = parse_quote!(
        #[derive(Deserialize, Serialize)]
        #[serde(transparent)]
);

but
let i: Vec<Arm> = parse_quote!(
        true => 12
        false => 13
);

doesn't,
let i: Vec<Arm> = parse_quote!(
        true => 12,
        false => 13
);

does, assigning the comma to the first arm.
Is it expected?
It kinda messes things up when quoting back that vec in quote! with repeat patterns
(workaround being to put the trailing comma for all arms and not use the comma as a separator in the repeat).
ie:
let i: Vec<Arm> = parse_quote!(
        true => 12,
        false => 13,
);
println!{"{i:#?}"};
let b: Vec<Arm> = parse_quote!(
        true => 12,
        #(#i)*
);
println!{"{b:#?}"};

The repeat should not be adding new comma separators. The individual arms will already contain a trailing comma if required. Not all kinds of expressions in an arm require a trailing comma (the Rust grammar for this is complicated).
If you are not sure whether arms have a comma, for example because you are combining arms from multiple parse_quote, then you could explicitly add a comma into all arms beforehand. for arm in &mut arms { arm.comma = ... }

Ok thank you 👌


Question: Rollback last finished migration ?

Some pr are merged in a different order than the migration id. This causes situations where there is no possibility to rollback last finished migration.
Example:
Status:
 Status  [Migration ID]  Started              Finished             Migration Name
----------------------------------------------------------------------------------
     up<PHONE_NUMBER>0527  2017-11-07 10:40:20  2017-11-07 10:40:20  Init
     up<PHONE_NUMBER>0835  2018-05-08 13:45:37  2018-05-08 13:45:38  A
     up<PHONE_NUMBER>2825  2018-05-24 11:11:23  2018-05-24 11:11:25  B
     up<PHONE_NUMBER>0510  2018-05-23 16:02:55  2018-05-23 16:02:55  C

Migrations: Init -> A -> C -> B
How to rollback only "B"  ?

@mablo Did that make sense? I accidentally closed the issue before waiting on feedback.

Closing due to lack of activity or out of scope. If there is new interest, please open a PR.


Adding flags to the (sbatch) submit command

Hey, I am trying to add the --wait flag to the sbatch submit command. I tried s.run(_cmd="sbatch --wait"), but that did not work. Thank you!

Okay, I guess I could just do s = Slurm("job-name", {"W": "", "partition": "my-partition"})


Examples for range and filter view

I added a couple more view examples.

(feel free to squash the last commit)

Thx.


5.x release changelogs are not documented in the Releases list

Description
There are no release notes or explanations for breaking changes/version bumps for any 5.x release currently on the Releases tab. And CHANGELOG.md indicates that is the location for changelog information.
Steps to Reproduce

Go to releases tab

Expected behavior
A list of breaking and non-breaking changes with each release
Suggested solution(s)
Add release notes

Yep, it's in progress.

Closed by https://github.com/piotrwitek/typesafe-actions/releases/tag/v5.1.0


Bad Gateway on Deployment

Only 1 ApiServer causes downtime on deployment?

This was fixed by adding maxSurge and minUnavailable options to the deployment of the apiserver. With only 1 replica the default settings cause a downtime when deploying a new image.
This caused a prominent error in the deployment pipelines: No consumer for text/html. The problem here was actually the parallel deployment of the admin apiserver and concurrently fetching credentials for it in the staging pipeline. Fix now.
In addition this issue surfaced a problem with nginx' default backend. It responds with text/html error pages even if json is requested. Would be great if it responded in json for the various (javascript) clients.

See #80


Scheduling resources fails if timezone is selected other than UTC

The custom service setup that creates the period and creates the schedule is not working when we provide the timezone value anything other than UTC.
The error received is Invalid Physical resource ID.
The lambda is initiated by the values sent by cfn. Any idea why this is happening. ?

@bibin-biju Just so that I understand this correctly is this happening when the stack is being created for the instance scheduler or when the custom resource is being setup for a specific schedule. If it is the later can you confirm if the field "ServiceToken" is configured with the right ARN for the lambda.

@gockle
Nikhil,
This happens when the custom service setup is creating schedules.
Yes, the service token is given correctly.

The Error received is Invalid Physical resource Id.

Bibin
Thanks for the information can you validate the template in the cloud formation designer and confirm if all the fields are correctly populated, I tried creating a custom schedule and was able to do it with other timezone.

Nikhil,
We have custom schedukes like Week end stop where it will create three periods for continous running on Mon thru Fri and stop only on Sat and Sun.
The lamda that create these schedules and periods is provided by aws. It has only certain changes i believe. Recently we converted the entire code to 3.7 by using the py2to3 module.
This is happening since then. Do you know why the physical resource id is fetched invalid. Or in which part of the code it is configured? The lamda that we use is exactly the instance scheduler lambda with certain changes in schedule names.

@Bipin what is the version of the instance scheduler is being used?


Add .editorconfig file

This is a request out of personal preferences. An Editor config prevents from clashes between editors. Maybe an .editorconfig file like this:
# http://editorconfig.org

root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true

[*.{py,rst,ini}]
indent_style = space
indent_size = 4

[*.yml]
indent_style = space
indent_size = 2

@glemmaPaul this is an interesting idea.  Here's my thoughts:
Benefits:

The styles you've proposed are overwhelmingly used by the community.
Having an .editorconfig is really convenient.
If someone doesn't like our configuration, its super easy to change it to suit their own needs.
An .editorconfig is great to consistently represent code across developers in projects where configuration may vary.

Concerns:

Configuring your editor is already handled on a personal level by your own editor's configuration.
We're already forcing general style guidelines with flake8, so do we need to go further?
An .editorconfig really comes down your own preference at the end of the day, so there's no objective answer about the right configuration; its always subjective.
We're tying to make this project a generic scaffolding tool for the community. By adding an .editorconfig with our preferences we could push those preferences on others who want to use the project but who don't share our coding style.

@glemmaPaul What are your thoughts here?
Could you give me a little more information about how this would make your personal workflow better antidotally?

@glemmaPaul any thoughts on this?

@glemmaPaul  closing because of lack of activity. Happy to resume the conversation in the future :smile:


Release Candidate 2022-06-14

New terms added:

ID
Label

OBI:0002830
catheter

OBI:0003297
tyramide signal amplification sequencing assay

OBI:0003298
DNA adenine methyltransferase identification assay

OBI:0003299
DamID-seq

OBI:0003300
nucleolus-associated domain sequencing assay

OBI:0003301
DNase Hi-C assay

OBI:0003302
micro-C assay

OBI:0003303
single cell combinatorial indexing Hi-C assay

OBI:0003304
single nucleus Hi-C assay

OBI:0003305
single cell Hi-C assay

OBI:0003306
bulk Hi-C assay

OBI:0003307
multi-contact Hi-C assay

OBI:0003309
transposase-mediated analysis of chromatin looping assay

OBI:0003310
split-pool recognition of interactions and tag extension assay

OBI:0003311
DNA split-pool recognition of interactions and tag extension assay

OBI:0003312
RNA-DNA split-pool recognition of interactions and tag extension assay

OBI:0003313
genome architecture mapping assay

OBI:0003314
mapping RNA-genome interactions assay

OBI:0003315
assay measuring epitope specific amphiregulin production by T cells

OBI:0003316
ELISA measuring epitope specific amphiregulin production by T cells

OBI:0003317
perforin release during T cell degranulation

OBI:0003318
granzyme A release during T cell degranulation

OBI:0003319
granzyme B release during T cell degranulation

OBI:0003320
granulysin release during T cell degranulation

OBI:0003321
venous blood microbiology assay

OBI:0003323
high throughput multiplexed assay measuring binding of a B cell epitope:antibody complex

OBI:0003324
high throughput multiplexed assay measuring binding of a T cell epitope:MHC:TCR complex

OBI:0003325
high throughput multiplexed assay measuring binding of a MHC:ligand complex

OBI:0003326
high throughput multiplexed assay measuring MHC ligand processing and presentation

OBI:0003365
milk assay datum

OBI:0003366
organism diagnostic process

OBI:0003367
diagnosis of an organism

OBI:0003368
detection technique

OBI:0003369
assay kit

OBI:0003371
epitope specific XCL1 release by T cells

OBI:0003372
assay measuring epitope specific lymphotactin production by T cells

OBI:0003373
ELISA measuring epitope specific lymphotactin production by T cells

OBI:0003374
remote patient assessment

OBI:0003380
placental blood specimen

OBI:0003381
placental blood microbiology assay

OBI:0003382
placental blood microbiology datum

OBI:0003383
eukaryota in placental blood datum

OBI:0003385
has assay target context

Can we fix the definitions for these terms? They have "A induced sputum..." instead of "An induced sputum...". Thanks.
OBI:0003268
OBI:0003269
OBI:0003270
Everything else looks good.

I noticed that you are introducing your own biological process classes and placing them as subclasses of existing GO classes, e.g. "granzyme A release during T cell degranulation", in order to define assays
We discussed this internally (@pgaudet @thomaspd), we would propose that the assay is defined separately in terms of a measurement (granzyme A)  to support an inference T cell degranulation has occurred. So some triple like [OBI assay] “used to demonstrate the occurrence of” [GO BP] would give us a link to GO that is more inline with current curation practice, as it’s really about the role of an experiment as evidence for a biological inference.

@johnwjudkins' fixes are easy, but I'll hold off on this RC until OBI developers can discuss @cmungall's concern. I'll add it to Monday's agenda, but I won't be on that call.

I don't want to hold up a release - if you wish to proceed you always have the option of making changes later, I just wanted to make sure this was noted

We had a call with GO people not that long ago where we discussed this and explained why we do it this way and the explanation was accepted. It can be true that the protein being produced is not directly measured and we do not want two separate assays for when it is and when it is not. Also sometimes it is a release of pre-existing proteins.

Discussed on the OBI call 2022-07-11:
@cmungall Our understanding is that we got buy-in from GO on this modelling, as discussed here for example. We will release this modelling now, and if it needs to be fixed later please open an issue.
My plan is:

close this PR without merging
make the three small fixes @johnwjudkins requested
make a release -- no more review required


/pfs/inputs directory

What is the ask?
A /pfs/inputs directory
What is the goal / desired outcome?
So that I don't have to do inputs = [d for d in os.listdir('/pfs/') if d is not 'out'] (or some bash equivalent) as the first line of every pipeline
The /pfs/inputs directory contains a symlink to each input; For consistency, I'd also like to see /pfs/output be a symlink to /pfs/out
At some point in the future, I'd like to deprecate the use of inputs directly within /pfs

I don't think I like this. Adding extra paths under /pfs to support a particular type of iteration seems like it's not worth the clutter. Furthermore I don't think that this use case is that important to users, it's rare that users want to iterate through all of the inputs, normally each input has a name that's meaningful and so you handle it directly by name rather than needing to find it via iteration. This also would have a big downside in terms of backwards compatibility, users who are doing iteration over their directories would suddenly have these new paths inputs and output which would probably break their existing code.

Personally I’d like to see /pfs/in as the prefix to input data rather than just /pfs. I don’t think that’s an unreasonable request, though, it wouldn’t be symlinks or differ in any way from now except the base directory difference.
However, what I think would be more realistic and actually fit the flexibility of pachyderm far better would simply be to enable specifying where the  input data appears just like we already do for secrets.

If only for backwards compatibility reasons, we're not going to pursue this.


⚠ Multimedia BRN has degraded performance

In f1f7a6a, Multimedia BRN (https://mbrn.in/ping.html) experienced degraded performance:

HTTP code: 200
Response time: 6104 ms

Resolved: Multimedia BRN performance has improved in 6a72339.


Dev

Thanks for the pull request submission! I'm not sure of what the intent of these changes are though. It looks like merging this into master would transition some commits from our dev branch into the master branch a bit prematurely. Our 1.4.0 release will be out on Friday courtesy of @wolfthefallen, which will include merging all of the new commits from dev into master.
Until then if you'd like to use the changes in the dev branch check the beta testing instructions.


libnl.h?

Where can I get libnl/libnl.h for RHEL?  I "yum install libnl3" but there is no /usr/include/libnl installed.  Make keeps failing
/home/ec2-user/nff-go/dpdk/dpdk/drivers/net/mlx5/mlx5_flow_tcf.c:8:27: fatal error: libmnl/libmnl.h: No such file or directory"

@FOXNEOAdvancedTechnology have you tried yum install libmnl-devel too? This should install head to /usr/include/libmnl/libmnl.h.

Not in RHEL, all they have is the non-devel:
# yum list available  | grep mnl
libmnl.i686                   1.0.3-7.el7       rhui-REGION-rhel-server-releases

I found the source code for libmnl here:
https://www.netfilter.org/projects/libmnl/downloads.html


Disable the text editor temporarily while saving file

The text editor should be temporarily disabled while saving file.
Users should be able to choose in settings whether to switch this on or not, but this would be very useful and pretty simple to implement.
This can help users to prevent over CPU usage.
Thanks.

whats the benefit of it?

Clicking save several times (or the hotkey) will continuously overwrite the file, which could cause problems for large files that take a bit to save.

Personally I would not like to disable the editor as it lets me stuck in writing, but I agree to add some kind of internal value to prevent saves during one active save


Identify Optional and Non-optional Fields On The Daily Report Form

We know our stakeholders want some fields to be optional and others not, however, that is not currently implemented in our DailyReportForm component. More information will be provided later as we obtain those specifications from our stakeholders.

Everything is mandatory but don't prompt for treatment information from diseases that weren't mentioned for treatment cycles.


wrong server chosen with --server parameter

If I provide the serverid of the server that would currently be chosen by get_best_server as well (and it is up and running of course), it goes to a completely wrong server half way around the world?

root@DiskStation:/volume1/Daten/scripts# ./speedtest.sh --verbose
Retrieving speedtest.net configuration...
Testing from Unitymedia (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by Spacken.net (Hagen) [98.87 km]: 26.086 ms
Testing download speed................................................................................
Download: 293.39 Mbit/s
Testing upload speed................................................................................................
Upload: 20.23 Mbit/s

_

root@DiskStation:/volume1/Daten/scripts# ./speedtest.sh --list | grep Spacken
15431) Spacken.net (Hagen, Germany) [98.87 km]

_

root@DiskStation:/volume1/Daten/scripts# ./speedtest.sh --fav 15431
Retrieving speedtest.net configuration...
Testing from Unitymedia (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Retrieving information for the selected server...
Hosted by Ayera Technologies, Inc. (Modesto, CA) [8944.84 km]: 197.459 ms
Testing download speed................................................................................
Download: 68.91 Mbit/s
Testing upload speed................................................................................................
Upload: 15.51 Mbit/s

Note: speedtest.sh is just a wrapper script from https://github.com/rsvp/speedtest-linux

You should really report this to https://github.com/rsvp/speedtest-linux
That project hard codes the favorite server to 1335:
https://github.com/rsvp/speedtest-linux/blob/6d85106d1274217589f09672ea1e505b0b2aa720/speedtest#L90-L92
It does not appear to accept a supplied server from the CLI as the favorite.

You are absolutely right. My bad. Didn't read the script properly. Thank you.


Todays date shows yesterday when selected.

When I click on todays date on the calendar it returns yesterdays date. I am using  version 2.3.3. is my GMT is an issue?

Hi @sayed19  Please check and make sure the date object is formatted with NSDateFormatter before it is printed out.


How do I fix this error: “Temporary failure in name resolution”

I received this error while connecting to a websocket (in python). The error handler automatically resets the connection, and the stream restarts. But the connections eventually break again every few hours.
What does the error mean? Why does the connection work, and then suddenly break after a few hours?
How do I fix this error? Is it some type of lookup issue? Wouldn't those result be cached?
 Could you someone please explain what that means and just point me in the right direction.
Thanks!
My connection code is below. Is there anyway to cache the DNS here? Why would there need to be a lookup if it's a websocket connection?
	async def connect(self):
		while True:
			log.info("connecting")
			async with websockets.connect(self.url, max_queue=2**10,) as websocket:
				log.info("connected")
				await websocket.send(json.dumps(self.subscribe))
				log.info("subscribed")
				while(True):
					try:
						message_str = await asyncio.wait_for(websocket.recv(), timeout=self._timeout)
						if message_str[9:18] != "heartbeat":
							# await self.queue.put(message_str)
							self.queue.put_nowait(message_str)
					except Exception as e:
						raise Exception("no data in {} seconds, killing connection".format(self._timeout))

It's hard to tell without the full stack trace.
Most likely your system occasionally fails to resolve the hostname in self.url into an IP address to connect to. However that exception would cause the code you provided to exit, not to loop like you describe.

Anyway it's clearly not a bug in websockets, as websockets relies on asyncio / Python / the operating system to establish connections. The answer is inevitably going to be "look at a lower level".

I have a similar problem. Here is my trace.
2018-11-20 02:28:22,294 WARNING websockets.protocol Error in data transfer
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 496, in transfer_data
    msg = yield from self.read_message()
  File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 526, in read_message
    frame = yield from self.read_data_frame(max_size=self.max_size)
  File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 591, in read_data_frame
    frame = yield from self.read_frame(max_size)
  File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 632, in read_frame
    extensions=self.extensions,
  File "/usr/local/lib/python3.6/site-packages/websockets/framing.py", line 100, in read
    data = yield from reader(2)
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 674, in readexactly
    yield from self._wait_for_data('readexactly')
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 464, in _wait_for_data
    yield from self._waiter
  File "/usr/local/lib/python3.6/asyncio/selector_events.py", line 723, in _read_ready
    data = self._sock.recv(self.max_size)
ConnectionResetError: [Errno 104] Connection reset by peer

2018-11-20 06:40:48,207 WARNING turnstile.sync Connection closed

2018-11-20 10:48:06,424 WARNING turnstile.sync Connection closed

2018-11-20 11:35:49,602 ERROR asyncio Fatal read error on socket transport
protocol: <asyncio.sslproto.SSLProtocol object at 0xb5c51e10>
transport: <_SelectorSocketTransport fd=10 read=polling write=<idle, bufsize=0>>
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/asyncio/selector_events.py", line 723, in _read_ready
    data = self._sock.recv(self.max_size)
TimeoutError: [Errno 110] Operation timed out

2018-11-20 11:35:49,607 WARNING websockets.protocol Error in data transfer
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 496, in transfer_data
    msg = yield from self.read_message()
  File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 526, in read_message
    frame = yield from self.read_data_frame(max_size=self.max_size)
  File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 591, in read_data_frame
    frame = yield from self.read_frame(max_size)
  File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 632, in read_frame
    extensions=self.extensions,
  File "/usr/local/lib/python3.6/site-packages/websockets/framing.py", line 100, in read
    data = yield from reader(2)
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 674, in readexactly
    yield from self._wait_for_data('readexactly')
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 464, in _wait_for_data
    yield from self._waiter
  File "/usr/local/lib/python3.6/asyncio/selector_events.py", line 723, in _read_ready
    data = self._sock.recv(self.max_size)
TimeoutError: [Errno 110] Operation timed out

2018-11-20 11:37:18,221 WARNING turnstile.sync Connection closed

2018-11-20 11:37:28,242 ERROR turnstile.sync [Errno -3] Try again

2018-11-20 11:37:28,253 ERROR turnstile.sync Traceback (most recent call last):
  File "/app/turnstile/sync.py", line 83, in sync
    loop=self.loop)
  File "/usr/local/lib/python3.6/site-packages/websockets/client.py", line 393, in __await__
    transport, protocol = yield from self._creating_connection
  File "/usr/local/lib/python3.6/asyncio/base_events.py", line 734, in create_connection
    infos = f1.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/socket.py", line 745, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -3] Try again

After that I get always the last error (socket.gaierror).
How could I handle the error. In the traces is not my script.

I believe the root cause is visible in this stack trace:
ConnectionResetError: [Errno 104] Connection reset by peer

Indeed. I think it is because the client (who uses a LTE-Connection) lost internet connection. After that trace we get always socket.gaierror. The client cannot resolve DNS.
My problem with the Exception ConnectionResetError: [Errno 104] Connection reset by peer is that it begins at
File "/usr/local/lib/python3.6/site-packages/websockets/protocol.py", line 496, in transfer_data
    msg = yield from self.read_message()

There is no reference to my script. How could I handle that?


AnimatedSprite: current texture index does not match current frame index

I have an AnimatedSprite and, let's say, 95% of the time on the first run it doesnt work properly. In this example, it's a toggle button, first image is frame 0, second image is last frame, and third image is what it likes when I run it on the first time.

The frame where it stops it's not always the same, could be last but one or in the middle..
It also occurs after first run but it is very very rare, most of the time is on first run while my webpage is still building things.
I printed some of the internal counters and I noticed that onFrameChange does not print for all frames, and the onComplete method always fires and currentFrame matches with the last index:

When I inspect the object, it says that is in last frame (index 10):

But then, the current texture is the relative to frame index 9, as you can see in the textureCacheIds:

And here are the list of all textures:

So, it seems that internally AnimatedSprite is correct, but visually it's not.
I noticed this since I updated from v5.2.0 to v5.2.1, I don't know if it is related to #6274
Environment

pixi.js version: 5.2.1
Browser & Version: Chrome 80.0.3987.132
OS & Version: macOS Catalina
Dev Environment: Webpack 4.42.0

Hello! The thing with AnimatedSprite - it is a baseline. Its not something that people actually use in production, most of pixi users patch it. It is also not something that requires intimate knowledge of webgl.
https://github.com/pixijs/pixi.js/blob/dev/packages/sprite-animated/src/AnimatedSprite.ts
There can be two type of problems:

Problem is in AnimatedSprite
Problem is in internal _texture assignment in Sprite.

There are two ways you can speed up resolution:

Find the problem yourself, patch it, make PR
Reproduce it in a demo and someone will look at it soon.

Alternatively:

Just wait and maybe someone does it for you.
Wait when a specialist of AnimatedSprite looks at this thread and suddently remembers that he forgot to patch this particular bug.

I guess I found out the problem:
In the PIXI.AnimatedSprite.prototype.update we have an if/else if/else if at the end, and only for the last else if the method this.updateTexture is called. If code enters in the first two, this is never called and if the last drawn frame was one in the middle, the animation will appear with that frame visible instead of the last one.
I checked commit log in #6274 and this was changed. Before, in the first two ifs the method gotoAndStop was called, wich contains a call to updateTexture, and now it was substituted by a simple call to stop() and never update the texture in that cases.

And I guess that this situation occurs more often when we have some kind of frame skipping/lag.

Guys, that's a real bug! @themoonrat @bigtimebuddy

Fixed with #6487


Preliminary OCR implementation, ID/stashing logic overhaul, Belt/Consumibles overhaul

Hey! Really big PR here, sorry. :) Will notify when ready to review to merge, just have one or two more rounds of testing to go with some of the devs.
Breaking changes:
-Nilhathak spelling fixed, so adjust your [routes] section in custom.ini accordingly
-always_repair config parameter changed to runs_per_repair. Set to 1 if you desire to always repair, set to 0 to only repair when the icon shows up, otherwise set to how many runs you want to do before doing a routine repair
-Added a line to graphics config, perform an F9 on starting botty
-Rebuild conda environment is needed if you plan to run from source:
conda deactivate
conda env remove --name botty
conda env create environment.yml
conda activate botty

Caveats:
-All drops and item description boxes are being read by OCR but not currently implemented in logic, this has led to an impact on performance during pickit routine. This is kept in order to help us generate truth to train the OCR. Once the OCR model is fully mature and pickit system overhauled, this should become a non-issue.
TO-DO:
-Bugfixes. VM users seem to struggle most.
-Splitting most of the features into separate PR's--at least the ones that aren't intertwined.
-A2 Lysander doesn't sell TP scrolls but does sell pots, so may need to refactor town_manager.py
Features:
OCR
-OCR model trained with Tesseract 5.0 using in-game and auto-generated D2 assets
-Adds ocr.py which contains functions for performing OCR using TesserOCR
-Limited amount of parsing leveraging the Parse module, currently implemented with checking TP, ID, and key counts from item descriptions
-Item parsing and pickit list generators are currently WIP and not yet implemented on the branch
Item identification
-Now supports tome of ID in inventory and will utilize if present, otherwise will utilize cain if id_items config parameter = 1
-No item filtering with OCR yet implemented, but this is planned
Towning overhaul
-Now checks items every pickup and decides to drop, ID, sell, or stash at the start of on_maintenance(), so no longer will go to the stash needlessly
-always_repair changed to runs_per_repair so you can set a more specific frequency for repairing if desired (see breaking changes above)
-Added a sell_items char config, set to 0 if you want to drop all items that won't be kept, to 1 to sell all items that won't be kept
-When purchasing items, will use "shift" click to buy stacks if appropriate
-Consolidated purchasing functions to transfer_items() function in inventory_manager.py
-Reduced various redundant or excessively frequent actions with towning/shopping
Consumibles
-Split up the functions of ui_manager.py and belt_manager.py into three new classes: UIManager, InventoryManager, and ConsumiblesManager
-TP, ID, and key counts are now tracked with potion counts
-Will buy TP, ID, and keys from vendors as needed
Pickit
-Will now pickup TP scrolls and ID scrolls if these are needed and if you have these set to 1 in the pickit.ini config file.
Discord
-Will send picture of every kept drop as well as the read OCR text
Other
-Changed item spacing width to controller spacing for better item segmentation
-Added more routes to act 5
-Adjusted logic for misc utility color_filter to allow H to span over 0 or 180 for reds
-Added support for list of images to be used with template_finder.search
-Added a couple more misc utility functions mask_by_roi (used to generate masks from img+roi), trim_black (used to trim black borders from image)

If anyone would like to help with this branch, I could still use your help with OCR error detection. Run the game as usual, but make sure you have addressed the issues in Breaking Changes above and have these variables set as follows in your custom.ini file:
[general]
logg_lvl=debug
loot_screenshots=1

[char]
id_items=1

Once you have run long enough, send me a zip of the loot_screenshots directory and your info.log file.

I am just wondering, what is the accuracy rate on the tesseract results? I trained a model with D2 fonts as well, and I get for "Harrogath" lots of variatns like "Hawogaln" or such

I am just wondering, what is the accuracy rate on the tesseract results? I trained a model with D2 fonts as well, and I get for "Harrogath" lots of variatns like "Hawogaln" or such

Right now it's the eng model refined for a single d2 font and only in the setting of item drops and item description boxes. About 99.5% word accuracy here for drops and item properties.

This is tremendous effort :) and can enable botty to be super smart :) From my point of view one I would try to split this PR in several to minimize the risk of regression and to simplify the review. E.g. 1) Nihlathak typo. 2) OCR as Framework 3) Splitting UI Manager. 4) Integrating OCR in XXX, etc.

This is tremendous effort :) and can enable botty to be super smart :) From my point of view one I would try to split this PR in several to minimize the risk of regression and to simplify the review. E.g. 1) Nihlathak typo. 2) OCR as Framework 3) Splitting UI Manager. 4) Integrating OCR in XXX, etc.

Yes, working on splitting it up. Not really ready for review yet anyway as it's very much in draft form. Currently put in the nihlathak & some misc util changes in separate PR's now that they've been validated to work in this branch; others to come. Will wait on aeon's "epic refactoring" and then adapt my changes to ui_manager and belt_manager. Will probably make an independent OCR function soon, currently working on a universal D2 model that works beyond the item drops and description boxes.

Not actively working on this branch due to #489 , will make small PR's for some of the features in the coming weeks.


Add Identity API to QueryCtx and ConnectorQueryCtx

Description
Presto clients can provide extra credentials to a connector. See https://prestodb.io/docs/current/develop/client-protocol.html#client-request-headers.
A related Prestissimo issue that requires these is https://github.com/prestodb/presto/issues/22849
The Presto protocol sends this information as part of the TaskUpdateRequest.
https://github.com/prestodb/presto/blob/49f6566012bc67d9c06e48e74e1d2d6b4029b6e1/presto-native-execution/presto_cpp/presto_protocol/presto_protocol.h#L3086
In Presto Java, these details are persisted in an Identity object under the security SPI. https://github.com/prestodb/presto/blob/master/presto-spi/src/main/java/com/facebook/presto/spi/security/Identity.java
The proposal is to add a similar API in Velox with only the minimal user and credentials fields.
These fields are generic (user is std::string, credentials is std::unordered_map) and other clients can also use them for similar needs.
The Presto Java Identity class has other fields (principal, roles, etc.) that are used for other use cases such as Kerberos support.
These will be added later when needed.

@majetideepak Deepak, would you describe some use cases that need this information? Adding Identity struct is not enough I assume. What are the next steps to provide meaningful functionality?

@mbasmanova Masha, the immediate need for this is in the Arrow Flight Connector implementation. The authors requested this in the Presto issue here https://github.com/prestodb/presto/issues/22849
From the issue description, the Identity struct should be sufficient for now since the requirement is for the users to be able to specify the user credentials via extraCredentials.
@ashkrisk, @tdcmeehan, can you confirm? Thanks.

@mbasmanova without an Identity API, the only way for connectors to read authentication credentials is through the catalog configuration file. This means that all presto users have the same level of access to the data source, which is not desirable in our case.
Specifying extraCredentials allows multiple users connecting to the same presto cluster to connect to the same data source, but access only the subset of data they are authorized to.
I think adding an "identity" member to the QueryCtx with a "user" and "credentials" field is good enough to address this.

@mbasmanova I will add some details on the usage. I will include some notes on the security rules/implications, especially in a multi-tenant system as well. I need to look at how Presto implements this.

This feature would be needed in Parquet Reader column level decryption. Parquet files supports columns to encrypted with a key. We at Uber would be using the user identity to verify if the user has access to encrypted column via a KMS service and use that information decrypt the column.


English translation?

This looks like an amazing skin, with the bar graphs and whatnot. What are the chances of there being an English translation?

well, it's in my Todo list, maybe the translation will be ADD in the next version 😘

Done

Oh wow that was REALLY fast! From your last reply, I mean. Much thanks!


EKS cluster fails to come up in an air gapped proxy setup

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Deploy an air gapped proxy setup
Deploy EKS cluster
EKS cluster fails to come up with error

time="2020-09-22T01:22:06Z" level=error msg="error syncing 'cattle-global-data/c-b9x2f': handler eks-controller: error creating stack with VPC template: error creating master: RequestError: send request failed\ncaused by: Post https://cloudformation.us-west-1.amazonaws.com/: dial tcp <IP_ADDRESS>:443: i/o timeout, requeuing"
time="2020-09-22T01:22:06Z" level=info msg="Bringing up vpc"
time="2020-09-22T01:22:44Z" level=error msg="error syncing 'cattle-global-data/c-k9454': handler eks-controller: error creating stack with service role template: error creating master: RequestError: send request failed\ncaused by: Post https://cloudformation.us-west-2.amazonaws.com/: dial tcp <IP_ADDRESS>:443: i/o timeout, requeuing"
time="2020-09-22T01:22:44Z" level=info msg="Creating service role"

Expected Result:
EKS cluster should come up successfully.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head - commit id: ed2749841db0
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): hosted EKS
Kubernetes version (use kubectl version):

1.17

I traced this down to the container running the eks operator it's self.  I am able to resolve dns inside the container but it cannot route to the aws api server.  I am able to route to the aws api server from the node and k3s container.

reopening the issue for a fix in 2.5-head

On 2.5-head commit id: b722847200 and on master-head - commit id: 4916c38e4

Deploy an air gapped proxy setup
Deploy EKS cluster
EKS cluster comes up Active. No error seen


mRNA and rRNA percentages missing from MultiQC output

Description of the bug
Previously the MultiQC output from Tomte included mRNA and rRNA percentage values.
Since the latest updates, these are no longer part of the MultiQC output.
I could see in my run that the values were calculated, just not included in MultiQC (i.e. not put in the multiqc_data folder).
It might be an issue with the recent MultiQC issues. It was recently discussed, but claimed to be fixed: https://github.com/MultiQC/MultiQC/issues/2608
I have tried the current MultiQC version (1.22.3) and also swapping the container to the most recent version (1.23).
Needs more investigation though, to understand why the CollectRnaSeqMetrics files are calculated but not put in the multiqc_data folder.
Command used and terminal output
Running the dev branch, commit: 00e5eb320ebb6a5a913ff136f45adf7171c7a75a

Relevant files
No response
System information
No response

Thanks for making an issue, I assume that updating to the newest version of the container didn't help, right?

Thanks for making an issue, I assume that updating to the newest version of the container didn't help, right?

No exactly, assuming that I did everything correctly, using the latest MultiQC version (1.23) did not help.

This should be solved when merging the new template as the multiQC version will be updated to 1.25
In test runs the produced multiQC includes both mRNA and rRNA 😄


MAXITER = 0 Parameters

I want a simple evaluation of the criterion function at the truth. Why are the economic parameters (starting with identifier 14) different?
est.grmpy.txt
test.grmpy.txt

I adjusted the estimation process appropriately.


Run background ddl in deterministic recovery test

[x] Depends on https://github.com/risingwavelabs/risingwave/issues/12885
[x] Migrate run-backfill-tests.sh (cancel) to run in deterministic integration tests: https://github.com/risingwavelabs/risingwave/pull/12167#discussion_r1366578726.
[x] Migrate the rest of the tests to run in deterministic integration test. https://github.com/risingwavelabs/risingwave/pull/13219
~- [ ] Deprecate run-backfill-tests.sh~ Some of these tests are specific to backfill, and require a full cluster. For instance tombstones test. Seems relatively stable for now. So won't change it.

[ ] We should test it in recovery-deterministic-test:

Use WAIT on recovery, which will wait for all background ddl to complete.

No need to test progress %, since it is flaky.
When cluster undergoes recovery, it should still recover the background ddl.

Last task requires some refactoring to complete it. The deterministic testing framework needs to retry background_ddl tasks after recovery. Reason being the jobs could be killed before the first barrier pass, making them unrecoverable.


Show token art not working

Show Token Art does not show the token, if I change the keybinding to Alt+A ( default keybinding to the Show artwork ) the token does not show.
Show artwork ir working fine.

This isn't a core or system keybinding