Portal-Server provisioning with prvc files.

Just to possibly save others some time:
Our Chef cookbook was failing during the authorize Server with Software Authorization step.
Working with Esri support, we discovered that one needs to use two separate PRVC files.
One for Server authorization and one for Portal Authorization.
If you have just one PRVC file that has Server, Server Extensions and Portal ECP codes (like we had),
then make two copies of it.
For the Server one, remove the line with the Portal ECP file.
For the Portal file, remove the Server and Extensions ECP lines and leave just the Portal authorization.
Esri support thinks this might be a bug in 10.4 Software Authorization.  It should probably work with just one file but it appears that during Server authorization, if the Portal ECP is there, then that is the final code SA tries to use and then fails.
Using a ecp file is probably preferable with Chef since it doesn't require Internet access to the Esri licensing servers.  However, you can't get an ecp file until you have authorized successfully so that's a bit of a Catch 22.
I did uninstall Server, remove the keycodes file and reinstall with Chef using two separate PRVC files to verify that this cleans up the problem we had been having (errors in the Chef install about unable to activate server.)   I had previously verified that using a keycodes.ecp file had also fixed the problem of authorization.

Yes. Licensing is another gotcha. We usually test with PRVC or ECP files that has Server, Server Extensions and Portal ECP codes. That mostly worked for us. Authorizing with PRVC files calls Esri license server to get ECP file. This is a problem in completely closed environments and if the license server is down.

Yep, the ecp file that worked for me had Server, Server Extenstions and Portal ECP codes in it and it worked fine.
I then removed that keycodes file, uninstalled server and a partially installed web adaptor.
Created the two separated PRVC files and then reran Chef without a problem.
I did have to install .NET Framework 3.5 by hand to get Chef past the IIS installation on Server 2012 R2.  We are thinking that the issue here was a specific Windows Update had removed 3.5
We also have put our domain level login account, that we use to create all of our ArcServer/Portal systems,  into the "Local Computer Policy:Computer Configuration:Windows Settings: Security Settings:Local Policies:Log on as a Service" Policy.
I don't know if we need this anymore but it was something we have had to do in the past with AGS and Portal installs done by hand.  Our VM template just has that in place.  I forget the issue we had that required this fix.
Our Production Portal & Federated Hosting Server with Data Store is now up and ready for configuration.

"Local Computer Policy:Computer Configuration:Windows Settings: Security Settings:Local Policies:Log on as a Service" policy should be set by Server/Portal/Data Store setups.

arcgis-2.2.0-cookbooks.zip includes third-party ms_dotnet cookbook that arcgis cookbook uses to install .NET Framework 4.5. You can try using this cookbook to install  .NET Framework 3.5.

I'll look into that.  Need to get into my head that we have a full Windows cookbook.
I thought our Test Portal was setup with .NETfx3.5 but I see that it wasn't successful.
Regarding the Log on as a Service...  That would explain something.
I have asked my SAII to do the Test Portal install using Chef and he hit the same problem with 3.5 that I did.  He was trying various things, one of which was adding our domain account to that Policy.
But when I looked on my Production Portal, our domain account was already in that Policy.
Since I believe he said he had to do this, it means its not in our VM template and that Chef did this correctly.  I was confused why he had to do it.  It's just that he hasn't run Chef far enough for that to occur.
This is just one of the benefits I find of Chef.  It takes care of a lot of the extra steps you would have to do by hand, after figuring out the fix.
My documentation for doing these installs by hand is pages and pages of notes and Google grabs, etc... as you work through various problems that occur.
My documentation for doing this with Chef is now only a page or two.
I'm a convert.

Here is a hint how to use ms_dotnet cookbook to install .NET Framework 4.5.
{
  "ms_dotnet" : {
    "v4" : {
      "version" : "4.5.1"
    }
  },
  "run_list":[
    "recipe[ms_dotnet::ms_dotnet4]"
   ]
}

Installing .NET Framework 3.5 should be similar.

Thanks for this conversation: very useful -- will look to split up a single ECP file into two separate Portal and ArcGIS server ones.

Hi Wml.
If you're using a .ecp file, it should work as a single file with both server and portal authorization inside it.
It's the .prvc files that we found needed to be split up into Server and Portal versions.
Hope that helps...


[Feature] impl left join unnest on true

Why I'm doing:
What I'm doing:
support left join unnest on true.
which means if the current row is null or [], we need add null to the result for left join on true.
Fixes #issue
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

https://github.com/Mergifyio backport branch-3.2


  They were easy fixes, so figured I'd pass them along.

Thank you so much!


Lalalambda + serverless-offline not working

Hello everyone, i'm experiencing an bug when using serverless-offline plugin with Lalalambda.
When i run $ npx serverless offline then the following error occurs:

It is my serverless config settings:
org: walkerdepaulawork
app: doare-api
service: server

provider:
  name: aws
  runtime: nodejs12.x

plugins:
  - lalalambda
  - serverless-offline

package:
  exclude:
    - .git/**
    - .vscode/**

The current workaround i'm using to be able to work offline is:

So, i my repository i have to manage the temp code provided by Lalalambda, as following:

The are some way to fix it? I dont know if i can help with this, i mean, i dont know if this "bug" is in serverless-offline plugin or its Lalalambda responsability. What are your thoughts?

I think this has to do with serverless-offline offering two different ways of starting the server: there's sls offline and sls offline start.  The latter offers explicit lifecycle hooks that lalalambda uses to interoperate with serverless-offline, and the former one doesn't.  Can you try changing your dev command to be npx serverless offline start and let us know how it goes?

Hey @devinivy, you are totally right about this!
I didn't know about that serverless offline **start**. I tested this yesterday and works fine for me. Thank you for you help!

Glad that's all it was! :) 🥂


Database dropdown selection has no effect for Athena

System information:

Operating system (distribution) and version: Windows 10
DBeaver version: <IP_ADDRESS>101311042
Additional extensions: none

Connection specification:

Database name and version: Athena
Driver name: Simba
Do you use tunnels or proxies (SSH, SOCKS, etc)? no

Describe the problem you're observing:
The selected database does not get set.  I think the fix would be setting the Schema parameter in the driver.  It is currently possible to set the parameter, so that it no longer looks in the default db, but would be useful if the drop down actually worked.
Steps to reproduce, if exist:
Connect to athena.  Try to select from a table not in the "default" database.  Get an error.
`
Include any warning/errors/backtraces from the logs

`SQL Error [100071] [HY000]: [Simba]AthenaJDBC An error has been thrown from the AWS Athena client. SYNTAX_ERROR: line 1:15: Table awsdatacatalog.default.tablename does not exist

Hi @uslss, the current version is 7.3.4 what does it mean this was added to 21.0.0?

Even if I set the schema as default in the connection settings it is still ignored.

This part actually works for me.  The workaround is to set up separate connections per database  (or use fully qualified db names)

Hi @chanansh. We are switching to a new versioning scheme. The 21.0.0 version will be out on the 1st of March.

Hello @dangeReis,
Can you please provide more details about your problem?
Are you talking about dialog for changing active catalog/schema (Ctrl+0)?

Hello @dangeReis,
Can you please provide more details about your problem?
Are you talking about dialog for changing active catalog/schema (Ctrl+0)?

Yes, that is the part that is not working.  I can pick a schema, but the query still runs against the wrong schema.

I see, thanks for the explanation.

Looks like the issue is with the driver itself. Need further examination.

Looks like the issue is with the driver itself. Need further examination.

Possible, but setting a default in settings works, so the driver is at least is capable of accepting default db.  I'm happy to try a different driver if you think it will help.

It may be capable of setting default schema during connection initialization, but may not be able to change it later for active connection.
Unfortunately, I can't name any alternatives. But, at least for now, you can use the workaround mentioned earlier.

It may be capable of setting default schema during connection initialization, but may not be able to change it later for active connection.
Unfortunately, I can't name any alternatives. But, at least for now, you can use the workaround mentioned earlier.

I meant like a newer version of the driver, if the one I'm using is having issues.  Please test and let me know if this is indeed an issue with the driver and if updating to a new version resolves it.

Updating to newer version (<IP_ADDRESS>0) does not resolve the issue.

Updating to newer version (<IP_ADDRESS>0) does not resolve the issue.

So are we sure the issue is with the driver?  In that case can we open an issue with them?

I do see this note on the documentation page:
To use the JDBC driver for multiple data catalogs with Athena (for example, when using an external Hive metastore or federated queries), include MetadataRetrievalMethod=ProxyAPI in your JDBC connection string.
Not sure if it's relevant here.
https://docs.aws.amazon.com/athena/latest/ug/connect-with-jdbc.html

I can't find any other traces of this problem, so that's my guess.
Unfortunately, that note is not relevant here, since we're talking about changing current schema, not the catalog.
As I said, we need further examination. I will write back later.

We have concluded that the issue is indeed with the driver. You can create a separate issue on their board.

We have concluded that the issue is indeed with the driver. You can create a separate issue on their board.

I can try.  Do you have some sample code that reproduced the issue with the driver?

As a starting point, the following code sample can be used:
https://simba.wpengine.com/products/Athena/doc/JDBC_InstallGuide/content/jdbc/ath/examples/jdkexamples.htm
And block to reproduce the issue:
conn.setSchema("non-default-schema");
conn.getSchema(); // will return "non-default-schema"

try (Statement stmt = conn.createStatement()) {
    try (ResultSet rs = stmt.executeQuery("select * from some_table_from_non_default_schema")) {
        rs.next();
    }
}


OU-539: Reload plugin certificates

Related Issues:
JIRA
OU-539 Reload Certificates : https://issues.redhat.com/browse/OU-539
Mirrors solution from the /monitoring-plugin:
https://github.com/openshift/monitoring-plugin/pull/187/files

/lgtm


Disk Encryption

As per the azure managed disk documentation, which one is supported and used by default for OS disk in AKS nodes?
Can I use Azure Disk Encryption (ADE) with secrets managed in Key Vault. Can someone provide an example of it?
=> Reference from the documentation below..
Managed Disks and Encryption
There are two kinds of encryption to discuss in reference to managed disks. The first one is Storage Service Encryption (SSE), which is performed by the storage service. The second one is Azure Disk Encryption, which you can enable on the OS and data disks for your VMs.
Storage Service Encryption (SSE)
Azure Storage Service Encryption provides encryption-at-rest and safeguard your data to meet your organizational security and compliance commitments. SSE is enabled by default for all Managed Disks, Snapshots, and Images in all the regions where managed disks are available. Starting June 10th, 2017, all new managed disks/snapshots/images and new data written to existing managed disks are automatically encrypted-at-rest with keys managed by Microsoft by default. Visit the Managed Disks FAQ page for more details.
Azure Disk Encryption (ADE)
Azure Disk Encryption allows you to encrypt the OS and Data disks used by an IaaS Virtual Machine. This encryption includes managed disks. For Windows, the drives are encrypted using industry-standard BitLocker encryption technology. For Linux, the disks are encrypted using the DM-Crypt technology. The encryption process is integrated with Azure Key Vault to allow you to control and manage the disk encryption keys. For more information, see Azure Disk Encryption for Windows and Linux IaaS VMs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1ac572f-c613-71fc-580a-2805b740b793
Version Independent ID: b4aeef15-7b0f-abc7-872e-28051e10d6ca
Content: Create persistent volumes with Azure Kubernetes Service
Content Source: articles/aks/azure-disks-dynamic-pv.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@badalk as of now AKS only supports and uses SSE. There is no option to encrypt the disks at any other level.
You can provide feedback if you want to see that feature implemented here:
https://feedback.azure.com/forums/914020-azure-kubernetes-service-aks

So the data is encrypted for the attached volumes (using Azure managed disks) and keys are managed by Microsoft as it is using SSE - can you confirm
In addition, if I want to encrypt the etcd store the only option to do it is using the kubernetes keyvault flextool from github -> https://github.com/Azure/kubernetes-keyvault-flexvol to ensure if there are any secrets and any sensitive data stored is encrypted. But is this supported by Microsoft?
This way we can ensure entire cluster data whether application specific or by the cluster is encrypted at rest.
Please confirm

@badalk all data in Azure is encrypted at rest. This means SSE. This applies to any data in Azure. Regardless of if you are using storage by itself, VMs, App service, AKS, etc.
What encrypted as rest means is that the physical data drives located inside the Azure Datacenters are all encrypted. So if a data disk were to ever make it way outside of a data center the data is encrypted and cannot be access. What Azure does when you are accessing the data via the portal or through connecting to the cluster is we decrypt the data in the pipeline  before it reaches you. Which is why you can access the data as if it was unencrypted.
For Virtual Machines as an example, you can add Azure Disk Encryption as an added layer of security. This will encrypt the data at the OS level. So if someone were to access your VM but did not have the key to the data disks they would not be able to access the data. Just as encryption on premise works.
I am not overfly familiar with the keyvault-flexvol. It appears to be a way to access the keyvault from within your cluster.

Just to clarify, the VM extension for encryption is on the AKS roadmap for native support, but is not currently supported for use with the AKS nodes.

@sauryadas and @seanmck for confirmation on the current status of support for flexvol, please.

#15278
@badalk we can address all issues in this issue. No need to open multiple issues as it can become a bit confusing.

@badalk I appreciate you asking these questions. And they are are valid questions. The scope for these comments on the docs are to help identify issues when running through the doc or items that we should add to the doc to make things more clear while you are following the instructions.
Myself and others who are working in these doc comments do have some knowledge about the product however some of these deeper product questions such as you are asking are best answered directly by the team that designs the product itself. We simply manage the doc walk through portion. We obviously can answer some of the product questions themselves but not all of them due to knowledge depth.
Here are the suggested areas and how to use them
Product Questions/ Bugs in the product
https://github.com/Azure/AKS/issues
Product Feedback/ Feature Suggestions
https://feedback.azure.com/forums/914020-azure-kubernetes-service-aks
General Troubleshooting Assistance
https://stackoverflow.com/questions/tagged/azure-kubernetes
The above links are where the Product Group members who design and work directly with AKS are located as well as a large community of other users who have a good grasp of the product and understand the ins and outs.
It sounds like you are needing some answers in order to move forward with AKS. I completely understand this and I would not want to steer you wrong. Hence, asking in the above channels will get you the answers you need and they will come directly from the product members who design the product itself so you know they are correct.
If you open an issue on the AKS GitHub page directly you are more than welcome to CC me in it as well. Also, from your Support ticket we had you open a bit ago you also have my email with you are more than welcome to reach out to me directly as well. In most cases I will still need to direct you to the AKS github repo but if I know the answer I am more than happy to share it with you directly.
If you are ever running through a doc and encounter an issue please do open a comment so we can take a look and see why the walk through might not be working. Otherwise I would suggest using the above links I provided so you get the correct support and your questions answered.
I appreciate you using AKS as I also really enjoy it. I just want to make sure you have the correct resources available so you can get your questions answered correctly and continue with your development.

@badalk I will close this out out for now.
Please feel free to reach out to me offline if you have additional asks that the above links I provided are not helping on :)


When setting breakpoints and hitting them, the source file doesnt come up

Describe the issue
When Storybook is up and running and i set breakpoints in a component.tsx file, the breakpoint gets hit. But VS Code opens up the file with a timestamp component.ts?t=1643631920003.
Steps to Reproduce
I used the commands in the README:
npm install # or yarn
npx sb@next init --builder storybook-builder-vite && npm run storybook

Then i added some console.log() to not hit the breakpoint in the JSX.
I also added the corresponding flags for sourceMap:true to tsconfig.json, main.js and to be sure also vite.config.ts.
Here is the repo to clone:
https://github.com/Hydrair/vite-react-app-breakpoints

Set Breakpoints in Header

Additional context
It doesn't fail all the time in the test repo, but i first recognized it in a bigger project after moving from webpack to vite.

Experiencing the same with Storybook 7 RC8 :(
Any updates on this one?


Repackage docker file

/reviewme @ubergeek42

I'm on the fence about vendor; my main objection is that it makes the commit history much messier (and PRs gross), and since all the dependencies are open source it seemed easier to just fetch everything as part of the build. But I could be convinced either way.


Alterative If roleAssignment/write access can not be given

Please provide us with the following information:

Authorization for template resource ****** of type 'Microsoft.Authorization/roleAssingments'. You does not have permission to perform action 'Microsoft.Authorization/roleAssignment/write'.
This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

You don't have permission to perform action 'Microsoft.Authorization/roleAssignment/write' operation.
Expected/desired behavior

What can be done if we don't have the permission of RoleAssignment/write.
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
Ubuntu 22.04.4

azd version?

run azd version and copy paste here.
1.5.1

Versions

Mention any other details that might be useful
I don't have permission to perform Role assignment operation. Please let me know if there any alternative for this issue.

Thanks! We'll be in touch soon.

Pasting below from the prerequisites:

Your Azure account must have Microsoft.Authorization/roleAssignments/write permissions, such as Role Based Access Control Administrator, User Access Administrator, or Owner. If you don't have subscription-level permissions, you must be granted RBAC for an existing resource group and deploy to that existing group.
Your Azure account also needs Microsoft.Resources/deployments/write permissions on the subscription level.

If you're not able to get the required permissions, we don't have a workaround yet. The Bicep would need to be re-written for a resource group deployment.
I see you commented on #4 so I'll close this one and reply there.


Shouldn't prefix transpiled libraries?

This is a theoretical question, I haven't checked if an issue actually happens or not.
I can see that transpiled libraries under vendor/phabel/transpiler71 still retain the same namespace: Nette\Utils\Strings is transpiled under Nette\Utils\Strings, not under PhabelVendor/Nette\Utils\Strings. Isn't that a problem?
For instance, if two libraries use Nette\Utils\Strings, and of them is using Phabel and the other not, couldn't that create conflicts?

Phabel's composer plugin sets transpiled packages to provide the original package, as well, so this is not an issue.
Composer will resolve all conflicts, and replace the original version of the package with the transpiled one, if present.

If SomeCadorno is defined in the root composer project A (the one that requires somevendor/cadorno), the developer of A will already use PHP 8 locally for development, so transpilation will not be triggered.
If some other project is in turn requiring othervendor/A, phabel will transpile othervendor/A, even if A does not explicitly require phabel, exactly to solve covariance issues like these.
The behavior in #9 is a bug, in reality, all covariance issues inside the vendor folder should be resolved automatically.

Now transpiled packages actively conflict with all versions (*) of the original package, forcing composer to install only the transpiled version.


[Coverity CID :198005]Memory - corruptions in /subsys/bluetooth/shell/gatt.c

Static code scan issues seen in File: /subsys/bluetooth/shell/gatt.c
Category: Memory - corruptions
Function: print_attr
Component: Bluetooth
CID: 198005
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

Marked as false positive in Coverity


Latitudinal Rotation, what is it?

Hello, thanks for your great library Matthew Petroff!. I was impressed you created this library using WebGL & Javascript!
thanks for sharing this one!
I'm not so good at math, but can you explain a little more about latitudinal rotation? as i know, the point position vector gives you a direction from the camera position right? but what is latitudinal rotation and why you should multiply it with point position vector? and can i convert the yaw & pitch of the camera to x,y,z coordinates?
thanks in advance!

This isn't an appropriate forum for math questions. Something such as Stack Exchange would be better suited to this.


filter state: add a mark for sharing with the upstream

Commit Message: Adds a new flag for filter state objects that indicates the intent to share with the upstream.
Additional Description: Follow-up to https://github.com/envoyproxy/envoy/pull/19809. There have been multiple reports of unexpected lifecycle changes for the filter state objects because they are stored in the transport socket options. This PR addresses this issue by introducing a new mark for filter state that explicitly changes the usage of filter state objects:

marked objects always participate in the connection pool hashing (generalizing and simplifying https://github.com/envoyproxy/envoy/pull/19435);
marked objects are copied by reference to the upstream info - this allows sharing state between downstream and upstream (and further down the chain, the internal listeners).

Risk Level: medium, revert to the original behavior prior to https://github.com/envoyproxy/envoy/pull/19809
Testing: yes
Docs Changes: yes
Release Notes: yes

@ggreenway This should be ready now. I could simplify the recently merged extension, too, which was the only client in-tree for filter state within transport socket options.

/retest

/retest


Update Dockerfile

python version issue fixed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Tilemap editor: Flipping or rotating tiles resets the selected tile when using atlas tilesets

Godot version: 3.1.1 Stable
OS/device including version: Solus 4.0
Issue description: When you press the buttons to flip or rotate a tile in the tilemap editor, the tile is reset back to the first tile.
Steps to reproduce:

Open a project.
Create a tilemap.
Create a tileset in the tilemap.
Create tiles from an atlas selection in the tileset.
Edit the tilemap.
Press the buttons at the top of the tile map pane to rotate or flip the tile; the selected tile will reset.

Minimal reproduction project: N/A
Here's a video that shows a bit: https://gfycat.com/SillyGrouchyHagfish

Update, looks like the problem is specifically with tiles created from an atlas selection.


Update screenshot to not say Xamarin Studio

We should update the screenshot here to not say Xamarin Studio Addin.
The latest version of the addin maker will actually show 3 choices for templates - IDE Extension, IDE Extension Tests, and IDE Library.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc52ec0c-7053-51d0-c576-2d8ce60cf198
Version Independent ID: 8bb8155e-d615-5ea8-cd83-3820f8484b43
Content: Extending Visual Studio for Mac Walkthrough - Visual Studio 2019 for Mac
Content Source: mac/extending-visual-studio-mac-walkthrough.md
Product: visual-studio-mac
Technology: vs-ide-sdk
GitHub Login: @conceptdev
Microsoft Alias: crdun

@BretJohnson Thank you for the feedback, assigning this to the author for review.

For what it's worth, that item – to create an Add-in – appears to be removed altogether in the version of VSMac I have installed (8.3.10(build 2)). I'll leave it to @heiligerdankgesang to decide what to do with this content.

@conceptdev is there a way to hide this content, but still retain it for when we revisit?

Creation of add-ins are not officially supported in Visual Studio for Mac 2019. I've removed the content from the 2019 docset in https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/6674

#please-close


Update index.md

Post transition to post-transition

post transition to post-transition

update post transition to post-transition


Saving large model results in corrupted XMI file

Issue and tracking information
Developer's time Estimated effort to fix (hours):
Developer's Actual time spent on fix (hours)
Issue reporter to provide a detailed description of the issue in the space below
(This was first mentioned in Issue #466).
"[...]we see a few other segfault errors as well as a problem that has been plaguing our team for years even back in RSA. This bug is one where the model saving goes wrong and some portion of the model is saved to UML twice giving invalid XML. I have added an example of this corrupted model in the other zip file.
SPDM_Large_corrupted.zip
-This contains the corrupted UML. Notice that the models XML ends with a </xmi:XMI> tag, but then contains what appears to be a trailing portion of the original model after it. If you delete all contents after the first ending </xmi:XMI> tag, the model is valid again."

While I see the corruption in the model that you provided, I haven't been able to reproduce it myself, with neither your large models, nor with other smaller models.
Can you perhaps give me more details about the steps that you do to get the corrupted model?

Do you change more than one element before saving?
Which elements are you changing and what values are you giving them?
How many changes do you make before seeing the corrupted file?
Does it happen after one save or after multiple saves?
Does it happen after reloading, or switching between models?
Do you see any exceptions in the Error Log when this happens?
Are there other models in the workspace?
Do you edit other models in the same session?
Do you have any plugins that are using the same ResourceSet?

For a little background, this issue is one that we have been seeing for a long time but it is fairly rare unless the model is very large.  We only develop on Linux VMs, which I believe is different from your development environment. The filesystem is mounted as just XFS, not NFS or anything like that.
I just reproduced this on my end with the following details. Only one project in the workspace with one model, the large SignalProcessingDataModel example. This was the only model or file open in eclipse. It took me two saves to reproduce this issue this time, however, I believe the issue happens psuedo-randomly and the number of saves isn't really relevant here. For both saves, the only thing I did was change a single message field type to a CX primitive like CXChar and CXDouble.  I don't know what you mean with your last question. My guess is no since our plugins do not really interact with the modeling system at all.
I will attach the logs in another comment.

Corruption.log


Remove line continuation from inside 'quotes' in help files of az resource

Line continuation inside 'quotes' cause json parsing error, so removed.
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

I can also repro this on OSX, which is strange since I thought the backslash was bash-specific syntax that needed to be there. In any case, yes, you'll need to update the linter rule accordingly to make the CI pass.

Yes it seems like a linter issue. Typically for multiline commands a backslash or uncompleted quote is needed to continue the command on multiple lines.
The "faulty_help_example_parameters_rule" linter rule needs to be updated to properly handle situations where a quotation spans many lines.
This is strange though as I cannot repro this on osx:
>                 "location": { \
>                     "value": "westus" \
>                 } \
>             }'
[Errno 2] No such file or directory: 'azuredeploy.json'

>                 "location": { \\
>                     "value": "westus" \\
>                 } \\
>             }'

[Errno 2] No such file or directory: 'azuredeploy.json'

@adewaleo
perhaps in your case it tries to load azuredeploy.json first and fails, so it doesn't attempt to parse parameters' json

@adewaleo
perhaps in your case it tries to load azuredeploy.json first and fails, so it doesn't attempt to parse parameters' json

@zikalino you are right about the CLI failing fast on azuredeploy.json:
(cli-venv) [02:15 PM] Work-Mac:azure-cli tosin$ az group deployment create -g MyResourceGroup --parameters '{ \\
>     "location": { \\
>        "value": "westus" \\
>     } \\
> }' --template-file azuredeploy.json
Unable to parse parameter: { \\
    "location": { \\
       "value": "westus" \\
    } \\
}
(cli-venv) [02:15 PM] Work-Mac:azure-cli tosin$ az group deployment create -g MyResourceGroup --parameters '{ \
>     "location": { \
>        "value": "westus" \
>     } \
> }' --template-file azuredeploy.json
Azure Error: InvalidRequestContent
Message: The request content was invalid and could not be deserialized: 'Required property '$schema' not found in JSON. Path 'properties.template', line 1, position 45.'.
(cli-venv) [02:15 PM] Work-Mac:azure-cli tosin$

For the second "successful" request, the following payload was sent, which is expected:
msrest.http_logger : Request body:
msrest.http_logger : {"properties": {"template": {"resources": []},
"parameters": {"location": {"value": "westus"}}, "mode": "Incremental"}}

So it seems the help text was valid, at least on osx / linux as the output help text from the yaml is actually the following:
az group deployment create -g MyResourceGroup --template-file azuredeploy.json --parameters '{ \
                                "location": { \
                                    "value": "westus" \
                                } \
                            }'

Thanks for the updates to the linter! Could we add the same changes here?

Thanks for the updates, especially to the linter! Could we add the same changes here?
We will be phasing out the core cli linter for the one in azdev...


Merge commands "show", "alias", "add", "search"

These 4 commands deal with projects and aliases. It would be better to have a single entry point instead of 4 different commands. The following need to be implemented:

alias (lists all aliases)
alias foo_ (lists all aliases starting with foo_)
alias foo_bar 123/456 (adds alias foo_bar, mapping it to 123/456)
alias 123 (lists all aliases defined for the given project)
alias 123/456 (shows the alias defined for the given project/activity tuple)
add foo_bar (searches for projects named foo_bar and interactively add an alias for one of its activities)
search foo_bar (lists projects named foo_bar)
show 123 (shows details of project 123)

We could use a notation similar to git remote:

alias (alias for "alias list", displays all aliases)
alias [list] foo_
alias [list] 123
alias [list] 123/456
alias add foo_bar 123/456
alias add foo_bar (equivalent to "add foo_bar")

Now the search and show commands are not directly related to aliases so maybe they should still be part of a projects commands or something like that...
Also this issue is a super-issue for:

https://github.com/sephii/taxi/issues/89
https://github.com/sephii/taxi/issues/87

is there anything preventing from using integer (123) as an alias? I guess not... meaning it would be hard to differentiate between alias foo_ and alias 123 above no?

That's a good point. Maybe we should then use a different subcommand to differentiate between alias and project searching?

Here's another proposal that would cover the commands alias, search, add, and show:

alias [list] [<search_string>] (lists all aliases, optionally only showing the ones that match the search string)
alias show [--reverse] <alias/id> (shows the mapping of a given alias or the reverse mapping by giving an id and showing the aliases that map to it)
alias add <alias> <mapping> (adds the given mapping)
project [list] [--add] [<search_string>] (lists all projects, optionally showing only the ones that match the search string. The --add option would replace taxi add)
project show <project_id> (shows the details of the given project id)

Fixed by https://github.com/sephii/taxi/commit/34ad147f11a9f75e974f1a4eb37988d08d7f1133.


Add options to buy the author a beer

I today realized that this tool has become a must have for me and looking at regular docker ps is painful. Thus, I would like to buy you a beer or two.
Please provide a way for me to do so :slightly_smiling_face:

Thanks :D
If you really want there is a buymeabeer link in my github profile.
But honestly I mostly made that tool for myself, and this issue makes me probably more happy than any donation.
It's just nice knowing that dops is actually used somewhere else (than by me and my direct colleagues).
(I wish github had a download counter :D)


use operators instead of lambdas when possible

The functions from the operator module are generally a bit faster than custom lambdas.
In case of numeric_range this speed up the code by a (admittedly rather insignificant) 10%:
%timeit list(numeric_range(0., 200000, 1))  # old
405 ms ± 8.16 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
%timeit list(numeric_range(0., 200000, 1))  # new
356 ms ± 5.19 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

and the overhead of creating a partial object compared to a lambda function is even for very short ranges almost negligable:
%timeit list(numeric_range(0., 2, 1))  # old
19.3 µs ± 119 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)
%timeit list(numeric_range(0., 2, 1))  # new
20.6 µs ± 203 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

Many thanks for running the performance tests.


chore(bench): include fixers in linter benchmarks

#5307  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on  Graphite


metabase: 0.48.7 -> 0.49.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/metabase/versions.
meta.description for metabase is: The easy, open source way for everyone in your company to ask questions and learn from data
meta.homepage for metabase is: https://metabase.com
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.48.8 in filename of file in /nix/store/8h2zcnscflk9avrpa71r4ihm6va4q4ii-metabase-0.48.8

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
metabase

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8h2zcnscflk9avrpa71r4ihm6va4q4ii-metabase-0.48.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A metabase https://github.com/r-ryantm/nixpkgs/archive/ce5bcdee50b134770fff773bd8919f4b38f44929.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ce5bcdee50b134770fff773bd8919f4b38f44929#metabase

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8h2zcnscflk9avrpa71r4ihm6va4q4ii-metabase-0.48.8
ls -la /nix/store/8h2zcnscflk9avrpa71r4ihm6va4q4ii-metabase-0.48.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

metabase

Maintainer pings
cc @schneefux @thoughtpolice @mmahut for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/metabase/versions.
meta.description for metabase is: The easy, open source way for everyone in your company to ask questions and learn from data
meta.homepage for metabase is: https://metabase.com
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.49.0 in filename of file in /nix/store/mqrlgbnrscqk2bb9c8b9g84b0n4bzayv-metabase-0.49.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
metabase

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mqrlgbnrscqk2bb9c8b9g84b0n4bzayv-metabase-0.49.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A metabase https://github.com/r-ryantm/nixpkgs/archive/d12adc1b1c7532df07fb3e670b23b7c5a0ba1bf8.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d12adc1b1c7532df07fb3e670b23b7c5a0ba1bf8#metabase

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mqrlgbnrscqk2bb9c8b9g84b0n4bzayv-metabase-0.49.0
ls -la /nix/store/mqrlgbnrscqk2bb9c8b9g84b0n4bzayv-metabase-0.49.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

metabase

Maintainer pings
cc @schneefux @thoughtpolice @mmahut for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/metabase/versions.
meta.description for metabase is: The easy, open source way for everyone in your company to ask questions and learn from data
meta.homepage for metabase is: https://metabase.com
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.49.1 in filename of file in /nix/store/07glc1wp8vp28k65s0h7wr50ag0nynh7-metabase-0.49.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
metabase

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/07glc1wp8vp28k65s0h7wr50ag0nynh7-metabase-0.49.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A metabase https://github.com/r-ryantm/nixpkgs/archive/319f491df89427f4bd0bab4f6b38c40611780b10.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/319f491df89427f4bd0bab4f6b38c40611780b10#metabase

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/07glc1wp8vp28k65s0h7wr50ag0nynh7-metabase-0.49.1
ls -la /nix/store/07glc1wp8vp28k65s0h7wr50ag0nynh7-metabase-0.49.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

metabase

Maintainer pings
cc @schneefux @thoughtpolice @mmahut for testing.


Add Windows COM Examples

Any plans to add windows com examples?
Context menu perhaps
https://code.msdn.microsoft.com/windowsapps/CppShellExtContextMenuHandl-410a709a
https://docs.microsoft.com/en-us/windows/win32/ad/implementing-the-context-menu-com-object

Thanks for reporting this. It definitely would be a good idea to have real world examples of COM APIs. Of course, pull requests are also very welcome! 😀

I have fairly many interfaces in my Virtual Desktops binding repo:
https://github.com/Ciantic/VirtualDesktopAccessor/blob/rust/src/interfaces.rs
It contains various input and output types, and works as a good example.
However, I'm not sure at all am I using this com crate correctly. I have some pending things to think about here:
https://github.com/Ciantic/VirtualDesktopAccessor/blob/a09c971500cc657a626dc794028d5c2a8bf8cb77/src/lib.rs#L172
I'm just not sure if the de-allocation is ever occuring for my ptrs.


Angular PWA Compatibility?

This looks awesome.
I've just started playing with Angular PWA. Making this work with Angular PWA structure shouldn't be hard but like I've said I don't have enough info on the subject yet. Is there an Angular example?
@davideast Have you seen this?

I don't have guidance specific to Angular at the moment, but with the way that Firebase Functions and Rendertron work together, it's not a huge leap to take a similar approach.
For instance, there's nothing specific in this example about the framework/lib; it just assumes you're using an app shell-style PWA. The only catch is the duplication of the initial shell in pwa.js, which you don't really have to do (I have a branch sitting locally that resolves this).
If there is a need for an Angular version of the this example, I'm sure we could sort that out.

AngularFirebase.com has an example. 👏🏻


one too many .Genomes in the name!

still need to work out how to get test token working in Github Actions unit tests, but unit tests are passing on command line.  self-merging to test in Narrative.  will not promote past beta without following full App release process.


fixes #1483 a bug with models namespace generation

fixes #1483
no generation diff as a change in the conversion library is required

@andrueastman thanks for the callout, I was already on it. Pushed a fix.


Single Quote in Comment Causes Incorrect Indentation on Following Source Lines

A single single-quote in a comment line causes an erroneous indentation error to be flagged on the following lines of source.
Simple example:
dcl-ds HEDINF                     based(p1@);
  HRLEN                 Int(10:0);                            // Record length
  HCRRN                 Int(10:0);                            // Cursor's RRN
  HCPOS                 Int(10:0);                            // Cursor's column
  HCCSID                Int(10:0);                            // CCSID of source
  HRECI                 Int(10:0);                            // Nbr of input rcds
end-ds;
dcl-s p2@          Pointer;

In the above example, the HCCSID and HRECI subfields will be flagged with Incorrect indentation. Expected 0, got 2.
The p2@ declaration is flagged with Incorrect indentation.  Expected -2, got 0.
The erroneous indentation error is caused by right-hand comments as well as full-line comments.  Also, note the error is not always thrown on the next line after the single single-quote.
Full-line comment example:
begsr displayHelp;
  // Do something with this program's
  //  name and library ... assume the program is running
  //  from the same library as contains the source.
  fileName = 'QRPGLESRC';
  library = pgSts.lib;

In the above example, the erroneous indentation error is first flagged on the setting of the fileName.

Context
Version

Code for IBM i version
2.14.5

Visual Studio Code version
1.96.0

Operating System
win32_x64

Active extensions
.NET Install Tool (vscode-dotnet-runtime): 2.2.3
COBOL (cobol): 24.11.28
Code Coverage for IBM i (code-coverage-ibmi): 0.1.7
Code for IBM i Walkthroughs (vscode-ibmi-walkthroughs): 0.5.0
Configuration Editing (configuration-editing): 1.0.0
Db2 for IBM i (vscode-db2i): 1.7.0
Dev Containers (remote-containers): 0.394.0
ESLint (vscode-eslint): 3.0.10
Emmet (emmet): 1.0.0
Error Lens (errorlens): 3.20.0
Extension Authoring (extension-editing): 1.0.0
Git (git): 1.0.0
Git Base (git-base): 1.0.0
GitHub (github): 0.0.1
GitHub Authentication (github-authentication): 0.0.2
GitHub Pull Requests (vscode-pull-request-github): 0.102.0
GitLens — Git supercharged (gitlens): 16.0.5
HTML CSS Support (vscode-html-css): 2.0.11
IBM i Notebooks (vscode-ibmi-notebooks): 0.0.6
IBM i Project Explorer (vscode-ibmi-projectexplorer): 2.12.0
JSON Language Features (json-language-features): 1.0.0
Jira and Bitbucket (Atlassian Labs) (atlascode): 3.0.15
Merge Conflict (merge-conflict): 1.0.0
NPM support for VS Code (npm): 1.0.1
Node Debug Auto-attach (debug-auto-launch): 1.0.0
Nx Console (angular-console): 18.33.1
Path Intellisense (path-intellisense): 2.10.0
Prettier - Code formatter (prettier-vscode): 11.0.0
RPGLE (vscode-rpgle): 0.28.2
Source Orbit (vscode-sourceorbit): 1.0.2
TODO Highlight (vscode-todo-highlight): 1.0.5
Todo Tree (todo-tree): 0.0.226
TypeScript and JavaScript Language Features (typescript-language-features): 1.0.0
WSL (remote-wsl): 0.88.5
YAML (vscode-yaml): 1.15.0

Remote system

Setting
Value

IBM i OS
V7R4M0

Tech Refresh
7

CCSID Origin
37

Runtime CCSID
37

Default CCSID
37

SSHD CCSID
?

cqsh
true

SQL
Enabled

Source dates
Disabled

Enabled features

/QOpenSys/pkgs/bin
/usr/bin
/QSYS.lib/ILEDITOR.lib
/QSYS.LIB
/QIBM/ProdData/IBMiDebugService/bin
/QOpenSys/QIBM/ProdData/JavaVM/jdk80

bash
attr
GETNEWLIBL.PGM
QZDFMDB2.PGM
startDebugService.sh
64bit

chsh
iconv

find
setccsid

git
uname

grep

ls

md5sum

sort

stat

tar

tn5250

Shell env
BUILDLIB=QGPL
CURLIB=QGPL
PASE_USRGRP_LIMITED=N
PATH=/QOpenSys/usr/bin:/usr/ccs/bin:/QOpenSys/usr/bin/X11:/usr/sbin:.:/usr/bin
SHELL=/QOpenSys/pkgs/bin/bash
SHLVL=1
SSH_CLIENT=<IP_ADDRESS> 54968 22
SSH_CONNECTION=<IP_ADDRESS> 54968 <IP_ADDRESS> 22
TZ=<EST>5<EDT>,M3.2.0,M11.1.0
_=/QOpenSys/usr/bin/env

Variants
{
  "american": "#@$",
  "local": "#@$",
  "qsysNameRegex": {}
}

@BrianGodsend Looking into this now. Related to changes for improved fixed-format support. Thanks for bringing this up!

@BrianGodsend I have a fix in place and I am going to make a release here soon.

0.28.3 has the fix.
If you find this is still an issue I will need another, bigger code example.

Thank you for such quick work!
The problem still persists if you define a constant for the single-quote and that is followed by another constant that includes two forward slashes.  (Just to point out, I normally do not define a constant for a single-quote, but, I did not write that line of code)
Example:
**FREE
dcl-c @QUOTE                   '''';

dcl-c @SOMETHING_IN_BETWEEN 'whatever';

dcl-c @SEUCOMMENT_FREE  '//&& ';
// ********************************************************************

dcl-ds copybookinfo_t           qualified template inz;
  qualObj;
  file                  Char(10)    overlay(qualObj: 1);
  lib                   Char(10)    overlay(qualObj: *NEXT);
  mbr                   Char(10);
  found                 Ind         inz(*OFF);
end-ds;
// ********************************************************************

In the above example the subfiles of copybookinfo_t are all flagged with an erroneous indentation error Incorrect indentation. Expected 0, got 2.  The end-ds and following comment are flagged with Incorrect indentation. Expected -2, got 0.
Note that this appears to happen no matter how much code is between the single-quote declaration (@QUOTE) and the following constant with the forward slashes (@SEUCOMMENT_FREE).  In fact I tested with various combinations of blank lines, comments, and other data structure definitions.  In all cases the indentation was correct until the forward slash constant definition.

FYI: The qualObj subfield with no data type or length is a valid syntax.  The qualObj will be auto-defined as a character field with a length long enough to support all of the overlayed fields (in this case Char(20) because of the overlayed file, Char(10), and lib, Char(10), subfields).

@BrianGodsend Thanks for your excellent test case. I have found a couple more slight issues and have a fix coming within the next 30 minutes or so.

Also, thanks for the FYI. That will have to be solved in a separate PR, but I have fixed the linting and parsing issue.

@BrianGodsend 0.28.4 is now available with the fix.

Getting closer (?).  It appears having a literal that has a space followed by a single quote causes things to go haywire.
**FREE
*in01 = 'yy' in %list('zz': ' ''');
*inLR = *ON;
return;

dcl-proc test;
  if specType = 'C' and not likelyComment;
    if not (%subst(srcDta: 7: 2) in
        %list('  ': 'L0': 'L1': 'L2': 'L3': 'L4': 'L5'
        : 'L6': 'L7': 'L8': 'L9': 'LR': 'SR': 'AN': 'OR'));
      return *ON;
    endif;
  endif;

  // If the line ends with a known end-of line character, then
  //  assume it is free format.  Make sure to strip any free-format
  //  comment first.  The stripping is not precise and will cause
  //  a free form line that has a '//' literal to not be detected.
  eol = ';';
  posStr = %scan('//': srcDta);
  if posStr > 1;
    evalr eol = %trim(%subst(srcDta: 1: posStr - 1));
  endif;
  if (eol in %list(';': ':': '+': '-': '/': '*': '=': '_'));
    return *ON;
  endif;

  // Despite our best guesses, we cannot confirm this to be a
  //  free format line, so indicate that it is _not_ free format.
  return *OFF;
end-proc;

In the above example, the literal ' ''' breaks the indentation checking.  Note that there must be a space in front of the quoted single quote in order to break the linter.

@BrianGodsend This one was really simple and actually bad coding on my part. Possibly a 1 character change to fix it. Again, thanks for a great test case.

@BrianGodsend 0.28.5 is coming out now. Give it a go and let me know.


Unexpected/unhandled error when decoding.

Hello, I was using this library to check if a number was in base32 using the decode function.
fn is_base32_number(s: &str) -> bool {
    match RFC4648.decode(s.as_bytes()) {
        Ok(_) => true,
        Err(_) => false,
    }
}

When I pass a string that has a length less than 6 to the function, it panics with a "attempt to subtract with overflow" without throwing a DecodeError, which is caused by the following function: https://github.com/rogusdev/fast32/blob/e9d804855ec8659e056c0e760ba88d8b5c65f6ea/src/base32/alphabet.rs#L154, more specifically where it tries to index a[len - 6].
I made what i feel like is a bandaid fix, but I have only been writing rust for like a week or 2 so I am not sure if it follows the best conventions and guidelines.
I am sure this is not an intended function of decode method, but from what I have been reading it would follow Rust conventions to make it as safe as possible.

Can you clarify what kinds of input you are passing to this function? RFC4648 is a padded alphabet, so you would expect to see strings like MY====== as in https://github.com/rogusdev/fast32/blob/e9d804855ec8659e056c0e760ba88d8b5c65f6ea/tests/base32.rs#L530 . But if you are trying to check numbers rather than arbitrary strings, you shouldn't be using a padded alphabet anyway, you should be using something like CROCKFORD or RFC4648_HEX_NOPAD .
Your point that perhaps this should be returning a result instead of just panic-ing is certainly valid, but it also sounds like you might be sending invalid input to the function from what you are describing.


[gpu] add support for Dataproc 2.2 images

Include open drivers on Debian 12

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

tests keep failing due to lack of quota.  I think the tests need to be run during India business times since us-central1 might be quieter at that time.

/gcbrun

Fixed in another branch


⚠ ClamAV has degraded performance

In ec046f4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 152 ms

Resolved: ClamAV performance has improved in cad984a.


Rename directories for more consistency

We found the directory structure to be confusing. It took a little while for us to determine there where different versions of node. I have not changed the underlying naming scheme. For example, jenkins-slave-maven-rhel7 is still the name of the image.

/assign @gabemontero

The directory names are aligned to the image names they produce, I don't think we should change that, it's the same pattern we follow in our other repos.
Perhaps the readme can be enhanced to make it clearer what the directories represent.

@bparees I thought that might be the case. I will look into updating the readme. Thanks!

OK closing this PR out based on the prior discussion.


Update spec to use block oracle terminology

Description
This PR renames state oracle -> block oracle. The reason is because it seems advantageous to finalize block hashes as opposed to state root hashes considering it is not added complexity & will allow us to prove the validity of logs.
Additional context
One could argue that the term 'block' is less general than state & being super generalized is beneficial. However, doesn't seem obvious to me that the benefits of generality outweigh the nice mental model that finalizing blockhashes provides. This is especially true considering we can use an L1 Block Oracle for fraud proofs, and then use an L2 Block Oracle for withdrawals, and each can share the same APIs. Being able to reuse code there & concepts there seems very beautiful.

@maurelian and I discussed this & decided that block oracle > block hash oracle.
@ben-chain very curious if you have opinions on this.

I think that L2 Block Oracle is good.  The only confusing thing to watch out for is that we also want an L1 blockhash oracle, which is has some chances for name collisions/confusions. Overall I think I still approve of this PR.

One could argue that the term 'block' is less general than state

IMO the term 'state' is excessively general, but also overloaded with possible specific meaning, as it's common to use 'state' to refer to accounts and storage. For example, a solidity dev is likely to say "view functions do not change state". That is wrong in the sense that they cost gas and reduce the balance of tx.origin.
'Block' seems like a better defined term, (and happens to contain a stateRoot field), so Iike that.

Alright I'll merge!


Export Module Completion error

Hello, here is the issue I have when I use this plugin.
Description
Adding import creates a lot of error, and makes Atom freeze when I import multiples variables or functions on the same line.
Steps to Reproduce

Create a test file

test.js
export const test = () => "Hello";

export const test2 = () => "World";

Try to include test from another file

index.js
import {test} from "./test";

Select the text inside the brackets and edit it to add test2 to have it like this

import {test, test2} from "./test";

Expected behavior: It works fine
Actual behavior: It prints a lot of log inside the developer tools console. It is even worse when you add import with long names on the same line, Atom freeze. And I can only force close it.
Reproduces how often: Every time
Console errors

Versions
macOS High Sierra
Atom : 1.25.0-beta2 x64
autocomplete-modules : 1.11.0
Additional Information
I'm not sure if this an Atom Issue or autocomplete-modules issue.
I will be glad to help :)

I will be glad to help :)

@callain
Would you like to try to put in a PR for this?
Something happened while it was trying to require test.js.

I will try ;)

Since changes to the package. This should be tested to see if it is still an issue.

Tested and working on version 2.2.0


Records not getting added but no errors in the logs

Hi,
I've been trying external-dns to automatically create DNS records for Kubernetes services. The GKE cluster was set up with the correct scope (https://www.googleapis.com/auth/ndev.clouddns.readwrite), the Google Cloud DNS zone is hosted in the same project as the GKE cluster. I deployed version 0.4.2 of external-dns.
The deployment of external-dns within GKE is pretty much the same as example from tutorial with exception that I added a serviceAccountName within the containerspec. That points to a custom SA with read permissions on the services and ingresses.
When I create a service of type=LoadBalancer I see in the pod's logs that an entry is being created. However, every minute this is logged and the entry never shows up in the DNS zone.

time="2017-08-16T19:16:42Z" level=info msg="Add records:my-app. A [130.x.x.x]"
time="2017-08-16T19:16:42Z" level=info msg="Add records: my-app. TXT ["heritage=external-dns,external-dns/owner=myid"]"
time="2017-08-16T19:17:42Z" level=info msg="Add records: my-app. A [130.x.x.x]"
time="2017-08-16T19:17:42Z" level=info msg="Add records: my-app. TXT ["heritage=external-dns,external-dns/owner=myid"]"

It's probably a permission issue but I have no idea where to look next.
Any ideas?
Thanks
Roland

please show complete external-dns manifest

kind: Deployment
metadata:
  name: register-dns
  namespace: register-dns
spec:
  strategy:
    type: Recreate
  template:
    metadata:
      labels:
        app: register-dns
    spec:
      serviceAccountName: register-dns-serviceaccount
      containers:
      - name: register-dns
        image: registry.opensource.zalan.do/teapot/external-dns:v0.4.2
        args:
        - --source=service
        - --domain-filter=my.test.domain
        - --provider=google
        - --google-project=my-project
        - --registry=txt
        - --txt-owner-id=myid

please add --debug flag and post the printed logs

Hi,
Thanks for helping. The --debug flag didn't show a lot of additional information.
However, I found the issue: my service definitions annotation was incorrect.
The hostname needs to be fqdn and I had just the hostname part. I was under the impression that the external-dns tool would add the DNS zone part.

external-dns supports multiple dns zones, therefore it requires fqdn to be specified. Closing this issue

Had a similar problem where I misspelled the domain in the annotation. However the log output is looking like nothing wrong with Add records: ... and there is no errors or any notes about that the domain was filtered.
It would be helpful if there was a statement that it got filtered or not printing it like that it was added.


Fzf command with popup window in vim changes jumplist

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues
[x] I have fzf 0.30.0 or above
[x] I have read through https://github.com/junegunn/fzf.vim/blob/master/README.md
[x] I have read through https://github.com/junegunn/fzf/blob/master/README-VIM.md

Info

OS

[X] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] vim

Problem / Steps to reproduce

When using a popup window with any fzf command the jumplist is modified, using full screen fzf commands with ! works correct. I tried looking into the fzf.vim code, but I can't pin it down. Is it an issue with fzf.vim or with vim itself?
:jumps
 jump line  col file/text
   6     1    0 .zsh_history
   5     1    0 code/linux/crypto/async_tx/Kconfig
   4 10544    0 .zsh_history
   3    12    0 code/linux/crypto/async_tx/Kconfig
   2     1    0 code/linux/certs/blacklist.c
   1    27    0 code/linux/crypto/async_tx/Kconfig
>  0     1    0 /* SPDX-License-Identifier: GPL-2.0-or-later */
   1     1    0 .vimrc
   2   350    0 .vimrc
   3   372    0 code/linux/certs/blacklist.c
   4     2    0 .vimrc

:Maps "or any other fzf.vim command

:jumps
 jump line  col file/text
  12     1    0 .zsh_history
  11     1    0 code/linux/crypto/async_tx/Kconfig
  10 10544    0 .zsh_history
   9    12    0 code/linux/crypto/async_tx/Kconfig
   8     1    0 code/linux/certs/blacklist.c
   7    27    0 code/linux/crypto/async_tx/Kconfig
   6     1    0 /* SPDX-License-Identifier: GPL-2.0-or-later */
   5     1    0 .vimrc
   4   350    0 .vimrc
   3   372    0 code/linux/certs/blacklist.c
   2     2    0 .vimrc
   1     2    0 /* Internal definitions for asymmetric key type
>

Thanks, I can reproduce. This only seems to happen when we open fzf in a popup window.
" Jumplist unaffected
let g:fzf_layout = { 'down': '40%' }
let g:fzf_layout = { 'tmux': '-p90%,60%' }

The problem is reproducible with :FZF, so you don't need to look into the code of fzf.vim project.

This fixed it for me, but let me know if you still have the issue.


add test cases for fedora|centos|rhel

Currently the test suite of runc is based on a ubuntu docker image, runc/script/test_Dockerfile.
This PR adds test suite Dockerfiles for fedora-based, centos-based, rhel-based docker image.

@rhatdan , @mrunalp , PTAL.
test_Dockerfile_fedora and test_Dockerfile_centos have been tested on the runc master + https://github.com/opencontainers/runc/pull/901.
I will give test_Dockerfile_rhel a new try on RHEL 7 VM.

Surely it matters more what the host kernel is? Docker containers don't have systemd or anything else that might make the tests different on different distributions. Or am I missing something?

We have found several issues in the past with running docker tests on our distribution rather then just running the default.  Going through this process has already found a couple of issues with runc on older kernels/userspaces.

That's interesting, I wouldn't have expected that (at SUSE we run all of the integration tests inside a virtual host (not in a container)).

@rhatdan , @mrunalp , I just rebased this branch on top of the upstream master. According to git log, I do not think I really did anything incorrectly. However, this PR starts showing all the commits since the PR was first created.
Is there some way to fix this?

You need to rebase your master branch as well. The diff of this PR is based on what branch you want to merge into.

@cyphar , thanks.
I recently shifted the directory for developing my feature branches from $GOPATH/src/github.com/hmeng-19/runc to $GOPATH/src/github.com/opencontainers/runc.
I just rebased my branch on the upstream master, and forgot rebasing on my master.


Not all sent parameters were read - OTOCO

I tried to place an OTOCO order, I got an error
params = {
  "symbol": "BTCUSDT",
  "workingSide": "BUY",
  "workingType": "LIMIT",
  "workingPrice": "80000",
  "workingQuantity": "0.0015",
  "workingTimeInForce": "GTC",
  "pendingSide": "SELL",
  "pendingQuantity": "0.0015",
  "pendingAbovePrice": "90000",
  "pendingAboveType": "LIMIT_MAKER",
  "pendingBelowPrice": "70000",
  "pendingBelowStopPrice": "60000",
  "pendingBelowType": "STOP_LOSS_LIMIT",
  "pendingTimeInForce": "GTC",
}
try:
    response = client.new_otoco_order(**params)
    logging.info(response)
except ClientError as error:
    logging.error(
        "Found error. status: {}, error code: {}, error message: {}".format(
            error.status_code, error.error_code, error.error_message
        )
    )

output
ERROR root: Found error. status: 400, error code: -1104, error message: Not all sent parameters were read; read '15' parameter(s) but was sent '16'.

Hey,
You should replace pendingTimeInForce with pendingBelowTimeInForce. While pendingTimeInForce is optional, pendingBelowTimeInForce is required when pendingBelowType is set to STOP_LOSS_LIMIT. For more details, you can refer to the documentation.


Fixed #31965 -- Adjusted multi-table fast-deletion on MySQL/MariaDB.

ticket-31965

The optimization introduced in 7acef095d73 did not properly handle deletion involving filters against aggregate annotations.
It initially was surfaced by a MariaDB test failure but misattributed to an undocumented change in behavior that resulted in the systemic generation of poorly performing database queries in 5b83bae031.
Thanks @harmant for the report.
Refs #23576.

@charettes Thanks :star:


Workbox Admin Page and/or Workbox in page GUI

Just had this idea across a few issues and wanted to just mention this:

Have a page that could be current state of the world from workbox's P.O.V /__workbox/admin. This would only be available in dev builds.
Have an option to inject a script into the developers page that would display a GUI to callout Workbox service worker is controller the page and perhaps offer additional options.

Were you thinking this would be a togglable overlay (a la React/Vue) or a dedicated admin page (BrowserSync)?

I was thinking move the browsersync seperate page. Only reason for seperate page is that way we can intercept a specific URL and do whatever we want.
Adding code and markup for an overlay feels somewhat risky / error prone.

Little to no traction on this so going to close.


Support for Spring Boot 3 (Spring 6)

I was trying out this library with the current Spring Boot 3 milestone and got this error. The reason is that the library uses imports from org.thymeleaf.spring5 and these don't exist as a dependency in Spring Boot 3 anymore. Instead, the imports should be made from org.thymeleaf.spring6.
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'io.github.wimdeblauwe.hsbt.mvc.HtmxMvcConfiguration': Resolution of declared constructors on bean Class [io.github.wimdeblauwe.hsbt.mvc.HtmxMvcConfiguration] from ClassLoader [jdk.internal.loader.ClassLoaders$AppClassLoader@1de0aca6] failed
	...
Caused by: java.lang.NoClassDefFoundError: org/thymeleaf/spring5/view/ThymeleafViewResolver
	...

Hi Tom, thanks for informing me about this! I'll look into it later, but it won't be in the first coming weeks I am afraid.

@thombergs That sounds like we won't be able to support both Spring 5 and Spring 6 at the same time. Right?

@thombergs I just pushed the branch spring-6-boot-3. If you build that locally using mvn install, then you could test it locally.

The version number has been set to 2.0.0-SNAPSHOT for now. I would use 1.x for Spring 5 versions and 2.x for Spring 6 versions.

Do you think we can have this rolled into a 2.0 M1 pretty soon? I have a lecture at Tu Dresden next week and would like to use this in a sample built on Spring Boot 3.

Having snapshots deployed would help as well.

@odrotbohm I will try to have a version this morning, but I am unable to fix the change away from spring.factories. I had this before:
org.springframework.boot.autoconfigure.EnableAutoConfiguration=\
  io.github.wimdeblauwe.hsbt.thymeleaf.HtmxThymeleafConfiguration,\
  io.github.wimdeblauwe.hsbt.mvc.HtmxMvcConfiguration
org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc=\
  io.github.wimdeblauwe.hsbt.thymeleaf.HtmxThymeleafConfiguration,\
  io.github.wimdeblauwe.hsbt.mvc.HtmxMvcConfiguration

Which enabled the autoconfiguration on tests that use MockMvc (e.g. @WebMvcTest). How can I have this again in the new system?

Never mind, just found it. I need to create a separate org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc.imports file now.
The wording in the release notes is a bit confusing:

If you have created your own test-slices, you should move the registration from spring.factories to the new place under META-INF/spring/.imports.

I am not creating my own test-slices, I am configuring extra classes on existing test slices like @WebMvcTest.

@thombergs @odrotbohm You should be able to use version 2.0.0-M1 now with Spring Boot 3.0.0-M5: https://github.com/wimdeblauwe/htmx-spring-boot-thymeleaf/releases/tag/2.0.0-M1

Th legacy auto-configuration format was removed in 3.0 M5. The release notes for 3.0 are a bit cluttered right now as we want folks to see what has changed for individual milestones until the GA release. After that, they'll be consolidated into a single document and the change is likely to be easier to find.
Thanks for the release, Wim!


[Dep] Revert "Upgrading Protobuf to v27.0 (#36753)"

This reverts commit 0ffab555345b00d82fd09281cc7c00b956433407.

@veblush FYI


Is supervised-fine-tune.py required to run merge_lora_weight after fine-tuning?

Hi! I don't know how to use the full-fine tuned model
I used the checkpoint output directly as the "base_model" in the inference.py, but got the "cannot find config.json" error. Do I need to run this?
 python3 merge_lora_weights_and_save_hf_model.py \         --base_model /pretrained/llama2/Llama-2-13b-chat-hf/ \         --peft_model /llama/LongLoRA/outputs/ \         --context_size 16384 \         --save_path /llama/LongLoRA/merged/Llama-2-13b-long-16k-merged
But I got the error when running this script
Traceback (most recent call last):   File "/mnt/Data/chen19/llama/LongLoRA/merge_lora_weights_and_save_hf_model.py", line 113, in <module>     main(args)   File "/mnt/Data/chen19/llama/LongLoRA/merge_lora_weights_and_save_hf_model.py", line 108, in main     model.save_pretrained(args.save_path)   File "/mnt/Data/chen19/anaconda3/envs/llama-2/lib/python3.9/site-packages/transformers/modeling_utils.py", line 1833, in save_pretrained     os.makedirs(save_directory, exist_ok=True)   File "/mnt/Data/chen19/anaconda3/envs/llama-2/lib/python3.9/os.py", line 215, in makedirs     makedirs(head, exist_ok=exist_ok)   File "/mnt/Data/chen19/anaconda3/envs/llama-2/lib/python3.9/os.py", line 225, in makedirs     mkdir(name, mode) PermissionError: [Errno 13] Permission denied: '/merged'
Thanks

Hi! I don't know how to use the full-fine tuned model I used the checkpoint output directly as the "base_model" in the inference.py, but got the "cannot find config.json" error. Do I need to run this?  python3 merge_lora_weights_and_save_hf_model.py \ --base_model /pretrained/llama2/Llama-2-13b-chat-hf/ \ --peft_model /llama/LongLoRA/outputs/ \ --context_size 16384 \ --save_path /llama/LongLoRA/merged/Llama-2-13b-long-16k-merged
But I got the error when running this script Traceback (most recent call last): File "/mnt/Data/chen19/llama/LongLoRA/merge_lora_weights_and_save_hf_model.py", line 113, in <module> main(args) File "/mnt/Data/chen19/llama/LongLoRA/merge_lora_weights_and_save_hf_model.py", line 108, in main model.save_pretrained(args.save_path) File "/mnt/Data/chen19/anaconda3/envs/llama-2/lib/python3.9/site-packages/transformers/modeling_utils.py", line 1833, in save_pretrained os.makedirs(save_directory, exist_ok=True) File "/mnt/Data/chen19/anaconda3/envs/llama-2/lib/python3.9/os.py", line 215, in makedirs makedirs(head, exist_ok=exist_ok) File "/mnt/Data/chen19/anaconda3/envs/llama-2/lib/python3.9/os.py", line 225, in makedirs mkdir(name, mode) PermissionError: [Errno 13] Permission denied: '/merged'
Thanks

Solved, I should not mkdir in advance.


API to use ng-admin features in my custom page

Hello
I need to create totally custom page but I still want to use some features:

CRUD API for existing entities
Custom fields (date, reference, etc)

How can I do it?

Dive in the ng-admin source and use the directives and classes that you want!


Types: embed.setColor() not showing ColorResolvable or number[]

Issue description
According to the guide:

The .setColor() method accepts a ColorResolvable, e.g. an integer, HEX color string, an array of RGB values or specific color strings.

However, the typescript decleration file only shows:
setColor(color: number | null): this;

The typings are not representative of what can actually be used.
Code sample
No response
@discordjs/builders version
0.9.0
Node.js version
Node v17.2.0, Typescript v4.5.3
Operating system
MacOS
Priority this issue should have
Low (slightly annoying)

Ok, so it turns out discord.js exports its own MessageEmbed class, which is separate from the Embed class in this package. Talk about confusing.


For LED lights

Hi I am interested in your ac_dimmer library and would like to build a homekit example.
What components did you use, and is this dimmer suitable for LED lighting?

This dimmer usually works for incandescent light bulbs,  but you can buy "dimmable" LED bulbs which also work. Non-dimmable LED bulbs will not like it.
To control, you need a zero-crossing dimmer like this one.


fixed the build script crashes for python versions < 3.9

the build.py was crashing with an ambiguous error in case of python versions < 3.9. I added a check of the python version to display a message that a newer version of python is needed to run the build.py.

What was the ambiguous error? build.py already runs the prereqs.py script (at line 66) which checks the Python version is 3.11 or later.

What was the ambiguous error? build.py already runs the prereqs.py script (at line 66) which checks the Python version is 3.11 or later.

Here is the error:
(envpython) (base) XPSHDD:~/qsharp/qsharp$ python ./build.py
Traceback (most recent call last):
File "./build.py", line 43, in
action=argparse.BooleanOptionalAction,
AttributeError: module 'argparse' has no attribute 'BooleanOptionalAction'
(envpython) (base) XPSHDD:~/qsharp/qsharp$ python --version
Python 3.8.10

@deepbrain sorry for the delay on this. The bug is worth fixing (thanks for catching!), but we suggest a slightly different way of handling this:

Check for 3.11 instead of 3.9 since that's our actual minimum version (see prereqs.py)
Remove the redundant check in prereqs.py.
Put the check in prereqs.py, but outside of check_prereqs() so that it runs both when running prereqs.py and build.py (but before argument parsing)

If you'd like to make these changes to the PR, I'll go ahead and merge. Thanks!


go<EMAIL_ADDRESS>invalid version: unknown revision v3.0.97

go<EMAIL_ADDRESS>invalid version: unknown revision v3.0.97

v3 is deprecated, please use v1.0.xxx .

As for now v1.0.449 is the latest version.


Fails to connect to Quicken ODBC (Qodbc)

What steps will reproduce the problem?

1. import pyodbc
2. cnxn = pyodbc.connect('DSN=myQodbcDsn')
3. (Failure!)

What is the expected output? What do you see instead?

It gives a failed call to qodbc saying that it was missing some ODBC
register or something to that effect (I've since removed qodbc and pyodbc
as the project cannot continue without quickbooks connectivity)

What version of the product are you using? On what operating system?

Using qodbc version 9.0 and pyodbc 2.1.5

Please provide any additional information below.

Pyodbc works peachy with mysql, but fails on connection to qodbc. Kind of
disappointing. There's a free version of Qodbc you can tryout, assuming you
have a quickbooks file. And since it's ODBC this is a windows only issue.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 14 May 2009 at 6:05

HI,
Please download latest version of QODBC  from www.qodbc.com
For 32 bit
cnxn = pyodbc.connect('DSN=QuickBooks Data QRemote;') or
cnxn = pyodbc.connect('DSN=QuickBooks Data QRemote;Trusted_Connection=yes')
For 64-bit
cnxn = pyodbc.connect('DSN=QuickBooks Data 64-bit QRemote;') or
cnxn = pyodbc.connect('DSN=QuickBooks Data 64-bit QRemote;Trusted_Connection=yes')
If you are still facing issue. please create a ticket at http://support.qodbc.com/
When submitting first level support ticket please share following

Screenshot of QODBC Setup Screen -- > About    (Start>>All Programs>> QODBC Driver for use with QuickBooks>> QODBC Setup Screen >> About Tab )
Screenshot of the issue you’re facing.
SQL Statement having issue
Screenshot of the application having issue
Sample code (if any)   ( as attachment )
Log Files from
QODBC Setup Screen -- > Messages -- > Review QODBC Messages  ( as attachment )
QODBC Setup Screen -- > Messages -- > Review SDK Messages  ( as attachment )

Refer: How to take screenshot: www.qodbc.com/links/screenshot.htm
--
Regards
Raj

Rajendra Dewani
Support Supervisor, QODBC & QODBC-POS
FLEXquarters.com Limited


fix memory leak

sqlitefts crashes because it has a memory leak

fixed one leak. reopen it as needed.


OLS-648: Fix DevConfig types

Description
Fix DevConfig types
Type of change

[x] Refactor
[x] Bug fix

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@3569f9a). Learn more about missing BASE report.
Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1259   +/-   ##
=======================================
  Coverage        ?   94.74%
=======================================
  Files           ?       57
  Lines           ?     2436
  Branches        ?        0
=======================================
  Hits            ?     2308
  Misses          ?      128
  Partials        ?        0

Files
Coverage Δ

ols/app/models/config.py
96.53% <100.00%> (ø)

ols/utils/auth_dependency.py
77.55% <100.00%> (ø)

/lgtm

/approve


fix: provide a sensible example for a privateca Root CA example

This one looks a lot like someone copied by accident the subordinate example out of certificate_authority_subordinate/main.tf as a root CA. Thus it contains a lot of values set which are outright invalid or not recommend for Root CA certficates if you consider RFC 5280 and CA/B Baseline Requirements as the standard to follow.
Also the subordinate example is a bit odd, e.g. configuring SAN on any kind of CA certificate doesn't make sense. And the resources examples there make use of the same pool name.
I tried to keep the lifetime setting, but set it to 99 years. That is probably a sensible value for a P(rivate)KI setup. For something public 10y or 15y are probably more sensible.
Description
Fixes #630
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness

[] Yes, merge this PR after it is approved
[X] No, don't merge this PR after it is approved

Testing

[ ] I have performed tests described in the Contributing guide:

[ ] Tests pass: terraform apply
[ ] Lint pass: terraform fmt check

--> this should get a test run somewhere, right now I don't have a test setup at hand to validate it against the API of the CAS

/gcbrun

@msampathkumar Can you help add @pmansour to the list of reviewers?

This PR has been inactive for two months. If this inactivity continues for another two weeks, I will close the request.

@msampathkumar I updated the PR long ago with the proposed changes by @pmansour. Thus it's just waiting for a review by you/your team. :)

/gcbrun

/gcbrun

Can I do anything else to help you to review this PR and get it a state you can merge?

/gcbrun

I haven't been able to find a subject matter expert on this, but looking at the changes made, it seems reasonable. I'm not an expert on RFC5280, but removing some of the extra fields appears to match what modules do (e.g.. csa-certificate-authority-service)

/gcbrun


updated docs to reflect pr 152

Updated docs to reflect changes in PR https://github.com/Styren/symbiosis/pull/152

Current dependencies on/for this PR:

main

PR #11   👈

This comment was auto-generated by Graphite.


No module can depend on :app

Task/Issue URL: https://app.asana.com/0/488551667048375/1202717423070870/f
Description
Ditto
Steps to test this PR

[ ] add implementation project(path: ':app') to any module that is not the :app module
[ ] you should get an error in the IDE or terminal saying that you can't do it

Current dependencies on/for this PR:

develop

PR #2135   👈

This comment was auto-generated by Graphite.


Quadratic performance on left-associated binds

The problem
Consider walking over a tree using a streaming library to do something at every leaf:
data Tree = Branch Tree Tree | Leaf Int

walkTreeTransformer :: (Monad (m IO), MonadTrans m)
                    => (Int -> IO ()) -> Tree -> m IO ()
walkTreeTransformer doSomething = loop
  where loop = \case
          Leaf i -> lift (doSomething i)
          Branch t1 t2 -> do
            loop t1
            loop t2

On left-skewed trees, i.e. trees that will end up generating left-associated binds, for example those generated by leftSkewed
-- Fully evaluated left-skewed tree
leftSkewed :: Int -> Tree
leftSkewed 0 = Leaf 0
leftSkewed n = (Branch $! leftSkewed (n - 1)) (Leaf n)

the performance of your streaming library is quadratic. In fact performance is quadratic under

streaming
pipes: https://github.com/Gabriel439/Haskell-Pipes-Library/issues/234
conduit: https://github.com/snoyberg/conduit/issues/474

(The only streaming library I know of whose performance is not quadratic is streamly.)
The plot below demonstrates the claim. The code to generate the plot is available at https://github.com/tomjaguarpaw/streaming-benchmark. The compiler was GHC 8.10.7.

The solution
Firstly, before talking about a solution, do you actually consider this a bug? I do, and I think the risk of hitting unexpected quadratic performance makes this library unsuitable for production use as it is. On the other hand maybe you have a good reason that I shouldn't think that. If so I would be interested to hear it.
If you do think this is a bug then let's think about what can be done. I know of two straightforward options:

Add an explicit constructor for binds and then reassociate binds during elimination
Use Codensity (streamly essentially uses handwritten Codensity.)

In my benchmarks explicit bind comes out slightly ahead.
Perhaps there is another option more suitable for your library.
I welcome your thoughts.

This paper https://rubenpieters.github.io/assets/papers/JFP20-pipes.pdf presents similar results, it has some more benchmarks as well. @tomjaguarpaw its nice to see that you have presented a solution as well. Looks neat.

@tomjaguarpaw Here's another data point. While working on streamly, I experimented with changing streaming' s representation to be more like streamly's (and vector's) internal representation which can be found at streaming-fusion.
Here is that library added to the benchmark:

@pranaysashank, I find the colors on that graph really hard to work out. Could you rearrange the key from top to bottom or something?

@treeowl I don't know enough about gnuplot to modify the generated image. So I just updated the comment with the keys top to bottom

[N.B. conduit doesn't have quadratic performance. I made a mistake when setting up the benchmarks: https://github.com/tomjaguarpaw/streaming-benchmark/commit/2a965a790c23c759c70ac580b25c59fd22ae922c]

While working on streamly, I experimented with changing streaming' s representation to be more like streamly's

Yup, makes sense that the performance is similar to streaming when I wrapped it with Codensity. I find it interesting that streaming with explicit binds is faster still!

The Bind implementation is nice, I changed the MonadTrans instance of streaming-fusion to be more like the streaming bind implementation and looks like it improves the performance quite a bit!!

@pranaysashank Wow! That's impressive.


Remove deprecated use of mock annotation

Purpose
Remove deprecated use of mock annotation
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Fix for https://github.com/ballerina-platform/ballerina-lang/issues/27480

Fix for https://github.com/ballerina-platform/ballerina-lang/issues/27480


FLUME-3268:Introducing micro batch processing to HDFSEventSink

Can one of the admins verify this patch?


added netcdf to ci dependencies

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2c027e4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #1   +/-   ##
========================================
  Coverage          ?   42.3%
========================================
  Files             ?       1
  Lines             ?      52
  Branches          ?       7
========================================
  Hits              ?      22
  Misses            ?      30
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c027e4...67c50a2. Read the comment docs.


Unable to write metadata for song!

When I try to download a particular song, I get "Unable to write metadata for song!
How can I resolve this issue?

Hi, can you please share the log file with name spotidl.log found at home directory?

09/02/2024 10:37:14 PM | WARNING: Couldn't read cache at: .cache
09/02/2024 10:37:18 PM | WARNING: Couldn't write token to cache at: .cache
09/02/2024 10:37:30 PM | ERROR: error 指定されたパスが見つかりません。 (os error 3) opening song file "C:\Users\tokut/dl\再生\→真逆様←.opus" for writing metadata
09/02/2024 10:40:01 PM | WARNING: Couldn't read cache at: .cache
09/02/2024 10:40:05 PM | WARNING: Couldn't write token to cache at: .cache
09/02/2024 10:40:08 PM | ERROR: error 指定されたパスが見つかりません。 (os error 3) opening song file "C:\Users\tokut/dl\再生\5 →真逆様←.opus" for writing metadata

Thanks for sharing this, can you please try running the app as admin? For windows, that would require opening the terminal/command line as admin and then running spoti-dl.

Thank you, I was able to download the desired sound source!
However, when I tried to download another sound source, the problem occurred again.
Here is the contents of the log file.

21/02/2024 09:32:20 PM | WARNING: Couldn't read cache at: .cache
21/02/2024 09:32:23 PM | WARNING: Couldn't write token to cache at: .cache
21/02/2024 09:32:26 PM | ERROR: error 指定されたパスが見つかりません。 (os error 3) opening song file "C:\Users\tokut/dl\futuring Prod.Morning Lemon\futuring ProdMorning Lemon.opus" for writing metadata

Okay, I see. I will look into this.
Thanks for reporting this issue.

@nethakha Hey, sorry for the late update -- was having issues with my systems and hence was unable to build the Windows version of the app for a long time.
Can you please update the app to version 2.1.2 -- it should fix your issue now.
python3 -m pip install --upgrade spoti-dl==2.1.2 or pip install --upgrade spoti-dl==2.1.2 is what you need to do, might need adjustments since python setup can vary from system to system.

Thanks for the update.
I tried it but it did not work.
Below is the log.
13/06/2024 05:06:28 PM | WARNING: Couldn't read cache at: .cache
13/06/2024 05:06:30 PM | WARNING: Couldn't write token to cache at: .cache
13/06/2024 05:06:31 PM | ERROR: error 指定されたファイルが見つかりません。 (os error 2) opening song file "C:\\Users\\tokut\\dl\\futuring ProdMorning Lemon.opus" for writing metadata

I don't know if this is related, but it appears that the ". seems to have been removed from the file name.
The name of the song is "futuring Prod.Morning Lemon", but in the log it is "futuring ProdMorning Lemon".
I hope the problem will be resolved.

Oh right, that could be the case. I'll look into this when time permits, and get back to you.
Could you please share the song link(s) that caused you the trouble?

This song.
https://open.spotify.com/intl-ja/track/5amIghCsQS7andDFxrvNi3?si=2914aaee57ba4b4d

Could you share what command are you using exactly, and the path to the dl folder (running just cd in your terminal will show the path)? I tried downloading the same song on my windows machine and had no issues there. There might be some permission issues, can you try downloading the song in some other drive other than the c: drive?
The . (and other characters) in the song name is replaced to avoid any issues when creating files, so that's not the issue here.

We tried the following three commands.
spoti-dl spotify:track:5amIghCsQS7andDFxrvNi3
spoti-dl https://open.spotify.com/intl-ja/track/5amIghCsQS7andDFxrvNi3
spoti-dl https://open.spotify.com/intl-ja/album/6tAqWourYOmhQikvkEzwk3

The dl folder is located directly under the user directory.
C:\Users\tokut\dl

I tried executing it by specifying a download destination to a drive other than the C drive, but the result did not change.


Add support for gettid() to PatternEncoder

Add {i} and {tid} to allow logging in particular the Linux
thread ID as returned by gettid(). This is very useful for
system-wide debugging und monitoring with consistent
thread/task IDs.
Fixes: #231

Two build errors. I'll take a look later.
error[E0658]: `cfg(rustdoc)` is experimental and subject to change
  --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\gettid-0.1.2\src\lib.rs:16:55
   |
16 | #[cfg(any(target_os = "linux", target_os = "android", rustdoc))]
   |                                                       ^^^^^^^
   |
   = note: for more information, see https://github.com/rust-lang/rust/issues/43781

error[E0433]: failed to resolve: use of undeclared crate or module `gettid`
  --> src/encode/mod.rs:33:34
   |
33 |     pub(crate) static TID: u64 = gettid::gettid()
   |                                  ^^^^^^ use of undeclared crate or module `gettid`

The gettid crate seems to use the unstable compilation flag cfg(rustdoc). The issue is that we build for stable rust and unstable compilation flags are unavailable on the stable channel of rust. I don't love that the crate has no tests.
I found another crate which has a seemingly more complete impl. I also like that it leverages nix which is know to be high quality software. The downside of the palaver crate is it seems maintenance has lapsed, and latest version is an alpha release from 2020.
It's a little unclear what to do from here, maybe bug the palaver authors or steal their implementation and add a comment linking back to an issue requesting they stabilize their api, so when that happens we can just pull them in...

I had some similar thoughts about gettid crate. I was thinking of asking the thread-id people if the would add gettid() to their crate. (I didn't know about palaver.) log4rs already depends on it and thread-id seems like a good place to add support. What do you think about this?

@cloneable that sounds like a great plan. Lmk if there is anything I can do to help.

So I looked at palaver and it seems like a well written library, but I agree that owners may have stopped caring. (The owner of the repo is still active elsewhere.) I like that they support more OSes (but not Redox), that they avoid phtread_self() and that their gettid() returns u64 whereas thread-id's get() returns usize for some weird reason.
In summary none of gettid, thread-id and palaver is a great choice, but I still prefer palaver's provided implementations of gettid(). I'll ask them about state of maintainership and stability.

nix is failing to build in 1.40 due to missing support for const_fn. I understand 1.40 is required for something, but are you planning to move to a younger release soon? If not then palavar is out.

So, im open to changing the 1.40 requirement, but my feeling is that we should have at least a year of rust compiler backward compatibility. We could open a PR for palaver to gate the const fns on rust versions with dtolnay's: rustversion. @alecmocatta do you plan on cutting a non-alpha 0.3 soon? Are you looking for a maintainer for the palaver crate?

@estk Thanks for the tag. I don't have the bandwidth at the moment but I'd happily add you as palaver maintainer to do so.

@alecmocatta that would be great, I'll work on a pr for palaver that will add compatibility for 1.40. Excellent crate btw.

@estk Thanks, look forward to reviewing!

@alecmocatta & @cloneable it actually looks like the problem is in nix and it is only in one line of a macro there. I'm going to see if its just that and if they are open to PR's on the subject. I'll keep this thread up to date on how I go.

Ok @alecmocatta & @cloneable I think the world has moved on. MSRV is 1.46 in not only nix, but also the bitflags crate. I've bumped master to test on 1.46. @cloneable you'll need to rebase and should be good. Apologies for holding this up.

Looks good now. Thank you both!


☂ BaseViewManagerTest.java => BaseViewManagerTest.kt

Summary:
Issue: https://github.com/facebook/react-native/issues/38825#issuecomment-1669202200
Changelog:
[GENERAL] [CHANGED] - BaseViewManagerTest.java => BaseViewManagerTest.kt
Test Plan:
./gradlew :packages:react-native:ReactAndroid:test

@retyui - thanks for working on this! Looks good overall, I just have one small nitpick regarding hungarian notation :)


migrate examples/javascript/predict-tense.js to examples/typescript/predict-tense.ts

Creates an equivalent typescript example for the existing javascript predict-tense example
Description
Copied the examples/javascript/predict-tense.js file to examples/typescript/predict-tense.ts and fixed import format.
Motivation and Context
This is part of a migration to typescript covered by issue #551
How Has This Been Tested?
Ran the linter and compiled the file with the tsc binary in node_modules
Screenshots (if appropriate):
N/A
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

[x] My code focuses on the main motivation and avoids scope creep.
[x] My code passes current tests and adds new tests where possible.
[x] My code is SOLID and DRY.
[x] I have updated the documentation as needed.

Reviewer's Checklist:

[ ] I kept my comments to the author positive, specific, and productive.
[ ] I tested the code and didn't find any new problems.
[ ] I think the motivation is good for the project.
[ ] I think the code works to satisfies the motivation.

Cast output to proper type i.e. string in our case

I've added a question to the comment, as i wasn't sure what the change should be