feat: add support for hotkeys

Description
This PR adds support for hotkeys and a Ctrl+S on Windows and Cmd+S hotkey on Mac as described in #1812.

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

PS: I haven't tested it on Windows yet and I'm not quite sure where to put the changes in documentation, because it seems like this would need a new category or should be featured on a specific page for editors.

Hey @rpfaeffle — this is great!
I've looked at it with the team and we have a few questions about how this will work with nested editing, i.e. our new drawers functionality but we'll check into that and see if any problems arise. We like the idea and the implementation though for sure.
Thank you - more soon!

Hey @jmikrut, @PatrikKozak,
you welcome. I'm glad you like the idea and the implementation. I must admit that I forgot about nested editing and how this would work with the useHotkey hook. But one option would be to extend the useDocumentDrawer hook with an onOpen function which could disable the Form it is placed in. What do you think about the idea?
Another point I wanted to bring up is Cmd+Enter and Ctrl+Enter as a hotkey for publishing documents.

@rpfaeffle if we can access a ref to the save button, we could potentially just trigger a click event from your hotkey hook and stopPropagation of the event. Might be something here.
As far as which hot-keys to enable, we should go based on demand.

@rpfaeffle I've made a proof-of-concept of this in e89e968 where the hook now triggers the button action directly through a ref and stops propagation of the event. There a few things to go here yet though, which are:

The hook needs to be moved from the "draft" button to the generic "submit" button and must be opt-in. This is because there might be multiple buttons rendered on the page simultaneously and we do not want them all the fire.
We need to write more tests to cover the edge cases here, like nested drawers.
There is a new lodash dependency that we cannot ship, so we need to replace those functions with our own code.

Alright, I think this will be ready soon! Just fixed the compatibility with linux (and thus hopefully windows as well), which should also make the tests succeed.
Only thing left is handling drawers which have save buttons.
Say a drawer with a save button is open, this means there are two save buttons: the one from the document behind, and the one from the drawer.
Currently, it only clicks the save button from the document behind. However, it should click the save button from the drawer with the highest edit depth instead.
This will require some refactoring of the useHotkey hook. Will look into fixing that tomorrow!

Done! This should now handle nested drawers.

@PatrikKozak or @JessChowdhury could either or both you pull this down and test it out? Pay special attention to using hot keys in drawers and nested drawers.

I bumped Payload to 1.14.0 but pressing Cmd + S still results in the browser prompting me to save the document as an HTML page.
Browser: Brave (Version 1.56.20 Chromium: 115.0.5790.171)
OS: macOS Ventura 13.5
Is this supposed to work, or this PR just lays out the foundation for making this feature possible?

I bumped Payload to 1.14.0 but pressing Cmd + S still results in the browser prompting me to save the document as an HTML page.
Browser: Brave (Version 1.56.20 Chromium: 115.0.5790.171) OS: macOS Ventura 13.5
Is this supposed to work, or this PR just lays out the foundation for making this feature possible?

Yep, the PR is supposed to work already! I've just tested it on Brave, Chrome and Safari on macOS with a fresh 1.14.0 payload installation, and it works fine for me.
Could you test it out with a fresh payload installation, and maybe share a screen recording? Moreover, make sure you are inside a document with unsaved changes.

I have a clone of the Payload repo and tested it with yarn dev _community there as well, at commit https://github.com/payloadcms/payload/commit/f5f23327555d61da77a7fb188e3ec853ee63a53a. Check it out:
https://github.com/payloadcms/payload/assets/5570098/b8f91b38-9b90-44a7-80c2-f16dcaf03558
I tested Cmd + S while switching to both Bulgarian language and English. I know this can make a difference in JavaScript when implementing hotkeys. There's also nothing in the console. It just doesn't work.
I'll try to dig into it.

@AlessioGr I tested it and found out why it doesn't work. It appears that maxEditDepth differs from editDepth:

Check my branch here: https://github.com/hdodov/payload/tree/bug-hotkeys
As a reminder, this happens in the original Payload repo, in the _community playground. This is not in my own project, so I believe it's genuinely a problem with Payload.
Should I open a separate issue for this?

@AlessioGr hey, the issue persists in Payload 1.15.2. Should I open an issue? Could you reproduce it as well?

@hdodov Yep, opening an issue for this would be nice!

Is there a way to opt out of this?
Not at the moment. I've got some ideas on how we should have the hotkeys in a section of the admin UI in the account page. With that we would be able to surface to the user the hotkeys, so that people can know what is available and even modify them.

In the meantime, some hotkeys settings passed through the config could be a good interim step.
We'd be happy to accept a contribution if that is something you want to make a PR for and we can discuss how it might look prior.


Stack trace when rubocop isn't installed

It might be nice to catch this exception and print a pretty message.
▶ molecule verify
--> Executing rubocop on *.rb files found in spec/.
Traceback (most recent call last):
...
sh.CommandNotFound: rubocop

Providing sh a stderr and stdout function, will always make sh display an error, since the function is executed.
This does not allow us to perform a try/catch pattern to squelch output.
We need to entirely rethink how we are dealing with logging and printing of messages in molecule.  I'm not entirely sure we even need to use a logger.


chore(code): use prettier for consistent indenting

I noticed that some things changed (tabs/spaces) when opening it in my editor, so I set up prettier for all typescript and javascript files. I noticed single quotes were preferred, so I set that setting in prettier.

Sure, that would be using prettier-eslint. I should take a look at how react did it.

@samccone I added a test, but I’m not 100% sure if it works correctly, could you enable travis on pull requests? I think it’s disabled

Hey @Haroenv I plan on landing this and all the big TS work this weekend, to minimize thrashing with rebasing :)
thanks so much for your prs thus far.

Sure. Lmk when to rebase

Landed as
a7a8c6b2cea081c403bbff75f85d948e050547ca
Thanks again for your help here... super awesome


use mean instead of sum for reconstruction error

currently we compute reconstruction error by summing over comopnents. Instead, we should compute the mean by normalizing by the number of elements. This will hopefully make the choice of regularization hyperparameters more robust across datasets.

This is addressed in https://github.com/ganguli-lab/twpca/pull/13
tf.reduce_sum(self._mask * (self.pred - self._data)**2) / self.num_datapoints


fix(Popup): ensure popup is closing on outside click

Fixes the issue is described here: #557
TODO

[ ] update changelog

Root cause
The cause of the problem is the fact that Menu component "intercepts" click event, so that Popup is unaware of whether this event has happened or not.
Fix
useCapture event interception logic is now used for Popup event subscriptions - this will guarantee that event won't pass unnoticed.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


1.13.0 crashes on iOS

Describe the bug
When I navigate to a screen that contains a KeyboardAwareScrollView or KeyboardAvoidingView, the app crashes with typeError: 0, _eventHandler.registerEventHandler is not a function (it is undefined) and it points to this line.
Downgrading to 1.12.7 solves the issue.
Code snippet
<KeyboardAwareScrollView className="flex-1 bg-white p-4">
  <Text className='my-2" mx-3'>{`Email: ${user?.email}`}</Text>
</KeyboardAwareScrollView>

Repo for reproducing
Let me know if you need a repro repo, since this a regression for a very recent release I thought I'd open the issue as fast as possible :)
Expected behavior
No crash.
Smartphone (please complete the following information):

Desktop OS: MacOS 14.5 (MBP M1 Pro)
Device: Simulator - iPhone SE (3rd gen)
OS: iOS 17.5
RN version: 0.74.5
RN architecture: new
JS engine: Hermes
Library version: 1.13.0

Additional context
Fresh install of the library, I couldn't understand what was going on until I saw your release tweet by chance :)

@aldebout which version of react-native-reanimated are you using? 👀

Sorry I should have added it earlier, this is part of my package.json:
    "@gorhom/bottom-sheet": "^4.6.4",
    "@shopify/flash-list": "1.6.4",
    "expo": "^51.0.28",
    "expo-apple-authentication": "~6.4.2",
    "expo-constants": "~16.0.2",
    "expo-crypto": "~13.0.2",
    "expo-dev-client": "~4.0.23",
    "expo-image": "~1.12.13",
    "expo-linking": "~6.3.1",
    "expo-localization": "^15.0.3",
    "expo-router": "~3.5.23",
    "expo-secure-store": "~13.0.2",
    "expo-splash-screen": "~0.27.5",
    "expo-status-bar": "~1.12.1",
    "google-libphonenumber": "^3.2.38",
    "i18next": "^23.12.2",
    "jotai": "^2.9.1",
    "nativewind": "~4.0.36",
    "react": "18.3.1",
    "react-dom": "18.3.1",
    "react-hook-form": "^7.51.4",
    "react-i18next": "^15.0.0",
    "react-native": "~0.74.5",
    "react-native-calendars": "^1.1306.0",
    "react-native-css-interop": "~0.0.36",
    "react-native-floating-action": "^1.22.0",
    "react-native-gesture-handler": "~2.16.2",
    "react-native-google-places-autocomplete": "^2.5.6",
    "react-native-keyboard-controller": "^1.12.7",
    "react-native-mmkv": "^2.12.2",
    "react-native-modal": "^13.0.1",
    "react-native-modal-datetime-picker": "^17.1.0",
    "react-native-phone-number-input": "^2.1.0",
    "react-native-reanimated": "~3.15.0",
    "react-native-restart": "^0.0.27",
    "react-native-safe-area-context": "~4.10.5",
    "react-native-screens": "~3.31.1",
    "react-native-svg": "^15.2.0",
    "react-native-url-polyfill": "^1.3.0",

Same issue on an Expo app,

"react-native-reanimated": "~3.6.0", // resolves to 3.6.3

I upgraded react-native-reanimated when I was investigating the crash, from 3.10 to 3.15, didn't change anything.

Okay, this is a very interesting! I'm also using reanimated 3.15.0 in example app and I don't have such problem 🤔
Do you think it would be possible to create a reproduction example? Or maybe you can add logger here and print console.log(REACore)?

This is the PR that introduced this regression (just for a reference): https://github.com/kirillzyusko/react-native-keyboard-controller/pull/538

Just created a fresh project using RN 0.74.5 + REA 3.10.0 - it works well:

I added console.log(123, registerEventHandler); in src/internal.ts and console.log("REACore", REACore); in event-handler.js and it prints:
 LOG  REACore {"configureLayoutAnimationBatch": [Function configureLayoutAnimationBatch], "createWorkletRuntime": [Function createWorkletRuntime], "enableLayoutAnimations": [Function enableLayoutAnimations], "executeOnUIRuntimeSync": [Function executeOnUIRuntimeSync], "getViewProp": [Function getViewProp], "initializeSensor": [Function initializeSensor], "isConfigured": [Function isReanimated3], "isReanimated3": [Function isReanimated3], "jsiConfigureProps": [Function jsiConfigureProps], "makeMutable": [Function makeMutable], "makeShareable": [Function makeShareableNative], "makeShareableCloneRecursive": [Function makeShareableCloneRecursive], "registerEventHandler": [Function registerEventHandler], "registerSensor": [Function registerSensor], "runOnJS": [Function runOnJS], "runOnRuntime": [Function runOnRuntime], "runOnUI": [Function runOnUI], "setShouldAnimateExitingForTag": [Function setShouldAnimateExitingForTag], "startMapper": [Function startMapper], "stopMapper": [Function stopMapper], "subscribeForKeyboardEvents": [Function subscribeForKeyboardEvents], "unregisterEventHandler": [Function unregisterEventHandler], "unregisterSensor": [Function unregisterSensor], "unsubscribeFromKeyboardEvents": [Function unsubscribeFromKeyboardEvents]}
 LOG  123 [Function registerEventHandler]

Really curious what's going wrong here 🤔

@kirillzyusko exploring the files to patch, it looks like lib/module/event-handler.js gets broken at build time, here is the code I get in my node modules:
export {};
//# sourceMappingURL=event-handler.js.map-native-reanimated/src/core");
} catch (e1) {
  try {
    REACore = require("react-native-reanimated/src/reanimated2/core");
  } catch (e2) {
    console.warn("Failed to load REACore from both paths");
  }
}
const registerEventHandler = REACore.registerEventHandler;
const unregisterEventHandler = REACore.unregisterEventHandler;
export { registerEventHandler, unregisterEventHandler };
//# sourceMappingURL=event-handler.js.map

I'm thinking I have an esm setup whereas you have a cjs one? I'll try to repro.

I'm thinking I have an esm setup whereas you have a cjs one? I'll try to repro.

 The code doesn't seem to be compiled properly (I also noticed that, but i couldn't point out my project to use that file - it was throwing other errors).
It would be super cool if you can prepare a reproduction - it would significantly speed up the process of fix preparation 🚀

https://github.com/aldebout/react-native-keyboard-controller-repro
Super basic repro, I just ran npx create-expo-app and added the lib/components. It crashes really well :)

@aldebout awesome! Thank you very much!
In a meantime I prepared a blind fix https://github.com/kirillzyusko/react-native-keyboard-controller/pull/552 - if you want to try feel free to do that 😊
Basically the problem was in the fact that I had two files with identical name but different extension: event-handler.ts and event-handler.js. And it looks like compiler could randomly overwrite the content of event-handler.js with output from event-handler.ts 🤦♂
Obviously in my case event-handler.ts served as declaration file only and I forgot to add .d extension (it had to be .d.ts).
Anyway - I finished work for today. I will checkout your repo tomorrow and will check if my fix is working - since it involves build process it'll take slightly more time to verify it, but anyway I hope I can find a fix till next Monday 😊
Thank you again for opening this issue and spotting the problem in such early stage! I appreciate it! And thank you for such quick response and so for such fast repro providing! Amazing speed 🚀

@aldebout weird, but when I run your project it works on my machine:

Any ideas what I'm doing wrong? 🙈 I just run npm install + npm run ios 🤷♂

same problem

Started having the same issue after upgrading as well (using expo). I upgrade reanimated to 3.15.0, prebuilt and built the app and still same issue. Not using the new arch btw.

@nikitapilgrim @corasan can you check if #552 fixes the problem for you? You can install it directly from GitHub and try it out in your project 👀

@kirillzyusko honestly no idea why it works on yours, BUT #552 seems to fix it for me :)

@aldebout cool, thank you for testing 😊
Let me then merge this PR and prepare a new release 👍

The fix is published under 1.13.1! Let me know if the issue is still there so that I can re-open this issue!

@kirillzyusko After upgrading to 1.13.1, is it resolved for me. I installed the lib this morning, crashed because of this bug, downgraded to 1.12.7, and now a few hours later it's already solved!
Thanks :)

@raphaelweis my pleasure 😊

Also upgraded and it's looking good so far, thanks @kirillzyusko for the super quick reaction!

You are welcome @aldebout
Thank you for your quick responses and help! 😊


Using @each directive for color array

I have a file util.scss
// 72 line below, very similar with the official documentation http://sass-lang.com/documentation/file.SASS_REFERENCE.html#each-directive
@each $color in red, blue, green, gray, white, black {
  .#{"" + $color} {
    color: $color;
  }

  .bg-#{"" + $color} {
    background-color: $color;
  }
}
...

I use node-sass(3.7.0) through gulp-sass. Print these error when compile.

events.js:141
      throw er; // Unhandled 'error' event
      ^
Error: util.scss
Error: Base-level rules cannot contain the parent-selector-referencing character '&'.

       Backtrace:
       	util.scss:72
        on line 72 of util.scss
>>   .#{"" + $color} {
   --^

    at options.error (/Users/basten/dev/web-projects/util.css/node_modules/gulp-sass/node_modules/node-sass/lib/index.js:271:32)

Sounds like you have a bug some where in your code. The error is likely due to incorrectly using & somewhere above this @each. Please confirm your code works with the offical Sass compiler. You can do this online with sassmeister.com.
You have not supplied enough working code us to reproduce this issue.

@xzyfer I try using sassmeister.com to compile my sass code, see http://www.sassmeister.com/gist/c98d2dec48b7c49d4b9343295b5e5475. It's ok.

It also works fine when using LibSass 3.3.6 as you can see sassmeister.com.
As I said earlier. The error your seeing is caused by the loop, from incorrectly using & some where that calls this this loop.


Add JavaScript SPA to ms-identity-docs code samples

Purpose
ms-identity-docs requires a JavaScript SPA to be used in quickstarts/tutorials - have taken sign-in app from ms-identity-javascript-tutorial, which is currently used in our doc set.
Does this introduce a breaking change?
[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe: New App type added.

How to Test
git clone https://github.com/Azure-Samples/ms-identity-docs-code-javascript.git
cd js-spa
git checkout add-js-spa
npm install

What to Check
Ensure this samples is suitable for our samples.

@cilwerner, @henrymbuguakiarie, @Dickson-Mwendia Can you review this PR - hoping to add a js-spa to our code samples, as we currently have differing samples in our doc set - thanks!

LGTM, will squash shortly, waiting until EOD Nairobi time in case @henrymbuguakiarie or @Dickson-Mwendia wish to add any comments

@cilwerner thanks for the approval - leave the merge to me as I have a few additional checks and updates to do.


GMail/Sheets images embedded inline in draft email get sent as attachments only

I thought this might be a GMail problem but am now thinking it must be caused by the script that sends the emails. The embedded image looks fine in the GMail draft. The recipient gets an image placemark with an x in the middle (not found) and the image is there as an attachment. Means I can't have a letterhead on my emails.

Same Problem, Have you found any solution yet?

Same Problem, Have you found any solution yet?

I suspect it is some sort of security measure by Google. I got around it by using a URL image.
Sent from my iPhone

On 5 Jan 2021, at 4:47 pm, vivekagr2021<EMAIL_ADDRESS>wrote:

Same Problem, Have you found any solution yet?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I suspect it is some sort of security measure by Google. I got around it by using a URL image.
Sent from my iPhone

On 5 Jan 2021, at 4:47 pm, vivekagr2021<EMAIL_ADDRESS>wrote:

Same Problem, Have you found any solution yet?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Subscribing! It's a problem for me too!

Subscribing! It's a problem for me too!

in your draft do not upload or drag and drop the picture
Solution: Click on insert photo and select web address URL (the URL should be public) and paste the URL of your pic.
Note: if your photo is local, you can use imgBB to upload your pic online and get the URL

in your draft do not upload or drag and drop the picture
Solution: Click on insert photo and select web address URL (the URL should be public) and paste the URL of your pic.
Note: if your photo is local, you can use imgBB to upload your pic online and get the URL

Ran into this issue as well while setting up mail merge for one of our staff members.
Began by looking around the Web; found code at https://stackoverflow.com/a/49621562 which provided a possible fix, but after modding the @mhawksey code to incorporate the code from the SO answer as part of getGmailTemplateFromDrafts_() I still couldn't get things working properly.
After a few (dozen) iterations of banging my head on it, I sent a message with inlines to myself, and compared the HTML code from "Show Original" to both a Logger.log of msg.getBody() from the Draft message and a "Show Original" from one of my failed Merge messages, and noted the following:
Draft message HTML Body  tag (from msg.getBody())

Mail Merge Sent message HTML Body  tag

Human Sent message HTML Body  tag

Essentially, the "draft" message  tags incorporate the "data-surl" parameter, and the failed Merge message copies those verbatim...but the Human message  tags do not.
My deduction is that Google changed how they handled Inline images at some point between when @mhawksey wrote getGmailTemplateFromDrafts_() and February 8th, 2021 (which is when I started noodling with this).  I found backup for that deduction at https://issuetracker.google.com/issues/36757948 and https://issuetracker.google.com/issues/36755796.
Now, knowing what a "proper"  tag should look like for an inline image, and having learned from  https://developers.google.com/apps-script/reference/gmail/gmail-app#sendEmail(String,String,String,Object) that one of the optional Object parameters is inlineImages, I was able to mod the SO code and getGmailTemplateFromDrafts_() to:

create an html_Body variable to contain the contents of msg.getBody() for modification;
modify the  tags in html_Body to conform to the new format for actual messages (vs drafts);
iteratively extract just the Inline images from attachments (keying by RegEx .match with data-surl="cid:) into an inlineImages array; and
return both modified items to emailMessage for use in GmailApp.sendEmail() which was also modified to incorporate retrieval of the inlineImages array value.

Here's the code I put together; it could probably be more optimized, but programming isn't my forte.
Line 98 (becomes 2 lines):
          attachments: emailTemplate.attachments,
          inlineImages: emailTemplate.inlineImages

Lines 114-133 (too many changes to break out):
  /**
   * Get a Gmail draft message by matching the subject line.
   * @param {string} subject_line to search for draft message
   * @return {object} containing the subject, plain and html message body and attachments
   *
   * Incorporates code to correctly parse and insert inline images
   * @see https://stackoverflow.com/a/49621562
  */
  function getGmailTemplateFromDrafts_(subject_line){
    try {
      // get drafts
      const drafts = GmailApp.getDrafts();
      // filter the drafts that match subject line
      const draft = drafts.filter(subjectFilter_(subject_line))[0];
      // get the message object
      const msg = draft.getMessage();
      // getting attachments so they can be included in the merge
      const attachments = msg.getAttachments();
      // get HTML body text
      var html_Body = msg.getBody();
      // Configure a RegExp for identifying draft Image Tags that indicate "inline" images
      const regDraftImgTag = new RegExp('img data-surl="cid:', "g");

      if (html_Body.match(regDraftImgTag) != null) {
        var inlineImages = {};
        var imgVars = html_Body.match(/]+>/g);
        var imgToReplace = [];
        if(imgVars != null){
          for (var i = 0; i < imgVars.length; i++) {
            if (imgVars[i].search(regDraftImgTag) != -1) {
              var id = imgVars[i].match(/src="cid:([^"]+)"/);
              if (id != null) {
                var imgTitle = imgVars[i].match(/alt="([^"]+)"/);
                if (imgTitle != null) imgToReplace.push([imgTitle[1], imgVars[i], id[1]]);
              }
            }
          }
        }
        for (var i = 0; i < imgToReplace.length; i++) {
          for (var j = 0; j < attachments.length; j++) {
            if(attachments[j].getName() == imgToReplace[i][0]) {
              inlineImages[imgToReplace[i][2]] = attachments[j].copyBlob();
              attachments.splice(j, 1);
              var newImg = imgToReplace[i][1].replace(/ data-surl="[^"]+"/, "");
              html_Body = html_Body.replace(imgToReplace[i][1], newImg);
            }
          }
        }
      }
      return {message: {subject: subject_line, text: msg.getPlainBody(), html: html_Body },
              attachments: attachments, inlineImages: inlineImages};
    } catch(e) {
      throw new Error("Oops - can't find Gmail draft");
    }

@mhawksey, I'd be happy to submit this as a patch to your code if you want.

@tyochelson-lwhs thanks for your investigation and reporting. Looking into this I think you are right the the inlineImages object needs to be rebuild. As it happens I had also recently come across a SO contribution, which provided a way to rebuild the inlineImages object whilst using the existing cid references. I've submitted a patch which is included in this modified version of the solution Google Sheet . If you could test and provide feedback that would be great


lake build MyProject.37: can't build files with numeric names

To reproduce:
lake new Numeric
cd Numeric
touch Numeric/s37.lean
lake build Numeric.s37

works, printing:
[0/1] Building Numeric.s37

but
touch Numeric/37.lean
lake build Numeric.37

errors with:
PANIC at Lean.modToFilePath.go Lean.Util.Path:38:20: ill-formed import
error: 'Numeric.37': no such file or directory (error code: 2)
  file:

And without #2756 it's annoying to work around.

(I encountered this in the wild, as I had a file 6123.lean in Mathlib, dealing with fallout from #6123.)

I suppose the problem here is that the intended Name of a module here is (`Numeric).str "37", not (`Numeric).num 37?


md-select not binding to number

Bug:
md-select binds to string values but not binding to number.
if (item.unitId) {
      // PATCH: Find permanet solution. Number not binding in md-select
      item.unitId = '' + item.unitId;
}

<md-select flex
          placeholder="Unit"
          formControlName="unitId">
<md-option *ngFor="let unit of units"
            [value]="unit.id">
  {{unit.name}} ({{unit.code}})
</md-option>
</md-select>

What is the expected behavior?
md-select should bind to number
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, browsers are affected?
2.0.0-beta.2
Is there anything else we should know?

It seems to work fine for me. Can you post a live example of the issue? You can use this as a template.

It is working fine. My bad. Datatype mismatch. Thanks for the support


go-ethereum: 1.13.5 -> 1.14.3

Description of changes
See https://github.com/ethereum/go-ethereum/releases/.
proxyVendor = true was needed to avoid the following error :
> # github.com/karalabe/hid
> vendor/github.com/karalabe/hid/hid_enabled.go:43:18: fatal error: os/events_posix.h: No such file or directory
>    43 |         #include "os/events_posix.h"
>       |                  ^~~~~~~~~~~~~~~~~~~

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 311188 run on aarch64-darwin 1

3 packages failed to build:

go-ethereum
go-ethereum.clef
go-ethereum.geth

Looks like ofBorg gets the build error for linux too: https://logs.ofborg.org/?attempt_id=4ada5d40-bb2c-4c07-91b0-6723f62b51cd&key=nixos%2Fnixpkgs.311188
I'm seeing the same hash on aarch64-darwin:
error: hash mismatch in fixed-output derivation '/nix/store/b9a9y8snhpyf42i21sw22yqv6wkqii8d-go-ethereum-1.14.3-go-modules.drv':
         specified: sha256-yD4Z7vbi3D3f9xGxRQjnjbTKljtjRLeIHRAdWjSub6U=
            got:    sha256-ugoRsxzJjPOS5yPhwqXhMPuThvyqCWvZD7PBnrkm0sQ=

Was the hash perhaps updated before proxyVendor was set to true?

Thanks for the report @RaghavSood !
It could have been the case; but that was because I was building against nixos-23.11, and not nipkgs master.
Output tested, PR updated.

Result of nixpkgs-review pr 311188 run on aarch64-darwin 1

3 packages built:

go-ethereum
go-ethereum.clef
go-ethereum.geth

Strange failure for x86_64-darwing, will check that out shortly

@GrahamcOfBorg build go-ethereum

@RaghavSood Looks like the x86_64-darwing build on Ofborg did pass ?

Both aarch64-darwin and x86 are failing: https://logs.ofborg.org/?key=nixos/nixpkgs.311188&attempt_id=7d3e8ad6-f207-45e9-8375-8c55033f554e

So the failure actually comes from nixosTests, not the build - but also intermittently - merging first, I will check out the tests soon

Likely related to #294725 - would explain why it failed, then passed - subsequent runs probably had the test build from the previous round of linux tests available in the cache and could download and run it


[gardening][enum class] Replace unsigned char with uint8_t for consistency

Before the changes:

git grep -E "enum class .+ : uint8_t \{" | wc -l: 90
git grep -E "enum class .+ : unsigned char \{" | wc -l: 26

@swift-ci smoke test

Yeah, it's good to be explicit.


ENH remove the sidebar in the benchmark result homepage

This PR removes the sidebar, and add dropdown selectors matching "Select X entries".
It also change the sysinfo names to uppercase ("cpu" --> "CPU").
Fixes #318

Before

After

Codecov Report

Merging #326 (5b6ecd0) into main (60dcf6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   61.45%   61.45%
=======================================
  Files          41       41
  Lines        2278     2278
  Branches      418      418
=======================================
  Hits         1400     1400
  Misses        780      780
  Partials       98       98


docstring example issue

this example is not up to date with the code (seems like):
https://github.com/vuillaut/ctaplot/blob/6d001ef0ba77ec48dec004313cc1da51183b57a1/ctaplot/plots.py#L554
Doint this change: ctaplot.ana.irf()  --> ctaplot.ana.irf_cta(), works for me.

Thanks. Solved.


Add AsinhScalarEncoder

Codecov Report
Attention: Patch coverage is 98.36066% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.92%. Comparing base (1aaac43) to head (e62edc0).

Files
Patch %
Lines

src/karbonn/modules/scalar/asinh.py
98.27%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #113      +/-   ##
===========================================
- Coverage   100.00%   99.92%   -0.08%
===========================================
  Files           63       64       +1
  Lines         1312     1371      +59
  Branches       128      142      +14
===========================================
+ Hits          1312     1370      +58
- Misses           0        1       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chunked transfer encoding response

Why does Kestrel always add transfer-encoding: "chunked" response header? IIS doesn't do it. Is this by design or a bug?

By design. If the application doesn't specify a content-length then the server must either buffer the content or send it as chunked. ASP.NET Core servers do not buffer the full content. IIS has some buffering quirks with response compression, but otherwise it doesn't buffer responses either.

Thanks


Move functions to a utilities class/namespace

Whenever possible move functions to a single class to avoid having the same or slightly different functions in multiple locations. This would make improvements in all uses of the functions. Another improvement would be the ease of testing functions since the current functions inside the execute function can't be tested

@Zazw3 any thoughts? I was also thinking of possibly doing new/updated functionality in rust while keeping the current boy alive. They can stay under the same boy account if there are no conflicting commands


[AutoPR cost-management/resource-manager] Microsoft.CostManagement - Add supression command into readme

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4334

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/3153


Allow statically typed variables

The Julia docs recommend that in some cases, variables can be type-annotated (LHS, not RHS). The section
https://docs.julialang.org/en/v1/manual/performance-tips/#man-performance-captured
says,

If captured variables are used in a performance-critical section of the code, then the following tips help ensure that their use is performant. First, if it is known that a captured variable does not change its type, then this can be declared explicitly with a type annotation (on the variable, not the right-hand side):

function abmult2(r0::Int)
    r::Int = r0
    if r < 0
        r = -r
    end
    f = x -> x * r
    return f
end

Annotations like r::Int = r0 sometimes lead to problems if GG also decides to box that variable. Could a type declaration like this be taken by GG as an assertion that the variable is unboxed?
This is related to https://github.com/cscherrer/Soss.jl/issues/337

Just to be sure I'm understanding, when you say "Removing boxing means the free variables are immutable"... Does this mean variables that are assigned in one scope and then passed to an "inner" scope?
Aside from performance, I was having the problem that the boxing was "leaking" - My generated code included the boxing, so some of my code broke. I'd think Refs might have the same issue, not sure yet


Fix handling of unmatched end-of-HTML-comment.

Fixes #1462. Also add tests.

@jitseniesen, thanks lot for helping us with this one!
I had to stop AppVeyor because it's timing out for unknown reasons. I'm preparing a PR to fix this.

@jitseniesen, I finally fixed our AppVeyor issues. Please rebase to get my fixes :-)

Great! Rebased.


[AWS] Support IAM Role for Service Account in KFServing

/kind feature
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Currently, it needs a S3 credential to download model. We need more fine grain control ways. IRSA is a better option. This helps us deploy model without credentials
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

/assign @Jeffwan

Hey @Jeffwan! Great feature. I'm less familiar with the AWS terminology. It looks like this will enable short lived credentials similar to GKE's managed pod identity.
I just want to confirm that these credentials will go through the Kubernetes Service Account API and that no API change is necessary from a KFServing perspective. What is the difference from an implementation perspective? IIUC, we currently read some AWS environment variables to retrieve the credentials -- what's different with IRSA?

It looks like this will enable short lived credentials within pods, similar to GKE's managed pod identity.

Exactly. This will be same as workload identity.

I just want to confirm that these credentials will go through the Kubernetes Service Account API and that no API change is necessary from a KFServing perspective. What is the difference from an implementation perspective? IIUC, we currently read some AWS environment variables to retrieve the credentials -- what's different with IRSA?

KFServing side doesn't need to make any API level change or even calls. User needs to choose service account with IAM role attached for inference service. EKS has the webhook to inject the temporary token from IAM role into the pod. There's two things need to be done.

Upgrade AWS or Minio SDK to the version that support assume-web-identity-role
Add assume-web-identity-role in the credential resolver chain and pod will load token to exchange temporary credentials.

This maybe supported out-of-box in kfserving and I have not checked it yet. I just create the issue for tracking purpose.

There is something else that it would be nice to have support for, which is to be able to chain into another role, once the web-identity-role has been configured. That's because our data-lake in S3 doesn't support the new web-identity roles yet, and we need to chain (assume roles) from the one configured by the EKS webhook.
pod-role-with-web-identity ---[assume]---> data-lake-role ===> download model

@Jeffwan I made this PR for using boto instead of minio for the storage initializer, seems related to this issue.
https://github.com/kubeflow/kfserving/pull/1130

Is this a vendor specific proprietary solution creeping into an open source offering?
Sent from my iPhone

On Apr 10, 2021, at 07:45, Google OSS Prow Robot @.***> wrote:

Closed #831 via #1472.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@ReggieCarey you seem to have a complete misconception of what open source is. I have seen several of your comments on the issue boards, mainly complaining about not successfully being able to join the Slack community and therefore falsely drawing the conclusion that "Microsoft, Google, and other proprietary orgs, limit who can use the publicly advertised slack channels" and constantly posting that "proprietary solution [are] creeping into an open source offering".
Let me clear it up for you: open source means collaboration between various different organizations and individuals in order to create shared functionality to the benefit of all. That means yes, absolutely yes, Kubeflow should support using functionality that is provided by Google, AWS and so forth if that is what is needed by Kubeflow's user base.


Doc: Generate a comparison table for matrix class methods

Description
Generate a comparison table that lists all APIs in (cupyx.)scipy.sparse.*_matrix classes, like we do for cupy.ndarray.
Idea or request for content
No response

Hi @kmaehashi, I was looking at this issue and I saw this page https://docs.cupy.dev/en/stable/reference/comparison.html#sparse-matrices. It seem to have all the existing APIs listed for (cupyx.)scipy.sparse.*_matrix. I've double checked with the code in the folder cupy/cupyx/scipy/sparse, all existing APIs in the files are listed on the comparison table

This issue intends to add APIs of methods for each matrix class to the table.

Hi @kmaehashi, i've looked at docs/source/_comparison_generator.py in the main branch and implemented code that generate comparison table for coo, csc, csr, dia matrices. Could i take this issue and send a PR?


scripted column: reference column by name

currently the columns can only be accessed through the values array. However, to improve readability, access via name would be useful.
such as
(col.a + col.b)/2
currently just: (values[0] + values[1]) /2
issues: how to identify columns easily? -> label of the column, can be changed and possible very long

Moved/integrated into https://github.com/datavisyn/lineupjs/issues/116


Finality proof: fetch new authorities set instead of previous one

Finality proof includes the proof(previous-authorities-set) instead of proof(new-authorities-set). This PR fixes that. Thanks to @jimpo for the report

(I think one test should be updated to test this properly => linprogress)


Add support for model-level config

This adds a hashid_config class method to allowing for overriding the default hashid config. The supports all the existing configuration options. It was added particularly to address the issue of changing a table name without changing the hashids.
Example usage:
class MyModel < ApplicationRecord
  include Hashid::Rails
  hashid_config pepper: "old_table"
end

Implements #60


Replace internal util functions by @untemps/utils

:tada: This issue has been resolved in version 1.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


reverse --no-hashes

they seem to be more problematic (or perhaps educational) than anything.
I like the idea of switching this to --include-hashes or simply --hashes and having them off by default.

@nateprewitt thoughts?

@kennethreitz, I agree. I was trying to find a conversation @jacebrowning and I had a month or two ago before we added --no-hashes but can't find it. The short of my thoughts are hashes are nice but have become incredibly combersome for cross platform. While I'm usually "secure by default", this has been enough of a blocker that it's probably more useful as an opt-in.

@nateprewitt https://github.com/kennethreitz/pipenv/issues/210 and https://github.com/kennethreitz/pipenv/issues/250 contain relevant discussion to requiring hashes.

I started a v4.0.0 branch (we can rename if you want to try that new version scheme @kennethreitz). 93316b6 converts --ignore-hashes and --no-hashes into an inverse --require-hashes option.

Resolved in #351.


funny prefix

Styling is no longer prefixed by md-. All styling is now prefixed by mat-.

Russian developers are having a laugh here, because in russian mat means foul language.
Should have gone for something simpler and more neutral, like mt-.

can't accommodate all languages tbh :P

Can't really accommodate all languages. mat is short for material and to me sounds really good :P

Ha, well, that's good to know!  The decision has been made to mat- though, and in the interest of not stressing out our community, we'd prefer not to roll out another large breaking change just to change the prefix.


license?

ZPL, MIT, BSD, Apache?

Good point. Never had to do with licenses. Chose a MIT license.


Native RNSkia Module cannot be found

Hi all,
I'm having this error at runtime (ios) on an existing project and also on bare project:

Apparently the NativeModules do not seem to have the RNSkia module.
What I've done:
- yarn add @shopify/react-native-skia
What i've tried:

clear all the caches
rm the node modules then yarn
rm the ios/pod and ios/podfile.lock then npx pod-install (or cd ios && pod install)

RN version 0.66.4
Usage:
I've had this issue trying to use https://github.com/margelo/react-native-graph, that requires react-native-skia.
It's been several days and still cannot figure out why this does happen.
Any tips ? This would be greatly appreciated

Could you share the repo on github so we could try on our side?

I'm having the same issue presented above and I'm using react-native-skia directly.
I'll give a try with the example app and see if it works.

Closing due to inactivity, and that it seems like the OP fixed this by himself :)


Vibrate doesn't work

I set an alarm with vibrage on and its doesn't work

Fixed in the latest app v2.24.


Remove excessive whitespaces

Fixes #72

Codecov Report

Merging #76 (86036b5) into master (e8c85f7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   97.26%   97.26%
=======================================
  Files           6        6
  Lines        1389     1389
=======================================
  Hits         1351     1351
  Misses         38       38

Impacted Files
Coverage Δ

source/argparse/help.d
97.94% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Edit Report Name flow

https://user-images.githubusercontent.com/39493102/134315994-d8bdf23f-6ce6-4604-9271-35231cb2babf.mp4

few comments:

The icon color should be $primary
Let us add a left margin to the icon temporarily - It looks very near to the name
Edit name header in the pop up is not center-aligned
Aren't we showing an error message if the report name is erased completely?


Add documentation to JavaClass & JavaClassWrapper

Related to https://github.com/godotengine/godot/issues/22136.
I... seriously don't know. I am struggling to understand the meaning of them. Any mention of these is outstandingly lacking, as if hidden in ancient scrolls. The code is old, uncommented and a bit garbled, and the history on GitHub doesn't tell me anything. Even the Android devs aren't exactly sure what these are for: JNISingleton exists and the tutorial for it is sufficient, at least.
Ever since their introduction they've been left ignored lacking any sort of documentation or proper tutorial. What's the purpose of these? Their obscurity stood out to me like a sore thumb. I had to know, and fill them with some semblance of information. Hence, I have written my... best guesses.

Thanks!


\n is parsed even inside backticks

This makes LaTeX somwhat difficult, and does not match Riot/Web.
What I actually wrote:
exists x \in PSPACE, x \notin PTIME

er, `exists x \in PSPACE, x \notin PTIME`

In a message without backticks:
{
  "age": 225,
  "content": {
    "body": "exists x \\in PSPACE, x \\notin PTIME",
    "format": "org.matrix.custom.html",
    "formatted_body": "exists x \\in PSPACE, x
otin PTIME",
    "msgtype": "m.text"
  },
  "event_id": "$1542266599241122yMfMG:matrix.org",
  "m_is_internal_pagination_token": false,
  "m_sent_state": "SENT",
  "m_token": "s742675855_610617397_477859_197230370_91075266_514123_13110302_10101801_23876",
  "origin_server_ts":<PHONE_NUMBER>477,
  "room_id": "!OBTvcNsrmhsytxbmDz:matrix.org",
  "sender": "@eternaleye:matrix.org",
  "type": "m.room.message",
  "unsigned": {
    "age": 225,
    "transaction_id": "!OBTvcNsrmhsytxbmDz:matrix.org-1542266599058"
  }
}

With backticks:
{
  "age": 238,
  "content": {
    "body": "er, `exists x \\in PSPACE, x \\notin PTIME`",
    "format": "org.matrix.custom.html",
    "formatted_body": "er, exists x \\in PSPACE, x \notin PTIME",
    "msgtype": "m.text"
  },
  "event_id": "$1542266622241169jJNGN:matrix.org",
  "m_is_internal_pagination_token": false,
  "m_sent_state": "SENT",
  "m_token": "s742676053_610617637_477961_197230474_91075308_514123_13110306_10101801_23876",
  "origin_server_ts":<PHONE_NUMBER>840,
  "room_id": "!OBTvcNsrmhsytxbmDz:matrix.org",
  "sender": "@eternaleye:matrix.org",
  "type": "m.room.message",
  "unsigned": {
    "age": 238,
    "transaction_id": "!OBTvcNsrmhsytxbmDz:matrix.org-1542266622426"
  }
}

What is your expected body and/or formatted_body for your 2 examples?

IMO:

body is already correct in both messages - it would render as I had typed it.
For the second message, I would expect "formatted_body": "er, exists x \\in PSPACE, x \\notin PTIME".
For the first message, it's either correct (if \n is an escape that is actually desired) or should be "formatted_body": "exists x \\in PSPACE, x \\notin PTIME".

Notably, Riot/Web does not support \n, and so it surprises me every time it bites me in Riot/Android.


outer_iterator_mut does not implement DoubleEndedIterator correctly

outer_iterator_mut uses a successive application of split_at_mut. The iterator is such not double-ended, and will fail when trying to iterate backwards on it. The code for this can be seen at https://github.com/mulimoen/sprs/tree/bug/outer_iterator_mut, see the actions page at https://github.com/mulimoen/sprs/actions/runs/436352486 for the error message.
How to fix: We probably need to sprinkle a bit of unsafe here to be able to move self.data into the closure, and make it independent of iteration order.

Fixed by #263


Add remacth! function ; do some renames and doc polish

Added rematch! to do different matching after the continuation has stopped
Renamed the continuation methods: RecurrencesFindAndMatch and GroupAcrossParameter. I've dropped Continuation from both names, as they subtype the AttractorsBasinsContinuation abstract type

Let me know if you disagree.

Codecov Report

Merging #64 (c853b47) into main (9453971) will increase coverage by 0.29%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   70.22%   70.51%   +0.29%
==========================================
  Files          20       20
  Lines        1105     1116      +11
==========================================
+ Hits          776      787      +11
  Misses        329      329

Impacted Files
Coverage Δ

src/continuation/aggregate_attractor_fractions.jl
94.73% <ø> (ø)

src/deprecated.jl
0.00% <ø> (ø)

src/continuation/continuation_recurrences.jl
88.88% <75.00%> (ø)

src/continuation/continuation_grouping.jl
97.72% <100.00%> (ø)

src/continuation/match_attractor_ids.jl
72.22% <100.00%> (+5.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

The new names are catchy. I don't see any problem since they are used in the context of continuation.
Good for me


Outdated readme

The main readme file contains information which are outdated by now:

https://github.com/elan-ev/opencast-editor/blob/main/README.md

The ReadMe has been updated in the meantime, so I'll close this assuming that whatever information was outdated is not outdated anymore.


add watchify as dependency

Watchify is required in the cmd.js - in theory we could also add it as optional dependency, but this would require a bit more code ;-)

Hi @greenify !
Using parcelify directly from the command line, e.g.
parcelify main.js -o bundle.css

has been depreciated as of v1.0.0 in favor of this new plugin syntax.
browserify main.js -o bundle.js -p [ parcelify -o bundle.css ]

With the new plugin syntax there is no dependency, so we are going to leave browserify / watchify out of dependencies going forward.
Thanks in any case for bringing up this issue!


[JTC] Add time-out for trajectory interfaces

This adds an optional time-out parameter for the trajectory interfaces (topic or action).
If using velocity as command interface, and the last velocity point is not zero -> the robot would move forever without stopping if no new trajectory is received.

Just wondering now, should the timeout be counted from the reception of the message, or from the time of the end of the trajectory (i.e., before_last_point==false)?

Good question... It's intuitive to do it from receiving the message but since this particular message has explicit timing in it I think we should only allow timeouts defined relative to the trajectory

We should define it from the end for the trajectory (time of the last point)

@christophfroehlich this PR shouldn't really target the jtc-features branch no?

@christophfroehlich this PR shouldn't really target the jtc-features branch no?

It is somehow independent, but why not?

Codecov Report

Merging #609 (23d5501) into master (e7f9962) will increase coverage by 0.75%.
The diff coverage is 34.91%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   35.78%   36.53%   +0.75%
==========================================
  Files         189        7     -182
  Lines       17570      676   -16894
  Branches    11592      357   -11235
==========================================
- Hits         6287      247    -6040
+ Misses        994      134     -860
+ Partials    10289      295    -9994

Flag
Coverage Δ

unittests
36.53% <34.91%> (+0.75%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ontroller/test/test_load_diff_drive_controller.cpp
11.11% <0.00%> (ø)

diff_drive_controller/src/odometry.cpp
42.16% <11.11%> (ø)

diff_drive_controller/src/speed_limiter.cpp
46.55% <11.11%> (ø)

...ive_controller/test/test_diff_drive_controller.cpp
17.62% <12.08%> (ø)

...iff_drive_controller/src/diff_drive_controller.cpp
47.09% <46.88%> (ø)

...de/diff_drive_controller/diff_drive_controller.hpp
100.00% <100.00%> (ø)

...troller/include/diff_drive_controller/odometry.hpp
100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

CI fails because of flaky JTC tests, not related to this PR


Camera stutters when trying to move mouse

Might be because I'm using Wayland (KDE), but for some reason the camera stutters while trying to move it, which is really annoying. It also stutters more as I increase the speed.

Software: Fedora Linux 41

KDE Plasma v6.2.2
KDE Frameworks v6.7.0
Qt v6.8.0
Kernel v6.11.5-300.fc41.x86_64
Graphics Platform: Wayland

I also applied the pull request #16 to the code


Add cluster_id to Spark/YARN collector

Add cluster_id label to identify different clusters in the spark/yarn collector.
We're using the Hadoop Yarn cluster identifier to uniquely identify a cluster. This means that mostly Yarn is supported, preliminary support for other cluster types is implemented (using the master host name)

I personally don't like the idea that YarnCollector instance is being transferred to SparkApplicationMetricsCollector
I don't think there is a reason to transfer collectors between themselves as arguments
You can enforce Sampler to have self._id - or just have it in BigDataSampler (no Sampler enforcement), which will practically behave as a cluster ID, and then call a function from Sampler.collect() that will update collected sampless' labels with self._id or something alike.
The ID will be different if is YARN or not obviously, as now.

Closing this PR as the metrics package was removed in #220 to a separate repository. Reopen there if relevant.


Fix: If FIO test running in background is stuck throw the exception and abort the test

Bug #367
Below code changes handles the ./StartFioTest.sh stuck issue with checking the status string and abort the test with throwing the exception.
To verify this fix running performance tests to reproduce the scenario

Could you please post results against latest code?

Tried to reproduce this issue with pipeline-cloudtest-manual jobs 1647,1648, 1696, 1697

Could you please post results against latest code?

Tried to reproduce this issue with pipeline-cloudtest-manual jobs 1647,1648, 1696, 1697. Please refer the jobs for latest results


Upgrade cloudfoundry and statuscake providers.

Currently it is not possible to run our Terraform scripts in an Apple ARM environment because we need newer versions of the CloudFoundry and StatusCake modules.
Context

Changes proposed in this pull request

Guidance to review

Link to Trello card

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] Required environment variables have been updated added to the Azure KeyVault

 Make Apply Apple Silicon Compatible


Hihenry

https://hihenry.com/fullstack-engineer
From Reddit. I usually dont create the PR because I am on my phone rather than computer when I read haskell reddit.

Thanks! But this is the swedish company Henry Labs which is already on the list

I will add the job ad as a source though!


Mtc controller config messages

Possible issues with config messages

Also, this is just a copy of the cleanup PR, right?


As a citizen, I want to use an identity verified by my government so that I can we can trust each other's identity in my country.

Revelation 13:16-17

Added to readme

Opening this as part of moving all user stories into issues again.


paper

“A Hybrid DSP/Deep Learning Approach to Real-Time Full-Band Speech Enhancement”
I want ask which magazine is this paper published in?I cant find answer on the Internet.

J.-M. Valin, A Hybrid DSP/Deep Learning Approach to Real-Time Full-Band Speech Enhancement, Proceedings of IEEE Multimedia Signal Processing (MMSP) Workshop, arXiv:1709.08243, 2018.

Thanks!


Remove StT and StM constructors for compatibility with monad-control 1.x

this should be fine.

Thanks @tranma, merging.


Area Radius not using meters when HA system default is feet

When I set the area to 10 meters (30 feet), areas farther than 10 feet away become unknown. When I set the area to 25 meters (75 feet), the unknown areas reappear.
My house is neither 25 meters nor even 10 meters long or wide, so I believe there might be an issue with the conversion from meters to feet.
HA Versions
Core: 2024.5.4
Supervisor: 2024.05.1
Operating System: 12.3
Frontend: 20240501.1
Bermuda
Version: 0.6.6
I'm not sure how to retrieve the logs for this issue.

Hmm that's odd. Can you post a screenshot of your config page (in bermuda configuration, global options)?
There might be something odd going on with the config option conversion. Internally, Bermuda uses metres for everything, and the sensors are exposed with a "native measurement" of metres, so the frontend will be doing the conversion to feet for you.
But I have a feeling it doesn't convert the config page, because I don't think I can (or have?) told HA the units for those settings. Or maybe it does and I don't realise it!
My expectation is that you need to enter metres on the config page, but HA will translate the units for sensors etc - but I might need to take a look at that specifically, by the sounds of it. A screenshot of your config just so I can see what it's reflecting would be good.
Also, could you post one of the "options" sections from calling the dump_devices service (Developer Tools, Services, bermuda.dump_devices). There will be one in every "block", it will look a bit like:
  options:
    attenuation: 3
    devtracker_nothome_timeout: 180
    max_area_radius: 72
    max_velocity: 3
    ref_power: -55
    smoothing_samples: 25
    update_interval: 10
    configured_devices:
      - C7:B8:C6:B0:27:11
      - EE:E8:37:9F:6B:54
      - CE12CBEB2DBE448BB057C1FE9804B45F_100_1
      - A4:C1:38:DC:19:36
      - FF:FF:10:F7:A4:B9
      - A4:C1:38:3E:4F:A4
      - 5A:B6:51:70:6C:3B

That plus the screenshot should show if anything is doing any conversion of units at the config end of things.
By the way, I set my radius to 70 metres or so (effectively infinite, since ble rarely travels that far) as I've found little benefit in having the sensors go to unknown, I'd rather they snap to the nearest sensor even if it's not "right". But that doesn't address the conversion issue you're seeing, of course...

I totally agree with you on the very little benefit of a scanner going unknow, but to each there own.  that why i wanted to set mine to 25 meters, that should about 75 feet. let me know if you need anything else.

      options:
        attenuation: 3
        devtracker_nothome_timeout: 30
        max_area_radius: 50
        max_velocity: 3
        ref_power: -51
        smoothing_samples: 20
        update_interval: 10

I was looking through the dev docs at the example sensor.  it shows the below properties for the sensor. I am wondering if not the config flow but the sensors don't have a native units set.
https://github.com/home-assistant/example-custom-config/blob/master/custom_components/example_sensor/sensor.py
    _attr_name = "Example Temperature"
    _attr_native_unit_of_measurement = UnitOfTemperature.CELSIUS
    _attr_device_class = SensorDeviceClass.TEMPERATURE
    _attr_state_class = SensorStateClass.MEASUREMENT

Some infomation at when i set it to 10

  options:     attenuation: 3     devtracker_nothome_timeout: 30     max_area_radius: 5     max_velocity: 3     ref_power: -60     smoothing_samples: 10     update_interval: 10

The sensors do define units of measurement, so that should be all good (and if they didn't HA wouldn't try to convert them for you, it would just present them as numbers, I believe). The units were added in v0.3.2 back in January.
The options block in your last post shows a bug, in that it is an incorrect copy of the options, but one that doesn't have any operational effect - what's happening is that the options block gets attached to each device / scanner entry, (mostly as a convenience to myself for when people send debugging info) and I save those scanner details into the config. When bermuda restarts or reloads, it pulls in those saved scanner entries without replacing the options block (it does replace them on all other devices) so it will be showing an out-of-date copy of the options. But they are not the options actually being used, which is confusing, but inert.
If you scroll through the devices in the dump_devices info, you'll notice that the entries for the proxies (they have is_scanner: True in them) will all have the radius set to 5, but all the other devices will have whatever the current actual config is. They are just copies of the config though, so aren't doing anything themselves.
I'll have that fixed in the next release.
That's just re the options block though, and is a non-issue.
Your screenshot of the sensor shows it reporting 17ft from the Family room scanner, which is inside the configured 10m radius, so it looks OK to me. If the units were getting messed up then I'd expect that a "measurement" of 17ft, being over 10ft, would result in that scanner also showing "Unknown". My assumption from the screenshot is that the Family Room proxy is "measuring" 17ft, while the others (dining, kitchen garage?) are either not seeing the device at all, or are measuring a distance of over 10m / 32ft so report Unknown.
It's important to note that "measurement" is not a very accurate term, so unless you have calibrated your proxy and device power/rssi levels, the absolute distance reported is not an actual distance, but but a super loose approximation - they should all be "relative" though, in that whichever proxy reports being the closest, regardless if that "measurement" is a few inches, or 50 metres, it is really "the closest", in relative terms.
Does that reflect what you're seeing, or am I missing something in my interpretation?
If it still doesn't seem right, can you call the dump_devices service, but use the address filter to limit the results to just your sensor above, and send it through? If you click the "Fill Example Data" button in the service it will give you a hint on how to specify one or more addresses to filter. If you send that, as well as a note (or another screenshot) about what distances are showing on the sensors at around the same time I should be able to take a deeper look into what's happening.
If you're concerned about sharing your MAC addresses online, you can do a search-and-replace on the file first, but if you can leave the first and last pair of digits on each mac so I can tell them apart that would be great (eg, replace nn:nn:nn:nn:nn:nn with nn:xx:xx:xx:xx:nn)

I have a feeling this is resolved, but please feel free to reopen the issue if you find anything odd going on.


Resizing right most column of variable view when in side panel doesn't work

Try dragging the right side size of the 'value' column. Once the mouse goes outside of the panel it stops responding.

Address as parity only if resizing the rightmost column worked in webview.

I can't repro this. If I try to drag it past the panel width, I keep controlling it until I click somewhere inside the panel to set it there.
Also, how do you put the variables there? Is that a setting?

I keep controlling it until I click somewhere inside the panel to set it there.

That's exactly the problem. I can only set the width to the current width of the panel. There's no way for me to resize the value column past the edge of the window.

Also, how do you put the variables there? Is that a setting?

Not sure what you're asking. I just created variables with a lot of data. Like this:
mystr = "A really long string that won't fit in the variables value column"

How do you put it on the side bar instead of the panel?

You drag the tab header over to a side panel.
The problem repros with it at the bottom too, it's just not as much of a pain

Keeping around most of the variable explorer feedback, but this one seemed really minor if it wasn't being reported by customers. So closing, but please reactivate if you disagree.


Add version to the PutBlobMetaInfo

Add a version number to the PutBlobMetaInfo.

Codecov Report
Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 18.20%. Comparing base (32a21b1) to head (205c4ba).

Files
Patch %
Lines

.../java/com/github/ambry/router/PutBlobMetaInfo.java
0.00%
17 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2739       +/-   ##
=============================================
- Coverage     70.67%   18.20%   -52.47%
+ Complexity    11573     2814     -8759
=============================================
  Files           833      833
  Lines         70950    70965       +15
  Branches       8530     8532        +2
=============================================
- Hits          50143    12919    -37224
- Misses        18182    56846    +38664
+ Partials       2625     1200     -1425

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bug with first category collapsed by default

Dear @volkanceylan,
just found a bug when the first category of a form is collapsed by default:

I think that's a css issue, because the first category it's the only one with the "first-category" class...
In fact the 2nd category collapsed by default it's ok...
I'll check the css and I let you know if I find the solution...
Thanks
Bye

Are you using Serenity as submodule?

No I've developed my application starting from a standard Serene template...
I checked my original code and this glitch never happens, but your implementation it's a bit different!

My implementation is different because you forgot to handle validation issue. Invisible items don't get validated.

I know I know...was my fault!

:) sorry no faults
it's not a bug. it happens because customer is focused on dialog open (as it is first input). i recommend not collapsing first category initially or focus another input.

These issues was primary reason why i didn't like much idea of collapsible forms etc. If you hide them you lose validation, if you don't you'll always have such problems.

Ok, add this:
.s-PropertyGrid .category.collapsed .field {
    visibility: hidden;
}

It seems to fix focus and validation issue

Yes...now it's working fine!!
Thank as always for your kind support (and for your patience!!!)
Bye


Looks like the website is down

Yeah, the domain expired and someone snug it away. Oh well.

It's now: https://robb.github.io/Underscore.m/

👍 works. thank you!


Format for 'myPrivateKey' in Example

Which Format must the 'myPrivateKey' be in the example forge Transaction?
I'm currently trying with bsv v2: const privKey = bsv.PrivKey.fromWif(myPrivateKey)  but it does not work.
Maybe you could add a "real" privateKey as an example.

TxForge >= 2.0 uses nimble not bsv2, so it would be nimble.PrivateKey.fromString(wif)
If you don't want to use nimble, TxForge legacy uses bsv2 so it would be as you expect (although minor api differences in txforge so make sure you refer to the legacy branch readme.


Cannot read property 'length' of undefined

Summary

I recently upgraded from v2.9 to v2.11.4 in order to leverage synchronization. I applied a ConfigMap yaml in the argo namespace and then populated the workflow template based on this example. When I have the synchronization stuff in there it causes the above errors, though things work properly when I run the workflow without the synchronization stuff.
Also adding to this, if i use the commandline argo utility to "argo watch" the workflow I can clearly see the synchronization semaphor is working properly, but for some reason the UI cannot display the workflow.
Diagnostics
What Kubernetes provider are you using? Amazon EKS
What version of Argo Workflows are you running? v2.11.4

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Hmm. Works for me. Can you attach screenshot please?

Can you please provide full workflow?

@alexec I do believe it is something specific to our workflow as it is quite complex. Happy to share it with you privately to protect our privacy, is that possible?

For UI problems, I need some YAML that I can just kubectl apply to create the issue. Could you redact your YAML?


Basic Transactor

Description :
Setted up a bare minimum transactor hook
Reason to use a custom hook instead of a function :
created a custom hook instead of transactor function because instead of making signer argument mandatory for the function we can leverage the wagmi hook (useSigner) . Also since we are using wagmi hooks for making wrtie transaction , if we go with function approach we need to get signer separately everytime and then pass it to transactor function.
example (keeping transactor as function) :
const signer = useSigner()
const {writeAsync} = useContractWrite({ ...config });
const tx = Transactor(signer);
await tx(writeAsync())

example (keeping transactor as hook) :
const {writeAsync} = useContractWrite({ ...config });
const tx = useTransactor();
await tx(writeAsync())

Please let me know if I should go with the custom hook approach or not.
Also in issue #48, it was mentioned to make util/component was a bit confused about it. Please let me know if the current (custom hook) approach is correct or I should go with other approaches 🙏 .
Thanks so much!

Please let me know if I should go with the custom hook approach or not.

Love the hook approach, make more sense. On the issue I mentioned a util/component thinking about v0.1, but you are on v1.0, which is great! Thanks Shiv!
Lmk when is ready for review.

Description :
Updated the transactor to properly show synced messages while doing transactions.
Approach :
The new useTransactor hook is very similar to Transactor.js in scaffold-eth. It's just that we can leverage the wagmi hook (useSigner) instead of passing the signer every time.
Demo - successful transaction on goerli (please skip the part 00:16 to 0:35 forgot to fast-forward) :
https://user-images.githubusercontent.com/80153681/206261643-f9b3dde4-0aa1-4ee0-b58d-8bc9818004fd.mov
Demo - showing error :
https://user-images.githubusercontent.com/80153681/206261942-c2ead7ca-c4d1-4b59-afdd-8e63bc37a33c.mov
Important points to note :
If you look at this block of code in transactor.js of se-typescript. Their they are waiting for transaction confirmation and then calling a callback even I did the same but took a different approach of leveraging transactionRes.wait() to make sure the transaction is included in a block and confirmed, referenced from ethers doc here checkout .wait(). My approch is at line 84 of  useTransactor. Please let me know if we should do it similar to se-typescipt, I tried making it clean and easy to understand but please let me know.
TODOs :
https://user-images.githubusercontent.com/80153681/206269407-25017889-460a-4c65-be76-9f8911d40230.mov
If we see here the error overflows the toast. Should I fix it in this PR or should we make a new issue for creating a custom toast with a se-2 theme for all stuff.
Also should we create an issue for getParsedEthersError for parsing error more efficiently?


Webhooks for default images

Default container images are now handled via env vars and internal webhooks, as per the pattern we are using for all NextGen operators.  This PR also changes the Horizon api version to v1beta1 to match our other operators.

I'm not a huge fan of the abrupt change to v1beta1 and removal of v1alpha1. Feels like something like that should have been its own PR, but since we're still deep in the development phase of this project, I guess it should be ok to include here.
We will need to also update openstack-operator if we're going to get rid of v1alpha1 since it currently imports it. So if we merge this, I think openstack-operator will complain until we fix it there as well.

/lgtm
Let's merge this and work on migration to v1beta, because we aim to bump version before GA.


[Bug]: Local Models not loading from Windows to WSL

What happened?
I was installing fabric, when I wrote: ":~/fabric$ fabric --listmodels" and local models are empty, when I am running Ollama in Windows 11:
:~/fabric$ fabric --listmodels
GPT Models:
Local Models:
Claude Models:
Google Models:
Version check

[X] Yes I was.

Relevant log output
No response
Relevant screenshots (optional)
No response

Getting the same issue running lm-studio.

I got models to list by manually adding the api key to the .env config

I came across the same issue. There was an ollama instance running in WSL, and I couldn't figure out why it wasn't sending prompts to LM-Studio.
@danielmiessler - I see you are holding most updates for after the GO version is released, not sure how that will change the setup.
From what I can tell having the API_KEY set is required by the OpenAI python package.
Below is the proposed update to the documentation.

Now you are up and running! You can test by running the help.

# Making sure the paths are set up correctly
fabric --help

[!NOTE]
If you're using the server functions, fabric-api and fabric-webui need to be run in distinct terminal windows.

Using a local OpenAI API compatible server
If you want to use fabric with OpenAI API compatible inference servers, such as FastChat, Helmholtz Blablador, LM Studio and others, simply export the following environment variables:

export OPENAI_BASE_URL=https://YOUR-SERVER:8000/v1/
export DEFAULT_MODEL="YOUR_MODEL"

And if your server needs authentication tokens, like Blablador does, you export the token the same way you would with OpenAI:

export OPENAI_API_KEY="YOUR TOKEN"

If using LM-Studio you must set your API key to lm-studio

export OPENAI_API_KEY="lm-studio"

[!NOTE]
When running in WSL2 your fabric CLI client must be pointed at your computers network IP address, not https://localhost or https://<IP_ADDRESS>
For example export OPENAI_BASE_URL=https://<IP_ADDRESS>:1234/v1/

Using the fabric client
Once you have it all set up, here's how to use it.

Check out the options
fabric -h

Thanks!  I could never get this working.
On Sat, Jun 1, 2024 at 9:03 PM Sean Visnaw @.***> wrote:

I came across the same issue. There was an ollama instance running in WSL,
and I couldn't figure out why it wasn't sending prompts to LM-Studio.
@danielmiessler https://github.com/danielmiessler - I see you are
holding most updates for after the GO version is released, not sure how
that will change the setup.
From what I can tell having the API_KEY set is required by the OpenAI
python package.
Below is the proposed update to the documentation.

Now you are up and running! You can test by running the help.

Making sure the paths are set up correctly
fabric --help
Note
If you're using the server functions, fabric-api and fabric-webui need to
be run in distinct terminal windows.
Using a local OpenAI API compatible server
If you want to use fabric with OpenAI API compatible inference servers,
such as FastChat https://github.com/lm-sys/FastChat, Helmholtz Blablador
http://helmholtz-blablador.fz-juelich.de, LM Studio
https://lmstudio.ai and others, simply export the following environment
variables:

export OPENAI_BASE_URL=https://YOUR-SERVER:8000/v1/
export DEFAULT_MODEL="YOUR_MODEL"

And if your server needs authentication tokens, like Blablador does, you
export the token the same way you would with OpenAI:

export OPENAI_API_KEY="YOUR TOKEN"

If using LM-Studio you must set your API key to lm-studio

export OPENAI_API_KEY="lm-studio"

Note
When running in WSL2 your fabric CLI client must be pointed at your
computers network IP address, not https://localhost or https://<IP_ADDRESS>
For example export OPENAI_BASE_URL=https://<IP_ADDRESS>:1234/v1/
Using the fabric client
Once you have it all set up, here's how to use it.

Check out the options
fabric -h

—
Reply to this email directly, view it on GitHub
https://github.com/danielmiessler/fabric/issues/489#issuecomment-2143652912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPVKQWVTVEUKJF3GBHJCS3ZFJVPNAVCNFSM6AAAAABIUALZGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGY2TEOJRGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Neil M. Greisman
@.***
416-277-8907

Same problem here with openai models.
`fabric --listmodels
gives me just an emptx result. Trying to summarize something with
`fabric --text "test" --pattern summarize
results in:
Error: Connection error.
Connection error.

Environment:
Windows 10 with WSL2 + Ubuntu 22.04.4 LTS
~/.config/fabric/.env exists + API key is configured.
I also tried setting the api key with "export OPENAI_API_KEY="YOUR TOKEN"" and even "export OPENAI_BASE_URL="https://api.openai.com/v1""


Feature Support Apache Avro file format

Proposed changes
#18431
Problem summary
support read avro file by hdfs() or s3() .
current avro reader only support common data type, the complex data types will be supported later
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.42 seconds
stream load tsv:          433 seconds loaded<PHONE_NUMBER>9 Bytes, about 164 MB/s
stream load json:         24 seconds loaded<PHONE_NUMBER> Bytes, about 93 MB/s
stream load orc:          60 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230516051549_clickbench_pr_144291.html


Actions (Email) not firing from java deployments.

Type of issue

[x] Bug
[ ] New feature
[ ] Improvement

Description
The email action is not working as expected. When the rule is triggered it is expected to fire an email. But I haven't received any email even after multiple rule firings. The info level logs indicate rules has been triggered, but there are no logs related to firing of an email or action getting executed.
Screenshot
Steps to reproduce

Create a java basic or standard deployment.
Create a rule configured with an email trigger.

Expected behavior
...
Current behavior
...
Known workarounds
...
Possible solution
...
Context and Environment

Operating System: ...
GitHub branch: ...
JRE & JDK: ...
SBT (version): ...

The management API call for the office365 logic app connector is returning an error:
GET https://management.azure.com/subscriptions/<subid>/resourceGroups/<rg-name>/providers/Microsoft.Web/connections/office365-connector/extensions/proxy/testconnection?api-version=2016-06-01

{
    "status": 401,
    "source": "https://logic-apis-eastus.token.azure-apim.net:443/tokens/logic-apis-eastus/office365/ba8faa96297c40ffa300167e26ce7fa1/exchange",
    "message": "Error from token exchange: Runtime call was blocked because connection has error status: Enabled| Error, and office365 is in the block list. Connection errors: [ParameterName: token, Error: Code: Unauthenticated, Message: 'This connection is not authenticated.']"
}


ghc821: init at 8.2.1-rc2 (a.k.a., <IP_ADDRESS>70507)

The approach taken to add this package was to port over the definitions
currently existing for 8.2.0, and making the necessesary changes to get
this building.
The Haskell package set associated with this compiler doesn't yet
guarantee that all or most of the packages successfully build with this
new compiler, but that will improve over time after this GHC 8.2.1
is officially released and the ecosystem catches up.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@k0001 Can you port over the cross-compilation stuff from HEAD.nix as well? cc @Ericson2314

@shlevy sure, I'll add that as well. Thanks for the quick feedback.

Err the cross compilation stuff in head needs a lot of revamp too. I have a yet-to-be-made PR for that, but it relies on other PRs that still need to be fixed.
So yeah, while it's fine to mimick some stuff from ghcHEAD, I'll end up rewriting it all anyways.

@Ericson2314 As long as you update it both here and in HEAD, no need to copy it over for now

@shlevy updated. I based my work off head.nix instead.


[alpha12] Unending Bowl doesn't fill or empty buckets(bottles) again.

It won't fill buckets in creative mode, it does fill buckets in survival mode.
It's not filling bottles in either mode however.

But I do this in survival mod((((

I may have fixed that in dev at some point.
Bottles are hard-coded so I'll need to hard-code it.


QR Code - New In-App Metrics

Metrics are identified here https://docs.google.com/document/d/1cquRya5pFDiaOFnKDh9MSJqF4s0eiF2yAOthflj1moI/edit

Blocked by lack of Schema

This has been addressed by:

cds-snc/covid-alert-metrics#106
cds-snc/covid-alert-metrics#120


Fix bf16 tests using torch as reference value

Enables much stricter tolerance (same as for other floats) now in binary operations.
Makes it easier adding other types only supported in torch in the future.
.float().numpy() float casting before numpy call is required.

Making draft as I don't like the copy paste feel of universal_test_unary_torch. Will work on it tommorrow. Also, one run still failed in CI in a previous run.


API route: DataSource tokenization (V1)

See #3237

Core API route to tokenize according to a given datasource setting
Front API V1 route to call this

AFAICT, both the original /tokenize and the datasource one here return CoreAPITokenType[] ( = array of [ token nb, token string])


set(x) in parallel to list(x) needed morphology.tex

\avm{
\emph{realisation-rule} \impl
	[mud & \1 set!(msp)! \\
	ms & \1 $\cup$ set!(msp)! \\
	mph & \list*(morph)]
}

You need to define these commands yourself. \list and \list* are not shipped with langsci-avm, it's a user definition as well. The procedure is explained in §3.3, "Defining input patterns", of the documentation.
Maybe you want sth along these lines?
\avmdefinecommand{set}[set]
  {
    attributes = \itshape,
    delimfactor = 900,
    delimfall  = 10pt
  }

And then use the starred \set* if the set is displayed in a value cell, but \set if in an attribute cell.

You need to define these commands yourself. \list and \list* are not shipped with langsci-avm, it's a user definition as well. The procedure is explained in §3.3, "Defining input patterns", of the documentation.
Maybe you want sth along these lines?
\avmdefinecommand{set}[set]
  {
    attributes = \itshape,
    delimfactor = 900,
    delimfall  = 10pt
  }

And then use the starred \set* if the set is displayed in a value cell, but \set if in an attribute cell.

I did this but this threw an error. It is now fixed by using \avmset rather than \set. I think you have something with \set in the code. Maybe this breaks it.

There is a new problem with spacing of italics text and the brakets. I think the distance is too close.

No, the code snippet I posted above works fine in unmodified langsci-avm and is compatible with langscibook. Maybe the error message comes from somewhere else? It's hard to tell without the complete error message. If this is still a problem, please provide a MWE and the error it produces.

Frank Richter defined set, check this.

This is somehow obsolete now, since I have new commands that just print text without using structured brackets:
\newcommand{\listOf}[1]{\upshape\textit{list}(\textit{#1})}
\newcommand{\setOf}[1]{\upshape\textit{set}(\textit{#1})}
\newcommand{\posetOf}[1]{\upshape\textit{poset}(\textit{#1})}

By the way: \listof was also used within the \avm environment, so I had to go for \listOf.
@kopeckyf you may close this once take over to some other repository.


support fabnet v4 for chameleon nodes.

Chameleon nodes can now use fabnet v4. Add the support for this feature in fabfed.

Not a priority.


Patch release of #17932

This release fixes an issue where the @backstage/plugin-kubernetes has a cyclical dependency in the built package

oops, how did we miss that @mclarke47 -- maybe an IDE was being too smart and automatically filling in imports...

It's no worries, I think that it actually might work at run time, but it definitely doesn't work under test in jest with cjs things getting in the way 😅


Add support for deleting keys

Hi, would it be possible to expose a Delete method?

Awesome, thanks.

Just an update, i'm currently working to improve the test https://github.com/iwanbk/bcache/commits/peer-test
I think it is better before i add new feature.

The deletion work is in progress at delete branch https://github.com/iwanbk/bcache/commits/delete

a WIP PR could be found at #22, still needs some docs and might be more tests

@luisdavim i've merged this PR for this delete feature.
Also relese this lib as v0.1.


docker compose with 4-peers doesn't get gracefully shut down

The most likely culprit is that the SIGINT signal (from Control + C) doesn't get forwarded beyond the first process, leading to non-graceful shutdown on all but the first process.

is this related to #1926 ?

Seems like it is.

If you build images with docker-compose-local.yml, then the problem is not reproduced. But it is reproduced with the docker-compose.yml where isn't init: true property.
I've tested docker-compose.yml with init: true and yeah the problem is no longer reproduced.
The doc explains why.

Might be reopened


Stage with merge conflicts warning still appears after all conflicts resolved

Similar to #35404 and #33983 which have been closed.

 Yes/No
yes

aaand not I can't reproduce any more ?!

Ok so the issue is that it's an rst file that contains lots of =========== for headers and that's probably throwing off the regexp. Can reproduce with slightly modified example.

I've also experienced this with a C# file that uses generics, which use some of the same symbols as merge conflict markers (<>). Can't say for certain that was the cause of the issue, but might be worth investigating.

Closing this, as it shouldn't occur many times and it's better to be safe than sorry.

Sorry but I disagree. This happens all the time and basically means you
can't commit restructured text files with vscode.
Sent from phone. Please excuse spelling and brevity.
On Wed, Sep 19, 2018, 14:57 João Moreno<EMAIL_ADDRESS>wrote:

Closing this, as it shouldn't occur many times and it's better to be safe
than sorry.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/53346#issuecomment-422813123,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbcFrwOnLG5Q864G8YW7AL5u2AL5Hs6ks5uck1SgaJpZM4U9S0d
.

What's the current regexp? Can it be made tighter?

Here it is: https://github.com/Microsoft/vscode/blob/master/extensions/git/src/commands.ts#L147
It looks for 7 consecutive occurrences of either <, > or = at the beginning of a line.

Shouldn't all three be present for an unresolved conflict?
I guess that function only works on single lines? I would argue you can't detect whether it's a failed merge on single lines.
A simple way to strengthen that would be to require exactly 7. That would make it less likely to fire spuriously. Git always uses 7, right?
Also, it might be more robust to only detect the < and > because they need to be seven < or > followed by a single space followed by a valid branch name followed by a newline.


Resolve the dependencies for moving BlockStore to a separate project

Remove LoggingConfiguration's dependency on BlockStore
Remove NodeSettings dependency on BlockStore

Can you please resolve conflicts?

I'll take care of this one @dangershony

Great stuff, thank you.
I saw that the test ReorganiseBlockRepository_WithBlockRepositoryAndChainOutofSync_ReorganiseBlocks_InMemory is failing. Is that something that you can fix?

@bokobza, it is one of those tests that succeeds when run on its own and would be failing intermittently. Perhaps this can be fixed in a separate PR along with other similar issues?

fine, thanks mate.


Reinit, Add Example App

Ref https://github.com/PlayerData/app/issues/2170
Re-initializes the library using https://github.com/callstack/react-native-builder-bob.
This adds an example app to allow easy development, and has nicer typescript integrations.
Also partially converted Android side to Kotlin.
All content under example/android and example/ios is generated, and can be ignored during review.

The example folders are important - we need to distribute the example app 🙂  (they're only generated as part of project setup)


Fixed overflow issue on message bubble

What does it do?
Long messages clip off the message bubble and will not wrap if it goes beyond the visible area. The solution introduced breaks down the message into an array of strings (lines) based on the bubble width to which an array of Text widgets are derived and laid out in a Column widget. In effect renders the long message as wrapped text.
Why is it needed?
This solution is needed since Text widget's soft wrap does not solve the issue encountered in this implementation.
How to test it?
Input a very long message.
Related issues/PRs
Let us know if this is related to any issue/pull request.

Do you have before and after screenshot for this @jcinco ?


ExDM - Change the namespace for test in the Graphical Data

Describe problem
The code map doesn't contain all the details. The namespaces in the test projects must not be the same as in the main projects.
List of tasks to be accomplished

[x] replace ViewMode with ViewModelTests
[x] replace Model with ModelTests
[x] Update NuGet packages
[ ] generate new code maps

Done


CreateDevelopmentEnvironment action failed. Error: Exception calling "FromBase64String" with "1" argument(s)

I was ready to use Device Login, but the error occurred in seconds.
Error: CreateDevelopmentEnvironment action failed. Error: Exception calling "FromBase64String" with "1" argument(s): "The input is not a valid Base-64 string as it contains a non-base 64 character, more than two padding characters, or an illegal character among the padding characters. " Stacktrace: at <ScriptBlock>, D:\a\_actions\microsoft\AL-Go-Actions\v2.0\CreateDevelopmentEnvironment\CreateDevelopmentEnvironment.ps1: line 35 at <ScriptBlock>, D:\a\_temp\2bce8241-e008-415b-9837-d8258fcb31fc.ps1: line 1 at <ScriptBlock>, <No file>: line 1

Here is the run:
https://github.com/AlGo-Workshop/app1/actions/runs/3229935671

I can see that

Will investigate.

I have hotfixed v2.0 with a fix for this.
Update AL-Go System files and it should work again

Confirmed, it works. Thank you.


rebase

Hi @hemlatabhatt. It looks like you've committed a local settings file by accident here.
I'm going to close this as it's not an actionable PR.


error

today i receive this error
Microsoft Visual C++ Redistributable is not installed, this may lead to the DLL load failure.
It can be downloaded at https://aka.ms/vs/16/release/vc_redist.x64.exe
Traceback (most recent call last):
File "C:\Users\p_melikidze\Desktop\moonbix-bot-main\bot\core\tapper.py", line 800, in run
await self.play_game(session)
File "C:\Users\p_melikidze\Desktop\moonbix-bot-main\bot\core\tapper.py", line 678, in play_game
from bot.core.solver.captcha_solver import solve_captcha
File "captcha_solver.pyx", line 4, in init bot.core.solver.captcha_solver
File "payload.pyx", line 6, in init payload
File "classifier.pyx", line 1, in init classify.classifier
File "C:\Users\p_melikidze\AppData\Roaming\Python\Python311\site-packages\transformers_init_.py", line 26, in
from . import dependency_versions_check
File "C:\Users\p_melikidze\AppData\Roaming\Python\Python311\site-packages\transformers\dependency_versions_check.py", line 16, in
from .utils.versions import require_version, require_version_core
File "C:\Users\p_melikidze\AppData\Roaming\Python\Python311\site-packages\transformers\utils_init_.py", line 27, in
from .chat_template_utils import DocstringParsingException, TypeHintParsingException, get_json_schema
File "C:\Users\p_melikidze\AppData\Roaming\Python\Python311\site-packages\transformers\utils\chat_template_utils.py", line 39, in
from torch import Tensor
File "C:\Users\p_melikidze\AppData\Roaming\Python\Python311\site-packages\torch_init_.py", line 148, in
raise err
OSError: [WinError 126] The specified module could not be found. Error loading "C:\Users\p_melikidze\AppData\Roaming\Python\Python311\site-packages\torch\lib\c10.dll" or one of its dependencies.
2024-10-06 11:27:48 | ERROR    | 813 - Moonbix | Unknown error: [WinError 126] The specified module could not be found. Error loading "C:\Users\p_melikidze\AppData\Roaming\Python\Python311\site-packages\torch\lib\c10.dll" or one of its dependencies.

dowload https://aka.ms/vs/16/release/vc_redist.x64.exe as it said then reinstall torch library

I installed it, but now it can't open the captcha with me. does it work with you

What did i say ?

i use vps i think not working correctly vps


Create navigating-mattermost-products.rst

Global Header
All content affected by GH

@cwarnermm: some notes:

Let me know how you want to align the Settings content.
I've standardized all the tabs - if you're happy with them I can apply the tab header wording to any current tabbed content.
Similarly, if you're happy with the flow of the content, we can standardize that across tabs as well.
I'm open to adding screenshots as discussed - not sure if elements would work well though.

Small edits on word choice.  Otherwise, all looks great to me! Thanks for all the work on this large affecting feature!


vsixPlugin broken >=1.85.3

Pre 1.85.3 I was using the vsixPlugin to import vsix extensions (and enable them) in one fell swoop (which worked wonderful)!
import './mathiasfrohlich.Kotlin-1.7.1.vsix';
import './sdras.night-owl-2.0.1.vsix';
import './tamasfe.even-better-toml-0.19.1.vsix';

Post 1.85.3 the extensions are completely missing from the builds (dev and build).
I did a double take, using vite build. Pre 1.85.3 the following is present in the dist/assets directory. While post 1.85.3 I cannot find any files related to the extensions.

So quick update to ensure we do not spent time doing the same thing.
In 1.85.3 the rollup plugin does emit the registerExtension code, but somehow it does not include any files from the extension (in my case). I added some debugging info to the resources variable which in all three of my vsix files are empty.
https://github.com/CodinGame/monaco-vscode-api/blob/86990ebacb72660fb0e5eb976fd9fe9c6d4baf67/src/rollup-vsix-plugin.ts#L84-L88
The only thing that really changed is the glob pattern compared to before, so not sure what is going wrong here...

I think I found the problem.
Pre 1.85.3 the code was:
https://github.com/CodinGame/monaco-vscode-api/blob/11cd928bca5848ada41df760ae6f17df9b3844be/src/rollup-vsix-plugin.ts#L96-L100
Post 1.83.4 the code is:
https://github.com/CodinGame/monaco-vscode-api/blob/86990ebacb72660fb0e5eb976fd9fe9c6d4baf67/src/rollup-vsix-plugin.ts#L84-L88
So the cwd got changed from '/' to id and I do not see how that could work to be honest. However I am confused to why #322 is not having any issues with bundling... Anyways, if I restore the cwd back to '/', the build works again and all missing files are bundled nicely.
@CGNonofr can you verify if this is indeed a bug and if so fix the cwd?

Indeed, it's a mistake while refactoring those rollup plugins. Do you mind opening a PR ?


Add preflight validations and force-cleanup for tink hardware status

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/lgtm

/retest