Procedure to use Cayley with a Postgres backend

Hi guys,
Today I asked this question on StackOverflow about using Cayley with a Postgres backend, a feature I saw referenced as implemented in this issue. However, it is not documented yet.
Thanks to the answer I got, who referenced the lib/pq documentation, I managed to connect with a cfg file like this:
{
    "database": "sql",
    "db_path": "user=user dbname=mydb password=mypassword sslmode=disable",
    "read_only": false
}

After that, running the cayley load --config=cayley.cfg.overview --quads=data/30kmoviedata.nq.gz command, I ran into the following errors:
quadstore.go:302] Couldn't execute horizon: pq: relation "quads" does not exist
cayley.go:277] db: failed to load data: pq: relation "quads" does not exist
Which I managed to get around executing the following query by hand, on psql:
CREATE TABLE quads (
        subject TEXT NOT NULL,
        predicate TEXT NOT NULL,
        object TEXT NOT NULL,
        label TEXT,
        horizon BIGSERIAL PRIMARY KEY,
        id BIGINT,
        ts timestamp,
        subject_hash TEXT NOT NULL,
        predicate_hash TEXT NOT NULL,
        object_hash TEXT NOT NULL,
        label_hash TEXT,
        UNIQUE(subject_hash, predicate_hash, object_hash, label_hash)
    );

After that, the cayley load --config=cayley.cfg.overview --quads=data/30kmoviedata.nq.gz command loaded the data and I could use the repl.
My questions are: will you update the docs? Did I do anything wrong above? If not, could I update it? Or do you want to do some more tests and development before it?
Thanks.

@marcusmonteiro Great question. The one thing you're missing is the preliminary step
cayley init --config=cayley.cfg.overview

It'll create the table and indices for you based on the config. Then go ahead and load. You're done! If you want to add the line to the docs that'd be super helpful, otherwise this issue tracks it.

Hi all.
I also want to use Cayley with a Postgres backend. But I have got a problem.
Here is my cayley.cfg
{ "database": "sql", "db_path": "postgres://test:test@<IP_ADDRESS>:5432/test_cayley?sslmode=disable", "read_only": false }
And the preliminary step goes well
cayley init -config=cayley.cfg
But when I run the command
cayley load  -config=cayley.cfg -quads="data/testdata.nq",
I got the following errors:E0325 14:15:07.055641 03038 cayley.go:290] db: failed to load data: pq: copyin statement has already been closed.
How can I solve this problem?
Thanks.

This setup worked for me a few months ago: https://github.com/oren/cayley-postgres
I haven't try that recently. if you give it a try and it's not working, please let me know.

@oren, thank you for your reply.
I try it following your steps. But when I run the conmand cayley load --config=cayley.cfg --quads=canada.nq, I still got the errors E0325 17:56:15.118697 13351 cayley.go:290] db: failed to load data: pq: copyin statement has already been closed.
Cayley I used is built from the source. And postgresql I used is postgresql-8.4.20-5.el6_7.x86_64.

@yiyunyaya I had the same issue recently and fixed it in #378. I could switch back to master branch and cherry-pick the fix for you, or you might try the new branch as alternative solution.

@dennwc - I'm experiencing the same error - could you cherry pick the fix on master to see if that works for me?

@AnthonyMete Done. Check dennwc/pq_copy branch.

Thanks @dennwc
Made the changes but still getting the error when following @oren's setup:

amete@amete:~/work/src/github.com/google/cayley$ ./cayley load --config=cayley.cfg --quads=canada.nq
E0427 15:28:59.448573 25331 cayley.go:290] db: failed to load data: pq: copyin statement has already been closed

In case this helps anyone else: I tried following these directions, but the binary version of Cayley I had didn't have a "sql" backend. It turns out you have to install it from source, even though this is presented as the option for people who want to hack on Cayley itself.

SQL works well, docs contains address templates for different database types, so I'm closing this.


feat: Default to XDG_PICTURES_DIR for save path

@mistricky  I think this is a better, more saner default were we default to the xdg_pictures_dir or /Users/<Username>/Pictures on mac. Let me know what you think. I tried to update the docs where applicable, not sure if more is required.

I'm not sure why, but I get this random as TOOD whenever I run it now:

Fixed the issue above by just moving to pure lua space.

@mistricky I think this is a better, more saner default were we default to the xdg_pictures_dir or /Users/<Username>/Pictures on mac. Let me know what you think. I tried to update the docs where applicable, not sure if more is required.

Hi @Uzaaft, I think set default value of save_path is great, but maybe there should have more logic for handle edge case, for instance, if the default path does not exist

What do you mean with edge cases? Isn't the edge cases done here, i.e defaulting to xdg, enough?

@mistricky I think this is a better, more saner default were we default to the xdg_pictures_dir or /Users/<Username>/Pictures on mac. Let me know what you think. I tried to update the docs where applicable, not sure if more is required.

Hi @Uzaaft, I think set default value of save_path is great, but maybe there should have more logic for handle edge case, for instance, if the default path does not exist

What do you mean with edge cases? Isn't the edge cases done here, i.e defaulting to xdg, enough?

I mean if somehow the value of XDG_PICTURES_DIR does not exists on disk, or if someone removed the ~/Pictures on his Mac, we should tell users what happened, and what they can do in this case.
Without default save_path, users should specify save_path explicitly, so the above case shouldn't happen, but if we set default value, we should check and throw more useful error message to users

I believe the error that will appear if the folder doesn't exist will be as useful as the one you provide today. I.e:
Value of type () couldn't be pushed on the stack: Lua runtime error: No such file or directory (os error 2).


Custom agent/etc/containerd/certs.d/* files are deleted by k3s on startup

Environmental Info:
k3s version v1.30.4+k3s1 (98262b5d)
go version go1.22.5
Node(s) CPU architecture, OS, and Version:
doesn't matter
Cluster Configuration:
doesn't matter
Describe the bug:
During generation of the containerd hosts config, the agent/etc/containerd/certs.d directory is completely deleted.
This happens here: https://github.com/k3s-io/k3s/blob/fa6940d03d39537636ef776db5c6719d4c0f6821/pkg/agent/containerd/config.go#L49
Steps To Reproduce:

put your own files into the agent/etc/containerd/certs.d folder
(optional) use k3s like this for a long time, upgrade k3s
start k3s
spend hours debugging stuff
figure out the files are deleted
be sad

Expected behavior:
I should be able to provide my own configs because I need full control over capabilities etc.
Actual behavior:
My own configs are deleted.
Additional context / logs:
At first glance I was thinking "why is there a os.RemoveAll in the code" but I can understand why this was implemented like this.
The writeContainerdHosts function needs to support deleting outdated files from previous configurations.
So my idea how to fix this would be instead of deleting all files, list all files and check if they start with # File generated by k3s. DO NOT EDIT.. And only delete them if they do.
What do you think?
Also, unfortunately its not possible to supply multiple config_path because then containerd won't start.

That does sound like a good potential solution. I think there might be some corner cases to work around, where we may drop certificates into that directory, but not create a hosts.toml - but that could probably be addressed by ensuring that we create a stub hosts.toml even if only placing certificates.

https://github.com/k3s-io/k3s/issues/10838#issuecomment-2343476754


Multi-Round Inference: training never ends, if inference object is saved/loaded to/from disk

Background information: I want to use multi-round inference with SNPE, but as I am not really experienced in Python and my simulator is not a Python code I thought of the following plan:

Run my simulator externally
Perform training with SNPE; save the inference object and posterior to disk; exit Python.
Run my simulator again with samples from the posterior and save results to disk.
Open Python again. Load the previously sampled inference object, append the new simulations. Then jump to step 2 to create a loop until enough rounds are done.

Now I have come across the following problem: if an inference object is saved to disk and then loaded again, simulations can be appended, but the following training simply never stops. Funnily enough, it prints Neural network successfully converged after ## epochs., but the code does not continue.
Here is an example (slightly modifified from here: https://www.mackelab.org/sbi/tutorial/03_multiround_inference/) that illustrates the problem:
import torch
import dill
from sbi.inference import SNPE, prepare_for_sbi, simulate_for_sbi
from sbi.utils.get_nn_models import posterior_nn
from sbi import utils as utils
from sbi import analysis as analysis

num_dim = 3
prior = utils.BoxUniform(low=-2*torch.ones(num_dim),
                         high=2*torch.ones(num_dim))

def linear_gaussian(theta):
    return theta + 1.0 + torch.randn_like(theta) * 0.1

simulator, prior = prepare_for_sbi(linear_gaussian, prior)

inference = SNPE(prior=prior)

num_rounds = 2
x_o = torch.zeros(3,)

posteriors = []
proposal = prior

theta, x = simulate_for_sbi(simulator, proposal, num_simulations=500)
density_estimator = inference.append_simulations(theta, x, proposal=proposal).train()
posterior = inference.build_posterior(density_estimator)
posteriors.append(posterior)
proposal = posterior.set_default_x(x_o)

with open("./temp.pkl", "wb") as handle:
    dill.dump(inference, handle)
del inference
with open("./temp.pkl", "rb") as handle:
    inference = dill.load(handle)

theta, x = simulate_for_sbi(simulator, proposal, num_simulations=500)
density_estimator = inference.append_simulations(theta, x, proposal=proposal).train()
posterior = inference.build_posterior(density_estimator)
posteriors.append(posterior)
proposal = posterior.set_default_x(x_o)

posterior_samples = posterior.sample((10000,), x=x_o)

# plot posterior samples
_ = analysis.pairplot(posterior_samples, limits=[[-2,2],[-2,2],[-2,2]],
                   figsize=(5,5))

Versions:

SBI: 0.17.2
torch: 1.9.0+cu102
Python: 3.8.10
OS: Ubuntu 20.04

Thanks for reporting this! This has been fixed in a recent PR but has not been released yet. If you can not wait for the next release, you can work on the bleeding edge. Since you wrote that you are unfamiliar with python, here is how you do that:
git clone git@github.com:mackelab/sbi.git
cd sbi
pip install -e .

Feel free to reopen the issue if it persists.

Sorry, I meant
git clone https://github.com/mackelab/sbi.git

perfect, thank you! I appreciate the advice on how to work with the bleeding edge very much.


Updated 'zat new' template

:v:
/cc @zendesk/vegemite
Description
The template used to generate iframe.html when running zat new needs updating. The 'u-gamma' class attribute, for example, is no longer part of Zendesk Garden. Also, the 'bedrock' CSS library pulled in resets all styling and probably isn't the best demonstration of Garden.
Changed H2 text styling using Utilities CSS class settings. Changed relevant links as comments.
Risks

[low] Switching out existing Bedrock CSS library for Utilities library. Updated H2 class attributes.

LGTM besides making it 1 request


How can I tap on the card to move to another view Controller

TapGesture applied like Pan Gesture But delegate not calling in view Controller ,is there any other way to achieve this.

this isn't a problem with this repository, so I'm going to close this issue.  I would recommend looking into how navigation and segues work in iOS.  You can't just call a view controller to show up in a view, you need a parent view controller or navigation controller

I have already created a Parent View Controller inside which i have called
DraggableViewBackground ,Now i need to apply Tap on the card when i create
a protocol in draggableView.h and called it into parent View controller ,it
gives me error in DraggableViewBackground View . Now the thing i want to
ask is how can i create the cards tappable. help me i've working on this
from last day ,.
On Tue, Dec 20, 2016 at 12:53 AM, Richard Kim<EMAIL_ADDRESS>wrote:

this isn't a problem with this repository, so I'm going to close this
issue. I would recommend looking into how navigation and segues work in
iOS. You can't just call a view controller to show up in a view, you need a
parent view controller or navigation controller
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cwRichardKim/TinderSimpleSwipeCards/issues/30#issuecomment-268053762,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATw9a6t0ErJV6BGIcwpEtkk-60DbmPHaks5rJtmegaJpZM4LQjWY
.

I'm really sorry, but the github issues section of this repository is meant for resolving issues with the repository.  I unfortunately can't afford to spend time with everyone's issues outside of the scope of this project


Lens Logic

You can call lens(loc) instead of items.Lens
replace loc with either 'Semi' or 'All' Semi is for all places Semi is for things relating to crossing the wasteland

Gonna wait until what I have in the PR gets merged before merging this, though it has some conflicts that are preventing the merge anyway. I can deal with them once the time comes to merge it if you'd rather

Closing this PR for now, I derped and forgot to add magic logic into the setting. Sigh Ill make a new PR once its fixed


Allow non-java clients to start consumer from timestamp

Describe the solution you'd like
#3622 (#3565) granted Java clients the ability to start & seek to a given timestamp. This request is to give that functionality to non-Java clients, in my specific case, Go.
The reasons for wanting this functionality are the same as described in #3565.

@phemmer are you using cgo or native-go client?

cgo. This one: https://github.com/apache/pulsar/tree/master/pulsar-client-go/pulsar

Closed as stale.
The development of the Go client has been permanently moved to https://github.com/apache/pulsar-client-go. If it's still relevant, please open an issue there.


Rule 932200, now inspecting Referer headers, matches any query string that contains spaces

Description
Rule 932200 was recently updated to add the following items for inspection:
REQUEST_HEADERS:Referer|REQUEST_HEADERS:User-Agent
Unfortunately, with the Referer header, this rule now causes false positives for the following scenario:

referer header contains a URL, and
URL includes a query string, and
query string includes one or more space characters (+) and/or URL includes one or more space characters (%20).

For example, these headers both cause a false positive:
Referer: http://www.example.com/page?param=test+test'
Referer: http://www.example.com/page%20test?param=test'
This header does not cause a false positive, as there are no encoded space characters:
Referer: http://www.example.com/page?param=test_no_space_char'

Cause
Rule 932200 has a regular expression looking for one of a number of optional patterns. This is the problematic pattern:
/[^/]+?[*?`\x5c']
<forward slash><non-forward slash chars><question mark> -> this will match URLs that feature a query string, e.g.
/some/dir/page?foo=bar
The presence of this chained rule:
SecRule MATCHED_VAR "@rx \s" "t:none,t:urlDecodeUni
means that a space character must also be present.
How to reproduce the misbehavior (-> curl call)
Testing the CRS Docker container:
curl -v -o/dev/null localhost -A 'test' -H 'Referer: http://www.example.com/page?param=test+test'

=>
[Thu Mar 30 11:13:44.997007 2023] [security2:error] [pid 40:tid<PHONE_NUMBER>63392] [client <IP_ADDRESS>:54008] [client <IP_ADDRESS>] ModSecurity: Warning. Pattern match "\\\\s" at MATCHED_VAR. [file "/etc/modsecurity.d/owasp-crs/rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "942"] [id "932200"] [msg "RCE Bypass Technique"] [data "Matched Data: /page? found within REQUEST_HEADERS:Referer: http://www.example.com/page?param=test test"] [severity "CRITICAL"] [ver "OWASP_CRS/4.0.0-rc1"] [tag "modsecurity"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-rce"] [tag "paranoia-level/2"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "localhost"] [uri "/"] [unique_id "ZCVu6EXwaRSBQCgL9kHo9wAAAIw"], referer: http://www.example.com/page?param=test+test
Your Environment

CRS version (e.g., v3.3.4): v4.0.0-rc1
Paranoia level setting (e.g. PL1) : PL 2
ModSecurity version (e.g., 2.9.6): n/a
Web Server and version or cloud provider / CDN (e.g., Apache httpd 2.4.54): Apache
Operating System and version: n/a

Confirmation
[x] I have removed any personal data (email addresses, IP addresses,
passwords, domain names) from any logs posted.

I vote for simply removing Referer matching again. There's no quick fix here I can see, we would need to craft a new rule that targets the actual format of the Referer header and checks for URL related bypass techniques specifically.

I currently using the following rule as an exclusion. It handles the above situation and another situation that my personal blog faced.
SecRule SERVER_NAME "@contains blog.jitendrapatro.me" \
     "id:1058,\
     phase:1,\
     pass,\
     nolog,\
     chain"
     SecRule REQUEST_HEADERS:Referer "@rx /\\w+(?:\.|'')\\w+\\?" \
        "ctl:ruleRemoveTargetById=932200;REQUEST_HEADERS:Referer"

I also think we should remove Referer again.

If you're going to remove it, then atleast take into consideration what @theseion suggested. There are cases in which the Referer header can be exploited by attackers and we need to have separate rule targeting common bypass techniques.

I thought this over and I think removing is totally not an solution. Rather, there should be a separate rule specifically targeting common bypasses.

How did you get the Let's Encrypt FP? I've set Certbot to automatically update Certificates at the first of every month and have never faced any problems.

@Xhoenix I installed the newest v4 release on several servers and they had all the same problem...

There's already a separate issue for this: #3163.

@emphazer I think the problem is while installing new certificates and not while renewing them. Did the FP also shows up when renewing certs?

@RedXanadu How about this:-
/[^ a-zA-Z0-9._-]+?[*?`\x5c'])
In the above regex if I've used the / then a payload like cat /etc/passwd would've been allowed. This above also excludes common command injection characters like &|;`$\ and more. This also protects against all command injection payloads presently known publicly.
For a basic test:-
echo "$testing/t so-me.php?isanothertest" | grep -oP "/[ a-zA-Z0-9._/-]+"

Is there any reason this shouldn't be used? I'll be happy to open a PR if you want this. 🙂

Okay, the hyphen character(-) allows payloads like sh -c whoami, but will most likely get blocked by other rules. Still, I think removing it would be a better choice.

@Xhoenix Not sure if that would work, you'd have to test it. (I'm not working on a fix for this issue, just FYI.)
The outcome from the meeting discussion was to try and fix the existing regular expression. If that does not work then 'Referer' inspection for this case will be moved to paranoia level 3 as we cannot afford these false positives at PL 2.

I've opened a PR that addresses this issue: #3300. I was forced to create two additional rules. @Xhoenix, I would appreciated it if you'd also take a look at the PR.

Small typos in rule 932200 regex. Updated regex can be viewed here:- https://regex101.com/r/w3kLqB/1

As far as I can tell, your version is identical to the one in this PR...?

@Xhoenix There's a CRS rule that states that forward slashes are not escaped in regular expression patterns, in the interests of making patterns slightly easier to read.
@theseion I've suggested (via a PR to your PR) to also add tests to check against the original rule that was reported to have false positives. I've also asked a question in the PR review as I don't follow what part of the PR is doing.

@RedXanadu I can't find the PR that you say you've opened.

Found it. Since the PR has already been merged, I've created a new PR with your changes: #3309.


Ternary operator and self-executing function

This issue demonstrates two problems:

A case where a self-executing function is not considered a function call when used in a ternary operator.
A semicolon is considered unnecessary when it is defensive in nature.

PROBLEM 1: When I add a self-executing function as part of a ternary operator expression, I get an error.
Error received from jshint:
Expected an assignment or function call and instead saw an expression. "} ())"
A self-executing function is a function call: it calls itself, and it should be treated as a function call.
EXAMPLE:
var foo;

; (foo)
? foo.bar = {}
: (function () {
	foo = {};
	foo.bar = {};
} ())
;

PROBLEM 2: Semicolon before expression parentheses.
The initial semicolon above is reported as unnecessary, but can help prevent errors from code that may have been included that did not include appropriate semicolons.
Thanks!

@ryanfitzer you can turn that on by setting expr flag to true.

That was it! Thanks soo much.
Any clue on the "Missing space after 'function'." warning? This happens if there is no space between the word function and ()?
!function() {}();

I assumed it was the white option, but that wasn't the case. I figure it is checking it against the same rules that apply to if/while/for type expressions, but I can't find the option (if it even exists).
Thanks again.

It's supposed to be white.
This works for me:
/*jshint expr: true, white: false */

!function() {
}();

Just tried yours and it worked. Not sure why, but indent: 4 is causing the issue. When removed, it works?
Not sure why it would conflict. Bug?

indent includes white: true... Hope we can remove it someday (or output a warning at least)

This was fixed in GH-414.


Plugin behaviour related questions

I'm submitting a ...  (check one with "x")

[x] question
[ ] any problem or bug report
[ ] feature request

If you choose 'problem or bug report', please select OS:  (check one with "x")

[x] Android
[ ] iOS

cordova information:  (run $> cordova plugin list)
Ionic information provided - Includes cordova plugin info
"dependencies": {
    "@angular/common": "5.0.3",
    "@angular/compiler": "5.0.3",
    "@angular/compiler-cli": "5.0.3",
    "@angular/core": "5.0.3",
    "@angular/forms": "5.0.3",
    "@angular/http": "5.0.3",
    "@angular/platform-browser": "5.0.3",
    "@angular/platform-browser-dynamic": "5.0.3",
    "@ionic-native/core": "4.4.0",
    "@ionic-native/device": "^4.5.3",
    "@ionic-native/diagnostic": "^4.5.3",
    "@ionic-native/file": "^4.5.3",
    "@ionic-native/geolocation": "^4.5.3",
    "@ionic-native/google-maps": "^4.5.3",
    "@ionic-native/in-app-browser": "^4.5.3",
    "@ionic-native/intel-security": "^4.5.3",
    "@ionic-native/location-accuracy": "^4.5.3",
    "@ionic-native/network": "^4.5.3",
    "@ionic-native/splash-screen": "4.4.0",
    "@ionic-native/sqlite": "^4.5.3",
    "@ionic-native/status-bar": "^4.4.0",
    "@ionic/storage": "2.1.3",
    "com-intel-security-cordova-plugin": "^2.0.3",
    "copyfiles": "^2.0.0",
    "cordova-android": "^6.4.0",
    "cordova-plugin-device": "^2.0.1",
    "cordova-plugin-file": "^6.0.1",
    "cordova-plugin-geolocation": "^4.0.1",
    "cordova-plugin-googlemaps": "^2.1.1",
    "cordova-plugin-inappbrowser": "^2.0.2",
    "cordova-plugin-ionic-keyboard": "^2.0.5",
    "cordova-plugin-ionic-webview": "^1.1.16",
    "cordova-plugin-network-information": "^2.0.1",
    "cordova-plugin-request-location-accuracy": "^2.2.2",
    "cordova-plugin-splashscreen": "^5.0.2",
    "cordova-plugin-statusbar": "^2.4.1",
    "cordova-plugin-whitelist": "^1.3.3",
    "cordova-sqlcipher-adapter": "^0.1.12-rc2",
    "cordova.plugins.diagnostic": "^3.9.2",
    "ionic-angular": "3.9.2",
    "ionicons": "3.0.0",
    "rxjs": "5.5.2",
    "sw-toolbox": "3.6.0",
    "zone.js": "0.8.18"
  },
  "devDependencies": {
    "@ionic/app-scripts": "3.1.8",
    "typescript": "2.4.2"
  }

Current behaviour:
I have a couple of questions related to the maps plugin:

In case a pause event is received during the app launch (for instance a phone call was received), will the plugin continue to load after receiving the resume event. What will happen if pause is received at the time the plugin is trying to fetch the google maps library? Is there a way to recover from this?

In poor data connections (GPRS, EDGE), if the plugin cannot load the Google maps library is there a way to reload the plugin when better network is available without having to load the page?

If the maps plugin receives the pause event, the maps plugin pauses the native maps views. If the maps plugin receives th resume event, the maps plugin resumes thr native map views.

https://github.com/mapsplugin/cordova-plugin-googlemaps/blob/master/src/android/plugin/google/maps/CordovaGoogleMaps.java#L490:L512

Behavior of the maps views behavior in poor connection is not the maps plugin control. This plugin is just a wrapper, it means bridge between JS and native code. The maps plugin does not control the maps view behavior.

Thank you for your response.


Embeddable relations

Hello! I checked your conversation in https://github.com/doctrine/doctrine2/pull/1502
I really enjoined embeddable relations concept for my project. Btw I need your advises:

How can I use this branch to extend doctrine classes (so to be able update doctine)?
My use case is to refernce from table A to table B using ManyToMany relation. Problem is that A needs to have 3 property with same Embeddable class (which is have 1 ArrayCollection property referenced to B as ManyToMany and 5 methods to operate with collection).
The current implementation is to flatten embeddable contents into single Entity class - too bad because it means to place 3 property and 5*3=15 methods into one class, so much code and so much copy-pasting (as well as the need to fix one thing in 3 methods to keep methods in sinc).


fix: fixed the overlapping of playground loader

Description

fixed the loader of playground section

Related issue(s)
fixes #1316

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.196%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5240

Relevant Lines:
5542

💛  - Coveralls


Pagination stopped working with gitlab.com Groups.ListGroupProjects

Using the following example client/options
client, err = gitlab.NewClient(token)
opts := &gitlab.ListGroupProjectsOptions{
    ListOptions: gitlab.ListOptions{
	    PerPage: 20,
	    Page:    1,
    },
    IncludeSubgroups: gitlab.Bool(true),
}

client.Groups.ListGroupProjects("gitlab-org", opts)

To get projects from here https://gitlab.com/gitlab-org
Will not properly paginate response.TotalPages returns 0

Thanks for letting me know, in that case I will close this issue 👍🏻


Fix for issue 839 and 490 on Windows

The paths were seen as changed but not static because of the backslashes in ev.Name. Once the backslashes were added, I discovered that the JSON sent to livereload was invalid and failed to work because it had backslashes.
Hence the code to replace the backslashes from the path to make them work in JSON and for the URL.
With this fix, changes to a stylesheet are shown on the page, and if it's a single file that changed, it's reflected in the browser without reloading the whole page.

Merged in 523f38a
Thanks, it's hard to discover these issues from Linux ...

Works beautifully. Thanks.


Write specification for the current and future versions of the ooni-explorer API

This involves documenting where we currently are at with the API, but also defining how the next iteration of it should be.
I believe we should separate the API endpoints into a public API (to be consumed by third parties that wish to integrate OONI data into their system), that is going to be backward compatible and quite stable and a private API (to be used internally by the explorer and other ooni products that need to use it as part of their application logic).
I would say the API specification should be written using swagger so we can support programmatic code generation, documentation generation and end to end testing capabilities.
The rational behind the API design would be either part of the swagger specification itself or inside of a markdown document.
Some notes about this can be found here too: https://github.com/TheTorProject/ooni-explorer/wiki/API-Design

Issue moved to TheTorProject/ooni-measurements #9 via ZenHub


The driver connects to the wrong SQLServer host

Driver version
11.2.1
Client Operating System
Linux
Problem description
When the database driver is used to connect to different SQLServer hosts, it can happen that the TCP connection is established to the wrong host. This is due to a race-condition in com.microsoft.sqlserver.jdbc.SocketFinder#getSocketByIPPreference. The change was introduced in #1766.
com.microsoft.sqlserver.jdbc.SocketFinder#addressList is static, and this state is shared across all SQLServerConnection instances, even if connected to different SQLServer hosts. A race-condition when mutating this state in com.microsoft.sqlserver.jdbc.SocketFinder#getSocketByIPPreference can lead to the socked being connected to an unexpected host.

Hi @mmimica,
Thank you, we'll take a look into both the issue and the potential fix.


createSignature's options params is not working

hihi, you forgot to include the options in the "createSignature" invokeMethod like shown in above pic.

hihi, you forgot to include the options in the "createSignature" invokeMethod like shown in above pic.

@cybriz , Sounds reasonable. Even when calling Flutter's inbuilt compute function, argument for calling the actual computed function is passed like this.  Let me check and put in a new release.


Switch tests to hspec

Looks like hspec-autodiscover doesn't work with GHC 7.6.

@CristhianMotoche Is there anything to change here if we don't have GHC 7.6.3 in the configuration for Travis?

We simply need to return in 1 commit.

I did a rebase of this branch with master. Now, the last 2 commits from @jsantos17 will be enough to use hspec for the test.

@CristhianMotoche this LGTM. Can you merge it?
Perhaps later we can make the specs a bit more idiomatic, along the lines of what we did with dotenv (i.e., not using so many spec functions, but using more describe blocks to group specs like we do with rspec in Ruby). However, this should be a good enough start for now. Thanks!

@jsantos17 started this PR, but I can merge it if there is no problem with that.

@jsantos17, Can you please rebase on the current master?

@jsantos17, OK, I rebased and resolved the conflict for you. Going to merge.


Repository Layer

Implement a repository layer for handling interaction with the underlying database. A repository will be a thin wrapper around Entity Framework DbContext, providing CRUD methods. The major reason of implementing the repository layer is that it hides the DbContext objects and operations, which are often hard or impossible to mock, which hinders unit testing.

Could have closed this by using "closes #3, closes #11 " when merging PR #9


Add watcher-operator to the content provider base job

In order to run meta content provider against watcher-operator[1], We need to add watcher-operator under content provider required projects.
Links:
[1]. https://github.com/openstack-k8s-operators/watcher-operator

recheck after https://review.rdoproject.org/r/c/config/+/55459

check rdo

recheck

/lgtm

/approve


[websocket] Add enableAutomaticPings & disableAutomaticPings

This refers to issue #1567 and adds methods for enabling & disabling automatic websocket pings.
I'm not entirely sure on how synchronization works with the used methods, to we need a mutex or similar? Is there a race somewhere in the code if two threads call enableAutomaticPings/disableAutomaticPings at the same time? Is that even possible?
Maybe some sort of locking mechanism is required, but as a first prototype this patch does seem to work.

This is an interesting approach! I thought you would make to a config option on a higher level, but running this in something like a wsBefore could work too :thinking_face:

Ohh, that's something I didn't really think about, I thought maybe you'd want to enable/disable automatic pings on a per-client basis, or have different interval timeouts for different device types. For example, you could have a higher timeout for mobile devices than for desktop devices.

Your way is definitely more flexible, I like that part, 🤔

How expensive are executors? Is it fair to have one per connection?

I think we should have a shared executor for the pings, and a way of ending jobs on error?

You're right, I completely forgot about disconnects. A shared executor is probably a good idea as well, though it's hard to find any documentation about it's thread safety - do we need a mutex of some kind of we have a shared instance?

A shared executor is probably a good idea as well, though it's hard to find any documentation about it's thread safety - do we need a mutex of some kind of we have a shared instance?

I'm not sure. How I have typically solved this, is to add the session to a ConcurrentHashMap, then loop through that map every timeunit. So just one executor and one task, accessing a thread-safe set.
This would then be less flexible wrt different intervals, but maybe it's okay?

I'm not sure. How I have typically solved this, is to add the session to a ConcurrentHashMap, then loop through that map every timeunit. So just one executor and one task, accessing a thread-safe set.

That would be an option, though I think we can stay flexible if we use the executor system. I tested around a bit and you're right, a single thread executor is quite heavy - every instantiation basically creates a new thread! I didn't know this, but you're right, my solution was horrible.
According to this: https://stackoverflow.com/a/7596354 executors are in fact thread save, and if we use a single thread for all pings, we should be fine. That's what my current pr does, let me know what you think.

I just noticed that pingFuture might need a mutex, t hough in practice a race is probably very rare/impossible with that variable.

A bit late now, but is it possible to test this? 🤔

I mean we can test calling the method & see that no exception gets thrown. The problem is that timeouts without pings are OS-specific. I looked around a bit and it does seem possible to actually detect ping & pong packets with the websocket client the javalin websocket tests are using, so it should be possible to test this. I'll try to create a PR in the next week.

Thank you very much ☺


Price callbacks do not consider grid fee

https://github.com/BESTenergytrade/simply/blob/eebacef48814ebfaa28bf58f977f4611d4f39a40/simply/market.py#L139-L144
Right now both sides of a match get their callback function called with the matched price. In my opinion the price the ask_participant receives should be reduced by the grid fee, since the grid fee is not part of the profit.

Yes, the payed fees should be stored separately, e.g. within the market.

The payed fees are already stored in market.matches which has "price" as well as "included_grid_fees"

true


Better Dynamax support

This adds functionality to the already planned "Dynamax" button:

It also adds Max Power to all supported moves (data is fetched from Showdown's repo).

Besides the code styling issues that pre pointed out, this looks good and I believe is the last step needed for this branch 👍

Are there any more code style issues that you have with this pr @scheibo ?

There is a 3000+ line diff in index.html showing up which certainly doesn't belong:

After those few nitpicks this looks good for merging :)

There’s just that one line you removed and then we are good to go!

What line? Sorry, I wasn't following your conversation.

Thanks!


Android Google Map Localization

I would like to show google map in French, Italian in Android app. How I can set language of map ?

If you mean you want to localize the name of streets and cities on the map, they are already localized. The map will show the English name on top of the localized name with the default setting (idk if that can be changed). You can see this more clearly if you navigate above china for example and zoom in a bit.


save preserveAspectRatio attr from progonal svg to symbol in sprite

It is useful to copy 'preserveAspectRatio' attribute from original svg icon to symbol in svg sprite (as well as id, class, viewbox) as it influences the way symbol is aligned when element that uses it is scaled (and it's ratio is different from the sybmol's ratio).

@fr-ench v0.0.20 published with your commit


DataSource name export is missing in InMail Service.

Describe the bug
The datasource name mentioned in the readme is missing from the exports.
To Reproduce
Steps to reproduce the behavior:

install the @sourceloop/in-mail-service package.
try to write a datasource, using the datasource name from the readme.
The datasource export is missing.

@Jyoti-13


Recursive subcommand could give better error

This is a very minor issue. I accidentally created a command that has itself as a subcommand, like this:
import picocli.CommandLine.Command;

@Command(name = "bad", subcommands = BadCommand.class)
public class BadCommand {

}

While this is of course incorrect, it gives a fairly opaque error:
error: FATAL ERROR: java.util.regex.PatternSyntaxException: Stack overflow during pattern compilation near index 9.
It might save someone else in the future a bit of trouble if this gave a more descriptive error. :-)

@battery-staple Thank you for raising this.
Is this something that happens in picocli's annotation processor during compilation, or in picocli's reflection code at runtime?
Is there a full stack trace you can provide?


What are unhandled vote questions, and should I worry about them?

(congress)cmb:congress burchc$ ./run votes --congress=114 --session=2015
Going to fetch 199 votes from congress #114 session 2015
Unhandled vote question: Table Motion to Refer
Unhandled vote question: Call by States

It looks like this is an effort to assign vote question text to categories, although this message isn't documented in the wiki. I see there's some effort to handle (i.e. normalize) the "Call by States" question in PR #155
Does this (warning?) message mean the vote type or category will be blank? Will it have any other effects?

You are correct that this is an effort to assign vote question text to categories. In the event of an unhandled question, you'll see "category": "unknown" in the scraper's JSON output (as with, for example, h1). This is in distinction to a vote on something like h2, which has "category": "leadership".
Because the scrapers are not tied to any particular implementation, it's hard to say whether or not one should worry about an 'unknown' value in this field. But within the scrapers themselves, nothing catastrophic will happen.

I'm going to close this issue because it's not actionable, but feel free to keep hitting this thread!


We need to validate libraryId for null versions for unPkg provider

Functional impact
Install libraries for unPkg provider without version (via UI or manually) fails with the below message in the output log window:
Restoring library jquery... (WebApplication48)
Restore operation failed for {0} libraries
Minimal repro steps
Install library without version for unPkg provider from UI or manually
Expected result
We should validate for version and throw an exception when libraryId is not valid. In the UI we should disable install and throw a warning that libraryId is invalid
Actual result
We fail silently with the below message in the log:
Restoring library jquery... (WebApplication48)
Restore operation failed for {0} libraries
We fail here with a NulRefException: https://github.com/aspnet/LibraryManager/blob/e07b24957b4d41cc56bfba6233d01f4960b8854c/src/LibraryManager/Providers/Unpkg/UnpkgProvider.cs#L99

Fixed via https://github.com/aspnet/LibraryManager/commit/42ec85a11f92127a842796f44e1bc6f5f181a79e


Tiff Thumbnail Issue

I am trying to show a thumb preview of the images user will upload but of course I've problem with tiff files. Is there anyway to do it? or eventually to show a default picture in case the user is trying to upload a tiff?

Does ngf-thumbnail="file || defaultImageUrl" works to show default image?

(First of all thanks for the fast reply) It dosen't work. I guess because file is indeed defined

"(file && file.type != 'image/tiff') || defaultImageUrl"

Thanks a lot. It worked partially. It's good to show another picture in case of tiff but doesn't show any jpg, gif, png, etc images. I fixed like this (hope it can be helpful to someone else):
img.upload-thumb(             ng-if="file.type != 'image/tiff'"             ng-show='uploadForm.file.$valid'             ngf-thumbnail="file"             ngf-size="{width: 120, height: 140, quality: 0.9}")  img.upload-thumb(             ng-if="file.type == 'image/tiff'"             ng-show='uploadForm.file.$valid'             ngf-thumbnail="(file && file.type != 'image/tiff') || 'defaultImageUrl'"             ngf-size="{width: 120, height: 140, quality: 0.9}")


s3 toggle-logging action - append '/' to the default target_prefix (#1464)

Verified the change locally

hmmm.. slash here would result in double slash in keys?

ah.. actual reason for change is described in #1464

Yes, sorry - should have put that in the PR message as well. Currently the slash is missing from the prefix, so the log objects get written directly into the root of the logging destination bucket.
Example action:
      - type: toggle-logging
        target_bucket: my-logging-bucket

Results in log objects like this:
s3://my-logging-bucket/my-source-bucket2017-08-07-17-22-28-D5813C87E6C5A11F


EtherPhunk #8436 #1420 #5560

After earlier issues resolved, Phunks mentioned in title seem stuck (there are possibly a few others). Can not withdraw from escrow, can not list. Error message keeps popping up. Withdrew several others with no issues

@Cyphstrain try accepting the bid I put on it.

I tried. Got the usual error message.

This issue relates to #36


Add support for external SYSLIB property (in Build Report)

What do we need that for ?
The BuildReport can then be used as input to the functionality described here: https://github.com/IBM/dbb/tree/master/Pipeline/RunIDZCodeReview.
If the external SYSLIBs isn't present (copybooks) in the BuildReport, we can't use the BuildReport as input.
Thanks

Morning @nixpix49 ,
With the DBB API, it is possible to report all the DDAllocations in the build report by using this API: https://www.ibm.com/support/knowledgecenter/en/SS6T76_1.1.0/javadoc/com/ibm/dbb/build/DDStatement.html#report-boolean-
It looks like this:
compile.dd(new DDStatement().dsn(syslibDataset).options("shr").report(true))

along the processing of the SYSLIB https://github.com/IBM/dbb-zappbuild/blob/development/languages/Cobol.groovy#L210
You are able to have all the datasets in the SYSLIB, see a sample :

However, while not all the users of zAppBuild also make use of the IDZCodeReview, and I don't would like to overload the BuildReport.
Therefore, I will open an enhancement on the ibm/dbb to have a property, where we can add an external syslib as well. I know that this leads to a duplication of the SYSLIB info, however I don't see any other way to solve it right now.
Thoughts?

Thanx Dennis! Will check it out!
Have a nice weekend and stay SAFE!

@dajsen please check this out. It is delivered in https://github.com/IBM/dbb/pull/72 and please close this issue if this is sufficient for you. Thx. Stay Safe as well!


Consolidate logs

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: quanjielin, wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [quanjielin,wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wattli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests-master

@wattli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio_auth_sds_e2e-master

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio_auth_sds_e2e-master

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio_auth_sds_e2e-master

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-master

prow/e2e-mixer-no_auth.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio_auth_sds_e2e-master

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-master

prow/e2e-mixer-no_auth.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-mixer-no_auth-master

prow/e2e-simpleTests-cni.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-cni-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio_auth_sds_e2e-master

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-master

prow/e2e-mixer-no_auth.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-mixer-no_auth-master

prow/e2e-simpleTests-cni.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-cni-master

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio_auth_sds_e2e-master

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-master

prow/e2e-mixer-no_auth.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-mixer-no_auth-master

prow/e2e-simpleTests-cni.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-cni-master

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master

/test e2e-simpleTests-master

/test istio_auth_sds_e2e-master

/test integ-framework-k8s-presubmit-tests-master

/test istio-unit-tests-master

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-unit-tests-master

prow/e2e_pilotv2_auth_sds.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio_auth_sds_e2e-master

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-master

prow/e2e-mixer-no_auth.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-mixer-no_auth-master

prow/e2e-simpleTests-cni.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-simpleTests-cni-master

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-framework-k8s-presubmit-tests-master

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-telemetry-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-galley-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test e2e-dashboard-master

prow/integ-security-k8s-presubmit-tests.sh
5038a6e6645bf8136acf9fceb9eb3b0b508aab0e
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-dashboard-master
/test integ-galley-k8s-presubmit-tests-master

/test integ-security-k8s-presubmit-tests-master


[BUG] global indicator legend switched

Describe the bug
The icons on the global indicators page legend have been switched.
The star should be (and is in the table) union concern species.
While triangle should be (and is in the table) species with observations
To Reproduce
Steps to reproduce the behavior:

Go to 'global indicators'
Click on 'legend'
See error

Expected behavior
The star should be (and is in the table) union concern species.
While triangle should be (and is in the table) species with observations
Screenshots

also, the colors seem to be missing

As discussed: color is green if management data available, otherwise black

However, I found out that union list data contains a special white space at the end of "Oxyura jamaicensis". Therefore the star button is missing.
I prefer to fix it in the data https://github.com/inbo/alien-species-portal/blob/sprint_v0.0.4/alienSpecies/inst/extdata/eu_concern_species.tsv#L38
Otherwise I will need to add an extra package dependency just for this single fix.
library(alienSpecies)
unionlistData <- loadTabularData(type = "unionlist")

trimws(unionlistData$scientificName)[37]
# [1] "Oxyura jamaicensis "

trimws(unionlistData$scientificName[37])
# [1] "Oxyura jamaicensis "

stringr::str_trim(unionlistData$scientificName[37])
# [1] "Oxyura jamaicensis"

in data fix is ok!
alopochen should be a union list species as well though

alopochen should be a union list species as well though

In the unionlist data it is spelled Alopochen aegyptiacus, while in the data it is Alopochen aegyptiaca. Another fix in the unionlist data?
@SanderDevisscher This gives me the impression we should best check the whole union list..

Half of the union list species is not present in the table. Do you see any abnormalities?
Browse[1]> nrow(unionlistData)
[1] 66
Browse[1]> unionlistData$scientificName[!unionlistData$scientificName %in% tableData$species]
 [1] "Alternanthera philoxeroides"      "Baccharis halimifolia"
 [3] "Gunnera tinctoria"                "Heracleum persicum"
 [5] "Heracleum sosnowskyi"             "Microstegium vimineum"
 [7] "Pennisetum setaceum"              "Persicaria perfoliata"
 [9] "Pueraria lobata"                  "Alopochen aegyptiacus"
[11] "Eriocheir sinensis"               "Herpestes javanicus"
[13] "Orconectes limosus"               "Orconectes virilis"
[15] "Oxyura jamaicensis "              "Percottus glenii"
[17] "Procambarus fallax f. virginalis" "Vespa velutina nigrithorax"
[19] "Humulus scandens"                 "Andropogon virginicus"
[21] "Arthurdendyus triangulatus"       "Cortaderia jubata"
[23] "Acacia saligna"                   "Gymnocoronis spilanthoides"
[25] "Triadica sebifera"                "Lepomis gibbosus"
[27] "Lespedeza cuneata"                "Lygodium japonicum"
[29] "Plotosus lineatus"                "Prosopis juliflora"
[31] "Salvinia molesta"                 "Ehrharta calycina"

Welcome to the miraculous world of taxonomy where nothing is what it seems and nothing stays the same 😅
Most of these scientificNames are synonyms of the accepted scientificname.
Do you get the same level of dropouts if you use the taxonkey (backbone_taxonKey) in the unionlist ?
Alopochen aegyptiacus & Lepomis gibbosus is an example which should be fixed by using the taxonKey.
While species like  Orconectes limosus will remain an issue since this is both a synonym in the textual sense as it is a synonym in the taxonomic sense of the accepted species Faxonius limosus.

Matching on the key works for 'Alopochen aegyptiaca' and 'Oxyura jamaicensis'.
It doesn't for 'Vespa velutina'
> exotenData$nubKey[exotenData$species == "Vespa velutina"]
[1] 1311477 1311477 1311477
> unionlistData[49, ]
               scientificName  englishName  kingdom taxonKey
1: Vespa velutina nigrithorax Asian hornet Animalia  6247411

Species on the union list that are currently not matching with any record in the table
> nrow(unionlistData)
[1] 89
> unionlistData$scientificName[!unionlistData$taxonKey %in% exotenData$nubKey]
 [1] "Alternanthera philoxeroides" "Baccharis halimifolia"
 [3] "Gunnera tinctoria"           "Heracleum persicum"
 [5] "Heracleum sosnowskyi"        "Microstegium vimineum"
 [7] "Pennisetum setaceum"         "Persicaria perfoliata"
 [9] "Pueraria lobata"             "Eriocheir sinensis"
[11] "Herpestes javanicus"         "Faxonius limosus"
[13] "Faxonius virilis"            "Percottus glenii"
[15] "Procambarus virginalis"      "Vespa velutina nigrithorax"
[17] "Humulus scandens"            "Andropogon virginicus"
[19] "Arthurdendyus triangulatus"  "Cardiospermum grandiflorum"
[21] "Cortaderia jubata"           "Acacia saligna"
[23] "Gymnocoronis spilanthoides"  "Triadica sebifera"
[25] "Lepomis gibbosus"            "Lespedeza cuneata"
[27] "Lygodium japonicum"          "Plotosus lineatus"
[29] "Prosopis juliflora"          "Salvinia molesta"
[31] "Ehrharta calycina"           "Ameiurus melas"
[33] "Axis axis"                   "Callosciurus finlaysonii"
[35] "Channa argus"                "Faxonius rusticus"
[37] "Fundulus heteroclitus"       "Gambusia affinis"
[39] "Gambusia holbrooki"          "Hakea sericea"
[41] "Koenigia polystachya"        "Lampropeltis getula"
[43] "Lampropeltis getula"         "Limnoperna fortunei"
[45] "Morone americana"            "Rugulopteryx okamurae"
[47] "Solenopsis geminata"         "Solenopsis invicta"
[49] "Solenopsis richteri"         "Wasmannia auropunctata"

did you use the new eu concern list ?

when using the taxonKey for Eriocheir sinensis from the new eu concern list (2225776) and filter the be_alientaxa_cube on this repo I get at least 1350 hits. Lepomis gibbosus yields similar results.
While species like Vespa velutina remains problematic. The currently used taxonKey on the unionlist (6247411) is the one of a subspecies Vespa velutina nigrithorax while the cube was build with the taxonKey of the species (1311477).
I'll add some logic to pull the eu_concern_list from Trias and fix this type of issues before uploading it to the bucket.

did you use the new eu concern list ?

With the latest eu concern list, all species are matched.
> unionlistData$scientificName[!unionlistData$taxonKey %in% exotenData$nubKey]
character(0)

also for Vespa velutina ?

No, still same list as reported here https://github.com/inbo/alien-species-portal/issues/57#issuecomment-1766159063
Wrt 'Eriocheir sinensis': It is in the data file 'data_input_checklist_indicators.tsv', but excluded because the first observation date is before 1950. All such records are excluded here in the code
Is this no longer as intendend?

I my opinion species introduced before 1950 should be included in all the lists but excluded or be a base load for cumulative  indicators.
does this make sense ?
@timadriaens what do you think?

I think that is a mistake as the indicators should show everything, e g. such as here? I suggest to ask @damianooldoni

what indicator is this about?

what indicator is this about?

all of them

I think for all of the checklist based indicators (pathways, origin, introduction rates) we do NOT need this filter. I suspect this filter comes from the occurrence-based indicator preprocessing and of course it remains relevant there.

Yes, we had the filtering while preprocessing occurrence based indicators, but not for checklist based ones.

The 1950 filter (https://github.com/inbo/alien-species-portal/blob/e48584677113aec2226283d63f837876d5ab8e3d/alienSpecies/R/data_load.R#L202) should be removed in case of the checklist indicators. But it can remain for the occurrence indicators (https://github.com/inbo/alien-species-portal/blob/e48584677113aec2226283d63f837876d5ab8e3d/alienSpecies/R/data_load.R#L303)

The crucial ones you mentioned are now recognized in the data.
These are the ones without a match still:
> unionlistData$scientificName[!unionlistData$taxonKey %in% exotenData$nubKey]
 [1] "Alternanthera philoxeroides" "Gunnera tinctoria"
 [3] "Heracleum persicum"          "Heracleum sosnowskyi"
 [5] "Microstegium vimineum"       "Pennisetum setaceum"
 [7] "Persicaria perfoliata"       "Pueraria lobata"
 [9] "Herpestes javanicus"         "Faxonius limosus"
[11] "Faxonius virilis"            "Percottus glenii"
[13] "Procambarus virginalis"      "Vespa velutina nigrithorax"
[15] "Humulus scandens"            "Andropogon virginicus"
[17] "Arthurdendyus triangulatus"  "Cardiospermum grandiflorum"
[19] "Cortaderia jubata"           "Acacia saligna"
[21] "Gymnocoronis spilanthoides"  "Triadica sebifera"
[23] "Lespedeza cuneata"           "Lygodium japonicum"
[25] "Plotosus lineatus"           "Prosopis juliflora"
[27] "Salvinia molesta"            "Ehrharta calycina"
[29] "Axis axis"                   "Callosciurus finlaysonii"
[31] "Channa argus"                "Faxonius rusticus"
[33] "Fundulus heteroclitus"       "Gambusia affinis"
[35] "Gambusia holbrooki"          "Hakea sericea"
[37] "Koenigia polystachya"        "Lampropeltis getula"
[39] "Lampropeltis getula"         "Limnoperna fortunei"
[41] "Morone americana"            "Rugulopteryx okamurae"
[43] "Solenopsis geminata"         "Solenopsis invicta"
[45] "Solenopsis richteri"         "Wasmannia auropunctata"

Maybe because these species do not occur on our territory. We should however have a few records of Lampropeltis getula and Salvinia molesta.

Most of these do not occur in Belgium but there are a few where matching problzms could have occurred, such as Salvinia molesta (could be under auriculata), procambarus virginalis (Procambarus fallax), Vespa velutina nigrithorax (Vespa velutina), Koenigia (Persicaria wallichii). However, i thought we solved this several times already for riparias and Prius @damianooldoni

Most of these do not occur in Belgium but there are a few where matching problzms could have occurred, such as Salvinia molesta (could be under auriculata), procambarus virginalis (Procambarus fallax), Vespa velutina nigrithorax (Vespa velutina), Koenigia (Persicaria wallichii). However, i thought we solved this several times already for riparias and Prius @damianooldoni

Salvinia molesta is on the checklist as Salvinia auriculata. I'll add a fix like I'll do for Vespa velutina (see https://github.com/inbo/aspbo/issues/26).
Persicaria wallichii & Koenigia polystachya are both missing from both checklist & occ. cube.
As are Procambarus virginalis & Procambarus fallax

Persicaria wallichii & Koenigia polystachya are both missing from both checklist & occ. cube. --> maybe it is under Polygonum polystachyum?
Axis axis en Perccottus (mind the two "c's" in the spelling!) glenii do not occur in Belgium indeed

Persicaria wallichii & Koenigia polystachya are both missing from both checklist & occ. cube. --> maybe it is under Polygonum polystachyum?

Polygonum polystachyum is also missing

Axis axis en Perccottus (mind the two "c's" in the spelling!) glenii do not occur in Belgium indeed

@damianooldoni is going to produce a new cube which should solve a number of these problems

Yes, as @timadriaens said I will start making a new cube today. Still, I want here first check the issues with the GRIIS checklist. I checked the very first taxa. Here my findings:

species
taxonKey (in GRIIS checklist)
GBIF backbone

Faxonius limosus
213214572
8909595

Koenigia polystachya
213214913
8848208

Lampropeltis getula
213212464
5224480

Procambarus virginalis
not present
9442269

Procambarus virginalis is not the GRIIS checklist because:

it's not in the waarnemingen.be list (only P. acutus and P. clarkii) AND
it's not in the Inventory of alien macroinvertebrates in Flanders, Belgium. Maybe is there a way to update this checklist? If so, @timadriaens, please take contact with authors and write an issue on the dedicated repository: https://github.com/trias-project/alien-macroinvertebrates

I mentioned these two datasets because both contain another mentioned crayfish: Faxonius limosus.
I think @SanderDevisscher is still using an old version of the GRIIS checklist? Of course the cube will be created on the new and most updated version of the GRIIS checklist. I will also update the indicators as next step.
@SanderDevisscher: within LIFE RIPARIAS project Tim and I published the Union Concern list on GBIF. So, maybe it's relevant to retrieve the information about such list directly from GBIF. This also allows you to automatize such step and get rid of csv's with such list spread among several repositories.

Indeed, the taxon on GRIIS Belgium should be Procambarus virginalis (9442269). It is normal since the taxonomy changed from P. fallax f. virginalis well after the checklist or macroinverts was published. Yet, is it then not better to include the original taxon (synonym, 8879526) in that source checklist?

Correction, it does not occur in this checklist of course as it was not yet present on the belgian territory then. But it should be in waarneminge.be checklist!

What species do you expect in the waarnemingen.be checklist?

Procambarus virginalis (9442269), on wnm.be

The species does occur on waarnemingen.be and is considered a species Procambarus virginalis : https://waarnemingen.be/species/561245/
For some reason, it didn't make it to the waarnemingen.be checklist however. Maybe because the rank changed from a form (not included in the checklist) to a species after the initial checklist was published. The only Procambarus that are included in the checklist are:

Procambarus clarkii
Procambarus acutus

Correction, it seems to be (incorrectly) considered a variety in waarnemingen.be, and a child of Procambarus fallax (https://waarnemingen.be/species/561244/) which is also not included in the checklist.

OK, so can we change that? It's a Union List species...

@mvarewyck do we currently use the entry_into_force date from the eu_concern_species.tsv?

This issue is waiting for updates of the GRIIS checklist & alien species cube to be solved.

@mvarewyck do we currently use the entry_into_force date from the eu_concern_species.tsv?

@SanderDevisscher No, we only read the following variables
"checklist_scientificName", "english_name", "checklist_kingdom", "backbone_taxonKey"

@timadriaens, concerning the missing "Procambarus virginalis" in the waarnemingen.be list: I have created an issue for that in data-publication-natuurpunt. The list will likely be updated in January 2024.


Unable to import lnd on Go 1.13

Background
Attempt to go get lnd using Go 1.13 fails with:
go get<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>invalid pseudo-version: revision is longer than canonical (284e2e0e696e)

Your environment

version of lnd: same behaviour for the last 4 releases.
which operating system (uname -a on *Nix): tested on MacOS, debian buster, and Alpine 3.8 through 3.10

A result of a minimal automated test case for multiple go/lnd combinations can be found here: https://github.com/meeDamian/go-get-lnd/commit/f931fd0425db481b0db4c1fc5917900b3c351000/checks
Steps to reproduce

Have go 1.13
Run

go get<EMAIL_ADDRESS>or
Add require github.com/lightningnetwork/lnd v0.7.1-beta to go.mod, and try to build

Expected behaviour
go get and go build complete successfully.
Actual behaviour
This: https://github.com/meeDamian/go-get-lnd/runs/222083871#step:3:71
Workaround
A temporary workaround I've found that works for me is adding the following to go.mod:
replace github.com/btcsuite/btcwallet => github.com/btcsuite/btcwallet v0.0.0-20190814023431-505acf51507f

Fixed by https://github.com/lightningnetwork/lnd/pull/3458.


Bootstrap Errors from Rust Clippy

Describe the bug
Running bootstrap.ps1 results in errors that prevent the simulators from being built properly. This appears to be related to a new release of rust clippy adding new warnings.
To Reproduce
Clone qsharp-runtime repo
Install listed pre-requisites and Powershell 7
Run boostrap.ps1
Expected behavior
boostrap runs without errors
Actual behavior
Errors from rust clippy (pasted below)
System information
OS: Windows
rustc/rust-clippy version: 1.55.0
Error messages
Compiling qdk_sim_experimental v0.0.1-alpha
Checking num_enum v0.5.4
error[E0658]: custom inner attributes are unstable
 --> src/lib.rs:4:4
  |
4 | #![clippy::allow(needless_borrow)] // because of strange rust clippy error
  |    ^^^^^^^^^^^^^
  |
  = note: see issue #54726 <https://github.com/rust-lang/rust/issues/54726> for more information

error: usage of unknown attribute
 --> src/lib.rs:4:12
  |
4 | #![clippy::allow(needless_borrow)] // because of strange rust clippy error
  |            ^^^^^

For more information about this error, try `rustc --explain E0658`.
error: could not compile `qdk_sim_experimental` due to 2 previous errors

...
Compiling qdk_sim_experimental v0.0.1-alpha
...

error[E0658]: custom inner attributes are unstable
 --> src/lib.rs:4:4
  |
4 | #![clippy::allow(needless_borrow)] // because of strange rust clippy error
  |    ^^^^^^^^^^^^^
  |
  = note: see issue #54726 <https://github.com/rust-lang/rust/issues/54726> for more information
  = help: add `#![feature(custom_inner_attributes)]` to the crate attributes
to enable

For more information about this error, try `rustc --explain E0658`.
error: could not compile `qdk_sim_experimental` due to previous error

...
Compiling qdk_sim_experimental v0.0.1-alpha
Documenting qdk_sim_experimental v0.0.1-alpha
...

warning: lint `missing_doc_code_examples` has been renamed to `rustdoc::missing_doc_code_examples`
  --> src/lib.rs:22:23
   |
22 | #![cfg_attr(doc, warn(missing_doc_code_examples))]
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name:
`rustdoc::missing_doc_code_examples`
   |
   = note: `#[warn(renamed_and_removed_lints)]` on by default

error[E0658]: custom inner attributes are unstable
 --> src/lib.rs:4:4
  |
4 | #![clippy::allow(needless_borrow)] // because of strange rust clippy error
  |    ^^^^^^^^^^^^^
  |
  = note: see issue #54726 <https://github.com/rust-lang/rust/issues/54726> for more information
  = help: add `#![feature(custom_inner_attributes)]` to the crate attributes
to enable

error: Compilation failed, aborting rustdoc

For more information about this error, try `rustc --explain E0658`.
warning: `qdk_sim_experimental` (lib doc) generated 1 warning
error: could not document `qdk_sim_experimental`

Thanks for filing this, @ryan-moreno! It looks like cargo clippy recently added a few new checks, but our build has clippy warnings promoted to errors by default. Thankfully, the six new linting issues are pretty straightforward to resolve, so let me go do that. Thanks!


move uart to uart1 pin 26,27

re-using 0/1 would mean the debug header is cross-connected to gpio14/15, and then they could conflict at the electrical level
oh, but maybe avoid uart0 then
if you avoid uart0, then you can drive both uart's at once

but now that ive delt with the pico-sdk stdio stuff, i can see how i could easily move things to uart1
so this is a lower priority


Fix Issue of Incorrect Statistics

This pull request will fix the issue of incorrect statistics being displayed by the page views and visitors metrics cards. The Month (to date) option will now compare the current month to date with the previous month. The Year (to date) option will now compare the current year to date with the previous year. Closes #19

@mattstauffer -- This is ready for re-review. The change needed was the Carbon time period declarations.


RHIROS-747 disable pagination when no systems

Codecov Report
Base: 22.84% // Head: 22.84% // No change to project coverage :thumbsup:

Coverage data is based on head (77d3ab5) compared to base (644697a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   22.84%   22.84%
=======================================
  Files          48       48
  Lines         915      915
  Branches      166      166
=======================================
  Hits          209      209
  Misses        660      660
  Partials       46       46

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add option to toggle off boss bar

Boss bar interfers with Hwyla interface and it doesnt make any sense if you want to have an entity health view mod in the first place

It would be awesome if it could be disabled.

Done! Thank you for the suggestion!


Add datareader.size

Depends on PR: https://github.com/ecmwf/fdb/pull/50
Add size to datareader. This allows nice things like:
    dh = fdb1.retrieve(request)
    blob = dh.read() # no argument now reads whole handle.
    fdb2.archive(blob)
    fdb2.flush()

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.77%. Comparing base (0d6c2a4) to head (48af9a8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #37   +/-   ##
========================================
  Coverage    94.77%   94.77%
========================================
  Files            3        3
  Lines          134      134
========================================
  Hits           127      127
  Misses           7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


TRG 4.06 separate notice file for DockerHub has all necessary information

In the frontend repository replace the docker notice section in your readme with a reference to the docker notice file. Currently it is a duplicate.

fixed in https://github.com/eclipse-tractusx/managed-simple-data-exchanger-frontend/pull/123


Temporary failure in name resolution

Proxy giving this error
502 Bad Gateway
ProtocolException('Server connection to ('www.oraculous.in', 80) failed: Error connecting to "www.oraculous.in": [Errno -3] Temporary failure in name resolution',)

mitmproxy version is 4.0
operating mode or command was mitmdump -p 8080
i installed python 3.6 and then mitmproxy on ubuntu 18.04

The error message states that mitmproxy cannot resolve the IP address of www.oraculous.in. That's not a mitmproxy issue, that's a problem with your internet connectivity (or with www.oraculous.in being unavailable in general).

See also: #3203


Identify why fetch-mock 9.10.2 breaks download-log test

Expected Behaviour
Tests should pass with fetch-mock 9.10.2
Actual Behaviour
They fail -- the call to pipelineStream never finishes
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version
Sample Code that illustrates the problem
Logs taken while reproducing problem

no longer occurs


jj: would be interesting to create an archived revset

Maybe based on description? interesting would explicitly exclude it so jjx is clean.

I guess jj reword @ -m "$(jj list -r @ -T '"(jj archive) " ++ description.remove_prefix("(jj archive)").remove_prefix(" ")')" works but it's a mouthful.

With 717cb04b81f40bb9b7a68a1cee2476dbe77b08a2, this is "just"
jj list -r @ -T 'change_id ++ "\n" ++ archived' | { read r && jj reword $r --stdin }
jj list -r @ -T 'change_id ++ "\n" ++ unarchived' | { read r && jj reword $r --stdin }
for archiving and unarchiving respectively.

Better with e70df0ad1c58ea9fc831a722b70d43da2efc14c7 --
jj archived @ | { read r && jj reword $r --stdin }
jj unarchived @ | { read r && jj reword $r --stdin }


no variant or associated item named TrayCenter found for enum tauri_plugin_positioner::Position in the current scope

I am trying to center a tauri app to the tray icon. Someone suggested i use the tauri-plugin-positioner plugin, and it does seem like a good solution.
I have followed the instructions on the readme file to use it with just rust, but when i run npm run tauri dev i get the following error

If i use let _ = win.move_window(Position::TopCenter); or let _ = win.move_window(Position::TopRight); they all work without problems. But when i use one of the Tray... positions (like Position::TrayCenter) then i get the error.
This is my main.rs
#![cfg_attr(
    all(not(debug_assertions), target_os = "windows"),
    windows_subsystem = "windows"
)]

use tauri::{CustomMenuItem, SystemTray, SystemTrayMenu, SystemTrayMenuItem, SystemTrayEvent};
use tauri::Manager;
use tauri_plugin_positioner::{WindowExt, Position};

fn main() {
    let quit = CustomMenuItem::new("quit".to_string(), "Quit");
    let hide = CustomMenuItem::new("hide".to_string(), "Hide");

    let tray_menu = SystemTrayMenu::new()
        .add_item(quit)
        .add_native_item(SystemTrayMenuItem::Separator)
        .add_item(hide);
    let tray = SystemTray::new().with_menu(tray_menu);

    tauri::Builder::default()
        .setup(|app| {
            let win = app.get_window("main").unwrap();
            let _ = win.move_window(Position::TrayCenter);
            Ok(())
        })
        .system_tray(tray)
        .on_system_tray_event(|app, event| match event {
            SystemTrayEvent::LeftClick {
                position: _,
                size: _,
                ..
            } => {
                println!("system tray received left click");
            }
            SystemTrayEvent::RightClick {
                position: _,
                size: _,
                ..
            } => {
                println!("system tray received right click")
            }
            SystemTrayEvent::MenuItemClick { id, .. } => {
                let item_handle = app.tray_handle().get_item(&id);
                match id.as_str() {
                    "quit" => {
                        std::process::exit(0);
                    }
                    "hide" => {
                        println!("Clicked the test menu item");
                    }
                    _ => {}
                }
            }
            _ => {}
        })
        .run(tauri::generate_context!())
        .expect("error while running tauri application");
}

Not sure if this is important, but this is the output of npm run tauri info
Environment
  › OS: Mac OS 12.4.0 X64
  › Node.js: 16.14.0
  › npm: 8.3.1
  › pnpm: Not installed!
  › yarn: Not installed!
  › rustup: 1.25.1
  › rustc: 1.64.0
  › cargo: 1.64.0
  › Rust toolchain: stable-aarch64-apple-darwin

Packages
  › @tauri-apps/cli [NPM]: 1.1.1
  › @tauri-apps/api [NPM]: Not installed!
  › tauri [RUST]: 1.1.1,
  › tauri-build [RUST]: 1.1.1,
  › tao [RUST]: 0.14.0,
  › wry [RUST]: 0.21.1,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:5173/

App directory structure
  ├─ types
  ├─ dist
  ├─ node_modules
  ├─ public
  ├─ src-tauri
  └─ src

This is my first time working with Rust, so i am sorry if this is a problem on how i am doing it, instead of a problem with the library. But maybe better safe than sorry...

Tray-relative positions are gated behind a feature flag as their implementation isn't optimal yet.
Just change this line from the docs:
[dependencies]
tauri-plugin-positioner = "1.0"

To this:
[dependencies]
tauri-plugin-positioner = { version = "1.0", features = ["system-tray"] }

And everything should work as expected.
This should be clearer in the Readme I agree with you, will fix that asap.

@JonasKruckenberg Thank you for your quick answer!
Having it behind a flag seems like a good idea.
Unfortunately, when i make the change you suggested i then get the following error:
thread 'main' panicked at 'state() called before manage() for given type', /Users/myName/.cargo/registry/src/github.com-1ecc6299db9ec823/tauri-1.1.1/src/lib.rs:749:8

Ahh yes, there was another reason why system-tray position is not enabled by default. Due to a limitation in Tauri, you currently have to do this (snippet from the example app):
https://github.com/JonasKruckenberg/tauri-plugin-positioner/blob/main/examples/svelte-app/src-tauri/src/main.rs#L36-L37
This should be documented too ofc.

Ah, ok, thank you.
I have tried it, and it seems to kind of work.
The problem is, than when i must click twice on TrayCenter before it gets the correct position.
After the 1st click it gets kind of "top centered on the page". And on the 2nd TrayCenter item click it gets the correct position.
So, there isn't really an option to set the position when the app starts, just on events?