Exceptionless v2 only sends a single notification of an error; can you send a digest or similar for repeated errors?

With the v2 release, a change has been made to email notifications. We no longer receive an email notification for each error. As I understand it, now we will only receive an email any time a new event occurs / is critical / is a regression. (I think the intent was to reduce the volume of emails from Exceptionless, and also so that "when you see an email alert it means something".) Also, it's now my understanding that a specific error will only have a single instance of "regression"; if it has been marked as fixed/closed and then occurs again, it will be re-opened and this will be a one-time regression. [The definition of a regression in Exceptionless has not changed; only my understanding of the details.
I understand the reason for this change, and that some users would find this useful. However, for our organization, we don't typically see a large volume of errors and we like to be notified of each instance. Sometimes, the same error repeats because we haven't had time to fix it yet, or sometimes it's a new circumstance that causes the same error (that we thought we had fixed in code, but not yet marked as fixed in Exceptionless).
Perhaps, to avoid sending thousands of notifications, perhaps you could consider sending a "digest" notification if there are more than a certain number of errors requiring notification in some time period (5 minutes, 30 minutes?). That is, do something like track the timestamp of the most recent notification sent to a user; and if any notification is required again - if it's more than 5/30 minutes (or some other interval) since the last message, send it as a new message, but if it's less than 5/30 minutes, wait until 5/30 minutes and send a summary/count of notifications to the user with a link to view all the errors.
Note that sometimes the volume/frequency of a specific error is a very useful indicator of a more serious problem (such as a failure in a database table, or a problem with an external web service used by the application), and receiving only a single notification for a new error that's occurring multiple times may mask that situation.

Alternatively, perhaps you could allow a project to be marked as "all errors for this project will be considered critical"; and then we would receive a notification for every error in that project. I know that, after an error is logged, you can set an option on that error to identify all future occurrences of the error as critical; I'm suggesting allowing that to be set as the default for all errors in a project.

One of the things you could do is use the bulk actions to mark a stack as critical but that doesn't seem like a good solution at all (not addressing the problem, just putting a bandaid on it).  We already do deduping and rate limiting on emails. The issue with sending one with each occurrence is if you got bunch emails in a short window of time from the same occurrence then a new actual critical occurrence wouldn't get an email notification.

The thing is would you read a digest email? It seems like it would be nice to send an email anytime a large amount of errors come in (lets say you average 5 an hour, and then all of a sudden you get 15), that would trigger an email. That might take a large amount of work to detect that (but would be cool to have)..
On a side note, It might be nice to have a plugin that runs server side that automatically marks timeout and connection related exceptions as critical.
@ejsmith  thoughts

Yeah, it would be nice. I'm sure we could figure out a rate per stack, but to keep that rate for every single stack over time would be interesting. Guess we would have to store it in redis short term and occasionally persist it to ES.

You might be able to cheat a bit with something like this:
(Total Occurrences / (Now - FirstOccurrence).TotalHours) > StackCountForLastHourInRedis

Alternatively, would you consider adding a new option to notifications - to allow notification for all errors (similar to the way that v1 worked)? [You can add warnings or similar if a user selects this option to inform the user that this may result in a large volume of email.]

I'll bring this up with the team for discussion.

There is more to this than just volume of email. It's a huge load on the system and costs us money as well. I think what we need to do is allow instance level notifications, but do it intelligently where we throttle them.

Thanks for the added explanation of system load and costs. I realize my use case is probably unusual (an exception, if you will), and that you are designing the system for the majority of your users, especially those with a large volume of projects and web applications with millions of daily users.
I'll give this some more thought and let you know if I have any other suggestions.

I think a good compromise would be to send a followup at an interval for a specific stack after it happens. Like you'll get notified 5, 30 and 60 minutes after a new occurrence. If you get an email on every occurrence/summary on a stack a week after it happened it's just noise.

@KasperLK commented on Apr 9, 2015
Time when the daily project summary should be send
Quiet hours
Quiet days (weekend)
It should also be possible to configure the above on organization level, with option to overwrite on selected projects.
Option to get a daily summary on organization level instead for one mail per project.

I'm closing this as it's now merged into 177.


Implementing React Hook Form

There are multiple states created in Register and Login files which cause multiple lines of code and validation, but react hook resolves all the issues related to frontend validation and the extraction of date from fields. And on other pages that have forms
Please Assign this task to me, and also label it as gssoc-ext
@gauravsingh1281

Please assign this to me
@gauravsingh1281

Please assign this to me @gauravsingh1281

Hey there!
Just for confirmation before raising pr is there any particular backend route to send request to

@gauravsingh1281 I have raised a PR all the tests are done from my side, please merge


Add TV Episode Data and Images

Fixes #59
Changes

Added TV episode data and image URL fetching to the project.
Added image vote average and count metadata.

Notes

Episode images were tested by hand in a client app using my fork
Everything had unit tests added and pass.

@joeljfischer Thanks for your PR. Can you fix the linting issues?

@adamayoung Done!

Done and done


Use PSI for running Kubernetes tests

Kubernetes tests that were earlier working on Travis need to run on PSI infrastructure.
Acceptance Critera

[ ] Kubernetes test results for every PR

Scope of the issue
https://github.com/openshift/odo/issues/4287#issuecomment-752359444
https://github.com/openshift/odo/issues/4287#issuecomment-754408501
/area testing
/priority high
/assign @mohammedzee1000

@prietyc123 @kadel please add any more acceptance critera or detail to the issue that I might have missed.

@prietyc123 is going to try the following steps manually:

Create openstack vm
Install minishift on it
Run some tests

Once we have manually achieved this, it is trivial to script it out
Also, will need to give robot account access to openstack for automation purposes

Create openstack vm

can we configure Jenkins to do this for us?

Create openstack vm

can we configure Jenkins to do this for us?

That would be the final goal, a script in jenkins

So the scope of this issue will be:

[ ] Get our internal Jenkins robot account access to our internal PSI project
[ ] Create a script that

Provisions a VM on PSI.
ssh into that machine, and provision minikube VM using podman (preferable) using https://minikube.sigs.k8s.io/docs/drivers/podman/  or docker if unavoidable using  https://minikube.sigs.k8s.io/docs/drivers/docker/
Run the tests against said cluster
Demolish the cluster and the machine

[ ] Create a jenkins project, a message queue and prow job for running this per PR

@prietyc123 is going to try the following steps manually:

Create openstack vm

I was able to successfully install openstack client. Followed doc - https://docs.openstack.org/mitaka/cli-reference/common/cli_install_openstack_command_line_clients.html
Tried creating fedora vm using CLI command
$ openstack server create --flavor m1.large --image Fedora-Cloud-Base-32 --nic net-id=provider_net_shared_2 --security-group default --security-group all-open --key-name releng-key fedora-minikube

But it is throwing error
Build of instance d35a70de-45b7-4cf9-aca8-c7f5688eaff4 aborted: Failed to allocate the network(s) with error No fixed IP addresses available for network: 14c15d33-175c-424e-88ba-361a875e0c5c, not rescheduling

I am trying to find out the root cause of the failure.

@prietyc123 is going to try the following steps manually:

Create openstack vm

I was able to successfully install openstack client. Followed doc - https://docs.openstack.org/mitaka/cli-reference/common/cli_install_openstack_command_line_clients.html
Tried creating fedora vm using CLI command
$ openstack server create --flavor m1.large --image Fedora-Cloud-Base-32 --nic net-id=provider_net_shared_2 --security-group default --security-group all-open --key-name releng-key fedora-minikube

But it is throwing error
Build of instance d35a70de-45b7-4cf9-aca8-c7f5688eaff4 aborted: Failed to allocate the network(s) with error No fixed IP addresses available for network: 14c15d33-175c-424e-88ba-361a875e0c5c, not rescheduling

I am trying to find out the root cause of the failure.

It says it right there. No more IPs. can you try a different network like _3 instead of _2

Scope of the issue mentioned in https://github.com/openshift/odo/issues/4287#issuecomment-752359444 also includes manual verification of scenarios like

[ ] Provisions VM on OpenStack with ssh key login
[ ] Install minikube inside the created VM
[ ] Run tests manually

Scope of the issue mentioned in https://github.com/openshift/odo/issues/4287#issuecomment-752359444 also includes manual verification of scenarios like

[ ] Provisions VM on OpenStack with ssh key login
[ ] Install minikube inside the created VM
[ ] Run tests manually

Provisions VM on OpenStack with ssh key login

Created fedora 32 VM on openstack
$ openstack server create --flavor m1.large --image Fedora-Cloud-Base-32 --nic net-id=provider_net_shared_3 --security-group default --security-group all-open --key-name releng-key fedora-minikube-none

$ ssh fedora@<ip>

Install minikube inside the created VM

Installing minikube using none driver inside fedora 32 VM with pre-req docker container environment. As fedora 32 doesn't support docker, we need to revert back to v1 cgroups. Steps to revert to v1 cgroups:
$ sudo -i
$ dnf install grubby
$ grubby --update-kernel=ALL --args="systemd.unified_cgroup_hierarchy=0"
$ systemctl reboot
$ ssh fedora@<ip>
$ sudo -i

Docker installation
Install docker as per doc https://docs.docker.com/engine/install/fedora/
$ docker version
Client: Docker Engine - Community
 Version:           19.03.13
 API version:       1.40
 Go version:        go1.13.15
 Git commit:        4484c46d9d
 Built:             Wed Sep 16 17:03:54 2020
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.13
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       4484c46d9d
  Built:            Wed Sep 16 17:01:49 2020
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.4.3
  GitCommit:        269548fa27e0089a8b8278fc4fc781d7f65a939b
 runc:
  Version:          1.0.0-rc92
  GitCommit:        ff819c7e9184c13b7c2607fe6c30ae19403a7aff
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

Minikube installation using bare metal
$ curl -Lo minikube https://storage.googleapis.com/minikube/releases/v1.11.0/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/

$ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.16.1/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin/

// Kubernetes 1.18.3 requires conntrack to be installed
$ yum install -y conntrack

// Close selinux
$ setenforce 0

// Enable kubelet services
$ systemctl enable kubelet.service

// To fix https://github.com/kubernetes/minikube/issues/6391 while starting minikube
$ sysctl fs.protected_regular=0

// start minikube
$ minikube start --vm-driver=none --container-runtime=docker

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T17:01:15Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:43:34Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

$ kubectl cluster-info
Kubernetes master is running at https://<IP_ADDRESS>:8443
KubeDNS is running at https://<IP_ADDRESS>:8443/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.

Will try to run the test manually and then automate the whole process.

Provisions VM on OpenStack with ssh key login

Created fedora 32 VM on openstack
$ openstack server create --flavor m1.large --image Fedora-Cloud-Base-32 --nic net-id=provider_net_shared_3 --security-group default --security-group all-open --key-name releng-key fedora-minikube-none

$ ssh fedora@<ip>

Install minikube inside the created VM

Installing minikube using none driver inside fedora 32 VM with pre-req docker container environment. As fedora 32 doesn't support docker, we need to revert back to v1 cgroups. Steps to revert to v1 cgroups:
$ sudo -i
$ dnf install grubby
$ grubby --update-kernel=ALL --args="systemd.unified_cgroup_hierarchy=0"
$ systemctl reboot
$ ssh fedora@<ip>
$ sudo -i

Docker installation
Install docker as per doc https://docs.docker.com/engine/install/fedora/
$ docker version
Client: Docker Engine - Community
 Version:           19.03.13
 API version:       1.40
 Go version:        go1.13.15
 Git commit:        4484c46d9d
 Built:             Wed Sep 16 17:03:54 2020
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.13
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       4484c46d9d
  Built:            Wed Sep 16 17:01:49 2020
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.4.3
  GitCommit:        269548fa27e0089a8b8278fc4fc781d7f65a939b
 runc:
  Version:          1.0.0-rc92
  GitCommit:        ff819c7e9184c13b7c2607fe6c30ae19403a7aff
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

Minikube installation using bare metal
$ curl -Lo minikube https://storage.googleapis.com/minikube/releases/v1.11.0/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/

$ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.16.1/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin/

// Kubernetes 1.18.3 requires conntrack to be installed
$ yum install -y conntrack

// Close selinux
$ setenforce 0

// Enable kubelet services
$ systemctl enable kubelet.service

// To fix https://github.com/kubernetes/minikube/issues/6391 while starting minikube
$ sysctl fs.protected_regular=0

// start minikube
$ minikube start --vm-driver=none --container-runtime=docker

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T17:01:15Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:43:34Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

$ kubectl cluster-info
Kubernetes master is running at https://<IP_ADDRESS>:8443
KubeDNS is running at https://<IP_ADDRESS>:8443/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.

Will try to run the test manually and then automate the whole process.

@prietyc123 I think its better to use systemctl enable --now kubelet.service to ensure service starts, if its not started for any reason. Other that that, I can second this

@prietyc123 I think its better to use systemctl enable --now kubelet.service to ensure service starts, if its not started for any reason. Other that that, I can second this

$ dnf install grubby
$ grubby --update-kernel=ALL --args="systemd.unified_cgroup_hierarchy=0"
$ systemctl reboot
$ ssh fedora@

To avoid whole grubby installation we can use Fedora 30 openstack vm.

$ dnf install grubby
$ grubby --update-kernel=ALL --args="systemd.unified_cgroup_hierarchy=0"
$ systemctl reboot
$ ssh fedora@

To avoid whole grubby installation we can use Fedora 30 openstack vm.

To avoid whole grubby installation we can use Fedora 30 openstack vm.

It's EOL (https://fedoraproject.org/wiki/End_of_life). We should avoid using EOL tooling, IMO.

To avoid whole grubby installation we can use Fedora 30 openstack vm.

It's EOL (https://fedoraproject.org/wiki/End_of_life). We should avoid using EOL tooling, IMO.

I will be handling the one time set up and @prietyc123 will handle every run piece. This will also give @prietyc123 experience with how to work with our jenkins and how the entire system works

I will be handling the one time set up and @prietyc123 will handle every run piece. This will also give @prietyc123 experience with how to work with our jenkins and how the entire system works

We are facing issue on psi minikube https://github.com/openshift/odo/issues/4383

We are facing issue on psi minikube https://github.com/openshift/odo/issues/4383

Blocked due to https://github.com/openshift/odo/issues/4383 , However I will try to analyse and get more info on failures.

Blocked due to https://github.com/openshift/odo/issues/4383 , However I will try to analyse and get more info on failures.

Steps I verified once we have the customised image created the VM:
#!/bin/sh

# fail if some commands fails
set -e
# show commands
set -x

sudo -i
git clone https://github.com/openshift/odo.git openshift/odo
cd openshift/odo
export GOPATH=$HOME/go
mkdir -p $GOPATH/bin
make goget-ginkgo
export PATH="$PATH:$(pwd):$GOPATH/bin"
minikube delete
minikube start --vm-driver=none --container-runtime=docker
set +x
kubectl cluster-info
set -x
make bin
cp odo /usr/bin
export KUBERNETES=true
make test-cmd-project
make test-integration-devfile

It works as expected.

Steps I verified once we have the customised image created the VM:
#!/bin/sh

# fail if some commands fails
set -e
# show commands
set -x

sudo -i
git clone https://github.com/openshift/odo.git openshift/odo
cd openshift/odo
export GOPATH=$HOME/go
mkdir -p $GOPATH/bin
make goget-ginkgo
export PATH="$PATH:$(pwd):$GOPATH/bin"
minikube delete
minikube start --vm-driver=none --container-runtime=docker
set +x
kubectl cluster-info
set -x
make bin
cp odo /usr/bin
export KUBERNETES=true
make test-cmd-project
make test-integration-devfile

It works as expected.

Issues we are facing while minikube implementation on jenkins:

Connection timeout while ssh into the vm
Although PSI Fedora vm are in running state, I think few configurations are not fully setup. For temporary solution we are adding 20 sec sleep into the configuration script. For long run solution we are planning to add a loop for ssh timeout into ci-firewall repo.

minikube start with none driver needs root permission access on jenkins
As minikube start with none driver needs root user access, we are using docker driver instead of none

One of the issue has been fixed by pr #4436

Hitting file permission issue on kubernetes job https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4512/pu[…]-master-psi-kubernetes-integration-e2e/1371511255918972928

It has been closed accidently via https://github.com/openshift/odo/pull/4516

Successful job run is blocked on https://github.com/openshift/odo/issues/4523 . However we have a debug pr https://github.com/openshift/odo/pull/4538 opened as a work around.

Most frequently ran into issue https://github.com/openshift/odo/issues/4548 on PSI jobs 🙁 Also I suspect the customised image fedora-minikube-bootstrapper-v1 is broken, as it complains about minikube command not found. I guess we need to create new customised image and check the behaviour of the pr.

There is one test related issue on kubernetes https://github.com/openshift/odo/issues/4577 working on this one.

We are getting false logs for PSI jobs on PRs everytime. For ex https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4578/pull-ci-openshift-odo-master-psi-kubernetes-integration-e2e/1377582757776986112#1:build-log.txt%3A32 I don't see any jobs running for build no. 990 🙁
I think there is something wrong on jenkins front, that we need to look into.

kubernetes jobs fails on
[ssh:Fedora 32] Running odo with args [odo create nodejs --context /tmp/119184934 --project default eluphj]
[...]

[ssh:Fedora 32] Running odo with args [odo push --context /tmp/119184934]

[ssh:Fedora 32] [odo] I0412 06:10:07.006222   42480 context.go:130] absolute devfile path: '/tmp/119184934/devfile.yaml'

[ssh:Fedora 32] [odo] I0412 06:10:07.006262   42480 context.go:72] absolute devfile path: '/tmp/119184934/devfile.yaml'

[ssh:Fedora 32] [odo] I0412 06:10:07.006340   42480 util.go:727] HTTPGetRequest: https://raw.githubusercontent.com/openshift/odo/master/build/VERSION

[ssh:Fedora 32] [odo] I0412 06:10:07.006449   42480 util.go:748] Response will be cached in /tmp/odohttpcache for 1h0m0s
[...]
[ssh:Fedora 32] [odo] I0412 06:10:07.045597   42480 preference.go:235] The path for preference file is /tmp/119184934/preference.yaml

[ssh:Fedora 32] [odo] I0412 06:10:07.048336   42480 utils.go:60] Deployment eluphj not found

[ssh:Fedora 32] [odo]

[ssh:Fedora 32] [odo] Validation

[ssh:Fedora 32] [odo]  ���  Validating the devfile  ...

[ssh:Fedora 32] [odo] I0412 06:10:07.048400   42480 command.go:171] Build command: devbuild

[ssh:Fedora 32] [odo] I0412 06:10:07.048411   42480 command.go:178] Run command: devrun

[ssh:Fedora 32] [odo]
[...]
���  Validating the devfile [47939ns]

[ssh:Fedora 32] [odo]

[ssh:Fedora 32] [odo] Creating Kubernetes resources for component eluphj

[ssh:Fedora 32] [odo] I0412 06:10:07.048436   42480 preference.go:235] The path for preference file is /tmp/119184934/preference.yaml

[ssh:Fedora 32] [odo] I0412 06:10:07.063247   42480 command.go:92] the command group of kind "debug" is not found in the devfile

[ssh:Fedora 32] [odo] I0412 06:10:07.063284   42480 utils.go:223] Updating container runtime entrypoint with supervisord

[ssh:Fedora 32] [odo] I0412 06:10:07.063298   42480 utils.go:118] Updating container runtime with supervisord volume mounts

[ssh:Fedora 32] [odo] I0412 06:10:07.063311   42480 utils.go:128] Updating container runtime env with run command

[ssh:Fedora 32] [odo] I0412 06:10:07.063327   42480 utils.go:145] Updating container runtime env with run command's workdir

[ssh:Fedora 32] [odo] I0412 06:10:07.065571   42480 adapter.go:475] Creating deployment eluphj

[ssh:Fedora 32] [odo] I0412 06:10:07.065595   42480 adapter.go:476] The component name is eluphj

[ssh:Fedora 32] [odo]  ���  Failed to start component with name eluphj. Error: Failed to create the component: unable to create or update component: unable to create Deployment eluphj: the namespace of the provided object does not match the namespace sent on the request

I tested the same scenario locally with the same minikube version that psi has:
$ minikube version
minikube version: v1.12.3
$ kubectl create namespace test2
namespace/test2 created
$ kubectl config set-context --current --namespace test2
Context "minikube" modified.
$ odo create nodejs --context testdis/ --project default efghij
Devfile Object Validation
 ✓  Checking devfile existence [66436ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [51430ns]
Validation
 ✓  Validating if devfile name is correct [50194ns]

Please use `odo push` command to create the component with source deployed
$ odo push --context testdis/

Validation
 ✓  Validating the devfile [589245ns]

Creating Kubernetes resources for component efghij
 ✓  Waiting for component to start [4m]
 ✓  Waiting for component to start [66ms]
 ⚠  Unable to create ingress, missing host information for Endpoint 3000-tcp, please check instructions on URL creation (refer `odo url create --help`)

Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.
[...]

Pushing devfile component efghij
 ✓  Changes successfully pushed to component

Ran test as well:
$ ginkgo tests/integration/devfile/
Running Suite: Devfile Suite
============================
Random Seed:<PHONE_NUMBER>
Will run 1 of 208 specs

SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
• [SLOW TEST:28.746 seconds]
odo devfile push command tests
/Users/pkumari/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:20
  Testing Push for Kubernetes specific scenarios
  /Users/pkumari/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:1127
    should push successfully project value is default
    /Users/pkumari/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:1134
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
JUnit report was created: /Users/pkumari/go/src/github.com/openshift/odo/tests/reports/junit_2021-4-12_14-29-35_1.xml

Ran 1 of 208 Specs in 28.788 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 207 Skipped
PASS | FOCUSED

Ginkgo ran 1 suite in 51.763187378s
Test Suite Passed

[odo create nodejs --context /tmp/119184934 --project default eluphj]
[...]
odo push
[...]
[ssh:Fedora 32] [odo]  ���  Failed to start component with name eluphj. Error: Failed to create the component: unable to create or update component: unable to create Deployment eluphj: the namespace of the provided object does not match the namespace sent on the request

@kadel @mik-dass I am confused if we are passing project as default, how odo push fails on namespace mismatch 🙁 . However the same test passes locally. Could you please share your thoughts on this.

$ minikube version
minikube version: v1.12.3
$ kubectl create namespace test2
namespace/test2 created
$ kubectl config set-context --current --namespace test2
Context "minikube" modified.
$ odo create nodejs --context testdis/ --project default efghij
Devfile Object Validation
 ✓  Checking devfile existence [66436ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [51430ns]
Validation
 ✓  Validating if devfile name is correct [50194ns]

Please use `odo push` command to create the component with source deployed
$ odo push --context testdis/

Validation
 ✓  Validating the devfile [589245ns]

Creating Kubernetes resources for component efghij
 ✓  Waiting for component to start [4m]
 ✓  Waiting for component to start [66ms]
 ⚠  Unable to create ingress, missing host information for Endpoint 3000-tcp, please check instructions on URL creation (refer `odo url create --help`)

Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.
[...]

Pushing devfile component efghij
 ✓  Changes successfully pushed to component

Ran test as well:
$ ginkgo tests/integration/devfile/
Running Suite: Devfile Suite
============================
Random Seed:<PHONE_NUMBER>
Will run 1 of 208 specs

SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
• [SLOW TEST:28.746 seconds]
odo devfile push command tests
/Users/pkumari/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:20
  Testing Push for Kubernetes specific scenarios
  /Users/pkumari/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:1127
    should push successfully project value is default
    /Users/pkumari/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:1134
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
JUnit report was created: /Users/pkumari/go/src/github.com/openshift/odo/tests/reports/junit_2021-4-12_14-29-35_1.xml

Ran 1 of 208 Specs in 28.788 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 207 Skipped
PASS | FOCUSED

Ginkgo ran 1 suite in 51.763187378s
Test Suite Passed

@kadel @mik-dass I tried the entire step manually on PSI and its failing. Not only the tests but also manually code executions are failing.
$ odo create nodejs --context testpsi/ --project default abcdef
? Help odo improve by allowing it to collect usage data. Read about our privacy statement: https://developers.redhat.com/article/tool-data-collection. You can change your preference later by changing the ConsentTelemetry preference. Yes
Devfile Object Validation
 ✓  Checking devfile existence [46493ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [22473ns]
Validation
 ✓  Validating if devfile name is correct [25464ns]

Please use `odo push` command to create the component with source deployed

$ odo push --context testpsi/

Validation
 ✓  Validating the devfile [149860ns]

Creating Kubernetes resources for component abcdef
 ✗  Failed to start component with name abcdef. Error: Failed to create the component: unable to create or update component: unable to create Deployment abcdef: the namespace of the provided object does not match the namespace sent on the request

Blocked on issue https://github.com/openshift/odo/issues/4609

@kadel @mik-dass I tried the entire step manually on PSI and its failing. Not only the tests but also manually code executions are failing.

Is it possible that something is misconfigured on PSI minikube instance if this is passing everywhere else?

@kadel @mik-dass I tried the entire step manually on PSI and its failing. Not only the tests but also manually code executions are failing.

Is it possible that something is misconfigured on PSI minikube instance if this is passing everywhere else?

I don't think so because odo push works fine but it fails only if we create component with default project. Not sure if we need to do some additional configuration for default project component.

@kadel @mik-dass I tried the entire step manually on PSI and its failing. Not only the tests but also manually code executions are failing.

Is it possible that something is misconfigured on PSI minikube instance if this is passing everywhere else?

I don't think so because odo push works fine but it fails only if we create component with default project. Not sure if we need to do some additional configuration for default project component.

ok, I'm able to reproduce this localy

As part of Sprint 200,

[ ] 3 consecutive successful test run on jenkins.
[ ] Enable minikube jobs on pr


Parsing GEN files

Add utility function to transform SpaceEx output (eg. polygons or flowpipes as TXT) to Julia objects within JuliaReach.
See https://github.com/JuliaReach/ReachabilityBenchmarks/pull/25#issuecomment-400413620

This would be cool to show reach sets from SpaceEx and JuliaReach in the same plot.


Investigate raylib and others for ui

openpilot's UI used to be written in https://github.com/memononen/nanovg, and in retrospect that it was nicer to work in than . Qt is nice for cabana, but it turns out to not add much value to the openpilot ui and adds a bunch of conceptual and dependency complexity.
Some options

https://www.raylib.com/
https://github.com/Immediate-Mode-UI/Nuklear
https://github.com/raysan5/raygui

We're looking for:

cross platform: Linux, macOS, etc.
small, simple. single header is ideal
Python bindings? would be great to have all or most of the UI written in Python

The onroad camera view is a good test for trying out these libraries.

@deanlee want to try to make a small demo in raylib of the onroad camera view?

I tried writing a simple demo based on Raylib to display the road camera (without shaders). Raylib can simplify some OpenGL code, and its text rendering performance is also somewhat better (currently, in the drawHud function of the Qt UI, the three drawText function calls consumes about 3% of the CPU).
Raylib might be a good option. The real challenge is the workload of migrating the entire UI to Raylib, including rewriting network management and WiFi manager.  All logic is driven by a while loop, and input/output would also need to be restructured, making the workload quite significant. Considering that the current UI is relatively stable, if the goal is just to save space, it might be worth first optimizing other dependencies that can be relatively easily removed before eventually migrating to Raylib, RayUI, or another library.

Qt was a big improvement over the old APKs, and I expect this to be a similar improvement. Smaller dependency, simpler library, better docs, etc.
I think we do have to find some way to do this incrementally; like you said, it's too much to do all at once. If you can't figure out a way to do it, I can start it. Want to put up a draft PR with the demo you wrote?

I'll commit a draft after adding the shader, transformations, and other features to ensure it matches the CameraView's output.

fyne is quite nice although it's written in golang which would be a bit of a hurdle, though it wouldn't be the first time the UI were separate from the py

PR #33326  provides a draft on using Raylib to display the road camera, with automatic scaling to fit the window while keeping the aspect ratio.

First Step: Migrate Onroad Widgets to Raylib
1.Organize the existing code by encapsulating related functions into specific classes to improve clarity and maintainability, making the transition to raylib smoother.

[ ] Refactor CameraView to serve as a generic class for displaying vision streams, enhancing modularity and code reuse. https://github.com/commaai/openpilot/pull/33372
[ ] Create a dedicated class for lead car updates and rendering functions.
[ ] Create a dedicated class for driver monitor updates and rendering functions.
[ ] Create a dedicated class for HUD updates and rendering functions.
[ ] Create a dedicated class for model updates and rendering functions.

Migrate to raylib

[ ] Port the rendering functions of the newly organized classes from Qt to raylib, ensuring better performance and seamless integration with raylib's rendering capabilities.

In my opinion, the current UI structure and display elements are relatively simple, making migration straightforward. The main challenges involve replacing the qdbus dependency with libdbus for the WiFi manager and implementing multi-language support. We need to create a tool similar to Qt’s lupdate to extract translatable strings and generate test cases. Once these tasks are completed, the migration will be quick and can likely be done in one go.


Create tensorflow.md

Added tensorflow integration instructions
Signed-off-by: Justin Woo<EMAIL_ADDRESS>

@Saumya-Sunder, Can you verify & link the same as suggested?

@Saumya-Sunder, please verify & update as suggested

@Saumya-Sunder, please verify & update as suggested

Too old. Cleaning up.


[BUG] DefaultAzureCredential failed to retrieve a token from the included credentials

Describe the bug
After switching from Azure.Identity 1.2.0 to Azure.Identity 1.3.0 I get the following error while debugging my ASP .NET Core 3.1.8 Application:
DefaultAzureCredential failed to retrieve a token from the included credentials.
- ManagedIdentityCredential authentication unavailable. No Managed Identity endpoint found.
- SharedTokenCacheCredential authentication unavailable. Token acquisition failed for user . Ensure that you have authenticated with a developer tool that supports Azure single sign on.
- Process "C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\Extensions\b1hwzg3d.j4s\TokenService\Microsoft.Asal.TokenService.exe" has failed with unexpected error: TS003: Error, TS004: Unable to get access token.  'AADSTS500011: The resource principal named https://database.windows.net/default was not found in the tenant named X. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You might have sent your authentication request to the wrong tenant.
Timestamp: 2020-11-20 12:14:23Z'

While using Azure.Identity 1.2.0 I had already issues with following bug: https://github.com/Azure/azure-sdk-for-net/issues/14691
Now what I am doing:
I switched our application and resources for the use of managed identities. For debugging I am using the "Azure Service Authentication" option in Visual Studio 2019. The error occurs not in a deterministic timeframe. Sometimes my application is working for about an hour without problems and sometimes the error occurs after few minutes.
This is a snippet where I get the exception:
            if(Database.GetDbConnection() is Microsoft.Data.SqlClient.SqlConnection conn)
            {
				var tokenCredential = new DefaultAzureCredential(new DefaultAzureCredentialOptions()
				{
					ExcludeAzureCliCredential = true,
					ExcludeVisualStudioCodeCredential = true,
				});

				var context = new TokenRequestContext(new[] { "https://database.windows.net/default" });
				var tokenResponse = tokenCredential.GetToken(context);
				conn.AccessToken = tokenResponse.Token;
            }

I experiment with the DefaultAzureCredentialOptions. But it makes no difference if I use the DefaultAzureCredentialOptions or not:
	   if(Database.GetDbConnection() is Microsoft.Data.SqlClient.SqlConnection conn)
            {
				var tokenCredential = new DefaultAzureCredential();

				var context = new TokenRequestContext(new[] { "https://database.windows.net/default" });
				var tokenResponse = tokenCredential.GetToken(context);
				conn.AccessToken = tokenResponse.Token;
            }

After a while my application crashes.
Environment:

Azure.Identity 1.3.0
Windows 10 20H2 with .NET Core 3.1.8
Visual Studio 2019 Version 16.8.2

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

@AliGuemues thanks for filing this issue. Sorry your having this trouble. Looking at the error message it seems that the VisualStudioCredential is failing with the following error which is complaining about the scope that you've passed in "https://database.windows.net/default".
Process "C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\Extensions\b1hwzg3d.j4s\TokenService\Microsoft.Asal.TokenService.exe" has failed with unexpected error: TS003: Error, TS004: Unable to get access token.  'AADSTS500011: The resource principal named https://database.windows.net/default was not found in the tenant named X. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You might have sent your authentication request to the wrong tenant'

I believe the scope you meant to specify is "https://database.windows.net/.default" (note the . before default). If you update the scope do you still see authentication failures?

@schaabs thanks for your quick response. I changed the scope of the URL like you mentioned and it seems to work. I tested my application for about an hour without any problems.
So its my fault to check the URL of the scope. But I am wondering about why this was working with the wrong scope URL for quite of time and failed in a non deterministic timeframe. I set breakpoints on the code and their was no exception for let me guess hundred times and then the exception occured.
Do you have any explanation for this behaviour?
Greetings

Hi @AliGuemues I'm going to close this issue for now - but if you can reproduce the behavior with the wrong scope set, please re-open with the details.

Hello,
I am having Similar Issue.
When I try to run the following thing on gitlab it gives me error.
if credential is None:
credential = azure.identity.DefaultAzureCredential(exclude_shared_token_cache_credential=True)
self.credential = credential
if kv_name is None:
kv_name = os.getenv("AZURE_KV_NAME")
url = f"https://{kv_name}.vault.azure.net"
super().init(url, credential, **kwargs)
Result: Failure
Exception: ClientAuthenticationError: DefaultAzureCredential failed to retrieve a token from the included credentials.
Attempted credentials:
EnvironmentCredential: EnvironmentCredential authentication unavailable. Environment variables are not fully configured.
Visit https://aka.ms/azsdk/python/identity/environmentcredential/troubleshoot to troubleshoot.this issue.
ManagedIdentityCredential: ManagedIdentityCredential authentication unavailable, no response from the IMDS endpoint.
SharedTokenCacheCredential: SharedTokenCacheCredential authentication unavailable. No accounts were found in the cache.
AzureCliCredential: Azure CLI not found on path
AzurePowerShellCredential: PowerShell is not installed
To mitigate this issue, please refer to the troubleshooting guidelines here at https://aka.ms/azsdk/python/identity/defaultazurecredential/troubleshoot.
Stack: File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/dispatcher.py", line 452, in _handle__invocation_request
call_result = await self._loop.run_in_executor(
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/dispatcher.py", line 718, in _run_sync_func
return ExtensionManager.get_sync_invocation_wrapper(context,
File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/extension.py", line 215, in _raw_invocation_wrapper
result = function(**args)
File "/home/site/wwwroot/regatta_association/init.py", line 26, in main
con_in = api.get_northstar_connection(secrets_manager := api.SecretsManager())
File "/home/site/wwwroot/api/database.py", line 43, in get_northstar_connection
username = secrets_manager.get_secret_value("northstar-db-username")
File "/home/site/wwwroot/api/secrets.py", line 39, in get_secret_value
return self.get_secret(name, version, **kwargs).value # type: ignore
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/tracing/decorator.py", line 78, in wrapper_use_tracer
return func(*args, **kwargs)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/keyvault/secrets/_client.py", line 72, in get_secret
bundle = self._client.get_secret(
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/keyvault/secrets/_generated/_operations_mixin.py", line 1574, in get_secret
return mixin_instance.get_secret(vault_base_url, secret_name, secret_version, **kwargs)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/tracing/decorator.py", line 78, in wrapper_use_tracer
return func(*args, **kwargs)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/keyvault/secrets/_generated/v7_3/operations/_key_vault_client_operations.py", line 694, in get_secret
pipeline_response = self._client._pipeline.run( # pylint: disable=protected-access
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/pipeline/_base.py", line 205, in run
return first_node.send(pipeline_request) # type: ignore
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/pipeline/_base.py", line 69, in send
response = self.next.send(request)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/pipeline/_base.py", line 69, in send
response = self.next.send(request)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/pipeline/_base.py", line 69, in send
response = self.next.send(request)
[Previous line repeated 2 more times]
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/pipeline/policies/_redirect.py", line 160, in send
response = self.next.send(request)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/pipeline/policies/_retry.py", line 474, in send
response = self.next.send(request)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/pipeline/policies/_authentication.py", line 126, in send
request_authorized = self.on_challenge(request, response)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/keyvault/secrets/_shared/challenge_auth_policy.py", line 117, in on_challenge
self.authorize_request(request, scope, tenant_id=challenge.tenant_id)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/core/pipeline/policies/_authentication.py", line 106, in authorize_request
self._token = self._credential.get_token(*scopes, **kwargs)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/identity/_credentials/default.py", line 168, in get_token
return super(DefaultAzureCredential, self).get_token(*scopes, **kwargs)
File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/identity/_credentials/chained.py", line 101, in get_token
raise ClientAuthenticationError(message=message)
Can anyone help me out in this?


[Bug]: Using latest version of Swashbuckle, OpenAPI documentation is incorrect when using custom TryParse() binding with Minimal APIs

Describe the bug
Using latest versions of Swashbuckle (from 6.7.0 to the last one) with .NET 8.0.10, I have the same issue described in https://github.com/dotnet/aspnetcore/issues/36412. If I revert to Swashbuckle.AspNetCore 6.6.2, everything works as expected.
Steps to reproduce
Use Swashbuckle.AspNetCore 6.7.0 or later and try the code at https://github.com/dotnet/aspnetcore/issues/36412.
Swashbuckle.AspNetCore version
6.7.0 or later
.NET Version
8.0.403
Anything else?
No response

I wonder if we need to do something similar to how they fixed it: https://github.com/dotnet/aspnetcore/pull/36526

@martincostello if you can give me an hint about what part of Swashbuckle to look at, I could try to give it a look. In this moment, this is a blocking issue for me, so I would be happy to contribute.

To be honest, I don't know myself off the top of my head without going digging in the code. I would imagine whatever it is in is here somewhere: https://github.com/domaindrivendev/Swashbuckle.AspNetCore/tree/master/src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator

By the way, the same issue happens also using the new built-in generator provided by .NET 9.0 RC2. I have opened an issue on the ASP.NET Core repository: https://github.com/dotnet/aspnetcore/issues/58318.

The issue may probably be caused by #2980, however it has to be rethinked because this was also preventing the base types like int,Enums,DateTimes to be reported as the actual type ( Not just a string)

@jgarciadelanoceda, can you explain the issue are you referring to about base types?
I have tried with:
app.MapGet("/test", (int number, DateTime dateTime, Status status) => TypedResults.NoContent());

public enum Status
{
    Active,
    Disabled
}

And I obtain this result (that seems correct):

With the version 6.6.2 the enum was not being shown as Enum and just as string, I am reviewing it

I have created a PR.. I showed that the #2532 fixed the issue #2733 and I applied with the latest bits.
Sorry for it and thanks for this issue


Add gpt baselines: mini, small, medium

Description
todo
Checklist
Answer each question with "yes", and provide an explanation if the answer isn't what is expected.

Is this PR focused on a single feature without the possibility of being divided into smaller PRs?

Answer: yes

Are all variables set with logical defaults that are backward compatible?

Answer: yes

Can you provide a link to a Neptune experiment verifying the functionality of this PR?

Answer: N/A

Have you successfully executed the linter and tests?

Answer: yes

Are all functions concise and don't require splitting?

Answer: yes

Is there documentation for arguments and complex logic?

Answer: N/A

Are there no temporary solutions in the code? Should a task be added to Trello to refine the code?

Answer: yes

Are all functions placed in appropriate files?

Answer: N/A

Is the PR name meaningful and descriptive?

Answer: yes

Is PR description provided, or unnecessary?

Answer: unnecessary

Other questions:

Have you not made changes to the requirements or anything related to the Singularity image? If you have, did you generate and upload a new image to the clusters?

Answer: yes

Is the change significant enough to notify all individuals working with this repository?

Answer: yes

Is there a need for a second reviewer?

Answer: yes

Dałem trochę komentarzy co do configów. Jaki batch size się mieści? i chyba chcemy ustalić dużo większą liczbę kroków?

Maksymalny batch size na bert medium dense   z loss chungusem to 505.

LGTM

A jaka jest reasonable liczba kroków?

ten PR wisi za długo; baseliny nie mogą dłużej czekać. Ustawiłem lokalnie warmup na 10K, zapisuję modele co 50K, trenuję 250K+20K=270K kroków, zmieniłem nazwy ścieżek bo by się nadpisywały.

Another PR will be made with inheritance


Allow hook for list of collapsed IDs

Hey there, awesome library!
I'm looking to update a list of collapsed IDs each time a user clicks the collapse button, I was thinking of hooking into the renderCollapseIcon for the onClick but then I don't believe I have anyway of defining which IDs are collapsed or not?
This would be great so I could for example, save the IDs in local storage and have user saved state.
Cheers,
Nick

hi. thank you for the feature request. the onCollapseChange callback is added. cheers


When trying to move a way node close to an area edge, the node jump

Description
I was trying to align a road close to and area edge when sudenly the node jump to another place dragging the road, try 3 times and the behavior was the same. Took some screenshoots

Version
2.0.0-beta.0
What browser are you seeing the problem on? What version are you running?
Chrome v110.0
The OS you're using
Win10
Steps to reproduce
No response
The browser URL at the time you encountered the bug
https://mapwith.ai/rapid-v2-beta#background=Mapbox&datasets=fbRoads,msBuildings&disable_features=power&map=18.44/-18.18017/-68.70825&overlays=osm-gps
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
No response

This behavior seems similar when the area edge highlight as selected when you are adding or editing a line/way adjacent or close to the edge of such area

I'm going through these bugs, trying to repro on a windows machine. This one was filed a few minor versions ago, and I can't seem to reproduce it.  I know we have fixed a bunch of bugs/issues with the border snapping since then though!

Cannot repro.


api:schema error

some property values are null
as workaround i applied array_filter
[streams] src/Stream/StreamSchema.php (Lines 32-38)

    public function object(): Schema
    {
        // @todo figure out why some property values are null, as workaround i applied array_filter
        $props=array_filter($this->properties());
        return Schema::object($this->stream->id)
            ->properties(...$props);
    }

Open in IDE
Created from JetBrains using CodeStream

I think this was due to missing field schemas - cannot reproduce anymore but let's get a specific use case (dump streams from the project here) if this occurs again.


splitDocuments support multiple separators

need splitDocuments support multiple separators

@pslxx you can loop over them no? do you have a limitation to do that?
Feel free to share what you want to do


SPEC: Develop Network Service Endpoints

Overview
We need to provide a generic way to simplification of developing Network Service Endpoint.
Link to the Google Docs document
https://docs.google.com/document/d/1rPhmqU71t5YgJQ_mWETtr2q6Z7AMO8e4NrZRvFTmFIU/edit?usp=sharing

Finally, we with @edwarnicke  decided to implement option 2 from the SPEC.
The work is planned to be completed in nsmctl repository.
Moving the issue...


Fix scrolling issues on mobile

Also happens on desktop in some cases.
Due to us disabling overflow on the body element.

Should be fixed by https://github.com/NotionX/react-notion-x/commit/3fcefe51c542a992c32389ab0e7559597a414327

Should be fixed by https://github.com/NotionX/react-notion-x/commit/3fcefe51c542a992c32389ab0e7559597a414327


Fix malformed path exception

Malformed/unexpected path exception is thrown when File Browser is opened to select an Executable Path or Working Directory if Replay Context was switched from Local to Android device.
Wrong Executable Path is set (Android package name is appended to RenderDoc's build folder path) e.g. /home/tabikati/Workspace/build-renderdoc-Desktop_Qt_5_6_1_GCC_64bit-Debug/com.example.native_activity while it should be the package name (com.example.native_activity) only.

Can you give more information about what is actually wrong? You mention an exception but exceptions should not be used anywhere in renderdoc. Is there an unhandled exception leading to a crash - if so where does it crash?

I got this in the indexForPath method (VirualFileDialog.cpp 136)
because the normPath (which is com.example.native_activity in my case) doesn't begin with „/” .
 134     if(normPath[0] != QLatin1Char('/'))
 135     {
 136       qCritical() << "Malformed/unexpected path" << path;
 137       return QModelIndex();
 138     }

This method is called from the VirtualFileDialog's constructor (VirtualFileDialog.cpp 594)
because the initialDirectory is not empty.
594  changeCurrentDir(initialDirectory.isEmpty() ? m_Model->homeFolder()
595                                         : m_Model->indexForPath(initialDirectory));

OK I understand, in that case the better fix is to make the VirtualFileDialog more robust so that it handles invalid paths better. The same problem could occur if someone is using a linux remote host and chooses and invalid path, your current fix only hides the problem for android.
The code could call indexForPath, and if it fails then use homeFolder instead.

OK, I have modified my commit.

I have modified my commit.


Add kernel version check

Fixes #48 as discussed

Sorry about the delay. Thanks. Cherry-picked in 9c1a4f3 in devel.

Just saw that you change from my list comprehension to the * sequence expansion, I don't think that works in Python 2 which is why I used list comp in the error message.

@CrazyIvan359 Are you thinking of an older Python 2? It works in Python 2.7:
Python 2.7.18 (default, Sep  5 2020, 11:17:26)
[GCC 10.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> version = (1, 2)
>>> "foobar {}.{}".format(*version)
'foobar 1.2'
>>>

Hmm... Maybe it's lists you can't do it with then? I remember I've had errors thrown at me for using that operator in 2.7 before. If it works here then all good!

Lists work too. Maybe you ran into this one: https://stackoverflow.com/questions/22257930/python-2-tuple-list-unpacking-using-star-throws-syntaxerror , which is Python 3 only. In any case, I tested the current code with both 2 and 3, so we should be good.

That looks familiar, yes.


Job Runs should create derived Dataset objects

When a Job Run is complete, a Dataset object of the type "derived" should also be created so that JobRun outputs can be used for further computation/visualization.

The information obtained from a JobRun actually doesn't fit very well into the Dataset model (many fields would be non-applicable) and no information is gained by saving the outputs of a JobRun to a Dataset's content. In fact, information is obscured: the context of the JobRun (its inputs, script, etc) could not be saved directly to the Dataset object and would have to be nested inside a reverse relation to the original JobRun object.
To simplify this, I propose we make the derived_datasets field on the Dataset model a ManyToMany of JobRuns, not other Datasets. We could change the name to derived_analytics or something similar. We can still use JobRuns as valid inputs for further computation, and we'll get to keep the context nearby.

Would it be possible for the job logic itself to create the Dataset object in the system? Then we can leave it to each job type to supply the logic to cause derived datasets to appear. Something feels off about have a Dataset link to JobRuns via a property called derived_datasets.
I'm happy to discuss this in person if needed.

Originally, I had imagined that the JobRun object would create a Dataset object within the spawn function, but I realized we would have a lot of blank fields and missing context. I do think we would have to change the name of the field if we change the model to which it links. It may be best to discuss this, but I'm not available until Monday. How about during the whole team meeting?

Whatever the results of that discussion end up being, let's be sure to write it up as part of this thread (or elsewhere, as long as its accessible)? I think its important that we really nail down the relationship between Dataset, derived_datasets, and JobRun objects (and Pins!). I think having well-defined concepts for these entities will really help with dicussing potential workflows in the system

In a discussion this evening, we decided that JobRuns can still create Dataset objects from their outputs. The JobRun model will need a new field to reference the newly-created Dataset, and the Dataset serializer will need a field to reference the reverse relation to the JobRun that created it.

During our pair programming today, @marySalvi and I realized that the information held by the JobRun object can be contained in the content of a Dataset, which means that when we spawn a job and create these derived Dataset objects, we don't actually need the "middle man" JobRun model anymore. Today we experimented with removing it, and it seems to be a cleaner structure.
Instead of the JobRun endpoints, we tried making it a Dataset-related action: POST /datasets/run_job/ with the following inputs:

original_dataset (optional): reference to an existing Dataset object, which will gain references to all new Dataset objects resulting from the job in its derived_datasets field
input_image: the image captured on the frontend to analyze in the job
script: reference to an existing JobScript object
additional_inputs (optional): additional args for the job

This was inspired by the discussion yesterday about our JobRun solution possibly being redundant. Mary and I are hoping to finish experimenting with this restructure tomorrow morning. @waxlamp thoughts?

This is great thinking. I like the push towards simplifying these concepts and cutting out middleman models (moddles?). I have a suspicion we can go even further but we can discuss that at tomorrow brainstorming meeting.


Test with BridgeDb 3.0.5

[x] Egon: make .jar with BridgeDb 3.0.5 (using a PR)
[x] Egon sends Luc new .jar
[x] Luc creates one .derby file with that new jar
[x] Luc compares that one derby file with one created with an older converter jar with the QC tool
[x] Luc reports the QC comparison in a comment on this issue

First QC results: https://github.com/bridgedb/create-bridgedb-genedb/issues/17


flagSecure + theme properties +  avoid addWindowToStack error

Add Flagsecure (to prevent screenshot of the app)
avoid addWindowToStack error
Add possibility to change the Android theme of the drawer

HI @SquirrelMobile great stuff. I would be happy to merge it, but please dont delete old releases.

@viezel i've add the old releases

can you please fix the conflicts?

@SquirrelMobile I would like to merge this, but cannot before the conflicts are resolved.

Hi, I'm getting the addWindowToStack issue.. is there a release with the fix in?..
Thanks


Test top 4 APIs on GAE Flex, GKE, and GCP

Test BigQuery, Storage, Datastore, and Logging client libraries on all the GCP platforms (don't include GAE Standard).
Close this issue once we confirm it all works.

@omaray not sure I follow?
You mean windows/linux/etc?

ISTM that we should take this as an opportunity to adopt non-PR-driven testing, and do these builds (including system test runs) periodically.

@jonparrott Has previously mentioned they have a Jenkins server we might use. Travis has a whitelisted cron feature. CircleCI has no official cron support, but they do have an API to spawn jobs, so we could have a dumb GAE app that sent API requests to CircleCI every 24 hours to act as a cron?

Yes, we need to make sure that our libraries work on GCE, GKE, and GAE Flex. We need to do what an end-user would do. Literally, write some code, use the client libraries for these 4 APIs, and deploy it to these platforms! Ideally we can test all methods. If we can automate - great. But we definitely need a full manual end-to-end test here. And we should test the top 4 libraries.
Basically: when customers will use our 1.0 libraries and deploy them on our platforms by running things like "gcloud app deploy" and what not,  they should hit 0 issues. It should just work. And we need to test that.

I can set this up.
 I am adjusting timeouts and such to try to fix, but running tests once a night on GCP is not going to do us any good if we have a lot of noisy failures.

Testing on GCE
Step 1. Create Instance

Go to Pantheon
Create new Ubuntu 16.04 image with 1 CPU, 10 GB disk space

Step 2. Configure Instance
lukesneeringer@python-system-tests:~$ sudo add-apt-repository ppa:fkrull/deadsnakes
[...]
lukesneeringer@python-system-tests:~$ sudo apt-get update
[...]

(The above generated too much output to paste, but it is exactly what you would expect.)
lukesneeringer@python-system-tests:~$ sudo apt-get install -y git
Reading package lists... Done
Building dependency tree
Reading state information... Done
git is already the newest version (1:2.7.4-0ubuntu1).
0 upgraded, 0 newly installed, 0 to remove and 12 not upgraded.

Okay, could have skipped that step. Fine.
lukesneeringer@python-system-tests:~$ which python
/usr/bin/python
lukesneeringer@python-system-tests:~$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>>

Python 2.7.12 is installed by default. I need to add 3.4, 3.5, and 3.6.
lukesneeringer@python-system-tests:~$ sudo apt-get -y install python3.4 python3.5 python3.6
Reading package lists... Done
Building dependency tree
Reading state information... Done
python3.5 is already the newest version (3.5.2-2ubuntu0~16.04.1).
The following additional packages will be installed:
  libpython3.4-minimal libpython3.4-stdlib libpython3.6-minimal libpython3.6-stdlib python3.4-minimal
  python3.6-minimal
Suggested packages:
  python3.4-venv python3.4-doc binutils binfmt-support python3.6-venv python3.6-doc
The following NEW packages will be installed:
  libpython3.4-minimal libpython3.4-stdlib libpython3.6-minimal libpython3.6-stdlib python3.4
  python3.4-minimal python3.6 python3.6-minimal
0 upgraded, 8 newly installed, 0 to remove and 12 not upgraded.
[...]
Setting up python3.4 (3.4.5-1~xenial1) ...
Setting up python3.6 (3.6.0-1+xenial1) ...

Python 3.4 and 3.6 were installed. I do not see Python 3.5; I am guessing it is packaged with Ubuntu 16.04 by default...
lukesneeringer@python-system-tests:~$ which python3.5
/usr/bin/python3.5

It is. Moving on.
lukesneeringer@python-system-tests:~$ which pip
lukesneeringer@python-system-tests:~$ sudo apt-get install -y python-pip
[...]

Finally, install nox.
lukesneeringer@python-system-tests:~$ sudo pip install nox-automation
The directory '/home/lukesneeringer/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/home/lukesneeringer/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting nox-automation
  Downloading nox-automation-0.10.0.tar.gz
Collecting colorlog<3.0.0,>=2.6.1 (from nox-automation)
  Downloading colorlog-2.10.0-py2.py3-none-any.whl
Collecting py<2.0.0,>=1.4.0 (from nox-automation)
  Downloading py-1.4.33-py2.py3-none-any.whl (83kB)
    100% |████████████████████████████████| 92kB 4.3MB/s
Requirement already satisfied (use --upgrade to upgrade): six<2.0.0,>=1.4.0 in /usr/lib/python2.7/dist-packages (from nox-automation)
Collecting virtualenv>=14.0.0 (from nox-automation)
  Downloading virtualenv-15.1.0-py2.py3-none-any.whl (1.8MB)
    100% |████████████████████████████████| 1.8MB 740kB/s
Installing collected packages: colorlog, py, virtualenv, nox-automation
  Running setup.py install for nox-automation ... done
Successfully installed colorlog-2.10.0 nox-automation-0.10.0 py-1.4.33 virtualenv-15.1.0
You are using pip version 8.1.1, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Now I am ready to clone the repo:
lukesneeringer@python-system-tests:~$ git clone https://github.com/GoogleCloudPlatform/google-cloud-python.git
Cloning into 'google-cloud-python'...
remote: Counting objects: 173114, done.
remote: Compressing objects: 100% (168/168), done.
remote: Total 173114 (delta 86), reused 21 (delta 21), pack-reused 172917
Receiving objects: 100% (173114/173114), 114.54 MiB | 24.91 MiB/s, done.
Resolving deltas: 100% (145162/145162), done.
Checking connectivity... done.
lukesneeringer@python-system-tests:~$ cd google-cloud-python/

Use my ci branch, which is a work in progress, but better suited for this purpose:
lukesneeringer@python-system-tests:~/google-cloud-python$ git checkout --track -b ci origin/ci
Branch ci set up to track remote branch ci from origin.
Switched to a new branch 'ci'

Step 3. Actually Run Tests
datastore


update consumer dependencies signature

Workaround for https://github.com/flutter/flutter/issues/91108

Full fix pending in https://github.com/flutter/flutter/pull/91109#issuecomment-932527350

Landing on red to fix tree, Linux analyze is passing.


composer update error

Laravel Version: 5.5
PHP Version: 7.2.11

Description:
"composer update" returns "...\vendor/infyomlabs/laravel-generator does not exist and could not be created."
in composer.json:
"infyomlabs/core-templates": "5.3.x-dev",
"infyomlabs/generator-builder": "dev-master",
"infyomlabs/laravel-generator": "5.3.x-dev",
"infyomlabs/swagger-generator": "dev-master",
How can i fix this issue?

Welcome to Laravel! We are glad to have you as part of the community.
Unfortunately GitHub is not an appropriate platform for general application issues. This is only for issues/bugs with the framework code itself.
Please close your issue, and instead try asking your question on one of the many great community support areas that will likely give you a better answer more quickly:
Laravel Slack (https://larachat.co/)
Laravel.io Forum (https://laravel.io/forum)
Laracasts Forum (https://laracasts.com/discuss)
StackOverflow (http://stackoverflow.com/questions/tagged/laravel)
Thanks!

The development branch you selected no longer exists  within your composer.json.


Update hdinsight-using-spark-query-hbase.md

Adding steps to use script for Spark HBase communication automation

@shawnawei : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The updates in this PR have been merged to master in a new PR in the private repository. We'll close this PR.


SXWN9000 when setting up $impl:successful

test.xsl which just returns the input node:
<?xml version="1.0" encoding="UTF-8"?>
<xsl:stylesheet exclude-result-prefixes="#all" version="2.0"
	xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
	<xsl:template as="node()" match="node()">
		<xsl:sequence select="." />
	</xsl:template>
</xsl:stylesheet>

test.xspec which just counts the element:
<?xml version="1.0" encoding="UTF-8"?>
<x:description stylesheet="test.xsl" xmlns:x="http://www.jenitennison.com/xslt/xspec"
	xmlns:xs="http://www.w3.org/2001/XMLSchema">

	<x:scenario label="Scenario-1">
		<x:context><foo /></x:context>
		<x:expect label="Expect-1" select="1" test="count(foo)" />
	</x:scenario>
</x:description>

The test runs fine, but a warning SXWN9000 is raised when setting up $impl:successful.
P:\test>f:bin\xspec test.xspec
Saxon script not found, invoking JVM directly instead.

Creating Test Stylesheet...

Running Tests...
Warning at char 29 in xsl:variable/@select on line 91 column 157 of test.xsl:
  SXWN9000: The only value that can pass type-checking is an empty sequence. Required item
  type of value of variable $impl:successful is xs:boolean; supplied value has item type xs:integer
Testing with SAXON EE <IP_ADDRESS>
Scenario-1
Expect-1

Formatting Report...
passed: 1 / pending: 0 / failed: 0 / total: 1
Report available at P:\test\xspec\test-result.html
Done.

Though the warning doesn't seem harmful, still nice to remove.

@cirulls,
Shall we give this issue a certain milestone?

The same test returns Success on XSpec 0.3. So at some point in the past, a certain decision was made to break the backward compatibility?


Add date ran as a column

I'm trying to add the date the test was run as a new column and I added in the settings this: data.completed and ran the update test columns and ran, but the column ends up empty.  Any ideas what I'm doing wrong?

figured it out.  I had to update the named range


Type annotations

This adds type annotations to almost all functions. The xopen() function itself is annotated as having the IO return type, which is not perfect, but should be good enough for now.
See #22

Thanks for the review! And yes, let’s drop Python 3.5 very soon, also for f-strings!


Queue access

Add a little more access to the QueuedAudioPlayers properties.

Codecov Report

Merging #47 into master will decrease coverage by 0.35%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   80.48%   80.13%   -0.36%
==========================================
  Files          17       17
  Lines         912      916       +4
==========================================
  Hits          734      734
- Misses        178      182       +4

Impacted Files
Coverage Δ

SwiftAudio/Classes/QueuedAudioPlayer.swift
75.86% <0%> (-5.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3930096...0ae0427. Read the comment docs.


Request for info on fork

Hi R Clayton I presume
I'm Raj, project lead on jsendnsca (admittedly fairly inactive due to family life nowadays). Can you summarise what lead you to fork the API as would really like the changes you have made to be integrated back into the original project if they would be of interest to wider world which they seem like they would
I've got no issues with adding you as a developer and would be great if we can bring the  changes back in.
Looking forward to your response.
Raj

Is this fork still alive?
I could add the changes to the original project for the upcoming release if it should be in there.
Raj, what do you think?

Hi Max,
Cutting a release, 2.1.0 as we speak.
Will email to let you know when ready.
Thanks
On Mon, 7 Mar 2016 at 08:13 Max Schwaab<EMAIL_ADDRESS>wrote:

Is this fork still alive?
I could add the changes to the original project for the upcoming release
if it should be in there.
Raj, what do you think?
—
Reply to this email directly or view it on GitHub
https://github.com/Berico-Technologies/jsendnsca/issues/1#issuecomment-193147816
.

--
Raj Patel - 07957 446908


Windows 10.0.17763.4499 not supported

Hello. Need's help pls.

Please, attach your RDPConf screenshot and termsrv.dll.

Duplicate of https://github.com/stascorp/rdpwrap/issues/2167


improving robusness and speed of go getting packages

Closes #66

Coverage remained the same at 53.996% when pulling c02ad6772666c2781c78d046d033715eb20dca9d on 66 into d55f5ea10953904568cb69d4c40270f3b97c1a02 on master.


Ensure tmp directory gets created

Coverage increased (+0.007%) to 99.415% when pulling 9ef6d1bc977e831715a8ed5ad05f212421cf1930 on me/tmpdir into b2fd8d2268aed73d4aba99d9ca9d1cd7bb64c68d on develop.

the coveralls integration seems borked?

(not only on this pr)

yeah, we reset our 3rd party integrations, going to see if i can fix

Yeah, status API requests don't seem to be going through. Will hit up our admin team to see what's up.


Garden runtime support

There are two parts to this PR, one simply adding Garden (the container piece behind Cloud Foundry) as a runtime. The existing /proc/self/cgroup strategy works for Garden out of the box:
Before
~ # ./amicontained
Container Runtime: not-found
Has Namespaces:
	pid: true
	user: true
User Namespace Mappings:
	Container -> 0	Host -><PHONE_NUMBER>	Range -> 1
	Container -> 1	Host -> 1	Range -><PHONE_NUMBER>
AppArmor Profile: garden-default (enforce)
Capabilities:
	BOUNDING -> chown dac_override fowner fsetid kill setgid setuid setpcap net_bind_service net_raw sys_chroot mknod audit_write setfcap
Chroot (not pivot_root): false
Seccomp: filtering

After
~ # ./amicontained
Container Runtime: garden
Has Namespaces:
	pid: true
	user: true
User Namespace Mappings:
	Container -> 0	Host -><PHONE_NUMBER>	Range -> 1
	Container -> 1	Host -> 1	Range -><PHONE_NUMBER>
AppArmor Profile: garden-default (enforce)
Capabilities:
	BOUNDING -> chown dac_override fowner fsetid kill setgid setuid setpcap net_bind_service net_raw sys_chroot mknod audit_write setfcap
Chroot (not pivot_root): false
Seccomp: filtering

The second part of the PR seemed sensible, but I'm not sure on the intent on this repo. I updated some of the paths (still a few release URLs on the README point to the old repo) in the README and in the Go import paths to point to this repo since it seemed like you intended it to become the canonical location.

thanks!!! forgot about import path hell hahahha


Bug on percentile for packages on RDocumentation

It seems there is something wrong when calculating the downloads percentile on RDocumentation:
All packages seem to be in the 99.99 percentile :)
https://www.dropbox.com/s/ilef980i7tojrf1/Screenshot 2017-05-31 16.13.38.png?dl=0
using https://www.rdocumentation.org/search, and this seems to be true for any package.
@ludov04 @ramnathv

There was a cleaned up of download stats yesterday to free up storage, you might have run into a glitch while this was being done, can you retry now ?
This is what I have:

Hi @ludov04
Unfortunately the issue still persists for me:
https://www.dropbox.com/s/uiplbtf8oojp7nb/Screenshot 2017-06-01 09.43.47.png?dl=0

@LoreDirick did you refresh your browser. It might be caching results.

I did, close off everything and I still get this:
https://www.dropbox.com/s/lqqemo5zmaa7i7x/Screenshot 2017-06-01 09.50.47.png?dl=0 https://www.dropbox.com/s/lqqemo5zmaa7i7x/Screenshot 2017-06-01 09.50.47.png?dl=0
When I click through the percentile is correct:
https://www.dropbox.com/s/qf83nruy7tudm9z/Screenshot 2017-06-01 09.51.32.png?dl=0 https://www.dropbox.com/s/qf83nruy7tudm9z/Screenshot 2017-06-01 09.51.32.png?dl=0

On Jun 1, 2017, at 9:48 AM, Ramnath Vaidyanathan<EMAIL_ADDRESS>wrote:
@LoreDirick https://github.com/loredirick did you refresh your browser. It might be caching results.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/datacamp/RDocumentation-app/issues/341#issuecomment-305498537, or mute the thread https://github.com/notifications/unsubscribe-auth/AQGDnn7l1Z7fEeLz_xZZl3GYia20ppS7ks5r_sE6gaJpZM4NsIr5.

@LoreDirick Is it still an issue for you ?

No, seems to work now! Thanks @ludov04 !
On Mon, Jun 26, 2017 at 10:21 AM, Ludovic Vannoorenberghe <
<EMAIL_ADDRESS>wrote:

@LoreDirick https://github.com/loredirick Is it still an issue for you ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/datacamp/RDocumentation-app/issues/341#issuecomment-311073796,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGDnqf3kHCKTRcquocm4ZEvJZg7dSJWks5sH758gaJpZM4NsIr5
.

--
Dr. Lore Dirick
Content Partnership Manager at DataCamp
Mobile:<PHONE_NUMBER>


fix: remote development support

In the case of running with toolbox, it should be executed on the remote to be able to access the files and provide schema validation.
Fixes https://github.com/bilelmoussaoui/flatpak-vscode/issues/202

Thanks!


fix(amplify-codegen-appsync-model-plugin): make id field the first field

Make the id field the first field so arity of the constructor is maintained
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2923 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2923      +/-   ##
==========================================
- Coverage   61.93%   61.85%   -0.09%
==========================================
  Files         221      223       +2
  Lines       11310    11335      +25
  Branches     2199     2349     +150
==========================================
+ Hits         7005     7011       +6
- Misses       3997     4010      +13
- Partials      308      314       +6

Impacted Files
Coverage Δ

...psync-model-plugin/src/visitors/appsync-visitor.ts
84.67% <100%> (+0.7%)
:arrow_up:

packages/amplify-cli/src/context-extensions.ts
25.69% <0%> (ø)
:arrow_up:

...lify-graphql-types-generator/src/compiler/index.ts
90.32% <0%> (ø)
:arrow_up:

...y-graphql-types-generator/src/compiler/legacyIR.ts
96.72% <0%> (ø)
:arrow_up:

...ges/amplify-graphql-types-generator/src/loading.ts
74.5% <0%> (ø)
:arrow_up:

...mplify-appsync-simulator/src/mqtt-server/client.ts

...psync-simulator/src/utils/expose-graphql-errors.ts

...simulator/src/data-loader/dynamo-db/utils/index.ts

...y-appsync-simulator/src/resolvers/unit-resolver.ts

...sync-simulator/src/schema/appsync-scalars/index.ts
0% <0%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db20336...824c31a. Read the comment docs.


HSEARCH-4328 Refactor JSR-352 ITs for safer startup/shutdown

https://hibernate.atlassian.net/browse/HSEARCH-4328
Backported to 6.0 as #2660

Merged, thanks


Replace python-requests with urllib.request and use cache for sources_non_forked

Replaced python-requests with urllib.request from the standard library; for simple GET requests, both urllib and requests are equal in terms of boilerplate and performance, so this saves us the extra step of pip install requests.

update_plugins.py copies contents of sources_non_forked folder to sources_non_forked_cache folder (gitignored) if sources_non_forked_cache does not exist yet, so that if sources_non_forked_cache fails to update, it will still have the contents of the folder sources_non_forked as a fallback.
This eliminates the need to use git reset --hard and git clean -d --force in the update process. Addresses #615

Updated instructions for the above changes in README.md

Thanks a lot for this, @elliotwutingfeng
Could you please split this up into 2 PRs:

Replace python-requests with urllib.request

Use cache for sources_non_forked

is a no-brainer to include, but 2) is a bit more tricky as I am unsure which issue it resolves (other than changing the name)

Thanks, I've split the changes into PRs #717 and #718


[Extension Bug] Git Repos Extension - Something Went Wrong

Extension – Git Repos
Author: @moored
Description
Extension breaking, when selecting the List Repos, it shows something went wrong message instead of listing the repositories
Error: type mismatch at params.message : Expected to decode String but found a dictionary instead.

Steps To Reproduce

Select the List Repos in the Raycast app
Shows the Something went wrong message instead of listing the Repos

The current behavior
Show Something went wrong screen
The expected behavior
Should list the repositories
Raycast version
Version: 1.40.3

Working Now


Full read-over and revision.

Removed a section ... it now seems extraneous. It was the section linking to all sorts of things from Gideon Wulfsohn's document. That document is still linked-to at bottom of guide. Thing is, Wulfsohn revised his document too! He removed some stuff. Seems like I should too. Just the kind of thought that comes with revision I guess. You realize some things are contradictory. Putting in this "list of lots of cool things" countradicts some other arguments in the guide (i.e. more data beats a better algorithm).
Then I got on a roll. Kept reading and made various revisions.

(build failure is erroneous, see https://github.com/dkhamsing/awesome_bot/issues/46 )


Should fonts be included, or not?

In my Obsidian, I've got Settings > Editor > Default editing mode set to Source mode.
I use a CSS snippet to use Open Sans as interface and text font, and JetBrains Mono as monospace font.
The snippet then forces the editing view to use this monospace font for everything:

What do you think: should fonts be included in this theme? (Remember that users can always use Settings > Appearance > Font to override them.)

Please not!
I just installed Obsidian and try out some settings, and I am right now annoyed that a theme (solarized) changes the fonts (that are possible to change just a few centimeters away!).
I especially don't like that the normal text font is forced monospaced. Please don't.
Otherwise, thanks a lot for making this solarized theme for Obsidian :)

Wait, did that happen when you installed Solarized through Obsidian? Because I was under the impression that Obsidian uses the main GitHub branch, which does not include any fonts. (The dev branch does, so just in case, I'll delete that.)

#32 is fixed, and I'll close this discussion


Issue deploying on Windows 10

Trying to get this going on Windows, but running into an error:
2016-04-18 11:38:33:INFO:botocore.credentials: Found credentials in environment variables.
2016-04-18 11:38:33:INFO:lambda_deploy: Packaging lambda .env
Traceback (most recent call last):
  File "C:\Users\Joe\appdata\local\scoop\apps\python27\2.7.10\scripts\lambda-deploy-script.py", line 9, in <module>
    load_entry_point('lambda-deploy==0.0.1', 'console_scripts', 'lambda-deploy')()
  File "C:\Users\Joe\appdata\local\scoop\apps\python27\2.7.10\lib\site-packages\lambda_deploy\lambda_deploy.py", line 321, in main
    method()
  File "C:\Users\Joe\appdata\local\scoop\apps\python27\2.7.10\lib\site-packages\lambda_deploy\lambda_deploy.py", line 133, in deploy
    zfh = self.package(lambda_name)
  File "C:\Users\Joe\appdata\local\scoop\apps\python27\2.7.10\lib\site-packages\lambda_deploy\lambda_deploy.py", line 98, in package
    if 'requirements.txt' in os.listdir(src_dir):
WindowsError: [Error 267] The directory name is invalid: 'C:\\Dev\\python\\kodi-alexa-master\\.env/*.*'

This is my .env file:
AWS_ACCESS_KEY_ID=***********
AWS_SECRET_ACCESS_KEY=*****************
LAMBDA_ROLE=lambda_basic_execution
LAMBDA_TIMEOUT=30

It looks like it's trying to use .env as a directory that everything is in. Anything I can try?

Hmm, definitely a bug.  Two work around while I work on a fix:
One, put your lambda or lambdas in a separate directory and point the tool at that:
current_directory
  |- .env
  |- lambdas
      |- your_lambda_dir

Then in current_directory, run lambda_deploy like so:
$ lambda-deploy -d lambdas deploy

The other option, especially if you only have one to upload, is to specify the lambda:
$ lambda-deploy deploy your_lambda_dir

Also - I'm definitely interested to hear about your experiences on Windows - I haven't tested this there at all so I'd like to hear if it works.

Yeah, I tried that after I wrote the issue and it seemed to work.
Once I figured out how to use yaep to use the environment variables, this turned into a pretty great way to deploy to lambda, glad I found the project! Now I can't wait to get a version where I can have it in the same directory.

Should be a 0.0.2 version up now - let me know if this fixes the problem, thank!

It seems to fix the issue, but it just stops what it's doing:
$ lambda-deploy deploy
2016-04-18 14:32:21:INFO:botocore.credentials: Found credentials in environment variables.

Doesn't upgrade or anything.

So you have a layout like:
current_directory (where you run lambda-deploy from)
  | - .env
  | - your_lambda_directory

?

Or are you trying to upload from inside "your_lambda_directory"?

Trying to do it inside of the lambda directory if that's possible

Hmm. I'll have to give some though to that, I guess I didn't really think much about uploading individual Lambdas. I have a stable of them that I keep in a repo with the idea that the tool can run on a CI machine to deploy them on commit (obviously blindly just updating them all, but no big deal).
I guess I could have the "search" logic to find lambda folders only operate if you give the -d argument to specify a directory, and otherwise assume there's a single lambda in the current directory.
That'll probably take some time though. I'll look into it.


Add merge verification using Github actions

Done in https://github.com/makra89/Visual-Odometry-Cpp/pull/25


select canvas by index

I want to be able to select a canvas by index, not just by canvasID.
When both are given, canvasID is preferred.

@aeschylus This was submitted 8 hours go, but Travis is still not done, so it can't be merged.  Do you know what's going on?

This is really weird.

I'm not sure what's going on with travis, since this build doesn't even appear anywhere in the travis dashboard.
However, I think we should close this pull request, since this is not really the place for this functionality. This adds a kind of "shadow API" that is hard and inconsistent to document. An input should have only one type, and we should not be doing type checking and coercion inside the library code. Can we add a method like selectCanvasBySequenceIndex() instead?
I especially don't know why this check has to go in the initial setup code. Can't the programmer get the canvas ID himself and pass that in?
On the other hand, one advantage of using the sequence index is that canvas IDs don't have to be unique within a sequence (I believe that's right, though it would be strange to repeat them), so I could be convinced to switch it over to the index instead of the ID, but having that configuration field accept either seems strange.

We should continue to discuss in an issue. Closing for now.

I created an issue for this: https://github.com/IIIF/mirador/issues/999
I totally agree: only one attribute should influence the behaviour, either canvasID or canvasIndex.
I did not create this because I thought that the canvasID wasn't unique enough (it should, it is an identifier!). Here is my use case:
In the current situation, mirador is a multi-window environment. State cannot be saved so easily in the URL because of the complexity of this structured information. But in my case, I'm using Mirador in Zen Mode, i.e. with only one manifest open, and no options available to add/remove any windows.
In that case the state information is flat (is it?).
Of course, I cannot create a state controller specifically for Zen Mode, and assume that no windows will be added. So I disabled the state controller (because it assumes multi-window environment).
I saw that you can supply the openseadragon bounds to the windowObject configuration. So I fetched
this myself from the URL fragment added it to the configuration. But I cannot restore the canvas so easily without storing the canvasID in the URL. The canvasIndex seems like a cleaner,shorter and more safe way to do this.
This is what I propose: is there a way to influence the mirador instance before it starts rendering?
Now everything starts automatically after configuration. But if you add a method like "start", only in that case would a method like "selectCanvasByIndex" be usefull. Maybe a configuration option like "auto"?