Make FLTEnableImpeller to be configurable in the Flutter bundle

Currently we only accept the flag when it is in the info.plist file in the main bundle. The behavior this flag controls lives entirely within the Flutter bundle, so it seems natural to me that we should accept the flag in the Flutter bundle, like FLTAssetsPath. (Also it makes our internal infra easier by giving us more control.)

This came up with b/274227975 and may also impact add2app scenarios

FYI @zanderso

This is probably like a 4-5 character fix, but for testing in, I think I need to add something like https://github.com/flutter/engine/blob/main/testing/scenario_app/ios/AppFrameworkInfo.plist to https://github.com/flutter/engine/tree/main/testing/ios/IosUnitTests, so that I can modify the test at https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterDartProjectTest.mm#L76 to try the lookup in the Flutter bundle.
I suspect that @jmagman might be able to give me a hint, or let me know if I'm on the wrong track.

Something like this I think:
Hoist applicationBundle App.framework local variable up:
https://github.com/flutter/engine/blob/004d841b7efde6ae26cefa4c3ad5a4ad07cf644c/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm#L132
+  NSURL* applicationFrameworkURL =
+  [mainBundle.privateFrameworksURL<EMAIL_ADDRESS>+                                                     isDirectory:YES];
+  NSBundle* applicationBundle = [NSBundle bundleWithURL:applicationFrameworkURL];
  if (flutter::DartVM::IsRunningPrecompiledCode()) {

https://github.com/flutter/engine/blob/004d841b7efde6ae26cefa4c3ad5a4ad07cf644c/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm#L154-L159
    if (settings.application_library_path.empty()) {
-     NSString* applicationFrameworkPath = [mainBundle<EMAIL_ADDRESS>-                                                               ofType:@""];
-     if (applicationFrameworkPath.length > 0) {
-       NSString* executablePath =
-           [NSBundle bundleWithPath:applicationFrameworkPath].executablePath;
+     if (applicationBundle != nil) {
+       NSString* executablePath = applicationBundle.executablePath;

https://github.com/flutter/engine/blob/004d841b7efde6ae26cefa4c3ad5a4ad07cf644c/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm#L210-L212
Then use it to check its Info.plist:
-  NSNumber* enableImpeller = [mainBundle objectForInfoDictionaryKey:@"FLTEnableImpeller"];
+  NSNumber* enableImpellerMainBundle = [mainBundle objectForInfoDictionaryKey:@"FLTEnableImpeller"];
+  NSNumber* enableImpeller =
+      enableImpellerMainBundle != nil
+          ? enableImpellerMainBundle
+          : [applicationBundle objectForInfoDictionaryKey:@"FLTEnableImpeller"];
  // Change the default only if the option is present.
  if (enableImpeller != nil) {

There doesn't seem to be a test that checks if FLTEnableImpeller is YES, only a test that checks if it's NO (testEnableImpellerSettingIsCorrectlyParsed @zanderso pointed out).

@jmagman That looks a bit more robust than what I was thinking. I might have misunderstood that the code here:
https://github.com/flutter/engine/blob/e159e35fb29ca1ca29581d4f1c5124f4abd3b29d/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm#L93
Would find the Info.plist for App.framework, but I guess that only works if it has the "io.flutter.flutter.app" bundle identifier, which I guess isn't guaranteed?
Anyway, it seems like one of these ways will probably work, so what I'm wondering is whether there's a way to add an App.framework like thing to these unit tests https://github.com/flutter/engine/tree/main/testing/ios/IosUnitTests, so that I can test looking up the flag in the app bundle in a new test alongside testEnableImpellerSettingIsCorrectlyParsed.

Would find the Info.plist for App.framework, but I guess that only works if it has the "io.flutter.flutter.app" bundle identifier, which I guess isn't guaranteed?

I think lots of things would break if people changed that ID, so I think you're right you can use that bundle local (I didn't spot it, looks like in that other spot it's using a different way to find the same bundle.

what I'm wondering is whether there's a way to add an App.framework like thing to these unit tests https://github.com/flutter/engine/tree/main/testing/ios/IosUnitTests, so that I can test looking up the flag in the app bundle in a new test alongside testEnableImpellerSettingIsCorrectlyParsed.

I think you should be able to mock it out like this:
https://github.com/flutter/engine/blob/e159e35fb29ca1ca29581d4f1c5124f4abd3b29d/shell/platform/darwin/ios/framework/Source/FlutterEngineTest.mm#L305-L307
Do you want me to try to get that working?  I didn't when I saw it's assigned to @jonahwilliams but it seems like you're trying to solve it too 🙂


Seeing some inconsistency if I use two streams with different databases JDBC sink

Hi Team,
Hope you are doing well and safe, I see some inconsistency in JDBC sink application when I use it for two different streams with two different databases (Mysql and Postgres)
eg:
I got two kafka streams,
Stream 1: Mqtt (Source) --> Postgres (Sink)
Stream 2: Mqtt (Source) --> MySQL (Sink)
If I deploy anyone of the above stream its working perfectly I don't see any issues at all, but if I deploy both of them, the data from Mqtt is not inserting into the databases properly, even the call itself its not reaching the JDBC sink.
Please help me out.
Thanks in advance
Mathan

Hi, @leanadvocate. Perhaps you could expand your description with exact stream definitions in use, and the versions of all components. Specifically, also, it'd be useful to know what you mean by  "not inserting into the databases properly" - is the data are partially written or no writes at all? Is it consistently reproducible?

Oh, these are the old app's repo! Please try to upgrade and move over to the optimized and improved versions of applications at: spring-cloud/stream-applications.

Thank you for the response, I will provide the exact stream info along with other details in this location https://github.com/spring-cloud/stream-applications


4 2 stable

well, i didn't mean to, but pushing to this closed the branch... so i'm going to try again with my clean version for 4-2-stable.


Python script to solve the Sudoku efficently

Description

Type of issue

NOTE: These boxes can be checked using [X]

[X ] Feature (New Script)

[ ] Bug

[ ] Documentation

Checklist:

[X] I have read the project guidelines.
[X] I have checked all the existing projects, before submitting a new project issue.
[X] I have checked previous issues to avoid duplicates.
[X] This issue will be meaningful for the project.

hey @AdityaJ7 please assign this to me.

This is work i love you can assign me.

This is work i love you can assign me.

This has been assigned to someone else


Fix regressions introduced by the changes to make CI green

The differential output and the button->led path stopped working due to changes introduced to get CI green.

Closing this. The issue was with nextpnr-xilinx, not upstream db:
https://github.com/gatecat/nextpnr-xilinx/pull/50/files


Configuration from metro.config.js get overridden by CLI argument defaults

What happened?
I was moving some files around in an empty project and started getting a haste map error around the lines of ‘MyApp/src could not be found’. At some point, I had added a MyApp/src dir and moved index.js and App.tax in there, then moved them back out and deleted the folder. Thinking it was some weird cache issue, I spent a couple of days trying every trick in the book to clear my npm, pnpm, watchman, metro, and cradle caches.
Eventually I started stepping through the metro server code, trying to find out what cache file I had missed. Eventually though, I found out that the overriding value came from rnx kit.
I had my setting defined as follows:
In package.json, I did NOT define a property for the rnx kit server and bundle project root.
In my tsconfig, I did not specify any base urls, root dirs, etc.
In my metro config, I had my project root defined as __dirname (./MyApp).
The command I ran was react-native rnx-start, with no arguments, in ./MyApp.
What I expected to happen was that the override order was CLI args > package json rnxkit config > metro config. Since I left the first two empty, I expected the third to take effect.
However, it seems that the default values for the cli are taking precedence, over defined values in metro config. Seems to be in the below file?
https://github.com/microsoft/rnx-kit/blob/main/packages/config/src/getServerConfig.ts
I guess if this is expected behavior, it would be nice if the docs explicitly mentioned that certain values on metro.config will essentially be ignored, while others will work. Maybe a CLI warning too. Or maybe specify that it’s a default? Perhaps this is something inherited from metro, but if they have a default value for it I couldn’t find it.
I would also like to note that the react native community template for typescript doesn’t come with a src folder.
https://github.com/react-native-community/react-native-template-typescript/tree/master/template
I guess it’s a bit of an edge case since most everyone will make a src folder, but it is pretty confusing if someone tries to set up all their config and get it running before adding anything to the app template.
Affected Package
@rnx-kit/cli
Version
Latest?
Which platforms are you seeing this issue on?

[X] Android
[ ] iOS
[ ] macOS
[ ] Windows

System Information
➜  pnpx react-native info
info Fetching system and libraries information...
System:
    OS: Windows 10 10.0.19043
    CPU: (12) x64 Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz
    Memory: 13.00 GB / 31.95 GB
  Binaries:
    Node: 16.8.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.11 - C:\Program Files\nodejs\yarn.CMD
    npm: 7.21.0 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK:
      API Levels: 30
      Build Tools: 30.0.2, 31.0.0
      System Images: android-31 | Google APIs Intel x86 Atom_64
      Android NDK: Not Found
    Windows SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Visual Studio: 16.9.31205.134 (Visual Studio Professional 2019)
  Languages:
    Java: javac 15
  npmPackages:
    @react-native-community/cli: ^6.0.0-0 => 6.0.0
    react: 17.0.2 => 17.0.2
    react-native: ^0.65.0-0 => 0.65.1
    react-native-windows: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to Reproduce
Oops, forgot to push to the repro repo. Will do it tomorrow morning.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sorry this took so long to fix. I have a PR with a fix. If you have time, it would be great if you could check it out. Thanks again for reporting this ❤


[Bug] ValueError: Check failed: (f != nullptr) is false: Cannot find function vm.builtin.kv_state_clear

🐛 Bug

To Reproduce
Steps to reproduce the behavior:
FINE_TUNED_MODEL_NAME = "fine_tuned_science_gemma2b-it"
QUANTIZATION= "q4f16_1"
!python -m mlc_chat convert_weight /content/$FINE_TUNED_MODEL_NAME/ --quantization $QUANTIZATION -o /content/$FINE_TUNED_MODEL_NAME-$QUANTIZATION-MLC/
!mlc_chat gen_config /content/$FINE_TUNED_MODEL_NAME/ --quantization $QUANTIZATION \   --conv-template gemma_instruction --context-window-size 768 -o /content/$FINE_TUNED_MODEL_NAME-$QUANTIZATION-MLC/
!mlc_chat compile /content/$FINE_TUNED_MODEL_NAME-$QUANTIZATION-MLC/mlc-chat-config.json \     --device android -o /content/$FINE_TUNED_MODEL_NAME-$QUANTIZATION-MLC/$FINE_TUNED_MODEL_NAME-$QUANTIZATION-android.tar
Executed the prepare_libs.sh file.
Built the Android app by placing the JAR files in library.
Error:

app-config.json
mlc-chat-config.json

Expected behavior
Android app fails to run. It crashes with the error ValueError: Check failed: (f != nullptr) is false: Cannot find function vm.builtin.kv_state_clear.
Environment

Platform (e.g. WebGPU/Vulkan/IOS/Android/CUDA):
Operating system (e.g. Ubuntu/Windows/MacOS/...):
Device (e.g. iPhone 12 Pro, PC+RTX 3090, ...)
How you installed MLC-LLM (conda, source):
How you installed TVM-Unity (pip, source):
Python version (e.g. 3.10):
GPU driver version (if applicable):
CUDA/cuDNN version (if applicable):
TVM Unity Hash Tag (python -c "import tvm; print('\n'.join(f'{k}: {v}' for k, v in tvm.support.libinfo().items()))", applicable if you compile models):
Any other relevant information:

Additional context

Hey @NSTiwari thanks for reporting. It looks to me that this is because your TVM is not the latest. To help confirm, could you check if the line 34 of file 3rdparty/tvm/src/runtime/relax_vm/kv_state.cc is this line? https://github.com/apache/tvm/blob/f8b9a5faa440d594d125271383ebef4037a106ac/src/runtime/relax_vm/kv_state.cc#L34
If it is not, or this file does not exist, then it means your TVM is not the latest. You will need to do submodule update by
git submodule update --init --recursive

and run prepare_libs.sh and subsequent steps again.

@MasterJH5574: Thanks for the suggestion. Unfortunately, my computer doesn't support CMake and I've tried a lot with other devices as well but there are some compatibility issues with Java. Could you please run the prepare_libs.sh script on the latest TVM for the below app-config.json and the Android .tar file and provide me the output JAR files? I would really appreciate your help.
app-config.json
prebuilt.zip

@NSTiwari @MasterJH5574
after updating all modules, when running ./prepare_libs.sh , I am getting this error:
Traceback (most recent call last):
  File "/Users/rageshantonyd/Documents/working_prj/mlc-llm/android/library/prepare_model_lib.py", line 78, in <module>
    main()
  File "/Users/rageshantonyd/Documents/working_prj/mlc-llm/android/library/prepare_model_lib.py", line 37, in main
    available_model_libs = get_model_libs(lib_path)
                           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/rageshantonyd/Documents/working_prj/mlc-llm/android/library/prepare_model_lib.py", line 7, in get_model_libs
    global_symbol_map = ndk.get_global_symbol_section_map(lib_path)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'tvm.contrib.ndk' has no attribute 'get_global_symbol_section_map'

I am using Mac M2

@NSTiwari @MasterJH5574
after updating all modules, when running ./prepare_libs.sh , I am getting this error:
Traceback (most recent call last):
  File "/Users/rageshantonyd/Documents/working_prj/mlc-llm/android/library/prepare_model_lib.py", line 78, in <module>
    main()
  File "/Users/rageshantonyd/Documents/working_prj/mlc-llm/android/library/prepare_model_lib.py", line 37, in main
    available_model_libs = get_model_libs(lib_path)
                           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/rageshantonyd/Documents/working_prj/mlc-llm/android/library/prepare_model_lib.py", line 7, in get_model_libs
    global_symbol_map = ndk.get_global_symbol_section_map(lib_path)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'tvm.contrib.ndk' has no attribute 'get_global_symbol_section_map'

I am using Mac M2
I updated TVM to latest commit #16812
pip show tvm output states
Name: tvm Version: 0.16.dev984+g2dcf9ec5a

@MasterJH5574: Could you have a look?

@RageshAntonyHM: Probably, there's an update in the MLC LLM Python library. Recently, it got updated from "MLC Chat" to "MLC LLM".
Have you tried reinstalling them?
python3 -m pip install --pre -U -f https://mlc.ai/wheels mlc-llm-nightly mlc-ai-nightly

@MasterJH5574
I able to build the app and run it.
But when trying to run a finetuned model provided by @NSTiwari , I get this error:

jar libs:
libs 2.zip

Hello folks, sorry for the delayed response. Unfortunately I don't have enough bandwidth to build the android app. But you are more than welcome to coordinate here.
As for the issue @RageshAntonyHM you posted, I believe recompiling the model will address this issue. The issue is caused by a recent change in https://github.com/mlc-ai/mlc-llm/commit/9ecc00edd3cff739cfbd4ae781409d98060a8ac2, and recompiling the model helps resolve it.


Feature: Migrate Claudie configuration to CRDs

Motivation:
Migrate Claudie manifests to CRD objects.
Description:
The Claudie input manifest is currently a single input object carrying all the data. There might be a few benefits coming from a migration to CRD-based configs. This would reflect on the inputs (e.g. breaking into Provider, Nodepool, LB, K8s, DNS, Credentials, etc. CRDs) and perhaps on the outputs as well (not just a Kubeconfig output, but also status updates to the CRs, e.g. health and lifecycle statuses in Nodepool).
Exit criteria:

[ ] Propose a breakdown for input/output manifests into CRDs
[ ] Compile pros/cons as a part of this task
[ ] Implement the change accordingly

We will not pursue this topic for now. We see the main (eventual) benefit from the CRD-driven state in the UX aspects. However, currently the state is scattered across several components: MongoDB, DynamoDB, object storage. It would not be straightforward to migrate the state to CRDs.
Hence, setting this aside for now.

What we could do is to decouple only provider configuration to avoid secrets within the manifest:
kind: Secret
metadata:
  name: aws-creds
  namespace: aws
type: Opaque
data:
  access: xxx
  secret: xxx
---
apiVersion: claudie.io/v1alpha1
kind: ClaudieProvider
metadata:
  name: aws-1
spec:
  type: aws
  credentials:
    source: Secret
    secretRef:
      namespace: aws
      name: aws-creds

Then just specify the provider in the input manifest:
  dynamic:
    - name: control-aws
      providerSpec:
        name: aws-1
        region: eu-central-1
        zone: eu-central-1c
      count: 2
      serverType: t3.medium
      image: ami-0965bd5ba4d59211c

Or point provider configuration in input yaml to a kube secret:
providers:
  aws:
    - name: aws-1
      accessKey:
        valueFrom:
          secretKeyRef:
            name: aws-creds
            key: access
      secretKey:
        valueFrom:
          secretKeyRef:
            name: aws-creds
            key: secret

On today's grooming, we decided to transition input manifest into the CRD, where cloud provider secrets would be decoupled. The idea is to keep using k8s Secrets for cloud provider secrets and use input manifest CRD to actually define the desired infrastructure.
No plans are made in terms of transitioning the whole Claudie state into CRDs as of now.

Closing due to partial implementation of this issue. No more CRDs are planned as of now.


update documentation for onevnet_addressrange

The build failed on one set of ruby and puppet, but it is a build system error and only the Readme.md is updated (this shouldn't break anything ;) ). will merge now...


Add Dockerfile and push to Docker hub

Hello 👋
We use this CLI in CI and it would nice to have an official Docker image and build to use. Modern CIs like Concourse and Circle can easily use Docker images instead of having to curl bins.

Agree @arbourd!
If you'd like to contribute a Dockerfile, we can use it to create the image.

On it! 🤓


(Haskell) GADT syntax highlighted incorrectly

Describe the issue
The where keyword in the Haskell GADT syntax is not highlighted correctly
Which language seems to have the issue?
haskell
Are you using highlight or highlightAuto?
highlightElement
Sample Code to Reproduce
https://jsfiddle.net/8j5zb4ny/1/
Expected behavior
The where keyword at the end of the first line should get a different highlighting to show that it is not a type variable

Thanks for report.  PR would be welcome... probably just need to add where as a keyword inside a data block.

Hello!, I'm searching for some open source first issue and this one seems great, Can I work on this?

Sure.

I,ve checked everything and adding 'where' inside the data block as mentioned fixed this, also tested everything and everything seems fine, checking the PR :)).


Can't see stored files on the filer page

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Report issues here. Ask questions here https://stackoverflow.com/questions/tagged/seaweedfs
Please ask questions in https://github.com/chrislusf/seaweedfs/discussions
Describe the bug
I accidentally restarted the server cluster.the previously stored files are all there, but I can't see them on the filer page.
System Setup

List the command line to start "weed master", "weed volume", "weed filer", "weed s3", "weed mount".
I set up the file system according to the following steps,

OS version
linux centos7.6

Expected behavior
while I accidentally restarted the server cluster. I restarted the file system and performed the same steps as before.

the previously stored files are all there, but I can't see them on the filer page.

Can I still access the previous data in the old system, or the data is inaccessible in the new system？

find the folder filerldb2. If it is a restart, the folder should still be there.

I find the folder filerldb2，it was built during the old system. How can I get the data?


fix: update extmarks unconditionally

Fixes https://github.com/nvim-treesitter/nvim-treesitter-context/issues/509
But I am not sure if it is a good solution. Maybe it is better to check if the virtual text has changed? It will be harder to implement and probably will require creating special namespace for extmarks or maintaining list of extmarks for each context window.
@lewis6991, what do you think?

I'm not sure this is the best solution. My idea was just to have additional triggers, it won't catch everything, but the main one is just diagnostics which we can special case for now.

Are you suggesting providing an API that allows users to manually trigger a context update?

Potentially. Need to know the use cases first.

You'd need to open several windows and this would be more complicated.
Context already copies all the semantic tokens and extmarks.

Potentially. Need to know the use cases first.

I think manually trigger context in Telescope previewer is very cool and useful, combined with TelescopePreviewLoaded autocmd


CDN load

Hi,
I've seen that this module is available at cdnjs, nevertheless the re-tree module, which is a dependency, can not be found in any CDN.
Can you push also re-tree  to a CDN in order that we can load and use both modules via CDN?
Best regards,
José Gonçalves

Hi @JoseGoncalves,
I understand your issue.
I've created a request for that at cdnjs... if you'd like you can +1 - maybe it might get treated faster :)
I wish I could help more but I don't have any control over cdnjs.

On step closer - we have a pending Pull request

Got it :)
re-tree on CDNJS


Making file field as Optional

I've a form-data request for user signUp process.
The user can or can't upload it's picture it's optional.
I've created a api, with field types as form and for image as Uploadfile everything works perfect but it is making the image field as required.
Is it possible to make the file input as optional..
Do share any reference docs..

Can you add a minimal reproducible example? It's hard to help.

async def send_mail(sender:EmailStr=Form(...), recipient:List[EmailStr]=Form(...),content:str=Form(...),attachments:List[UploadFile]= File(...)):
I want to make attachments as optional

you could add like file: bytes =File(None) or file: bytes = File(b'') and check if its not none or empty like if file is not None: or if file:
async def send_mail(sender:EmailStr=Form(...), recipient:List[EmailStr]=Form(...),content:str=Form(...),attachments:List[UploadFile]= File(...)):
I nned to use UploadFile and when I replace it with  attachments:List[UploadFile]= File(None)
and run function without selecting file It gives me below error
{
"detail": [
{
"loc": [
"body",
"attachments",
0
],
"msg": "Expected UploadFile, received: <class 'str'>",
"type": "value_error"
}
]
}

Need help here on urgent basis..
Below is what I'm trying
async def send_mail(
sender:EmailStr=Form(...),recipient:List[EmailStr]=Form(...),content:str=Form(...),attachments:List[UploadFile]= File(...)
):
I'm using UploadFile as I've send to send file in attachments , this can be optional , so  when I replace it with attachments:List[UploadFile]= File(None), the docs makes it a optional field but if I didn't  select file It gives me below error
{
"detail": [
{
"loc": [
"body",
"attachments",
0
],
"msg": "Expected UploadFile, received: <class 'str'>",
"type": "value_error"
}
]
}
Any solutions or alternative will be helpful here..

what about this?:
async def send_mail(
sender:EmailStr=Form(...),recipient:List[EmailStr]=Form(...),content:str=Form(...),attachments:List[UploadFile]= File([])
):

what about this?:
async def send_mail(
sender:EmailStr=Form(...),recipient:List[EmailStr]=Form(...),content:str=Form(...),attachments:List[UploadFile]= File([])
):

if it is a list just set an empty list as default

If I didn't use uploadfile it would not give me a option to select file on doks then..
I didn't got you fully, can u explain in more detail.

what about this?:
async def send_mail(
sender:EmailStr=Form(...),recipient:List[EmailStr]=Form(...),content:str=Form(...),attachments:List[UploadFile]= File([])
):

if it is a list just set an empty list as default

I does not work. Any solution?

you could add like file: bytes =File(None) or file: bytes = File(b'') and check if its not none or empty like if file is not None: or if file:

It solved my problem

you could add like file: bytes =File(None) or file: bytes = File(b'') and check if its not none or empty like if file is not None: or if file:

It solved my problem

On my End is working icon: UploadFile = File(None)
   if icon:         if icon.filename:             pass

Currently, I am getting error when I tried to set multiple upload files optional but when I upload file/files then it’ll upload successfully.
Need to do - Upload multiple files when required but it should be optional.
Code:
... @query_router.post("/uploadfiles/") async def create_upload_files(files: Union[List[UploadFile], None] = None): if not files: return {"message": 'Files not attached'} return {"filenames": [file.filename for file in files]} ...
Tried to make multiple attachments optional using above code but it’s giving following error:
Error:
{ "detail": [ { "loc": [ "body", "files", 0 ], "msg": "Expected UploadFile, received: <class 'str'>", "type": "value_error" } ] }

Basically you should not use either None or `List[UploadFile], but use an empty list as default value. Try this:
@ query_router.post("/uploadfiles/")
async def create_upload_files(files: list[UploadFile] = []):
    if not files:
        return {"message": "Files not attached"}
    else:
        return {"filenames": [file.filename for file in files]}

solution :-  Optional[list[UploadFile]] = None

Basically you should not use either None or `List[UploadFile], but use an empty list as default value. Try this:
@ query_router.post("/uploadfiles/")
async def create_upload_files(files: list[UploadFile] = []):
    if not files:
        return {"message": "Files not attached"}
    else:
        return {"filenames": [file.filename for file in files]}

Thanks for reply.
I have run the suggested code:
@ query_router.post("/uploadfiles/")
async def create_upload_files(files: list[UploadFile] = []):
    if not files:
        return {"message": "Files not attached"}
    else:
        return {"filenames": [file.filename for file in files]}

After run code, I got following error:
{
  "detail": [
    {
      "loc": [
        "body",
        "files",
        0
      ],
      "msg": "Expected UploadFile, received: <class 'str'>",
      "type": "value_error"
    }
  ]
}

Thanks for reply. I have run the suggested code:
@ query_router.post("/uploadfiles/")
async def create_upload_files(files: list[UploadFile] = []):
    if not files:
        return {"message": "Files not attached"}
    else:
        return {"filenames": [file.filename for file in files]}

After run code, I got following error:
{
  "detail": [
    {
      "loc": [
        "body",
        "files",
        0
      ],
      "msg": "Expected UploadFile, received: <class 'str'>",
      "type": "value_error"
    }
  ]
}

Thanks for reply.
I have run the suggested code:
@ query_router.post("/uploadfiles/")
async def create_upload_files(files: Optional[list[UploadFile]] = None):
if not files:
return {"message": "Files not attached"}
else:
return {"filenames": [file.filename for file in files]}
After run code, I got following error:
{
"detail": [
{
"loc": [
"body",
"files",
0
],
"msg": "Expected UploadFile, received: <class 'str'>",
"type": "value_error"
}
]
}

solution :- Optional[list[UploadFile]] = None

Thanks for reply.
I have run the following code:
@ query_router.post("/uploadfiles/")
async def create_upload_files(files: Optional[list[UploadFile]] = None):
    if not files:
        return {"message": "Files not attached"}
    else:
        return {"filenames": [file.filename for file in files]}

After run code, I got following error:
{
  "detail": [
    {
      "loc": [
        "body",
        "files",
        0
      ],
      "msg": "Expected UploadFile, received: <class 'str'>",
      "type": "value_error"
    }
  ]
}

How are you calling the endpoint? It works on my end using curl.

How are you calling the endpoint? It works on my end using curl.

I'm calling endpoint through Swagger UI (http://<IP_ADDRESS>:8000/docs).

What is the generated curl that swagger gives you?

This is a swagger ui bug; rather than sending no files, it tries to send “something” as files.

This is a swagger ui bug; rather than sending no files, it tries to send “something” as files.

Any other solution?

Is it super required that you use Swagger? I mean, the API works as intended, it is just the medium that you use to aproach it that doesn't work. Using curl -X 'POST' 'http://<IP_ADDRESS>:8000/student_query/uploadfiles/' from a command line will work. If you want Swagger to work properly, then I would suggest opening an issue on that project.

ning an issue on that project

No super required but for testing I'm using it.
Thank you very much.


Setting default-host to something non-native displays infinite recursion error message

I've found that when you set the default-host in rustup to a non-native target, then running cargo and rustc prints an infinite recursion error.
Example (from a linux machine):
$ rustup toolchain list
stable-x86_64-pc-windows-gnu
stable-x86_64-unknown-linux-gnu (default)
$ cargo
<normal cargo help output>
$ rustc
<normal rustc help output>
$ rustup set default-host x86_64-pc-windows-gnu
$ rustup toolchain list
stable-x86_64-pc-windows-gnu (default)
stable-x86_64-unknown-linux-gnu
$ cargo
error: infinite recursion detected
$ rustc
error: infinite recursion detected

@Fiveside While it could possibly benefit from a more specific error message, this is not expected to work.

Yeah I realized that that shouldn't work sometime after posting this.  I've updated the issue so that its more focused on the error message generated.  Thanks @Diggsey !

I haven't been able to reproduce this so far. I made sure to install the windows toolchain with rustup install nightly-x86_64-pc-windows-gnu and to set the default to just 'nightly', but the error I see is:
error: toolchain 'nightly-x86_64-pc-windows-gnu' does not have the binary `rustc`


Is there any possibility that we support XDS static cluster

istiod auto generates several static xds cluster like xds-grpc, envoy_accesslog_service, zipkin and so on, but seems there is no way we can add static cluster dynamically, using envoyfilter or serviceEntry.
background:
some envoy feature need static cluster, like access log service: https://github.com/envoyproxy/envoy/issues/3660
we want enable access log service for some of pod, but not all(so we disabled enableEnvoyAccessLogService in mesh global config). then we tried use envoyfilter to add access log config to LDS, it's ok, but we can not find a way to generate the static cluster.
Is there any possibility that we support generate XDS static cluster?

See https://github.com/istio/istio/tree/master/samples/custom-bootstrap

See https://github.com/istio/istio/tree/master/samples/custom-bootstrap

this works for me, thank you @bianpengyuan, close this.


[BUG] - pool margin value not shown correctly in ledger-state

cardano-cli / cardano-node version 1.12.0 on master.
Registered a new stake pool on FnF network - specified non-zero margin (e.g. 0.75) when creating stake pool registration certificate. Followed the rest of the steps, submitted the transaction - pool record was created in ledger-state output (seen via cardano-cli shelley query ledger-state --testnet-magic 42 command).
Expected to see poolMargin field with the same value as was specified during pool creation - instead, poolMargin is listed as 0 for all stake pools.

@dcoutts The precision epsilon of the rational approximation was set to 1 in the parser.
Thus for most x in [0, 1] the best rational approximation of x in the interval [x - 1, x + 1] is 0/1.
This is fixed by setting epsilon equal to 0 and thus enforcing a machine precision rational approximation.
diff --git a/cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs b/cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs
index 2caff9dd..fd4302a7 100644
--- a/cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs
+++ b/cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs
@@ -1112,7 +1112,7 @@ pPoolCost =

 pPoolMargin :: Parser ShelleyStakePoolMargin
 pPoolMargin =
-  (\dbl -> maybeOrFail . Shelley.mkUnitInterval $ approxRational (dbl :: Double) 1) <$>
+  (\dbl -> maybeOrFail . Shelley.mkUnitInterval $ approxRational (dbl :: Double) 0) <$>
     Opt.option Opt.auto
       (  Opt.long "pool-margin"
       <> Opt.metavar "DOUBLE"

@dcoutts I have tested the fix with the pool margin set to the irrational Euler constant gamma = 0.57721 56649 01532 86060... The parsed pool margin approximates the Euler constant up to 15 digits as expected for double precision numbers.


[Bug]: task query fails when using postgres

Before proceeding, is there an existing issue or discussion for this?

[X] I have done a search for similar issues and discussions.

OS and version
Ubuntu 22.04
Open-RMF installation type
Source build
Other Open-RMF installation methods
No response
Open-RMF version or commit hash
humble
ROS distribution
Humble
ROS installation type
Binaries
Other ROS installation methods
No response
Package or library, if applicable
No response
Description of the bug
Using

rmf-web on deploy/hammer
postgres db

When going to the task tab, the task query fails
msg="<IP_ADDRESS>:43160 - \"GET /tasks?limit=10&offset=0&order_by=-unix_millis_start_time HTTP/1.1\" 500" level="INFO" ts="2024-06-19T22:12:36.182+0800" src="httptools_impl.py:474" funcName="send"
msg="Exception in ASGI application" level="ERROR" ts="2024-06-19T22:12:36.183+0800" src="httptools_impl.py:409" funcName="run_asgi" exc_info="Traceback (most recent call last):
  File "/home/aaron/.local/lib/python3.10/site-packages/tortoise/backends/asyncpg/client.py", line 36, in translate_exceptions_
    return await func(self, *args)
  File "/home/aaron/.local/lib/python3.10/site-packages/tortoise/backends/asyncpg/client.py", line 185, in execute_query
    rows = await connection.fetch(*params)
  File "/home/aaron/.local/lib/python3.10/site-packages/asyncpg/connection.py", line 621, in fetch
    return await self._execute(
  File "/home/aaron/.local/lib/python3.10/site-packages/asyncpg/connection.py", line 1659, in _execute
    result, _ = await self.__execute(
  File "/home/aaron/.local/lib/python3.10/site-packages/asyncpg/connection.py", line 1684, in __execute
    return await self._do_execute(
  File "/home/aaron/.local/lib/python3.10/site-packages/asyncpg/connection.py", line 1711, in _do_execute
    stmt = await self._get_statement(
  File "/home/aaron/.local/lib/python3.10/site-packages/asyncpg/connection.py", line 398, in _get_statement
    statement = await self._protocol.prepare(
  File "asyncpg/protocol/protocol.pyx", line 168, in prepare
asyncpg.exceptions.GroupingError: column "taskstate.data" must appear in the GROUP BY clause or be used in an aggregate function

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/aaron/.local/lib/python3.10/site-packages/uvicorn/protocols/http/httptools_impl.py", line 404, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/home/aaron/.local/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
  File "/home/aaron/.local/lib/python3.10/site-packages/fastapi/applications.py", line 269, in __call__
    await super().__call__(scope, receive, send)
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/applications.py", line 124, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/middleware/cors.py", line 92, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/middleware/cors.py", line 147, in simple_response
    await self.app(scope, receive, send)
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/exceptions.py", line 93, in __call__
    raise exc
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/exceptions.py", line 82, in __call__
    await self.app(scope, receive, sender)
  File "/home/aaron/.local/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/home/aaron/.local/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/routing.py", line 670, in __call__
    await route.handle(scope, receive, send)
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/routing.py", line 266, in handle
    await self.app(scope, receive, send)
  File "/home/aaron/.local/lib/python3.10/site-packages/starlette/routing.py", line 65, in app
    response = await func(request)
  File "/home/aaron/.local/lib/python3.10/site-packages/fastapi/routing.py", line 227, in app
    raw_response = await run_endpoint_function(
  File "/home/aaron/.local/lib/python3.10/site-packages/fastapi/routing.py", line 160, in run_endpoint_function
    return await dependant.call(**values)
  File "/home/aaron/workspaces/rmf/demos-tasks/packages/api-server/api_server/routes/tasks/tasks.py", line 199, in query_task_states
    return await task_repo.query_task_states(query, pagination)
  File "/home/aaron/workspaces/rmf/demos-tasks/packages/api-server/api_server/repositories/tasks.py", line 155, in query_task_states
    results = await query.values_list("data", flat=True)
  File "/home/aaron/.local/lib/python3.10/site-packages/tortoise/queryset.py", line 1489, in _execute
    _, result = await self._db.execute_query(str(self.query))
  File "/home/aaron/.local/lib/python3.10/site-packages/tortoise/backends/asyncpg/client.py", line 38, in translate_exceptions_
    raise OperationalError(exc)
tortoise.exceptions.OperationalError: column "taskstate.data" must appear in the GROUP BY clause or be used in an aggregate function"

It works well with sqlite, if we launch the api-server normally, pnpm start
Steps to reproduce the bug

Setup an empty postgres DB
Modify rmf-web/packages/api-server/psql_local_config.py to point to the DB
pnpm install to setup per normal
Start the dashboard, cd rmf-web/packages/dashboard, pnpm run start:react
Start the api-server using pnpm run start:psql
On the dashboard, click on the Task tab
The error will show up in the api-server terminal while the dashboard fetching doesn't work

Expected behavior
Task states to show up
Actual behavior
Continues to query, where each query fails
Additional information or screenshots
No response

Commits before https://github.com/open-rmf/rmf-web/pull/949 is working

Just disable label sorting for now I guess. The bigger issue is that there is a chance a fix for this will not work in sqlite, then we need to either drop sqlite or maintain separate code paths. Or it could be that this is a tortoise/async-pg bug, need to try on main to see if that is the case.

yeah unfortunately it is happening on main too, so this is perhaps some missing generations on postgres' side, leaving the logs here, https://gist.github.com/aaronchongth/004c3ecfb713aa1565774c20b450b446
Removing sorting via labels, will that affect filtering? If I would like to filter via __contains instead of exact matches?


Added homebrew installation instructions

I think you're supposed to modify dependency-check-cli/src/site/markdown/index.md.vm in the master branch, instead.

Ah - I was looking for that - you can reject the patch, then.


Is directories option only to create directory or can I recursively copy?

In https://github.com/coreos/fcct/blob/master/docs/configuration-v1_0.md - storage --> directories is it used to only create empty directories?  Is there a way to recursively copy a directory say from S3 location

directories only creates empty directories.  You can create a bunch of directories and files objects to copy a directory tree from S3, but you'd have to list them explicitly; there's currently no way to have Ignition automatically perform the recursion.

Got it.  Thanks for clarification.


Add option to only add prefixes to the .css output when working with .scss/.sass?

It'd be great if the prefixes were only added to the .css file after/upon save as it would keep the .scss file about half the length and maintain readability. (lots 'o' prefixes with last 999 versions)

If you use Sass, you already have a build system, so it would be better to just integrate Autoprefixer into that than using this plugin.


Optional prop

Hi,
Can you please make "groupProps", "divProps" props of Html component optional?
Is there a reason why they must be presented?

No, fixed it with<EMAIL_ADDRESS>Please try it.


Remove hound in favor of pronto

Coverage remained the same at 75.568% when pulling 213d724fc877042e130676fcd9ff1211f881b9d2 on tasks/remove-hound into c711a86b77b779b939f615f4824004978f7c900d on master.

This PR makes me smile in your direction, @enriikke

I knew you would appreciate it @iamdustan 😄

@chrisman I think we could probably merge this one, it's just removing the .hound.yml. Doesn't look like we are using that anyways


Containers do not support pixel perfect input

Version

Phaser Version: 3.16.2
Operating system: macOS
Browser: Safari

Description
Containers do not seem to work correctly with pixel perfect input. I would expect them to iterate their children and perform a hit test on all of them recursively or something like that, but I don't think that's happening.
In the console, I see a stream of errors like this:

Example Test Code
Just make a container and add a sprite or two and then do myContainer.setInteractive({ pixelPerfect: true })

It's because a Container doesn't have a texture. When you interact with a Container it expects the container itself to have a hit shape defined, and it is this that's used for input detection, not the children. I will add a condition so that if you do specify pixelPerfect on a container it just ignores it, to avoid the error above, but there's no way it'll actually work.

I poked around some more in the code to see what you mean and found the function that seems to do the work here: https://github.com/photonstorm/phaser/blob/master/src/input/CreatePixelPerfectHandler.js
Based on this, I think I came up with a way it could work. This might not be comprehensive, and I'm sorry this isn't in exactly the same code formatting you use, but what about something like this?
function CreatePixelPerfectHandler (textureManager, alphaTolerance) {
  function pixelPerfectHitTest (hitArea, x, y, gameObject) {
    // if this gameObject has a texture and a frame, then it is something we can query for pixels - so do it and return the result
    if (gameObject.texture && gameObject.frame) {
      const alpha = textureManager.getPixelAlpha(x, y, gameObject.texture.key, gameObject.frame.name)
      return (alpha && alpha >= alphaTolerance)
    }

    // see if the gameObject might be a Container, and if it is, check the children looking for a hit
    if (gameObject.list) {
      for (const child of gameObject.list) {
        if (pixelPerfectHitTest(hitArea, x + child.displayOriginX, y + child.displayOriginY, child)) {
          return true
        }
      }
    }

    // we could find nothing that was hit
    return false
  }

  return pixelPerfectHitTest
}

The problem is that this makes some assumptions that go against how everything else works. Containers have never hit tested their children and shouldn't start doing so now really.
However, you can do exactly what you want already. Remember that when you call setInteractive() on a Game Object you don't have to give it a shape, you can give it a function instead. If you were to give it your modified pixelPerfectHitTest function above, then it would use that when hit testing the Container, which would give you the result you need in this specific case.


getting started doc

Hi,
i'm newer to pwa, is there any doc/example for getting started? is there "registerServiceWorker.js" like vue cli? where to put the "maniestfest" file? Thanks a lot for your great help.

sw.js error in console after build for production, "cannot use import statement outside module" ,"failed to register service worker"

example:
https://github.com/antfu/vitesse/blob/8e492449b6a0caebab183d07f9fee0ff3cb09a5e/vite.config.ts#L58-L76


Bug： Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'arb_id')

controller-a03b04ebe66d2345eb5c2670f9f98387.js:1 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'arb_id')
at ws (controller-a03b04ebe66d2345eb5c2670f9f98387.js:1:239287)
at controller-a03b04ebe66d2345eb5c2670f9f98387.js:1:240705

When I open the proxy, I will report the error！！！

Which server and client are you using? Which proxy are you referring to?

您使用的是哪个服务器和客户端？你指的是哪个代理？

Which server and client are you using? Which proxy are you referring to?

hello , I use the "payment-element".  Use the computer's proxy tool to proxy a test domain name.

Which server and client are you using? Which proxy are you referring to?

You can set up your own proxy to try！

Which server and client are you using? Which proxy are you referring to?

No problem, I found it was because I blocked a link！Thanks


Async API?

Would be great to see an async API wrapper option here. For some context on my use case: I'm looking to set up a weather station using this sensor. My main board is a Raspberry Pi Pico W, which requires special setup for the WiFi chip, and I'm using embassy for this, which is a fully async runtime.

Hello @tazz4843, I'm not opposed to this but I have to admit that I did not have worked with embassy so far. Could you sketch out how an async API for this sensor should look like? Or do you have a good example of such an async API you could point me to?
Is diy-weather-station the project in question?

embassy implements embedded-hal-async traits for all its HALs so such an API could match the sync API 1:1, just with an async implementation of the I2C bus instead. I haven't dug much into the code, but I doubt it would be difficult for me to make a PR if that's something you'd want.
Yes, that's the project in question, however most of the code is only locally on my computer and hasn't been updated on GitHub in a while.

See #2


Add Magic Leap One Support

Overview
In accordance with MRTK mission of openness and broad Cross-platform support, please add official support for Magic Leap One. ML1 is the closest device to HoloLens 2 for devs without access to one yet. Considering the recent hardship Magic Leap is going through, it would be particularly meaningful for Mixed Reality developers that relied on ML dev tools who are now facing uncertainty and the Mixed Reality community at large.
There is existing preliminary work available such as: Eric Provencher’s fork here. However, official support would provide Much needed functional parity and stability

You may be interested to know that Magic Leap announced a fork of the MRTK a couple of days ago. Hopefully this can get integrated at some point.
The XRTK already seems to have support for it.


Missing latest-public value for xcode-version

We have set up xcode-version: latest-stable, but AppStore Connect didn't want to release our version, because it was't build with latest public Xcode version.

Then I realized, that the build was done with Xcode 16 RC version.

Based on the doc there is no other option besides latest and specific version (sub-versions).
So I would suggest to have the option to set up latest-public value for xcode-version to be able to have this setup at least for production releases.

I am experiencing the same issue. Have you found a solution yet?

Same issue too. Any solution?

Also It looks like Apple stopped marking versions with GM and it is now Release  [source]
@maxim-lobanov I've noticed that you are using that in XcodeVersionReleaseType in the code.

@jendaz its working for us with the new GitHub runner, there is no need to update the action.


Add missing space in clean-conversation-headers

fixes #3483

Is the space necessary? Can you post a screenshot of the before and after?

Ah I saw your issue now. PRs should include “fixes #issue”. Please follow the PR template

Right, sorry. I thought mentioning it in the commit is enough but you're right, it says so in the template. Screenshot is in the issue

Thanks! Appreciated


File LastWriteTime appears identical between objects but tests as inequal

Steps to reproduce
given two files with the same LastWriteTime
>Write-Host $null > ./foo

>Write-Host $null > ./bar

>(Get-Item ./bar).LastWriteTime = (Get-Item ./foo).LastWriteTime

>(Get-Item ./foo).LastWriteTime

Thursday, August 15, 2019 11:59:38 AM

>(Get-Item ./bar).LastWriteTime

Thursday, August 15, 2019 11:59:38 AM

Expected behavior
>(Get-Item ./foo).LastWriteTime -eq (Get-Item ./bar).LastWriteTime

True

Actual behavior
>(Get-Item ./foo).LastWriteTime -eq (Get-Item ./bar).LastWriteTime

False

Environment data
Name                           Value
----                           -----
PSVersion                      6.2.2
PSEdition                      Core
GitCommitId                    6.2.2
OS                             Darwin 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

It appears that the milliseconds of the DateTime is not being copied. I confirmed the DateTimes actually are different:
> (Get-Item ./foo).LastWriteTime.Millisecond
812
> (Get-Item ./bar).LastWriteTime.Millisecond
0

So perhaps the bug is with copying DateTime objects, or assigning it through {file}.LastWriteTime = {file}.LastWriteTime

Possibly related: https://social.technet.microsoft.com/Forums/ie/en-US/cdae9a4b-b2d2-4e05-8988-9fe9881a1c11/file-lastwrite-times?forum=winserverpowershell
This does not feel like intended behavior.

I think this is a .NET Core issue, not a PowerShell issue. The objects underlying the cmdlets here that you're working with are managed by .NET Core, so if there's a bug in the property that occurs when it is set, there's not much PS can do to resolve it.
You may want to put together a small C# repro and file an issue in https://github.com/dotnet/corefx

@vexx32 thanks for the advice! I'll close this and open a .NET Core issue.


Create User Tables

See #1
Create Portfolio Manager and Field Partner user tables.

Finished creating user tables.


Make the algorithm actually produce smart behavior

First, I'd like to say that this is interesting, but if this works this will turn into a societal issue.
If you claim that you can predict human behavior then you open the door to preferential treatment of distinct groups.
Second, I think you have a core issue, which if solved, would enable this.
Please understand that this is a modestly informed opinion, and there are likely better ones, but I thought this was intriguing and wanted to lay this out as a potential solution.
That core issue is building an idea of how to trust, and action from, another agent. This will allow you to have agents which can then be rewarded as a function of "I see you and the way you think. You are more successful than me. This is my reward. This is yours." This would be connected directly to an action which moved their parameter weights as a function of the parameter space. Basically, which of your weights do I want to take, and how much.
In code, this would be reasonably easy.
Produce an array of agent weights, map along the actions as a float from zero to one, and then do an 'move x percentage change toward this number' as a function of my nets weights.
Ensure that you've got some samples of an agent doing 'something' (an array of their internal agent hyperparameter values, all current net weights, and a unique identifier per agent) and agents can differentiate that they can trust higher rewarded agents. I would recommend a sample construction strategy such that a linear trend was seen with respect to overall mean change and reward, but a downward trend seen with age. This would provide a sample space for the agents to begin training with, which can allow for learning to trust and adopt behavior patterns.
I think this is very doable, and that following the sampling strategy from above as you train your agents they can see their 'regret' in which they see 'if I changed, this would be my reward', which can allow them to differentiate trust on a by agent basis in a society.
That allows you to associate trust in named agents.
To short circuit this and prevent unnecessary training, ensure that all agents are drawing from a single pool of experience at training time to start, which then transitions to individual experience.
That will allow you to first gradient climb to a point where you can associate trust across a society.
At that point you then need to begin punishment as a random function of the number of times the agent has undergone a transition. This needs to enforce terminal reward signal as the random function approaches higher input.
This will provide the idea of 'sooner or later, you have to just be yourself', while still allowing for change to happen.
An agent which very strongly believes they can change in a better way by changing their weight sets will then still be able to gradient climb by weighting, but there will arrive a decision point where undergoing this change could produce less reward over an infinite timespan than not.
Now you've provided for a differentiable reward signal with respect to societal trust coupled to agent experience.
Ensure that you produce a terminal state as an increasing random function of experience during training only. I would highly recommend that the agent reward, at some point, is a function of rewarding some optimum balance of individuality across the population. You want to allow cliques, but prevent a population of loners, and definitely prevent the hive mind.
Now you've got individualized experience and your agents have a personality, but their actions still feed the communal pool of experience.
This allows for a racial memory which you can keep manageable by randomly dropping items as a function of experience history.
Be careful when you're doing this and ensure that your drop would never shift the base model of the relationship of trust to reward. This prevents your agents from unlearning trust.
I predict that at this point you will see societal structure evolve and you could monitor at this point.


How to install?

$ pip install nustack
...ImportError: no module named nustack
$ cd /path/to/downloaded/copy/of/nustack/
$ pip install nustack
...ImportError: no module named nustack

Am I missing something?

Somehow I messed up setup.py... Pypi version is broken. I'm trying to fix this right now, but I'm having trouble.

I changed the readme install instructions,


Not clear when execute a new console.log

With this code:
spinner.start();
console.log('Foo')

The result is:
/ Foo
"spinner this"

Ever new console.log, some part of spinner continue in terminal, how I solve this !!
thx

See this as well. It clears if I put spinner.stop(true); before the console.log(...) but not after.


Fixed bug where settings a custom urlOpener no longer worked

Hi, when will this be merged? The urlOpener is not working at all. Thanks.


x/build: one ppc64le osuosl builder is configured differently from the rest, causing failures

This is related to #48554, it would appear some power9 builders are configured differently.
Sometimes the test to open /dev/rtc0 is either skipped or passes, and sometime it fails. It is not clear if this test was always skipped previously (e.g the builder had no RTC device, or was prohibited from opening it, or has an RTC which supports alarms).
Are all the power9 builders provisioned and configured identically? Likewise, is it possible to tag golang.org/x/sys CI logs with more information about which builder they have run on (I am not sure if I am overlooking this one)?
Thanks!

@laboger fyi.

@bcmills We have found that the failures from #48554 were due to this rogue p9 builder that is not set up like the others so fails in a different way. This builder is not documented and not set up like the others. This builder should be stopped/disabled so people don't waste time tracking down bugs on this builder.

CC @dmitshur @toothrot

I would like to shutdown the go-ppc64le-p9 builder. Does anyone object? Also, what steps are needed to deactivate a builder?

@pmur I'm not seeing go-ppc64le-p9 on farmer.

I 'm not seeing go-ppc64le-p9 on farmer.

We had opened a ticket with OSU and Paul asked them to delete it. It is gone now and it looks like all is working as expected.
The builders now match what is documented in x/build/env/linux-ppc64le/osuosl/NOTES.

Thank you!

Closing since I understand this is all resolved, thanks again!


Concurrent rewrite for KnnVectorQuery

Description
Issue #11862
Solution
AbstractKnnVectorQuery currently performs HNSW searches (one per-segment) iteratively
Since this is done in a single thread, we can make it concurrent by spinning off per-segment searches to different threads (and make use of available processors)
The actual search is performed in Query#rewrite, and support to allow concurrency there was added recently (#11838) by passing an IndexSearcher (which wraps an IndexReader and Executor)
Proposing to achieve this by CompletableFuture:

If the Executor is not set, we can perform a blocking call to CompletableFuture#completedFuture
Else we submit the task of per-segment search to the Executor using CompletableFuture#supplyAsync

As a follow up here: We can also dive into breaking the per-segment search into sub-tasks, and make use of work-stealing thread pools (if one thread completes search in a smaller graph, it can "steal" some work from another thread that is performing a larger search by picking up some of it's sub-tasks)
One thing to note here would be that sub-tasks must be large enough so that overhead from sub-task creation, thread switching, etc. does not cause performance drops instead
Any suggestions?

I ran some benchmarks as well (Columns 2-4 are latency in ms):
enwiki (topK = 100, segment count = 10)

recall
Sequential
CompletableFuture
SliceExecutor
nDoc
fanout
maxConn
beamWidth

0.995
1.00
0.31
0.32
10000
0
16
32

0.998
1.33
0.37
0.38
10000
50
16
32

0.998
1.09
0.31
0.32
10000
0
16
64

0.999
1.43
0.37
0.40
10000
50
16
64

0.995
0.99
0.29
0.31
10000
0
32
32

0.998
1.31
0.35
0.37
10000
50
32
32

0.998
1.05
0.29
0.31
10000
0
32
64

0.999
1.40
0.36
0.38
10000
50
32
64

0.987
1.73
0.39
0.41
100000
0
16
32

0.992
2.37
0.49
0.52
100000
50
16
32

0.993
1.92
0.41
0.44
100000
0
16
64

0.996
2.57
0.53
0.56
100000
50
16
64

0.987
1.74
0.39
0.41
100000
0
32
32

0.992
2.34
0.50
0.52
100000
50
32
32

0.994
1.98
0.42
0.45
100000
0
32
64

0.997
2.68
0.54
0.57
100000
50
32
64

0.971
2.76
0.56
0.46
1000000
0
16
32

0.982
3.75
0.72
0.60
1000000
50
16
32

0.985
3.26
0.61
0.55
1000000
0
16
64

0.991
4.24
0.80
0.64
1000000
50
16
64

0.973
2.80
0.58
0.51
1000000
0
32
32

0.983
3.88
0.75
0.62
1000000
50
32
32

0.986
3.33
0.65
0.57
1000000
0
32
64

0.992
4.57
0.85
0.70
1000000
50
32
64

enwiki (topK = 100, segment count = 5)

recall
Sequential
CompletableFuture
SliceExecutor
nDoc
fanout
maxConn
beamWidth

0.991
0.59
0.28
0.23
10000
0
16
32

0.996
0.84
0.34
0.27
10000
50
16
32

0.997
0.62
0.28
0.23
10000
0
16
64

0.999
0.89
0.35
0.31
10000
50
16
64

0.991
0.60
0.26
0.21
10000
0
32
32

0.995
0.81
0.35
0.26
10000
50
32
32

0.997
0.65
0.27
0.22
10000
0
32
64

0.999
0.86
0.36
0.29
10000
50
32
64

0.978
0.97
0.36
0.29
100000
0
16
32

0.987
1.29
0.47
0.38
100000
50
16
32

0.989
1.08
0.40
0.31
100000
0
16
64

0.994
1.46
0.52
0.41
100000
50
16
64

0.977
0.98
0.36
0.31
100000
0
32
32

0.987
1.32
0.49
0.37
100000
50
32
32

0.989
1.14
0.40
0.34
100000
0
32
64

0.994
1.55
0.56
0.42
100000
50
32
64

0.957
1.54
0.57
0.45
1000000
0
16
32

0.972
2.07
0.70
0.60
1000000
50
16
32

0.976
1.71
0.61
0.53
1000000
0
16
64

0.985
2.33
0.76
0.65
1000000
50
16
64

0.959
1.58
0.57
0.45
1000000
0
32
32

0.974
2.17
0.73
0.63
1000000
50
32
32

0.978
1.88
0.65
0.53
1000000
0
32
64

0.987
2.57
0.83
0.69
1000000
50
32
64

enwiki (topK = 100, segment count = 1)

recall
Sequential
CompletableFuture
SliceExecutor
nDoc
fanout
maxConn
beamWidth

0.941
0.23
0.25
0.21
10000
0
16
32

0.970
0.24
0.27
0.25
10000
50
16
32

0.965
0.19
0.23
0.20
10000
0
16
64

0.984
0.27
0.28
0.28
10000
50
16
64

0.941
0.17
0.20
0.17
10000
0
32
32

0.970
0.23
0.27
0.24
10000
50
32
32

0.966
0.20
0.22
0.20
10000
0
32
64

0.985
0.26
0.29
0.28
10000
50
32
64

0.909
0.26
0.29
0.28
100000
0
16
32

0.945
0.36
0.38
0.38
100000
50
16
32

0.944
0.30
0.32
0.31
100000
0
16
64

0.969
0.42
0.43
0.43
100000
50
16
64

0.914
0.28
0.30
0.29
100000
0
32
32

0.948
0.37
0.43
0.44
100000
50
32
32

0.949
0.31
0.35
0.31
100000
0
32
64

0.972
0.41
0.48
0.43
100000
50
32
64

0.870
0.35
0.38
0.36
1000000
0
16
32

0.911
0.48
0.51
0.50
1000000
50
16
32

0.913
0.40
0.43
0.42
1000000
0
16
64

0.945
0.55
0.59
0.57
1000000
50
16
64

0.881
0.38
0.43
0.39
1000000
0
32
32

0.919
0.52
0.57
0.55
1000000
50
32
32

0.923
0.45
0.50
0.47
1000000
0
32
64

0.954
0.62
0.67
0.65
1000000
50
32
64

I used KnnGraphTester for this benchmark with two changes:

Used elapsed time instead of totalCpuTime (which measures time for which the main thread was running). This is important because the main thread may be "waiting" on executor threads to finish, and not count towards overall latency
Added an executor: Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()) to the IndexSearcher object, to "make use" of concurrency

Please let me know if this sounds fine?
As expected, the speedup is higher for larger number of segments since they are taken up in parallel. I have also tried to measure the overhead of searching from a single segment

I foresee backporting this to 9.6. Unless @kaivalnp @jpountz or @zhaih object.

+1 to backporting

@benwtrent I think the concurrent rewrite API change is only at Lucene10 right now, it is a bit tricky to backport it to 9x and not yet done as discussed in the previous PR I linked.

Thank you for the context @zhaih, Do you mind then guiding this PR through the merging and potential backporting process?
Backporting would indeed be blocked until your change can be backported at some point.

Do you mind then guiding this PR through the merging and potential backporting process?

Yeah I can help with that, I would suggest let's keep it in Lucene 10 for now, and if the previous PR is able to be backported to 9x in the future, I'll remember to backport this PR as well (along with the CHANGES.txt entry moving to appropriate place)

May this failure relevant to this
https://jenkins.thetaphi.de/job/Lucene-9.x-Linux/8927/testReport/junit/org.apache.lucene.search/TestKnnFloatVectorQuery/testDocAndScoreQueryBasics/
java.lang.IllegalStateException: This DocAndScore query was created by a different reader
	at __randomizedtesting.SeedInfo.seed([125C1E79EB05AAC5:3BA19DF38099A68]:0)
	at org.apache.lucene.search.AbstractKnnVectorQuery$DocAndScoreQuery.createWeight(AbstractKnnVectorQuery.java:298)
	at org.apache.lucene.search.TestKnnFloatVectorQuery.testDocAndScoreQueryBasics(TestKnnFloatVectorQuery.java:204)

??

May this failure relevant to this
https://jenkins.thetaphi.de/job/Lucene-9.x-Linux/8927/testReport/junit/org.apache.lucene.search/TestKnnFloatVectorQuery/testDocAndScoreQueryBasics/

I don't think so: The build seems to be for branch_9x (link to job information), which does not have this change
The Revision of the build also shows the latest commit on that branch, where this commit is not present
Please let me know if I'm missing something?

Question on this change: index searcher parallelizes search over leaf slices, while the concurrent rewrite for knn vector query will request one thread per segment. Is this on purpose or should the concurrent rewrite also leverage the slices for its parallelism?

I think the concurrent rewrite should act the same way(one thread per
slice) ideally. Do you want to open a PR on that? Or open an issue and I
can probably work on it recently
On Tue, May 23, 2023, 13:42 Luca Cavanna @.***> wrote:

Question on this change: index searcher parallelizes search over leaf
slices, while the concurrent rewrite for knn vector query will request one
thread per segment. Is this on purpose or should the concurrent rewrite
also leverage the slices for its parallelism?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/lucene/pull/12160#issuecomment-1560097486, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFSB7AKDU5Z6CZPHOGLLPDXHUOLTANCNFSM6AAAAAAVBHNVRE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

I opened #12325 .


William/brownie implement

I would to have these new tests run in Github actions along side the existing hardhat based one.

Add something like this to .github/workflows
https://github.com/brownie-mix/github-actions-mix/blob/master/.github/workflows/main.yaml


artwork list - price section

does not show the price but shows the artists name

@aghpr Duplicate related to filters


Processor#show_related_resources pass options to result if they are calculated

same behaviour as for Processor#find

@senid231 Thanks!


Enable indexing Dimension by Axis

Fixes #111
Due to coherence rules I've had to use a macro. Looks like it works fine.

It seems this is not enough for it to be useful with just D: Dimension? Maybe there is another way, so that we don't have to make this interface public. My idea is that it should not be a part of ndarrays external API.

Yes avoiding to expose this too much would be nice, but I don't know if it's possible. Right now I have no idea how to restrict this.

We can add a new method to Dimension (or two).

Right, simply being able to use a.dim().index(axis) would be nice.

The methods are added to the trait now. I haven't added doc for them yet, but I will.

Looks good. This gives me food for thought regarding the issue of hiding these implementation details. Dimension is good because we can use it to specialize each method while also providing a general implementation. But that's a larger question outside of this PR.

I added some documentation on these new members.

Thank you!

You're welcome.


Allow adding holes with same orientation as base face

Taking the opportunity for a suggestion. As it stands, Topolys requires that parent applications/wrappers (e.g. TBD) send (as input) holes with wire normals inverted with respect to their parent face. IMO, if a parent application "gets" (i.e. creates) a Topolys face with "holes" (i.e. an array of wires) as input (i.e. the intention is clear enough), Topolys should be able to evaluate if such holes are inverted or not, and invert those that aren't. This looks like internal logic to Topolys, and therefore such functionality (e.g. evaluation, inversion) should - in my opinion - reside within Topolys code. The operation is simple enough (.reverse).

A possible prerequisite: there's a need to better understand the role of Topolys "holes". Strictly there to accommodate subsurfaces? Or maybe also rare cases such interior courtyards (as seen from above), with a single roof surface encompassing all 4x sides of the courtyard? In small-scale residential, it may be plausible to have a single roof surface encompassing all 4x sides of a courtyard, but doubtful for anything larger (the roof surface would usually be broken up into multiple, non-holed surfaces as a function of spatial zoning). So I can appreciate the usefulness of "holes" for the courtyard cases. Yet If only there to accommodate subsurfaces, maybe holes should be entirely internal to Topolys, as it should - ideally - detect (internally) surface overlaps, surfaces eclipsing other surfaces (100% glazed walls), surfaces "holding" other surfaces without edge collision (more traditional punched windows), and so on. That's something to consider in the future.

Changed convention so holes are same winding as faces, this is more convenient for OpenStudio.  Can open a new issue if we need to support reverse winding.


Feat: Super users can delete discord group roles

Date: 04 Nov 2024

Developer Name: @VaibhavSingh8

Issue Ticket Number

Closes #2191

Description

This PR implements the ability for super users to delete Discord groups through the /groups endpoint on the dashboard site. This feature allows for better group management.

Added the deleteGroupRole model function to handle the soft deletion of group roles in the Firestore database.
The deletion is implemented as a soft delete, setting isDeleted: true along with deletion metadata.
Implemented controller logic to handle deletion requests, verify role existence, log deletion events for audit, and manage responses with appropriate status codes.
Added comprehensive test coverage for both success and error scenarios.

Documentation Updated?

[ ] Yes
[x] No

Under Feature Flag

[x] Yes
[ ] No

Database Changes

[x] Yes
[ ] No

Breaking Changes

[ ] Yes
[x] No

Development Tested?

[x] Yes
[ ] No

Screenshots

Screenshot 1

https://github.com/user-attachments/assets/5c6c85d0-bed8-4481-af0c-78a898f40922
https://github.com/user-attachments/assets/7037cc1d-1ee5-4e62-b868-b2b9d2aef603

Test Coverage

Screenshot 1

Additional Notes

Hi @yesyash @vinit717 ,
Please review my PR.
Thank you!

Hi @yesyash @vinit717 ,
Please review my PR.
Thank you!

Try to be in Discord so we can track this,  ask @ankushdharkar  for further assistance

This is failing.

Test is missing for controller.

Add a proper test coverage and tests of the code you made

@vinit717 Can you please elaborate more on this as in what to add?

Add a proper test coverage and tests of the code you made

@vinit717 Can you please elaborate more on this as in what to add?

Proper test coverage report of the code/file you changed

Add a proper test coverage and tests of the code you made

@vinit717 Can you please elaborate more on this as in what to add?

Proper test coverage report of the code/file you changed

@vinit717 updated the reports in the PR description. Do I need to add tests for the controller too, because I can't find any written earlier for any controller?

updated the reports in the PR description. Do I need to add tests for the controller too, because I can't find any written earlier for any controller?

Integration test itself is controller tests make logic parts in models so you can test it

updated the reports in the PR description. Do I need to add tests for the controller too, because I can't find any written earlier for any controller?

Integration test itself is controller tests make logic parts in models so you can test it

Hi @vinit717
I've implemented the requested changes. Please review the PR.
Thank you!

Are we not integrating the Discord API as we discussed? @VaibhavSingh8

Are we not integrating the Discord API as we discussed? @VaibhavSingh8

The timeline for this issue is concise, so as I requested yesterday, let's proceed with the original advice by Ankush to do it in a separate PR.

Okay, I will pick in new task.

Left few comments @VaibhavSingh8

Left few comments @VaibhavSingh8

-In the working video, include the discord part as well. Left few comments @VaibhavSingh8

Fixed


feat: Refactor handleCopilotChatInputChange Function in Copilot.tsx for Simplicity

Description:
The handleCopilotChatInputChange function in the Copilot.tsx file can be simplified by destructuring the event object directly in the function parameters. This will make the code cleaner and more readable.
Current Code:
// handles the data changes on the chat input.
const handleCopilotChatInputChange = (event: { target: { value: React.SetStateAction<string>; }; }) => {
    setData(event.target.value);
};

Proposed Change:
Refactor the function to destructure the event object directly in the parameters:
const handleCopilotChatInputChange = ({ target: { value } }) => {
    setData(value);
};

Steps to Reproduce:

Open the Copilot.tsx file.
Locate the handleCopilotChatInputChange function.
Refactor the function as proposed above.

Expected Outcome:
The function should work as intended with a cleaner and more readable code structure.
Additional Notes:

Ensure that the refactored function is tested thoroughly to confirm that it handles data changes correctly.
Verify that there are no side effects or issues introduced by this change.

Feel free to reach out if there are any questions or further clarifications needed.

I'd like to work on this issue! Could you please assign it to me?

Go Ahead!

I'd like to work on this issue! Could you please assign it to me?

Hi @SHIVANG2904, just to let you know, I’m currently working on this issue

@Arindam200 please review this #141


Apply for Dockerhub open source program

Apply for an open source project on dockerhub to get rid of restrictions.
https://www.docker.com/blog/expanded-support-for-open-source-software-projects/
Background:
Apply here:
https://www.docker.com/community/open-source/application

This is done! https://hub.docker.com/orgs/lfenergy/repositories could be used for all LF energy projects.


Should add provisioning / install_prereqs; possibly use for CI

We don't yet have provisioning on develop; #3 has provisioning, but I do not believe others do.
Per VC w/ Miche:

Can maintain separate provisioning (not too much harder than joining, perhaps better for support matrix)
Can use either order of ROS2 action + Drake containers or vice versa
We should be careful about things like python-is-python2 from upstream provisioning https://github.com/RobotLocomotion/drake-ros/pull/6#pullrequestreview-798146922

FYI @IanTheEngineer

Hmm, should this wait until both #3 and #6 are merged? Should #3 land on develop instead of main?


Fixed NSData to Blob bridge extension

Related to issue #337
Sqlite.Blob.length is deprecated, need to use Sqlite.Blob.bytes.count instead

no longer applies, closing


Fix bad URL for GitLab remotes with multiple sub-groups

Hey!
I've noticed an issue when using a GitLab project with several sub-groups: only the first group is matched, and the other groups and the project name is discarded.
I've added test cases reproducing the issues and a proposed fix. As the parse-github-url method discarded completely some parts of the source URL, I've opted to re-parse it for GitLab with a regexp. I don't think this is a great from a maintainability standpoint, but I am unsure how to implement this differently
Let me know what you think!

#232 is 6 month old and fixes the same bug, closing this


Unable to render report when mock-fs is used

I have a test file that uses mock-fs which is a package that mocks a filesystem for testing with Node. I wanted to use Codecov with my repo but I could not. Everything was showing OK, I could see that stats being generated on my local machine as well as on Jenkins. But it did not generate any files.
This is what I did to resolve it (where I set NODE_ENV === 'test' on Jenkins):
var fsMock = process.env.NODE_ENV === 'test' ? function() {} : require('mock-fs');
The drawback is that now a file is actually created on the Jenkins machine after every run, but I can live with that.
My question is: What could be causing this?

Ok, this problem was me not reading the documentation properly.
When you are done with the mock-fs package you should restore it using .restore(), I did this in my tear down method. Now it's working perfectly.


Migrated to React 16.2.0

Upgraded some additional dependencies and configured jest tests
Relative Issue #80

Just seen the Travis issue. Unfortunately I am unable to reproduce the error on my local system.

Coverage remained the same at 100.0% when pulling d435f4c9a497519410a8e7bd49bf7b3ebbb6e180 on jonasgrunert:master into fd17be09fc4ca5c61cdaef03c23d4aedefca6c07 on AlgusDark:master.

Okay I was able to detect with issue. Came from using jest v3 without additional travis configuration.

Already did and no problem occured.

I found issues relating to Typescript. I will close this for good and just give you the advice to use runInBand flag.

So is the only reason this didn't get merged is because of Travis? Can this PR be used as a base for a React 16 version of bloomer or is it completely incompatible?


dolichol-linked oligosaccharide biosynthetic process

dolichol-linked oligosaccharide biosynthetic process
The chemical reactions and pathways resulting in the formation of dolichol-linked oligosaccharide, usually by a stepwise addition of glycosyl chains to endoplasmic reticulum membrane-bound dolichol-P.
In this pathway dolichol is a lipid,  but the dolichol-linked oligosaccharide refers to the combination of an oligosaccharide attached to the lipid carrier dolichol. The oligosaccharide is temporarily associated with the dolichol lipid during its synthesis and transfer to proteins. So overall the dolichol isn't metabolized...
Shouldn't this really be "GO:0019348  (https://www.ebi.ac.uk/QuickGO/services/ontology/go/terms/GO:0019348/complete)
dolichol metabolic process"
It gets classified as lipid metabolic process, but it seems wrong?
(not sure about this one)
@pgaudet @deustp01

It gets classified as lipid metabolic process, but it seems wrong?

This looks like the usual trap that if a chemical entity is a part_of a larger chemical entity (as adenine is a part of coenzyme A) then the part inherits metabolism terms assigned to the larger entity. I think that in previous discussions people may have identified a workaround to escape this inheritance but I can't remember anything more.

I removed
"dolichol metabolic process" from the parentage.
I also removed "lipid metabolic process" from the parent term
oligosaccharide-lipid intermediate biosynthetic process
(although I don't see why we need this term - it's got a single child).
I will put this on  the list of terms I am noticing that could be obsoleted so I don't forget.

I agree we should obsolete oligosaccharide-lipid intermediate biosynthetic process


OpenBSD build is broken due to compilation errors

Tested versions
Reproducible with the 4.3 beta (commit [daa81bb]) and with the 4.3 dev 6 (commit [64520fe])
System information
OpenBSD 7.5 GENERIC amd64 (running on QEMU)
Issue description
OpenBSD build is broken.
I've tried to build it on freshly installed OpenBSD 7.5 in QEMU, and the build is broken due to compilation errors. I've found the following problems:

With the default scons build command it fails because the definition of quick_exit standard function cannot be found when compiling the file platform/linuxbsd/x11/detect_prime_x11.cpp, although the header <stdlib.h> is included.
If I build with OpenGL disabled with scons opengl3=no (that way the source file above won't be included in the build), it sill fails with another error: it can't find the header file #include <linux/input-event-codes.h> (which is included in platform/linuxbsd/wayland/wayland_thread.cpp). Note: it's linux-specific header, although it's available in FreeBSD, but not in OpenBSD.
Problem with Variant class: calls to vformat with long and unsigned long parameters make compiler fail to resolve Variant class constructor, because there is no constructor with either long or unsigned long and in this environment neither of intX_t/uintX_t is typedefed with long/unsigled long.
Definition of the function secure_getenv(name) can't be found in thirdparty/openxr/scr/common/platform_utils.hpp (line 98).

And most likely there are other errors.
Steps to reproduce

Checkout Godot source code, master branch
Install build dependencies: pkg_add python scons llvm
Run scons or scons opengl3=no

Minimal reproduction project (MRP)
N/A

Just to confirm, it still happens on a recent build? That commit is 3 weeks old

Just to confirm, it still happens on a recent build? That commit is 3 weeks old

I've just tried to build the latest master branch and the results are the same. I have updated the ticket description.

Here is a brief summary on how each issue can be fixed.

The first one can be fixed by using _Exit function instead of quick_exit. The only difference is that quick_exit will run functions registered with at_quick_exit, but since there are no any of them, it should be totally OK to use _Exit, given that it's the only source file where this function call is used.
The header file linux/input-event-codes.h is Linux-specific, but it's also present in FreeBSD (here), which seems to be just cloned from the Linux kernel. We can either include that file in the Godot source tree, or make a small abstraction over it (actually redefine the key constant that we use for OpenBSD/NetBSD). Since it's the only place where this file used, there should be no problem with that.
The problem with the overloaded constructors of Variant class with POD types, the issue is exactly the same as discussed in this StackOverflow question: https://stackoverflow.com/questions/10579544/ambiguous-overload-between-int32-t-or-int64-t-parameters-when-passing-long The best solution would be to use a template with integer only types (i.e. with std::enable_if and std::is_integer).
The issue with secure_getenv also present for FreeBSD build, see the issue #67838


Create Loading Screen

We need to either get that loading gif down <1MB or maybe convert it to a Lottie https://airbnb.io/lottie/? (depending on how it was created)

@Phineas

We need to either get that loading gif down <1MB or maybe convert it to a Lottie https://airbnb.io/lottie/? (depending on how it was created)

I've replaced with a basic image for now so we can get something in.
Have also requested the source files for that animation so will try Lotte with it when they come through.


Add integration boundary eq class tests

Closing because merged into https://github.com/katanallama/projectile-simulation-suite/pull/19 Test System with bug fix that caused tests to fail.


problem when getting status of user service

Hi, I really like this project.
However, when I run telegraf in local as:
$ sudo systemctl start telegraf

Then telegraf was started by user "telegraf".
As a result, telegraf was not able to get services started by other by this line in service.py
out = subprocess.Popen(["systemctl", "--user", "status", service], stdout=subprocess.PIPE, stderr=subprocess.DEVNULL)  # NOQA

Do you have any idea about this problem?
Thanks advance

Hi @hsnuhayato, I'll try to reproduce this tomorrow, and will see. I guess the problem is in privileges user telegraf may not have rights to access some files, but will check this.


Light groups for BakedLightmap

Godot version:
109242c
OS/device including version:
Debian GNU/Linux 9.3
Issue description:
Currently, with BakedLightmap, we can only change the energy of the overall BakedLightmap, but we can't change the energy of only certain lights in it. Using separate BakedLightmap may not be an option when the lights we want to control separately are in close proximity with each other.
As mentioned in #4136, this is useful, for example, for flickering lights.
A solution to this problem can be to have a mechanism to specify which light sources should be baked for each BakedLightmap. This way, users can use multiple lightmaps which may overlap (when the lights are close to each other) and control the energies of each BakedLightmap instance separately to control the energy of individual lights, or groups of them, as they need.
Steps to reproduce:
Add multiple light sources and bake the BakedLightmap. When you change the energy of a light source after bake, it has no effect.

While the upcoming new lightmapper in 4.0 is much more powerful than the previous implementation, it doesn't feature support for light groups/lightstyles.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

While the upcoming new lightmapper in 4.0 is much more powerful than the previous implementation, it doesn't feature support for light groups/lightstyles. Still, since Godot now supports projector textures for OmniLight and SpotLight, the original use case should now be covered.

Can you elaborate on how the projector textures cover the original use case, which is an issue more about Lightmap rather the lights itself?

@seadra I was referring to this comment:

If I'm not missing anything here, Godot doesn't have a light source whose shape can be changed, which is needed for ceiling lights like in this video unlike Unreal, so one has to use emission textures. Alas, in current implementation, emission textures don't emit any direct light.

Yes, I agree with that, although that's a side discussion and not the original use case.


Is there a way to test the newInstance method

I'm not able to test newInstance method because I'm not able to create a Map instance since the constructor is private, could you provide a way to create a map to allow newInstance method testing?

Hey there,
I've made the Map init public. This is in the swift-2.0 branch which will be merged into master soon.
Note: the Mappable protocol has been reverted to what it was before, so the newInstance equivalent function is now init?
public protocol Mappable {
	init?(_ map: Map)
	mutating func mapping(map: Map)
}


Inconsistent currentPosition via MediaController if skip silence is enabled

Version
Media3 1.2.1
Devices that reproduce the issue
Pixel 7
Reproducible in the demo app?
Not tested
Reproduction steps
Can be reproduced by setting skip silence on.
Expected result
Position should immediately jump according to skipped parts due to skip silence.
Actual result
There's sometimes a delay of up to a few seconds, as also observed in https://github.com/androidx/media/issues/765. This seems to still be affecting MediaController. I'm also not seeing onPositionDiscontinuity being emitted even when the time does jump, as mentioned in the commit.
Media
Any speech file that has pauses.

I tested this on 1.3.0-alpha01 (which contains the fix for https://github.com/androidx/media/issues/765) and the issue is improved but not entirely fixed. Some skips don't have the discontinuity emitted.
I sent a test media file to<EMAIL_ADDRESS>For example, between "Fun in Osaka" and "The Osaka demonstration was great fun.", we get a discontinuity, but between that one and the next segment, we don't. The shift in playback position to the next segment is delayed.

Hi @Digipom,
Thanks for reporting! You're right, the last fix is an improvement, but unfortunately cannot report every time when there is a period of silence skipped. The complexities reside in the two facts:
a. The silence period can be thin;
b. The noisy period can also be thin;
Both of them will result the event onPositionDiscontinuity to be emitted too frequently. Based on the tradeoff, the standards that we are using to report the silence skipping discontinuity are:

When a silence period is detected, we wait for 100ms to check if there is another silence period coming. If yes, this means that the two silence periods are close enough, so we can accumulate them into one. And if not, this means that any later silence period is far from the current accumulated period, we can consider to report them. This is to address the above complexity b).
For the accumulated period that we consider to report, there is another check on its length. We only report the accumulated silence period that is no less than 1s. This is to address the above complexity a).

So there can be a corner case that, the accumulated silence period is nearly but still less than 1s, then it gets dropped from reporting onPositionDiscontinuity.
Hope this helps!

@tianyif without being familiar with the internals, is there a way to get a deterministic jump or for the skip silence detector to notify you exactly when the skips happen, so we can get deterministic discontinuities? The reason why I'm asking is that I'm building a transcription app and it's important that the current media position actually reflect the real position within the file, so we can highlight the correct text segments. Even if the behavior is better, it still leads to some lag.
If it's not possible currently, I'd like to keep the issue open as a feature request in that case. Thank you very much.

@Digipom Thanks for the information!
The current length threshold for reporting an accumulated silence period is 1s, with which we ignore any accumulated silence period shorter than it. It could create a significant shift between the controller current position and the real position of the player indeed. So would if reducing it, say 300ms, can help? I experimented on the demo-session app with your content, and think the sent onPositionDiscontinuity can reflect speaker's “change breath” at the full stops, and some of the commas.  Could you please let me know this solution sound acceptable for your case?

@tianyif I would say, if it's possible to be deterministic, updating for every skip would be ideal. If we ignore skips under 300ms, then if we have small skips repeated over and over, isn't it still possible to end up with a multiple-second discrepancy between the current media time and the actual media time? When would it get synchronized up again?
Otherwise, certainly 300ms will probably be an improvement over 1000ms.
Would it perhaps be possible to expose the configuration so that the application developers could further customize this behavior?
Thank you.

Hi @Digipom,
We pushed a commit earlier to improve the skip silence reporting logic, which ensures that the discrepancy at the controller from the real playback position won't exceed 300ms. Could you please try and see if this solution fits your case? I'm closing this issue for now, but feel free to re-open it if there are more questions.

@tianyif Sure I can test it. Which version should I use to test?

@Digipom It went with 1.3.0.

@tianyif I tested and the behavior is much improved. Thank you!


Fix typo: an -> a

@lperron /!\ merged into stable not master...

I know. I backported it to master.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le sam. 19 oct. 2019 à 15:18, Mizux<EMAIL_ADDRESS>a écrit :

@lperron https://github.com/lperron /!\ merged into stable not master...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1650?email_source=notifications&email_token=ACUPL3O2I5HRVPQKDOSNG3TQPMCJVA5CNFSM4JBLFRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXPNAA#issuecomment-544142976,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3JJFEBOD67ZU754CNTQPMCJVANCNFSM4JBLFRLQ
.


Nextwebb dev

commented out endpointFor() and makeApiRequest() functions

Hi There 👋 Appreciate the thought but this isn't a desirable change. Thank you though 🙂


Update circle.yml

circle yml was having a command to print "." during 20 hours

must check again all the changes committed. The yml file is not the only one having loops and errors