Update Scalafmt

Codecov Report

Merging #310 (6baaf0a) into main (5cd1833) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   59.87%   59.87%
=======================================
  Files          30       30
  Lines         987      987
  Branches       64       64
=======================================
  Hits          591      591
  Misses        396      396

Impacted Files
Coverage Δ

...s/src/main/scala/org/dhallj/cats/LiftVisitor.scala
76.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd1833...6baaf0a. Read the comment docs.


💡[Feature]: Add Preloader

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
A preloader is an essential feature for enhancing user experience by indicating the progress of loading content. It helps in keeping the users engaged while the main content is being fetched or rendered. Implementing a preloader can significantly improve the perceived performance of our application.
Use Case
Initial Application Load:

Scenario: A user opens the application for the first time.
Requirement: Display a global preloader covering the entire screen while the initial assets and data are being loaded.
Outcome: Users see a visual indicator that the application is loading, reducing uncertainty and improving user experience.

Fetching Data for Dashboard:

Scenario: A user navigates to the dashboard which requires fetching data from multiple APIs.
Requirement: Show a local preloader in the main content area of the dashboard while the data is being fetched.
Outcome: Users are aware that the dashboard data is being loaded and are less likely to think the application is unresponsive.

Loading Large Images or Media Files:

Scenario: A user clicks on a thumbnail to view a large image or video.
Requirement: Display a preloader over the media area until the full image or video is loaded.
Outcome: Users see that the media content is loading and are informed of the progress.

Navigating Between Routes:

Scenario: A user navigates to a different page within the application that requires fetching new content.
Requirement: Show a global or local preloader while the new page content is being loaded.
Outcome: Users are aware that the navigation is in progress and the content is being fetched, improving the navigation experience.

Submitting a Form:

Scenario: A user submits a form that triggers a backend process which takes some time to complete.
Requirement: Display a preloader over the form or a specific section of the page indicating that the submission is being processed.
Outcome: Users receive immediate feedback that their submission is being processed, reducing uncertainty and the likelihood of resubmitting.

Benefits
Enhanced User Experience:

Users are informed about the progress of loading content, reducing uncertainty and frustration.
A preloader keeps users engaged and reassured that the application is functioning correctly.

Improved Perceived Performance:

By providing a visual indicator during loading, the perceived performance of the application is improved, making users feel that the application is faster.

User Retention:

A smoother loading experience helps in retaining users by preventing them from abandoning the application due to unresponsive or slow-loading screens.

Consistency:

A preloader ensures a consistent experience across different parts of the application, especially when loading large components or data-heavy pages.

Customization:

Customizable preloaders can be tailored to match the application's design language, providing a cohesive and branded user experience.

Accessibility:

An accessible preloader ensures that all users, including those using screen readers, are informed about loading processes, enhancing the inclusivity of the application.

Feedback Loop:

Provides immediate feedback to users about ongoing processes, such as form submissions or data fetching, making the application more interactive and responsive to user actions.

Add ScreenShots
My Previous Work:-
https://github.com/sethshivam11/campus-space/assets/146121869/60659c58-583e-4dbb-8db7-2e225aff5bbe
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@AsmitaMishra24 Your idea is good but there is no requirement for that because we are not importing anything from React.lazy. And if you are concerned about the loading time when you get to the site, that is because of the service we are using which spins down the server after 15 mins of inactivity. When a new request comes in the server again spins up.


Updating samples with v1beta1 sample manifest

Closes #340.

config/samples/ingress.yaml it's an empty file.

Already fixed with 549682c1394a68a1cf0854a970026c3031f4fc59


KAFKA-8967 Flaky test kafka.api.SaslSslAdminIntegrationTest.testCreat…

The other brokers sync ACLs from zk notification so the sync may be slower than the Assert. The fix is to wait all brokers to sync the ACLs.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

org.apache.kafka.clients.admin.KafkaAdminClientTest.testDefaultApiTimeoutOverride
kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

they are unrelated flaky

retest this please

retest this please

retest this please

retest this please

looped SaslSslAdminIntegrationTest 50 times. pass
@mjsax could you take a look? thanks!

Not sure this approach is best since user applications don't do this.

Not sure this approach is best since user applications don't do this.

the another approach is to change the "target node" from "LeastLoadedNode" to "ControllerNode" for all methods of Admin so the later operations sent by same Admin benefit from the acl cache (in ControllerNode).
On the other side, the document of #createAcls does not include the acl asynchronization on zk. Personally, we should highlight this scenario for users. There is a good reference on Confluent website.

Note that ACLs are stored in ZooKeeper and they are propagated to the brokers asynchronously so there may be a delay before the change takes effect even after the command returns.

I am not familiar with the details of this test and won't be able to review. Maybe @rajinisivaram @cmccabe @hachikuji can help?


release build failure on Softlayer/JDK11/Windows

Failed on the regular Softlayer build machine (job 516, succeeded on the new one at Azure (job 517]
Have locked the 516 console log to allow fo investigation. I'd like to have someone look at and understand this one instead of just cleaning up the workspace and retrying if possible.

the machine has been pending a restart for 3 months, restarting now to see if that helps

Going to transfer this to infra for now as the machine seems to be in a rather undesirable state - am attempting to power it back on but it seems initially somewhat resistant (FYI @tellison)


[rip-10] add test case for PrintMessageByQueueCommand and bug fix issure 903

bug fix https://github.com/apache/rocketmq/issues/903
and add test case for PrintMessageByQueueCommand

Coverage increased (+0.03%) to 47.817% when pulling bc58d00bf85f2f85c543d3c4d7bbd13e2a09270d on pigpdong:dev_test_20190226 into 6eff504877e2924f76cd0b48f8daf7bfff4621c5 on apache:develop.

remove bugfix just add test case


[9.x] Added ability to set delay per channel based on notifiable instance

We have a lot of users who don't want to receive Notification emails during the night, and some that does.
After some digging this is a solution to bypass the current behaviour:
public function via($notifiable)
{
	$this->delay = [
		'mail' => $notifiable->likes_uninterrupted_sleep ? $notifiable->nextWakeUpTime() : null
	];

       return ['mail', 'database'];
}

Trying to set a delay based on a notifiable instance currently required the delay to be set in  $notification->via() as it is the last method called where the notifiable is passed through.  It is however not optimal as it is set on the $original instance in NotificationSender::186, so it must be overwritten in every via-call on every notifiable.
My proposal is a new method call withDelay that accepts the notifiable and channel as arguments which provides:
public function withDelay($notifiable, $channel)
{
	return match ($channel) {
		'mail' => $notifiable->likes_uninterrupted_sleep ? $notifiable->nextWakeUpTime() : null,
		default => null,
	};

}

//OR

public function withDelay($notifiable)
{
	return [
		'mail' => $notifiable->likes_uninterrupted_sleep ? $notifiable->nextWakeUpTime() : null
	];
}

To me there are only upsides, if there are database queries performed or heavy logic to resolve the delay it's only calculated once if the developer choose to match against the channel name provided. The code looks cleaner as well, the via method doesn't become cluttered with delay data.
It does not break the existing implementation by setting the delay prop.
Only breaking change would be if someone has implemented a withDelay function in a notification to solve something else.

Was there a reason you named the method withDelay instead of just delay?

@taylorotwell Illuminate\Bus\Queueable already defines delay as a fluent setter. Open for suggestions on the method name, I thought delay/withDelay() would be similiar to queue/viaQueues()
@robert-sykes Fixed ternary format

@taylorotwell Illuminate\Bus\Queueable already defines delay as a fluent setter. Open for suggestions on the method name, I thought delay/withDelay() would be similiar to queue/viaQueues()

I think delay reads easier and a common interface i.e. similar to Queueable fluent setter might be a good idea. 🤔

The reason I mentioned Illuminate\Bus\Queueable is that artisan make:notification {name} command uses the Illuminate\Bus\Queueable-trait per default on all notifications. So there would be a duplicate declaration of methods, or needed to be handled frequently by developers to avoid duplication if it was simply named delay
It would also break any current use of notifications that has the Queueable-trait as it would be calling a setter-method instead of getting the desired delays per channel

The reason I mentioned Illuminate\Bus\Queueable is that artisan make:notification {name} command uses the Illuminate\Bus\Queueable-trait per default on all notifications. So there would be a duplicate declaration of methods, or needed to be handled frequently by developers to avoid duplication if it was simply named delay
It would also break any current use of notifications that has the Queueable-trait as it would be calling a setter-method instead of getting the desired delays per channel

Ah - I didn't consider that. 👍

@ehamrin got it


Investigate the xml support availability in oracledb module

Description:
$title
Describe your task(s)
xml data type was removed in oracledb and now need to check the root cause of the removal of that type. Also need to investigate the possibility of adding the xml data type support back again into oracledb.
Related Issues (optional):
Suggested Labels (optional):
module/oracledb
Suggested Assignees (optional):
Lahiru Malepathirana

It seems RecordIteratorUtils class in sql module should be extended in oracledb module when selecting xml data type data since in sql module we used SQLXML sqlxml = resultSet.getSQLXML(columnIndex); is throwing an exception

Issue is closing since the PR is merged,


bug: fixed dockerfile and dockerfile.contrib to use node:erbium-buster-slim

dependabot changed all references to  to node:erbium-buster-slim to node:15.9.0-alpine.
This PR reverts those changes.,

Pull Request Test Coverage Report for Build 585172057

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 19.388%

Totals

Change from base Build 581791076:
0.0%

Covered Lines:
2027

Relevant Lines:
10724

💛  - Coveralls

@jcam  erbium-buster-slim is failing on the build check
the github workflow expects linux/arm64,linux/amd64,linux/arm/v6,linux/arm/v7
node:erbium-buster-slim
has

options:

we pick a different base buster and install node manually
we change the github workflow to remove arm/v6

What workflow is running the dockerfile.contrib?
I picked erbium-buster-slim because that was one we used to use here before dependabot broke it (the first time, back in january):
https://github.com/zwave-js/zwavejs2mqtt/commit/9767d76df0e1760504ee74b8b32ba0e18e85b304#diff-4ddc2e10398d5c169795b7937f893ec72d2619b395259c592156a5dd0b476c9f

the regular Dockerfile should be using node alpine

the regular Dockerfile should be using node alpine

ok will make the change, why the difference?

contrib does a lot more :D

if you use slim up top, you'll need to run an apt-get install a few things... build-essential, git, jq... i think that's all

if you use slim up top, you'll need to run an apt-get install a few things... build-essential, git, jq... i think that's all

I put it back to alpine for the dockerfile but to erbirum-buster-slim (to mirror your change that got wiped away),
i had (wrongly) assumed that both edits by the dependabot was bad.


Unable to open/edit files

I'm now using the latest pawncc.exe provided by Russell last night, and pawncc.exe does at least open without errors/warnings now, however, I'm still unable to open files using PawnEditor.exe. For example, I tried double-clicking AdministratorCommands.pwn -- nothing happened, same with various other files. Tried enabling/disabling compatibility mode, running as admin, etc.
I created a screen capture to demonstrate: https://youtu.be/vaKczWZt6nQ

Looks like you only downloaded the project configuration file and not the project files themselves.
Clone https://github.com/LVPlayground/playground through git or the GitHub client https://desktop.github.com. This method is easiest if you want to submit pull requests. You can also download our latest release from https://github.com/LVPlayground/playground/releases/tag/v26.0 if you just want to run the gamemode.
Once you have all the files, open LVP.ppr inside the editor.

Problem solved, thanks oostcoast.


"device_state_attributes" deprecated in Home Assistant 2021.12.5

While running the custom component in Home Assistant 2021.12.5, I get the error:
Logger: homeassistant.helpers.entity
Source: helpers/entity.py:549
First occurred: 04:38:55 (1 occurrences)
Last logged: 04:38:55

Entity sensor.ecowater (<class 'custom_components.ecowater_softener.sensor.EcowaterSensor'>) implements device_state_attributes. Please report it to the custom component author.

Can't find the exact release notes, but it seems that (since HA 2021.11.0) attributes are moving towards separate sensors - I think that's what this relates to?

+1 I have the same issue on 2021.12.9

+1, also seeing this one. Is this integration still active, or should someone look to contribute a fix?

I think @barleybobs might be somewhat on a break or something because I also received no response to my PR from December for a different issue ( #6 #7).

Updating it now! Sorry I haven't been very active lately.
Thanks 👍

Fixed in #9

Fixed in #9


Full city list URL as in README.md

only comment upgrade to align config.js.sample with README.md

Could you fix the conflict? Thanks!

Of course

I'll try again from develop branch directly


Maintain output in console

I love this plugin! Great work. The only thing that I wish was different is that I can no longer see error output in my terminal... I would love if the error could be shown in both the browser and the terminal, so I can see it wherever I happen to be working. Sometimes I'm working on something and I'm not jumping back and forth to the browser, in which case I miss the error output unless I go check there.

Oh shoot, didn’t even notice! Let me look into that today. Also, there’s a PR to merge this into the core and I’m certain it doesn’t have the same issue.

Wonderful, thank you!

No prob! It's now available in 0.1.2.


Update process-editor checksum

if it still works -> ok but a little bit strange that it changes from a sha512 to sha1...

I think it's because I built this package on my mac and not via pipeline. There are few others with sha1, so I assume it's ok.


Manually add a new FTP user to an existing container

Hello,
The documentation provides an example to manually add a new FTP user to an existing container
docker exec -i -t vsftpd bash
mkdir /home/vsftpd/myuser
echo -e "myuser\nmypass" >> /etc/vsftpd/virtual_users.txt
/usr/bin/db_load -T -t hash -f /etc/vsftpd/virtual_users.txt /etc/vsftpd/virtual_users.db
exit
docker restart vsftpd

Nevertheless each time the container is restarted, virtual_users.txt is erased in run-vsftpd.sh  so the new added user is deleted.
echo -e "${FTP_USER}\n${FTP_PASS}" > /etc/vsftpd/virtual_users.txt
/usr/bin/db_load -T -t hash -f /etc/vsftpd/virtual_users.txt /etc/vsftpd/virtual_users.db

May be I'm doing someting wrong.

This is my exact issue - would you happen to have found a resolution for this as i've spent hours on it and still not getting anywhere

+1 for any clues please.

If anyone is still looking for a solution to this, I have a possibility but it involves changing quite a few of scripts and 'breaking' some of the original solution.
You can move the location of virtual_users.db to a different directory and mount it on the host using VOLUME so that the user db persists across container restarts. I also eliminated the creation of default FTP_USER and start with an empty user db, creating users manually as-needed.
I make no comment on the security of doing this. You could try adding crypt=crypt to the vsftpd_virtual?https://nasauber.de/blog/2020/howto-virtual-users-for-vsftpd/
And ensure the .db file is only readable by root user?
A number of modifications are required to the source configuration and script files to enable this, but at a high-level the steps are:

vsftpd_virtual Shift the location of the virtual_users.db from /etc/vsftpd to /etc/vsftpd/db
run-vsftpd.sh eliminate the creation of FTP_USER and FTP_PASS when the container starts. Also, eliminate the lines that load the virtual_users.txt - the goal is to have run-vsftpd.sh not create any users when it runs. You will add users manually after startup. Ensure all references to the db are updated to reflect the new path, and references to FTP_USER/FTP_PASS are removed.
Dockerfile amend to create the /etc/vsftpd/db folder and VOLUME /etc/vsftpd/db, also copy in the addftpuser.sh script. Ensure all references to the db are updated to reflect the new path.
Create a bespoke addftpuser.sh that is copied into the image that takes care of adding a user/password to virtual_users.db and creates the /home/vsftpd/ folder for the user using the techniques already described in the use-cases and existing scripts. Basically my script generates a password for the supplied user, writes it to a temp file using the \n format, then loads that file into the db, then deletes the temp file. It then creates the /home/vsftpd/ folder if it doesn't exist.
When you run the image, mount the /etc/vsftpd/db folder to a folder on the host, so the .db persists outside of the container lifecycle e.g. -v /path/on/host:/etc/vsftpd/db

With a running container you then do:
docker exec -ti  /bin/bash
addftpuser.sh
Then you can start the container, create users as you need, and assuming you also mounted the /home/vsftpd volume too, if you stop/start the container, the user config persists. Also I didn't find the need to restart the container when a new user is added, authentication seems to work fine as soon as the user is added.
There is still an issue of duplicating config in vsftpd.conf each time you restart the same container, due to run-vsftpd.sh appending config using >> when it runs. I didn't fix this yet.

I've posted the complete solution here https://github.com/phantom-artist/vsftpd if you want details of the scripts etc.
Again, kudos to fauria on which my solution is based!


Logo is missing in the footer.

Describe the bug
In the footer of the website, the amazon logo is not rendering.

Expected behaviour
When the footer gets loaded, it should render the logo as well.
Screenshots
No response
Additional context
No response

@Kanika637 Can you assign this to me.

This issue is part of the PR id: 119


Excelize floating images support editAs="oneCell" attribute

Description
I found the following three problems when using excelize's floating picture function, hoped to add the attribute editAs="oneCell"
Probrem 1：
Use the floating image in the table exported by Excelize, due to the twoCell format,
	      +------------+------------+
	      |     A      |      B     |
	+-----+------------+------------+
	|     |(x1,y1)     |            |
	|  1  |(A1)._______|______      |
	|     |    |              |     |
	|     |    |              |     |
	+-----+----|    OBJECT    |-----+
	|     |    |              |     |
	|  2  |    |______________.     |
	|     |            |        (B2)|
	|     |            |     (x2,y2)|
	+-----+------------+------------+

the size of the image will change as the coordinates of the lower right corner point change.
When adjusting the row height and column width, the image will also adjust the height and width accordingly, and the ratio of the image will be affected
For example, the original image was in this scale:

After adjusting the row height of row 7 and the column width of column C, the proportions of the image are affected.

However, this phenomenon does not occur when using floating pictures inserted by Excel.

It looks like it's because the floating picture inserted by Excel has the attribute editAs="oneCell", adjusting the row width and column height will not affect the original width and height of the picture.

Probrem 2：
When I put a floating image on top of a collapsed row or column,

Floating images in files exported by Excelize will have the wrong display ratio:

It looks like it's because in the method of func (f *File) positionObjectPixels(sheet string, col, row, x1, y1, width, height int) (int, int, int, int, int, int) {}, when calculating colEnd, rowEnd, width, height, the folded rows and columns will also be calculated.
// Subtract the underlying cell widths to find end cell of the object.
for width >= f.getColWidth(sheet, colEnd+1) {
	colEnd++
	width -= f.getColWidth(sheet, colEnd)
}

// Subtract the underlying cell heights to find end cell of the object.
aaa := f.getRowHeight(sheet, rowEnd+1)
for height >= aaa {
    rowEnd++
    bbb := f.getRowHeight(sheet, rowEnd)
    height -= bbb
    aaa = f.getRowHeight(sheet, rowEnd+1)
}

As a result, when the file is actually opened, if rowEnd is in the folded row, the above image proportion problem will occur.
After unfolding, the display returns to normal. After resuming folding, the display will appear abnormal again.

Probrem 3：
Pictures exported using Excelize have problems with proportions even on rows and columns that are not folded. The original image is a square with the same width and height, but the proportion of the exported image has changed. The screenshots are compared as follows:

This problem may be that the width and height of each cell are inconsistent in files of different standards, which leads to problems in determining the size of the image based on the point in the lower right corner of the image.

Describe the results you received:
support editAs="oneCell" attribute
Output of go version:
1.22.6

Excelize version or commit ID:
v2.8.1

Environment details (OS, Microsoft Excel™ version, physical, etc.):

the same problem


fix: migration issues

Fix RM-XYZ

🧰 Changes
Fixes some issus that come up during testing.

Close unclosed self-closing tags.
Handle mutli-line html comments.

🧬 QA & Testing

Broken on production.
Working in this PR app.

RM-9899


Add "EdgeInsets? margin" to  ButtonStyle

Use case
In some cases, I need the desktop and mobile to have the same button layout.
The Button style is now available in different styles for different platforms. And the only option.
Proposal
Add "EdgeInsets? margin" to  ButtonStyle.
If margin==null, the existing style is used.
If margin! =null, I want to be able to achieve the desired style.
Thank you very much.

Hi @LinHaoLove
I wonder how the margin works inside ButtonStyle. Could you please be more specific?
ButtonStyle includes visual properties for the button such as color, textStyle or padding between the button's boundary and its child. The properties apply inside the button. Meanwhile, margin as I understand it is the distance between the button and the ancestor widget.

Hi @LinHaoLove I wonder how the margin works inside ButtonStyle. Could you please be more specific?
ButtonStyle includes visual properties for the button such as color, textStyle or padding between the button's boundary and its child. The properties apply inside the button. Meanwhile, margin as I understand it is the distance between the button and the ancestor widget.

For example, when multiple buttons are placed in a Row or Column.
And "mainAxisAlignment: MainAxisAlignment.start,",
The spacing between buttons will vary on different platforms.
I hope that sometimes they are the same on different platforms. And the spacing can be set, I cannot modify the spacing between them now.
Now I have customized a button to solve this problem, but my coding skills are not very good.

@LinHaoLove can you share an example of what you are specifically trying to achieve with ButtonStyle?
Some sample code would be very helpful to identify the issue here.

For example, when multiple buttons are placed in a Row or Column.

ButtonStyle only applies to one button, it does not apply to multiple buttons or how they are positioned in relation to each other.

Thanks for extracting this! This is something that should be handled with the Padding widget, or in a Row/Column I've seen folks use a SizedBox for spacing as well. We typically do not enumerate padding properties on widgets, since we have a Padding widget!
Thanks for clarifying the issue.

Thanks for extracting this! This is something that should be handled with the Padding widget, or in a Row/Column I've seen folks use a SizedBox for spacing as well. We typically do not enumerate padding properties on widgets, since we have a Padding widget!
Thanks for clarifying the issue.

Hi，
Based on the current state, there will be different padding on different platforms.
SizedBox or Padding will increase their spacing on top of the existing spacing. And it won't keep their spacing the same.
So，we need to first unify their existing spacing by a optional way .


Update Liferay Commerce Screenshots

Liferay Commerce has a new accelerator design for 1.1. Please update the screenshots at https://liferay.design/blueprints/resources/product-screens/ with the ones we use on liferay.com.
Anything referring to Beryl should be retired.

more details here

Thanks @abelhancock !
Sent with GitHawk


Local AppMaps aren't updated in the AppMap panel if an entire containing directory is deleted

GIVEN a number of AppMaps in a subdirectory within the workspace
AND the subdirectory is deleted
THEN the AppMaps still appear in the panel

I can't reproduce with installed AppMap extension v0.13.0, can you check on your side is these issues are still relevant? @dustinbyrne


Fixed stream ref issue on exhausted outgoing flow ctrl window

The bug arises in the following scenario:

Outgoing flow control window is depleted, which causes the http2 stream to stall.
Eventually, a flow control window updates arrives while there's contention on the stream's lock.
This which MAY result in an invalid intertwining of callback invocations, triggering the bug.

The fix avoid incrementing the ref count of a defunct stream. The stream destruction function, which will eventually be invoked, would take care of removing the stream from the transport's lists.

Known issues:
#9150
#9153


White frame around original image yields only partially readable caption

White frame around original image yields only partially readable caption:

Consider adding a dropshadow like this: https://stackoverflow.com/questions/67473444/how-to-make-text-shadow-effect-in-pillow-python


fix(extract): transform static key into a string literal

Hi again 😅
I've attempted to use the plugin and realised there is an error. Static key property needs to be transformed into string literals. I've made a basic example of what I did. It looks like object properties do need some transformation at times.

Thank you


Proper way to handle when error occurs

what is the proper way to terminate the loading when an error occurs for example making an http call?
right now when assign my http call's promise to cg-busy and an error occurs it just continues to spin/load.
thanks!

Yes this is an issue for me too

Wouldn't loadingPromise.reject(); do the trick?

Perhaps (haven't looked into it), but it would make for easier developer user experience to have the module handle this itself

i.e. use finally instead of then, if available on "promise thing"


Substitutions for GenericSeries and MathematicalExpression

I do not want to include this into the first version of the GenericSeries since it is already enough work, but I think we should definitely consider it in the future:
Sometimes there are expressions that have repetitive terms. For example, consider the following I used in the GenericSeries tutorial:
expr = "tanh((x-t)/5) - tanh(x-t-10)"

Here the term x-t is used twice. Not so bad you might think and it isn't as long as you do not start using units. Here x is a spatial dimension with a length unit and t is time. Also, consider that tanh requires an angular unit or no unit at all and suddenly you get a total mess. To get everything sorted out, you need to bloat this subterm to a * x + b * t where a and b are parameters that are just there to clear the units. And no, clearing the units from the variables in advance (before we evaluate) is also no option because x and t might appear in other terms where the unit does not need to be cleared. The simple solution would be to have a substitution like this:
expr = "tanh(s/5) - tanh(s-10)"
subs = {"s": "a * x + b * t"}

Apart from some minor difficulties, this shouldn't be a big issue since it can be a simple text replacement in the beginning and get some more depth later (strings are not the only method to define a math expression or think of chained substitutions). This should probably be implemented as a feature of the MathematicalExpression

I think a string replacement before evaluation is a good (and simple) solution, everything else might be a bit overkill for the scope of weldx for now
PS: just seeing tanh(x-t-10) makes my skin crawl when thinking about the units (and we should avoid automatically ' just clearing' units because this would defeat the whole purpose in the first place. There is no such thing as 'clearing units', there is only conversion 📜

PS: just seeing tanh(x-t-10) makes my skin crawl when thinking about the units

It's not that bad. Not much worse as when describing a sine weaving motion, just with an extra (incompatible) dimension.
The equation is just a modified version of a traveling wave 😉

(and we should avoid automatically ' just clearing' units because this would defeat the whole purpose in the first place.

exactly

There is no such thing as 'clearing units', there is only conversion 📜

have a word with my 🧽

PS: just seeing tanh(x-t-10) makes my skin crawl when thinking about the units

It's not that bad. Not much worse as when describing a sine weaving motion, just with an extra (incompatible) dimension. The equation is just a modified version of a traveling wave 😉

I meant concerning that it should always be in the form of tanh(a*x+b*t-10) (which looks pretty ⭐ )

PS: just seeing tanh(x-t-10) makes my skin crawl when thinking about the units

It's not that bad. Not much worse as when describing a sine weaving motion, just with an extra (incompatible) dimension. The equation is just a modified version of a traveling wave 😉

I meant concerning that it should always be in the form of tanh(a*x+b*t-10) (which looks pretty ⭐ )

True, but that's the target equation. In the tutorial, we start simple (no parameters, no units) and get there step by step 😉


Restore-DbaDbCertificate tests

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[X] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Tests were not working properly, fixed them up and added additional code coverage.

thank you so very much, i always have a hard time with the certificate tests. i appreciate your updates!


chore(ingress): update examples in documentation (#1363)

Backport
This will backport the following commits from k8s-25/main to k8s-24/main:

chore(ingress): update examples in documentation (#1363)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1381

Questions ?
Please refer to the Backport tool documentation


--cleanDestinationDir flag ignored if static directory is missing

What version of Hugo are you using (hugo version)?

hugo v0.108.0-a0d64a46e36dd2f503bfd5ba1a5807b900df231d+extended darwin/amd64 BuildDate=2022-12-06T13:37:56Z VendorInfo=gohugoio

Does this issue reproduce with the latest release?
Yes
Currently the --cleanDestinationDir flag is ignored when the project is missing a static directory. It's been there for a while but I was not able to find an opened or closed issue about this.

I think this is a duplicate of https://github.com/gohugoio/hugo/issues/8433.

Ok sorry, I did not seem them related at first 👍


:bug: Fix default folder

Summary
fix github actions to run make strict-fmt
Related issue(s)
Fixes #

/retest

/lgtm


add Github Auth

It should be possible to use Github OAuth2 infrastructure with this middleware.

Hey @szuecs, still want this?  Want to add a Help Wanted label?

@LappleApple sure I want to have it. :)

@szuecs +1 for the HW label.

This issue is fixed in #39


Add details to How to Join RDS

Issue
#373
What is the change?

Added "How to Join Real Dev Squad" details
Three Files have been changed index.html, main.css and index.js.

Is Development Tested?

[x] Yes
[ ] No

Before / After Change Screenshots
Before :

After :

Feature flag is already written i am add only hide class to this section


Fix typo in path to file for upgrade dependencies

Description
Fix typo in the file name and path to the file in the workflow file.

@napari-bot update constraints


Review diff algorithm API

cc @alexandrudima
In order to implement range staging/unstaging, I had to expose the diff algorithm in the API.
	export interface LineChange {
		readonly originalStartLineNumber: number;
		readonly originalEndLineNumber: number;
		readonly modifiedStartLineNumber: number;
		readonly modifiedEndLineNumber: number;
	}

	export function computeDiff(oneDocument: TextDocument, otherDocument: TextDocument): Thenable<LineChange[]>;

https://github.com/Microsoft/vscode/blob/9703537e62075a6c9edd85133c22f601c5f25182/src/vs/vscode.proposed.d.ts#L158-L165
I'm not entirely happy as to how that looks like.
@jrieken Do you have any ideas how we can improve this? Maybe we could add it to the workspace namespace, since it computes diffs on TextDocuments.

I don't see LineChange being referenced anywhere in the API? Is this just a util?

It's the result of the computeDiff function.

I understand that but I don't see the contract? The API doesn't expect the result to passed in to some operation, right? Nor does the API call the compute-function, right? Is this just a util-function?

Apart from finding it hard to justify such a utility API there are major performance concerns. Diff'ing is inherently slow, 5yrs back it was one of the first web worker consumers, and should therefore not be executed in the extension host.

I'm also not really sure.
Running computeDiff on the same two inputs might yield different results.
Perhaps we need a special purpose command that retrieves the actual displayed diff in the UI... Or perhaps it can be on the new SCM specific API that it is possible to register a diff command that will always be called with certain arguments, that also include the diff.

Running computeDiff on the same two inputs might yield different results.

That's not very good news.

Perhaps we need a special purpose command that retrieves the actual displayed diff in the UI

Feels like a hack, but it could work for my specific use case.

There's always the third option:

Or perhaps it can be on the new SCM specific API that it is possible to register a diff command that will always be called with certain arguments, that also include the diff.

e.g.
vscode.scm.registerDiffEditorCommand('bla', function(diff) {
   // diff is the current diff info displayed in the editor.
});

The main side would then make sure to invoke such commands always with the diff information.

Yeah, there are asks for us exposing the diff editor. It sounds like that could solve this issue by exposing the currently showing diff. It would also align with registerDiffEditorCommand

@jrieken We should expose think of ways to expose this information in a "non-eager" way.
Pushing the diff changes every time it is computed on the UI thread to the extension host (only to have nobody use it 99% of the time) is too much IMHO.

Yeah, that's an API design thing of having it sync there or not. In general diff editors are open too often I would say and having a lone 'diffEditorCommand' might be unexpected

Reviewed!


Separate options from display

as per Paul:
When looking at the interaction between options and outputs, I want to have several nodes selected for display (using shift click to select them), then I want to select the options for an entirely different node, modify them, and update the displayed graphs.  Consider background subtraction, where I want to show the three inputs to "sub bg" but want to adjust the Qz basis in "load bg+" and "load bg-" until the curves have a matching Q range.

as per Brian:
This is doable!  Seems like a good idea.  Just takes a little rejiggering of the click handlers.

After diving into this a bit, it is not as simple as it sounds... We have ties between the active module and the graph for certain field types (currently, index for masking, range for boxes, and click-to-drag for scale factor).  Knowing when the graph is interactive with the current module and when it is not might be confusing to users.


可以提供一个测试账号吗?

您好,可以提供一个测试登录的账号吗

@Woxiee Hey we can't provide you with a test account since most of the authentication is currently based on Apple's IAP system. You would have to provide us with your IAP shared secret
I also noticed that you are writing in Chinese and due to laws imposed by the Chinese Government you wont be able to connect to our nodes since the underlying connection relies on a VPN implementation

@Woxiee Hey we can't provide you with a test account since most of the authentication is currently based on Apple's IAP system. You would have to provide us with your IAP shared secret
I also noticed that you are writing in Chinese and due to laws imposed by the Chinese Government you wont be able to connect to our nodes since the underlying connection relies on a VPN implementation

THX


Nav: Fix right padding on level2+

The sets the right padding the same as the first level.
The current padding is too large and varies between toc levels.
Now, the right padding is the same between all levels and only the left padding changes
Before:

After:

Another example:


Kwxm/signature verification throughput statistics

(PLT-788)  @iquerejeta is interested in how many Ed25519 signatures we can verify in a Plutus validation script.  This adds a program to test that.   I don't know if we want to merge it, but here it is anyway.
It does the following, which I think is roughly what Iñigo's interested in.

Generates n public keys P_1,...,P_n

Hashes them to get n hashes H_1,...,H_n.

Signs all of the hashes with different private keys K_1,...,K_n (with corresponding public keys V_1,...V_n) to get n
signatures S_1,...,S_n.

Creates a list of (V_i, H_i, S_i, P_i) tuples, convert it to Data, and feeds that to a script which

Verifies each (V_i, H_i, S_i) to check that the signatures are valid.
Hashes each P_i to make sure that it matches H_i.

This program does that for varying values of n and prints statistics about the size, cpu cost, and memory cost of the script.  The hashes are calculated using sha2_256; I also tried sha3_256 and that left the script sizes unaltered but increased CPU/memory usage by 1 or 2%.
The results are shown below, both as absolute values and as percentages of the limits specified in the current protocol parameters.  For script size, I've shown the percentage of the max_tx_size parameter: this may include more than just the script, so the percentages may be a little optimistic.  Anyway the main limiting factor seems to be the script size: we can get up to 90 or so signatures before we start to hit the limit.  The data that we're checking account for most of the size of the script; I may have included too much stuff in the inputs, and if that's the case then it may be possible to squeeze in some more.
    n     script size             CPU usage               Memory usage
  ----------------------------------------------------------------------
    0     507   (3.1%)         7834416   (0.1%)           28414   (0.2%)
   10    2234  (13.6%)       781835316   (7.8%)          667844   (4.8%)
   20    3961  (24.2%)<PHONE_NUMBER>  (15.6%)         1307274   (9.3%)
   30    5688  (34.7%)<PHONE_NUMBER>  (23.3%)         1946704  (13.9%)
   40    7415  (45.3%)<PHONE_NUMBER>  (31.0%)         2586134  (18.5%)
   50    9141  (55.8%)<PHONE_NUMBER>  (38.8%)         3225564  (23.0%)
   60   10868  (66.3%)<PHONE_NUMBER>  (46.5%)         3864994  (27.6%)
   70   12595  (76.9%)<PHONE_NUMBER>  (54.3%)         4504424  (32.2%)
   80   14321  (87.4%)<PHONE_NUMBER>  (62.0%)         5143854  (36.7%)
   90   16048  (97.9%)<PHONE_NUMBER>  (69.7%)         5783284  (41.3%)
  100   17775 (108.5%)<PHONE_NUMBER>  (77.5%)         6422714  (45.9%)
  110   19502 (119.0%)<PHONE_NUMBER>  (85.2%)         7062144  (50.4%)
  120   21228 (129.6%)<PHONE_NUMBER>  (93.0%)         7701574  (55.0%)
  130   22955 (140.1%)<PHONE_NUMBER>6 (100.7%)         8341004  (59.6%)
  140   24682 (150.6%)<PHONE_NUMBER>6 (108.4%)         8980434  (64.1%)
  150   26409 (161.2%)<PHONE_NUMBER>6 (116.2%)         9619864  (68.7%)

Hmmm.  It's failing in CI because cabal seems to think that plutus-tx-plugin isn't required, but if I remove that from the cabal file I get a linker error (locally, at least).

This is great. Thanks a lot for the benchmarks. They are really helpful to define our strategy in the near future. I guess the decision of merging or not will fall back to the plutus team, but I find these really helpful, and wouldn't be surprised if they'll be helpful in the future.
The fact that the script size is the bottleneck gives hopes that we can design the protocol in a way where we optimise the script size by a fraction. However, the CPU usage seems to indicate that the hard limit is at around 130 signatures (this assuming we don't do anything else in the script), which is also very good to know.

Hmmm. It's failing in CI because cabal seems to think that plutus-tx-plugin isn't required, but if I remove that from the cabal file I get a linker error (locally, at least).

Yeah, this is a weird thing that happens sometimes, just turn off -Wunused-packges for that component with a note.

OK, I'm going to merge this.  It seems that it's just Cicero that's problematic.

For reference, here are the earlier figures along with ones for verifySchnorrSecp256k1Signature and verifyEcdsaSecp256k1Signature.  The figures for script sizes are the same (as you'd expect), but the CPU and memory figures are better since both of the Secp256k1 functions have lower costs than the Ed25519 one.  Also, most of the space in the script is taken up by the data, so things might be different in a real application.
verifyEd25519Signature
    n     script size             CPU usage               Memory usage
  ----------------------------------------------------------------------
    0     507   (3.1%)         7834416   (0.1%)           28414   (0.2%)
   10    2234  (13.6%)       781835316   (7.8%)          667844   (4.8%)
   20    3961  (24.2%)<PHONE_NUMBER>  (15.6%)         1307274   (9.3%)
   30    5688  (34.7%)<PHONE_NUMBER>  (23.3%)         1946704  (13.9%)
   40    7415  (45.3%)<PHONE_NUMBER>  (31.0%)         2586134  (18.5%)
   50    9141  (55.8%)<PHONE_NUMBER>  (38.8%)         3225564  (23.0%)
   60   10868  (66.3%)<PHONE_NUMBER>  (46.5%)         3864994  (27.6%)
   70   12595  (76.9%)<PHONE_NUMBER>  (54.3%)         4504424  (32.2%)
   80   14321  (87.4%)<PHONE_NUMBER>  (62.0%)         5143854  (36.7%)
   90   16048  (97.9%)<PHONE_NUMBER>  (69.7%)         5783284  (41.3%)
  100   17775 (108.5%)<PHONE_NUMBER>  (77.5%)         6422714  (45.9%)
  110   19502 (119.0%)<PHONE_NUMBER>  (85.2%)         7062144  (50.4%)
  120   21228 (129.6%)<PHONE_NUMBER>  (93.0%)         7701574  (55.0%)
  130   22955 (140.1%)<PHONE_NUMBER>6 (100.7%)         8341004  (59.6%)
  140   24682 (150.6%)<PHONE_NUMBER>6 (108.4%)         8980434  (64.1%)
  150   26409 (161.2%)<PHONE_NUMBER>6 (116.2%)         9619864  (68.7%)

verifySchnorrSecp256k1Signature
 ----------------------------------------------------------------------
    0     499   (3.0%)         7765416   (0.1%)           28114   (0.2%)
   10    2226  (13.6%)       589337056   (5.9%)          652544   (4.7%)
   20    3953  (24.1%)<PHONE_NUMBER>  (11.7%)         1276974   (9.1%)
   30    5680  (34.7%)<PHONE_NUMBER>  (17.5%)         1901404  (13.6%)
   40    7407  (45.2%)<PHONE_NUMBER>  (23.3%)         2525834  (18.0%)
   50    9133  (55.7%)<PHONE_NUMBER>  (29.2%)         3150264  (22.5%)
   60   10860  (66.3%)<PHONE_NUMBER>  (35.0%)         3774694  (27.0%)
   70   12587  (76.8%)<PHONE_NUMBER>  (40.8%)         4399124  (31.4%)
   80   14313  (87.4%)<PHONE_NUMBER>  (46.6%)         5023554  (35.9%)
   90   16040  (97.9%)<PHONE_NUMBER>  (52.4%)         5647984  (40.3%)
  100   17767 (108.4%)<PHONE_NUMBER>  (58.2%)         6272414  (44.8%)
  110   19494 (119.0%)<PHONE_NUMBER>  (64.1%)         6896844  (49.3%)
  120   21220 (129.5%)<PHONE_NUMBER>  (69.9%)         7521274  (53.7%)
  130   22947 (140.1%)<PHONE_NUMBER>  (75.7%)         8145704  (58.2%)
  140   24674 (150.6%)<PHONE_NUMBER>  (81.5%)         8770134  (62.6%)
  150   26401 (161.1%)<PHONE_NUMBER>  (87.3%)         9394564  (67.1%)

verifyEcdsaSecp256k1Signature
    n     script size             CPU usage               Memory usage
  ----------------------------------------------------------------------
    0     499   (3.0%)         7765416   (0.1%)           28114   (0.2%)
   10    2246  (13.7%)       549033716   (5.5%)          652544   (4.7%)
   20    3993  (24.4%)<PHONE_NUMBER>  (10.9%)         1276974   (9.1%)
   30    5740  (35.0%)<PHONE_NUMBER>  (16.3%)         1901404  (13.6%)
   40    7487  (45.7%)<PHONE_NUMBER>  (21.7%)         2525834  (18.0%)
   50    9234  (56.4%)<PHONE_NUMBER>  (27.1%)         3150264  (22.5%)
   60   10980  (67.0%)<PHONE_NUMBER>  (32.6%)         3774694  (27.0%)
   70   12727  (77.7%)<PHONE_NUMBER>  (38.0%)         4399124  (31.4%)
   80   14474  (88.3%)<PHONE_NUMBER>  (43.4%)         5023554  (35.9%)
   90   16221  (99.0%)<PHONE_NUMBER>  (48.8%)         5647984  (40.3%)
  100   17968 (109.7%)<PHONE_NUMBER>  (54.2%)         6272414  (44.8%)
  110   19715 (120.3%)<PHONE_NUMBER>  (59.6%)         6896844  (49.3%)
  120   21461 (131.0%)<PHONE_NUMBER>  (65.0%)         7521274  (53.7%)
  130   23208 (141.7%)<PHONE_NUMBER>  (70.4%)         8145704  (58.2%)
  140   24955 (152.3%)<PHONE_NUMBER>  (75.9%)         8770134  (62.6%)
  150   26702 (163.0%)<PHONE_NUMBER>  (81.3%)         9394564  (67.1%)


Unable to execute gulp

This tracker is for bug reports only.
Before opening an issue, please make sure you've checked the following:

For support requests, please use Stack Overflow (stackoverflow.com) or Gitter (see the README).

If the bug is in a plugin, open an issue on the plugin repository, not the gulp repository.

If you're getting a deprecated module warning, don't worry about it: we're aware of it and it's not an issue. To make it go away, update to Gulp 4.0.

If you're asking about the status of Gulp 4, please don't! You can see the remaining issues on the gulp4 label: https://github.com/gulpjs/gulp/issues?q=is%3Aissue+is%3Aopen+label%3Agulp4

What were you expecting to happen?
Gulp to run normally like before I reformat my system.
What actually happened?
An error:
+<EMAIL_ADDRESS>PS C:\Users\Train> gulp html
gulp : File C:\Users\Train\AppData\Roaming\npm\gulp.ps1 cannot be loaded. The file
C:\Users\Train\AppData\Roaming\npm\gulp.ps1 is not digitally signed. You cannot run this script on the current system.
For more information about running scripts and setting execution policy, see about_Execution_Policies at
https:/go.microsoft.com/fwlink/?LinkID=135170.
At line:1 char:1
+ gulp html
+ ~~~~
    + CategoryInfo          : SecurityError: (:) [], PSSecurityException
    + FullyQualifiedErrorId : UnauthorizedAccess
PS C:\Users\Train>

Please post a sample of your gulpfile (preferably reduced to just the bit that's not working)
const gulp = require('gulp'),
	plumber = require('gulp-plumber'),
	htmlmin = require('gulp-html-minifier'),
	runSequence = require('run-sequence')

const src = './src/',
	dist = './dist/';

// Minify HTML
gulp.task('html', () => {
	gulp.src(src + '**/*.html')
		.pipe(plumber())
		.pipe(htmlmin())
		.pipe(gulp.dest(dist));
});

// Watch
gulp.task('default', () => {
	runSequence('html');
});

What version of gulp are you using?
<EMAIL_ADDRESS>What versions of npm and node are you using?
PS C:\Users\Train> npm --version
6.13.4
PS C:\Users\Train> node --version
v12.16.1

I think i mangled the gulpfile.js too much oops, It isn't required for me to reproduce the issue. It's kinda weird because I can't find any instance of this happening to anyone else.

gulp.ps1 is nothing we create. There is something wrong with your environment.

Thanks, my google skills are trash I found npm creates the ps1 files as a shim in fron of commands that are installed while running in Powershell, I guess to give it a more natural feel. I was able to add .cmd aka gulp,cmd html and got it working.

@Seeker1437 Can you explain where did you add gulp.cmd html? I am very new to Gulp and I can't make it work in VSC because of this issue.


Stacked new messages / message date.

I've found on ClearVision Amethyst that the dates for messages and the divider for new messages are stacked on top of each other.
With the BetterDiscord support server I was able to get it fixed by putting a black background on the New Message and Date dividers.

I mis-clicked close without noticing, ignore the close.

Fixed hopefully :)

As far as I'm aware, it hasn't been fixed. The issue still appears, however, it seems Discord is inconsistent as to whether or not it does show up. I'm not entirely sure what causes it.
Another issue has actually appeared in the form of the margins between the date dividers and the text below and above being a little too close. I'm not sure if that's the actual theme, or my eyes playing tricks on me, however.

it should no longer show the date divider if there is a new message divider and then when the new message divider goes the date should show

Yeah, I noticed that was happening now. Bit weird to see, but at least its fixed the date divider / new message divider overlap.


Dated W3C reference search tags

With date: "W3C Recommendation JSON-LD 1.1 2019-12-12"
https://www.w3.org/standards/history/json-ld11

@ronaldtse with a date it should give us only another link to the document and publication date, all other information should remain as in the last version, shouldn't it?

With a date we should give the link to the dated document, for example:

2020-03-16 is the "Candidate Recommendation"
2019-05-10 is the "Working Draft"

You can notice that in the actual documents, the metadata is also different:

2020-03-16 is the "Candidate Recommendation", link: https://www.w3.org/TR/2020/CR-json-ld11-20200316/

2019-05-10 is the "Working Draft": https://www.w3.org/TR/2019/WD-json-ld11-20190510/

2018-09-11 is the "First Public Working Draft": https://www.w3.org/TR/2018/WD-json-ld11-20180911/

Originally posted by @andrew2net in https://github.com/relaton/relaton/issues/50#issuecomment-601912242

@ronaldtse it seems workgroup and keyword are only on the search page

fixed by ca498d600ab6f650ec311c835fa3f4f3381119a7


Tests fail on PHP 7.1

$ php71 vendor/bin/phpunit
PHPUnit 4.8.27 by Sebastian Bergmann and contributors.

Runtime:	PHP 7.1.0RC6
Configuration:	/home/siwinski/projects/AkamaiOPEN-edgegrid-php/phpunit.xml.dist
Warning:	The Xdebug extension is not loaded
		No code coverage will be generated.

..F.........................................

Time: 2.04 seconds, Memory: 6.00MB

There was 1 failure:

1) Akamai\Open\EdgeGrid\Tests\Client\Authentication\TimestampTest::testTimestampFormat
Failed asserting that two DateTime objects are equal.
--- Expected
+++ Actual
@@ @@
 2016-12-09T00:07:14+0000

/home/siwinski/projects/AkamaiOPEN-edgegrid-php/tests/Authentication/TimestampTest.php:32

FAILURES!
Tests: 44, Assertions: 114, Failures: 1.

I was going to submit the following diff/patch but I don't know if it defeats the purpose of that test:
29a30
>         $actual = \PHPUnit_Framework_Assert::readAttribute($timestamp, 'timestamp');
31,32c32,34
<         $check = \DateTime::createFromFormat('Ymd\TH:i:sO', (string) $timestamp, new \DateTimeZone('UTC'));
<         $this->assertEquals($check, \PHPUnit_Framework_Assert::readAttribute($timestamp, 'timestamp'));
---
>         $expected = \DateTime::createFromFormat('Ymd\TH:i:sO', (string) $timestamp, new \DateTimeZone('UTC'));
>
>         $this->assertEquals($expected->format('Y-m-d H:i:s'), $actual->format('Y-m-d H:i:s'));

Here is the cause of the test issue for PHP 7.1 : http://php.net/manual/en/migration71.incompatible.php#migration71.incompatible.datetime-microseconds


Clarify GPLv3 license use

Hi!
This project looks great, but I have a question about the license. It looks like it's a GPL v3 license. To my understanding, that means if I use this library in my web app, I have to open source my entire web app under GPL v3:

Permissions of this strong copyleft license are conditioned on making available complete source code of licensed works and modifications, which include larger works using a licensed work, under the same license. [1]

Is my understanding correct?
[1] https://github.com/SortableJS/ember-sortablejs/blob/master/LICENSE.md

Hi! I'd love to follow up on this! Am I understanding the license you're using correctly?

I'll take a look at it later today. But

if I use this library in my web app, I have to open source my entire web app

Is not my intention


New RAG interface

Perhaps as part of a future project:
RAG MEHDIE:
Given a query of a name of a place / person / event:

Expand the query using our knowledge graph to give us more variations of this name / known instances in sources, and related information - related places, related people, etc.
Retrieve documents and document parts relevant the list of entities in the expanded query.
Feed the results to the LLM to construct an unstructured response with embedded links where possible describing the context of the requested place.

two specs:
API to enable linking between digital editions (Travelab and others like https://topostext.org/place/328350USyk)
llm response in selected language.


Hello , does dataset open?

Could you provide more training code? For instance, alignment pre-training and SFT configurations? Additionally, the dataset appears to be unavailable.

We are working on the dataset.

is it possible if we finetune output voice accent?

is it possible if we finetune output voice accent?

yes, but you need to prapare the data with new accent first and finetune with it.

hello, looks like the dataset still not uploaded succesfully?

hello, looks like the dataset still not uploaded succesfully?

hi, we will upload it to hf in 2-3 days.

dupe with: https://github.com/gpt-omni/mini-omni/issues/2, I'll close it for now, feel free to re-open.

hello, looks like the dataset still not uploaded succesfully?

hi, we will upload it to hf in 2-3 days.

May I ask where can I access the dataset? I cannot find it in hf.

the dataset is uploaded, path: https://huggingface.co/datasets/gpt-omni/VoiceAssistant-400K

Hello, @mini-omni  noticed that the data only contains in speech, no out speech.

Hello, @mini-omni noticed that the data only contains in speech, no out speech.

we did not save the output speech audio file, but only keeped the snac tokens of the output audio. If you need to the output audio you can use snac model to decode it to wavs.

@mini-omni Does the snac ids decode can 100% recover audio

@mini-omni  hi, may I ask which sample rate of snac were used here?

@MonolithFoundation I don't think it will 100% recover, but pretty good. The sample rating 24kHz.

@mini-omni Hi, if snac is so good, why some models still using flow matching or diffusion way to geneate audios? I listened the SNAC trained model, mostly lack of emotions and stops with signs etc., how do u think

@MonolithFoundation I think flow matching and diffusion work better for acoustic details.

but flow matching hard to streaming.


More customizable and Faster waymo evaluation

Modification

Add waymo_gtbin_creator.py in tools/dataset_converters/

Support creating local gt_bin for evaluation. No need to download.
Support creating subset of gt_bin with the information in info pkl file.
Support creating normal gt_bin or the one for camera-only challenge.

Modified waymo_metric.py

Generate gt_bin if no gt_bin is found.
Support training set evaluation for model debugging use.
Support load_interval in order to speed up evaluation.  For example, in config files, you can add load_interval=10 to val_dataloader and val_evaluator. This is only for waymo evaluation.
self.split == 'training' no longer means val set evaluation.

Modified prediction_to_waymo.py

Generate idx2metainfo.pkl in waymo_format/validation automatically if not specified.
Delete slow converting function. Get everything fast!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zltjohn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


BadRequestError: 'Token could not be verified'

Hi MarshalX.
Strange new error since this morning:
from atproto import Client, models, exceptions

client = Client()
profile = client.login('handle', 'pwd')
try:
    res = client.com.atproto.server.get_account_invite_codes(
        models.ComAtprotoServerGetAccountInviteCodes.Params(
            createAvailable=True,
            includeUsed=True)
    )
except exceptions.BadRequestError as err:
    print(err)

It throws an error with status code 400
'InvalidToken'
'Token could not be verified'
I looked at https://atproto.blue/en/latest/namespace.html#atproto.xrpc_client.namespaces.sync_ns.ServerNamespace.get_account_invite_codes again, there is nothing about a token?
What am I missing?
Please help.

pls create discussions not issues https://github.com/MarshalX/atproto/discussions/categories/questions


Streaming to voice popup is poorly themed

The switch between Applications and Screens still uses the old colours as well as the entire popup is the default dark discord.
Example Image:
https://i.imgur.com/3ZnV2iW.png

Thanks!
Should be fixed on  8bd1643


bridge-method-annotation should be an optional dep

b6e48cc4f9c7b13895673a7b4aa6399b7e236b1f introduced a hard dep on a lib which is newer than that currently bundled in core, causing problems for requireUpperBoundDeps.
@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

LGTM 🐝

@reviewbybees complete


Create order page

Create order page
Update formik to v2

Before merging, need to decide, how order urls will be handled


Repair logging client 'list_*' methods.

Broken in #1820.  Borked logging system tests pass with this patch.

LGTM


the convergence of network

Thank you for your open source code and it's helpful to me. I tried to reproduce your experiment, but I couldn't get good navigation performance. After many episodes of training, the mobile robot had no ability to avoid obstacles. Could you tell me what is the final navigation accuracy of your experiment.

Hi,
See a bit of explanation here: https://github.com/reiniscimurs/DRL-robot-navigation/issues/19
A fully trained network should be able to execute 97~99% of episodes without collisions, but it does not reach 100% collision free behavior.

Thank you for your reply. How many rounds have you trained. I tried to take laserscan data as input instead of  velodyne, but the effect was poor. I was confused about this, and could you me some suggestions?

Usually I would train for 100 epochs, that generally converges well. However, you can see proper behavior around 20 to 40 epochs.
Laserscan inputs should work and there is no huge difference in performance, as long as you bag the data correctly. You would have to explain what process you went through to set up training with laser scan, for me to give any suggestions. But as said, generally there is no difference between using flattened Velodyne scans or laser scans directly.


Feature/persistent storage

Hey, I just made a Pull Request!
This change extends the auth-backend to support Redis as memory

[x] create a file to provide a singleton instance of Redis.
[x] modified router.ts to add support for Redis if available.

@NishkarshRaj  @Ahampa07


add administrator doc in website repo about how to do migration rollback

What type of PR is this?
/kind documentation

What this PR does / why we need it:
add administrator doc in website repo about how to do migration rollback
Which issue(s) this PR fixes:
Part of https://github.com/karmada-io/karmada/issues/5380
Special notes for your reviewer:

all comments fixed


App Icon

Love the app, great implementation!  However, the app icon leaves much to be desired. When switching apps, I always feel like I'm going to a WebMD app.  Any plans on making it more music/Pandora related?  Want some help (ie If I create one for you, would you add it)? Maybe something like this: http://cl.ly/image/0W1h3L1a330s

oh fun, I was also playing around with ideas in the same vein.
http://cl.ly/2K0P3l0n2g3G


[US] As an Attestation Issuer, I want the AttestationRegistered event to contain the Attestation ID

Duplicated by #118


Chainer graph

New features

New data(set) patterns

sparse graph data(set)
padding graph data(set) with coo matrix

New models

sparse RelGCN
sparse GIN
GIN with coo matrix

New task

semi-supervised node classification on large graphs

New datasets

citation network (cora, citeseer)
reddit

Dataset class

Chemical
Network

adjacency matrix
NumpyTupleDataset
PaddingGraphDataset

scatter operation
SparseGraphDataset
SparseGraphDataset

sparse matmul
not supported
PaddingGraphDataset (use_coo=True)

updated comment

updated comment

Thank you! LGTM. I will check to run example later!

Codecov Report

Merging #398 into master will decrease coverage by 6.81%.
The diff coverage is 27.85%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   91.22%   84.41%   -6.82%
==========================================
  Files         229      234       +5
  Lines       11049    11449     +400
==========================================
- Hits        10080     9665     -415
- Misses        969     1784     +815

If you can add some test, please add test (coverage test is failing now, since new functionality is not tested.) But I am going to merge this PR, even though in current condition after I confirmed example code works.

I will merge this PR!
Known TODO: #400 #401


Rewrite addFunction of AdditiveModel to add new type of function easily

@deerzq @yolken @hectorgon @spencerde @christhetree

LGTM, I feel we need to test the recent changes by training on the real data to make sure nothing is broken.

@deerzq good point, will try that!


Add test for partitions

Codecov Report

Merging #20 into master will increase coverage by 3.7%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master      #20     +/-   ##
=========================================
+ Coverage   72.41%   76.12%   +3.7%
=========================================
  Files          17       17
  Lines         620      620
  Branches       39       39
=========================================
+ Hits          449      472     +23
+ Misses        171      148     -23

Impacted Files
Coverage Δ

src/main/scala/fr/vsct/dt/maze/core/Predef.scala
98.56% <0%> (+2.15%)
:arrow_up:

.../main/scala/fr/vsct/dt/maze/topology/Cluster.scala
67.56% <0%> (+13.51%)
:arrow_up:

.../scala/fr/vsct/dt/maze/helpers/DockerNetwork.scala
52.23% <0%> (+20.89%)
:arrow_up:

...ain/scala/fr/vsct/dt/maze/topology/NodeGroup.scala
50% <0%> (+50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ab4b0...ad4040a. Read the comment docs.


[Samples] Ensure samples are run as part of the nightly CI

The packages that have samples, have a execute:samples script which is meant to be used by the nightly test runs against live resources. This issue is to ensure that for all Track 2 packages we have this execute:samples script defined and run as part of the nightly CI.
A few checks for this to happen are

Ensure the tests and samples use the same set of env variables that point to test resources and other pre-requisites
Ensure #12555 is done
Update the pipeline

If any of the package samples need any further work or investigation, please log an issue for each package. This applies for

App Config
Search
Key Vault
Event Hubs
Event Hubs Checkpoint Store
Event Grid
Service Bus
Storage
Identity
Form Recognizer
Schema Registry
Tables
Text Analytics

Closing. We have a number of other issues at this point to track packages' individual work in migrating to v2 samples, which includes a system for running samples in CI by default.


Map k8s LoadBalancer to a secure domain for stripes and okapi

Likely route 53 will serve the custom domain. Stripes should travel over 443 to port 80 in the cluster, or perhaps we should only open 443 on the stripes container. Either way someone needs to handle redirection of 80 to 443.
Okapi needs to flow securely to the okapi port.
This is how we're able to open a k8s service to the outside: https://github.com/culibraries/folio/blob/c8d415b5326669904c8c61b4de098b402762c3d5/pulumi/folio/folio.ts#L172
Enabling this produces a AWS domain specific URL on http. This is likely what we're going to have contact with.
Here is a doc: https://aws.amazon.com/premiumsupport/knowledge-center/eks-kubernetes-services-cluster/

This is the help doc we need: https://aws.amazon.com/premiumsupport/knowledge-center/terminate-https-traffic-eks-acm/
Making this work involves: getting a public ACM certificate, getting the ARN of that cert, and binding the cert to the LoadBalancer service through annotations on that service. It looks like the annotations also enforce SSL.
I don't think we are using AWS certs currently but the same principle should apply. I think all we should need is an ARN for the cert, and presumably we have that either way.

Annotations for the service are things we can easily modify in folio-helm: https://github.com/folio-org/folio-helm/blob/909c24048d1f4d800788da9997a47bfabb17b280/platform-complete/values.yaml#L21

When a service of type LoadBalancer is created in k8s, EKS automatically creates a ec2 load balancer which opens the service up to the outside world. It would appear that the type of load balancer that EKS is creating for us is a classic load balancer.
Is this type of load balancer going to be retired by AWS at the end of the year?
I think it is not. There is confusion because another service type with a very similar name is going to be retired, but the Classic Load Balancer when used in a VPC will not be.

There is some discussion of the confusion here. Scroll down to the bottom for the most helpful answer.
See this aws blog post which recommends migrating classic load balancers by which it means migrating them from a classic EC2 networking cluster (the actual thing being retired) to a VPC.
See this help doc which says definitively that you can "migrate to a Classic Load Balancer in a VPC".

As I have said elsewhere, I think the simplicity of the Classic Load Balancer fits our use-case more closely, because 1) it's easier to setup and maintain, and 2) it makes it much easier to open up load balanced services on non-http ports (like for edge-connexion). Many of the features of an Application Load Balancer just don't apply to us.

This is the help doc for how to route route53 traffic to the ELB: https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-to-elb-load-balancer.html. So the steps are:

Completed by: https://github.com/culibraries/folio/pull/145


Update lzomnichain discovery and project page

Resolves L2B-2910

this part of the description is a bit misleading. While it's true that there is only one contract that is not verified, it doesn't specify which.

2d6183b

2d6183b WDYT?

 this part of the description is a bit misleading. While it's true that there is only one contract that is not verified, it doesn't specify which.

2d6183b WDYT?


Genre/year using plex_search not working with TV Shows

Applied a few plex_search collections for my TV shows library and they turned out empty even though I definitely have TV shows with these genres. Very strange, because it worked perfectly with my Movies Library, and I was also able to get other collections working with my TV Shows library (Star Wars from TVDB List).
This is the plex_search portion of my current setup in TV Shows.yml:
collections:
  Animated TV Shows:
    plex_search:
      genre: Animation
    sort_title: ++_Animated TV Shows
    sync_mode: sync
    collection_order: alpha
  Comedy TV Shows:
    plex_search:
      genre: Comedy
    sort_title: ++++_Comedy TV Shows
    sync_mode: sync
    collection_order: alpha
  Drama TV Shows:
    plex_search:
      genre: Drama
    sort_title: ++_Drama TV Shows
    sync_mode: sync
    collection_order: alpha

It seems to be working perfectly fine with movies, with almost an identical setup. Added this after line 904 in config.py to see if I could debug a bit more
items = library.Plex.search(**search_terms)
items_found += len(items)
print("[DEBUG]: \n", library.Plex.search(genre=["Comedy"]))

and I was able to get a list for the Movies without an issue. However, with the TV shows it results in an "Unknown filter" error for both genre and year. Might be an issue on the end of PlexAPI or I could be doing something wrong here as well.

I have the same issue, and it does appear to be an issue with PlexAPI. I was able to workaround this by using the following config instead for the TV Library. It appears to be slower vs a plex_search, but at least it works.
    '* Comedy':
        sort_title: "* Comedy"
        sync_mode: sync
        plex_all: true
        filters:
            genre: Comedy

yea this pull request will fix the errors https://github.com/pkkid/python-plexapi/pull/598

Perfect, makes sense. Might be nice to edit the WIki  too for now. I would do it, but AFAIK Github doesn't support PRs for the Wiki stuff.

follow this PR for updates https://github.com/pkkid/python-plexapi/pull/693


Search results disappear/reappear while typing in search text

So I did this: if results are not empty; and if new results are empty; keep old results until new results are not empty. Looks like its fixed. Closing issue


pip only installs the dist-info

Ran pip install dalaipy==2.0.2
Dalaipy was not imported -> checked pip show dalaipy
went to the path it pointed, and there was only the dist-info part.
guess this was the problem for #3

I agree with @BlueveryPi

same


Add explicit <IP_ADDRESS> IP addresses to docker-compose.yml

This prevents your running Docker containers from being hit by network-wide security scans.
How to test this PR

Pull branch
Ensure docker-compose up continues working as expected

Notes and todos

I believe this causes a conflict between the Postgres container and a running local Postgres service, if you happen to have both. As far as I can tell, the best workaround is simply to stop the local service when firing up the container.

Checklist

[x] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[x] Changes are limited to a single goal (no scope creep)
[x] Code follows the standards laid out in the CFPB development guidelines

Yes please.


metric with tags doesn't work

I use the graphite in Docker (this one:https://github.com/graphite-project/docker-graphite-statsd)

when I send a metric without tags, everything seems good. well, if I add tags with metric I can't found my metrics anymore.
I have checked the carbon log but nothing found
Plz give me a hand, thanks a lot!

Yes, that's how it works for now. Tagged metrics' name is hashed and resides under _tagged directory. So, dashboard doesn't currently support tagged metrics, you'll need e.g. Grafana to render it properly.

See https://github.com/graphite-project/carbon/issues/813

Right, I lost two hours on trying to resolve this "problem".


Add an API to create surfaces based on a set of points

Hi sgenoud! Thank you for your selfless dedication and excellent open source project. I have implemented such a function, which can directly generate Three.js surfaces, but in Repliccad, I seem to have not found a package for surface number types. If this library also supports surfaces, I can add surface fitting functionality.


Feature/automated soft credits  updating primary contact

Resolves the IsPrimary flag not being set issue on some OCRs when the Opportunity's Primary Contact is changed.
Critical Changes
Changes
Issues Closed
Fixes #2894
New Metadata
Deleted Metadata

@joy-sfdo do we want this fix going into master, or into a reviewed soft credits branch?  @mpusto did you want this fix sooner, or with all of the soft credit automation work when its complete?


Swipe trap iOS 12.1.4/VoiceOver

Description
Can't swipe right past  "Icons" in Hamburger menu using iOS 12.1.4/VoiceOver. VoiceOver users are trapped when the try to swipe past the work "Icons" link. They can explore by tough to move past it but it would take some guessing and the user could be lost afterwards.
Location
Hamburger menu
Priority
High
Recommended fix
Unknown fix
LOE
High

This is for the old website, and should not be an issue in the new website. Closing as resolved through new site.

This is for the old website, and should not be an issue in the new website. Closing as resolved through new site.


Model update history on ollama.com

Would be nice if we can see what has been updated for a model on the ollama.com

We've talked about this for a while, and it's definitely something we'd like to add. I'm debating where to track this though; the issue is essentially the same as #5169.

@qzc438 nothing to report yet. We do have a rewrite of the ollama.com backend happening which should make features like this easier to do.


"When will the source code be released?"

I've been thoroughly impressed by your work on "ShapeLLM: Universal 3D Object Understanding for Embodied Interaction" and am keen to explore it further. Could you please let me know when the associated source code might be available? "Thank you very much, and I apologize for any disturbance."

Thank you for your attention! The code will be released today.

Hi @lyshuang,
The code has been released. Enjoy.


Evaluate updating to GATK <IP_ADDRESS>

"Evaluate", because it's not the first time there are regressions, but the new version comes with important fixes in Mutect2, so it might be worthwhile to update.

Indeed we have it already. I'm not sure to keep this open, since it's already there.

Hi Luca,
I was actually pretty happy that you opened this thread. We could compare notes, if you like. I am putting some numbers together right now.
We started with some germline comparisons of WES data, but we are most interested in the potential Mutect2 improvements.

We are using a number of different dilutions of NA12878 in NA24385 (40%, 20%, 10%, 5%). The analysis is "tumor only" which is the clinical use case. We are most concerned about FDR.
In total, there are a little more than 1000 SNVs and 150 Indels in the target regions.
As with <IP_ADDRESS>, the results are somewhat mixed and not really an improvement. As far as I can see the differences are caused by changes in the filtering in mutect2. They do not seem to be related to allele frequency. From my point of view I cannot really argue in favor of an update. What is your take?
Mutect2 <IP_ADDRESS>

Mutect2 <IP_ADDRESS>

From our side we'd mostly be worried about missing true positives, so that FNR jump is not what I'd want to see...

Hi Ben and Oliver,
You all are the experts here-- so I defer to whatever you all think is the way to go. Hopefully some other folks will get in on the discussion. That is a nice test idea Ben. I am curious if there is something common about the false negatives/positives in general and the new false negatives with <IP_ADDRESS>. Maybe we can address this by fiddling with some of Mutect's filtering parameters. Ben, if you could pass along the calls and some markup of which ones are false positives/negatives from each of the runs we could see if setting some flags might help out.

Mutect2 now has dropped most filtering options in favor of a single parameter that can be tweaked for accuracy or sensitivity, IIRC. @gabeng Just to make sure I understand your graphs correctly, are they paired or tumor-only analyses?

It is tumor only. I will try to differentiate between low-AF and germline variants. It may look better in a tumor-normal setting, when it is not critical that true germline variants are removed by aggressive filtering.

Did you try filtering with already-known GNOMAD sites as mentioned in #2873 (not yet in bcbio, but up for discussion)? It should have at least some impact as far as I can see (known sites are not even taken into account).
Although I'm not sure if it would improve the FNR.

No, I have not yet tried filtering against gnomAD. I was afraid of creating yet another copy of that data set.
In general, I would like to put filtering against populations or other data pools (e. g. PoN) at the very end of a pipeline, or even leave it optional. Those reference populations change over time and make re-analysis under identical conditions challenging. It also may not really reflect the performance of a variant caller.

At least for my own data sets I had to put in place very aggressive filtering and a PoN because at least the Mutect2 defaults tend to (IMO) over-call variants in tumor only mode.

Thanks everyone for the discussion, sorry to be slow about getting around to this stuff. Luca could you share what you did?

Running https://github.com/bcbio/bcbio_validations/tree/master/somatic_trim, I see an increase in false negatives for indels over previous validations for mutect2 in tumor-normal mode, so the opposite problem with tumor-only:

Looking at tumor-only now.


Time Validity issue

So I found an odd issue. I get an error when searching for lyrics that the certificate is not within the validity period. If I try and go to the URL that is provided it gives me the certificate error where I can "Advance" through it. Here is the error that I am getting, it is for every song I have.
error sending request for url (https://lrclib.net/api/search?track_name=<track_name>%28Album+Version%29&artist_name=&album_name=): error trying to connect: A required certificate is not within its validity period when verifying against the current system clock or the timestamp in the signed file. (os error -2146762495)

Oops, it seems my cron job for renewing Let's Encrypt certificate does not working, so now the certificate is expired. I'll check it out.

I've renewed the certificate. The issue was that the certbot-renew.timer timer was inactive by default, so the certificate renewal service certbot-renew.service did not run as expected. I will monitor this closely over the next few days to ensure it runs as intended. Thank you for notifying me of this issue!

Is there anything I need to do on my end?
Re-download something?

Is there anything I need to do on my end? Re-download something?

Nevermind :) I just had to try it again. I was on my phone when I messaged before.
Thank you for the quick turn around!

Hi, LRCLIB website and APIs are blocked for old androids probably <7.1.1 devices from yesterday, (after certificate renewal). I think it's related to this issue so that I'm writing here.
The website shows NET::ERR_CERT_AUTHORITY_INVALID. I can skip that warning to load the website.
But API requests are throwing IO Exception during network request: java.security.cert.CertPathValidatorException: Trust anchor for certification path not found.

@abhishekabhi789 I've just renewed the cert again with certbot renew --preferred-chain "DST Root CA X3"  --force-renewal. Could you check it if it works again for Android <7.1.1?

Yes the problem seems fixed. I can access the website & API from android 6 device. Tested on Android 6. Thanks for the patch. Tested on Android 6


[Eco Pass KIT v2.0.0] Update Technical Context Diagram

What needs to be changed?
The context image is outdated and needs to be fixed here:
https://github.com/eclipse-tractusx/eco-pass-kit/blob/bc89fbdaabcf7bd54725e6f20e0b1e8abac86e59/docs/page-software-development-view.md?plain=1#L16
New Content:

review done, just a minor adjustment of the licensing years needed. other than that fine


feat: noPrecompiles modifier or function

Ref https://github.com/foundry-rs/foundry/issues/1228
The fuzzer will pass precompile addresses to tests. These are valid inputs so we don't want to strip them from the fuzzer, but in some tests they can cause problems. The scope of this issue is to add a modifier OR a function (I'm not yet sure which we should prefer, open to discussion here, as well a name other than noPrecompiles) that does something like this:
// --- forge-std ---
// Use this version to infer the chain ID from the test environment.
function noPrecompiles(address who) internal {
  noPrecompiles(who, block.chainid);
}

// Use this version to specify which chain's precompiles to use.
function noPrecompiles(address who, uint256 chainId) internal {
  if (chainid == 1 || chainid == 31337) {
    // Mainnet precompiles: https://www.evm.codes/precompiled
    vm.assume(who > address(9));
  } else if (chainid == 10 || chainid == 69 || chainid == 420) {
    // Optimism precompiles: https://github.com/ethereum-optimism/optimism/blob/master/packages/contracts/contracts/libraries/constants/Lib_PredeployAddresses.sol
    vm.assume(who < 0x4200000000000000000000000000000000000000 && who > 0x4200000000000000000000000000000000000013);
  }
  // etc. for other chains
}

// --- myTest.t.sol ---
function testSomeAddress(address a, address b) public {
  noPrecomples(a); // Precompiles for `b` are allowed.
}

I think including mainnet, optimism, and arbitrum precompiles is a good start for this PR

Additional modifiers to exclude foundry addresses (such as Vm and the test contract), as well as an array of user provided addresses, would also be useful

Per @mds1 request on #1078, here are some additional precompiles for Avalanche evm-based subnets. A list of such subnets is maintained here.

One thing to note is that Optimism doesn't have extra precompiles, they are technically predeploys so they are evm bytecode placed at specific addresses. I do think that it makes sense to avoid those addresses while fuzzing, it makes sense to include them in assumeNoPrecompiles. In the address space for predeploys is 0x4200..00 to 0x4200..0800` in bedrock, the first 2048 addresses in that range

Closed by https://github.com/foundry-rs/forge-std/pull/184


Define binary serialization format

Is your feature request related to a problem? Please describe.
Consider how we want to serialize/deserialize binary assets.
We likely want them to be packaged into a sort of package file and then mapped into main memory.
Related to #17
Describe the solution you'd like
TODO
Describe alternatives you've considered
TODO
Describe the acceptance criteria
TODO

Closing as unneeded. Will be defined on an "as we go" basis


BatchWrite does not handle Unprocessed Items correctly and ignores them

Describe the bug
During a BatchWrite operation some writes may fail due to things like Throttling. The response will include the Unprocessed items so that they can be processed again to ensure they are written to the database.
The BatchWrite method in OneTable does have the code to handle this, but looks at the wrong place to get the Unprocessed Items so it never finds any and just continues without reprocessing them.
Note: I've only tested this with the SDK v3. I don't know if the same issues exists on v2.
To Reproduce
Write a large number (e.g 50,000) items into a table using a BatchWrite, because of 25 item max batch you'll need to do multiple requests. In order to ensure you trigger Throttling issue you can run multiple BatchWrites concurrently.
After the write has been complete check how many items were written into the table. If you experienced throttling then the number of items will be less than the number you intended.
Expected behavior
All items to be written to database.
I have a PR from April that highlights the minor changes required to fix it: https://github.com/sensedeep/dynamodb-onetable/pull/470

Thanks Alex, merged.


ARROW-432: [Python] Construct precise pandas BlockManager structure for zero-copy DataFrame initialization

This avoids "memory tripling" (because pd.DataFrame will often immediately consolidate the arrays) and also will allow the Arrow->pandas deserialization to be parallelized for further performance gains.
@xhochy this also has the effect of coercing all timestamps to datetime[ns] -- for pandas I believe this is the proper behavior, but wanted to run it by you.
In a local benchmark on roughly 1GB of data I have:
setup code:
import numpy as np
import pandas as pd
import pyarrow as pa

DATA_SIZE = (1 << 30)
NCOLS = 100

data = np.random.randn(NCOLS, DATA_SIZE / NCOLS / 8).T
data[::2] = np.nan

df = pd.DataFrame(data, columns=['c' + str(i) for i in range(NCOLS)])

table = pa.Table.from_pandas(df)

before these changes (I added block_based argument to toggle this code path off):
In [4]: %timeit df2 = table.to_pandas(block_based=False)
1 loop, best of 3: 252 ms per loop

In [5]: %timeit df2 = table.to_pandas()
10 loops, best of 3: 139 ms per loop

This takes the effective in-memory bandwidth on numerical data from 3.97 GB/s to 7.19 GB/s.
I also moved the clang-format files to the top level so we can more easily run code formatting on the C++ code under python/.

Seems Appveyor is stuck

+1 -- so that this patch doesn't linger over the holidays, I'm going to merge so I can proceed with development between now and the new year. @xhochy if you could review the datetime specific changes and any other issues you are worried about, I'll be happy to address feedback in a follow up patch. thank you!


[AutoPR apimanagement/resource-manager] [DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6487

(message created by the CI based on PR content)


feat: introduce at_signing_algo and hashing_algo in at_auth_request and at_onboarding_request

Closes https://github.com/atsign-foundation/at_libraries/issues/602
- What I did

Introduce SigningAlgoType and HashingAlgoType in at_auth_request and at_onboarding_request
Pass signingAlgo and hashingAlgo to at_lookup instance while creation

- How to verify it

when using an signing or hashing algorithm other than the default should, indicate the same while sending a from verb command to server

- Description for the changelog

feat: introduce at_signing_algo and hashing_algo in at_auth_request and at_onboarding_request

A functional test has been added but skipped for now. It will be unskipped once https://github.com/atsign-foundation/at_server/issues/2045 has been resolved

@sitaram-kalluri @srieteja https://github.com/atsign-foundation/at_server/issues/2045 has been resolved - let's unskip the test and get this PR reviewed and merged


Update README.md

Updated links to new repo name and included brief instructions for submitting issues.

@furqanMM,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Cannot prevent renaming of static class property using externs

React's ES6 classes approach to React Components requires a class / static property "childContextTypes" to be defined if using contexts (the same goes for the more familiar React concepts "propTypes" and "defaultProps"):
class X extends React.Component {}
X.childContextTypes = {};

I can't find a way to prevent this being renamed or removed (other than using [""] notation, or exportSymbol, which requires my non-CC-savvy developers to remember to use this pattern - somewhat error prone. Here are some externs I've tried:
Object.childContextTypes;
React.Component.childContextTypes;
React.Component.prototype.childContextTypes;

I would have thought that the Object.childContextTypes approach would prevent this property being removed or renamed on every type it was found upon.
I've tried to find the minimum options in the debugger that show this. However I think there's more than one combination. In my use case, I'm compiling using advanced level, and the propTypes and childContextTypes lines are both being removed. Not sure which of the debugger tickboxes correspond to advanced.
Here's one combination which shows it being renamed:
https://closure-compiler-debugger.appspot.com/#input0%3Dclass%2520X%2520extends%2520React.Component%2520%257B%250A%2520%2520%2520%2520constructor()%2520%257B%250A%2520%2520%2520%2520%2520%2520%2520%2520super(%257B%257D)%253B%250A%2520%2520%2520%2520%2520%2520%2520%2520console.log(%2522here%2522)%253B%250A%2520%2520%2520%2520%257D%250A%257D%250A%250AX.propTypes%2520%253D%2520%257B%257D%253B%250AX.childContextTypes%2520%253D%2520%257B%257D%253B%250A%250Anew%2520X()%253B%26input1%26conformanceConfig%26externs%3Dvar%2520React%2520%253D%2520%257B%257D%253B%250A%250A%252F**%250A%2520*%2520%2540constructor%250A%2520*%2520%2540param%2520%257BObject%253C%253F%252C%253F%253E%257D%2520props%250A%2520*%252F%250AReact.Component%2520%253D%2520function(props)%2520%257B%257D%253B%250A%250AObject.childContextTypes%253B%250AReact.Component.childContextTypes%253B%250AReact.Component.prototype.childContextTypes%253B%250A%250A%26refasterjs-template%26includeDefaultExterns%3D1%26CLOSURE_PASS%3D1%26COLLAPSE_PROPERTIES%3D1%26LANG_IN_IS_ES6%3D1%26VARIABLE_RENAMING%3D1
And here's one which shows it being removed:
https://closure-compiler-debugger.appspot.com/#input0%3Dclass%2520X%2520extends%2520React.Component%2520%257B%250A%2520%2520%2520%2520constructor()%2520%257B%250A%2520%2520%2520%2520%2520%2520%2520%2520super(%257B%257D)%253B%250A%2520%2520%2520%2520%2520%2520%2520%2520console.log(%2522here%2522)%253B%250A%2520%2520%2520%2520%257D%250A%257D%250A%250AX.propTypes%2520%253D%2520%257B%257D%253B%250AX.childContextTypes%2520%253D%2520%257B%257D%253B%250A%250Anew%2520X()%253B%26input1%26conformanceConfig%26externs%3Dvar%2520React%2520%253D%2520%257B%257D%253B%250A%250A%252F**%250A%2520*%2520%2540constructor%250A%2520*%2520%2540param%2520%257BObject%253C%253F%252C%253F%253E%257D%2520props%250A%2520*%252F%250AReact.Component%2520%253D%2520function(props)%2520%257B%257D%253B%250A%250AObject.childContextTypes%253B%250AReact.Component.childContextTypes%253B%250AReact.Component.prototype.childContextTypes%253B%250A%250A%26refasterjs-template%26includeDefaultExterns%3D1%26CLOSURE_PASS%3D1%26COLLAPSE_PROPERTIES%3D1%26LANG_IN_IS_ES6%3D1%26REMOVE_DEAD_CODE%3D1%26SMART_NAME_REMOVAL%3D1

A static property like that isn't inherited from a parent and therefore externs will have no impact on it's renaming - unless the type based optimizations are disabled (--use_types_for_optimization=false). To prevent renaming and collapsing of a static property on a class, your only option is to use quoted properties.
If you make it a class property, then externs will work:
X.prototype.childContextTypes = {};

I realize that ES6 classes have no shortcut method to define a property like this as the spec pushes developers to use getters and setters.
Or as an instance property in the constructor:
constructor() {
  super({});
  console.log("here");
  this.childContextTypes = {};
}

Thanks @ChadKillingsworth. Unfortunately I'm not able to choose to use a class property since this is the React spec/requirement.
Not sure what you mean about no shortcut method.
For cases like this and presumably others, some possibilities:

allow a way of giving a type name to the class object (well, constructor) itself, to allow extern'ing its properties;

allow some kind of wildcard extern that prevents tells CC "this property name might exist or be used on ANY object" hence don't rename or remove it?

Meanwhile I'll manage with quoted properties.

For 1) A class is a type. But static properties attached are not part of that type. They are an entirely different object/type. This is intrinsic to the compiler's type system.
For 2) This is the behavior when the type-based optimizations are disabled. See https://github.com/google/closure-compiler/wiki/FAQ#some-of-my-properties-are-getting-renamed-but-some-arent-why
You will also need the @nocollapse annotation to prevent the property from being removed from the class.

Understood. It would be useful to be able to prevent this without using quoted property access and without disabling fundamental parts of the optimisation and obfuscation; React is a tiny part of our large codebase. I'm using quoted names and have added a custom eslint rule to my project to fail if a developer forgets.

There are two issues here:  property collapsing and property renaming.  Property collapsing converts properties to variables (see https://developers.google.com/closure/compiler/docs/limitations?hl=en#implications-of-object-property-flattening).
You can work around the inheritance problem Chad talks about  by declaring the property name on Object.prototype or Function.prototype in the externs (prevents renaming). AND then use @nocollapse on the property in your code.      The compiler currently will never remove a non-collapse constructor property (see https://github.com/google/closure-compiler/wiki/Understanding-Property-Removal) unless then entire class isn't referenced.
We would like to soften property collapsing but when we do we will likely also enable direct unused constructor property removal (when that happens, your original external solution will work) and ES6 class promote "class-side" constructor property inheritance.

I'm using quoted names and have added a custom eslint rule to my project to fail if a developer forgets.

@supersteves 🎉  would you be happy to share that rule?

@joscha Sure, it's an eslint plugin you'll need to add to your .eslintrc:
"use strict";

module.exports = {

	// http://eslint.org/docs/developer-guide/working-with-rules
	// https://github.com/estree/estree
	// https://github.com/estree/estree/blob/master/es2015.md

	rules: {
		"no_react_dotted_static_props": function(context) {
			// Prevents you using class X extends React.Component
			// then adding X.defaultProps etc.; these must be accessed as X["defaultProps"]
			// as there is no way to avoid Closure renaming/removing them:
			// https://github.com/google/closure-compiler/issues/1155

			return {
				"AssignmentExpression": function(node) {

					// VERY primitive check:
					if (context.getSource().indexOf("React.Component")>=0) {
						var code = context.getSource(node);

						if (code.indexOf(".defaultProps")>=0 ||
							code.indexOf(".propTypes")>=0 ||
							code.indexOf(".childContextTypes")>=0)
						{
							context.report(node,
									"Dotted access to defaultProps/propTypes/childContextTypes is not allowed " +
									"and will be renamed and/or removed by Closure Compiler. " +
									"You must use [\"\"] notation instead, e.g. MyClass[\"propTypes\"] = {...};");
						}
					}
				}
			};
		}
    },
    rulesConfig: {
        "no_react_dotted_static_props": [2]
    }
};


Add detail on task relationships in Dependencies guide

Direct feedback from a customer, whom at the time was looking for bet practices on inserting a manual step in a DAG:

It might be handy to include documentation on the list/tuple syntax of task relationships (a >> (b, c) >> d) ... it's handy and the core documentation doesn't cover it AFAIK.

There's already a good bit in the existing Managing Dependencies in Apache Airflow, but it should be looked at and added to.

^ Added a quick example, should be enough for this