[youtube] Can't download recently finished broadcast.

[x] I've verified and I assure that I'm running youtube-dl 2017.10.12

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

C:\Users\User>youtube-dl -v https://www.youtube.com/watch?v=ELUCUFQp1_k
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=ELUCUFQp1_k']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2017.10.12
[debug] Python version 3.4.4 - Windows-10-10.0.15063
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] ELUCUFQp1_k: Downloading webpage
[youtube] ELUCUFQp1_k: Downloading video info webpage
[youtube] ELUCUFQp1_k: Extracting video information
[youtube] ELUCUFQp1_k: Downloading MPD manifest
[debug] Default format spec: best/bestvideo+bestaudio
[debug] Invoking downloader on 'https://r3---sn-gvnuxaxjvh-5c5e.googlevideo.com/videoplayback?requiressl=yes&expire=1507877736&itag=18&signature=0F3E3E3EFBFB541F1EACC11FB2D7D05ED33DE7A2.75620A6D2348AD91819D4563CAFB3A769932DA4C&key=yt6&ms=lv&id=ELUCUFQp1_k.0&ei=CA_gWZz4DcaudM7hn8gM&mv=m&pl=18&mt=1507856060&sparams=ei%2Cgcr%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cexpire&mn=sn-gvnuxaxjvh-5c5e&gcr=ru&source=youtube&mm=32&ipbits=0&ratebypass=yes&initcwndbps=940000&ip=<IP_ADDRESS>&mime=video%2Fmp4'
ERROR: unable to download video data: HTTP Error 404: Not Found
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmphdp9utoa\build\youtube_dl\YoutubeDL.py", line 1892, in process_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmphdp9utoa\build\youtube_dl\YoutubeDL.py", line 1831, in dl
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmphdp9utoa\build\youtube_dl\downloader\common.py", line 361, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmphdp9utoa\build\youtube_dl\downloader\http.py", line 286, in real_download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmphdp9utoa\build\youtube_dl\downloader\http.py", line 74, in establish_connection
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmphdp9utoa\build\youtube_dl\YoutubeDL.py", line 2195, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default
urllib.error.HTTPError: HTTP Error 404: Not Found

https://www.youtube.com/watch?v=ELUCUFQp1_k
It's temporary issue, so example would be useless in time.

Most likely requested format wasn't yet encoded at the time of a request.


[CodeCompletion] Fine grained prioritization

Introduce CodeCompletionFlair that is a set of more descriptive flags for prioritizing completion items. This aims to replace SemanticContextKind:: ExpressionSpecific which was a "catch all" flag.  Also, use Flair to describe "is argument labels".

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test


Failing tests

It seems updates to the Coinbase Pro API have broken many tests. I only see the first 10 of 21 tests passing right now.

A number of tests have been failing since before my last spurt of work in December. I don't recall how many precisely, but I just re-ran the test suite on master and none of the failures jump out at me as new.
We had some discussion about this previously, and I opened issue #7 in particular. All failing tests on master related to the WebSockets API (three of the ten failures) are fixed in my still unmerged channels branch. I had intended to move on to fixing the broken REST calls, but I got distracted before tackling it.
The channels branch has a somewhat improved test suite, as noted in the pull request, #10. (I get 7 of 45 tests failing right now; all of the failures are of REST functionality, untouched by me.) The new local tests of the WebSocket functionality that I added, e.g., tests parsing the JSON examples from the Coinbase Pro documentation, are what I had in mind to add for the REST calls. Writing tests like this is a good way to start figuring out why the current tests are failing.

Thanks. Seems first step is pulling in your merge request and then working backwards to fix the other problems. I will work on that.

Let me know what you want to take on. I can probably find some time to jump back in and help whip everything into shape. And I think I might have some additional changes in my fork or a local repo.

Re-posting here after mistakenly creating a new issue. Here's the run-down on the test failures. These look like they're be straightforward to fix:
There are seven tests that consistently fail right now, all related to REST API calls. All of these tests also failed before the dependency set update.
One failure is an error parsing into the Account type, (via the getAccounts call; the failing test is labeled getUSDAccountLedger). The FromJSON instance is derived generically. It looks like Coinbase changed a JSON field from a number to a string?
Five of the other six test failures are HTTP 400 "Bad Request": "OrderValidation" errors,  and the sixth (getOrderList) fails with the message "Received empty order list". Presumably these are all due to a common cause, which looks like it probably has to do with the order-creation action defined in the tests, creatNewLimitOrder [sic].
One or two other tests sometimes fail for me due to rate limiting. The docs show that the rate limit for public endpoints is three calls per second, so these tests are in fact likely to get rate-limited sometimes if we're not explicitly delaying them (are we?). Our tests must be strangely slow for this not to happen more often if we're not delaying the calls.
I'll get to work on this tomorrow, probably, unless you want to tackle it before then, @dimitri-xyz.

I looked at the six tests that all fail because the sandbox server doesn't like the orders we're submitting. The requests we're sending look fine to me, and nothing in the order-submission process has changed, so far as I can tell from the documentation.
Google shows a StackOverflow question citing the "OrderValidationError" message from a few weeks ago (with no answers), and an inaccessible IRC log in which somebody asked about it. No further leads.
I suspect this is something screwy going on with the sandbox server, which seems to happen from time to time. I emailed Coinbase Pro support about it; we'll see if I get a response.
I'll create a PR momentarily to fix the failing getUSDAccountLedger test; go there for details.

After following up with Coinbase support to provide a detailed example of an order-submission request that results in a successful order placement on the live server but an "OrderValidationError" on the sandbox server, I just got an email saying the issue has been marked as resolved and closed, with no further explanation.
The tests still fail on the sandbox server. So much for that.

Oh, and to be clear I did debug this pretty thoroughly and noticed nothing wrong with our HTTP requests encoding order submissions. In a couple of test examples, the live server accepted order submissions that were identical up to the necessary differences in URL and authentication headers. I don't think authentication is the issue, as other authenticated calls work on the sandbox server.
In short, I'm fairly confident the problem is on Coinbase's end, which makes this rather frustrating. A sandbox server that behaves differently from the live server and is simply broken for long periods is more trouble than it's worth.
One last thing: there two diverging code paths for making REST API calls against the live server and sandbox server, coinbaseRequest and realCoinbaseRequest in Coinbase.Exchange.Rest. I'm not sure whether this is a vestige of some past functionality, but it's redundant and ugly, as is much of the nearby code related to order submission (e.g., some request headers are set more than once), and could benefit from refactoring. It's also where the problem likely lies if indeed the failing tests are our fault rather than Coinbase's.


Allow for pre-built indexes (mmi, fai)

Description of feature
Allow for inputing pre-built indexes (mmi, fai).

While allowing for fai input, the mmi index will overwrite any settings set by the pipeline and should be added/used with care.


Slider with one slide and show part next/prev

Issue description:  Hi!
I'm triyng to program this slider with some specials peculiarities. I'm using the item's value with decimals (1.2) to show part of the next slide (or previous slide if the user goes back). My problem is that I don't know what can I do to get the efect of the next images:
This is how will see the first slide and the others except the last.

Actually, my last slide has that position:

And I need that its final position was like this image:

I need that the user see the first slide and part of the next when he move the slider to right. When he arrives to the last slide, I don't want space on the right side of slide. The last slide is located without right margin and instead of show part of the previous slide.
I create a demo to show you how its the slide configured.
Demo link/slider setting:   https://codepen.io/bgarcilaso/pen/PozbdVW
Thanks!

@BGarcilaso I see you closed this the next day after you created this issue, were you able to solve this?


[UBS Admin. Orders] Order is not displayed after inserting its number into the "Search" field

Environment: Windows 10 Google Chrome 96.0.4664.110
Reproducible: always
**Build found:**28.01.2022
Preconditions

Sign in  as Admin

Steps to reproduce

Go to UBS-Admin Orders (https://ita-social-projects.github.io/GreenCityClient/#/ubs-admin/orders)'
Write any orders number in the "Search" field (ex. 35, 41, 50 etc)

Actual result
Orders inserted into  the "Search" field is not displayed
Expected result
Orders inserted into  the "Search" field is displayed in the table
https://user-images.githubusercontent.com/95848159/151590609-a3b2cbd1-1a62-4b91-b0e9-9910c2672f4f.mp4

Search works for all cells of table.


Opening a second scroller requires two clicks

Once I've opened one scroller from the editor, whether I close it or not, opening another one requires me to click the Open button twice. It should only require one click.

done.


clustering fixes, do not fix pars, grid decimation

Fixed two problems that caused clustering, or rather estimation, to go wrong:

the decimation of the grid didn't work correctly, with a decimation of 2 there was no change to the number of models (with 5 PCs, 243 models)
due to the addition of fix_pars to the sliding_event arguments, the pool inputs from sliding_event_mags were wrong, setting this new argument to 1...

Can you somehow prevent the changes to the tutorials? I did not intend to change them (though I guess it's also not a problem).

I cannot uncheck the changes to the tutorials, could you do a new PR? There are also ways for you to remove these files but I'll probably be longer

Not entirely sure either, I think this will delete the files entirely
On Wed, 19 Jul 2023 at 14:11, Jelmer Borst @.***> wrote:

I deleted them... but I'm not sure whether I deleted them from the commit
or whether they will be deleted if you merge.
—
Reply to this email directly, view it on GitHub
https://github.com/GWeindel/hsmm_mvpy/pull/78#issuecomment-1641971725,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3LE5Y3IY7IGFCFBGRYCILXQ7FINANCNFSM6AAAAAA2PVUHIY
.
You are receiving this because your review was requested.Message ID:
@.***>

Do not merge, can be removed.


Fix cancel process

Ensure that the Pod can be safely stopped even if it is canceled before it becomes Running.
Allow kubejob-agent to set timeout

Codecov Report

Merging #61 (ff0867e) into master (90ef5cb) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   55.14%   55.12%   -0.02%
==========================================
  Files          10       10
  Lines        2109     2117       +8
==========================================
+ Hits         1163     1167       +4
- Misses        760      764       +4
  Partials      186      186


Request to be an elector for TOC election

Github Username: sklevenz
Affiliation: SAP
Community participation: member of governing board

Thanks, @sklevenz! Closed via 9c4cf89359cdb6dd2c744f0c8bb2e6a1f839f821.


There is no method to get id_token instead of access_token

Our service provider requires a payload from decoded JWTs.  Calling getAccessToken() returns the access_token, however, doesn't include a payload.  In the same property is a key named id_token (from the OpenID spec) which includes a payload with who was authenticated.  Is there a built-in way to get this?  Of course I can query the properties service to get it, however, it seems that there should be some built in function that validates access is still valid, etc.  Any suggestions on how to proceed with this?  I realize this is maybe more of a how-to, however, I doubt folks on Stackoverflow will be familiar with this library.

To close the loop, it was possible via getToken().id_token, but you recently added a dedicated getIdToken() method which is a shortcut for that.


Help adding kernel support for Fairphone 4

What device do you have?
Fairphone 4
What is the output of uname -a on the device?
Linux AloeHumilis 4.19.157-perf+ #1 SMP PREEMPT Tue Feb 28 09:20:04 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux
Where is the kernel repo?
https://gitlab.com/ubports/porting/reference-device-ports/android11/fairphone-4/kernel-fairphone-sm7225

I have tried compiling the modules myself, but I run into errors about the wireguard headers redefining kernel functions as static.

I'm also interested in this. Can I ask the steps you made to patch the kernel? I've never  done it but I'm willing to dive in. I'm very much in need to get wireguard working on my Fairphone 4, so far no luck. I tried installing wireguard via apt but space runs out..

I didn't patch the kernel, I'm trying to create an external module which I can load. Anyhow, here are the rough steps I took:

Clone Fairphone kernel sources and wireguard sources. (wireguard sources found @ https://github.com/WireGuard/wireguard-linux-compat)
In the kernel sources, replace scripts/gcc-wrapper.py with the script from these sources, as I can't use Python 2:
https://github.com/ayufan-rock64/linux-kernel/commit/c3714cbbcfbf0f72179e611ee16bf040f5b1695d#diff-8b99c545c4f541534435d1b8da9ba020ae93dfa359f8acd1e3247585d5a5f5e3
Run the following two commands in the kernel source directory:
/usr/bin/make O=../kernel-out ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CROSS_COMPILE_ARM32=arm-linux-gnueabihf-  PYTHON=python3 defconfig KBUILD_DEFCONFIG=ubports_fp4_defconfig -j$(nproc)
/usr/bin/make O=../kernel-out ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CROSS_COMPILE_ARM32=arm-linux-gnueabihf-  PYTHON=python3 modules_prepare -j$(nproc)
cd to the wireguard sources and run the following
make -C src -j$(nproc) KERNELDIR=$(pwd)/../kernel-out ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CROSS_COMPILE_ARM32=arm-linux-gnueabihf- PYTHON=python3 module

What followed for me is a bunch of issues regarding wrong types and static declarations, but you might have more luck with it.

Ahh right sorry, got the terminology mixed. I'll try compiling the module too and see what happens.

Just to make sure: I can do this on another machine and then move the module to FP4? I get
kernel-fairphone-sm7225/scripts/gcc-version.sh: 30: printf: Is: expected numeric value
when running the first command. Tried in my host (Arch) and a VM (Kali). I'll try to debug what's wrong.

Out of curiosity, have you managed to get wireguard to work (at all) in userspace with your FP4? I tried to unset pin but I don't get a handshake when connecting.

This MR might help https://gitlab.com/ubports/porting/community-ports/android10/xiaomi-poco-x3/kernel-xiaomi-surya/-/merge_requests/6


Password policy documentation and image version

I have corrected the number of lower case characters required by the password checker (as per the existing code).
I have also corrected the version of the image to the latest (0.2.0).

LGMTM. Thanks @DanTarl.


When run in Cloud-Shell, az account get-access-token can't retrieve token for Power Platform

Describe the bug
Fetching token for Power Platform (Dataverse) environment is not possible form Azure Cloud-Shell (Bash). This seems to be by design since crm.dynamics.com is not valid resource registered for Cloud Shell MSI. Behavior between execution from client and Cloud shell is different (Cloud shell seems to be calling to some MSI proxy: https://github.com/Azure/msrestazure-for-python/blob/master/msrestazure/azure_active_directory.py#L597).  This proxy does not register crm.dynamics.com  as valid audience.
To Reproduce
Run: az account get-access-token --resource="https://{environment}.crm.dynamics.com"
From: dev machine, this is able to get a token
From: cloud shell, this fails with 400
Expected behavior
I am able to get token for Power Platform environment from Cloud-Shell since it is Microsoft product and behavior is consistent between client and Cloud-Shell execution.
E.I. crm.dynamics.com is registered as valid resource in Cloud-Shell MSI proxy.

@jiasli for awareness

This is a known issue of Cloud Shell. Please see https://github.com/Azure/azure-cli/issues/11386#issuecomment-588176743 for explanation and workarounds.


Markdown mode issue

Hi
I am doing the following to set the mode for different files and it does not work properly for '*.md' files.
var info = CodeMirror.findModeByFileName(filename);
var mode, spec;
if (info) {
  mode = info.mode;
  spec = info.mime;
} else {
  mode = null;
  spec = 'text/plain';
}
CodeMirror.autoLoadMode(this.editor, mode);
this.editor.setOption('mode', spec);

Any idea how I can resolve this?
Thank you.

This works for me. Make sure the mode scripts are in the place where loadmode expects them (see the CodeMirror.modeURL setting). You'll see an error in the console if it can't find them.

It still not working for me. I checked the modeUrl. It is correct. I mean it works for everything else.
Here is a snapshot of variables. Seems like it does not like setting mode option set to "text/x-gfm". If I set that to "gfm" it will work. But then I cannot change my logic because it will break the clike mode.
      CodeMirror.autoLoadMode(this.editor, mode); // mode = "gfm"
      this.editor.setOption('mode', spec); // spec = "text/x-gfm"

Aha, you didn't mention you were using gfm. It seems the gfm failed to actually define the MIME type that meta.js declared for it. Attached patch fixes this.

Yayy! Awesome! Thanks a bunch.


[Auto-generated] Update requirements.txt

Update requirements.txt
Automatically created PR from the ci_update_requirements.yml workflow.

Codecov Report
Patch and project coverage have no change.

Comparison is base (a8e6efe) 69.15% compared to head (79c4b93) 69.15%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                  Coverage Diff                   @@
##           ci/dependabot-updates     #289   +/-   ##
======================================================
  Coverage                  69.15%   69.15%
======================================================
  Files                         18       18
  Lines                        522      522
======================================================
  Hits                         361      361
  Misses                       161      161

Flag
Coverage Δ

pytest
69.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


⚠ ClamAV has degraded performance

In b5d1b52, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 207 ms

Resolved: ClamAV performance has improved in 2382e73.


Select op support

Add select op to TTIR
Decompose select op to TTIR slices and concat optionally
Unit tests (negative and positive)

Fixes #1179

Shouldn't this op be called TTIR.SliceOp? Is it called Select in Forge? Select and Where are used in other dialects for the op that selects values from tensor based on predicate (examples: stablehlo, tosa, onnx). In TTIR we used Where, so using Select for slice op could lead to confusion.

Shouldn't this op be called TTIR.SliceOp? Is it called Select in Forge? Select and Where are used in other dialects for the op that selects values from tensor based on predicate (examples: stablehlo, tosa, onnx). In TTIR we used Where, so using Select for slice op could lead to confusion.

This select is based on forge select which is not the as select in other dialects, nor it is the same as ttir.slice op. Note that it can be decomposed to many slice ops, but it's not 1:1. Based on the wide/narrow TTIR dialect design, I thought this made sense to copy select op from ForgeFE and decompose it as possible. If you have more concerns, we can discuss further offline.

Talked offline, seems like we just need a better name for this op. @nvukobratTT is it okay to change op names in Forge? Did you manually choose this name (Select) or was it chosen based on TVM or something?

Talked offline, seems like we just need a better name for this op. @nvukobratTT is it okay to change op names in Forge? Did you manually choose this name (Select) or was it chosen based on TVM or something?

It's okay to change op names in Forge, if we figure out that other is better suited :))
Most of the ops on Forge are inspired by TVM. However, I wouldn't limit us to use those names, if we find ones that are more suitable and aligned with TTIR and other frontends.
@mrakitaTT @rpavlovicTT I don't have full context, so feel free to send you proposal with a bit more details :))


How to Use Inversify?

I see references to creating our own ServiceFactory for using other IoC containers like Inversify. I've been working with this for several hours now and can not figure out how it is supposed to work with Inversify. I am successfully binding a service that I can use outside of a typescript-rest controller, and I've implemented the following custom class:
import {
  ServiceContext,
  ServiceFactory,
} from 'typescript-rest/src/server/model/server-types';

export class InversifyServiceFactory implements ServiceFactory {
  public create(serviceClass: any, context: ServiceContext) {
    console.log('>>> CREATE SERVICE FACTORY >>>');
    return new serviceClass();
    // return Container.get(serviceClass);
  }

  public getTargetClass(serviceClass: () => {}) {
    console.log('>>> CREATE SERVICE FACTORY >>>');
    if (Array.isArray(serviceClass)) {
      return null;
    }
    let typeConstructor: any = serviceClass;
    if (typeConstructor.name && typeConstructor.name !== 'ioc_wrapper') {
      return typeConstructor as FunctionConstructor;
    }
    typeConstructor = typeConstructor.__parent;
    while (typeConstructor) {
      if (typeConstructor.name && typeConstructor.name !== 'ioc_wrapper') {
        console.log('>>> RETURN 2');
        return typeConstructor as FunctionConstructor;
      }
      typeConstructor = typeConstructor.__parent;
    }
    console.log(
      'Can not identify the base Type for requested target: %o',
      serviceClass
    );
    throw new TypeError('Can not identify the base Type for requested target');
  }
}

And I correctly inject it with:
    Server.registerServiceFactory(new InversifyServiceFactory());

I see that the typescript-rest-ioc does the following:
return Container.get(serviceClass);

However, for Inversify, this is what we're provided:
    get<T>(serviceIdentifier: interfaces.ServiceIdentifier<T>): T;
    getTagged<T>(serviceIdentifier: interfaces.ServiceIdentifier<T>, key: string | number | symbol, value: any): T;
    getNamed<T>(serviceIdentifier: interfaces.ServiceIdentifier<T>, named: string | number | symbol): T;
    getAll<T>(serviceIdentifier: interfaces.ServiceIdentifier<T>): T[];
    getAllTagged<T>(serviceIdentifier: interfaces.ServiceIdentifier<T>, key: string | number | symbol, value: any): T[];
    getAllNamed<T>(serviceIdentifier: interfaces.ServiceIdentifier<T>, named: string | number | symbol): T[];

Which takes an interfaces.ServiceIdentifier.
I'm sure I'm missing something simple, but hoping I can get some quick guidance about how to complete my ServiceFactory since I've seen several places claiming that Inversify is usable, but I keep getting undefined when I inject into the controller.
Thanks!

Ok I figure I can pass the Inversify container to my custom ServiceFactory. What I've noticed is that for the following handler:
  public create(serviceClass: any, context: ServiceContext) {
    console.log('>>> CREATE SERVICE FACTORY >>>');
    return return this.container.get(serviceClass);
  }

serviceClass is a handle to the Controller class, not to the injected service. For example, if I'm inject a service into MyController called MyService, the create() method is getting MyController. So when I try and use the Inversify container to get the serviceClass, it obviously doesn't know anything about the controller and I'm given this error:
Error: No matching bindings found for serviceIdentifier: MyController

How do I get the handle for the MyService property so I can get the property rather than the controller? I really wish that there was some sort of example in the documentation or test code or something. Thank you!

Ok I figure I can pass the Inversify container to my custom ServiceFactory. What I've noticed is that for the following handler:
  public create(serviceClass: any, context: ServiceContext) {
    console.log('>>> CREATE SERVICE FACTORY >>>');
    return return this.container.get(serviceClass);
  }

serviceClass is a handle to the Controller class, not to the injected service. For example, if I'm inject a service into MyController called MyService, the create() method is getting MyController. So when I try and use the Inversify container to get the serviceClass, it obviously doesn't know anything about the controller and I'm given this error:
Error: No matching bindings found for serviceIdentifier: MyController

How do I get the handle for the MyService property so I can get the property rather than the controller? I really wish that there was some sort of example in the documentation or test code or something. Thank you!

Hi - Were you able to get it working?


Regtest network upgrade activation heights

follows from #548 to expand activation heights to all network upgrades instead of only orchard

the changes in this PR require the test author to create a RegtestNetwork as a requirement for all scenarios. This regtest network has helper functions for creating a regtest network with all network upgrades active or to specify an orchard activation height whih are the two most common use cases. however, the regtest network can be configured to activate any network upgrade at any height. the regtest network is then fed into the zcash conf file construction and also to zingoconfig where it can be called with activation height (and similar helper functions). The motivation for creating a regtest network as an outer structure to hold ActivationHeights is to lay the foundation to further simplify zingoconfig in a future PR. i also feel it is more intuitive and is good to have all regtest network parameters in one place.


[Question] Test redux reducers with Immer

I recently started using Immer in redux reducers  in my react app since I have a lot of nested states in them. (lets avoid the fact the these nesting can be solved with sub reducers).
The usage of Immer is clear for me, but once I started to write unit tests with jest I started wondering, that should I avoid using Immer in the tests?
Lets have a basic reducer example:
export default function (state = initialState, action) {
    return produce(state, (draftState) => {
        switch (action.type) {
            case MY_TYPE:
                draftState.some.nested.flag = true;
                break;
        }
    });
}

then my test which also using Immer
it('should handle MY_TYPE', () => {
    const storeState = reducer(initialState, {
        type: MY_TYPE
    });
    const newState = produce(initialState, (draftState) => {
        draftState.some.nested.flag = true;
    });
    expect(storeState).toEqual(newState);
});

So my question is that should I avoid using Immer produce in the tests and make the copy of the nested object manually with the spread syntax ? Something like:
.toEqual({
    ...initialState,
    some: {
        ...initialState.some,
        nested: {
            ...initialState.some.nested,
            flag: true
        }
    }
})

So is there any pitfalls using Immer in tests ?

No, there is no reason to not use immer in tests.
That being said, I didn't really understand the question except for the
last line 😅
Op wo 3 apr. 2019 13:44 schreef zoltan-jere-epam<EMAIL_ADDRESS>
I recently started using Immer in redux reducers in my react app since I
have a lot of nested states in them. (lets avoid the fact the these nesting
can be solved with sub reducers).
The usage of Immer is clear for me, but once I started to write unit tests
with jest I started wondering, that should I avoid using Immer in the tests?
Lets have a basic reducer example:
export default function (state = initialState, action) {
return produce(state, (draftState) => {
switch (action.type) {
case MY_TYPE:
draftState.some.nested.flag = true;
break;
}
});
}
then my test which also using Immer
it('should handle MY_TYPE', () => {
const storeState = reducer(initialState, {
type: MY_TYPE
});
const newState = produce(initialState, (draftState) => {
draftState.some.nested.flag = true;
});
expect(storeState).toEqual(newState);
});
So my question is that should I avoid using Immer produce in the tests and
make the copy of the nested object manually with the spread syntax ?
Something like:
.toEqual({
...initialState,
some: {
...initialState.some,
nested: {
...initialState.some.nested,
flag: true
}
}
})
So is there any pitfalls using Immer in tests ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mweststrate/immer/issues/342, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhErkWpH7Q5bEWPKGAHMfYSGxp-eqks5vdIYAgaJpZM4caMSx
.

Okay. Thanks for the answer !


Overlay icon not rendered when --centericon is true

Describe the bug
Overlay icons do not render when using the --centericon option.
To Reproduce

Install swiftDialog 2.5.3
Run this:

    /usr/local/bin/dialog command display alert \
    --title "Network Connection" \
    --message "### Test awdawd awd awd" \
    --messagealignment "center" \
    --icon "SF=network.slash" \
    --overlayicon "SF=xmark.circle.fill,colour=auto"\
    --bgcolour none \
    --button1disabled \
    --centericon \
    --width 500 \
    --height 300 \

Observe no overlay icon
Install swiftDialog 2.5.2
Run the above again
Observe overlay icon alive and well

Expected behavior
The overlay icon should be rendered regardless of icon alignment configuration.
Screenshots
Centered, icon missing - 2.5.3 ❌

Left, icon rendered - 2.5.3 ✅

Centered, icon rendered - 2.5.2 check ✅

Desktop (please complete the following information):

macOS version: Sequoia 15.1
swiftDialog version: swiftDialog 2.5.3

Additional context
Apologies for the childish placeholder text.
I was tearing my hair out, taking screenshots for my own sanity until I realised it was a bug.

Btw, I figured this out because I've been crafting up some initial script dialogs for Baseline. Things were fine for some time until they stopped rendering mid way through my testing. I realised Baseline can install the latest SwiftDialog as a post-run option and you'd just released 2.5.3 haha.

Also, just realised that bgcolour option was passed incorrectly 🤦♂

good catch

I've fixed this for cases where the number of icons is 1. If it's more than that then overlay icons won't show. I'll make sure to document this behaviour


Simplify new line indicator and message badge

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/224876
Tests

Start a chat between User A and User B.
Ensure User A is not looking at the chat.
Send a message as User B
Verify the LHN row shows in bold for User A to indicate unread messages
Visit the chat as User A and verify the LHN row no longer shows in bold
Verify there is a “----- New” line above the message sent by User B
Scroll up and verify that the “New Messages” button appears floating above the content.
Verify that tapping this button will scroll you to the bottom of the chat but not clear the “---- New” line marker.
Mark a comment as “unread”
Verify the “---- New” line marker appears
Mark as unread comments above and below the existing new marker
Verify the marker appears in the correct position each time
While the new marker is active leave a comment as User A
Verify the new marker and new messages badge both disappear
Mark another comment as unread.
Navigate away from the chat
Navigate back to the chat
Verify the chat in the LHN shows as read
Verify the New Line marker and new messages badge is still present
Navigate away one more time and back
Verify the new marker and new messages badge both disappear
Mark another comment as unread.
Navigate away from the chat
Navigate back to the chat
Minimize the app and reopen it
Verify the new marker and new message badge both disappear
Switch to a mobile view (small screen) and mark a message as unread
Tap the header to reveal the LHN
Verify the chat in the LHN shows as “unread”
Tap the chat
Verify the new marker and badge are present
Tap the header to reveal the LHN
Verify the chat in the LHN shows as “read”
Tap the chat
Verify the new marker and badge are no longer present.
Scroll up in the chat so that last comment is out of view
Leave a comment as User B
Verify the “new messages badge” shows for User A
Scroll down and verify the “new line marker” shows for User A in the correct position.
Scroll back up and leave another comment as User B
Scroll down as User A
Verify the new marker is in the same position as it was before

[ ] Verify that no errors appear in the JS console

PR Review Checklist
Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
Same as Test Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

This PR is required to test atm as I discovered a regression caused by the OpenReport changes.

This is still on HOLD but testing well so marking it as ready.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @marcaaron in version: 1.1.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Going to try reverting this to see if it's the cause for https://github.com/Expensify/App/issues/10751


Adds sum-of-multiples generator and exercise

Hi, this PR is to add a new exercise for sum-of-multiples, here is a link to the problem-specifications
I'm still learning Crystal, so feel free to point out anything that needs to be change or improved.
Thanks!

Rebased master, fixed conflict with config.json, regenerated readme to get updates.


Ntopng Flows Dump

Is your feature request related to a problem? Please describe.
I would like to enable the ntopng flows dump feature. So I can send the flows to a external server.
Describe the solution you'd like
A way to enable the flows dump command line flag and a text field to enter the flows dump destination.
Additional context
https://www.ntop.org/guides/ntopng/advanced_features/flows_dump.html

Oh wait I should have opened this in the plugins repo sorry.


api: Fix login

This commit, fix the login problem when the user has not registered a namespace.

The build has failed. It seems go.mod has not been updated. Log below:
# github.com/shellhub-io/shellhub/api/authsvc
authsvc/service.go:128:26: undefined: mongo
authsvc/service.go:176:26: undefined: mongo
# github.com/shellhub-io/shellhub/api/authsvc [github.com/shellhub-io/shellhub/api/authsvc.test]
authsvc/service.go:128:26: undefined: mongo
authsvc/service.go:176:26: undefined: mongo
FAIL	github.com/shellhub-io/shellhub/api/authsvc [build failed]


Move out of buggy version of awkward

1.0.1 has an n+1 bug in some circumstances when trying to flatten arrow buffers into parquet files. 1.1.1 has a bug fix.
This is ready for review and merge. It turns out it isn't hard to build a query that will tickle this bug!

This has now been tested for a few weeks. Good to go!


md-option viewValue

proposal:
I would like to set the viewValue for an option in and md-slect manually. I have the following setup:
<md-select>
  <md-option *ngFor="let data of datas" [value]="data.selector">
    {{data.val}} <md-icon>filter_{{data.num}}</md-icon>
  </md-option>
</md-select>

What is the expected behavior?
When I select an option the text in the select should only read the text of data.val and not display the icon name aswell.
What is the current behavior?
After I selected the option the select shows the data.val and filter_3 (if the value is 3) as text.
What are the steps to reproduce?
See above
Providing a Plunker (or similar) is the best way to get the team to see your issue.
I would love to, but the plunker mentioned in this template doesn't support md-icon for some reason, wich makes it a bit difficult
What is the use-case or motivation for changing an existing behavior?
It's pretty ugly to see an icon's name in text.
Which versions of Angular, Material, OS, browsers are affected?
"@angular/material": "^2.0.0-beta.3",
"@angular/core": "^4.0.0"
Is there anything else we should know?

https://github.com/angular/material2/pull/3341

That would be good aswell, thanks

Closing as something that should be possible in master.


[Feature Request] LASTERROROBJECT As String

If there is an error with a web service call, the information from the last error text or callstack is not sufficient. If the web service call is executed in a background session, it is nearly impossible to find the error.
LASTERROROBJECT provides all information needed, but is not available in the SaaS Scope because of return type DOTNET.
It would be great if we could read the Last Error Object as text in both scopes to be able to log this.

@ChrisBlankDe doesn't GetLastErrorText covers the same scenario?

Especially when it comes to http communication the content of getLastErrorText is quite worthless.
Here only the .Net error really tells you what is not working.
In the meantime Microsoft has changed a lot of things and we can also access the .net error. So a separate function is no longer needed.
See the following code how we can solved this today:
    trigger OnRun()
    begin
        if not TryRunTest() then begin
            ShowErrorInfo();
        end;
    end;

    [TryFunction]
    local procedure TryRunTest()
    var
        client: HttpClient;
        repsonse: HttpResponseMessage;
    begin
        client.Get('http://not.existing/domain', repsonse);
    end;

    local procedure ShowErrorInfo()
    var
        DotNetExceptionHandler: Codeunit "DotNet Exception Handler";
    begin
        Message('LastErrorCode: %1', GetLastErrorCode); //LastErrorCode: HttpRequest:HttpRequest
        Message('LastErrorText: %1', GetLastErrorText); //LastErrorText: An error occurred while sending the request. <-- too generic
        DotNetExceptionHandler.Collect();
        message('DotnetMessage: %1', DotNetExceptionHandler.GetMessage()); //DotnetMessage: The remote name could not be resolved: 'not.existing' <-- specific enough
    end;


www.scala-js-fiddle.com is unregistered

Sorry if this is not the correct place to report this.
www.scala-js-fiddle.com is unregistered there is a link to it on http://www.scala-js.org/

Thanks for the report. The link should have been changed to https://scalafiddle.io/ months ago, but there was a redirection so we didn't notice.
PR most welcome. I won't have a computer until Monday with which to do it myself.

@lordmat0 feel free to review scala-js/scala-js-website#405 as well.

Fixed in scala-js/scala-js-website#405.


Migrate<EMAIL_ADDRESS>library code into this repo

Copy the konnect, cprint, crud, diff, dump, file, scripts, state, types, and utils packages from https://github.com/Kong/deck/releases/tag/v1.29.2 (also the current tip of main) into this repository's pkg dir.
Update references to those packages from their deck location to this repository.
Run:
go mod init "github.com/kong/go-database-reconciler"
go mod tidy

Add replace directive from deck go.mod.
Run:
go get<EMAIL_ADDRESS>go mod tidy

This library is apparently rather out of date in deck and has had breaking changes since it was added. After this downgrade, go vet  ./... no longer shows errors.

Between the template hook issue and lack of some lint configuration, this needs https://github.com/Kong/go-database-reconciler/pull/8 first.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It's copying the libraries as-is, yes. Only change is the package paths in internal references.


Access Revoke Code Refactoring

Access Revoke completed but it is too early to open PR I need write test code.


Fix an incorrect auto-correct for Layout/LineLength

This PR fixes the following incorrect auto-correct for Layout/LineLength when a heredoc is used as the first element of an array.
% cat example.rb
[<<~STRING, { key1: value1, key2: value2 }]
STRING

% ruby -c example.rb
Syntax OK

% cat .rubocop.yml
Layout/LineLength:
  Max: 40

% bundle exec rubocop --only Layout/LineLength example.rb -a
(snip)

Inspecting 1 file
C

Offenses:

example.rb:1:41: C: [Corrected] Layout/LineLength: Line is too long. [43/40]
[<<~STRING, { key1: value1, key2: value2 }]
                                        ^^^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
[<<~STRING,
{ key1: value1, key2: value2 }]
STRING

% ruby -c example.rb
example.rb:1: syntax error, unexpected end-of-input, expecting ']'

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

I never thought I'd see a heredoc used in an array. :-) Thanks for tackling this!


Move non-command transaction functions to another module

Changelog
- description: |
    Move non-command transaction functions to another module
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context
Move moves non-command transactions functions to a separate module to make it easier to integrate the transaction commands into era-based later.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] The change log section in the PR description has been filled in
[ ] New tests are added if needed and existing tests are updated.  These may include:

golden tests
property tests
round trip tests
integration tests
See Running tests for more details

[ ] The version bounds in .cabal files are updated
[ ] CI passes. See note on CI.  The following CI checks are required:

[ ] Code is linted with hlint.  See .github/workflows/check-hlint.yml to get the hlint version
[ ] Code is formatted with stylish-haskell.  See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
[ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7

[ ] The changelog section in the PR is updated to describe the change
[ ] Self-reviewed the diff

I found a better way to do this: https://github.com/input-output-hk/cardano-cli/pull/229


fix(input): pass messageStyle to inputMessage

Codecov Report

Merging #361 (32d627d) into dev (70cc3a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #361   +/-   ##
=======================================
  Coverage   90.44%   90.44%
=======================================
  Files         154      154
  Lines        3630     3630
  Branches     1201     1201
=======================================
  Hits         3283     3283
  Misses        189      189
  Partials      158      158

Impacted Files
Coverage Δ

...ges/react-magma-dom/src/components/Input/index.tsx
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc8d8b...32d627d. Read the comment docs.


[import/order] Resolver cannot distinguish external and internal imports

Hi there,
When using import/order in conjunction with the import/no-unresolved rule, it doesn't appear possible to configure a resolver to distinguish between external (i.e. node_modules) and internal/absolute imports (i.e. src). In every case, either the resolver groups the external and absolute imports together, or, the resolver is unable to resolve one of the groups.
The following configuration is able to automatically add a newline between the external and absolute imports, but is unable to resolve the external imports:
"eslintConfig": {
    "extends": [
      "eslint:recommended",
      "react-app",
      "plugin:import/recommended",
      "plugin:import/react"
    ],
    "rules": {
      "import/order": [
        "error",
        {
          "groups": [
            "builtin",
            "external",
            "internal",
            "parent",
            "sibling",
            "index"
          ],
          "newlines-between": "always"
        }
      ]
    },
    "settings": {
      "import/external-module-folders": [
        "node_modules"
      ],
      "import/resolver": {
        "node": {
          "moduleDirectory": [
            "src"
          ],
          "extensions": [
            ".jsx",
            ".js"
          ]
        }
      }
    }
  }

In order to get the external imports to resolve, adding node_modules to the module_directory works, but then external and absolute internal imports are grouped together.
I've tried additional configurations using the webpack resolver as well, but am running into the same problem. Any help would be greatly appreciated!

Happens to me when I upgraded to the latest version. Was not the case before. Moved from 2.18.0 to 2.20.1

@constgen Thanks for your reply!
After a bit of bisecting it appears that in this particular case, the bug only affects Windows on v2.20.1. I tested both MacOS and Ubuntu and both were working properly on v2.20.1. So for now, I have rolled back to v2.20.0 for Windows compatibility.
Here is the latest eslint configuration I'm using that works with Windows on v2.20.0, but not v2.20.1:
"eslintConfig": {
    "extends": [
      "eslint:recommended",
      "react-app",
      "plugin:import/recommended",
      "plugin:import/react"
    ],
    "rules": {
      "no-console": "warn",
      "import/order": [
        "error",
        {
          "groups": [
            "builtin",
            "external",
            "internal",
            "parent",
            "sibling",
            "index"
          ],
          "newlines-between": "always"
        }
      ]
    },
    "settings": {
      "import/resolver": {
        "webpack": {
          "config": {
            "resolve": {
              "extensions": [
                ".js",
                ".jsx"
              ],
              "modules": [
                "src",
                "node_modules"
              ]
            }
          }
        }
      }
    }
  }

@warnellw can you perhaps try on windows on latest master on this plugin?

@ljharb Yes, #1651 seems to have fixed it - thanks!

Running into this same issue on Windows, any timeline on when this fix will be released?

hi
First the PR is fixed but still not published on NPM. Is it possible to publish it to npm ?
Secondly, in case of monorepo, the external resolving is not working at all, as modules are symlinked and are not under node_modules folder.
In this case, it doens't work at all.
I don't understand how your trying to detect if a module is external withot knowing what is the path of the module we work on.
in case we know it, a path.relative(from, to) is enough to know if we are in or out of our module.
But we need the package.json path extra info to be in all your importType management, that we don't have at all.
I can work on it but it will generate lot of changes

Yes, it will be published to npm with the next release. That will happen when I have time to do it, and not before.
For the other thing, can you file a new issue to discuss what you need and why?

Sure
I've create a PR here to fix all these problems #1696
Do I need to create a new defect or we can talk over the PR itself ?
Globally I replace the external detection part thanks to the resolved path, because before the resolving, hte import name has no real value.
Everything works correctly now, window / unix, monorepo, aliases, ...
Tell me if you can look at it

The PR is fine, I'll take a look at it today.


Toggle two layers at once?

Hi, thanks for a very useful tool.
I'm wondering if I could have an action that toggles two layers at once and also run a macro. Use case is as such: I have a nav layer that maps a whole bunch of keys to ctrl and alt actions, for use with programs such as firefox and slack. A few of these actions focus on text entry boxes. I would like to implement 'modes', so that if I type 't', it opens a new tab with C-t, and also removes the nav layer, and also adds in a new layer with one change: the enter key re-enters nav 'mode'. Simply toggling a second layer doesn't remove the nav layer, and so I can't enter text properly. Swap would be useful here if the changes were permanent instead of only while holding the key.
clearm is what I'm currently using but I'd love to have more precise control over which layers are active at any given time.
I've read through the manpages and issues enough to understand that layers aren't intended to have any kind of priority, and that's fine. I'd just like to be able to toggle two or perhaps even more layers at once along with a macro so I can build up modal workflows. Also would be nice if clear accepted multiple layers, again with a macro.
Thanks again, this might eventually allow me to ditch qmk and the like!!

It may be easier to have a conversation if you can show a specific config that others can reproduce by copy-pasting.

Err, sure. Here is an example of a config I'm using now.
main.conf
[main]

capslock = overload(control, esc)
sysrq = layer(meta)
z+x = toggle(nav)

[nav]

app.conf
[signal]

nav.j = A-S-down
meta.j = M-j
nav.; = A-S-up
meta.; = M-;
nav.c = C-c
nav.g = clearm(C-S-t)
nav.v = C-v
nav.x = C-x
nav.z = C-z
control.enter = togglem(nav, enter)
nav.y = C-1
nav.u = C-2
nav.i = C-3
nav.o = C-4
nav.p = C-5

As you can see there are two layers, main and nav I can get into nav either through z+x globally or with control.enter in signal. Nav switches up the keyboard so it mostly serves for navigating to where I might want to enter text, when I'm ready I hit g and it focuses on the text input and then drops the nav layer. All well and good, if I only have two layers to switch between. Let's say I wanted a third layer,  which is just main with an additional binding where enter instead of control.enter switches back to nav. Can't do that from the nav layer, there's no way to swap from one layer to another, though I suppose I could use the command() to switch the enter binding, I can't do that and clear the nav layer. Scripting to support changing the layer using keyd -e would also help.

The wording is not specific enough to allow others to copy-paste just that text and reproduce the setting, and there appears to be room for misunderstanding and interpretation. It might be easier to get the story across if it were in a simpler form.
I think it is likely that I am misunderstanding you, partly because of this, but are clear() and clearm(<macro>) of no use to you?
If that functionality does not exist (there is no mention of it in man keyd), then you need to build the latest version somehow.

Not sure how I can be any clearer. I need to switch from one active layer to another layer in one key action. Doesn't appear to be possible atm.

@vg250156 Sorry for the belated response, but have you tried using swap?
If I understand you correctly, something like this should work
[nav]

g = swapm(C-S-t)

[foo]

enter = swap(nav)

Sorry, the above was wrong, since swap only applies to layer(). The latest commit adds support for swapping out toggled layers, which should allow you to achieve what you want using my suggestion above.

Thanks! I found a bug, but made a new issue for it.


Logging in with cookies does not work.

Description of the problem
Trying to pass a set of cookies to the Client fails with two exceptions, one describing the fail to load them and another one from aiohttp related to it. It seems to be a problem with loading a cookie jar from the dict.
The client logs in correctly, but it needs to log in every time instead of reusing sessions which increases the chance of getting blocked by facebook.
Code to reproduce
#!/usr/bin/env python3
import fbchat
import json
import asyncio

with open('bote/config.json') as fd:
    config = json.load(fd)
    email = config['login']
    password = config['password']
cookie_file = 'cookies.json'

loop = asyncio.get_event_loop()
loop.set_debug(True)

async def start():
    with open(cookie_file, 'r') as fd:
        cookies = json.load(fd)
    client = fbchat.Client(loop=loop)
    await client.start(email, password, session_cookies=cookies)
    with open(cookie_file, 'w') as fd:
        cookies = client.get_session()
        json.dump(cookies, fd)
    client.listen()
loop.run_until_complete(start())
loop.run_forever()

Traceback
Failed loading session
Traceback (most recent call last):
  File "/home/szymek/.local/lib/python3.8/site-packages/fbchat/_client.py", line 184, in set_session
    self._state = await _state.State.from_cookies(session_cookies, loop=self.loop,
  File "/home/szymek/.local/lib/python3.8/site-packages/fbchat/_state.py", line 216, in from_cookies
    return await cls.from_session(session=session)
  File "/home/szymek/.local/lib/python3.8/site-packages/fbchat/_state.py", line 179, in from_session
    user_id = get_user_id(session)
  File "/home/szymek/.local/lib/python3.8/site-packages/fbchat/_state.py", line 21, in get_user_id
    return str(rtn.value)
AttributeError: 'dict' object has no attribute 'value'
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fa4660b3940>
source_traceback: Object created at (most recent call last):
  File "./test2.py", line 41, in <module>
    loop.run_until_complete(start())
  File "/usr/lib/python3.8/asyncio/base_events.py", line 595, in run_until_complete
    self.run_forever()
  File "/usr/lib/python3.8/asyncio/base_events.py", line 563, in run_forever
    self._run_once()
  File "/usr/lib/python3.8/asyncio/base_events.py", line 1836, in _run_once
    handle._run()
  File "/usr/lib/python3.8/asyncio/events.py", line 81, in _run
    self._context.run(self._callback, *self._args)
  File "./test2.py", line 33, in start
    await client.start(email, password, session_cookies=cookies)
  File "/home/szymek/.local/lib/python3.8/site-packages/fbchat/_client.py", line 100, in start
    or not await self.set_session(session_cookies)
  File "/home/szymek/.local/lib/python3.8/site-packages/fbchat/_client.py", line 184, in set_session
    self._state = await _state.State.from_cookies(session_cookies, loop=self.loop,
  File "/home/szymek/.local/lib/python3.8/site-packages/fbchat/_state.py", line 214, in from_cookies
    session = session_factory(loop, user_agent)
  File "/home/szymek/.local/lib/python3.8/site-packages/fbchat/_state.py", line 29, in session_factory
    return aiohttp.ClientSession(loop=loop or asyncio.get_event_loop(), headers={

Environment information
Python 3.8.0 (default, Oct 23 2019, 18:51:26)
[GCC 9.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import fbchat
>>> fbchat.__version__ # downloaded with pip
'0.3.0'

The cookie stuff is a bit hacky (relying on private aiohttp fields), so maybe try pickle instead of json for storing the cookies.

I can confirm logging in with cookies seems to work fine if you pickle the session_cookies.

I keep getting null/None as the cookies when I client.get_session()
Also how do you use the pickel thing?


Add host and device targets

This adds cmake targets for host and device to make it easier to link against the host or device version of the library.

However I would like to point out that strictly speaking hip_hcc is not a host-only library.

Yes, but it still needs to be linked when using hip from only a host compiler. hip_hcc also includes headers from hc runtime as well which hcc is required.
The hip::host is for when the user is only using the host part of the library and most likely is compiling with a host-only compiler like g++, thus it does not include hcc runtime in its usage requirements.

Linking against hip::host would still require including the hcc runtime since as I mentioned libhip_hcc.so contains a GPU kernel (See https://github.com/ROCm-Developer-Tools/HIP/blob/master/src/hip_memory.cpp#L1522-L1551). Hence both hip::host and hip::device have a dependency on hcc runtime. There was some issue with moving this to the device library. Once that is resolved, what you said will be true. So I approve the merge as long as we documentation or comment somewhere that hip::host currently still has a dependency on hcc runtime.

Ah, so there is no way to use hip with gcc? We can document it for now until it gets fixed.

Can this be merged?


UI Enhancements in Tracks, Speakers and Session details

Enhanced UI, screenshots attached

LGTM. Let's merge it.

@creativepsyco Thanks :)


ITS-90 Guide contains multiple parts, need to support parts/sub-parts and their titles

The ITS-90 Guide contains multiple parts, metanorma-bipm needs to support parts and sub-parts, and part/sub-part titles.
Originally posted by @ronaldtse in https://github.com/metanorma/mn-samples-bipm/issues/2#issuecomment-716957021

ITS-90 guides have been merged in metanorma/mn-samples-bipm#6. This issue is ready for action.

https://github.com/metanorma/metanorma-model-bipm/issues/2:
title type="part", title type="subpart"
ext/structuredidentifier/part, ext/structuredidentifier/subpart


Best way to communicate between two docker containers?

Can someone please suggest the proper way to communicate between two docker containers.
I have one mongodb container which exposes ports at 27017 and can be accessed by host at localhost:27017
I have the second container which has express application, and connects to mongodb via mongodb://localhost:27017/test
But the express container app doesn't works... Please help.. Thank You in advance

Here's the docs around networking: https://docs.docker.com/engine/userguide/networking/dockernetworks/
Closing as this is the issue tracker and generally not good for general support.
Please see forums.docker.com or #docker on IRC (freenode) for user support.
Thanks!


Integrate Phase 1 state machines with F Prime

https://github.com/garthwatney/fprime/tree/sm-test
See FppTest/state-machine

Review and finalize this branch
Make a PR to fprime devel

The latest STARS can be found here:  https://github.com/JPLOpenSource/STARS/tree/main

Integration is happening via this PR: https://github.com/nasa/fprime/pull/2829.

The PR is merged! Thanks to @garthwatney and @LeStarch.


Implementation of signal_state for newly added BlockEncoding instances.

See #1094.
This method should be implemented for all BlockEncoding instances once the new interface around PrepareOracle has stabilized.

Can you add more detail about what's required here

We need to do the following:

Create a quantum interface for state preparation. It should expose essentially the same signature as BlackBoxPrepare, which should be made an instance.
Implement signal_state for all BlockEncoding instances to return an instance of that quantum interface. In most cases (including linear combination, product, Chebyshev polynomial) this will be PrepareIdentity.
In composite block encodings, add checks that the signal state of the constituents is permitted. In most cases this check will require that the signal state be PrepareIdentity.

One challenge here is that we have been increasingly committing to the PrepareOracle abstract class as the interface of state preparation. This class is not a quantum interface; it generates its signature dynamically just like the old BlockEncoding interface did.
I haven't yet come to a conclusion on how to add/change the Prepare interface in a way that isn't highly confusing/redundant with the existing PrepareOracle and BlackBoxPrepare.


[Update Request]: Multiple NirSoft Packages

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
NirSoft.*
Package Version
Multiple
Please describe the changes you would like to see
Some of the nirsoft packages are seem to be outdated, here is the report of each packages I have checked:

Package name
Version from this repository
Version from nirsoft website

AppReadWriteCounter
1.41
1.42

ChromeCacheView
2.45
2.51

DNSLookupView
1.12
1.15

HashMyFiles
2.44
2.50

InsideClipboard
1.25
1.27

InstalledDriversList
1.05
1.06

InsttaledPackagesView
1.05
1.10

NK2Edit
3.45
3.46

NetworkOpenedFiles
1.62
1.63

NetworkUsageView
1.31
1.32

SearchMyFiles
3.30
3.31

VideoCacheView
3.09
3.10

Volumouse
2.10
2.15

WifiInfoView
2.93; 2.94
2.95

WirelessNetworkWatcher
2.31
2.41

[!NOTE]
Every pull request can only modify one version of manifest. It would be better splitting them into multiple issues.

Every pull request can only modify one version of manifest. It would be better splitting them into multiple issues.

You can make multiple pull requests and link it to this one issue if you want 👍


feat: TS type export (#682)

See detail https://github.com/ecomfe/zrender/issues/682

@lzxb Thanks!


Version of packages displayed as 'undefined' in full view

This happens with every package I haven't installed.
Atom 1.0.7
Windows 7

Would you mind reopening this on https://github.com/atom/settings-view? Thanks!
Also take a look at https://discuss.atom.io/t/id-like-to-report-an-issue-request-an-enhancement-for-atom-where-on-github-do-i-do-that/19290 for a guide on where to post issues.

Done: https://github.com/atom/settings-view/issues/638
And thanks for the second link. That's indeed a goof to read.


Lane alignment component - realignment

It seems that the difference between lane alignment and frame alignment is that lane alignment should react to /A/ whereas frame alignment should react to /F/. There may be some inconsistencies if both lane and frame alignment is enabled. Maybe having one or the other could make sense.


Make a URL analyser - full version

This is discussed in the Wiki, in https://github.com/digirati-co-uk/iiif-manifest-editor/wiki/Import-of-IIIF-Resources and https://github.com/digirati-co-uk/iiif-manifest-editor/wiki/Import-of-Content-Resources
This is used anywhere the user drops a URL into the user interface when attempting to open or import something.
It's not itself a UI, but it's called by several UI components. It's a code component. But UI components use it to sometimes present additional choices - e.g., if you're trying to import a canvas and you drop a Manifest URL in, and there's more than one canvas, the ME needs to know which one.
This analyser returns a JSON object - a resource - which might be an image, with width and height properties, or an image service, or a IIIF Presentation resource.
MVP

Is the URL an Image?
Is the URL an Image Service?
Is the URL an image but is actually a parameterisation of an image service?
Is the URL a Canvas?
Is the URL a Manifest?
Is the URL a link to an encoded state?
Is the string an encoded content state?

Future

Any web page may be pasted and the code will try to find a manifest, or an image service, or the largest image, on that page, depending on what's needed by the caller. This eventually (in future) allows for a very forgiving content-assembly process. It can even have special handlers for Wikimedia pages and others. It can even resolve to an adaptor/proxy service which returns "legacy image pyramid" providers like Wikimedia and Flickr as level 0, sizes-only services.

Image Examples
analyse("https://upload.wikimedia.org/wikipedia/commons/4/4d/NASA_Apollo_17_Lunar_Roving_Vehicle.jpg");

{
   "id": "https://upload.wikimedia.org/wikipedia/commons/4/4d/NASA_Apollo_17_Lunar_Roving_Vehicle.jpg",
   "type": "Image",
   "format": "image/jpeg",
   "width": 3000,
   "height": 3000
}

(whatever the best way to measure the image is... load into an invisible img tag and then ask for .width and .height ?)
analyse("https://iiif.wellcomecollection.org/image/b21151763_0005.jp2");
analyse("https://iiif.wellcomecollection.org/image/b21151763_0005.jp2/info.json");
analyse("https://iiif.wellcomecollection.org/image/b21151763_0005.jp2/full/1000,/0/default.jpg");

{
  "@context" : "http://iiif.io/api/image/2/context.json",
  "@id" : "https://iiif.wellcomecollection.org/image/b21151763_0005.jp2",
  "protocol" : "http://iiif.io/api/image",
  "width" : 1533,
  "height" : 2520,
  "tiles" : [
     { "width" : 256, "height" : 256, "scaleFactors" : [ 1,2,4,8,16 ] }
  ],
  "sizes" : [
{"width": 623, "height": 1024}, {"width": 243, "height": 400}, {"width": 122, "height": 200}, {"width": 61, "height": 100}
  ],
  "profile" : [
     "http://iiif.io/api/image/2/level1.json",
     {
       "formats" : [ "jpg" ],
       "qualities" : [ "native","color","gray" ],
       "supports" : ["regionByPct","sizeByForcedWh","sizeByWh","sizeAboveFull","rotationBy90s","mirroring","gray"]
     }
  ]
}

The difference between the third example here and the first Wikimedia image is that the analyser recognised that the last part of the path is an Image API parameterisation, and pulled out the image service.
Other examples
Other IIIF resources are more straightforward.
analyse("https://iiif.wellcomecollection.org/presentation/b21151763");

// Sees that the resource is a Manifest. But does it load it into Vault and return a ref? Or just return a ref that the caller could decide to load into Vault?

{
   "id": "https://iiif.wellcomecollection.org/presentation/b21151763",
   "type": "Manifest"
}

analyse("JTdCJTIyaWQlMjIlM0ElMjJodHRwcyUzQSUyRiUyRnByZXZpZXcuaWlpZi5pbyUyRmNvb2tib29rJTJGMzMzMy1jaG9pY2UlMkZyZWNpcGUlMkYwMDMzLWNob2ljZSUyRmNhbnZhcyUyRnAxJTIzeHl3aCUzRDgzNyUyQzkxMyUyQzc3MSUyQzMzNCUyMiUyQyUyMnR5cGUlMjIlM0ElMjJDYW52YXMlMjIlMkMlMjJwYXJ0T2YlMjIlM0ElNUIlN0IlMjJpZCUyMiUzQSUyMmh0dHBzJTNBJTJGJTJGcHJldmlldy5paWlmLmlvJTJGY29va2Jvb2slMkYzMzMzLWNob2ljZSUyRnJlY2lwZSUyRjAwMzMtY2hvaWNlJTJGbWFuaWZlc3QuanNvbiUyMiUyQyUyMnR5cGUlMjIlM0ElMjJNYW5pZmVzdCUyMiU3RCU1RCU3RA");

{
    "id": "https://preview.iiif.io/cookbook/3333-choice/recipe/0033-choice/canvas/p1#xywh=837,913,771,334",
    "type": "Canvas",
    "partOf": [
        {
            "id": "https://preview.iiif.io/cookbook/3333-choice/recipe/0033-choice/manifest.json",
            "type": "Manifest"
        }
    ]
}

Possible future behaviour (NOT FOR NOW!)
analyse("ImageService", "https://en.wikipedia.org/wiki/A_Burial_At_Ornans");
analyse("ImageService", "https://commons.wikimedia.org/wiki/File:Gustave_Courbet_-_A_Burial_at_Ornans_-_Google_Art_Project_2.jpg");

{
    "@context": "http://iiif.io/api/image/2/context.json",
    "@id": "https://iiifmediawiki.herokuapp.com/image/a/a0/Gustave_Courbet_-_A_Burial_at_Ornans_-_Google_Art_Project_2.jpg",
    "width": 6042,
    "height": 2777,
    "profile": [
        "http://iiif.io/api/image/2/level0.json"
    ],
    "protocol": "http://iiif.io/api/image",
    "sizes": [
        { "height": 147, "width": 320 },
        { "height": 294, "width": 640 },
        { "height": 367, "width": 800 },
        { "height": 470, "width": 1024 },
        { "height": 588, "width": 1280 },
        { "height": 1176, "width": 2560 },
        { "height": 2777, "width": 6042 }
    ]
}

analyse("ImageService", "https://en.wikipedia.org/wiki/A_Burial_At_Ornans");
analyse("ImageService", "https://commons.wikimedia.org/wiki/File:Gustave_Courbet_-_A_Burial_at_Ornans_-_Google_Art_Project_2.jpg");

{
   "id": "https://iiifmediawiki.herokuapp.com/presentation/File:Gustave_Courbet_-_A_Burial_at_Ornans_-_Google_Art_Project_2.jpg",
   "type": "Manifest"
}

analyse("Manifest", "https://collections.britishart.yale.edu/catalog/tms:1095");

// sniff out the link to a Manifest from this web page
{
   "id": "https://manifests.collections.yale.edu/ycba/obj/1095",
   "type": "Manifest"
}

Building blocks:

Image URL to definition
Image request (also ported to JS)

Potential strategies:

Knowledge in the Vault - have I loaded this before?
Synchronous regex or extension
Patterned URLs ({domain}/presentation/v2/{id} mapped to manifest)
HEAD requests to get headers/mime
Byte-by-byte load EXIF and bail early without loading whole image (complex)
Load the whole resource (ideal for JSON etc.)
Stream partial JSON until we can identify (Oboe.js)

Would this be useful as a vault helper?

Possibly. It feels like a standalone thing because it could be used elsewhere, although may need different logic in different contexts.
Whether it's focused enough to fit alongside the other Vault helpers, I'm not sure.

Having thought about this more, there is no one analysis that fits all. Depending on the context it will more likely be one thing vs. another. There is also a big difference between static analysis of the URL and probing.
So the analysis should work in 3 steps:

Static analysis of the URL to find the best order to try for dynamic analysis.
Dynamic analysis to determine the Content-Type
Content analysis to refine further and extract information

Static analysis.

Looking for file extensions
Looking for structure matching image server request
Matching other known resources
Detecting known patterns (e.g. YouTube video)

Dynamic analysis

HEAD request to resource, returning content type
Trying to fetch /info.json to find image server
Bypassing CORS by using browser elements <img />, <audio/> and <video />
Fetching full resource, checking content directly

Content analysis

Determining the width/height of an image or video
Determining the duration of a video
Discovering an info.json from an image served from IIIF Image API endpoint
Determining the type + version of a resource (e.g. IIIF Presentation 2 Manifest)

With a skeleton framework of helpers for each of these steps, we can start to create issues that cover the detection of a specific resource that fits into one of these categories.


Injecting in global namespace

Hello
I have the following object :
pjs = js.globals['pjs']
How can I inject all pjs objects in global namespace in order to not use 'pjs' prefix ?
Regards
PS : This is not an issue, but I don't know how to put 'question' label

You can directly modify the global python namespace by adding items to globals(), so something like this might work:
for nm in dir(js.globals['$']):
    globals()[str(nm)] = js.globals['$'][nm]

(The need to use str(nm) here is unfortunate and should go away at some point; it stems from the fact that the items in dir(js.globals['$']) are javascript strings rather than python strings)

Thank you Ryan


RUMM-1897: Update DD Java Agent to 0.98.1

What does this PR do?
This PR bumps dd-java-agent version used from 0.67.0 to 0.98.1, unlocking the possibility to use JUnit 5.8+, which wasn't possible because of the bug which was fixed only in 0.92.0.
Test and pipeline runs are reported fine after this change.
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[x] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[x] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #905 (bdd19f5) into develop (f566c55) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #905      +/-   ##
===========================================
+ Coverage    82.87%   82.95%   +0.08%
===========================================
  Files          265      265
  Lines         9002     9021      +19
  Branches      1458     1461       +3
===========================================
+ Hits          7460     7483      +23
+ Misses        1141     1140       -1
+ Partials       401      398       -3

Impacted Files
Coverage Δ

...c/main/kotlin/com/datadog/android/rum/GlobalRum.kt
69.44% <100.00%> (+2.78%)
:arrow_up:

.../android/rum/internal/domain/scope/RumViewScope.kt
96.98% <100.00%> (+0.13%)
:arrow_up:

...android/log/internal/logger/TelemetryLogHandler.kt
75.00% <0.00%> (-25.00%)
:arrow_down:

...ndroid/telemetry/internal/TelemetryEventHandler.kt
82.22% <0.00%> (-2.22%)
:arrow_down:

...rc/main/java/com/datadog/opentracing/DDTracer.java
55.65% <0.00%> (-0.42%)
:arrow_down:

...id/src/main/java/com/datadog/trace/api/Config.java
65.29% <0.00%> (+0.34%)
:arrow_up:

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
86.74% <0.00%> (+1.66%)
:arrow_up:

.../internal/persistence/file/EncryptedFileHandler.kt
95.10% <0.00%> (+1.96%)
:arrow_up:


Performance Improvements

PR out here https://github.com/danpaquin/gdax-python/pull/197
I like this framework, but when I've tried to write my own trading strategy on top of this, there are a few performance bottlenecks in the orderbook that can be improved.
Each price level in the RBTree bids and asks book should be an ordered dictionary where key is the id and value is the order. Will give O(1) access to top level and will give O(1) removal/insertions. This gives significant improvements over a few O(n) calls.
https://github.com/danpaquin/gdax-python/blob/fe727f57476bb396b1816d9666429d93bfe2d561/gdax/order_book.py#L103
This O(n) operation doesn't do anything
https://github.com/danpaquin/gdax-python/blob/62b7b808914f3573ca2ac10c0e59159e34e99d08/gdax/order_book.py#L188

I believe this was fixed via #272.  I apologize for not merging your PR, but I liked the idea of getting away from RBTrees for this high level package.


MB-5054 - Port run_ENV_migrations make commands from com to gov

Description
Right now the run_env_migrations makefile endpoints are still tied to the legacy commercial environment. This PR updates things to use GovCloud. In this process it also decouples the logic to call out to the vault go library as that does not support assuming IAM roles between AWS accounts.
Reviewer Notes
I'll be updating the https://github.com/transcom/mymove/wiki/migrate-the-database wiki as part of this PR
Setup
Add any steps or code to run in this section to help others prepare to run your code:
DISABLE_AWS_VAULT_WRAPPER=1 AWS_REGION=us-gov-west-1 aws-vault exec transcom-gov-milmove-exp make run_exp_migrations
DISABLE_AWS_VAULT_WRAPPER=1 AWS_REGION=us-gov-west-1 aws-vault exec transcom-gov-milmove-stg make run_stg_migrations
DISABLE_AWS_VAULT_WRAPPER=1 AWS_REGION=us-gov-west-1 aws-vault exec transcom-gov-milmove-prd make run_prd_migrations

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.

Messages

:book:
:link: MB-5054

  Generated by :no_entry_sign: dangerJS against 388804234d7e2c6ee8fb599e3ace7aa259e27886

I would like to see an app eng run it. I'm wondering whether we can keep the make command a little simpler by putting the DISABLE part in the command like on line 399-402.

Oh I see @gidjin s response now--yeah I am on a similar page.

@gidjin @kilbergr I simplified things a bit. Can y'all test it out?

The looks like a IAM perms issue on the AWS side of things

Update short commands are working great! Thanks for making that change. Let me know when to test the prd migrations again.

@kilberg I've update the docs.


Relative path check fix

This should fix some test errors on the test/memory_mapped_files branch that arose due to partial UTF-8 support and redundant path checks. There is still a test error due to a race condition on Windows. Most likely arising because curl starts to send RNFR and RNTO commands prematurely (when it thinks that it is done sending the file and not when the server has announced that has received the file completely), but a Wireshark trace would be needed to confirm that.

Thanks, I will check it out! the original implementation fails at the same test on windows. I actually think that fineFTP Server returns too early, when the file isn't fully flushed, yet. I really hope that there is a way to fix that issue, as our software depends on this upload-and-rename-immediately approach (as the FTP protocol cannot distinguish between interrupted and finished file transfers).
I thought that I had that issue fixed in the past, but apparently I only made it better but did not fully fix it.


solving issue of different navbars

Description
Please include a summary of the change and which issue is fixed.
Navbars in home and team section are different
Fixes #330
List any dependencies that are required for this change
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
UI /UX changes
Attach gif or screenshot for changes.

Before :
- After :

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

@harikesh409 Kindly merge my PR

@harikesh409 I have solved all conflicts and issues please merge and add required levels

@harikesh409 Please check

What is the progress @Muskan-creator ?

What is the progress @Muskan-creator ?

I am working on it @harikesh409

@harikesh409 Please review

@harikesh409 Please review

[ ] Resolve merge conflicts
[ ] Few comments are not addressed.
[ ] The style.css file has too many space differences which makes us impossible to review so remove all those changes.
[ ] In team.html page More is not having the underline whereas it is present on the home page.
[ ] The footer in booklist.html page is not in sync with the main repo, resync your fork.
[ ] In DSA.html and practicedsa.html the navbar is overlapped with the content.


Develop Settings Page.

Developed The Settings User Interface Completely. But have to implement the backend part.


fix: allow webpack-dev-server v5

Summary
This was released a few hours ago, and is needed to patch a vulnerability.
Pull Request checklist
Remove this line after checking all the items here. If the item does not apply to the PR, both check it out and wrap it by ~.

[x] Add/update test to cover these changes
[x] Update documentation
[x] Update CHANGELOG file

~This looks to be working fine out of the box for me, though I'll do a look through the actual changelog later to determine if there's any followup work; would be good to get this released in the meantime though.~ looks like they just removed a bunch of previously deprecated stuff; my CSP is broken for some reason but that isn't Shakapackers problem

Thanks @tomdracz and @G-Rath !

Hey folks, any change for cutting a new release here? 👀

Shipped @rwojsznis!


Create a Template Guideline READE.md

The README is for folks who want to contribute a new template to this project.
README should have the following things in it:

[ ] Use of CSS variables
[ ] Use comments in your code to make it easier for people who want to use the templates.
[ ] Your template code should not affect any other element other than your components
[ ] Every template needs to have a README.md file.
[ ] Add this Template guideline README.md link in the project README.md.

Template README should have the following things in it:

Screenshots of the component contributed.
Proper instructions to use the template.
Anything a user needs to know about the template that might affect the user's project.
Contributor's name and social media link.

Note:  Every contributor have to follow these guidelines and then only the PR will get merged.

Assign it to me

Assign it to me

Done.

Noted.

Created the Readme file


Can't use file in embed

Hi, when trying to send a file with an embed I get this error:
await ctx.send(file=file2, embeds=[embed2])
TypeError: send() got an unexpected keyword argument 'file'

My code:
embed2 = discord.Embed(title=f"ID: {id}", color=defaultColour)
file2 = discord.File("cosmeticIcons/cache/icon.png", filename="image.png")
embed2.set_author(name=f"Successfully generated icon image for {name} (512x512)", icon_url=author_icon)
embed2.set_image(url="attachment://image.png")
embed2.set_footer(text=footer)
await ctx.send(file=file2, embeds=[embed2])
``;

Discord currently does not suppprt sending files over Slash Commands. Hence the file kwarg is not found

Ah okay, thank you for the clarification!