[BUG] Reserved IP addresses should be skipped when checking the embedded DHCP server IP in validating admission webhook

Describe the bug

In Harvester's vm-dhcp-controller design, the embedded DHCP server's IP address could reside within the allocatable pool range when creating an IPPool object. The IP address that is occupied by the DHCP server will be marked as RESERVED under the .status.ipv4.allocated field:
...
spec:
  ipv4Config:
    cidr: <IP_ADDRESS>/16
    leaseTime: 300
    pool:
      end: <IP_ADDRESS>
      start: <IP_ADDRESS>
    serverIP: <IP_ADDRESS>
  networkName: default/overlap-net
status:
  ...
  ipv4:
    allocated:
      <IP_ADDRESS>: RESERVED
      <IP_ADDRESS>: 1a:63:91:aa:4a:a6
    available: 65531
    used: 1

However, we didn't respect reserved IP addresses in the admission webhook. As harvester-vm-dhcp-controller's log indicated, the update request was rejected by harvester-vm-dhcp-controller-webhook:
time="2024-02-27T01:26:56Z" level=error msg="error syncing 'default/overlap-net': handler vm-dhcp-ippool-controller: admission webhook \"validator.harvester-system.harvester-vm-dhcp-controller-webhook\" denied the request: Internal error occurred: could not update IPPool default/overlap-net because server ip <IP_ADDRESS> is already allocated, requeuing"

Also, the following line could be found in the webhook's log:
time="2024-02-27T02:07:49Z" level=error msg="could not update IPPool default/overlap-net because server ip <IP_ADDRESS> is already allocated"

With that said, the entire IP allocation/deallocation process is still in a good shape. Newly created VMs could get IP addresses from the embedded DHCP server.
To Reproduce

Enable the harvester-vm-dhcp-controller add-on
Create a VM Network
Create an IPPool object whose serverIP falls into the range of the pool, for example:apiVersion: network.harvesterhci.io/v1alpha1
kind: IPPool
metadata:
  namespace: default
  name: overlap-net
spec:
  ipv4Config:
    serverIP: <IP_ADDRESS>
    cidr: <IP_ADDRESS>/16
    pool:
      start: <IP_ADDRESS>
      end: <IP_ADDRESS>
    leaseTime: 300
  networkName: default/overlap-net

Observe the controller and webhook's log

Expected behavior

Not showing such messages in both controller and webhook's log.
Support bundle

Environment

Harvester ISO version: v1.2.1 (with harvester-vm-dhcp-controller v0.2.1)
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): KVM

Additional context
Add any other context about the problem here.
N/A

For such cases, the agent Pod cannot be cleaned up after the IPPool object is deleted. Users need to manually remove the agent Pod if they want to re-create the same IPPool object.

@starbops tested off of v1.3-head
And version 0.3.0 charts:
apiVersion: harvesterhci.io/v1beta1
kind: Addon
metadata:
  labels:
    addon.harvesterhci.io/experimental: "true"
  namespace: harvester-system
  name: harvester-vm-dhcp-controller
spec:
  chart: harvester-vm-dhcp-controller
  enabled: true
  repo: https://charts.harvesterhci.io
  valuesContent: |
    image:
      repository: starbops/harvester-vm-dhcp-controller
      tag: fix-5225-head
    agent:
      image:
        repository: starbops/harvester-vm-dhcp-agent
        tag: fix-5225-head
    webhook:
      image:
        repository: starbops/harvester-vm-dhcp-webhook
        tag: fix-5225-head
  version: 0.3.0

And this looks good :smile:
I'll go ahead and close this out :+1:


Default routes for serviceWorker option

@angular/cli rc.0 with --ng4 option
Currently, the serviceWorker option only registers the assets to cache in ngsw-manifest.json, but no routing.
So it only works if I go on directly on http://localhost:4200/index.html, but not on http://localhost:4200/ (which could be the url registered in browser favorites for example).
It would be easy to add to the manifest the required options :
"routing": {
  "routes": {
     "/": { "prefix": false },
  },
  "index": "/index.html"
}

Not sure if a sub-directory base href would require a different config.
Less trivial, if the app root url is redirecting to another route (let's say "profile"), the manifest should add it too :
"routing": {
  "routes": {
     "/": { "prefix": false },
     "/profile": { "prefix": false },
  },
  "index": "/index.html"
}

Hello @cyrilletuzi!
You are correct that your proposed configuration would be a sensible default. Currently it's a little tricky, as the CLI doesn't generate an ngsw-manifest.json for you. The integration currently is limited to including hashes of compilation assets seen by Webpack into the manifest.
Longer term, we would like to avoid the user writing this config entirely. The list of routes is statically known to the app via the routing config in NgModules already, we should just leverage this.
Shorter term, if you include either of the ngsw-manifest.json files in the CLI project root directory, ng build --prod will augment them with the static caching information and output the merged version to dist.

Thanks for the merging tip, it works well.
I'm up to do the missing wiki page about this.

@alxhub First of all, thank you for working on Service Worker feature. It is awesome.
I have got the app fully working with
"@angular/core": "4.3.0-rc.0",
...
"@angular/cli": "1.3.0-beta.0",
 "@angular/service-worker": "^1.0.0-beta.16",

I am using all the latest version of Angular and Angular CLI.
The question that I have is what option do I use to turn on the no-cors mode?
My service worker works pretty fine in the NO-Authentication mode. Once I put it behind an authentication layer, it does not work. Nothing is store in the cache.
To be exact, the issue in the Network tab in Chrome debugger
Request URL: `SITE_URL/ngsw-manifest.json?ngsw-cache-bust=0.23123123123`
Request Method: GET
Status Code: 401 Unauthorized

I found this post, i believe it is what I need.
Note: In the index.html, it also run into the same issue when loading manifest.json file with 401 Unauthorized. I used this trick to bypass
<link rel="manifest" crossOrigin="use-credentials" href="manifest.json">
But for ngsw-manifest.json case, i believe it is a simple configuration option fix. If I am wrong, could you point me to the right place?

Fixed in service worker final (5.0).


Images in list getting mixed up

Hi,
I'm seeing that when using FFImageLoading for images in lists, images are sometimes mixed up between the list items, I was wondering if you could provide some guidance?
I've created a small app to reproduce the issue in Xamarin.Android using ImageViewAsync, it has some numbered images which I am loading from a local webserver, the code can be found here:
https://github.com/markmni/FFImageTesting
When scrolling, the image that was previously in the reused cell appears until the new one loads in. I can work around this by setting the drawable to null when the view is retrieved in the adapter before loading the new image, but is this intended behaviour?
Images can still appear next to the wrong entry even after loading is complete, even with setting the image drawable to null before loading. It seems like with the recycled cells maybe whichever request completes last 'wins', rather than the one initiated most recently? Many Thanks

When scrolling, the image that was previously in the reused cell appears until the new one loads in. I can work around this by setting the drawable to null when the view is retrieved in the adapter before loading the new image, but is this intended behaviour?

Yes, it is.

Images can still appear next to the wrong entry even after loading is complete, even with setting the image drawable to null before loading. It seems like with the recycled cells maybe whichever request completes last 'wins', rather than the one initiated most recently?

This should be fixed with: https://github.com/luberda-molinet/FFImageLoading/commit/3997d79c1fbb53ce4544e3a49879a24bb3854b06
Could you test the newest prerelease?

Having a placeholder image seems to fix this too.

Thanks both, I tried the latest prerelease and setting a placeholder image, but unfortunately images are still going astray.
I tried a quick workaround in client code markmni/FFImageTesting@91c9d0790be0269f4cfac0488a4b81cc22238d07 by storing a reference to the scheduled work on the image, then explicitly cancelling it before loading the new image, which (GC implications aside) does seem to stop the problem, in case that's useful in tracking down the issue.

The source of the problem is here:

https://github.com/luberda-molinet/FFImageLoading/blob/master/source/FFImageLoading.Droid/Drawables/FFBitmapDrawable.cs#L122-L154 (returns drawable size)
https://github.com/luberda-molinet/FFImageLoading/blob/master/source/FFImageLoading.Droid/Drawables/FFBitmapDrawable.cs#L94-L97 (animation ends)

Somehow, drawable is not invalidated correctly after animation ends. Any ideas how could we fix this?

It's fixed. Thanks for you help.


Unused code, possible loss of push parameter

/kind bug
In  https://github.com/kubeflow/fairing/blob/master/fairing/builders/cluster/gcs_context.py,
function
def generate_pod_spec(self, image_name, push):
args = ["--dockerfile=Dockerfile",
"--destination=" + image_name,
"--context=" + self.uploaded_context_url]
if not push:
args.append("--no-push")
return client.V1PodSpec(
containers=[client.V1Container(
name='kaniko',
image='gcr.io/kaniko-project/executor:v0.7.0',
args=["--dockerfile=Dockerfile",
"--destination=" + image_name,
"--context=" + self.uploaded_context_url],
)],
restart_policy='Never'
)
Here args is being defined but not used. And the V1PodSpec for Kaniko container is not making any use of push parameter.

@shikha130vv Thanks for you raise the problem. We are going to introduce the pytest in #300 to check the related issues.


Center footer svg.

By setting margin to 1em auto, the footer's logo is centered properly.
Before

After

Sounds good to me, @faykus. :)


npm or yarn?

The repository contains both a package-lock.json and yarn.lock, and that's resulting in confusion, e.g.,

@legalcodes Can we choose one package management solution? I don't care which.

No problem. I'm removing yarn.lock in https://github.com/hardik-vala/TreeSum/pull/19


Explore standing up grafana via the Grafana operator

https://github.com/integr8ly/grafana-operator

@seravat ; since you've used this @customer recently. Can you give a quick summary of it?

So, despite not bringing huge advantages comparing to using the standalone application, I found that being able to provision new dashboards or datasources through the CRDs is indeed good, otherwise you would have to create ConfigMaps and add them as volumes attaching to the /provisioning directory on Grafana - if you want to provision datasources/dashboards on Grafana's startup
It is especially useful if you are doing multiple deployments, for the reasons above.

@garethahealy @seravat yes, that is the specific use case we have here, as currently we are standing up a generic grafana deployment, and then individually "mounting" a dashboard as a CM to grafana, which requires a patch of the deployment to add the volume. This is not ideal, as this approach isn't very declarative, so we would like to replace it with the operator & dashboard CRD.

I think I got this working, here is a PR for you to look at.
https://github.com/redhat-cop/pelorus/pull/37


AOT

Will it create metadata.json also so that AOT compilation does not fail.

Yes, you can perform the following commands:
# Install dependencies
$ npm install @angular/compiler-cli typescript@next @angular/platform-server @angular/compiler

# Compile
$ ./node_modules/.bin/tsc -p path/to/project

This will generate a compiled version in the dist directory with index.metadata.json.
I will also update the generator to include a build script to automate this.
Thank you for your feedback! 👍

I have just released v5.1.0 which includes the necessary dependencies and an npm run build script.
I will close this issue for now. Feel free to re-open if you feel something is missing.
Thanks again for your feedback!

Hi, I'm currently using your generator with ionic 3 but I have a problem with the AOT compilation when I'm doing the command : ionic cordova build ios --prod.
Here my error: Error: Error encountered resolving symbol values statically. Calling function 'MyModule', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in src/app/app.module.ts, resolving symbol AppModule in src/app/app.module.ts
I would like to know if it's possible to add the compilation with AOT support ? As i don't see the index.metadata.json.
Regards,

My bad the metadata.json has been generated with the name n9-angular2-storage.metadata.json, so it's mean that the AOT compilation should working. Why I don't have this error during the compilation of the library but with ionic ?
Regards,

@gaetansenn — Awesome, thank you for keep us posted. Much appreciated! 👍


Where is the best place to add display activity indicator to code?

I need to add activity indicator before response came. Is there any way to access all request from one place?

May NetworkActivityPlugin  can do this. See end of the Providers Doc

Thanks @alfredcc I tried to add plugins but couldn't. Can you give me an example code or some more detailed link about plugins?

You add the plugins as part of the initialization for your provider. It is passed in as an array. As an example, to add the NetworkLoggerPlugin to your provider, use the following sample code:
let plugins: [PluginType] = [NetworkLoggerPlugin(verbose: true)]
let myProvider = MoyaProvider<MyTarget>(plugins: plugins)

Here is the full spec for the init of a MoyaProvider.

thanks @aamctustwo :+1:

Thanks @aamctustwo – much appreciated :bow:

@aamctustwo What about usage NetworkActivityIndicator? Can you please give sample code about that?


Examples would be helpful

I think it would be beneficial if section Configuring Static Routes | Linux contained an example.  So that the reader can correctly substitute their network specific information

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8b2b888-cb50-926c-17c8-27717fdcb0bf
Version Independent ID: 3d814685-eac3-500c-83e2-4d4edfafd815
Content: Host-Gateway Mode
Content Source: virtualization/windowscontainers/kubernetes/configuring-host-gateway-mode.md
GitHub Login: @gkudra-msft

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Doesn't work on Remove SSH (Ubuntu 20.04)

Issue Type: Bug
Extension Name: vsliveshare
Extension Version: 1.0.5065
OS Version: Windows_NT x64 10.0.19043
VS Code version: 1.61.2

I am trying to use Live Share on a Remove SSH connection to an Ubuntu 20.04 Virtual Machine.
When connect to it I am able to get 2 scenarios.

When I am signed into my GitHub account I don't see the LiveShare button, if I try to start a LIveShare session I get the Notification "Starting collaboration session", but nothing happens.
If I sign out of GitHub, I am able to see the LiveShare button, and click it to sign in, but as soon as I sign in the LiveShare button is gone again, and I am back to 1.

Trace Log from the Live Share extension, when I start VsCode with GitHub Signed in:
[Client I] Extension, IDE, OS : VSLS/1.0.5065 VSCode/1.61.2 Linux/5.11.0-38-generic
[Client I] Passed version check for Linux: found 5.11.0-38-generic
[Client.Rpc V] RPCClient.init retryCount:0 currentRetryInterval:0
[Debug.Rpc.Host V] TrackDebugManager created
[Client.Rpc V] disposing the object> object #0: undefined
> object #1: {}
[Client.Rpc V] Agent connection not completed: Error: connect ENOENT /tmp/CoreFxPipe_vscode.607d5d0f22647ef13f1b32fd25ac40f0; Retrying...
[Client.Rpc V] RPCClient.init retryCount:1 currentRetryInterval:100
[Client.Agent V] Agent lock on:</<redacte/<redacte.lock>
[Client.Agent I] starting agent with pipe:vscode.607d5d0f22647ef13f1b32fd25ac40f0
[Client.Agent I] signalR service -> uri:https://signlr-prod.core.vsengsaas.visualstudio.com/api/signalr/signalrhub
[Client.Agent V] Finished agent startup...
[Client.Agent V] Agent unlocked
[Client.Rpc I] Agent connection success - net.pipe://localhost/vscode.607d5d0f22647ef13f1b32fd25ac40f0
[Client.Rpc V] finish initialize agent session with rpcConnectId:null hostSessionId:1
[Client.Rpc.Auth V] < version.exchangeVersions()
[Client.Rpc.Auth V] > version.exchangeVersions() succeeded t:21.0
[Client I] Client version: 1.0.5065 (VSLS/2.2), agent version: 1.0.5065.29383 (VSLS/2.2)
[Client.Rpc.Auth V] < version.exchangeSettings()
[Client.Rpc.Auth V] > version.exchangeSettings() succeeded t:15.0
[Client.Rpc V] < telemetry.initialize()
[Client.Rpc V] > telemetry.initialize() succeeded t:29.0
[Client I] Hub connection is being enabled...
[Client.Rpc.SessionContext V] < sessionContext.getServiceNames()
[Client.Rpc.SessionContext V] > sessionContext.getServiceNames() succeeded t:29.0
[Client I] No workspaceId found in workspace settings.
[Client I] No workspace url found in cascade.json file.
[Command:liveshare.signin I] Decorator: CancellationDecorator Starting
[Command:liveshare.signin I] Decorator: ErrorNotification Starting
[Command:liveshare.signin I] Decorator: Telemetry Starting
[Command:liveshare.signin I] Decorator: TelemetryStatus Starting
[Command:liveshare.signin I] Decorator: Validation Starting
[Command:liveshare.signin I] Decorator: SessionStateTransitions Starting
[Client I] "Planned sessions are disabled, state: SigningIn
[Command:liveshare.signin I] SessionContext: State update from "Initializing" (undefined) to "SigningIn" (AttemptSignIn).
[Command:liveshare.signin I] Decorator: Authentication Starting
[Command:liveshare.signin I] SessionContext: Status update from "undefined" to "SigninCheckStarting".
[Command:liveshare.signin I] SessionContext: Status update from "SigninCheckStarting" to "SilentNativeLoginStarting".
[github V] Attempting to load session - login = false
[API I] Initializing Live Share API 1.0.3015 for<EMAIL_ADDRESS>[Contact.Manager V] ->initialize state:2
[Contact.Manager I] registerContactProvider-> serviceId:git
[Contact.Service V] _Initialize:git
[Contact.Service V] Request 'initialize' serviceId:git
[Contact.Manager I] registerContactProvider-> serviceId:selfInvite
[Contact.Service V] _Initialize:selfInvite
[Contact.Service V] Request 'initialize' serviceId:selfInvite
[Contact.Manager I] registerContactProvider-> serviceId:LivesharePresence
[Contact.Service V] _Initialize:LivesharePresence
[Contact.Service V] Request 'initialize' serviceId:LivesharePresence
[Client.Rpc.Contact V] < contactService-LivesharePresence.request()
[github V] Successfully loaded session
[Client.Rpc.Contact V] > contactService-LivesharePresence.request() succeeded t:67.0
[Contact.Service V] onNotified-> serviceId:git name:suggestedUsers
[Contact.Manager I] onSuggestedUsersUpdate-> serviceId:git count:0
[Contact.Manager V] ->updateRecentContacts -> count:0
[Contact.Manager V] ->updateSuggestedUsers
[Contact.Manager V] suggest contacts from provider:git ids: emails:
[Contact.Manager V] <-updateRecentContacts
[Contact.Manager I] <- updateSuggestedUsers count:0
[Contact.Service V] Request 'signIn' serviceId:LivesharePresence
[Client.Rpc.Contact V] < contactService-LivesharePresence.request()
[Client.Rpc.Contact V] > contactService-LivesharePresence.notified:
[Contact.Service V] onNotified-> serviceId:LivesharePresence name:authenticationRequired
[Client.Rpc.Contact V] > contactService-LivesharePresence.request() succeeded t:14.0
[Client I] Attempt to log in with github auth provider.
[Client.Rpc.Auth V] < auth.login()
[Client.Rpc.Auth V] > auth.authenticationChanged:
[Client.Rpc V] > telemetry.genericOperation:

I figured out the issue.
When opening VsCode a popup for unlocking Gnome Keyring appeared on the VM I use. After unlocking it, everything works


Need es version

https://github.com/ant-design/ant-design/issues/7158
https://github.com/react-component/react-component.github.io/issues/12

@yiminghe

WARNING in ./node_modules/_rc-animate<EMAIL_ADDRESS>76:11-34 "export 'isCssAnimationSupported' was not found in 'css-animation'

https://github.com/yiminghe/css-animation/issues/13


[BUG] ERROR rapids.tools.qualification: Failed to execute the prediction model

Describe the bug
I'm using the qualification tool over an eventlog generated by the execution of a Databricks Workflow Job.
I'm getting the following errors when using the qualification tool:
Processing...⣟2024-10-24 10:48:43,531 ERROR rapids.tools.qualification: Failed to execute the prediction model. Using default speed up of 1.0 for all apps. Reason - KeyError:'startTime' ERROR: Could not find elements [('rd-fleet.8xlarge',)] 2024-10-24 10:48:43,542 ERROR rapids.tools.cluster_inference: Error while inferring cluster: Instance type rd-fleet.8xlarge is not found in catalog. Processing...⡿2024-10-24 10:48:43,609 ERROR rapids.tools.AdditionalHeuristics: Cannot apply heuristics for qualification. Reason - FileNotFoundError:[Errno 2] No such file or directory: '/Users/username/repos/nvidia-rapids/qual_20241024134808_8B440b4b/rapids_4_spark_qualification_output/raw_metrics/app-20241022192347-0000/stage_level_aggregated_task_metrics.csv'
After the error is thrown, the tool generates the report but indicates there are no compatible apps.
Steps/Code to reproduce bug

Execute qualification tool with the following parameters:

spark_rapids qualification  --platform databricks-aws  --eventlogs logs/cluster_id/eventlog/cluster_id_10_69_238_61/some_id/eventlog

Expected behavior
No errors and a recommendation about the cluster shape I should use to improve performance.
Environment details (please complete the following information)

Environment location: It was executed in my local environment, using logs generated by Databricks AWS, which I previously downloaded to my machine.

Additional context
No additional context.

Hi @estebanmodmed,

It seems the path you provided maybe incomplete, which is causing the Tool to read partial event logs. Databricks stores event logs in a rolling manner as:
ls -l logs/<cluster-id>/eventlog/<cluster-id>_<some-id>/<some-id>
eventlog
eventlog-2024-02-20--04-50.gz
eventlog-2024-02-20--05-00.gz
eventlog-2024-02-20--05-10.gz
eventlog-2024-02-20--05-20.gz

To fix this, I would recommend using the parent directory instead of pointing directly to a specific eventlog file.
Full CMD:
spark_rapids qualification  --platform databricks-aws  --eventlogs logs/cluster_id/eventlog/cluster_id_10_69_238_61/some_id

The application seems to have run on Databricks Fleet instances ('rd-fleet.8xlarge'). At the moment, we don't support fleet instances, but we will update our catalog to include them. However, this is mostly a log message and is not related to the tool’s failure.

With the updated CMD and path, you should be able to run the tool. Let us know incase there are any issues.


Pandas 1.x.x support

Are there current plans to support Pandas 1.x.x?
It looks like there is a following restriction on pandas in v0.16.0: pandas>=0.18.1, <= 0.24.2
Thank you.

Pandas 1.x.x should work with mleap already (at Yelp we do this with no problems).  The file you linked is for the test environment which relies on other properties such as the python version.  The actual mleap package dependencies are specified in the setup.py.


simple-oidc-provider chrome issue

Hi!
I'm implementing OIDC provider using node-oidc-provider (https://www.github.com/qlik-trial/simple-oidc-provider).
This is working fine with Firefox and Safari, but not with Chrome. Seems that cookies gotten in header response are not set in the browser, I've tried different things but haven’t succeeded.
@hairyhenderson do you have any idea what could be happening?
Thank you!

I'm no longer a maintainer of this repo (not at Qlik anymore), maybe @masaruhoshi can help?

@hairyhenderson Sorry about that 🙏 Thsnk you for the connection.


Allow "kamel promote" integrate with GitOps styled deployments

Hi,
right now, to utilize kamel promote feature, it has to be executed as a CLI command directly via pipeline. This makes it hard to integrate it with a more modern way of deploying application which relies on GitOps paradigm.
This could be potentially mitigated if kamel promote came up with the "dry-run" option which would output set of valid k8s YAML manifests which would fully represent the promoted integration. This would allow to easily integrate "kamel promote" with GitOps styled repositories, so instead of promoting integration directly by calling "kamel promote" command, we would delegate this to GitOps solution which would simply apply the valid manifests of the promoted integration.

kamel install has -o|--output {yaml|json} option, so kamel promote should provide the same option as well.


issue when multiplication sign * is not surrounded by whitespace

This is flagged as error, but whitespace is optional around mathematical operators:
imageW = int(p_width + (2*p_hPadding))
imageH = int(p_height + (2*p_vPadding))

@dhuebner The problem here is the symbolic label name:
terminal SYMBOLIC_LABEL_NAME: /\*[a-zA-Z]+?/;

I think *p_hPadding is interpreted as a token instead of a multiplication sign and operand.
I am not sure what we can do here. Maybe split the terminal and validate whether it is a symbolic label name or not. WDYT?


✨ App tile: Hide Title + Move Title + Description Tooltip

Category

Feature / Cosmetic

Overview
Improvements on the app tile:

Option to hide the title.
Option to move the title around the icon.
Option to add a description for the app, which will appear to the user as a tooltip on hovering the app.

Issues

Related issues: #549 #834

Screenshot

Hide Title

Move Title

App description

Note that my cursor doesn't show in the screenshots, but the tooltip description follows the cursor.

Very nice, thank you @Tagaishi for the contribution.
After this has been merged, can you also update the documentation?

Hide name which was a toggle has been changed to a triple option to be closer to the initial issue #549

Normal: Will show the title in the tile but not in the tooltip. Only when this option is selected can you change the relative position of the app name on the tile (the selector under).

You can see the title doesn't appear in the tooltip but does on the tile. if the description was empty then no tooltip would be shown at all

Hover: Will show the title in the tooltip but not in the tile.

Here you can see that the description will concatenate with the title using a separator, when both need to be in the tooltip.

if no description then the title will stand alone in it

Hidden: Doesn't show on either the tile or the tooltip.

Again if there were no description then no tooltip would appear at all.

I think you need to add some padding to the name, it feels a little to close to the icon when it's on the right.
Also is there a way to see the description beneath the name?

I think you need to add some padding to the name, it feels a little to close to the icon when it's on the right.
Also is there a way to see the description beneath the name?

Can add some more padding yeah, it's already set at 10 pixels so just need to get that a little bigger.
Since the size is dynamic anyway that would only be the very minimum distance.
I could add an option to make the description appear underneath the name if I add the option the same way as it is for the app title.

Some parts of the changes should be reverted (For example it tries to readd the api endpoints for docker)


Entropy src testplan

DV Plan, Testplan, sanity test updates/changes

There is a "Signed-off-by..." so what do I need to do?

There is a "Signed-off-by..." so what do I need to do?

Add user name and email if you haven't done it
git config --global user.name "FirstName LastName"
git config --global user.email<EMAIL_ADDRESS>update commit message
git commit --amend  -s
force push the update

I've tried everything you suggested to get this PR to pass the checks. If I look at the PR, it looks to me like the "signed off by" line is/always has been there so I don't know why it's complaining.

I've tried everything you suggested to get this PR to pass the checks. If I look at the PR, it looks to me like the "signed off by" line is/always has been there so I don't know why it's complaining.

That's weird. There is a "signed off by" for each commit. @imphil do you know why CI still fails.
@senelson7 can you merge all your commits into one? Follow the steps here to do that.

I merged all my commits into one but it still fails the check.

You can have a look at the checks tab to see the failure at https://github.com/lowRISC/opentitan/pull/2072/checks?check_run_id=633407017
It is:
The commit message must contain a Signed-off-by line that matches the commit author name and email, indicating agreement to the Contributor License Agreement. See CONTRIBUTING.md for more details. "git commit -s" can be used to have git add this line for you.
If you have a closer look at the patch, it's authored by "Eunchan Kim<EMAIL_ADDRESS>but has a signed-off line "Signed-off-by: Steve Nelson<EMAIL_ADDRESS>
Force-push (git push -f) to update this PR.

That worked, but I have a couple of questions:

Where did you look to see that eunchan was listed as the author? I couldn't find that.
How did that happen?

You can have a look at the checks tab to see the failure at https://github.com/lowRISC/opentitan/pull/2072/checks?check_run_id=633407017
It is:
The commit message must contain a Signed-off-by line that matches the commit author name and email, indicating agreement to the Contributor License Agreement. See CONTRIBUTING.md for more details. "git commit -s" can be used to have git add this line for you.
If you have a closer look at the patch, it's authored by "Eunchan Kim<EMAIL_ADDRESS>but has a signed-off line "Signed-off-by: Steve Nelson<EMAIL_ADDRESS>
Force-push (git push -f) to update this PR.

Thanks for the help @imphil

@senelson7 I don't know how that happened, it must have been something how you used git locally.
You can check for things like that by looking at the commits on your machine, use git log or graphical tools like ´gitkortig`.


Springfox 3.0.0 generates 3 classes instead of 1 (Class, ClassReq, ClassRes) and ClassReq is missing required fields

What version of the library are you using? 3.0.0

For a single class 3.0.0 generates 3 classes: the original class, one with the Req and one with the Res postfix. Req seems to be used if @RequestBody is being used. Res I suppose when @ResponseBody is in use (do not use it, class is still generated). The original Class name is used when the class is present on another object.
This makes it impossible to pass a response object to a request API in Java and other other languages that rely on nominal typing because they are completely separate classes.
Even worse: it seems that the ParsedBusinessScheduleReq object does not properly generate the required fields. Below is the used class. Take a look at the required field which is absent for the ParsedBusinessScheduleReq object.
@ApiModel(value = "ParsedBusinessSchedule")
data class OpeningHours(
    val daysInWeek: List<WeeklyOpeningHours> = emptyList(),
    val daysInYear: List<YearlyOpeningHours> = emptyList(),
    val winterSeason: WinterSeason? = null,
    val closedOnHoliday: Boolean = true
)

{
  "ParsedBusinessSchedule": {
    "type": "object",
    "required": [
      "closedOnHoliday",
      "daysInWeek",
      "daysInYear"
    ],
    "properties": {
      "closedOnHoliday": {
        "type": "boolean"
      },
      "daysInWeek": {
        "type": "array",
        "items": {
          "$ref": "#/definitions/WeeklyOpeningHours"
        }
      },
      "daysInYear": {
        "type": "array",
        "items": {
          "$ref": "#/definitions/YearlyOpeningHours"
        }
      },
      "winterSeason": {
        "$ref": "#/definitions/WinterSeason"
      }
    }
  },
  "ParsedBusinessScheduleReq": {
    "type": "object",
    "properties": {
      "closedOnHoliday": {
        "type": "boolean"
      },
      "daysInWeek": {
        "type": "array",
        "items": {
          "$ref": "#/definitions/WeeklyOpeningHoursReq"
        }
      },
      "daysInYear": {
        "type": "array",
        "items": {
          "$ref": "#/definitions/YearlyOpeningHoursReq"
        }
      },
      "winterSeason": {
        "$ref": "#/definitions/WinterSeasonReq"
      }
    }
  },
  "ParsedBusinessScheduleRes": {
    "type": "object",
    "required": [
      "closedOnHoliday",
      "daysInWeek",
      "daysInYear"
    ],
    "properties": {
      "closedOnHoliday": {
        "type": "boolean"
      },
      "daysInWeek": {
        "type": "array",
        "items": {
          "$ref": "#/definitions/WeeklyOpeningHoursRes"
        }
      },
      "daysInYear": {
        "type": "array",
        "items": {
          "$ref": "#/definitions/YearlyOpeningHoursRes"
        }
      },
      "winterSeason": {
        "$ref": "#/definitions/WinterSeasonRes"
      }
    }
  }
}

[ ] Question. Is this a question about how to do a certain thing? Not sure if this is a bug or feature, couldn't find any docs on that.

Thanks for reporting, Not sure what's going on, could you share the operation signature that use these classes as well? I suspect that the Kotlin module is rendering properties that are differentiating the models.
Keep in mind that if the request is different from the response (recursive properties included) then the whole tree is different.

That one generates the ParsedBusinessScheduleReq:
    @PostMapping("/businessareasopeninghours")
    fun updateOpeningHoursForBusinessAreas(
        @RequestBody idsAndHours: OpeningHours
    ): ResponseEntity<Void>

That one the ParsedBusinessSchedule:
    @GetMapping("/cooperatives/{cooperativeId}/locations/{locationId}/businessareas/{businessAreaId}")
    fun getBusinessArea(
        @CooperativeId @PathVariable("cooperativeId") cooperativeId: String,
        @LocationId @PathVariable("locationId") locationId: String,
        @IsLong @PathVariable("businessAreaId") businessAreaId: String
    ): BusinessArea

@JsonInclude(Include.NON_NULL)
data class BusinessArea(
    val openingHours: OpeningHours
)

I have the same issue. Using a 3.0.0 version from release repository.

@dilipkrish
This class seems to be related to this issue.
https://github.com/springfox/springfox/blob/e7f0a8fc7d23708f8ab3e90e3f3ed3f5b89b9f6a/springfox-spring-web/src/main/java/springfox/documentation/spring/web/scanners/DefaultModelNamesRegistryFactory.java#L129
Could you let me know what's the condition that is applied to this pattern?

@pitzcarraldo The condition is when the request model differs from the response model (one has more/less properties than the other) then we distinguish the model as Req/Response
@BernhardPosselt It seems like WinterSeason, YearlyOpeningHours, WeeklyOpeningHours all have properties that differ between request and response, which is why OpeningHours/ParsedBusinessSchedule has a request response pair

@dilipkrish nope, they are exactly the same.

We have the same issue. We recently switched to version 3.0.0 and use spring-boot 2.3.4 together with kotlin 1.4.10.
The following contrived example generated a AnalysisPortfolioReq and AnalysisPortfolioRes schema.
@ApiOperation(value = "testAnalysisPortfolios", notes = "Returns all AnalysisPortfolio entities.")
@PostMapping(path = ["/portfolios"], produces = [MediaType.APPLICATION_JSON_VALUE])
fun testAnalysisPortfolios(@RequestBody model: AnalysisPortfolio): ResponseEntity<AnalysisPortfolio> {
    return ResponseEntity.ok(AnalysisPortfolio());
}

@ApiModel(value = "AnalysisPortfolio", description = "")
class AnalysisPortfolio(
    @ApiModelProperty(required = true)
    var id: Long? = null,

    var test: AnalysisBattery? = null,
)

@ApiModel(value = "AnalysisBattery", description = "")
class AnalysisBattery(
    @ApiModelProperty(required = true)
    var id: Long? = null,
)

Removing the @RequestBody or the test property on the model fixes the issue. So I guess the tree generation might not work correctly using the sources generated by kotlin?

During testing we noticed that adding @ApiModelProperty to every property also fixes the issue.

I am seeing this problem as well after upgrading to 3.0.0. I have not been able to confirm that adding @ApiModelProperty rigorously solves my problem. Instead I have had success replacing all @RequestBody annotations with a corresponding RequestEntity - eg.
This works:
public ResponseEntity<BasketResponse> setOrderContactInfo(
   @ApiParam(value = "Conctact information for the order.", required = true)
   final RequestEntity<OrderContactInfo> contactInfo) {
 }

This does not:
public ResponseEntity<BasketResponse> setOrderContactInfo(
   @ApiParam(value = "Conctact information for the order.", required = true)
   @RequestBody final OrderContactInfo contactInfo) {
 }

Though this can be used as a workaround it is not optimal as it changes the type of the contactInfo parameter and thus requires changes in the method body as well.

Also having this issue. Sometimes we use the same ObjectDTO type on input and output. On 3.0.0 version ObjectDTORes and ObjectDTOReq definitions are generated. While on 2.9.2 there was only one definition (only ObjectDTO)

The workaround I posted earlier (https://github.com/springfox/springfox/issues/3487#issuecomment-706133266) only solved the original 3-class problem. But another problem - also related to request body and response body sharing models - is not solved: It turns out that the api being described in such cases features individual operation parameters for each property in the request body - instead of the previous single request body object parameter - as well as some strange apparently generic parameters named "method2, "type" and "url" ???. This is absolutely horrible - I am going to downgrade to 2.9 :-(

A colleague of mine has pointed out that it is actually my workaround that introduces the individual request body properties as parameters in the api. He also discovered that the 3-class problem stems from the fact that one of my models appearing in both request and response has a read only property in the form of a getter deriving af a value from other properties, making it effectively different in request and response. By simply adding a dummy setter for this property the 3-class problem disappeared.

@dilipkrish The main issue with the Req/Res approach is that it forces all models to have getters and setters. And this is not  a valid assumption as there are other ways of creating beans such the example below using constructors
public class Sorting {     public Integer index;     public Direction direction;     @JsonCreator     public Sorting(@JsonProperty("index") Integer index, @JsonProperty("direction") Direction direction) {         this.index = index;         this.direction = direction;     }     public Integer getIndex() {         return index;     }     public Direction getDirection() {         return direction;     } }
Maybe this decision could be based on some configuration, to let each consumer to decide whether create the req/res automatically depending on their API.

There doesn't seem to be a consensus as to how to fix this or make 3.0.0 compatible with e.g. 2.9.2.
We've reverted to 2.9.2 for the time being

This is still an issue.

It's causing a lot of discomfort for us still. Could someone address this issue?

Label > waiting-for-more-info
What else information do you need on this?

This is still an issue.

This is still an issue.

I found a way to hotfix this in my projects:
/**
 * Fixes springfox bug: https://github.com/springfox/springfox/issues/3487
 * Where it generates ModelReq/ModelRes when we use the same model on @RequestBody and response
 */
@Component
@Order(SwaggerPluginSupport.SWAGGER_PLUGIN_ORDER)
class SwaggerName : ModelNamesRegistryFactoryPlugin {
  val factory = DefaultModelNamesRegistryFactory()

  override fun modelNamesRegistry(registry: ModelSpecificationRegistry): ModelNamesRegistry =
    Registry(factory.modelNamesRegistry(registry))

  override fun supports(dt: DocumentationType) = true

  private class Registry(private val registry: ModelNamesRegistry) : ModelNamesRegistry {
    private val re = Regex("(Req|Res)?$")
    override fun modelsByName(): Map<String, ModelSpecification> =
      registry.modelsByName()
        .mapKeys { re.replace(it.key, "") }
        .mapValues {
          ModelSpecificationBuilder().copyOf(it.value).facets { f -> f.title(it.key) }.build()
        }

    override fun nameByKey(key: ModelKey?): Optional<String> =
      registry.nameByKey(key).map { re.replace(it, "") }
  }
}

It's really sad to see that this library is not being developed anymore.

Same problem here. This bug occurs when I migrate from Java to Kotlin (using same Spring Boot and Springfox, of course)

Here is another hack without using Regex and a bit shorter:
@Component
@Order(SwaggerPluginSupport.SWAGGER_PLUGIN_ORDER)
class SwaggerFixReqResPostfix(val delegate: DefaultModelNamesRegistryFactory = DefaultModelNamesRegistryFactory()) :
    ModelNamesRegistryFactoryPlugin by delegate {

    override fun modelNamesRegistry(registry: ModelSpecificationRegistry): ModelNamesRegistry =
        delegate.modelNamesRegistry(HackModelSpecificationRegistry(registry))

    class HackModelSpecificationRegistry(delegate: ModelSpecificationRegistry) :
        ModelSpecificationRegistry by delegate {
        // HACK
        override fun hasRequestResponsePairs(test: ModelKey?) = false
    }
}

Java version of the Hack by @fzyzcjy  (included in a spring Swagger configuration class)
    @Bean
    @Order(SwaggerPluginSupport.SWAGGER_PLUGIN_ORDER)
    public ModelNamesRegistryFactoryPlugin swaggerFixReqResPostfix() {
        return new DefaultModelNamesRegistryFactory() {
            @Override
            public ModelNamesRegistry modelNamesRegistry(ModelSpecificationRegistry registry) {
                return super.modelNamesRegistry(hackModelSpecificationRegistry(registry));
            }

            private ModelSpecificationRegistry hackModelSpecificationRegistry(ModelSpecificationRegistry delegate) {
                return new ModelSpecificationRegistry() {
                    @Override
                    public ModelSpecification modelSpecificationFor(ModelKey key) {
                        return delegate.modelSpecificationFor(key);
                    }

                    @Override
                    public boolean hasRequestResponsePairs(ModelKey test) {
                        return false;
                    }

                    @Override
                    public Collection<ModelKey> modelsDifferingOnlyInValidationGroups(ModelKey test) {
                        return delegate.modelsDifferingOnlyInValidationGroups(test);
                    }

                    @Override
                    public Collection<ModelKey> modelsWithSameNameAndDifferentNamespace(ModelKey test) {
                        return delegate.modelsWithSameNameAndDifferentNamespace(test);
                    }

                    @Override
                    public Set<ModelKey> modelKeys() {
                        return delegate.modelKeys();
                    }
                };
            }

        };
    }

For those still waiting for a fix, have a look at https://springdoc.org/. It might be a replacement for springfox for some of you.


Python API Doc - GetShaderReflection Return Type

Description
renderdoc.PipeState.GetShaderReflection() return type is listed as ShaderBindpointMapping.
In practice, return type seems to be ShaderReflection.
Not certain if this is another possible return type or a typo in the documentation.

Thanks for reporting this. The type information etc in the documentation is manual so it's susceptible to copy-paste errors like this one.
That commit should fix it, please let me know if you spot anything else!


Create Salts tab and include basic salts

Is your feature request related to a problem? Please describe.
Right now in templates there are no salts exist.
Describe the solution you'd like
Add salts tab into the templates tab and include basic known salts . The behavior should be the same as for functional groups (add super atoms)

closed as replicate of #1820


[google_maps_flutter] Fix CameraPosition regression

The nullability conversion added a type check when recreating a
CameraPosition from JSON that was too restrictive, and regressed the
app-facing package. This relaxes that assertion, and adds a test to
catch the issue.
Pre-launch Checklist

[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I signed the CLA.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I forgot to re-run the app-facing package tests after the last review changes to the platform interface, so missed this regression.


Upgrade curry for variadic functions. Fix tree shaking.

I still need to do a bit of testing. The location of the comment gets pretty funky after the transformation to CJS modules happens:
var _default = (
/*#__PURE__*/
0, _iterable.iterableCurry)(map);

exports.default = _default;
module.exports = exports["default"];

Oh and I need to trigger it for calls to the regular curry function to

Since the curry code is a bit heavier now, I pulled as much of it as can be fully parameterized out into a top level method so that it can be compiled and reused.

So I think that we don't really want or need a pure comment in the cjs files. I could change the configuration to only do that work for es module builds.
Rollup took over the work that I started on support __#PURE__ comments (read: rewrote my diff) and it should ship soon.
Tree shaking is going to be a feature unique to users of either Rollup or Webpack, and both have default configurations which will preference our mjs over our js.
In particular we define module to point to an mjs file in our package.json. Rollup will preference module over main by default, and so will Webpack

So I think that we don't really want or need a pure comment in the cjs files. I could change the configuration to only do that work for es module builds.

That would be nice but you don't have to if it increases complexity.

@KSXGitHub: nope it's pretty easy. Done.

OK I'm content with it now, it should be ready to merge.

@KSXGitHub: nope it's pretty easy. Done.

Adding things will almost always be the easiest, the hard part is when you want to change or remove them.

@KSXGitHub do you have a specific worry?

Nah, just clarify what I said in https://github.com/sithmel/iter-tools/pull/203#issuecomment-467982569 after reading your response (emphasis on "complexity" as opposed to "easy").
I also read your commits, it seems that the last commit adds no extra complexity, so I am fine with it so far.

@sithmel Fixed those things.


Save trades to db

Following my initial research I found the way which we can store our raw market data and tickers
There is InfluxDB, docs here
https://docs.influxdata.com/influxdb/v1.3/query_language/data_exploration/
just for example for our tickers
<symbol, timestamp, open, high, low, close, volume>
Query is:
SELECT open, close FROM market_data_1m WHERE symbol = 'BTC' AND time > '2017-09-19 14:00' AND time < '2017-09-19 15:00'

Java driver for influxdb
https://github.com/influxdata/influxdb-java

read
https://docs.datastax.com/en/cql/3.3/cql/cql_using/useCreateTableTOC.html
https://docs.datastax.com/en/cql/3.3/cql/cql_using/useCompoundPrimaryKeyConcept.html

See also https://docs.confluent.io/current/connect/index.html
See also http://docs.datamountaineer.com/en/latest/cassandra-sink.html


Fix: carousel chevron subpixel render

Jira
N/A
Summary
Fixes a visual rendering bug with the carousel nav buttons.
Details
This small CSS change fixes a subpixel issue with the chevron icon.
Before

After

How to test
Run the branch locally and inspect the carousel demos visually. Re-size your browser extremely and make sure the chevrons (previous and next buttons) render smoothly in all breakpoints.

@mikemai2awesome I'm good with the result of this fix but I'm curious about why this is the actual fix?
Because we are using magic numbers here, why is this the actual fix vs some other value? Additionally, just to play devils advocate here, what's going to stop us from accidentally changing this value back to something more standardized and causing this sub-pixel issue to reoccur?
CC @danielamorse @adamszalapski @remydenton

@sghoweri I will write some additional comments.

@sghoweri @adamszalapski
Comments are added to the CSS.


InputEvent: rename axis, scancode and button_index to index in 3.0

Is there any reason to have different names for the following variables? They are used in the same context.
InputEventJoystickButton.button_index  -> InputEventJoystickButton.index
InputEventJoystickMotion.axis -> InputEventJoystickMotion.index
InputEventMouseButton.button_index   -> InputEventMouseButton.index
InputEventKey.scancode  -> InputEventKey.index

i think it's clearer the way it is, prefer not to rename it
On Sat, Jun 3, 2017 at 10:05 PM, AlexHolly<EMAIL_ADDRESS>wrote:

Is there any reason to have different names for the following variables?
They are used in the same context.
InputEventJoystickButton.button_index -> InputEventJoystickButton.index
InputEventJoystickMotion.axis -> InputEventJoystickMotion.index
InputEventMouseButton.button_index -> InputEventMouseButton.index
InputEventKey.scancode -> InputEventKey.index
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/9039, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z20cWJufl6-vkp2-JYXb0tqz7mcA2ks5sAgLygaJpZM4NvPkf
.


how to assign internal ip to nodes

hi there,
glad to see you're progressing with this project.
since my installation relies on some components which have an internal ip as a precodition, i was trying to figure how to get an internal ip on the nodes. wit less success and i'm a bit lost here.

NAME
STATUS
ROLES
AGE
VERSION
INTERNAL-IP
EXTERNAL-IP
OS-IMAGE
KERNEL-VERSION
CONTAINER-RUNTIME

k8s-master-0
Ready
control-plane,master
26m
v1.22.0
none
2a01:4f9:c010:7335::1
Ubuntu 20.04.2 LTS
5.4.0-77-generic
containerd://1.4.9

...

goal: i'd like to get an interal ip assigned to every node which may be also used in the cluster communication.
i could easily setup an ipv4 internal network, e.g. and assign the nodes to these networks. hetzner seems not provide any options to have ipv6 networks.
file: internal_network.tf
resource "hcloud_network" "network" {
  name     = "network"
  ip_range = "<IP_ADDRESS>/16"
}

resource "hcloud_network_subnet" "network-subnet-master" {
  type         = "cloud"
  network_id   = hcloud_network.network.id
  network_zone = "eu-central"
  ip_range     = "<IP_ADDRESS>/24"
}

resource "hcloud_network_subnet" "network-subnet-worker" {
  type         = "cloud"
  network_id   = hcloud_network.network.id
  network_zone = "eu-central"
  ip_range     = "<IP_ADDRESS>/24"
}

then, in module "master" (and similar for worker) the internal ip could be assigned somehow like:
  private_network_ip = "10.0.1.${count.index + 10}"
  private_network_id = hcloud_network.network.id

  depends_on = [
    hcloud_network_subnet.network-subnet-master,
    hcloud_network.network
  ]

the internal ip ends on the "ens10" interface on the nodes.
but here my knowledge ends somehow. is there any way how i get the internal ip assigned to the kubernetes node?
i guess it needs to be added to the extra-sans but most probably also to wigglenet.
so, if you have some time or ideas how i could achieve this, please let me know.
thanks.
btw this kind of describes the issue with ceph -> requirements for the internal ip
https://github.com/rook/rook/issues/7866

I would have to test it, but IIRC when Hetzner Cloud Controller Manager is used in networks mode, the private IP is added as InternalIP on the node (see https://github.com/hetznercloud/hcloud-cloud-controller-manager#networks-support). In any case, it is the CCM that manages the node addresses. You can see that InternalIP is set to the node's primary IPv6 address before CCM is installed and then it disappears after CCM sets up the ExternalIPs.
But it is as you said, private networks are IPv4 only and also not encrypted. If you want to use IPv6 over the private network, you'd need some sort of tunneling over it and personally I don't see much benefit using that over the encrypted overlay that Wigglenet already provides.
Wigglenet does give every node "private" IPv4 and IPv6 address (the first IP in the podCIDR subnet of every node) that is routable within the cluster and you should be able to use for Ceph or any other application using host networking and relying on InternalIP. The only problem is that these addresses are not added to the Node spec, but I think this might be a worthwhile feature to add to Wigglenet.
Let me know what you think.

It is indeed the case that Hetzner CCM will assign the InternalIP address if networks are used:
https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/master/hcloud/instances.go#L181
However, bad news is that the CCM will also overwrite any other IPs that may be set by Wigglenet, so setting it in Wigglenet is not a viable option. I'll brood on it for a while, but in the meantime, using Hetzner private networks should be a viable option. I'll see if I can incorporate networks into this TF module in a way that makes sense.

@udatny Could you please review https://github.com/tibordp/terraform-hcloud-dualstack-k8s/pull/26 if it meets your needs. I also had to make a change to Wigglenet in order for node address changes to work reliably and the upgraded version is part of this PR.
Thanks!

i am very sorry for my late response.
i found some time yesterday and was testing your mr, had some other issues. and finally got my installation working all the way down to ceph.
it does exactly what i needed to have.
you did a very great job and im really thankful!!


Choose to task manager you would like to use for the frontend

Gulp o grunt

It would be very useful. Gulp is simpler!

Please, see @jayfk comment: https://github.com/pydanny/cookiecutter-django/issues/443#issuecomment-164827537
That said, if any interested in adding Gulp to this project, please send a pull-request, that adds support for Gulp that works both Heroku and Docker.

As @luzfcb said, pull requests are always welcome.


Support IE9+

This fixes problem with IE9 on react-0.13.
Would it be possible for you to merge it and also publish it for react-0.13 - we are still stacked with old version of react?

Hi, I'm away and without laptop, i'll be able to do that on tuesday. If I
have a minute I'll take a look to merge but wont be able to publish before
tuesday.
Le 11 mai 2016 16:29, "mieszko4"<EMAIL_ADDRESS>a écrit :

This fixes problem with IE9 on react-0.13.
Would it be possible for you to merge it and also publish it for
react-0.13 - we are still stacked with old version of react?
You can view, comment on, or merge this pull request online at:
https://github.com/romainberger/react-portal-tooltip/pull/14
Commit Summary

Support IE9+

File Changes

M package.json
https://github.com/romainberger/react-portal-tooltip/pull/14/files#diff-0
(2)
M src/index.js
https://github.com/romainberger/react-portal-tooltip/pull/14/files#diff-1
(4)

Patch Links:

https://github.com/romainberger/react-portal-tooltip/pull/14.patch
https://github.com/romainberger/react-portal-tooltip/pull/14.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/romainberger/react-portal-tooltip/pull/14

Great, thanx for the answer. I am not sure if this pr is good though since I am merging to react-0.14 branch. Perhaps you could also create react-0.13 branch so I can do pr there?

Sorry for the delay 😞
I've published versions for react 15, 0.14 and 0.13. For 0.13 npm install<EMAIL_ADDRESS>should do it.
Thanks!

Thanks!


Milestones Options have no effect

Hi!
Thanks for a wonderful plugin, but we would really love to enable "Crop time range" option. However, it seems that the visualization doesn't react to any changes to options (apply changes button is inactive). Is this still a to-do?

Thanks for filing the issue! Can you please provide a few more details, maybe a screenshot would help to be able to see what you would expect getting to visualize and what you're actually seeing.

Hello, it's been several month since I created this issue and it seems that the plugin has improved in the way we needed! What I meant was the following:

we set a time frame to -1 month ago till now. If 3 events had happened the day before it would have shown them all at the end of the line.
"crop time range" option seemed to be just what we needed: we expected it to show the first event at the beginning of the line, this second one in the middle and the third one at the end of the line.
we couldn't apply this "crop time range" setting because the "apply" button was disabled

Now I can see that by default it scales to the actual time interval during which it has had events and does not scale to the time period specified if there have been no events at the beginning or at the end of this period. I don't see this "crop time range" option at the Options tab as well.  However, the issue still persists: I tried unchecking "Render Labels" option but cannot apply changes (see the screenshot).

Thanks for the details! I'll try to pick it up in the upcoming releases.

So far I haven't found a way to work around this issue unfortunately. There's a workaround though and in more recent versions of the plugin I added a hint to use the Refresh button instead of that Play button. Even if you're on an older version without the hint, clicking the Refresh button should work for you. Hope that helps!

From version v7.4.0 onwards the play/update button is working again! https://github.com/walterra/kibana-milestones-vis/releases/tag/v7.4.0


Pylance/VSCode shows Pyright diagnostics output for files listed in "exclude" array of pyrightconfig.json

Problem
Hello,
I am currently trying to set up Pyright/Pylance, and I am encountering a small issue:

Pylance, the VSCode plug-in, shows diagnostics for files which I have excluded via the exclude setting of the pyrightconfig.json.
Based on this comment by @erictraut https://github.com/microsoft/pylance-release/issues/642#issuecomment-732175189, I imagined that listing files in the exclude array of pyrightconfig.json would cause VSCode/Pylance not to show the diagnostic output for these files.
The include/ignore settings don't seem to do anything either. Pylance shows diagnostics for every file in the repo.

Two things that I find confusing is that:

Pylance responds to all of the other settings in the pyrightconfig.json. Pylance responds to toggles for individual error codes, and to settings such as venv and venvPath. So Pylance is correctly finding and reading the config file.
The Pyright CLI tool respects the include/exclude/ignore settings. When run I Pyright from the CLI, it only produces diagnostic output for files listed in the include array. It correctly ignores things listed in exclude array (By Pyrght CLI tool I mean the one you install with pip install pyright).

Does Pylance respect exclude/include/ignore settings of the pyrightconfig.json?
What I am trying to achieve

I would like to gradually cover my codebase in types, as suggested in Getting Started with Pyright. So I'd like to add some files to the include array, but ignore all others.
Until I explicitly place a file into the include list, I don't want to see the Pylance diagnostics for that file, because all the red highlights make it hard to read code.

Test set up
To test this behavior, I created a test/ folder with just 3 files in it
test/
   include.py
   exclude.py
   pyrightconfig.json

Contents of the python files are the same. It's an erroneously typed function that produces reportGeneralTypeIssues diagnostic error:
def test(x: int) -> int:
    return str(x)

The relevant part of the pyrightconfig.json looks like this:
  "exclude": ["exclude.py"],
  "include": ["include.py"],

And here is the output of Pyright CLI tool. It correctly analyzes 1 file (includes.py) and reports 1 error:
Loading configuration file at /home/username/Documents/CodeRepos/test/pyrightconfig.json
stubPath /home/username/Documents/CodeRepos/test/typings is not a valid directory.
Searching for source files
Found 1 source file
/home/username/Ubuntu/Documents/CodeRepos/test/include.py
  /home/username/Documents/CodeRepos/test/include.py:2:12 - error: Expression of type "str" cannot be assigned to return type "int"
    "str" is incompatible with "int" (reportGeneralTypeIssues)
1 error, 0 warnings, 0 informations
Completed in 0.528sec

Here is the output of Pylance in the Problems tab of VSCode. It correctly flags include.py, but also the exclude.py which is excluded:

Here is the Output tab of VSCode for Python Language Server:
[Info  - 5:39:51 PM] (69291) Pylance language server 2022.4.3 (pyright 88f2a424) starting
[Info  - 5:39:51 PM] (69291) Server root directory: /home/username/.vscode/extensions/ms-python.vscode-pylance-2022.4.3/dist
[Info  - 5:39:51 PM] (69291) Setting pythonPath for service "test": "/bin/python3"
[Info  - 5:39:51 PM] (69291) Loading configuration file at /home/username/Documents/CodeRepos/test/pyrightconfig.json
[Warn  - 5:39:51 PM] (69291) The useLibraryCodeForTypes has been specified in both the config file and the client settings. The value in the config file (false) will take precedence
[Warn  - 5:39:51 PM] (69291) stubPath /home/username/Documents/CodeRepos/test/typings is not a valid directory.
[Info  - 5:39:51 PM] (69291) Searching for source files
[Info  - 5:39:51 PM] (69291) Found 1 source file
[Info  - 5:39:51 PM] (69291) Background analysis(1) root directory: /home/username/.vscode/extensions/ms-python.vscode-pylance-2022.4.3/dist
[Info  - 5:39:51 PM] (69291) Background analysis(1) started
[Info  - 5:39:52 PM] (69291) Indexer background runner(2) root directory: /home/username/.vscode/extensions/ms-python.vscode-pylance-2022.4.3/dist (index)
[Info  - 5:39:52 PM] (69291) Indexing(2) started
[Info  - 5:39:53 PM] (69291) Indexer done(2). indexed 583 files

This is just one example, and I tried other permutations of include/exlude settings, such as setting the entire dir as exlcude. Pyright CLI respects the settings, while Pylance continues to report diagnostics for both files.
I also note that the last line in the log says indexed 583 files. I am not sure where that comes from. I opened VSCode from terminal inside the test/ folder with code ..
Related Issues
Here is some of the threads I explored while trying to find a solution.
https://github.com/microsoft/pylance-release/issues/2255
https://github.com/microsoft/pylance-release/issues/642

Thank you for reading! :+1:
PS here is the entire pyrightconfig.json file if relevant:
{
  "pythonPlatform": "Linux",
  "pythonVersion": "3.8",
  "exclude": ["exclude.py"],
  "include": ["include.py"],
  "typeCheckingMode": "strict",
  "useLibraryCodeForTypes": false,
  "verboseOutput": false,
  "strictListInference": true,
  "strictDictionaryInference": true,
  "strictSetInference": true,
  "strictParameterNoneValue": true,
  "enableTypeIgnoreComments": true,
  "reportMissingTypeStubs": "warning",
  "reportMissingModuleSource": "error",
  "reportMissingImports": "error",
  "reportUndefinedVariable": "error",
  "reportAssertAlwaysTrue": "error",
  "reportInvalidStringEscapeSequence": "error",
  "reportInvalidTypeVarUse": "error",
  "reportSelfClsParameterName": "error",
  "reportUnsupportedDunderAll": "error",
  "reportUnusedExpression": "error",
  "reportWildcardImportFromLibrary": "error",
  "reportGeneralTypeIssues": "error",
  "reportOptionalSubscript": "error",
  "reportOptionalMemberAccess": "error",
  "reportOptionalCall": "error",
  "reportOptionalIterable": "error",
  "reportOptionalContextManager": "error",
  "reportOptionalOperand": "error",
  "reportTypedDictNotRequiredAccess": "error",
  "reportPrivateImportUsage": "error",
  "reportUnboundVariable": "error",
  "reportUnusedCoroutine": "error",
  "reportConstantRedefinition": "error",
  "reportDuplicateImport": "error",
  "reportFunctionMemberAccess": "error",
  "reportImportCycles": "error",
  "reportIncompatibleMethodOverride": "error",
  "reportIncompatibleVariableOverride": "error",
  "reportIncompleteStub": "error",
  "reportInconsistentConstructor": "error",
  "reportInvalidStubStatement": "error",
  "reportMatchNotExhaustive": "error",
  "reportMissingParameterType": "error",
  "reportMissingTypeArgument": "error",
  "reportOverlappingOverload": "error",
  "reportPrivateUsage": "error",
  "reportUnknownArgumentType": "error",
  "reportUnknownLambdaType": "error",
  "reportUnknownMemberType": "error",
  "reportUnknownParameterType": "error",
  "reportUnknownVariableType": "error",
  "reportUnnecessaryCast": "error",
  "reportUnnecessaryComparison": "error",
  "reportUnnecessaryIsInstance": "error",
  "reportUnusedClass": "error",
  "reportUnusedImport": "error",
  "reportUnusedFunction": "error",
  "reportUnusedVariable": "error",
  "reportUntypedBaseClass": "error",
  "reportUntypedClassDecorator": "error",
  "reportUntypedFunctionDecorator": "error",
  "reportUntypedNamedTuple": "error",
  "reportCallInDefaultInitializer": "error",
  "reportImplicitStringConcatenation": "error",
  "reportMissingSuperCall": "error",
  "reportPropertyTypeMismatch": "error",
  "reportUninitializedInstanceVariable": "error",
  "reportUnnecessaryTypeIgnoreComment": "error",
  "reportUnusedCallResult": "error"
}

Pylance does honor the "include", "exclude" and "ignore" settings in pyrightconfig.json.
The "include" and "exclude" settings determine which code files comprise your "project". This resulting set of files is used for all language server actions that operate on your project, such as "find all references" and "replace all". Also, if you have "python.analysis.diagnosticMode" set to "workspace", pylance will run the type checker on all of the files in the project.
Pylance always runs the type checker on a file that you open in the editor regardless of whether it's part of the project. Excluding a file won't prevent pylance from running the type checker and reporting errors in the "Problems" tab if that file is opened. I suspect that's what you're seeing. If you close the file, you should see the diagnostics disappear from the "Problems" tab. They are presented only when you have the file open.
If a file is referenced in the "ignore" setting, the type checker may still run on that file, but any diagnostics generated as part of that analysis are ignored and won't appear within the "Problems" tab. If your intent is to never see any diagnostics for a file (or an entire directory), you can include that in the "ignore" setting.

Thank you for the clear explanation of how Pylance uses these settings. Not including files in the ignore was the problem. Once I included files that I want to exclude into ignore, VSCode stopped reporting Pylance diagnostics for them.

Thanks for the explanation, @erictraut.
If my understanding is correct, the ignore array could be difficult to maintain for large codebases.
My team works on a section of a large monolith. We want to introduce type-checking to the part we own and then gradually expand. So far, we've done this using pre-commit targeting only specific directories. Unfortunately, Pylance is picking up our Pyright configuration and generating diagnostic output for the entire codebase - which is disruptive for other teams.
The ignore array solves our problem, but the approach seems cumbersome. It would be helpful to ignore everything (suppress diagnostic output) and then specify a list of directories or files that should not be ignored.
Do you have any advice here? Perhaps I missed something in the docs.
Appreciate all your work on this project!

Thanks for the detailed response, @erictraut 🙇♂


Enable filters panel for checked resources

In order to make it more consistent, the filters panel should be enabled when there are checked resources. The user should be able to open the filters panel from the checked resources actions menu, maybe with an icon that is delimited by the rest of the actions ( a hotkey could also be useful for opening them ).

This depends on: https://github.com/kubeshop/monokle/issues/3085


add sitemap to repository

installed the sitemap library to docs tool kit
and added sitemap.xml.ts to server/routes directory
document tree can be seen at http://example.com/sitemap.xml

@Hdd87 pay attention to #11 . It uses options reserved for sitemap.

@Hdd87 Stas implemented filter for hidden content in #26. Do the same for the sitemap.

Previous review is still not resolved

@d0rich Hi, which one is not resolved ?


Added javadocs

Fixes #29

Thanks, this is really useful. I now understand more how to use this.

:+1:


Pin::getEdge/setEdge

Edge detection is primarily used for interrupt detection - sometimes we only care about interrupts LOW -> HIGH for example.  However, it looks like this is being set via the Pin class (and can be done for output pins, which isn't useful).  Would it make more sense to set this on the interrupt watcher instead?

Let me give this some thought!
Trying to decide if this is best as a parameter to InterruptWatcher::register(), a parameter to the input pin factory or a method on the input pin.

I think my main concern about having this is an InterruptWatcher::register() parameter or factory parameter is that it implies it wont change.
I'm leaning towards methods on an InputPin class.

I feel it's more logical to define the edge you're interested in detecting at the same time you're registering the callback to handle occurrences of that edge.
For example, let's say I want a callback to fire whenever a button is pressed.  I'd want to listen for any FALLING (or RISING) events and do some action.  However, hooking that same callback up to a pin set to BOTH means the callback would fire twice.  If I forget to set the pin's edge beforehand, or if it's modified at some other point in time, my callback isn't going to work as expected.
For Arduino, setting the edge is done when registering the interrupt callback: https://www.arduino.cc/en/Reference/AttachInterrupt
RPi.GPIO does the same thing with their wait_for_edge() function: https://sourceforge.net/p/raspberry-gpio-python/wiki/Inputs/


Feature/20210707 updates

Updated code summary (full details in commit comments):

Updated enhanceLogClass library so that when logging to log.nsf the default will be to log to the machine (server or client) upon which the code is running, rather than the machine (server or client) where the source nsf is located.    Resolves #77
Added agent for testing HTTP Request Response Codes.  Resolves #78
Updated Build and Release Date values in domiConstantsBE library
Updated Help and About documents to include links to online DOMI documentation and Github page.
Applied design changes and tested on mail file.  (test results SUCCESS).
Updated DOMI.nsf (in DOMI.zip file resource).

Resolves issue #77,
Resolves issue #78


Deleting blog-post counts as quiz deleted

When we create a new blog-post it doesn't count as quiz count. But deleting counts as quiz deleted.  Either it should be counted as quiz created or not count as quiz deleted.

fixed


I don't get the idea of that plugin

This plugin allows vim to use Racer ( on Apr 21) for Rust code completion and navigation. but as far as I know vim uses things like YouCompleteMe or deoplete to provide code completion. I also don't know should I pair this plugin with https://github.com/rust-lang/rust.vim or they should be installed separately of each other.

You need to auto completion?
If it is need, you need to install auto completion framework like YouCompleteMe or deoplete.
But if it is not need, you can use manual completion <C-x><C-o> instead.


react-hot-loader & formatter change

I'm noticing that react-hot-loader is not refreshing the component when I change the column formatter function (it works when changing text or align attributes).
I plan to open an issue in the react-hot-loader repo, but I wanted to see if anyone else is using it in the context of react-hot-loader and noticing similar issues. The current workaround is to use key= Math.random() to force react to re-render the component.
I'm using react-hot-loader 4.12.12.

@aliogaili I didn't notice this issue. but how did you change the column formatter function? Would you please describe it a bit more?  Thanks!

I've react-hot-loader configured to accept module changes on the parent container and down the component tree I've a table.
In the table I pass a custom formatter, nothing special:
  {         dataField: 'addedOn',         text: 'Added On',         align: 'center',         headerAlign: 'center',         formatter: (cell, row) => {           return
This Doesn't hot reload
;         }
If I change the formatter function, for example change the text, the effect won't hot reload until I force refresh. Again, this is issue is only observed with react-hot-loader (storybook it works, but they have their own hot-reloader implementation).
My current workaround is to generate a random key:
key={DataTable.hotKey()}

// A hack to make it work with react-hot-loader
DataTable.hotKey = () => {
  if (module.hot) {
    return Math.random();
  }
  return undefined;
};

I'm not sure if this is only local to my webpack/react-hot-loader setup or a general issue, I think we need a smaller reproduction. I really hope the new react fast refresh will iron those glitches out.

Thanks your quick reply @aliogaili
it might be an issue in react-hot-loader, Let's see if fast refresh could solve this issue.


Add a single event for a move's own immunity to a specific target

Captivate, Dream Eater, Leech Seed and Synchronoise have a target-specific immunity calculation. These moves used to use the TryHit event, as this used to run once per target. However, this does not properly recreate cart mechanics, as the check should happen before the accuracy check. Additionally, the spread move effect order refactor (#5216) changed the mechanics of the TryHit event so that it only runs once (for the first target) thus breaking Captivate and Synchronoise.
This new TryImmunity (or I guess you want it just called Immunity right?) event allows the move to veto each target independently by returning false for immune targets. This also avoids having to specifically add the -immune message in each of those moves.

Is this at all specific to Invulnerability?

Is this at all specific to Invulnerability?

It's just another form of immunity, it's not related to two-turn move semi-invulnerability.

"This branch has conflicts that must be resolved"
Actually an auto-merge...


TrafficSplit OpenAPI Validation is incorrect

Describe the proposal
The OpenAPI validation for the TrafficSplit CRD definition has service and backends as required fields at the root level (https://github.com/servicemeshinterface/smi-sdk-go/blob/master/crds/split.yaml#L33-L36):
  validation:
    openAPIV3Schema:
      required:
        - service
        - backends

But this should really be nested under a spec field, according to https://github.com/servicemeshinterface/smi-spec/blob/master/traffic-split.md#specification
Scope

[ ] New specification
[ ] Traffic Access Control
[ ] Traffic Specs
[ ] Traffic Metrics
[x] Traffic Split

Possible use cases

Bug should probably be against https://github.com/servicemeshinterface/smi-sdk-go and not this repo.


Remove GPT_4_32K_MODEL_CONFIG

Description

In certain sections, we previously relied on GPT 4 32k due to issues with the output JSON. However, these issues appear to be resolved in the most recent version of GPT 4 (0125). This PR updates the generation actions to use the latest model version.
Risk

If we hit our rate limit, this PR is safe to be rollback.
Deploy Plan

bye bye thank you for the fish


Supported SPI clocks

Add a note on SPI explaining the supported clocks and how they are derived from max frequency. If max frequency is 60Mhz then the clocks are 60 -> 30 -> 20 ....etc 1/2 -> 1/3 -> 1/4 The driver will pick the closet clock below the selected one. Setting the clock on previous example to 29 will result in 20 not 30. This is done on purpose to keep the clock the highest possible but at or below the specified frequency, never higher.

Made changes to documentation that need to be reviewed before final pull request submission.

Made changes to documentation that need to be reviewed before final pull request submission.


Sign in with Twitter not working, tried on several machines and networks

YASB Bug Report
Note: If you are experiencing problems with the permalink URL when you have Maul or Bomblet Generator in your list, this is a known issue.  For more information please see https://www.reddit.com/r/XWingTMG/comments/7c4q6h/yet_another_squad_builder_problems_with_maul/
Expected Behavior
State what you expect to happen here.
Actual Behavior
State what actually happens here.
Language
State what language translation you use.

I just noticed this too.  I think twitter recently shut down some older API calls.  That could be the cause of this issue.

Fixed; had to configure an extra callback URL because of https://twittercommunity.com/t/action-required-sign-in-with-twitter-users-must-whitelist-callback-urls/105342

Thanks!
On Mon, Jun 25, 2018, 9:02 PM Geordan Rosario<EMAIL_ADDRESS>wrote:

Fixed; had to configure an extra callback URL because of
https://twittercommunity.com/t/action-required-sign-in-with-twitter-users-must-whitelist-callback-urls/105342
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/geordanr/xwing/issues/582#issuecomment-400170941, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AhvbHpdtXEuNLVGqFMl-6Xoi0B_KraF5ks5uAbJOgaJpZM4Up3tW
.


Is deploy-only possible?

Hello,
I would like to have a separate Git repository where I would only deploy (so no build) via SSH: download the binary, stop the service, replace files, restart the service etc. A webhook would trigger this after a successful build of the binary (from the original repository). Is such thing possible?

Please use http://discuss.drone.io for general usage questions such as this


Change instance wrapper vnode relationship

Currently we store the root vnode of an instance vnode tree in the wrapper:
const TestComponent = {
  template: '

'
}
const wrapper = mount(TestComponent)
wrapper.is('div') // true
wrapper.is(TestComponent) // true
wrapper.isEmpty() // true

This can result in unexpected behavior:
const wrapper = mount(TestComponent)
wrapper.find('div').is('div') // true
wrapper.find('div').is(TestComponent) // false

I don't think this is the best way going forward. It makes the instance and the root vnode appear the same. I propose changing the wrapper vnode to be the parent vnode of the instance:
const TestComponent = {
  template: '

'
}
const wrapper = mount(TestComponent)
wrapper.is('div') // false
wrapper.isEmpty() // false

The main benefit of this would be to make the distinction between an instance and an element vnode clear.
Changing the behavior would result in lots of breaking API changes, which is why I'd like to add it before we move to 1.0.

I think this makes more sense. I intuitively expect the vnode of a vm to refer to the "top" of the tree.
The main question is what are the main APIs this breaks? find and findAll and is will likely need
significant changes (but that shouldn't change the public API?).
I can't think of which APIs would break - vnode is used a lot internally, but not that much by the public API?

On reflection I believe we should keep the existing behavior. With the existing behavior, users can trigger events on a root element of an external component (if listeners are added to the root element) without knowing the implementation detail:
wrapper.find(VIcon).trigger('click')


[Bug]: API /api/v1/images Parameter 'nsfw' does not act as described

What happened?
According to the API docs, when the parameter 'nsfw' is not supplied, all items shall be returned but actually nsfw items are missing and are only returned with "nsfw=X".
Docs:
https://github.com/civitai/civitai/wiki/REST-API-Reference#get-apiv1images
Steps to reproduce the problem

Paginate all the way to the end: civitai.com/api/v1/images?username=Dix69&limit=200
The API will return significantly less resuls than 1700 while there are 1700+ items present in that profile.
Using the following request, the API will return all items: /api/v1/images?username=Dix69&limit=200&nsfw=X

What should have happened?
Return all items when parameter 'nsfw' is not given.
To fix this, either update the docs accordingly or update the API to fit the docs.

Found this already posted, This optional parameter might be better if it was a filter based off rating that is shown on site. Since the boolean nsfw parameter is not on this endpoint.
Maybe changing it to rating instead for clarity.

rating (OPTIONAL)
enum (PG, PG-13, R, X, XXX)

could also make this a Boolean parameter and have nsfw override rating. if FALSE then returns only (PG, PG-13)

nsfw (OPTIONAL)
boolean

Same issue here. Not using the parameter only returns sfw images.


Fix CoverAmbience.js

Looks like class names were changed, because no .main-nowPlayingWidget-trackInfo class exists anywhere on my Spotify, causing the extension to crash. This PR fixes that.

Hi, which version of Spotify are you on? I don't have this problem on Spotify <IP_ADDRESS>0 + Spicetify v2.36.11
The div.main-nowPlayingWidget-trackInfo.main-trackInfo-container selector seems to select only the element in the bottom left corner, while the div.main-trackInfo-container selector also selects the track info in the side bar on the right.

Ah, think my version was outdated

glad you got it figured out :)


Bump the version to 1.24.0-preview

Because https://github.com/Azure/azure-sdk-for-net/pull/5008 was merged after publishing the 1.23.0-preview, I need to change the version.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@NMijat1024  Please resolve merge conflicts

Per our guidelines, please squash commits into a single commit and update the PR. Looks good for the most part but curious if this is a version bump without any changes

Resolved @dsgouda

We should probably be using feature branches to avoid such confusion. I also see that there is this PR open, should it be merged before or after this PR.

I guess it is okay to merge this PR first, because nuget package version 1.23.0-preview is already published.

@dsgouda Just wait to squash commits. :)

@NMijat1024 please resolve conflicts and update the PR


Caught exception: TypeError: Cannot read property 'getConnectivityState' of undefined

Currently I am getting this error even though the grpc module is v1.10.1:
info: Creating a marble owner...
debug: [fcw] setting target event url grpc://localhost:7053
debug: [fcw] Invoking Chaincode: init_owner()
debug: [fcw] Sending invoke req chaincodeId=marbles, fcn=init_owner, args=[o01527515931064nsYGJ, amy, United Marbles], 0=193, 1=51, 2=196, 3=93, 4=149, 5=89, 6=216, 7=29, 8=156, 9=44, 10=76, 11=174, 12=252, 13=138, 14=135, 15=75, 16=57, 17=41, 18=95, 19=67, 20=209, 21=133, 22=192, 23=35, _transaction_id=41c7da72279f94af6d2b29d358dee51df83520758de73c6d864e118f9a4726d8
debug: [fcw] listening to transaction event. url: grpc://localhost:7053
info: [EventHub.js]: _connect - options {"grpc.http2.keepalive_time":300,"grpc.keepalive_time_ms":300000,"grpc.http2.keepalive_timeout":35,"grpc.keepalive_timeout_ms":3500,"grpc.max_receive_message_length":-1,"grpc.max_send_message_length":-1}
error: Caught exception: TypeError: Cannot read property 'getConnectivityState' of undefined
at EventHub._checkConnection (/home/lwy599/IBM_Bluemix/adcoin/node_modules/fabric-client/lib/EventHub.js:471:39)
at EventHub.registerTxEvent (/home/lwy599/IBM_Bluemix/adcoin/node_modules/fabric-client/lib/EventHub.js:713:8)
at setup_event_hub (/home/lwy599/IBM_Bluemix/adcoin/utils/fc_wrangler/parts/invoke_cc.js:125:14)
at Object.invoke_cc.invoke_chaincode (/home/lwy599/IBM_Bluemix/adcoin/utils/fc_wrangler/parts/invoke_cc.js:52:3)
at Object.fcw.invoke_chaincode (/home/lwy599/IBM_Bluemix/adcoin/utils/fc_wrangler/index.js:57:13)
at Object.marbles_chaincode.register_owner (/home/lwy599/IBM_Bluemix/adcoin/utils/marbles_cc_lib.js:230:7)
at Object.startup_lib.create_owners (/home/lwy599/IBM_Bluemix/adcoin/utils/startup_lib.js:260:15)
at /home/lwy599/IBM_Bluemix/adcoin/utils/startup_lib.js:211:17
at /home/lwy599/IBM_Bluemix/adcoin/node_modules/async/dist/async.js:3083:16
at eachOfArrayLike (/home/lwy599/IBM_Bluemix/adcoin/node_modules/async/dist/async.js:1003:9)
debug: [ws] broadcasting to clients. 1 error
debug: [ws] broadcasting to clients. 2 error
debug: [ws] broadcasting to clients. 3 error
debug: [ws] broadcasting to clients. 4 error
error: Caught exception: TypeError: Cannot read property 'getConnectivityState' of undefined
at ClientDuplexStream. (/home/lwy599/IBM_Bluemix/adcoin/node_modules/fabric-client/lib/EventHub.js:305:56)
at emitOne (events.js:116:13)
at ClientDuplexStream.emit (events.js:211:7)
at addChunk (_stream_readable.js:263:12)
at readableAddChunk (_stream_readable.js:250:11)
at ClientDuplexStream.Readable.push (_stream_readable.js:208:10)
at Object.onReceiveMessage (/home/lwy599/IBM_Bluemix/adcoin/node_modules/fabric-client/node_modules/grpc/src/client_interceptors.js:1302:19)
at InterceptingListener.recvMessageWithContext (/home/lwy599/IBM_Bluemix/adcoin/node_modules/fabric-client/node_modules/grpc/src/client_interceptors.js:629:19)
at /home/lwy599/IBM_Bluemix/adcoin/node_modules/fabric-client/node_modules/grpc/src/client_interceptors.js:728:14
debug: [ws] broadcasting to clients. 1 error
debug: [ws] broadcasting to clients. 2 error
debug: [ws] broadcasting to clients. 3 error
debug: [ws] broadcasting to clients. 4 error
The setup steps 1, 2 3 work correctly. I get this on Step 4 when the first marble (amy) is being created.
I am at the latest commit.

as a work around you could try not using eventhub, change use_events to false https://github.com/IBM-Blockchain/marbles/blob/master/config/marbles_local.json#L3 .

closing, inactivity

Why did you close this bug? It is clearly still there.

@nyetwurk

closing, inactivity

I closed it because inactivity.
I've been unable to reproduce this and OP vanished. No one else has reached out with a similar issue.

Sorry, I meant that the suggested solution of simply using an ancient version of grpc is not optimal. The code should be fixed to support recent versions.


Backward pagination with resolveOffsetConnection not working with the Relay pagination plugin

We use resolveOffsetConnection with the relay pagination plugin.
Seems that hasNextPage is not properly updated when you paginate in the opposite direction.
This query for forward pagination works:
products(first: 10, after: "T2Zmc2V0Q29ubmVjdGlvbjoxOQ==") {
    edges {
      cursor
      node {
      	id
        title
      }
    }
    pageInfo {
      endCursor
      startCursor
      hasNextPage
      hasPreviousPage
    }
    totalCount
  }

result:
"pageInfo": {
        "endCursor": "T2Zmc2V0Q29ubmVjdGlvbjoyNA==",
        "startCursor": "T2Zmc2V0Q29ubmVjdGlvbjoyMA==",
        "hasNextPage": false,
        "hasPreviousPage": true
      },
"totalCount": 25

This query for backward pagination doesn't work:
query products {
  storeProducts(last: 10, before: "T2Zmc2V0Q29ubmVjdGlvbjoyNA==") {
    edges {
      cursor
      node {
      	id
        title
      }
    }
    pageInfo {
      endCursor
      startCursor
      hasNextPage
      hasPreviousPage
    }
    totalCount
  }
}

result:
 "pageInfo": {
        "endCursor": "T2Zmc2V0Q29ubmVjdGlvbjoyMw==",
        "startCursor": "T2Zmc2V0Q29ubmVjdGlvbjoxNA==",
        "hasNextPage": false,
        "hasPreviousPage": true
      },
"totalCount": 25

hasNextPage should be true?

jest released a fix, let me know if you are still having issues after upgrading

Lighting fast fix and works great! 🙏👍


Add Plumo paper to papers area of celo.org

Expected Behavior
a spot within protocol section for https://docs.zkproof.org/pages/standards/accepted-workshop3/proposal-plumo_celolightclient.pdf
Current Behavior
no plumo paper

update celo.org/papers

update celo.org/papers


[WIP] Add sync feature

This is the first pass at adding a feature to sync data between Bearden and Redshift. A couple things I plan to tackle in future commits:

tests
move from PG to Sequel
update env.example

This is looking 💪 great!


Fixed .framework compilation

Include missing MASShortcutViewButtonCell
Fixed header attributes and search paths
Conditional in MASLocalization.m
Fixed README link

Thanks!


Fails to install on Arch Linux

During a normal install of ignoreit, at the build phase it fails when attempting to compile ignoreit v2.4.8, with the following error log:
   Compiling reqwest v0.11.11
   Compiling ignoreit v2.4.8 (/home/cornul11/.cache/yay/ignoreit/src/ignoreit-2.4.8)
error: Cannot have both "native-tls" and "vendored-tls" enabled at the same time
  --> src/main.rs:14:1
   |
14 | compile_error!("Cannot have both \"native-tls\" and \"vendored-tls\" enabled at the same time");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not compile `ignoreit` due to previous error
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: ignoreit

Was this installed with cargo-install or through the AUR?

It was installed using AUR.

Has been fixed in the recent aur update, https://aur.archlinux.org/cgit/aur.git/commit/?h=ignoreit&id=07b12e0ce43679097aecbce7253f40e56ad02b1b


Add blocking Wait method for audio tracks

I guess this should improve situation described in #1230 for a bit.
Please take into consideration that:

I did not touch audio samples because, as far as I understand, this workaround was applied only to tracks.
I understand that track.Restart().Wait(); is much more better, but these Start/Stop/Restart methods are from IAdjustableClock interface. According to it's name, it is not audio specific and I guess I can't just change described method signatures to something like AsyncAudioTask Start();.
Updated game code can be here.

I'd suggest checking WorkingBeatmap's implementation, as it is more standard conforming and likely cleaner to code.

This one looks better #1275


Fixed syntax error (python 2).

Note: tests here do not cover this issue, so no need to wait on the tests.

Thanks!

@jbednar, sorry, turns out there's another python 2 syntax error in that notebook.

data = [[node, *layout[node]] for node in graph.nodes] isn't valid python 2.7.
My guess is something like
data = [[node]+layout[node].tolist() for node in graph.nodes]
might be ok, but I'm not sure what all the things here are.

Turns out another notebook also had a problem on python 2.7. The three changes I made to get the lint checks to pass for examples/ using python 2.7 are shown below. (The second change is already now in master, the third is what's discussed above, the first is new.)
$ git diff master examples/
diff --git a/examples/user_guide/5_Rasters.ipynb b/examples/user_guide/5_Rasters.ipynb
index fcc7e5a..2748bdd 100644
--- a/examples/user_guide/5_Rasters.ipynb
+++ b/examples/user_guide/5_Rasters.ipynb
@@ -24,7 +24,7 @@
     "    return np.cos((x**2+y**2)**2)\n",
     "\n",
     "def sample(fn, n=50, range_=(0.0,2.4)):\n",
-    "    xs = ys = np.linspace(*range_, n)\n",
+    "    xs = ys = np.linspace(range_[0], range_[1], n)\n",
     "    x,y = np.meshgrid(xs, ys)\n",
     "    z   = fn(x,y)\n",
     "    return xr.DataArray(z, coords=[('y',ys), ('x',xs)])\n",
diff --git a/examples/user_guide/7_Networks.ipynb b/examples/user_guide/7_Networks.ipynb
index d7d56a6..42fc161 100644
--- a/examples/user_guide/7_Networks.ipynb
+++ b/examples/user_guide/7_Networks.ipynb
@@ -147,7 +147,7 @@
     "    if canvas is None:\n",
     "        xr = nodes.x.min(), nodes.x.max()\n",
     "        yr = nodes.y.min(), nodes.y.max()\n",
-    "        canvas = ds.Canvas(**cvsopts, x_range=xr, y_range=yr)\n",
+    "        canvas = ds.Canvas(x_range=xr, y_range=yr, **cvsopts)\n",
     "        \n",
     "    np = nodesplot(nodes, name + \" nodes\", canvas, cat)\n",
     "    ep = edgesplot(edges, name + \" edges\", canvas)\n",
@@ -344,7 +344,7 @@
     "\n",
     "def nx_layout(graph):\n",
     "    layout = nx.circular_layout(graph)\n",
-    "    data = [[node, *layout[node]] for node in graph.nodes]\n",
+    "    data = [[node]+layout[node].tolist() for node in graph.nodes]\n",
     "\n",
     "    nodes = pd.DataFrame(data, columns=['id', 'x', 'y'])\n",
     "    nodes.set_index('id', inplace=True)\n",


Camera sensitivity increase for MGS3?

Not sure if this beyond the scope of this project but It'd be great if a hack for upping sensitivity in MGS3 could be implemented for KB+M. Currently it's abysmal and messing around with DPI & Mouse settings on windows is a pain.

There are a few calls to windows to get the cursor position. It might be possible to hook in to it and modify the reported position thereby increasing the perceived mouse sensitivity. I'll take a look at it further tomorrow.

I've added this option to the latest release (v0.7). Just need to tweak MGSHDFix.ini to enable it and adjust. If you can, give it a try and let me know if this works for you.

I enabled the mouse sensitivity multiplier and camera speed is still slow, no matter what value I put on the multiplier

I enabled the mouse sensitivity multiplier and camera speed is still slow, no matter what value I put on the multiplier
Edit: alright, It works but I have to alt-tab the game first in order to make the multiplier setting work

I was able to replicate this on my end so I've tried altering the position of the hook. I've also added a separate X and Y multiplier. Can you try out this test build?
MGSHDFix_v_0_7_mousetest.zip

I enabled the mouse sensitivity multiplier and camera speed is still slow, no matter what value I put on the multiplier
Edit: alright, It works but I have to alt-tab the game first in order to make the multiplier setting work

I was able to replicate this on my end so I've tried altering the position of the hook. I've also added a separate X and Y multiplier. Can you try out this test build?
MGSHDFix_v_0_7_mousetest.zip

Just tested it and the multiplier is now working as expected

Works great. Thanks.

Works great. Thanks.
I modified it like this and it didn't work for me
Enabled = true
Multiplier = 10

I enabled the mouse sensitivity multiplier and camera speed is still slow, no matter what value I put on the multiplier
Edit: alright, It works but I have to alt-tab the game first in order to make the multiplier setting work

I was able to replicate this on my end so I've tried altering the position of the hook. I've also added a separate X and Y multiplier. Can you try out this test build?
MGSHDFix_v_0_7_mousetest.zip

Just tested it and the multiplier is now working as expected

I modified it like this and it didn't work for me
Enabled = true
Multiplier = 10


Order of (id, bounds) pairs

This is minor nitpicky thing but intersections provides (id, bounds) but remove accepts bounds, id.
These should probably have the same order for consistency, because sometimes you'll want to take intersection candidates and pass them to remove later.

Standardized on id, bounds, [value].