bower.json only includes angulartics as main

We are using wiredep on a project to perform injection. We recently updated versions of angulartics and realized that our app was crashing because it couldn't find angulartics.clicky
In past versions wiredep had no problem including all the components because the bower.json "main" property was an array with each and every dependency listed in it. At some point, the property was rewritten to only include angulartics.js
I understand that the plan was to eventually break out each provider into its own package, but since this hasn't been completed yet, the removal of other packages from the main property is breaking compatibility with wiredep.

The issue was easily fixed by adding an override to our bower.json, but if this is a design choice, could this perhaps be added to the README.md so that people know what to do in order to fix their dependency injection?

@weeksling is right. The following snippet in the bower.json solved the problem for me.
"overrides": {       "angulartics": {          "main": [             "src/angulartics.js",             "src/angulartics-heap.js"          ]       }   }
There is similar issue as well #225


ARTEMIS-1664 fix npe bug while getting element in the process of rehash

closing as https://github.com/apache/activemq-artemis/pull/1851 is what should be merged was just branching from there to get a PR build done to check it.


new:update device adminstate

Enable update of device admin state by deviceName or deviceId
Usage Examples:
./edgex-cli device adminstate update  -s LOCKED -d TestRandom-Integer-Device
./edgex-cli device adminstate update  -s unlocked --deviceId 089d3bbf-3795-4ac6-b471-e9645969f720
Fix: https://github.com/edgexfoundry/edgex-cli/issues/247
Signed-off-by: Diana Atanasova<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@601d233). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #295   +/-   ##
=========================================
  Coverage          ?   20.45%
=========================================
  Files             ?        3
  Lines             ?       44
  Branches          ?        0
=========================================
  Hits              ?        9
  Misses            ?       35
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601d233...c6fddd3. Read the comment docs.

@mkbhanda Thank you for reviewing


Failure of enemy predictions in some circumstances

Hi @jeefo, a fix has been made to ensure that enemies' guesses about bots fail in some cases. I think it would be better for these conditions to go back to normal in order to fix this problem.
  auto isPredictedIndexApplicable = [&] () -> bool {
     if (!vistab.visible (m_currentNodeIndex, predictNode) || !vistab.visible (m_previousNodes[0], predictNode)) {
        predictNode = kInvalidNodeIndex;
        pathLength = kInfiniteDistanceLong;
     }
     return graph.exists (predictNode) && pathLength < cv_max_nodes_for_predict.as <int> ();
  };

Hello, it was against looking-at-the-wall-continuously bug. It's probably should be reworked with some sort of a timer rather than explicitly failing predicted node in that case.

Hello, it was against looking-at-the-wall-continuously bug. It's probably should be reworked with some sort of a timer rather than explicitly failing predicted node in that case.

yes @jeefo timers are broken. They should do this the first time they hear about it.


mgmt: mcumgr: grp: os_mgmt: Add datetime get/set functions

Adds datetime set and get functions which allow for setting and getting the current time to/from the rtc alias device

@bjarki-trackunit might be of interest


TwitterBot to automatically add Tweet to Bookmarks

Adding a Tweet to Bookmarks is a mobile app only feature where you hit the share button under a tweet and 'Add Tweet to Bookmarks' (other options are 'Send via Direct Message' or 'Share Tweet via...'). I'd want to add tweets to bookmarks based on keywords or hashtags or maybe users they mention.
Any hint as to how I could add this to my Python TwitterBot - thank you for the wonderful guide - Iappreciatethisisnotcustomersupport ;)

Upon researching this I have found nothing on how to bookmark on the desktop, except for navigating to mobile.twitter.com and bookmarking from there. However, this will not work with Tweepy.
If you want to store tweets, I think the best option would be to simply export the tweets from the keyword or hashtag and save them to a CSV file. If needed I could help you with this.
You could also use lists on Twitter to follow a specific set of users (maybe users that you followed with the bot based on a keyword?). Tweepy offers a handy function for this.
API.create_list(name[,** mode][, description])


Sdba add loess

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[x] Tests for the changes have been added (for bug fixes / features)
[x] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
This add the xclim.sdba.loess submodule and the xclim.sdba.detrending.LoessDetrend object to perform LOESS smoothing and use is in detrending. I based the implementation on Cleveland (1979) and matlab code from P Grenier.

The LOESS smoothing has the advantage that its stays within the limits of the data itself. In opposition to polynomial regression, a LOESS-detrended precipitation timeseries will never be negative, for example. However, it has really strong border effects and should always be used with extra data on the sides. The size of the "local" window is controlled by parameter f ( a kind of percentage of the total domain) and the outermost f * N points should always be considered with suspicion.  (N is the total number of elements in the smoothed array).
I'm not sure xclim is the best place for such a general smoothing procedure, but it doesn't exist in scipy or numpy... And I didn't want to add a under-maintained dependency. So here we are.

Does this PR introduce a breaking change?
No

Other information:
This might interest @RondeauG,

Pull Request Test Coverage Report for Build 2123

30 of 63 (47.62%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 90.357%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

xclim/sdba/detrending.py
14
15
93.33%

xclim/sdba/loess.py
16
48
33.33%

Totals

Change from base Build 2118:
-0.7%

Covered Lines:
3186

Relevant Lines:
3526

💛  - Coveralls

@huard I pushed the new notebook directly in this PR since it is not going to be merged very soon.

In the notebook, you say "As it can already be seen in this small example, LOESS smoothing suffers from heavy boundary effects.", but it's not clear what you are referring to. The fit in black looks good in the figure.

Tried to use axvspan to identify the domain that should be discarded in the last graphic, but I get an error from matplotlib.

@huard  I have modified the notebook to better explain this. Sadly, the axvspan bug comes from  nc-time-axis. (See SciTools/nc-time-axis#47).

This is good to go for me.


PR: Url awareness improvements

Description of Changes

[x] Wrote at least one-line docstrings (for any new functions)
[x] Added unit test(s) covering the changes (if testable)

[x] Make URLs work with %20.
[x] Remove the requirement of mailto:
[ ] Make {gh/bb/gl}-123 work.

Issue(s) Resolved

Fixes #9513
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

Hello @goanpeca! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/utils/syntaxhighlighters.py:

Line 52:80: E501 line too long (80 > 79 characters)

@rgommers for the shorthand notation
gh-123 this will only work if we are cloning from the actual repo and not from the fork (like many projects follow)
So I can ask git for this
$ git config --get remote.origin.url
And use the output to get the repo, but if the repo is a fork we may or may not have the upstream remote set. Thoughts no this?

Oh yeah, having to check for the parent repo via the GitHub API would work but that's a weird design. The standard convention is that the parent is named upstream, but it's not always the case. I think the choice is between using upstream if it exists, or just forgetting about this.

The standard convention is that the parent is named upstream, but it's not always the case. I think the choice is between using upstream if it exists, or just forgetting about this.

I agree with this. Let's try to detect upstream using git locally and then use it for as the main URL for all {gh/bb/gl}-123 kind of references.

The following dialog is displayed if gh-123 is clicked on a file that is not being tracked by git or if there is no upstream, or no origin

The following dialog is displayed if gh-123 is clicked on a file that is not being tracked by git or if there is no upstream, or no origin

I agree with ti, thanks for adding it.


Help upgrading the linter

PR #5966 tries to upgrade the linter, but runs into many new lint issues that need to be fixed before upgrade can be merged. Most of them are about signed/unsigned conversions, which we generally force-ignore.
Success criteria: gh pr checkout 5966 and make lint

@yurishkuro please assign it me . i can do it .

git push origin dependabot/go_modules/internal/tools/github.com/golangci/golangci-lint-1.61.0
remote: Permission to jaegertracing/jaeger.git denied to anishbista60.

Create a new branch and push as a new PR.


[feature/no-ref/separate-rvo2] Fix presubmit failing due to fail-fast

Currently unreproducible. Latest presubmit run passes with no change to script.


Add permission STREAM to Permission enum.

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[ ] I have read the contributing guidelines

Changes

[x] Library interface (affecting end-user code)
[x] Documentation

Closes Issue: NaN
Description
This is mentioned in discordapp/discord-api-docs#918. Permissions#STREAM is for Discord's guild video feature.
Previously, there was no permission set to 9.
I considered adding it to ALL_VOICE_PERMISSIONS but it didn't seem right.

ah! I had a feeling something was wrong. thanks for letting me know

Theres a reason that reading the contribution guidelines is in the checklist for PRs

(guess I didn't search hard enough for any pr or commit, sorry about that)


What is the point of this project?

What is the point of this project? It's a waste of emotions. Absolutely nothing, it's worse than trashy advertising

Thank you for your interesting and question.
This project is a simple demo to demonstrate our IP Core Product on any your own FPGA boards.
You may request for free evaluation license of our IP Core, please contact us dgway.com/contact.html.
https://youtu.be/FEoKKayIkJI


turn on checks for unlocalized elements

Skyline: re-running my automation to update from our old homebrewed "// Not L10N" localization inspection to standard ReSharper inspections. This first commit is just turning on the inspection as warning, to make sure TC is catching unlocalized elements.

It was meant to only go after files containing "// Not L10N" comments. I'll
back out any changes in those areas.
On Fri, Aug 31, 2018 at 12:25 PM, Matt Chambers<EMAIL_ADDRESS>wrote:

Presumably this PR should not be touching anything outside
pwiz_tools/Shared and pwiz_tools/Skyline? If so, it seems to have affected
pwiz_tools/Bumbershoot and pwiz_tools/BiblioSpec accidentally.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/190#issuecomment-417766362,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJSebvWHjtK2CTqY773LGd48EpBXEioks5uWY2PgaJpZM4WUSb4
.

The only surprise I'm finding is in Bumbershoot, where there was a lone "//
Not L10N" comment that got the treatment. I'll back that one out.
The changes in pwiz_tools/Shared/BiblioSpec are intentional (no changes in
pwiz_tools/BiblioSpec -  we don't attempt L10N there).
Thanks for the review!
On Tue, Sep 4, 2018 at 7:40 AM, Brian Pratt<EMAIL_ADDRESS>wrote:

It was meant to only go after files containing "// Not L10N" comments.
I'll back out any changes in those areas.
On Fri, Aug 31, 2018 at 12:25 PM, Matt Chambers<EMAIL_ADDRESS>wrote:

Presumably this PR should not be touching anything outside
pwiz_tools/Shared and pwiz_tools/Skyline? If so, it seems to have affected
pwiz_tools/Bumbershoot and pwiz_tools/BiblioSpec accidentally.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/190#issuecomment-417766362,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJSebvWHjtK2CTqY773LGd48EpBXEioks5uWY2PgaJpZM4WUSb4
.

Pretty sure the entire pwiz_tools\Skyline\Executables\LocalizationHelper project goes away.


Fix OSAL build when using RTEMS "pc686" BSP

In the RTEMS distribution, the rtems_interrupt_catch() function is not always defined.  It depends on the BSP build-time options, specifically if the macro "CPU_SIMPLE_VECTORED_INTERRUPTS" is defined set to FALSE then the API call is not available.
This causes a link error when building with the "pc686" BSP since OS_IntAttachHandler() calls rtems_interrupt_catch().
This ticket will simply add a preprocessor check for the above condition, and if rtems_interrupt_catch() is not available then OS_IntAttachHandler() should return OS_ERR_NOT_IMPLEMENTED.

Imported from trac issue 19.  Created by jphickey on 2015-02-17T13:51:26, last modified: 2015-11-20T16:22:16

Trac comment by jphickey on 2015-04-14 11:32:19:
This commit has been rebased to the current development branch (2015-02-26 OSAL update)
The rebased commit is [changeset:39e2465]

Trac comment by jphickey on 2015-02-17 14:06:00:
Commit [changeset:ef374d0] pushed to branch "trac-19-rtems_interrupt_catch"
Note this also adds in a "build_options.cmake" file (a new file) to the RTEMS directory to set a few required parameters for building using the CMake scripts.

Trac comment by sstrege on 2015-05-15 17:26:20:
approve commit

Trac comment by sduran on 2015-06-01 11:49:30:
approve

Trac comment by glimes on 2015-07-02 12:44:11:
Commit [changeset:39e2465] is now included in the OSAL "development" branch
as of the [changeset:2c9c345] merge.

Trac comment by acudmore on 2015-06-01 14:10:59:
approve commit


Create a PlayCookieStore

based on the Play native session (in a cookie).

The Play session cookie is only signed, not encrypted. So data can not be tampered, be read. This might not be a suitable solution if we don't use an encryption layer in addition to the signature.

What if you put a signed and encrypted token inside the Play session cookie as a value?
If you did it that way, couldn't you just wrap a JwtGenerator and use this method?
Of course you'd have to decrypt it from there, but that shouldn't be too difficult, right?

I have always been reluctant to have clear data in the Play cookie, but using JWT is a good idea.
We should clear the profile from the sensitive data (for size and security): https://github.com/pac4j/pac4j/blob/master/pac4j-core/src/main/java/org/pac4j/core/profile/UserProfile.java#L329 and then, encrypt it with the JwtGenerator and decrypt it using the JwtAuthenticator.

Yes. Go ahead


Camera indicator light is ON unless BackgroundEffectProcessor#destroy is called

I created a new BackgroundEffectProcessor and it uses my camera's MediaStreamTrack as the input stream. When I call publisher.publishVideo(false) the camera indicator light is still ON. Calling mediaStreamTrack.enabled = false and mediaStreamTrack.stop() won't turn the light OFF.
I had to call backgroundEffectProcessor.destroy() to make the camera indicator light go OFF. Also, I had to use publisher.destroy() to make the browser tab right dot (screen recording) go away.
Thank you for your help.
Brower: Chrome  102.0.5005.61
OS: Mac OS 12.4
SDK: OpenTok.js 2.22.5 + video-api-effects 1.0.0-rc3

Hi @brian17han, we are aware of this limitation. Unfortunately the issue is not with the library itself but with Opentok JS SDK because if you specify a videoSource:MediaTrack, the publishVideo(false) function will not close the stream.
As for now, the only solution is to destroy the processor.

This library is gonna be deprecated soon - Opentok JS now fully supports BBlur https://tokbox.com/developer/sdks/js/reference/Publisher.html#applyVideoFilter

Oh, that’s unfortunate. Will they support virtual background soon? Thanks.

@brian17han yes they will :)


data type codecs

investigate whether encoding/decoding of types could be stored into rio files
assuming the proposal for Go plugins API goes in, it would be possible to dynamically load code. => just write the package name ?
fwd/bwd compat of types. write the AST or some serialized version of the data type for versionning (instead of just the package name + data type name) (AKA, schema evolution)

This issue was moved to go-hep/hep#2

This issue was moved to go-hep/hep#3


Adding BIDS support

Extension of LocalRepository
Specify which kwargs need to be specified for each Study field. Those could be passed to pybids queries. Alternatively use a function pointer with BIDSLayout argument passed for more complex queries (think fieldmaps).

More on pybids: https://github.com/INCF/pybids/tree/master/bids/grabbids

BIDS support has been added to MonashBI/banana now instead

Awesome!


Zhinst-qcodes no longer marked as type checked with zhinst-core 23.10.49450

With the new release of zhinst-core zhinst-qcodes is no longer marked as type checked. This causes type checking failures when running type checking on qcodes (of the aliases shipped in qcodes.instrument_drivers.zhinst)
Normally typechecking is marked by shipping a py.typed file. I guess that zhinst-core used to ship that file at the toplevel module but no longer does. An alternative fix could be for zhinst-qcodes to ship the file at its toplevel module
The failures that we observe are.
pyright 1.1.332, node v[20](https://github.com/QCoDeS/Qcodes/actions/runs/6704453962/job/18255153080#step:7:21).8.1, pyright-action 1.7.1
/home/runner/runners/2.311.0/externals/node20/bin/node /opt/hostedtoolcache/pyright/1.1.332/x64/package/index.js --outputjson
/home/runner/work/Qcodes/Qcodes/src/qcodes/instrument_drivers/zurich_instruments/hdawg.py:8:10 - error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
Error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
/home/runner/work/Qcodes/Qcodes/src/qcodes/instrument_drivers/zurich_instruments/hf2.py:8:10 - error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
Error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
/home/runner/work/Qcodes/Qcodes/src/qcodes/instrument_drivers/zurich_instruments/mfli.py:8:10 - error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
Error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
/home/runner/work/Qcodes/Qcodes/src/qcodes/instrument_drivers/zurich_instruments/pqsc.py:8:10 - error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
Error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
/home/runner/work/Qcodes/Qcodes/src/qcodes/instrument_drivers/zurich_instruments/shfqa.py:8:10 - error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
Error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
/home/runner/work/Qcodes/Qcodes/src/qcodes/instrument_drivers/zurich_instruments/shfsg.py:8:10 - error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
Error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
/home/runner/work/Qcodes/Qcodes/src/qcodes/instrument_drivers/zurich_instruments/uhfli.py:8:10 - error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
Error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
/home/runner/work/Qcodes/Qcodes/src/qcodes/instrument_drivers/zurich_instruments/uhfqa.py:8:10 - error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
Error: Stub file not found for "zhinst.qcodes" (reportMissingTypeStubs)
8 errors, 0 warnings, 0 informations
Error: 8 errors

See an example here https://github.com/QCoDeS/Qcodes/pull/5477 where the version of zhinst-core is bumped causing typechecking that was passing to fail

Thank you for the issue. That is indeed true, the issue will be addressed.

@markheik Thanks, rerunning https://github.com/QCoDeS/Qcodes/pull/5477 with that version it looks like the issue is resolved


Add link to logging drivers reference

fixes https://github.com/docker/docker/issues/14711

ping @vdemeester @LK4D4 PTAL

author LGTM


Infinite loop when non-existent drive specified in directory parameter

This seems to be an issue with the mkdirp package (see https://github.com/substack/node-mkdirp/issues/66 and https://github.com/substack/node-mkdirp/issues/70). We'll need to do some validation before calling mkdirp.

Added code to ensure root path exists before attempting to create a directory recursively (see https://github.com/manifoldjs/ManifoldJS/commit/d2326076ed26527a52452cc5da9d6bd2b8d6d559).


[DevPortal/Error] SDK generation options available for Web socket APIs

In a published web-socket API user is shown the option to generate a SDK which is not possible due to there is no swagger definition is available.Following error logs in the console.

This is fixed with the pr: https://github.com/wso2/carbon-apimgt/pull/7282


Fix a race in adding references

- What I did
Fixed a race when two coroutines independently try to add the same digest reference.
- How I did it
See the commit message.
- How to verify it
On a trivial level, using the modified unit tests. Beyond that, whatever is the usual standard, I guess.
It should be in principle possible to make an actual reproducer by concurrently issuing many pull and/or push API requests for the same image (same manifest digest); I haven’t even attempted that so far. The race window is a few lines of Go code in an operation which involves remote HTTP requests, so it might require quite a few concurrent attempts.
- Description for the changelog
Fixes a race possibly causing one of several concurrent push/pull operations with the same remote image fail with “Cannot overwrite digest …”.

Upstream PR: https://github.com/moby/moby/pull/37781 .

LGTM, let's just hear from upstream as well before letting this in


Change /lib to /src

/src is a more standard place to keep code

I have seen /src often in web front-end projects, but in libraries I found it more often being in /lib. Do you have a different experience?

/src is the convention we use at my office. When we do have a /lib directory, it's always transpiled into /src for production.


Feature/issue 922 add cash ui to new upstream

Add CashUI package
Start Core Session Manager
Add hooks to redeem flow
Adding extension to disable UI while redeem send.
Adding last bits of redeem flow.
Add XIBs for cashUI
Add app icons
Expose currency getter based on currencyID from CoreSystem
Add presentModal completion blocked removed by upstream
Rename BRD MenuViewController to avoid conflicts with CashUI. Needs revising as CashUI does not have a class named MenuViewController anymore
Add code for buy/trade removed by accident from our code base. This prevents future conflicts

Good job!


Error API since frebrery 12

Since February 12, the application has given me an error when requesting a change.  the error: API manager object has not attribute protom_response.
Is it my problem or has something changed in securitas direct?
Thanks for your time.

I'm getting the same error. I'm not 100% sure but I think it might have started when I upgraded to 2024.2.2 I'll try and backout that upgrade when i get some time

Probably this error is the same of #205 , and was introduced in version 2.7.1. 0 . Downgrading to version <IP_ADDRESS> is the current solution to it.

I use 2024.1.3 and hace the problem. Isn't the HA version.  I thing is a problem with securitas direct API.Enviado desde mi Galaxy
-------- Mensaje original --------De: pauljwhelan @.> Fecha: 19/2/24  23:42  (GMT+01:00) Para: guerrerotook/securitas-direct-new-api @.> Cc: JaVier-Lloret @.>, Author @.> Asunto: Re: [guerrerotook/securitas-direct-new-api] Error API since frebrery 12 (Issue #208)
I'm getting the same error. I'm not 100% sure but I think it might have started when I upgraded to 2024.2.2 I'll try and backout that upgrade when i get some time
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Thanks for the heads up. I'll go back to <IP_ADDRESS>

Working again for me after downgrading. Thanks.


[Bug]Evaluated value is 'undefined' on entering item spacing in numbers

Description
Release Environment - List Widget
It is observed that when the user enters item spacing in numbers for example 150, 100 the evaluated is displayed as undefined
Expected Result:
Evaluated value needs to match the value entered in the Item spacing field
Actual Result:
Evaluated value is displayed as undefined
Steps to reproduce the behaviour:

Launch Appsmith app in the release environment
Drag and Drop List widget
Click edit on the list widget
Enter values in the item spacing field and observe the evaluated value

Important Details

Version: [Safari - 14.1 (166<IP_ADDRESS>.3), Chrome - 90.0.4430.93]
OS: [macOS Big Sur 11.3]
Browser [Chrome, Safari]

Fixed in #4247

@YogeshJayaseelan the fix for this up on release.

@YogeshJayaseelan confirmed that this works as expected


Client and SCCM Server in different domain

Our Administration Client is in a different Domain than the SCCM Server. So we are unable to connect to the Server by using Right-Click-Tool.
Please add Feature to define DNS Suffix for the SCCM Server in config file.
Issue is in "Program.cs" (line 175):
string sScope = sPath.Split(':')[0]+"add SCCM Server DNS Suffix";

In the .config File there is a 'FQDN' Property which can be used to append a fixed DNS Domain...
If you start the tool with a right click on a collection in ConfigMgr, you should get the FQDN of the computers automatically !

I can see that the FQDN is used for the tool to connect to the clients. But I have a different issue.
My Management Station is in a different domain than the SCCM Server. When Right-Click on SCCM Management Console you pass the "##SUB:__PATH## where the server name is not fully qualified. So CMCollCtr can't connect to the SCCM Server and fails during startup with an RPC Error.
I have the fix already implemented and wanted to create a pull request for you but don't have permission for this. Basically the line 175 in Programs.cs need to be changed from
string sScope = sPath.Split(':')[0]
to
string sScope = sPath.Replace(sPath.Split('\\')[2], sPath.Split('\\')[2] + Properties.Settings.Default.ServerDNSSuffix);
where "ServerDNSSuffix" is a setting I added.

got it now…

Another solution could also be to add a CNAME entry in DNS Server of client domain. Just another option.


[Feature Request]  A new component for feature section

Is your feature request related to a problem? Please describe.
The problem is that standard feature sections on websites tend to be static and take up a lot of space. This layout is not visually engaging and can clutter the webpage, especially when displaying multiple features. My suggestion is to add a slider component for the feature section. This slider will allow users to showcase multiple features without taking up much space, while also making the design more interactive and attractive. I've created my own feature section component, where users can add several features and display them in a slider format that catches attention more effectively than traditional layouts.
Describe the solution you'd like
I would like to introduce a new slider-based feature component to the NextUI library. The solution involves creating a horizontally scrollable slider that can display feature highlights in a compact yet visually engaging manner.
Describe alternatives you've considered
Carousel Component: Use a traditional carousel to display features with sliding transitions.
Grid Layout with Hover Effects: Arrange features in a static grid layout with subtle hover effects. This is ideal for users who prefer a clean, no-animation display where information is instantly available.
Vertical Scrolling List: Implement a vertically scrolling list, where each feature automatically scrolls into view. This approach saves horizontal space and works well with longer feature lists.
Card Flip Effect: Make the features more interactive by adding a card flip animation. When a user hovers or clicks on a card, it flips to reveal more detailed information about the feature.
Screenshots or Videos
https://github.com/user-attachments/assets/a074c4fb-f7f8-4491-925a-705ec7bacb4f

we can use marquee from magicui and create it
assign this to me and i'll work it out
thanks

@Dheerajjha451


gaps_out needs window refresh when set from a script

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit ea3fd13e24d7d3a74cf803bef3e6133b5d708d1b  ().
Date: 2024-02-21
Tag:

flags: (if any)

System Information:
System name: Linux
Node name: tower
Release: 6.1.78
Version: #1-NixOS SMP PREEMPT_DYNAMIC Fri Feb 16 18:06:32 UTC 2024

GPU information:
0a:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 21 [Radeon RX 6800/6800 XT / 6900 XT] [1002:73bf] (rev c3) (prog-if 00 [VGA controller])

os-release: ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20240221.0e74ca9"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"

plugins:

Bug or Regression?
Bug
Description
When running the command hyprctl keyword general:gaps_out 15 from inside a script or a tmux session the window needs currently displayed windows need to refresh to respect the new setting.
The refresh can be achieved through:

changing workspaces
resizing the window
using movewindow

When runnning from inside a normal terminal it works.
How to reproduce
Run the command hyprctl keyword general:gaps_out 15 from a script or inside a tmux session.
Crash reports, logs, images, videos
No response

hyprctl -r keyword general:gaps_out 15?

hyprctl -r keyword general:gaps_out 15?
Also I believe e9528fc fixed this.

Ah yes that on the latest commit this works even without -r. Thanks :)


Export to Geoblacklight

Have an endpoint that export the item into geoblacklight schema

See https://github.com/geoblacklight/geoblacklight-schema/issues/80

As I currently understand the GeoBlacklight schema and this issue, the ActiveFedora ID for the FileSet or Image/Raster/VectorWork must map to the Solr field "uuid".
Unfortunately, I receive the following error when I attempt to implement a solution for this:
Error: {'responseHeader'=>{'status'=>400,'QTime'=>2},'error'=>{'msg'=>'ERROR: [doc=ws859f68w] unknown field \'uuid\'','code'=>400}}

(Please see the latest [WIP] commit)
My suspicion is that Solrizer uses dynamic fields in order to avoid hard-coding fields generated for indexed ActiveFedora properties (explaining why one finds field names such as "dct_references_s" rather than simply "dct_references", as a common pattern for dynamic fields would be "*_s" for single valued strings).  Because GeoBlacklight requires "uuid" rather than "uuid_s", I can only propose that we proceed by offering an alternative/extended Solr schema.
I will further investigate this and report my findings.  Please let me know if any of my suspicions rest upon some misunderstanding of Solrizer, the GeoBlacklight schema, or ActiveFedora.

Note that the GeoBlacklight schema went 1.0. See the wiki for details: https://github.com/geoblacklight/geoblacklight/wiki/Schema

Pending #170

See https://github.com/projecthydra-labs/geo_concerns/blob/master/app/services/geo_concerns/discovery/geoblacklight_document.rb

I have a branch going, but I have a question. How do I make an attribute a single valued attribute? Right now, provenance is an Array, but I cannot find where it thinks that from.
https://github.com/projecthydra-labs/geo_concerns/blob/70-geoblacklight-schema-v1/app/models/concerns/geo_concerns/solr_document_behavior.rb#L22
https://github.com/projecthydra-labs/geo_concerns/blob/8d34965f738a82590897d453d41a599a02022ff1/app/schemas/geo_concerns/basic_geo_metadata_required.rb#L23

I'm not sure why, but it looks like you have to do some custom indexing to get that to happen. As it stands, the UI only allows one provenance value. Don't think we need to reinvent the wheel here.
https://github.com/projecthydra/curation_concerns/blob/master/app/indexers/curation_concerns/collection_indexer.rb#L12

Also related is issue #169. I think we might want to use a configurable institution name here to generate the geoblacklight docs instead of provenance. We may not need that property at all.

there's also that new :depositor attribute, but I dunno how it's used in cc.

I don't understand the link to the collection_indexer.rb. Can you clarify?

@drh I got confused there. That is not the droid you are looking for.

@johnhuck The :depositor attr looks like it is auto-populated with the username of the person creating the work. I think this is to support sufia/ir applications.

👍  makes sense.


Fix all fragments not loading when one is badly formed

Adds try-catch blocks to the parts where we layer a fragment onto a profile and create a new profile from a fragment. This allows us to continue looping over the remaining fragments after failing to use a badly-formed one, instead of aborting prematurely.


add readme content

manual

what is supported and what is not supported

Community Note

Please vote on this issue by adding a 👍 reaction
to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do
not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

References

#0000

manual:
a) how to compile
b) how to generate ChangeLog
c) how to run update command


create-react-redux-app-structure command gives error

child_process.js:383
throw new TypeError('"file" argument must be a non-empty string');
^
TypeError: "file" argument must be a non-empty string
at normalizeSpawnArguments (child_process.js:383:11)
at exports.spawn (child_process.js:496:38)
at Object. (/usr/local/lib/node_modules/create-react-redux-app-structure/cli/cli.js:15:5)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Function.Module.runMain (module.js:693:10)
at startup (bootstrap_node.js:191:16)
Steps to reproduce-
Just install the library in MacOS High Sierra (10.13.4 (17E202)).
Hit command "create-react-redux-app-structure my-app"
there you go. error.

Hi @saaksshi ,
Thank you for beeing interested in this project :)
To be short, this is one of npm package error and it is not blocked app for beeing created. So, you can work with app as well.
This arror is going to be fixed.
Please find more details here https://github.com/shystruk/create-react-redux-app-structure/issues/10

node --version
v8.11.2
npm --v
5.6.0
yarn --version
1.7.0
Let me kn ow if you need anything else

********************$ create-react-redux-app-structure test-app
Welcome to Create React Redux App Structure
Installing Packages
child_process.js:383
throw new TypeError('"file" argument must be a non-empty string');
^
TypeError: "file" argument must be a non-empty string
at normalizeSpawnArguments (child_process.js:383:11)
at exports.spawn (child_process.js:496:38)
at Object. (/usr/local/lib/node_modules/create-react-redux-app-structure/cli/cli.js:15:5)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Function.Module.runMain (module.js:693:10)
at startup (bootstrap_node.js:191:16)
yarn install v1.7.0
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has incorrect peer dependency "webpack@2 || 3".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[4/4] 📃  Building fresh packages...
success Saved lockfile.
✨  Done in 79.41s.
gets stuck here every time.
have to force quit (^c) and then doesn't work.

Check if my-app folder was created. If yes, go inside and do commands from
a list in Readme. If not, you can clone or download the repo.
On Tue, May 29, 2018, 10:36 Saaksshi Tyagi<EMAIL_ADDRESS>wrote:

********************$ create-react-redux-app-structure test-app Welcome
to Create React Redux App Structure Installing Packages
child_process.js:383
throw new TypeError('"file" argument must be a non-empty string');
^
TypeError: "file" argument must be a non-empty string
at normalizeSpawnArguments (child_process.js:383:11)
at exports.spawn (child_process.js:496:38)
at Object.
(/usr/local/lib/node_modules/create-react-redux-app-structure/cli/cli.js:15:5)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Function.Module.runMain (module.js:693:10)
at startup (bootstrap_node.js:191:16)
yarn install v1.7.0
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency "prop-types@
^15.5.4".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency "webpack@2
|| 3".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency
<EMAIL_ADDRESS>[4/4] 📃 Building fresh packages...
success Saved lockfile.
✨ Done in 79.41s.
gets stuck here every time.
have to force quit (^c) and then doesn't work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shystruk/create-react-redux-app-structure/issues/19#issuecomment-392681410,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFuLt2KUPOZiaVDbE66NGJ8eXIj8u0LRks5t3Pp8gaJpZM4UQ6ED
.

ok thanks :)
On Tue, May 29, 2018 at 1:23 PM, Vasyl Stokolosa<EMAIL_ADDRESS>wrote:

Check if my-app folder was created. If yes, go inside and do commands from
a list in Readme. If not, you can clone or download the repo.
On Tue, May 29, 2018, 10:36 Saaksshi Tyagi<EMAIL_ADDRESS>wrote:

********************$ create-react-redux-app-structure test-app Welcome
to Create React Redux App Structure Installing Packages
child_process.js:383
throw new TypeError('"file" argument must be a non-empty string');
^
TypeError: "file" argument must be a non-empty string
at normalizeSpawnArguments (child_process.js:383:11)
at exports.spawn (child_process.js:496:38)
at Object.
(/usr/local/lib/node_modules/create-react-redux-app-
structure/cli/cli.js:15:5)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Function.Module.runMain (module.js:693:10)
at startup (bootstrap_node.js:191:16)
yarn install v1.7.0
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency "prop-types@
^15.5.4".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency "webpack@2
|| 3".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency
<EMAIL_ADDRESS>[4/4] 📃 Building fresh packages...
success Saved lockfile.
✨ Done in 79.41s.
gets stuck here every time.
have to force quit (^c) and then doesn't work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/shystruk/create-react-redux-app-structure/issues/19#
issuecomment-392681410>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AFuLt2KUPOZiaVDbE66NGJ8eXIj8u0LRks5t3Pp8gaJpZM4UQ6ED>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shystruk/create-react-redux-app-structure/issues/19#issuecomment-392685616,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI1oP-ZCtvQeMNvACRnjNxlNhq9jxxViks5t3P5ngaJpZM4UQ6ED
.

--
Cheers,
Saaksshi

Even running npm run fast-start giving error:
D:\Desktop\working_copy_frontend_temp_card\my-app>npm run fast-start

<EMAIL_ADDRESS>fast-start D:\Desktop\working_copy_fron
tend_temp_card\my-app
yarn install && webpack --mode=development && gulp prod && run-p server open-l
ocalhost

yarn install v1.7.0
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/term-size/-/te
rm-size-1.2.0.tgz: EPERM: operation not permitted, open 'C:\Users\Bikram M\Ap
pData\Local\Yarn\Cache\v1\npm-term-size-1.2.0-458b83887f288fc56d6fffbfad262
e26638efa69\vendor\windows\term-size.exe'".
info If you think this is a bug, please open a bug report with the information p
rovided in "D:\Desktop\working_copy_frontend_temp_card\my-app\yarn-error.log
".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this
command.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>fast-start: yarn install && web pack --mode=development && gulp prod && run-p server open-localhost
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>fast-start script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.
npm ERR!      C:\Users\Bikram M\AppData\Roaming\npm-cache_logs\2018-07-25T05_35_
11_490Z-debug.log
D:\Desktop\working_copy_frontend_temp_card\my-app>

@bikram1889 something strange happened with readonly permissions to your node_modules folder. You can try to remove node_modules folder and install packages again or go to file manager, right click on /node_modules main folder, selecting properties, and check-uncheck "read-only".
For more details please check this - https://github.com/yarnpkg/yarn/issues/992


feat(BUX-720) additional linters

Pull Request Checklist

[x] 📖 I created my PR using provided  : CODE_STANDARDS
[x] 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
[x] 🏠 I tested my changes locally.
[ ] ✅ I have provided tests for my changes.
[x] 📝 I have used conventional commits.
[ ] 📗 I have updated any related documentation.
[x] 💾 PR was issued based on the Github or Jira issue.

Codecov Report
Attention: Patch coverage is 40.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 53.14%. Comparing base (18ab5b2) to head (9e6358e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   53.17%   53.14%   -0.03%
==========================================
  Files         194      194
  Lines       10896    10913      +17
==========================================
+ Hits         5794     5800       +6
- Misses       4553     4563      +10
- Partials      549      550       +1

Flag
Coverage Δ

unittests
53.14% <40.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

config/validate_authentication.go
100.00% <100.00%> (ø)

config/validate_paymail.go
87.50% <100.00%> (+0.83%)
:arrow_up:

config/flags.go
42.10% <0.00%> (-1.14%)
:arrow_down:

config/load.go
59.32% <0.00%> (-1.03%)
:arrow_down:

config/services.go
43.64% <0.00%> (-0.38%)
:arrow_down:

config/validate_server.go
63.15% <40.00%> (-10.18%)
:arrow_down:

server/server.go
42.00% <0.00%> (-1.75%)
:arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ab5b2...9e6358e. Read the comment docs.


Fix double do_io_close in HttpTunnel::chain_abort_all()

A state machine can not access the VConnectuion or any returned
VIOs after calling do_io_close().
The TVC maybe already destroyed while the 2nd close on TransformVC,
this bug may cause TransformVC crash.

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/375/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/363/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/488/

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/359/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1950/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/621/

Cherry picked to 7.1.x, thanks Oknet!

Do we want to revert this again, or try to fix it?

@zwoop please revert the PR from 7.1.x and master.
The "double do_io_close()" bug stills here and can not be resolved in chain_about_all().
Since the vc->alive == false is not means the vc was closed already.

@zwoop  Can I consider the Http1ClientSession::do_io_close() has the same requirement as VConnection::do_io_close() ?
"Likeswise, the state machine must not access the VConnection or any VIOs obtained from it after calling this method."
source: I_VConnection.h
252   /**
253     Indicate that the VConnection is no longer needed.
254
255     Once the state machine has finished using this VConnection, it
256     must call this function to indicate that the VConnection can
257     be deallocated.  After a close has been called, the VConnection
258     and underlying processor must not send any more events related
259     to this VConnection to the state machine. Likeswise, the state
260     machine must not access the VConnection or any VIOs obtained
261     from it after calling this method.
262
263     @param lerrno indicates where a close is a normal close or an
264       abort. The difference between a normal close and an abort
265       depends on the underlying type of the VConnection.
266
267   */
268   virtual void do_io_close(int lerrno = -1) = 0;

There are some mistaken in HttpTunnel,
HttpTunnel::chain_abort_all(HttpTunnelProducer *p)
1453 void
1454 HttpTunnel::chain_abort_all(HttpTunnelProducer *p)
1455 {
1456   HttpTunnelConsumer *c = p->consumer_list.head;
1457
1458   while (c) {
1459     if (c->alive) {
1460       c->alive     = false;
1461       c->write_vio = nullptr;
1462       c->vc->do_io_close(EHTTP_ERROR);   // -------> do_io_close() but did not set c->vc = nullptr
1463       update_stats_after_abort(c->vc_type);
1464     }
....
1486     p->read_vio = nullptr;
1487     p->vc->do_io_close(EHTTP_ERROR);   // -------> do_io_close() but did not set p->vc = nullptr
1488     update_stats_after_abort(p->vc_type);
1489   }
1490 }

HttpTunnel::close_vc(HttpTunnelProducer *p) and HttpTunnel::close_vc(HttpTunnelConsumer *c)
1587 void
1588 HttpTunnel::close_vc(HttpTunnelProducer *p)
1589 {
1590   ink_assert(p->alive == false);
1591   HttpTunnelConsumer *c = p->self_consumer;
1592
1593   if (c && c->alive) {
1594     c->alive = false;
1595     if (c->write_vio) {
1596       c->bytes_written = c->write_vio->ndone;
1597     }
1598   }
1599
1600   p->vc->do_io_close();   // -------> do_io_close() but did not set p->vc = nullptr,  p->bytes_read = p->read_vio->ndone;
1601 }

I'm not sure to be honest, this is not really my area of expertise :-/. How do we want to proceed with this? The 7.1.x branch is not usable as it is now, so we have to do something (it crashes every 10 minutes on Docs / CI).

please revert this commit.
The double do_io_close bug still here and  can not be fixed easily.
I will show you a new patch to test on docs before push a PR.
Oknet xu
发自我的 iPhone

在 2017年5月8日，23:27，Leif Hedstrom<EMAIL_ADDRESS>写道：
I'm not sure to be honest, this is not really my area of expertise :-/. How do we want to proceed with this? The 7.1.x branch is not usable as it is now, so we have to do something (it crashes every 10 minutes on Docs / CI).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.


Zoom slider is not working for numerical columns with specific data distribution

Preconditions:
Open a table with column having specific distribution of values.
Some examples:

Files > demo_files > smiles.csv > FractionCSP3 column
Calculated column with sigmoid-like function: open SPGI, create a calculated column with following formula:
if(${Average Mass} == null, 0.00001,1/(1+Exp(-0.01*(${Average Mass}-680))))

Steps to reproduce:

Add a scatter plot
Set up a column prepared earlier as one of the axes
Try to use zoom slider for this column

Expected results: Scatter plot can be zoomed using the slider.
Actual results: Nothing happens on attempt to use zoom slider.
Issue can be reproduced in v1.8.2, it first appeared in 1.6.13 or earlier.

Fixed in v1.8.3


OIBIT behaviour with primitives (specifically references) doesn't seem perfected

#![feature(optin_builtin_traits)]

trait NoImpl {}
impl NoImpl for .. {}
fn test_no_impl<T: NoImpl>() {}

trait ConcreteImpl {}
impl ConcreteImpl for .. {}
fn test_concrete_impl<T: ConcreteImpl>() {}

impl<'a> ConcreteImpl for &'a i16 {}

trait GenericImpl {}
impl GenericImpl for .. {}
fn test_generic_impl<T: GenericImpl>() {}

trait Bound {}
impl<'a, T: Bound> GenericImpl for &'a T {}

fn main() {
    test_no_impl::<&u8>();
    test_concrete_impl::<&u8>();
    test_generic_impl::<&u8>();
}

Fails to compile with:
<anon>:23:5: 23:29 error: the trait `Bound` is not implemented for the type `u8` [E0277]
<anon>:23     test_generic_impl::<&u8>();
              ^~~~~~~~~~~~~~~~~~~~~~~~

In particular, adding a generic impl of a trait has effectively removed other implementations (i.e. comparing against the behaviour when that impl wasn't there). It seems like this behaviour is somewhat idiosyncratic, and may want to be fine tuned.
The RFC doesn't seem to discuss references (or even primitives) at all, so I'm unsure if this has been thought about much.
(NB. the safety of Send and Sync is actually relying on this behaviour at the moment, so changes to this may have to change how the impls are arranged in core. Although I would prefer a solution that doesn't require changing them, as that will be making safety the default.)
cc @rust-lang/lang

This is indeed the expected behavior -- whether it's the best behavior
is unclear, but we made the .. basically a "fallback" for use only
when no other impls can be matched (in particular, we don't fully
evaluate the where clauses before making this distinction). We should
be able to change this backwards compatibly though, I believe, as it
would make impls more applicable (and the coherence changes we made
SHOULD make that OK).
On Sun, May 24, 2015 at 05:40:45AM -0700, Huon Wilson wrote:

#![feature(optin_builtin_traits)]

trait NoImpl {}
impl NoImpl for .. {}
fn test_no_impl<T: NoImpl>() {}

trait ConcreteImpl {}
impl ConcreteImpl for .. {}
fn test_concrete_impl<T: ConcreteImpl>() {}

impl<'a> ConcreteImpl for &'a i16 {}

trait GenericImpl {}
impl GenericImpl for .. {}
fn test_generic_impl<T: GenericImpl>() {}

trait Bound {}
impl<'a, T: Bound> GenericImpl for &'a T {}

fn main() {
    test_no_impl::<&u8>();
    test_concrete_impl::<&u8>();
    test_generic_impl::<&u8>();
}

Fails to compile with:
<anon>:23:5: 23:29 error: the trait `Bound` is not implemented for the type `u8` [E0277]
<anon>:23     test_generic_impl::<&u8>();
              ^~~~~~~~~~~~~~~~~~~~~~~~

In particular, adding a generic impl of a trait has effectively removed other implementations (i.e. comparing against the behaviour when that impl wasn't there). It seems like this behaviour is somewhat idiosyncratic, and may want to be fine tuned.
The RFC doesn't seem to discuss references (or even primitives) at all, so I'm unsure if this has been thought about much.
(NB. the safety of Send and Sync is actually relying on this behaviour at the moment, so changes to this may have to change how the impls are arranged in core. Although I would prefer a solution that doesn't require changing them, as that will be making safety the default.)
cc @rust-lang/lang

Reply to this email directly or view it on GitHub:
https://github.com/rust-lang/rfcs/issues/1132

Triage: no movement.
Tested with updated syntax:
#![feature(optin_builtin_traits)]

auto trait NoImpl {}
fn test_no_impl<T: NoImpl>() {}

auto trait ConcreteImpl {}
fn test_concrete_impl<T: ConcreteImpl>() {}

impl<'a> ConcreteImpl for &'a i16 {}

auto trait GenericImpl {}
fn test_generic_impl<T: GenericImpl>() {}

trait Bound {}
impl<'a, T: Bound> GenericImpl for &'a T {}

fn main() {
    test_no_impl::<&u8>();
    test_concrete_impl::<&u8>();
    test_generic_impl::<&u8>();
}


add kubebuilder annotations for network types

cluster-config-operator generates CRDs for the config types, but it doesn't enforce that uint32 fields have non-negative values, which can cause problems by letting people create objects that can't be unmarshaled into their corresponding golang types (https://github.com/openshift/cluster-network-operator/issues/69).
I filed https://github.com/openshift/crd-schema-gen/issues/9 about doing this automatically so this may become unnecessary eventually.

While we're at it, do we want to add the actual minimum value where possible (e.g. MTU)?

Yeah, I had started adding more validation, but we can only validate the syntax, and only in isolation. So it's going to let some bad objects through no matter what, and it didn't really seem like it was worthwhile to, eg, validate that a given hostPrefix was between 0 and 32, but not validate that it fits within its corresponding cidr. This is basically why we end up copying everything to status I guess; because we can't guarantee that spec is meaningful.
But there's a difference between hostPrefix: 50 and hostPrefix: -1. In the former case, we'll see the bad value and we can log an error complaining that it's invalid. In the latter case, we will never even see the bad value, because it can't be read into a github.com/openshift/api/config/v1.Network object.

This is basically why we end up copying everything to status I guess; because we can't guarantee that spec is meaningful.

Exactly right. And, of course, because some changes may take time to roll out.
Anyways, blocking unmarshallable seems like a good first step. I'll add a JIRA card for adding more complete validation.
/lgtm

/assign @damemi
/approve
/hold
@damemi if this looks good, remove the hold.

As mentioned, this was filed as an issue to crd-schema-gen. However since we're moving away from that generator this issue should be reopened against upstream https://github.com/kubernetes-sigs/controller-tools. Given that we'll then depend on getting that fixed, I think this is a suitable fix for now.
/hold cancel


Timeline enhancements

This PR includes many enhancements to the incident timeline, including:

Direct link to the timeline for an incident. Users can now browse to .../{org_name}/incidents/{incident_name}/timeline to open the incident view directly to the timeline.
The incident details view pane is now expandable by a click and drag on the vertical divider line.
Icons in the timeline bubbles quickly indicate the type of event.
The incident timeline now has filtering to show/hide different kinds of events, with system events hidden by default.
Users can now add custom events to the timeline directly in the UI by hovering between existing events in the timeline and click the "Add event" button.
Custom events can be edited and/or deleted by the incident commander or reporter.
Messages imported from Slack with the reaction event can now be edited and/or deleted by the incident commander or reporter.

One thing that stands out form a UX perspective in the timeline is user actions vs system actions look very similar. I think it'd help to differentiate them more.
For example, the icon for the user actions could be the users profile picture and names could be bolded/clickable with the user popover component we have.

A minor thing from last screenshot -- the delete / edit icons probably fit best positioned all the way right, under the date. that way they wont cover the text or interfere with the content if it is rich (hoverable/clickable) in the future

One thing that stands out form a UX perspective in the timeline is user actions vs system actions look very similar. I think it'd help to differentiate them more.
For example, the icon for the user actions could be the users profile picture and names could be bolded/clickable with the user popover component we have.

Will pull these ideas into a phase 2, which will align the entire Incident edit/view with the new Case UI.


perm_income_cons.rst PyPlot to Plots converted

Looks great. We'll maybe do some cosmetic tweaks to the Plots while iterating, but this PR does what's needed.


refactor: replace uses of for in

Replace the uses of for in with for of and Object.entries/Object.values/Object.keys.
One case was further simplified by using a spread.

Did you benchmark this? for...in could be faster although probably not by a lot, plus there were no checks for prototype own properties before. Might be worth benchmarking this with complex files.
I also plan to take a stab at tweaking things after every file is formatted. :)

Thanks!


Updated llama.cpp

llama.cpp upstream had tensor_split converted from an array to a *const f32 which makes it a little more complicated since it doesn't have the trait Sync so any structures using it also aren't Sync.
https://github.com/ggerganov/llama.cpp/commit/ae178ab46bfd6ecb2422da5dad441a4e2fef8b7e
I think it is safe to explicitly mark them as so
unsafe impl Sync for ContextParams {}
unsafe impl Send for ContextParams {}

as long as the data at the pointer is never mutated by llama.cpp but not sure.
Also had to remove the Serialize, Deserialize for the *const f32 from being derived but that didn't break anything so idk why they were there in the first place.

Hi andy, looks good but you need to upgrade the bindings.rs after you build the package. As per the bindgen userguide.

The resulting bindings will be written to $OUT_DIR/bindings.rs where $OUT_DIR is chosen by cargo and is something like ./target/debug/build/llm-chain-llama-sys-23ea4c1322828090/out/.

so copy the bindings.rs from there into to src/bindings.rs in llama-sys. Thanks!

👌

Looks like there's some build problems. Merge with main first before debugging, there were some problems in the main branch as well.


Return u/int8, u/int16, u/int32 (sign-extend Int24), float32, float64 for interface{} as appropriate

Related to Issue #26 the previously merged PR maintains the same return types always int64 for integral and float64 for floats.
This PR will return variable width and also the unsigned versions of types. This is somewhat of a breaking change, so consider if this seems better to you. It means that users will have to check for float32 as well as int8, uint8, ... int64, uint64 when interface{} is returned. The plus is that there's less chance of getting the wrong value. In particular for replication/row_event.go since there's no 'unsigned' meta info, signed is always returned. So an int32 for a value like 0x80000000 cast to uint32 will mean the right thing. Without this PR an int64 returned for a MYSQL 32-bit LONG with value 0x0000000080000000 will return 0xFFFFFFFF80000000 (with sign extension) and cast to uint64 will not be the intended value. Cast to uint32 is, but then user must remember to downcast width for unsigned.
Hope this is all clear. If very concerned with backward compatibility, perhaps a mode setting?

Thanks @karmakaze , but I think it is not necessary here.
As you said above, handling multi int types  is not easy, sometimes we should write
case n := v.(type) {
    case int8:
    case int16:
    case int32:
    ....
    case uin64:
}

It is a little redundant and not convenient than only using int64/uint64, maybe user will define its own ToInt64/Uint64 conversion function for outer use  to make thing simple. :-)
You may see that for go database/sql lib, it only uses int64.

I agree it's more convenient when it works. However it can lead to incorrect data when it doesn't. For the RowsEvent integral values are returned in interface{} as int64, say in v.
switch n := v.(type) {
    case int64:
        // for known unsigned value, cast to unsigned:
        u64 := uint64(v.(int64))
    // other cases are non-integral
}

Now if the original value was from a LONGLONG all is well. If it was from an unsigned LONG, say 0x80000000 the int64 will be 0xFFFFFFFF80000000 and the u64 will have a huge value, instead of<PHONE_NUMBER>.
To handle this correctly the user code has to first have a type case for int64 then for each field name know what it's size is supposed to be when converting to unsigned. There's no automatic way of doing it, e.g.
func getUnsignedIntValue(v interface{}) uint64 {
    switch n := v.(type) {
    case int8:
        return uint64(uint8(v.(int8))
    case int16:
        return uint64(uint8(v.(int8))
    case int32:
        return uint64(uint8(v.(int8))
    case int64:
        return uint64(uint8(v.(int8))
    }
}

Such a function will continue to work without the user hardcoding field widths and even if a field in the db changes between unsigned int sizes. [The MySQL INT24 when unsigned requires masking out bits 25+ either way.]

Hi @karmakaze
I think the problem is that we only return int64 for integer type now, maybe we will change it to returning int64/uint64 directly.
But I don't know whether this change will affect outer use like my go-mysql-elasticsearch or others.

We don't know in advance whether to return int64 or uint64 in the case of RowsEvent--the column information doesn't include 'unsigned' meta info (in my testing).
Yes, this change can/will break some programs as behaviour is different (regardless of correctness of values).

Hi @karmakaze
I dive into python mysql replication and find that it selects the column information(including unsigned flag) from INFORMATION_SCHEMA.COLUMNS table using schema name and table name when meets table map event, and I think we can use this way too.
But this may have a risk, the table with same schema name and table name may be altered, so when we meet a table map event and use its schema name and table name to fetch the column information, the table may have been altered. So we must check the table id validation in INFORMATION_SCHEMA.INNODB_SYS_TABLES, if the table id exits, the table is not altered, if not, we can't use the columns information.
Btw, I still think using int64/uint64/float64 is enough.  :-)

SELECTing column meta info with table id protection sounds like a good idea.
I'm currently using a fork/branch with the int8...int64 return types, and otherwise stay in sync with upstream for now.

Merged


Add templates for JavaScript

Is your feature request related to a problem?
We do not work with TypeScript in our company. We literally have zero projects in TypeScript.
However, as I looked at all starter templates, they all work with TypeScript.
Please add JS templates for those who do not use TypeScript.
Describe the solution you'd like
I think providing a flag for the CLI should do the trick.
npm create qwik@latest --use-js

Describe alternatives you've considered
No alternative exists. We need to test with TypeScript. But if we decide to use Qwik, we need to wait until you support JS. Because we do not use TypeScript in our company at all.
Additional context
No response

Any comments about this?

@Nefcanto: See https://twitter.com/mhevery/status/1603468277945991168.
@mhevery says to just rename the couple of files to .js and .jsx. If that doesn't work, it's a bug.
Copy pasta:
find . -type f -name '*.ts' -exec sh -c '
    my_file={}
    my_file="$(dirname "${my_file}")"/"$(basename "${my_file}" .ts)"
    mv "${my_file}.ts" "${my_file}.js"
' \;

find . -type f -name '*.tsx' -exec sh -c '
    my_file={}
    my_file="$(dirname "${my_file}")"/"$(basename "${my_file}" .tsx)"
    mv "${my_file}.tsx" "${my_file}.jsx"
' \;

For example adding integrations needs vite.config.ts

Can't you rename that to vite.config.js?
Or is what you are after to have a non-build step project. If the no-build step is what you are after then Qwik may not be for you.

@mhevery when we use add commands while we have renamed vite.config.ts to vite.config.js, we encounter an error.
It seems that vite.config.ts or .ts and .tsx in general are in some places over Qwik's codebase.
Of course, Qwik is for us :)
We're building an internal layer over Qwik to be able to completely migrate from Next.js to Qwik.
We're a website design agency and we're suffering from pagespeed scores.
We're stuck at some places and we're R&Ding to solve them.

Having separate onGet for layouts and pages.
Figuring out how to use middleware
Figuring out how to incorporate i18n and l10n in our sites

As soon as we solve these problems internally, we migrate 100% to Qwik. And thank you so much for this valuable framework.

Ohh I see.
May I ask why not use TS? There are many benefits to it with few downsides.

It's a team decision. Many times we tried it, and we never felt good using it.
We're very happy without it and our projects are not complex in nature. We just deliver many projects and moat of them are simple and vanilla JS works just fine foe us.
I truely wanted to help. But TBH, I could not understand the codebase.
I forked and cloned and created the image. But understanding the code was not easy for me.
Do you have any idea about that? I can put 2 hours per day, if I understand the codebase.

Yes it is a complex project so it takes a while to get into the codebase.
Not sure we can offer help at this point as it is not something which is on
our roadmap and we already have the roadmap full with what we consider high
priority items.
On Sat, Dec 17, 2022 at 11:26 AM Saeed Nemati @.***>
wrote:

It's a team decision. Many times we tried it, and we never felt good using
it.
We're very happy without it and our projects are not complex in nature. We
just deliver many projects and moat of them are simple and vanilla JS works
just fine foe us.
I truely wanted to help. But TBH, I could not understand the codebase.
I forked and cloned and created the image. But understanding the code was
not easy for me.
Do you have any idea about that? I can put 2 hours per day, if I
understand the codebase.
—
Reply to this email directly, view it on GitHub
https://github.com/BuilderIO/qwik/issues/2062#issuecomment-1356403556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3KT22WFN3H6S7HN3I7N3WNYHYFANCNFSM6AAAAAAR3JWDHM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Upgrade nixpkgs

Description
The version of nixpkgs used is one of the stable versions for 22.11.
While they will continue working for the foreseeable future, we've already run into issues with out-of-date packages.
Proposal
Upgrade to 23.05/23.11 (if takes a month to get to this ticket)

Fixed by https://github.com/efabless/openlane2/pull/296


Update version - 1.3.14 was tagged on master

Makes sure the next release off the 1.3.x branch has the correct version.

Closing this because it is now part of #172 which also includes all the other missing commits that are needed. Thanks @mkurz for making this update.


Cap Touch activity?

Provide an activity that uses cap-touch to control the chest LED.  This can be a stand-alone node/launch file so it doesn't conflict with the other nodes that attempt to control the chest light
Dependencies

May need to provide a client for cap-touch in mobile_base

Need to flesh out this activity a bit

Plumb the segments on the cap touch sensor to LEDs on the chest light
Provide an example with white light that activates when the sensor detects touch
Suggested activities for students:

Different color LEDs
LEDs that get brighter the longer you touch, and then get dimmer over time when touch goes away.

Brad did this in https://github.com/MayfieldRoboticsPublic/kuri_edu/pull/21


Initial storyId does not get passed to the iframe

When you reload a storybook it says "Sorry, but you either have no stories or none are selected somehow."
For some reason the iframe.html is being rendered with id=undefined. I think due to this refactoring:
https://github.com/storybooks/storybook/commit/292d9152f73b2fb450432cedd89082b2a02a86bc
I can see immediately that these two lines are inconsistent:
https://github.com/storybooks/storybook/blob/6fdbf18db25a0c87844d67902f90508a324d1e76/lib/components/src/preview/preview.js#L40
https://github.com/storybooks/storybook/blob/6fdbf18db25a0c87844d67902f90508a324d1e76/lib/components/src/preview/preview.js#L25
However that alone is not enough to resolve the problem.

I'm pretty sure this is resolved


Improve observability around config sync

Is there an existing issue for this?

[X] I have searched the existing issues

Does this enhancement require public documentation?

[X] I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement
There are metrics to see how long sync takes: https://docs.konghq.com/kubernetes-ingress-controller/latest/production/observability/prometheus/#ingress_controller_configuration_push_duration_milliseconds
A user is suggesting adding this to logs.
https://github.com/Kong/kubernetes-ingress-controller/blob/95af584ab560822a40ee6a1dd66a2005f9663e71/internal/dataplane/sendconfig/sendconfig.go#L104
Is this something we want to do?
Proposed Solution
No response
Additional information
No response
Acceptance Criteria

[ ] Potentially log duration

The request is a little more involved. They'd like timings for each phase e.g.

Fetch from k8s API server
Translate to Kong format
Sync with Konnect

This looks a lot like tracing to me but tracing without an originator is a little unusual.

I have previously attempted to add tracing support for KIC (for performance testing purposes).
previously proposal here: https://docs.google.com/document/d/1iSWDjODhupV-1GxIBCsDcXbyrAyMghl2zg9wKXMPRVU/edit?usp=sharing
Example


fixed program schedule

Fixed Tutorial of Tomorrow and TBC on Thursday morning (09:00 AM)

published


Need to add shouldCloseOnSelect to TimePicker

Is it possible to add shouldCloseOnSelect to TimePicker (like it is implemented in DatePicker) because popup is not closed when time is already choosen. Looks wierd. Thank you.

I will look into it in a bit

Upgrade to the latest version added shouldCloseOnSelect  to TimePicker

@rnwonder Thank you!


New roles

How does one implement new roles with custom behavior/permissions (not just new aliases for preset roles) procedurally?

Please have a look into Role.php file. There are XYZ slots for like a 10 new roles available.


MG - 7.2.6 - "linear solver module" reference

It would be good to add a reference to M12 next to the text too.

Good idea! reference added. Thank you, Jason!


Pulling develop into master

Coverage increased (+2.3%) to 28.475% when pulling b67930570ca47b986fea72b9febaca463d5bd2dc on develop into 5dd5a6ba0c1a2d7d2645c6696db6e1f237422cfd on master.

Coverage increased (+2.3%) to 28.475% when pulling b67930570ca47b986fea72b9febaca463d5bd2dc on develop into 5dd5a6ba0c1a2d7d2645c6696db6e1f237422cfd on master.

Coverage increased (+2.3%) to 28.475% when pulling b67930570ca47b986fea72b9febaca463d5bd2dc on develop into 5dd5a6ba0c1a2d7d2645c6696db6e1f237422cfd on master.


Save Stripe responses in attributes

Hello,
I'm wondering if it would be a good idea to avoid some calls to Stripe's API in order to speed up Cashier.
When asStripeCustomer(), asStripeSubscription(), etc... methods are called several times, Stripe is called each time, wouldn't it be a good idea to save the first return in an attribute?
Something like :
    /**
     * @var \Stripe\Customer
     */
    private $stripeCustomer;

    /**
     * Get the Stripe customer for the model.
     *
     * @return \Stripe\Customer
     */
    public function asStripeCustomer()
    {
        if (!isset($this->stripeCustomer)) {
            $this->stripeCustomer = StripeCustomer::retrieve($this->stripe_id, $this->stripeOptions());
        }
        return $this->stripeCustomer;
    }

@driesvints ?
Thanks

I think this has been asked before iirc. The problem with keeping the original response in memory is that during the process, these responses can get out of date because of actions taken within Stripe and thus it could lead to inconsistent data from the actual state within Stripe. So I personally think this isn't the ideal solution. If we can speed up Cashier by making less API calls, all for the better but I believe there aren't many opportunities to do so atm. But feel free to prove me wrong by sending in a PR :)
Thanks.


Persisting multiple entities with custom types broken on 5.5.0

Describe the bug
Trying to upgrade from 5.3 to 5.6, I'm running into issues. I can't tell if there are breaking changes that I should apply to the code base or if that's just a bug. I tracked the issue as much as I could, it starts happening on 5.5.0 when I have a custom type on an entity.
Stack trace
Cannot read properties of undefined (reading 'id')
TypeError: Cannot read properties of undefined (reading 'id')
    at ChangeSetPersister.persistNewEntitiesBatch (node_modules/@mikro-orm/core/unit-of-work/ChangeSetPersister.js:126:53)
    at async ChangeSetPersister.persistNewEntities (node_modules/@mikro-orm/core/unit-of-work/ChangeSetPersister.js:102:13)
    at async ChangeSetPersister.runForEachSchema (node_modules/@mikro-orm/core/unit-of-work/ChangeSetPersister.js:68:13)
    at async UnitOfWork.commitCreateChangeSets (node_modules/@mikro-orm/core/unit-of-work/UnitOfWork.js:704:9)
    at async UnitOfWork.persistToDatabase (node_modules/@mikro-orm/core/unit-of-work/UnitOfWork.js:656:13)
    at async SqliteConnection.transactional (node_modules/@mikro-orm/knex/AbstractSqlConnection.js:36:25)
    at async UnitOfWork.doCommit (node_modules/@mikro-orm/core/unit-of-work/UnitOfWork.js:279:17)
    at async UnitOfWork.commit (node_modules/@mikro-orm/core/unit-of-work/UnitOfWork.js:252:13)
    at async SqlEntityManager.flush (node_modules/@mikro-orm/core/EntityManager.js:753:9)
    at async SqlEntityManager.persistAndFlush (node_modules/@mikro-orm/core/EntityManager.js:698:9)

To Reproduce
Here's an example with the smallest scope I managed to get: https://gist.github.com/maphe/b29c1f670014c626bac83a71e64cf907
Expected behavior
Should not throw an error on persist.
Additional context
It only occurs when I persist more than 1 entity. Changing line 80 to
orm.em.fork().persistAndFlush([u1]);

works fine.
Versions

Dependency
Version

node
v18.14.2

typescript
4.9.5

mikro-orm
5.5.0 and above

your-driver
sqlite

The issue is indeed relevant, but I wanted to mention this too:
orm.em.fork().persistAndFlush([u1, u2]);
orm.em.fork().clear();

Your code looks like you fork everywhere without much thinking, probably to get around the global context validation. Those two lines don't make much sense together, especially the second one. You create a clean fork via em.fork() and clear it, that will never have any effect, even if the clear would do something, you do it on the freshly created fork that you never store anywhere. Also note that you are missing an await on the first line.
Here is a "fixed" test case that is truly minimal, maybe you will find it useful:
import { Entity, PrimaryKey, Property, Type } from '@mikro-orm/core';
import { MikroORM } from '@mikro-orm/sqlite';

class RailsArrayType extends Type<string[], string> {

  convertToDatabaseValue(values: string[]): string {
    if (!values) {
      return null!;
    }

    // Convert to Set and back to Array to remove duplicates
    return ['---', ...[...new Set(values)].map(value => `- ${value}`)].join('\n');
  }

  convertToJSValue(value: string): string[] {
    if (!value) {
      return [];
    }

    return [...value.matchAll(/\n- (.*)/g)].map(matches => matches[1]);
  }

  getColumnType(): string {
    return 'text';
  }

}

@Entity()
class LegacyUser {

  @PrimaryKey()
  id!: number;

  @Property()
  username!: string;

  @Property({
    type: RailsArrayType,
  })
  teams!: string[];

}

let orm: MikroORM;

beforeAll(async () => {
  orm = await MikroORM.init({
    entities: [LegacyUser],
    name: 'sfp_test',
    dbName: `:memory:`,
  });
  await orm.schema.refreshDatabase();
});

afterAll(async () => {
  await orm.close(true);
});

it('should work', async () => {
  const u1 = new LegacyUser();
  u1.username = 'test';
  u1.teams = ['engineering', 'product'];

  const u2 = new LegacyUser();
  u2.username = 'test';
  u2.teams = ['engineering', 'product'];

  await orm.em.persistAndFlush([u1, u2]);
  orm.em.clear();

  const user = await orm.em.findOneOrFail(LegacyUser, 1);
  expect(user.username).toEqual('test');
});

(the ORM tests have global context allowed)

I see, v5.5.0 started using the returning statements in sqlite, but knex with sqlite can't detect returning statements automatically, so to get around that we use a regexp and it didn't support multiline queries (which your type produces).


Missing GA4 'properties' config

Expected Behavior
I'm trying to create a GA4 to Snowflake connection but only selecting the appropriate GA4 accounts and properties
Current Behavior
Following the documentation here, I'm trying to specify the properties config parameter but it doesn't allow it so the connection is incomplete on Fivetran.

resource "fivetran_connector" "google_analytics_4" {
  group_id          = fivetran_destination.snowflake.group_id
  service           = "google_analytics_4"
  sync_frequency    = 1440
  paused            = false
  pause_after_trial = false
  run_setup_tests   = true

  destination_schema {
    name  = local.snowflake_schema
    table = "traffic_session_medium"
  }

  config {
    timeframe_months = "THREE"
    sync_mode        = "SPECIFIC_ACCOUNTS"
    accounts         = ["XXXXXXXXX"]
    properties       = ["XXXXXXXXX"] // throws an error on 'terraform apply' as it doesn't exist
    prebuilt_report  = "TRAFFIC_ACQUISITION_SESSION_MEDIUM_REPORT"
    client_id        = var.gcp_client_id
    client_secret    = var.gcp_client_secret
  }
}

Steps to Reproduce

Mimic the above connector terraform config
See that if you don't specify properties, after terraform apply succeeds, then the connection is incomplete.
Try now and add properties into the config block, and now see that terraform apply throws error  Error: Unsupported argument ... An argument named "properties" is not expected here.

Created internal ticket for that. Will support the field in nearest releases.

Hi @MikeyJL , mentioned field was added in latest fivetran terraform provider version 0.6.17.
Please upgrade the provider version to it and u will be able to use the field.
Im closing this ticket.


Added LICENSE

This pull request should only be merged once all authors of the surviving code in the repository agree to using the BSD-3 License.
List of authors as of 7b52e2a:
(generated using git ls-files | while read f; do git blame --line-porcelain $f | grep '^author-mail ' | cut -f2 -d' '; done | sort -f | uniq -i | sort and decrypting github user names via emails - potentially better ways exist to get such a listing)

[x] @LeMyst
[x] @QEDK
[x] @addshore
[ ] @clamor
[ ] @cbenz
[ ] @danmichaelo
[ ] @dartar
[ ] @GretaD
[ ] @jjkoehorst
[ ] @JeroenDeDauw
[ ] @maxlath
[x] @Ladsgroup
[x] @manicki
[ ] @MatthiasWinkelmann
[ ] @micgro42
[ ] @wiese
[ ] @rosalieper
[x] @helmo
[x] @siebrand
[ ] @kerphi
[ ] @tarrow
[x] @thadguidry
[ ] @tuukka
[ ] @vrandezo
[x] @waldyrious

I agree to the license as I am requesting this change.

I agree to using the BSD-3 License.

I agree to using the BSD-3 License.

I agree to using the BSD-3 License.

I agree to using the BSD-3 License.

I agree to using the BSD-3 License.

I agree to using the BSD-3 License.

I don't mind. But is there a discussion that can be linked here for recerence?

I don't mind. But is there a discussion that can be linked here for recerence?

I agree.

I agree.

I agree to license my contributions to this project under the BSD-3 license.

I agree to license my contributions to this project under the BSD-3 license.

I agree.

I agree.

I agree

I agree

I agree.

I agree.

I agree

I agree

I agree

I agree

I agree

I don't mind. But is there a discussion that can be linked here for recerence?

Hi @helmo, there is not really a discussion involved. This pull request is simply fixing the old past mistake of not having a clear license for the docker "packaging" scripts in this repo (which, among other things, prevents them being able to be copied to other places - should anyone even needed this).
The proposed Modified BSD 3-Clause is standard license choice for WMDE - there is no discussion whether the repo should be licensed on some other license, if this was what you were getting at in your question.

I yet have to understand why we are so fond of such a permissive license over a GPL-flavor, but this is not the right place to have this discussion.
I agree to license my contributions to this project under the proposed Modified BSD 3-Clause.

I agree

I agree

I agree :+1:

I agree

I agree

I agree to license my contributions to this project under the BSD-3 license.

I agree

I agree to license my contributions to this project under the proposed Modified BSD 3-Clause.

I agree

I agree, make it so!

Checklist seems complete to me

FYI, in case someone asks in the future... the 3rd clause itself does allow for promotion with phrases such as "based-on WMDE's wikibase", or "derived from wikibase".  It disallows promotion phrases for projects which try to represent themselves as THE "WMDE wikibase" or "wikibase project" or "this uses the WMDE approved wikibase version".
Now I have to ping and bug @natfriedman about the display issue on GitHub which is slightly out of tone and probably should be fixed on their side:

Is docker-compose.yml interpreted within this license as a "source code"? We use Wikibase-specific docker-compose.yml in RaiseWikibase, but we use MIT license. Should we replace the MIT license by BSD 3-Clause license?

I'm not a lawyer, but ...
I think you can keep using your existing licence, so long as you also meet with 3 clauses of the bsd licence, 2 of which are mainly about redistributions.

Now I have to ping and bug @natfriedman about the display issue on GitHub which is slightly out of tone and probably should be fixed on their side:

@mlinksva may have some input here.

Ah, nevermind — he's way ahead of me :)


"Platform version 16 is unsupported by this NDK. Please change minSdk to at least 21 to avoid undefined behavior."

I upgraded Flutter to the most recent beta, and now cronet_http, which depends upon jni ^0.7.3 as a transitive dependency, causes my project to no longer build:
   > A problem occurred configuring project ':jni'.
      > [CXX1110] Platform version 16 is unsupported by this NDK. Please change minSdk to at least 21 to avoid undefined behavior. To suppress this error, add android.ndk.suppressMinSdkVersionError=21 to the project's gradle.properties or set android.experimentalProperties["android.ndk.suppressMinSdkVersionError"]=21 in the Gradle build file.

These lines seem relevant:
https://github.com/dart-lang/native/blob/95d226d290d4d5c583c4e45b04048442f244c656/pkgs/jni/android/build.gradle#L59C1-L64C33
and
https://github.com/dart-lang/native/blob/95d226d290d4d5c583c4e45b04048442f244c656/pkgs/jni/android/build.gradle#L87
This needs to be bumped to 21 to solve the problem. (Also now minSdkVersion has become minSdk.)

I can't reproduce this error.
$ flutter --version
Flutter 3.22.0-0.3.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 87b652410d (13 days ago) • 2024-04-23 21:41:18 -0500
Engine • revision b4bfd45986
Tools • Dart 3.4.0 (build 3.4.0-282.3.beta) • DevTools 2.34.3

$ flutter create reproduce1119 --platform=android
$ cd reproduce1119
$ flutter pub add cronet_http
$ flutter run

At least for a new project minSdk and other parameters are set to match Flutter's gradle plugin located in $flutterSdkPath/packages/flutter_tools/gradle:
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion
minSdk = flutter.minSdkVersion
targetSdk = flutter.targetSdkVersion

The default values are defined here.

I could change the minSdkVersion to 21 since it's the same as Flutter, but logically shouldn't it just be the maximum across all the dependencies including your application? So if your application is using current Flutter's default, then it should set it to 21 anyways?
Also, do you have ndkVersion = flutter.ndkVersion in your app/build.gradle? Maybe that downloads the correct NDK version automatically. Otherwise you could download an NDK from Android Studio and see if you still get this error.

Alternatively I could add ndkVersion = android.ndkVersion to package:jni's build.gradle. I'll try removing every NDK on my machine to see if this has an effect on auto downloading...

In the meantime, a dirty hack to add in android/build.gradle:
subprojects {
    ...
    afterEvaluate { project ->
        if (project.name.equalsIgnoreCase('jni')
                && project.hasProperty('android')) {
            android {
                defaultConfig {
                    minSdkVersion 21
                }
            }
        }
    }
}

OK, I'll publish jni 0.9.2 with minSdk 21.


feat: progress and button-group supports wai-aria

As you can see in chrome devtools, there are some generic DOM which shouldn't appear in a11y tree. You need to add role="none" for those DOM node.

Button group is nice.

当 indicatorPlacement === 'inside' 时，无论 showIndicator 为何值，都将会显示indicator，不知道有什么特殊的考虑在其中，我认为这是一个bug。 这个问题导致了 不能用 showIndicator 来判断 role  为progressbar 还是 none。
如果可以，将在下次commit中将 原有判断逻辑 indicatorPlacement === 'inside' 改为 showIndicator && indicatorPlacement === 'inside'

For circle progress, there is still a useless generic dom which should be set as role="none".

In the most basic progress bar, the role shouldn't be "none" but "progressbar".

For a types progress bar & circle, the role shouldn't be "none" but "progressbar".

Useless generic dom in the following example


Fixes gh-2420 | Added to test to verify open feign annotations are ignored

This is reference to the issue #2420

@thirunar Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@thirunar Thank you for signing the Contributor License Agreement!

Codecov Report

Merging #2435 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2435   +/-   ##
=======================================
  Coverage   68.43%   68.43%
=======================================
  Files         234      234
  Lines        8218     8218
  Branches     1020     1020
=======================================
  Hits         5624     5624
  Misses       2210     2210
  Partials      384      384

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f7842...10de2f9. Read the comment docs.

We document that feign annotations don't work be default. If you think the documentation needs clarifying, great. But we don't need a test to verify this.


DSND-3203: Update healthcheck endpoint

DSND-3203

CI: No security warnings found

CI: No security warnings found


Nos of input passed does not matches with the output

I am using model lmsys/vicuna-7b-v1.5, but I am not getting a proper response. i.e. on passing 3 input prompts to the model
with two prompts such that it exceeds the model's supported length. I am expecting vLLM to return 3 outputs from the model, but actually getting just 2 responses. We cannot map the response to the correct output if the order is not maintained.
I also tried different combinations where the input prompt length exceeded the permissible limit, a similar response was observed there. As vLLM does not do truncation of the input, but actually it drops the request #447, I believe in that case vLLM should return " " as an output.
In some cases, we are getting an empty string as output, and in some cases, we don't.
Can this be fixed?
from transformers import AutoTokenizer
from vllm import LLM, SamplingParams

model_name = "lmsys/vicuna-7b-v1.5"
tokenizer = AutoTokenizer.from_pretrained(model_name,
                                          trust_remote_code=True,
                                          use_fast=True,
                                          )

llm = LLM(model=model_name,
          trust_remote_code = True,
          tensor_parallel_size=1,
          max_num_batched_tokens=4096
         )

sampling_params = SamplingParams(max_tokens=100,
                                 temperature=0.1,
                                 top_k=100,
                                 top_p=0.3,)

def get_vllm_response(text):

    outputs = llm.generate(text, sampling_params, use_tqdm=False)

    response = []
    # Print the outputs.
    for output in outputs:
        response.append(output.outputs[0].text)

    return response

prompt_list = [
 "<prompt_1>", #   Input tokens is 4204
 "<prompt_2>", #   Input tokens is 1756
 "<prompt_3>", #   Input tokens is 4245
]

received_op = get_vllm_response(prompt_list)

expected_op = [
    "",                          # Exceeds Model's max seq limit
    "<output_2>",       # Within Model's max seq limit
    "",                          # Exceeds Model's max seq limit

]

received_op = [
     "<output_2>",
    ""
]

len(prompt_list)==len(received_op)  => Returning False

I met the same issue!!

I think if we truncate the prompts to the acceptable limit before passing it to vLLM then it's working fine

What is the status of this?

Any updates on this issue?

Closing this issue as stale as there has been no discussion in the past 3 months.
If you are still experiencing the issue you describe, feel free to re-open this issue.


Healthy check

Acceptance Criteria

Return status of artify-core and relevant services

Not sure it's a good candidate https://github.com/CachetHQ/Cachet It's written by PHP


CIV-8601 Hide uploaded evidence in case file viewer until Application Paid

Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[ ] Screenshot attached for the Evidence of manual testing
[x] Functional, Smoke and API tests have been run locally
[x] Full gradle build and run tests with coverage have been completed (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-8601
Change description
Hide uploaded evidence in case file viewer until Application Paid
Testing branch and instruction
https://github.com/hmcts/civil-general-apps-ccd-definition/pull/771
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

merging it as it had prior approvals to accidental commits


Recent update seems to introduce issue with shell check and home-manager on macOS?

I recently ran a nix flake update, followed by a nix run ./#build-switch - and I now seem to be getting an NixOS error regarding the shell configuration?
❯ nix run ./#build-switch
warning: Git tree '/Users/foobar/nixos-config' is dirty
Running build-switch for aarch64-darwin
Starting build...
warning: Git tree '/Users/foobar/nixos-config' is dirty
error:
       … while evaluating the attribute 'value'
         at /nix/store/hfz1qqd0z8amlgn8qwich1dvkmldik36-source/lib/modules.nix:816:9:
          815|     in warnDeprecation opt //
          816|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          817|         inherit (res.defsFinal') highestPrio;

       … while calling the 'addErrorContext' builtin
         at /nix/store/hfz1qqd0z8amlgn8qwich1dvkmldik36-source/lib/modules.nix:816:17:
          815|     in warnDeprecation opt //
          816|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |                 ^
          817|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error:
       Failed assertions:
       - users.users.foobar.shell is set to fish, but
       programs.fish.enable is not true. This will cause the fish
       shell to lack the basic Nix directories in its PATH and might make
       logging in as that user impossible. You can fix it with:
       programs.fish.enable = true;

       If you know what you're doing and you are fine with the behavior,
       set users.users.foobar.ignoreShellProgramCheck = true;
       instead.

I do have the following in modules/shared/home-manager.nix:
 40   fish = {
 41     enable = true;
 42 #    loginShellInit = ''
 43 #      if [[ -f /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.fish ]]; then
 44 #        source /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.fish
 45 #        source /nix/var/nix/profiles/default/etc/profile.d/nix.fish
 46 #      fi
 47 #   '';
 48   };

However, it seems like NixOS itself might not be aware of the home-manager module?
https://github.com/NixOS/nixpkgs/issues/280726
I'm pretty confused here as to the best way to fix this - is there some other place I should be setting fish.enable = true, on top of within home-manager.nix?

I just set this repo up today on a new Mac and was hoping to get Fish, my preferred shell, working.
Unfortunately, I've been unable to do so with this repo. My existing (private) nix-config repo has Fish working just fine, so I couldn't say why it's not working in this one. I've tried just about every combination of config I can, and zsh always shows up.
FWIW, you can make this error go away by adding:
programs.fish.enable = true;
to modules/darwin/home-manager.nix


Make the Largest-First algorithm pay for outputs collectively.

Related Issue
#39
Summary
This PR changes the reference implementation of the Largest-First coin selection algorithm to match the specification.
After applying this PR, the algorithm should always be successful at paying for a given set of outputs of total value v provided that the total value u of available inputs satisfies u ≥ v. (Unless the maximum input count has been exceeded.)
Old implementation (before applying this PR)
Rather than considering the total collective value of all outputs when attempting to find a selection of inputs, the old implementation considered each output independently, and for each output, attempted to find a selection of inputs to cover just that output.
This created an unnecessary cardinality restriction, namely that a single unique input could only be used to pay for at most one unique output, which meant that any set of n outputs could only be paid for if there were at least n inputs available. Under this restriction, the algorithm could fail even if the total value of inputs was sufficient to cover the required outputs.
New implementation (after applying this PR)
The updated algorithm now considers the total value of all outputs collectively, rather than considering them individually.
Under this relaxed scheme, it will always be possible to pay for a given set of outputs of total value v if the total value u of available inputs satisfies u ≥ v. (Unless the maximum input count has been exceeded.)

Q: So after collectively addressing all inputs to be covered (instead of one to one) we have more robust algo. Let's assume we want to cover [2, 1, 2] inputs. and have [4, 1, 1] utxos. In old implementation:
2 could be attributed 4, but the next one 1 would be not enough to cover the next2 and we would end up with error. Right now, 4 will cover [2,2] and [1] will cover the rest?

If we have inputs of [1, 1, 4] and want to pay for outputs of [2, 1, 2], the algorithm will:

Calculate the total value of all outputs: 5
Place the inputs into a list of descending order: [4, 1, 1].
Take just enough inputs from the head of the list to pay for the total value of all outputs. In this case, it will be [4, 1].
Since we have paid for the outputs exactly, there will be no change.

If we have inputs of [1, 2, 4] and want to pay for outputs of [2, 1, 2], the algorithm will:

Calculate the total value of all outputs: 5
Place the inputs into a list of descending order: [4, 2, 1].
Take just enough inputs from the head of the list to pay for the total value of all outputs. In this case, it will be [4, 2], with a total selected input value of 6.
Since there's an excess (6 - 5 = 1), the algorithm generates a change value of 1.