Spotless prevents to build or import

I cloned the repo, and I see this error when trying to build or when importing in IJ and this is very confusing because at first nothing looks wrong.
Cannot change dependencies of dependency configuration ':jsvg:compileOnly' after it has been included in dependency resolution.
$ ./gradlew build
Type-safe project accessors is an incubating feature.
Project accessors enabled, but root project name not explicitly set for 'buildSrc'. Checking out the project in different folders will impact the generated code and implicitly the buildscript classpath, breaking caching.

> Configure project :
Building: JSVG 1.5.0-SNAPSHOT
     JDK: /Users/brice.dutheil/.asdf/installs/java/corretto-<IP_ADDRESS>.1
  Gradle: 8.3

Build jsvg-root FAILURE reason:
    org.gradle.internal.exceptions.LocationAwareException: Build file '/Users/brice.dutheil/opensource/jsvg/jsvg/build.gradle.kts' line: 11
    Cannot change dependencies of dependency configuration ':jsvg:compileOnly' after it has been included in dependency resolution.
        Caused by: org.gradle.api.InvalidUserDataException: Cannot change dependencies of dependency configuration ':jsvg:compileOnly' after it has been included in dependency resolution.
            at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.preventIllegalMutation(DefaultConfiguration.java:1520)
            at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.validateMutation(DefaultConfiguration.java:1479)
            at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.lambda$validateMutationType$0(DefaultConfiguration.java:358)
            at org.gradle.internal.ImmutableActionSet$SingletonSet.execute(ImmutableActionSet.java:225)
            at org.gradle.api.internal.DefaultDomainObjectSet.assertMutableCollectionContents(DefaultDomainObjectSet.java:57)
            at org.gradle.api.internal.DefaultDomainObjectCollection.addLater(DefaultDomainObjectCollection.java:272)
            at org.gradle.api.internal.DelegatingDomainObjectSet.addLater(DelegatingDomainObjectSet.java:104)
            at org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.doAddProvider(DefaultDependencyHandler.java:218)
            at org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.doAdd(DefaultDependencyHandler.java:191)
            at org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.add(DefaultDependencyHandler.java:123)
            at org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.add(DefaultDependencyHandler.java:117)
            at org.gradle.kotlin.dsl.support.delegates.DependencyHandlerDelegate.add(DependencyHandlerDelegate.kt:53)
            at Build_gradle$1.invoke(build.gradle.kts:11)
            at Build_gradle$1.invoke(build.gradle.kts:10)
            at org.gradle.kotlin.dsl.ProjectExtensionsKt.dependencies(ProjectExtensions.kt:236)
            at Build_gradle.<init>(build.gradle.kts:10)
            at org.gradle.kotlin.dsl.execution.Interpreter$ProgramHost.eval(Interpreter.kt:523)
            at org.gradle.kotlin.dsl.execution.Interpreter$ProgramHost.evaluateSecondStageOf(Interpreter.kt:451)
            at org.gradle.kotlin.dsl.execution.Interpreter$ProgramHost.eval(Interpreter.kt:523)
            at org.gradle.kotlin.dsl.execution.Interpreter.eval(Interpreter.kt:218)

...

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/brice.dutheil/opensource/jsvg/jsvg/build.gradle.kts' line: 11

* What went wrong:
Cannot change dependencies of dependency configuration ':jsvg:compileOnly' after it has been included in dependency resolution.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 4s
4 actionable tasks: 4 up-to-date

After various trial and errors I found out that spotless was the culprit, and that it is required to add skipSpotless = true in properties.
And running also run into the same issue.
$ ./gradlew spotlessCheck -PspotlessRatchet=false -PskipSpotless=false

Also, contributing mention an autostyleCheck task but it doesn't exist.

Ever task with a name containing autostyle has been replaced by a version with spotless with it. Looks like I never got around to updating it in the documentation.
Not sure about the error though. I will try to reproduce it.

Ah, I forgot I had this in my ./gradle/init.d folder, not sure why it cause this issue though.
auto-apply-spotless
allprojects {
    plugins.withType(JavaPlugin::class.java) {
        plugins.withId("com.diffplug.spotless") {
            tasks.findByName("spotlessApply")?.let { spotless ->
                tasks.withType<JavaCompile> { // this causes the issue
                    finalizedBy(spotless)
                }
            }
        }

        // legacy plugin id
        plugins.withId("com.diffplug.gradle.spotless") {
            tasks.findByName("spotlessApply")?.let { spotless ->
                tasks.withType<JavaCompile> {
                    finalizedBy(spotless)
                }
            }
        }
    }
}

Interesting. Maybe I can figure out why it’s causing the error. Though I don’t immediately see why it should be an issue.

Yep I don't see as well why it could be an issue there, these seem to be different tasks.
For now I disabled this in my init.d which allows the project to be imported fine.


HDR videos available even on SDR displays/panels

Steps to reproduce
Open any video playback capable app and play some HDR content on it.. It will have "greyish" accent indicating HDR being applied on SDR videos And weird color mixture when HDR is played on non-HDR display (example: YouTube)
I have HDR off in Windows settings obv.
It should be auto-detecting my display I guess? But thats not happening.
I should not be having options to play HDR at all.
 And non-HDR videos are having HDR effects applied (example: YouTube)
Other Software
Mainly:
YouTube app (any version)
VLC (any version)
and:
Any other HDR playback capable app (any version)
Please specify the version of Windows Subsystem for Android
2303.40000.4.0

Thanks for raising this do you have a Nvidia GPU?

Thanks for raising this do you have a Nvidia GPU?

No I have AMD and latest drivers

Tracking this on #171


Changing Copyright info for new year.

This won't be implemented until midnight, but will be easier to push if it's ready to go!

Good

Thanks, but there are more places the year needs to change.


Object of class Shapefile\Geometry\MultiPolygon could not be converted to string when using `update()

Laravel version: 11.20.0
PHP version: 8.3
laravel-eloquent-spatial version: 4.3.2
Problem Description:
When trying to update a MultiPolygon geometry using the update() method in Eloquent, I encounter the following error:
Object of class Shapefile\Geometry\MultiPolygon could not be converted to string

Query Example:
Here’s the query I am using:
County::where('geometry', '=', null)
    ->update([
        'geometry' => new MultiPolygon([
            new Polygon([
                new Linestring([
                    new Point(0, 0),
                    new Point(0, 1),
                    new Point(1, 1),
                    new Point(1, 0),
                    new Point(0, 0),
                ]),
            ]),
        ]),
    ]);

Model Setup:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;
use MatanYadaev\EloquentSpatial\Traits\HasSpatial;
use Shapefile\Geometry\MultiPolygon;
use Shapefile\Geometry\Polygon;

class County extends Model
{
    use HasSpatial;

    public $timestamps = false;

    protected $table = 'county';

    protected $guarded = ['id'];

    protected $fillable = [
        'name',
        'bbox',
        'geometry',
    ];

    protected $casts = [
        'name' => 'string',
        'bbox' => Polygon::class,
        'geometry' => MultiPolygon::class,
    ];
}

Steps to Reproduce:

Create a MultiPolygon object.
Use the update() method to try and update the geometry field in the database.

Expected Behavior:
The geometry field should be updated with the MultiPolygon value.
Actual Behavior:
I get an error that the MultiPolygon object cannot be converted to a string.
Question:
Does laravel-eloquent-spatial support updating geometry fields using the update() method directly? Or is there a specific configuration or method that needs to be used?

Hi @Paxton0222, I think it doesn't work because you run ->update in the Query Builder and not in Eloquent, which passes the casting logic, and therefore, it doesn't convert the MultiPolygon instance into WKT format.
You can fix it by first fetching the record and then update it: Country::where(...)->first()->update(...)

@MatanYadaev Thank you so much for clearing up my confusion!


python311Packages.yabadaba: 0.1.3 -> 0.2.0, python310Packages.potentials: 0.3.5 -> 0.3.6

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 227612 run on x86_64-linux 1

16 packages built:

python310Packages.atomman
python310Packages.atomman.dist
python310Packages.cdcs
python310Packages.cdcs.dist
python310Packages.potentials
python310Packages.potentials.dist
python310Packages.yabadaba
python310Packages.yabadaba.dist
python311Packages.atomman
python311Packages.atomman.dist
python311Packages.cdcs
python311Packages.cdcs.dist
python311Packages.potentials
python311Packages.potentials.dist
python311Packages.yabadaba
python311Packages.yabadaba.dist


Multiple types of Torch builds

Multiple Torch Builds
This PR adds support for two distinct types of PyTorch builds:

torch:base

New home for gooseai/torch-base-type containers
Builds with nvidia/cuda:[...]-devel-[...]
Extends nvidia/cuda:[...]-base-[...]
Low image size, fewer libraries at runtime

torch:nccl

Builds with and extends ghcr.io/coreweave/nccl-tests
Inherits special versions of nccl and HPC-X
Larger image size, extensive libraries at runtime
Supersedes old torch-nccl containers from this repository

These are both grouped under the "torch" container name, with differing tags.
Tag Suffixes
The existing tag format for containers in this repository is :<short commit hash> for commits to the main branch, and :<branch name>-<short commit hash> for commits to other branches.
Since these torch builds are highly parameterized (potential variables: edition [torch:base/torch:nccl], CUDA version, NCCL version, torch version, torchvision version), it is beneficial to allow for tag customization to denote different build versions—which may also benefit from the then-shared build cache.
To achieve this, this PR adds an optional tag-suffix parameter to the .github/workflows/build.yml template. This allows for tags of the form [<branch name>-]<short commit hash>[-<custom suffix>].
Examples
torch:base builds are suffixed with a version string to result in the following format:
ghcr.io/coreweave/ml-containers/torch:<short commit hash>-base-cuda{}-torch{}-vision{}

Where {} is a placeholder for the respective library's version number.
torch:nccl builds have a similar format:
ghcr.io/coreweave/ml-containers/torch:<short commit hash>-nccl-cuda{}-nccl{}-torch{}-vision{}

Fix for UCC integration in torch:nccl builds
torch:nccl builds now enable UCC integration, linking against HPC-X.
This was intended to be enabled when the torch-nccl builds were added, but the right combination of flags had not been set (USE_SYSTEM_UCC does not imply USE_UCC, for some reason), and furthermore a bug would have made it impossible to link against the UCX library in nccl-tests's HPC-X distribution anyway.
The combined torch Dockerfile now contains a workaround to fix that bug when nccl-tests is used as a base, and properly links against UCX.
Build process optimizations
The torch builds have been optimized for size, speed, and cache-friendliness by making use of more build stages, as well as cross-stage filesystem mounts.
Highlights:

Torch repository versions are now downloaded as their own build stage.

This means they can now be cached separately and shared across runs with different CUDA base images.
This also means they can download in parallel with the builder stage.

No torch source files are stored in the builder stage's filesystem; they are only mounted temporarily from the downloader stage.
Torch build artifacts are all cleared except for the wheels to be distributed, to avoid bloating the intermediate image in the cache.
The final image no longer makes a copy of the torch wheels before installing them.

They are instead temporarily linked directly from the builder stage.

This looks awesome, like the nice PR doc.
Those image tags are getting long, splitting does have some impacts on the cache although since cache is synced at the end of each of the CI jobs anything running in parallel in CI will miss cache created by other parallel runs (which is unfortunate since these often get run together).  I would almost prefer keeping torch-base and torch-nccl as two separate images to maybe split that difference, but not a very strong opinion.

Also noticed that the workflows here only work out of the main repo since we only run them on push, to make PRs from forks able to run we need to add pull_request to the triggers for the top level workflows with the same path filters.  Mainly helpful to know that PRs result in working builds.

@arsenetar

This looks awesome, like the nice PR doc.
Those image tags are getting long, splitting does have some impacts on the cache although since cache is synced at the end of each of the CI jobs anything running in parallel in CI will miss cache created by other parallel runs (which is unfortunate since these often get run together). I would almost prefer keeping torch-base and torch-nccl as two separate images to maybe split that difference, but not a very strong opinion.

Image tags
As far as legal limits, the maximum length for a docker image tag (excluding the name) is 128 characters. A fully formatted torch:nccl tag with a 7-character hash and no branch prefix looks like abc1234-nccl-cuda11.8.0-nccl2.16.2-1-torch2.0.0-rc1-vision0.15.0-rc1, with 68 characters (though these are a bit longer than usual because of -rc1 version suffixes). This would leave about half of the character quota for an optional branch name, which should be plenty of room.
As far as aesthetics, having an extremely descriptive tag is pretty nice for visually scanning through versions quickly in the container repository, and being able to pluck out the right container without having to cross-reference docs/code/commits or manually downloading and probing them. And it ought to help people who use them in a Dockerfile keep track of any major changes if they want to update the version they are using later on.
So I think it'd be beneficial enough from a usability perspective to outweigh its visual clunkiness.
Caching and concurrency
On the first run they will miss out on cache-sharing, though on most subsequent updates the cache should help them out. For instance, if the base images for torch:nccl change, both parallel runs should be able to reuse the downloaded PyTorch repositories. And, since the builds running in parallel all use different base images, they wouldn't be able to share their cache for the builder steps anyway, so there isn't too much missed opportunity in that direction.
If the downloaded repositories change, both builds will re-download them in parallel, which will waste some bandwidth. I'm not sure if it would waste any storage, since the intermediate downloader stages will end up with identical contents; Docker might deduplicate the later one to save.
The builds can have their concurrency limited to an arbitrary extent with job concurrency groups to get maximal use out of of the downloader cache, but since each of these builds can take several hours, serializing them in any way may be a bit painful.

Also noticed that the workflows here only work out of the main repo since we only run them on push, to make PRs from forks able to run we need to add pull_request to the triggers for the top level workflows with the same path filters. Mainly helpful to know that PRs result in working builds.

Pull Request Builds
This is a good suggestion; none of the containers in this repository are currently built on the pull_request trigger.
Building a PR from an arbitrary fork results in arbitrary code execution on the runner, so workflows triggered from pull_request events have limited access to secrets. This would mean that they can't log in or push to the ml-containers ghcr.io repository, and since those steps are baked into the build.yml script, the runs would fail automatically.
The build and publish steps would benefit from being disentangled from one another, with the publish step being optional. This could also allow builds in branches to be tested without necessarily publishing them to the container image repository forever. Since this is a somewhat involved, repo-wide change with its own design considerations, it would be good to make it a separate issue, implemented apart from this one.
In the case of this PR, I test-ran the workflows by modifying build.yml's runs-on: [self-hosted, Linux] to runs-on: ubuntu-20.04 in a separate branch in my forked repo, which lets most of the steps run, though inefficiently. So these should be valid.

With regards to image tags, I was not worried about the max limit, and it seems like it should be large enough.   Splitting back to two different images for torch-nccl and torch-base was more about a top level clarity on there being two different "main" images more than anything (and slightly due to the one image already existing).  It also makes it slightly clearer that torch-nccl image is from the torch-nccl.yaml and such.  Not going to push too strongly for this, so if @wbrown is ok with the change to just a torch image with two distinct builds represented through the tags then I'll accept as well.
I would not want to limit concurrency of these builds any, the cache misses are not the worst here, and even so the matrix already creates a decent bit of invalidation between the different builds even though now there are more sections that can be shared with this new Dockerfile.
PR Builds from forks require approval to run which does help mitigate some concerns, however fork workflows do still have some differences as you stated.  Disabling push makes sense for forks as the intent is to verify the build succeeds more than anything else.  The impacted parts can be disabled fairly straightforward within the "build and push" step.  I do agree we can address that separately, was mainly making note for us.

@arsenetar @Eta0 Are we good to merge this?

@wbrown It was up to you to decide direction on the image change torch-nccl and torch-base vs torch (with nccl and base tags).

Confirmed with @wbrown; he said that torch with tag distinctions should be fine, so I'll merge it like this.


Implements :streaming option for DataFrame.to_csv/3

Closes #888
Description
I have added a streaming option for the to_csv/3 that uses the Polars sink_csv function under the hood.  Polars does not have a sink_csv_cloud function similar to sink_parquet_cloud, so for now, I implemented it only for a LazyFrame using a local entry.
Notes
As far as my implementation goes, I've kept the DataFrame API clean since I'm really just adding an option, but it does beg the question of how we'd want to expose some other Polars serialization options for users of the to_csv function.  For now I won't worry about that, though.

@ryancurtin thank you!


GraphIT problems when changing mandatory attrs to optional in new version

Hi Stefan,
When loading in GraphIT:
ontology_1
with entity_1
with attribute_1 = mandatory
and then later load:
ontology_2
with entity_1
with attribute_1 = optional
GraphIT does not recognize attribute_1 = optional, but still treats it as = mandatory
Because of this behavior, we can not properly work with OGIT ontology in the context of ConnectIT.
Could you please help?
@p-a-x @Ay-men @PPelchmann

this has nothing to do with the ontology itself . it is an implementation issue. Pls. report as ticket for GraphIT Server.

@p1tz explained that the ontology management is already a defined item on the list for future development but with an undefined implementation date.
The only temporary solution is the deletion of the ontology via admin console and a reload of the new one.

thank you @fotto , this happens as a result from the current setting in GraphIT which loads several ontologies at the same time


Make mysql command work out of the box

Enable mysql unix socket and set BASH_ENV so that docker
exec -ti CONTAINER_ID bash -c mysql works correctly.
Fixes #45
@mfojtik @hhorak

@mnagy LGTM but wait for the test... we have to do same for other images


Attributes loaded via attribute/list in SSR are not in base-state

Current behavior

If I enter a product page directly via URL as a server-side request, the state (list_by_id and list_by_code) won't be populated with the results of the attribute/list action from the ssr-request, and it remains empty.
The search query made in core/modules/catalog/store/attribute/actions.ts:77 is executed correctly and returns the correct data and commits them as expected into the state in its mutation core/modules/catalog/store/attribute/mutations.ts:13. But in the base state of the client the state object is empty again.
I noticed it when I was trying to load attribute option labels in a custom module via a mixin using asyncData in a component like:
asyncData ({ store }) {
  return store.dispatch('attribute/list', { filterValues: [ 'band', 'brand' ] })
}

I found out that the ATTRIBUTE_UPD_ATTRIBUTES mutation method is called as a async function which shouldn't be done according the Vuex docs. But if I remove it still delivers an empty state object.
If the page is entered using CSR, like when you are open a product over a category page, the state seems to be correct and complete.
Expected behavior

Show attribute lists in client-side base state.
Steps to reproduce the issue

On a plain installation, using the https://demo.storefrontcloud.io api-endoint, got to http://localhost:3000/women/tops-women/jackets-women/jackets-23/neve-studio-dance-jacket-1369.html?childSku=WJ11-XS-Black and use the Vue-Dev-Tools to inspect the current state:

You can see that the state objects are empty, despite the fact that they are loaded and commited on server-side prefetch via asyncData.
Repository

Latest develop e154dbb8d9346d01d5200f862fd958309eb8524d
Can you handle fixing this bug by yourself?

[x] YES – I try, but I didn't found a reason yet, any hints are appreciated ;)
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[x] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Chrome
OS: OSX
Node: LTS v10.15.3
Code Version: e154dbb8d9346d01d5200f862fd958309eb8524d

This is not an issue and it's intentionally filtered https://github.com/DivanteLtd/vue-storefront/pull/3326; the attributes are cached in the localStorage instead of being transferred with the HTML

@pkarw Ah I see. Thanks you, reading the changelogs could have saved me some time.
Okay, i get that change but I have two questions:

How I'm supposed to fetch product attributes that I need inside server-side html – like for SEO meta-tags in my case – when the initial state is completely flushed for attributes (without disabling useInitialStateFilter)?
How can I use the optionLabel helper method to get option labels that are already in the cache – is this already an intended usecase?

ad1) The state is flushed only when transferring to Client's side - so they should be available in the state after attribute/list call + you should repeat this call client's side
ad2) after product/list you will be able to use the optionLabel

@pkarw Thank you for your answer!!
My problem here is, that I need to get the option labels in the metaInfo() method of vue-meta in a single-page component (theme/pages/Product.vue). BUT the ssr-renderer clears the initial state before metaInfo() is executed.
I worked my way around it by loading the attributes as before in asyncData to get it server-side into the state and then assign it to a components property. This way I can use this property in optionLabel() despite the fact it has already been cleared from the state of the ssr-renderer when the metaInfo() is called – Honestly this seems like a hack. I'm thinking about to disable this feature if there isn't any other solution. Do you maybe have another idea how to do it?

You can still keep attributes in the SSR state by just removing the attribute from initialStateFilter -> this line


Added IsUsingIdentityServer3 bool in the OpenIdConnectOptions that is…

Added a unit test to make sure that when IsUsingIdentityServer3 is set to true, UserPkce will be false even if the users sets it to true
Summary of the changes (Less than 80 chars)

Detail 1
Detail 2

Addresses #14990

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: rcreynolds53 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

As discussed in https://github.com/aspnet/AspNetCore/issues/14990, I don't think we're ready to take a PR for something like this now. We don't add application-specific options like this (IsUsingIdentityServer3). Until we understand what change would be best (if any), we won't be looking at a PR yet.
Let's finish discussion on the Issue and once we've got an idea of the way we want to move forward, we can consider a PR.

@anurse sounds good, if there is anything I can do I am happy to help.


Broken link in README

The style guide link in the README file is broken: https://github.com/rust-lang/style-team/blob/master/guide/guide.md

The README needs an overhaul, as this isn't the fmt-rfcs repository anymore.

Readme has been rewritten


make dependence on jackson-databind explicit (bigquery connector)

BigQuery connector has jackson code and it messily only updates some jackson jar dependencies while leaving some key ones not updated.

Probably best left alone - the pekko-http-jackson dependency is provided so it is probably better not to add an explicit dependency on jackson-databind


uninstall option

i don't see uninstall/remove option. do you have any plans for this in the future?

Didn't thought about it @xxcriticxx :+1:

@xxcriticxx Thanks for using funceble and for requesting this feature.
I just fixed this issue with https://github.com/funilrys/funceble/commit/def3ba404188236e34aa58740233540b039b7522.
It's gonna be in the next release.
Thanks again and have a nice day/night.
Cheers,
Nissar
P.S: Please DO NOT close this issue manually. This issue is gonna be closed automatically once https://github.com/funilrys/funceble/commit/def3ba404188236e34aa58740233540b039b7522 will be merged to master.


Support Lighting instead/besides Pytorch Lighting

Provide and integration module for the new Lighting framework instead of PyTorch Lighting
Motivation
The new framework is lighting. Using the old callback optuna.integration.PyTorchLightningPruningCallback does not work with the new framework (I guess it mixes imports , which leads to bugs as explained here
If your feature request is related to a problem, please describe a clear and concise description of what the problem is. -->
Exceptions when using the new Lighting package.
The new callback should extend the behavior of the current one but for the new Lighting package

I see it is actually fixed. For some reason I do not obtain it in my optuna installation when doing pip install optuna.


Need ssl to connect

After i set googleMapsApiKey param a got this message:
( [error_message] => Requests to this API must be over SSL. [results] => Array ( ) [status] => REQUEST_DENIED )
This is my patch:
This patch file was generated by NetBeans IDE
It uses platform neutral UTF-8 encoding and \n newlines.
--- GeocodingClient.php (Today 10:04:15)
+++ Current File
@@ -52,7 +52,7 @@
* @return string
*/
public function getUrl() {

   return 'http://maps.googleapis.com/maps/api/geocode/' . $this->format;

   return 'https://maps.googleapis.com/maps/api/geocode/' . $this->format;

}
/**

this has been changed: https://github.com/2amigos/yii2-google-maps-library/blob/master/services/GeocodingClient.php#L57

The issue is no longer relevant for v1.0.


Install failing when composer decides it must install both ^5.3 AND dev-master

$ composer require felixfbecker/language-server
Using version ^5.3 for felixfbecker/language-server
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: remove felixfbecker/language-server dev-master
    - Can only install one of: felixfbecker/language-server[v5.3.0, dev-master].
    - Can only install one of: felixfbecker/language-server[v5.3.1, dev-master].
    - Can only install one of: felixfbecker/language-server[v5.3.2, dev-master].
    - Can only install one of: felixfbecker/language-server[v5.3.3, dev-master].
    - Can only install one of: felixfbecker/language-server[v5.3.4, dev-master].
    - Can only install one of: felixfbecker/language-server[v5.3.5, dev-master].
    - Installation request for felixfbecker/language-server dev-master -> satisfiable by felixfbecker/language-server[dev-master].
    - Installation request for felixfbecker/language-server ^5.3 -> satisfiable by felixfbecker/language-server[v5.3.0, v5.3.1, v5.3.2, v5.3.3, v5.3.4, v5.3.5].

Installation failed, reverting ./composer.json to its original content.

I have no idea where the purported Installation request for felixfbecker/language-server dev-master is coming from, as it quite clearly says Using version ^5.3 for felixfbecker/language-server at the outset.
Without knowing why it thinks it needs it in the first place, composer's recommendation to remove felixfbecker/language-server dev-master did not help.

This doesn't really sound like a language server issue. If you don't have a suspicion how I could fix this I would like to close this as not actionable.
Here's what I would try:

delete composer.lock
change the requirement in composer.json
delete vendor
run composer install

change the requirement in composer.json

Which requirement? What should it be changed to?

I'm confused, could you describe what you are trying to do?

I cloned this git repo, and followed the installation instruction by running the command:
composer require felixfbecker/language-server

And the result was the output I posted initially.

Wait, so you you tried to install the language server as a dependency of the language server?

Maybe?  I just followed your instructions?

I have the impression that you're telling me that we're not actually supposed to clone the git repo at all(?!).  Given that the instructions are part of the git repo, that seems bizarre to me, and should certainly be clarified in the instructions if that is the intention.
However, I've tried to test this by running the same command in a new/empty directory, with the following outcome:
$ composer require felixfbecker/language-server
Using version ^5.3 for felixfbecker/language-server
./composer.json has been created
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
- felixfbecker/language-server v5.3.6 requires jetbrains/phpstorm-stubs dev-master -> satisfiable by jetbrains/phpstorm-stubs[dev-master] but these conflict with your requirements or minimum-stability.
- felixfbecker/language-server v5.3.5 requires jetbrains/phpstorm-stubs dev-master -> satisfiable by jetbrains/phpstorm-stubs[dev-master] but these conflict with your requirements or minimum-stability.
- felixfbecker/language-server v5.3.4 requires jetbrains/phpstorm-stubs dev-master -> satisfiable by jetbrains/phpstorm-stubs[dev-master] but these conflict with your requirements or minimum-stability.
- felixfbecker/language-server v5.3.3 requires jetbrains/phpstorm-stubs dev-master -> satisfiable by jetbrains/phpstorm-stubs[dev-master] but these conflict with your requirements or minimum-stability.
- felixfbecker/language-server v5.3.2 requires jetbrains/phpstorm-stubs dev-master -> satisfiable by jetbrains/phpstorm-stubs[dev-master] but these conflict with your requirements or minimum-stability.
- felixfbecker/language-server v5.3.1 requires jetbrains/phpstorm-stubs dev-master -> satisfiable by jetbrains/phpstorm-stubs[dev-master] but these conflict with your requirements or minimum-stability.
- felixfbecker/language-server v5.3.0 requires jetbrains/phpstorm-stubs dev-master -> satisfiable by jetbrains/phpstorm-stubs[dev-master] but these conflict with your requirements or minimum-stability.
- Installation request for felixfbecker/language-server ^5.3 -> satisfiable by felixfbecker/language-server[v5.3.0, v5.3.1, v5.3.2, v5.3.3, v5.3.4, v5.3.5, v5.3.6].

Installation failed, deleting ./composer.json.

It depends on what you are trying to do.
Are you trying to use the language server? Then you don't need to clone the repo, but follow the installation instructions.
Are you trying to contribute to the language server? Then you need to follow the contribution instructions (includes cloning the repo) and not the installation instructions.

I am trying to use the language server, so following the installation instructions was what I was attempting to do.

Then you don't need to clone the repo

Please state this in the instructions (both that you don't need to clone the repo, and also that doing so will actually result in errors), because that's not at all intuitive.
However, as the installation instructions have resulted in (different) errors even when I did not run the command from the cloned repo/working copy, it seems like those instructions are not quite correct even if a cloned repo is taken out of the equation.

I was going to re-open this issue to make sure it didn't disappear from view in the interim, but I can no longer see the option for doing that... perhaps it's time-limited. If you still have the re-open ability, could you do that?


knockpy: 5.1.0 -> 5.2.0

Motivation for this change
Update to latest upstream release 5.2.0
Change log: https://github.com/guelfoweb/knock/releases/tag/5.2.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 140988 run on x86_64-linux 1

1 package built:

knockpy


880 string length schema checks

Description
Update the json schema file for new min and max values of shorterThan, longerThan and ofLength
Additional notes
Manually tested using VS Code on a local file. I have added invalid test profiles for each for the 6 new rules and 1 valid profile to prove the boundaries.
Issue
Resolves #880

Local testing:

Codecov Report

Merging #910 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted Files
Coverage Δ
Complexity Δ

.../com/scottlogic/deg/generator/utils/IsinUtils.java
83.33% <0%> (-3.71%)
25% <0%> (-1%)

...g/generator/restrictions/DataTypeRestrictions.java
62.85% <0%> (-2.86%)
13% <0%> (ø)

...n/fieldvaluesources/CombiningFieldValueSource.java
74.35% <0%> (-2.57%)
7% <0%> (ø)

.../generation/StandardFieldValueSourceEvaluator.java
94.82% <0%> (-1.67%)
31% <0%> (ø)

...rator/decisiontree/ProfileDecisionTreeFactory.java
95.58% <0%> (-0.07%)
25% <0%> (ø)

...tor/constraints/atomic/MatchesRegexConstraint.java
47.05% <0%> (ø)
5% <0%> (ø)
:arrow_down:

...generator/inputs/AtomicConstraintReaderLookup.java
95.4% <0%> (ø)
59% <0%> (ø)
:arrow_down:

...nerator/restrictions/StringRestrictionsMerger.java
100% <0%> (ø)
7% <0%> (+1%)
:arrow_up:

...com/scottlogic/deg/generator/VisualiseExecute.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...ogic/deg/generator/GenerateTreeCollectionJson.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

... and 21 more

We should update the documentation with this change, but otherwise hits the mark

Whereabouts is the current documentation for schema? I tried looking around for it and couldn't find anything?

We should update the documentation with this change, but otherwise hits the mark

Whereabouts is the current documentation for schema? I tried looking around for it and couldn't find anything?
https://github.com/ScottLogic/datahelix/blob/master/docs/ProfileDeveloperGuide.md


PaginationView overlap issue

Left this comment on a closed ticket but maybe it should be it's own issue.
I'm running into an overlap issue with other views seemingly ending up underneath the PaginationView.
Here's a minimal project example. You'll notice it can take several clicks on the "Skip" button to recognize the tap
paginationviewoverlap.zip

I just downloaded and run your project I didn't find any issue where Button not being tapped. Actually only text of your button is tappable which may be your issue.
HStack {
                    Button(
                        action: {
                            currentPageIndex = 2
                        },
                        label: {
                            Text("Skip")
                            .font(.system(size: 14, weight: .semibold, design: .rounded))
                            .foregroundColor(Color.gray)
                            .padding(skipButtonPadding)
                            .border(Color.green, width: 1)
                            .hidden(currentPageIndex == 2)
                        }
                    )
                    Spacer()
                    Button(
                        action: {
                            currentPageIndex += 1
                        },
                        label: {
                            Text("Next")
                                .padding(skipButtonPadding)
                                .border(Color.green, width: 1)
                                .hidden(currentPageIndex == 2)
                        }
                    )

                }

@sthahemant1st did you happen to try on a physical device? On the simulator it worked for me, but not on my iphone x (i believe it was with ios 15)
I'm out of an iphone at the moment so I can't give you the exact specs. I'm waiting for the new iphone to come out to retest again.

Actually only text of your button is tappable which may be your issue.
@sthahemant1st i think you're right here.

Using the label argument and sizing the text explicitly seems to work a little better. Tested on  iphone 15 pro max ios 17.0.2. Closing for now


Fix ampersand issue

I'm not the greatest with github, but I believe this fixes issue: https://github.com/OfficeDev/VBA-content/issues/588

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Access-VBA/articles/accessobject-datecreated-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/accessobject-datemodified-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/add-a-value-to-a-bound-combo-box.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/all-distinct-distinctrow-top-predicates-microsoft-access-sql.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/allow-users-to-add-items-to-an-unbound-combo-box.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/and-operator.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-accesserror-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-brokenreference-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-build-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-buildcriteria-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-closecurrentdatabase-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-codecontextobject-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-currentuser-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-davg-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dbengine-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dcount-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-deletecontrol-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-deletereportcontrol-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dlast-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dlookup-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dmax-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dmin-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dstdev-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dstdevp-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dvar-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-eval-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-featureinstall-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-followhyperlink-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-hyperlinkpart-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-languagesettings-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-modules-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-nz-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-opencurrentdatabase-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-printer-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-printers-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-productcode-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-references-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-refreshtitlebar-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-run-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-setdefaultworkgroupfile-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-usercontrol-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-vbe-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-version-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/apply-a-filter-when-opening-a-form-or-report.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/assign-a-control-a-value-from-a-table.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/attachment-properties-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/avg-function-microsoft-access-sql.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/axis-example-vbscript.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/boundobjectframe-beforeupdate-event-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/boundobjectframe-columnhidden-property-access.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Access-VBA/articles/accessobject-datecreated-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/accessobject-datemodified-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/add-a-value-to-a-bound-combo-box.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/all-distinct-distinctrow-top-predicates-microsoft-access-sql.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/allow-users-to-add-items-to-an-unbound-combo-box.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/and-operator.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-accesserror-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-brokenreference-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-build-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-buildcriteria-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-closecurrentdatabase-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-codecontextobject-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-currentuser-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-davg-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dbengine-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dcount-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-deletecontrol-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-deletereportcontrol-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dlast-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dlookup-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dmax-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dmin-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dstdev-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dstdevp-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-dvar-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-eval-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-featureinstall-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-followhyperlink-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-hyperlinkpart-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-languagesettings-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-modules-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-nz-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-opencurrentdatabase-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-printer-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-printers-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-productcode-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-references-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-refreshtitlebar-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-run-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-setdefaultworkgroupfile-method-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-usercontrol-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-vbe-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/application-version-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/apply-a-filter-when-opening-a-form-or-report.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/assign-a-control-a-value-from-a-table.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/attachment-properties-property-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/avg-function-microsoft-access-sql.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/axis-example-vbscript.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/boundobjectframe-beforeupdate-event-access.md
:white_check_mark:Succeeded

VBA/Access-VBA/articles/boundobjectframe-columnhidden-property-access.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Bravo @Kagre for fixing a format problem in hundreds of files. Can you describe the steps you used?
@Lauragra or @lindalu-MSFT please confirm that you can accept a pull request that fixes multiple files.

@Kagre This content is no longer being published. The new content is about to be merged to live on MicrosoftDocs/VBA-docs.

@italicize @Kagre This PR will not be merged. When the new VBA-docs is published on MicrosoftDocs (sometime today, we hope) then you'll have to reapply your fix. This repo was supposed to be blocked from making changes, I'm looking into what happened and why you were able to make changes.

@italicize basically,
I updated my fork to the current master: SO Article.
Installed Git
downloaded the repository files locally: GitHub Article
fiddled around with PowerShell a bit until I got it to do what I wanted https://github.com/OfficeDev/VBA-content/issues/588:
$re = [regex]'(?s)```vb([^`]*&;)+[^`]*```'
filter fltr{
   $content=(gc $_) -join "`n"
   $mList = $re.matches($content)
   if($mList.count -gt 0){
#      write-host "********* $($_.fullname)"
      foreach($ToFind in $mList.value){
#         write-host "********* ToFind"
#         write-host $ToFind
         $ToSet = ($ToFind -replace '&;','&')
#         $ToSet = ($ToFind -replace '(?''head''\s+)&;(?''foot''\s+)','${head}&${foot}')
#         write-host "********* ToSet"
#         write-host $ToSet
         $content = $content.replace($ToFind,$ToSet)
      }
      $pth = resolve-path $_ -relative
#      $pth = ".\diff\$pth";$null = (ni $pth -type file -force)
      sc $pth $content -force
      resolve-path $pth -relative
   }
}
ls *.md -recurse | fltr | ac Updated.txt

Git commandline also installed Git GUI which was easier to use to push the updated files back to my fork, then I created a pull request from my fork to the master through the web interface.
(of course it wasn't quite this straight forward when I was working through it; I just had to try things, some worked, some didn't, but this is the gist of what got me there in the end.)
if you want to give it a go; there's some spacing issues I've noticed here and there but haven't had the time to dig into which you could try fixing as well.
@lindalu-MSFT I believe I should be ok to run it again, but is there a way for me to check when the new VBA-docs is published?

@Kagre It looks like the VBA reference has moved.

Old repository, https://github.com/OfficeDev/VBA-content
New repository, https://github.com/MicrosoftDocs/VBA-Docs/blob/master/api/overview/index.md

Also, it looks like the formatting is worse now.

Old article, https://github.com/OfficeDev/VBA-content/blob/master/VBA/Language-Reference-VBA/articles/select-case-statement.md
New article, https://github.com/MicrosoftDocs/VBA-Docs/blob/master/Language/Reference/User-Interface-Help/select-case-statement.md

These fixes were needed even before the files moved:

Add a space before links, if missing.
Add a space between an italic mark (_) and a bold mark (*).
Add a blank line between single-spaced lines.
Change bold Syntax and Remarks to headings.
Replace &; with & only.

@lindalu-MSFT Could Microsoft please fix the formatting problems? Each time the files moved, formatting problems showed up.

Also, @Kagre thanks for posting the steps. I think I had a conceptual block about the step where you created a pull request from your fork to the master. I had some feeling like Microsoft wouldn't let it work that way. But that's how GitHub works, so what was I worried about?

@italicize lol, Microsoft recently bought GitHub, so who knows what the future may hold.

@italicize now I'm curious, would you suggest Syntax and Remarks should be at the double level like Example, or all at the triple level? Also @lindalu-MSFT would that bold to header update break the MSDN conversion?
plus it looks like there is one more to add to your list, any link to the vbe-glossary.md should probably have the hash sub reference added too.

digging through some of the other documentation looks like they should be at the double level

@Kagre You're right that the glossary links should go to specific terms.
@lindalu-MSFT Why does a link like [constants](vbe-glossary.md#constant) receive an "illegal link" error? See https://github.com/OfficeDev/VBA-content/pull/636

Moved to https://github.com/MicrosoftDocs/VBA-Docs/pull/36 and completed there.


use-package integration: allow backquoted/quoted recipe

The :straight keyword now accepts the same type of arguments
straight--use-package does. This allows one to programmatically
specify recipes.
For example:
    (defvar my/github-username "my")

    (use-package example
      :straight `(:repo ,(concat my/github-username "/repo")))

Expands to:
    (progn
      (straight-use-package
       `(example :repo ,(concat my/github-username "/repo")))
      (require 'example nil nil))

Not familiar with the older syntax mentioned here:

Previously, straight.el used a different syntax for its use-package integration. For backwards compatibility, you can use this syntax instead by customizing straight-use-package-version.

But I don't think I've broken anything.

(use-package test
  :straight t)

Expands to:
(progn
  (straight-use-package 'test)
  (require 'test nil nil))

Is this incorrect? What should it expand to?

Would it not make more semantic sense if the syntax were to use , instead of `? The former means to evaluate, the latter means don't evaluate.

I am familiar with backquotes, but I don't understand where/how you think they should be used. An example would help.

breaks several cases

I'm not sure which cases it breaks, but you are obviously more familiar with how this integration is supposed to work. AFAICT, The expansion matches for all the cases here:
(use-package el-patch
  :straight t)

macroexpands (essentially) to:

(straight-use-package 'el-patch)

And this:

(use-package el-patch
  :straight (:host github :repo "raxod502/el-patch"
             :branch "develop"))

becomes:

(straight-use-package
 '(el-patch :host github :repo "raxod502/el-patch"
            :branch "develop"))

If the feature you are requiring with use-package is different from the package name, you can provide a full recipe:

(use-package tex-site
  :straight (auctex :host github
                    :repo "emacsmirror/auctex"
                    :files (:defaults (:exclude "*.el.in"))))

And you may also provide just the package name:

(use-package tex-site
  :straight auctex)

If you don't provide :straight, then by default nothing happens. You may customize straight-use-package-by-default to make it so that :straight t is assumed unless you explicitly override it with :straight nil.

Why not just check at the top level whether it's quasiquoted, and eval the form before running the existing code?

That was my original implementation, but I think this is a better approach. For one it is more transparent to the end user when the form is expanded. Secondly, I believe evaling when handling the :straight keyword may complicate things down the line for features like this: https://github.com/raxod502/straight.el/issues/235

The current implementation works for the undocumented, multiple argument case as well.
Previously, in this case the forms would appear in reverse order in the expanded body.
Though I think this is a rare corner case, I've made it so they expand in declared order in.
Seems to work for me for all of the following cases:
(let ((tests '(;; nil
               ((use-package test :straight nil) . (require 'test nil nil))
               ;; t
               ((use-package test :straight t) . (progn
                                                   (straight-use-package 'test)
                                                   (require 'test nil nil)))
               ;; implicit quote
               ((use-package test :straight (:repo "user/test"))
                . (progn
                    (straight-use-package '(test :repo "user/test"))
                    (require 'test nil nil)))
               ;; explicit quote
               ((use-package test :straight '(:repo "user/test"))
                . (progn
                    (straight-use-package '(test :repo "user/test"))
                    (require 'test nil nil)))
               ;; backquote
               ((use-package test :straight `(:repo ,(concat "user" "/test")))
                . (progn
                    (straight-use-package `(test :repo ,(concat "user" "/test")))
                    (require 'test nil nil)))
               ;; package name different from repo name
               ((use-package provided :straight (package :repo "user/package"))
                . (progn
                    (straight-use-package '(package  :repo "user/package"))
                    (require 'provided nil nil)))
               ;; (undocumented) multiple args to :straight keyword
               ((use-package test
                  :straight
                  `(foo :repo ,(identity "user/package"))
                  bar
                  'baz)
                . (progn
                    (straight-use-package `(foo :repo ,(identity "user/package")))
                    (straight-use-package 'bar)
                    (straight-use-package 'baz)
                    (require 'test nil nil))))))
  (mapcar (lambda (test)
            (equal (macroexpand (car test)) (cdr test)))
          tests))

One thing to note about the undocumented, multiple argument case is that you can pass contradictory arguments.
e.g.:
(use-package test
:straight nil t)

expands to:
(progn
  (straight-use-package 'test)
  (require 'test nil nil))

And:
(use-package test
:straight t nil)

expands to:
(require 'test nil nil)

The last argument "wins" in these cases. Not sure if that's desirable or not, but I just wanted to note it.

a bug in the normalizer

We'll tackle that in a separate pull.

Just add a comment in the handler

Addressed in latest commit.

Thank you for your work here; it's great and I really appreciate your patience.

Thank you for straight.el! It's an indispensable tool for me.

Just in case someone else runs into the same issue, the changes in this PR caused my config to break due to how I was passing in custom package names via the :straight property.
Details are here, TL;DR below:
;; bad (no longer works)
(use-package helm-global-bindings
  :straight (helm))

;; good (worked before, still works)
(use-package helm-global-bindings
  :straight helm)

@jimeh Apologies for the breakage. I've pushed a fix in #566 that should allow either case if you don't mind testing it out.


Which falvor should i deploy and tunning parameter

I am testing ten thousands different topic, per topic 100 QPS, every message is 512Byte. When I add to 3_600 topic, my bookkeeper is OOM which reached 2G limit.
I want to know, my pulsar and bookie deploy on which falvor of ECS, and what paramenter need to change

@Shoothzj
How do you set up the bookie memory settings? It would be good to share more details about your current set up.
I would also suggest checking out the whitepaper written by Penghui and Devin about a deep-dive into Pulsar Architecture for performance tuning - https://streamnative.io/whitepaper/taking-a-deep-dive-into-apache-pulsar-architecture-for-performance-tuning/

According to my business, I want to deploy in two mode:

1U4G for both pulsar and bk
4U16G for both pulsar and bk

I test it last week, I only tunning both pulsar and bk, JVM HEAP to 1G, Directory memory to 1G.
Last week, I didn't thinking the memory of rocks DB, and I will  consider this.
Do you think it's okay? Can 1U4G run well?


send account recovery email on repeated signup attempt

following up in this issue we need to improve the UX for users who forget that they have an existing account:
https://github.com/supabase/supabase-js/issues/296

@awalias Any plans to implement sending magic link / recovery email for existing user signup? Currently, the DX is unwieldy, as I need to detect the existing user signup and then act accordingly

Repeated Signups with the same email address should now return an error stating that the user has already signed up.
Additionally, we have introduced a resetPasswordForEmail method which would allow a developer to detect repeat signups at the application level and send a reset password email as necessary
https://github.com/supabase/gotrue-js/blob/rc/src/GoTrueClient.ts#L690
Going to close for now but feel free to comment/reopen if there are unaddressed concerns

Repeated Signups with the same email address should now return an error stating that the user has already signed up.

Thanks @J0. Is this change already rolled out or is it expected to roll out with a particular release of supabase-js/gotrue-js/gotrue server

The change should be rolled out  in supabase-js for signups which make use of the signUp method. Is the change not working as expected on your end?

I have been using supabase-js v2 with its latest rc release. In one of my test where I signup, confirm signup and then signup once again with the same email, instead of an error I get faux user record.
I am testing this locally with the gotrue v2.16.7 docker image

@J0 Emails are not sending again on the live Supabase platform, with latest supabase-js 1.35.7. Can you post the link to the releases note or PR which contains the fix that closed this issue? I cannot find it in https://github.com/supabase/supabase-js/releases.

Repeated Signups with the same email address should now return an error stating that the user has already signed up.

This is only the case if you have autoconfirm enabled in your project config :( (see https://github.com/supabase/gotrue/blob/6c8a96e39190e1d499ab667fcd24bed2b2fa01c8/internal/api/signup.go#L252)


Load in properties from the tiles

I had to remove Eq from the Tile and Tileset due to the fact that f32 does not implement it.

Sorry for the delay, and thanks! It's a bit annoying rust does this, but oh well!


Add ability to exit on successful retrieval of JWT SVID

It also can not run a command on exit near as I can tell. The code should probably call the same function that does cmd execution and signaling as well as exit?

It also can not run a command on exit near as I can tell. The code should probably call the same function that does cmd execution and signaling as well as exit?

Yes, I think so. It's confusing that there's not parity here.

Actually signaling might be confusing since if there's multiple JWTs, it would signal multiple times.

Actually signaling might be confusing since if there's multiple JWTs, it would signal multiple times.

The same is true on exiting? With multiple jwts I'd think the exit should happen when all have been fetched. Probably signaling, and cmd should happen the same way? But that is more tricky...

The same is true on exiting? With multiple jwts I'd think the exit should happen when all have been fetched. Probably signaling, and cmd should happen the same way? But that is more tricky...

Yea, I guess it should signal once when all the JWTs are fetched, not each time. Dunno why I didn't think of that.

@keeganwitt This should be met with the daemon-mode setting released in 0.8.0. Can you confirm?

@keeganwitt This should be met with the daemon-mode setting released in 0.8.0. Can you confirm?

Yes, this is the case.


setup.py install doesn't work on PyPy

When installing AbuseHelper using PyPy (pypy setup.py install) the script doesn't find the needed packages. The problem lies in the function is_package() which is called when collecting packages in function collect_package().
The problematic function below:
def is_package(path):
    try:
        imp.find_module(".", [path])
    except ImportError:
        return False
    return True

This will always raise ImportError on PyPy with a message ImportError: No module named . The result is that the actual code is not copied to site-packages folder, only the abusehelper-*.egg-info file appears. On Python the same function seems to work, returning something like (None, 'abusehelper/.', ('', '', 5)).

The newer setup.py in branch setuptoolsify seems to install fine on PyPy.

Apparently related to pull request #37

Fixed in #37. Closing

how to install ？


if a side container in a taskrun failes, entire taskrun should fail

Reusing the title  from #682 since they are the same but this time we are using side container instead of init ones
Expected Behavior
When you have one step that fails it should be marked as fail and not continue to the next step
Actual Behavior
Continue to the next steps and show as Completed/Succeeded
Steps to Reproduce the Problem
Sample task
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: echo-hello-world
spec:
  steps:
    - name: echo
      image: ubuntu
      command:
        - echo
      args:
        - "hello world"
    - name: error
      image: ubuntu
      command:
        - exit
    - name: final
      image: ubuntu
      command:
        - echo
      args:
        - "hello moto"

First step should success, second shoudl error and third should work as seen from the containerStatuses :
- containerID: cri-o://e8f02dae0c84276cc1fb15b282c8b5241042525c13576fca4353239484e92436
    image: docker.io/library/ubuntu:latest
    imageID: docker.io/library/ubuntu@sha256:f2557f94cac1cc4509d0483cb6e302da841ecd6f82eb2e91dc7ba6cfd0c580ab
    lastState: {}
    name: build-step-echo
    ready: false
    restartCount: 0
    state:
      terminated:
        containerID: cri-o://e8f02dae0c84276cc1fb15b282c8b5241042525c13576fca4353239484e92436
        exitCode: 0
        finishedAt: 2019-04-04T22:06:00Z
        reason: Completed
        startedAt: 2019-04-04T22:06:00Z
  - containerID: cri-o://9358cbe2aeeecbe571c102d6489fb3a366c9d6198217d022d5b7a2647ad62998
    image: docker.io/library/ubuntu:latest
    imageID: docker.io/library/ubuntu@sha256:f2557f94cac1cc4509d0483cb6e302da841ecd6f82eb2e91dc7ba6cfd0c580ab
    lastState: {}
    name: build-step-error
    ready: false
    restartCount: 0
    state:
      terminated:
        containerID: cri-o://9358cbe2aeeecbe571c102d6489fb3a366c9d6198217d022d5b7a2647ad62998
        exitCode: 1
        finishedAt: 2019-04-04T22:06:01Z
        reason: Error
        startedAt: 2019-04-04T22:06:01Z
  - containerID: cri-o://f400bcd955d115462011c9cafe786d5b3431f4b0fc37d440ce04e6edca4f9b52
    image: docker.io/library/ubuntu:latest
    imageID: docker.io/library/ubuntu@sha256:f2557f94cac1cc4509d0483cb6e302da841ecd6f82eb2e91dc7ba6cfd0c580ab
    lastState: {}
    name: build-step-final
    ready: false
    restartCount: 0
    state:
      terminated:
        containerID: cri-o://f400bcd955d115462011c9cafe786d5b3431f4b0fc37d440ce04e6edca4f9b52
        exitCode: 0
        finishedAt: 2019-04-04T22:06:02Z
        reason: Completed
        startedAt: 2019-04-04T22:06:02Z

but third step should have not been started since the second one has failed and should show as completed/success :
% k get pod
NAME                                           READY   STATUS      RESTARTS   AGE
echo-hello-world-task-run-pod-cfd7fd           0/4     Completed   0          3m30s
% k get taskrun
NAME                        TYPE        STATUS   STARTTIME   COMPLETIONTIME
echo-hello-world-task-run   Succeeded   False    4m38s       4m24s

Additional Info

@chmouel So… it's a bit trickier. As we don't use initContainers, all containers in a Pod starts in parallel… So the flow is the following:

all the container are starting, initial step command being "transformed" using entrypoint …
if it's the first step, it starts right away, and write a file when finished (if failed, it's gonna prepend .err to that file)
if it's not the first step, it's gonna wait for a file (well actually either the "success file" or the "error file") to be written (by the previous step) before actually running the real step command.

If the previous step was error, it's doing a no-op (aka exit 0)

This can be a bit confusing as it will exit 0 and thus makes us think it actually executed. It kinda has been discuss here quikcly :sweat_smile:

I see thanks for taking the time to describes how it works, I guess then it's a UI problem, to check if the containers have failed or not.
Is it a pattern that we are going to keep ? if it is then perhaps we can document it  ? (I would not mind doing it)

I see thanks for taking the time to describes how it works, I guess then it's a UI problem, to check if the containers have failed or not.
Is it a pattern that we are going to keep ? if it is then perhaps we can document it ? (I would not mind doing it)

Right… Good question :sweat_smile:. I'm not a huge fan of " it's a UI problem, to check if the containers have failed or not." as it means each UI implementation will have to have this knowledge (and if it changed or evolve, well. we break them). I think that:

We should document it (for sure !)
We may want to think of a better way to show that those steps are skip due to previous errors. In the PR we discussed maybe using a special exit code for that.

Perhaps as a first step,  we can maybe fix that the status is not set as "Succeeded" when there is a failure ? For example :
status:
  conditions:
  - lastTransitionTime: 2019-04-04T22:06:04Z
    message: 'build step "build-step-error" exited with code 1 (image: "docker.io/library/ubuntu@sha256:f2557f94cac1cc4509d0483cb6e302da841ecd6f82eb2e91dc7ba6cfd0c580ab");
      for logs run: kubectl -n tekton-pipelines logs echo-hello-world-task-run-pod-cfd7fd
      -c build-step-error'
    status: "False"
    type: Succeeded

the type  here get sets as failed after all the task has finished ?
that would make explicit that there is an issue for UI to then go digg into the issue ?

@chmouel as discussed on Slack, this conditions are "standard", and it is kinda explicit for the consumer that this is a failure : condition of type Succeeded is false — hence it's a failure. Also this is what knative/serving is looking for and it would be a huge API changes just to rename it :sweat:

fair enough, so let's try to document this, then. (there is a nice github tag for this?)

I just want to double check @chmouel @vdemeester do we want to keep this open so we update the docs? or did that already happen?

@bobcatfish we may want to keep it opened until docs are clearer about it, indeed

I think we can "close" this :angel: @ImJasonH proposal on API spec should help with making it more clear but it's "standard" conditions :angel:
/close


Add basic support for Alpine Linux on aarch64

These changes allow us to build the toolchain and Swift runtime on aarch64 Alpine Linux.

@MaxDesiatov Are there plans to also support Alpine on x86, or would there be some drawbacks? Can't wait to see swift for Linux Alpine to enable formatting and linting in the CI ;D


Multiple chat windows tab

Would be nice for Launcher to take an array of multiple chats and make tabs for each chat with each unique user

Yeah totally agree, that's what the genuine Intercom has and it should be on the roadmap. Realistically I won't get to that feature for several months.

I'm removing this from the next release. I haven't heard anyone else require it, and it's a fair amount of work.

It would be nice to have this feature.. Even i am looking for it... tried in different ways but couldn't give that good feel...

Also very interested in this feature

Same!

Also interested!

@lineldcosta can you share your  code/ approach

Cannot use the lib because of this missing feature, otherwise wouldn't have doubted. I feel it's better not to wait for user feedback, many users will just move on without leaving feedback. This is the only lib available that does the private chat window thingy well. I'll be forced to go with a terrible accordion UI approach, but at least I can chat with multiple users.


Make it impossible in the UI to select unsuitable parent pages for page copies/aliases

Let's say you're trying to copy/alias a page ArticlePage and it can have only ArticleIndexPage as a parent. When selecting a new parent page in the UI, you can select any page type for the parent, for example HomePage. If you select unsuitable parent page, you will be redirected to Wagtail admin homepage when submitting and an error will be shown:
"Sorry, you do not have permission to access this area."
This behaviour will happen in Wagtail core models.py, in can_copy_to function.
# reject early if pages of this type cannot be created at the destination
if not self.page.specific_class.can_create_at(destination):
    return False

While this behaviour is correct, it provides quite bad user experience since it's very easy to select wrong parent page and you need to start over.
I would change this so that it's not even possible to select wrong type of parent, by not showing them in the page selector modal at all. If a page is unsuitable type but it has suitable children, then it must be shown so that you can navigate to the correct page, but it should be disabled so that it can't be selected.

As of #8689 / #8647, the "Move" page uses the page chooser UI, which supports restricting which page types are allowed options. Since the Copy page UI also uses the page chooser, I would expect it’d be relatively simple to backport those "Move" view changes to it.


Fix: Add separator line at the beginning of created csv

This fix allows Excel to detect the separator when opening the file and fixing the problem of all of the data shown in the same column.
With this change Excel opens csv like an xls without the need to import the csv data manually and specifying the separator.

@AllenFang did you merge this in master ?? @BernatWozzo


64bit int decode error: Object doesn't support property or method 'readInt32BE'

msgpack.decode([129, 161, 120, 211, 0, 0, 0, 0, 0, 0, 0, 0]);

Result: Object doesn't support property or method `readInt32BE'
I see #1 about true 64-bit integer support, but this is more of a decoder error. I can work around this in my own code (by adding the missing methods, readInt32BE and readUInt32BE). In my case, I'm dealing with data downloaded from an ASP.Net server running a C# implementation of the msgpack protocol where 64-bit integers (long/ulong) are supported natively.

msgpack.decode() requests Buffer instance instead of Array instance.
msgpack.decode(Buffer([129, 161, 120, 211, 0, 0, 0, 0, 0, 0, 0, 0]));

This would work at node.js. See #28.

Now msgpack.decode() accepts Array instance!
msgpack.decode([129, 161, 120, 211, 0, 0, 0, 0, 0, 0, 0, 0]); // => {x: 0}


chore: add updated test for createWithOptions.ts

PR Checklist

[x] Addresses an existing open issue: fixes #874
[x] That issue was marked as status: accepting prs
[x] Steps in CONTRIBUTING.md were taken

Overview
This is a test file for createWithOptions. It tests the logic of createWithOptions..
This PR is an extension of a previous PR, #1119.

I'm happy to make any additional changes, let me know if I missed anything. Thanks!

Btw, this wouldn't be a feat: as it's not user-facing. It'd be a chore: or test:. https://www.conventionalcommits.org

Oh thanks for fixing the name! And thanks for the help tidying this test up! I am stoked to contribute.

Excited to see the coverage jump up >=1% 😄

If you're interested, I bet #872 and #873 would be pretty similar PRs.


cmake: flash: use genexpr to generate runners.yaml

This allows users to modify the contents of the data being
written after the cmake/flash/CMakeLists.txt has been
executed.
Signed-off-by: Håkon Øye Amundsen<EMAIL_ADDRESS>

See https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/2082#issuecomment-607667856 for context

Thanks for your review @tejlmand , one outstanding comment.
Regarding the yaml validation, we could do something like they propose here https://howchoo.com/g/ogewodbhztm/how-to-validate-yaml-from-the-command-line and simply do:
python -c 'import yaml, sys; yaml.safe_load(sys.stdin)' < cfg.yaml

and then check for errors being thrown.

Thanks for your review @tejlmand , one outstanding comment.
Regarding the yaml validation, we could do something like they propose here https://howchoo.com/g/ogewodbhztm/how-to-validate-yaml-from-the-command-line and simply do:
python -c 'import yaml, sys; yaml.safe_load(sys.stdin)' < cfg.yaml

and then check for errors being thrown.

If you can get this in and ideally do it only if there is external content (no reason to launch python for things within Zephyr control), that would be great.
But as this is a nice addition, I approve current status.


Create example for passing data to the popup by extending Marker

It's possible to pass whatever data you want to the Popup by extending Marker and adding the data to the embedded popup. It would be nice to create an example for this.

Hi @rorystephenson,
Thanks for your plugin and for your short explanation about how to give extra data to a Marker, I did not think about it before reading it here!
I created a small example below to illustrate your points, if it does not match with what you wanted to know, feel free to tell me and I will remove/edit it.
import 'package:flutter/material.dart';
import 'package:flutter_map/flutter_map.dart';
import 'package:flutter_map_marker_popup/flutter_map_marker_popup.dart';
import 'package:latlong/latlong.dart';

void main() => runApp(MyApp());
const double MARKER_SIZE = 25;

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Marker with additional data example',
      home: MapPage(),
    );
  }
}

class MapPage extends StatefulWidget {
  MapPage({Key key}) : super(key: key);

  @override
  _MapPageState createState() => _MapPageState();
}

class _MapPageState extends State<MapPage> {
  final PopupController _popupLayerController = PopupController();
  @override
  void initState() {
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: FlutterMap(
        options: MapOptions(
          plugins: <MapPlugin>[PopupMarkerPlugin()],
          center: LatLng(48.857661, 2.295135),
          zoom: 13.0,
          interactive: true,
          onTap: (_) => _popupLayerController.hidePopup(),
        ),
        layers: <LayerOptions>[
          TileLayerOptions(
            urlTemplate: 'https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png',
            subdomains: <String>['a', 'b', 'c'],
          ),
          PopupMarkerLayerOptions(
            markers: <Marker>[
              MonumentMarker(
                monument: Monument(
                  name: 'Eiffel Tower',
                  imagePath:
                      'https://cdn.lifestyleasia.com/wp-content/uploads/2019/10/21224220/Winer-Parisienne.jpg',
                  lat: 48.857661,
                  long: 2.295135,
                ),
              ),
              Marker(
                anchorPos: AnchorPos.align(AnchorAlign.top),
                point: LatLng(48.859661, 2.305135),
                height: MARKER_SIZE,
                width: MARKER_SIZE,
                builder: (BuildContext ctx) => Icon(Icons.shop),
              ),
            ],
            popupController: _popupLayerController,
            popupBuilder: (_, Marker marker) {
              if (marker is MonumentMarker) {
                return MonumentMarkerPopup(monument: marker.monument);
              }
              return Card(child: const Text('Not a monument'));
            },
          ),
        ],
      ),
    );
  }
}

class Monument {
  Monument({this.name, this.imagePath, this.lat, this.long});

  final String name;
  final String imagePath;
  final double lat;
  final double long;
}

class MonumentMarker extends Marker {
  MonumentMarker({@required this.monument})
      : super(
          anchorPos: AnchorPos.align(AnchorAlign.top),
          height: MARKER_SIZE,
          width: MARKER_SIZE,
          point: LatLng(monument.lat, monument.long),
          builder: (BuildContext ctx) => Icon(Icons.camera_alt),
        );

  final Monument monument;
}

class MonumentMarkerPopup extends StatelessWidget {
  const MonumentMarkerPopup({Key key, this.monument}) : super(key: key);
  final Monument monument;

  @override
  Widget build(BuildContext context) {
    return Container(
      width: 200,
      child: Card(
        shape: RoundedRectangleBorder(
          borderRadius: BorderRadius.circular(15),
        ),
        child: Column(
          mainAxisSize: MainAxisSize.min,
          children: <Widget>[
            Image.network(monument.imagePath, width: 200),
            Text(monument.name),
            Text('${monument.lat}-${monument.long}'),
          ],
        ),
      ),
    );
  }
}

Finally got around to adding this. Thanks a lot @flogaribal !
https://github.com/rorystephenson/flutter_map_marker_popup/commit/697c38df46916e2c77d74db54f3b7a94fc76f909

Hello after a few days of trying to pass values to markers I finally came and found this thread. Unfortunately the example is not updated to null safety. I attempted to do this but ran into some issues with the _popupLayerController stating that "The argument type 'void Function(TapPosition)' can't be assigned to the parameter type 'void Function(TapPosition, LatLng)?'." The latlong package needed to be changed to latlong2 to support null safety, but I'm not sure if this is what's causing the problem as I'm a fairly new programmer. Long story short, is there any way this example can be updated to Null Safety. I'm quite looking forward to being able to pass values to my markers but my programming skill is coming up short. Long story short, any way this example could be updated to work with null safety or the error I'm getting? Or any suggestions period? Thanks !

@giroprotagonist thanks for pointing that out! It should be fixed now.

Ah that was easy enough, thank you, very much appreciated!


Invalid behavior Pressable in ScrollView

Description
The delayPressIn was set to 0 in this commit. https://github.com/facebook/react-native/commit/86ffb9c41e033f59599e01b7ad016706b5f62fc8. This removes the delay for pressing a button. This is fine if the button is not in a ScrollView but this delay is designed to not trigger pressIn while scrolling (see native iOS touchables). So basically every Pressable that's being used in a ScrollView has invalid behavior.
React Native version:
0.63.4
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Put a pressable in a ScrollView
Try to scroll above a button
The button triggers

Expected Results
There should be a way to set this delay (it is delayPressIn is not available on the Pressable component). I think it best to:

Set the default back to 130ms
make the delay configurable on the Pressable component

This is because in my experience most Pressables are part of a ScrollView, and if they're not part of a ScrollView, the small delay is unnoticeable (it might even be the same for native controls). If a delay of 130ms is not acceptable (perhaps in a game scenario or something like that) it can be configured.

Does anyone have answer for this problem. I have a Pressable in ScrollView, but the pressable doesn't let me scroll because the scroll trigers the press event

Hello @Firesoul18 , @jfrolich :)
I have exactly the same problem (I've already asked the question here, but no relevant answer). Have you found a solution?

Hey, I just stumbled upon the same issue I have a Pressable (a big one) inside a ScrollView and whenever I try to scroll by starting my gesture on the Pressable it triggers the click action.
The way I fixed this is by changing the press action handler from onPressIn to onPress.
Hope this helps.


Cusome by

Resolves #2338
Description

What is the purpose of this pull request?
The purpose of this pull request is to introduce the @stdlib/iter/cusome-by package, which provides a transform iterator to determine if at least n values from a source iterator satisfy a given predicate function. This new feature enhances the library by allowing cumulative testing of iterated values.

This pull request:

adds the feature of cusome-by function for stdib

Related Issues

Does this pull request have any related issues?

No

This pull request:

resolves #2338
fixes #2338

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

@kgryte Please review this PR .

@vivek-anand-singh Also, in your OP, you removed the checkbox indicating that you have read the contributing guidelines. Without that checkbox, we cannot accept your PR. Please be sure to include that before any further review.