vds build command failed.

Hello.
I do run Android Studio 3.1.3.
I want to know what is the error for the command.
Build command failed.
Error while executing process /Users/peter/Library/Android/sdk/cmake/3.6.4111459/bin/cmake with arguments {--build /Users/peter/devel/Android/vds/android/app/.externalNativeBuild/cmake/debug/x86 --target vds_embedded}
[1/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/app.cpp.o
[2/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/async_task.cpp.o
[3/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/barrier.cpp.o
[4/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/binary_serialize.cpp.o
[5/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/command_line.cpp.o
[6/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/const_data_buffer.cpp.o
[7/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/encoding.cpp.o
[8/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/file.cpp.o
[9/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/filename.cpp.o
[10/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/foldername.cpp.o
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/async_task.cpp:1:
../../../../../../kernel/vds_core/async_task.h:91:28: warning: while loop has empty body [-Wempty-body]
while(this->process());
^
../../../../../../kernel/vds_core/async_task.h:91:28: note: put the semicolon on a separate line to silence this warning
../../../../../../kernel/vds_core/async_task.h:866:9: warning: '~result_callback' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2233:5: note: in instantiation of member function 'vds::async_result<>::result_callback::~result_callback' requested here
delete __ptr;
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2546:7: note: in instantiation of member function 'std::__ndk1::default_delete<vds::async_result<>::result_callback>::operator()' requested here
_ptr.second()(__tmp);
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2500:19: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::reset' requested here
~unique_ptr() { reset(); }
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:3961:21: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::~unique_ptr' requested here
unique_ptr<_Yp> __hold(_p);
^
../../../../../../kernel/vds_core/async_task.h:822:4: note: in instantiation of function template specialization 'std::ndk1::shared_ptr<vds::async_result<>::result_callback>::shared_ptr<vds::async_result<>::result_callback>' requested here
: impl(new result_callback(token, owner, std::move(callback)))
^
../../../../../../kernel/vds_core/async_task.h:655:5: note: in instantiation of member function 'vds::async_result<>::async_result' requested here
async_result<result_types...>(
^
../../../../../../kernel/vds_core/async_task.h:894:11: note: in instantiation of function template specialization 'vds::async_task<>::execute<(lambda at ../../../../../../kernel/vds_core/async_task.h:895:9)>' requested here
arg.execute(
^
../../../../../../kernel/vds_core/async_task.h:163:7: note: destructor has a implicit non-throwing exception specification
~result_callback();
^
2 warnings generated.
[11/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/logger.cpp.o
[12/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/mt_service.cpp.o
[13/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/persistence.cpp.o
[14/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/service_provider.cpp.o
[15/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/shutdown_event.cpp.o
[16/131] Building CXX object kernel/vds_core/CMakeFiles/vds_core.dir/shutdown_exception.cpp.o
FAILED: /Users/peter/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++  --target=i686-none-linux-android --gcc-toolchain=/Users/peter/Library/Android/sdk/ndk-bundle/toolchains/x86-4.9/prebuilt/darwin-x86_64 --sysroot=/Users/peter/Library/Android/sdk/ndk-bundle/sysroot   -Ikernel/vds_core -I../../../../../../kernel/vds_core -isystem /Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include -isystem /Users/peter/Library/Android/sdk/ndk-bundle/sources/android/support/include -isystem /Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++abi/include -isystem /Users/peter/Library/Android/sdk/ndk-bundle/sysroot/usr/include/i686-linux-android -D__ANDROID_API=15 -g -DANDROID -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -mstackrealign -Wa,--noexecstack -Wformat -Werror=format-security -std=c++11 -std=c++14 -frtti -fexceptions -std=c++14 -fPIC -O0 -fno-limit-debug-info  -DDEBUG -Wall -Werror=return-type -MD -MT kernel/vds_core/CMakeFiles/vds_core.dir/foldername.cpp.o -MF kernel/vds_core/CMakeFiles/vds_core.dir/foldername.cpp.o.d -o kernel/vds_core/CMakeFiles/vds_core.dir/foldername.cpp.o -c /Users/peter/devel/Android/vds/kernel/vds_core/foldername.cpp
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/foldername.cpp:18:
In file included from ../../../../../../kernel/vds_core/file.h:16:
../../../../../../kernel/vds_core/async_task.h:91:28: warning: while loop has empty body [-Wempty-body]
while(this->process());
^
../../../../../../kernel/vds_core/async_task.h:91:28: note: put the semicolon on a separate line to silence this warning
/Users/peter/devel/Android/vds/kernel/vds_core/foldername.cpp:227:11: error: no matching constructor for initialization of 'statvfs'
if(0 != statvfs(this->local_name().c_str(), &buf)){
^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/peter/Library/Android/sdk/ndk-bundle/sysroot/usr/include/sys/statvfs.h:46:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
struct statvfs { __STATVFS64_BODY };
^
/Users/peter/Library/Android/sdk/ndk-bundle/sysroot/usr/include/sys/statvfs.h:46:8: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided
/Users/peter/Library/Android/sdk/ndk-bundle/sysroot/usr/include/sys/statvfs.h:46:8: note: candidate constructor (the implicit default constructor) not viable: requires 0 arguments, but 2 were provided
/Users/peter/devel/Android/vds/kernel/vds_core/foldername.cpp:250:11: error: no matching constructor for initialization of 'statvfs'
if(0 != statvfs(this->local_name().c_str(), &buf)){
^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/peter/Library/Android/sdk/ndk-bundle/sysroot/usr/include/sys/statvfs.h:46:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
struct statvfs { __STATVFS64_BODY };
^
/Users/peter/Library/Android/sdk/ndk-bundle/sysroot/usr/include/sys/statvfs.h:46:8: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided
/Users/peter/Library/Android/sdk/ndk-bundle/sysroot/usr/include/sys/statvfs.h:46:8: note: candidate constructor (the implicit default constructor) not viable: requires 0 arguments, but 2 were provided
1 warning and 2 errors generated.
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/file.cpp:4:
In file included from ../../../../../../kernel/vds_core/file.h:16:
../../../../../../kernel/vds_core/async_task.h:91:28: warning: while loop has empty body [-Wempty-body]
while(this->process());
^
../../../../../../kernel/vds_core/async_task.h:91:28: note: put the semicolon on a separate line to silence this warning
../../../../../../kernel/vds_core/async_task.h:866:9: warning: '~result_callback' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2233:5: note: in instantiation of member function 'vds::async_result<>::result_callback::~result_callback' requested here
delete __ptr;
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2546:7: note: in instantiation of member function 'std::__ndk1::default_delete<vds::async_result<>::result_callback>::operator()' requested here
_ptr.second()(__tmp);
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2500:19: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::reset' requested here
~unique_ptr() { reset(); }
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:3961:21: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::~unique_ptr' requested here
unique_ptr<_Yp> __hold(__p);
^
../../../../../../kernel/vds_core/async_task.h:822:4: note: in instantiation of function template specialization 'std::_ndk1::shared_ptr<vds::async_result<>::result_callback>::shared_ptr<vds::async_result<>::result_callback>' requested here
: impl(new result_callback(token, owner, std::move(callback)))
^
../../../../../../kernel/vds_core/async_task.h:655:5: note: in instantiation of member function 'vds::async_result<>::async_result' requested here
async_result<result_types...>(
^
../../../../../../kernel/vds_core/async_task.h:894:11: note: in instantiation of function template specialization 'vds::async_task<>::execute<(lambda at ../../../../../../kernel/vds_core/async_task.h:895:9)>' requested here
arg.execute(
^
../../../../../../kernel/vds_core/async_task.h:163:7: note: destructor has a implicit non-throwing exception specification
~result_callback();
^
2 warnings generated.
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/app.cpp:7:
In file included from ../../../../../../kernel/vds_core/app.h:25:
In file included from ../../../../../../kernel/vds_core/service_provider.h:11:
../../../../../../kernel/vds_core/async_task.h:91:28: warning: while loop has empty body [-Wempty-body]
while(this->process());
^
../../../../../../kernel/vds_core/async_task.h:91:28: note: put the semicolon on a separate line to silence this warning
../../../../../../kernel/vds_core/async_task.h:866:9: warning: '~result_callback' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2233:5: note: in instantiation of member function 'vds::async_result<>::result_callback::~result_callback' requested here
delete __ptr;
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2546:7: note: in instantiation of member function 'std::__ndk1::default_delete<vds::async_result<>::result_callback>::operator()' requested here
_ptr.second()(__tmp);
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2500:19: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::reset' requested here
~unique_ptr() { reset(); }
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:3961:21: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::~unique_ptr' requested here
unique_ptr<_Yp> __hold(__p);
^
../../../../../../kernel/vds_core/async_task.h:822:4: note: in instantiation of function template specialization 'std::_ndk1::shared_ptr<vds::async_result<>::result_callback>::shared_ptr<vds::async_result<>::result_callback>' requested here
: impl(new result_callback(token, owner, std::move(callback)))
^
../../../../../../kernel/vds_core/async_task.h:655:5: note: in instantiation of member function 'vds::async_result<>::async_result' requested here
async_result<result_types...>(
^
../../../../../../kernel/vds_core/async_task.h:894:11: note: in instantiation of function template specialization 'vds::async_task<>::execute<(lambda at ../../../../../../kernel/vds_core/async_task.h:895:9)>' requested here
arg.execute(
^
../../../../../../kernel/vds_core/async_task.h:163:7: note: destructor has a implicit non-throwing exception specification
~result_callback();
^
../../../../../../kernel/vds_core/async_task.h:636:7: warning: '~async_task' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
../../../../../../kernel/vds_core/service_provider.h:95:14: note: in instantiation of member function 'vds::async_task<>::~async_task' requested here
return async_task<>::empty();
^
../../../../../../kernel/vds_core/async_task.h:302:4: note: destructor has a implicit non-throwing exception specification
~async_task();
^
3 warnings generated.
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/persistence.cpp:8:
In file included from ../../../../../../kernel/vds_core/persistence.h:10:
In file included from ../../../../../../kernel/vds_core/service_provider.h:11:
../../../../../../kernel/vds_core/async_task.h:91:28: warning: while loop has empty body [-Wempty-body]
while(this->process());
^
../../../../../../kernel/vds_core/async_task.h:91:28: note: put the semicolon on a separate line to silence this warning
../../../../../../kernel/vds_core/async_task.h:866:9: warning: '~result_callback' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2233:5: note: in instantiation of member function 'vds::async_result<>::result_callback::~result_callback' requested here
delete __ptr;
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2546:7: note: in instantiation of member function 'std::__ndk1::default_delete<vds::async_result<>::result_callback>::operator()' requested here
_ptr.second()(__tmp);
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2500:19: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::reset' requested here
~unique_ptr() { reset(); }
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:3961:21: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::~unique_ptr' requested here
unique_ptr<_Yp> __hold(__p);
^
../../../../../../kernel/vds_core/async_task.h:822:4: note: in instantiation of function template specialization 'std::_ndk1::shared_ptr<vds::async_result<>::result_callback>::shared_ptr<vds::async_result<>::result_callback>' requested here
: impl(new result_callback(token, owner, std::move(callback)))
^
../../../../../../kernel/vds_core/async_task.h:655:5: note: in instantiation of member function 'vds::async_result<>::async_result' requested here
async_result<result_types...>(
^
../../../../../../kernel/vds_core/async_task.h:894:11: note: in instantiation of function template specialization 'vds::async_task<>::execute<(lambda at ../../../../../../kernel/vds_core/async_task.h:895:9)>' requested here
arg.execute(
^
../../../../../../kernel/vds_core/async_task.h:163:7: note: destructor has a implicit non-throwing exception specification
~result_callback();
^
../../../../../../kernel/vds_core/async_task.h:636:7: warning: '~async_task' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
../../../../../../kernel/vds_core/service_provider.h:95:14: note: in instantiation of member function 'vds::async_task<>::~async_task' requested here
return async_task<>::empty();
^
../../../../../../kernel/vds_core/async_task.h:302:4: note: destructor has a implicit non-throwing exception specification
~async_task();
^
3 warnings generated.
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/logger.cpp:7:
In file included from ../../../../../../kernel/vds_core/logger.h:15:
In file included from ../../../../../../kernel/vds_core/service_provider.h:11:
../../../../../../kernel/vds_core/async_task.h:91:28: warning: while loop has empty body [-Wempty-body]
while(this->process());
^
../../../../../../kernel/vds_core/async_task.h:91:28: note: put the semicolon on a separate line to silence this warning
../../../../../../kernel/vds_core/async_task.h:866:9: warning: '~result_callback' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2233:5: note: in instantiation of member function 'vds::async_result<>::result_callback::~result_callback' requested here
delete __ptr;
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2546:7: note: in instantiation of member function 'std::__ndk1::default_delete<vds::async_result<>::result_callback>::operator()' requested here
_ptr.second()(__tmp);
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2500:19: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::reset' requested here
~unique_ptr() { reset(); }
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:3961:21: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::~unique_ptr' requested here
unique_ptr<_Yp> __hold(__p);
^
../../../../../../kernel/vds_core/async_task.h:822:4: note: in instantiation of function template specialization 'std::_ndk1::shared_ptr<vds::async_result<>::result_callback>::shared_ptr<vds::async_result<>::result_callback>' requested here
: impl(new result_callback(token, owner, std::move(callback)))
^
../../../../../../kernel/vds_core/async_task.h:655:5: note: in instantiation of member function 'vds::async_result<>::async_result' requested here
async_result<result_types...>(
^
../../../../../../kernel/vds_core/async_task.h:894:11: note: in instantiation of function template specialization 'vds::async_task<>::execute<(lambda at ../../../../../../kernel/vds_core/async_task.h:895:9)>' requested here
arg.execute(
^
../../../../../../kernel/vds_core/async_task.h:163:7: note: destructor has a implicit non-throwing exception specification
~result_callback();
^
../../../../../../kernel/vds_core/async_task.h:636:7: warning: '~async_task' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
../../../../../../kernel/vds_core/service_provider.h:95:14: note: in instantiation of member function 'vds::async_task<>::~async_task' requested here
return async_task<>::empty();
^
../../../../../../kernel/vds_core/async_task.h:302:4: note: destructor has a implicit non-throwing exception specification
~async_task();
^
3 warnings generated.
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/mt_service.cpp:6:
In file included from ../../../../../../kernel/vds_core/mt_service.h:9:
In file included from ../../../../../../kernel/vds_core/service_provider.h:11:
../../../../../../kernel/vds_core/async_task.h:91:28: warning: while loop has empty body [-Wempty-body]
while(this->process());
^
../../../../../../kernel/vds_core/async_task.h:91:28: note: put the semicolon on a separate line to silence this warning
/Users/peter/devel/Android/vds/kernel/vds_core/mt_service.cpp:148:8: warning: unused variable 'thread_id' [-Wunused-variable]
auto thread_id = syscall(SYS_gettid);
^
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/mt_service.cpp:6:
In file included from ../../../../../../kernel/vds_core/mt_service.h:9:
In file included from ../../../../../../kernel/vds_core/service_provider.h:11:
../../../../../../kernel/vds_core/async_task.h:866:9: warning: '~result_callback' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2233:5: note: in instantiation of member function 'vds::async_result<>::result_callback::~result_callback' requested here
delete __ptr;
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2546:7: note: in instantiation of member function 'std::__ndk1::default_delete<vds::async_result<>::result_callback>::operator()' requested here
_ptr.second()(__tmp);
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2500:19: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::reset' requested here
~unique_ptr() { reset(); }
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:3961:21: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::~unique_ptr' requested here
unique_ptr<_Yp> __hold(__p);
^
../../../../../../kernel/vds_core/async_task.h:822:4: note: in instantiation of function template specialization 'std::_ndk1::shared_ptr<vds::async_result<>::result_callback>::shared_ptr<vds::async_result<>::result_callback>' requested here
: impl(new result_callback(token, owner, std::move(callback)))
^
../../../../../../kernel/vds_core/async_task.h:655:5: note: in instantiation of member function 'vds::async_result<>::async_result' requested here
async_result<result_types...>(
^
../../../../../../kernel/vds_core/async_task.h:894:11: note: in instantiation of function template specialization 'vds::async_task<>::execute<(lambda at ../../../../../../kernel/vds_core/async_task.h:895:9)>' requested here
arg.execute(
^
../../../../../../kernel/vds_core/async_task.h:163:7: note: destructor has a implicit non-throwing exception specification
~result_callback();
^
../../../../../../kernel/vds_core/async_task.h:636:7: warning: '~async_task' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
../../../../../../kernel/vds_core/service_provider.h:95:14: note: in instantiation of member function 'vds::async_task<>::~async_task' requested here
return async_task<>::empty();
^
../../../../../../kernel/vds_core/async_task.h:302:4: note: destructor has a implicit non-throwing exception specification
~async_task();
^
4 warnings generated.
In file included from /Users/peter/devel/Android/vds/kernel/vds_core/service_provider.cpp:9:
In file included from ../../../../../../kernel/vds_core/service_provider.h:11:
../../../../../../kernel/vds_core/async_task.h:91:28: warning: while loop has empty body [-Wempty-body]
while(this->process());
^
../../../../../../kernel/vds_core/async_task.h:91:28: note: put the semicolon on a separate line to silence this warning
../../../../../../kernel/vds_core/async_task.h:866:9: warning: '~result_callback' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2233:5: note: in instantiation of member function 'vds::async_result<>::result_callback::~result_callback' requested here
delete __ptr;
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2546:7: note: in instantiation of member function 'std::__ndk1::default_delete<vds::async_result<>::result_callback>::operator()' requested here
_ptr.second()(__tmp);
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:2500:19: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::reset' requested here
~unique_ptr() { reset(); }
^
/Users/peter/Library/Android/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/include/memory:3961:21: note: in instantiation of member function 'std::__ndk1::unique_ptr<vds::async_result<>::result_callback, std::__ndk1::default_delete<vds::async_result<>::result_callback> >::~unique_ptr' requested here
unique_ptr<_Yp> __hold(__p);
^
../../../../../../kernel/vds_core/async_task.h:822:4: note: in instantiation of function template specialization 'std::_ndk1::shared_ptr<vds::async_result<>::result_callback>::shared_ptr<vds::async_result<>::result_callback>' requested here
: impl(new result_callback(token, owner, std::move(callback)))
^
../../../../../../kernel/vds_core/async_task.h:655:5: note: in instantiation of member function 'vds::async_result<>::async_result' requested here
async_result<result_types...>(
^
../../../../../../kernel/vds_core/async_task.h:894:11: note: in instantiation of function template specialization 'vds::async_task<>::execute<(lambda at ../../../../../../kernel/vds_core/async_task.h:895:9)>' requested here
arg.execute(
^
../../../../../../kernel/vds_core/async_task.h:163:7: note: destructor has a implicit non-throwing exception specification
~result_callback();
^
../../../../../../kernel/vds_core/async_task.h:636:7: warning: '~async_task' has a non-throwing exception specification but can still throw [-Wexceptions]
throw std::runtime_error("Task without execute");
^
../../../../../../kernel/vds_core/service_provider.h:95:14: note: in instantiation of member function 'vds::async_task<>::~async_task' requested here
return async_task<>::empty();
^
../../../../../../kernel/vds_core/async_task.h:302:4: note: destructor has a implicit non-throwing exception specification
~async_task();
^
3 warnings generated.
ninja: build stopped: subcommand failed.

Hello!
This project not released yet. Sorry.


[bug] line seperator in conjunction with heading

it seems to be a kind of a follow up to #4... but definitively something weird is going on:
"heading2" (no matter if you use ## before or --- underneath) gets underlined... some phraser underline "heading1" and "heading2", but according to CommonMark no heading is underlined by default!
so either "heading1" and "heading2" should be underlined or none, which is IMHO the correct resp. better choice because you can still ad a line separator (---) if you want to.

This is an issue with the default style (from github) -> heading have an underline
Please select another css if you dont like that style.


Dashboard for monitoring latency (mvp)

Problem
We should monitor our health from a latency perspective over time
Potential solutions
Ideas for dashboard
Topline average TTR and TTV + time filter (-1hr, -24hrs, -7day ,-30day)
Plots fast transfer TTV as a time series
Plots slow transfer TTR as a time series
Additional info
ex/

ex/
SELECT
	transfer_hour,
	CASE
		WHEN origin_chain = '6648936' THEN 'Ethereum'
		WHEN origin_chain = '1869640809' THEN 'Optimism'
		WHEN origin_chain = '6450786' THEN 'BNB'
		WHEN origin_chain = '6778479' THEN 'Gnosis'
		WHEN origin_chain = '1886350457' THEN 'Polygon'
		WHEN origin_chain = '1634886255' THEN 'Ethereum'
		WHEN origin_chain = '6648936' THEN 'Arbitrum One'
		ELSE 'Error'
	END AS origin,
	CASE
		WHEN destination_chain = '6648936' then 'Ethereum'
		WHEN destination_chain = '1869640809' then 'Optimism'
		WHEN destination_chain = '6450786' then 'BNB'
		WHEN destination_chain = '6778479' then 'Gnosis'
		WHEN destination_chain = '1886350457' then 'Polygon'
		WHEN destination_chain = '1634886255' then 'Ethereum'
		WHEN destination_chain = '6648936' then 'Arbitrum One'
		ELSE 'Error'
	END AS destination,
	avg(fastpath_avg_ttv_in_secs) / 60 AS TTV_fast_avg_mins_allchains,
	avg(fastpath_avg_ttr_in_secs) / 60 AS TTR_fast_avg_mins_allchains,
	avg(slowpath_avg_ttr_in_secs) / 60 AS TTR_slow_avg_mins_allchains,
	avg(slowpath_avg_ttv_in_secs) / 60 AS TTV_slow_avg_mins_allchains
FROM
	hourly_transfer_metrics
WHERE
	transfer_hour >= '2023-01-21 00:00:00+00'
	AND (slowpath_avg_ttv_in_secs IS NOT NULL
		OR slowpath_avg_ttr_in_secs IS NOT NULL
		OR fastpath_avg_ttv_in_secs IS NOT NULL
		OR fastpath_avg_ttr_in_secs IS NOT NULL)
GROUP BY
	transfer_hour, origin_chain, destination_chain
ORDER BY transfer_hour DESC

Topline averages
SELECT
	transfer_hour,
	avg(fastpath_avg_ttv_in_secs) / 60 AS TTV_fast_avg_mins_allchains,
	avg(fastpath_avg_ttr_in_secs) / 60 AS TTR_fast_avg_mins_allchains,
	avg(slowpath_avg_ttr_in_secs) / 60 AS TTR_slow_avg_mins_allchains,
	avg(slowpath_avg_ttv_in_secs) / 60 AS TTV_slow_avg_mins_allchains
FROM
	hourly_transfer_metrics
WHERE
	transfer_hour >= '2023-01-21 00:00:00+00'
	AND (slowpath_avg_ttv_in_secs IS NOT NULL
		OR slowpath_avg_ttr_in_secs IS NOT NULL
		OR fastpath_avg_ttv_in_secs IS NOT NULL
		OR fastpath_avg_ttr_in_secs IS NOT NULL)
GROUP BY
1
ORDER BY 1 DESC

Chain averages
SELECT
	transfer_hour,
	CASE
		WHEN origin_chain = '6648936' THEN 'Ethereum'
		WHEN origin_chain = '1869640809' THEN 'Optimism'
		WHEN origin_chain = '6450786' THEN 'BNB'
		WHEN origin_chain = '6778479' THEN 'Gnosis'
		WHEN origin_chain = '1886350457' THEN 'Polygon'
		WHEN origin_chain = '1634886255' THEN 'Arbitrum One'
		ELSE 'Error'
	END AS origin,
	CASE
		WHEN destination_chain = '6648936' then 'Ethereum'
		WHEN destination_chain = '1869640809' then 'Optimism'
		WHEN destination_chain = '6450786' then 'BNB'
		WHEN destination_chain = '6778479' then 'Gnosis'
		WHEN destination_chain = '1886350457' then 'Polygon'
		WHEN destination_chain = '1634886255' THEN 'Arbitrum One'
		ELSE 'Error'
	END AS destination,
	avg(fastpath_avg_ttv_in_secs) / 60 AS TTV_fast_avg_mins_allchains,
	avg(fastpath_avg_ttr_in_secs) / 60 AS TTR_fast_avg_mins_allchains,
	avg(slowpath_avg_ttr_in_secs) / 60 AS TTR_slow_avg_mins_allchains,
	avg(slowpath_avg_ttv_in_secs) / 60 AS TTV_slow_avg_mins_allchains
FROM
	hourly_transfer_metrics
WHERE
	transfer_hour >= '2023-01-21 00:00:00+00'
	AND (slowpath_avg_ttv_in_secs IS NOT NULL
		OR slowpath_avg_ttr_in_secs IS NOT NULL
		OR fastpath_avg_ttv_in_secs IS NOT NULL
		OR fastpath_avg_ttr_in_secs IS NOT NULL)
	--AND origin_chain = '1869640809'
	--AND destination_chain = '1634886255'
GROUP BY
	1, origin_chain, destination_chain
ORDER BY 1 DESC

@alexwhte where can we get these above data? could you share us the endpoints?

no longer relevant, will handle another way


Remove unneeded types

[x] tests and linter show no problems (npm t)
[x] code is properly formatted (npm run fmt)

Landed in https://github.com/metarhia/impress/commit/6e6ea1c8b307d74d4950a45a9e53b84e5b5c784f


[Feature Request]: Configurable DynamoDB url

Feature Description
Please add the ability to set the url for DynamoDB. A suggestion would be to get it from environment variables
Reason
I am interested in using the DynamoDB implementation for document storage, however, I noticed that the boto3 initialization does not give me the ability to specify the url to use for DynamoDB.
Value of Feature
This would help out greatly in development environments where DynamoDB is hosted locally.

This is how I feel we can address the issue. Your thoughts?
@classmethod
def from_table_name(cls, table_name: str) -> DynamoDBKVStore:
"""Load a DynamoDBKVStore from a DynamoDB table name.
Args:
table_name (str): DynamoDB table name """
try:
import boto3
except ImportError:
raise ImportError(IMPORT_ERROR_MSG)
# Get the DynamoDB URL from environment variable
dynamodb_url = os.getenv('DYNAMODB_URL')
# Create a session
session = boto3.Session()
# If the DynamoDB URL is set, use it as the endpoint URL
if dynamodb_url is not None:
ddb = session.resource("dynamodb", endpoint_url=dynamodb_url)
else:
# Otherwise, let boto3 use its default configuration
ddb = session.resource("dynamodb")
return cls(table=ddb.Table(table_name))

The only change I would make is the conditional. It should only need if dynamodb_url:


How to initialize a keras tensor employed in an API model

I am trying to implemente a Memory-augmented neural network, in which the memory and the read/write/usage weight vectors are updated according to a combination of their previous values. These weigths are different from the classic weight matrices between layers that are automatically updated with the fit() function! My problem is the following: how can I correctly initialize these weights as keras tensors and use them in the model? I explain it better with the following simplified example.
My API model is something like:
      input = Input(shape=(5,6))
      controller = LSTM(20, activation='tanh',stateful=False, return_sequences=True)(input)
      write_key = Dense(4,activation='tanh')(controller)
      read_key = Dense(4,activation='tanh')(controller)
      w_w = add([w_u, w_r])                            #<---- UPDATE OF WRITE WEIGHTS
      to_write = dot([w_w, write_key])
      M = add([M,to_write])                                       #<---- UPDATE OF MEMORY
      cos_sim = dot([M,read_key])
      w_r = Lambda(lambda x: softmax(x,axis=1))(cos_sim) #<---- UPDATE OF READ WEIGHTS
      w_u = add([w_u,w_r,w_w])                         #<---- UPDATE OF USAGE WEIGHTS
      retrieved_memory = dot([w_r,M])
      controller_output = concatenate([controller,retrieved_memory])
      final_output = Dense(6,activation='sigmoid')(controller_output)

You` can see that, in order to compute w_w^t, I have to have first defined w_r^{t-1} and w_u^{t-1}. So, at the beginning I have to provide a valid initialization for these vectors. What is the best way to do it? The initialization commands I would like to use are:
       M = K.variable(numpy.zeros((10,4)))       # MEMORY
       w_r = K.variable(numpy.zeros((1,10)))     # READ WEIGHTS
       w_u = K.variable(numpy.zeros((1,10)))     # USAGE WEIGHTS

But, analogously to what said in #2486(entron), these commands do not return a keras tensor with all the needed meta-data and so this returns the following error:

'NoneType' object has no attribute 'inbound_nodes'

I also thought to use the old M, w_r and w_u as further inputs at each iteration and analogously get in output the same variables to complete the loop. But this means that I have to use the fit() function to train online the model having just the target as final output (Model 1), and employ the predict() function on the model with all the secondary outputs (Model 2) to get the variables to use at the next iteration. I have also to pass the weigth matrices from Model 1 to Model 2 using get_weights() and set_weights(). As you can see, it becomes a little bit messy and too slow.
Do you have any suggestions for this problem?
P.S. Please, do not focus too much on the API model above because it is a simplified (almost meaningless) version of the complete one where I skipped several key steps.

How did you manage to solve this problem?

Actually I did not. I think keras does not support initialization and cumulative variables during the training. In fact I see that all public codes of memory-augmented network that require this kind of mechanisms are developed in tensorflow, using mainly the scan function to iterate the training step using an initializer. Right now, I am moving in this direction.

Thanks a lot @martin592 . Can you please point me to some the links that has done this in Tensorflow?

 Here is the main reference code from hmishra2250 that I am using right now: https://github.com/hmishra2250.


@radix-ui/react-label - role="label" is invalid

Bug report
Running react-label component through jest-axe produces an accessibility error:
    "ARIA roles used must conform to valid values (aria-roles)"

    Fix all of the following:
      Role must be one of the valid ARIA roles: label

    You can find more information on this issue here:
    https://dequeuniversity.com/rules/axe/4.2/aria-roles?application=axeAPI

I believe it is caused by role="label" being applied on the element.
Looking at the guidelines for axe core and the list of WAI-ARIA roles on Mozilla it doesn't appear that role="label" is valid.
Current Behavior
Using the component results in the following HTML:
import { Root } from "@radix-ui/react-label";

<Root>My Label</Root>

My Label

Expected behavior
Not exactly sure. Would using a label HTML element be a viable solution?
My Label

Reproducible example
CodeSandbox Example
Run tests => See Problems
Thank you!

This issue is a duplicate of #638 where we've explained original thoughts.
That said, we are also investigating if we can now rely on native label in #1233.
I'll close this issue now.


Is there official guide to build this lib and extend the command

Hi
Is there official guide to build this lib and extend the command?
thanks

Welcome @quantrpeter 👋🏻
I would recommend that you read the project guides linked below
https://github.com/pnp/office365-cli/blob/master/docs/guides/index.md

Hey @quantrpeter did the guide help you?
Feel free to reach out if you have any further questions.

@garrytrinder your guide is perfect, thanks

Great @quantrpeter 👍🏻
If you'd like to get involved with helping building new commands for the CLI, I'd recommend taking a look through the below list of issues.
If there is a command you want to start work on, just let us know in the comments 😀
https://github.com/pnp/office365-cli/issues?q=is%3Aopen+is%3Aissue+label%3A"help+wanted"+label%3A"good+first+issue"


Consumer group Issue

Hi James,
We are using Kafka net in our project. Everything looks good  except to achieve consumer group in order to make kafka as Queue model.
Right now there is no option to achieve consumer group.
As we know you are already working on that. Is there any possible to achieve consumer group.
May i know when it will be released? Next build will it have AutoCommit feature?
One more clarification regarding producer response. Currently we are getting response after sending message through await keyword
var x= client.SendMessageAsync();
var response = await x;
Is there any alternate solution available to get response?
Thanks,
Sugumar J

I'm also looking for a solution to achieve group consumer within kafka-net

I'm also looking for a solution to achieve group consumer within kafka-net

Is there any solution on how my two consumers in the same group receives identical messages without specifying partitionId ? I really need this crack to work with .Net.

I'm working on a fully featured Kafka client for .net, which has working consumer groups: https://github.com/ah-/rdkafka-dotnet

This is awesome @ah- Haider - This is exactly what I was looking for.
I am so thankful to you that you made it possible to enabled the autocommit property for consumer.
Thank you so much again.
Is anything pending or r you improving on this solution?

It's mostly complete and somewhat stable now. I'm basically waiting for a release of https://github.com/edenhill/librdkafka, then I'll do a proper release myself.
That said, it is still fresh code, so do some testing yourself. But if you find any issues I'm happy to fix them.

I will do much testing in this as i was desperately looking for autocommit
functionality.... So far i have tested this with billions of messages in
qeue and that works as i want... But will let u know uf find anything
interesting.
Thanks again Haider.
On Thursday, February 25, 2016, Andreas Heider<EMAIL_ADDRESS>wrote:

It's mostly complete and somewhat stable now. I'm basically waiting for a
release of https://github.com/edenhill/librdkafka, then I'll do a proper
release myself.
That said, it is still fresh code, so do some testing yourself. But if you
find any issues I'm happy to fix them.
—
Reply to this email directly or view it on GitHub
https://github.com/Jroland/kafka-net/issues/75#issuecomment-188984134.

--
Thanks & Regards
Niral Patel
917-912-1308


Recognize contributor of #20310

@bot-gradle test and merge

OK, I've already triggered a build for you.


Add sample settings for cronjob

Added detail instruction here: https://github.com/KyberNetwork/widget-woocommerce/wiki/Transaction-monitor


Add CLI command to remove dependencies

Implemented a new cli command for unlinking a list of multiple dependencies.
Example usage:
foo@bar:~$ zos unlink openzeppelin-zos gnosis-safe

There are some conflicts @jcarpanelli, feel free to fix them and merge!


Add doc include for connecting to FCM

Add include for connecting to FCM when app becomes active.
Add call to completion handler in didReceiveRemoteNotification.

LGTM bar swift q

Funny, I just wanted to create this PR too.


Fixed makeaddressbyte returning 1 in cases that it should return 0

and also made it look much nicer

Danke


Added custom counter

Added a custom counter

This would be great if you provide any of this   📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Single page website

Checklist ✅
]

[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm Hacktoberfest contributor

Any tutorials or documentation have you added
(made by you only not from google)

[x] Documentation

Screenshots / Gif (Compulsory) 📸

![image](https://user-images.githubusercontent.com/74728397/196979254-64744033-b11c-46e5-bcad-bf73b65851b4.png)

hey @RIYANSHGARG please add deployed link of project

What kind of deployed link ? its just a counter template.

What kind of deployed link ? its just a counter template.

@RIYANSHGARG add a deployed link or ss of project

@Ayan-thecodeking I have added the ss but on preview its not displaying

@Ayan-thecodeking Can You please rectify it and merge it ?


Update project-scoped-feeds.md

Document does not clearly mention that members who want to have access to read the packages in feed needs to be added in ADO Organization.

@Ahetejaz Thanks for your contribution! pending team confirmation

Thanks @Ahetejaz! I've made some minor changes
#sign-off


Autoupdate mechanism

Continuation of #44.

Additionally, having WingetUI run in the background and automatically notify and install updates unattended is something I think is essential to most package manager UIs.

See #44


Add Kafka binder to the streams code

The core team is not likely to work on this prior to Steeltoe 4.0, if it is important to you and you would like to help build it, please reach out and we'd be happy to help you get it done

Due to the scope of capabilities needed to deliver Steeltoe Messaging support for RabbitMQ, which is the initial Messaging implementation, Steeltoe OSS team is going to focus on delivering it first before tackling another messaging platform such as Kafka. We will update this issue when we have a better idea of which release that Kafka support will be addressed. Please let us know if there are any questions or concerns. Thank you.


Use DAC on PWM ports to get the correct voltage out to LEDs

Controlling digital to analogue with analogWrite(A4, 0.5)giving 0.5*3.3v = 1.65v
Can use B3-B15 for PWM

Works well, using A5,6 and 7 for lights, B5 for switch.
// Code saved with E.setBootCode
var  on = false;
console.log('this should only happen once');

setWatch(function() {
  if (on === false) {
    on = true;
    lightOn();
  } else {
    on = false;
    lightOff();
  }
}, B5, { repeat: true, debounce : 50, edge: "rising" });

var lightOn = function() {
    lightIntensity = [1, 0.02, 0.02];
    analogWrite(A5, lightIntensity[0]);
    analogWrite(A6, lightIntensity[1]);
    analogWrite(A7, lightIntensity[2]);
    console.log('light on!');
};

var lightOff = function() {
  analogWrite(A5, 0);
  analogWrite(A6, 0);
  analogWrite(A7, 0);
  console.log('light off!');
};


Change readme to markdown.

@justinfrench @mikz Should I change hash syntax too?

The hash syntax is in lots of other documentation, so I'd keep the focus here on just the document format, not content changes, then follow up with another PR.

What are you going to do with README.textile before this merges?

I am not sure, do you want to delete it?

It could be deleted, but lots of stuff probably links to it. I guess delete the contents of README.textile and provide a link or instructions to README.md instead?

@justinfrench done.

Merged, thanks!

Happy to help :smile:


This seems not to be working with WEG 1.4.6

Can not change display brightness at all when I update to WEG 1.4.6, (switching the boot-args included, as stated in the instruction) not sure whether it is AppleBacklightSmoother problem or WEG’s (or even OpenCore’s), but reporting the issue as soon as discovered. Will test other combinations of this extension with updated versions of Acidanthera kexts later.

It turns out, that WEG doesn’t patch backlight registers by default, so we do not need igfxcflbklt=0 or it’s newer equivalent -igfxblr for this kext to work correctly. Suggest removing this from installation instructions.

It turns out, that WEG doesn’t patch backlight registers by default, so we do not need igfxcflbklt=0 or it’s newer equivalent -igfxblr for this kext to work correctly. Suggest removing this from installation instructions.

More compatibility problems with WEG ≥ 1.5.6 are described in Acidanthera’s bugtracker #1471
TL;DR:
The kext causes recovery environment to KP due to page fault.

I had to disable the kext as it probably caused me problems entering recovery mode. I disabled some kext, but after reading this issue I suppose this could be the problem. Hope @hieplpvip can fix the issue soon

@hieplpvip
I've confirmed this issue also, please take a look.

@Ubsefor you have written 1.5.6 THREE times.. but even the link you post points to WEG 1.4.6..... and even now, WEG is at v. 1.4.x. Please correct the misleading issue title - thanks.
@tylernguyen @antoniomcr96 what about your eye's vision and alertness?

Not much of an issue, as everyone else understood me 🙂
Fixed it anyway, thanks

mighty fine - you da man ;)


fix with ubuntu18

Hi, why apt-fast?

The Sage was to big😬
获取Outlook for Androidhttps://aka.ms/AAb9ysg

From: Darío Clavijo @.>
Sent: Friday, September 2, 2022 6:38:56 AM
To: RsaCtfTool/RsaCtfTool @.>
Cc: imazes @.>; Author @.>
Subject: Re: [RsaCtfTool/RsaCtfTool] fix with ubuntu18 (PR #360)
Hi, why apt-fast?
—
Reply to this email directly, view it on GitHubhttps://github.com/RsaCtfTool/RsaCtfTool/pull/360#issuecomment-1234857826, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADHEFXIJPIMBCOIEMWKWRILV4EWABANCNFSM6AAAAAAQCFKFQY.
You are receiving this because you authored the thread.Message ID: @.***>


NSInvalidArgumentException

Thanks for you great ftp class.
Everything works fine, but sometimes i receive NSInvalidArgumentException error on line 484 when downloading zip file from ftp
    case NSStreamEventEndEncountered: {
        [self.delegate requestCompleted:self];
        [self destroy]; <---- HERE
    } break;

Sorry, this is my fault.
downloadFile is a retain property in my code and in requestCompleted delegate a release it because i want to decrease app memory usage. But after [self.delegate requestCompleted:self]; you do some cleanup stuff with this object. Where is the good place to release retaned request?

Sorry, this is my fault.
downloadFile is a retain property in my code and in requestCompleted delegate i release it because i want to decrease app memory usage. But after [self.delegate requestCompleted:self]; there is some cleanup stuff with this object. Where is the good place to release WRRequestDownload object?

Hello jgrom,
I usually keep a ivar reference to whiteraccoon and dealloc it in my dealloc method. Also, to keep memory down,  you should always purge receivedData after you used it. (by default it persists)


Add support for server variables and relevant tests in Chai OpenAPI Response Validator

Completes https://github.com/openapi-library/OpenAPIValidators/issues/89 for Chai

The tests cover the use cases I can think of, having looked at the documentation. If any are missing, please let me know.
The code is more complicated than I'd like, but handling OpenAPI 3 server variables just seems to be pretty complex. Very happy to suggestions to improve this if there are any

After merging, this still need to be ported to Jest, then released


Update README, add CONTRIBUTING

@girasquid another one :)

Two minor niggles, otherwise :+1:

Both are fixed. :)

:heart_eyes:


Profile - Pronouns and local time are not displayed when clicking on header

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.46
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4995348&group_by=cases:section_id&group_id=229064&group_order=asc
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Create an account and update avatar, first name, last name, pronouns, time zone
Create another account
Start the conversation with the first account
Tap on "Inbox"
Tap on the coversation with the first account
Tap on the name or avatar of the recipient

Expected Result:
The avatar, first name, last name, pronouns, time zone of the recipient are displayed
Actual Result:
Only avatar, first name, last name of the recipient are displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/a61f8155-68cf-4c59-b887-dc8e0cdb12bc
View all open jobs on GitHub

@Christinadobrzyn  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Working as expected,
we show pronounce row only when user has pronounce set.
And we display user local time row if we have user's timezone and user is validated.

Awesome - thanks @ChavdaSachin going to close this then as not needing a fix


Accessibility

We break Accessibility down into multiple chunks of work:
Issues labeled Accessibility
https://github.com/Microsoft/vscode/labels/accessibility
Keyboard navigation & Focus indication

[x] Define central CSS rules for focus indication
[x] Support navigation in actions and action bars
[x] Support navigation in tree widget and embedded actions
[x] Support navigation in split view and embedded actions
[x] Support navigation to search details toggle
[x] Support navigation in iframe previews
[x] Support navigation in feedback widget
[x] Support navigation in debug repl
[x] Support navigation in debug complex hovers
[ ] Support navigation to sashes for resizing parts
[ ] Don't navigate to the html  of the app

Related PR: https://github.com/Microsoft/vscode/pull/2077

Looking good so far :) I think screenreader support can be broken up into points like the following:

Make main edit area ocusable
Enable screenreaders to receive useful information using UIA when simply arrowing through existing input and creating input  (yes, yes, I know that is easier said then done with this app)
Add UIA events for things like autocomplete suggestions, debugger warnings etc.
See what can be reused in the initial UIA implementation for the editor to make things like preferences screens and other such dialogs speak

The action bar and its actions are already sort of usable if ou know how to get to them, so those only need some minimal work to be keyboard-accessible, no additional screenreader support should be required.

@zersiax thanks the feedback. In the January update we will have some first rough support for accessibility including the editor (needs to be enabled through a setting). I would much appreciate if you can give it a try. I'll follow-up with more details in this issue once the update is available.

@zersiax the 0.10.7 insiders build is now available. There is some initial support for screen reading of the editor contents on Windows when using NVDA.
Here is the blog that describes how to get the release:
https://blogs.msdn.microsoft.com/vscode/2016/02/01/introducing-insiders-builds/
Here are the relase notes:
https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/latest.md
We would be much interested in your early feedback.

Just did some quick checking. NVDA reas stuff in the code editor. Sometimes it seems NVDA thinks the line you are currently on gets selected after you've arrowed to it, leading to some strange output now and again. It makes some lines repeat with "selected" added in front to indicate selection of the entire line. This is false however since typing will not in fact delete the current line, which is good. It does lead to a bit of head-scratching for a f ew seconds though. Overall, good improvements so far :) Keep up the good work.

@zersiax would also appreciate some feedback for screen reader support in areas outside the editor (views, etc.).

Thanks for doing this btw :+1:

Thanks much for trying it out and here are some more questions. We have also added additional support that should improving the screen reading. This is enabled with ALT+F1. Did you discover this support? Does it improve things.
@alexandrudima FYI.

Hi,
No, I was not awareof this functionality and will try it. What I have found with it disabled is the following. Please not I am haphazardly jumping around right now, if you want me to do a systematic check please give me some areas to focus on, code is rather big :+1:

When bringing up the git view, screenreaders don't report this. When hutning around the accessibility tree, I come across a group labeled simply as ￼
, which holds these git elements. This is a unicode symbol that sometimes is reported as 'note' , but doesn't seem to always work with NVDA.
In search, when there are no results this shows up as text, but I have to go hunt for it. It would be good if this is either popped up or reported via a live region of some kind. The treeview of search results, when it comes up, is accessible and seems to work. It might be good to bring focus to the treeview after a search though.
In the menubar, you cannot use left and right arrow keys to jump between menubar menus. Also, I can't seem to find the menubar in the accessibility tree, so I essentially don't know what menus are there. I do alt+letter now to get to the menus I am guessing are there like file, edit, view etc.

What does the alt+f1 keystroke add?

git view

When you open the git view, we immediately transfer focus into the git commit text area. Would you expect this text area to explain to you that it is for committing the changes you have or even more (how many changes etc.)? Maybe you could give an example what you would expect here

search view

Good point regarding the search result message that is not being read. I will look into that. I am not sure about moving focus out of the search box, I was assuming that it is not nice to programmatically change focus without user interaction. I do agree though that it would be nice to announce the status of the search operation to the user (progress, results).

menu bar

Unfortunately the menu bar does not seem to be the native menu bar on Windows. Here we rely on the Electron framework and do not have much control.

What does the alt+f1 keystroke add?

It brings the editor into accessibility mode, so you want to enable that to test screen reader support within the editor!

Git view:
Yes, I think that would be good. Right now I was actually thinking I was still in my editor document.
search:
You are right, often playing ninja with focus isn't considered as a good practice. But I think in this case it actually augments the workflow. You search to get results. It is logical to therefore go to results after doing a search, since ...where else are you going to go?
Alt+f1:
Please give me some things that work differently when this is enabled. Without screenreader mode, the editor behaves as I described in an earlier comment. When pressing alt+f1 this toolbar pops up that says I have to press shift+ctrl+r to turn the accessibility support on. Doing that does show me it is toggled on, but i don't really understand what it is supposed to do exactly. I do see something about toggling tab key behavior using ctrl+m, is that what it is supposed to do? That toggle works fine for as far as I can tell.

Ok, turning on screenreader mode seems to get rid of the 'selected' thing I was talking about. Also, the search seems to be visible with its controls greyed out ('unavailable' for screenreaders), not sure why or if that's because of something I did or not.
What else should this influence, e.g., do autocomplete suggestions etc. work in this mode as well? Anything else?

@zersiax the difference with Alt+F1 is that we put the entire contents of the file you are editing into the browsers textarea element. We are not doing this typically for performance reasons when the file is very large, that is why we require this explicit action. Doing so, we rely on the browser to provide the related accessibility features for a text area control with text.
I will make a pass over our views and panels to make sure that the text that is being read when switching to these things makes sense in the context where they are.

@zersiax another question I had in mind is how do you explore an application when you start it for the first time without knowing its structure? do you let the screen reader read out the structure of the application? did you try that with Code already?

@bpasero good :) I understand the underlying technologies of Code will make rendering an entire file to a screenreader at once in the current model almost impossible due to performance reasons, so its good you built in this toggle. When users get to this though, we wil need to somehow make them aware the toggle even exists. I now understand the whole 'selected' issue when this mode is off as well, its due to the chunk of code you're working with being rendered almost at runtime to the screenreader which slightly confuses it. This is not a showstopper though.
As for how I explore an application, typically I don't. I tend to focus on what I am trying to get done and see what I come across in the mean time.  This used to work somewhat way, way back when. When I am really looking for something I tend to use NVVDA's object navigation feature which relies on the accessibility tree that UIA or some other framework provides. Usually this gets me places faster than the individual keyboard shortcuts of an app if they don't exist or aren't implemented properly.

@zersiax when you move focus into the editor, we give the screen reader a message that indicates you can press Alt+F1 to enable this mode, maybe this message was no clear enough or not read to you at all?
I will file a bug for the Menu issue on Electron and link it back here: https://github.com/atom/electron/issues/4330

NVVDA's object navigation feature
How do you trigger that? I have NVDA installed too. Would like to see what it reports for Code.

Hi,
Best to check the manual for object navigation, theres a clear section about it there.
As for the hotkey, no I wasn't informed this hotkey existed when opening the program. Should I have been? :)

@zersiax we set the following aria-label to the editor and would expect a screen reader to read it once you focus the editor:
Text file editor.Press Alt+F1 for more info.

Hi,
Best to check the manual for object navigation, theres a clear section about it there.
As for the hotkey, no I wasn't informed this hotkey existed when opening the program. Should I have been? :)
Now you mention it, yes, that is read out. However, more info may be a little too generic in this case. How about "press alt+f1 if you are using a screenreader". Since ARIA-labels only communicate with screenreaders, that way it is both clearer what you mean and not a hindrance to others who aren't using a screenreader. 'more info'  could be all sorts of things, from a help page to some kind of status message. I think that confused me as well :)

@alexandrudima fyi for discoverability of Alt+F1

I saw stuff on Twitter that made me pop in.
Object nav is  a set of 4 or 5 keys for directly exploring the object hierarchy of the application.  What exactly object hierarchy means in this case is a bit interesting, but it's not UIA.  NVDA has an internal abstraction over the idea of accessibility object, and browsers are treated specially.  I believe Aria can let you change this, but Aria may not be working very well in Chromium.  The basic keys (on the laptop layout) are shift+nvda+the arrow keys. Left and right for previous and next object, up for go to parent, down for go to children.
When it works well and if the application is bad at providing navigation keystrokes, it can certainly be faster.  When the application doesn't provide or provides insufficient keyboard support, it can be a lifesaver.  I would personally expect any intermediate to advanced NVDA user (so, like, everyone who'd use VSCode) to know about and use this feature on a semi-frequent basis.
It is worth noting that Aria-label is an interesting case where it doesn't always do what you'd expect.  Simply putting it on stuff will probably work here, but please please please test.  I've seen so many places on the web where people are using Aria-label and it fails to be read at all for stupid reasons that nevertheless don't have good solutions (on the NVDA side of things, don't even get me started on how annoying it is that the Aria spec doesn't say what AT must do).
And finally, I don't know if it's a problem here, but I feel like it's worth mentioning.  A lot of the other Visual Studio stuff and a lot of the MS installers use really bad labels in addition to the horrible accessibility on offer.    Syllable minimization is a very important thing, and I see very little attention paid to it in general and especially in other Microsoft developer products (count the "This button xx" instances in various installers, my screen reader already tells me "button" and "this" is redundant...and then the rest of the label just repeats the actual text on the button--also already read).
Keep it up. The story for good programming editors for blind programmers is Notepad++, and Notepad++ has a ton of annoying issues.  Everything else is stuff by other blind people and it's all buggy, to put it kindly.  Do a good job here, and the blind people will come at least.

I'm going to discuss VS Code accessibility with someone at MS in a few
days, I will certainly bring these points up since they are on the
mark :)

Actually, while I'm thinking about it, this comment exists to mention @jcsteh.  He might be interested in this, given that VSCode accessibility is the first time I can personally recall Microsoft acknowledging that NVDA exists publicly, as opposed to just saying "narrator and other assistive technology" or something to that effect.

Just some clarifications:

Object nav is  a set of 4 or 5 keys for directly exploring the object hierarchy of the application.  What exactly object hierarchy means in this case is a bit interesting, but it's not UIA.

In this case, it's based on MSAA/IAccessible2, since that's what Chromium exposes. However, NVDA does tweak the tree a bit, particularly if simple review is enabled (which it is by default).

NVDA has an internal abstraction over the idea of accessibility object, and browsers are treated specially.

For object nav, browsers aren't really treated specially at all. They are for browse mode, but that's an entirely different issue and I suspect irrelevant for Code.

I believe Aria can let you change this, but Aria may not be working very well in Chromium.

ARIA lets you change the hierarchy using aria-owns. This is now implemented in Chromium, though it was fairly recent; I don't know what version of Chromium you're using here.

It is worth noting that Aria-label is an interesting case where it doesn't always do what you'd expect.

When you're not dealing with browse mode and you're primarily dealing with interactive controls, aria-label should work as you expect. I'm guessing browse mode isn't used here; it certainly wouldn't make sense to do this.

We have improved accessibility for debug sessions in the latest vs code alpha release which can be downloaded here:
https://az764295.vo.msecnd.net/alpha/4090a5d2ea7a84f215e7f16929a12ad76045f94d/VSCodeSetup-alpha.exe
It would be great if someone is willing to tryout the debug experience and give feedback on accessibility so we could further improve here.

I spoke with @zersiax earlier today and discussed what we should do in the debugger. Here are my notes. Florian, please feel free to add or comment if I missed anything or got it wrong

After pressing F5 to launch the app under the debugger the debugger should announce "Debugger launched" before the app starts up and the screen reader starts announcing from the app.
When a breakpoint is hit, we should announce "breakpoint hit filename linenumber". If it's a conditional breakpoint, announce "conditional breakpoint hit filename linenumber". We discussed whether or not to announce the conditional expression but thought that it might be too verbose to do so.
Each time execution moves from one breakpoint to another, or each time a breakpoint is hit, there is a lot of text announced. The main window title is announced, followed by the file name. Then "Text file editor, press Alt+F1 for more info". We don't need to announce this each time and should focus on announcing that a breakpoint was hit.
Inside the debug viewlet, when browsing the list of variables we should reduce the verbosity as much as possible. For example, consider just announcing the name of the variable or field rather than prefixing it with "variable"

Great feedback, thanks a lot. I'll try to improve these next week

Hi,
Just saw the new release changelog, good work so far.
I want to stress-test the system a little. See where accessibility is
still not optimal and create issues for the stuff i find. Please let
me know a fitting strategy for this? Is there a tag I should group
them under, put them all in one issue or ...?

@zersiax thanks much for willing to help! we will soon release a new insider drop with all our changes that you can use.
We typically file individual issues here around accessibility with the label "accessibility". We will take care of the triaging from then on!

@zersiax actually I think the insiders build (0.10.10-insiders) is already out!

Lets continue accessibility work via issues reported. Closing this one.


[Broken] [viki] "No video formats found" on modern episodes and shows.

Checklist

[X ] I'm reporting a broken site support
[ X] I've verified that I'm running youtube-dlc version 2020.09.16
[X ] I've checked that all provided URLs are alive and playable in a browser
[X ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X ] I've searched the bugtracker for similar issues including closed ones

Verbose log
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-u', 'PRIVATE', '-p', 'PRIVATE', '-v', 'https://www.viki.com/videos/1169478v-idol-on-the-quiz-episode-1']
[debug] Loading archive file None
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dlc version 2020.09.23-2
[debug] Python version 3.8.5 (CPython) - Windows-10-10.0.19041-SP0
[debug] exe versions: ffmpeg N-92558-ge695b0beba, ffprobe N-92558-ge695b0beba
[debug] Proxy map: {}
[viki] Logging in
[viki] 1169478v: Downloading video JSON
[viki] 1169478v: Downloading video streams JSON
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dlc -U  to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "youtube_dlc\YoutubeDL.py", line 819, in extract_info
  File "youtube_dlc\extractor\common.py", line 532, in extract
  File "youtube_dlc\extractor\viki.py", line 285, in _real_extract
  File "youtube_dlc\extractor\common.py", line 1359, in _sort_formats
youtube_dlc.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dlc -U  to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.

Description
Both https://www.viki.com/tv/37282c-idol-on-the-quiz and https://www.viki.com/tv/37130c-mom-has-an-affair give the error mentioned in the title. To try and debug the issue I tried downloading https://www.viki.com/tv/21497c-sbs-inkigayo and while the oldest episodes available work just fine the newest episodes also give the same error. I'm using a paid VikiPass Plus account.

Additional info, it seems x-viki-app-ver is 4.0.53 when I use chrome's webdev tools to view the headers, which is different that what the extractor uses (_APP_VERSION = '<IP_ADDRESS>8709186').

Maybe @zackmark29 can help.
This video is drm protected with microsoft readyplay.
Therefore streams.json returning an empty array. I don't know if it's possible to circumvent the drm with any vpn/proxy.

Maybe @zackmark29 can help.
This video is drm protected with microsoft readyplay.
Therefore streams.json returning an empty array. I don't know if it's possible to circumvent the drm with any vpn/proxy.

Yeah it's drm protected I  think because I tested in my tool and it can't find the streams as well
But I'll try to find out the solution right now.

I just check that the author is Kocowa. That's why it's really DRM protected. try to visit their website it's the same.
But on some videos, You can get access the streams with using vpn.

So, no way to download the videos.


index out of range when encoding large VCF

Hi Brent
Thank you for another great tool. I am getting this error when trying to encode a rather large VCF. The VCF is spliceAI indels, with a custom max field (max of four values). The json config is also below. I am also trying to attach the smallest VCF I can make that would still produce the error.  (hopefully you can download this https://www.icloud.com/iclouddrive/0967utbVnXQf9DsBnTWh4tiqA#chr5 , sorry it is so large, if I drill down to smaller locations, the error goes away)
[
  {"field": "SpliceAI_max", "alias": "SpliceAI_max", "multiplier": 200},
  {"field": "SpliceAI_max_name", "alias": "SpliceAI_max_name"},
]

RUST_BACKTRACE=full echtvar encode spliceai_scores.masked.indel.hg38.max.chr5.zip spliceai_scores.masked.hg38.max.echtvar.json spliceai_scores.masked.indel.h
g38.max.chr5.vcf.gz
[echtvar] adding VCF:spliceai_scores.masked.indel.hg38.max.chr5.vcf.gz
thread 'main' panicked at 'range end index 39591728 out of range for slice of length 39591726', /home/brentp/.cargo/registry/src/github.com-1ecc6299db9ec823/stream-vbyte-0.4.0/src/encode/sse41.rs:117:21
stack backtrace:
   0:           0x4fc31d - std::backtrace_rs::backtrace::libunwind::trace::h65ef482bb9b15649
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
   1:           0x4fc31d - std::backtrace_rs::backtrace::trace_unsynchronized::hf1ee7630128bf9a9
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:           0x4fc31d - std::sys_common::backtrace::_print_fmt::haddc20e8865333bd
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/sys_common/backtrace.rs:67:5
   3:           0x4fc31d - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hc06b166f304d5a13
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/sys_common/backtrace.rs:46:22
   4:           0x49cebc - core::fmt::write::h212f7b7266b9a26a
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/core/src/fmt/mod.rs:1149:17
   5:           0x4dae84 - std::io::Write::write_fmt::h240619c436cddbd8
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/io/mod.rs:1660:15
   6:           0x4fdbae - std::sys_common::backtrace::_print::h9d519f4e309ac3d8
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/sys_common/backtrace.rs:49:5
   7:           0x4fdbae - std::sys_common::backtrace::print::h8362bac372870d46
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/sys_common/backtrace.rs:36:9
   8:           0x4fdbae - std::panicking::default_hook::{{closure}}::hdf453592ec91e76e
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/panicking.rs:211:50
   9:           0x4fdbae - std::panicking::default_hook::h9b626066b2c6b270
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/panicking.rs:228:9
  10:           0x4fdbae - std::panicking::rust_panic_with_hook::h90c32e4f1cc54562
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/panicking.rs:606:17
  11:           0x4fd468 - std::panicking::begin_panic_handler::{{closure}}::h6751672be4522935
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/panicking.rs:502:13
  12:           0x4fd3e6 - std::sys_common::backtrace::__rust_end_short_backtrace::hdecab70784de07d3
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/sys_common/backtrace.rs:139:18
  13:           0x4fd3a2 - rust_begin_unwind
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/std/src/panicking.rs:498:5
  14:           0x404bd0 - core::panicking::panic_fmt::h3a6bf5e754065d1c
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/core/src/panicking.rs:107:14
  15:           0x404cd1 - core::slice::index::slice_end_index_len_fail::h8d2ca6c452b724f9
                               at /rustc/8f3238f898163f09726c3d2b2cc9bafb09da26f3/library/core/src/slice/index.rs:43:5
  16:           0x41689d - echtvar::commands::encoder_cmd::write_bits::hbb96f375a38dcffc
  17:           0x41aff5 - echtvar::commands::encoder_cmd::encoder_main::hbcd6dffce26afc25
  18:           0x425241 - echtvar::main::h994cda02b319af02
  19:           0x433863 - std::sys_common::backtrace::__rust_begin_short_backtrace::h3a3ce605638829d4
  20:           0x43376d - std::rt::lang_start::{{closure}}::h95dc532fc021057b
  21:           0x4345cb - main
  22:           0x78483a - __libc_start_call_main
  23:           0x785cc7 - __libc_start_main_impl
  24:           0x408b85 - _start
  25:                0x0 - <unknown>

Hi, thanks for reporting. Looks like this might be an issue with the stream-vbyte lib that I am using.
Can you try this debug binary? (gunzip, chmod+x and run).
It will also output position information that might help you to create a smaller test-case. I'll also have a look at your file on monday.
echtvar.gz

Wow that was fast. That binary works for me on the small VCF I created. I am now testing it on the whole VCF, and should be able to report back in a couple days.
Thanks again for the quick fix and great tool.

Thanks for reporting! spliceAI is definitely a good stress test for echtvar.
I found another issue using the file you sent that's still present in that binary (so don't continue to use that one). I have just fixed that as well. I'll make a release next week.
echtvar.gz
You can try this one or wait for the release.

Awesome, thanks again.

Just verifying this is resolved for you. Please let me know any other issues.
Thanks again

Sorry for not giving an update, yes it was resolved. Thanks you

No problem. Just wanted to verify.


"All messages" gets busy and crashes on skimming past tons of messages

A user reports:

I’m using Zulip as personal notification system (something happens in my home network, I get a notification in appropriate stream/topic).
When checking those on iOS app after a while (I usually do it via desktop app), there is no easy way to scroll to the bottom...down arrow icon appears in bottom right, I click it, it brings me 10 or so messages down, then it appears again, and so on.
I receive a lot of those notifications and sometimes I must click the down arrow icon 15 times...in that time, iPhone gets really hot, and I’ve also had the app crash in the process.
For my usage, that’s the only thing that bothers me :)

Additional details:

This is in the "All messages" screen

I have Jenkins sending all messages to “Jenkins” stream, but each job creates its own topic, so I want to get it read fast, hence all messages view

Also, I saw “mark all as read” in the top right corner, but only two times I think (second one being just now, but before I could press it Zulip crashed) :)

I can't immediately reproduce -- in 23.2.111 on Android 9, in a test realm with a fair number of messages I can fling-scroll up and down the "All Messages" view smoothly and the phone doesn't get warm. That was in a scenario where it started at the end, after scrolling up and having it load previous messages a few times. May require a bigger volume of messages, or many unread, or going forward (from a pointer in the past) instead of back, or might be platform-dependent; more investigation required.

#3423 describes something that could conceivably be a cause of this. (Though it seems hard to trigger, and it doesn't seem like it should really cause that much client-side work -- so I think the cause is probably something unrelated.)


ocaml-libvirt: init at <IP_ADDRESS>

Motivation for this change
virt-top dependency
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

superceded by https://github.com/NixOS/nixpkgs/pull/21536


Round the corners of the app card footer

Fixes #107.
~!important ✨~

Thanks for the quick work @j-f1!


Grammar fixes in HomepageHero.tsx and CommunityGrant.tsx

Description
Concise description of proposed changes, We recommend using screenshots and videos for better description
Minor grammar fixes for the CommunityGrant.tsx and HomepageHero.tsx files.

[X] I have read the contributing docs (if this is your first contribution)
[X] This is not a duplicate of any existing pull request

Related Issues
Closes #{issue number}
#91 "Grammar Fixes"
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address:

Thanks for the sharp grammar eyes @sfaber34
The lining was giving some prettier errors, so I fixed them locally.


Include original event in event subscriptions?

Dear Matt Lewis,
Thank you for your great work on this module.
Could you please consider including the original/browser events in the onDrag, onDragOver, onDrop, etc. events?  The way I understand the documentation and code, currently I can only access the dropData in the mwlDroppable's onDrop handler.  It would be great if that $event also contained the original browser event, like in {dropData: …, event: …}.
The reason I need this is that I have created a “huge” (13 x 13) grid where each cell is a droppable, but it slows down the performance considerably.  If I had access to the drag/drop event's coordinates, I could calculate which cell is hovered and dropped upon, and I would only need to make one element (the whole grid) droppable.

hmm that's odd, I've put a lot of effort into making this lib as performant as possible, I would expect it to be able to cope with 169 droppable squares quite easily. I'll do some profiling and see if I can see what's causing the slowdown. What browser are you seeing the perf issues in?

It's quite performant in desktop Chrome, but starts to show small “lag” effects in mobile browsers on Android and iOS.

@mattlewis92: I've sent you an email with a video that should explain the usage context better.  If the draging and dropping were the only things going on, the performance would probably not be a problem.

Sorry about the late reply on this, been super busy lately with work + real life, and open source hasn't been at the top of my list. Do you still need this? 😄

Hi, @mattlewis92.  No problem.  I know how it is when work and real life team up and demand that you spend time on them.  :smile:  For now, I've made some other optimizations, like changing the cell components' changeDetection to ChangeDetectionStrategy.OnPush, and it might do the trick for now, by reducing the number of actual change-detection checks performed for each relevant event.
So, until I gain more experience with the choices I've made, I do not need this feature, but I would love to be able to compare the performance differences of the approaches (if any).  However, if I feel that this issue becomes pressing again, I can either make the changes myself and propose a pull request, or I can ask you politely if you would like to reopen this issue.  :wink:

Ah yeah, using OnPush is a really good way of getting a nice perf boost, have a look at this article as well, as it might give you some additional ideas on how to make things faster. I only wrote this module as I needed snap grids when dragging, if you don't need that feature which it didn't look like from the video you sent me, then your best bet is probably just to use native drag and drop as that will probably give you the best performance as it's baked into the browsers API. I will close this issue for now then 😄


fix cosignatory websocket callback

It has never been working correctly.

https://github.com/proximax-storage/tsjs-xpx-chain-sdk/pull/47


Implement auto-scrolling after middle click

After middle click moving the mouse pointer in a direction scrolls in that direction.
Also add the cursor.

Implemented in #188.


appflowy: 0.5.7 -> 0.5.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/AppFlowy-IO/appflowy/releases.
meta.description for appflowy is: An open-source alternative to Notion
meta.homepage for appflowy is: https://www.appflowy.io/
meta.changelog for appflowy is: https://github.com/AppFlowy-IO/appflowy/releases/tag/0.5.8
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.5.8 with grep in /nix/store/jwchx30pqwppqiqmh8zbkr8xr52c3xyy-appflowy-0.5.8
found 0.5.8 in filename of file in /nix/store/jwchx30pqwppqiqmh8zbkr8xr52c3xyy-appflowy-0.5.8

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

appflowy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jwchx30pqwppqiqmh8zbkr8xr52c3xyy-appflowy-0.5.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A appflowy https://github.com/r-ryantm/nixpkgs/archive/d43c6fce10b4c9b5415396adea91304f1a822e5f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d43c6fce10b4c9b5415396adea91304f1a822e5f#appflowy

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jwchx30pqwppqiqmh8zbkr8xr52c3xyy-appflowy-0.5.8
ls -la /nix/store/jwchx30pqwppqiqmh8zbkr8xr52c3xyy-appflowy-0.5.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

appflowy

Maintainer pings
cc @DarkOnion0 for testing.

Supersede by #321703


Update URL for HTTP grammar

The HTTP grammar has been moved to a new location, from https://github.com/httpspec/sublime-highlighting to https://github.com/samsalisbury/Sublime-HTTP.

I had to contact the author of the grammar, who deleted it by mistake, to reinstate it. I got a quick answer and new URL for the repository, so I was just waiting to be home as well to open the pull request :stuck_out_tongue_closed_eyes:


NT Barratry Update

About the PR
A small update addressing some of the feedback.
Screenshots

Changelog

:cl:

tweak: NT Barratry has received a small update.
add: Referring to Barratry by the wrong name will now result in instant immolation.

my favorite map nt bartholomew


Blocking bugfix for mysql lock

GET_LOCK doesn't block in mySQL, so the $blocking variable has no effect when passed to getLock in the mysql driver. This fixes the blocking logic in the abstract base class.

Thanks :)


The controlPlaneNodeSelector installation field doesn't effect Typha

Expected Behavior

Based on the documentation for controlPlaneNodeSelector it applies to all components which aren't DaemonSets. That means that it should apply to the Typha deployment.
Current Behavior

The controlPlaneNodeSelector doesn't apply to the Typha deployment. I suspect this might be because there is the typhaAffinity field, but affinity and node selectors can be used in parallel.
Possible Solution

Use controlPlaneNodeSelector with the Typha deployment.
Steps to Reproduce (for bugs)

n/a
Context

n/a
Your Environment

n/a

Yeah we should state that Typha is an exception because it is a critical component and should be considered part of the dataPlane.

@tmjd isn't that more reason to allow the nodes it runs on to be selected?

I don't think so, it isn't critical that individual Typhas are not destroyed/recreated. It is critical that a sufficient number exist, which is why there is a PodDisruptionBudget defined for it and we suggest only preferred(not required) typaAffinity. This will allow typha to always be present at the correct scale since it is not forced to any specific nodes.  So as long as any node scaling properly follows PodDisrutpionBudgets then Typha is fine.
If you still would like to prefer system nodes for typha you can set that with spec.typhaAffinity.

If Typha isn't using controlPlaneNodeSelector then there either needs to be a typhaNodeSelector or dataPlaneNodeSelector to control this.

I do not believe this is necessary because typha's scaling and PodDisruptionBudget are set to ensure HA when nodes are removed or fail.
If you still believe you need to force typha to certain nodes checkout typhaAffinity which is of type NodeAffinity. But please take note of the warning on requiredDuringSchedulingIgnoredDuringExecution, which is

WARNING: Please note that if the affinity requirements specified by this field are not met at scheduling time, the pod will NOT be scheduled onto the node. There is no fallback to another affinity rules with this setting. This may cause networking disruption or even catastrophic failure! PreferredDuringSchedulingIgnoredDuringExecution should be used for affinity unless there is a specific well understood reason to use RequiredDuringSchedulingIgnoredDuringExecution and you can guarantee that the RequiredDuringSchedulingIgnoredDuringExecution will always have sufficient nodes to satisfy the requirement.

@tmjd I've configured typhaAffinity but as Typha uses the controlPlaneTolerations value it really doesn't make sense that it doesn't use the controlPlaneNodeSelector value. Also for a simple node selector typhaAffinity is overkill and adds significant cognitive load.
When building Kubernetes platforms it's really important to have control over scheduling decisions for central components; this is where a lack of flexibility in operators can make them un-usable. It's a common pattern to run system node pools to rull all the central components on, leaving user provisioned nodes to only run daemonsets and user workloads.

Yeah that was a bad decision to have the two controlPlane* configs not apply to the same set of components.
@caseydavenport WDYT should we create a typhaTolerations so the controlPlane ones are consistent in where they apply?

Also for a simple node selector typhaAffinity is overkill and adds significant cognitive load.

I expect the user to take on that cognitive load because it should be a specific decision if they need to use affinity for typha. We are talking about a component that if it cannot be deployed then pod networking will not function in a cluster, so if someone wants Node Selector type behavior for typha, it should not be an easy or quick decision.

Yeah that was a bad decision to have the two controlPlane* configs not apply to the same set of components

Agreed

should we create a typhaTolerations so the controlPlane ones are consistent in where they apply?

I think the options here are:

Consider Typha to be controlPlane, and thus have all the controlPlaneX fields apply to it.
Consider it to be dataPlane, add new dataPlaneX fields that apply to Typha and calico/node.
Add component-specific fields for Typha and calico/node.

I think the latter is probably the right path forward. controlPlane makes sense for controllers and such that are not critical path for applications functioning (kube-controllers, apiserver, etc). Those can be bunched up.
calico/node and calico/typha are, unfortunately but necessarily, special system components that require fine-tuning.
So, for typha I think we should have:

typhaNodeSelector
typhaAffinity
typhaTolerations

I'm not a huge fan of encoding component names into the API - I think it leaks implementation details, but in this case the implementation is part of the feature that is relevant to the end user, so there might be no way around that.
calico/node is even more awkward, because it is named pretty vaguely...

calicoNodeNodeSelector
calicoNodeAffinity
calicoNodeTolerations

^ These all seem non-obvious for the new user - e.g., is it "CalicoNode affinity or Calico NodeAffinity"? I think better names are needed for those.

Now that Typha is respecting controlPlaneTolerations , we can either:

Make a clean break, and release note the change in field
Have Typha prefer typhaTolerations, and fall back to controlPlaneTolerations, with a warning explaining that it will be removed in a future release and users should migrate to typhaTolerations
Have Typha prefer typhaTolerations, and fall back to controlPlaneTolerations, no future change.

@caseydavenport I agree that "Add component-specific fields for Typha and calico/node." is the best approach from an end user aspect. Is it worth considering if Calico node needs affinity or customisable selectors? Also Calico Node configuration could use the daemonset prefix, e.g. daemonsetTolerations.
Slightly related, could you point me at the documentation that defines the data plane and control plane? I incorrectly assumed that Typha was part of the control plane; mainly because it's usually only the daemonsets that are considered data plane, but also because my understanding of Typha is that it caches the K8s API and I'd consider the K8s API to be more control plane than data plane (possibly incorrectly).

Any plans to allow the calico-typha to be configured analogously to calico-kube-controllers? We consider typha to be more "control plane-y" and want to control which set of nodes it lands on in part due to security concerns.
Would be great to have typha part of the controlPlaneNodeSelector or having a separate typhaNodeSelector.

but requires us to configure calico in an inconsistent manner between the controllers and typha.

Agree this is annoying, although my preference would be to adjust controllers to respect an affinity field since it's a more flexible syntax than adding a selector for typha.

That would work too!

The one caveat we've heard of around affinity is that it is much more expensive for the scheduler to enforce compared to nodeSelectors

Yeah, it's true that nodeSelectors are evaulated continuously whereas to-date, I believe affinities are at schedule-time only. So perhaps there is a case for supporting both.

I think we should fill this out:

typhaAffinity
typhaNodeSelector
controlPlaneAffinity
controlPlaneSelector
daemonsetAffinity
daemonsetNodeSelector

Consistent and covers all of the bases :sweat_smile:

stevehipwell which version of calico are you using where you are seeing that controlPlaneTolerations are being applied to typha pods? The reason being, I recently upgraded to calico 3.20.0. I am installing it via tigera-operator. And controlPlaneTolerations are not being applied to typha pods for me. 😅

@sarthakjain271095 I'm currently running Tigera Operator v1.23.5 to install Calico v3.21.4 and the toleration are applied to Typha correctly, I've also used one of the v1.24 versions and that also worked.
I think the behaviour was added in v1.22.0 (https://github.com/tigera/operator/pull/1507) so it depends on which Tigera Operator version you're using to install Calico v3.20.0.

I think we should fill this out:

typhaAffinity
typhaNodeSelector
controlPlaneAffinity
controlPlaneSelector
daemonsetAffinity
daemonsetNodeSelector

Consistent and covers all of the bases 😅

You dropped support for tolerations specification for calico-node/DS which is very important if we need calico-node on every nodes - even with a taint.
I can confirm that in v3.22.2 controlPlaneTolerations gets applied to Typha, but not to Node (calico-node).
Thank you

Hey @stevehipwell @aquam8 @sarthakjain271095 and @aarondav,
We've put up an outline of proposed changes to operator component configuration. Among other fields, this will include allowing configuration of tolerations and node affinity/nodeSelectors. Please take a look if you can. We'd appreciate your input on the proposed changes: https://github.com/tigera/operator/issues/1990

Now that #2063 is merged, it will now be possible to specify a nodeSelector/affinity the core Calico components including Typha.


Create marching squares grid

Create a way to update the values within the grid by passing the index, row and the new value for that point


⚠ Bofrost.be has degraded performance

In 6a01cf8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 905 ms

Resolved: Bofrost.be performance has improved in 52d8b09 after 14 minutes.


Improve kroxy startup ascii art

Type of change
Select the type of your PR

Enhancement / new feature

Description
Kroxylicious writes an ascii art kroxylicious icon into the logs on startup.  It doesn't look too slick.  I wondered if it could be improved.
Please describe your pull request
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonar-Lint warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

This is the work of @insectengine

@insectengine thank you, that's definitely much easier on the eye.
It is possible to make it smaller?

the previous one was 90 spaces wide. I've worked up two at 40 spaces.

kroxy_symbols_ascii.txt
kroxy_block_ascii.txt

@insectengine thank you.
Of the two 40 width versions, the block ascii is more pleasing on the eye.  However, I don't know how universal support is for Extended ASCII in all terminal emulators. A google shows some  reports of users reporting issues, but these all seemed to be 15+years old.  Maybe I'm worrying about nothing.
I do like the smoother look of the 90 width version (but would drop the ASCII art "Kroxylicious is starting").  Googling 'standard terminal widths' seems to suggest that some software still defaults to 80.   So I think it make sense to fly under that width to avoid wrapping in common use-cases.
Could we see a rendering at 50 and 60 for a comparison?

kroxy_ascii_60.txt
kroxy_ascii_50.txt
kroxy_ascii_40.txt
Here is a fresh set at 40, 50, and 60.  I've also included screen captures in light/dark.

thank you @insectengine
+1 to the 60 char.
@gracegrimwood @tombentley @robobario @SamBarker WDYT

Yeah I think the 60char version is the winner as its the only one that comes close to retaining the croc's smile.