Failed to pip install pysqlite3 on Mac OS 12.6

Hi, I'm having trouble installing pysqlite3 on Mac (OS 12.6)
Is pysqlite3 support Mac?
pip3 install pysqlite3
Collecting pysqlite3
  Using cached pysqlite3-0.5.0.tar.gz (40 kB)
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: pysqlite3
  Building wheel for pysqlite3 (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [46 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.macosx-12.6-x86_64-3.9
      creating build/lib.macosx-12.6-x86_64-3.9/pysqlite3
      copying pysqlite3/__init__.py -> build/lib.macosx-12.6-x86_64-3.9/pysqlite3
      copying pysqlite3/dbapi2.py -> build/lib.macosx-12.6-x86_64-3.9/pysqlite3
      running build_ext
      Builds a C extension linking against libsqlite3 library
      building 'pysqlite3._sqlite3' extension
      creating build/temp.macosx-12.6-x86_64-3.9
      creating build/temp.macosx-12.6-x86_64-3.9/src
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -Qunused-arguments -DMODULE_NAME="pysqlite3.dbapi2" -I/usr/include -I/Users/jace/.pyenv/versions/3.9.2/include/python3.9 -c src/blob.c -o build/temp.macosx-12.6-x86_64-3.9/src/blob.o
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -Qunused-arguments -DMODULE_NAME="pysqlite3.dbapi2" -I/usr/include -I/Users/jace/.pyenv/versions/3.9.2/include/python3.9 -c src/cache.c -o build/temp.macosx-12.6-x86_64-3.9/src/cache.o
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -Qunused-arguments -DMODULE_NAME="pysqlite3.dbapi2" -I/usr/include -I/Users/jace/.pyenv/versions/3.9.2/include/python3.9 -c src/connection.c -o build/temp.macosx-12.6-x86_64-3.9/src/connection.o
      src/connection.c:1303:9: warning: 'sqlite3_trace' is deprecated: first deprecated in macOS 10.12 [-Wdeprecated-declarations]
              sqlite3_trace(self->db, 0, (void*)0);
              ^~~~~~~~~~~~~
              sqlite3_trace_v2
      /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sqlite3.h:3223:36: note: 'sqlite3_trace' has been explicitly marked deprecated here
      SQLITE_API SQLITE_DEPRECATED void *sqlite3_trace(
                                         ^
      src/connection.c:1306:9: warning: 'sqlite3_trace' is deprecated: first deprecated in macOS 10.12 [-Wdeprecated-declarations]
              sqlite3_trace(self->db, _trace_callback, trace_callback);
              ^~~~~~~~~~~~~
              sqlite3_trace_v2
      /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sqlite3.h:3223:36: note: 'sqlite3_trace' has been explicitly marked deprecated here
      SQLITE_API SQLITE_DEPRECATED void *sqlite3_trace(
                                         ^
      src/connection.c:1328:10: error: implicit declaration of function 'sqlite3_enable_load_extension' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          rc = sqlite3_enable_load_extension(self->db, onoff);
               ^
      src/connection.c:1328:10: note: did you mean 'pysqlite_enable_load_extension'?
      src/connection.c:1315:18: note: 'pysqlite_enable_load_extension' declared here
      static PyObject* pysqlite_enable_load_extension(pysqlite_Connection* self, PyObject* args)
                       ^
      src/connection.c:1352:10: error: implicit declaration of function 'sqlite3_load_extension' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          rc = sqlite3_load_extension(self->db, extension_name, 0, &errmsg);
               ^
      src/connection.c:1352:10: note: did you mean 'pysqlite_load_extension'?
      src/connection.c:1338:18: note: 'pysqlite_load_extension' declared here
      static PyObject* pysqlite_load_extension(pysqlite_Connection* self, PyObject* args)
                       ^
      2 warnings and 2 errors generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pysqlite3
  Running setup.py clean for pysqlite3
Failed to build pysqlite3
Installing collected packages: pysqlite3
  Running setup.py install for pysqlite3 ... error
  error: subprocess-exited-with-error

  × Running setup.py install for pysqlite3 did not run successfully.
  │ exit code: 1
  ╰─> [46 lines of output]
      running install
      running build
      running build_py
      creating build
      creating build/lib.macosx-12.6-x86_64-3.9
      creating build/lib.macosx-12.6-x86_64-3.9/pysqlite3
      copying pysqlite3/__init__.py -> build/lib.macosx-12.6-x86_64-3.9/pysqlite3
      copying pysqlite3/dbapi2.py -> build/lib.macosx-12.6-x86_64-3.9/pysqlite3
      running build_ext
      Builds a C extension linking against libsqlite3 library
      building 'pysqlite3._sqlite3' extension
      creating build/temp.macosx-12.6-x86_64-3.9
      creating build/temp.macosx-12.6-x86_64-3.9/src
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -Qunused-arguments -DMODULE_NAME="pysqlite3.dbapi2" -I/usr/include -I/Users/jace/.pyenv/versions/3.9.2/include/python3.9 -c src/blob.c -o build/temp.macosx-12.6-x86_64-3.9/src/blob.o
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -Qunused-arguments -DMODULE_NAME="pysqlite3.dbapi2" -I/usr/include -I/Users/jace/.pyenv/versions/3.9.2/include/python3.9 -c src/cache.c -o build/temp.macosx-12.6-x86_64-3.9/src/cache.o
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -Qunused-arguments -DMODULE_NAME="pysqlite3.dbapi2" -I/usr/include -I/Users/jace/.pyenv/versions/3.9.2/include/python3.9 -c src/connection.c -o build/temp.macosx-12.6-x86_64-3.9/src/connection.o
      src/connection.c:1303:9: warning: 'sqlite3_trace' is deprecated: first deprecated in macOS 10.12 [-Wdeprecated-declarations]
              sqlite3_trace(self->db, 0, (void*)0);
              ^~~~~~~~~~~~~
              sqlite3_trace_v2
      /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sqlite3.h:3223:36: note: 'sqlite3_trace' has been explicitly marked deprecated here
      SQLITE_API SQLITE_DEPRECATED void *sqlite3_trace(
                                         ^
      src/connection.c:1306:9: warning: 'sqlite3_trace' is deprecated: first deprecated in macOS 10.12 [-Wdeprecated-declarations]
              sqlite3_trace(self->db, _trace_callback, trace_callback);
              ^~~~~~~~~~~~~
              sqlite3_trace_v2
      /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sqlite3.h:3223:36: note: 'sqlite3_trace' has been explicitly marked deprecated here
      SQLITE_API SQLITE_DEPRECATED void *sqlite3_trace(
                                         ^
      src/connection.c:1328:10: error: implicit declaration of function 'sqlite3_enable_load_extension' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          rc = sqlite3_enable_load_extension(self->db, onoff);
               ^
      src/connection.c:1328:10: note: did you mean 'pysqlite_enable_load_extension'?
      src/connection.c:1315:18: note: 'pysqlite_enable_load_extension' declared here
      static PyObject* pysqlite_enable_load_extension(pysqlite_Connection* self, PyObject* args)
                       ^
      src/connection.c:1352:10: error: implicit declaration of function 'sqlite3_load_extension' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          rc = sqlite3_load_extension(self->db, extension_name, 0, &errmsg);
               ^
      src/connection.c:1352:10: note: did you mean 'pysqlite_load_extension'?
      src/connection.c:1338:18: note: 'pysqlite_load_extension' declared here
      static PyObject* pysqlite_load_extension(pysqlite_Connection* self, PyObject* args)
                       ^
      2 warnings and 2 errors generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> pysqlite3

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

Your system sqlite3 appears to not support runtime loadable extensions, would be my guess. I suggest installing a newer SQLite and building a statically linked pysqlite3. Instructions are in the readme.


Fixed mobile zooming issue

Problem
I have fixed the issue on mobile devices when you click on a input field the application the page zooms in, this is unwanted because it creates a jarring experience for the user.
Solution
Change the line:
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
to:
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=0"/>
This has been tested locally by myself, on the login page (I couldn't figure out what the credientials are proberly a pebcak issue, maybe implement a signup page, like in Wordpress or Nextcloud)

Hey, will look on this later.
Meanwhile what do You mean that You had problems with credentials? Demo or local?

Meanwhile what do You mean that You had problems with credentials? Demo or local?
Yeah, I set it up with Xampp because I was being lazy and didn't want to setup a linux vm... I probably should have, I know more about web hosting on Linux.
I just straight up didn't know what to use as the password.

Oh my... I forgot it in documentation... what a fail. WIll add it in a moment.

Ah, no worries!

Oh no wait.. it's there:
https://volmarg.github.io/installation/
Building cache
I will move that to separate section.

Ok I've added section:
https://volmarg.github.io/installation/
Creating user

Lovely, It's now clearer! Even an idiot(@cooperj) can do it!

In other news, I've got my account sorted!

I can sit tommorow to this.
Can You provided me data like:

Url (where is this happening)
screenshot of current behaviour
screenshot of fixed behaviour

I can sit tommorow to this.
Can You provided me data like:

Url (where is this happening)
screenshot of current behaviour
screenshot of fixed behaviour
which browser are You using
what are Your mobile view settings

I've checked this on upload page but don't see any problem.

Yeah, it's just when opening any input field... i've been testing with the login page, because its easy.
The current behavior, the browser is zoomed in, to focus on that field.
Fixed behavior, the browser doesn't move.
Chrome on iOS
What is the mobile view settings?
this is what is looks like before

this is what is looks like after

I will check that out later on my smarphone once it's charged - either this is specifically something smarphone based or iOS based.

Yeah and no, I noticed somebody with a similar issue on one of my projects. He was using a pixel.

I'm sorry but I cannot recreate this problem.
This is not happening on:

my smartphone "Xiaomi Redmi 4A",
webtools mobile view,
Nox emulator,

You using Chrome on you phone?

Yeah

Strange, I must grab my android device to test it... I wonder if the problem is iOS specific...

From: Dariusz<EMAIL_ADDRESS>Sent: Sunday, September 1, 2019 7:55:45 PM
To: Volmarg/personal-management-system<EMAIL_ADDRESS>Cc: Joshua Cooper<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Volmarg/personal-management-system] Fixed mobile zooming issue (#8)
Yeah
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Volmarg/personal-management-system/pull/8?email_source=notifications&email_token=AG367OU5ID3JA2W4TDO2RATQHQF3DA5CNFSM4INE46DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UIQGA#issuecomment-526944280, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG367OQZENJ4C2YQGGUQZN3QHQF3DANCNFSM4INE46DA.
Kind Regards,
Joshua Cooper
Maker | Programmer | Student
Websitehttps://joshuacooper.co.uk · GitHubhttps://github.com/cooperj · LinkedInhttps://linkedin.com/in/joshcoopertech
This email message is for the addressed recipient only. If this is not yourself, please delete this email and contact the sender. We put the security of your inbox at a high priority. Therefore, we have put efforts into ensuring that the message is error and virus-free. Unfortunately, full security of the email cannot be ensured as, despite our efforts, the data included in emails could be infected, intercepted, or corrupted. Therefore, the recipient should check the email for threats with proper software, as the sender does not accept liability for any damage inflicted by viewing the content of this email. Please consider the environment before printing this email.

I can confirm that this issue is not happening on my Android Phone, must therefore be an iOS only issue...
You may need to get access to an iOS device to test this.

I will think near weekend what can I do with this - thanks for info.

I've managed to confirm that it does exist on iPhone (https://snack.expo.io) and to see how it behaves. Will check out how Your changes affect current project and then I can decided if I can merge it.

Approved - doesnt seems to break view on desktop.


Twig assets

I did followed your tutorial twig-webpack-extension-setup with this skeleton which getting error 404. Do you have any idea what cause the problem?

I'm not sure what you have tried, but try this:

Run: npx webpack --mode=development or just npx webpack to build the assets
Then check if the files exists in the public/assets/ directory
If you run your site / app in a sub-directory, make sure you set the correct base href of the html document, e.g.

<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8">
    <!-- other stuff -->
    <base href="{{ base_path() }}"/>
    <!-- other stuff -->

Show me the F12 developer toolbar response.

Just creating own simple cms to learn.
I already did mentioned things. Console return 404 errors.

Looks good, so far. Try to find the "correct" url for the js/css assets manually.

Actually same working on Hosting server but in the localhost. Any idea for it.?

Sounds like an typical basePath issue if you run Slim in an sub-directory (applies for most development environments). Please give me more details (error message & code, screenshot, directory, etc...).

Running directory is c/wamp/www/dts(simple cms). I used your skeleton nothing else. I added some screenshot here. please let me know if you need anything else. Thank you.
Container:

Middleware

Error:

Composer.json

Your app is running in a sub-directory (under c/wamp/www/dts). So the BasePathMiddleware should set Slims basePath to /dts automatically for you.
What is the output of the Twig helper function base_path() ?
in your layout/layout.wig file here:
 <base href="{{ base_path() }}/"/>

On your localhost the output should be: <base href="dts/"/>
On your prod server the output should be: <base href="/"/>

Is your host root pointed to the public directory inside dts?

What is the output of the Twig helper function base_path() ?

@odan Return <base href="/"/> - where do i change that?

Is your host root pointed to the public directory inside dts?

i think yes. C:\wamp\www\dts>php -S localhost:8080 -t public public/index.php

Good hint from @dunkoh. I thought you are using apache. If you use the PHPs internal webserver, then you may try this command:
cd c:\wamp\www\dts
composer start
The same command without composer:
cd c:\wamp\www\dts
php -S localhost:8080 -t public
Then navigate to: http://localhost:8080/
The base href should then look like this: <base href="/"/>

@odan Which is works cool!. Thank you.


[MTDSA-1007] Explicit auditing for period creation and tax calculations.

Add switch for authorisation.

👍


not able to install punctuator2 library in Mac m1.

I am using this library in Mac intel chip. and everything work fine for me.
When I update my system and try to install this library in new Mac M1 it's throw error.
I am new in python. Please help me.
ERROR: Command errored out with exit status 1: /Library/Developer/CommandLineTools/usr/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/1z/b8__0s5x5198lhpnjw4st7k00000gn/T/pip-install-wyoslhsx/numpy_dddb7fa28a3049d0a6f1f98813557aee/setup.py'"'"'; file='"'"'/private/var/folders/1z/b8__0s5x5198lhpnjw4st7k00000gn/T/pip-install-wyoslhsx/numpy_dddb7fa28a3049d0a6f1f98813557aee/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(file) if os.path.exists(file) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /private/var/folders/1z/b8__0s5x5198lhpnjw4st7k00000gn/T/pip-record-l4o0vkxn/install-record.txt --single-version-externally-managed --prefix /private/var/folders/1z/b8__0s5x5198lhpnjw4st7k00000gn/T/pip-build-env-_rwtp71z/overlay --compile --install-headers /private/var/folders/1z/b8__0s5x5198lhpnjw4st7k00000gn/T/pip-build-env-_rwtp71z/overlay/include/python3.8/numpy Check the logs for full command output.
ERROR: Command errored out with exit status 1: /Library/Developer/CommandLineTools/usr/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/1z/b8__0s5x5198lhpnjw4st7k00000gn/T/pip-install-o3xh3hbc/scipy_404711783095485b99eb6cdcc92d9b05/setup.py'"'"'; file='"'"'/private/var/folders/1z/b8__0s5x5198lhpnjw4st7k00000gn/T/pip-install-o3xh3hbc/scipy_404711783095485b99eb6cdcc92d9b05/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(file) if os.path.exists(file) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /private/var/folders/1z/b8__0s5x5198lhpnjw4st7k00000gn/T/pip-record-634zzfvs/install-record.txt --single-version-externally-managed --user --prefix= --compile --install-headers /Users/pawankumar/Library/Python/3.8/include/python3.8/scipy Check the logs for full command output.

Hi finally I found I way to run this library on Mac m1
run these command and you good to go
brew install --cask miniforge
conda init zsh
conda activate
conda install numpy scipy scikit-learn
and then install the library
pip3 install punctuator

Thanks for the fix. Closing since the problem seems to be platform specific, for which there's not a solution.


[Forms] UI bugging on Android when using MediaManager into the a ListView

Sample: click here
Steps to reproduce :scroll:

Launch the provided sample

scroll a bit down

noticed the bug

Expected behavior :thinking:
The listview should display a white bottom since each item has Margin property set to "0,5". We created such style to separate each one of them and add a small top / bottom spacing for the first / last items.
Actual behavior :bug:
The white part is not being display. To me, it looks like it's related to the fact that a part of the MediaManager of the second item was being display at the end of the device's screen and when we are scrolling down, the UI is not being updated in some way.
Configuration :wrench:
Version:
MediaManager v0.4.5
MediaManager.Forms v0.4.5
Xamarin.Forms v<IP_ADDRESS>7273
Platform:
Bug noticed on Android (6.0.1) !
Another important information to notify is that I am using a Samsung A3 (A310FXXU3BQE1) and I am convinced that if you will test my sample with a device that is having a bigger screen you won't notified the bug.
Also I attached a .png files to show you the actual result vs the wanted one.

Hey guys,
If some people met the same issue, just so you know that I replace the MediaManager to finally use the native video players. You will find an example showing you how to implement them into this next sample ! ;)


refactor: temp disk, reconcile-private-host without go templates

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

github check seems borked but it's running over here https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=67640445&view=results


Add Feature Table

Resolve #5
Test URLs:

Before: https://main--shredit--stericycle.aem.page/
After: https://5-feature-table--shredit--stericycle.aem.page/en-us
After: https://5-feature-table--stericycle-shared--aemsites.hlx.page/en-us

@allanhero it doesn't display on mobile I assume that's how the current site works?

@allanhero it doesn't display on mobile I assume that's how the current site works?

That's right, that is how the current site works.


Add libpointmatcher_INCLUDE_DIR to match with CGAL

When using libpointmatcher with CGAL, <pointmatcher/PointMatcher.h> can't be found because libpointmatcher is not added to the list of included directories.
The reason for this is that CGAL wait for the libpointmatcher_INCLUDE_DIR variable when libpointmatcher set the libpointmatcher_INCLUDE_DIRS variable (with a S)

CGAL_pointmatcher_support.cmake
if(libpointmatcher_FOUND AND NOT TARGET CGAL::pointmatcher_support)
  add_library(CGAL::pointmatcher_support INTERFACE IMPORTED)
  set_target_properties(CGAL::pointmatcher_support PROPERTIES
    INTERFACE_COMPILE_DEFINITIONS "CGAL_LINKED_WITH_POINTMATCHER"
    INTERFACE_INCLUDE_DIRECTORIES "${libpointmatcher_INCLUDE_DIR}"
    INTERFACE_LINK_LIBRARIES "${libpointmatcher_LIBRARIES}")

endif()

Can one of the admins verify this patch?

ok to test

thanks!


Unable to set password with 63 symbols size and special characters

Hello, I'm trying to set 63 character wifi password with special symbols. When I'm trying to do it using telnet, i'm getting Invalid Command message.
Apparently due to using %#$!@ symbols escaping using \ before them, size exceeds allocated
uint8_t password[65];

Is it possible to increase size or fix esacping problem ?

Same problem here... Any updates?

Could you try that with a higher value of MAX_CON_CMD_SIZE at:
https://github.com/martin-ger/esp_wifi_repeater/blob/5fdca67c74f66bc5787883de78e9412378c18bba/user/user_config.h#L22

I spend one day trying to implement CI / DC build system, but failed compiling some dependency, so abandoned with this idea...

Could you try that with a higher value of MAX_CON_CMD_SIZE at:
https://github.com/martin-ger/esp_wifi_repeater/blob/5fdca67c74f66bc5787883de78e9412378c18bba/user/user_config.h#L22

That worked for me, thanks!


Refactor beacon/block to use CombinedChainDataClient

Description
The beacon/block endpoint is currently referencing ChainStorageClient and HistoricalChainDataClient and should be refactored to use CombinedDataChainClient to ensure we retrieve finalised blocks.

Related to #1161 and addressing comments in this PR: https://github.com/PegaSysEng/teku/pull/1217


[FEATURE] FeTS: Script for running all the models

Is your feature request related to a problem? Please describe.
FeTS needs a script for data collaborators to run all the models. This execution should follow an ordering specified in the following file:
https://hub.dkfz.de/s/Nj8Ceqw3DyfmyaM
This file needs to be replaced to an equivalent one, that uses mlcube ids instead of names.
Describe the solution you'd like
Script should be provided with the list of mlcubes to run
Peudocode:

Load the mlcube list file
Get the list of existing results with medperf result ls
remove the set of successfully-executed mlcubes from the mlcube list
For each mlcube in the list:

execute with medperf result create
if failed Continue to the next

In the chance that the mlcube list file changes, all we need to do is send the updated version to each data collaborator

FeTS scripts have been provided here


BUG: signal: Fix ShortTimeFFT.extent() for fft_mode == 'centered'

The frequency values of ShortTimeFFT.extent() are incorrect for ShortTimeFFT.fft_mode == 'centered'. This is fixed here and the relevant unit test is improved to cover all cases.
The following plot illustrates the problem, which utilizes ShortTimeFFT.extent() in its intended use case of producing the correct extent parameter for imshow .
The grid lines indicate the times and the frequency values of the STFT. The first row (ShortTimeFFT.fft_mode == 'onesided') depicts the expected result of the onsided FFT: In the left column (parameter center_bins=False) the time and frequency values are at the beginning of the respective bin; in the right column they are at the center of the respective bin.
It can be seen in the second row, which depicts the two-sided FFT,  that the frequency grid lines are at the incorrect place:

The corrections in this PR produce the desired results:

The following script was used to produce the plots:
import matplotlib.pyplot as plt
import numpy as np

from STFT import ShortTimeFFT

n, m = 12, 4
win = np.ones(m)
x = np.zeros(n)
x[m:2*m] = 1

fig0, axx = plt.subplots(2, 2, tight_layout=True)
for c_, fft_mode in enumerate(('onesided', 'centered')):
    SFT = ShortTimeFFT(win, fs=m, hop=m, scale_to='magnitude',
                       fft_mode=fft_mode)
    Sxx = SFT.spectrogram(x)
    for ax_, center_bins in zip(axx[c_, :], (False, True)):
        extent = SFT.extent(n, center_bins=center_bins)
        ax_.imshow(np.sqrt(Sxx), origin='lower', aspect='auto', interpolation=None,
                   extent=extent, cmap='viridis', vmax=1)
        ax_.set_xticks(SFT.t(n))
        ax_.set_yticks(SFT.f)
        ax_.grid(True)
        ax_.set(title=f"{fft_mode}, {center_bins=}",
                xlabel=f"Time ({SFT.p_num(n)} points)",
                ylabel=f"Frequency ({SFT.f_pts} points)")
plt.show()

Do you think it's worth adding the little snippet to the docs somewhere, maybe in or after https://docs.scipy.org/doc/scipy/tutorial/signal.html#sliding-windows ?

Good idea! I added it as an example  directly to the docstr of ShortTimeFFT.extent, because it is probably more discoverable there.
The test failure seems unrelated.

Pretty straightforward fix so in it goes, thanks @DietBru !


[imgui] Update to 1.89

Describe the pull request

What does your PR fix?
Fixes #27889, update imgui to 1.89. All features test pass on x64-windows x86-windows and x64-osx.

Closed as duplicate of https://github.com/microsoft/vcpkg/pull/27838.


Bug: Resources tab doesn't update correctly

Steps to reproduce:

Visit the start page (https://caniuse.com/)
Search for "container". Click Resources for the first result ("CSS Container Queries"). 6 resources for CSS Container queries show
Search for "grid". Click Resources. 9 resources (for Grid) show.
Search for "container" again. Click Resources for "CSS Container Queries".  It still shows the 9 resources for CSS Grid (the previous search's results).

Expected behaviour:
On step 4, the Resources for CSS Container Queries should show.
Environment:
macOS Big Sur 11.4
Chrome 92.0.4515.159 (Official Build) (x86_64)

Thanks for catching! Found the issue and it should be fixed now. Can you confirm?

Confirmed, works as expected now! 😄


Inconsistent import Behavior when using Lodash

Describe the bug
Inconsistent import Behavior for Libraries with or without Optimization.
Sometimes Lodash cannot be imported properly. ( I havent tested it with other Libaries atm)
Reproduction
There are multiple ways to reproduce this Bug:

Default Vite Config

use "import split from 'lodash/split'

terminal will output:

[vite] Avoid deep import "lodash/split" (imported by<EMAIL_ADDRESS>
because "lodash" has been pre-optimized by vite into a single file.
Prefer importing directly from the module entry:

  import { ... } from "lodash"

console will output:

SyntaxError: import not found: default

Fix:
import split from 'lodash'

then its not tree shaked

Disable Deep Optimization like this in the Config

    optimizeDeps: {
        exclude: [
            'lodash'
        ]
    }

Old Terminal Output will be gone
Console Output will be the same

This Issue doesnt occur in the vite.config.js itself, if lodash is imported there like in example 1.
If lodash-es is used instead it outputs the same as above from main.js,
But if it is used in vite.config.js, then this error occurs:
import baseToString from './_baseToString.js';
^^^^^^

SyntaxError: Cannot use import statement outside a module

System Info
"lodash": "^4.17.15",
"lodash-es": "^4.17.15",
"vue": "^3.0.0-beta.14"
"vite": "^0.20.5",
"@vue/compiler-sfc": "^3.0.0-beta.14"

Windows 10 64 Bit 2004
Node: 12.16.1
NPM: 6.13.4

You should be using lodash-es and then import { split } from 'lodash-es'

How should i import lodash in packages that are used both in the server and client?
I cannot import from lodash-es because nodejs still does not support ESM
I should not use lodash because of bigger bindle size
import from lodash/function was the best solution IMHO


allow more recoverable V3000 parsing errors when strictParsing=false

Allows a couple of additional problems with v3000 mol files to be ignored when strictParsing=false:

missing SGroup section
mssing END SGROUP
missing BEGIN/END OBJ3D (no tests for this, but we don't have any tests for OBJ3D anyway)

Additionally: if there aren't enough SGroups we'll now generate an error unless strictParsing is false

@ricrogz , @d-b-w : this should resolve SHARED-7892


feat(grafana): gitlab dashboard improvement to include issues, prs an…

missing stats in grafana dashboard for gitlab
#6409
Summary
include issues, prs handled and cicd metrics in gitlab dashboard
Does this close any open issues?
Closes #6409
Screenshots

Other Information
the dashboard contain same structure of GitHub

@Startrekzky Can you take a look at it?


InitWithCoder implementation

Fixes https://github.com/contentful-labs/Concorde/issues/7

Hm, Travis fails with:
failable initializer 'init(coder:)' cannot override a non-failable initializer
But both are failable. @neonichu could you, please, help me?

Fixed by 61856c5719c6beb6ac4d4a5f37efff407eb07c93


Source dists on PyPI cannot be installed

Binary dist (wheel) can still be installed.
The problem is that setup.py tries to get the version by running git commands, which doesn't work without the git repository, like when having downloaded the source dist.
Reproduce with: $ pip install --no-binary ":all:" py-smart-gardena==0.6.16
Error message (without traceback):
Collecting py-smart-gardena==0.6.16
  Using cached py-smart-gardena-0.6.16.tar.gz (12 kB)
    ERROR: Command errored out with exit status 1:
[...]
    Complete output (12 lines):
    fatal: not a git repository (or any of the parent directories): .git
    Traceback (most recent call last):
[...]
    subprocess.CalledProcessError: Command '['git', 'describe', '--tags', '--long', '--dirty']' returned non-zero exit status 128.
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Works for me with the latest release:
$ python -m venv .
$ source bin/activate
(gardena) $ pip install --no-binary ":all:" py-smart-gardena==0.7.9
Collecting py-smart-gardena==0.7.9
  Downloading
[...]
https://files.pythonhosted.org/packages/6b/34/415834bfdafca3c5f451532e8a8d9ba89a21c9743a0c59fbd0205c7f9426/six-1.15.0.tar.gz
Installing collected packages: chardet, idna, urllib3, certifi, requests, oauthlib, requests-oauthlib, six, websocket-client, py-smart-gardena
    Running setup.py install for chardet ... done
    Running setup.py install for idna ... done
    Running setup.py install for urllib3 ... done
    Running setup.py install for certifi ... done
    Running setup.py install for requests ... done
    Running setup.py install for oauthlib ... done
    Running setup.py install for requests-oauthlib ... done
    Running setup.py install for six ... done
    Running setup.py install for websocket-client ... done
    Running setup.py install for py-smart-gardena ... done
Successfully installed certifi-2020.6.20 chardet-3.0.4 idna-2.10 oauthlib-3.1.0 py-smart-gardena-0.7.9 requests-2.24.0 requests-oauthlib-1.3.0 six-1.15.0 urllib3-1.25.10 websocket-client-0.57.0
WARNING: You are using pip version 19.3.1; however, version 20.2.3 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.


Testing alternative notation for network definitions

I went ahead and created this so that I could provide comments

That's great! Thanks!  Not sure how the PR works with my new branch, but I guess I'll learn by doing... and by screwing up!  Seniors' moment: how do I incorporate lodash into this ever-growing construction?

Help!  I have added defproc checks to  alternative_network_defs and updated network fbptestxx and a couple of others.  npm test and Travis are now failing massively!  Where are the networks that are failing when I run npm test?
The biggie is that reader.js doesn't seem to be passing data back from the callback to the process (?) - it used to work!  It's been a while since I worked on this - I am wondering if JS has changed how callbacks are handled...  Could you do me a big favour and look at fbptest02.js and reader.js? (I have added a few console.logs to reader.js)
While I am working in a branch, what do I do about your other PRs - probably dumb question!
Lastly, we have to go out for the rest of the day - I'll have a little more time tomorrow morning, and then not much until Monday!  Sorry!

This is actually great!
The code that is failing is because the process name is not given in the tests... just as we wanted.
Those networks are in test/components/*.js

I fixed the tests that are failing due to a missing process name and pushed to this branch

That's great!  Thanks!
Have to leave for the day shortly - I'm really curious about reader.js -
hope you can figure it out!  That callback stuff was based on a suggestion
by Bruno Jouhier, and was working - does it still work in master?  Maybe
you could test it, and then we could go from there...?  I could also try to
find the original correspondence with Bruno...
Thanks,
Paul
On Thu, Jun 2, 2016 at 12:51 PM, Dan Rumney<EMAIL_ADDRESS>wrote:

I fixed the tests that are failing due to a missing process name and
pushed to this branch
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jpaulm/jsfbp/pull/63#issuecomment-223352378, or mute
the thread
https://github.com/notifications/unsubscribe/AATGJ5P2L6aEJ_zLSzEnXbv-tQxenlkUks5qHwn-gaJpZM4IsHMf
.

I'm closing this as it's out of date. I'll open a new one

I opened #66
As for the other PRs. If you're OK with them, just indicate with a comment and I can get them all merged (it may take a little massaging).
Otherwise, have a great weekend and we'll catch up on Monday.


Upgrade checks should properly handle cluster services the installer deployed

I have a default install of KET 1.8.1 with no other workloads deployed.
I upgraded the kismatic-cluster.yaml to leverage Kubernetes 1.9.3
After performing kismatic upgrade online --verbose I received the following errors ...

This is an issue with all upgrades not just that specific version. The upgrade needs to be reworked to correctly handle errors for services that are deployed by KET.
For current versions you can hit "Y" when prompted to continue or use the --ignore-safety-checks option.


Enable example testing

For #2331

Change List

added new test examples
fixed the golden images of examples that did not pass the test

What's wrong with the react-app image

What's wrong with the react-app image

@Pessimistress
It is a dropdown list which allows you to display different layers.

In the react-app golden image, the base map is not fully loaded. This is not going to work on other people's machines or networks.

The moved json examples need to be named something meaningful e.g. json-pure-js, json-react


Cannot assign color to individual shapes in a Shapes layer

🐛 Bug
It is not possible to assign an individual color to an individual shape within a shape layer. Colors for all shapes must be supplied. This is true for both edge_color and face_color
This should either be documented or updated to be more intuitive, took me several hours to figure out!
To Reproduce
Steps to reproduce the behavior:
Run this in the napari console:
import numpy as np

shapes = np.array([[[0, 0], [20, 0], [20, 20], [0, 20]], [[30, 0], [50, 0], [50, 20], [30, 20]]])
colors = np.array([[1., 0., 0., 1.], [0., 1., 0., 1.]])
colors_new = np.array([[0., 0., 1., 1.], [0., 1., 1., 1.]])

viewer.add_shapes(data=shapes, shape_type='polygon', edge_color=colors, face_color=colors)

# doesn't work, colors not updated in the viewer, no exception or message thrown
viewer.layers['shapes'].face_color[0] = colors_new[0]
viewer.layers['shapes'].face_color[1] = colors_new[1]
viewer.layers['shapes'].refresh()

# this returns `True`
(viewer.layers['shapes'].face_color == colors_new).all()

# works
viewer.layers['shapes'].face_color = colors_new

Expected behavior
Setting viewer.layers['shapes'].face_color[i] = colors[i] should either set the color in the GUI or throw an exception stating that color data must be provided for all shapes, basically  assert len(<provided colors>) == len(<existing shape data>)
Environment
Latest napari from main, here's the stuff from Help -> napari info:
napari: 0.4.14.dev112+g4c65afca
Platform: Linux-5.16.11-arch1-1-x86_64-with-glibc2.2.5
System: Arch Linux
Python: 3.8.12 (default, Oct 22 2021, 23:50:53) [GCC 11.1.0]
Qt: 5.15.2
PyQt5: 5.15.6
NumPy: 1.21.5
SciPy: 1.8.0
Dask: 2022.02.1
VisPy: 0.9.6

OpenGL:
- GL version: 4.6 (Compatibility Profile) Mesa 21.3.7
- MAX_TEXTURE_SIZE: 16384

Screens:
- screen 1: resolution 3840x2160, scale 1.0

Plugins:
- Mesmerize: 0.0
- console: 0.0.4
- napari-plot: 0.1.4
- scikit-image: 0.4.14.dev112+g4c65afca
- svg: 0.1.6

@andy-sweet would this bug be addressed by the new property API?

@andy-sweet would this bug be addressed by the new property API?

The issue here is mostly with the shapes data model (i.e. ShapesList), so maybe not. I tried to think of a workaround for the current API/implementation (other than using the face_color setter in the description) and couldn't come up with anything better / more efficient.
As part of the new property API / style encoding work, we may end up fixing this, but it's probably fixable without it too.
Reacting to the in-place modification of the color array is not currently possible because it's just a plain old numpy array, which is why the manual refresh is needed (though doesn't actually work here as it does for Points). We could wrap the array to react to in-place modifications (e.g. by overriding __setitem__), but we've held off on doing stuff like that for now.

At the very least we should probably make sure this is documented, that the colors can't be updated in place.
A work around is to use the same pattern as the GUI, e.g. if there are 3 shapes, this will make the first and third blue.
viewer.layers['Shapes'].selected_data = {0, 2}
viewer.layers['Shapes'].current_face_color = "blue"


Get the test scenario loading on 2.0.

The testing scenario hadn't been updated for 2.0, and didn't work at all (i.e. was crashing).
This change gets it technically working again, though it avoids the problem of creating factory fixtures. Instead, it shortcuts that process by using a raw export string.
Don't get too excited, this really isn't much. But it's an improvement. A potential negative is that it does technically change the mod code itself, which I was trying to avoid - removing interfaces/commands before adding them - but that strikes me as a pretty safe operation (though redundant in ideal circumstances.) That's caused by this approach needing to re-require control.lua.
I haven't yet convinced myself that this approach is the way forward (as you mentioned yourself on discord, it has some Issues), but at least this leaves it in a better place than it was.
Devlog
2024-10-24
GOAL: Set up devenv.
Cloned repo to mod directory.
PROBLEM: Mod doesn't load when launching debug. modfiles subdirectory needs to
be at the root level. Renamed repo directory to something else and made a
windows shortcut. Didn't work. Copy+pasted directory to verify it should work.
Found how to create "proper" symlinks on windows:
New-Item -Path factoryplanner -ItemType SymbolicLink -Value .\factoryplannerrepo\modfiles

Works.
PROBLEM: Scenarios don't show up.
Symlinked scenarios directory into modfiles. Probably would be cleaner to
symlink into user directory. Reference:
https://wiki.factorio.com/Tutorial:Mod_structure
PROBLEM: misc crashes loading testing scenario. Liberal commenting out and
updating to 2.0 (e.g. global to storage) got the scenario booting, though
not doing anything.
2024-10-25
PROBLEM: Need test suite to actually do something. Start uncommenting and
actually figure out what's going on.
Need to make Factory constant available in tests.lua.
local Factory = require("__factoryplanner__.backend.data.Factory")

require works, but has picket up the init and unpack functions. get
doesn't exist anymore, but looking at usage plausible that unpack is the
replacement function ... but has a different API.
Hrmm maybe not, looking at type of import_factory.
process_export_string is returning nil, breakpointing to step through it.
We're getting a migration failure.
So: the test fixture data is in an old format. 1.1.42. This is before 1.1.60 which is first migratable version.
So: we need new fixture data. Can we export from mod? Or simply construct by looking at data constructors?
The fixture data is created in parts.lua, which hard codes version strings.
Confirmed can export a string from mod proper, so let's use that and try to reverse engineer.
Ok it loads now, but solving fails because factory is not in a district. (Line:get_surface_compatibility)
Let's try regening with a district? Feel like it might still fail coz we're in a testenv and no surfaces?
Actually maybe just looking for compat between district and machines/recipes.
So factory export from ingame mod is specific just to factory and doesn't include district. So we need another way to rehydrate that data.
For now will comment out in Line and see if we can make progress.
Found one more line trying to find pollution type, commented that out also.
Altered test body to locate an item in the factory as a proof-of-concept.
Messy, but this is technically testing something now.
The default District initialiser contains a default location, so adding one of
those to the test subfactory lets us remove hacks.
Added print to control.lua so that results are printed to console as well as file.
Pretty sure the code to dump errors to results.txt is broken, but don't care at this point.
PROBLEM: Still have some commented code in the main modfiles that need to be reverted before merge is possible.
Files are being double-required. First by the scenario control.lua, second by
the mod control.lua. This causes problems when e.g. adding an interface in
screenshotter.lua
Really wanted to avoid changing main modfiles, but think need to make them
idempotent by removing commands first. Otherwise need to do a lot of work in
test harness to sort out requires.

Thanks again for this, I'll have a look at it once I'm less inundated with bug reports!

Okay finally had a look, sorry for taking forever, should have done this sooner for such a low-risk change. I'm terrible with PRs lol.
Anyways, appreciate the log, interesting to read! The changes to the commands are fine, although it probably makes more sense to check for existance instead of removing then re-adding. I'll change this after merge.
Otherwise, looks good. You already noticed a few issues with all this, and there not being perfect answers. Feel free to take whatever path makes sense to you, I'm not married to any approach in particular. Thanks again.


Attrs class for CMAQ config

[x] Add a config file for the CMAQ set up
[x] Move config files in config folder
[x] Define a class for the CMAQ configuration object
[x] Add validators for the CMAQ config
[x] Run tests in checks on GitHub

@lewisjared I think this is ready to be reviewed.
One thing I haven't dealt with yet is checking the formats for the configuration, so specifically: do some of the values have to be in a list or not, e.g. ["d01"] or "d01". I can say that it works if they are all in a list and does not work if they are all not in a list. I haven't found a quick way to check the individual values as everything has to run in the Docker container and I'm not sure if it's worth the effort.
As discussed, the tests run in the ci as separate step now. I will look into running them with the integration test in parallel tomorrow.

Nice. Can you also run ruff before merging

I usually go through all the files and click on Code -> Reformat Code (with the ruff plugin). Is there a better way to do this?


Regression in release compilation time on iOS

SkiaPerf is reporting a regression in initial release compilation time on the commit https://github.com/flutter/flutter/commit/22e4088134b80c63faf3abd98bfbae8abe7ea8d6
https://flutter-flutter-perf.skia.org/e/?begin=1694115415&end=1695348859&keys=Xeb53656b4f751dea0b79aba8134af69c&requestType=0&selected=commit%3D36961%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253Drelease_initial_compile_millis%252Ctest%253Dflutter_gallery_ios__compile%252C&xbaroffset=36963
The regression is  ~77s -> ~85s.
cc @cyanglaz

Multiple apps' compilation time has regressed, so not just a fluke:
https://flutter-flutter-perf.skia.org/e/?keys=X15b7647f191f2b39c8710699cc4b7ee6&selected=commit%3D36961%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253Drelease_initial_compile_millis%252Ctest%253Dbasic_material_app_ios__compile%252C&xbaroffset=36961

There are more artifacts (extension_safe version of Flutter.framework) to download after https://github.com/flutter/flutter/commit/22e4088134b80c63faf3abd98bfbae8abe7ea8d6.
This is expected.
Maybe we can add a tool command to download the extension safe framework separately when only needed?

Makes sense. On reading the benchmark code, the "initial" compile benchmarks include artifact download time. The "full" compile benchmarks do not. Since there was no regression in the "full" compile benchmark, I'll go ahead and close this.


container.stop() is not a function

Hi there, thanks for the great node lib!
I'm using it to run some tests with jest and getting the message:
Test suite failed to run
    TypeError: pgContainer.stop is not a function

My code:
/* eslint-disable no-undef */
const { GenericContainer } = require('testcontainers');
const pgContainer = new GenericContainer('postgres').withEnv('POSTGRES_USER', 'test').withEnv('POSTGRES_PASSWORD', 'test').withExposedPorts(5432);

beforeAll(async () => {
  await pgContainer.start();
});

afterAll(async () => {
  await pgContainer.stop();
});

describe('Controller' tests, () => {
  it('should create something', () => {
    expect(1).toEqual(1);
  });
});

Any ideas why is this happening?

Hi @andreybleme
The variable pgContainer is a GenericContainer.
Calling await pgContainer.start() returns a StartedContainer which has a stop() method.
You probably want pgContainer to be the started container


Array of tasks in after/before are reversed

I am not sure what the reason the tasks list is reversed on before/after hooks:
https://github.com/deployphp/deployer/blob/bc708bec860b50be558840adb5c6db3c733d369e/src/Importer/Importer.php#L239-L250
This makes no sense as we have to write the tasks in the opposite order of their execution.

Don’t remember) we can remove it. I guess.

I just found out it was added in v7 1d137ad0 but the commit description doesn't mention anything about the tasks bein reversed and this behavior is not documented either

@antonmedv any update on this?

I found this behaviour unexpected and a bit confusing. At least it should be documented, but I believe even better the order should be changed to what most people would expect top of the list first, bottom last.

At you all: Feel free to provide a PR yourself, especially for so easy tasks like this.
Now 🤞 the CI is green :-)

@antonmedv I guess the YAML array order for me is different than what's shown in https://github.com/deployphp/deployer/issues/3431
Any idea what may cause this strange order difference?

I can confirm, that the order is still an issue for me as well.
As a breaking change, it would probably need to go into a major release.
@antonmedv can you reopen this issue, so we can track this?


unexpected result in hgetall with RESP3

Describe the bug
I'm using Ruby's redis-client gem to connect to Garnet.
Redis is properly returning a Hash, whereas Garnet is unexpectedly returning an Array.
Steps to reproduce the bug
> gem install redis-client
> irb
require "redis-client"
c = RedisClient.new
c.call "hset", "foo", "bar", "mike"
c.call "hgetall", "foo"
{"bar"=>"mike"} # Redis 7.2.3
["bar", "mike"] # Garnet main

Expected behavior
No response
Screenshots
No response
Release version
main
IDE
No response
OS version
No response
Additional context
No response

We are adding per-operator RESP3 support on an incremental and on-demand basis. Have covered ZRANGE in the linked PR.


extra_arguments doesn't work when downloading remote Terraform configurations

Imagine you have the following folder structure:
infra-live
└ global.tfvars
└ stage
    └ terraform.tfvars

The stage/terraform.tfvars has the following contents:
terragrunt = {
  terraform {
    source = "git::git@github.com:foo/bar.git//frontend-app?ref=v0.0.3"
  }

  extra_arguments "global" {
    arguments = [
      "-var-file=terraform.tfvars",
      "-var-file=../global.tfvars"
    ]
  }
}

When you run terragrunt apply in stage, it will fail, because it will download the Terraform code into a temporary folder, switch to that folder, and then try to use the relative path to global.tfvars. Since global.tfvars is in the infra-live folder and not the temp folder, it won't find it.

Ideas on possible fixes:

Explicitly parse extra_arguments for -var-file arguments and automatically copy those into the proper folder structure in the temporary folder. This sounds like it would be very messy.

Instead of downloading code into a temporary folder, download it into the current folder, run Terraform, and then clean up. Again, this sounds like it would be very messy.

Add a new helper similar to ${path.module}. For example:
arguments = [
  "-var-file=${path.module}/terraform.tfvars",
  "-var-file=${path.module}/../global.tfvars"
]

Terragrunt would automatically fill in the path of the original working directory, so those relative paths would become absolute paths.

#3 seems like the proper solution and it should be pretty easy to implement. Anyone up for a PR?

As a workaround you can symlink ../global.tfvars into your stage directory and reference the symlink file into the extra_argument block. This way you can reuse the same global.tfvars everywhere without code duplication.
example:
infra-live
└ global.tfvars
└ stage
    └ terraform.tfvars
    └ global.tfvars (symlink -> ../global.tfvars)

stage/terraform.tfvars:
terragrunt = {
  terraform {
    source = "git::git@github.com:foo/bar.git//frontend-app?ref=v0.0.3"
  }

  extra_arguments "global" {
    arguments = [
      "-var-file=terraform.tfvars",
      "-var-file=global.tfvars"
    ]
  }
}

Fix here: https://github.com/gruntwork-io/terragrunt/pull/168. Feedback welcome!

Whoops, meant to hit comment, but hit close. Reopened this one until #168 is merged :)

Fixed by #170.


Change logger used for stream debug

Was using self.logger but no messages were showing up, even when the provider or global log level was debug or verbose. Use the same logger as other messages in provider and now they print.

So should all the logging be changed away from this?


[5.4] Removed the hard dependency on parsedown

We may still want to install parsedown by default in new laravel 5.4 apps though, similar to with the tinker package.

Will do in 5.5.


Shanghai Pocket Color

Hi, I was wondering if someone could create a save state patch for Shanghai Pocket (U) (V1.1) [C][!]. Thank you for all your work!

Hi there,
I've now created a patch for this. Give it a try and let me know if any issues :)
One thing I noticed is that you need to wait at least until the title screen has displayed before loading the save state, otherwise the audio will be very loud.

Thank you so much for creating this! And thanks for the heads up on the waiting. I tried it out and it seems to work fine!


Integrate Coveralls and separately build Scala module on Travis

Closes #1548 and #1540

Looks good

I think closes xxx messages should go in the PR description. Or if you found otherwise could you link that?

What's the relation of this PR to the other two related Scala and Coveralls PRs?

This is the successor, it includes both.

Sorry for the confusion @timowest. I didn't intend to open this PR. I was testing the combination of these two features in my fork and GitHub tricked me into opening the PR on querydsl instead of my fork, but since it's here I'll just use it to close the other two PRs.

I renamed -pl to --projects as Ruben suggested in #1548.

Could you backport this, since the versions used in the examples there are also old?

I suppose merging this is good now?

Yes. I'm backporting it right now.

So I am merging these now.


Default to service account auth

Author the user story for this feature
As a user, I want to run tests with the same credential as CI so I can have reproducible builds.
Describe the solution
Flank currently uses user auth and falls back to service credential authentication. We should consider the reverse.
https://github.com/Flank/flank/blob/458a12ed4a7b364f481101a749fbf0f7a408c8e8/test_runner/src/main/kotlin/ftl/adapter/google/Credentials.kt
I think there may be some historical context for why user auth is first, will be worth searching the old Flank issues/code to see if this has been discussed.

I was checking some tickets related to the service account but I can't find any discussion about it. I think this change can potentially fix #1792. I will create or asap

Realized in: https://github.com/Flank/flank/pull/1955.


Use dmcontent.govuk_frontend.render_question instead of show_question

We want to use dmcontent.govuk_frontend.render_question.

However, functional tests are failing locally because they've recently been updated to expect a standard date field for availability, and we're still using a text input since there was a variety of responses to that question.

🤔 Have you got DOS5 live locally?

Ah, that'll be it!

However, functional tests are failing locally because they've recently been updated to expect a standard date field for availability, and we're still using a text input since there was a variety of responses to that question.

🤔 Have you got DOS5 live locally?

Ah, that'll be it!


[20.09] go_1_16: backport to release-20.09

Motivation for this change
I can't be the only one that's had need for golang 1.16 on a stable base. Perhaps this isn't appropriate for merge for a branch that only has a couple of months to go, perhaps it is.
This is simply the state of go_1_16 in master as of commit eecacdf3d8d58ccc689b7194d33a5ba53a7bdd79 squashed to a single commit. I initially started off cherry-picking and editing the various commits that had got it to that state, but the result was an ugly and confusing mess of nonsensical partial commits.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116665 at b8d556c7 run on aarch64-linux 1

1 package built successfully:

go_1_16

1 suggestion:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/development/compilers/go/1.16.nix:6:3:
  |
6 | , fetchpatch
  |   ^

I'm not really sure how I feel about this. I understand the need to access Go 1.16. Why not pull it as an overlay from unstable? That said, I don't feel strongly against it, especially that it does not actually become the default version. I'm not sure how others would feel about the lack of cherry-picking of commits.

Why not pull it as an overlay from unstable?

Just convenience. Telling colleagues they've all got to set up a particular overlay to get a set of software running is annoying, when working with pinned setups it's a bit painful having to throw around multiple nixpkgs. And instead I can smooth off this sharp corner, saving the next person who hits this the bother of thinking about it.

I need this to fix the minio vulnerabilities in 20.09 https://github.com/NixOS/nixpkgs/issues/120398 https://github.com/NixOS/nixpkgs/issues/116893.


change the port in visdom and get error:  'No connection could be formed quickly'

I define a visdom visa selected port
python -m visdom.server -port 2002
and then when i do
viz = Visdom()
assert viz.check_connection(), 'No connection could be formed quickly'

I get the error that
AssertionError: No connection could be formed quickly
Any suggestion

Duplicate of #426, details can be found there.


Refactor

-Used composition over inheritance in linear models/family
-IOHMM code more clear
-Tests added

This change is

Coverage increased (+57.6%) to 78.04% when pulling f5bb212952aa0773cd9ee8f714fd9c3c09882398 on refactor into 5b1b82f7e6dbd3eb44cbf5c1d7f7a983b151f82c on master.


[Question] Advantages of react-query over swr

Issue
The client application leverages react-query to hydrate the UI. Since the application is built with Next.JS, what do you think of the advantages of using react-query over Vercel's own solution 👉  swr.vercel.app?

To be honest, I haven't spent the time researching on the Pros and Cons of swr and react-query.
react-query is the library that I give a try first and am happy with it so I haven't tried swr yet.
Upon looking into the feature comparison provided by React Query
Generally, the difference between these two libraries lay in their advanced features which I haven't got the chance to use yet. Although from that document, it is clearly seen that React Query provides more features but I think we should research them ourselves if we have a need for those features since the document might be biased.
Anyway, In my opinion, the clear benefit of using react-query is it also supports other frameworks such as Vue and Solid so if we decide to change those frameworks, the learning curve is less than having to learn how to use the new library. (Keep in mind though that there might be other libraries for those frameworks that are significantly better than react-query.
On the other hand, the swr is smaller and it is supported by the Vercel team so there might be some optimizations specifically for Next.js. Although the second advantage is waived when using  theswr with other bundlers such as Vite or Create React App.

All good points 😀 swr does have a simple caching strategy IMO since it is based on a unique key value and the fetcher param plays nice with axios or any other custom utility that makes it easier to set up IMO too.


ORA-48189 OS command to create directory failed

Hi,
If I issue select * from dba_directories; I get the following error message ORA-48189 OS command to create directory failed.
Only from PDB but it works from CDB.
After creating a new container the query works well only the first time.
Any further trial results error.

I tried to set permissions recursively on /diag folder to 777 in the test enviroment.
I set permissions to 777 on /opt/oracle/oradata folder too

Oracle version 21.3.0 SE
Docker version 20.10.14
OS: Fedora 35 Server (SELinux is disabled)
Thank you in advance

@csekme I am unable to reproduce this on my machine.
OS: OL7
Docker version: 19.03
Oracle Database: Oracle 21.3 SE
This issue mostly caused by wrong permissions to $ORACLE_BASE/diag folder. It should be 775.
Can you share more details: your $ORACLE_BASE/diag permissions, docker container logs and the entire error that comes while running the command you specified ?


Add the option to update

Add a flag --update repo_name (for example) that allows you to update the underlying cookicutter-easydata framework

This is getting a lot easier, as I've added replay in #127, so we can now do a
cookiecutter --config-file repo_name/cookiecutter-easydata.yaml cookiecutter-easydata -f

and the module will be regenerated in place.
I think the best step after this is to give a little script to automatically create a branch and start a merge, since you'll inevitably have to solve a 3-way merge here.

Some others discussing this very idea:

https://github.com/cookiecutter/cookiecutter/issues/784
Some implementations of this idea
https://github.com/senseyeio/cupper (based on the below)
https://github.com/aroig/cookiecutter-latex-paper/blob/master/{{cookiecutter.project_slug}}/make/cookiecutter-update.py (uses update-template target, below)
https://github.com/aroig/cookiecutter-latex-paper/blob/master/{{cookiecutter.project_slug}}/Makefile (see update-template target)

So, I have a working git procedure to make this work.
We could incorporate the linked scripts above, but that would increase our git dependency to a later version (to support git worktree). Since this is presumably not a common thing to do, it can be worked around with documentation (the git operations) for now.

I should note, there's also this approach (a PR against cookiecutter directly).
https://github.com/cookiecutter/cookiecutter/pull/1173/files

I've written up a howto for now
https://github.com/hackalog/cookiecutter-easydata/wiki/Merging-Easydata-Changes-into-a-Generated-Project

I've moved the links above into the Merging Easydata Changes wiki page. Closing this unless automation becomes an issue.


feat(server): avoid manipulating position_ids for non-applicable models

Currently, position_ids are always maintained/updated in the CausalLM case but this is unnecessary for models like BLOOM which don't use them.

Closing as stale.
Thanks for the contribution Nick, happy to take some back now that we're back on Apache !
Cheers.


Task/cs/general cleanup

Two commits, first is non-code changes and the second is removing unused code (as directed by CLion and reviewed by me). Of course let me know if the code is vestigial or has some historical meaning that I don't know about :smiley:

And this compiles? 😁

And this compiles? grin

Yep, gotta love the compile checks :smile:
Most (if not all) of the removals are easily seen to not be used via searches

I kinda was joking, since we do have the CI pipe. I was surprised that _currentDECPosition isn't used anywhere, but _currentRAPosition is... but turns out we could eliminate _currentRAPosition as well and just use a local variable in Mount::loop() instead, since it's only used to correct backlash there.
Looks like there's a version problem somewhere too.

Yep, good points! I haven't updated the version stuff yet since this was kind of exploratory changes


modify curl images

Description
tutum/curl docker image is 404 Not found and seems to be currently unavailable.
So, modify the image used to execute the curl command on the sleep pod to curlimages/curl.
ref.
https://hub.docker.com/r/tutum/curl/
https://hub.docker.com/r/curlimages/curl

@akitok thanks for the PR! lgtm!


Moved: Vivaldi.Vivaldi version 4.3.2439.56

This pull request is automatically generated by 🥟 Dumplings
Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run


CorsService loads options on initialization with no method to modify

The CorsService class loads the cors.php config options when it's initialized, but there are no methods to modify the private $options property, so no config changes can be made after the initial load.
I need to be able to dynamically change some of the config settings. I had originally extended the HandleCors middleware where I expected to be able to do this, but this snag with the $options with no methods to modify it, has really put me in a tough situation.
Even just a method to "reload" the options from the config would be great as I can modify the config from config(['cors'] =>[])

For reference if anyone else wants to "hack" this. This is how I managed to do it with reflection:
class MyCors extends HandleCors
{

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $clients = $request->route('myparam');
        $domains = $clients->domains;
        $this->addDomainsToAllowed($domains);

        return parent::handle($request, $next);
    }

    protected function addDomainsToAllowed($domains)
    {
        $reflected = new \ReflectionObject($this->cors);
        $property = $reflected->getProperty('options');
        $property->setAccessible(true);
        $options = $property->getValue($this->cors);

        $options['allowedOrigins'] = $domains;

        $property->setValue($this->cors, $options);
    }
}

@Ben-Russell : Can you give me more details about myparam  ? Not sure if this hack would fix my issue (#360).

@alexszilagyi myparam is just an id/model from my route. In short, our app runs for many different clients/domains, and so I want to lock down an api request for a client to only be allowed on the domains that are associated to that client. This is where I'm dynamically querying the domains for that client and adding them to the allowedOrigins options per request.

This is a problem that I have come across recently too. The above "hack" does also work for me but there should realy be a cleaner way to this.
My app uses laravel-passport and is setting the allowed origins for accessing the underlying API based on the registered clients. Without that hack I would be forced to release a new build of my app every time a new client registers.

I'm closing this due to inactivity. If this issue is still relevant on the latest version (2.0.1 at the moment), please open a new issue with detailed information.

I m looking forward to this dynamic set allowed origins function as well. I am doing a multi-tenancy application which might have different domains or subdomain where I need to limit the access of api calling among different domains.


Swipe-to-dismiss improvements, code cleanup

Improves swipe-to-dismiss in a way that calculates with velocity (better UX), fixes #31 and cleans up transition code (makes it more swift and consistent).

Thank you for another great PR! I've just noticed small UI glitch when you open full screen mode, select image with different proportions and close the full screen. It worked previously, will try to look into that what's causing this.


Support thick-client uploads in server and Go client

Tested manually.
Still TODO: unify the 2 "stage" operations (semantics may be tricky because one references a staging token and the other does not).

Codecov Report

Merging #1670 (1165f46) into master (39323ff) will decrease coverage by 0.36%.
The diff coverage is 2.53%.

@@            Coverage Diff             @@
##           master    #1670      +/-   ##
==========================================
- Coverage   39.40%   39.04%   -0.37%
==========================================
  Files         167      167
  Lines       13611    13766     +155
==========================================
+ Hits         5364     5375      +11
- Misses       7485     7628     +143
- Partials      762      763       +1

Impacted Files
Coverage Δ

pkg/api/client.go
3.85% <0.00%> (-0.47%)
:arrow_down:

pkg/block/s3/adapter.go
0.00% <0.00%> (ø)

pkg/catalog/catalog.go
18.41% <0.00%> (-0.40%)
:arrow_down:

pkg/graveler/graveler.go
34.95% <0.00%> (-0.18%)
:arrow_down:

pkg/api/controller.go
32.99% <2.63%> (-1.23%)
:arrow_down:

pkg/block/namespace.go
58.33% <100.00%> (ø)

pkg/graveler/hooks_handler.go
100.00% <100.00%> (ø)

pkg/pyramid/tier_fs.go
62.44% <0.00%> (+3.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39323ff...1165f46. Read the comment docs.

Thanks for the review!  Pulling once tests pass...


Updated RadixSort.php

Assigned Issue Number ?
#136
Language Opted ?
PHP
Number of files added or updated ?
1
Name of these files ?
Algorithm => Sorting_Algorithms => Radix_Sort => radixSort.php
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Hi @ahampriyanshu,
I have completed the code in PHP, let me know if any changes that needs to be made in the radixSort.php file
Regards,
@jain13tushar


Added functionality for Book Now button for each package - Solution to Issue #57

Related Issue
None.
Description
Provided solution for Issue #57.
In index.html:

Changed the code for buttons under each package.
Moved the link rel tag for script.js before end of body tag to enable the functioning of button.

In script.js:
Added a code snippet for the Book Now button to point to the respective package pages.

Added packages folder containing all HTML files for the packages. I have provided the base content for each page. The page can be improved in future.

Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
Page for Goa package (other pages follow similar format):

Checklist:

[X] I have made this change from my own.
[ ] I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you! @rees8


Blueprint service journey for getting a form online

When deciding what an end-to-end self-service solution might look like, it will be helpful to understand what the current state journey is today, documenting: service gaps, pain points, supporting actors, and technologies used.
This workshop can be run with participants from programs, design, development, leadership, client support, and other stakeholders. The key is to have someone in the room that has insight into each channel a form builder must navigate to get a form online with GC Forms.
The outcome of the workshop is to build understanding and alignment throughout the team on where gaps and pain exist holistically throughout the service, from business requirements to user needs to technical constraints.

@connorscarolyns to review

This work is ongoing. Journey maps are being maintained, there could be opportunity in the future to revisit a workshop


linux bridge: switch to nispor for querying

Use nispor for bridge status query(including vlan filtering) and remove
the query code from NetworkManager plugin.
Since both nispor and NetworkManager plugin need to convert
nmstate state to kernel port VLAN format, the
ifaces/linux_bridge_port_vlan.py is added to hold the share functions.
The kernel will automatically compress adjacent VLAN IDs to VLAN range,
at the verification stage, LinuxBridgeIface will expand VLAN range to
single VLAN IDs.
Also move linux bridge only functions to LinuxBridgeIface().
Unit test cases added for ifaces/linux_bridge_port_vlan.py.

@maiqueb Could you review this PR?
The main purpose is querying base on kernel runtime status for bridge instead of reading NetworkManager on-disk config.
You may focus the review against libnmstate/ifaces/linux_bridge_port_vlan.py and libnmstate/nm/bridge_port_vlan.py.
Thank you!

@maiqueb Could you review this PR?
The main purpose is querying base on kernel runtime status for bridge instead of reading NetworkManager on-disk config.
You may focus the review against libnmstate/ifaces/linux_bridge_port_vlan.py and libnmstate/nm/bridge_port_vlan.py.
Thank you!

I'll reply in the next few days, but on the short look I've taken, it looks OK.


View<> lacks flatMap

Is this fixed

Is this fixed

This is a false positive. At that time, you were using Stream instead of View.

Oh! GG


Fix redefinition of non-GDI Windows basic types in win32structs.h

This causes some of the unit tests to fail to compile on Windows:

c:\users\hugh\documents\github\libgdiplus\src\win32structs.h(129): error C2371: 'TCHAR': redefinition; different basic types
c:\program files (x86)\windows kits\10\include\10.0.15063.0\ucrt\tchar.h(180): note: see declaration of 'TCHAR'

@hughbe,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

I've updated the PR to fix duplicate non-GDI definitions that are already supplied from Windows.h.
This also fixed a source compat issue with GDI+: it takes a wchar_t on Windows with GDI+, but an guint16 in libgdiplus.
However, this now causes the build on Windows to fail, due to:
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(25): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(25): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(71): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(71): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(119): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(119): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(168): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(168): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(220): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(220): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(274): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(274): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(328): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(328): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(410): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(410): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(481): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(481): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(636): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(636): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(693): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(693): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(762): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(762): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(801): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(801): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
1>c:\users\hugh\documents\visual studio 2017\projects\consoleapplication1\consoleapplication1\testgraphics.cpp(840): error C2664: 'GpStatus GdipLoadImageFromFile(const WCHAR *,GpImage **)': cannot convert argument 1 from 'gunichar2 *' to 'const WCHAR *'

I supposed one course of action could be to unconditionally define WCHAR as wchar_t on non-Windows platforms. This would fix the source compat issues against GDI+ on Windows.
E.g. the following code works on Windows. Before this PR, it failed to compile against libgdiplus on Windows, but it now does. However, it still fails to compile against libgdiplus on non-Windows platforms.
static void test_privateFontCollectionAddFontFile()
{
	GpStatus status;
	GpFontCollection *collection;
	GdipNewPrivateFontCollection (&collection);

	const WCHAR *directory = L"C:\\Users\\hugh\\Documents\\Visual Studio 2017\\Projects\\ConsoleApplication1\\ConsoleApplication1";
	const WCHAR *filename = L"C:\\Users\\hugh\\Documents\\Visual Studio 2017\\Projects\\ConsoleApplication1\\ConsoleApplication1\\CodeNewRoman.ttf";

	status = GdipPrivateAddFontFile (NULL, filename);
	assert (status == InvalidParameter);

	status = GdipPrivateAddFontFile (collection, NULL);
	assert (status == InvalidParameter);

	status = GdipPrivateAddFontFile (collection, L"");
	assert (status == FileNotFound);

	status = GdipPrivateAddFontFile (collection, L"NoSuchFile");
	assert (status == FileNotFound);

	status = GdipPrivateAddFontFile (collection, directory);
	assert (status == GenericError);

	status = GdipPrivateAddFontFile (collection, filename);
	assert (status == Ok);

	GdipDeletePrivateFontCollection (&collection);
}

@qmfrederik this may need some more discussion - let me know what you think.

@akoeplinger I've addressed your PR feedback, let me know if you need anything else

No real comments from my side, sorry for the delay, had some other things to attend to (and I'll be off for the coming weeks).
If it makes the unit tests work on both Unix & Windows, then LTGM :).
Do you have a vcxproj file for the tests? The tests do not seem to run as part of the Windows Jenkins build, correct?

@qmfrederik I did create one but it's ugly right now and I haven't had time to clean it up.
The problem is that each test file has it's own main method, so I'm not sure what the best way to do this is - we get compilation errors if they are all together in the same project

@hughbe Got it. Yeah, you can either create a .vcxproj file for each test - that would be closes to what's done in the Unix world.
Alternatively, you could try something like having one test executable, where you pass the name of the test as a command line argument.
For each test, you could rename the main method if being compiled as part of a vcxprpoj - for example by detecting _MSC_VER or a preprocessor variable you define on your own.
int
#if _MSC_VER
test_name_main (int argc, char **argv)
#else
main (int argc, char **argv)
{
#endif

It's still not ideal but may be a starting point.

Okay. I'll take a look at that in a future PR. Would something like googletest be a good idea?\
That aside, is there anything blocking this PR?

That aside, is there anything blocking this PR?

Nothing, I just got confused about what exactly this breaks from the comment in https://github.com/mono/libgdiplus/pull/73#issuecomment-312475633, but now I see it just makes things better. Thanks 👍


Error while parsing choose command

Got error mapping values are not allowed here at org.yaml.snakeyaml...
Example to get error:
- if true {
  - choose "1":
    - case "1":
      - narrate abc
}

Save and reload scripts.
We cant use choose command inside a codeblock because of yml parsing?

cannot put : notation inside a {} notated section :/  Easiest copy-and-paste fix is to bring the choose/case block into a task subscript and inject it. Alternately, rework the logical ordering of the script at hand a bit...

Thank you very much


Rename doesn't replace on Windows

On Windows one cannot use os.rename to overwrite a file:
  File "C:\Users\$USER\geo-activity-playground\geo_activity_playground\__main__.py", line 118, in make_activity_repository
    precompute_activity_distances(repository)
  File "C:\Users\$USER\geo-activity-playground\geo_activity_playground\core\similarity.py", line 29, in precompute_activity_distances
    with stored_object(fingerprint_path, {}) as fingerprints, stored_object(
  File "C:\Users\$USER\.conda\envs\geo-activity-playground\Lib\contextlib.py", line 144, in __exit__
    next(self.gen)
  File "C:\Users\$USER\geo-activity-playground\geo_activity_playground\core\tasks.py", line 30, in stored_object
    temp_location.rename(path)
  File "C:\Users\$USER\.conda\envs\geo-activity-playground\Lib\pathlib.py", line 1175, in rename
    os.rename(self, target)
FileExistsError: [WinError 183] Eine Datei kann nicht erstellt werden, wenn sie bereits vorhanden ist: 'Cache\\activity_distances.tmp' -> 'Cache\\activity_distances.pickle'

I just delete the old file before, this should fix it.

Version 0.20.0 is released you can update and try it out. If the issue persists, please reopen this ticket.

Version 0.20.0 is released you can update and try it out. If the issue persists, please reopen this ticket.


GET route parameters not getting passed (v2.2.0)

Lets assume I have a controller action like this one:
[ProducesResponseType(typeof(ServerResponse<IEnumerable<Province>>), 200)]
[HttpGet("provinces/{countryCode}")]
public async Task<IActionResult> ProvincesByCountryCode(string countryCode)
{
        var result = await _location.GetProvinceByCountryCode(countryCode);
        return Reply(result);
}

Using the SwaggerUI to test and populating the variable with "US", the following URL gets called:
http://localhost:2391/api/v1/data/provinces/{countrycode}  instead of
http://localhost:2391/api/v1/data/provinces/US
It is not passing the variable on the route, {countryCode} gets sent.
This worked perfectly on the 1.x release.

I can't repro this issue and therefore it's impossible to troubleshoot:

Can you try create a new project from scratch and see if it repros?

Bizarre. Any chance someone can provide repro steps starting from a blank app?

I've got similar behavior but as mentioned, web API routing has always had
issues with case sensitivity with parameters... Or so I thought, been doing
that since web API 1
On Wed., 14 Mar. 2018, 12:05 pm domaindrivendev<EMAIL_ADDRESS>wrote:

Bizarre. Any chance someone can provide repro steps starting from a blank
app?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/634#issuecomment-373120056,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFIxOmV0jltnEppRGdLaHksdx_rnla5Fks5teVvMgaJpZM4Sbeeb
.

Also httpcontext matching, any matching ties can invalidate it.

I just ran into this issue as well.
Got [HttpGet("{id}")] on my action and the UI picks it up as a path parameter as expected but when I try it out it's calling this

curl -X GET "http://localhost:5000/v1/Entity/{id}"

The {id} in the url doesn't get replaced with the entered value in the textbox.

Here's a minimal reproduction

Controller
namespace WebApplication5.Controllers
{
    public class Query
    {
        public int Id { get; set; }
    }

    [Route("api/[controller]")]
    public class ValuesController : Controller
    {
        // GET api/values/5
        [HttpGet("{id}")]
        public string Get(Query query)
        {
            return "value";
        }
    }
}

Startup
public void ConfigureServices(IServiceCollection services)
{
    services.AddSwaggerGen(c =>
    {
        c.SwaggerDoc("v1", new Info { Title = "My API", Version = "v1" });
    });

    services.AddMvc();
}

// This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
public void Configure(IApplicationBuilder app, IHostingEnvironment env)
{
    if (env.IsDevelopment())
    {
        app.UseDeveloperExceptionPage();
    }

    app.UseSwagger();
    app.UseSwaggerUI(c =>
    {
        c.SwaggerEndpoint("/swagger/v1/swagger.json", "My API V1");
    });

    app.UseMvc();
}

Id and id don't match in your query class, make the upper case one lower
case.
That work?
On Fri., 16 Mar. 2018, 9:30 am snebjorn<EMAIL_ADDRESS>wrote:

Here's a minimal reproduction
[image: image]
https://user-images.githubusercontent.com/1266245/37529060-6be1f5a0-2936-11e8-9bb6-3752de4300f8.png
Controller
namespace WebApplication5.Controllers
{
public class Query
{
public int Id { get; set; }
}
[Route("api/[controller]")]
public class ValuesController : Controller
{
    // GET api/values/5
    [HttpGet("{id}")]
    public string Get(Query query)
    {
        return "value";
    }
}

}
Startup
public void ConfigureServices(IServiceCollection services)
{
services.AddSwaggerGen(c =>
{
c.SwaggerDoc("v1", new Info { Title = "My API", Version = "v1" });
});
services.AddMvc();

}
// This method gets called by the runtime. Use this method to configure the HTTP request pipeline.public void Configure(IApplicationBuilder app, IHostingEnvironment env)
{
if (env.IsDevelopment())
{
app.UseDeveloperExceptionPage();
}
app.UseSwagger();
app.UseSwaggerUI(c =>
{
    c.SwaggerEndpoint("/swagger/v1/swagger.json", "My API V1");
});

app.UseMvc();

}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/634#issuecomment-373749744,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFIxOp7fKzdUfOAwgPqyEnI86IBzy_cDks5te9p6gaJpZM4Sbeeb
.

As per @vaustral, the casing mismatch is definitely the issue.
If you want to keep the property in PascalCase, to adhere to c# naming conventions, but still use camelCase in your route templates, you can apply the following setting when you configure Swashbuckle.
c.DescribeAllParametersInCamelCase();

Wouldn't it be sensible to ignore casing when matching query/route parameters against the model?
The previous version of Swashbuckle didn't care about casing. Neither does the current version of ASPNET Core. The following works
[HttpGet("id")]
public IActionResult Get(int ID)

I would argue that Swashbuckle should follow the expected behavior of the ASP NET Core framework.
I appreciate the c.DescribeAllParametersInCamelCase(); option, but isn't that just supposed to change how you want your parameters displayed in the UI and not actually have an impact on the ability to call the API.

@domaindrivendev @vaustral the c.DescribeAllParametersInCamelCase(); fix isn't ideal. See above post.
I'm not sure if this is a swashbuckle issue or a swagger ui issue. But that fact that parameter name displayed in swagger must match the exact casing of the parameter (not the route) is error prone.

Route
Action
DescribeAllParametersInCamelCase
Working

[HttpGet("id")]
Get(int ID)
:black_square_button:
:x:

[HttpGet("Id")]
Get(int ID)
:black_square_button:
:x:

[HttpGet("Id")]
Get(int Id)
:black_square_button:
:heavy_check_mark:

[HttpGet("Id")]
Get(int id)
:black_square_button:
:x:

[HttpGet("ID")]
Get(int id)
:white_square_button:
:heavy_check_mark:


upgrade  ios platform 10.0   #connectivity_plus

In Android  connectivity_plus is ok . but when i use connectivity_plus  on ios  it  always show no internet connection but my iOS simulator have internet   connection . i use firebase  firestore in my project  . so  my  ios platform 10.0   but connectivity_plus  ios platform 8.0  .
#connectivity_plus

I will like to work on this issue


Update Version to <IP_ADDRESS>.0

Adapter version '<IP_ADDRESS>.0', partner version '~> 7.3.1'

@ricealexanderb The version should be <IP_ADDRESS>.0.0. Can you try creating <IP_ADDRESS>.0.0 with ironSource 7.3.1 and see if that works? If not, we might need a quick bug fix in our create release script.

@kendallrogers I think the release script is fine, I caused a problem by forgetting the extra digit when I ran the workflow. I fixed the files in a commit but didn't think about the branch name.
If I just rename this branch now that should fix the problem right?
The RC build and the adapter certification ticket are also missing the trailing zero, but afaik those strings don't feed into any other workflows.

@ricealexanderb Okay I thought maybe ironSource had released a version with an inconsistent versioning scheme, but it looks like they didn't, so we should be fine.
Can you also update the version in the PR title and body?


Auto-refresh stale login links

Add a config var to enable a new behavior: when a user visits via a login link that is stale, the application will send a fresh link to the user.

@abevoelker I would prefer to include some covering tests. It looks like right now, system specs are written directly in the dummy app by default. Is that the preferred convention here?

After working with this some more, it turned out to be a poor fit for my use case. I needed to take some additional action when refreshing the links, so I used a custom failure app class instead.


test(instrumentation-pino): refactor Pino tests for correctness

Before this change the 'PinoInstrumentation' was being created
one or more times per test case, which results in the pino
module getting wrapped each time. The pino instrumentation
wraps the top-level/default export, so it cannot use the typical
instrumentation._wrap along with isWrapped/_unwrap handling.
The result was a stack of pino() being wrapped over a dozen
times, with each of those patchedPinos being active.
This caused debugging complexity. For example, every test
case after the logKeys test case would get span context
fields being added as trace_id/span_id and traceId/spandId
because the earlier PinoInstrumentation was still active.
I suspect the 'pino-disabled.test.ts' tests were only
working because they ran first, because 'disabled' luckily
comes before 'enabled' alphabetically.
This refactors the tests back to a single file
(because mocha runs separate test files in the same
process there is some cross-talk between the files), and
works with a single instance of PinoInstrumentation.
FWIW the instr-bunyan and instr-winston tests work
similarly.

Thanks for the review!


obs reports unable to walk on path 'sailfishos:<IP_ADDRESS>/latest_i408'

i586

armv8el

aarch64

armv8el

aarch64

i586

Can you elaborate? Links to package?  Is that a typo in the title?

This, in the project meta:
  <repository name="sailfish_<IP_ADDRESS>_i486">
    <arch>i586</arch>
  </repository>

https://build.sailfishos.org/project/show/home:poetaster:audioworks shows a setup error. I copied the blocks from 'getingstarted'.

Fixed, thanks


Get latest changes from unityci

Changes

...

Checklist

[x] Read the contribution guide and accept the code of conduct
[ ] Readme (updated or not needed)
[ ] Tests (added, updated or not needed)

No need to pull


Allow latest puppet-lint version

@janlam7 I was told you may be able to help. Could you take a look at merging and releasing this? If @hostnet is no longer interested in its maintenance, @voxpupuli would be happy to take it over.

I'll try to poke some people as well. As the author I wouldn't mind it being transferred to voxpupuli but I have no say in it anymore ;)

Hi there, we are happy to have @voxpupuli take it over. Please let me know how to get that going.

@rswarts awesome! I sent you a GitHub invitation to join Vox Pupuli. After you accepted it, you can migrate the github repo to vox pupuli. Afterwards please agg<EMAIL_ADDRESS>as maintainer on rubygems. We will configure new releases on our side, that's about it. If you like, you and your coworkers are more than happy to become Vox Pupuli members, then you can keep merge access to the repo. Vox Pupuli membership doesn't come with any costs or obligations. We're also around in #voxpupuli on Libera IRC and slack at https://slack.puppet.com/ if you have any questions.

Hi @rswarts ! Please let us know if you've any questions about the migration or if you can help somehow.

Hi @bastelfreak, sorry I haven't gotten around to this yet. Invitation seems to have expired, can you please resend? I'll get on this today or tomorrow.

Hey I just resent the invitation :)

@rswarts thanks for migrating the repo! Please add<EMAIL_ADDRESS>as maintainer on rubygems. Afterwards we can do the rest on our side.


"AdditionalRoutes.class" here no import  jar , i don't no why ?

can you resolve it ,or tell me why? maybe my localtional environment is wrong?

That class comes from kotlin sources. Your ide needs to support kotlin.

i am particularly grateful to him for his timely help


Upload via button is broken

Hello,
After last release 2.3 the upload via button is broken, due to adding new methods to upload folders by drag and drop. So the old method used to upload via button is not working,
The console shows the following error message:
vendor.js?id=eaffe66c3a2800ae7df2:1 TypeError: Cannot read property 'forEach' of undefined
    at p.formatFiles (nova-filemanager:formatted:41036)
    at p.uploadFiles (nova-filemanager:formatted:41028)
    at p.uploadFilesByButton (nova-filemanager:formatted:42431)
    at Pt (vendor.js?id=eaffe66c3a2800ae7df2:1)
    at HTMLInputElement.n (vendor.js?id=eaffe66c3a2800ae7df2:1)
    at HTMLInputElement.Zo.i._wrapper (vendor.js?id=eaffe66c3a2800ae7df2:1)

I am also facing this issue. It would be nice if the referenced commit was merged.
Best Regards.

Same issue

same issue

Same here.

same

Same here. But uploading via drag & drop doesn't work for me either.

Just merged the PR. Please check!