Publishing: Images do not show up with simplest publishing technique

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[x] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
Images that are within the repository do NOT get shown upon publishing using the simplest method of publishing (running a local server).
To Reproduce
Create a workspace with a vault that contains vault/assets/images/my-image.png
Create a note note.md that has the following content
![img](assets/images/my-image.png)

Validate that the preview of note.md shows the image.
Go through the steps described in publish wiki https://wiki.dendron.so/notes/e5st4LFLtIwwbQmC6JBaF/
And after running the npx dendron publish export
Grab the files from .next/out/ and utilize python server to serve these files:
python -m SimpleHTTPServer 8000

Expected behavior
Image is shown in the published note.
Actual behavior: The site is being served by python -m SimpleHTTPServer 8000 (look up, searching works). But the images are shown as broken links.
Screenshots

Desktop (please complete the following information)

OS: [e.g. iOS]
Browser (if with published websites; include version): [e.g. chrome, safari]
Versions (all that apply to bug):

Dendron Extension: 88.0
VS Code version:
Dendron CLI:

If some other simple server method works better than python SimpleHTTPServer (node etc..), would be happy to use it.
Also could be good to add this as one of the ways to serve the published content.

@nickolay-kondratyev - thanks for reporting.  Do you see the image assets getting copied over into .next/out/ after running the npx dendron publish export command? @kevinslin - do you know if we have any existing issues around this that we're tracking?

@jonathanyeung Yes the image assets are copied under .next/out/
.next/out/assets/images is full of images.

Hrm - unable to repro thus far.
Are you seeing 404's in the python simple server output?
I just tried a basic example with python simpleHTTPServer and so far it's rendering the image ok.
...
<IP_ADDRESS> - - [07/Apr/2022 17:16:23] "GET /data/dendron.json HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/Apr/2022 17:16:23] "GET /_next/static/chunks/213.0b43b5c507169128.js HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/Apr/2022 17:16:23] "GET /_next/static/chunks/798.fae27e19f205f4ee.js HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/Apr/2022 17:16:25] "GET /_next/static/chunks/pages/notes/%5Bid%5D-dc9b1cbe134a7143.js HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/Apr/2022 17:16:25] "GET /_next/data/Lqyp6D65xHBWEStQqWMPC/notes/arqdtyeksn7gmm90hhq1l1d.json HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/Apr/2022 17:16:25] "GET /assets/images/2022-04-06-18-02-46.png HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/Apr/2022 17:16:26] "GET /_next/data/Lqyp6D65xHBWEStQqWMPC/index.json HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/Apr/2022 17:16:31] "GET /_next/data/Lqyp6D65xHBWEStQqWMPC/notes/87ryid2vvx48yxi5m8x16co.json HTTP/1.1" 200 -

Yes seeing 404s in this example gtlz9qnzpobtwfvj5ha5g88 is the id of the note being renderred.
<IP_ADDRESS> - - [12/Apr/2022 02:55:26] code 404, message File not found
<IP_ADDRESS> - - [12/Apr/2022 02:55:26] "GET /notes/gtlz9qnzpobtwfvj5ha5g88/assets/images/lambda_dlq_ddb_stream_src.png HTTP/1.1" 404 -

I tried to setup brand new vault and in that vault I am actually able to see the images.

@jonathanyeung are you trying the basic example from root.md note?
It appears that for me if I add an image to root.md the image is rendered but if I add the image to a note right next to root for example hi.md then the same image does not render anymore.
Due to 404 such as
<IP_ADDRESS> - - [12/Apr/2022 03:17:34] code 404, message File not found
<IP_ADDRESS> - - [12/Apr/2022 03:17:34] "GET /notes/9y0v9nlt6xs55ek4pb3klfe/assets/images/dendron_root_image.png.png HTTP/1.1" 404 -

Where 9y0v9nlt6xs55ek4pb3klfe is the id of the hi.md note.

Also appears to reproducible if adding contents of out file to S3 bucket, root is able to render the image. But hi note does not render the image.

@jonathanyeung Just wanted to make sure you are able to reproduce this now right?

@nickolay-kondratyev - Haven't been able to repro this exactly, but I have been noticing asset rendering issues happening intermittently in various scenarios.  Still trying to chase down the root cause.
Can you share with me your publishing config, i.e. the publishing section of dendron.yml?

Here is the entire test repository with, log notes, environment recorded, and entire .next/out folder as well to record as much state as possible. Let me know if you are able to reproduce it from running from this
https://drive.google.com/file/d/1qUyh66qSsvlQ5nD4PbSRXCYON3kIYy5g/view?usp=sharing
Run this command to unpack the folder
untarUngzFile ()
{
    tar xzf "$1"
}

And place it into /tmp/ForPublishTest/ for the other command specified in [[command-used-for-publishing]] to work.

Thanks @nickolay-kondratyev - I can repro with your example.  Let me continue investigating.

@nickolay-kondratyev - I think there's a simple workaround: prefix all your image links with a slash:
![](/assets/images/screenshot.png)

instead of
![](assets/images/screenshot.png)

We have some logic in preview to make it work even if there's no leading slash, but it looks like that logic got dropped in the publishing flow.  We'll follow up on that part.

@jonathanyeung Thanks! Yea it looks like adding a / at beginning fixes the issue.

Related Fix that should permit assets without a leading /: https://github.com/dendronhq/dendron/pull/2899

This should be fixed after the Dendron v0.95 Feel free to comment here if that's not the case.


Data on optimal layers to skip?

Dear authors,
Your work looks very interesting! Thanks for making it available. Would you be willing to post examples of sets of layers you found to be optimal for skipping? The paper only shows performance based on the number of layers skipped, but it notes that the specific combination of layers skipped is important.
Even though the experiments were performed on a 13B LLaMA2, it would be interesting to see if they can be extrapolated to other models/sizes even if only as a starting point to find more optimal results.
Thanks for your time!

Of course, You can use attention layers [3, 5, 6, 8, 10, 11, 14, 15, 18, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 33, 34, 35, 36, 37] and MLP layers [6, 9, 10, 11, 15, 24, 25, 27, 28, 35] as a starting point to speed up the search, but the search results will have a certain relationship with the environment and device.

@junzhang-zj Thanks for making it available. Would you be willing to post examples of sets of layers you found to be optimal for skipping in the llama-7b as well?

@gxy-gxy llama-7b? We have not tested this model. Generally, models above 13b will show obvious redundancy.

@gxy-gxy I guess a subset of the llama-7b model is insufficient to make good predictions even for easy tokens.


tests: drivers: build_all: Fix undefined CONFIG_ETH_ENC28J60_0_MAC2 reference

I'm guessing this was meant to assign CONFIG_ETH_ENC28J60_0_MAC{3-5},
which exist.
Signed-off-by: Ulf Magnusson<EMAIL_ADDRESS>

Codecov Report

Merging #7791 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7791   +/-   ##
=======================================
  Coverage   55.01%   55.01%
=======================================
  Files         483      483
  Lines       53946    53946
  Branches    10493    10493
=======================================
  Hits        29678    29678
  Misses      19982    19982
  Partials     4286     4286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc56e3...4b91293. Read the comment docs.


Windows App SDK not installing in windows docker image

Describe the bug
The SDK is not installing inside windows docker images. Error is in the screenshot below.
Steps to reproduce the bug

Create a Dockerfile with the following contents

FROM mcr.microsoft.com/windows:20H2 AS build
WORKDIR app

RUN powershell  Invoke-WebRequest -URI https://aka.ms/windowsappsdk/1.4/1.4.231008000/windowsappruntimeinstall-x64.exe -OutFile ./downloadwinappsdk.exe
RUN powershell .\downloadwinappsdk.exe -q

# Start PowerShell when the container starts.
CMD ["powershell", "Start-Sleep", "-s", "3600"]

Build the dockerfile. (Run "docker build -t test in the directory where the Dockerfile is stored)

Expected behavior
SDK should install successfully
Screenshots

NuGet package version
Downloaded exe for version 1.4
Packaging type
No response
Windows version
Windows 10 version 20H2 (19042, October 2020 Update)
IDE
No response
Additional context
No response

MSIX isn't supported in Docker containers.
This is a Windows issue, not WinAppSDK (whether you run WindowsAppRuntimeInstaller.exe or directly install WinAppSDK's MSIX packages you'll get errors).
+@cwruss @dianmsft for visibility and vFuture consideration

Update: I was able to create a new user and then tried to install the MSIX as that user, but still ran into the same error.

Adding @nmetulev @michael-hawker for visibility


Error: Cannot find module 'cssnano'

hi!
I've followed the installation steps but when I try to load the demo it raise this error in the browser
Can you help, please?

This issue is old and has potentially been solved by the rewrite. Further, there are now explicit instructions to install dependencies when needed in 761e1321772fc19b8b63a92e01c9e4d751c502ed
Thanks!


Cannot use Substitutions neither in Personalizations nor in Mail objects

Issue Summary
// Setup sendgrid api
const sendGridMail = require('@sendGrid/mail');
sendGridMail.setApiKey('<API_key goes here>');

//build object
var mailOptions = {
    personalizations:[{
      to: to,
      substitutions: {'first_name':'John'}
    }],
    from<EMAIL_ADDRESS>    reply_to<EMAIL_ADDRESS>    subject: 'Hello',
    html: 'email text goes here',
    templateId: 'aa6733f7-0bbb-4a76-a022-588f04e10ca4'
  };

//send
return sendGridMail.send(mailOptions);

I'm receiving the following error:
There was an error while sending the email: TypeError: personalization.reverseMergeSubstitutions is not a function
    at Mail.applySubstitutions (/user_code/node_modules/@sendgrid/helpers/classes/mail.js:278:21)
    at Mail.addPersonalization (/user_code/node_modules/@sendgrid/helpers/classes/mail.js:228:10)
    at personalizations.forEach.personalization (/user_code/node_modules/@sendgrid/helpers/classes/mail.js:221:40)
    at Array.forEach (native)
    at Mail.setPersonalizations (/user_code/node_modules/@sendgrid/helpers/classes/mail.js:221:8)
    at Mail.fromData (/user_code/node_modules/@sendgrid/helpers/classes/mail.js:95:12)
    at new Mail (/user_code/node_modules/@sendgrid/helpers/classes/mail.js:41:12)
    at Function.create (/user_code/node_modules/@sendgrid/helpers/classes/mail.js:555:12)
    at MailService.send (/user_code/index.js:489:25)
    at Promise.all.then (/user_code/index.js:387:29)

If don't use personalizations (and use Substitutions in the root object), then email is sent fine, but Substitutions are not replaced, because @sendgrid/helpers/classes/Mail object in its toJSON method ignores 'substitutions' property.
Technical details:

sendgrid-nodejs Version: 6.0.0
Node.js Version: 6.11

Hi @dbaranovsky,
I was able to reproduce and I've added this to our backlog for a fix.
For now, this example works.
Here is the code I used to test:
// Setup sendgrid api
const sgMail = require('@sendgrid/mail');
sgMail.setApiKey(process.env.SENDGRID_API_KEY);
sgMail.setSubstitutionWrappers('-', '-'); // Configure the substitution tag wrappers globally

const msg = {
  to<EMAIL_ADDRESS>  from<EMAIL_ADDRESS>  subject: 'Hello world',
  text: 'Hello plain world!',
  html: '
Hello HTML world!
',
  templateId: '13b8f94f-bcae-4ec6-b752-70d6cb59f932',
  substitutions: {
    name: 'Some One',
    city: 'Denver',
  },
};
sgMail.send(msg);

Thanks!
With Best Regards,
Elmer

@adamreisnz,
Thoughts on this one?

I'll have a look!

PR created to fix this issue

Having this issue on all subs:
trying to sub a form response template with the following:
{   "email"<EMAIL_ADDRESS>  "to"<EMAIL_ADDRESS><EMAIL_ADDRESS>  "subject":"Thank You For Contacting Us",   "substitutions" : {     "first_name": "John",     "last_name": "Doe",     "contact_method": "Email",   	"substitutionWrappers": ["{{", "}}"],     "email_user"<EMAIL_ADDRESS>    "message_user": "The Message....."   },     "templateId": "TheID....."

Using the latest Node Mail SDK. This only works with the .send method, since using the POST method with postman works fine...
Any insights would be great at this point. so far I've tried applying the substitutionWrappers field, and tried not applying it.. yields the same result.
Cheers

Could you please post the entire code you're using to send & construct the email? I can see your configuration and at first glance it looks ok, but I'd like to see the full JS.
Are you using @sendgrid/mail and not by any chance the old sendgrid package?

I'm using sendgrid/mail
Turns out that in my test I had a top-level "email" field that I'd forgotten to remove.
as in
<EMAIL_ADDRESS>...the rest of the object...}
removing the field fixed the issue and things worked normally. however, re-implementing it still produced the issue. So it's a fix on my end, however just letting you guys know this does happen.
The code used is basically your example in your Readme for template usage, whereas:
// Setup sendgrid api
const sgMail = require('@sendgrid/mail');
sgMail.setApiKey(process.env.SENDGRID_API_KEY);
sgMail.setSubstitutionWrappers('-', '-'); // Configure the substitution tag wrappers globally

const msg = {
  email<EMAIL_ADDRESS>  to<EMAIL_ADDRESS>  from<EMAIL_ADDRESS>  subject: 'Hello world',
  text: 'Hello plain world!',
  html: '
Hello HTML world!
',
  templateId: '13b8f94f-bcae-4ec6-b752-70d6cb59f932',
  substitutions: {
    name: 'Some One',
    city: 'Denver',
  },
};
sgMail.send(msg);

Produces the error and this:
// Setup sendgrid api
const sgMail = require('@sendgrid/mail');
sgMail.setApiKey(process.env.SENDGRID_API_KEY);
sgMail.setSubstitutionWrappers('-', '-'); // Configure the substitution tag wrappers globally

const msg = {
  to<EMAIL_ADDRESS>  from<EMAIL_ADDRESS>  subject: 'Hello world',
  text: 'Hello plain world!',
  html: '
Hello HTML world!
',
  templateId: '13b8f94f-bcae-4ec6-b752-70d6cb59f932',
  substitutions: {
    name: 'Some One',
    city: 'Denver',
  },
};
sgMail.send(msg);

Does not.

Right, email shouldn't be there!
On Wed, Feb 14, 2018, 06:26 murphman300<EMAIL_ADDRESS>wrote:

I'm using sendgrid/mail
Turns out that in my test I had a top-level "email" field that I'd
forgotten to remove.
as in
<EMAIL_ADDRESS>...the rest of the object...}
removing the field fixed the issue and things worked normally. however,
re-implementing it still produced the issue. So it's a fix on my end,
however just letting you guys know this does happen.
The code used is basically your example in your Readme for template usage,
whereas:
// Setup sendgrid api
const sgMail = require('@sendgrid/mail');
sgMail.setApiKey(process.env.SENDGRID_API_KEY);
sgMail.setSubstitutionWrappers('-', '-'); // Configure the substitution tag wrappers globally
const msg = {
email<EMAIL_ADDRESS>to<EMAIL_ADDRESS>from<EMAIL_ADDRESS>subject: 'Hello world',
text: 'Hello plain world!',
html: 'Hello HTML world!',
templateId: '13b8f94f-bcae-4ec6-b752-70d6cb59f932',
substitutions: {
name: 'Some One',
city: 'Denver',
},
};
sgMail.send(msg);
Produces the error and this:
// Setup sendgrid api
const sgMail = require('@sendgrid/mail');
sgMail.setApiKey(process.env.SENDGRID_API_KEY);
sgMail.setSubstitutionWrappers('-', '-'); // Configure the substitution tag wrappers globally
const msg = {
to<EMAIL_ADDRESS>from<EMAIL_ADDRESS>subject: 'Hello world',
text: 'Hello plain world!',
html: 'Hello HTML world!',
templateId: '13b8f94f-bcae-4ec6-b752-70d6cb59f932',
substitutions: {
name: 'Some One',
city: 'Denver',
},
};
sgMail.send(msg);
Does not.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/sendgrid-nodejs/issues/433#issuecomment-365340395,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAd8Qgev1QXQvqueU4uLZBxMahM37-a3ks5tUcXPgaJpZM4PGk_I
.

Thanks @murphman300 for the follow up and @adamreisnz for the confirmation!


nixio file not closed

When using the nixio in an ipython notebook, written files are only valid after the kernel is restarted. If one tries to load a nix file created in a separate notebook without explicitly stopping the kernel of that notebook, the file turns out to be corrupted and can not be read.
Suggestions

A quick fix for this is to manually close the file after writing to file by calling nixio.nix_file.close(). However, I think a nixio.close() function, which closes all files would be more intuitive.
In the long run it would be nice to use the nixio as a context manager, so one does not need to close files explicitly. Currently python returns an AttributeError: exit when calling

with neo.NixIO('data.nix','ro') as nix:
    pass

Hello @JuliaSprenger.
The lack of an explicit close() method is indeed an issue. I'm not sure how I feel about a nixio.close() function on the entire namespace. Given that the general convention with importing IOs is from neo.io.Xio import X or as you mentioned in the last example, simply importing neo and using neo.NixIO(...), a method that closes all open NixIO files might not be directly accessible.
I like the context manager idea, though. This would be especially nice given how there's no real reason to keep the file open after reading or writing. So a common use case would be:
with neo.NixIO("data.nix", "ro") as nix:
    blocks = nix.read_all_blocks()

...
<work with blocks>
...

with neo.NixIO("newdata.nix", "ow") as nix:
    nix.write_all_blocks(blocks)

and there would be no issue with open files.


Added a lint file to to prevent ununnecessary error markings

Added a lint file to make IntelliJ / Android Studio stop doing Android validation on the desktop Java project (to prevent ununnecessary error markings).
Original forum topic with problem described:
http://www.badlogicgames.com/forum/viewtopic.php?f=11&t=24943
Source of solution (see the comment of Róbert Papp):
https://youtrack.jetbrains.com/issue/IDEA-122904

This won't automatically copy the lint file to the desktop project. Could you please amend the PR and make the gdx-setup app copy it to the desktop project on creation?

Oh sure, I'll see if I can find out how to do it this week. I just assumed adding it to this folder would include it.

Would be nice to hack into the gradle import instead to stop the gradle android facet being added to everything.

@Tom-Ski I've put some time into trying to modify my gradle script to make that happen, but I was unable to (might be a bit inexperienced with gradle). On the ticket I put in the PR description on the jetbrains ticket system multiple people have reported this problem and this was the best solution posted only recently.

Tested and verified that when using the gdx-setup it copies the lint.xml file to the desktop project.


feat: support native <IP_ADDRESS>

@LichKing-2234 This release doesn't follow semver, will this be released to NPM?


Rule name and token meta information

For the default rule name, it would be great if we could have some consistency with dollarmath package? Maybe math_block_amsmath? Or simply make it a math_block and add some metadata to the token to indicate that it is AMS?
It would be great to have consistency between:
$$
\begin{equation}
Ax = b
\end{equation}
$$ (math)

and
\begin{equation}
\label{math}
Ax = b
\end{equation}

and
```{equation}
:label: math
Ax = b
```

and
$$
Ax = b
$$ (math)

In terms of downstream packages not having to know the intricacies of how the math was parsed, this would mean the tokens in all cases would be something close to:
token.type = 'math_block'
token.content = 'Ax = b' || '\begin{...'
token.meta = {amsmath: true, label: 'math', numbered: true}

Maybe optionally strip out equation environments and parse simple label information. In the future as well, as packages may want to label things on their own.

Yep I can the see the thinking here; seems reasonable 👍
If we do this, a the thing to bear in mind is that these changes also need to be made in mdit-py-plugins, and then in myst-parser, to keep parity (see e.g. https://github.com/executablebooks/mdit-py-plugins/issues/26)

Maybe optionally strip out equation environments and parse simple label information.

hmm, not sure about that: I think having the package start to actually interpret the LaTeX (or reassemble it) is difficult to do in a robust way, without implementing/depending on a proper parser. I would rather leave that to katex/mathjax

Note you would also have to bear in mind how myst-parser would need to be changed, to accommodate the different tokens:

https://github.com/executablebooks/MyST-Parser/blob/553b7b8cbdf0e6a6b1beb7f78b2cd23076fcd028/myst_parser/docutils_renderer.py#L778
https://github.com/executablebooks/MyST-Parser/blob/553b7b8cbdf0e6a6b1beb7f78b2cd23076fcd028/myst_parser/sphinx_renderer.py#L141

See also https://github.com/executablebooks/markdown-it-dollarmath/issues/1


Make ETCD volumes re-attachable for vSphere.

AWS and GCE cloud providers have volumes that are independent of VM instances. In case VM instance dies, volumes still exists and can be attached to newly created VM. This feature is used in kops for HA purpose.
In case of vSphere, VMDKs are not that readily available as independent entities. This issues is about addressing this gap and make changes in vSphere kops code to  allow attaching VMDK of a crashed master instance with newly created master instance.

This issue was moved to kubernetes/kops#2736


fpp: init at 0.7.1

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Pushed a modified version to master. Thank you.


Review usage and support of older MacOS

MacOS 13 will likely be coming out in the next month or two. We currently support MacOS 10.13, 10.14, 10.15, 11, and 12. These are spread through our different devices on many partitions and it can be hard to install the new OS while still being able to test the old ones. 10.13 and 10.14 are no longer maintained by Apple according to what I've been able to find, so I think it would be good to think about at least removing them. I suspect 10.15 will lose support when 13 is released. We should look again at usage and determine if these platforms can be dropped. We should also consider reexamining iPadOS 13 as the new releases approach.

@KatieWoe MacOS 10.13 only represented 1.65% of MacOS users (.243% of all users) in the last 30 days. I'd say it's save to drop support of that platform -- though it may be best to wait until MacOS 13 is released.

Coming back to this now that MacOS 13 and iPadOS 16 are out. This was mentioned in https://github.com/phetsims/chipper/issues/1323 and seems to have been deferred at the time. I strongly support dropping MacOS 10.13 and iPadOS 13.
I updated the device we used for 10.13 to 10.15 in order to make room for the new MacOS. While I can probably get another device on 10.13 if we really want to keep supporting it, it will probably be difficult. I also don't see the utility in it. It isn't supported by Apple, usage was low, and supporting 6 Mac OS's is pretty unwieldly for QA.
Putting this issue forward to discuss in design meeting on 11/10/22.

mac OS 10.13 was released September 25, 2017.
ipadOS 13 was released September 19, 2019.

Seems appropriate to drop iOS 13!
iOS stats (last 30 days):

ios
12
31881
3.55%

ios
13
7169
0.80%

ios
14
53658
5.97%

ios
15
301607
33.56%

ios
16
504294
56.12%

Yep - @KatieWoe and @oliver-phet - let's drop ios 13.


Feature Request: (Datepicker) Allow first day of week as per ISO 8601 standard.

Quote from Wikipedia:
"in some Muslim countries and Israel, Sunday is the first work day of the week. According to the Hebrew calendars and traditional Christian calendars, Sunday is the first day of the week and according to the International Organization for Standardization ISO 8601 Sunday is the seventh and last day of the week."

Happy to take a PR for this.  But not something that we'll implement ourselves in the near future.

Resolved by #89.


Fix IMS SE verifier

Added the missing se_parse_hdr.py file to the IBM SE verifier code

@ajayvic please review

Please rebase so the build can succeed


Videos not working in 1.9.2

When attempting to run a dialog that contains an MP4 in 1.9.2, I get the following error
 /usr/local/bin/dialog --title "Test Title" --video "/Users/Shared/Sample.mp4" --videocaption "Test Caption"
failed to demangle superclass of VideoPlayerView from mangled name 'So12AVPlayerViewC': unknown error
However, in version 1.8.1 the same command works perfectly.

Interesting bug. the video code hasn't been modified between 1.8 and 1.9 but I have an idea.

fixed in 1.9.3

Thanks, I verified on my end that videos are now working.  The only thing I noticed is that for  --image dialogs, the content is scaled a bit smaller than with 1.8.1.   Not a big deal. Just thought I would pass it along.

ah - ok - yeah, that's to do with the image carousel that was introduced in 1.9.
I've had a look at the code and have fixed up the rendering when there is only a single image present. Will be updated in the next release.


Resolve slowness on registation form for CHW, at Rwanda site [3h]

Currently, it take several seconds to see a response for click on form.

Deployed to live. Closing.


Add badges

What's Changed

Using merit to add badges to users.
Added five initial badges, and a couple of rules for assigning them.

What's next

Implement these badges visually, test that they're working on staging.

Coverage increased (+0.0%) to 99.94% when pulling cba4890d18988825f5f6e9b01e3796e429fc3cda on simonv3:add-badges into e23c7b018954a421b4099414e9d5940db76b6d32 on openfarmcc:master.

Coverage increased (+0.0%) to 99.94% when pulling cba4890d18988825f5f6e9b01e3796e429fc3cda on simonv3:add-badges into e23c7b018954a421b4099414e9d5940db76b6d32 on openfarmcc:master.

Coverage increased (+0.0%) to 99.94% when pulling cba4890d18988825f5f6e9b01e3796e429fc3cda on simonv3:add-badges into e23c7b018954a421b4099414e9d5940db76b6d32 on openfarmcc:master.


Refactored IsolateGraphFailingTestCategory name to GraphSimpleLogTestCategory

Reference: https://github.com/awslabs/dynamodb-titan-storage-backend/issues/113

@F2006 your changes LGTM. one more addition please:
https://github.com/awslabs/dynamodb-titan-storage-backend/blame/janusgraph/README.md#L407
Please update the step 5 in the readme:

[ ] remove one of the mvn verify commands
[ ] change the category of the remaining verify command to IsolateRemainingTestsCategory

@F2006 Just checking, Apache CLA OK with you?

@amcp removed the verify command for IsolateGraphFailingTestCategory, the last one was already IsolateRemainingTestsCategory.
Totally 100% ok with Apache CLA, if there is one I need to sign and send back, just let me know. :)


Make cw1155 can add token's url at the first mint

There is no way to add url of cw1155 token despite it has queryMsg for it.

Huh, that contract is something of the orphan.
Since the CosmWasm core team has little to no understanding of the use cases of NFTs, we moved the nft code over to https://github.com/CosmWasm/cw-nfts
There is an open PR to add cw1155 there open for a long time: https://github.com/CosmWasm/cw-nfts/pull/27
Can you please follow up on that repo and see if they can update / maintain this (or volunteer to do so yourself)? There were too many demos, we trimmed down to the ones we could really maintain and let the community manage others.


don't 500 when we get a 404

Signed-off-by: Adam Miller<EMAIL_ADDRESS>

@jhjaggars if we 500 then rpm-ostree bombs out, apparently rpm-ostree tries to check for some optional index files and if they 404 then it's fine and the transaction keeps going ... if we 500 then it bombs. I'm not sure how to properly handle this case because I don't know how to extract the status code from the S3 error returned, but this worked for swinging the hammer.

the docs have this example that you might consider starting from:
if err != nil {
    if aerr, ok := err.(awserr.Error); ok {
        switch aerr.Code() {
        case s3.ErrCodeNoSuchKey:
            fmt.Println(s3.ErrCodeNoSuchKey, aerr.Error())
        case s3.ErrCodeInvalidObjectState:
            fmt.Println(s3.ErrCodeInvalidObjectState, aerr.Error())
        default:
            fmt.Println(aerr.Error())
        }
    } else {
        // Print the error, cast err to awserr.Error to get the Code and
        // Message from an error.
        fmt.Println(err.Error())
    }
    return
}

Looks like this needs a rebase to pull in your fixes @biancarosa


Add Neg gradient

@saxenasaurabh
Part of #42668

@saxenasaurabh
I have a question. In tensorflow/tensorflow/c/experimental/ops/math_ops.cc, we are doing something like
https://github.com/tensorflow/tensorflow/blob/2345c09855f73f0a56184a06a72261d3eb792c75/tensorflow/c/experimental/ops/math_ops.cc#L97-L106
We just pass the input and get the output. But I can not find out what happens when we call Execute(). Could you show me the list of ops and their implementation ( something like Neg(input) { return -input;} ) please ? It will come in handy when I need to port one of those from the core to tensorflow/tensorflow/c/experimental/ops/math_ops.cc. Thank you

@saxenasaurabh
I have a question. In tensorflow/tensorflow/c/experimental/ops/math_ops.cc, we are doing something like
https://github.com/tensorflow/tensorflow/blob/2345c09855f73f0a56184a06a72261d3eb792c75/tensorflow/c/experimental/ops/math_ops.cc#L97-L106
We just pass the input and get the output. But I can not find out what happens when we call Execute(). Could you show me the list of ops and their implementation ( something like Neg(input) { return -input;} ) please ? It will come in handy when I need to port one of those from the core to tensorflow/tensorflow/c/experimental/ops/math_ops.cc. Thank you

It may be useful to look at this guide on adding a new op. For Neg, the kernel  is registered here which calls into Eigen.


added crunchyroll to default services

I will add this release to the beta channel when I have a minute. Thanks for the PR.


Upgrade to ocamlformat.0.22.4

Unfortunately, the ocaml-ci bug strikes again and we can't merge this. I've pinged the maintainer on my old PR and we're trying to find a durable solution!

I'm closing for now! I realize that we could start with a 0.21 upgrade first so I'll give this a spin!


Automatically add PR type label with GHA based on description

Description
I improve action that examines the PR description to add. Labels based on PR description.
This modifies existing actions instead of creating separate ones to keep code in one place and fo not have code duplication. Also, to reduce setup time.
Type of change

[x] Maintenance (changes required to run napari, tests, & CI smoothly)

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

LOL it is very ironic that the label checker is failing here 🤣
@Czaki re discussion in #6092, I suggest that the categories should not be a checklist but just a bullet list, and people only need to delete elements, rather than fill in a - [ ], which often results in the malformed - [x ] (extra trailing space). I do think that the changes in #6092 are in a good direction and we can rejigger this one to use a simpler standard. e.g. a single - type: bugfix line somewhere would be enough?

Following up on the bullets vs. check boxes, maybe the comments should explicitly state that it's good to delete unneeded elements?
For the benefit of a new contributor who might not be sure how scared the template is—or isn't?

@Czaki re discussion in #6092, I suggest that the categories should not be a checklist but just a bullet list, and people only need to delete elements

And if a person does not delete elements, should all labels be added? Such action needs to depend on user action, not lack of effort.

rather than fill in a - [ ], which often results in the malformed - [x ] (extra trailing space).

It is not a problem to handle this, also this action may fix such malformation.

rejigger this one to use a simpler standard. e.g. a single - type: bugfix line somewhere would be enough?

and how contributors will discover this?

As mentioned elsewhere: given the valid concerns from #6042, I would rather remove these checks altogether from the CI. Instead, have those checks happen at a later stage (on merge, or on release, daily...)

As mentioned elsewhere: given the valid concerns from #6042, I would rather remove these checks altogether from the CI. Instead, have those checks happen at a later stage (on merge, or on release, daily...)

and you will take personal responsibility for adding labels to each omitted PR?

close in favor of #6158

yep


WIP: Support for IP exclude option in init-container script prepare_proxy.sh

What this PR does / why we need it:
This pr is mainly to get a review from @vadimeisenbergibm, @ayj, @rshriram to confirm this is what we want to add support for?
If there is consensus around the implementation and tests here then -post comments- I can commit or actually do a version which is closer to what would be useful.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
I will follow up this pr with the istioctl side changes once there is agreement that the underlying mechanics are as per need.
Release note:

none

Hi @saumoh. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saumoh can you clarify what is the user impact for this?   sorry it was not clear to me what benefit we'd gain by supporting this and how user will be consuming this.

While you are at this, do you want to sync up the prepare proxy script
updates from istio/proxy ?
On Tue, Sep 5, 2017 at 4:39 PM Jason Young<EMAIL_ADDRESS>wrote:

@ayj commented on this pull request.
In docker/prepare_proxy.sh
https://github.com/istio/pilot/pull/1157#discussion_r137107144:

 iptables -t nat -A ISTIO_OUTPUT -j RETURN                                 -m comment --comment "istio/bypass-default-outbound"

+elif [ "${IP_RANGES_EXCLUDE}" != "" ]; then

output_redir ${IP_RANGES_EXCLUDE} "exclude"
iptables -t nat -A ISTIO_OUTPUT -j ISTIO_REDIRECT                         -m comment --comment "istio/bypass-exclude-default-outbound"

Duplicating the for loop and removing the extra function (w/conditional)
seems cleaner and results in less code, e.g.
if [ "${IP_RANGES_INCLUDE}" != "" ]; then
for cidr in ${IP_RANGES_INCLUDE}; do
iptables -t nat -A ISTIO_OUTPUT -d ${cidr} -j ISTIO_REDIREC
done     elif [ "${IP_RANGES_EXCLUDE}" != "" ]; then
for cidr in ${IP_RANGES_EXCLUDE}; do
iptables -t nat -A ISTIO_OUTPUT -d ${cidr} -j RETURN
done
iptables -t nat -A ISTIO_OUTPUT -j ISTIO_REDIRECT  else
iptables -t nat -A ISTIO_OUTPUT -j ISTIO_REDIRECTfi

In docker/prepare_proxy_test.sh
https://github.com/istio/pilot/pull/1157#discussion_r137107474:

TAG=test
NAMESPACE=prepare-proxy-test0

-PLATFORM=gcloud
-GCLOUD_CLUSTER_NAME=c1
-GCLOUD_CLUSTER_ZONE=us-central1-a
+LIST_CIDRS=""
It would be better to either rely on ENVVAR or add proper flags support
(e.g. getopt) rather than rely on implicit ordering to set parameters.
In docker/prepare_proxy_test.sh
https://github.com/istio/pilot/pull/1157#discussion_r137107627:

@@ -92,6 +106,36 @@ function assertRedirected {
prev=${current}
}

+function getPodName() {

local appName=$1
shift
local iter=$1
shift
local NAME=""
while [ "$NAME" = "" ]; do NAME=$(kc get pod -l app=${appName},iter="${iter}" -o jsonpath='{.items[0].metadata.name}'); done
echo $NAME
+}

Any reason you used shift vs. assigning vars directly, e.g.
appName=$1
iter=$2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/pilot/pull/1157#pullrequestreview-60732186, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qd_CC8WbHs5qzwlJjytX6AubKkiyQks5sfbGagaJpZM4PJhEt
.

--
~shriram

closing to keep bot happy

@linsun: This pr motivated by the https://docs.google.com/document/d/10XjjfVcA-gFJ0WuYZQJ-snCdbB9a1FfJUywNZDTFl_k/edit?ts=5992ba31# (Stage1 Implementaion Notes)

@saumoh: you can't request testing unless you are a istio member.

In response to this:

@linsun: This pr motivated by the https://docs.google.com/document/d/10XjjfVcA-gFJ0WuYZQJ-snCdbB9a1FfJUywNZDTFl_k/edit?ts=5992ba31# (Stage1 Implementaion Notes)

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rshriram I've opened issue https://github.com/istio/pilot/issues/1300 to track the requirement of merging the prepare_proxy.sh into one version only.

@saumoh: you can't request testing unless you are a istio member.

In response to this:

@rshriram I've opened issue https://github.com/istio/pilot/issues/1300 to track the requirement of merging the prepare_proxy.sh into one version only.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

this should not change for 0.2
for after 0.2 - we should unify with https://github.com/istio/proxy/blob/5095854ad9c207e999ada2a98cb4c38a43ecd6d8/tools/deb/istio-iptables.sh
cc @costinm
any objection we close this PR for now to avoid a chance it goes in ?

@laurent, @costinm, Opened the issue
https://github.com/istio/pilot/issues/1300 to track having just one copy of
this script. Unless there is a compelling reason to keep them separated?
On Mon, Sep 18, 2017 at 5:32 PM, Laurent Demailly<EMAIL_ADDRESS>wrote:

this should not change for 0.2
for after 0.2 - we should unify with https://github.com/istio/proxy/blob/
5095854ad9c207e999ada2a98cb4c38a43ecd6d8/tools/deb/istio-iptables.sh
cc @costinm https://github.com/costinm
any objection we close this PR for now to avoid a chance it goes in ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/pilot/pull/1157#issuecomment-330393861, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT2ksqN00CwdZ3xWJ5XtzwNLZxmKEJapks5sjwuhgaJpZM4PJhEt
.

Can we re-open this PR and try to get it in?

yeah we should early in the cycle, attached to https://github.com/istio/istio/issues/1384 in the new repo layout, not here

+1. istio/istio#1384 needs to go in and then this pr can be addressed.
On Thu, Nov 9, 2017 at 5:11 PM, Laurent Demailly<EMAIL_ADDRESS>wrote:

yeah we should early in the cycle, attached to istio/istio#1384
https://github.com/istio/istio/issues/1384 in the new repo layout, not
here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/old_pilot_repo/pull/1157#issuecomment-343344135,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT2kspbF5x5b5zgayW004FV83rIgXp6nks5s06LEgaJpZM4PJhEt
.


[MM-29622] Collapsed reply threads tour

Summary
This will add a Collapsed reply threads tour when the admin switches on the feature based on the following document https://mattermost.atlassian.net/wiki/spaces/Threads/pages/1074757633/Desktop+Webapp+Onboarding we have added the trigger logic. As we have modified the existing tutorial tip Component so that will also require some testing to verify everything is working as usual.
Here is a video on how to reset tour settings via API https://www.loom.com/share/3340fc15d24a4324a6841b69e5c0627a
(Categories are  crt_thread_pane_step,  crt_tutorial_step ,crt_tutorial_triggered)
Note: For the CRT tour to trigger you have to finish/skip the onboarding tour and at least have 1 thread.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-29622
Related Pull Requests
None
Screenshots

before
after

None
https://www.loom.com/share/c30ed9581ee44d8aaa342b14c442a7c0

Release Note
* Adding CRT tour functionality, after modifying tutorial tip component to support multiple tours.

@matthewbirtch "Can we add 1px border on the tour point container? border: solid 1 rgba(var(--center-channel-bg),.16)"
this is possible but I can’t see any visual difference have done it

@matthewbirtch "Can we add 1px border on the tour point container? border: solid 1 rgba(var(--center-channel-bg),.16)" ~this is possible but I can’t see any visual difference have done it~ very subtle line

Its fine....it's more noticeable on dark themes - which is where it is needed most. Looks good

@AshishDhama I wasn't able to get the CRT tutorial to trigger for a new user even after I turned on CRT and created a thread, is there something else blocking it from triggering?

One other thing:

@AshishDhama just tested again and I can't seem to reset the CRT tour.
I tried testing with a new user and noticed that the arrow on the tour points is too big now compared to the designed component. (saw this on the initial onboarding tour)
Implemented

Designed

@AshishDhama just tested again and I can't seem to reset the CRT tour.
I tried testing with a new user and noticed that the arrow on the tour points is too big now compared to the designed component. (saw this on the initial onboarding tour)
Implemented
Designed

Yeah, Did some calculations mistake here instead of matching the diagonal of the square have matched the side.

Looks like for the existing, non-CRT related tour set, clicking outside on the shadow advances the tutorial. Is this desired?
In the CRT related tour set, clicking outside also advances the tutorial. If I understand the confluence Desktop/Webapp Onboarrding, in this tour set, clicking outside should not dismiss the modal and should advance the tutorial.

I don't know if there's a setup step I'm missing, but when I:

create a new user
Turn on CRT in the Settings > Display > Collapsed Reply Thread Menu (Beta) menu

I don't see the beginning of the tour pop up.

Maybe I need the auto tour feature flag enabled?
If I then post a message, and then open the thread view for the message, then I get CRT tips. After dismissing a few by clicking on the outside modal shadow, I get a javascript error on getLastStep.

Should the existing, non-CRT tour set show the previous button to back up in the tour

?

I don't know if there's a setup step I'm missing, but when I:

create a new user
Turn on CRT in the Settings > Display > Collapsed Reply Thread Menu (Beta) menu

I don't see the beginning of the tour pop up.

@neallred there is one more condition: you must have one followed thread in your global threads list. However, I can't seem to get the CRT tour to come up even if I have the condition satisfied @AshishDhama

@neallred the tour doesn't pop up immediately, it is user initiated by clicking on the Threads view. The Threads view should have a pulsing dot on it in the sidebar when you meet the conditions for the tutorial https://mattermost.atlassian.net/wiki/spaces/Threads/pages/1074757633/Desktop+Webapp+Onboarding

/update-branch

@esethna

Is a little tricky with the current setup, will see how to around this one and get back to you? Rest all are done.

Is a little tricky with the current setup, will see how to around this one and get back to you? Rest all are done.

@AshishDhama if we can't figure that out I think we should just remove the "previous" button from the tips on the general non-CRT tutorial. We can keep it for the CRT tutorial since the previous button is already working as expected

@AshishDhama looks good but I am seeing two issues:

In the general tutorial, hitting enter to post a message is skipping through the tutorial steps: https://gyazo.com/be77c2c8801afce8ec6db377dab4efec

I still seem to require a double click on the "Threads" item to trigger the pulsing dot on the Threads view: https://gyazo.com/b95ef93a1e105f766844e0bcb313dff8

This repros if you finish the tutorial and have CRT on, then you post your first reply message. I would expect that's when the pulsing dot appears on the threads area immediately.

@esethna If we can't show the dot immediately after the first reply post, maybe one way to fix this is to trigger the modal immediately after the user clicks the Threads view if they match the conditions? Let me know if you want to chat on it.
will test it tomorrow.

/update-branch

@AshishDhama I'm still seeing these issues: https://github.com/mattermost/mattermost-webapp/pull/9289#issuecomment-978037637

Discussed with Ashish. I'm worried we might be bloating the scope of this project a bit too much by adding mobile view support for the existing onboarding tutorial. I propose we focus only on the Threads tutorial. Ashish will remove any changes related to mobile view for the general onboarding tutorial and it should be handled by the growth team at some point.

Agree to this, eventually we'll need to figure out the problem but mobile-browser is not in its best shape and figuring out the tutorial for that is a big task on its own.
Regarding the points you made, are there any that could be fixed in a separate PR so we can move this one forward?

Discussed with Ashish. I'm worried we might be bloating the scope of this project a bit too much by adding mobile view support for the existing onboarding tutorial. I propose we focus only on the Threads tutorial. Ashish will remove any changes related to mobile view for the general onboarding tutorial and it should be handled by the growth team at some point.

Works for me - as long as we get this in the queue soon for the Growth team - I'm wondering if we need to modify the QA and UX review process to make sure that these types of things get caught in the reviews at the right time.

@neallred @koox00 please do the review at your earliest convenience.

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/102573

I ran the e2e test suite against this branch, and some CRT related tests fail that didn't fail in the latest master run. Could you take a look whether its related to anything in this PR? It could also be test flakiness, but I don't know.
The run I did against this branch: https://mattermost-cypress-report.s3.amazonaws.com/102573-47c9f62-onprem-ent-webapp-pr-9289-mattermost/mm-ee-test47c9f62/mochawesome.html
A recent run against master branch: https://mattermost-cypress-report.s3.amazonaws.com/102460-onprem-ent-master-mm-ee-test:test/mochawesome.html
You can see more test run results in https://community-daily.mattermost.com/core/channels/qa-test-automation-reports

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/103250

@michelengelen Have updated the pr with your suggestions except few empty line related nit. I hope you won’t mind those.

@AshishDhama There is a server config issue on the test server that prevent posting replies. I've asked SRE support to take a look. This is not specific to this PR it is present on other cloud test servers. I will retest as soon as the issue is resolved.

Thanks @AshishDhama
There are 3 failed E2E tests - otherwise this has been tested and it looks good to merge.

Verified Threads tour points. Tour triggers after user enables CRT and after user has at least one thread and has completed the onboarding tour.

Affected tests:
MM-T4140
MM-T4141_2
MM-T4142

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/107976

Thanks for fixing the tests @AshishDhama
Looks good to merge - here's the latest E2E report, no PR related failures.

@AshishDhama please merge now that reviews are complete :)


unable to use _text in params as defined in README

using default configuration:
  - put: send-email
    params:
      to<EMAIL_ADDRESS>      subject_text: Job info
      body_text: this is the body

Error:
Using dir /tmp/build/put
Logging payload to /tmp/tmpzek9pz52
Unable to extract 'subject' from 'params'

unexpected end of JSON input

Sorry. I forgot to push the docker image after updating the repository. Could you please try again and report back if this is still an issue for you?

Success! Any thoughts on changing the error message to include the reason for failure? e.g. the original error message is a bit cryptic. Thank you.


Issues and workflow updates

Overall Review of Changes:
Addition of changelog
update to audit output
update to workflows
removal of dependency on jmespath
Issue Fixes:
some items from #13 thanks to @PoundsOfFlesh
#17 thanks to @knbrende
Enhancements:
Audit
workflows
How has this been tested?:
Manually

Pipeline will fail as a task requires skipping as requires a password change, this is fixed for new pipeline


downport, ALPHA = OUT

https://github.com/abapGit/abapGit/pull/4161#discussion_r523422495
its 740sp2,

I'll add it in https://github.com/abapGit/abapGit/pull/4177, give me an hour or two

abaplint fix = https://github.com/abaplint/abaplint/pull/1551

:+1:


Display "Interactive mode enabled" only when running odo init interactively

What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5957
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:
Running odo init non-interactively should no longer display the "Interactive mode enabled, please answer the following questions" message.

/lgtm

/approve

/lgtm

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM Cloud

/override ci/prow/v4.10-integration-e2e


pm: domains: Alternate power domain implementation

This PR is an alternate implementation (of details) of power domains from the work presented in #39344.
The primary differences are:

Power domain drivers are responsible for notifying child devices of state changes themselves.
Custom drivers can be notified and handle transition failures if they wish.
Power domain transitions are integrated into the existing PM actions, instead of a new set of actions that can occur asynchronously.

This pulls the power domain logic out of the common pm_device_action_run function.

@gmarull

I like the ideas brought in this proposal, it will help on making progress. I have a few questions.

The turn on / off is a good idea.
Notify children is not a basic behavior for all domains?? We simplify the subsystem logic but we put more responsibility into the domain implementation. Not bad though.
I am looking it from my cel and will only be able to properly review tomorrow night

Notify children is not a basic behavior for all domains?? We simplify the subsystem logic but we put more responsibility into the domain implementation. Not bad though.

Notifying children is a basic behaviour, but what to do when one fails is not. I can easily see custom regulator drivers being written that will accept any device, some devices, or no devices failing. This flexibility is lacking when the return values are ignored because they are buried in device_pm_get.
I don't count putting more responsibility on the domain implementation as a bad thing. Its a power domain driver, asking it to call a function to notify children does not seem like too large a burden.

I've added the simplest version of a power-domain device and a qemu test which cycles some dependent devices.
/ {
	test_reg_0: test_reg_0 {
		compatible = "power-domain-gpio";
		label = "test-reg-0";
		enable-gpios = <&gpio0 0 0>;
	};

	test_reg_1: test_reg_1 {
		compatible = "power-domain-gpio";
		label = "test-reg-1";
		enable-gpios = <&gpio0 1 0>;
	};

	test_reg_chained: test_reg_chained {
		compatible = "power-domain-gpio";
		label = "test-reg-chained";
		enable-gpios = <&gpio0 2 0>;
		power-domain = <&test_reg_0>;
	};
};

Which shows the sequencing operating correctly.
 If the domain is on by default, you need to run PM_DEVICE_ACTION_TURN_ON code in your init function, because you are already powered up. If it is off by default you can't , because the device has no power.

Given how the implementation works, it may even make sense for the drivers to depend on PM_DEVICE_RUNTIME.

Notify children is not a basic behavior for all domains?? We simplify the subsystem logic but we put more responsibility into the domain implementation. Not bad though.

Notifying children is a basic behaviour, but what to do when one fails is not. I can easily see custom regulator drivers being written that will accept any device, some devices, or no devices failing. The most likely custom implementation is one that will accept any device failing that isn't the device that was asked for. This flexibility is lacking when the return values are ignored because they are buried in device_pm_get.
I don't count putting more responsibility on the domain implementation as a bad thing. Its a power domain driver, asking it to call a function to notify children does not seem like too large a burden.

Notify children is not a basic behavior for all domains?? We simplify the subsystem logic but we put more responsibility into the domain implementation. Not bad though.

Notifying children is a basic behaviour, but what to do when one fails is not. I can easily see custom regulator drivers being written that will accept any device, some devices, or no devices failing. The most likely custom implementation is one that will accept any device failing that isn't the device that was asked for. This flexibility is lacking when the return values are ignored because they are buried in device_pm_get.

I got it. The responsibility to notify children was transferred to domains implementation because of the error handling. I thought about it and to to integrate it into the subsystem would require change the device API that I was avoiding.
I really would like to have this behavior done automatically for power domains, but between change an API that is used by all devices or make it responsibility of the power domain driver I prefer the latter.

I don't count putting more responsibility on the domain implementation as a bad thing. Its a power domain driver, asking it to call a function to notify children does not seem like too large a burden.

It is not indeed, but it is not common pattern in the project. Anyway, I don't think it is bad, I rather have it and optimize later than don't have it.

@JordanYates  @gmarull  How you want to proceed with it ? I'm ok with this solution, there are small clarifications and adjusts to be done, but nothing blocker for me.
@JordanYates do you want to move forward and move from the DRAFT stage ?
@gmarull Anything that would make you block it ?
Power domains are being discussed for, at least three months, nothing really major appeared, so I'm really pushing to have it before the next release. This solution move a lot of responsibility from subsystem to drivers, so the impact should not be big. Also, the feature is optional and should not have big impact in people not using it.

@JordanYates do you want to move forward and move from the DRAFT stage ?

I am happy for you to roll in/squash any of my commits to your PR if you want to continue there. If pushing this feature becomes my responsibility it will be pretty low on my priority list, given that I will probably be on the LTS for quite some time.

@JordanYates do you want to move forward and move from the DRAFT stage ?

I am happy for you to roll in/squash any of my commits to your PR if you want to continue there. If pushing this feature becomes my responsibility it will be pretty low on my priority list, given that I will probably be on the LTS for quite some time.

Ok, I'll move forward and squash these changes there.

Closing it since changes in this pr were included in the original pr. Thanks for the help / work.


⚠ ClamAV has degraded performance

In bf89346, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 56 ms

Resolved: ClamAV performance has improved in aeb7230 after 6 minutes.


Docker image do not start

Hello,
I try to use the docker image : https://registry.hub.docker.com/r/hygieiadoc/sonarcodequalitycollector.
But when I run it, it fail with : "no main manifest attribute, in sonar-codequality-collector-javadoc.jar" error.
(I build myself the image using the Dockerfile.build, and it works well)
P.S.: I'm not a java developer, so spring boot is not my cup of tea.

Can you share your local Dockerfile that you used? We can probably fix the file on repository and going forward the future images will work

FYI - I am actually seeing this on nearly all of the docker images hosted on docker hub

@chzhanpeng Can you validate this ? Also @samwiskow did you did you follow the instructions as in docker-instructions.

 Is there a more complete set of instructions/options/arguments that need to be passed in for each of the containers to be started correctly?
For example, I'm running something like this command for the api container:
 docker run -d -t -p 8080:8080 --name api --link=hy-mongo:mongo -v $SOME_WINDOWS_PATH\props\api.properties:/hygieia/config/application.properties -e "SPRING_DATA_MONGODB_HOST=<IP_ADDRESS>" -e "SPRING_DATA_MONGODB_PORT=27017" -e SKIP_PROPERTIES_BUILDER=true hygieiadoc/api:v3.1.3

The container exits straight away with the logs:
SPRING_DATA_MONGODB_HOST: <IP_ADDRESS>
SPRING_DATA_MONGODB_PORT: 27017
no main manifest attribute, in api-javadoc.jar

But it's not really clear what arguments the container is expecting, or what is going wrong. I am having similar issues with all the containers I try
OS: Windows
Docker platform: Hyper-V


Big No Brainer - Input replay.json -> Perception

Python code that translates a replay.json into a Perception() class.
This translations allows to feed existing game data to the BigNoBrainer NET.

test_json_processsor.py process a replay.json into a list 360 elements of Perception and into a gif of 360 frames.


Extracting channel info with --print fails with Cyrillic characters and gives unexpected results (windows)

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.02.04. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
While trying to extract a channel name to use in a script variable, I noticed the result is an empty string if the channel name uses Cyrillic alphabet. NOTE that Windows batch doesn't allow piping directly to a variable so the FOR loop is necessary.
Using Windows batch, parameters tried are:
%(creator)s
%(channel)s
%(channel_id)s
%(uploader)s
%(uploader_id)s
NOTE: For the purpose of the bug report, I included all parameters together. My script only uses one parameter.
SET /p theURL= ^> Enter a URL:
SET theChannel=

FOR /F "tokens=*" %%A IN ('!theDownloader! --proxy !proxyInf! --print "%%(creator)s - %%(channel)s - %%(channel_id)s - %%(uploader)s - %%(uploader_id)s" --playlist-end 1 "!theURL!"') DO (
    ECHO uploader is "%%A"
    SET theChannel=%%A
)

Example 1:
https://www.youtube.com/watch?v=d6yVXYz9P6c
The above URL will produce the following output:

uploader is "NA - - UC-39fLDJPwSDuR7rlHGoXUg -   - AleksZamorin"

Note that the channel name is actually МанхэттенФотошкола and the display name is Друзья Фотошкола but neither of those are obtained. Also note that the channel and uploader results are blank. If you search for the channel ID in the Youtube search bar and filter on "channel", it returns:
https://www.youtube.com/c/МанхэттенФотошкола
The expected output would be:

uploader is "NA - МанхэттенФотошкола - UC-39fLDJPwSDuR7rlHGoXUg - Друзья Фотошкола - AleksZamorin"

Example 2:
https://www.youtube.com/watch?v=bv_6f_utMek
This channel is in english but still seems to give unexpected results:

uploader is "NA - David Manning - UC_sSJZnJdsnjuAKdr95D9HQ - David Manning - UC_sSJZnJdsnjuAKdr95D9HQ"

The channel name is actually DavidManningvlog as seen in the URL when you search for the channel ID in the Youtube search bar and filter on "channel":  https://www.youtube.com/c/DavidManningvlog/videos
Verbose log
[debug] Command-line config: ['-v', '--print', '%(creator)s - %(channel)s - %(channel_id)s - %(uploader)s - %(
uploader_id)s', '--playlist-end', '1', 'https://www.youtube.com/watch?v=d6yVXYz9P6c']
[debug] Encodings: locale cp1252, fs utf-8, out cp1252 (No ANSI), err utf-8 (No ANSI), pref cp1252
[debug] yt-dlp version 2022.02.04 [c1653e9] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=d6yVXYz9P6c
[youtube] d6yVXYz9P6c: Downloading webpage
[youtube] d6yVXYz9P6c: Downloading android player API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, codec:vp9.2, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), acodec, la
ng, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] d6yVXYz9P6c: Downloading 1 format(s): 248+251
uploader is "NA -   - UC-39fLDJPwSDuR7rlHGoXUg -   - AleksZamorin"

❯ yt-dlp -O "%(creator)s - %(channel)s - %(channel_id)s - %(uploader)s - %(uploader_id)s" d6yVXYz9P6c
NA - Друзья Фотошкола - UC-39fLDJPwSDuR7rlHGoXUg - Друзья Фотошкола - AleksZamorin

Your console probably doesn't support unicode characters and therefore blanked them out. I can't test on a windows 7 system right now, but try running chpcp 65001 before yt-dlp

The channel name is actually DavidManningvlog as seen in the URL when you search for the channel ID in the Youtube search bar and filter on "channel": youtube.com/c/DavidManningvlog/videos

channel is the "name" of the channel, not it's URL slug

Your console probably doesn't support unicode characters and therefore blanked them out

Thanks for the reply. My console does actually support unicode. In fact, I often get the correct result printed to the console but when I try to pipe it to a file using >, it's blank.
For example:
SET theURL=https://www.youtube.com/c/МанхэттенФотошкола/videos
!theDownloader! --proxy !proxyInf! --print "%%(channel)s" --playlist-end 1 "!theURL!"
!theDownloader! --proxy !proxyInf! --print "%%(channel)s" --playlist-end 1 "!theURL!" > test.txt
The console shows: Друзья Фотошкола
The text file is empty

did u try this!?

but try running chpcp 65001 before yt-dlp

did u try this?

but try running chpcp 65001 before yt-dlp

Yes, it filled in the missing parameters:

NA - Друзья Фотошкола - UC-39fLDJPwSDuR7rlHGoXUg - Друзья Фотошкола - AleksZamorin

But this brings up two additional questions:

How do I know which codepage to use if I'm accepting any random URL from Youtube
Why doesn't the output properly get printed to the text file?

NOTE: I tried to use --print-to-file but it failed on a playlist URL because "multiple files but only one ouput" or something.

How do I know which codepage to use if I'm accepting any random URL from Youtube
Why doesn't the output properly get printed to the text file?

Windows 7 console does not have proper unicode support. The closest you can get it is 65001. Even in windows 10/11, full utf8 support is marked as beta

NOTE: I tried to use --print-to-file but it failed on a playlist URL because "multiple files but only one ouput" or something.

verbose log?

--download-archive "!downloadDir!%(channel)s!videoList!.txt"

Download archive must be a single file, not an output template

NOTE: I tried to use --print-to-file but it failed on a playlist URL because "multiple files but only one ouput" or something.

verbose log?

Sorry, my mistake. It was an error in my command structure, I forgot to add --playlist-end 1 in my previous test.
--print to file actually works well except it downloads the first video before hitting my PAUSE directive. I only want to dump the channel name to a file, not actually start downloading yet.

yt-dlp.exe -v --playlist-end 1 --print-to-file "%%(channel)s" test.txt "!theURL!"

I get a file with the channel name and also the first MP4 on the channel's "videos" tab.

Add --simulate. Unlike --print, --print-to-file does not automatically imply it

Finally, this works
SET /p theURL= ^> Enter a URL:

chcp 65001
yt-dlp.exe --simulate --playlist-end 1 --print-to-file "%(channel)s" test.txt !theURL!
SET /p theChannel= < test.txt
ECHO !theChannel!
ECHO !theChannel! > !theChannel!.txt

I can echo the channel name to the screen and to a file with the same name. Without the chcp 65001 I can sometimes echo to the screen but the filename is all garbage.
Thank you for your help. I'm marking this resolved.

It would be good to know how this issue would be affected by 79ecd190da3c6803b749941ea156108832f1f59e and/or 680da2aeb058a0453dee6a8690451aec0857a7e8. I have no Windows set-up to test this.
Are you able to create a custom build with those two patches applied?

Windows 10+ is unaffected. I'll test on win7 before merging, but I can't test for a few days atleast


Add serverUrl to .fernrc

So we can default to it! instead of making the client enter it manually

completed with support for environments


feature request: button-add for non-required objects

Prerequisites

[x] I have read the documentation;
[x] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description
A schema may define a set of objects as properties.  A subset of those properties may be required by the schema.  Currently react-jsonschema-form expands all objects (required or not).  It would save space to collapse objects not required and provide a button to add the object if desired.  Additionally, if the unrequired object has required fields when present, the validator will require the required fields in the unrequired object be filled in (even though they are only required when the object exists).
Steps to Reproduce
sample JSFiddle
Expected behavior
Ideally, string 1 and object 1 would be displayed and object 2 would be collapsed so everything below it was not shown.  String 3 would not be required because no object 2 had been created.
Actual behavior
All properties and subproperties are shown.  String 3 is required even though object 2 is empty.
Version
0.48.2

Hi, thanks for your comment. I agree that this would be useful. We've had a longstanding wishlist item for collapsing fields or hiding them (#322/#324, #578, your own #598). I would be interested in reviewing a PR that added this feature if it could be done in a clean way.


Swift Compiler 5.8 / Xcode 14.3 RC   -strict-implicit-module-context  not pass to swift-frontend

Description
Use Xcode 14.3 RC , set  -strict-implicit-module-context  flag on Other Swift Flags of Building Settings, when compile swift file,  the -strict-implicit-module-context flag only appear swiftc command, does not appear swift-frontend command
Steps to reproduce
1、Use Xcode 14.3 RC , set  -strict-implicit-module-context  flag on Other Swift Flags of Building Settings
2、Build swift file
3、See  swiftc command and  swift-frontend command  by XCode build message log
Expected behavior
-strict-implicit-module-context  flag  pass to swift-frontend

Environment

Swift compiler version info swift-driver version: 1.75.2 Apple Swift version 5.8 (swiftlang-<IP_ADDRESS>.1 clang-14<IP_ADDRESS>.100)
Xcode version info Xcode 14.3 Build version 14E222a

the -strict-implicit-module-context flag does not appear in the result of swiftc --help  command

When the frontend has a flag but the driver doesn't have an equivalent flag, you can pass the flag directly to the frontend by adding -Xfrontend before it in the driver flags, e.g. OTHER_SWIFT_FLAGS = $(inherited) -Xfrontend strict-implicit-module-context.

@tshortli  thank you very much, it solves my problem.  I try to find  -Xfrontend from the result of  swiftc --help, but it  does not appear.

@Fushj89 -Xfrontend is not documented because strictly speaking it's not meant for general use. The -strict-implicit-module-context also isn't yet an official, supported flag. You're of course free to use them to work around the issue you're encountering, but they are not generally advertised because there is not yet a formal commitment to supporting them. You can read a bit more about the topic of private Swift compiler flags here: https://forums.swift.org/t/is-xfrontend-forbidding-enough/18791/5


Website Home Page Replace with "Your Function App is up and running"

The website home page is replaced with "Your Function App is up and running":

Repro steps
Provide the steps required to reproduce the problem

Deploy existing website. Ours is deploys via webdeploy
Follow tutorial on wiki with deployment option 1. I only deployed QueueTrigger.

Expected behavior
Website is not replaced. WebJobs dashboard shows something about the site extension or deployed function.
Actual behavior
Website is replaced with Function App website.
Known workarounds
Related information
I originally had the website in 64-bit mode, but had to switch it to 32-bit like I mentioned in #1157.

This is by design. Azure Functions is not really designed to be used alongside a regular site, unlike Azure WebJobs. What is your scenario?

@lindydonna I was hoping to use WebJob Scripts instead of WebJobs. May be I'm confused what this azure-webjobs-sdk-script project is all about. cc @panesofglass

@ctaggart WebJob Script is really just a codename. This is the runtime that powers Azure Functions, which is documented here: https://docs.microsoft.com/en-us/azure/azure-functions/index
Creating a private site extension is mostly for people who are contributing to the project, not usually end-users.

Okay, I get it. I should have gone with option 2:
https://github.com/Azure/azure-webjobs-sdk-script/wiki#option-2-no-http-functionwebhook-support


Emojis non showing

Describe the bug
Emojis in text in editing mode do not show
To Reproduce
It's unclear to me how to reproduce this, since it seems to have an irregular behavior.
Anyhow, my notes seem to not be able to show emojis in the text.
Expected behavior
I expect to see emojis
Additional context
To problem seems to solve it self right way when disabling the iconize plugin
plugin version: 2.11.11

Describe the bug
Emojis in text in editing mode do not show
To Reproduce
It's unclear to me how to reproduce this, since it seems to have an irregular behavior.
Anyhow, my notes seem to not be able to show emojis in the text.
Expected behavior
I expect to see emojis
Additional context
To problem seems to solve it self right way when disabling the iconize plugin
plugin version: 2.11.11

thanks for reporting. does it work if you set the option emoji mode in the Iconize settings to native?

I set the emoji mode to native, but the problem still exists.

I have the same issue, I also tried to set the emoji mode to native, but the problem still exists.

thanks for reporting. does it work if you set the option emoji mode in the Iconize settings to native?

No. I never actually changed it from "native"

plugin version: 2.11.11 (but I already had the issue with the previous version)

Yeah, me too. It's been a problem for a couple of days at least

I have the same issue. It started occurring when the change was made in the plugin settings to ‘none’ to ‘default’ or similar. Before that change, it was working beautifully. For now, I have disabled this plugin unfortunately…

Yeah all the emojis are broken across obsidian since the last iconize update!! It renders the package absolutely unusable!

I need more information to reproduce the issue.

Are there any error logs in the Developer Console?
Is the problem still reproducible when you only have Iconize in your Vault without other plugins
When does the error exactly occur?

I'm having the same problem.
Is the problem still reproducible when you only have Iconize in your Vault without other plugins
Switched off all plugins apart from Iconize and the problem presists. I'm using AnupPuccin as a theme.
When does the error exactly occur?
Almost always.
The icons are shown:

in Dataview tables
when the cursor is in the same line
within callouts (unless I'm editing the callout. Then no icons are shown)

I have the same problem in Live Preview mode.
With Iconize 2.11.5:

After updating to the latest Iconize 2.11.11, the same problem occurs on Windows, macOS, and Android:

Here is my default Iconize setup from .obsidian/plugins/obsidian-icon-folder/data.json:
{
  "settings": {
    "migrated": 4,
    "iconPacksPath": ".obsidian/plugins/obsidian-icon-folder/icons",
    "fontSize": 16,
    "iconColor": null,
    "recentlyUsedIcons": [
      "🕑",
      "🧑🍳",
      "🍖",
      "🅿",
      "🥊"
    ],
    "recentlyUsedIconsSize": 5,
    "rules": [
      {
        "icon": "✅",
        "rule": "+LEARN 🚧/DATA SCIENCE 🚧/Courses 🚧/MATLAB 🚧/(YouTube) MATLAB Tutorial - Derek Banas 🚧.md\\/[\\w\\d\\s]+\\.(?:\\w+\\.)*\\w+",
        "for": "files",
        "order": 0,
        "useFilePath": true
      }
    ],
    "extraPadding": {
      "top": 2,
      "right": 2,
      "bottom": 2,
      "left": 2
    },
    "extraMargin": {
      "top": 0,
      "right": 4,
      "bottom": 0,
      "left": 0
    },
    "emojiStyle": "twemoji",
    "iconInTabsEnabled": true,
    "iconsBackgroundCheckEnabled": false,
    "iconInTitleEnabled": false,
    "iconInFrontmatterEnabled": false,
    "iconsInNotesEnabled": true,
    "iconIdentifier": ":",
    "iconsInLinksEnabled": true,
    "iconInFrontmatterFieldName": "icon",
    "iconColorInFrontmatterFieldName": "iconColor",
    "debugMode": false
  },

I cannot find anything interesting in the developer console. When I activate Iconize, there is only this single log line in the console:
loading iconize plugin:obsidian-icon-folder:5836

Same issue, exactly as @Stefanyeah describes. Emojis only show up when my cursor is on the same line/block; in DataView blocks; and in Callouts (unless when editing).
I'm pretty much always in Live Preview.
Obsidian 1.5.12, Iconize 2.11.11

I'm experiencing the problem just as @Stefanyeah described it. I am also using Anapuccin as a theme. I wonder if there might be some problem related to that (?)

not entirely sure if the newest built version fixes this problem. i've tweaked some things. this link is the currently built version. it would be really nice, if someone could tell me if everything works fine or if there is still an issue.
here are the things you need to do to install the main.js file:

Go to your .obsidian folder (you can e.g., access that through Obsidian _Settings > Appearance > Themes (and click on the directory icon))
Go to the plugin directory (should be .obsidian/plugins/obsidian-icon-folder/)
Replace the main.js file with the newly downloaded main.js file

@FlorianWoelki I have tried what you asked. It did seem to partially solve the problem. Emojis are displayed now, but it's like it's using some older version of the emojis (I'm not sure how it works, I'm not really into this stuff). For example, instead of a farmer is displaying a person followed by a crop, which is not the emojis I used:

@FlorianWoelki: I also tried it.
Without Iconize:

With Iconize and modified main.js. Notice, that when I hover my cursor over emoji, there is a magnifier button and a preview is being shown. The same magnifier is being shown when I hover over images, although then a preview is not shown.

thank you for the feedback @Jaked2001 and @pyxelr
could you checkout this one. I was also able to reproduce the example by @pyxelr but with this version I am not able to reproduce it anymore.
fyi: the old link is broken.

Thank you for working on this right way trying to solve the issue.
I've just tried the last version you sent and it seems to be working as expected! All emojis are displaying the way they should.
Previus version:

This version:

@FlorianWoelki Hey, I had the same problem as @Jaked2001, your newest main.js fixed it completely for me, thanks!
I'm new to the plugin and have a somewhat similar question though: When using icons from icon packs, for example :FabFonticonsFi: it is not rendered while the cursor is within the same paragraph of text, it renders only when the cursor is elsewhere, is this intended behavior? It's not a big deal, but I figured I asked anyway. :)

really awesome to hear that! thanks for all the great collaboration on that issue! I'll try to release a new version in the next few days.

@FlorianWoelki Hey, I had the same problem as @Jaked2001, your newest main.js fixed it completely for me, thanks! I'm new to the plugin and have a somewhat similar question though: When using icons from icon packs, for example :FabFonticonsFi: it is not rendered while the cursor is within the same paragraph of text, it renders only when the cursor is elsewhere, is this intended behavior? It's not a big deal, but I figured I asked anyway. :)

yes, this is intended, but also a "bug". at least for now. I think, it is something similar to #315. feel free to upvote this one with a thumbs up.

@FlorianWoelki: For me, it does not seem to be fixed with the new main.js. Everything is the same as in my last comment.

@FlorianWoelki: For me, it does not seem to be fixed with the new main.js. Everything is the same as in my last comment. I can still see the magnifier button upon hovering and the emoji style is different.

yeah that's intended. sorry I was not aware of the magnifier there. but the tooltip always shows the "real" name of the emoji/icon. it's also described here.

could you checkout this one. I was also able to reproduce the example by @pyxelr but with this version I am not able to reproduce it anymore.

This does the trick for me as well. Thanks!

the latest version v2.11.12 should fix this issue.

@FlorianWoelki: v2.11.12 still does not show up in my Obsidian community plugin updates (I have v2.11.11). Does it need to go through some verification process?

@FlorianWoelki: v2.11.12 still does not show up in my Obsidian community plugin updates (I have v2.11.11). Does it need to go through some verification process?

normally, there is no verification process. I am also wondering why it is not updated. but, I cannot influence anything here.

@FlorianWoelki: Ok, I finally managed to get an update.
I see that v2.11.12 partly resolved the issue.
Here is how it looks without Iconize (in live preview):

And here is how it looks with it:

When it is activated:

emojis look differently. I would prefer the look as in the 1st screenshot in this message
the 🏃♂ (running_man) emoji is consisted of 2 emojis
emojis are highlighted and get a magnifier icon on top of them

Lastly, I noticed something (not sure if it is from this version) that when I change the "emoji style" in Iconize settings, I get this ℹ icon at the top of the page, which I can get rid of by reopening the page:

Ah, I noticed that 🏃♂ (running_man) emoji is being consisted of 2 emojis, when:

I turn off Iconize and have emoji shortcodes activated
I add a 🏃♂ (running_man) emoji and turn on Iconize.

Now I removed Emoji shortcodes plugin, as its functionality was being duplicated by Iconize.
Nevertheless, I also noticed quite a weird behaviour in live preview mode while using Iconize. Emojis change their look when I hit enter:

In "reading" mode they became brighter, while in "source mode" they look just like before hitting enter.

Ah, I noticed that 🏃♂ (running_man) emoji is being consisted of 2 emojis, when:

I turn off Iconize and have emoji shortcodes activated
I add a 🏃♂ (running_man) emoji and turn on Iconize.

Now I removed Emoji shortcodes plugin, as its functionality was being duplicated by Iconize.
Nevertheless, I also noticed quite a weird behaviour in live preview mode while using Iconize. Emojis change their look when I hit enter (when I hit backspace (or when I hit space on the same line), the original look is brought back):

In "reading" mode they became brighter, while in "source mode" they look just like before hitting enter.
This seems to be fixed when I turn off "Toogle icons while editing notes", but I also lose the option to easily add emojis with :.

this is generally the live preview mode. whenever you enter the line, it will revert back to the original emoji/icon. that's why you also see the :CoFlag (for instance) instead of the rendered emoji when you are in the line.

@FlorianWoelki: Thanks for explaining!
Well, to overcome this, I have installed emoji shortcodes and turned off "Toogle icons while editing notes" in Iconize settings. Otherwise, it was a little annoying to see the flashing emoji while editing text on the same line.

@FlorianWoelki: Thanks for explaining!
Well, to overcome this, I have installed emoji shortcodes and turned off "Toogle icons while editing notes" in Iconize settings. Otherwise, it was a little annoying to see the flashing emoji while editing text on the same line in live preview.

lovely stuff, I'll try to fix this. could you create a new issue with the wonderful gifs you've provided? thanks!

@FlorianWoelki: Thanks for explaining!
Well, to overcome this, I have installed emoji shortcodes and turned off "Toogle icons while editing notes" in Iconize settings. Otherwise, it was a little annoying to see the flashing emoji while editing text on the same line in live preview.

lovely stuff, I'll try to fix this. could you create a new issue with the wonderful gifs you've provided? thanks!

Sure! Here it is: https://github.com/FlorianWoelki/obsidian-iconize/issues/465.

I was using

I was using v2.11.12 (the latest available) and this problem is not resolved. You can see details of the issue on this forum post. I thought it was unrelated to pluggins since the call stack for the line that modifies the emojis only contains app.js functions.
Disabling this plugin solved my issue.


The wired label extraction in TensorFlow model

Hi.
I'm very appreciate your notebook because I have to implement Doc2Vec in TensorFlow.
I came to the 2nd chunk of TensorFlow Model in test_doc2vec.ipynb, I think extracting label for every instance (piece of words with length skip_window*2) after deleting centered word is wrong. Isn't it?
k = 0
for doc_id, sentence  in enumerate(data):
    for i in range(skip_window, len(sentence)-skip_window):
        buffer = sentence[i-skip_window:i+skip_window+1]
        del buffer[skip_window]
        labels[k] = sentence[i]
        context[k] = buffer
        doc[k] = doc_id
        k += 1

I mean labels[k] = sentence[i] should be placed before del buffer[skip_window].
I'm sorry If this is misunderstandings.

You raise a really good point! I did a little bit of an experiment as follows:
In [3]: a = list(range(10))

In [4]: a
Out[4]: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]

In [5]: b = a[0:5]

In [6]: b
Out[6]: [0, 1, 2, 3, 4]

In [7]: del b[2]

In [8]: b
Out[8]: [0, 1, 3, 4]

In [9]: a
Out[9]: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]

As you can see a is unaffected by the del b[2] operation. However, just to be on the safe side I will change it to as you suggested. Its hard to know when python passes things by reference or by value.
Also my code is still experimental. I'm not entirely convinced that this is what doc2vec is supposed to be doing. More to follow!

Oh I'm sorry for bother you. I miss understood the label was extracted from buffer variable...
Thank you for taking your time and kind explanation!

Not at all. I appreciate you taking the time. Let me know if you spot any other potential mistakes. Cheers.


Added missing cronjob and node atrributes : https://github.com/kubern…

…etes/kube-state-metrics/issues/1509
Tested by running ksm locally and using unit tests. Screenshots attached for new fields in metrics endpoint.


Requirements file

Hi,
Thanks for the great input. I think your requirements file is containing a little to much. Do you have the correct dependancy list?
Kr
Mads

Hi @madslundgaard
Yeah, I did it with pip freeze > requirements.txt so it put there all the dependencies as well. Will fix it, thanks!


IP binding vs token sent addresses conflict on real application

I'm using AWS EC2 service to get a test service running.
The example code runs but binding UDPAddr fails using my server public IP
Analyzing the code, when listening UDP addresses, the address is added to a slice in order to listen ports up to numServers.
But in order to correctly listen on the udp address and port correctly, it must use <IP_ADDRESS> or <IP_ADDRESS>  as the server IP.
However the client should get the public IP of the server in order to be able to connect to it using the token.
I managed to "cheat" by setting the addresses with the public ip of the server, but binding netcode.NewServer to <IP_ADDRESS>, however, <IP_ADDRESS> IP gets whitelisted but it's compared against my server public IP so it doesn't match.
I managed to get it to work commenting the whitelist check, but i know it's not the right/secure way.
What's the right way of:

Binding the address:port successfuly
Sending the server's public IP in the token
Whitelisting server's public IP so it matches the connection attempt from the client.

Thanks for your help
TLDR;
Can't bind with public IP.
<IP_ADDRESS> or <IP_ADDRESS> won't let clients connect for obvious reasons
Cheating by binding <IP_ADDRESS> and sending server's public IP won't match whitelist.

Fixed by @yome


network partition reconnection

{"name":"mservice","hostname":"ms-users-production-0","pid":1,"level":30,"msg":"connection is closed. Had an error: <n/a>","time":"2016-07-05T19:56:17.450Z","v":0}
{"name":"mservice","hostname":"ms-users-production-0","pid":1,"level":30,"msg":"connected to<EMAIL_ADDRESS>v3.5.7","time":"2016-07-05T19:56:18.589Z","v":0}
{"name":"mservice","hostname":"ms-users-production-0","pid":1,"level":30,"msg":"queue \"amq.gen-pQdG4usu7BVtX7KpbuyUZA\" created","time":"2016-07-05T19:57:03.027Z","v":0}
{"name":"mservice","hostname":"ms-users-production-0","pid":1,"level":30,"msg":"consumer is being created on \"amq.gen-pQdG4usu7BVtX7KpbuyUZA\"","time":"2016-07-05T19:57:03.028Z","v":0}
Unhandled rejection (<{"replyCode":404,"replyText":"NOT_FOUN...>, no stack trace)
{"name":"mservice","hostname":"ms-users-production-0","pid":1,"level":30,"msg":"re-establishing connection after \"[object Object]\" ","time":"2016-07-05T19:57:17.041Z","v":0}
Unhandled rejection (<{"replyCode":404,"replyText":"NOT_FOUN...>, no stack trace)

potentially fixed in #10


feat(#20): add feature to zoom/pan to position/node

The init function dTree.init(jsonData, {}) returns a set of functions to manipulate the zoom handler.

resetZoom(duration = 500): reset zoom and position to initial state
zoomTo(x, y, zoom = 1, duration = 500): zoom to a specific position
zoomToNode(nodeId, zoom = 2, duration = 500): zoom to a specific node
zoomToFit(duration = 500): zoom in/out to fit the entire diagram into the viewport

The duration parameter controls the transition animation speed.

I need this feature, anyone gonna approve this please?


Token collisions1.3

This version provides support for rectangular token collisions.
The README/description also documents the script's API.

There might be a merge conflict between this branch and the Util Docs branch for the README and script.json files.
The README and script.json files for this branch should be accepted over the other one.

There's a merge conflict to due with your updating the help documentation in two different pull requests.


Fix minor typo in pong tutorial code comments

While reading through the pong tutorial code, I noticed that of should
have been off in code comments.  This commit fixes the issue.
This PR is submitted in the hope that it is helpful.  If you would like anything changed, please don't hesitate to let me know and I'll update the PR as appropriate and resubmit.

Maintainer merge checklist

[ ] Title is descriptive/clear for inclusion in release notes.
[ ] Applied a Component: xxx label.
[ ] Applied the api-deprecation or api-break label.
[ ] Applied the release-highlight label to be highlighted in release notes.
[ ] Added to the milestone version it was merged into.
[ ] Unittests are included in PR.
[ ] Properly documented, including versionadded, versionchanged as needed.

@tshirtman thanks for approving this! I'm not sure why the unit tests are failing though; the change is only a documentation change and should be affecting that, should it?

Yeah i don’t think it has anything to do with it, the CI might be flacky, that will need checking later, but no reason to block what’s just a comment change


In user-guide, in front matter, change approvers to reviewers.

Partially addresses #7432.

This change is

/assign @Bradamant3

/approve


hugo: Fix auto-font-size on iphone - safari

Turn off webkit text-size-adjust so Safari in Iphone to make sure Safari doesn't zoom in the text anymore

To test:
Go to https://cuelang.org/docs/concept/how-cue-works-with-json/#validating-json-files-against-a-schema on Safari on an Iphone. The text inside the code block should no be zoomed in anymore
Fixes: cue-lang/cue#3602

I will let @jpluscplusm check and action here, thanks!


"Take inside" doesn't work in C++ with #pragma line

In C++, if I use "take inside" to try and take the text "-Wdeprecated-declarations", it doesn't work.
#pragma clang diagnostic ignored "-Wdeprecated-declarations"

In the c++ parse tree everything after pragma is just one single opaque node. . We don't have access to if this is a string style argument, where the quotes are or anything like what we have with normal strings. We have to switch to a more text based approach instead of relying as much on the parse tree as we are doing today. This isn't really a bug we can fix with the c++ implementation; we have to basically rewrite our surrounding pairs win a new paradigm. Lucky for us I'm already working on exactly this :D
https://github.com/cursorless-dev/cursorless/pull/2457


silx.gui: Added support for QT_API environment variable

This PR adds support for selecting the Qt binding with QT_API env. var. (case-insensitive) the same way as matplotlib and close to qtpy - which is case sensitive.

There is no need to set/change the environment variable, both qtpy and matplotlib first check for already imported bindings, so I would prefer not to change the env. var. If it is fine for you, I would revert your change.

qtpy:

If one of the APIs has already been imported, then it will be used.

Otherwise, the shim will automatically select the first available API (PyQt5, PySide2,
PyQt6 and PySide6); in that case, you can force the use of one
specific bindings (e.g. if your application is using one specific bindings and
you need to use library that use QtPy) by setting up the ``QT_API`` environment
variable.

matplotlib:

At runtime, these backends select the actual binding used as follows:

    If a binding's QtCore subpackage is already imported, that binding is selected (the order for the check is PyQt6, PySide6, PyQt5, PySide2).

    If the [QT_API](https://matplotlib.org/stable/users/installing/environment_variables_faq.html#envvar-QT_API) environment variable is set to one of "PyQt6", "PySide6", "PyQt5", "PySide2" (case-insensitive), that binding is selected. (See also the documentation on [Environment variables](https://matplotlib.org/stable/users/installing/environment_variables_faq.html#environment-variables).)

    Otherwise, the first available backend in the order PyQt6, PySide6, PyQt5, PySide2 is selected.

There is no need to set/change the environment variable, both qtpy and matplotlib first check for already imported bindings, so I > would prefer not to change the env. var. If it is fine for you, I would revert your change.

There is no need, but I was so annoyed of seeing the warning "selected binding pyqt5 but pyside6 already imported" that I did not realize the warning seems to have been removed in recent versions.
You can revert my commit if you wish.

Thank you @t20100! I tested it and it works as expected.


Update spaceradar to 4.4.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 3f1816280e2fb78448b19e6a1708dcfb537152c5. Your contribution is still credited to you.


Allow to select multiple files in the file dialog

Extend the file dialog by the possibility to select multiple files at once.

Hi Jens,
Could take a look at the tests ?
Thanks !

Hello leplatrem,
in August I tried to install all npm packages using "npm install", after 3 hours I aborted the installation process. In that time npm created an endless structure of folders, which I wasn't able to delete with Windows tools, I had to download a special tool which was able to get rid of all the files.
I think there was a circular reference in the mocha package, or maybe a bug in npm.
Whatever, I've tried it again now, and it downloaded the packages in less than 10 seconds without problems.
But now I have the next problem, I'm not sure how to great an automatic unit test for that.
How would you test the opening of multiple files especially using drag&drop? To me it looks like there are no unittests for that, which I could use as base for my tests.

Hi,
Thanks for coming back  :) Sorry for the delay, I don't work for the company anymore :|
Indeed, there might not be too much tests already there. Maybe you could just add a small test to check that the input field has the 'multiple' option.
It would be a symbolic test, but at least it proves that our intentions are to test the changes of this PR :)

Thanks for the PR @jens-duttke !
I merged your PR, adding a test to assert that the input has the 'multiple' option


Inconsistent display of default values in help output

If the default value text for the help output is given with a string value in the show_default option of the click.Option class it is shown with parenthesis around the value. If the it's taken from the default option directly no parenthesis are shown. Both ways of defining the default value shown in the help text should use the same formatting. If parenthesis are desired they can be added to the show_default string value directly.
This is caused by this code block in src/click/core.py:
2736             if show_default_is_str:
2737                 default_string = f"({self.show_default})"
2738             elif isinstance(default_value, (list, tuple)):
2739                 default_string = ", ".join(str(d) for d in default_value)
2740             elif callable(default_value):
2741                 default_string = _("(dynamic)")
2742             elif self.is_bool_flag and self.secondary_opts:
2743                 # For boolean flags that have distinct True/False opts,
2744                 # use the opt without prefix instead of the value.
2745                 default_string = split_opt(
2746                     (self.opts if self.default else self.secondary_opts)[0]
2747                 )[1]
2748             else:
2749                 default_string = str(default_value)

Environment:

Python version: 3.9.2
Click version: 8.0.1

The parentheses are to indicate that it's not the actual value but a message, see (dynamic) as well.

IMHO this is only one possible use of this setting. And if the parentheses are desired they can always be added to the show_default string. In my use case I wanted to show the actual value but in a different "formatting". See #1999. While this is a bug I think there might be other cases where it's not so clear that this is a bug. Adding the parenthesis in the code removes this flexibility.