Unable to specify Null as Session ID when applying Link Filter

Because a string is nullable in C#, the SDK allows for AMQP encoding of a string to either the string value or AMQP Null As seen here:
C# AMQP StringEncoding.cs#L30
At the moment, setting a session-filter does not allow for a nil value to be passed in:
https://github.com/vcabbage/amqp/blob/271d6282f59cd10184fef147de589cce8ad69c93/client.go#L1509
I'll have a PR in by EOD to change this.

Can you please describe the use case? The spec says that a null value is the same as not setting a filter.

The spec says that a null value is the same as not setting a filter.

This is what I thought as well. However, as I've been implementing Service Bus support over here: https://github.com/marstr/azure-service-bus-go/tree/sessions I ran into a weird behavior. When I placed a session filter with a string value, the broker would pass me only messages with a particular GroupID (Service Bus calls this "SessionID" but I'll call it GroupID as AMQP does to avoid ambiguity) as expected. However, if I omit the filter, instead implicitly choosing a GroupID to filter on for me, it just sends messages from multiple session interleaved together. It's not clear to me, but I hope it would still at least assign an affinity between a particular GroupID and a particular link. When chatting with the Service Bus team about it, they said that the way to get my desired behavior and how to match the C# SDK was to provide a SessionFilter, but to have the ID be null. I checked against the C# SDK and confirmed here that this is how the C# SDK does it.

I tried to find documentation on "com.microsoft:session-filter", but haven't had much luck. It makes me think we should revisit whether LinkSessionFilter really belongs in this library. Perhaps a different API for vendor specific filters is the better approach.
@devigned and I discussed this a bit previously when the option was added in https://github.com/vcabbage/amqp/pull/26

It makes me think we should revisit whether LinkSessionFilter really belongs in this library. Perhaps a different API for vendor specific filters is the better approach.

Agreed, it doesn't feel like something that should live here to me. Given that LinkOption is an exported type, it would be just as easy for me to add the same method over in the service bus repository.

I can close out #135 if you'd like, or we can accept this PR for now and open an issue for me to refactor out the vendor specific stuff in the near future. Whichever you prefer is fine.

Would modifying #135 to make an empty string indicate null work for the time being?

Let me do a little exploring to see if an empty string is a valid GroupID. If it's not valid, I don't mind that approach. If it is valid, I'm a little less comfortable with it, for fear that temporary work arounds often become permanent.

Looks like empty string is valid as a GroupID (for better or worse).
I'll spend a few minutes tinkering to see if I can come up with something compelling for exposing these sorts of LinkOptions through third-party repositories.

I through-out another option, that isn't a breaking change but does expose through a little bit lower-level concept than previously shown. However, I think it's a good compromise and will allow me to write a method in Azure/azure-service-bus-go that does what I need for filtering.

The spec says that a null value is the same as not setting a filter.

After rereading the spec, I realized my comment was incorrect, at least in this context.
The spec says:

Every key in the map MUST be of type symbol, every value MUST be either null or of a described type which provides the archetype filter. [...] If the value for a given key is null, this acts as if there were no such key present (i.e., all messages pass through the null filter).

In this case, it's setting the map value to a described type with a null value, which is subtly different.


After install all the package in a conda env, got the error message!

hi, I got an error after install all the packages and run your code.
Traceback (most recent call last):
File "/home/ubuntu/OSRL/examples/train/train_bc.py", line 15, in
from fsrl.utils import WandbLogger
File "/home/ubuntu/anaconda3/envs/OSRL/lib/python3.9/site-packages/fsrl/utils/init.py", line 3, in
from fsrl.utils.logger import BaseLogger, DummyLogger, TensorboardLogger, WandbLogger
File "/home/ubuntu/anaconda3/envs/OSRL/lib/python3.9/site-packages/fsrl/utils/logger/init.py", line 4, in
from fsrl.utils.logger.tb_logger import TensorboardLogger
File "/home/ubuntu/anaconda3/envs/OSRL/lib/python3.9/site-packages/fsrl/utils/logger/tb_logger.py", line 5, in
from torch.utils.tensorboard import SummaryWriter
File "/home/ubuntu/anaconda3/envs/OSRL/lib/python3.9/site-packages/torch/utils/init.py", line 4, in
from .throughput_benchmark import ThroughputBenchmark
File "/home/ubuntu/anaconda3/envs/OSRL/lib/python3.9/site-packages/torch/utils/throughput_benchmark.py", line 2, in
import torch._C
ModuleNotFoundError: No module named 'torch._C'

It seems that the PyTorch version doesn't support the tensorboard SummaryWriter. Could you show me your PyTorch version?
You can also try to update your PyTorch version to 1.13.1 since this version works for us well.

Your understanding is correct. The bolded $\mathbf{R}$ and $\mathbf{C}$ represent all the reward returns and cost returns in the trajectory, while $R(\tau_i^*)$ denotes the scalar return of the entire trajectory.


Update CONTRIBUTING.md

Updated Contributing.md file
Motivation for the change:
Closes #3

Thanks so much for your help! There's just a couple of links that need updating to match this repo then this should be ready to merge.
Both the issues ended up in the same PR, it's not a big deal with such small PRs but try to remember to make separate branches for each issue next time.

yes, I will update the corrections and also I also realized they same PR will have 2 changes after i created this one, that's why I did a single commit in the main for appreciation.ymlPR , I will remember it to branch out first while creating, thanks for the review.

If you want to delete the yaml file from this pr I can merge the other one

If you want to delete the yaml file from this pr I can merge the other one

yes, Deleted appreciation.yml.

Brilliant, thanks!

thanks for the support, do I need to look up for some other issues too?

You're more than welcome to look through the current issues or if you find something missing then feel free to create a new issue too. I will hopefully be adding more over time, I just need to start working on a design for this repo so we have something to start with.

You're more than welcome to look through the current issues or if you find something missing then feel free to create a new issue too. I will hopefully be adding more over time, I just need to start working on a design for this repo so we have something to start with.

that's awesome, I would truly like to work on it, looking forward to more contributions.


Change the default favicon and banner

When the logo of the community come out, replace the default theme favicon and banner @yekangming

Done. Close.


NopCustomerDefaults Class Doesn't Have Required Properties

Hello,
I am trying to build the api plugin project but Nop.Core.Domain.Customers -> NopCustomerDefaults class does not have below properties those are required:
FirstNameAttribute
LastNameAttribute
LanguageIdAttribute
CurrencyIdAttribute
DateOfBirthAttribute
GenderAttribute
VatNumberAttribute
VatNumberStatusIdAttribute
CompanyAttribute

How can I handle this problem?
Thanks.

same issue

Fixed with branches 4.7 and develop


Uncaught Error: Cannot find module '@microsoft/dotnet-js-interop'

The nugets work fine, but when cloning this repo and building from source it looks like it is either pulling in newer stuff for the javascript side.
I can get it to work by editing the package.json and replacing
"@dotnet/jsinterop": "3.1.3",
with
"@microsoft/dotnet-js-interop": "5.0.0-preview.4.20257.10",
and
import<EMAIL_ADDRESS>with
import<EMAIL_ADDRESS>in the src*.ts files
I notice microsoft recently moved the js code into this renamed module.

Thanks @roceh. I was still tracking the development branch for the Blazor javascript files, but it's stable by now. New nugets should be there shortly. The source should be OK as well.


[CRASH ON STARTUP] [1.21.1] NeoForge 21.1.61 + Azure Lib Armor 2.3.13

Minecraft Info:
Minecraft Version: 1.21.1
Modloader version: NeoForge 21.1.61
Mod version: 2.3.13
Describe the bug:
Unable to start the game, it either crashes on startup or gets stuck on the loading screen.
Steps to reproduce the behavior:

Create a clean instance of 1.21.1 NeoForge 21.1.61.
Install Azure Lib Armor 2.3.13 for NeoForge.
Start the game.
See error.

Screenshots:

Logs:
https://mclo.gs/ym2MwwZ

Because its made for .62+.

Because its made for .62+.

And which version supports .61?


mj-group stacking into column on Gmail for iOS

mj-group containing 2 columns with images breaks into a stacked column on Gmail for iOS.  I have exported my code minified using the CLI command mjml source.mjml -o output.html --config.minify as well as using this tool, which was recommended in a separate issue.  Here is the relevant section of my code (non-minified):
  <mj-body background-color="#F2F2F2" width="500px">
    <mj-section background-color="#FFFFFF" vertical-align="center" padding="24px 16px 30px">
      <mj-group vertical-align="center">
        <mj-column>
          <mj-image width="190px" padding="0"  src="https://marketing.cloudagentsuite.com/cdnr/34/acton/attachment/35764/f-0016/1/-/-/-/-/cloud-agent-suite-logo.png" alt="Cloud Agent Suite" />
        </mj-column>
        <mj-column>
          <mj-image width="98px" padding="0" align="right" src="https://marketing.cloudagentsuite.com/cdnr/34/acton/attachment/35764/f-0017/1/-/-/-/-/mlsok.png" alt="MLS OK" />
        </mj-column>
      </mj-group>
    </mj-section>

</mj-body>

And this is the result:

Reproduction Steps:

Start with the mj-group example from the docs
Replace image paths with my own, use correct width of image.
minify output using CLI or tool mentioned above.
paste code into litmus and run browser previews

Expected behavior:
I would expect the images to remain on the same line, and not break into a column, like so:

Observed behavior:
The image on the right falls beneath the image on the left, stacking them into a column on Gmail for iOS as well as Inbox for iOS.
Screenshots and GIFs
Screenshots included above.
MJML version:
4.0.5
Email clients the bug is seen on:

Gmail App (iOS 10.3.2)
Inbox by Gmail (iOS 10.3.2)

Screenshot taken from an iPhone 6 on EOA seems ok for me :

You may have an option checked somewhere in litmus that alter the minified output ? If the HTML works in Mail.app it should works in Gmail too (same webkit bug)

Closing because we're unable to reproduce on EOA part, feel free to reopen if it happens with a real device / other method

This is a weird bug that continues to happen on certain iPhones with the Gmail app. It does not happen on all of my templates that use mj-groups. That's all I have right now - working when available to identify the issue. It will not always show stacked columns in the EOA previews (I'm not sure why). Co-workers bring their physical devices to me that show the stacked columns as described by @skywinston
I have acquired an iPhone 7 to see if it's specific to iPhone 6 and 6+ (which are the devices where it shows the symptom). Working on that still.
The apple reformatting meta tag does not fix the issue. As OP mentioned, you have to use a minifier with reduced max line length (I use 100) to get it to not stack.

I don't really advise to use max line length, it could break line in an
unwanted place causing Webkit to render it and stack columns. We would be
happy to reopen if someone can provide a template with 100% reproduction
rate on EOA/Litmus/Physical device.
On Mon, Jun 25, 2018 at 10:53 PM S. Baker<EMAIL_ADDRESS>wrote:

This is a weird bug that continues to happen on certain iPhones with the
Gmail app. It does not happen on all of my templates that use mj-groups.
That's all I have right now - working when available to identify the issue. It
will not always show stacked columns in the EOA previews (I'm not sure
why). Co-workers bring their physical devices to me that show the stacked
columns as described by @skywinston https://github.com/skywinston
I have acquired an iPhone 7 to see if it's specific to iPhone 6 and 6+
(which are the devices where it shows the symptom). Working on that still.
The apple reformatting meta tag does not fix the issue. As OP mentioned,
you have to use a minifier with reduced max line length (I use 100) to get
it to not stack.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/1243#issuecomment-400091743, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAizzc3KmY8bMQ-7Zh69DRcYxFHKhY2jks5uAU2_gaJpZM4UlIeG
.

--
Cordialement,
Maxime BRAZEILLES

@shorstki indeed, there's a blue note in the docs about that:

iOS 9 Issue: If you use a HTML beautifier for MJML output, iOS9 will render your columns inside a mj-group as stacked. On the output HTML, remove the blank space between the two columns inside a mj-group.

i'm using iphone6 with iOS 12.1, still i have same issue mj-group not working on Gmail app, i send from mailjet with code in document.

Hey @AnthonyLai1001, we had to temporarily deactivate the minify setting in our builder for another reason, sorry about that. We're working to bring back minification for all templates asap.

@ngarnier Is there any movement here on this minifier? I'm having the same issue. Mj-group works fine in the Try-It-Live, but when I fire the HTML it generates off to gmail, the lines stack. Or perhaps there's a current workaround? Thanks.

Just minify your html it should behave as it should then.

On 9 Apr 2019, at 20:10, Sawyeraltman<EMAIL_ADDRESS>wrote:
@ngarnier Is there any movement here on this minifier? I'm having the same issue. Mj-group works fine in the Try-It-Live, but when I fire the HTML it generates off to gmail, the lines stack. Or perhaps there's a current workaround? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

As I mentioned above, I tried that – it turns out I was just using a poor minifier. Just tried http://minifycode.com/html-minifier/ and it's come out nicely. Thanks.

That's the one shipped within MJML :)
On Tue, Apr 9, 2019 at 8:17 PM Sawyeraltman<EMAIL_ADDRESS>wrote:

As I mentioned above, I tried that – it turns out I was just using a poor
minifier. Just tried http://minifycode.com/html-minifier/ and it's come
out nicely. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/1243#issuecomment-481371330, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAizzcDdfqXatfiKz1MglU2WDVjFntfJks5vfNksgaJpZM4UlIeG
.

I would like to report the same persistent bug on Ipad Air 2 (iOS 12.1). Code minifying does not help in any way. The problem is on Gmail client, Apple mail is OK.

How did you send your email?
On Mon, Apr 15, 2019 at 9:40 PM Eugene Chernov<EMAIL_ADDRESS>wrote:

I would like to report the same persistent bug on Ipad Air 2 (iOS 12.1).
Code minifying does not help in any way. The problem is on Gmail client,
Apple mail is OK.
[image: IMG_0040]
https://user-images.githubusercontent.com/40392032/56160275-7a864680-5fcf-11e9-956b-db22b9d27ba0.PNG
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/1243#issuecomment-483389924, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAizzYBsYoQW87yRbX4YCYrgHKUIEOMCks5vhNXDgaJpZM4UlIeG
.

It was via Sendpulse template editor. Could it potentially cause the issue?

Try with putsmail.com to Check yes

On 16 Apr 2019, at 08:01, Eugene Chernov<EMAIL_ADDRESS>wrote:
It was via Sendpulse template editor. Could it potentially cause the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you for the response, still very dependent on Sendpulse. It's our primary email marketing tool. What compatible solution can you suggest/if any? Maybe some 3rd party HTML minifier?

The issue is not with the minifier but with Sendpulse altering your HTML. The only solution is to ask them to stop messing with the HTML you want to send, or to change tools.

I'm having a similar problem using putsmail.com with the following code:
<mjml>
  <mj-body>

    <mj-section>
      <mj-group>
        <mj-column>
          <mj-text>

Button 1

          </mj-text>
        </mj-column>
        <mj-column>
          <mj-text>

Button 2

          </mj-text>
        </mj-column>
      </mj-group>
    </mj-section>
  </mj-body>
</mjml>

It is looking good in every email client I've tried except gmail for IOS, where it is being stacked.
It works fine if using 3 columns instead

I confirm @angrykoala I have the same issue with Gmail iOS and by adding a third "empty" column fixes it! Thanks for the idea.

My team was running into the same problem. Two columns: left – 73%, right – 27% width, with a total of 100%.
First of all: a big thank you to everybody, above who was trying to help and shared their solutions!

The solution with adding a 3rd column did not work for us.
The solution with minifying via http://minifycode.com/html-minifier/ did work. But that way is hard to make changes without unminifying first.
Finally, we come up with this solution:  for the left column, we decreased the width by 1% and set that 1% as padding.  That works perfectly.

Keep in mind: for some reason, this solution works only for the left column, but not for right.
Final result:

Well you should not modify the output html, unless you really need to do something specific with the html ?

Well you should not modify the output html, unless you really need to do something specific with the html ?

Yeah, but we kinda have no choice:

We have to provide the "final HTML" to our clients. This is one of their requirements.
We were unable to fix that problem inside of the MJML editor. So we had to "look deeper".

If you really want to edit the HTML without minifying, just remove the space between the columns as explained in the documentation. It's way more straighforward and not hacking with % to fix that iOS bug.

iOS 9 Issue: If you use a HTML beautifier for MJML output, iOS9 will render your columns inside a mj-group as stacked. On the output HTML, remove the blank space between the two columns inside a mj-group.

Thanks for this note, @ngarnier.
I wouldn't say that we really want to play around with output HTML, but we had to.
Anyway, I just need to point that this hack with 1% we were able to do in MJML editor, even without digging into output HTML. So that way the output HTML was ready to deploy.
I would consider that solution as better and easier.

My team was running into the same problem. Two columns: left – 73%, right – 27% width, with a total of 100%.
First of all: a big thank you to everybody, above who was trying to help and shared their solutions!

The solution with adding a 3rd column did not work for us.
The solution with minifying via http://minifycode.com/html-minifier/ did work. But that way is hard to make changes without unminifying first.
Finally, we come up with this solution:  for the left column, we decreased the width by 1% and set that 1% as padding.  That works perfectly.

Keep in mind: for some reason, this solution works only for the left column, but not for right.
Final result:

This worked for me!

@limonfresh, jeeesus, thank you so much for this solution!

@shorstki indeed, there's a blue note in the docs about that:

iOS 9 Issue: If you use a HTML beautifier for MJML output, iOS9 will render your columns inside a mj-group as stacked. On the output HTML, remove the blank space between the two columns inside a mj-group.

@ngarnier Deleting the blank space worked for me, However I'd like to note for anyone else struggling with this, you can't just delete the blank line between the two, you must delete ALL BLANK SPACES surrounding the comments, etc, so its all on one line. Then it will work.


Allow creation of user with bridge-generated username

In the future, the Hue API will no longer support creating users with custom usernames on the bridge, only users with bridge-generated usernames. A new bridge method will need to be added to jsHue to support this change.
It will look something like:
var bridge = jsHue().bridge('<IP_ADDRESS>');
bridge.createUser('foo application', function(data) {
    // extract bridge-generated username from returned data
    var user = bridge.user(data[0].success.username);
});

Hi blargoner,
Thanks for your tool :)
Do you have a milestone for this enhancement?

@Mysterarts v0.3.0. :)

Thanks a lot!

Interessting - I just used
hue.bridge(bridgeIp).user().create("MyApp", function(successResultArray){});

and that worked with the new API.
But thanks for the updated version.

@derjust Nice workaround. With the new version, you can avoid instantiating a user() object twice.


AWS::ECS::TaskDefinition Encountered Unsupported Property image

Describe the bug
When recording a ECS TaskDefinition the property in ContainerDefinitions are recorded starting with a lowercase letter but need to be a uppercase first letter
Related Mapping
AWS::ECS::TaskDefinition
Related Language
Cloudfomration (maybe others as well)
To Reproduce
Steps to reproduce the behavior:

Record AWS::ECS::TaskDefinition
check CF script
see image instead of Image (other as well)

Expected behavior
should be Image

Hi there,
Thanks for raising!
I've gotten some fixes in release 0.3.27, which should be available roughly one hour from now. The update isn't tested fully so if there are any issues please let me know.

seems to be working now, thanks.


ArgoCD pod scheduling does not follow otomi.nodeSelector

Describe the bug: (a clear and concise description of what the bug is)
To Reproduce
Steps to reproduce the behavior:

Create cluster with two nodepools
Deploy Otomi with otomi.nodeSelector set to the first pool.
Observe that affinity is added to the spec of the argocd deployments (/spec/template/spec/affinity/nodeAffinity/requiredDuringSchedulingIgnoredDuringExecution/nodeSelectorTerms), but that the values

key: <label-name>
operator: In
values:
- <label-value>

is added over and over again, resulting is a loop where the Pods are created and then terminated again.
Expected behavior: (a clear and concise description of what you expected to happen)
ArgoCD workloads are deployed on pool specified by  otomi.nodeSelector selector

It's not needed to add a second node pool to reproduce this bug. Just set the nodeSelector and then delete one of the argocd pods.

waiting for release


[SUPPORT] Better packaging for hudi-cli with hudi-cli-bundle.jar

Describe the problem you faced
Currently there does seem to be any packaging for hudi-cli. According to this doc, to use hudi-cli.sh, users need to clone the source code and build it with Maven. Even worse, the build result has lots of dependency jars in to the target/lib dir. This is not so user-friendly and hard to distribute.
To Reproduce
N/A
Expected behavior
Ideally, there should be a better packaging for hudi-cli. For example, it generates a hudi-cli-bundle.jar, available on Maven Central, and can be used with hudi-cli.sh directly.
Environment Description

Hudi version : 0.12.0

yes, we have it in our plans.
https://issues.apache.org/jira/browse/HUDI-4666
CC @rahil-c

thanks for the ask. Will see how we can prioritize this.


add intro page back

Change Description

Add introduction page back to docs.
API Changes

[ ] API Changes

Documentation Additions

[x] Documentation Additions

@lparisc Introduction wasn't removed, it was moved to index.md because the README.md was not suitable as a splash page.

@lparisc Introduction wasn't removed, it was moved to index.md because the README.md was not suitable as a splash page.

Ok I see. I'll fix it then

@lparisc There's nothing to fix. Having both a README.md as a splash page and an introduction.md that is essentially a splash page doesn't really make sense IMO (that is what it was created for initially, but a miscommunication resulted in the creation of an "Introduction" page.

@dskvr I need to fix the broken link #640 by linking to the index file.

Not the best solution, but considering @dskvr's notes, maybe the line can be rephrased/removed.

Fix the broken link, don't regress the docs.


hi

Can i be in? I am in studio
I will post "verify:joshatticus" in studio as myself

I am in studio too
verify:god286

let's see if i have the permissions to do this

hmm

done

Josh Atticus wasn't invited (the ST deleted their comment). They later said it was them here.

Hmm, I wonder why it was deleted.

i added @JoshAtticus


Crash

Hey there,
Crashlytics found a new issue today. Have no idea how to reproduce it, hope the crashlog will help.
Thread : Crashed: com.vluxe.starscream.websocket
0  libobjc.A.dylib                0x24d8597c lookUpImpOrForward + 111
1  libobjc.A.dylib                0x24d8595b lookUpImpOrForward + 78
2  libobjc.A.dylib                0x24d85903 _class_lookupMethodAndLoadCache3 + 34
3  libobjc.A.dylib                0x24d8bd7b _objc_msgSend_uncached + 26
4  gg                             0x27fed0 WebSocket.(canDispatch in _6F7C047625E628753C22EBD59D0B6D08).getter (WebSocket.swift:133)
5  gg                             0x28cfac WebSocket.(doDisconnect in _6F7C047625E628753C22EBD59D0B6D08)(NSError?) -> () (WebSocket.swift:800)
6  gg                             0x286a50 WebSocket.(disconnectStream in _6F7C047625E628753C22EBD59D0B6D08)(NSError?) -> () (WebSocket.swift:357)
7  gg                             0x2867d8 WebSocket.stream(NSStream, handleEvent : NSStreamEvent) -> () (WebSocket.swift:348)
8  gg                             0x286938 @objc WebSocket.stream(NSStream, handleEvent : NSStreamEvent) -> () (WebSocket.swift)
9  CoreFoundation                 0x2552448b _signalEventSync + 146
10 CoreFoundation                 0x2557fdef ___signalEventQueue_block_invoke + 14
11 libdispatch.dylib              0x2514fdd7 _dispatch_call_block_and_release + 10
12 libdispatch.dylib              0x25159f97 _dispatch_queue_drain + 1762
13 libdispatch.dylib              0x25152f2f _dispatch_queue_invoke + 282
14 libdispatch.dylib              0x2515b325 _dispatch_root_queue_drain + 400
15 libdispatch.dylib              0x2515b193 _dispatch_worker_thread3 + 94
16 libsystem_pthread.dylib        0x252e8e0d _pthread_wqthread + 1024
17 libsystem_pthread.dylib        0x252e89fc start_wqthread + 8

Thanks for the report, but unfortunately a part of a backtrace doesn't give me much to work off. How many times has it been reported as a crash? The error is fairly generic and by just looking at the lines it is something around disconnecting, but there isn't much I can suggest in troubleshooting. What does your code do when the WebSocket is disconnected?

Crash rate is 1/1300 sessions and happens only on iOS 9 (Fabric reports). On disconnect app shows an alert view. It's not a big deal, but I wanted to get to the bottom of the issue.

We're seeing two similar issues. If you like I can make two separate github issues outside of this.
Maybe it will help a little.

Crashed: com.vluxe.starscream.websocket
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000020
0
libobjc.A.dylib
objc_release + 16
1
SocketIOClientSwift
_TToFC19SocketIOClientSwift9WebSocket6streamfS0_FTCSo8NSStream11handleEventVSC13NSStreamEvent_T_ + 68
2
CoreFoundation
_signalEventSync + 192
11
libsystem_pthread.dylib
start_wqthread + 4

Crashed: com.vluxe.starscream.websocket
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x002400013f672000
0
libobjc.A.dylib
objc_msgSend + 8
1
SocketIOClientSwift
_TTSf4g_n___TFC19SocketIOClientSwift9WebSocketP33_ED38407276FC67CE6D5C84F7A1133F2A16disconnectStreamfS0_FGSqCSo7NSError_T_ + 332
2
SocketIOClientSwift
_TTSf4g_n_n___TFC19SocketIOClientSwift9WebSocket6streamfS0_FTCSo8NSStream11handleEventVSC13NSStreamEvent_T_ + 4056
13
libsystem_pthread.dylib
start_wqthread + 4

@rgallagherzonoff Again thank you for the report, but these type of logs with just a part of a backtrace aren't much help. These are pretty generic errors and a number of things can cause these sort of crashes. If you have a sample app or code where these crashes are occurring that would be helpful in tracking down the issue. Thanks!

+1


Addon doesn‘t work anymore error (log) s6-overlay-suexec: fatal: can only run as pid 1

unfortunately your addon doesn‘t work anymore, probably because of latest Home Assistant update?

I'll take a look.

Thank you very much!
Greetings

Am 18.05.2022 um 23:07 schrieb Karl Anders Øygard @.***>:

I'll take a look.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Try 0.54.2, hopefully fixes your issue.
You are commenting in the wrong repo, by the way. :)

it works fine! Thank you for the quick reaction and sorry for commenting in the wrong place ;)

Am 19.05.2022 um 21:10 schrieb Karl Anders Øygard @.***>:

Try 0.54.2, hopefully fixes your issue.
You are commenting in the wrong repo, by the way. :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


inference code not working

Hi,
I wanted to test the code by running inference on a couple of samples images i downloaded from the internet. But it's not working. Here are the steps that i followed:

cloned repo and setup the conda environment. Note: since there were compatibility issues between tf 1.13 and python 3.5, I used python version 3.6.
created a subdirectory in the repo called data/pretrained_weights and downloaded the resnet50 related ckpt files from GDrive into the directory. That is, the files resnet50_v1d.ckpt.data-00000-of-00001 ,  resnet50_v1d.ckpt.index and  resnet50_v1d.ckpt.meta.
ran the inference code on a folder containing the following two images:

image_1.
image_2.

the images generated in the destination folder don't contain any bounding boxes.

Am I doing something wrong? Could you please guide. Thanks in advance.

pretrained_weights is used for training. you need download trained weights in MODEL_ZOO.md @karan-shr

@yangxue0827 thanks for the reply.
Okay so this is what I did:

Downloaded the weights for for R3Det with ResNet50_v1d backbone from the link provided in MODELZOO.md doc. Extracted the files and placed them under the output/trained_weights folder. The four files are

checkpoint
DOTA_1079996model.ckpt.data-00000-of-00001
DOTA_1079996model.ckpt.index
DOTA_1079996model.ckpt.meta

The data/pretrained_weights contain all the files provided in your Gdrive link mentioned in point 2 of your documentation.

The tools/inference.py script uses the standard config file (configs/cfgs.py), so I didn't modify that. Then I ran the inference.py script again and then I got the same result as last time, no bounding boxes.

refer here
@karan-shr

@karan-shr

I updated inference.py and you need to download the script again. @karan-shr

Hi @yangxue0827,
Based on your feedback, did the following:

Did a git-pull to get the latest version of the inference.py and other changes into the my local repo.
changed the folder structure for the weights as you have mentioned in the figure above.

Sadly, still no bounding boxes. Can you please test on the images i had mentioned in the first comment. Just to compare.
Thanks for the feedback so far.
Regards,
Karan

my model is trained by DOTA dataset. which is very different from your images, so no results are normal. Maybe you need to retrain a model with your own data. @karan-shr

Yes, i know the images are different. But in this case the bounding box should be wrongly placed, or over- or under-segment. But getting no bounding boxes on an image is also not normal.
Ofcourse, I can retrain the model. But first to determine the efficacy of the code, I am trying your inference code with some simple examples. It should work, shouldn't it? Does the inference script work for you?

Why not use the dota dataset for inference and use the test_dota_r3det.py script.

applied tools/inference.py on DOTA Test set 2 images, still no bounding boxes. Adjusted libs/configs/cfgs.py VIS_SCORE to 0.0, still no bounding boxes.
Here's the code I used
python inference.py --data_dir '/dir/of/2/test/images/' --save_dir '/my/chosen/folder/' --gpu 0 --draw_imgs
Here's the output running inference script on DOTA Test set P0034.png

I also encountered the same problem when running test_dota_r3det.py, and I have placed the file location according to the author's instructions, has your problem been solved?

I printed out the test results and found that they were all empty


Better handling of static const function variables in spv*TableGet()

We have a bunch of static const function variables to represent various bits of the SPIR-V grammar. It contains non-POD fields, which causes problems with custom memory allocators: https://github.com/Microsoft/DirectXShaderCompiler/issues/725. Need to figure out a better way of handling them, e.g., using non-const global pointer, changing everything to POD, etc.

Done via #920


2.11.x: Add copyCheckouts(WorkflowRun) method.

This will be used to copy the checkouts list from one run to another,
to support certain use cases where we need to ensure that the
checkouts list is propagated even though actual checkouts aren't
happening.
cc @reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Just do review in #62, and if and when merged, it can be backported (git cherry-pick -x -m1 $merge_commit) without additional review (assuming the backport is clean).

@jglick Gotcha, closing.


Display a warning when someone passes an invalid profile name on the wt commandline

Environment
Windows build number: 10.0.19041.264
Windows Terminal version (if applicable): 1.0.1401.0

Profiles:
Windows Powershell
Command Prompt
PowerShell
PowerShell 7 Preview
Ubuntu
Azure Cloud Shell

Config: settings.txt
Steps to reproduce

wt -p Windows PowerShell
Causes Windows Powershell to be loaded, but with Powershell (Core) as the profile
wt -p Command Prompt
Following message is shown: [error 0x80070002 when launching `Prompt'] (Is using the Powershell (Core) profile but the tab name is empty)
wt -p ubuntu
Launches Powershell (Core)

Expected behavior
Less confusing behaviour, from what I have observed it seems like, on my system at least, the Powershell (Core) profile is considered a default of sorts, so if it doesn't find a direct match it just opens that. It also seems that the second argument seems to be passed as an argument to the profile, not entirely sure if that's right way to describe it, as wt -p Windows Get-Date results in the same error as the Command Prompt example instead of executing Get-Date.
So I think ways of adressing that would be:

Commands should only accept the ones defined in the documentation, (e.g. new-tab, split-pane, focus-tab)
If a direct (case insensitive) profile match isn't found, is it possible to launch the default profile while displaying to the user that the selected profile wasn't found?
(imo) If a direct (case insensitive) profile match is found do launch that, instead of the default. (i.e. wt -p ubuntu is the same as wt -p Ubuntu)

Actual behavior
In steps to reproduce, above.

You need to use spaces to wrap the profile names as a single argument - so do wt -p "Windows Powershell" or wt -p "Command Prompt". For more details, refer to command-line arg documentation

Hi, I'm sorry if I didn't phrase the issue better, but none of the issues I mentioned are related to quotes itself, they are how I discovered the issue(s), but everything I wrote is still the case, whether quotes are used or not.

Ah okay, gotcha. Sorry, long day triaging.
If we can't find the profile provided, you're right, we default to whatever the default profile is for your settings. So that's why it seems like "powershell core" is the default value - it probably is.
RE:

Commands should only accept the ones defined in the documentation, (e.g. new-tab, split-pane, focus-tab)

If a direct (case insensitive) profile match isn't found, is it possible to launch the default profile while displaying to the user that the selected profile wasn't found?

(imo) If a direct (case insensitive) profile match is found do launch that, instead of the default. (i.e. wt -p ubuntu is the same as wt -p Ubuntu)

I'm not sure I totally get what the problem is here - we definitely only accept the given subcommands. Everything that we don't recognize that's passed to new-tab or split-pane is treated as a commandline value to use instead of the commandline from the profile. When there's no subcommand provided, we default to new-tab.
This isn't a terrible idea.
I tried playing with case-insensitivity in #5690, though, I think we're probably going to stick with case sensitivity at this point.

No worries, I can imagine you're all pretty swamped with a sudden influx of reports from releasing at build. 😄
In regards to 1., your explanation helped me see that I misunderstood the documentation, wt -p "Powershell" is, as you point out, the equivalent of wt new-tab -p "Powershell". So what I thought was a command was actually a parameter for the command. So in the end it's getting passed to the commandline parameter of the new-tab command, exactly as the documentation states. Sorry for missing that.
I didn't see you were already experimenting with case sensitivity, so that's fair,.

Two thoughts on this:

The profile name is case sensitive. (Example: "Poershell 7" != PowerShell 7`)
I agree that a notification about the wrong profile name makes sense.


Request hasPreviousSession and Cookie Session Handler

I configured my app to use Cookie Session Handler and discovered that authentication started breaking. I kept getting "Your session has timed out, or you have disabled cookies.". I traced this issue down to AbstractAuthenticationListener and then to the hasPreviousSession method of Request. I discovered that if I add:
framework:
    session:
        name: session

...the problem disappears. But doing this means that the browser is receiving two cookies named "session". The browser seems to be using the last Set-Cookie: session= when it picks which of the two to send back.
I am wondering if this is how this session handler is meant to be used, or if there is some extra configuration that needs to be done.

:+1: simply does not work at all with symfony 2.7
I just can not log in if encrypter/singer is enabled.. Debugged and ended up with the same result - cookies are removed from request, and onKernelResponse simply not getting called.
We use Redis to store our sessions.

Symfony 2.7 here. Same use case as rodush.

Run into the same problem :disappointed:

same problem. symfony 3.

Think we're hitting the same problem in Symfony 3 (using signed_cookie).

Is there any progress or some knowledge about a workaround for this issue? We are experiencing the same issue in a symfony 3.4 project.

Closing the issue since SessionCookieHandler and EncryptedCookieListener have been removed in 3.0, feel free to open a new issue if the problem persists.


Scrub is not functioning properly

using a Docker image v0.31 on unRaid.
Go to Settings > Delete history version data
type confirm text "scrub".
Limit delete history including and after date is a required field so I set to a future date to scrub all data.
Here I recommend setting the input type to "date" instead of text to reduce likelihood of bad user input and improve ease of use
After hitting submit I get the following error:
Traceback (most recent call last):   File "/usr/local/eventlet/wsgi.py", line 563, in handle_one_response     result = self.application(self.environ, start_response)   File "/usr/local/flask/app.py", line 2464, in __call__     return self.wsgi_app(environ, start_response)   File "/usr/local/flask/app.py", line 2450, in wsgi_app     response = self.handle_exception(e)   File "/usr/local/flask/app.py", line 1867, in handle_exception     reraise(exc_type, exc_value, tb)   File "/usr/local/flask/_compat.py", line 39, in reraise     raise value   File "/usr/local/flask/app.py", line 2447, in wsgi_app     response = self.full_dispatch_request()   File "/usr/local/flask/app.py", line 1952, in full_dispatch_request     rv = self.handle_user_exception(e)   File "/usr/local/flask/app.py", line 1821, in handle_user_exception     reraise(exc_type, exc_value, tb)   File "/usr/local/flask/_compat.py", line 39, in reraise     raise value   File "/usr/local/flask/app.py", line 1950, in full_dispatch_request     rv = self.dispatch_request()   File "/usr/local/flask/app.py", line 1936, in dispatch_request     return self.view_functions[rule.endpoint](**req.view_args)   File "/usr/local/flask_login/utils.py", line 272, in decorated_view     return func(*args, **kwargs)   File "/app/backend/__init__.py", line 276, in scrub_page     limit_timestamp = int(request.form.get('limit_date')) ValueError: invalid literal for int() with base 10: '6/14/2021'
Does not matter if I put in a future or past date, same error.
I have success when I input "0" into "Limit delete history including and after date"

@WindedHero try updating :latest once https://github.com/dgtlmoon/changedetection.io/actions/runs/935025090 is finished , thanks for the issue!

Looks great! Small typo "of of" FYI.


Problems with pooled columns.

:b is a pooled column.
this works:
(df[:a] .== 1) & (df[:b] .== "vbvb")
this doesn't worked:
(df[:a] .== "vbvb") & (df[:a] .== 1))
ERROR: MethodError: no method matching DataArrays.DataArray{T,N}(::Array{Bool,1}, ::DataArrays.PooledDataArray{Bool,UInt8,1})
Closest candidates are:
  DataArrays.DataArray{T,N}{T,N}(::Array{T,N}) at /home/am/.julia/v0.5/DataArrays/src/dataarray.jl:75
  DataArrays.DataArray{T,N}{T,N}(::Array{T,N}, ::BitArray{N}) at /home/am/.julia/v0.5/DataArrays/src/dataarray.jl:75
  DataArrays.DataArray{T,N}(::Array{T,N}, ::Array{Bool,N}) at /home/am/.julia/v0.5/DataArrays/src/dataarray.jl:94
  ...
 in &(::DataArrays.PooledDataArray{Bool,UInt8,1}, ::DataArrays.DataArray{Bool,1}) at /home/am/.julia/v0.5/DataArrays/src/operators.jl:496

Thanks for the report. This is an issue with the DataArrays package, not with DataFrames, so you should file an issue there if you want. But note DataFrames will be moving to NullableArrays instead in the next major release, so bugs are not likely to be fixed in DataArrays.


Docker containers respond to ICMP without using host network

Description
After creating a new container in interactive mode. The container is responding to ICMP requests for various ip addresses. These responses still occur when the host has no physical or wireless network connections.
Steps to reproduce the issue:

Start new container with ubuntu:trusty or centos:latest
Run ping <IP_ADDRESS> or any other ip address you know the host is unable to reach
Verify ICMP responses are received and no traffic (wireshark) is transmitted over the host network connection.
alternatively unplug ethernet from the host and disable wireless.

docker run -it ubuntu:trusty bash
Unable to find image 'ubuntu:trusty' locally
trusty: Pulling from library/ubuntu
71a21fdea81d: Pull complete
cf68a3ea6e1d: Pull complete
31cb2a4d344a: Pull complete
0341b6fcb0fe: Pull complete
c8777cc48364: Pull complete
Digest: sha256:93a14ad7bd339597b91d945b097c5a7b249e33bd680159551ac5c96025da7520
Status: Downloaded newer image for ubuntu:trusty
root@6a65cb779e9d:/# ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=37 time=0.221 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=37 time=0.224 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=37 time=0.221 ms
64 bytes from <IP_ADDRESS>: icmp_seq=4 ttl=37 time=0.222 ms
64 bytes from <IP_ADDRESS>: icmp_seq=5 ttl=37 time=0.216 ms
64 bytes from <IP_ADDRESS>: icmp_seq=6 ttl=37 time=0.207 ms
^C
--- <IP_ADDRESS> ping statistics ---
6 packets transmitted, 6 received, 0% packet loss, time 4997ms
rtt min/avg/max/mdev = 0.207/0.218/0.224/0.015 ms
root@6a65cb779e9d:/#

Describe the results you received:
Ping responses are generated when they should not be.
Describe the results you expected:
`Request timeout for icmp_seq x'
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
docker version
Client:
 Version:      1.12.1
 API version:  1.24
 Go version:   go1.7.1
 Git commit:   6f9534c
 Built:        Thu Sep  8 10:31:18 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.12.1
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   23cf638
 Built:        Thu Aug 18 17:52:38 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 2
 Running: 1
 Paused: 0
 Stopped: 1
Images: 2
Server Version: 1.12.1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 14
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge overlay null host
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.20-moby
Operating System: Alpine Linux v3.4
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 1.952 GiB
Name: moby
ID: VPDM:GDSJ:SMX7:NUUV:JK3Z:DCD2:F6BD:4AK7:O4LX:5TMN:TEO3:OWSM
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 22
 Goroutines: 41
 System Time: 2016-09-22T22:01:44.185577026Z
 EventsListeners: 1
No Proxy: *.local, 169.254/16
Registry: https://index.docker.io/v1/
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Mac OS X El Capitan
This has been verified on two different systems.

Also confirmed, this is quite surprising behaviour, any update?

I think this may be specific to Docker for Mac
@foxx were you running on Docker for Mac as well?

@thaJeztah Yup, Docker for Mac
Version 1.12.1 (build: 12133)
2d5b4d9c3daa089e3869e6355a47dd96dbf39856

/cc @justincormack is there an issue tracing this?

Yes, it is tracked here https://github.com/docker/for-mac/issues/57
I am going to close this issue as it is already being tracked (and worked on I believe).


Added vendors (pub dependencies) and fixed OSX support

Forked from https://github.com/dart-lang/rules_dart/pull/16
Fixed:

examples/web_app was failing due to a missing dart:async import in strong mode
both the analyzer and dev_compiler binaries were hardcoded to use the linux binary

Added:

pub_pkg_name (see https://github.com/dart-lang/rules_dart/pull/16)
temporary support for a vendor folder (pub package dependencies for rules_dart)

Love it. Fix in-progress stuff as we go.


gazebo installation error

Hello all, i am trying to install gazebo and am running into this error, can someone please help
px4/simulation/gazebo 7 contains conflicting version recursive dependencies: boost<EMAIL_ADDRESS>I am using a mac

@Sam1215 Could you please let me know how you resolved this?


v1.2.0: break window is very large on macOS

Prerequisites

[X] I'm using latest version: v1.2.0
[X] I've checked Known issues
[X] I've checked Open issues

Description
The window that pops up for a break is very large, covering most, but not all, of the whole screen.  This started happening after I used "brew" to upgrade from v1.1.0 to v1.2.0
Operating system: macOS Catalina 10.15.7
Steps to Reproduce

Upgrade from version 1.1.0 to version 1.1.2 by running "brew update && brew upgrade"
Select "Skip to the next mini-break" using the icon in the menu bar.
Observe that the displayed window is very large.

Expected behavior: [What you expect to happen]
A small window to be displayed.
Actual behavior: [What actually happens]
Reproduces how often: [What percentage of the time does it reproduce?]
100%
Additional Information

I have checked the settings and "Show breaks in: Window" is selected.
I am using a MacBook Pro with an external monitor.   The external monitor is the primary display.
I forgot to quit Stretchly before upgrading.   After upgrading, I continually saw a pop-up complaining about a javascript error (if memory serves).  I needed to kill all the Stretchly processes (using pkill) in order to get rid of the pop-up and cause Stretchly to exit.  Maybe some preferences got scribbled on due to my failure to quit before upgrading or my subsequently killing the processes using the default TERM signal.
I removed version 1.2.0 using "brew cask uninstall Stretchly" and then installed the version 1.1.0 .dmg found at https://github.com/hovancik/stretchly/releases.  That version works as expected, so this seems to be 1.2.0-specific.

Hi, this is new default behavior, Stretchly is covering 85% of screen. You can change the percentage by editing preferences file: https://github.com/hovancik/stretchly#break-window-size-
https://github.com/hovancik/stretchly#advanced-preferences

Just to note: a side effect of this is that Stretchly covers its own status-bar menu, only the top two lines are visible and accessible. Hence, if you want to pause the breaks after one starts (e.g. when watching a film), you have to wait until the ‘next break’ lines disappear—which doesn't happen immediately—and ‘pause breaks’ moves higher.
IMO though, the window shouldn't cover menus in the first place, but dunno yet why that occurs.

@decadent do you mean that opposite of this is happening? (That black thingy is Stretchly's break window)

This is for me on Linux (Debian KDE)

Yeah, this is what it looks like for me. Notably, I've never seen another app that covers the menus.

I guess it's because how we set no top: https://www.electronjs.org/docs/api/browser-window#winsetalwaysontopflag-level-relativelevel
    breakWinLocal.setAlwaysOnTop(true, 'screen-saver')

Different level might work as expected. There was some reason, I think, why screen-saver was used but don't remember now.

Also, while testing this, I realized that transparency doesn't always work, and ‘postpone the break‘ doesn't always appear on the mini-break window. I'm betting on race conditions—probably some flags/actions should be triggered before displaying the window, but are occasionally triggered afterwards. Something in this vein.


Brings back 'module' property and mark as deprecated

We currently have an issue where are schema for azure.yaml references our main branch the removal of this property is causing our issues confusion.
Bring back the property and mark as deprecated for now till we have a better yaml schema versioning strategy.

/checkenforcer override

/check-enforcer override


When Impala editor is not installed, then the importer fails to get t…

…he USER_SCRATCH_DIR_PERMISSION from impala conf.
Jira: CDPD-41666
What changes were proposed in this pull request?
Added a condition to check the editor type before allowing it to enter the if condition
How was this patch tested?
This was tested manually by disabling impala editor to see if Hive importer worked and enabled impala editor to see if importer from impala editor worked.

@agl29 - Can you please take a look?


GitOps setting with local git server is not working

What happened:
I create a local git server, and I'm able to make a clone like git clone git@<server>:/home/git/myproject.git
However, when I use following GitOps setting in the cluster yaml file, and try to create a EKS anywhere cluster on bare metal, I see this error:
Error: connecting with remote origin for repository: ssh: handshake failed: knownhosts: key is unknown
spec:
  ...
  gitOpsRef:
    kind: FluxConfig
    name: my-git-flux-provider
---
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: FluxConfig
metadata:
 name: my-git-flux-provider
spec:
  git:
      repositoryUrl<EMAIL_ADDRESS>      sshKeyAlgorithm: ecdsa

I try to replace the ~/.ssh/known_hosts_eksa content with the rsa public key of user git, and change the sshKeyAlgorithm to "rsa", it shows the same error.
What you expected to happen:
I'm able to create an EKSA cluster with GitOps setting on bare metal successfully.
How to reproduce it (as minimally and precisely as possible):
I mention the steps above.
Anything else we need to know?:
Environment:

EKS Anywhere Release: v0.18.7
EKS Distro Release: 1.28

figured out, it really doesn't match.


fix for php8

To make the CRM work with php8 you need laravel/ui 3.2 and league/glide 1.7.

Have you tested this to make sure the image endpoint actually works? I thought the Glide 2.x branch had a different API (because I wrote it a long time ago 🤣).

tomorrow I'm going to test with php 8

Ah you are right, this endpoint doesn't work. Will check later to fix either the endpoint, or to update your 2.x branch to php8 to get them to work together nicely.


Update crypto lib

Codecov Report

Merging #142 into master will decrease coverage by 1.74%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #142      +/-   ##
=========================================
- Coverage   98.25%   96.5%   -1.75%
=========================================
  Files           9       9
  Lines         229     229
=========================================
- Hits          225     221       -4
- Misses          2       5       +3
- Partials        2       3       +1

Impacted Files
Coverage Δ

pkg/vanity/vanity.go
71.42% <0%> (-28.58%)
:arrow_down:

pkg/keypair/keypair.go
76.92% <0%> (-7.7%)
:arrow_down:

pkg/keypair/address.go
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294ad93...01569b3. Read the comment docs.


Strip Linux binary

Strip Linux binary before packaging, this will remove debug information and make the binary smaller.

Thanks for the PR! I'm not sure why the Windows tests are failing, but I think they're safe to ignore.
How much does this reduce the binary size? Also, are there any drawbacks to doing this? For example, is it possible to get backtraces using RUST_BACKTRACE=1 after stripping?

The size of binary will reduce from 4.1 MiB to 2.3 MiB, after stripping. (test with just-v0.7.1-x86_64-unknown-linux-musl)
The stack backtrace will be useless after stripping the binary, because the debug information is removed.
For a stripped binary, its stack backtrace will be:
thread 'main' panicked at 'test 123', src/main.rs:4:5
stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: __libc_start_main
  12: <unknown>

Should I close this PR?

Thanks for the info!
I could really be persuaded either way.
4mib to 2mib is a great savings, although disk and bandwidth are very cheap these days.
I'm not sure stack traces have ever actually been used to debug release binaries. Just doesn't crash a whole lot, and when it does it tends to be reproducible. So users can provide a justfile and command that trigger the crash, which can then be debugged on a debug build.
I think I'm inclined to leave this open for now in the hope of getting some feedback. I'd also be curious what the best practices of package managers are.

Thanks for the review!!
I will keep this PR open.

I think I'm going to close this. I haven't gotten any feedback on it either way, so I'm inclined to not strip the binary, since in the event of a bug that causes a crash, I'd like to keep backtraces, in case they're helpful to end users. I do appreciate the PR though!


Animation Interop Problem

Which version of the app?
WinUI 3 Gallery
Description
Damping ratio & Period combination problem under the Motion > Animation Interop section

25 ms and 0.8 - 0.6 - 0.4 damping ratio
50 ms and 0.8 damping ratio

and same problem has under the following two section (ExpressionAnimation on an Ellipse element - Driving several related animations...) when period is:

25 ms and 0.8 - 0.6 - 0.4 damping ratio
50 ms and 0.8 damping ratio

You must change damping ratio if you can't see problem when 25 ms - 0.6 damping ratio (once click any damping ratio then click 0.6)

Screenshots
https://user-images.githubusercontent.com/52853427/212882857-340481f1-9f4c-491e-8e4f-fbdc9b989a96.mp4
Windows version
Windows 11 22H2 (22621)
Additional context
No response

Thank you for reporting this bug, I'll close this in favor of #1049 to make tracking this bug easier; PR #1375 will fix this issue.


ci: Fix minimal-versions job

@duesee Can we solve this similar to https://github.com/duesee/imap-codec/pull/615?

I think so, yes.


Issue#2

Added reset button

Make sure when you try to solve an issue ask first in the issue tab and get assigned on the issue.
This will not lead to multiple people working on the same issue.
Thank you for the PR.

Thanks Suraj,
That was the first time I've attempted to solve an issue. I'll be sure to
have myself assigned to an issue before working on it in future.
Cheers,
Rob.
On Sun, 11 Apr 2021, 19:02 Suraj Vishwakarma, @.***>
wrote:

Make sure when you try to solve an issue ask first in the issue tab and
get assigned on the issue.
This will not lead to multiple people working on the same issue.
Thank you for the PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/surajondev/text-to-speech/pull/3#issuecomment-817278003,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBBT6ORJER6IKTDOI6PYCDTIFUCVANCNFSM42XORCUA
.


Make graphviz optional

Makes graphviz an optional dependency.
Fixes #26.
Additions

Helpful error message if graphviz isn't installed and the user tries to plot

Removals

Dependency on graphviz

Testing
Not really sure how to test this.
Surely there is a way to mock existence or non-existence of a package? Cursory googling did not reveal one.
Todos

Test maybe? If we can figure out how

Checklist
I'm not sure I can do all of these things:

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the TODO link to standards
[x] Passes all existing automated tests
[ ] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Python

[ ] python 3.6
[ ] python 3.7

Looks good! Let's add a minor version bump for the library? Even though this technically could be backwards incompatible I think a minor version bump is fine -- its unlikely to break existing workflows. Also I think we can do the same with networkx -- it's only used in the same function.

Did both. Might be worth a helper function!

@ivirshup question, what's your motivation for this? I'm curious what you're trying to avoid.
Otherwise we need to think about the impact to documentation and onboarding; we're going from a single pip install step to multiple. Hence my curiosity as to what prompted the PR :)

what's your motivation for this? I'm curious what you're trying to avoid.

I was thinking about trying this out for computing some statistics on some single cell data (relevant library). Made me wonder whether this could even be a dependency, so I looked this packages dependencies.

Yep -- but did you install hamilton and it didn't work? or you had a dependency conflict in your environment? or?

we're going from a single pip install step to multiple. Hence my curiosity as to what prompted the PR

Oh, I would definitely recommend having a pip install "sf-hamilton[plotting]" option or something. Would also be nice to have these for installing the dev and test requirements.

Yep -- I would perhaps name it sf-hamilton[visualization] but that doesn't seem unreasonable. I guess if we go that route, it's probably worthwhile doing #12 while we're at it? 🤔

Just wondered "could this be a dependency", opened an issue to check, and had this PR solicited https://github.com/stitchfix/hamilton/issues/26#issuecomment-987222812

it's probably worthwhile doing #12 while we're at it

Yeah, I would also highly recommend that. flit +  as much of the pyproject.toml PEPs as possible is quite nice and clean. I've recently done this myself for scanpy and anndata, and it's just so much less janky.
I don't think that I should be the one doing that update though – since it's about reporting author metadata and license.
I could undo the version bump for now?

Just wondered "could this be a dependency", opened an issue to check, and had this PR solicited #26 (comment)

🤦  sorry I missed that. Thanks for clarifying.

Yeah, I would also highly recommend that. flit + as much of the pyproject.toml PEPs as possible is quite nice and clean.
I've recently done this myself for scanpy and anndata, and it's just so much less janky.
I don't think that I should be the one doing that update though – since it's about reporting author metadata and license.

Fair enough 😄 .

I could undo the version bump for now?

Yeah I think removing the version bump would be useful;  we haven't decided on a proper release process just yet. So let us convene internally and then let you know about when we'll merge this PR.

@ivirshup I went ahead and dropped your version bump, and tweaked the logic a little. Thanks for getting this started.
Otherwise @elijahbenizzy I tested the install locally via pip install -e . and pip install -e .[visualization].

@skrawcz looks good to me! Only Q is if we want to wait to release a minor version until we get the transformer/node lifecycle changes out. But I think it's fine to release this, then do my change and release a different minor version.


new.target support

Flow breaks if you give it:
var x = new.target
It tells me that the "." is an unexpected token.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target

TIL. added it to #560 too.

Even get this error even with option: suppress_comment (flow v0.23.0) eg.
// $FlowIssue: https://github.com/facebook/flow/issues/1152
if (new.target === BaseClass) {
  throw TypeError("new of abstract class BaseClass");
}

Is there any update on this one? I am like @rogchap, suppress_comment seems not to work with it.

The following is a parse error 0.38.0:
function a(x = new.target){}

I found no evidence it should be forbidden and both Firefox and Node read it without error.

I'm still getting this problem:
./node_modules/flow-bin/flow-osx-v0.40.0/flow check
src/components/SigmaReactGraph.js:40
 40:     if (new.target === MacroNode) {
             ^^^^^^^^^^ not (sup)ported

I'm still getting this problem:
./node_modules/flow-bin/flow-osx-v0.40.0/flow check
src/components/SigmaReactGraph.js:40
 40:     if (new.target === MacroNode) {
             ^^^^^^^^^^ not (sup)ported

Same. What's the recommended way to do this?


The example test doesn't start execution

Describe the bug
I wanted to try this library out but the provided example test does not start. Please see the repro steps. I suspect the reporter can mess something here. I tried running open via IntelliJ plugin and as npx cli command. Both with the same result.
To Reproduce
Steps to reproduce the behavior:

Add uuv/playwright tp your project
Run npx playwright test --project=chromium -c uuv/playwright.config.ts --ui --reporter=@uuv/playwright/uuv-playwright-reporter
When UI opens click run test
The UI blinks like a reload and test does not run at all

Expected behavior
Test should run
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows10 / macOs
Browser chrome

Additional context
Once I run npx playwright test --project=chromium -c uuv/playwright.config.ts --ui the test started executing.
config
import { defineConfig, devices } from "@playwright/test";

export default defineConfig({
  testDir: ".uuv-features-gen",
  testMatch: ["**/*.spec.ts", "**/*.{ts,js}"],
  fullyParallel: true,
  forbidOnly: !!process.env.CI,
  retries: process.env.CI ? 2 : 0,
  outputDir: "reports/playwright",
  workers: undefined,
  reporter: "@uuv/playwright/uuv-playwright-reporter",
  use: {
    baseURL: "http://localhost:4200",
    trace: "on-first-retry",
    screenshot: "only-on-failure"
  },

  projects: [
    {
      name: 'chromium',
      use: {
        ...devices['Desktop Chrome'],
        channel: 'chrome',
        viewport: { width: 1920, height: 1080 }
      },
    },
  ],

  webServer: {
    command: 'npm run start:ci',
    url: 'http://localhost:4200',
    reuseExistingServer: true,
    timeout: 120 * 1000
  },
});

https://github.com/Orange-OpenSource/uuv/assets/17836911/48004370-f1ef-4b4b-8d39-c3d2dd906f50

Hello Mike,
Thanks for the issue, can't you please can you please give us the following informations please :

@uuv/playwright version
UUV Jetbrains Plugin version
Console logs when the bug occurs
Playwright logs when the bug occurs (See boxed button on the following attachment)

We also recommend that you use the following command to execute the open mode :
npx uuv open

browser console is clear (page didnt load)
CLI console/terminal

@uuv/playwright v2.11.1
UUV Plugin 1.4.1
IJ 2014.1
I will now make sure to bump everything. I thought I did this morning when filing the bug but somehow it stuck to the older ones.

I forgot about your node version too

Playwright Output is interesting, can you please paste all the content here because it's truncated on the capture ?

Thanks, I'm looking into it

I managed to reproduce the bug, I'll fix it.
:-D

I've checked this change from the PR and it appears to be working!
FYI - the upgrades slowed down the time the UI needs to read all the files/generate stuff.

I've checked this change from the PR and it appears to be working! The test started executing. I am just not sure what should be the expected output of that reporter.
FYI - the upgrades slowed down the time the UI needs to read all the files/generate stuff.

In fact this reporter is already set as default from playwright.config.ts file, so even without the reporter parameter this reporter is used and you can look at either the playwright ui output or the npx uuv e2e output

Cool! Huge thanks for such a quick fix!

Cool! Huge thanks for such a quick fix!

You're welcome !
A new release is available with this fix: @uuv/playwright 2.13.1


kn/fix notifications set

Add test to illustrate await-for-yield problem
Add fix to avoid re-subscribe on resume

Fix: #1344

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 21 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 88.794%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
3233

Relevant Lines:
3641

💛  - Coveralls


[improve][client] Optimize Third-Party Client Matrix Page

Third-Party Client Matrix Page: https://pulsar.apache.org/docs/next/client-libraries

Some clients are obsolete, they have not been updated for a long time, should we still show them?

What's the definition of "obsolete client"?
For example, a client was last updated before a certain date or something else?

Can we show the last update time automatically in the third-party client matrix doc as we did in Pulsar README?

Is it better not to include pulsar in the third-party client name to avoid misrepresentation?
For example, the third-party Go client,[pulsar-client-go](https://github.com/Comcast/pulsar-client-go), looks like the official client, while [pulsar-client-go](https://github.com/apache/pulsar-client-go) is the official one.

🔹🔹🔹🔹🔹🔹
Any thoughts or anyone would like to implement? Thank you!
🔹🔹🔹🔹🔹🔹
@BewareMyPower thanks for your suggestions!

Obsolete clients? I think that it will be hard to maintain the date of last commit. Instead we should reevaluate each of the clients periodically to see if there is still value to the overall Apache Pulsar community. We should have simple criteria otherwise the rules would imply the PMC's certification of a client. Certification would then imply we create a test suite. This is a much larger discussion and if we did this then our own official clients would also need to pass.
Regarding naming. We could ask the projects with "pulsar" in their name to rename. When a repository is renamed in GitHub old links and references are redirected. When we ask the project we can also make sure that their README.md points that they are responsible and are unaffiliated with the Apache Pulsar PMC. We should contact each maintainer privately.

I looked at all of the repositories:
ttps://github.com/Comcast/pulsar-client-go - Mar 27, 2019 - It supports Pulsar 2.0 along with 1.22.
https://github.com/t2y/go-pulsar - June 14, 2018 - Some functionality are known to be broken, missing or incomplete. The interface may also change.
https://github.com/cr-org/supernova - Oct 23, 2020 - Alpha, under developement
https://github.com/cr-org/neutron - 5 days ago - use at your own risk
https://github.com/CleverCloud/pulsar4s - Mar 22
https://github.com/streamnative/pulsar-rs - 10 days ago - looks to be very active - it is Apache licensed and MIT liceensed
https://github.com/fsprojects/pulsar-client-dotnet - 25 days ago - very active
https://github.com/ayeo-flex-org/pulsar-flex - 2 hours ago
https://github.com/ikilobyte/pulsar-client-php - 3 days ago
To me we should remove the two go clients plus maybe supernova. We should ask the maintainer because it looks like they chose Scala over Haskell internally.

Actually I have a similar issue posted on the pulsar-site repo https://github.com/apache/pulsar-site/issues/146.

This issue can be closed by https://github.com/apache/pulsar/pull/17010.
For further improvement, I notice that @momo-jun create a draft proposal #17098 which can supersede this one.
@dave2wave @Anonymitaet please help close this issue :)

@tisonkun does it make sense to add last commit time to show client's vitality?

There is an other issue in this field:
[Doc] (before: Add) list of 3rd party pulsar clients -> Make it findable #17113
https://github.com/apache/pulsar/issues/17113#issuecomment-1216517393

@Anonymitaet what if we create a new issue to track this dedicated topic? I don't think it's good we discuss everything about "Optimize Third-Party Client Matrix Page" under this issue without a clear boundary. Open-ended discussions should go to Discussions or mailing lists.
For the proposal itself, I'm glad to review a patch with its preview. But if you ask me to implement it, perhaps I'll try to take it later this month. FYI, there're some predefined "GitHub badges" you can use - search with the keyword.

I'm going to replace the "Star" column with a "Badges" column to show badges including stars and last commit. Will investigate a patch by next week.


Added explore to bottom nav. Added explore label component.

I think the daily task file is edited like that because I hit save on the page and prettier ordered it but nothing is changed on that page.


UpdateIntent overrites old training phrase instead of updating

The updateintent overrites old intents, see my code below.
                                              trainingPhrase.Parts.AddRange(phraseParts);                         intent.TrainingPhrases.Add(trainingPhrase);                         var req = new UpdateIntentRequest();                         req.Intent = intent;                         client.UpdateIntent(req);
@amanda-tarafa

What exactly do you mean by "overwrite" and what do you expect "update" to do instead? Have you looked at the API documentation I linked in the previous issue and confirmed that this is not the expected behavior?
In general my advice would be that you first determine what you want to achieve, then read the API documentation and the client library reference docs to find out how to achieve it, and only then write your code. If the code doesn't behave as expected according to the documentation then we'll be very happy to help and fix whatever might be wrong.

I'll be closing this issue now since we haven't had more info. Please do leave a comment if there was a problem with the client library or the samples.


Logging/sentry strategy

Our logs & error catching needs an overhaul
we have

sentry exceptions
flutter exceptions
uncaught exceptions
logs
print statements

@mike-audi Is there a preferred error handling library to be used for this? Sentry? or thinking custom class to handle multiple channels?

@CraftingGamerTom I've been using this library (https://pub.dev/packages/logging) for logging lately. That way we can just setup a listener at the top level of the app and route the logs to Sentry for production or local console for development or wherever else.

Items 3 and 4 will be handled in #493

Updated App configuration
All errors are routed through Logger. No more automatic Sentry logs.
https://github.com/tiki/app/blob/2fa2b45aff3c15fd286e4eed163919e1534a5ce8/lib/main.dart#L19-L31
Logger decides which messages will be sent to Sentry, user log, or printed in the console.
https://github.com/tiki/app/blob/2fa2b45aff3c15fd286e4eed163919e1534a5ce8/lib/src/config/config_log.dart#L22-L38


Do not output "Trace" level logs from process manager by default

The old process manager's Trace function by default calls log.Printf to output "trace" level logs. That's not ideal because by default the trace level logs should not be outputted. In history it didn't cause problems because there was no other call to the process manager before the logger system's initialization.
But if there is any package using the process manager before the "Trace" function gets assigned to the logger system's trace function, the process manager will outputs unexpected verbose messages, this behavior is not expected in most cases.
Now, the logger system also uses process manager to manage its goroutine contexts, so it's the time to fix the old "trace" behavior: by default, do not output the trace level messages. Fix #24951

3rd CI failure:
#14 643.9 go: downloading git.sr.ht/~mariusor/go-xsd-duration v0.0.0-20220703122237-02e73435a078
#14 644.5 /go/pkg/mod/github.com/go-ap/activitypub@v0.0.0-20230331173947-f5b96d9450d4/encoding_json.go:8:2: unrecognized import path "git.sr.ht/~mariusor/go-xsd-duration": https fetch: Get "https://git.sr.ht/~mariusor/go-xsd-duration?go-get=1": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-05-27T05:12:24Z is after 2023-05-27T00:00:06Z
#14 644.5 make: *** [Makefile:820: gitea] Error 1


docs(rfc): Improve Time & Flow of the core Job Deployment & other areas

RFC to improve the time taken to do:

Job deployment
Job creation
Job deletion
Replay
Backup

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.86%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5143

Relevant Lines:
7157

💛  - Coveralls

I see we are trying to cache the upstream job dependency in db at optimus level instead of plugin level(bq2bq does in-memory cache at the moment) but one problem with this approach that I see is upstream dependencies can change without even modifying the job. For example in case bq2bq, if your query uses a view, that view could have been updated externally which indirectly updated this job's upstream tables. So unless we invalidate the job hash in optimus db, optimus will remain oblivious to this change.

@kushsharma @sravankorumilli how about Optimus provides the ability to do dependency resolution for all jobs in a project? It can be a separate command, that can be run before the job deployment, on-demand, or can be called in deploy --all. Or we can also make it a flag.

If it is outside of Optimus then, it is not suggested but as @arinda-arif mentioned we can have a mechanism of refresh all jobs, which computes the dependencies & priorities of all jobs, either it can be automated in the pipeline or it can be used by admins for fixing any errors.
For the resources being managed within Optimus, it is fair point to automatically infer the dependencies, so we need to have a relationship b/w resources & jobs, through which we can do the dependency resolution for the jobs for which these views are the sources, it is just that we need to keep the design clean with this change.

Summary of discussion

Deployment process will not be failed when there is a failing dependency resolution. We will fetch the existing job dependency from the table and proceed with the deployment. The list of failing jobs will be shown in the response. There will be metrics added and alert.
Sources and destination will be computed and stored before doing the dependency resolution (when saving the job). The source and destination will be already stored regardless of whether the dependency resolution and compilation succeed or not. It will not be a problem if any issue is happening in some job. Jobs and resources already integrated through these 2 fields.
Check and remove caching in transformers, to avoid giving wrong dependencies
Ability to deploy multiple namespaces in 1 request. This is helpful to do clean deployment per project and avoid stale dependencies when doing it 1 by 1.

As discussed, this is the expected behavior of jobs and resources. This behavior is the guideline on what to build and improve.
Job Creation / Modification

Sources & Destination Resource Urns to be identified & persisted
Dependency resolution for the current job & the jobs which have source as the new jobs destination.
Priority Resolution for all jobs
Compilation & deployment for all jobs
Whether we support multiple jobs writing to a single destination or not? - Validation to not support this.

Job Deletion

Identify any dependent jobs & delete only if there are no dependencies.
Soft Delete can be avoided & rather store in a separate table for audit as it avoids reusing the names (TBD)
No Need for Priority Resolution or compilation, but we have deleted it from the scheduler storage.

Refresh all Jobs at namespace or at project level (Deploy)

Diff of modified/created/deleted jobs at the namespace level
Compute sources & destination & persist in DB
Dependency Resolution & Persist
PriorityResolution, Compilation & Deployment only once.

Clean Refresh all jobs (Clean Deploy)

Identify deleted Jobs
We do the rest all steps for all(dependency resolution, priority resolution, deployment)
Side effect the plugins will be upgraded.

Upgrade Jobs at namespace, project (upgrading plugins)

Can use Clean Refresh

Resource Creation

On Resource Creation it doesn’t affect any dependencies, rather we can check if any job can be created without resource being available as an optional validation to avoid missing resource creation.

Refresh all Resources at namespace or at project level.

Diff of modified/created/deleted resources at the namespace level
Dependency Resolution
Priority Resolution & Job Deployment

Clean Refresh all resources

Consider all resources as new/modified we just update all resources.
Dependency Resolution, Priority Resolution & Deployment for all.

Optimus job deploy –namespace –project –clean
Will do clean refresh all jobs
Optimus resource deploy –namespace –project –clean –resources=(resource1, resourc_2)
Will do deployment only for specific resources
Optimus job deploy –namespace –project –jobs=(job_name1,job_name2)
Will do deployment only for specific jobs
Optimus job/resource  delete/upgrade –job-names
Will delete or upgrade jobs.