[Bug] Entity mapping for parent/children hierarchy does not work if entities are deleted first

I found a bug with mapping references to entity ids. If you delete the entities in your world before loading, then re-load, the world will contain invalid entity IDs where there was an entity pointer. It happens with Parent components and custom components with an Entity property implementing MapEntities.
After loading the new Parent component points to a non-existent entity.
I've included an example to reproduce below.
What else I have tried
When it first happend with Parent/Children, I tried implementing MapEntities in a component to hold the relationship instead. The same issue occurred, after loading it held an invalid ID.
I noticed that my component's map_entities function was never called. I put a println in it's map_entities and never saw it in the console.
EDIT: with MappingMode::Strict, the below example crashes after load from a heirarchy assertion in bevy.
What I want to try next, but haven't tried yet
Next, I'll try to debug print the EntityMap so I can see what entities it contains after loading, as well as the code that calls the ReflectMapEntities functions to see what's happening.
What else I considered
moonshine_save uses a custom resource to expose the entity id mappings after load, and components can implement a FromLoaded to set their ID's after load.
I'm not too sure about how MapEntities works, but if I couldn't get it working I was considering implementing a similar thing here.
Example
Modified examples/main.rs, where I spawn a child entity with a Head component on the player.
To reproduce: Hit ENTER to save, then R to delete all players, then BACKSPACE to load. Hit P to print debug info about all heads, and it'll show that the head's Parent entity does not exist. It will still point to the original parent ID from before you deleted them.
use bevy::prelude::*;
use bevy_inspector_egui::quick::WorldInspectorPlugin;
use bevy_save::prelude::*;

#[derive(Component, Reflect, Default)]
#[reflect(Component)]
pub struct Player;

#[derive(Component, Reflect, Default)]
#[reflect(Component)]
pub struct Head;

fn setup(mut commands: Commands) {
    commands
        .spawn((SpatialBundle::default(), Player))
        .with_children(|p| {
            p.spawn(Head);
        });

    // to reproduce the error, hit the following keys:
    // P         - Print debug info about heads and check their parent exists
    // ENTER     - Save
    // R         - Reset, delete all player entities
    // BACKSPACE - Load
    // P         - Print head info <== head will have an invalid parent
    println!("Controls:");
    println!("P: to print debug info on `Head` entities and to validate their parent exists");
    println!("R: to recursively delete all `Player` entities");
    println!("ENTER: Save");
    println!("BACKSPACE: Load");
}

fn interact(world: &mut World) {
    let keys = world.resource::<Input<KeyCode>>();

    if keys.just_released(KeyCode::Return) {
        info!("Save");
        world.save("example").expect("Failed to save");
    } else if keys.just_released(KeyCode::Back) {
        info!("Load");
        world.load("example").expect("Failed to load");
    } else if keys.just_pressed(KeyCode::E) {
        info!("Info");
        for entity in world.iter_entities() {
            info!("Entity: {:?}", entity.id());
            for component_id in entity.archetype().components() {
                if let Some(component) = world.components().get_info(component_id) {
                    info!("  {:?}: {:?}", entity.id(), component.name());
                }
            }
        }
    }
}

fn handle_keys(
    keys: Res<Input<KeyCode>>,
    head_query: Query<(Entity, &Parent)>,
    despawn_query: Query<Entity, With<Player>>,
    mut commands: Commands,
) {
    // Print head debug info, check that all heads have a valid parent
    if keys.just_released(KeyCode::P) {
        println!("{} Heads", head_query.iter().len());
        for (entity, parent) in &head_query {
            println!("  Head {:?} has parent: {:?}", entity, parent.get());
            if commands.get_entity(parent.get()).is_none() {
                println!("    X - Head parent does not exist!");
            } else {
                println!("    Ok - Head parent exists, all good")
            }
        }
    }

    // Reset, delete all entities
    if keys.just_released(KeyCode::R) {
        for entity in &despawn_query {
            commands.entity(entity).despawn_recursive();
        }
    }
}

fn main() {
    App::new()
        .add_plugins(DefaultPlugins.build().set(AssetPlugin {
            asset_folder: "examples/assets".to_owned(),
            ..default()
        }))
        // Inspector
        .add_plugin(WorldInspectorPlugin::new())
        // Bevy Save
        .add_plugins(SavePlugins)
        // Uncomment this and the app will crash after load, due to a `bevy` assertion on the parent/child heirarchy
        // .insert_resource(AppMappingMode::new(MappingMode::Strict))
        .register_saveable::<Player>()
        .register_saveable::<Parent>()
        .register_saveable::<Head>()
        .register_saveable::<Children>()
        .register_type::<Head>()
        .register_type::<Player>()
        .add_startup_system(setup)
        .add_system(interact)
        .add_system(handle_keys)
        .run();
}

How I've been using bevy_save
Not relevant to the issue, but I've been using bevy_save in a level editor for Undo + Redo behavior -- the rolbacks are a really great feature.

Unfortunately, this is not an easy problem to solve and will require breaking changes to the save format.
In the mean time, it is possible to work around by ditching World::load when working with any components that contain entities and providing anEntityMap to Applier<Snapshot> manually.

Thanks for the reply!
I had trouble applying an EntityMap manually, but I made a fork and fixed it for myself there.
The changes I made would be breaking, I changed SaveableEntity to support the full entity ID, changed how the EntityMap is filled and applied and also called set_parent on all loaded entities that had a Parent.
You can have a look at the changes here if you want.
Children was a problem and still doesn't work -- I ended up excluding it from my saves. It may contain entities that weren't included in the save (because of despawning and filtering) and filtering a Children was harder than I thought. Parent always worked because it was a single relationship, so I stuck with that.

Looks great. More or less exactly what I would have done. I will put together a PR and get this merged.
Though I am curious why you need to call set_parent here - does that populate Children for you?

Looks great. More or less exactly what I would have done. I will put together a PR and get this merged.

Thanks! I wasn't certain about the other contexts bevy_save is used in, such as the third-party crate support, and I've only tested it for real in scenarios where I despawn components first.

Though I am curious why you need to call set_parent here - does that populate Children for you?

Yes, that was my workaround for not including Children in the save.
If you don't call set_parent, bevy complains about broken hierarchies. It may only happen when GlobalTransforms are involved, I can't remember for sure, so it may be worth adding transforms to the hierarchy example.


Use PyPi version of sphinx-material

sphinx-material has a release on PyPi now, no need to install it from the repo anymore.

I guess they just forgot to change it.
Btw. the tests fail since the package is python>=3. 6, and it can't be installed from PyPi for lower versions. But that would be a problem user need to take care themselves anyway. Since the code might break in other cases, i.e. if the theme code uses formatted-strings. So the failing should be rated as intended.
Maybe mention it in the docs for building themes?


  I wanted to submit it as a PR to your fork so you can take a look at the diff.  If you diff this branch to the current master of vinyl-fs, it is actually really clean.  Your changes were overall pretty great but I couldn't follow the callbacks being passed around everywhere.  I had refactored stuff so the stat call was still in the written callback but then I figured out why you were passing the callbacks around (to handle the outstream.end case).  Since streams handle all this stuff we are trying to do rather nicely, I just left them up their own devices and created a closeFd method that is used in writeBuffer and writeDir.  I want to refactor the stat method, as it is just a cut-paste of your implementation into a module and add a ton more tests, but I figured I'd send the bulk of it to you now.  Feedback is greatly appreciated.

I bet this looks clean against master, most new code is in fresh modules now :-) But as these helpers are exclusively used by lib/writeContents/*, would they not better live in there as well?
A subjective matter, of course, but I found the original back-and-forth between index and writeXXX, with appropriate comments in place, slightly less confusing then have a third level of modules.
More importantly though this looks to me like it does the same thing, so if you're much happier with this structure, great.
Are the changes in test/dest.js and test/symlink.js related to this metadata work?

@erikkemperman
Module location: I was planning to reorganize the structure after I sent you this, I just didn't want to mess with the diff prior to sending it your way.
Test changes: no, they were just completely broken when i turned on some other eslint options (no-undef) and weren't testing what they were supposed to (so those features don't actually exist and are breaking changes).

@phated All right, I'm going to have to call it a night -- one more thing I noticed, it is now no longer obvious that the symlink case is not handled yet. I had a TODO somewhere, I think?
And having read the flow in execution order again, for both branches, the original structure strikes me as slightly less fragmented lexicographically -- if that makes any sense -- but of course I spent more time looking at that structure earlier :-P
Maybe @piranna could weigh in?

I'll also add @contra

Ref https://github.com/gulpjs/vinyl-fs/pull/151 for clean diff against master

@phated Just to double check, you made this PR to my branch for communication purposes only, right? Or should I merge it at some point?

No need to merge it. I'll be rebasing the branch while adding tests and stuff and then I can merge my PR to master. Just wanted to show the diff with yours.

All right, thought so but wanted to be sure.

Metadata stuff finally resolved, closing this!


WIP - feat: allow import of eth derivation path wallets

Description
Allows imports of wallets that use an Ethereum derivation path and 12 or 24 word wallets.
TODO

[ ] Passing the derivation path to getStoredPrivateKey in src/web3/KeychainSigner.ts.
[ ] ImportWallet.tsx styling and text changes.

Screenshot iOS

Other changes
Added a selector button on ImportWallet.tsx to choose to import from an eth derivation wallet or not.
Tested
Tested locally on iOS.
How others should test
Attempt to import a wallet created with Valora.
Attempt to import a wallet created with MetaMask.
Related issues

RET-283

Backwards compatibility
TBD

Closing as this was just a proof of concept.


Metadata Plugin

Summary
Here's some metadata plugin that allows kong to modify Headers and Querystring based on two source of metadata, the persistent ones in database / redis and the ones in the transitory store.
Transitory store could allow other plugins to prepare metadata on the fly when kong receive a Request. (View Tieske suggestion here https://github.com/Mashape/kong/issues/550)
One of the test cover the use case by feeding the transitory store with fixtures.
I've added a debug.lua library for my POC, I should probably remove it if the pull request ever gets approved.
Also I believe my request_headers_factory and request_querystring_factory could be use in the request-transformer plugin, so it might be wise to move in /kong/tools or something like that ?
Comments are welcome, i've never done Lua / OpenResty before.
Full changelog

Implement metadata-insertion plugin

Issues resolved
Fix https://github.com/Mashape/kong/issues/550

@thefosk  @Tieske  @thibaultcha  Does it make any sense to you guys ?

The git history seems wrong. Mind fixing that up before we start a review? On a side note, I am quite unsure how I feel about such a plugin. I do understand the promise, but am clearly questioning if the approach as a plugin is the best one.

Also: thank you for taking interest in this and your contribution ;)

Not sure how the history got mixed up, probably because I started my brand over master, I'll try a rebase (oh god I hate rebase xD)

Yah, you should base your work on top of next instead. Good to know for next time (unless you are writing a hotfix).

Is there a reason why the previous commits over master have not been moved on top of next already ?

Is there a reason why the previous commits over master have not been moved on top of next already ?

Because someone probably did not follow the proper git flow when merging things to master. I shall update it in a bit.

Ok so I'll wait then, because I think it will fix my git history, (if the new commits on master are already in the next branch, they will disappear from the changed files in my pull request)

I just merged master in next but it appears your history is still conflicting. I would suggest a rebase.

See the new pull request here, https://github.com/Mashape/kong/pull/1962
Rebase is such a pain sometimes.


Edge 530: Configuration for Varia 511 can't be saved on Garmin Express

Today I discovered your Smart Bike Lights app and installed it on my Edge 530, which I have been using for years with my Varia 511.
First, I set Light Beam Activated to Timer Start as described in your instructions.
Then I tried these three configurations (where I have reduced/deleted more and more settings):
1,1!AUTO:1I[300]0###0,4096::1#2,2!BRAKE:1:4:0:0A[-20!:1:0:0:0D=1##2:Varia 511!OFF:0!ON:4#0::#0:1#0#0#B3121##7#0#0
1,1!AUTO:1I[300]0###0,4096::1#1,1!:1:0:0:0D=1##2:Varia 511!Off:0!Solid:4#0::#0:1#0#0#B3121##7#0#0
###0,4096::1#1,1!:1:0:0:0D=1##2:Varia 511!Off:0!Solid:4#0::#0:1#0#0#B3121##7#0#0
But none of them could be saved in Garmin Express, see GIF below:

Do you have any idea why this might be the case and what else I could try?
Thanks in advance for your answer and your great tool!

It seems like that something broke with the latest Garmin Express as I have the same issue as you. Unfortunately, I cannot do anything about that. Try to use Garmin mobile app to change the settings until Garmin fixes the issue.


Workflows have not run in 4 months

Hi all,
the workflows haven't run in 4 months because there was no activity in this repo over the past 60 days.
Could you enable them again? 🙏🏻

On it - thanks @filippo82

(BTW best to at-mention me when you see an issue, so I get notified)

You are welcome Jeremy! I will do that (add an at-mention) next time. I wish you a great weekend.


Stop kernel by ctrl+C but occur the'concurrent.futures._base.TimeoutError'and 'ensure_async(self._kill_kernel(restart=restart))'

Description
What steps will reproduce the problem?

I used the ctrl+c to stop the kernel execution but these errors occurred. How to solve that? python:3.6.13, tendorflow-gpu2.6.0,gpu:rtx4070 laptop, win11, spyder5.0.5. I also wrote 'import tensorflow.compat.v1' and 'compat.v1.disable_eager_execution' but no 'disable_v2_behavior'.
Thanks!
Traceback
Traceback (most recent call last):
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\manager.py", line 425, in _async_finish_shutdown
    self._async_wait(pollinterval=pollinterval), timeout=waittime / 2
  File "D:\anaconda3\envs\tf2\lib\asyncio\tasks.py", line 362, in wait_for
    raise futures.TimeoutError()
concurrent.futures._base.TimeoutError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\utils.py", line 26, in wrapped
    raise e
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\utils.py", line 23, in wrapped
    return loop.run_until_complete(future)
  File "D:\anaconda3\envs\tf2\lib\site-packages\nest_asyncio.py", line 70, in run_until_complete
    return f.result()
  File "D:\anaconda3\envs\tf2\lib\asyncio\tasks.py", line 180, in _step
    result = coro.send(None)
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\manager.py", line 79, in wrapper
    raise e
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\manager.py", line 71, in wrapper
    out = await method(self, *args, **kwargs)
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\manager.py", line 488, in _async_shutdown_kernel
    await ensure_async(self.finish_shutdown(restart=restart))
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\utils.py", line 26, in wrapped
    raise e
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\utils.py", line 23, in wrapped
    return loop.run_until_complete(future)
  File "D:\anaconda3\envs\tf2\lib\site-packages\nest_asyncio.py", line 70, in run_until_complete
    return f.result()
  File "D:\anaconda3\envs\tf2\lib\asyncio\tasks.py", line 180, in _step
    result = coro.send(None)
  File "D:\anaconda3\envs\tf2\lib\site-packages\jupyter_client\manager.py", line 430, in _async_finish_shutdown
    await ensure_async(self._kill_kernel(restart=restart))
TypeError: _kill_kernel() got an unexpected keyword argument 'restart'

Versions

Spyder version: 5.0.5
Python version: 3.6.13
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Windows 10

Dependencies

# Mandatory:
atomicwrites >=1.2.0          :  1.4.0 (OK)
chardet >=2.0.0               :  4.0.0 (OK)
cloudpickle >=0.5.0           :  2.0.0 (OK)
cookiecutter >=1.6.0          :  1.7.3 (OK)
diff_match_patch >=20181111   :  20200713 (OK)
intervaltree >=3.0.2          :  3.1.0 (OK)
IPython >=7.6.0               :  7.16.1 (OK)
jedi =0.17.2                  :  0.17.2 (OK)
jsonschema >=3.2.0            :  3.2.0 (OK)
keyring >=17.0.0              :  23.1.0 (OK)
nbconvert >=4.0               :  6.0.7 (OK)
numpydoc >=0.6.0              :  1.1.0 (OK)
paramiko >=2.4.0              :  2.8.1 (OK)
parso =0.7.0                  :  0.7.0 (OK)
pexpect >=4.4.0               :  4.8.0 (OK)
pickleshare >=0.4             :  0.7.5 (OK)
psutil >=5.3                  :  5.8.0 (OK)
pygments >=2.0                :  2.11.2 (OK)
pylint >=1.0                  :  2.9.6 (OK)
pyls >=0.36.2;<1.0.0          :  0.36.2 (OK)
pyls_black >=0.4.6            :  0.4.6 (OK)
pyls_spyder >=0.3.2;<0.4.0    :  0.3.2 (OK)
qdarkstyle =3.0.2             :  3.0.2 (OK)
qstylizer >=0.1.10            :  0.1.10 (OK)
qtawesome >=1.0.2             :  1.0.3 (OK)
qtconsole >=5.1.0             :  5.1.1 (OK)
qtpy >=1.5.0                  :  2.0.1 (OK)
rtree >=0.9.7                 :  0.9.7 (OK)
setuptools >=39.0.0           :  58.0.4 (OK)
sphinx >=0.6.6                :  4.4.0 (OK)
spyder_kernels >=2.0.4;<2.1.0 :  2.0.5 (OK)
textdistance >=4.2.0          :  4.2.1 (OK)
three_merge >=0.1.1           :  0.1.1 (OK)
watchdog >=0.10.3             :  2.1.3 (OK)
zmq >=17                      :  22.2.1 (OK)

# Optional:
cython >=0.21                 :  None (NOK)
matplotlib >=2.0.0            :  3.2.2 (OK)
numpy >=1.7                   :  1.19.2 (OK)
pandas >=1.1.1                :  None (NOK)
scipy >=0.17.0                :  1.5.2 (OK)
sympy >=0.7.3                 :  None (NOK)

Hi @Junda-Wong thank you for the feedback! This seems like a duplicate of https://github.com/spyder-ide/spyder/issues/16762 You will need to update Spyder to be >= 5.2.0 or downgrade to jupyter_client 6
Let us know if the info above helps!

Thanks.But the Spyder >=5.2 requests the python version>=3.8, but mine is 3.6. I need to use the pip/conda to install a higher version Spyder mandatorily?

I also found another problem today. The console had no response  when I clicked the restart kernel, if I needed to end up the current task. Sometimes, variable would remain even I click the 'clear variable' button.

Hi @Junda-Wong thank you for the feedback! This seems like a duplicate of #16762 You will need to update Spyder to be >= 5.2.0 or downgrade to jupyter_client 6
Let us know if the info above helps!

I just modified the jc to 6.1.7. Because the aforementioned problem is accidental, I need to use for a period of time and give feedback. And, could I invite you to give me some ideas on above restart kernel problem? Thanks! XD

I just modified the jc to 6.1.7. Because the aforementioned problem is accidental, I need to use for a period of time and give feedback. And, could I invite you to give me some ideas on above restart kernel problem? Thanks! XD

Awesome, glad to hear that you were able to workaround the problem by downgrading jupyter_client! Regarding the restart not totally sure but maybe it could also be an issue that was solved in a more recent release. If you have any more info let us know!

@dalthviz After I degraded the jc, I have not met that error again. BUT the problem 'restart kernel no response' still remains. It will occurs possibly after running a tensorflow .py file or half-stopping. The results are: restart kernel no response, no error report either. But restart kernel will success if I don't run the .py file, or specifically, don't run with tensorflow. I guess there's some conflicts of versions of tensorflow-gpu and spyder also jc. Now my solution is: to open a new console when I meet above issue.

Oh I see thank you for the info @Junda-Wong :+1: I think there is not much we can do or suggest but maybe running Spyder on debug mode could give more info. To run Spyder in debug mode you can run it with the --debug-info verbose flag

Closing due to lack of response


User-reported unhelpful error message

Program: https://code.world/#P5MemhCMUH8Ay1U_p24kDkQ
Message:
program.hs:1:39-45: error:
    • Couldn't match type Number with (Number, Number)
      Expected type: Number -> Picture
        Actual type: (Number, Number) -> Picture

This student is missing a fundamental idea, that the state is always the same type.  It's not clear that an error message could have helped them.  I'm going to close this.


Explorer Tree View section doesn't disappear if EH dies

testing #33300 on macOS:

debug some code and open loaded scripts explorer
kill EH from outside and restart EH

Observe:
Loaded Scripts explorer tree disappears but the viewer header stays:

@weinand As discussed, this is expected. Because view is still registered and given the current context view is visible. Data of the view was gone as the extension host died.

@alexandrudima what do you think is the correct behaviour in this case?

I don't have a strong opinion either way. For example, grammar contributions survive, even if the extension host is dead. But grammar contributions don't need a running extension host...
I think various paths can be taken:

Render a placeholder. When the extension host is starting up, it can read "Loading...". When the extension host is crashed, it can read "Not available at this time..." or "Error..." etc.
Don't render anything (also not the header)

I agree the path it takes today (where only the header is rendered, and the content is empty) is a bit ... unfriendly.


C++ string parameter instance duplicates

Brief Description
The C# generated output from a virtual method that takes two strings (or three) as parameters generates duplicate names for string instances.
C++ input: https://pastebin.com/HrBkVT87
Generated C# output: https://pastebin.com/4CyMcfag
Errors:
Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0128	A local variable or function named '__basicStringRet' is already defined in this scope	TestSharp	C:\Users\mattp\Documents\Flounder Workspace\TestSharp\TestSharp\Test.cs	110	Active

OS: Windows
Target: MSVC
Driver: https://pastebin.com/vAWeTgua

Thanks for the bug report.
The issue is in this code:
https://github.com/mono/CppSharp/blob/695a7538d11db4fe7fef6c1f1d77dd0284267ce7/src/Generator/Types/Std/Stdlib.cs#L101
https://github.com/mono/CppSharp/blob/695a7538d11db4fe7fef6c1f1d77dd0284267ce7/src/Generator/Types/Std/Stdlib.cs#L112
I think this just needs to be changed to something like this:
const string varBasicString = $"__basicStringRet{ctx.ParameterIndex}";

Do you want to try sending a PR fixing this issue?


InteractiveBrokers MapSymbol Option And Future Failure

Expected Behavior

IB can map option symbols correctly

Actual Behavior

During the algorithm initialization, the following exception has occurred: Error connecting to brokerage: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for SPY JUN2021 345 P [SPY 210618P00345000 100]; Contract description: OPT SPY JUN2021 345 P [SPY 210618P00345000 100] USD 0 0 0. This may be caused by incorrect login credentials or an unsupported account type.InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for SPY JUN2021 345 P [SPY 210618P00345000 100]; Contract description: OPT SPY JUN2021 345 P [SPY 210618P00345000 100] USD 0 0 0 InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for SPY JUN2021 345 P [SPY 210618P00345000 100]; Contract description: OPT SPY JUN2021 345 P [SPY 210618P00345000 100] USD 0 0 0 String was not recognized as a valid DateTime.

Potential Solution

Reproduce & fix issue

Reproducing the Problem

Believe there are 3 paths for a call to MapSymbol(): calling LookupSymbols(), have an open order or position in the security
System Information

N/A
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

Reopening this issue since we have a new unhandled case with FUT VIX      MAR2021 (VX) USD   0 0 0
2021-01-19T23:46:25.6738770Z ERROR:: InteractiveBrokersBrokerage.Connect():  System.Exception: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for VIX      MAR2021 (VX); Contract description: FUT VIX      MAR2021 (VX) USD   0 0 0 ---> System.Exception: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for VIX      MAR2021 (VX); Contract description: FUT VIX      MAR2021 (VX) USD   0 0 0 ---> System.FormatException: String was not recognized as a valid DateTime.

Reopening this issue since we have a new unhandled case with FUT VIX      MAR2021 (VX) USD   0 0 0
2021-01-19T23:46:25.6738770Z ERROR:: InteractiveBrokersBrokerage.Connect():  System.Exception: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for VIX      MAR2021 (VX); Contract description: FUT VIX      MAR2021 (VX) USD   0 0 0 ---> System.Exception: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for VIX      MAR2021 (VX); Contract description: FUT VIX      MAR2021 (VX) USD   0 0 0 ---> System.FormatException: String was not recognized as a valid DateTime.

Reopening this issue since we have a new unhandled case with FUT VIX MAR2021 (VX) USD 0 0 0
2021-01-19T23:46:25.6738770Z ERROR:: InteractiveBrokersBrokerage.Connect():  System.Exception: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for VIX      MAR2021 (VX); Contract description: FUT VIX      MAR2021 (VX) USD   0 0 0 ---> System.Exception: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for VIX      MAR2021 (VX); Contract description: FUT VIX      MAR2021 (VX) USD   0 0 0 ---> System.FormatException: String was not recognized as a valid DateTime.

Unhandled case is passing in latest Lean master. User launched their algorithm (2021-01-04) before the Futures fix made it into master (2021-01-06).

Reopening this issue since we have a new unhandled case with FUT VIX MAR2021 (VX) USD 0 0 0
2021-01-19T23:46:25.6738770Z ERROR:: InteractiveBrokersBrokerage.Connect():  System.Exception: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for VIX      MAR2021 (VX); Contract description: FUT VIX      MAR2021 (VX) USD   0 0 0 ---> System.Exception: InteractiveBrokersBrokerage.MapSymbol(): Failed to convert contract for VIX      MAR2021 (VX); Contract description: FUT VIX      MAR2021 (VX) USD   0 0 0 ---> System.FormatException: String was not recognized as a valid DateTime.

Unhandled case is passing in latest Lean master. User launched their algorithm (2021-01-04) before the Futures fix made it into master (2021-01-06).


Unable to click on content menu item when it's overlapping with the top bar.

Description
I found that it's not possible to click on content menu item when it's overlapping with the top bar.
In both full extended, and not-extended mode.
Steps To Reproduce

Go to any folder
Right click to open content-menu
Select a sub-menu where it contains a decent number of items.
If the sub-menu's length of height is long enough, it should overlap with the top bar.
Try click on the item that is overlapped with the top bar, it should be unclickable.

Requirements
The content-menu (or sub-content-menu) item that overlapped with the top bar should be clickable.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.2134
Log File
I don't think you'll find anything that's related to my issue in the log, since it does not cause any crash nor issue, just a little trouble in my opinion.
Anyways, here's the log you might not need :)
debug.log

Just to add to what Josh already shared, you can download the preview version from our website https://files.community/download.


FireMonkey UserCSS version

Since a FireMonkey user has brought it up  (https://github.com/erosman/support/issues/252) and it is a minor adjustment, you may consider including a FireMonkey UserCSS version for potential users.
FireMonkey UserCSS uses the exact metadata block format as GM UserScript.
A UserCSS version is posted in above topic for reference.

I recommend that FireMonkey users just install the UserScript version since the UserScript version is going to support Goolge Image Search (see #25).

There is no difference in FireMonkey between UserScript & UserCSS version of "google-search-sidebar". If "google-search-sidebar.user.js" had any other function other than injecting CSS, then that would be right. The CSS will affect dynamically generate content the same way.
Please note the FireMonkey UserCSS is not the same as Stylish UserStyle.
google-search-sidebar.user.js
GM_addStyle(css);
FireMonkey UserCSS
injects the same css
Anyway, it was only a suggestion.

This issue was closed because it has been stalled for a long time with no activity. Feel free to reopen this issue if you have further questions or suggestions.


Work item linking samples throws errors

WorkItemsSample.CreateAndLinkToWorkItem throws an exception that "linking to a work item requires the full URL".
WorkItemsSample.LinkToOtherWorkItem throws an exception that "a work item cannot be linked to itself".
That means neither of these samples is actually successful at showing how the APIs work.

Resolved


"Error: Maximum call stack size exceeded in execute function"

Bug description
The code is causing a maximum call stack size exceeded error.
How to reproduce

Load the code that contains the execute function.
Call the execute function passing an array of SnippetArrayItem and thisArg as parameters.
The code will get stuck in an infinite loop, eventually throwing the RangeError: Maximum call stack size exceeded error.

Related sub-libraries

[ ] All of them
[x] posthog-web
[ ] posthog-node
[ ] posthog-react-native

Additional context
The error is occurring in the execute function, which contains a loop that calls itself recursively. This is causing the stack to fill up until it reaches the maximum size allowed by the browser, resulting in the error.
Thank you for your bug report – we love squashing them!

With the current amount of context there isn't much we can advise here. If you can provide more context and code snippets then feel free to re-open.


docs(button): update button docs

Minor: update button docs

add type="submit" to submit button
follow consistent patterns for usage examples
make Rough DOM composition readable

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Performance issue when calling Keras conv2D / gen_nn_ops.conv2d with different sizes

System information

Have I written custom code (as opposed to using a stock example script
provided in TensorFlow):
yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Linux Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue
NA
happens on a mobile device:
NA
TensorFlow installed from (source or binary):  binary wheel via PyPI
TensorFlow version (use command below):
v2.1.0-rc2-17-ge5bf8de 2.1.0;
v2.2.0-0-g2b96f3662b 2.2.0
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
CUDA 10.0
GPU model and memory:
V100 32 GB

Describe the problem
I'm suspecting time performance issue when running a model with different input sizes.
the first time of running a model produce tracing, but I created a model with tf.function with tensor spec and yet when changing the input size (even by 1) the performance decreases a lot.
the model is build with keras layer conv2d.
when running the low level tensorflow API gen_nn_ops.conv2d received the same decrease of performance.
Describe the expected behavior
the timing performance shouldn't decrease after the 1st time of calling the model with different size.
Keras code:
import tensorflow as tf
import numpy as np
from time import perf_counter
from tensorflow.keras.layers import Conv2D

filters = 8
kernel_size = (3, 3)
inp_shape = (15, 15, filters)

layers = [Conv2D(filters=filters, kernel_size=kernel_size, input_shape=inp_shape)]
layers += [Conv2D(filters=filters, kernel_size=kernel_size) for _ in range(4)]
model = tf.keras.Sequential(layers=layers)

@tf.function(input_signature=[tf.TensorSpec([None, 15, 15, 8])])
def tf_func(inp):
    print('graph tracing')
    return model(inp)

def prepare_inp(n):
    return np.random.rand(n, *inp_shape).astype("float32")

out = tf_func(prepare_inp(1)).numpy() # first call - very slow
N = 30000
for n in range(N, N+6):
    inp = prepare_inp(n)
    elapsed = []
    for _ in range(5):
        _start = perf_counter()
        out = tf_func(inp).numpy()
        elapsed.append(perf_counter() - _start)
    print(f'[{n:,} samples] running time (msec): ' + ' '.join(f'{1000*e:6.1f}' for e in elapsed))

"""
Output:
graph tracing
[30,000 samples] running time (msec):  466.6   77.4   63.0   63.5   77.9
[30,001 samples] running time (msec):  389.0   64.0   49.6   38.8   63.4

Expected something like:
graph tracing
[30,000 samples] running time (msec):  466.6   77.4   63.0   63.5   77.9
[30,001 samples] running time (msec):   60.0   64.0   49.6   38.8   63.4
"""

low level API code:
import tensorflow as tf
import numpy as np
from time import perf_counter

filters = 8
kernel_size = (3, 3)
order = 'NHWC' # or 'NCHW'
img_shape = (15, 15)

inp_shape = img_shape + (filters,) if order == 'NHWC' else (filters,) + img_shape
kernel = tf.constant(np.random.rand(*kernel_size, filters, filters), dtype='float32')

from tensorflow.python.ops import gen_nn_ops

@tf.function(input_signature=[tf.TensorSpec([None, 15, 15, 8])])
def tf_func(inp):
    print('graph tracing')
    net = inp
    for _ in range(5):
        net = gen_nn_ops.conv2d(net, kernel, (1, 1, 1, 1), 'VALID', data_format=order)
    return net

def prepare_inp(n):
    return np.random.rand(n, *inp_shape).astype("float32")

out = tf_func(prepare_inp(1)).numpy() # first call - very slow
N = 30010
for n in range(N, N+6):
    inp = prepare_inp(n)
    elapsed = []
    for _ in range(5):
        _start = perf_counter()
        out = tf_func(inp).numpy()
        elapsed.append(perf_counter() - _start)
    print(f'[{n:,} samples] running time (msec): ' + ' '.join(f'{1000*e:6.1f}' for e in elapsed))

"""
Output:
graph tracing
[30,010 samples] running time (msec):  466.6   77.4   63.0   63.5   77.9
[30,011 samples] running time (msec):  389.0   64.0   49.6   38.8   63.4

Expected something like:
graph tracing
[30,010 samples] running time (msec):  466.6   77.4   63.0   63.5   77.9
[30,011 samples] running time (msec):   60.0   64.0   49.6   38.8   63.4
"""

Was able to reproduce the issue, please find the gist of it here. Thanks!

I ran the gist, it looks like it runs with CPU in the gist but in my environment it runs with GPU.
the issue occurs only in GPU.

I ran the gist, it looks like it runs with CPU in the gist but in my environment it runs with GPU.
the issue occurs only in GPU. what should I change so it will run in gist on the GPU?

@farotem,
Please click on "Runtime" -> "Change runtime type"  and then select the preferred hardware accelerator.

please add the label GPU since the issue is happening only on GPU

@farotem,
Sorry for the delayed response. Performance seems to be improved when your code is executed with Tensorflow Version 2.5. Please find the Gist. Can you please confirm the same? Thanks!

@rmothukuru
sorry for the late delay but it looks like it didn't improved with tensorflow 2.5.
the gist mechanism changed a bit.
when running the gist for the 1st time the performance issue occurs.
when calling run cell again with the same inputs shapes it doesn't.
when calling run cell again with different inputs shape (N = 30010 for example) its happening again.
can you please re open it?

@farotem Can you please try with the latest TF v2.7.0 and let us know if it helps?Thanks!

Hi,
I checked on tf 2.7 and the issue is still happening
tf version = 2.7.0
graph tracing
[29,990 samples] running time (msec): 1567.1  128.6  125.4  127.3  125.2
[29,991 samples] running time (msec): 1377.4  125.5  125.9  124.9  124.5
[29,992 samples] running time (msec): 1365.7  128.6  125.1  125.3  125.3
[29,993 samples] running time (msec): 1377.8  125.7  126.0  124.9  124.3
[29,994 samples] running time (msec): 1366.3  124.1  124.7  125.0  125.5
[29,995 samples] running time (msec): 1380.6  126.2  125.6  124.1  124.9

@farotem This is not a bug in tensorflow, everytime the input size changes, graph retracing happens as to accommodate the input size as mentioned here and that is the reason why performance is being reduced. To control the tracing behavior, you can use the following techniques as mentioned here. Thanks!

@gowthamkpr unfortunately from my benchmark calling conv2d with tf functions and tensor spec did not help to improve the performance when changing the batch size (you can see the example I shared) do you have a suggestion what to change to make sure retracing is not accuring when using conv2d?

@farotem The issue here is that, if you call the layer with inputs of different sizes, each time you call a layer your Function retraces a new graph for every call, you'll find that your code executes more slowly than if you didn't use tf.function. I would recoomend you to use unknown dimensions for flexibility as mentioned here to control retracing


Origin List based hooking

This PR intends to bring a change in the way the extension hooks into the running Hoppscotch page.
Implementation
With the new hooking mechanism, the extension doesn't rely upon the content script being executed in the page based on the manifest. Instead, it features a lot more hands-on approach. It will listen for tab updates throughout the browser and try to inject the data into content script file into the tabs which have their origins included in a origin list. The origin list is defined by the user and contains the origins which the extension (with the new hooking mechanism) should hook onto. The user can access and update the origin list by clicking on the extension button on their browser bars.
Why ?
The main motivation to this implementation over the current one is to allow users to include their own origins. With the present approach, the origins are fixed in the manifest. Many people run self-hosted versions of Hoppscotch or run Hoppscotch within containers and this allows those folks to still take advantage of the extension without resorting to building the extension with their origins included on the manifest.
Side-effects ?
Well, the current implementation overrides a ton of the safeguards that the browser manifest based hooking provides. Browsers are forced to assume a bit more general and low security permissions to the extension. This may increase review times for all further releases of the extension (especially on Chrome Web Store) as they would have to perform a more rigorous testing regimen on the extension. Also, the user facing permission screen will read out a bit more 'evil' seeming on the respective browser install prompts as well.
Progress

[x] Initial (PoC) implementation
[x] Implement proper CRUD operations on the origin list
[x] URL validation (make it so invalid origins are not accepted and origins are cleanly added (remove trailing slashes (if any) etc))
[x] Clean up and stylize UI
[x] Test and polish for Firefox
[x] Cleanup Manifest

Happy Hacking!

@AndrewBastin shouldn't we change Readme instructions along with this PR?

@AndrewBastin shouldn't we change Readme instructions along with this PR?


Feature 406 practically perfect

It looks like the name of the files should be swapped.
convection_allowing_models/Point2Grid_obsLSR_ObsOnly_PracticallyPerfect.py/conf

There are a couple minor things that need to be fixed in the .py documentation file:

The text in the links for the keywords need to match the keyword exactly or they will not come up in the search. For example, this:

ASCII2NC <https://ncar.github.io/METplus/search.html?q=ASCII2NCToolUseCase&check_keywords=yes&area=default>_
should be
ASCII2NCToolUseCase <https://ncar.github.io/METplus/search.html?q=ASCII2NCToolUseCase&check_keywords=yes&area=default>_
The keyword in the link should be the same as well. You can refer to the quick search page to make sure the keyword matches exactly.

The title of the use case webpage usually contains only the name of the evaluation tool used in the use case. This case runs 3 MET tools that convert data, so I'm not sure what is appropriate for this title. @TaraJensen any suggestions? Currently the title is:

ASCII2NC, Point2Grid, RegridDataPlane: Use storm reports on a grid as a mask to calculate practically perfect probabilities


Smart Contracts: Contract Storage Read Endpoint for remote core (futurenet)

Follows on from #60
Provide a way to read raw storage xdr from contracts, as a tertiary option for dapp devs. Probably the least used, so the lowest priority.
Access via HTTP, with something like:
/contracts/user:contractId/data/xdrstorageKey -> xdr storage value
Access via console, with something like:
cli read <contract_id> <key>
(Note: see if we can use strval for the key)
TODO

Blocked on #60

See https://github.com/stellar/stellar-core/pull/3500

core side of this is (I think) done in stellar/stellar-core#3500 above. Assigning back to paul for completion.


idle: Unmask only previous masked interruptions

Some architectures like ARM Cortex-M3 define minimum priorities. The
idle thread was not respecting it and unmasking all priorities >= 0.
Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

It is missing the power management path. Working on this, just sent this initial fix because I want to confirm that this is correct.

Not worth a -1, but I guess I don't understand the use case being supported here.  I mean, I get the idea of matching the exit interrupt level from an idle event to the entrance one in the sense of aesthetics and symmetry.
But... what on earth kind of interrupt priorities exist that we want NOT to interrupt the idle thread?  It's... the idle thread!  By definition it's the lowest priority code in the system, that does literally nothing.

Not worth a -1, but I guess I don't understand the use case being supported here. I mean, I get the idea of matching the exit interrupt level from an idle event to the entrance one in the sense of aesthetics and symmetry.
But... what on earth kind of interrupt priorities exist that we want NOT to interrupt the idle thread? It's... the idle thread! By definition it's the lowest priority code in the system, that does literally nothing.

This is about leaving the idle thread and restoring the state before it ran. It is not changing the interruption mask in the idle thread. I mean, if someone for some reason change the BASEPRI do something greater than 0, this affects all the time irq_lock is  used, not only here. And assuming that there is a reason to do this, it makes sense restore it properly IMHO.


Kapacitor Documentation is incomplete

I'm attempting to get started using Kapacitor, but having issue after issue.
First, it appears that the 'real world' stream example just doesn't work
invalid task: error calling func "percentile" on obj *kapacitor.influxqlMapReducers: reflect: Call using int64 as type float64
From there, I attempted to find the documentation for percentile, and found nothing.
Further, the sigma function says it uses a 'running mean', but the concept of running mean never defined.
These issues, and the general state of the documentation, are making it very hard to get using Kapacitor.

@nathanielc does this suggest any improvements to the docs?

@beckettsean There is a typo in the getting started guide for the percentile call. I'll fix that here in a bit before I forget.


Adding users to homepage (fixes #33)

Added users section to the homepage with 5 logos. Unfortunately, this script will execute on every page, but should only insert logos on the homepage. Couldn't find another way to do this with Jekyll.

You should be able to add this to the homepage front matter:
homepage: true

Then in the template:
{% if page.homepage %}
Your script
{% endif %}

Ahh.. Nice, I didn't realize that. Let me try it locally and submit a change if it works.

Updated. Nice trick!

Lgtm. Merge at will.


Extract cuba-front to a separate project

It is updated rarely. There is no need to release it every platform release
Relates to cuba-platform/cuba#1175

In former version was it possible to overwrite the frontProject in task buildUberJar by usage of  polymerProject
The documentation still contains
polymerProject - a Gradle project representing the Polymer UI module. If not defined, the standard polymer-client module is used.
please see at https://doc.cuba-platform.com/manual-7.0/build.gradle_buildUberJar.html
I guess it is missing due to a merge conflict.
Is it possible to reenable it soon?

See cuba-platform/cuba-gradle-plugin/issues/96#issuecomment-465898811


add circuit.compose() method

Compose two circuits (without having to turn one into a gate). Uses dag.compose() under the hood.

this looks good but we really need to have some tests. Since this is a new function I am ok approving and them making the test as the one that is the most complicated is when we have circuits with registers and the wiring map gets done correctly. Looking at the code I don't see any issues.

@kdk @jaygambetta releasenote and tests added.
I made a few updates and now dag and circuit composition have the same signature.
With this, we can deprecate circuit.combine and circuit.extend which only worked on circuits with the same registers - this is more general. I can do that next.


Water is broken on static bodies

What Happened?
Turns out that water volumes check the _attachedForceDetector on their planet's OWRigidbody, so any planet with water must also have a force detector
Static bodies do not get a force detector made
therefore static planets with water are very broken (crazy stuff starts to happen, including gravity affecting the player perpendicular to how it should)

Possible fix: add a ConstantForceDetector to static bodies that just detects nothing


Dice game UI updation

Image is not loading and button UI is not appropriate.

Sorry to inform but this repository has been excluded from hacktoberfest. So inorder to make your PR count towards hacktoberfest, request you to make your contribution in this repository -> https://github.com/SR-Sunny-Raj/Hacktoberfest2022-for-all


Add administrator UI

Ability to CRUD customers
Ability to view statistics on customers, associated applications and reviews

@noelo is this complete?

@boogiespook ?
On Thu, Jun 14, 2018 at 3:56 AM texasbrok<EMAIL_ADDRESS>wrote:

@noelo https://github.com/noelo is this complete?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redhat-cop/pathfinder/issues/21#issuecomment-397142071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAb_008bkPuSzmqD2eNh4z1Qj_2DMVqNks5t8cLBgaJpZM4TjKAF
.

I'm going to say this is complete. We can now CRUD customers and their associated applications. In terms of stats, we can see the percentage of assessments complete and review assessments.
If there are any other stats that are required, please open a specific issue to cover it.


Added GET_AND_SET_FIELDS_CONVENTION

Ignores all non field properties
JAVA-4545

Marking as draft - awaiting user feedback on the design.

Hey @rozza, this looks like exactly what we need as well. Any estimates when can it be released? Let me know if I can help. I'll try to implement a custom convention on my side for now, but would like to use the official version if possible.

Closing as this has gone stale.


Kivy makes massive app

Hi, I'm Trying to create a Kivy App for OS X. My main.py and kv file are about 12kb, and the compiled app is about 3.5 gbs. is there any way to make this smaller, as this seems really big.
Thank

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24918944-kivy-makes-massive-app?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).

my recent app has approx. 30mb after packing for osx with pyinstaller as one-file executable. how did you package your app?

I packaged my app using the "Offical Method". I will try pyinstaller though, thank you very, very much

I tried to use pyinstaller, but the file-size is still huge (2.35 gbs) anything I can do to make this smaller?

You can use the archive viewer to get an idea what bloats your app that much.
http://pythonhosted.org/PyInstaller/#using-pyi-archive-viewer

Thank you!
I realized what I did wrong!
I was packaging my app Inside the  folder, so it was pretty much making a copy of it self over and over and over again.
I needed to put kivy-sdk-packager in a directory not containing main.py


add a terraform resource for cf cache settings

Fixes: 147
cc @lucacasonato you might want to try it in a staging environment first; when I tried it locally, the first time didn't apply correctly, I had to apply a second time for the changes to appear correctly. Also make sure the CF API token you're using has the Zone Settings:Edit and Zone:Edit permissions.

Thanks, but as this affects everything on the zone, not just registry, I would rather not manage it through Terraform at the moment. I will close for now.


Maven Compiler Source Specifies Wrong Java Version

From the pom.xml:
  <properties>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <maven.compiler.source>11</maven.compiler.source>
    <maven.compiler.target>11</maven.compiler.target>
    <maven.compiler.release>11</maven.compiler.release>
    <skipITs/>
  </properties>

But in the code you use "string blocks":
 """
package foo;
abstract class AbstractParent {
  abstract byte[] foo();
}
""".getBytes()

String blocks were added only starting from 15 version. This inconsistence  in versions create significant problems in project configuration.

@volodya-lombrozo fixed, thanks!


fixed ChosenInlineResult

I fixed the ktlint in chosenInlineResult.

@red-avtovo hi, could you please review and merge this PR?
Thanks in advance

Thanks for the nudge! 👍


Support for the mold linker

This adds support for the mold linker on linux. On my system this significantly improves link time (from about 18 seconds to about 1 second).

Siiiick, but awwww, linux only?

https://github.com/bluewhalesystems/sold
Payware, but would be totally worth it

I tested this under Ubuntu 22.04 container - in this environment gold is always installed because it is included in binutils , and mold is an extra package, so we can have both, but we cannot have mold alone without gold.


Use cluster name as SNI when using Istio mTLS

Reverts #7692
Using the cluster name will be needed to do SNI-based cluster routing
at the gateway in multi-cluster scenarios, where the client
and server use citadel minted certs.
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lizan this is with regard to the discussions ongoing in Envoyproxy on using SNI name as cluster name

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lizan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Well, standards still matter - and there is no guarantee envoy will be on
the other side. Pilot or other 'native' istio stacks could be as well.
On Tue, Sep 18, 2018, 18:10 Shriram Rajagopalan<EMAIL_ADDRESS>wrote:

@rshriram commented on this pull request.
In pilot/pkg/networking/core/v1alpha3/cluster.go
https://github.com/istio/istio/pull/8778#discussion_r218641508:

@@ -490,6 +486,10 @@ func applyUpstreamTLSSettings(cluster *v2.Cluster, tls *networking.TLSSettings)
Sni: tls.Sni,
}

// Set default SNI of cluster name for istio_mutual if sni is not set.

if len(tls.Sni) == 0 && tls.Mode == networking.TLSSettings_ISTIO_MUTUAL {

	cluster.TlsContext.Sni = cluster.Name

Yes, per "spec" it has to be valid DNS name.. But I confirmed that boring
SSL doesn't care at all (confirmed with @PiotrSikora
https://github.com/PiotrSikora as well). Infact, a few months ago, the
SNI was set to the cluster name in our code base and things worked normally.
Given that we set cluster name as SNI only for istio services using mTLS,
we know that the other side is Envoy and that envoy will accept arbitrary
strings as SNI, we should be safe,
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/8778#discussion_r218641508, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6k5OGANWX3SGK5fSAoPIgE-UNL65ks5ucZmUgaJpZM4Wsn8v
.

And no guarantee boringssl will continue to fail to validate - it is
clearly a bug, and most failures to validate can result in security
problems.
On Tue, Sep 18, 2018, 18:59 Costin Manolache<EMAIL_ADDRESS>wrote:

Well, standards still matter - and there is no guarantee envoy will be on
the other side. Pilot or other 'native' istio stacks could be as well.
On Tue, Sep 18, 2018, 18:10 Shriram Rajagopalan<EMAIL_ADDRESS>wrote:

@rshriram commented on this pull request.
In pilot/pkg/networking/core/v1alpha3/cluster.go
https://github.com/istio/istio/pull/8778#discussion_r218641508:

@@ -490,6 +486,10 @@ func applyUpstreamTLSSettings(cluster *v2.Cluster, tls *networking.TLSSettings)
Sni: tls.Sni,
}

// Set default SNI of cluster name for istio_mutual if sni is not set.

if len(tls.Sni) == 0 && tls.Mode == networking.TLSSettings_ISTIO_MUTUAL {

	cluster.TlsContext.Sni = cluster.Name

Yes, per "spec" it has to be valid DNS name.. But I confirmed that boring
SSL doesn't care at all (confirmed with @PiotrSikora
https://github.com/PiotrSikora as well). Infact, a few months ago, the
SNI was set to the cluster name in our code base and things worked normally.
Given that we set cluster name as SNI only for istio services using mTLS,
we know that the other side is Envoy and that envoy will accept arbitrary
strings as SNI, we should be safe,
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/8778#discussion_r218641508, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6k5OGANWX3SGK5fSAoPIgE-UNL65ks5ucZmUgaJpZM4Wsn8v
.

That is true.. but this is the easiest way to get zero vpn working. We pass in the cluster name to the remote gateway in SNI, and the gateway routes to the internal cluster by that name. The filter for this will land in Envoy soon (working onit). If we adopt any other custom format, then its hard to push that filter to Envoy as it would have some custom logic to decode SNI to a cluster name [not everyone would agree with it]. But taking SNI string opaquely as the cluster name will be acceptable to everyone.

We can replace the special char in the cluster name. Or even better - make
it dns name. For example _port._subset.service
On Wed, Sep 19, 2018, 16:59 Shriram Rajagopalan<EMAIL_ADDRESS>wrote:

That is true.. but this is the easiest way to get zero vpn working. We
pass in the cluster name to the remote gateway in SNI, and the gateway
routes to the internal cluster by that name. The filter for this will land
in Envoy soon (working onit). If we adopt any other custom format, then its
hard to push that filter to Envoy as it would have some custom logic to
decode SNI to a cluster name [not everyone would agree with it]. But taking
SNI string opaquely as the cluster name will be acceptable to everyone.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/8778#issuecomment-422995854, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6lgLh4_d7FhhZo1xp2eFzdjEcMOLks5uctpQgaJpZM4Wsn8v
.

I don't think the spec enforces (i.e. MUST in RFCs) DNS names. It only says currently only DNS hostnames are supported, and it MAY treat it as opaque data.
https://tools.ietf.org/html/rfc6066#section-3

Currently, the only server names supported are DNS hostnames;
however, this does not imply any dependency of TLS on DNS, and other
name types may be added in the future (by an RFC that updates this
document).  The data structure associated with the host_name NameType
is a variable-length vector that begins with a 16-bit length.  For
backward compatibility, all future data structures associated with
new NameTypes MUST begin with a 16-bit length field.  TLS MAY treat
provided server names as opaque data and pass the names and types to
the application.

@PiotrSikora for expertise on TLS spec.

That is my recollection as well. SNI is treated as opaque and passed as is to the application.
And if we add any semantics to interpreting/converting the SNI to a cluster name, we have to get everyone in the larger open source community to agree upon that format and then push it into Envoy as a filter. IF we treat the SNI as a opaque string and use that string as a cluster name (just like the way Envoy allows this to happen for HTTP clusters via cluster_header parameter), we keep everyone happy and people are welcome to use any format they want for their cluster names.

Agree we should not add any mapping. But we can still change how we name
clusters - so they are dns names. Everyone happy.
On Wed, Sep 19, 2018, 17:42 Shriram Rajagopalan<EMAIL_ADDRESS>wrote:

That is my recollection as well. SNI is treated as opaque and passed as is
to the application.
And if we add any semantics to interpreting/converting the SNI to a
cluster name, we have to get everyone in the larger open source community
to agree upon that format and then push it into Envoy as a filter. IF we
treat the SNI as a opaque string and use that string as a cluster name
(just like the way Envoy allows this to happen for HTTP clusters via
cluster_header parameter), we keep everyone happy and people are welcome to
use any format they want for their cluster names.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/8778#issuecomment-423002496, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6u2IjPRWXDqsELpMmFz67EHImb2jks5ucuRvgaJpZM4Wsn8v
.

@costinm any change to cluster naming will cause upgrade issues, which we will have to handle.
Previously we attempted a dns compliant cluster name because upstream sets it as the host header if none is set, but we don’t have that requirement anymore.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lizan, PiotrSikora
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The naming format of the cluster is independent of this PR isn't it? if we change the cluster naming format to a DNS form, then this will automatically cause all SNIs to be DNS names. Put another way, we need this PR irrespective of the naming format we choose for clusters.
Also, keep in mind that subsets are optional. So, we have to use some dummy subset name if there is no subset. And anything we choose is bound to cause collision. Btw, _ is not a valid DNS char. So, we are restricted to [0-9a-z-] and coming up with some Istio default name is hard. Second, we use the service's dns name as part of the cluster name. and since service entries can have wildcards, an entry like *.example.com will end up as 80||*.example.com.. Translate this to a proper DNS name and we have more issues (finding a suitable alternative for * without colliding with names people can use (remember underscore is not allowed in DNS).

And if we pick some dummy names, we have to make sure all our dashboards are updated to strip out the dummy names and display the proper values. Thats sure to be a breaking change :( [we can manage pilot side but not dashboard side]. We went through this pain once during the 0.8 cycle and @douglas-reid was not very happy.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lizan, mandarjog, PiotrSikora
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: GregHanson, lizan, mandarjog, PiotrSikora
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [GregHanson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I don't think it'll cause upgrade issues - each envoy (regardless of
version) gets an opaque name. And we have versioning support if needed.
The main reason for this is interoperability with non-envoy clients ( grpc,
etc ) and tools that use and expect normal domain names.
We already create a big interop issue with the spiffee - no need to make it
worse.
On Wed, Sep 19, 2018 at 8:03 PM mandarjog<EMAIL_ADDRESS>wrote:

@costinm https://github.com/costinm any change to cluster naming will
cause upgrade issues, which we will have to handle.
Previously we attempted a dns compliant cluster name because upstream sets
it as the host header if none is set, but we don’t have that requirement
anymore.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/8778#issuecomment-423024875, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6nwSUGnu_AMrSFy1IF-N2OyRJLByks5ucwWIgaJpZM4Wsn8v
.


Check before commit

Allow local environment variables to be set in order to run tests against a new device matcher without creating additional files. Formats input data suitably for importing into device-identification-data and tvp-user-agents.

closing due to inactivity


Extend elasticsearch_index resource capabilities + fix issue #38

This PR solve issue #38 and extend capabilities of elasticsearch_index
The problem of  var.indices as map(any) lead terraform raising an exception when defining nested maps in mappings attribute or any other string JSON that converted by jsonencode function from map(any) to string.
Terraform issue mentioned here about nested maps within map(any) variable .
Terraform Error:

cannot find a common base type for all elements

Expected behavior:

Defining nested maps inside JSON string attribute of terraform resource elasticsearch_index schema

Required Configuration E.g:
indices = {
    example-index-1 = {
      number_of_shards   = 2
      number_of_replicas = 1
    }
    example-index-2 = {
      number_of_shards   = 2
      number_of_replicas = 1
      mappings           =<<-EOF
      {
        "properties": {
          "id": {
            "type": "text"
          },
          "name": {
            "type": "text"
          },
          "containerType": {
            "type": "text"
          },
          "containerIds": {
            "type": "text"
          },
          "synonyms": {
            "type": "text"
          },
          "parentEvents": {
            "type": "text"
          },
          "valueType": {
            "type": "text"
          }
        }
      }
    EOF
    }
  }

Suggested Solution:

Using terraform intended heredoc by changing var.indices to defined map object and use string variable in all JSON objects.

Hi @Amos-85, thanks for your pull request.
That's really cool, i like it! But it's a breaking change.
This change will replace all indices in already existing clusters.
I think we should merge it when we switch to the new Terraform provider for OpenSearch.

Hi @Amos-85, thanks for your pull request.
That's really cool, i like it! But it's a breaking change. This change will replace all indices in already existing clusters.
I think we should merge it when we switch to the new Terraform provider for OpenSearch.

@steveteuber do you have a timeline for the OpenSearch provider migration? I have some needs that unfortunately this module doesn't offer and would like to help with the migration but not sure if it is an undergoing effort or it hasn't started yet.
Thanks!

Hi @amontalban, I will start the migration next week.


mx num seqs expose to benchmark_throughput script

mx num seqs expose to benchmark_throughput script
@shajrawi  @dllehr-amd @JArnoldAMD

Can you please make the changes in benchmarks/profiling version of the *py benchmark files? This is our own copy we can change in rocm/vllm.
Changing the benchmarks/ folder scripts would require going through upstream first to avoid merge conflicts.

@shajrawi
Sure will do! Thank you for the guidance!


Triangulator gets hanged in infinite loop

Hello! Trying to draw shape like this:
drawBatch.Begin(DrawSortMode.Deferred);

var brush = new SolidColorBrush(Color.Black);

drawBatch.FillPath(brush, new List<Vector2>()
{
	new Vector2(0, 0),
	new Vector2(0, 100),
	new Vector2(20, 120),
	new Vector2(20, 20),
});

drawBatch.End();

Then program freezes - triangulator function hangs in infinite loop

Seems I used wrong function for my task. Now I'm using FillQuad - works perfect :)


DefaultLimitSpec doesn't respect sortByDimsFirst

The timestamp is always compared first in the ordering created by DefaultLimitSpec (https://github.com/druid-io/druid/blob/master/processing/src/main/java/io/druid/query/groupby/orderby/DefaultLimitSpec.java#L201-L253). This breaks the behavior sortByDimsFirst.
I'm fixing this bug, and wonder what is the correct behavior of sortByDimsFirst. If some metrics are specified as well as dimensions for ordering in limitSpec, should they be compared before comparing timestamp? or only dimensions should be compared before timestamp?
IMO, it looks to make sense to compare metrics as well as dimensions before timestamp if sortByDimsFirst is set to true, because sortByDimsFirst option is introduced to avoid sorting in each time bucket and thus get the result sorted by columns.
@himanshug what do you think?

IMO, it looks to make sense to compare metrics as well as dimensions before timestamp if sortByDimsFirst is set to true, because sortByDimsFirst option is introduced to avoid sorting in each time bucket and thus get the result sorted by columns.

@jihoonson yes I agree.


Loading Dom Problem

Good Job Jose!

Don't forget that to use dynamically created element classes in JS you must first load them into the DOM.

Nice code! In the meantime please try to adapt your css style so that it looks like the original design.

Thank you very much for your suggestion


meta-ros to be built for Raspberry Pi 4 instead of Raspberry Pi 3

Milestone 11 will introduce support for OpenEmbedded release series newer than thud and migrate webOS OSE to version 2.x. This means that meta-ros will be able to be built for Raspberry Pi 4. In order to reduce the number of combinations of  OpenEmbedded release series and MACHINE-s for which we do builds, we intend to replace building for raspberrypi3 with building for raspberrypi4. However, we won't do anything that knowing prevents others from building for Raspberry Pi 3.
If this change will cause you hardship, please respond by the end of 2020-01-17 (UTC).

The support policy for MACHINE-s has been codified on the Policies wiki page.


kerasTensor not behaving as expected, functional api incorrectly skipped

System information
Tf version:
v2.6.0-rc2-32-g919f693420e 2.6.0
Problem
Using tf.keras.Input(4, 1) doesn't work with all layers. I am using an op which does not support dispatching, which will break the use of KerasTensors. Adding dispatching fixes this problem, and digging into the dispatching code I see it uses tensorflow.python.keras.layers.KerasOpDispatcher which just wraps my op in a TFOpLambda layer. Rather than add the dispatching I figure I can just use the TFOpLambda layer directly. But using the TFOpLambda layer directly does not work, because the check for whether the input to the layer is a keras tensor erroneously returns false, which means the layer is not built through the functional api.
Minimal example
import tensorflow as tf
import tensorflow.keras.layers as layers

from tensorflow.python.ops.gen_cudnn_rnn_ops import cudnn_rnn
from tensorflow.python.util.dispatch import add_dispatch_support
from tensorflow.python.keras.layers.core import TFOpLambda

# explicitly adding dispatching works!
# the call to cudnn_rnn_dispatch calls a tfoplayer, which is built CORRECTLY with the
# functional API as the check _in_functional_construction_mode returns true this check
# is done in keras.engine.base_layer and it returns true because we have a tensor t such that:
# t is an instance of <class 'keras.engine.keras_tensor.KerasTensor'>
# is_instance(t, keras_tensor.KerasTensor) -> True
x = layers.Input([1, 4])
cudnn_rnn_dispatch = add_dispatch_support(cudnn_rnn)
out = cudnn_rnn_dispatch(x, x, 0, tf.zeros(128), rnn_mode='gru')
y = out[0]

# turning into a layer does not work!
# it fails because in the base_layer now the _in_functional_construction_mode check
# erroneuously returns False!
# the _in_functional_construction_mode check now takes place in
# tensorflow.python.keras.engine.base_layer
# and we have the confusing:
# t is an instance of <class 'keras.engine.keras_tensor.KerasTensor'>
# is_instance(t, keras_tensor.KerasTensor) -> False
x = layers.Input([1, 4])
cudnn_layer = TFOpLambda(cudnn_rnn)
try:
    out = cudnn_layer(x, x, 0, tf.zeros(128), rnn_mode='gru')
    y = out[0]
    print(y)
except TypeError:
    print('IM BROOOOOOOOOOOOOOOKEN')

@ben-davidson-6 Please post this issue on keras-team/keras repo.
To know more see;
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999
Thank You!


Get Wallet Connect working with daohaus-connect

Description
Some configuration or package version in connection with web3modal might be causing a typscript issue. When trying to connect with WC we see an error:
Global is not defined

This is a vite specific issue I believe. @alexkeating do you think that the approach for defining global in the index.html may not work since this is within a package?

https://github.com/raid-guild/headline/blob/master/index.html#L19


[SYSTEMML-1774] Bugfix for illegal arguments in ConvolutionUtils

When using Arrays.fill() in ConvolutionUtils.#binaryOperationInPlace to fill the values of the 1-dimension destination array by fromIndex and toIndex, the column index cix of the sparse matrix block need to be added into fromIndex and endIndex first, but it is missed at line 95 for toIndex.

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1780/

It works, @feihugis !

Thank you @feihugis for the fix and @j143 for testing.
LGTM.


Added Image Gallery

Fixes: #220
Describe the changes you've made
Added an option in navbar "image gallery" in home page .
Image gallery contains reports of 2020 and female rights activists with their descriptions .
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.

Screenshots

Original
Updated

original screenshot
updated screenshot

Hey @mansijain980, fix this.

I am getting error on adding gallery.html url on  line 16 this.
Please tell me what is the issue?

Before adding line 16 it was properly working .
Thanks.

Now its working fine after removing line 16 from urls.py

I have done all changes required to run this image gallery in home.html , urls.py , viwes.py , gallery.html.
Please check it.
Thanks.

Hey @mansijain980, Fix this issues mentioned below

Align the cards in a proper manner.
Use the same font as used in the website.
The back to top button should be same.
Add header and footer.
Use good quality pictures. (Don't stretch the pictures)

Use soe good quality pics
Many photos are stretching, fix it.
Use proper css for making the page look good.

yes sir i m adding footer etc as well .

Please check login.html page and let me know.
Thanks

@sakshikhachane Can you please look into this as there is no proper use of css as she is using only html.

Use soe good quality pics
Many photos are stretching, fix it.
Use proper css for making the page look good.

yes sir i m adding footer etc as well .

yes sir i will do this as i noticed it after commiting.

@sakshikhachane Can you please look into this as there is no proper use of css as she is using only html.

Maam wherever needed i used it , i will do changes .
Thanks.

Please check login.html page and let me know.
Thanks

?

@sakshikhachane Can you please look into this as there is no proper use of css as she is using only html.

Maam wherever needed i used it , i will do changes .
Thanks.

Please look after the other pages that are there on the website and use the CSS accordingly.

@swapnilsparsh sir , actually i have assigned three issues of this repo and out of three i did commit for two bt it does not make a new pull request and everytime the changes were commit on a frst pull request i did .
Can u see to it?
Thanks.

@swapnilsparsh sir , actually i have assigned three issues of this repo and out of three i did commit for two bt it does not make a new pull request and everytime the changes were commit on a frst pull request i did .

@mansijain980 If you are working on different issues then always make sure that all the work that is done is on different branches which must not be the master branch.

@mansijain980 Any updates?

Hey @mansijain980,
It's 1 month since you have created the issue and 18 days since you have created the PR. We can't wait for such a long time as there are many participants you want to contribute. So, I am closing this PR.


Unintended Shrinking?

So i had some fun with the newest version and things were working as intended, but when i switched to a second girl in Free H their breast sizes suddenly went negative. Dosent seem to matter on who it was, their breasts were normal for a sec but upon being interacted by the plugin they just go microscopic. Switching off Original Size fixed this but that mean i had to resort to putting in sizes manually. Something went wrong here, proably as a side effect of the new update, mind looking into it?

I tried reproducing your error
with the exact same settings
it might be a conflict with an existing mod
or perhaps you have both the BE and Age Progression plugin both installed at the same time?

I am also having this issue, could be an issue with a different plugin as I don't have the age progression plugin installed

Can confirm, it was most likely because i had both the BE and Age plugins on. Sorry for taking so long to reply to this, it seems to be resolved


New CostEvaluator for AQE in Spark 3.2

Spark 3.2 has introduced a better cost evaluator and has also exposed a config, spark.sql.adaptive.customCostEvaluatorClass, that allows a user to use a different cost evaluator. We might be able to use this
Read SPARK-35794 for more details

Although no action is required, I would like to at least explore implementing our own cost evaluator that delegates to our existing CostBasedOptimizer and compares the original Spark plan with the plugin version of the plan, and chooses the cheapest plan. This would only take effect if the user specifies spark.sql.adaptive.customCostEvaluatorClass to use our custom cost evaluator.


Uncaught Error: Class 'phpDocumentor\Reflection\Types\Mixed' not found in /var/www/language-server/vendor/felixfbecker/lang uage-server/src/DefinitionResolver.php

https://github.com/phpDocumentor/TypeResolver/releases/tag/0.4.0 (Renamed Mixed to Mixed_)
You either need to make edits to the file (LanguageServer\DefinitionResolver) or change the package version to an earlier version.

See 7ce228417605bc8559716d300f21d0ce26209fda and https://github.com/phpDocumentor/ReflectionDocBlock/issues/109


More declarative way of adding stories?

Say we have an addStories method:
const addStories = (stories) => {
  Object.keys(stories).forEach(key => {
    let story = storiesOf(key, module)
    stories[key].forEach(args => {
      story = story.add.apply(null, args)
    })
  })
}

then we can reduce some boilerplates and be more declarative:
const stories = {
   'Button': [
        ['with text', () => (<button onClick={action('clicked')}>My First Button</button>)],
        ['with no text', () => (<button></button>)],
    ],
}

addStories(stories)

Hi @xyc . It can be done with an addon. @jurgob wrote something similar here.

Hope we can close this.


FIX: sort by subquery results in error that tableAlias.column does not exists

This pull request addresses issues related to sorting within a column that is created by a subquery
example
   // service.ts
	 const builder = this.pomBoxRepository.createQueryBuilder("pb");

	// subquery
    builder
      .addSelect((subQuery) => {
        return subQuery
          .select("COUNT(t.id)", "trayCount")
          .from(Tray, "t")
          .where("t.pom_box_name = pb.name");
      }, "trayCount")

	 return paginate(query, builder, {
       sortableColumns: ["trayCount" as any],
    });

this service results an error from db Unknown column 'pb.trayCount' in 'order clause'.
This PR fixes above problem

Hi! Thanks for your contribution! Could you add a test that shows that this PR fixes the problem you speak of? :)


Fix code and tes

[x] Use<EMAIL_ADDRESS>>> support Node.js 12+.
[x] Fix typo (typo with js linter).
[x] All Test Pass.

@niftylettuce, Oops lock file :D .


Error in Demo: Invalid audio type: Your GStreamer installation is missing a plug-in.

Describe the bug
Running the https://github.com/speechmatics/speechmatics-js-sdk/tree/main/examples/microphone_nextjs demo gives me the following error: "Invalid audio type: Your GStreamer installation is missing a plug-in."
To Reproduce
Steps to reproduce the behavior:

Follow setup steps in https://github.com/speechmatics/speechmatics-js-sdk/blob/main/examples/microphone_nextjs/README.md
Open demo and click "Start transcribing"
See error

Expected behavior
Demo to work
Screenshots

Desktop (please complete the following information):

OS: macOS Ventura 13.4
Browser: Google Chrome
Version: Version 123.0.6312.124 (Official Build) (arm64)

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@thorwebdev I was unable to reproduce this on the following:
Mac OS 14.5 (23F79), 124.0.6367.208 (Official Build) (arm64)
Did you manage to resolve it in any way?


Themes

Summary
can we have the following themes

native windows
flat metro light
flat metro blue
flat metro dark

Analysis

pros

just more visual pleasing

Attachments

I just changed the metro themes to flat metro themes since that is what I meant

Chaning the theme ist quite difficult right now, because we are using WinForms. Maybe after choosing a new UI Framework (https://github.com/AdamsLair/duality/issues/274), we could add different themes, like dark theme, light theme...


Okay, I'll make the tweak. Thank you for catching this issue and posting the patch!


Placeholder styling?

Is there any way to set css styles of select placeholders? It works on my "non select2" -selects/inputs but not in the ones using select2.

In response to the original issue, I'm still finding it impossible to style the select2 placeholder without affecting the other values.
Two years later, has anyone managed to figure this out or should I pursue another JS library for select styling?

In Select2 4.0...
For a single select, the text is in a span with the class .select2-selection__placeholder.
For multiple selects, you can override the browser placeholder on the search box.


Is there a way to know to which component each point was clustered?

I may not be familiar with the algorithm, but
Is there any way to know to which components each point was clustered?
Maybe I've heard the obvious, but I'd appreciate it if you could answer.

From link, "UMAP provides a n_components parameter option that allows the user to determine the dimensionality of the reduced dimension space we will be embedding the data into." IOW each point is embedded in a latent space of 'n_components' dimensions, which is usually 2 or 3 for visualization. To cluster points which may be 'close' together in this latent space is a different analysis.


Could not copy or download

Hello xiaoluoboding,
Your bookmark.style is brilliant. However, I found I could not copy or download via these two buttons. Would you please help fix? Thanks.

@cncn123 It's a known issue, you can use capture image tools instead for now.

@cncn123 It's a known issue, you can use capture image tools instead for now.

Noted with thanks.


Remove ConfigBuilder and Gossip

Problem
ConfigBuilder is deprecated and only used for a couple of cases:

Integration testing
The dynamic validator

Gossip networking also is a deprecated dependency that only exists for config-builder.
Goal
Remove ConfigBuilder and Gossip from networking.
Approach

Minimize the code necessary for ConfigBuilder to support Integration tests or explore how to make the Genesis based config builder work for integration test cases
Add a --test feature to libra-node that takes in a random seed used for producing a deterministic genesis
Eliminate validator-dynamic containers and give instructions on how to leverage --test from within the primary docker container
Update docker information to show that we no longer directly support running a set of validators in docker
Remove [gossip]( from networking

@davidiw I think we did it!

WOW, we accomplished so much!


c-lightning-REST improvements

continues: #4002 with small fixes for reliability

the new clrest, RTL and is working well with the latest CLN now


feat(lint): add rules for  component

Close US102190
Add rules for the  component:

no-unknown-key
interpolation-data

Pull Request Test Coverage Report for Build 163

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.886%

Totals

Change from base Build 160:
0.0%

Covered Lines:
101

Relevant Lines:
105

💛  - Coveralls


Feed stopped working all of the sudden

Hi there,
This was working a few days ago and all of the sudden stopped working:
{exp:twitter:user screen_name="revitasinc" limit="5"}
{text}
{/exp:twitter:user}
Debugging says:
(0.019667 / 14.20MB) Using 'user' Twitter Timeline For User revitasinc
(0.019739 / 14.20MB) Fetching Twitter timeline remotely
(0.068728 / 14.25MB) Twitter Timeline Error: Unable to retrieve statuses from Twitter.com
Any thoughts?

Interesting.

Nothing related seems to have changed on Twitter's end recently: Twitter API Recent Changes
I checked some of our sites that are using this module, and it still seems to be pulling in correctly.

I think your best bet is to inspect $rawjson around mod.twitter.php line 434 to see if what Twitter is sending you gives you any clues.

I also received this but I'm unsure how to further troubleshoot. I tried to create new keys and it's giving me a generate new token error.
Client is on v2.9.2 - Build Date: 20141004
PHP Version 5.5.9
I looked into the line 434 and nothing shows there.

@lealea Can you change line 434 to this?
echo $rawjson; die();

or
var_dump($rawjson); die();

to see what the JSON being returned by Twitter says?

That doesn't seem to work because I removed all my keys and it won't let me generate request tokens any more. :-/ I just gives me a variation of:
{"errors":[{"code":215,"message":"Bad Authentication data."}]}

Hm, when I put in the API keys/secret but DON'T try to generate a PIN, it gives me:
string(62) "{"errors":[{"code":135,"message":"Timestamp out of bounds."}]}"


Documentation review.

Fixed some typos and improved readability.
Small documentation review. There is still some improvements that can be done that will make the documentation/concept more clear.

Thanks! Documentation is still a bit raw material, so much room for improvement :smile:

:+1:


[SPARK-122] python support for kv

WIP: documentation

looks good to me

@zkhadikova please remove connector/python/setup.pyc from 2bf1c0b


feat(Frontend): Basic login page

Basic login page on foront end, there are no logic, only view

Codecov Report

Merging #7 (f244756) into main (3775543) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main       #7   +/-   ##
=========================================
  Coverage     43.33%   43.33%
  Complexity       10       10
=========================================
  Files             6        6
  Lines            30       30
=========================================
  Hits             13       13
  Misses           16       16
  Partials          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3775543...f244756. Read the comment docs.


Added Welcome Screen to improve UI

Welcome screen was added as a entry point to the app to improve User Experience and User Interface
It looks like this Screenshot:

if any changes regarding this please mention it

there are some conflicting files, so kindly resolve it

Also, are other sign-in methods are working?

i resolved merge conflicts @Ijaiswalshivam


Color set -> color class compression

Congratulations on the excellent manuscript! I have read it with great excitement and @jamshed will be presenting this paper in our lab's journal club soon. I was also very happy to see that you've chosen to implement ggcat in Rust.
I wanted to make brief mention of something that may be relevant to your color set representation. The concept of collapsing redundant color vectors into a minimal set of unique colors (i.e. color classes) and then representing them by their indices via an extra layer of indirection, is, depending on the specific data, a very powerful idea.  This is essentially the same strategy adopted in rainbowfish and, later, mantis, and may be worth mention in your manuscript.  Along these lines, I also wanted to convey an additional idea adopted in those tools that you may find useful to compress the color information even further.
In many types of data over which one wants to build a compacted colored dBG, not only do many k-mers have identical color sets (that is, they are equivalent under the color relation of k1 ~ k2 iff colors(k1) = colors(k2)), but the frequency distribution of the color sets themselves is highly skewed.  That is, there are a small number of distinct color classes to which many k-mers map, and the distribution of frequencies of color class occurrences is often scale-free.  This presents an additional opportunity to compress the color class labels themselves even further by choosing small labels (integers) for color ids that will be used frequently, and choosing larger labels (integers) for color ids that will be used infrequently.  Specifically, as you build the information concerning the color sets, it is relatively easy to track the number of times a color ID has been used.  Then, IDs can be re-ordered to assign smaller IDs to more frequent color sets and larger IDs to less frequent color sets.  While this re-labeling can be done globally, it turns out that, in practice, the majority of the benefit comes from just assigning small IDs to the few most frequent color sets — this can be done at a relatively small cost by simply sampling the color sets for a small fraction of the k-mers. As long as the sampling is done randomly and unbiasedly, you'll expect to see all/most of the heavy hitters (probably many times) in your random sample, and you can assign IDs based on the frequency in this random sample (this is akin to the strategy we adopt to assign color IDs in mantis).
Anyway, congrats again on the very cool paper, and thanks for helping to drive rust adoption in bioinformatics! We look forward to exploring and using your tool.

Very nice paper indeed. For the record, "color class compression" is also used in my tool Themisto (supplement 1 of this paper https://www.ncbi.nlm.nih.gov/pmc/articles/PMC8743562/).

Hi, thanks for the useful tips! I'll look at rainbowfish and mantis, also citing them in the paper.
I'll investigate the possibility of adopting the optimized color index encoding as you proposed.
Andrea


[sil-serialize] Improve serialization of function declarations and function definitions with external linkage

It turned out that a significant part of a swiftmodule’s size is contributed by function declarations and types used by them. Therefore it is important to avoid emitting any functions or function declarations that are not needed by the module.
This change introduces the following changes:

Function declarations should be serialized only if they are referenced by something that is serialized.
Function bodies of functions with external linkage should never be serialized.
The only exception are shared_external functions. THis is a workaround, which will be removed in the future (see explanations in SILSerializer::writeSILFunction)

The result of the later change is that functions with external linkage are not put on the SIL serialization worklist and their bodies are not scanned, thus we do not detect references to the functions which are only referenced by functions with external linkage. In particular, the bodies of shared_external functions won’t be serialized at all if they are referenced only from functions with external linkage. And declarations of external functions referenced only from functions with external linkage won’t be serialized too.
With this changes SILSerializer produces smaller swift modules, because it serializes significantly fewer function declarations and function bodies of external functions.
Fixes rdar://30081040

@jrose-apple Jordan, could you have a look? Does it make sense?

@swift-ci please smoke test

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 96e83ef1e3bd17feb032b1540b17935034fd28b1
Test requested by - @swiftix

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 96e83ef1e3bd17feb032b1540b17935034fd28b1
Test requested by - @swiftix

@swift-ci please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - b5943d476e3207b55d130236f94925371dc2c1e2
Test requested by - @swiftix


Introduce provider upgrade tests for the V6 RC branch

This is the merge of https://github.com/pulumi/pulumi-aws/pull/2711 with further commits that adapt it to the V6 reality.
The good news is that the full integration upgrade tests pass, and validate rds.Instance upgrade.
The bad news is that the quick version fails, I suspect this is due to the known limitation of replaying Diff only and not the results of Check. This will need to be investigated.
Still we can check this in as it adds coverage if we could make sure it runs on CI. Checking up on that.

@iwahbe I've pondered sequencing here and I think if there's ongoing work to bring AWS repo under ci-mgmt perhaps this PR is not a good time to split examples and tests.
I don't think we were tracking this before so here's a new issue:
https://github.com/pulumi/ci-mgmt/issues/526
Once pulumi-aws is under ci-mgmt we can roll out examples/tests split everywhere including here, then move tests around.

Let me confirm but I also think this is self-sufficient for recording v5 provider; the baseline version is currently written in the Pulumi.yaml Program file. So if doing something like adding example resources we should be able to re-record this baseline version from the main branch without having to checkout some earlier branch.

"Error creating S3 bucket: BucketAlreadyExists: The requested bucket name is not available. The bucket namespace is shared by all users of the system. Please select a different name and try again." hmm okay so we would need to randomize the names. That's unfortunate.

We could make the name depend on the stack name, which is already accounted for.

That's ${pulumi.stack}-somename ? Yes worth trying .


First Draft of changes for BMC-SMM target phase-1

Integrated changes for BMC-SMM exdi gdbserver target


Can't use option -f.

I got this error.
> crx pack -f
error: unknown option `-f'

Not sure what happens.
Node's version is v0.10.35

It changed in 8638efeae30f64b9f33fc3366aaf280a523de58e / v2.0.0 / cf. git blame.
You can use -o to output to a file, instead of -f. The last often refers as --force rather than --file (file is too imprecise on its meaning and implications).
Let me know how it goes.


Fix SQL DDL generator

[x] tests and linter show no problems (npm t)
[x] code is properly formatted (npm run fmt)
[x] description of changes is added in CHANGELOG.md

Landed in https://github.com/metarhia/metasql/commit/73f421a1d9e22cce82b351a5bb219bb10ba7b601, https://github.com/metarhia/metasql/commit/1c0cf1d6404b36e9e463dfe0b259cbc3c09253bb, and https://github.com/metarhia/metasql/commit/752f65dc341150f06616fc28a7fcac1fe790cdab