TX power for CC1352P2 CC2652P router firmware

Hey,
Can you please share what tx power is set in CC1352P2_CC2652P_other_router_20210128.hex?
Currently im tessting CC2652P as a router, it works stable but i think that it has lower radio tx power than my old CC2530+CC2591 - which is surprising ;)

5dbm

Ok, will try to build new firmware. As i dont have any experience with CCS (and zigbee firmware), any hints how to adjust tx power before compilation?

Can you please share your firmware？

Sure, but please remember that this is "test" firmware, im dont know much about this board. I cant guarantee anything (except that it works in my network). But still power is better on CC2530+CC2591, can you confirm?

I added LED indicator.

zb_firmware_CC1352P_2.zip

Sure, but please remember that this is "test" firmware, im dont know much about this board. I cant guarantee anything (except that it works in my network). But still power is better on CC2530+CC2591, can you confirm?
Changes:

TX power set to 20
Red LED always turn on

zb_firmware_CC1352P_2.zip

Wich hardware are you using?

@bkupidura - thanks, appears to be working for me.
I have two of these CC2652P routers, and the one flashed with your firmware is reporting approx double the LQI in the same location.
Finger crossed this change makes its way through.

@Alfiegerner my firmware for sure will not be part of "official" zigbee2mqtt firmware available for CC1352P2. As it have some issues with introspection.
But maybe @Koenkk can just introduce two firmwares created by him (5 and 20 DB tx power).

@Alfiegerner @bkupidura Have either of you had any issues since you've been running the modified firmware? I've installed it on a couple of tubes routers the other day and they seem to be working perfectly so far. And pardon my ignorance here @bkupidura , but what did you mean by "issues with introspection"?

No issues from me @cjsteward, looking good. I don't any updates on last seen in the z2m frontend but I don't think I did pre either.  Network map show sitting connections and connected endpoints all good.

@cjsteward board with that firmare is running in my network for last 1.5 month without issue.
Regarding introspection i mentioned, when you are pairing board with zigbee2mqtt, you will see error in log message about missing endpoint.  Except that error, everything else (i hope) is working.

Just wanted to follow up here -  I've been running the modified firmware for over two weeks now and everything is still stable, but I just wanted to call out a few oddities I've noticed:

As @bkupidura mentioned above, I also receive errors on startup:
Zigbee2MQTT:error 2021-05-02 15:04:36: Failed to configure 'New Garage Repeater', attempt 1 (Error: ConfigureReporting 0x00124b00229839f4/8 genBasic([{"attribute":"zclVersion","minimumReportInterval":0,"maximumReportInterval":3600,"reportableChange":0}], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Timeout - 34821 - 8 - 3 - 0 - 7 after 10000ms)   at Timeout._onTimeout (/app/node_modules/zigbee-herdsman/dist/utils/waitress.js:37:35)   at listOnTimeout (internal/timers.js:554:17)   at processTimers (internal/timers.js:497:7))

Link quality is only reported on startup, I believe I read in another thread though that that's a known firmware issue.

Another issue I've noticed is that I haven't been able to pair new devices. I swapped out my CC1352P-2 coordinator for a CC2652P from Tubes around the same time I put these routers into rotation, so I'm not exactly sure what's causing the issue there.

I'm hoping there will be production ready firmware released with the Tx power increase because besides the issues above, I've been really happy with the performance.

@cjsteward regarding pairing issue, i dont think its related to router firmware. As in my network i added new enddevices while router with custom firmware is running.
You can easly test that by just removeing router from network (and powering it off after that, to be sure).

Missed stale bot - I think this would be a great feature.

I'm using a CC1352P-2 LAUNCHPAD.
The coordinator firmware works perfectly on my device.
But when I load @bkupidura 's firmware or firmware from the Z2M Z-STACK Firmware Repo, the device does will not attempt to interview and join the network.
Anyone have any ideas on how I can get my device to interview and pair with my coordinator?

Succesfully flashed the 20dBm variant above and got double the lqi now ... only issue I have is that no matter what I do not a single device will ever join the router even if I specifically put it on top of it ..m

@thiscantbeserious I had the same issue and ended up reverting back to the stable firmware. I hope someone smarter than me can figure this out because besides the pairing issue, the increase in performance and range was really nice. It also seems like a waste having nice routers if they can only perform at 1/4 of their rated power.

Can someone test my router firmware? It supports CC2562 and CC1352P-2, custom LED configuration, etc. I am primarily interested in signal strength.
https://ptvo.info/download/ptvo-firmware-latest.zip

Can someone test my router firmware? It supports CC2562 and CC1352P-2, custom LED configuration, etc. I am primarily interested in signal strength. https://ptvo.info/download/ptvo-firmware-latest.zip

Will do. Give me a week, maybe a day :)

@ptvoinfo can you build firmware which reports rssi to z2m in some (1/5/10m) intervals? Im currently using Conbee as cordinator, and to be honest im not trusting signal strenght reported by z2m.

@bkupidura The coordinator receives RSSI with every message from a device. You can define a virtual output with a virtual pin or an output for a LED pin and enable periodic reports with the necessary interval. But I'm not sure if Conbee can receive messages from a DIY device.

@ptvoinfo what's the difference between psm-cc2652p.hex and cc2652p.hex? Not sure which one to flash.

@ruimarinho You cannot flash these files directly.
It is necessary to configure the firmware for your board.
https://ptvo.info/cc2652r1-cc2652rb-cc2652p-cc1352p2-configurable-router-firmware-748/

@ruimarinho You cannot flash these files directly. It is necessary to configure the firmware for your board. https://ptvo.info/cc2652r1-cc2652rb-cc2652p-cc1352p2-configurable-router-firmware-748/

I have tested your router firmware on multiple cc2652p sticks, including the sonoff, zigstar and a custom router I am working on with a SHT35 and some other sensors. I am seeing a significant increase in LQI across my entire network. It would be hard to give an exact figure but previously my mesh had some distance end device sensors sitting at ~15, currently the lowest is ~70. I was however experience this issue: 10282. Earlier today I re-flashed most of the routers with the newest firmware and all are still responding and pinging as expected.
Just a few things I wanted to comment on...
In your configuration utility all settings are saved between opening and closing the application, except "serial bootloader enable SBL". I ran into an issue as I was going back and forth modifying the firmware a few times, enabled the feature, closed the app, reopened it and only changed a setting on the main page without realizing that this setting does not get saved. Ended up having to flash with jtag, not a huge deal just a minor point.
Unrelated to tx power, but it would also be amazing to be able to configure sensors to use the reporting functionality based on change example (https://www.zigbee2mqtt.io/devices/KMPCIL_RES005.html#kmpcil-kmpcil_res005). This would allow me to configure router devices with less frequent "periodic updates" but still get good sensor values.
As a follow up question, if you do not mind sharing what version of the TI simplelink SDK are you using for these firmwares? I only ask out of interest as I was working on one for the experience.

currently this is not configurable, to change you have recompile: https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/COMPILE.md

FYI, submitted a separate feature request for Zigbee router firmware with remotely configurable TX power output level -> https://github.com/Koenkk/Z-Stack-firmware/issues/341

@ptvoinfo would be great to test a pre-compiled version for TubesZB based on these schematics.

@ptvoinfo would be great to test a pre-compiled version for TubesZB based on these schematics.

I can confirm I am using the firmware on two of those units for a few day now. With the following configuration.. just note in the second image I've blacked out Manufacturer ID, Name, Model and Icon as I have simply just set my own custom information here to make it easier and identify all units in my network running "custom" firmware I have deployed. You should be able to use anything. After simply hit "save custom converter to Z2M" which will generate a converter file that you will need to set in zigbee2mqtt before joining the device. Also do not forget to enable serial bootloader SBL or you will lock the bootloader and need to reflash via jtag.

Thanks @ptvoinfo but I use ZHA so it would probably need its own quirk :/ plus I don't have access to a Windows machine..

Can someone test my router firmware? It supports CC2562 and CC1352P-2, custom LED configuration, etc. I am primarily interested in signal strength. https://ptvo.info/download/ptvo-firmware-latest.zip

Where's the setting for the power output or is it hardcoded to 20?

Can someone test my router firmware? It supports CC2562 and CC1352P-2, custom LED configuration, etc. I am primarily interested in signal strength. https://ptvo.info/download/ptvo-firmware-latest.zip

Where's the setting for the power output or is it hardcoded to 20?

He had confirmed previously on his website that i

Can someone test my router firmware? It supports CC2562 and CC1352P-2, custom LED configuration, etc. I am primarily interested in signal strength. https://ptvo.info/download/ptvo-firmware-latest.zip

Where's the setting for the power output or is it hardcoded to 20?

Set to 20DB atleast for cc2562 https://github.com/ptvoinfo/zigbee-configurable-firmware/issues/75

Can someone test my router firmware? It supports CC2562 and CC1352P-2, custom LED configuration, etc. I am primarily interested in signal strength. https://ptvo.info/download/ptvo-firmware-latest.zip

Where's the setting for the power output or is it hardcoded to 20?

He had confirmed previously on his website that i

Can someone test my router firmware? It supports CC2562 and CC1352P-2, custom LED configuration, etc. I am primarily interested in signal strength. https://ptvo.info/download/ptvo-firmware-latest.zip

Where's the setting for the power output or is it hardcoded to 20?

Set to 20DB atleast for cc2562 ptvoinfo/zigbee-configurable-firmware#75

Interesting double jones'ing

I have tested your router firmware on multiple cc2652p sticks, including the sonoff, zigstar and a custom router I am working on with a SHT35 and some other sensors. I am seeing a significant increase in LQI across my entire network. It would be hard to give an exact figure but previously my mesh had some distance end device sensors sitting at ~15, currently the lowest is ~70. I was however experience this issue: 10282. Earlier today I re-flashed most of the routers with the newest firmware and all are still responding and pinging as expected.

Hi @irakhlin is it now working stable or do you still have disconnections ?
Did you also flashed the coordinator ? or how did you solve the issue with devices routers (eg plugs) ?

Just wanted to report back - I've flashed both Tube's cc2652p router and Sonoff's Dongle Plus with PTVO's router firmware while following the options in @irakhlin post above and everything has been perfectly stable for about a week or so now. I've noticed a significant increase in LQI with my 3 routers (mix of Tube's and Sonoff's), especially after being paired with my Tube's usb cc2652p coordinator that's flashed with the 20 db firmware from Koenkks dev branch. Sensors and routers pair faster and more easily, sensors located at further points in my house and garage are more responsive, Z2M network map loads up quick and accurately, and nothing has dropped off. This is the end game zigbee solution that I've been trying to achieve for literally years.  I can't thank everyone enough for all the hard work that has gone into this project and the firmware. Seriously amazing stuff.

@cjsteward which firmware are you referring to with +20dBm hardcoded? I believe the one posted on the dev branch was +9dBm only.

@cjsteward which firmware are you referring to with +20dBm hardcoded? I believe the one posted on the dev branch was +9dBm only.

@ruimarinho I think he is talking about the ptvoinfo custom firmware configuration tool. I posted a screenshot of the settings I am using for generating that firmware and I can also report my network has been incredibly stable.
@daufinsyd I did not flash my firmware but I did flash all my 'custom' routers and a few usb powered sensors I am working on, all of which are cc2652p chips. The coordinator I am using is tube's ethernet cc2652. For the last week my network has been stable and the firmware provides a very significant increase in LQI. I now believe the issue I was having with routers going offline was due to 3 zigbee powered sensors that where running very old firmware. I am not positive about this but I have removed them from the network and no issues thus far, I will probably know in the next few days.

Thanks @irakhlin. Would be great if you could do a side-by-side test with the firmware compiled by @bkupidura above (link)!

Thanks @irakhlin. Would be great if you could do a side-by-side test with the firmware compiled by @bkupidura above (link)!

@ruimarinho I did not use his specific file but about a month or so ago I did make compile the same firmware with the changes he posted above. I saw an increase in LQI but the issue of not responding to pings/network map requests was very annoying. It also caused significant delay on restarts of zigbee2mqtt. It seemed like it would wait for a ping timeout from all routers running thr firmware before the web ui would start to load.

Fun with higher power zigbee https://youtu.be/4aLxw48ZCQo

@ruimarinho I may be mistaken, and I have no real way to measure it, but I was under the impression that the coordinator firmware defaults to 9 but allows you to set it higher with "transmit_power" in the config file.

@ruimarinho I may be mistaken, and I have no real way to measure it, but I was under the impression that the dev branch coordinator firmware defaults to 9 but allows you to set it higher with "transmit_power" in the config file.
If I'm wrong then I guess I have more improvements to look forward to in the future.

@cjsteward I think the discussion here was regarding various versions of the router firmware. As it stands now that value is compiled into the firmware. There are a few different versions floating around with values from 5db to 20db (for the cc2652p) chips.

@irakhlin  Yeah, the discussion here is for sure focused on the router firmware. I was just responding to ruimarinho because he was asking about the 20db coordinator firmware in the dev branch that I mentioned in my previous post.

I've switched to @ptvoinfo's firmware as well and my network has been rock solid too. I've never had an issue with @bkupidura's one too. I'm using ZHA and a Tubes coordinator and router.

I've switched to @ptvoinfo's firmware as well and my network has been rock solid too. I've never had an issue with @bkupidura's one too. I'm using ZHA and a Tubes coordinator and router.

Red LED always turn on

@bkupidura can you share how you enabled the Red LED?

I'm getting a solid ~190 LQI between my two Sonoff sticks both running 20 dBm firmwares. The router is using PTVO's firmware. I tried a large antenna from a router, as well as the antenna that came with the Sonoff stick, and I couldn't see a difference between them.
The two sticks are between a thick concrete wall and the coordinator is plugged into my server without an extension cable. Still lots of options for better LQI, but 190 is very, very good.

@ruimarinho You cannot flash these files directly. It is necessary to configure the firmware for your board. https://ptvo.info/cc2652r1-cc2652rb-cc2652p-cc1352p2-configurable-router-firmware-748/

Hi @ptvoinfo  can you please help in correct configuration for https://github.com/egony/cc2652p_cc1352p_RF-STAR/tree/main/firmware/router RF-Star Stick? I found pins to be described here:
https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/bin/README.md
ZigStar Stick v4	CC2652P
(RFSTAR RF-BM-2652P2)
CC1352P2_CC2652P_launchpad_*.zip	DIO_15	Only for CH340C ver.	DIO_28: 2.4Ghz
DIO_29: 20dBm PA	DIO_6 (Green)
DIO_7 (Red)
Thank you,
Wojciech

@wojciechczyz , can't we flash fril usb it using koenkk bootloader? Would it overwrite the bl ?

Can someone test my router firmware? It supports CC2562 and CC1352P-2, custom LED configuration, etc. I am primarily interested in signal strength.
https://ptvo.info/download/ptvo-firmware-latest.zip

@ptvoinfo can you maybe build +10 and +20 dBm TX router firmware for new ITead SONOFF ZBMINI-L Zigbee 3.0 Smart Switch?
https://itead.cc/product/sonoff-zbmini-l-zigbee-smart-switch-no-neutral-wire-required/
https://sonoff.tech/product/diy-smart-switch/zbmini-l/
It has been confirmed its radio board uses the exact same model of CC2652P chip as ITead Sonoff Zigbee 3.0 USB Dongle Plus:
https://community.home-assistant.io/t/sonoff-zbmini-l-zigbee-3-0-smart-switch-by-itead-works-without-neutral-wire-and-based-on-cc2652p-so-should-be-a-good-zigbee-router/384644/
PS: Not recieved mine yet but the latest information is firmware ITead is shipping is configured as "End Device" (and not "Router").

latest information is firmware ITead is shipping is configured as "End Device" (and not "Router").

@Hedda, this may be because ZBMINI-L does not have guaranteed power budget, but it can be dependent on what load it is switching (check Shelly Bypass for Shelly 1L). Operating as End Device means lower power consumption -> more stable operation in more use cases. Operating as Router - even more with increased output power - would increase the chance of brownout resets, which would also be more impactful/noticeable when operating as a Router.
ZBMINI (with neutral wire) uses the same chip and does not have these limitations, but for some strange reason none of the router firmwares in this repository work with it - check last part of this comment.

@ptvoinfo @Hedda Is there a version of the firmware for the regular ZBMINI?

@nickwild-999
https://ptvo.info/custom-firmware-for-sonoff-zbmini-01minizb-and-ewelink-switch-zr-02-923/

Thanks @ptvoinfo so if we select the chip type to CC2652R it works? Are there any means of getting your firmware working on the Sonoff S26R2ZB plug too? Problems with this plug are on #10282

Yes, the firmware for cc2652r works. Sorry, but I don't have info about sonoff s26R2ZB.

Sorry, but I don't have info about sonoff s26R2ZB.

FYI, ITead Sonoff S26R2ZB ZigBee Smart Plug is based on radio module with CC2652P (CC2652 P1F) chip and ceramic chip antenna:
https://github.com/Koenkk/zigbee2mqtt/discussions/10909
https://github.com/Koenkk/zigbee2mqtt/issues/10282
https://itead.cc/product/sonoff-s26r2zb-zigbee-smart-plug-uk-de-fr/
https://sonoff.tech/product/smart-plug/s26r2zb/

@Hedda, note that the module on your pictures has exactly the same design flaw/optimization as described in https://github.com/ptvoinfo/zigbee-configurable-firmware/issues/96#issuecomment-1056704722 (ptvo blog post), therefore enabling the power amplifier will result in working chip/FW, but no transmitted packets.

@Hedda, note that the module on your pictures has exactly the same design flaw/optimization as described in ptvoinfo/zigbee-configurable-firmware#96 (comment) (ptvo blog post), therefore enabling the power amplifier will result in working chip/FW, but no transmitted packets.

So to resolve https://github.com/Koenkk/zigbee2mqtt/issues/10282 it then probably very likely that selecting CC2652R chip type in the PTVO firmware configurator will result in a working firmware image on the ITead Sonoff S26R2ZB ZigBee Smart Plug similar to the new Sonoff ZBMINI (01MINIZB) as both use CC2652P (CC2652 P1F) chip model and their radio modules have same design "optimizations"?

@ptvoinfo there have been a few commits on https://github.com/ptvoinfo/zigbee-configurable-firmware but it seems like the changelog on the blog hasn't been updated in a while.
Are any of the most recent commits relevant for the router firmware (in my case, originally Dec 2021)? Thanks.

@ruimarinho All these changes are relevant to my firmware, where you can build a router too.

5dbm, currently this is not configurable, to change you have recompile: https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/COMPILE.md

See issue https://github.com/Koenkk/Z-Stack-firmware/issues/341 for the request + discussion about having a similar feature in Koenkk's Z-Stack Zigbee Router firmware -> https://github.com/Koenkk/Z-Stack-firmware/issues/341


promtool check rules <file> is broken

What did you do?
I have written a rule with a known bad annotation
groups:
  - name: example-rule
    rules:
      - alert: example-rule
        annotations:
          summary: "{{$label.foo}}"
        expr: up==1
        for: 1s
        labels:
          severity: high

When I run with 2.46 it shows no error
~/Downloads/prometheus-2.46.0.darwin-arm64/promtool check rules tmp.rule.yml
Checking tmp.rule.yml

When I run with 2.45 it shows the error
~/Downloads/prometheus-2.45.0.darwin-arm64/promtool check rules tmp.rule.yml
Checking tmp.rule.yml
  FAILED:
tmp.rule.yml: group "example-rule", rule 1, "example-rule": annotation "summary": template: __alert_example-rule:1: undefined variable "$label"

I suspect the changes in https://github.com/prometheus/prometheus/pull/12225 are the source of the issue.
https://github.com/prometheus/prometheus/blob/f676d4a756f6833ba2694b2c6600259ff3c62533/cmd/promtool/main.go#L729-L733
ParseFile already validates the rules and detects the answer, but because the error check here immediately sets failed = true and then continue, there is no opportunity for the error messages to be printed out.
What did you expect to see?
~/Downloads/prometheus-2.45.0.darwin-arm64/promtool check rules tmp.rule.yml
Checking tmp.rule.yml
  FAILED:
tmp.rule.yml: group "example-rule", rule 1, "example-rule": annotation "summary": template: __alert_example-rule:1: undefined variable "$label"

What did you see instead? Under which circumstances?
~/Downloads/prometheus-2.46.0.darwin-arm64/promtool check rules tmp.rule.yml
Checking tmp.rule.yml

System information
Darwin 22.5.0 arm64
Prometheus version
~/Downloads/prometheus-2.46.0.darwin-arm64/promtool --version
promtool, version 2.46.0 (branch: HEAD, revision: cbb69e51423565ec40f46e74f4ff2dbb3b7fb4f0)
  build user:       root@a12703ef1de3
  build date:       20230725-12:36:56
  go version:       go1.20.6
  platform:         darwin/arm64
  tags:             netgo,builtinassets,stringlabels

Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Doing an additional test, it appears the exit code is also incorrect.
❯ ~/Downloads/prometheus-2.46.0.darwin-arm64/promtool check rules < tmp.rule.yml
Checking standard input
group "example-group", rule 1, "example-rule": annotation "summary": template: __alert_example-rule:1: undefined variable "$label"

❯ echo $?
1

❯ ~/Downloads/prometheus-2.46.0.darwin-arm64/promtool check rules  tmp.rule.yml
Checking tmp.rule.yml

❯ echo $?
0

Thanks! Are you willing to send a PR?

I can give it a shot though Go isn't my primary language, so it often takes me a bit longer to figure out a clean solution.

/assign

I submitted a PR(#12715 ) to fix this and added some test cases.
This is the result of the unit test:


Access to JdbcAsyncWriteJournal

I see that the ReadJournal is exposed, but how would I access the write journal?
I'd assume it needs to be accessible for @ktoso's recent feature in https://github.com/dnvriend/akka-persistence-jdbc/pull/183 to allow for updates. Is it currently accessible, and I just don't see how I would do so without creating a class in package akka.persistence so I can use the internal method akka.persistence.Persistence.journalFor(), or is that portion of the feature not figured out yet?
I definitely understand why this wouldn't be exposed: Although the class isn't private, its effectively an internal API; I shouldn't be able to raw-insert into the DB without utilizing the PersistentActor interface. I want to do so to support a DB migration. I already have PersistentActor data in a different data store, and I want to explore the performance of my system if it were using Postgres. To do so, I want to push all my existing data into Postgres, and if I use the JdbcAsyncWriteJournal to do so, I'll have confidence that it is in the correct format for the JdbcReadJournal to read.

It's not a feature that should be used across the board really so it is intentionally not super exposed.
Yes, reaching into the journalFor is the strategy.

You state that you want to do a db migration, are you migrating from one jdbc database to another? Or are you migrating from a different akka-persistence journal plugin?
In the first case you can see if the source database supports dumping the contents of the journal table in a format which the target database supports. If this is not the case then maybe you can use slick to query the JournalRows in the source database and insert these in the target database.
In case of different akka-persistence the following might be options:

Query the data, and see if some of the existing library code can be used to convert the data to a PersistentRepr, the ByteArrayJournalSerializer can serialize this to JournalRow which can be inserted using slick.
Perhaps you can combine the currentPersistenceIds query with the  currentEventsByPersistenceId query,  so that you can send the events to a persistent actor again which stores the events using akka-persistence-jdbc

Note that the global event ordering (which determines the order for the events by tag query) is generated using a database sequence, so the order of inserting in the database determines the global event ordering. If you care about this then you should ensure that events are inserted in the correct order. (you should definitely make sure that events for each persistenceId are inserted in the correct order)

I am trying out a migration from a Cassandra akka-persistence implementation. I had considered using the highest-level interface the most likely for integration success, which is why I targeted the write journal, but you're right, I'll probably be fine just using the Serializer and doing the insert myself.
I'm explicitly trying not to use a persistent actor because I want to ensure my sequence number (at least per entity) to be the same in both DBs. I can probably ensure that by inserting in the same order, but I'd feel more confident about it if I utilized the existing sequence number.
I'd love for global event ordering to be at least similar, but it's not absolutely necessary. For data truncation, I will want a way to identify old data, which I could use sequence number if I insert in the same order.
Thanks for the simpler idea and for being a sounding board.


[Bug] Query Builder count() return wrong number with groupBy()

Using Query Builder count() with groupBy() doesn't return the correct number of rows, not considering the group by condition
I just made an example to show the problem
consider following table and code:

id
cat
desc

1
1
abc

2
1
abc

3
2
abc

$count = DB::table('product')
    ->where('cat', 1)
    ->groupBy('cat')
    ->count();

var_dump($count);

$count = DB::table('product')
    ->where('cat', 1)
    ->groupBy('cat')
    ->get();

var_dump(count($count));

Output:
int(2)

int(1)

I have this problem too.
What should I do?

This is already fixed in laravel 5.

what should I do for 4.2 ?
Thanks

Its not difficult to upgrade to 5/5.1.

@GrahamCampbell I have a similar Issue with v5.1.16:
public function points()
{
    return $this->hasMany('Point')->orderBy('index', 'asc')->groupBy('id');
}

var_dump($annotation->points()->count()); // int(1)
var_dump(count($annotation->points()->get())); // int(2)

So points()->count() returns 1 although there should be two elements. Grouping by the ID was a workaround because otherwise I got an SQL error SQLSTATE[42803]: Grouping error: 7 ERROR: column "points.index" must appear in the GROUP BY clause or be used in an aggregate function when trying thinks like points()->max('index').

this is not fixed in 5.2.35
if I use $query->count() with a groupBy, this count will be the first item's count, not total count.

@steve3d yeah,I have the same problem,when i use count method after groupBy method,I get 1,but actually it has 77.How to solve it.

This is still an issue with 5.5.16
I've had to get around this by running a separate query
SELECT FOUND_ROWS()

Also very confusing: If I have some model and call \App\SomeModel::findOrFail(100)->count(), I will get the number of elements of SomeModel in total, although 1 should be the intuitive answer.

I have the same issue like that
I want to count the same name but it retrieve as the data below

This is my table datas as I labeled that what I want to be output

Instead of the result of the first picture I want to output like this but how i can do that ?

this is my code ..
$salaryRate = DB::table('alumni_tracers')
->select(DB::raw("count() as count"), 'grad.')
->join('graduate_per_courses as grad', 'grad.program', '=', 'alumni_tracers.course')
->leftjoin('graduate_per_courses as gradd', 'gradd.year', '=', 'alumni_tracers.year_graduated')
->groupBy('program')
->get();
hope you help me guys ..

this has been buggin me for the past 3 hours, i was going nuts thinking something wrong in my search. Is there a workaround for this yet?

i dont think i would even call it a workaround. the way to get the result people seem to want is to use distinct rather than group by

Here's the "eloquent" way to work around this issue:
            $realCount = DB::query()->selectRaw(
                    sprintf(
                        'COUNT(*) count FROM (%s) agg',
                        $mainQuery->select('id')->toSql()
                    ),
                    $mainQuery->getBindings()
                )->value('count');

thanks @shababhsiddique

The problem still exists

Still exists

Still exists.

I can't even get the originally example to work properly. Please open up a new issue with all the information needed to re-create this: migrations, code, models, etc.


OnHttpRequestBody in websocket connections has previous message

Describe the bug / error
I'm trying to log messages in websocket and I'm getting from proxywasm.GetHttpRequestBody body which contains only previous messages, not actual. And last message can't be retrieved.
What is your Envoy/Istio version?
envoy  version: dc7f46eb44e54d5646301aa5ab4ba01f662fdf75/1.21.2/Modified/RELEASE/BoringSSL
What is the SDK version?
v0.18.1-0.20220510133519-6240ca761207
What is your TinyGo version?
tinygo version 0.23.0 darwin/amd64 (using go version go1.18.2 and LLVM version 14.0.0)
URL or snippet of your code including Envoy configuration

Extension code https://gist.github.com/dkeysil/b0c7d7709e814788b2ef915468d8253b
Evnoy config https://gist.github.com/dkeysil/b0c7d7709e814788b2ef915468d8253b#file-websocket-yaml

Additional context (Optional)
messages to websocket:
websocat ws://<IP_ADDRESS>:10000
qwe
ewq
^C

envoy logs:
[2022-05-24 19:48:22.171][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: ON HTTP REQUEST BODY
[2022-05-24 19:48:22.171][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: BODY SIZE ctx=0 overall=0
[2022-05-24 19:48:22.171][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: NEXT MESSAGE []
[2022-05-24 19:48:22.171][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: WAITING FOR NEW MESSAGE
[2022-05-24 19:48:31.402][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: ON HTTP REQUEST BODY
[2022-05-24 19:48:31.402][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: BODY SIZE ctx=0 overall=10
[2022-05-24 19:48:31.402][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: DECODED MESSAGE qwe
[2022-05-24 19:48:31.402][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: NEXT MESSAGE []
[2022-05-24 19:48:31.402][1274945][info][wasm] [source/extensions/common/wasm/context.cc:1172] wasm log: WAITING FOR NEW MESSAGE

Found that for websockets use OnHttpRequestBody without types.ActionPause


UncontrolledAccordion?

Would be great to have a version of UncontrolledCollapse or perhaps more specifically an UncontrolledAccordion. Especially one that does something similar to bootstrap's data-parent:

To add accordion-like group management to a collapsible control, add the data attribute data-parent="#selector". Refer to the demo to see this in action.

https://v4-alpha.getbootstrap.com/components/collapse/#accordion-example
Right now I'll have to handle the mutually exclusive state logic myself.

recompose is extremely useful for this, once you wrap your head around the API.
For instance, for an uncontrolled tooltip:
const StatefulTooltip = compose(
  withState("isOpen", "setOpen", false),
  withHandlers({
    toggle: ({ isOpen, setOpen }) => () => setOpen(!isOpen)
  }),
  mapProps(({ setOpen, ...rest }) => rest),
)(Tooltip);

(I know Reactstrap provides an uncontrolled tooltip, but this pattern can apply to any controlled component).

Accordion is essentially multiple Collapse components working together to ensure only one is open at a time. Not 100% sure how to make it uncontrolled in a similar way as the other uncontrolled component even with recompose in the mix.
An Accordion component may be needed to act as the controller on the children collapse.
BS4 uses data-parent to indicate that a collapse is apart of the accordion. This helps nested collapse components within the accordion not be apart of the accordion. Interesting things happen: https://codepen.io/TheSharpieOne/pen/qXdqbb so we cannot simply say any Collapse under an Accordion is part of the Accordion.

I'm just curious why there is no UncontrolledCollapse?

You can create an UncontrolledCollapse with a HOF. No other dependencies necessary.
import React, { Fragment, Component } from 'react';
import { Collapse } from 'reactstrap';

const createUncontrolledCollapse = (Toggler) =>
	class UncontrolledCollapse extends Component {

		state = {
			isOpen: false
		};

		toggle = () => {

			this.setState(({ isOpen }) => ({ isOpen: !isOpen }));

		};

		render () {

			return (
				<Fragment>
					<Toggler onClick={this.toggle} />
					<Collapse isOpen={this.state.isOpen} {...this.props} />
				</Fragment>
			);

		}

	};

export default createUncontrolledCollapse;

Then just use it:
export default () => {
		const UncontrolledCollapse = createUncontrolledCollapse((props) =>
I am the toggler
);
		return (
			<UncontrolledCollapse>

I am the collapsible content

			</UncontrolledCollapse>
		);
}

Yes, please!

Merged! This issue should now be closed.

@TheSharpieOne someone made an accordion using reactstrap Collapse  => https://coreui.io/react/demo/#/base/collapses
Maybe we can borrow the idea from there ?

They end up managing the state manually (seen here: https://github.com/coreui/coreui-free-react-admin-template/blob/master/src/views/Base/Collapses/Collapses.js) which is the only way to do it currently. Ideally it would be easier that needing all of that extra code.
We probably need an accordion component which controls n number of Collapses and then we can make that thing uncontrolled.
The accordion component would probably work similar to how Tabs work, and then we can make that uncontrolled as well as Tabs in a similar way.

https://gist.github.com/iamandrewluca/3f760b9218e926e1c4230a1ae3b025be

So does the gist above not correctly address the issue ?

@MichaelRWalker why not? Here is a sandbox
https://codesandbox.io/s/reactstrap-accordion-7xchb

@iamandrewluca  My mistake for not being more clear.
I meant your Gist is a good solution for the problem. i was more curious if it was going to be added to a PR
I actually just used a regular 'bootstrap' styled div with the class 'accordion'
<


Consolidated Security Updates for 2.0.12

Consolidated Security Updates for 2.0.12

Apply three-strikes rule to all transaction failures
Apply unconditional subjective CPU check along with some additional logging
Provide options to enable subjective CPU billing for P2P and API transactions ,and provide an option to disable it for individual accounts

Co-Authored-By:Kevin Heifner<EMAIL_ADDRESS>Co-Authored-By:Lin Huang<EMAIL_ADDRESS>

Discard this PR as branch name starts with release/, which causes buildkite/mirror-eosio failed.


Handling Array (Variant) objects from Snowflake

Hi,
First of all thanks for developing this library, it is much better than default one in my opinion!
I was testing it and tried to query Snowflake ARRAY type into C# List, but received
System.Text.Json.JsonException '0x0A' is invalid within a JSON string. The string should be correctly escaped.

Is there a way to overcome this using Options or the fix should be added to Mapper?

Thank you for your bug report!
I have just fixed this bug, now it should properly map array, variant and object types.
This will be included in the next release of a NuGet package soon - I just need some more time to do some additional tests.
But you already can use fixed version directly from master branch.

Thank you for your bug report!
I have just fixed this bug, now it should properly map array, variant and object types.
This will be included in the next release of a NuGet package soon - I just need some more time to do some additional tests.
But you already can use fixed version directly from master branch.

@vostruk, I've included this fix into latest NuGet release - Snowflake.Client 0.3.1.
Can you please try this version and approve, that mapping from array now works properly?

@vostruk, I've included this fix into latest NuGet release - Snowflake.Client 0.3.1.
Can you please try this version and approve, that mapping from array now works properly?

@fixer-m, yes array mapping works well now. Thanks a lot for solving that!
Also I found another bug related to it (could set a new issue if needed) - when using complex objects (like List) in sqlParams the error is thrown.
For example performing an insert with something like:
await snowflakeClient.ExecuteAsync("INSERT INTO EMPLOYEES EmploymentsList VALUES (:EmploymentsList);", new { EmploymentsList = new List<string> {"Programmer"} });

Causes an error in SnowflakeClient.cs like 137 (BuildQueryRequest method)
I understand where i may come from, since filtering on such objects may not be needed. But inserts of complex objects is quite common thing, at least in my case.
Would be great if we can solve this problem too.

@vostruk Great!
Can you please create a new separate issue for this? This is completely unrelated to original mapping issue, new one is related to Parameter Binding feature.
Then I can close this bug.

Done, let's close this one. Thanks for solving!


Choose archetype:    Your filter doesn't match any archetype

I don't know what to input here. I'm trying to install via my mac terminal as per the instructions.
Choose a number or apply filter (format: [groupId:]artifactId, case sensitive contains): :

No archetype defined. Using maven-archetype-quickstart (org.apache.maven.archetypes:maven-archetype-quickstart:1.0)
Choose archetype:
Your filter doesn't match any archetype (hint: enter to return to initial list)
Choose a number or apply filter (format: [groupId:]artifactId, case sensitive contains): :
I'm on a ubuntu 18.04 and not sure what to input here. Also tried other flags: -DarchetypeCatalog=local, internal, remote but doesn't seem to fit the instructions. Does anyone have any suggestions? thanks.


[Backend/Prepdocs] Update to latest version of search SDK

Purpose
This PR updates search to latest version of SDK.
Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe:

How to Test

Existing tests still work
local server works with existing environment
./scripts/prepdocs.sh works with existing environment
azd deploy works with existing environment (pending)

Typing fail! Will fix tomorrow.


Update README.md

Warning added to README to inform users that our Docker stuff is not currently working, for Islandora-CLAW/CLAW#377

@manez @ruebot @whikloj does this qualifies as docker? Do we need a rewording maybe?


Investigate memory leak in prod

A little while ago, I deployed prod and noticed that we were not getting through a full enforce loop. Looking at memory usage there seemed to be a memory leak which was causing allstar to crash before completing a loop. I took a look at the changes between the last two prod pushes and only two seems like they could cause any changes: #345 and #347.
I tried to reproduce the memory leak both in staging and on a personal test instance without any luck. Therefore, I rolled back those two changes with #357, and the leak was fixed.
I need to try to apply the original two changes individually to prod to see which one is the issue, then debug the memory leak.

@jeffmendoza As 4.10.5 is now released, it might make sense to add back the changes and update to 4.10.5 to see if the issue might have been fixed since 4.10.2.

Any idea when this might be fixed @jeffmendoza ? Sorry to push, but scorecards is currently broken on all private repos due to the old version we're using.

Ah, I hadn't prioritized it as I thought the old version of scorecard was working ok. Sorry about that.
I created a new branch https://github.com/ossf/allstar/tree/prod-temp to deploy prod from to not have churn on main. I  deployed the vuln client and will watch it over the weekend and see if it is running out of memory, next I'll try the latest scorecard.
So far the vuln client is looking ok:

Which doesn't bode well for the scorecard update. I might have to do a binary search on the scorecard version releases to find out which one is breaking us.

Thanks @jeffmendoza , how is the scorecard update looking?

Just removed the vlun client and left it disabled, then updated to v4.10.2:

Going to try v4.10.5 now, then if that is not working, try some of the versions between 4.5 and 4.10

I've deployed a ton and found the change that causes the problem:
https://github.com/ossf/scorecard/commit/9a9a1cbbb79a32ec23d51ddc6aaa06632de0d58e
Not a leak per-se, but an overuse of memory. We call in here: https://github.com/ossf/allstar/blob/main/pkg/scorecard/scorecard.go#L105 And the transport comes from the github client which we create here: https://github.com/ossf/allstar/blob/main/pkg/ghclients/ghclients.go#L102
The transport has the auth already setup which is what we need to pass to scorecard (we don't set any kind of github token env var for scorecard). It also has caching in place for all the calls we do to to the API.
Looks like the change uses the client for tarball downloads, so now our in-memory cache is trying to save the tarballs of many thousands of repos, which is not going to work.
Seems like we have a few areas to investigate

Can we pass an authenticated but non-cached transport to scorecard
Can we tweak our caching package to not cache the large tarballs.
Should we be calling / using scorecard in a different way to provide auth, but not try to cache tarball downloads.

Thanks @jeffmendoza . One thing I spotted looking at the code is that the scorecard Close function is never called on an error in the enforcer loop, I think I fixed this here: https://github.com/ossf/allstar/pull/403
I doubt this is the cause of the memory issue, but maybe you could test with it?

Sounds good, I'll test that as well. Prod does have a number of installations that hit errors.

Any improvement with the PR @jeffmendoza  ?

Can we pass an authenticated but non-cached transport to scorecard

What led to the cache being used in the first place, or rather would using a non-cached transport with scorecard still have any benefits?

Can we tweak our caching package to not cache the large tarballs.

Would that just involve ignoring certain files here?
https://github.com/ossf/allstar/blob/d199777fe882b0eae837fe9601ad67ec98643761/pkg/ghclients/memorycache.go#L52-L62
Scorecard stores its files in /tmp folders using some defined patterns.
https://github.com/ossf/scorecard/blob/46c6fe700cdc10a780f3c867b36b6810e1986cb0/clients/githubrepo/tarball.go#L138-L144
Where the patterns used are:
	repoDir      = "repo*"
	repoFilename = "githubrepo*.tar.gz"

So for a given repo you may see the tarball downloaded to:
/tmp/repo2046618022/githubrepo2124655200.tar.gz

Should we be calling / using scorecard in a different way to provide auth, but not try to cache tarball downloads.

As of right now alternatives to how you're interacting with scorecard clients. Theres no customization for using different transports used for different private handlers inside the client.
If it were necessary for a change on our end to allow using a different transport for the tarball download, I would imagine using a "functional options" pattern to set the tarball http client separately (which may expose some of the implementation details that we're hiding away).
This would bring us back to your first point of " Can we pass an authenticated but non-cached transport to scorecard" except only applied to the tarball handler.

What led to the cache being used in the first place, or rather would using a non-cached transport with scorecard still have any benefits?

Passing the cached transport to Scorecard was a side-effect of needing to pass a pre-authenticated transport. Allstar does a lot of API calls and passes around an authenticated and cached github client to do so. We pull the transport out of the client and pass to Scorecard because it is convenient. It is not critical that the Scorecard API calls are cached, I believe they are minimal, and the most-used checks are just based on the tarball download, and not API calls.

Would that just involve ignoring certain files here?

Yeah, that could work, I believe the key is the url path, there could be a glob/regex to avoid caching tarballs there.

@jeffmendoza Did my PR make any difference to the memory consumption?

Ah, no unfortunately. It the caching we do on our side, not the Close() needed for the scorecard side.


Added SSL Cert Parameters to Redis Tracker Store

Proposed changes:

Added optional ssl_keyfile, ssl_certfile, and ssl_ca_certs parameters to the Redis tracker store.

Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ben Q seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: b-quachtran:x: Ben QBen Q seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing this PR and going to re-open another because of the commit author problem


SynchronousFuture behavior is different depending on the SDK

The behavior of a SynchronousFuture is different dependeing on whether the Dart SDK or Flutter SDK is used. The Dart SDK  executes immediately, but the Flutter SDK does not:

SynchronousFuture with Flutter SDK
Synchronous Future with Dart SDK

It looks like this only happens when a Flutter app is compiled to JS:

Platform
sync
async

Web (Dart)
X

Web (Flutter)

X

VM (Dart)
X

VM (Flutter)
X

FYI @yjbanov

Update: this is only happening with DDC.

I'm surprised that we're able to subvert the asynchrony of await on any platform...
@lrhn - were you aware of this behavior?

It's unsurprising that things break when you implement Future incorrectly. Since await is defined in terms of calling then, and then is specified as not calling the callback during the then call, weird things happen if you do so anyway. We don't (necessarily) add extra overhead to try to avoid implementations of Future which are broken.
We also don't try to keep our implementations bug-compatible. If your Future doesn't behave like a proper future, we can go off the rails in different ways on different platforms.
Basically, it's unspecified behavior. If it hurts, stop doing it.
Nothing prevents you from creating a Stream which calls its event callbacks after you've called cancel, or after sending a done event, or sending more than one done event, or creating a future which calls the then callback more than once, or both the data and error callbacks. It breaks assumptions that other code might be based on, and the behavior of the platform is undefined if you do so. Same if your Future calls the callback in during the call to then.

Related to https://github.com/flutter/flutter/issues/82827

Thanks for the discussion here. Going to close in favor of the other linked issues as well as stale since all DartPad runs now consistently use DDC and the Flutter SDK.
If there's anything you'd like to see DartPad change still, please open a new issue with some more details. Thanks!


fix: androidX bug

fixes androidX bug
The Example App project was not setup for AndroidX.
This PR adds the gradle.properties configuration to enable it.

@Harshit933 there is rule from the root .gitignore that includes the *.properties:
https://github.com/Harshit933/tiki-sdk-flutter/blob/9494c857714781ba7039e1fc5831599f330bd6e2/.gitignore#L48
It make the publishing of the package fail.
https://github.com/tiki/tiki-sdk-flutter/actions/runs/4135768894/jobs/7148848387#step:7:189-201
I don't know if this rule was auto created or if we added that later. I will check it later.
For now, could you please add an exception in the .gitignore of the example_app for the specific file you have committed?

done

Thank you @Harshit933. Nice job!


Plugins which require chat input are not compatible with HuskChat

It has been observed, that any plugin (verified with CommandPanels and BankPlus), which requires chat input is not compatible with HuskChat. Input from the chat is completely ignored.
Preconditions:

HuskChat installed
any plugin that requires chat input, eg. BankPlus (https://www.spigotmc.org/resources/✨-bankplus-✨.93130/) installed
op account

Repro Steps:

Login to the server.
Type /bank.
Click Deposit-Custom.
Type the amount of money to deposit.
Observe the issue as the number is ignored.

Due to HuskChat being a proxy plugin and handling chat on the proxy, it is incompatible with plugins that require chat input.
However, there is a workaround. HuskChat has channel scopes which allow you to select how a message is handled. Create a new channel, setting it up with the PASSTHROUGH broadcast scope. Players on your server can then use the following steps to interact with plugins that require chat input:

Switch to the passthrough channel (/channel <channel id> or the channel's shortcut command, if configured)
Type /bank (or whichever command requires chat input), etc.
Type the amount in chat
Switch back to the channel the player was chatting in earlier (by default, this is the global channel which can be used by typing /g)

^^
Please check our dedicated documentation page for more on this matter: https://william278.net/docs/huskchat/Backend-Chat-Entry


[Verticles][Roles Management] Allow multiple role management restriction on endpoints

I was working on implementing new roles for new screen that are coming for Tock.
The idea was i wanted to allow some endpoints accessibles for multiples roles, in case we want to have our own endpoint role management.
Plus there a code duplication with /sentences/dump/:dumpType/:applicationId with admin and technicalAdmin in AdminVerticle.kt

fixed by #1350


Arcade Stick version?

Is it possible to make an arcade stick version for this? Basically the same thing, but using C and Z buttons instead of L and R triggers, since digital inputs are better than analog for arcade sticks and games. It would be fantastic if this were possible!

Hi! Sure, that's easy. If you don't need VMU LCD functionality, it might be easier for you to start from Charcole's original Pop'n Music controller code, since you wouldn't have to strip out MaplePad's analog stick/trigger code. Either way the edits would be similar.
First you'd need to make some changes to the main controller InfoPacket:
void BuildInfoPacket()
{
	InfoPacket.BitPairsMinus1 = (sizeof(InfoPacket) - 7) * 4 - 1;

	InfoPacket.Header.Command = CMD_RESPOND_DEVICE_INFO;
	InfoPacket.Header.Recipient = ADDRESS_DREAMCAST;
	InfoPacket.Header.Sender = ADDRESS_CONTROLLER_AND_SUBS;
	InfoPacket.Header.NumWords = sizeof(InfoPacket.Info) / sizeof(uint);

	InfoPacket.Info.Func = __builtin_bswap32(FUNC_CONTROLLER);
	InfoPacket.Info.FuncData[0] = __builtin_bswap32(0x000f06fe); // What buttons it supports
	InfoPacket.Info.FuncData[1] = 0;
	InfoPacket.Info.FuncData[2] = 0;
	InfoPacket.Info.AreaCode = -1;
	InfoPacket.Info.ConnectorDirection = 0;
	strncpy(InfoPacket.Info.ProductName,
			"Dreamcast Controller          ",
			sizeof(InfoPacket.Info.ProductName));

	strncpy(InfoPacket.Info.ProductLicense,
			// NOT REALLY! Don't sue me Sega!
			"Produced By or Under License From SEGA ENTERPRISES,LTD.     ",
			sizeof(InfoPacket.Info.ProductLicense));
	InfoPacket.Info.StandbyPower = 430;
	InfoPacket.Info.MaxPower = 500;

	InfoPacket.CRC = CalcCRC((uint *)&InfoPacket.Header, sizeof(InfoPacket) / sizeof(uint) - 2);
}

This is the Maple packet the controller sends to the Dreamcast to identify itself. InfoPacket.Info.FuncData[0] should be updated to indicate the buttons the Arcade Stick supports (Dpad, ABXYCZ, Start) based on Sega's official Arcade Stick documentation (05_Svs090e.doc in Kochise's dreamcast-docs). It's also wise to match Sega's spec for the ProductName and Power fields, just to be safe.
Then you'd just need to update the buttons themselves-- increase the NUM_BUTTONS macro to 11, and add the new buttons (including the GPIOs you wire them to, and their bitmask as per Sega's controller docs) to the ButtonInfo struct. You can see the unused C button left over from Charcole's Pop'n Music controller below.
static ButtonInfo ButtonInfos[NUM_BUTTONS]=
{
	{ 0, 0x0004},	// Red centre, A
	{ 1, 0x0002},	// Green right, B
	{ 4, 0x0400},	// Blue right, X
	{ 5, 0x0200},	// Yellow right, Y
	{ 6, 0x0010},	// Yellow left, UP
	{ 7, 0x0020},	// Green left, DOWN
	{ 8, 0x0040},	// White left, LEFT
	{ 9, 0x0080},	// Blue left, RIGHT
	{ 10, 0x0008}	// White right, START
	// { 13, 0x0001}	// White right, C
};

Finally, if using MaplePad's codebase, you would need to remove or comment out all the analog stick and trigger code in SendControllerStatus(), so it doesn't mess up the packet checksum. If you use Charcole's original codebase you don't have to worry about this.
Hopefully that answers your question. If you'd like me to make a branch of MaplePad with these changes, let me know and I'll see what I can do!

I have no coding experience, so I think I'd mess it up pretty easily if I tried to do it myself! It would be perfect if you could make a branch for the Arcade stick version!

i forked this and did a version with L and R as buttons instead of triggers.
https://github.com/ez2torta/MaplePad/

Exactly what I needed! Thank you!! I'll be trying this out soon!

I've been including an HKT-7300 binary in each release, so I'm going to close this. Saw on Twitter you made an arcade stick with it!  Very cool!


Use latest formatter to fix token name collision

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

:tada: This PR is included in version 12.0.0-beta.12 :tada:
The release is available on:

GitHub release
npm package (@beta dist-tag)

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Term(d::AbstractDecapode) should avoid expanding operators

That way we don't mangle nice decapodes by converting them to SSA.

@jpfairbanks  #16 resolves this issue


Docs: Added a hyphen to "database-generated"

Hey @bcail, "database generated" is a correct term, I don't see a gain in making the change you are suggesting. And changing strings at this point would increase the translators works, so I'll be closing for now, but let me know if there is another reason for this change that I'm missing.


a11y-high-contrast-light errors showing up in Sphinx on main

I am trying to get some improvements into the sphinx-book-theme  using main from this theme, and finding this error message that keeps popping up:
E         + WARNING: Color theme a11y-high-contrast-light not found by pygments, falling back to tango.
E         + WARNING: Color theme a11y-high-contrast-dark not found by pygments, falling back to monokai.

Any idea why this would be happening? cc @drammock who authored the PR where I believe these were added:

https://github.com/pydata/pydata-sphinx-theme/pull/1064

Ah I think this is because we only installed the accessible-pygments package in our doc environment, it's not a dependency:
https://github.com/pydata/pydata-sphinx-theme/pull/1064/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R54
My feeling is that we want the default install to not build with any warnings, so we should either make accessible-pygments a dependency of the theme, or we should remove the warning and default to not using accessible-pygments.

oops.  yeah, I think you've diagnosed correctly. I should have added it as a full dependency, not just for doc.

i'll open a quick PR


bimpm is too slow

thanks for your great work.
but when I run bimpm.py with 1080 ti, the train speed is very low.I want to know whether it is common situation? I know this model is compalicated

I agree that it's a bit slow, I also had this problem with the same GPU. If you manage to make it faster, I'd be happy to merge PRs 😄 .
Closing for now, reopen if you have further questions.


Code=40 "Message too long" Error

Description
my app is uploading videos to Firebase storage and it was working fine until 1 hour ago. Now it is giving error that says "Code=40 'Message too long'". I did not change anything and the video I want to upload is 15 seconds and 1.2 mb.
Reproducing the issue
No response
Firebase SDK Version
10.29.0
Xcode Version
15.4
Installation Method
Swift Package Manager
Firebase Product(s)
Storage
Targeted Platforms
iOS
Relevant Log Output
Task <68C7A14A-0620-40E0-A095-72DE0A62A9A8>.<1> finished with error [40] Error Domain=NSPOSIXErrorDomain Code=40 "Message too long" UserInfo={_NSURLErrorFailingURLSessionTaskErrorKey=BackgroundUploadTask <68C7A14A-0620-40E0-A095-72DE0A62A9A8>.<1>, _kCFStreamErrorDomainKey=1, NSErrorPeerAddressKey={length = 16, bytes = 0x100201bbacd9116a0000000000000000}, _kCFStreamErrorCodeKey=40, _NSURLErrorRelatedURLSessionTaskErrorKey=(
    "BackgroundUploadTask <68C7A14A-0620-40E0-A095-72DE0A62A9A8>.<1>",
    "LocalUploadTask <68C7A14A-0620-40E0-A095-72DE0A62A9A8>.<1>"
)}

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Thanks for reporting, @yildirimatcioglu. It's possible that this might be an intermittent issue. May I know if you're still seeing the same issue? If so, is the issue also reproducible using other network or device? A reproducible example would also be great in order investigate.


Updated version to 0.3.0

We should change the version and upload the package to NuGet because of the library changes (.NET Standard 2.0).

version 0.3 is published to NuGet


Using Textures Causes Fatal errors

Fixed in Latest Commit,
i was using GL_UNSIGNED_INT instead of GL_UNSIGNED_BYTE, so GL was trying to access nonexistent memory


Default toolbar location is incorrect

By default the toolbar is shown in the wrong location.

We were able to resolve the issue by changing this code in example_editor.dart from:
docBox.localToGlobal(docBoundingBox.topLeft, ancestor: context.findRenderObject()),
docBox.localToGlobal(docBoundingBox.bottomRight, ancestor: context.findRenderObject()),

To:
docBox.localToGlobal(docBoundingBox.topLeft),
docBox.localToGlobal(docBoundingBox.bottomRight),

Thanks for the great package!

Hi @hillelcoren . I couldn't get it reproduced. Can you provide code snippet or more information about this?

Hi, thanks for looking into the issue!
I'm not sure, in the screenshot above I'm using a row which contains multiple Scaffolds. Maybe it's related?

@override
  Widget build(BuildContext context) {
    return Row(
      children: [
        const SizedBox(
          width: 200,
          child: Scaffold(
            backgroundColor: Colors.red,
          ),
        ),
        Expanded(
          child: Scaffold(
            body: Column(
              children: [
                Expanded(
                  child: _buildEditor(),
                ),
                if (_isMobile) _buildMountedToolbar(),
              ],
            ),
          ),
        ),
      ],
    );
  }

The code snippet above still doesn't produce the issue. It is modified from the example_editor.dart file. Do you mind giving me the widget's hierarchy related to this?

@hillelcoren do you have multiple editors on one screen? That could potentially lead to the issue.

Yes, we're using two editors in a column.

It is true that the location of the toolbar is incorrect when having multiple editors on a screen, and your solution does fix that.
Is there any issue you're having with the toolbar's location when using the solution you found?

Not that I'm aware of.
Thanks for tracking down the issue.


hash: add hash function from aki

this includes a test. It needs a fix in the formatting: what is %z%u in the
plan 9 world?
Signed-off-by: Ronald G. Minnich<EMAIL_ADDRESS>

size_t x = ...;
ssize_t y = ...;
printf("%zu\n", x);  // prints as unsigned decimal
printf("%zx\n", x);  // prints as hex
printf("%zd\n", y);  // prints as signed decimal

It's a C99 addition, but really it can be removed.


tour: Slices: slicing a particular range of an array does not work

Context: https://tour.golang.org/moretypes/7
Code: https://play.golang.org/p/wdLUlXigcv
Expected: [3, 5, 7, 11, 13]
Change the title above to describe your issue and add your feedback here, including code if necessary

Your code run as expected if I run it.
That is
package main

import "fmt"

func main() {
	primes := [6]int{2, 3, 5, 7, 11, 13}

	var s []int = primes[1:6]
	fmt.Println(s)
}

outputs
[3 5 7 11 13]


[Kernel][Feature Request] Support data skipping using min/max file statistics for TIMESTAMP type columns

Feature request
Which Delta project/connector is this regarding?

[ ] Spark
[ ] Standalone
[ ] Flink
[X] Kernel
[ ] Other (fill in here)

Overview
In #2433 we block skipping using file statistics on timestamp columns. This is because timestamps are truncated to milliseconds when written to JSON statistics, and thus we cannot safely use the MAX statistics since we may see microsecond precisions.
To use the timestamp MAX statistic we need to add a millisecond to it as we do in DataSkippingReader.
Further details
To do this we need to support time addition first.

Hi! I would like to work on this issue.

@sebastian2296 sounds good. Let us know if you have any questions.


[BUG] Performance Test Consumer in Example not setting the NameServer Addr

BUG REPORT

Please describe the issue you observed:

org.apache.rocketmq.example.benchmark.Consumer is not setting the NameServer as the Example Producer does.
Which would cause consume failed if not seting nameserver in ENV variable.

Please tell us about your environment:

Rocket MQ 4.5.1

Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):

I'll make a PR to solve the problem.

@liheyuan It's recommended to use ENV variable to manage Name server address.
The issue only used for a bug report or feature request, if you have some questions, please subscribe our mailing list and send your question by email: https://rocketmq.apache.org/about/contact/, so I will close this issue, but please feel free to reopen it if you have more questions.


Unable to edit "Scale Transition Point" in Span

The user is unable to add any data to the "Scale Transition Point" in Span. When the user adds some data and saves the save does not take and the field is still blank
Original Ticket:
Edit Monitoring Span data #1706

Bug has been fixed


Show detailed progress for ROCm CI

/test jenkins

/test skip

Closing as this still generates huge outputs...


Editing list of available versions

Adding 0.3.0 to this page - https://pytorch.org/data/versions.html
The default page that users reach when they visit pytorch.org/data will still be the documentation for themain branch. I recommend keeping it that way unless you have other thoughts.

And, can you please update https://github.com/pytorch/data/blob/gh-pages/index.html to point to 0.3.0?

That's the part I am unsure about, it depends how much our API/doc will change in the very near future, but I can do that.

It is done. The landing page will now redirect to beta which redirects to 0.3.0.

I don't think this is going to work. Can you please do a test?

Updated as symbolic link


feat(localizations): Add el-GR localization

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[x] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

Add el-GR localization

@raptisj I've updated the translations based on you comments, thanks! :)

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Pings staff for new ticket

Your welcome Dan

Wait this is not something to use, I put this in the wrong file


feat: Helm chart: Support hostAliases

SUMMARY

We have a corporate cluster where not all connectible servers are in DNS yet.
So, interception of the name resolution is required. hostAliases is that mechanism.
TESTING INSTRUCTIONS

Can use helm template with respective values set.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[x] Introduces new feature or API
[ ] Removes existing feature or API

just bumped the version


prevent modal from closing in react

I'm trying to add inputs to the modal using the react example, however when i click on the input to write the modal automatically close

Hello there, @Merrick17 ,
Please provide us with your sample code, and we'll see what we can do.
Best,
Manu

 <>       <button         className="bg-pink-500 text-white active:bg-pink-600 font-bold uppercase text-sm px-6 py-3 rounded shadow hover:shadow-lg outline-none focus:outline-none mr-1 mb-1"         type="button"         style={{ transition: "all .15s ease" }}         onClick={() => setShowModal(true)}       >         Open regular modal       </button>       {showModal ? (         <>
 setShowModal(false)}           >
               {/*content*/}
                 {/*header*/}

                     Modal Title
                   <button                     className="p-1 ml-auto bg-transparent border-0 text-black opacity-5 float-right text-3xl leading-none font-semibold outline-none focus:outline-none"                     onClick={() => setShowModal(false)}                   >                                            ×                                        </button>
                 {/*body*/}

                     I always felt like I could do anything. That’s the main                     thing people are controlled by! Thoughts- their perception                     of themselves! They're slowed down by their perception of                     themselves. If you're taught you can’t do anything, you                     won’t do anything. I was taught I could do everything.

                 {/*footer*/}
                   <button                     className="text-red-500 background-transparent font-bold uppercase px-6 py-2 text-sm outline-none focus:outline-none mr-1 mb-1"                     type="button"                     style={{ transition: "all .15s ease" }}                     onClick={() => setShowModal(false)}                   >                     Close                   </button>                   <button                     className="bg-green-500 text-white active:bg-green-600 font-bold uppercase text-sm px-6 py-3 rounded shadow hover:shadow-lg outline-none focus:outline-none mr-1 mb-1"                     type="button"                     style={{ transition: "all .15s ease" }}                     onClick={() => setShowModal(false)}                   >                     Save Changes                   </button>

         </>       ) : null}     </>
I took this code snippet and tried to integrate it however no matter where i click it closes

Hello again, @Merrick17 ,
Please un-minify the code snippet.
Best,
Manu


Exclude anon classes from dependency registration

These can show in edge cases like:
package demo

class SRC[_]
class Filter
class Refined {
  def select(cols: SRC[_]*) = new {
    def where(filter: Filter => Filter)(implicit d: DummyImplicit) = {
      new {
        def using(opt: Box[SRC[_]] => Some[SRC[_]])(implicit d: DummyImplicit) = opt
      }
    }
  }
}

package demo

class Client {
   def temp = new Refined().select(null).where(null).using(null)
}

This can leak an existential type owned by an anon-class into Client, at least prior to this compiler fix:
scala/scala#10940

I'm not 100% sure if this leads to an observable under- or over-compilation bug.
One thing I've noticed is that it does create a spurious entry in the external libraries table in the analysis.
import sbt.internal.inc.{Analysis, Stamps}

scalaVersion := "2.13.15"

val p1 = project

val p2 = project.dependsOn(p1)

TaskKey[Unit]("diagnostic") := {
  val stamps = (p2 / Compile / compile).value.asInstanceOf[Analysis].stamps.asInstanceOf[Stamps]

  println("libraries = " + stamps.libraries)
}

sbt:zinc-refinement> diagnostic
[debug] Other repositories:
[debug] Default repositories:
[debug] Using inline dependencies specified in Scala.
[debug] Copy resource mappings:
[debug]
[debug] [zinc] IncrementalCompile -----------
[debug] IncrementalCompile.incrementalCompile
[debug] previous = Stamps for: 7 products, 2 sources, 1 libraries
[debug] current source = Set(${BASE}/p1/src/main/scala/Refined.scala, ${BASE}/p1/src/main/scala/Box.scala)
[debug] > initialChanges = InitialChanges(Changes(added = Set(), removed = Set(), changed = Set(), unmodified = ...),Set(),Set(),API Changes: Set())
[debug] No changes
[debug] Created transactional ClassFileManager with tempDir = /Users/jz/code/zinc-refinement/p1/target/scala-2.12/classes.bak
[debug] Removing the temporary directory used for backing up class files: /Users/jz/code/zinc-refinement/p1/target/scala-2.12/classes.bak
[debug] [zinc] IncrementalCompile -----------
[debug] IncrementalCompile.incrementalCompile
[debug] previous = Stamps for: 1 products, 1 sources, 2 libraries
[debug] current source = Set(${BASE}/p2/src/main/scala/Client.scala)
[debug] > initialChanges = InitialChanges(Changes(added = Set(), removed = Set(), changed = Set(), unmodified = ...),Set(),Set(),API Changes: Set())
[debug] No changes
[debug] Created transactional ClassFileManager with tempDir = /Users/jz/code/zinc-refinement/p2/target/scala-2.12/classes.bak
[debug] Removing the temporary directory used for backing up class files: /Users/jz/code/zinc-refinement/p2/target/scala-2.12/classes.bak
libraries = Map(${BASE}/p1/target/scala-2.12/classes/demo/Refined.class -> farm(1651ebda9ac28257), ${SBT_BOOT}/scala-2.12.20/lib/scala-library.jar -> farm(d37410c41eebd71a))
[success] Total time: 0 s, completed 3 Dec 2024, 10:43:03 am

I made a GitHub repo containing retronym's reproduction for people to play around with: https://github.com/Friendseeker/zinc-1507

So an ExistentialType (in this case SRC[_]) has a quantified type (call it tpe), for which its enclosing class (tpe.typeSymbol.enclClass) is an anon class. Zinc then tries to register the class dependency between  Client and that anon class. As Zinc does not recognize the anon class as declared by any source files, Zinc decides that the anon class must be from a library and registers an external library dependency.

This is basically correct. SRC[_] is a shorthand for SRC[$1] forSome { type $1 }.  The compiler create a Symbol represent $1, as it does to represent anything named entity in the program (ie classes, params, type params, methods). All symbols have an owner which is typically the symbol of the closest, suitable enclosing Symbol.
The compiler really shouldn't let the symbol for this anonymous class within the method "leak" out into method return type, even in a seemingly innocuous way as above where it just the owner of a symbol. We're fixing that in the compiler.
But Zinc also can stand to be more discriminating in its interpretation of the Symbol's it encounters. Calling flatnameon an anoymous class symbol at the point in compilation whereExtractAPIruns gives nonsensical results (the actual class name will beanon$N` once a later compiler phase lifts classes out of methods into the enclosing class.
Run this to see what I mean scala --scala-version 2.13.15 -Vprint:all -e 'class C { def f = new { "fanon"} }'

The 3 compiler gurus (Eugene, Dale, Lukas) likely grasp the issue much better than me, but I guess there's probably no edge case that can emerge from not tracking class level dependency with anon class? Say an anon class is changed, then some name hash of the enclosing top-level named class will change, so tracking class level dep with anon class is completely unnecessary.

Yep, any changes to the anonymous class that are relevant to incremental compilation are reflected in the structural type of the method, which is determines its API hash.


Add a Rnn classification example

Add a Rnn classification example
reproducing the pyTorch char rnn
tuturial.
Categories: 0:Arabic, 1:Greek, 2:Chinese, 3:Czech, 4:Dutch, 5:Japanese,
6:Korean, 7:Russian, 8:English, 9:Scottish, 10:Vietnamese, 11:German,
12:Spanish, 13:French, 14:Polish, 15:Italian, 16:Irish,
Creating a RNN Classifier with vocab size: 256 and num classes: 17
Epoch 1 - Train Loss: 2.37  Global accuracy=0.422
Epoch 2 - Train Loss: 2.013 Global accuracy=0.543
Epoch 3 - Train Loss: 1.744 Global accuracy=0.619
Epoch 4 - Train Loss: 1.561 Global accuracy=0.713
Epoch 5 - Train Loss: 1.322 Global accuracy=0.734
Epoch 6 - Train Loss: 1.187 Global accuracy=0.790
input:       Samad expected: Arabic	 prediction: Arabic
input:   Papademos expected: Greek	 prediction: Greek
input:    Birovsky expected: Czech	 prediction: Czech
input:         Wai expected: Chinese	 prediction: Vietnamese
input:    Nikolaev expected: Russian	 prediction: Russian
input:  Washington expected: English	 prediction: English
input:    Voltaire expected: French	 prediction: French
input:    Pfeiffer expected: German	 prediction: English
input:  Tambellini expected: Italian	 prediction: Italian
Enter a surname and press enter to classify it:
Original Issue:
closes #252
Summary
Add a Rnn classification example
Test Plan (required)
Build and run the example, see droping loss, increasing accuracy

Will have a look on the latest version probably tmr.

Ok, it looks good for me in current state. Wait @jacobkahn comments before merging. @WilliamTambellini regarding your comment on the dataset - can we call exec on downloading the dataset or remain it for people to download if the path doesn't exist (seems better to preserve original link to the data so no ambiguity on the data we use)?

Ok, it looks good for me in current state. Wait @jacobkahn comments before merging. @WilliamTambellini regarding your comment on the dataset - can we call exec on downloading the dataset or remain it for people to download if the path doesn't exist (seems better to preserve original link to the data so no ambiguity on the data we use)?

ok, added wget and unzip system calls.

@WilliamTambellini CI's failing, please take a look.


Endpoints are not working last tried 28th aug

@choxxin Thank you trying out this project, I've checked it now it's working. I was able to login and get user's details attaching screenshot as well. Could you please try again and let me know if its working.

Yes its working fine ,thank u soo much


round rgba values. issue #197

Thank you. Planning to do a release this weekend. This will be included.


[Grid] Better document direction column limitation

Grid items are an opinionated height when using the xs and similar attributes on items within Grid column containers.
I don't think you should use flex-basis for Grid item's in a column container when xs and similar attributes are used on items. I think xs and related attributes are intended to control the width only, never the height, but flex-basis controls height in column containers.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
The following code results in an item with flex-basis: 100%, which is not expected for column containers.
<Grid container direction="column">
  <Grid item xs={12}>test</Grid>
</Grid>

Expected Behavior 🤔
Instead, I think height should not be controlled by xs and similar attributes on Grid items. You probably should use width: 100%  rather than flex-basis when an item is directly under a column container.
The workaround I am using is to specify the width without the attributes, e.g.
const useStyles = makeStyles(theme => ({
  xs12: {
    width: '100%',
  },
}))
const Comp = () => {
    const classes = useStyles()
    return (
<Grid container direction="column">
  <Grid item className={classes.xs12}>test</Grid>
</Grid>
  )
}

Steps to Reproduce 🕹
https://codesandbox.io/s/mui-bug-for-column-containers-8ztdx
Steps:

make a column container with Grid
see the item fill the height even though it should not.

Context 🔦
I'm trying to make a simple page with items going down on the page.
Your Environment 🌎

Tech
Version

Material-UI
"@material-ui/core": "^4.5.1",

React
CRA "react": "^16.11.0",

Browser
Chrome 78.0.3904.70

TypeScript
n/a

OS
macOS Version 10.13.6

@cyrfer As far as I remember, the xs, sm, etc. props don't work with the vertical direction. This issue remember me an older one but I can't find it.

@oliviertassinari in fact they cause unexpected results. You clicked the codesandbox link, right?
Yes, frequently I prefer block elements stack in the vertical direction, like most simple websites. Changing to width for column containers seems easy to support. Maybe you can point me in the right direction where I would begin to make a PR.

@cyrfer I could find the documentation for this problem: https://material-ui.com/components/grid/#direction-column-column-reverse.

What about?
diff --git a/docs/src/pages/components/grid/grid.md b/docs/src/pages/components/grid/grid.md
index 465149ea0..01636e70d 100644
--- a/docs/src/pages/components/grid/grid.md
+++ b/docs/src/pages/components/grid/grid.md
@@ -119,12 +119,10 @@ In practice, you can set the `zeroMinWidth` property:

 ### direction: column | column-reverse

-Though the `Grid` component has a `direction` property that allows values of `row`, `row-reverse`, `column`, and `column-reverse`,
-there are some features that are not supported within `column` and `column-reverse` containers.
-The properties which define the number of grids the component will use for a given breakpoint
-(`xs`, `sm`, `md`, `lg`, and `xl`) are focused on controlling width
-and do **not** have similar effects on height within `column` and `column-reverse` containers.
-If used within `column` or `column-reverse` containers, these properties may have undesirable effects on the width of the `Grid` elements.
+The xs, sm, md, lg, and xl props are **not supported** within `direction="column"` and `direction="column-reverse"` containers.
+
+They define the number of grids the component will use for a given breakpoint (focused on controlling width).
+If used, these props may have undesirable effects on the width of the `Grid` item elements.

Doc improvements are always appreciated. I think you adequately described the issue now.
Supporting expected behavior seems straight forward to me. I hope we can consider that path also.

@oliviertassinari actually, what do you think about change,

are focused on controlling width and do not have similar effects on height

to:

are intended to control width but use flex-basis so they will impact height also.

@cyrfer This sounds good 👍.

@oliviertassinari great!
Yes! Any chance you could point me in the right direction? I'm thinking I need to check when the parent is a column container and make a selector that prefers width over flex-basis.

@cyrfer I meant, for an update of the documentation, not the implementation.

@oliviertassinari who can I talk to about fixing the bug?

@cyrfer At this point, I doubt we can change the Grid component implementation (I suspect we can only add new features), I would fear that a change like this could break people layouts.

@oliviertassinari your hesitation is warranted. When I think about it, I cannot imagine who would be depending on a column layout that expresses height using width props. The result does not seem easy to plan around. However, perhaps someone has decided to do that.
Is it possible to control feature flags, perhaps using theme properties? That way developers can "opt into" the better behavior?

@cyrfer Did you find a way to work around the problem?

I feel like my original post was not absorbed.

@oliviertassinari great!
Yes! Any chance you could point me in the right direction? I'm thinking I need to check when the parent is a column container and make a selector that prefers width over flex-basis (for each of the props xs, sm, etc).

I would be interested in seeing a proof of concept.

@joshwooding I think it would simply look like the codesandbox link.

Hi @cyrfer

I cannot imagine who would be depending on a column layout that expresses height using width props.

Well, I do! I don't know if I should or if it's a complete misunderstanding of the doc, but I find it very handy in some situations. I don't find where the doc specifies xs as a width prop. It says that it

Defines the number of grids the component is going to use

I use it in vertical container in some of my custom components, and I just had a minor issue with the maxWidth (resolved here ). I imagine some situations where it can be nice to use that if you want to turn your component from horizontal to vertical, but you want to keep proportions of its children.

@cyrfer
Concerning the wrapping problem, it's the same behaviour than a row container. I can see why it can be bothering, but then why don't you use wrap:'nowrap' in your container? In your codesandbox, it fixes well your issue.
In fact, I don't see why you use a column container. What is your need of using it?
I use a row container to display different size items successively in a row, and if it overflows it, it goes to a second row.
I use a column container to display different size items successively in a column, and if it overflows it, it goes to a second column.
I may be completely wrong though. What do you think @oliviertassinari ?

@oliviertassinari
What could be really great is to change the maxWidth to maxHeight when the parent container is a column.

@oliviertassinari
What could be really great is to change the maxWidth to maxHeight when the parent container is a column.

Is there any update on this?

@sprietNathanael I think that we should improve the documentation around how this is not a supported feature: https://github.com/mui-org/material-ui/issues/18225#issuecomment-550437836. What diff do you have in mind?

@oliviertassinari Well, as I said earlier, I think it would be really great to support using maxHeight instead of maxWidth when the parent container is set in column direction.
Thus, items behaviour would be the same, whether it's in row or column.

@sprietNathanael What would the implementation look like?

Well, I some of the comments here and there, and I found again a solution I've used to workaround this issue : https://github.com/mui-org/material-ui/issues/13277#issuecomment-564591148

I just stumled upon this issue while searching for a reason of this unexpected behaviour. I don't truly understand why breakpoint={1-12} does not make sense with direction="column" for particular uses. I work with a fixed height container and this could be really usefull to use that functionality.

We can work around the problem using CSS selectors.

@oliviertassinari I think this could be a nice workaroud.
I don't know if it's the correct way to handle this, but what worked for me is to apply to the container the following class:
	verticalContainer: {
		'& .MuiGrid-item': {
			maxWidth: 'none',
		},
	},

verticalContainer is a class I add, but it could be replaced by .MuiGrid-container.MuiGrid-direction-xs-column.
This works, but I have to re-implement this css for every component that nedd it. I could use my global theming to do it, but I think it would be really handy to have it implemented internaly in the library.
Moreover, it only bypass maxWidth, but does no set maxHeight instead.

@sprietNathanael Do you want to send a pull request?


Add setup section in the readme file

Hello,
Have you any questions about this pull request ?
Because, I see that you've been waiting to add this.


Reuse VirtualHostBuilder on the same hostnamePattern

Motivation:
I registered each virtual host with the same hostname, the registered routes cannot be not found. Because VirtualHostBuilder creates new builder even if hostname is the same. However, it does reuse them on the same port.
So, I think it's better to reuse them on the same hostname.
Modifications:

ServerBuilder.virtualHost(hostnamePattern) and ServerBuilder.virtualHost(defaultHostname, hostnamePattern) checks whether there is builders with the same hostname. If there is, returns this builder.

Result:

Reuse VirtualHostBuilder on the same hostname.
Even if you register each one on a virtual host with the same hostname, they will be merged.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

gentle ping @yejinio 🙇

I've added a small commit which

Deprecates ServerBuilder#virtualHost methods that doesn't support VirtualHostBuilder reuse
Adds a ServerBuilder#withVirtualHost which supports VirtualHostBuilder reuse
Deprecates VirtualHostBuilder#hostnamePattern which makes VirtualHostBuilder reuse ambiguous

Let me know if the changes don't make sense 🙇
https://github.com/line/armeria/pull/5418/commits/0d0edef32cefac38f31ae7d525bcfd57e7cc3311


Add picamera as an optional dependency.

We make two dependencies optional:

Picamera can only be installed on Pi hardware (AFAIK).
OpenCV takes so long to install on Pi hardware that it should be optional.

[ ] add note to readme about groups/extras
[ ] check runs on pi


Specs for candidate timeout

Context
Our recent incidents showed that we didn't have specs around the candidate timeout.
Changes proposed in this pull request
Specs that show how sessions are timed-out and refreshed.
Guidance to review
Anything else we want to add?
Link to Trello card

 Specs for candidate session timeout


📚 - Stackblitz examples for Editor don't work

What is the affected URL?
No response
Description
All the Stackblitz examples of Editor with images don't work for me.
https://taiga-ui.dev/editor/images/resizable
Error: NullInjectorError: No provider for HttpClient!
https://taiga-ui.dev/editor/images/preview
Error: Could not find template file './image-preview.template.html' (template should be inside image-preview folder, not in the app folder)
https://taiga-ui.dev/editor/images/upload
Error: Cannot find module '../../../../../../../environments/environment' or its corresponding type declarations.
But even if I fix errors, I still cannot attach image because of this console error: "Error: Class constructor NodeView cannot be invoked without 'new'"
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Also

Also it would be great to have a stackblitz example with default editor configuration like this one https://taiga-ui.dev/editor/setup/API
It will allow to explorer Editor features and reproduce bugs without pain.


Feat(Jest): retrieve coverage from testResults Fix #965

Fixes #965

@Tobino thanks for working on this.
It doesn't seem to work for me:

However there does seem to be coverage data, but I think it is because jest itself instrumented the code. Which isn't bad by itself, we should be able to make that work as well, we would just need to alter Stryker to not do the coverage analysis in this case. More changes are needed. @simondel what do you think?

I've opened a stack overflow question about globals: https://stackoverflow.com/questions/51723662/retrieve-global-variable-after-test-run-in-jest

@nicojs Do we also have to update the Stryker readme? https://github.com/stryker-mutator/stryker/tree/master/packages/stryker#type-of-coverage-analysis

@nicojs on my macbook, I can retrieve the coverage data. Maybe I am working with a different version of jest. :/
The array contain two coverages, one for Add.js and one for Circle.js
Your array have 4 items, what is the other testSuite ?

@Tobino After reading the docs and dived a bit in the Jest source code, I'm now seeing that Jest actually does it's own instrumentation using istanbul: https://github.com/facebook/jest/blob/6d3da9be06350bfa7414b609807ebd0cbdf0c416/packages/jest-runtime/src/script_transformer.js#L24
This means that we could make it work, but it would come at severe consequences:

We need to change Stryker to allow the test runner to instrument the code instead of Stryker itself.
Because Stryker cannot instrument the code, the coverage analysis 'perTest' will never work, because that instrumentation is different from the regular istanbul instrumentation.
The istanbul version that the test runner uses must be inline with the istanbul version Stryker is using. Meaning that the report structure must be the same one Stryker is supporting.
This implementation would break once we do our own 'mutation coverage instrumentation' that we are planning to do in the future.

IMHO those downsides are to big to allow this.
However, really the only thing that we need jest to be able to do is report back on global variables. I've opened this stack overflow question for this. It seems that it is not possible at the moment: https://stackoverflow.com/questions/51723662/retrieve-global-variable-after-test-run-in-jest/51831522
@Tobino Would you be interested in opening up an issue at Jest side to see if they are willing to help us with this? If they could give us a way to programmatically retrieve a global variable value from the testing environment, we would be golden.

I went along and created an issue at the Jest side of things here: https://github.com/facebook/jest/issues/7421
I'm closing this PR for now. Once we figured out what the way of reporting the code will be we can create a new PR.

@nicojs any news for this ?

@PFadel As you can see on the issue facebook/jest#7421, unfortunately not :(


Adapter stops updating client states

I am using the adapter since a while for tracking my devices are there or not.
I found out that after a few days the clients are stopped being updated by the adapter, although they're online and fine.
My workaround was to restart the adapter each night, what helped a little.
But it is still too buggy. Right now I have a client (my smartphone) where the objects of the adapter for this client has been updated the last time two days before from now. But I see the client alive in my unifi dashboard - same MAC address, nothing from the device itself has changed to the identification parameters of the object tree in the unifi adapter on iobroker side.
While I am typing this, I simply press the restart button of the adapter and the exact same object tree of the client I described updated each state. No new objects or that I am in the wrong object-tree. It is just the fix: Restarting the adapter and the given states has been updated.
I cannot see when the updates are stopping and why - all I know is restarting the adapter fixes it within seconds.
Versions:

Adapter version: 0.7.0
JS-Controller version: 6.0.5
Node version:  18.17.1
Operating system: raspbian 11

Same here

same also here :-(

Same here.

Same here -
all last seen by .. - false
is online - true


Adds type information for pandas.DataFrame.transpose

Fixes #159

Hi, thanks for the PR! I'm not sure Optional is the right type here though. In Python's typing library, Optional means that the value may be None. But I don't think these values can be None, can they?
The fact that the values have default values is already encoded by the = ....


MM-48582 Playbook import via drag and drop

Summary

Playbooks can be imported by dropping a file onto the import buttons.
Additionally, the LHS is now refreshed when a playbook is imported.
Screencast from 12.01.2023 16:54:38.webm
Ticket Link

MM-48582
Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[x] Unit tests updated

I've added a visual indicator for the dropzone and updated the video above. I'm 2/5 in regards of the UX that the dropzone gets shown when the user drags a file to any part of the page. In Channels, it is only shown when dragged into the dropzone.


Sydney.edu.au: Missing collection tags

The Python programs do not include sets (Researchers, Publications, Grants, Relations). Please refer to (http://researchgraph.org/oxygen2/index.html#registryObjects)
For example, the Authors export should include Researchers tag.
      2     <registryObjects
      3         xmlns="http://researchgraph.org/schema/v2.0/xml/nodes"
      4         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      5         xsi:schemaLocation="https://raw.githubusercontent.com/researchgraph/schema/master/xsd/researcher.xsd">

 <<<- Researchers tag is missing here

      6         <researcher>
      7             <key>sydney.edu.au/researcher/***</key>
      8             <local_ID>***</local_ID>
      9             <first_name>Pramesh</first_name>
     10             <last_name>Kavoor</last_name>
     11             <full_name>Pramesh Kavoor</full_name>
     12         </researcher>

The way that this system works is based on the XML hierarchical structure: Registry objects includes sets (Researchers, Publications, Grants, Relations), and each set includes individual items:

Researchers include Researcher
Publications include Publication
Datasets include Dataset
Grants include Grant

This issue is fixed by Keir.


From private repo

Hi @v-cmans, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-cmans). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Hi @v-cmans, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-cmans). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;