Roll Flutter Engine from 22baa83db63b to 13cdf933d641 (10 revisions)

https://github.com/flutter/engine/compare/22baa83db63b...13cdf933d641
2023-11-16<EMAIL_ADDRESS>Fix race condition in Unobstructed Platform View Scenario tests (flutter/engine#48096)
2023-11-16<EMAIL_ADDRESS>[Impeller] store all path point data in single buffer. (flutter/engine#47896)
2023-11-16<EMAIL_ADDRESS>Roll Skia from b9ead4140f84 to 297049bbfc0d (2 revisions) (flutter/engine#48133)
2023-11-16<EMAIL_ADDRESS>[macOS] Replace pasteboard mock with fake (flutter/engine#48110)
2023-11-16<EMAIL_ADDRESS>[Impeller] Fix issue where the lock was not re-acquired when the wait exits on CV. (flutter/engine#48104)
2023-11-16<EMAIL_ADDRESS>[Impeller] Create a drawable backed TextureMTL. (flutter/engine#48049)
2023-11-16<EMAIL_ADDRESS>Reverts "Make flow/embedded_views.h compatible with .clang_tidy." (flutter/engine#48130)
2023-11-16<EMAIL_ADDRESS>[macOS] Replace fixture subclasses with usings (flutter/engine#48111)
2023-11-16<EMAIL_ADDRESS>Make flow/embedded_views.h compatible with .clang_tidy. (flutter/engine#47994)
2023-11-16<EMAIL_ADDRESS>Make flow/... compatible with .clang_tidy. (flutter/engine#47995)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Standardize VM count metadata

Benchmarks utilizing a variable number of VMs are currently responsible for reporting the number of VMs used. We should create a single location to add this information to the metadata, under a fixed key.

Agreed.  We should start by adding a consistent label to all benchmarks - really all.  In this case I dont think we need to deprecate the old labels on specific benchmarks because it is not confusing like we did with the server_machine vs receiving_machine labels for the network benchmarks.
I'm advocating for "all" benchmarks to have the label even if they one use 1 VM like Spec CPU 2006.  This will make it easier to write a well specific query - ie ooking for the vm_count=1 vs absence of the vm_count label.  By the way I'm not saying vm_count should be the label name.

Fixed by above PR


Try to handle Windows being Windows

Fixes #92 (maybe).

I don't think we have immediate other changes planned, so I will mark for the release as well.


Fix: Update publishing branch from master to main

Issue
When using this workflow in the repository the default branch is main, it does not publish the document to Github wiki page successfully. (But it returns success result)
Since Github default branch changed from master to main, so we need to update the script to publish to main branch instead.
👉🏻  Fix this line: https://github.com/nimblehq/publish-github-wiki-action/blob/develop/entrypoint.sh#L64
Expected
The workflow publishes doc to wiki successfully.
Steps to reproduce

Merge the wiki markdown page to main branch on the repository.
Let the workflow runs.
It will return success, but it does not publish the document on wiki page.

The issue is not from the publishing branch, as discussed in this thread.


fix: cannot read property 'ignore' of undefined

:tada: This PR is included in version 1.14.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Get the header column from excel

Hi ,
I am reading excel file through js-xlsx. my requirement is to read the the first headings row alone,
now i am doing this by
var columns = XLSX.utils.decode_range(workSheet['!ref']).e.c + 1;
for (z in workSheet) {
if(z[0] === '!') continue;
if(rowIndex == 0){
excelColumns[columnIndex] = (JSON.stringify(workSheet[z].v)).replace (/"/g,"");
}
else break;
columnIndex++;
if(columns == columnIndex){
rowIndex++;
}.
but this has some issues while reading the excel if the number of columns in the heading is less than number of columns in the remaining data row for this logic.
Is there any way to do this with js-xlsx library defined function to read the heading of excel.Any help will be much appreciated.
heading here i refer to the first line of the document.

@kalai7890 If you just want to pull the header row, the easiest way is to just walk the cells in the first row:
function get_header_row(sheet) {
	var headers = [];
	var range = XLSX.utils.decode_range(sheet['!ref']);
	var C, R = range.s.r; /* start in the first row */
	/* walk every column in the range */
	for(C = range.s.c; C <= range.e.c; ++C) {
		var cell = sheet[XLSX.utils.encode_cell({c:C, r:R})] /* find the cell in the first row */

		var hdr = "UNKNOWN " + C; // <-- replace with your desired default
		if(cell && cell.t) hdr = XLSX.utils.format_cell(cell);

		headers.push(hdr);
	}
	return headers;
}

For simple access patterns, it may be easier to work with an array of arrays.  See https://github.com/SheetJS/js-xlsx/issues/212#issuecomment-95970115 for an example of working with the sheet_to_json utility function

what is range.s.c and range.e.c ? what is the difference?

It's discussed a bit in the README: the decoded range is an object where range.s is the upper-left corner of the range (so range.s.c is the first column and range.s.r is the first row) and range.e is the lower-right corner of the range (so range.e.c is the last column and range.e.r is the last row)  The indices are 0-based, consistent with JS but different from Excel (the first element of a JS array is index 0, but the first row is number 1 in Excel)
For example, for the range reference A1:C5: the upper-left cell is A1, represented as the object {c:0, r:0}; the lower-right cell is C5, represented as the object {c:2, r:4}; so the range object is {s:{c:0, r:0},e:{c:2, r:4}}
The mnemonic here is: s for "start of range", e for "end of range", r for "row", c for "column"

you are brilliant!!! thank you so much

Hello sir,
I need your help. I want to fetch the number of row and columns. How I do this using this library. Please help me for this. if you can explain this work with simple example its more useful for me. thank you.

I am using Javascript this is my simple code.
var url = "myFile.xlsx";
var oReq = new XMLHttpRequest();
oReq.open("GET", url, true);
oReq.responseType = "arraybuffer";
oReq.onload = function(e) {
var arraybuffer = oReq.response;
var data = new Uint8Array(arraybuffer);
var arr = new Array();
for(var i = 0; i != data.length; ++i) arr[i] = String.fromCharCode(data[i]);
var bstr = arr.join("");
/* Call XLSX */
var workbook = XLSX.read(bstr, {type:"binary"});
var t  = workbook.SheetNames;
//HOW I COUNT NUMBER OF ROWS AND COLUMN'S WHICH ARE NOT EMPTY
}
oReq.send();

@SheetJSDev Thank function is a life saver. Thank you!

hello, I want to read particular
rows in the xlsx file. how to read with this library

@SheetJSDev when I use the function. It returns me "!ref" undefined

Hi everyone,
I was using this function to get Header Row:
function get_header_row(sheet) {
var headers = [];
var range = XLSX.utils.decode_range(sheet['!ref']);
var C, R = range.s.r; /* start in the first row /
/ walk every column in the range /
for(C = range.s.c; C <= range.e.c; ++C) {
var cell = sheet[XLSX.utils.encode_cell({c:C, r:R})] / find the cell in the first row */
    var hdr = "UNKNOWN " + C; // <-- replace with your desired default
    if(cell && cell.t) hdr = XLSX.utils.format_cell(cell);

    headers.push(hdr);
}
return headers;

}
But today I upgraded XLSX to version 0.12.3, and now there is an error saying "Property 'format_cell' does not exist on type 'XLSX$Utils'"
Can you help me, please?
Is it there a new function to replace 'format_cell'?

@victorj2307 It's available in the JS module but currently isn't in the TS definition.  If you would like to submit a PR, the type definitions are in /types/index.d.ts and the simplest fix would be
     decode_range(range: string): Range;

+    /** Format cell */
+    format_cell(cell: CellObject, v?: any, opts?: any): string;
+
     /* --- General Utilities --- */

Hi @SheetJSDev, thanks for your help.
I haven't create a PR in the past in any Github project, so I'm not familiar with how to do it.
I used a casting to any to avoid TS check. I'd appreciate if you make the change and it will be available in a future version.
This is what I did:
if (cell && cell.t) hdr = (<any>XLSX.utils).format_cell(cell);

Thanks in advance.

@kalai7890 I found an easier solution using regex.
function getSheetHeaders(sheet: WorkSheet) {
    const headerRegex = new RegExp('^([A-Za-z]+)1=\'(.*)$');

    const cells = XLSX.utils.sheet_to_formulae(sheet);
    return cells.filter(item => headerRegex.test(item)).map(item => item.split("='")[1]);
}

This thing worked for me:
const workbook = XLSX.read(data, { type: "array" });
const firstSheetName = workbook.SheetNames[0];
const worksheet = workbook.Sheets[firstSheetName];
const options = { header: 1 };
const sheetData = XLSX.utils.sheet_to_json(worksheet, options);

const header = sheetData.shift();
console.log(header);


Jeff Schaller: Watch soikeo7ball.com

Jeff Schaller requests the watch of the watch_keyword soikeo7ball\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

soikeo7ball\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Eliah Kagan in Charcoal HQ


Scss is not reloaded until the server is restarted

version: 2.4.2
node: 5.7.1
os: darwin x64
app/styles/
├── app.scss
└── pods.scss

Importing pods into app and ...test/style into pods.
app/pods/components/
├── test
    ├── component.js
    ├── style.scss
    └── template.hbs

//ember-cli-build.js
module.exports = function(defaults) {
  var app = new EmberApp(defaults, {
    sassOptions: {
      includedPaths: ['app']
    }
  });

I've also tried includedPaths: ['app/pods'] and globbing. Thanks!

How does your pods.scss looks like?
Does it have import of the pods/components/test/style.scss?
It supposed to be automatically if you used 'ember g style' command.

Yep, it imports the pods/components/test/style.scss styles. I've tested this by restarting the server / modifying the styles in that file. I feel like there may be something weird going on with livereload since writing to the pods.scss file will also forcefully reload the styles, but is not detecting changes in the individual pods.

I didn't understand.
If you're set this style:
body {background: red}
to your pods.scss file. It will reload automatically? with the actual change?

Yes, but only if the pods.scss file is manually written. Updating a child stylesheet does not rewrite or update pods.scss which manifests itself as no visible changes until 1) the server is reloaded, or 2) pods.scss is manually written.

Experiencing this as well. Must be an issue with some new Ember-CLI. If a scss file outside of /styles folder is changed, dist css folder is not updated even if the "build" is triggered.

@barcher I have managed to solve my issue. Not sure how exactly though.
See here:
https://github.com/ember-cli/ember-cli/issues/5823

@MartinMalinda thanks! I tried adding the sassOptions as you suggest, but it doesn't seem to affect the results.


Fix yaml key and bare-metal index

This change fixes the certificate-authority-data key for kubeconfig in the bare-metal doc. It also revert the index.mdx changes from [1].
[1] https://github.com/tigera/docs/pull/1758/files#diff-cee12842f2d30c31655cc9f7e40e9b74e3e89c147e8568e7023c6a298cca6fe3

Product Version(s):

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

LGTM, thanks for the fixes


Usage Issues

I have been attempting to implement this theme into by jekyll site, but the theme does not work. Please add usage steps to make this more straightforward.

@YoussefRaafatNasry I think they mean running it locally. It shows an error that it does not find 'jemoji'. Did you have to install anything?

@YoussefRaafatNasry I think they mean running it locally. It shows an error that it does not find 'jemoji'. Did you have to install anything?

Did you run bundle install as mentioned here?

Please reopen this if there's any updates.


rewrite: old snapshot deleted before new one is created?

At the end of rewriting a snapshot with --forget, the log output looks like this:
removed old snapshot c682c238
saved new snapshot 0d58bbaa

It suggests that restic deletes the old snapshot before saving the new one, which would be prone to data loss. I have not checked the code at all, so it might just be misleading.
I would feel better if the log messages were the other way around, or the text was clear that no snapshot can be lost.

The code saves the new snapshot first and deletes the old one afterwards. It is just the log messages that are misleading.

@MichaelEischer Thanks for confirming that! I was too lazy for checking the code myself.


Web Actions Tab: Add content type to Web Action unique tag

Currently actions with proto request/response are showing up twice (one for proto content type, one for JSON), but any button clicks manipulate both meaning that the unique tag used to identify interactions in Redux for each Web Action card is resolving to the same for the two.
Adding content type to that unique tag should resolve this.


Tracker for FIPS204 / ML-DSA

Tracks liboqs ML-DSA #1919
This PR Integrates ML-DSA and (non-composite) hybrids.
However, it does not yet include support for the updated composite signatures with ML-DSA.
@feventura: It would be great if you could amend this PR to incorporate the updated composite signature support. Alternatively, you could submit a follow-up PR for those changes.

Can we revive this PR to get ML-DSA landed in oqs-provider?  @bhess is there anything more you were planning before converting this from a draft PR?

@feventura @johngray-dev do you have any feedback whether this is heaving as expected in interop with other ML-DSA implementations?

Tests are passing after the merge of https://github.com/open-quantum-safe/liboqs/pull/1919, so the PR is now ready.

@feventura: It would be great if you could amend this PR to incorporate the updated composite signature support. Alternatively, you could submit a follow-up PR for those changes.

@bhess I look at the changes and I think it does not require any change for the composite. The composite OIDs used in there expect to use ML-DSA not dilithium.
The composite interop will still fail, but that's because I didn't implemented the -03 changes yet.

@feventura @johngray-dev do you have any feedback whether this is heaving as expected in interop with other ML-DSA implementations?

@dstebila I don't think there is interop with this PR and other implementations, but as soon as this is merged and the openquantumsafe/oqs-ossl3 is updated we will see the results of the interop in the Automated Interop Table.
Right now, oqs is failing on the ML-DSA interop, I expect that this PR will fix it.

Thank you, @baentsch and @tomato42, for pointing out the ML-DSA code points. I’ve updated the PR accordingly.

@dstebila I don't think there is interop with this PR and other implementations, but as soon as this is merged and the openquantumsafe/oqs-ossl3 is updated we will see the results of the interop in the Automated Interop Table. Right now, oqs is failing on the ML-DSA interop, I expect that this PR will fix it.

It would be nice to see the results of these interop tests this before we release liboqs 0.12.0. @feventura If I'm understanding correctly what you wrote here, the tests will run automatically when a new version of oqs-ossl3:latest is pushed to Docker Hub. If that is indeed the case, what about (manually?) building and pushing a new image based on liboqs 0.12.0-rc1 and this branch of oqs-provider as part of the pre-release testing process? Tagging @baentsch and @ajbozarth as the people who likely know most about the feasibility of doing this.

what about (manually?) building and pushing a new image based on liboqs 0.12.0-rc1 and this branch of oqs-provider as part of the pre-release testing process?

Good idea and easily doable. But a bit "unfriendly" towards "unsuspecting" users of that image. @feventura : Is there any chance one can tweak the tag pulled for that automatic test? When I made these images available a few years (really?) back, I always tagged them ":ietfxyz" to ensure the right image is used at the IETF xyz hackathon event. Would you know who could change that from ":latest" to maybe also run the automated test on a tag like ":prerelease"? Or even simpler: What'd be needed for us (s part of the release process) to create such a test matrix?

If I'm understanding correctly what you wrote here, the tests will run automatically when a new version of oqs-ossl3:latest is pushed to Docker Hub.

Not quite @SWilson4, correcting myself, the actions will not run automatically when a new version of oqs-ossl3 is published, instead it will run when a push is done to any branch, but I or any with admin access (including you @baentsch ) could go there and trigger a new run on the git actions after the image is updated.
Now for the interop with this PR I see three options:

I or @baentsch  can create a branch on the hackathon repository and make change the tag for the docker image. That page would not be uploaded to the hackathon github (because the action only upload when is run from main) but the .html that would be uploaded can be downloaded.
Run this tests locally, and since this is already on gitaction someone could clone the hackathon repository and run the actions using act after making the changes on the tag for the docker image.
Run the test manually, here is how you do it https://github.com/IETF-Hackathon/pqc-certificates/blob/master/docs/compat_matrix_instructions.md, the only change is that we are using R4 format, not R3.

any with admin access (including you @baentsch )

Yikes. I still have these rights?!? I'll surely not use them without knowing exactly what I'd need to do -- I simply didn't follow the development on the hackathon github (but assumed @praveksharma does).

Now for the interop with this PR I see three options:

Thanks for that explanation . Option 1 is imo too "heavy handed"; option 3 sounds like the fastest short-term approach and option 2 like the best "CI-able" long-term approach.
Considering @praveksharma both volunteered doing the release and also participates in the hackathon (right?) may I suggest him taking on implementing option 3 in the release test script, followed by 2 in CI (or just 2 if quick-and-easy) to enhance the quality of the release testing in the long run?

I created some artifacts using liboqs and ML-DSA and manual testing shows they interop with the other providers in our hackathon project.   However, the docker image openquantumsafe/oqs-ossl3  that is used is still failing to verify all artifacts.  Is this docker image picking up the latest 012.0 (or even the 0.12r1) version of liboqs?   I suspect it must not, otherwise the automated  table from the hackathon  would be showing oqs passing with positive results (instead of failing).

The liboqs code base or version does not describe the functionality in an oqsprovider until both are released and documented to work together. Only an oqsprovider 0.8.0 (or as of yesterday, main) will work with liboqs 0.12.0: We had been waiting for the interop confirmation before landing the final (O)IDs. Now the docker image can follow (manually or automatically built as per preference, e.g., of @praveksharma ).

@feventura: It would be great if you could amend this PR to incorporate the updated composite signature support. Alternatively, you could submit a follow-up PR for those changes.

@bhess I look at the changes and I think it does not require any change for the composite. The composite OIDs used in there expect to use ML-DSA not dilithium. The composite interop will still fail, but that's because I didn't implemented the -03 changes yet.

@feventura @johngray-dev do you have any feedback whether this is heaving as expected in interop with other ML-DSA implementations?

@dstebila I don't think there is interop with this PR and other implementations, but as soon as this is merged and the openquantumsafe/oqs-ossl3 is updated we will see the results of the interop in the Automated Interop Table. Right now, oqs is failing on the ML-DSA interop, I expect that this PR will fix it.

As mentioned above, I manually used libOQS 0.12 to interop with the other implementations in the IETF hackathon, and it works.   We are still waiting for the dockerhub image to be updated to 0.12.  Once that is done the automated interop table look much better!


External Dependencies

More of a question than anything else.
Why doesn't this ecosystem use cmake externalproject fetchcontents conan etc for managing dependencies between projects such as xacc. I'm sure you have good reasons, I'm just not understanding why.

I'm closing this as is a discussion topic rather than an issue.


Fix #96 pydocstyle 2.0.0

Coverage increased (+0.8%) to 77.869% when pulling 30557f36164f5c6b3f3f91bb8a28d03e96294848 on diraol:fix-96-pydocstyle_v2 into 5ec2927f332708c76103bf199d05094c8a92badf on klen:develop.

Coverage increased (+0.2%) to 77.254% when pulling 7b6401eae4f4f1a30f26556eb4f6aa62b807a2e7 on diraol:fix-96-pydocstyle_v2 into 5ec2927f332708c76103bf199d05094c8a92badf on klen:develop.

Coverage remained the same at 77.049% when pulling f9749dab8f75f55293bb9e336fb9293aa262823b on diraol:fix-96-pydocstyle_v2 into 5ec2927f332708c76103bf199d05094c8a92badf on klen:develop.

Coverage increased (+0.05%) to 77.096% when pulling f96f84024e65968df8bea07c6e9c94779301910a on diraol:fix-96-pydocstyle_v2 into 5ec2927f332708c76103bf199d05094c8a92badf on klen:develop.

Coverage increased (+0.05%) to 77.096% when pulling 92165c850ad8e048403cdb5565bec3a41474141d on diraol:fix-96-pydocstyle_v2 into 5ec2927f332708c76103bf199d05094c8a92badf on klen:develop.

This PR depends on #98.

Coverage increased (+0.05%) to 77.096% when pulling 178f227e6af58ac5c6e04ae1428a6f0fd82f3bd2 on diraol:fix-96-pydocstyle_v2 into 5ec2927f332708c76103bf199d05094c8a92badf on klen:develop.

Coverage increased (+0.05%) to 77.096% when pulling 9f331a7bb6c6c675f9adf9094fdec883b3c78237 on diraol:fix-96-pydocstyle_v2 into 5ec2927f332708c76103bf199d05094c8a92badf on klen:develop.

The commit 9f331a7bb6c6c675f9adf9094fdec883b3c78237 fixes #98 by removing support to python2.6, specially on tests.
If on #98 it is decided not drop the support, just let me know and I'll remove the commit from this branch. (but it will not pass on the tests and I don't know how to fix it, since a dependency from this project has dropped the support for py26).

@klen
Please review/merge.

Looks good. @diraol Thank you!


Add catch for invalid answers in AreYouOk.py

If the user adds an invalid answer, currently the program just crashes.
There should be a catch implemented for this.
I will implement this for AreYouOK.py.

This is done. I implemented and tested it and my work is in PR #968.


Problems with checkboxes arrays

Following the problem described here [1], I can't retrieve an entire array passed with a checkbox via post with $app-request->post('sel[]'). Maybe, I think, this is a (silent?) bug.
[1] - http://help.slimframework.com/discussions/problems/8449-problems-with-checkbox

Hi @jrborbars,
This is very delayed but I had some spare time to contribute.  You can access the values by using $app->request->post('sel').  I stood up a test instance and confirmed this myself.
An important thing to note is that if you're getting a POST'd array directly via the request and none of the checkboxes are checked, you simply end up with a null.

Hi cwscribner,
Thanks (a lot) for your reply, but I think that you not "catch" my problem. Your solution works well with ONLY ONE value selected in checkboxes. If I select multiple values only the LAST value return (checked with var_dump). And yes, I was checked some checkboxes to receive this values...... I never said that the array was returned empty. ;-)

@jrborbars no problem :-)
I should've clarified in my original response, I was able to successfully retrieve more than one selected checkbox using $app->response->post('sel').  My tests were:
0 checkboxes checked -- returns null
1 checkbox checked -- returns $_POST['sel'][0]=>on
2 out of 4 checkboxes checked -- returns $_POST['sel'][0]=>on, [1]=>on

@cwscribner,
What's your version of Slim? I'm using 2.4.2 and can't do this. 8-(
The code:
######## HTML #####################################

######## CONTROLLER/ROUTE ########################
$sel = $app->request()->post('sel');
echo "";
var_dump($sel);
echo "";
######## RESULT ####################################
Result of var_dump:
string(1) "3"
######## FIREBUG ###################################
Post:
sel	2
sel	3
####################################################
Other inputs in the same form are catched by $app->request()->post() easy (no one have the same name or id!). Other ideas?
Thanks A LOT and best regards.

I believe I'm using the most recent stable version (2.5).  I don't have access to it at the moment so I can't confirm 100%.
One other thing you could try is using $app->request->params() or $app->request->params('sel') just to see if that returns anything.  Do you have any of this code in a repo anywhere?  I could probably investigate more thoroughly if I could see the code in full context.

I will try to post it in a gist soon.
So I tested to put individual names to each checkbox ('sel1', 'sel2', 'sel3'), and it WORKS. Worked to if names are 'sel[1]', 'sel[2]', 'sel[3]',etc. But doesn't works if names are 'sel' only (for all checkboxes) or 'sel[ ]' (without the inner space).
NOTE: Now I see my typo in the $app->request above. But it works (believe in me ;-). )
WRONG  ------> $app->request()->post('sel');
RIGHT     ------> $app->request->post('sel');

So for my own clarification, fixing the typo fixed the issue you are having?

No. The behaviour still wrong. The checkbox with ONE name must return an array. The "solution that works" before is only a workaround that I tried, putting individual names and POST returning individual variables.
So, with my typo or not, the POST do the job (with only one name for each variable).

Ah, okay.  Without seeing your full code, I don't think I can diagnose any further.  I was successfully able to pass multiple checkboxes with the same name (sel[]) and retrieve them as an array using $app->request->post() and $app->request->post('sel').  This was using Slim 2.4.2.

$app->request is an alias for $app->request(); both work. And I confirm the behavior described by @cwscribner, $app->request->post("sel") returns the array, even using 2.4.2 version. To return just the last value, the checkboxes must be <input name="sel"> instead of <input name="sel[]"> or <input name="sel[n]">, the expected behavior.

I don't think this is a bug as others have pointed out here, this actually works. Can we move the discussion back over to http://help.slimframework.com/discussions/problems/8449-problems-with-checkbox if you wish to continue or jump on irc channel #slimphp on freenode.

Hummmmm.
This is very strange. I see with more attention the @tassoevan response, that said that $app->response->post('sel') catch the input of name="sel[]". I tried and the result (var_dump) is NULL. So, this is not a server issue. Oh! Now I remember that I'm using HHVM 3.4.2, not Zend PHP, with a Nginx HTTP server. But this type of post array works with raw PHP and, IMHO, this still not a server issue. Continue in help.slimframework,com.


Framebuffer is Aligned to Full Window Rect

Commit: 209ab92
Platform: Windows 10
GPU: Intel HD Graphics P630 (sigh)
Backend: WGL
Reference: https://github.com/zacps/alacritty/issues/26
I've tracked the reference issue back to glutin but have hit a wall. Using the window example with the following change:
diff --git a/examples/support/mod.rs b/examples/support/mod.rs
index 9fe30c3..208422e 100644
--- a/examples/support/mod.rs
+++ b/examples/support/mod.rs
@@ -76,9 +76,9 @@ impl Gl {
 }

 static VERTEX_DATA: [f32; 15] = [
-    -0.5, -0.5, 1.0, 0.0, 0.0,
-    0.0, 0.5, 0.0, 1.0, 0.0,
-    0.5, -0.5, 0.0, 0.0, 1.0
+    -1.0, -1.0, 1.0, 0.0, 0.0,
+    0.0, 1.0, 0.0, 1.0, 0.0,
+    1.0, -1.0, 0.0, 0.0, 1.0
 ];

Results in the following on Intel HD Graphics:

For reference, allocating a sensible GPU (NVIDIA) resolves the issue, but uses more power:

By aligning windows manually I've found that the framebuffer is aligned to the outer window size, and confirmed this by disabling the chrome/border (the issue disappears). I've also messed about with DPI settings (no effect).
If a workaround is needed (this is Intel HD we're talking about - the bug is almost certainly in their driver), it might be possible to hosting a borderless child window/control and using that for the DC.

Surprise surprise, it's an Intel issue.
The <IP_ADDRESS>86 (latest) drivers resolve the issue.


Add to NPM and CDNJS ?

Hi,
It would be nicer if the package is added to npm & CDNJS.

Yes indeed, we will soon
Thanks


Replace reflect.DeepEqual with dedicated Equals methods

Signed-off-by: davidsbond<EMAIL_ADDRESS>What this PR does / why we need it:
Found a TODO comment to remove a couple usages of reflect.DeepEqual for comparing some types. I've added Equals methods for ChallengeStatus, OrderStatus, ACMEAuthorization and ACMEChallenge and switched the commented code to use those instead.
Release note:
NONE

Thanks for this however I am not too sure if this is more efficient, we always like the option of adding more fields to objects which now would have the risk not being unit tested properly

/kind cleanup

Thanks for this however I am not too sure if this is more efficient, we always like the option of adding more fields to objects which now would have the risk not being unit tested properly

Yeah, after I opened this I sort of realised that now you don't just have it automatically picking up any extra fields. Happy to close this or just remove the equality checks like @wallrj suggested

Use apimachinery..Semantic.DeepEqual() to correctly handle comparisons of metav1.Time and resource.Quantity

This is something we should be doing here - and there's at least one place that I can recall where we actually serialise the status to json before comparing as we kept running into issues with it 🙈 a switch to the semantic DeepEqual method would be great.

Implement some sort of hashing mechanism where we calculate a checksum of only the fields that we're interested in and compare these.

I think this is overkill in this case given we can just compare the fields as we do today/with the semantic package.

Another option is to remove the equality check altogether. Afterall, the API server will presumably do it's own equality check before bothering to update the Status data in Etcd and presumably it will only update the Object resource version if any of the fields have changed, so an identical status should not trigger another reconcile.

I'm not 100% confident that this is the case, and I know we added this in previously because it wasn't the case. So for the sake of peace of mind, I'd be inclined to keep this check (and besides, it saves a network round-trip & http request at the cost of what's probably nanoseconds worth of computation to run the equality check).

As an aside: sorry for the very old and leftover ambiguous comments 😅


Update layers/meta-balena digest to 03d8e7b

This PR contains the following updates:

Package
Update
Change

layers/meta-balena
digest
0da22de -> 03d8e7b

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@balena-ci I self-certify!


NLOG Database Target Logs are dropping when writing more than 5000 logs consecutively with async true

NLOG Database Target Logs are dropping when writing more than 6000 logs consecutively with async true. I am not sure this is bug (or) known limitation.
NLOG  Config:
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">

  <!--
  See http://nlog-project.org/wiki/Configuration_file
  for information on customizing logging rules and outputs.
   -->
  <targets async="true">
    <!-- add your targets here -->
    <target name="f" xsi:type="File"
       layout="${longdate} ${logger} ${level} ${message} ${exception:format=tostring}"
       fileName="${basedir}/logs/current.log"
       archiveFileName="${basedir}/logs/archive.{#}.log"
       archiveEvery="Day"
       archiveNumbering="Rolling"
       maxArchiveFiles="7"
       concurrentWrites="true"
       keepFileOpen="true"
       autoFlush="true"
       encoding="iso-8859-2" />

      <target xsi:type="Database" name="db" keepConnection="false">
        <!-- SQL command to be executed for each entry -->
        <commandText>INSERT INTO [LogTable](time_stamp, Level, Logger,Message) VALUES(getutcdate(),@level, @logger,@msg)</commandText>
        <!-- parameters for the command -->
        <parameter name="@msg" layout="${message}" />
        <parameter name="@level" layout="${level}" />
        <parameter name="@logger" layout="${logger}" />

        <!-- connection string -->
        <dbProvider>System.Data.SqlClient</dbProvider>
        <connectionString>server=.\SQLEXPRESS;database=NLOGDB;integrated security=sspi</connectionString>
      </target>

  </targets>

  <!-- Add your logging rules here.  -->
  <rules>
    <logger name="*" minlevel="Info" writeTo="f" />
    <logger name="*" minlevel="Info" writeTo="db" />
  </rules>

</nlog>

C# Code:
 static void Main(string[] args)
        {
            Logger logger = LogManager.GetCurrentClassLogger();
            for (int i = 0; i < 15000; i++)
            {
                logger.Error("sample log message"+i);
                //if(i%1000 == 0)
                //LogManager.Flush();
            }
            Console.WriteLine("Completed");

}

NLog Configuration won't allow any flush for targets but file target it will allow flush.
if i use LogManager to flush then it is working database target as Log Manager works with all Targets.

Hi, this is by design and configurable. See https://github.com/NLog/NLog/wiki/AsyncWrapper-target#async-attribute-will-discard-by-default

Thanks for quick response.. Appreciate your Efforts..
Changed NLog Config:

<!-- add your targets here -->
<!--<target name="f" xsi:type="File"
   layout="${longdate} ${logger} ${level} ${message} ${exception:format=tostring}"
   fileName="${basedir}/logs/current.log"
   archiveFileName="${basedir}/logs/archive.{#}.log"
   archiveEvery="Day"
   archiveNumbering="Rolling"
   maxArchiveFiles="7"
   concurrentWrites="true"
   keepFileOpen="true"
   autoFlush="true"
   encoding="iso-8859-2" />-->

<target xsi:type="AsyncWrapper" name="dbwrapper" queueLimit="20000" timeToSleepBetweenBatches="50" batchSize="100" overflowAction="Discard">
  <target xsi:type="Database">
    <!-- SQL command to be executed for each entry -->
    <commandText>INSERT INTO [LogTable](time_stamp, Level, Logger,Message) VALUES(getutcdate(),@level, @logger,@msg)</commandText>
    <!-- parameters for the command -->
    <parameter name="@msg" layout="${message}" />
    <parameter name="@level" layout="${level}" />
    <parameter name="@logger" layout="${logger}" />

    <!-- connection string -->
    <dbProvider>System.Data.SqlClient</dbProvider>
    <connectionString>server=.\SQLEXPRESS;database=NLOGDB;integrated security=sspi</connectionString>
  </target>
</target>

I tried that previously also...Even now also i tried, It is not working consistently. It will work 1 in 20 times..Do you any idea about this?. All the examples of AsyncWrapper applied to File Target not to Database Target. I am interested in Database Target. do you got chance to try AsyncWrapper with Database Target?.

Has your question being answered?

Yes..Thanks for the response..


Enhancement/documentation

Added extension to list all classes and methods. See picture.

The failed tests are from DemexClient(testnet)


Encapsulate transition relation to isolate class

Maybe making classes for transition relation would be good after all. Lets try to discuss here.
The reason is that we actually will want to modify the data structures,
mainly to make extensions of the library. So far, it seems that we will want to:

include counters
include general registers
have a version that mixes BDDs with automata - has binary alphabet and levels of states.

And we will probably want to be able to fine tune some data structures after all. Maybe not much and often, but it would be good to make it possible.

@kilohsakul is this solved by the current changes?


[MySQL Conformance] fix tree size bug

This returns the logic back to how it was before #281. This addresses part of #364, but I think only fixes a special case for full tiles. I think this needs more to address requesting partial sizes slightly larger than the current tree size.

There is also a bug in the mysql_test/TestTileRoundTrip. The nodeIndex should be replaced with nodeIndex+1 when passing into the s.ReadTile.
https://github.com/transparency-dev/trillian-tessera/blob/26d856727a8823585e99f9b381731476a549b987/storage/mysql/mysql_test.go#L288-L289

@roger2hk @AlCutter PTAL - this is passing the tests now.


feat: adds axell to the token ring

Token ring is the logo:

The whole point of a webring is to drive traffic from each others sites without the use of a search engine or indexer. Simply setting the icon as your logo provides no connection to the webring and does not provide visitors any way of knowing about, or accessing the rings index. Check out what other users on the ring have done and try and use the example code in the readme, then submit another request.

Sorry had to try the lazy way 😛. Will do.


golint fixed for modules/base

Current coverage is 3.03% (diff: 0.00%)

Merging #231 into master will increase coverage by <.01%

@@            master      #231   diff @@
========================================
  Files           33        33
  Lines         8107      8106     -1
  Methods          0         0
  Messages         0         0
  Branches         0         0
========================================
  Hits           246       246
+ Misses        7841      7840     -1
  Partials        20        20

Powered by Codecov. Last update 3917ed4...fb3bb69

LGTM but please try to keep comments as english phrases (This does that.)

LGTM

resolved #70


Check the Machine Failure domains conform with CPMS

Check:

Nova availability zones
Root volume Cinder availability zones and volume types
Additional networks

/retest

/approve
/lgtm
unless the test says no.

/cherry-pick release-4.14


ShareToTeams script no option to share to person while this is mentioned in the docs.

Hi,
While creating a ShareToTeams button we noticed a discrepancy between the docs and the actual functionality.
In the docs it is clearly stated it can be used to share something directly with a person.
See Create Share-to-Teams button first paragraph

Third-party websites can use the launcher script to embed Share-to-Teams buttons on their webpages. When you select, it launches the Share-to-Teams experience in a pop-up window. This allows you to share a link directly to any person or Microsoft Teams channel without switching the context. This document guides you on how to create, and embed a Share-to-Teams button for your website, craft your website preview, and extend Share-to-Teams for Education.

While testing a ShareToTeams button we were only allowed to share a link in a team or channel and not directly to another person.
Is this an error in the documentation or something related to the teams setup on our end?

Hi @milandebuck Thanks for reaching out to us. We are checking this issue internally and get back to you.

@milandebuck We are able to repro the issue with public version. We have raised a bug and our Engineering team will work on it.

@Jagadeesh-MSFT  I am still able to reproduce this issue. Seems like it is not yet out there for all users.

Doesn't work for me either ➕

The issue is still reproducible for me for both accounts that I've tried

Still reproduces, 2 different accounts

Hi we took this issue to our Engineering team we will let you know once issue is fixed.

I am having this issue as well. What's strange in our case, is that we have at least one user who CAN search for users using this implementation, yet myself and several other developers are not able to search for users; only Teams/Channels.
I take it this has not been resolved?

@cecil-jolley - could you please share sceenshot of what you see in Share To Microsoft Teams UI? Also share for the users who are able to do it.

@cecil-jolley - could you please share sceenshot of what you see in Share To Microsoft Teams UI? Also share for the users who are able to do it.

Absolutely, the first two are screen shots of what we see. We are only able to search for Teams/Channels, and the placeholder text even states 'Search for a Team or Channel'

Here is a screenshot from one of our developers where he IS able to search for users:

@cecil-jolley -  This feature would be enabled in public rings in next few weeks.

@cecil-jolley - This feature is enabled. Please feel free to re-open this issue if you are still facing the issue.


timers not working for MacVim run in GUI mode

I reported Shougo/neocomplete.vim#563, in which @Shougo tracked the issue down to the timers feature not working in MacVim as a GUI application. The odd thing is that timers works fine when running MacVim within my terminal (iTerm2) via mvim -v. This issue also relates to maralla/completor.vim#35.
In Shougo/neocomplete.vim#560, @Shougo mentions he is not able to reproduce this issue in GVim, so this is specific to MacVim.
Environment
OS X 10.11 El Capitan
$ brew info macvim
macvim: stable 8.0-114 (bottled), HEAD
GUI for vim, made for macOS
https://github.com/macvim-dev/macvim
/usr/local/Cellar/macvim/8.0-113 (2,102 files, 33.5M)
  Built from source on 2016-10-27 at 12:33:22 with: --with-python3 --without-python --with-lua --with-luajit
/usr/local/Cellar/macvim/8.0-114 (2,107 files, 33.6M) *
  Built from source on 2016-11-07 at 09:20:23 with: --with-python3 --without-python --with-lua --with-luajit
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/macvim.rb
==> Dependencies
Recommended: cscope
Optional: lua, luajit
==> Requirements
Build: xcode
Recommended: python
Optional: python3
==> Options
--with-custom-python
	Build with a custom Python 2 instead of the Homebrew version.
--with-lua
	Build with lua support
--with-luajit
	Build with luajit support
--with-override-system-vim
	Override system vim
--with-python3
	Build with python3 support
--without-cscope
	Build without cscope support
--without-python
	Build without python support
--HEAD
	Install HEAD version
==> Caveats
.app bundles were installed.
Run `brew linkapps macvim` to symlink these to /Applications.

$ mvim --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Nov  7 2016 09:20:12)
MacOS X (unix) version
Included patches: 1-52
Compiled by Homebrew
Huge version with MacVim GUI.  Features included (+) or not (-):
+acl             +find_in_path    -mouse_sysmouse  -tag_any_white
+arabic          +float           +mouse_urxvt     +tcl
+autocmd         +folding         +mouse_xterm     +termguicolors
+balloon_eval    -footer          +multi_byte      +terminfo
+browse          +fork()          +multi_lang      +termresponse
++builtin_terms  +fullscreen      -mzscheme        +textobjects
+byte_offset     -gettext         +netbeans_intg   +timers
+channel         -hangul_input    +num64           +title
+cindent         +iconv           +odbeditor       +toolbar
+clientserver    +insert_expand   +packages        +transparency
+clipboard       +job             +path_extra      +user_commands
+cmdline_compl   +jumplist        +perl            +vertsplit
+cmdline_hist    +keymap          +persistent_undo +virtualedit
+cmdline_info    +lambda          +postscript      +visual
+comments        +langmap         +printer         +visualextra
+conceal         +libcall         +profile         +viminfo
+cryptv          +linebreak       -python          +vreplace
+cscope          +lispindent      +python3         +wildignore
+cursorbind      +listcmds        +quickfix        +wildmenu
+cursorshape     +localmap        +reltime         +windows
+dialog_con_gui  +lua             +rightleft       +writebackup
+diff            +menu            +ruby            -X11
+digraphs        +mksession       +scrollbind      -xfontset
+dnd             +modify_fname    +signs           +xim
-ebcdic          +mouse           +smartindent     -xpm
+emacs_tags      +mouseshape      +startuptime     -xsmp
+eval            +mouse_dec       +statusline      -xterm_clipboard
+ex_extra        -mouse_gpm       -sun_workshop    -xterm_save
+extra_search    -mouse_jsbterm   +syntax
+farsi           +mouse_netterm   +tag_binary
+file_in_path    +mouse_sgr       +tag_old_static
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -L/usr/local/lib -L. -L/usr/local/lib  -L/usr/local/lib -o Vim -framework Cocoa -framework Carbon       -lm  -lncurses -liconv -framework Cocoa  -pagezero_size 10000 -image_base 100000000 -L/usr/local/opt/luajit/lib -lluajit-5.1 -fstack-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE -lperl  -L/usr/local/opt/python3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/config-3.5m -lpython3.5m -framework CoreFoundation -F/System/Library/Frameworks -framework Tcl -framework CoreFoundation -framework Ruby

can you write a short Vim script to repro the issue?

At least, timer unittests including testdir/test_timers.vim works with GUI. GUI_FLAG=-fg make test.

@splhack I'm sorry.  I only know the effects of this on neocomplete.
Maybe @Shougo or @maralla would have an idea on how to demonstrate this issue in a small script.

It seems the timer_stop function blocked by something, becauee when you move the mouse cursor or type any candidate characters, than the popup menu just showed like I demo in those screencasts.

@markwu is there any chance to check and modify test_timers.vim to repro the issue? timer_stop seems ok for me, at least in the test.

I really hope I can help. But, I am not familiar with timer and completion in vimscript, I just know how to reproduce problem with these plugins.

I think test_timers.vim does not test timer feature in insertmode.

It seems timers work well as excepted, but there is something when input >. Maybe related highlighting bracket in Insert mode.

I try to disable matchit.vim at start by add this line to my vimrc
let loaded_matchparen = 1
Nothing changed.

This problem is due to feedkeys() in timer callback.
nnoremap <F5> :<C-U>call TimerStart()<CR>
fu! TimerStart()
  call timer_start(50, 'Feedkeys')
endfu
fu! Feedkeys(...)
  call feedkeys('iabc')
endfu

Keying <F5>, on TUI shows "abc" promptly, but on GUI MacVim doesn't show it until other any input (keyboard or mouse cursor moved) given.
The reason is, GUI has not check input buffer typebuf after timer callback.
https://github.com/vim/vim/blob/ca8b8d6/src/gui.c#L2869
when invoked timer callback in check_due_timer(), due_time is set to -1.
https://github.com/vim/vim/blob/ca8b8d6/src/gui.c#L2877
so gui_mch_wait_for_chars() waits for input forever.
Thus, when feedkeys() is called in callback, the input of feedkeys() must be handled in gui_mch_wait_for_chars() but MacVim does not so and simply waits for input.
Other GUI Vim, gui_win32;
https://github.com/vim/vim/blob/ca8b8d6/src/gui_w32.c#L2100
gui_gtk_x11;
https://github.com/vim/vim/blob/ca8b8d6/src/gui_gtk_x11.c#L6648
both of these have checked input_available(), which returns TRUE if feedkeys() gave input, in gui_mch_wait_for_chars ().

@ichizok Thanks for chasing that down!
@splhack Can we please re-open this issue, since the initial fix was reverted?

I just wondering why revert the fix? Anything wrong?

via Newton Mail
[https://cloudmagic.com/k/d/mailapp?ct=pi&cv=9.2.5&pv=10.1.1&source=email_footer_2]
loooop


Add compatibility to PHP8

Thank you for this MR.
I think I'll try to update and run Travis with php version 8 before merging it.
Nicolas.

Hello,
I need to migrate my application to php8 in September 2021. Do you have a date for the compatibility?
Thank you for your work which is remarkable.

Hello @ColonelMoutarde I'm not sure that the syntax you used in the composer.json file was correct.
Anyway, I've merged to master the PR #29 that will allow to use PHP8.
Feel free to tell me if this works for you.
Nicolas.


Add methods from List/Map to Listing/Mapping

Methods that "project out" of the type can be added to Listing and Mapping to avoid having to use toList()/toMap(). Methods that result in a Listing, resp. Mapping, are not included for performance and (lazy) semantics reasons, but methods like contains etc. can be defined straightforwardly.

I'm missing any and every for Listing.


Choose input and output formats

Need to decide on input and output formats (current implementation is arbitrary). This may require consideration of the Dfam pipeline.

Done. Using Stockholm and a simple bespoke matrix format for input and SODA + table for output.


Timestamp for the message should be created right after acquiring the image

To facilitate more accurate latency measurement with rostopic delay, the timestamp for camera image should be created right after acquiring the image, not before publishing the message.

The timestamp is captured here, and is extracted from the image handle from the camera.
It wouldn't make any difference to move the ros timestamp calculation  earlier in the camera pipeline.
If you think it's clearer to store the ros timestamp directly as CameraBase class member I can do that.

Thanks, this escaped my attention.


Unable to install

I must be doing something fundamentally wrong, but I don't know what.
I'm using Vundle to install. I added the repo to the .vimrc file, and :PluginInstall downloads the repo to the local machine.
However, :OmniSharpInstall gives me the error message: E492: Not an editor command: OmniSharpInstall
If I try manually installing the server and then open a .cs file, I get:
Could not find solution file or directory to start server
I'm running VIM 8.0 on an Ubuntu 18.04

:OmniSharpInstall, like all other OmniSharp-vim commands, only works from a .cs buffer. It is also unnecessary - if you open a .cs file, OmniSharp-vim should download the OmniSharp-roslyn server itself. Did that not happen?
What is your project structure like? That error message is pretty clear ... no .sln has been found for your .cs file. If you want to start a server without a .sln, you can try:
let g:OmniSharp_start_without_solution = 1

Aah!
The "Start without solution" fixed my specific problem.
Not sure it's fixed my general problem, however. The thing is that I'm trying to write some scripts for use in a Unity project. So I don't necessarily have a solution, as far as I know.
Thanks for the help, though! I was able to move on to my next unexpected roadblock (also known as progress). :)

I have the same problem, trying to use vim with unity and I get the error
 CS0246: The type or namespace nameUnityEngine' could not be found. Are you missing an assembly reference?`
On the other hand
:OmniSharpInstall gives me the error message: E492: Not an editor command: OmniSharpInstall
Could you help on this one? @Rayal how did you solve this?
Maybe something could be added to the documentation about this. It is nebulous.

Nebulous?
Neither of you has said what happens when you open a .cs file - does OmniSharp-vim not offer to install the server?
@aleksfadini as I said in my first response, :OmniSharpInstall and all other OmniSharp-vim commands only work from .cs files. If that command is not available from a .cs file, then the plugin is not installed correctly.
The README has a lot of information about installing the server (and the plugin). Is there something specific that the README doesn't explain?

@aleksfadini where are you getting the error you mention: CS0246: The type or namespace nameUnityEngine' could not be found. Are you missing an assembly reference?? In Vim? Presumably the OmniSharp-vim and OmniSharp-roslyn are installed and working if you are getting code errors?


Agent doesn't start after docker stop/start

Agent version and platform
2.111.1
ubuntu.16.04(as docker container)
VSTS type and version
VisualStudio.com
http://mediatonic-catapult.visualstudio.com
What's not working?
I am running agent as docker container using official image vsts-agent-docker
docker run -d --restart=always -e VSTS_ACCOUNT=mediatonic-catapult -e VSTS_TOKEN=**** -e VSTS_AGENT='$(hostname)-agent' -e VSTS_POOL=Default -e VSTS_WORK='/var/vsts/cat-agent' -v /var/run/docker.sock:/var/run/docker.sock -v /var/vsts:/var/vsts -v /.nuget:/.nuget -v /.local:/.local  microsoft/vsts-agent:ubuntu-16.04-docker-1.12.1-standard
First time it works fine but after restarting host vm or just doing docker stop/start agent quits immediately with An error occurred: Not configured
Agent and Worker's diag log
[2017-02-06 12:13:11Z INFO AgentProcess] Agent is built for Linux - ubuntu.16.04-x64.
[2017-02-06 12:13:11Z INFO AgentProcess] RuntimeInformation: Linux 4.4.0-62-generic #83-Ubuntu SMP Wed Jan 18 14:10:15 UTC 2017.
[2017-02-06 12:13:11Z INFO AgentProcess] Version: 2.111.1
[2017-02-06 12:13:11Z INFO AgentProcess] Commit: f2b339f02e4065d8500c918d883f50c347b7ba57
[2017-02-06 12:13:11Z INFO AgentProcess] Culture:
[2017-02-06 12:13:11Z INFO AgentProcess] UI Culture:
[2017-02-06 12:13:11Z INFO HostContext] Well known directory 'Bin': '/vsts/agent/bin'
[2017-02-06 12:13:11Z INFO HostContext] Well known directory 'Root': '/vsts/agent'
[2017-02-06 12:13:11Z INFO AgentProcess] Validating directory permissions for: '/vsts/agent'
[2017-02-06 12:13:11Z INFO CommandLineParser] Parse
[2017-02-06 12:13:11Z INFO CommandLineParser] Parsing 1 args
[2017-02-06 12:13:11Z INFO CommandLineParser] parsing argument
[2017-02-06 12:13:11Z INFO CommandLineParser] HasArgs: False
[2017-02-06 12:13:11Z INFO CommandLineParser] Adding Command: run
[2017-02-06 12:13:11Z INFO AgentProcess] Arguments parsed
[2017-02-06 12:13:11Z INFO ProxyConfiguration] No proxy setting found.
[2017-02-06 12:13:11Z INFO Agent] ExecuteCommand
[2017-02-06 12:13:11Z INFO ConfigurationStore] currentAssemblyLocation: /vsts/agent/bin/Agent.Listener.dll
[2017-02-06 12:13:11Z INFO ConfigurationStore] binPath: /vsts/agent/bin
[2017-02-06 12:13:11Z INFO ConfigurationStore] RootFolder: /vsts/agent
[2017-02-06 12:13:11Z INFO ConfigurationStore] ConfigFilePath: /vsts/agent/.agent
[2017-02-06 12:13:11Z INFO ConfigurationStore] CredFilePath: /vsts/agent/.credentials
[2017-02-06 12:13:11Z INFO ConfigurationStore] ServiceConfigFilePath: /vsts/agent/.service
[2017-02-06 12:13:11Z INFO CommandSettings] Flag 'help': 'False'
[2017-02-06 12:13:11Z INFO CommandSettings] Flag 'version': 'False'
[2017-02-06 12:13:11Z INFO CommandSettings] Flag 'commit': 'False'
[2017-02-06 12:13:11Z INFO CommandSettings] Command 'configure': 'False'
[2017-02-06 12:13:11Z INFO CommandSettings] Command 'remove': 'False'
[2017-02-06 12:13:11Z INFO ConfigurationManager] LoadSettings
[2017-02-06 12:13:11Z INFO ConfigurationStore] IsConfigured()
[2017-02-06 12:13:11Z INFO ConfigurationStore] IsConfigured: False
[2017-02-06 12:13:11Z INFO ConfigurationManager] Is configured: False
[2017-02-06 12:13:12Z ERR  Terminal] WRITE ERROR: An error occurred: Not configured
[2017-02-06 12:13:12Z ERR  AgentProcess] System.InvalidOperationException: Not configured
   at Microsoft.VisualStudio.Services.Agent.Listener.Configuration.ConfigurationManager.LoadSettings()
   at Microsoft.VisualStudio.Services.Agent.Listener.Agent.<ExecuteCommand>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Services.Agent.Listener.Program.<MainAsync>d__1.MoveNext()

@Rurouni
seems like the image will unconfig agent on SIGINT/SIGTERM
https://github.com/Microsoft/vsts-agent-docker/blob/c124d309a6ba1eece47bca1aa70f58f58bec8205/ubuntu/14.04/2.106.0/start.sh#L26

I seem to have had the same problem with the same configuration as the OP, however, when I did a docker ps, the status was "Restarting 2 hours".
Is this issue closed because it is fixed? Where is the documentation on a proper docker run command that ensures restart capabilities?

I don't think they fixed it, looks more like hey it's not our problem... in the end I have abandoned idea with docker restart and went for init script that restarts image with docker run -rm ...


[IOTDB-778] Do not handle measurement name with quotaion uniformly

https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-778

Just discussed with xiangdong about this PR. Why is this closed? It looks good, not?


The stream is not closed when the underlying connection closed?

Hi, I'm using tokio-yamux in my project, and this  tokio-yamux helps me a lot, thanks for this excellent lib.
I have encountered a problem.
I opened some streams, and copy the io from my served connections to those stream and also from those streams to my served connections.
I have tested an exceptional use case that when I close the server side of yamux, I expect that the copying threads should stop. but the reality is that it is still running.
So my question is: How to stop the Read or Write of the yamux stream, when the underlying connection is closed.
I  tried to add control.close() in the "next call thread" but it is still no use.
tokio::spawn(async move {
                loop {
                    match agent_session.next().await {
                        Some(_) => (),
                        None => {
                            debug!("closing session");
                            health_control.close().await;
                            break;
                        }
                    }
                }
            });

Is it something I ignored? or are there any other suggestion for this use case?

the copying thread is like below:
let client_to_server = async {
                        let r = tokio::io::copy(&mut rfront, &mut wback)
                            .await
                            .map_err(io_error!(e, "failed to copy from client to server"));
                        wback
                            .shutdown()
                            .await
                            .map_err(io_error!(e, "failed to shutdown proxy socket"))?;
                        r
                    };
let server_to_client = async {
                        let r = tokio::io::copy(&mut rback, &mut wfront)
                            .await
                            .map_err(io_error!(e, "failed to copy from server to client"));
                        wfront
                            .shutdown()
                            .await
                            .map_err(io_error!(e, "failed to shutdown agent socket"))?;
                        r
                    };

                    futures::try_join!(client_to_server, server_to_client)
                        .map_err(|e| {
                            let msg = format!("failed to copy stream: {}", e);
                            error!("{}", msg.as_str());
                            Other(msg)
                        })

After my review, this is a missing state machine transition, we didn't have this scenario before so didn't find it, thanks!
I'll fix it and release it as soon as I can, but if you're in a hurry, you can use the commit that PR fixes afterward first.

@abel-von Ok, now, you can try #260 pr


Non-default deploy commands do not break running the default one

What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5452
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

/approve
Tested this locally, works without error.

/hold

@feloy Do we want to wait for tests validating PR? Please remove unhold this PR if not.


Logging configuration ignored before the startup hooks chain execution

After the startup of my Revel application, some DEBUG logs are sent to the standard error channel with colors enabled, ever if the runMode is prod and regardless of the app.config configuration.
As example, this is the first log line after the app run. It is sent to the standard error:
DEBUG 12:00:38  revel  server.go:27: RegisterServerEngine: Registered engine   section=server name=go
OS: Windows 10
app.config (only log settings):
log.debug.prefix = "DEBUG "
log.info.prefix  = "INFO  "
log.warn.prefix  = "WARN  "
log.error.prefix = "ERROR "
[dev]
mode.dev=true
log.debug.output = stdout
log.info.output  = stdout
log.warn.output  = stderr
log.error.output = stderr
log.request.output = stdout
[prod]
mode.dev=false
log.debug.output = off
log.info.output  = off
log.warn.output  = stderr
log.error.output = stderr
log.request.output = off
log.colorize = false

I see this as well, it seems that Revel is logging it's engine start prior to evaluating the app configuration, so it gets quite a bit of logging done re: startup prior to taking config into account.

Yes, the proxy runner (when revel run is executed) is verbose with sending messages to the console. I will be adding code to the revel command to make this less verbose

This is resolved in the new revel command tool


One-Time permissions

Hi there,
I wondered if it's possible to give a group a one-time permission. With this I don't mean a temporary permission so they can use the command unlimited over a period of time. With this I mean that the group can only use the command once.
Thanks in advance!

This isn't the job of a permission plugin, but rather of whatever plugin handles the command.
LP doesn't check if command xyz was run, because it wouldn't make sense to do so and is also out of scope for it.

Wow, thanks for the fast reaction! I'll look for options in the plugin itself then.
Thanks for your help!

I agree, out of scope for now.


Gradle version in "gradle-wrapper.properties" is old

The gradle version in gradle-wrapper.properties is pretty old. The distribution URL needs to be updated distributionUrl=https://services.gradle.org/distributions/gradle-4.1-all.zip would suffice.

I would suggest to add gradle wrapper task instead of modifying gradle-wrapper.properties directly since that file is auto-generated:
task createGradleWrapper(type: Wrapper) {
    gradleVersion = '4.9'
}

Please refer to pull request #11


Floating Visualizer Fixes

About the PR
Fixes #13572
Fixes #13566
Added a nullspace check to IsWeightless
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

fix: Neither monkeys on the guidebook nor people outside your view float

Entities in null space just shouldn't be floating in the first place.

Entities in null space just shouldn't be floating in the first place.

Okay that was the core issue, fixed (someone merge for me cuz im gonna snooze)


Unable to give app permissions.

No permission request prompt either.
OnePlus 7
Android 10

Reopening app fixed it?!

Bluetooth off:

Bluetooth on:

I'm having the same issue on a Google Pixel 1, Android 10.
If I install the version from the Play Store, I get the prompt to turn on permissions. If I build the app on my machine and install it, I don't get the prompt, and permissions are off.

@dsamojlenko - thinking this has something to do with the whitelisted account (maybe).

@JuliannaR can we try to start tagging as Play store vs apk
Ideally all testing is being done via the Play store.  Looking to avoid it works when it's installed this way but not that way issues.

@timarney attempting to do this now.

@JuliannaR this should be re-tested if it hasn't been already.

@sidbmw is this still an issue?

@sidbmw is this still an issue?

Do you have an apk I can test?

Please see this -
https://github.com/cds-snc/covid-shield-mobile/issues/607#issuecomment-657108583
There's a version # in the Test menu now.

Closing this - this can be expected outside of our test tracks.


slim/psr7: dev-master

Any insights why slim/psr7 needs to be set at dev-master?
It looks like the latest tag is 0.4.0. Which has the last commit from August 2nd: https://github.com/slimphp/Slim-Psr7/commit/d312896b7cd4aca7d4b86b64acdfcb5cc3da758f
There have been 22 commits on the master branch since tag 0.4.0. I assume there is something in those 22 commits that is needed but hasn't been released yet?
However, slim/psr7:dev-master was set on April 23rd in commit https://github.com/slimphp/Slim-Skeleton/commit/83c9c9a0cba2c7356e326410f3a9ea86851098a6#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780
So, since it was set to slim/psr7:dev-master on April 23rd - there has been tagged releases, the latest being 14 days ago. So it goes to reason, there is nothing in those last 22 commits that was needed when the version was originally set to dev-master. Perhaps dev-master isn't needed anymore and it should be set to the latest version, 0.4.0?
Any insights are appreciated. Thanks!

I will be tagging a new release for Slim-Psr7 soon, once that's done. We will change it to ^0.5 once that's done.

Great, thank you @l0gicgate !


Dataset link not working ？

The dataset link you provided （https://www.dropbox.com/s/r0ef3ij3wl049gl/data.tar?dl=1）
doesn't seem to be able to be downloaded, can you check it for an update, thank you.

The link from README works for me, so maybe the reason is that your machine cannot connect to DropBox for some reason?

The same discussion is continuing here.


⚠ Bofrost.de has degraded performance

In a2e7f68, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 807 ms

Resolved: Bofrost.de performance has improved in 9774e6b.


Create 3- Delete Columns to Make Sorted (Esraa Syam).cpp

Good Job, thanks for your contribution @EsraaSyam.


Bulk-edit selection

It would be a good idea for user to be able to select multiple segments/junction[s] to perform bulk-edit. (In issue #559 I have described whats the difference between quick edit and bulk edit)
issue #557 talks about how to select road using the 'Adjust road selection tool'. However I think there should be other ways of bulk editing as well using [ALT/CTRL/SHIFT]+Click. for example in the junction restriction tool the user should be able to select a junction or multiple junctions to be able 'ban all pedestrian crossing (also see #40)'/'cars can enter blocked junctions'/... on all of the selection.
See also  this comment

For modifier keys (shift/ctrl/etc) we ideally want some consistency so it works the same across all tools.
Tagging: #177
Also, I think there's some (possibly outdated) ponderance on modifier keys linked via #38. I also compiled a list of shortcuts on the steam workshop page (probably also outdated).
Remember that in addition to modifier keys, we can also do things like drag select or drag apply (you can click and drag to apply speed limits for example).
So I think we should first clarify a set of consistent mechanisms (modifiers, drag, selections, etc)? #84 had some thoughts in to that kind of stuff, but only specific to speeds tool.

I suggest we have a page in Wiki for GUI guidelines and filter every new feature through that.
Example:  Either shift of ctrl would add to selection in selection modes
Colors:
White - available to click
Light blue - active
Black - xxxxx
Red - xxxxx
Circle highlights a node
Thick bezier sausage - highlights a segment
Half-sausage highlights a half-segment
Thin sausage highlights a lane
Thin bezier highlights a direction

Just been thinking about this - now that we have the mass edit thing merged, that gives us this new interaction point: User can select roads while toolbar is visible but no tool selected.
What if, in that context, they could Ctrl+Click additional segments or Shift+Click to select all segments between clicked and original selection?

Further to comment above:

If only one segment selected, then the normal "road route" (primarily based on road name) gets the 'green bar'
If multiple segments selected (Ctrl+Click segments to add to current selection) then only those segments get the 'green bar'
If Shift pressed, auto-route follow (like other tools) gets the 'green bar'


feat: decode custom errors

Motivation
Closes https://github.com/foundry-rs/foundry/issues/3399
Brute forces custom error decoding.
  error MyError(address);

will be decoded and printed to console as:
 Error: reverted with 'Custom Error 73ea2a7f:(0x0000000000000000000000000000000000000001)'

Solution

Can we instead log the name instead of "Custom Error"? Isn't that info accessible from the ABI?

we already check against the abi object, but only we have one, which is not the case in anvil for example.
instead the logs will look like
eth_sendRawTransaction

    Transaction: 0x0e2e9603e80d290b3896dab17fe2527c7222f9eb8ee49a44492fae6bd07ae89c
    Gas used: 21448
    Error: reverted with 'Custom Error 73ea2a7f:(0x0000000000000000000000000000000000000001)'

    Block Number: 3
    Block Hash: 0x5e7ddf9ac9f01609077ac31e2e8ebf5b5b85f9f727f62549d74664a5c1c24d58
    Block Time: "Wed, 28 Sep 2022 20:14:28 +0000"


[TestExplorer] newly added test item not showing gutter icon

Issue Type: Bug
After adding a new test, the item shows up correctly in the TestExplorer view, but no gutter icon is shown, even though the item does have the correct location (range).

This might help narrow down the issue: the test item was first created without range but updated afterward. Maybe the update failed to notify the gutter update for some reason?
VS Code version: Code 1.63.0 (7db1a2b88f7557e0a43fec75b6ba7e50b3e9f77e, 2021-12-07T05:15:48.091Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (12 x 3200)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
32.00GB (5.71GB free)

Process Argv
--crash-reporter-id 438d80c7-05fc-418f-b140-e69581260943

Screen Reader
no

VM
0%

Extensions (37)

Extension
Author (truncated)
Version

better-comments
aar
2.1.0

vscode-color-pick
ada
0.6.2

spellright
ban
3.0.60

emojisense
bie
0.9.0

vscode-eslint
dba
2.2.2

xml
Dot
2.5.1

gitlens
eam
11.7.0

prettier-vscode
esb
9.0.0

vscode-commands
fab
1.4.3

flow-for-vscode
flo
1.9.2

shell-format
fox
7.2.2

vscode-pull-request-github
Git
0.34.0

go
gol
0.29.0

vscode-insertdatestring
jsy
2.3.0

vscode-colorize
kam
0.11.1

git-graph
mhu
1.30.0

vscode-docker
ms-
1.18.0

python
ms-
2021.12.1559732655

vscode-pylance
ms-
2021.12.1

jupyter
ms-
2021.11.1001550889

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.4

debugger-for-chrome
msj
4.13.0

vscode-react-native
msj
1.8.1

vscode-jest
Ort
4.2.1

material-icon-theme
PKi
4.11.0

java
red
1.1.0

markdown-preview-enhanced
shd
0.6.1

pdf
tom
1.1.0

vscodeintellicode
Vis
1.2.14

vscode-java-debug
vsc
0.37.0

vscode-java-dependency
vsc
0.18.8

vscode-java-pack
vsc
0.19.0

vscode-java-test
vsc
0.33.0

vscode-maven
vsc
0.34.1

vim
vsc
1.21.10

markdown-all-in-one
yzh
3.4.0

(1 theme extensions excluded)

I'm having trouble reproducing this either in vscode-jest or the test provider, but I think I might know what's going on here. I'll put a fix in, please let me know if it solves the issue for you.

/verified
yup, this is fixed, @connor4312 thanks!


Problem with motor_test

When lancing motor_test it always goes to the usage function, no matter if the arguments are correct.

This need more investigation.
It seemed to be related with getopt.
@davids5 could it be connected with the nuttx upgrade?

Fixed.


Slack markdown message simple formatting bold, italic and etc

[x] Read slack documentation about message formatting
[x] Find library for markdown formatting (write own)
[x] Implement message formatting using helpers on client and server side
[ ] Add scenarios to check message formatting

Time spent:  4h 35m 29.07.2019
Time spent:  4h 40m 30.07.2019
Time spent:  4h 31.07.2019

Added message formatting for bold, strike, code and preformatted without styles
Need to add formatter also for quotes.

Need to add scenarios for checking formatting. And adjusting the formatting so that it is as close to the Slack formatting as possible

Need to correct some formatting problems (precisely to Slack formatting) for a preformatted block. After that, I will write scripts.

Need to clear logic of parsing and use only ends and starts methods for detecting start and end of block

Many formatting issues have been fixed with additional research on Slack formatting behavior.
But need to fix in the future the following moments:

nested formatting inside strike, bold, italic sections

In the context of this ticket need to add scenarios for checking formatting with current functionality

Need to add scenarios for checking the following formatters:

italic
code
preformatted
quote
But I think that this tests I will write in the separate tickets


"array variable name"

Challenge Name

Issue Description
Why am i getting different output if i use different variable   ##names.
Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

var oreo = ['Nilesh', 'Ne', 'Na', 'da', 'ma'];
for(var i = 0; i<oreo.length ; i++)
{
    console.log(oreo[i]);
}

var name = ['Nilesh', 'Ne', 'Na', 'da', 'ma'];
for(var i = 0; i<name.length ; i++)
{
    console.log(name[i]);
}

Screenshot

What's happening here is that name is a little special in the global scope, because window.name will always convert whatever you set it to into a string.
For example, if you do
oreo = 5;
console.log(typeof oreo);

Then you'll get number. But if you do
name = 5;
console.log(name);

You'll get a string.
In your case, ['Nilesh', 'Ne', 'Na', 'da', 'ma'] gets converted to a string, Nilesh,Ne,Na,da,ma, and as you take each index of that string, you'll be logging each character.
Basically, it's because name is special.
If you really really really want to use the variable name name, then you'll need to hop out of the global scope through a closure. Be sure to use the var keyword (or let, or const). Check this out!
(function() {
    var name = 5; // this no longer means "window.name = 5;"
    console.log(typeof name); // number
})()

Having said all that, questions about general JavaScript coding would be more appropriate in the Gitter Chatroom or the FreeCodeCamp forums, and I encourage you to ask any future questions there. Hope you have fun doing some more coding, and good luck!

@NAAG1999 this issue tracker is for reporting issues in the freecodecamp.org platform only. Please reach out to forums and chat rooms in future.
@joker314 thanks for your comment.

am not getting that, how is 'name' special?? is it special for my IDE or the JavaScript??


pull request for e2e test at 11/25/2016 07:56:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


EVP_PKEY_{en,de}capsulate.pod: fix glitches and add some detail and hints

SSIA
Checklist

[x] documentation is added or updated
[ ] tests are added or updated

Ouch, many (clearly unrelated) CI failures.
Hope this will get resolved QUIC-kly.

Thanks @paulidale and @t8m for your swift approvals.
Pauli, could you please re-confirm after the nit fix.

This pull request is ready to merge

Merged to master, 3.0, and 3.1.
Thanks @t8m and @paulidale for your quick approvals.


⚠ ClamAV has degraded performance

In 9ce8ae3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 196 ms

Resolved: ClamAV performance has improved in 91898d2.


Hamiltonian Cycle Algorithm in java

Please assign me this issue @smv1999

Can I work on this issue using C++

/assign

@harshita9621, please create a new issue for the same.


[stable/ark] Add prefix and podannotation

What this PR does / why we need it:

Enable bucket prefix configuration
Add podannotations to restic pod so that kube2iam will works

Special notes for your reviewer:
I'm aware of PR #11068 which also enable bucket prefix. But since the scope of that PR quite large (and introduce breaking changes), I assume it might take a while.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @sameersbn

/ok-to-test

/test pull-charts-e2e

@cpanato Any idea how to resolve the CRD error? I saw @agolomoodysaada already put "helm.sh/hook-delete-policy": "before-hook-creation" label to all CRD resources.

I think my PR was also receiving CRD errors try /retest

/retest

/assign @unguiculus

/assign @paulczar

@faizshukri please update your branch

/retest

@cpanato It's updated, and the test passed now. Thanks :)

/retest

@cpanato The prefix has been added in this PR. But the indentation is a bit off.
I've updated this PR to fix that. And also applying podannotation and resource to the restic pod. Currently its only applied to ark.

/retest

@faizshukri Please resolve the conflict!

@PabloCastellano Resolved, yet e2e test always fails on me.

Yes, this is a known issue. Check https://github.com/helm/charts/pull/11068#issuecomment-465404606

@cpanato Can I get approval on this, since the e2e failure was caused by another issue?
Thanks

The prefix stuff was already merged in #12832, but looking at it again, values.yaml was not updated there. Also, what's still missing is an entry in the config table in the readme. Cloud you please add that?

@unguiculus If you meant configuration.backupStorageLocation.prefix, it's already in the readme.

Right, I had overlooked it.

/lgtm


Can't predict bounding boxes with my own trained model, even though Tensorflow returns reduced loss during training.

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information
Have I written custom code (as opposed to using a stock example script
provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 Home
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue
happens on a mobile device: No
TensorFlow installed from (source or binary): Source
TensorFlow version (use command below): 1.14.0
Python version: 3.6.7
Bazel version (if compiling from source): Not using Bazel
GCC/Compiler version (if compiling from source): Not using GCC
CUDA/cuDNN version: CUDA/cuDNN: 10.0
GPU model and memory: NVIDIA GeForce GTX 1080, 6G
Exact command to reproduce:
vis_util.visualize_boxes_and_labels_on_image_array(
image,
np.squeeze(boxes),
np.squeeze(classes).astype(np.int32),
np.squeeze(scores),
category_index,
use_normalized_coordinates=True,
line_thickness=8,
min_score_thresh=0.20)
Describe the current behavior
When trying to predict bounding boxes with my own trained model with the Object Detection API, it won't predict any boxes and returns the original image. The problem is not with my prediction code, as I used the same as in the tutorial at
https://tensorflow-object-detection-api-tutorial.readthedocs.io/en/latest/training.html
and with a different model, which returns the predicted bounding boxes.
Describe the expected behavior
I don't know why this is happening, as the Tensorboard report says that my loss is reducing as I train the model, but when actually using it to predict bounding boxes in the image, it won't work.
Standalone code to reproduce the issue
The model:
https://drive.google.com/drive/folders/1SMwSHRR8RLX3RMhYXT_aI9gMAIRLHHlp?usp=sharing
The prediction code:
import os
import cv2
import numpy as np
import tensorflow as tf
import sys

from utils import label_map_util
from utils import visualization_utils as vis_util

MODEL_NAME = 'league_model'
IMAGE_NAME = 'test1.jpg'

# Grab path to current working directory
CWD_PATH = os.getcwd()

# Path to frozen detection graph .pb file, which contains the model that is used
# for object detection.
PATH_TO_CKPT = os.path.join(CWD_PATH,MODEL_NAME,'frozen_inference_graph.pb')

# Path to label map file
PATH_TO_LABELS = os.path.join(CWD_PATH,'annotations','label_map.pbtxt')

# Path to image
PATH_TO_IMAGE = os.path.join(CWD_PATH,IMAGE_NAME)

# Number of classes the object detector can identify
NUM_CLASSES = 2

# Load the label map.
# Label maps map indices to category names, so that when our convolution
# network predicts `5`, we know that this corresponds to `king`.
# Here we use internal utility functions, but anything that returns a
# dictionary mapping integers to appropriate string labels would be fine
label_map = label_map_util.load_labelmap(PATH_TO_LABELS)
categories = label_map_util.convert_label_map_to_categories(label_map, max_num_classes=NUM_CLASSES, use_display_name=True)
category_index = label_map_util.create_category_index(categories)

# Load the Tensorflow model into memory.
detection_graph = tf.Graph()
with detection_graph.as_default():
    od_graph_def = tf.compat.v1.GraphDef()
    with tf.io.gfile.GFile(PATH_TO_CKPT, 'rb') as fid:
        serialized_graph = fid.read()
        od_graph_def.ParseFromString(serialized_graph)
        tf.import_graph_def(od_graph_def, name='')

    sess = tf.Session(graph=detection_graph)

# Define input and output tensors (i.e. data) for the object detection classifier

# Input tensor is the image
image_tensor = detection_graph.get_tensor_by_name('image_tensor:0')

# Output tensors are the detection boxes, scores, and classes
# Each box represents a part of the image where a particular object was detected
detection_boxes = detection_graph.get_tensor_by_name('detection_boxes:0')

# Each score represents level of confidence for each of the objects.
# The score is shown on the result image, together with the class label.
detection_scores = detection_graph.get_tensor_by_name('detection_scores:0')
detection_classes = detection_graph.get_tensor_by_name('detection_classes:0')

# Number of objects detected
num_detections = detection_graph.get_tensor_by_name('num_detections:0')

# Load image using OpenCV and
# expand image dimensions to have shape: [1, None, None, 3]
# i.e. a single-column array, where each item in the column has the pixel RGB value
image = cv2.imread(PATH_TO_IMAGE)
image_rgb = cv2.cvtColor(image, cv2.COLOR_BGR2RGB)
image_expanded = np.expand_dims(image_rgb, axis=0)

# Perform the actual detection by running the model with the image as input
(boxes, scores, classes, num) = sess.run(
    [detection_boxes, detection_scores, detection_classes, num_detections],
    feed_dict={image_tensor: image_expanded})

# Draw the results of the detection (aka 'visulaize the results')

vis_util.visualize_boxes_and_labels_on_image_array(
    image,
    np.squeeze(boxes),
    np.squeeze(classes).astype(np.int32),
    np.squeeze(scores),
    category_index,
    use_normalized_coordinates=True,
    line_thickness=8,
    min_score_thresh=0.20)

# All the results have been drawn on image. Now display the image.
cv2.imshow('Object detector', image)

# Press any key to close the image
cv2.waitKey(0)

# Clean up
cv2.destroyAllWindows()

TensorBoard loss

Empty returned Image

Update:
I got the boxes to appear, by using the Legacy train.py file.
The problem has changed, as using the same image and the same steps as before, the bounding boxes get too big and don't actually match the number of objects in the image, as follows:


Remove unnecessary pages, components and libraries

Description
There are numerous libraries/dependencies present inside website, out of which some are very outdated and some are being added but not currently used. Same is the case with some component files and pages like jobs, workshops, etc. Since, we are now in the verge of expanding the project, we should first cleanout the unnecessary parts from it.
Expected Solution

Go through each dependencies in package.json, components and pages inside website codebase and figure it out what we are not using.
Remove such files both from the Next app and Cypress testing

cc: @anshgoyalevil @derberg

for this before opening the PR I think I should first note down all the unused libraries here

Hey @akshatnema, could I help out and work on this issue with @sambhavgupta0705 ? Here are my findings:

We can check all outdated dependencies using npm-check :

To check the unused dependencies, we can use depcheck :

I want to know if there could be a more efficient way to identify unused components. Otherwise, it will require manual checking.

Closing this as completed


[SPARK-14088][SQL] Some Dataset API touch-up

What changes were proposed in this pull request?

Deprecated unionAll. It is pretty confusing to have both "union" and "unionAll" when the two do the same thing in Spark but are different in SQL.
Rename reduce in KeyValueGroupedDataset to reduceGroups so it is more consistent with rest of the functions in KeyValueGroupedDataset. Also makes it more obvious what "reduce" and "reduceGroups" mean. Previously it was confusing because it could be reducing a Dataset, or just reducing groups.
Added a "name" function, which is more natural to name columns than "as" for non-SQL users.
Remove "subtract" function since it is just an alias for "except".

How was this patch tested?
All changes should be covered by existing tests. Also added couple test cases to cover "name".

cc @davies for Python, and @cloud-fan / @liancheng for the rest.

Test build #53866 has started for PR 11908 at commit 87c4641.

LGTM

Test build #53866 has finished for PR 11908 at commit 87c4641.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53866/
Test FAILed.

LGTM for python part

Test build #53886 has started for PR 11908 at commit a7e98b8.

Test build #53886 has finished for PR 11908 at commit a7e98b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53886/
Test PASSed.


[Bug] SVG image not displayed inside canvas with Firefox

Version
5.1.2
Link to Minimal Reproduction
No response
Steps to Reproduce
Create a chart with data as follow:
    {
      "value": 28,
      "originalValue": 528,
      "label": {
        "show": true,
        "width": 25,
        "height": 25,
        "color": "transparent",
        "backgroundColor": {
          "image": "data:image/svg+xml;utf8,<svg xmlns=\"http://www.w3.org/2000/svg\" id=\"mobile\" viewBox=\"0 0 24 24\" fill=\"white\"><path fill=\"rgba(180,248,196,0)\" d=\"M127 256h24v24h-24z\" transform=\"translate(-127 -256)\"/><path data-name=\"phone_pro\" d=\"M142.5 257h-8a2.5 2.5 0 00-2.5 2.5v17a2.5 2.5 0 002.5 2.5h8a2.5 2.5 0 002.5-2.5v-17a2.5 2.5 0 00-2.5-2.5zm-4 21a1.5 1.5 0 111.5-1.5 1.5 1.5 0 01-1.5 1.5zm4.5-4h-9v-14h9z\" transform=\"translate(-127 -256)\"/></svg>"
        }
      }
    }

The SVG inside backgroundColor -> image is not displayed on firefox whereas it works well on chrome.
If we configur SVG mode instead of canvas mode it also works.
Current Behavior
SVG is missing in firefox
Expected Behavior
SVG should be visible
Environment
- OS: ALL
- Browser: Firefox
- Framework: angular

Any additional comments?
No response

Experiencing similar issues with adding a graphic to a multiseries chart:
    graphic: [           {             type: 'image',             id: 'logo',             right: 'center',             top: 'center',             z: 1,             style: {               image: '/logo-wide.svg',               width: 128,               height: 64,               opacity: 0.4,             },           },         ]
This will work fine on Chrome and Safari, but not show up in firefox


deleted comment

HI Chris, just testing out this process, can you please merge to master.

Thanks Shaun! You bet.


Add information about how the build works

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

README.md, line 110 at r1 (raw file):

### Testing

You can write two types of tests: unit and integration tests.  The unit tests will use the maven-surefire-plugin to run any tests found in packages that include "unit" in their name. The integration tests will start a Liberty server before using the maven-failsafe-plugin to run any tests with in pacakges that include "it" in their names before then stopping the Liberty server. As integration tests are longer running then can be skipped by providing the skipTests flag: `mvn install -DskipTests`.

Spelling mistake of packages, and doesn't quite make sense. Also then->they

Comments from Reviewable

README.md, line 110 at r1 (raw file):
Previously, katheris (Katherine Stanley) wrote…
Spelling mistake of packages, and doesn't quite make sense. Also then->they

I've fixed the typos. I wasn't sure which part didn't make sense so I made it a list in an effort to make it clearer

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

README.md, line 113 at r2 (raw file):

1. Start a Liberty server
2. Use the maven-failsafe-plugin to run any tests with in packages that include "it" in their names
3. Stop the Liberty server

Number 2 should say:
2. Use the maven-failsafe-plugin to run any tests that have packages that include "it" in their names

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

README.md, line 113 at r2 (raw file):
Previously, katheris (Katherine Stanley) wrote…
Number 2 should say:
2. Use the maven-failsafe-plugin to run any tests that have packages that include "it" in their names

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Should Infra Manager Resources Be Removed

Currently, Infra Manager resources are being maintained but not used for any purpose, adding another layer of state. Should this type be removed and have Infra Manage continue working with objects from the controller-runtime cache?

sure sgtm, less code to maintain


Getaddrinfo failed upon logging in

I am connected directly to a FortiGate 100E to test my code and upon logging in, I received a "getaddrinfo" failed error:

Traceback (most recent call last):
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connection.py", line 160, in _new_conn
(self._dns_host, self.port), self.timeout, **extra_kw)
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\util\connection.py", line 57, in create_connection
for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\socket.py", line 748, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 11001] getaddrinfo failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connectionpool.py", line 603, in urlopen
chunked=chunked)
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connectionpool.py", line 344, in _make_request
self._validate_conn(conn)
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connectionpool.py", line 843, in _validate_conn
conn.connect()
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connection.py", line 316, in connect
conn = self._new_conn()
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connection.py", line 169, in _new_conn
self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.VerifiedHTTPSConnection object at 0x00000271E236AC50>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\adapters.py", line 449, in send
timeout=timeout
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connectionpool.py", line 641, in urlopen
_stacktrace=sys.exc_info()[2])
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\util\retry.py", line 399, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='https', port=443): Max retries exceeded with url: //<IP_ADDRESS>/logincheck (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x00000271E236AC50>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\ktrang\Downloads\fortiosapi-master\fortiosapi-master_init_.py", line 1, in
from fortiosapi.fortiosapi import FortiOSAPI
File "C:\Users\ktrang\Downloads\fortiosapi-master\fortiosapi-master\fortiosapi_init_.py", line 4, in
print(server.login(host = "https://<IP_ADDRESS>", username = "admin", password = "admin"))
File "C:\Users\ktrang\Downloads\fortiosapi-master\fortiosapi-master\fortiosapi\fortiosapi.py", line 183, in login
data='username=' + urllib.parse.quote(username) + '&secretkey=' + urllib.parse.quote(password) + "&ajax=1", timeout=self.timeout)
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\sessions.py", line 581, in post
return self.request('POST', url, data=data, json=json, **kwargs)
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "C:\Users\ktrang\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\adapters.py", line 516, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='https', port=443): Max retries exceeded with url: //<IP_ADDRESS>/logincheck (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x00000271E236AC50>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed'))

This seems to show that your Fortigate is not reachable.
Can you https to it ? Is it properly licensed ? (if not use http)


Add Northern Oklahoma College domain

This pull request adds the domain noc.edu for Northern Oklahoma College.

Official Website
IT-related Course
Proof of Domain

Please let me know if any additional information is required.

@amiakshylo lib/domains/edu/noc.txt.: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@amiakshylo I am sorry, the domain noc.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

Thank you, got it through GitHub. I appreciate your support for students.


Save plots to files

split the plot generator into two methods. One to render the plot as before, the other to save the plot as an image file

This is a great idea! Thank you so much for contributing this.
I will include this feature in the next release of SounderPy, which should come pretty quick.

So I have this functionality up and running now, with just a slightly different version of what you provided.
The way I have it still uses spy.metpy_sounding() but uses the kwarg method to determine how the user wants to handle the function. method can be set to either 'show' or 'save'. An additional optional kwarg is filename allows the user to set a custom filename.
With this functionality created and ready to be added to v1.1.0 of SounderPy, I will now close this pull request.