[RFC] Remove type from the language

Inside a lib declaration you can use type similar to an alias but making its own type:
lib LibSomething
  type Foo = Void*

  fun some_function : Foo
end

The idea behind this is using type when the C library exposes an opaque type whose structure is not known, hidden behind a pointer, but where you still want to consider it a different type, not always equal to Void*.
The problem with the existing type is that:

It's another concept someone has to learn
It's similar to alias, but different
You can use type with types other than Void* but it doesn't work quite well. For example you can do type Foo = Int32 but methods on it don't work, which doesn't make a lot of sense

But the most important point is that type can be easily done right now: using a struct.
lib LibSomething
  # This is similar to `type Foo = Void*`
  struct Foo
    data : Void*
  end

  fun some_function : Foo
end

I know, it's a bit more typing, but it's just for C libraries.
Alternatively, we can keep type but remove its "value" part. That is, you write type Foo and that's it, and it's assumed that it's a Void* internally. Or we could allow macros to be invoked inside lib declarations and introduce a macro for defining a wrapper struct, so you can write wrapper_struct Foo, Pointer(Void) or similar.

Another option: keep type, but give an error if the underlying type is not Void*. Then we can document it as just being a short syntax for a struct with a single member.
Yet another option: keep type, but document it and make it work like a wrapper struct. Right now type has a few special rules in the language which I can't even remember, but making it work like a wrapper struct is probably better.

Adding a macro newtype similar to Haskell could work. IIRC newtype can have only one type argument, they are type-safe way to give a new meaning to an existing type.
newtype Temperature = Float32

newtype Length = Float32 do
  def +(other : Length)
    # ...
  end
end

We could standardize the conversion in both directions inside the macro and it would be able to work inside and outside lib.

Yet another option, probably my favorite: you can use type, but you get a compilation error saying to use a wrapper struct (with example code). If you run crystal tool format it changes type to those wrapper structs so the fix is really simple.
Eventually for Crystal 1.1 or 2.0 we can remove it.
That way we remove it, but we still provide a really easy upgrade path.

Oh, yeah, newtype could be another option.
That said, it seems in Haskell you have data and newtype, and the only difference is performance and something related to bottom. In Crystal you can already do newtype: it's record with just one field. So that could be another option (I wouldn't introduce newtype if there's no difference with record with just one field).

I don't think those problems are much of a deal.
Yes, it's another concept but you only have to learn it if you write C bindings. That's most likely a minority of developers. Most probably don't care about lib and what goes on inside. If you do care, you need to learn some new concepts. The semantics of type aren't hard to learn if your familiar with C types.
Sure, it could be improved and some of the ideas here sound good. But unless there was something really broken, I wouldn't make it a priority. It works and keeping it the way it is has not much cost.

The thing is, using type with a Proc type works, and if you call new on it you get a Proc type which is counter intuitive (you don't get the type type). I wanted to make Proc.new be defined in the standard library instead of the compiler, but the above breaks. I guess it's fine? It's a breaking change, but type is used the wrong way there (it should be an alias instead).

(removing type doesn't make it a breaking change because, well, type is gone)

Please, ... this will break all the bindings in the wild. We don't need that.
type Foo = Void* as a feature is needed. The syntax is non-intrusive. struct is a workaround. If you want to allow only Void\** there, maybe that could work.

Sounds good. I guess I won't be making the changes I had in mind then.

@asterite Seems you've wanted to that a long long time ago: https://github.com/crystal-lang/crystal/issues/4682#issuecomment-328349647
Reading the comments there I better understand that type as a feature is really unnecessary and eventually should be removed.

I think another alternative is to keep type but not make it special anymore: it's just a wrapper struct. I will try that some time later.

type vs alias confused the heck out of me for a long time, particular because I was using crystal-lib to generate bindings and it would generate all of type Foo = Void*, alias bar : LibC::Int, and type Baz = SomeStructDeclaredEarlier.  Of course, the generator is not perfect, so it would occasionally miss some, and in order to fix it I'd be pulling my hair out trying to understand which one was the "right" one I needed to add back in.  Add to that that I was new to crystal and couldn't really understand the difference between alias and type.  For me personally, removing type would have reduced some cognitive load.
If we really needed a dedicated keyword, I think type is too generic and is part of the confusion... newtype is good or perhaps even opaque, opaque_type, new_opaque_type.


Valid Callback error

Really cannot work out why this error is being thrown ;
Warning: call_user_func() expects parameter 1 to be a valid callback, function 'b' not found or invalid function name in /home/entodev/public_html/wp-content/themes/sliced_enterprise/kirki/includes/class-kirki-styles-output-css.php on line 165
Any suggestions would be very helpful

Could you please post the code you're using for your fields here?

@tomcollom I'm closing this ticket due to inactivity.
If you're still having an issue with this then please feel free to reopen this and post an update on your current status.


Fixed bug in tmp102_getTempCelsius() with temperatures below 0 degrees C

If the temperature was below 0 degrees C, tmp102_getTempCelsius() would
return large positive values instead of the expected negative values

Ben
The MMTSC Wonders team foun a bug in the ArdusatSDK in the temperature sensor interface.  They were trying to generate a calibration table of accelerometer biases vs. temperature, and in doing so, they put their SpaceKit outdoors, where it was below 0 degrees C.  Instead of getting negative temperature readings, the saw large positive readings.  Not knowing what to do, they called me, described the problem, and upon inspecting tmp102_getTempCelsius(), I discovered the integer variable receiving the raw data from the TMP102 was declared as unsigned instead of signed.  Once this was changed to a int16_t, the temperature was reported correctly.
Not wanting to setup the enviromental chamber here at work, I simply stuck my SpaceKit in the freezer in the break room, and ran a test before and after the change.
Before the change:
Tick count = 1128
1128,accelerometer,0.951,1.010,9.581
1129,magnetic,0.727,-10.727,-39.694
1129,orientationation,6.018,-5.639,54.082
1132,temperature,251.500
Tick count = 2128
2128,accelerometer,0.912,1.049,9.542
2129,magnetic,11.818,-38.636,-46.224
2129,orientationation,6.276,-5.427,63.663
2132,temperature,251.438
After the change:
Tick count = 128
128,accelerometer,0.932,1.030,9.620
129,magnetic,11.091,-34.182,-45.408
129,orientationation,6.109,-5.500,61.673
132,temperature,-6.188
Tick count = 1128
1128,accelerometer,0.971,1.049,9.620
1129,magnetic,0.545,-13.545,-40.306
1129,orientationation,6.225,-5.729,62.727
1132,temperature,-6.250
I would suspect other teams might be seeing the same problem, so you might want to incorporate this change as quick as possible.
Michael Kirkhart

Merged into master. Good find!


[Question] GWD Bosses drop tables

How did you calculate the coin weight in gwd bosses drop tables. For example for General Graardor it's 28 here. In the wiki I see it's (31.7 + 1.25)/127? What are the steps to get 28 as the weight for coins?

Im not the one who coded that drop table, but its based on the wiki displaying the overall chance of getting those amount of coins from multiple tables. There is a note on the wiki saying it comes from multiple tables. So the 31.7/127 is a sum of the chances of getting coins from the main table, GDT and RDT. Since the GDT and RDT already have their own subtables  with coins, you need to substract those chances from 31.7/127. The coin weight from GDT and RDT are around 3.7/127, 31.7-3.7=28. The 1.25/127 coins chance is included here. Hope that makes sense!

I see. I'm trying to make sense of how this 3.7/127 came to be. I tried calculating and summing up the chance of getting coins from GDT and RDT but I can't get seem to get 3.7/127 as the sum there.
Do you happen to have a detailed series of steps how to calculate that?
Maybe @gc could shed some light on this as well 🙏

You get 3.7/127 by summing up all the ways of getting coins from the GDT and RDT. The roll to get on the GDT is 2/127 and the coin drop in GTD is 63/128, so to start: (2/127) * (63/128). In the GDT, you can also roll the mega-rare table, which also has coins: (2/127) * (1/128) * (113/128). So in total for GDT:   sum = ((2/127) * (63/128)) + ((2/127) * (1/128) * (113/128)) =~ 0.0079. That is 0.0079/1 so multiply by 127 to get aprox 1/127. You use the same logic for the RDT, which will results in 2.7/127, total of 3.7/127. The RDT has 4 total paths to coins drop:

RDT - coins
RDT - GTD - coins
RDT - GTD - mega - coins
RDT - mega - coins

What do you mean by That is 0.0079/1 so multiply by 127 to get aprox 1/127. 0.0079/1 * 127 is 1/127?

(0.0079/1) * (127/127) = (0.0079*127)/(1*127) = 1/127
Since 0.0079 is the chance out of 1, we want to convert it to a chance of of 127, which is done by multiplying by 127/127

I finally get it now 😄. I indeed adds up. I can understand why the weight of coins is 33 in the main table of gwd bosses. Thanks for the explanation!

Cool. I think another contributor wrote this particular code (either alexsuperfly or wyattos)


Unpin all pins for Windows 11 Start Menu not working?

Prerequisites

[X] Verify that this is not a Windows issue;
[X] Refer to the system requirements;
[X] Refer to the How to use;
[X] I do not use a homebrew Windows image;
[X] I did not tweak Windows before that could cause system instability;
[ ] If your issue concerns the Wrapper, please mention @BenchTweakGaming in issue

Steps to reproduce
Hello. I've got a new PC with Windows 11 Pro. Ran it through the setup process, installed the latest updates, drivers, powershell version and used the Wrapper to create a preset to speed up customization.
I ticked the option to unpin all start menu items, but nothing seemed to happen. In fact, pins were added after running the script. The unpin option used to work fine back when the Wrapper was on version 2.6.8. Versions 2.6.9 and the newest 2.6.10 don't seem to affect the start menu pins.
Regrading pins coming back, I even manually unpinned all the items before running the script and suddenly there were new pins in the start menu, as if I had just setup Windows for the first time.
As a side note, I only use the Wrapper as it has the tweaks I use the most and don't need further customization. I have even tested the script on other PCs with freshly installed versions of Windows 11 and have experienced the same result.
Windows Version
Windows 11 Pro
Sophia Script version
Windows 11 6.5.5

Confirm. Thanks for bugreporting. :cat:

Fixed. :)

Oh wow that was fast. I'll be sure to check it out with the next update then. Your script has been incredibly useful! Also, based on your documentation, is it possible to separate specific functions out to run them separately? Say, if I wanted to just run the "unpin all apps" function, I could separate that out and use it?

Of course! I didn't release a new version yet, so just download an updated file manually.
Just read the instructions on the page: https://github.com/farag2/Sophia-Script-for-Windows#how-to-run-the-specific-functions
Everything is possible))


Problem while parsing the package

Unable to install, pop message: "There was problem while parsing the package."
Model: Redmi 8
Android Version: 10
Steps to reproduce the issue:

Attempt to install

Seems to be an issue with the api level, I changed it to api 28 (Android 9), please see
Test changes
Also haven't tested how the arknights UI would change on different resolutions, I'll try to get back to this issue and test in around 2 or 1 week.


index: push: handle checkout errors

Related #456 #457

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (7b0cf1d) 63.78% compared to head (cb1c40d) 63.70%.

Files
Patch %
Lines

src/dvc_data/index/push.py
45.45%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   63.78%   63.70%   -0.08%
==========================================
  Files          61       61
  Lines        4120     4125       +5
  Branches      708      710       +2
==========================================
  Hits         2628     2628
- Misses       1344     1349       +5
  Partials      148      148

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update using interfaces kmeans for patch sklearn

Using choose parameters computeAssignments, computeCentroids and computeAssignments for efficiently calculate an algorithm without overhead.

@agorshk, @Alexander-Makaryev , @oleksandr-pavlyk  Look, please. I made it only for the 0.23 file so that it would be easier to review, before the merge I will add 0.22 and 0.21 for these changes.

Am I right, that appropriate Sklearn tests were passed (it's need manual check due to the old version comes to CI)?

Of course. So far this has been verified in manual mode.

Do we need update interfaces for 0.21 and 0.22 Sklearn version?

Of course. This will be done after the review to make it easier for review.

Does it correct work if we take the newest version of daal and old version d4p (do we need check version for dp4?)

I checked different version DAAL. I need to check with different versions of daal4py. I think it should work.

@agorshk

Am I right, that appropriate Sklearn tests were passed (it's need manual check due to the old version comes to CI)?

Of course. So far this has been verified in manual mode.

Do we need update interfaces for 0.21 and 0.22 Sklearn version?

Of course. This will be done after the review to make it easier for review.

Does it correct work if we take the newest version of daal and old version d4p (do we need check version for dp4?)

I checked different version DAAL. I need to check with different versions of daal4py. I think it should work.

Ok, that's all from my side, I have no other objections


Pytorch Lightning Model Question

Hi!
I have built my model using Pytorch Lighntning, thus it has the functions training_step, validation_step etc. I attempted to follow the tutorial here: https://torch-uncertainty.github.io/auto_tutorials/tutorial_der_cubic.html#gathering-everything-and-training-the-model
But it errors with NotImplementedError: Module [CMPNNModel] is missing the required "forward" function (which I guess may be obvious). So does this mean to utilise this package I will need to change my model from a PyTorch Lightning one to a Torch one? Or have I done something incorrect.
Thank you!

Hi @calvinp0!
Thank you for your feedback!
You need to define the __forward__(self, x: Tensor) -> Tensor method of your Lightning module (as shown in the starter example). A Lightning module is an extension of an nn.Module, and therefore should include a __forward__. If you do so, you will be able to test and train your model with the RegressionRoutine.
However, if you use trainer.fit or trainer.test, it will not use your own loops but those of the  RegressionRoutine, so it may not work depending on your model. In the general supervised case, we would advise wrapping a simple torch.nn.Module in the RegressionRoutine.
:construction: Our implementation for regression is still unstable but we have made progress in the soon-to-come 0.2.1 version that we will merge in the following days. Reach out and raise issues if you have other questions or concerns. :construction:
To read if you want to keep your LightningModule:
You won't have the computation of the metrics that come with the RegressionRoutine - you can directly use the DERLoss from torch_uncertainty.losses and the NormalInverseGammaLayer from torch_uncertainty.layers.distributions. But anyway, you will need the __forward__(self, x: Tensor) -> Tensor method.
In any case, don't hesitate to give us more details here or contact us through Discord
(written with @alafage)

Thank @o-laurent
I in the end decided to create simple torch.nn.Module version of my model. However, I want to clarify, would the package be able to accommodate a customLightningDataModule, for example:
class DataModule(pl.LightningDataModule):
    def __init__(self, data_dir: str, features_generator: List[str], batch_size: int, num_workers: int, persistent_workers: bool = False):
        super().__init__()
        self.data_dir = data_dir
        self.features_generator = features_generator
        self.batch_size = batch_size
        self.num_workers = num_workers
        self.persistent_workers = persistent_workers

    def prepare_data(self):
        """
        This method is called only once and on only one GPU. It's used to perform any data download or preparation steps.
        """
        print("Preparing data...")

    def setup(self, stage: Optional[str] = None):
        """
        Call in SmilesDataset
        Need to consider if splitting via scaffolding or 5 fold etc.

        Multiple GPU
        """
        self.data = SmilesDataset(f'{self.data_dir}/delaney-processed.csv', features_generator=self.features_generator)
        if stage == 'fit' or stage is None:
            self.train_data = self.data.get_split('train')
            self.val_data = self.data.get_split('val')
            self.test_data = self.data.get_split('test')
        if stage == 'test':
            self.test_data = self.data.get_split('test')

    def train_dataloader(self):
        return DataLoader(self.train_data, batch_size=self.batch_size, num_workers=self.num_workers, collate_fn=collate_molgraph_dataset, persistent_workers=self.persistent_workers)

    def val_dataloader(self):
        return DataLoader(self.val_data, batch_size=self.batch_size, num_workers=self.num_workers, collate_fn=collate_molgraph_dataset, persistent_workers=self.persistent_workers)

    def test_dataloader(self):
        return DataLoader(self.test_data, batch_size=self.batch_size, num_workers=self.num_workers, collate_fn=collate_molgraph_dataset, persistent_workers=self.persistent_workers)

I ask, because I have attempted to follow the tutorial here, whilst using my model and dataset but am now receiving when I run the code:
from lightning.pytorch import Trainer
trainer = Trainer(max_epochs=5) #, enable_progress_bar=False)
trainer.fit(model=routine, datamodule=data_module)

and receive this error:
ValueError                                Traceback (most recent call last)
Cell In[27], line 3
      1 from lightning.pytorch import Trainer
      2 trainer = Trainer(max_epochs=5) #, enable_progress_bar=False)
----> 3 trainer.fit(model=routine, datamodule=data_module)

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/trainer.py:543, in Trainer.fit(self, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path)
    541 self.state.status = TrainerStatus.RUNNING
    542 self.training = True
--> 543 call._call_and_handle_interrupt(
    544     self, self._fit_impl, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path
    545 )

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/call.py:44, in _call_and_handle_interrupt(trainer, trainer_fn, *args, **kwargs)
     42     if trainer.strategy.launcher is not None:
     43         return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
---> 44     return trainer_fn(*args, **kwargs)
     46 except _TunerExitException:
     47     _call_teardown_hook(trainer)

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/trainer.py:579, in Trainer._fit_impl(self, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path)
    572 assert self.state.fn is not None
    573 ckpt_path = self._checkpoint_connector._select_ckpt_path(
    574     self.state.fn,
    575     ckpt_path,
    576     model_provided=True,
    577     model_connected=self.lightning_module is not None,
    578 )
--> 579 self._run(model, ckpt_path=ckpt_path)
    581 assert self.state.stopped
    582 self.training = False

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/trainer.py:946, in Trainer._run(self, model, ckpt_path)
    943 self.__setup_profiler()
    945 log.debug(f"{self.__class__.__name__}: preparing data")
--> 946 self._data_connector.prepare_data()
    948 call._call_setup_hook(self)  # allow user to set up LightningModule in accelerator environment
    949 log.debug(f"{self.__class__.__name__}: configuring model")

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/connectors/data_connector.py:89, in _DataConnector.prepare_data(self)
     87 lightning_module = trainer.lightning_module
     88 # handle datamodule prepare data:
---> 89 if datamodule is not None and is_overridden("prepare_data", datamodule):
     90     prepare_data_per_node = datamodule.prepare_data_per_node
     91     with _InfiniteBarrier():

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/utilities/model_helpers.py:42, in is_overridden(method_name, instance, parent)
     40     if parent is None:
     41         _check_mixed_imports(instance)
---> 42         raise ValueError("Expected a parent")
     44 from lightning_utilities.core.overrides import is_overridden as _is_overridden
     46 return _is_overridden(method_name, instance, parent)

ValueError: Expected a parent

Thank @o-laurent
I in the end decided to create simple torch.nn.Module version of my model. However, I want to clarify, would the package be able to accommodate a customLightningDataModule, for example:
class DataModule(pl.LightningDataModule):
    def __init__(self, data_dir: str, features_generator: List[str], batch_size: int, num_workers: int, persistent_workers: bool = False):
        super().__init__()
        self.data_dir = data_dir
        self.features_generator = features_generator
        self.batch_size = batch_size
        self.num_workers = num_workers
        self.persistent_workers = persistent_workers

    def prepare_data(self):
        """
        This method is called only once and on only one GPU. It's used to perform any data download or preparation steps.
        """
        print("Preparing data...")

    def setup(self, stage: Optional[str] = None):
        """
        Call in SmilesDataset
        Need to consider if splitting via scaffolding or 5 fold etc.

        Multiple GPU
        """
        self.data = SmilesDataset(f'{self.data_dir}/delaney-processed.csv', features_generator=self.features_generator)
        if stage == 'fit' or stage is None:
            self.train_data = self.data.get_split('train')
            self.val_data = self.data.get_split('val')
            self.test_data = self.data.get_split('test')
        if stage == 'test':
            self.test_data = self.data.get_split('test')

    def train_dataloader(self):
        return DataLoader(self.train_data, batch_size=self.batch_size, num_workers=self.num_workers, collate_fn=collate_molgraph_dataset, persistent_workers=self.persistent_workers)

    def val_dataloader(self):
        return DataLoader(self.val_data, batch_size=self.batch_size, num_workers=self.num_workers, collate_fn=collate_molgraph_dataset, persistent_workers=self.persistent_workers)

    def test_dataloader(self):
        return DataLoader(self.test_data, batch_size=self.batch_size, num_workers=self.num_workers, collate_fn=collate_molgraph_dataset, persistent_workers=self.persistent_workers)

I ask, because I have attempted to follow the tutorial here, whilst using my model and dataset but am now receiving when I run the code:
from lightning.pytorch import Trainer
trainer = Trainer(max_epochs=5) #, enable_progress_bar=False)
trainer.fit(model=routine, datamodule=data_module)

and receive this error:
ValueError                                Traceback (most recent call last)
Cell In[27], line 3
      1 from lightning.pytorch import Trainer
      2 trainer = Trainer(max_epochs=5) #, enable_progress_bar=False)
----> 3 trainer.fit(model=routine, datamodule=data_module)

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/trainer.py:543, in Trainer.fit(self, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path)
    541 self.state.status = TrainerStatus.RUNNING
    542 self.training = True
--> 543 call._call_and_handle_interrupt(
    544     self, self._fit_impl, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path
    545 )

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/call.py:44, in _call_and_handle_interrupt(trainer, trainer_fn, *args, **kwargs)
     42     if trainer.strategy.launcher is not None:
     43         return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
---> 44     return trainer_fn(*args, **kwargs)
     46 except _TunerExitException:
     47     _call_teardown_hook(trainer)

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/trainer.py:579, in Trainer._fit_impl(self, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path)
    572 assert self.state.fn is not None
    573 ckpt_path = self._checkpoint_connector._select_ckpt_path(
    574     self.state.fn,
    575     ckpt_path,
    576     model_provided=True,
    577     model_connected=self.lightning_module is not None,
    578 )
--> 579 self._run(model, ckpt_path=ckpt_path)
    581 assert self.state.stopped
    582 self.training = False

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/trainer.py:946, in Trainer._run(self, model, ckpt_path)
    943 self.__setup_profiler()
    945 log.debug(f"{self.__class__.__name__}: preparing data")
--> 946 self._data_connector.prepare_data()
    948 call._call_setup_hook(self)  # allow user to set up LightningModule in accelerator environment
    949 log.debug(f"{self.__class__.__name__}: configuring model")

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/trainer/connectors/data_connector.py:89, in _DataConnector.prepare_data(self)
     87 lightning_module = trainer.lightning_module
     88 # handle datamodule prepare data:
---> 89 if datamodule is not None and is_overridden("prepare_data", datamodule):
     90     prepare_data_per_node = datamodule.prepare_data_per_node
     91     with _InfiniteBarrier():

File ~/miniforge3/envs/deepchem_cuda/lib/python3.10/site-packages/lightning/pytorch/utilities/model_helpers.py:42, in is_overridden(method_name, instance, parent)
     40     if parent is None:
     41         _check_mixed_imports(instance)
---> 42         raise ValueError("Expected a parent")
     44 from lightning_utilities.core.overrides import is_overridden as _is_overridden
     46 return _is_overridden(method_name, instance, parent)

ValueError: Expected a parent

Actually, I discovered the issue was calling pytorch lightning differently during import as reported here: https://github.com/Lightning-AI/pytorch-lightning/issues/17485

Hi @calvinp0,
Thanks for the details! We could add a comment to advise users to use lightning.pytorch if you find it relevant. As a side note, you could use our slightly modified version of the Trainer called TUTrainer in the utils folder to have improved metric printing. We also plan to improve this side of the library in the following months.
Please don't hesitate to let us know if we can help you in any way.

Hi @calvinp0,
Thanks for the details! We could add a comment to advise users to use lightning.pytorch if you find it relevant. As a side note, you could use our slightly modified version of the Trainer called TUTrainer in the utils folder to have improved metric printing. We also plan to improve this side of the library in the following months.
Please don't hesitate to let us know if we can help you in any way.

Hi @o-laurent , yes I think that would be great to add that advisement for future users.
I will try to utilise the TUTTrainer, thanks! On that note, and please tell me if I should open up another thread in discussions, is there a tutorial or information on the Monte Carlo Dropout wrapper: https://github.com/ENSTA-U2IS-AI/torch-uncertainty/blob/main/torch_uncertainty/models/wrappers/mc_dropout.py

Hi again @calvinp0,
Thanks, we'll find a place to highlight this when we improve the documentation.
We can create a discussion thread or chat on Discord if you have more specific questions. Otherwise, I've just slightly improved the wrapper, its documentation, and the MC-Dropout tutorial on the dev branch.
NB: Since the modified version of the tutorial is not yet pushed on main, our website's tutorial page remains outdated.


Image has an incorrect aspect ratio

Noticed this in https://reactjs.org/docs/lifting-state-up.html#lessons-learned:

Not sure if this is just a single image or if there's a pattern.

Gone through the docs, I think this image is only having this problem because it has been assigned a fixed height of 322px.


Update the game over message

Update the game over message so people know how to play again!

jngh


HITMAN Blood Money - Multiple Issues

In HITMAN Blood Money is a lot of stuff missing, probably because of Shader Model 3 which is afaik not fully supported by d9vk 0.12.
Here is what is is missing:

Video are rendered black
Missing shadows
Missing volumetric effects
Color grading
Missing image blur

With 0.13:

Everything expect of cut scenes and menus is rendered black

Blur:

Shadows:

Volumetric effects or probably just pales with translucent textures.

Software information
HITMAN Blood Money

Settings: Max

System information

GPU: GeForce GTX 1080
Driver: 430.14
Wine version: Proton 4.2-6
DXVK version: 0.12

Apitrace file(s)

https://drive.google.com/open?id=15q35w2OaKsTtPFEWxWQ9rBhZ3ItuNDM2

Were those effects missing for you when set to Max? When I set Post processing effects LOD to something other than "none" I'm getting black render.

With 0.13 in game movies are working now.

@qdevpl I can confirm that with d9vk 0.13 everything (except of text and cut scenes) renders black. The screenshots above where made with d9vk 0.12

This is fixed in the latest master, can you guys please try it?

To me it work spot on! Performance is way more stable than d3d, it locks at monitor framerate and stays that way.

I also can confirm that it looks absolutely beautiful :+1:
Feel free to close this issue I feel like everything is working as it should :D

With the latest master, it's flickering a lot, even in the first menu.

Is this a new regression @NerosTie? Can you bisect?

Yes, it's a regression. I have the same issue with Skydrift (yes, this game again).
I think it's latest commit, #635 in the pipelines, because it works with #633.


Added Terraform in Depth

Hi,
Stjepan here from Manning. I thought this title might be a good match for your list. Thank you for considering it.
Best,

Thank you.
Best,
On Thu, Feb 1, 2024 at 9:20 PM Anton Babenko @.***>
wrote:

Merged #244 https://github.com/shuaibiyy/awesome-tf/pull/244 into
master.
—
Reply to this email directly, view it on GitHub
https://github.com/shuaibiyy/awesome-tf/pull/244#event-11675389382, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANDIEMNFDCVKYEDZS7KNXULYRP2KLAVCNFSM6AAAAABCTRNEVWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY3TKMZYHEZTQMQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Stjepan Jureković
Manning Publications - Marketing
@.***


Use controllerutil.ContainsFinalizer in delete example

Replacing the custom contains implementation with
the version in controllerutil.

Description of the change:
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[x] Add or update relevant sections of the docs website in website/content/en/docs

@rearl-scwx did you forget to commit the changes? I don't see any changes in this PR.

/hold

@rearl-scwx also can you signoff your commits so the DCO check will be green? You can do that by git commit --signoff when you commit your files or if you already committed them you can do git rebase HEAD~n --signoff where n is the number of commits you already committed.

@jmrodri I have a feeling I've made a mess of this and will need to start again.


Ownership index.php leads to failure to create php site

Creating a PHP site fails as the index.php file is owned by root. When creating a PHP site with —skip-status-checks and afterwards changing the ownership of index.php it all works …

This issue has been resolved in newer EasyEngine releases.. Please update EasyEngine to the latest version using ee cli update command.  In order for a fresh installation instead, consider using the command wget -qO ee rt.cx/ee4 && sudo bash ee to use the automated installation script to install the latest version of EasyEngine.
This issue occurs as during the site creation, EasyEngine tries to check if the created site works, and if it doesn't, considers the created output faulty, and rolls back the changes made to create the site. So if you skip tests, and fix the permission issue with index.php, site works. As mentioned before, consider updating EasyEngine to the latest version using the aforementioned command.


feat(correlation-id) new "tracker" generator

SEE ALSO #1228

:+1: great! code lgtm
What's left;

[ ] update docs
[ ] adding a test

I'm afraid the chances of collision is really high with this generator. ngx.now sure provides milliseconds precision but surely that won't be enough to guarantee a level of uniqueness as high as uuids.

updated doc is done.  https://github.com/Mashape/getkong.org/pull/236

I'm afraid the chances of collision is really high with this generator. ngx.now sure provides milliseconds precision but surely that won't be enough to guarantee a level of uniqueness as high as uuids.

yes, crossed my mind as well. But figured it would be easy to add a counter within the millisecond precision if needs be and it actually causes collisions. But maybe better to prevent it any way and add such a counter right away.

in modern operating system, pid_t is  int type,  and the pid has been increasing(pid%MAX_INT),
at the same time(milliseconds precision), the pid absolutely not repeat.

not sure, but I don't think you should be caching the magic table ngx on module level. Sen t you an update.
Not sure I understand your comment (with pid_t) but the question imo is whether we'll assume there will be no collisions, or we code to make sure there are none.

And dont forget subsequent requests may come to different nodes on different hosts who may have varying clocks which could increase the chances of collision.

Correlation ID = ip-port-pid-connection-connection_requests-timestamp
ip: different hosts
port: different kong node
pid: different process
connection:  serial number
connection_requests: serial number on same connection
timestamp: milliseconds precision
code make sure there are no collisions

Right, the combination of $connection and $connection_requests should avoid any collision indeed. This is still missing a test.

@WALL-E can you rebase on next?  LGTM, except for the typo.
@thibaultCha any more comments, or ready to merge? (after rebase)

Manually applied the patch with minor modifications to next. Thank you for your contribution!

Looking forward to next release :)

I seem to have missed the beautiful moment  :(


how does component abstraction work?

I think a helpful example that would help me understand how component abstraction works is a dynamic list of counters like in the Elm tutorial: https://github.com/evancz/elm-architecture-tutorial#example-3-a-dynamic-list-of-counters

From my point of view the power of cyclejs is to structure with a super easy but very intuitive functional approach your rxjs code.
So to be efficient you should read, of course the cyclejs documentation, but also the rxjs one.
And as cyclejs is very simple, generally if your are confused about some cyclejs stuff you should take a look at rxjs documentation.
Maybe this link will help you : cold vs. hot observables

Ahhh. I get it now. You're creating a Subject, piping it through the TickerComponent and connecting to it on the other side. Weird.


With latest Windows10 Build (10565) some Characters are not displayed correctly.

Might be connected to custom font settings or language settings.

Closing until there is more data or additional reports.


svtyper-classic: only print Reading metrics message once

with n samples and parallelizing across m chunks, this message
was printing n*m times, with this change, it will print only m
times.

bump


Added Shipping page

Related Issue
Feat: Adding Shipping Page #865
Description
Adding Shipping Page
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@arghadipmanna101 please merge this PR, and please assign it appropriate labels - gssoc, level3 (as it is an enhancement and I had to make it from complete scratch, at least level2), and enhancement.


[ja] replace links to /docs/concepts/containers/runtime-class/ with /ja/docs/...

This is a Feature Request

What would you like to be added

replace links to /docs/concepts/containers/runtime-class/ with /ja/docs/concepts/containers/runtime-class/.
Why is this needed
/docs/concepts/containers/runtime-class/ has already been translated into Japanese.
Comments

/language ja
/kind cleanup
/assign
lines to update
content/ja/docs/reference/command-line-tools-reference/feature-gates.md:- `RuntimeClass`: コンテナのランタイム構成を選択するには[RuntimeClass](/docs/concepts/containers/runtime-class/)機能を有効にします。
content/ja/docs/setup/production-environment/windows/user-guide-windows-containers.md:[RuntimeClass]: https://kubernetes.io/docs/concepts/containers/runtime-class/

base branch: dev-1.19-ja.2

/triage accepted

/close


Gradle 8 Issue

Summary
Not able to build flutter app, getting error below
PS C:\Users\pranay\Documents\flutter_projects\first_app\android> .\gradlew build --warning-mode all

> Configure project :rtmp_broadcaster
Build file 'C:\Users\pranay\AppData\Local\Pub\Cache\hosted\pub.dev\rtmp_broadcaster-2.2.6\android\build.gradle': line 8
The RepositoryHandler.jcenter() method has been deprecated. This is scheduled to be removed in Gradle 9.0. JFrog announced JCenter's sunset in February 2021. Use mavenCentral() instead. Consult the upgrading guide for further information: https://docs.gradle.org/8.3/userguide/upgrading_version_6.html#jcenter_deprecation
        at build_c79sxsk4oi5vashz9wbmot3hd$_run_closure1$_closure2.doCall(C:\Users\pranay\AppData\Local\Pub\Cache\hosted\pub.dev\rtmp_broadcaster-2.2.6\android\build.gradle:8)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        at build_c79sxsk4oi5vashz9wbmot3hd$_run_closure1.doCall(C:\Users\pranay\AppData\Local\Pub\Cache\hosted\pub.dev\rtmp_broadcaster-2.2.6\android\build.gradle:6)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
Build file 'C:\Users\pranay\AppData\Local\Pub\Cache\hosted\pub.dev\rtmp_broadcaster-2.2.6\android\build.gradle': line 20
The RepositoryHandler.jcenter() method has been deprecated. This is scheduled to be removed in Gradle 9.0. JFrog announced JCenter's sunset in February 2021. Use mavenCentral() instead. Consult the upgrading guide for further information: https://docs.gradle.org/8.3/userguide/upgrading_version_6.html#jcenter_deprecation
        at build_c79sxsk4oi5vashz9wbmot3hd$_run_closure1$_closure4.doCall(C:\Users\pranay\AppData\Local\Pub\Cache\hosted\pub.dev\rtmp_broadcaster-2.2.6\android\build.gradle:20)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        at build_c79sxsk4oi5vashz9wbmot3hd$_run_closure1.doCall(C:\Users\pranay\AppData\Local\Pub\Cache\hosted\pub.dev\rtmp_broadcaster-2.2.6\android\build.gradle:18)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':rtmp_broadcaster'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 2s
4 actionable tasks: 4 up-to-date

i have made a pr (#27) collecting all fixes needed for gradle 8 support.
would you mind trying it out and reporting any remaining problems?
pubspec.yaml
  rtmp_broadcaster:
    git: https://github.com/OlJohnny/flutter_rtmp_broadcaster.git

i have made a pr (#27) collecting all fixes needed for gradle 8 support. would you mind trying it out and reporting any remaining problems?
pubspec.yaml
rtmp_broadcaster:
git: https://github.com/OlJohnny/flutter_rtmp_broadcaster.git

Thanks @OlJohnny this fixed my problem, please approve this PR @emiliodallatorre


Enhancement - Change URL of Org

ArcRest or ArcRestHelper
Feb 2016 Release
Enhancement
Ability to change the name in the URL of an organization.
This was mentioned by @mattsbaber. Matt, if workflow/understand is incorrect please clarify.
Currently the workflow to change the name/URL of an ArcGIS Online organization is to copy an org to a different org with the desired name. Use case for this is for organizations that are merged/bought up by a larger organization. So rather than using the previous name in the URL, the users would like the ability to change the URL without having to copy and transfer all their services, maps, and apps to a different organization.

@clareprice so you want another org (site A) to take ownership of a service from site B?

@clareprice - have you taken a look at this: https://github.com/Esri/ago-admin-wiki/wiki/Inviting-public-accounts-into-organizations

@achapkowski The workflow would more be able to change the actual org url (highlight below)

Similar to the functionality of this: https://pholleran.github.io/agoAdminTools/

@clareprice this can be done by calling the update() on the Portal class to change the site's
https://github.com/pholleran/agoAdminTools/blob/master/js/portal.js#L81 shows what they are doing.
For the URL updates, you just need to call updateItem and update the service to the new url:
https://github.com/pholleran/agoAdminTools/blob/master/js/portal.js#L208


Cant find your css file in the download

Could you please check and upload it?

The SCSS files compile to CSS. Please refer to the gulp file to see how this is done. You should run the 'prod' or 'dev' gulp tasks.


The training data "commoncrawl.de-en" does't seem right

The text in two red boxes have no relationship.

Yes, this is an example of "noisy training data". All the reported en-de results with T2T Transformer (including Attention Is All You Need) train on this data without any filtering and the NMT results are quite OK. So you can close this issue and don't worry about it.
Of course, a proper filtering of noisy training data may result in even better results. In this case a simple language identification would filter these three English sentences from the German data.
However, there are many more strange sentence pairs in CommonCrawl (and ParaCrawl). There are many parallel-data filtering techniques, e.g. Dual Conditional Cross-Entropy Filtering, which is the winner of the WMT 2018 Shared Task on Parallel Corpus Filtering.

Thank you so much for your answer. I learned a lot.


Could you please provide details instead

Hi there
this doco is definitively not helpful to enable TLS 1.2
This just refers to other doco which then refers also to other and there it is definitively not usefull
Please update this doco to provide exact configuration for enabling TLS 1.2

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db678f94-700f-ad35-9fdc-d165893b5373
Version Independent ID: 2ee761db-4b3b-6fa0-c195-ad85ebbac70d
Content: Prerequisite checks - Configuration Manager
Content Source: sccm/core/servers/deploy/install/list-of-prerequisite-checks.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @benoithamet for the feedback. This article is not intended to provide that information, and currently the linked KB article is the primary source for how to enable TLS. Revising that KB, and incorporating the content into the core docs is on my to do list. So I'm going to close this issue as a duplicate of #548. You can subscribe to that issue to receive notifications when anything changes.


Call RestApi in OnNotificationReceived when app is closed

as I make the call in release mode (Rest), the application closes and I do not visualize the error, the call is an asynchronous method, this happens only when the application is closed

finally the error is not with the asynchronous method, but with the way to open the sqlite, it is solved


Using iframes

[x] Question

Using iframes inside of the draggable elements creates quite a noticeable lag when resizing. Are there any extra steps necessary to make this smoother?

For anyone else who may have had issues with this like I did I found the problem and the solution.
The issue is not that your draggable element is "lagging", but that when resizing and moving your mouse over the iframe your mouse events are now being hijacked by the iframe! This can mean that your resizeable element doesn't receive events to resize or mouseup when you're done dragging.
The easy solution is to add an onResizeStart and onResizeEnd function to your grid that sets a "resizing" state when an element is being resized. Pass this state down to the element itself and when your iframe elements are being resized, render an invisible div on top of your iframe to prevent the events from being hijacked.
Voila! No more lag! Hope this helps :)

Save tons of my time. Really useful!!!


Decode to S16LE

Hi there, I'm trying to decode an MP3 stream to raw S16LE interleaved mono, then pipe via websocket. What would be the appropriate properties to add to the lame.Decoder()?

You can use fluent-ffmpeg if you want.


SWC plugin support

This is an issue as a start for RFC to develop a swc plugin instead of babel plugin

Hi! This has been answered here.

Hi! We've actually added it now: https://typewind.vercel.app/docs/transpilers/swc


Error on remix 1.7.0

Upon installing remix 1.7.0 I started having this issue with remix-typedjson:
Error: You must render this element in a remix route element
[dev:*server]     at invariant (/Users/.../app/node_modules/@remix-run/react/dist/invariant.js:15:11)
[dev:*server]     at useRemixRouteContext (/Users/.../app/node_modules/@remix-run/react/dist/components.js:179:3)
[dev:*server]     at useLoaderData (/Users/.../app/node_modules/@remix-run/react/dist/components.js:964:10)
[dev:*server]     at useTypedLoaderData (/Users/.../app/node_modules/remix-typedjson/dist/remix.js:20:44)
[dev:*server]     at App (/Users/.../app/src/app/root.tsx:58:29)
[dev:*server]     at renderWithHooks (/Users/.../app/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5662:16)
[dev:*server]     at renderIndeterminateComponent (/Users/.../app/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5735:15)
[dev:*server]     at renderElement (/Users/.../app/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5950:7)
[dev:*server]     at renderNodeDestructiveImpl (/Users/.../app/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6108:11)
[dev:*server]     at renderNodeDestructive (/Users/.../app/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6080:14)

Thanks. I'll test it on Remix 1.7.

You're right. It works just fine.
The problem I had was because I needed to run gen-remix again in my repo.
Thanks for your answer.

Ah, so you're using gen-remix. Cool. How do you like it? I like that I can import everything from a single file, plus allow overrides for things like json and useLoaderData.

If you add rmx gen-remix to postinstall in package.json, you won't have to worry about doing it after updgrades.


Add canvas detection

See #302

@denisenepraunig why are the tests failing?

/Users/runner/work/DeviceKit/DeviceKit/Tests/Tests.swift:32:27: error: value of type 'Device' has no member 'isCanvas'
    XCTAssertFalse(device.isCanvas)
                   ~~~~~~ ^~~~~~~~

@JackYoustra isCanvas isn't available on tvOS. If you move your method in the Device class to be included on tvOS (and watchOS possibly), it should fix it.


Fix CVE-2018-1281

References:

https://nvd.nist.gov/vuln/detail/CVE-2018-1281
https://bandit.readthedocs.io/en/latest/plugins/b104_hardcoded_bind_all_interfaces.html

Test results:
>> Issue: [B104:hardcoded_bind_all_interfaces] Possible binding to all interfaces.
   Severity: Medium   Confidence: Medium
   Location: ../local.py:4
   More Info: https://bandit.readthedocs.io/en/latest/plugins/b104_hardcoded_bind_all_interfaces.html
3	# https://docs.djangoproject.com/en/3.1/ref/settings/#allowed-hosts
4	ALLOWED_HOSTS = ["localhost", "<IP_ADDRESS>", "<IP_ADDRESS>"]
5

Description

Checklist:

[x] I've made sure that tests/test_cookiecutter_generation.py is updated accordingly (especially if adding or updating a template option) Not applicable
[x] I've updated the documentation or confirm that my change doesn't require any updates Not applicable

Rationale
Ensure that allowed host doesn't include a non-routable meta-address.

Thanks for the report, I've looking into why this value was added, I would assume there is a good reason for it, but I could only trace it back to https://github.com/pydanny/cookiecutter-django/commit/64f25417436e3adceecacb0761d52077782d0a3a which doesn't give much context.
In the current form, this is breaking our Docker setup, we use this IP address by default when starting the django server:
https://github.com/pydanny/cookiecutter-django/blob/c54c4f5ef7ebe4ee85e96dd9e72df4a49a7242d1/{{cookiecutter.project_slug}}/compose/local/django/start#L10-L12
I'd be curious to understand whether if we also need to update this part:
https://github.com/pydanny/cookiecutter-django/blob/624dd94dd3738d50f91655d350ca9bf22b6af68f/{{cookiecutter.project_slug}}/production.yml#L43-L46
Also, for non-docker setup, the documentation needs to be updated here:
https://github.com/pydanny/cookiecutter-django/blob/8cd3a796dabeba41c850684566b09a7764d784bc/docs/developing-locally.rst#L77-L83
As well as here:
https://github.com/pydanny/cookiecutter-django/blob/4f7204744667184bc2fc48a2e039bf44282a1a27/docs/developing-locally-docker.rst#L277
Finally, to prevent this from happenning again, I think we could run bandit on our CI (this last part can be done separately though).

Thanks for the report, I've looking into why this value was added, I would assume there is a good reason for it, but I could only trace it back to 64f2541 which doesn't give much context.
In the current form, this is breaking our Docker setup, we use this IP address by default when starting the django server:
https://github.com/pydanny/cookiecutter-django/blob/c54c4f5ef7ebe4ee85e96dd9e72df4a49a7242d1/{{cookiecutter.project_slug}}/compose/local/django/start#L10-L12
I'd be curious to understand whether if we also need to update this part:
https://github.com/pydanny/cookiecutter-django/blob/624dd94dd3738d50f91655d350ca9bf22b6af68f/{{cookiecutter.project_slug}}/production.yml#L43-L46
Also, for non-docker setup, the documentation needs to be updated here:
https://github.com/pydanny/cookiecutter-django/blob/8cd3a796dabeba41c850684566b09a7764d784bc/docs/developing-locally.rst#L77-L83
As well as here:
https://github.com/pydanny/cookiecutter-django/blob/4f7204744667184bc2fc48a2e039bf44282a1a27/docs/developing-locally-docker.rst#L277
Finally, to prevent this from happenning again, I think we could run bandit on our CI (this last part can be done separately though).

👍  Done

For setting up bandit. I currently use https://fussyfox.github.io/ but if it needs to be part of tox / github actions that's also an alternative.

I think fussyfox isn't suitable for us as it would run on the templated code, while we need it to run bandit on the result of the template.

I think fussyfox isn't suitable for us as it would run on the templated code, while we need it to run bandit on the result of the template.

Yeah that's true, I'll setup a github action instead.

The Django ticket that could've been the reason for running runserver with that arg of <IP_ADDRESS>:8000: https://code.djangoproject.com/ticket/27537

I tried to generate a fresh project with Docker and it doesn't work at the moment: I can't access the homepage locally. The console shows that we can access it at the IP <IP_ADDRESS> but when opening in the browserm it's not reachable. I also tried localhost, same issue.

Err isn't the point of having <IP_ADDRESS> supposed to be exposing the port 8000 of the Docker network? Because it's in a Docker container, the localhost you type in is not the same as the localhost of the Docker network. So even though you exposed port 8000 from the Docker network, Django is only accepting localhost from within the network.

@browniebroke I'm gonna pull this again and test. In the meantime I added bandit here #2974

@browniebroke I'm gonna pull this again and test. In the meantime I added bandit here #2974


Improve CI performance

TL;DR
This PR eliminates PR's CI time from 1.5 ~ 2.5 hours to less than 30 minutes!
Basic ideas
Prevent Cache Bloating (-25 min)
A fresh build of current TiKV only generates 3GB cache, whose downloading time is only 5 minutes. But latest cache size before I manually cleared bloated to 19GB, whose downloading time was 30 minutes and uploading time was 50 minutes. This is huge.
So by preventing cache bloating, we can save a lot of CI time.
This PR permanently prevents cache bloating by limiting each build to either "load cache", or "save cache", but not both, more specifically:

For non-master branches, like PRs, it always load (a clean) cache from master. It will not upload cache so that uploading time can be eliminated. (for a 3GB cache, uploading time cost another 5 minutes).

For master branches, it never loads cache and always do fresh builds. After successful build, cache will be uploaded and will be used for other PRs. Notice that this ensures that cache is fresh and will not bloat, so it is fast to upload and also fast to download.

No Cache Uploading for non-master (-50 min)
As described previously, uploading cache also costs a lot of time. I have done the following two tests:
test 1: load latest PR's cache (5 min), build PR's change (5 min), upload PR's cache (5 min)
test 2: load master's cache (5 min), build PR's change (5 min)
Test 1 cost more time because latest PR's cache does NOT help eliminate build time compared to master's cache, while uploading will cost extra time.
So for non-master branches, cache uploading is completely removed.
Disable Code Coverage for non-master (-30 min)
Currently we don't respect code coverage in PRs. Also according to a tarpaulin's bug, it cannot just replace unit tests. So code coverage is removed when building PRs. It is preserved for master branch so that we can still learn code coverage.
When the issue is fixed, we can switch back using tarpaulin in PRs and remove tests so that we can have both tests and code coverages in PRs while not doubling the test time.
Statistics
After this PR is merged, PR's building time will be improved to about 30 minutes, consists of:

Install System Dependencies (2 min)
Load master's ~/.cargo & ~/.local cache (0.5 min)
Load master's ./target cache (5 min)
Build (3 ~ 8 min)
Run test (18 min)

Master branch's build time will be about 1.5 hour (+ coverage 40 min, + upload 5 min).

@siddontang @Hoverbear @overvenus PTAL

Now circle CI runs even faster than our Jenkins build 😂😂

Cooooooooooooool 👍

Amazing


No provider for "framework: chai"

I'm running Karma version 1.6.0 and trying to add chai-as-promised to my karma.conf. This also requires me to add chai. I ran:
npm install karma-chai karma-chai-as-promised --save-dev
and setup my karma.conf with the frameworks and plugins below:
const frameworks = [
    'mocha',
    'chai-as-promised',
    'chai',
];
const plugins = [
...,
'karma-chai-as-promised',
];

and load them into config.set(...).
When I run this using ./node_modules/karma/bin/karma start, I get the error:
Error: No provider for "framework:chai"! (Resolving: framework:chai)
I've looked over other similar errors and the fixes have been to add the necessary packages to package.json and run npm i. However, these packages are already there and installed.

I hit this as well, and fixed it by adding 'karma-chai' to the plugins section.

@zachdini
You should add karma-chai to the plugin section, and karma-mocha about integration with mocha not about chai.
If you have a problem with karma-chai you should open issue in karma-chai project
Thanks!


[Flaky-test] BatchSourceExecutorTest.testLifeCycle (#10870)

Fixes #10870
Motivation
event will be dropped at BatchSourceExecutor#triggerDiscover when discoverInProgress is true
https://github.com/apache/pulsar/blob/f0d166f36e1fbd4df1e20ae2ccc7fcae822c17b4/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/batch/BatchSourceExecutor.java#L161-L182
Modifications
await util task submitted in BatchSourceExecutor#triggerDiscover execute completed and discoverInProgress update to false
Verifying this change

[x] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes)

Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[x] no-need-doc

event will be dropped at BatchSourceExecutor#triggerDiscover when discoverInProgress is true

Why does the implementation drop events? I noticed that the solution was introduced in #8498 . @jerrypeng Do you have a better solution for the problem?

@wuxuanqicn please rebase this PR


Rename node-ts to typescript and add GitHub Action

Renames sdk from node-ts to typescript and adds a simple test action with codecoverage. I also had to add a couple commands in package.json to keep things clean.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Hm, interesting that prettier fails only on windows - looks like maybe its caused by https://github.com/prettier/prettier/issues/7825? I don't think its worth changing line endings for our whole project to placate prettier though. I updated to just not run it on windows.

LGTM thanks!


updated screenshots and content for iot-express-4a tutorial

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

changed the title/resolved review

@JitendraSharma01 I see you are not using the Atom plugin to author. I highly recommend -- even insist -- you use it. This will help you preview, validation, and push your tutorials with a single click (sometimes automatically), and keep the QA and production repos in sync. The last commit is not in QA.

@JitendraSharma01 Can you modify the title and description. The title is VERY generic and it is not clear what it refers to. Perhaps even adding the word "Thing" or "IoT" would help. The description should better mention the technology you are refrring to -- this helps explain to someone what the tutorial is about and helps with SEO.

@JitendraSharma01 I see you are not using the Atom plugin to author. I highly recommend -- even insist -- you use it. This will help you preview, validation, and push your tutorials with a single click (sometimes automatically), and keep the QA and production repos in sync. The last commit is not in QA.

@JitendraSharma01 I see you are not using the Atom plugin to author. I highly recommend -- even insist -- you use it. This will help you preview, validation, and push your tutorials with a single click (sometimes automatically), and keep the QA and production repos in sync. The last commit is not in QA.

Hi ,
I am using the sap plugin, also I made the QA repo in sync as it was in my fork before. I had some issue while using the plugin to push, however validation and other things worked fine. It is because of my local git repo configurations hence created through a fork.

i am trying my local config again so would like to close this PR

using sap-plugin again to push to Prod environment so closing this PR to be clear


DOC Update the dependency set-up for building the docuemntation

The version of numpydoc as pinned down through git-submodules is outdated (circa 2015), and it is what conflicts with the latest PyPI release of Sphinx; this out-of-date version of numpydoc imports sphinx.util.compat which has just been removed from Sphinx. This caused the recent build failures in test building the documentation (example). This PR removes git submodules and switches to pip-installing the dependencies for building the documentation.

@keithing Will removing the git submodules and switching to pip install-ing the doc-related dependencies impact the doc building process on the readthedocs site?

Will removing the git submodules and switching to pip install-ing the doc-related dependencies impact the doc building process on the readthedocs site?

We should be okay so long as dev-requirements.txt and docs/source/conf.py are set up correctly.

The builds have passed. I've also tried to build the documentation locally, and everything worked and looked as expected.


spelling error

What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
Put link here, and add [ZEPPELIN-Jira number] in PR title, eg. [ZEPPELIN-533]

How should this be tested?
Outline the steps to test the PR here.
Screenshots (if appropriate)
Questions:

Does the licenses files need update?
Is there breaking changes for older versions?
Does this needs documentation?

spelling error
responce => response
seprated => seperated

Thanks for the contribution! could you modify PR description template with little info and address the comment.

Thank you for the contribution. Having description would help reviewers to understand what you are trying to do. I believe you will do it from next time :)
Plus do you mind close #1547? I think it duplicates this one.
Meanwhile I will merge this in next 24 hours


⚠ Bofrost.lu has degraded performance

In 6704a02, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1268 ms

Resolved: Bofrost.lu performance has improved in c6f1ada after 6 minutes.


Run in Release mode

Is it possible to have the tests run in release mode? When I build for test and have my scheme set to have Run and Test build in Release mode I get the following error when I run bluepill:
[  ERROR ] Packing failed: (null)

I'm on version 2.3.0 and I'm running with --xctestrun-path.

Unfortunately no, we get the list of tests from the symbols in the XCTest executable, which are stripped in Release mode.

Would you be open to alternative ways of generating the list of tests that'd work for release mode?
For example parsing the source code. Or generating a test list from the debug version and saving that as a text file.

The generation of a list of tests is relevant of release mode or debug mode, as far as you have the XCTest executable, we're able to parse it (which AFAICT, only in debug mode). It doesn't make sense to parse source code for a test list using complex regex, a better way is to get the AST out of the source code and get the test names, this itself is a complicated project.


Update regex.rs to not split words on combining marks and diacritics

Over half the world population seems to speak languages that use unicode combining marks like accents and matras in between the words. GPT / tictoken regular expressions seem to break such words in between preventing merges of characters that should actually merge. Edited the regular expression to not split on such combining characters.

Previously the regex tokenizer defaulted to gpt4 identical (hopefully) behavior. Does your proposed change fix cases where we were not compatible with gpt4 and we just didn't have the test cases to prove it?


Performance Issues with All the Mods

You wanted a github issue :P
There is no crash, not sure what logs you would like or even if they would help. Multiple issues in previous All the Mods which were solved by removing Cyberware: Single player game periodically freezing(with no apparent Mem dump at 95%. FPS drops and server TPS drops. There really isn't much to report :( and it could quite well just be the pack, it sure has other issues as well. https://github.com/whatthedrunk/allthemods/issues/103
All the Mods v1.9 added Cyberware. v1.12 removed Cyberware.

Not entirely sure if this is the same issue, but it sounds similar: in my own handrolled modpack, I was having significant client render lag and often freezing, every few seconds, which from the F3 piechart seemed to be primarily due to bloating in the time spent on forgeHudText and blockEntities.
Removing Cyberware (and nothing else) entirely resolved that, but so did removing everything except Cyberware and JEI, so I'm 99% sure that the issue is in how it interacts with one of the other mods.
I've made a gist of my entire mod list, though that's pretty long so I'm trying to see if I can narrow down the issue to a smaller set of mods and once I do I'll update this issue.

Marking as closed for now, will re open if more info emerges showing it's still present.


api: add docs for live_update

This is just api docs to ensure we're on the same page. I've filed ch2047 for friendlier non-api docs.
This won't be merged until after the implementation is in master.

I don't need a full re-review, but but appreciate a quick skim in re: layout and organization

cc @landism i can't request you as a reviewer of your own PR but hiii

LGTM


after_state_change functionality

Is there a method to change the after_state_change callback after the Machine object has been created? And is it possible to have multiple callbacks for after_state_change. For example:
m = Machine(model=some_model, states=[...])
m.add_callback('after_state_change', callback1)
m.add_callback('after_state_change', callback2)

Hello @peendebak,
after_state_change can handle lists like this:
machine = Machine(..., after_state_change=['callback1', 'callback2'])

Additionally, this list can be adapted during runtime as machine property:
machine.after_state_change = 'callback3'

However, this will not have any effect on already created transitions and this is probably what you need right?

@aleneum Thanks for the reply. Your example already helps, but I want the callback to apply to already existing states.
After creating a machine with a state and transitions I want to automatically create a GUI that shows the current state and has options to change the state. If the machine changes state through some other way. I want this to be reflected in the GUI. E.g. after changing the state I want to call gui.update.
I create the gui after creating the machine, so the gui can use machine.states to build the interface.

Okay,
to achieve this we could convert Machine.after/before_state_change into a property
# Machine
@property
def before_state_change(self):
    return self._before_state_change

# this should make sure that _before_state_change is always a list
@before_state_change.setter
def before_state_change(self, value):
  self._before_state_change = listify(value)

skip the concatenation during add_transition and iterate over two lists (Transition.before and Machine.before_state_change) with itertools.chain
# Transition.execute
from itertools import chain
for func in chain(self.before, machine.before_state_change):
    ...

Let's see what others think of this or if there might be other solutions.

It took a while but since 6e9334f the following should work:
from transitions import Machine

class Model:

    def bark(self):
        print("bark")

    def chirp(self):
        print("chirp")

model = Model()
m = Machine(model=model, states=['A', 'B'], initial='A', before_state_change='bark')

model.to_B()  # >>> bark
m.before_state_change = 'chirp'
model.to_A()  # >>> chirp


Allow proto strings to contain invalid UTF-8 data

What was changed
All calls to build or test this code now contains -tags protolegacy
Why?
We discovered last week that the version of gogo/protobuf we use allowed for invalid UTF-8 data in proto strings. This violates the proto3 spec as strings must be valid UTF-8, and the google/protobuf library will correctly fail to serialize and deserialize strings that contain invalid data.
As we can't be sure that an arbitrary temporal installation has well-behaved data we've had to hack around things to support it in google/protobuf.

Asked internally on clarification for protolegacy tag (I had hoped that changing the descriptor was enough), but I am curious whether you think we should apply this for the CLI rewrite too?

Should we just not support non-utf8 by default in our pre-1.0 CLI and document how they can build it if they must have it?

Should we just not support non-utf8 by default in our pre-1.0 CLI and document how they can build it if they must have it?

I'm certainly a fan of that approach. I aimed for compatibility first-and-foremost but will happily change that here

We've discussed this and don't wish to enable invalid UTF-8 data in our new cli. Users who desire that behavior will need to build it with -tags protolegacy themselves


Improvement/QoL: Guide Browser to select the correct username for password saving

Currently the browser selects the initialization code as the username for password saving.
Can we somehow 'guide' the browser to take the actual username? and if not - or if we don't want this because of security reasons - can we surpress the password saving alltogether?

duplicate of https://github.com/zitadel/zitadel/issues/2740


[Bug]: crashing when choosing the game i want to patch

All of the following criteria must be met

[ ] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the game.
[X] Tried reinstalling LemonLoader.
[X] Tried restarting device.

Describe the issue.
this has been a problem ive been experiencing for a while, when i go to pick a game to patch it will crash every time without fail (i have taken a screenshot and put the file down below

Did you attach your log file?

[ ] Yes, I attached my log file to the text box above.
[X] No, I could not find a log file at /storage/emulated/0/Android/data/<package name>/files/melonloader/etc/Latest.log

New Lemon update; try updating the installer


Exit code is always zero with status command

When I run the status command and it fails for some reason it returns 0 error code (which indicates no error). It would be better if it were returning non-zero error code. This happens both in silent mode (-s) and normal mode.
Example:
% swarm-cli status -q
FAILED - Bee API Connection
FAILED - Bee Debug API Connection
FAILED - Bee Version Compatibility
Bee version - N/A
Supported version - 0.6.2-984dca0a
% echo $?
0

This is fixed in #152


Certain text crashes exported Windows 32-bit game

Godot version
v4.1.2.stable.official [399c9dc39]
System information
Godot v4.1.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1080 (NVIDIA; <IP_ADDRESS>42) - Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 Threads)
Issue description
An exported Windows 32-bit game crashes when loading a scene containing certain (common) text. No errors are seen in the console; the game window silently disappears after a few seconds of loading.
Texts that cause the crash include "ft" (but not "tf") and "abcdefg" (but not "abcdef").
Windows 64-bit works fine, both exported and in the editor. Same for Linux 64-bit. Windows 32-bit exports were made from both Linux 64-bit and Windows 64-bit with the same result.
The crash occurs 100% of the time on the two Windows PCs I have access to (both have very similar hardware).
Steps to reproduce

Create a new project.
Create a Control-based scene and set it as the main scene.
Add a Label containing the text "ft" to the scene.
Create an export preset for Windows with Architecture: x86_32.
Export the game ("Export project...").
Run the exported game.
Observe the crash.

Minimal reproduction project
testft.zip

Can you reproduce this issue with a 32-bit Windows editor?

Another FreeType LTO or mingw bug maybe?

Can you reproduce this issue with a 32-bit Windows editor?

Placing Godot_v4.1.2-stable_win32.exe and Godot_v4.1.2-stable_win32_console.exe in the minimal reproduction project directory and double-clicking them gives the same result as when the game was exported: the text "ft" causes a crash and "abc" does not.
However, I can't open the project in the editor, because both the Project Manager and the Editor applications crash the same way on startup regardless of the project.

I am having a similar problem exporting my game to 32bit using the templates offered on the official site.
v4.1.2.stable.official [399c9dc39]
This might be related, I can't run the 32bit godot editor. It instantly crashes when I open it.


Data Loader for Graphs

So the graph_nets did not have any integration with tfrecords, which I needed for my project. So I wrote my own. I modified it to make it a bit more general here. I also added a demo based on demos/shortest_path.ipynb using my data_loader (just to show an example of it working). I'm unfamiliar with the kind of testing you do, but I'm happy to add in tests if need be.

Closing since this was discussed offline and decided that this contribution was general enough to exist on its own repo, Stephen work is being continued here.
Thanks Stephen!


Allow defining mappings per application without impacting global mappings/shortcuts

Let's take Firefox as an application.
I would like to be able to define a mapping for F2 for it similar to:
[firefox]
f2 = right

But without having this mapping impact all key combinations using F2 with modifiers.
Currently, with the above mapping, pressing F2 in Firefox results in ArrowRight being sent. This is as expected.
If on the other hand, I press Alt+F2 while Firefox is focused, Alt+ArrowRight is being sent. I'm looking for Alt+F2 being sent.
Especially when it comes to F-keys, it would be very useful to be able to define per application mappings for them, that won't interfere with global mappings/shortcuts containing the same F-keys.

You can do:
[firefox]
f2 = right
alt.f2 = A-f2
meta.f2 = M-f2
control.f2 = C-f2
shift.f2 = S-f2

It's what I indeed do, as a workaround. It is working fine.
The overhead and annoyances it caused me over the past ~1.5 years moved me to write this issue in the hope that you can implement a new feature to address this shortcoming.
There's nothing that could beat allowing to remap a single keyboard shortcut to a single action per application, with the guarantee that nothing else gets changed.
Would really appreciate if you could implement this feature. Thank you!

It's what I indeed do, as a workaround. It is working fine.

The overhead and annoyances it caused me over the past ~1.5 years moved me to write this issue in the hope that you can implement a new feature to address this shortcoming.

Aside from the minor annoyance of having to remap modifiers for each key, do you have any other issues with the approach?

There's nothing that could beat allowing to remap a single keyboard shortcut to a single action per application, with the guarantee that nothing else gets changed.

Making this the default behaviour would produce the opposite problem for the (far more common) case in which the user expects the remapped key to be compatible with modifiers. In the odd case where you actually want different behaviour when a key is used in combination with a modifiers, it seems reasonable to require the user to explicitly define this.

Aside from the minor annoyance of having to remap modifiers for each key, do you have any other issues with the approach?

It's about keeping track and thinking about this issue every time I change things that could impact global shortcuts.

Making this the default behaviour would produce the opposite problem for the (far more common) case in which the user expects the remapped key to be compatible with modifiers. In the odd case where you actually want different behaviour when a key is used in combination with a modifiers, it seems reasonable to require the user to explicitly define this.

Not asking for changing the default behavior, that would be way too big a change that literally break everything in place nowadays. TO do that would be a mistake imho.
You could add a new construct to allow for this behavior to be specified explicitly, e.g.
f2 = direct(...)
f2 = simple(...)

I think this is a bit too niche to warrant a dedicated feature, but I will consider it for the next major release. I am closing this issue for now since I am trying to slim down the set of active issues.


Port (most of) Twitter's Compose Rules to Lint

Part of #34
Most of these are largely copied with small changes to make it work with lint (i.e. reporting, different APIs for access, some shared option infra, etc).
The only functional modification I made to any of them was to add Collection to the immutable collections check, as compose now supports ImmutableCollection.
Another caveat is that lint doesn't currently allow reuse of shared properties. This means for something like custom content emitters, we would have to redefine it multiple times. We could work around this by sourcing the list from a newline-delimited file that multiple options point at though, but will save that for the future when we actually need it.

Nice work on the port! 🎉


Quoted arguments aren't parsed properly

When entering quoted args like paths, they aren't split properly. The line const origArgs = (query.args as string).split(/\s+/); in server/src/index.ts splits arguments at whitespace, regardless of any quotes. Something like:
import { parse as shellParseArgs } from 'shell-quote';
const origArgs = shellParseArgs(query.args as string) as string[];

should be used instead.
Steps to reproduce the behavior:

Enter any any argument in quotes like a path in the arguments field
Hit connect
The MCP server will be unable to parse the falsely parsed args

Expected behavior
Quoted args should be respected and not split.
Here it is with that mitigation:

@Richard-Weiss thanks for filing! I think your proposed fix makes sense, feel free to open a PR 😄 Otherwise we may be able to get to this sometime next week.

Fixed in #104


topic search does not navigate to topic

When I try to use the topic search, I type in 'election; and then click on the 'us presidential election' item in the list, I can't get it to actually navigate to the topic.  I've tried various combination of pressing enter and clicking on the list item.  The 'us presidential election' label gets put into the search box, but I don't get forwarded to the actual topic.
using chrome on ubntu.

I just tried on chrome and firefox on ubuntu and on chrome on windows and
get the same result.
am I misunderstanding what the interface is supposed to do?  I'm assuming
that the selected topic is actually supposed to load somehow?  The
autocomplete works great.  It's just that nothing happens other than the
autocomplete.
-hal
On Sat, Feb 11, 2017 at 7:56 PM, rahulbot<EMAIL_ADDRESS>wrote:

Unable to reproduce on Chrome on OSX, nor in Chrome on Windows. Can you
right-click, select "inspect", and then click console to see if there are
any useful errors reported?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mitmedialab/MediaCloud-TopicMapper/issues/244#issuecomment-279190295,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvvT7d3TPDu8FlfZMiAAxVQNex18S0Lks5rbmbigaJpZM4L9Tfu
.

--
Hal Roberts
Fellow
Berkman Klein Center for Internet & Society
Harvard University

I just tried clicking on item in the list, and it works fine.


performance fix for podman events with large journalds

in the case where the host has a large journald, iterating the journal
without using a Match is very poor performance.  this might be a
temporary fix while we figure out why the systemd library does not seem to
behave properly.
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

LGTM. Nice performance improvement on my laptop with 1.8G journal

/lgtm

/retest


Latest change to action.yml contains secrets.GITHUB_TOKEN which results in errors

The Latest change that was published has introduced a bug that results in the job erroring and not starting . There is a Github secret in the description for pr-comment-github-token in action.yml and in that description there is "${{secrets.GITHUB_TOKEN}}" so when this is used in an actual workflow its trying to render the value of  ${{secrets.GITHUB_TOKEN}}. I have attached a couple of screenshots showing the error and the update to action.yml

Weird, Let me fix that. I didn't get that issue when I was testing it manually. Thanks for filing this

fixed in #36


[fix](jdbc catalog) fix and add mysql and doris extremum test #41679

cherry pick from #41679

run buildall

run buildall


Support DBT custom --project-dir parameter

As mentioned in https://github.com/rfdearborn/dbt-docs-to-notion/issues/19 the GHA doesn't support cases where the DBT project is defined in a sub-directory.
To support this case, we have to allow the GHA to specify a --project-dir parameter to DBT.


Increase reaper buffer size and non-blocking send

Fixes #2709
This increases the buffer size for process exit subscribers. It also
implements a non-blocking send on the subscriber channel.  It is better
to drop an exit even than it is to block a shim for one slow subscriber.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

what about v2 reaper?

@estesp good catch

Codecov Report

Merging #2748 into master will decrease coverage by 3.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2748      +/-   ##
==========================================
- Coverage   47.41%   43.73%   -3.68%
==========================================
  Files          91      100       +9
  Lines        8411    10730    +2319
==========================================
+ Hits         3988     4693     +705
- Misses       3700     5307    +1607
- Partials      723      730       +7

Flag
Coverage Δ

#linux
47.41% <ø> (ø)
:arrow_up:

#windows
40.89% <ø> (?)

Impacted Files
Coverage Δ

snapshots/native/native.go
43.3% <0%> (-10%)
:arrow_down:

metadata/snapshot.go
45.8% <0%> (-8.96%)
:arrow_down:

archive/tar.go
43.13% <0%> (-6.87%)
:arrow_down:

metadata/containers.go
47.97% <0%> (-6.62%)
:arrow_down:

content/local/writer.go
57.84% <0%> (-6.36%)
:arrow_down:

content/local/store.go
48.51% <0%> (-5.03%)
:arrow_down:

remotes/docker/resolver.go
58.36% <0%> (-4.99%)
:arrow_down:

archive/tar_opts.go
28.57% <0%> (-4.77%)
:arrow_down:

archive/compression/compression.go
58.69% <0%> (-4.7%)
:arrow_down:

metadata/images.go
58.46% <0%> (-4.7%)
:arrow_down:

... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a32a8...232a063. Read the comment docs.


Are files read-only?

I just tried this for the first time. I had to create /persist/etc/machine-id but now /etc/machine-id points to a file in the nix store. Which I expect to be read-only. It's fine for the machine-id but it wouldn't be for network-manager stuff or logs. Which I would prefer to be writable but still persistent between reboots.
  environment.persistence."/persist" = {
    files = [
      "/etc/machine-id"
    ];
  };

I would expect that your /etc/machine-id is a symlink chain that looks something like this:
/etc/machine-id -> /etc/static/machine-id -> /nix/store/hvnykaklbwa55pl8znhq7lsjf76vq6gy--persistent-etc-machine-id -> /persist/etc/machine-id

And since it's symlinks they don't have to be writable in the entire chain, so if you make sure the directory /persist/etc exists and then create the file it should be fully possible to write to /etc/machine-id :)

they don't have to be writable in the entire chain

Uh I didn't know that. Or forgot about it.
Thank you very much.


Add customer label parameter and a new method without prefix.

update: allow to change label every time, you can pass an empty string in the first parameter when you don't want to change label and use client.config.Labels.
add: add a new method Logf to submit a logline without prefix such as ERROR, INFO etc.

I'm not actively maintaining this library at the moment so I would appreciate somebody else's eyes on this PR

you can pass an empty string in the first parameter when you don't want to change label

I don't think this is a good API, nor do I approve the break of the backward compatibility. Please provide new methods that allows to override the label if necessary and keep the existing API as is.

you can pass an empty string in the first parameter when you don't want to change label

I don't think this is a good API, nor do I approve the break of the backward compatibility. Please provide new methods that allow to override the label if necessary and keep the existing API as is.

Agree with that, I am going to change that API and comments above. Thanks for your time.

Just re-committed, please review it, thanks, I'll pull another commit with go-formatted later.

I just tested the new method LogfWithLabel, it works as expected.

Is it possible to merge ?

Unfortunately I'm not actively maintaining this library at the moment. Feel free forking it.


python3Packages.xknx: 0.17.1 -> 0.17.2

Motivation for this change
Update to latest upstream release 0.17.2
Change log: https://github.com/XKNX/xknx/releases/tag/0.17.2
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116262 at 4e701b58 run on x86_64-linux 1

2 packages built successfully:

python38Packages.xknx
python39Packages.xknx


Second Contribution by Ogochukwu Onwujiobi

Name: Ogochukwu Onwujiobi
Projects analyzed: GNU Radio/The Carpentries
project links:   https://github.com/gnuradio/gr-governance/blob/main/aoa.md/
 https://carpentries.org/governance/
ANALYSIS OF THE GOVERNANCE MODELS
GNU Radio's governance model uses online voting for decision-making, but with varying degrees of voting rights for members based on their membership type. Suprisingly, for the GNU Radio, the General assembly seem to wield more authority than the Board as against most contemporary organizations where the Board usually holds the final say. Governance of The Carpentries is done by the Executive Council, to whom the Executive Director reports and The Council comprises nine members, from The Carpentries community or others, four elected by the community, and five appointed from the Executive Council. This goes to show that both organizations are community oriented
Differences

GNU Radio has two major decision making bodies which is the General Assembly and the Board while The Carpentries has just one which is The Executive Council.
GNU Radio decison making system is decentralised,no one person holds a ultimate authority over a decision but The Carpentries  concentrates Authority on the Executive Council.

Similarities

Both organizations use the online platforms as a means of meeting.
Both have by laws which govern operation and behavior.
Both run community based model of governance.
Both organizations are community oriented.

MY OPINION
Though they are both coomunity centred and may have been effective in their different ways, GNU Radio governance model seems like a preferred model because power belongs to the General Assembly and this helps bring about transparency and trusted intergrity.

cc @arliss-NF. please review. thank you.


[tool_crash] FileSystemException: Cannot open file, OS Error: No such file or directory, errno = 2

Command
flutter pub upgrade --dry-run

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot open file, OS Error: No such file or directory, errno = 2
#0      _File.throwIfError (dart:io/file_impl.dart:635:7)
#1      _File.openSync (dart:io/file_impl.dart:479:5)
#2      _File.writeAsBytesSync (dart:io/file_impl.dart:604:31)
#3      _File.writeAsStringSync (dart:io/file_impl.dart:628:5)
#4      ForwardingFile.writeAsStringSync (package:file/src/forwarding/forwarding_file.dart:147:16)
#5      ErrorHandlingFile.writeAsStringSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:271:22)
#6      _runSync (package:flutter_tools/src/base/error_handling_io.dart:597:14)
#7      ErrorHandlingFile.writeAsStringSync (package:flutter_tools/src/base/error_handling_io.dart:270:5)
#8      _DefaultPub.interactively (package:flutter_tools/src/dart/pub.dart:431:21)
<asynchronous suspension>
#9      PackagesInteractiveGetCommand.runCommand (package:flutter_tools/src/commands/packages.dart:347:5)
<asynchronous suspension>
#10     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1209:27)
<asynchronous suspension>
#11     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#12     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#13     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
<asynchronous suspension>
#14     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#15     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
<asynchronous suspension>
#16     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)

[✓] Flutter (Channel stable, 3.3.10, on macOS 12.6.2 21G320 darwin-arm, locale en-KE)
    • Flutter version 3.3.10 on channel stable at /Users/joash/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revi

Closing as duplicate of https://github.com/flutter/flutter/issues/91559


Issues Training on RTX 2080 Ti 11GB

I've upgraded my PC recently and I now have the Nvidia Geoforce RTX 2080 Ti with 11GB's of V-RAM. I'm able to run conversions just fine with all the correct cuda drivers installed, but I'm having a lot of trouble training.  Once the data loads and it starts on the first Epoch, it just stops after a few seconds. No errors, nothing. It just closes. I tried debugging the script in Visual Studio Code to look for errors, but even then nothing, no errors. I verified my configuration and verified that my other PC with a GTX 1060 is able to run the exact same script with no issues.
I verified there was nothing wrong with the GPU as it's able to run high end games with absolutely no issues. Have you experienced this? Is there something I need to look out for?
System specs -
CPU: i9 9900K
RAM: 48 GB
Motherboard: Z390 ASAP Phantom Gaming 6

I have a GTX 1660ti & 32 GB RAM and had problems at first too. Reduced batch size helped me:
python train.py -i dataset/instrumentals -m dataset/mixtures -M 0.5 --gpu 0 -b 2 -B 2

I have not encountered that issue.
My current enviroment and settings:
OS: Windows10
CPU: i7-8700K
RAM: 32GB
GPU: RTX 2080 Ti
VRAM: 11GB

CUDA: 10.1
NVIDIA Driver: 431.68
Python: 3.6.8
PyTorch: 1.5.0+cu101

Batch size: 4
Training samples: 170 pairs

I downloaded and installed the exact same versions as you and I got it working! Thank you so much for the assistance!

Has anyone tried the Google Colab? I would like to use it instead of renting an expensive server, but I still can't figure out how to work with it.


Can it work with the Meta Quest 3?

Describe the feature
The Meta Quest 3 runs on Android, and I’d like to know if it’s possible to run Llama 3 on it with good performance. Also, could microphone compatibility (speech-to-text) be added in future updates? That would be fantastic, I want to create a 3D character that you can interact with in mixed reality using the headset.

I created a very realistic facial animation system for my game and I really want to add Llama 3 to my game :
https://github.com/user-attachments/assets/c46217c3-07f6-4ab2-bd72-e6587d9dc803

Hi, sounds great!
I don't have a Meta Quest so can't tell but if it runs normal Android apps it should work.
You can easily test it by building the AndroidDemo sample (check the "Build a mobile app on Android" section of the readme).
You can try the small and tiny models that can be downloaded from the LLM GameObject.
For speech--to-text you can use whisper.unity.

Ok, I'm going to do some tests. I'll let you know if it works.

Good news, Llama 3 works perfectly on the Quest 3! I managed to get it running. However, I’m having trouble integrating Whisper, it detects the microphone but doesn’t transcribe. I’ll keep looking into it.
https://github.com/user-attachments/assets/c21e0921-e541-43ab-b3d9-454ac845c307

I found out how to write the text vocally, but I can't figure out how to send/submit the message to the AI when I've finished my sentence :/

I found how to do the speech-to-text, and it works perfectly. However, I'm having a bug with the LLMCharacter. When I talk to it, after about 2 minutes, it starts repeating the same phrase over and over as a response. I'm using a tiny model. Do you know why the AI is repeating a phrase in a loop?

Awesome, thanks for sharing!
You can try to increase the Repeat Penalty or Frequency Penalty of the LLMCharacter (advanced options) - or a different model.


Fix JOpt Simple version

Description

The PR switches the version of JOpt Simple from 5.0.3 to 4.6.

Motivation

The JMH support introduces a dependency to version 5.0.3 of JOpt Simple. However JMH library is built against version 4.6 of JOpt Simple. In current state the command line parsing functionality of JMH is partially broken (see test //test/jmh:jmh_command_line_parsing_test).

thanks!
does jmh have a newer version? In general I prefer rolling forward.
Having said that the right thing to do is probably merge this PR and then try to upgrade JMH itself (if relevant) in a separate PR.
Also can you please take care of the CLA?

does jmh have a newer version? In general I prefer rolling forward.

Unfortunately, it seems the last version of JMH (v1.23 from last January) is still depending on JOpt Simple 4.6.
https://github.com/openjdk/jmh/blob/1.23/pom.xml#L269

Also can you please take care of the CLA?

I will take care of that.

@googlebot I signed it!