Have separate menu items for « Export to file… » and « Export to Google Drive… »

Is your feature request related to a problem or area of OpenRefine? Please describe.

Also, using the term « Export to local » is vague, « Export to file » (or even « Export to OpenRefine ZIP » would be better tho the latter is a bit too verbose… ;-)
Describe the solution you'd like
It would be much better if there where 2 items in the menu, named « Export to file… » and « Export to Google Drive… ». It would save clicks for exporting to file, which is the operation most of our user do, and it would be clearer in the interface that OpenRefine can export the whole project to Google Drive.
Describe alternatives you've considered
Doing the same as now. But if we want to add interface elements for Export to gDrive, it will clutter the interface.
Additional context

@wetneb I was thinking of solving this issue :)

It's true that export to Google services are not very well exposed at the moment. We could add menu items for:

Export to Google Sheets
Export to Google Drive

But "Export project to file" is too vague: most of the other export options can also be seen as exporting the project to some file. How about "Export as OpenRefine project" or "Export as OpenRefine archive"?

« Export as OpenRefine archive » is good because its an internal archive
(ZIP).
Le dim. 22 mars 2020 à 06:59, Antonin Delpeuch<EMAIL_ADDRESS>a
écrit :

It's true that export to Google services are not very well exposed at the
moment. We could add menu items for:

Export to Google Sheets
Export to Google Drive

But "Export project to file" is too vague: most of the other export
options can also be seen as exporting the project to some file. How about
"Export as OpenRefine project" or "Export as OpenRefine archive"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/2453#issuecomment-602181039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5GZNLULRQNMVSMDGJ4SITRIXVSLANCNFSM4LRCHKFQ
.

Thinking about it,
« OpenRefine archive to file… »
« OpenRefine archive to Google Drive… »
might be better?
And then, we could also have:
« Google Sheet… »
Just to conform with how it's written elsewhere in the menu. It's the Export menu. Maybe every item could be preceded  by « As » or « To », like « To Excel (.xls) ».
And, to continue the uniformisation, « Export to QuickStatement « would be « To QuickStatement » and « Export Wikidata schema » become « Wikidata schema to file »?
And « Custom tabular exporter… » would be something like « Thru custom tabular exporter… »?
@wetneb what do you think of that?

Another clarification…

@ostephens @thadguidry @wetneb

Definitely not "Thru", that is informal, and they do not add anything.
I would remove all the "To", they are unnecessary too.

?

Definitely not "Thru", that is informal, and they do not add anything.
I would remove all the "To", they are unnecessary too.

@wetneb  what about "..." after each export option? Should we add them or remove them from all options?

Good point, I think "..." should only be added to exporters which require further configuration (in some dialog or prompt). That's the convention, I think.
Also, the "..." should be included in the message itself (so they can be translated too), not concatenated afterwards.

And of course changing messages has a cost (it invalidates them for translators), so we should do it as sparingly as possible.

They should stay as they indicate that a dialog/manual interaction is
coming before the real action.
Regards, A.
Le dim. 22 mars 2020 à 09:21, Agha Saad Fraz<EMAIL_ADDRESS>a
écrit :

Definitely not "Thru", that is informal, and they do not add anything.
I would remove all the "To", they are unnecessary too.
@wetneb https://github.com/wetneb what about "..." after each export
option? Should we add them or remove them from all options?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/2453#issuecomment-602199615,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5GZNOL4BOIK6M2Q6O6BF3RIYGEZANCNFSM4LRCHKFQ
.

They should stay as they indicate that a dialog/manual interaction is
coming before the real action.

In your screenshot, you added them to exporters which do not use any dialogs.

They should stay as they indicate that a dialog/manual interaction is
coming before the real action.

In your screenshot, you added them to exporters which do not use any dialogs.

Hi Antonin,
If you choose a menu, and after that you still have a user interaction, then, I requires an ellipsis.
That why I put an ellipsis to most (if not all) of the items.
Also, spreadsheet file is not redundant: the spreadsheet can be saved to the cloud or elsewhere. But in my proposition, the menu item is precise, it tells you when you will generate files.
Regards, Antoine


TODO: add example kubectl commands to the pepr hello world capability demo.

IE:
kubectl create ns pepr-demo
kubectl create configmap  example-1 -n pepr-demo

you wouldnt create those, you'd kubectl apply -f. We currently have this info in 3 places:

The main readme
The Module Docs
The HelloPepr generated capability in every module.

Should there be something else, I think these 3 places might be sufficient?


Trying to insert an invalid mag into a gun should give a popup if one doesn't already exist

Duplicate of https://github.com/RMC-14/RMC-14/issues/2159


Links sometimes don't wrap enough

Describe the bug
Sometimes very long links appear onto other monitors for me, it should wrap more
To reproduce

Hover over a long link

Screenshots

Chatterino version
Chatterino Nightly 2.2.3-beta2 (commit 529f19a2d, 17.11.2020)
Operating system
Windows 10

The screenshot link is dead. Was this about tooltips from links being too long and wrapping onto your second monitor?

The screenshot link is dead. Was this about tooltips from links being too long and wrapping onto your second monitor?

I believe it was for links like this

Others have had similar issues (https://github.com/freedomofpress/securedrop-client/issues/815). We can't set a max-width on the label due to QTBUG-85498, and we can't use a QTextEdit in read-only mode as we need to shrink the widget to its contents (not that easy with a QTextEdit).
I found that setting the word wrap here to QTextOption::WrapAtWordBoundaryOrAnywhere solves the issue for us. I'll see if that's a decent fix for Qt.


There is no local etcd, removing 'etcdctl set'.

@kelseyhightower thoughts?

@kelseyhightower can you take a look?

@AntonioMeireles can you take a look at this PR and say if it looks safe?

@pires any comment here?

@bussyjd this touches the same area as your #6890.  Want to comment on this PR?

To me it feels like we should have kept the single etcd in the master node, where apiserver runs and not a cluster like @antoniomeireles implemented.
In this case, removing this line (or the entire entry is OK), because
flannel:
    interface: eth1
    etcd_endpoints: http://<master-private-ip>:4001

@erictune If a single master node is the way to go it then makes sense to get rid of this line IMO with @pires 's PR
I am sorry if I bring back an old discussion but running etcd only on the master feels like it might cause some issues in niche cases when the master is not available (flanneld nw conf update for example). It defeats the purpose of etcd's HA.
Now might be the right time to weight the pros and cons if it haven't been done before otherwise It's totally fine to discard https://github.com/GoogleCloudPlatform/kubernetes/issues/6555 and https://github.com/GoogleCloudPlatform/kubernetes/pull/6890 in favor of https://github.com/GoogleCloudPlatform/kubernetes/pull/6281

@bussyjd @antoniomeireles was the one who brought etcd HA to light, since I was in favor of a simpler approach. People here will tell you etcd is just an implementation detail that may change in the future and have that said, I am to believe they don't actually care about etcd best-practices. And I agree with this idea. So, to me, if you're not happy with a single etcd node cluster, perhaps it's time to assemble it outside of Kubernetes?
Anyway, #6281 works for me.

@pires Thank you for the info.

So, to me, if you're not happy with a single etcd node cluster, perhaps it's time to assemble it outside of Kubernetes?

Is that in any world a productive answer?
@erictune  It is now clear that case #6281 is the way to go.

Is that in any world a productive answer?

@bussyjd I'm sorry if it offended you in some way, but it's actually how I use it in production. Once again, etcd is just an implementation detail. How coupled do we want its high-availability to be to Kubernetes?

[sorry lag, mutitasking too much]
several issues/angles at stake (and now we even have etcd2 to grasp as it is already in latest CoreOS alpha).

one approach we could use is the old one were the minions are absolutelly dumb and have no etcd (1, 2, whatever) of any kind, with everything pointing to master. with that approach one will always have to "cheat" one way or another and make sure that in no circunstance the nodes have the chance to want/need etcd before master is up. [this is easy to trigger specially in Vagrant with fast boxes/ssds and without VAGRANT_NO_PARALLEL=true.
another approach that @pires thinks is too much (its is, but handy for testing) is just have a local etcd cluster, spread among master and nodes.
finally, the last approach is while having a single-node etcd-master running on master having on all the minions etcd in proxy/client mode pointing to master. this way and without further cheating even if they start well in advance the minions will wait orderly that etcd (and whatever deps on it) is up and ready in master. [this is what is being done in this master/node and works afaict flawlessly.]  Also, from my understanding this approach is the recomended way by upstream of consuming etcd and should cover all use cases.

@pires et all - any objection for a PR that implements last option (IMHO the way to go), plus full etcd2 awareness, plus fixing kubelet/kube-register interaction in 0.15.x ? (as afaik this 3 issues are the ones currently affecting this ?]

@AntonioMeireles I'm OK with depending on etcd2 (CoreOS 563.0.0) and follow the proxy approach.

@pires can you please when you time hand pick the mods from my tree to yours (now that they are closer again :-) ) for "independent" testing :-) to see if this time we get rid of all corner cases :-). Anyway PR will available for discussion after my lunch :-)

@AntonioMeireles working on the proxy thing right now.

@AntonioMeireles done and can confirm it's working.

@pires - thnks - working on PR.

fellows,
submited GoogleCloudPlatform/kubernetes#6973. the discussion/review should probably jump to there :angel:

closing this as it appears to be obsoleted by #6973


refactor: Refactoring hero grid

I removed the repeated code and left it dynamic in case it is needed in the future.

Thanks, @lucasaugustsof!


Ensure cleanup of corrupted mount points

Ensure that corrupt mount points are cleaned up during NodePublishVolume calls, this currently returns an error afterwards to make sure that kubelet can cleanup on it's side. In the future we might want to consider utilizing the NodeStateVolume calls to actually deal with the block device then only do bind mounts during NodePublishVolume calls.
We should also update the node plugin (lock per volume) to keek track of currently running operations for a single volume. To prevent multiple operations from running concurrently, the correct error to return then is aborted. Since that will signal that a previous operation is in progress.
longhorn/longhorn#2629
supersedes longhorn/longhorn-manager#908

hold merge for @innobead requested review.

@joshimoo Please help backport to 1.1.2.


markdown code blocks are always colored (incorrectly)

I'm using the markdown plugin, and code blocks (surrounded by 3 backticks, or indented four spaces) are always colored with some unknown syntax highlighter (probably Javascript).  I've tried specifying "text" or "Text" as the syntax, but that has no effect.
For example, I am writing this on github which uses GFM (github flavored markdown), and here is a code block with no syntax specified:
0. this should appear (we hope)
1. with no syntax highlighting = just plain text;

compared to specifying javascript syntax:
0. this should appear (we hope)
1. with no syntax highlighting = just plain text;

A workaround is to use <pre> tags instead of standard markdown backticks or indent 4 spaces.
Are any other language syntax besides JavaScript supported?  It seems at least that plain text is not supported.

The default template uses the Google Code Prettify library to do client-side syntax highlighting of code blocks. I believe Prettify attempts to auto-detect the language, but it probably doesn't know about Markdown.
I'm open to pull requests that would improve the current situation. A couple of ideas:

Update the default template to use highlight.js, which speaks more languages, including Markdown. The library doesn't include support for line numbering, but there are ways around that (including this loader).
Modify the Markdown plugin so that GFM language info is passed through to the HTML output, with some user-configurable way to control what HTML attribute is added to identify the language, and perhaps an option to disable syntax highlighting if no language is specified.

poke


Add BERTopic docs

Hi all! It took a while but finally found some time to add some BERTopic docs. Let me know if something is missing and I'll make the appropriate changes.

hi @MaartenGr 👋  – nice stuff!

Awesome work @MaartenGr! It would be nice to do another push for the hub integration features once this is merged :)

@merveenoyan Thanks for the review! I just pushed a commit with the suggested changes. If there is anything that needs to be changed, let me know 😄
@davanstrien That would be great! Let me know what you need for that.


vagrant: Add live code reloading on server file change to Vagrant box.

This PR adds a script for live code reloading to the web server.  Every time a file is changed, the server will be restarted.  Simply run ./run_dev_server.sh to start the server with code reloading turned on.
It also renames the Vagrant directory to vagrant, because I'm lazy when typing capitals to change a directory.  I definitely understand if that change gets rejected though.
I've assigned the PR to Vagrant Master @Felttrip, but the whole team may be interested because it makes working on the backend a lot nicer.  @EaseApp/hackers
Thanks!
-Ryan

I'm calling this one good, :+1:


Chess-Challenge.exe not found

I have .NET 6.0 installed but I can't build

try

Where do I find that?

I only see this

Oh, you need to open youre project as PROJECT, not a folder. Close VS and double-click Chess-Challenge.sln (or open through VS)


Add option to set branch to deploy

Q
A

Bug fix?
No

New feature?
Yes

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

Add option --branch to set branch to deploy. Best way than get of env.

This looks like it would be a breaking change.  My server definitions set the branch via env.  While maybe not obvious at first, this makes perfect sense as I suspect many existing server definitions are environment specific (the documentation certainly guides people to use different server def for prod vs beta, etc).

Branch should be defined in environment variables and --tag option should be
more preferred than branch.
If you want deploy on different branch, i think you should make more stages.

Better to 4.x

I agree wit you @pdbreen . I think the purpose is only add the option --branch without delete env('branch'). But If you make dep deploy --branch=x wins over env=branch of server because you can decide in deploy what branch you want deploy IMHO.

Ok I will don't change my PR beacuse @oanhnn make a PR with correct code of my point of view: https://github.com/deployphp/deployer/pull/771
Thanks!

Done in v4.


autocomplete=off is ignore by Chrome

Haven't tested other browsers yet, but my chrome offers an autocomplete for my select2 search field despite it having autocomplete=off. Really annoying. Any idea how to fix this?

See this: https://code.google.com/p/chromium/issues/detail?id=468153
I worked around it with this code (coffeescript):
setTimeout ->
  $('input.select2-input').attr('autocomplete', "xxxxxxxxxxx")
, 1000

Closing this off because it's a browser issue, and it's difficult to work around browsers which do not conform to the specification.


[DNM] [WIP] Coprocessor on Read Pool

This PR runs all coprocessor requests on Read Pool. It brings performance improvements due to:

There is no longer endpoint schedulers. Previously the scheduler (based on Worker<T>) is single-threaded and will be the bottleneck under heavy loads.
There is no longer pipes to bridge OnResponse and Future / Stream. Coprocessor now natively returns Future or Stream.
Less Boxes.

Besides performance improvements, code base becomes much simpler now:

Major change: Streaming and unary requests are handled in the same way. Unary requests are just streaming requests with only one element. In fact the Endpoint is totally rewritten (named as Service now).
Major change: Provides a common trait for CoprocessorContexts like DAGContext (now named as RequestHandler) so that tests are less tricky to write.

Don't merge: Please merge the following two PRs first

https://github.com/pingcap/tikv/pull/2841
https://github.com/pingcap/tikv/pull/2827.

Work in progress:

[ ] Migrate endpoint tests
[ ] Migrate statistics
[ ] Benchmark performance

Will this feature improve the performance of Sysbench or TPC-C?

@hicqu @AndreMouche @BusyJay PTAL

It's a big rewrite. How about seperate coprocessor on read pool and use RequestHandler as  2 PRs?

We have a new PR. Closing.


Time for a new point release?

Last point release was Dec-2021. Could be nice to have a new tag before OpenFOAM-2306 ships.

when do you want to ship OpenFOAM? We can create a new release.

done


Apply AutoValue to Tag, TagKey, and TagValue.

Codecov Report

Merging #193 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #193     +/-   ##
===========================================
- Coverage     94.78%   94.69%   -0.1%
+ Complexity      397      381     -16
===========================================
  Files            52       52
  Lines          1208     1187     -21
  Branches         79       77      -2
===========================================
- Hits           1145     1124     -21
  Misses           43       43
  Partials         20       20

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/com/google/instrumentation/stats/Tag.java
100% <100%> (ø)
2 <2> (-8)
:arrow_down:

.../java/com/google/instrumentation/stats/TagKey.java
100% <100%> (ø)
3 <3> (-4)
:arrow_down:

...ava/com/google/instrumentation/stats/TagValue.java
100% <100%> (ø)
3 <3> (-4)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebff55a...9f1f0ae. Read the comment docs.


Error 404 on first login to the console

Environment: official docker image
On first login to the console and changing the default password, the console opens, but does not render fully. There are 404 errors in the Chrome console, for example accessing
https://sso.mydomain.tld/zitadel.auth.v1.AuthService/ListMyProjectOrgs
There are also errors in the docker log, sample:
zitadel  | time="2022-10-01T13:44:08Z" level=warning msg="asset in login could not be served" caller="/home/runner/work/zitadel/zitadel/internal/api/ui/login/resources_handler.go:35" error="download failed: ID=DATAB-pCP8P Message=Errors.Assets.Object.NotFound Parent=(sql: no rows in result set)" file="policy/label/css/variables.css?v=2022-10-01T13:43:44Z" org=181421804890357795
zitadel  | time="2022-10-01T13:44:21Z" level=warning msg="asset in login could not be served" caller="/home/runner/work/zitadel/zitadel/internal/api/ui/login/resources_handler.go:35" error="download failed: ID=DATAB-pCP8P Message=Errors.Assets.Object.NotFound Parent=(sql: no rows in result set)" file="policy/label/css/variables.css?v=2022-10-01T13:43:44Z" org=181421804890357795
Side note: it is not obvious from the official documentation that the username of the admin is zitadel-admin in org ZITADEL on sso.mydomain.tld -><EMAIL_ADDRESS>the only place I found it in was the default sample config in the git repo.

Hi - This looks like a http2 upstream problem.
What kind of proxy are you using? We provide some config snippets here https://docs.zitadel.com/docs/guides/manage/self-hosted/proxy

Side note: it is not obvious from the official documentation that the username of the admin is zitadel-admin in org ZITADEL on sso.mydomain.tld -><EMAIL_ADDRESS>the only place I found it in was the default sample config in the git repo.

Great feedback 👍
Question: @livio-a  @hifabienne the version 2.7.0 with #4245 does this not change to just zitadel-admin?

Thanks, you are right, this was it. I added explicitly h2c to traefik config.
traefik.http.services.myservice.loadbalancer.server.scheme=h2c

Great, let me close this issue then, feel free to reopen if you encounter further problems.


Add GDT access links

Why these changes are being introduced:
The GDT UI requires various access links to appear in the record sidebar. The text and hrefs of these depend on the data provider and access restrictions.
Relevant ticket(s):

GDT-141
GDT-175
GDT-176

How this addresses that need:
This applies the requested changes:

A 'Download geodata files' link appears for MIT-provided records that are OA.
A 'Download geodata files' link with an auth notice appears for MIT-provided records that require auth.
A 'View [provider] record' link appears for non-MIT records, where [provider] is the institution providing access to the data.

Non-MIT records always use the kind=Website link, whereas MIT records always use the kind=Download and text=Data link.
GDT-176 is not implemented in this commit, as we have not yet loaded GIS records from Alma.
Side effects of this change:

The schema has been updated, and some unrelated cassettes have been regenerated as a result.
The provider field has been added to the Record query object.
A record SCSS partial has been added.
The controller tests rely on specific data returned by the API call. We've generally avoided this testing approach as it can be brittle, but this seemed like the best way to test the conditional logic in the new access_button partial. We do have tests covering the helper methods, so we could consider removing these tests for now. Either way, we should evaluate E2E testing for this repo (and likely others).

Developer

[x] All new ENV is documented in README
[x] All new ENV has been added to Heroku Pipeline, Staging and Prod
[x] ANDI or Wave has been run in accordance to
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
[ ] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

[ ] The commit message is clear and follows our guidelines
(not just this pull request message)
[ ] There are appropriate tests covering any new functionality
[ ] The documentation has been updated or is unnecessary
[ ] The changes have been verified
[ ] New dependencies are appropriate or there were no changes

Requires database migrations?
NO
Includes new or updated dependencies?
NO
Schema updated?
YES

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

11 of 11 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 99.482%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
384

Relevant Lines:
386

💛  - Coveralls


Purchase of crazy.one subdomain from 1Wallet

It didn't prompt me to add my Twitter address during creation from 1Wallet, so now my subdomain doesn't show on my Twitter. (Also, there's no way to access the subdomain that I can see, but that's not a 1Wallet issue)

I haven't enabled the feature that links purchased domain to external identifiers. It can be activated later. The reason is the infrastructure could offer a lot more than just Twitter handle linkage, so we wanted to reserve the storage slot linked to the subdomain for later use, instead of just a Twitter handle. For example, it could store the wallet owner's profile image, personal website, Telegram id, and a lot more.

So, will 1Wallet be able to link to that subdomain later to update it?

Yes, owner of a subdomain (in this case, the 1wallet address) can update the storage slot of a subdomain at any time as long as the subdomain is not expired.


Add warning if venv found but not active

Closes #1408
I couldn't come up with a good way to add a test for this since all the test macros seem to have a virtual environment active. I'm happy to add one if pointed in the right direction.

Hi, thanks for the PR and sorry the late reply! There are different workflows around virtual environments, some don't require activating it at all (i have e.g. written CI and docker workflow where i used .venv/bin/<bin> to avoid problems with environment variables, and i expect more tool to pick up .venv automatically in the future) and we also plan on extending uv to make venvs more managed, e.g. a uv run command. While there's definitely a gap where users don't realize that they need to activate the venv, i don't think we should unconditionally show a warning.


Unselect Installation

installing the unselected software " Git "
when I select the software that I want and after the click install selected the software called: "git" start installed with them

are you trying to install GitHub desktop?
GitHub Desktop needs git to be installed that's why when you install GitHub Desktop it also install git as a requirement for GitHub desktop.


⚠ Bofrost.de has degraded performance

In bb92c48, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 964 ms

Resolved: Bofrost.de performance has improved in 2289eba.


Use custom time difference between selecting minutes of Datetimepicker

Hi All
I am using DateTimepicker in my application .  I want to change the difference between minutes when selecting time currently it is using 1 minutes difference .I have seen the code I can see there is FiveMinuteKeys .But I don't know where to set it  in xaml

@peererror There are 3 different lists which you can use for the properties SourceHours, SourceMinutes and SourceSeconds like
<Controls:DateTimePicker SourceMinutes="{x:Static Controls:TimePickerBase.IntervalOf5}" />

or IntervalOf10 and IntervalOf15. They all type of IEnumerable<int>.


Schemaless metrics + additional metrics for things we care about

This is based on the discussion in the dev forums:
https://groups.google.com/forum/#!topic/druid-development/weccuTb2W54
This does not yet include doc updates.
This will be a backwards incompatible change for metrics.

There are already concerns about the size of Metrics data. Do you have any numbers on how/if this changes data sizes?

@fjy would you mind also submitting a corresponding PR to https://github.com/metamx/server-metrics, to make SysMonitor and JvmMonitor schemaless as well?

I'm happy to merge this as long as:

[ ] everyone is ok with making the backwards incompatible change in metrics. @cheddar, thoughts?
[ ] remaining issues with exceptions being thrown are resolved

@xvrl @himanshug Addressed all code review comments.

@xvrl @himanshug Any thoughts?

LGTM, @himanshug any other comments?

LGTM

Looks like we need to update docs / configs to rename ServerMonitor to HistoricalMetricsMonitor


Prevent CXXFLAGS from leaking to abc Makefile

Under certain circumstances¹, the CXXFLAGS assigned by the main Makefile can leak down to abc/Makefile.  This causes them to be passed along to abc/depends.sh when depending C++ code (such as abc/src/sat/glucose/AbcGlucose.cpp).  With gcc this seems work cause no problems, but when the compiler is clang this causes an issue because clang is unhappy with getting both -MM (which is from abc/depends.sh) and -MD (which is from Makefile) at the same time, and outputs preprocessed C code instead of dependency rules.
By unexporting CXXFLAGS, the leak is plugged and the build completes normally with clang.
¹ This happens when the environment variable CXXFLAGS is set to something in the environment where the top level make command is run.  The fact that CXXFLAGS was set in the environment causes make to re-export the value of $(CXXFLAGS) that it sets to the environment where it can be picked up by the sub make process.  Note that the flags which break the build do not come from the environment variable, but the environment variable must be set for them to be exported.  This is a quirk of how variable export works in make.

After this patch, how does one pass flags to abc e.g. for cross-compilation?

@whitequark Well, I guess by setting CC= and CXX=, since those are explicitly forwarded to abc?
If you want CXXFLAGS from env to reach abc, then an alternative solution would be to use a different variable name from "CXXFLAGS" in the main Makefile, eg YOSYS_CXXFLAGS := $(CXXFLAGS) and then append to that variable instead...

Eh, sorry, setting CXX= is enough since it is forwarded as "CC" as well.  :smile:

Well, I guess by setting CC= and CXX=, since those are explicitly forwarded to abc?

As in, adding compiler flags to CC and CXX?

As in, adding compiler flags to CC and CXX?

Yes.  When cross compiling you'll need to set the name of your cross compiler of course (like riscv64-unknown-linux-gnu-gcc), but you can add compiler flags as well since the variables are expanded without quoting.  So something like CXX="gcc -mbig-endian" works as intended.

So something like CXX="gcc -mbig-endian" works as intended.

Right. That's perhaps not ideal but I think we can live with that.


Vocabulary types additional views

:heart: Thank you for your contribution!
Description

Please describe briefly your pull request.

Addresses #312
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

[ ] I'm aware of the code of conduct.
[ ] I've created logical separate commits and followed the commit message format.
[ ] I've added relevant test cases.
[ ] I've added relevant documentation.
[ ] I've marked translation strings.
[ ] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
[ ] I've NOT included third-party code (copy/pasted source code or new dependencies).

If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

[ ] I've followed the CSS/JS and React guidelines.
[ ] I've followed the web accessibility guidelines.
[ ] I've followed the user interface guidelines.

Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

split into https://github.com/inveniosoftware/invenio-vocabularies/pull/347 and another that is yet to be added for the edit view of vocabulary items


Matter OT devices do not work with Apple BR implementations

Matter Devices using OT are unable to join and advertise networks hosted by Apple Border Routers. We need help identifying where the issue lies.
The Matter accessory log shows that it's unable to join the network and start the SRP client. "Operation refused for security reasons"
[00:00:30.914,337] <inf> net_openthread: [INFO]-MAC-----:     dst:[fdc7:3536:a992:0:a3f1:9d79:45b1:de0b]:49154
[00:00:30.914,520] <inf> net_openthread: [INFO]-SRP-----: [client] Received response
[00:00:30.914,642] <inf> net_openthread: [INFO]-SRP-----: [client] Server rejected Security code:5
[00:00:30.914,764] <inf> net_openthread: [INFO]-SRP-----: [client] Retry interval 1800 ms
[00:00:30.914,855] <inf> net_openthread: [INFO]-SRP-----: [client] State Updating -> ToRetry
[00:00:30.914,978] <err> chip: [DL]OnSrpClientNotification: Operation refused for security reasons

Expected behavior Matter OT devices should be able to join Apple Thread networks.
Console/log output pcap from the BR and logs from the accessory with OT debug logs are attached.
NRF5_SRP_NoClearSrpHost.txt
BR_utun0_no_clear.txt <- rename this to .pcap, I can't seem to attach it as a pcap file.
@abtink

@sagar-apple, we discussed this on matter slack already. I add a quick summary of findings below.
In short it seems to be an issue with how matter code is using the OT APIs and/or how the BR server is handling the message.

The matter layer code seems to set host address as zero :: and then request a host remove SRP update to be sent to server (usng Srp::Clinet OT APIs).
This the message we see in the pcap file.
The message itself (its format, included RRs, etc) seems to be all fine (no issue in OT SRP client implementation).
We see in next message from pcap that Apple SRP server implementation is reject (with response "refused (5)").
It is likely that the server code does not like the :: address of host.
I know OpenThread SRP server code would check and reject a :: (unspecified) address (so reasable for Apple SRP server implemetation to do the same).

My suggestion is to investigate the matter code base to see why/how the host address is being set as zero.

The Apple Border Router was not accepting a remove host update that did not include a AAAA record. The Apple Border Router implementation will be updated to support this.
While debugging, an bug in the SRP client was discovered around the lease time value on retransmissions. This has been addressed with:

#7216


Invalid config.toml configuration when using local model.

When using local models, the config.toml configuration must be configured according to the models listed on the front end (including the full model path), otherwise the front-end model list will be set to ·null· by default, which will result in failure to run. If config is configured according to the front-end model list. Does toml have a reference standard? Because the model name path here cannot be modified. For example: Even if the model name in the front-end model list exists in local servers such as "LM Studio" and "ollama", after being configured with multiple LLM_MODEL="" methods, "null" will still be displayed on the front-end, unless it is completely consistent with the front-end model list. The method "LLM_MODEL="ollama/llama2:13b-chat-q4_K_M/"" is the only one because their model name paths are consistent.

config.toml------------------------------
LLM_MODEL="TheBloke/deepseek-coder-33B-instruct-GGUF"
LLM_API_KEY="lm-studio"
LLM_EMBEDDING_MODEL=""
LLM_BASE_URL="http://<IP_ADDRESS>:1234/v1"
WORKSPACE_DIR="./workspace"
logs----------------------------------
raise litellm.exceptions.BadRequestError(  # type: ignore
litellm.exceptions.BadRequestError: LLM Provider NOT provided. Pass in the LLM provider you are trying to call. You passed model=null
Pass model as E.g. For 'Huggingface' inference endpoints pass in completion(model='huggingface/starcoder',..) Learn more: https://docs.litellm.ai/docs/providers

try to modify the llm.py file located in opendevin/opendevin/llm, as per the screen we give priority to the config file, even if I currently can't get the answers back from lm studio

I am getting the same type of issue but running on purely Windows with the powershell install
Currently my toml file is
LLM_MODEL = "qwen"
LLM_EMBEDDING_MODEL = "llama2"
LLM_BASE_URL = "http://<IP_ADDRESS>:11434"
WORKSPACE_DIR = "E:\\Projects\\PowerShell\\OpenDevinPowerShell\\opendevin_env\\OpenDevin\\workspace"

Without an LLM_API_KEY defined as I am trying to get it to run locally with ollama.
In OpenDevin/opendevin/server/agent/manager.py in function create_controller, defaults should be loaded from the config but LLM_MODEL is replaced with the default in the script, "gpt-3.5-turbo-1106". This might be an issue with OpenDevin/opendevin/config.py and get_or_default where that function is returning values, if in, the toml or using the default static config in config.py. This is causing LLM_MODEL and LLM_EMBEDDING_MODEL to be ignored.
From this log you see the embedding model ignored along with the LLM_MODEL
embedding_strategy: "llama2"

--- opendevin ignoring embedding model and using huggingface
INFO:sentence_transformers.SentenceTransformer:Load pretrained SentenceTransformer: BAAI/bge-small-en-v1.5
04:12:06 - sentence_transformers.SentenceTransformer:INFO: SentenceTransformer.py:107 - Load pretrained SentenceTransformer: BAAI/bge-small-en-v1.5
INFO:sentence_transformers.SentenceTransformer:2 prompts are loaded, with the keys: ['query', 'text']
04:12:08 - sentence_transformers.SentenceTransformer:INFO: SentenceTransformer.py:224 - 2 prompts are loaded, with the keys: ['query', 'text']
---

DEFAULT_API_KEY None
DEFAULT_BASE_URL http://<IP_ADDRESS>:11434
LLM_MODEL "qwen"
DEFAULT_WORKSPACE_DIR "E:\Projects\PowerShell\OpenDevinPowerShell\opendevin_env\OpenDevin\workspace"
CONTAINER_IMAGE ghcr.io/opendevin/sandbox

--- OpenDevin ignoring above toml config and defaulting to gpt-3.5-turbo
Adding Router
{'model_name': 'gpt-3.5-turbo-1106', 'litellm_params': {'model': 'gpt-3.5-turbo-1106', 'api_key': None, 'api_base': 'http://<IP_ADDRESS>:11434'}}
---

Import config.py interactively you can see it treats the quoted "qwen" as a whole string with double quotes
>>> from opendevin import config
>>> config.get_or_default("LLM_MODEL", "gpt-3.5-turbo-1106")
'"qwen"'

@risingsunomi if you change the if else in the file as I wrote above it gives the priority locally, however I have another problem where lm studio does not return the response to devin

@risingsunomi if you change the if else in the file as I wrote above it gives the priority locally, however I have another problem where lm studio does not return the response to devin

Thank you, will try. I just wonder if the call before llm.py by the server manager or the main is overwritting it as I am seeing it correctly passed when llm.py is loaded but when the llm class is called in main.py or the settings changed via manager.py it drops what the toml was.
Will try this change and hopefully we can make a PR to fix all these toml issues.

the project is very large, I haven't understood the whole thing yet, I tried and there was the only point I found that gave priority to the toml. I hope you find some solutions, I've been stuck with lm studio for 3 days with this issue #812

@risingsunomi if you change the if else in the file as I wrote above it gives the priority locally, however I have another problem where lm studio does not return the response to devin

If so, what's the point of modifying it?

@zhonggegege you can try and see if it works maybe you don't have my problem, because you have some different settings there is this possibility, or don't use lm studio because from what I see a real solution hasn't been found yet

@zhonggegege you can try and see if it works maybe you don't have my problem, because you have some different settings there is this possibility, or don't use lm studio because from what I see a real solution hasn't been found yet

thank you for your reply.

Ok I think I found the solution and got it working with ollama/qwen. It was because in the front end there was the default openai model being sent in the initialization message to the backend over websockets.

I have updated OpenDevin/opendevin/server/agent/manager.py to kinda do what @flavioTocca llm.py update did where just making sure the environment variables are focused on first.

Going to make a PR with this update and hope you can get it working.

I updated the code in the screenshot as that wouldn't let the frontend update the backend settings. Made a PR and have the newest code there

@risingsunomi iI tried the code you ran, removing my part doesn't seem to work

@risingsunomi i try the code you ran, removing my part doesn't seem to work

I got that error when I didn't type in the model that litellm wants it in. Might have to look at their page for your model and see if you have it in the format they need.
For example, I was using quen and not ollama/quen

and why does editing llm.py see it instead? however this is not my issue it was just to give a hint for those who want to start it locally by forcing it, I return to my problem which was closed

@risingsunomi i have a question, i got 'ollama/llama2' from '/api/default-model', i think it should be lcoalStorage.setItem('model'), but i dont see it in my browser. in websocket model set with 'gpt-3.5-turbo-1106'. sorry im not familiar with react i tried, maybe some bugs there.

@iFurySt can you check if the PR above #858 is compatible with the one you proposed #863 ?

@iFurySt can you check if the PR above #858 is compatible with the one you proposed #863 ?

i think #858 doesn't need to be merged~ cuz my changes will overwrite it. 😅

@risingsunomi I just checked @iFurySt 's PR and it seems to work for me. Can you confirm your PR #858 is no longer needed and can be closed?

@risingsunomi I just checked @iFurySt 's PR and it seems to work for me. Can you confirm your PR #858 is no longer needed and can be closed?

Confirmed and closed my PR. @iFurySt appreciate the hard work on this, thank you.

Sounds like this is fixed now that @iFurySt's PR is in. LMK if not!


Handling recordtorecord coercion

Called when patching a record with different types of fields.
Example:
With({t1:Table({a:stringVar})},Patch(t1,First(t1),{a:5}))

✅ No public API change.

✅ No public API change.

✅ No public API change.


Collect and add alternatives to readme

There are two classes of alternatives. Those that do the same job slightly differently (list pros and cons), and those that do a different job (you should use them if). This is intended to help visitors choose a library to use and should belong in the readme file.

A wiki page have been created for this: https://github.com/xiegeo/must/wiki/Alternatives
Todo: add link to wiki page from readme.


Kosaraju's algorithm for Strong Connected Components

💥 Proposal
I'd like to add code for Kosaraju's algorithm for Strong Connected Components in C# with proper comments and explanation
Have you read the Contributing Guidelines on Pull Requests?
YES

/assign


Add custom RuneLite Color picker

Fixes #2503
Adds a custom runelite color picker with the long awaited alpha slider. This new color picker attempts to give a modern but functional look to the default substance/java color pickers. It also adds rgb value sliders, hex and rgba inputs and the transparency slider. So we can finally have user-selected transparent colors.
This is my first time doing something of this sort so I'm sure you guys will have some fun pointing out where I can clean up or optimize. I'd really appreciate some feedback and reviews.

Mentioned this in Discord, but for visibility I'll say this here too: We need to be careful about changing the color picker to add alpha, since there are a number of config options which affect chat colors (eg. <col=ffffff> tags inserted into chat) which would not work with an alpha hex color (eg. ffffffff). I think ColorUtil's functions mostly avoid this issue already, but we should make sure that's the case, that it has test cases written to ensure that, and that client code/plugins are going through ColorUtil.

Going to leave my comments from discord here too for record.
Switching to HSB based rendering for the TonerPanel and ColorPanel will reduce complexity of the application overall and provide access to 40% more colors in the limited gradient space.


Can't execute v1.34.0 with error "cannot load such file -- rubocop-rails"

I can't run rubocop v1.34.0.
Downgrading to v1.33.0, I could run it correctly.

Expected behavior
In the rails project,

execute % rubocop
then execute correctly

Actual behavior
% rubocop --debug
For /path-to/ruby-project: configuration from /path-to/ruby-project/.rubocop.yml
cannot load such file -- rubocop-rails
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/feature_loader.rb:33:in `require'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/feature_loader.rb:33:in `load'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/feature_loader.rb:21:in `load'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/config_loader_resolver.rb:14:in `block (2 levels) in resolve_requires'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/config_loader_resolver.rb:13:in `each'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/config_loader_resolver.rb:13:in `block in resolve_requires'
<internal:kernel>:90:in `tap'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/config_loader_resolver.rb:12:in `resolve_requires'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/config_loader.rb:46:in `load_file'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/config_loader.rb:104:in `configuration_from_file'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/config_store.rb:68:in `for_dir'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/config_store.rb:47:in `for_pwd'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/cli.rb:99:in `parallel_by_default!'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/lib/rubocop/cli.rb:46:in `run'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/exe/rubocop:19:in `block in <top (required)>'
/path-to/.rbenv/versions/3.1.1/lib/ruby/3.1.0/benchmark.rb:311:in `realtime'
/path-to/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rubocop-1.34.0/exe/rubocop:19:in `<top (required)>'
/path-to/.rbenv/versions/3.1.1/bin/rubocop:25:in `load'
/path-to/.rbenv/versions/3.1.1/bin/rubocop:25:in `<main>'
Finished in 0.01386200000001736 seconds

Steps to reproduce the problem

Just do %rubocop

RuboCop version
% bundle exec rubocop -V
1.34.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.21.0, running on ruby 3.1.1 arm64-darwin21)
  - rubocop-rails 2.15.2

Can confirm this issue. It fails for any require that is placed in the .rubocop.yml config file, works fine when using the cli argument $ rubocop --require rubocop-rails --require rubocop-performance.

+1

This error is caused by #10845. It requires backward compatibility.

@hiro-teaaa Can you provide configuration around require: in .rubocop.yml?

@koic Thank you for checking in so quickly.

Can you provide configuration around require: in .rubocop.yml?

Sure, here it is
require:
  - rubocop-rails

AllCops:
  TargetRubyVersion: 3.1.1
~~~

Is it enough?

@hiro-teaaa OK, It was reproducible. Thank you!

@koic I got similar issue with rubocop-performance
Mine .rubocop.yml is here
You could checkout this project, it's fully opensource and failing with latest update

JFYI, RuboCop 1.34.1 has been released. Thank you.

@koic Thanks for quick fix

It fails for me with rubocop-performance:
# .rubocop.yml
require:
- rubocop-rake
- rubocop-rails
- rubocop-performance

# Gemfile
  gem 'rubocop', require: false
  gem 'rubocop-performance', require: false
  gem 'rubocop-rails', require: false
  gem 'rubocop-rake', require: false

$ bundle exec rubocop
cannot load such file -- rubocop-performance
/home/oleg/.rbenv/versions/3.2.1/lib64/ruby/gems/3.2.0/gems/rubocop-1.45.1/lib/rubocop/feature_loader.rb:46:in `rescue in rescue in load'
/home/oleg/.rbenv/versions/3.2.1/lib64/ruby/gems/3.2.0/gems/rubocop-1.45.1/lib/rubocop/feature_loader.rb:39:in `rescue in load'

rubocop-rake and rubocop-rails work ok, but not rubocop-performance
$ bundle exec rails c
Loading development environment (Rails 7.1.0.alpha)
[1] pry(main)> require 'rubocop-performance'
=> true

rubocop-1.45.1, bundler 2.4.7, rails master, ruby 3.2.1

Still getting such error with v1.60.2.
I'm adding new rubocop extentions to my Gemfile (ex. 'rubocop-rails') and then to the .rubocop.yml.
And when I try to execute rubocop - oops! cannot load such file.
But! I was able to fix this with rubocop --restart-server.
In the docs I found this: https://docs.rubocop.org/rubocop/usage/server.html#restart-server

The started server does not reload the configuration file. You will need to restart the server when you upgrade RuboCop or change the RuboCop configuration.

Same issue with new  rubocop-rspec 3.0.1 and rubocop 1.64.1
cannot load such file -- rubocop-rspec_rails
.rubocop.yml
require:
  - rubocop-performance
  - rubocop-rails
  - rubocop-rspec
  - rubocop-rspec_rails
  - rubocop-factory_bot

Gemfile:
group :development, :test do
  gem 'debug', platforms: %i[mri mingw x64_mingw]
  gem 'factory_bot_rails'
  gem 'irb'
  gem 'reline'
  gem 'rspec-rails'
  gem 'rubocop', require: false
  gem 'rubocop-performance', require: false
  gem 'rubocop-rails', require: false
  gem 'rubocop-rspec', require: false
end

The same error.

Ruby 3.3.3
rubocop (1.64.1)
rubocop-rspec (3.0.1)
rubocop-rspec_rails (2.30.0)
rubocop-factory_bot (2.26.1)

# .rubocop.yml
require:
  - rubocop-performance
  - rubocop-rails
  - rubocop-rspec
  - rubocop-faker
  - rubocop-factory_bot
  - rubocop-rspec_rails

# Gemfile

group :development do
gem 'fasterer'
gem 'rubocop', require: false
gem 'rubocop-factory_bot', require: false
gem 'rubocop-faker', require: false
gem 'rubocop-performance', require: false
gem 'rubocop-rails', require: false
gem 'rubocop-rspec', require: false
gem 'rubocop-rspec_rails', require: false
bundle exec rubocop
cannot load such file -- rubocop-factory_bot

bundle exec rubocop
cannot load such file -- rubocop-rspec_rails

here

looks like fix is ready in PR and we just needs to wait until it is merged and published.
For now it works for me when I manually run rubocop . instead of just rubocop. Or when I downgrade rubocop from 1.64.1 down to 1.64.0

For me @BoutPure 's answer worked
rubocop --restart-server


"Warthog" Z-95 Non-functional Ability

Fly Casual Release Version
V2.5.20241102.02
Online Game Mode
No
Describe the bug
"Warthog" flown in the Z-95 Headhunter does not have  functioning ability. He should be able to keep himself and friendly non-limited ships from being removed until the end of the engagement phase (so that they can still attack).
To Reproduce
Steps to reproduce the behavior:

Fly "Warthog" in the Clone Z-95 Headhunter.
Have "Warthog" be destroyed during the engagement phase (before he has the opportunity to attack).
OR
Have a non-limited friendly ship at range 0-2 of "Warthog" be destroyed (for my testing, "Warthog" was flying with 7th Sky Corps Pilots).

Expected behavior

"Warthog" and friendly non-limited ships at range 0-2 should be able to attack during the engagement phase, even after being destroyed. They should not be removed until the end of the engagement phase.

Platform/Device (be as specific as possible):

OS: Android
Version 14

Additional Context

Bug was not tested with the LAAT version of "Warthog". Verification if his ability functions across both chassis my be warranted.

Warthog has the wrong ability assigned. LAAT appears to have the correct Warthog ability which is the same, will relink. Thanks for finding this.


snapTools: remove

Description of changes
snapTools.makeSnap has produced broken snaps since at least Oct 2020, as indicated by the following issue: https://github.com/NixOS/nixpkgs/issues/100618 (note that the issue mentions it's broken since snapd version >= 2.36, which dates back to Oct 2018)
No person has shown interest in maintaining it, and given that there is no fix available, it's assumed that all attempts made to fix that function have not succeeded (I personally made such attempt and was only able to make the snap work for statically-compiled binaries, which reduces considerably the utility of the function).
Given that snapTools only contained makeSnap, it was removed completely.
The message that is thrown when someone attempts to use snapTools will point them to https://github.com/NixOS/nixpkgs/issues/100618, which will also link to this PR. If anybody has questions about this change, feel free to contact me.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2024-03-07-documentation-team-meeting-notes-112/40963/1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2024-03-14-documentation-team-meeting-notes-113/41462/1


Suggestion: “Episode” element on title page

I’d like to suggest adding “Episode” as new element/key for fountain title pages. This element could be used for an episode number or title and would ideally come between title and credit. I’ve added it to my parser and pdf maker, and found it very useful when I’m writing for tv.

As far as I know, you can use any key-value pair you like. Is there a need to standardize this?


Difference with native Promise

new Promise((resolve, reject) => {
  resolve();
})
  .then(() => {
    console.log('outer tick0');
    new Promise((resolve, reject) => {
      resolve();
    })
      .then(() => {
        console.log('inner tick0');
        return Promise.resolve();
      })
      .then(() => {
        console.log('inner tick1');
      })
  })
  .then(() => {
    console.log('outer tick1');
  })
  .then(() => {
    console.log('outer tick2');
  })
  .then(() => {
    console.log('outer tick3');
  })
  .then(() => {
    console.log('outer tick4');
  })

// native promise output
// outer tick0
// inner tick0
// outer tick1
// outer tick2
// outer tick3
// inner tick1
// outer tick4

// then/Promise output
// outer tick0
// inner tick0
// outer tick1
// inner tick1
// outer tick2
// outer tick3
// outer tick4

What's the reason behind this?

I'm fairly sure the order in which the callbacks are invoked is undefined, and is thus an implementation detail you should not rely on.

I'm fairly sure the order in which the callbacks are invoked is undefined, and is thus an implementation detail you should not rely on.

Is the order in which the callbacks are invoked defined in the ECMAScript Specification or any other place?


Mobile Support?

The Month & Year Fields do not work on mobile (android)
I'm going about replacing with two drop down lists

@copremesis Thanks for pointing that out - it worked on Android the last time I checked, but clearly I've broken something somewhere.
I was thinking the same thing with the drop down lists, it's a good idea.
I will work on both issues over Christmas and get something published ASAP. If you get anywhere with the drop down lists in the mean time let me know.
Thanks

Hi there! I think we know what the issue is as we were having it ourselves. It has to do with the mask and the default Samsung keyboard (Samsung S6 at least). When using their keyboard, the mask isn't applied and doesn't parse/delimit the month and year properly. When using the Google keyboard for Android instead, it magically works as expected. Not sure if this is the complete answer, but this is definitely the source of the problem. Would love a fix for this as well. Got to the bottom of this by reading this issue on a separate jQuery mask plugin: https://github.com/igorescobar/jQuery-Mask-Plugin/issues/348

Any chance anyone has figured out how to fix this?

@colin-stannard  have you got a chance to look into it ?

Any updates on this issue?  It seems to be the same or similar issue as #28 #32 and #35
I love this credit card form but I am now on a daily basis getting emails from customers saying they are getting invalid expiration date errors.  I have to tell them to use a different device or different virtual keyboard on their device.
Short of fixing it properly, does anyone have any advice on how to detect browsers/keyboards/devices that have this problem and just display simple fields for those users?
Thanks!

I've tried fixing this previously and I was unable to replicate the problem. I should have some time to look at this soon, I will borrow a Samsung device and try to sort this.

Still waiting for a fix on this. It's easy to replicate, open up Browserstack, launch a Samsung Tab 4 and see the issue first hand.
Seems the fix here is to use dropdowns, and changing CardJs.EXPIRY_USE_DROPDOWNS = true; doesn't seem to produce dropdown fields. I'll continue digging to see why but this is easily replicable every single time.


chore(logging): update logging remote constraint ETag caching

Issue #

Description
Update the Logging remote constraint provider to fetch the configuration and look up the ETag in the response header.  If-None-Match should only be in the request header not the response header, keeping this logic in so that it is not a breaking change to existing customers.
General Checklist

[ ] Added new tests to cover change, if needed
[x] Build succeeds with all target using Swift Package Manager
[x] All unit tests pass
[x] All integration tests pass
[x] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[x] Documentation update for the change if required
[x] PR title conforms to conventional commit style
[x] New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
[x] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6444f3a) 68.11% compared to head (e7954ab) 67.93%.

Files
Patch %
Lines

...tion/DefaultRemoteLoggingConstraintsProvider.swift
0.00%
8 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3494      +/-   ##
==========================================
- Coverage   68.11%   67.93%   -0.19%
==========================================
  Files        1070     1080      +10
  Lines       36065    36431     +366
==========================================
+ Hits        24565    24748     +183
- Misses      11500    11683     +183

Flag
Coverage Δ

API_plugin_unit_test
67.12% <ø> (-0.12%)
:arrow_down:

AWSPluginsCore
64.18% <ø> (ø)

Amplify
48.12% <ø> (-0.05%)
:arrow_down:

Analytics_plugin_unit_test
81.16% <ø> (ø)

Auth_plugin_unit_test
78.99% <ø> (+<0.01%)
:arrow_up:

CoreMLPredictions_plugin_unit_test
59.44% <ø> (ø)

DataStore_plugin_unit_test
80.54% <ø> (-0.99%)
:arrow_down:

Geo_plugin_unit_test
70.75% <ø> (?)

Logging_plugin_unit_test
62.87% <0.00%> (-0.47%)
:arrow_down:

Predictions_plugin_unit_test
37.16% <ø> (ø)

PushNotifications_plugin_unit_test
87.13% <ø> (ø)

Storage_plugin_unit_test
77.51% <ø> (ø)

unit_tests
67.93% <0.00%> (-0.19%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Leather colored armor problem in #1651

Server version :  CraftBukkit version git-Spigot-2cf50f0-2b93d83 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT) This is a final build for 1.12.2.
Denizen version : 1.0.2-SNAPSHOT (build 1651), core version: 1.15 (Build 152)
Script : https://one.denizenscript.com/haste/50214
Debug : http://old.mcmonkey.org/paste/50213
Command used : /ex give Botte_hermes

err...
 color: co@F9801D
^ that's not valid.
View the debug output (in your own link) to see the correct format for a color object.

It doesn't work with the command /ex give i@leather_boots[display_name=Hermes;color=co@160,101,64]

Update : The format color: co@F9801D worked before version 1651
Now it work only with co@blue or for eg: co@50,50,50

No part of the relevant parsing logic has changed recently.
There's no reason that input should have / would have worked on any recent versions to my knowledge.

The successful test was on #1647, there where many change since

Update : after some test, it was before this version. We where using the script related to co@F9801D 2 years ago and we doesn't use it since. It was just now that we where again interested in using the color format in leather armor
Sorry but I have not time to test it on older version, I should check the updated use next time


Pausing without showing interface feature

So for instance there's a need to look some details on the video or you just need time to read the subtitle, you pause the video, but pausing video always showing app interface blocking the view and you can't hide it.

Duplicate of #195


added a mini-profile card for Peter Ndungu

adding a mini-profile card for Peter Ndungu
My name of course
My image using cloudinary.com
A short bio about what I do outside the programme and what my hobbies are.
A link to my GitHub profile

This is great Peter, Just a note though, your image should be rounded. just see an example of how mine looks then edit and do another pull request.
Good job!


docs: Use SVG format for images

Diagrams in the Markdown files are better rendered on any screen size if
they are in vector format, such as SVG.
This change also improves positioning and scaling of the diagrams, which
is now easy to change with the vector image format.

https://github.com/pavelkalinnikov/merkle/blob/use_svg_for_images/docs/data_model.md

Ping


Cleanup @NamedArgument

Codecov Report

Merging #84 (64aa217) into master (b6be471) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   97.09%   97.09%
=======================================
  Files          14       14
  Lines        1409     1409
=======================================
  Hits         1368     1368
  Misses         41       41

Impacted Files
Coverage Δ

source/argparse/package.d
99.25% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Geometric path animation support

I know this was mentioned in the BUILD 2015 but just wonder if there's a timeline for it? I am asking because if it's coming soon then I will wait for it otherwise I will have to find an alternative.
Thanks guys!

Hey Justin!
Thanks for reaching out and sorry for a bit of a delay on the response. Unfortunately, "Not Soon" is your timeline for path animations, but we are thinking about them. If you have early feedback/scenarios in mind, feel free to send them our way!

No worries @patsiu. :)
Basically I just want to animate the points of a shape and turn them into another shape. Real world examples would be, how a three-line hamburger menu icon gets transformed into a back arrow icon, or how a circular user profile background into a rectangular details background.


Normalize project versioning and soname

Instead of custom variable names, use the standard CMAKE_PROJECT_VERSION, PROJECT_VERSION_MAJOR etc.
Use them to properly set SOVERSION.

@JohanMabille let's introduce what we did for soname with xeus.


[Edge] Change thread attribute

pthread_join can wait joinable thread.
So, change thread attribute.
Signed-off-by: gichan<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #39. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


Data paging

This request adds paging to some of the data collections.
In cases such as characters for a Media entry only 25 entries are retrieved by default and the rest has to be requested as separate pages. I've added paging to all the collections that I use that require it. To make paging easier and cleaner I've moved the GraphQL queries to a new class and separated the parts that need to be paged out. That way the first 25 entries are retrieved along with the Media (or other types) and the rest are requested if required returning only the page data that is needed.
I have also expanded one or two of the Media/Character/Staff entries to include additional data that I use to filter entries (for example I don't make use of Manga, my app only deals with anime so Character media entries now includes the media type).
Finally I added code documentation to all of the methods in the Client.cs class.

Nice! I'll take a closer look at this tomorrow :)


Adding guards around adding protobuf targets

This test seems to be failing consistently:
20:39:52 lib/python2.7/dist-packages/caffe2/python/operator_test/blobs_queue_db_test.py::BlobsQueueDBTest::test_create_blobs_queue_db_string Build timed out (after 30 minutes).

@yinghai this is a known problem that we've been having for a while. They seemed to appear after we bumped the docker versions to 43.

@pjh5 Were you able to reproduce this with the dockerfile? Because I was not able to reproduce...

@yinghai these failures are not consistent, and we don't know their cause yet. But I am quite certain that they are unrelated to this change


Add frontend config files to config folder

https://github.com/damienbod/AngularWebpackVisualStudio/issues/31

Can't we close this with Roberto's check in?


Logoff-DisconnectedSession: Script Should Not Use Hardcoded Log Path

Instead of hard coding the path to the log directory consider using the following:
[Environment]::GetFolderPath('ApplicationData')
I changed mine to $LogFile = [Environment]::GetFolderPath('ApplicationData') + "\DisconnectedSessions\sessions_" + $([DateTime]::Now.ToString('yyyyMMdd')) + ".log"
You'll probably also want to ensure that the folder path exists; I created an Ensure-LogFolder method that just gets called prior to the rest of the script execution; nothing fancy:
function Ensure-LogFilePath([string]$LogFile)
{
    $LogFileFolder = [System.IO.Path]::GetDirectoryName($LogFile)
    [System.IO.Directory]::CreateDirectory($LogFileFolder)
}

You might also want to modify how Write-Log is implemented such that it doesn't rely on the global $LogFile, but that is a stylistic choice.
As an aside your commenting system on your blog is broken; otherwise I would have responded there; thank you for the useful script!

Thank you for the remarks... I will look into them.


Exploratory Branch for Addressing Missing Bridge Indexer Events

Summary

RFCs: $\emptyset$.
Categories: protocol-units

The Bridge Indexer is missing events. Logs from the Bardock node these events are being missed generally. The currently leading guess is that this is related to #856. However, this branch is open for checking several other possibilities.
Changelog

Testing

Outstanding issues

Seems like all is well with #690 merged in. For any looking to verify, you can...

just bridge-solo native build.eth-holesky.mvt-bardock-testnet.indexer --keep-project
Bridge over with the UI: https://bridge.testnet.movementnetwork.xyz/
Check your Hasura server at: http://localhost:8085/ (you will have to track the public tables the first time)

Unit tests failures are the same as #690

Sadly @l-monninger "The base branch requires all commits to be signed"

@0xmovses not if you are me.


[feature-request] slows down editing

Description
this is super useful plugin! However, I noticed it considerably slows down editing of the document. I have a document of several thousand lines with highlighted keywords dispersed throughout. When I enable the plugin sometimes typing takes effect after several seconds.
Proposed Solution
is it even possible to make it faster for a large document?
Alternatives Considered
No response

Hi @ondrobaco, thanks for your feedback. I will take a look into it. Perhaps there is a solution to render only the visible area, but I am uncertain about that.


Microsoft Visual Studio 2022 Preview C++20 Problem with std::chrono std::format Output

This simple code should output 10:55:23 EDT but instead it outputs 10:55:23 GMT-4
auto tm = std::chrono::system_clock::now();
std::cout << std::format("{:%X %Z}", std::chrono::zoned_time("America/New_York", tm));

There is something wrong with the way MSVC is outputting Time Zones.
This code has been tested to work correctly on other compilers.
Visual Studio Info
Microsoft Visual Studio Community 2022 Preview
Version 17.0.0 Preview 2.0
VisualStudio.17.Preview/17.0.0-pre.2.0+31512.422
Microsoft .NET Framework
Version 4.8.04161
Installed Version: Community
Visual C++ 2022   00476-70000-00000-AA652
Microsoft Visual C++ 2022
ASP.NET and Web Tools 2019   17.0.303.37752
ASP.NET and Web Tools 2019
Azure App Service Tools v3.0.0   17.0.303.37752
Azure App Service Tools v3.0.0
C# Tools   4.0.0-2.21362.3+5f7ddf6f02d40036fdbf823cd9910027da277acd
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.
Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers
Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards
Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package
NuGet Package Manager   6.0.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/
ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info
Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.
Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.
TypeScript Tools   17.0.0701.2001
TypeScript Tools for Microsoft Visual Studio
Visual Basic Tools   4.0.0-2.21362.3+5f7ddf6f02d40036fdbf823cd9910027da277acd
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Visual F# Tools   17.0.0-beta.21352.5+3af67cd8ffd73b2dc443e1e24dc0cf28f7e1c608
Microsoft Visual F# Tools
Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio
Visual Studio IntelliCode   2.2
AI-assisted development for Visual Studio.
Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake
System Info
OS Name	Microsoft Windows 10 Pro
Version	10.0.21354 Build 21354

This is not a Live Share issue. You can file feedback against Visual Studio here (https://developercommunity.visualstudio.com/home) or inside the product using the Feedback options.


Added ApiLeap API which allows you to make screenshots of web pages a…

…nd HTML.
Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide.
[x] Your changes are made in the README file, not the auto-generated JSON.
[x] Your additions are ordered alphabetically.
[x] Your submission has a useful description.
[x] Each table column should be padded with one space on either side.
[x] You have searched the repository for any relevant issues or PRs.
[x] Any category you are creating has the minimum requirement of 3 items.

Thanks!


Switch to application IDs for admin application review UI.

Description
Using applicant IDs to alert admins of new applications, and to describe applications in admin list/detail views was confusing since the CSV export uses application IDs and there can be many applications for the same applicant. This PR switches to using application IDs instead if applicant IDs in most places, or makes it clear which one is being referenced.
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
Closes #1605

Screen shots

Overview

Application detail


add dotenvx status command

this will work similar to git status - showing you differences between your .env* files and encrypted .env.vault contents.

released as v0.36.0


BBNORM: Cannot run program “bgzip”

Description of the bug
I am running metatdenovo (nf-core/metatdenovo vv2.5.1-gd57e1db) with bbnorm using singularity (v3.6.4).
BBNORM fails with the following information in the "all_samples.bbnorm.log"
Set threads to 6
***********  Pass 1  **********
Settings:
threads:        6
k:           31
deterministic:     true
toss error reads:    false
passes:         1
bits per cell:     16
cells:         73.25B
hashes:         3
base min quality:    5
kmer min prob:     0.5
target depth:      400
min depth:       3
max depth:       500
min good kmers:     15
depth percentile:    64.8
ignore dupe kmers:   true
fix spikes:       false
Made hash table:    hashes = 3    mem = 136.42 GB    cells = 73.24B     used = 50.244%
Estimated unique kmers:<PHONE_NUMBER>3
Table creation time:      11794.754 seconds.
java.io.IOException: Cannot run program “bgzip”: /scratch/SlurmTMP/smomw524.8777496/TEMPFILE_BBNORM_P1_R1_40d0ef1f161000ebd9da1ec6b00c71__802.5645338018305.fq.gz (No such file or directory)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1073)
at fileIO.ReadWrite.getOutputStreamFromProcess(ReadWrite.java:708)
at fileIO.ReadWrite.getBgzipStream(ReadWrite.java:628)
at fileIO.ReadWrite.getGZipOutputStream(ReadWrite.java:533)
at fileIO.ReadWrite.getOutputStream(ReadWrite.java:382)
at fileIO.ReadWrite.getOutputStream(ReadWrite.java:344)
at stream.ReadStreamWriter.(ReadStreamWriter.java:71)
at stream.ReadStreamByteWriter.(ReadStreamByteWriter.java:18)
at stream.ConcurrentGenericReadOutputStream.(ConcurrentGenericReadOutputStream.java:38)
at stream.ConcurrentReadOutputStream.getStream(ConcurrentReadOutputStream.java:71)
at stream.ConcurrentReadOutputStream.getStream(ConcurrentReadOutputStream.java:29)
at jgi.KmerNormalize.count(KmerNormalize.java:1496)
at jgi.KmerNormalize.runPass(KmerNormalize.java:1111)
at jgi.KmerNormalize.main(KmerNormalize.java:673)
Caused by: java.io.FileNotFoundException: /scratch/SlurmTMP/smomw524.8777496/TEMPFILE_BBNORM_P1_R1_40d0ef1f161000ebd9da1ec6b00c71__802.5645338018305.fq.gz (No such file or directory)
at java.base/java.io.FileOutputStream.open0(Native Method)
at java.base/java.io.FileOutputStream.open(FileOutputStream.java:293)
at java.base/java.io.FileOutputStream.(FileOutputStream.java:235)
at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:223)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1110)
... 14 more
Exception in thread “main” java.lang.AssertionError: Could not execute bgzip -c -f -l 4 -@ 6
at fileIO.ReadWrite.getOutputStreamFromProcess(ReadWrite.java:713)
at fileIO.ReadWrite.getBgzipStream(ReadWrite.java:628)
at fileIO.ReadWrite.getGZipOutputStream(ReadWrite.java:533)
at fileIO.ReadWrite.getOutputStream(ReadWrite.java:382)
at fileIO.ReadWrite.getOutputStream(ReadWrite.java:344)
at stream.ReadStreamWriter.(ReadStreamWriter.java:71)
at stream.ReadStreamByteWriter.(ReadStreamByteWriter.java:18)
at stream.ConcurrentGenericReadOutputStream.(ConcurrentGenericReadOutputStream.java:38)
at stream.ConcurrentReadOutputStream.getStream(ConcurrentReadOutputStream.java:71)
at stream.ConcurrentReadOutputStream.getStream(ConcurrentReadOutputStream.java:29)
at jgi.KmerNormalize.count(KmerNormalize.java:1496)
at jgi.KmerNormalize.runPass(KmerNormalize.java:1111)
at jgi.KmerNormalize.main(KmerNormalize.java:673)
Command used and terminal output
No response
Relevant files
No response
System information
No response

I think the key part of the error is this line:
Cannot run program “bgzip”: /scratch/SlurmTMP/smomw524.8777496/TEMPFILE_BBNORM_P1_R1_40d0ef1f161000ebd9da1ec6b00c71__802.5645338018305.fq.gz (No such file or directory)

At first my guess was that the bgzip program was missing from the container, but now I start to wonder if it's the input file that's missing. It can be missing when run in the container either by actually being missing, or by existing on a non-mounted file system. Do you use any parameter or config directive to make Nextflow use /scratch?
I think this thread: https://nfcore.slack.com/archives/CKDDD9JB0/p1688127045331519 might hold the solution, though I'm not sure how to set this up. Maybe your cluster administrator needs to configure Singularity to mount /scratch?
There's also this message: https://nfcore.slack.com/archives/CKDDD9JB0/p1675213873767469. It seems one can add mounts with singularity.runOptions in the nextflow.config in the pipeline execution directory. I'd try something like singularity.runOptions = -B /scratch:/scratch to mount the host /scratch file system as /scratch in the container.

There is something that we can do for this issue? or it is a singularity/container issue? if it so, we can close it


Remove integration-blueprint from Readme

The integration-blueprint repository has removed tests.
See https://github.com/ludeeus/integration_blueprint/commit/15feac505d7b21e6c17e48f918fa04cf0e340a0e

Thanks!  I additionally removed the reference in the next point.


macOS hosted agents unable to build Xamarin.iOS 15.x

Description
Xamarin.iOS <IP_ADDRESS> was released to the Stable VS release channel yesterday. Azure DevOps hosted agents' latest Xamarin bundle available is 6_12_9, which maps to Xamarin.iOS 14.20 as the latest available version.
Developers are now starting to write iOS 15-specific bug fixes against 15.x locally, only to have the CI/CD build fail due to using new APIs not yet available in Xamarin.iOS 14.20. Here is an example of an issue that we're blocked on fixing.
I know Xamarin.iOS 15.x was just released, but could we possibly get a timeline on when this will be available in Azure DevOps / GitHub Actions?
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[X] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
20210917.1
Is it regression?
No
Expected behavior
Builds utilizing the latest, stable, available iOS APIs can be built successfully
Actual behavior
Builds containing iOS 15 API usage are passing locally, but failing in Azure DevOps
Repro steps

Create an empty Xamarin Forms app with a ListView somewhere in it
Write a small custom ListView renderer in your iOS project, similar to this, make sure to set SectionHeaderTopPadding
Build project using Azure DevOps hosted macOS agent and latest available Xamarin bundle

Hi @cgwhouse! Xamarin iOS 15 will be available on the macOS-11 image early next week.

@miketimofeev Thank you for the reply 😄 Sounds good.

BTW as you can see on the logs bellow of my Azure Pipelines build running on vmImage: 'macOS-11', it indicates that it is using XCode 12.5.1 instead of XCode 13. Could you guys make sure that XCode 13 and it's respective Xcode command line tools are set to the 13 version.
Starting: XamariniOS
==============================================================================
Task         : Xamarin.iOS
Description  : Build an iOS app with Xamarin on macOS
Version      : 2.189.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/build/xamarin-ios
==============================================================================
/Library/Frameworks/Mono.framework/Versions/Current/Commands/msbuild /version /nologo
/Library/Frameworks/Mono.framework/Versions/Current/Commands/msbuild /Users/runner/work/1/s/src/StudyCompanion.iOS/StudyCompanion.iOS.csproj /p:Configuration=Release /p:Platform=iPhone /p:BuildIpa=true /p:DefineConstants="ENABLE_TEST_CLOUD;" /p:Codesignkey=iPhone Distribution: SURGENT MCCOY CPE%2C LLC (388HNF8X9B) /p:CodesignProvision=5b9a00a9-96cc-4fba-bd9a-5925ac82c8d6
Microsoft (R) Build Engine version 16.6.0 for Mono
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 10/1/2021 3:08:56 PM.
Project "/Users/runner/work/1/s/src/StudyCompanion.iOS/StudyCompanion.iOS.csproj" on node 1 (default targets).
PrepareForBuild:
  Creating directory "bin/iPhone/Release/".
  Creating directory "obj/iPhone/Release/".
_BeforeCoreCompileImageAssets:
  Directory "obj/iPhone/Release/actool" doesn't exist. Skipping.
_CoreCompileImageAssets:
  Tool /usr/bin/xcrun execution started with arguments: actool --errors --warnings --notices --output-format xml1 --output-partial-info-plist /Users/runner/work/1/s/src/StudyCompanion.iOS/obj/iPhone/Release/actool/partial-info.plist --app-icon AppIconSurgent --compress-pngs --target-device iphone --target-device ipad --minimum-deployment-target 10.3.1 --platform iphoneos --compile /Users/runner/work/1/s/src/StudyCompanion.iOS/obj/iPhone/Release/actool/bundle /Users/runner/work/1/s/src/StudyCompanion.iOS/obj/iPhone/Release/actool/cloned-assets/Assets.xcassets

_CoreCompileInterfaceDefinitions:
  Tool /usr/bin/xcrun execution started with arguments: ibtool --errors --warnings --notices --output-format xml1 --minimum-deployment-target 10.3.1 --target-device iphone --target-device ipad --auto-activate-custom-fonts --sdk /Applications/Xcode_12.5.1.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk --compilation-directory /Users/runner/work/1/s/src/StudyCompanion.iOS/obj/iPhone/Release/ibtool /Users/runner/work/1/s/src/StudyCompanion.iOS/Resources/LaunchScreen.storyboard

  Tool /usr/bin/xcrun execution started with arguments: ibtool --errors --warnings --notices --output-format xml1 --minimum-deployment-target 10.3.1 --target-device iphone --target-device ipad --auto-activate-custom-fonts --sdk /Applications/Xcode_12.5.1.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk --compilation-directory /Users/runner/work/1/s/src/StudyCompanion.iOS/obj/iPhone/Release/ibtool /Users/runner/work/1/s/src/StudyCompanion.iOS/ScreenLaunch.storyboard

  Tool /usr/bin/xcrun execution started with arguments: ibtool --errors --warnings --notices --output-format xml1 --minimum-deployment-target 10.3.1 --target-device iphone --target-device ipad --auto-activate-custom-fonts --sdk /Applications/Xcode_12.5.1.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk --link /Users/runner/work/1/s/src/StudyCompanion.iOS/obj/iPhone/Release/ibtool-link /Users/runner/work/1/s/src/StudyCompanion.iOS/obj/iPhone/Release/ibtool/LaunchScreen.storyboardc /Users/runner/work/1/s/src/StudyCompanion.iOS/obj/iPhone/Release/ibtool/ScreenLaunch.storyboardc

    BundleResources Output:
      obj/iPhone/Release/ibtool-link/ScreenLaunch.storyboardc/01J-lp-oVM-view-Ze5-6b-2t3.nib
      obj/iPhone/Release/ibtool-link/ScreenLaunch.storyboardc/UIViewController-01J-lp-oVM.nib
      obj/iPhone/Release/ibtool-link/ScreenLaunch.storyboardc/Info.plist
      obj/iPhone/Release/ibtool-link/LaunchScreen.storyboardc/01J-lp-oVM-view-Ze5-6b-2t3.nib
      obj/iPhone/Release/ibtool-link/LaunchScreen.storyboardc/UIViewController-01J-lp-oVM.nib
      obj/iPhone/Release/ibtool-link/LaunchScreen.storyboardc/Info.plist
    OutputManifests Output:
      obj/iPhone/Release/ibtool-manifests/LaunchScreen.storyboardc
      obj/iPhone/Release/ibtool-manifests/ScreenLaunch.storyboardc
      obj/iPhone/Release/ibtool-manifests/link
_BeforeCoreCompileSceneKitAssets:
Skipping target "_BeforeCoreCompileSceneKitAssets" because it has no inputs.
_BeforeCoreCompileSceneKitAssets:
Skipping target "_BeforeCoreCompileSceneKitAssets" because it has no inputs.
_BeforeCoreCompileSceneKitAssets:
Skipping target "_BeforeCoreCompileSceneKitAssets" because it has no inputs.
_CoreCompileSceneKitAssets:
Skipping target "_CoreCompileSceneKitAssets" because it has no inputs.
_CoreCompileColladaAssets:
Skipping target "_CoreCompileColladaAssets" because it has no inputs.
_BeforeCompileTextureAtlases:
Skipping target "_BeforeCompileTextureAtlases" because it has no inputs.
_BeforeCompileTextureAtlases:
Skipping target "_BeforeCompileTextureAtlases" because it has no inputs.
_BeforeCompileTextureAtlases:
Skipping target "_BeforeCompileTextureAtlases" because it has no inputs.
_CoreCompileTextureAtlases:
Skipping target "_CoreCompileTextureAtlases" because it has no inputs.

@ederbond That change is being tracked here: https://github.com/actions/virtual-environments/issues/4180
FYI, XCode 13 is available on the agents today. If you ever wanted to manually ensure your builds are using a given version of XCode, you could run this command prior to building (this has some Azure DevOps specifics in it, but you get the idea):
echo '##vso[task.setvariable variable=MD_APPLE_SDK_ROOT;]'/Applications/Xcode_13.0.app;sudo xcode-select --switch /Applications/Xcode_13.0.app/Contents/Developer

@svaldetero yes, Xamarin.iOS 15 was set as default and the image is currently being rolled out, that's why the Readme is not yet merged https://github.com/actions/virtual-environments/pull/4224
I'm afraid we can't fix it before the next week, so please either pin to Xcode 13 explicitly or lower Xamarin iOS version. Sorry for the inconvenience.


Port number should come from config

🚀 Feature Request
Description
Port numbers are hard coded and passed to the client as an argument. They should all be listed in the configuration.
Describe the solution you'd like
Declare the port numbers in cmd/root.go with Viper.

duplicate of #16


[Q] Reparse form without using watch:true MutationObserver

The docs show how to validate dynamically-modified forms with a MutationObserver via v.bootstrap({ watch: true }).
But that is a little heavy when I know exactly when and how new items are added to the form.
I want to replace jquery-validate where that is done by reparsing the form. Just out of interest, it's done like this:
$(form).removeData("validator").removeData("unobtrusiveValidation");
$.validator.unobtrusive.parse(form);

I'm sure this library already has this built-in, but it doesn't seem to be documented.
Does someone know how to do this?
Thanks!

If this has unintended consequences, please let me know? ...e.g. will it track existing fields twice?

It shouldn't. Please let us know if you find that it does. 😁


checkJs error for indirect JSDoc param tag

TypeScript Version: 2.6.0-dev.20171015
// @ts-check

function Foo() {
    /**
     * @param {string} wat
     */
    this.bar = function(wat) {

    }
}

Expected: No error
Actual: JSDoc '@param' tag has name 'wat', but there is no parameter with that name.

Probably due to #18777.

Any chance this will be fixed in TS 2.6? This is a big blocker for us upgrading to 2.6, as we use JSDoc in many places.
As a workaround, I'm using @ts-ignore.

Yeah, it's certainly #18777 -- the type is correct, it just issues a spurious error.

Fix is up at #19355

@sandersn Thanks for getting this fixed so quickly!

Hey!
I ran into a similar issue but from the other perspective. Using a destructuring assignment on the function argument, I got the following error:
/**
 * @param {Object} args
 * @param {string} args.prop1
 * @param {string} args.prop2
 */
function patate({ prop1, prop2 }) {

}

// JSDoc '@param' tag has name 'args', but there is no parameter with that name.

The problem is the same using an enum syntax:

```js
/**
 * @param {{prop1: string, prop2: string}} args
 */
function patate({ prop1, prop2 }) {

}

Wouldn't it make sense not to raise this error in this case, but still be able to annotate the properties with the right types ?

@KtorZ this is tracked by https://github.com/Microsoft/TypeScript/issues/7429

Sweet, thanks :+1:


fix(kook): fail to launch and to receive message

Codecov Report

Merging #12 (1ab7d25) into master (79b1de3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   80.42%   80.42%
=======================================
  Files           7        7
  Lines         654      654
  Branches       54       54
=======================================
  Hits          526      526
  Misses        128      128

Help us with your feedback. Take ten seconds to tell us how you rate us.


#50 add test for support notifications client

Signed-off-by: yanghua<EMAIL_ADDRESS>hi @drasko and @feclare , I add a test for support notification client because I find this call :
https://github.com/edgexfoundry/edgex-go/blob/master/support/notifications-client/client.go#L91
will not trigger a real remote request if it run in a new goroutine.
Please review this test, I will try to refactor the notification client and this test code. Thanks!

hi @tsconn23 , if you have time, would you please merge this PR? Because, I will refactor the notification client and use this test case to verify the function. Thanks!


docs: refine solidity-docgen into gitbook

Feature Request
Describe the Feature Request
Definition of done:

[ ] Refine the Solidity-Docgen with the latest updates from Swaplace.
[ ] Create an account to implement the gitbook

Related Code
solidity-docgen

closed by #233


Fix forced writing of Duktape/C function .length

Duktape/C function .length is a "virtual" property so it's not an own property but also not inherited. The current handling prevents a DUK_DEFPROP_FORCE write to establish a .length own property for a Duktape/C function.
Nicest solution would be for Function.prototype.length to be an inherited accessor which could have special handling for Duktape/C functions, to provide a useful .length based on nargs count. However, that would violate the ES2015 property setup so the property needs to be virtual.

[ ] Add testcase coverage
[ ] Fix for virtual property writing, should allow one to establish a property in general even if a virtual property conflicts
[ ] Releases entry
[ ] Backports

The particular case for function .length might become moot with #1493 but other cases remain valid.

In general defineProperty() might just allow establishing a concrete property if no concrete property exists but a virtual one does, and DUK_DEFPROP_FORCE is set. This doesn't always make sense though, e.g. Array .length is always virtual and if a concrete property is created it will actually not have effect.
So maybe cleanest solution would be to add one more internal attribute flag for virtual properties, to indicate whether it's allowed to write over the virtual property or not.

Nicest solution would be for Function.prototype.length to be an inherited accessor which could have special handling for Duktape/C functions, to provide a useful .length based on nargs count. However, that would violate the ES2015 property setup so the property needs to be virtual.

Out of curiosity, why is this the case?  Is it because...
> Object.getOwnPropertyDescriptor(Function.prototype, 'length')
{ value: 0,
  writable: false,
  enumerable: false,
  configurable: true }
>

...Function.prototype.length must be a data property == 0 and not an accessor?

Hmm, if you mean why .length must be a virtual property:
Duktape/C functions don't have a concrete .length because of memory concerns: the property would use a lot of RAM for low memory targets (for 100 functions, 8x100 = 800 bytes). The .length value is also almost always the same as the nargs count so there's rarely a need to actually change it. The best compromise IMO would be for the property to be virtual but behave like an own property so you could overwrite it.
The easiest solution would to make the property a concrete one, but that has RAM concerns. The second easiest would be for Function.prototype.length to be an accessor which can come up with a useful value for Duktape/C functions automatically. But that's not allowed by ES because the property is described as a data property, unlike e.g. the new RegExp.prototype.xxx properties which are accessors.
I could also make a concrete .length the default and use a virtual one for low memory targets. But I'd like to avoid that if possible, because even for non-low-memory targets minimizing memory usage is still useful.
Not sure if I covered your question here though :)

Function.prototype.length to be an accessor which can come up with a useful value for Duktape/C functions automatically. But that's not allowed by ES because the property is described as a data property

Right, this is exactly the answer I was looking for. :)
To be clear, I knew why there were no length own properties, I was just trying to figure out why the inherited accessor solution wasn't feasible.  I suspected it might be a spec issue, just wanted to verify.

Another solution could be to have Duktape/C functions inherit from a special NativeFunction class instead of Function directly, but that's a bit overkill just to get an inherited .length. ;-)

Hmm, that sounds pretty good actually because it would remove the need for virtual properties (which are an "internal" feature with no Ecmascript visibility). Lightfuncs could also inherit from NativeFunction and get their virtual properties from there.
The only downsides I can think of is slightly slower method lookups (but function methods are not usually looked up in hot paths) and some additional built-in objects. The NativeFunction prototype wouldn't need to have a global name so it wouldn't cause global object changes either (this would be similar to %TypedArrayPrototype%).

It would be important to ensure that only user-provided functions inherit from NativeFunction and not e.g. builtins, since otherwise that would surely not be standards compliant :)

That's true. It's a bit odd but the built-ins have explicit .length properties so the inheritance won't matter.

This is handled by #1515, so closing as unmerged.


How to include babel-polyfill

I'm trying to use redux-box project and created a new basic react-static project. Redux-box indicates including babel-polyfill if getting errors and I'm getting a regenerate runtime error which seems to be related to needing babel-polyfill. I don't understand all the parts, but it seems you can include babel-polyfill in weback so I modified static.config.js as follows:
import 'babel-polyfill'
export default {
    ...
    webpack: previousConfig => {
        const newConfig = Object.assign({}, previousConfig)
        newConfig.entry = ['babel-polyfill', previousConfig.entry]
        return newConfig
    },
}

However, I'm not sure if it's related but I get this error when running yarn build now
=> Exporting HTML...
{ Invariant Violation: React.Children.only expected to receive a single React element child.
    at invariant (/Users/michael/Code/sandbox/redux-box/node_modules/fbjs/lib/invariant.js:42:15)
    at Object.onlyChild [as only] (/Users/michael/Code/sandbox/redux-box/node_modules/react/cjs/react.development.js:975:31)
    at Provider.render (/Users/michael/Code/sandbox/redux-box/node_modules/react-redux/lib/components/Provider.js:63:30)
    at resolve (/Users/michael/Code/sandbox/redux-box/node_modules/react-dom/cjs/react-dom-server.node.development.js:2149:18)
    at ReactDOMServerRenderer.render (/Users/michael/Code/sandbox/redux-box/node_modules/react-dom/cjs/react-dom-server.node.development.js:2260:22)
    at ReactDOMServerRenderer.read (/Users/michael/Code/sandbox/redux-box/node_modules/react-dom/cjs/react-dom-server.node.development.js:2234:19)
    at renderToString (/Users/michael/Code/sandbox/redux-box/node_modules/react-dom/cjs/react-dom-server.node.development.js:2501:25)
    at renderToStringAndExtract (/Users/michael/Code/sandbox/redux-box/node_modules/react-static/lib/static/index.js:524:68)
    at Object.renderToHtml (/Users/michael/Code/sandbox/redux-box/node_modules/react-static/lib/static/getConfig.js:151:14)
    at _callee5$ (/Users/michael/Code/sandbox/redux-box/node_modules/react-static/lib/static/index.js:562:39) name: 'Invariant Violation', framesToPop:1 }
error An unexpected error occurred: "Command failed.
Exit code: 1
Command: sh
Arguments: -c react-static build
Directory: /Users/michael/Code/sandbox/redux-box
Output:
".

Are you using preact?

Also, make sure that <Router> only has one children.

Oh yeah I guess I did select preact. I didn't mean to introduce that variable already though. You think that's the issue?

Could be a bug with the preact option.
On Tue, Mar 13, 2018 at 4:10 PM Michael Bender<EMAIL_ADDRESS>wrote:

Oh yeah I guess I did select preact. I didn't mean to introduce that
variable already though. You think that's the issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/471#issuecomment-372836118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCQSSL6qvsCEhshIS6GVIWmX67iagks5teEPUgaJpZM4So-GE
.

Looks like its a minor problem with the preact option. This will be fixed in the next release.