Sign-NavContainerApp fails with SSL/TLS error in Sign-tool download

PLEASE DO NOT INCLUDE ANY PASSWORDS OR TOKENS IN YOUR ISSUE!!!
Describe the issue
Trying to sign our extensions on a freshly created container fails with an SSL/TLS error on download of Sign-Tools
Scripts used to create container and cause the issue
Container Creation:
$artifactUrl = Get-BCArtifactUrl -type OnPrem -version "<IP_ADDRESS>" -select Closest -country "w1"

$licenseFile = "<Path to license file>"
$ContainerName = 'runtime'
$UserName = 'user'
$Password = ConvertTo-SecureString 'password' -AsPlainText -Force
$Credential = New-Object System.Management.Automation.PSCredential ($UserName,$Password)

New-NavContainer `
     -accept_eula `
    -accept_outdated `
    -containerName $ContainerName `
    -artifactUrl $artifactURL `
    -licenseFile $licenseFile `
    -auth NavUserPassword `
    -Credential $Credential `
    -useBestContainerOS `
    -doNotExportObjectsToText `
    -assignPremiumPlan `

Signing call:
Sign-NavContainerApp -containerName runtime -appFile $file.FullName -pfxFile $cert -pfxPassword $certPassword -Verbose

Full output of scripts
Container Creation:
Default parameter UpdateHosts = True
Default parameter Isolation = Process
Default parameter Multitenant = False
BcContainerHelper is version 3.0.3
BcContainerHelper is running as administrator
Host is Microsoft Windows Server 2016 Standard - ltsc2016
Docker Client Version is 20.10.9
Docker Server Version is 20.10.9
Removing container runtime
Removing runtime from container hosts file
Removing runtime-* from container hosts file
Removing C:\ProgramData\BcContainerHelper\Extensions\runtime
Fetching all docker images
Fetching all docker volumes
Using image mcr.microsoft.com/businesscentral:10.0.14393.3384
Creating Container runtime
Style: onprem
Multitenant: No
Version: 19.0.29894.30693
Platform: 19.0.29884.30666
Generic Tag: <IP_ADDRESS>
Container OS Version: 10.0.14393.3384 (ltsc2016)
Host OS Version: 10.0.14393.3384 (ltsc2016)
Using Process isolation
Using locale en-US
Disabling the standard eventlog dump to container log every 2 seconds (use -dumpEventLog to enable)
Using license file C:\Export\NET.flf
Files in C:\ProgramData\BcContainerHelper\Extensions\runtime\my:
- AdditionalOutput.ps1
- license.flf
- MainLoop.ps1
- SetupNavUsers.ps1
- SetupVariables.ps1
- updatehosts.ps1
Creating container runtime from image mcr.microsoft.com/businesscentral:10.0.14393.3384
0ec8d3a354b89d540da913ba7e0850b7851f9e01359091b2495660cac0e74ea2
Waiting for container runtime to be ready
Using artifactUrl https://bcartifacts.azureedge.net/onprem/19.0.29894.30693/w1
Using installer from C:\Run\150-new
Installing Business Central
Installing from artifacts
Starting Local SQL Server
Starting Internet Information Server
Copying Service Tier Files
c:\dl\onprem\19.0.29894.30693\platform\ServiceTier\Program Files
c:\dl\onprem\19.0.29894.30693\platform\ServiceTier\System64Folder
Copying PowerShell Scripts
c:\dl\onprem\19.0.29894.30693\platform\WindowsPowerShellScripts\Cloud\NAVAdministration
c:\dl\onprem\19.0.29894.30693\platform\WindowsPowerShellScripts\WebSearch
Copying dependencies
Copying ReportBuilder
Importing PowerShell Modules
Determining Database Collation from c:\dl\onprem\19.0.29894.30693\w1\database\Demo Database BC (19-0).bak
Restoring CRONUS Demo Database
Setting CompatibilityLevel for CRONUS on localhost\SQLEXPRESS
Modifying Business Central Service Tier Config File for Docker
Creating Business Central Service Tier
Installing SIP crypto provider: 'C:\Windows\System32\NavSip.dll'
Copying Web Client Files
c:\dl\onprem\19.0.29894.30693\platform\WebClient\Microsoft Dynamics NAV
Copying Client Files
c:\dl\onprem\19.0.29894.30693\platform\LegacyDlls\program files\Microsoft Dynamics NAV
c:\dl\onprem\19.0.29894.30693\platform\LegacyDlls\program files\Microsoft Dynamics NAV
c:\dl\onprem\19.0.29894.30693\platform\LegacyDlls\systemFolder
Copying ModernDev Files
c:\dl\onprem\19.0.29894.30693\platform
c:\dl\onprem\19.0.29894.30693\platform\ModernDev\program files\Microsoft Dynamics NAV
Copying additional files
Copying ConfigurationPackages
C:\dl\onprem\19.0.29894.30693\platform\ConfigurationPackages
Copying Test Assemblies
C:\dl\onprem\19.0.29894.30693\platform\Test Assemblies
Copying Applications
C:\dl\onprem\19.0.29894.30693\platform\Applications
Starting Business Central Service Tier
Importing license file
Stopping Business Central Service Tier
Installation took 127 seconds
Installation complete
Initializing...
Setting host.containerhelper.internal to <IP_ADDRESS> in container hosts file
Starting Container
Hostname is runtime
PublicDnsName is runtime
Using NavUserPassword Authentication
Creating Self Signed Certificate
Self Signed Certificate Thumbprint 89108195FFED54F1D73B12F4B6735C92B964F21D
DNS identity runtime
Modifying Service Tier Config File with Instance Specific Settings
Starting Service Tier
Registering event sources
Creating DotNetCore Web Server Instance
Using license file 'c:\run\my\license.flf'
Import License
Creating http download site
Setting SA Password and enabling SA
Creating admin as SQL User and add to sysadmin
Creating SUPER user
Assign Premium plan for ADMIN
Container IP Address: <IP_ADDRESS>
Container Hostname  : runtime
Container Dns Name  : runtime
Web Client          : http://runtime/BC/
Dev. Server         : http://runtime
Dev. ServerInstance : BC
Setting runtime to <IP_ADDRESS> in host hosts file

Files:
http://runtime:8080/ALLanguage.vsix

WARNING: You are running a container which is 499 days old.
Microsoft recommends that you always run the latest version of our containers.

Container Total Physical Memory is 6.0Gb
Container Free Physical Memory is 2.6Gb

Initialization took 31 seconds
Ready for connections!
Reading CustomSettings.config from runtime
Creating Desktop Shortcuts for runtime
Container runtime successfully created

Afterwards signing the extension:

Copying certificate file to container
Downloading Signing Tools
Exception calling "DownloadFile" with "2" argument(s): "The request was aborted: Could not create SSL/TLS secure channel."
at <ScriptBlock>, <No file>: line 24
at Invoke-ScriptInBcContainer, C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\3.0.3\ContainerHandling\Invoke-ScriptInNavContainer.ps1: line 43
at Sign-BcContainerApp, C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\3.0.3\AppHandling\Sign-NavContainerApp.ps1: line 86
at <ScriptBlock>, C:\Users\vmAdmin\Desktop\Skripte für Docker VM\Release BC 19 VJS.ps1: line 49
Sign-NavContainerApp Telemetry Correlation Id: b787d0e9-dee0-45a9-941c-0ff1beaaed03
Exception calling "DownloadFile" with "2" argument(s): "The request was aborted: Could not create SSL/TLS secure channel."
At C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\3.0.3\ContainerHandling\Invoke-ScriptInNavContainer.ps1:44 char:13
+             throw $_.Exception.Message
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Exception calli...ecure channel.":String) [], RuntimeException
    + FullyQualifiedErrorId : Exception calling "DownloadFile" with "2" argument(s): "The request was aborted: Could not create SSL/TLS secure channel."

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context

This started happening today (05/04/22). Yesterday (04/04/22) everything worked as expected. No updates done to the BCContainerhelper and the same certificate and script were used.
We also ran [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 before execution of the script to force TLS connections with no change in error message.
We currently have a workaround by manually installing the sign-tools into the container.

We ran into this error as well. I suspect the ltsc2016 images from Microsoft will fall back on Tls10 but to download the signing tools, now TLS 1.2 is expected.
Our work-around was to add the following to our scripts right before Sign-BcContainerApp is invoked:
Invoke-ScriptInNavContainer -containerName $containerName -scriptblock {
    Write-Host "Setting security protocol to Tls12"
    [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12;
}

I think the docker images should be updated to default to Tls12.

Hello,
Faced the same issue yesterday and for to solve it temporary and urgently as workarround I modified code of installed BcContainerHelper module function script Sign-NavContainerApp.ps1 to add Tls12:
Invoke-ScriptInBcContainer -containerName $containerName -ScriptBlock { Param($appFile, $pfxFile, $pfxPassword, $timeStampServer, $digestAlgorithm)
    [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls -bor [Net.SecurityProtocolType]::Tls11 -bor [Net.SecurityProtocolType]::Tls12
    Write-Host "$([Net.ServicePointManager]::SecurityProtocol)"
...

Yes, MS disabled tls1.0 support on the servers and if you are using Windows 2016 for the containers, they have no TLS enabled by default. I have used this to enable it during container creation:
-myScripts @(@{"AdditionalSetup.ps1"={
  New-Item 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Server' -Force | Out-Null
  New-ItemProperty -path 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Server' -name 'Enabled' -value '1' -PropertyType 'DWord' -Force | Out-Null
  New-ItemProperty -path 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Server' -name 'DisabledByDefault' -value 0 -PropertyType 'DWord' -Force | Out-Null
  New-Item 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client' -Force | Out-Null
  New-ItemProperty -path 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client' -name 'Enabled' -value '1' -PropertyType 'DWord' -Force | Out-Null
  New-ItemProperty -path 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client' -name 'DisabledByDefault' -value 0 -PropertyType 'DWord' -Force | Out-Null
  New-ItemProperty -path 'HKLM:\SOFTWARE\Microsoft\.NetFramework\v4.0.30319' -name 'SchUseStrongCrypto' -value '1' -PropertyType 'DWord' -Force | Out-Null
  New-ItemProperty -path 'HKLM:\SOFTWARE\Microsoft\.NetFramework\v4.0.30319' -name 'SystemDefaultTlsVersions' -value '1' -PropertyType 'DWord' -Force | Out-Null
  New-ItemProperty -path 'HKLM:\SOFTWARE\Microsoft\.NetFramework\v2.0.50727' -name 'SchUseStrongCrypto' -value '1' -PropertyType 'DWord' -Force | Out-Null
  New-ItemProperty -path 'HKLM:\SOFTWARE\Microsoft\.NetFramework\v2.0.50727' -name 'SystemDefaultTlsVersions' -value '1' -PropertyType 'DWord' -Force | Out-Null
  $TLS12Protocol = [System.Net.SecurityProtocolType] 'Ssl3 , Tls12'
  [System.Net.ServicePointManager]::SecurityProtocol = $TLS12Protocol
  Write-Host "Tls12 Enabled"
}})

You can use something similar, e.g. invoke-scriptinbccontainer after creation. It should enable the TLS by default for the current and any next session in the container.

Thanks for sharing - will consider adding this workaround to containerhelper

@kine - I cannot see why all of these statements are needed? What Windows Server 2016 build are you running?
I have tried generic image with Windows Server 2016 build 10.0.14393.3384 (from the original bug) - on this one, it is sufficient to use
[Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12

when creating the session.
On build 10.0.14393.4946 - same thing
On the oldest available build 10.0.14393.2906 - same thing
I will add the line above to Get-BcContainerSession.

Included in latest prerelease

That's great news! Thank you @freddydk for your quick reaction.

Shipped in 3.0.5

@kine - I cannot see why all of these statements are needed? What Windows Server 2016 build are you running?
I have tried generic image with Windows Server 2016 build 10.0.14393.3384 (from the original bug) - on this one, it is sufficient to use
[Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12

when creating the session. On build 10.0.14393.4946 - same thing On the oldest available build 10.0.14393.2906 - same thing
Will close this issue with the checkin done two days ago.

It is solving different things for different apps. It is just collection of "hacks" which helped to solve TLS things in different cases. Sorry for that. It grew itself during the time... :-) was not sure which one is the correct for this specific case.

I know what you mean - I am sure that I also have workarounds in place in various places which is no longer necessary
It is just scary to remove them, not knowing whether you will break 1000s of pipelines tomorrow...


Update compute_el_header_block_hash for EIP-7685

Reference: https://eips.ethereum.org/EIPS/eip-7685
This PR does the following:

Consolidate deposit_receipts and withdrawal_requests into requests.
When encoding those two types, prefix with type (0x00 and 0x01).
Encode with non-null parent_beacon_root.

A null parent_beacon_root causes issues when requests_root is not null.
I believe this field was accidentally overlooked before.

Set payload.withdrawal_requests = [] in  build_empty_execution_payload.

I noticed these issues when looking into why the block hash differed from Geth.

@lightclient I would appreciate your review but I can't select you as a reviewer.

consider renaming these methods to reflect their actual semantics.

Ah yes, you're right. Thanks for pointing this out! I took this approach.

Note: if #3757 gets merged, we should rename it in this PR too.

@jtraglia I fixed the conflicts and added lines for ConsolidationRequest. Could you take a look?

@hwwhww So get_withdrawal_request_rlp_bytes and get_consolidation_request_rlp_bytes are both prefixed with 0x01 now, these should be different. And get_deposit_request_rlp_bytes doesn't have a prefix byte anymore.

@jtraglia you're right! I forget to update the prefix when copy-pasting.


models should be able to have variables that are not in constraints

created during init by self.varkeys.add(W) etc?

similarly for cost

see also https://github.com/hoburg/gpkit-models/pull/17


Failed to install via Homebrew

Is there some trouble-shooting magic I need to perform?  What to do if homebrew installation fails?
$ brew install hugo
Error: No available formula for hugo

I'm a Linux user, so no idea.
But in general, http://discuss.gohugo.io is a better place for questions.

I don't see any problem with hugo formula for hugo.
@fireproofsocks what do you get for brew info hugo? Have you tried updating brew?
$ brew info hugo
hugo: stable 0.12 (bottled), HEAD
http://hugo.spf13.com/
Not installed
From: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/hugo.rb
==> Dependencies
Build: go ✔, bazaar ✔

If this still is an issue, post at http://discuss.gohugo.io i

@fireproofsocks: Remember to run brew update before running brew install hugo.  ;-)


Doesn't work for me

I opened index.html and clicked start server but nothing happened. I opened up the browser to localhost, localhost:8080 bbut no webserver running.

Sorry about this! I've moved from Atom to VS Code, so I'm no longer using/maintaining this package.


GHA report "Error: No space left on device" for velox backend testing

Describe the bug
GHA report "Error: No space left on device" when running velox backend testing during PR submission.
To Reproduce
When submitting a PR and running velox backend, it would happen occasionally.
Expected behavior
Expect to run pass velox backend testing without any error message.

Because temp directories /tmp/spark_columnar_plugin* not clean, use crontab to clean this dir, fixed


trouble shooting woman generations?

hey thanks for this! I've fine-tuned a model on the man class and things worked fine. but I am trying a woman and the raw images and samples come out identical no matter what I do.
are there any other steps to trouble shoot this? I can confirm the files are named as:
root@C.5408015:/workspace/Dreambooth-Ion-Cannon$ tree training_samples/

training_samples/
└── woman
    ├── emma woman_001.png
    ├── emma woman_002.png
    ├── emma woman_003.png
    ├── emma woman_004.png
    ├── emma woman_005.png
    ├── emma woman_006.png
    ├── emma woman_007.png

and the notebook vars are initialized as:
target_name = "emma"
target_class = "woman"

not sure how else I could mess it up :)
any other hints where to look? I created a clean new vast instance and have done this twice now with identical results.
the raw gallery image comes out as the attached, both times (even though I'm using more training images now)
any other suggestions appreciated!

I can confirm I get absolutely identical images on a second run on a clean new instance. so it seems somehow the training class is being ignored. the target_name "emma" is in the file names tho:

Oh it's a GPU out of mem error.
also noticed i uploaded a .DS_Store mac file by accident...
I wonder if you have guidelines on how many images could be uploaded generally?
eg how many / big files?
seems to be a problem for the Tesla instances, even the a 10x Tesla seems capped at 16GB of VRAM:

RuntimeError: CUDA out of memory. Tried to allocate 20.00 MiB (GPU 0; 15.78 GiB total capacity; 14.49 GiB already allocated; 15.69 MiB free; 14.63 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

got it thanks! i overlooked that in the README. might be worth having some code to do a startup check at the beginning and fatal if there's for sure not enough vram.


upgrade moment to ^2.25.3

What does this pull request aim to achieve? 💯
fix https://github.com/moment/moment/issues/5484# by upgrade to moment ^2.25.3 (installs 2.26.0).
Resolves #450

ok going to merge this asap so the master builds for everyone


report when rootless

when running as rootless, report as such.
resolves: #1509
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

@rh-atomic-bot r+


Availability of Az.Resources should be validated

Describe the bug
At the beginning I did not have Az:Resources installed.
As a result I got
Finished deploying object: [IntegrationRuntime].[ir-shir-onprem]
New-AzResource : InputIsMalformedDetailed : Input is malformed. Reason: Could not get integration runtime details for ir-shir-onprem
CorrelationId: e4943009-7a4b-4673-b034-750a8e533318
In \\mnzfs100\Users-Ext$\xmoell46\WindowsPowerShell\Modules\azure.datafactory.tools\1.5.0\private\Deploy-AdfObjectOnly.ps1:134 Zeichen:13
+             New-AzResource `
+             ~~~~~~~~~~~~~~~~
    + CategoryInfo          : CloseError: (:) [New-AzResource], ErrorResponseMessageException
    + FullyQualifiedErrorId : Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.NewAzureResourceCmdlet

many times.
To Reproduce
Your script to reproduce the behaviour:
Publish-AdfV2FromJson -RootFolder "." -ResourceGroupName "rg-gamdwh-prod-001" -DataFactoryName "df-gamdwh-ingest-prod" -Location "West Europe"

Expected behaviour
An error message appears that I should install Az.Resources
Screenshots
If applicable, add screenshots to help explain your problem.
Version of PowerShell module of:
PS C:\df-gamdwh-ingest-fm> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14393.5582
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.5582
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

PS C:\df-gamdwh-ingest-fm> Get-Module Azure.datafactory.tools

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     1.5.0      azure.datafactory.tools             {Export-AdfToArmTemplate, Get-AdfDocDiagram, Get-AdfFromService, Import-AdfFromFolder...}

Provide all files to reproduce the issue

Attach at least log file (you can wipe out any potentially sensitive info)
Attach files of objects which are involved in the process

https://stackoverflow.com/questions/46216038/how-do-i-define-requiredmodules-in-a-powershell-module-manifest-psd1


Fix for issue 9 : update create_operator_group to false to avoid creating unecessary operatorgroups

Signed-off-by: Snehal Pansare<EMAIL_ADDRESS>

closing it due to conflict


Migrations-1223 - Improve Documentation

Description
This PR enhances the current documentation/readme files in the repo.
Issues Resolved
Migrations-1223
Check List

[ ] New functionality includes testing

[ ] All tests pass, including unit test, integration test and doctest

[X] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Maybe I'm missing it but I don't see documentation on "running the tools." I would add information about the OpenSearch benchmark container, provide an example run, and reference the OpenSearch benchmark documentation.
Documenting how data flows from OpenSearch benchmarks to the replayer would be ideal. Keep in mind that the replayer responses are going to be stored in persistent storage. I would reference this but leave further documentation about the Comparator out.
Can you open another task specifically for documenting how to analyze output? Also another task for cleanup if it doesn't exist?

@sumobrian, What I had in mind around "running the tools" was the already existing documentation on how to stand up the Docker Solution and/or the current AWS Deployment. But documentation around the OpenSearch benchmark is still needed and is a great idea! Thanks for pointing that out! I'll address that.
Created the linked tasks below:

Cleanup: https://opensearch.atlassian.net/browse/MIGRATIONS-1270
Analyze Output: https://opensearch.atlassian.net/browse/MIGRATIONS-1271


ML 8.13 : YOLO (D)

Description
📌  Issues for Week 8
Welcome to 'ML' Team, good to see you here
:arrow_forward: This issue will helps readers in acquiring all the knowledge that one needs to know about ----
You Only Look Once
:red_circle: To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
✔ Domain : Machine Learning
:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the `Machine Learning/Machine_Learning/ML_for_Sequential_Data_&_Visual Data' Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

:white_check_mark: To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Documentation

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎
Domain
Machine Learning
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Yugal Agarwal
Batch - 1
https://github.com/Yugal41735
Documentation

Please assign this issue to me.
Name: Vansh Sharma
Domain: ML Batch 3
Github link: https://github.com/vanshhhhh

Name: Mann Shah
Batch: ML Batch 3
GitHub: https://github.com/Mann-tech13
Documentation

Please assign this issue to me.
Name: Vidhi Bhatt
Domain: ML Batch 3
Serial no: 490
Github link: https://github.com/VidhiBhatt01
Documentation

Name: Priyal Palkhiwala
Batch: 5
Profile link: https://github.com/priyall
Contribution type: Documentation
I would like to contribute to this issue.

Please assign this issue to me.
Name: Ruchika
Domain: ML Batch 3
Documentation

Yugal Agarwal Batch - 1 https://github.com/Yugal41735 Documentation

Already assigned

@vanshhhhh @Mann-tech13 @VidhiBhatt01 you already been assigned issues?

@vanshhhhh @Mann-tech13 @VidhiBhatt01 you already been assigned issues?

No issues have been assigned from this week.

Sorry @raina-akshay I am unassigning this issue. I checked and got another issue. You can give this issue to some other contributor.

@raina-akshay please assign me this. I haven't contributed much

@VidhiBhatt01 one issue at a time, please make the PR for previous assigned issue first.

I m sorry @VidhiBhatt01 but Rule is Rule.
Why didn't you give the time to it previously.
I would like to suggest you to create the PR for assigned issue ASAP, then grab the other issue.

@Isha307 Please check your LinkedIn DM.

I have completed previously assigned issue. Please assign me this. @abhisheks008 @Isha307

issue assigned to you @VidhiBhatt01


@azure/communication-identity Core2 Migration

Packages impacted by this PR

@azure/communication-identity

Issues associated with this PR

#15814

Describe the problem that is addressed by this PR

https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-rest-pipeline/documentation/core2.md

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-rest-pipeline/documentation/core2.md

Are there test cases added in this PR?

No new test cases, the existing ones suffice

Provide a list of related PRs (if any)

#20337

Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[x] Does this PR needs any fixes in the SDK Generator? NO
[x] Added a changelog (if necessary)

Notes

Based on  #20337 (contains changes done there)

API changes have been detected in @azure/communication-common. You can review API changes here
API changes
+ export declare function createCommunicationAuthenticationPolicy(credential: KeyCredential | TokenCredential): PipelinePolicy;
+ export declare function createCommunicationKeyCredentialPolicy(credential: KeyCredential): PipelinePolicy;

API changes have been detected in @azure/communication-identity. You can review API changes here
API changes
- export interface CommunicationIdentityClientOptions extends PipelineOptions { }
+ export interface CommunicationIdentityClientOptions extends CommonClientOptions { }

@sarangan12 Can you please help here?

@sarangan12 a related PR suffers from the same issue: https://github.com/Azure/azure-sdk-for-js/pull/19043

@petrsvihlik I have started looking into this issue. Let me start debugging this and update this issue soon.

@petrsvihlik I have looked into the code base. Here are some of the observations. (Please correct me if I am wrong).

You are trying to move the package @azure/communication-identity from core V1 to core V2.
But the @azure/communication-identity is dependent on @azure/communication-common package.
In your PR, you have removed the dependency of @azure/core-http in communication-identity package. But, the underlying base package of communication-common is still relying on @azure/core-http.
Also, I am specifically seeing this dependency being used in the browser specific tests in the communication-identity package which might be the root cause of this PR failure.

Could you please resolve the dependency issues with communications-common package and migrate it before communications-identity? Please let me know. Thanks

Thank you for your suggestions @sarangan12!
Just so you know, we have another PR open for the migration of the communication-common library - https://github.com/Azure/azure-sdk-for-js/pull/20337. And we used that PR as a starting point for this PR. This PR serves for verifying that the changes we make in the communication-common will work fine in the dependent libraries.
Now to your observations:

In your PR, you have removed the dependency of @azure/core-http in communication-identity package. But, the underlying base package of communication-common is still relying on @azure/core-http.

Yes, we wanted to keep the backward compatibility and include both versions of the policy (V1 & V2) but it seems it's not needed in this case according to the architects

Could you please resolve the dependency issues with communications-common package and migrate it before communications-identity? Please let me know. Thanks

Yes, I'll update the other PR and remove the dependency on @azure/core-http.
Thanks again!

@sarangan12 There should be no dependency on @azure/core-http by now but the pipeline is still failing. Do you have any more ideas? Or who should I contact to help me resolve the issue?

@xirzec @maorleger @jeremymeng @deyaaeldeen @joheredi
Hi, do any of you folks have any idea what could be going on wrong in this pipeline?
    × successfully creates a user and token
      Chrome Headless 93.0.4577.0 (Windows 10)
    RestError: Error sending request: Failed to fetch
        at getError (../../core/core-rest-pipeline/src/fetchHttpClient.ts:174:7 <- dist-test/index.browser.js:4123:20)
        at FetchHttpClient.sendRequest (../../core/core-rest-pipeline/src/fetchHttpClient.ts:59:4 <- dist-test/index.browser.js:4020:23)
        at async Object.sendRequest (../../core/core-rest-pipeline/src/policies/redirectPolicy.ts:41:6 <- dist-test/index.browser.js:1053:34)
        at async Object.sendRequest (../../core/core-rest-pipeline/src/policies/retryPolicy.ts:60:10 <- dist-test/index.browser.js:3749:36)
        at async Object.sendRequest (../../core/core-client/src/deserializationPolicy.ts:98:6 <- dist-test/index.browser.js:7051:34)
        at async IdentityRestClient.sendOperationRequest (../../core/core-client/src/serviceClient.ts:199:18 <- dist-test/index.browser.js:7793:37)
        at async CommunicationIdentityClient.createUserAndToken (src/communicationIdentityClient.ts:199:6 <- dist-test/index.browser.js:8517:51)
        at async Context.<anonymous> (test/public/communicationIdentityClient.spec.ts:45:30 <- dist-test/index.browser.js:77477:50)

Or is there a way to get more detailed exception from the pipeline?
It's happening only in the browser pipeline:

This PR is a follow-up PR to https://github.com/Azure/azure-sdk-for-js/pull/20337. I use it to verify whether we'll be able to successfully migrate the libraries dependent on @azure/communication-common.

@petrsvihlik this may be related to our recent change in core-rest-pipeline to switch to another http client for browser.  The old browser playback test recordings are captured using XHR based http client.  If this is the case you can fix it by passing an xhr client to the test client similarly to what's being done in PR #20201
https://github.com/Azure/azure-sdk-for-js/pull/20201/files#diff-c4968f06636c5ed6ef23ef092c892e25341dcb609c79c6137fff9a93aba4e5b4R98

API changes have been detected in @azure/communication-common. You can review API changes here
API changes
- createCommunicationAccessKeyCredentialPolicy: (credential: KeyCredential) => RequestPolicyFactory
- createCommunicationAuthPolicy: (credential: KeyCredential | TokenCredential) => RequestPolicyFactory
+ export declare function createCommunicationAccessKeyCredentialPolicy(credential: KeyCredential): PipelinePolicy;
+ export declare function createCommunicationAuthPolicy(credential: KeyCredential | TokenCredential): PipelinePolicy;

note to self:

[ ] revert sdk/communication/communication-common/CHANGELOG.md

@joheredi thanks, there really was an issue: https://github.com/Azure/azure-sdk-tools/pull/2895. should be fixed now: https://github.com/Azure/azure-sdk-for-js/pull/20749/files
I'll merge main and try again.

@jeremymeng @joheredi hi, could some of you please take a quick look and confirm that the changes are ok? thank you!

/check-enforcer reset

/azp run js - communication - ci


Added new checks for reverse.map, reverse.iterator and reverse.take.reverse

Added 3 new reverse-related checks (ideas from https://pavelfatin.com/scala-collections-tips-and-tricks/):

reverse.map can be replaced with reverseMap
reverse.iterator can be replaced with reverseIterator
reverse.take(n).reverse can be replaced with takeRight(n)

In addition, checks have been added for arrays, not only collections.

Awesome


DeleteRequest should target object instance only.

And for DiscoverRequest, there's nothing different with current behavior but just fixed it for patterns of DownlinkRequest classes.
Signed-off-by: Rokwoon Kim<EMAIL_ADDRESS>

I integrated your PR in master (commit a7c958ab2dcad79db763e2d1fb9632604bcb30fe)
I fixed a test which didn't passed anymore with this fix but I ask myself if I should not just delete it...
Anyway thx again @rkimsb2 :+1:


Unable to use a local .dzi file as tileSource since Firefox 35.0.1

A test HTML file (pasted below) with a single viewer with tileSources set to a local .dzi file used to display the tiles when rendered with Firefox <=  Firefox 34 but, in Firefox 35.0.1 or 36.0b7, displays the following message instead: "Unable to open [object Object]: HTTP 200 attempting to load TileSource". This happens with OpenSeadragon 1.1.1 as well as with 1.2.1.
Does anybody observe the same? Is it due to a bug in Firefox ? A bug in OpenSeadragon ?
Thanks!

<!DOCTYPE html>

    <title>OpenSeadragon Basic Demo</title>

        Simple demo page to show a default OpenSeadragon viewer.

I noticed that as well.
Apparently, Firefox now returns the status 200 for file:// instead of 0.
Ha even found the related release note: https://developer.mozilla.org/en-US/Firefox/Releases/35/Site_Compatibility
So this line https://github.com/openseadragon/openseadragon/blob/master/src/openseadragon.js#L1947 needs to be changed.
From what I remember, Chrome was blocking this kind of requests but IE was working, so some testing needs to be done.

Fixed by #597


Updated readme to avoid Nginx error

Leaving that lines uncommented make Nginx try to fetch Let's Encrypt certificates, which will make the container fail as it does not have access to open ports.
Commenting them fixes the problem.

How come you have to do this on your container but not on mine? Where is your container from?

I followed the Discourse installation guide I got the container from:
git clone https://github.com/discourse/discourse_docker.git /var/discourse
I can't be sure, but I imagine that changes on the installation script since you installed could cause this.


Use v1.7.2 as default Kubernetes version

This is an ask from @sauryadas and the ACS RP team.
TBD:

default version for ACS (managed)?
default version for acs-engine only?

n/a


chore: bdd-nh-1587996782 to 0.0.1

chore: Promote bdd-nh-1587996782 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Error with code

ADD ISSUE DESCRIPTION HERE
Every time I attempt to check my code with the companion I get a message saying "No changes detected in the programming file." Even though I know my query is absolutely correct, companion won't even recognize it as an attempt.
Version: 1.85.2
Commit: 8b3775030ed1a69b13e4f4c628c612102e30a681
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

/causedByExtension please use the course support channel.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


Optional parameters in query are not really optional

Hi!
I encountered this issue while describing my endpoints, and it can be demonstrated with the flowers api example.
Setting up the example from the wiki:
// ...
export const flowerAPI = defineAPI({
    listFlowers: GET `/flowers`
        .query({
            'sortBy': FlowerIndexedAttribute,
            'filterBy': FlowerIndexedAttribute
        })
        .response(rt.Array(Flower))
/ /...
});

// if you create a client
import axios from 'axios';
const driver = axios.create(config);
const flowers = createConsumer(flowerAPI, driver);

// and when you try to call it with the supposedly optional query params:
flowers.listFlowers({
  query: {
    sortBy: 'color'
    // filterBy: 'color' // without this parameter it will not pass typecheck
  }
});

As you can see, in the example, I'm calling the created API endpoint with an optional query param (I would like to think all query params are optional by default as stated here: https://github.com/hmil/rest.ts/blob/master/packages/rest-ts-core/src/builder-kit.ts#L136) it fails.
The error comes from the type calculations made on the inferred incoming type in defineAPI will see every Runtype defined type requirements as present, non-undefined, so none of them can be left out ultimately. (I hope this makes sense).
For now I don't know what would be a good solution, but I feel that if we actually want to allow ALL query params as optional (as they usually should be in RESTful design)  then maybe the type calculations shouldn't be removing undefineable fields, but rather making the whole query type Partial.
My workaround, btw with the current code is this:
const identity: <T>(o: T) => T = o => o;
const partial: <T extends object>(o: T) => Partial<T> = identity;
const optional: <T>(o: T) => T | undefined = identity;

export const flowerAPI = defineAPI({
    listFlowers: GET `/flowers`
        .query(partial({
            'sortBy': FlowerIndexedAttribute,
            'filterBy': FlowerIndexedAttribute
        }))
        .response(rt.Array(Flower))
/ /...
});

What do you think? Is this a legit concern?

Good find. Yes this is legit.
Actually this is pretty bad because in the server all parameters are typed as string and not string | undefined, but the route will match regardless of whether the parameter was provided or not... So potential for crash right here.
The prototype of query should be changed to something like this:
public query<U extends QueryParams>(query: U): EndpointBuilder<RemoveKey<T, 'query'> & { query: Partial<ExtractRuntimeType<U>> }>

This is a breaking change.

Just a comment - I agree that in RESTful design it's usually good practice to have all query params as optional but there are some legit cases where you want query params to be mandatory, so I think the framework should allow for that too.
So there should be either a flag to mark properties as mandatory, or a flag to mark them as optional or use some Partial runtimes wrapper.

It's also a legit solution, to update the docs, and javadocs, and let the authors make stuff optional with some util function.

Maybe there should be a runtime type check for request query parameters, similar to the one available for request body with runtypes.
The thing is: query params are user input (as seen by the server). We can make rest.ts enforce mandatory query params on the client, but the server might still receive bad data.


removed code duplicate in BaseDataset and WindowsDataset

always great to remove code duplication :+1:

thx @gemeinl !


Is it possible to write a map?

Which part is this question about
I have been struggling to make RecordBatch objects with what I believe are maps. I cannot seem to create the right icantation to write a record which includes a map.
Describe your question
I have tried variables of MapBuilder and hand-crafting MapArrays but today I broke down and just tried to write a record with a JSON decoded object to parquet, for example:
    let json = r#"{"ds" : "1", "timestamp" : 1, "status" : 200, "url" : "https://",
    "method" : "GET", "response" : "", "headers" : {"this" : "is a map"}}"#;
    use arrow::json::reader::{Decoder, DecoderOptions};
    use arrow::datatypes::Schema as ArrowSchema;
    // don't mind this, this is just some Delta Lake schema translation
    let schema: ArrowSchema = <ArrowSchema as TryFrom<&Schema>>::try_from(&HttpRecord::schema()).unwrap();
    let schema_ref = Arc::new(schema);
    let value: serde_json::Value = serde_json::from_str(json).unwrap();

    let vit = vec![value];
    let mut vit = vit.iter().map(|v| Ok(v.to_owned()));

    let options = DecoderOptions::new();
    let d = Decoder::new(schema_ref, options);
    let batch = d.next_batch(&mut vit).unwrap();

The batch then looks like:
RecordBatch { schema: Schema { fields: [Field { name: "ds", data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false,[32/742]
a: {} }, Field { name: "timestamp", data_type: Timestamp(Microsecond, None), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} },
Field { name: "status", data_type: Int32, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field { name: "url", data_type: Utf
8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field { name: "method", data_type: Utf8, nullable: false, dict_id: 0, dict
_is_ordered: false, metadata: {} }, Field { name: "response", data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }
, Field { name: "headers", data_type: Map(Field { name: "key_value", data_type: Struct([Field { name: "key", data_type: Utf8, nullable: false, dic
t_id: 0, dict_is_ordered: false, metadata: {} }, Field { name: "value", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metad
ata: {} }]), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }, false), nullable: true, dict_id: 0, dict_is_ordered: false, meta
data: {} }], metadata: {} }, columns: [StringArray
[
  "1",
], PrimitiveArray<Timestamp(Microsecond, None)>
[
  1970-01-01T00:00:00.000001,
], PrimitiveArray<Int32>
[
  200,
], StringArray
[
  "https://",
], StringArray
[
  "GET",
], StringArray
[
  "",
], MapArray
[
  StructArray
[
-- child 0: "key" (Utf8)
StringArray
[
  "this",
]
-- child 1: "value" (Utf8)
StringArray
]], row_count: 1 }

Which when I attempt to write using RecordBatchWriter results in a panic:
thread 'model::tests::zip_batches' panicked at 'not implemented: Take not supported for data type Map(Field { name: "key_value", data_type: Struct
([Field { name: "key", data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field { name: "value", data_type: Utf
8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }]), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }, fals
e)', /home/tyler/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-select-33.0.0/src/t
ake.rs:234:14

I would appreciate any examples whether using JSON or raw constructed RecordBatch objects to get records with maps written properly to parquet :frowning:
Additional context
This is with arrow 33 for what it's worth.

I would appreciate any examples

There is an example using MapArrayBuilder - https://github.com/apache/arrow-rs/blob/master/parquet/src/arrow/array_reader/map_array.rs#L146
And an example using the JSON reader - https://github.com/apache/arrow-rs/blob/master/arrow-json/src/raw/mod.rs#L607
The documentation could definitely be improved for handling this particular type

Take not supported for data type

This looks like a failure in model::tests::zip_batches, that is calling the take kernel which doesn't currently support MapArray, not anything to do with parsing the MapArray itself.

@tustvold thank you for the suggestions.  Investigating the take is a good suggestion, there's something fishy between my code, delta-rs, and arrow I'm following up on now

@tustvold as I am getting deeper into this problem, I'm curious if there's a reason why take() isn't implemented for MapArray? In the context of a RecordBatch it seems to me to be a reasonable thing to use to take rows out of the batch :confused:

No reason that I'm aware of, MapArray support simply hasn't been added to many of the kernels


Separating the seed for testing vs. non-testing code

The current code has a lot of Random.seed!(42) in front of MANY cells in the notebooks.
I imagine that the reason for this is that the tests where randomness is provided are otherwise impossible to run out of sequence?  Having a single one at the top is fine, but it looks ugly to have so many.
If there is no way around resetting things before every test section, then I think we should move those seeds to test-blocks (maybe on their own) right before their current locations.  Then things will be deterministic for testing purposes, but the code won't be cluttered for readers.

@XiaojunGuan, if I recall, you're out of tasks to complete on this project? If you could take a stab at this, that would be great (this is basically test manipulation).
The idea is that we want to make sure that tests are runnable out of sequence (that is, in any order that compiles). This is tricky because the tests depend sometimes on random objects. What we've done is to sprinkle Random.seed!(42)s everywhere at the start of cells (which resets the seed before running that particular cell). But, as Jesse points out, this is an ugly and distracting solution.
I don't think we'll have time before the release on c. Nov. 5 to refactor the whole tests. So, what we should do is the solution above (move the random seeds to test blocks, which contain only the one command) right before their current locations). That way, as @jlperla pointed out, we can keep the current tests/values for development, but get rid of the noise for end users.

Okay, I will try to get it done by tomorrow.

Thanks so much.

@arnavs Finished. Please see PR #238.

Closed by #238


please add a api call to list all provisioned instances

Hi Christian,
please add a api call to list all provisioned instances
e.g.
GET /instances
regards Stefan

Fixed with 0.1.0!

Helle Christian,
thanks for implementing,
I am currently travelling; I will test this end of June.
best regards Stefan
From: Christian Giese @.>
Reply to: rtbrick/bngblaster-controller @.>
Date: Monday, 3. June 2024 at 21:50
To: rtbrick/bngblaster-controller @.>
Cc: Stefan Lieberth @.>, Author @.***>
Subject: Re: [rtbrick/bngblaster-controller] please add a api call to list all provisioned instances (Issue #7)
Fixed with 0.1.0!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Migrate to newer electron

Electron v18 has been out of support for quite some time now. Please consider updating to a newer version.
Here is a list of the current electron versions.
Why is this an issue?
Quite a lot of linux distributions don't package outdated electron versions as they could be insecure. This not only makes it impossible for packagers to add GMEdit to the official repositories but it also makes it inconvinient for users that want to compile from source.
On nix the prebuild version doesnt work (because of nix linker shenanigans, don't worry abt it I didn't expect it to work).
When I tried the app-only build it would've worked if I could have used a newer electron version.

If you have time and enthusiasm, you can try updating the dependency and seeing whether everything/anything still works - from experience I already know that the "breaking changes" page doesn't actually list every breaking change (let alone bugs that have been introduced since then), so the cost of updating Electron is largely unpredictable.

Sorry I don't think I'll be able to do that. Never worked with anything electron or js related. I wouldn't even know how to update the dependency...
If I find some free time on the weekend I might look into it but I'm more or less certain I can't pull this off by myself.

I just figured out how to build it with electron 18 so this isn't really necessary for me anymore (we could still leave this open tho if you're planning to migrate to a non-EOL electron version)

K I did some research
Electron 24 (which is also EOL) still works fine. Just the following warning:
electron .
TypeError: app.setUserTasks is not a function
    at Object.<anonymous> (/home/notyou/Downloads/foragerModding/gmedit/main.js:227:7)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1296:10)
    at Module.load (node:internal/modules/cjs/loader:1096:32)
    at Module._load (node:internal/modules/cjs/loader:937:12)
    at f._load (node:electron/js2c/asar_bundle:2:13377)
    at loadApplicationPackage (/nix/store/i9qxr0n0bkj5ihdmq10w2fk17pv5v16k-electron-24.8.6/libexec/electron/resources/default_app.asar/main.js:121:16)
    at Object.<anonymous> (/nix/store/i9qxr0n0bkj5ihdmq10w2fk17pv5v16k-electron-24.8.6/libexec/electron/resources/default_app.asar/main.js:233:9)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1296:10)
DRM kernel driver 'nvidia-drm' in use. NVK requires nouveau.
[69717:0607/000027.140730:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
[69717:0607/000027.144175:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times!

You can ignore DRM kernel driver 'nvidia-drm' in use. NVK requires nouveau.. That's linux related and I also get that in chrome. The first one is a bit weird but not version related because I also get it with electron 18.
[69717:0607/000027.140730:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 3 times!

This is the relevant one. No clue what it means tho.
When using >24 The editor doesn't load:

Note that that is not my color theme so it crashed before it selected a theme. Nothing important in the logs searching for the error sounds like a nightmare ngl.

Just the following warning:

That's slightly more than a warning, a (yet another) function has been removed from the "render process" (where the UI is) in the name of security (?).
Effectively GMEdit doesn't become any more or less secure from all these changes as the only thing that GMEdit accesses on the internet is a JSON file with function definitions for auto-completion.

When using >24 The editor doesn't load:
You'd want to uncomment the

wnd.webContents.openDevTools()

call in main.js, JS console is slightly less noisy. It's most likely more functions being removed though.

#228 closes this :)


Why no spread operator support?

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator.

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.


chore: better error message when salesforce API is unavailable

can you re-do this diff on top of your other PR branch? looks like this includes those bigquery changes

can you re-base this diff on top of your other PR branch? looks like this includes those bigquery changes

Done


Add funrar

Insert URLs to the project here: https://github.com/Rekyt/funrar

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All projects listed will be posted on our Mastodon channel

@Rekyt


feat: handle duplicate vm backup and snapshot

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
VM Backup and Snapshot use same CRD, but they're in different pages, so users may wonder why some names can't work.
Solution:
Give a better error message to point out VM Backup and Snapshot can't have same name.

Related Issue:
https://github.com/harvester/harvester/issues/5855
Test plan:

Create a VM Backup with name test.
Create a VM Snapshot with name test. Webhook should return an error message about VM Backup and Snapshot use same CRD.

@mergifyio backport v1.3


Long SQL text and external data

I have a long SQL request (>16000 characters) which uses external data and I get a "400 bad request" response from server.
I see that the SQL text is put in URI in this case and that it is related to this problem:
(ClickHouseStatementImpl)

            // write sql in query params when there is external data
            // as it is impossible to pass both external data and sql in body
            // TODO move sql to request body when it is supported in clickhouse
            uri = buildRequestUri(
                    sql,
                    externalData,
                    additionalClickHouseDBParams,
                    additionalRequestParams,
                    ignoreDatabase
            );

Is there any progress regarding this issue? Is there a workaround?

Yes, it should be put into request body. This is same issue as #607.
Unfortunately I currently don't have a workaround for this. Let me fix this in these two days.

I can reproduce the issue but moving query to request body didn't work when external data is used. Perhaps you can load external data into a temporary table and then issue a query without external data?

I found a way to reduce the size of my query so it is not a problem anymore.
I was using temporary tables before but external data are really more comfortable: no need to create a session, create a table, insert data.
My initial question was more about this comment:
// write sql in query params when there is external data
// as it is impossible to pass both external data and sql in body
// TODO move sql to request body when it is supported in clickhouse

it implies that there is a limitation in Clickhouse HTTP protocol. Do you know if it is still relevant or if someone is working on it?
alternatively, if you tell me that gRPC will be used in a few months, there is no need to fix this.
Thanks.

Sorry I was wrong. The limitation seems no longer exist. The fix has been merged into develop branch.
Also I'm curious about usage of external data. I agree that it's more convenient compare to temp table, but where is the data from? If it's dumped from another database, why not use JDBC bridge or so to issue a distributed query? We used to have offline data in flat files but now most of them are imported into database tables.


feat: return when recording permission is denied

Hi @yutasuzuki
There isn't really a convention, I've seen snake_case, UPPER_SNAKE_CASE and pascalCase being used. What would be a bit cleaner is using an object instead of plain strings, e.g.
const RecordingResult = {
  Started = 'started',
  PermissionError = 'permission_error'
} as const;

type RecordingResult = typeof RecordingResult[keyof typeof RecordingResult];

const res: RecordingResult = await RecordScreen.startRecording();

if (res === RecordingResult.PermissionError) {
  // user denies access
}

This would not break the current API as the started value is still the same.

@robrechtme
That's great!
I'd be happy to Pull request that code!

Hi @yutasuzuki
I updated the code to do that 🙂


Unable to authenticate to private ECR repository with source controller (no aws-autologin-for-ecr flag)

The image reflector controller contains "aws-autologin-for-ecr" flag for logging into ECR.  I cannot find a similar flag for the source controller.  However, we are using ECR to store private helm charts.
Should it have a similar flag?

When declaring a helmRepository pointing to your repository in ecr, you can set a provider field to aws to enable autologin. See https://fluxcd.io/flux/components/source/helmrepositories/#provider

Thanks for the pointer.  We will try that out.


Custom Relationship Enhancements

Proposed Functionality
Custom relationships, depending on the relation type, might either create a url-redirect inside a view either to a list of relations, either to the related object.
This is misleading in some cases, where numbers are used as the object names (ie. vlan name, or the circuit name).
For those cases, it would be useful to distinguish for those two different situations.
Object Redirect :

List View Redirect :

Thanks for the report! Would just adding some words to the list case, making it something like:
IPs         2 related records

be an adequate fix here?

Sounds good to me


Custom elements v1 article

R: @arthurevans @jpmedley cc @petele
Article has had a technical review. PR also adds a nice "talking head" card to the site:

Looks good, will merge. did a publish today, will do one again tomorrow morning ET.

Might want to wait for @jpmedley or @arthurevans . I don't know if they've had time to look at it yet.

Er - OK, merged already... I'll publish tomorrow, if there are copy edits we can push those as they come in...

Sorry Eric, I meant to get to this last week, been buried. Will take a look tomorrow.


Add a copy console logs button

Make it easy to copy logs to the clipboard with a copy output button

Would this copy:

A single line
The selection
The entire log

Entire log


quiche: enable more quic tests

Commit Message: remove or comment on EXCLUDE_DOWNSTREAM_HTTP3 in various integration tests
Risk Level: low
Testing: existing integration tests
Part of #12930

/retest

coverage failure was an unrelated flake - kicking off another run


How can i use go build -mod without default vendor

What version of Go are you using (go version)?

$ go version
go version go1.18rc1 darwin/arm64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="arm64"
GOBIN="/usr/local/go/bin"
GOCACHE="/Users/wang/Library/Caches/go-build"
GOENV="/Users/wang/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/wang/go/pkg/mod"
GONOPROXY="gitlab.hexcloud.cn"
GONOSUMDB="gitlab.hexcloud.cn"
GOOS="darwin"
GOPATH="/Users/wang/go"
GOPRIVATE="gitlab.hexcloud.cn"
GOPROXY="https://goproxy.io,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18rc1"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/wang/go_project/test/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/fc/5_f38pyn6k915kw7_vvfjhrc0000gn/T/go-build2956473923=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.18rc1 darwin/arm64
GOROOT/bin/go tool compile -V: compile version go1.18rc1
uname -v: Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:20 PDT 2021; root:xnu-7195.141.6~3/RELEASE_ARM64_T8101
ProductName:	macOS
ProductVersion:	11.6
BuildVersion:	20G165
lldb --version: lldb-13<IP_ADDRESS>
Swift version 5.5-dev

What did you do?

run go mod vendor -o vendoring on bash
run go build -mod=vendor -o main main.go

What did you expect to see?
No error
What did you see instead?
go: inconsistent vendoring in /Users/x/test:
<EMAIL_ADDRESS>is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
<EMAIL_ADDRESS>is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
<EMAIL_ADDRESS>is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor

Drop the -o vendoring flag from your go mod vendor command.  (-mod=vendor only works with a vendor directory with that exact name.)


Add guidance for making a PR fixes toolstate

This is a follow-up PR of #446.
r? @spastorino

git add -u gets the change staged if something is changed or removed.


fix: handle missing pydantic-core corner case

This change handles a corner case where pydantic is installed in the environment but pydantic-core is missing. The current code assumes that if pydantic is importable, then pydantic is available, but the access of pydantic.BaseModel does a lazy import of pydantic-core which is not handled, crashing the application that is using cappa.
To handle the issue, BaseModel is imported eagerly during the detection step, which will throw an error when pydantic-core is not available.
I have observed this in the wild, where I am not using pydantic with cappa at all, nor it is one of my direct dependencies, but it is still being pulled transitively from other sources, crashing my application. This issue surfaced with https://github.com/DanCardin/cappa/releases/tag/v0.19.0.

I'm happy to accept this change, as I see no harm it in.
But besides that, I wonder if you're befallen by something like https://github.com/python-poetry/poetry/issues/9266. If you have pydantic you should have pydantic_core. I recently found myself hitting related-sounding issues where the lock wasn't installing required transitive dependencies (including pydantic_core).


Fibonnaci Series

Fibonnaci Series using Recursion

Please star this repository to show your support, in the meantime I am reviewing your code.


Fixed typo

@tisnik Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-api-gateway:SNAPSHOT-PR-24


Update azureml-pipeline version to 1.57.0

Issue
With current version(1.53.0) of azureml-pipeline, trigger a dry run of demand forecasting in the machine learning portal, we are seeing below errors, (same if we run from FnO)

Fix
update azureml-pipeline to 1.57.0, tested with both dry run and from FnO

@andreygarmash will create another PR for updating the rest

@andreygarmash finished testing, upgrade all to version 1.57.0 works


Performance improvements and neuron_parallel_compile and gradient checkpointing fixes

What does this PR do?

Fixes neuron_parallel_compile which fails as soon as it sees a character in the log that it cannot decode. Related issue: https://github.com/aws-neuron/aws-neuron-sdk/issues/886
Fixes gradient checkpointing. But a lot that can be skipped for now and deferred to another PR is marked as "TODO".
Changes the xm.mark_step() position in the training loop. Before it was after the optimizer.step() which is not ideal at all because it will produce more graphs than the current proposed solution. The proposed solution, on top of making more sense, is also more aligned with what the Neuron compiler expects, providing good speed-up in compilation time.
Loss log and model saving are now step closures. The benefit of doing that compared to what was done before is that these functions will be executed sequentially at the next xm.mark_step() (so the next batch being fetched). While it could trigger compilation (and thus more graphs) before, now it will wait for the actual tensors to be materialized (via the xm.mark_step() to be run, avoiding the creations of new graphs.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Is this a transient error ?
tests/distributed/test_model_parallelization.py::TestModelParallelization::test_parallel_model_matches_original_model_from_pretrained_with_parallel_embeddings_and_sequence_parallel[LlamaForQuestionAnswering-dp=4,tp=pp=2] - torch.fx.proxy.TraceError: symbolically traced variables cannot be used as inputs to control flow

@dacorvo no it's broken. I have added that to "CLASSES_TO_IGNORE" in the tests, let me check why it runs it...

Filtered now!

I trust you on this, because it is a bit hard to decipher without grasping the whole context of // training.

But the explanations in the description are really clear: it is just that it is hard to follow how it is translated in the code.


Runtime URIDecoder fails when parsing strings containing commas

Commit hash: f0589f6
Context:
URIDecoder fails with error DecodingError: typeMismatch String - at : Cannot parse a value from a node with multiple values. (underlying error: <nil>) when trying to parse a value that contains a comma (e.g. no-cache, private in a header response).
I traced this back to URIParser which is splitting elements by commas.
Steps to reproduce:

Attempt to decode a header response containing a comma as part of a request
Request fails with DecodingError.typeMismatch

$ swift --version
Apple Swift version 5.8.1 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>.100)
Target: arm64-apple-macosx13.0
Operating system: MacOS 13.4.1

Ah yes, can you confirm what the style and explode values are for the header, if specified?

simple and explode I think. Was part of decoding a header response.

Was explode true or false? The default is false for simple (https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#fixed-fields-10), was it enabled manually?

Oh yes it was false!

Ok. The reason this is happening is because the value isn't percent-encoded, which is required by https://datatracker.ietf.org/doc/html/rfc6570#section-3.2.2, which is how OpenAPI serializes simple values: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#style-values
However, this is a common mistake servers make (or documenters of the APIs), so I'm leaning towards the runtime library correctly encoding values (with percent-encoding), but being a little more flexible while decoding values.
A way to introduce this flexibility might be as simple as making URISingleValueDecodingContainer concatenate values again with a comma and return that. I'll have to play with that next week. This logic is getting improved further with https://github.com/apple/swift-openapi-runtime/pull/50, which just landed, but I don't think it contains any changes that'd fix this case.
Here's a speculative fix, can you try if it helps, please? https://github.com/apple/swift-openapi-runtime/pull/51

Changing the label as the runtime library is doing the correct thing according to RFC6570, I believe. Marking as enhancement instead, as it'd still be nice to be a bit more flexible on the input side.

Yeah that fix works, though I had to convert the array.joined into a substring to get it to compile:
let string = array.joined(separator: ",")
return Substring(stringLiteral: string)

I may be getting the wrong idea here, but shouldn't headers be treated differently to other encoded parameters? My(limited) understanding is that headers are always colon-delimited, as per RFC822 e.g.:
Content-Type: application/json
Content-Length: 1428

I'm not sure these should be handled in exactly the same way that we're handling URL form encoding? Apologies if I've misunderstood what's happening here!

You're right that the header line is colon-delimited, the colon is not meant to be percent-escaped, that only applies to the header value, aka the stuff on the right of the colon.
Most headers that support multiple values simply concatenate them using a comma. For example, let's say we have a header called Greeting-Options that provides an array of greetings for the server to choose from.
For the values Hello world! and Hi, the on-the-wire representation should look like this:
Greeting-Options: Hello%20world%21, Hi

And the OpenAPI documentation should look like:
name: Greeting-Options
in: header
schema:
  type: array
  items:
    type: string

From your originating example, I infer you're using the Cache-Control header, but it seems to be documented as:
type: string

instead of:
type: array
items:
  type: string

Basically, the generated code is being told it's a single value, not an array, but the simple unexploded format uses commas to separate individual values.
So you have two options here:

Continue to treat the header value as a single string, but then the server must return no-cache%2C%20private instead of no-cache, private.
Change the definition of the header in the OpenAPI document to be an array of strings, instead of a single string. Then you'll get the two values separated by a comma parsed correctly.

I'd probably recommend (2), but wanted to explain both options here.

Ok thanks, that makes sense. I think this is probably actually an issue with my Openapi document then 😅
FWIW the document I'm using was converted from Postman docs. I guess it's a bug or oversight either with the converter I was using, or with the way Postman exports collections.
That said, I guess if this is a common use case and there is an easy fix, it would make the runtime more robust to handle admittedly badly-formed open api specs.

I suspect most tools are just too permissive, making folks unaware of not being spec-compliant.
But in this case, I agree that making things a bit more permissive is probably justified here. Would you be interested in contributing this fix? My PR was just to show the diff, will need tests etc.

yeah sure - can take a look this afternoon hopefully!

Already landed in https://github.com/apple/swift-openapi-runtime/pull/52


Default File Explorer

What feature or improvement do you think would benefit Files?
Is there an option to make Files the default file explorer so when clicking links they open with files?
Requirements
It will make it easier to not switch between files and file explorer
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.4651
Comments
No response

It's in Files settings > Advance > Set as default


I got error below, maybe the voxeet maven repository is down
* What went wrong:
Execution failed for task ':app:checkDebugAarMetadata'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not resolve com.facebook.react:react-native:+.
     Required by:
         project :app
         project :app > project :notifee_react-native
         project :app > project :react-native-community_datetimepicker
         project :app > project :react-native-community_masked-view
         project :app > project :react-native-firebase_analytics
         project :app > project :react-native-firebase_app
         project :app > project :react-native-firebase_crashlytics
         project :app > project :react-native-firebase_messaging
         project :app > project :react-native-firebase_remote-config
         project :app > project :react-native-picker_picker
         project :app > project :sentry_react-native
         project :app > project :appcenter
         project :app > project :appcenter-analytics
         project :app > project :appcenter-crashes
         project :app > project :lottie-react-native
         project :app > project :react-native-auth0
         project :app > project :react-native-bootsplash
         project :app > project :react-native-code-push
         project :app > project :react-native-exception-handler
         project :app > project :react-native-gesture-handler
         project :app > project :react-native-keep-awake
         project :app > project :react-native-localize
         project :app > project :react-native-mmkv-storage
         project :app > project :react-native-pager-view
         project :app > project :react-native-permissions
         project :app > project :react-native-safe-area-context
         project :app > project :react-native-screens
         project :app > project :react-native-sensitive-info
         project :app > project :react-native-svg
         project :app > project :react-native-track-player
         project :app > project :react-native-view-pdf
         project :app > project :react-native-zohosalesiq-mobilisten
         project :app > project :react-native-flipper
      > Failed to list versions for com.facebook.react:react-native.
         > Unable to load Maven meta-data from https://dl.bintray.com/voxeet/maven/com/facebook/react/react-native/maven-metadata.xml.
            > Could not get resource 'https://dl.bintray.com/voxeet/maven/com/facebook/react/react-native/maven-metadata.xml'.
               > Could not GET 'https://dl.bintray.com/voxeet/maven/com/facebook/react/react-native/maven-metadata.xml'. Received status code 502 from server: Bad Gateway

You need to remove the outdated dl.bintray.com line from the dependencies. (It will be removed from the readme as well)

it works now, thanks so much


P100 oct 2022 build

Updated the build instructions for the new parts.  We should also make sure we have a clear distribution made in the print files directory.

closes #79


initialize() got an unexpected keyword argument 'bytes_mode'

I recently set-up an Apache server to serve my Django project. After doing so, I receive errors while accessing the views which use ldapdb. Everything works fine when running the server with the runserver-command.
Any clues as to why I'm receiving this?
Here's my error-log:
Environment:
Request Method: GET
Request URL: http://<IP_ADDRESS>/api/v1/budgetbase/
Django Version: 1.10.6
Python Version: 2.7.5
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.messages',
'django.contrib.staticfiles',
'rest_framework',
'hardware_budget_handler',
'ldap_handler',
'signature_handler',
'time_handler',
'ldapdb',
'djangosecure',
'rest_framework_swagger',
'webpack_loader',
'intranet']
Installed Middleware:
['django.middleware.security.SecurityMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware']
Traceback:
File "/usr/lib/python2.7/site-packages/django/core/handlers/exception.py" in inner
42.             response = get_response(request)
File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
187.                 response = self.process_exception_by_middleware(e, request)
File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python2.7/site-packages/django/views/decorators/csrf.py" in wrapped_view
58.         return view_func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/django/views/generic/base.py" in view
68.             return self.dispatch(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/rest_framework/views.py" in dispatch
483.             response = self.handle_exception(exc)
File "/usr/lib/python2.7/site-packages/rest_framework/views.py" in handle_exception
443.             self.raise_uncaught_exception(exc)
File "/usr/lib/python2.7/site-packages/rest_framework/views.py" in dispatch
480.             response = handler(request, *args, **kwargs)
File "/root/spintra2/app/hardware_budget_handler/views.py" in get
38.             request.user.username)
File "/root/spintra2/app/ldap_handler/utils.py" in fetch_user_by_account_name
19.         user = LdapUser.objects.get(account_name=account_name)
File "/usr/lib/python2.7/site-packages/django/db/models/manager.py" in manager_method
85.                 return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/django/db/models/query.py" in get
379.         num = len(clone)
File "/usr/lib/python2.7/site-packages/django/db/models/query.py" in len
238.         self._fetch_all()
File "/usr/lib/python2.7/site-packages/django/db/models/query.py" in _fetch_all
1087.             self._result_cache = list(self.iterator())
File "/usr/lib/python2.7/site-packages/django/db/models/query.py" in iter
54.         results = compiler.execute_sql()
File "/root/spintra2/app/ldapdb/backends/ldap/compiler.py" in execute_sql
137.             vals = list(vals)
File "/root/spintra2/app/ldapdb/backends/ldap/base.py" in search_s
279.         cursor = self._cursor()
File "/root/spintra2/app/ldapdb/backends/ldap/base.py" in _cursor
253.         self.ensure_connection()
File "/usr/lib/python2.7/site-packages/django/db/backends/base/base.py" in ensure_connection
199.                 self.connect()
File "/usr/lib/python2.7/site-packages/django/db/backends/base/base.py" in connect
171.         self.connection = self.get_new_connection(conn_params)
File "/root/spintra2/app/ldapdb/backends/ldap/base.py" in get_new_connection
225.         connection = ldap.initialize(conn_params['uri'], bytes_mode=False)
Exception Type: TypeError at /api/v1/budgetbase/
Exception Value: initialize() got an unexpected keyword argument 'bytes_mode'

You've installed python-ldap instead of pyldap.
django-ldapdb relies on the pyldap fork of python-ldap, whose goal is mainly to add Python3 support — which you'll require anyway starting from Django 2.0 (which should be released in 8 months).
You should be able to fix this by running:
pip uninstall python-ldap
pip uninstall pyldap
pip install pyldap

Let me know if this fixes your issue!

Thank you for your fast answer.
It seemed I had used python-ldap in the early development stages, switched to pyldap and forgotten about python-ldap but it remained in requirements.txt.
This fixed the issue, thank you very much!


Mega Menu: Accessibility - Issue related to Search edit combo list box

Detailed description
On iPhone Voice over
URL - https://ibmdotcom-react-canary.mybluemix.net/
Issue :
After entering the search term visually the options are appearing but screen reader users are not able to navigate through the options within the combo box
Expected :- the user should be able to navigate through the options using left and right swipe and make the selection.
Additional information

@Praveen-sr
I've tested it in my phone using talk back, and I was able to navigate through the list by swiping slowly up and down, after getting to the list-box.
This behavior is set by an external library that we use for the suggestions, that is accessibility compliant, as we can check here (https://github.com/moroshko/react-autosuggest).
Do we need to override their up and down selection for side swapping?
CC: @jeffchew @annawen1

@jeffchew Changed the severity to SEv 3 based on Raph's response.  Do we still need in v1.10.0?

Moving to icebox because a technical solution is not available at this time.  Search would have to be completely reworked / designed in order to find a solution.

Will be moving away from support of Pure React components.  Closing this epic and all linked issues.


Example for MST

Description

What does this PR do?

This is a script to test the operation of MST

Sign async from Polkadot https://github.com/polkadot-js/api/blob/e77050b9f59a0b772d1d0b8c5c1da488a7c36810/packages/api/src/submittable/createClass.ts#L72
isKeyringPair from Polkadot https://github.com/polkadot-js/api/blob/e77050b9f59a0b772d1d0b8c5c1da488a7c36810/packages/api/src/util/isKeyringPair.ts


Add e2e test for Datadog features timeWindowOffset and lastAvailablePointOffset

Proposal
Add e2e test coverage for Datadog features timeWindowOffset and lastAvailablePointOffset
Use-Case
No response
Anything else?
No response

hi @dogzzdogzz ,
Are you willing to contribute it?

Can but quite busy recently, will revisit this issue when I am available.


Add an exclusion for other folders in the TEI repo

@adrianplau has asked us to add exclusions for other directories in the TEI repo; files we shouldn't transform and present in the front-end.
This is a small change to the TEI ID extractor; we already exclude files from the "Templates" directory: https://github.com/wellcomecollection/catalogue-pipeline/blob/e650e334d9735ae3b62ecddaf9e6efb16a35e89c/tei_adapter/tei_id_extractor/src/main/scala/weco/catalogue/tei/id_extractor/TeiIdExtractorWorkerService.scala#L108-L114
We're waiting for him to give us the list of folders.

Thanks for this, Alex! The folder is this one: https://github.com/wellcomecollection/wellcome-collection-tei/tree/main/Arabic/Fihrist
By the way, I assume the docs folder also is excluded?

Done.


When installing a custom font in the system, the cursor moves right

Bug description

When installing a custom font with an understated width (in my case Ubuntu Normal), in the ConnectBot terminal, the cursor begins to shift to the right, and this offset increases with each printed character.
Steps to reproduce

Go to smartphone Settings
Setup custom font
Open ConnectBot and connect to SSH server
See a problem

Screenshots

Android device

Device: Tecno POVA 4 pro
OS: Android 12
ConnectBot Version: 1.9.9 F-Droid
Font: Ubuntu Normal

The shift happens here even with Standard font.
Device: Samsung Galaxy S22
OS: Android 13
Font: Standard

Сдвиг здесь происходит даже со стандартным шрифтом. Очень сложно найти правильное место при попытке исправить опечатку...
Устройство: Samsung Galaxy S22 Версия ConnectBot: 1.99-oss (F-Droid) ОС: Андроид 13 Шрифт: стандартный

Hmm... Well, I have no problems with the standard font, either on my main phone or on my previous one (Samsung Galaxy A30s, Android 11).

The shift happens here even with Standard font. Makes it reeeeaaaally hard to find the right spot when trying to fix a typo...
Device: Samsung Galaxy S22 ConnectBot version: 1.99-oss (F-Droid) OS: Android 13 Font: Standard

Hmm... Well, I have no problems with the standard font, either on my main phone or on my previous one (Samsung Galaxy A30s, Android 11).

I also have this issue with the standard font on both phones I use.
ConnectBot 1.9.9-oss
Android 12

All I did was select a 2 point larger font. Ever since, it's messed up as in OP's case, between 5-10 spaces between the cursor and the text.  Did a complete uninstall and reinstall (deleting all used storage space and having to setup my connections again), and it's still messed up. I can't even find any way to change fonts, but no size helps, it's always there.
About to switch to Juice it's so annoying. Every other device is fine, just my main.

Same font issue on Samsung S22+. Anyone have an idea how to fix it?

That's screwed Midnight Commander. Note that width of bold font is OK.

Seems that's Samsung problem. I had SamsungOne font installed as a default system font; when I reverted the font setting to the 'standard' one, ConnectBot rendering becomes way better.

Just experiencing this on a Moto G62 5g using stock font since upgrading to Android 13 (Android 12 was fine from what I can remember).
If there is any info you need or Ideas to fix this let me know.
Thanks.

I have the same with my Moto g72 with the stock Android 12 and I didn't find any solution how to fix the issue.
In official handbook from Motorola there is a statement that you can set up your own font style, but I'm unable to find this option on my phone.

I finally found the setting in Android 13.  Tap and hold the screen, to bring up the widgets, and use the personalise option, and change it to a different font (in Android 11 it's in the settings, display, styles section).
I can live with a stock android font as it makes this look right.
Hope this helps the others that got stuck looking for this setting.

Same issue with the Motorola ThinkPhone, when using the "Square" Font.

Fixed issue on moto g54 by making font bold. Changing font didn't help

I also had this sproblem when using a non-standard font. I suppose an option to select a font for the terminal would solve this problem.

This seems to related to a changes in android 12 and Material Design. Some phone's settings let you change font size and color but not actual font. My Moto G Stylus 5G 2023 is an example of this which came stock with Android 13. Screenshot attached.
I recommend adding the feature to set the font in-app. This will help fix the issues across multiple manufacturers.

I finally found the setting in Android 13.  Tap and hold the screen, to bring up the widgets, and use the personalise option, and change it to a different font (in Android 11 it's in the settings, display, styles section).
I can live with a stock android font as it makes this look right.
Hope this helps the others that got stuck looking for this setting.

My Moto G Stylus 5G 2023 (Android 13) doesn't have the personalize widget.

Fixed issue on moto g54 by making font bold. Changing font didn't help

Enabling bold in system settings didn't fix my font probm on my Moto G Stylus 5G 2023.


Scalability test wall clock

Summary
Update the implementation for the original scalability test to include an absolute plot. In addition, many changes have been made to streamline the different scalability tests.
Note: As I have been rebasing from the gpu-monitoring branch, many of the changes from that branch will appear in this PR until the other PR has been merged.
Related issue :
#221

I just realized that it would be nice to enable/disable all scalability analyses from a flag passed to the Trainer's constructor. This would give the possibility to the user to decide when profiling should actually be done and when to have less overhead

I just realized that it would be nice to enable/disable all scalability analyses from a flag passed to the Trainer's constructor. This would give the possibility to the user to decide when profiling should actually be done and when to have less overhead

The way I had it in mind was that the decorator was going to be used as a toggle for this. The obvious problem with doing that is of course that you have to actually change the source code every time you want to do it. However, if you add a flag to the constructor that overrides the decorator then you in a sense have two contradicting toggles, which to me sounds quite confusing. To counteract this, I would suggest then that the decorators are a permanent part of every trainer, somehow, so that we limit the number of places for configuration, as anything else quickly becomes convoluted.


moti requires expo-linear-gradient when im using react native cli only without expo @nandorojo

Is there an existing issue for this?

[X] I have searched the existing issues

Do you want this issue prioritized?

[ ] Yes, I have sponsored
[X] Not urgent

Current Behavior
getting this weird  error while trying to use moti with react native only
my package json contains these packages
"react-native-reanimated": "^3.6.1",
"react-native": "0.72.7",
"moti": "^0.27.2",

Expected Behavior
getting this weird  error while trying to use moti with react native only
my package json contains these packages
"react-native-reanimated": "^3.6.1",
"react-native": "0.72.7",
"moti": "^0.27.2",

Steps To Reproduce
create new react native project with npx react-native init project
install moti package
instal reanimated package
use in in the code
Versions
"react-native-reanimated": "^3.6.1",
    "react-native": "0.72.7",
    "moti": "^0.27.2",

Screenshots

Reproduction
npx create-react-native-app -t with-moti

@husam868maher @nandorojo  same here any fix for this ?

Did you use the non-expo approach from the skeleton on docs?
https://moti.fyi/skeleton#non-expo-users

Hey @nandorojo!
Recently I've also tried to use Skeleton component with react-native-cli & react-native-lineal-gradient but got the same error as @yamak-app

Seems like your Babel plugin isn't working

You added the module resolver one from the docs?

Hi @nandorojo !
Thanks again for such great package for animations. I've resolved
the problem for react-native cli by using this small patch changes:
moti+0.27.2.patch

Can you please send the code inline?

expo.tsx file:
import { LinearGradient } from 'react-native-linear-gradient'
import React from 'react'

import SkeletonNative from './skeleton-new'
import { MotiSkeletonProps } from './types'

export default function SkeletonExpo(
  props: Omit<MotiSkeletonProps, 'Gradient'>
) {
  return <SkeletonNative {...props} Gradient={LinearGradient as any} />
}

SkeletonExpo.Group = SkeletonNative.Group

skeleton.tsx:

import { LinearGradient } from 'react-native-linear-gradient'
import React, { useState, createContext, useContext } from 'react'
import { View, StyleSheet } from 'react-native'

import { View as MotiView } from '../components'
import { AnimatePresence, MotiTransitionProp } from '../core'
import {
  DEFAULT_SKELETON_SIZE as DEFAULT_SIZE,
  defaultDarkColors,
  defaultLightColors,
  baseColors,
} from './shared'
import { MotiSkeletonProps } from './types'

export default function Skeleton(props: MotiSkeletonProps) {
  const skeletonGroupContext = useContext(SkeletonGroupContext)
  const {
    radius = 8,
    children,
    show = skeletonGroupContext ?? !children,
    width,
    height = children ? undefined : DEFAULT_SIZE,
    boxHeight,
    colorMode = 'dark',
    colors = colorMode === 'dark' ? defaultDarkColors : defaultLightColors,
    backgroundColor = colors[0] ??
      colors[1] ??
      baseColors[colorMode]?.secondary,
    backgroundSize = 6,
    disableExitAnimation,
    transition,
  } = props

  const [measuredWidth, setMeasuredWidth] = useState(0)

  const getBorderRadius = () => {
    if (radius === 'square') {
      return 0
    }
    if (radius === 'round') {
      return 99999
    }
    return radius
  }

  const borderRadius = getBorderRadius()

  const getOuterHeight = () => {
    if (boxHeight != null) return boxHeight
    if (show && !children) {
      return height
    }
    return undefined
  }

  const outerHeight = getOuterHeight()

  return (
    <View
      style={{
        height: outerHeight,
        minHeight: height,
        minWidth: width ?? (children ? undefined : DEFAULT_SIZE),
      }}
    >
      {children}
      <AnimatePresence>
        {show && (
          <MotiView
            style={{
              position: 'absolute',
              top: 0,
              left: 0,
              borderRadius,
              width: width ?? (children ? '100%' : DEFAULT_SIZE),
              height: height ?? '100%',
              overflow: 'hidden',
            }}
            animate={{
              backgroundColor,
              opacity: 1,
            }}
            transition={{
              type: 'timing',
            }}
            exit={
              !disableExitAnimation && {
                opacity: 0,
              }
            }
            onLayout={({ nativeEvent }) => {
              if (measuredWidth === nativeEvent.layout.width) return

              setMeasuredWidth(nativeEvent.layout.width)
            }}
            pointerEvents="none"
          >
            <AnimatedGradient
              // force a key change to make the loop animation re-mount
              key={`${JSON.stringify(colors)}-${measuredWidth}-${JSON.stringify(
                transition || null
              )}`}
              colors={colors}
              backgroundSize={backgroundSize}
              measuredWidth={measuredWidth}
              transition={transition}
            />
          </MotiView>
        )}
      </AnimatePresence>
    </View>
  )
}

const AnimatedGradient = React.memo(
  function AnimatedGradient({
    measuredWidth,
    colors,
    backgroundSize,
    transition = {},
  }: {
    measuredWidth: number
    colors: string[]
    backgroundSize: number
    transition?: MotiTransitionProp
  }) {
    return (
      <MotiView
        style={StyleSheet.absoluteFillObject}
        from={{ opacity: 0 }}
        transition={{
          type: 'timing',
          duration: 200,
        }}
        animate={
          measuredWidth
            ? {
                opacity: 1,
              }
            : undefined
        }
      >
        <MotiView
          style={[
            StyleSheet.absoluteFillObject,
            {
              width: measuredWidth * backgroundSize,
            },
          ]}
          from={{
            translateX: 0,
          }}
          animate={
            measuredWidth
              ? {
                  translateX: -measuredWidth * (backgroundSize - 1),
                }
              : undefined
          }
          transition={{
            loop: true,
            delay: 200,
            type: 'timing',
            duration: 3000,
            ...(transition as any),
          }}
        >
          <LinearGradient
            colors={colors}
            start={{
              x: 0.1,
              y: 1,
            }}
            end={{
              x: 1,
              y: 1,
            }}
            style={StyleSheet.absoluteFillObject}
          />
        </MotiView>
      </MotiView>
    )
  },
  function propsAreEqual(prev, next) {
    if (prev.measuredWidth !== next.measuredWidth) return false

    if (prev.backgroundSize !== next.backgroundSize) return false

    const didColorsChange = prev.colors.some((color, index) => {
      return color !== next.colors[index]
    })

    if (didColorsChange) return false

    // transition changes will not be respected, but it'll be in the key
    return true
  }
)

const SkeletonGroupContext = createContext<boolean | undefined>(undefined)

function SkeletonGroup({
  children,
  show,
}: {
  children: React.ReactNode
  /**
   * If `true`, all `Skeleton` children components will be shown.
   *
   * If `false`, the `Skeleton` children will be hidden.
   */
  show: boolean
}) {
  return (
    <SkeletonGroupContext.Provider value={show}>
      {children}
    </SkeletonGroupContext.Provider>
  )
}

Skeleton.Group = SkeletonGroup

The only important change here is this new import { LinearGradient } from 'react-native-linear-gradient' instead of expo-linear-gradient.
babel.config.js:
module.exports = function (api) {
  api.cache(true);

 return {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: [
    'react-native-reanimated/plugin',
    [
      'babel-plugin-module-resolver',
      {
        root: ['./src/'],
        alias: [
          { 'moti/skeleton': 'moti/skeleton/react-native-linear-gradient' },
        ],
        extensions: ['.js', '.jsx', '.ts', '.tsx'],
      },
    ],
  ],
  };
};

I didn't properly tested it with other RN versions. In my case it's working like a charm for both Android/iOS "react-native": "0.72.7"

@nandorojo Let me know if it's working on your side?
By the way, maybe it's better to override this react-native-linear-gradient/expo-linear-gradient dependency directly in json with "overrides" or something similar to it. What do you think?

Please send the patch file
What's wrong with the current docs for the skeleton using the Babel plugin? Doesn't it do this for you?

diff --git a/node_modules/moti/src/skeleton/expo.tsx b/node_modules/moti/src/skeleton/expo.tsx
index 1674b89..083824c 100644
--- a/node_modules/moti/src/skeleton/expo.tsx
+++ b/node_modules/moti/src/skeleton/expo.tsx
@@ -1,4 +1,4 @@
-import { LinearGradient } from 'expo-linear-gradient'
+import { LinearGradient } from 'react-native-linear-gradient'
 import React from 'react'

 import SkeletonNative from './skeleton-new'
diff --git a/node_modules/moti/src/skeleton/skeleton.tsx b/node_modules/moti/src/skeleton/skeleton.tsx
index 3ef5dd1..0e3bed3 100644
--- a/node_modules/moti/src/skeleton/skeleton.tsx
+++ b/node_modules/moti/src/skeleton/skeleton.tsx
@@ -1,4 +1,4 @@
-import { LinearGradient } from 'expo-linear-gradient'
+import { LinearGradient } from 'react-native-linear-gradient'
 import React, { useState, createContext, useContext } from 'react'
 import { View, StyleSheet } from 'react-native'

diff --git a/node_modules/moti/src/skeleton/types.ts b/node_modules/moti/src/skeleton/types.ts
index 7fa9d78..176f224 100644
--- a/node_modules/moti/src/skeleton/types.ts
+++ b/node_modules/moti/src/skeleton/types.ts
@@ -1,4 +1,4 @@
-import { LinearGradient } from 'expo-linear-gradient'
+import { LinearGradient } from 'react-native-linear-gradient'
 import { MotiTransitionProp } from '../core'
 import { baseColors } from './shared'

babel-plugin is working as expected now. Before, I had some troubles with changing babel.config.js.

Same problem here, I tried with the same patch but it's still not working. Any updates?

This solution worked for me using React Native CLI:
Install react-native-linear-gradient:
npm install react-native-linear-gradient
Replace all instances of:
import { LinearGradient } from 'expo-linear-gradient'
with:
import { LinearGradient } from 'react-native-linear-gradient'
Files where the change is needed:

node_modules/moti/src/skeleton/expo.tsx
node_modules/moti/src/skeleton/skeleton.tsx
node_modules/moti/src/skeleton/types.ts
node_modules/moti/build/skeleton/expo.js

This should resolve the issue when using React Native CLI instead of Expo.