onebox集群，停止调某个replica进程后，通过shell进行数据操作报ERROR:timeout

体验 onebox 集群，通过 shell 进行数据操作。创建一个新的表后，执行数据操作没有问题，然后运行  ./run.sh stop_onebox_instance -r <id> 命令，或者直接 kill调 replica 进程后，再次执行数据操作，就会报错ERROR：timeout。

以上为运行的截图，麻烦帮忙看下什么问题，thanks~

Because there is no primary replica alive for partition 3 (your pic 5), you must wait for new primary elected to be able to read/write.

But I've been waiting for at least ten minutes, and I still can't do data manipulation.I don't think it's normal.

Because there is no primary replica alive for partition 2 (your pic 5), you must wait for new primary elected to be able to read/write. Normally it doesn't take long.
Btw we suggest to use v1.11.3 which is the latest stable version.

But I've been waiting for at least ten minutes, and I still can't do data manipulation.I don't think it's normal.

由于只剩下了2个replica server（图3），而create建表是默认三副本的，一个replica server挂掉后partition 2没有primary所以无法读写（图5）。
可以用start_onebox -r 指定replica个数，启动多个（大于3）replica server，再stop其中一个试试。

由于只剩下了2个replica server（图3），而create建表是默认三副本的，一个replica server挂掉后partition 2没有primary所以无法读写（图5）。
可以用start_onebox -r 指定replica个数，启动多个（大于3）replica server，再stop其中一个试试。

我尝试了，你说的是对的，我再学习一下，感谢。

@zhangyifan27 is wrong.
@jackeylove01
This behavior is controlled by a configuration item of meta server:
[meta_server]
min_live_node_count_for_unfreeze = 3

If only 2 servers alive at last, the cluster will turn into a "freeze" state, which means
some of the partitions may not gonna have its primary, and the cluster will become
unavailable.
>>> app temp -d
[Parameters]
app_name  : temp
detailed  : true

[Result]
app_name           : temp
app_id             : 1
partition_count    : 8
max_replica_count  : 3
details            :
pidx  ballot  replica_count  primary              secondaries
0     3       3/3            <IP_ADDRESS>:34803  [<IP_ADDRESS>:34801,<IP_ADDRESS>:34802]
1     4       2/3            -              [<IP_ADDRESS>:34802,<IP_ADDRESS>:34803]
2     3       3/3            <IP_ADDRESS>:34802  [<IP_ADDRESS>:34803,<IP_ADDRESS>:34801]
3     3       3/3            <IP_ADDRESS>:34803  [<IP_ADDRESS>:34802,<IP_ADDRESS>:34801]
4     4       2/3            -              [<IP_ADDRESS>:34802,<IP_ADDRESS>:34803]
5     3       3/3            <IP_ADDRESS>:34802  [<IP_ADDRESS>:34801,<IP_ADDRESS>:34803]
6     3       3/3            <IP_ADDRESS>:34803  [<IP_ADDRESS>:34801,<IP_ADDRESS>:34802]
7     4       2/3            -              [<IP_ADDRESS>:34803,<IP_ADDRESS>:34802]

node                 primary  secondary  total
<IP_ADDRESS>:34801        0        5          5
<IP_ADDRESS>:34802        2        6          8
<IP_ADDRESS>:34803        3        5          8
                     5        16         21

fully_healthy_partition_count    : 5
unhealthy_partition_count        : 3
write_unhealthy_partition_count  : 3
read_unhealthy_partition_count   : 3

list app temp succeed

If you set this item to "min_live_node_count_for_unfreeze = 2":
>>> app temp -d
[Parameters]
app_name  : temp
detailed  : true

[Result]
app_name           : temp
app_id             : 1
partition_count    : 8
max_replica_count  : 3
details            :
pidx  ballot  replica_count  primary              secondaries
0     4       2/3            <IP_ADDRESS>:34803  [<IP_ADDRESS>:34802]
1     5       2/3            <IP_ADDRESS>:34802  [<IP_ADDRESS>:34803]
2     4       2/3            <IP_ADDRESS>:34802  [<IP_ADDRESS>:34803]
3     4       2/3            <IP_ADDRESS>:34803  [<IP_ADDRESS>:34802]
4     5       2/3            <IP_ADDRESS>:34803  [<IP_ADDRESS>:34802]
5     4       2/3            <IP_ADDRESS>:34802  [<IP_ADDRESS>:34803]
6     4       2/3            <IP_ADDRESS>:34803  [<IP_ADDRESS>:34802]
7     5       2/3            <IP_ADDRESS>:34802  [<IP_ADDRESS>:34803]

node                 primary  secondary  total
<IP_ADDRESS>:34802        4        4          8
<IP_ADDRESS>:34803        4        4          8
                     8        8          16

fully_healthy_partition_count    : 0
unhealthy_partition_count        : 8
write_unhealthy_partition_count  : 0
read_unhealthy_partition_count   : 0

list app temp succeed

your cluster can still be able to read/write.

@jackeylove01 参见楼上neverchanje的解释，原来有3个replica-server，你kill掉一个后，只有两个了，就会进入freezed模式，这种模式下会禁止所有的config更新，所以无法切换新的primary。你可以在shell中执行cluster_info命令 ，可以看到meta_function_level是freezed。


weinre, remote debugging CORS error

weinre, remote debugging CORS error
How can I set up and use remote debugging?
I am able to open ui, and enable Remote Debugger (weinre).
Now I have three ports used, one for my app (8080), one for ui (8081) and one for weinre (8082).
If I access weinre directly I get some documentation, and a script-tag I can add to my index.html-file.
The script is loaded, but when it tries to connect back to weinre I get
(index):1 XMLHttpRequest cannot load https://my-server:8082/ws/target.
No 'Access-Control-Allow-Origin' header is present on the requested resource.
Origin 'https://my-server:8080' is therefore not allowed access.

I don't know how to enable CORS on weinre, I am able to enable CORS on my app (and perhaps ui), using middleware (SO-post, similar problem), but this does not seem to affect weinre.
Environment

lite-server version: 2.2.2
nodejs version: v6.3.1
npm version: 3.10.3
OS type/version: linux

Problem was with using c9.io as hosting


AOT Error: Cannot determine the module for class.. Possible Regression

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [x] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
Windows 10
NPM: 6.0.0
Angular CLI: 6.1.3
Node: 8.11.1
OS: win32 x64
Angular: 6.1.3
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.0
@angular-devkit/build-angular     0.6.0
@angular-devkit/build-optimizer   0.6.0
@angular-devkit/core              0.6.0
@angular-devkit/schematics        0.7.3
@ngtools/webpack                  6.0.0
@schematics/angular               0.7.3
@schematics/update                0.7.3
rxjs                              6.1.0
typescript                        2.9.2
webpack                           4.6.0

Repro steps

Create a nested layer of modules
Create a component that inherits from abstract class

AppModule

NaviationModule (exports InboxModule)

InboxModule (Declares and exports InboxNavigationComponent)

InboxNavigationComponent

Observed behavior
ERROR in : Cannot determine the module for class InboxNavigationComponent in D:/Users/{{UserName}}/Desktop/Frontend/CannotDetermineModuleTest/src/app/core/inbox/inboxNavigation.component.ts! Add InboxNavigationComponent to the NgModule to fix it.

Desired behavior

Mention any other details that might be useful (optional)
Here is a reproduction from a generated cli 6.0.0 project
CannotDetermineModuleTest.zip

+1

Anyone have any movement on this? I am unable to upgrade to version 6 if I cant do a production build. Any ideas for a work around? I would like to keep current with angular. If I can't I will be forced into moving off angular.

try looking for import statements where you have lower/upper-case inconsistencies in the full path of files/modules.
That was my issue with these errors.
it's also the reason wry the reproduction excample fails. look in inbox.module import, there are a Uppercase but the file is lowercase.

Thank You so much I had entirely forgotten about case sensitivity! I actually didn't know it mattered that it didn't match the file name but I did remember having to be consistent when importing it.
While it still does not compile.... its a completely different error!
Thanks you so much @PawOrmstrupMadsen for your help.


feat: exclude existing guild from on_guild_create event after starting

About
This pull request is about on_guild_create event, which save the guilds array from ready (start) event, then excluding them from dispatching (then remove them from the list so the event will dispatch if the bot rejoined).
Checklist

[x] The pre-commit code linter has been run over all edited files to ensure the code is linted.
[x] I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

[ ] For the documentation
[x] To add a new feature
[ ] As a general enhancement
[ ] As a refactor of the library/the library's code
[ ] To fix an existing bug
[ ] To resolve #ISSUENUMBER

This is:

[ ] A breaking change

Will be better implement new event guild_join instead of limiting guild_create

reverted guild_create, dispatching new guild_join instead


[Impeller] Unstable frame rates on high frame rate iOS devices post 16.6.

Background
The frame rate jumps around constantly and the app experience is quite jittery. Annecdotally, this was filled as a regression but we don't actually have a way to confirm that this is due to a behavioral change in iOS.

Why are we blocking on waitForNextDrawable.
Assuming  "CPU to Display Latency"  is "Time from present drawable to system being done with drawable", then right now we have times bouncing between ~21 ms and 26ms. Some math: if we finish frame 0 at ~8.3 ms, then the best case scenario that drawable isn't ready until ~29ms, but we started waiting for it at 25ms. That is 4ms of waitForNextDrawable. In the worst case, we actually just miss the frame completely.

Turning on presentsWithTransaction from a background thead doesn't seem to change the presentation times much, though the appear much more stable and seemingly cause our rendering code to not block on waitForNextDrawable at all. Its unclear how this works, but from running metal system trace there were no additional clues. presentsWithTransaction from the main thread had no such effect.
Why is the display latency so high?
Interestingly if I test on a non high frame rate iOS device, the display latency is comparable. but with 16ms frames we have a lot more leeway. Searching apple forums for info on this turns up nothing. Interestingly, if I follow the advice in the profile above and set the CAMetalLayer.opaque property to YES, then presentation delay drops to 13ms. This may be an option for "regular" flutter apps but not add2app, but I haven't measured this.

How can we work around blocking on waitForNextDrawable?
Generally the advice I've seen on Apple docs/forums is that CAMetalLayer.nextDrawable should be one of the last things we do in frame. That is, rather than use the metal drawable texture as the resolve for our onscreen rendering, we should actually create our own swapchain and then blit into the drawable at the end of the frame. In the example, above where we waited for the next drawable for ~4ms, means that on average we have half as much time to complete the frame.
Note on our vsync
Something odd I've noticed is that regardless of whether metal system traces says that it presented a drawable for 8, 16 ms, the CADisplayLink is always firing at 8ms. Even the previous timestamp doesn't seem to represent when we actually presented our drawable, just the last system vsync.
I'm not sure if this is working as expected, but we don't have any backpressure on this system beyond the pipeline count until we hit the raster thread, so its very possible for the UI thread to run ahead. In fact, this is very much a goal of the UI thread - except that I suspect we're making things worse but not dropping frames earlier in the pipeline. I've tried to make changes to this but it is difficult. I think ideally the vsync implementations would have some awareness of the last time that flutter actually presented so that it could smooth things out. i.e. if the last frame duration was 16ms then assume the next one will take 16ms. Its possible we can make applications that are already janky better by adjusting this logic.
Dead ends
I had preveiously investigated unconditional thread merging, as this allowed presentsWithTransaction uncontionally. On further investigation, I found that this didn't actually help the frame stability, instead it triggered code in the vsync waiter to throttle our frame rate to 80.
Short-term Options

Cap device frame rate at 80. This seems to gauarantee that we dont have terribly unstable frames but is defiitely a "feels bad man" solution.

Apply opaque=YES to CAMetalLayer. I'm not sure if its possible to create a "transparent" flutter view on iOS. By default we clear the screen to solid black, but I think you applications could punch through this. We could always give an opt out.

PresentWithTransaction = YES and give apps a Plist Opt out. Despite the fact that we don't know how/why this works, and the fact that it breaks add2app and certain plugins, it definitely does fix the rendering jankiness. Last resort.

Longer-term options

Rewrite iOS rendering to acquire metal drawable later, including partial repaint. This will require a substantial reworking of partial repaint. Porting this change to Skia may be difficult without removing partial repaint entirely.

Opaque was set to NO in https://github.com/flutter/engine/pull/30664
Can we revisit this decision?

Sorry, I linked you the wrong PR - it was reverted in https://github.com/flutter/engine/pull/31710

Ahh got it. Makes sense then , I'll keep digging on this.

After updating to iOS 17, I do not see presentation times jumpting above 22ms, which means we generally always have enough time to render simple applications. We should still try to fix the above issues, but they may be less critical.

Proposed solution is documented in https://github.com/flutter/flutter/issues/138490

Looking at the system trace for the opaque layer - it has 'Direct to Display' set to yes, which I assume would mean it it skips the compositor. That would explain lower latency. Though I was under the assumption this can only happens when there are no other layers (which would include the status bar). Maybe that's not the case?

I'm wondering if the CPU to Display Latency is a red herring. I just ran some metalkit examples on macOS at 120hz, in some the CPU to display latency is over 32ms, and yet the average frame time is consistent 8.33ms.

I think I have a pretty good idea what is going on. I documented it here, but just in case, I'll put a quick summary here.
waitForNextDrawable is a symptom, not the cause. The difference between presentsWithTransaction on and off is what happens when iOS does not manage to present the requested frame in time:

With presentsWithTransaction enabled, this frame will simply be replaced by next frame (you can verify this by checking the presentedTime on drawable. It will never be displayed by the compositor.

With presentsWithTransaction disabled, the frame will be displayed as soon as possible and for full duration. Because this increases the presentation latency, waitForNextDrawable will now block almost for duration of entire frame. And it will keep blocking, until it slows down the raster thread enough so that metal layer can keep up. After things get bad enough on raster thread where it skips entire frame, waitForNextDrawable will not block anymore. This is what you can see this being a continuous pattern. It starts with a CAMetalLayer missing deadline ([layer nextDrawable] will begin blocking) and ends withs with raster thread skipping a frame, which lets the CAMetalLayer keep up.

I have a quick prototype branch that attempts to drop the frame when CAMetalLayer can't keep up, trying to emulate the behavior of presentsWithTransaction to a degree.
Circular progress indicator from flutter gallery with frame dropping:

Same thing on main:

In this example, only one frame gets dropped at the beginning of transition from gallery menu to example. That is enough to remove the delay from [layer nextDrawable].

waitForNextDrawable is a symptom, not the cause.

FWIW we know its not the cause, I documented the cause in https://github.com/flutter/flutter/issues/138490 . iOS takes too long to present, sometimes consistently, sometimes not. in 16.6 it was very inconsistent.
If iOS 120hz isn't actually able to sustain consistent 120hz then we need to merge the threads and present with transaction.

waitForNextDrawable is a symptom, not the cause.

FWIW we know its not the cause, I documented the cause in #138490 . iOS takes too long to present, sometimes consistently, sometimes not. in 16.6 it was very inconsistent.
If iOS 120hz isn't actually able to sustain consistent 120hz then we need to merge the threads and present with transaction.

The frame delays are quite rare, and may depend on other factors (i.e. have work on ui thread), unfortunately one "untreated" frame delay is enough for things to go south on raster thread.

Just a heads-up - this should be improved by https://github.com/flutter/engine/pull/48226 - I'd suggest trying current master with
<key>FLTUseFlutterMetalLayer</key>
<true/>

added into Info.plist.

We've made the FlutterMetalLayer the default with https://github.com/flutter/engine/pull/54121


Wallet confusion.

Wallet has permissions and password which most users would look for these under settings.
Permissions and password should be moved to the settings page.

@TheDegenSloth I would normally also say, passwords and keys should be placed under settings. But hiere is all different. In wallet are stored keys and passwords, not the money. The balance shown just for info. It more like card wallet where you hold a visa card and not the cash.

Oh okay i just didn't get the reason behind is because as a developer i would normally put that stuff in settings.

I dont see a point leaving this open right now. If you do you may re-open as you wish of course


Bug: Whitelabel Error Page

How to reproduce :

Start the genrator with ./mvnw
F5 on http://localhost:7471/generator

Hints :
"Either the controller class is not loaded in the spring boot context or the rest call is not available." -> https://www.yawintutor.com/application-has-no-explicit-mapping-for-error-whitelabel-error-page-with-status-404/

Found how to fix it.
When e user enters the URL directly into the Browser, we get a Whitelabel Error Page because our Spring Boot backend gives us a HTTP 404 - since this URL isn’t present in the backend.
The solution is to redirect or better forward the user to the frontend (router) again.
I can handle this ticket

Adding a bounty as it's a bug and need to be fixed


Sanity check for email addresses as first name

Refs: https://github.com/DoSomething/phoenix/issues/5997
Somewhere a user was able to register with an email address as a first name, which is displayed publicly if their reportback item happens to be promoted. We can perform this check in DSOUser -(NSString *)displayName

Worth adding a check into the register form prevent user from adding an email address as a first name...

We don't check for email as first name on web, so only sanitizing Campaign reportback gallery for now.


Generated code expects incorrect type for Gio::AsyncReadyCallback

If you try to compile this branch of my project, you will get the following error.
https://gitlab.gnome.org/wildeyedskies/wince/-/tree/fix-geoclue-init
In lib/gi-crystal/src/auto/geoclue-2.0/simple.cr:264:76

 264 | LibGeoclue.gclue_simple_new(desktop_id, accuracy_level, cancellable, callback, user_data)
                                                                            ^-------
Error: argument 'callback' of 'LibGeoclue#gclue_simple_new' must be Pointer(Void), not Proc((GObject::Object | Nil), Gio::AsyncResult, Nil)

This results from the generated code function requiring a Gio::AsyncReadyCallback, but the C call expects a pointer for the callback.
However, if you change the C call to instead take the pointer of the proc, you get a error, so I'm not entirely sure what's going on here.

However, if you change the C call to instead take the pointer of the proc, you get a error, so I'm not entirely sure what's going on here.

Here is the explanation why your attempt to fix didn't work.

Here is the explanation why your attempt to fix didn't work.

I don't think boxing is the reason for this.  The signature for Gio.AsyncReadyCallback is actually not a Pointer(Void), so I'm pretty sure the libgen isn't working correctly.
I ran into this while trying to use Gio.Task which generates mismatched bindings between LibGio and Gio.
lib LIbGio
  # generates the alias, but doesn't use it.
  alias AsyncReadyCallback = Pointer(LibGObject::Object), Pointer(LibGio::AsyncResult), Pointer(Void) -> Void

  fun g_task_new(source_object : Pointer(Void), cancellable : Pointer(Void), callback : Void*, callback_data : Pointer(Void)) : Pointer(Void)
end

module Gio
    def self.new(source_object : GObject::Object?, cancellable : Gio::Cancellable?, callback : Gio::AsyncReadyCallback?, callback_data : Pointer(Void)?) : self
      # g_task_new: (Constructor)
      # @source_object: (nullable)
      # @cancellable: (nullable)
      # @callback: (nullable)
      # @callback_data: (nullable)
      # Returns: (transfer full)

      # Generator::NullableArrayPlan
      source_object = if source_object.nil?
                        Pointer(Void).null
                      else
                        source_object.to_unsafe
                      end
      # Generator::NullableArrayPlan
      cancellable = if cancellable.nil?
                      Pointer(Void).null
                    else
                      cancellable.to_unsafe
                    end
      # Generator::NullableArrayPlan
      callback_data = if callback_data.nil?
                        Pointer(Void).null
                      else
                        callback_data.to_unsafe
                      end

      # C call
      _retval = LibGio.g_task_new(source_object, cancellable, callback, callback_data)

      # Return value handling
      Gio::Task.new(_retval, GICrystal::Transfer::Full)
    end
end

There's also a clear problem with trying to call #to_unsafe on a callback_data, which is a Pointer(Void), but that's another issue.
Unfortunately, I'm not sure there are any workarounds that I can find.
Monkey patching isn't possible as you can't monkey patch C lib bindings.  Trying to override the binding.yml to use lib_ignore for Gio also proves to be pretty difficult, as it can't conflict with Gio's already present binding.yml
Trying to use shard.override.yml to use a separate gio.crwith a differen't binding.yml also ignores the binding.yml in gio.cr.
info - Pango - No binding config found for Gio-2.0.

Putting binding.yml really anywhere in the project directory causes compile errors for the project like:
Error: can't find file '../../../../../src/bindings/g_lib/error.cr' relative to '/Users/skinnyjames/dsrc/big_editor/lib/gi-crystal/src/auto/g_lib-2.0/g_lib.cr'bi

So it seems that binding.yml is coupled with the lib repo, and the lib repo can't be swapped out.
While the lib is cool, I can't seem to make an app do moderate computation without blocking the UI thread.  Definitely open to suggestions.  It'd be really great if Lib<Gio/Gtk/whatever> generations were decoupled from their corresponding Gio/Gtk/whatever abstractions, which make it a lot more complicated to work with, especially when there are bugs.

The Lib* objects must be coupled only with other Lib* form C libraries it depends, any other coupling must be interpreted as a bug. I mean, must be possible to monkey patch things to fix the gi-crystal bugs.
Callback need more <3 for sure. On top of my head it needs:

Use Box objects to encapsulate the Crystal Proc.
Use ClosureManager to keep the Box objects in memory while the callback can be called.
De-register the callback from ClosureManager to avoid memory leaks.

It's possible to mimic a async API in libtest to be able to fix and test these issues in gi-crystal.

I'm trying to use Gio::Subprocess and this issue is now blocking me too 😬.
The problem is that the method doesn't have a DestroyNotify parameter, so GICrystal doesn't recognize it as a callback.
Anyway... I also need to think a better way to map these GObject assync API to Crystal... probably:
proc = Gio::Subprocess.new(argv: ["ls", "-l"], flags: :none)
proc.wait_async(cancelable) do |result|
  ...
end

This would cause GI-Crystal to call g_subprocess_wait_async with GAsyncReadyCallback being a wrapper function that would call the user callback then de-register itself from ClosureManager.

Here´s a monkey patch I did to be able to use GtkSource::FileSaver#save_async from GTKSourceView.
module GtkSource
  class FileSaver
    def save_async(io_priority : GLib::Priority, cancellable : Gio::Cancellable? = nil, &callback : Gio::AsyncReadyCallback) : Nil
      c_callback = Pointer(Void).null
      if callback
        c_callback = ->(gobj : Void*, result : Void*, box : Void*) {
          unboxed_callback = Box(Gio::AsyncReadyCallback).unbox(box)
          unboxed_callback.call(GObject::Object.new(gobj, :none), Gio::AbstractAsyncResult.new(result, :none))

          GICrystal::ClosureDataManager.deregister(box)
          nil
        }.pointer
      end

      # C call
      box = Box.box(callback)
      GICrystal::ClosureDataManager.register(box)
      LibGtkSource.gtk_source_file_saver_save_async(to_unsafe, io_priority, cancellable, Pointer(Void).null, Pointer(Void).null, Pointer(Void).null, c_callback, box)
    end
  end
end

I have plans to let the generator generate something similar to this, but passing to the block a generated type base don what the *_finish methods returns, e.g. in this case it would be GtkSource::FileSaver::SaveAsyncResult, with the method value returning what the gtksource_file_saver_save_finish would return, and more methods for any out parama of the *_finish functions.
In case of error, any of these methods would just thrown the corresponding exception.
As usual... I'm not sure when I'll implement this, but at least it's all clear how to do it.


TextField in Figma & Zeroheight is misleading  and unreadable.

Misleading
While building docs for TextField i have been looking to Figma & Zeroheight for guidelines  and i found them bit misleading:
Figma

Zeroheight

As expels show here there are inputIcon & helperIcon in the same TextField, wile Storybook says:

Examples of validation states. You can add the icon in the helper text or inside the text input, both not in both places.

And then we have this:
Storybook

Which statement is correct?
Unreadable
In both platforms the examples are difficult to read:
Figma

Zeroheight

From duplicate issue:
Reported in May 2022 gathering
- Rebecca/Lucas look at some zeroheight things:
	○ When inspecting in Figma the text is over top of each other. Also very small and blurry:
	○ https://eds.equinor.com/0b0c666ab/p/77e7d5-text-field/b/86826a/i/43041814

https://eds.equinor.com/0b0c666ab/p/77e7d5-text-field/b/86826a
	○ ![image.png](https://images.zenhubusercontent.com/6075453285eb60bb55b90568/59159ddd-b889-4967-953e-53bdb21cb969)
	○ So small, blurry, can we fix: https://eds.equinor.com/0b0c666ab/p/31ae8d-select/b/86826a

Will be solved as part of EDS 2.0, close this issue.


Add cell_ids for plotting

thanks for debugging and finding a potential fix.
I added a commit to the main PR that always includes the cell ids – the list you added the coordinate name to is intended as a default value for a parameter that allows customizing which coordinates are included in the hover table (I decided that this would be too much for this PR, though).
I'll have to think some more about how to pass the name of the cell id coordinate, though.


Rounded numbers

#367 Rounded target positions

just a note that this affects aopy.postproc.rotate_spatial_data -- see #376


ENH: ModifiedTimeType uses 64 bits on Windows - it was 32 before

This is missing circle.png+resample test failure.

As #654 needs more work, I will merge this now instead of waiting to rebase.


Terraform GitHub OpenID Connect

Creates an OpenID Connect provider for GitHub, with permissions to only allow access from a specific repository.
The certificate thumbprint has changed previously (when GitHub update their certificates), so a script has been added to get the latest thumbprint - which is then passed to the OpenID connect provider
Currently the managed AdministratorAccess policy has been attached to the Role that the OpenID Connect provider is allowed to assume - Though we should determine minimum permissions and create our own policy.

I've looked at it and I'm none the wiser. I think you might want bob to review this one.

As you say, the permissions policy is too wide at the moment. Please can another PR follow with a restricted policy, maybe do a deploy then use IAM Access Analyser to see what's being done?

Thats the plan. :)


No resource identifier found for attribute 'dragView'

I did add compile 'com.sothree.slidinguppanel:library:3.3.1' in build.gradle. However, I got this error when I wanna use dragView.
Did I miss something?

yes, it is now umanoDragView


Search contributor component

Issue #475
Description
A search bar to filter contributors on ProjectContributors page

The lag is due to too many contributors being rendered (be sure to test with a lower number of array elements to confirm that this is the root cause) so we can:

Explore optimizations involving lazy loading React components
Fallback solutions might be to add pagination and a Load More button

@Ovifer13 Great pr, go ahead and create an issue for improving load time and performance and another one for changing the x color in the text field to setlife primary and make it clickable on hover


Indentation Issues

It's a JSX file.

The settings are set to happiness

Hey @virginc, you could use your custom version of happiness. You just need to tick checkStyleDevDependencies option and it will try to find the linter on your node_modules. thx


v12 release

dependencies: update for invenio-app-rdm v12
release: v1.5.0

Once merged and released (I should be able to), I'll merge the docs too.


Migrate docs to Slab

I think it's better to have all in one place and is a better authoring and editing experience

Do #42 at the same time


Introduce good logging

To make debugging and tracing easier we should replace debug with bows and add good logs everywhere using debug were it makes sense.

Debug is integrated and at the moment we don't have major debugging/logging issues so closing for now.


[WIP] Fix GroupMetadataManager::removeProducerGroup() by using the correct ID

Motivation
GroupMetadataManager::removeProducerGroup() is trying to remove a group using the producerId.
Modifications
Fixed the issue by using the group ID.
Verifying this change

[ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:
WIP
Documentation
Check the box below.
Need to update docs?

[x] no-need-doc
No functionality change

Is it ready to review? If yes, you can remove the "WIP" from the title.

@lin-zhao I think yes.
@ZiyaoWei Could you rebase it master again?


[Event Request] Table 36 - Sales Header - OnBeforeLookupCity

Hi AL-Team,
can you please add the following Publisher in City OnLookup Trigger?
            trigger OnLookup()
            begin
                // NEW >>>>
                OnBeforeLookupCity(Rec, PostCode);
                // NEW <<<<
                                PostCode.LookupPostCode("Ship-to City", "Ship-to Post Code", "Ship-to County", "Ship-to Country/Region Code");
            end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeLookupCity(var Rec: Record "Sales Header"; var PostCode: Record "Post Code")
    begin
    end;

We don't have field City in Sales Header, we have Sell-to, Bill-to and Ship-to City. Please correct you request.

Hi Alexander, sorry for the unclear description. The Publisher should be inserted at Ship-to City. I've modified the request.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Reinstate slab allocator initialization for UltraHonk?

We can do recursive verification without the initialization step, but perhaps we will want that again in the future.

General sentiment is that the slab allocator should go away


add https support for pointpin

it seems that when people are using pointpin service via geocoder it uses http protocol while we're supporting https for quite a while

Thanks for this. My concern here is that Pointpin does still support HTTP (there are even examples in the docs) and this PR makes it impossible for Geocoder to use it. My preference is to let users choose what protocol they want to use via Geocoder config. Are there plans to phase out non-HTTPS access? Is there another issue with the HTTP requests?

@alexreisner thanks for quick response
I've re-enabled http
I will update documentation though to mention https only

The method is now identical to the one inherited from the Base lookup so I'm going to close this. But do please help us keep Geocoder up to date as Pointpin evolves!

ah, I didn't see this method
but now I don't understand why one of our clients is having troubles connecting via http if https is enabled and is preferable in geocoder gem

Hmm, that is strange. The way to do it is to set use_https when configuring Geocoder, eg:
Geocoder.configure(use_https: true)


docs: Tailwind CSS branding / link

Naming rule taken from: https://github.com/aniftyco/awesome-tailwindcss/blob/master/.github/CONTRIBUTING.md
Link is handy 🙃

thanks for the link!!


Release of NIDM-Results 1.3.0

Transition from NIDM-Results 1.3.0-rc3 to 1.3.0.

Released as nidmresults 0.3.4: https://pypi.python.org/pypi/nidmresults.


Make the packager work with babel strict mode transform

At the moment we have to disable strict mode for the transform-es2015-modules-commonjs because strict mode leaks to the global scope and breaks the bridge. It was due to the way the polyfills were bundled in the package. To fix it, I wrapped the polyfill modules in an IIFE. Then when strict mode was enabled some polyfills were broken due to strict mode errors so that was fixed too. Also removed the IIFE from the polyfills that included one.
This diff doesn't enable the strict mode transform since some internal facebook modules depend on it not being enabled. When #5214 lands we could make the default babel config shipped with OSS react-native use strict mode modules and facebook could just modify the babel config to disable it if needed.
This will allow removing "strict": false from https://github.com/facebook/react-native/blob/master/packager/react-packager/.babelrc#L16
Fixes #5316

On a completely unrelated note that new @facebook-github-bot picture is amazing!

This is awesome. I was planning to work on this, but seems now I don't have to :D
Thanks for working on this.

@janicduplessis thank you for the effort! I will try to shipit when I’m in the office.

@janicduplessis, thank you for the effort. I’m generally fine with the changes. Let’s clarify the open questions, especially in polyfills/document.js

@davidaurelio Thanks for the review, I fixed the issues concerning the navigator polyfill and the other minor stuff. The issues left are the @polyfill thing and WPO. I tested WPO on master vs my branch and it is effectively broken (__DEV__ code is not being removed). I'll check what has to change to make it work.

Awesome, thank you! Let me know if you need any help

@davidaurelio Should I keep support for both __DEV__ and global.__DEV__?

@janicduplessis Thank you, looks good!

@facebook-github-bot shipit

@janicduplessis I’m sorry, but you have to rebase :-(

@davidaurelio Rebased on master and squashed the commits.

I tried to land immediately after you posted yesterday, and right now, but there are still conflicts in packager/react-packager/src/Resolver/polyfills/babelHelpers.js and packager/react-packager/src/Resolver/polyfills/error-guard.js.
Afaik there is no need to squash your commits, btw. They will be squashed by our system anyway, so don’t worry doing it.

@davidaurelio Hmm weird, right now it says the branch has no conflicts. If you want to fix the conflicts manually what I did for these 2 files is simply take the version from master and then remove the extra closure scope that is not needed anymore.

It seems like you still have the version before I rebased since that's the 2 conflicts I fixed, not sure how your system works exactly but maybe try reimporting it since I rebased it may have trouble updating my branch.

ok, it’s supposed to update itself. Let’s try to ship from here.

@facebook-github-bot shipit

ok, the patch succeeded.


[BUG] Connection to Aurora managed Postgres

Agent Environment
Datadog EU site
Datadog Agent v7.44.0
Docker image using Linux arm64v8 architecture
Using documentation : Setting Up Database Monitoring for Aurora managed Postgres
docker run -e "DD_API_KEY=xxx -e "DD_SITE=datadoghq.eu" -v /var/run/docker.sock:/var/run/docker.sock:ro -l com.datadoghq.ad.check_names='["postgres"]' -l com.datadoghq.ad.init_configs='[{}]' -l com.datado ghq.ad.instances='[{"dbm": true,"host": "xxx","port": xxxx,"username": "datadog","password": "xxx"}]' gcr.io/datadoghq/agent
Describe what happened:
On a Host using ARM64 CPU architecture, agent can't connect to AWS Aurora PostegreSQL.
2023-05-04 09:49:20 UTC | CORE | ERROR | (pkg/collector/worker/check_logger.go:69 in Error) | check:postgres | Error running check:
[{"message": "SCRAM authentication requires libpq version 10 or above\n",
"traceback": "Traceback (most recent call last):\n
File \"/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/base/checks/base.py\", line 1122, in run\n
self.check(instance)\n  File \"/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/postgres/postgres.py\", line 674, in check\n    raise e\n  File \"/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/postgres/postgres.py\", line 642, in check\n    self._connect()\n
File \"/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/postgres/postgres.py\", line 471, in _connect\n
self.db = self._new_connection(self._config.dbname)\n  File \"/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/postgres/postgres.py\", line 455, in _new_connection\n    conn = psycopg2.connect(**args)\n
File \"/opt/datadog-agent/embedded/lib/python3.8/site-packages/psycopg2/__init__.py\", line 127, in connect\n
 conn = _connect(dsn, connection_factory=connection_factory, **kwasync)\npsycopg2.OperationalError: SCRAM authentication requires libpq version 10 or above\n\n"}]

Describe what you expected:
Running the same environment using docker image for amd64 architecture. No connection issue, SQL monitoring is working using Datadog dashboard
Steps to reproduce the issue:
Run a simple EC2 using t4g instance type by example. It will run a machine using Graviton2 processor.
Run a cluster Aurora Postgres and setup a datadog user and all the need following your documentation

Same as #13939


build: upgrade to nextjs 13 because why not

Refer: Next.js 13 Blog for migration.
Current version is 12.2.0.

Oops, opened in the wrong repo.


return cursor to normal mode upon exiting

my cursor in bash is a rectangle.  when i start julia with VimBindings, it changes to a vertical line.  insert mode.  if i then exit julia in this state, my bash cursor is now a vertical line.  if before exiting julia i hit escape to enter normal mode, the cursor becomes a rectangle.  if i then exit julia, my bash cursor is now a rectangle.
is there a way to retain the previous bash cursor shape irrespective of the state of the julia cursor when you exit?
thanks for this pkg btw!  i'm loving it!!

Thank you for the report!
This sounds similar to #51 - I'm fairly certain that I that what needs to be done is to print a "revert cursor to default" control sequence to the terminal. I haven't dug into exactly where to do that—Julia provides the atreplinit hook for hooking into the start behavior, so I'll need to find a way to get something like atreplexit behavior. Probably will end up being a fairly simple change.
I'm curious, what terminal and OS are you running? I'm still learning where the responsibility of cursor control lies, and I see a lot of different behavior. I observe the same behavior that you report when I use bash (in the terminal alacritty), but not fish, so I thought it was under the control of the shell, but it appears that when I use fish within the embedded terminal of vs-code I see this behavior there too, so it must not just be the shell alone?
Regardless, the fix is to print the "revert" sequence to the terminal upon exiting the REPL.
As a temporary (and annoying) fix, I believe this command can be used to reset the cursor to its default state:
printf "\e[0 q"

Well what do you know! There is a function for exit callback, atexit. Makes this much easier than I thought!

great!  to answer your question, i'm using the MacOS Terminal app.

@bjarthur the package now reverts the cursor to block style when exiting. I've just published version 0.3.6, if you update the package this should be fixed.
Let me know if you still see this issue!
Thanks

works, thanks!


Is it possible to share depenedencies / caches/modules-2 between multiple jobs?

Hi! Thank you for this GitHub Action, it's been a blast using it so far 😄
I am currently running a single workflow with 4 separate jobs structured this way:
ktLint ->
       unit-tests
       android-lint
       screenshot-test

it seems that each of those jobs would publish it's own dependencies cache (and instrumentation jars):

Is there a way to let only one of those jobs publish those, while the rest would be able to reuse them?
I tried the following:
  ktlint:
    name: KtLint
      ...
      - name: Run ktlint
        uses: gradle/gradle-build-action@v2
        with:
          gradle-home-cache-cleanup: true
          gradle-home-cache-excludes: |
            caches/jars-9
            caches/modules-2
          arguments: ktlintCheck

  unit-tests:
    name: Unit Tests
      ...
      - name: Run tests
        uses: gradle/gradle-build-action@v2
        with:
          gradle-home-cache-cleanup: true
          arguments: test

but then it seems like those cache entries are omitted / not downloaded at all:
Entry: Gradle User Home
    Requested Key : v8-gradle|Linux|checks-ktlint[37a6259cc0c1dae299a7866489dff0bd]-e17cbd2bab4030bc45ad8460cf3d2318bd6bc322
    Restored  Key : v8-gradle|Linux|checks-ktlint[37a6259cc0c1dae299a7866489dff0bd]-6ceb06cc32243f25912bd344b7d0c2b9a1455409
              Size: 293 MB (307078181 B)
              (Entry restored: partial match found)
    Saved     Key : v8-gradle|Linux|checks-ktlint[37a6259cc0c1dae299a7866489dff0bd]-e17cbd2bab4030bc45ad8460cf3d2318bd6bc322
              Size: 293 MB (307121161 B)
              (Entry saved)
---
Entry: /home/runner/.gradle/caches/8.4/generated-gradle-jars/gradle-api-8.4.jar
    Requested Key : generated-gradle-jars-1a83665c481822ee3817bdf1f75747ae
    Restored  Key : generated-gradle-jars-1a83665c481822ee3817bdf1f75747ae
              Size: 35 MB (36850579 B)
              (Entry restored: exact match found)
    Saved     Key :
              Size:
              (Entry not saved: contents unchanged)
---
Entry: /home/runner/.gradle/wrapper/dists/gradle-8.4-bin/1w5dpkrfk8irigvoxmyhowfim
    Requested Key : wrapper-zips-f82d94dd741812d9afc7aad8d4ab116c
    Restored  Key : wrapper-zips-f82d94dd741812d9afc7aad8d4ab116c
              Size: 124 MB (130236794 B)
              (Entry restored: exact match found)
    Saved     Key :
              Size:
              (Entry not saved: contents unchanged)

If these builds resolve exactly the same set of dependencies, then they will share the dependency-* cache entry. (You can likely see this with them sharing the wrapper-zips-* entry.) Otherwise, these builds will have distinct cache entries. Cache entries in GitHub are immutable once written, so it's not possible to have a single dependencies entry that is appended to by each build.
There are ways this could potentially be improved, by having the action extract cache entries for common sets of shared dependencies, or separating "stable" sets of dependencies from ones that change more often. I haven't found time to work on this yet.
Presently, the only way to have these Jobs share the dependencies entry is for them to share a "top-level" Gradle User Home cache entry. So you could have the ktlint Job write a cache entry, and have the other jobs configured with cache-read-only: true. They should then reuse the Gradle User Home entry from the ktlint job, which would also mean sharing the dependencies. The downside to this setup is that any dependencies that are not downloaded by the ktlint job will need to be re-downloaded each time.
May I ask what is prompting this question? Are you actually running out of space in you GitHub Actions cache, or just looking at ways to optimized the process?

Thank you @bigdaz for such an extensive answer. It's much more clear to me now.
Could you please point me to a place where hash for dependencies-* is calculated?

May I ask what is prompting this question? Are you actually running out of space in you GitHub Actions cache, or just looking at ways to optimized the process?

I just figured that having multiple dependencies sets being stored will stop scaling if I add more jobs to the project.
Meanwhile seeing that dependencies sets are of different size so it gave me an idea that the biggest one will be a superset for all of them.

The dependencies-* entry is defined here. Since the file-names are sufficient to uniquely identify the dependencies contained therein, we construct a hash of the file names here.
A couple of things to note:

You can enable cache debugging to see a lot more detail about what's going on.
You likely want to enable cache-cleanup, to ensure that the dependencies for each job are limited to exactly what's required for that job.


add court number

Court number added to match UI and also round robin tournament view. Boxes in playoff tournament view are already so full that I think it's better to only see the court number when clicking the box.

Kävin nyt lisää kentän näkyvii myös playoff näkymään!


Add verify-crd-upgrade script

/assign @deads2k

The script looks ok-ish to me.  Any comments from @sttts and @damemi should be fixed as followups.  This is catching problems in already merged PRs and in PRs currently open trying to make this switch.  I want to stop teh bleeding.
/lgtm
/approve

I'm manually adding valid-label, since this is not changing code, but rather adds additional layer of checks which ensures the completeness and correctness of the manifests.


Ensure Strict Ordering with Single Active and Exclusive Consumers

Back port issue for: https://github.com/spring-projects/spring-amqp/issues/2482

Fixed via: https://github.com/spring-projects/spring-amqp/tree/2.4.x


Apple Silicon machines support

Hi,
Are there any plans to handle Apple Silicon chips because Docker recommends avoiding the use of AMD64 images when possible?
Thank you,
Nicolas.

Hi, at the moment we don't have plans of providing images for different architectures - the public tracking issue for this is b/277154322.


Async Validation fires multiple times for single field when loading form from JSON Schema

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[x] support request

Current behavior
When loading a form from a json schema file, I add an async validation to one of the fields. Validation gets fired multiple times on startup for the single field (apparently equal to to the total number of fields in the form ). After that, the validation fires correctly when field is touched.
Expected behavior
Validation should only fire once when field is touched or instructed to do so.
Minimal reproduction of the problem with instructions
Repro on stackblitz ->https://stackblitz.com/edit/angular-k1i8qu
On startup, check dev console for the validation method calls.
What is the motivation / use case for changing the behavior?
Need to add async validation to a form loaded from json schema. I read that json validation is in the making, but thought this was a possible workaround. Thanks in advance for your support.
Please tell us about your environment:
Windows 10, VisualStudio Code, ngx-formly latest NPM package

Angular version:
Angular CLI 8.1.1

Browser:
all

Language:
Typescript

Node (for AoT issues): node --version =
10.16.0

Quick add, not only async validators have this problem.
Minimal reproduction of the problem:
https://stackblitz.com/edit/angular-wj7mme-u74x4v
Check console, validator gets called twice on init.

I'd give it another chance to see if there is an easy way to fix it in the next minor version.
note: The proper fix will be implemented in the next major version (v6) as it may introduce a breaking change.

v5.5.2 is released which includes a fix for this issue!

Hi I tried updating the previous stckblitz with 5.5.2, but the validation is called twice on startup. Here's a link:
https://stackblitz.com/edit/angular-k1i8qu-bjhfoh
Could it be because I am adding the validation during runtime and this forces a reload of the form object?

not sure why? I'll check it. Before it was called 8 times ;)

I've tried with angular reactive form without using formly and the calls are the same as what we've got with formly https://stackblitz.com/edit/angular-taojrp?file=src/app/input-form-example.ts
maybe related to https://github.com/angular/angular/issues/21500
so the fix is out of our scope, unfortunately, I'll try to provide a fix in angular itself when time allows!

I see. Thank you for your support! :)


Add a param to enable check_support_default_queue_size for the support app

This functionality is never used in staging but is used in integration
and production so we want to gate its deployment by environment. Defaults to
true so only stage should see a change.

/cc @alphagov/team-gov-uk-core-formats-and-publishing because this is your app that we're tinkering with the monitoring for.

@deanwilson: Merge whenever :+1:


pending authorization prevent issuance of certificate

Which version of python are you using?
2
What operating system and version of operating system are you uing?
ubuntu
What version of sewer are you using?
0.1.8
What did you do? (be as detailed as you can)
try get certificate
What did you expect to see/happen/not happen?
get cert
What did you actually see/happen?
didn't get cert
Paste here the log output generated by sewer, if any. Please remember to remove any sensitive items from the log before pasting here.
this is cause there are pending authz and we either have to for them to clear https://letsencrypt.org/docs/rate-limits/

closed by: https://github.com/komuW/sewer/commit/959fb995a5852c9e6700763e7b6847d9daafdb00


Cannot properly open project in OSX

Describe the bug
When opening any MRTK project with Unity on a Mac (e.g. to use the experimental iOS support), the following error is printed to console many times:
DirectoryNotFoundException: Could not find a part of the path 'Applications/Unity/Hub/Editor/2020.1.0a16/Data\Resources\PackageManager\BuiltInPackages'.

Between console printouts a progress window with the title Building MSBuild projects... appears for a split-second.
The editor cannot be used with these errors interrupting any action.
To reproduce
Steps to reproduce the behavior:

Create a Unity project with MRTK imported (e.g. on a Windows computer)
Open that project on an OSX computer
Observe the errors flow in

Expected behavior
A clear and concise description of what you expected to happen.
Your setup (please complete the following information)

Unity Version 2020.1.0a16
MRTK Version 2.2.0

Looks like this is being addressed, see @keveleigh 's comment in  #6947


[WIP] Account creation with unlisted organisation fix

Fixes #1770 .
CHANGELOG

Using the 'My organisation isn't listed' link and entering a name now fills the 'Organisation' field with the 'Other' organisation
'Organisation' and the other organisation name fields are now validated with some JS
If no 'Other' organisation is present in the database, the appropriate error message will be shown
'Other' organisation won't be shown in organisations' list (since it's technically not a "real" org)

The changes look good @Sudiukil. Some recent merges seem to have created a conflict though. Please pull in the latest changes and resubmit.

My branch is already up to day with the development branch.
I've reviewed the conflict, it's nothing, keeping my version of create_account_form.js should be ok.

Fixed merge conflicts.


identify the file type without extension when opening a void or creating

specify for an empty open file with no extension just created or opened what is its type

You can already do this with the command Change Language Mode.


Would larger product images be better for mobile viewing?

Quoting from https://groups.google.com/forum/?fromgroups=#!topic/django-oscar/7kK33gdHB8c

Smaller devices would benefit from larger pictures

See the mobile size for this Zurb Foundation template: http://foundation.zurb.com/page-templates4/store.html
This is not a suggestion to switch the front-end Framework
These images respond well to browser resizing: http://teegallery.com
This site has a simple design and features: https://www.inventables.com

Is there an improvement we can make here by changing the image sizes?

I believe we'd allow to control thumbnails size in the settings, rather than hardcoding into the templates. Thus, to be address during thumbnails revision in the #1408.


MSMeasurement.siq_multicomp_gas_flux_calibration gives results inconsistent with MSMeasurement.gas_flux_calibration!

For example a 30% difference in F^O2_M32 based on N2 with 20% O2, compared to multicomp_gas_calibration. The difference is not explained by the viscosity of air, which is only 3.5% different from that of N2 at room temperature.

@matenestor I think this should be on your list, either for after the current project or at least for tracking.

@AnnaWiniwarter , I think we solved this, right? Is the correction merged?

Yes! I've been using it, works fine now.


Add skos and dcterms as common prefixes (always available)

Fix in namespaces.
Look in to annotations.py and namespace.py from owlready2 to see how it is done.

when saving the ontologies we get:
@prefix core: http://www.w3.org/2004/02/skos/core# .
@prefix term: http://purl.org/dc/terms/ .
but we should have
@prefix skos: http://www.w3.org/2004/02/skos/core# .
@prefix dcterms: http://purl.org/dc/terms/ .


Issue 2338

The major changes:
The deserialize order was changed ddic is now imported after the first abap step
For that reason it is required to activate the abap objects even with syntax error (not possible for ddic elements).
Therefore, some changes must be made to zcl_abapgit_objects_activation.
(Maybe conflict with the question #2509 cause now no dialog is shown at all)
side effects
For Remote function models the existence of DDIC is required (ABAP checks ich the Types in the interface matches the requirements for remote modules)
=> Function models are imported twice (1. as non remote so DDIC activation still could use the function module / 2. imported after the ddic as remote function)
Dynpros need the DDIC in the system. So dynpros are only imported after the ddic
SFBS/SFBF/SFSW needs old activation see #2469  #2470  so there is a new step for this issue
WAPA  needs a check + activation to be imported correct therefore also moved to the las check
Issues/open Questions:

What parameters should be used for the activation function?
Where to but the control of the sometime required special scenarios

syntax check (for Example WAPA - function O2_CHECK_APPL must be called before O2_ACTIVATE_PAGE)
Some objects need the DDIC flag but is no real DDIC SFBF/etc. (new function module is not working here)

I think the update of the where used list. Should be moved.
I think it is not working for objects with syntax errors. so this task should be done after all deserialize steps

Am I wrong that Travis errors are about indentation only?

I've built the report from this source and it worked almost perfectly. Some tables were left but another pull resolved the issues. Great work @GoWale ! 👍

please fix the indentation,
src/objects/zcl_abapgit_object_sfbs.clas.abap[159, 6] - Indentation
src/objects/zcl_abapgit_object_sfbs.clas.abap[159, 6] - Start statement at tab position

Please update the description so it reflects the changes part of the PR, "the basic idea" and "major changes" were merged previously
this PR contains changes to FUGR and other objects

@GoWale see comments above

@larshp soryy for the delay ahde some internet issues an was offline for 2 weeks...
I fixed the Indentation and updated the comment.

sorry for the delay, can you help rebasing the changes to current master?

rebase done

can we split this into multiple PRs? There are central changes + changes to 7 different serializers, which makes this difficult to merge

I have a look how I could split up this PR.
But this could be tricky. Cause the change of order requires the other changes…
Would it also be possible if there would be a way to put this change unto the experimental flag?

I will open a some new PR next week.
I'll try to keep the scope for each as focused/slim a possible :)


Proposed CONTRIBUTING.md file using a standardized template

Purpose

New CONTRIBUTING.md file format
Leveraging https://nasa-ammos.github.io/slim/documentation/starter-kits/#contributing-guide-template
NOTE: this is a DRAFT pull-request and it needs to be customized / adapted to your repo - please commit to this PR branch with your customizations before merging!
NOTE: make your modifications by searching for the string INSERT in the file and replacing with appropriate values for your repo
NOTE: read through the file thoroughly to ensure its well adapted for your repo and your scenario, feel free to modify as needed

Proposed Changes

[ADD] CONTRIBUTING.md file with sample content

Testing

For live example, see: https://github.com/riverma/terraformly/blob/main/CONTRIBUTING.md

My concern with the contribution guide is the split arrow in the diagram that implies a PR can be duplicated between two repos. PRs are tied to repos in a 1:1 correspondence. So PR comments/metadata/metachanges on a forked repo will be not be seen in the main repo. I would remove the arrow that goes back to the forked repo with the PR. If users comment there it will be them commenting on the fork only. (PRs aren't carried with merges, only the content itself.) Sure, the content will be retained but I think there's value in documenting the process as well as the comments.
See image:


Issue highlight with Liquid and Script type=“application/ld+json”

Hi, I have an issue with the code Script with type="application/ld+json"
Not only does it have display problems, fold buttons also do not work, as the code cannot be hidden.
I'm not sure if this is a feature or a bug, can anyone confirm this for me?
I have created a discussion here, you can find more information about this issue
Sublime version: 4166
This issue does not appear on version 4107
Can you check it? Thank you.

Fixed by Liquid 2.2.1
Note: ST's JSON syntax is not optimized to work with templating engines. Thus there might still be some smaller highlighting issues, like illegal highlighted commas etc.

It looks a lot more comfortable but still seems unfinished, I thought I should give you this code:
<script type="application/ld+json">
	{
		"@context": "http://schema.org/",
		"@type": "Product",
		"name": {{ product.title | json }},
		"url": {{ shop.url | append: product.url | json }},
		{%- if selected_product.featured_media -%}
			{%- assign media_size = selected_product.featured_media.preview_image.width -%}
			"image": [
				{{ selected_product.featured_media | image_url: width: media_size | prepend: "https:" | json }}
			],
		{%- endif -%}
		"description": {{ product.description | strip_html | json }},
		{%- if selected_product.sku != blank -%}
			"sku": {{ selected_product.sku | json }},
		{%- endif -%}
		"brand": {
			"@type": "Thing",
			"name": {{ product.vendor | json }}
		},
		"offers": [
			{%- for variant in product.variants -%}
				{
					"@type" : "Offer",
					{%- if variant.sku != blank -%}
						"sku": {{ variant.sku | json }},
					{%- endif -%}
					"availability" : "http://schema.org/{% if variant.available %}InStock{% else %}OutOfStock{% endif %}",
					"price" : {{ variant.price | divided_by: 100.00 | json }},
					"priceCurrency" : {{ cart.currency.iso_code | json }},
					"url" : {{ shop.url | append: variant.url | json }}
				}{% unless forloop.last %},{% endunless %}
			{%- endfor -%}
		]
	}
</script>

Thank you for fixing it.

That's what I mean with "ST's JSON syntax is not optimized to work with templating engine".
It uses a lot of unnamed contexts, which can't be overridden by 3rd-party packages.
As of ST4134 JSON is highlighted within HTML


SecureTextEntry Issue

Not able to change secureTextEntry While using a icon inside renderRightIcon onPress state is not updating the variable inside the secureTextEntry

Hi @RJ-CodeByte
Please re-check with version 2.0.1


Float arg

FloatArgument, for floating point args that need a range.
Still needs unit tests, but at this point, so does everything.

Also, this and IntegerArgument could probably share a base argument type, since most of the range checking is the same.  The main difference is that the text from the request body is cast to a float instead of to an int.

Looks good to me.
As a side thought, DecimalArgument ?

Hmm, yeah, interesting thought indeed. I think DecimalArgument makes sense, since this data will most likely be transmitted as a string rather than an IEEE 754 binary float, but that then begs the question...
Why do you think DecimalArgument is better than FloatArgument?

@soundofjw I'm going to leave this as FloatArgument for now, because the value type on the python end is float.


Consider removing property setters from non-Draft API objects

They suggest that the Object can be modified and then POST/PUT ed as changed to the API, but in fact changes can only be done via Update Actions.
-> may break stuff (tests...).
Just mark internal?

Problem: The sub-Objects like Money, etc. pp. are re-used massively across draft and API response objects.   To consistently make the API responses not look like they should be changed we would have to remove setters on all sub-objects, too.
But that's a larger effort with massive duplication.
-> later.

Will not be done with the actual design


tnt.ToolPage: get rid of Side Navigation

Dear UI5-Team,
closed issues can't be reopened, right?
This is a follow-up of https://github.com/SAP/openui5/issues/2290.
See this example in iPad mode, please:
https://jsbin.com/coduzigubu/edit?html,output
The SideNavigation space is still there. OpenUI5 is on 1.60.3.

Hi @born2dev,
I reopened the original issue, please check the status there.
Kind regards,
Georgi
(Github Dispatcher)


Support encoding JWT using JWKS string

Summary
This is related to use cases described in both #119 and #128.
I'd like to run jwt encode by providing my own JWKS instead of a plaintext --secret value. For example:
# jwt encode ... [--secret|--jwks]

$ MY_JWKS='{"keys":[{"alg":"HS256","k":"hS1H1jxz1fgBlXZGvuPxJHOnZxKsoAlvTncmFD-qEkc","key_ops":["sign","verify"],"kid":"MY_KEY_ID","kty":"oct"}]}'

$ jwt encode --kid MY_KEY_ID ... --jwks "$MY_JWKS"

where MY_JWKS can be retrieved from some HTTPS endpoint or generated locally using the jose CLI:
# https://github.com/latchset/jose

$ jose jwk gen -s -i '{"alg":"HS256","kid":"MY_KEY_ID"}'

{"keys":[{"alg":"HS256","k":"hS1H1jxz1fgBlXZGvuPxJHOnZxKsoAlvTncmFD-qEkc","key_ops":["sign","verify"],"kid":"MY_KEY_ID","kty":"oct"}]}

and jwt-cli would use the JWK in the provided keyset by matching the mandatory --kid value.
Besides just adding support for the JWKS standard, it allows using 256-bit (or whatever size) base64-encoded secrets that is in the JWKS k value. The --secret parameter is currently unable to use a non-Unicode string value, throwing the following error if given a binary string:
$ jwt encode --kid MY_KEY_ID ... --secret "$(base64 -d <<< "hS1H1jxz1fgBlXZGvuPxJHOnZxKsoAlvTncmFD-qEkc")"

thread 'main' panicked at 'unexpected invalid UTF-8 code point', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-2.33.3/src/args/arg_matches.rs:118:40
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Thanks for writing this up @erhhung! I'm not familiar with JWK/JWKS, so this is a bit new for me.
Taking an initial look, however, I don't think jwt-cli would be able to fully implement the standard. The underlying libray this project uses, keats/jsonwebtoken would allow us to support HMAC and RSA keys, since it provides a method to decode with ECDSA components, but not RSA components. Encoding is another matter, as this project would need to create the keys first, and it doesn't look like ring supports that.
What are your thoughts?

You don't need to generate keys before encoding first. You just need to require a JKW set that also contains the private key information. You can play with different JWK sets here https://mkjwk.org/ to get a better understanding of what that entails.
As far as I can tell keats/jsonwebtoken has support for at least ES256 an ES384 these days. It might not be everything but some support is much better than no support.

Unfortunately I don't have a lot of time to work on this at the moment (hence the delay here!) so if anyone would like to open a PR for this, I'd be happy to review!


[Fabric-Admin] Refactor to use API methods instead of PushCommand (3/3)

In the Fabric-Admin example app, we currently use string-based command handling. To better integrate with the final product, we need to replace this with APIs that utilize the SDK's read, write, and invoke clients.
Implement the bridge subscription API.
Fixes https://github.com/project-chip/connectedhomeip/issues/34910

fast track of 1-week old PR


MINOR:Start processor inside verify message

This PR fixes a flaky system test.
I ran six runs of branch builder, and each run was parameterized to repeat the test 25 times for a total of 150 runs.  All test runs passed.

https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2122/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2123/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2124/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2128/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2129/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2130/

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ping @guozhangwang, @mjsax, and @vvcephei for reviews

LGTM! Merged to trunk.


BoF request deadline

Description
Currently you can still start a new BoF request after the BoF request deadline. It would be good to add a note at the top that the deadline expired and now requests might not be consider for the next IETF meeting anymore.
Alternative we grey out the request button after the deadline and until the start of the IETF meeting. In this case it would be good to add a note that if the deadline was missed, the responsible AD should be contacted directly to figure what to do.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

I agree, we can check with the IESG. But for now edit some text would be good!


Upgrade PyJWT to latest version

Upgrading from 1.6.1 to 1.6.4 would result in the following error.
FAIL: test_multi_user_subscription (zerver.tests.test_subs.SubscriptionAPITest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/zulip/zerver/tests/test_subs.py", line 2039, in test_multi_user_subscription
    self.assertEqual(len(add_peer_event['users']), 19)
AssertionError: 18 != 19

@zulipbot label "area: dependencies"

PyJWT doesn't seem to be the cause of the issue. Closing for now.

I saw this recently in a Ubuntu bionic test VM.  I suspect the issue has to do with it being nondeterministic which users (maybe which bots?) are on that stream @sampritipanda can you investigate?
(It's possible the issue was just need to provision?)

@timabbott Couldn't really reproduce this on a bionic with the latest provision.
@hackerkid If you're still getting this error, can you just print the contents of add_peer_event['users'], would help with debugging.

Yeah, I think this might be something where if you provisioned with a certain master, it wouldn't update populate_db properly when you rebased to a newer version.  For me, do-destroy-rebuild-test-databsae fixed it.  So might be a bug that won't recur.

Yeah. I can't reproduce it.


Expand documentation

Love the tool but thought it could use a little more documentation. Happy to change/tweak things if anything should be different!

I'm not a big fan of adding a lot of extra documentation when the tool is providing these as well. When you run denon you'll see a list of all the commands. This list always up-to-date with the version you're running. If you are willing to add a better help text for these then you're welcome to do this in the source! :sun_with_face:


Prevent mapping extra fields in form for entity

I have additional fields in form for creating new Entity. But default mapped option not work in SensioLabs\RichModelForms\DataTransformer\ValueObjectTransformer. Any usages of read_property_path/write_property_path/property_mapper does not help
simple example:
public function buildForm(FormBuilderInterface $builder, array $options): void
{
    $builder
        ... // here are entity fields
        ->add('extra_field', SomeType::class, [
            'mapped' => false,
        ])
    ;
}

After request handling i catch NoSuchPropertyException for getExtraField() method.

@xabbuh  I added tests, can you review, please)

Also i found another solution of this case.
If use nested form for extra fields - exception will be not thrown.
Simple example:
(I use php7.4, so example will contain its features)
User class:
class User
{
    private int $id;
    private string $name;
    private string $email;

    public function __construct(string $name, string $email)
    {
        $this->name = $name;
        $this->email = $email;
    }

    public function getId(): int
    {
        return $this->id;
    }

    public function getName(): string
    {
        return $this->name;
    }

    public function rename(string $name): self
    {
        $this->name = $name;

        return $this;
    }

    public function getEmail(): string
    {
        return $this->email;
    }

    public function setEmail(string $email): self
    {
        $this->email = $email;

        return $this;
    }
}

ExtraForm:
class ExtraForm extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder->add('extra_field', TextType::class);
    }
}

UserForm:
class UserForm extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add('name', TextType::class, [
                'read_property_path' => fn(User $user) => $user->getName(),
                'write_property_path' => fn(User $user, string $name) => $user->rename($name),
            ])
            ->add('email', EmailType::class, [
                'read_property_path' => fn(User $user) => $user->getEmail(),
                'write_property_path' => fn(User $user, string $email) => $user->setEmail($email),
            ])
            ->add('extra_form', ExtraForm::class, ['mapped' => false]) // Here 'mapped' option will work
        ;
    }

    public function configureOptions(OptionsResolver $resolver): void
    {
        $resolver->setDefaults([
            'factory' => 'factory' => fn(array $data) => new User($data['name'], $data['email'],
        ]);
    }
}

In this case nested form will work by another strategy, as i can understand and mapped option will work properly

Thank you @KartaviK.


More curl status

Codecov Report

Merging #89 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   96.78%   96.78%   +<.01%
==========================================
  Files          20       20
  Lines        1367     1368       +1
==========================================
+ Hits         1323     1324       +1
  Misses         30       30
  Partials       14       14

Impacted Files
Coverage Δ

chttp/errors.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7fd601...9c71a45. Read the comment docs.


Some ipl's not loading?

Im totally a noob at this, i recently put this on my fivem server but some of the maps are not loading or something. when i look in the config files for the teleport coordinates. and i do the tp command it comes up saying invalid coordinates. is there something i am missing here?

Hi, I'm quite sure the issue is related with the way you teleport to coordinates.
Indeed, this script will not "create valid coordinates". You are free to teleport outside the map or under the ground in GTA V.
You must check how your teleport script works and see if you use it correctly.
Most teleport scripts uses
/tp X Y Z

Therefore, be sure not to write a comma (,) between the coordinates.


Hide secondary chart by default

By default, the secondary chart should be hidden. The user should have the option to turn RSI on/off, which will show/hide the secondary chart.

I'll take this.


Add option for Mocha tests to use event handlers

Creates an option battle.test that Mocha tests can use to create their
own temporary event handlers that can get picked up.
At any rate, it's more efficient than hotpatching the getEvent function.

@Zarel @Slayer95 @TheImmortal
I'm also very sleepy and this could be prone to tons of error.
battle.getRelevantEventsInner is set to "borrow" the format data when
resolving battle.test event handlers because like, it's part of this custom
one-use format??? idk if it's a good idea good night everybody

This is a very needed feature.
If only we could have a battle.on('Event', [...args]) API... (EventEmitter says hi)

What are we talking here, like a more complicated event injection system that let's the test module add more than one handler to the same event? If so, what would be a potential application?

Implementation of new formats without requiring mods.
Eventually replacing the event system by a modified EventEmitter (not sure who else if anyone supports this part).

So like, are we looking for something like this?
And do we need an off function for anything?

Seems good? Someone else review

Let's see, the reviewers left would probably be @TheImmortal and @Joimer. idk.
I also have absolutely no clue how we'd even abstract out an EventEmitter like @Slayer95 mentioned. Looking at how node does it, our handler resolution wouldn't be affected, but we'd only add new functions or something? Also having trouble deciding how we'd even implement off or removeListener with something like that anyways.

removeListener is not needed at this stage, but it would be cool to have it available for the future. It would iterate over the event list and remove the handler if found.
on would benefit from having priority as an optional intermediate argument (i.e. if only two arguments are provided, assume the second one is the callback).

So it would be battle.on(eventid[, priority], callback)? How would I write up the function arguments for something like that?

You can function (eventid, priority, callback) dalled as ('string', null | number, function) or get the called arguments and their number with arguments, as is done in some places in PS.
Also this is great, good idea, long needed and can be a first step to use EventEmitter as @Slayer95 suggests.

Something something new tests something something checking arguments something trying not to accidentally de-optimize something.

Suddenly things are being thrown.

Looks good as far as I can tell.
Leaving to @Zarel or @Slayer95.

Just curious though, since this hasn't been answered in this PR yet, is using the format data when the event is retrieved by getRelevantEffectsInner a good idea? Or should I try to figure out some other effect data thing to use?

imo it's fine for this case.  When/If we get to expanding this functionality to set event handlers for pokémon / sides / volatiles / etc, we could remove these throws.

Actually, I think that it should be a format (check effectType). I may not be thinking well due to a head ache lasting the whole day.

This is giving me a headache because for things like format or whatever you'd need the formatData when you add it to the relevantEffects, etc. etc. and I don't know the best way to resolve it, especially if we expand the possibilities for target.
At any rate, I made the new event handlers "fake" the resolveLastPriority by adding order and subOrder to the handler object in getRelevantEffectsInner.

At some point, tell me if this is okay for merge.

@Slayer95, what's your solution to resolving the fact that we need both the format object and the formatData to have a proper event? (It's going to be especially relevant when we expand it to work on abilities, weathers, etc. like you said)

statusData can be figured out from status at runEvent, by checking effectType or other relevant properties.

Oh surprise, because the default-format we have isn't an official format, target.effectType === 'Effect' when I set target = battle.getFormat(). Yippee, what should I do

Make it default to Custom Game? Create Custom Game battles where the feature is used?

If I default the battle engine to Custom Game if no format is specified, every test that uses default args needs to be updated to account for Team Preview...

And then I realized that @Slayer95 meant that the tests that used the new function should be Custom Games, and only those tests.

@Zarel, this is basically ready for merge if @Slayer95 doesn't object to something within the next day or so.

looks good


SCB-1617 Update the README files for contributors

Coverage decreased (-0.02%) to 80.455% when pulling eac31f6786d3d3263049ddea6a5f8eaef5f23a4f on SCB-1617 into 37cb41595e50129015edb5035aeb2aecb79e939e on master.


Adds content to Custom Fields page

Awesome job, thanks @DrrnDyl! Could you wrap your sample code in code fences please? It's 3 backticks ( ` ) before and after the code if you're wondering

No problem, @daviddarnes.


Reddit proof failed

https://www.reddit.com/r/KeybaseProofs/comments/8udlav/my_keybase_proof_redditcreeper123123321/

My Keybase proof is failing as well. I also work for Reddit.  Please let me know what we can do to help.

Also failing for me.

keeps failing

Mine was failing too, I was able to get it to work with my mobile phone instead of my computer browser. Give that a swing.

I also got this working with my phone; didn't work with the Mac app or on the web.  Thanks for the tip, @shawneric

It worked for me with the phone as well, thanks @shawneric


ObjectSchema keys are unconditionally added to the JSON object validated

package main

import (
	"bytes"
	"log"

	"github.com/faceair/jio"
)

func main() {
	orig := []byte(`{}`)
	data := []byte(`{}`)
	schema := jio.Object().Keys(jio.K{
		"foo": jio.String(),
	})

	if _, err := jio.ValidateJSON(&data, schema); err != nil {
		log.Fatal(err)
	}

	if !bytes.Equal(orig, data) {
		log.Printf("Want %s, got %s.", orig, data)
	}
}

prints
Want {}, got {"foo":null}.

Thanks, it's been fixed in v1.0.1 version.

Thanks a lot, @faceair. That was quick :slightly_smiling_face:


missing qas for dataset V1.2

http://visualgenome.org/api/v0/api_home.html
The page lists two versions of question answers:    V1.2 is in the size of 803.19MB  and V1.0 is in the size of 201.09MB.      However, both links lead to the same zip file which I believe is for V1.0.
While iterating through all the question-answers,  I find that a big portion of ids do not have its question-answer list.  I am wondering if those missing question-answers are only available in V1.2 ? If so, would you please redirect the download link to the correct file?
Thanks!

I have this same problem


No AstroInstaller.exe in latest release

:bug::scroll:

What is the current behavior?

When downloading the latest release, you are only given the source files and not the compiled application.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

Navigate to the latest release (2.1.4 as of this post)
Download the assets (note no compile assets, only source code)
Notice no AstroInstaller.exe in the downloaded files

What is the expected behavior?

According to the README, there should be an AstroInstaller.exe in the latest release dump, but it is not being properly generated.
Ideally there should be a GitHub Action that creates the exe on each release, or the README should be updated to only use the PowerShell instructions

Howdy,
GitHub support wrote me a few months ago asking me to pull the exe files due to false positive antivirus alerts.  I was using ps2exe in the travis.yml to generate the exe.  See here for details on why ps2exe isn't an option anymore.
You're welcome to compile the exe yourself using build.ps1 included in the repo.  In the meantime, I've halted making any more releases to this project pending the resolution of ps2exe being a false positive.

Thanks for the info Alex. Just looking at the repo for ps2exe it looks like it has almost been a year (Sept. 2020) since it first started being an issue. I think at that point you may as well just remove the exe information from the README and just have users simply use the ps1 scripts isntead

Sorry for the delay!
I've gone ahead and removed the references to AstroInstaller.exe from the README: https://github.com/alex4108/AstroInstaller/commit/8edc9f49873fe6186ce4232c07043b3c82f39e9f#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
If I get some time to put towards this project, it might be worth looking at another way to package as an executable.
Thank you for your feedback! :)


Token expired

Token needs to be renewed (https://github.com/osism/github-manager/actions/runs/2220354249)

Looks like the stored PAT only works when I merge/commit myself.


add screenshot at the beginning

Can you please rename Carte Topo avec QGIS.md to a more standard name such as readme.md ?  Having spaces is not convenient in command line. I didn't do it because I think you might have edited this long file on your side.
Thanks for this work.

Parfait, merci.


Silent PayPal failure

From a user:

We are testing the shopping cart and the checkout experience on the commerce site we are building on D-Shop. There are issues after checkout when on the PayPal page where after entering all info into Paypal it just reverts back to the data entry page.

Issue, as seen in my development environment:
https://user-images.githubusercontent.com/10854442/150491555-59ada2da-5f9e-49e1-9dd5-d5869ac3c1ff.mov


Suggest combining these sentences

Suggest you consider combining these two sentences:

To access Apache Ranger and Ambari audit logs, and ssh access logs, enable Azure Monitor. And view the tables that provide auditing records.

...into one sentence like so:

To access Apache Ranger and Ambari audit logs, and ssh access logs, enable Azure Monitor and view the tables that provide auditing records.

Thanks! Appreciate your hard work.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4cf98993-22de-6e5e-a11c-14fc78a6a0a7
Version Independent ID: 9e1dc9b5-df80-367a-9ed5-e30c6cbf964d
Content: Overview of enterprise security in Azure HDInsight
Content Source: articles/hdinsight/domain-joined/hdinsight-security-overview.md
Service: hdinsight
GitHub Login: @hrasheed-msft
Microsoft Alias: hrasheed

@cqueern Thanks for your contribution, I've addressed this issue in PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/118881
The changes should be live EOD or tomorrow. We will now close this issue. In future, if you see any minor bug fixes in the doc, feel free to click on the edit button and submit a PR to update. we love to take community contributions.


Remove panic when method not found in the tree

Replaced panic with HandleNotFound in router.go line 257.

Pull Request Test Coverage Report for Build 190

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.7%) to 99.324%

Files with Coverage Reduction
New Missed Lines
%

router.go
2
99.05%

Totals

Change from base Build 183:
-0.7%

Covered Lines:
294

Relevant Lines:
296

💛  - Coveralls


Rebase with master from ItJustWorksTM

Fixed conflicts, tests works 100%

Codecov Report

Merging #13 (86fd8d4) into master (a838a6f) will increase coverage by 24.31%.
The diff coverage is 64.94%.

@@             Coverage Diff             @@
##           master      #13       +/-   ##
===========================================
+ Coverage   38.69%   63.00%   +24.31%
===========================================
  Files          33       81       +48
  Lines        1473     2944     +1471
===========================================
+ Hits          570     1855     +1285
- Misses        903     1089      +186

Impacted Files
Coverage Δ

CMake/BuildProfiles/OpenSuseLeap.cmake
0.00% <0.00%> (ø)

include/Ardrivo/WString.h
100.00% <ø> (+100.00%)
:arrow_up:

include/SMCE/BoardView.hpp
94.44% <ø> (ø)

include/SMCE/Toolchain.hpp
66.66% <ø> (ø)

include/SMCE/internal/BoardData.hpp
25.00% <ø> (ø)

src/SMCE/BoardConf.cpp
0.00% <0.00%> (ø)

CMake/Runtime/CMakeLists.txt
89.74% <33.33%> (ø)

CMake/Modules/SetupBoost.cmake
75.49% <63.76%> (ø)

CMake/Modules/UserConfigVars.cmake
66.66% <66.66%> (ø)

src/SMCE/Toolchain.cpp
67.44% <66.66%> (-0.40%)
:arrow_down:

... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a838a6f...86fd8d4. Read the comment docs.


Fix deprecations for readLine in examples

warning was:

method readLine in trait DeprecatedPredef is deprecated:
Use the method in scala.io.StdIn

Duplicate ... (sorry for the noise, again)


[Storage] Migrate test_cpk in Blob to test proxy

Migrates test_cpk and test_cpk_async in the Blob package to test proxy.

API change check
API changes are not detected in this pull request.


Added Azure.KeyVault.RBAC

PR Summary
Fixes #1916
Added Azure.KeyVault.RBAC rule.
PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] Change is not breaking
[x] This PR is ready to merge and is not Work in Progress
Rule changes

[x] Unit tests created/ updated
[x] Rule documentation created/ updated
[x] Link to a filed issue
[x] Change log has been updated with change under unreleased section

Other code changes

[ ] Unit tests created/ updated
[ ] Link to a filed issue
[ ] Change log has been updated with change under unreleased section

@BernieWhite Let me know.


Not working for DPlay video

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.04.06. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.04.06

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
qp:q p$ youtube-dl -v http://www.dplay.no/nattpatruljen/season-4-episode-11/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.dplay.no/nattpatruljen/season-4-episode-11/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.04.06
[debug] Python version 2.7.11 - Darwin-15.3.0-x86_64-i386-64bit
[debug] exe versions: avconv 11.4, avprobe 11.4, ffmpeg 3.0.1, ffprobe 3.0.1, rtmpdump 2.4
[debug] Proxy map: {}
[DPlay] season-4-episode-11: Downloading webpage
[DPlay] 5017: Downloading JSON metadata
[DPlay] 5017: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[DPlay] 5017: Downloading f4m manifest
WARNING: Unable to download f4m manifest: HTTP Error 403: Forbidden
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 669, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 323, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/dplay.py", line 121, in _real_extract
    self._sort_formats(formats)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 845, in _sort_formats
    raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.```

---

### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

---

### Description of your *issue*, suggested solution and other information

Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* required an account credentials please provide them or explain how one can obtain them.

This video requires subscription thus you have to provide working account credentials.


add new dependencies

IPA can use the stress-ng and fio package beginning with version 8.0 / 8.1 (currently unreleased) https://docs.openstack.org/releasenotes/ironic-python-agent/unreleased.html#relnotes-8-1-0 we should add them as well.

@B1Sandmann PRs are welcome.
Both stress-ng and fio are included in Fedora.
Will this somehow change the deployment time? Or is this stress test of both disks and CPU optional?

yeah I just wanted to add it to the backlog as the version where this is needed isn't released yet. So I think adjusting the IPA version and updating the dependencies can be done in one PR.
As for the deployment time: I assume it shouldn't change the deployment time (from my limited understanding) as this is only used in a special mode and not on every deployment

I created a project to track everything needed for IPA 8.*


Upgrade to bootstrap 4

What issue does this PR address?
This PR updates the CSS/JS/Views to Bootstrap 4.3.1.
Resolves #2819.
Does this PR introduce a breaking change?
No. All changes are front end only changes.
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
N/A Unit Tests for the changes have been added (for bug fixes / features)

Other information:

I checked it out manually and ran the build - it fails
C:\local\identity\server4\IdentityServer4\src\IdentityServer4\host\Views\Account\LoggedOut.cshtml(1,27): error RZ1017: Unexpected literal following the 'model' directive. Expected 'line break'. [C:\local\identity\server4\IdentityServer4\src\IdentityServer4\host\Host.csproj]
Can you fix that?

I checked it out manually and ran the build - it fails
C:\local\identity\server4\IdentityServer4\src\IdentityServer4\host\Views\Account\LoggedOut.cshtml(1,27): error RZ1017: Unexpected literal following the 'model' directive. Expected 'line break'. [C:\local\identity\server4\IdentityServer4\src\IdentityServer4\host\Host.csproj]
Can you fix that?

All fixed. I stupidly had the "Prettier" VS Code extension enabled. It did NOT make the code prettier. . .

All fixed

Great, thanks! I'll have a look this weekend.

Hey. The consent screen looks a little wonky. Can you have a look, please?

Bootstrap 3.X moved to EOL in 24 Jul 2019. What is the current status of this PR?
https://blog.getbootstrap.com/2019/07/24/lts-plan/

	Sorry I got caught up with a few projects at work. Will try to get to addressing Brock’s feedback this week if possible.

	Get Outlook for iOS

On Wed, Aug 21, 2019 at 9:22 PM -0400, "SIkebe"<EMAIL_ADDRESS>wrote:
Bootstrap 3.X moved to EOL in 24 Jul 2019. What is the current status of this PR?
https://blog.getbootstrap.com/2019/07/24/lts-plan/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@brinehart Thank you for your great job! Much appreciated.

Nothing seems to happen here. Can we close?

Sorry I got busy at work. I think I will be able to address the design concerns this week so it can be used finally.
Securely sent with Tutanota. Get your own encrypted, ad-free mailbox:
https://tutanota.com
Nov 2, 2019, 02:23 by<EMAIL_ADDRESS>
Nothing seems to happen here. Can we close?
—
You are receiving this because you were mentioned.
Reply to this email directly, > view it on GitHub https://github.com/IdentityServer/IdentityServer4/pull/3311?email_source=notifications&email_token=AHSM72ORAEOT46NFMQGVVNTQRUMFBA5CNFSM4HSOJWZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4U7AI#issuecomment-549015425> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AHSM72NGJNRWYU7ALMY2ZPLQRUMFBANCNFSM4HSOJWZA> .

@brinehart How's it going? The bot added "wontfix" label, but this PR is very valuable since Bootstrap 3.X ended support last summer.

@brinehart I am unable to do that because I don't have a working IdentityServer4 setup.

@brockallen Is this PR going to be approved? Hope you can find some time to review because Bootstrap 3.3.5 is really getting ancient...

Yes... we're working on our 4.0 milestone, so it will be looked at.

Ok, thanks for the quick reply. Looking forward to 4.0

@brinehart so after almost a year, i finally got around to working on this. I used your branch as my starting point, I did additional re-learning of bootstrap, then i made the other tweaks to get this done. My PR is over here (https://github.com/IdentityServer/IdentityServer4/pull/4427) so we'll use that one. Thank you so much for sticking with this and pestering me to finally get to it.
Thanks!


Wrong link on web payments, payment methods basics page

Page Affected:
https://developers.google.com/web/fundamentals/payments/basics/payment-method-basics
What needs to be done?
Fix link for Tokenized Card Payment. This is should point to https://w3c.github.io/webpayments-methods-tokenization/index.html instead of https://w3c.github.io/webpayments/proposals/interledger/

I think this one has been fixed.