Env variables are not accessed by vite in PROD

Describe the bug
I am using the docker image for the production build. I have set my environment variables in docker and they are accessible by using env. But when I build the app these are not accessed by Vite.
Please help me here!
Reproduction
Create Svelte kit app by started.

create the docker image
Create the env variables in the docker system.
use the VITE_ as a prefix.

Logs
No response
System Info
Undefined

Severity
blocking all usage of SvelteKit
Additional Information
No response

VITE_ variables are bundled during build, not looked at at runtime in prod mode. If your Dockerfile is setting them at app runtime with ENV, this is expected. If that's not what's happening, we need a proper reproduction.

VITE_ variables are bundled during the build, not looked at runtime in prod mode. If your Dockerfile is setting them at app runtime with ENV, this is expected. If that's not what's happening, we need proper reproduction.

@Conduitry Yes, Dockerfile is setting them at app runtime with ENV.
Do you know any workaround for this.

@Conduitry
.env
VITE_SOME_ENV=hello

variable.ts
console.log(import.meta.env) // {VITE_SVELTEKIT_AMP: '', BASE_URL: '/_app/', MODE: 'production', DEV: false, PROD: true}
export const variables = {
	SOME_ENV: <string>import.meta.env.VITE_SOME_ENV,
};

NOTE: import.meta.env don't have VITE_SOME_ENV after the build
api.ts
import { variable } from './variable.ts'

const data = variable.SOME_ENV // const data = "undefined "

after the build const data = "undefined "  it replaced by undefined.
My docker image already has all the env variable inside the system env. When I build the file my env data is replaced by undefined.

What happens if you change import.meta.env.SOME_ENV to import.meta.env['SOME_ENV']? I remember a while ago Vite was doing text replacement specifically looking for the text import.meta.env. (with a trailing period), but I haven't looked at it in months and don't know if that's still current Vite behavior. But if import.meta.env['SOME_ENV'] works for you then that could be an easy workaround.

@rmunn there should be some improvement on that front with Vite 2.7: https://github.com/vitejs/vite/pull/5404
@narender2031 can you try upgrading and see if it fixes your issue?

I don't think import.meta.env.SOME_ENV or import.meta.env['SOME_ENV'] would work, even with Vite 2.7. import.meta.env is a per-file variable and replacements must be done during build-time. .env files wouldn't work as well so we'd need a different strategy for this, here's two options:

Have a separate build script in docker that generates a static JS file, which would be imported by app.html.

// env.js
window.__MY_ENV__ = "something"

// your-code.js
console.log(__MY_ENV__)

Keep in mind that you need to shim it in dev and SSR if needed, possible with kit.vite.define.

Or have a separate build script that does a find+replace on the final build assets.

vite looks like a horrible absurd bundler considering the number of issues and how childish and absurd those issues are. This vite nonsense is ruining the reputation of sveltekit. It's the only thing preventing the release of sveltekit.

@IsaacHub This issue has nothing to do with Vite, it's a common problem across any other bundlers like webpack, rollup, snowpack, so it's misleading to belittle Vite here. Plus, Vite 2.7 has solved many SSR issues, the majority of issues left are within SvelteKit itself. Vite is here to stay.

@benmccann Tried upgrading to 1.0.0-next.202, variables are still undefined with import.meta.env.VAR_KEY and import.meta.env['VAR_KEY'] when provided through Docker.
Reproduction repo available here.

Sort of duplicate: https://github.com/sveltejs/kit/issues/3030

Please see the environment variable FAQ: https://kit.svelte.dev/faq#env-vars
To use at runtime you'll need to instantiate yourself (see svelte.dev's hooks.js for an example). You can then pass to your templates using session

This problem is still here and quite infuriating.

This is an incredibly ugly hack to get this working, it converts process.env variables prefixed with VITE_ to an .env file before before runtime.
docker build file
...

COPY . .

CMD ["pnpm", "run", "preview"]

package.json
"scripts": {
    "build": "node ./.patch/env_bind.js && vite build && rm .env",
    "preview": "node ./.patch/env_bind.js && vite build && rm .env && vite preview --host"
},

.patch/env_bind.js
// Vite imports environment variables through import.meta.env. import.meta.env does not import docker variables like process.env does. This file patches this.
import fs from "fs";

const vite_env_variables = Object.entries(process.env).filter(variable => variable[0].startsWith("VITE_"));
const vite_env_variable_string = vite_env_variables.map(variable => variable[0] + "=" + variable[1]).join("\n");
fs.writeFileSync(".env", vite_env_variable_string, {encoding: "utf-8"});

I don't recommend using this, but in my case I dont have another choice until import.meta.env gets all the env variables

Hey, any update on this?

I solved this by building the .env from a shell script, using a pre-populated .env with =null for each variable.
docker-entry.sh:
#!/bin/sh

SRC=.env
OUTPUT="// generated"

while IFS="" read -r line || [ -n "$line" ]; do
    use_line=$line

    if expr "$line" : "VITE" > /dev/null; then
        ENVIRONMENT_VARIABLE_NAME=$(echo "$line" | sed -re 's/=.*//g')
        value=$(printenv "$ENVIRONMENT_VARIABLE_NAME")

        if [ "${value}" ] && [ "${value-x}" ]; then
            use_line="$ENVIRONMENT_VARIABLE_NAME = '$value';"
        fi
    fi

    OUTPUT="$OUTPUT\n$use_line"
done <$SRC

echo "$OUTPUT" > $SRC

http-server dist

https://stackoverflow.com/a/77490465/17756110 If anyone is still looking for the solution to this problem.


[Errno 11] Resource temporarily unavailable

Affected System: WSL2 Ubuntu 18.04 LTS, RaspBian Buster
Issue: [Errno 11] Resource temporarily unavailable
Steps to reproduce:

Install requirements as per documentation
sudo pip3 install -r requirements.txt
Run script python3 Callstranger.py
Script aborts with error

Log:
Stranger Host: http://<IP_ADDRESS>
Stranger Port: 80
Traceback (most recent call last):
  File "/usr/lib/python3.6/urllib/request.py", line 1325, in do_open
    encode_chunked=req.has_header('Transfer-encoding'))
  File "/usr/lib/python3.6/http/client.py", line 1264, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.6/http/client.py", line 1310, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.6/http/client.py", line 1259, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.6/http/client.py", line 1038, in _send_output
    self.send(msg)
  File "/usr/lib/python3.6/http/client.py", line 976, in send
    self.connect()
  File "/usr/lib/python3.6/http/client.py", line 948, in connect
    (self.host,self.port), self.timeout, self.source_address)
  File "/usr/lib/python3.6/socket.py", line 724, in create_connection
    raise err
  File "/usr/lib/python3.6/socket.py", line 713, in create_connection
    sock.connect(sa)
BlockingIOError: [Errno 11] Resource temporarily unavailable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "CallStranger.py", line 113, in <module>
    devices = upnp.discover()
  File "/home/mplogas/CallStranger/upnpy/upnp/UPnP.py", line 33, in discover
    for device in self.ssdp.m_search(discover_delay=delay, st='upnp:rootdevice', **headers):
  File "/home/mplogas/CallStranger/upnpy/ssdp/SSDPRequest.py", line 49, in m_search
    devices = self._send_request(self._get_raw_request())
  File "/home/mplogas/CallStranger/upnpy/ssdp/SSDPRequest.py", line 100, in _send_request
    device = SSDPDevice(addr, response.decode())
  File "/home/mplogas/CallStranger/upnpy/ssdp/SSDPDevice.py", line 82, in __init__
    self._get_description_request(utils.parse_http_header(response, 'Location'))
  File "/home/mplogas/CallStranger/upnpy/ssdp/SSDPDevice.py", line 115, in _get_description_request
    device_description = utils.make_http_request(url).read()
  File "/home/mplogas/CallStranger/upnpy/utils.py", line 80, in make_http_request
    return urllib.request.urlopen(request)
  File "/usr/lib/python3.6/urllib/request.py", line 223, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 526, in open
    response = self._open(req, data)
  File "/usr/lib/python3.6/urllib/request.py", line 544, in _open
    '_open', req)
  File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 1353, in http_open
    return self.do_open(http.client.HTTPConnection, req)
  File "/usr/lib/python3.6/urllib/request.py", line 1327, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 11] Resource temporarily unavailable>

Having almost the same error here, but instead of "Resource temporarlily unavailable" I get "Invalid Argument"

I updated UPnP stack to handle exceptions. can you retry?

Hi @yunuscadirci, this particular error has been resolved but I'm running into a different error now:
!Error: http://<local ip>:8080/description.xml failed
Traceback (most recent call last):
  File "CallStranger.py", line 113, in <module>
    devices = upnp.discover()
  File "/home/mplogas/CallStranger/upnpy/upnp/UPnP.py", line 33, in discover
    for device in self.ssdp.m_search(discover_delay=delay, st='upnp:rootdevice', **headers):
  File "/home/mplogas/CallStranger/upnpy/ssdp/SSDPRequest.py", line 49, in m_search
    devices = self._send_request(self._get_raw_request())
  File "/home/mplogas/CallStranger/upnpy/ssdp/SSDPRequest.py", line 100, in _send_request
    device = SSDPDevice(addr, response.decode())
  File "/home/mplogas/CallStranger/upnpy/ssdp/SSDPDevice.py", line 81, in __init__
    self._get_description_request(utils.parse_http_header(response, 'Location'))
  File "/home/mplogas/CallStranger/upnpy/ssdp/SSDPDevice.py", line 114, in _get_description_request
    device_description = utils.make_http_request(url).read()
AttributeError: 'NoneType' object has no attribute 'read'

The device that is behind the (redacted) IP and causing the error is my main home automation device. Want me to create a new issue instead?

Hi there are too many devices. I broaded exception handling. can you try again?

Hi @yunuscadirci thanks for your hard work. It seems we're getting close:
Stranger Host: http://<IP_ADDRESS>
Stranger Port: 80
!Error: http://<local ip>:8080/description.xml failed
!Error in device description request http://<local ip>:8080/description.xml
!Error in  ('<local ip>', 1900)
!Error in service definition http://<other local ip> urn:schemas-upnp-org:service:dummy:1
25  devices found:

 None None ( http://<local ip>:8080/description.xml )
Traceback (most recent call last):
  File "CallStranger.py", line 120, in <module>
    print(colored('\n  ' +str(len(tmpservices)) + ' service(s) found for '+device.friendly_name,'yellow'))
TypeError: must be str, not NoneType

I wonder why the script looks for a description.xml on port 8080 of  instead of port 80? I can GET the description.xml on port 80.

location header points port 8080. can you try with latest commit

@yunuscadirci Awesome, I tried with the latest commit and got a couple of results. Out of 26 devices found, I got 3 vulnerable devices (with total 36 vulnerable services) and 36 unverfied services on 5 devices. Is there a hard limit on the services iterator (36) or is it just pure coincidence?

It is good to see it worked. server verification limit is 50 but i will remove it soon


feat: turn on gzip for packument requests

:tada: This issue has been resolved in version 1.14.0 :tada:
The release is available on:

v1.14.0
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Node: more int types, float

https://github.com/no1msd/mstch/blob/master/include/mstch/mstch.hpp#L97
Is it possible to add: float, more integer types - int64_t/uint64_t, 8, 16 bit versions;
replace: int -> int32_t, add uint32_t ?
Or it has performance and memory drawbacks?

+1 but I only need additionally unsigned long long (uint64_t), long long (int64_t) and unsigned (uint32_t).

The 64 bit versions would be good.


Do you test your model on the images in the wild？

Hi, xy:
I try your demo on my hands and get the following results, it's there any thing wrong? I use the camera_param of 20_img as my camera_param.

Hi, camera_param is used to compute camera-space information, and the hand pose is not related to K. I have tried the first sample.  CMR-PG has the below results. Because of the lighting change, it brings errors.

So, I have released CMR-G. It has smaller model size and better generalization, and we train it with FreiHAND + other data. The model has the below results. However, the silhouette predicted by this model contains the wrist, so you would want to use the 2D registration only for mesh-image alignment, i.e., set poly=None in registration.

Announce in advance: we will release a new version of this method working on mobile devices in 3 months.

Thank you for your reply. So is there any differences between training CMR-G with others model?

All models have the same training setting.

ok, I'll try to train a model by myself. THx for your help.

Hi, I also have the same problem when I run demo on my own images, Do you find how to change the settings or something to get the good results?

Hi, I also have the same problem when I run demo on my own images, Do you find how to change the settings or something to get the good results?

Hi, thanks for your question. Please wait for days. I will update this repo and release the model for real-world test.

Thanks for your reply, so the results for real-world example above is generated by the other trained-model instead of model which was released?

Yes. Our model has a nice generalization. We have used it for online applications. Note that a small model size leads to better generalization.

@SeanChenxy  great work! Could you please tell me what inference framework for your online application ? Thanks !


Fix: Gitlab webhooks can be triggered without secret

Changes

Empty check for gitlab webhook secret send with request

Issues

fix #4186

Thank you for the PR!

Thank you for the PR!

your are welcome!


fix: remove extra class in Tailwind/trpc example

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/analogjs/analog/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Which package are you modifying?

[ ] vite-plugin-angular
[ ] vite-plugin-nitro
[ ] astro-angular
[ ] create-analog
[ ] router
[ ] platform
[ ] content
[x] nx-plugin (not really sure?)
[ ] trpc

What is the current behavior?
In the welcome component, we use text-xs and text-sm on the same element, so text-xs gets ignored.

Closes N/A
What is the new behavior?
I removed the extra tailwind class: text-xs.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N/A
[optional] What gif best describes this PR or how it makes you feel?

Thanks! @allcontributors add @ajitzero for code


Fix: wso2/ballerina-message-broker#513

Fix: wso2/ballerina-message-broker#513
Expose connection/channel details of consumers through CLI.
Related issue : https://github.com/wso2/ballerina-message-broker/issues/513

@DMadhuranga @sdkottegoda  Why did we add the --queue flag?

@DMadhuranga Can we also update the user documents?

@a5anka
+ --+ -----------+ -----------+ ------------------- +
| id| isExclusive| flowEnabled| transportProperties |
+ --+ -----------+ -----------+ ------------------- +
| 43| false      | true       | connectionId : 25.0 |
|   |            |            | channelId : 1.0     |
| 44| false      | true       | connectionId : 25.0 |
|   |            |            | channelId : 1.0     |
+ --+ -----------+ -----------+ ------------------- +

You asked me to fix the format of connection ID and channel ID (They should be integers). Rest API return a Map<String,Object> as transport properties. At the client end response comes as,
[{"id":43,"isExclusive":false,"flowEnabled":true,"transportProperties":{"connectionId":25,"channelId":1}},{"id":44,"isExclusive":false,"flowEnabled":true,"transportProperties":{"connectionId":25,"channelId":1}}]

So still the connection ID is an integer. But when Gson converts the payload to a list of Consumer objects,  transport properties becomes {"connectionId":25.0,"channelId":1.0}. Gson coverts integers to float when type is specified as Object. But i cannot convert type of the properties to Map<String, Integer> because there could be transport properties of other types.
Shall i do a hack converting values of transport properties map from double to integer if the double has ".0" as the floating value?

@DMadhuranga Let's not do that kind of a hack. Maybe we have to modify the deserializer used in the Gson. Can you please create a new issue to track this? We can handle the floating point issue separately.

@DMadhuranga It seems the github commit author has changed to "dan"


Cannot read property 'updateElementsByName' of undefined:

OS X, out of source

Start vscode, sometimes happens on startup

Sorry for not precise steps, but it happens seldomly.
  ERR Cannot read property 'updateElementsByName' of undefined: TypeError: Cannot read property 'updateElementsByName' of undefined
    at file:///Users/isidor/Development/vscode/out/vs/workbench/parts/preferences/browser/settingsEditor2.js:521:81
    at Array.forEach (<anonymous>)
    at SettingsEditor2.updateElementsByKey (file:///Users/isidor/Development/vscode/out/vs/workbench/parts/preferences/browser/settingsEditor2.js:521:22)
    at SettingsEditor2.onConfigUpdate (file:///Users/isidor/Development/vscode/out/vs/workbench/parts/preferences/browser/settingsEditor2.js:479:29)
    at file:///Users/isidor/Development/vscode/out/vs/workbench/parts/preferences/browser/settingsEditor2.js:51:23
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:148:38)
    at WorkspaceService.triggerConfigurationChange (file:///Users/isidor/Development/vscode/out/vs/workbench/services/configuration/node/configurationService.js:574:48)
    at WorkspaceService.onDefaultConfigurationChanged (file:///Users/isidor/Development/vscode/out/vs/workbench/services/configuration/node/configurationService.js:414:22)
    at file:///Users/isidor/Development/vscode/out/vs/workbench/services/configuration/node/configurationService.js:56:179
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:148:38)
    at ConfigurationRegistry.registerConfigurations (file:///Users/isidor/Development/vscode/out/vs/platform/configuration/common/configurationRegistry.js:55:46)
    at file:///Users/isidor/Development/vscode/out/vs/workbench/services/configuration/common/configurationExtensionPoint.js:117:31
    at ExtensionPoint._handle (file:///Users/isidor/Development/vscode/out/vs/workbench/services/extensions/common/extensionsRegistry.js:67:17)
    at ExtensionPoint.acceptUsers (file:///Users/isidor/Development/vscode/out/vs/workbench/services/extensions/common/extensionsRegistry.js:55:18)
    at Function.ExtensionService._handleExtensionPoint (file:///Users/isidor/Development/vscode/out/vs/workbench/services/extensions/electron-browser/extensionService.js:832:28)
    at file:///Users/isidor/Development/vscode/out/vs/workbench/services/extensions/electron-browser/extensionService.js:431:38
    at Object.notifySuccess [as _notify] (file:///Users/isidor/Development/vscode/out/vs/base/common/winjs.base.js:1191:59)
    at Object.enter (file:///Users/isidor/Development/vscode/out/vs/base/common/winjs.base.js:867:30)
    at _Base.Class.derive._creator._run (file:///Users/isidor/Development/vscode/out/vs/base/common/winjs.base.js:1089:29)
    at _Base.Class.derive._creator._completed (file:///Users/isidor/Development/vscode/out/vs/base/common/winjs.base.js:1057:18)
    at <anonymous>

Did not see it today -> verified
Will reopen if I see it again


IMP final release 0.6.0

@ekohl -- we can certainly do that, FWIW I'm not a maintainer on this project, but I can include it in the PR if you are able to merge?

Looking at my review icon (which is gray rather than green) I think I'm unable to.

I think we could ask @peritus to review and merge this branch after it's ready.

Sure. Can do that.


Sleek icon pixelated in Flatpak installation

Description:
Just a minor heads-up.
The new release (v2.0.1) currently provides an icon that appears slightly pixelated.
Here's a screen capture of my dash, for reference:

Rel: v2.0.1
Linux Flatpak installation
Pop!_OS 22.04

What desktop environment are you using?

Gnome 42.9

Here's a couple captures of my dock so you can see Sleek in context with others. It looks like my current version of Sleek is v2.0.8.
It still appears pixelated on my end.

@TriggerDingus thanks for sharing. It really looks nasty. I'll set up a VM and try to fix it.

@TriggerDingus can you please check this test release and tell me if the icon is still pixelated on your end?
Install it with: flatpak install https://dl.flathub.org/build-repo/78244/com.github.ransome1.sleek.flatpakref

I installed the test release in a GNOME virtual machine which should yield the same result as installing to my production host. It looks mucho better:

It isn't pixelated in the Apps panel any longer, either:

Glad to hear it works. I will include the fix in the next release. Again, Thanks for reporting this.

Just received the latest production release on my production box. Fixed!


New element to ODPS dev

•    CIA rating
CIA rating of the data product (link to data classification guideline)
We need to look this
•    Steward
A person with registered profile in the data catalogue that is responsible for the data product (link how to register and role description)
As a part of Data Holder information
•    Information Model
(Embedded) link or attached file to an information model (link to business term) describing the logical structure of the data.The information architecture team can be contacted through the catalog with conversation or by email (link).
Currently schemaLocationURL as a part of DataOps information. Schematype might be needed also.
•    Solution Overview
Describe the data product architecture and internal structure if needed. The aim is to give clarity to how this data product is operating.
Is description enough?
•    Data Profiling
Data profiling gives an overview of what type of data the data product has and some statistics about it. A link to the data profiling results can be presented here, or summary of the results.(Link to data profiling guideline)Under development: There is an API in development that allows data product teams to publish their data profiling results into the catalog as soon as the profling results are available.
Is Description enough?
•    Observability Metrics
Observability metrics are details about the operation status of the data product. Examples of metrics that can be of value to share with consumers (standard metrics is under development):Metric Value Notes
Latest update time 2022-01-03 12:31:00
Latest data time stamp 2022-01-03 10:00:00
Number or records 12456 Under development: There is an API in development that allows data product teams to publish their data metrics into the catalog as soon as the metrics are available.
As a part of document level attributes, mandatory?
•    Planned Updates
Planned updates indicate future changes that the consumers should be aware of. Usually only a major changes need to be presented, that have an effect on data usage.
As a part of document level attributes, optional?
•    Change Log
Log of all the changes with regards to the data product. Should be aligned with semantic versioning of the data product.
As a part of DataOps?

Old, closing


Cannot delete the postgres server group after creating a postgres server group is created but gets stuck due to insufficient resource on ADS

Azure Data Studio Version: 1.26.0-insider (user setup)
Azure Arc extension Version: 0.7.1
Azure Data CLI extension Version: 0.5.1

Steps to Reproduce:

Create a postgres server group which will get stuck due to insufficient resource for sure on ADS.
Close the notebook deployment window while the created postgres server group gets stuck on ADS.
Refresh the Arc controller management page so the stuck postgres server group shows up on ADS.
Click the stuck postgres server group on the Arc controller management page to bring up the postgres server group page on ADS.
Hit "Delete" button

Expected - Deletion should work.
Actual - Nothing seems to happen. I don't see "azdata arc postgres server delete" command is issued in the output windows of Azure Data CLI.
After closing and re-opening ADS app, "Delete" button starts to work.

I see this too.  For me it doesn't require the deployment to get stuck.  It requires (1) Deploy PG from within ADS (2) Manage it (3) Try to delete it.  Nothing happens.  It does work after restarting ADS or if PG was deployed outside of ADS.  Attaching a debugger to see why it doesn't execute.

I see this too.  For me it doesn't require the deployment to get stuck.  It requires (1) Deploy PG from within ADS (2) Manage it (3) Try to delete it.  Nothing happens.  It does work after restarting ADS or if PG was deployed outside of ADS.  Attaching a debugger to see why it doesn't execute.

I see this issue as well but I am also seeing it when trying to edit the postgres server. The azdata commands are not able to run before progress error occurs. Can also confirm it works after restarting ADS.

Deploy postgres server
Mange it -> Compute & Storage page
Save a change to worker count, CPU, or memory

Expected: Progress notification should have shown and error that is being caught should show error message on window.
Version: 1.26.0-insider
Azure Arc extension v0.7.1
Azure Data CLI extension v0.5.1

I see this issue as well but I am also seeing it when trying to edit the postgres server. The azdata commands are not able to run before progress error occurs. Can also confirm it works after restarting ADS.

Deploy postgres server
Mange it -> Compute & Storage page
Save a change to worker count, CPU, or memory

Expected: Progress notification should have shown and error that is being caught should show error message on window.
Version: 1.26.0-insider
Azure Arc extension v0.7.1
Azure Data CLI extension v0.5.1

This is the error message I see in the debugger.  For some reason it's not surfaced in the UI even though  vscode.window.showErrorMessage is executed.  I'm not exactly sure which line is throwing this.
message:'Converting circular structure to JSON\n    --> starting at object with constructor 'Node'\n    |     property 'next' -> object with constructor 'Node'\n    --- property 'prev' closes the circle'
stack:'TypeError: Converting circular structure to JSON\n    --> starting at object with constructor 'Node'\n    |     property 'next' -> object with constructor 'Node'\n    --- property 'prev' closes the circle\n\tat JSON.stringify (<anonymous>)\n\tat stringify (c:\\azuredatastudio\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:18:21)\n\tat Function.serializeRequestArguments (c:\\azuredatastudio\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:576:23)\n\tat RPCProtocol._remoteCall (c:\\azured…otocol.js:355:58)\n\tat Proxy.<anonymous> (c:\\azuredatastudio\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:146:41)\n\tat ExtHostProgress.withProgress (c:\\azuredatastudio\\out\\vs\\workbench\\api\\common\\extHostProgress.js:25:25)\n\tat Object.withProgress (c:\\azuredatastudio\\out\\vs\\workbench\\api\\common\\extHost.api.impl.js:472:44)\n\tat c:\\azuredatastudio\\extensions\\arc\\out\\ui\\dashboards\\postgres\\postgresOverviewPage.js:149:41\n\tat processTicksAndReject...

This is the error message I see in the debugger.  For some reason it's not surfaced in the UI even though  vscode.window.showErrorMessage is executed.  I'm not exactly sure which line is throwing this.
message:'Converting circular structure to JSON\n    --> starting at object with constructor 'Node'\n    |     property 'next' -> object with constructor 'Node'\n    --- property 'prev' closes the circle'
stack:'TypeError: Converting circular structure to JSON\n    --> starting at object with constructor 'Node'\n    |     property 'next' -> object with constructor 'Node'\n    --- property 'prev' closes the circle\n\tat JSON.stringify (<anonymous>)\n\tat stringify (c:\\azuredatastudio\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:18:21)\n\tat Function.serializeRequestArguments (c:\\azuredatastudio\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:576:23)\n\tat RPCProtocol._remoteCall (c:\\azured…otocol.js:355:58)\n\tat Proxy.<anonymous> (c:\\azuredatastudio\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:146:41)\n\tat ExtHostProgress.withProgress (c:\\azuredatastudio\\out\\vs\\workbench\\api\\common\\extHostProgress.js:25:25)\n\tat Object.withProgress (c:\\azuredatastudio\\out\\vs\\workbench\\api\\common\\extHost.api.impl.js:472:44)\n\tat c:\\azuredatastudio\\extensions\\arc\\out\\ui\\dashboards\\postgres\\postgresOverviewPage.js:149:41\n\tat processTicksAndReject...


Resolve links to parent local authority

This changes the link resolver class to lookup the links of the parent local authority, if the parent local authority tier is a valid tier for this service.
This is useful because it allows users to be shown a more suitable link if the most local council tier has no link set in the cases where the service is provided by multiple council tiers. This has come up recently as we're adding a new service for volunteering, but don't have all the links available at all tiers.
Trello Card

Nice one 🎉


Eliminate all logging in CI environments.

We only ever use STDOUT/STDERR in travis so any logging is completely useless.
Let's see if this makes any difference.

Do we want the null logger to return a level so when asked, so when a method asks logger "do you want warnings?" it will say "no"

We could fix the actual logs so we output less junk... just sayin?

@kbrock that's what Logger::UNKNOWN is -- it's the highest level.

We could fix the actual logs so we output less junk... just sayin?

Yeah, I agree.  A NullLogger variation (TrackingLogger) can be used to track who's the main culprits to see if we're doing excessive logging for certain things.  But, the idea was to take the NullLogger idea and see if stopping all logging in tests made any difference in test speed.

@matthewd it's :green_heart: now... that second commit did it.  Note, code coverage went down because we were calling our loggers in other code via the global variables.  Now, only the code that actually tests the loggers are covered.  I guess those were lies.
cc @blomquisg @Fryguy

Darn, looks like it only saved us ~15 seconds - but looks good to me


Remove fallback search value?

Why it fallbacks to sydney?
https://github.com/Srirangan/googleplaces.js/blob/master/lib/PlaceAutocomplete.js#L16
Can you please remove this, thanks

What is the input parameter? I don't see any documentation on this and wondering what I should set it to.


Update YoloV5 training notebook

Adding part for exporting the model via tools.luxonis.com, and changing the other methods as a bonus

Can we add 4 sections in square as a subsection of new section "Bonus: Host decoding".
And then parts of the last 5th section should go under that as well.
Rest of the 5th section would be on same level as "Bonus: Host decoding", but we should call it "Bonus: Device decoding - manual export". @HonzaCuhel

Updated


XML Docs for wholegraph needs to be created and uploaded in ci for use by cugraph-docs repository

This was done prior to migration into gnn
https://github.com/rapidsai/wholegraph/blob/branch-24.12/ci/build_docs.sh

References for context:

discussion about why this is needed: https://github.com/rapidsai/cugraph-docs/pull/46#issuecomment-2541919930
how this works in cugraph: https://github.com/rapidsai/cugraph/blob/3ad4949f2e119f881361500172a04d2d4b243f31/ci/build_docs.sh#L63-L68
how it used to work in wholegraph: https://github.com/rapidsai/wholegraph/blob/0a10aba7242656839dfcb31c7eba8b12df106631/ci/build_docs.sh#L35-L38

Reopening as this wasn't actually fixed by #96 (see #97).

Ok NOW we can close this, this was uploaded in https://github.com/rapidsai/cugraph-gnn/actions/runs/12381312765
And I saw that XML get downloaded successfully in https://github.com/rapidsai/cugraph-docs/pull/46


Server Password authentication doesn't work

Environment

TS3 Server: 3.12.0 Linux
tsclientlib: cab105e1

Steps to reproduce

Add password setting:

diff --git a/tsclientlib/examples/audio.rs b/tsclientlib/examples/audio.rs
index dc134ce..1f4385c 100644
--- a/tsclientlib/examples/audio.rs
+++ b/tsclientlib/examples/audio.rs
@@ -16,6 +16,9 @@ struct ConnectionId(u64);
 #[derive(StructOpt, Debug)]
 #[structopt(author, about)]
 struct Args {
+	/// The address of the server to connect to
+	#[structopt(short = "p", long, default_value = "")]
+	password: String,
 	/// The address of the server to connect to
 	#[structopt(short = "a", long, default_value = "localhost")]
 	address: String,
@@ -54,7 +57,8 @@ async fn real_main() -> Result<()> {
 	let con_config = Connection::build(args.address)
 		.log_commands(args.verbose >= 1)
 		.log_packets(args.verbose >= 2)
-		.log_udp_packets(args.verbose >= 3);
+		.log_udp_packets(args.verbose >= 3)
+                .password(args.password);

 	// Optionally set the key of this client, otherwise a new key is generated.
 	let id = Identity::new_from_str(

Run: cargo run --example audio -- -v -a <server> -p <password>

Expected result
Audio example runs.
Actual result
    dir: OUT
     Dec 29 15:23:16.069 DEBG Command, content: clientek ek=T1KOHxMK8XmEuKKpVxsgwzi2kZJjHJ0vEgjlLZlzsQw= proof=MEUCIDjfKrUREPPhXEdJtLNZKq++EBp\/hxgO8pE56Q9vXcbDAiEAt+UmvfcwaOZ8ycLlFRmoifDiUt11I+Des4f8Qdl9l0Q=
     Dec 29 15:23:16.088 DEBG Command, content: clientinit client_nickname=TeamSpeakUser client_version=3.?.?\s[Build:\s5680278000] client_platform=Windows client_input_hardware=1 client_output_hardware=1 client_default_channel client_default_channel_password client_server_password=<password> client_meta_data client_version_sign=DX5NIYLvfJEUjuIbCidnoeozxIDRRkpq3I9vVMBmE9L2qnekOoBzSenkzsg2lC9CMv8K5hkEzhr2TYUYSwUXCg== client_key_offset=354 client_nickname_phonetic client_default_token hwid=923f136fb1e22ae6ce95e60255529c00,d13231b1bc33edfecfb9169cc7a63bcc
    dir: IN
     Dec 29 15:23:16.108 DEBG Command, content: error id=1028 msg=invalid\sserver\spassword

Error: Server refused connection: ServerInvalidPassword

Remarks
I tested with multiple servers (another one at 3.12.1), and the password supplied is verified correct (TS3 Client connects).
I don't think it's a tsclientlib issue per se, as ts3j has the same problem, maybe the protocol has changed slightly?
Seeing as server password is a relatively recent addition to the lib, maybe I'm just using it wrong?
I haven't checked with TS3Hook yet how the password is presented in the regular client, might that be helpful?

On a whim, I set up TS3Hook anyway, and it looks like client_server_password needs to be hashed (looks to be sha1) and base64'd before going into the configuration. Maybe tsclientlib should take care of this internally e.g. in the password() fluent api.
Used "test":
[OUT] clientinit client_nickname=test client_version=3.?.?\s[Build:\s5680278000] client_platform=Windows client_input_hardware=1 client_output_hardware=1 client_default_channel client_default_channel_password client_server_password=qUqP5cyxm6YcTAhz05Hph5gvu9M= client_meta_data client_version_sign=DX5NIYLvfJEUjuIbCidnoeozxIDRRkpq3I9vVMBmE9L2qnekOoBzSenkzsg2lC9CMv8K5hkEzhr2TYUYSwUXCg== client_key_offset=182 client_nickname_phonetic client_default_token client_badges=Overwolf=0 client_myteam

Used "x":
[OUT] clientinit client_nickname=test client_version=3.?.?\s[Build:\s5680278000] client_platform=Windows client_input_hardware=1 client_output_hardware=1 client_default_channel client_default_channel_password client_server_password=EfatjsUqKYSrqv18O1FlA3hcIHI= client_meta_data client_version_sign=DX5NIYLvfJEUjuIbCidnoeozxIDRRkpq3I9vVMBmE9L2qnekOoBzSenkzsg2lC9CMv8K5hkEzhr2TYUYSwUXCg== client_key_offset=182 client_nickname_phonetic client_default_token client_badges=Overwolf=0 client_myteam

Thanks for the note, I guess I never tested that. base64(sha1(password)) seems to work, I added that in c53456d.
Clientmove, channeledit and all the file functions still need to be fixed.


Release v0.1.1

What
Release v0.1.1, containing all recent commits to main, excluding any commits that changed the versions of any dependencies.
Why
So that we can tag a version of this repo that is compatible with FutureNet, and that has the Gitpod configuration.

The last commit on this PR has been tagged and released as v0.1.1. It will not be merged back to main because these commits already live on main.
This release was done to support https://github.com/stellar/soroban-docs/pull/211.


Feature/click taskname open

Should fixe #46
One problem though, the mod_init function is not runned at the start of a new game... Can't figure out why. Can anyone help me with this?

tagging for later!

While testing I found out that if I can open the edit windows on clicking, it may be useful to close it with the same mode, disregarding modifications. this can be easily removed.

What do you mean with the last comment?

I you click the task, it opens the edit windows. If then you click one more, it closes the windows.

I finally managed to automate the building of the artifact. A new version has been released.
Can you please add a "next" version to the readme and write a short text on what you did?
Then I would merge the PR.

No problem I'll do that during lunch break.
Le dim. 19 août 2018 à 23:46, Jonas<EMAIL_ADDRESS>a écrit :

I finally managed to automate the building of the artifact. A new version
has been released.
Can you please add a "next" version to the readme and write a short text
on what you did?
Then I would merge the PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JonasJurczok/factorio-todo-list/pull/50#issuecomment-414158243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbWmwZk8k7bR-sxGL0NrzhOfNHdymdoks5uSdy_gaJpZM4V6rrc
.

Rebase, update version and changelog done.

@JonasJurczok can you push this into master or is there still changes to make ?

Sorry, I thought there was still a discussion here :)


write python script/function that modifies the properties of a link in a model file

sub task of #119 and #98

this would actually makes the development process more tedious, however #132 would definitely facilitate development


The ignore version specification for Docker is not clear

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#ignore
What part(s) of the article would you like to see updated?
The article mentions that "If you want to define a range, use the standard pattern for the package manager". However for Dockerfiles and docker containers, there doesn't seemed to be a defined syntax for this, including in the Docker/Dockerfile documentation. After much experimentation, the following was found to work:
versions:
          - "~> 1.3.0, < 1.3.6"

This should be documented, with a reference to the versioning this uses, or an example like the above.
Additional information
No response

@dannystaple Thank you for opening an issue and linking it to your PR! ✨

Closing this issue based on response here


Fix #2379 - CLI backup Import on call

Describe your changes :

This PR fixes https://github.com/open-metadata/OpenMetadata/issues/2379.
Try to import boto3 only when interested in running the backup command with the upload. This allows normal use of the CLI if backup is not needed.
Thanks

Type of change :

[x] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have performed a self-review of my own.
[ ] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

There are some issues in the get_entity_version methods for OpenMetadata API wrapper. This is also happening in my local. I opened an issue to take a look at this https://github.com/open-metadata/OpenMetadata/issues/2384


Docu of v5 Grid API - lack of justifyContent and alignItems props

Hello,
In the documentation of the new version (v5) of Material UI, in the section of Grid API :
https://next.material-ui.com/api/grid/
I can't find the justifyContent and alignItems props like in the v4.
But these props are still useful and working.
They are still in the Grid example page in the interactive section :
https://next.material-ui.com/components/grid/
Regards,
Getzel

These props are documented under

Related to #18288.


No component found for view with name "ARTSurfaceView"

Using:
"react-native": "^0.24.1",
"react-native-circular-progress": "0.0.6",
I get the following error below:

I have the same issue, I guess it is a problem caused by react-native-progress library

I did and I am getting this error. Is there an easy way to check that it has linked correctly? rnpm link returned no errors.

I drag and dropped node_modules/react-native/Libraries/ART/ART.xcodeproj somewhere to my Xcode project. After that I was able to add libART.a under Build Phases -> Link Binary With Libraries

@shiv86
I have found the solution for this problem.
It is caused by ART library which is to draw vector graphics using React.
You do not need to download anything, ART library is already in React-Native libraries.
Merely linking it to your project via Xcode can resolve the problem.
This article provides detailed steps, https://www.smashingmagazine.com/2016/04/how-to-build-your-first-ios-app-with-javascript/

@sschengyf  @dionysiusmarquis  Thanks it solves my issue too 👍

Glad to hear it solves your issue. @dionysiusmarquis @sschengyf thanks for support!

@sschengyf that links doesn't work (or needs a subscription or something)

@dionysiusmarquis @sschengyf  I followed those steps but I'm still getting the error. On XCode the file libART.a is highlighted red indicating that it is missing. If either of you could send me the file, that could possibly fix everything! Thanks

I am having the same issue as sampocs.  In XCode the libART.a file is red and adding it to the Link Binary with Libraries section has no effect.

@sampocs or anyone else still running into this issue:
After linking libART.a, I was able to proceed by doing the following

In Xcode, use CMD+B to build the project (thus completing the linking process by executing that "Link Binary to Libraries" build phase you just edited)
Restart the app by running react-native run-ios.

Hot reloading from the simulator didn't work for me - I had to restart the app from the command line.

Some additional tips:

when linking in XCode, make sure to select your main target and not the tvOS or test targets

in XCode -> project navigator -> Libraries -> Products -> libART.a was highlighted in reduntil I ran on device (not the simulator) and restarted XCode

@sschengyf Thanks!  Worked.

@ronaldsmartin thanks , that exactly the issue, i did'nt knew it that you have to build it , after building and restarting the simulator again, problem fixed 💃

I'm getting the same issue & I followed every single step 5 times & still I get No component found for view with name "ARTSurfaceView"
Frustrated now 😂
Can anyone help 🙏
I did what @dionysiusmarquis said & what @ronaldsmartin said but its still giving an error in Xcode

I had a same issue, but restart my application, and it solve this problem

I am having the same problem on RN 0.49.3

https://stackoverflow.com/questions/37658957/no-component-found-for-view-with-name-artshape
helped me

Please please please be make sure that when draging libArt.a make sure the target is your project.

It works for me:

In my Podfile i entered "ART" (my example)

  pod 'React', path: rn_path, subspecs: [
    'Core',
    'RCTActionSheet',
    'RCTAnimation',
    'RCTGeolocation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTNetwork',
    'RCTSettings',
    'RCTText',
    'RCTVibration',
    'RCTWebSocket',
    'ART'
  ]

pod install (inside ios folder)
react-native run-ios


RealSense d435 is not recognized (No device connected...)

Required Info

Camera Model
realsense D435

Firmware Version

Operating System & Version
Ubuntu 16.04 LTS

Kernel Version (Linux Only)
4.13.0-32-generic

Platform
PC

Issue Description
<Describe your issue / question / feature request / etc..>
I followed this link .
The result from
roslaunch realsense_ros_camera rs_camera.launch
is
[ERROR] [1519064413.637674817]: No RealSense devices were found! Terminating RealSense Node... [FATAL] [1519064413.833545927]: Failed to load nodelet '/camera/realsense_ros_camera of type realsense_ros_camera/RealSenseNodeFactory to manager realsense_ros_camera_manager' [camera/realsense_ros_camera_manager-2] process has died [pid 4279, exit code 1, cmd /opt/ros/kinetic/lib/nodelet/nodelet manager __name:=realsense_ros_camera_manager __log:=/home/yuki-ag/.ros/log/86d4b45e-15a1-11e8-88b0-d4258b2da0d7/camera-realsense_ros_camera_manager-2.log]. log file: /home/yuki-ag/.ros/log/86d4b45e-15a1-11e8-88b0-d4258b2da0d7/camera-realsense_ros_camera_manager-2*.log [camera/realsense_ros_camera-3] process has died [pid 4280, exit code 255, cmd /opt/ros/kinetic/lib/nodelet/nodelet load realsense_ros_camera/RealSenseNodeFactory realsense_ros_camera_manager __name:=realsense_ros_camera __log:=/home/yuki-ag/.ros/log/86d4b45e-15a1-11e8-88b0-d4258b2da0d7/camera-realsense_ros_camera-3.log]. log file: /home/yuki-ag/.ros/log/86d4b45e-15a1-11e8-88b0-d4258b2da0d7/camera-realsense_ros_camera-3*.log
And
modinfo uvcvideo | grep "version:"
is
version:        1.1.1.realsense-4.4.0 srcversion:     1812EB60BDE0DB2B1C92262
i can find realsense d435 when i run lsusb commando.

Hello @agari1229, could you please provide the lsusb output?
Have you managed to streaming using the Intel RealSense tools/examples such as realsense-viewer/rs-capture?

[Realsense Customer Engineering Team Comment]
Hello @agari1229,
Are you still having this issue?
If you are, please provide the lsusb output. Can you also tell me the output from rs-enumerate-devices?

Hi @agari1229
Feel free to open a new issue if you still having this problem.


AttributeError: 'str' object has no attribute 'decode'

Here's what I've done:
>>> import requests_html
>>> session = requests_html.Session()
>>> r = session.get("http://google.com")
>>> r.html.find('a')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/requests_html.py", line 85, in find
    c = [g for g in gen()]
  File "/usr/local/lib/python3.6/site-packages/requests_html.py", line 85, in <listcomp>
    c = [g for g in gen()]
  File "/usr/local/lib/python3.6/site-packages/requests_html.py", line 83, in gen
    yield Element(element=found, url=self.url, default_encoding=_encoding or self.encoding)
  File "/usr/local/lib/python3.6/site-packages/requests_html.py", line 53, in encoding
    self._encoding = html_to_unicode(self.default_encoding, self.html)[0]
  File "/usr/local/lib/python3.6/site-packages/w3lib/encoding.py", line 273, in html_to_unicode
    return enc, to_unicode(html_body_str, enc)
  File "/usr/local/lib/python3.6/site-packages/w3lib/encoding.py", line 185, in to_unicode
    return data_str.decode(encoding, 'replace' if version_info[0:2] >= (3, 3) else 'w3lib_replace')
AttributeError: 'str' object has no attribute 'decode'

Python version: 3.6.4

Last commit fixes it https://github.com/kennethreitz/requests-html/commit/db87e4b8084966d9b1f6c72f225d13bf62d7eb3c

@Recursing Wait, let me try.

Confirmed! https://github.com/kennethreitz/requests-html/commit/db87e4b8084966d9b1f6c72f225d13bf62d7eb3c fixed this.


SQL Lab saved query appears as "untitled" in new SQL Lab window

When user saves a SQL Lab query, and then opens a new browser tab and loads SQL Lab (or closes browser and opens SQL Lab again later), the earlier saved query is labeled as "untitled query". The query is however saved and view from the saved queries CRUD view.
Expected results
The query tab should have the correct title of the saved query.
Actual results
The query tab is labeled as untitled.
Screenshots
Step 1: Save a query.

Step 2:
Open SQL Lab in a new browser tab - see bug, the earlier saved query is Untitled.

Step 3:
It got saved into the saved queries list in crud view

How to reproduce the bug

Go to SQL Lab
Write query and click on Save query
Open SQL in a new browser tab (or close existing tab and open SQL Lab again)
See issue - the earlier saved query is shown as unitled.

Environment
(please complete the following information):

superset version: superset master

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
This is a regression, I noticed is couple days back first, it might have been introduced couple weeks back.

@zuzana-vej do you have the feature flag SQLLAB_BACKEND_PERSISTENCE enabled in your environment?

No I don't think so. Was there recent changes in this area though? (because this wasn't issue in the past)

I'm not sure about recent changes, but things work quite differently depending if you have that flag enabled or not

ok thanks for the suggestion, I will reopen if needed.

@zuzana-vej I'm seeing the same issue even with the flag enabled. Looks like the saving the query only temporarily renames the tab? and reloading sqllab the tab state reverts back to what it was called before saving the query. Opening the query from the CRUD view results in a correct tab name though.
The tab positions also seem to be moving around

Yes exactly. It saves it at that moment, but not when you open SQL Lab in a new window. And yes - it saves it in the backend since it's then in the crud view, and opening from there, the tab is named correctly.

Hmmm, I'm having trouble repro-ing this on master today. Are you still seeing it, @zuzana-vej ?

Yes, but I am few days behind. I will check again when I have new version. But based on flipping through closed PRs, I didn't see anything that was merged that would have fixed this in last few days. Initially the query name saves, but it's when you open SQL Lab in a new browser tab (or you close SQL Lab and open it again) when the title is again unknown.

I can confirm this was an issue in the latest version yesterday. I think the repo steps are not so clear

This happens when SQLLAB_BACKEND_PERSISTENCE is True

I not able to reproduce on master, so closing now.
https://www.loom.com/share/6417eef61a3247bf972aa794670ba152

I not able to reproduce on master, so closing now.
https://www.loom.com/share/6417eef61a3247bf972aa794670ba152

@hughhhh did you try reproing this with SQLLAB_BACKEND_PERSISTENCE=True? I've been able to repro consistently with that setting active

@hughhhh did you try reproing this with SQLLAB_BACKEND_PERSISTENCE=True? I've been able to repro consistently with that setting active

Thanks @etr2460 ! Yeah, I think he was able to repro now so reopened the issue. I think the flag wasn't set properly earlier so it looked like it wasn't happening.

Thanks @etr2460 ! Yeah, I think he was able to repro now so reopened the issue. I think the flag wasn't set properly earlier so it looked like it wasn't happening.

Thanks for the update @yousoph! Do you or @hughhhh have any update on resolving it?

Thanks for the update @yousoph! Do you or @hughhhh have any update on resolving it?

Still on our radar! But we don't have a fix yet

Still on our radar! But we don't have a fix yet

This PR has the fix:
https://github.com/apache/superset/pull/12607

This PR has the fix:
https://github.com/apache/superset/pull/12607

I missed that PR, thanks @hughhhh !!! :)

I missed that PR, thanks @hughhhh !!! :)


IE 11 and EDGE

This amazing button doesn't work in IE and Edge. Please help to me to fix it.

I don't have a Windows to try, but I have been able to verify that in Edge 42.17134.1.0 it works, not very well, but it works.
Can you detail me the errors?


Can only flash D21g18a once, then locked forever (nearly!)

I have been following this tutorial for implimenting a bootloader for the D21g18a.  I've downloaded the relevant files, made my own device_config for it and successfully uploaded it.
I've then successfully uploaded the bootloader (via JTAG), built my binary (with flags to start at address 0x6000) and uploaded the binary using SAM-BA.  I've tested the upload via SAM-BA several times and seems to be fine.
I then did an upload via BOSSA using the windows GUI. It identified the D21x18 successfully and can show info. I set Flash Offset = 0x6000 and hit write.  All went well.
I then tried again.  It said the flash was locked and asked to unlock first. I say yes, but it immediately brings up "Flash Command Failed".  I can still bring up info (it shows 0-15 locked regions) and read the flash.
I cannot write via SAM-BA either.  I get the error:
send_file {Flash} "C:/Users/info/Documents/Atmel Studio/7.0/SsAtxController/SsAtxController/Debug/SsAtxController.bin" 0x06000 0 -I- Send File C:/Users/info/Documents/Atmel Studio/7.0/SsAtxController/SsAtxController/Debug/SsAtxController.bin at address 0x06000 File size : 142312 Flash size : 0x40000 Flash page size : 64 First page : 384 Dest : 24576 -I- 	Writing: 0x100 bytes at 0x6000 (buffer addr : 0x200028D8) -E- Generic::Write returned error (0x00000002)
I tried erasing the micro via JTAG and reuploading the bootloader and then the binary.  Still no joy (either SAM-BA or BOSSA).
Weirdly, the only way to get the micro working is to set the upload project back to its default start address (is that 0x0000 ?), upload via JTAG.  Then start all over again (upload bootloader, change upload project start address etc etc).
I've been through this whole process twice, so definitely not a one-off. I'm a bit stuck and really want to use BOSSA in my project!  Any help would be much appreciated.

@soulsbysynths Hi Paul
I gave up on Bossa

For production, I use another SAMD21 that reads the .bin from an SD card and flash the target on a press of a button (see https://github.com/adafruit/Adafruit_DAP/tree/master/examples/flash_from_SD)
Subsequent users updates are done via the SDU library (just by saving firmware.bin on an SD card and rebooting )
(see https://www.arduino.cc/en/Reference/SDU)
Hope this may help

Ah that's a shame.  I feel that everything is so close to working with this system and with SAM-BA it's perfect, but of course I can't use that with my own uploader and I think it'll be too daunting for most users.
I'd done a nice bootloader where you connect Clk Out to Clk In with a jack cable and it does a little handshake to put it into USB flash mode!
Will check out those links.  Flashing from SD is an option for me, so could go down that route.
I'm surprised that no-one else has run into this issue of BOSSA permanently locking the flash regions after writing.

After this initial lock, you need to return SAMD21 fuse USER_WORD_1.NVMCTRL_REGION_LOCKS from 0x2000 to 0xFFFF.
Every new SAMD21 locks at the first time. You edit the Fuse and won't lock anymore.


Add multi-currency support for asset and position information

Add ability to set a currency other than USD for understanding position information, borrowing power, and asset values.
Consider defaulting to non-USD selection as part of overall i18n efforts.

This is live now. The app now allows users to select between 135 supported fiat currencies:

After consideration, I opted not to include auto selection of currency to match user browser locale preferences, as I have done with the auto language selection (#5). I can always toggle this on if there's interest but I'm generally suspicious of this type of automatic logic.
The implementation supports editing asset prices in the selected fiat currency and the general display of debt information. Future fiat-related features will respect this currency selection as well.


Add Support for import fetch from 'whatwg-fetch';

It's a polyfill, so you should never need to import it with a name, just like you never need to do import Promise from 'es6-promise'.
But if you insist, it should be doable currently
import * as fetch from 'whatwg-fetch';
import {fetch} from 'whatwg-fetch';

It might be a little cumbersome but something like this could work:
Make a little fetch utility module, that wraps up the whatwg-fetch.
// utils/fetch.js

// For browsers without Promise support
require('es6-promise').polyfill()
import 'whatwg-fetch'

// Can remove this if you would like
function checkStatus (response) {
  console.log('response.status', response.status)
  if (response.status >= 200 && response.status < 300) {
    return response
  }

  const error = new Error(response.statusText)
  error.response = response
  throw error
}

export default function whatwgFetch (url, options) {
  return fetch(url, options)
    .then(checkStatus)
}

Import your fetch utility to use in your module
// myModule.js
import whatwgFetch as fetch from '../utils/fetch'

fetch('/users.html')
  .then(function(response) {
    return response.text()
  }).then(function(body) {
    document.body.innerHTML = body
  })


x/build: plan to remove windows-[386|amd64]-2008 builders

Windows 2008 has reached end of life status. We should remove this builder and investigate if there are any other steps that should be taken in the process.
@golang/release
@bufflig

These builders are used by Go releases right now. Go 1.17 and 1.16 are documented to require Windows 7 or newer. Before we can remove the builders, we need to start using a newer builder for releases if possible, otherwise wait.

Is there any timeline by when Go would stop supporting windows 2008 R2?

@sanjayvora Windows 2008 R2 has reached its end of life.  We should be moving toward not supporting it in the near future.

Not an official one. We are starting to work on that.

Windows 2008 R2 has reached its end of life. We should be moving toward not supporting it in the near future.

Unfortunately no, it's still supported, Windows 2008 (NT 6.0) and R2 (NT 6.1) still receive security patches until January 10, 2023. These are part of the ESU program, which has a cost for self-managed installs, but is free if you have virtualized your 2008 / R2 box to an Azure VM.
While looking up a citation for this, i discovered that Azure VMs for 2008 and 2008 R2 even get an extra year of official security updates, all the way out to January 14, 2024:
https://www.microsoft.com/en-us/windows-server/extended-security-updates

With this, customers will have until January 14, 2024 for Windows Server 2008/ 2008 R2 [...] to upgrade to a supported release.

Hi @mappu thank you for providing this link and information.
@golang/release @bufflig Do you have any thoughts on this?

I'm not in a position to make any decisions here, I think, but it does look premature to drop the support for WIndows 2008 R2 if Azure workloads still get security updates. But I think the @golang/release team understands this much better than me.

Woooahh there, this is a big deal.
Dropping Windows 7 support is a very, very big deal.
I've tried various times to sunset support for it in my own software (most recently here -<EMAIL_ADDRESS>) and have not had much success. There are simply too many users: https://gs.statcounter.com/windows-version-market-share/desktop/worldwide/
Even Chrome, which was supposed to sunset Windows 7 this year, then pushed it to next, has pushed it ahead yet another year. And Microsoft still sells support for it too.
So, I would really like to kill Windows 7 support, because developing for it is a massive pain. But I don't think that'd be the best decision to make, so despite my desires, I'm keeping it alive a little longer.
If Go drops Windows 7 support, then Go will have forced this decision for me, and for others. That will surely elicit grumbles and maybe even howls. So maybe this issue should be tabled for another year or two, unfortunately.

@zx2c4 The @golang/release team discussed this earlier today and reached a similar conclusion. Thanks for creating the CL.

This decision will be explored in the future.


[SPARK-27362][K8S]  Resource Scheduling support for k8s

What changes were proposed in this pull request?
Add ability to map the spark resource configs spark.{executor/driver}.resource.{resourceName} to kubernetes Container builder so that we request resources (gpu,s/fpgas/etc) from kubernetes.
Note that the spark configs will overwrite any resource configs users put into a pod template.
I added a generic vendor config which is only used by kubernetes right now.  I intentionally didn't put it into the kubernetes config namespace just to avoid adding more config prefixes.
I will add more documentation for this under jira SPARK-27492. I think it will be easier to do all at once to get cohesive story.
How was this patch tested?
Unit tests and manually testing on k8s cluster.

Test build #105768 has started for PR 24703 at commit a461ab0.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/11023/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/11023/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11023/
Test PASSed.

Test build #105768 has finished for PR 24703 at commit a461ab0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105768/
Test PASSed.

Test build #105931 has started for PR 24703 at commit d8c095f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/11183/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/11183/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11183/
Test PASSed.

Test build #105931 has finished for PR 24703 at commit d8c095f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105931/
Test PASSed.

the pod templates are supported in the sense you can use them and if you specify the spark resource configs it will override whatever is in the templates.  That seemed to be how the other spark configs were setup with the templates, but if that is not the case or we prefer another behavior let me know.

@tgravescs pod template is the base configuration if exists and spark conf takes priority so it is ok to have this kind of semantics.

Ok, thanks,  no other comments I'll commit this later today

thanks everyone for the reviews, merged to master


refactor so functions show up in order on docs

This also makes it so functions show up in order from lsp requests, and provide a better code structure overall.

All done


.Net 6 supports

.Net 6 will be ready within 3 months. Is it possible to add the support? Thanks.

Sorry for confusion. After added the "actions/setup-dotnet@v1" lines, it works as before:
- uses: actions/checkout@v2
- uses: actions/setup-dotnet@v1
with:
dotnet-version: '6.0.x'
include-prerelease: true


Resolve some sysctl relevant stig issues

includes:
[#98978114]
[#98978116]
[#98978130]
[#98978170]
Signed-off-by: Zhang Hua<EMAIL_ADDRESS>

Merged.


Plus client is broken

It seems they totally removed the previous API, instantiating the Plus client currently fails:
>>> plus_client = Client()
Traceback (most recent call last):
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/connection.py", line 196, in _new_conn
    sock = connection.create_connection(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/util/connection.py", line 60, in create_connection
    for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/socket.py", line 964, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
socket.gaierror: [Errno -5] Name has no usable address

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 789, in urlopen
    response = self._make_request(
               ^^^^^^^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 490, in _make_request
    raise new_e
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 466, in _make_request
    self._validate_conn(conn)
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 1095, in _validate_conn
    conn.connect()
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/connection.py", line 615, in connect
    self.sock = sock = self._new_conn()
                       ^^^^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/connection.py", line 203, in _new_conn
    raise NameResolutionError(self.host, self, e) from e
urllib3.exceptions.NameResolutionError: <urllib3.connection.HTTPSConnection object at 0xfff621e753d0>: Failed to resolve 'pls-sprmrkt-mw.prd.vdc1.plus.nl' ([Errno -5] Name has no usable address)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/requests/adapters.py", line 667, in send
    resp = conn.urlopen(
           ^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 843, in urlopen
    retries = retries.increment(
              ^^^^^^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/urllib3/util/retry.py", line 519, in increment
    raise MaxRetryError(_pool, url, reason) from reason  # type: ignore[arg-type]
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='pls-sprmrkt-mw.prd.vdc1.plus.nl', port=443): Max retries exceeded with url: /Due-away-are-Fight-Banq-Though-theere-Prayers-On?d=pls-sprmrkt-mw.prd.vdc1.plus.nl (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0xfff621e753d0>: Failed to resolve 'pls-sprmrkt-mw.prd.vdc1.plus.nl' ([Errno -5] Name has no usable address)"))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/supermarket_connector/nl/plus/__init__.py", line 177, in __init__
    self.login()
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/supermarket_connector/nl/plus/__init__.py", line 152, in login
    response: Response = requests.request(
                         ^^^^^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bart/Downloads/tmp/.venv/lib/python3.12/site-packages/requests/adapters.py", line 700, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='pls-sprmrkt-mw.prd.vdc1.plus.nl', port=443): Max retries exceeded with url: /Due-away-are-Fight-Banq-Though-theere-Prayers-On?d=pls-sprmrkt-mw.prd.vdc1.plus.nl (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0xfff621e753d0>: Failed to resolve 'pls-sprmrkt-mw.prd.vdc1.plus.nl' ([Errno -5] Name has no usable address)"))

Any clue how to resolve this @Repsay? Seems something new has to be made.

I currently don't have the time to look into this. But the way you can find out is by decompiling the apk and looking through the source code to look for an url that they use now.


Add get_buyer_email_domains methods

We've had a request from CCS to see the list of approved email address domains for buyers (https://trello.com/c/h0CbxA9t/754-domain-whitelist-for-buyers). In future we might also want to add an admin frontend view that displays this info (https://trello.com/c/4LinvI5X/810-allow-admin-framework-manager-to-view-list-of-trusted-buyer-email-domains).
This commit adds a method to grab a page from the /buyer-email-domains api endpoint, and also an iter method so that you can easily fetch all values in one go.

Ttttest https://trello.com/c/dmlGGCAG/467-spike-searching-g-cloud-for-test-and-testing-gives-different-results


[bug] downloaded music can not be played back after a while of offline usage

Caching of albumart fails, downloaded music doesn't play anymore

Could not reproduce


Clean up BSPs

Gets them all to a 0.1.0 release.
You might want to do https://github.com/rp-rs/rp-hal/issues/244 instead (but at least they're in a state where they can be separated out fairly cleanly).

If we're publishing it, pico seems like something we should avoid claiming? -- too generic of a name.

I hadn't considered that, but also since it's generic and short it is also already taken.
https://crates.io/crates/pico

I did wonder if I should rename pico. We probably should. raspberrypi-pico or raspberry-pi-pico?

Oh one more thing I thought about but haven't yet done - should the crate owners all be reset to "The rp-rs Developers"?

I like raspberrypi-pico more, don't really need another dash to disambiguate.

should the crate owners all be reset to "The rp-rs Developers"

Owners in which respect? If you mean the authors field in Cargo.toml that's fine by me, would be good to get quorum before doing that though.

What about rp-pico?

What about rp-pico?

OK, that does have a certain consistency to it.

Oh one more thing I thought about but haven't yet done - should the crate owners all be reset to "The rp-rs Developers"?

@ithinuel
@hmvp
@eolder
@onnenon
@anall
Are you happy I reset your BSP crates to have an author of "The rp-rs Developers" in the relevant Cargo.toml files?

I noticed that a few of the BSPs have dependencies they don't use. For example adafruit-macropad depends on cortex-m even though it does not import anything from it. Is that intentional? If not maybe cleaning that up should be included in this PR.

This PR has been merged but I'd be happy to see one that trims dependencies down the minimum set required.


Fall back to login as display name when we have it

Details

Updates getDisplayNameForParticipant to fall back on the login when we have it. Also updates the Typescript types to account for the potential of the display name not being set.
Fixed Issues

https://github.com/Expensify/App/issues/31312
Tests

Set the app to force offline
Click + > start chat
Type an email address of someone you don't know and have never chatted with before
Create the chat
Click + > start chat again
Type the same email address
Verify that they show up in the search results with their email address as their display name and not "hidden"

[ ] Verify that no errors appear in the JS console

Offline tests

Same as tests.
QA Steps

Same as tests.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@puneetlath I see that the issue is not linked correctly ($ is missing).
Does that mean that this PR doesn't fully fix https://github.com/Expensify/App/issues/31312?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/ce3566d8-2bef-4429-bb06-0aac8ffcd63b

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/f105790d-279f-4cef-86ed-a789b2403fed

iOS: Native
https://github.com/Expensify/App/assets/108292595/bc363510-1b49-47ff-bc2f-ca88c33cde69

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/5dcd5d96-1b83-439f-aea4-15704bdec3ef

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/b7e74a18-6cba-4b4c-b414-783079712c9e

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/4df3bfa5-aba7-4b5a-8d57-78b56e3b0415

Please just complete author checklist as the fix doesn't depend on platforms. Though I tested all platforms including android.

@puneetlath I see that the issue is not linked correctly ($ is missing).
Does that mean that this PR doesn't fully fix https://github.com/Expensify/App/issues/31312?

That's correct, it's just part of that issue, not the complete fix.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Added Operator support for Partitioned HashJoin.

Assigned to @hbdeshmukh or @jianqiao.
This PR allows HashJoin to accept partitioned info. If no partition, num_partitions is 1.

LGTM. Merging.


Args are being ignored by pytest config: impossible to run ipdb even with -s

Environment data

VS Code version: 1.41.0
Extension version (available under the Extensions sidebar): 2019.11.50794
OS and version: MacOS 10.14.6
Python version (& distribution if applicable, e.g. Anaconda): 3.7.5
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Relevant/affected Python packages and their versions: pytest 5.3.1
Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): Language Server

Expected behaviour
I'm aware that if I want to use ipdb (import ipdb; ipdb.set_trace()) when I run tests using pytest I have to run pytest with -s option, like: pytest -s. So I have enabled this args in pytest configuration unders VSCode.

When I run my test using the test UI of VSCode, I expect IDE to drop me into an ipdb shell, just like it happens if I run pytest -s from the VSCode terminal.

  Consider using `-s`."
        )
E       OSError: pytest: reading from stdin while output is captured!  Consider using `-s`.

Which is "curious" because it's exactly what I have enable in the Pytest Args.
Steps to reproduce:

Configure VSCode to run the tests with pytest and add the -s arg
Implement a simple test which can run from the UI
now place an ipdb breakpoint somewhere in the test: import ipdb; ipdb.set_trace()
run the test from the UI: the output will be similar to the one posted above

Unfortunately that is not supported as part of the Test Explorer. If you want to use ipdb specifically you will need to continue to use the terminal to execute. An alternative is to launch your tests using the included debugger in the extension which will run the tests in debug mode.


0.2.2 was never released

It appears 0.2.2 was never released (The removal of debounced)

OBE now that 0.2.3 has been released to npm.


Support negative column index for Slot

Yup, nice one. Happy for this to be included under the MIT license (as simple a change as it is, I should probably still ask!)?

Yup, nice one. Happy for this to be included under the MIT license (as simple a change as it is, I should probably still ask!)?

Of course. Happy to contribute.


[iOS] add playground

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.剑涵 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Update browser version.

This should fix a problem with formatting on the main page and adds a consent message.
I'll be rebasing and updating this again soon.

GitHub actions failing for some reason, will check it out..

not sure why all the test faield...but I tested this out on dev terra, and things are working great..so going to merge this PR as is and we can have a ticket about fixing the CI for this repo


Doesn't seem to function correctly on Windows 10 21H1

BasicThemer2 completely breaks the title bars of file explorer windows making them completely transparent and effectively removing the ability to close them as the buttons are also removed as well. This likely has something to do with a change in the way explorer.exe works in the newest version of Windows 10.

IT IS NOT FIXABLE a solution to this would be to exclude explorer.exe and install secure UX theme and use Aero7 Basic theme then you will get the Basicthemer2 title bars for all other programs but the the aero 7 title bars for windows explorer and control panel

IT IS NOT FIXABLE a solution to this would be to exclude explorer.exe and install secure UX theme and use Aero7 Basic theme then you will get the Basicthemer2 title bars for all other programs but the the aero 7 title bars for windows explorer and control panel

does secure UX theme and the Aero themes actually work on the latest version of Windows 10 though? At least as far as I knew those haven't been updated since like 2016

IT IS NOT FIXABLE a solution to this would be to exclude explorer.exe and install secure UX theme and use Aero7 Basic theme then you will get the Basicthemer2 title bars for all other programs but the the aero 7 title bars for windows explorer and control panel

does secure UX theme and the Aero themes actually work on the latest version of Windows 10 though? At least as far as I knew those haven't been updated since like 2016

It doesn't work on Uxstyle Patcher but it works Great on secureUXtheme Patcher the buttons are kinda big though so I set the title bar size to 20 in winaero tweaker


feat(frontend): filter repositories that has no issue

Resolve on issue #56
Here i filtered the repository list only showed repositories that has issue
Before
There is showed rosetta and manusier repo that has no issue

After

bump, siapa tau lupa

Hello there. I'm gonna close this issue as we'll rewrite the repo soon enough.


Poor performance when focus changes

Setup:
Arch Linux
hyprland-git r2982.e1edfde5-1
i9-11900H CPU/GPU
4k60 display
Steps to repro:
Enable the debug overlay
Open two windows
Switch focus
Result:
Watch FPS drop significantly for a few seconds
Expected result:
FPS maintains constant 60Hz
Additional info:
It seems to be bound on the GPU here, but I don't think it's maxxing out the GPU...looking at intel_gpu_top, when spamming focus changes, GPU usage is around 88%, but for some reason it's only running at 500 MHz, with a max stated as ~1500MHz--so it seems like the GPU isn't clocking up correctly or something like that?
When just sitting on a desktop running a Firefox instance, intel_gpu_top and htop in terminals, Hyprland uses ~38% CPU (htop numbers, so 100% means ONE core fully utilized). When spamming switching focus, it goes down to 10%, likely b/c waiting on the GPU.
It seems like switching focus shouldn't be such a GPU intensive task, and it seems like my system has the headroom to work much nicer if the GPU were able to clock up properly.
Given the GPU clocking stuff, this may be a driver bug of sorts, or at least partially?
In general performance on this 4k display is pretty poor with this GPU, and it's pretty smooth in Windows and it's very smooth running 1x 1440p60 + 1x 1440p144, which is more pixels per second, so something particular to the 4k case seems to be happening?
Maybe related to https://github.com/hyprwm/Hyprland/issues/2305 also

sir gpus dont work like that
do you have any animations playing when you do that? what if you set animations:enabled to 0?

gpus dont work like that

Which part lol?

what if you set animations:enabled to 0?

Same result

I have Arch with the latest git build from today.
i7-10750H
also 2x4k display
and if I switch windows my intel_top shows me an increase in the GPU frequency.
Can you check if your device is connected to AC and check the CPU governor or if you have any power saving settings/tools active.

Yes, connected via AC and using the powersave governor (as suggested https://www.gfxstrand.net/faith/blog/2020/11/getting-the-most-out-of-your-intel/ -- apparently it gives more of the power budget to the GPU).
Here's a little screenrecording--performance is obviously impacted by screenrecording--seems to be ~10FPS difference.
https://github.com/hyprwm/Hyprland/assets/7105082/70f60a2e-fc4a-46bd-a4c2-7f58d634d1e1
It seems very strange to me that the performance is SO bad, and that the GPU is clocked down so much...

I can confirm, that I could replicate that, but in my case it was just dropping to 30fps for a short period of time and increased slowly to 60fps.
When I tested setting the GPU frequency to max (for my iGPU)
echo 1150 | tee /sys/class/drm/card0/gt_min_freq_mhz
the FPS stayed constant at 60 there was no way it would drop.
So my guess is that other projects are rendering more often or deliberately to keep the freq higher (it's a guess, haven't compared yet).
My nvtop result shows that there are frequency drops even if I continually switch focus

does this happen on sway too? maybe its just the app redrawing itself or something?

I collected a bit of data with a simple setup:
1x4k60 display
i9-11900H CPU/GPU
this on the display:

WM
freq setting
FPS
GPU Clock speed (MHz)
GPU Utilization

sway
-d
60
414
23%

sway
-m
60
870
16%

Hyprland (overlay ON)
-d
30*
480
52%

Hyprland (overlay ON)
-m
60**
1410
50%

Hyprland (overlay OFF)
-d
60**
550
85%

Hyprland (overlay ON)
-m
60
1205
38%

I first did all the tests with the debug overlay on, then re-did them after I realized it makes a significant performance difference
*: oscillates between 30 and 60, spending probably 90% of time in 30FPS
**: misses exactly one frame per second (don't mind the bit at the end, that was from the screenshot tool)

I pushed some commits to master, can you check the window switching perf issue?

I pushed some commits to master, can you check the window switching perf issue?

I rebuilt it with the current commit and tested it.
As soon as wf-recorder is activated, it drops to 18 fps

thats a separate thing, we're talking about the "when focus changes" here.

thats a separate thing,
missing screencopy-dmabuf?

we're talking about the "when focus changes" here.
yeah, with disabled animations the FPS looks promising when switching between windows.
Stays above 55 FPS no matter how fast or what windows I switch (before drops down to 30fps).

@russelltg what is your experience??
@vaxerski from my side a big thanks to you

Also maybe related to #2484, cause in my case gpu clock also not rising properly and stays on 300MHz and cause fps drops.

based on reports from @romanstingler I am closing this as complete.
Poor performance of screencopy can be opened as a separate issue.


Fix a bug when setting StringConstraint(strict=False)

Change Summary

This PR fixes a bug when setting StringConstraint(strict=False). It was in fact setting the schema to strict=True.
This change was initiated as a test code coverage improvement, but while creating the test, I spotted this bug.
Related issue number

Contributes to #7656 .
Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[x] Unit tests for the changes exist
[x] Tests pass on CI
[x] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review


Fix gulp ECMDERR on older node, by forcing plato to 1.4.*

plato 1.6.0 recently came out, and brought in a dependency on strip-bom 3.0.0 (via eslint), which needs node 4+
This forces plato to 1.4.0 which has no such dependencies.
This needs to be darga/yes because build failures..