UWP - AmbiguousMatchException thrown when binding TextBlock.Text property to the property which exists in both base and derived class

Describe the bug
I have a property in same name in both base and derived class with different data type. When binding the property to TextBlock.Text property, exception occurs while binding itself.
NOTE: Exception is throwing only in UWP. But works fine in WPF.
Steps to reproduce the bug
BindingCode:
MyData myDataObject = new MyData(DateTime.Now);
Binding myBinding = new Binding();
myBinding.Mode = BindingMode.TwoWay;
myBinding.ConverterParameter = null;
myBinding.UpdateSourceTrigger = UpdateSourceTrigger.Default;
myBinding.Path = new PropertyPath("MyDataProperty");
myBinding.Source = myDataObject;
myBinding.ElementName = myDataObject.MyDataProperty;
textBlock.SetBinding(TextBlock.TextProperty, myBinding);

Model:
public class data
{
    public int MyDataProperty { get; set; }
}

public class MyData : data
{
    private string myDataProperty;

    public MyData() { }

    public MyData(DateTime dateTime)
    {
        myDataProperty = "Last bound time was " + dateTime.ToLongTimeString();
    }

    public new String MyDataProperty
    {
        get { return myDataProperty; }
        set
        {
            myDataProperty = value;
            OnPropertyChanged("MyDataProperty");
        }
    }

    public event PropertyChangedEventHandler PropertyChanged;

    private void OnPropertyChanged(string info)
    {
        PropertyChangedEventHandler handler = PropertyChanged;
        if (handler != null)
            handler(this, new PropertyChangedEventArgs(info));
    }
}

Run the sample.
Expected behavior
Exception not occured.
Screenshots

I could not get this sample to produce an AmbiguousMatchException on latest insider. It either gave no errors (but also didn't work) if I did it from XAML and from code-behind it was giving a debug output error:
Error: BindingExpression path error: 'MyDataProperty' property not found on 'App1.MyData'. BindingExpression: Path='MyDataProperty' DataItem='App1.MyData'; target element is 'Windows.UI.Xaml.Controls.TextBlock' (Name='textBlock'); target property is 'Text' (type 'String')

@SaravananAyyanar can you provide the version of Windows you're running against and a more complete sample?
I'm also confused by the setting of "myBinding.ElementName" in the repro, why is that being used?

complete sample:
UWPArgumentException.zip
ScreenShots:

I have tested latest version and also other version, but exception thrown when run the sample and also output window shown the  error,
Error: BindingExpression path error: 'MyDataProperty' property not found on 'App1.MyData'. BindingExpression: Path='MyDataProperty' DataItem='App1.MyData'; target element is 'Windows.UI.Xaml.Controls.TextBlock' (Name='textBlock'); target property is 'Text' (type 'String')

Any update on this query ?

Sorry for the delay, we'll debug and take a look. That said, this is probably just an accidental difference between the XAML binding behavior and the WPF binding behavior.
Is using x:Bind an option for you?

We are binding the property in code behind for our internal purpose. So, x:Bind is not an option for us. We needs this bug to be fixed.

@SaravananAyyanar, thank you for reporting this issue around Binding. Chances are that this bug requires framework changes and since that portion has not been open sourced just yet, we won't be able to give you a speedy update. Second, Microsoft's investment has been in x:Bind for the last few years, we see x:Bind as a much better alternative to Binding.

I encourage you to unblock yourself by switching to x:Bind. Let us know if you need any help with that.
We'll keep track of this bug and once the framework portion is open sourced, we can look into fixing it.

@fabiant3 ,can you provide the code for x:bind in code behind as mention above.
We are binding in code behind for our internal purpose. We needs this bug to be fixed.

Any update regarding this?

@SaravananAyyanar - there are no planned changes to Binding at this moment, the investments we have been making for years now are all in x:Bind. Even if we were to make changes to support this scenario in Binding, there is no vehicle to deliver that since it requires framework updates and that code is not open sourced (yet).
I recommend making changes to your code, so you can support x:Bind and/or wait until the code becomes open sourced.


Switch to fb webdriver

Why closing the PR ?

Why closing the PR ?

Because nobody noticed upfront that Facebook's version of WebDriver requires PHP 5.5+ to run. Since Mink/Mink Driver require PHP 5.3+ to run we have no way to use it.

Well, as PHP 5.3 and 5.4 are EOLed, dropping support for them could be acceptable if we have some benefit when doing it (switching to a maintained library).
The previous PR dropping it for Mink was dropping support with no benefit for us. Here, it could have one.
Some drivers may drop support for older PHP versions (the third-party phantomJS driver does not support PHP 5.3 btw)

Here, it could have one.

Switching one dependency for another, while both work at the end is no benefit to me. Fact that one dependency is better maintained than another one doesn't really change the fact that both work.

@aik099 actually there are many limitations on the instaclick version that are not present on the facebook one. Off the top of my head I can remember the iframe manipulation bit, for instance. On instaclick/php-webdriver you can only change iframes based on it's id, whereas in facebook/php-webdriver you can use the id, name or an WebDriverElement

Off the top of my head I can remember the iframe manipulation bit, for instance.

This particular change isn't a problem, because public API of Mink supporting locating frames by name only anyway.
Since Instaclick version covers 100% of functionality needed to implement the driver it doesn't really matter at this point if we switch to FB at all.

Some other reasons:

maintained library is possibly faster and in case of performance/bug/security issues, there's a higher chance of a patch
the FB library takes care of things like handling uploads and other stuff that is unnecessarily replicated in MinkSelenium2Driver.

That said, I gave up arguing here.  No trouble at all if the main one is stagnant and becomes obsolete, we'll just move forward using yours.

I see you're eager to change stuff even though it works as expected for years now. I'm not here to judge how you should spend your time, but in your place I won't be spending time on doing anything that won't result in any kind of gain.
In this case I don't see any actual gains except FB library is more maintained than Instaclick one. There can't be any possible performance gain, because both FB and Instaclick are doing remote calls using WebDriver protocol, where speed is result of how fast we get a response and not how fast library can process it.

Seems instaclick does not officially support Selenium 3.x, am I right?
Therefore, if a library is still active (facebook) and the other is not, plus does not supports officially Selenium 3.x, why shouldn't we change this dependency?
Moreover, if it's a question of BC and minimum PHP version, it's also our duty to make all this community evolve. Even 5.6 is not actively supported anymore. People with previous PHP versions will still have older versions of MinkSelenium2Driver.


release: v1.0.0a2

Signed-off-by: Jiri Kuncar<EMAIL_ADDRESS>

Coverage remained the same at 99.526% when pulling 80bf766b68f10016997e117971426df2ebb660b3 on jirikuncar:release-v1.0.0a2 into a7ffb89b50032e7e952737acc626d3b005f7370f on inveniosoftware:master.


OSError: [Errno 24] Too many open files

When I run the main.py with the recommended arguments python main.py --method fedalign --client_number 16 --thread_number 16 --comm_round 25 --lr 0.01 --epochs 20 --width 0.25 --mu 0.45 --data_dir data/cifar100, I got the following error. It happened after finishing the first local iterations of client0.
INFO:root:************** Round: 0 *************** INFO:root:(client 0. Local Training Epoch: 0 	Loss: 1.819505  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 1 	Loss: 1.794823  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 2 	Loss: 1.775222  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 3 	Loss: 1.754200  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 4 	Loss: 1.732598  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 5 	Loss: 1.710265  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 6 	Loss: 1.688822  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 7 	Loss: 1.668204  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 8 	Loss: 1.649973  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 9 	Loss: 1.634276  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 10 	Loss: 1.618046  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 11 	Loss: 1.605212  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 12 	Loss: 1.592514  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 13 	Loss: 1.579208  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 14 	Loss: 1.568651  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 15 	Loss: 1.559061  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 16 	Loss: 1.548159  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 17 	Loss: 1.538477  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 18 	Loss: 1.529025  Thread 1  Map [0] INFO:root:(client 0. Local Training Epoch: 19 	Loss: 1.520388  Thread 1  Map [0] INFO:root:************* Client 0 Acc = 31.51 ************** Traceback (most recent call last):   File "<input>", line 1, in <module>   File "/home/server1/.pycharm_helpers/pydev/_pydev_bundle/pydev_umd.py", line 197, in runfile     pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script   File "/home/server1/.pycharm_helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile     exec(compile(contents+"\n", file, 'exec'), glob, loc)   File "/media/server1/ef9c36bf-023a-4a24-9852-c85fbc39a794/zhuhuixiang/python_Project/FedAlign-main/main.py", line 234, in <module>     client_outputs = pool.map(run_clients, server_outputs)   File "/home/server1/anaconda3/envs/zhuhuixiang/lib/python3.7/multiprocessing/pool.py", line 268, in map     return self._map_async(func, iterable, mapstar, chunksize).get()   File "/home/server1/anaconda3/envs/zhuhuixiang/lib/python3.7/multiprocessing/pool.py", line 657, in get     raise self._value   File "/home/server1/anaconda3/envs/zhuhuixiang/lib/python3.7/multiprocessing/pool.py", line 431, in _handle_tasks     put(task)   File "/home/server1/anaconda3/envs/zhuhuixiang/lib/python3.7/multiprocessing/connection.py", line 206, in send     self._send_bytes(_ForkingPickler.dumps(obj))   File "/home/server1/anaconda3/envs/zhuhuixiang/lib/python3.7/multiprocessing/reduction.py", line 51, in dumps     cls(buf, protocol).dump(obj)   File "/home/server1/anaconda3/envs/zhuhuixiang/lib/python3.7/site-packages/torch/multiprocessing/reductions.py", line 327, in reduce_storage     df = multiprocessing.reduction.DupFd(fd)   File "/home/server1/anaconda3/envs/zhuhuixiang/lib/python3.7/multiprocessing/reduction.py", line 194, in DupFd     return resource_sharer.DupFd(fd)   File "/home/server1/anaconda3/envs/zhuhuixiang/lib/python3.7/multiprocessing/resource_sharer.py", line 48, in __init__     new_fd = os.dup(fd) OSError: [Errno 24] Too many open files.
It seems that something is wrong when calling the 'pool.map' function to enable multi-threaded acceleration. Moreover, the version of torch used is 1.2.0 due to the limit of the old CUDA version. Thanks!

I have solved it by adding "torch.multiprocessing.set_sharing_strategy('file_system')" to the main.py. Using the file_system strategy, the CUDA tensor is transferred directly between processes to avoid excessive file descriptor generation.


⚠ Bofrost.at has degraded performance

In 7ce933e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 816 ms

Resolved: Bofrost.at performance has improved in 42e000e after 34 minutes.


Added async file read to executescript

Added async file reads as suggested in https://github.com/Carberra/Carberretta/issues/86
P.S. First aiofiles branch was made from wrong git commit and included non-related changes so I re made the branch

This has already been addressed in #91.


Map customizations

Map customization

ability to overlay destinations
ability to overlay roads
use buckets (quintiles) for population size
add legend for population size

Wrong repo. This is now being tracked in the frontend repo: https://github.com/WorldBank-Transport/rra-frontend/issues/127


RCIAM-1107 VO admin web services for group members

I have removed only addOrRemoveVoAdmin method. As we disgused GroupAdmins will be seperate table from group members.
I keep email templates for adding / removing in order to be used lately.


Question: why are 'max-width' and 'width' equal on .container?

I understand the max-width, but doesn't also setting a fixed width (to an equal pixel value) make the e-mail effectively fixed-width? Or is this some kind of workaround/hack?
/* Set a max-width, and make it display as block so it will automatically stretch
to that width, but will also shrink down on a phone or something */
      .container {
        ...
        /* makes it centered */
        max-width: 580px;
        width: 580px;
      }

In the smashingmag article you do use a percentage value;
.container {
  max-width: 600px;
  width: 100%;
}

Definitely a hack, but I forget why exactly. Likely to do with a version fo Outlook. Curious if you run into this issue or not.


csbms-parser release

I noticed the latest release available for download is two commits behind the master branch.
The only remarkable change I found is that Bemusilization was replaced with csbms-parser.
Is there a reason why a new release wasn't made after that change?
Do you think csbms-parser is less reliable?

as we all known that csbms-parser is porting project from java project named "jbms-parser"
I had finished porting but there is some bugs to solve and I have no time to debug at that time
So I didnt publish a new release after porting.
for example this bms

done , have a try
https://github.com/MikiraSora/BmsPreviewAudioGenerator/releases/tag/v0.8.8

Hey, thanks!
Sorry for the super late reply.


Adding Github homepage clone

Project title
Github homepage clone
Project Description
Making a clone of Github's homepage on dark theme, I may add search functionalities to it using JS if applicable.
Stack:

[x] Html
[x] CSS
[x] JavaScript

@khushi-purwar May I get the level label assigned on this one?

@khushi-purwar may I have the level label assigned on the PR too?


Pretrained Coco Weights

Can you share pretrained weights(trained on coco dataset)? I would like to perform finetuning using pretrained coco dataset weights and my own dataset. Converting other models(caffe etc.) seems like not entirely performable and there are other converting issues. So I will be glad if you share pretrained pytorch model on coco dataset.@jwyang

Actually, I have the same request. I also want to finetune pretrained coco or pascal voc weights with my own dataset. Thanks in advance !

you guys already got the pretrained model on coco, right?

No we didn't. We trained the model with coco from scratch.
On Fri, 29 Jun 2018, 04:09 Jianwei Yang<EMAIL_ADDRESS>wrote:

you guys already got the pretrained model on coco, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jwyang/faster-rcnn.pytorch/issues/138#issuecomment-401217927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AN-KMXpzCbXLeRgwCkHi557tLGGjVFTzks5uBX42gaJpZM4TghIj
.

@artuncF sounds good. Actully, you can download them from the links in readme.

let me know if you have any further issues, I am closing this issue now.

So the links for the pertained model on COCO is the one given in the README file?


Setting a default value for the --receipts-show-limit flag on release-notes action

Summary

This PR fixes below issue:

https://github.com/paketo-buildpacks/jammy-full-stack/issues/14

Practically, the default value for the --receipts-show-limit flag that the action passes is an empty string, which does not convert to a number. In that case, it needs an extra check if it is an empty string or not, the same pattern we apply to the other flags/variables.
Use Cases

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@robdimsdale @mhdawson


[Event Change Request] Table 36 Sales Header - Procedure UpdateShipToAddressFromSellToAddress

Dear ALAppExtensions Team,
We would like to request the following change
local procedure UpdateShipToAddressFromSellToAddress(FieldNumber: Integer)
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeUpdateShipToAddressFromSellToAddress(Rec, FieldNumber, IsHandled);
    if IsHandled then
        exit;

    if ("Ship-to Code" = '') and ShipToAddressEqualsOldSellToAddress then begin
        case FieldNumber of
            FieldNo("Ship-to Address"):
                "Ship-to Address" := "Sell-to Address";
            FieldNo("Ship-to Address 2"):
                "Ship-to Address 2" := "Sell-to Address 2";
            FieldNo("Ship-to City"), FieldNo("Ship-to Post Code"):
                begin
                    "Ship-to City" := "Sell-to City";
                    "Ship-to Post Code" := "Sell-to Post Code";
                    "Ship-to County" := "Sell-to County";
                    "Ship-to Country/Region Code" := "Sell-to Country/Region Code";
                end;
            FieldNo("Ship-to County"):
                "Ship-to County" := "Sell-to County";
            FieldNo("Ship-to Country/Region Code"):
                "Ship-to Country/Region Code" := "Sell-to Country/Region Code";
        end;
        **//--> change request
        OnAfterUpdateShipToAddressFromSellToAddress(Rec, xRec, FieldNumber);
        //<-- change request**
    end;
    **//--> change request cancel old
    //OnAfterUpdateShipToAddressFromSellToAddress(Rec, xRec, FieldNumber);
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47054.


For some text samples, Lingua-go detected the wrong language, but Lingua's results were correct

examples:

texts
lingua-go
lingua

Chắc tại có +18:)?
Malay
VIETNAMESE

Thanks @hwdlei for letting me know. I'm going to work on lingua-go now anyway, so I will investigate if and how the detection result differ between the JVM and the Go version.

Hi @hwdlei, I was finally able to find the cause of the problem. So this will be fixed in the next release 1.1.0.


Force high bitrate for incoming video

Hi,
I'm using a modified version of the broadcast example to achieve just that in an production environment, is there a way to force a high bitrate for incoming video ?

RTCRtpSender.sendEncodings with maxBitrate can be used to control it somewhat. However, browsers will typically use available bandwidth estimates and other network signals to adjust the bitrate on the fly.
In my experience browsers will default to about 2.5Mbps for video streams but then adjust downwards if the network conditions aren't sufficiently good

i see, i'm already doing that, at 10Mbits, depending on the device the video and audio is still very compressed, i was wondering if there is a way in sdp or something else withg server side hackery

I'm not sure. I think there's some SDP attribute that might help. Also worth checking chrome://webrtc-internals which will contain information about target bitrate and constraints that are causing the bitrate to not be as high as you want(assuming you are using a browser to send)

So with further usage it looks like the bitrate is high enough with the setEncoding max bitrate, the rest is generally bound to the available bandwidth or encoding performance. Closing for now.


Wrong positioning of popover on IOS

Problem Description
Popover doesn't seen on IOS when I type in Autocomplete field.

I guess I found why.

When I start to interact with other parts of application, the popover flies from top.
I found that div with popover has wrong position. For example: the text field has absolute offset position 916px and popover has top: 294px;.
I think that in IOS position:fixed has different behavior, positioning starts from top of the page, not of the screen.

Versions

Material-UI: v0.15.0-alpha.1 and latest from github
React: 0.14.7
Browser: Safari 8 / ios 8.2

I was facing this problem on one of my projects. http://stackoverflow.com/questions/7970389/ios-5-fixed-positioning-and-virtual-keyboard . Shortly: fixed elements scrolls in iOS browsers, then virtual keyboard is opened. Moreover, devs from Apple keep this behaviour at least in a 5 iOS versions in a row. So probably it's a feature and they aren't going to fix it. I can envestigate, how to solve this in popover, if you want.

To override this behavior I check if it's IOS and if true I get offset().top instead of anchor element bottom position.
I use jquery and device.js because deadline
getAnchorPosition(el) {
    if (!el) {
      el = ReactDOM.findDOMNode(this);
    }
    const rect = el.getBoundingClientRect();
    const a = {
      top: rect.top,
      left: rect.left,
      width: el.offsetWidth,
      height: el.offsetHeight,
    };
    const offsetTop = window.jQuery(el).offset().top;
    a.right = rect.right || a.left + a.width;
    a.bottom = (device.ios()?offsetTop + a.height:rect.bottom) || (device.ios()?offsetTop:a.top) + a.height;
    a.middle = a.left + ((a.right - a.left) / 2);
    a.center = a.top + ((a.bottom - a.top) / 2);
    return a;
  },

Sorry, missed by clicking on the button :)

I just don't understand, why popover has position: fixed initially. It handles page scroll and changes top directly, but if it will has position: absolute instead - this issue and necessity to handle scroll will gone.

I don't mention, that this will not solve this issue, because layer itself has position: fixed. So i'll close the PR. So the only way which I see is to not using layer for popover or to set the positioning of layer to absolute, when popover use it.

#3144 sorts this - we had the same issue - has become a little distracted...

Got the same issue without the virtual keyboard

@newoga check this one out too RE Popover

Is there any progress? The documentation site on version 0.15.0 has the same issue.
React 15.1.0
IOS 9.3

+1
@w01fgang I tested your solution and it works. The downside is that I would have to maintain a fork of material-ui and include jquery to make it work. Have you found a way to get the offset without jquery?

@nsantini yes I have the way.
First of all I use react-boilerplate and for that fix I only need to take Autocomplete and Popover components, so I don't need to make a fork.
Here's the folder structure:
components
containers
material-ui/
     Autocomplete
     Popever
tests
...

And here's the function for finding needed position:
getOffsetTop (elem) => {

    let yPos = elem.offsetTop;
    let tempEl = elem.offsetParent;

    while ( tempEl != null )
    {
        yPos += tempEl.offsetTop;
        tempEl = tempEl.offsetParent;
    }

    return yPos;
}

@w01fgang legend!

could we make a PR with this code?

+1

I'm missing something but I can't get the fix to work. I tried using your Material UI branch @w01fgang but that didn't work either. Top position is still incorrect.
That's my autocomplete:
        <AutoComplete
          {...this.props}
          dataSource={this.state.dataSource.map((item, index) => {return item.label})}
          filter={(searchText: string, key: string) => true}
        />

Am I missing something ?
Thanks so much

@Taakn can you show the output of device detection helper?
import Device from 'material-ui/utils/device';
console.log(Device);

@w01fgang Thanks for your reply. I'm actually getting Error: Cannot find module 'material-ui/utils/device' so something is wrong with my configuration.
My package.json looks like this, is that correct ? Otherwise what would be the best way to get your solution ?
"material-ui": "git+https://github.com/w01fgang/material-ui.git#fixPopoverIOS",
Thanks again

@Taakn When you install from git repo, it installs in folder 'material-ui-build'
"material-ui-build": "github:w01fgang/material-ui#fixPopoverIOS",

Otherwise it doesn't installs.
Than you need to include it from material-ui-build
include AutoComplete from 'material-ui-build/AutoComplete'

Hi @w01fgang thanks for your help.
When doing an npm install I am getting an unmet peer dependency  error (I am using<EMAIL_ADDRESS>and your package requires 0.16.0-alpha ?) but I'm not sure that would really matter.
However I am getting an Uncaught Error: Cannot find module 'material-ui-build/AutoComplete' error. When I attempt to just require('material-ui-build') my application doesn't start at all.
Do you know what could be the problem ? Please let me know if you can think of anything else.
Thanks again

@Taakn sorry, my mistake. Maybe I need to sleep more 😄
Using github's version isn't simple. In npm package the material-ui is transpiled by babel, but in the github it is not. For example in my webpack config babel ignores all from node_modules folder and simple importing from material-ui-build doesn't work.
I think you can copy Popover and Autocomplete components and make a little change to them

Thanks @w01fgang it took a little bit of work but it's working. It's interesting but my desktop Safari is sending the iPhone user agent when I'm debugging. Anyway thanks again!

I was digging into that PR last weekend.
I realized that the root of the issue is the iOS browser messing around with fixed positioned elements when an input is focused.
It seems that the proposed fix (#4638) is only working fine in that context but breaking the others.
I believe that the only way to solve that issue is to expose a property to enable / disable the fixed positioning.
Any thoughts?

The problem is in the fixed positioning in IOS.
The getBoundingClientRect() method on IOS returns values different from the others.
I have made this fix more than a year ago and I successfully use it.
Maybe doing refactor on the PR #4638 I broke some thing, but I don't think so, it should work.

There still are some issues on mobile. It seems to be related to the scroll position:

There still are some issues on mobile. It seems to be related to the scroll position:

That's the expected behavior on a simulator. Please try it on a simulator.

@PhilippSpo 's issue reproduced for me on a real device too

I'm also experiencing this issue on iOS 10.3.1 in Safari and Chrome. It's happening on the documentation site like @PhilippSpo 's example, but the Popover is appearing so far down that it's off the screen of my iPhone 6 so I can't even see it. Something seems to have changed since #4638 was implemented.

I am also experiencing this issue– it's specifically related to scroll on mobile screens.  I see it occurring in my Chrome devices view.

For what it's worth, this doesn't seem to happen when you use the down key to enter the popover menu.  As far as I can tell it seems to be directly related to the focusTextField piece of state.  When it's set to false things seem to work.  I tested this by setting it to false in handleChange(), and while I was not able to continue typing in the textfield, the popover did appear in the right place.
I wonder if it has something to do with the timing of setting the anchorEl when focus changes.

More info!
I am able to correct the issue on actual devices when the components live in a scrolling body.  Originally they were in a scrolling div.  Once they live as part of the scrolling body the bug appears in the Chrome devices tab but not in the iOS simulator, which is good enough for now!
TLDR when there's a focused text input in a scrolling container, and that container is scrolled, the autocomplete's popover appears where it would if the div were not scrolled.

@devinivy are you saying you have a fix for this?  if so, please share! ;-)

My fix was to ensure the autocomplete field wasn't scrolled within a scrolling div.  Instead I recreated the layout of my page to have a scrolling body.  Originally the layout consisted of a full-height div that scrolled, which is what seems to have triggered the issue.

@devinivy  Geez, I cannot use your fix :/
Plus, on chrome device view, the dropdown seems to be fixed. No matter how scrolled down I am it appears in the same place, so I'm confused by your analysis... :(

Closes by #7333 but #5544 remains.

In some cases canAutoPosition: false prop can help you


Cant login into corporate repos at bitbucket

Hi. I can't login into corp repos at bibtbucket.
<EMAIL_ADDRESS>What info do you need to investigate this?

Hi,
did you use the "Add Remote Account" dialog?
Did you enter there the username or the mail address?

Just tried

Thanks!
I tried just once connecting to a bitbucket server and there I used ssh maybe you can consider this in the meantime?

Sorry, cant do ssh. Only https.
( Switched to Aurees. It logins swiftly )

Sorry for the inconvinience, the problem is I am not able to test it right now.

@MikeKholomeev can you try to change the bitbucket url?

@MikeKholomeev can you try to change the bitbucket url?

What do you mean? Change how?

BitBucket on prem and cloud have different APIs and are therefore incompatible with each other
We'd have to implement support for BitBucket Server, which will take quite a bit of work
However, you can still clone, fetch and push using git remotes with HTTP URLs - just having a list of available repositories for your account won't be available

BitBucket on prem and cloud have different APIs and are therefore incompatible with each other We'd have to implement support for BitBucket Server, which will take quite a bit of work
However, you can still clone, fetch and push using git remotes with HTTP URLs - just having a list of available repositories for your account won't be available

I tested dozen git clients with the same Bitbucket corp repos - all connected successfully....except Gittyup. It cant fetch, clone etc.

What do you set in those applications?

Just usrrname and password?

Just username and password?

Yes

What messages show up in the log at the bottom of the window when trying to fetch?

After 5-7 consequent attempts:
 Unable to fetch from 'origin' - remote error: CAPTCHA required

Your Bitbucket account has been locked. To unlock it and log in again you must
solve a CAPTCHA. This is typically caused by too many attempts to login with an
incorrect password. The account lock prevents your SCM client from accessing
Bitbucket and its mirrors until it is solved, even if you enter your password
correctly.
If you are currently logged in to Bitbucket via a browser you may need to
logout and then log back in in order to solve the CAPTCHA.
Visit Bitbucket at https://stash.cengage.com for more details.

During that unsuccessful attempts  - no messages were at the bottom part of the app window

Could you start Gittyup with the command line parameter --debug-menu and enable the Options "Log Remote Connection" and "Log Credential Helper"
The fetch once with your account unlocked and send us the files %LOCALAPPDATA%\temp\Gittyup\remote.log and %LOCALAPPDATA%\temp\Gittyup\cred.log after censoring sensitive information

Only one file there - cred.log

Looks like it could be a problem with the credhelper
Since we're having holidays in germany, so i'll be able to look into this on tuesday

@MikeKholomeev Can you try with the development build

@MikeKholomeev Can you try with the development build

Downloading...

Same behavior.
And no log files at %LOCALAPPDATA%\temp\Gittyup\

Is your credential helper set to manager?

Try setting it to manager, Microsoft renamed it from manager-core

Try setting it to manager, Microsoft renamed it from manager-core

I don't have such a selection in the dropdown menu. Only - cache, store, wincred

Try setting it to manager, Microsoft renamed it from manager-core

Simply deleted -core part - nothing changed

Tried all other three options - nothing changed

Can you tell me which authentication plugins are used with your BitBucket instance?

Can you tell me which authentication plugins are used with your BitBucket instance?
How can I check it?

This is a screenshot from Sourcetree. Does it suffice?

Sorry, I meant the server-side plugins. Could you ask your sysadmin?

Also, the BitBucket and plugin versions would be good to know

Sorry, I meant the server-side plugins. Could you ask your sysadmin?

No :(

I've just downloaded GitAhead (v2.6.3 Jul 14, 2020) and tried to fetch - entered the password - All Worked!

Does Gittyup v1.1.2 work?

Does Gittyup v1.1.2 work?

WOW! YEA! Its work! Thanks!
I see you removed some settings from Options, and removed App Options from gear icon.....

Could you also try if v1.2.0 works?

Could you also try if v1.2.0 works?

It does!!

v.1.3.0 also doesnt open the latest repos at startup (as 1.2.0 and older versions do)

Does v1.2.1 work?

v.1.3.0 also doesnt open the latest repos at startup (as 1.2.0 and older versions do)

That would be #329

Does v1.2.1 work?

It works!

1.2.2 - also works......eeeeerrrr.... Let me do clean install/

what
The only difference between v1.2.1 and v1.2.2 is the updater, which shouldn't have any influence on Windows builds
Did you use the development build originally instead of v1.2.2 when you openend this ticket?

uninstall 1.2.2 - install 1.2.2 - Fetch works without asking password

Did you use the development build originally instead of v1.2.2 when you openend this ticket?

Now I'm siting and wondering..... And I cant check my old downloads coz I deleted them :(
Sorry for troubles :(

Alright since it works now I'll assume that you used the development version, I'll check the changes between 1.2.2 and 1.3.0

I looked through Google download history and that what I found:

So It really was 1.2.2 ....
How should I uninstall GittyUp in order to remove all records?
.....I think after I entered password at 1.1.2 - app records it and all other version use that record

v.1.2.2 - Yep - I unchecked "Store credentials in secure storage" - and error returns - I cant fetch

That could be the case - the password should be stored in the Windows vault (search for "manage credentials")
Also: do you have Git for Windows installed normally?

Also: do you have Git for Windows installed normally?

what does where git output?

what does where git output?

nothing

Ah, try where.exe git

Ah, try where.exe git

Hmm, Ok, so I tried all your versions (except 1.3.0) and the last GitAhead

with unchecked "Store credentials in secure storage" - all have the same behavior as I described in this ticket.
with checked "Store credentials in secure storage" - all have the same behavior - fetch/push without asking a password.

I donk know wat was at 13-th of march that I got that error and continuously had it till today (the checkbox was always checked, as I remember).
So its up to you guys to decide whether it's correct behavior or not  and close this issue.

interesting, considering that unchecking only removes credential.helper form the user GIT config, which makes the default take over (which is manager) - unchecking should make it still work but ask for the password everytime
I'll leave this open
@Murmele should we make the checkbox set credential.helper to an empty string when unchecked?

@exactly-one-kas this sounds like a good idea


Error send mail

Laravel Version: 7.0.1
PHP Version: 7.3
Database Driver & Version: Mysql

Description:
When trying to send a message through "smtp" an error occurs.

https://github.com/laravel/laravel/blob/master/config/mail.php - the configuration is such
Returns the text: Undefined index: host

Code example 1:
 Mail::mailer('smtp')
                    ->to(config('mail.email_support'))
                    ->send(new TestMailRequest());

Code example 2:
 Mail::to(config('mail.email_support'))
                    ->send(new TestMailRequest());

The error occurs at the stage "createSmtpTransport", the parameter "host" cannot be found.
Link code: https://github.com/laravel/framework/blob/7.x/src/Illuminate/Mail/MailManager.php#L186
Maybe I made a mistake somewhere, but after changing the configuration "mail", this error appears

https://github.com/laravel/framework/blob/7.x/src/Illuminate/Mail/MailManager.php#L186
An error occurs at this point.

@serderovsh you haven't accidentally emptied your MAIL_HOST env variable have you? https://github.com/laravel/laravel/blob/master/.env.example#L27

My env code
MAIL_MAILER=smtp
MAIL_HOST=
MAIL_PORT=465

Everything works when I do this:
mail.php
return = [
'mailers' => [
  //code default
],

'host' => env('MAIL_HOST', 'smtp.mailgun.org'),
'port' => env('MAIL_PORT', 587),
'encryption' => env('MAIL_ENCRYPTION', 'tls'),
'username' => env('MAIL_USERNAME'),
'password' => env('MAIL_PASSWORD'),
]

Remove this from your mail.php config file
'driver' => env('MAIL_DRIVER', 'smtp'),

and replace it with
'default' => env('MAIL_MAILER', 'smtp'),

I have this problem with queue. I have debugged it and the host index seems to be okay, but as soon as it goes to a queue, it became unavailable.
Any idea why?

As mentioned, replacing  'driver' => env('MAIL_DRIVER', 'smtp'), by 'default' => env('MAIL_MAILER', 'smtp'), will do the trick.
However, I spent over 20 minutes to figure out that, keeping the 'driver' => env('MAIL_DRIVER', 'smtp'), in the mail.php config file seems to tell Laravel to use the old-fashioned configurations. I was keeping it as a backward compatibility but figured out that it will break the mail sending, so you need to comment it out or remove it and replace it with 'default' => env('MAIL_MAILER', 'smtp'),


[BUG] With Every Compat, there are duplicates of some doors.

Thank you for reporting!
For issues:

If the issue seems to affect only one mod, report to them instead of here.
Remove Dramatic Doors to see if they are causing the issue before reporting.
If you crashed, please paste the crash log to gist and link it here.

Important Information
Minecraft Version: 1.20.1
Mod Loader System: Quilt
DramaticDoors Version: 3.2.8
Describe the bug
With Every Compat, some doors have duplicates which are just tinted oak doors. This applies to both tall and short doors (not vanilla ones).
To Reproduce

Install Every Compat, Nature's Spirit, Dramatic Doors, and EMI
Search for "Fir Tall Door"
There are 2 different items (one from everycompat and one from dramatic doors)

Expected behavior
Every Compat would not add tall doors that already exist.

It must be on Every Compat's end.


No application binary in snap

I wanted to create a snap for http://github.com/pbek/QOwnNotes and the build went quite well and the snap was created, but it seems the the built binary wasn't found and that's why it wasn't included in the snap (that can be installed sucessfully).
snapcraft.yml I created: https://github.com/pbek/QOwnNotes/blob/develop/build-systems/snap/snapcraft.yaml
Commands I executed:
cd ~/Code/_internal/QOwnNotes/build-systems/snap
snapcraft build
sudo snap install qownnotes_16.07.2_amd64.snap

These are the lines of the output near the end of the snapcraft build:
make install INSTALL_ROOT=/home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install
install -m 755 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/QOwnNotes /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/bin/
install: Aufruf von stat für '/home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/QOwnNotes' nicht möglich: Datei oder Verzeichnis nicht gefunden
Makefile:1981: die Regel für Ziel „install_target“ scheiterte
make: [install_target] Fehler 1 (ignoriert)
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/QOwnNotes.desktop /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/applications/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_de.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_en.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_es.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_fr.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_hu.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_it.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_ja.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_nl.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_pl.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_pt.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_ru.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
install -m 644 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/languages/QOwnNotes_zh.qm /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/QOwnNotes/languages/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/128x128 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/16x16 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/24x24 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/256x256 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/32x32 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/48x48 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/512x512 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/64x64 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/96x96 /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/
cp -f -R /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/images/icons/scalable /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/share/icons/hicolor/

Can anyone imagine what went wrong?
This is the qmake project file: https://github.com/pbek/QOwnNotes/blob/develop/src/QOwnNotes.pro
Note that it will create a binary QOwnNotes, but the name of the snapcraft is qownnotes. Is that a problem?
This line in the output produces a not found error:
install -m 755 -p /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/src/QOwnNotes /home/omega/Code/_internal/QOwnNotes/build-systems/snap/parts/qownnotes/install/usr/bin/

I found a QOwnNotes binary in parts/qownnotes/build, but snapcraft tries to install it from parts/qownnotes/src/QOwnNotes (according to the generated QOwnNotes make file).
Can I tell snapcraft to use the binary parts/qownnotes/build/QOwnNotes?

In the generated Makefile during the build it looks like for QOwnNotes (and other files like the .desktop file in . and not in ./parts/qownnotes/build. I'm not quite sure where the problem comes from and pinged @kyrofa and @sergiusens about it.

Thank you @dholbach!
Maybe @popey can help, I started to create a snap after watching his video https://www.youtube.com/watch?v=K0IzxsIFjJY ;)

@pbek @dholbach I'm not sure why this is happening, but I suspect an issue with qmake's out-of-source build support. It doesn't seem to be working in this case, and I'm not sure why. @pbek use this as a local plugin for now:
# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*-
#
# Copyright (C) 2016 Canonical Ltd
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License version 3 as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

"""The qmake plugin is useful for building qmake-based parts.

These are projects that are built using .pro files.

This plugin uses the common plugin keywords as well as those for "sources".
For more information check the 'plugins' topic for the former and the
'sources' topic for the latter.

Additionally, this plugin uses the following plugin-specific keywords:

    - options:
      (list of strings)
      additional options to pass to the qmake invocation.
    - qt-version:
      (enum, 'qt4' or 'qt5')
      Version of Qt to use with qmake.
    - project-files:
      (list of strings)
      list of .pro files to pass to the qmake invocation.
"""

import os
import shutil

import snapcraft
from snapcraft import common

class QmakePlugin(snapcraft.BasePlugin):

    @classmethod
    def schema(cls):
        schema = super().schema()
        schema['properties']['options'] = {
            'type': 'array',
            'minitems': 1,
            'uniqueItems': True,
            'items': {
                'type': 'string',
            },
            'default': [],
        }
        schema['properties']['qt-version'] = {
            'enum': ['qt4', 'qt5'],
        }
        schema['properties']['project-files'] = {
            'type': 'array',
            'minitems': 1,
            'uniqueItems': True,
            'items': {
                'type': 'string',
            },
            'default': [],
        }

        # Qt version must be specified
        schema['required'].append('qt-version')

        # Inform Snapcraft of the properties associated with building and
        # pulling so it can mark those steps dirty if they change in the YAML.
        schema['build-properties'].append('options')
        schema['pull-properties'].append('qt-version')

        return schema

    def __init__(self, name, options, project):
        super().__init__(name, options, project)

        self.build_packages.append('make')
        if self.options.qt_version == 'qt5':
            self.build_packages.extend(['qt5-qmake', 'qtbase5-dev'])
        elif self.options.qt_version == 'qt4':
            self.build_packages.extend(['qt4-qmake', 'libqt4-dev'])
        else:
            raise RuntimeError('Unsupported Qt version: {!r}'.format(
                self.options.qt_version))

    def build(self):
        super().build()

        env = self._build_environment()

        sources = []
        if self.options.project_files:
            sources = [os.path.join(self.sourcedir, project_file)
                       for project_file in self.options.project_files]

        self.run(['qmake'] + self._extra_config() + self.options.options +
                 sources, env=env)

        self.run(['make', '-j{}'.format(
            self.project.parallel_build_count)], env=env)

        self.run(['make', 'install', 'INSTALL_ROOT=' + self.installdir],
                 env=env)

    def _extra_config(self):
        extra_config = []

        for root in [self.installdir, self.project.stage_dir]:
            paths = common.get_library_paths(root, self.project.arch_triplet)
            for path in paths:
                extra_config.append("LIBS+=\"-L{}\"".format(path))

            paths = common.get_include_paths(root, self.project.arch_triplet)
            for path in paths:
                extra_config.append("INCLUDEPATH+=\"{}\"".format(path))

        return extra_config

    def _build_environment(self):
        env = os.environ.copy()
        env['QT_SELECT'] = self.options.qt_version

        return env

I'll upstream that.

Thank you for helping, @kyrofa!
I created your qmake plugin (thanks a lot!) and did a snapcraft clean && sanapcraf build.
The make install works now!
install -m 755 -p /home/omega/Code/_test/QOwnNotes-Snapcraft/parts/qownnotes/build/QOwnNotes /home/omega/Code/_test/QOwnNotes-Snapcraft/parts/qownnotes/install/usr/bin/

The binary was present at parts/qownnotes/install/usr/bin/QOwnNotes.
But I still could not find an application binary in the snap.

@pbek note the case: QOwnNotes. Your command is lower-case: command: desktop-launch qownnotes.  You need to use snapcraft snap or just snapcraft to do that.

@kyrofa, thank you for the hints! I'm testing them currently.

meanwhile: I would like to modify a header file from the downloaded source archive before building it. Is that possible in the snapcraft.xml?

@kyrofa, the binary is now present inside the mounted snap at ./usr/bin/QOwnNotes and can be executed directly, but calling qownnotes still just outputs aa_change_onexec failed with -1. errmsg: No such file or directory.
I have tried both desktop-launch QOwnNotes and desktop-launch usr/bin/QOwnNotes as command in the snapcraft.xml.

@pbek what distro are you running? Can I see the output of cat /etc/os-release, please?

@kyrofa, thank you for helping!
$ cat /etc/os-release
NAME="KDE neon"
VERSION="5.7"
ID=neon
ID_LIKE=ubuntu debian
PRETTY_NAME="KDE neon User Edition 5.7"
VERSION_ID="16.04"
HOME_URL="http://neon.kde.org/"
SUPPORT_URL="http://neon.kde.org/"
BUG_REPORT_URL="http://bugs.kde.org/"
UBUNTU_CODENAME=xenial

@pbek ah, I'm afraid that's bug #1593255. It's fixed in 2.0.10, which is making its way through the SRU process now. Hang tight, I'm sorry!

These are my configuration files right now: https://github.com/pbek/QOwnNotes/tree/develop/build-systems/snap

Oh, thank you for letting me know, @kyrofa. Will there be an update for snap 2.0.10 in Ubuntu?
And I would like to modify a header file from the downloaded source archive (or copy one file from the archive over the current header file) before building it. Is that possible in the snapcraft.xml?

Will there be an update for snap 2.0.10 in Ubuntu?

Oh yes, subscribe to the SRU bug so you can know when to update.
Regarding patching, no, that's not currently supported within snapcraft. Currently the recommended way to do that is to have a fork with the patch applied.

SRU bug

Thank you, I now did.

patching

That's not very convenient. :) Do you know if there are any plans to implement support for running shell commands or copying files before the build process (like for Arch PKGBUILD, AUR, SlackBuild or Gentoo)?

 Can I build snaps on Launchpad? I haven't found anything about that, but I think I heard it works... So I'm asking myself how.

Indeed you can, check this out.

Wonderful, thank you very much, @kyrofa!

@kyrofa: the build on Lauchpad didn't went so well for me. :)
First I had to remove the confinement property, because Launchpad complained that it existed.
(It was then set to strict by default: "confinement" property not specified: defaulting to "strict")
But then I also got:
Issue detected while analyzing snapcraft.yaml: Cannot find definition for part 'desktop/qt5'. It may be a remote part, run "snapcraft update" to refresh the remote parts cache
https://launchpadlibrarian.net/271441376/buildlog_snap_ubuntu_xenial_amd64_qownnotes_BUILDING.txt.gz

I just asked the Launchpad team about this.
@kyrofa - Regarding the out-of-source build support, is there anything which might need a change in the qmake plugin?

thank you, @dholbach

I filed https://bugs.launchpad.net/launchpad-buildd/+bug/1599786

Thank you @dholbach, I subscribed to it.

@kyrofa - Regarding the out-of-source build support, is there anything which might need a change in the qmake plugin?

Yeah, PR is here.

I filed https://bugs.launchpad.net/launchpad-buildd/+bug/1599786

Worth pointing you to this as well-- snapcraft will do this automatically in the next release.

ah, nice!

Thanks a lot @kyrofa

@kyrofa, I can confirm that I can now start applications from snaps under KDE Neon with snap 2.0.10, but I still have to use your local qmake.py. Building on Launchpad still doesn't work, same error: Cannot find definition for part 'desktop/qt5'.
But meanwhile I have uploaded a locally built qownnotes snap to the store. Now I'm waiting for the confirmation. :tada:

@pbek indeed, snapd and snapcraft are two separate products-- the new release of snapcraft (containing the updated qmake plugin and the fix for the LP builders) will be released in the next few days.

@kyrofa, thank you for informing me, I was hoping a snapcraft update would fetch directly from GitHub. ^_^

@dholbach, @kyrofa currently I get this error on Launchpad:
Running repo phase...
Cloning into 'qownnotes'...
Running pull phase...
Loaded local plugin for qmake
HTTPSConnectionPool(host='wiki.ubuntu.com', port=443): Max retries
exceeded with url: /Snappy/Parts?action=raw (Caused by
ProxyError('Cannot connect to proxy.', OSError('Tunnel connection
failed: 403 Forbidden',)))
Traceback (most recent call last):
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 194, in main
    builder.pull()
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 135, in pull
    env=env)
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 92, in run_build_command
    self.chroot(["/bin/sh", "-c", command], echo=echo)
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 66, in chroot
    "/usr/bin/sudo", "/usr/sbin/chroot", self.chroot_path] + args)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)

https://launchpadlibrarian.net/272365528/buildlog_snap_ubuntu_xenial_amd64_qownnotes_BUILDING.txt.gz

And does anyone know what is supposed to happen if a snap has the status published on https://myapps.developer.ubuntu.com? I can't find the snap anywhere to download publicly...

Can you maybe give me the URL of your app in myapps and I'll see what I can do?

Can you check if a channel is selected for the upload?

@dholbach, you are my hero. ^_^
https://myapps.developer.ubuntu.com/dev/click-apps/5374/

There is no channel selected for the upload at https://myapps.developer.ubuntu.com/dev/click-apps/5374/configurations/.

... Downloading... :-)

I now manually selected the channel Stable (can that be done by snapcraft upload)

That's going to be part of one of the next snapcraft releases: https://bugs.launchpad.net/snapcraft/+bug/1549211

Thank you, good to hear. Is it mandatory that the channel is set?

Yes, I'll add a task for this bug for the store to set a sensible default in cases where it's not set (for whatever reason).

Thank you!
So do you know when/how/where the snap will be publicly available (now that I have set the channel manually)?
And you you know anything about the weird error at https://launchpadlibrarian.net/272507287/buildlog_snap_ubuntu_xenial_i386_qownnotes_BUILDING.txt.gz

I just installed it using "snap find" and "snap install qownnotes" on Ubuntu 16.04 LTS. :-)

The Launchpad fix is in progress right now.

Wow, you definitely are my hero now! :tada:
So the next time I manually build a snap I just also need to set a channel at myapps, right?
But ultimately I want to build and release it with launchpad, I'm looking forward to that fix.

I think it should land together with snapcraft 2.12.1.

Awesome!
by the way, can qownnotes now also be found at https://apps.ubuntu.com/cat/search/?q=qownnotes&op= and https://uappexplorer.com/app/qownnotes?

apps.u.c is just for .deb packages - here's your snap: https://uappexplorer.com/app/qownnotes.pbek

I'm not quite sure why the search on uappexplorer didn't find it. Maybe file a bug on https://github.com/bhdouglass/uappexplorer?

https://uappexplorer.com/app/qownnotes.pbek

really awesome! :smile_cat:

bug

I now did at https://github.com/bhdouglass/uappexplorer/issues/78, thank you!

@pbek looking at the conversation, I think this issue can be closed now, would you agree?

we do, thank you!

@dholbach, concerning building snaps on launchpad:
since the last update the snapcraft update seems to be done, but the build still fails:
Downloading parts list|
Parts 'desktop/qt5' and 'env' have the following file paths in common which have different contents:
usr/share/pkgconfig/xkeyboard-config.pc
Traceback (most recent call last):
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 194, in main
    builder.pull()
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 135, in pull
    env=env)
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 92, in run_build_command
    self.chroot(["/bin/sh", "-c", command], echo=echo)
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 66, in chroot
    "/usr/bin/sudo", "/usr/sbin/chroot", self.chroot_path] + args)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['/usr/bin/sudo', '/usr/sbin/chroot', '/home/buildd/build-SNAPBUILD-1600/chroot-autobuild', 'linux64', '/bin/sh', '-c', 'cd /build/qownnotes && env LANG=C.UTF-8 https_proxy=https://snap-proxy.launchpad.net:3128 http_proxy=http://snap-proxy.launchpad.net:3128 SNAPCRAFT_LOCAL_SOURCES=1 snapcraft pull']' returned non-zero exit status 1

https://launchpadlibrarian.net/273098585/buildlog_snap_ubuntu_xenial_amd64_qownnotes_BUILDING.txt.gz

The issue you're mentioning depends on https://bugs.launchpad.net/launchpad-buildd/+bug/1599786

You mean as in "something broke while that issue was addressed"?
And now you filed https://bugs.launchpad.net/snapcraft/+bug/1603403...

After applying https://github.com/ubuntu/snappy-playpen/pull/178 to every part the snapcraft built, but after an install qownnotes just started as zombie process...

Bugs 1603403 and 1599786 are quite separate things. I pinged the right people to take a look at them.
Can you give me a link to the changes you made, so I can take a look at it locally?

@dholbach, I created a feature branch for you with what I made:
https://code.launchpad.net/~pbek/qownnotes-snap/+git/qownnotes-snap/+ref/feature/snapcraft-2-12-1

Try adding the network-bind plug - that should make it work.

Really, I just removed that because I have no network daemon. I will add it again and try. (why is it needed now?)

@dholbach, you are right, network-bind did the trick. Thanks a lot! Do you have any idea why network-bind is needed? And should not desktop/qt5 together with desktop-launch somehow match the Qt theme with the Qt theme of the underlying system? They are not matched here on KDE Neon.

I don't quite know why network-bind is needed - I seem to recall it was a transient thing and had to do with host look-ups(?).
Unfortunately I don't have a KDE Neon system to test this with. Do you know which files it looks for and can't find? I responded on the PR  #181 with a proposal on how to just use one part (and just one remote part).

Ok, thank you!

currently I have still a lot of issues with the snap..

Qt theme (colors, widgets, icons, ...) does not match with native Qt theme under KDE Neon
usage of the language files doesn't work

the language is always the default language

problems with UTF8 characters

see interface settings, language list

cannot store notes to note folder

seems like it tried to write to an old revision's directory

home directory changes with revision

e.g. /home/omega/snap/qownnotes/13/ownCloud/Notes

snap is built in debug mode

should be release mode

@dholbach, I got around the home folder problem by trying to determine the real home folder of the user and suggest that folder, but the other troubles still exist

still some issues left with the qownnotes snap..

Qt theme (colors, widgets, icons, ...) does not match with native Qt theme under KDE Neon
usage of the language files doesn't work

the language is always the default language
are the language files not found?

problems with UTF8 characters

see interface settings, language list or when typed in a note
Japanese or Chinese characters don't work

debug information is logged in the build

I don't know how to get around that


Fix RTD documentation link

Merging myself because I don't have write access, so this is the workaround.


update and delete is not work!

when i used soft delete()  and update,  my mysql database has changed, but es cannot be updated.
the version of scout-elasticsearch-driver is 3.8.1，laravel version is 5.6.*。why？

Hi @kotlin360, do you receive an error message or data just doesn't appear in ES?

@babenkoivan no any errors! And data is in ES.When  delete and update method,I used array mode.For example,
UserModel::where('id',100)->delete()
UserModel::where('id',101)->update(['age'=>20])
After that,mysql was be updated but its not work for es!
No change in ES!

@kotlin360 the problem with your query is that the delete and update operation is a direct database operation and not using Eloquent, which will not trigger Eloquent delete and update events. Hence it will not be picked up by scout.
You will need to do the following instead:
To delete:
UserModel::find(100)->delete
To update:
$user = UserModel::find(101);
$user->age = 20;
$user->save();

@aygee thank you!But if it is a batch operation?it's pain!

@kotlin360 if that's the case, then you will need to manually call searchable with your eloquent query, eg:
App\Order::where('price', '>', 100)->searchable();
https://laravel.com/docs/5.7/scout#updating-records


Fix: where split('') did not account for locales that contained ''.

Ref: https://github.com/statikbe/laravel-nova-chained-translation-manager/issues/18

@7ammer Thanks a lot for your pull request. I released v3.0.2.


Added alot of commits

Hi, im EdenStudio from the forums
1# I added a snowing javascript that should be enabled only when its Christmas
2# added snowflake.svg
3# updated snowsrc
4# added comments and modified the script
5# added internet explorer detection that whines if your IE is under 8 to fix any future compatibility issues @ index.html
6# added ie.html that the user gets redirected to if IE > 8
7# Updated javascript with the right redirect

We'll see what the group's opinion is on this. I assigned Cheese-Eater so he can see it.

Thank you. I would love to be a contributor too.

You could add a bit about IE, maybe newer versions, and allow them on the site and make it display something like this: Your using Internet Explorer, OpenSprites does not recommend using Internet Explorer, upgrade to a new browser like Firefox! You`ll find its a lot quicker too!

That would be cool. I could add "Continue to the site or Download Chrome"

No... Not Chrome... Not da google web browser dat tracks you and stuffs D:

Great, thanks for your work! If you'd like to become a developer, please ask on the thread so I can keep account of everything. Thank you. :smile:

@The-QullzToxic Chromium... :+1:

Let's not force the user to use anything...
(unless they're using IE :P)

Changed.

changed what?

He changed the link to Chrome to the browser choices site. Anyone using IE is on a sinking ship, the only thing it's good for now is checking Windows Updates on old XP. :P I liked Chrome's simple and modern design, but the fact that Google made it, scared me into uninstalling it. Firefox works OK, but HTML5 video playback is the most terrible I've seen, ever.

I use Chromium myself, way better.

@The-Cheese-Eater you're wrong - it's amazing at downloading Chrome!  xD

xD


Role Selection from RoleBinding does not allow free text

Description
The Form Validation fails if free text is typed in
Expected result
User should be able to add free text and the form should be valid
Actual result

Steps to reproduce

Troubleshooting

Free text entries are most likely of kind ClusterRole that the respective user is not allowed to list due to lack of cluster scoped authorizations.


Compose ReusedModifierInstance false positive

Expected Behavior
I have a @Composable that receives a modifier, and the first child is ProvideWindowInsets that has no modifier parameter, and I put the received modifier on the first child of ProvideWindowInsets, then Detekt says that the received modifier instance should be passed only to de first child.
Here is an example:
@Composable
fun MyComposable(
    ....
    modifier: Modifier = Modifier,
    .....
    ) {
          ProvideWindowInsets {
               Surface(
                      modifier = modifier,
                      .....
               ) {
                    .....
               }
          }
    }

Observed Behavior
Detekt says that the received modifier instance should be passed only to de first child.

Steps to Reproduce
Create a composable that receive a modifier and its first child has no modifier parameter (ProvideWindowInsets) so pass the modifier to the first child of ProvideWindowInsets.

Context

Your Environment

Version of detekt used: 1.20.0
Operating System and version: Mac OS 12.4

Thanks for the report!
Unfortunately without Detekt's "type resolution" feature enabled, there's no way for the detekt rule to know which parameters does a function call have - if they are not used. And "type resolution" is currently an experimental feature (read about it here).
I will try to play with this and hope to fix eventually. For now I'd suggest to put @Suppress("ReusedModifierInstance") on this particular @Composable.

I just published this on the detekt repo: https://github.com/detekt/detekt/discussions/4959 I hope we can remove the "experimental" tag from type resolution. It should be completely safe to use type resolution.
But, even with type resolution, which is your idea here? look for the first node that allows a Modifier and check that is that the only one receiving the modifier value? I think that should do the trick :)

But if it would be possible to find a "detektLite" variant of this rule, it would be nice, because a lot of users are using it (although I guess this will gradually change towards "detektFull") and this rule is one of those which can really help catch some bugs.

If we find a way to do it completely with "detektLite" would be nice. But I don't recommend to give this rule a mixed behaviour: https://github.com/detekt/detekt/issues/2994
The problem is, how do we know if we should skip a node? Creating a list of nodes to skip? That could be hard to maintain.


Feature: Add iter enumerate method.

Takes an iterator and returns a new iterator that produces the same elements with corresponding indices.

import Iter "mo:base/Iter";

let letters = [ "a", "b", "c" ];
let enumeratedIter = Iter.enumerate(letters.vals());
assert(?(0, "a") == enumeratedIter.next());
assert(?(1, "b") == enumeratedIter.next());
assert(?(2, "c") == enumeratedIter.next());
assert(null == enumeratedIter.next());

Simplifies:
var i = 0;
for (l in letters.vals()) {
  // Do somthing with `i` and `l`.
  i += 1;
}

@kentosugama @crusso Would love to see this merged in - sometimes just need a count aware iterator without needing to provide a function (like in Iter.iterate)

Let me ask an innocent question... Isn't this just a zip of the passed-in iterator with some unbounded range?

Isn't this just a zip of the passed-in iterator with some unbounded range?

In a way yes, currently only the List and Buffer structs have the zip operation defined afaik.
Might be interesting to also support this for iterators.

@kentosugama @ggreif any reason not to merge this?

I am a bit concerned about

utility: this is a very specific function
heap traffic: this tends to create a lot of pairs in the heap that ends up as garbage
naming: this really enumerating things?

IMHO what we need is a rangeFrom iterator that gives the naturals (open ended) and then zips it with the above letters.vals().

Seems like there aren't any plans to merge this.


RFE: a way to run a test just before Angular loads

I believe that it's a good practice to inform users that the Angular-based application is loading. I mean, in case of Angular 2, it's e.g. <view>Loading...</view>. It would be nice to have a possibility to test this aspect of the page by running a test just BEFORE Angular (or maybe any particular script) loads.

I don't see how this has anything to do with Protractor. There's nothing preventing you from using selenium to test that a loader / message exists on the page.

The description says "Protractor is an end-to-end test framework for AngularJS applications.". Since I am seeking for a way to test a particular aspect of an AngularJS application, I guess it fits the purpose of Protractor...
Would you be so kind to give me some more hints? You meant some browser.driver methods? Do you know off head what method can help me make sure that Angular won't be loaded before the test finishes?

Certainly (and other Protactor users) would be happy to help you on StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Great to hear that. Thank you.
For those who come across this thread: http://stackoverflow.com/q/33732320/5566882

So, since @NickTomlin has just responded that there is no way to ensure that Angular has not loaded, I would be glad if you could reconsider the use case and if you find it valid, please, reopen the issue. Either way the tag "question" is not correct since it was and still is an RFE.

Unfortunately, this is impossible to do with WebDriver - once requested, you can't generically pause a page during its load. Protractor does ask Angular to wait to bootstrap while it is loading to insert more modules - you could potentially piggy-back off of this to run a check between when the page is loading and when angular bootstraps. I don't think that this is a common use case so I doubt we'll add an official way of doing this, but I can reopen.

I'm going to go ahead and close this since if it's not something we are likely to implement and we haven't had any movement on it for a few months. I think alexce's SO answer provides a decent approach to testing around this.
Please feel free to re-open if that's a wrong way to think about it :smile:

Does alexce's approach guarantee that Angular is not loaded before the test ends? Otherwise I have trouble to understand how that can be a decent approach.


Generated responses are occasionally in languages other than Apex

Sometimes, when I ask for a method to be created in Apex ie.
Create a function to take two numbers and print the sum
the generated response will be in a language other than Apex, ie. Python. If I'm working within an existing Apex file, I'd like the generated code to also be in Apex.

@abrantes23 strictly speaking, there is a distinction between methods and functions, but practically speaking it isn't so wrong to describe apex methods as functions. sure, Apex doesn't have pure functions, but its common and correct enough to refer to apex methods as functions, and I think a tool meant to convert the intent of natural human language to executable code should not care about the kind of distinction that doesn't impact how the resulting code should be composed.
By the same distinction, much of the behavior written in LWC are written as class members, which are more "correctly" described as methods

This issue was resolved by further training of the LLM.  Please reopen if you encounter a new prompt that generates something other then apex.


handling padding when computing scaling for cost matrices.

The segmented approaches to pad efficiently point clouds rely on padding with "default" (e.g. zero) vectors. These padded vectors create spurious entries in cost matrices, but when running Sinkhorn, these entries are ignored thanks to the fact that these entries have 0 weights (in the respective a and b weight vectors). However, these entries would play a role when computing scalings (such as mean cost).
A possible approach would be to redefine some of those statistics (e.g. max, mean etc..) to only apply to entries that have a positive weight (e.g. C_ij is considered iff a_i b_j >0). For the mean cost, the mean might be weighted by a_i b_j as well.

A possible approach would be to redefine some of those statistics (e.g. max, mean etc..) to only apply to entries that have a positive weight (e.g. C_ij is considered iff a_i b_j >0). For the mean cost, the mean might be weighted by a_i b_j as well.

I think partial solution to this can be found in #99 , where I define a subset method.
In this case, we could implement inv_scale_cost in geometries as:
@property
def inv_scale_cost(self) -> float:
    if self._src_ixs None and self._tgt_ixs is None:
        return self._inv_scale_cost
    return self.subset(self._src_ixs, self._tgt_ixs)._inv_scale_cost

@property
def _inv_scale_cost(self) -> float:  # old `inv_scale_cost`, now private
    if isinstance(self._scale_cost, float):
      return 1.0 / self._scale_cost
    ...

However, this would require we save the extra valid {src,tgt}_ixs, which I'm ok with (better than passing them in each function).

Thanks Ersi, Michal.
Michal: for the fix you propose I feel the issue here is computing self._scale_cost, which, typically, when considering a mean distance will be problematic because of the padding. I think it could be easier overall to update the scale cost methods to incorporate a set of indices on which statistics should be considered. This could in some case fallback on subset as you defined it, but also possibly something slightly more complicated.

Michal: for the fix you propose I feel the issue here is computing self._scale_cost, which, typically, when considering a mean distance will be problematic because of the padding. I

I think I might be missing something, but self._scale_cost is just the flag which tells how to compute the inverse scaling (Laetitia changed the naming a while back).
Unless you want to have something very generic, like (n, m) boolean mask for kernels/costs (a trouble finding a use case ATM), I'd say the approach above should be sound for Geometry/LRCGeometry/PointCloud without much modification.

You are right, I think the fix you propose is very good! It's a bit of an open debate to figure out whether the normalization should be weight dependent or not (i.e. should we take into account a and b, and not just their supports) but I think what makes for now this solution more preferable is that this can be entirely handled at the level of the padding blocks.


Filter attributes by shibmd_scope

All Submissions:

[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Have you added an explanation of what problem you are trying to solve with this PR?
[X] Have you added information on what your changes do and why you chose this as your solution?
[x] Have you written new tests for your changes?
[X] Does your submission pass tests?
[X] This project follows PEP8 style guide.

Fix #297 by extending satosa.micro_services.attribute_modifications.FilterAttributeValues to support not only regexp filtering but also add filter types shibmdscope_match_scope and shibmdscope_match_value - equivalent to https://shibboleth.atlassian.net/wiki/spaces/IDP4/pages/1272053894/ScopeMatchesShibMDScope and https://shibboleth.atlassian.net/wiki/spaces/IDP4/pages/1272053892/ValueMatchesShibMDScope from the Shibboleth project.
@c00kiemon5ter , please let me know whether you are happy with the overall approach - in #297, you indicated this should be done in a microservice - and in the end, it wasn't that hard.
I first thought I'd do this in a new microservice, but I'd just be replicating what FilterAttributeValues does - and this additional filtering fits in there conceptually well.
If happy with this approach, I'd add documentation and tests - but please let me know if overall happy with the approach I took.
Cheers,
Vlad

@vladimir-mencl-eresearch I think it's fine! Please, go ahead 👍

Hi @c00kiemon5ter , I've  now added tests - and also made a few tweaks, incl. removing the unnecessary re.compile - and switched to re.fullmatch as discussed.
I think it's now ready for a proper review - please let me know what you think needs to get done to get it merged.
Thanks a lot in advance for getting back to me.
Cheers,
Vlad


Bearer Tokens? JWT? Claims Based?

The more I think and research about this, the more I think a custom SessionStorer that does JWT tokens is all that needs doing here. Direct support from Authboss seems of little utility since we've already abstracted this part out. If there are any issues with an implementation that requires authboss I'm ready to lend a hand to anyone attempting to implement.

@aarondl can you provide some hints on how this might work. There doesn't appear to be anything called SessionStorer. There is ServerStorer but it never gets access to the request. I thought maybe I could do in a ClientStateReadWriter but while that gets access to the request I don't think there's any way to attach anything to the requests context because you get a *http.Request and not a **http.Request.
I can read the JWT token out of a header in my ClientStateReadWriter but I can't figure out how to propagate to the rest of the code (e.g. so I can read it out of the context in an endpoint).


License

Paul,
Any chance that you could provide a license for this? (BSD, MIT, etc?)
Cheers,
:w

I've added the MIT License, thank you for the suggestion.


Custom Local Address Extension Character

Is your feature request related to a problem? Please describe.
I'd like to migrate mailservers which already rely heavily on local address extension using the delimiter _ (underscore).
Other folks might face the same blocker e.g. when currently using the Postfix-default delimiter +.
Describe the solution you'd like
A configuration option to set a delimiter different from the default - (dash).
This should be relatively easy as it may require no more than two customizations, one in Postfix and the other in Dovecot config files.
Describe alternatives you've considered
Migrating the mailservers from the current _ underscore to the default - (dash) is not feasible because addresses using the underscore are in use by hundreds of third-parties.

Added this feature to master. You can use the new RECIPIENT_DELIMITER environment variable to configure that.

@jeboehm Wow, very cool, thanks a lot... and Happy 🐰 🥚

Happy holidays for you aswell :)


Add field validation to resolve the Update Profile Issue

Proposed Changes
This PR introduces logic to disable the "Update" button on the profile update page when no changes are detected in the form fields. The useMemo hook compares the current form values with the user's existing data and detects any modifications.

Fixes #8804
Implemented validation in the useMemo hook to check specific fields and compare them with userData.
Only submit updated data when actual changes are detected in the fields.

@ohcnetwork/care-fe-code-reviewers
Demo Video
Click here to watch the demo video
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[x] Ensure that UI text is kept in I18n files.
[x] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

@JavidSumra fix  the failing cypress test

@JavidSumra fix the failing cypress test

Hi Nihal Sir, I ran all the test cases locally, and only one test case from the users_spec suite needs to be fixed. All the other test cases that are failing in the workflow have passed locally. I believe the issue might be related to a timeout. What should I do next?

@nihal467 the failing specs are majorly not related to this PR. Do check it out.

src/Components/Form/FormFields/PhoneNumberFormField.tsx

[ ] You recently modified the reusable phone number input field component by removing the default pre-fill of "+91". This change is causing issues with related forms where tests were written with the assumption that "+91" would be pre-filled. Please revert the change, as having "+91" pre-filled in the input field is an intentional behavior.

cc: @bodhish

Hey @nihal467 can you please check updates in test cases now it's passing all the test cases.

Hey @nihal467 can you please help me to debug why test cases are failing so I can fix Accordingly

Thanks @nihal467  all the test cases passed now!!

LGTM

Hey @bodhish can you please assign 2 story point for this?

Done


pfx files encrypted with AES256 are not supported.

This page should clearly indicate that Azure does not support AES256 and all pfx files should be encrypted with TrippleDES.
When importing a pfx file Azure will only give an error message of 'wrong password or invalid file' when trying to upload a pfx cert file encrypted with AES256

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbf6dd80-7e07-3e24-7aa8-d3f278f34588
Version Independent ID: e06a85f1-9a8c-7b94-a86d-33bdf2daf9d5
Content: Use SSL certificate in code - Azure App Service
Content Source: articles/app-service/configure-ssl-certificate-in-code.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

Thanks for your patience @rcorral-ci. We have updated the docs. I have submitted a PR to fix the issue, the change is merged internally and will go-live in the public docs shortly.


comment keymap is gcc

Problems summary
now comment is gc
Environment Information

OS:

neovim :version output:

:checkhealth or :CheckHealth result(neovim only):

How to reproduce the problem from neovim startup (Required!)

foo
bar
baz

gc is not this keymap
Screenshot (if possible)

Hi  gc is a prefix key for caw.vim. the usage
Type "gci" (toggle: "gcc", uncomment: "gcui")
  before:
      "   <- inserted here"
  after:
      "   # <- inserted here"

Type "gcI" (uncomment: "gcuI")
  before:
      "   inserted the first column"
  after:
      "#    inserted the first column"

Type "gca" (uncomment: "gcua")
  before:
      "inserted after this"
  after:
      "inserted after this    # "

Type "gcw" (uncomment: "gcuw")
  before:
      "  wrap!"
  after:
      "  /* wrap! */"

Type "gcb"
  before:
      "  box!"
  after:
      "  /********/"
      "  /* box! */"
      "  /********/"

Type "gco"
  before:
      "   func1();"
  after:
      "   func1()"
      "   // "  (now cursor is at the end and entered insert-mode)

Type "gcO"
  before:
      "   func1();"
  after:
      "   // "  (now cursor is at the end and entered insert-mode)
      "   func1();"


archive.twig missing?

I don't see archive.twig even tho it is referenced in archive.php as a template, no big deal just something I came across.

If you need to make a separate archive template, you can save your index.twig as archieve.twig. Otherwise, the default template is index.twig.

Closed by #72


[Feature] Rework to_onehot and to_categorical to take a tensor as parameter

Description
As mentioned in the closed PR #783 we want to update the methods to_onehot and to_categorical to support value conversion in addition to spec conversion.
This is what currently happens
spec = torchrl.data.MultOneHotDiscreteTensorSpec([5,10])
sample = spec.rand((2,3))
sample.shape
torch.Size([2, 3, 15])
sample_np =spec.to_numpy(sample)
sample_np.shape
(2, 3, 2)

spec = torchrl.data.MultOneHotDiscreteTensorSpec([5,10])
sample = spec.rand((2,3))
sample.shape
torch.Size([2, 3, 15])
sample_np =spec.to_numpy(sample)
sample_np.shape
(2, 3, 15)

sample_cat = spec.to_categorical(sample)
sample_cat.shape
torch.Size([2, 3, 2])

To keep the current behaviour (conversion of the spec), I decided that val will be an optional parameter. The documentation will be well written to explain the different behaviours of theses methods.
Motivation and Context
Also related to the issue #781

[X] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[x] New feature (non-breaking change which adds core functionality)
[x] Documentation (update in the documentation)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[x] I have updated the documentation accordingly.

Hey @riiswa can I help to unblock this?

Hey @riiswa can I help to unblock this?

Hey, I'm a little bit busy in this moment (exams at school). I think the PR is finished, I juste have a little bug on GPU (created tensor are not on the right device) 😄
I think you can start the PR review, and when I have time I'll fix this little thing (unless you want to do it yourself)

Np i'll have a look

@vmoens I'm finally back, and I think this PR is ready for a review😄
@matteobettini maybe you should also check, because it's your idea

Yes it's cleaner, but in case of DiscreteTensorSpec.to(OneHotDiscreteTensorSpec) what can be the use of the parameter? I mean we will always convert it to the same OneHotDiscreteTensorSpec. The method can be named to_one_hot_spec()`

Yes it's cleaner, but in case of DiscreteTensorSpec.to(OneHotDiscreteTensorSpec) what can be the use of the parameter? I mean we will always convert it to the same OneHotDiscreteTensorSpec. The method can be named to_one_hot_spec()

My idea (but happy to challenge it) was that some day in the future we may code -- say -- a HashDiscreteSpec where a hash key is used to code a discrete value (or some other embedding).
Then it may be useful to have a generic to(SpecType) method that handles all sorts of conversion.
We could also map Bounded to Unbounded with the same structure, etc.
By I agree that to_one_hot_spec is more explicit.

Then it may be useful to have a generic to(SpecType) method that handles all sorts of conversion.

For the moment I have written a specific function, let's work on the generic version in the future after implementing the HashDiscreteSpec!


Remove TODO and add basic usage instructions

This change is

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

README.md, line 19 [r1] (raw file):
How about removing the ./? It does not seem common in usage descriptions.

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

README.md, line 19 [r1] (raw file):
Wasn't quite sure about this myself... what do you think of using a stylized prompt in front of the command?
$ guenther

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

README.md, line 19 [r1] (raw file):
Good idea.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


improving faq with analysis and meta-analysis questions

Now it looks like this:

Codecov Report

Merging #2772 into dev will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev   #2772   +/-   ##
=====================================
  Coverage   94.3%   94.3%
=====================================
  Files        166     166
  Lines      19980   19980
=====================================
  Hits       18843   18843
  Misses      1137    1137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcbfe3...fa5707d. Read the comment docs.

@charles-cowart, any left to change in this PR? Can you merge?


Blog thumbnails are stretched

The blog thumbnails on the Home route have strange aspect ratio and looks stretched

@brianwmunz Didn't this commit https://github.com/Qlik-Branch/branch-resource-library/commit/395788936b7b9fd95f461df4e3f5f5582f9dc880 close this?

no, did not fully commit. While @brianwmunz updated the .less files, the built files were not committed


redundant check in getting leadership status

Don't need to check again in ZooKeeperLeaderElectionService as LeaderLatch already checks for it.

I just found a Jira for this [https://issues.apache.org/jira/browse/FLINK-3461] . Please review.

Thanks for the PR. Change looks good. I'm going to merge it.
In the future, please follow the coding guidelines with respect to the PR title and commit msg: http://flink.apache.org/contribute-code.html#coding-guidelines.


Add node tests for subscribers

Cover exports.user_is_subscribed and exports.remove_subscriber.

@thejwzhang You should wait till your current task gets approved before moving on to another, especially for these node coverage tasks (there's also a rule for GCI that you can only claim one task at a time). The reason being if you aren't familiar with how to do node tests, you tend to make the same mistake continuously, which seems to be happening here. So, my advice is wait till your current task gets reviewed and approved, then continue onto other tasks.


Changed Room model id to UUIDField instead of shortuuid, bugfixes

Due to unforeseen migration issues when using shortuuid's random UUID generator, I've changed the id field on room to UUID entirely.
The way the scripts were being loaded, the chatroom had two scripts executing the same commands, so whenever a user searched and created a room with another user, the scripts ended up creating two room altogether; sort-of race condition
views.py is much shorter now to the use of the get_room utility.
Fixed a bug where if a user received a message, whatever they were writing would get reset to the empty string.

Closes #17


Remove Hash extensions

This PR removes HashRecursiveMerge as a core extension to Hash. The HashRecursiveMerge methods seem to have a single call site, invoked by a Geocoder::ConfigurationHash, which already includes the module.
Monkey-patching the core library can cause problems, such as unintentionally coupling code to the geocoder library (which can break in unanticipated ways when code is refactored), or causing conflicts with other libraries that have conflicting core extensions.
I'd also like to move HashRecursiveMerge under the Geocoder namespace, let me know if you'd be open to such a change.

Totally agree. The current solution is too heavy. All that's really needed is a utility method that takes two hashes and returns their merged result (which isn't very OOPish, but when it comes to merging two objects I'm not convinced that one of the objects should be responsible for the process). I'm up for redesigning this whole thing. Do you have an overall plan in mind?

Yeah, sounds good. I could create lib/geocoder/util.rb with an rmerge!(h1, h2) method, if that works for you. Let me know if you have other ideas.

Sounds good to me!

This looks good! Just a couple of things:

Since the rmerge! method has lost the context of a hash object, we should probably give it a more descriptive name. Also I think the ! is unnecessary. What about recursive_hash_merge?

The test seems to be failing:
...geocoder/test/unit/util_test.rb:9:in `test_rmerge!'
Error: test_rmerge!(UtilTest): NameError: uninitialized constant UtilTest::Util

Thanks, I've made the suggested changes (it wasn't meant to reviewed juuust yet, but I appreciate it nonetheless – i was just pushing changes to trigger tests, since I'm having issues running them locally).

Looks great. Thanks!!


WIP: Port Ansible role over to this repo

This PR ports the pre-existing Ansible role over to this open repo, fixes some bugs related to the move to the new repo, and vendors in lib_openshift so all of openshift-ansible is no longer a requirement. Vendoring currently done with the prototype tool gogitit.

@sallyom could you take a look at this one?


Misconfiguration no longer detected

With https://github.com/rust-lang-nursery/multirust-rs/commit/c3679a5922e68c5b08d7ff544f4d76031887523d the proxy test was removed. While I understand the rationale for it's removal, I do think it was useful:

On windows, the system-wide PATH has a higher precedence than the user-specific PATH, so by default, any existing rust install will silently override the rustup install, and the invocations of rustc will not be correctly proxied. Given how likely this is to occur, we should at least warn when this is happening.

Previously, multirust would intercept commands of the form <proxy> --multirust and print a message indicating that said proxy is working correctly. This was a useful feature in itself, and does not cause erroneous warnings.

There are a couple of ways this could be solved:

Only check the proxies on first install.
Provide a command to check that the proxies are correctly configured, and recommend using it in the post-install message.

Interesting points. I did not know the first. There are other system problems we might want to detect too, like old .multirust directories laying around.
The main reason I removed the old test was because it expected rustc to be on the PATH, which is I didn't consider a requirement for rustup to work. I also removed setting of PATH during proxy execution, instead relying on MULTIRUST_TOOLCHAIN.
I have doubts though that this was the right decision because of the way rustup is installed to ~/.cargo/bin: if ~/.cargo/bin is not in PATH then when cargo runs rustc it's going to fail because the rustc proxy isn't on the path. In other words, to make rustup work without setting PATH beforehand, rustup needs to set PATH to ~/.cargo/bin (not the toolchain dir) when executing proxies.
So what I think we might should do is:

Before running a proxied command prepend the directory containing the running proxy to PATH.
At installation, prepend the proxy directory to PATH and run rustc --multirust (or some other flag)
to see if Windows is overriding PATH.


Add hints for compare x y == EQ, compare x y /= EQ

I don't recall to have seen compare x y == EQ in any code, but since all other ==//= and Ordering combinations are already there, I don't think it will cause any harm.

Thanks, good idea!