[Platform Indicators] crashes on discord 247.2

info
Versions:
Bunny - e240509-main
Discord - 247.2 (64408)
React - 18.2.0
React Native - 0.74.5
Bytecode - 96
Platform:
Release Channel - ptb
Loader - BunnyTweak (0.3.1)
Operating System - iPadOS 17.6.1
Manufacturer - Apple Inc.
Brand - iPad
Model - iPad
Machine ID - iPad14,3
repro:

disable all plugins except Platform Indicators (https://bn-plugins.github.io/vd-proxy/martinz64.github.io/vendetta-plugins/PlatformIndicators/)
open DMs
clear cache
load in normal mode
switch from DMs to a server
client should crash

stack trace
Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined.
    at createFiberFromTypeAndProps (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:126272)
    at reconcileChildFibersImpl (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:47033)
    at reconcileChildFibers (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:49966)
    at reconcileChildren (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:69482)
    at updateForwardRef (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:69679)
    at beginWork (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:133783)
    at performUnitOfWork (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:115240)
    at workLoopSync (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:115096)
    at renderRootSync (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:114744)
    at recoverFromConcurrentError (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:112153)
    at performConcurrentWorkOnRoot (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:304:111221)
    at K (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:302:1375)
    at V (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:302:1887)
    at apply (native)
    at anonymous (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:106:2002)
    at _callTimer (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:106:539)
    at _callReactNativeMicrotasksPass (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:106:981)
    at callReactNativeMicrotasks (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:106:3805)
    at __callReactNativeMicrotasks (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:35:3263)
    at anonymous (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:35:1096)
    at __guard (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:35:2846)
    at flushedQueue (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:35:1054)
    at callFunctionReturnFlushedQueue (/Volumes/InternalDisk/builds/discord/discord/discord_ios/build_output/main.jsbundle:35:785)
    at apply (native)
    at hook_default (bunny:153:116)
    at runHook (bunny:212:35)
    at apply (bunny:218:46)
    at proxy trap (native)

same!

Do you have a screenshot of the components tab when it crashes?

I'm also having this issue... I'm not too sure if I have the right thing but, heres the "component stack" when it crashes :)
It's pretty long, so I'll probably post another comment with the full thing and not just the screenie

Heres the full thing :D
in Unknown
in RCTView
in Unknown
in AnimatedComponent(View)
in Unknown
in TextInputWrapper
in RCTView
in Unknown
in TouchableWithoutFeedback
in RCTView
in Unknown
in Unknown
in RCTView
in Unknown
in RCTView
in Unknown
in ChatInput
in RCTView
in Unknown
in ChatInputGuard
in ChatInputVerification
in FluxContainer(ChatInputVerification)
in ChatInput
in RedesignCompat
in Unknown
in DCDChat
in Unknown
in Messages
in StartupProfiler
in Unknown
in RCTView
in Unknown
in AnimatedComponent(View)
in Unknown
in StickyWrapper
in Unknown
in RCTView
in Unknown
in KeyboardCloser
in MessagesWrapper
in RCTView
in Unknown
in ImageBackground
in MessagesWrapperConnected
in ChatView
in StartupProfiler
in ChatViewConnected
in RCTView
in Unknown
in StandaloneChannelScreen
in RCTView
in Unknown
in AnimatedComponent(View)
in Unknown
in Wrap
in AnimatedComponent(Wrap)
in Unknown
in GestureDetector
in Suspender
in Suspense
in Freeze
in ChannelScreen
in TransitionGroup
in ThemeContextProvider
in RCTView
in Unknown
in Suspender
in Suspense
in Freeze
in MainTabsChannelScreenStack
in RCTView
in Unknown
in AnimatedComponent(View)
in Unknown
in RCTView
in Unknown
in Wrap
in AnimatedComponent(Wrap)
in Unknown
in GestureDetector
in MainTabsNavigatorPanel
in MainTabs
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(Component)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in ScreenGestureDetector
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in ChatPanelNativeStackNavigator
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(Component)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in ScreenGestureDetector
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in StartupProfiler
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in _default
in RCTView
in Unknown
in AnimatedComponent(View)
in Unknown
in RCTView
in Unknown
in Wrap
in AnimatedComponent(Wrap)
in Unknown
in GestureDetector
in LaunchPadContainer
in RCTView
in Unknown
in StartupProfiler
in StackNavigator
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in SafeAreaWrapper
in RNCSafeAreaProvider
in SafeAreaProvider
in DCDSafeArea
in DCDSafeArea
in SafeAreaProvider
in KeyCommandsView
in KeyCommandsView
in PortalKeyboardContextProvider
in KeyboardControllerView
in Unknown
in AnimatedComponent(Animated(Anonymous))
in Unknown
in KeyboardProvider
in PortalProviderComponent
in ErrorBoundary
in RCTView
in Unknown
in GestureHandlerRootView
in GestureWrapper
in t
in WebViewContextProvider
in EnsureSingleNavigator
in BaseNavigationContainer
in ThemeProvider
in NavigationContainerInner
in AppNavigationContainer
in AppNavigationContainerOrEmpty
in AccessibilityPreferencesContextProvider
in RootThemeContextProvider
in RootThemeContextProvider
in ReanimatedScreenProvider
in StartupProfiler
in AppContainer
in StartupProfiler
in RNCSafeAreaProvider
in SafeAreaProvider
in App
in RCTView
in Unknown
in AppContainer


Source Maps don't appear in a cordova project

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.
@angular/cli: 1.1.1
node: 6.9.1
os: win32 x64
@angular/animations: 4.1.3
@angular/common: 4.1.3
@angular/compiler: 4.1.3
@angular/compiler-cli: 4.1.3
@angular/core: 4.1.3
@angular/forms: 4.1.3
@angular/http: 4.1.3
@angular/material: 2.0.0-beta.6
@angular/platform-browser: 4.1.3
@angular/platform-browser-dynamic: 4.1.3
@angular/platform-server: 4.1.3
@angular/router: 4.1.3
@angular/upgrade: 4.1.3
@angular/cli: 1.1.1
Repro steps.
create a cordova application and build using the angular cli
Desired functionality.
I want source maps to be found. Currently I build for web and source maps are in the .webpack folder. But cordova doesn't give me access to this making debugging much harder than needed
Mention any other details that might be useful.
I think its possible to get this if given the option to use inline source maps, or option to change the path of the source maps

Can you provide us with more detailed repro steps please? I have no idea of how you are creating a cordova application, nor of how you are building it.
Also if you're doing ng build --prod, then it doesn't output sourcemaps by default. You can do ng build --prod --sourcemaps to force it to output them.

This is happening with standard ng build.
I see the .js.map files there but they aren't loaded in to the debuggers.
I think its related to this...
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-discuss/c54b6CxWhwU

We don't provide an option to inline sourcemaps, but you can configure that manually if you eject. I don't know what's happening in the Cordova project proper but as far as I can tell sourcemaps are emitted correctly. I suggest you try asking in stack overflow.


SelectorData add serialVersionUID

Fixes #1238
Fix the problem in OpenJDK (for example, version 1.8.0_65-b17): Caused by: org.I0Itec.zkclient.exception.ZkMarshallingError: java.io.InvalidClassException: org.dromara.soul.common.dto.SelectorData; local class incompatible: stream classdesc serialVersionUID =<PHONE_NUMBER>752212141, local class serialVersionUID =<PHONE_NUMBER>21794874

hi， why our tested not find this bug？ you have old data？

IMO, We should change all classes that implement the serial interface but do not have the serialVersionUID property.

Codecov Report

Merging #1249 (39b3b7a) into master (d46ff76) will decrease coverage by 0.61%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1249      +/-   ##
============================================
- Coverage     70.30%   69.69%   -0.62%
+ Complexity     2096     2090       -6
============================================
  Files           376      376
  Lines          8339     8339
  Branches        908      908
============================================
- Hits           5863     5812      -51
- Misses         2024     2080      +56
+ Partials        452      447       -5

Impacted Files
Coverage Δ
Complexity Δ

...soul/client/tars/TarsServiceBeanPostProcessor.java
23.17% <0.00%> (-59.76%)
5.00% <0.00%> (-9.00%)

...omara/soul/sync/data/http/HttpSyncDataService.java
63.72% <0.00%> (-11.77%)
12.00% <0.00%> (ø%)

.../soul/plugin/httpclient/NettyHttpClientPlugin.java
57.14% <0.00%> (-2.05%)
10.00% <0.00%> (ø%)

.../soul/admin/service/impl/UpstreamCheckService.java
66.35% <0.00%> (+10.28%)
18.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46ff76...39b3b7a. Read the comment docs.


[Flaky Test] Test E2E Gardener Suite: [It] Gardener upgrade Tests for Shoot with workers::e2e-upg-hib when Pre-upgrade (Gardener version:'', Git version:'v1.105.0-dev') should hibernate a shoot [pre-upgrade]

How to categorize this issue?

/area testing
/kind flake
Which test(s)/suite(s) are flaking:
Gardener upgrade Tests for Shoot with workers::e2e-upg-hib when Pre-upgrade (Gardener version:'', Git version:'v1.105.0-dev') [It] should hibernate a shoot [pre-upgrade]
CI link:

https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/10599/pull-gardener-e2e-kind-upgrade/1841385293916147712
https://prow.gardener.cloud/view/gs/gardener-prow/logs/ci-gardener-e2e-kind-upgrade-release-v1-89/1764212465899409408
https://prow.gardener.cloud/view/gs/gardener-prow/logs/ci-gardener-e2e-kind-upgrade/1822100616814530560

Reason for failure:
  [FAILED] Expected success, but got an error:
      <*errors.errorString | 0xc00041d400>:
      failed to verify no running pods after hibernation: found pods in namespace shoot--local--e2e-upg-hib: [etcd-main-0]
      {
          s: "failed to verify no running pods after hibernation: found pods in namespace shoot--local--e2e-upg-hib: [etcd-main-0]",
      }
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/upgrade/upgrade.go:213 @ 10/02/24 08:09:39.872

Anything else we need to know:
N/A

@ialidzhikov would you agree to close this one for now, as the job history seems to be very stable (compared to other jobs). Also, within the previous 30d this error seems to have not occurred.
Of course, we can always reopen this one again in the future. 😉


[Bug]: UniverseLib not working in LemonLoader

All of the following criteria must be met

[X] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the game.
[X] Tried reinstalling LemonLoader.
[X] Tried restarting device.

Describe the issue.
When I try to use UnityExplorer in LemonLoader, it seems to not work, which i think could possibly be a UniverseLib issue because it doesnt seem to load at all. I tried many things such as copying UniverseLib to a bunch of different Directories, and even reinstall ing the game, and nothing seems to help. It keeps giving me the same Error in the logs.
Latest.log
Did you attach your log file?

[X] Yes, I attached my log file to the text box above.
[ ] No, I could not find a log file at /storage/emulated/0/Android/data/<package name>/files/melonloader/etc/Latest.log

I even tried the following UnityExplorer Versions: 3.3.3,3.3.4,3.3.7,2.0.0,4.0.0
Either it leaded to a Crash (2.0.0) or it gives another Error (3.X.X) about MelonLoader.Tomlyn.Model.TomlObject having an issue with HarmonyInit.
Latest.log
I have no idea on what else it could be, since the errors Don't give a lot of information on what exactly Went wrong.

It looks to be an issue with UE/UL specifically, which makes sense considering that the dev never implemented Lemon support into either tool.


Update dotnet-sql-cache to use Microsoft.Data.SqlClient

Follow up to https://github.com/aspnet/AspNetCore/issues/10013
dotnet-sql-cache uses System.Data.SqlClient. If there is sufficient interest, we could update it to use the new client, Microsoft.Data.SqlClient. The impact of this on consumers should be negligible because this package is a console tool and which version of the client should be hidden from the user.

I'll see if I can get this done to remove the System.Data.SqlClient dependency.

The basic work is done. #12957 is the follow-up to get us on RTM when their RTM is available.

Why is this issue still open @BrennanConroy? Isn't everything tracked in #12957?

This happened, issue is just out of date :). Closing.


Unable to analyzer app in .NET Core 3.0 Desktop API Analyzer

Unable to analyze.
Details:
Detecting assembly references                      [Failed]

Cannot locate assembly information for System.Object. Microsoft assemblies found are:

Cannot locate assembly information for System.Object. Microsoft assemblies found are:

Cannot locate assembly information for System.Object. Microsoft assemblies found are:

Cannot locate assembly information for System.Object. Microsoft assemblies found are:

Can I somehow provide logs of some kind?

Getting this as well on one of three apps I've tested (this one is by far the most complex, with a mix of VB.NET and C#, and WinForms and WPF).
It does not happen if I use the command-line version and explicitly set the -f argument to the .exe rather than the entire directory, so the problem is presumably with one of the dependencies in the directory.

Same error message for me when running PortabilityAnalyzer.exe on my WPF app.

I have the same issue with my app.

I was able to pinpoint it down to a DLL, namely de\Microsoft.SqlServer.Types.Resources.dll. I'm therefore guessing this is a problem with resource DLLs.

@chucker great analyses. I've removed all the resource assemblies from the app and now it works fine, thanks 👍

@conniey @twsouthwick
It looks like API Port cannot analyze resource assemblies (*..resources.dll) as those have no references (not even to mscorlib). That seems to crash the MD reader. I suggest we exclude any files that are named *.resources.dll. Is this something we can fix? A lot of our customers are hitting this now with the .NET Core 3.0 runs against WinForms/WPF assemblies.

@terrajobst I wrote a possible fix in #699.
In the meantime, temporarily moving out the resource assemblies while testing a directory is an OK workaround.

Thanks @chucker. Yes, deleting the resources file is a possible workaround.

(Do I need to ping someone to ask them to review my pull request?)

I'm pinging the API Port team. Your fix looks reasonabe to me but I'm hesitant to accept your changes as this isn't my code base. I'd rather @conniey or @twsouthwick would review & merge your PR.

I can confirm both problem and workaround.
Maybe worth mentioning: my first instinct was "this is caused by VB" because of the "System.Object" message - there are situations with packages that target the CLR (like Fody), where the "Missing System.Object" problem with VB projects pops up here and there.
But after simply removing System.Net.Http.Formatting.resources.dll in my case, I was able to analyze a very complex 4.7.2 WPF application, mixed VB and C# with no further issue. Made me happy :)

Seeing the same issue here with *.license.dll files, stemming from external components from GrapeCity.


Filename of image shared out has file extension .jpe rather than .jpg or jpeg

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.

Affected version
v+
Steps to reproduce the bug

click on image of a tweet
from the menu choose Share, Quacker will download the file in the background and show the share sheet
In the receiving app, the shared image file has a filename extension .jpe. This is usually OK when the file is use in Android, since most of the apps dealing with picture will resort to mimetype rather than filename extension to determine file type. But when the file is upload to a server like Nextcloud, the server will have a hard time recognizing it. BTW, when you choose Download in the menu, the downloaded file has correct extension of .jpg

Expected behavior
When share image file, use a common file extension like .jpg or .jpeg
Actual behavior
No response
Screenshots/Screen recordings
No response
Logs
No response
Affected Android/Custom ROM version
No response
Affected device model
No response
Additional information
No response

This seems to be an issue with the package I am using for sharing. I will continue to look for a fix

Good idea, I created a PR for Fritter.


[BUG] Incorrect display of a quote in a channel with a title from two or more words.

Your Rocket.Chat.Android version: 2.5.1
Mobile device model: Xiaomi Redmi 3
OS version: MIUI 9.6 (<IP_ADDRESS>) , Global Stable
Your Rocket.Chat Server version: 0.68.4
An erroneous display of a quote in a channel with a heading of two or more words, the first of which begins with a capital letter. In other channels, everything is fine. The desktop client and the chat in web interface are ok.

Confirmed bug (weird)! Nice finding @Pitstopper


EC256 signature is incompatible with RFC-7518

The library creates ES256 JWS signature as DER encoded ASN1 sequence, but it have to be concatenated R and S ECPoints.
See https://tools.ietf.org/html/rfc7518#section-3.4
The problem code is https://github.com/namshi/jose/blob/master/src/Namshi/JOSE/Signer/OpenSSL/PublicKey.php#L25
The right example is
https://github.com/lcobucci/jwt/blob/master/src/Signer/Ecdsa.php#L82
With best wishes, Roman

Confirmed ES256, ES384 .. etc not working.
I just realized the same issue ... this lib is not implementing RFC7518 correct.
case:

create private & public key with ES384.
use the private key and this lib to sign the token
use the signed token generated by this lib and try to validate it using the public key and this tool:
http://kjur.github.io/jsjws/tool_jwt.html

Hey guys,
would you mind sending a PR for this to get fixed? We mostly use RSA so I dont have a good hang of how ECDSA works :)

This is a reference in Java which can be stacked on top on current OpenSSl impl:
https://github.com/jwtk/jjwt/blob/master/src/main/java/io/jsonwebtoken/impl/crypto/EllipticCurveProvider.java

This is my impl for ES384:
$sig = base64_decode(strtr($sigB64, '-_', '+/'), true);
$rawLen = 48; // ES384
for($i = $rawLen; $i > 0 and $sig[$rawLen - $i] == chr(0); $i--) {}
$j = $i + (ord($sig[$rawLen - $i]) >= 128 ? 1 : 0);
for($k = $rawLen; $k > 0 and $sig[2 * $rawLen - $k] == chr(0); $k--) {}
$l = $k + (ord($sig[2 * $rawLen - $k]) >= 128 ? 1 : 0);
$len = 2 + $j + 2 + $l;
$derSig = chr(48);
if($len > 255){
	throw new RuntimeException("Invalid signature format");
}elseif($len >= 128){
	$derSig .= chr(81);
}
$derSig .= chr($len) . chr(2) . chr($j);
$derSig .= str_repeat(chr(0), $j - $i) . substr($sig, $rawLen - $i, $i);
$derSig .= chr(2) . chr($l);
$derSig .= str_repeat(chr(0), $l - $k) . substr($sig, 2 * $rawLen - $k, $k);

$verified = openssl_verify($headB64 . "." . $payloadB64, $derSig, "-----BEGIN PUBLIC KEY-----\n" . wordwrap($key, 64, "\n", true) . "\n-----END PUBLIC KEY-----\n", OPENSSL_ALGO_SHA384) === 1;

hey @ishitatsuyuki would you mind sending a PR? We mostly use RSA so I dont have a good hang of how the ES family works :)

I have only implemented verify only and not sure where to insert these code by your design. This is just converting between sign format, thus you don't have to understand how it works. Please take a look at the reference Java code.

I think I've managed to build a more clear, universal and bidirectional (sign & verify) solution, however I'd like to keep it private until it's tested against at least one known-good implementation. As the only other library I'm firm with (jsrsasign) seems to have the same problem (expects ASN1), could someone contact me to test my implementation? (That's why I want to keep it private, I think it's a very bad idea to just publish another non-standard, non-working Implementation which only brings massive confusion.)
As soon as it's tested, I'll send a PR - that's why I wrote it.

Have a look on my PHP library to deal with that bug.
I hope it will help you.

@Spomky That's the first thing I've considered when facing this bug, however I'd like to avoid ext-gmp, which is required by fgrosse/phpasn1, while phpseclib used in this impl is working w/o an additional PHP Extension (In theory, like shown above, the whole ASN1-parser could be avoided, but this make the code a bit messy and therefore vulnerable)

You don't need GMP. Look at https://github.com/Spomky-Labs/jose/blob/master/src/Algorithm/Signature/ECDSA.php#L52
The method that uses GMP is just a fallback in case openssl does not support EC signatures

@Spomky is it possible to open a PR against this repo?

@Spomky Isn't Integer, Sequence part of phpasn1, which represents the integers with gmp internally? However, I'd need to force my 'dependency manager' to ignore dependencies, which I'd like to avoid.

You are right fgrosse/phpasn1 requires GMP.
If you know an ASN.1 parser that does not requires GMP, then I will try to create a PR.

phpseclib ;-)


Bug on multiple discounts for each product in an order

We have discovered a problem:
list of prestashop products: https://gyazo.com/53404b9ec77f63cbd655e0f976435b95
list of discount for each accessories: https://gyazo.com/b789dc0a7b335e133ea601cba0891fd9
Total is wrong:

must be 145.91€
When customer will pay with PAYPAL this is what paypal processing:
List of products: https://gyazo.com/b52725c76727f0da3c4168828a49486b
List of discounts: https://gyazo.com/69d959bd52af56d73cdf971c99c5ca2f
Total order on Paypal:

When the Order is passed to paypal we can see what is the problem, because discounts are progressive lower!
only the first product discount is right: -5.70€, the other discounts are progressively lower!
And the total si wrong again, because using excel the toal must be:

PS <IP_ADDRESS>
PHP 7.2
Paypal Module  v5.1.5
Warehouse theme
Round settings:

Hello @HartLarsson
Thank you for reporting us this issue !
We will do some tests and fix it in the next version of the module.
Thank you for your help and have a nice day !
Best regards,
202 ecommerce

Hello,
We have a couple of questions :

from where this screenshot was taken ? Is it a page in the PrestaShop ?

do we understand well  that you added some specific discounts for each product via its product page in the BO (Product settings-Pricing-Add a specific price : https://prnt.sc/uj0g3y)?

Thank you !
Regards,

hi, the product discount are created by vouchers.
I've reported to prestashop github too, where you can see more information how the voucher is configured here: https://github.com/PrestaShop/PrestaShop/issues/20981#issuecomment-692835862

other bad calculation case:

all orders with muktilple discounts return a Wrong Total!

I attach the 4 records of the previous order in csv format so you can control what prices aer inside the database.
I've checked and all is fine seems Prestashop do a wrong calculation but i don't know why.
I'm unable to find out the problem.
ps_order_detail.zip

anothe rorder with 1 product and 3 accessories with same price and same discount of 30%
As you can see the discounts in Paypal are not the same -5,70 but only the first one is right the other 2 progressively decreases (wrongly)

Hello,
Thank you for your messages.
If I understand well the amounts on PrestaShop and PayPal are the same.
PayPal module takes the data provided by PrestaShop.
So, if there are some issues with the calculation on the PrestaShop side I advice you to handle this issue with PrestaShop directly.
Best regards,
202 ecommerce

is not true.
Your module take all discounts and change the value as shown in the previous image.
in pestashop all the discounts are the same value but on paypal aer loaded differently .

Hello,
Thank you for your message. In order to understand you request better and to check the issue in your environment we have to get more examples. Please contact our support team. We will help you to solve the issue.
Thank you in advanced !


Module formats should include links to their respective websites

e.g. https://6to5.org/docs/usage/modules/#umd should include a link to https://github.com/umdjs/umd

:+1:

Added links to plugin pages http://babeljs.io/docs/plugins/#modules


Can this copybook be parsed as multi segment use case?

Hi,
Below (image) is our copybook. The field in red rectangle is segment id. When we try to parse the ebcdic data file with .option("segment_field", "SRC1-DG-77.SRC1-DG-N") and .option("segment_filter", "111"), it works fine and gets data for SRC1-DG-77.SRC1-DG-N = 111 but when we try to parse the next segment with  .option("segment_field", "SRC1-DG-78.SRC1-DG-N") and .option("segment_filter", "222") we get an error "java.lang.IllegalStateException: Field 'SRC1-DG-78.SRC1-DG-N' is not found in the copybook." It seems like it is trying look for SRC1-DG-78.SRC1-DG-N in segment "77".
My question is - Can this copybook be considered as multi segment use case? Is so what will be the right way to parse this as multi segment.

Thanks,
Paresh

Hi Paresh,

Try using full path to the segment id field e.g. SRC1-PWR-78.SRC1-DG-78.SRC1-DG-N for segment filtering. In your example you didn't include the first element of the path, it might confuse Cobrix. Alternatively, you can use "SRC1-DG-77.SRC1-DG-N" a s segment id field and filter by "222"
since location of this field is the same in both segments.
For multisegment files it is expected for segments to redefine each other. I think 'SEC1-PWR-78' group should redefine 'SRC-PWR-77':

      01 SRC-PWR-78 REDEFINES SRC-PWR-77.

Also, since all the segments have the same header, I'd recommend to extract that header in a separate GROUP andput it at the beginning of of the copybook.


Readd VIP if address has dadfailed flag

Remove and re-add the address to the interface in the case that a duplicate address is detected. Without this change, kube-vip will take no corrective action, and the address will remain in dadfailed state. Removing and re adding the address causes duplicate address detection to happen again, hopefully successfully the next time. This behavior only applys to IPv6 addresses, as IPv4 addresses cannot get into the dadfailed state.
We suspect dadfailed happens when a new leader is elected and the old leader is too slow or fails to delete the IP address.
We attempted to add a test, but we find it impossible to reliably trigger a dadfailed state on the leader node. During manual testing we were occasionally trigger the scenario and see that this PR has the desired effect.
fixes: #523

We reviewed our PR and realized there's a block of duplicate service related code that ensures the VIP and sends gratuitous updates. We realized that the duplicate code is also prone to the same dadfailed errors. We've extracted the common code to a function that both code paths now use.
We've manually tested the change for the control plane VIP code path, and see it has the desired effect.
We've not manually tested the service related code path, we're unsure how to do so. The service-e2e's look to have substantial tests. This PR relies on those tests.
We're done making updates for this PR, and we now think this PR is ready for review. Sorry about the spam.

/lgtm


[FLINK-6268] [core] Object reuse for Either type

Implement object reuse for Flink's Either type by storing a reference to Right in Left and Left in Right. These references are private and remain null until set by EitherSerializer when copying or deserializing with object reuse.

+1.

@zentol thanks for the review. I pushed a second commit to mark the added static methods as @Internal and renamed from asLeft/Right to obtainLeft/Right.

Additional changes look good as well :)


add testing environment indicator to the logger

Description
Following a recommendation from the structlog docs on testing. Needed so that I can actually test the log output from various warnings and errors in developing the Wastewater endpoint https://github.com/cmu-delphi/delphi-epidata/pull/1513. Marked as a draft because I am still testing that this is all that's needed to be able to test the logger.
Changelog

Adds another option to get_structured_logger(name, filename, log_exceptions, *is_real=True*) indicating whether to log as if in a testing environment
A bunch of formatting things that ruff decided were Correct. Can remove if they're a problem.

@dsweber2 I would suggest adding @minhkhul as a reviewer, I know that she's working with some elastic and logging stuff I feel like she would be able to give some insight on that part

Mostly unrelated, but I would definitely prefer if we dealt with formatting stuff all in one PR.

If in your case, test runs are 1. also run on prod, and 2. the logged info must be output to the same log file as real runs, then the is_real addition makes sense.
But elastic allows us to distinguish different kinds of run using server names and/or the dir where log are output to. So far, that's been enough to help distinguish things. I think it's a good idea to separate where we put real log files and test log files anyway.
So instead of adding a flag, I suggest doing those 2 things first if possible (run test on staging and/or output log of test to a separate location from real logging).
If you want to, you can set up an elastic ingest pipeline to take advantage of elastic's log parsing by doing these:

Put your test log file into something like /var/log/test-wastewater/
Set up an elastic ingest pipeline like this
Add pickup configuration like this so your test log are automatically picked up and put into the ingestion pipeline you created in step 3.
Then you can make dashboard like this

@minhkhul the point of this is to make it easier to evaluate the application's logging functionality in a sandboxed test environment; Elastic isnt part of the scope.
I would lean towards removing the formatting changes from this PR, they distract from the core diffferences being applied and the rationale.

Thanks all for the comments, I eventually figured out a way around it without having to modify the functionality of get_structured_logger while using pytests.


Adding cron-based sheduled start definition

Many thanks for submitting your Pull Request :heart:!
Please specify parts this PR updates:

[x] Specification
[x] Examples
[x] Schema
[x] Roadmap
[ ] Use Cases
[ ] Community
[ ] Website
[ ] SDK
[ ] TCK
[ ] Other

What this PR does / why we need it:
Addresses issue https://github.com/cncf/wg-serverless-workflow/issues/31
Adds cron-based scheduled start definition
Special notes for reviewers:
Additional information (if needed):

@singhkays Hi, can you please take a look? Thanks!

@ricardozanini thanks for review!!!!! ill update asap!

Thanks for the review @singhkays !

@singhkays @ricardozanini I made some updates to this PR after our discussions on the issue and also after thinking about this some more :)
@singhkays
I have used your overloading idea which I thought was very good. Please look at the updates to see if they fit your needs better now.
Basically the start definition now you can do either (for scheduled):
"start": {
              "kind": "scheduled",
              "schedule": {
                "interval": "2020-03-20T09:00:00Z/2020-03-20T15:00:00Z"
              }
          }

or
"start": {
            "kind": "scheduled",
            "schedule": {
                "cron": "0 0/15 * * * ?"
            }
        }

I have also lifted the restriction of event based starting states not being able to use the cron definition, however added a note
for runtime implmentors on what should happen in order to trigger workflow instances in this scenario
WDYT?

@tsurdilo Overloading looks good 👍
Re: below

Defining a cron-based scheduled starts for the runtime implementations would mean that there needs to be an event service which issues
the needed events at the defined times to trigger workflow instance creation.

I'm trying to understand a couple of things:

What would happen if the event was sent at a time other than cron specified time (e.g. 0 0/15 * * * ?)?
To write a workflow in the example I described above, would I use Event state or Operation state as the starting state to allow ad-hoc execution in addition to cron scheduled execution?

@singhkays
It is really up to the runtime engine for 1. and 2. to allow/not allow instance creation outside the cron/interval definitions IMO for both Event and Operation (+ other non-event-triggered starting) states.
Do you think that we should add a flag for this behavior where the default should be not to be able to create instances outside what is defined but can be set to allow it? I think this decision should be something the person modeling a workflow should set as its most likely mandated by business requirements, rather than depending on some behavior of the runtime (which can differ from one to another)?

Interesting.. I can see a use-case of not allowing a said cron workflow outside of scheduled time.
I'm not too sure if the default should be to block or allow. In my experience, choosing a default is always tricky in cases where users don't read the docs and end up shooting themselves in their foot :) Could the default option be an item that could be voted on by the larger community so we can get more eyes on it?

@singhkays sure, we could bring this up in our next meeting. @manuelstein if you don't mind can we add this as an agenda item ? thanks.

@singhkays we could also not have a default and force a decision to be made with a boolean param for example. I just thought having a default could be useful but I see from your point that yes it can be tricky.

@tsurdilo Can you show me an example of how a boolean param would look in the spec?

@singhkays
Let's say we call this param "directInvoke" with possible values "allow" and "deny" we could have for example:

Don't set "allow" or "deny" as default in the json schema, thus making this param required:

 "start": {
   "kind": "scheduled",
   "schedule": {
   "cron": "0 0/15 * * * ?",
   "directInvoke": "allow"
   }
}

Set "allow" as default value of this param (thus making it not required in json schema, and its use would be to overwrite the default with "deny"):

 "start": {
   "kind": "scheduled",
   "schedule": {
   "cron": "0 0/15 * * * ?",
   "directInvoke": "deny"
   }
}

WDYT? (Names of param and its values are of course tbd :) )

rebased

I like the first option. It forces the user to chose an option. Also if they didn't read the documentation, the schema forces them to read upon the usage of this option.
For the naming, need to think this through. Something that is anti of a "scheduled execution" might be more clearer. For e.g. adhocExecution but that's a terrible example 😆

@singhkays
agree with the first option as well.
for the name, yeah let me know what you'd like to see used. Ad-hoc is typically used in workflows/processes to describe unstructured processes where theirs flow is not pre-defined, something we are planning to add to spec in the future so I'd like to reserve that word for that if possible :)

Reserving ad-hoc for future features sounds good. Can't think of another name atm so open if others have suggestions. If not, directInvoke will do.

rebased

@singhkays added the directInvoke param. Yes let's make a decision on this is you want in our next meet. I think time zone can be figured out by the runtime impls.

@tsurdilo Do we need a parameter for time zone? How would a runtime implementation take in the input from the user?

rebased

@singhkays my understanding is that time zone can be figured out by the runtime impls. Let me know if you agree or not. If you think we need a specific param we could add, but I assume if thats the case it could be also needed as input to other definitions. Would setting a time zone as a metadata input on the workflow def level work for you ?

Metadata approach might work but it might be better to be more explicit as I'm not sure another place in the spec where a timezone is needed. I was looking into Argo workflow example comparisons and came across this as one of the options for cron workflows in Argo docs.

@singhkays good point. agree with you and added the timezone property. Let me know what you think. Thanks.

👍  lgtm

rebased

@singhkays in our meet today I think everyone was OK with the changes made in this PR. Can you give it a "final GO" and I will merge it :) Thanks!

@tsurdilo lgtm 👍


Fix CI Test Discovery

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

Closing. Will reopen on upstream branch.


Mouseless don't respect palm rejection setting

On most desktop on linux, palm rejection is enabled by default. However, mouseless doesn't respect this setting:
To reproduce, on a gnome desktop set /org/gnome/desktop/peripherals/touchpad/disable-while-typing to true in dconf.
Try to type and moving the trackpad at the same time with mouseless enabled will see the mouse cursor moves normally; if the mouseless service is disabled, then the trackpad input will be ignored when the keyboard is typing.

I think this is a duplicate of #50, so I will close this one.
In the other issue I linked a possible solution, I don't know if there is a way to fix this in mouseless directly as it creates a virtual keyboard device, which is treated like an external keyboard by default.


Update boilerplate and generate CSV through boilerplate scripts

This PR contains 2 main changes:

Update boilerplate
Rename the CSV template so that it can be used by boilerplate CSV generation.

/lgtm

/approved

/hold cancel


Improve error handling

Rather than checking for 0-size responses from the component tools, we should check for status codes.
We should pass along errors and logs from the underlying elements, esp strider.
If a component fails, we should return whatever we got to up to that point, rather than returning nothing.  Everything after strider is a valid response, even if it does not have everything we want.

Also, I think that if strider "returns nothing" we're printing an error message, returning an empty message, but returning a 200 status code.
If strider is returning an error code, then we should too.  If we return 200 we should return a trapi message with at least the query graph, plus empty knowledge_graph and results.

corrected in the the PR #14 merge listed above.


CppADCogen couldn't found in recent devel branch

Hi guys,
I want to report this issue that I only encounter in the devel branch, just in case you're not aware of it.
This is the current error message:
CMake Error at cmake/package-config.cmake:82 (find_package):
  By not providing "Findcppadcg.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "cppadcg", but
  CMake did not find one.

  Could not find a package configuration file provided by "cppadcg"
  (requested version 2.4.1) with any of the following names:

    cppadcgConfig.cmake
    cppadcg-config.cmake

  Add the installation prefix of "cppadcg" to CMAKE_PREFIX_PATH or set
  "cppadcg_DIR" to a directory containing one of the above files.  If
  "cppadcg" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  CMakeLists.txt:115 (ADD_PROJECT_DEPENDENCY)

This is expected because CppADCG does not come with cmake module. Could you fix it? Thanks in advance.

For reference: https://github.com/loco-3d/solo-collisions/tree/master/cmake-modules

@jcarpent : should I put that in the jrl-cmakemodule ?

I would say yes. Thanks a lot @nim65s.

thank @nim65s for handling this task :)


Default self-representation should be avatar, not point cloud

Making avatar the default representation should help on-boarding (because there are fewer things that can go wrong when you first start VR2Gather.

We should also check that once this is implemented, if you run VR2Gather without first installing cwipc, it either works, or you get a decent error message.

Unfortunately the latter needs to be fixed in cwipc. Leave it for now.


Fusion gateway can't return list of a union type

Is there an existing issue for this?

[X] I have searched the existing issues

Product
Hot Chocolate
Describe the bug
I have a subgraph with a type which as a union type list field.
When I query the field via fusion gateway I get an execution error. Switching the union type to an interface type makes the gateway return the values.
It seems, that fusion can not handle union types on list fields.
Steps to reproduce

Create a subgraph with a type which has field with a union type list
Query for the type and field on the fusion gateway
It should create and error

Relevant log output
{
  “errors”: [
    {
      “message”: “Unexpected Execution Error”,
      “extensions”: {
        “message”: “The type structure is invalid.“,
        “stackTrace”: ”   at HotChocolate.Types.TypeExtensions.ListType(IType type)\n   at HotChocolate.Types.TypeExtensions.ElementType(IType type)\n   at HotChocolate.Fusion.Execution.ExecutorUtils.ComposeList(FusionExecutionContext context, ResultData parent, Int32 parentIndex, Selection selection, SelectionData selectionData, IType type)\n   at HotChocolate.Fusion.Execution.ExecutorUtils.ComposeElement(FusionExecutionContext context, ResultData parent, Int32 parentIndex, Selection selection, SelectionData selectionData, IType valueType)\n   at HotChocolate.Fusion.Execution.ExecutorUtils.ComposeList(FusionExecutionContext context, ResultData parent, Int32 parentIndex, Selection selection, SelectionData selectionData, IType type)\n   at HotChocolate.Fusion.Execution.ExecutorUtils.ComposeResult(FusionExecutionContext context, SelectionSet selectionSet, SelectionData[] selectionSetData, ObjectResult selectionSetResult)\n   at HotChocolate.Fusion.Execution.ExecutorUtils.ComposeObject(FusionExecutionContext context, ResultData parent, Int32 parentIndex, ISelection selection, SelectionData selectionData)\n   at HotChocolate.Fusion.Execution.ExecutorUtils.ComposeResult(FusionExecutionContext context, SelectionSet selectionSet, SelectionData[] selectionSetData, ObjectResult selectionSetResult)\n   at HotChocolate.Fusion.Execution.ExecutorUtils.ComposeResult(FusionExecutionContext context, WorkItem workItem)\n   at HotChocolate.Fusion.Planning.Compose.OnExecuteAsync(FusionExecutionContext context, ExecutionState state, CancellationToken cancellationToken)\n   at HotChocolate.Fusion.Planning.QueryPlanNode.ExecuteAsync(FusionExecutionContext context, CancellationToken cancellationToken)\n   at HotChocolate.Fusion.Planning.QueryPlanNode.OnExecuteNodesAsync(FusionExecutionContext context, ExecutionState state, CancellationToken cancellationToken)\n   at HotChocolate.Fusion.Planning.QueryPlanNode.ExecuteAsync(FusionExecutionContext context, CancellationToken cancellationToken)\n   at HotChocolate.Fusion.Planning.QueryPlan.ExecuteAsync(FusionExecutionContext context, CancellationToken cancellationToken)\n   at HotChocolate.Fusion.Execution.FederatedQueryExecutor.ExecuteAsync(FusionExecutionContext context, CancellationToken cancellationToken)\n   at HotChocolate.Fusion.Pipeline.DistributedOperationExecutionMiddleware.InvokeAsync(IRequestContext context, IBatchDispatcher batchDispatcher)\n   at HotChocolate.Execution.Pipeline.OperationVariableCoercionMiddleware.InvokeAsync(IRequestContext context)\n   at HotChocolate.Execution.Pipeline.OperationResolverMiddleware.InvokeAsync(IRequestContext context)\n   at HotChocolate.Execution.Pipeline.OperationComplexityMiddleware.InvokeAsync(IRequestContext context)\n   at HotChocolate.Execution.Pipeline.OperationCacheMiddleware.InvokeAsync(IRequestContext context)\n   at HotChocolate.Execution.Pipeline.DocumentValidationMiddleware.InvokeAsync(IRequestContext context)\n   at HotChocolate.Execution.Pipeline.DocumentParserMiddleware.InvokeAsync(IRequestContext context)\n   at HotChocolate.Execution.Pipeline.DocumentCacheMiddleware.InvokeAsync(IRequestContext context)\n   at HotChocolate.Execution.Pipeline.TimeoutMiddleware.InvokeAsync(IRequestContext context)\n   at HotChocolate.Execution.Pipeline.ExceptionMiddleware.InvokeAsync(IRequestContext context)”
      }
    }
  ]
}

Additional Context?
No response
Version
13.3.0

Is this still true with 13.4?

Nope. It is fixed with 13.4.  👍


GCC 14: error: assignment to ‘my_bool *’ {aka ‘char *’} from incompatible pointer type ‘int *’ [-Wincompatible-pointer-types]

Trying to build LuaDBI 0.7.2 on Fedora Rawhide using GCC 14 fails like this (report from Fedora mass rebuild):
gcc -c -o build/dbd_mysql_statement.o dbd/mysql/statement.c -I/usr/include -g -pedantic -Wall -O2 -shared -fPIC -DPIC -std=c99 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I. -shared -Wl,-z,relro -Wl,--as-needed   -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld-errors -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes  -I/usr/include/mysql -L/usr/lib64/mysql -lmysqlclient
dbd/mysql/statement.c: In function ‘statement_execute’:
dbd/mysql/statement.c:221:33: error: assignment to ‘my_bool *’ {aka ‘char *’} from incompatible pointer type ‘int *’ [-Wincompatible-pointer-types]
  221 |                 bind[i].is_null = (int*)1;
      |                                 ^
dbd/mysql/statement.c:230:33: error: assignment to ‘my_bool *’ {aka ‘char *’} from incompatible pointer type ‘int *’ [-Wincompatible-pointer-types]
  230 |                 bind[i].is_null = (int*)0;
      |                                 ^
dbd/mysql/statement.c:245:33: error: assignment to ‘my_bool *’ {aka ‘char *’} from incompatible pointer type ‘int *’ [-Wincompatible-pointer-types]
  245 |                 bind[i].is_null = (int*)0;
      |                                 ^
dbd/mysql/statement.c:256:33: error: assignment to ‘my_bool *’ {aka ‘char *’} from incompatible pointer type ‘int *’ [-Wincompatible-pointer-types]
  256 |                 bind[i].is_null = (int*)0;
      |                                 ^
make: *** [Makefile:82: build/dbd_mysql_statement.o] Error 1

Because of commit e951acfb0adf385a1cdf6d2a4b68435d62510a2b, only 3 not 4 occurrences exist in current code in Git.

Weird thing is, MySQL docs explicitly say to do this.
Pullrequest #75 includes a fix. I am uncertain if it will work with MySQL 8 as they've changed the name from 'my_bool' to 'bool'.

Fedora builds against MariaDB Connector/C, not MySQL directly.

Fedora builds against MariaDB Connector/C, not MySQL directly.

LuaDBI currently supports both MySQL and MariaDB - and one pointer cast is not enough to justify forking the driver. I'm forced to keep both in mind at all times.

I'm sorry, this was meant as information only, given you referred to MySQL 8 specifically. But sounds like some #ifdef or so is maybe needed?

I don't think an ifdef is needed - Finally got hold of a MySQL 8.0.36 system to test #75 with and it compiled without any warnings.
I think that resolves this issue, okay to close?

In general yes. May I ask how far we are from a LuaDBI release? So is it worth to backport or is a release just around the corner?

I'd like some more feedback that the merged pull request resolved the original problem. That's the only thing stopping me from a release at this time. If I don't hear anything soon I will likely release it anyway.

@sparked435, I am sorry, but building v0.7.3 fails on Intel/AMD 32 bit like this now (other architectures are building fine):
gcc -c -o build/dbd_mysql_statement.o dbd/mysql/statement.c -I/usr/include -g -pedantic -Wall -O2 -shared -fPIC -DPIC -std=c99 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -I. -shared -Wl,-z,relro -Wl,--as-needed  -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld-errors -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes  -I/usr/include/mysql -L/usr/lib/mysql -lmysqlclient
dbd/mysql/statement.c: In function ‘statement_execute’:
dbd/mysql/statement.c:271:40: error: assignment to ‘long unsigned int *’ from incompatible pointer type ‘size_t *’ {aka ‘unsigned int *’} [-Wincompatible-pointer-types]
  271 |                         bind[i].length = str_len;
      |                                        ^
make: *** [Makefile:82: build/dbd_mysql_statement.o] Error 1


Removes the Lagrange form of the SRS

Description
As discussed in slack -- the lagrange form of the SRS is no longer needed due to the advancements made in R&D.
This PR removes the lagrange form of the SRS.
Changes:

First commit, I just grepped the codebase for lagrange being used with pippenger and removed it

Second commit; I did the IFFT of the wire polynomials before committing to them, which made their monomial form available to commit to. The monomial form can be fetched from the polynomial cache by using the wire_tag without the lagrange postfix.

Checklist:

[ ] I have reviewed my diff in github, line by line.
[x] Every change is related to the PR description.
[ ] I have linked this pull request to the issue(s) that it resolves.
[ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[x] There are no circuit changes, OR specifications in /markdown/specs have been updated.
[x] There are no circuit changes, OR a cryptographer has been assigned for review.
[ ] I've updated any terraform that needs updating (e.g. environment variables) for deployment.
[x] The branch has been rebased against the head of its merge target.
[x] I'm happy for the PR to be merged at the reviewer's next convenience.
[x] New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
[x] If existing code has been modified, such documentation has been added or updated.

(I can't compile locally so I'm using the CI as a way to compile -- should be fine as it gets squashed :) )


Release Planner error when creating a release plan for management plane

Attempted to create a release plan for feature for Backup Service.  The release plan states it was created by it does not show up in "your release plans".   The product is "Cross Region Restore for Backup Vaults".   It is onboarded already using the release planner.  Here is the ADO work item that was created - https://dev.azure.com/azure-sdk/Release/_queries/edit/14994/?triage=true.

@ladonnaq if you refresh the browser you will see the new version of the App (1.0.0-beta.5).
When you do that, do you still see the Release plan missing?

@maririos I am still getting the error.  I am using the release planner AKA link for PROD which is https://aka.ms/release-planner-preview.  Let me know if I need to do something in my environment (clear cache, etc).


add topic tag "deep-learning"

I suggest adding the topic deep-learning in the About section.

Thanks for the suggestion! Added the topic.


fixed commit error because of chaning vlans

chaning a vlan from an access interface from for example 101 to 102 caused this:
bad_element: members 101-102, message: error: Vlan range format not supported if interface-mode is access
chanhing the action between overwrite & replace didnt help. also the new junos_config module didnt fix it.

please correct me if I'm wrong or if i didn't think this through :)

Hi
Currently the expectation is that configuration will be deploy using overwrite, the new configuration will completely delete the previous one.
I think there is a bug with the current module junos_config regarding overwrite that is not working.
As a workaround, you can use junos_install_config
Damien

right now we are using junos_template as junos_config has the state "preview".
the provided pb.conf.all.commit.galaxy.yaml doesnt seem to work for me but i'll look into it.
also this bug affects pb.conf.all.commit.yaml so I do think it isnt't just for me :)

pb.conf.all.commit.galaxy.yaml doesnt seem to work for me
That is surprising, let me know if you need help to make to work

I've just noticed that overwrite doenst seem to work at all for me. for example removing force-up from a lacp interface isnt working.
ansible <IP_ADDRESS>

I've just noticed that overwrite doenst seem to work at all for me.

With which module ? I would recommend junos_install_config for now

Closing for now


Versatile test suite package for *_moveit_config idea

Just an idea...
Requirement

Who (Consumer): X_moveit_config packages that want to test themselves from within.
What to test:

Tests for X_moveit_config packages (not moveit itself).
Minimum:

move_group.launch launches.
Get the default, init pose that is deduced from SRDF. Get the joint values from the runing instance and validate.

Advanced:

IF group_state(s) is defined, see if moving to them goes well. Get the joint values after the move and validate with those defined in each group_state.
Get reachability (by reuleaux?) and command a pose to randomly chosen poses among them?

How users can use:

Minimal usage: No class, script generation needed, ideally. Maybe only a launch file. Something like:

roslaunch moveit_commander derivedpkg.test pkg:=nextage_moveit_config

If in X_moveit_config packages there's a class derived from MoveitCommander (e.g. Hironx' ROS_Client) where pre-defined trajectory is available (e.g. goInitial), run it.

Development constaints

Not all robot packages that use moveit utilize MoveGroupCommander (rtmros_hironx & rtmros_nextage are the rare cases where the robot client component inherits MoveGroupCommander). So the test suite needs to instantiate move groups without relying on MoveGroupCommander.

Ref. roscon2016 proposal

Can't ignore what MoveIt! prepares for the tests.

No more interested in this.


[$500] IOU- In distance request, user unable to edit amount

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.90-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Launch app
Tap on a Workspace chat
Tap plus icon and select request money
Tap distance
Enter start and finish waypoints
Tap next
Tap on Amount

Expected Result:
When user taps on amount, he must be able to edit amount.
Actual Result:
When user taps on amount, it does not trigger any action and user unable to edit amount.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome
https://github.com/Expensify/App/assets/115492554/951a59e4-90e2-459a-99b4-3635f7a209e7

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0116de5be45e362471
Upwork Job ID:<PHONE_NUMBER>168441856
Last Price Increase: 2023-10-25

@izarutskaya, @dukenv0307 Should the user be able to change the value manually or just using distance?
I believe that this value is automatically calculated according to the ratio and distance entered.
The issue here is that the value is calculated once, and then when changing the starting or ending points, the value is not recalculated. There is already an issue  about this, but it was closed as a dupe of https://github.com/Expensify/App/issues/26946
Do you know anything about @cubuspl42?


Prune redundant, invalid CSS

The rule I removed
&.l0.r0
  border-left: none;

is not valid CSS, but that rule is actually validly specified in the next block of CSS.

@TimShawver does this look reasonable?

Yep looks good.  Thanks @ajgreenb.

:+1: Thanks guys!


Remove version: Stevenaaus.ScidvsPC version 4.24

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/scidvspc/files/windows/Scid vs PC-4.24.exe/download
Status Code: 200
(Automated message - build 897)

Close with reason: Package still available.;


Creating data object hladb_protein_3.35.0

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   97.58%   97.58%
=======================================
  Files           9        9
  Lines         372      372
=======================================
  Hits          363      363
  Misses          9        9

Impacted Files
Coverage Δ

R/prepareHLAdb.R
97.77% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249a08b...42b88c9. Read the comment docs.


Add 1.25x objective to json for dropdown

Need FOV and details for the 1.25x Evident objective we offer.

Added.


Language popup appearing for Dialog section

On checking out the dialog tag page, the language is detected as Dutch and this hinders the user experience as the user gets distracted every time or is felt compulsive about choosing an option to move further.

@atapas I've added my observation which I experienced while exploring the hosted project. Please check if you feel it to be an issue. I would like to work and add a fix for the same. Please assign the issue to me so I can proceed with the same.
Thanks


grype: 0.73.5 -> 0.74.0

Diff: https://github.com/anchore/grype/compare/refs/tags/v0.73.5...v0.74.0
Changelog: https://github.com/anchore/grype/releases/tag/v0.74.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 279203 run on x86_64-linux 1

1 package built:

grype


CONDITION EVALUATION DELTA in server log output

I have a standard Config Server built using Boot 2.0.1 (spring-boot-starter-test and spring-boot-devtools) and Finchley.RELEASE (spring-cloud-config-server).  No unusual properties set.
When adding the spring-cloud-starter-bus-amp dependency, the log output is pummeled with an unrequested "CONDITION EVALUATION DELTA" that goes for miles.  A brief snippet:
2018-06-21 22:44:11.929  INFO 36788 --- [  restartedMain] demo.Application                         : Started Application in 6.459 seconds (JVM running for 6.922)
2018-06-21 22:44:11.955  INFO 36788 --- [  restartedMain] .ConditionEvaluationDeltaLoggingListener : Condition evaluation delta:

==========================
CONDITION EVALUATION DELTA
==========================

Positive matches:
-----------------

   AuditAutoConfiguration#auditListener matched:
      - @ConditionalOnMissingBean (types: org.springframework.boot.actuate.audit.listener.AbstractAuditListener; SearchStrategy: all) did not find any beans (OnBeanCondition)

   AuditAutoConfiguration.AuditEventRepositoryConfiguration matched:
      - @ConditionalOnMissingBean (types: org.springframework.boot.actuate.audit.AuditEventRepository; SearchStrategy: all) did not find any beans (OnBeanCondition)
etc.
etc..
etc...

Removing devtools eliminates this output dump - and I don't really need devtools here anyway - but it seems odd to have this behavior.

Devtools enabled that report

Hi @spencergibb is there a property to disable this logging? 'cause it's poluating the console output when starting the application? Thanks


update metadata/README for changes needed due to repo transfer

The repo transfer means we need to update URLS, etc..  This PR also adds some more details to the README that should be helpful.

@benjeffery  -- can you check the changes to cargo.toml and LICENSE?

@molpopgen Looks good to me! Let me know if there are any of the other repo automations you want on this repo.

Let me know if there are any of the other repo automations you want on this repo.

Will do!  Some will require more research.  For example, my way to update the change log and then publish a new version is hackish and manual.  (And undocumented... ;) ).  Unclear how best to "fix" that, etc..


Rewrite compose_state storage of streams to use stream IDs, not stream names

Since we moved to the new dropdown widget stream picker in the compose box, we've fixed the historical quirk of being a text input that streams were stored by name, not by ID, in the compose box.
However, we still have a bunch of blocks of code that interact with the compose box that messily round-trip through the stream name, like this:
const stream_name = compose_state.stream_name();

if (!stream_name) {
    return undefined;
}

return stream_data.get_sub(stream_name).stream_id;

I think it'd be a lot cleaner to have a native compose_state.stream_id interface that these can call, and flip around the storage structure, so that it's compose_state.stream_name that does a lookup in our streams database to figure out what the stream is called.
Tagged as a priority because this is the kind of refactor that's going to remove a decent amount of both potential corner case bugs and error-handling code for cases that are actually impossible (of our not knowing what stream ID is selected in the compose box).
@evykassirer @shameondev likely have more ideas than I do on how this should fit together, and it probably makes sense for one of them to pick this up.

It's ready and waiting for review


All creation features dissapers when enable Hide folders in Connection View

Description
I'm really not sure if is it a bug or a feature. But it looks strange.
When I enable Hide folders in the Connection View settings https://www.screencast.com/t/YLsclixy3, I'm no longer able to create tables or even columns in the table.
Please check these screenshots:
This menu looks as usual, but it should contain create table option if folders are hidden https://www.screencast.com/t/VoR29PqvbAem
This toolbar doesn't contain create column option if folders are hidden https://www.screencast.com/t/R1gFeJmoV
DBeaver Version
Community Editio <IP_ADDRESS>303131743
Operating System
macOS Ventura 13.2.1 (22D68)
Database and driver
MySQL 8
Driver for MySQL 8 and later
Steps to reproduce

Right-click on the connection and select Connection View / Custom https://www.screencast.com/t/ZwmI0mgWmly
Tick the checkbox Hide folders https://www.screencast.com/t/YLsclixy3

Additional context
No response

It looks like a bug. I believe it wasn't intended.
Thank you for report.

This is the side-case of the Simple View. We must consider how the Simple View and the "hide folders" settings can work together.


Fix dead link in the docs

This docs link was broken, because it was pointing to element with id Draggable-Events on the current page instead of pointing user to the Draggable-Events page.
You can convince yourself this fix works by going to https://package.elm-lang.org/packages/zaboco/elm-draggable/latest/Draggable, ctrl + f for "See Events" and click that link (will take you nowhere). If instead you edit the link address in browser developer tool like this PR (i.e. remove #) it will take you to the correct page.

Cool, thanks for fixing that!

Published as 4.0.5 👍


Allow to know what data were used

in hci_prepare, some assertions are made, to ensure we get the needed
data. Until now, it was failing, but we didn't know what data were
consumed.
This PR leverage the block/rescue pattern to output the checked data.
It also correct how those data were checked and consumed: the network
names are usually converged to a simple string without any dashes, at
least in a job reproducer case.
This patch allows to cover both names, the one from the CI job
definition (with dashes) and the one rebuilt over name conversions.
Testing (not in commit message)
This PR was tested with ds tp 599. While it failed, it did successfully pass the hci_prepare step, meaning the issue is solved with this PR.

As @cjeanner mentioned, bootstrap networking is now correctly present in testing deployment allowing the hci_prepare to reference storage-mgmt, the additional error is unrelated to current PR.

/approve

/lgtm

/approve


Low Priority: Documentation of Download & Uncompress

The section here:   https://github.com/sap-linuxlab/ansible.playbooks_for_sap/blob/main/docs/GET_STARTED_WINDOWS.md#download
Has the following example:
mkdir -p run_playbooks && cd run_playbooks && curl -L https://github.com/sap-linuxlab/ansible.playbooks_for_sap/archive/refs/tags/1.0.0.zip | tar -xzv
But using 1.0.0.zip is not decompressed with tar.
Should be:
mkdir -p run_playbooks && cd run_playbooks && curl -L https://github.com/sap-linuxlab/ansible.playbooks_for_sap/archive/refs/tags/1.0.0.tar.gz | tar -xzv
Same for the MacOS section also.

Just a developer's shorthand that covers .tar.gz or .zip for the following long form operators. I didn't think much of this command to be honest, it was after a long day of documentation that I added it.
Does it need to be replaced? I'm not confident of the unzip utility across different OS and whether that will work from a curl pipe.  I would have to test.
curl -L https://github.com/sap-linuxlab/ansible.playbooks_for_sap/archive/refs/tags/1.0.0.tar.gz \
| tar --extract --ungzip --verbose

-x, --extract, --get
    Extract  files  from an archive.

-z, --gzip, --gunzip, --ungzip
    Filter the archive through [gzip](1).

-v, --verbose
    Verbosely  list  files processed.

Source: https://manpages.ubuntu.com/manpages/jammy/en/man1/tar.1.html


CommandGroup should have Sertain lifecycle methods

Currently it only has the default WPILib ones.

We shouldn't be extending CommandGroup


Feat: Make website SEO friendly

Describe the feature
I would like to make the website SEO friendly by adding the appropriate meta tags and keywords.
Add ScreenShots
N/A
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@chaanakyaaM Where you will add them?

In this way
import React from 'react';
import { Helmet } from 'react-helmet';

const HomePage = () => {
  return (

      <Helmet>
        <title>Home Page - My React App</title>
        <meta name="description" content="Welcome to my React.js application!" />
        <meta name="keywords" content="React, SEO" />
      </Helmet>

Welcome to My React App

This is the homepage of my React.js application.

  );
};

export default HomePage;

@chaanakyaaM Issue assigned to you

@SUGAM-ARORA  Kindly review the PR.


Problem with spotify Alias in terminal: osascript error

osascript: /Users/computer_user/code/SpotifyControl/SpotifyControl.scpt: No such file or directory
The above error shows in the terminal once I try to run the 'spotify' command.
I went to the directory in question, it wasn't created and the file didn't exist.  I suppose this may be a problem with a script that isn't executing correctly during installation?

I don't think this is related to spotify-cli-mac. Are you using a zsh config from some template?
A google search leads me here:
https://gist.github.com/NickWoodhams/94919631f126072b9391#file-zshrc-L24


Transformers - Failure scenarios

https://huggingface.co/gpt2/tree/main
Here is how to use this model to get the features of a given text in PyTorch:
from transformers import GPT2Tokenizer, GPT2Model
tokenizer = GPT2Tokenizer.from_pretrained('gpt2')
model = GPT2Model.from_pretrained('gpt2')
text = "Replace me by any text you'd like."
encoded_input = tokenizer(text, return_tensors='pt')
output = model(**encoded_input)
and in TensorFlow:(updated with config)
from transformers import GPT2Tokenizer, TFGPT2Model,PretrainedConfig
tokenizertf = GPT2Tokenizer.from_pretrained('gpt2')
model_tf = TFGPT2Model.from_pretrained('gpt2')
configtf=PretrainedConfig.from_pretrained('gpt2')
text = "Replace me by any text you'd like."
encoded_input = tokenizertf(text, return_tensors='tf')
outputtf = model_tf(encoded_input)

    return kwargs["model"].optimizer.get_config() - Seems the optimizer is None

Both the model upload is failing to the modelstore

Thanks @sayandigital - I've found one bug so far related to how modelstore decides to save models. Am working on it in the PR linked above, which includes the TF example you at the top of your issue.

I've just merged the fix, this will go out in the next release of modelstore and I'll keep the issue open until then. Thanks again!

Released!


NFD open file browser crash

This seems to fix it: https://github.com/practicing01/Torque3D/commit/78694a03bff8824454d8aec58f6996ab364f308f

still an issue your end?


As a user i want to be able to sync requests with my team mates

Decided to do this in steps

user PeerJS so we can use WebRTC to connect user to eachother => done in https://github.com/mcorten/web-man/pull/29

create a custom web-man peer js turn/stun server so we can use that as a default

[ ] host custom peerjs turn/stun server

store server information so we can use a nickname and an static conenction id (so the client is always the same ID => this is needed to identify users)

[ ] create table to store information
[ ] create form to enter turn/stun server information (use web-man turn/stun created in step 2 as default)
[ ] add user information to the form so the user can choose a nickname and connection id (can be auto generated)
[ ] allow user to save form
[ ] auto connect to the server chosen (if any) on application load

allow users to connect to each other by entering the connect ID of the one you are connecting with

[ ] make form to connect to other user by connection ID
[ ]


USSD Support

Hello @herlesupreeth
Could you advise if I can test USSD using docker_open5gs ? and how ?
Thanks

Sadly, its not possible.

Why ? what is the limitation ?

USSD is not part of 4g/5g. It requires 2g/3g network services.
Envoyé à partir de Outlook pour Androidhttps://aka.ms/AAb9ysg

From: Abdelmuhaimen Seaudi @.>
Sent: Monday, February 26, 2024 8:41:36 PM
To: herlesupreeth/docker_open5gs @.>
Cc: Subscribed @.***>
Subject: Re: [herlesupreeth/docker_open5gs] USSD Support (Issue #285)
Why ? what is the limitation ?
—
Reply to this email directly, view it on GitHubhttps://github.com/herlesupreeth/docker_open5gs/issues/285#issuecomment-1965117309, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVTPOOJWDA2AKAJBPZKHHGLYVTQPBAVCNFSM6AAAAABDYHJYPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGEYTOMZQHE.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

What about 3GPP TS 24.390 "Universal Mobile Telecommunications System (UMTS); LTE; Unstructured Supplementary Service Data (USSD)  using IP Multimedia (IM) Core Network (CN) subsystem IMS;" ?

What about 3GPP TS 24.390 "Universal Mobile Telecommunications System (UMTS); LTE; Unstructured Supplementary Service Data (USSD) using IP Multimedia (IM) Core Network (CN) subsystem IMS;" ?

That requires a XCAP server and the one in kamailio does not support features needed for IMS


ARTEMIS-4723 Avoid objects left on ThreadLocal from OrderedExecutorFactory

co-authored: Clebert Suconic

@cardamon notice I'm keeping you as the author on the commit. as you discovered the issue.
I went further and just removed the usage. if all my tests are good I will merge this.

@cardamon notice I'm keeping you as the author on the commit. as you discovered the issue.
I went further and just removed the usage. if all my tests are good I will merge this.

Thanks!

even thought I wanted to get rid of the shutdown.. that represented some semantic change.. and it's impossible to measure consequences. I will have to keep the behaviour to avoid breaking use cases and causing unexpected issues.


Vulnerability roundup 85: wolfssl-4.3.0: 1 advisory [7.5]

search, files

[ ] CVE-2020-11713 CVSSv3=7.5 (nixos-20.03)

Scanned versions: nixos-20.03: a84b797b28e. May contain false positives.
Cc @mcmtroffaes

PR is here https://github.com/NixOS/nixpkgs/pull/86999 and waiting for a curl bump.

It's been staged.


Skip button on first opening does not work

When starting the application the very first time, it will ask you name, surname and email with a submit and a skip button. Unfortunately the skip button does not work.

Hello, I've removed this functionality entirely, This has been removed here https://github.com/pacholoamit/pachtop/commit/d46cb252353410a1cef043522cd020600a51200d


[@svgr/babel-plugin-add-jsx-attribute] Allow to limit to first match / root element

🚀 Feature Proposal
Allow to limit the target element for attributes to the first match / the root element.
Motivation
Currently the specified attributes are added to all found elements regardless how deep nested within the tree. This is really useful when adding custom props that should apply to all of these elements like e.g. a fill color. Unfortunately this prevents to make use of fragments / fractals for animations. These are SVG children elements not wrapped in a <svg> which can be used to compose a SVG out of multiple smaller elements (multiple .svgfiles) where each of them can be animated separately.
The reason is that e.g. the className prop must be passed to the wrapping/root element of the fragment/fractal. Most of the time this is a <g>, but whenever there are other nested <g> elements they will also receive the prop and act like a own root element, e.g. running the same animation that was only meant to be interpreted by the real root element.
Another use case is the fact that awesome animations libraries like react-pose are reliant on a forwarded ref which would currently also be passed to all nested e.g. <g> elements, but a ref is a reference to one element and can not be added to multiple.
This feature request suggests to add a new boolean configuration like e.g. onlyMatchFirst or onlyWhenRootElement to pass the attributes only when the matching element is the root element and skip deeper nested matches.
Implementing this feature won't cause any breaking changes since <svg> tags would still receive all extended props. Also of course the new configuration should be disabled by default.
Example
Currently when transforming a SVG file which root element is not a <svg> no props are passed at all. Using this SVGR Babel plugin allows to add these using a configuration (enabled ref option for sure) and SVG file like this:
          // ...
          {
            "elements": ["g"],
            "attributes": [
              {
                "name": "ref",
                "value": "svgRef",
                "spread": false,
                "literal": true,
                "position": "end"
              },
              {
                "name": "props",
                "spread": true,
                "literal": false,
                "position": "end"
              }
            ]
          }
          // ...

<g>
  <path d="M10 10"/>
</g>

This will result in a transformed component like this:
import React from "react";

const SvgSVGFile= ({ svgRef, ...props }) => (
  <g ref={svgRef} {...props}>
    <path d="M6.0 4 2" />
  </g>
);

const ForwardRef = React.forwardRef((props, ref) => (
  <SvgSVGFile svgRef={ref} {...props} />
));
export default ForwardRef;

Unfortunately as soon as there are other <g> elements the props are passed too resulting in invalid ref props for different elements causing animation libraries to stop working:
<g>
  <path d="M10 10" />
  <g>
    <path d="M5 5" />
  </g>
</g>

import React from "react";

const SvgSVGFile= ({ svgRef, ...props }) => (
 <g ref={svgRef} {...props}>
   <path d="M10 10" />
   <g ref={svgRef} {...props}>
     <path d="M5 5" />
   </g>
 </g>
);

const ForwardRef = React.forwardRef((props, ref) => (
 <SvgSVGFile svgRef={ref} {...props} />
));
export default ForwardRef;

When implementing this new feature it would allow to use such SVG files like above without problems for animations or other use cases where props must be passed only to the wrapping element or to compose multiple SVG fractals/fragments at all. Enabling the new config would generate components like this:
import React from "react";

const SvgSVGFile= ({ svgRef, ...props }) => (
 <g ref={svgRef} {...props}>
   <path d="M10 10" />
   <g>
     <path d="M5 5" />
   </g>
 </g>
);

const ForwardRef = React.forwardRef((props, ref) => (
 <SvgSVGFile svgRef={ref} {...props} />
));
export default ForwardRef;

These can now be used to compose animated SVGs:
import React from "react";
import styled from "styled-components";
import { posed } from "react-pose";
import { ForwardRef as PosedLineOne } from "./svg/fragments/line-one.svg"
import { ForwardRef as PosedLineTwo } from "./svg/fragments/line-two.svg"

const poseA = {
  up: {
    x: "-5%",
    opacity: 0.7
  },
  down: {
    x: "5%",
    opacity: 0.95
  }
};

const poseB = {
  up: {
    x: "7%",
    delay: 150
  },
  down: {
    x: "-19%",
    transition: {
      duration: 200
  }
};

const PosedLineOne = styled(posed(PosedLineOne)(poseA))`
  fill: #6100FF;
  margin-top: 2em;
`;

const PosedLineOne = styled(posed(PosedLineTwo)(poseB))`
  stroke: #004FFF;
  padding: 1em;
`;

const SVGComposition = (pose, ...passProps) => (
  <svg viewBox="0 0 200 200" {...passProps}>
    <PosedLineOne pose={pose} />
    <PosedLineTwo pose={pose} />
  </svg
);

export default SVGComposition;

Alternative Solutions
Root Element Prop Pass Handling
Another solution would be to change the logic how prop extending on root elements that not <svg> elements are handled. Currently when the root element is not a <svg> (e.g. a <g>) no props are passed at all.
With v3 is was possible to add these by using a custom template, but as far as I've tested it with the cool new Babel AST API there is no way to hook into the process where props are passed to the root element or respectively to determine the root element to add the props using the appropriate API function.
When props would be passed regardless of the root element type, either <svg> or <g> there's no need to add a new configuration for this plugin.
Specialized SVGR Babel AST plugin
Another possible solution is to create a new SVGR Babel AST plugin that is similar this one, but doesn't require to specify the elements the configured attributes should be passed to. It would pass the props automatically to the root element regardless of the type. It could be named like @svgr/babel-plugin-svg-fragment-jsx-props or something like this (sometimes naming is hard 😄 ).
I've started to implement something like this for my personal use cases, but supporting it officially would be a cleaner solution and can help others facing the same problem.
Implementation notes
If this feature is going to be implemented some details have to be considered. There is currently a strange behaviour when parsing SVG children elements that are not wrapped in a <svg> that the first child element of the root gets transformed to a openingElement although the "original" element is selfClosing.
Example:
<g>
  <path fill="#ECEFF4" d="M140.948 279.726v-.306a6.333 6.333 0 0 1 6.333-6.333h94.625a6.333 6.333 0 0 0 0-12.665h-1.249a6.332 6.332 0 0 1-6.332-6.332v-.306a6.333 6.333 0 0 1 6.332-6.333h72.089a6.333 6.333 0 0 1 6.333 6.333v.306a6.332 6.332 0 0 1-6.333 6.332h-24.622a6.332 6.332 0 1 0 0 12.665h1.345a6.332 6.332 0 0 1 6.332 6.333v.306a6.332 6.332 0 0 1-6.332 6.332h-26.386a6.332 6.332 0 1 0 0 12.665h61.068a6.332 6.332 0 0 1 6.332 6.333v.306a6.332 6.332 0 0 1-6.332 6.332H173.775a6.333 6.333 0 0 1-6.333-6.332v-.306a6.333 6.333 0 0 1 6.333-6.333h4.016a6.332 6.332 0 1 0 0-12.665H147.28a6.332 6.332 0 0 1-6.332-6.332z"/>
  <path d="M271.616 298.723h-10.674a6.332 6.332 0 0 1 0-12.665h10.674a6.332 6.332 0 1 0 0 12.665zm26.385-12.665h-10.674a6.332 6.332 0 0 0 6.333-6.332v-.306a6.333 6.333 0 0 0-6.333-6.333h-1.343a6.332 6.332 0 1 1 0-12.665h10.673a6.333 6.333 0 0 0 0 12.665h1.344a6.332 6.332 0 0 1 6.332 6.333v.306a6.332 6.332 0 0 1-6.332 6.332zm23.277-25.636h-10.673a6.333 6.333 0 0 0 6.333-6.332v-.306a6.334 6.334 0 0 0-6.333-6.333h10.673a6.333 6.333 0 0 1 6.333 6.333v.306a6.332 6.332 0 0 1-6.333 6.332zm7.065 44.939v-.306a6.332 6.332 0 0 0-6.332-6.333h10.674a6.332 6.332 0 0 1 6.331 6.333v.306a6.332 6.332 0 0 1-6.331 6.332h-10.674a6.332 6.332 0 0 0 6.332-6.332z" fill="#D8DEE9"/>
</g>

Parsing the given SVG fragment will result in the following React component (with enabled ref and noSvg option):
import React from 'react'

const SvgComponent = ({ svgRef, ...props }) => (
  <g>
    <path
      fill="#ECEFF4"
      d="M140.948 279.726v-.306a6.333 6.333 0 0 1 6.333-6.333h94.625a6.333 6.333 0 0 0 0-12.665h-1.249a6.332 6.332 0 0 1-6.332-6.332v-.306a6.333 6.333 0 0 1 6.332-6.333h72.089a6.333 6.333 0 0 1 6.333 6.333v.306a6.332 6.332 0 0 1-6.333 6.332h-24.622a6.332 6.332 0 1 0 0 12.665h1.345a6.332 6.332 0 0 1 6.332 6.333v.306a6.332 6.332 0 0 1-6.332 6.332h-26.386a6.332 6.332 0 1 0 0 12.665h61.068a6.332 6.332 0 0 1 6.332 6.333v.306a6.332 6.332 0 0 1-6.332 6.332H173.775a6.333 6.333 0 0 1-6.333-6.332v-.306a6.333 6.333 0 0 1 6.333-6.333h4.016a6.332 6.332 0 1 0 0-12.665H147.28a6.332 6.332 0 0 1-6.332-6.332z"
    >
      <path
        d="M271.616 298.723h-10.674a6.332 6.332 0 0 1 0-12.665h10.674a6.332 6.332 0 1 0 0 12.665zm26.385-12.665h-10.674a6.332 6.332 0 0 0 6.333-6.332v-.306a6.333 6.333 0 0 0-6.333-6.333h-1.343a6.332 6.332 0 1 1 0-12.665h10.673a6.333 6.333 0 0 0 0 12.665h1.344a6.332 6.332 0 0 1 6.332 6.333v.306a6.332 6.332 0 0 1-6.332 6.332zm23.277-25.636h-10.673a6.333 6.333 0 0 0 6.333-6.332v-.306a6.334 6.334 0 0 0-6.333-6.333h10.673a6.333 6.333 0 0 1 6.333 6.333v.306a6.332 6.332 0 0 1-6.333 6.332zm7.065 44.939v-.306a6.332 6.332 0 0 0-6.332-6.333h10.674a6.332 6.332 0 0 1 6.331 6.333v.306a6.332 6.332 0 0 1-6.331 6.332h-10.674a6.332 6.332 0 0 0 6.332-6.332z"
        fill="#D8DEE9"
      />
    </path>
  </g>
)

const ForwardRef = React.forwardRef((props, ref) => (
  <SvgComponent svgRef={ref} {...props} />
))
export default ForwardRef

As you can see the first <path> element suddenly becomes an non selfClosing element and contains the second <path> as a child element which is also not conform to the spec since a path must always be self-closing.
Strangely, when the <g> root element is changed to a <svg> everything works fine where both <path> elements are self-closing.
These transformation problem must be resolved before or within the implementation of this feature, otherwise it will generate invalid SVG content.

I close it, it didn't get enough interest to be implemented.


DKPY2.0: AttributeError: FakeAPI instance has no attribute ....

I modified vehicle_state.py to new API. I'm getting errors that Location, attribute (at least are not being found)
Connecting to vehicle on: <IP_ADDRESS>:14550
Completed list of 454 params
Starting dronekit.

Get all vehicle attribute values:
Traceback (most recent call last):
  File "D:\deleteme\dronekit-python\examples\vehicle_state\vehicle_state.py", line 32, in <module>
    print " Attitude: %s" % vehicle.attitude
AttributeError: FakeAPI instance has no attribute 'attitude'

This was a bug in my build. Reinstalled WinPython and tried again and everything works.


Tooltip for ASes does not work in BGP updates and hijacks

Describe the bug
Tooltip for ASes does not work in BGP updates and hijacks
Affected Component(s)

[ ] Back-End (Database, Microservices, Containers, etc)
[X] Front-End (Flask, API, etc)
[ ] Docs
[ ] Build System

To Reproduce
Steps to reproduce the behavior:

Go to BGP updates or hijacks tables (or updates in hijacks)
Hover over fields that involve ASNs.
3.Nothing is shown (not normal behavior)

Expected behavior
Showing tooltip information.
Screenshots
N/A
System (please complete the following information):

OS: Linux
Browse: Firefox

Additional context
N/A

Reported by @pgigis
$jscomp.makeIterator is not a function

(error on minified version of prod-ripestat.js)


Remove unreachable code from calculate-statutory-sick-pay

The days_that_can_be_paid_for_this_period method was introduced into
SmartAnswer::Calculators::StatutorySickPayCalculator in this commit.
At this point it was being used in the entitled_or_not_enough_days outcome
to determine what outcome_text was to be displayed.
In a (considerably) later commit, a new next_node_if block was added to
the usual_work_days? question which directed the user to the
maximum_entitlement_reached outcome depending on whether the value returned
by the days_that_can_be_paid_for_this_period method was zero.
However, this effectively duplicated an existing next_node_if block which
already did (effectively) the same calculation and directed the user to the
same maximum_entitlement_reached outcome. Thus the condition for the new
next_node_if block was could never be satisfied.
Unfortunately there are no clues in the tests or git history which explain what
the intention was. I've elected to replace the older next_node_if block with
the more recent one, because this looks as if what was intended. Note that the
calculation in the newer version of the code (in the calculator object) does a
rounding which the older version doesn't.
The integration test which covers the maximum_entitlement_reached outcome
continues to work after this change, so I'm reasonably confident nothing has
gone awry. However, I've emailed @lutgendorff to check that this approach is
OK.

I've just added another small commit to this PR which removes the unused & untested method, SmartAnswer::Calculators::StatutorySickPayCalculator#find_6th_april_after.

I've changed the title to include [DO NOT MERGE] until Liz is happy with the changes.

I can't immediately see how prior_sick_days and prior_sick_days.to_i >= (days_worked * 28 + 3) is essentially the same as calculator.days_that_can_be_paid_for_this_period == 0.
Rather than really try to understand it I'm happy that Liz can make the decision based on the changes to the artefacts.

@chrisroos: You need to look at these methods in the calculator, but even then it's not totally obvious.

I'm planning to do something with this once #2031 is merged.

The calculate SSP flow & its calculator have changed considerably since this pull request was submitted.

The first commit has already been applied as part of #2068 in this commit.

As explained in the second commit, I'm pretty sure there's some duplication in the :usual_work_days? decision as to whether to go to the :maximum_entitlement_reached outcome. However, this is now a bit more prominently highlighted in the code.

I don't have time right now to investigate this further right now, but I don't think there's much value in keeping this (very old) PR around any more. Closing.


A fix to call non-blocking closeAsync in finalize

A fix to call non-blocking closeAsync in finalize instead of the blocking close method.
And minor tweaks.

Since Vijay Gopal do not have permission, I am merging it.


Add block "end_of_body" for JS includes

It is a common pattern to add JS at the end of the body. See bootstrap starter template
The end_of_body enables you to add HTML before the closing </body> tag.

@guettli Something like this looks useful 👍
It looks like a release note would be needed here. (See this very similar PR for example).
Also - whilst a ticket on trac isn't necessarily required for a small PR like this, I'm sure creating one would speed up getting it merged :)

That's quite common, yes. But, the JavaScript code of the admin is included in the <head>; is there a reason why you'd prefer this to adding scripts to {% block extrahead %}?

That's quite common, yes. But, the JavaScript code of the admin is included in the <head>; is there a reason why you'd prefer this to adding scripts to {% block extrahead %}?

I am following the "best practice" which I was told. My goal is to make the page load fast. I confess that I don't know if this "best practice" is still needed for modern browsers.

@matthiask I created a ticket for this: https://code.djangoproject.com/ticket/32564

Closing per ticket.


sendError sets isAd = true, isAd = this.isAd() sounds more accurate

Current
att.isAd = true

https://github.com/newrelic/video-core-js/blob/173c69ae18502f23cc00426a8f218f8f43596b4f/src/videotracker.js#L712
Suggestion
att.isAd = this.isAd()

Good catch. Thanks for reporting.

Thanks for fixing :)


Support variables with \s in their names?

Problem Statement
Currently there's an unspoken support for token objects that follow traditional JS variable naming. However, for our design system we've opted for a human-readable taxonomy which means our tokens are non-traditional. Eg Background Subtle or Background Subtle - Elevated .
Proposed Solution
I poked around and it seems like the regex being used is the limiting factor here. I'm wondering if you've considered making the regex more generic and to really only care about the initial $ in the variable name? I've poked around with changing it to include spaces for example and everything appears to work fine.
This is what i've changed the variable regex to (-)?\B\$([\w\s\-.]+), which so far so good 🤷🏼 . There are probably things I haven't considered but it allows me to do this :)
      <Box
        as="div"
        backgroundColor="$Background Subtle"
        padding={{xsmall: '$Macro Small', large: '21px'}}
      />

Alternatives Considered
Another thing I could do is remap our tokens to something RS expects and hide that from consumers. It's a bit ham-handed but would probably work.
Additional Context
Existing components already use these strings so it'd be a massive change to completely overhaul how we use tokens.

Hey there, I'm sorry I never followed up on this. I wasn't sure how I wanted to respond to it. I understand the need to support prior use of tokens, but I don't think having spaces in variable names is a good idea, and it seems like too small of an edge case to be worth supporting in this library.
You've probably found a workaround or alternative at this point, but if anyone reads this in the future: I'd recommend either forking the library or using something like patch-package to add this. The surface area in a git patch should be small enough to support, and I think the types should continue to work? Dunno for sure.
Good luck!


refactor(aria): ♻  remove aria dependencies with button & interactions

We can merge this after #90 #91


refactor(@angular/build): use structured component stylesheet tracking for hot replacement

When using the development server with the application builder, the internal state of any external component stylesheets is now more comprehensively tracked. This allows for more flexibility in both debugging potential problems as well as supporting additional stylesheet preprocessing steps including deferred component stylesheet processing.

The changes were merged into the following branches: main, 19.0.x


missing leading { when rendering JSON string

It seems the rendering logic has a bug when dealing with the following input:
       val prompt = """
            {
              "model": "{{{model}}}",
            }""".trimIndent()
        val p = prompt.render(
            mapOf( "model" to "staticValue1")
        )
        println(p)

The result prints:
  "model": "staticValue1",
}

The leading { is missing in the rendered result.

Hello @Zane-XY
Thanks for sharing, I've found the cause. I will patch it ASAP.

hi @L-Briand ,
i tried, it works for some cases, but not this one:
    @Test
    fun testMapContext() {
        val prompt = """
{
  "source":"{{{model}}}"
}
    """.trimIndent()
        val p = prompt.render(
            mapOf( "model" to "staticValue1")
        )
        println(p)
    }
}

@Zane-XY Thank you for the comeback. I'll look into it.

The issue should be fixed in the 1.0.3 version