Crookedneighbor separate tests

Description

Builds off of @crookedneighbor's excellent work here: https://github.com/lexicalunit/spellbot/pull/134
I decided to overload pytest_collection_modifyitems to get the order I wanted for the tests without having to add a new dependency.
Removed calls to pytest.mark.usefixtures.
Pushed S_SPY and SNAPSHOTS_USED into test_meta.py as those are the tests that are meant to check the state of those variables. Also they're not constants so I didn't feel like they should be in constants.py.
Pulled constants.py up a level.
Added __init__.py files to make the test suite a module.
Pushed simulate_user_leaving_server() into MockDiscordClient.mock_disconnect_user() as I think it makes sense hanging off the client object there.
Renamed tests/fixtures to avoid confusion. These aren't pytest fixtures, they're actually just static test data files.

Checklist

[ ] Add tests for these changes
[ ] Test coverage is not decreased
[ ] Entire test suite passes

Codecov Report

Merging #137 into master will increase coverage by 2.95%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #137      +/-   ##
===========================================
+ Coverage   97.04%   100.00%   +2.95%
===========================================
  Files          20        19       -1
  Lines        1318       464     -854
  Branches      217        22     -195
===========================================
- Hits         1279       464     -815
+ Misses         24         0      -24
+ Partials       15         0      -15

Impacted Files
Coverage Δ

src/spellbot/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21cccd...9eedbc2. Read the comment docs.


Fix schema cleanValues method to always remove associations.

Should resolve the ever-pesky #429 and https://github.com/balderdashy/sails-mongo/issues/254 .  This ensures that association attributes that represent collections are always cleaned by the schema before sending values to the adapter during create and update.  This should allow schema: false to behave correctly.  I added unit tests here– if anyone would like to add integration tests to waterline-adapter-tests, that would be sweet!
CC: @dmarcelino @tjwebb @anasyb

Argh!!! I was looking at another PR and merged this one by accident :astonished: I'm so embarrassed... @tjwebb @anasyb please review this as well!
To be honest I think this is fine, I was just about to comment the following:
I've pulled this branch into my machine and ran the integration tests against some adapters:

sails-memory passes all tests
sails-disk passes all tests
sails-orientdb (schemafull and schemaless) passes all tests
sails-postgresql passes all tests (not surprising)

I'm good with this :white_check_mark:

Ah, @anasyb that magic array is added elsewhere– when values come out of the adapter and are turned into a model instance (the object with save, destroy, add, and remove methods).  This cleans the values so that they may be passed directly into an adapter for a particular collection.  In the schema: true case, these collection-attribute values have always been stripped by cleanValues since they're not technically part of the schemata for any collection.

@particlebanana @tjwebb  this fixes issues around using schema: true.  It was merged accidentally, so it still needs review.  Will close #429 and https://github.com/balderdashy/sails-mongo/issues/254 .  Mind taking a peek?

@devinivy looks perfect. @irlnathan had the same issue today in #966 so I'm sure others have experienced it. Looks like a nice patch.

Great– thx for taking a peek.

thanks everyone... this was an awesome patch... so excited and looking forwards to get my main project back to flexible schema


ModuleNotFoundError

OS version:
Windows 10

atom --1.54.0

6.1.12
76.0.3809.146
v12.4.0

Hydrogen version:
2.14.7
Plugins
Have you installed and activated any of the Hydrogen plugins below ?

[yes] hydrogen-python
[yes] Hydrogen Launcher
[yes] Data Explorer

Expected behavior
Module Not Found Error : pandas, numpy, etc
Already did everything I can find online including

installing modules manually
pip install pandas
added modules to path

I have ipython and ipykernal installed
I have python version 3.8 and 3.9.1
Screenshots

Hey @bakananna, I don't think this is an issue with hydrogen.
I think the issue might be with your environment. Since you have two python versions installed.
you might have to add the module to the environment you are using by default.
Something like this...
python3 -m pip install pandas

Hi, thanks for the reply.
But when I tried to run  python3 -m pip install pandas it says

Python was not found

So I ran python -m pip install pandas instead and it says

Requirement already satisfied:
pandas in c:\users\neohu\appdata\roaming\python\python39\site-packages (1.2.1)
pytz>=2017.3 in c:\users\neohu\appdata\roaming\python\python39\site-packages (from pandas) (2021.1)
python-dateutil>=2.7.3 in c:\users\neohu\appdata\local\programs\python\python39\lib\site-packages (from pandas) (2.8.1)
numpy>=1.16.5 in c:\users\neohu\appdata\roaming\python\python39\site-packages (from pandas) (1.20.0)
six>=1.5 in c:\users\neohu\appdata\local\programs\python\python39\lib\site-packages (from python-dateutil>=2.7.3->pandas) (1.15.0)

Does this mean I have to change to python3 somehow or is there a way to tell atom which version I'm using?

Okay, python is pointing to python39.
Have you installed Python kernels https://nteract.io/kernels/python?
python -m pip install ipykernel
python -m ipykernel install

Yup, I did.

I think I found the problem.. somehow the kernel is still pointing to python38. How can I change the specs?

Okay, not sure if this will work, but try this.
Install kernel again with python3.8.
python3.8 -m pip install ipykernel
python3.8 -m ipykernel install

And then install your modules in that python.
python3.8 -m pip install pandas

Great! That works. Thank you so much


Why pass the 'info' dictionary to from_array?

Why pass the 'info' dictionary to from_array, when it is not used directly? The only thing it does is to check, if the information is the same in array + mode compared to the dict. It would greatly simplify maintains and use of the code, if the user had to do the necessary checks.

probably compatibility with older code that used info in calls to Writer().
I agree it seems like a lot of complexity.


Don't add default templates back after they are deleted

A customer is asking for the following:

I delete default templates (hello)
I sync with Gorgias.io
I install the extension on another laptop, and login
--> The "hello" template is back. The user doesn't want this.

It could be done by checking if the user is logged in on gorgias.io and not add them at all. The problem with this is that it's unlikely that they are logged in on a new computer. We can also delete them once the user is logged in, but are we sure that the user doesn't want them?
It's not super clear what to do here and I don't think it's super important for now.

Yep agreed, just added that for tracking purposes. I think the best way to
go is probably to delete the templates after the user logs in for the first
time.
On Tue, Dec 8, 2015 at 1:39 PM Alex Plugaru<EMAIL_ADDRESS>wrote:

It could be done by checking if the user is logged in on gorgias.io and
not add them at all. The problem with this is that it's unlikely that they
are logged in on a new computer. We can also delete them once the user is
logged in, but are we sure that the user doesn't want them?
It's not super clear what to do here and I don't think it's super
important for now.
—
Reply to this email directly or view it on GitHub
https://github.com/gorgias/gorgias-chrome/issues/155#issuecomment-162974880
.

Closing this for now as it's not a common issue.


About SQL Server Physical Operation Statistics Count  ActualRebind and ActualRewind

Hello guys, seems it is a little confused with my scenario about "Unless an operator is on the inner side of a loop join, ActualRebinds equals one and ActualRewinds equals zero".
the official document is the following one :
https://docs.microsoft.com/en-us/sql/relational-databases/showplan-logical-and-physical-operators-reference?view=sql-server-2017
In the index seek physical operation, I found the ActualRebinds equals to zero

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0193ed76-3eec-18ac-512f-45f8118dde34
Version Independent ID: 8e693833-3e45-2bb8-ddc2-d0c54936c3c1
Content: A New Feedback System Is Coming to docs.microsoft.com
Content Source: teamblog/a-new-feedback-system-is-coming-to-docs.md
Service: team-blog
GitHub Login: @EisenbergEffect
Microsoft Alias: EisenbergEffect

please ignore this problem, I haven't read the next paragraph. They will not be shown on these operators.


Error! Version1.11.2

Error when loading "android.animation.ObjectAnimator.ofFloat"

It popups "Can't find method."

Which device and which mod is this? Can I please see a screenshot?

2016年1月19日 上午10:22於 "zhuowei"<EMAIL_ADDRESS>
Which device and which mod is this? Can I please see a screenshot?
—
Reply to this email directly or view it on GitHub
https://github.com/zhuowei/MCPELauncher/issues/500#issuecomment-172711199
.


[21302] Fast DDS statistics backend migration to Fast DDS v3.0

This PR allows to compile Fast DDS Statistics Backend with Fast DDS v3.0.0
Main Changes

Overload removed in init_monitor() for discovery servers. Initialising the monitor using a custom GUID is no longer supported.
Types regenerated using FastDDS v4.0.0
Old headers and guards changed
Changed fastrtps namespace to fastdds
Private classes (ReaderProxyData, WriterProxyData and ParticipantProxyData) changed to the new public ones
Discovery StatisticsParticipantListener callbacks updated
Refactored tests

Comments
Communication test does not work correctly: timeout error using low resources
Related PRS

https://github.com/eProsima/Fast-DDS-monitor/pull/227

Dependant PRs

https://github.com/eProsima/Fast-DDS-statistics-backend/pull/245

CI issues reflect existing uncrustify issues with nlohmann-json thirdparty, and a flaky test issue that will be addressed in future PRs.
This PR is ready to merge!


[CT-3249] [Bug] Issue with ValidationError when enabling local package for a dbt project

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
We have two local dbt packages (let's call them local_package_a and local_package_b) that holds data transformation logic for different functionality. One of them (local_package_a) is installed in every customer dbt project, and the other only in two of the customers.
Currently when I added local_package_b (the second local dbt package) to another customer I get a Validation error that block the compilation of customer dbt project. This validation error points to a macro in the main local package local_package_a. See details of the stack trace below.
I am looking for how to debug this without pulling the whole dbt and hologram python packages locally, installing them and use the classic pdb.set_trace().
Expected Behavior
Adding the local module to the packages.yml should not block the installation of the module for any other dbt project.
Steps To Reproduce
Not sure how to reproduce this without pasting the whole code of our local dbt packages, but I can paste the macro in question
{% macro vacuum_model() %}
    {%- if model.config.materialized in [ "table", "incremental" ] -%}
        -- vacuum table
        vacuum {{ this }};
    {%- endif -%}
{% endmacro %}

Relevant log output
23:32:25  Running with dbt=1.5.6
23:32:26  Registered adapter: databricks=1.5.5
23:32:26  Unable to do partial parsing because saved manifest not found. Starting full parse.
23:32:27  Encountered an error:
'{{ local_package_a.vacuum_model() }}' is not of type 'object'

Failed validating 'type' in schema['properties']['post-hook']['items']:
    {'additionalProperties': False,
     'description': 'Hook(sql: str, transaction: bool = True, index: '
                    'Optional[int] = None)',
     'properties': {'index': {'oneOf': [{'type': 'integer'},
                                        {'type': 'null'}]},
                    'sql': {'type': 'string'},
                    'transaction': {'default': True, 'type': 'boolean'}},
     'required': ['sql'],
     'type': 'object'}

On instance['post-hook'][0]:
    '{{ local_package_a.vacuum_model() }}'
23:32:27  jsonschema.exceptions.ValidationError: '{{ local_package_a.vacuum_model() }}' is not of type 'object'

Failed validating 'type' in schema['properties']['post-hook']['items']:
    {'additionalProperties': False,
     'description': 'Hook(sql: str, transaction: bool = True, index: '
                    'Optional[int] = None)',
     'properties': {'index': {'oneOf': [{'type': 'integer'},
                                        {'type': 'null'}]},
                    'sql': {'type': 'string'},
                    'transaction': {'default': True, 'type': 'boolean'}},
     'required': ['sql'],
     'type': 'object'}

On instance['post-hook'][0]:
    '{{ local_package_a.vacuum_model() }}'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/cli/requires.py", line 86, in wrapper
    result, success = func(*args, **kwargs)
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/cli/requires.py", line 71, in wrapper
    return func(*args, **kwargs)
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/cli/requires.py", line 142, in wrapper
    return func(*args, **kwargs)
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/cli/requires.py", line 168, in wrapper
    return func(*args, **kwargs)
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/cli/requires.py", line 215, in wrapper
    return func(*args, **kwargs)
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/cli/requires.py", line 242, in wrapper
    manifest = ManifestLoader.get_full_manifest(
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/parser/manifest.py", line 227, in get_full_manifest
    manifest = loader.load()
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/parser/manifest.py", line 386, in load
    self.parse_project(
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/parser/manifest.py", line 515, in parse_project
    parser.parse_file(block)
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/parser/base.py", line 442, in parse_file
    self.parse_node(file_block)
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/parser/base.py", line 397, in parse_node
    node = self._create_parsetime_node(
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/parser/base.py", line 211, in _create_parsetime_node
    "config": self.config_dict(config),
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/parser/base.py", line 373, in config_dict
    config_dict = config.build_config_dict(base=True)
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/context/context_config.py", line 330, in build_config_dict
    return src.calculate_node_config_dict(
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/context/context_config.py", line 213, in calculate_node_config_dict
    finalized = config.finalize_and_validate()
  File "/path/to/my/venv/lib/python3.9/site-packages/dbt/contracts/graph/model_config.py", line 358, in finalize_and_validate
    self.validate(dct)
  File "/path/to/my/venv/lib/python3.9/site-packages/hologram/__init__.py", line 989, in validate
    raise ValidationError.create_from(error) from error
hologram.ValidationError: '{{ local_package_a.vacuum_model() }}' is not of type 'object'

Failed validating 'type' in schema['properties']['post-hook']['items']:
    {'additionalProperties': False,
     'description': 'Hook(sql: str, transaction: bool = True, index: '
                    'Optional[int] = None)',
     'properties': {'index': {'oneOf': [{'type': 'integer'},
                                        {'type': 'null'}]},
                    'sql': {'type': 'string'},
                    'transaction': {'default': True, 'type': 'boolean'}},
     'required': ['sql'],
     'type': 'object'}

On instance['post-hook'][0]:
    '{{ local_package_a.vacuum_model() }}'

Environment
- OS: Ubuntu 22.04.3 LTS
- Python: Python 3.9.18
- dbt: 1.5.6
- dbt-databricks: 1.5.5

Which database adapter are you using with dbt?
spark
Additional Context
I am aware there is a similar issue marked as closed, but not relevant to my case, though the error is pretty much the same (stack trace) #6776
No response

Hey! I'm curious what indicates to you that this is a bug with dbt core, vs. a bug in your macro?
What happens if your macro is empty?
{% macro vacuum_model() %}

{% endmacro %}

Are you still getting this issue?
Is this macro in local_package_a? Or local_package_b? Sounds like these two packages aren't compatible with each other. Does local_package_b work independently of local_package_a?
Additionally, what dbt command did you run that cause this error? dbt deps, dbt run, dbt compile, something else?

Ok I did some digging to answer your questions. Here are the dets:

the macro belongs to local_package_a
local_package_b works independently from local_package_a
local_package_a is installed in dbt_project_customer1 along side local_package_b and they work with no worries
having the empty macro as suggested still give me the same issue (same stack trace as reported above). This happens when I install the package local_package_b to another customer (ie dbt_project_customer2)
The command dbt deps install the packages correctly with no errors
The errors is shown when running dbt parse or dbt ls or dbt run or dbt build (any dbt command that actually compile the project code base)
the macro is called within local_package_a in some models as post hook (ie post_hook=["OPTIMIZE " ~ this, "{{ vacuum_model() }}"] in the model config
the macro is called within dbt_project_customer2 as follow post_hook = ['OPTIMIZE ' ~ this, '{{ local_package_a.vacuum_model() }}' ],
no model in dbt_project_customer2 calls the macro directly but it is defined as a general post hook for all models in the dbt project yaml (see below)

The only real difference between dbt_project_customer1 and dbt_project_customer2 with regards the macro is that the macro is used in some models in dbt_project_customer1, while the macro is defined as a general post hook for all the models in dbt_project_customer2 with
# dbt_project_customer1 dbt_project.yml
models:
  +post_hook:
    - "{{ local_package_a.vacuum_model() }}"

I found the issue: because the macro is added as post hook under models, I think it conflict with the local_package_a as the
dbt_project_customer2 dbt_project.yml has these lines:
# dbt_project_customer1 dbt_project.yml
models:
  +post_hook:
    - "{{ local_package_a.vacuum_model() }}"

  customer1:
# confs for customer1 models

  local_package_a:
# confs for local_package_a models
    ...

I believe putting local_package_a.vacuum_model() under models conflicts with the vacuum_model in the local_package_a models.
Funny things is that this issue comes out only when installing a new local dbt package.

Moving the macro from under models to the customer name fix this issue
# dbt_project_customer2 dbt_project.yml
models:
  ...

  customer2:
# confs for customer2 models
    +post_hook:
      - "{{ local_package_a.vacuum_model() }}"

  local_package_a:
# confs for local_package_a models
    ...

Thank you for replying to this :pray:


Orquesta workflow unit testing UX

Purpose
Allow unit testing of orquesta workflows.
Workflows with many forks need to be unit tested with fixtures to provide regression testing of functionality after making code changes in the yaml file.
UX new binary

orquesta-test
https://github.com/StackStorm/orquesta/blob/8035754f474e7872b0efd9e82e307a3121da027d/orquesta/tests/unit/base.py#L242
that will be refactored into the main orquesta module.

usage:

 orquesta-test -f [path to fixture] -l [path to workflow files named in fixture]

run a test against a workflow named in fixture

 orquesta-test -d [path to directory containing fixtures] -l [path to workflow files named in fixture]

run an entire directory of fixtures automatically one after the other

fixture spec in JSONobject yaml.
workflow_file_name:
  description: filename of workflow
  type: string
  required: true

expected_task_seq:
  description:  list of tasks names in the order expected
  type: array
  items:
    type: string
  required: true

expected_routes:
  description: routes expected in workflow
  type: array
  items:
    type: array
    items:
      type: number
  required false

inputs:
  description: input parameters to workflow
  type: object

mock_statuses:
  description: return status for each task
  type: array
  items:
   type: integer
  required: false

mock_results:
  description: array of results for each task
  type: array
  required: false

expected_workflow_status:
  description: expected workflow status output
  type: number

expected_output:
  type: object
  required: false

expected_term_tasks:
  type: array
  required: false
  items:
    type: string

Can we make this as part of st2-run-pack-tests instead of a separate command?

Could we do both?
On Mon, May 25, 2020, 21:03 W Chan<EMAIL_ADDRESS>wrote:

Can we make this as part of st2-run-pack-tests instead of a separate
command?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/StackStorm/discussions/issues/27#issuecomment-633757882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZ5TILFRT6L3BMT42GOESTRTMINJANCNFSM4NICNKAA
.

Well, we will have to do both. The st2-run-pack-tests is a bash script.
On Mon, May 25, 2020, 21:03 W Chan<EMAIL_ADDRESS>wrote:

Can we make this as part of st2-run-pack-tests instead of a separate
command?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/StackStorm/discussions/issues/27#issuecomment-633757882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZ5TILFRT6L3BMT42GOESTRTMINJANCNFSM4NICNKAA
.

ahh i see nosetests just uses python built in unit testing.  yeah that makes sense.

could you explain what a route is?

Route is a sequence of tasks that records the origin of a fork/split. A fork/split in orquesta is a non-join task that is referenced multiple times in a workflow.  If the task is called multiple times during workflow execution, this result in multiple independent branches.
Let's take this workflow as an example. https://github.com/StackStorm/orquesta/blob/master/orquesta/tests/fixtures/workflows/native/splits.yaml.
In the example, task4 and task8 are referenced multiple times and both tasks are not join.  So when task4 is called by task2 and task3, there will be two separate branches originating from task4.  Similarly, when task8 is called by task1 and task7s, there will be multiple branches for task8.  The route keeps track of these point of branching.
You can take a look at the unit test at https://github.com/StackStorm/orquesta/blob/master/orquesta/tests/unit/conducting/native/test_workflow_split.py#L54 to better understand.

@guzzijones If it requires a separate command to run, then it's fine. But as for running under st2-run-pack-tests, I want users to be able to define test cases in YAML/JSON and provide include the datasets for mocking action execution result. As it stands with orquesta-test, I prefer the datasets for each action execution to be in separate files (or at least have an option to put them in different files and then either pass file path to the command). The result can be huge and it's hard to pass them all through the command as arguments.

10-4 on defining tests using yaml/json files.
10-4 on orquesta-test command in orquesta using separate fixture files for each dataset to test.

10-4 on routes. Thank you for the clear explanation and the location of examples.

My TLDR on routes:
If a task is referred to in multiple locations the route tells you which transition it was transitioned from


[SR-1799] CoreFoundation has not be audited for nullability

Previous ID
SR-1799

Radar
None

Original Reporter
KaiDANTE (JIRA User)

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Foundation

Labels
Bug

Assignee
None

Priority
Medium

md5: 053a9800719c46ba7394b265d7da6be2

Issue Description:
After speaking to an Apple engineer during WWDC 2016 in the Swift Open Hour, he mentioned that it seems like CoreFoundation has not yet been audited for nullability. Specifically, the example that lead to the discovery is as follows:
let someMutableCFData = CFDataCreateMutable(nil, 0)!

CFDataCreateMutable() returns CFMutableData!, which lead him to think nullability hasn't been handled or audited.

We don't intend to update CF for nullability.


fix: increase range for the random value of request id in prover

Request id is currently generated by choosing random number 0-10000.
This range is too small, and in some scenarios causes duplicate ids in batch.
Example:
call eth_call to multicall contract, aggregating balanceOf calls of many tokens.
If enough tokens are queried, then many eth_getProof requests will be submitted in a batch. for a large amount of tokens there is a large chance of request id collision, failing the check in https://github.com/ChainSafe/lodestar/blob/unstable/packages/prover/src/utils/json_rpc.ts#L84

:tada: This PR is included in v1.14.0 :tada:


⚠ Bofrost.de has degraded performance

In 3da8cb3, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1758 ms

Resolved: Bofrost.de performance has improved in 504ab75 after 6 minutes.


WIP: Testing AutoHierarchicalNormalMessenger

This tests the use of a more complex AutoHierarchicalNormalMessenger guide both with and without local variables.
This guide constructs the posterior distribution conditional on parent variables - automatically replicating hierarchical variable dependencies of the model. This can improve the performance of hierarchical models. However, this guide operates in a very different way from standard AutoNormal (including lazy creation of new parameters if they appear in the model) - required to be tested.

Closing this for now.


Updated to the last stable FileHelpers Version 3.0.46

I just updated the library and the NuGet build script for use the last version of the FileHelpers library that must run much better and faster now
Based on:
https://github.com/hibernating-rhinos/rhino-etl/issues/12

Final version 3.1.2 released, I will close this PR because work continues on: #25

@MarcosMeli I'd suggest that you don't close this as your PR is much more subtle than mine it will be accepted easier. It's a simple change on your PR as well.

Reopened and updated :+1:

:shipit: @nathanpalmer :smile:


I found a broken link

@zhanglele6681 happy to re-open this one with more information about where the problem is


Add makefile for mingw

This is branch of PR from #42

@craigwi If you want single commit, please let me known. I'll squash commits before you will merge.

Thanks @mattn.  There was a comment about the name of the makefile.  I would prefer to have the mingw suffix, but are others ok with that?

I'm not sure I see the point of the prefix

How about renaming Makefile.mingw to GNUmakefile?

Doesn't make much difference, still have to manually specify the Makefile to make

It does make a difference. GNU Make also reads GNUmakefile by default.

Interesting but

The first name checked, GNUmakefile, is not recommended for most makefiles. You should use this name if you have a makefile that is specific to GNU make

Is worth noting

My point exactly. NMAKE doesn't understand this makefile, so I think it's fine to name it GNUmakefile.

The makefile does not look GNU make specific to me, so I dont think it should be named GNUmake.

I renamed Makefile.mingw to GNUmakefile since this makefile use subst as ePirat said.

I squashed commits to 1 commit. Please push merge button if you are okay. Thanks.

Thanks all!


feat: Num.pos and Num.neg constructors

Closes #117

@rultor merge it.

@rultor merge it.

@rafamizes OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge it.

@rafamizes Done! FYI, the full log is here (took me 3min)


Shims to compile under OpenBSD

STAILQ_HEAD is implemented as SIMPLEQ_HEAD
pty.h is like in apple , util.h

Thanks!


Jump page no refresh loading error

Screenshot

Description
First, very sorry, I have a poor English.
CSS template definition is still used when the dashboard custom CSS template jumps to other panels because there is no refresh.
Impact panels scope: dashboard, chart, database, dataset, SQL saved query/history query.
##Environment
superset version:master
Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review. If this includes a design proposal,
include the label design:suggest]

@xch-jack you mean making chart theme-able?

hi,
What I mean is that when the custom CSS template is switched to other sections, as long as it is not refreshed, the definitions in the custom CSS template will affect other sections, including dashboards, charts, databases, data sets, SQL queries/historical queries.
My English is very poor, I don’t know if the description is clear.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/superset"                                                                                @.>;
发送时间: 2021年5月18日(星期二) 下午3:35
@.>;
<EMAIL_ADDRESS>主题: Re: [apache/superset] Jump page no refresh loading error (#14681)
@xch-jack you mean making chart theme-able?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Add spectrum finetuning support

Not sure if this allign  with unsloth but spectrum is actually a very great way to finetune models it  selects layers with higher Signal to Noise Ratio  while adhering great performance
A great model which use spectrum is  Llama-3.1-Storm-8B
paper
github
Performance

Thanks for the feature request.

If it’s okay, I’d love to contribute to this feature. I can start by opening a draft implementation and possibly asking questions along the way to ensure it aligns with your vision. Let me know if that works for you!

Always excited for new additions :)


Add hidden context for icons in rows for summary tables

What is the context of this PR?
Fixes: #3030
This PR fixes the lack of context in summary tables where there is no status column and only an icon which in the case of the ticket, were checks for completion. Following from the DAC advice, we are now adding a visually hidden <span> to the icon's <div> to enable adding additional contextual information. This done by setting the "iconVisuallyHiddenText": {string} param in rowItems adjacent to "iconType": {icon}. The service can input the appropriate text to add context to whichever icon is being used.
Please make sure that this param is set when there is no other context on the row indicating section completion status (see the new minimal example).
How to review this PR
Check the new example-minimal for the summary table and see if the new span tag with section completed is there. Sense check the output from the screen reader
Checklist
This needs to be completed by the person raising the PR.

[x] I have selected the correct Assignee
[x] I have linked the correct Issue

Can you also raise a ticket to add this new example to the summary component?

Update documentation in this issue


Live workers do not work with RPC calls

Relating to #321, it seems live workers do not work when calling other RPC workers (sst v0.0.330).
Steps to reproduce:

Clone repo
Set environment variables and install providers (with sst install)
Run sst dev
Add a log statement in the handler of packages/functions/src/workerA.ts
Invoke the url of WorkerA

The corresponding log statement is not present in the terminal where sst dev is running, hence, I can only assume the request wasn't proxied to my machine and it invoked the deployed (now older) version instead. WorkerA calls WorkerB via workers RPC - I see live changes to my workers after removing the call to WorkerB. Assuming this is a bug and gets fixed, am I right in assuming that making a change in WorkerB will not be reflected when invoking WorkerA, since it's called over RPC, instead of HTTP?
Interestingly, when calling the fetch method of WorkerB instead, both workers are live (I observe changes made to either worker).

Tried on latest (3.1.13) and I actually cannot run it as it seems I can no longer override the esbuild target to es2020 which is needed to support explicit resource management (the using declaration) which is needed for RPC and I now just get esbuild syntax errors.
I got the es2020 fix from this unrelated issue.


Bug 5152 gracefully handle ssl handshake errors in app sdk for android

Exception handling for click event

Use these settings when testing (see attached picture)


[Snyk] Security upgrade setuptools from 39.0.1 to 65.5.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

resotolib/requirements.txt

⚠ Warning
jsons 1.6.3 requires typish, which is not installed.

Vulnerabilities that will be fixed
By pinning:

Severity
Issue
Upgrade
Breaking Change
Exploit Maturity

Regular Expression Denial of Service (ReDoS) SNYK-PYTHON-SETUPTOOLS-3113904
setuptools:  39.0.1 -> 65.5.1
No
No Known Exploit

Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

Superseded by #1282


Option to ignore images or videos with discovery

Clear and concise description of the problem
I have some videos in the main element that I don't want to include in the sitemap. However, I have not found a way to exclude them from the sitemap without disabling discovery altogether.
Suggested solution
Add an attribute, that marks the videos or images for exclusion, for example data-sitemap-ignore.
Alternative
No response
Additional context
No response

Hi, thanks for the issue. This option actually does already exist but it missing documentation.
I've pushed some improvements to the docs.
export default defineNuxtConfig({
  sitemap: {
    discoverVideos: false,
  }
})

@harlan-zw
Thanks for your response and the time to improve the documentation!
However, I'd like to keep Video (and Image) Discovery. But I'd like to exclude only certain images. I'm interested in a solution with a data-attribute, for example:
<main>
  <!-- This video is included -->
  <video>
    <source src="/media/cc0-videos/flower.webm" type="video/webm" />
  </video>

  <!-- This video is excluded -->
  <video data-sitemap-ignore>
    <source src="/media/cc0-videos/flower.webm" type="video/webm" />
  </video>
</main>

Hi, while this would be fairly straight forward it's not a type of customization I'd like to maintain.
A better solution for something like this is to use the Nitro hook which will let you customize the output however you like.
See https://nuxtseo.com/sitemap/nitro-api/nitro-hooks#sitemapresolved
Here's an example of how you'd do it
import { defineNitroPlugin } from 'nitropack/runtime'

export default defineNitroPlugin((nitroApp) => {
  nitroApp.hooks.hook('sitemap:resolved', (ctx) => {
    ctx.urls.map((url) => {
      if (url.videos?.length) {
        url.videos = url.videos.filter((video) => {
          if (video.content_loc) {
            const url = new URL(video.content_loc)
            return url.host.startsWith('www.youtube.com') // only include youtube videos
          }
          return false
        })
      }
      return url
    })
  })
})

@harlan-zw
Ah, that's perfect. I wasn't aware that such a thing is configurable with a Nitro Hook! Awesome! Thanks for your help!

No problem, just did a small update to that code block, old version wouldn't work :+1:


⚠ Spryr has degraded performance

In 4410214, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3595 ms

Resolved: Spryr performance has improved in 890287d after 10 minutes.


JS browser object model(BOM)

Description 📜

In this particular section, I would be making a document-based contribution to javascript browser object modeling and its basic functionality.

Domain of Contribution 📊

[ ] Android Dev (Flutter, Java, Kotlin)
[ ] Backend Dev (Java, .NET, Python)
[ ] C/CPP
[ ] Competitive Programming
[ ] Cyber Security
[ ] DSA
[ ] Database
[ ] Datascience with Python
[ ] Datascience with R
[x ] Frontend Dev HTML/CSS/JS
[ ] Frontend Dev React/Angular/Vue
[ ] Golang
[ ] Interview Prep
[ ] Java_Domain
[ ] JavaScript
[ ] MERN
[ ] Machine Learning
[ ] Open Source
[ ] Python_Domain
[ ] Rust
[ ] Statistics
[ ] UI/UX

In this particular section, I would be making a document-based contribution to javascript browser object modeling and its basic functionality. Please assign it to me.
/assign

/assign

@Surbhi-sinha remove non-domains 7 reopen


[ART-5504] create and wait on new rhcos builds

ART-5504 is part of a wider effort to interact with multi RHCOS builds like we expect. Here we lay the groundwork by moving the new build logic to pyartcd and having it use the Jenkins API to see when existing builds are running, create a new one if not, and wait for it (and its children) to complete so that we won't kick off duplicates (make the version lock work again).
This also provides knobs to create a new build even if one is running, and also to have a new build occur even when the RHCOS pipeline doesn't think it needs one. These will be useful for manual overrides or automated recovery from incomplete/inconsistent builds.
Finally, I think it provides improved status about what it sees and does. The last few trial runs are representative.

made some improvements and rebased. can't test ocp4_scan right now, not sure why it's broken in master.

Really nice work! This brings us closer to even more fine grained control thanks to the jenkins api
I saw a case where the build jobs succeeded but the release job failed https://saml.buildvm.hosts.prod.psi.bos.redhat.com:8888/job/hack/job/lmeyer/job/lmeyer-dev/job/dev-build%252Frhcos/55/
it was ultimately rerun manually. But in a case like that, if noone is closely watching, we could be skipping out
on perfectly good builds. So I guess we need to watch all 3 jobs closely, maybe rhcos team can handle some of that
retry logic if they wait for release job in the main build job

In theory we have the information here that the release job failed, and our status at least would consider it failed. We could in theory do something about it.
But that's kind of like noticing when OSBS creates a build and then brew fails to tag it. We could recover from that but... I just don't want that level of detail (and if a build fails, we don't know that it was a flake - we could waste a lot of time on retries). I want a build that succeeds or fails, and to start from scratch if it fails, so I'm hoping the RHCOS pipeline takes care of all those details. This is a workaround really...


fix(scoped-elements): unrecognizable tag names (#1293)

This commit uses the keys instead the class names for setting the tag names.

niiicccceee 💪


Add an interactive mode

In some cases, like performance regression, it's hard to write reliable automated tests to drive the bisection. It would be great to have a git-bisect like interactive mode allowing to run commands manually and then tag whether the tested version was good or bad.

Good example of something hard to automate is https://github.com/rust-lang/rust/issues/49336 ... I guess I have to resort to using rustup for this.


Add note about naming the file main.swift to README

This change adds a note about naming the file main.swift and using the @main attribute.
Motivation:
When transitioning to the 1.x API users may have had their files named main.swift and will encounter the error 'main' attribute cannot be used in a module that contains top-level code. This change adds a note to help remedy this issue and make it easy to locate when searching the repository.
Modifications:

Added note to readme.md

Result:

Improved documentation.

cc @abertelrud @neonichu - is there anything tracking a better error message from SwiftPM in such cases?

@swift-server-bot test this please


[EventHub] az eventhubs eventhub create/update: Change documentation of destination_name

Description of PR (Mandatory)
We need to know the allowed variables for running the command with --destination-name.
This only changes the documentation on https://docs.microsoft.com/en-us/cli/azure/eventhubs/eventhub

This checklist is used to make sure that common guidelines for a pull request are followed.

[ x] The PR title and description has followed the guideline in Submitting Pull Requests.

[ x] I adhere to the Command Guidelines.

#10031

add to S167

@brunomartinspro Hi, this PR title is not in the right format, please modify the PR title and description. For details, refer to: doc link

Hi! Is it okay now? If not what should I change it to?

@zhoxing-ms @yonzhan All builds passed..

@zhoxing-ms @yonzhan the builds have passed! 👍

@brunomartinspro If your requirements are related to specific commands, you can add the corresponding command to the title, like:

[IoT] iot hub: Support IotHub in the profile of 2019-03-01-hybrid (#12069)

@brunomartinspro If your requirements are related to specific commands, you can add the corresponding command to the title, like:

[IoT] iot hub: Support IotHub in the profile of 2019-03-01-hybrid (#12069)

Okay but since I only updated the documentation, is it not enough “[EventHub] Change  documentation of destination_name”?
I just added more text to the description.

You might write it like this: [EventHub] az eventhubs eventhub create/update: Change documentation of destination_name.  It's up to you~

@brunomartinspro You might write it like this: [EventHub] az eventhubs eventhub create/update: Change documentation of destination_name. It's up to you~

@zhoxing-ms i updated to your recommendation, thanks!

@v-Ajnava any news on this?

add to S170

add to S171

add to S172

@brunomartinspro Hi, could you please take a look at the new request from v-Ajnava? Is there any update?

Because there is no reply for a long time, so I tag it Do Not Merge first.

@zhoxing-ms @yonzhan Added the pull request recommendations.

@v-Ajnava Could you please help to review it again

@v-Ajnava please help take a look at the PR. Without your approval, we could not merge the PR.


Confusing semantics of Flag.Changed

The documentation says:
Changed             bool                // If the user set the value (or if left to default)
But it also says:
// Changed returns true if the flag was explicitly set during Parse() and false
// otherwise
func (f *FlagSet) Changed(name string) bool {
...
}

Both can't be true. - unless it's explicitly the intention that the field Changed and the function Changed has different behaviors.

"user" in first formulation is somewhat ambiguous — command-line user or programmer using the pflag library?  I believe intent here was the former, whether the flag was set explicitly by command-line flag, which matches the function's doc.
Here are subtleties I learned by trial-and-error and code reading:

Changed is set even when the value passed on command-line equals the default value.  (This is what makes it useful!)

pflag has no way to detect direct assignments to the variable associated with a flag, e.g.:
var flagvar int
flagset.IntVar(&flagvar, "flagname", ...)
...
flagvar = 42

Changed remains false in that case.

flag.Value.Set("42") has no effect on .Changed!  This is somewhat confusing :-|
This is a direct call to the Value interface which each type implements differently.  It has no access to the Flag object, so can't touch its .Changed field.

flagset.Set("flagname", "42") does set .Changed.  :arrow_left: Use this if you want to simulate "as if the user passed it on command line".

Ok ... I think I might have realized the source of my confusion.
The comment: "If the user set the value (or if left to default)"  can be interpreted in 2 ways (and I read it wrong).
wrong: The value is true if the user set the value or if left to default
right: The value is true if explicitly set - or it's false if left to default.
Also ... you're right that flag.Value.Set() not setting Changed is somewhat confusing.
That API is also just meant to be able to define new kind of flags, right ... not to actually set concrete instances of flags in the code.


Question:

How can one use your model to train on data that is already in the text form and has not come from reddit?
For example, I want to train the model on Cornell Movie Lines dataset.
Any suggestions?

keep your data in reddit phrase directory and run "reddit_phrase.py"


Support for Kubernetes 1.18 and up?

We have recently upgraded our Kubernetes version to 1.18.3 and observe some strange behavior from CSI driver.
Any new PVC and PV seem to be created successfully but the pods have problems mounting them in. Usually it would take a pod anywhere from 2-6 hours to successfully attach the PV the first time.
Here are some logs, if that helps:
kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T23:35:15Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:43:34Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

kubectl describe pv
Name:            pvc-333fe307-69ab-4cc8-9bac-50109b15bdd2
Labels:          <none>
Annotations:     pv.kubernetes.io/provisioned-by: block.csi.ibm.com
Finalizers:      [kubernetes.io/pv-protection]
StorageClass:    san-storage
Status:          Bound
Claim:           default/mongo-backup
Reclaim Policy:  Delete
Access Modes:    RWO
VolumeMode:      Filesystem
Capacity:        4Gi
Node Affinity:   <none>
Message:
Source:
    Type:              CSI (a Container Storage Interface (CSI) volume source)
    Driver:            block.csi.ibm.com
    FSType:            xfs
    VolumeHandle:      SVC:6005076380810428A000000000000338
    ReadOnly:          false
    VolumeAttributes:      array_address=xx
                           pool_name=UAT_POOL_RAID10
                           storage.kubernetes.io/csiProvisionerIdentity=1592537786498-8081-block.csi.ibm.com
                           storage_type=SVC
                           volume_name=UAT_pvc-333fe307-69ab-4cc8-9bac-50109b15bdd2
Events:                <none>

kubectl describe pod
Name:           mongo-dump-lvl46
Namespace:      default
Priority:       0
Node:           xx
Start Time:     Tue, 14 Jul 2020 14:36:32 +0700
Labels:         controller-uid=15b0c4ce-c734-434b-a46b-fdc7c0bae44f
                job-name=mongo-dump
Annotations:    kubernetes.io/psp: unrestricted-psp
Status:         Pending
IP:
IPs:            <none>
Controlled By:  Job/mongo-dump
Containers:
  mongo-dump:
    Container ID:
    Image:         bitnami/mongodb:latest
    Image ID:
    Port:          <none>
    Host Port:     <none>
    Command:
      mongodump
      --uri
      --out
      /dump
      --verbose
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /dump from mongo-backup-pvc (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-7tf47 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  mongo-backup-pvc:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  mongo-backup
    ReadOnly:   false
  default-token-7tf47:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-7tf47
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  disktype=SAN
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason       Age                   From             Message
  ----     ------       ----                  ----             -------
  Warning  FailedMount  3m46s (x29 over 87m)  kubelet, hs22v7  Unable to attach or mount volumes: unmounted volumes=[mongo-backup-pvc], unattached volumes=[mongo-backup-pvc default-token-7tf47]: timed out waiting for the condition
  Warning  FailedMount  90s (x10 over 81m)    kubelet, hs22v7  Unable to attach or mount volumes: unmounted volumes=[mongo-backup-pvc], unattached volumes=[default-token-7tf47 mongo-backup-pvc]: timed out waiting for the condition

Eventually it will successfully mount the PV, but the wait is too long to be productive.

CSI Block version 1.2.0 doesn't support K8S 1.18.
Please try to reproduce this issue on CSI Block version 1.3.0 and reopen if you encounter this issue again.


[19.03] roll-back libnetwork iptables forward policy change [DESKTOP-1934]

this rolls back the libnetwork bump from https://github.com/docker/engine/pull/330 with 1 commit
The patch made in  docker/libnetwork#2450 caused a breaking change in the
networking behaviour, causing Kubernetes installations on Docker Desktop
(and possibly other setups) to fail.
Rolling back this change in the 19.03 branch while we investigate if there
are alternatives.
diff: https://github.com/docker/libnetwork/compare/45c710223c5fbf04dc3028b9a90b51892e36ca7f...96bcc0dae898308ed659c5095526788a602f4726

ping @justincormack @silvin-lubecki @euanh @andrewhsu PTAL

Lgtm
On Mon, 7 Oct 2019 at 10:10, Arko Dasgupta<EMAIL_ADDRESS>wrote:

@arkodg approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/engine/pull/398?email_source=notifications&email_token=AADVYPCDHBR42ZHDVSN5WB3QNNURNA5CNFSM4I6GVYP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHDWECA#pullrequestreview-298279432,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADVYPDF2RSTMOT2V7A5OKTQNNURNANCNFSM4I6GVYPQ
.

Hmm...just one test failure:
--- FAIL: TestContainerBindMountNonRecursive (2.13s)
    mounts_linux_test.go:261: assertion failed: error is not nil: Error response from daemon: ttrpc: closed: unknown

kicked CI, but if we think it's ok, we can merge

[2019-10-07T18:45:19.141Z] --- FAIL: TestInspect (12.14s)
[2019-10-07T18:45:19.141Z]     inspect_test.go:23: Creating a new daemon at: /go/src/github.com/docker/docker/bundles/test-integration/TestInspect
[2019-10-07T18:45:19.141Z]     daemon.go:325: [d3ca03e6346e4] waiting for daemon to start
[2019-10-07T18:45:19.141Z]     daemon.go:325: [d3ca03e6346e4] waiting for daemon to start
[2019-10-07T18:45:19.141Z]     daemon.go:353: [d3ca03e6346e4] daemon started
[2019-10-07T18:45:19.141Z]     inspect_test.go:39: timeout hit after 10s: waiting for tasks to enter run state. task failed with error: task: non-zero exit (1)
[2019-10-07T18:45:19.141Z]     daemon.go:461: [d3ca03e6346e4] Stopping daemon
[2019-10-07T18:45:19.141Z]     daemon.go:296: [d3ca03e6346e4] exiting daemon
[2019-10-07T18:45:19.141Z]     daemon.go:448: [d3ca03e6346e4] Daemon stopped
[2019-10-07T18:45:19.141Z] === RUN   TestDockerNetworkConnectAlias

Daemon logs of the daemon for that test:
d3ca03e6346e4.log

But.. now DCO check fails? https://ci.docker.com/public/blue/organizations/jenkins/engine/detail/PR-398/5/pipeline

ah, that's probably because it's diffing the wrong diff 😞 need to backport https://github.com/moby/moby/pull/40035 for that

I created an escape hatch for that; let me rebuild with the "skip dco" option set

It's green now; I skipped the DCO check, but the commit is signed-off;

I'll backport https://github.com/moby/moby/pull/40035 to get this to prevent the DCO flakiness

bringing this one in


[11.0.x] ISPN-12820 JdbcStringBasedStore closed statement on exceptional code …

…path
https://issues.redhat.com/browse/ISPN-12820

Merged, thanks


Examples from graphql-scalar have wrong behaviour

Hi there !
I just updated to last version (1.0.5), and now I'm facing issues with scalar examples.
Examples are shown as Array, meaning with a String scalar it shows: ["abc123", "xyz789"].
I expected it to work just as examples in the metadata files : one random value being used during generation.
NB: this doesn't occur when graphqlScalarExamples: false.

Should be fixed in 1.0.6...sorry/thanks!


Add  element to tizen-manifest.xml

Add the <tv-info> element to the tizen-manifest.xml template (.NET-only). The TV seller portal automatically rejects app binaries without the element (https://github.com/flutter-tizen/flutter-tizen/issues/137#issuecomment-860364896). The Galaxy Store binary checker will ignore the element.
Remove trailing newlines from the templates. The tool automatically removes them when building a tpk.

Please refer to the internal guide for detailed information about the element.

New lines are deleted by updateManifest function. I think that it would be better to keep the new lines in template files and also add them in updateManifest.

@rwalczyna Alright. I'll change updateManifest() as you suggested.


(suggestion) Use s2n-quic instead of quinn for better performance and stability

According to quic-interop-runner results (repo), the quiche HTTP/3 library from Cloudflare (also made in Rust), is faster than quinn.
In more than one test, quiche was more than 2x faster than quinn, and there were tests where quinn failed while quiche succeeded.
Not only that, quinn's maintainers already stated on https://github.com/quinn-rs/quinn/issues/1320 (still open) that quinn is currently maintained by only two volunteers, and this makes difficult to improve quinn in the same pace of other more robust libraries, like quiche, maintained by Cloudflare.

Hi Paulo,
That's a nice suggestion, thanks! Yes, considering the perspectives of performance/maintenance, changing HTTP/3 library from quinn to quiche would be better. But to this end, there are several technical challenges.

quiche only provides really 'low-level' APIs. So we need to handle low-level event loop.
quiche uses BoringSSL, but rpxy currently heavily relies on rustls. We should manage both crypto materials inside rpxy. (This probably works, but will be a bit messy in the code)
We use hyper to quickly handle HTTP messages proxying from/to  backend applications. But since quiche::h3 is not compatible with hyper, we should consider how to glue hyper with quiche.

One option is to ignore quiche::h3 and implement hyperium/h3 (hyper's HTTP/3 trait) for quiche itself. This was considered here https://github.com/hyperium/h3/issues/147 and an experimental implementation was provided at eagr/h3-quiche.
The first option has a problem that quiche doesn't provide sufficient interface to appropriately handle HTTP/3 streams as mentioned at https://github.com/hyperium/h3/issues/147#issuecomment-1331973240. So another option is to glue quiche::h3 with hyper as suggested in the comment . I think this is better than the first option.

Anyways, I think this idea should be seriously considered to maintain rpxy. So first, I will test quiche separately from rpxy.
(I know the most ideal option is that I contribute quinn and improve its performance dramatically... Also from our initial philosophy of rpxy, it should be written in pure Rust with community-based codes as much as possible. Of course, that's really tough, and sometimes impossible...)

If he challenges described become too problematic, maybe it's better to continue with quinn until we have a better scenario.

Agree. I will take a look the code in deep.

Update of my previous suggestion: s2n-quic instead of quiche
It is as fast as quiche, is maintained by AWS and can use s2n-tls or rustls, both pure-rust TLS libraries.
The only drawback is that s2n-quic fails in a few tests (as quinn does, as well), but at least it provides the same performance as quiche
(on the tests, I believe that s2n-quic is using s2n-tls, which seems to be the easy and natural path)

Hi Paulo, thanks for your information!
Yes, s2n-quic looks a promising option. Moreover it provides s2n-quic-h3 which is an implementation of hyperium/h3 used in rpxy. So, I think it would be easier to use it inside rpxy than quiche!

I am roughly testing s2n-quic and s2n-quic-h3 from the viewpoints of

use of rustls to be compatible with http2 and 1.1,
serve multi-domain.

At this point, I confirmed that it works as a simple http/3 server using s2n-quic-h3 with hyperium/h3. I think that we can reuse the most part of codes written for h3-quinn for s2n-quic-h2, ands2n-quic and s2n-quic-h3 can be used in rpxy much like quinn. So so I will test more.
Also I think the better way for rpxy is to support both quinn and s2n-quic as features, where either one is default.

Also I think the better way for rpxy is to support both quinn and s2n-quic as features, where either one is default.

If this doesn't create an additional burden on you (and future contributors) regarding the code maintainability, this approach has the advantage of making rpxy more modular with the different libraries and implementations of HTTP/3

I just made an example implementation of HTTP/3 server (and client) using s2n-quic with rustls. https://github.com/junkurihara/s2n-quic-h3-examples
As my first impression, s2n-quic seems to probably have  limitations on configurability of some parameters with rustls like TLS cipher suites. But I think it would not be a big issue.

Here's initial integration of s2n-quic! https://github.com/junkurihara/rust-rpxy/pull/65

Incredible work! :tada: :tada: :tada:
(If you want, I believe we can now close this issue. Mission accomplished!)

Thanks Paulo!
Yes, I will close this issue soon after I merge the branch to main :-)

Merged!


Stackoverflow when calling getKoin in custom view

I have a weird exception when getKoin() is recursivly being called until Stackoverflow exception. It happens when I try to get the instance in my custom view via context.getKoin().get<T>. What can be the source of the issue?

Here are my modules:
class MainModule: AndroidModule() {
    override fun context() = applicationContext {
        provide { PackManager(applicationContext, get()) }
        provide { Repo(get()) }
    }
}

class NetworkModule: AndroidModule() {
    override fun context() = applicationContext {
        provide { OkHttpClient()/*.Builder().addInterceptor(LoggingInterceptor()).build()*/ }
        provide { NetworkStateMonitor(applicationContext) }
        provide { Retrofit.Builder()
                .baseUrl(NetworkClient.BASE_URL)
                .client(get())
                .addConverterFactory(GsonConverterFactory.create(gson))
                .addCallAdapterFactory(RxJava2CallAdapterFactory.create())
                .build()
                .create(LivliApi::class.java) }
        provide { NetworkClient(get(),get(),get()) }
    }
}

If there is a circular dependency wouldn't it fail with by inject()? Because injecting the same instance in a filed works fine.

by inject()and getKoin().get<T> use the same method from koinContext. But the first one return a lazy, of your result.
What version of Koin do you use ?

Yeah I know and for some reason lazy init works fine and eager does not. Maybe it has something to do with timing? I am using 0.4.0

Yes, I think your component is not yet ready when you requesting it in your custom view. I also must admit, that I never tested injection into custom views. What do you try to inject ?

I am trying to inject my custom object. For some reason 0.5.1 fixed it and there is no more stack overflow exceptions. Hope it stays this way :)


Matchmaking error?

I'm trying to test matchmaking but it won't work for some reason. Any help? Here are my matchmaking settings as well in config.

nevermind it was the season. Matchmaking for season 5 below when?


[coll] Increase timeout limit.

One of the pyspark workflows ran into troubles due to timeout. One of the workers started constructing QDM while another one took more than 5 minutes after the first one to get started. The time was spent on the cache_partitions function. Not much can be done in XGBoost since it's simply fetching partitions from pyspark.
This PR increases the timeout to 30 minutes from 5 minutes. Please note that, the timeout is caused by the difference between workers, which should be minimal for normal workflows.

cc @wbo4958

LGTM. Thx


jfes.c issues part 2

return jfes_memcmp(data, "null", 4) == 0;
Better use strlen("null") instead of magic numbers.

jfes_is_integer():
a. what about hexadecimal integers?
b. why are you casting '0' and '9' from char to int? data[i] is char.

jfes_is_double():
a. same question about casting;
b. you don't need to use "else if" if the if block ends with "continue".

jfes_string_to_integer() and jfes_string_to_double() just ignore non-number characters in input - is this the intended behavior?

char *jfes_boolean_to_string(int value) {
static char *true_value = "true";
static char *false_value = "false";
return value ? true_value : false_value;
}
Just 'return value ? "true" : "false";'
Maybe it's worth to have defines for "true" and "false" to use them in such functions.

I'm tired, need a break ;)

Thank you very much for these valuable reports!

I will make this argument optional, as I described in this comment.
All accepted. I'll work on hexadecimal and octal integers.
Casting accepted. But I think I need to use else if, because this condition does not interfere with the course of the program, does not affect the performance, but shows a program algorithm.
These functions returns an integer/floating point value. They can't signal, if input data is invalid. I think, I'll add to the functions description warning, that input data should be checked for correct input by jfes_is_integer() and jfes_is_double() functions.
Accepted.

You're welcome :)

Also, I'd recommend splitting jfes.c into several modules - unless there are some very good reasons to keep all code in a single file.

JFES planned as single-file library, but it had grown. I will think about splitting it into several files, thank you.


Refactor watch-metrics.sh script

What changes are proposed in this pull request?
Refactor the watch-metrics.sh script to be more useable, and to increase its flexibility.
Why are the changes needed?
The previous script required knowledge about the format of the JSON returned by the Alluxio metrics JSON sink. This version of the script only requires the metrics keys.
Does this PR introduce any user facing changes?
Developers using the script will see changed flags & functionality.

alluxio-bot, merge this please!

@Xenorith do you think doc is needed for this watch-metrics.sh?


Allow language selection

The content and the internal content representation have been designed to allow translations but this should be also reflected in the frontend and made available to users.

Being able to switch to any language could potentially be difficult as it requires the backend to send in which languages the current page is implemented (a translation might be outdated or incomplete).
I guess we could just drop the selection idea and show the available languages at the beginning (like the Go Tour).
Moreover it we use a lot of precious ui space for a feature that is not commonly used.
Hence I will go ahead and close this, feel free to reopen in case of arguments for such a interactive  selection.

I fully agree. Good idea.


TwingToken is not exported

I'm trying to port a TwigPHP tag extension to work on Twing, but it seems that TwingToken is not exported from the main entry point and therefore e.g. Twing.TwingToken.BLOCK_END_TYPE can't be used from user JS code.

You're totally right. That's an oversight. I'll fix that.
As a workaround, you can require/import TwingToken by using the path to the token module:
const {TwingToken} = require('twing/lib/twing/token');
// or
import {TwingToken} from 'twing/lib/twing/token';

Thanks for reporting!


Improved trees

The wood of a tree now drops a stick (which is a new item added). The crafting recipes where you needed wood now need sticks. When you break a block of a tree stem all the wood blocks above will break, too.

Love it! Good idea!


StatusEntry::path does not get a joinable path string

As I can read in https://github.com/rust-lang/git2-rs/blob/ae256db3b27dd7dedab02fa5c051bd7adedf7de7/src/status.rs#L316
StatusEntry::path() returns the relative path to the repository root.
Unfortunately, this path seems to always use the /directory separator.
Thus, on Windows (where the directory separator is \\), joining such a string with Path::join() will produce a path with both \\ and /directory separators.
In my usage, I get \\\\?\\C:\\Users\\runneradmin\\AppData\\Local\\Temp\\.tmpRy1iwp\\d1/f1 where the relative path d1/f1 has been join()ed with a canonicalized path.
Is it the excepted behavior?
Is it a good idea to change the signature of StatusEntry::path() to return an Option<Path>?

This is just binding the raw libgit2 return value, so if you'd like that to change I'd recommend opening an issue with libgit2 itself.

Ok. I will see how Windows paths are managed in libgit2 and other bindings.


fix: ws

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove output formatting to get back what was put in

Looks like the html formatter from before caused some weird output for >-like symbols. This jsut removes formatting entirely so we're just getting back what was put in to begin with. Safe enough, though the docs say that it might output invalid html, but that seems to be the case if the html was invalid to begin with.
cfgov/manage.py sheer_index
http://localhost:8000/about-us/blog/mortgage-moves-what-kind-of-mortgage-will-you-get/ check for correct output of apostrophes
http://localhost:8000/about-us/the-bureau/leadership-calendar/ check descriptions for correct output of >'s

@rosskarchner @kave @richaagarwal

:+1:


Implement Linear Discriminant Analysis

References :-
https://www.section.io/engineering-education/linear-discriminant-analysis/
https://youtu.be/9IDXYHhAfGA

Me and Ritam (Mobius-strip) would like to work on this, thanks!

yes, we both would like to work on it, thanks!

Sure, go ahead, understand the principle and implementation itself, then come back with the script accordingly.

Due to prolonged absence of contribution in this issue, its now open for anyone to contribute. But first, get assigned by messaging here.

can I try this, I am new to this but want to work with this i know python and interested to learn about it

Have you went through the basic resources, mentioned for the issue as well as the mathematics?

Can I try this ???

Surely

https://colab.research.google.com/drive/1tCT28q7D3YlMnGmVLEiFWsAdT2hlW-ZY?usp=sharing
@Exoutia Is it fine???

https://colab.research.google.com/drive/1tCT28q7D3YlMnGmVLEiFWsAdT2hlW-ZY?usp=sharing
@Exoutia is it fine???

@testgithubtiwari  I dont have access to this file grant me access

@Exoutia Now you can access.

@testgithubtiwari  looking good to me now you can add some tests and some comments to code then you can add your code to your branch it should be fine


test/2,3 in ExUnit should not have parens

It's formatted as
test("some test") do
  ...
end

I think we should not hardcode these, probably all things that take do...end should not have parens in their args before the block.

Thanks for the tip! I have pushed a fix (link) to master, this should be fixed.


Forward/ Reply message with attachments

How to add attachments to the forward/reply message?
After finding mail items from inbox, I use following code to forward/ reply mails
EmailMessage msg = (EmailMessage) item;
msg.load();

List<EmailAddress> emailAddresses = new ArrayList<EmailAddress>();
emailAddresses.add(new EmailAddress("user1@gmail.com"));
emailAddresses.add(new EmailAddress("user2@gmail.com"));
msg.getAttachments().addFileAttachment("mypaths\\test.txt");
msg.forward(MessageBody.getMessageBodyFromText("Test forward mail .........."), emailAddresses);  // message is being forwarded but without attachment

Also tried -
ResponseMessage resMsg = msg.createForward();
resMsg.setSubject("mysubject");
resMsg.setBody(MessageBody.getMessageBodyFromText("Test forward............"));
resMsg.getToRecipients().add(new EmailAddress("user1@gmail.com"));
resMsg.getCcRecipients().add(new EmailAddress("user2@gmail.com"));
resMsg.send();  // message is not being forwarded. could not find method to add attachment

Same goes with createReply() and msg.reply() methods.
Thanks

I haven't run into this myself, so it's a bit of a stab in the dark. Attachments in EWS can be a bit tricky.
A ResponseMessage is descended from ServiceObject, so you could try resMsg.setObjectFromPropertyDefinition(ItemSchema.AttachmentCollection, myAttachments). I can't say for certain if the operation would be explicitly supported through EWS, though.
Have a look inside the EmailMessage class. When creating an email with attachments, it will create the message in the drafts folder, then save the attachments, then send the message. Since ResponseMessage doesn't have this process built in (and that may be a feature request if Exchange supports the operation), you'll have to do it manually. EmailMessage.forward() simply creates a ResponseMessage and sends it. You can try using EmailMessage.createForward() instead and use the same manual process on the returned ResponseMessage. It seems that ResponseMessage.save() (no arguments) will save it to the drafts folder if I'm reading this correctly. Then you can use AttachmentCollection.save(). Since the send() methods will attempt to create it again, you can try using ResponseMessage.save(WellKnownFolderName.SentItems), which should accomplish the same thing.
Like I said, this is mostly guesswork, but it may well do the trick.

@rutvi-zymr do you have any feedback on this?

Same question ，Does anyone know how to solve it?


Implement Theme for Dark Mode

🚀Feature Request
Implementation of Theme for Dark Mode
Expected behavior
An aesthetic Dark Mode with a theme and drawables similar to the theme used in Light Mode.
Current behavior
Uses Default Dark Theme and some customised Theme colors in Dark Mode that don't go well with the App's Theme in Light Mode.
Step to reproduce
Turn Dark Mode On after running the application.
Possible Solution
Modify the Colors and Drawables being utilised  when application is being used in dark mode.
Why is this feature important to you?
This feature give a sense of uniformity allowing the app to be usable in dark mode too.

Hey!I am working on the issue

Comment on Github Issue
On Wed, Oct 9, 2024 at 12:52 PM AGNIHOTRIMAHI @.***>
wrote:

Hey!I am working on the issue
—
Reply to this email directly, view it on GitHub
https://github.com/ContriHUB/Just-Share/issues/1#issuecomment-2401533820,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXHBMIXEGJOMY2DJFN3DHOLZ2TKRVAVCNFSM6AAAAABPOB3SPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGUZTGOBSGA
.
You are receiving this because you were assigned.Message ID:
@.***>

I am interested in doing this. Should I start?

This project is in Kotlin, but I don't know the language. I am familiar with React and CSS. Can I still contribute to improving this project?

Yes, you can try learning it on the go, if you are interested.

Hi @ShivaniSaini123 . How will you implement dark theme. I need to know because i am working on a follow up issue requires to know your implmentation.

I don't know kotlin,but I implement before in react
On Thu, 10 Oct, 2024, 2:39 pm Aachintya, @.***> wrote:

Hi @ShivaniSaini123 https://github.com/ShivaniSaini123 . How will you
implement dark theme. I need to know because i am working on a follow up
issue requires to know your implmentation.
—
Reply to this email directly, view it on GitHub
https://github.com/ContriHUB/Just-Share/issues/1#issuecomment-2404535121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGHVSAKTRD5EN5OLABDBBWDZ2Y74TAVCNFSM6AAAAABPOB3SPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBUGUZTKMJSGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ok i'll wait for 1 day

You can start your work; I am working on another issue assigned by the seniors

@SaiDheerajPeketi can you assign me this issue. i know kotlin

@SaiDheerajPeketi please add hacktoberfest label to this issue

@SaiDheerajPeketi please review my PR

I've added bonus for this issue, if you implement theme based icon

I've added bonus for this issue, if you implement theme based icon


Support more pre-filtering at the outset

For very large datasets, microscopium becomes unwieldy. Even though Chrome performance is fine for 50,000+ images, as a user, it's very hard to navigate that many points. Therefore, the ability to filter points based on certain criteria, perhaps as a command-line option to the serve command, could help users in their exploration.

I like this idea, but I disagree that a command line argument when you launch the server is the right way to go.
I'd expect users would want to try out a couple of different ways of filtering things (and maybe tweak thresholds on whatever criteria they have a bit), and that would be really annoying to do if you need to re-launch the server every time.

Sure, good point. So, live filtering based on a whole bunch of parameters. Piece of cake. =P
Actually, I think there's quite a few examples of cross-filtering in the Bokeh server gallery. So we could get inspiration from those. =)

Sure, good point. So, live filtering based on a whole bunch of parameters. Piece of cake. =P

I know, I know :)
Relaunching the server can always be our fallback option if we really can't make it work well in a more usable way.


Feature/add middlewares

Description
Pretty standard implementation of http error middleware. Might have to adjust it later as right now it also converts all other exceptions into Internal Server Error, which might not be useful for the front-end.
Related issues

Fixes #9
Type of change

[x] New feature (non-breaking change which adds functionality)

Changes Made

add middleware in a separate file and reference it in server initiation

Testing

[x] Unit Tests

I added some suggestions for stuff we discussed yesterday:

removed /{schema}, we don't need it since we have /object/{schema}
added checks that /object/{schema} returns 404 if schema is wrong (like "stuuufyy" etc)
fixed that AssertionError bug @csc-jm noticed, it now returns 400 for error.

@csc-jm feel free to fix these, if you'd like to handle things differently!

Btw, would be also good to log errors in middleware

yeah logging is lacking a bit at the moment, was testing yesterday the backend, but logs were quite scarce

Added a test for the 404 case in the handlers just to see for myself how that works. Can be removed if not a necessary test. Added some logging aspect in the middleware without being completely sure, if it was the proper way. Well, it's merged now. :D

@csc-jm you can create a new PR and we can merge that as well.


Write a C# program to find the largest three elements in an array

Description
Write a C# program to find the largest three elements in an array
Input  : arr[] = {10, 4, 3, 50, 23, 90}
Output : 90, 50, 23

Input  : arr[] = {10, 4, 3, 50, 23, 90, 1, 100, 49}
Output : 100, 90, 50

How to contribute

Comment !assign to assign this issue to yourself
Fork this repository
Create a new branch
Save the solution in program/program/find-the-largest-three-elements-in-an-array/FindTheLargestThreeElementsInAnArray.cs
Commit the changes
Create a pull request

!assign


WebView inside swiper reloads

I'm using a Swiper to wrap a couple of WebViews.
But each time I swipe, the WebView reloads (and scrolls to the top).

hi @subpublicanders I think the new version fixed this issue.

838b24c Re-design a loop model for avoid img flickering.

If not, make me know i will check it again, thanks

Worked like a charm!
I'll be trying the latest each time in the future :)


Match data does not auto parse even if logged in using Steam

Yes, automatic parsing is somewhat unreliable lately due to Valve rate limiting accessing to replay salts.  Hopefully this will improve after TI is over.  For now, you may have to request parsing for matches that you want parsed more quickly.

It looks like the limits have been lifted so automatic parsing should resume.


Beautify: Website Beautification

Pull Request Description for Beautify Website Design Improvements
Summary:
This pull request introduces a visual refresh for the Beautify website, aiming to enhance user experience and create a more visually appealing aesthetic.
Changes:

Homepage: Updated the background image and logo to create a fresh first impression.
Subpages: Consistent background updates applied to all subpages for a cohesive look.
Content: Refreshed tagline text, colors, and fonts to improve readability and brand alignment.
Visual Appeal: Enhanced the visual style of boxes and buttons, making them more attractive and user-friendly.

Benefits:
*Improved User Experience: The updated design aims to provide a more engaging and informative experience for visitors.

Enhanced Brand Consistency: Consistent visuals across the website strengthen brand recognition.
Increased Visual Appeal: The refreshed design is more visually appealing and reflects the project's value proposition.

Testing:
I have thoroughly tested these changes on various devices and browsers to ensure proper functionality and responsiveness.
Further Discussion:
I'm open to any feedback or suggestions for further improvements. Let's discuss if you have any questions or require additional information.
Note:
I've attached screenshots of the "before" and "after" versions for your reference (consider attaching screenshots if possible).
Thank you for your time and consideration!
This description highlights the key changes, their benefits, and your testing efforts. Remember to replace the generic "screenshots" with actual screenshots showcasing the changes for a clearer understanding.

Pls mention the issue number for this PR, edit the PR description above and fill all the details properly @Riyaa019

Ok I will do the needy and reply to you soon
On Thu, 13 Jun, 2024, 12:08 am Rakesh Roshan, @.***>
wrote:

Pls mention the issue number for this PR, edit the PR description above
and fill all the details properly @Riyaa019 https://github.com/Riyaa019
—
Reply to this email directly, view it on GitHub
https://github.com/Rakesh9100/Beautiify/pull/975#issuecomment-2163678707,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDTAZTVAIBYSAYESTDEVFJ3ZHCIUBAVCNFSM6AAAAABJF4E66CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGY3TQNZQG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Do in this same PR, don't create any new PR. You have to edit the PR description @Riyaa019

Can you please describe in detail the things I have to mention

Here's my Issue number #984

Here are the screenshots of changes I have made

Please do not create a PR until you have been assigned to an issue @Riyaa019

Actually I forgot to create issue that's why I created after Creating the PR
On Thu, 13 Jun, 2024, 7:12 pm Rakesh Roshan, @.***>
wrote:

Please do not create a PR until you have been assigned to an issue
@Riyaa019 https://github.com/Riyaa019
—
Reply to this email directly, view it on GitHub
https://github.com/Rakesh9100/Beautiify/pull/975#issuecomment-2165714892,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDTAZTXOIMDDIOMGWWWJ6U3ZHGOURAVCNFSM6AAAAABJF4E66CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRVG4YTIOBZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Bug: Mysql connection issue with MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT

https://github.com/codeigniter4/CodeIgniter4/blob/1d40479705a531a3f98371bd12588a20f601268b/system/Database/MySQLi/Connection.php#L162-L165
Hi, i am facing a problem making a mysqli ssl connection to database.
I am using CodeIgniter version 4,
mysqli->client_info = "mysqlnd 7.4.3"
Database driver: "MySQLi"
The problem is that when i have the ssl_verify = false, it never gets into:
elseif (defined('MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT') && version_compare($this->mysqli->client_info, '5.6', '>=')) 					{ 						$client_flags += MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT; 					}.
The version_compare is comparing the mysqli->client_info which in my case is "mysqlnd 7.4.3" to a "5.6" and this will always return false.
Something similar is happening on line 166.
A possible fix it could be replace that part of the version_compare to:
elseif (defined('MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT') && version_compare(preg_replace("/[a-zA-Z\s]/", "", $this->mysqli->client_info), '5.6', '>='))
Where there i am replacing any string and whitespace before the version number.
Would you be able to change this? If not, which could be the solution to this problem?

Can you open a PR for this?

Can you open a PR for this?

Ok. I am not sure if i should create a new branch or make the pull request in an existing one?

Please create a new branch for your PR.

#4566 pull request done


Readers

I took a couple of magnetic card readers that were made for smart phones. One from FirstData, another from AnywhereCommerce. Pligged them into iPhone's phone jack; both didn't seem to work on iOS in either Safari or Chrome using your demo page. I also ordered a couple of chinese generic magnetic readers from Amazon but they didn't arrive yet, so I can't tell if those will work or not. In general, do those phone card readers have to be of a certain type? Thanks!

The plugin expects to see keyboard events, from readers that simulate a keyboard. A reader made for smartphones may not work that way -- it could have an API that you can get to with an app, but not from a web site. This project is intended for web sites. Have a look at this comment in another issue: https://github.com/CarlRaymond/jquery.cardswipe/issues/13#issuecomment-191996504
The writer describes using a USB-to-Lightning connector with a USB reader, and it works.


QBFT Smart Contract Validators

Deploy validator contract
transition to smart contract validators
test we can add validators and validation stops

This is great addition! LGTM but I'm not a PEEPS expert so will leave to someone else to approve. The PR makes sense to me from a QBFT point of view.
Am I right that the test only involves besu nodes...if so intrigued to know if there is a plan to add GoQuorum nodes as well?

Yes, will be adding go-quorum nodes (probably changing this test) when we implement smart contract validator transitions.


conference-schedule-app

issue : #10
conference schedule app

[x] @fullcalendar/react library to display the calendar.
[x] Daygrid plugin to display the calendar in day format.
[x] Time grid plugin to display the calendar in 24 hr time format.
[x] Interaction plugin from @fullcalendar to actually interact and schedule an event.
[x] Able to delete scheduled events.


Non resizable window withouth title bar has border when updating to 1.6

Describe the bug
With the 1.6 version i get a white border around a window that's not resizable.
Steps to reproduce the bug
Create a window with the following code:
Window window = new();
OverlappedPresenter presenter = OverlappedPresenter.Create();
presenter.IsResizable = false;
presenter.SetBorderAndTitleBar(false, false);
window.AppWindow.SetPresenter(presenter);
window.AppWindow.Show();

Expected behavior
There is no border around the window
Screenshots

NuGet package version
WinUI 3 - Windows App SDK 1.6.0: 1.6.240829007
Windows version
Windows 11 (22H2): Build 22621
Additional context
Works fine with WindowsAppSDK 1.5.240802000

Also running into this issue, worked fine on 1.5. Is there any fix / workaround?

@Usergitbit There is no fix that I'm aware of and I do not now if this will be fixed in the next release.
I guess as a workaround you can manually implement the MaxWidth/MaxHeight/MinWidth/MinHeight on the window, set the window resizable and set the same value to the max and min property.
The downside would be that the cursor appears to be resizable on the window when it's actually not.

Also running into this issue, worked fine on 1.5. Is there any fix / workaround?

You can remove the style for the frame :
private IntPtr hWndMain = IntPtr.Zero;
hWndMain = WinRT.Interop.WindowNative.GetWindowHandle(this);
SetWindowLong(hWndMain, GWL_STYLE, (IntPtr)(GetWindowLong(hWndMain, GWL_STYLE) & ~(WS_DLGFRAME)));

with :
        const int GWL_STYLE = (-16);
        const int GWL_EXSTYLE = (-20);
        public static IntPtr SetWindowLong(IntPtr hWnd, int nIndex, IntPtr dwNewLong)
        {
            if (IntPtr.Size == 4)
            {
                return SetWindowLongPtr32(hWnd, nIndex, dwNewLong);
            }
            return SetWindowLongPtr64(hWnd, nIndex, dwNewLong);
        }

        [DllImport("User32.dll", CharSet = CharSet.Auto, EntryPoint = "SetWindowLong")]
        public static extern IntPtr SetWindowLongPtr32(IntPtr hWnd, int nIndex, IntPtr dwNewLong);

        [DllImport("User32.dll", CharSet = CharSet.Auto, EntryPoint = "SetWindowLongPtr")]
        public static extern IntPtr SetWindowLongPtr64(IntPtr hWnd, int nIndex, IntPtr dwNewLong);

        public static long GetWindowLong(IntPtr hWnd, int nIndex)
        {
            if (IntPtr.Size == 4)
            {
                return GetWindowLong32(hWnd, nIndex);
            }
            return GetWindowLongPtr64(hWnd, nIndex);
        }

        [DllImport("User32.dll", EntryPoint = "GetWindowLong", CharSet = CharSet.Auto)]
        public static extern long GetWindowLong32(IntPtr hWnd, int nIndex);

        [DllImport("User32.dll", EntryPoint = "GetWindowLongPtr", CharSet = CharSet.Auto)]
        public static extern long GetWindowLongPtr64(IntPtr hWnd, int nIndex);

        public const int WS_DLGFRAME = 0x00400000;

That seems to work for me, thanks @castorix.

Workaround works for me, but still it's a workaround please fix that

Really annoying bug where customers are asking questions to the developer (us) on why their app is "messed up".. Years later and WinUI3 is still terrible

Unfortunately, workaround not works for me.
Windows11 uses different style I guess?

This trick works for me after upgrading 1.6 even though I decided to rollback back to 1.5 because of other issues.
ExtendsContentIntoTitleBar = true;
presenter.IsResizable = false;
presenter.SetBorderAndTitleBar(true, false);

This trick works for me after upgrading 1.6 even though I decided to rollback back to 1.5 because of other issues.
ExtendsContentIntoTitleBar = true;
presenter.IsResizable = false;
presenter.SetBorderAndTitleBar(true, false);

Nice Trick
tnx

Try OverlappedPresenter.CreateForContextMenu()

Just did some reverse work:
CreateForContextMenu = WS_BORDER
CreateForDialog = WS_SYSMENU | WS_CAPTION
CreateForToolWindow = WS_OVERLAPPEDWINDOW
IsAlwaysOnTop = WS_EX_TOPMOST
IsMaximizable = WS_MAXIMIZEBOX
IsMinimizable = WS_MINIMIZEBOX
IsModal = Enable/Disable parent Window and some other stuff (restricted to hwnd with owner set) See https://github.com/microsoft/WindowsAppSDK/issues/3258
IsResizable = WS_SIZEBOX(WS_THICKFRAME)


Ndv tfa

Current coverage is 98.06% (diff: 100%)

No coverage report found for master at c6ea1d8.

Powered by Codecov. Last update c6ea1d8...51b942e


How to specify the source port number when a client wants to Dial to server

I wonder if there is a way to specify the source port number for the function quic.Dial. I know that using the net package has a function called DialUDP allowing to specify the source port number when connecting to a server.

You can construct a Transport with a UPDConn that you created yourself.

Thanks @marten-seemann for the feedback.
I tried to create a transport from UDPConn. But i didn't know how to do it properly because transport.Dial return the error: INTERNAL_ERROR (local): write udp <IP_ADDRESS>:44746-><IP_ADDRESS>:59951: use of WriteTo with pre-connected connection
This is the part the code, i did use:
	tConn, err := net.DialUDP("udp", lAddr, rAddr)
	if err != nil {
		sugar.Debug("Could not create UDP connection: %v", err)
	}

	transport := &quic.Transport{Conn: tConn}

	conn, err = transport.Dial(ctx, rAddr, tlsConfig, quicConfig)
	if err != nil {
		sugar.Debug("Connect to quic server failed: ", err)
	}

It’s all explained in the README.

Thanks @marten-seemann again. Actually, i did check the README, and i did just find a implementation for the server. But, i need to specify source port of the client. When defining the server, no client is connected to server so the transfer of net.UDPConn to quic.Connection will work, but how about the client if he already connected. And the problem, is that internally the function writeTo is called instead of write.

Use ListenUDP instead of DialUDP. Just like it says in literally the first paragraph of the README.

Solved. Thank you @marten-seemann.


Introduce Network Policies feature

Description
Adds the sets of Network Policy views to Network and Discovery menu
Related issue(s)
Solves #948

/test pre-busola-integration-test-k3s


no such module Shout

mkdir ssh_shout
cd ssh_shout
swift package init --type executable
Then I added
.package(url: "https://github.com/jakeheis/Shout", from: "0.2.0")
in the Package.swift
Then I entered
swift package fetch
Then in Souces/ssh_shout/main.swift I entered import Shout, then
swift build

and I got "no such module Shout".
What can be the problem?
Thanks

Did you add Shout as a dependency of your main target?
let package = Package(
   ...
   dependencies: [
      .package(url: "https://github.com/jakeheis/Shout", from: "0.2.0")
   ],
   targets: [
      target(name: "MyTarget", dependencies: ["Shout"]),
   ]

Thanks very much! That's been solved, but the main thing still not works.
Error message:
Fatal error: Error raised at top level: Shout.LibSSH2Error.error(-16): file /BuildRoot/Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-9<IP_ADDRESS>/src/swift/stdlib/public/core/ErrorType.swift, line 187
Illegal instruction: 4
My main.swift:
import Shout
let session = try SSH.Session(host: "<IP_ADDRESS>")
try session.authenticate(username: "taqo4", privateKey: "~/dora", passphrase: "demo")
let (status, output) = try session.capture("pwd")
print("status: (status)")
print("output: (output)")
Thanks for the help!


Crash "overflow on subtracting durations"

I got this during a run:
thread 'main' panicked at 'overflow when subtracting durations', library/core/src/time.rs:936:31

dupe of #586


Fix wrong reference breaking for CRAMs

(and re-enable test in CRAMReferenceIntegrationTest once this is done)

Currently we get a NullPointerException if the wrong reference is provided for a cram (but the sequence dictionaries are compatible). Ideally we want to query in advance whether a reference matches the one each cram input expects -- if there's no facility to do this, we may need to add a new method to htsjdk.

Looks like the problem occurs when the cram dictionary is "compatible" with the reference dictionary according to our validation routines, but the reference dictionary does not contain all contigs from the cram dictionary.
We are going to make our dictionary validation stricter to prevent this (https://github.com/broadinstitute/hellbender/issues/802). We should also patch htsjdk to throw a nicer error than NullPointerException in this case -- ie., insert a check after CRAMIterator line 158 that throws a RuntimeException with a nice "contig from cram header not found in reference" error message if refs == null.


Update "Go to mobile" Splash screen: Design and text

https://xd.adobe.com/spec/8f259bcd-550e-4f0c-40bb-bdce2ed36fe5-f914/

For this and future requests please specify what are the changes.
Also if this is etoro only use the etoro label and mention it in the description

@sirpy
Text changes.
It's not only for eToro.

Checked on Dev, QA and eWallet environments
eWallet Env: https://www.screencast.com/t/Y3rmjmXpG

Checked on Dev, QA and eWallet environments
eWallet Env: https://www.screencast.com/t/EU8MGHh45qU


Run a html whitelist scrubber before saving to the database.

We could make this an optional dependency, but it is safer and seems simple enough to be a default. Thoughts?
See: http://samuelks.com/python-scrubber/docs/

Now we can handle multiple python - django combinations.
But this PR sanitizes html on displaying widgets, not on saving.
I think it should be cleaned up when we save instances.


Module build failed: TypeError: Cannot read property 'postcss' of null

Hi, I'm trying to use css modules composition but I keep getting this error.
This is what I have:
/* container.css */ .container {   width: 100%;   max-width: 1200px; }
/* somemodule.css */ .inner {   composes: container from "../../style/container.css"; }
And this is what I get:
✖ ERROR ./src/style/container.css
Module build failed: TypeError: Cannot read property 'postcss' of null
    at Processor.normalize (/Users/brielov/Projects/Grupo Jolivet/website/node_modules/postcss/lib/processor.js:136:13)
    at new Processor (/Users/brielov/Projects/Grupo Jolivet/website/node_modules/postcss/lib/processor.js:51:25)
    at postcss (/Users/brielov/Projects/Grupo Jolivet/website/node_modules/postcss/lib/postcss.js:73:10)
    at Promise.resolve.then.then (/Users/brielov/Projects/Grupo Jolivet./node_modules/postcss-loader/lib?{"sourceMap":false,"plugins":[null]}!./src/components/header/style.css 3:10-288 11:28-306
 @ ./src/components/header/style.css
 @ ./src/components/header/index.js
 @ ./src/components/app.js
 @ ./src/index.js
 @ ./node_modules/preact-cli/lib/lib/entry.js

Hello !
Can you please share your preact.config ?

Hi, I have no preact.config, it's a default preact create default myApp

@brielov hey, in the earlier versions we forgot the sourcemaps for postcss, you were getting this error because of that. Please do update the preact-cli to the latest version (i.e. v2.0.2) and can you please tell me if you are still facing the same issue.

@reznord I just did that, and still no luck :/

Is there a repo somewhere I can take a look at? It will be a lot easier in that case. 😄

I've also come across this error. After some research i found this issue in PostCSS Loader. Apparently, it's missing an ident property. I've added that to the preact-cli/lib/lib/webpack/webpack-base-config.js on the postcss-loader options and it's working.


add auto-fix for no-var-keyword

Note, we just replace with let which can cause errors if the identifier is referenced before the declaration or outside the scope. TypeScript will catch these at type-check time

Thanks for your interest in palantir/tslint, @alexeagle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

My only concern here is that this can change the behavior of user code without triggering a TS error. Take the below (contrived) example:
var a = 0;
{ var a = 1; }
console.log(a);

It'll print "1" before the fix and "0" after the fix.

FYI, the tslint-microsoft-contrib project has this as a formatter.  It kinda works, but I ran into some issue with it.
Description: https://github.com/Microsoft/tslint-microsoft-contrib#supported-formatters
Code: https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/src/fixNoVarKeywordFormatter.ts

@chrismbarr can you elaborate what issue you ran into?
@JKillian we don't require type-checker for this rule, so I suppose the best we can do is a syntactic check whether the declared token appears before the var statement?

@alexeagle Check this issue I had open with them about the formatter: https://github.com/Microsoft/tslint-microsoft-contrib/issues/173
I had 2 problems with it, they fixed one of them as it was just a simple bug in the formatter, but the other one about file paths was not something they were able to resolve.  perhaps they went about doing this in a way that wasn't ideal, but if the file path issue could be resolved that would be fantastic.
in the end though, it wasn't to big of a deal.  i was able to make a complicated glob pattern that worked and I ran the formatter to replace all the var with let in my project in one pass.  That worked great, then I deleted this complex pattern and enabled the TSLint rule to enforce this for any future var keywords.
IMO, running a fix like this should be a one-time thing so get an application up to speed with the TSLint rules.  I've spoken with people on my team about automated code "fixes" like this and in general we don't want them to happen frequently for the possibility of potential bugs, etc.

@alexeagle I'd guess that if you had code like my example above, you actually were expecting let semantics and not var semantics. In which case, TSLint would be fixing a bug.
Still though, a little risky to do that, so if it's easily possible to look for previous tokens of the same name in previous var declarations, let's do that as you suggested.

Risky, but this seems like the kind of thing (hopefully) that gets checked over by a human after it's run, and it would only happen once.  Are the situations where you'd want to keep running this auto-fixer?
Seems like you'd want to run this because the no-var-keyword rule produces a lot of violations and this would be a quick & easy way to fix them all at once.  Do that, and then afterwards just enable that rule to catch any new/future violations.

Gonna merge this -- we categorize no-var-keyword as a Functionality related rule, and autofixers for these kinds of rules will likely require manual review.