Roll engine e7fd442410f4..953ac71749ee (18 commits)

git@github.com:flutter/engine.git/compare/e7fd442410f4...953ac71749ee
git log e7fd442410f4..953ac71749ee --no-merges --oneline
2019-09-24<EMAIL_ADDRESS>Roll src/third_party/dart acac9ab11b..d53d355c6c (12 commits)
2019-09-24<EMAIL_ADDRESS>Roll src/third_party/skia b4b1005d485f..c096654fa7c6 (1 commits) (flutter/engine#12415)
2019-09-24<EMAIL_ADDRESS>Roll src/third_party/skia b3542d95da65..b4b1005d485f (6 commits) (flutter/engine#12414)
2019-09-24<EMAIL_ADDRESS>Write MINIMAL_SDK to exception message (flutter/engine#11345)
2019-09-23<EMAIL_ADDRESS>Track "mouse leave" event (flutter/engine#12363)
2019-09-23<EMAIL_ADDRESS>Roll src/third_party/dart 77ff89b223..acac9ab11b (6 commits)
2019-09-23<EMAIL_ADDRESS>Don't send pointer events when the framework isn't ready yet (flutter/engine#12403)
2019-09-23<EMAIL_ADDRESS>Update test to verify that secondary isolate gets shutdown before root isolate exits. (flutter/engine#12342)
2019-09-23<EMAIL_ADDRESS>Roll src/third_party/skia 57ef68077574..b3542d95da65 (12 commits) (flutter/engine#12409)
2019-09-23<EMAIL_ADDRESS>Update --dart-vm-flags whitelist to include --write-service-info and --sample-buffer-duration (flutter/engine#12395)
2019-09-23<EMAIL_ADDRESS>Add system font change listener for windows (flutter/engine#12276)
2019-09-23<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from xPX7p... to kgFwg... (flutter/engine#12405)
2019-09-23<EMAIL_ADDRESS>Check for index bounds in RTL handling for trailing whitespace runs. (flutter/engine#12336)
2019-09-23<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from F-g18... to NY2A5... (flutter/engine#12407)
2019-09-23<EMAIL_ADDRESS>Roll src/third_party/dart f546362691..77ff89b223 (6 commits)
2019-09-23<EMAIL_ADDRESS>Updating text field location in IOS as a pre-work for spellcheck (flutter/engine#12192)
2019-09-23<EMAIL_ADDRESS>Roll buildroot and remove toolchain prefix. (flutter/engine#12324)
2019-09-23<EMAIL_ADDRESS>Roll src/third_party/dart 94dd49cdb6..f546362691 (1 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


Server may not be exiting correctly after receiving exit notification

This issue describes a symptom in which a language server does not appear to be exiting when it receives the exit protocol notification.
From this comment:

In theory, Server::serve() should already gracefully shut down when it receives an exit message, regardless of the state of stdin, but if it doesn't, then there must be a bug in the logic somewhere.

Creating this issue as requested. :-)

That certainly doesn't sound good! Unfortunately, I don't think there's currently a user-facing way to directly react to the exit notification yet, looking at the macro-generated code for the exit notification for reference (see the lib.rs module in the tower-lsp-macros crate).
With that said, I'll be sure to prioritize this for investigation tonight. Would you or someone on the Deno team happen to have a minimal reproducible example in mind that can be debugged or treated against? I will later pull a form of it into the tower-lsp repo and turn it into a unit or integration test for the sake of coverage.
Thanks for the patience, folks! Please let me know and I'll start debugging later tonight, in the hopes of pushing out an emergency release soon after.

#[tokio::main]
async fn main() {
  use tower_lsp::LanguageServer;
  use tower_lsp::LspService;
  use tower_lsp::Server;
  use tower_lsp::async_trait;
  use tower_lsp::jsonrpc::Result;
  use tower_lsp::lsp_types::InitializeParams;
  use tower_lsp::lsp_types::InitializeResult;

  struct Backend;
  #[async_trait]
  impl LanguageServer for Backend {
    async fn initialize(&self, _: InitializeParams) -> Result<InitializeResult> {
        Ok(InitializeResult::default())
    }

    async fn shutdown(&self) -> Result<()> {
        Ok(())
    }
  }

  let stdin = tokio::io::stdin();
  let stdout = tokio::io::stdout();
  let (service, socket) = LspService::new(|_| Backend);
  Server::new(stdin, stdout, socket).serve(service).await;
}

And then run on the CLI:
(printf 'Content-Length: 33\r\n\r\n{"jsonrpc":"2.0","method":"exit"}' && cat) | cargo run

The program will hang until you press Ctrl+D to close stdin.
Any similar hanging stream would do for an automated test.
By the way, I think the main doc comment example (as rendered -- without the hidden lines) at https://github.com/ebkalderon/tower-lsp/blob/v0.20.0/src/lib.rs#L57-L73 will exhibit this.

@ebkalderon, did you ever figure this out?


Standardize configuration to work anywhere!

We have a problem!
Currently, relying on configurations internally cause not only issues with testing environments (where the app structure is like Orchestra's or something), but also we also face abstraction issue where we do validations right after every call for config() to ensure working with a sane value!
The solution I'm working on is to implement configuration defaults and validations on the package service provider (any other package's really, since we're a helper package, yet including ourselves too), and then globalizing a validated_config() helper function to do exactly that.
What do you think? @GoodM4ven

We still have to input them twice, right? Maybe even more?
I'm not sure how it would look, but it seems to solve a current problem, like you mentioned.
-Give it a try?! ¯_(ツ)_/¯

I mean commit Arabicable#7 wouldn't have been a breaking v2 if config was handled, yeah?

Done with!


[DDW-1213] Optimize E2E tests

This PR optimizes E2E tests, standardizing some methods and removing unnecessary code.

Testing Checklist

Slack QA thread

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@DominikGuzei @tomothespian please review this one today 🙏

@daniloprates I still get this failure :(

@daniloprates I got same failure as Nikola :(

@tomothespian can you please check this? We need to fix it and merge this PR ASAP 🙏

@daniloprates I still get this failure :(

@nikolaglumac @tomothespian fixed. The issue was happening when running this scenario for the second time. E.G. if it failed due to timeout (a cardano-sl issue), on the second run the balance wallet with funds wouldn't have funds, anymore. Therefore now, in case the imported balance wallet has no funds, it will throw an error, asking to reset the Daedalus directory.

@daniloprates I'm still getting random test failures. Is that also case on your side?

@daniloprates I'm still getting random test failures. Is that also case on your side?

Yes. Mostly timeout ones. But there's one that breaks cardano node. Investigating... ⏳

@daniloprates yeah same on mi side, almost 90% failed because timeout.
Thanks Danilo ❤

@daniloprates I still get the same error like before :(

@daniloprates I still get the same error like before :(

@nikolaglumac yes, I didn't add any new fix for that yet. I'm off this morning but will make sure to discover some magic for this and the other issues by the EOD.

I have added a fix for the aforementioned issue. The this.wallets array was not updating the wallet amount correctly. Not it gets the wallet amount directly from the client, in a string format, since webdriver doesn't import BigNumber properly.

@daniloprates it seems there are new problems now :(

@nikolaglumac random timeout issues still happen and there's nothing we can do ATM

@nikolaglumac we've run there tests numerous times and have always faced at least one timeout issue, always different from the previous.

@daniloprates OK. Let's discuss this when you start today 🙏

@daniloprates I think that I found an issue.
Soo problem is with event emitter which breaks IPC and caused Cardano Node crashes. Event emitter comes from events.js and that is from NodeJS. I tried to update NodeJs version and ran tests 8 times. I didn't get Cardano Node crash, unexpected timeouts... Tests pass multiple times and just 2 times failed but the error is reasonable (Transfer funds scenario - transfer took a little bit longer than default timeout and another Scenario: Balance wallet "Create a Rewards wallet" notification is displayed if the wallet is NOT empty and I don't have a Rewards wallet in the UI which we need to check).
So my suggestion is to wait for https://github.com/input-output-hk/daedalus/pull/1883 to be merged . Maybe also to wait https://github.com/input-output-hk/daedalus/pull/1887 so we can update spectron inside this optimization PR. What you think?
cc @nikolaglumac

@daniloprates I think that I found an issue.

@tomothespian sounds good!


fix: added cursor pointer for checkbox and pre-filled list

What does it do?
Fixed the Media Library's missing cursor pointers issue on the filters
Why is it needed?
To fix issue https://github.com/strapi/design-system/issues/1791: Media Library missing cursor pointers on the filters
How to test it?

Open the Media Library
Hover over the filters, it should show the cursor pointers.

Related issue(s)/PR(s)
https://github.com/strapi/design-system/issues/1791

Hi @remidej , As discussed in this PR 21460, here’s the new PR for the issue. Please let me know if you have any feedback on this change.

Sorry I meant to ping @lucasboilly for a final check

Hey @Sam-Phillemon9493, it looks great! Thanks for your contribution!

I forgot this just needs a changeset (something we use for auto geenrated releases and changelogs), could you add one?
yarn release:add and mark it as a patch

Hi @remidej , I've added a changeset. Please let me know if anything else is needed.


Allow setting $OPTIONS via an EnvironmentFile for systemd

fixes #14492

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:Krijger/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Hi @Krijger,
You'll need to sign off your commit, see CONTRIBUTING.md.
Please not too that this is probably a duplicate for already closed PR, like https://github.com/docker/docker/pull/14319, see comments :wink:.

duplicate of #14319

Thanks @vdemeester . I did look, but did not find :)  Closed issue and PR as duplicates. The PR was exactly the same!


Generate default values in Kotlin

Currently, when you specify a default value for a column, it does not show up in the generated Kotlin code, e.g.:
CREATE TABLE entity (
    foo TEXT DEFAULT "bar"
);

produces this class:
interface Entity {
    val foo: String?

    data class Impl(override val foo: String?) : Entity
}

It would be cool if default values would be reflected in Kotlin as well, like so:
data class Impl(override val foo: String? = "bar")

If you want to take full advantage of default parameters, then ordering would also matter. I'm not sure if reordering the parameters so that the ones with default values are at the bottom is desired, but even if we don't order them I think it adds value to represent default values in Kotlin as well.

This isn't possible. The generated type and default value will not always match.
How does
date INTEGER AS java.time.Instant DEFAULT 0

work?

Good point, didn't think about that case. However what do you think about adding it in cases where it does work, don't you think it would provide some value there?
In the case where you are using a custom type, I guess you could convert the SQL default value with the ColumnAdapter, but then you would have to expose them somewhere so I don't like that solution either.

I don't really like the asymmetry of it. I think I'd prefer not having the feature than having it with a bunch of limitations.
Beyond that, I don't think it's generally useful. The only place you should be manually creating instances is for tests. The DB should be the canonical source of instances in production.

I guess you're right, I was thinking this was a simple QoL improvement, but I did not think about it's limitations.


Tensor.masked_fill applying mask incorrectly?

Good evening,
I'm creating a tril mask (lower triangular mask) for my self attention model and it seems to create the tril correctly. However, when trying to apply the mask fill over my tensor, it applies the transposed matrix that I would expect. I'm wondering if this is by design, if I am using the masked_fill function incorrectly, or if this is a bug. Here are some pictures of the example:

My weights tensor during the q * transpose of k tensor:

My mask tensor made from mask = torch.tril(torch.ones(blockSize, blockSize, device: device)).@bool(); This appear correctly as I would expect the mask to be viewed.

Applying the mask to the weights tensor does logic I would not expect. weights = weights.masked_fill(mask, float.NegativeInfinity);

I would expect that the upper triangular portion of the tensor display would contain the -infinity values and that the lower triangular portion would contain the self attention weights. If this is a bug in my code (which is probably is), then I apologize ahead of time. But I think that there is something more here that could potentially be a bug in the way the mask is applied versus the way it is applied in PyTorch. Please let me know if there are any questions I can help with.
`public AttentionHead(int n_embd, int headSize, double dropoutVal, int blockSize, Device device, int id) : base ($"AttentionHead{id}")
{
key = Linear(n_embd, headSize, false, device);
query = Linear(n_embd, headSize, false, device);
value = Linear(n_embd, headSize, false, device);
//mask will modify the sublayer to prevent positions from attending to subsequent positions (we only want the context of previous positions)
// combined with output embeddings offset by one position ensures the predictions for position i can only depend on known outputs at positions less than i
mask = torch.tril(torch.ones(blockSize, blockSize, device: device)).@bool();
this.register_buffer("tril", mask);
Debug.WriteLine($"{mask.str}");
dropout = Dropout(dropoutVal);

RegisterComponents();

}
public override Tensor forward(Tensor x)
{
var k = key.forward(x);
Debug.WriteLine(k.str());
var q = query.forward(x);
Debug.WriteLine(q.str());
// perform the dot product of Q and transposed K (MAYBE LOOK AT THIS USING WRONG DIMS FOR TRANSPOSE 1 based dims as opposed to 0 based?), scaling by sqrt(dksize) counteracts the magnitude of dot products on large values of dk
var weights = torch.matmul(q, k.transpose(-2, -1)) / Math.Sqrt(k.size(-1));
Debug.WriteLine(weights.str());
Debug.WriteLine(mask.str());
// look into the mask potentially being null (setting to -inf turns off all illegal connections to prevent leftward information flow and preserve auto-regressive properties)
weights = weights.masked_fill(mask, float.NegativeInfinity);
Debug.WriteLine(weights.str());

//coverts output to predicted next-token probabilities (weights)
weights = torch.nn.functional.softmax(weights, dim: -1);
Debug.WriteLine(weights.str());
weights = dropout.forward(weights);
Debug.WriteLine(weights.str());

var v = value.forward(x);
Debug.WriteLine(v.str());
var output = torch.matmul(weights, v);
Debug.WriteLine(output.str());
return output;

}
private void RegisterComponents()
{
this.register_module("key", key);
this.register_module("query", query);
this.register_module("value", value);
this.register_module("dropout", dropout);
}`

Okay hang on, I realized this is a bug in my code where I need to define what it means grab the values in the TxT matrix that are == 0.


Document ExecuteQueryV2

There is a (new?) method called ExecuteQueryV2 but no documentation on how to use it correctly and when it might beneficial to use it over the ExecuteQuery one. The return interface is also different so one cannot simply drop it in. I would assume it allows to stream back query results rather than loading everything in one go which would imply it's more useful when larger result sets are expected but one question is whether it can be used in general instead of the v1 one or are there any caveats that one must consider?

Noted.
In the meantime you can use this sample
https://github.com/Azure/azure-kusto-samples-dotnet/tree/master/client/HelloKustoV2
The API description is found here,
https://learn.microsoft.com/en-us/azure/data-explorer/kusto/api/rest/response2

Hi, could you please improve the API documentation? For example add a http request with http headers and body. I would like to use a httpclient to call the api directly.


Flags doesnt shows on React Native Web (Windows)

Unfortunately, flag emojis are not displayed on windows.
How can i fix it?
Print below:

Hi, this library was not very well tested on web. Maybe some issues with styles?

Hey @GeorgeHop
I did a test usyng other fontFamily and work...its name is TwemojiMozilla!
For now, this worked for me...


Engine -> Framework roll blocked due to LUCI results not making their way to github

https://github.com/flutter/flutter/pull/111026
has three jobs pending, but clicking through to LUCI shows that they finished 8 hours ago.
I am going to land the roll manually, but filing this in case follow-up investigation is needed.
cc @GaryQian

It looks like these two subsequent PRs got autosubmitted correctly:

https://github.com/flutter/flutter/pull/111044
https://github.com/flutter/flutter/pull/111046

GitHub's services have been intermittent today and I'm trying to access some logs to confirm if that's the culprit here.

I found nothing conclusive, but this seems to be a transient issue.


[WIP] Add new spinners

DEMO
install

update

status

Features

Add new spinners and parallel processing
Add many state control variables
Add --rollback option
Add --log option

🚧 Work in progress 🚧

Cool.

Doesn't work on Mac OS systems with gnu-utility (from OMZ/Prezto).
~/.zplug new-spinners ● zplug update
[zplug] Start to update 7 plugins in parallel

 /usr/local/bin/gprintf: missing hexadecimal number in escape
 /usr/local/bin/gprintf: missing hexadecimal number in escape
 /usr/local/bin/gprintf: missing hexadecimal number in escape
 /usr/local/bin/gprintf: missing hexadecimal number in escape
 /usr/local/bin/gprintf: missing hexadecimal number in escape
 /usr/local/bin/gprintf: missing hexadecimal number in escaperch
 /usr/local/bin/gprintf: missing hexadecimal number in escape

[zplug] Elapsed time: 2.4975 sec.
 ==> Updating finished successfully!

This is what gnu-utility does on Mac OS:
~ ● which printf
printf () {
	'/usr/local/bin/gprintf' "$@"
}

Removing printf from gnu-utility umbrella fixes the issue. Do you think you can properly detect what implementation of printf is used on the system?
Good work with new spinners - looks amazing!

Thanks @stevenjlho for reporting. I have probably understand the cause so I'll fix that.

@stevenjlho Thanks for reporting. Should be fixed.


Redirects for dev mode short links

Adds a https://lit.dev/msg/<code> redirect for all warnings logged by Lit's dev mode.
Half of https://github.com/lit/lit/issues/2078. Other half is at https://github.com/lit/lit/pull/2119.

Looks good to me. I hadn't though of the redirect testing that @AndrewJakubowicz mentioned, but I think we'll (at a minimum) need to add comments to each of the docs sections where these links land, so we don't accidentally break the intended association between the current URL and the answer we're looking for (for example, when refactoring one section into two). I opened #467 for that, because it doesn't seem like it needs to be part of this PR.

Good idea. It would be nice if we could use the link checker we already have for this, but it doesn't support checking for anchors (see stevenvachon/broken-link-checker#108 -- understandable since it would require DOM parsing). I've written a little custom script to do this, will send it in a followup PR.

Done in https://github.com/lit/lit.dev/pull/468


Boost mingw

Current tests (header-only, system, filesystem) hangs for several hours.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5250141-boost-mingw?utm_campaign=plugin&utm_content=tracker%2F1032790&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1032790&utm_medium=issues&utm_source=github).

Not a Hunter issue, closing.


[Operation] Swagger documentation

Summary
Swagger documentation should be provided for Operation API endpoints
Details
N/A
Acceptance criteria

[ ] Operation API module has its own Swagger documentation
[ ] Swagger version is updated to the latest one
[ ] Mandatory parameters are documented

Additional context

there are some swagger-related filed that can be used as a guideline (ex. account-service-rest-api.yaml)
swagger documentation should be configured using Java annotations

Done and merged to swagger branch


go: binaries built with "buildGoModule" return an empty string for "runtime.GOROOT()"

Describe the bug
Binaries built using buildGoModule return an empty string for runtime.GOROOT(). This will change behavior and most likely break all apps relying on GOROOT.
I noticed that swag init (see go-swag) was producing inconsistent results based on whether it was installed through nix-shell --pure -p go-swag, installed using go install github.com/swaggo/swag/cmd/swag@latest or build manually from the GitHub repo.
go-swag relies on runtime.GOROOT() to ignore files from the Go stdlib: https://github.com/swaggo/swag/blob/e67c96576bc94cbb0acc8026885ed53e0b08ad04/packages.go#L96
This prefix-check always returns true due to runtime.GOROOT() == "", effectively ignoring all files.
As it is unknown if this breaks other apps (due to them depending directly on GOROOT, or one of their dependencies), this should be fixed in buildGoModule and not only for the go-swag nixpkg.
Steps To Reproduce
Minimal reproducible here: https://git.helsinki.tools/leon.klingele/nix-buildgomodule-bug
Build it using buildGoModule. Running it will output something similar to
[..]
runtime.GOROOT() == "" true

Expected behavior
I don't have a nix system at hand so I can't tell the exact output. But that one line which says true in the output above should say false instead.
Notify maintainers
Sorry for the spam.

Let's pull in golang team:
map (x<EMAIL_ADDRESS>lib.teams.golang.members expands to: @c00w @kalbasit @Mic92 @zowoq @qbit

I believe this is a result of the program being compiled with the -trimpath argument. This can be disabled by passing allowGoReference to buildGoModule. Having allowGoReference = false is desirable so that Go programs' closures don't include the Go compiler by default.

It uses the GOROOT environment variable, if set at process start, or else the root used during the Go build.

Yep either drop -trimpath or provide a GOROOT env var either when running the command or use a wrapper.

Although in this case I think this a bug that go-swag needs to resolve. It should check if the GOROOT function actually gives a value & not just ignore everything. Then it wouldn't matter if we're using -trimpath

Any news on this?
The same issue just struck us again with go-licenses which doesn't work at all due to the use of runtime.GOROOT() here: https://github.com/google/go-licenses/blob/150520fc5b3aaf07a90ff6cc50f7227abda448f8/licenses/library.go#L303

What resolution do you expect?
trimpath is default and allowGoReference removes trimpath for cases where you need GOROOT or other stuff trimpath removes.
Does that still not resolve the issue for go-licenses?


[Event Request] Page 7018 Purchase Price List - GetDefaultSourceType needs a Publisher for own extensions

Hello Microsoft Team,
we are currently developing our own extension based on the new Pricing Feature.
We extended the Enums of this module for our own usage. if we try to open the page 7018 "Purchase Price List" with our new added context we get an "error".

The Code in the Background changes the context back to "Source Group" = Vendor even if we enter the Page 7018 from our new List-Page with our own Source Group.

Reason for this behaviour is simple:
When the code gets the Default Source Type with the procedure "GetDefaultSourceType" in page 7018 it does not know what to do with the new Value in the Enum-paramter SourceGroup. The exit Value for this procedure will be the default value of the Enum "Price Source Type" which equals "(All)". This small error leads to another error in the next procedure call. There it resets the Source Type and also access the wrong interface implementation.

To solve this wrong behaviour we simply need a Publisher at the end of the procedure:
local procedure GetDefaultSourceType(SourceGroup: Enum "Price Source Group") DefaultSourceType: Enum "Price Source Type";
begin
    case SourceGroup of
        SourceGroup::Vendor:
            DefaultSourceType := Rec."Source Type"::"All Vendors";
        SourceGroup::Job:
            DefaultSourceType := Rec."Source Type"::"All Jobs";
    end else
            OnGetDefaultSourceOnCaseElse(SourceGroup, DefaultSourceType);
end;

[IntegrationEvent(false, false)]
local procedure OnGetDefaultSourceOnCaseElse(SourceGroup: Enum "Price Source Group"; var DefaultSourceType: Enum "Price Source Type")
begin
end;

Another Solution would be to create a new procedure in the interface so that the Default Source Type could be received from own implementations as well.
Kind Regards
Jonas

Isn't this issue a duplicate of my issue, that I created some days ago?
https://github.com/microsoft/ALAppExtensions/issues/23216

Isn't this issue a duplicate of my issue, that I created some days ago? #23216

yes it is. Only Placement is different. I'll close this issue and let Microsoft decide how to implement it.


radosgw_user: support caps on user

Supporting adding/removing caps on the user.

jenkins test centos-non_container-switch_to_containers

@guits Tests has been added.


GA Expert

Our custom GPT is trained on all Google Analytics documentation to provide expert answers to your Google Analytics questions.

what's your question?


Initial commit of Yahoo Fantasy Football app

This PR is for a new app for Yahoo Fantasy Football. The app has the option to display the score from the current fantasy matchup or scroll through the standings. This app depends on OAuth2 authentication with the Yahoo API. If you create a new Yahoo App to use then simply update the YAHOO_CLIENT_ID and YAHOO_CLIENT_SECRET values. I believe I've set TIDBYT_OAUTH_CALLBACK_URL to the correct URL but please correct if needed.
I have requested access to the beta and would love to be able to beta test this before it goes live due to the limited testing I could perform relating to OAuth and Secrets.
Thanks! Really excited to get this one going and then I'm planning on a similar one for Yahoo Fantasy Baseball.

Just some more info if you create a new OAuth app...You can create one here: https://developer.yahoo.com/apps/.
Client Type = Confidential Client
API Permissions = Fantasy Sports (Read)

Sorry for the long review time. This should be avaialble for beta users in a minute or so. I'll set up our own set of credentials as well before we launch it. Hit me up on discord when you've tested this out and we'll take it from there.


Operations Stack Fails Because '*' Invalid Principal Type

Describe the bug
Pipeline fails on Operatons stack for applying S3 bucket policy to aws-accelerator-cur-XXXXXXXXXX-us-east-1 with error 'Invalid principal in policy".
To Reproduce
Deploy Accelerator pipeline on v1.4.3 in GovCloud
Expected behavior
Operations stack fails for ReportBucketPolicy because '*' cannot be used as principal in S3 bucket policy.
Please complete the following information about the solution:

[ ] Version: 1.4.3

[ ] Region: us-gov-west-1

[ ] Was the solution modified from the version published on this repository? No

[ ] If the answer to the previous question was yes, are the changes available on GitHub? N/A

[ ] Have you checked your service quotas for the sevices this solution uses? N/A

[ ] Were there any errors in the CloudWatch Logs? N/A

Screenshots
Additional context
Manually attempting to apply the S3 bucket policy fails also because '*' is not acceptable for principal in policy.

Hello @hypori-github,
Thanks for bringing this to our attentions.
Cost and Usage reports are only available in standard partitions so its not possible to reference the service principal.
We will track this issue internally and release a fix.

A fix for this issue has been included in our v1.5.0 release. I will be closing this issue as resolved. Thanks for your support of Landing Zone Accelerator!


Ignore interfaces in eureka service

Is this a bug: No, just a question, possibly a new feature suggestion
Problem:
is there a way to ignore or exclude clients in my eureka server based on their ip address? or something like this?
currently we have 100+ services up and running connecting to different eureka servers,
and we would like to avoid registering client services if they are running locally,
since we have a lot of services with a lot of people working with them removing their @EnableEurekaClient annotation every time we run it locally can be annoying, or any similar workaround.
So I'm looking for a way to prevent services from getting registered in the eureka server by modifying my eureka server, not my clients,
Thanks.

If the config can be flexed locally, the eureka.registration.enabled property can be used to skip client registration.


Intellisense issues with commit on space and other punctuation

VS now commits completion lists on more than tab and enter, including space and a variety of punctuation characters (semicolon, parens, brackets, etc). There are places where we offer completion lists that we shouldn't, or poor completion lists, which were previously visual distractions but now are significant annoyances in the actual typing experience, requiring constantly dismissing completion lists via Esc to type what you intended.
Fat arrow functions

Typing a space after the fat arrow argument commits a suggestion that is never correct, and then happens frequently in the body as well.
Type argument declarations

Tracked here https://github.com/Microsoft/TypeScript/issues/1428
Destrucuring Assignments

Not supported in the editor yet but will need to work like var declaration completion lists.
There are likely other cases as well but these ones stand out immediately. This also ties into #315 which is asking for a toggle on this behavior. Depending on the fix we use for this behavior we may also have some significant test costs associated with these fixes.

Sometimes an Esc is better than an Enter every single time. :) You are on the right track.


open-stage-control: fix npmDepsHash

Description of changes
EDIT: I'm marking this as WIP until an apparently hash instability problem is solved
It looks like the hash that 814a0bc changed npmDepsHash to wasn't correct for the final version of the buildNpmPackage fixes in #200470
This PR updates this hash to what now seems to be the stable hash
The build is currently failing in Hydra for 22.11 due to hash mismatch so this should be a part of ZHF
ZHF: #199919
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I've worked with winter on rooting out non-reproducibility in the hash generation for hosted git npm deps
I'm closing this PR in favor of one to fix that problem


Yak Compiler Script & Action

Description
This should generate and upload Mac and Win yak packages
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[x] Ran by the Github Actions

@cwensley can you try this on mac? The package works for me on Windows 😊😊😊


Bug: Specifiying patch version of PHP is ignored

Describe the bug
Hi, Thank you for making great github action to install PHP easily.
I found that installing the current latest PHP version 8.3.13 with this action fails and installs 8.3.12 instead.
After debugging for a hour and then found that this action seems drop the patch version from version string when parsing the php-version.
Here: https://github.com/shivammathur/setup-php/blob/ce2f681d2257b1c64228aa701fefa22db84edf4b/src/utils.ts#L69
Could you fix/add feature to make it possible installing precise version down to patch version?
Thank you!
Version

[X] v2
[ ] v1

Runners
GitHub Hosted
Operating systems
ubuntu-latest
PHP versions
8.3.13
To Reproduce
Run the job below on action:
      - name: Setup PHP with composer
        uses: shivammathur/setup-php@v2
        with:
          php-version: 8.3.13
          tools: composer
        env:
          GITHUB_TOKEN: ${{ secrets.COMPOSER_AUTH }}

Expected behavior
installs 8.3.13 instead of 8.3.12
Screenshots/Logs
Run shivammathur/setup-php@v2
  with:
    php-version: 8.3.13
    tools: composer
    ini-file: production
  env:
    GITHUB_TOKEN: ***
/usr/bin/bash /home/runner/work/_actions/shivammathur/setup-php/v2/src/scripts/run.sh

==> Setup PHP
✓ PHP Installed PHP 8.3.12

==> Setup Tools
✓ composer Added composer 2.8.2

==> Sponsor setup-php
✓ setup-php https://setup-php.com/sponsor

Additional context
No response
Are you willing to submit a PR?
Yes

It seems this issue is duplicate of:
https://github.com/shivammathur/setup-php/issues/687
https://github.com/shivammathur/setup-php/issues/618
https://github.com/shivammathur/setup-php/issues/704
I totally agree with https://github.com/shivammathur/setup-php/issues/704#issuecomment-1437394352.

@tomocrafter
It should install 8.3.13 now, I have updated the builds cache we have.
Yes, when we do a major version bump, we can change that to throw an error, but changing it currently would break a lot of workflows.

@shivammathur I appreciate for the updating and consider to make it throws an error.
Thank you.


Alternative for NVIDIA RTX 3070

CARLA version: 0.9.15
Platform/OS: Windows
Problem you have experienced: GPU is not supported
What you expected to happen:
Steps to reproduce:
Other information (documentation you consulted, workarounds you tried):
Hi,
I would like to get help if I could use ADM RX6700XT as an alternative NVIDIA RTX 3070.
I need to ensure that before buying ADM RX6700XT
Thank you.

solved


Fix rmrf and drop version to 2.9.0

Current published version is 2.8.0. Probably not going to major version at this time.

Can we add more details to this? What are we fixing? What's the new implementation? How is it different? Good to have for historical context.

Are there tests that cover this? Do we need more?

Sure, for context we're trying to solve the issue here. To summarize, nodes unlinkSync doesn't always actually delete a file, it just decrements its ref-count (which eventually has the effect of deleting it). This means that if the file is open elsewhere (often with antivirus software its being scanned) it doesn't actually get immediately deleted. This tries to address that.
I think existing coverage does a pretty good job with this, not really sure if there's a good way to test that exact behavior. Since we're not using unlinkSync, that edge case should just be avoided entirely anyways.

Looks good, let's have Eric review before merging.

/azp run

I'm intentionally not updating the version in package.json. We should probably release all the changes going in and need to follow up in the release notes when we do.


Switch __new__ to a macro

Same idea as https://github.com/FluxML/Zygote.jl/pull/1220. Using a generated function here should just introduce unnecessary compilation overhead when a macro can do the same job with significantly less overhead.

Sound like a good improvement, but tests say @splatnew not defined, and I don't remember such a macro too. Is it new in Julia 1.9?

Whoops, sorry I named the macro __splatnew__ but was calling it as @splatnew, that should fix it.

Weird that it's still erroring. Maybe it's because I defined the macro after the function. That should fix it I think.

It works now. Thanks for this neat solution!


Vercel Adapter failing to bundle sveltekit

Describe the bug
A Cloud invocation on vercel indicates that sveltekit is not bundled in the application.
Logs

2021-04-30T04:23:13.209Z	898311b1-cdc5-4d50-9c95-bc29b2c59c4f	ERROR	Unhandled Promise Rejection 	{"errorType":"Runtime.UnhandledPromiseRejection","errorMessage":"Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/kit' imported from /var/task/server/app.mjs","reason":{"errorType":"Error","errorMessage":"Cannot find package '@sveltejs/kit' imported from /var/task/server/app.mjs","code":"ERR_MODULE_NOT_FOUND","stack":["Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/kit' imported from /var/task/server/app.mjs","    at packageResolve (internal/modules/esm/resolve.js:655:9)","    at moduleResolve (internal/modules/esm/resolve.js:696:18)","    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:810:11)","    at Loader.resolve (internal/modules/esm/loader.js:86:40)","    at Loader.getModuleJob (internal/modules/esm/loader.js:230:28)","    at ModuleWrap. (internal/modules/esm/module_job.js:56:40)","    at link (internal/modules/esm/module_job.js:55:36)"]},"promise":{},"stack":["Runtime.UnhandledPromiseRejection: Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/kit' imported from /var/task/server/app.mjs","    at process. (/var/runtime/index.js:35:15)","    at process.emit (events.js:327:22)","    at processPromiseRejections (internal/process/promises.js:245:33)","    at processTicksAndRejections (internal/process/task_queues.js:94:32)"]}
Unknown application error occurred

To Reproduce
Not entirely sure but it should be reproducible if you clone https://github.com/DrewRidley/PantryBook and deploy to vercel.
Expected behavior
Sveltekit compiles without errors (which it does), but also bundles svelte with the distribution deployed to vercel (which it does not according to the exception)
Information about your SvelteKit Installation:
Not sure this information is pertinent to the error since all vercel deployments are the same in terms of hardware?
Severity
In this case it blocks the usage of sveltekit entirely, although I suspect if I created a fresh project with identical components it would work.

I re-scaffolded the project and copied over all of my components and it no longer reproduces. Works fine now, not really sure what caused it. You are welcome to try to reproduce with older commits of the repository, but i'll close this issue since it was resolved so easily.


Fix/306 TCMSFieldDateTime with seconds

Q
A

Branch
master

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Fixed issues
chameleon-system/chameleon-system#306

License
MIT

First, the TCMSFieldDateTime field with the datetimepicker() widget did mysterious things because the date field in the database had seconds and datetimepicker() by default doesn't represent seconds. After I found the country-specific date and time setting WITH seconds (format: "L LTS") for the datetimepicker() widget, I had an ugly styling error:

Unfortunately this could not be investigated, because it immediately collapsed again when leaving the field. Even with devTools this could not be prevented.
After some searching I found the options keepOpen: true and debug: true for the datetimepicker(). This allowed me to find and overwrite the wrong css setting.

Thanks @ckleis


Added www.codevolve.com to real-world use cases

We use Code Mirror for our code editor at Codevolve.

Great! Merged as 5dfab9c9


Error with new hair color pattern node

PRMan: X00003 {WARNING} Plugin warning: primvar lookup failed: is this the correct primvar name ? [ Object: Suzanne Shader: Hair.PxrHairColor]

Did you use "index"?
On Wed, May 17, 2017 at 7:06 PM Jon D<EMAIL_ADDRESS>wrote:

PRMan: X00003 {WARNING} Plugin warning: primvar lookup failed: is this the
correct primvar name ? [ Object: Suzanne Shader: Hair.PxrHairColor]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/RenderManForBlender/issues/499, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABzffLhjUepeWOG9H_3YcRISqDF81l4Fks5r66elgaJpZM4NepUh
.

--
<EMAIL_ADDRESS>508-274-8700

No comment.......
ID10T issue

It might make sense to hardcore that to default as index
On Wed, May 17, 2017 at 8:04 PM Jon D<EMAIL_ADDRESS>wrote:

Closed #499 https://github.com/bsavery/RenderManForBlender/issues/499.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/RenderManForBlender/issues/499#event-1087074690,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffDQLfik_0pfU63JcOnO1a9gBYMcMks5r67U6gaJpZM4NepUh
.

--
<EMAIL_ADDRESS>508-274-8700


Plotting API defaults should be over-ridden with user defined kwargs (intake)

From https://github.com/intake/intake/issues/171

Seems like a straightforward fix. We just need to check if the explicit x/y are passed in they are correctly merged with the definition in the catalogue.

This has been fixed for a while. Can't find the exact commit now.

This has been fixed for a while. Can't find the exact commit now.


Rendering Katex in figure shortcodes

Hi,
Is it possible to render math in {{ <figure> }} elements? Or is this a limitation of Hugo?
{{< figure src="cmos_inv.svg" caption="<span class=\"figure-number\">Figure 1: </span>CMOS Inverter schematic. The $C_L$ capacitor is charged or discharged when \\(V\_{in}\\) switches its logical value." width="1000" >}}

output:

Hi,
As far as I know, that's not possible. The figure shortcode does not allow to nest any other shortcode and is designed to load image files only.


feat: remove isChecked from the document shape

Description
Major changes
As the title says, this PR removes the isChecked boolean from the expected shape of the Firestore document. The expectation here is that Collabies will understand that they need to read the dateLastPurchased and check if it's been 24 hours in order to determine whether the item is checked in the UI.
Documentation changes
Edited some comments to (hopefully) provide better clarity to Collabies.

I don't see where this actually removes isChecked … am I just missing it?

Formerly lines 64 and 65 in firebase.js!


Ability to copy chord

Hello!
I think that it would be useful to be able copy to the clipboard the current chord (or the last one, in case that no chord is currently playing) in the "Chord Display" view if we right click it, as a shortcut.
Also, it could be extended to the "Chord Dictionary" view and to the individual notes that were forming that chord.
For example, for a D, F# and B chord, we could be able to copy or "D6" or "Bm/D" depending what chord was right clicked and "D F# B" if, for example, we right click on the keyboard or in one of the notes.
I have attached a screenshot of the "zones" that I'm referring to.

Thank you @dertasiu for your issue.
That's an idea i put away because i thought it would be a bit far-fetched to have such non explanatory features, but i'll consider it.
I can easily add a contextual menu with many actions on a right click, so that's probably the way i will add this.
What would be your need for this ?
Is it to be able to search the chord elsewhere ? or for taking notes on a separate application ?
I had a few ideas about quick actions on chords like:

custom link to a website (such as https://www.scales-chords.com/ that i regularly use too)
Copy chord with unicode characters (e.g. "C-Δ11")
Copy chord with ascii characters (e.g. "Cminmaj11")
Add chord to a list / quiz ?
Disable chord

I currently paused MIDI Jar development for personal reasons but i'll try my best to address pending issues this month.

What would be your need for this ?

When I am composing a song, I write the lyrics with the chords in a separate software (a simple text file) while I record the session. Also, I have opened Midi Jar to see the chords that I am playing. In the case that I'm improvising and I play a chord that I currently don't know, I can see the notation and the notes that compose it.
If it is a really unknown chord for me but I want to take a note of the inversions and everything, I attach a simple note with the notes that are currently playing, for example: C (G C E), just to quickly remember how to play it.

Is it to be able to search the chord elsewhere ?

Not really, the software provides me with all the information I need.

Or for taking notes on a separate application ?

Yes
I really like the quick actions that you wrote, I would simply add three more:

Copy chord's individual notes (e.g. "C E G B")
Copy chord with unicode characters and individual notes (e.g. "Cmaj7 (C E G B)")
Copy chord with ascii characters and individual notes (e.g. "Cmaj7 (C E G B)")

I don't know if it is a efficient way, but it is what works best for me 😅


"click here" considered harmful

You can find any number of posts arguing that "click here" links are not good style: w3c, for instance, and several million more. I don't want to be absolutely prescriptive about our writing style, but we should at least be aware that this is a thing.
Prompted by https://github.com/WGBH/openvault3/pull/424/files

Fixed.


Downloads fail when locking iPhone

Describe the bug
The download fails when I press the power button to turn off my phone or when screen times out.
To reproduce
Attempt transfer file and press side button to turn off phone screen (lock phone.)
Expected behavior
The solution would be adding Live Activity support for the app, which allows it to display it's progress on the lock screen, as well as letting it progress. This feature is very much needed as some don't like leaving their phone on the whole time, and if I need to do something else on my phone, I'd rather not have to completely restart just because the app terminated.
Another solution would simply be to just allow pausing downloads when it detects the phone is off, so I don't have to restart EVERY TIME. Thank you.
Screenshots
No response
Desktop (please complete the following information)
Windows 10 build 19043.1348
Ryzen 5 5500U
8GB DDR4 3200MT/S
256GB SSD
HP laptop motherboard
Smartphone (please complete the following information)
iPhone SE 3rd gen (2022) (same chipset as iPhone 13)
iOS 18.2
Additional context
No response

Unfortunately, iOS stops LocalSend when minimized.
Closing in favor of #1468


Version 0.3.1

Contributes to https://github.com/rapidsai/build-planning/issues/31
Proposes releasing #41 as v0.3.1.
Yes #41 was "breaking", but not in any practical way... no project currently using rapids-build-backend should observe any change in behavior as a result of merging that.
So this proposes 0.3.0 -> 0.3.1, so that the new package will still get pulled in in builds of all the projects already using constraints like rapids-build-backend>=0.3.0,<0.4.0dev0

thank you!


Add appveyor config for Windows testing.

Add appveyor.yml config to allow Windows testing.
The config does not exactly reflect the travis config, because:

appveyor only supports a set list of ruby versions
appveyor requires matrix combinations to be listed explicitly

Appveyor tests are failing for at least 2 different issues; will troubleshoot those now

@james-stocks code looks fine to my. Can you please take a look at the used email address? It isn't associated with your github account.

@james-stocks I see you're using --without development on windows, presumably because ruby on appveyor is limited? Travis is installing the full gemset, maybe we can also save some time there with  --without development?
For reasons of hygiene, I'd suggest using the same sets of gems on all platforms as much as possible.

@bastelfreak - well spotted, thank you - I have updated my Github email address, the commits should now appear associated with this account

@DavidS The '--without development' was copypasted from another project; but I think it's better to see spec tests passing without development dependencies. So I've added an additional commit to this PR to run the same bundle install command for travis


build: update client-go and other go mods

manually, updating a few go modules which are
causing error when dependabot is trying to update.
Closes:  #154

#160 will fix the build issue


Section of beam rotated 90 degrees when using Bar.Modify

Can you add the related files to our commont folder so that I can debug?

Sure, find them here: C:\Users\JohannaRiad\StruSoft AB\StruParam - Projects\femdesign-api\Files for debugging

Moved to \femdesign-api\Test files\114

On which build are you experiencing this?

When setting a new curve the LocalY of the new curve will overwrite the LocalY set on the Beam. So when setting a new base geometry for a Beam the user needs to specify the LocalY to make sure that the orientation remains as expected.

Problem is that the new curve could have any direction and it is then not possible to save the old orientation.


can we dismiss the toast programmatically? toast.dismiss() does not work

i am working on GUI using wails, and I tried to make my own toast because somehow the toast can't be styled using the toast option you provided using tailwind. and the toast itself is not really match up the design of my app, so i need to make my own anyway
the problem is, when i tried to use my own component, the value from the option somehow still appearing outside my component. and i am struggling to dismiss the toast because toast.dismiss() is not working. i don't know if this has something to do with wails or not
btw, i use vue-shadcn port
here is my implementation
// some imports

export type ToastOption = Omit<ExternalToast, 'invert' | 'icon' | 'important' | 'style' | 'unstyled' | 'descriptionClassName' | 'className' | 'promise' /** | 'action' */ > & {
    type?: NonNullable<Parameters<typeof toastVariants>[0]>['text']
    action?: {
        label?: string,
        icon?: Component,
        onClick: () => void
    }
}

export type ToastProps = ToastOption & {
    title: string
}

export function toast(title: string, data?: ToastOption) {
    callToast(markRaw(
        defineComponent({ render: () => h(Toast, { title, ...data }) })),
        {
            ...data,
            // description: undefined,
            // onAutoClose: data?.onAutoClose,
            // onDismiss: data?.onDismiss,
            // duration: data?.duration,
            // cancel: data?.cancel,
            // id: data?.id || new Date().getTime().toString(),
        }
    )
}

Experienced the same thing.

i found the answer. after looking trough your code, it turns it will close the sonner after the custom component emits closeToast event
can you at least give us more concise documentation about this component so that we don't have to look deeper into your code? I think diving deeper to the code is not really necessary if we have good documentation

Hi, did you find the solution to this?

Just create emitter with name closeToast. For closing the toast, just emit it like this, after that the vue-sonner will take care of closing the toast
const props = defineProps<ToastProps>()
const emit = defineEmits<{
    (e: 'closeToast'): void
}>()

function dismiss() {
    if (props.onDismiss) props.onDismiss({ id: props.id! })
    emit('closeToast')
}

function click() {
    if (props.action) props.action.onClick()
    emit('closeToast')
}

I’m not sure I understand. I use the standard toast.dismiss() but it throws an error. What example did you provide me above. PS I’m using Js not Ts

If you create your custom toast, toast.dismiss will not work (i forgot the reason tho). I think the toast.dismiss only close the original toast, not our custom toast.
Vue sonner do not provide clear api to close the toast. After going deeper into the code, it turns out that to close the toast, we need to create emitter named closeToast and then emit it. Just try it out, and see if that works

I understand now. Where should I create the emitter?

Inside your toast

 still getting this error after adding.

maybe im not getting you

Take a look at my code (might as well shameless plug my project lol)
In Toast.vue is my custom toast using the vue-sonner
In index.ts is how i define the composable (function that calls the toast)

Got it to work and i want to personally thank you! @thoriqadillah

Emiting closeToast from custom component works.
Thanks @thoriqadillah for writing it here, it helped me.
Mentioning it in documentation would be helpful to others.

I still don't understand how this works. Can someone write a proper instruction?

I have made a PR for fixing the dismiss function, and an test example to show how the dismiss work.
You can check here https://github.com/xiaoluoboding/vue-sonner/pull/91
Maybe you can close the issue @xiaoluoboding  when you will create a new tag/release for the 1.2.3 ?

Hey @xiaoluoboding, when do you think you can make a new release with the fix ?

Hey @xiaoluoboding, when do you think you can make a new release with the fix ?

Released https://github.com/xiaoluoboding/vue-sonner/releases/tag/v1.2.3

What happened if I have created my custom toast component with its own close button? How get close event emit if I'm using toastservice?
Example:
import Alert from './components/Alert.vue';
import { Toaster, toast } from 'vue-sonner';

const toastQueue = ref([]);

function callAlert() {
  const toastId = toast.custom(markRaw(Alert), {
    componentProps: {
      title: 'This is a title',
      body: 'This is a body text',
    },
    duration: 999999,
  });

  toastQueue.value.push(toastId);
}
</script>

<template>
  <Toaster position="top-center" />

  <button @click="callAlert" @close="">Call Alert</button>
</template>


Roll Engine from 610fd039ae48 to b69f144f62a2 (4 revisions)

https://github.com/flutter/engine/compare/610fd039ae48...b69f144f62a2
2021-04-20<EMAIL_ADDRESS>Roll Skia from e05860862631 to d0ef90769b47 (2 revisions) (flutter/engine#25682)
2021-04-20<EMAIL_ADDRESS>Roll libpng to afda123a503bdc41df13f86316cf5f83bc204761 (flutter/engine#25679)
2021-04-20<EMAIL_ADDRESS>Start microtasks only in non-test envs (flutter/engine#25653)
2021-04-20<EMAIL_ADDRESS>Roll Skia from 94df572a1374 to e05860862631 (2 revisions) (flutter/engine#25678)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


fix(log, vec): use u64 for indices and lengths

On the Wasm32 architecture, usize is 32 bit, making it impossible for the log to report correct size in bytes on large data sets.
This commit changes the types of indices and lengths in Vec and Log so that they will behave correctly if these structures grow beyond four billion items.

LGTM. We'll need to release a new minor version 0.5.0, to roll this out, right?

Do you think we should do a similar change for the BTreeMap?

LGTM. We'll need to release a new minor version 0.5.0, to roll this out, right?

Do you think we should do a similar change for the BTreeMap?

We already use a u64 in BTreeMap::len(). Do you see anything else that needs to be updated?

We already use a u64 in BTreeMap::len(). Do you see anything else that needs to be updated?

No, I think we're good. Thanks!


Some branch

---Please read and delete this text before creating this pull request---
Thanks a lot for the pull request you are going to do!
Please verify that you validate these points:

[ ] indentation is made with 4 spaces
[ ] your pull request contains only changes intended (no refactoring, line return added, ... that could make code review harder. Make another one if you think it is needed...)
[ ] run and verify that existing tests pass. Add some new units tests, if needed.
[ ] update the documentation, if needed.
[ ] update the release notes file

Sorry but what is the goal of this PR?

Sorry, this was really stupid of me, I was using my fork of this repo when experimenting with running an analysis tool in circle-ci build scripts.
I created a pull request for trying a PR build, without thinking at all about that it would go to you. Again, I’m sorry!
Regards/Kalle

On 3 May 2019, at 15:01, Philippe Miossec<EMAIL_ADDRESS>wrote:
Sorry but what is the goal of this PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/git-tfs/git-tfs/pull/1274#issuecomment-489087296, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVJMN35GSWTEVEENQCU2MDPTQZUJANCNFSM4HKTNTMQ.

Ok. No problem.


New: Add new sections to user guide

Fix #570

Pull request checklist
Make sure you:

[x] Signed the Contributor License Agreement
[x] Followed the commit message guidelines

Short description of the change(s)

This is how it looks in this PR:

We might want to tweak some of the titles like

but that's a separate PR.


Student Skills Checklist

Student Skills Checklist

[x] Laptop Verification or Cloud Workspace

Rank: 4
Notes: verification by Linux commands notebook

[x] VSCode

Rank: 4
Notes: live change code, commit, make, run localhost, test, debug

[x] Show VSCode GitLens

Rank: 3
Notes: verify commits, show change, comments, reset to commit, run on old commit

[x] GitHub cloud repo

Rank: 3
Notes: live push change, verify id, review profile

[x] GitHub Pages Actions

Rank: 4
Notes: review runs and verify runtime, receive demo

[x] Hacks Tools & Equipment Play

Rank: 4
Notes:

[x] Hacks GitHub Pages Playground

Rank: 4
Notes:

[x] Hacks SASS Basics

Rank: 3
Notes:

[x] Hacks Jupyter Notebook

Rank: 3
Notes:

[x] Pair Programming

Rank: 3
Notes: tangibles that show co-operative work

Originally posted by @jm1021 in #14

Grader Skills Worksheet

[4] Attendance

Rank: 0
Notes:

[4] Work Habits

Rank: 0
Notes:

[4] Behavior

Rank: 0
Notes:

[4] Timeliness

Rank: 0
Notes:

[3] Tech Sense

Rank: 0
Notes:

[4] Tech Talk

Rank: 0
Notes:

[4] Tech Growth

Rank: 0
Notes:

[2] Advocacy

Rank: 0
Notes:

[3] Comm & Collab

Rank: 0
Notes:

[4] Integrity

Rank: 0
Notes:

[4] Organized

Rank: 0
Notes:

Originally posted by @jm1021 in #14


feat: add flat_map function + test

closes #5

used this as inspo https://dev.to/turbaszek/flat-map-in-python-3g98


Minor Improvements

This PR corrects postCSS config settings: you are supposed to give a directory here and not the config file itself.
It also bumps npm dependencies to latest versions.

@deining Appreciate the changes 💯


Remove usage of zypper

There is no zypper anymore in bci micro based containers.

You could try to use the container_git_clone fixture instead:
https://github.com/SUSE/BCI-tests/blob/35aefbb4f8c646cc9818439601412dec4f295f9a/conftest.py#L22

that does the cloning at test runtime, rather than at build time of the container. if we don't want to add tar to the container on tumbleweed then I think I need to wait until the multibuild refactoring is over and make this a proper multibuild package.

see https://github.com/SUSE/BCI-dockerfile-generator/pull/1817 instead.

thanks for merging the tar change. now I'd like to get this change reviewed as otherwise the tests are broken.


On initialize skill fails to load when no settings

When I try to load the skill with an empty settings.json file or a server that doesn't work, the skill completely fails to load.
Maybe just check if the user has filled out the settings in home, and if they haven't, give them a message that they need to do so.

More error handling and debug logging added. Please try it out.

I'm having an issue where I had to re-install it fresh and it doesn't appear to be loading:
23:06:29.052 - skill-squeezebox_johanpalmqvist:load_library_total_duration:239 - INFO - Loading library total duration state
23:06:29.056 - skill-squeezebox_johanpalmqvist:load_library_total_duration:245 - INFO - Loaded library total duration state
23:06:29.059 - skill-squeezebox_johanpalmqvist:update_sources_cache:442 - INFO - Library total duration changed. Updating cache.
23:06:29.088 - skill-squeezebox_johanpalmqvist:load_library_total_duration:239 - INFO - Loading library total duration state
23:06:29.093 - skill-squeezebox_johanpalmqvist:load_library_total_duration:245 - INFO - Loaded library total duration state
23:06:29.097 - skill-squeezebox_johanpalmqvist:update_library_cache:419 - INFO - Library total duration unchanged. Not updating cache.
23:06:29.101 - skill-squeezebox_johanpalmqvist:load_library_cache:229 - INFO - Loading library cache
23:06:29.105 - skill-squeezebox_johanpalmqvist:load_library_cache:235 - ERROR -Library cache not found. Exception: Expecting value: line 1 column 1 (char 0)
23:06:29.874 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist.set'
23:06:29.884 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:IdentifyTrack.intent'
23:06:29.888 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:PowerOff.intent'
23:06:29.891 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:PowerOn.intent'
23:06:29.894 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:Stop.intent'
23:06:29.897 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:UpdateCache.intent'
23:06:29.900 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:VolumeDown.intent'
23:06:29.903 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:VolumeHalf.intent'
23:06:29.906 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:VolumeMax.intent'
23:06:29.910 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:VolumeMute.intent'
23:06:29.913 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:VolumeQuarter.intent'
23:06:29.917 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:VolumeThreeQuarters.intent'
23:06:29.920 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:VolumeUnmute.intent'
23:06:29.924 - mycroft.messagebus.client.ws:remove:159 - DEBUG - Removing found'skill-squeezebox.johanpalmqvist:VolumeUp.intent'
23:06:30.040 - mycroft.skills.core:load_skill:166 - ERROR - Failed to load skill: skill-squeezebox.johanpalmqvist
  File "/opt/mycroft/skills/skill-squeezebox.johanpalmqvist/__init__.py", line 78, in initialize
  File "/opt/mycroft/skills/skill-squeezebox.johanpalmqvist/__init__.py", line 99, in get_sources
  File "/opt/mycroft/skills/skill-squeezebox.johanpalmqvist/__init__.py", line 443, in update_sources_cache
  File "/opt/mycroft/skills/skill-squeezebox.johanpalmqvist/__init__.py", line 306, in save_sources_cache
AttributeError: 'SqueezeBoxMediaSkill' object has no attribute 'results'

Is this related? This is a new install with the media library not selected.

Sorry I think this was from an incomplete scan after the initial settings being incorrect (e.g. trying to scan the media library and failing) which may not be related.


Support for Azure OpenAI

There is a previous issue that seems to have added this functionality, however it's not clear to me how I can use it.
How can I use Doctran with Azure OpenAI models?

I'm facing similar issue , I would like to use doctran with Azure open AI ,
I've got access to following environment variables :
OPENAI_EMBEDDING_API_KEY
OPENAI_CHAT_API_KEY
OPENAI_CHAT_MODEL_NAMES
OPENAI_CHAT_API_BASE_URL
OPENAI_EMBEDDING_API_BASE_URL
OPENAI_EMBEDDING_VERSION
OPENAI_CHAT_VERSION
but not sure how to use them with doctran

I was able to use doctran for azure with this code
from doctran import Doctran
import os

# This is the Azure OpenAI Endpoint
os.environ["OPENAI_API_BASE"] = "https://{YOUR_RESOURCE_NAME}.openai.azure.com/"
os.environ["OPENAI_API_VERSION"] = <API_VERSION>

doctran = Doctran(
    openai_api_key=<AZURE_OPENAI_API_KEY>,
    openai_deployment_id=<AZURE_OPENAI_DEPLOYMENT_ID>,
)

document = doctran.parse(
    content="",
    content_type="text"
)

@aroffe99
Thanks for your inputs. I tied out your code with few modification.
os.environ["OPENAI_API_BASE"] = OPENAI_CHAT_API_BASE_URL
os.environ["OPENAI_API_VERSION"] = OPENAI_CHAT_VERSION
os.environ["OPENAI_API_TYPE"] = "azure"
doctran = Doctran(
    openai_api_key=OPENAI_CHAT_API_KEY,
    openai_deployment_id=DEPLOYMENT_ID
)

document = doctran.parse(
    content=STRING_CONTENT,
    content_type="text"
)

but when I call interrogate :
interrogate_doc = await document.interrogate().execute()
I get error ::
Exception: Error executing transformation (<Transformation.interrogate: 'DocumentInterrogator'>, {}): OpenAI function call failed: Unrecognized request argument supplied: functions
Not enough information for me to go further , did you face such error ?


v.0812

👷 Deploy Preview for analyticalnutrition processing.
🔨 Explore the source changes: ed3f1c5d3bb6716d2d101ecee05961135c7235e6
🔍 Inspect the deploy log: https://app.netlify.com/sites/analyticalnutrition/deploys/6115a201c20b950007087593


Add extra samples

Could we extend this application to include additional API samples?
Whilst the contacts sample works, my dev(s) have so far been unsuccessful in being able to run a simple search query via the API off the back of this sample.  We keep getting errors around unable to silently get the token.
I have a feeling that the ADALTokenCache implementation may be an issue, it certainly seems to be when you try and host this in Azure from what I have heard from others.

Closing all issues since this repo is being archived and no longer maintained.


Unsigned primary keys

Is there a way to cause the autogen'd primary key ('id') to be unsigned?

Alternative method overriding Phinx classes.
https://gist.github.com/f0ead7bd210e3968208e.git

This is a feature I miss. Doesn't necessarily break the app, but it hurts inside knowing that all my auto-increment id's will be signed for no practical reason.

@robmorgan I would love to see this feature. Sure @twoixter solution works great (thanks!) but it would be nicer to have the possibility to configure it directly.

Just posted a small update for @twoixter solution: https://gist.github.com/adayth/f0ead7bd210e3968208e#gistcomment-1585602

Who came up with the brilliant idea to set primary keys as signed in the first place, that's one of the reasons I'm starting to think raw SQL files for migrations wasn't such a bad idea after all... Overall Phinx feeling -> This is just retarded.

Hi @bubach that was me and it's why I no longer work on this project anymore. You might want to check out this instead: https://flywaydb.org/ 👍


Conditionally run release stage

This can save some build time

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   99.38%   99.38%
=======================================
  Files          12       12
  Lines         485      485
=======================================
  Hits          482      482
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105b616...8a255b2. Read the comment docs.

LIKE


flask how to stop after run() called

i want help i called run() it is running forever. Is there any method to close or stop without using service?

CTRL+C...
flask run is only meant for development, so if you are running it as a service you are most likely doing something wrong.

u mean flask i can't use as service?

Please read the flask docs (and this is not whatsapp, it's not too much work to write "you" instead of "u"): https://flask.palletsprojects.com/en/1.1.x/deploying/


Adding example of AntiForgery scenarios with standards Web APIs

Part of https://github.com/dotnet/aspnetcore/pull/42586
Was decided to not have any in-box default behavior for both (API controllers and Minimal APIs), however, we should add an example of how the users could implement it using IAntiforgery services.
Here is a sample code with the server implementation: https://gist.github.com/brunolins16/3d11b2fd9861afaec22e79abfc2a55fd

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47b14f57-82ac-a2e2-cbc7-22a81a60f4ac
Version Independent ID: bffca13c-223f-c61f-9cb2-9da8811eecfa
Content: Prevent Cross-Site Request Forgery (XSRF/CSRF) attacks in ASP.NET Core
Content Source: aspnetcore/security/anti-request-forgery.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@brunolins16 don't worry about the wording, I can clean that up. Just get a good start.


Uncaught TypeError: Cannot read property 'null' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.8.0
System: Mac OS X 10.11
Thrown From: json-schema package, v0.1.15
Stack Trace
Uncaught TypeError: Cannot read property 'null' of undefined
At /Users/march/.atom/packages/json-schema/node_modules/react/lib/ReactMount.js:636

TypeError: Cannot read property 'null' of undefined
  at Object.ReactMount.findReactContainerForID (/Users/march/.atom/packages/json-schema/node_modules/react/lib/ReactMount.js:636:50)
  at findParent (/Users/march/.atom/packages/json-schema/node_modules/react/lib/ReactEventListener.js:39:30)
  at handleTopLevelImpl (/Users/march/.atom/packages/json-schema/node_modules/react/lib/ReactEventListener.js:74:16)
  at ReactDefaultBatchingStrategyTransaction.Mixin.perform (/Users/march/.atom/packages/json-schema/node_modules/react/lib/Transaction.js:134:20)
  at Object.ReactDefaultBatchingStrategy.batchedUpdates (/Users/march/.atom/packages/json-schema/node_modules/react/lib/ReactDefaultBatchingStrategy.js:66:19)
  at Object.batchedUpdates (/Users/march/.atom/packages/json-schema/node_modules/react/lib/ReactUpdates.js:110:20)
  at ReactEventListener.dispatchEvent (/Users/march/.atom/packages/json-schema/node_modules/react/lib/ReactEventListener.js:174:20)

Commands
     -0:17 settings-view:check-for-package-updates (atom-workspace.workspace.theme-solarized-light-syntax.theme-atom-light-ui.atomic-emacs.scrollbars-visible-when-scrolling)

Config
{
  "core": {
    "audioBeep": false,
    "destroyEmptyPanes": false,
    "disabledPackages": [
      "clippy",
      "gocode",
      "emacs-center-screen",
      "Tern",
      "policeman",
      "policeman",
      "jenkins-dashboard",
      "SublimeSelect",
      "atom-debugger",
      "dash-on-cursor",
      "atom-template-engine",
      "nippo",
      "go-playground",
      "godef",
      "git-blame-plus",
      "atom-sharp",
      "git-grep",
      "gradle-manager",
      "linter-scalac",
      "clojure-eval-in-repl",
      "linter-lein",
      "linter-clojure"
    ],
    "excludeVcsIgnoredPaths": false,
    "themes": [
      "atom-light-ui",
      "solarized-light-syntax"
    ]
  }
}

Installed Packages
# User
angularjs, v0.3.4
atom-gdb, v0.4.0
atom-math, v0.0.9
atom-mocha, v0.0.6
atom-python-debugger, v0.3.4
atom-shortcuts, v0.0.2
atom-slime, v2.3.3
atom-yeoman, v0.3.15
atomatigit, v1.5.5
atomic-emacs, v0.9.1
autocomplete-go, v1.1.0
autocomplete-python, v1.7.5
bottom-dock, v0.4.4
build, v0.64.0
build-gradle, v0.6.0
build-sbt, v0.5.0
builder-go, v1.0.0
busy, v0.5.0
color-picker, v2.1.1
command-logger, v0.23.0
editor-stats, v0.17.0
environment, v1.2.0
git-log, v0.4.1
go-config, v1.1.4
go-get, v1.0.3
go-plus, v4.1.0
go-runtime, v0.2.0
gofmt, v1.1.6
gometalinter-linter, v1.1.0
gorename, v1.0.2
gulp-manager, v0.2.19
hashrocket, v0.4.10
haskell-grammar, v0.4.0
haskell-unicode-snippets, v0.1.1
html2haml, v0.10.0
ide-haskell-cabal, v1.4.0
ink, v0.4.4
ionide-fsharp, v1.9.1
java-importer, v1.4.1
javascript-standard-snippets, v0.2.1
json-schema, v0.1.15
jsonlint, v1.1.2
jsonpp, v0.1.1
language-diff, v0.4.0
language-docker, v1.1.6
language-dockerfile, v0.1.0
language-dot, v1.6.0
language-fsharp, v0.8.4
language-gradle, v0.0.3
language-groovy, v0.6.0
language-groovy-cloned-from-java, v0.3.0
language-haml, v0.24.0
language-haskell, v1.7.17
language-ipynb, v1.3.0
language-javascript-jsx, v0.3.7
language-javascript-semantic, v0.2.1
language-lisp, v0.2.0
language-prolog, v0.10.0
language-rust, v0.4.6
language-scala, v1.1.6
language-scala-plus, v1.2.2
language-swig, v0.1.4
less-than-slash, v0.13.0
line-diff-details, v1.3.5
linter, v1.11.5
linter-checkstyle, v1.2.0
linter-clang, v3.4.4
linter-golinter, v1.2.0
linter-hlint, v0.4.3
linter-javac, v1.9.4
linter-liquid, v0.1.0
linter-manager, v0.2.12
linter-rust, v0.4.6
lisp-paredit, v0.5.3
merge-conflicts, v1.4.4
minimap, v4.24.4
minimap-git-diff, v4.3.1
navigator-godef, v1.0.3
nuclide-debugger-lldb, v0.0.35
package-atom-snippets, v0.1.11
pigments, v0.29.2
pretty-json, v1.4.1
project-environment, v1.0.4
proto-repl, v1.1.11
proto-repl-charts, v0.3.2
python-isort, v0.0.7
python-jedi, v0.3.6
racer, v0.20.0
react, v0.15.0
react-snippets, v0.4.2
refactor, v0.6.0
rust-api-docs-helper, v0.5.1
scala-format, v0.1.8
script-runner, v1.8.4
source-preview-react, v0.2.0
terminal-status, v1.6.8
tester-go, v1.0.4
tree-view-git-status, v0.2.3
tualo-git-context, v0.6.17

# Dev
No dev packages

+1 for me. Encountering the same problem. It makes my Atom editor instance unusable as it keeps throwing the same error over and over again. It does so every few seconds, really annoying.

Ran into this after updating to Atom 1.8 on OS X 10.11.5. It seems like disabling the atom-json-schema package and restarting Atom helped, but I'm not sure what functionality I'm missing with that package disabled.

I got this error while having a json file open then opening a .h file using shell on Linux/Ubuntu.  By command line I mean issuing "atom ./file.h" from a Terminal.


Update golangci-lint version

What
Update golangci-lint dependency to version 1.60.1.
Why
The pipeline on @radimous's #412 is failing on the lint-and-unit job. The problem seems to be that the current version of
golangci-lint:v1.58.1 is incompatible with go:v1.23. Therefore, I upgraded the version to the one used in PKO: golangci-lint:v1.60.1.

dupe of https://github.com/package-operator/cardboard/pull/396

merging anyways bc https://github.com/package-operator/cardboard/pull/396 isn't ready yet


Need binding frontal_face_detector inside .h from HOG SVM detector file using train_object.py script?

Is it possible to bind HOG SVM detector file into frontal_face_detector.h to use get_frontal_face_detector in python instead of using simple_object_detector?
P.S: I have already tried to convert detector.svm file to base64 & replace with get_frontal_face_detector.h base64 data. Then I rebuild dlib manually. But it shows this error "RuntimeError: Error detected in compressed data stream."
Thanks in Advance.

Maybe you are looking for this
http://dlib.net/python/index.html#dlib.fhog_object_detector ?
On Tue, Dec 15, 2020 at 1:03 AM ismailpolas<EMAIL_ADDRESS>wrote:

Is it possible to bind HOG SVM detector file into frontal_face_detector.h
to use get_frontal_face_detector in python instead of using
simple_object_detector?
Thanks in Advance.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/issues/2262, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPYFR42XH4LT63MK3KPNOLSU333FANCNFSM4U3Z7AHQ
.

Thank You @davisking for replying. I have solved the issue by your support.


Adding support for multiple subgroups

This PR adds support for multiple work subgroups.
Subgroups are formed by introducing multiple pubsub topics to which work (roll calls) are published to. Changes are backwards compatible - if no explicit configuration is done, everything should work like before, and all nodes use the default topic as before (blockless/b7s/general).
Operators can instruct their work nodes to make themselves available to specific topics of work by using CLI parameters, e.g. node --topic blockless/b7s/topic1 --topic blockless/b7s/topic3. Note that worker can include a list of topics. The default topic is always included as it's used to transmit some general data like health pings.
To direct work to a subgroup, HTTP requests to the head node execution endpoint (/api/v1/functions/execute) should include the subgroup field, e.g.
{
    "subgroup": "blockless/b7s/topic1",
    "function_id": "{{hello-world-cid}}",
    "method": "{{hello-world-wasm}}",
    "config": {
        "number_of_nodes": 2,
        "result_aggregation": {
            "enable": false,
            "type": "none",
            "parameters": [
                {
                    "name": "type",
                    "value": ""
                }
            ]
        }
    }
}

If the subgroup is not specified, it's published to the general topic, which all worker nodes belong to.
Worker nodes have to have their topics specified on boot, and they will subscribe to all of them. However, head nodes do not. If a head node sees a subgroup it has not seen before, it will try to join that topic and publish to it, even if it's new to it (fanout messages). This makes the head node more flexible and doesn't require it to know a lot in advance.
Function install messages can also be directed to a specific subgroup.
Since we now have multiple subscriptions for ingress messages, main node run loop has been somewhat tweaked (and can be cleaner, but will be in a later PR).

I think this makes total sense.
There is only 1 execution per topic?

Oh, I think you're right - I've lost sight of limiting parallelism. But I accidentally went the other way. We limit how many messages we queue (from all topics) but when draining the queue we execute all of them asynchronously. Before (as it should be) we had a limit on how many concurrent executions we had. I'll amend this tomorrow when I'm back.
Good catch! 🕵


[3.0-dev] Major refactor of serialization in prep for 3.0

(note this PR is just for merging into the v3.0.0-dev branch, not main)
file schema
The file schema has changed. Immediately following the metadata block is the full block of all header structures.
After the metadata and headers is the block of raw tensor data. The block of tensor data begins on a 4k page-aligned boundary (relative to start of file). Each individual tensor begins on an 8-byte-aligned boundary.
Basically:
file_header
metadata_size
metadata0
...
metadataN
header0
...
headerN
tensor0 (file_offset % 4096 == 0)
tensor1 (file_offset % 8 == 0)
...
tensorN (file_offset % 8 == 0)

We may want to combine the metadata and the header entries, but they are left separate for now for easier backwards compatibility.
hash computation
Previously, header hash computations included the hash fields themselves, presumed to be zeroed. This has been changed so the hash computation segments omit the hash fields.  ~This breaks verify_hashes=True with 2.x files for now. We should prob fix prior to release~ (This is now fixed, we can deser 2.x files with verify_hashes)
bulk_write refactor
_bulk_write() has been broken up into a series of smaller functions that each perform some operation on the tensors. _WriteSpec carries the state of each tensor as it gets processed. Many ops are threaded and tracked as Futures (_WriteSpec.tensor_data_task). Dependent steps do Future chaining.
tensor_write()
tensor_write(), e.g. "incremental mode", is still supported. (It is implemented as a call to _bulk_write([tensor])). There are new tests to validate its functionality.
max_tensors
Because the new file schema must know ahead of time where to start writing tensor data, there must be a certain amount of pre-allocated space for the metadata and headers. Thus you must specify max_tensors to TensorSerializer.__init__ If you plan on callling tensor_write() more than once. This does a wild-ass-guess estimate on a good amount of header space to reserve. In some cases, like really long tensor names, it could still be an underestimate. You will get a RuntimeError() if you call write_tensor() and there isn't enough pre-allocated space.
You do not need to set max_tensors if you just call tensor_write() once.
Performance
Note that while these changes are mainly motivated to improve performance, I did not spend much time in this PR to measure and optimize performance. There may be regressions, but we should be able to resolve them (and beyond!) before release.

Feedback
The code looks pretty good and it also works pretty good too. I have tested this against various serialization tasks by serializing models for inference which did not result in a failure. The comments that I have left on this are mainly to get a better understanding behind the intent of some of the changes in this PR even if it was as little as changing an error return value.
That being said, the changes to the file schema that this PR provides are nice such as aligning tensor data on fixed boundaries or the decomposition of bulk_write(). Though, I am a bit curious about the addition of max_tensors. Is max_tensors a necessary argument to have because we support write_tensor()?
Additionally, it would be helpful to understand max_tensors more with a code sample that demonstrates its necessity, just like the code samples in the other docstrings.
Testing
A good portion of the changes in this PR and the PR's intent is changing the file schema. I have spent a good portion of my time reviewing this PR by testing the changes that were implement. The PR works with deserializing older 2.x artifacts and I have gathered benchmarking data from serializing and deserializing GPT-J 6B for 50 trials which did not show a significant performance difference between this PR and 2.9.0 (or at least: I don't think it is a significant difference.)

Accounting for File Range Insertion

Imo its a fair bit of added code complexity, adds more constraints to what we can optimize, for little benefit. Object stores upload APIs have minimums to the chunk sizes, and you still need to assign the correct index of the block ahead of time -- you can't insert a block later.

In terms of dev process:
There are a lot of good suggestions on changes and improvements, but this PR is already uncomfortably big. I think it's easier to make those changes as subsequent and individual PRs against the 3.x branch. I can take point on writing up issues on all of the pending comments so that they don't get lost. For some of the spicier ones, we can also use the issues as separate threads of discussion on each topic. How does that sound?

In terms of dev process:
There are a lot of good suggestions on changes and improvements, but this PR is already uncomfortably big. I think it's easier to make those changes as subsequent and individual PRs against the 3.x branch. I'd also like to empower others to be able to make contributions as well 😜
I can take point on writing up issues on all of the pending comments so that they don't get lost. For some of the spicier ones, we can also use the issues as separate threads of discussion on each topic. How does that sound?

Accounting for File Range Insertion

~Imo its a fair bit of added code complexity, adds more constraints to what we can optimize, for little benefit. Object stores upload APIs have minimums to the chunk sizes, and you still need to assign the correct index of the block ahead of time -- you can't insert a block later.~
Thinking about this more, I maybe have presumed different from what you were proposing. I don't think we should add a public interface that allows for the mid-range insertion of a tensor. But I could see the benefit of using fallocate holes to optimize the writes of incremental tensors.

Ticketing this as https://github.com/coreweave/tensorizer/issues/159

Accounting for File Range Insertion

~Imo its a fair bit of added code complexity, adds more constraints to what we can optimize, for little benefit. Object stores upload APIs have minimums to the chunk sizes, and you still need to assign the correct index of the block ahead of time -- you can't insert a block later.~
Thinking about this more, I maybe have presumed different from what you were proposing. I don't think we should add a public interface that allows for the mid-range insertion of a tensor. But I could see the benefit of using fallocate holes to optimize the writes of incremental tensors.

Presuming this was what you intended, ticketed as https://github.com/coreweave/tensorizer/issues/159

Accounting for File Range Insertion

~Imo its a fair bit of added code complexity, adds more constraints to what we can optimize, for little benefit. Object stores upload APIs have minimums to the chunk sizes, and you still need to assign the correct index of the block ahead of time -- you can't insert a block later.~
Thinking about this more, I maybe have presumed different from what you were proposing. I don't think we should add a public interface that allows for the mid-range insertion of a tensor. But I could see the benefit of using fallocate holes to optimize the writes of incremental tensors.

Presuming this was what you intended, ticketed as #159

Yes—no, we don't need an interface that controls the actual tensor insertion point in the file—it would rather be useful for expanding the metadata section at the top of the file instead of going through hoops to determine its size or requiring people to specify max_tensors in advance. So I'm referring to setting up the entire metadata section as a chunk of indeterminate size, for object storage purposes.
Though, as a sidenote, you can add new chunks into the middle of a multi-part object storage upload, because part indices don't need to be consecutive (for anything compatible with AWS's object storage):

Parts upload
When uploading a part, in addition to the upload ID, you must specify a part number. You can choose any part number between 1 and 10,000. A part number uniquely identifies a part and its position in the object you are uploading. The part number that you choose doesn’t need to be in a consecutive sequence (for example, it can be 1, 5, and 14). If you upload a new part using the same part number as a previously uploaded part, the previously uploaded part is overwritten.

If we wanted, we could make the file header (start at) chunk 1 and the data section start at chunk 100, and have room to optionally insert up to 99 extension chunks before committing an upload. But we wouldn't need to.


CORE-29012 Added "type" field to Send Event action type.

Description
Added type field to Send Event action type. Right now I made it optional. We can switch it to required whenever we deem that it's required.

Related Issue
https://jira.corp.adobe.com/browse/CORE-29012

Motivation and Context
type is supported by alloy

How Has This Been Tested?
Automation and manual visual inspection

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Yeah, that's a good idea. I'll use a ComboBox. Do we know of any other predefined values?

I don’t think we have any predefined ones yet. Thank you sir!

@jfkhoury I switched it to a ComboBox and fixed a couple unrelated things along the way.


AVRO-1810: Fix GenericDatumWriter w/ enums

Generated enum classes will implement GenericEnumSymbol so that they may be written with GenericDatumWriter. This narrows the Comparable scope of GenericEnumSymbol to the class that implements it because java.lang.Enum already implements Comparable. However it seems the broader comparable scope was unused or at least untested.
testGenericWriteAndRead reads into an IndexedRecord because there is no GenericDatumReader support for setting an instance of an Enum into a SpecificRecord (but this seems to make sense and SpecificDatumReader should be used in that instance anyway).
https://issues.apache.org/jira/browse/AVRO-1810

Hi, I was so happy to see this PR which fixes this issue - thank you. It looks like the JIRA marks the fix version to the unreleased 1.8.4 or 1.9.0 versions. It looks like there are normally 2-3 releases per year, but that there hasn't been a release since mid-2017. Does anyone have suggestions for the best way to capture PRs like this or know when the release might get scheduled? It looks like 1.8.3 has 7 todos and 1.8.4 has 1 (https://issues.apache.org/jira/projects/AVRO?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page&status=no-filter)

We want to release 1.9 soon. We're looking at a RC this week if everything goes according to plan 👍


List machines in a flat list

This PR changes the way the GCE instances are listed by default to show a plain list of instances. The user can still choose to show per zone by using a new context menu option to do so. For completeness the option to filter to only Windows instances is also added to this context menu.
The options in the context menu are dynamically changed depending on the properties values, instead of using checked options. It feels easier to understand this way.
See the new options in the context menu here:

Just one small comment otherwise LGTM


enhancement: Minimize and maximize from components

Closed by https://github.com/marc2332/freya/pull/627


[Doc] Add versioning to website

Add versioning to website because the domain layer schema changes frequently.

@klesh /version route is probably broken only returning '@' as version. I've hidden version tag line on my current PR at the request of @Startrekzky .


Can ChatHuggingFace model perform Function Calling?

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
I was using the following code to demonstrate the tool-calling feature of HuggingFace model, but i got error.
from langchain_huggingface import ChatHuggingFace, HuggingFacePipeline

pipeline = HuggingFacePipeline.from_model_id(
    model_id="NousResearch/Hermes-2-Pro-Llama-3-8B",
    task="text-generation",
    pipeline_kwargs={
        "max_new_tokens": 500,
        "top_k": 50,
        "temperature": 0.1,
        "do_sample": True,
        "return_full_text": False
    },
    device=0
)

model = ChatHuggingFace(llm=pipeline)
from pydantic import BaseModel, Field
from langchain_core.tools import tool

class GetWeather(BaseModel):
    '''Get the current weather in a given location'''
    location: str = Field(description="The city and state,e.g. San Francisco, CA")

class GetPopulation(BaseModel):
    '''Get the current population in a given location'''
    location: str = Field(description="The city and state, e.g. San Francisco, CA")

model_with_tools = model.bind_tools([GetWeather, GetPopulation])
model_with_tools.invoke(
    "Which city is hotter today and which is bigger: LA or NY?",
)
model_with_tools.tool_calls

Error Message and Stack Trace (if applicable)
{
	"name": "AttributeError",
	"message": "'ChatHuggingFace' object has no attribute 'tool_calls'",
	"stack": "---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[7], line 1
----> 1 model_with_tools.tool_calls

File /dccstor/kirushikesh/.conda/testenv/lib/python3.10/site-packages/langchain_core/runnables/base.py:5704, in RunnableBinding.__getattr__(self, name)
   5703 def __getattr__(self, name: str) -> Any:
-> 5704     attr = getattr(self.bound, name)
   5706     if callable(attr) and (
   5707         config_param := inspect.signature(attr).parameters.get(\"config\")
   5708     ):
   5709         if config_param.kind == inspect.Parameter.KEYWORD_ONLY:

File /dccstor/kirushikesh/.conda/testenv/lib/python3.10/site-packages/pydantic/main.py:856, in BaseModel.__getattr__(self, item)
    853     return super().__getattribute__(item)  # Raises AttributeError if appropriate
    854 else:
    855     # this is the current error
--> 856     raise AttributeError(f'{type(self).__name__!r} object has no attribute {item!r}')

AttributeError: 'ChatHuggingFace' object has no attribute 'tool_calls'"
}

Description
Ok, i am try to use langchain library to play with the tool-calling capability of HuggingFace models. Recently, i got to know about the Hermes-LLM tool calling capability from this blog. I am a big fan of Langchain and i thought of doing the function calling with that model in Langchain. First i am not sure if its possible yet in Langchain, but when i checked this class definition i thought its possible and i tried to reproduce the same code.
The .bind_tools() is working from ChatHuggingFace, but when i tried to read the tool_calls from the response i was getting the error.
System Info
System Information

OS:  Linux
OS Version:  #1 SMP Thu Dec 7 03:06:13 EST 2023
Python Version:  3.10.4 (main, Mar 31 2022, 08:41:55) [GCC 7.5.0]

Package Information

langchain_core: 0.3.0
langchain: 0.3.0
langchain_community: 0.3.0
langsmith: 0.1.121
langchain_huggingface: 0.1.0
langchain_ibm: 0.2.0
langchain_openai: 0.2.0
langchain_text_splitters: 0.3.0

Optional packages not installed

langgraph
langserve

Other Dependencies

aiohttp: 3.10.5
async-timeout: 4.0.3
dataclasses-json: 0.6.7
httpx: 0.27.2
huggingface-hub: 0.24.7
ibm-watsonx-ai: 1.1.9
jsonpatch: 1.33
numpy: 1.26.4
openai: 1.45.1
orjson: 3.10.7
packaging: 24.1
pydantic: 2.9.2
pydantic-settings: 2.5.2
PyYAML: 6.0.2
requests: 2.32.2
sentence-transformers: 3.1.0
SQLAlchemy: 2.0.35
tenacity: 8.5.0
tiktoken: 0.7.0
tokenizers: 0.19.1
transformers: 4.44.2
typing-extensions: 4.12.2

Hi, my name is Juno, I'm working with a team at UTSC as part of a group project to contribute to LangChain. We're interested in working on this issue, can it be assigned to us please?

Hi there, the problem lies on the data type returned after invoke(prompt) function. The returned type is a dict. So, to get the attribute 'tool_calls', you have to convert the result to a dictionary and access it like dict['attribute'].
response = model_with_tools.invoke(     "Which city is hotter today and which is bigger: LA or NY?", )
result = response.dict()['tool_calls']