The problem with the latest (v16) layer ARN for Python 3.6

The plugin has stopped working properly after the latest layer ARN arn:aws:lambda:us-west-2:451483290750:layer:NewRelicPython36:16
was released. Please check.

@aandrusyk-amplify Thanks for reporting. Any more details as to what is not working?

@aandrusyk-amplify There's been a couple layer releases since v16, are you still having issues with the latest layer version?

Versions v16, v17, v18 are not working for me. The last working version is v15.
The Summary page for Lambda functions doesn't present information like duration, invocations, and others. However, CloudWatch metrics page does.

The newest v19 works again.
You may close the issue.
Thank you!

@aandrusyk-amplify Thanks for letting us know.


Fix initial value for useLocalStorage() when local storage is disabled.

Fair point.  I agree the code is weirdly duplicative. The one nice thing about using storageAvailable() is that it will prevent you from getting repeat exception log messages in the console once we've determined storage is not available.  Probably doesn't really matter, but I like a clean console. 😁


Android 13 and multiple updates

This PR updates the app to Android 13 (or tries to, I do not have Android 13 and can not test it).
I also took multiple forks and merged their changes into this PR.

Test Android 13 before merge!

Related: https://github.com/bilde2910/Hauk/issues/191

The app runs fine on Android 13.
This PR merges multiple unrelated PRs?
Looks odd...

@licaon-kter I rewrote the history a little bit and removed the mess I made while testing.
May you test again?
And it would be great to get this as release to Google Play Store...

I tested it using an emulator with Android 13, but I can not test it on real devices, because I have no devices above Android 11

@TheCataliasTNT2k  I am also using Fdroid, would you have an .apk for me to make some test ?

On a quick read it looks nice, hopefully @bilde2910 can take a look too

@TheCataliasTNT2k I am also using Fdroid, would you have an .apk for me to make some test ?

No, sorry, I never built an apk, because unfortunately I do not have any real devices to test it. I only used the Android Emulator....


App Submission Disclaimer

Figma
Copy
Upon submittal of an Application by an Applicant:

We need to update the disclaimer at the end of application submission.
Please use copy below or under "revised copy" in document above
We need to store a record of their acknowledgement, if we don't already.

Copy:

For available units that are offered via a housing lottery, eligible applicants will be contacted in order of their rank in a lottery conducted shortly after the application deadline.  For available units that are offered on a first-come, first-served basis, eligible applicants will be contacted in chronological order of their applications until vacancies are filled.
If you are contacted for an interview, you will be asked to fill out a more detailed application and provide supporting documents.  All of the information that you have provided will be verified and your eligibility confirmed. Your application may be removed from consideration by the Professional Partner if you have made any fraudulent statements. For properties with housing preferences, if your housing preference claim cannot be verified, you will not receive the preference but will not be otherwise penalized.  All applicants will be screened as outlined in the Listing’s Resident Selection Criteria.
Completing this application does not entitle you to housing or indicate you are eligible for housing. Note that you cannot change your online application after you submit it.

I affirm that I am at least eighteen years of age and am authorized to submit the personal identifiable information (PII) of any household member listed in the Application. I consent on both behalf of the household members listed in the Application and myself for the PII to be transmitted to the Professional Partner and/or Local Government for the purposes as outlined in the Terms of Use [link].  I agree to the above terms and declare that the foregoing provided information is true and accurate, and acknowledge that any misstatement fraudulently or negligently made on this application may result in removal from the application process.

Yes, I agree
No
If they click “Yes, I agree”, they can proceed.  If they click “No”, they can’t create an account.

as a heads-up, we can handle translations in a separate ticket

looks good!


Preview: Save of unknown monomer to KET gives invalid ket file

Steps to Reproduce

Go to Macromolecules mode - Flex mode
Load using paste from clipboard IDT type: /i2AmPr/

Save canvas to KET file
Load it back

Actual behavior
System throws exception: Convert error! Error during file parsing.

Expected behavior
System saves and load ket file correct:

As per requirements:
There should be possible to load such monomers from IDT and KET formats and save to these formats.

Versions

Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
Windows 10 Pro
Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - https://github.com/epam/ketcher/issues/4431

Verified

Versions:
Ketcher Version 2.23.0-rc.2 Build at 2024-07-10; 19:39:22
Indigo Version 1.22.0-rc.2.0-ga21fb5d8f-wasm32-wasm-clang-19.0.0
Chrome Версия 126.0.6478.127 (Официальная сборка), (arm64)
MacOs Sonoma 14.5


How to use it

I got this error as in the screenshot. Can you explain how to use the software? thank you, like how to make a workspace

The top menu bar -> Edit

When display workspace, click plus icon

thanks


Add CSRF error page

Currently when CSRF verification fails, one gets a (very) ugly Django error view. It would be better to provide a nice error page with some resolution options (like the current error views for 400/404/500/etc).
The trick would be how to explain people to do a fresh refresh instead of a normal reload (as a normal reload reloads the HTML, and thus the CSRF token, from the local cache).

See also https://docs.djangoproject.com/en/4.0/ref/settings/#csrf-failure-view

Check out: /Users/Stiph002/Projects/ethics/main/templates/error

Closed with PR #356


Add Bidoo

I can’t understand how to delete my account in Bidoo.com

Please make it clearer what your request is. The way it is phrased, it seems like the instructions we provide aren't clear, but there's no "Bidoo" in our files.
If you want to know how to delete it, we can't really help, generally people find out and tell us so we can populate the page and help others in the future

I’m sorry. I was asking for instructions. Anyway I find out that the only way to delete an account on the site Bidoo.com is to contact the staff and ask for it.
If you want to add the site to the list I’ll help giving the link of the contact form. Otherwise I’ll just close this issue

It's alright. We can either add a link to the contact form or the e-mail, if you have it, but sure, do provide it so we can improve our database. Thanks!

I can’t get the link because they deleted my account already (without notify me).
Anyway I just opened the contact form asking if they could delete my account.

That's fine, we can work with that information. Do you remember if you needed to give them any specific information for them to delete your account?

No. I didn’t give any specific information. I just had to confirm with a second message

So the steps that occurred were:

You visited the site, opened the contact form, and requested account deletion (without providing any account info?)
They messaged you back (how did they do so?)
You responded to that message (again, how did that occur--email or something else?)
They deleted your account

If you can help fill in the gaps, we can add a card with steps to delete an account from this site. Thanks in advance!

(1) You can write on the contact form I used (by clicking on the link “assistence” in the website) only after you logged in the website, so I just provided my email address even if unnecessary.
(2) When they reply I got an email which just report that they have replied. I clicked the link on the email, access again on the website and I could see their answer in a sort of a chat page.
There I confirmed my intection to delete the account and nobody replied me or sent me any email, but if I now try to log in with the same email, the account is inexistent.


JSon Parsing Error, nested template

When I embed an empty nested template I receive teh following error
ConvertFrom-Json: C:\Users\ARM\Source Code\GitHub\drewkg\Azure\ARM\Policy\DiagnosticSettings\LogAnalytics\ARM-TTK\arm-ttk\Expand-AzTemplate.ps1:304:51                                                                                LLine |                                                                                304 |                  $TemplateObject = $TemplateText | ConvertFrom-Json                                                                                |                                                    ~~~~~~~~~~~~~~~~                                                                                | Conversion from JSON failed with error: Additional text encountered after finished reading JSON content: :. Path '', line 1,                       | position 10.
The nested section, taken from a Bicep repository, converted into ARM, is as follows
"resources": [
{
"name": "getManagementGroupName",
"type": "Microsoft.Resources/deployments",
"apiVersion": "2019-10-01",
"location": "[parameters('location')]",
"properties": {
"expressionEvaluationOptions": {
"scope": "inner"
},
"mode": "Incremental",
"template": {
"$schema": "https://schema.management.azure.com/schemas/2019-08-01/managementGroupDeploymentTemplate.json#",
"contentVersion": "<IP_ADDRESS>",
"resources": []
}
}
},
This provides the ability to retrieve the current Management Group name that the deployment is being run against.

The same issue. We have some ARM templates that contains nested templates. ARM TTK generates two errors for these templates:
Conversion from JSON failed with error: Additional text encountered after finished reading JSON content: :. Path '', line 1, position 10."
Empty property:  {} found on line: 50"
A sample template is attached.
applicationInsights.zip

I am not sure if this is related, but this template https://raw.githubusercontent.com/drewkg/Azure/feature/ARMTTK/ARM/Policy/DiagnosticSettings/LogAnalytics/azuredeploy.json
is still causing issues when parsing the json, the error message from AzDO pipeline is ##[error]ConvertFrom-Json : Invalid JSON primitive:  {}{

@drewkg - can you open a new issue for this one?  Feel free to cross ref this one...

@bmoore-msft will do, I am trying to distil down to the smallest possible reproducible.

appreciated for sure...


Error while creating new page with index page

I am trying to create new page with index page , so in this case i want only main menu bar and footer , but when i tried to to remove the<header class="masthead">tag , menu background black color vanish , Question is how to get only menu bar in new page
For more detail :
https://stackoverflow.com/questions/55088738/fails-to-get-only-menu-bar-in-a-new-page-from-the-agency-bootstrap-theme

The menu bar starts in a transparent background state and then changes to a darkened background when the page is scrolled. If the masthead is removed, then the navigation is still there, just the background is transparent and the lettering is white.
What you would need to do is change the base CSS of the navbar, or add the .navbar-shrink class to the navbar by default.


Class "App\Utils\CheckDotEnv" not found

Installed on MacOS Ventura :
❯ ./ai-terminal execute

In OpenAIServiceV1.php line 35:

  Class "App\Utils\CheckDotEnv" not found

❯ sw_vers
ProductName:		macOS
ProductVersion:		13.3.1
BuildVersion:		22E261

Can you try to manually create the .env file in the root of the project?
The content of the .env file shoud be:
# OpenAI
OPENAI_API_KEY=your_api_key

Ok, I've found the issue. It happens only in the builded version of the project.
You can still use it running ./ai-terminal from the root of the project.
We'll get back as soon as we solve the issue.

I should have fixed the issue. Can you please test if it's working correctly?
Thanks


CRD numatopo scope change namespaced to cluster

Signed-off-by: huone1<EMAIL_ADDRESS>

/lgtm
overall, it's lgtm.

/approve
/lgtm

I'll merge this PR for the sign-off is already signed.


Don't reexport Specta

This might be a duplicate but don't forgor in the next major

finally lets goooooo

This is done under the "unstable" feature (Basically for Spacedrive) but part of the v1 stabilisation this will be done for everyone.


Conflict of nanoflann namespace issue

Hello Koide, thanks for sharing this nice stuff.
I tried to include this repository, and I found that once the repository already contains nanoflann.hpp, then two nanoflann.hpp brings namespace conflict error.
Of course, it's very easy to resolve by manually changing the workspace name in the own package, but maybe we have to change the namespace of nanoflann.hpp in this repository for better usability (e.g., namespace koide_nanoflann or something)
Thanks!

Thanks for reporting the issue. I recently re-implemented KdTree, and I'm considering to replace nanoflann with the new KdTree. It would resolve the conflict and bring (very slight) speed improvement.

I replaced nanoflann with a new KdTree implementation in this PR https://github.com/koide3/small_gicp/pull/42 that would resolve the conflict. I'll merge it once some errors on windows are fixed.


Use Option key to add a recent folder to the current workspace

In the recent files command menu (CTRL+R), selecting a folder opens the folder in the current window, replacing the current workspace. On Mac, the menu suggests using the Option key to open items in the same window, but since this is the default action, it might be handy if it added folders to the current workspace instead.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


how can i define a custom url mapping for health check ?

i am using a combine  of  kubenetes and spring-cloud ,
when  i deploy spring-cloud-config , sometime health check shows the appliaction is  not health :
messages show below ：
curl localhost:8888/health
{"status":"DOWN","configServer":{"status":"DOWN","repository":{"application":"app","profiles":"default"},"error":"org.springframework.cloud.config.server.environment.NoSuchLabelException: No such label: master"},"discoveryComposite":{"description":"Discovery Client not initialized","status":"UNKNOWN","discoveryClient":{"description":"Discovery Client not initialized","status":"UNKNOWN"}},"diskSpace":{"status":"UP","total":845373399040,"free":766472146944,"threshold":10485760},"refreshScope":{"status":"UP"},"hystrix":{"status":"UP"}}#
and i hope my app can restart automatic when it is not healthy ，so I  need a custom url mapping for healthy check  in spring-cloud-config-server ， such as
@RequestMapping(value = "/checkalive")
public String checkAlive() throws IOException {
// logic to confirm server health status
return "OK";
}
but it seems custom url mapping are not userful in spring-cloud-config-server .
so  how can i define a custom url mapping for health check ?
my app-version with spring boot is 1.3.5 , is that  related ？

after moving a special annotation ,the problem solved :@EnableAutoConfiguration


QR Reading for Checkin

Just a cool feature I wanna add

QR scanner in but not hooked up to any backend logic

Backend logic to associate QR with user account & use QR for event checkin #109


Issue with WebActivator dependency

Getting this error during install -
install-package : Unable to find dependent package(s) (WebActivator)
I installed it manually using Install-Package WebActivator -RequiredVersion 1.5.3, but TheMVCForum still errors out.  Also tried 1.5.2, same error.

I am using 1.5.2 and do not see 1.5.3 available, can you remove and reinstall 1.5.2. Alls well with my copy. recent pull.


Validate uniqueness of Node table in core

Having a duplicate edge (#1255), results in a late error while writing results. We should add validation code to check for duplicates in the Node and Edge tables.
For Node this means the combination of node_type and node_id must be unique.
For Edge this means the combination of from_node_type, from_node_id, to_node_type and to_node_id must be unique.

I noticed that this gave problems in the core, so I added this in my flow_demand branch for duplicate edges:
https://github.com/Deltares/Ribasim/blob/d6ff7af2ee6e46e6ae96d709a5411e608d9548f7/core/src/graph.jl#L81C1-L84C12

Great, I updated the issue to just cover the Node case.


Rancher 2.3 vsphere Cloud Provider Issues

**What kind of request is this : bug
I have just try Rancher 2.3 and created a new cluster and adding the cloud_provider setting in the yaml the same way I did it in Rancher 2.2.8
I am adding the cloud_provider at the bottom of the YAML file
cloud_provider:
name: "vsphere"
vsphereCloudProvider:
global:
insecure-flag: true
soap-roundtrip-count: 0
virtual_center:
myvc:
datacenters: "CLOUD"
soap-roundtrip-count: 0
user<EMAIL_ADDRESS>password: "MyPassword"
workspace:
datacenter: "CLOUD"
default-datastore: "vsanDatastore01"
folder: "Rancher"
server: "myvc"
But for some reason rancher is not automatically deploying the PVC, I have tested this multiple times, and in 2.2.8 it works perfectly in 2.3 it’s not ?
Result:
Cloud provider not initialized properly
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
2.3.2
Installation option (single install/HA):
Single

Cluster information

Machine type VM

Docker version (use docker version):

(paste the output here)

@Spookman With 2.3 , we need to have the cloud_provider:  section created under the rancher_kubernetes_engine_config section .
Could you please try having the  cloud_provider:  section under rancher_kubernetes_engine_config section and see if the cloud provider settings works ?

@sangeethah Thanks for the response, I have re attempted this under the rancher_kubernetes_engine_config which I am sure I have always done, but this is still having the same problem. just to iterate the same cloud_provider config works 100% in Rancher 2.8.x

I have found the issue, it's was an incorrect line in the config file,


Adding Trion Interactive bidder documentation

Hi @grohm33 - I'm not seeing a Trion Interactive on http://prebid.org/download.html or in the list of adapters in the repo.  Is there an open Prebid.js adapter PR I missed?

@rmloveland We have an open pull request for our adapter at https://github.com/prebid/Prebid.js/pull/1059 awaiting approval still.  I was told to submit a documentation pull request here along with it.

@grohm33 great, thanks!  As soon as it goes out in the next release (and the Prebid.org downloads page is updated) we can merge this in.

@rmloveland Alright sounds good!  It says in the documentation not to submit a pull request for the downloads page so i omitted that.  Is that something that will be taken care of on your end or should I add that to the PR.

Thanks @grohm33, sorry it took so long to merge this in!


🐛 [firebase_database] .once() returns a stream

v 6.1.2
I am querying my db .once() using riverpod. The app does not stop loading and it prints the result like every second
class RealTimeService {
  final FirebaseDatabase _rtdb;

  RealTimeService(this._rtdb);

  Future<DailyModel> getStats(DateLocation dateLoc) async {
    try {
      String dateString = DateFormat("ddMMMyyyy").format(dateLoc.day);
      DatabaseReference locationRef = _rtdb.reference().child('daily/$dateString').child(dateLoc.myID);
      return await locationRef.once().then((snap) {
        if (snap == null || snap.value == null) {
          return null;
        }
        print(snap); // prints snap continuously
        return DailyModel.fromSnap(snap);
      });
    } catch (e) {
      print(e);
      return null;
    }
  }
}

final realtimeDBProvider = Provider<FirebaseDatabase>((ref) {
  return FirebaseDatabase.instance;
});
final realtimeDB = Provider.autoDispose<RealTimeService>((ref) {
  final _rtdb = ref.read(realtimeDBProvider);
  return RealTimeService(_rtdb);
});

final statsProvider = FutureProvider.autoDispose.family<DailyModel, DateLocation>((ref, dateLoc) {
  return ref.watch(realtimeDB).getStats(dateLoc);
});

in the db data looks like
- daily
   -date(ddMMMyyy)
      -someID
         -dailyStat1
         -dailyStat2

in the widget build I have
    final _today = DateTime.now();
    final _todayStats = useProvider(statsProvider(DateLocation(day: _today, myID: myID)));
....
              Container(
                  child: _todayStats.when(
                    data: (stats) {
                      return Text(stats.dailyStat1.toString());
                    },
                    loading: () => Center(child: CupertinoActivityIndicator()),
                    error: (err, stack) {
                      print(err);
                      print(stack);
                      return Center(
                        child: Text("Err"),
                      );
                    },
                  ),
                ),

This looks like a misuse of Riverpod instead
You passed the current date to a provider as a family parameter. This means whenever that date changes, this will re-fresh the stats.
Bear in mind that DateTime.now also includes seconds and milliseconds. So your provider is going to refresh basically all the time.
You may want to pass only the day as a parameter, not the complete date.

@rrousselGit
I've removed the the DateTime.now from the build
and changed the getStats to
String dateString;
      DateTime _now = DateTime.now();
      final _today = DateTime(_now.year, _now.month, _now.day);
      dateString = DateFormat("ddMMMyyyy").format(_today);

You also need to make sure that DateLocation overrides ==

This is my DateLocation class
enum SelectedDay { TODAY, TOMORROW }

class DateLocation {
  SelectedDay day;
  String locationID;
  DateLocation({
    @required this.day,
    @required this.locationID,
  });
}

How can I override it

@wazini-john
Can you provide flutter doctor -v and flutter pub deps -- --style=compact?
Since riverpod is 3rd party plugin, can you try without it and see if you still get same behavior ?

Flutter Doctor
[✓] Flutter (Channel stable, 2.2.0, on macOS 11.3.1 20E241 darwin-arm, locale en-KE)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.2)
[✓] VS Code (version 1.56.2)
[✓] Connected device (3 available)

Pub Deps
- cached_network_image 3.0.0 [flutter flutter_cache_manager octo_image]
- cloud_firestore 2.2.0 [cloud_firestore_platform_interface cloud_firestore_web firebase_core firebase_core_platform_interface flutter meta]
- cloud_functions 1.1.0 [cloud_functions_platform_interface cloud_functions_web firebase_core firebase_core_platform_interface flutter]
- cupertino_icons 1.0.3
- firebase_analytics 8.1.0 [firebase_analytics_platform_interface firebase_analytics_web firebase_core flutter meta]
- firebase_auth 1.2.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_database 6.1.2 [firebase_core flutter]
- firebase_remote_config 0.10.0-dev.4 [firebase_core firebase_core_platform_interface firebase_remote_config_platform_interface flutter]
- firebase_storage 8.1.0 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_barcode_scanner 2.0.0 [flutter flutter_plugin_android_lifecycle]
- flutter_hooks 0.17.0 [flutter]
- georange 1.0.0
- google_fonts 2.1.0 [flutter http path_provider crypto]
- google_sign_in 5.0.3 [google_sign_in_platform_interface google_sign_in_web flutter meta]
- hooks_riverpod 0.14.0+4 [collection flutter flutter_hooks flutter_riverpod riverpod state_notifier]
- http 0.13.3 [async http_parser meta path pedantic]
- image_picker 0.7.5+2 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface image_picker_for_web]
- intl 0.17.0 [clock path]
- location 4.1.1 [flutter location_platform_interface location_web meta]
- package_info 2.0.0 [flutter]
- qr_flutter 4.0.0 [flutter qr]

Try:
class DateLocation {
  DateLocation({
    @required this.day,
    @required this.locationID,
  });

  final SelectedDay day;
  final String locationID;

  @override
  bool operator ==(Object other) {
    return other is DateLocation && other.day == day && other.locationID == locationID;
  }

  @override
  int get hashCode => runtimeType.hashCode ^ day.hashCode ^ locationID.hashCode;
}

In any case, this looks like a misuse of Riverpod, not an issue with FlutterFire. So I'm going to close this issue.

@rrousselGit  How is it a misuse of Rivepod ?

As stated by the documentation, parameters of family must override ==


Test on Nightly but allow_failure.

I'm not sure if it's useful to test but allow failures - I only go and look at Travis when there is a failure, so I won't usually see any failures that only occur on nightly. Can Travis build with the 3.6 betas yet? If so,  I might add that as a target and not use allow_failure.

Can Travis build with the 3.6 betas yet? If so, I might add that as a target and not use allow_failure.

Not yet (AFAICT) and it seem to me that  current "nightly" point to the 3.6 branch.
Agreed that once we have a 3.6 target we can add it without allow_failures. The problem for now is that most of the failures are due to bug upstream so almost all of repo would fail with unfixable errors. While ipykernel pass (which I'm surprised about) everything that touch traitlets will be kill because of an out of memory error.
Testing on nightly ( or for that matter 3.6-betas once that target exists) allows us to know when the upstream bugs are fixed.
Travis Build of nightly seem also a bit buggy:
$ export PYTHONWARNINGS='ignore'; python -c 'print(1)'
'import warnings' failed; traceback:
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.6-dev/lib/python3.6/warnings.py", line 496, in <module>
    _processoptions(sys.warnoptions)
  File "/home/travis/virtualenv/python3.6-dev/lib/python3.6/warnings.py", line 178, in _processoptions
    _setoption(arg)
  File "/home/travis/virtualenv/python3.6-dev/lib/python3.6/warnings.py", line 184, in _setoption
    import re
  File "/home/travis/virtualenv/python3.6-dev/lib/python3.6/re.py", line 122, in <module>
    import enum
ModuleNotFoundError: No module named 'enum'

I only go and look at Travis when there is a failure, so I won't usually see any failures that only occur on nightly.

I check Travis more often, and i think it is useful to know when upstream have broken something, it allows you to report the bug immediately. If we had been testing on nightly beta1 would never have been released with http://bugs.python.org/issue28147 and I got another segfault corrected upstream because of nightly +allow_failures testing.
I'm also poking at travis API and looking as whether I can get all the project that test on nightly & 3.5 through time and look at the evolution of nightly-failure/3.5-success and see if I can autodetect nightly regression at a day or so granularity; Or even during the Python 3.6 Beta get an indicator of projects "Compatibility" with 3.6.

I don't want to do this in flit with 'nightly' at the moment:

If we're bothering to run tests, I don't want allow_failures - I want to know about it when tests fail
If the tests do fail, it wouldn't be obvious whether it's because of a change in flit, a change in Python, or a bug in Travis' build of Python (as in your example above).
This is exacerbated because flit is not changing very quickly at the moment, so nightly could change a lot between flit builds, and we're unlikely to pick anything up promptly.

During the 3.5 betas, you could ask Travis to build on e.g. 3.5.0b1. This was based on pyenv, which has recently added 3.6.0b1 (yyuu/pyenv#699). If that works on Travis, I'd be happy to start testing with the numbered betas.


Jesse: Watch stride.marketing

Jesse requests the watch of the watch_keyword stride\.marketing. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Makyen in Charcoal HQ


Fix a command error in configure-service-account.md file

kubectl patch command no longer need insert '\' at all.
This patch fix this.

/lgtm

/approve


Linking error when enabling GPIO_INTR

Hi there, attempting to enable the GPIO_INTR ( esp32_hal::interrupt::enable(Interrupt::GPIO_INTR); ) results in the following linking error. Thanks in advance.

Are you trying to use esp32-hal in a std application, like https://github.com/ivmarkov/rust-esp32-std-hello? Whilst I'd like this to work in the future, this is currently not a supported configuration.
I would say use the idf-hal implementation but this does not have support for Interrupts just yet.

Thanks for the quick response. That is exactly what I am trying to do. Yes, I noticed that too which is why I tried the esp32-hal crate. I'll leave the interrupts for now.
Should I close this one?


Gas-efficiency improvements

We use this in ENS for verification of P256 signatures on DNSSEC records, and the gas cost of verifying a signature is a significant barrier.
We're interested in offering a bounty for work on improving the gas efficiency of the library. Would this be of interest? If not, do you know anyone else who might have the necessary skill to take such work on?

Hi there,
I have been worried about the cost as well. Unfortunately, I myself do not have the time to work on this right now, nor do I know anyone who might.
One solution to this problem that I thought about was the following: Instead of actively verifying a signature, just publish it on chain alongside a temporary deposit. Add logic that allows anyone to kick off the signature verification on chain. If a signature is found to be invalid / does not pass verification, the deposit goes to whoever called the verification function.
If the deposit exceeds the costs of verification, the equilibrium should be that only valid signatures get posted since all invalid ones will be successfully challenged / invalidated. Once some time has passed without a valid challenge to the signature, the deposit gets refunded to whoever posted the signature. I suspect that the on-chain costs of this scheme should be substantially smaller than actively verifying signatures.

That kind of challenge system will be viable for some applications; however, it adds a significant amount of complexity, and I don't think it's viable in our case.


Don't build tests on default

Introduce CMake option to enable building of tests. Deactivate building tests on default.

Should be fixed now.


KTL-Toolkit Developer Button Positioning Issue

I found another minor issue with the Toolkit button not staying in position:
https://vimeo.com/839091757/d2488f4364
Dean

Hi Dean,
Can you manually set your KTL version to 0.13.8 to see if it fixes the bug please?
Norm

Dean, I took the liberty to change your issue title a bit.
You are actually referring to what is called the Version Info Bar.
Closing this issue now, thanks for reporting.
Norm


[FEATURE] Enable modern preload bundles without dependencies

Follow up of https://github.com/SAP/ui5-builder/pull/734, which GitHub didn't update any more after a certain force-push.
Currently, when building a UI5 project without dependencies, the legacy
bundle format is used. This change defaults to the new bundle format and
removes any checks for the existence of core modules from the bundle
Builder.

bundle/Builder: Remove checks for existence of core modules and
replace them with bundleOptions "decorateBootstrapModule" and
"legacyBundleFormat"
generate(Component|Library)Preload: Stop globbing dependency resources

Coverage increased (+0.04%) to 94.926% when pulling 410e6fb9ff6b00d84b5c63799b34223118f7f5f3 on dep-less-preloads into be03519fb339ba89d09261175191aa57ea346271 on next.


⚠ Bofrost.at has degraded performance

In 522e608, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 939 ms

Resolved: Bofrost.at performance has improved in 24a25b0 after 13 minutes.


Credit icon

Describe your problem here. If you are modding, please try testing your problem in a clean version of the engine instead, this ensures the problem is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
how do i use le credit icon
i have no damn clue how to use it nor do i see a way how to-
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Create a folder at mods/images/credits and just put some image here.
For Credits follow this:

i meant in like a song
cuz in the song a 'credit icon' can be applied
is it the same way as that or is it different?

to put a song's credit icon, you have to put the name of the credit icon's png here

To make the credit icon work, it must be placed inside mods/images/songCreators/. the same applies for credits bars, they must be put in mods/images/songHeadings/.


Add easings.net

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Board Login must be explicitely more lenient on spaces and case sensitivity

Building on Issue 259
Related to the backend database change from mySql to PostGres

Board Names in database, login form, and board creation form must be considered matching even if one of the string has leading or trailing whitespace
Board names in database, login form, and board creation form must be considered matching when the characters match in a case-insenitive manner
Board name creation must trim leading & trailing whitespace such that team name "My New Team " is saved as "My New Team" with uri "my-new-team" rather than saved as "My New Team " and uri "my-new-team"

With regard to the word matching above:
This means when board names match, login should succeed, and new board creation should fail because an existing board has been found.

Fixed in PR #262


Optimize modules release time

We should run with -m option to enable parallel uploads. Additionally, we should run with either -c or -i instead of the default (which compares modification time). Since files are sync'd from a actions/checkout git clone, all of the files mtimes are set to the time of checkout, so the default behavior will be to copy every file every time.

Lovely! thanks so much


chore(apps/gcp/prow/release): bump image for hook to v20230927-01102e9c12

[x] tested in dev env.

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

Test passed
OWNERS file: confg/OWNERS
# REF: https://www.kubernetes.dev/docs/guide/owners/#owners
options:
  no_parent_owners: true
filters:
  "config\\.toml\\.example$":
    approvers:
      - zuo-bot-1
  ".*":
    approvers:
      - zuo-bot-2

Changed files:

config/config.toml.example
config/hello.txt

Tests

Need approval for all all changed parts.

parent owner has no effects when not inherit and with default regex set.

all parts are approved.

/approve


Movie Ticket Pricing System

Description 📜
I have explained all the necessary information and code regarding it.
Fixes #6951

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Datascience with Python

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@prathimacode-hub Ma'am I have committed the changes .Please evaluate it.

@prathimacode-hub Ma'am I have committed the changes. Please evaluate it.


Fix PBMC sample participants

https://github.com/populationgenomics/sample-metadata/pull/113 Assumed a 1:1 relationship between samples and participants for the entire TOB-WGS project. However, this is not the case for the PBMC samples. This script modifies the PBMC samples' participant data appropriately.

See https://github.com/populationgenomics/sample-metadata/pull/120


feat: poc for new bar chart

This is the POC for the new chart. Suggestions are welcome.
The idea is to build a chart component with more flexibility in the configuration, while avoiding to have to manage a complex options object for Chart.js.
This is a work in progress, keep in mind:

There is a lot of config options in Chart.js still missing, until now I've ported only the necessary to fulfill the example
Docs for the prop-types are almost 100% missing
We need to add a few more stories
And we need a lot of tests

I will keep working on this, but early feedback is much appreciated ;)

we gonna close this for now


added support for big numbers and sending > 9007 XCH

added support for big numbers and sending more than 9007 XCH
fixed formatting for big numbers

There are a small number of files that still use JSON.parse() and JSON.stringify(). Should we be using JSONbig everywhere, and if so, is there some way we can enforce its usage (custom ESLint warning?)

packages/wallets/src/components/offers/OfferEditorRowData.ts

spendBalance should be BigNumber because in packages/wallets/src/components/offers/OfferEditorConditionsPanel.tsx, there is line:balance = mojoToChia(walletBalance.spendableBalance);
...
row.spendableBalance = balance;

packages/wallets/src/components/offers/OfferEditorConditionsPanel.tsx

Line61: if (balanceString !== row.spendableBalanceString || balance !== row.spendableBalance) {
balance is BigNumber so native !== does not work.

packages/gui/src/components/block/Block.jsx

Line307 ${baseFarmerReward} ${currencyCode}:
baseFarmerReward is BigNumber, so by including in string template, BigNumber.toString() is implicitly called.
BigNumber.toString() can be 2.5e-11. Is it allowed? If not please consider using BigNumber.toFixed()

packages/gui/src/components/farm/card/FarmCardBlockRewards.tsx

Need to check and update whole lines.

packages/wallets/src/components/did/WalletDID.tsx

Line 615. {mojoToChiaLocaleString(props.balance)} TXCH Is this OK? Maybe not relevant to this PR though.

packages/gui/src/util/chia.js

Replace big.js with bignumber.js for whole lines.

packages/gui/src/types/Transaction.ts

Shouldn't type of amount, sent and fee_amount be number|BigNumber?


[RFC] Support for exclusive cert pinning

Sending this structure out for comments before I proceed with implementation on Windows/Linux

The pinning logic seems reasonable, but I'm not sure about the algorithm stuff.

i'd like to consider renaming disable_built_in_certs() to something else that better represents our intent.
rust-native-tls does not have any built-in certificates. instead, we want to use an empty store with no roots. if you agree, may i suggest a name like empty_root_certificates()?


Syntax highlighting should differ between class variables and local variables

Godot version:
3.0
OS/device including version:
Issue is platform agnostic
Issue description:
Both class member variables and local function variables use the "Text Color" syntax color value (and not the "Member Variable Color"?).
Distinguishing these colors, even in relatively small scripts, can be helpful. For comparison, see:
GDScript:

IntelliJ (Java):

Steps to reproduce:
Just create a script with class fields and local fields in it, e.g.
extends Node2D

const CONST_VAR = 10
var class_var = 0

func _ready():
	var local_var = CONST_VAR
	class_var += local_var

Expected: CONST_VAR and class_var should use member variable highlighting, while local_var should use text color highlighting.
Minimal reproduction project:
Not included, as issue is trivial to reproduce.

Opening an issue to see if the team agrees with the issue as written, before I spent too much work digging into it.
I've also tried to take a look at the code to see if this would be trivial or not, but I'm still learning and can't tell. It might be tricky if the syntax coloring phase happens before we know whether a variable is a class variable or local variable.
Also, what is the "member variable color" for, if not currently used for member variables?

@gamesoil it's probably for this syntax:
obj.member_var

Ah, thanks, you're right. If I type self.class_var, it's colored correctly.
I still think it would be nice if it was possible to color other class variables the same way. Especially I noticed when I was going through sample code, it was hard at a glance to know which functions were part of the function and which were part of the class.
For example, glancing at code like this (extracted from the Instancing 2D sample):
if ...:
   jumping = false
if ...:
   jumping = true

prev_jump_pressed = jump

is jumping local? Is jump local? Is prev_jump_pressed local? It's not the hardest thing to figure out, but you have to scroll around the file to find out, which results in losing focus for a few moments to answer what should be a simple question.
It could also help identify if someone accidentally shadowed a class variable with a local variable:
var should_jump = false

func _physics_process(delta):
   ...
   var should_jump = false // Whoops! Someone added without realizing the collision
   ...
   should_jump = true // Potentially subtle bug...

My suspicion is we don't know this information at coloring time, however.

Related (duplicate?) to #8080

I see value in coloring variable names at different scopes in different colours/shades.  However my biggest issue presently is distinguishing const from mutable variables.
I would dearly love if the names of const variables were a different colour.

@ZodmanPerth The convention is to use UPPER_SNAKE_CASE for constants, so they're distinguished by their casing.
Personally, I'd value distinguishing local and member variables over distinguishing mutable and immutable variables (even if we do add actual immutable variables in the future). Having both is probably not a good idea, we don't want to use too many syntax highlighting colors to preserve visual consistency.

we don't want to use too many syntax highlighting colors to preserve visual consistency.

It wouldn't probably hurt to have them as an option, with defaults having same colors in some cases.

Conventions are personal and shouldn't be enforced (or required) by the framework.  Coming from a C# background I use different conventions for casing than someone from Python (for example).
const symbols are special, and deserve their own highlight colour.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Since no one wrote a proposal for this it seems, I've gone ahead and submitted one - in case anyone ever revisits this thread.
https://github.com/godotengine/godot-proposals/issues/6428


Enhance opentelemetry-demo to demonstrate OTel correlation and contextualization

Feature Request
Enhance the opentelemetry-demo to demonstrate Instana correlation and contextualization capabilities with OTel data.
Basically, this item includes a tutorial (a doc) to setup Instana and opentelemetry-demo, then go through the correlation and contextualization features along with tips and best practices. During the time, figure out the gaps within opentelemetry-demo and fill the gaps by contributing back to the upstream repo.
Some demonstration areas including:

Correlation:

Correlation via service.name
Correlation via peer.service
Correlation specific in k8 env, via service.name, service.instance.id, process.pid, container.id, host.id, k8s.pod.uid.
The use of spanmetrics
(Advanced) Combination with Instana agent, e.g.: for IBM Middleware

Contextualization:

Contextualization via tags for different supported technologies, e.g.: HTTP, RPC, databases, messaging systems, and more.

We can define some specific scenarios for demo purpose by following: https://opentelemetry.io/docs/demo/feature-flags/.


Root Element is missing?

When I started coding 3 days ago, I tried to run my code. It doesn't work when I input "dotnet run" in the terminal because it says that the root element is missing. I tried uninstalling and installing the SDK download, but that doesn't work. Any suggestions?

Hi @D8G
I believe you don't need to use the command "run". You just need to provide the filename after "Dotnet", like:
dotnet myapp.dll
You should be able to run without any issue. However, if the issue still persists please share the complete version of dotnet you are using.
You can refer the document:
https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-run
Thanks

Off the top of my head it sounds like your .csproj is corrupt.  It should be an XML file that has Project as the root element.  Usually it's pretty slim, like
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
  </PropertyGroup>

</Project>

though probably with a newer TargetFramework value.
If you've correupted your project file you can create a new project with dotnet new, and the same project kind (e.g. dotnet new console) in a clean directory, then copy the project file from that other directory over top your original one.


Vendor endpoint is not ready for provider calls when resuming from pod crash

Scenario:

An activation activates a campaign and pod crashes when one of the stages is running
pod resumes
pubsub state provider is resumed first, starting to retrieve pending messages from redis server.
One of the stages resumes from the trigger events and execute the provider. The provider may send requests for symphony objects CRUD operation to vendor endpoints. However, the vendor may be not ready at this point so the provider fails.
the trigger events save "Failed" result in the activation and completed successfully.

Result: All the stages which failed to call vendor endpoints will end with Failed result and stops activation execution.

We will consider to add retry in apiclient to keep retrying in retriable error.


[GH-#322] Epoch gossip API

closes #322

One important endpoint in epoch is /ping I think

yes, sync works

@d-velev do you still plan on adjusting this? https://github.com/aeternity/elixir-node/pull/323#pullrequestreview-109725072

I will adjust it in a moment


Support map "includes" to a different directory in site-packages

Currently the includes will be copied to site-packages as it is. For example, if I have includes = ["path/to/foo"], then path/to/foo will appear in the site-packages. Can we support mapping this path/to/foo in the source tree to a different directory in site-packages? For example, I might want to be able to do import foo after installing my package, so I would want path/to/foo in the source tree to be installed to foo in site-packages. That adds flexibility in the backend.

set package-dir config to path/to: https://backend.pdm-project.org/build_config/#the-src-layout, which means path/to/foo will be importable as import foo
This works the same as the equivalent in setuptools:
setup(
    package_dir={"": "/path/to"}
)

Yeah package_dir works, but it is a common value for all includes. I would like to have a way to customize the installation path for each includes.
For instance, if I am using the src layout, so the package_dir is by default src. Now my package in src/mypackage would be installed correctly. If I also have path/to/foo outside src and I want it to be installed to site-packages/foo, there would be no way to do it as far as I know.

Is there any special reason not putting it inside src/ instead?


mockhttp.Entry.collect can't really handle more than one request properly

mockhttp.Entry.collect does this:
self._sent_data += data
return super(Entry, self).collect(self._sent_data)
which means that apart from the first request, all subsequent requests are actually going to be using the first request headers, and the other requests as body data.

I think it should be fixed as well with my last merge.

This is still an issue;  the same 'entry' is reused for requests to the same host/port. mockhttp.Entry tracks _sent_data, and each request appends to _sent_data. but the entire _sent_data is sent to super.collect(), which is where it's passed into the Request class, and everything but the first _sent_data is truncated when the data is parsed.

Hi @ajhodges, do you have a specificfailing  test case for the problem you are referring to?

Sure - I've added a failing test case here:
https://github.com/ajhodges/python-mocket/commit/cbae40c5ab2821dcc38c6dcfbf8d91b6edb1322d
Both of these assertions are currently failing. Somehow there are 3 requests getting added when only two are made, and they all have the same data as the first request (the one with the query params)

Hi @ajhodges, I am working at a fix. The problem that makes your test fail has nothing to do with multiple requests.
It's a bug in managing the second sendall sent by requests when sending the JSON body. I am on it.

Just for clarifying: the fact that the same Entry is re-used is a mocket feature and it has been like that since the very beginning. The APIs have been consistent since we released it in 2013. If you need different responses for the same path you explicitly create two different entries.
In case you feel you have a problem which is similar to this please open a new issue, and add a snippet which shows your problem.


Exogenous input

This addresses #71 and is related to #48. I added support for exogenous inputs in all the methods for the standard (linear) case.

Hi can you explain better the usage for exgenous inputs? Is it possible to use it in the Unscented kalman filter? Can you provide an example?

@fedtf, this would be useful to include in pykalman. The active pykalman fork is now maintained in sktime, would you like to add this there?
sktime.libs.pykalman


add loading option for modal

i loved how you added loading option for Form component, it's so easy to build ui with such options. Would be great to have loading flag for modal too.
For now, I use segment as wrapper, while it has loading option.
return (
      <Modal open={true} onClose={handleClose} dimmer={true}>
        <Segment loading={foo.get('loading')}>
          <Modal.Header>...</Modal.Header>
          <Modal.Content>...</Modal.Content>
        </Segment>
      </Modal>
    );

Since loaders are CSS powered, this issue would need to be opened on the main Semantic-UI repo.  Our project only concerns itself with JS components that render down to valid Semantic-UI HTML.
Note the core Modal component has no loading variation: http://semantic-ui.com/modules/modal
The proposed workaround is a good solve as well.


Add TagHelper attribute targeting.

Transitioned HtmlElementNameAttribute into a more generic TargetElementAttribute. Targeting an HTML element can be done by attribute, tag or both.
Updated TagHelperDescriptor to track required attributes.
Updated TagHelperProvider to ask for provided attributes when resolving TagHelperDescriptors, this is used to apply RequiredAttributes.
Updated TagHelperParseTreeRewriter to properly track HTML elements that coincide with a TagHelper scope based on the presence of RequiredAttributes.
Added tests to validate TargetElementAttribute, TagHelperDescriptorFactory, CSharpTagHelperCodeRenderer and TagHelperParseTreeRewriterTests.
Renamed HtmlElementNameAttributeTest to TargetElementAttributeTest.

#311

Rebased, /cc @dougbu

@dougbu updated based on earlier discussion.

:watch: will look at the test changes once product code solidifies a bit.

Updated.

:watch:

Updates.

:watch:

Updated.

Updated TargetElementAttribute and corresponding dependencies based on our convo.

:watch:

Updated.

:watch: mostly for the tag helper recovery scenario and the public const availability

Updated.

:shipit:


feat: upgrade to grumbler scripts 8

DTPPSDK-957

Migrated to grumbler scripts v8.
Added flow-typed, jest, and cross-env as explicit dev-dependencies.
Added eslint override for test directory and removed /test/eslintrc
Added declaration for __DEBUG__ to resolve flow error

Codecov Report
Base: 95.63% // Head: 95.63% // No change to project coverage :thumbsup:

Coverage data is based on head (c12d40f) compared to base (123c702).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   95.63%   95.63%
=======================================
  Files          18       18
  Lines        1213     1213
=======================================
  Hits         1160     1160
  Misses         53       53

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[SEC-11864] system-probe: skip eBPF setup/cleanup when eBPF isn't required

What does this PR do?
This PR skips the Linux eBPF setup/cleanup when no system-probe module requires using eBPF.

Motivation
The event monitor/runtime security module implemented a new way to monitor syscalls that doesn't require eBPF.
Under this setup, running system-probe without the CAP_SYS_RESOURCE capability will make it fail to start even though eBPF isn't required.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Update ConversationsExtensions.xml

remove "(OPTIONAL)" from the activity argument for ReplyToActivity and ReplyToActivityAsync, because it isn't.

The API reference docs are auto-generated from the comments in the source code. You can update the comments in the source code, and submit a PR. The source code is here: https://github.com/Microsoft/botbuilder.


Wild Shape fixes + changes, DM Items menu

Wild Shape / Animal Companion - added Dire Wolf option
Added House Rule: Wild Shape Usable Items. Allow you to retain bonuses from some of your equipment while wildshaped (Bracers, Cloaks, Helmets, Necklaces, Rings) and to use potions.
Dungeon Master: Added Items menu to allow giving and spawning items. Including search by name.
Fixed Wildshape not changing size category
Fixed Wildshape not applying special monster conditions (such as Tripping Bite for Wolf/Dire Wolf, Fire damage/immunity for Fire Elementals)

Looked it through and the changes look good to me!  Will merge the changes.


Note for install with addon manager

Note for requirement.
freecad version 0.21.2
scipy needs to be installed.
If scipy is not installed the module it will not work.

Thanks, I added it to the README.


TrailingSlash using rewrite for a fetch call results on infinite loop

Hello team,
I was struggling with an infinite loop and blaming the cache on CloudFront. However, after some hours of research, the issue is with the trailing slash.
Explanation step by step:

I'm using Mixpanel to keep track of the users.
I created a rewrite to next.config.js to avoid ad-blockers blocking the request to Mixpanel made by the client (using only the browser version).
Mixpanel client will send the request as ${url}/track/ -> In my case, I will make a rewrite from /mp/:slug to their API.
Notice the last slash on track/ as that is the crucial part here.
Because I do not have set trailingslash=true, the redirect will be to ${url}/track instead of to the end API URL.
Loop

My investigation arrived here. I'm still researching why this creates an infinite loop because, from my understanding, it should double redirect to not trailing slash and then to the final API URL.
In localhost, the setup is working correctly.
To give it a shot, it will be as easy as installing mixpanel-browser and initialise with a rewrite, for example:
rewrites: () => [
    {
      source: '/mp/decide',
      destination: 'https://decide.mixpanel.com/decide',
    },
    {
      source: '/mp/:slug',
      // use "api-eu.mixpanel.com" if you need to use EU servers
      destination: 'https://api-eu.mixpanel.com/:slug',
    },
  ],

I tried enabling trailing slash, and then it worked as expected.
However, when using search parameters, something seems off.
Result when accessing to:
-> https://xxxx.cloudfront.net/mp/track?verbose=1&ip=1&=1697202041851
<- https://xxxx.cloudfront.net/mp/track?verbose=1&ip=1&=1697202041851///////////////////////////////////////////////////////////////////////////////////////////////
(Notice the loop)
Expectation:

No infinite loops
Does fetch need to handle trailing slash? Disable it if it is a fetch request.
Handle properly search params

UPDATE
I found something more.
On the file [Line: 176 && 191]: https://github.com/sst/open-next/blob/main/packages/open-next/src/adapters/routing/matcher.ts
If the URL contains search parameters, then that is when the infinite loop happens. I think considering search params on this redirect will fix the issue.
SOLUTION
On the file [Line: 176 && 191]: https://github.com/sst/open-next/blob/main/packages/open-next/src/adapters/routing/matcher.ts
const headersLocation = event.url.split('?');
    if (NextConfig.trailingSlash &&
        !event.rawPath.endsWith("/") &&
        !event.headers["x-nextjs-data"]) {
        return {
            type: event.type,
            statusCode: 308,
            headers: {
                Location: headersLocation[0] + "/" + (headersLocation[1] ? "?" + headersLocation[1] : ""),
            },
            body: "",
            isBase64Encoded: false,
        };
        // eslint-disable-next-line sonarjs/elseif-without-else
    }
    else if (!NextConfig.trailingSlash &&
        event.rawPath.endsWith("/") &&
        event.rawPath !== "/") {
        return {
            type: event.type,
            statusCode: 308,
            headers: {
                Location: headersLocation[0].replace(/\/$/, "") + (headersLocation[1] ? "?" + headersLocation[1] : ""),
            },
            body: "",
            isBase64Encoded: false,
        };
    }

Hi thanks for the investigation and fix, can you put up a PR and add some test cases around this?

Ey @khuezy yeah I'm on it. I'll update here when ready.

PR ready for review: https://github.com/sst/open-next/pull/280


Re-remove kotlin-reflect dependency

Something funky happened when #1151 was merged - this fixes the build which is currently failing.
Fixes #1179 closes #1180

Can this be merged so that work on `master can continue?


Align module exports with webpack

System Info
System:
OS: macOS 12.4
CPU: (10) arm64 Apple M1 Max
Memory: 22.38 GB / 64.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 20.5.0 - ~/Library/Caches/fnm_multishells/61564_1700104358947/bin/node
Yarn: 1.22.17 - ~/.yarn/bin/yarn
npm: 9.8.0 - ~/Library/Caches/fnm_multishells/61564_1700104358947/bin/npm
pnpm: 8.10.5 - ~/Library/Caches/fnm_multishells/61564_1700104358947/bin/pnpm
bun: 0.8.1 - ~/.bun/bin/bun
Browsers:
Chrome: 119.0.6045.105
Safari: 15.5
Details
I've noticed that rspack build artifacts are typically larger than what webpack generates.
One of the contributing factors is how exports are generated.
Example file:
export const variableWithLongNameOne = 'one';
export const variableWithLongNameTwo = 'two';
export const variableWithLongNameThree = 'three';
export const variableWithLongNameFour = 'four';
export const variableWithLongNameFive = 'five';
export const variableWithLongNameSix = 'six';

webpack will generate the following code:
/*!**********************!*\
  !*** ./src/index.js ***!
  \**********************/
__webpack_require__.r(__webpack_exports__);
/* harmony export */ __webpack_require__.d(__webpack_exports__, {
/* harmony export */   variableWithLongNameFive: () => (/* binding */ variableWithLongNameFive),
/* harmony export */   variableWithLongNameFour: () => (/* binding */ variableWithLongNameFour),
/* harmony export */   variableWithLongNameOne: () => (/* binding */ variableWithLongNameOne),
/* harmony export */   variableWithLongNameSix: () => (/* binding */ variableWithLongNameSix),
/* harmony export */   variableWithLongNameThree: () => (/* binding */ variableWithLongNameThree),
/* harmony export */   variableWithLongNameTwo: () => (/* binding */ variableWithLongNameTwo)
/* harmony export */ });
const variableWithLongNameOne = 'one';
const variableWithLongNameTwo = 'two';
const variableWithLongNameThree = 'three';
const variableWithLongNameFour = 'four';
const variableWithLongNameFive = 'five';
const variableWithLongNameSix = 'six';

rspack generates this code:
__webpack_require__.r(__webpack_exports__);
__webpack_require__.d(__webpack_exports__, {
  variableWithLongNameFive: function() { return variableWithLongNameFive; },
  variableWithLongNameFour: function() { return variableWithLongNameFour; },
  variableWithLongNameOne: function() { return variableWithLongNameOne; },
  variableWithLongNameSix: function() { return variableWithLongNameSix; },
  variableWithLongNameThree: function() { return variableWithLongNameThree; },
  variableWithLongNameTwo: function() { return variableWithLongNameTwo; }
});
 const variableWithLongNameOne = 'one';
 const variableWithLongNameTwo = 'two';
 const variableWithLongNameThree = 'three';
 const variableWithLongNameFour = 'four';
 const variableWithLongNameFive = 'five';
 const variableWithLongNameSix = 'six';

When minified, webpack is able to be compressed more, because the export bindings use () => instead of function(){return}
webpack compressed (pretty formatted for readability):
  e.r(o),
    e.d(o, {
      variableWithLongNameFive: () => n,
      variableWithLongNameFour: () => i,
      variableWithLongNameOne: () => r,
      variableWithLongNameSix: () => l,
      variableWithLongNameThree: () => t,
      variableWithLongNameTwo: () => a,
    });
  const r = 'one',
    a = 'two',
    t = 'three',
    i = 'four',
    n = 'five',
    l = 'six';

rspack compressed (pretty formatted for readability):
n.r(r),
          n.d(r, {
            variableWithLongNameFive: function () {
              return a;
            },
            variableWithLongNameFour: function () {
              return u;
            },
            variableWithLongNameOne: function () {
              return t;
            },
            variableWithLongNameSix: function () {
              return f;
            },
            variableWithLongNameThree: function () {
              return i;
            },
            variableWithLongNameTwo: function () {
              return o;
            },
          });
        let t = 'one',
          o = 'two',
          i = 'three',
          u = 'four',
          a = 'five',
          f = 'six';

For modules that contain lots of exports, this causes the size of rspack to grow quite a bit larger than webpack. Aligning with webpack would lead to more optimized bundles
Reproduce link
https://github.com/JohnDaly/rspack-export-alignment-with-webpack/
Reproduce Steps
Compare the output between rspack and webpack and notice that webpack has smaller output

Looks like this is the code that will need to be updated:
https://github.com/web-infra-dev/rspack/blob/96ae293534f166d08a84810827cf6c554135df33/crates/rspack_core/src/init_fragment.rs#L290
I think this is the equivalent code from Webpack:
https://github.com/webpack/webpack/blob/7d3a8880036d8e5410a144f4c4c495b8f0e21d88/lib/dependencies/HarmonyExportInitFragment.js#L153-L156
The format of the bindings (either function() { return .. } or () => (..)) is determined based on if the environment supports arrow functions or not
https://github.com/webpack/webpack/blob/7d3a8880036d8e5410a144f4c4c495b8f0e21d88/lib/RuntimeTemplate.js#L133-L137

try newTreeshaking

This issue isn't related to tree shaking

Need full support of runtime template and output.environment, related to #5013

I'm also coming up against this issue, where arrow functions are being converted to function syntax. I'm using newTreeshaking and target setup using browserslist where all browsers in the list support arrow functions.
If it helps, adding this to the minimiser config forces the keeping of arrow functions, however shouldn't be needed:
compress: {
    ecma: 2015,
    unsafe_arrows: true,
},

bump

@ahabhgk can you confirm whether it's solved?

I've also seen issues where browserslist config wasn't being respected. To get around it, I have to pass targets to env in the swc loader config directly.

I've also seen issues where browserslist config wasn't being respected. To get around it, I have to pass targets to env in the swc loader config directly.

@isuro Do you mean builtin:swc-loader didn't respect the .browserslistrc file? or the runtime code generated by Rspack. Would you open an issue and provide a reproduce, it would be great for us to find the potential bug

I think it may be https://github.com/swc-project/swc/issues/3365

bump

Bump from a very eager user of Docusaurus 😁

Bump
Our build increased by quite a bit from webpack without the arrow functions. So much so that the switch is potentially going to be held back due to the artifact size ☹


Tensorflow to engine

Hi guys,
First of all I want to thank you for the wonderful job you are doing, I tried the ssd mobile net following your tutorial and it worked like a charm. Now I am trying to use other networks not implemented but I have problems with NonMaximumSuppressionV2, because it is not supported by TRT so I can’t convert the tensorflow model to a TRT Engine, like you did in the tutorial. I would like to ask you how are you converting ssd mobile net to TRT Engine? Because I saw that after the tutorial a file .engine was saved in the project folder. Are you removing NMS and then applying transformations in parser?
If you are doing this, can I ask to you how are you removing those layers from pretrained networks?
Thanks, Lorenzo

Hi @lorenzo-caruso , sorry for the delay - this was the tool used to convert the TensorFlow-based SSD-Mobilenet to TensorRT:
https://github.com/AastaNV/TRT_object_detection
Or if you are referring to the PyTorch-trained SSD-Mobilenet that the tutorial covers, I don't believe I had to remove anything from the network to get that working.  But the clustering is done in post-processing.

Thank you very much!
Lorenzo


MINOR: Throw exception in BytesInput

Noticed this while reviewing https://github.com/apache/parquet-java/issues/3040

Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?

IMO this one should also go to 1.14.4

@pan3793 I agree, let's add this one as well


Tomlm/refactor assemblies

Consolidates assemblies

Microsoft.Bot.Expressions => pulls in Expression.Parser and TriggerTrees code
Microsoft.Bot.Builder.Dialogs.Adaptive => pulls in LanguageGeneration.Templates code
(temporarily) moved QnAMakerDialog into adaptive assembly so that we can ship GA QnAMaker

Pull Request Test Coverage Report for Build 82570

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.6%) to 76.519%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder/TurnContextStateCollection.cs
1
85.0%

Totals

Change from base Build 82538:
-0.6%

Covered Lines:
6863

Relevant Lines:
8969

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3


Add support for webp

https://developers.google.com/speed/webp/?csw=1

+1

+1

+1

+1

+1

+1

+1

+1

+1!

+1


Small PR for the color theme

Changed the color theme so that it fits a bit more the aesthetic of our app and the desire to have a more accessible app for everyone.

@gunnm0 Thanks for your comments! I tried to cover all of the colors used but I missed the error color, so thank you for your kind reminder, it is now included in our project, the problem with the color theme of before is that we used so much more colors than actually needed so this is also more purified


Add banner

(Ignore the astro dev toolbar in screenshots)
It sticks to the bottom of the page, has a message, and can be closed:

It takes on the accent color of the page:

When the user dismisses the banner, it stores the title we gave that message in the browser's local storage. That way, we can only show the banner again once we have a new message with a new title.
Also, when testing this out, I noticed some issues with scroll bars appearing on the homepage due to the header and hero image not taking into account scrollbar width. I've corrected those here too.

oh that's a good callout, thanks! I also have a content/pages directory that is being used for similar things because I didn't know about the text-detail directory at the time, would that avoid the issue of getting a page made for it? if so maybe I should keep it around and use it just for these non routed bits?

@davepagurek maybe? it looks like Education resources would work great as a page in text-detail, I'm not sure where the libraries file in there is used. Actually, looking more at the metadata you have for the banner, I would suggest that it should be its own collection. Nothing else in the text-detail collection or in content/pages collection is going to have the same metadata as a banner and i think it would keep the schemas a lot clearer to keep them separate.

I updated banner to be its own collection now!

Oops good catch, thanks!

We will merge this after we hear confirmation from the designers. @stefanietam @tyler-yin

Looks good to us, thanks!


Will the code be available?

Nice job! And will the code be available?

Of course！ I'm now working on it. Maybe nextweek ？

Congratulations on your work!

Hello，could I know when will the code be available?

Before January, I am now testing the code!


Feat/markdone

Made chat sessions "done"-eable / unarchived. (they can be closed / opened)
updated piece of state on reducer for whether the active chat is open or not.

this eliminates the need for looping through and checking the entire array of chats.

Screen Gif (long one)

woop woop merge meself womp womp


Allow excludeFields from type: 'Object' actionOnlyFields

If I have an object that, when created, creates another object and references the first object. There's no way to exclude the reference field from the input.
To use an example, I have Horse and HorseInfo ents. HorseInfo has a field horseID. My create action for Horse looks like this:
{
  operation: ActionOperation.Create,
  actionName: 'AddHorseAction',
  inputName: 'AddHorseInput',
  graphQLName: 'addHorse',
  actionOnlyFields: [
    {
      name: 'info',
      type: 'Object',
      nullable: false,
      actionName: 'CreateHorseInfoAction',
    },
  ],
  fields: ['name', 'nickname'],
}

Which means that the horseID field is exposed in the create action, even though the trigger for AddHorseAction looks like this:
{
  async changeset(builder: HorseBuilder, input: AddHorseInput) {
    return await CreateHorseInfoAction.create(builder.viewer, {
      ...input.info,
      horseID: builder,
    }).changeset();
  },
}

making the horseID input field a no-op and potentially confusing in the graphQL schema since it is required.

This was fixed in #690, I just hadn't pulled in awhile.


Precision_Guidelines_for_Ngen_Code_Validation

A description on what to expect after a major Ngen code change or update.
Document in pdf format.

Nice write up! I think it we should dump this into markdown so we can version the document. We can always use pandoc to generate a pdf from the markdown. This will also help keep the history/repo size down.

I also want discuss a bit about the precip variable sometime.

I haven't used markdown before. What do we need to do to dump the document to markdown?
About precip variable discussion, anytime would be fine.

Here's a useful tutorial for MD:
https://www.markdowntutorial.com/

How do I preview my markdown document?

Thanks Zach.
I was able to change the document to the markdown format and upload it (PR#226). It looks ok.

closing in favor of #226


[Feature Request] - embed from multiple files

For case where you have multiple files with the same structure, it would be nice to aggreagate across multiple files like a query.
Example with 3 files together.
2022-01-31
- Nothing cool up here
- something cool below
  - Things are awesome
- something unrelated
- more unrelated

2022-02-01
- Nothing cool up here
- something cool below
  - Things are awesome2
- something unrelated
- more unrelated

2022-02-03
- Nothing cool up here
- something cool below
  - Things are awesome3
- something unrelated
- more unrelated

path:
  - [[2022-01-31#-something cool below]]
  - [[2022-02-01#-something cool below]]
  - [[2022-02-03#-something cool below]]
display: embedded
join: "- "

would render as
  - Things are awesome
  - Things are awesome2
  - Things are awesome3

I thought you might bring this up 😄.
I'm not sure yet if this is something on the roadmap. Definitely a lot of the assumptions in the code as of now are based around one file per embed. It raises some questions about how to handle multiple files with some of the other embed options. How would show: author, title behave? Or having ranges that are present in some files but not others?
As I'm working on things, I'll have to keep an eye out for whether or not the assumption about one file per embed is a necessity or not.

no worries. I can wrap it in a templater for loop for a little bit so no rush


Windows Remote Desktop may prevent Cesium actors from loading

User reports that when using Remote Desktop connection, Cesium actors won't load in Unreal (though everything else loads fine).

Hello,
indeed, it doesn't work if accessed via RDP. I have tried it on two different machines and neither works:

On a Windows Server 2019 user with Unreal Engine 4.27 and the latest version of Cesium
On a Windows 11 Insider (22494) with the same versions, nor on 4.26.
On the other hand, on Windows 11, if I login locally (after crashing Unreal Engine and reopening it), I can see the Cesium content perfectly.

If anyone has ideas on how to solve this problem, please share them here. It's quite annoying for me and my colleagues who want to use Cesium remotely from the server.
For any test you may need, count on me.

I just ran into the same thing. The reason Cesium content doesn't appear under remote desktop is because the Unreal Editor automatically disables real-time mode under remote desktop. And when real-time is disabled, Actors don't get Ticked. And when the Cesium3DTileset Actor doesn't get ticked, tiles don't get loaded and displayed.
I'm not sure what a proper solution is here, but a good workaround is to re-enable real-time rendering. It's an option on the viewport's hamburger menu in the top left.

This is not something we can fix, and the workaround is documented in the FAQ now, so I'm closing this.


Enable fullUnicode in blessed

Enable fullUnicode feature according to https://github.com/chjj/blessed/issues/226
close https://github.com/evanyeung/terminal-slack/issues/23

Thanks for the description, screenshot, and linked issue!


6898: Add validity duration to Venafi certificates

Pull Request Motivation
When using Venafi as issuer the specified Duration on the certificate resource does not get passed to Venafi. Therefor only the CA default expire time will be used and it's not possible to override it.
Kind
feature
solves https://github.com/cert-manager/cert-manager/issues/6898
Release Note

Now passes down specified duration to venafi client instead of using the CA default only.

/ok-to-test

Note that this might change existing behaviour since now duration would actually be used (as it should), if the CA allows it

When can we see this PR merged and shipped in a release? Can it be back-ported to prev releases as a patch ?
This is currently an issue and would like to have this functionality

We aim to include this in cert-manager v1.16. This PR will not be backported, we only backport fixes, not behavior changing "features".
Got it, thank you!

As a workaround, I think it should be possible to configure the certificate duration in Venafi TPP on a policy level (ask your Venafi representative).
Yea, we could do that but sometimes those ttls are large by default and we wanted to set something lower to test auto-rotation. Not a big deal for now

/kind feature

/approve
/lgtm

This PR causes our e2e tests to fail (see https://testgrid.k8s.io/cert-manager-periodics-master#ci-cert-manager-master-e2e-v1-30-issuers-venafi).
cc @wallrj

vcert error: server error: Unexpected status code on Venafi Cloud zone read. Status: 412 Precondition Failed\nError Code: 10728 Error: Validity period is invalid. Value must be greater than 0 and less than or equal to 7 days

I never tested with Venafi Cloud myself, not sure where this 0-7 days come from, but I guess now the default 90 days is sent in. Might be more issues also but this is what I could easily see in the tests.. Anything I can do to help? I'm available next week to help but after I'm away on vacation

The error originates from our e2e test issuing template configuration:

It specifies a duration of 7 days, which is the default but also the maximum.
So, with this new feature our e2e test request a certificate with duration > 7 days and that might cause a renewal/ issuance failure.
This is something that will at least have to be added in the release notes.

@inteon Are the e2e tests still an issue ? Just want to confirm if I should try to modify the certificate request in the tests

@inteon Are the e2e tests still an issue ? Just want to confirm if I should try to modify the certificate request in the tests

Thanks for the help, but I think we will just update the Venafi policy instead. Nothing required from your side.

I've updated the policy to allow certificates up to 1 year.
/test pull-cert-manager-master-e2e-v1-30-issuers-venafi-cloud
/test pull-cert-manager-master-e2e-v1-30-issuers-venafi-tpp


Develop this Revamped Open-Source Profile UI

What would you like to share?
Develop this Open-Source Profile UI

Additional information
Refer to the Figma Design
https://www.figma.com/file/QJdOAP9EB3CbiK3dOiOfaL/ClueLess?node-id=2330%3A7211&t=u23pNyuQlhrFByO2-1

I want to contribute to it under jwoc

@gnaneshwar718 assigning you

@gnaneshwar718 What's the Update?

@Debajyoti14 I want to work on this issue. Can you please assign it to me under JWOC.

I would like to work on this issue under JWOC

I want to work for on this issue under jwoc , please assign me

Sorry for late reply I just had IA
On Sat, 25 Feb 2023, 10:28 Hritik1503, @.***> wrote:

I want to work for on this issue under jwoc , please assign me
—
Reply to this email directly, view it on GitHub
https://github.com/Clueless-Community/clueless-official-website/issues/505#issuecomment-1444994164,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXIAZNJ6Q5YUUO3IDCYBUWTWZGGPPANCNFSM6AAAAAAU3673XA
.
You are receiving this because you were mentioned.Message ID:
@.***
.com>

I would like to take it on, @Debajyoti14.

@Zubair-05 Do you want to work on this issue now ?

@bbsdevloper Yes of course. I want to work on this issue.

Go ahead @Zubair-05

@Zubair-05  is it done ❓

@bbsdevloper I'm really sorry that I'm not able to finish the task. I request you to assign this issue to somebody else.


feat(protocol): Add native ERC20 token support 'plugin' to ERC20Vault via Registry+Translator

So, this seemingly a big PR but it is NOT !
Let me summarize the things and it will be more understandable.
IMPORTANT NOTE:
Why cannot we just bring the USDC contracts (from taiko/USDC) to this repo's contract folder ? And why I use those contracts only in test/helper/usdc ?
Because those are not identical (modified contracts only for E2E tests). The reason is the compiler settings (solc version and optimization).
Here (in the tests) i can change the pragma version (to 8.20) but 'in real life' we have to stick to the old USDC contract compiler versions and optimizations.
You do not have to bother with the contracts in test/helper/usdc, because they are the official USDC contracts - slightly modified to work with .8.20, see mods:
There are some things deprecated with higher version of the compiler, which is still relevant in circle’s USDC code (lack of receive does not trigger a warning, constructor visibilty,.now, .add -> BUT in the test/helper/usdc folder, it is fine, i modified these files to be working with .8.20 but the Circle’s Bridged USDC Standard is clear on that, we shall NOT modify the code and have the exact same byte code.
https://github.com/circlefin/stablecoin-evm/blob/master/doc/bridged_USDC_standard.md
So this is why, during testing, I used these modified USDC contracts - to have an E2E tests with our ERC20Vault.
Ok so now the changes:

introduced an ERC20Hook contract, deployable - which will handle the 'mappings' native token vs. deployed token on L2.
In particular, we need to keep track of some data:

    struct DeployedToCanoincalData {
        address canonicalAddress;
        uint8 burnFunctionSignature;
    }
    mapping(address => address) public canonicalToPredeployed;
    mapping(address l2Address => DeployedToCanoincalData) public predeployedToCanonical;

canonicalToPredeployed is needed in _getOrDeployBridgedToken(), so when we we check if a custom contract is deployed already for a specific native coin (in our case/example it is USDC).
predeployedToCanonical is needed in _handleMessage, so when we "birdge back" to the canonical chain the already bridged USDC. Because we "minted" during the bridging, we now need to burn. But the burn function differs from our "BridgedERC20" standard - we need to keep that in mind. (Only minterRole can burn and only in case if minterRole address owning those tokens).

This was the easiest design coming to my mind, with hooks, because maybe in the future we can support other native tokens (USDT), the only thing we need to do is pre-deploy a USDT the same way, check its' burn function and add it to the interface if different.
Referring to this doc too:
https://github.com/taikoxyz/USDC/blob/0d7d65af85ce59b5ae8452b15d125159f21555e4/README.md
Please let me know if you have any questions or suggestions !

For the different solc versions, could this help: https://ethereum.stackexchange.com/a/153746?

For the different solc versions, could this help: https://ethereum.stackexchange.com/a/153746?

Tried :( Not working. And one other issue is the optimizer settings - which differs for USDC too.

Two ideas:

Instead of modifying the behavior of ERC20Vault, maybe better to create a separate USDCTranslator contract that handles the differences. So ERC20Vault -> USDCTranslator (which implements IMintableERC20) -> USDC (custom smart contract). This seems cleaner and more flexible because then these translator contracts can do whatever is needed to make the custom contracts conform to the ERC20Vault behavior.
Rename ERC20Hook to ERC20Regsitry so it's more clear what its function is

* Rename ERC20Hook to ERC20Regsitry so it's more clear what its function is

Done, thanks for the feedback.

* Instead of modifying the behavior of ERC20Vault, maybe better to create a separate USDCTranslator contract that handles the differences. So ERC20Vault -> USDCTranslator (which implements IMintableERC20) -> USDC (custom smart contract). This seems cleaner and more flexible because then these translator contracts can do whatever is needed to make the custom contracts conform to the ERC20Vault behavior.

An observations to this - as i started implementing. We can definitely do that (i think) but it comes with the fact that this 'USDCTranslator' needs to be:

MinterRole given (which is OK, we just grant it minter role, it is OK)
Needs to be an 'approved()' address -> This contract will be the one (and not the ERC20Vault!!) who need to be approved for bridging back from L2 to L1.  So the UI also needs extra logic to check to whom 'approve()'... Because this wrapper/translator will be the one responsible for transferFrom().

I'm implementing in the meantime, will try to do it within today, adjust code+tests, and you can decide if the flexibility worth the effort of breaking the 'way' we bridge (hence some UI logic changes).

Instead of modifying the behavior of ERC20Vault, maybe better to create a separate USDCTranslator contract that handles the differences. So ERC20Vault -> USDCTranslator (which implements IMintableERC20) -> USDC (custom smart contract). This seems cleaner and more flexible because then these translator contracts can do whatever is needed to make the custom contracts conform to the ERC20Vault behavior.

Funcional wise it is done. Now every native ethereum asset could be plugged in to the system - if we want to support it (stEth, USDT, USDC, etc.) - just need to predeploy their current 'up-to-date' smart contract from ethereum (with their respective proxies) onto L2 with genesis (or right after the genesis) and then update the ERC20NativeRegistry.
Please have a look at the design diagram and then check the code ! I tried to put explanations everywhere possible.
Here is a high level design diagram about the usage.
@dantaik , @Brechtpd i advise to start from the diagram and see points in order, 1,2,3,4.. etc. to get to know the flow.

Needs to be an 'approved()' address -> This contract will be the one (and not the ERC20Vault!!) who need to be approved for bridging back from L2 to L1. So the UI also needs extra logic to check to whom 'approve()'... Because this wrapper/translator will be the one responsible for transferFrom().

Could you work around this by calling back into ERC20Vault from the translator contract so that ERC20Vault still does the transfers requiring approval? Seems like it could be possible in a safe way because msg.sender would the the translator contract and ERC20Vault would know the token contract that is linked to that translator? Not saying it's a good idea, but seems like there are could be potential solutions that do not require this to be a special case.

Well, i tried with delegateCall() + removing the nativeContractAddress from the translators but so far no success. Will need to revisit on Monday.

Somehow I found my comments have not been submitted successfully (or I submitted it somewhere else):

If Circle requires their contract to be deployed bytecode as-is, we should simply copy their bytecode to this contract without creating our own https://github.com/taikoxyz/USDC repo.
We should avoid integration testing with USDC and other future third-party tokens, and focus on unit-testing our own code. I suggest to completely remove USDC related code from our mono repo.
I suggest to rename Translator to Adaptor as this is what it is from a design-pattern perspective.

Somehow I found my comments have not been submitted successfully (or I submitted it somewhere else):

Yes, you asked them in the Airdrop branch, but it is ok. :)

* If Circle requires their contract to be deployed bytecode as-is, we should simply copy their bytecode to this contract without creating our own https://github.com/taikoxyz/USDC repo.

Agreed.

* We should avoid integration testing with USDC and other future third-party tokens, and focus on unit-testing our own code. I suggest to completely remove USDC related code from our mono repo.

Well, the addition to they layer above (aka with Translators/Adaptors) means that some tokens have custom burn/mint functions. Like we see with Circle USDC's burn. But i'll try to shrinken the contracts and make it less, but only once i reached the 'final' version. (Only missing piece is: make the adatpor calls delegate so that the ERC20Vault is the "approved" contract not the translator - for native tokens).

* I suggest to rename Translator to Adaptor as this is what it is from a design-pattern perspective.

Ok.

@Brechtpd @dantaik
Functional wise it is ready ! Please have a look if something is not OK or clear.
Missing things:

[ ] Bring USDC bytecode (from other repo) here and incorporate into the L2 deployment process
[ ] Mock actual USDC code under /test/helper/usdc into a smaller codebase
[ ] Use other proxy implementation for registry and vault

As opened a new on top of branch proxy, closing this.


Allow customize timestamp format

It would be nice if zephyr allowed registering a user-provided function to format the output string of the timestamp.
Perhaps introduce a new kconfig symbol as an alternate to CONFIG_LOG_BACKEND_FORMAT_TIMESTAMP?
Will CONFIG_LOG_BACKEND_FORMAT_TIMESTAMP_CUSTOM sounds good?

@manoj153 sure, would you mind sending a Pull Request with a proposal?

Here is an PR that implements custom timestamp formatting https://github.com/zephyrproject-rtos/zephyr/pull/56277


chore: bdd-spring-1584297864 to 0.0.1

chore: Promote bdd-spring-1584297864 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Re-invent core value propagation logic

This PR replaces the initial Monix based value propagation hack with a new macro free implementation. Hopefully this fixes all memory leak issues.
@Atry If you are interested, https://github.com/OlivierBlanvillain/monadic-html/commit/5d863d8f5ac6974203c5f375c7dce79873844098 is the interesting commit.

Looks good


Question about optimizing camera poses

Hello,
Thanks for your fancy work. I'm interested in the dynamic 3D from a monocular video. While reading the paper, I was curious about the part about optimizing camera pose. Since the current Gaussian Splatting renderer does not support gradient propagation of camera poses, it seems that you are not optimizing camera poses with the l1 loss of the rendered image and GT, as shown in Eq. 14 and 15.
However, I'm a little confused about "Note that we will also optimize the camera poses Wt throughout the rendering phases as well with
photometric losses to further adjust the camera". I saw this was also mentioned in another issue. Does this mean that the camera pose is also optimized using Eq. 13 as loss? If so, have you implemented a renderer that can pass the camera pose gradient? If so, that's so cool.

thanks for your question.
The camera focal length is not optimized during rendering, but the camera poses are optimized during rendering by the l1 loss of rendered rgb images and depths.
The native GS renderer does support optimizing camera poses but does not support focal length gradient. Because the renderer can take input 5-tuple of gaussian parameters (mu, rot, scales, opacity and sph) no matter in which coordinate frame, and produces an image. So we can always manually transform these parameters (rotate and translate mu, rotate rot) outside the native renderer with pytorch auto-grad, and make the input camera pose to the renderer function always identical. In this way, we can optimize the camera poses. Hope this answer would be somehow useful, thank you.

Thanks for quick replying!


Add support for self-managed GitLab

Thanks for your great work!
I tried to add support for self-managed GitLab.

添加对自建gitlab服务的支持。

Thanks


proxy: overhaul backend error handling

Cleans up logic around response handling in general. Allows returning
server-sent error messages upstream for handling.
In general SERVER_ERROR means we can keep the connection to the backend.
The rest of the errors are protocol errors, and while some are perfectly
safe to whitelist, clients should not be causing those sorts of errors
and we should cycle the backend regardless.

[x] Tests around the lua API; ensure :ok() fails for an error and :code() works right. It should function the same as an error, it just doesn't blow away the response data further up the chain.
[x] Self code review. Feels like I'm missing something but it just took a lot of thinking to clean it all up.

At some point I'll either merge code/resp in mcmc or figure out some better way of representing that data, as they do overlap.

Using the new staging branch to make this easier to review and merge.

I'm sure someone's going to want to take the error and shove it into a log line, but I think that's another change.

Wowee look at all these tests!
Gonna stage this booger I think. I still kinda hate the resp type vs code thing (And resp type isn't exposed into lua at all), but resp:ok() uses the status return value which covers all errors, so that's still perfectly good.