Suggestion: return value in "selected" listener to set input field value

I find that on "selected" callback would benefit from returned value that would set input field's value. Right now, input field is set by getSuggestionValue method, but by decoupling from same method into @selected callback would make component more versatile.
Case in point, there is custom logic in @selected callback that assigns selected suggestion to an external array for further processing. In this case, it would make sense to clear out selection. Sample code:
methods: {
    onSelectHandler (val) {
      this.selectedSuggestions.push(val.item)
      return null
    }
}

Similar approach is already implemented in renderSuggestion and getSuggestionValue.
Should be a fairly quick and short update. I can help with a PR if that helps.

getSuggestionValue was created because the @selected event is not the only time the method is called. This method is also needed when you are keying through items.

OK, fair enough. I see that @selected handler only gets called when selecting an item, keying through calls getSuggestionValue and renderSuggestion methods. Suggestion here is to have a method that gets called when a selection is made (either by Enter, keying through selections, mouse click, etc). This will allow for an important feature such as multiple selections, that will be highly useful (see https://vuetifyjs.com/en/components/autocompletes#scoped-slots with multiple select field).
@darrenjennings

@sbay multiple selection can be accomplished via @mouseup.stop on the slot items. This isn't a great solution since it forces a vue-autosuggest user to roll their own multiselect implementation, but it is possible. Also, you can get around it by uses input checkboxes which won't trigger @selected event. Though I prefer the @mouseup.stop event since it allows you to click anything
See the "button" in one of the slots, as well as the checkboxes:
https://codesandbox.io/s/x9z1lo20mo


Tables included with {include} not exporting to DOCX

Description
Currently, you can {include} tables into the HTML site without issues with the syntax:
::::{table} Area Comparisons (written in fancy HTML)
:label: tbl:fancy-table

:::{include} table.html
:::

::::

However, exporting to DOCX doesn't work.
It generates the following errors:
❯ myst build table.md --docx --debug
...
Exporting formats: "docx"
loadFile: loaded /Users/roaldarbol/Filen/Projects/myst-tables/table.md in 44 ms.
📬 Performing exports:
   table.md -> _build/exports/table.doc
Loaded site config from /Users/roaldarbol/Filen/Projects/myst-tables/myst.yml
Loaded project config from /Users/roaldarbol/Filen/Projects/myst-tables/myst.yml
loadFile: loaded /Users/roaldarbol/Filen/Projects/myst-tables/table.md in 4.76 ms.
Processing "/Users/roaldarbol/Filen/Projects/myst-tables/table.md"
⛔ table.md container of kind table contains no valid content besides caption, legend
   Valid content types include image, referenced notebook cell, table, code, iframe, subfigure
To suppress this message, add rule: "contianer-children-valid" to "error_rules" in your project config
⚠  table.md unexpected figure content of type table found in legend node
To suppress this message, add rule: "contianer-children-valid" to "error_rules" in your project config
📖 Built table.md in 39 ms.
Transformed mdast cross references and links for "/Users/roaldarbol/Filen/Projects/myst-tables/table.md" in 6.02 ms
📚 Built 1 page for export (including 0 dependencies) from /Users/roaldarbol/Filen/Projects/myst-tables in 53 ms.
Template found: /Users/roaldarbol/Filen/Projects/myst-tables/_build/templates/docx/myst/default
⛔ _build/exports/table.doc Node of type "legend" is not supported by docx renderer
To suppress this message, add rule: "docx-renders" to "error_rules" in your project config
📄 Exported DOCX in 199 ms, copying to _build/exports/table.doc

Additional notes
A minimal reproducible example:

Save as table.html:

       Projection
       Area in square miles

       Large Horizontal Area
       Large Vertical Area
       Smaller Square Area

       Albers Equal Area
       7,498.7
       10,847.3
       35.8

       Web Mercator
       13,410.0
       18,271.4
       63.0

       Difference
       5,911.3
       7,424.1
       27.2

          <bold>Percent Difference</bold>

       44%
       41%
       43%

Save as tables.md:

---
title: Testing tables
---
::::{table} Area Comparisons (written in fancy HTML)
:label: tbl:areas-html

:::{include} table.html
:::

::::

Build DOCX file:
myst build table.md --docx --debug

It seems that export to PDF through Typst is also broken.


Merge pull request #1 from andyfmiller/master

Pull from upstream source (andyfmiller/LtiLibrary)

Oops, accidentally created a PR in the wrong direction! ;-)


Backward Error during Pre-training

Dear authors:
Thank you for your inspiring work !
 This error is caused by one of the following reasons: 1) Use of a module parameter outside the `forward` function. Please make sure model parameters are not shared across multiple concurrent forward-backward passes. or try to use _set_static_graph() as a workaround if this module graph does not change during training loop.2) Reused parameters in multiple reentrant backward passes. For example, if you use multiple `checkpoint` functions to wrap the same part of your model, it would result in the same set of parameters been used by different reentrant backward passes multiple times, and hence marking a variable ready multiple times. DDP does not support such use cases in default. You can try to use _set_static_graph() as a workaround if your module graph does not change over iterations.
Parameter at index 486 with name protein_lm.bert.encoder.layer.29.output.LayerNorm.weight has been marked as ready twice. This means that multiple autograd engine  hooks have fired for this particular parameter during this iteration.RuntimeError

It seems that this error only appears when performing DDP training, besides we have tried deep speed but an error occurs during loading optimizer at line 168 in trainer.py.
Wonder how I can solve this. Thank you very much!

Hi, thanks for your interest in our work!
Our training framework is based on deepspeed, it may exist some errors when directly running the script for pertaining using torch.distributed.launch.
Could you show the detailed error information about deepspeed?
We will check and release the new version of our code. Thank you!


Gallery

Todo:

Infinite scroll option for the gallery page. (not needed for the home page)
Fix CSS hover action to make the author and view links look good
Ability to have a youtube video in there as well

[ ] Favorites functionality
[ ] View button
[ ] Styling
[ ] Performance

closing since we have the remaining performance task in #78


[WebToolsE2E][Aspire] After successfully publishing an Aspire project, the page keeps flashing when double clicking any instrument group in the "Aspire Dashboard" Metrics on the physical machine.

INSTALL STEPS

Clean machine: Windows/Mac
Install SDK 8.0.402
Install Aspire 8.2.0
Install latest released azd v1.10.1
Install git v2.46.2.windows.1

REPRO STEPS

Open CMD, run following command to create an Aspire Starter App project and deploy it

dotnet new aspire-starter -o AspireStarterApp
cd AspireStarterApp/AspireStarterApp.AppHost
azd init
azd up

After successful deployment, open the deployed "Aspire Dashboard" URL in physical machine

Click the "Metrics" option on the Aspire dashboard left, select a resource and double click on any instrument group

Note:

This issue only reproduce when open the deployed "Aspire Dashboard" URL on physical machine, it doesn't repro on the virtual machine
This issue also repro on Aspire 8.2.1, and it also repro on the latest Aspire 9.0.0-preview.4.24475.9

ACTUAL
The page keeps flashing

cc @snehapar9 @drewnoakes


[HELP]How to replace the search and download image addresses of Sentinelhub with proxy server addresses

How to replace the search and download image addresses of Sentinelhub with proxy server addresses, such as https://sentinel-s2-l2a.s3.eu-central-1.amazonaws.com/ change into http://...:9527/sentinel -S2-12a

The three addresses for querying images, downloading l1c, and downloading l2a have been proxied forward


String bug MK II

Fixes The String Bug

[x] OSAPI - fairly trivial. Event names and labels will not preserve encoding, but arguments to os.queueEvent will.
[x] PeripheralAPI - in the call method we should detect if the peripheral implements IBinaryLuaObject, if it doesn't then we will need to 'decode' arguments.
[x] HTTPAPI - this will require rewriting both the reading and the request: It might just be easier to manually replace the classes.
[ ] FSAPI - Not sure if just to use the binary reader/writers for everything or something else. This will be the hardest.
[ ] TermAPI - We could fix the issue with term.blit not coping with binary characters.
[x] Peripherals - CCTweak's own modems will be trivial to patch, wireless modems should also be easy. I'm not sure if we should path others: Unicode printed pages would be pretty awesome though :smile:. However, I'm not sure you need binary for unicode - this project seems to work without it.

I'm going to leave the FS API bit for the moment - there is an existing binary implementation for it.
I'll test using a similar script from #12.

Implemented the FS API in ceb8fa0940c489636b90e3d4af3b8f549c89c53d.


Fix for pulling in new limits from TA.

Before there was a bug where we wouldn't pull in new numbers from TrustedAdvisor
cc @nadlerjessie @hltbra

LGTM


MacOS Catalyst 13.0 - Doesn't Persist once app is closed.

Using MacOS Catalyst, the Keychain works by using Keychain Sharing and adding into the Keychain Groups but once the app is closed, the values are removed and deleted. Any suggestions / feedback would help :) Thanks!

Library setup method: CocoaPods
Version of the library: 18.0.0
Xcode version: 11.2.1
Deployment target version: iOS 13.2

Triedn 'KeychainSwift.synchronizable = true' but still to no avail...

Nevermind, I figured it out. Kept clearing the keychain  in 'func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool ' in the AppDelegate. Everything works now. Thanks! Will close the issue.


Update rust toolchain to 1.34.1.

Codecov Report

Merging #264 into develop will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #264      +/-   ##
===========================================
+ Coverage       49%   49.19%   +0.18%
===========================================
  Files          116      116
  Lines        17337    17351      +14
===========================================
+ Hits          8496     8535      +39
+ Misses        8841     8816      -25

Impacted Files
Coverage Δ

cita-sm2/src/keypair.rs
80% <0%> (-17.15%)
:arrow_down:

jsonrpc-types/src/rpc_types/specs/id.rs
44.44% <0%> (-11.12%)
:arrow_down:

proof/src/bft_proof.rs
93.1% <0%> (-6.9%)
:arrow_down:

cita-ed25519/src/keypair.rs
96.42% <0%> (-3.58%)
:arrow_down:

jsonrpc-proto/src/complete.rs
95.38% <0%> (-3.08%)
:arrow_down:

tx_pool/src/pool.rs
82.47% <0%> (-2.07%)
:arrow_down:

db/src/kvdb/in_memory.rs
44.61% <0%> (-1.54%)
:arrow_down:

...sonrpc-types/src/rpc_types/basic/arbitrary_data.rs
80.88% <0%> (-1.48%)
:arrow_down:

libproto/src/autoimpl.rs
90.36% <0%> (-1.21%)
:arrow_down:

db/src/journaldb/refcounteddb.rs
96.73% <0%> (-1.09%)
:arrow_down:

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec4e19...70dda18. Read the comment docs.


p2p: use backoff during routing discovery

Motivation
Previous attempts at enabling routing discovery caused network overload on some of the nodes
Description
Avoid excess DHT queries and connection attempts by using the same backoff mechanisms as those used by Kubo and peer discovery code in go-libp2p-pubsub
Test Plan
Tested on a mainnet node
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update changelog as needed

bors merge


Allow specifying dependencies as a hash

This pull request fixes #186. It changes the dependencies to allow hash values specifying the package as the key and the constraint as the value. Here are some allowable dependencies:
# As before, a single string is allowed.
dependencies: base ==<IP_ADDRESS>

# Also as before, a list of strings is allowed.
dependencies:
  - base ==<IP_ADDRESS>

# This changed! Now a hash is interpreted as "<package>: <constraint>".
dependencies:
  base: ==<IP_ADDRESS>

# Values aren't required.
dependencies:
  base:
  aeson: null

# Values can be hashes.
dependencies:
  local:
    path: the/path-to/local
  remote:
    github: user/repo
    ref: master

# Be careful with constraints that collide with YAML syntax.
dependencies:
  # base: >=4.10 # Error!
  base: '>=4.10'

# When there are duplicate keys, later keys win.
dependencies:
  base: ignored
  base: ==<IP_ADDRESS>

In #186 I originally suggested that the == constraint be implied if no constraints were given. In other words, base: <IP_ADDRESS> would mean base ==<IP_ADDRESS>. I chose not to implement that because it would require parsing constraints, which is hard.

@tfausak Hey, sorry for the late reply (I was offline for a while).

In #186 I originally suggested that the == constraint be implied if no constraints were given. In other words, base: <IP_ADDRESS> would mean base ==<IP_ADDRESS>. I chose not to implement that because it would require parsing constraints, which is hard.

This syntax is actually what convinced me in favor of adding this feature.  In addition, I was hopping that it will be possible to tighten (or loosen) constraints for specific dependencies, e.g.:
dependencies:
  base: 4.*

tests:
  ...
  dependencies:
    base: '>= 4.3'

What exactly do you mean with "hard" when it comes to parsing constraints?  My assumption was that depending on Cabal will allow us to do this (not that I'm excited to depend on Cabal, but that's probably what I would do...).

I said that parsing constraints would be hard because right now the dependency strings are simply passed through to the Cabal file. Parsing the constraints will be a little bit bigger of a change, but it's definitely doable.
Would later constraints be "and"ed together with earlier ones? In your example, that would end up as 4.* && >=4.3. It would be hard to loosen constraints that way. You could optionally put || before the constraint, but Cabal might not like parsing that.

Would later constraints be "and"ed together with earlier ones? In your example, that would end up as 4.* && >=4.3.

Cabal solves dependencies for a package as a whole (with intersection-semantics for constraints from different sections, which is the same as &&).  For that reason I think it is fine to override global constraints with section specific ones by just merging the Maps and leaving the intersecting to the dependency solver.
This will give us the exact same semantics in most cases.  The only exception I see is when you override a global dependency in all sections of a package, e.g.:
dependencies:
  base: '>= 4'

library:
  dependencies:
    base: '< 5'
  ...

tests:
  spec:
    dependencies:
      base: '>= 4.3'

which is not particularly DRY in the first place and better expressed as
dependencies:
  base: 4.*

tests:
  spec:
    dependencies:
      base: '>= 4.3'

(As a side note, as I understand it, it's never useful to specify different constraints for library and executables, as Cabal will always solve them together anyway.  In the same vane it does not make sense to loosen constraints for tests/benchmarks, as again Cabal will always solve them together with constraints from library/executables.  So the only thing that I ever wanted to do is tighten constraints for tests/benchmarks.  Please correct me if you think I'm missing something.)

It would be hard to loosen constraints that way. You could optionally put || before the constraint, but Cabal might not like parsing that.

Can you come up with a use case?
@tfausak big sorry again for the delay!  I implemented constraint parsing and changed the internal representation from a list to a Map in #196.  Can you migrate your changes on top of that?

Once we are through with this, I'm also happy to revisit #91 and see what we can cherry-pick from npm/bundler.

I'll take another look at this today. Your changes look great and lay a nice foundation for what I want to do here. I'll probably open another PR to avoid gnarly merge conflicts.

Closing in favor of #198.


Bug: Crash during Pinboard RSS import

Describe the bug
Using the Pinboard RSS parser results in a crash due to an assertion in index/schema.py. This assertion fails because parsers/pinboard_rss.py passes a None value as the url property of the Link object.
The url is set to None because the return value of item.find() is coerced to a bool in pinboard_rss.py. The result of the coercion is always False, because the <link> element does not have any child elements, which is the definition of __bool__() in ElementTree.Element. In fact, the RSS 1.0 specification forbids any child elements of <link>.
Steps to reproduce

Run curl -sSL 'https://feeds.pinboard.in/rss/u:maciej/' | archivebox add --parser=pinboard_rss
Python crashes with a backtrace, below.

Screenshots or log output
Backtrace
[X] Error while loading link! [1628081549.183792] None "None"
Traceback (most recent call last):
  File "./test_pinboard_rss.py", line 18, in <module>
    main()
  File "./test_pinboard_rss.py", line 13, in main
    items = [item for item in parse_pinboard_rss_export(args.rss_file)]
  File "./test_pinboard_rss.py", line 13, in <listcomp>
    items = [item for item in parse_pinboard_rss_export(args.rss_file)]
  File "/usr/local/lib/python3.8/site-packages/archivebox/parsers/pinboard_rss.py", line 41, in parse_pinboard_rss_export
    yield Link(
  File "<string>", line 11, in __init__
  File "/usr/local/lib/python3.8/site-packages/archivebox/index/schema.py", line 141, in __post_init__
    self.typecheck()
  File "/usr/local/lib/python3.8/site-packages/archivebox/index/schema.py", line 165, in typecheck
    assert isinstance(self.url, str) and '://' in self.url
AssertionError

ArchiveBox version
Running dev branch. Tested on commit 3d54b13.


Optimize ScPCA servers disk usage

Problem or idea
Both staging and prod deploy boxes have a decent amount of disk space required for data loading process only. This resource contributes ~20-25% to ScPCA AWS monthly bill.
Solution or next step
Figure out a preferable cost optimization solution and implement it.

Please don't close this ticket until we test this on staging by re-loading all of the projects (./load-data.sh --reload-all) to ensure the new smaller volume size will support every available project.


Allowed loading a ROM without file IO

This makes the ROM constructor accept either a filename or the ROM bytes. Magpie's autotracker never knows were the ROM file is, it has it in memory.

Alternatively you could use an IO.StringIO object?

I looked into an approach along those lines originally, but the fact that ROM accepts a path that it passes directly to open() stumped me. Maybe I'm misunderstanding, though?
Or are you suggesting ROM accept a stream rather than bytes?

Yeah, make the class accept a filestream instead of a filename.

Got it, how's this look?
Also, merry Christmas!


isDirSynced is filterable with Get-Recipient

isDirSynced is filterable with Get-Recipient

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ce35226-b40b-3c9f-a37f-585b84aa129e
Version Independent ID: ac9953e2-769a-c115-b1c6-e6f6fc940db2
Content: Filterable properties for the Filter parameter
Content Source: exchange/docs-conceptual/exchange-server/recipient-filters/filter-properties.md
Service: exchange-powershell
Product: exchange-server-itpro
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

@dariomws  Thank you very much for the contribution and updating the documentation with PR. @grzegorzwierzbicki Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Use new process when executing offline CLI

@jamezp updated the PR to check for result of the script execution.
and if it fails it display up to 3 lines of execution log.
Better would be to have CLI outout error to std err, but as long as we don't have that this should work just fine.


Errors with documents with spaces

Error when I use get function on documents with spaces
This gives error:

Error:

This doesn't give error:

This is my fix


Update README in favour of Wiki

This will make everything tidier and way much easier to find!
Benefits:

Developers won't land on a colossal page with all kind of irrelevant info and they won't get quickly overwhelmed by it
Developers will easily find whatever it's they are looking for
PRs to update README will not be needed anymore and we'll have quick updates whenever we need.
Whenever there's a new version, we'll only need to update 1 or 2 pages, for example, Integration if we have a change on the integration methods or if we just released the border work then we only need to change Make It Your Own
Easy to browse through it on the sidebar. Rather than an endless scrolling on a huge README file.

Cons:

We won't have a frozen version of our README that's bound to our released versions and we'll need to be strict about naming our pages with the relevant Frames version number? There is also history available: https://github.com/checkout/frames-ios/wiki/Integration/_history

As a solution to this, we can keep the Documentation section under README. And then, we can have different pages that has the version number as a suffix like Integration [4.2.0] and link it. They will stay in the revision history of the Wiki pages and can be reviewed later. This is for a case where a merhant uses an old version and at a later time they come and want to see the old documentation. By doing this, we create a frozen README for every version out there.
Investigation:
Wiki pages are being created by the title string. Which means the path to them includes the string in the title. So, even if we see the history, when we change the title, the old version returns 404.
If we can’t solve this, we might hold separate .md  files for separate sections of README.md and link them under the Documentation section while the main README again just holding the Documentation section.
or, we can keep the same title, being careful about it, and then write commit messages as Update for 4.2.1 like this https://github.com/adam-p/markdown-here/wiki/Tips-and-Tricks/_history. even if you accidentally change the title and create a new file, when you change it back to the old name, it stands still there with all the revision history

Closing this because:

Wiki don't get versioned under git
Wiki can lose history if the page title is changed
Wiki gets updates directly without reviewers and this makes it risky to maintain


Don't segfault when product name from BIOS is empty

Somehow some Dell servers we're trying to run a gRPC client on have an empty product name in the BIOS. When gRPC tries to create default credentials, it checks whether it's running on GCE by strcmp()ing the contents of /sys/class/dmi/id/product_name to some magic strings. When it reads that file, it gets only a newline; in trim() it skips over the newline in both directions, and since end < start it returns nullptr. This causes a segfault in the strcmp() call. Since a machine without a product name clearly isn't GCE, change it to return false instead.

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.0%     +16 [None]                                                                    +72  +0.0%
  +8.5%     +16 src/core/lib/security/credentials/alts/check_gcp_environment_linux.cc     +16  +8.5%
       +45%     +29 grpc_core::internal::check_bios_data                                      +29   +45%

  +0.0%     +32 TOTAL                                                                     +88  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

PTAL. Clang format diffs were the only failing test in the sanity check.

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.0%     +16 [None]                                                                    +64  +0.0%
  +8.5%     +16 src/core/lib/security/credentials/alts/check_gcp_environment_linux.cc     +16  +8.5%
       +45%     +29 grpc_core::internal::check_bios_data                                      +29   +45%

  +0.0%     +32 TOTAL                                                                     +80  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,975,261      Total (=)      1,975,261

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,769,652      Total (>)     10,769,638

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

@coryan, will do an RC hopefully by tomorrow and release 1.14.2 patch after a few days. Have you verified the fix on master or using nightly builds from https://packages.grpc.io/ ?

@coryan, 1.14.2 RC is now available.

@srini100, good news, it works for us. Thanks for the quick turnaround.

Would it be possible to merge this fix to 1.13 which is still used by TensorFlow?
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/workspace.bzl

Thanks Nicolas!


runBNG SV

Hi,
I'm a bit confused how to compare two different cmaps from individuals of the same species using your script. The -r option is clear to me, but where can I define the query cmap? Is it the 'full path to final assembled folder, such as *exp_refineFinal1.' as written in the help print out? Anyway, I tried both but it says 'Some compulsory option is not given please check as following:'
My second question concerns the genome size. Do I need to estimate the genome size or should I give it the exact length in Mb that was assembled?
Thank you very much for showing a simple example how I should set up the command for SV detection between two cmaps assembled from two individuals.
cheers,
j

Hi @kkuonjj, if you want to directly compare two cmap files, you may use 'runBNG compare'. If you want to find SVs in the query sample, you may use 'runBNG SV'.
In the 'runBNG SV', except the '-b' option, others are all mandatory. You may check which option you have missed in your settings. For the '-f' option, it refers to the final denovo assembled folder. If you use 'runBNG denovo', the folder should be under the /path /to/your saved denovo assembly folder/contigs/exp_refineFinal1.
For the genome size, I suggest using the estimated genome size.
Cheers,
Andy


[SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate spark.sql.parser.escapedStringLiterals

What changes were proposed in this pull request?
This PR follows up https://github.com/apache/spark/pull/43187 and improve the test case.
Why are the changes needed?
Avoid create data set duplicately of the test case.
Does this PR introduce any user-facing change?
'No'.
Just update the test cases.
How was this patch tested?
Test cases updated.
Was this patch authored or co-authored using generative AI tooling?
'No'.

I am neutral about the changes.

OK. Let me revert the change you mentioned. But we can avoid create data set duplicately.

@MaxGekk Could you take a review again ?

Let's just merge but I would avoid such change in general.

Merged to master.

Let's just merge but I would avoid such change in general.

Yeah. It's a minor change. I will avoid the similar change ! Thank you !


AttributeError: module 'gpflow' has no attribute 'kernels'

For questions on how to work with GPflow, or support for problems that are not verified bugs in GPflow, please go to StackOverflow and use gpflow tag for your question.
Hi I installed gpflow package. When I tried to run a small code suggested in the document, code throws an error:
AttributeError: module 'gpflow' has no attribute 'kernels'
import gpflow
import numpy as np
import matplotlib.pyplot as plt
plt.style.use('ggplot')
import tensorflow as tf
%matplotlib inline
k1 = gpflow.kernels.Matern12(input_dim=1)
k2 = gpflow.kernels.Linear(input_dim=1)
k3 = k1 + k2
k4 = k1 * k2
Does anyone know the reason for this?
When I go to the gpflow package folder, I can see kernels.py file.
Any help would be much appreciated.
Thanks

Sounds like a path issue. How did you install gpflow?

@madudata61 this looks like an installation issue, not a bug in gpflow - if you still require some help, you'll need to provide a bit more information on what you tried to do to install gpflow. This may be more appropriate as a stackoverflow question (https://stackoverflow.com/questions/tagged/gpflow).


OTST_TS_OB_RFND_05_Generic_Reason_Code : Generic Refund Reason code Scenario

Description
The scenario will use the config file structure defnied in the issue  Improve usage of "type" from data_file to deliver a generic scenario Refund with reason code that could be run with as entry parameter the reason code to be used.
SFR
SSD: TBD

OTST meeting
For the moment we have one SSD per functionality (offer, booking, fullfilment, refund) see if
Dev on going, with first reason codes tested. Need to add tew scenarios for other reasons codes.
Thus in progress

Design done is done using the last version of the data file shared by Tim and Josef (even if not fully validated ).
Merge of all known refund scenario done. Should support other reason code providing they do not have a dedivated specific business logic.
Design for postman and the code for checks delivered.
Refactoring based on the feedback is done, but code is not committed as test sytem does not work. (Bileto and Sqills). Wait for regression test before committing.


Update testing README to reflect current structure

Just a note, some other parts of this read me might be out of date as well. For example running python3 junit/run_junit.py gives me an error, but running python ./junit/run_junit.py --build-type=debug --query-mode=simple doesn't give me an error. Also junit/README.md also seems to reference non-existent files.
As I get more familiar with the project I can try and make those updates if someone else isn't already planning on it.

Let's merge these changes into #1052


Fixed CSV export when custom query is used.

When you have a default query set up on a project, the CSV export will use it when a temporary (session) query is created.
Steps to reproduce:

Go to a project and set a default query that returns no data.
Create a temporary query that displays some issues.
Press CSV export.
Notice no issues are displayed in the export files.

If you consider the method to be overkill I can inline it.

@sdwolf Thank you very much!! and sorry for the late reply.


Coerce the labels passed to Index.query to array-like objects

When looking at #5691 I noticed that the labels are sometimes coerced to arrays (i.e., #3153) but not always.
Later in PandasIndex.query those may again be coerced to arrays (i.e., _as_array_tuplesafe). In #5692 (https://github.com/pydata/xarray/pull/5692/commits/a551c7f05abf90a492fb59068b59ebb2bac8cb4c) they are always coerced to arrays before maybe be converted as scalars.
Shouldn't we therefore make things easier and ensure that the labels given to xarray.Index.query() always have an array interface? This would also yield a more predictable behavior to anyone who wants to implement custom xarray indexes.

In #5692 (a551c7f) they are always coerced to arrays before maybe be converted as scalars.

This is not exactly true: slices are kept as-is.
#3153 is actually a workaround specific to Pandas index limitations (only float64 floating -point labels supported), so it would make sense to move this within PandasIndex.
Other use-cases like xoak point-wise indexing only support Variable or DataArray objects as indexers (to ensure that all indexers have the same dimensions).
So it would probably be better to leave indexers untouched and let Index objects do the validation and conversion.

leave indexers untouched and let Index objects do the validation and conversion.

So does this mean custom indexes have to implement vectorized or pointwise indexing on their own?

So does this mean custom indexes have to implement vectorized or pointwise indexing on their own?

No I don't think so (sorry my thoughts are still confusing), we would still use the current implementation in Xarray for positional (vectorized, pointwise, etc.) indexing.
Currently label-based indexers go through these normalization steps before passing them to Index.query:

cast floating-point labels to coordinate dtype (maybe_cast_to_coords_dtype())
convert DataArray objects to unlabelled data (via .variable.data)

The dimension (positional) indexers returned by Index.query may be also converted before passing them to .isel:

back to Variable or DataArray objects for advanced indexing

I think that PandasIndex should take care of 1. Casting floating-point labels (casting any object to a numpy array as a side effect) may be undesirable for other, custom indexes.
For 2 and 3, I'm not exactly sure what to do. We should probably avoid 2 since dimension labels are useful (e.g., it is used in .xoak.sel) and let the indexes handle that. This means that indexes should also handle 3. For pandas multi-indexes, this would allow us raising a more meaningful error message since they don't support DataArray or Variable objects as level indexers. It is also better to handle 2 and 3 in a per-case basis since a general solution for 3 is tricky with the new data model (non-dimensional indexes).
This means a lot of flexibility for custom indexes but also a great responsibility.


Add linting

Following on from https://github.com/spatialos/gdk-for-unity/pull/1306 this adds linting to the FPS Project

This PR is the BOM


Can't paste in source field

Describe the bug
Can't paste in any text field won mobile
To Reproduce
Open a new note and try to hold and paste. No context menu shows up
Expected behavior
Same behaviour as before for textfield with context menu to paste

Waiting for reply from https://discord.com/channels/910294799188385885/1117475362998329425

Made Irrelevant by #639


Store metadata for use in napari

see: https://github.com/ome/napari-ome-zarr/pull/47

Migrated to https://github.com/ome/ome-zarr-py/pull/174


add 'tests' to the excluded packages

Issue type

Bugfix

Summary
Add 'tests' to the exclude patterns for packages so that the included tests don't get installed on user's systems and potentially conflict with other packages that include "tests".

Coverage remained the same at 94.647% when pulling d3a12c1f4e36b2e6031c3a5bc6303f3d154fad47 on namarrgon:fix-tests-ignore into db8f80eeb1b4d1405816bd62c16ddb3364e0c46d on DinoTools:master.

Coverage remained the same at 94.647% when pulling d3a12c1f4e36b2e6031c3a5bc6303f3d154fad47 on namarrgon:fix-tests-ignore into db8f80eeb1b4d1405816bd62c16ddb3364e0c46d on DinoTools:master.


Make sure the sizing of the Main Window is correct

When showing Tomotroid and Pomotroid side by side Tomotroid looks slightly bigger. I think I have the dimensions wrong.

I believe I have the dimensions correct, it just looked a bit off because I was looking on Window 11 and Pomotroid had the rounded corners, but Tomotroid didn't.


[projmgr] enforced component selection using extended component identifier

The fundamental principle of CMSIS-Pack components is that componentIDs are unique after the filter conditions for each component have been checked.
This proposal is introducing a way to uniquely identify a component independently of the filter conditions by specifying the full <packID> and <conditionID> in addition to the <componentID>.
Extend the components node in cproject.yml/clayer.yml :
  components:
    - component: <componentID>
      from-pack: <packID>
      condition: <conditionID>

Note: this is the notation being used in cbuild.yml already today.
A component with such an extended component identifier will be always be included in the processing, regardless of the result of the condition evaluation just like any other component.

convert (write: *.cprj, *.cbuild.yml)
generator (read: *.cbuild.yml)
build (read: *.cprj)

If several components with the same <componentID> exist in the pack, it is required to add the <conditionID> to identify the exact component to be included otherwise an error will be issued.

I've got some  remarks and questions to this issue:

I would suggest using term "primary key" for full component identification, similar to relational database model
Should the tool issue a warning if the enforced component does not pass filtering?
Should the component's files be filtered or also enforced?
May two or more components be enforced if they belong to the same exclusive API or cause conflicts?
Should generated components have priority over the enforced ones?

"primary component ID" to make it more specific to the subject
probably not by default but maybe in a dedicated validation mode or verbose mode of list dependencies ?
In the absence of the condition evaluation, we have no criteria to choose the files. I suggest not to copy configuration files that have a condition
In my view, having multiple components being selected for a single exclusive "api" needs to be checked and reported regardless how a component is specified.
Similar to point 4 I think we should not have different rules ... but open for feedback.

In the absence of the condition evaluation, we have no criteria to choose the files. I suggest not to copy configuration files that have a condition

I believe that all files from a component can have conditions, not just config files. E.g. two copies of the "same" source file, one for ARMC6 and one for GCC. In that case I think we'd need to take some filtering into account when running the build.

@mcgordonite you are right, so a filter for conditions at file level needs to be applied.

@slhultgren please review the updated implementation for 1.7.0 and raise a new issue in case this does not meet your expectations.


xmr: monero crypto functions, tests

original PR: https://github.com/trezor/trezor-crypto/pull/162

basic crypto in ed25519 (ge, fe, sc) missing from the trezor-crypto, required for Monero.
Monero specific functions (e.g., sub-address computation, Pedersen commitments, base58 block-based, hash_to_scalar, hash_to_point, derivation to scalar)
serialization routines - simple variable sized integer serialization
memory optimized range proof, Borromean.
tests - should be covered pretty well.

Moved stuff not related to monero into:

ed25519-donna/ge25519.{c,h} - ge25519 related functions
ed25519-donna/modm-donna-32bit.{c,h} - bignum256modm related functions

I see. Just a quick question:

The corresponding tests will be also moved from the monero test file to the main test file?
Is modtrezorcrypto-monero going to stay the same / provide the same API for the micropython code? It might be not worth to move these non-monero ed25519 specific functions to other modules as none of existing provide such low level API.

The corresponding tests will be also moved from the monero test file to the main test file? Just curious.

Unsure for now, I might move them to test-ge25519 and test-modm

Is modtrezorcrypto-monero going to stay the same

I don't plan to change this

I suggest

moving bignum25519 related functions (curve25519_*) from ge25519.c to curve25519-donna-32bit.c and
moving ge25519 related functions (ge25519_*) from ge25519.c to ed25519-donn-impl-base.c.

What do you think, @prusnak?
There are a lot of unused functions in ge25519.c: curve25519_set_d, curve25519_set_2d, curve25519_set_sqrtneg1, ge25519_set_base, ge25519_neg_partial, ge25519_neg_full, ge25519_reduce. Are you going to use them in future, @ph4r05?

The following issue is related to the trezor-core monero pull request. Perhaps, it'll be a subject of a long-term plan with trezor-crypto.
I don't like the interface between trezor-crypto and trezor-core. It doesn't properly encapsulate cryptographic primitives. For example:

trezor-crypto contains functions unrelated to cryptography (base58.c).
Some cryptography is implemented in trezor-crypto (xmr_gen_range_sig), some in trezor-core (gen_mlsag_ext, generate_signature).
As a consequence of the previous point, trezor-core imports functions which, in my opinion, shouldn't leave trezor-crypto (ge25519_add).

Some functions are already used internally in the trezor-crypto, e.g., curve25519_neg is already used. But the functions you list are not used at the moment in trezor-core, may be later used when implementing multisigs / bulletproofs

After some time, when Monero code in trezor-core stabilizes, proves over time and new features are added the trezor-crypto <-> trezor-core probably changes but I don't think this is the first phase stuff.
MLSAG may need to be slightly changed when implementing multisigs (I made some preparations already but we will see after this phase starts) so I think it is definitelly better to have it in Python for now.

I was also looking into Bulletproofs for a while and due to large memory allocations I will implement it in Python, as a prototype. As I will need to dynamically allocate large key vectors and gc.collect() them after they are not needed anymore. And for Bulletproofs I need low level crypto API such as mulsub256_modm. Bulletproofs are rather complicated and I don't think it is doable directly in C on Trezor without prototyping and testing it in Python.

And frankly I don't see why trezor-core should not have access to crypto primitives such as ge25519_add

Because it's difficult to develop and maintain such a low-level code. It requires trezor-core developers to understand how ed25519-donna works. Which isn't easy since it uses several coordinates formates, reduced and fully reduced form of numbers, consttime and vartime functions.
I see you prefer trezor-crypto consists only of those functions which are CPU or memory intensive and/or easy to implement in C, which I partially agree with. But I'd rather trezor-crypto be cryptographic library with well-defined interface.

Just a side note: I think we're touching an issue of trezor-crypto becoming a library having two goals. First it is a cryptographic library, but second it is also becoming a place of all performance sensitive code.
It's something we were discussing internally briefly and I think it is on the long term roadmap. The ideal state IMHO is to have a cryptographic library (trezor-crypto) and then a simple way how to incorporate performance sensitive C code into trezor-core. Each trezor-core app would have some C code directly in the trezor-core app folder, which would also significantly increase its readability.
That being said, I think it's beyond the scope of this issue and is something we should tackle later on.

In the API there is only one form of the point representation - Extended Edwards (x, y, z, t)

What about point_norm which calls ge25519_norm? There is a normalised (with z=1) and general form of a point.

Note: Point normalization operation is typically performed when compressing coordinate point representation to the 32 B array as z needs to be 1. It requires to compute inversion which is not for free.
On the other hand, the original Monero C++ code typically operates on 32 B keys by decompressing and compressing it after each result so they are doing normalization in each step, basically.
There are some optimized chunks, e.g., range sig verification, which improves blockchain scanning (still takes 3 days to verify the blockchain). Optimized chunks are using different point representations to avoid redundant normalizations but in general cases, it is not a performance issue for the sake of correct computation, easy development and maintenance.

Hmm I will try bn_

Ah I see.
The thing is normalization is needed after multiplication (I think, it been a while I implemented this part).
Normalization is performed:
void ge25519_scalarmult_base_wrapper(ge25519 *r, const bignum256modm s){
	ge25519_scalarmult_base_niels(r, ge25519_niels_base_multiples, s);
	ge25519_norm(r, r);
}

void ge25519_scalarmult_wrapper(ge25519 *r, const ge25519 *P, const bignum256modm a){
	ge25519_scalarmult(r, P, a);
	ge25519_norm(r, r);
}

ge25519_add trully can return non-normalized point. In spite of that, all the Monero crypto code works properly without need to bother with the normalization issue - python Monero code does not call normalization at all.
So the question is:

Is there a python way (using extmod-monero) to get invalid computation because of addition not normalizing points all the time? There is obviously none in the current Monero code so non-norming in this particular case does not cause any trouble to the trezor-core user.

If such PoC exists in the python I can easily add additional norming step in the trezor-core etmod-monero module so python layer gets normed point always. Will that fix it for you?

Is there a python way (using extmod-monero) to get invalid computation because of addition not normalizing points all the time?

Honestly, I don't know what (or when) operations do require normalised points. I'll try to figure it out.

If I remember correctly there was an issue with scalar multiplication.
If I comment out point normalization in ge25519_scalarmult_wrapper tests break.

Hm.. It seems we could get rid of the point normalization in general. I think there is just a problem with ge25519_eq which does not work well with non-normed points.

So, Extended Edwards coordinates (X, Y, Z, T) where it holds:
x=X/Z
y=Y/Z
x*y=T/Z

Thus lets have:
P1=(X1, Y1, Z1, T1)
P2=(X2, Y2, Z2, T2)

x1 = X1/Z1, y1 = Y1/Z1
x2 = X2/Z2, y2 = Y2/Z2

To check if P1==P2 we check x1==x2 && y1==y2, right?
That would be:
X1/Z1 - X2/Z2 == 0 && Y1/Z1 - Y2/Z2 == 0

Which should be equal as: (pls check)
X1*Z2 - X2*Z1 == 0 && Y1*Z2 - Y2*Z1 == 0

Is that correct?

OK found it. The test for point lying on the curve ge25519_check does not work on non-normalized point.
This check was performed also in ge25519_eq which is not needed, I will remove it. Testing if point lies on the curve is typically performed after point decompression - point is normalized right after decompression.
So I suggest:

Remove all normalizations ge25519_norm in crypto operations
Change ge25519_check to ge25519_normed_check so it is obvious the point has to be normed for this check.
trezor-core: if needed, extmod will norm the point before checking if the point lies

OK found it.
The first thing: ge25519_eq is correct. The problem is it performed also point-on-curve ge25519_check check (which was extraneous) and the check does not work with non-normalized points (@onvej-sl pls check). I removed this check from ge25519_eq so normalization is not required. Point check is meaningful operation after decompressing the point - the point is normalized after decompression - so the check works.
The another thing: I think the problem is that ge25519_scalarmult is not returning completely valid Extended Edwards point.
@prusnak pls consider cherry picking d628ce7ee529a65f953e7812063cd9ef5dad63ab to the monero branch.
@onvej-sl Example where problem occurs if normalization is not performed:
void xmr_add_keys2(ge25519 * r, const bignum256modm a, const bignum256modm b, const ge25519 * B){
	// aG + bB, G is basepoint
	ge25519 aG, bB;
	ge25519_pniels bBn;
	ge25519_p1p1 p1;
	ge25519_scalarmult_base_niels(&aG, ge25519_niels_base_multiples, a);
	ge25519_scalarmult(&bB, B, b);
	ge25519_norm(&bB, &bB);  // dies not return valid result if bB is not normed

        // Tried also http://hyperelliptic.org/EFD/g1p/auto-twisted-extended-1.html#addition-add-2008-hwcd-3 with the same result
	ge25519_full_to_pniels(&bBn, &bB);
	ge25519_pnielsadd_p1p1(&p1, &aG, &bBn, 0);
	ge25519_p1p1_to_full(r, &p1);
}

So if output from ge25519_scalarmult is an input to point addition (tried both algorithms, ge25519_pnielsadd_p1p1 and addition-add-2008-hwcd-3) the result is invalid.
As it should hold:
x=X/Z
y=Y/Z
x*y=T/Z

I verified if these 3 equations hold for the point returned from ge25519_scalarmult simply by normalizing the point bB to a new variable N to get x, y. Then it should hold (pseudocode):
zinv = curve25519_recip(bB.z)
N.x == bB.x * zinv
N.y == bB.y * zinv
N.x * N.y == bB.t * zinv

The third equation does not hold (most of the time) for the bB.
So I propose to use point normalization after the scalarmult operation, i.e., use the wrapper ge25519_scalarmult_wrapper. And all other normalizations can be removed.
@prusnak @onvej-sl pls consider cherry-picking 2c9d42475482ef78269065774db3af2e735c57a1 commit which contains changes described in this comment.
Moreover, I did another small PR fixing a small issue that ge25519_scalarmult result parameter could not be the same as the input point parameter: https://github.com/trezor/trezor-crypto/pull/171/files

OK found it.
The first thing: ge25519_eq is correct. The problem is it performed also point-on-curve ge25519_check check (which was extraneous) and the check does not work with non-normalized points (@onvej-sl pls check). I removed this check from ge25519_eq so normalization is not required. Point check is meaningful operation after decompressing the point - the point is normalized after decompression - so the check works.
Another thing: The problem is that ge25519_scalarmult is not returning completely valid Extended Edwards point. The last line manipulating the result before returning:
ge25519_p1p1_to_partial(r, &t);

I've fixed so it returns always fully valid extended Edwards point. Because of this no normalization is required. This saves also performance as we avoid modular inversion.
@prusnak @onvej-sl pls consider cherry-picking 3f4cfecd1f82c1a2debbe9484a05b75531e9f8f4 commit which contains changes described in this comment, also the a6d34c95e79a53902ef79d978ba92429f522996e.
I did also a separate PR fixing mentioned issues of ge25519_scalarmult in https://github.com/trezor/trezor-crypto/pull/171/files

Aah OK then. Thanks! So I will add a check for the z coordinate.
I will double check why I assumed the ge25519_check is not working but I
think it was because of invalid T coordinate from scalarmult.
Normalization was just a workaround to get full and valid extended edwards
point. As scalarmult computed only with _partial the T coordinate was
invalid. Normalization recomputes T coordinate from X, Y, Z which are OK
for partially computed point so normalization fixed it. But it is not
needed if scalarmult returns proper full point - just one more
multiplication is needed.
po 20. 8. 2018 v 13:23 odesílatel Ondřej Vejpustek<EMAIL_ADDRESS>napsal:

X1Z2 - X2Z1 == 0 && Y1Z2 - Y2Z1 == 0
Is that correct?
You also need to check Z1 and Z2 are non-zero, which wasn't necessary
before since the ge25519_check.
the check does not work with non-normalized points
It does work since the equation you are using (y * y - x * x - z * z -
ed25519.d * t * t) is the equation of the Edwards curve in projective
coordinates. I also did some testes to be absolutely sure.
I've fixed so it returns always fully valid extended Edwards point.
Because of this no normalization is required.
Could you explain it to me? I can't see a connection between normalisation
and extended coordinates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/trezor/trezor-crypto/pull/169#issuecomment-414283281,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAQWULfjZqR3j20LBj5rs0X92IF7u7bks5uSpxMgaJpZM4VoIf6
.

Just to sum-up discussion with @onvej-sl:

ge25519_eq don't need to check for Z==0 as the valid point cannot have Z==0. The points can be created only by unpack which does not allow invalid points or by operations which return valid points. We can either note the fact both points for ge25519_eq need to be valid in the comments or return ge25519_check to the ge25519_eq to make it more robust, but quite redundant. Up to discussion.

ge25519_check works for non-normalized points. There was a misunderstanding of the tests failing and wrong assumptions (scalarmult returns partial points only, not full). I've created new PRs https://github.com/trezor/trezor-crypto/pull/171 https://github.com/trezor/trezor-crypto/pull/172. Whether to use the change I proposed or different possible alternatives is up to discussion.

Correct?

Correct?
Absolutely.

And we decided ge25519_eq to be more robust and to check point validity.

ACK
Nevertheless, I created this issue, since I'm not one hundred percent sure that there isn't any unexpected edge case behaviour.
Please consider merging this PR before.


split miniimagenet to train val and test

hello,
i ran the code for classification on google colab, downloading files on google drive.
the images folder containing 60,000 images crashes as google drive cannot handle so many files within one folder.
is a modification in the code, that is split into train, test and val folders, that contain images possible, this is the link for these splits
https://meta-transfer-learning.yaoyao-liu.com/download/
thanks
ok I was able to run it

Glad to hear you got it to work! Sorry I didn't have time to look into this yet. Did you use the split or did it work without? I like the suggestion of using the split. If you managed to integrate this it would be great if you can open a pull request :)

I modified the classification code , I ran it with adabound optimizer, cosine annealing scheduler, and added dropout, should I create a pull request, I have modified certain things, I forked and uploaded it there.
I split dataset into train, val and test, and placed them in miniimagenet/{train}{val}{test} folders.
also, how to make cavia transductive, or proto cavia, just like we have transductive maml, and proto maml.

Cool! Did you run the experiment with those changes? I'm very curious what will happen and if you can get an improvement.
A pull request with just the train/va/test set split would be great.
I haven't looked into something like transductive / proto cavia. For Proto-MAML, are you referring to this paper https://arxiv.org/pdf/1903.03096.pdf? I think something similar can be done with CAVIA as well. I'm not familiary with transductive MAML, could you point me to a paper? (Also happy to continue this via email -<EMAIL_ADDRESS>


Double asuswrt sensor

Home Assistant release with the issue:
0.83.2
Last working Home Assistant release (if known):
N/A
Operating environment (Hass.io/Docker/Windows/etc.):
Docker on centos 7
Component/platform:
asuswrt sensor
Description of problem:
Upload/download sensor is showing up twice

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
asuswrt:
  host: !secret device_tracker_asus_host
  username: !secret device_tracker_asus_username
  mode: ap
  ssh_key: !secret device_tracker_asus_ssh_key

device_tracker:
  - platform: owntracks_http
  - platform: asuswrt
    new_device_defaults:
      track_new_devices: false
      hide_if_away: true

sensors:
    - platform: asuswrt

Additional information:

Hi! Remove the sensors platform and the device_tracker
Its setup through platform only atm.

Closing due to lack of response for 3+ months.


identifyPanel widget, export button issue

the dialog box is maximized. Not sure if there is any setting we can use to change that.
I am using the most current Develop version. (very good enhancement!)
Thanks.
ERS-Long

@ERS-Long This is something I noticed the other day and is actually a CMV bug introduced in the latest commits. The fix that I will submit is to change this line to this:
class: parentId + ' ' + widgetConfig.type + 'Widget',

Of course there is always more than one way to skin a cat. You can include a style property in the widget's options to set the width and height. That's true for pretty much any widget. Something like this:
style: 'width: 285px;height:320px;max-width:98vw;max-height:98vw',

or for the floating pane itself as we do for help widget
Since the issue is specific to CMV and not the widgets themselves, I am going to close this issue.


Perhaps should not receive value update via props

Thanks for the component! It's soooo close to exactly what I need.
One small thing: The docs for SliderIOS state:

Initial value of the slider. …
This is not a controlled component, e.g. if you don't update the value, the component won't be reset to its initial value.

However, this component receives prop updates that affect the value. Should that simply be removed so that the component gets an initial value but not further updates?

Hi @rreusser,
As discussed in https://github.com/jeanregisser/react-native-slider/pull/24#issuecomment-205746032
the current implementation matches what SliderIOS does.
When you update the value prop it changes the thumb position. But you don't have to change the value prop after interacting with the thumb for it to stay at its position where you lifted your finger.
Let me know if all is clear.

Good catch! My mistake. I misinterpreted the what "not controlled meant." My code was accidentally modifying the value which in turn prevented the slider from being movable. Thanks for the clarification!


Correct the pg_dump --schema arg format

The args to pg_dump's --schema option are schema-name patterns, not table-name patterns.
For example, consider a Gonymizer config with: schema": ["foo", "bar"]
Prior to this change, the resulting pg_dump will look like:
pg_dump ... --schema foo.* --schema bar.* ...

The result is that pd_dump interprets foo and bar as database names with the * schemas, and, consequently, dumps all tables in the current databse.
After this change, the same config results in:
pg_dump ... --schema foo --schema bar ...

Which dumps just the foo and bar schemas, as expected.
Note, as per issue #112, pg_dump v14 will actually refuse to run with the existing incorrect arguments.  But while v13 will not complain, it does (as explained above) do the wrong thing. This change resolves #112 as a convenient side-affect.
Also worth noting, pg_dump's --exclude-schema option accepts the same format, but Gonymizer already does the right thing there 🙂

Thank you for adding these changes @pcolby !


Remove Unneeded Dependency

Change Type (required)
Indicate the type of change your pull request is:

[x] patch
[ ] minor
[ ] major

/canary


Fix: Allow smartSplit() to handle String of chars not just a single char

This commit adds the support of String separator in function smartSplit. Previously only char separator is supported. Now smartSplit can support String as well as single char as separator. Changed to existing implementation of overloaded constructor of CSVParser which takes string separator.

Hi @omkarnix, thanks a lot for this pull request! As discussed in the issue it would be great to have a few tests for this (as you have noticed the test coverage is really poor at the moment so we are trying to improve that for all new changes). Let me know if you need any help.

@wetneb, Sure Thanks for reviewing. Actually, I realized that low test coverage after creating PR and started the discussion on https://github.com/OpenRefine/OpenRefine/issues/1674. Will amend my PR with tests tomorrow and update! Thank you for quick responses and encouragement!

@wetneb Thank you very much for your support and encouragement on contribution. The community is very supportive. I would certainly try to contribute as much as possible!


Data Science with Python : Detection of Bright Spots in Images

Welcome to 'DSWP' Team, good to see you here
This issue will helps readers in getting all the guidance that one needs to learn about Detection of Bright Spots in Images. Tutorial to Detection of Bright Spots in Images and how it's applied using sample code.
To get assigned to this issue, add your serial numbers mentioned in the spreadsheet of "Data Science with Python", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
If you had referred any resources, add them up in "DS Resources". Similarly if you had used datasets, include them in "DS Datasets".
Domain : Computer Vision
Mentors Assigned : Yash Goel / Jivitesh Jain
Points to Note :
The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Changes should be made inside the Datascience_With_Python/ directory & Datascience_With_Python branch.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'GWOC' contributors of 'DSWP' domain.
All the best. Enjoy your open source journey ahead. 😎

Name: Hritik
Serial no.: 276
Discord: Hritik | Contributor
Type: Documentation
Approach: Explaining about the problem and how we are going to solve it. Providing code and demonstrating the results to solve the project.

Name: Freny
Serial number : 707
Approach : Documentation
How: Providing codes to detect bright spots using python and open CV and analyzing the results.

@freny24 @Hritik157 Already an issue each has been allotted to you.

Name: Parvati
Sl.no: 475
Discord: Parvati | Contributor
Type: Documentation
Approach: Write a python code (In Jupyter notebook with little information) to detect the bright spots in image.

Use Google Colab for documenting and adding code. Be elaborative. Issue assigned to @parvatijay2901 for documentation


It is recommended that the expost.core.ingress field be changed to optional

What can we help you?
Currently ExternalURL and expost.core.ingress fields are required, can they be changed to not required?
Currently we have a scenario where we only need to access the Harbor backend service, and it is accessed inside the k8s cluster, so it can be accessed through the service ClusterIp type of harbor core.

ExternalURL is a required configuration for the harbor-core because the harbor-core uses this configuration to generate the auth service URL.
ingress can be changed to not required

Fixed in #975


OSX build job on Travis CI seems too lenghty

[x] I have read through the manual page (man fzf)
[ ] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
I recently opened pull request #2269. I noticed that the build job of Travis CI on OSX was taking much more time than the Linux one, and it eventually failed after 50 min. I checked a couple of other last PR build jobs and it seems that the OSX build job always take about 20 min to finish, if not failing after 50 min. Maybe my changes did introduce a bug on this platforme, but it think there is something wrong with this high duration, though I am not able to tell what.

Thanks for the heads up. I've noticed that too and fixed it on master (disabling homebrew update).


Let edit tags and description within the datasets/maps item

If there is no description or tags, that field should be an "input" that lets users add any text (description) or any tag (separated by commas). Once it happens, description or tag/s are saved, and element appears as text. The same on maps

@xavijam can you provide more info about this please? thx

better description

aaaand design :)

edited!

thx!

I have a couple of questions on this one:

How does the input text / textarea should look like for both the description and tags? Should it just be a textarea that is submitted when the user hits enter? What happens with lines breaks? Should it have a submit button?
Tags are now displayed below the description (not as displayed in the attached mockup). I assume the mockup is wrong.

Please clarify @saleiva.

Line breaks should be done when clicking cmd+enter - IMO.
Where?  You mean in the maps? In the datasets view? You forgot to attach the mockup :P

Sorry, I was referring to the screenshot you attached. But I was confusing the maps and datasets view. So let's forget about 2. and focus on 1. How do the inputs/textareas will look like? Do we have a mock for that somewhere? Thx

Preparing it for you :)

Done in the dashboard sketch file

Thanks!

@saleiva Thanks for the screenshots. I don't quite get the yellow background and horizontal lines... Are those visible or just there to help?
I almost have the editable description :). These are the things I've implemented so far:

Clicking "Add description..." toggles the textarea.
Hitting Esc or clicking outside of the textarea displays the link again.
Hitting cmd+enter introduces a newline in the textarea.
Hitting enter saves the field (only if the textarea is not empty).
Length of the field is limited to 200 chars.
Markdown is supported and HTML is sanitized.

This is how it's looking right now:

Looks great.
The point of the style is to not have a square about the text that moves everything else when appearing. The idea is to give it that 'notebook' style by adding the yellow bkg and the lines.

:+1:

Everything is looking great so far. The only place where this looks a bit funky is when editing tags of a dataset:

@saleiva @xavijam: Should we make the editable area a bit narrower? Is it okay to align the text on the right?

IMHO, it should be narrower. About the direction... difficult, because it is displayed aligned to the right, but we should type them at left... Let's try with this option and then we will have time to change later.

Also, I decided not to use the tag-it plugin because it didn't add any value here... Do you guys think that we should specify that tags should be separated with commas? We could use the placeholder for this.

This is ready for CR! :sweat:
@xavijam @viddo can you please CR? thx!

Where is the PR/the changes? Also, it makes it easier to test if you deploy on a staging. :)


Reorganise documentation

This PR reorganizes guides pages into separate sections, one level up.
Testing section has been split into many smaller pages.
Each cheatcode has its dedicated page now.
Sidebar is fully autogenerated from filesystem.
Replaced all absolute URL links with relative Markdown links, so that Docusaurus can maintain valid links througout documentation.
Added redirects to old URLs so that we do not break any existing blogposts.

Let me know when it's deployed - i will update my article then :)

Cheatcodes order is weird. We should sort them by name or importance (which needs to be defined).

I have preserved existing order, but overall I am big 👍🏻 for lexical sorting. Doing so.

@MaksymilianDemitraszek said:

I think drop-down menu being also an overview section is very confusing. Can we make overview sections explicit?

@MaksymilianDemitraszek said:

I think drop-down menu being also an overview section is very confusing. Can we make overview sections explicit?

Docusaurus seems to have such convention to have overview pages. But there's not a problem for me to create separate page (Fundamentals) for Testing. More tricky is the layout for cheatcodes, as personally I like how it looks.

It is kinda nice, but I would never find the page if i didn't know it has to exist somewhere 😅


[Release fix] Update asset manifest to include application.css

Description
The new version of the sprockets gem asks for an explicit declaration of application.css in app/assets/config/manifest.js. This PR does so.
Notes
It's unclear if anything actually broke or what triggered the error, since the website continued to function fine.
Tests
Since this is part of rendering actionview templates, testing endpoints that return html should test this. As noted above, currently rendering appears to continue to work.

Fixing this didn't fix the issue with importing font urls unfortunately :/


Montage repr

Since some montages have the fiducials in the file, the __repr__ is incorrect.
for instance biosemi-64 displays the following:
<Montage | biosemi-64 - 67 Channels: Fp1, AF7, AF3 ...>

PR on the way?

I can do it tomorrow afternoon. preparing for my department talk tomorrow :/ and noticing things as I am powering through.

I think to fix this, we need to have point_types, the fiducials are being counted as channels in the representation

Improve the doc and message is easier


Add Brilliant International Private School to the list of schools

Website: www.bips.ae

@AzureStar123 First stage of verification passed, official domain is bips.ae as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@AzureStar123 Pull request merged. Thank you.


Fix configuration for LGTM

Signed-off-by: Stefan Weil<EMAIL_ADDRESS>

Is there a way to configure Coverity scan?
I see that it has warnings for abseil and googletest source files.

In theory there is a way, but in real life there is a bug in Coverity Scan which makes that impossible since a few months.


ci: refine terraform k3s cloud-init scripts to support k8s v1.25

ci: refine terraform k3s cloud-init scripts to support k8s v1.25
For https://github.com/longhorn/longhorn/issues/4807
Signed-off-by: Yang Chiu<EMAIL_ADDRESS>

This change should only apply to the master/1.4 w/o any backports.


Add StatementDescriptor on Refund

See: https://mangopay.com/docs/release-notes/hongze

@williamdes, I've submitted another PR #640 with these changes. It will become unnecessary once my PR is merged into the master branch.


ValueError: A KerasTensor cannot be used as input to a TensorFlow function.

While converting onnx model of yolov7 w6 to tflite getting the below error-
`Checking 0/1...
ValueError                                Traceback (most recent call last)
 in <cell line: 3>()
1 #%cd /content/drive/MyDrive/yolov7/repo/yolov7/onnx2tflite/onnx2tflite
2 from onnx2tflite import onnx_converter
----> 3 res = onnx_converter(
4         onnx_model_path = "/content/drive/MyDrive/yolov7/repo/yolov7/modified_yolov7-w6.onnx",
5         need_simplify = True,
5 frames
/usr/local/lib/python3.10/dist-packages/keras/src/backend/common/keras_tensor.py in tf_tensor(self, dtype, name)
136
137     def tf_tensor(self, dtype=None, name=None):
--> 138         raise ValueError(
139             "A KerasTensor cannot be used as input to a TensorFlow function. "
140             "A KerasTensor is a symbolic placeholder for a shape and dtype, "
ValueError: A KerasTensor cannot be used as input to a TensorFlow function. A KerasTensor is a symbolic placeholder for a shape and dtype, used when constructing Keras Functional models or Keras Functions. You can only use it as input to a Keras layer or a Keras operation (from the namespaces keras.layers and keras.operations). You are likely doing something like:
x = Input(...)
...
tf_fn(x)  # Invalid.

What you should do instead is wrap tf_fn in a layer:
class MyLayer(Layer):
    def call(self, x):
        return tf_fn(x)

x = MyLayer()(x)

Thanks for your issue and suggestion, but I don't have time to maintain onnx2tflite anymore. If you can solve it and submit a PR, I would be happy to help you merge it.


Add fabrial item sheet

We need to add a fabrial item sheet

Closed as this will be offloaded to the stormlight world module.


reactions-avatars - Support new issue view

part of #7856

Test URLs
https://togithub.com/eslint/eslint/issues/3565
Screenshot
https://github.com/user-attachments/assets/f33689a8-e466-4f7c-a836-5cd7b841cbf5

Don't forget to link the original issue, like:
- part of #7856

This selector needs to be adjusted:
https://github.com/refined-github/refined-github/blob/f7617783376d3b31f359373cf52d56cdf0ffb2f3/source/features/reactions-avatars.css#L9-L10

Also I'm seeing an error on discussions: https://github.com/orgs/community/discussions/5841
❌ Refined GitHub: reactions-avatars
errors.js:77 📕 0.0.0 → SyntaxError: Failed to execute 'querySelector' on 'Document': '[href="/    🚀
            3
" i] img' is not a valid selector.
    at $ (select-dom.js:8:38)
    at getUserAvatar (get-user-avatar.js:8:25)
    at getParticipants (reactions-avatars.js:53:20)
    at reactions-avatars.js:86:19
    at Array.map (<anonymous>)
    at showAvatarsOn (reactions-avatars.js:86:5)
    at IntersectionObserver.rootMargin (reactions-avatars.js:65:4)

Before this PR, the error was there, but different:
❌ Refined GitHub: reactions-avatars
errors.js:77 📕 0.0.0 → TypeError: Cannot read properties of null (reading 'textContent')
    at getParticipants (reactions-avatars.js:24:4)
    at reactions-avatars.js:64:19
    at Array.map (<anonymous>)
    at showAvatarsOn (reactions-avatars.js:64:5)
    at IntersectionObserver.rootMargin (reactions-avatars.js:49:4)

Just to be clear, the new error is specifically because getParticipants is returning bad data, so it ends up in the selector

Sorry I had pointed you in the wrong direction, it was not :last-of-type but the regular margin-right that needed to be increased.

Adjusted, restested, merging…

This would also be good to address, it's not in the original list of broken features: https://github.com/refined-github/refined-github/blob/db5e00462bdbe398512f223cabb41961e81fc559/source/features/center-reactions-popup.css#L4


Merging efforts

Hi,
Thank you for tackling the combine requirements issue. I believe this will help a lot but will require a lot of contributions.
There is another port being build at https://github.com/cx-org/CombineX.
Maybe you could merge yours efforts ? I'm opening the same issue on the other repo.

Hi!
The author of CombineX has reached out before (see #4) and said that they would contribute to OpenCombine instead of developing their own project, but for some reason changed their mind.
In no way am I judging them, working on a project like this is indeed too much fun to be left for somebody else :)
I've looked at CombineX before and I can tell that there's a significant difference at how we see the development process and the little things like coding style, git workflow, implementation details etc.
That's why I think that at this point merging efforts would actually slow down the development process.

Good to know, sorry I missed the issue.

Corresponding issue: cx-org/CombineX#19


chore: error handling

#101

:tada: This PR is included in version 1.40.1 :tada:
The release is available on:

v1.40.1
GitHub release

Your semantic-release bot :package::rocket:


Highscore rank does not follow pagination

Each page of the highscore starts with rank 1. It should be offset by the pagination parameters

Will be fixed when we add seasons and a highscore table


Yaw remove slewrate

Similar to this PR but without manual changes.
This PR moves the heading computation from navigator to FlightTaskAuto, which will also remove
the continuous triplet update due to heading computation.

it is to note that during any ROI mission without gimbal control/rotation, the heading will still continuously be updated by the navigator

@Stifael Should we wait for https://github.com/PX4/Firmware/pull/10006 first?

@Stifael Should we wait for #10006 first?

yep, that makes sense. #10006 wasn't there when I created this PR

@Stifael Do we need additional flight tests?

@Stifael did you mean MIS_YAWMODE to control heading during a mission?

flashed the pr, i see MPC_YAW_MODE appears in 'other' parameters
would the value be similar to MIS_YAWMODE?
Values:
0: Heading as set by waypoint
1: Heading towards waypoint
2: Heading towards home
3: Heading away from home

similar:
0 towards waypoint
1 towards home
2 away from home
3 along trajectory
Set by waypoint  got removed because if will take precedence over MPC_YAW_MODE. Basically if the mission sends a valid yaw waypoint, then the vehicle will obey that yaw waypoint independent of MPC_YAW_MODE/.

thanks for the info, will test shortly

Some flights with pixhawk 4 (V5). Good flights, heading towards waypoint
https://review.px4.io/plot_app?log=3b1aaa4c-e1df-4a54-811d-1ec7de1270d1
https://review.px4.io/plot_app?log=3b1aaa4c-e1df-4a54-811d-1ec7de1270d1
https://review.px4.io/plot_app?log=a448d8cb-8654-4596-9d0a-4dae924b78f1
Some flights with pixhawk 2.1 (V3). Good flights, heading towards waypoint
https://review.px4.io/plot_app?log=83616e27-9612-4a71-a2a1-f732edf072cb
https://review.px4.io/plot_app?log=ea02ff15-43e9-4733-8ff9-f1c92b383257
https://review.px4.io/plot_app?log=ea02ff15-43e9-4733-8ff9-f1c92b383257

couple flights on a Pixhawk pro (v4):
https://review.px4.io/plot_app?log=97f18520-5fd9-4b17-a425-1118e0e051f9
https://review.px4.io/plot_app?log=b70f9c01-9a71-4098-943c-98b2862ac486
pixhawk mini:
https://review.px4.io/plot_app?log=ef395dc6-785b-4295-97cf-423577d80b74
https://review.px4.io/plot_app?log=bafc63ea-e1c2-4b5b-8aa2-e22b7272809b
pixhawk v2
https://review.px4.io/plot_app?log=d73899c2-2087-4f62-98fe-0ced68ca7c38
https://review.px4.io/plot_app?log=d73899c2-2087-4f62-98fe-0ced68ca7c38
land and rtl working properly

Few flights on a pixracer (v4)
mcp_yaw_mode set to 0,1,2,3 respectively per flight
https://logs.px4.io/plot_app?log=aec9e42c-94e9-4b3d-ac34-53113de5a712
https://logs.px4.io/plot_app?log=a062494e-114c-4024-b42e-0b006afabc1f
https://logs.px4.io/plot_app?log=80fd9e14-0219-47ea-8f0d-ae9f97535b0a
https://logs.px4.io/plot_app?log=d14d154f-22b3-442e-b06c-b1dbf8290c1f
everything looks to be working as expected


Broken Fragment Selector

Something in the last week has broken the selector (It can't even find the proper libraries). This occurred before me touching it today. I am currently investigating what the issue is.

The TFragmentSelector::Init() function is no longer being called.

This might be a root version issue.... works on 24, not on 30?

So it is something in one of my changes earlier. Turns out checking out old commits doesn't overwrite changed files. Go figure...

It's in loading the format library. I made a change for OSX that apparently didn't take properly. This may have always been a problem on OSX.

fixed in latest push.


[Docs][UI Next][V1.0.0-Alpha] Add license file.

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

The file corresponding to the license is already in dolphinscheduler-dis/release-docs/licenses/ui-next-licenses .

Codecov Report

Merging #8703 (6c2a4e8) into dev (63c476a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8703      +/-   ##
============================================
- Coverage     45.30%   45.29%   -0.02%
  Complexity     4075     4075
============================================
  Files           700      700
  Lines         27050    27050
  Branches       2894     2894
============================================
- Hits          12255    12251       -4
- Misses        13643    13647       +4
  Partials       1152     1152

Impacted Files
Coverage Δ

...olphinscheduler/rpc/remote/NettyClientHandler.java
41.86% <0.00%> (-9.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c476a...6c2a4e8. Read the comment docs.


more svelte action ideas

https://mobile.twitter.com/lihautan/status/1350083142833487874/photo/1

devon govett suggests the hooks from his React Aria package https://github.com/adobe/react-spectrum/tree/main/packages/@react-aria/interactions/src

devon govett suggests the hooks from his React Aria package https://github.com/adobe/react-spectrum/tree/main/packages/@react-aria/interactions/src

Since Svelte does not have a way to forward all the events from a DOM node (e.g., on:* — which I think is so bad it should never be shipped to Svelte) we're stuck with UI Kits that forward everything by hand.
I came up with an action, that will open up an react-alike API for events.
Child.svelte
<script>
	import { subscribeToEvents } from './utils.js';

	export let events;
</script>

<div use:subscribeToEvents={events}>
	Hey
</div>

Parent.svelte:
<script>
	import Child from './Child.svelte';

	const events = new Map();
	events.set('mouseover', () => console.log('mouseover'))
	events.set('click', () => console.log('click'))
</script>

<Child {events} />

I can update it to look better, but the idea stands.

Since Svelte does not have a way to forward all the events from a DOM node (e.g., on:* — which I think is so bad it should never be shipped to Svelte) we're stuck with UI Kits that forward everything by hand.
I came up with an action, that will open up an react-alike API for events.
Child.svelte
<script>
	import { subscribeToEvents } from './utils.js';

	export let events;
</script>

<div use:subscribeToEvents={events}>
	Hey
</div>

Parent.svelte:
<script>
	import Child from './Child.svelte';

	const events = new Map();
	events.set('mouseover', () => console.log('mouseover'))
	events.set('click', () => console.log('click'))
</script>

<Child {events} />

I can update it to look better, but the idea stands.

thank you for suggesting! this usecase looks a bit a bit abstract imo. mostly useful for library builders? would prefer to document in recipes then unless there is more popular demand.

thank you for suggesting! this usecase looks a bit a bit abstract imo. mostly useful for library builders? would prefer to document in recipes then unless there is more popular demand.

@sw-yx I'm on the same page with you. I came up with this action while discussing Svelte's potential with React folks, I have yet to find a single use-case in my real-world practice for it.
But I was told by the same React folks that every major company creates an in-house UI Kit, and being unable to work with events predictably pushes them away from adopting Svelte. I'm not sure if this belongs in this repo, recipes, tutorials or whatever. For now other guy from the same chat put the solution on the corresponding feature request on Svelte's main repo, hopefully it'll help someone.

@sw-yx I'm on the same page with you. I came up with this action while discussing Svelte's potential with React folks, I have yet to find a single use-case in my real-world practice for it.
But I was told by the same React folks that every major company creates an in-house UI Kit, and being unable to work with events predictably pushes them away from adopting Svelte. I'm not sure if this belongs in this repo, recipes, tutorials or whatever. For now other guy from the same chat put the solution on the corresponding feature request on Svelte's main repo, hopefully it'll help someone.

Is there a way to extract the active action from svelte-spa-router https://github.com/ItalyPaleAle/svelte-spa-router#highlight-active-links

Is there a way to extract the active action from svelte-spa-router https://github.com/ItalyPaleAle/svelte-spa-router#highlight-active-links

@jthegedus this maaaybe could be interesting - do you think most routers would have an opinion on how to do active links though?
i'm sure if we wanted to we could extract it, just want to make sure it is useful by most. i think this is ok...

Beautiful idea! Revising how I achieved this in my project can't help but think an action would be more reusable.
But just compare the code required for this task. It's monstrous for a reusable solution and barely 4 LOC for a sapper-specific one. Makes me think if it would really be useful.

do you think most routers would have an opinion on how to do active links though

Most routers will certainly have an opinionated way of doing this. The fact that not all routers come with this action standard is the real issue. Is there a way to ensure that SvelteKit/all Svelte routers come with this action? Although Sapper only needs a 4LOC implementation as @dkzlv notes, it's 4 lines people have to lookup, understand, implement, and maintain as the router changes over time. I just want use:active everywhere :sweat_smile:

i think its a valid thing to want. i have no insider info on what sveltekit will offer. we definitely dont have any dictat on what routers will have this action.
You know what - I'll add this to readme for now. can add if we have popular demand/once sveltekit comes out and doesnt have it.


VGGT section style corrections

HI @asanchez75
please:

make sure there is always vertical space between each teaser no matter the content type (3px at the bottom of the teaser).
make sure all the teasers use the same font size abd color
a) Title: 18px
b) date, location, data provider 13px #444444
c) description 13px #666666
hide the element class page-header so we can enable the panel title in the three pages. Beware that this class is used in other pages and should continue being visible in the other pages. It should be hided ONLY in the 3 pages of this section.

Please let me know if anything is not clear enough in this request. Thanks.

done

Hi @asanchez75
the point 3 isn't working. I enabled the title (on page/content) and now it is visible not just in the breadcrumb (which it is OK) but also in the body of the content, that is the one I wanted to hide:

thanks.


score is not displayed,

there should be score board at corner of the game that should display score.

@devsargam  assign me this issue , I will do it

@YugalPradhan WDYM? There is a score board

ok I got the issue , it's not about scoreboard , it's about reflexive website , in my 14 inch laptap scoreboard is not visible,
here is the screenshot-

I also have a 14' laptop but it works fine.

@YugalPradhan have you got any idea. How to fix this?

@xstable do you want to work on this?


Problem with the characters ' in value of variables

The substitution for the escape of ' not work.
I propose this correction :
diff --git a/read_ini.sh b/read_ini.sh
index 06b1bc8..2ae2a85 100755
--- a/read_ini.sh
+++ b/read_ini.sh
@@ -270,7 +270,7 @@ function read_ini()
                # enclose the value in single quotes and escape any
                # single quotes and backslashes that may be in the value
                VAL="${VAL//\\/\\\\}"
-               VAL="\$'${VAL/\'/\\\'}'"
+               VAL="\$'${VAL//\'/\'}'"

                eval "$VARNAME=$VAL"
        done  <"${INI_FILE}"

or use "shopt -s compat42"


Move shared layout template includes to lib folder

What
Move the contents of the app layout template includes that we would expect to be the same in every kit installation into the lib folder.
Why
Since the last release we have made a number of changes to the template partials in app/views/includes: in PR #1434 we removed the IE8 stylesheets; in PR #1478 we removed the jQuery script; and in PR #1481 we moved the common JavaScript into the lib folder and added a new script.
This file is in the user's space, but it would be nice if users didn't have to update it themselves. Moving the standard code out will also mean less is needed to bootstrap a prototype using a package.

This PR moves the standard lines in the template partials to new template partials in the lib folder, and replaces them with a placeholder comment illustrating how the user can customise their prototype if they wish.
We make sure that the lines in the kit templates are included first by inverting the control; by moving the lib folder first in the order of places to look for templates when the Nunjucks environment is configured we make sure that the files in the lib folder will be preferred, and then we include any app templates from the lib files.
This is similar to the method used in #1385 and #1481.

Closing in favour of #1517


Enable vectorization on z13

Enable vectorization on z13 to improve performance.

Can one of the admins verify this patch?

@tensorflow-jenkins test this please


pub workspace mixes plugins between projects

Steps to reproduce

Create 2 flutter projects in the same "pub workspace"
Have these projects uses different Flutter plugins (e.g. project1 uses url_launcher and project2 uses webview_flutter).

Expected results
The 2 projects should be separated. The plugins used by one project should not leak to the other projects (for binary size reasons?).
Actual results
After you run flutter run (or flutter test), you notice that various files from project1 contains pointer to the plugins used by project2 (in files GeneratedPluginRegistrant.swift|java)
Example in GeneratedPluginRegistrant.swift in project2:
import url_launcher_macos
import webview_flutter_wkwebview

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
  UrlLauncherPlugin.register(with: registry.registrar(forPlugin: "UrlLauncherPlugin"))
  FLTWebViewFlutterPlugin.register(with: registry.registrar(forPlugin: "FLTWebViewFlutterPlugin"))
}

Code sample
git clone https://github.com/xvrh/pub_workspace_test
Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Flutter (Channel main, 3.26.0-1.0.pre.131, on macOS 14.5 23F79 darwin-arm64, locale en-BE)

Reproducible using the repository provided above.

flutter doctor -v
[!] Flutter (Channel master, 3.26.0-1.0.pre.129, on macOS 14.6.1 23G93 darwin-arm64, locale en-US)
    • Flutter version 3.26.0-1.0.pre.129 on channel master at /Users/deanli/dev/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b4903228eb (9 hours ago), 2024-09-15 22:29:13 -0400
    • Engine revision 9aaea5a4bd
    • Dart version 3.6.0 (build 3.6.0-255.0.dev)
    • DevTools version 2.40.0-dev.1

Is this only happening for macOS / iOS targets or for Android as well?

@bkonyi It happens for all platforms.
In Android, the GeneratedPluginRegistrant.java will contains references to plugins that are not referenced by the current project.

GeneratedPluginRegistrant.java
@Keep
public final class GeneratedPluginRegistrant {
  private static final String TAG = "GeneratedPluginRegistrant";
  public static void registerWith(@NonNull FlutterEngine flutterEngine) {
    try {
      flutterEngine.getPlugins().add(new io.flutter.plugins.urllauncher.UrlLauncherPlugin());
    } catch (Exception e) {
      Log.e(TAG, "Error registering plugin url_launcher_android, io.flutter.plugins.urllauncher.UrlLauncherPlugin", e);
    }
    try {
      flutterEngine.getPlugins().add(new io.flutter.plugins.webviewflutter.WebViewFlutterPlugin());
    } catch (Exception e) {
      Log.e(TAG, "Error registering plugin webview_flutter_android, io.flutter.plugins.webviewflutter.WebViewFlutterPlugin", e);
    }
  }
}

This is an important bug because it means the final application will be bundled with a bunch of unused native code.
It seems the plugins are derived directly from the package_config.
https://github.com/flutter/flutter/blob/2528fa95eb3f8e107b7e28651a61305d960eef85/packages/flutter_tools/lib/src/flutter_plugins.dart#L91
We should add a filter using the pubspec.yaml

We should add a filter using the pubspec.yaml

We can't filter with pubspec.yaml directly, beceause it doesn't contain the transitive dependency tree.

@stuartmorgan of course, I meant start from the pubspec.yaml and transitively discover all real sub dependencies.
We may even fix an other problem: which is to not include plugins from "dev_dependencies". But this is less important and probably a breaking change to think of separetely.

The same approach as taken in https://github.com/flutter/flutter/pull/160443 might generalize


ad plugin in "external plugins" list

Added new line with "Ad plugin" in doc/EXTERNAL_PLUGINS.md.

Coverage decreased (-0.02%) to 71.56% when pulling bf26e81a68ae8007684ae429509ecaf11c1ea4a9 on vix-simplex:ad_external_plugin_to_doc into f8606f8b7c97cf5405977b1702d14447f4172b26 on clappr:master.

Coverage increased (+0.2%) to 71.775% when pulling 02da36f88b0b3ccac09c20f2db8f7c79b96edddc on vix-simplex:ad_external_plugin_to_doc into f8606f8b7c97cf5405977b1702d14447f4172b26 on clappr:master.

I'll merge it since it's just an update on readme. Thank you very much @vix-simplex


Retain table sort

The purpose of this PR is to fix https://github.com/aqualinkorg/aqualink-app/issues/114. The reef table on homepage was implemented using the material-table package, which caused issues with the redux-state. This implementation uses just custom MUI components

Closing for now in favor of #152.


[BUG] The clipboard is being used when browsing a feed

Please make sure you've tried the latest version of Fritter first, as the F-Droid version is sometimes out of date!

Describe the bug
Fritter reads the clipboard, or at least Android 12 says so.
To Reproduce
Steps to reproduce the behavior:

Open Fritter on Android 12
Tap "Feed"

Screenshots

Device
Pixel 5
Android 12 Beta (SPB5.210812.002)
App Version v2.14.0+20210910

This looks like it's caused by some behaviour in Flutter itself, and the PR has been merged in so it should be available in the next version of Flutter. I'll upgrade Fritter once that arrives, and this should get fixed automatically!

Just to keep this thread up-to-date - I've updated to the latest version of Flutter (v2.8.1) and this still occurs, so it looks like there's still some more work for the Flutter team to do, despite the above PR being merged in...


Could not find any version that matches com.algolia:algoliasearch-android:3.+.

I inserted the lib like was in site:
compile 'com.algolia:algoliasearch-android:3.+@aar'
But I got this error:
Error:Could not find any version that matches com.algolia:algoliasearch-android:3.+.
Search in build.gradle files

What is the real path to compile it?

Hi @paulokhouri, thank you for reporting this issue.
The documentation you mentioned is outdated, you should use this instead:
    compile 'com.algolia:algoliasearch-android:3.5'

I will update the documentation accordingly!

Thanx!!


Fix an exception (TypeError) in function getStereoscopeMode() on startup

2019-11-28 11:01:08.332 T:140554339870464   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--                                              - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!                                             Error Type: <type 'exceptions.TypeError'>                                             Error Contents: getStereoscopeMode() takes exactly 1 argument (0 given)                                             Traceback (most recent call last):                                               File "/storage/.kodi/addons/hyperion.control/service.py", line 221, in <module>                                                 hyperion = Hyperion()                                               File "/storage/.kodi/addons/hyperion.control/service.py", line 91, in __init__                                                 self.updateSettings()                                               File "/storage/.kodi/addons/hyperion.control/service.py", line 165, in updateSettings                                                 self.updateState()                                               File "/storage/.kodi/addons/hyperion.control/service.py", line 215, in updateState                                                 newMode = getStereoscopeMode()                                             TypeError: getStereoscopeMode() takes exactly 1 argument (0 given)                                             -->End of Python script error report<--

Thank you for you contribution. I really need check all these warning with the next code update :)


Are there plans to support WebP?

sink = wds.TarWriter('test.tar')
image_byte = io.BytesIO()
image = Image.fromarray(numpy.uint8(torch.randint(0, 256, (256, 256, 3))))
image.save(image_byte, format='webp')
sink.write({
    '__key__': 'sample001',
    'txt': 'Are you ok?',
    'jpg': torch.rand(256, 256, 3).numpy(),
    'webp': image_byte.getvalue()
})

For now, I have to transfer it by myself, while jpg and png can be stored directly.

You can just add a handler to webdadaset.writer.default_handlers, or you can completely override the encoder in TarWriter.
ImageIO seems to support it natively, so I may add it by default.
(This needs to be documented better and perhaps needs a nicer API.)


Fix release tags

Save and publish the the no-SUFFIX tags.
Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

I don't know what the PARENTDIRNAME was supposed to do, but it's not necessary.