Added Text Alignments. and fixes #583. Changed Clicked from Action to EventHandler per tenets.

This is really good work.
I don't think we can accept this until we have a clear conversation with @migueldeicaza  on backwards compat. Most of these changes from Action to EventHandler will break existing apps.
If you look at the inventory I created in #447, I suggested how we could do this in a way that is backwards compatible.
To be clear, my opinion is that we do what you have done and "do it right" and not clutter the code with a ton of legacy APIs. But Miguel knows more about what he's promised existing users and I think it is his call on whether we do this or not.
Because of this, it might be a good idea to break your TextAlignment changes out as a separate PR because that stuff looks like a no brainer.

I have never really liked EventHandlers, going all the way back to WinForms, and would rather use Actions which were introduced later.
Is there a reason to embrace that idiom, other than "This is what .NET in 2001 did"?

I have never really liked EventHandlers, going all the way back to WinForms, and would rather use Actions which were introduced later.
Is there a reason to embrace that idiom, other than "This is what .NET in 2001 did"?

Yes, I think I and others pretty clearly made the case for them here:
https://github.com/migueldeicaza/gui.cs/issues/101
Action was not invented to replace EventHandler but to compliment it. Action lacks pub/sub multiplexing, which is really important for UI idioms where multiple pieces of code want to subscribe to an event. We could build a pub/sub model on top of Action, but then....

It really gets a little difficult to work like that. If it is to impose big changes, the sooner the better, that is, before version 1.0 and not after getting used to the new model where you will see that there are different treatments for the same events. @migueldeicaza really @tig is right to adopt Event / EventHandler for the user's UI, because it allows for an interaction between the API and UI so that the user receives information about the object being passed (sender) and the information needed to interact with the API (e) that allows you to both read and send content. For example, in the case of Button why create a Selected event if it only serves to press or click and have two events to do the same thing?. User level changes are not very complicated, it is practically putting (o, e) inside the parentheses. I would like these rules to be well defined so that we do not have the feeling of wasting time. Thanks and sorry for something.

One thing that many folks do not realize is that every .NET delegate is multicast, which means that this works and does not even need "Action" to be flagged as an event:
Action a;

void setup ()
{
    a += method1;
    a += method2;
}

And this calls both methods.
The scenario that @Bdisp mentions is the demultiplexing of code, which is a rarely used feature, and everyone has to pay the price for it.   A solution that made sense when we did not have lambdas.   Nowadays the same demultiplexing can take place inline:
void SharedCode (int button)
{
   switch (button) {...}
}

button1.action = () => { SharedCode (1); }
button2.action = () => { SharedCode (2); }

Now, these are all old-way of managing events.   A more interesting discussion is whether embracing System.Reactive is the right approach, as it is a better framework for reasoning about events than these hooks.

We will have to pay a price for that, but with the increasingly powerful machines I think it would be insignificant. For me you are the master and your opinion counts a lot and what you decide I will always follow :-)

Ok, I was obviously wrong on Action and need to revisit some of my deepest thoughts. I will ponder this and consider what to do. I do think, in the end, being consistent is super important for a framework like this.
@Bdisp thanks for your work on this PR, but we are not going to merge it at this time.

Certainly @tig I understand. I will then submit the TextAlignment only. Thanks.

Certainly @tig I understand. I will then submit the TextAlignment only. Thanks.

It would be awesome if you took a swing at re-factoring the keyboard events using the draft guidelines I just put here:  https://github.com/migueldeicaza/gui.cs/wiki/Framework-Design-Guidelines

I think so.
This is all my fault because I pushed forward without waiting to hear from @migueldeicaza. Sorry about that.
Let's look at it as an opportunity to do it right and do it consistently though! ;-)

It would be awesome if you took a swing at re-factoring the keyboard events using the draft guidelines I just put here: https://github.com/migueldeicaza/gui.cs/wiki/Framework-Design-Guidelines

@tig do you mean these?
public override bool ProcessKey (KeyEvent keyEvent)
public override bool ProcessHotKey (KeyEvent keyEvent)
public override bool ProcessColdKey (KeyEvent keyEvent)

Well, those are the event raising functions, but, yes, those are the events I was asking about.
To be clear on what I'm asking:

I believe we should be consistent on how events are defined.
I believe we should do this before 1.0
I now believe we should rally around Action<T>.

I was hoping you'd take a look at those events and see how hard it would be to convert them to be Action<T> based. How hard would it be for subscribers to adapt?

I don't think it's that hard. I will contribute the best I can.

I'm a +1 for @migueldeicaza #reactive suggestion especially given the power of linq over events :D

@tig changing from EventHandler to Action is relatively easy. The question I have is how to proceed in those cases where the sender object is actually used to use its properties without having to declare the View's that are using it as public. I'm already dealing with that in the Terminal.Gui project.

I found this into Designer project for a generic handler. Really in that case the subscriber should be able to provide his original object. I'll ignore it.
		private static void LoginText_Leave (object sender, EventArgs e)
		{
			((TextField)sender).Text = $"Leaving from: {sender}";
		}

		private static void LoginText_Enter (object sender, EventArgs e)
		{
			((TextField)sender).Text = $"Entering in: {sender}";
		}

		private static void LoginText_MouseLeave (object sender, View.MouseEventEventArgs e)
		{
			((TextField)sender).Text = $"Mouse leave at X: {e.MouseEvent.X}; Y: {e.MouseEvent.Y} HasFocus: {e.MouseEvent.View.HasFocus}";
		}

		private static void LoginText_MouseEnter (object sender, View.MouseEventEventArgs e)
		{
			((TextField)sender).Text = $"Mouse enter at X: {e.MouseEvent.X}; Y: {e.MouseEvent.Y} HasFocus: {e.MouseEvent.View.HasFocus}";
		}

@tig it's all done in PR #632


Ask for support of Grove Base HAT for Raspberry

I want to ask for support the Grove Base HAT for Raspberry. It give also a HAT for Raspberry Zero.
http://wiki.seeedstudio.com/Grove_Base_Hat_for_Raspberry_Pi/
The hardware was found by the adapter...

The Grove Base Hat is only a wiring adapter. Which device do you have plugged into your hat? If it is an I2C device, this adapter might be able to help. If it is one of the other ports (PWM, Analog, GPIO), you would need to use the rpi2 adapter.

The grove hat has  a build-in MCU, a 12-bit 8 channel ADC. But I used in the meanwhile an other solution. I added the support for BH1750 and create a pull request.


Can it support USB CAM with YUYV format?

Hi mpomonet:
Can it support USB CAM with YUYV format?
I test it with a logitech USB CAM,and play rtsp stream with VLC,but can not play.The log in server side and player side is as following:
./v4l2rtspserver -fYUYV
2017-11-11 16:21:37,941 [NOTICE] - /home/test/v4l2rtspserver/src/main.cpp:548
Create V4L2 Source.../dev/video0
2017-11-11 16:21:38,055 [NOTICE] - src/V4l2Device.cpp:115
driver:uvcvideo 84200001
2017-11-11 16:21:38,055 [NOTICE] - src/V4l2Device.cpp:119
/dev/video0 support streaming
2017-11-11 16:21:38,075 [NOTICE] - src/V4l2Device.cpp:177
/dev/video0:YUYV size:640x480 bufferSize:614400
2017-11-11 16:21:38,095 [NOTICE] - src/V4l2Device.cpp:198
fps:1/24
2017-11-11 16:21:38,095 [NOTICE] - src/V4l2Device.cpp:199
nbBuffer:0
2017-11-11 16:21:38,095 [NOTICE] - src/V4l2MmapDevice.cpp:70
Device /dev/video0 nb buffer:10
2017-11-11 16:21:38,099 [NOTICE] - /home/test/v4l2rtspserver/src/main.cpp:566
Create Source .../dev/video0
2017-11-11 16:21:38,099 [NOTICE] - /home/test/v4l2rtspserver/src/DeviceSource.cpp:93
begin thread
2017-11-11 16:21:38,111 [NOTICE] - /home/test/v4l2rtspserver/src/main.cpp:161
Play this stream using the URL "rtsp://<IP_ADDRESS>:8554/unicast"
while the player side,the exception log:
Sending request: DESCRIBE rtsp://<IP_ADDRESS>:8554/unicast RTSP/1.0
CSeq: 3
User-Agent: LibVLC/2.2.2 (LIVE555 Streaming Media v2016.02.09)
Accept: application/sdp
[00007fbc00000958] lua art finder debug: Trying Lua scripts in /home/test/.local/share/vlc/lua/meta/art
[00007fbc00000958] lua art finder debug: Trying Lua scripts in /usr/lib/vlc/lua/meta/art
Received 101 new bytes of response data.
[00007fbc00000958] lua art finder debug: Trying Lua playlist script /usr/lib/vlc/lua/meta/art/00_musicbrainz.luac
Received a complete DESCRIBE response:
RTSP/1.0 404 File Not Found, Or In Incorrect Format
CSeq: 3
Date: Sat, Nov 11 2017 08:43:04 GMT
[00007fbbfc000e38] live555 demux debug: connection error 404
[00007fbbfc000e38] live555 demux error: Failed to connect with rtsp://<IP_ADDRESS>:8554/unicast
[00007fbbfc000e38] core demux debug: no access_demux modules matched
[00007fbc080009b8] core input debug: creating access 'rtsp' location='<IP_ADDRESS>:8554/unicast', path='(null)'

Hi codedigger123,
Not directly because v42rtspserver doesnot encode and there is no RTSP/RTP standard for YUYV.
But you can use an intermediate virtual video driver v4l2loopback and one encoder from v4l2tools to encode the YUYV to a compress format supported by v4l2rtspserver.
This should works with v4l2compress_h264, v4l2compress_jpeg and v4l2compress_vpx, I have still problem with v4l2compress_x265.
Best Regards,
Michel.

Hi Michel:
I know.thanks a lots!

Hi codedigger123,
An other way is to include encoding stuff in v4l2rtspserver.
Best Regards,
Michel.


how to use DownloadExt

my mlsql console ip is http://<IP_ADDRESS>:9002/ , and I drag and up load some file . then I use command：
run command as DownloadExt.`` where
from="public/sougou-train.tar.gz" and
to="/tmp/rawdata/sogo";
And I got error :
Connect to <IP_ADDRESS>:9002 [/<IP_ADDRESS>] failed: Connection refused (Connection refused)
org.apache.http.conn.HttpHostConnectException: Connect to <IP_ADDRESS>:9002 [/<IP_ADDRESS>] failed: Connection refused (Connection refused)
how to config the ip from <IP_ADDRESS> to <IP_ADDRESS> ?

I found that even I just upload one 3KB file , it won't be success :
Error: Server Error Sometimes this caused by your upload space is not enough or backend fails.

I found that on the server where I deploy mlsql-console , the files I upload already in the path : /tmp/upload :
[devuser@bdp-docker-01 mlsql-console-1.3.0-SNAPSHOT]$ ls /tmp/upload/b480131926edb08092a8a2df7c221655
20181221155904069.result.csv<PHONE_NUMBER>1131202.result.csv  sougou-train.tar.gz


[BUG] Cannot SwitchView to a view that requires scrolling to

Bug Report
Issues should only be created for items related to covered functionality.
Not covered functionality, feature requests, and questions should use the Feature Request or Question templates.
EasyRepro Version

[ ] Microsoft Dynamics 365 Online Version 8.2 (8.2.x) (DB 8.2.x) online
[ ] Microsoft Dynamics 365 Online Version 9.0 (9.0.x) (DB 9.0.x) online
[ ] Microsoft Dynamics 365 Online Version 9.0.2 (9.0.2) (DB 9.0.2) online
[x] Microsoft Dynamics 365 Online Version 9.1 (9.1.x) (DB 9.1.x) online

UCI or Classic Web

[x] UCI (XrmApp)
[ ] Classic Web (XrmBrowser)

Online or On Premise

[x] Online
[ ] On Premise

Browser

[x] Chrome
[ ] Firefox
[ ] IE
[ ] Edge

Describe the bug
When using SwitchView, the following error message is returned because the view being switched to is out of frame and needs to be scrolled to.
System.InvalidOperationException: No view with the name 'all field tasks' exists.

The image above shows that "All Field Tasks" is out of frame.
Special formatting / display
N/A
Code to reproduce

Expected behavior
View should be selectable.

I am having similar issue :  I change language  to French and it cannot seen to locate the french view banes.  In English, I can select the views.  Both languages are within viewable window.
xrmApp.Grid.SwitchView("English name works");
xrmApp.Grid.SwitchView("French name does not work");

@tdashworth Thank you for your input. I will take a look at this as soon as possible. Could you please provide the server version you are using located in the Settings->About page?

@aliyoussefi Thanks for taking a look.
Timestamp: 2022-01-27T15:14:21.593Z
Build name: 0.0.20220121.2-2201.3-prod
Version 1710 (9.2.21123.167) online


NPCLib Failed to initiate. Your server's version (v1_15_R1) is not supported

Describe the bug
Server Version is not Supportet?
NPCLib usage option
3
NPCLib JAR name
Server version
git-Paper-185 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)
To Reproduce
@Override 	public void onEnable() { 		NPCLib npclib = new NPCLib(this); 	}
Expected behavior
Failed to initiate
Screenshots
none
Additional context
none

Hi, thanks for opening this issue ticket!
NPCLib should support 1.15 R1. If you're using option 3, have you read the footnote?
If you do not want to have NPCLib in your plugins folder, you need to use the npclib-plugin artifact and shade it accordingly.

ohhh... thx i´m stupid. x_x


Setting of web application

It was required to use options --base --state (and -d/-D as was asked before) and specify reposlugs in the first basic filabel script. I would like to ask you - is this required also for the web application? (I know that the new script executed in shell must work the same as it was, I ask only regarding the web application). If I understood well - it is not required. Please, is an acceptable solution to specify repos in configuration files (e.g. line repos=something in section [github] in file bla.cfg)? I am not sure...
Sometimes I can see issues or PRs in English, sometimes in Czech, which language is preferable, please? Thank you for the response.

The web app can assume the default -d/-D.
State, base and reposlugs however don't make sense for the web app. Those are only useful where scanning repos. However the web app is just listening to webhooks. Once it receives one, it should try to act. Storing a list of reposlugs doesn't achieve any goal.
(I tend to use English everywhere on GitHub. However I respond to anything I can understand.)

(Not sure if this answers you question, feel free to close if yes or ask more specific things in return.)

Thank you for your response, now I understand more what the web app should do. Previously I thought wrongly that there should be displayed similar output as from the application executed from command line, too...


p2p & ZeroTier - can't see other players

We are using ZeroTier custom network along with p2p option (in desire for a better synchronization). Although we can successfuly connect to the server (running on my end), we do not see each other. This only happens with the p2p turned on.
Server config:
...
	<UseP2P>true</UseP2P>
	<UseZeroTier>true</UseZeroTier>
	<UseVoice>false</UseVoice>
	<ZeroTierNetworkID>*redacted*</ZeroTierNetworkID>
...

So what might be the issue here? Port is forwarded on the router and allowed on my PC.

It may be due to the updated Lidgren.Network in the latest release (actually it's the same library, only changed to a release build which has better performance than the debug build used previously).
Please try with this version, I reverted to the debug build
https://github.com/oldnapalm/RAGECOOP-V/releases/tag/nightly-build


Update harvest extension: major caching upgrade

Description
Improved how the caching is handled by all API requests improve stability and reduce the number of times the extension would get rate-limited by Harvest.
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

This PR includes changes inspired by #12600, plus a few other things. I hope I can still give credit to @klmz for his PR which inspired these changes!

Also, should fix #11983 and #11706

This is seems like a more robust solution than what I did. 👍  Happy to have helped!


Unconventional behavior in EmailAddress validator

Configuring a 'message' option on validators should return that single message on failure. (ref http://framework.zend.com/manual/current/en/modules/zend.validator.messages.html)

The second parameter defines the failure which will be overridden. When you omit this parameter, then the given message will be set for all possible failures of this validator.

I have a simple field in a sign up form whose counterpart InputFilter contains this configuration:
'validators' => [
                [
                    'name' => EmailAddress::class,
                    'options' => [
                        'useMxCheck'        => true,
                        'useDeepMxCheck'    => true,
                        'useDomainCheck'    => true,
                        'message'           => _( "Hey bud, check your email." ),
                    ],
                ],

In this case, unfortunately, we get a regex failure that's pretty cryptic on top of what we've set.

The input does not match against pattern '/^[a-zA-Z0-9.!#$%&'+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:.[a-zA-Z0-9-]+)$/'

The message configured should preempt the regex failure.

Are you using InputFilter? Then message could be defined at the same level of the input and should works too.

Also the behavior its supposed to be tested https://github.com/zendframework/zend-validator/blob/master/test/EmailAddressTest.php#L594
Please check again and provide a unit test showing the issue

Here's a quick repo that exhibits the behavior:
https://github.com/Saeven/validator_test
Can see it from the command line.  Email element types are being duplicitous it seems! ;)


Issue with required validation

Hi,
I am facing an issue while trying to implement the required validation. I am using angular's ng-messages to display the error message when the validation fails.
But the validation message does not get displayed although user is not able to submit the form if there is no value in the selector. The form valid and invalid bit is being set correctly. Please find the url of the plunk below:
http://plnkr.co/edit/Rwi4u27NqfzQ1f2yAyeW?p=preview
I have corrected this in my code using the custom template and adding the name attribute where required validation is used as follows:

Is there any other way of doing this?

Mmhh interesting. There's no way at the moment to handle the native angular form's properties, but it could be with a little update in the template.
Does this plunker fits your needs?
http://plnkr.co/edit/nvdAVhrVGEQ9UBlCXe9a?p=preview

Since Angular Selector uses two types of input (an hidden select and a text input) some features you're looking for are not available. The plunker above lets you handle the $error property when the required validation is set. Let me know which properties you also need for validation.
This will absolutely be a part of the next release.

Hi,
The above plunker also creates one more issue as I have already tried it in my code.
. I have added the name attribute only to the input tag which is as follows as per plunker:
<input name="{{name}} Search" ng-model="search" placeholder="{{!hasValue() ? placeholder : ''}}" ng-model-options="{ debounce: debounce }"' +
'ng-disabled="disabled" ng-required="required && !hasValue()">'
But I cannot add the required validation to the select tag which is done in plunker as follows:
<select name="{{name}}" ng-hide="true" ng-required="required && !hasValue()" ' +
'ng-model="selectedValues" multiple ng-options="option as getObjValue(option, labelAttr) for option in selectedValues" ng-hide="true">
The issue with adding the required validation above is that if there is any invalid option in the select, then it sets the oldValue or newValue depending to undefined instead of setting to an empty array. In my code I had a dependency on two lists. So one lists got populated on the change of first one.
So the code breaks on line 464
'scope.change(scope.multiple
? { newValue: newValue, oldValue: oldValue }
: { newValue: newValue[0], oldValue: oldValue[0] });'
as it cannot access the 0th index of undefined.
I mainly need the required validation and a class by which we can set the select to invalid in case we need to add css to it.

That's not totally correct, the only update I made in the template is this:
<		'<select name="{{name}}" ng-hide="true" ' +
>		'<select name="{{name}}" ng-hide="true" ng-required="required && !hasValue()" ' +

The name attribute in the <input> field was just a test, you need to handle only the <select> field.
The only issue I see in the plunker is at line 458, after removing the selected value. It can be resolved by updating the setValue() method like this:
scope.updateValue = function (origin) {
<	if (!angular.isDefined(origin)) origin = scope.selectedValues;
>	if (!angular.isDefined(origin)) origin = scope.selectedValues || [];
	scope.setValue(!scope.multiple ? origin[0] : origin);
};

If you also need to handle other properties like $pristine, $dirty, $touched, etc., this must be done by manually in the controller, in order to reflect every update of the input field to the select.

I think if the above two changes are made then the problem will be solved. I can make a change to template but I cannot make a change to the js file. So I will wait for the next release. Thank you. :)

Can you confirm that this plunker (http://plnkr.co/edit/tZdrO8163NSvMJ4VJk1J?p=preview) doesn't get you any error?

The above plunk is getting me the same error in case of dependent selectors. I have created the following plunk depicting my scenario:
http://plnkr.co/edit/qAlBn5Y5qiZAuH6OGapn?p=preview
Steps to reproduce the issue:

Deselect the value from the Main Selector by clicking on 'x'.

See that there is no value in the dependant selector.

Now select the value in the main selector.

Click on the 'Dependant Selector'. It is not getting populated.

On console, it is throwing me following error:

Ok thank you, now I am able to see the error, let me figure it out where the problem is and I'll come back you.

@kanikagupta13 latest release v1.3.13 solves your problems, check it out!

Thank you @indrimuska . It worked. :+1:


Adaptive Bitrate

I think it's obvious that TUM-Live should be as accessible as possible, so offering lower-bitrate streams for people with bad internet connections is something worth discussing. There are of course some potential drawbacks to this which may outweigh the benefits:

high processing requirements on the server for re-encoding the video stream
Added complexity
@joschahenningsen mentioned something about licensing costs
time might be better spent on other features

We are thrilled to announce that adaptive bitrate will come soon™
Additionally we'll most likely implement DVR. That means that you'll be able to sleep an hour more, scroll back to the beginning of the live lecture and watch it in double speed :tada:
Unfortunately it may take a month or two until we figured out who will pay additional server and licensing costs. But stay tuned!

Great 🎉

Available in all future streams :)


Add smart mode line support.

https://github.com/Malabarba/smart-mode-line
Before (with no sml theme applied):

After:

Based on sml default dark theme:

Merged! Thanks for your contribution!


client channels do not reconnect after server crash

What version of gRPC and what language are you using?
Version 1.8.3 C++
What operating system (Linux, Windows, …) and version?
Linux 26ee74637e50 4.4.0-109-generic #132~14.04.1-Ubuntu SMP Tue Jan 9 21:46:42 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
g++ (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
What did you do?
We have 2 GRPC streaming clients in the same process connecting to a server via unix domain socket. When we shutdown the server and restart, the clients try to reestablish the connection to the server but the client channel never get into CONNECTING state.
If there is only one client then the connection is reestablished successfully
What did you expect to see?
We expect both clients are able to reconnect to the the server.
What did you see instead?
client_channel remains in IDLE state and never get into CONNECTING or READY state
grpc_issue.txt
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
bool GrpcSubscriber::try_connect(const std::chrono::milliseconds &timeout)
{
bool success = false;
int cnt = (timeout.count() + 99) / 100;
auto state = channel_->GetState(false);
while ((cnt-- > 0) && (state != GRPC_CHANNEL_READY)) {
    xxx::sleep_for(std::chrono::milliseconds(100));
    logging::Logger *logger = logging::getLogger(name_.c_str());
    logger->info() << "Try to connect channel " << (void *) channel_.get();
    state = channel_->GetState(true);
    logger->info() << "channel " << (void *) channel_.get() << " State: "<< state;
}
if (state == GRPC_CHANNEL_READY) {
    success = true;
}
return success;

}
bool GrpcSubscriber::create_reader()
{
bool success = false;
channel_ = grpc::CreateChannel(
address_, grpc::InsecureChannelCredentials());
if (try_connect(std::chrono::milliseconds(1000))) {
context_ = std::make_uniquegrpc::ClientContext();
stub_ = SubscribeService::NewStub(channel_);
reader_ = stub_->Read(context_.get(), request_);
if (reader_) {
reader_ready_ = true;
success = true;
}
}
reader_ready_ = success;
return success;
}
Anything else we should know about your project / environment?

We moved to 1.9.0-pre1 release and the problem goes away

@jtattermusch @nathanielmanistaatgoogle This issue seems be resolved in GRPC 1.10.0. Can we have confirmation & closure of issue (if true)?

@vjpai  can you seems that this is resolved in gRPC 1.10, can you please link it to the PR that fixed it? (@dgq is OOO).

Reassigning to @dgquintas to see which PR resolved this problem

@vjpai nicely timed.
Fixed by https://github.com/grpc/grpc/pull/13932 and https://github.com/grpc/grpc/pull/14170


Add a locale switcher

Listens to the app state and updates the selector if the locale changes
If you change the locale via the switcher it will run a transaction on the application reconciler with i18n/change-locale

NOTE: I am not quite sure how to do the code formatting, maybe it would be a idea to have cljfmt configuration or something like that.
Resolves: #37

I'll play around with cljfmt if I can get it to do minimal changes to the code, Also I have not remove refer for the require macros, because then I had to add the complete namespace where I called the macro. If you want I can still change that.

Would you mind going ahead and just format this to your liking? Then I can make a separate PR with formatting

Thanks!


chore(wdio): use resolution by platform

Deploy preview for hopeful-hamilton-4090b9 ready!
Built with commit 1565de47f25d885a8cc02779a9a54da5ac071aa2
https://deploy-preview-691--hopeful-hamilton-4090b9.netlify.com

looks good to me


Remove the remaining closures in the src/core/colorspace.js file

For the MOZCENTRAL build-target this reduces the size of the built pdf.worker.js file by just over 1 kB, which isn't a lot but still cannot hurt.

/botio test

Thank you for the patch!


SDL2 build failure

Host Environment

OS: Ubuntu 20.04
Compiler: gcc 9
Package: sdl2:x64-linux
Vcpkg version: 2020.06.15-unknownhash

To Reproduce
Steps to reproduce the behavior:
./vcpkg install sdl2
Failure logs
CHECK_LIB_unwind-generic_RELEASE:CHECK_LIB_unwind-generic_RELEASE-NOTFOUND CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:229 (message):   Library "unwind-generic" was not found! If it is a system library use the   SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,   correct the *.pc file Call Stack (most recent call first):   scripts/cmake/vcpkg_fixup_pkgconfig.cmake:294 (vcpkg_fixup_pkgconfig_check_files)   ports/sdl2/portfile.cmake:97 (vcpkg_fixup_pkgconfig)   scripts/ports.cmake:79 (include)

I can't repro it. unwind does not exists on my sdl2.pc.
@Neumann-A Could you please take a look?
Thanks.

I get similar error
./vcpkg install sdl2
Computing installation plan...
The following packages will be built and installed:
    sdl2[core]:x64-linux -> 2.0.12#7
Detecting compiler hash for triplet x64-linux...
Could not locate cached archive: /home/X/.cache/vcpkg/archives/86/86bc4fa5231d5679ddc7519123a1fbf3b7c154c1.zip
Starting package 1/1: sdl2:x64-linux
Building package sdl2[core]:x64-linux...
-- Using cached /home/X/source/vcpkg/downloads/SDL2-2.0.12.tar.gz
-- Cleaning sources at /home/X/source/vcpkg/buildtrees/sdl2/src/SDL2-2-7528f85a66.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/X/source/vcpkg/downloads/SDL2-2.0.12.tar.gz
-- Applying patch export-symbols-only-in-shared-build.patch
-- Applying patch enable-winrt-cmake.patch
-- Applying patch disable-hidapi-for-uwp.patch
-- Applying patch fix-space-in-path.patch
-- Applying patch disable-wcslcpy-and-wcslcat-for-windows.patch
-- Applying patch fix-EventToken-header-reference.patch
-- Applying patch 0006-sdl2-Enable-creation-of-pkg-cfg-file-on-windows.patch
-- Applying patch 0007-sdl2-skip-ibus-on-linux.patch
-- Applying patch 0008-fix-macos-metal-test.patch
-- Using source at /home/X/source/vcpkg/buildtrees/sdl2/src/SDL2-2-7528f85a66.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Fixing pkgconfig file: /home/X/source/vcpkg/packages/sdl2_x64-linux/lib/pkgconfig/sdl2.pc
-- CHECK_LIB_unwind-generic_RELEASE:CHECK_LIB_unwind-generic_RELEASE-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:235 (message):
  Library "unwind-generic" was not found! If it is a system library use the
  SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
  correct the *.pc file
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:301 (vcpkg_fixup_pkgconfig_check_files)
  ports/sdl2/portfile.cmake:101 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:136 (include)

Error: Building package sdl2:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: sdl2:x64-linux
  Vcpkg version: 2020.11.12-unknownhash

Additionally, attach any relevant sections from the log files above.

We haven't been able to repro this; if more information comes up, or this issue appears again, please reopen.

OS: CentOS Linux release 7.9.2009 (Core)
Compiler: gcc (GCC) 8.3.1 20190311 (Red Hat 8.3.1-3)
Package: sdl2:x64-linux
Vcpkg version: 2020.11.12-unknownhash
I'm getting the following sdl2.pc file on my local machine and it's exhibiting the same behavior.
prefix=${pcfiledir}/../..
# sdl pkg-config source file

exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: sdl2
Description: Simple DirectMedia Layer is a cross-platform multimedia library designed to provide low level access to audio, keyboard, mouse, joystick, 3D hardware via OpenGL, and 2D video framebuffer.
Version: 2.0.12
Requires:
Conflicts:
Libs: -L${libdir} -Wl,-rpath,${libdir} -Wl,--enable-new-dtags -pthread -lSDL2
Libs.private: -lunwind-generic -lunwind -ldbus-1 -ldl -lm  -Wl,--no-undefined -pthread -lSDL2
Cflags: -I${includedir}/SDL2  -D_REENTRANT

I was able to fix this locally with the following patch:
index e1c027bf7..cfa2fc86c 100644
--- a/ports/sdl2/portfile.cmake
+++ b/ports/sdl2/portfile.cmake
@@ -101,4 +101,6 @@ endif()
 vcpkg_fixup_pkgconfig(
     IGNORE_FLAGS "-Wl,-rpath,${CURRENT_PACKAGES_DIR}/lib/pkgconfig/../../lib" "-Wl,-rpath,${CURRENT_PACKAGES_DIR}/debug/lib/pkgconfig/../../lib" "-Wl,--enable-new-dtags" "-Wl,--no-undefined" "-Wl,-undefined,error" "-Wl,-compatibility_version,${DYLIB_COMPATIBILITY_VERSION}" "-Wl,-current_version,${DYLIB_CURRENT_VERSION}" "-Wl,-weak_framework,Metal" "-Wl,-weak_framework,QuartzCore"
     SYSTEM_LIBRARIES dbus-1
+    SYSTEM_LIBRARIES unwind-generic
+    SYSTEM_LIBRARIES unwind
 )

update vcpkg. vcpkg_fixup_pkgconfig has been changed to no longer do that library check.


EnvelopesAPI getDocument method signature order change in v3

The order for $document_id and $envelope_id has changed for EnvelopesApi->getDocument between versions:
V2
public function getDocument($account_id, $envelope_id,  $document_id)
V3
public function getDocument($account_id, $document_id, $envelope_id, EnvelopesApi\GetDocumentOptions $options = null)
Any particular reason why these two have been interchanged? Please let me know if this wasn't intentional and I can create a pull request for the fix.
Thanks.

@astridblahblahblah Thanks for pointing it out. Parameters in the swagger spec that we use to generate the php-client itself have been moved around. I will follow up on this issue internally and make the necessary changes. I would recommend you update your calls if that is a blocker for now. Sorry for the inconvenience.


.CompleteChatAsync freezes without any exceptions. non-async version of the method works fine

Hi. When our application is deployed on aws, the .CompleteChatAsync method stops working. Locally everything works fine. The timeout is configured
    public class OpenAiService
    {
        private readonly string apiKey = ConfigurationManager.AppSettings["openai.apikey"];
        private readonly string model = ConfigurationManager.AppSettings["openai.model"];
        private readonly float temperature = Convert.ToSingle(ConfigurationManager.AppSettings["openai.temperature"]);
        private readonly int timeout = Convert.ToInt32(ConfigurationManager.AppSettings["openai.timeout"]);
        private ChatClient client;

        public OpenAiService()
        {
            var options = new OpenAIClientOptions()
            {
                NetworkTimeout = TimeSpan.FromSeconds(timeout),
            };
            client = new ChatClient(model, apiKey, options);

            ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls11;
            ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12;
        }

        public async Task<string> SendRequestToOpenAiAsync(OpenAI.Chat.ChatMessage[] messages)
        {
            try
            {
                var completion = await client.CompleteChatAsync(messages);

                return completion.Value.Content[0].Text;
            }
            catch (Exception ex)
            {
                Log.SaveLog($"OPENAI request error occurred:");
                Log.SaveLog(ex.Message + ex.StackTrace + ex.Source);

                return null;
            }
        }
    }

but still no exceptions at all. The application just freezes.
When switched to .CompleteChat, everything starts working when deployed.
2024/06/28 09:21:19   Running start turn for turn 145163
2024/06/28 09:21:21   1
2024/06/28 09:21:26   2
2024/06/28 09:21:26   Finished running start turn for turn 145163
2024/06/28 09:21:27   Successfully sent email ***
after changing CompleteChat to CompleteChatAsync
2024/06/28 09:23:47   Running start turn for turn 145163
2024/06/28 09:23:49   1

Is the client meant to be re-used across multiple async requests or a new client every request?

We used it once per request

I have seen similar performance issues, the first request calling await chatClient.CompleteChatAsync(...) is quick, if I call it again in a second request (Scoped essentially - as I new it up each call) it's slow and can take up to a minute to complete. I am going to play around with IoC and try different scopes, winder if singleton might be better.

I started seeing this recently too. It's not just slow... we've let it run for as long as 30 or 60 minutes. Setting NetworkTimeout on the client options seems to have no impact.


TypeError: overflowWidgetsDomNode.appendChild is not a function

I'm trying to use the configuration option overflowWidgetsDomNode in my monaco editor. But I get the error TypeError: overflowWidgetsDomNode.appendChild is not a function.
I'm using monaco-vscode-api via monaco-languageclient version 6.0.2, which depends on monaco-vscode-api version 1.78.8, but I believe I've found the cause of the issue in the newest code as well: https://github.com/CodinGame/monaco-vscode-api/blob/f82fbfd0200d448e63da9d844c0ad3699fb4d9d7/src/monaco.ts#L86-L88
I believe the overflowWidgetsDomNode should be passed around the computeConfiguration() call like ariaContainerElement is, as the computeConfiguration() call seems incompatible with dom nodes.
When breakpointing into the above linked code, at line 88, options.overflowWidgetsDomNode is the correct dom node, but computedOptions.overflowWidgetsDomNode is an otherwise empty object, containing only an angular-specific value __ngContext__: 8 (I'm using Angular), and this is the object it later tries to call appendChild() on.

If I understand properly, the fix is quite simple, do you mind open a PR?


pihole_dhcp_lease_lookup missing attribute for dvc

The lookup file pihole_dhcp_lease_lookup contains DHCP information from all pi-hole servers that are acting as DHCP servers if you are running in multiple locations. However, there is no way to separate from which device each lease is related.
I would like to suggest that the saved search "Pihole - DHCP Leases Lookup - Gen" is updated with that attribute. I see no risk in adding this attribute to the lookup, it won't collide with any searches or dashboards.
My suggestion is to add the following to the search:
| tstats latest(All_Sessions.dest_nt_host) as "dest_nt_host", latest(All_Sessions.dest_mac) as "dest_mac" latest(dvc) as dvc from datamodel=Network_Sessions where sourcetype=pihole:dhcp by All_Sessions.dest_ip
| `drop_dm_object_name(All_Sessions)`
| eval _time=now()
| fields - count
| outputlookup create_empty=false createinapp=true override_if_empty=false pihole_dhcp_lease_lookup

pihole_dhcp_lease_lookup is a definition that points to a KV store, we need to update that definition as well. Missed that


Ignore Pokemon Yaml file not working

Having issues here, I updated the YAML file with just the example Pokemon and I am still catching them. Is there anything else that needs to be done to ensure they are going to be ignored?

Not supported at the moment.

We might want to move this to a different branch if it's not supported ATM.

Waiting for #286 and #270 to be merged before this can be fixed.

Should be fixed with #286


React native routing and deep linking with navigator

Description
React native routing and deep linking with navigator.
At this moment, the web React native redirect every time to the first screen in the navigator.
We want to have the possibilities to directly go this page like a Nostr profile or whatever.
Todo

[ ] Fix deep linking in Router.tsx
[ ] Fix navigator routing
[ ] Clean navigators
[ ] Fix screens

Hi

H

@MSghais kindly assign me ETA 2days

hello @MSghais i would love to work on this issue

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hello I'm a frontend and also a blockchain developer and I would love to jump on this issue

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
i am a frontend developer with experience using typescript for typesafety and js. kindly assign me
How I plan on tackling this issue

i currently understand how the navigator works

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I’m a front-end developer with 3 years of experience transitioning to Web3, and I would love to make my first contribution to this project. I'm excited to take on this issue to challenge myself, learn, and contribute to the project's success.  I'm also a member of the Dojo Coding community, looking forward to applying my skills in this new space while I grow and contribute to the community.
How I plan on tackling this issue
First, I would investigate how routing is currently set up in the project. I need to understand how the navigator initializes and why it's always redirecting to the first screen. This likely has something to do with the initial route configuration or how deep linking is being handled.
I'll configure deep linking so the app can navigate directly to specific pages like a Nostr profile or any other destination. This involves making sure the app can parse URLs properly and direct users to the correct screen based on the link. I'll look into the Router.tsx file to ensure it handles incoming URLs and routes them to the right screen.
Since the problem lies in the navigator always defaulting to the first screen, I’ll modify the logic so it checks for deep links or saved navigation states when the app initializes. This will allow the app to open directly to the screen specified by the deep link, rather than always starting at the first screen.
I'll review the current navigators and clean up any unnecessary or redundant configurations. The goal is to ensure a clear and efficient navigation flow, which will also help with maintaining the deep linking functionality. This step might involve consolidating routes and simplifying the overall structure.
I'll make sure each screen can handle incoming parameters from deep links. For example, if I’m navigating to a Nostr profile, the screen should be able to extract the profile ID or any other necessary data from the URL and render the correct content.
Once the changes are made, I’ll thoroughly test the deep linking functionality by simulating different deep link scenarios, like entering URLs directly in the browser or using universal links on mobile. I want to ensure that the app reliably navigates to the correct screens in all cases.
If I run into any problems or questions, I’ll reach out to the maintainers for assistance.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Please can I be assigned this issue? This would be my first time contributing to this ecosystem and I’d love to be given the opportunity. I am a blockchain Developer, and my experience includes html, css, react, JavaScript,TypeScript and solidity and Cairo.
How I plan on tackling this issue
To solve issue, I’d take the following steps:
1. First of all, I’ll fix Deep Linking in Router.tsx (by mapping routes to URLs in the linking object and ensuring correct path handling for specific screens like Nostr profiles).
2. I’ll ensure the navigator hierarchy is properly set up to handle deep links, passing parameters to the correct screen.
3. I’ll simplify and clean up unnecessary or redundant code in the navigators for better maintainability.
4. I’ll ensure screens correctly receive and handle route parameters (e.g., nostrId) passed via deep links.
5. I’ll verify deep linking works on all platforms and different scenarios (web, Android, iOS) for proper routing behavior.
Please kindly assign.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a frontend developer with vast experience using typescript for typesafety and javascript . kindly assign me i am available to work please
How I plan on tackling this issue
I would approach the problem by doing the following:

Deep Linking in Router.tsx: Ensure the deep linking setup correctly parses URLs and routes to the desired screen.
Navigator Routing: Check if the initial route is properly configured and if conditional logic forces navigation to the first screen.
Clean Navigators: Simplify navigator structure by removing redundant configurations.
Fix Screens: Ensure each screen's routing path is well-defined and accessible through deep links.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a passionate and results-driven web developer, currently deepening my knowledge in web3 technologies, Cairo, and open-source development through Dojo Coding. My skill set includes expertise in JavaScript, React, HTML, CSS, C# with .NET Entity Framework, and more. I also have experience with tools like Git, GitHub, SQL Server, and Postman. My focus has been on building solid web applications, from task lists to full-fledged CRUD systems, with front-end, back-end, and database integration.
I have already made a contribution to the open-source ecosystem, and I am eager to engage in more projects, particularly those involving Cairo.
How I plan on tackling this issue
To resolve routing and deep linking issues in React Native, first, configure deep linking correctly in Router.tsx, mapping URL routes to the app screens. Ensure the navigator is set up to handle these routes without redirecting to the main screen.
Clean up the navigation logic to avoid unnecessary redirections and verify that each screen component is properly implemented and registered. Conduct tests with different deep links to ensure each one directs to the correct screen.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
As a full-stack JavaScript developer with solid experience in using React and Expo, I'm well-prepared to handle the current navigation problems. My background in these technologies means I understand how to create smooth user experiences, and I can efficiently address the routing issue we’re facing.
How I plan on tackling this issue
First, I’ll focus on fixing the deep linking in Router.tsx. This will allow users to directly access specific pages, like a Nostr profile, instead of always going back to the first screen in the navigator. I will review how deep linking is currently set up to ensure the app routes correctly based on the links being used.
Next, I’ll improve the navigator routing to ensure that transitions between screens work properly. I’ll clean up any unnecessary navigators to make the navigation system simple and easy to follow.
Once I’ve fixed the routing, I’ll check all the screens to ensure they work well with the new setup. This includes making sure that each screen loads correctly when accessed via deep links and behaves as expected when navigating within the app.
After making these changes, I’ll thoroughly test the routing and deep linking to ensure everything works smoothly. This will involve checking how the app handles different deep links and how it navigates between pages. Finally, I’ll tidy up the code to make sure the navigator and router components are efficient and easy to maintain.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
hello i am a frontend dev and blockchain developer
please can i work on this issue :) and would love to be a contributor
How I plan on tackling this issue
Review Existing Code: Understand the current setup in Router.tsx to identify issues.
Fix Deep Linking: Update the deep linking configuration to ensure correct screen navigation from URLs.
Enhance Navigator Routing: Refactor the navigator configuration to handle routes and components properly.
Clean Up Navigators: Simplify the navigator structure for better readability and maintainability.
Verify Screens: Ensure all screens are correctly defined and accessible via the navigator.
Test Changes: Conduct thorough testing to confirm deep linking and navigation work as intended.
Update Documentation: Revise documentation to reflect any changes made for future reference.

Someone have an ETA please?

I would love to work on this issue @MSghais

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Lindsay - Software Engineer with almost 5 years of exp. Already contributed to this project several times.
How I plan on tackling this issue
Most of my exp is with react and react native, and I have also had the chance to work with Deep Linking (and solve some strange issues as this is).
I'll start by using the urls examples shared and debugging the app, to see where exactly is the issue happening.


HTTPRequestHeaderFilter should specify the order of operations

What happened:
HTTPRequestHeaderFilter has add/set/remove operations that manipulate the set of request headers. Depending on the order that a proxy applies these operations, the final result can be different.
What you expected to happen:
Header manipulations should be consistent across proxies.

/remove-lifecycle stale
/lifecycle frozen

It seems reasonable that there would be situations where you would have multiple verbs acting on the same header. For instance, a user might use Set followed by Add to erase any values previously associated with a header, and then add another value on top of that. We are marking this help wanted as we're looking for contributors with strong use cases to help champion and drive this forward.

@shaneutt I can help do this if possible :)

/assign

I think another case is clarifying the behavior for Set, Let's say we have two X-Foo headers:
X-Foo: v1
X-Foo: v2

What will happen after we apply the rule:
set:
  X-Foo: v3

Will we have two X-Foo headers and their values are v3 or we just have one X-Foo header (Because we can treat the original X-Foo header's value as v1, v2.

I think it's reasonable to approach this by simply rejecting any configuration that includes multiple Sets or Adds (or both a Set and Add) for the same header, which should be simpler to implement since you can handle it entirely in Gateway API resource processing and don't need to worry about whether an implementation can easily conform to a given order. Is there a good reason we'd need to allow more than one Set or Add for the same header?
Per https://www.rfc-editor.org/rfc/rfc7230#section-3.2.2 multiple instances of the same header essentially always end up as a single CSV It is a bit ambiguous since it says senders must not generate multiple instances of the same header, but if they do recipients may combine them, without indicating what should happen if recipients opt to not combine them--maybe discard the additional instances after the first? In any case, it does seem clear that a CSV is the correct version of multiple values.
I don't know of an obvious reason why we shouldn't be able to require that users adding HTTPRequestHeaderFilters add multiple values as a single header instance with a CSV in advance: the values are going to end up in that form anyway, HTTPRequestHeaderFilters aren't standalone resources and can't be natively reused across HTTPRouteRules, and requiring that removes user-facing ambiguity about the final order (you don't need to know the spec to know what the order of the values will be because you've specified the order in its final form already), and I can't think of any configuration that you could express with multiple Sets/Adds that you couldn't with a single CSV Set/Add.
We would still need to worry Adds applied to a request that already contains that header, since we would still need to choose an order there.
In either case, whether we only handle Adds atop existing request headers or allow users to specify multiple Sets and Adds for the same header, given the

[recipients may handle multiple of the same header] by appending each subsequent field value to the combined field value in order

in the RFC language, I do think we'd want the order to be existing,first add,second add. Multiple Sets or mixed Sets and Adds are more complicated since, per the above, it's unclear whether they'd be absolute (you only get the value of one of the Sets) or additive (you get a CSV of values from all Sets and Adds), which I think is more argument in favor of just rejecting them.
FWIW, in our existing header mutation implementation we can easily control the order of headers within an operation, but don't have the ability to control operation order: our Sets always come before our Adds. We would not be able to easily implement a spec that required that Sets override Adds (if you have Set X-Foo: a and Add X-Foo: b you get X-Foo: a instead of X-Foo: a, b) or that Add values come first (if you have Set X-Foo: a and Add X-Foo: b you get X-Foo: b, a instead of X-Foo: a, b).

Is there a good reason we'd need to allow more than one Set or Add for the same header?

I think we should not make the decision for the users.

It's not something that affects the end result AFAIK. If you have:
add:
- name: X-Foo
  value: Red
- name: X-Foo
  value: Blue

and
add:
- name: X-Foo
  value: Red,Blue

and both result in the request containing X-Foo: Red,Blue, choosing to allow only one or the others doesn't limit actual capabilities. We can and should be prescriptive about configuration format. I'm asking if there's any way this would limit capabilities and not just accepted configuration.
The main example I can think of where it would is if we want to allow either duplicated headers or CSV values, in which the multiple Add version would actually result in two separate X-Foo: Red and X-Foo: Blue headers and violate the RFC. It's not inconceivable that there is some application out there that both needs to receive multiple values for the same header and requires using multiple instances of that header/cannot parse the CSV format. However, I'm not particularly inclined to say that we should offer support for intentionally violating the HTTP RFCs unless there's a commonly accepted de facto standard where doing so is commonplace. Set-Cookie is one such known exception, but IDK if that's something we'd need to support (if implementations accept both the compliant CSV Set-Cookie value and also permit multiple Set-Cookie instances, sending the former is fine)--I'd like to think that clients do generally support the RFC-compliant variant.

@tokers we discussed this during yesterday's sync and consensus was generally okay with restricting to a single operation per header name (remove hasn't been discussed here previously, but it doesn't make much sense to exclude it--any combination of other operations and remove could be accomplished by just using remove or just using set alone) and not trying to handle non-compliant header sets. Did you know of any issues where the "single operation that provides a CSV value for multiple values if desired" does still limit what users can configure or causes other issues?

@tokers we discussed this during yesterday's sync and consensus was generally okay with restricting to a single operation per header name (remove hasn't been discussed here previously, but it doesn't make much sense to exclude it--any combination of other operations and remove could be accomplished by just using remove or just using set alone) and not trying to handle non-compliant header sets. Did you know of any issues where the "single operation that provides a CSV value for multiple values if desired" does still limit what users can configure or causes other issues?

Indeed I have never encounter such a scenario.


[Bug]: JSON form submit button is not disabled when default data doesn't meet the validation criteria

Is there an existing issue for this?

[X] I have searched the existing issues

Description
If a json form has default data as empty and a field is marked as required, the submit button is still enabled when "disable invalid forms" is true. Only after the user interacts with the field, the submit button is disabled.
Steps To Reproduce

Add a new JSON form
Bind this data
{
"name": "",
"date_of_birth": "20/02/1990",
"employee_id": 1001
}
Make sure name is set to required
Deploy the app
Observe the submit button is enabled

Public Sample App
No response
Version
1.6.20

Reach - Happens to all devs who have successfully bound data to JSON form
Stats

Stat
Values

Reach
77

Effort (months)
0.5


tests, integ: split tier1 integration tests

This patch is introducing integ_tier1 tests and using it in travis CI.
This will allow us to run integration test quickly as both jobs, integ
and integ_tier1  are going to run at the same time.
Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

Coverage remained the same at ?% when pulling c0804cbb36df3f852097c04c0603e1535243fee5 on ffmancera:split_tests into e4a7a0fd94a35e6b864d0936751acdd3e1bc9d6e on nmstate:master.

Coverage remained the same at ?% when pulling c0804cbb36df3f852097c04c0603e1535243fee5 on ffmancera:split_tests into e4a7a0fd94a35e6b864d0936751acdd3e1bc9d6e on nmstate:master.

You are removing tier1 test cases from runtest.sh --test-type integ which is incorrect.
The runtest.sh --test-type integ should run all(except slow) integration test cases.
I was expecting runtest.sh --test-type integ == tier1 + tier2.
The travis just use integ_tier1 and integ_tier2.

Done. I have introduced integ_tier1 and integ_tier2. Travis CI is using integ_tier1 and integ_tier2. You can run tier1+tier2 tests using integ. Thanks!

Done, thanks!


fix(distortion_correction_node): remove redundant code

Description
There is a for-loop and a while loop doing the same thing. Basically, when implementing the while loop, the contributor forgot to delete it.
https://github.com/autowarefoundation/autoware.universe/pull/2913/files

Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf Since the code appears to be designed to improve performance, it is better to check the execution time impact.

@yukkysaito My understanding is that this modification does not change any performance, simply increasing the readability of the code by removing "purely" redundant code, given that the following while loop does exactly the same thing as the for loop.
@vividf Would you confirm if the above argument is correct?

@kminoda
Yes, you are correct :)
@yukkysaito
In the PR, [#2913], you can also see that the author removed the for loop and added the while loop for optimization for twist. But for imu, only the while loop was added.
I also analyze the time difference (green: remove for-loop, red: original)

Below is the value of the above graph (100 samples)
Remove for-loop:
min: 5.1, max: 11.98, avg: 6.56
Original
min: 5.29, max: 11.95, avg: 6.88
The value average processing time is lower because the current implementation still uses the for-loop. By removing the for-loop and using the while loop that the author implemented it will decrease the time.
reference:
#(https://github.com/autowarefoundation/autoware.universe/pull/2913/files#:~:text=it_y%2C %2B%2Bit_z%2C %2B%2Bit_time_stamp)%20%7B-,for%20(%3B,%2B%2Btwist_it)%20%7B,-while%20(twist_it)

@vividf could you resolve conflict?

Due to the approval being late, other PR also solved this.


Build a Shopping Fresh Fiori App in SAPUI5

Tutorial URL: https://developers.sap.com/tutorials/cp-apim-shoppingfresh-create-fioriapp.html
Please specify the step you are referring to Step 4: Deploy app.
For some reason I'm unable to Deploy my app, the option for Deploy to SAP Cloud Platform is missing and I created my project as a SAP Fiori Master/Detail as stated in the tutorial:

I did exactly what the tutorial said.
I clear all my quotas deleting my applications and my service instances.
Can you help plz ?
Thanks
Ivan

Hello Ivan,
Right-click on your project and check. I am getting the options.

Regards
Shilpa

Well, there is something wrong and no one is able to help me, I will leave this tutorial behind !!
Thanks


Support for submenus?

Is it possible to create submenus?
I would like to create a menu with an item "Research" and then submenus with "All publications" and "Work in progress". Ideally, clicking on (or hovering over) "Research" reveals the 2 submenus. Similarly, for "Teaching" I would like to create submenus.
The Hugo documentation mentions the use of the "parent" field to create nested menus, but this does not appear to work.
I'm still very new to Hugo, so I apologise if this is a silly question. Any help is very much appreciated.

Academic doesn't support sub-menus. The general philosophy with the theme is to keep the interface simple, so this feature probably won't be added anytime soon.
You can customize the navigation bar for your purpose by copying themes/academic/layouts/partials/navbar.html to layouts/partials/navbar.html (relative to the root of your site). Your version of the navigation file will then override Academic's file.

Thanks for the reply. I was able to get it working! The modification turned out to be quite simple. I now have submenus (but not submenus in submenus). They are specified using the parent field.

Thanks for sharing your modification @kepiej . I just tested it out - the required code changes for the feature are more minimal than I expected and it doesn't break compatibility with the existing example site menu or the active link highlighter (Bootstrap scroll spy). Thus, I've had a change of mind and will integrate it shortly 😃

Thanks for the reply. I was able to get it working! The modification turned out to be quite simple. I now have submenus (but not submenus in submenus). They are specified using the parent field.
I attach my modification for anyone interested in the future: navbar.html

Please tell me after you've done navbar.html how did you make submenu in config.toml?

Thanks for the reply. I was able to get it working! The modification turned out to be quite simple. I now have submenus (but not submenus in submenus). They are specified using the parent field.

I attach my modification for anyone interested in the future: navbar.html

@kepiej Please tell me after you've done navbar.html how did you make submenu in menus.toml?

Have a look at my repo: https://github.com/rodrigoalcarazdelaosa/rodrigoalcarazdelaosa.me where I use submenus

Thanks for the reply. I was able to get it working! The modification turned out to be quite simple. I now have submenus (but not submenus in submenus). They are specified using the parent field.

I attach my modification for anyone interested in the future: navbar.html

@kepiej Please tell me after you've done navbar.html how did you make submenu in menus.toml?

Have a look at my repo: https://github.com/rodrigoalcarazdelaosa/rodrigoalcarazdelaosa.me where I use submenus

@rodrigoalcarazdelaosa  I saw it, thank you very much. But I didn't find navbar.html file in your layouts/partials/?

@rodrigoalcarazdelaosa I understand, thank you again 👍

Even after reading this issue I didn't realize this was a working feature without custom partials. I was really happy to discover it is baked in!
I think it might be good to add a "how to edit the menu" docs page to the wowchemy docs or possibly modify the example academic template to include a simple submenu so the functionality is demonstrated.


Bug: Migrate bin/index.mjs rewritten as index.js , causing CLI to fail

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
Bug: Migrate bin/index.mjs rewritten as index.js , causing CLI to fail
Reproducible demo
No response
Steps to reproduce
install migrate
Expected behavior
to run migrate
Actual behavior
fails to load as esm module needs to be .mjs not .js
Your environment
osx 10.15
Self-service

[ ] I'd be willing to fix this bug myself.

Thanks for the report! This has already been fixed. Could you try with @docusaurus/migrate@canary?

Oh I see, that's why I see it working for me :D

Going to close as resolved. The migration CLI isn't used a lot these days anyways


STLT Dashboard Testing with CO & WA

Background & Context
Washington and Colorado have both expressed interest in learning more about the upcoming Data Dashboard. ReportStream designers will share the Figma prototype with the STLTs in a 30 minute session to learn more about the usability of the current design, identify gaps & needs. Takeaways will inform future iterations of the Data Dashboard.
Working Links

Conversation Guide & Raw Notes
Washington Synthesis Notes
Colorado Synthesis Notes
Research Synthesis Mural
Updated Figma designs per Research Synthesis

Acceptance Criteria

[x] Conversation guide completed
[x] Synthesized CO notes shared via Slack
[x] Synthesized WA notes shared via Slack
[x] Identify design changes to MVP, if any
[x] Identify design changes to long-term version of the Dashboard, if any

Closing per updated Figma and communication out on the changes.


When querying SQLite using DuckDB, a mapping of column types must be chosen - example?

From the docs about sqlite scanner we can read `When querying SQLite using DuckDB, a mapping of column types must be chosen". However there is no example showing that mapping, and the three examples of querying SQLite does not map column types. It would be super nice with a short code snippet showing how it is preferred we map column types.

Hey there, by "chosen" here we mean that DuckDB itself chooses types to map SQLite types to. The section following the part you link to specifies how we map the few SQLite types to DuckDB types. You can customize it using the sqlite_all_varchar setting, and afterwards cast to custom types, if you prefer

Good question! Let me rephrase that a little bit. Does this clarify things @bjornasm? #737

Thank you so much @Alex-Monahan  - yes! Sorry for being so late with this reply. All in all, thank you for being so active here, also thank you @Mause  .


create reports based on server stats

Should be able to get a table report of:

Accounts

[x] How many connections
[x] Cumulative bytes in/out
[x] Cumulative messages in/out

Connections

[x] Bytes in/out
[x] Messages in/out
[x] Connection duration

Leafnodes

[ ] Bytes in/out
[ ] Messages in/out
[ ] Connection duration

General

[x] reverse sort

Sortable by in ways that make sense
What else @derekcollison ?

This looks good to start..

added nats server report connections and nats server report accounts

These are very helpful!
On Mon, Aug 10, 2020 at 4:10 AM R.I.Pienaar<EMAIL_ADDRESS>wrote:

added nats server report connections and nats server report accounts
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nats-io/jetstream/issues/282#issuecomment-671293615,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAV74PX6C5HJUA6OXVDORDR77IQ7ANCNFSM4PXOKGHA
.

Will close this one, we dont have leaf reports but I think thats fine for now


Roadmap for release-it

Hey.
I was wondering what's the best way to contribute to this project.
Is there any planned roadmap?
Support for maintaining more platforms?
Known issues(to the author) that need to be tackled?
If help is needed I'd be happy to help!

Hi @IamTheHttp, to be honest, there's not really any kind of roadmap. This tool basically does what I want from it, and I'm happy to consider feature requests and bug reports from others.
Issues #266 and #273 are good examples of features that I'm happy to consider, but not personally interested in (at least not atm).
Overall, further improvements of the codebase, tests, and documentation to make it more usable, robust, and easier to develop further are welcome!
From the metrics I can share a few numbers from the last week. Of all sessions...

84% happens with the latest two versions (7.3.0 and 7.2.1)
72% is run on OSX/macOS, 8% is run on Windows 10, rest is Linux
58% is in "interactive mode"
20% is run on a CI environment

Are there any improvements or known issues you have in mind?


Migrate project to Webpack 4

Migrate project from Webpack 1 to 4. Due to small code base and rather simple configuration there is not a lot of code that has changed. All tests passed successful on my machine.
I've left few comments in the diff preview to explain few changes in detail.
Also project URLs in package.json has been updated and yarn.lock has been added to .gitignore file.

Awesome stuff, thanks! Delegating to @mslipper for review and further steps ❤

This is awesome! Thanks @Simek. Will review today.

Going to run some local tests as well to make sure nothing breaks.

Thank you @timche  and @mslipper for the quick response. Let me know if I can help or clarify something for you.
Small side note. In future it will be nice to use babel-plugin-lodash functionality over manually
managing lodash imports. But that's optimization for another time.

Going to run some local tests as well to make sure nothing breaks.

Shouldn't we run CI? I think it hasn't been set up since we moved the repo to this organization 😱
Let me see if I can get it back up.

Travis should be back up. Can you try a force push and check if that works?

Is Node 4 officially supported? I've didn't notice that information earlier. Unfortunately Webpack 4 requires Node 6+. I'm asking because on Travis library is builded on Node 4 and 6.

Should be changed to LTS and latest. Can you include Travis changes in your PR please?

@timche thanks for fixing that :). This looks good to me.


Add travis build file and badge

Automate builds so that no bad code gets shipped (there are currently 4 failing specs).
Ideally this would be set up with automated deploys on tagged commits:
http://docs.travis-ci.com/user/deployment/rubygems/

ping @tkadauke

Great idea! Thanks!

Thanks for your help recently, @jbender.  I'm adding you as a collaborator, I hope you continue to help move this project forward! :smile: :+1:

@colinta glad to help out, hopefully we can make iOS dev as fast/easy as writing a Rails app


Directly spawn chrome driver process and fix retry logic

When I run a standalone spectron script using node, everything works as expected.  However, when I try to get spectron working inside my atom package, process.execPath is the atom helper binary, and this doesn't work.  Spawning the chromedriver process directly fixes this.
The setTimeout retry logic in startChromeDriver wasn't working for me either, so I replaced it with a setInterval and a max retry limit.

Sorry for the delay in updates on this issue, but I got back to this today.
I merged and released two pull requests that I believe address the issue, #8 and #9.
You can now set the timeout for waiting on ChromeDriver to launch with the startTimeout option that defaults to 5 seconds and so it no longer infinitely polls.
You can also set the path to node via the nodePath option that will default to process.execPath.
So you should be able to do something like the following in your specs to get the running from Atom/Electron.
var myApp = new Application({
  path: '/Applications/MyApp.app/Contents/MacOS/MyApp'
  nodePath: 'node'
})

I'm going to close this pull request out, the options are published in 0.35.5. Please let me know if this does not work for you.


[FIX] signup url should point to kaggle

minor fix changing url from crestle to kaggle

Fixed in another PR - thanks


[Fabric] Fixed surface presenter observer

Summary
We missed create observer array, let's add it.
cc. @shergin .
Changelog
[iOS] [Fixed] - Fixed surface presenter observer
Test Plan
N/A.

Wait a sec, how does work before?.. 🤔


Added single rule endpoint

Description
This change add single rule endpoint.
Fixes https://github.com/RedHatInsights/insights-results-smart-proxy/issues/49
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Testing steps
Send request to endpoint.

@tisnik 404 handler is done here: https://github.com/RedHatInsights/insights-results-smart-proxy/pull/57/files#diff-91bbeda7eb98a7adc57b9e47e2cf5c2bR418

Please, rebase, it may calm down the CI

Sorry, I thought this one already merged https://github.com/RedHatInsights/insights-results-smart-proxy/pull/64 so please just wait lil bit and then rebase

Codecov Report

Merging #57 into master will increase coverage by 2.69%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   39.41%   42.10%   +2.69%
==========================================
  Files          12       12
  Lines         746      798      +52
==========================================
+ Hits          294      336      +42
  Misses        422      422
- Partials       30       40      +10

Impacted Files
Coverage Δ

server/server.go
50.20% <63.63%> (+3.85%)
:arrow_up:

server/endpoints.go
100.00% <100.00%> (ø)

server/router_utils.go
6.55% <0.00%> (+6.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b373d82...9ff984f. Read the comment docs.


Attempt to call external function which is not connected to the body does not cause error.

Dart VM version: 2.9.0-13.0.dev (dev) (Fri May 29 15:59:05 2020 +0200) on "windows_x64"
Dart Language Specification reads:

An external function is connected to its body by an implementation specific mechanism. Attempting to invoke an external function that has not been connected to its body will throw a NoSuchMethodError or some subclass thereof.

Seems like the following source code example should throw error according to the rule above, however it does not happen:
external int unexistent();

main() {
  print(unexistent());
}

Dart just goes through and prints null here.

It should really fail at compile-time.
I guess the compiler phases don't agree on which one needs to report the error. After all, a later phase might add the implementation (like the VM does for dart:ffi).
Still, if the back-end specific compiler sees an external that it doesn't know what to do about, it should fail.

It should really fail at compile-time. Throwing at run-time is a Dart 1 left-over.

@lrhn If it should fail at compile-time, shouldn't this issue be marked as CFE?
/cc @johnniwinther

Only the backends know for which external functions an implementation exist. Therefore the CFE cannot report an error unless we can query the backend as to whether a particular external function is allowed.
Patched functions are declared as external and the implementation is provided in terms of Dart code in the patch files. These are delivered as non-external functions to the backends and the CFE can only check that only external functions are patched (a check I'm not sure that we currently do) and the reverse (that all external functions are patched, which they are not).
Native methods for the VM, dart2js and ddc, and foreign and js-interop functions for dart2js and ddc are all external and delivered as such to the backends. The CFE currently knows nothing about how to recognize and verify these supported cases of external functions.

The connection between an external declaration and an implementation is specific to each tool, so it is hardly possible to emit a compile-time error which is valid for all backends. Also, it would be a link-time property in any case. I think it makes sense to expect that a NoSuchMethodError is throw n at run time, as specified.

I definitely want to emit compile-time errors where possible.
For example, we promise that all external members of the platform libraries are patched up, and we won't (mustn't) build the SDK if they are not.
If a back-end sees an external declaration and has no clue to where the implementation is, it should fail as early as possible. If it sees @JS or @ffi or something that suggests that it should provide the implementation, then it's fine to go on (and potentially do a nSMError later if it fails to link up with something anyway).
So, I want the specification to at least allow compile-time errors for unknown external declarations.

The VM uses the native syntax for natives (both in our patch files as well as for native extensions):
int foo() native "Foo_native";

So I believe from the VM point of view, an unpatched external can be a compile-time error.

On the other hand, it sure would be nice if our common front-end didn't have to support a VM-only syntax extension. Have you considered no using native :smile:?

On the other hand, it sure would be nice if our common front-end didn't have to support a VM-
only syntax extension. Have you considered no using native 😄?

Well, we have to attach the native name somehow. In kernel it's basically represented as:
@ExternalName("Foo_native")
external int foo();

We could allow Dart to do the same. Then the rule would be: If an patched external member does not have an ExternalName annotation it should be a compile-time error.


Filtering on table shows the results from last page by default.

I just noticed that on entering a filter input in any page other than first page, table is showing the results from last page. How can I reset the results to show from page 1?
Any suggestions??
Thank you,

@tannerlinsley Can you please suggest something about this, I'm trying to do something with onFilteredChange, but it's not calling on filter input.

You could use the onFilteredChange prop to listen for a filter change and set the page prop to 0. Though I feel like this should happen already without you doing anything. Could you fork the codepen from the readme and replicate this bug?

http://codepen.io/tannerlinsley/pen/VbBzWa?editors=0010 In this example, any time I filter, I am automatically given page 1 of the results.  It must be something in your implementation. Could you post your component code for more details?

@yolohello12 is correct that it doesn't reset to the first page on filter change. What happens is that if the current page >  number of pages then it sets page = last available page.
In that codepen go to page 3 and then search for an age = 2 and you can see the behavior. Maybe we do want to reset to page 0 on filter change. Not sure.

Interesting.  I would think that filtering would temporarily go to page 1 of the filtered content (or it would go to the equivalent page in the filtered results.  Would it even make sense to return to the original unfiltered page when and if the filters are cleared?

I think that might be getting too fancy. Maybe we just reset the page to 0 on filter change and if they really need advanced logic they can implement it themselves.

http://codepen.io/anon/pen/PmBKVQ?editors=0110
I'm using a filtermethod for contained search, but even without that it's doing the same. Just like @aaronschwartz said, when I'm in any other page than page 1 and do a filter it either stays in that current page or shows the result from last page of filter results.

@aaronschwartz agreed. Just go to page 1 by default and let the controlledProps and callbacks provide the path to more custom stuff.

I'm facing the same issue, any fix available for this?

Not yet. This still needs to be fixed. Its just a matter of forcing a change to the first page when filtering and sorting


feat: Multi IP Address Support

Support for assigning multiple IP addresses per account id.

[ ] refactor Network to use Map <string, ManagedNetwork> instead of <string, Node>
[ ] refactor ManagedNetwork
[ ] refactor nested functionalities/calls
[ ] add new setters/getters?
[ ] add bunch o tests
[ ] pop champagne

Fixes: #725
Signed-off-by: valtyr-naut<EMAIL_ADDRESS>

Superseded by #755


[INF-4058] docker scout integration

WHY:
This PR is raised in order to implement CircleCI and docker-scout integration for this repository.
WHAT:
CircleCI configuration.
Jiira: https://heyjobs.atlassian.net/browse/INF-4221

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Make cleanup-leases security context configurable

Description of the change
The SecurityContext field for this job is currently static, however when deploying policy-controller into a namespace that uses Pod Security Admission controllers this job will not be able to run.
This adds a new field to the values file that operates in a manner similar to the securityContext option for the webhook deployment.

Existing or Associated Issue(s)

Additional Information

Checklist

[x] Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
[x] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[x] JSON Schema generated.
[x] List tests pass for Chart using the Chart Testing tool and the ct lint command.

@sirisaacnuketon Please, could you fi


UWP: Body element is required which means can't make card with only actions

You can't even just use a blank array on body, you currently have to provide elements inside the body, otherwise the renderer fails to render.
HTML renderer allows no body/empty body.
Some scenarios there's no body, just actions.

I will split this issue into two:
As of current documentation, Body is a mandatory property for an adaptive card. I will file an issue for the documentation and schema to determine if a change there is needed. It is a bug however that the UWP renderer does not allow rendering of an empty body.

Opened #548

Fixed with #553


Update name of repo in New Machine Script

Also remove reboot or make it a user input

Closed in pull request #119 https://github.com/iancleary/ansible-desktop/pull/119/commits/e886ced64482aa574ba864098b35a40294a89339


How to compile this editor?

I love this editor very much,
I used win7 + vs2015 compile this project ,but can not find engine editor? can you help me how to compile this engine editor? is this project need NET 4.7 ?

Did you manage to solve your issue?

successfully compiler,but run exe is  crash


Chrome Failed to find the first pattern!

[*] Targeting Chrome
[+] Found browser process: 8424
Process owner: xxxx\xxxx
[-] Failed to find the first pattern!
Chrome Updated today.

Latest release should work with the latest Chrome version.

thats great. can you share the way to fix the pattern update. how the method for future chrome updates? what tools should used and what to find?


Improve generating demo data

Added visitor statistics for orders
Orders are generated between today and -2 years
Customer email is now random and salutation, firstname, lastname is now filled

thanks @shyim :+1: :blue_heart:


Fix XCiT hub.load issue

Do the hub.load from "main" branch of XCiT repo as it got renamed (from "master") recently

Thanks @TimDarcet! Can you also modify the other files that rely on xcit please :) ? That should include eval_linear.py, eval_image_retrieval.py, eval_knn.py, hubconf.py, etc


smartthings component doesn't show smart lock status

Home Assistant release with the issue:

0.87.0
Last working Home Assistant release (if known):
N/A
Operating environment (Hass.io/Docker/Windows/etc.):

hassio on hassbian using dale3h's hassio installer.
Component/platform:

smartthings
Description of problem:
Can't populate smart lock(zwave)'s status.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
N/A

Traceback (if applicable):
N/A

Additional information:

Locks are of the lock capability, which wasn't part of 0.87.  It has since been added #20848 and will hopefully be part of 0.88.
While #20848 would represent a lock as a sensor, it will eventually move to the Lock component in the future once that's implemented.

@andrewsayre Ive created a SmartThings Lock component here, haven't completed the docs or tests yet. Is it close enough to what you were aiming for? (i.e should I do the docs/tests and open a PR or just wait for your changes to come down the line 😄)

@bendews That looks awesome (you must be using the latest version of pysmartthings that I released today--hah).  Open a PR!  There's just a couple of suggestions - like we can pull some of the custom ST data attributes into the state attributes, but otherwise you've got it 95% of the way there!

Thank you both!
Looking forward to it!


Add loader support to django_router

Description
Adds support for the loader arg within route.
Checklist
Please update this checklist as you complete each item:

[ ] Tests have been developed for bug fixes or new functionality.
[ ] The changelog has been updated, if necessary.
[ ] Documentation has been updated, if necessary.
[ ] GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

This is going to be better done within reactpy_router.route(loader=...), so I'm closing this PR.


Make ParseLabels stricter

This pull request makes the following additions & changes:

Add a test case (TestDecodeDnsAnswer_PathologicalPacket) that demonstrates how the current non-strict version of ParseLabels can be (ab)used with a ~65 kilobyte packet that takes lots of CPU power and multiple gigabytes of memory to parse.
Make ParseLabels stricter in a way that is (hopefully) quite a bit stricter about the input it accepts:

Check that there's enough packet data to read before each step, including pointer bytes.
Ensure that the maximum total name length is 253 (when counting the separator dots). Note that the code compares to 254 instead of 253, because allowing an imaginary dangling separator dot makes bookkeeping easier.
The two most significant bits of label headers bytes must either be both set or be both unset. Return error when encountering a label header byte that doesn't adhere to this rule. This also effectively limits the length of a single label to 63 bytes.
Require pointers to always point to a prior name (based on a reading of RFC 1035, section 4.1.4). We also make a point to ensure that the prior name can't overlap already processed labels. These rules turn pointer loops into parsing errors, so the the separate map for tracking such loops can be dropped.

Add test cases for the following strictness checks.
Fix a corner case where a valid compressed name got suffixed with an extra dot.

The comments in the pathological packet code try to explain the logic behind it, but in short the idea is to create a message with one question and N CNAME answers. The question contains a very long (too long) name composed of chunks of oversized labels that are interleaved to save space. Each chunk is then followed by a burst of pointers that try to duplicate the data as much as possible, the last pointer jumping forwards and continuing decoding. The name is neatly finished with a null byte when we can't fit any more data to the first 16383 bytes that pointers can point to. A quick check seems to indicate that a name that's encoded like this takes somewhere around 700 kilobytes of memory (don't quote me on this).
The question is then followed by as many CNAME answers as we can fit into the remaining message space. Each answer is kept as short as possible and points just to the name in the question, so that the already bloated name gets copied many times in the memory.
In my Docker-based dev environment the test takes multiple gigabytes of memory and times out after 240 seconds or so.
I made the pathological case the first commit in this pull request so that it can be easily tested against the non-strict version of ParseLabels:
git checkout 3811d0e088002883551786e270c4af7f4a2a0cee
go test ./dnsutils -v -run PathologicalPacket

Thanks a lot for your contribution.
I will take a look to your improvement, it seems to be very instructive :)


RangeError (index): Index out of range: index should be less than 10: 10

Hi, i am getting this error when hot restart the application.
RangeError (index): Index out of range: index should be less than 10: 10
This is when I have more then 10 items in my data table. If I change row per page in my app to a value more then my items count, everything works fine.

Is the table loading data from a future? I had this as the table is expecting a complete list and is instead obtaining (some) null value(s).


purchase_order is typod

purcharse_order should be purchase_order.
This is a breaking change so the next minor should be bumped (because this is an 0. release)

Fixed in https://github.com/equinix-labs/terraform-equinix-fabric-connection/commit/1c7addb64da7b1b99202abe64b73f7a7c5398295 (v0.5.0)


Disable onClick auto close for nav menu

I just wanna ask about how to disable automatic close for dropdown menu on nav bar for specified menu item like below picture:

This is a Bootstrap related issue. The only way to do that is via javascript:
$("#your-menu-id").on('click', function (e) {
  e.stopPropagation();
});

Thanks for replying and help Abdullah :)

No problem. Did it work?

Yeah it worked but the button group onside it not working since we disabled the event from running in the whole div :sweat_smile:.
I'm working on this solution

I am actually working on a custom mega menu for the premium collection. Thanks for sharing the solution!


MAID-2688 fix/error: adds missing error handling for failed app_reconnect

Coverage decreased (-0.1%) to 94.881% when pulling 857ef9b9f4b2768a701859a434eb12e3c845f047 on hunterlester:2688 into 830f6969bd9c7f5fc1da284cff8c58105da70136 on maidsafe:master.


[sleek2, minor] Archive file is not configurable

Bug Report
IMPORTANT:
Please follow this template strictly when reporting bugs. Providing detailed and accurate information helps the development team to understand and address the issue effectively.
App Version: 2.02
Platform: Linux
Installation Method: Appimage
Bug Description:
There is a little inconsistency: when archiving completed todos, the app says the archiving will happen in the configured archive file, but this seems not to be configurable (yet).

Right click on the file tab will give you the option to define your custom done file for each todo file.

Great! Missed that! Thanks and sorry for the noise

The way archiving works, or more the process of how the archiving file is defined, has changed fundamentally. This has been discussed in a parallel issue. I am going to close here for now.


Include connection to training/scoring data sources

The template should include realistic guidance on how to connect to data sources:

For training, how to connect to data sources (whether of a type supported by Azure ML Datasource classes, or other ODBC data source type)
Whether we should have a separate pipeline stage for pulling the data (separation of concerns + reuse of run steps) or just query the data in the training step
How to manage credentials, one way is to use Key Vault in the run script itself (https://github.com/Azure/MachineLearningNotebooks/blob/master/how-to-use-azureml/manage-azureml-service/authentication-in-azureml/authentication-in-azureml.ipynb) but it's hard to find, should be part of the solution template (+any other method to manage credentials if appropriate)
For scoring, similarly how to manage connectivity to data sources. Enterprise DS models often enrich incoming requests with data from a data mart (e.g. user profiles)

+1 there should be at least one sample that uses the Azure ML managed data stores.
https://docs.microsoft.com/en-us/azure/machine-learning/service/how-to-access-data#train

I believe this is fixed by #134. I'd like to keep the DataOps for ML cycle separate from this repo - and yes it should be in its own pipeline.  Eugene is working on other supporting documents in this space.
Key Vault integration is present with Azure DevOps task groups.  We link to existing documentation on how to add different types of data sets which will work with this approach.


DOC: Fix old reference to Image Number

Before DICOM standard, the Instance Number (0020,0013) was referenced as 'Image Number'. This turns out to confuse users. Fix this.

PR Checklist

[ ] :no_entry_sign: Makes breaking changes
[ ] :no_entry_sign: Makes design changes
[ ] :no_entry_sign: Adds the License notice to new files.
[ ] :no_entry_sign: Adds Python wrapping.
[ ] :no_entry_sign: Adds tests and baseline comparison (quantitative).
[ ] :no_entry_sign: Adds test data.
[ ] :no_entry_sign: Adds Examples to ITKExamples
[ ] :no_entry_sign: Adds Documentation.

Refer to the ITK Software Guide for
further development details if necessary.

For reference:

https://sourceforge.net/p/gdcm/bugs/475/

@finetjul


Created possibility to add multiple application paths to a specific InjectorConfig

see https://cognifide.atlassian.net/browse/SLICE-154

Changes Unknown when pulling 48d4ba81602670716df5787cbb4ee9383ec84407 on royteeuwen:feature/add-multiple-apps-paths into ** on Cognifide:master**.

Changes Unknown when pulling fe6a081269eb06adca9d5f208fb1cb6b3ab8218a on royteeuwen:feature/add-multiple-apps-paths into ** on Cognifide:master**.


Bug in Contoso Coffee Demo

In Table    https://github.com/microsoft/ALAppExtensions/blob/main/Apps/W1/ContosoCoffeeDemoDataset/app/Tables/ManufacturingDemoDataSetup.Table.al,
several field length are to short,
    field(31; "Retail Code"; code[10])
    {
        DataClassification = CustomerContent;
        Caption = 'Retail - Gen. Prod. Posting Group';
        TableRelation = "Gen. Product Posting Group";
    }

-> should be length 20, for example.
Problem arises, if a customer has created a record with length 15, and renames it, there will be an error.
(
There hopefully will be some kind of automatic check after so many years to prevent this errors.
https://github.com/microsoft/AL/issues/4493
)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 46387.

Availability update: We will publish a fix for this issue in the next update for release 21.
Build ID to track: 46565.


Embedded user manual within site

Created new pages for each release that show manual embedded in
site (using iframe)
Left old (non-embedded) pages for historical reasons and due to anchor
tags not working with new pages
Updated links in navbar to point to embedded manual

Can you still create #section links when the manual is in the iframe?
We actually publish the manual to Maven Central. I'd almost rather serve the pages from there, and drop the additional hosting. Putting in the iframe may make it easier to do that, because we can make it look like we're still hosting it. If section links still work, it may be best to just wrap the manuals in their original locations, but link to the manual on Maven Central, rather than change the link in order to keep the unwrapped version at the previous location.

@ctubbsii, I like the idea of external hosting but the latest user manuals for 1.7 and 1.8 published on the website don't match the 1.8.0 and 1.7.2 releases published to maven central

I agree it makes sense to move the old ones so links go to the iframe version. Good point on the external hosting. We tend to update the manual between releases with typo and related fixes.

Overall, I'm not convinced that it's better to have the manuals embedded into the site. It adds complexity to the site layout, and maintenance. It also has some side-effects: Links directly to the manual (which includes all of the links inside the manuals themselves) will still go to the raw, unwrapped version. It also makes it harder for users to right-click (or Ctrl-S) to save a copy of the manual.
While those issues aren't insurmountable, and the windowed look does look nice enough so far as it goes, I think maybe it's better to just open the manual in a separate window/tab. That's a much simpler way to address the navigation issue, is a much smaller change, and requires far less maintenance. That way, the manuals will continue to be thought of as separate, standalone items, which are independently downloadable and portable regardless of the website.

@ctubbsii, I pushed another commit 2f8d8255d1c3311bb517 that puts a warning above the manual telling users that the manual is embedded.  It also links to the standalone manual.  This lets users decide how they want to view manual (as I am sure some will prefer embedded and others standalone).  Does that work?

@mikewalch I think that change is better, but I don't think it changes my overall opinion. At this point, I'm -0 (against, but not a veto), and would prefer a simpler change of making sure the manual opens in a new window/tab, and that the manual has a link back to the home page. But, my opinion is one of many. I defer to the majority.