Hue Tap Dial Switch Support of Dimmer function

Hi Erik
first of all I would like to say thank you for this great homebridge plugin :-)
I actually own a Conbee 2 USB Stick which is connected with the homebridge-deconz plugin to my Home in HomeKit. Now, I just got a "Hue Tap Dial Switch" which has 4 buttons (1-4) on the front and a wheel to dim lights up and down. This actually works in the Deconz web UI, but in homebridge the wheel is exposed as to buttons, one Button (5 & 6) for each scroll direction.
Is it possible to get the wheel working as dimmer in HomeKit or does HomeKit not support dimmer at all? I would like to configure Homekit scenes with it (like dimm all bulbs in kitchen) and not implement everything also in deconz again... if this is not possible, perhaps someone here has an idea for an automation script to get such dimmer functionality?
Thanks and best regards
Jens

HomeKit supports wired dimmers (that control dumb lights, wired to the dimmer) as Lightbulb.  I don't know of any service for wireless dimmers (that control smart lights).  I think the Hue bridge doesn't even expose the dial to HomeKit nor to Matter (since they don't define a wireless dimmer either).  I'm open to suggestions how better to expose the Hue tap dial (and other wireless controllers with a dial, like the IKEA SYNFONISK sound controller), but please include the HomeKit service(s) and characteristic(s) to be used, or point to another Homebridge plugin that does this.

Is it possible to get the wheel working as dimmer in HomeKit or does HomeKit not support dimmer at all?

Yes, that's why I expose the Brightness Change characteristic on lights, to set relative brightness.  Simply create a HomeKit scene (in Eve, or another decent HomeKit app, as Brightness Change is a custom characteristic), for Dim Up, and one for Dim Down.  Then select these scenes from the button action for the dial buttons.

I would like to configure Homekit scenes with it (like dimm all bulbs in kitchen) and not implement everything also in deconz again

Technically feasible, but I wouldn't recommend it.  deCONZ rules are far more reliable and responsive.  If you insist on going the HomeKit route, you might want to expose the deCONZ group for all bulbs in the kitchen and use that in the HomeKit scene, instead of the individual lights.  Recalling a HomeKit scene is like a denial-of-service on deCONZ and the Zigbee network.

Thank you for your quick and detailed reply.... i was afraid that the problem is in HomeKit and not in Homebridge/deconz :-(
Just to clarify... the "brightness Change" way is not recommend to be used with scenes in HomeKit... so I will stay on using decent for dimming the kitchen group and will do the rest with HomeKit. It is very funny, that I can say Siri to turn the brightness in the kitchen down, but HomeKit not support any hardware doing the same ;-)
Thanks you very much for your help :-)

I use HomeKit automations to control my (Zigbee) devices from non-Zigbee controllers, and my non-Zigbee devices from Zigbee controllers.  To control Zigbee devices from Zigbee controllers, I use deCONZ rules.
The Brightess Change is useful for controlling ZIgbee devices from HomeKit automations.  It's just not recommended to create a HomeKit scene with up to 50 (Brightness Change or other) characteristics for up to 50 different lights.  Homebridge deCONZ will need to send a separate API call to deCONZ for each light, and deCONZ will need to send a separate Zigbee message to each light.  WIth Zigbee networks "rated" for about 20 (unicast) messages per second, this is stretching the network.  Homebridge deCONZ does throttlie the API calls, not sending them all at once, but this will cause the lights to react at visibly different moments.
Using a Zigbee group, or ZIgbee scene, from a deCONZ rule results in one (broadcast) Zigbee message, causing all devices to react simultaneously.  Exposing the Zigbee group to HomeKit, Homebridge deCONZ sends a single API call to deCONZ (for that group), and deCONZ sends a single broadcast message.  Note that ZIgbee is "rated" for one broadcast message per second, so best avoid HomeKit scenes containing multiple group accessories.


[Suggestion] Notify user when a new app is added, and prompt them to enable it

In the current implementation of this app, the app does not notify the user of newly supported apps (in my experience) and auto-enables the app. I recently saw all of my browser activity reported to WakaTime, which I didn't want. In my opinion, this probably shouldn't be auto-enabled -- not everyone wants to track all of their browsing activity here.

We tried to notify when new apps are supported in #182, but it's not working so I just disabled tracking all new apps by default in #190.


Version change from 5.0.5 to 6.0.0

Changes

[X] Changed package version to 6.0.0.

Pending release references

Priority-based AST postprocessing (#56)
Support for Solidity 0.8.7 (#57)

Regards.

Codecov Report

Merging #58 (fbf852b) into master (5300261) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   91.93%   91.93%
=======================================
  Files         239      239
  Lines        4739     4739
  Branches      727      727
=======================================
  Hits         4357     4357
  Misses        235      235
  Partials      147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5300261...fbf852b. Read the comment docs.


Remove 'uni' prefix and make icon names camel case

Hey,
Looks like a great lib! Just about to switch to Unicons and up this pops.
I don't see the point of the uni prefix. I suspect most people will move their setup to a plugin file (you have to in Nuxt by default) so this just seems like extra code.
Additionally, if both the imports and the names were camelCase, it would make it much easier to copy / paste icon names as they are needed:
import { checkCircle } from 'vue-unicons/src/icons'

Unicon.add([ checkCircle ])

<unicon name="checkCircle"/>

Looking forward to using.
:D

If you don't want to do the camel-casing, it turns out it's pretty simple to optimize the declarations with an interim functional component:
Vue.component('icon', {
  functional: true,

  props: {
    name: {
      type: String,
      required: true,
    },

    size: {
      type: [Number, String],
      default: 12,
    },

    fill: {
      type: String,
      default: '#8795a1'
    }
  },

  render (h, context) {
    const { name, size, fill } = context.props
    const props = {
      name: name.replace(/([a-z])([A-Z])/g, (match, a, b) => a + '-' + b.toLowerCase()),
      width: size,
      height: size,
      fill: fill,
    }
    return h('unicon', { props })
  }
})

Duplicate #20

Export is not reserved.


pokemon go fails to login

everything is up and running but if i try to log in pokemon go it fails to do so
(if i stop the prosy server it connects correctly tho)

It was temporarily not working for me as well, but it seems to be working fine atm. Mind giving it another try?

I am getting the same, first time trying to use it after pulling master.

Are you both on Windows? This doesn't seem to be an issue on OSX.

Ubuntu 14.04.4 LTS

I am on OSX. Haven't used Windows in years.

@justinleewells any ideas? Not sure where to start debugging this.

I'm honestly not sure. I just upgraded the mitm version. Maybe try that? It seems like an issue with the POGOProtos, which is what they updated.

now it logs but on the node app there are no pokemon displayed

Same here, just cleared out my node_modules folder and updated the app, re-ran npm install and got everything up to date. The app will login and work now, but I am not seeing any pokemon in the node app.

I've updated to the newest version.  It still seems to have trouble logging in.  I don't have any more information to share yet other than to say that something still isn't working 100% properly.  I see standard log messages about starting servers for various domains.  I'm going to keep debugging later

Turning on mitm debug I get this output snippet:
starting server for pgorelease.nianticlabs.com
https server started for pgorelease.nianticlabs.com on 33697
[+++] Request to /plfe/rpc
[+] Request for action GetPlayer:
{}
[+] Request for action GetHatchedEggs:
{}
[+] Request for action GetInventory:
{}
[!] Overwriting POGOProtos.Networking.Requests.Messages.GetInventoryMessage
[+] Request for action CheckAwardedBadges:
{}
[+] Request for action DownloadSettings:
{}
[+] Waiting for response...

and then nothing seems to progress.  I'm not sure exactly where to go from here but I'll try some more tomorrow.

I am having the same issue. It works when I first login to the app and then switch to my WIFI connection. I am on Arch Linux x64, but have installed everything in a clean Debian environment using Docker (see PR #21)

Getting the same result as @nubs, and same output from the server after turning on debug to the MITM instance.
Login hangs and eventually fails.

I was able to get things working kinda after making a few changes.  I logged into pokemon go over 4g, then once I was logged in I switched over to the wifi with proxy.  That still only fetched one pokemon at a time and was kind of buggy, so I made a change to the node.js code to set the date for the inventory delta request back a bit (data.last_timestamp_ms = data.last_timestamp_ms -<PHONE_NUMBER>).  That finally got me a useful inventory dump that I could use.

It actually worked for me after removing the request handler (which deletes the last_timestamp_ms altogether).  Login was fine, full inventory was returned.  I don't know enough about the code to know why the timestamp should be deleted on the first request though.

could you share a bit more about what you did to get a full inventory?

If you're having the same problem as me, I just opened up the index.js and commented out the request handler, lines 49-55.  I do not however know the reasoning behind deleting the timestamp from the first request nor the consequences of removing the handler and not doing so.

That didn't work for me=[  I guess I'm having some other problem.

That worked for me too actually.


Update to encrypted attachments v2

Set half the IV to zeroes as per comment, and update tests.

LGTM


Add rulings

Requires PR 751 from the JSON repo to be present in order to work.
This PR is very much a work in progress and is not ready for submission.
New functionality:

Rules JSON creator task, requires JSON from the NRDB mysql DB to be the source.
New importer functions (flag-guarded) in the cards:import task.
Adds basic RulingSource and Ruling entities, along with basic resources to serve them.
Adds simple relationships between the two new entities and the Card resource.

There are a lot of open workflow questions to work out and I don't love the "Delete everything and get new rulings with new IDs" style of importing.  It's bad.
Couple of example outputs:

Could this also expose the name of the ruling source?


Created Java Projects for beginners

I have added 2 Java Projects for beginners. The process of the project and what are the packages should be installed are mentioned in the file clearly with Source codes.

Highlight headings....

Highlight headings....

I have added headings so can you please accept my pr request.


Issue containerssh/containerssh#97: Honeypot guide

As requested by @mkfifos this is a new guide to deploy a honeypot with ContainerSSH.

Thanks for the review @mhmxs


Tracking: etcd-backup HeaderTimeoutPerRequest is too short

We have a customer who has experienced some timeouts in the etcd backup phase during intermediate upgrades of gravity 5.2. The exact circumstances are poorly understood, but code review indicates a possible cause where we're defaulting to a low header timeout in the etcd backup code.
This issue is tracking the adjustment to the header timeout, under the assumption it could be contributing to the upgrade failures.

Change has been vendored into each release branch, closing.


Switch from requirement.txt to environment.yml

Switching from requirements.txt to Conda environment file environment.yml further reduces the CI times since we can use cache. On a cache hit, the whole CI run now take  ~1m 30 (2m on cache miss). Furthermore, it is possible to specify both conda and pip dependencies in the environment file, which leads to massive simplification -- the whole environment specification is now contained in a single file (except for Julia et al).
Other changes:

move the remaining install scripts from scripts/ to root dir
fix pyjulip version (broken in last  PR, whoops)
further cleanup of install scripts

@juraskov this is ready for review

Thank you for the README update, this should be good to go. :rocket:
(prepac for the last two commits)


Custom btc display unit

Enable displaying BTC in mBTC, uBTC, Satoshi units.
Correctly display summery if output currency isn't BTC.

Description
Implements https://github.com/Mikadily/poloniexlendingbot/issues/197
Fixes https://github.com/Mikadily/poloniexlendingbot/issues/196
TESTING STAGE
In Testing
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read CONTRIBUTING.md
[x] I fully understand Github Flow.
[x] My code adheres to the code style of this project.
[ ] I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
[N/A] I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
[ ] I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

I suggest we repoint this to master, really need to merge #174

What's prevents you from merging, you don't need to wait for this PR.

@Evanito please review

I approve this PR as is, but suggest the changes above. Also Codacy has some quick changes it wants done.


added stopPropagation() to allow nested scrollers

One line addition that sets kinetic to allow nested scrollers by default.
Also added a demo page.
Tested with chrome and firefox on Ubuntu.
Did not modify the touch events because i don't have a tablet to test.

thanks @cc-lam i have taken a quick look and it seems to be ok, i'll just add this in for touch and then merge it in

i've merged this in to the 1.4 branch ready for next release. thanks @cc-lam


ERROR in ./virtual__uno.css 4:14-362 Module not found: Error: Can't resolve '../virtual/__uno.css'

Once I import uno.css in main.ts:
import 'uno.css'

An error happened:
ERROR in ./_virtual_\__uno.css 4:14-362
Module not found: Error: Can't resolve '../_virtual_/__uno.css' in '/MyProject/_virtual_\'

My deps:
"@unocss/webpack": "^0.32.12",
"unocss": "^0.30.6",

My webpack.config.js
const { defineConfig } = require("@vue/cli-service");
const { presetAttributify, presetUno, presetIcons } = require("unocss");

module.exports = defineConfig({
  transpileDependencies: true,
  chainWebpack: (config) => {
    config.resolve.extensions.add(".ts");
  },
  configureWebpack: {
    resolve: {
      fallback: {
        http: false,
        https: false,
        url: false,
        timers: false,
      },
    },
    plugins: [
      require("unplugin-icons/webpack")({
        autoInstall: true,
      }),
      require("@unocss/webpack").default({
        theme: {
          fontFamily: {
            sans: '"Inter", Inter var,system-ui,-apple-system,BlinkMacSystemFont,Segoe UI,Roboto,Helvetica Neue,Arial,Noto Sans,sans-serif,Apple Color Emoji,Segoe UI Emoji,Segoe UI Symbol,Noto Color Emoji',
          },
        },
        presets: [
          presetIcons({
            extraProperties: {
              display: "inline-block",
              height: "1.2em",
              width: "1.2em",
              "vertical-align": "text-bottom",
            },
          }),
          presetAttributify(),
          presetUno(),
        ],
      }),
    ],
  },
  lintOnSave: false,
  pluginOptions: {
    windicss: {
      // see https://github.com/windicss/vite-plugin-windicss/blob/main/packages/plugin-utils/src/options.ts
    },
  },
});

In WSL?

No，Macbook pro

No，Macbook pro

Try to modify backSlash function in node_modules/unplugin/dist/index.js
function backSlash(path2) {
  return path2.replace(/\//g, import_path4.sep);
}

Still got the same error  :(

@peterroe can you provide a minimal repro?

@peterroe can you provide a minimal repro?

vue-cli example  has same issue in windows WSL, maybe it exists in linux

OK，I try to minimize it, but it takes some time. This is my origin repo : https://github.com/peterroe/Rss-Reader

I have been developing on windows system before, and this error occurred after trying to work with macbook

@peterroe try import 'virtual:uno.css' or import 'unocss'

Syntax Error: Reading from "virtual:uno.css" is not handled by plugins (Unhandled scheme).
Webpack supports "data:" and "file:" URIs by default.

webpack doesn't seem to support it

@peterroe so in Windows still working or the same error with your repro? can you send the full stacktrace here<EMAIL_ADDRESS>

Still got the same error :(

No，Macbook pro

Try to modify backSlash function in node_modules/unplugin/dist/index.js
function backSlash(path2) {
  return path2.replace(/[\\/]/g, import_path4.sep);
}

@peterroe  modified it exist this error?

@peterroe modified it exist this error?

this should work, I'm on Windows machine so I haven't that problem, the unocss works

@peterroe modified it exist this error?

this should work, I'm on Windows machine so I haven't that problem, the unocss works

ion linux(WSL), I met the same error, after temporarily modifed, it works on windows and linux

@aliuq we should file a bug on unplugin

@peterroe fixed upstream, next release should update unplugin version to 0.6.3 and should fix this issue, I'll close it when updated, you'll only need to update unocss

I try to upgrade unocss. But still can't solve this problem
"unocss": "^0.33.1"

stacktrace:
ERROR in ./_virtual_\__uno.css 4:14-362
Module not found: Error: Can't resolve '../_virtual_/__uno.css' in '/MyProject/_virtual_\'

Still got the same error :(

No，Macbook pro

Try to modify backSlash function in node_modules/unplugin/dist/index.js
function backSlash(path2) {
  return path2.replace(/[\\/]/g, import_path4.sep);
}

@peterroe modified it exist this error?

I tried to modify it like you said. But still got the same error

And I upgrade unocss to 0.33.1, ...same error :(

@peterroe you will need to delete node_modules and make a fresh install, or await to release a new version with the unplugin version updated...

webpack dep is still using 0.6.2 and we need 0.6.3: https://github.com/unocss/unocss/blob/main/packages/webpack/package.json#L46

OK. Thanks.👌

OK. Thanks.👌

check this, it seems it is working but wait to new release if you don't want to remove your node_modules: https://github.com/unocss/unocss/issues/797

@peterroe you need to update @unocss/webpack not unocss

@peterroe you need to update also @unocss/webpack not only unocss

Thank your help. Finally I succeeded😊.I think there are two reasons why my use of unocss fails:

backSlash
yarn

I update my unocss dep✅, and I switch yarn to pnpm✅.
I don't know why yarn also has problems


The terminal does not work on Windows

The CLIPS terminal does not open on Windows, it just hangs. Execution does not reach any lines after the node-pty spawn() call.
If the CLIPS terminal is opened as a normal vscode terminal though (using the createTerminal() function), it actually works.
But using that would prevent commands (and outputs) from bypassing the terminal window, and thus it would be polluted by text from the commands for updating the views.

After some digging, I found several node-pty issues that might be related to this issue.
Also, inside the TerminalProcess class in vscode there are some comments that reference them, which suggests that there are some workarounds in place for those issues. That would explain why the createTerminal() API works, whereas using node-pty's spawn() directly doesn't.
https://github.com/microsoft/vscode/blob/dabc9bdc9db2854b8289e1f154726c00f67a2665/src/vs/platform/terminal/node/terminalProcess.ts#L43

This leaves several possible courses of action:

Finding a way to call TerminalProcess directly from the extension

It doesn't seem feasible, as the class does not seem to be exposed in vscode's Terminal API

Figuring out which workarounds fix this issue and re-implementing them inside the extension

Leaving a suggestion/issue in vscode for a way to create standalone terminal processes

This would probably improve the usefulness of Pseudoterminals in vscode
But it would probably take a lot of time to be released (if it ever did), because it would not be a priority

Waiting for node-pty and/or vscode to release some kind of fix/workaround to this issue

Creating a Windows-specific version of this extension that uses normal Terminals instead of Pseudoterminals. This would at least make it work, but it would also make it worse in some aspects:

All commands and command outputs would be shown in the terminal window. This would include commands for updating all views, which are called after each and every command.
Processing for all terminal I/O would be delegated to vscode and CLIPS.

This would make some custom implementations useless (command history, command editing)
And other implementations would not work anymore (clear line/screen, errors colored in red)

The issue seemed to be in the conpty library that node-pty uses under the hood.
Luckily, there's an option to make it work with another library called winpty instead, which worked.
Using winpty required some extra work on handling data output because it seems to work differently than the Linux implementation in that regard.


Support an in-browser POD : local storage via data:// scheme

This may be hair-brained, but it could potentially have many uses.  It could work by making a cut-out in solid-auth-client.fetch() that handed fetching of data:// URIs to a local-storage aware library that returns success/failure in an object similar to what an HTTP fetch returns.   There could be sync apps that would use standard rdflib or ldflex methods to copy files to a cloud-based POD.  I can work on this if you think it's useful.

Or how about a browser extension that stores data in its own storage? Would love to brainstorm about this!

How about a separate library that can create a POD on the service worker? Likes https://github.com/linonetwo/ipfs-browser-gateway
I think a potential usage is using it as a local cache when user don't actually have a WebID. If you are new to SoLiD and want to try out a note-taking app, It may provide a local POD for you. (maybe

I think a browser extension is a great idea to use in addition to my idea rather than a replacement for it.  The advantage of building it into solid-auth-client is that any app will then be able to dependably use rdflib/query-ldflex to interact with the local storage (or indexed db)  whereas they could not count on having an extension installed.

@michielbdejong I've created a file:// handler for rdflib which basically treats the file system as a minimal Solid REST server.  It might be a useful piece of a browser extension for an in-browser POD.  It also has some tests that might be useful elsewhere.

My in-browser-pod is almost ready for prime time.  It can store and access resources and containers in localStorage via rdflib.  It would be accessible in all apps if you include a cutout for it in solid-auth-client (if the IRI scheme is app://, use solid-rest-browser's fetch).  Here's links to a working demo and the code repo..  It's not finalized, but it does the basics, such as returning a GET Container as a set of LDP:Contains triples.

Update : the in-browser storage can now handle GET, PUT, POST, DELETE on resources and containers according to (my interpretation  of) the Solid  REST spec.  It can transparently handle all rdflib methods except those requiring PATCH and that most likely goes for most other Solid libraries.   It doesn't touch ACL or other related specs, only the REST interaction.  I've had reports it works fine on iPhone and Android.

@RubenVerborgh I am ready to submit a PR to include a single line at the top of solid-auth-client's fetch
if(inpu.startsWith("app")) return appfetch(input,options)l

Should I expect the user to load solid-rest-browser themselves so that appfetch pre-exists? Or should it be imported by solid-auth-client?  Or are you considering not including the PR at all.  If so, please explain.

If possible, I would suggest require('solid-rest-browser') and then configure webpack such that it defaults to window.something.something (https://github.com/linkeddata/rdflib.js/blob/v0.20.1/webpack.config.js#L45-L46). That gives people the option of distributing/packaging it the way they want.

I'm sorry, I'm pretty slow-witted when it comes to require/import and webpack.  Could you clarify where the require would occur and what you mean about the webpack?

Sure, so that would need to become:
if(input.startsWith("app:"))
  return require("solid-rest-browser").fetch(input,options);

and https://github.com/solid/solid-auth-client/blob/v2.3.0/webpack/webpack.common.config.js#L28 would need something like
'externals": {
    'solid-rest-browser': {
        root: ['whatever', 'whatever'],
        commonjs: 'solid-rest-browser',
        commonjs2: 'solid-rest-browser',
    },
}

Ah!  Thanks so much!  I am starting to get it. It does sound like the cleanest way.  Two more questions:  users will need to import solid-rest-browser in a script tag placed before the script tag for solid-auth-client?  And solid-rest-browser will not be included at all in the package.json for solid-auth-client?

Two more questions: users will need to import solid-rest-browser in a script tag placed before the script tag for solid-auth-client?

If they use the default webpack build solid-auth-client.bundle.js, yes. If they require the client in their own apps, then no.

And solid-rest-browser will not be included at all in the package.json for solid-auth-client?

It would actually. It would just not be bundled with the default webpack build.

users will get an error if they try an app:// url without having imported it ... should there perhaps be a try/catch around the require in solid-auth-client to warn them?

That wouldn't be really clean, because a require is not expected to fail. Instead, we might want to configure webpack to include a stub. Now, we're telling webpack "look in window.something.something, whereas we could say "include this try/catch stub" (and that stub might very well be part of a separate file in solid-rest-browser).

Great!  I'll set that all up and submit a PR.  Thanks very much for your help!


Add documentation for username registration via BNS for Stacks 2.0

It doesn't appear we have any good place to send developers wondering how to integrate BNS into their apps or otherwise execute BNS-related contract functions separately on Stacks 2.0 (e.g. instructions on how to register usernames for users or transfer usernames between users).

we should prioritize:

teaching users how to register a username on .id
a simplified description of how BNS works
registering their own namespaces

happy to help with this.
potentially when we launch DDNS, we can add a tutorial to this section for how users can get started with that, and how developers can register names on it.

I would like to know how to use the explorer sandbox for registering namespaces and BNS names as this will work regardless of available apps. And it is convenient to have a workflow that works for both testnet and mainnet.

Here are some issues I am running into when trying to preregister a namespace through the explorer sandbox. It has a buffer of 20 for the hashed-salted-namespace whereas all the 160 bit hashing algorithms I know of (RIPE-MD160, SHA0/SHA1 and Tiger-160) produce strings of 40 characters.

What hashing should be used here?
Wouldn't it make more sense for this field (hashed-salted-namespace) to accept 40 chars in HEX? instead of 20 chars in ASCII?
Now the transaction fails with BadFunctionArgument because it does not accept the strange ASCII characters (provided screenshot).

@314159265359879

hash160 uses RIPEMD160(SHA256(x))
yes, i think it would make more sense for 40 chars? not too sure on this
read no 1

"hash160" is using the clarity impl. check here.
i'm attempting to register .ddns on testnet. will update on how it goes.
txid: 0xd2a2150e59d1771df9bdb9aeb090b83d0eac7ddc560dd09cf910f82c18bb87f6


ngc returns Unexpected value 'AgGridModule' imported by the module 'AppModule'

when i try to compile my angular 2 app through @angular/compiler-cli ngc command, i get the error Unexpected value 'AgGridModule' imported by the module 'AppModule'
seems like the module resolver of the compiler is not able to resolve the AgGridModule but i can't figure out why
if i run my app bootstrapped with platformBrowserDynamic, the module gets resolved and the ag-grids are rendering fine

We'll look at this once ng2 has been released (final version), but at a guess it might be down to the fact that we use the RuntimeCompiler in our module, and the compiler isn't deployed (afaik).

Final version is out!
Here's a post explaining what has to be done in order to fix this issue:
http://stackoverflow.com/a/39515266/6805453
In short, if i get this right, the module has to be compiled with @angular/compiler-cli ngc to generate a metadata.json file that has to be delivered with the compiled module.

thanks for the link - we'll investigate this early next week
with regards to 2.0.0, 6.0.2 (released yesterday) of ag-grid-ng2 (and examples) supports 2.0.0

An update on this - I'm still investigating but analysis so far leads me to believe that AoT compilation with our ng2 module may not be possible, given we rely on COMPILER_PROVIDERS, and this cannot be resolved and compilation time (more generally, the compiler cannot resolve items that can only be determined at runtime).
An issue regarding this has been raised in the last day or so: https://github.com/angular/angular/issues/11780
The outcome of that issue will probably determine (in the short term at least) if we can provide AoT support

I've just release 6.1.1-beta - can you give it a go and see if it resolves your problem
To use it, import AgGridModule in your module (not AgGridModule.forRoot() - this will remain for non-aot/dynamic components)
In summary, there are two choices here - either:

AOT and no dynamic/ng2 components
dynamic/ng2 components and no AOT

It is unfortunately not possible to have both AOT and dynamic ng2 components due to restrictions around whats possible with the cli.

Ok i'll try to give it a shot this week
I'll let you know the outcome
Thanks

I made a very simple example work based on the angular class starter, which uses webpack and does AOT and tree shaking.

Thanks for this - I'll be releasing 6.1.1 which will include two options - one for aot and one without
I'll take a look at your link as soon as possible!

6.1.1 release - please see https://www.ag-grid.com/best-angular-2-data-grid/#aot for AOT usage
thanks

I've tried using 6.1.1 and it is crashing at run-time.
Error: Uncaught (in promise): Error: Error in ./Home class Home - inline template:1:2 caused by: No provider for Ng2FrameworkFactory!
I have created a working repo (with ag-grid-ng2 version 6.1.2-beta) so you can try it.
Just change to 6.1.1 and you'll see it.
git clone https://github.com/joanllenas/ag-grid-ng2-webpack2-aot-test.git
npm i
npm start

Cheers

Please use 6.1.1 and please see the docs for usage - you need to specify either AgGridModule.withAotSupport() or AgGridModule.withNg2ComponentSupport()
I've updated your repo (locally of course) and it works fine from what I can see

Sorry, I totally missed that step.
Works like a charm now.
Thanks

I just updated my project to Angular 2.0.2 and ag-grid 6.2.1/ag-grid-ng2 6.2.0
I configured my AoT compilation and bundling with rollup but when i run with the result bundle i get this ag-grid error:

Uncaught TypeError: Cannot read property 'GridOptionsWrapper' of undefined

The same error have been referenced in #68 so it may be related.
Its probably worth to mention that in my rollup process i run the rollup plugin commonjs (which will convert from commonjs to ES2015 module handling). That is needed because it seems rollup only supports ES2015. I am also running buble to convert the end result from ES2015 syntax to ES5.
Any clue on what's the problem there?

@philbern I am seeing the same issue with Gridoptionswrapper. Have you been able to get past it?

I've been working on moving our ng2 support to include aot and dynamic components and have it working now. We'll be releasing it soon, but its worth noting that I'm using systemjs-builder for the rolling up, not rollup.
If you're using rollup you should be able to run it through the commonjs plugin, which should convert it to es2015.
I'll update once I have a beta ready everyone
thanks

I am using AOT and rollup, basically following the Angular 2 cookbook on https://angular.io/docs/ts/latest/cookbook/aot-compiler.html.
In rollup-config.js I have
commonjs({
include: [
'node_modules/rxjs/',
'node_modules/ag-grid-ng2/'
]}
}),
..
I do a
node_modules/.bin/ngc -p tsconfig-aot.json
followed by
node_modules/.bin/rollup -c rollup-config.js
In app.module.ts I have
import { AgGridModule } from 'ag-grid-ng2';
..
@NgModule({
imports: [
BrowserModule,
AgGridModule.withAotSupport(),
..
I do not get any errors while compiling or treeshaking but when I run ag-grid I get a
ReferenceError: require is not defined
in the Chrome devTools console.
Btw. in JIT mode using
@NgModule({
imports: [
BrowserModule,
AgGridModule.forRoot(),
ag-grid does work.


OCPBUGS-11861: Backport MetalLB log level feature

This PR backports the metallb log level feature, from the following PRs:
https://github.com/metallb/metallb/pull/1198
https://github.com/metallb/metallb/pull/1180
PRs was written by Andrea Panattoni<EMAIL_ADDRESS>

/jira refresh

/jira refresh

/approve
/lgtm

/label backport-risk-assessed labels

/label cherry-pick-approved

/label backport-risk-assessed labels

This wasn't rendered correctly, I think you need to remove the "labels" at the end

/label backport-risk-assessed


Question: Why are actions restricted to form-encoded data only?

Describe the problem
First of all I welcome new Actions structure. I think it is a great idea. I understand using FormData (as default) for POST-ing data to the server. However, what bugs me, is restriction that you can ONLY use FormData; no JSON allowed.
Is there any particular reason that this is so restrictive? Again, I understand why this should be encouraged, but I don't think this should be forced.
I can think of milion instances when POST-ing JSON objects. When you want to quickly hack something; or your app's UI is dependent on JavaScript then you can expect all users having JS enabled; building APIs, and so on. FormData is quite dificult to work with compared to a JSON Object.
Describe the proposed solution
Quit restricting Actions to FormData only.
Alternatives considered
Way around it is to submit a FormData object with your JSON serialized as form value:
const formData = new FormData()
formData.append('data', JSON.stringify(data))

...then parse the value back on the server side. I don't see any value in this unnecessary step. If someone want's to post JSONs they shouldn't be restricted. If theren's no technical reason to do so.
Importance
would make my life easier
Additional Information
No response

The forms feature only works with forms. If you want to write a json endpoint use the server files: https://kit.svelte.dev/docs/routing#server


Support scopes in relationships

Rails has replaced the :conditions relationships' option with optional lambda/proc scopes for a long time already. It just makes sense for Formtastic to support them the same way it does for the :conditions option.
Given this code:
class Post < ApplicationRecord
  belongs_to :author, -> { active.order(name: :asc) }
end

class Author < ApplicationRecord
  scope :active, -> { where(active: true) }
end

- semantic_form_for(Post.new) do |f|
  = f.input :author

Without this change the autogenerated select input with the list of authors will include ALL authors because it effectively loads the list from Author.all. After this change, the list will be filled with Author.active.order(name: :asc) because the belongs_to relationship includes a scope.
This seems to bring parity to the old way of applying conditions to relationships via the :conditions option which got deprecated back in Rails 4.

I'm happy to merge once I figure out why there is no Github Action build for this PR.

Thanks! 🤘

Thank you! 🥇 👍


Add "remove all" for Alerts

Is your feature request related to a problem? Please describe
As a staff user I'm currently seeing 75 pages of alerts and I would like to be able to remove them all at once
Describe the solution you'd like
Remove all button

This was done already in #1211 ?

Hmm I searched for 'alert' and 'alerts' and 'remove all' etc. Not for 'clear all' I guess, but good that it is already there, guess I need to upgrade to python3.


LINK-2082 | Validate contact person name fields

Description
Validate that contact person first name and last name are filled if the payment is needed for the signup.
Create payment if the signup group or signup group price is higher that 0
Closes
LINK-2082

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr407-ui.dev.hel.ninja :rocket::rocket::rocket:

e2e tests result is failed for https://linkedcomponents-pr407-ui.dev.hel.ninja :crying_cat_face::anger::boom::boom:

e2e tests result is failed for https://linkedcomponents-pr407-ui.dev.hel.ninja :crying_cat_face::anger::boom::boom:

There appears to be test failures in the review build. One comment also about the validation in "shouldCreatePayment". Otherwise looks good.

The test failure in the review build comes from the e2e tests and is not related to this PR. The reason for the failure is too short timeout time. I think that https://github.com/City-of-Helsinki/linkedcomponents-ui/pull/402/files should fix that issue.

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr407-ui.dev.hel.ninja :rocket::rocket::rocket:

e2e tests result is success for https://linkedcomponents-pr407-ui.dev.hel.ninja :laughing::tada::tada::tada:


Dsapce does not send emails in the correct language

Describe the bug
Hi
I'm having trouble translating email messages into another language.
I created files with messages in Brazilian Portuguese, adding the sulfix _pt_BR to each of the translations. However, not all of them are working.
To Reproduce
For example, a user's registration correctly uses the register_pr_BR file. In the case of sending the document, DSpace continues to use the file template in english, submit_archive instead of submit_archive_pt_BR.
DSpace local.cf
...
default.language = pt_BR
webui.supported.locales = pt_BR, es, en
...

Angular config.yml
...
defaultLanguage: pt-BR

languages:
  - code: 'pt-BR'
    label: 'Português do Brasil'
    active: true
  - code: 'es'
    label: 'Español'
    active: true
  - code: 'en'
    label: 'English'
    active: true
...

The database was migrated from DSPace 6.3, and this problem does not occur with old users, only with new ones.

This appears to be a duplicate of #9085?
It is also worth noting that emails language is chosen based on the user's preferred language/locale, with a default value of the default.language.  So, if the user's account has their "Language" set to English in their Profile, they will receive emails in English.

I will extend the question in more detail. Let us initially consider that:

All the following tests were run by recompiling the DSpace backend and frontend (Angular).
Also consider that notification email templates in Brazilian Portuguese follow the country_language_variant format (Ex.: register_pt_BR).
All the custom internationalization JSON file follow the country_language-variant, with the standard files that are already included in the Algular frontend (Ex.: pt-BR.json).

The first aspect that caught my attention is the creation of an administrator user via the CLI.
Let's look at the example below considering that they are in the configuration file of DSpace backend local.cfg:
...
default.language = pt_BR
webui.supported.locales = pt_BR,es,en
...

Following the installation manual we execute the following command to create a admin user:
root ~ # dspace create-administrator
Creating an initial administrator account
E-mail address<EMAIL_ADDRESS>First name: DSpace
Last name: Admin
Select one of the following languages: pt_BR
Language: pt_BR
Is the above data correct? (y or n): y
Password will not display on screen.
Password:
Again to confirm:
Administrator account created

See who where it only shows the default language, and not all those available in the webui.supported.locales parameter.
OK, next.
Let us consider that the user dspace.admin was created correctly and is in the Postgresql database as follows:
dspace=# select email,uuid from eperson;
            email             |                 uuid
------------------------------+--------------------------------------
<EMAIL_ADDRESS>    | 7c94a813-d401-4ca2-9b66-45b61f468176

dspace=# select metadata_value_id,metadata_field_id,text_value,dspace_object_id  from metadatavalue;
 metadata_value_id | metadata_field_id | text_value |           dspace_object_id
-------------------+-------------------+------------+--------------------------------------
                24 |                 2 | Admin      | 7c94a813-d401-4ca2-9b66-45b61f468176
                25 |                 1 | DSpace     | 7c94a813-d401-4ca2-9b66-45b61f468176
                27 |                 4 | pt_BR      | 7c94a813-d401-4ca2-9b66-45b61f468176

The metadatavalue table shows the other attributes related to the user. Note that the metadata_field_id field that stores the language has just pt and not its chosen pt_BR.To solve this problem I used the following command:
variationdspace user --modify  -m<EMAIL_ADDRESS>-l pt_BR

Now let's go to the graphical interface. As mentioned in the previous post, standard Angular notions were used to specify the languages available for selection int the config.yml file:
...
defaultLanguage: pt-BR

languages:
  - code: 'pt-BR'
    label: 'Português do Brasil'
    active: true
  - code: 'es'
    label: 'Español'
    active: true
  - code: 'en'
    label: 'English'
    active: true
...

This configuration is supported, allowing the correct translation of terms into Brazilian Portuguese. But, when the language variable in the user profile does not match the Angular GUI config, mapping is not done as in the figure below.

Basically, the variable use by DSpace backend and frontend, associated with user profil, with mail send and translation of the Angular GUI.
The following table aims to summarize how the tests performed using the combination of these variables.

local.cfg
config.yml
maping lang in profile
mail messages
translation angular

pt_BR
pt_BR
Yes
pt_BR
ERROR

pt_br
pt_br
Yes
en
ERROR

pt-BR or pt-br
pt-BR or pt-br
No
en
pt_BR

In my opinion, it is clearly a bug because of the non-standardization of the pt_BR and pt-BR sulfixes, which causes a conflict between the backend and the frontend. The backend does not support message templates that use _pt-BR as a sulfix. The frontend does not support internationalization files that use pt_BR.
I know that such a problem may be small, and I also understand that this may have gone unnoticed, since the number of Portuguese-speaking countries is small. However, in our institution we include Brazilian Portuguese and Spanish, in addition to English.
PS.: Apologies for my poor English

Hello
I temporarily solved this problem by overwriting any language with no variation (for example, Vietnamese 'vi') with the content 'pt_BR/pt-BR'. Both the notification emails and the Angular interface recognized the corresponding language selection.
I hope this bug will be considered and fixed in the next version.

Hello
I temporarily solved this problem by overwriting any language with no variation (for example, Vietnamese 'vi') with the content 'pt_BR/pt-BR'. Both the notification emails and the Angular interface recognized the corresponding language selection.
I hope this bug will be considered and fixed in the next version.

@leandroecomp : If this is still a bug in the system, then we should reopen this ticket.  Otherwise it will be assumed "fixed".
If you have a fix, please consider sending us a Pull Request with the proposed changes.  DSpace has no central development team, so all bugs are fixed by volunteers who collaborate with us on the next release.  So, if you find a bug fix, we encourage you to send along a PR so that we can include that fix in the next release.
It's unclear to me whether this ticket should be reopened.  But, I'd encourage reopening it if the bug still exists in DSpace itself.


Undefined reference to pthread_rwlock_init

Hey guys,
in my system (Ubuntu Ubuntu 16.04.2 LTS 4.4.0-66-generic), I've gotten "Undefined reference to pthread_rwlock_init" in my build.
In the file guetzli.make I've had to add -lpthread to LINKCMD variable. I don't if it was necessary in your build (maybe not), but I thought it would be interesting if you could add it in your source files.
Best regards,
Rodrigo Gonçalves de Branco

Did you by any chance try to compile a static binary?
What do the following commands print on your system?
pkg-config --ignore-errors --libs gflags || pkg-config --libs libgflags
pkg-config --ignore-errors --static --libs gflags || pkg-config --static --libs libgflags

No, I didn't.
Installing libgflags-dev through apt-get didn't work, so I checked it out https://github.com/gflags/gflags and make installed it.
Here what I got when running those commands:
-L/usr/local/lib -lgflags
-L/usr/local/lib -lgflags -lpthread

Could you pull and try again? I expect that the problem is gone by virtue of the gflags dependency being gone.

Robert, I'm now in my work desktop (Linux Mint 17.3 Rosa 3.19.0-32-generic). I could correctly clone and make it.
I got some warnings, I don't know if it's important to you, so check the log out:
==== Building guetzli (release) ==== Creating bin/Release Creating obj/Release butteraugli_comparator.cc In file included from ./guetzli/butteraugli_comparator.h:22:0,                  from guetzli/butteraugli_comparator.cc:17: third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:146:45: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’    static void *Allocate(const size_t bytes) BUTTERAUGLI_CACHE_ALIGNED_RETURN;                                              ^ third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:257:42: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’    ConstRestrict<T *> Row(const size_t y) BUTTERAUGLI_CACHE_ALIGNED_RETURN {                                           ^ third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:268:7: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’        BUTTERAUGLI_CACHE_ALIGNED_RETURN {        ^ dct_double.cc debug_print.cc entropy_encode.cc fdct.cc gamma_correct.cc guetzli.cc idct.cc jpeg_data.cc jpeg_data_decoder.cc jpeg_data_encoder.cc jpeg_data_reader.cc jpeg_data_writer.cc jpeg_huffman_decode.cc output_image.cc preprocess_downsample.cc processor.cc In file included from ./guetzli/butteraugli_comparator.h:22:0,                  from guetzli/processor.cc:24: third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:146:45: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’    static void *Allocate(const size_t bytes) BUTTERAUGLI_CACHE_ALIGNED_RETURN;                                              ^ third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:257:42: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’    ConstRestrict<T *> Row(const size_t y) BUTTERAUGLI_CACHE_ALIGNED_RETURN {                                           ^ third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:268:7: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’        BUTTERAUGLI_CACHE_ALIGNED_RETURN {        ^ quality.cc quantize.cc score.cc butteraugli.cc In file included from third_party/butteraugli/butteraugli/butteraugli.cc:32:0: third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:146:45: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’    static void *Allocate(const size_t bytes) BUTTERAUGLI_CACHE_ALIGNED_RETURN;                                              ^ third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:257:42: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’    ConstRestrict<T *> Row(const size_t y) BUTTERAUGLI_CACHE_ALIGNED_RETURN {                                           ^ third_party/butteraugli/butteraugli/butteraugli.h:129:76: warning: ‘assume_aligned’ attribute directive ignored [-Wattributes]  #define BUTTERAUGLI_CACHE_ALIGNED_RETURN __attribute__((assume_aligned(64)))                                                                             ^ third_party/butteraugli/butteraugli/butteraugli.h:268:7: note: in expansion of macro ‘BUTTERAUGLI_CACHE_ALIGNED_RETURN’        BUTTERAUGLI_CACHE_ALIGNED_RETURN {        ^ Linking guetzli

I'm aware of them and they aren't concerning. Thanks. Please reopen if you find that it doesn't work on your other machine.

It has worked, I could test it, thank you.


Network Credentials override, fixes Uncatchable exceptions

Adds possibility to ovverride Default NetworkCredentials (In cases where context Impersonation is not an option. Like in my case.)
Fixes uncatchable exceptions in Server loop (I frequently get an exception at _listener.GetContextAsync(); when PhantomJs webdriver is shutting down, which I dont care about but I cannot catch,  a change of method declaration fixed this problem)

AppVeyor builds with msbuild v12, I only have v14 installed, where this builds, sorry...

Nice!
If you wouldn't mind fixing the formatting I'll merge and cut a release. If you can wait a few days I can take care of the formatting and then merge/release.

Yea I'm a tab guy, but no excuse here I totally didnt notice the mixing... let the beating begin http://i.imgur.com/VyMu86F.png


IsBlank can operate on controls without coercing

This scenario can occur, e.g. if a component has an input property expecting a Screen type, and is passed Blank(). In that case, IsBlank() is a valid operation on the control type, even if we're not coercing to the primary output property.

✅ No public API change.

✅ No public API change.


COVID Tracking Project hospitalization data

Data source description
Hospitalization, ICU and vent data, US, daily
Data source location
COVID Tracking Project API
Data format
JSON API
Data issues
Creates new table CT_US_COVID_HOSPITALISATIONS (to be created in COVID19_DEV and propagated to README.md and METADATA.

(Nb. this data is only available at state level to accommodate 1) inter-county hospitalisations, which are pretty common (esp. for ICU cases), 2) HIPAA requirements.)


lang: add checked arithmetic lint check

Similar to how we require /// CHECK: for UncheckedAccount and AccountInfo, we should add a lint for unchecked arithmetic.

the implementation needs to keep in mind that some projects use types that impl the arithmetic traits to avoid overflow instead of using the checked methods directly

new projects now come with overflow-checks = true in the release profile so by default there's no more unchecked arithmetic.
because of that Im not sure theres good arguments for this feature to be implemented. if a dev turns the overflow-checks setting off, they explicitly say they want that behaviour

Agreed with the previous post — no need for this lint especially since overflow-checks is required to be explicitly set now(https://github.com/coral-xyz/anchor/pull/2716).


chore: fallback to building barretenberg targets sequentially when RAM constrained

Attempting to run bootstrap.sh full locally results in my computer freezing due to the amount of memory which building the three barretenberg targets in parallel. I've added a quick check on the amount of available memory and if it's below 32GB then we fall back to building sequentially.

Thanks for this, LGTM

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 13.0 (-86%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 933145e8 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
676
676
676

l1_rollup_calldata_gas
6,424
6,424
6,412

l1_rollup_execution_gas
585,757
585,757
585,745

l2_block_processing_time_in_ms
1,337 (+3%)
4,683 (-1%)
9,256

note_successful_decrypting_time_in_ms
203 (+10%)
516 (-1%)
977 (+1%)

note_trial_decrypting_time_in_ms
:warning: 13.0 (-86%)
30.2 (-24%)
108 (+13%)

l2_block_building_time_in_ms
13,976
51,791 (+1%)
104,270 (+2%)

l2_block_rollup_simulation_time_in_ms
7,983
28,019
56,374 (+2%)

l2_block_public_tx_process_time_in_ms
5,970 (+1%)
23,722 (+2%)
47,795 (+3%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
13,260 (-5%)
26,071 (-2%)

note_history_successful_decrypting_time_in_ms
1,220 (-3%)
2,431

note_history_trial_decrypting_time_in_ms
80.4 (-11%)
145 (+23%)

node_database_size_in_bytes
18,653,264
35,078,224

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
235
44,377
28,214

private-kernel-ordering
207
52,880
14,296

base-parity
4,708 (-1%)
128
311

root-parity
1,685 (+5%)
1,244
311

base-rollup
18,062
165,760
861

root-rollup
49.8
4,359
725

private-kernel-inner
304
73,794
28,214

public-kernel-app-logic
126 (+1%)
35,251
28,217

public-kernel-tail
168 (-1%)
40,928
28,217

merge-rollup
8.46 (-9%)
2,568
861

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
9.93 (-1%)
15.8 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.579 (-1%)
0.490 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
46.0 (-1%)
71.4 (-1%)
232 (+1%)
439 (-1%)
861
1,727 (+1%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.472 (-1%)
0.441 (-1%)
0.421
0.411 (-1%)
0.410
0.414 (+1%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
53.1 (-3%)
105 (-1%)
339
651 (-1%)
1,300 (-1%)
2,612 (+1%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
104
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.473 (-3%)
0.476 (-1%)
0.456 (-1%)
0.449 (-1%)
0.451
0.453 (+1%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
60.6 (-1%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.530 (-1%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
14,966
494,914

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
2,433 (+3%)
1,393

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
16.1 (-2%)
726

@ludamad can you approve please?

Woops sorry


Refactor Makefile: Split build section into smaller, distinct targets

Split the 'build' section into smaller targets. The new targets: 'create_dirs', 'build_linux_amd64', 'build_linux_static', 'build_linux_arm', 'build_windows', 'build_macos', 'build_macos_arm','build_freebsd'.
Updated .PHONY list
Resolves #185

Hi @iskiy,
Thanks for your contribution.
I will review this as soon as possible.


Launcher startup/shutdown log events.

shutdown hook creates a log message
startup creates a log message

unexpected system outage creates a log message on the logging node when no heartbeat is received for a set period of time.

Add an unregister handler to detect dropped nodes instead of adding a new heartbeat?

Works as expected already.


Update GitHooks

Pull Request
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

#188  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 11, 7:03 AM EDT: A user merged this pull request with Graphite.


Response Headers

Even though the documentation says that any headers sent to front door from the backend are passed through to the client, we encountered an issue where response headers from the backend that had an X-AS- prefix were not being passed to the client by front door. We've since worked around the issue but it would be useful to know if that is a bug or intentional behavior.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c44a91d-f0a9-99cb-1ba6-a4a0918c1b8f
Version Independent ID: 3c43384c-6fce-25b0-eabb-49ba7667034b
Content: Protocol support for HTTP headers in Azure Front Door
Content Source: articles/frontdoor/front-door-http-headers-protocol.md
Service: frontdoor
GitHub Login: @duongau
Microsoft Alias: duau

@bfrasertech, Thanks for reaching out. We will investigate and update this thread.

@bfrasertech, Appreciate your patience. I have tested this in my lab where I can see that X-AS-prefix headers are being added in absence of Front Door.

Also, the same has been mentioned on the doc say, any headers sent to Front Door from the backend are also passed through to the client. The following are headers sent from Front Door to clients.

We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Ident, tabs, and other things =)

Watch out with tabs characters, it's bad :D
Watch out with token, it's not required (there is an option to disable it).
Watch out with sql request in __construct when it must be execute just once :)
Watch out with tabs, must be active :P
Regards :heart:

QA approved :+1:

Thank you @PierreRambaud


Login issue

I've been trying countless different methods, and getting the code and callback, but my application keeps saying "bad request". See below:
# set environment variables
os.environ["SPOTIPY_CLIENT_ID"] = c_id
os.environ["SPOTIPY_CLIENT_SECRET"] = c_secret
os.environ["SPOTIPY_REDIRECT_URI"] = callback_uri
token = util.prompt_for_user_token(username, scope)
and the output:
Opening https://accounts.spotify.com/...output_omitted...
Enter the URL you were redirected to: http://localhost:8888/...output_omitted...
Traceback (most recent call last):
File "./HotUnity.py", line 24, in
token = util.prompt_for_user_token(username, scope)
File "build/bdist.macosx-10.11-intel/egg/spotipy/util.py", line 86, in prompt_for_user_token
File "build/bdist.macosx-10.11-intel/egg/spotipy/oauth2.py", line 210, in get_access_token
spotipy.oauth2.SpotifyOauthError: Bad Request

I was also just having this problem and in my case I discovered after some inspection that my callback url had a "#" at the end followed by "=".  When pasting the callback url into the console I omitted that portion of the url and it worked!  Spotipy needs to be able to properly parse out the code from the callback url

Yes check the redirect_uri is correct


printed errors while piping data will errantly colorize error messages

Errors printed are the same color as the previously printed sysline.
Reproduction
Given some syslog file with multiple syslines, run
$ s4 /var/log/syslog | head -n1

Prints
Aug  7 00:00:00 ubuntu22-s4b systemd[1]: logrotate.service: Deactivated successfully.
ERROR: failed to print Broken pipe (os error 32)

The first line is colorized, which is expected.  However, the line ERROR: failed to print Broken pipe (os error 32) is also colorized.  It should be printed with the default text settings.
This was run in bash shell within Windows Terminal.
More...
The reason is the shell escape codes to return to default text settings occur after the newline.  This escape code to default text settings is written to the pipe | and then head drops that default text escape code. So the terminal does not see the default text escape code. Thus, proceeding lines retain the same colorization settings as the prior sysline.
This relates to a larger problem that user-facing errors are currently handled in a generic way eprintln!. However, user-facing errors should have awareness of TermColor settings, and handle their own colorization.  This Issue may require significant refactoring, depending upon the completeness of the solution.

This also occurs when using grep with colorizing.
Given grep command
$ grep -R /var/log/apt -Fe 'unpack'

will colorize the string "unpack" in output
...
Preparing to unpack .../gnupg2_2.2.27-3ubuntu2.1_all.deb ...
Preparing to unpack .../libapt-pkg6.0_2.4.6_amd64.deb ...
...

And running only s4
s4 -wn /var/log/apt/

results in
...
term.log.2.gz   :Preparing to unpack .../gnupg2_2.2.27-3ubuntu2.1_all.deb ...
term.log.2.gz   :Preparing to unpack .../libapt-pkg6.0_2.4.6_amd64.deb ...
...

But piping s4 output to grep
$ s4 -wn /var/log/apt/ | grep -Fe 'unpack'

s4 will colorize the printed data. grep colorize the substring "unpack", but grep does not return to the preceding color after the "unpack" substring, so s4 colorizing is interrupted
term.log.2.gz   :Preparing to unpack .../gnupg2_2.2.27-3ubuntu2.1_all.deb ...
term.log.2.gz   :Preparing to unpack .../libapt-pkg6.0_2.4.6_amd64.deb ...

Noticed while posting this SO Answer,

A likely fix for this is to have all error messages print using TermColor. Currently, only some prints use TermColor.


Any plan to add new hardware wallet?

Hey TronLink Team,
Aaron here from the Keystone crew. We're all about creating cutting-edge open-source hardware wallets over at Keystone. You can check out our site for more info if you’d like. Just wanted to ask if you have any plans for adding new hardware wallet support? We've got a bunch of Keystone users who are eager for a TronLink integration. Let me know what you think!
Best,
Aaron

Hi. Thanks for reaching out. As discussed, we will evaluate more hardware wallet to be supported at next FY planning.


The width of the navigation bar does not extend throughout the page

Expected Result
The navigation bar extends throughout the screen
Actual Result

The issue is now resolved


question: how to import/export all cookies from browser?

I'm aware that Selenium only exports cookies for the current website. In the past, I've used workarounds like patching Chrome driver to get cookies for all websites or installing a Chrome extension to export/import all cookies. I also know that another way to do this is to parse cookies from the file in the browser profile directly, but I haven't tested it yet.
In the context of using tools like your library or BAS, exporting and importing cookies is a crucial feature.
If you decide to implement exporting and importing cookies with this library or any other tool, it's important to consider the BAS format for exporting cookies to ensure cross-compatibility between this library and BAS. Using a standardized format like JSON for exporting and importing cookies can also help ensure compatibility between different tools and libraries.
// Import dependencies:
require('chromedriver');
const {plugin} = require('selenium-with-fingerprints');
const fs = require('fs');
const {promisify} = require('util');
const writeFileAsync = promisify(fs.writeFile);

async function navigateAndSaveCookies(driver,url,filename) {
    // Navigate to the website:
    await driver.get(url);

    // Wait for the page to load:
    await driver.wait(async () => {
        const pageState = await driver.executeScript('return document.readyState');
        return pageState === 'complete';
    }, 5000);

    // Read cookies and write to file.
   //  =======>>>>>>>>> Cookies are saved only for the currently opened website. <<<<<<<<=====
    const cookies = await driver.manage().getCookies();
    await writeFileAsync(filename, JSON.stringify(cookies, null, 2));
}

// Main function:
(async () => {

    // Get a fingerprint from the server:
    const fingerprint = await plugin.fetch('', {
        tags: ['Microsoft Windows', 'Chrome'],
    });

    // Apply fingerprint:
    plugin.useFingerprint(fingerprint);

    // Launch the browser instance:
    const driver = await plugin.launch();

    // Maximize the window:
    await driver.manage().window().maximize();

    await navigateAndSaveCookies(driver,'https://www.google.com/webhp?hl=en','cookies_google.json')
    await navigateAndSaveCookies(driver,'https://yandex.com/','cookies_yandex.json')

    // Quit the browser:
    await driver.quit();
})();

You can try using CDP to get all cookies, for example with Storage.getCookies or Network.getCookies methods.
Exporting and importing cookies is not the responsibility of plugins, as well as implementing the logic for their compatibility with BAS. I think users should do it on their side.

I recommend not using spawn, given that the plugin has a ready-made method for launching the browser. It's more suitable for cases where you need to migrate code, or for other frameworks - plus, you will need to manually call the chrome.configure() method after opening each page.
There are ready-made methods in selenium for working with CDP, I gave you the links above.
Your cookie retrieval method could be rewritten like this:
async function getAllCookies(driver) {
  const { cookies } = await driver.sendAndGetDevToolsCommand('Storage.getCookies');
  console.log('All cookies:', JSON.stringify(cookies, null, 2));
  return cookies;
}

Or even shorter:
async function getAllCookies(driver) {
  return await driver.sendAndGetDevToolsCommand('Storage.getCookies').then(({ cookies }) => cookies);
}

Regarding the example of saving cookies - a bit later i'll add for all frameworks, thanks.

Yes, of course, i'll mention this ticket in the commit.

Didn't notice it right away, thanks.


Fix non-thread-safe use of Random in MultipartFormDataBinaryContent

MultipartFormDataBinaryContent has a static Random instance that's being used without a lock. This locks around each access (an alternative would be to use and lazily-initialize on each access a [ThreadStatic] Random).
While fixing that, also improved a few things:

We don't need to create a char[] for the boundary values; the const string can be used directly.
For netstandard2.0, we don't need to allocate a char[]; a stackalloc'd span can be used directly.
For .NET, we don't need a stackalloc, either; we can use string.Create and write directly into the new string instance.
For .NET, we don't need a dedicated Random instance, either; we can use Random.Shared.
For .NET, Random allows writing into a byte span, so we don't need the byte[] allocation either and can stackalloc it.
For .NET, just %'ing by the string length produces as good or better code than using a manually-computed mask.

cc: @annelo-msft


Use the correct library name for rocclr

This needs to go to internal development branch. Please resubmit there. Closing this PR.

@mangupta Which branch do I submit a PR to? And why did you close this instead of just changing the base branch?

@pfultz2 these changes are already in https://github.com/ROCm-Developer-Tools/HIP/blob/roc-3.5.x/CMakeLists.txt.

That branch doesn't build. I get this error when configuring:
CMake Error at tests/hit/HIT.cmake:374 (add_custom_target):
  add_custom_target cannot create target "directed_tests.gcc.hipMalloc"
  because another target with the same name already exists.  The existing
  target is a custom target created in source directory
  "/usr/local/cget/build/tmp-318339e40b0a49c99fb316685aea07e1/HIP-roc-3.5.x".
  See documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  tests/hit/HIT.cmake:452 (hit_add_files)
  tests/hit/HIT.cmake:457 (hit_add_directory_recursive)
  CMakeLists.txt:660 (hit_add_directory_recursive)

It seems like something is wrong with the configuring the tests.

That branch doesn't build. I get this error when configuring:
CMake Error at tests/hit/HIT.cmake:374 (add_custom_target):
  add_custom_target cannot create target "directed_tests.gcc.hipMalloc"
  because another target with the same name already exists.  The existing
  target is a custom target created in source directory
  "/usr/local/cget/build/tmp-318339e40b0a49c99fb316685aea07e1/HIP-roc-3.5.x".
  See documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  tests/hit/HIT.cmake:452 (hit_add_files)
  tests/hit/HIT.cmake:457 (hit_add_directory_recursive)
  CMakeLists.txt:660 (hit_add_directory_recursive)

It seems like something is wrong with the configuring the tests.

Are instructions available at https://github.com/ROCm-Developer-Tools/HIP/issues/2104#issuecomment-643435845 not working for you ?

Are instructions available at #2104 (comment) not working for you ?

I am installing it with cget install<EMAIL_ADDRESS>-DHIP_PLATFORM=vdi -DHIP_COMPILER=clang(hcc-based version work with cget), which uses standard cmake commands(ie cmake -DCMAKE_PREFIX_PATH=$PREFIX ..;make;make install) to install. If hip doesn't work with standard cmake commands then the build scripts should be fixed.
I dont pass in the build directory to rocclr since the build directory has already been deleted(if files are needed by downstream components then they should be installed). Also, cget takes care of setting the CMAKE_PREFIX_PATH so custom variables like ROCclr_DIR should not be necessary.
We need to be able to build hip using standard cmake(via cget or CMakeGet) so we can can move our CI to test with hip-clang instead of hcc. With this PR and this one in rocclr, we can build hip-clang, although with some workarounds for the broken installation of opencl headers(hopefully this can be fixed in the future as well).

@pfultz2 The master branch was used for hip-hcc runtime development. Whereas the new runtime is developed in the internal branch. Hence master branch should be treated as deprecated. As of now only the release branch is pushed to github (after the release is done). So if this change is needed, it needs to go to the internal branch.


Add video tutorial on how to compile firmware.

[Issue created by DocMoebiuz: 2019-09-08]
[Last updated on bitbucket: 2020-08-18]

Looking through older issues and this can probably get resolved when #461 is done. The PlatformIO version has a readme that explains how to compile the firmware and it's simplified enough that a video probably isn't necessary anymore. All it takes is VSCode + the PlatformIO extension.


fix: make pluginOptions work as documented

I'm not understanding what this is fixing. Can you elaborate?

Current documentation states following way to define options:
module.exports = {
  plugins: [
    {
      plugin: CracoLinariaPlugin,
      options: {
        // Linaria options
      },
    },
  ],
}

But this doesn't works since current version tries to get config property of pluginOptions. Which is obviously undefined in this case.

OK sorry, but I'm really struggling to understand the root issue here. Are you suggesting that (undefined || undefined || {}).config || {} doesn't work in that it throws an error or something? What is the scenario in which this breaks? What is the expected result here and how does moving the ( help? I'm not seeing how.

({ someLinariaOption: true } || undefined || {}).config || {} // {}

{ someLinariaOption: true } || (undefined || {}).config || {} // {} // { someLinariaOption: true }

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support for docstrings in scenario outlines

Figured I might as well just create the pull request, I can always squash the commits later.
I've added what I hope is a solution to using Docstrings with Scenario Outlines as described in #7 and #79. The implementation is concentrated to src/parsed-feature-loading.ts I also added a couple of examples for TypeScript and ECMAScript to illustrate the new functionality (it was previously not possible to use Docstrings and Scenario Outlines together).
Have a look and ping me if there are any concerns.

@SirSkorpan - thanks for contributing this fix! I commented on a couple of small tweaks, but it looks good otherwise. Once those issues are resolved, I can merge and publish.
I will be publishing this in a beta package for now instead of in the mainline because I've been a bad maintainer the last several months, and master still has some beta functionality in it from a while back (#27).

@bencompton I added a few tests for using repeating 's in steps, docstrings and gherkin tables. Hopefully you feel that those belong in this PR as well. As I was adding regex in the replace method for my new code I figured I might as well use it in the old code as well to add support not just to docstrings.
Also added some information to the docs about placeholders in scenario outlines as well as docstrings. Have a look an get back to me if you feel something is missing or doesn't belong in this PR.

@SirSkorpan - Thanks for fixing the replacement in both places, and also adding additional examples! Your changes are now merged and published to v2.0.13 (tagged as "next").


ARROW-6957: [CI][Crossbow] Nightly R with sanitizers build fails installing dependencies

@ursabot crossbow submit test-ubuntu-18.04-r-sanitizer

I canceled the appveyor job to unclog the queue; this patch does not affect appveyor.

@ursabot crossbow submit test-ubuntu-18.04-r-sanitizer

@ursabot crossbow submit test-ubuntu-18.04-r-sanitizer

Crossbow is green: https://circleci.com/gh/ursa-labs/crossbow/5778
Merging.


Scroll to index

It would be really nice if there was a method on the adapter to scroll to a particular index.

Are you talking about something like this?

I did something like this by changing an offset I'm keeping track of and incrementing the revision:
https://github.com/Tsarpf/Tsatter/blob/master/nodeapp/environment/public/js/services/infiniteMessages.js#L247
The code is bit of a mess, sorry for that. But basically it resets it to call getAroundLink with the offset set to obj.linkOffset.

Those examples work great. Implementing as such :+1:


⚠ Bofrost.at has degraded performance

In 9a34eb9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1932 ms

Resolved: Bofrost.at performance has improved in 694d55d.


Bug: Linux chromium screenshot: unable to locate page area

npx testcafe -s screens -S chromium tests
  Was unable to take a screenshot due to an error.

  Error: Unable to locate the page area in the browser window screenshot at
  .../screens/2018-05-18_09-27-20/test-1/Chrome_66.0.3359_Linux_0.0.0/errors/1.png, because the page area mark with ID<PHONE_NUMBER> is not found in
  the screenshot.
      at _callee$ (.../node_modules/testcafe/lib/screenshots/crop.js:95:31)
      at tryCatch (.../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (.../node_modules/regenerator-runtime/runtime.js:296:22)
      at Generator.prototype.(anonymous function) [as next] (.../node_modules/regenerator-runtime/runtime.js:114:21)
      at step (.../node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
      at .../node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
      at run (.../node_modules/core-js/library/modules/es6.promise.js:75:22)
      at .../node_modules/core-js/library/modules/es6.promise.js:92:30
      at flush (.../node_modules/core-js/library/modules/_microtask.js:18:9)
      at process._tickCallback (internal/process/next_tick.js:172:11)

// test.js
import { Selector } from 'testcafe';
fixture('t1').page('https://google.com');
test('My first test', async t => {
  await t.expect(Selector('not-exists').exists).ok();
});

operating system: ArchLinux, KDE, Chromium 66.0.3359
testcafe version: 0.20.0
node.js version: v10.0.0

Could you please provide me the screenshot file that caused this warning?

Hi @psi-4ward! Unfortunately, I can't reproduce the issue on my machine. I would try to figure out what's wrong with screenshots if you could provide me a remote session (trough VNC, TeamViewer, etc.). Also, I'm working on the screenshots code to enable capturing images through browsers' debug protocols. It must fix the issue, but I can't say it for sure without reproducing the issue. I'll notify you when a debug build is available.

Hi @amits1995. this functionality is implemented in https://github.com/DevExpress/testcafe/commit/2a748edbc31c98577d8ea3c89dd4c32e9a19b11a. I think we will release an alpha build next week.

Try the 0.20.4 version and feel free to reopen issue if problem still persists.

I'm having the same issue with IE11 on 0.20.4
  Error: Unable to locate the page area in the browser window screenshot at
  xxx\2018-07-02_06-28-29\test-2\IE_11.0.0_Windows_7.0.0\1.png,
  because the page area mark with ID<PHONE_NUMBER> is not found in the screenshot.
      at detectClippingArea
```

Could you please share the screenshot with me?

and today I cannot reproduce it :/ though yesterday it was almost 100% like this...


Restore to working order

This PR fixes the action to work again.
Basically it's a workaround for a bug in nixpkgs impure.nix, where isDir works for strings, but not for paths, and something changed, so that pypi-deps-db's py36 overlay is now being understood as a path, and had to be a directory.

Thanks, please remove the last commit which updates the data.

Of course. I had hoped we could save on the computation, but it does make the PR very unwieldy and appears to break the diff UI here on Github.

This fixes #23.


Use OlpClientSettings from the core.

Changes imports to use OlpClientSettings from the olp-sdk-core
in the olp-sdk-dataservice-read.
Updates for some tests.
Resolves: OLPEDGE-1940
Signed-off-by: Oleksii Zubko<EMAIL_ADDRESS>

Codecov Report

Merging #313 into master will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #313     +/-   ##
========================================
- Coverage    87.6%   87.6%   -0.1%
========================================
  Files          55      56      +1
  Lines        1551    1559      +8
  Branches      183     183
========================================
+ Hits         1359    1365      +6
- Misses        119     121      +2
  Partials       73      73

Impacted Files
Coverage Δ

@here/olp-sdk-dataservice-read/lib/HRN.ts
100.0% <ø> (ø)

...aservice-read/lib/cache/MetadataCacheRepository.ts
100.0% <ø> (ø)

...ataservice-read/lib/client/LayerVersionsRequest.ts
100.0% <ø> (ø)

@here/olp-sdk-core/lib/utils/FetchOptions.ts
100.0% <100.0%> (ø)

...-sdk-dataservice-read/lib/client/ArtifactClient.ts
91.7% <100.0%> (ø)

...p-sdk-dataservice-read/lib/client/CatalogClient.ts
75.5% <100.0%> (+0.5%)
:arrow_up:

...lp-sdk-dataservice-read/lib/client/ConfigClient.ts
85.7% <100.0%> (ø)

...olp-sdk-dataservice-read/lib/client/DataRequest.ts
90.9% <100.0%> (+0.4%)
:arrow_up:

...lp-sdk-dataservice-read/lib/client/FetchOptions.ts
100.0% <100.0%> (ø)

...dk-dataservice-read/lib/client/IndexLayerClient.ts
93.3% <100.0%> (+0.2%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63dd0ae...b94a995. Read the comment docs.


[build-script] Don't clobber PKG_CONFIG_PATH

Overwriting this variable can cause the build to break when pkg-config tries to find packages that aren't ICU. Prepending the ICU path so it takes precedence is a less fragile solution.
My builds failed when building Swift on CentOS until I tried this patch.

@swift-ci please test and merge


New solariumphp/solarium version (3.5.0) related issue

Hi,
New SolariumPHP version (3.5.0) has been released on 2015-12-09 and it changed the class name of the abstract Plugin class :
Solarium\Core\Plugin\Plugin => Solarium\Core\Plugin\AbstractPlugin
Since the solarium/solarium requirement in composer.json is "~3.3", the new 3.5.0 is retrieved and the Logger plugin (Nelmio\ SolariumBundle\Logger) tries to extends the abstract Plugin with the "old" name, which results in an error.
For now, as a workaround, we forced the version of solarium/solarium with 3.4.1 in our application composer.json.

same problem here, same solution for now, waiting for fix!

+1 #sfCon2015 ;)

See PullRequest: https://github.com/nelmio/NelmioSolariumBundle/pull/56

Please use composer require solarium/solarium:3.4.1 as a workaround for now. This is not something we should fix here, as if I merge #56 it will just mean that the bundle isn't compatible with solarium versions 3.3/3.4 anymore. See https://github.com/solariumphp/solarium/issues/382 for an issue on solarium asking for them to fix their BC break (which I guess wasn't intentional..).

same here, i will do the 3.4.1 require

Hello,
I tried "composer require solarium/solarium:3.4.1" also tried to change the composer.json manually, but It still fails.
The error was
"The requested package nelmio/solarium-bundle could not be found in any version, there may be a typo in the package name."

Conposer must require solarium and the nelmioSolariumBundle. Then remove the old solarium package from the vendors directory and reinstall it by composer install or update

3.5.1 fixed it


Accept lambda/proc in security definitions for relative urls

For example:
        security_definitions: {
          ResourceOwner: {
            type: 'oauth2',
            description: 'OAuth 2 with the password grant flow',
            flow: 'password',
            tokenUrl: -> {|request| "#{request.host}/api/v1/oauth/token"}
          }
        }

When using Swagger UI, it can allow a relative URL, but it really needs an absolute URL to point to the same server that enables authorizations.

looks like a bug, please feel free to commit


File picker, SPFx and permissions

Hi,
I try to use File picker V8 with SPFX, it's working but permissions as strange behavior.
I have created a sample : https://github.com/rgcircum/spfx-sp-filepicker-sample
I have based the SPFx sample with the sample by @patrick-rodgers (thanks)
The idea is to be able to use the filePicker without declaring an AAD application
i'm get Token by AadTokenProviderFactory
public async getToken(command: IAuthenticateCommand): Promise<string> {
    const _aadTokenProvider = await this._aadTokenProviderFactory.getTokenProvider();
    const _authToken = await _aadTokenProvider.getToken(command.resource);
    return _authToken;
}

If i'm use the permissions :
{
  "resource": "Microsoft Graph",
  "scope": "Files.ReadWrite.All"
},
{
  "resource": "Microsoft Graph",
  "scope": "Sites.ReadWrite.All"
},
{
  "resource": "Microsoft Graph",
  "scope": "AllSites.Write"
},
{
  "resource": "Microsoft Graph",
  "scope": "MyFiles.Write"
},

This not work, i have this error :
ServerError: AADSTS500011: The resource principal named https://***/sites/Test was not found in the tenant named ***. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You might have sent your authentication request to the wrong tenant.

If i add the permission :
{
  "resource": "Windows Azure Active Directory",
  "scope": "User.Read"
},

The WebPart work!!! but only in SharePoint, on Teams tab, I have always AADSTS500011 error.
For Teams tab, i have tested this permissions :
{
  "resource": "Microsoft Graph",
  "scope": "ChannelSettings.ReadWrite.All"
},

But, i have the same error.
Another problems, the documentation explains that i can use *.read permissions, but that doesn't work. I thought it could work without the upload functionality, but not. it's a problem, the write permissions is to large (ex : AllSites.Write), lot of client do not accept this permissions for security purpose.

I have no answer, Issue reposted on sp-dev-docs repos :
https://github.com/SharePoint/sp-dev-docs/issues/9503

I am trying something similar, but I only get blank white pages, no error's in the console or blocked network requests. I then downloaded your sample (@rgcircum) but still see only blank pages - is this an indication, that I have the permissions set up incorrect? I tried it in multiple ways (with own app, without, ...) but I have never seen anything but a blank screen.

If you valid Graph authorization, it's works, but with bug's have that I brought up.

Correct authorization (working for me) :
{   "resource": "Microsoft Graph",   "scope": "Files.ReadWrite.All" }, {   "resource": "Microsoft Graph",   "scope": "Sites.ReadWrite.All" }, {   "resource": "Microsoft Graph",   "scope": "AllSites.Write" }, {   "resource": "Microsoft Graph",   "scope": "MyFiles.Write" }, {   "resource": "Windows Azure Active Directory",   "scope": "User.Read" },

@rgcircum thanks for your correct authorization. Today I got it working as well! I do not know why it did not work last week - i have not changed anything on the privileges side. Thanks for your help!! But I agree with your comment, some permissions are very large and we will not get them from many clients too.

@JCrew0 you have (enventualy good) news for this ?


java.lang.RuntimeException: java.lang.NoSuchMethodException: setProgress [int, boolean]

Apparently it doesn't work in android 5 or lower

https://github.com/frmdstryr/enaml-native/commit/e6f73530a0e797d5ae8f031d9cc2ecfd076f4868


Investigate Property Coverage Analysis

in particular http://hackage.haskell.org/package/tasty-hedgehog-coverage-<IP_ADDRESS>/docs/Test-Tasty-Hedgehog-Coverage.html

Allows to classify generated data via predicates and output percentages, e.g., length of lists greater than n ...
Useful to validate that generated input is not trivial. It would also be possible to classify into validated and non-validated transaction rule applications for example.

first property with classification realized in #65
labelling used in #73


paginateExpandedRows problem ?

Describe the bug
I am using the model getExpandedRowModel and I wanted to display subRows and not to be paginated.
So I setted the paginateExpandedRows to false.
But that is not working :/
Also, in the code I so that comment https://github.com/TanStack/table/blob/d5d5501c5a0b76bda45dcf55f0d466fe7c7f63d2/packages/table-core/src/utils/getExpandedRowModel.ts#L17
          // Do not expand if rows are not included in pagination
          !paginateExpandedRows ||

Why we do not expand the table ? The paginateExpandedRows should be used for pagination only no ?
Your minimal, reproducible example
https://codesandbox.io/s/react-table-paginateexpandedrows-bug-wv3hd2
Steps to reproduce

Go to https://codesandbox.io/s/react-table-paginateexpandedrows-bug-wv3hd2
See that the option paginateExpandedRows is set to false
Try expand the table
Not working :(

Expected behavior
Expand the table (and don't update pagination)
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

Browser: Chrome (and I suppose others)

react-table version
8.3.3
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

I am also facing the same problem :(

No direct fix for this, sorry
I made a PR ( #4263 ), but not sure if it's compatible with others options

@tannerlinsley could u fix this one ?

Working on it
Tanner Linsley
On Aug 4, 2022, 7:51 AM -0600, Dhanush kumar Sivaji @.***>, wrote:

@tannerlinsley could u fix this one ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Fixed!


Update French translations for NPC Map Locations

Thanks for the help! Merged into develop for the upcoming NPC Map Locations 2.10.1.


Yii2 ver 2.0.6 migration setting unsigned integer

Exception 'yii\base\UnknownMethodException' with message 'Calling unknown method: yii\db\ColumnSchemaBuilder::unsigned()'
in /var/www/ivm/vendor/yiisoft/yii2/base/Object.php:220
My code:
public function up() {
	$this->createTable('auditLog', [
		'id' => $this->primaryKey(),
		'model' => $this->string(255)->notNull(),
		'action' => $this->string(255)->notNull(),
		'oldAttributes' => $this->text(),
		'newAttributes' => $this->text(),
		'IPAddress' => $this->string(255),
		'createdAt' => $this->datetime(),
		'updatedAt' => $this->datetime(),
		'createdBy' => $this->integer(10)->unsigned(),
		'updatedBy' => $this->integer(10)->unsigned(),
	]);
}

There's no support for it.

Yet.

Bump for this. we need this

you can just use old syntax to specify and custom type you like. ColumnSchemaBuilder is mostly useful to create schema independed defintions.

@cebe  I dont like old syntax. So i report this error. Please release the new version more faster. I cant w8 for the new syntax. Its soo easy :P

You can use on version < 2.0.7
$this->createTable('{{%ipgeo}}', [
      'from' => $this->integer() . ' UNSIGNED NOT NULL',
      'to' => $this->integer() . ' UNSIGNED NOT NULL'
]);

I know but it looks ugly to me.
Better to use only 1 way. Only OLD WAY or Only NEW WAY.
When will be released -v 2.0.7 ?

My answer not only for you. I had this problem too. I agree about one way but I admit use OLD WAY temporary. Still I use this code (before -v 2.0.7):
$this->createTable('{{%ipgeo}}', [
      'from' => $this->integer() . ' UNSIGNED NOT NULL', //@todo ->notNull()->unsigned(),
      'to' => $this->integer() . ' UNSIGNED NOT NULL', //@todo ->notNull()->unsigned(),
      'vocabulary_id' => $this->integer()->notNull()
]);


small synonym fix GO:0140403

remove
suppression of effector-triggered immunity (PTI) | exact
a) it would be ETI
b) this  term is not specific for either ETI or PTI suppression

OK this should be
suppression of effector-triggered immunity (ETI) | ~exact~ broad
BUT
We we don't  need this synonym, because a term  meaning  exactly this will be created, but that is in another ticket.

@ValWood
I am not following
synonym: "suppression of effector-triggered immunity (ETI)" EXACT []

There is  plant term for  ETI sitgnalling , see https://github.com/geneontology/go-ontology/issues/18733
We don't have a plant term for just "effector-triggered immunity". I don't think it would be appropriate to have such a term from the plant perspective because it is too broad. However, it is the term the pathogen community use most commonly.
Also note that
GO:0140403 is BROADER than just signalling. It refers to the plant  suppressing the immunity during signalling, or in any of the downstream outputs. Often we cannot be more precise than this. We only know that ETI is suppressed.
(@CuzickA is this the case, all of the suppression of ETI have been through the receptor, do we have other examples)?


Update README.md

Updated composer installation instruction with the correct name

Current coverage is 69.42% (diff: 100%)

Merging #75 into 1.0 will not change coverage

@@                1.0        #75   diff @@
==========================================
  Files             2          2
  Lines           121        121
  Methods          12         12
  Messages          0          0
  Branches          0          0
==========================================
  Hits             84         84
  Misses           37         37
  Partials          0          0

Powered by Codecov. Last update f5260fc...7626e9c


💲[Native Checkout] Login & Sign-up on the pledge screen (Part 1)

📲 What
Allows logged out users to log in or sign up before pledging right from the pledge screen.
Does not include

design updates to the login/signup screen, that's coming in Part 2 of this work

🤔 Why
You need to be signed into an account in order to back a project. This feature allows users to log in or sign up from within the pledging flow.
🛠 How
We already had this functionality in the old DeprecatedRewardPledgeViewController, which means the LoginToutViewController is already built to support login/signup from multiple contextual places throughout the app. Adding support for this in our new pledge screen was relatively straightforward since the LoginToutViewController manages it's own dismissal (this is something we should re-evaluate in the future). The PledgeTableViewController listens for userSessionStarted notifications which trigger a table view refresh.
👀 See

♿ Accessibility
No accessibility changes required.
✅ Acceptance criteria

[ ] Logging in from the pledge screen works as expected.
[ ] Signing up for a new account for the pledge screen works as expected.
[ ] Logging in using Facebook works as expected.
[ ] Signing up in using Facebook works as expected.

 [Checkout] Pledge Continue Button Cell - User Interaction


info on CamemBERT preprocessing

Hello,
we are trying to train a new RoBERTa model from scratch following the CamemBERT paper https://arxiv.org/abs/1911.03894.
Currently we have done the following steps:

Downloading our dataset for training RoBERTa
Creating our sentencepiece.bpe.model and sentencepiece.bpe.vocab following RAW_DATA_FPATH = "dataset.txt" MODEL_PREFIX = "tokenizer"  VOC_SIZE = 32000 SUBSAMPLE_SIZE = 12800000  NUM_PLACEHOLDERS =  0 SPM_COMMAND = ("--input={} --model_prefix={} "             "--vocab_size={} --input_sentence_size={} "             "--shuffle_input_sentence=true "             "--model_type=bpe").format(             RAW_DATA_FPATH, MODEL_PREFIX,              VOC_SIZE - NUM_PLACEHOLDERS, SUBSAMPLE_SIZE) spm.SentencePieceTrainer.Train(SPM_COMMAND)
We split the dataset in dataset_train.txt, dataset_val.txt, dataset_test.txt
We encode the previous txt files in the bpe format in order to pass them to roBERTa based on the following snippet:
for SPLIT in train val test; do  cat dataset_${SPLIT}.txt | spm_encode --model=sentencepiece.bpe.model --output_format=piece > dataset_${SPLIT}.bpe done

In order to run correctly the fairseq-preprocessing and then fairseq-train (following https://github.com/pytorch/fairseq/blob/master/examples/roberta/README.pretraining.md ) do we need to add the bos and eos token with the spm_encode parameter --extra_options=bos:eos ?
Thanks in advance.

Fairseq will add these tokens automatically


⚠ Punto de Fuga has degraded performance

In 20e1531, Punto de Fuga (http://puntodefugapodcast.com) experienced degraded performance:

HTTP code: 200
Response time: 8645 ms

Resolved: Punto de Fuga performance has improved in fd0c229.