The asset pick-publish-target.png contains a visual artifact on the top left corner

The asset pick-publish-target.png contains a visual artifact on the top left corner. Looks like a leftover from a copy/paste operation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 449b8ce2-80b3-9bfa-6d7f-3e8ac8a86e16
Version Independent ID: 31264b07-1aeb-b3f0-1126-f25e578f6d50
Content: Publish your .NET Core Hello World application with Visual Studio - .NET Core
Content Source: docs/core/tutorials/publishing-with-visual-studio.md
Product: dotnet-core
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for reporting that, I'll include a fix with some other changes I'm making in that tutorial now.


stop managing system directories like /run

This is similar to #202, but simpler.
I had to declare the newer Debian versions to exercise the unit tests on them.
(Nevermind these acceptance results on my comp, you have Travis set up - The acceptance tests run successfully on Debian 8 and 9. The puppet agent does not install on Debian 10 nor Ubuntu 18 and I didn't bother to debug it. The tests fail on CentOS 7 because there is no dnsutils package available.)

These look like good changes to me.  Thank you for putting this up for review.

Thanks for the contribution.


[Core] Fix sharing of stateful logits processors

This is related to PR 4109
In vLLM users can submit more than one sequence at the same time with the completion request in the legacy OpenAI API. Since the sampling params are validated only once a single SamplingsParam object is shared between all sequences even when they belong to different sequence groups. The SamplingsParam is mostly a data object, but it has a list of logits processors that are executable. If the logits processors are stateless there is no problem. But there are implementations of logits processors that have internal state that depends on the sequence seen so far.
For example, the  CFGLogitsProcessor would crash with the request below:
curl http://localhost:8000/v1/completions   -H "Content-Type: application/json"   -d '{
    "model": "meta-llama/Llama-2-7b-hf",
    "prompt": ["An example of a json document: ", "Another example of a json document: "],
    "max_tokens": 100,
    "temperature": 0,
    "guided_decoding_backend": "outlines",
    "response_format": {"type":"json_object"},
  }' | jq

resulting in the following error:
  File "/home/vllm/.local/lib/python3.11/site-packages/vllm/model_executor/layers/logits_processor.py", line 57, in forward
    logits = _apply_logits_processors(logits, sampling_metadata)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vllm/.local/lib/python3.11/site-packages/vllm/model_executor/layers/logits_processor.py", line 106, in _apply_logits_processors
    logits_row = logits_processor(token_ids, logits_row)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vllm/.local/lib/python3.11/site-packages/vllm/model_executor/guided_decoding/outlines_logits_processors.py", line 50, in __call__
    self.fsm_state[seq_id] = self.fsm.next_state(
                             ^^^^^^^^^^^^^^^^^^^^
  File "/opt/vllm/lib/python3.11/site-packages/outlines/fsm/fsm.py", line 364, in next_state
    return self.regex_fsm_last.next_state(state, token_id)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/vllm/lib/python3.11/site-packages/outlines/fsm/fsm.py", line 178, in next_state
    last_token_to_end_state = self.states_to_token_maps[state]
                              ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
KeyError: 6

PR 4109 solves the crashing behavior, but the output is still affected by the sharing problem.
The additional solution proposed here is based on adding factories for stateful logits processors. The basic idea is:

We add processors and factories to the same list so that they are in the correct order
We add a logits_processors list to the SequenceGroupState object
When the SequenceGroup is created, we iterate over the sampling_params.logits_processors
and copy the logits_processors and call the factories to populate SequenceData.logits_processors
The LogitsProcessor(nn.Module) will iterate over the SequenceData.logits_processors instead of
the sampling_params.logits_processors

Here are some diagrams to illustrate the current code structure to better visualize the proposed changes:

There are two scenarios that need further investigation:

Sequences that are preempted with the recompute policy: possibly the state needs to be reset.
Forking of sequences during beam search: would a deep copy of the processor be feasible?

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Thanks @maxdebayser! You need to run format.sh to fix the linting, and it looks like there's some tests that need updating.

@br3no I have a couple of questions:

Is it possible / relatively cheap to clone a Guide that has been built based on particular parameters before it is used, so that each copy may be used independently by concurrent sequences?
Irrespective of the answer to (1), can one of these Guide instances be reset/reused for a separate sequence (sharing the same params) once it has finished being used for a first one?

Unless (1) is possible and very cheap, the best option would be to extend this PR to support pooling and make use of (2), assuming that (2) is possible. This library looks like exactly what we'd need for that: https://pypi.org/project/pondpond/, in conjunction with finding the right place to hook the sequence completion event (possibly Sequence destructor).

@njhill

Is it possible / relatively cheap to clone a Guide that has been built based on particular parameters before it is used, so that each copy may be used independently by concurrent sequences?

I haven't benchmarked anything, but the code suggests that copying the CFGGuide is currently as expensive as creating it from scratch. This is in line with my impression while working on it.
Which doesn't mean it wouldn't be possible to improve this in Outlines in principle.
There is no support for resetting the CFGGuide in Outlines currently. So (2) is most probably also a negative.
I believe to improve this situation, we need to work with the Outlines community.
NOTE This problem only applies to the CFGGuide. The other Guides are stateless.

Thanks @br3no, so CFGGuide is used for json mode but these currently can't be reused. Yes I think this will be important to fix (in outlines it sounds like).

Forking of sequences during beam search: would a deep copy of the processor be feasible?

Sounds like there should be a replay of the FSM, at the very least; there should be a parameter passed for how logit_processor that is essentially autoregressive can recover the state from full list of tokens.
Just some more plumbing required to ensure that when you call method clone_with_history or something, it does the replay instead of just pulling the last token_id
https://github.com/vllm-project/vllm/blob/5923532e15b12832febe91ef5e9a4cef2786cefc/vllm/model_executor/guided_decoding/outlines_logits_processors.py#L44

I've synced the branch with main and all the unit tests that are touched by this PR work, but guided decoding in main currently seems to be broken: https://github.com/vllm-project/vllm/issues/7557


Style the API documentation

Right now it is the bare monodoc export output, the docs/template could use some work

We use something else now


Deprecation warnings when starting hypergan

WARNING:tensorflow:From /home/martyn/dev/hypergan/hypergan/gan.py:87 in load_or_
initialize_graph.: initialize_all_variables (from tensorflow.python.ops.variable
s) is deprecated and will be removed after 2017-03-02.

Fixed in 0.8


doubt: Any way to force exclusive fullscreen ?

Hi,
Is there any way to force exclusive fullscreen through dxvk settings ? I have some titles that don't allow the user to change the window mode through their interfaces, configuration files or parameters.
Regards

On Windows we already use the exclusive fullscreen hint if available. On Linux, the concept doesn't really exist.

Thanks for the explanation regarding fullscreen on Linux.
Regards


aws-c-event-stream: 0.3.2 -> 0.4.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/aws-c-event-stream/versions.
meta.description for aws-c-event-stream is: C99 implementation of the vnd.amazon.eventstream content-type
meta.homepage for aws-c-event-stream is: https://github.com/awslabs/aws-c-event-stream
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.1 in filename of file in /nix/store/925262fppfs94yzbqhcsnisnhq2nxvbz-aws-c-event-stream-0.4.1

Rebuild report (if merged into master) (click to expand)

733 total rebuild path(s)

733 package rebuild(s)

First fifty rebuilds by attrpath
activitywatch
adafruit-nrfutil
akkoma-frontends.admin-fe
akkoma-frontends.akkoma-fe
alice-lg
anki
ansible-language-server
antennas
antora
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
appvm
archivebox
ariang
arrow-cpp
arrow-glib
arrpc
assemblyscript
audiobookshelf
authelia
authy
aw-server-rust
aws-azure-login
aws-c-event-stream
aws-crt-cpp
aws-sdk-cpp
balanceofsatoshis
balena-cli
behave
bibtex-tidy
bilibili
bitwarden
bitwarden-cli
bitwarden-directory-connector-cli
botamusique
browsr
bruno
btc-rpc-explorer
bundix
cabal2nix
cached-nix-shell
cachix
camunda-modeler
carbon-now-cli
carto
castnow
cdxgen
ceph
ceph-client
ceph-csi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/925262fppfs94yzbqhcsnisnhq2nxvbz-aws-c-event-stream-0.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A aws-c-event-stream https://github.com/r-ryantm/nixpkgs/archive/7870a502150a5a18a49f92b7bd14c7767ec47fa1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7870a502150a5a18a49f92b7bd14c7767ec47fa1#aws-c-event-stream

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/925262fppfs94yzbqhcsnisnhq2nxvbz-aws-c-event-stream-0.4.1
ls -la /nix/store/925262fppfs94yzbqhcsnisnhq2nxvbz-aws-c-event-stream-0.4.1/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @orivej @edolstra for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/aws-c-event-stream/versions.
meta.description for aws-c-event-stream is: C99 implementation of the vnd.amazon.eventstream content-type
meta.homepage for aws-c-event-stream is: https://github.com/awslabs/aws-c-event-stream
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.2 in filename of file in /nix/store/43nmzhs2dj5wp5j27b0zwkdvrzv7i9lb-aws-c-event-stream-0.4.2

Rebuild report (if merged into master) (click to expand)

764 total rebuild path(s)

764 package rebuild(s)

First fifty rebuilds by attrpath
activitywatch
adafruit-nrfutil
akkoma-frontends.admin-fe
akkoma-frontends.akkoma-fe
alice-lg
anki
ansible-language-server
antennas
antora
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
appvm
archivebox
ariang
arrow-cpp
arrow-glib
arrpc
assemblyscript
audiobookshelf
authelia
authentik
authy
aw-server-rust
aws-azure-login
aws-c-event-stream
aws-crt-cpp
aws-sdk-cpp
balanceofsatoshis
balena-cli
behave
bibtex-tidy
bilibili
bitwarden
bitwarden-cli
bitwarden-directory-connector
bitwarden-directory-connector-cli
botamusique
browsr
bruno
btc-rpc-explorer
bundix
cabal2nix
cached-nix-shell
cachix
camunda-modeler
carbon-now-cli
carto
castnow
cdxgen
ceph

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/43nmzhs2dj5wp5j27b0zwkdvrzv7i9lb-aws-c-event-stream-0.4.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A aws-c-event-stream https://github.com/r-ryantm/nixpkgs/archive/dd0f75110c934393465a5fab0c33e35ab82782e6.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/dd0f75110c934393465a5fab0c33e35ab82782e6#aws-c-event-stream

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/43nmzhs2dj5wp5j27b0zwkdvrzv7i9lb-aws-c-event-stream-0.4.2
ls -la /nix/store/43nmzhs2dj5wp5j27b0zwkdvrzv7i9lb-aws-c-event-stream-0.4.2/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @orivej @edolstra for testing.

Addressed by https://github.com/NixOS/nixpkgs/pull/299898


Attempting to fix torch leak.

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil So it seems like theres multiple causal_lm files so you would need it to all of them not just the one I mentioned. So any file that ends with causal_lm needs this change as it includes the if stopped: function. Let me know if i need to be more clear


SSLExtractor

Previously, the self-supervised learning models that are not included in the Vissl library were added as custom models. This leads to confusion and makes it harder for the user to discover these models. This PR renames the VisslExtractor to SSLExtractor with source ssl and depending on the model, loads it either from the Vissl library or the torch hub. This more generic source also allows easier addition of future SSL models which are not included in Vissl.
Changes:

Renamed VisslExtractor to SSLExtractor with source ssl
Added barlowtwins-rn50, vicreg-rn50 to the SSLExtractor and removed them from custom models
Added documentation + tests

Codecov Report
Base: 79.02% // Head: 79.46% // Increases project coverage by +0.43% :tada:

Coverage data is based on head (a0737e7) compared to base (40459ca).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   79.02%   79.46%   +0.43%
==========================================
  Files          25       22       -3
  Lines        1111     1086      -25
  Branches      160      162       +2
==========================================
- Hits          878      863      -15
+ Misses        192      181      -11
- Partials       41       42       +1

Flag
Coverage Δ

unittests
79.46% <75.00%> (+0.43%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

thingsvision/core/extraction/helpers.py
73.11% <66.66%> (ø)

thingsvision/core/extraction/extractor.py
78.99% <76.19%> (-0.84%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Nice, looks great! Maybe we could we make it backward compatible, i.e. still allowing vissl as a source when using get_extractor but printing out a deprecation warning?

@andropar Good Idea, I implemented it in the latest commit.


BlackBerry is spelled incorrectly

It's BlackBerry, not Blackberry

I actually plan on removing BlackBerry altogether some time soon so...probably won't bother.

BlackBerry was removed from the site some time last year (and no one seemed to notice), so closing this issue.


Please add snyk.io Badge

Api Doc: https://snyk.docs.apiary.io/#

We have a nice tutorial! If anyone would like to give it a go, please do!

Might be extra good to implement this, now that nsp is gone: #2529.

Oh. The API docs say it's for paid plans. Hmm.

I briefly looked at this one not too long ago and saw the same limitations about the API. I got as far as wondering the BaseSvgScraper could be used with the badges snyk provides directly: https://snyk.io/docs/badges but then got side tracked :)

Ah, that's probably a good way to do it.

I'm going to see if I can get the core snyk vulnerability badges added using this approach
🤞

It's working. I've finished adding support for GitHub repos/manifests, working on npm packages now


styles for new company designs

Changes description
Adjusted styles to match new company designs -> Colors, Logo etc.

Thanks for taking care of updating this!
All looks good. My only optional suggestion: I see you've added button examples to show off the new secondary and tertiary colors. Do you think it would make sense to present those new colors near the top of the page as well, next to where primary color is first introduced? See:


Feature Request: Email notifications for YI-Hack cameras - Integration of script "WalkingDot / yihmail" into Allwinner 2

I accidently found the following script https://github.com/WalkingDot/yihmail which offers the posibility to send email notifications when a motion event is detected.
Wouldn't this be a nice feature being integrated as standard in the Allwinner 2 firmware?

We would need Yihmail + ipc_multiplexer to get it running. Some file restoring from previous releases will be necessary.
If this will be included I can try to contribute the corresponding web interface for configuration inputs.

ipc_multiplexer is no longer present in the current hack version.
The stragedy is changed and the source code of yihmail should be updated.
You should try to ask to WalkingDot.
Sorry but I don't know go language.


Filter for campus partner

Client wants a chain dropdown of college and department. If a user selects a college, only departments associated with that college will be shown in the dropdown. If no college is selected, you can see all departments in dropdown. College and department both filter.

Doesn't update count.

Doesn't update count. Seems to have same results for both academic years.

The new develop should have this

@TarekRamesses


Static analysis warning

Realm/ObjectStore/src/impl/transact_log_handler.cpp:286:9: Called C++ object pointer is null

        context->did_change(m_observers, invalidated);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

That line isn't reachable if context is nullptr, so this is just a false-positive that should be silenced.

Verified that the static analyzer (in Xcode 8.2.1) no longer emits this warning.


Stocator support for temp url

Stocator need to support temp url.
For example, consider the following temp url
https://mil01.objectstorage.softlayer.net/v1/AUTH_8f731319-18c3-4ce8-909f-df78b885df0a/testurl1/data.csv?temp_url_sig=ID&temp_url_expires=1479816450
To access it from Spark:
val d = sc.textFile("swift2d://testurl1.mil01/v1/AUTH_8f731319-18c3-4ce8-909f-df78b885df0a/testurl1/data.csv?temp_url_sig=ID&temp_url_expires=1479816450")
However Stocator will fail during listStatus(..)

@djalova Can you handle it please?

@michaelfactor FYI

Hi Gil,

Sure I can work on this. I just want to make sure that this temporary URL lasts for the rest of the week. I checked the expiration date and assuming that the number<PHONE_NUMBER> maps to a Unix timestamp, the URL seems to expire some time today.

Thanks,
Daniel Jalova

----- Original message -----From: Gil Vernik<EMAIL_ADDRESS>SparkTC/stocator<EMAIL_ADDRESS>Daniel Jalova/San Francisco/IBM@IBMUS, Mention<EMAIL_ADDRESS>Re: [SparkTC/stocator] Stocator support for temp url (#97)Date: Tue, Nov 22, 2016 4:14 AM
@michaelfactor FYI
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.


Add back qiskit.transpiler.passes.synthesis.graysynth module

Summary
This commit reverts a breaking change made in #8568, in that PR the graysynth module was moved to the qiskit.synthesis package and the cnot_synth function was also renamed as part of the move. However, this change would break any existing users of the module without any warning. To fix this for the 0.23.0 release this commit adds back the graysynth module and just exports the contents of the module in its new location. Additionally, a small wrapper function is added so that the legacy cnot_synth function name can continue to be used for the time being. In the 0.24.0 cycle we can deprecate the old module and remove them after we've giving users a warning about the change.
Details and comments

I think the code is minimal enough here that we don't really need to worry about test coverage. All this is doing is redirecting calls from the old module to the new module and there is only one source of code so we'd essentially be testing python and not our code. That being said apparently this is causing a import cycle in the unit tests (which my manual tests didn't catch). I'll have to use a lazy import to fix this

I've changed my mind on the testing it might be effectively one line of code but I made a typo in this so I'll add a test case that exercises the function.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 10 (100.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 84.927%

Files with Coverage Reduction
New Missed Lines
%

src/vf2_layout.rs
1
86.44%

src/sabre_swap/layer.rs
2
98.95%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
66719

Relevant Lines:
78560

💛  - Coveralls

Note that both gray_synth and cnot_synth have never appeared in the Qiskit documentation before.

@mtreinish, thanks for taking care of this. Out of curiosity, did someone complain about the missing functionality? (Shelly and I were under an impression that if something is not mentioned anywhere in the documentation, it can probably be moved or renamed at will).
On a related note, we have also renamed some of the already existing (but not documented) clifford synthesis functions -- can this be a problem?

Note that both gray_synth and cnot_synth have never appeared in the Qiskit documentation.

IMO, this was mostly just an oversight. The module was added in the 0.9.0 release (back then we weren't as careful about the documentation) and the feature was documented as a new feature in the release notes at the time. For cases like this where it's not explicitly marked as internal or private (either with a leading _ or in the docstring) we should err on the side of caution and support the legacy name so if there are existing users they can migrate. I agree with the new location and name make it clearer, but it's very little effort on our part to add the redirects and do this and will avoid users complaining about things breaking for them.

@mtreinish, thanks for taking care of this. Out of curiosity, did someone complain about the missing functionality? (Shelly and I were under an impression that if something is not mentioned anywhere in the documentation, it can probably be moved or renamed at will).

Nobody complained about it afaik (although rc1 usage is typically pretty low so people might not have seen this) but I caught this going through the release notes and it was documented as a breaking change and I couldn't come up with a justification for why it needed to be breaking.

On a related note, we have also renamed some of the already existing (but not documented) clifford synthesis functions -- can this be a problem?

It could be if we weren't explicitly saying they were private or internal it might be best to add backwards compat wrappers to support the old names too.


fix build after #242

after #242 master is not compilling

I don't think this is desired, master should be compiling wrt swift master and not necessarily the toolchain. #242 was done due to proposal SE-0046 which is merged to swift master but isn't in toolchain yet. However I do think #242 should have been CI'ed.

So you saying that
func f(_ arg: Int)
f(arg: 2)

will build in swift/master?
My pr mostly fix this mistakes

I can build swiftpm master against swift master without this patch.

@mxcl ok, if not needed - can close it. New toolchain will be with master swift. So it wouldn't a problem


apprt/gtk: make window-decoration=false with gtk-titlebar=true look better

Before this change, there seemed to be some artifacting in the window corners due to the window border no longer outlining the content properly. By detecting the situation, we can turn the window border radius off.

I'd love to provide pictures, but it is hard to capture. Any reviewer should test it for themselves.

Thanks for the attention to detail. I trust you saw and fixed this.

See previous discussion in https://github.com/ghostty-org/ghostty/discussions/3290.

@tristan957 can confirm this does fix it


docs: add Angular CLI example

Summary/ Motivation (TLDR;)
Add an Angular CLI example to the repository.
Related issues

Closes #170

@nvh95 @ntt261298
Here's an example using Angular CLI with Jest via @angular-builders/jest.

@LayZeeDK

I just read the raw global CSS stylesheet and append it to the document. I don't know how we would add Sass support although it is supported by Angular CLI.

I see, I left a comment in the feedback above. You can use CSS file transform, then import .css and .scss file directly. More at https://www.jest-preview.com/docs/getting-started/installation/#2-configure-jests-transform-to-transform-css-and-files

Additionally, it would be interesting to run Angular in development mode to enable Angular Developer Tools.

Sorry, I haven't got your point. (Please forgive me I haven't had a chance to use Angular in production yet)

I plan to add an Angular Testing Library example even though Angular's built-in TestBed API seems to work well.

That would be awesome. Currently, all existing examples are using @testing-library packages. But Jest Preview is framework agnostic, so it just needs a JSDOM environment. Thank you very much for this plan.

Additionally, it would be interesting to run Angular in development mode to enable Angular Developer Tools.

Sorry, I haven't got your point. (Please forgive me I haven't had a chance to use Angular in production yet)

Angular has two runtime modes:

Production mode, used for deployed apps
Development mode, used for local app development

The ng serve command Angular developers use to start a Webpack Development Server usually runs Angular in development mode which adds runtime checks that degrade performance and enables Angular Developer Tools to be used as a web extension.
I'm not sure how to instruct the @angular-builders/jest:run Angular CLI builder to start the application in development or whether this is something Jest Preview could support.

@nvh95
I used the workaround to import component styles in tests and documented this in the example project's readme file.

@LayZeeDK 🚀🚀
@all-contributors please add @LayZeeDK for example


[Audio]: LOL Song/Caramelldansen (Pitched Down by 6 Semitones)

Check if this audio is already added to RetroStudio.

[X] The audio is not already in game.

Is this for the main-menu playlist?

[X] Add to main-menu playlist.

Is this song from an old Roblox era or a sound effect?

[X] This song is from old Roblox or is a sound effect.

A link to the audio on Roblox
https://www.roblox.com/library/9810554796/haha
A link to the audio file to download.
https://www.mediafire.com/file/diye9cxgn5blcan/lol_D_major__bpm_164.mp3/file
Notes
I'm not sure if this can be added, since it is copyrighted, but since it got approved, i'm using it's alright, though it might just be the filter sucking, i'd say wait around for a few days and if this isn't taken down by then add it.

unfortuately i've lost acces to the account, so i can't be 100% sure, but it looks like it's still up.

unfortuately i've lost acces to the account, so i can't be 100% sure, but it looks like it's still up.

How did you manage to lose access to an account that, I assume, you just made? (＃°Д°)

i made it in private tab, and forgot to save the pass DX


Ability to set value

Hi,
Thanks for writing this library. I added in the small feature of being able to programmatically set the value of the underlying  component using the same syntax and same implementation that you were using for getting the value.

Thanks!


warning api version 1.18.0

The latest v2 Hue bridge firmware delivers v1.18.0 of the Hue API.  homebridge-hue logs a warning message when it encounters this version:
[4/27/2017, 9:48:16 PM] [Hue] philipshue: BSB002 bridge, api v1.18.0
[4/27/2017, 9:48:16 PM] [Hue] philipshue: warning api version 1.18.0

Philips have yet to publish the changelog, but I don't think this version breaks anything in homebridge-hue.

Updated in v0.4.1.


Uncaught TypeError: Cannot read property 'token' of null

Getting this whenever I call hit my signin button and it calls the action. Any ideas?

^^ Fixed, was an issue in config with wrong token request name.

close?

Close


[FEATURE]

How urgent is this feature?
10
Is your feature request related to a problem? Please describe.
We control the robot in remote mode.
We command the robot to move to different target TCP poses but cannot find a way to limit trajectory taken when transitioning from one pose to another. This would be useful to prevent the robot hitting equipment around it.
Describe the solution you'd like
Set joint angles values range via RDK. Joint angle limits would be taken into account when robot IK is calculated.
Describe alternatives you've considered
As short-term solution, is there a way to set joint angles limits in Elements that would be considered when IK is calculated?
Thanks!

@yellownebula10 We can add setting joint limits over RDK in v1.6. However, only primitives that actually rely on IK calculation  will take into consideration the joint limits, for example MovePTP and MoveIK. The other primitives or the direct motion-force control modes in RDK do not calculate IK to get target joint positions, they calculate target joint torques based on a different control law instead. That being said, they will still honor the joint limits in a different way, which is the joint limits constraining that prevents joints from going over the limits.

Hi @pzhu-flexiv,
Thank you for your reply.
When you say "they will still honor the joint limits in a different way, which is the joint limits constraining that prevents joints from going over the limits" does this work when setting safety joint limits? Is setting safety joint limits sufficient to "constraint" the robot path when moving between target TCP poses?

@yellownebula10

Yes, setting safety joint limits changes both the safety limit and software limit, which is calculated according to the safety limit ( software_limit = safety_limit - const_offset).
Yes, if not forced by externally applied torques, the joints won't move over the set limits, i.e. the range of motion is changed. However, this also means some TCP pose might not be reachable due to reduced range of motion in the joints.


Issue with term

cc @michael-conrad
Describe the problem:
If an issue of grammar/correctness, please describe:
Something seems off about this to me. I know Ꮎ has a meaning similar to "that" but my understanding is that it is the demonstrative that (ie. that one, that thing) and not the coordinating conjunction that (ie. that I am hungry).
I know in German, demonstratives and other 3rd person pronouns will be used in place of subordinate clauses to preserve the grammatical structure. Eg.
Ich habe es   nicht gesehen,            dass du  hier gekommen             bist.
1sg AUX 3sg.IN NEG  see:PAST-COMPLETIVE that 2sg here come:PAST-COMPLETIVE AUX

Lit: I didn't see it, that you came here.
Free: I didn't see you get here / come here.
Is this how I would gloss this Cherokee phrase?
ᎠᏍᎦᏯ Ꮭ   Ꮎ  ᏯᎪᏩᏘ         ᎠᏴ    ᎠᏂ
asgaya hla na yà:gowhtí      ayv   áhni
man    not it 3sg:see:IRREAL me.we here

Literally, "The man didn't see it, (that) we are here," ie. the "it" which the man didn't see is "that we are here."
DO NOT EDIT BELOW
Problematic audio:

/online-exercises/source/chr/asgaya_hla_na_yagowhti_ayv_ahni_en-333-f_a1.30_ac69a1ed62aae16f70a108a811f2884709709129.mp3
/online-exercises/source/en/the_man_doesnt_see_that_i_or_we__Joey_5230d5f75be38211d7aa45692b08045aca0ac508.mp3

Additional metadata:
{"term":"asgaya hla na yà:gowhtí ayv áhni"}

Hrmm, I'm understanding "that" in this context to be a pronoun standing for the action. Not sure what that is linguistically.


Rename 'an block' to 'a block'

Missed this in the automatic rename of 'Ebb' to 'Block'.

Thanks for fixing this!


Use reasonable cluster size for ECS

Is your feature request related to a problem? Please describe.
There is unnecessary cost in a minimal setup, because 1 EC2 instance is in idle and 2 are just under minimal usage.
Describe the solution you'd like
Removing the 3 EC2 instance and scaling down the other 2. But remain enough resources to update both services.

utilizing the capacity provider will help here. so we put desired to 1 instance as default and max to 3 for the sample setup. this will make sure the system will be upgradable due CP requesting additional instances if needed. will put these changes into the next pull request.

solved by #39


Custom cmake - link_libraries based on the target dependency

There are already few modules which use custom cmake. The problem comes when the module adds target dependency, needs to create a conditional statements similar to:
if(TARGET_LIKE_FRDM_K64F)
    set(PLATFORM_SPECIFIC_HAL_LIB mbed-hal-frdm-k64f)
elseif(TARGET_LIKE_YOUR_TARGET)
    set(PLATFORM_SPECIFIC_HAL_LIB mbed-hal-yourtarget)
else()
    message(FATAL_ERROR "Missing PLATFORM_SPECIFIC_HAL_LIB")
endif()

In target link libraries, add ${PLATFORM_SPECIFIC_HAL_LIB}.

This could be resolved automatically with yotta.

One thing to note is that if all your custom cmake needs to do is extend the yotta-defined one, then you can use a .cmake file instead of a CMakeLists.txt (see http://yottadocs.mbed.com/reference/buildsystem.html#custom-cmake)
yotta could definitely add target_link_libraries commands after including custom CMake for a module: the only drawback I can think of doing this is that there'll be no way to stop it from doing that if, for some reason, it's undesirable. I don't know of any cases currently where it would be undesirable though.


Strip location in response for Exception class

I'm having trouble understanding how to generate a test that produces an exception. Is it possible to test it on the Merlin branch via Fuzzy-CI?

Is it possible to test it on the Merlin branch via Fuzzy-CI?

That's probably the easiest solution to test this, yes. If you want to do that before merging this, you can do it on your merlin fork. You'll need to go into the Fuzzy-CI workflow file in merlin, adjust merl-an's repo and commit sha in there to point to your change, and open a PR on your merlin fork itself. That should (hopefully) trigger the Fuzzi-CI and you should be able to see the impact of this change on the Fuzzy-CI output. As a side-effect, that'll also be a good way to test if the CI runs on a fork or not.

You open a PR to merlin with the new merl-an pin in the Fuzzy CI.

Using my own (merl-an) fork?

I don't understand (I'm sorry!). I meant to pin to the commit that the default branch of this fork points to now after merging. For that, you need to open a PR on Merlin that updates the commit in line https://github.com/ocaml/merlin/blob/master/.github/workflows/fuzzy-ci.yml#L44 to 6411f0d3847e8b7e66362bcb1f9345a5d3e851ca. If you prefer that I open and discuss the PR on Merlin, let me know!


Running previous code

We have written the needed data into your clipboard because it was too large to send. Please paste.
Issue Type: Bug
My code is running the previous code i was working on
i have cleared obj and bin folders but still its still runnning the previous file
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 7 5700U with Radeon Graphics          (16 x 1797)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.35GB (7.75GB free)

Process Argv
--crash-reporter-id c4d3d8d5-b39a-457a-8447-46165960816f

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

csharp
ms-
1.23.17

python
ms-
2021.12.1559732655

vscode-pylance
ms-
2021.12.2

jupyter
ms-
2021.11.1001550889

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.4

vscode-icons
vsc
11.8.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vscop804:30404766
vscop453:30404998
vsrem710cf:30416617
vscexrecpromp3t3:30407764

We'll need some more context to understand the problem you're having, it sounds like an extension/language issue though not related to vscode core.


Index Out of Range Error in live-image-classifier

Error stacktrace below for "../ncappzoo/apps/live-image-classifier":
Traceback (most recent call last):   File "live-image-classifier.py", line 186, in <module>     main()   File "live-image-classifier.py", line 132, in main     infer_image( graph, img, frame )   File "live-image-classifier.py", line 109, in infer_image     + " ( %.2f ms )" % ( numpy.sum( inference_time ) ) ) IndexError: list index out of range

@nealvis @ashwinvijayakumar Would like to seek your support to fix this issue.


Grammar fixes

Thanks. I am not sure if such changes are in the scope of what Hacktoberfest considers acceptable, but we welcome it nonetheless.


Handle failed exit codes elegantly

Instead of printing out this error:
$ wrangler generate my-rust https://github.com/EverlastingBugstopper/rustwasm-worker-template/🌀  🐑  Generating a new rust worker project with name 'my-rust'...
🔧   Creating project called `my-rust`...
Error: ⛔   Target directory already exists, aborting!
Error: failed to execute `"/Users/averyharnish/.cargo/bin/cargo-generate" "generate" "--git" "https://github.com/EverlastingBugstopper/rustwasm-worker-template/" "--name" "my-rust" "--force"`: exited with exit code: 1

print out this error that lets people copy and paste the command we tried to run easier (before it had a bunch of quotes in it):
$ wrangler generate my-rust https://github.com/EverlastingBugstopper/rustwasm-worker-template/
🌀  🐑  Generating a new worker project with name 'my-rust'...
🔧   Creating project called `my-rust`...
Error: ⛔   Target directory already exists, aborting!
Error: command exited with exit code: 1
`/Users/averyharnish/.cargo/bin/cargo-generate generate --git https://github.com/EverlastingBugstopper/rustwasm-worker-template/ --name my-rust --force`

reason i'm looking at this is because of https://github.com/ashleygwilliams/cargo-generate/pull/198

While we are at it, could we remove these redundant lines?
🌀  🐑  Generating a new worker project with name 'my-rust'...
🔧   Creating project called `my-rust`...

seems those lines are saying the same thing?

Totally!


HeadlessMC crashing when run in a linux service

So I was trying to run headlessmc as a linux service, but it keeps crashing. When I run it manually by doing ./hmc.sh, its starting and working just fine (except some errors, probably just LWGL though).
crash-2024-12-05_09.31.49-client.txt
This is the service file:
[Unit]
Description=Legitimoose API Scraper Bot

[Service]
ExecStart=/etc/legitimoose/legitimooseapi/scraper/hmc.sh
Restart=always
User=root
# Note Debian/Ubuntu uses 'nogroup', RHEL/Fedora uses 'nobody'
Group=root
Environment=PATH=/usr/bin:/usr/local/bin
Environment=NODE_ENV=production
WorkingDirectory=/etc/legitimoose/legitimooseapi/scraper/

[Install]
WantedBy=multi-user.target

And this is the hmc.sh script:
#!/usr/bin/env sh
java -jar headlessmc-launcher-wrapper-2.4.1.jar --command launch fabric-loader-0.16.9-1.21.1 -lwjgl

Yep thanks that worked


git-up not working on OS X Mavericks

Using the basic instructions, it seems to install OK:
%> sudo gem install git-up
Fetching: git-up-0.5.12.gem (100%)
Successfully installed git-up-0.5.12
Parsing documentation for git-up-0.5.12
Installing ri documentation for git-up-0.5.12
Done installing documentation for git-up after 0 seconds
1 gem installed
However it is not functional:
%> git up
git: 'up' is not a git command. See 'git --help'.
Did you mean one of these?
pull
push
I'm setup with homebrew git that's found first before os x git:
%> for g in $(which -a git) ; $g --version
git version 1.9.0
git version <IP_ADDRESS> (Apple Git-48)
Not sure what to provide, not a ruby guy.
%> gem list
*** LOCAL GEMS ***
bigdecimal (1.2.5, 1.2.4)
colored (1.2)
diff-lcs (1.2.5)
git-up (0.5.12)
grit (2.5.0)
io-console (0.4.2)
json (1.8.1)
mime-types (2.2, 1.25.1)
minitest (5.3.1, 4.7.5)
posix-spawn (0.3.8)
psych (2.0.4, 2.0.3)
rake (10.1.1, 10.1.0)
rdoc (4.1.1, 4.1.0)
test-unit (2.5.5, <IP_ADDRESS>)
%> gem --version
2.2.2

@asmod3us nice trick. Used rvm info to figure out which ruby version to use with the rvm --default use command.


Full path issues for sbt and java.

https://gitter.im/ensime/ensime-sublime?at=558b23f6609a063b57874201
I think I should at least remove the default and if empty, just run "sbt" and "java" as is.  And add error handling.

Waiting for input why it doesn't stick: https://discuss.atom.io/t/package-settings-not-saved/17925

Half-baked: https://github.com/hedefalk/ensime-atom/commit/6da6c23077b10cee7e912d5d7a7e9774e9c20034


FediFinder is gone

On your main page, there's a link to https://fedifinder-v1.glitch.me
Site's offline, Musk killed the API used.
Not sure if there's any replacement tools for twitter (X) / bsky users to find masto accounts.

Thank you for pointing this out, sorry it has been a moment since I had a sec to work on this but I think this should be an easy fix that I should be able to knock out this evening.


Add support for transparent characters

Hi! Thank you for helping out with Embedded Graphics development! Please:

[x] Check that you've added passing tests and documentation
[ ] Add a simulator example(s) where applicable
[x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) and appropriate crate (embedded-graphics, simulator, tinytga, tinybmp) if your changes affect the public API
[x] Run rustfmt on the project
[ ] Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description
Closes #408
I think drawing a solid rectangle using the background color is not particularly useful. This PR modifies text rendering so that the text can be transparent in this case.

p.s. pleas give this a rebase when you have a moment.

I think this PR also raises a related issue: if the stroke colour and background colour are None, should the bounding box size of Styled<Text> be zero?

Makes sense, best to be consistent on that one IMO.

I just noticed there was some force pushing to this branch. When you're ready for a re-review, can you click the "request review" button so I get an email notification please? That way these PRs don't fall down the back of the couch :grin:

I'll do that as soon as I have the size=0 change.

All yours @jamwaffles

even if it makes layout of transparent text in e-t a bit harder

I don't think it does :)

For whatever reason I can't reply to the second comment, but:

transparent_text_bounding_box or transparent_text_dimensions

I can often be lazy with naming my tests, but after listening to some of Kevlin Henney's talks, I'm trying to give somewhat meaningful names to my tests. So that when they fail, the name of the test can often tell what's wrong. For example, "transparent_text_bounding_box" hints at which test is bad, but not why. However, "transparent_text_has_no_size_but_has_position" while a bit unwieldy and asserts two things, at least gives a pointer without looking at the test result or test code. If anything, I think I should split the test into 2 :)
However, I agree with the "no size" part. No extent, maybe, or zero size, but both sound also a bit off to my ears.

Any possible time gain from a good function name, if this test ever fails, has already been eaten up by this discussion :wink:.
If I run the tests by using cargo test I don't think the function name on it's own is very important, because it always includes the entire test output. But adding the reason why the test failed is a valid point, so I would suggest this:
#[test]
fn transparent_bounding_box() {
    let style: TextStyle<BinaryColor, _> = TextStyle {
        font: Font6x8,
        text_color: None,
        background_color: None,
    };

    let styled = Text::new(" A", Point::new(7, 11)).into_styled(style);

    assert_eq!(
        styled.bounding_box(),
        Rectangle::new(Point::new(7, 11), Size::zero(),
        "Transparent text is expected to have a zero sized bounding box with the top left corner at the text position",
    );
}

This might not be what you suggested but is consistent with the other tests and shows the reason why the test failed when running cargo test. IMO this is not the right place to discuss changing our style of writing test in general, but feel free to open an issue if you think we should improve our tests so we can discuss this further. There certainly is room for improvement.

I don't want the current tests to change, I merely tried to explain why/how I (at least want to) write my tests. I'm sorry that I am so bad at explaining my thoughts.
I still think having a more descriptive test name is as important here as it is with the API itself. But I quite like your suggestion, @rfuest :)

Now that #459 is merged, this PR needs updating to change files in the project root - there's no workspace anymore.
I like @rfuest's suggestion to add some descriptive failure text. Beyond that, I think this is getting a bit bikesheddy, so if there are no other issues it would be good to get this PR merged.

@jamwaffles I've rebased, and I've also updated the tests. The first one I've originally added now actually tests different background colors, which, while not strictly necessary, I think shows the intended behaviour better (i.e. no accidental "deletion" of existing pixels [even though that's not even possible]).

The first one I've originally added now actually tests different background colors, which, while not strictly necessary, I think shows the intended behaviour better (i.e. no accidental "deletion" of existing pixels [even though that's not even possible]).

The correct behavior is already sufficiently shown by a single draw call to a MockDisplay. MockDisplay records the changes made to the display and not only the final framebuffer content. It's guaranteed that the drawing operation didn't change any ' ' pixels in the pattern. And by having to deactivate the overdraw detection the test is now insensitive to any overdraw that happens while a transparent text is drawn.

Closing in favour of #470

@bugadani I would like to get this merged soon. Did you see my previous comment about the test changes?

@rfuest Yes. I can change it back but I feel like the current one is more informative for a reader. I'm not worried about the overdraw in the test, since the feature kind of (but not completely) implies it anyway. Also, the lack of overdraw is already covered by other tests, and changing a color shouldn't cause any that wasn't there before. I don't really feel strongly either way, so I leave the decision up to you :)

OK, let's not drag this out any longer and just leave it this way.

@bugadani LGTM. Thanks for you patience ;).
@jamwaffles Your review is still marked as "changes requested" so that I cannot merge the PR. I'll let you merge it.


Wrong received int type in liteserver.get_account_state

Hi!
I try to get the raw account state using liteserver method as follows:
from pytonapi import AsyncTonapi

client = AsyncTonapi(api_key="<API_KEY>")

account_address = "EQCqFPpSLtcstURtrXLRCv9wyjfrw7_44_nwvD8JiSmSjbUI"

state = await client.liteserver.get_account_state(account_address)

And I get the following error:
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)
Cell In[24], line 1
----> 1 state_tonapi = await client.liteserver.get_account_state(account_address)

File [/usr/local/lib/python3.10/site-packages/pytonapi/async_tonapi/methods/liteserver.py:121](http://localhost:8889/usr/local/lib/python3.10/site-packages/pytonapi/async_tonapi/methods/liteserver.py#line=120), in LiteserverMethod.get_account_state(self, account_address, target_block)
    118 params = {"target_block": target_block} if target_block else {}
    119 response = await self._get(method=method, params=params)
--> 121 return RawAccountState(**response)

File [/usr/local/lib/python3.10/site-packages/pydantic/v1/main.py:341](http://localhost:8889/usr/local/lib/python3.10/site-packages/pydantic/v1/main.py#line=340), in BaseModel.__init__(__pydantic_self__, **data)
    339 values, fields_set, validation_error = validate_model(__pydantic_self__.__class__, data)
    340 if validation_error:
--> 341     raise validation_error
    342 try:
    343     object_setattr(__pydantic_self__, '__dict__', values)

ValidationError: 1 validation error for RawAccountState
shardblk -> shard
  value is not a valid integer (type=type_error.integer)

I'm pretty sure this error stems from int annotation here: https://github.com/tonkeeper/pytonapi/blob/960e574259049a65e4aea6580e25a56efcb8890c/pytonapi/schema/liteserver.py#L8
I tried to do the simple HTTP request without Pydantic response parsing like that:
response = await client._get(method=f"v2/liteserver/get_account_state/{account_address}", params={})

and get the following response
{'id': {'workchain': -1,
  'shard': '8000000000000000',
  'seqno': 37496117,
  'root_hash': '01166afa4bcb8b8bc65499ca755f434f0cfc4d13b7e90eb42ed436a831853e45',
  'file_hash': 'fd4620e8510e0d0b657f7edc6e3cc9f505fac97f63f8f79c8d9c9ee4082f5dd0'},
 'shardblk': {'workchain': 0,
  'shard': 'c000000000000000',
  'seqno': 43158333,
  'root_hash': 'bd96247321a94c9d17945286f85a13e296e2a4ce932764a6c95ddd0126e60bc3',
  'file_hash': 'f0728e43f52308da96a88b6c664a5b115ec01d51c499e8e057e83da901a9b322'},
 'shard_proof':
  .....

So response["shardblk"]["shard"] is indeed not an integer, at least not a decimal one.
I would be grateful if someone can help/share the experience with it.
@nessshon I'm also happy to make a PR, but I'm not quite sure how we should fix it.

@vladimir-chernykh, Thank you for your contribution! Indeed, it was found that in the documentation, the shardblk.shard schema specifies the data type as str instead of the expected int. It will be corrected in the next update.


Highlight unassigned geographies

#169
Description

Adds option to highlight un assigned geometries to make them easier to find and paint

Reviewers

Primary: @mapmeld
Secondary: @raphaellaude

Checklist

[x] Update mapOptions type
[x] Update highlight layer specification to optionally show these ares
[x] Add subscription to mapOptions to update layer rendering based on options
[x] Add checkbox in sidebar with this option
[x] Added child layer highlight, when present

Screenshots (if applicable):

Looks good and works well – only thing I'd app perhaps is making the stroke width a little thinner and using round caps.

Thanks! I just reduced the line width and cleaned up the style expression a little. The cap is already rounded, although it does look a little rough. The challenge he is that we cannot combine map style specification case  and interpolate so there is no way to get a smaller line when zoomed out and also check some additional logic


Add --retry-on-tf-failure flag to k8s conformance jobs

Added a flag --retry-on-tf-failure tokubetest2 tfcommand used in below k8s conformance jobs:
test-infra/config/jobs/periodic/kubernetes/test-kubernetes-periodics.yaml:  - name: periodic-kubernetes-conformance-test-ppc64le
test-infra/config/jobs/ppc64le-cloud/builds/kubernetes-postsubmit.yaml:    - name: postsubmit-master-golang-kubernetes-conformance-test-ppc64le

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Rajalakshmi-Girish
To complete the pull request process, please assign mkumatag after the PR has been reviewed.
You can assign the PR to them by writing /assign @mkumatag in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

\cc @mkumatag

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mkumatag, Rajalakshmi-Girish
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

key test-kubernetes-periodics.yaml using file config/jobs/periodic/kubernetes/test-kubernetes-periodics.yaml
key kubernetes-postsubmit.yaml using file config/jobs/ppc64le-cloud/builds/kubernetes-postsubmit.yaml

In response to this:

Added a flag --retry-on-tf-failure tokubetest2 tfcommand used in below k8s conformance jobs:
test-infra/config/jobs/periodic/kubernetes/test-kubernetes-periodics.yaml:  - name: periodic-kubernetes-conformance-test-ppc64le
test-infra/config/jobs/ppc64le-cloud/builds/kubernetes-postsubmit.yaml:    - name: postsubmit-master-golang-kubernetes-conformance-test-ppc64le

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[Feature Request]: Improvement and fix bug in rate us form

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
the font colour of rate me form message needs to be changed as it is not visible moreover instead of getting confirmation message via alert it will be great if we use popup confirmation message for better user experience

Use Case
n/a
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Already there


[$500] Web – Assign Task - An error occurs when both User A and User B press the "Mark as done" button simultaneously

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any chat labeled "Assign Task" between User A and User B. (The task was created by User A.)
Click "Mark as done" and "Mark as incomplete" from User A. Observe that it works correctly
Click "Mark as done" and "Mark as incomplete" from User B. Observe that it also works correctly
Ensure that the "Mark as done" option is present in the header for each user
Simultaneously press the "Mark as done" button from both User A and User B
An error message appears on User B's system, stating, "You do not have permission to perform the requested action.

Expected Result:
The error should not appear and the task should be closed regardless of which user performs the action
Actual Result:
An error message appears on User B's system, stating, "You do not have permission to perform the requested action."
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.70-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/1469e0d9-b530-4225-8a23-add1aa71144d
https://github.com/Expensify/App/assets/78819774/ca2bcf83-1cca-4840-8779-28ad810dd71c
Expensify/Expensify Issue URL:
Issue reported by: @Usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694588501046099
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0129a7b3f4233c245f
Upwork Job ID:<PHONE_NUMBER>863018496
Last Price Increase: 2023-10-06

Proposal
Please re-state the problem that we are trying to solve in this issue.
In assign task when 2 users simulatenously complete task then 1 of 2 users gets an unwanted error.
What is the root cause of that problem?
Root cause is that we are hard coding error message here:
https://github.com/Expensify/App/blob/76c1559fb3fbee1d07c8f210b522b63edd03920e/src/libs/actions/Task.js#L264-L272
This is not considering other reasons of error and have just 1 hard coded case of permissions issue which is not in this specific case.
What changes do you think we should make in order to solve the problem?
We need to add error handling for task errors and show error that is tailored to the problem that happened which in this case is e.g. "User 1 has already completed task.", "User 2 has already reopened task".
This needs to be done via a utility method that must find appropriate error message based on various conditions. Currently we can add 2 cases:

Some other user already reopened task
Some other user already completed task

Text needs to be added in language files for showing various error messages in multiple languages.
What alternative solutions did you explore? (Optional)
Just simply remove this:
https://github.com/Expensify/App/blob/76c1559fb3fbee1d07c8f210b522b63edd03920e/src/libs/actions/Task.js#L264-L272
That will stop showing error messages for tasks api call.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Updated

Problem Statement:
When two users simultaneously attempt to mark a task as done, one of them encounters an error message, "You do not have permission to perform the requested action."
Root Cause:
The system doesn't handle concurrent task state modifications gracefully, leading to misleading error responses when race conditions emerge.
Proposed Solution:
Intelligent Error Handling Using Task State Locking and Enhanced Onyx Messaging:

Backend Task State Locking:

Use a short-term locking mechanism to handle task state changes.
If another user tries to modify the task during this lock, return an appropriate concurrency error code.

Enhanced Onyx Error Management on the Frontend:

Incorporate specific error codes to provide clearer feedback.
Update the Onyx store with user-friendly error messages based on the error code received.

Implementation:
Backend:
if (task.isLocked()) {
    return { success: false, errorCode: 'CONCURRENCY_ISSUE', message: 'Another user is currently updating the task. Please try again in a moment.' };
}
task.lock();
// Carry out the task state modification
task.unlock();

Frontend:
function changeTaskState(taskID) {
    API.ChangeTaskState(taskID)
        .then((response) => {
            if (response.errorCode === 'CONCURRENCY_ISSUE') {
                Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${taskID}`, {
                    errors: {
                        concurrencyIssue: "Another user is updating this task. Kindly wait a moment."
                    }
                });
            } else if (!response.success) {
                // Manage other potential errors
            }
        });
}

Incorporate enhanced error messages in App/src/languages/en.ts:
task: {
    // ... existing keys
    messages: {
        // ... existing messages
        concurrencyIssue: "Another user is updating this task. Kindly wait a moment.",
        completingError: "Unable to finalize the task as completed. Please retry shortly.",
        reopeningError: "Unable to revert the task. Please try again after a while."

Delivers clearer feedback to users through enhanced Onyx error messaging, improving UX.
Centralizes error messages with Onyx, streamlining error management.

Disadvantages:

The locking mechanism can introduce a minor delay in processing task updates.
Requires frontend and backend modifications to manage and display the new error messages.

Alternative Solution:
Optimistic UI Updates with Timestamp-based Validation and Onyx Messaging:

Assume success on the frontend (optimistically) when a user tries to change the task state.
Use timestamps to determine the most recent task state change on the backend.
If there's a conflict, return a specific error code.
Display a more descriptive error message using Onyx on the frontend.

Advantages:

Provides an immediate response, enhancing user experience.
Reduces the chance of race conditions using timestamp validation.

Disadvantages:

Potential for race conditions if timestamps are identical, though very unlikely.
Users might still experience rejection messages, but they will be more descriptive.

This was marked External prematurely, and I'm just getting caught up now. I just tested on my local accountant this is reproducible so we should indeed fix it.
@sobitneupane inviting your input on the proposals above.

@michaelhaxhiu It is better to handle this issue internally. I think it's possible that we may need to make some adjustments to the backend in order to address the issue.

@sobitneupane @michaelhaxhiu in the frontend showing simple error message in case of a failure should be enough as per my thinking. Handling it in the backend with semaphores and other simultaneous access jargon can make things more complicated and will cause more errors. Simply showing message unable to mark completed/reopen should be enough. @michaelhaxhiu what do you think?

I'm going to apply the Engineering label to get an internal engineers input. @sobitneupane is saying this may be best resolved internally here, but we have some existing proposals that can resolve it in the front end.
What do we think?

This feels more like an improvement than resolving a bug.
I think a backend change would be ideal, but a front-end fix is the better solution for us. There's no chance we'll be able to prioritise the backend changes this year.

Thanks for your input! @sobitneupane let's review the front end suggestions that were provided please.

I think this is the next step:

@sobitneupane let's review the front end suggestions that were provided please.

Thanks @Julesssss.
@dukenv0307 Would you mind explaining the conditions used in the codeblock?
Would the proposed change affect the case where the user does not have permission to perform the action? We would like to show an error if that is the case.

Would the proposed change affect the case where the user does not have permission to perform the action? We would like to show an error if that is the case.

If user doesn't have permission then it will be 404 page that will be thrown to the user or lets say someone removes the task then it should be removed in real time from other users.

Bump @sobitneupane

Sorry for the delay.
I will try to review the proposals before EOD tomorrow (NPT).

Thanks for the update @dukenv0307.
Proposal from @dukenv0307 looks good to me.
🎀 👀 🎀 C+ reviewed

I reviewed the PR and I'm not sure that the current proposal is the right solution. I think we should fix it on the backend as I mentioned here.

@jules, my proposal is straightforward; we can address the issue by adding a permissions error alongside showing marking/unmarking errors. This should resolve the problem.

Assigning to @neil-marcellini as discussed here: https://github.com/Expensify/App/pull/29259#issuecomment-1764952775

Rodrigo is taking over for me to implement the backend change.

@ayazalavi It is decided to fix the issue in the backend. It is no longer available for new proposals.

So we are suggesting showing one action, marked as complete, as taken by two people? I'm not sure that's ideal but curious what @neil-marcellini thinks too

In the end only one person actually completed the task, since we don't save a new completed action for a task that was already completed, that is why I think this is ok.

Just to be sure, you think showing the task that one person actually completed to two people as completed by both of them to be OK?

Oh no sorry, I think we should show only one completed message by the correct person, and that is what we are actually doing, showing only one complete action for this situation.
I guess the screenshot I took made things a little bit confusing, but we fixed that screenshot in the backend PR.
If two people complete a task simultaneously we are erasing the completed message from the person that didn't actually complete it.

Awesome!

I think we can close this issue, but I am not sure whether payment is due or not.
@MitchExpensify

Payment summary:

usmantariq96 Reporter: $50, Upwork
C+ @sobitneupane - Clarification, did you end up reviewing the proposal that was ultimately used here seeing as it was a backend change?

@MitchExpensify A proposal was selected and while implementing the PR, it was decided that the issue would be best solved on the backend. So, we ended of closing the PR without merging.

That seems fair, can you both please apply to this job for payment? https://www.upwork.com/jobs/~01314f533571a41c4f

And same for you usmantariq96, thanks!

@MitchExpensify link is not opening at my end.
Can you please send me direct message please.
My Upwork Profile link: https://www.upwork.com/freelancers/~0162e9ec0b876900fb
Thanks

@MitchExpensify applied for the job
thanks

@MitchExpensify I will request payment on newDot once you post the payment summary.

Updated the payment summary - https://github.com/Expensify/App/issues/27570#issuecomment-1830528327

Do we need to add a regression test here @sobitneupane ?

Regression Test Proposal

Create a task from User A assigning it to User B.
Ensure that the "Mark as done" option is present in the header for each user
Simultaneously press the "Mark as done" button from both User A and User B
Verify that the app works fine and no error is displayed
Ensure that the task is marked as Done
Simultaneously press the green box to re-open the task from both User A and User B
Verify that the app works fine and no error is displayed
Simultaneously press Cancel the task from both User A and User B
Verify that the app works fine and no error is displayed

Do we agree 👍 or 👎

https://github.com/Expensify/App/issues/27570#issuecomment-1830528327
Requested payment on newDot.

$500 payment approved for @sobitneupane based on this comment.


PT/BR Docs Translation: update the "janelas" to "windows"

System Operation windows and not literal windows!

Thanks! Though I don't know PT/BR, this is making me laugh.


use of cortex where one is not in control of renderComponent

This may be out of scope here but I thought I'd ask.  I'm trying to react-router with cortex.  One is not in control of calling render function.  Is there a way of using cortex in such a fashion?  The best I can come up with is a wrapper component that stores the cortex object as state and passes it down as a prop but at least one weird render problem occurs (cursor position gets lost in text fields).
Thanks

I'm not familiar with react-router, can you provide code of what you're trying to achieve?

A typical usage of react router might goes as follows:
var routes = (
  <Route handler={App} path="/">
    <DefaultRoute handler={Home} />
    <Route name="about" handler={About} />
    <Route name="users" handler={Users}>
      <Route name="recent-users" path="recent" handler={RecentUsers} />
      <Route name="user" path="/user/:userId" handler={User} />
      <NotFoundRoute handler={UserRouteNotFound}/>
    </Route>
    <NotFoundRoute handler={NotFound}/>
    <Redirect from="company" to="about" />
  </Route>
);

Router.run(routes, function (Handler) {
  React.render(<Handler/>, document.body);
});

You can see one is not "in control" of the React.render call.  This pattern seems to be typical for other routers at well.  I'm trying to use cortex and a router at the same time.  What I've tried so far was to use a "wrapper" component to create the cortex object then pass it down through a prop to the "real" component.
From the example above suppose I have User and RealUser components defined like this:
var RealUser = React.createClass({ // the "real" component
  updateFoo: function(e){
    this.props.data.add(foo, e.target.value);
  },
  render: function(){
    <input type='text' value={this.props.data.foo} onChange={this.updateFoo} />
  }
});

var User = React.createClass({ // a "wrapper" component
  getInitialState: function(){
    var data = new Cortex({ foo: 'bar' });
    data.on('update', function(newData){
      this.setState({data: newData});
    });
    return {
      data: data
    }
  },
  componentWillUnmount: function(){
    this.state.data.off('update');
  },
  render: function(){
    return <RealUser data={this.state.data} />
  }
});

Everything seems to work fine except the cursor position jumps to the end of the text field on any value change.  It seems wrong to store the cortex object as state in any component but I'm not sure how to do it otherwise when I'm using a router.  What I'm I missing?  Surely people are using a router with react and cortex (or something similar).
Thanks.

Cortex is designed such that you can use it as either props or state, but when you use it as state then the component managing that state is in charge of changing the data. It's still unclear to me the connection between your React components and your router. Do you have Users component as well, and if so why not pass a cortex of users as props into that component?

Here's an example of the problem I'm seeing:
https://dl.dropboxusercontent.com/u/10057662/page.zip
Try typing in the text box at the left most of the text.  The cursor will jump out to the right on any modification.

I think the problem is after changing the input, your handler updates the model, which triggers react to rerender and reset the cursor position
Have a look at this related issue
https://github.com/facebook/react/issues/955

OK, been going back and forth on this issue for a couple of weeks now. Here's the problem:

React's onChange handler triggers a re-render.
Since Cortex 0.6.0, Cortex batches updates and runs them together in a setTimeout.

So the example pattern of "update state and/or props from an Cortex.on('update') callback" won't work.
Unless props and/or state are updated synchronously in onChange then the old Cortex value will get rendered again to the DOM. React triggers forceUpdate after running any onChange handlers. Because the props/state still have the old Cortex value, React will notice that domValue != reactValue and so put the old value back into the DOM, causing the cursor jump as described in facebook/react#955.
Finally, after event handling & rendering has concluded and Cortex's setTimeout gets a tick from the event loop, the new value is put back into the field.
By removing setTimeout from Cortex, things work as expected — the input updates with no cursor jumps.
I'm not sure what the best approach is to fixing this. I believe that forceUpdate after onChange is a relatively recent change to React, but they seem to have a good reason for doing that.


force polyfill

Is there a way to force polyfill even with browsers with native dialog support?

No. You could modify the code to target a specific element but right not it's hard-coded to dialog.


code to cover Fees

I don't see a way to add a fee to a subscriber. http://spreedly.com/manual/integration-reference/adding-a-fee-to-a-subscriber/

+1


Advanced CmakeLists Parser/Lexer, Yaml config

Hi,
Hope you are all well !
I tried to install and use cmakepp with hunter in order to add hunter_add_package on the fly when a find_package command is referenced in a project.
Goal/Background:
My goal is to create a small utility, that I will write in golang for ease and cross-platform use, allowing to parse CMakeLists.txt and export,import package dependencies with yaml/json input file. It would help me to bundle lots of projects, cmake based, to a Docker container, alpine based (for those not familiar Docker, it will just reduce the size of containers, making it more easy to deploy in production). Often, I would to extract all dependencies, and pick a specific version and build them from sources.
Summary: Manage cmakelists package dependencies with commit-ids and vcs, and be able to manage cmake args through a yaml file.
My little script can either write/generate *.cmake file from a yaml config, then parse the content from cmake with json-cmake (link) and loop over the dependencies to find or add with the ExternalProject to build a project. As a preliminary step, I would need to extract some informations, or the whole ast from cmake based project in order to build this configuration file.
My inspiration comes from these golang utilities:

Glide: Manage package dependencies with versioning, and multi-vcs. Official Repository (link), Yaml config file example (link)
nut: Manage macros and bundle a project into a docker container. Official Repository (link), Yaml config example (link)

Real case:
For example, this dockerfile as lot of packages provided by apt package manager. So I would like to build them from source but be able to checkout a specifc version from a specifc vcs and iterate through a macro.
In a nutshell, I wanted to pre-generate, with a kind of wizard (like with glide in golang) the extraction of the cmake ast, then to extract some config nodes related to commands like: find_package, find_library, add_target, add_library...
Where is my bottleneck ? :-)
So it requires to get the precise mapping of arguments names, values and properties. But CmakeLists does not have uniform ways to provide command flags or args ....the order of some commands can be different, present or missing...
examples:

Custom functions/macros:

https://github.com/headupinclouds/gatherer/blob/develop/CMakeLists.txt#L66

Packages,Components,Version

https://github.com/halismai/bpvo/blob/master/CMakeLists.txt#L124
https://github.com/halismai/bpvo/blob/master/CMakeLists.txt#L136

I was thinking about a CMake lexer (reference example), and to write an ast tree, but I would like to do more with the CMakeLists.txt so that's how I found your interesting project.
Question:
Is it possible to manipulate, parse CMakeLists.txt with cmakepp ? Is there any example that would help me to start some tests or development quickly ? ps. I could not make work all examples 3 last examples.
Hope I was clear enough with this lengthy explanation ^^
Have all a great day ! And thanks for any inputs or any recommendations in order to achive this smart cmake lexer.
Cheers,
Richard

Hi Richard,
it is possible to manipulate cmake lists with cmakepp... however cmakepp is a pure cmake library. ie it could be hard to incorporate it and it is slow compared to doing this natively in c++ for example.
creating a lexer and parser  for cmake yourself is however very simple because cmake script is a very simple language - this is also what i would suggest.
Here is the complete language definition: https://cmake.org/cmake/help/v3.0/manual/cmake-language.7.html#syntax
possibly you could even use a parser like antlr or boost::spirit to create the asts simply.
you can look at how i did it in cmakepp eventhough its very specific.
https://github.com/toeb/cmakepp/blob/master/cmake/cmake/reflection/parsing/cmake_tokens_parse.cmake
here are the regular expressions used: https://github.com/toeb/cmakepp/blob/c597ef81cfa3c09cecc4129600b7ed082900cc7d/cmake/regex/regex_cmake.cmake


Bug in Venmo app: "Pay (null) $1" appears when using this SDK

A picture speaks a thousand words:

Presumably this is because the app does not query Venmo's servers for the firstname and lastname if you try to initialize a payment using a URL scheme. (notice the dash between Murat and Gursoz, instead of it being "Murat Gursoz")
BTW, the URL scheme I used was:
venmosdk://venmo.com?recipients=Murat-Gursoz&txn=pay&note=test

I also tried this scheme, with all of the parameters and it also did not work:
venmosdk://venmo.com?recipients=Murat-Gursoz&txn=pay&note=test&client=ios&app_name=test&app_id=2734&device_id=&app_version=1.3.0

Actually, there's another nasty bug I noticed when using a URL scheme to open the app.
Another one I noticed is when you use a URL scheme to open the app, and you have a passcode/touch ID enabled, it asks for you to enter your passcode or touch ID, but when you do the payment menu is not opened.

The (null) issue should have been resolved by a new version of the Venmo app. We're tracking your second comment via issue #73 for now.
If your first issue still persists, feel free to reopen this issue!


Comodo WAF Rules doesnt work with Modsecurity v3.0.3

Comodo WAF Rules doesnt work with Modsecurity v3.0.3

Hi @slushz,
I am not sure what exactly i can do to help. Can you explain to us what is the exactly problem?

I am going to close this issue as you don't have feedback.


Next.js Examples

[ ] Community Skin Example
[ ] Headless Tailwind Example

Closing this as we now have React examples which should be mostly the same for Next.js.


Updated quickstart examples to inherit from object (new-style classes)

I went through the docs page by page and looked for where a class declaration was missing the new object inheritance.

This pull request is in response to
https://github.com/falconry/falcon/issues/565
I wasn't sure if there was a way to link issues to pull requests

@adamyala This change looks good. Could you ammend your commit message slightly in preparation for merging? It should conform to our style guide, and you can reference the issue in the body, i.e.:
doc(quickstart): Update examples to use new-style classes

Closes #565

@kgriffs I rebased my commits to use the style guide (and also just used the example you gave me)
The last thing I'm not 100% clear on is the Travis CI build check. Anything specific I should do about it? Is there a type of pull request when I'd want to address it?
Sorry for all the questions, I'm new to open source contributing. I'm also working on another open issue and I'd like to save us the trouble later.

The last thing I'm not 100% clear on is the Travis CI build check. Anything specific I should do about it? Is there a type of pull request when I'd want to address it?

For this particular change, there isn't anything to do. But if you were to modify the framework code then you would have to ensure that the tests pass, and if there aren't any tests that cover the change already, add some new ones until all code paths are tested. You can run the tests locally per the instruction on the README. It's a good idea to at least run pep8, py27, and py34 before submitting the PR:
$ tox -e pep8,py27,py34

If everything passes, you can submit the PR and Travis will test the remainder of the environments for you. Let me know if that helps, and feel free to catch me anytime on Freenode in #falconframework if you have further questions; I'm always happy to help new open-source contributors. :+1:

Thanks!


No visible @interface for 'RCTEventDispatcher' declares the selector 'sendInputEventWithName:body:'

I created a new project and I added react-navigation. When I want to build this project in Ios, the error happened as shown in title.
React Native version:
System:
OS: macOS Mojave 10.14.5
CPU: (4) x64 Intel(R) Core(TM) i5-6360U CPU @ 2.00GHz
Memory: 209.58 MB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.13.0 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
Android SDK:
API Levels: 18, 21, 22, 23, 24, 25, 26, 27, 28, 29
Build Tools: 23.0.1, 23.0.2, 23.0.3, 25.0.0, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.1, 27.0.3, 28.0.0, 28.0.1, 28.0.2, 28.0.3, 29.0.0, 29.0.0, 29.0.1, 29.0.2
System Images: android-19 | Google APIs Intel x86 Atom, android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Intel x86 Atom, android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>00203
Xcode: 10.3/10G8 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-create-library: 3.1.2
The Other Libraries that I used  ->
"react-native-gesture-handler": "1.5.2",
"react-native-reanimated": "1.4.0",
"react-native-safe-area-context": "0.6.2",
"react-native-screens": "2.0.0-alpha.22",
"react-navigation": "4.0.10",
"react-navigation-stack": "2.0.12",
My Pod File
platform :ios, '9.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
target 'Deneme' do
Pods for Deneme
pod 'React', :path => '../node_modules/react-native', :subspecs => [
'Core',
'CxxBridge',
'DevSupport',
'RCTActionSheet',
'RCTAnimation',
'RCTBlob',
'RCTCameraRoll',
'RCTImage',
'RCTNetwork',
'RCTPushNotification',
'RCTSettings',
'RCTText',
'RCTVibration',
'RCTWebSocket',
'RCTLinkingIOS',
]
pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
pod 'React-Core', :path => '../node_modules/react-native/'
pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'
pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
pod 'ReactCommon/jscallinvoker', :path => "../node_modules/react-native/ReactCommon"
pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'
pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'
target 'DenemeTests' do
inherit! :search_paths
# Pods for testing
end
use_native_modules!
end
target 'Deneme-tvOS' do
Pods for Deneme-tvOS
target 'Deneme-tvOSTests' do
inherit! :search_paths
# Pods for testing
end
end
Describe what you expected to happen:
I expected it to run in ios.

I added the   pod 'React', :path => '../node_modules/react-native/' to pod file , and error is gone.


Aniruddh Parwal DSC-SVCE added

Fixes #
Proposed Changes
-Added my Chapter DSC SVCE

@aniruddhparwal Please don't change the formatting of the file. Only add your photo and data. Revert your commit, add correctly and force push to update your PR.

+1 to aravind on this

It was auto prettified by VS  code.


Roles support

I have a need to extend roles for creating admin user.
It could be passed as variable in the line https://github.com/tutumcloud/mongodb/blob/master/2.6/set_mongodb_password.sh#L15
Do you mind to do that?

And ability to create custom db and grant access to it.


Can files come from stdin or named pipe

Hello,
Is there a way to allow files to be programmed to come from stdin, or a named pipe?  I tried with a named pipe for a command like
uuu fb: flash system      <somepath>/system.img

where system.img is a named pipe, and got an error such as
Error: fail open file: >/someotherpath/system.img

It would be useful for very large files on constrained systems.
Thank You

Not support yet.  local file use mmap. it should be okay for big file  at 64bit system


error AL0570: Same label var name in same codeunit results in same translation ID

Please include the following with each issue:
1. Describe the bug
error AL0570: Same label var name in same codeunit results in same translation ID
2. To Reproduce
codeunit 1234 my_codeunit
{
procedure p1()
var lbl1: Label 'label1';
begin
end;
procedure p2()
var lbl1: Label 'label2';
begin
end;
}
...\my_codeunit.al(y1,x1): error AL0570: The symbol 'lbl1' results in the same translation ID as one or more other symbols. Rename symbol to resolve the problem.
...\my_codeunit.al(y2,x2): error AL0570: The symbol 'lbl1' results in the same translation ID as one or more other symbols. Rename symbol to resolve the problem.

Go to '...'

AL code snippet that demonstrates the issue or a link to a code repository the developers can easily pull down to recreate the issue locally.

Note: Because the developers need to copy and paste the code snippet, including a code snippet as a media file (i.e. .gif) is not sufficient.
3. Expected behavior
2 differents translation ID generated
4. Actual behavior
error with same translation ID
5. Versions:

AL Language: v14.0.1114061 (pre-release)
Visual Studio Code:  Version: 1.92.2 (user setup)
Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
Date: 2024-08-14T17:29:30.058Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631
Business Central: Version : FR Business Central 24.3 (plateforme 24.0.23306.0 + application 24.3.21374.21517)
List of Visual Studio Code extensions that you have installed:
andrzejzwierzchowski.al-code-outline
davidanson.vscode-markdownlint
docsmsft.docs-article-templates
docsmsft.docs-authoring-pack
docsmsft.docs-build
docsmsft.docs-images
docsmsft.docs-markdown
docsmsft.docs-preview
docsmsft.docs-scaffolding
docsmsft.docs-yaml
github.copilot
github.copilot-chat
github.remotehub
gruntfuggly.todo-tree
learningengineeringoperations.learn-training-ai-assistant
martonsagi.al-object-designer
ms-dotnettools.csdevkit
ms-dotnettools.csharp
ms-dotnettools.vscode-dotnet-runtime
ms-dynamics-smb.al
ms-vscode.azure-repos
ms-vscode.powershell
ms-vscode.remote-repositories
nabsolutions.nab-al-tools
redhat.vscode-yaml
waldo.crs-al-language-extension
yzhang.markdown-all-in-one

Final Checklist
Please remember to do the following:

[X] Search the issue repository to ensure you are reporting a new issue

[X] Reproduce the issue after disabling all extensions except the AL Language extension

[X] Simplify your code around the issue to better isolate the problem

Hi @cristof-thomas,
I just tried out the code that you have in the issue description, and it does not reproduce for me. This is the generated translation file.
<trans-unit id="Codeunit<PHONE_NUMBER> - Method<PHONE_NUMBER> - NamedType<PHONE_NUMBER>" size-unit="char" translate="yes" xml:space="preserve">
  <source>label1</source>
  <note from="Developer" annotates="general" priority="2"></note>
  <note from="Xliff Generator" annotates="general" priority="3">Codeunit my_codeunit - Method p1 - NamedType lbl1</note>
</trans-unit>
<trans-unit id="Codeunit<PHONE_NUMBER> - Method<PHONE_NUMBER> - NamedType<PHONE_NUMBER>" size-unit="char" translate="yes" xml:space="preserve">
  <source>label2</source>
  <note from="Developer" annotates="general" priority="2"></note>
  <note from="Xliff Generator" annotates="general" priority="3">Codeunit my_codeunit - Method p2 - NamedType lbl1</note>
</trans-unit>

That being said, the Ids of a trans-unit is a hash of the names involved, which means that there can occur collisions. We have therefor included multiple elements to help avoid that situation. For instance in the example above.
Codeunit my_codeunit - Method p2 - NamedType lbl1
If you encounter such diagnostic the best recommendation I have for you is to rename the local variable inside the procedure


Add clean task

“Signed-off-by: Alina Pereskokova<EMAIL_ADDRESS>Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

The clean task has already been added in https://github.com/emc-mongoose/console/pull/41 and I've stated it via Slack. No need to duplicate I guess.

@mandarinSh Please close this if not needed