realtime doesn't seem to work with with xcframeworks.

not sure if it's a side effect of CLib change from swift-nio
sample app here
https://github.com/wweevv-johndpope/DemoBazel/tree/gotrue-swift
table is simple structure
    struct TestClass: Codable {
        var id: Int?
    }

I'm definitely on the right instance.
pqxcxltwoifmxcmhghzf
client connects successfully - I attempt to move subscription into the onOpen block - but no joy.

   let rt = RealtimeClient(endPoint: "https://pqxcxltwoifmxcmhghzf.supabase.co/realtime/v1", params: ["apikey": supabaseKey])
        rt.connect()
        rt.onOpen {

            let allUsersUpdateChanges =  rt.channel(.all)//rt.channel(.table("test", schema: "public"))
            allUsersUpdateChanges.on(.all) { message in
                print(message)
            }
            allUsersUpdateChanges.subscribe()
        }
        self.realtimeClient = rt

my bad - need to update readme to enable realtime updates for table.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/34247

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/60042

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/82837

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/87939

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/94764

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110994

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/111645


Report

txt template in docs
The design document should include
(a) a general overview of your system with a small user guide,
(b) a detailed design of your software with a focus on the components required to
deliver the major functions of your application,
(c) your testing strategy, and
(d) your group work break-down strategy.
Everyone at least needs to put down their time spent (an estimate) and progress made

testing strategy is likely just white-box unit testing.


Big improvements of the role. (Breaking changes)

Thanks for the PR.
Can you explain why you have removed the compatibility to Windows?

@lucasmaurice What are your motivations for the massive changes?


S3 Error Code: NoSuchKey when creating a custom Transformer with a lambda.Function

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.14.0
Amplify CLI Version
7.6.21
What operating system are you using?
Ubuntu
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
n/a
Amplify Categories
api
Amplify Commands
push
Describe the bug
When you write a custom transformer, and that transformer creates a lambda function using lambda.Function(), it fails with the above error.
Expected behavior
The lambda function should be added to the API stack.
Reproduction steps

Create a TS file with this content:

export default class CountTransformer extends TransformerPluginBase implements TransformerPluginProvider {
    constructor() {
        super("foo", "directive @foo on OBJECT");
    }

    transformSchema = (ctx: TransformerTransformSchemaStepContextProvider) => {
     generateResolvers = (ctx: TransformerContextProvider) => {
        const stack: TransformerNestedStack = ctx.stackManager.createStack("countResolverStack") as TransformerNestedStack;
        stack.setParameter(ResourceConstants.PARAMETERS.S3DeploymentBucket, Fn.ref(ResourceConstants.PARAMETERS.S3DeploymentBucket));
        stack.setParameter(ResourceConstants.PARAMETERS.S3DeploymentRootKey, Fn.ref(ResourceConstants.PARAMETERS.S3DeploymentRootKey));

        const func = new lambda_node.NodejsFunction(stack, "countResolverFunction", {
            projectRoot: __dirname,
            entry: path.join(__dirname, "resolver.ts"),
            handler: "handler",
            bundling: {
                forceDockerBundling: true
            }
        });
    };
}

Add this transformer by adding the path to ./amplify/backend/api/amplify/transform.conf.json
Add @foo to your schema
Run amplify push

GraphQL schema(s)

# Put schemas below this line

Log output
type Todo @foo {
  id: ID!
  name: String!
  description: String
}

Additional information
Full error message:
CREATE_FAILED      countResolverFunction7AFC8206                                                           AWS::Lambda::Function      Tue Feb 22 2022 22:28:15 GMT+1100 (Australian Eastern Daylight Time) Resource handler returned message: "Error occurred while GetObject. S3 Error Code: NoSuchKey. S3 Error Message: The specified key does not exist. (Service: Lambda, Status Code: 400, Request ID: 3de18d23-9099-48e2-af22-85ef678ff11c, Extended Request ID: null)" (RequestToken: ce29afe4-58ea-acbd-42b1-b2073e07ec93, HandlerErrorCode: InvalidRequest)
CREATE_FAILED      amplify-amplify-somedev-210332-apiamplify-REXGKFCZYMOU-countResolverStack-1JJTAEVS17RUX AWS::CloudFormation::Stack Tue Feb 22 2022 22:28:16 GMT+1100 (Australian Eastern Daylight Time) The following resource(s) failed to create: [countResolverFunction7AFC8206, QuerycountTodoResolver].

hey @multimeric, thank you for reaching out. apologies for the delay in a response. wanted to check and see if you are still experiencing issues. If so, could you please provide us the full example for your transformer.

Unfortunately I couldn't work out how to reproduce this issue, so I'm happy to close. Not sure if it's actually fixed, though.


Debugger doesn't stop on collectible errors

1. Describe the bug
Even when you have "breakOnError": "All" in launch.json, debugger still don't stop on the error statement if it is a collectible error.
There is an option to skip errors when they happen in TryFunction, but it is not obvious why debugger should skip collectible errors. Stop will only happen when you step out of collecting functions and after this it might still be hard to understand why you stopped there and where actual error has happened. Ability to skip collectible errors might be a usegfull option for breakOnError though. But not when All is selected.
2. To Reproduce

Copy code from learnign portal's example
Set "breakOnError": "All" in launch.json
Publish solution with debugger attached
Run PostWithErrorCollect action

pageextension 50100 CollectingErrorsExt extends "Customer List"
{
    actions
    {
        addfirst(processing)
        {
            // This action doesn't collect errors. Any procedure will stop on the first error that occurs,
            // and return the error.
            action(Post)
            {
                ApplicationArea = All;
                trigger OnAction()
                var
                    i: Record Integer;
                begin
                    i.Number := -9;
                    Codeunit.Run(Codeunit::DoPost, i);
                end;
            }

            // This action collects errors. The PostWithErrorCollect procedure continues on errors,
            // and displays the errors in a dialog to the user done.
            action(PostWithErrorCollect)
            {
                ApplicationArea = All;
                trigger OnAction()
                begin
                    PostWithErrorCollect();
                end;
            }

            // This action collects errors. The PostWithErrorCollectCustomUI procedure continues on errors,
            // and displays error details in a list page when done.
            // This implementation illustrates how you could design your own UI for displaying and
            // troubleshooting errors.
            action(PostWithErrorCollectCustomUI)
            {
                ApplicationArea = All;
                trigger OnAction()
                begin
                    PostWithErrorCollectCustomUI();
                end;
            }
        }
    }

    [ErrorBehavior(ErrorBehavior::Collect)]
    procedure PostWithErrorCollect()
    var
        i: Record Integer;
    begin
        i.Number := -9;
        Codeunit.Run(Codeunit::DoPost, i);
        // After executing the codeunit, there will be collected errors,
        // and therefore an error dialog will be shown when exiting this procedure.
    end;

    [ErrorBehavior(ErrorBehavior::Collect)]
    procedure PostWithErrorCollectCustomUI()
    var
        errors: Record "Error Message" temporary;
        error: ErrorInfo;
        i: Record Integer;
    begin
        i.Number := -9;
        // By using Codeunit.Run, you ensure any changes to the database within
        // Codeunit::DoPost are rolled back in case of errors.
        if not Codeunit.Run(Codeunit::DoPost, i) then begin
            // If Codeunit.Run fails, a non-collectible error was encountered,
            // add this to the list of errors.
            errors.ID := errors.ID + 1;
            errors.Description := GetLastErrorText();
            errors.Insert();
        end;

        // If there are collected errors, iterate through each of them and
        // add them to "Error Message" record.
        if HasCollectedErrors then
            foreach error in system.GetCollectedErrors() do begin
                errors.ID := errors.ID + 1;
                errors.Description := error.Message;
                errors.Validate("Record ID", error.RecordId);
                errors.Insert();
            end;

        // Clearing the collected errors will ensure the built-in error dialog
        // will not show, but instead show our own custom "Error Messages" page.
        ClearCollectedErrors();

        page.RunModal(page::"Error Messages", errors);
    end;
}

codeunit 50100 DoPost
{
    TableNo = Integer;

    trigger OnRun()
    begin
        if Number mod 2 <> 0 then
            Error(ErrorInfo.Create('Number should be equal', true, Rec, Rec.FieldNo(Number)));

        if Number <= 0 then
            Error(ErrorInfo.Create('Number should be larger than 0', true, Rec, Rec.FieldNo(Number)));

        if Number mod 3 = 0 then
            Error(ErrorInfo.Create('Number should not be divisible by 10', true, Rec, Rec.FieldNo(Number)));

        // Everything was valid, do the actual posting.
    end;
}

3. Expected behavior
Debugger stops on each error statement
4. Actual behavior
Debugger stops after PostWithErrorCollect finishes.
5. Versions:

AL Language: v13.1.1065068
Visual Studio Code:
Version: 1.92.2 (user setup)
Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
Date: 2024-08-14T17:29:30.058Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631
Business Central: 24.4
List of Visual Studio Code extensions that you have installed: AL

I'll accept this to be investigated in tandem with the runtime team.


AutofillGroup no longer fills relevant email/password with Flutter 3.19.2

Steps to reproduce
Apologies for not having a better code sample, but it requires registering a domain with an associated appID to function.
AutofillGroup in flutter 3.16.9 would give a prompt for password manager (1pass in this case), and once the password manager is unlocked, correctly suggest the autofill credentials specific to the app based on the registered domain hosted .well-known/apple-app-site-association file.
When making no changes to code, and only upgrading to flutter 3.19.2, AutofillGroup prompts for the password manager, but no longer attempts to autofill credentials specific to this app when unlocked. It instead gives a list of ALL the credentials stored in the password manager and requires you to search and select the correct credentials.
Please look at the screenshots for a before and after behavior difference, and please let me know if there is any other relevant information I can get to you, to help resolve this. If necessary, we would be open to pair with a flutter engineer if you are unable to repro this issue on your end.
Expected results
Usage of password manager is suggested, and when opened, autofills with credentials registered with the associated domain.
Actual results
Usage of password manager is suggested, but when opened, doesn't autofill with credentials registered with the associated domain.
Code sample
Code sample
 return AutofillGroup(
      child: Column(
        crossAxisAlignment: CrossAxisAlignment.stretch,
        children: [
          TreadTextField.email(
            controller: _emailController,
            labelText: l10n.email,
            enabled: !_sendingMagicLink && !_loggingIn,
            onChanged: (value) => setState(() {}),
          ),
          const SizedBox(height: 8),
          TreadTextField.password(
            controller: _passwordController,
            labelText: l10n.password,
            enabled: !_sendingMagicLink && !_loggingIn,
            onChanged: (value) => setState(() {}),
          ),
....

`TreadTextField` is `TextField` under the hood

Screenshots or Video

Screenshots / Video demonstration

Flutter 3.16.9
Flutter 3.19.2

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.19.2, on macOS 14.2 23C64 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc3)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.85.2)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.9, on macOS 14.2 23C64 darwin-arm64, locale
    en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc3)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.85.2)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

Hi @diego-tread
Which iOS device are you checking on? (OS, model). I checked this with my device iPhone 7, iOS 15.8 on both 3.19.2 and 3.16.9 but it always prompts password manager instead.

I'm using the iPhone 13 pro on 17.4 (21E219).
There is a bit of nuance to this issue. The password manager is prompted in both versions of flutter, but in 3.19.2, it doesn't know which password to use, while in 3.16.9 it does know. Take a look at my screenshots for reference.
I believe you must have this file setup on your website for this to work: .../.well-known/apple-app-site-association

It could be an issue on 3.10.6 as well since I saw the same issue at https://github.com/flutter/flutter/issues/135948. He also uses a lower iOS version iOS 15.7.7 (not sure if it's related). To ensure that this doesn't depend on a separate implementation on Dart side, could you try with this minimal sample code?

Sample code
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

class AutofillPage extends StatefulWidget {
  const AutofillPage({Key? key}) : super(key: key);

  @override
  State<AutofillPage> createState() => _AutofillPageState();
}

class _AutofillPageState extends State<AutofillPage> {
  final _formKey = GlobalKey<FormState>();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: AutofillGroup(
          child: Form(
            key: _formKey,
            child: Column(
              mainAxisSize: MainAxisSize.min,
              mainAxisAlignment: MainAxisAlignment.center,
              crossAxisAlignment: CrossAxisAlignment.stretch,
              children: [
                TextFormField(
                  decoration: const InputDecoration(labelText: 'Username'),
                  validator: (value) {
                    if (value == null || value.trim().isEmpty) {
                      return 'Please enter username';
                    }
                    return null;
                  },
                  autofillHints: const [AutofillHints.username],
                ),
                TextFormField(
                  decoration: const InputDecoration(labelText: 'Password'),
                  validator: (value) {
                    if (value == null || value.trim().isEmpty) {
                      return 'Please enter password';
                    }
                    return null;
                  },
                  obscureText: true,
                  autofillHints: const [AutofillHints.password],
                ),
                const SizedBox(height: 16),
                ElevatedButton(
                  onPressed: () {
                    final validated = _formKey.currentState!.validate();
                    if (!validated) return;

                    TextInput.finishAutofillContext();
                  },
                  child: const Text('Login'),
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}

Hello, looks like I'm seeing the same issue using your example. 3.16.9 works as expected and 3.19.2 still does not. Images for reference.
Flutter 3.16.9

Flutter 3.19.2

Thanks for checking. I also check this on iPadOS 17.2 but there is also only Passwords button there (without suggesting an account). Perhaps my setup has something corrupted with Associated Domains. Despite that, since this is reproduced on your end with minimal sample code, I will label this to get more input from others.

@diego-tread Associated Domains issue seems to be solved on my end. So I re-visited the Autofill issue but can't reproduce it on the latest Flutter stable channel 3.19.3. It works as expected on my device iPhone 7, iOS 15.8:

Demo
https://github.com/flutter/flutter/assets/104349824/7859acfa-82ab-4ee1-9caf-39d13e2368ce

Hello, I upgraded to Flutter 3.19.3 just now and tried again. Flutter 3.19.3 doesn't resolve the issue for me, and it's still only 3.16.9 that works as expected.
Any other ideas for things I can try, or things to give you to help triage?

CC @LongCatIsLooong from triage.

Hello @justinmc | @LongCatIsLooong | @huycozy
Is there anything else that I can provide to help triage this issue further and not let it become stale?
If you are unable to reproduce, I am more than happy to hop on a zoom call to pair.
Best

Any progress on these? Autofill has been broken for a while now, with lots of related bugs reports but nobody seems interested in fixing them. We've just had to roll back to 3.16.9 because of these issues which is real pain.

Same issue. Autofill was working fine 2 months ago. Now doesn't fill correctly on iOS.
It has various odd behaviors. I've seen:
1: Clicking suggestion fills both fields. TouchId check is given after already filled.
2: Choosing saved cred from list > TouchId check is made. But fields are left blank.
When fields are left blank, sometimes adding a character causes the fields to populate. But the typed character will be appended. Sort of as expected.

@LongCatIsLooong this is indeed a duplicate but the other issue is locked. And for some reason the fix was never cherry picked to stable.

Ah the fix was reverted. Feel free to open a new cherrypick request for the reland


Add ASCII-only option, to mimic default RE2 behavior

This is a workaround, motivated by the difference in handling non-valid UTF8
bytes that Oniriguma has, compared to Go's default RE2.
See https://github.com/src-d/enry/issues/225#issuecomment-490043281
Summary of changes:

use modern version of Oniguruma as it's well-maintained and is constantly improved
ci: test on latest 2 Go versions
c: NewOnigRegex() calls to onig_initialize() [1]
c: prevent NewOnigRegex() from hard-coding UTF8
go: expose new MustCompileASCII() \w default character class matching only ASCII
go: MustCompile() refactored, initRegexp() extracted for common UTF8/ASCII logic

Encoding was not exposed on Go API level intentionally for simplicity,
in order to avoid introducing complex struct type [2] to API surface.

https://github.com/kkos/oniguruma/blob/83572e983928243d741f61ac290fc057d69fefc3/doc/API#L6
https://github.com/kkos/oniguruma/blob/83572e983928243d741f61ac290fc057d69fefc3/src/oniguruma.h#L121

Signed-off-by: Alexander Bezzubov<EMAIL_ADDRESS>

CI is great and it's ready to be merged.
As I do not have rights neither to push to this repo, nor add reviews - \cc @kuba-- for a quick review.

Thank you for the prompt reviews! Feedback was addressed in last 2 commits and it's ready for another round.


Make useStderr a proper config value

I've used config.useStderr internally to divert stdout to stderr
so we can talk to the caller via json. Instead of having a one-off
config option, I'm making this an actual option with a consistent
behaviour.
Had to convert the InstanbulTestReporter into a proper class
so it can do proper inheritence.
cc @cpojer @DmitrySoshnikov

jshint issues are failing in master too, fixed here 5cad18949e6a2e8ee4d69bbcb790471b96abb59e

can you fix the jshint issues? Otherwise lgtm!
Once we go www first we should just drop jshint and use eslint with the www rules.  I fixed the jshint issues in master. So we should be good


FR: Alert when container is missing based on an expected list

Docker's restart policies won't save you if you accidentally bring down a container. It might be nice if container-mon can detect that and alert me based on a list of containers that should be there. On the other hand, I could see this being annoying if you bring down a service deliberately and you first have to update container-mon's config if you want to avoid alerts. I'm torn. Do you have any recommendations, thoughts, best practices?

Not sure if this would really fit in with container-mon as the Docker API won't return information about containers that have been removed, so then it would have to compare against some external list.

Makes sense. The external list is what I was contemplating. It would likely be very easy to implement (and I'd be happy to look into it myself), I'm just ping-ponging if it's a good approach or whether there's a better one.

You can do this with a one liner in a cron job though (docker ps | grep -q "my_container") || echo "Alert" where you can replace the echo "Alert" with your notification command or webhook

I do like your proposal. I guess it's more robust anyways, since you can apply the same strategy to container-mon itself. Replacing echo with the shoutrrr CLI I can even reuse the same config/change :+1:
Thanks mate!


support for android version of firefox?

I always assumed it just works, but apparently the most important API function is not implemented for Android, tabs.move See bottom of https://developer.mozilla.org/Add-ons/WebExtensions/API/tabs When this is implemented (if it will at some point), it should just work...


Adds new error image. Replaces card placeholder

This branch:

Adds a new error placeholder (already approved by @CartoDB/design; see image below).
Merges branch 224-preview-remove-table.

@CartoDB/frontend: could you review this, please?

Looks legit :+1:

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


SPF parser bug fixed in package dns-zonefile

Hello, I'm the maintainer of the package dns-zonefile. I saw this package is depending on a specific version (0.1.10) of dns-zonefile, which had serious bugs on parsing SPF and TXT records. The latest version has greatly improved the parsers and fixed all known bugs. Now it might be an option for you to update the dependency and move it on to the up to date version. Thanks.

Awesome! Thanks for the heads up @elgs
@stephenplusplus - can we take a look ?

@elgs thanks for opening an issue about this! I upgraded locally, but the latest version of dns-zonefile is breaking one of our e2e tests.
  1) dns Zones should import records from a zone file:

      Uncaught AssertionError: '"-all"' === '"v=spf1" "mx:gcloud-node.com." "-all"'
      + expected - actual

      -"-all"
      +"v=spf1" "mx:gcloud-node.com." "-all"

      at system-test/dns.js:205:22

It would seem that some of the values we're testing for are being stripped out. Would you be able to provide me with any clues as to why this might be happening?

@callmehiphop I know what's wrong. That does not mean the old version is anywhere near correct, because in the old version, the mx in the SPF record could fool the parse to parse it as a mx record if SPF is parse first. I will fixed and get back here soon. Thanks.

@callmehiphop I have released `dns-zonefile v0.1.18', which should have fixed the SPF parser problem. This release introduced a zone file resource record normalizer which eliminated assumptions of record format and sticks to the RFC1035. Would you please help run your test again and let me know if it works. Thanks.

@elgs that appears to have fixed it, thanks! I'll make a PR to bump the version of dns-zonefile shortly. Thanks again for opening this issue and for the quick fix! :+1:

Sure. Thanks @callmehiphop.


Added AccessTokenInterface

Added AccessTokenInterface. Providers can now override AccessToken and add their own information.
This is really important since some idps providers other information and properties for the AccessToken.

I understand the intent of this change but am not sure this is best solution. A possibly better way to do this would be to create a TokenFactory that gets injected into each grant instance and then used like so:
    public function handleResponse(array $response)
    {
        return $this->tokenFactory->create($response);
    }

After reviewing this again, I actually really like what you are suggesting, as it centralizes the token creation with provider while allowing the grant to modify it. I would keep the code you have, with one modification: change the interface name to TokenInterface for easier naming compatibility.

Also, this PR should be recreated against the master branch, as the 0.12.x branch is in maintenance mode.

Why can't the provider just have it's own AccessToken, which simply extends League\OAuth2\Client\Token\AccessToken?

Thank you so much for this, but I agree with @rtheunissen. Can providers just extend this, or is the interface needed?

It could be done by extension, but the point remains, it must receive an Access Token object
I just think the signature, which was
handleResponse($reponse = [])
that was changed to
handleResponse(AccessToken $token, array $response = null)
should be just:
handleResponse(AccessToken $token)
In fact, I don't even get why you should have the handleResponse if it's allways an Identity function. Are you previewing future developments where the handleResponse method will do more that it presently does?

it must receive an Access Token object

Just to be clear that we're on the same page, if you extend League\OAuth2\Client\Token\AccessToken, that extension also qualifies as its parent type, ie. you can pass your extending class to that method as an AccessToken.

Yes that is true. In facto we don't need that interface. I will refactor this proposal and attach a new one without the interface and simplifying all of these.

Thanks @lightningspirit :)

@lightningspirit, after you refactor, make sure you run phpcs before pushing your changes. The Travis build is failing on this pull request due to some coding standards violations. Refer to our contributing guide for instructions on what to run before pushing.
Thanks!

@lightningspirit Any chance you can submit your changes/refactor by tomorrow? I will be cutting 1.0.0-alpha2 tomorrow (see #362).

I am releasing 1.0.0-beta1 on Wednesday (15 July). At that point, I am freezing the API for 1.0, so that we can move forward with a stable 1.0.0 release soon. If you'd like this to be in 1.0, please submit your changes before Wednesday. Thanks!

I released 1.0.0-beta1 last week, and I'm closing this since the 1.0 API is now frozen.
Please feel free to open a new pull request against the master branch, and we can work this into a future 1.1 or 1.2 release.


Fixed typos and broken formatting, and restructured some sentences.

Applied @tallship 's changes as merged by @kjetilk earlier today so my earlier README improvements can be applied again without conflicts.

Oops, didn't catch that before, but it looks good.

Thanks for merging and accepting the PR @kjetilk :)


back button redirecting to page 1 -> should be based on previously

look into react-router history

clicking on header opens the nav menu, should be only the icon

solution:

introduced context -> central logic for resumes' state
header's only clickable if menu is open
empty layout when loading -> migrated logic to default layout so it's standardize


Drive pull retrieves empty sheets .csv - push of fresh non-empty local csv claims up to date

Hi,
I really tried to scour the docs to figure this out, but I'm not sure if what I'm seeing is a bug.  When I pull a non-empty sheets file from drive, I get an empty file (0 bytes).  If I try to locally create a non-empty csv and push it, drive simply says everything is up-to-date and appears to do nothing; doesn't update the sheets mime type file and doesn't create a new (different mime type) file on drive.
I found the option to specify a mime type for a new file, but I don't see a way to force mime type of an existing file and forcefully update the file on drive.
Any help would be greatly appreciated; been working on this for 2 days... :(

Also, by default, drive thinks everything is set to be ignored...  I created a .driveignore file and only put .gd in there, thinking that would cause it to ignore .gd and allow everything else, but that didn't work...
Some info on my setup:
go version go1.7.5 linux/arm
drive-google version
drive version: <IP_ADDRESS>
Commit Hash: <CURRENT_COMMIT>
Go Version: <GO_VERSION>
OS: <OS_INFO>
BuildTime:

Hello there @dyburke, thank you for the question and welcome to drive!
My apologies for the late reply.
So Google Sheets and Docs cannot be downloaded raw but rather exported, because they
are blobs that aren't directly exports by the Google Docs service. That file that you
see will always be empty on file before it is exported, so as to maintain consistency.
In order to export a file you'll need to pass in the output export types as comma separated
values, something like this:
drive pull -export odt,rtf,csv,tsv -explicitly-export <sheets_paths>

We talk about this in the README here:

https://github.com/odeke-em/drive#exporting-docs under section Pulling
https://github.com/odeke-em/drive#desktopentry under section DesktopEntry

Sorry, I wasn't clear as to what my end goal was.  I would like to push a csv file, but push it in the sheets format so that other sheets can reference it. This is all I'm really attempting to accomplish; could you recommend a way to do that? -export doesn't appear to function with a push command.

Yeah, Google Docs and Sheets do not support reading or writing directly to those files.
Unfortuntely, no way around opening them to edit in the WebUI.
The other option you could do though is use the convert flag, but that barely works
$ drive push thisFile.csv -convert

and before we had a request for this issue from Google APIs but I think one of the PMs
closed it as non-actionable, I don't think there was anything they could do about it
The issue was https://github.com/odeke-em/drive/issues/232 and the Google APIs request was at https://code.google.com/a/google.com/p/apps-api-issues/issues/detail?id=4198.

Gah! This is such bad news. :(   Thank you for the help, @odeke-em ! Hopefully, they correctly implement the convert call since they never gave us a client at all... :/  I starred the issue and plan to share the tweet.  Thanks again!

Hi @dyburke, I also had a similar setup where I needed to reference a CSV from another one. Since Google did not want to fix this issue, I went for a workaround.

Push the file without any conversions.

Open your Google Drive and get a shareable link for the file

Now, create a Google Sheet and (on cell A1 of the sheet) use the IMPORTDATA function to import data from your csv file into this spreadsheet. Typically the function call looks like this:
=IMPORTDATA("https://drive.google.com/uc?export=download&id=YOUR-CSV-ID-GOES-HERE")

This will import all the data from CSV. Now, you can start working with this sheet. This is a feasible workaround in my case, but YMMV. Hope this helps.
Caution: If you follow these instructions, the CSV file will have a public URL and if anyone gets hold of that URL they can access the contents. So, do not use this method if the contents of the file are important/critical/secret etc..

@canpolat Thank you!!  I was poking around IMPORTDATA to work around this issue too, but I couldn't get my hands on the proper url to download the csv.
It is indeed a shame that I have to sacrifice security to make this work, but it's good enough for now.  Hopefully the drive team takes the feature req seriously and throws us a bone...


Hook bleeps the bleeps

Signed-off-by: Daniel Lin<EMAIL_ADDRESS>

fixed issue #9 , job well done


Subtitles won't download

Good evening all,
After fixing lots of problems, I hope this is the final one.
When I open the subtitle tab, there is a list of subtitles I can choose from.
After selecting one I get the message the downloading failed.
What's going wrong?
https://paste.kodi.tv/adekaxexez.kodi

Please, try version 0.0.66.
There are some changes to searching episodes and shows.

Alright I will try soon, can I manually update by selecting the addon in Kodi?

The problem with subtitles is that Kodi not support WinRAR 5 version, only version 3. And if subtitles are archivated with highest than version 3, Kodi cannot extract them.

Not sure there is something to help with. We get subtitles from Opensubtitles, download the file and give it to Kodi.

May be he use other subtitles source, like subsunacs and subssab for bulgarian subtitles, where subtitles are archived.

No I use opensubtitles to download Dutch subtitles

@Jwaarsenburg try the latest version of Elementum.

updated, still doesn't work. This time I use a older movie with English subs... https://paste.kodi.tv/lanuliwudi.kodi

Strange error. Your system could not download this subtitles file: https://dl.opensubtitles.org/en/download/src-api/vrf-19c60c5b/sid-MfFtSPelKXUtohqTyId8Aq5ycC0/file/1955186249.gz
I can download it. Do you have any firewall or something?

I also have the same problem with v0.6.6, on Kodi 18 RC2, Android TV. I was downloading english sub for Venom movie from opensubtitles

I'm having the similar problem. Downloading from "Elementum" subtitle service gives error. I installed OpenSubtitles addon and it works just fine.

@vonhutuan @frozentrone would be much helpful if someone shares log file and not just write something that cannot be reproduced.
http://elementum.surge.sh/contribute/log/

@Jwaarsenburg @martinstz @vonhutuan @frozentrone If you want this to be fixed - I need log files that show what happens on your system.
I open movie/episode, open subtitles tab, in providers I open "Elementum", then I get list of found subtitles, select any and it's done, I see subtitles.

@elgatito I'll get the log file when I get a chance. Thanks!

Kodi 18 (Leia) removed support for RAR files from base system, now it has a separate addon for dealing with RAR files. You need to look for it in AddOns menu and install it (sorry, I can't remember which section it is located)

Kodi 18 (Leia) removed support for RAR files from base system, now it has a separate addon for dealing with RAR files.

@gabiruh  There is still no evidence about this case. The only log shows Kodi was not able to download file (which I can download). And I have Kodi 18 and subtitles gets downloaded well by Elementum, because elementum is un-zipping it, before giving to Kodi.
I can't reproduce why file was not unable to download. Maybe it's firewall or something, now allowing to download archive, don't know.
There is no response in this issue, and if noone answers - I will close it.

I am not able to test it right now, because I'm away for a few weeks. I will try again when I come back and share my log. If you want to close it in the meanwhile, I'll make a new one later.

The issue somehow resolved on its own after I selected a path for download.

The issue somehow resolved on its own after I selected a path for download.

this is because elementum saves subtitles into Subtitles directory inside the download directory so it should exist and be writable

	subtitlesPath := filepath.Join(config.Get().DownloadPath, "Subtitles")
	if _, errStat := os.Stat(subtitlesPath); os.IsNotExist(errStat) {
		if errMk := os.Mkdir(subtitlesPath, 0755); errMk != nil {
			subLog.Error("Unable to create Subtitles folder")
		}
	}

Ir is created if needed.

i meant that download directory should exist and be writable (like the code says). thanks.

Please, use v0.0.71.
Even with non-set directory subtitles download should work.

Closing, as got no updates.

So any possible solution? I have set a download path in the settings. Even set a torrent path.
Could you see anything in the log file that could help?
Thanks

@KillerJoeBR I have no idea why it does not work for you:
2019-04-07 07:35:59.109 T:31773  NOTICE: [plugin.video.elementum] [GIN] 2019/04/07 - 10:35:59 | 200 |  1.006493385s |       <IP_ADDRESS> | GET      /subtitle/1956270196?action=download&dl=https%3a%2f%2fdl.opensubtitles.org%2fen%2fdownload%2fsrc-api%2fvrf-19ba0c57%2fsid-k4aQAxOdBDfr8tJyHqlNvSm-C%2c3%2ffile%2f1956270196.gz&file=Bumblebee.2018.1080p.BluRay.x264-SPARKS.srt&fmt=srt&lang=pob&doresume=false
2019-04-07 07:35:59.123 T:32715   DEBUG: onExecutionDone(38, /storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.elementum/navigation.py)
2019-04-07 07:35:59.124 T:32584   ERROR: OnDownloadComplete - Saving of subtitle /storage/emulated/0/Download/Subtitles/Bumblebee.2018.1080p.BluRay.x264-SPARKS.srt to /storage/sdcard0/Download/Subtitles/links..srt failed

@elgatito
I think the problem is that it tries to download the subtitle always using the same filename "links..srt".
It works the first time but in the next time it can't overwrite the last file links..srt maybe because it is still in use somehow.
I think a possible simple solution if you can somehow make the filename to be numbered each try. Like first time links 1.srt
Then  links 2.srt, links 3.srt .... Etc... Etc
Would that be possible? Or Random generated? Perhaps this way it can always write the filename without failing
Thanks

2019-04-07 07:35:59.124 T:32584   ERROR: OnDownloadComplete - Saving of subtitle /storage/emulated/0/Download/Subtitles/Bumblebee.2018.1080p.BluRay.x264-SPARKS.srt to /storage/sdcard0/Download/Subtitles/links..srt failed

This is NOT done by Elementum.
Elementum gives subtitles url to Kodi, everything else done by Kodi.

Maybe a different folder for each subtitle? Using the filename of the torrent or something like that. Just some ideas...

2019-04-07 07:35:59.124 T:32584   ERROR: OnDownloadComplete - Saving of subtitle /storage/emulated/0/Download/Subtitles/Bumblebee.2018.1080p.BluRay.x264-SPARKS.srt to /storage/sdcard0/Download/Subtitles/links..srt failed

This is NOT done by Elementum.
Elementum gives subtitles url to Kodi, everything else done by Kodi.

And the name "links" is not something it gets from elementum?

And the name "links" is not something it gets from elementum?

No. It is taken from stream url.

Why while using opensubtitles addon it works fine?
For movie files where the opensubtitles get results normally I can download the subtitle without issues

Like I said there are 2 different problems that are related.
First elementum can't download the subtitle the second time. Using opensubtitles it works fine.
Second problem is that elementum does not give the right info to the subtitles Add-ons and they can't find results. Mostly this issue is with TV episodes. Movies usually works

If I delete the links.srt file then elementum subtitle addon works. But then I need to delete it again for each use.
Can I bind some key in my remote to delete the subtitle folder? Or a shortcut or something like that? This way it would fix the problem temporally till find a better solution.

I guess you can check kodi wiki, maybe it is possible to bind a key to run a script (.sh).
Also it would be interesting to see permissions of that file. E.g. ls -la , ls -Z , stat , fuser , lsof on that file in terminal.

Thanks, but I tried searching for a way to map a key to do this but I didn't get any viable results. Perhaps it's too complicated. No idea how to create a script to do that either.

First of all third is not really a solution.
Try to run commands i stated before in any terminal program (e.g. ls -la /path/to/links.srt)
But if you want to implement this workaround, then:
Google for something like "kodi key to run script"
https://kodi.wiki/view/Keymap look for system.exec or runscript.
Simple shell script would be like
#!/bin/sh
rm /path/to/links.srt

@antonsoroko
Thanks I will try this later. I need to go out for the day (family stuff). At night I will try it.
I appreciate your help. This script example you gave me I can just type it in the keymap or I need to create a script file and save it somewhere inside kodi? It looks too advanced for me.
Anyway thank you

I tried the ls terminal command
-rw-rw---- root

I need to create a script file and save it somewhere

yes. i guess even download folder could work - e.g. Downloads/del_sub.sh. (if not, then probably your android has security features enables like selinux and it will be to tedious to explain options)
just google for something like "kodi key to run script" for examples
but anyway, this is not okay, i, for instance, don't have this issue . what device do you use? what is  android version?

-rw-rw---- root

you ran ls -la /storage/sdcard0/Download/Subtitles/links..srt , right?
it should produce a longer line
also please try lsattr /storage/sdcard0/Download/Subtitles/links..srt

@antonsoroko @KillerJoeBR I will try to test some ideas this week, but cannot guarantee it will help with subtitles' providers. Each provider is using own logic for getting played item information.

Ok I tried creating the script and executing it with a key but for some reason it is not working. For now I am using an addon to clear cache and custom paths. But it is not ideal cause it is not automate. I need to do it manually.
Thanks for looking this issue @elgatito. If you can at least make opensubtitle addon to work than it would be great. I and I guess a lot of people use it most of the time.
Thanks

Please try with 0.1.25.
There are changes regarding OSDB:

OSDB is not working anonymously.
Links changed to don't have "links/play".
Auto-download option added.

@elgatito
Thanks. I will try it and report back.
But in the downloads section the new version doesn't have an arm release. Seems to be missing something for a proper release? Maybe it's too soon? I will wait a little longer

Yup. It was too soon. There is a proper download now. I will try it

Ok my initial analisys.
The subtitle seems to be working much better now. It shows the name of the file you are watching and I get more results with another providers like opensubtitles and others.
So I guess this one is fixed.
But I think I'm getting worse download speed now. It's not always. Seems more unstable. Like sometimes it's reconnecting lots of times. So it doesn't gain momentum and better speed.  But maybe it's the new torrents that I am trying. Need more testing

Ok further testings and the download speed seems to be fine. I guess it was my internet provider was slow at the time or maybe the torrent didn't have good seeds.
Anyway everything looks fine now.
Thanks @elgatito for your work

Closing this specific issue.


Release fails with Build tools version 35.0.0-rc3

I believe aapt dump badging changed format in how text is printed on console which is causing the break.

Fixed by #276


fix routes order

Requests to SigningCertURL are currently handled by actionHandler instead of pemHandler because of wrong routes order. This PR fix this issue.

Nice catch - Would you mind writing a unit test to test these routes?

I have never written in GO before XD, but I'll try.

@p4tin Could you please update the image on  Docker Hub?


not update lighthouse ips if dns lookup failed

Can you please describe the purpose of this change? In #1183 you stated it resolved some issues. Can you describe the issues this change resolved?
My understanding of the code here is that if DNS resolution fails, it may be seen as a "different" list of IPs than resolved previously. However, the results of this function are prepended to the overall cache here: https://github.com/slackhq/nebula/blob/16eaae306afe95ac9876e333fc1636c98cd999a4/lighthouse.go#L565-L569
In other words, I don't think a failure to resolve will end up removing any previously successfully resolved queries. Given that that is the case, I'm not sure I understand what this PR is attempting to fix.

Can you please describe the purpose of this change? In #1183 you stated it resolved some issues. Can you describe the issues this change resolved?您能否描述一下此更改的目的？在#1183 中，您表示它解决了一些问题。您能描述一下此更改解决的问题吗？
My understanding of the code here is that if DNS resolution fails, it may be seen as a "different" list of IPs than resolved previously. However, the results of this function are prepended to the overall cache here: 我对这里代码的理解是，如果 DNS 解析失败，它可能会被视为与之前解析的“不同”IP 列表。然而，该函数的结果被添加到此处的整体缓存中：
https://github.com/slackhq/nebula/blob/16eaae306afe95ac9876e333fc1636c98cd999a4/lighthouse.go#L565-L569
In other words, I don't think a failure to resolve will end up removing any previously successfully resolved queries. Given that that is the case, I'm not sure I understand what this PR is attempting to fix.换句话说，我认为解决失败不会最终删除任何以前成功解决的查询。鉴于这种情况，我不确定我是否理解此 PR 试图解决的问题。

I apologize, the PR and issue mentioned different situation, both related to DDNS, so they were linked together. Here is log section and why submit this change.
Jul 12 03:24:25 node nebula[2115492]: level=error msg="DNS resolution failed for static_map host" error="lookup foo.bar.com: i/o timeout" hostname=foo.bar.com network=ip4
Jul 12 03:24:25 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[]" origSet="&map[<IP_ADDRESS>:11010:{}]"
Jul 12 03:24:55 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[<IP_ADDRESS>:11010:{}]" origSet="&map[]"
Jul 12 03:38:55 node nebula[2115492]: level=error msg="DNS resolution failed for static_map host" error="lookup foo.bar.com: i/o timeout" hostname=foo.bar.com network=ip4
Jul 12 03:38:55 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[]" origSet="&map[<IP_ADDRESS>:11010:{}]"
Jul 12 03:39:25 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[<IP_ADDRESS>:11010:{}]" origSet="&map[]"
Jul 12 03:43:55 node nebula[2115492]: level=error msg="DNS resolution failed for static_map host" error="lookup foo.bar.com: i/o timeout" hostname=foo.bar.com network=ip4
Jul 12 03:43:55 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[]" origSet="&map[<IP_ADDRESS>:11010:{}]"
Jul 12 03:44:25 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[<IP_ADDRESS>:11010:{}]" origSet="&map[]"
Jul 12 04:05:55 node nebula[2115492]: level=error msg="DNS resolution failed for static_map host" error="lookup foo.bar.com: i/o timeout" hostname=foo.bar.com network=ip4
Jul 12 04:05:55 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[]" origSet="&map[<IP_ADDRESS>:11010:{}]"
Jul 12 04:06:25 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[<IP_ADDRESS>:11010:{}]" origSet="&map[]"
Jul 12 04:30:25 node nebula[2115492]: level=error msg="DNS resolution failed for static_map host" error="lookup foo.bar.com: i/o timeout" hostname=foo.bar.com network=ip4
Jul 12 04:30:25 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[]" origSet="&map[<IP_ADDRESS>:11010:{}]"
Jul 12 04:30:55 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[<IP_ADDRESS>:11010:{}]" origSet="&map[]"
Jul 12 04:31:55 node nebula[2115492]: level=error msg="DNS resolution failed for static_map host" error="lookup foo.bar.com: i/o timeout" hostname=foo.bar.com network=ip4
Jul 12 04:31:55 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[]" origSet="&map[<IP_ADDRESS>:11010:{}]"
Jul 12 04:32:25 node nebula[2115492]: level=info msg="DNS results changed for host list" newSet="map[<IP_ADDRESS>:11010:{}]" origSet="&map[]"

Based on the above, it appears that DNS queries are fluctuating—sometimes there is an ip, and other times times out.
This might be related to UDP traffic in the environment. However, since this is happening in virtual machine, I'm not sure how to investigate further, so handle the error if dns query failed.

@yylt Thanks for explaining. Indeed it looks like half of the DNS queries in the log are failing. That being said, the failing lookups should not be overriding the successful lookups in the cache Nebula uses to find hosts (which is a separate list from the one referenced in origSet.)
One way to verify this is to enable the debug SSH server and then issue the list-lighthouse-addrmap following a failed DNS query. You should still see the IP address present.

Since the nebula at this node is already on the version that merged the PR, the issue has not recurred up to now, which has been around 50 days.
Additionally, the DDNS changes approximately once a week, requiring SSH to be opened and checked after address change. It is unlikely to be feasible in the short term.

@yylt Understood that you're unable to test currently, but this PR doesn't appear to solve any issues and the code as written creates undesirable behaviors (such as a single DNS lookup failure causing successful queries to be discarded.) Thanks for the contribution, but I'm going to close the PR.


[DCOS-40974] Mesos checkpointing support for Spark Drivers

Reference PR#51
What changes were proposed in this pull request?

added boolean configuration property spark.mesos.checkpoint
spark.mesos.checkpoint is used when drivers are submitted to Dispatcher

How was this patch tested?

unit test verifying that spark.mesos.checkpoint is respected
Integration tests from mesosphere/spark-build

Release notes

Added Mesos checkpointing support for Spark Drivers submitted to Dispatcher

This PR is just for reference, so final and effective change has been moved to #69.


Compare GPTQ group sizes at 4bit

-1 vs 32 vs 64 vs 128

With exl2 quants readily available in a larger range of bpw, the few % difference between these is not worth considering.


fix: chrome date

We can temporarily fallback to ja-JP.
This issue is tested in Chrome 89 / Safari 14.0.3

Current:

其实这个问题v8 9.0（chrome 90）已经修复了，现在revert还是到时候revert就看你们了（
> yarn eshost -e 'new Date().toLocaleString("zh-CN", { hour12: false })'
#### V8 8.6
2021/3/19 20:24:47

#### V8 8.7
2021/3/19 20:24:47

#### V8 8.8
2021/3/1920:24:47

#### V8 8.9
2021/3/1920:24:47

#### V8 9.0
2021/3/19 20:24:47

#### V8 9.1
2021/3/19 20:24:47

Done in 0.63s.

This issue is caused by an upstream bug of v8 engine, and is fixed in its latest commit.
This issue also impacts Node.JS v15.
https://github.com/unicode-org/icu/blob/3333fd557c398c98805f1ffdc63df796dc2bdcbd/icu4c/source/data/locales/zh.txt#L1995
https://github.com/unicode-org/icu/commit/3333fd557c398c98805f1ffdc63df796dc2bdcbd


Pretrained model plus several code updates

This PR is mostly to upload a pretrained model to the core Tiny repo, but there are also several miscellaneous code updates in the AWW code.

I just merged a PR from Nat today that did some reorganization and renamed the benchmarks/ folder to training/
Can you rename your benchmarks/ folder locally and add that change? I think that should resolve the merge conflict.
Sorry for the annoyance!

@jeremy-syn when you have time can you resolve the merge conflict?

Colby,
I think I have resolved the merge conflicts.  Do I need to re-submit the PR?
Jeremy
On Mon, Feb 15, 2021 at 9:56 AM Colby Banbury<EMAIL_ADDRESS>wrote:

@jeremy-syn https://github.com/jeremy-syn when you have time can you
resolve the merge conflict?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mlcommons/tiny/pull/25#issuecomment-779274076, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ARN3UFK7YH2EK2VHA5BPQ4DS7EY3FANCNFSM4XPVC3JQ
.

--
Jeremy Holleman
Chief Scientist @ SYNTIANT
SYNTIANT
7555 Irvine Center Drive,
Suite 200
Irvine, CA 92618
M: +1<PHONE_NUMBER>
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Oh I missed that you fixed it. Thank you!
You've signed the CLA correct? We may need to connect your CLA to your github

Yes, I've signed the CLA.  Do you know how to connect it to my github
account?  I thought it already was, but I guess not.
On Mon, Feb 15, 2021 at 12:37 PM Colby Banbury<EMAIL_ADDRESS>wrote:

Oh I missed that you fixed it. Thank you!
You've signed the CLA correct? We may need to connect your CLA to your
github
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mlcommons/tiny/pull/25#issuecomment-779366633, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ARN3UFJFKC62PZVOSYPD7FLS7FLTZANCNFSM4XPVC3JQ
.

--
Jeremy Holleman
Chief Scientist @ SYNTIANT
SYNTIANT
7555 Irvine Center Drive,
Suite 200
Irvine, CA 92618
M: +1<PHONE_NUMBER>
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Is the same email connected to your github account? That could be the issue.
Otherwise, I think we need to contact<EMAIL_ADDRESS>to resolve this

Sorry for the delay, looking into this now.

I have sent my CLA to ML Commons Admin. Hopefully this is resolved soon.

recheck


Rue89 failed with error 0

Error message: The requested resouce cannot be found! Please make sure your input parameters are correct!
Query string: action=display&bridge=Rue89&format=Atom
Version: dev.2018-10-15

Confirmed. Thanks for reporting!
Looks like http://api.rue89.nouvelobs.com/ is no longer available: http://www.isitdownrightnow.com/api.rue89.nouvelobs.com.html

{"error":{"title":"Resource not found","message":"The requested resource could not be found","type":"NotFoundException","code":404}}
When trying https://api.nouvelobs.com

Should be fixed by 110b865.


remove auth from some endpoints

The basic auth is now removed from some endpoints:
https://github.com/Open-EO/openeo-grassgis-driver/issues/18

for /collections and /collections/{name} the authentication is taken from the config

Looks good, please merge

I changed the base branch to master as we can use these changes in v0.4 as well.


[FEATURE 💡]

Description
On the homepage the get started button could instead be used to scroll down to the course cards part.
Wanna Work upon[y/n] ??
y

Please assign it to me. I want to work on it.


Stroom in Docker not picking up external doc ref types

This is set via a CSV property, which it should then use to build external doc ref entity services.

Environment variable names can't include hyphens


Centos install issues

I had some install pains on a plain, fresh built centOS7 on AWS:
normal instructions:
clone the repo
git clone git@github.com:duo-labs/cloudmapper.git
(Centos, Fedora, RedHat etc.):
sudo yum install autoconf automake libtool python-dev jq
cd cloudmapper/
at this point I had to run:
curl "https://bootstrap.pypa.io/get-pip.py" -o "get-pip.py"
pip install virtualenv
then I could continue
virtualenv venv
source venv/bin/activate
pip install -r requirements.txt
then it bombed out with a python error, so I had to run
yum install python-devel
In summary, I had to run the additional commands at any time before the command "virtualenv venv"
curl "https://bootstrap.pypa.io/get-pip.py" -o "get-pip.py"
pip install virtualenv
yum install python-devel

Makes sense, my instructions assumed pip and virtualenv were already installed, which is rarely the case in a new setup.  I'll add some guidance around that.

Also (stupid centos) for the collect_data.sh script to work I had to run:
yum install epel-release
yum install jq

For the python cloudmapper.py script to work I had to run:
pip install pyjq
pip install netaddr
I'm determined to get this to work!  :)

It's beautiful!
Thank you.

Yes, on Centos it seems there is no python-dev, only python-devel https://centos.pkgs.org/7/centos-x86_64/python-devel-2.7.5-58.el7.x86_64.rpm.html

Thank you. Resolved in https://github.com/duo-labs/cloudmapper/commit/11565c9171f6d086eb6fabbbe44f7074a93c725c


Z-Wave???????????

Home Assistant release (hass --version):
0.65.3
Python release (python3 --version):
3.5.3
Component/platform:
Z-wave
Description of problem:
After upgrading to 0.65.3, Z-Wave sensors got renamed, or left un-named.
Component/platform:
Z-Wave
Description of problem:
Z-wave Motion and Sensors un-named
Expected:
To stay as was before upgrade
Additional info:
Z-Wave sensors listed as:
zwave._
zwave.__2
zwave.__3
zwave.__4
zwave.__5

search the issues for zwave entity registry. Also please pick useful titles

These sensors were added and renamed in 0.64.3 and kept there names up until 0.65.2, it's only after upgrading to 0.65.3 they lost there names, is this renaming process going to be the case with each update?

@balloob
Not sure what's going on, just downgraded to 0.64.3. and everything is as it was prior to 0.65.3


[5261] Prevent update to trainee after award

Context
Add a guard clause to not allow trainees to be updated from hesa once they are awarded.
Changes proposed in this pull request
Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Prevent any HESA changes to a trainee after the trainee is in a state of 'awarded'


Spinner should support layout props

It's props current just extend HoistProps, so if you want to set something like width or height, you'll get linter errors since TS doesn't know that we pass the props through to the img element. Supporting layout props on Spinner is probably the best way to go, we don't think it is necessary to support other img element props

Woops -- just merged Colin's change to actually support all image props.
Do we want to roll that back -- @cnrudd, @haynesjm42?

https://github.com/xh/hoist-react/commit/dafef9cc8ff10a2


Deepstack invalid image

Describe the bug
Deepstack is now returning invalid image on almost all of my images that are automatically added to the folder. When copying and pasting the same image back in it works perfectly
Log entries
Automatically added image
trigger_1       | 2020-07-07T13:25:55+01:00 [Trigger Front Door] /aiinput/FD_12-25-48.jpg: Analyzing deepstack-ai_1  | [GIN] 2020/07/07 - 12:25:55 | 400 |   15.225609ms |      <IP_ADDRESS> | POST     /v1/vision/detection trigger_1       | 2020-07-07T13:25:55+01:00 [Trigger Front Door] Error: Failed to call DeepStack at http://deepstack-ai:5000/: {"success":false,"error":"invalid image"} trigger_1       | 2020-07-07T13:25:55+01:00 [Trigger Front Door] /aiinput/FD_12-25-48.jpg: Analysis failed
Copy and Pasted identical image
trigger_1       | 2020-07-07T15:01:18+01:00 [Trigger Front Door] /aiinput/FD_12-25-48 copy.jpg: Analyzing deepstack-ai_1  | [GIN] 2020/07/07 - 14:01:25 | 200 |  7.193620498s |      <IP_ADDRESS> | POST     /v1/vision/detection trigger_1       | 2020-07-07T15:01:25+01:00 [Trigger Front Door] /aiinput/FD_12-25-48 copy.jpg: Found at least one object in the photo. (7181 ms)
Installation details

macOS Catalina
Docker Desktop

Additional context
I believe the problem occurs because the program is sending the images too quickly after they have been placed into the folder not allowing enough time for it to completely save. I have recently received telegrams that include images that are half grey that i previousy mentioned in  #187
Here's someone else with the Deepstack error: https://github.com/robmarkcole/HASS-Deepstack-object/issues/83
I assume Deepstack is reading the image as "blank"
Would a delay function fix this?

Just found awaitWriteFinish in the settings.json schema 🚀
Sorry to keep "bugging" you


I've written a batch represent script

Wrote this a month ago, people have been requesting it.
Thanks!

I'm trying to have as few scripts as possible the require maintenance, but if you move this one to the tmp directory I will be happy to merge it. Thanks!

@davidsandberg I've moved it over to tmp
Thanks!

Thanks!


Support Round Function Ibis - DuckDB

https://github.com/substrait-io/substrait/pull/322

Made an issue to add missing options for our ROUND function
https://github.com/duckdb/duckdb/issues/6806

out of date, closing.


CB-9865 Better simulator detection for iOS

https://issues.apache.org/jira/browse/CB-9865

@purplecabbage please have a look, this fixes build failure on older versions of XCode


fixed typo in instructions.md

Proposed changes
Fixed a typo in instructions.md. ( #405 )
Types of changes
Improve the Documentation.

Coverage remained the same at 96.499% when pulling 7d05803c0f5b951e200272f5accd7c56db8f25d0 on cc-haugge:patch-1 into 2646b0c8abd74bd0e198bd10b03bcd4812056033 on adonisjs:develop.

Thanks 😄


Ubuntu, Kubernetes (https://github.com/artur9010/charts/tree/master/renterd)
Autopilot Config
x
Bus Config
x
Contract Set Contracts
x
Anything else?
No response

This issue is caused by the new route pattern for buckets and files:
/buckets/bucket_name/files/path/to/directory
which generates an html entry point like:
/buckets/[bucket]/files/[[...path]].html

The special nextjsRouter static http.Handler does not support the param + catch all combo: https://github.com/SiaFoundation/web/blob/main/ui/ui.go
It needs to work for this sort of case: https://github.com/SiaFoundation/web/commit/c8795ebf96b24bb7fe2e8011947982aa4bf43833#diff-797a8ca0587dda82ce75e0a8c8a5b08207d68ca17ee1dfbe1b4d33e6ba0af258R205-R206
@n8maninger is this is a difficult change? I am not familiar with that magical code 😅


README.md: Add sections for bash/zsh completion

Installation guide for bash/zsh completion.

Good to go?

Yes, if you would like to do "Squash and merge", don't forget to clear the auto-generated description.


PHP syntax checking doesn't work

When saving a php file with errors in it, the plugin doesn't work properly. The error message appears in the error list displayed by the :Errors command but the error line number is not displayed in the status line; instead, [syntax:0] is displayed. Also, the error signs are not displayed either.
I tried the plugin with a ruby file and it works perfectly.

I have finding that syntastics always says Syntax: line:0 (1) for the status warning value. When I run php -l on command line this is the output
Parse error: syntax error, unexpected T_FUNCTION in app.php on line 21

Errors parsing app.php

It looks like this should be greped correctly according to syntastic's php.vim but for some reason isn't or further down the line is being messed up


Deploy server hookup

Oh btw :shipit: when the logs are relocated.

@rafkhan this is looking good with the exception of the one deleted comment

:shipit:


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2022-10-13)
Features

Artisan command to assign a role to a user (#91) (1025964)

Miscellaneous Chores

deps: bump laravel/framework from 9.34.0 to 9.35.1 (bdcfca2)
deps: bump laravel/framework from 9.34.0 to 9.35.1 (#89) (c2a37be)
deps: bump postcss from 8.4.17 to 8.4.18 (da27fdb)
deps: bump postcss from 8.4.17 to 8.4.18 (#92) (1f62c7d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/rotex1800/registration/releases/tag/v1.1.0 :sunflower:


added comments feature

@skashish-sps Added comments to the frontend and connected it to servlet API. I created a new servlet file called CommentsServlet.java, instead of using the existing DataServlet.java. Is this alright? Here's the website link.
Todos:

[ ] Some server-side validation and checks.
[ ] Avoid refreshing page on submit.

@skashish-sps The PR shows already merged commits, but creating a new PR seems to remove that issue. So closing this. Here's the new one. Resolved reviews, except JDO, I'll give it a look. Also added server-side validation.


Server and incoming-endpoint support

vcabbage currently only acts as a client, and does not support incoming lines
Add support for listening on a server socket and accepting incoming links and sessions (for both client and server connections)
PR coming shortly to show a proposed API.

Awesome! :+1:

Work on this is starting in #178


Cannot read property 'default' of undefined during test

Hello.
I created a react app via create-react-app and I am trying to test it but i have an issue.
Here is my json.package file

{
"name": "frontend",
"version": "0.1.0",
"private": true,
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^1.2.8",
"@fortawesome/free-solid-svg-icons": "^5.5.0",
"@fortawesome/react-fontawesome": "^0.1.3",
"@material-ui/core": "^3.1.2",
"axios": "^0.18.0",
"bootstrap": "^4.3.1",
"cors": "^2.8.4",
"dotenv": "^5.0.1",
"email-validator": "^2.0.4",
"eosjs": "^16.0.9",
"google-maps-react": "^2.0.2",
"history": "^4.7.2",
"ipfs-http-client": "^28.1.1",
"jquery": "^3.3.1",
"jwt-decode": "^2.2.0",
"node-sass": "^4.9.3",
"npm": "^6.4.1",
"nstall": "^0.2.0",
"object-assign": "^4.1.1",
"postcss-flexbugs-fixes": "^3.3.0",
"postcss-loader": "^2.1.6",
"promise": "^8.0.1",
"qrcode.react": "^0.8.0",
"query-string": "^6.1.0",
"rc-steps": "^3.3.0",
"rc-time-picker": "^3.3.1",
"react": "^16.3.2",
"react-app": "^1.1.2",
"react-bootstrap-datetimerangepicker-edited": "^2.0.8",
"react-bootstrap-table": "^4.3.1",
"react-bootstrap-table-next": "^1.4.1",
"react-datepicker": "^2.4.0",
"react-dev-utils": "^5.0.2",
"react-dnd": "^2.6.0",
"react-dnd-html5-backend": "^2.6.0",
"react-dom": "^16.3.2",
"react-dropdown": "^1.4.2",
"react-error-overlay": "^4.0.1",
"react-facebook-login": "^4.1.1",
"react-google-login": "^5.0.0",
"react-google-recaptcha": "^1.0.5",
"react-helmet": "^5.2.0",
"react-jss": "^8.6.1",
"react-modal": "^3.6.1",
"react-password-strength": "^2.4.0",
"react-redux": "^5.0.7",
"react-router": "^4.2.0",
"react-router-dom": "^4.3.1",
"react-scripts": "3.0.0",
"react-select": "^1.2.1",
"react-show-more": "^2.0.0",
"react-tagsinput": "^3.19.0",
"react-test-renderer": "^16.8.6",
"reactstrap": "^6.0.1",
"sass-loader": "^7.1.0",
"socket.io": "^2.1.1",
"style-loader": "^0.21.0",
"url-loader": "^1.1.1",
"uuid": "^3.3.2",
"validator": "^10.7.1",
"whatwg-fetch": "^2.0.4"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject",
"fix": "eslint --fix src"
},
"jest": {
"collectCoverageFrom": [
"src//*.{js,jsx}",
"!/node_modules/**"
]
},
"eslintConfig": {
"extends": "react-app"
},
"devDependencies": {
"css-loader": "^2.1.1",
"eslint-config-airbnb": "^16.1.0",
"eslint-plugin-import": "^2.11.0",
"eslint-plugin-node": "^6.0.1",
"eslint-plugin-promise": "^3.7.0",
"eslint-plugin-react": "^7.7.0",
"eslint-plugin-standard": "^3.0.1",
"img-loader": "^3.0.0",
"stylelint-config-standard": "^18.2.0"
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
}
}

and here is my test which is very simple

import React from 'react';
import ReactDOM from 'react-dom';
import { App } from '../containers';
it('renders without crashing', () => {
const div = document.createElement('div');
expect(3).toBe(3)
});

so when run test i have the following error

TypeError: Cannot read property 'default' of undefined

  at Object.get [as EmailSender] (src/routes/index.js:65:25)
  at Object.EmailSender (src/index.js:37:22)
  at Object.<anonymous> (src/functions/getSettingsDataFromStore.js:1:1)
  at Object.<anonymous> (src/routes/register/RegisterDescription.js:9:1)
  at Object.<anonymous> (src/routes/index.js:6:1)
  at Object.<anonymous> (src/functions/getAvailableRoutes.js:4:1)
  at Object.<anonymous> (src/components/Navbar.js:4:1)
  at Object.<anonymous> (src/components/index.js:6:1)
  at Object.<anonymous> (src/containers/App.js:4:1)
  at Object.<anonymous> (src/containers/index.js:1:1)
  at Object.<anonymous> (src/tests/App.test.js:3:1)

When I remove the import { App } from '../containers'; the test runs succesfully.
Any idea? Thank you in advance

And we don't know what's inside App and EmailSender. This is likely issue with your code node testing environment, please ask for help on Discord or Stack Overflow

@NikosCha I am getting the same issue. I think jest is not supported naming export. If i go through the default export then it work's. Let me know, if you find any solution for this error.

I am having the same issue, Till now according to my finding I see the error is because of naming import/export
like in my code I have

import  { toJS } from '../toJS'

if I change to export default toJS and import like below

import toJS from '../toJS'

I don't get the error for this.
But converting all named export to the default export won't be possible for my project as the project is old and big in itself.
File toJS.js
const toJS = WrappedComponent => wrappedComponentProps => {
     // code here
}

export {
  toJs,
  // ....
}

Though I am not very sure if I am missing something here.

I had the same problem, but my solution wasn't that straight forward. I had a "rogue export", that was called from just about everywhere.
In the same file, I had a React component which was the default export. The component didn't have any relation to that "rogue export".
My problem occurred every time I tried to use anything outside the scope of the "rogue export". My guess is that it triggered some kind of circular dependency - I don't exactly know tbh.
The solution was to isolate the "rogue export" in it's own file.
Finding the export is pretty easy. It's the one that tries to call the function/const/import that is undefined.

@NikosCha have you been able to resolve this issue? If so, care to share how? I'm also running into the same issue

The issue can be caused by hidden circular dependencies


Error when validating prdoc in a PR that introduce a new crate

In this PR https://github.com/paritytech/polkadot-sdk/pull/6140 I introduce a new crate in the workspace.
the semver check using parity publish is failing with:
 validating prdocs...
checking file changes...
checking dep changes...
Error: no dep

Stack backtrace:
   0: parity_publish::prdoc::get_dep
   1: parity_publish::prdoc::manifest_deps_changed
   2: parity_publish::prdoc::handle_prdoc
   3: parity_publish::main::{{closure}}
   4: tokio::runtime::park::CachedParkThread::block_on
   5: tokio::runtime::context::runtime::enter_runtime
   6: tokio::runtime::runtime::Runtime::block_on
   7: parity_publish::main
   8: std::sys::backtrace::__rust_begin_short_backtrace
   9: std::rt::lang_start::{{closure}}
  10: std::rt::lang_start_internal
  11: main
  12: __libc_start_main
  13: _start

https://github.com/paritytech/polkadot-sdk/actions/runs/12111543947/job/33763614902?pr=6140

I had the same issue and I think this is could be fixed by this: https://github.com/paritytech/parity-publish/pull/43

Also that PR fixes when removing crate


Add missing targetLabels default value

serviceMonitor object refers to targetLabels, which does not exist in values.yaml. No harm there, but it should be added to values.yaml with its default empty slice value.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@frederiko please run nix develop -c task generate to fix the failing test. kminion's README.md is out of date.

@frederiko please run nix develop -c task generate to fix the failing test. kminion's README.md is out of date.
✅ Haven't really done via nix, but I suspect all checks should now pass.


question on the block table

https://github.com/Dao-AILab/flash-attention/blob/478ee666cccbd1b8f63648633003059a8dc6827d/tests/test_flash_attn.py#L2066
Could you elaborate more on the block table argument here? I am trying to find an example to show how flash_attn_with_kvcache should be used. Specifically, why user needs to care about the logical block/physical block mapping when passing the KV cache since it is updated in place by this function? How should we construct the block table based on the KV shape? I assume the block table shape is dependent on the KV shape only.

You can read the function docstring
https://github.com/Dao-AILab/flash-attention/blob/478ee666cccbd1b8f63648633003059a8dc6827d/flash_attn/flash_attn_interface.py#L1492
Typically this is used with a cache manager (e.g. in vLLM) that manages when to allocate & free the blocks and construct the block table. Such cache manager is not implemented here since it depends on how you build the inference engine.

Where can we find a better example to show us how to use this API with block table?
For example, in vLLM (0.6.1.post2) what does it mean by having a block_table with value
tensor([[127],
        [126],
        [125]], device='cuda:0', dtype=torch.int32)

?
In this case, the prompt for the model gpt2 is
prompts = [
    "Hello, my name is",
    "The president of the United States is",
    "The capital of France is",]

and
sampling_params = SamplingParams(temperature=0, top_p=1, top_k=1,max_tokens=1024)

You can read the test code (https://github.com/Dao-AILab/flash-attention/blob/641db759ab7168e472909bc9ff1eda4a329de34f/tests/test_flash_attn.py#L1907) to see how block table is used. Setting breakpoint and printing out values could be helpful

Thanks. I found the answer.

A follow-up question :
I need to know more about the seq_len usage inside the function you previously pointed out
https://github.com/Dao-AILab/flash-attention/blob/641db759ab7168e472909bc9ff1eda4a329de34f/flash_attn/flash_attn_interface.py#L1547
which will in turn execute this cuda kernel:
https://github.com/Dao-AILab/flash-attention/blob/641db759ab7168e472909bc9ff1eda4a329de34f/csrc/flash_attn/flash_api.cpp#L1241
(confused about this comment which says batch_size in the comment about seq_len)
To your knowledge, is it possible to use cuda-gdb to debug this test? If not, how do you normally set break-point and print in it? (don't want to add print and then recompile)
cuda-gdb --args pytest -v tests/test_flash_attn.py::test_flash_attn_kvcache

The tests should fully describe the usage.
I always add print and recompile

I.e the tests compare the output of the cuda kernel w a reference impl. You just need to trace through the ref impl (in PyTorch) to know how block table is used.

I see that it is comparing the result from flashAttn with the one from the ref attention impl using pytorch (e.g. softmax followed by the torch.einsum).
Why tracing through this ref impl helps understanding block_table and cache_seqlens? They are not used there.
I updated the issue title to point out the confusion I have when using the flash_attn_with_kvcache in case there is any confusion caused by my earlier question. My intent is to construct the appropriate k cache and v cache so they can be used by  flash_attn_with_kvcache


Kapacitor / Bosun

As a long-time InfluxDB customer, I'm hopeful about the futures of these new tools -- Telegraf, Chronograf, Kapacitor.  How does the vision / capabilities for Kapacitor differ from Bosun which is another alerting daemon from Stack Exchange?  What other alerting daemons are influencing the design of Kapacitor?

Kapacitor's vision is much broader than just an alerting framework. Kapacitor's goal is to be able to provide rich ways of detecting and triggering events from the data it is processing but then leaving the heavy lifting of managing the alert workflow (acknowledge, comment escalate, etc.) on third party tools like VictorOps and PagerDuty.
As for other tools out there almost all of them have influenced Kapacitor in some way, Apache Storm, Flink, Spark, Riemann, and Bosun to just name a few.

Thanks for the insight.


Clarify documentation

If you need to support IE8, do you need both versions? Or just the setimmediate-ie8.js?
I'm confused because the IE8 version actually looks smaller so I don't see why the non-IE8 version needs to exist?

If you need to support IE8, do you need both versions? Or just the setimmediate-ie8.js?

You need to use both versions to support IE8 and other browsers. IE8 version must be included first.
If you want all-in-one solution, you can use YuzuJS/setImmediate. It also use the script.onreadystatechange event for IE8.

I'm confused because the IE8 version actually looks smaller so I don't see why the non-IE8 version needs to exist?

Because the postMessage works faster than the appending of a <script> in the DOM tree.
But the use of the postMessage results in a stack overflow in IE8.


Minus API's access token response is invalid?

I don't know where is the right place to write this issue. Sorry if I writing some thing odd.
I am writing Minus API wrapper for iOS5, and I think there is an error in access token response.
When I request for access token to minus, the server response is like this
{"access_token": "brabra",
 "token_type": "bearer",
 "expire_in": 86400,
 "refresh_token": "brabra",
 "scope": "read_all upload_new"}

In this response, I think the key expire_in is missing trailing "s".
In the IETF's spec at 4.1.4. Access Token Response,
expires_in
     OPTIONAL.  The lifetime in seconds of the access token.  For
     example, the value "3600" denotes that the access token will
     expire in one hour from the time the response was generated.

I found this issue because when using a third party OAuth2 library, they will not parse this parameter.
Please close & ignore this issue if this a known issue. Thanks.

Hi Attila
Can you look into this
Best Regards,
John Xie
Co-Founder
http://minus.com | http://john.minus.com
http://blog.minus.com | @mindotus
On 2/25/12 9:45 AM, ISHITOYA Kentaro wrote:

I don't know where is the right place to write this issue. Sorry if I writing some thing odd.
I am writing Minus API wrapper for iOS5, and I think there is an error in access token response.
When I request for access token to minus, the server response is like this
 {"access_token": "brabra",
  "token_type": "bearer",
  "expire_in": 86400,
  "refresh_token": "brabra",
  "scope": "read_all upload_new"}

In this response, I think the key expire_in is missing trailing "s".
In the IETF's spec at 4.1.4. Access Token Response,
 expires_in
      OPTIONAL.  The lifetime in seconds of the access token.  For
      example, the value "3600" denotes that the access token will
      expire in one hour from the time the response was generated.

I found this issue because when using a third party OAuth2 library, they will not parse this parameter.
Please close&  ignore this issue if this a known issue. Thanks.

Reply to this email directly or view it on GitHub:
https://github.com/minus-development/MinusAPI/issues/30

HI,
thank you! It's been fixed, there's an expires_in field from now on.
Cheers,
Attila Maczak
On Mon, Feb 27, 2012 at 12:35 PM, John Xie<EMAIL_ADDRESS>wrote:

Hi Attila
Can you look into this
Best Regards,
John Xie
Co-Founder
http://minus.com | http://john.minus.com
http://blog.minus.com | @mindotus
On 2/25/12 9:45 AM, ISHITOYA Kentaro wrote:

I don't know where is the right place to write this issue. Sorry if I
writing some thing odd.
I am writing Minus API wrapper for iOS5, and I think there is an error in
access token response.
When I request for access token to minus, the server response is like this
{"access_token": "brabra",
     "token_type": "bearer",
     "expire_in": 86400,
     "refresh_token": "brabra",
     "scope": "read_all upload_new"}
In this response, I think the key expire_in is missing trailing "s".
In the IETF's spec at
4.1.4. Access Token Response,
expires_in
         OPTIONAL.  The lifetime in seconds of the access token.  For
         example, the value "3600" denotes that the access token will
         expire in one hour from the time the response was generated.
I found this issue because when using a third party OAuth2 library, they
will not parse this parameter.
Please close&  ignore this issue if this a known issue. Thanks.

Reply to this email directly or view it on GitHub:
https://github.com/minus-development/MinusAPI/issues/30

Hi,
I've confirmed that there is a filed "expires_in" in access token response.
Thank you for the fix!


Allow adding multiple login IDs

@carmenlau Are you testing using SDK example in Chrome?

I tried calling the api with http client directly, let me try in SDK too.

I found I configured my http client incorrectly, the apis work! Thanks @kiootic


Upgrade Ruby

I have not used Ruby a lot, so I can't say for sure this works without breaking anything, but it seems to work. I was on a version before this commit and instead of downgrading I upgraded to the latest version of ruby and jekyll, which required a fresh lockfile.
Also added the webrick dependency since it originally failed with the following error solved with this thread
bundler: failed to load command: jekyll (/usr/local/bundle/bin/jekyll)
<internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require': cannot load such file -- webrick (LoadError)

Only issue I seem to have left with the docker is that when you ctrl-c it freezes and I have to manually stop the container in another terminal, but this might just be my machine.

Hi Rover @rvandernoort , thanks for the contribution! I really appreciate it. If that's ok, I'll look into it later this week. Cheers, L.

Only issue I seem to have left with the docker is that when you ctrl-c it freezes and I have to manually stop the container in another terminal, but this might just be my machine.

This is due to -it (--interactive --tty) not being included in the docker run command; without it, the container can't hear your Ctrl+C :–)


Fix issue of volume metadata is not saved correctly

What this PR does / why we need it:
This pr will solve the issue of #625. By the way, this pr should be backported to stable/bali branch which has the same problem.
Which issue this PR fixes:  #625
Special notes for your reviewer:
Release note:

Coverage decreased (-0.01%) to 38.564% when pulling 6aa508deb329741c12b23cd1bb98d82da5231eb3 on wisererik:development into 453c372509f27fabb6f1d4a9961c74929424c287 on opensds:development.


Hacktoberfest-password-Crediability-29-Top-secrets

the changes which I have  done for password Validation is added a new function inside the  register.ejs file for password validation using regex. And for the backend part app.post method is used and inside that regex function is used for the same process so that user is unable to register with invalid format of password.
alert call has been made when user tries to register with invalid format. No console.logs have been added.
This might help . Please have  a look.

Thanks for your valuable contribution.
Don't forget to star the repo.


Suppress Geocoder API warning when no results are returned

Took a shot at fixing this warning, hopefully I'm doing this right. The Geocoder API warning occurs in the test_no_results unit test, where no results being returned is the expected behaviour. Added a warning suppression line based on prior example.

Thanks! This is the correct way to suppress the warning, but issuing a warning for a simple zero-results response doesn't seem like the right behavior (no other lookup does it, and getting no results does not necessarily mean an error occurred). I think the next step is to examine why the lookup is raising an error, and whether it's doing so appropriately (and if it is, let's use a different query to test for no results, because we shouldn't need to suppress warnings in tests unless we're testing something for which we expect a warning to occur).

Awesome thanks!
Note: other lookup tests that use Geocoder.search('no results') worked because there is either a test fixture for the lookup (ie test/fixtures/lookup_name_no_results) or test_helper.rb overrides the result method of the lookup and sets return [] if query = 'no results'


Adding version numbers to vsimporter and xib2nib

This is my initial attempt at versioning vsimporter and xib2nib. The shared release version number has to be manually incremented and resides in build\winobjc.version.

:shipit:

:shipit:

:clock1:


[Figma] adapt / improve the component Drawer to allow fluid size

Based in this Slack thread

[x] Figma
[ ] Zeroheight spec

Can we discuss this one soon ?  If we do it, it might require adding it to Dialog to be consistant. I noticed also that most DS chose not to have a fluid size.
Right now all our sizes are already "fluid" in that when the screen get smaller, it will adapt, but not the other way around. fluid  can be weird for web for example on a drawer in left/right position, because html content naturally take as much width as they can, so a simple long paragraph in a drawer with size="fluid"  and side="right"  would result in a fullscreen drawer for example. I think that's why it's not very popular.
Also the maximum height/width of a drawer can already be customized as it is today.

Yes! Let's discuss this in the next Specs Reviews session.
I'll add it as topic

We will add fluid size, the need from design is only for bottom and top drawers
We might allow but discourage the use of fluid size in left and right
We will not provide this prop in Figma for side drawers
We decided back ago not to have Bottom sheets because
Specific to mobile
Performance issues
etc

Update on ZH: url
Update Figma spec: url

👍
On Tue, 30 Jan 2024 at 10:09, Turo López Sanabria @.***>
wrote:

Closed #1802 https://github.com/adevinta/spark/issues/1802 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/adevinta/spark/issues/1802#event-11638527341, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BBL3VXZIU5Y37K2HWGBGXS3YRC2FHAVCNFSM6AAAAABBROC232VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGYZTQNJSG4ZTIMI
.
You are receiving this because you were assigned.Message ID:
@.***>


consolidate add-edit-duplicate modals

Opening as draft, is dependent on the backend updates Ben has made, but otherwise should be good for review.
This consolidates the ADD, EDIT, and DUPLICATE modals into a common template modal UpsertFeatureFlagModal, as they are nearly identical except for a couple of straightforward params.
This adds the DUPLICATE modal to the FF details menu. The only actual difference between ADD and DUPLICATE is the title and we add _COPY_CHANGE_ME to the name and key.

This one is merged with backend changes and works like a charm now for Add - Edit - Duplicate, ready for review @zackcl @Yagnik56 @Yagnik56

If this is good other than some styling can we merge? would be easier to complete the story i'm currently working on. @zackcl @Yagnik56

If this is good other than some styling can we merge? would be easier to complete the story i'm currently working on. @zackcl @Yagnik56

can u resolve that deriveInitialFormValues function cmt, I can approve it later.


Add lookback <IP_ADDRESS>.g5e60c5a

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] If the sha256 changed but the version didn’t,
provide public confirmation by the developer: {{link}}

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Closes https://github.com/caskroom/homebrew-cask/issues/34493

Thank you for the contribution. It was merged directly as 8192e466ba2bf0e3ac3684ce8149d1f7b6366f22. Your contribution is still credited to you.


Option to revert modified interface string translations to Base

Problem Statement
Sometimes you need to update a string in an interface file that has already been translated. This necessitates updating the that string in all translations. However, interface strings are keyed to the object ID, so if the object itself doesn't change then bartycrouch only seems to update the comment, but leaves the actual localisations untouched. This requires developers to be extra careful in auditing the changes
Suggested Solution
Bartycrouch seems able to detect that the string has changed in the Base localisation by the fact that it updates the title. It would be useful if there was a configuration option to also have it replace the localised string with the new Base localisation, as the localised string is likely now invalid. This would make it easier for translators to see that the string needs to be re-translated
Example Usage
You have a button titled "Delete" in a NIB with translations in multiple languages. You update the button in the NIB to "Remove". The next time you run bartycrouch update all strings files for that NIB get updated with "buttonID.title" = "Remove", replacing any previous translations for buttonID.title.
Possible Involvement

I could help with implementation: Depending on time I could take a look at implementing this myself, though likely not in the near future
I could help with testing: Once implemented I could assist with testing on my current project to ensure it works

@pilky Thank you for this idea. But I do not understand how this is useful yet. For example, in your above "example usage" you are updating the "Delete" base translation to "Remove". Imagine the German translation was "Löschen" before you made the change. I don't understand how it's any useful now to replace the German "Löschen" with the English "Remove" value.
The reason we update the comment is exactly the purpose you are asking for: Translators can then see the updated English term. But what workflow do you have that it would be more useful to replace a valid translation with an updated base value?

@Jeehut Comments are easier to overlook, partly by being comments, but mostly by being in the same language before and after the change.
The reason for wanting the string translations to be reverted to Base is that it is a bigger "error" and so easier to see. The translator doesn't need to check every string in the file each time and make sure the translations are still valid, they just need to look for untranslated strings.
They'll also show up when you build and run the app, which means developers and QA can more easily find any changed strings that haven't been updated. You don't need to know the language the app is running in to find an untranslated string, but you do need to know it to find a string that hasn't been updated (on top of knowing it was updated in the Base locale).
Essentially it makes the process of translating the same for both new and changed strings (i.e. look for what isn't translated)

@pilky Thank you for explaining that to me, it does make more sense to me now. So what you're asking for is only relevant if you use Base-translation, which is not used directly in the first place. And what you want as an option is something like a "override all translations with base value if base changes", right?
This should be possible and I would accept a PR that implements this and documents the new option in the README. Feel free to tackle it if you have the time to. To me, it currently seems like a very specific workflow that smaller companies don't need and most larger companies handle in a different way, e.g. by using a proper translation service where they can mark a specific translation as "needs review" in such a situation. Therefore I will not put much energy into this myself, but I would review any related PRs. :)

@Jeehut Thanks. Unfortunately I don't have time to implement it right now but it's good to know you're open to the functionality.


Improve compilation times on Windows

Thank you for the very useful library!
Few improvements:

Better header hygiene
Isolate windows.h to .cpp whenever possible
Use WIN32_LEAN_AND_MEAN
Remove unused headers

Tested on Windows with
cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=1
  -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS="-ftime-trace -Wall -Wextra -Wpedantic
  -Wno-ignored-attributes" -DCMAKE_COLOR_DIAGNOSTICS=1 -DCPPTRACE_BUILD_TESTING=1
  -DCPPTRACE_BUILD_BENCHMARKING=0

There's a lot more that can be improved if you are interested.

Looks like some CI is failing, unfortunately one of the hard things about developing this library is how much code can't be tested on a single platform. Happy to help however I can.

@jeremy-rifkin: could CI be retriggered'

@jeremy-rifkin: and again please :)
If possible, could you make CI not require approval until this PR is merged? I need to iterate a bit to figure out what includes are missing on various platforms.

I’ll look to see if I can set it to not need approval, sorry for the iteration hassle

I’ll look to see if I can set it to not need approval, sorry for the iteration hassle

Seems like approval is still required :(

Sorry for the hassle here, I think the setting is correct now. I can take a stab at getting things correct later too.