Introduce tracing as a feature flag

Is your feature request related to a problem? Please describe.
Downstream crates that use hyper have feature flag tracing using which users can choose not to download tracing library  or use tracing.  Ex: octocrab has this feature. Even though octocrab has this feature tracing, the tracing library anyway gets downloaded since hyper is a dependency of octocrab and hyper downloads tracing libraries by default.
Describe the solution you'd like
Hyper to hide tracing behind a feature flag. That way, downstream crates that use hyper can choose not to have tracing if needed.
Describe alternatives you've considered
Downstream crates start using tracing by default
Additional context
By allowing tracing as a feature flag, users can opt out of tracing and avoid having to download tracing related libraries

It would be nice. As part of #2874, we'll move tracing to an unstable feature in 1.0. We can't move it to a feature in 0.14, since it could suddenly mean tracing is disabled for people who have default-features = false.

This was done as part of v1.


ClassNotFoundException when using retrolambda.jar at command line.

Here's my stack trace (and runtime output): https://gist.github.com/perezd/f3c98350dba15e975a46
For background, I'm using the following command:
/usr/bin/java \
-Dretrolambda.inputDir=/tmp/in_classesdir \
-Dretrolambda.outputDir=/tmp/out_classesdir \
-Dretrolambda.classpathFile=/tmp/classfiles.txt  \
-javaagent:retrolambda-2.1.0.jar  \
-jar retrolambda-2.1.0.jar;

Any idea what I'm doing wrong here? Its probably my fault, just not sure what I did wrong.

The problem is the classpath. Instead of listing all files in it, you must list the directory that contains those files. The /tmp/classfiles.txt file should contain just the line /tmp/in_classesdir (and paths to the JARs of any third-party libraries).

oh shoot. OK I think I see what you mean. Yeah, that wasn't entirely clear from the docs. Will try again. Thanks!

I tried what you recommended and that fixed it. THANK YOU! Great project!

So, I actually have this classpath problem again, but this time with Android libraries.
I've added this jar to the classpathfile: http://mvnrepository.com/artifact/org.robolectric/android-all/5.1.1_r9-robolectric-1
And I've confirmed that this jar as android.app.IntentService but I continue to get this error:
Caused by: java.lang.ClassNotFoundException: android.app.IntentService
What can I do to diagnose this further?

Does every .class file (of even dependencies) need to be in the inputDir?

OK I just answered my own question, it apparently does need them all. Why does classpath exist at all then?

Nevermind me, this is a bug with bazel.io's sandboxing compiler. Sorry for the spam!!


Beta/1.10.0

What
Auditting process wrapped up, all endpoints covered, as well as vendor in changes to authentication and identity packages which include auditting attempts when users are not authenticated.
Also includes:

Fix to closing of request body (e.g. drain request bodies)
Set publish flag on instance node

How to review
Final check of changes make sense and both unit and acceptance tests pass.
Who can review
Anyone

Tests pass, looks good to go 👍


HandInteractionPanZoom is Input, not UI namespace

HandInteractionPanZoom should be in the UI namespace, to match BoundingBox and ManipulationHandler

could you add explanation why this is a GA blocker

@julenka

I consider it an issue with the usability of our API that a class that's clearly a UI component lives in the Input namespace. Changing the namespace in a future release would be a breaking change, so I'm concerned with putting this off until after GA.

Removing myself from this issue since I'm currently out, hopefully we can assign it to somebody else while I'm out. This is an easy fix, doesn't require any UX or input knowledge.


In cases where AssemblyInfo is being preserved and there are multiple…

… AssemblyInfo files present (very common in GitVersion implementations where there is a single common AssemblyInfo file containing version info and an AssemblyInfo file containing library specific details), AssemblyDetails will be null (multiple files not currently supported) but there is no null check in NuGetPackageTransformation. Added null propagation on the assemblyAttributes object. If time allows I will add support for multiple assemblyinfo files but at a minimum this fixes the null reference exception when assembly info details are being preserved.

@jlegan regarding your wish to improve support for shared (common, global) assemblyinfo files. They are already supported (I regularly test the project on ConfuserEx and Dopamine, both have shared assemblyinfo files). The degree of that support however is minimal: preserve all assemblyinfo files, do not read information from them. I introduced such behavior back in #139, to not to introduce errors during conversion. There aren't much things that can be done to improve the situation (or they are quite complicated).

Read all assemblyinfo files and transform read properties into includable MSBuild project with a single PropertyGroup.
Read shared assemblyinfo files and add specific properties (e.g. GenerateAssemblyCompanyAttribute) for each shared property

Note, that these require making a lot of assumptions about the structure of the project. E.g. in ConfuserEx the shared assemblyinfo file might not exist at the time of conversion (it is being generated during build process by one of the projects being built).
Thanks you for your contribution, I can't believe such bug existed and wasn't noticed before.


Prototype Kit site stopped deploying automatically

The site used to deploy on merge to master but no longer does, might be related to the change to main but I think the issue may predate that slightly

I've confirmed that this automatic deploys work now 🙌


Update recaptchalib.php

The array index in Line 133 needs quotes to prevent an error message. It should be ['error-codes'] instead of [error-codes].
Thanks!

Duplicate of #1 (and many other PRs), can you close this PR?

Fixed in v1.1


Added gold theme

@matteobruni I have added a gold color theme. I am good at UI but I was unable to test the colors as I could not find how to setup the entire project in my local system.
And I tried with gitpod.io but for some reason the changes did not reflect when I selected existing themes as "orange", "purple". The UI showed everything in white.
Please review and let me know if there's any more changes I have to do. Also, if you could guide me setup and view my local changes that would be nice. :slightly_smiling_face:
This PR is for #36

Hi @NitinNair89,
I just fixed those themes, they were missing in the editor.scss file.
To test the project just yarn && yarn start the first time and yarn start every time you need to test it.
If you make changes to the editor and not the test app you can just run yarn build in another terminal and refresh the page.
The demo app runs on http://localhost:3030

Thank you so much @matteobruni :smiley:
Let me fix the issues for my PR, will let you know.
Can you prepare one CONTRIBUTING file so beginners like me can understand how/where to make changes for theme contributions? :slightly_smiling_face:

Yes indeed, I'll work on that soon

The theme is missing from editor.scss

I added entry for gold theme. Please review.

I am sorry. My latest commit went with my office account. Anyway to discard it? @matteobruni

I'll squash merge it so it won't appear in history, once a commit is pushed there's no way to revert it as far as I know

I'll squash merge it so it won't appear in history, once a commit is pushed there's no way to revert it as far as I know

Thank you @matteobruni
I will try to contribute more themes, this looks interesting to me :slightly_smiling_face:


Ignore legacy keys when caching keys on startup

When AcraServer starts and loads all the keys into cache (if the option is enabled), ignore old keys related to AcraConnector.
Add new key kind "legacy" and ignore this key if found inside keystore.
TODO:

[ ] Same thing for AcraTranslator

Checklist

[ ] Change is covered by automated tests
[x] The coding guidelines are followed
[ ] Public API has proper documentation in the Acra documentation site or has PR on documentation repository
with new changes
[ ] CHANGELOG.md is updated (in case of notable or breaking changes)
[ ] CHANGELOG_DEV.md is updated
[x] ~Benchmark results are attached (if applicable)~
[ ] Example projects and code samples are up-to-date (in case of API changes)

TODO:

add integration tests that checks that acra works correctly with old keys and logs about existing legacy keys.


fix space removal

Codecov Report

Merging #224 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #224   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines          69     69
  Branches        8      8
=====================================
  Hits           69     69

Impacted Files
Coverage Δ

lib/stringValueCleaner.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e223c5...cd91b2a. Read the comment docs.


unicode_string collapses repeated characters

Using 0.5.1 on Windows 10, the following code types abc:
use tfc::{traits::*, Context, Error};

fn main() -> Result<(), Error> {
    let mut ctx = Context::new()?;
    ctx.unicode_string("aabcccc")?;
    Ok(())
}

ascii_string works as expected.

I’m not able to reproduce this problem in a Windows 10 VM. Perhaps the application that’s receiving input is doing the collapsing? I used Notepad to test this. Can you provide some more information?

I've pushed a fix for this. Repeating characters are indeed repeating for me in Notepad and Command Prompt. Can you confirm that this is working on your end?

Yep the fix works for me. Thanks!


Ocelot in Production Environment

Hi,
congratulations for this project!!
I did a little project with ocelot and two apis and all works fine in development, but when I publish the solution in production (with IIS) and I access to some reroute always return 404 not found. My api+ocelot has the default ValuesController (that creates Visual Studio by default) and works fine but the reroutes didn´t work in production.
It´s neccesary some special kind of configuration in the server?
Thanks.

@player84
Thanky you very much.
I am currently just using kestrel as the webserver without IIS. You might need to do something like this to get Ocelot working behind IIS. https://weblog.west-wind.com/posts/2016/Jun/06/Publishing-and-Running-ASPNET-Core-Applications-with-IIS
Hope this helps.

@TomPallister
Yes, I followed that steps (but by the microsoft web). My two Api´s are working. The problem it´s only than the reroute doesn´t work in production. I have two api:
Api1: it´s the api (in net core) that contains Ocelot (and contains also a TestController with GET method that return a string). In the configuration.json I have a reroute to redirect request to Api 2.
Api2: it´s a simple api (in net core) with a TestController with GET method thant return a string.
In develop works fine but in production, Api 2 work fine while in Api1 only works the TestController and not the reroute of the configuration.json.

@player84 @TomPallister
Hi,
I had the same problem. I don´t know the reason but the IIS AppPool must have all grants over your app folder. You must go to your ocelot app folder in inetpub and add all permissions for your AppPool.
Follow the steps of this Microsoft´s tutorial: https://docs.microsoft.com/en-us/aspnet/core/publishing/iis (in section Application Pool Identity) and restart your IIS with running the command "iisreset" in the cmd like administrator. (Remember, only needed over your ocelot api folder).
It worked for me.
Hope this helps.

@juancash thanks for the info! Much appreciated.

@juancash @TomPallister
It works.
Thanks!!!!


Ref inference doesn't work when passing a callback function

Not sure if that's by design, but there's a difference in ref inference behavior:
Code
class Example extends Component {
  notWorkingRef = el => {
    // el is implicit any
  }
  render() {
    return

 {/* el is properly inferred here */}} />

  }

Expected behavior:
It should infer notWorkingRef parameter properly.

I don't think el in the funciton definition should be inferred by the usage of the function somewhere else.
Consider this case (where notWorkingRef is unused):
class Example extends Component {
  notWorkingRef = el => {
    // which type should el have?
  }
  render() {
    return

  }

In your case, notWorkingRef would change its signature depending on if it gets called or not.

We don't do this style of inference.

Makes perfect sense, just wanted to be sure. Thanks a ton!
On Wed, 21 Mar 2018 at 17:49, Ryan Cavanaugh<EMAIL_ADDRESS>wrote:

Closed #22761 https://github.com/Microsoft/TypeScript/issues/22761.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/22761#event-1533711318,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqQj2WxzPYj3AjlkGt0QBQVDS8ZU8Eeks5tgoSngaJpZM4SzsJW
.


Fix syntax highlighting on old blog posts

Github Flavored Markdown allows us to add backticks with languages for syntax highlighting. I should go back through my older blog posts and ensure highlighting is functional.
Here's some old pages where I don't think it's set up:

https://www.bryanbraun.com/2014/10/19/an-overview-of-javascripts-try-catch
https://www.bryanbraun.com/2015/05/17/setting-up-automated-testing-for-a-small-client-side-javascript-project/
https://www.bryanbraun.com/2014/11/27/every-possible-way-to-define-a-javascript-function/
https://www.bryanbraun.com/2013/10/07/pause-javascript-in-the-browser-using-the-debugger-command/
https://www.bryanbraun.com/2014/01/19/anchorjs/

There might be more.

Fixed in https://github.com/bryanbraun/bryanbraun.github.io/pull/19.


TYP: fix almost all keyword-only reported by stubtest

Ran poe stubtest --nightly | grep keyword-only
Not sure about the cases with

Not actually positional-only, used to handle deprecations in 1.5.0

Currently fails because of https://github.com/python/mypy/issues/14311

Sometimes keyword-only arguments are used when they are not actually such because that is the only way to handle some literal overloads: https://github.com/python/mypy/issues/5486
I'm surprised the tests pass after removing some of these.


all sorting algorithm

all the sorting algorithm is implemented in c

don't forget to add Star to this repo.


support CPU for inference_images.py

Thanks for your contribution.
Are you able to modify it so that num_workers is not hardcoded in the file? Make it a command line argument --num-workers after line 56. Set its default to 0, but allow people to change it.
If you don't have time, I will make the change myself later.

Thanks for your contribution.
Are you able to modify it so that num_workers is not hardcoded in the file? Make it a command line argument --num-workers after line 56. Set its default to 0, but allow people to change it.
If you don't have time, I will make the change myself later.

sure, I would be happy to do that for all 3 inteference codes.

sure, I would be happy to do that for all 3 inteference codes.

Thanks for your contribution.
Are you able to modify it so that num_workers is not hardcoded in the file? Make it a command line argument --num-workers after line 56. Set its default to 0, but allow people to change it.
If you don't have time, I will make the change myself later.

@PeterL1n  this is the PR https://github.com/PeterL1n/BackgroundMattingV2/pull/28. please review. thanks.

Thanks for your contribution.
Are you able to modify it so that num_workers is not hardcoded in the file? Make it a command line argument --num-workers after line 56. Set its default to 0, but allow people to change it.
If you don't have time, I will make the change myself later.

@PeterL1n  this is the PR https://github.com/PeterL1n/BackgroundMattingV2/pull/28. please review. thanks.

Merged the other pull request. I am closing this one.

Merged the other pull request. I am closing this one.


Proposal: Add an Example for Custom Hook Usage

Hi,
I really like this project and I would love to contribute to it. I noticed there isn't an example for using custom hooks, which made it challenging for me to figure out the correct way to implement them. I believe other newcomers might face similar difficulties.
To address this, I would like to add an example demonstrating how to use custom hooks.
Could you please guide me on how to submit to update the README.md by pull request accordingly?
Thank you!
Maybe the example like
hook.go
type authHook struct {
	mqtt.HookBase
}

func (h *authHook) OnConnectAuthenticate(cl *mqtt.Client, pk packets.Packet) bool {
	if cl.Properties.Username == 'david' {
              return true
        }
        return true
}

server.go
//something to build the mqtt
_ = server.AddHook(new(authHook), nil)
//something to start the mqtt
err := server.Serve()

@TheRiseOfDavid Thank you for your interest in the project! What do you feel is missing in examples such as looking here that could be provided in this new update of the readme?

@dgduncan I feel embarrassed to open this issue. When I was a noob using this package, I didn't realize that auth.Hook is an encapsulation of HookBase. Because auth.Hook is not in the /example/auth folder but rather in hook/auth, I was confused and thought this project didn't have a hook example. Thank you.


Design Bug | None centered login card sits in top corner of view

Describe the bug
When choosing left align for the container placement (I would presume right aligned also)
the container is placed in the top left/right of the page.
I'm assuming this is a design issue that just needs quickly fixing.
The affected div element that doesn't have the h-full class is here:
Main Element > div element with classes relative w-full h-full > Livewire element with classes w-full and relative (missing h-full)
The children of the root element for the livewire component do have h-full (auth-container-parent and auth-container).
To Reproduce
Steps to reproduce the behavior:

Go to Settings / Config
Change header and container alignment to left
See issue on login page

Expected behavior
Probably should stretch the livewire element with h-full
Screenshots

System Details

Auth Version 1.0.3

Related to #77

Just published a new release https://github.com/thedevdojo/auth/releases/tag/1.0.4, which should resolve this. Thanks for opening the issue.

Just published a new release 1.0.4 (release), which should resolve this. Thanks for opening the issue.

Thank you!


[About Module] Update views for empty content

Need the empty state module.
First we can just create a dedicated view
Will fin #537

@B3nz01d  @mccart77 Waiting for Figma specs, cannot work on this task without them.


cea.sensitivity.sensitivity_optimization.py doesn't work

It can't work. The imports don't work. This never worked

import cea.optimization.evolAlgo.evaluateInd as eI (evolAlgo doesn't exist)
the variation of globalvars used doesn't work
the code is a mess

I'm not sure what it is for at all (we have another sensitivity analysis code - which one is this one?)

This is for the optimization part @BhargavaKrishnaSreepathi  could you check if it works? the idea of this code is to take the results of a generation, change the prices of some fuels, re-run and based on certain criteria erase the individuals that are not robust enough

Sure, let me take a stab at it

Hi @JIMENOFONSECA. I will summarize my understanding of the necessity of the file, please correct me if i am wrong.

We take the population of a certain generation
we change the unit prices of utilities like electricity, natural gas prices and see the solution which is least sensitive to the variations in these prices.
We then proceed to remove the individuals which are very sensitive from the generation and only keep the solutions which are robust

You are right :-)
Best, Jimeno
On 10 Feb 2017, at 12:19, BhargavaKrishnaSreepathi <notifications<EMAIL_ADDRESS>wrote:
Hi @JIMENOFONSECAhttps://github.com/JIMENOFONSECA. I will summarize my understanding of the necessity of the file, please correct me if i am wrong.

We take the population of a certain generation
we change the unit prices of utilities like electricity, natural gas prices and see the solution which is least sensitive to the variations in these prices.
We then proceed to remove the individuals which are very sensitive from the generation and only keep the solutions which are robust

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/issues/472#issuecomment-278853872, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrghZnMO-0-x248VHBQ1R-vTdDnCi4ks5ra-U7gaJpZM4Lz7dI.


HttpClientCustomizer function no access to micrometer tracing context

Describe the bug
When creating a http client logger I have found that the trace & span id are not propagated for certain methods.
Sample
start.spring.io micrometer tracing & spring cloud gateway
@Bean
  public HttpClientCustomizer httpClientResolverCustomizer(HttpClientLogger httpClientLogger) {
    return httpClient ->
        httpClient
            .doAfterRequest((req, conn) -> logRequest(req, httpClientLogger))
            .doAfterResponseSuccess((res, conn) -> logResponse(res, httpClientLogger));
  }

2023-10-03T23:00:31,971 INFO  [reactor-http-nio-6][app,651c8effe9d86a59bad37df2b701910e,728be67b030f67cf] HttpClientLogger: Sending Request [GET] to [http://localhost/path/to/example] with headers [{}]
2023-10-03T23:00:32,853 INFO  [reactor-http-nio-6][app,,] HttpClientLogger: Received Response [200] from Request to [GET http://localhost/path/to/example] with response headers [{}], duration [N/A]ms

I'm not sure how it could. Maybe @jonatan-ivanov might have an idea.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

I think this can happen because in the instrumentation, the Observation.Scope is closed before doAfterResponseSuccess is called. You might be able to verify this either with a debugger or by registering ObservationTextPublisher that will print out the events that are happening during an observation. If closing the scope is happening before calling doAfterResponseSuccess, this behavior is what you get.
Do you know who creates the Observation here? Is it SC Gateway or Reactor Netty? If the latter, maybe this issue should be closed and a new one in Reactor Netty should be opened.
/cc @violetagg

In both doAfterRequest and doAfterResponseSuccess , you can obtain the current reactive context i.e. currentContextView(). If the Observation is stored in the context then it is available.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Fourier Continuation layer

Generalizing to other dimensions
The Fourier Continuation layer is only explicitly written for 2D inputs.
The continuation is done along each dimension separately, so almost exactly the same code could be used for 1D inputs or higher dimensional inputs with minor changes.
Could we make the use of the FC layer more explicit for other dimensions?
I suggested a simple code update to have 1D FC temporarily, but you might want to make a more general update later on and have the forward take as an input a tuple of dimensions along which the FC is performed.
##########################################################################################
Extending on both sides
The current FC layer extends on the right and on the bottom.
It could be generalized to extend both on the left and right, and both on the top and bottom. We could have as an optional parameter to either extend on one side or on both sides.
For instance, in 1D, I would extend on the right with 2*m additional points, and prepend the last m additional points to the left of the tensor. Another way to do it would be to extend on the right, flip the tensor, extend on the right, and flip back.
##########################################################################################
Handling Complex Inputs
If the input tensor is complex-valued, I added 0j to the extension matrix so it does not throw an error.
It extends the real and complex parts independently

This looks good to me @vduruiss - could we add a small unit-test to verify that e.g. a non-periodic input is correctly padded into a periodic one?

I added a unit-test for the Fourier Continuation layer in 1d and 2d.
The Fourier Continuation does not repeat the boundary value(s) in the extension, so instead of asserting the periodicity, I asserted that the shapes are correct and that the original values are not modified in the extension.
I included some code to plot the signals and their extensions to visually verify periodicity, and left that code commented. Here are the plots for reference

Let me know if that's what you had in mind!


ROCm: Support RCCL

Close #3927. All tests in tests/cupy_tests/cuda_tests/test_nccl.py passed locally, but I only have 1 GPU, so we might need further tests to ensure it's working with multi-GPUs.

cc: @emcastillo

Jenkins, test this please

Fixed a bug in f174fc2 that I wasn't able to catch because I have a CUDA installation on the development machine.

Jenkins, test this please

Jenkins CI test (for commit f174fc257d6b1f5c1d8942a6707c5975c022f7d4, target branch master) succeeded!


Add netstandard2.1 target to NuGetGallery.Services

Next step in addressing https://github.com/NuGet/Engineering/issues/4434.
This change introduces the netstandard2.1 target, and excludes many classes from it. If there is ongoing work in this target framework, it will take the form of removing these Remove items and addressing any issues that arise.
This change retargets only some telemetry classes and support database entities, which will be used elsewhere in this epic. Some upstream dependencies are specific to framework webapps and are not included in the netstandard2.1-targeted build.
Note also that the EntityFramework package reference is removed here, as it should have been removed in the SDK-style conversion for this project. This package reference is now accessed transitively through NuGetGallery.Core -> NuGetGallery.Services.Entities.
Also, DurationMetric.cs was poorly named. Have renamed according to class in file (DurationTracker).

@joelverhagen yes, that's right--the net472 target is unchanged, and this work is the only consumer of the new target.


feat: entity factories

possibility to store data on all types which extend the BaseObject struct & internal rework of entities
similar to c# entity factories

improved version in branch 'factories'


Updates for llvmlite 0.28

As title.

Just noticed the numba/label/dev builds for 0.43.0dev0 currently want llvmlite 0.27*, this updates.

added build 41 of llvmlite to main label, rerunning CI

Ignoring Python 2.7 windows (which is failing for non-Numba related reasons), this PR looks ready to merge now.


issue with latest summerwind/actions-runner failing to start: ./externals/node12/bin/node: No such file or directory

Hi,
Latest version of summerwind/actions-runner (deployed 10 hours ago) seem to be broken on actions-runner-controller v0.12.0 (0.13.0 yaml is missing in release - you have other ticket on that)
When deploying runner like:
apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
  name: sample-runner
spec:
  replicas: 5
  template:
    spec:
      organization: someorg
      group: All
      env: []

logs from a single runner ends like:
A runner exists with the same name
√ Successfully replaced the runner
√ Runner connection is good

# Runner settings

√ Settings Saved.

mv: target './externals/' is not a directory
16c16
< ./externals/node12/bin/node ./bin/RunnerService.js &
---
> ./externals/node12/bin/node ./bin/RunnerService.js $* &
20c20
< wait $PID
---
> wait $PID
\ No newline at end of file
27c27
<                 listener = childProcess.spawn(listenerExePath, ['run'], { env: process.env });
---
>                 listener = childProcess.spawn(listenerExePath, ['run'].concat(process.argv.slice(3)), { env: process.env });
30c30
<                 listener = childProcess.spawn(listenerExePath, ['run', '--startuptype', 'service'], { env: process.env });
---
>                 listener = childProcess.spawn(listenerExePath, ['run', '--startuptype', 'service'].concat(process.argv.slice(2)), { env: process.env });
34c34
<
---
>
59c59
<
---
>
91c91
< });
---
> });
\ No newline at end of file
.path=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
/runner/bin/runsvc.sh: line 16: ./externals/node12/bin/node: No such file or directory

Hey @lasse-aagren , this PR (https://github.com/summerwind/actions-runner-controller/pull/203) should actually have solved this.

same issue as #210


How to update session list when use Literal AI

A new chat, I want to update it in real time on the session list.

This is a known limitation, we will enhance this in future releases.


Is it possible to offer a block list to the generic phone?

I want to block specific numbers (and send them to voicemail), both on the VoIP as well as on cell calls. Is that possible? I believe this is called Call Directory Extension.

Yeah it's possible but haven't implemented since I don't have this requirement yet. PR is welcome!

Do you have build instructions? Can you give me hints on how to teach myself about this as fast as possible? Thanks.


docs: create env yaml

Ya I agree with you. Think I got a bit carried away with the dependencies so will remove sklearn and the other things we don't need right now!


Upload lambda to region specific buckets

Seems like lambda's need to be from a bucket in the same region, so this uploads to multiple regions.

@toolmantim this is currently blocked on needing the latest version of awscli on the build machine.

@toolmantim this is currently blocked on needing the latest version of awscli on the build machine.

Success!


impl AsyncBufRead for ReadHalf

Currently, ReadHalf doesn't implement AsyncBufRead, only AsyncRead, but I think that
impl<X: AsyncBufRead> AsyncBufRead for ReadHalf<X>

should be possible/implementable. Is there any argument against this / why this wouldn't work?

Seems like a very good idea to me.

ok, I just found out which makes that so difficult: The consume method has no Context argument, thus, we have no easy way to acquire the lock.

We could delay the call to the consume method conditionally (because we don't want to have a AsyncBufRead bound on the AsyncRead impl) using a helper trait, but that would require specialization, I think...

As this would either require feature(min_specialization) or a change to the trait AsyncBufRead (change consume to poll_consume with a cx arg), this won't fix soon, but if one needs that, it is possible to build a custom work-around using BiLock, just use locking on a more coarse level, e.g. outside of both poll_fill_buf and consume, in the surrounding scope, such that both are called under the same lock. --> EWONTFIX

It may be possible to fix this by introducing a new type BufReadHalf, which is constructable from ReadHalf, but only if the inner type support AsyncBufRead, and could include this optimization.

As stated in https://github.com/stjepang/async-dup/issues/1, this probably won't work.


GRPC methods not being camel cased.

Thanks a lot for the library, something I've been looking to try out!
Currently I've noticed in the GRPC example, that the methods are still pascal cased in the resolvers instead of using the camel case naming convention.
Is this by purpose or a bug?

If you want to have camel case, you can use camel case in gRPC service so you will have camel case operations in GraphQL as well. Naming convention is developer's preference, i don't think it can be considered as a bug.

Is there anyway to keep the pascal case in gRPC service methods, and then transform it to camel case GraphQL resolvers using the mesh config?

For now, it is not possible to transform field names in GraphQL Mesh. We can keep this open until it gets implemented.

Available in https://github.com/Urigo/graphql-mesh/releases/tag/v0.2.9 !!!

That was fast! 🚀


More CodeClimate engines

[Current coverage][cc-pull] is 100%

Merging [#7][cc-pull] into [mvp][cc-base-branch] will not change coverage

@@           mvp    #7   diff @@
================================
  Files        1     1
  Lines       10    10
  Methods      0     0
  Messages     0     0
  Branches     0     0
================================
  Hits        10    10
  Misses       0     0
  Partials     0     0

Powered by Codecov. Last updated by [565cb84...e836bfb][cc-compare]
[cc-base-branch]: https://codecov.io/gh/amercier/oeco-api/branch/mvp?src=pr
[cc-compare]: https://codecov.io/gh/amercier/oeco-api/compare/565cb8451f90bfda3070ea0bdacb6a016137e633...e836bfb66416123ce5e78ae29920a5bb0b447cd9
[cc-pull]: https://codecov.io/gh/amercier/oeco-api/pull/7?src=pr


Support TCMalloc service

What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:

Performance effects(性能影响):

Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

这个要考虑成为memory service么？(/memory)，那样的话似乎比较适合以后适配新的allocator

LGTM


chore: update vite v5.2

Description

fix: #4143
https://github.com/vitejs/vite/pull/14441 has already been merged and published to<EMAIL_ADDRESS>Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[x] Ideally, include a test that fails without this PR but passes with it.
[x] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[x] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

There are CI issues with updating Vite. Let's have a single PR to track this at #5311


[feature]: what about adding a maxMatchSize option?

When searching in a large object, there may be too many results.
Adding a maxMatchSize option would reduce the perform issue by early returns.

It wouldn't make a huge difference without re-architecting some things. Ultimately you need to score all of the entries to find out the top entries, and that's where all the performance critical work is.

Agreed, @heyimalex.

It wouldn't make a huge difference without re-architecting some things. Ultimately you need to score all of the entries to find out the top entries, and that's where all the performance critical work is.

It may not need to score all of the entries, just to find a limit number of the result that meets the threshold(early returns, left the rest unvisited).
I've found the limit option on code, but it's not used.
https://github.com/krisk/Fuse/blob/fe1ff83645a55b6ea9f9488893a32495c132529f/src/index.js#L100-L102

@dabuside You're right that it'd be possible, but how often would it be used? The vast majority of people want the best matches, not the first x matches that crossed the threshold.
That code you linked runs after scoring.

@dabuside You're right that it'd be possible, but how often would it be used? The vast majority of people want the best matches, not the first x matches that crossed the threshold.
That code you linked runs after scoring.

oops. You're right.


generate protocol for a halo2 circuit offchain

although, we have abstracted the protocol info we need to verify a halo2 proof.
We still need to generate the protocol offchain, so that developers can use the tool to upload the protocol info to chain, then our halo2 verifier can use theses circuits' protocol infos.
should also take care of  #10

ongoing #25


feat: Implement support-cron-scheduler service persistence layer

This is the first PR of #4834.

Initialized for the new support-cron-scheduler
Implemented the persistence layer with PostgreSQL and jackc/pgx toolkit

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[ ] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[x] I have opened a PR for the related docs change (if not, why?)
https://github.com/edgexfoundry/edgex-go/pull/4831

Testing Instructions

Clone the fork edgex-go and checkout this branch
Run the following command at root folder to build local images

make docker

Clone this fork edgex-compose and checkout  to test-cron-scheduler branch
Head to the compose-builder folder
Run the whole stack with local images in non-security mode with the following command

make run dev no-secty

Wait for the containers to start and use the following command to check the log of support-cron-scheduler service

docker logs edgex-support-cron-scheduler

New Dependency Instructions (If applicable)

jackc/pgx dependencies:

GO111MODULE=on go mod graph | grep jackc
github.com/edgexfoundry/edgex-go<EMAIL_ADDRESS>github.com/edgexfoundry/edgex-go<EMAIL_ADDRESS>github.com/edgexfoundry/edgex-go<EMAIL_ADDRESS>github.com/edgexfoundry/edgex-go<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 297 lines in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (9dd7579) to head (259c2dd).

Files
Patch %
Lines

...nternal/pkg/infrastructure/postgres/schedulejob.go
0.00%
135 Missing :warning:

...kg/infrastructure/postgres/scheduleactionrecord.go
0.00%
129 Missing :warning:

internal/pkg/infrastructure/postgres/utils.go
0.00%
25 Missing :warning:

internal/pkg/infrastructure/postgres/client.go
0.00%
8 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4837      +/-   ##
==========================================
- Coverage   40.63%   39.50%   -1.13%
==========================================
  Files         109      113       +4
  Lines       10427    10724     +297
==========================================
  Hits         4237     4237
- Misses       5828     6125     +297
  Partials      362      362

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Status Codes

If website is not reachable, requests.get(url) returns with different status code. In this code, this case is handled by returning 404 user not found error.
The error message can be improved depending on status code.

Yes, do your changes and pull the requests. I will merge them.


Downloading sync failed - SSL problem: unable to get local issuer certificate

Goals

Installing Realm through Cocoapods using pod 'RealmSwift'.
Expected Results

Realm installs successfully.
Actual Results

Cocoapods pod install --verbose output:
Downloading dependencies

-> Installing Realm (2.8.3)
 > Git download
 > Git download
     $ /usr/local/bin/git clone https://github.com/realm/realm-cocoa.git
     /var/folders/q7/l_1t3jx11nqcxq19jsg14sj00000gn/T/d20170712-13217-1o6ihno
     --template= --single-branch --depth 1 --branch v2.8.3
     Cloning into '/var/folders/q7/l_1t3jx11nqcxq19jsg14sj00000gn/T/d20170712-13217-1o6ihno'...
     Note: checking out '15afc8f3620f70ef8fd98f053490839777567555'.

     You are in 'detached HEAD' state. You can look around, make experimental
     changes and commit them, and you can discard any commits you make in this
     state without impacting any branches by performing another checkout.

     If you want to create a new branch to retain commits you create, you may
     do so (now or later) by using -b with the checkout command again. Example:

       git checkout -b <new-branch-name>

     $ /usr/local/bin/git -C
     /var/folders/q7/l_1t3jx11nqcxq19jsg14sj00000gn/T/d20170712-13217-1o6ihno
     submodule update --init --recursive
     Submodule 'Realm/ObjectStore' (https://github.com/realm/realm-object-store.git) registered for path 'Realm/ObjectStore'
     Cloning into 'Realm/ObjectStore'...
     Submodule path 'Realm/ObjectStore': checked out '39d33531363d8ac9faf0333c9abd9b7c86588d13'
     Submodule 'external/catch' (https://github.com/philsquared/Catch) registered for path 'external/catch'
     Submodule 'external/pegtl' (https://github.com/ColinH/PEGTL) registered for path 'external/pegtl'
     Cloning into 'external/catch'...
     Submodule path 'Realm/ObjectStore/external/catch': checked out 'ce37f48ffad2401e6c23a54cae3f015c01fdc200'
     Cloning into 'external/pegtl'...
     Submodule path 'Realm/ObjectStore/external/pegtl': checked out '3c4128a7e7e1288eb746418ea60c41477358f26a'
 > Running prepare command
   $ /bin/bash -c  set -e sh build.sh cocoapods-setup
   core is not a symlink. Deleting...
   Downloading dependency: sync 1.10.0
   Downloading sync failed:
   	https://static.realm.io/downloads/sync/realm-sync-cocoa-1.10.0.tar.xz
   	curl: (60) SSL certificate problem: unable to get local issuer certificate
   More details here: http://curl.haxx.se/docs/sslcerts.html

   curl performs SSL certificate verification by default, using a "bundle"
    of Certificate Authority (CA) public keys (CA certs). If the default
    bundle file isn't adequate, you can specify an alternate file
    using the --cacert option.
   If this HTTPS server uses a certificate signed by a CA represented in
    the bundle, the certificate verification probably failed due to a
    problem with the certificate (it might be expired, or the name might
    not match the domain name in the URL).
   If you'd like to turn off curl's verification of the certificate, use
    the -k (or --insecure) option.
[!] /bin/bash -c
set -e
sh build.sh cocoapods-setup

core is not a symlink. Deleting...
Downloading dependency: sync 1.10.0
Downloading sync failed:
	https://static.realm.io/downloads/sync/realm-sync-cocoa-1.10.0.tar.xz
	curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.

The main issue is with curl trying to download
Downloading sync failed:    	https://static.realm.io/downloads/sync/realm-sync-cocoa-1.10.0.tar.xz
which shows the error:
curl: (60) SSL certificate problem: unable to get local issuer certificate
I have tried curl alone with the sync file and got the same issue.
However, when trying the curl command with http instead of https, it works fine!!
I also tried a method found in other issues in the Realm repo, which consisted of downloading the file and moving it using the following commands:
curl http://static.realm.io/downloads/sync/realm-sync-cocoa-1.10.0.tar.xz -O
mkdir $TMPDIR/sync_bin
mv realm-sync-cocoa-1.10.0.tar.xz $TMPDIR/sync_bin/realm-sync-cocoa-1.10.0.tar.xz

The first command downloaded the file (successful because I used http).
The second command created the sync_bin directory successfully.
The third command moved the file to the directory.
I tried the same steps with the core_bin folder as well.
None of the above worked.
Steps to Reproduce

Running the pod install command for a pod file with pod 'RealmSwift'.
Code Sample

No code samples, this issue happens with the installation of realm.
Version of Realm and Tooling

Realm framework version: 2.8.3
Realm Object Server version: ?
Xcode version: 8.3.3
iOS/OSX version: 10
Dependency manager + version: Cocoapods 1.2.1

Interesting. I'm sorry you're experiencing some difficulty downloading Realm.
I couldn't reproduce this myself just now:
$ curl -O https://static.realm.io/downloads/sync/realm-sync-cocoa-1.10.0.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 42.5M  100 42.5M    0     0  6459k      0  0:00:06  0:00:06 --:--:-- 6795k
$ echo $?
0

@jpsim I am getting the issue when running the same command you ran.

I tried the suggested commands, the first one resulted in the same issue:
curl: (60) SSL certificate problem: unable to get local issuer certificate
However, I manually downloaded the file and moved it to the working directory in terminal, then ran the second command and it worked (started downloading).
On a related, possible needed, note:
I tried the command curl --cacert nonExistingFile.pem https://www.google.com so I can check my CApath, but the result was CApath: none.
As for the version:
curl 7.30.0 (x86_64-apple-darwin10.0.0) libcurl/7.30.0 OpenSSL/1.0.1m zlib/1.2.8
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smtp smtps telnet tftp
Features: IPv6 Largefile NTLM NTLM_WB SSL libz TLS-SRP

After more research, I did not find a one-post solution, but the fragments here and there helped me, so I'm putting the simple fix for future reference:
1- Download the .pem file from: https://curl.haxx.se/ca/cacert.pem
2- Move/copy it to the following directory: /etc/ssl/certs
3- Run the following command: echo 'cacert=/etc/ssl/certs/cacert.pem' > ~/.curlrc
That's it. curl was not set to use the .pem file by default, and these steps makes sure it does. Subsequently, this makes the pod install command work and not fail anymore.
Thanks @jpsim for the help, the commands you posted made me realize my curl was not downloading from any https links at all!

🎉

This suggests that we may want to hard-code /usr/bin/curl in build.sh so we always get the system version rather than a user-installed version. The system version of curl on recent versions of macOS uses SecureTransport rather than OpenSSL for SSL, which means it relies on the system keychain for verifying the certificate chain.

That does sound nice. PR incoming.

Downloading dependency: 11.14.0 from https://static.realm.io/downloads/core/realm-monorepo-xcframework-v11.14.0.tar.xz
Downloading core failed:
	https://static.realm.io/downloads/core/realm-monorepo-xcframework-v11.14.0.tar.xz
	curl: (60) SSL certificate problem: certificate has expired
More details here: https://curl.se/docs/sslcerts.html

Could you please update static.realm.io certificate, so tuist/carthage would be able to build my project?


Inter-droplet communication is broken

I noticed that DNS lookups were broken, upon investigating I found that droplet communication seems to be broken.
I created a busybox pod and then executed:
kubectl exec -ti busybox -- nslookup kubernetes.default
which resulted in
Server:    <IP_ADDRESS>
Address 1: <IP_ADDRESS>

nslookup: can't resolve 'kubernetes.default'

I then tried:
kubectl exec -ti busybox -- ping <IP_ADDRESS> -c 3
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes

--- <IP_ADDRESS> ping statistics ---
3 packets transmitted, 0 packets received, 100% packet loss

Pinging on the droplet's private IPs does work, however.

I'm experiencing this as well and haven't been able to make any progress. Should we revert #28 until this is resolved?

Let me know to reopen this if you find #31 doesn't adequately resolve this.


Improving Footer Section

Describe the bug
The text in the footer looks kinda akward and big

Expected behavior
I will be improvving its CSS and making it look lood

Screenshots (optional)

Additional context (optional )

Please assign me this issue under GSSOC'23

@Swapnil-Singh-99 please assign this issue


[Bug] drop-placehold displays the wrong position

Link Demo Bug: https://jobchatproduction.s3.ap-southeast-1.amazonaws.com/mediaUpload/1558167270099_ro856783i8h.ogv
Step 1: download this library
Step 2: change property  orientation="horizontal" to  orientation="vertical"
Step 3: npm run dev
Step 4: scroll to second container (Ipsum)
Step 5: move task in this container
Could you fix this issue as quickly as possible? :((

Hello @PhuHoaframgia , Did you find any solution for it?

Hey @PhuHoaframgia @sergeynew
Sorry for late response. I'll fix it in couple of days and let you guys know
Cheers!

@kutlugsahin we see the same problem today. Could you please submit your commit  to help solve the problem.

+1

+1


docs: add org scope to quickstart

Definition of Ready

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

https://zitadel.com/docs/guides/manage/console/organizations

Yes we can try that. Not sure if it is enough.

I have changed it


Integration issues

After having a good look at the getting started and the sources, I'd like to share a few integration issues that I've come across. Basically the biggest issue is the fact that the output from gramps() goes directly into the apollo-server middleware. I thought I could get around it by accessing the individual properties of that object (for example, the schema), but that's also not possible, because the output is actually a function of req. Of course, I can work around that as well, by running gramps()(null).schema to get to the schema, but that doesn't really feel right.
This means that I end up with an all or nothing solution, which is not really what I would like. I'd like to have the ability to composition these components into my own server.
To be able to do this I need the following:

Access to the resulting schema. That makes it easier to use that and apply my own stitching, or add additional schemas to my server outside of GrAMPS.
Access to a middleware function that constructs my context. Currently, the context is only passed in to apollo-server. Ideally, the context would be constructed in an Express middleware function, so I have the possibility to add my own required bits and pieces to the context as well, before it is passed in to apollo-server.

This might be as easy as:
const gramps = gramps()
const schema = gramps.schema

// do my own stuff with my schemas

app.use('/graphql', gramps.setContext())

// do my own stuff in the context

app.use('/graphql', graphqlExpress({ schema: finalSchema, context: req => req, /* additional options */ })

Now, if I didn't need all of that, I would still be able to do:
const gramps = gramps()
app.use('/graphql', express.json(), graphqlExpress(gramps.serverOptions));

So it wouldn't impact the getting-started experience much, but would make it a lot easier to either use it in a more mixed environment, or integrate it with other tools (like graphql-yoga and my upcoming supergraph framework).

I think we could make this work, yeah.
For default cases, I think GrAMPS working standalone makes sense, so I don't think I'd want to change that API (especially because breaking changes this early on seem ill-advised).
However, I think we could easily abstract out the core parts of GrAMPS into named exports, so you could do something like this:
import { generateExecutableSchema } from 'gramps';

const gramps = generateExecutableSchema();

const schema = gramps.schema;

// do whatever you want

app.use('/graphql', graphqlExpress({
  schema: finalSchema,
  context: req => ({
    req,
    gramps: gramps.context(req),
  }),
  // additional options...
}));

Were you thinking the setContext() method in your example would be middleware to attach the context to req? Or something else?

^^ to clarify, generateExecutableSchema would effectively return the same GraphQLOptions object as the default GrAMPS export, but wouldn't wrap it with the req => /* ... */ function.

And where would I pass in my GrAMPS datasources in this example?

Regarding the context, that depends on where you 'need' it to be. I see in your example you pass it in on the top level, so you would have (in apollo) context.req and context.gramps. I usually pass in the entire req object as context, so if I add in to req in an Express middleware, it would still end up in context.gramps for apollo, which is good.

prepare() makes sense, yeah.
It would have the same API as gramps(), I imagine, with the limitation that it doesn't have access to req for extraContext.
We could refactor under the hood so that gramps() calls prepare() to make sure we keep things DRY.
Data sources scope context in resolvers to their own namespace + the content of extraContext, so we'd have to think through that. Basically anything that a GrAMPS data source needs to access will need to be attached via:
const gramps = prepare({
  dataSources: [/* ... */],
  extraContext: {
    // any extra context needed by GrAMPS data sources goes here
  },
});

See my proposal (very initial draft, no linting, tests, or even running). I don't think there's an issue with extraContext.

At first glance, this looks like it's the right direction. @ecwyne, anything seem out of place with the API in #63?

So, to recap, that would mean you could alternatively do (keeping the existing API 100% intact):
import { prepare } from 'gramps'

const gramps = prepare({ /* all gramps() parameters here /*)
const schema = gramps.schema

// do my own stuff with my schemas

app.use('/graphql', gramps.contextMiddleware)

// do my own stuff in the context

app.use('/graphql', graphqlExpress({ schema: finalSchema, context: req => req, /* additional options */ })

This seems most descriptive to my eye:
app.use('/graphql', gramps.addContext);

As long as the existing API stays intact, I think this is a solid addition for advanced use cases.

As add is a verb, I would go for gramps.addContext(), not gramps.addContext, but that's just semantics.

I threw together a quick boilerplate, for use with graphql-cli. Run the following command to create a server:
graphql create server -b https://github.com/supergraphql/gramps-boilerplate

This is awesome. Thank you!

This is a totally different take on a solution, but let me know what you think @kbrandwijk. If what you need is the resulting schema and the getContext function created by GrAMPS, what if we just add those as properties to the middleware function returned by GrAMPS.
const middleware = req => ({
    schema,
    context: getContext(req),
    // formatError: formatError(logger),
    ...apolloOptions.graphqlExpress,
  });
  middleware.schema = schema;
  middleware.getContext = getContext;
  return middleware;

Then you can use them however you'd like.
import gramps from 'gramps'

const middleware = gramps({ /* all gramps() parameters here */ });
const { schema, getContext } = middleware;

// do my own stuff with my schemas

app.use('/graphql', middleware)

// do my own stuff in the context

app.use('/graphql', graphqlExpress({ schema: finalSchema, context: req => req, /* additional options */ })

I'm inclined to agree: adding props to functions has always looked hacky to me, and I think it increases the cognitive overhead of understanding what's going on.


Add documentation for new CTS test cases

Please see PR #1999

Looks like this can be closed? closing ....

I think we're still missing the documentation for the latest (read-only) search test cases:
https://egeria.odpi.org/open-metadata-conformance-suite/docs/repository-workbench/test-cases/repository-entity-sharing-property-search-test-case.md
... is referred to in the CTS output, but the link gives a 404 (and can't see any corresponding markdown in master)

Fixed by #2097


Add changes to handle new v1.25 ListValue with BC

Closing in favour of https://github.com/weaviate/weaviate-python-client/pull/984


docs: Fix Typo Update README.md

Description
I noticed a small issue with the wording in the documentation where "timing buffered disk reads" was used. This phrase seems to be a typo, as the correct term in the context of disk read operations should be "time-buffered disk reads."
The term "time-buffered" is commonly used in technical contexts related to disk I/O operations, and correcting this will help ensure clarity and accuracy.
Thank you for reviewing this!
Based.

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

@mdqst Thank you for this PR. We're going to leave this as-is for now.


kubernetes-leader-election-example: service not elected as leader

Describe the bug
Following https://github.com/spring-cloud/spring-cloud-kubernetes/tree/main/spring-cloud-kubernetes-examples/kubernetes-leader-election-example , service is not receiving leadership even without replication. Any additional settings required?
[shoner@shoner kubernetes-leader-election-example]$ kubectl apply -f deploy.yml
service/kubernetes-leader-election-example created
serviceaccount/kubernetes-leader-election-example created
rolebinding.rbac.authorization.k8s.io/kubernetes-leader-election-example:view created
role.rbac.authorization.k8s.io/namespace-reader created
deployment.apps/kubernetes-leader-election-example created
[shoner@shoner kubernetes-leader-election-example]$ minikube service kubernetes-leader-election-example --url
http://<IP_ADDRESS>:31706
[shoner@shoner kubernetes-leader-election-example]$ SERVICE_URL=$(minikube service kubernetes-leader-election-example --url)
[shoner@shoner kubernetes-leader-election-example]$ curl $SERVICE_URL
I am 'kubernetes-leader-election-example-795dc76c6b-nfbvx' but I am not a leader of the 'world'[shoner@shoner kubernetes-leader-election-example]$ curl $SERVICE_URL
I am 'kubernetes-leader-election-example-795dc76c6b-nfbvx' but I am not a leader of the 'world'[shoner@shoner kubernetes-leader-election-example]$ curl $SERVICE_URL
I am 'kubernetes-leader-election-example-795dc76c6b-nfbvx' but I am not a leader of the 'world'[shoner@shoner kubernetes-leader-election-example]$ curl $SERVICE_URL
I am 'kubernetes-leader-election-example-795dc76c6b-nfbvx' but I am not a leader of the 'world'[shoner@shoner kubernetes-leader-election-example]$ kubectl get pods
NAME                                                  READY   STATUS    RESTARTS   AGE
kubernetes-leader-election-example-795dc76c6b-nfbvx   1/1     Running   0          7m32s
[shoner@shoner kubernetes-leader-election-example]$ curl $SERVICE_URL
I am 'kubernetes-leader-election-example-795dc76c6b-nfbvx' but I am not a leader of the 'world'[shoner@shoner kubernetes-leader-election-example]$
Sample
Used https://github.com/spring-cloud/spring-cloud-kubernetes/tree/main/spring-cloud-kubernetes-examples/kubernetes-leader-election-example in main branch as is, with two minor modifications below. "deploy.yml" file in the description above is a file created as instructed under "You can then deploy the application using the following yaml."

Changed service type in YAML to NodePort, as discussed in https://github.com/spring-cloud/spring-cloud-kubernetes/issues/1257
Due to 404 error, I modified LeaderController.java: @ GetMapping -> @ GetMapping({ "", "/" })

Can try replacing the role in the deploy YAML with this

  - apiVersion: rbac.authorization.k8s.io/v1
    kind: Role
    metadata:
      namespace: default
      name: namespace-reader
    rules:
      - apiGroups: ["", "extensions", "apps"]
        resources: ["configmaps", "pods", "services", "endpoints", "secrets"]
        verbs: ["get", "list", "watch", "create", "update", "patch", "delete"]

After modifying YAML, it successfully received leadership. Thank you for your help.
[shoner@shoner kubernetes-leader-election-example]$ kubectl apply -f deploy.yml
service/kubernetes-leader-election-example created
serviceaccount/kubernetes-leader-election-example created
rolebinding.rbac.authorization.k8s.io/kubernetes-leader-election-example:view created
role.rbac.authorization.k8s.io/namespace-reader created
deployment.apps/kubernetes-leader-election-example created
[shoner@shoner kubernetes-leader-election-example]$ minikube service kubernetes-leader-election-example --url
http://<IP_ADDRESS>:32674
[shoner@shoner kubernetes-leader-election-example]$ SERVICE_URL=$(minikube service kubernetes-leader-election-example --url)
[shoner@shoner kubernetes-leader-election-example]$ curl $SERVICE_URL
I am 'kubernetes-leader-election-example-795dc76c6b-n2jkz' and I am the leader of the 'world'[shoner@shoner kubernetes-leader-election-example]$

I am not sure you would ever really see a single instance ever not be a leader because as soon as the configmap is updated this triggers a config map watcher which then will try and acquire the leadership.  This will of course succeed because there is no other instance to compete with.  If you scale the replicas to 4 for example you will have much better luck trying to see how this works.
I put together a PR to clarify the README instructions.
https://github.com/spring-cloud/spring-cloud-kubernetes/pull/1281/files

After applying replication, Connection Refused error happens and internally pods seem to keep restarting. Perhaps it's because my CPU/RAM resources are not enough to run them. Thank you for your help anyway.


Identity Crash

This crash report when using identity and opening up its menu (seems to be an issue with the Phyg wing):
https://pastebin.com/11NZbt83

the phyg has not yet been implemented,

Phyg is not implemented, when it has a model this will be a non-issue


right-sidebar: Implement progressively rendered list for user presences.

This implements the progressively rendered list for user presences so
that it only displays the first fifty or so results and dynamically
creates the rest on demand.

Automated message from Dropbox CLA bot
@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!

@showell can you take this review?

@timabbott:
@brockwhittaker and I had some chat discussion about this, and I like the direction it's going in, but I assume this is probably post-1.7 at this point?

Yeah, agreed.

I think the one piece we could change before then is swapping the scrollbar to perfectScrollbar.

Yeah I can definitely bake that in quickly. Curious how it will interact with the progressive list.

Heads up @brockwhittaker, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

Closing this, since we ended up solving this a different way a couple years ago.


Add covariance structures as in definitions 4.3, 4.4, 4.5 and 4.6 of …

…Aitchson - The Statistical Analysis of Compositional Data. Still needs to be tested.

Didn't coded tests file because I'm not sure how I could do it. Maybe using groundtruth results and then compare with the output of these functions? I appreciate if we can discuss this later.

Didn't coded tests file because I'm not sure how I could do it. Maybe using groundtruth results and then compare with the output of these functions? I appreciate if we can discuss this later.

We can discuss in our meeting a good set of tests, also considering #22 👍🏽

Codecov Report

Merging #23 (751b051) into master (24c8a66) will decrease coverage by 20.68%.
The diff coverage is 0.00%.

:exclamation: Current head 751b051 differs from pull request most recent head 88a467a. Consider uploading reports for the commit 88a467a to get more accurate results

@@             Coverage Diff             @@
##           master      #23       +/-   ##
===========================================
- Coverage   82.10%   61.41%   -20.69%
===========================================
  Files           3        4        +1
  Lines          95      127       +32
===========================================
  Hits           78       78
- Misses         17       49       +32

Impacted Files
Coverage Δ

src/covariances.jl
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c8a66...88a467a. Read the comment docs.

@mrr00b00t please close this PR and start a fresh one with a rebased version of master. You are including all changes that were merged in #22 again because of the merge.
Please follow the workflow we shared on that set of slides.

I will close this PR so that we don't merge it accidentally.


fix: improve git sync slowness

Changes:

[x] check git changes every 30s
[x] use promise all to improve speed when get git changes
[x] add changes&push check after some of git action

Next step:

[ ] we need try to use statusMatrix instead of status

related #7946


Minecraft 1.10.2 Support

Mod won't load on forge for 1.10.2
[main/ERROR] [FML/]: The coremod nallar.tickprofiler.minecraft.CoreMod is requesting minecraft version 1.10 and minecraft is 1.10.2. It will be ignored.

The inability to supply a range of acceptable versions for coremods is annoying. The only options are to support everything and get a warning in the logs, or to support one exact version string.
:/
I'll make a 1.10.2 branch.

1.10.2 branch up, build on Jenkins. Haven't tested it, busy right now. Does it work?

It works now, thanks!


Mock web requests in tests?

Hey there. Is it desired to mock web requests? If so, I can work on a PR.

Sure! Go for it

Hey, what do you think about adding a MockProvider? It could be used for test environments.

Honestly dude, I haven't been giving this lib the love it requires. I'm also not familiar with what a MockProvider would do.
Given A and B above, I'm totally open to it, but you'll have to explain it a bit more to me :)

@philipgiuliani sounds good, but it wouldn't test the actual real-world providers. Or we just fire real webrequests to those and add a provider contract / behaviour.

Might be worth considering a pattern like Geolix.Adapter.Fake
Where test configuration can hard-code expected addresses and their geocoded mappings.

Great idea! Want to submit a PR with this change?
On Mon, May 2, 2022 at 4:37 PM Kyle Boe @.***> wrote:

Might be worth considering a pattern like Geolix.Adapter.Fake
https://github.com/elixir-geolix/geolix#fake-adapter
Where test configuration can hard-code expected addresses and their
geocoded mappings.
—
Reply to this email directly, view it on GitHub
https://github.com/DaoDeCyrus/geocoder/issues/13#issuecomment-1115437043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABE2RZKBFTICOGGWH3FHA3VIBKKNANCNFSM4CHT63UQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Yep! I've forked and will work on that when time permits.

Added #86. Am definitely looking for some feedback on ways of improving it/the documentation around Providers.


revise superclass assertions for down syndrome. Addresses #824

There was ID duplication on another branch and that error made it to other
places. It was clearly a mistake of not incrementing the ID for this class,
and it cased it to merge with MONDO:0100080.  This error was merged into
master recently and it was causing it to fail. Same for a couple of other
branches. Discussed with Nicole and she agreed that the ID was incorrect.
There, and the next used ID was MONDO:0100082, so MONDO:0100081 was missing
and MONDO:0100080 was applied to two classes. Fixing this was part of
getting the build to pass for master and a couple of other branches.
On Tue, Oct 1, 2019, 8:47 PM Chris Mungall<EMAIL_ADDRESS>wrote:

@cmungall requested changes on this pull request.
Never modify IDs!
If this is necessary to correct something on master then raise this as a
high priority issue that must be addressed!
I'm not sure what is going on here, as we already have this on master:
[Term]
id: MONDO:0100081
name: sleep disorder
do you know what is up @ShahimEssaid https://github.com/ShahimEssaid?
Is this a case of branches or branches?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/monarch-initiative/mondo/pull/837?email_source=notifications&email_token=ABELXUKVKOOEEJPLYHKYO4TQMQKWFA5CNFSM4I3AYXYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGSJ7RA#pullrequestreview-296001476,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABELXUNMCVZHB6N7I7ADU5TQMQKWFANCNFSM4I3AYXYA
.

See https://github.com/monarch-initiative/mondo/pull/838
On Tue, Oct 1, 2019, 9:40 PM Shahim Essaid<EMAIL_ADDRESS>wrote:

There was ID duplication on another branch and that error made it to other
places. It was clearly a mistake of not incrementing the ID for this class,
and it cased it to merge with MONDO:0100080. This error was merged into
master recently and it was causing it to fail. Same for a couple of other
branches. Discussed with Nicole and she agreed that the ID was incorrect.
There, and the next used ID was MONDO:0100082, so MONDO:0100081 was missing
and MONDO:0100080 was applied to two classes. Fixing this was part of
getting the build to pass for master and a couple of other branches.
On Tue, Oct 1, 2019, 8:47 PM Chris Mungall<EMAIL_ADDRESS>wrote:

@cmungall requested changes on this pull request.
Never modify IDs!
If this is necessary to correct something on master then raise this as a
high priority issue that must be addressed!
I'm not sure what is going on here, as we already have this on master:
[Term]
id: MONDO:0100081
name: sleep disorder
do you know what is up @ShahimEssaid https://github.com/ShahimEssaid?
Is this a case of branches or branches?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/monarch-initiative/mondo/pull/837?email_source=notifications&email_token=ABELXUKVKOOEEJPLYHKYO4TQMQKWFA5CNFSM4I3AYXYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGSJ7RA#pullrequestreview-296001476
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABELXUNMCVZHB6N7I7ADU5TQMQKWFANCNFSM4I3AYXYA
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/monarch-initiative/mondo/pull/837?email_source=notifications&email_token=ABELXUOLRNU6RQLVTCDVNHDQMQQ3NA5CNFSM4I3AYXYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADQRNY#issuecomment-537331895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABELXUIX7ILMYZMJFJMBL7LQMQQ3NANCNFSM4I3AYXYA
.

unfortunately the release has a messed up link as the ID was corrected in
the main stanza but not a link so we have
[Term]
id: MONDO:0013600
name: insomnia (disease)
...
is_a: MONDO:0100080 {source="
https://github.com/monarch-initiative/mondo/issues/531"} ! cardioectodermal
syndrome
let me know if something similar happens again, I am expert at fixing obo
files.
Also, never reuse - better to obsolete any ID that has been tainted in any
way!
On Tue, Oct 1, 2019 at 9:46 PM Shahim Essaid<EMAIL_ADDRESS>wrote:

See https://github.com/monarch-initiative/mondo/pull/838
On Tue, Oct 1, 2019, 9:40 PM Shahim Essaid<EMAIL_ADDRESS>wrote:

There was ID duplication on another branch and that error made it to
other
places. It was clearly a mistake of not incrementing the ID for this
class,
and it cased it to merge with MONDO:0100080. This error was merged into
master recently and it was causing it to fail. Same for a couple of other
branches. Discussed with Nicole and she agreed that the ID was incorrect.
There, and the next used ID was MONDO:0100082, so MONDO:0100081 was
missing
and MONDO:0100080 was applied to two classes. Fixing this was part of
getting the build to pass for master and a couple of other branches.
On Tue, Oct 1, 2019, 8:47 PM Chris Mungall<EMAIL_ADDRESS>wrote:

@cmungall requested changes on this pull request.
Never modify IDs!
If this is necessary to correct something on master then raise this as
a
high priority issue that must be addressed!
I'm not sure what is going on here, as we already have this on master:
[Term]
id: MONDO:0100081
name: sleep disorder
do you know what is up @ShahimEssaid <https://github.com/ShahimEssaid
?
Is this a case of branches or branches?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/monarch-initiative/mondo/pull/837?email_source=notifications&email_token=ABELXUKVKOOEEJPLYHKYO4TQMQKWFA5CNFSM4I3AYXYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGSJ7RA#pullrequestreview-296001476

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ABELXUNMCVZHB6N7I7ADU5TQMQKWFANCNFSM4I3AYXYA

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/monarch-initiative/mondo/pull/837?email_source=notifications&email_token=ABELXUOLRNU6RQLVTCDVNHDQMQQ3NA5CNFSM4I3AYXYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADQRNY#issuecomment-537331895
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABELXUIX7ILMYZMJFJMBL7LQMQQ3NANCNFSM4I3AYXYA
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/monarch-initiative/mondo/pull/837?email_source=notifications&email_token=AAAMMOIOQXRAQSRM34ZZQFTQMQRQJA5CNFSM4I3AYXYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADQZNA#issuecomment-537332916,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAMMOJTPE2UVIPOSB46IHTQMQRQJANCNFSM4I3AYXYA
.

Ok, we'll ask for your expert help if a similar issue arises, and will obsolete tainted IDs next time. Thanks for your help!

conflicts.. and we have the weird ID shift again

conflicts resolved.


Move EEPROM methods out of DuckNet

Describe the bug
All the EEPROM methods are built inside of DuckNet since that's where originally passed into the value for the EEPROM.
To reproduce
Open Ducknet.cpp and look at:
saveWifiCredentials()
loadWifiCredentials()
saveControlSsis()
saveControlPassword
loadControlSsis()
loadControlPassword
Move these methods to DuckUtils
Additional context
More EEPROM methods are being built now for saving channels, which reminded me of moving them.

I'm new to the project. These seems like a pretty mellow first contribution. Is this still needed?

Hi @l-monninger, sorry for the delay! Yes this is still a need!

Sure! You can join our slack if you need any help www.project-owl.com/slack


Support horizontal scrolling in neo-tree window?

Hi thanks for the plugin, recently updated it and found file name rendering logic changed.

if filename is very long, it only partially renders. users can't see it even after pressing zl to scroll. This also prevents searching, for example the file name is completion.lua, but /completion.lua doesn't have any matches because the rendered text is comple.
Is there any plans to support these? thanks

You'll want to remove the containers from the default renderers. See https://github.com/nvim-neo-tree/neo-tree.nvim/discussions/267#discussioncomment-2547669

that worked, thanks!


Remove flows in beckn_onix.sh which are not clearly defined

Some of the flows in beckn_onix.sh are not clearly defined. For example merging two networks.
Similarly the network configuration option is not clearly defined
Remove these from the beckn_onix.sh

This is linked to the discovery issue here #18


Use UV_E* constants, OSError built-in translation.

This PR avoids the hard-coded error numbers from the PR #14. Instead the available error numbers of the form UV_E* (hence with a single underscore _ ) are used in modules like stream.pyx and udp.pyx in winloop/handles/. The files uv.pxd and  errors.pyx are modified accordingly, also taking advantage of the translation in Python's OSError(), which given an error number and error message automatically returns an instance from a subclass of OSError, like this:
>>> import errno
>>> OSError(errno.EAGAIN, '')
BlockingIOError(11, '')
>>> OSError(11, '')
BlockingIOError(11, '')
>>> OSError(errno.EAGAIN)  # conversion is not done if error message is left out
OSError(11)

Maybe the same approach also works for all other errors (incl. the socket errors). I don't really see why not?
This also helps to keep the source code for Winloop as close as possible to the uvloop source code.

Looks good I have no complains

@lschoe You could also do the same with socket errors since it doesn't kill any time and makes the code smaller.


Show comments doesn't work on Firefox

As title says. Toggle to show comments won't work, even after refreshing the page.
The only way to make them reappear is to disable this extension from extension settings.
Chromium browsers are unaffected.

Never mind. I've switched to shutup.css with Stylus (No Stylish because of privacy concern).
You may still look into this issue if you want though.

I've seen people mention this problem a few times now, but I'm not sure what the cause is. Toggling comments has always worked in Firefox for me, without exception!
https://user-images.githubusercontent.com/233891/139966946-2e3c0dd3-c702-4389-9f30-e3df549723eb.mov
If anyone stumbling upon this GitHub issue looking for help sees this post because they're also seeing this behavior, could you confirm a few things with me?

Does this behavior only occur on specific websites, or does it happen everywhere?
Do you notice any warnings in the developer console when you try to toggle comments?
Is this happening in Private Browsing, or does it happen in normal windows too?
Can you think of any nonstandard config options you're using in Firefox that might have side effects?
As an example: You might not think about:preferences#privacy > Delete cookies and site data when Firefox is closed has any effect, but it actually causes all windows to be treated like Private Browsing windows.

Basically, I need to be able to see this issue myself in order to fix it... but as of yet, I've never seen it, and I don't have any clues. Hoping someone out there can help.

Can you copy the website and paste it there. I'll try testing it. (Even though currently I have no issue with Stylus turning off comments)

Ok so now that's some plain magic. I've just tried it again and it worked now. Perhaps some Firefox issues that got patch in later version? I'm on 94.0.1 now. But let's keep this issue opened for a while before making a final judgement.

Nope it doesn't work again.
https://news.ycombinator.com/item?id=22752131
It appears to be site-specific. For example this one, showing comment won't work until you refresh it, then it'll work for once. But if you refresh it again then comments are broken again.

@thjderjktyrjkt Thank you for testing! This bug is really weird. I recorded this on 94.0.1 too:
https://user-images.githubusercontent.com/233891/141245166-68227970-7fec-4c4e-9d7a-db255add68cf.mp4
🤷⁉
What happens if you go into about:addons and turn off every other extension, then reload the page and try it? Does it work then? The only other extension I have installed is 1Password, and I'm wondering if Shut Up might be conflicting with another extension on your system.
Also... which OS are you running? It should work fine on any OS – even Linux – but maybe we've discovered a new quirk? I'm on macOS but I can test on anything.

about:profile, created a new profile solely to test this.
New profile (Only this extension is installed, no tweak applied):
https://user-images.githubusercontent.com/40300931/141246226-c9c5939d-b042-449b-8941-40058e31670c.mp4
My existing profile with tons of extensions and tweaks:
https://user-images.githubusercontent.com/40300931/141246266-5f02df9c-3616-4568-b134-6e978988b713.mp4
I'm using Fedora. But this issue also occurs on Windows, so it shouldn't be OS specific.

So now the only remaining problems are:

What caused conflict with shutup extension?
Why is Stylus not affected?

It's Dark Reader.
https://user-images.githubusercontent.com/40300931/141247454-c16b83ef-91f8-4269-a3c1-3737640281ac.mp4
But on Chrome Shut Up extension doesn't have issue with Dark Reader. Nor does Stylus, so might need to have further look into this problem.

Perfect! I really appreciate you narrowing down the cause. I can confirm the same issue on my Mac.
https://user-images.githubusercontent.com/233891/141250289-4eb596e6-2aa3-4b60-aef4-46b4a4f0dd77.mp4
Now I can try to fix the conflict! :+1:

Okay, I've done some investigation and determined that I'll need some help from the Dark Reader team to fully resolve this. Bug: https://github.com/darkreader/darkreader/issues/7347
What's happening is their extension is copying my stylesheet into their own style tag, and then they're re-applying all my styles. So when I remove my copy to show comments, their copy of my stylesheet is still in effect, and the comments remain hidden as a result.
(I noticed another issue where Dark Reader and Shut Up are competing to get their stylesheets to the end of the <head> tag, which I'm resolving separately. However, that doesn't appear to be the root cause of this bug.)

As of 14e3ac2c1d182968c0f9dd11c30ccbcb47524028 I've addressed the MutationObserver conflicts with Dark Reader.
For Dark Reader's part, it looks like they fixed the duplicate styles bug on their end with a pretty simple change. They haven't released that fix yet, but given their frequent release schedule it should happen soon.
I'll close this bug after I've verified the fix in Dark Reader.

@thjderjktyrjkt I've tested again with Dark Reader 4.9.43 and it appears to resolve this bug. Thanks again for reporting it!


error: undefined symbol: logging::CheckError::~CheckError()

hi i am try to build this chromium on mac. but found some errors can not compiled
ld64.lld: error: undefined symbol: logging::CheckError::~CheckError()

referenced by obj/chrome/chrome_helper_app_default_executable/chrome_exe_main_mac.o

can you give me some suggestions thanks

This ticket has been moved to RUN-149

This is future-work as of now. Might be able to tend to Chromium for Mac later in 2023.


🚀 v1.0.2

Fixes #14.

Codecov Report

Merging #17 (9617668) into master (cd0ff6c) will decrease coverage by 1.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   85.46%   83.82%   -1.65%
==========================================
  Files          26       26
  Lines         406      408       +2
==========================================
- Hits          347      342       -5
- Misses         59       66       +7

Impacted Files
Coverage Δ

lib/src/translator.dart
86.20% <100.00%> (-2.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0ff6c...9617668. Read the comment docs.


don't delete DataChannerlObserver in OnStateChange

Don't delete DataChannerlObserver in OnStateChange, otherwise it will crash in RTCPeerConnection::~RTCPeerConnection, where it will be deleted again.
Also see the comment in line 418 of PeerConnectionInterface.cc

Thanks for catching this and submitting!  I'll merge it in, but as a heads up we'll be replacing the CX wrapper objects like RTCPeerConnection with C++/WinRT in a week or so, which will eliminate this code.


Occasional disconnections and timeouts when having a degraded cluster behind pgbouncer

Steps to reproduce
Create a 5x postgresql cluster
Create a 3x pgbouncer cluster in front of it
Turn down 2 out of 5 postgresql instances to have a degrated but functional cluster
Try to connect through pgbouncer
Expected behavior
Not to have disconnections or timeouts
Actual behavior
Occasional disconnections and timeouts when having a degraded cluster behind pgbouncer
Versions
OS: Ubuntu 22.04
Juju: 3.5.4
pgbouncer 1/stable       rev396
postgresql 14/stable      rev468
Log output
Start from a 5x pg cluster
# curl <IP_ADDRESS>:8008/cluster | jq | grep -vE "port|lag|timeline|api"
{
  "members": [
    {
      "name": "postgresql-0",
      "role": "sync_standby",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-1",
      "role": "sync_standby",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-2",
      "role": "leader",
      "state": "running",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-3",
      "role": "replica",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-4",
      "role": "replica",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    }
  ]
}

Stop postgresql-0 (sync). It changed postgresql-3 from async to async
{
  "members": [
    {
      "name": "postgresql-1",
      "role": "sync_standby",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-2",
      "role": "leader",
      "state": "running",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-3",
      "role": "sync_standby",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-4",
      "role": "replica",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    }
  ]
}

Stop postgresql-4 (async). Thu Oct 17 08:59:52 PM UTC 2024
{
  "members": [
    {
      "name": "postgresql-1",
      "role": "sync_standby",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-2",
      "role": "leader",
      "state": "running",
      "host": "<IP_ADDRESS>",
    },
    {
      "name": "postgresql-3",
      "role": "sync_standby",
      "state": "streaming",
      "host": "<IP_ADDRESS>",
    }
  ]
}

It looks like a functional cluster
Now, stopped pg instances still show in pgbouncer, making the connection hang sometimes
# pgbouncer config
testdb = host=<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7
testdb_readonly = host=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7

How much time does it take on its own to figure out machines failed?
while (true); do echo "========== $(date)"; grep testdb pgbouncer.ini; sleep 30; done
Thu Oct 17 09:06:55 PM UTC 2024 - 5 min
Thu Oct 17 09:20:25 PM UTC 2024 - 20 min+

I don’t think it will ever notice the two VMs are down, is this okay?
Here the connection logs
It is eventually not connecting, why?

gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
psql: error: connection to server at "<IP_ADDRESS>", port 6432 failed: FATAL:  server login has been failing, try again later (server_login_retry)
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
INSERT 0 1
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
psql: error: connection to server at "<IP_ADDRESS>", port 6432 failed: FATAL:  server login has been failing, try again later (server_login_retry)
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"^C
gustavosr98@pc1-infra1:~$ juju exec -a pgbouncer -- grep testdb /var/snap/charmed-pgbouncer/current/etc/pgbouncer/pgbouncer/instance_0/pgbouncer.ini
pgbouncer/0:
testdb = host=<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7
testdb_readonly = host=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7

pgbouncer/1:
testdb = host=<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7
testdb_readonly = host=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7

pgbouncer/2:
testdb = host=<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7
testdb_readonly = host=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7

gustavosr98@pc1-infra1:~$ juju exec -a pgbouncer -- grep testdb /var/snap/charmed-pgbouncer/current/etc/pgbouncer/pgbouncer/instance_1/pgbouncer.ini
pgbouncer/0:
testdb = host=<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7
testdb_readonly = host=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7

pgbouncer/1:
testdb = host=<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7
testdb_readonly = host=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7

pgbouncer/2:
testdb = host=<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7
testdb_readonly = host=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> dbname=testdb port=5432 auth_user=pgbouncer_auth_relation_7

gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
INSERT 0 1
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
INSERT 0 1
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
INSERT 0 1
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
psql: error: connection to server at "<IP_ADDRESS>", port 6432 failed: FATAL:  server login has been failing, try again later (server_login_retry)
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
INSERT 0 1
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
INSERT 0 1
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
INSERT 0 1
gustavosr98@pc1-infra1:~$ psql -U $USER -w -h $HOSTNAME -d $DATABASE -p $PORT -c "INSERT INTO test VALUES ('g', 3);"
psql: error: connection to server at "<IP_ADDRESS>", port 6432 failed: FATAL:  server login has been failing, try again later (server_login_retry)

Sometimes it taking a lot of time to reponse (15 seg)
time psql -U $USER -w -h $HOSTNAME -d ${DATABASE}_readonly -p $PORT -c "SELECT COUNT(*) FROM test;"
 count
-------
    79
(1 row)

real	0m15.067s
user	0m0.031s
sys	0m0.008s

JFYI, pre-planned the investigation for the next pulse 2024#24.

Hi, @gustavosr98, Postgresql 14/edge (revs. 519, 520) will filter out missing units and units with unexpected status when setting the read only endpoints, so Pgbouncer can in turn update the readonly hosts.


'utf-8' codec can't decode byte 0x?? in position ?: invalid continuation byte

When pastes contain non utf-8 characters, the decoding fails and downloading the paste is being stopped.
Errors logged at:
https://github.com/d-Rickyy-b/pastepwn/blob/1d9b82efa53d948f790b663a54d609150e65b32e/pastepwn/scraping/pastebin/pastebinscraper.py#L96-L100
and:
https://github.com/d-Rickyy-b/pastepwn/blob/1d9b82efa53d948f790b663a54d609150e65b32e/pastepwn/scraping/pastebin/pastebinscraper.py#L123-L140
Example pastes:
2020-02-04 01:17:22,211 - pastepwn.scraping.pastebin.pastebinscraper - ERROR - 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte
2020-02-04 01:17:22,213 - pastepwn.scraping.pastebin.pastebinscraper - ERROR - An exception occurred while downloading the paste 'nDPF9r5b'. Skipping this paste! Exception is: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte
2020-02-04 01:19:19,130 - pastepwn.scraping.pastebin.pastebinscraper - ERROR - 'utf-8' codec can't decode byte 0xe1 in position 2262: invalid continuation byte
2020-02-04 01:19:19,132 - pastepwn.scraping.pastebin.pastebinscraper - ERROR - An exception occurred while downloading the paste 'aeC9BS25'. Skipping this paste! Exception is: 'utf-8' codec can't decode byte 0xe1 in position 2262: invalid continuation byte
2020-02-04 08:17:52,570 - pastepwn.scraping.pastebin.pastebinscraper - ERROR - 'utf-8' codec can't decode byte 0xe1 in position 2262: invalid continuation byte
2020-02-04 08:17:52,636 - pastepwn.scraping.pastebin.pastebinscraper - ERROR - An exception occurred while downloading the paste '0Cq4CYCH'. Skipping this paste! Exception is: 'utf-8' codec can't decode byte 0xe1 in position 2262: invalid continuation byte

For this bug to be fixed, we need to use the raw bytes. That might break many analyzers.

Hi, you have problem in this place:

Hi, I think that you have problem there:
https://github.com/d-Rickyy-b/pastepwn/blob/1d9b82efa53d948f790b663a54d609150e65b32e/pastepwn/util/request.py
You 'except' only TimeoutError and no except other errors.
You need and regex in this part beefore decoding utf-8.


Invalid FTP godocs

godocs is selecting docs from the mocks generated, should be proper.
Along with this re-verify the other go-docs comments present in the package
https://pkg.go.dev/gofr.dev/pkg/gofr/datasource/file/ftp

@aryanmehrotra Greetings Sir, Could you assign this issue to me ?


Trial PR for adding a single one of Anthony's test.

@eaplatanios CI got setup for this repo, and I'm testing it with this PR. I'll then try a second PR for some of the tensor extensions.

@pschuh what builds is the CI compiling? just Linux for now?

The kokoro build only supports linux as of now.


Bank does not open on different screen size

With the help of an assistant (razor/uoassist), if we adjust the screen dimensions outside the default dimensions in sphere, the bank closes immediately 1 second after it is opened.  The bank does not allow it to open.  but after resetting the window size and relogin, it opens without any problem.  When trying this, it is necessary to relogin on every window size change.
Sending the client's window size to sphere as a package, sphere sees it without any problem, but the bank still doesn't open. Tested on different client and sphere versions, and I found that the problem was with sphere. It may be related to the last screensize package or it is related to the coodinat that the bank is trying to open on the screen.

What are u changing the size? the window's size? or the game's size that is inside the windows size? The gump's size? Dosnt happens on old spheres?

Game screen size, yes, previous versions don't have this problem.

If you can make a list of the resolution supported by razor/uoassist i can add them to the screensize command

actually this is completely set by the user, there is no fixed value. whatever the player enters. There are only maximum and minimum values. In fact, I set it as supported by sphereserver, but still the bank does not open.

I changed resolution with Razor, set it to 1600x900, called bank and it remained open

With client 7.0.97 (super recent one) seems like you can't force game resolution by razor

I changed resolution with Razor, set it to 1600x900, called bank and it remained open (client 7.0.20)

After setting the resolution, you need to re-login. Then try opening a bank.

I tried again with client <IP_ADDRESS> but can't reproduce the issue. I set this time the resolution at 1920 x 1080 and the bank stays in place. Hardcoded Gump like Bank, Paperdoll, Statusbar positions are not handled by sphere but by client, i think they are stored in the desktop.uos file in the EaGames/Ultima Online Legacy/blabla/charactername folder

I don't think this issue is client related. There is no such problem when I try on 56b emulator.

Anyway, you wrote in the first post that you need to re-login for the bank to be opened properly.
Razor warns you to restart the client after changing the resolution, so the issue is non existant


Status of openvr integration?

It appears that openvr is integrated but I'm not sure.

OculusVR (current version 1.3.0) is integrated, not OpenVR.


Add code to fetch data from server.

Followed the tutorial to fetch the content in DataServlet and display on Home page.

Please fix comments before merging.

The next time you get an approval, you should first check the comments before merging.
Approval is just to unblock, but there might still be some comments to fix.