Correction for raw affiliation IATE, UMR 1208 INRA-CIRAD-Montpellier Supagro-UM2 - 2 place Pierre Viala, F-34060 Montpellier cedex 01, France, EU

Correction needed for raw affiliation IATE, UMR 1208 INRA-CIRAD-Montpellier Supagro-UM2 - 2 place Pierre Viala, F-34060 Montpellier cedex 01, France, EU
raw_affiliation_name: IATE, UMR 1208 INRA-CIRAD-Montpellier Supagro-UM2 - 2 place Pierre Viala, F-34060 Montpellier cedex 01, France, EU
new_rors: 03rnk6m14;05kpkpg04;0000n5x09
previous_rors: 03rnk6m14;05kpkpg04
works_examples: W3101476938
contact: 129770ab719f38849308884058b82c91:d7afdc27f2e97641937f4f2c22a8ba9edf27 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Online/Web Editor Navigation breaks Cursor

Godot version:

Godot Web Editor 3.2.4 beta 4 https://godotengine.org/editor/latest/godot.tools.html (Currently b5e8b48)
OS/device including version:

Windows 10 1909, Google Chrome
Issue description:

When Holding Mouse Button to Look around the scene, like in the offline editor, once the button is no longer held, The Cursor doesn't come back, forcing the user to use esc to free the Cursor, which is an annoyance
Steps to reproduce:

Make/Load a project
Try looking around with the cursor
Stop holding the mouse button
Notice how the Cursor doesn't come back
Press Esc to Get the Cursor back

Minimal reproduction project:

Cannot make MRP

Try looking around with the cursor

By "looking around with the cursor", you mean using 3D freelook?

Confirmed on Firefox 84.0 / Ubuntu 20.04 looking around a 3D scene with the mouse.

Yea, it's the Right Mouse Button, for rotating The camera, not the middle mouse button that's Blender like rotation.


Added BackButtonIcon to trivialize creating IconButtons that look like (platform specific) back buttons but behave differently.
Fixes #9601

needs a test


Add numeric compare for validation

Hi,
I needed numeric compare when pre-post validate such as cpu_use,memory_available.
for example, less than memory 50% is executed by commit_config.

modified: _compare_getter_dict
add method: compare_numeric
add test: get_environment

Sorry for the late response on this. Looks good so I will merge after we add a note to the documentation.
Thanks!

Thanks!  I'll add a note to the documentation and send PR right away :-)

Sent PR to napalm #377

Great job, thanks!


enhancement - bind to IP and display full URL in

Just tried ttyd today and found it wasn't easy to work out which IP address it's accessible on as the computer has multiple IPv4 and IPv6 addresses and interfaces.

it would be nice to display a full URL although I can understand this might prove difficult to work out what the "best" address would be
i would be nice to specify an IP address for ttyd to bind to,and not just an interface

Use case is that we have computers with multiple IP addresses on different networks, some secure (vpn) & some public, and knowing which IP ttyd will bind to is important for staying secure on the safe network.

This should already works (at least on *nix) with the -i option, try ttyd -i <IP_ADDRESS>.
Feel free to reopen if you have problems with this.

@tsl0922 thanks - the docs state     --interface, -i         Network interface to bind (eg: eth0), or UNIX domain socket path (eg: /var/run/ttyd.sock) can you amend that to "IP address or Network interface to bind (eg: eth0), or UNIX domain socket path (eg: /var/run/ttyd.sock)` for the next person?
Also, when I run this on FreeBSD I get:
 ttyd -i <IP_ADDRESS> tmux -u new
[2017/09/29 21:52:28:0244] NOTICE: ttyd 1.3.3 (libwebsockets 2.2.2)
[2017/09/29 21:52:28:0244] NOTICE: tty configuration:
[2017/09/29 21:52:28:0244] NOTICE:   start command: tmux -u new
[2017/09/29 21:52:28:0244] NOTICE:   reconnect timeout: 10s
[2017/09/29 21:52:28:0244] NOTICE:   close signal: SIGHUP (1)
[2017/09/29 21:52:28:0244] NOTICE: Initial logging level 7
[2017/09/29 21:52:28:0244] NOTICE: Libwebsockets version: 2.2.2 unknown-build-hash
[2017/09/29 21:52:28:0244] NOTICE: IPV6 compiled in and enabled
[2017/09/29 21:52:28:0244] NOTICE: libev support not compiled in
[2017/09/29 21:52:28:0244] NOTICE: libuv support not compiled in
[2017/09/29 21:52:28:0245] NOTICE:  Threads: 1 each 3770172 fds
[2017/09/29 21:52:28:0543] NOTICE:  mem: platform fd map: 30161376 bytes
[2017/09/29 21:52:28:0543] NOTICE:  Compiled with OpenSSL support
[2017/09/29 21:52:28:0543] NOTICE:  SSL disabled: no LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT
[2017/09/29 21:52:28:0543] NOTICE: Creating Vhost 'default' port 7681, 2 protocols, IPv6 on
[2017/09/29 21:52:28:0553] ERR: ERROR on binding fd 6 to port 7681 (-1 48)
[2017/09/29 21:52:28:0553] ERR: init server failed
[2017/09/29 21:52:28:0553] ERR: Failed to create default vhost
[2017/09/29 21:52:28:0553] ERR: libwebsockets init failed

however trying it on a different IP does work:
 ttyd -i  fe80::ae1f:6bff:fe15:2d78  tmux -u new
[2017/09/29 21:54:23:1437] NOTICE: ttyd 1.3.3 (libwebsockets 2.2.2)
[2017/09/29 21:54:23:1437] NOTICE: tty configuration:
[2017/09/29 21:54:23:1437] NOTICE:   start command: tmux -u new
[2017/09/29 21:54:23:1437] NOTICE:   reconnect timeout: 10s
[2017/09/29 21:54:23:1437] NOTICE:   close signal: SIGHUP (1)
[2017/09/29 21:54:23:1437] NOTICE: Initial logging level 7
[2017/09/29 21:54:23:1437] NOTICE: Libwebsockets version: 2.2.2 unknown-build-hash
[2017/09/29 21:54:23:1437] NOTICE: IPV6 compiled in and enabled
[2017/09/29 21:54:23:1437] NOTICE: libev support not compiled in
[2017/09/29 21:54:23:1437] NOTICE: libuv support not compiled in
[2017/09/29 21:54:23:1438] NOTICE:  Threads: 1 each 3770172 fds
[2017/09/29 21:54:23:1763] NOTICE:  mem: platform fd map: 30161376 bytes
[2017/09/29 21:54:23:1763] NOTICE:  Compiled with OpenSSL support
[2017/09/29 21:54:23:1764] NOTICE:  SSL disabled: no LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT
[2017/09/29 21:54:23:1764] NOTICE: Creating Vhost 'default' port 7681, 2 protocols, IPv6 on
[2017/09/29 21:54:23:1773] NOTICE:  Listening on port 7681
[2017/09/29 21:54:23:1773] NOTICE:  mem: per-conn:          568 bytes + protocol rx buf
[2017/09/29 21:54:23:1773] NOTICE:  canonical_hostname = wintermute.skunkwerks.at
^C[2017/09/29 21:54:30:2058] NOTICE: received signal: SIGINT (2), exiting...
[2017/09/29 21:54:30:2058] NOTICE: send ^C to force exit.
[2017/09/29 21:54:30:2059] NOTICE: lws_context_destroy: ctx 0x8006ab000
[2017/09/29 21:54:30:2059] NOTICE: lws_context_destroy2: ctx 0x8006ab000

I'm not clear what the difference between these interfaces is;
igb0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=e505bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,LRO,VLAN_HWFILTER,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6>
	ether ac:1f:6b:15:2d:78
	inet6 fe80::ae1f:6bff:fe15:2d78%igb0 prefixlen 64 scopeid 0x1
	inet <IP_ADDRESS> netmask 0xffffff00 broadcast <IP_ADDRESS>
	nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>
	media: Ethernet autoselect (1000baseT <full-duplex>)
	status: active
igb1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=e505bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,LRO,VLAN_HWFILTER,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6>
	ether ac:1f:6b:15:2d:79
	inet <IP_ADDRESS> netmask 0xffff0000 broadcast <IP_ADDRESS>
	inet6 fe80::ae1f:6bff:fe15:2d79%igb1 prefixlen 64 scopeid 0x2
	nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>
	media: Ethernet autoselect (1000baseT <full-duplex>)
	status: active
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
	options=600003<RXCSUM,TXCSUM,RXCSUM_IPV6,TXCSUM_IPV6>
	inet6 ::1 prefixlen 128
	inet6 fe80::1%lo0 prefixlen 64 scopeid 0x3
	inet <IP_ADDRESS> netmask 0xff000000
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
	groups: lo
lo1: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
	options=600003<RXCSUM,TXCSUM,RXCSUM_IPV6,TXCSUM_IPV6>
	inet <IP_ADDRESS> netmask 0xffff0000
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	inet <IP_ADDRESS> netmask 0xffffffff
	nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
	groups: lo
zt1flo98dm0peka: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 5000 mtu 2800
	options=80000<LINKSTATE>
	ether 8a:58:82:3c:2f:91
	hwaddr 00:bd:8d:32:f7:09
	inet <IP_ADDRESS> netmask 0xffff0000 broadcast <IP_ADDRESS>
	inet6 fc7b:dbb3:c9e2:8e50:6c98::1 prefixlen 40
	inet6 fc7b:dbb3:c9e2:8e50:6c98::2 prefixlen 128
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
	media: Ethernet autoselect
	status: active
	groups: tap
	Opened by PID 1322
zt1flo98dm17np8: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 5000 mtu 2800
	options=80000<LINKSTATE>
	ether 2a:3d:9d:3c:2f:91
	hwaddr 00:bd:9d:32:f7:0a
	inet <IP_ADDRESS> netmask 0xffff0000 broadcast <IP_ADDRESS>
	inet6 fc7b:c4d6:6be2:8e50:6c98::1 prefixlen 40
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
	media: Ethernet autoselect
	status: active
	groups: tap
	Opened by PID 1322

@dch sorry, I didn't test it on FreeBSD (will do it later, I'm on a vacation now).
The server functionality of ttyd is provided by the libwebsocket library, this maybe it's issue (to be confirmed).

I'm closing this now since there's nothing can be done on ttyd's side, you may want to file an issue to the libwebsockets project.


GitHub Actions

I think we could simplify the lesson by demonstrating automated testing with GitHub actions:

no new account to create
nothing to enable and not a different tab to switch to
better support for testing on macOS and Windows
all you need to do is add a file, that's it
we could point learners to the many examples for other languages

I can adjust lesson but don't want to change it now under @blindij feet.
But I think the minimum we need to do and this is what I would ask @blindij to do in the upcoming workshops is to at least mention it.
Otherwise we can look outdated. I still like and will use Travis but for many situations GH Actions is just simpler.

I agree. Travis seems an overkill in many simple projects. We should definitely teach it.

I mean github actions!

I really really like github actions, but really don't like the monopolization.  Still, seems like what we need to do.
I recently decided what I should do to avoid lock-in: I will try to avoid putting the test scripts in the github-specific YAML file, but in some makefile (or equivalent) with targets such as test-install and test-run, if it's not trivial.  So, at least porting to a new CI system is relatively easy.  But of course, then we lose some of the power of GHA.
Anyway, I would support mentioning the alternatives and lock-in potential, but fully switching to GHA. The easier it is to test, the more people who will, and I accept the trade off...


Stickied discussions at the top of group show

Not sure if this is something the end user should end up implementing. There could be a list of labels (including locked/stickied) in the discussion listing partial.

It should at least be delivered in the stock view.


Allow one peer to claim an un-allocated address from another

IPAM supports an (undocumented) 'claim' function at start-up so containers that are already running with an IPAM address can get that address reserved.  But currently this only works if the current node owns the range.  We could extend this so the claiming peer sends a message to the owning peer to see if it can get it.

Fixed by #1159.


Android : Unable to get provider cl.json.RNShareFileProvider

Hi there,
I was using your plugin for weeks, and it was working well. But today, after updating some plugins -which yours-, I am getting my Android app crashing on launch :
 Unable to get provider cl.json.RNShareFileProvider: java.lang.ClassNotFoundException: Didn't find class "cl.json.RNShareFileProvider" on path: DexPathList
If I removed your plugin, my application works just fine. Any idea to solve this issue ? I followed the manual link installation
Environment

React Native version: 0.59.8
React Native platform + platform version: Android

react-native-share
Version:  1.21
Thanking you in advance

This is some sort of install failure - that class was added and should be found
Recommend installing react-native-clean-project then doing react-native clean-project-auto followed by a reinstalling modules and rebuilding (don't forget pod install if you use pods)
You can check to make sure it works by looking at the example in the module itself - it builds correctly

Hi @mikehardy ,
Thanks for your quick reply. I tried the what you said, but I am still getting the error... Plus, It is happening on the APK from my circle.ci (which is every time from a fresh install then).
I can create the APKs, but I cannot launch them. Any idea ?

Most CIs do some sort of caching, that has tripped me up before. Not saying that's the case, just that I don't assume CI is clean unless I verify it.
All I can say is, clone the project, and run the example. It should work. If it doesn't we have a real bug, if it does run, there is something different between the example and your project, and it must be related to https://github.com/react-native-community/react-native-share/pull/490

@mikehardy  Have you tested in android 4.4 sdk 19? This issue is happening for me just with android4, after I started a new project with react-native init myproject.
#adb logcat *:E
Caused by: java.lang.ClassNotFoundException: Didn't find class "cl.json.RNShareFileProvider" on path: DexPathList[[zip file "/data/app/com.prevendamovel-1.apk"],nativeLibraryDirectories=[/data/app-lib/com.prevendamovel-1, /vendor/lib, /system/lib]]
#My environment:
#react-native info

info Fetching system and libraries information...
Binaries:
Node: 11.10.0 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.7.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 24, 25, 26, 27, 28, 29
Build Tools: 27.0.3, 28.0.3
System Images: android-19 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-24 | Google APIs Intel x86 Atom, android-24 | Google Play Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.3 => 0.60.3
npmGlobalPackages:
react-native-alert-async: 1.0.3
react-native-clean-project: 3.2.4
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7
react-native-html-to-pdf: 0.8.0
react-native-navigation: 2.16.0
react-native-rename: 2.4.1
react-native-share: 1.1.3

Seems like it be some sort of MultiDex issue if it's Android 4 only. MultiDex goes away in Android 5 so 4 vs 5 differences are almost always MultiDex.
I just checked my autolinking/RN60 example PR #570 and it worked fine in API18 and didn't crash on API16 but did have a problem there. something isn't perfect about the fileprovider, but it isn't a ClassNotFoundException.
I'd suspect you aren't extending MultiDexApplication or similar in MainApplication, or don't have multidex enabled etc?

Thks @mikehardy
I have isolated the libraries and also added this in app/build.gradle:
android {
    defaultConfig {
       multiDexEnabled true
    }
}


Fix string vs integer definitions

So these fixes I think are correct based on all the items in the Devices Database.
In the existing schemas
1.  The schema for baud rate is specified as a string, but in the documentation and all the example json's the field is populated as an integer
2. The schema for timetable device actions is specified as a string, the documentation also shows examples as a string, but in the one example "Switch with power measure|2x50A" from the Device Database it is populated as an integer.    Im assuming that the example is correct because I presume otherwise it wouldnt have worked.   But I guess the example could be wrong.
With these updates, all examples from the DeviceDatabase pass schema validation.

Note:  I wasnt able to figure out how to update the Wiki docs for timetable device actions.    You will need to change the docs on that one to not use "" around the numbers and to confirm it should be an integer not a string.

Note: I wasnt able to figure out how to update the Wiki docs for timetable device actions. You will need to change the docs on that one to not use "" around the numbers and to confirm it should be an integer not a string.

Could you tell me exactly where is it? I am not able to find it in the Wiki.

Many thanks!

Note: I wasnt able to figure out how to update the Wiki docs for timetable device actions. You will need to change the docs on that one to not use "" around the numbers and to confirm it should be an integer not a string.

Could you tell me exactly where is it? I am not able to find it in the Wiki.

I think that I know what is happening. Device actions must be declared as string "0", "1"... because JSON keys must be strings, but they must be used as integer when used as value into "tt" array.

I changed description of A, changing "0" to "50" part to 0 to 50.

You should also change it at the bottom of this ref.    https://github.com/RavenSystem/esp-homekit-devices/wiki/General-Configuration#Device-actions   as it shows "50"

It would probably be a good idea to note in the docs about how the actions need to be a string when used as a key, but need to be an integer when used as a value.   I mean I understand that, but Im not sure everyone else would without the explanation.

You should also change it at the bottom of this ref. https://github.com/RavenSystem/esp-homekit-devices/wiki/General-Configuration#Device-actions as it shows "50"

These declarations are keys and they must be strings.


Add styles

Create styles.css document and add it to html

this branch has to be merged in develop branch


Notifications Can Be Lost

There is a race condition with progress notifications. A notification can occur before
the progress callback is attached to a promise and unlike the reject or done callbacks which are stored and triggered they will be lost.
I have a fix for it using a list that is flushed when the progress is attached.

What should be the right behavior for a single callback vs if there are multiple callbacks?  I.e., we can't guarantee that all notifications are buffered and replayed for every new callback registration.
if we do this only for the first registration, then the subsequent registrations may have different behaviors.
What is the use case in this particular use case where not a single notifications can be missed?
Thanks!

Hi,
You are correct in that as multiple progress callbacks can be attached asynchronously to the promise it cannot be guaranteed that all progress callbacks will receive all notifications.
That being said, I have not yet come across a scenario where using multiple progress recipients has been useful, however guaranteed notifications for a promise that uses the progress mechanism certainly has been.
The use case that highlighted notifications being lost was when attaching promises to a I/O stream/pipe to deliver data asynchronously to the consumer. Data is delivered on the progress() callback and done()/reject() is called when the data stream completes in success or error. Data cannot be lost in this scenario.
Maybe if multiple guaranteed progress notifications were required this could be achieved by using multiple promises and chaining rather than a single promise with multiple recipients.
Thanks.


use other: Self instead of other: Column

We're not saying that
s1: PandasColumn
s2: FancyColumn
s1 + s2

is supported, so let's use Self
Else implementations will get
t.py:18: error: Argument 1 of "add" is incompatible with supertype "Cat"; supertype defines the argument type as "Cat"  [override]
t.py:18: note: This violates the Liskov substitution principle
t.py:18: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
t.py:21: error: Argument 1 of "sub" is incompatible with supertype "Cat"; supertype defines the argument type as "Cat"  [override]
t.py:21: note: This violates the Liskov substitution principle
t.py:21: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
Found 2 errors in 1 file (checked 1 source file)

What happens if a library wants to allow using other libraries columns as well as their own?
I.E. cudf may want to allow any CPU or other NVIDIA GPU library as input, assuming we eventually tie the interchange protocol and API together similarly to what was done in the array API.

that would be fair enough, but I'm not sure it should be part of the standard?
typing other: Column in theory means "any object which implements the Column protocol can be passed here", which even in the cudf case wouldn't be true

thanks for your review!


Slack connect

Adding standalone option for connecting to slack, will later be used for notifying based on events.

@bermaj Has your Slack code been pushed? I don't see it here.

Whoops, looks like it didn't get added


Remove version: CrystalDewWorld.CrystalDiskInfo.ShizukuEdition version 8.10.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://osdn.net/frs/redir.php?m=ipconnect&f=crystaldiskinfo%2F74490%2FCrystalDiskInfo8_10_0Shizuku.exe
Response Error: The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.
(Automated message - build 923)


Request support for ESM

▲ [WARNING] Module 'quill-delta' used by 'node_modules/quill/core.js' is not ESM

  CommonJS or AMD dependencies can cause optimization bailouts.
  For more information see: https://angular.io/guide/build#configuring-commonjs-dependencies

This would be awesome! 🙏🏼

Any timeline on this? Thanks.

Application: Angular CLI with PrimeNG UI
problem when running terminal:  [WARNING] Module 'quill-delta' used by 'node_modules/quill/core.js' is not ESM
Solution: angular.json
            "production": {               "budgets": [                 {                   "type": "initial",                   "maximumWarning": "50MB",                   "maximumError": "100MB"                 },                 {                   "type": "anyComponentStyle",                   "maximumWarning": "2kB",                   "maximumError": "4kB"                 }               ],               "outputHashing": "all"             },

Any update on this issue?


Fix #1 (Reforged: Soul Shards -> JER Integration)

Thanks!

Thanks!

I don't not why i didn't see this earlier :/


IAM controller recommended inline policy needs iam:UpdateAssumeRolePolicy

Describe the bug
v1.2.0 ack-iam-controller needs iam:UpdateAssumeRolePolicy. The recommended-inline-policy should be updated to include this action.
Steps to reproduce
Run v1.2.0, logs report:
"error": "AccessDenied: User: xxx is not authorized to perform: iam:UpdateAssumeRolePolicy on resource: role xxx because no identity-based policy allows the iam:UpdateAssumeRolePolicy action

Expected outcome
Controller should be able to update assume role policy document per https://github.com/aws-controllers-k8s/iam-controller/pull/74
Environment

Kubernetes version: 1.25.6
Using EKS (yes/no), if so version? yes 1.25
AWS service targeted (S3, RDS, etc.) IAM

Thank you for catching this @rlister - it's a pretty simple one to fix. Are you interested in contributing to the iam-controller? :)

This has been open for a little while now, but since it directly relates to a change I made I've linked a PR to fix it.
I don't see any code generation for the inline policy itself and it has the Sid of VisualEditor, so I believe it is a simple line change.

Completed now.


Update Tests

The tests for the update command are all commented out as I haven't yet had the time to think about how we would go about testing it, as I assume we would need to test that a deps.ts has been modified to upgrade versions, but we'd want this file to be defaulted to it's original state for the other update tests

Finish the tests inside /tests/update_test.ts

I believe it can be done like so:

Have an original_deps.ts and a deps.ts, both with the same content.
Run the update tests and when the deps.ts gets updated, replace it with the original (at the end of the test)

Sounds like a solid solution


rebecca had chris inventory

Version
3.2.1 (0770993)
Seed
R710-0BN4-XNHH5077Z9YN003N9KWK2E94ZZZVZZZQZZZZZZZQGJFUZZZZZ
Scenario
RE 1 (Chris)
Player Character
re6 leon
What happened?
at the part where you fight plant 42 and rebecca comes in and chris sends her to go make vjolt, when i took control of what would have been rebecca(it was billy) they had what would have been chris inventory instead of their own, rebecca and chris arent supposed to share an inventory.

Yep this was necessary for the 8 item slots. You can use the item box, so you should be able to make space for V-JOLT.


on adding technologies which can be applied by systems having roles e.g. electrical energy distribution system

Components of 'energy distribution system'
The way how an energy distribution system is composed should be describable by bringing some technologies together. Technologies on their role combine artificial objects (in this case energy distribution system's components) or other material entities in a specific way.
Ideas of solution

add 'energy distribution system components' (e.g. cables, etc..) as a sub class of 'artificial object'
add 'electricity distribution system' as sub class 'supply system'/'energy system'
add 'electricity distribution technology' as a 'technology'
make 'electricity distribution system' applying 'electricity distribution technology'

So one can, for example, constraint the specification of a distribution system or describe a distribution system to a model.
Further more one can define some measurable quantities characterising such systems.
Workflow checklist

[x] I discussed the issue with someone else than me before working on a solution
[x] I already read the latest version of the workflow for this repository
[x] The goal of this ontology is clear to me

I am aware that

[x] every entry in the ontology should have a definition
[x] classes should arise from concepts rather than from words

Thanks for the proposal @koubaa-hmc. Adding a concept for electricity distribution technology is sensible.
I have some questions to clarify:

add 'electricity distribution system' as sub class 'supply system'/'energy system'

Is your proposed electricity distribution system equivalent to the already existing power system OEO_00360017 A power system is an energy system covering the generation, transportation, distribution and consumption of electrical energy.?

If yes, we should add "electricity distribution system" as alternative label.
If not, how would you differentiate? Could you propose a definition?

add 'energy distribution system components' (e.g. cables, etc..) as a sub class of 'artificial object'

Same as above: is your proposed energy distribution system comüponent equivalent to the existing gird component OEO_00020006 ?

Even though the OP seems to be no longer active, should we look into this? Make our own choices regarding the new concepts?
Since we have no reason to assume electricity distribution system to be different from power system I believe going with the alternative lable would be a good choice.
The second question is trickier. Energy distribution system component was meant to means something like "cable" or maybe "plug" and I feel like it starts where the energy grid ends. But that may be due to my limited understanding of grid component.

A more detailed distrinction into power systems is part of #1960.
@madbkr take a look at OEO_00020006 for the detailed grid component hierarchy (not yet exhaustive though)


🐛 Camera start and stop issues

Looks like camera device is struggled to start and stop immediately
What
We are building an app with React Navigation.
So each screen is actually a view, that is manipulated by the library on navigation.
I have found that if I "open a screen" with the CameraView being active by default, there are problems:

the frame processor doesn't get called on iOS
on some Android devices turning on flashlight leads to crash.

If I add a delay before making CameraView active like so:
  useEffect(() => {
    if (!visible) {
      setTrueVisible(false);
      return () => {};
    }
    const timeout = setTimeout(() => setTrueVisible(true), 20);
    return () => clearTimeout(timeout);
  }, [visible, setTrueVisible]);

And the same applies to the CameraView destroying.
When I navigate back, the camera stays active (can be seen by green dot indicator in iPhone).
But if I first make it inactive and then navigate back after a small delay - all is fine.
Tried to update the library to the lates version (2.4.1) - same result.
Is this delay mandatory or smith else is the source of the issue?
Logs
The problem was found by lack of logs.
Actually there are no errors in the logs. Just actual misbehavior...
¯_(ツ)_/¯
Reproducable sample
Try to add this view and alter visible prop. Mb by button.
import React, { useEffect, useMemo, useRef } from 'react';
import { StyleSheet, NativeModules, NativeEventEmitter } from 'react-native';
import {
  Camera,
  useCameraDevices,
  useFrameProcessor,
} from 'react-native-vision-camera';

import useAppState from '../../../hooks/useAppState';
import { useCameraPermissions } from '../hooks';
import { PermissionStatus } from '../types';
import scanQRCodes from '../../../util/vision-camera-qr-scanner';

export default ({ visible, flash, onScannedCodes }: Props) => {
  const camera = useRef<Camera>(null);
  const { status } = useCameraPermissions();
  const devices = useCameraDevices();
  const appState = useAppState();
  const device = useMemo(
    () => (status === PermissionStatus.allowed ? devices.back : undefined),
    [devices, status]
  );
  const isForeground = useMemo(() => visible && appState === 'active', [
    visible,
    appState,
  ]);

  useEffect(() => {
    const subscription = eventEmitter?.addListener(
      'onQRCodesScanned',
      (result) => onScannedCodes?.(result.codes)
    );
    return () => subscription?.remove();
  }, []);

  const frameProcessor = useFrameProcessor(
    (frame) => {
      'worklet';

      scanQRCodes(frame);
    },
    [scanQRCodes]
  );

  return device ? (
    <Camera
      ref={camera}
      style={StyleSheet.absoluteFill}
      device={device}
      torch={visible && flash ? 'on' : 'off'}
      isActive={isForeground}
      frameProcessor={frameProcessor}
      frameProcessorFps={2}
      photo
      video
    />
  ) : null;
};

Environment

Platform(s):

[V] iOS
[V] Android

react-native version: 0.64.1
react-native-vision-camera version: 2.2.0
react-native-reanimated version: 2.2.0

A released question I asked earlier !190

This happens on both iOS and Android?
Can you log isForeground? Does it actually have true when you expect the camera to open?
Can you run the project in Xcode/Android Studio and share the native logs with me? Maybe there's something being logged there...
Does it work if you use the following code:

  return device ? (
    <Camera
      ref={camera}
      style={StyleSheet.absoluteFill}
      device={device}
      isActive={true}
      frameProcessor={frameProcessor}
      frameProcessorFps={2}
      video={true}
    />
  ) : null;

?

On Android looks like it works (no frame processor, just takeSnapshots
Yes, I logged, it is true.
Logs are coming (the case without delay)
Same result unfortunately
Happens always despite of hot reload or cold start

The iOS log right after navigating to the screen with the camera:
2021-06-28 19:06:29.182929+0300 emma dev[2144:890642] [javascript] 'currentlyFocusedField is deprecated and will be removed in a future release.

Looks like it just skipped the frame processor adding?

This is Android logs for the same case:
2021-06-28 19:09:09.627 929-929/? W/adbd: timeout expired while flushing socket, closing
2021-06-28 19:09:10.069 17592-20176/com.emmaprod E/ReactNativeJS: 'currentlyFocusedField is deprecated and will be removed in a future release. Use currentlyFocusedInput', '\nTransitioner@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:135346:36\nStackView@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:132204:36\nNavigator@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:131503:38\nKeyboardAwareNavigator@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:131617:38\nNavigationContainer@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:129320:38\nRCTView\nView\nErrorBoundaries@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:460506:36\nNavigator@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:458504:36\nConnect(Navigator)@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:118562:43\nRCTView\nView\nApp@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:122830:36\nConnect(App)@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:118562:43\nRNCSafeAreaProvider\nSafeAreaProvider@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:121469:24\nProvider@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:118139:21\nRoot@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:117941:36\nRCTView\nView\nRCTView\nView\nAppContainer@http://localhost:8081/index.android.bundle?platform=android&dev=true&minify=false&app=com.emmaprod&modulesOnly=false&runModule=true:68170:36'
2021-06-28 19:09:10.111 17592-17592/com.emmaprod E/libc: Access denied finding property "vendor.camera.aux.packagelist"
2021-06-28 19:09:10.104 17592-17592/com.emmaprod W/com.emmaprod: type=1400 audit(0.0:21979): avc: denied { read } for name="u:object_r:persist_camera_prop:s0" dev="tmpfs" ino=2223 scontext=u:r:untrusted_app:s0:c232,c256,c512,c768 tcontext=u:object_r:persist_camera_prop:s0 tclass=file permissive=0
2021-06-28 19:09:10.344 17592-17592/com.emmaprod W/CameraView: CameraViewModule::getAvailableCameraDevices took: 240 ms
2021-06-28 19:09:11.054 17592-17592/com.emmaprod W/CameraX-core_ca: type=1400 audit(0.0:21980): avc: denied { read } for name="u:object_r:persist_camera_prop:s0" dev="tmpfs" ino=2223 scontext=u:r:untrusted_app:s0:c232,c256,c512,c768 tcontext=u:object_r:persist_camera_prop:s0 tclass=file permissive=0
2021-06-28 19:09:11.068 17592-20629/com.emmaprod E/libc: Access denied finding property "persist.vendor.camera.privapp.list"
2021-06-28 19:09:11.070 953-24003/? E/CameraService: tom han set sys.camera 000 ....
2021-06-28 19:09:11.114 17592-17592/com.emmaprod W/Binder:17592_7: type=1400 audit(0.0:21981): avc: denied { read } for name="u:object_r:persist_camera_prop:s0" dev="tmpfs" ino=2223 scontext=u:r:untrusted_app:s0:c232,c256,c512,c768 tcontext=u:object_r:persist_camera_prop:s0 tclass=file permissive=0
2021-06-28 19:09:11.120 17592-24079/com.emmaprod E/libc: Access denied finding property "vendor.camera.aux.packagelist"
2021-06-28 19:09:11.121 17592-24079/com.emmaprod E/libc: Access denied finding property "vendor.camera.aux.packagelist"
2021-06-28 19:09:11.114 17592-17592/com.emmaprod W/Binder:17592_7: type=1400 audit(0.0:21982): avc: denied { read } for name="u:object_r:persist_camera_prop:s0" dev="tmpfs" ino=2223 scontext=u:r:untrusted_app:s0:c232,c256,c512,c768 tcontext=u:object_r:persist_camera_prop:s0 tclass=file permissive=0
2021-06-28 19:09:11.511 17592-20075/com.emmaprod W/OpenGLRenderer: Surface doesn't have any previously queued frames, nothing to readback from
2021-06-28 19:09:11.527 17592-17592/com.emmaprod E/SurfaceViewImpl: PreviewView.SurfaceViewImplementation.getBitmap() failed with error 3
2021-06-28 19:09:11.884 753-753/<EMAIL_ADDRESS>type=1400 audit(0.0:21983): avc: denied { read } for name="u:object_r:default_prop:s0" dev="tmpfs" ino=2152 scontext=u:r:hal_camera_default:s0 tcontext=u:object_r:default_prop:s0 tclass=file permissive=0
2021-06-28 19:09:11.890 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.894 753-753/? E/walog/SCamera: module name: defualt -> HMD_M582
2021-06-28 19:09:11.895 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.895 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.884 753-753/<EMAIL_ADDRESS>type=1400 audit(0.0:21984): avc: denied { read } for name="u:object_r:default_prop:s0" dev="tmpfs" ino=2152 scontext=u:r:hal_camera_default:s0 tcontext=u:object_r:default_prop:s0 tclass=file permissive=0
2021-06-28 19:09:11.904 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.904 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.904 753-753/? E/walog/SCamera: module name: defualt -> HMD_M582
2021-06-28 19:09:11.904 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.904 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.904 753-753/? E/walog/SCamera: module name: defualt -> HMD_M582
2021-06-28 19:09:11.904 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.905 753-753/? E/libc: Access denied finding property "persist.wa.log.level"
2021-06-28 19:09:11.908 779-855/? E/ANDR-PERF-RESOURCEQS: Failed to apply optimization [2, 1]
2021-06-28 19:09:11.908 779-855/? E/ANDR-PERF-RESOURCEQS: Failed to apply optimization [2, 0]
2021-06-28 19:09:11.908 779-855/? E/ANDR-PERF-RESOURCEQS: Failed to apply optimization [2, 1]
2021-06-28 19:09:11.908 779-855/? E/ANDR-PERF-RESOURCEQS: Failed to apply optimization [2, 0]
2021-06-28 19:09:11.908 779-855/? E/ANDR-PERF-RESOURCEQS: Failed to apply optimization [2, 1]
2021-06-28 19:09:11.908 779-855/? E/ANDR-PERF-RESOURCEQS: Failed to apply optimization [2, 0]
2021-06-28 19:09:11.908 779-855/? E/ANDR-PERF-RESOURCEQS: Failed to apply optimization [2, 1]
2021-06-28 19:09:11.908 779-855/? E/ANDR-PERF-RESOURCEQS: Failed to apply optimization [2, 0]
2021-06-28 19:09:11.988 753-753/? E/mm-camera: <STATS ><ERROR> 3068: stats_port_check_caps_reserve: Invalid Port capability type!
2021-06-28 19:09:11.988 753-753/? E/mm-camera: <STATS ><ERROR> 3068: stats_port_check_caps_reserve: Invalid Port capability type!
2021-06-28 19:09:12.025 17592-20075/com.emmaprod W/OpenGLRenderer: Surface doesn't have any previously queued frames, nothing to readback from
2021-06-28 19:09:12.043 17592-17592/com.emmaprod E/SurfaceViewImpl: PreviewView.SurfaceViewImplementation.getBitmap() failed with error 3
2021-06-28 19:09:12.059 753-753/? E/libc: Access denied finding property "ro.camera.req.fmq.size"
2021-06-28 19:09:12.062 753-753/? E/libc: Access denied finding property "ro.camera.res.fmq.size"
2021-06-28 19:09:12.100 753-3515/? E/mm-camera: <SENSOR><ERROR> 203: module_sensor_offload_init_config: tom han module_sensor_offload SENSOR_INIT success
2021-06-28 19:09:12.108 753-753/? E/CamComm1.0-MD: Mismatched tag type when updating entry enable (-2146762752) of type byte; got type int32 data instead
2021-06-28 19:09:12.108 753-753/? E/CamComm1.0-MD: Mismatched tag type when updating entry is_main (-2146762751) of type byte; got type int32 data instead
2021-06-28 19:09:12.114 953-24003/? W/CameraDeviceClient: createSurfaceFromGbp: Camera 0 with consumer usage flag: 2304: Forcing asynchronous mode for stream
2021-06-28 19:09:12.115 953-24003/? W/CameraDeviceClient: createSurfaceFromGbp: Camera 0: Overriding format 0x4 to IMPLEMENTATION_DEFINED
2021-06-28 19:09:12.117 753-3515/? E/mm-camera: <SENSOR><ERROR> 246: module_sensor_offload_init_config: tom han module_sensor_offload is_insensor success
2021-06-28 19:09:12.133 753-3515/? E/mm-camera: <SENSOR><ERROR> 37: af_actuator_power_up: failed: rc = -1
2021-06-28 19:09:12.133 753-3515/? E/mm-camera: <SENSOR><ERROR> 710: af_actuator_init: failed rc -5
2021-06-28 19:09:12.133 753-3515/? E/mm-camera: <SENSOR><ERROR> captain_hi1336_back_hlt_i_autofocus_calibration: 491: [af otp] marco: 593, infinity: 143
2021-06-28 19:09:12.133 753-3515/? E/mm-camera: <SENSOR><ERROR> captain_hi1336_back_hlt_i_autofocus_calibration: 507: [ af otp] adjusted code_per_step: 121, qvalue: 128
2021-06-28 19:09:12.136 753-3515/? E/mm-camera: <SENSOR><ERROR> 293: module_sensor_offload_init_config: tom han module_sensor_offload AEC success
2021-06-28 19:09:12.137 753-3515/? E/mm-camera: <SENSOR><ERROR> 312: module_sensor_offload_init_config: tom han module_sensor_offload all Success
2021-06-28 19:09:12.155 753-3503/? E/mm-camera: <IMGLIB><ERROR> 322: module_depth_map_handle_ctrl_parm: E
2021-06-28 19:09:12.155 753-3503/? E/mm-camera: <IMGLIB><ERROR> 430: module_depth_map_set_config_param: X
2021-06-28 19:09:12.155 753-3503/? E/mm-camera: <IMGLIB><ERROR> 254: module_depth_map_send_config_data: CAM_STREAM_TYPE_DEPTH not set !!
2021-06-28 19:09:12.155 753-3503/? E/mm-camera: <IMGLIB><ERROR> 369: module_depth_map_handle_ctrl_parm: Error module_depth_map_send_config_data
2021-06-28 19:09:12.155 753-3503/? E/mm-camera: <IMGLIB><ERROR> 373: module_depth_map_handle_ctrl_parm: X
2021-06-28 19:09:12.155 753-3503/? E/mm-camera: <IMGLIB><ERROR> 890: module_imgbase_process_param: [depth_map] handle_ctrl_parm error : type=10, rc=-5
2021-06-28 19:09:12.159 753-3503/? W/mm-camera: <IFACE >< WARN> 2857: iface_util_modify_plane_info_for_native_buf: iface_util_modify_plane_info_for_native_buf: Invalid cam_format -2088533117
2021-06-28 19:09:12.159 753-3503/? W/mm-camera: <IFACE >< WARN> 2892: iface_util_calculate_frame_length_for_native_buf: iface_util_calculate_frame_length_for_native_buf: returned fail=-1
2021-06-28 19:09:12.159 753-3503/? W/mm-camera: <IFACE >< WARN> 2857: iface_util_modify_plane_info_for_native_buf: iface_util_modify_plane_info_for_native_buf: Invalid cam_format -2088533117
2021-06-28 19:09:12.159 753-3503/? W/mm-camera: <IFACE >< WARN> 2892: iface_util_calculate_frame_length_for_native_buf: iface_util_calculate_frame_length_for_native_buf: returned fail=-1
2021-06-28 19:09:12.173 753-3503/? W/mm-camera: <IMGLIB>< WARN> 5728: faceproc_hw_comp_create: Library not loaded, handle=0x0, p_ops=0xd8c4d04c
2021-06-28 19:09:12.173 753-3503/? W/mm-camera: <IMGLIB>< WARN> 3898: module_faceproc_comp_create: create comp failed, eng_type=0
2021-06-28 19:09:12.173 753-3503/? W/mm-camera: <IMGLIB>< WARN> 1060: faceproc_dsp_comp_create: fddsp stub library not loaded
2021-06-28 19:09:12.173 753-3503/? W/mm-camera: <IMGLIB>< WARN> 3898: module_faceproc_comp_create: create comp failed, eng_type=1
2021-06-28 19:09:12.184 753-753/? W/CAM_MctServ_3: type=1400 audit(0.0:22000): avc: denied { read } for name="u:object_r:system_prop:s0" dev="tmpfs" ino=2242 scontext=u:r:hal_camera_default:s0 tcontext=u:object_r:system_prop:s0 tclass=file permissive=0
2021-06-28 19:09:12.198 753-3503/? E/libc: Access denied finding property "sys.camera.miui.apk"
2021-06-28 19:09:12.199 753-3503/? E/mm-camera: <SENSOR><ERROR> 8122: module_sensor_set_decode_format_based_on_pack_mode: Pack mode is 0
2021-06-28 19:09:12.199 753-1589/? E/quadracfa_dummy: inside dummy remosaic_init 1
2021-06-28 19:09:12.199 753-1589/? E/quadracfa_dummy: inside dummy remosaic_gainmap_gen 1
2021-06-28 19:09:12.219 753-3525/? E/mm-camera: <STATS_AF ><ERROR> 596: af_haf_default_mixer_active_algo_selection: ERROR! Unable to find active mixer algo !!
2021-06-28 19:09:12.219 753-3503/? E/mm-camera: <IFACE ><ERROR> 2269: iface_util_set_chromatix: iface_util_set_chromatix:2269 failed: iface_hvx_open rc 0
2021-06-28 19:09:12.222 753-3524/? E/mm-camera: <STATS_AEC ><ERROR> 579: aec_led_cal_apply_calibration: Calibrate data size 0 not expected with tuning size: 0
2021-06-28 19:09:12.233 753-3541/? E/mm-still: omx_component_set_callbacks: Bad Parameter
2021-06-28 19:09:12.277 753-753/? E/QCamera: <HAL><ERROR> translateToHalMetadata: 15900: tong mHmdZOOMEable = 0
2021-06-28 19:09:12.290 753-2256/? E/QCamera: <HAL><ERROR> translateToHalMetadata: 15900: tong mHmdZOOMEable = 0
2021-06-28 19:09:12.296 753-2256/? E/QCamera: <HAL><ERROR> translateToHalMetadata: 15900: tong mHmdZOOMEable = 0
2021-06-28 19:09:12.809 1644-24165/? W/ActivityManager: Scheduling restart of crashed service com.android.chrome/org.chromium.chrome.browser.customtabs.CustomTabsConnectionService in 1000ms
2021-06-28 19:09:12.813 1644-24155/? W/ActivityManager: Scheduling restart of crashed service com.hmdglobal.app.midtest/.NvDealService in 10996ms
2021-06-28 19:09:12.821 1644-24155/? W/ActivityManager: Scheduling restart of crashed service com.qualcomm.qti.callenhancement/.CallEnhancementService in 20988ms
2021-06-28 19:09:12.832 1644-1695/? W/ActivityManager: Scheduling restart of crashed service com.qualcomm.qti.qdma/.job.QDMAJobService in 30977ms
2021-06-28 19:09:12.832 1644-1695/? W/ActivityManager: Scheduling restart of crashed service com.qualcomm.qti.qdma/.app.ActiveCareService in 40977ms
2021-06-28 19:09:12.832 1644-1695/? W/ActivityManager: Scheduling restart of crashed service com.qualcomm.qti.qdma/.uploader.UploaderService in 50977ms
2021-06-28 19:09:12.841 1644-1695/? W/ActivityManager: Scheduling restart of crashed service com.qualcomm.simcontacts/.SimContactsService in 60968ms
2021-06-28 19:09:12.843 1644-2773/? W/ActivityManager: Scheduling restart of crashed service com.qualcomm.qti.workloadclassifier/.WLCService in 70966ms
2021-06-28 19:09:13.634 17592-3578/com.emmaprod W/StreamingFormatChecker: ML Kit has detected that you seem to pass camera frames to the detector as a Bitmap object. This is inefficient. Please use YUV_420_888 format for camera2 API or NV21 format for (legacy) camera API and directly pass down the byte array to ML Kit.
2021-06-28 19:09:14.309 3579-3579/? E/.android.chrom: Not starting debugger since process cannot load the jdwp agent.
2021-06-28 19:09:14.555 3579-3579/? W/.android.chrom: JIT profile information will not be recorded: profile file does not exits.
2021-06-28 19:09:14.555 3579-3579/? W/.android.chrom: JIT profile information will not be recorded: profile file does not exits.
2021-06-28 19:09:14.837 3579-3613/? W/DynamiteModule: Local module descriptor class for com.google.android.gms.googlecertificates not found.
2021-06-28 19:09:14.941 1644-24153/? W/ActivityManager: Scheduling restart of crashed service com.android.chrome/org.chromium.chrome.browser.customtabs.CustomTabsConnectionService in 78868ms
2021-06-28 19:09:18.635 17592-3604/com.emmaprod W/StreamingFormatChecker: ML Kit has detected that you seem to pass camera frames to the detector as a Bitmap object. This is inefficient. Please use YUV_420_888 format for camera2 API or NV21 format for (legacy) camera API and directly pass down the byte array to ML Kit.
2021-06-28 19:09:20.299 1644-1691/? W/System: A resource failed to call close.
2021-06-28 19:09:20.299 1644-1691/? W/System: A resource failed to call close.
2021-06-28 19:09:20.300 1644-1691/? W/System: A resource failed to call release.
2021-06-28 19:09:20.300 1644-1691/? W/System: A resource failed to call close.
2021-06-28 19:09:20.300 1644-1691/? W/System: A resource failed to call close.
2021-06-28 19:09:23.663 17592-3490/com.emmaprod W/StreamingFormatChecker: ML Kit has detected that you seem to pass camera frames to the detector as a Bitmap object. This is inefficient. Please use YUV_420_888 format for camera2 API or NV21 format for (legacy) camera API and directly pass down the byte array to ML Kit.
2021-06-28 19:09:23.875 3623-3623/? E/bal.app.midtes: Not starting debugger since process cannot load the jdwp agent.
2021-06-28 19:09:24.265 3623-3623/? W/ContextImpl: Calling a method in the system process without a qualified user: android.app.ContextImpl.startService:1570 android.content.ContextWrapper.startService:669 com.longcheertel.fmradio.FMAdapterApp.onCreate:81 android.app.Instrumentation.callApplicationOnCreate:1190 android.app.ActivityThread.handleBindApplication:6479

And Android camera component looks like this:
import React, { useMemo, useRef } from 'react';
import { StyleSheet, NativeModules } from 'react-native';
import { Camera, useCameraDevices } from 'react-native-vision-camera';

import useAppState from '../../../hooks/useAppState';
import { useCameraPermissions } from '../hooks';
import { PermissionStatus } from '../types';
import useInterval from '../../../hooks/useInterval';

const qrcodeLocalImage = NativeModules.QRCodeLocalImage;

type Props = {
  visible: boolean;
  flash: boolean;
  onScannedCodes?: (codes: string[]) => void;
};

export default ({ visible, flash, onScannedCodes }: Props) => {
  const camera = useRef<Camera>(null);
  const { status } = useCameraPermissions();
  const devices = useCameraDevices();
  const appState = useAppState();
  const device = useMemo(
    () => (status === PermissionStatus.allowed ? devices.back : undefined),
    [devices, status]
  );
  const isForeground = useMemo(() => visible && appState === 'active', [
    visible,
    appState,
  ]);

  useInterval(
    async () => {
      if (camera.current && visible) {
        try {
          const photo = await camera.current?.takeSnapshot({
            quality: 80,
            skipMetadata: true,
          });

          if (photo && qrcodeLocalImage) {
            onScannedCodes?.(await qrcodeLocalImage.decode(photo.path));
          }
        } catch (e) {
          // NoOp
        }
      }
    },
    isForeground && device ? 500 : undefined
  );

  return device ? (
    <Camera
      ref={camera}
      style={StyleSheet.absoluteFill}
      device={device}
      torch={isForeground && flash ? 'on' : 'off'}
      isActive={isForeground}
      photo
    />
  ) : null;
};

Oh okay, so the issue is that the frame processor is not set?
The title of the issue is a bit misleading. "Camera start and stop issues" sounds like the camera blackscreens.
Anyways, I think I already found a fix. I haven't tested the change, but here's the diff: https://github.com/mrousavy/react-native-vision-camera/commit/b10b2c10fc6084f13a3a667b970910c0d7541b34
I have released this (and Frame Processors for Android! 🎉) under the beta tag on npm (see Release 2.4.2-beta.3).
$ npm i react-native-vision-camera@beta

But what about camera not stopping on view unmount?
I can record a video of this...

Will be happy to get Android Frame Processor also :-)🎉

I can record a video of this...
Please do, because I cannot reproduce it in the example app.

Add the following code to your page:
useEffect(() => {
  console.log("mounted")
  return () => {
    console.log("unmounted!")
  }
}, [])

, then start the app clean (no fast-refresh) and showcase the issue

@mrousavy so here it the record
https://youtube.com/shorts/Yzv0afk7aJ4?feature=share
The green indicator dot on the top right of the screen stays after going back. And never goes off.
If I send app to background it disappears.
But appears back once app gets resumed.
Here are the logs:
 LOG  mounted
 WARN  [native] VisionCamera.captureOutput(_:didDrop:from:): Dropped a Frame. This might indicate that your Frame Processor is doing too much work. Either throttle the frame processor's frame rate, or optimize your frame processor's execution speed. Frame drop reason: FrameWasLate
 LOG  unmounted!

Visually unmounted log happened after the view was animated to go offscreen.

Also will try to update the lib, then will report on it's behavior

Hm, that's really weird. Maybe there's a memory leak? Are you using react-navigation or react-native-navigation?

We are using react-navigation

Tried with the latest 2.4.2-beta.7
The issue is still here.
@mrousavy  You mentioned something about the leak.
How there can be a leak if a component is unmounted? 🤔

Also, looks like this fix actually doesn't help #b10b2c1
I need a delay anyway to let frame processor work.
Actually it looks like frame processor gets stuck after 1 run 🤔
And start to work normally only after disabling CameraView and enabling again.

View with CameraView mounted and before disabled (Frame processor called only once):
2021-06-29 15:27:02.643754+0300 emma dev[2737:1147307] FrameProcessorBindings: Setting new frame processor...
2021-06-29 15:27:02.643803+0300 emma dev[2737:1147307] FrameProcessorBindings: Adapting Shareable value from function (conversion to worklet)...
2021-06-29 15:27:02.643914+0300 emma dev[2737:1147307] FrameProcessorBindings: Successfully created worklet!
2021-06-29 15:27:02.654980+0300 emma dev[2737:1147299] FrameProcessorBindings: Converting worklet to Objective-C callback...
2021-06-29 15:27:02.655318+0300 emma dev[2737:1147299] FrameProcessorBindings: Frame processor set!
2021-06-29 15:27:02.657990+0300 emma dev[2737:1147134] [native] VisionCamera.didSetProps(_:): Updating 13 prop(s)...
2021-06-29 15:27:02.658195+0300 emma dev[2737:1147551] [native] VisionCamera.configureCaptureSession(): Configuring Session...
2021-06-29 15:27:02.658223+0300 emma dev[2737:1147551] [native] VisionCamera.configureCaptureSession(): Initializing Camera with device com.apple.avfoundation.avcapturedevice.built-in_video:6...
2021-06-29 15:27:02.658256+0300 emma dev[2737:1147551] [native] VisionCamera.configureCaptureSession(): Adding Video input...
2021-06-29 15:27:02.662385+0300 emma dev[2737:1147551] [native] VisionCamera.configureCaptureSession(): Adding Photo output...
2021-06-29 15:27:02.663920+0300 emma dev[2737:1147551] [native] VisionCamera.configureCaptureSession(): Adding Video Data output...
2021-06-29 15:27:02.664479+0300 emma dev[2737:1147551] [native] VisionCamera.invokeOnInitialized(): Camera initialized!
2021-06-29 15:27:02.664535+0300 emma dev[2737:1147551] [native] VisionCamera.configureCaptureSession(): Session successfully configured!
2021-06-29 15:27:02.665129+0300 emma dev[2737:1147551] [native] VisionCamera.configureFormat(): Configuring Format...
2021-06-29 15:27:02.665137+0300 emma dev[2737:1147551] [native] VisionCamera.configureDevice(): Configuring Device...
2021-06-29 15:27:02.665144+0300 emma dev[2737:1147551] [native] VisionCamera.configureDevice(): Device successfully configured!
2021-06-29 15:27:02.665277+0300 emma dev[2737:1147551] [native] VisionCamera.didSetProps(_:): Starting Session...
2021-06-29 15:27:03.259933+0300 emma dev[2737:1147551] [native] VisionCamera.didSetProps(_:): Started Session!
2021-06-29 15:27:10.769634+0300 emma dev[2737:1147307] FrameProcessorBindings: Setting new frame processor...
2021-06-29 15:27:10.769747+0300 emma dev[2737:1147307] FrameProcessorBindings: Adapting Shareable value from function (conversion to worklet)...
2021-06-29 15:27:10.769829+0300 emma dev[2737:1147307] FrameProcessorBindings: Successfully created worklet!
2021-06-29 15:27:10.769945+0300 emma dev[2737:1147296] FrameProcessorBindings: Converting worklet to Objective-C callback...
2021-06-29 15:27:10.770171+0300 emma dev[2737:1147296] FrameProcessorBindings: Frame processor set!
2021-06-29 15:27:10.794642+0300 emma dev[2737:1147296] Frame processor called!
2021-06-29 15:27:10.795332+0300 emma dev[2737:1147296] Metal API Validation Enabled
2021-06-29 15:27:10.856776+0300 emma dev[2737:1147134] [native] VisionCamera.didSetProps(_:): Updating 1 prop(s)...
2021-06-29 15:27:10.857034+0300 emma dev[2737:1147554] [native] VisionCamera.didSetProps(_:): Stopping Session...
2021-06-29 15:27:10.985358+0300 emma dev[2737:1147554] [native] VisionCamera.didSetProps(_:): Stopped Session!

Logs after CameraView reenabled. Frame processor gets called constantly:
2021-06-29 15:27:15.703789+0300 emma dev[2737:1147134] [native] VisionCamera.didSetProps(_:): Updating 1 prop(s)...
2021-06-29 15:27:15.704219+0300 emma dev[2737:1147296] [native] VisionCamera.didSetProps(_:): Starting Session...
2021-06-29 15:27:16.259640+0300 emma dev[2737:1147296] [native] VisionCamera.didSetProps(_:): Started Session!
2021-06-29 15:27:16.261332+0300 emma dev[2737:1147296] Frame processor called!
2021-06-29 15:27:16.782095+0300 emma dev[2737:1147556] Frame processor called!
2021-06-29 15:27:17.294113+0300 emma dev[2737:1147556] Frame processor called!
2021-06-29 15:27:17.825266+0300 emma dev[2737:1147296] Frame processor called!
2021-06-29 15:27:18.330277+0300 emma dev[2737:1147296] Frame processor called!
2021-06-29 15:27:18.857436+0300 emma dev[2737:1147296] Frame processor called!
2021-06-29 15:27:19.361439+0300 emma dev[2737:1147296] Frame processor called!
2021-06-29 15:27:19.893778+0300 emma dev[2737:1147624] Frame processor called!
2021-06-29 15:27:20.426882+0300 emma dev[2737:1147300] Frame processor called!
2021-06-29 15:27:20.529367+0300 emma dev[2737:1147134] [native] VisionCamera.didSetProps(_:): Updating 1 prop(s)...
2021-06-29 15:27:20.529628+0300 emma dev[2737:1147300] [native] VisionCamera.didSetProps(_:): Stopping Session...
2021-06-29 15:27:20.695193+0300 emma dev[2737:1147300] [native] VisionCamera.didSetProps(_:): Stopped Session!
2021-06-29 15:27:22.628997+0300 emma dev[2737:1147307] FrameProcessorBindings: Removing frame processor...
2021-06-29 15:27:22.629324+0300 emma dev[2737:1147134] FrameProcessorBindings: Frame processor removed!

Can you reproduce this in the example app?

Trying to build this one https://github.com/mrousavy/vision-camera-image-labeler/tree/main/example
It fails...
But what I see so far, there is no case where CameraView gets unmounted while app is on the screen.
Once build, will add this case and check if it reproduces...

Analyzing the difference in logs between first deactivate than unmount and unmount while was active.
The case with the issue lacks these logs:
[2861:1181594] [native] VisionCamera.didSetProps(_:): Stopping Session...
[2861:1181594] [native] VisionCamera.didSetProps(_:): Stopped Session!

@mrousavy thank you a lot with your help!
I finally managed to make example app build and run (it's a bit outdated and not fully set), replicated the case with mount/unmount and saw no issue with camera hang I reported. Looks like we have a leak somewhere...
I altered the example code a bit to test:
import * as React from 'react';
import { TouchableOpacity, Text } from 'react-native';

import { StyleSheet, View, ActivityIndicator } from 'react-native';
import {
  useCameraDevices,
  useFrameProcessor,
} from 'react-native-vision-camera';
import { Camera } from 'react-native-vision-camera';
import { labelImage } from 'vision-camera-image-labeler';

export default function App() {
  const [hasPermission, setHasPermission] = React.useState(false);
  const [active, setActive] = React.useState(true);
  const [mount, setMount] = React.useState(true);
  const devices = useCameraDevices('wide-angle-camera');
  const device = devices.back;

  React.useEffect(() => {
    (async () => {
      const status = await Camera.requestCameraPermission();
      setHasPermission(status === 'authorized');
    })();
  }, []);

  const frameProcessor = useFrameProcessor((frame) => {
    const labels = labelImage(frame);
    _log(`Labels: ${labels.join(', ')}`);
  }, []);

  return (
    <View style={styles.container}>
      {device != null && mount && hasPermission ? (
        <Camera
          style={StyleSheet.absoluteFill}
          device={device}
          isActive={active}
          frameProcessor={frameProcessor}
          frameProcessorFps={5}
        />
      ) : (
        <ActivityIndicator size="large" color="white" />
      )}
      <TouchableOpacity
        style={styles.button}
        onPress={() => {
          setActive(!active);
        }}
      >
        <Text style={{ fontSize: 24 }}>
          {active ? 'Deactivate' : 'Activate'}
        </Text>
      </TouchableOpacity>
      <TouchableOpacity
        style={styles.button}
        onPress={() => {
          setMount(!mount);
        }}
      >
        <Text style={{ fontSize: 24 }}>{mount ? 'Unmount' : 'Mount'}</Text>
      </TouchableOpacity>
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
  },
  button: {
    padding: 24,
    margin: 24,
    backgroundColor: 'rgba(255,255,255,0.7)',
  },
  box: {
    width: 60,
    height: 60,
    marginVertical: 20,
  },
});

Hey @G0retZ! Can you check if https://github.com/mrousavy/react-native-vision-camera/pull/265 fixes the issue for you?

Having same issue with "react-native-vision-camera": "^2.12.0",
Using it with react-navigation. Green dot stays even after I close the screen with Camera
const isFocused = useIsFocused();
const devices = useCameraDevices();
const device = devices.back;
const [frameProcessor, barcodes] = useScanBarcodes([BarcodeFormat.QR_CODE]);

{device && (
                <Camera
                    style={StyleSheet.absoluteFill}
                    device={device}
                    isActive={isFocused}
                    frameProcessor={frameProcessor}
                    frameProcessorFps={5}
                    torch={flashOn ? 'on' : 'off'}
                />
)}

I have the same issue but Android only. The camera stays active as soon as I visit this screen and persists through whole app session until it's moved to background:
import { isDefined, Nullable } from '@core'
import { useIsFocused } from '@react-navigation/native'
import React, { FC, useEffect, useMemo, useRef, useState } from 'react'
import { Text, View } from 'react-native'
import { Camera, CameraDevice, CameraPermissionStatus, useCameraDevices } from 'react-native-vision-camera'

interface CameraState {
  cameraDevice?: CameraDevice
  cameraPermissionStatus?: CameraPermissionStatus
}

interface CameraReadyState extends CameraState {
  cameraDevice: CameraDevice
  cameraPermissionStatus: 'authorized'
}

const isCameraStateReady = (cameraState: CameraState): cameraState is CameraReadyState =>
  isDefined(cameraState.cameraDevice) && cameraState.cameraPermissionStatus === 'authorized'

const PictureScreen: FC = () => {
  const isFocused = useIsFocused()
  const cameraRef = useRef<Nullable<Camera>>(null)
  const { back: cameraDevice } = useCameraDevices()
  const [cameraPermissionStatus, setCameraPermissionStatus] = useState<CameraPermissionStatus>()

  const cameraState = useMemo<CameraState>(() => ({ cameraDevice, cameraPermissionStatus }), [
    cameraDevice,
    cameraPermissionStatus,
  ])
  const isCameraAuthorized = cameraPermissionStatus === 'authorized'

  useEffect(() => {
    Camera.getCameraPermissionStatus().then(setCameraPermissionStatus)
  }, [setCameraPermissionStatus])

  useEffect(() => {
    if (!isCameraAuthorized) Camera.requestCameraPermission().then(setCameraPermissionStatus)
  }, [isCameraAuthorized, setCameraPermissionStatus])

  return (
    <View>
      {isCameraStateReady(cameraState) ? (
        <Camera audio={false} device={cameraState.cameraDevice} isActive={isFocused} photo ref={cameraRef} video />
      ) : (
        <View>
          <Text>Loading camera...</Text>
        </View>
      )}
    </View>
  )
}

isFocused is propertly changing from true to false when navigating from this screen and isCameraStateReady(cameraState) is still true.

Hey! I just found out that I really forgot to close and dispose the locked Camera resources, so I just fixed that in this PR: https://github.com/mrousavy/react-native-vision-camera/pull/2174
Now the Camera fully & synchronously closes all resources (CameraSession, CameraDevice, OpenGL context, Video & Photo outputs, Photo Synchronizer) once the view gets removed from the React view hierarchy ("unmounted"), and things like Flash, Torch, NFC, and other Camera components should be working again.
There is still a small issue that causes once Camera component to turn into a blackscreen when navigating back and forth between two Camera components, that's a pretty rare edge case but I will still try to fix that soon when I have some free time.
If you appreciate my time, expertise and dedication to this project, pleas 💖 consider sponsoring me on GitHub 💖 to support the development of this project.


Consistent naming of options and arguments that do the same thing

At the moment, certain options and arguments that do the same thing should are not named the same across all schematics.
In ng new to skip the creation of spec files, one needs to use --skip-test, with an alias of -S, while in other schematics it is --spec and no alias.
In the component schematics ng generate component, to specify the style preprocessor you need to use  --styleext, while in ng new this is named --style
We should discuss this, choose the preferred namings and align all the same options to make it easier for the users.

I prefer --skip-test and --style

Let's review it for v8. We have a design in place and a discussion.


Information bundle issues

Description:

Changed wording
Changed button when in history
Added checkbox for public keys

Related issue(s):
Fixes #238
Fixes #233
Fixes #234

lgtm, but not sure if I should approve or not yet 😀

Just go ahead and approve it, please


New Fingerprints Recommendation

Configuration:

RDKit Version: 2020.03.2
Operating system: Windows 10 Professional
Python version (if relevant): Python 3.7.9

Description:
I have just found out there are some new fingerprints, but I am wondering if they are being added to RDKit yet? which is Min-Hashed Atom-Pair Fingerprint (MAP4) and Min-Hashed Fingerprint, up to six bonds (MHFP6) or up to four bonds (MHFP4) or MACCS-322bit, PubChem Fingerprint. Is all of that can be in bit-type?
Source: https://jcheminf.biomedcentral.com/articles/10.1186/s13321-020-00445-4
Source: https://jcheminf.biomedcentral.com/articles/10.1186/s13321-018-0321-8
At this current time, although we have 17 fingerprints yet but I have just found 11 bit-type fingerprints on RDKit which is Morgan (useFeatures=False) (ECFP4 or ECFP6), Morgan (useFeatures=True) (FCFP4 or FCFP6), RDKit, Layered RDKit, Atom-Pair, Topological Torsion, Pattern, MACCS Keys, Avalon. Will it be added to RDKit in later update?

The release notes for 2020.03.1 include  "A few new descriptor/fingerprint types are available - BCUTs (#2957), Morse atom fingerprints (#1773), Coulomb matrices (#2993), and MHFP and SECFP fingerprints (#2643)" ; https://github.com/rdkit/rdkit/blob/master/ReleaseNotes.md .
Of those, I think only SECFP fingerprints are bit fingerprints. The notes I have say it works something like:
from rdkit.Chem import rdMHFPFingerprint
secfp_encoder = rdMHFPFingerprint.MHFPEncoder(0, 0)
fp = secfp_encoder.EncodeSECFPMol(mol, radius, rings, isomeric, kekulize, min_radius, fpSize)

I don't know about MACCS-322bit. "Reoptimization of MDL Keys for Use in Drug Discovery" , http://dx.doi.org/10.1021/ci010132r , mentions "both 166 bit and 960 bit keysets based on 2D descriptors" and describes an optimized version for similarity with 548 bits. I see that 322 is twice 166 but don't know the connection.

The release notes for 2020.03.1 include "A few new descriptor/fingerprint types are available - BCUTs (#2957), Morse atom fingerprints (#1773), Coulomb matrices (#2993), and MHFP and SECFP fingerprints (#2643)" ; https://github.com/rdkit/rdkit/blob/master/ReleaseNotes.md .
Of those, I think only SECFP fingerprints are bit fingerprints. The notes I have say it works something like:
from rdkit.Chem import rdMHFPFingerprint
secfp_encoder = rdMHFPFingerprint.MHFPEncoder(0, 0)
fp = secfp_encoder.EncodeSECFPMol(mol, radius, rings, isomeric, kekulize, min_radius, fpSize)

I don't know about MACCS-322bit. "Reoptimization of MDL Keys for Use in Drug Discovery" , http://dx.doi.org/10.1021/ci010132r , mentions "both 166 bit and 960 bit keysets based on 2D descriptors" and describes an optimized version for similarity with 548 bits. I see that 322 is twice 166 but don't know the connection.

In cases of MACCS 322 bits, I have found it here http://www.mayachemtools.org/docs/scripts/html/MACCSKeysFingerprints.html
I have just tried BCUT 2D as your code mentioned as well as MHFP - SECFP , but at this time, I am still struggling about the code that is there any array representations or string representations about these three fingerprints in Python. Some function in C++ is not been passed into Python when I check the source code of the author (MHFP-SECFP). In case of BCUT, I don't know what to do next, when it just gives me and _vectdouble without no function to represent it
http://rdkit.org/docs/cppapi/classRDKit_1_1MHFPFingerprints_1_1MHFPEncoder.html#ac45cdeb7eab075d43c84bb9dbecfffbd

It's unlikely that RDKit will include the MayaChem MACCS 322 bits implementation. It cites the same "Reoptimization of MDL Keys" paper I mentioned before, but I don't see anything related to 322 in that paper. I could try to figure it out more, but someone is going to need to test it and show that it outperforms the other fingerprint types already in RDKit. There are only a handful of publications that Google Scholar could find which use the 322 bit implementation, and nearly all were from one research group who simply used all of MayaChem's fingerprint implementations, and did not remark that they weren't using the by-far most common 166 bit version.
MHFP does not have a standard fingerprint representation.
The _vectd means the BCUT is a vector of doubles. This can be turned into a Python list like:
>>> list(BCUT)
[-9.569191070688725e-16, -0.24844104338801754, -0.1798488674638132, -2.5611396749690116, -0.03425012966629479, -2.6847019107610306, -2.2462701462792987e-16, -1.1084942735259444]

from rdkit.Chem import rdMHFPFingerprint
secfp_encoder = rdMHFPFingerprint.MHFPEncoder(0, 0)
fp = secfp_encoder.EncodeSECFPMol(mol, radius, rings, isomeric, kekulize, min_radius, fpSize)

Can you explain what do the two zeros mean in the following block?
secfp_encoder = rdMHFPFingerprint.MHFPEncoder(0, 0)

I looked at the documentation, https://www.rdkit.org/docs/source/rdkit.Chem.rdMHFPFingerprint.html. But I don't know much about C++ and didn't figure it out.
Thank you very much for your time!
@adalke @IchiruTake

from rdkit.Chem import rdMHFPFingerprint
secfp_encoder = rdMHFPFingerprint.MHFPEncoder(0, 0)
fp = secfp_encoder.EncodeSECFPMol(mol, radius, rings, isomeric, kekulize, min_radius, fpSize)

Can you explain what do the two zeros mean in the following block?
secfp_encoder = rdMHFPFingerprint.MHFPEncoder(0, 0)

I looked at the documentation, https://www.rdkit.org/docs/source/rdkit.Chem.rdMHFPFingerprint.html. But I don't know much about C++ and didn't figure it out.
Thank you very much for your time!
@adalke @IchiruTake

I got it. Never mind. Thanks!
https://github.com/reymond-group/mhfp
    # n_permutations: analogous to the number of bits ECFP fingerprints are folded into. Higher is better, lower is less exact.
    # seed: seed for the MinHash operation. Has to be the same for comparable fingerprints.

I'm closing this because it looks like the question is answered. Please reopen if necessary.


Popup is broke

Current Behavior
The popup is braking due to computePosition as its store is undefined
and receives error in clientside:

Expected Behavior
expected to work as the demo shows
https://www.skeleton.dev/components/autocomplete
Steps To Reproduce
reproduce demo for select popup
<input
							class="input autocomplete"
							type="search"
							name="autocomplete-search"
							bind:value={inputPopupDemo}
							placeholder="Search..."
							use:popup={popupSettings}
						/>
						<div data-popup="popupAutocomplete">
							<Autocomplete
								bind:input={inputPopupDemo}
								options={timeStrategies}
								on:selection={onSelected}
							/>
						</div>

at https://www.skeleton.dev/components/autocomplete
https://github.com/skeletonlabs/skeleton/blob/85b69544e512645738d4c4135ff17a6e71641159/packages/skeleton/src/lib/utilities/Popup/popup.ts#L5
Link to Reproduction / Stackblitz
No response
More Information
No response

@snk-js the autocomplete feature makes use of the Popups feature. The popup feature, however, has a few prerequisite steps. Can you confirm you've followed these and report back:
https://www.skeleton.dev/utilities/popups#installation


Please add an Open Source license to this project

Would you consider adding a license file to this project? This would be consistent with good community practices and would allow others to build upon your work with a clear set of rules for what is acceptable.
For maximum compatibility with other free software projects, please consider using MIT license, such as expressed here:
https://opensource.org/licenses/MIT
(replace the copyright statement with your copyright, of course)
Thank you for making this available. I used this (by downloading and running it unmodified) in this package: https://github.com/obscureorganization/lj2wp

Fixed in a21fe1259f58301b3494324ef1ae028cf35ab389

Thank you @ghewgill !
🏆 🎆 🥇 ⭐


Discontinuous Series

Is there a way to chart just the (x,y) values?
The ContinuousSeries joins them together. What if I don't want them joined?

Never mind: https://github.com/wcharczuk/go-chart/tree/master/examples/scatter


Unsolved conflict between options: 'apk_paths' and 'apk'

Issue Description
Hi, I have a few questions about apk_path parameter. apprecated if you can answer them. cheers!

what is the correct format of inputing 'apk_paths'? is it something like:
apk_paths: ["/app/build/outputs/apk/app-release-unaligned.apk", "/app/build/outputs/apk/app-release-unaligned.apk"] ?
Is it not allowed to manually set parameters for 'apk_paths' and 'apk' at the same time? I guess that might be the reason causing the conflict as mentioned in the title. But there is a weird case that when i run 'supply' without giving any parameters, the apk_paths is filled with a default value, and it upload the data to play store successfully. don't know why?
+-------------------------+------------------------------------------------------------------------+
|                                     Summary for supply 0.7.1                                     |
+-------------------------+------------------------------------------------------------------------+
| package_name            | com..supplydemo                                           |
| track                   | alpha                                                                  |
| metadata_path           | //SupplyDemo/fastlane/metadata/android             |
| json_key                | /***/SupplyDemo/key.json                              |
| apk_paths               | ["/app/build/outputs/apk/app-debug.apk |
| rollout                 | 1.0                                                                    |
| apk                     | app/build/outputs/apk/app-Release.apk                                  |
| skip_upload_apk         | false                                                                  |
| skip_upload_metadata    | false                                                                  |
| skip_upload_images      | false                                                                  |
| skip_upload_screenshots | false                                                                  |
+-------------------------+------------------------------------------------------------------------+

Complete output when running fastlane, including the stack trace and command used
10:40:45: --- Step: supply ---
10:40:45: --------------------
[10:40:47]: You passed invalid parameters to 'supply'.
[10:40:47]: Check out the error below and available options by running fastlane action supply
[10:40:47]: Variable Dump:
[10:40:47]: {:DEFAULT_PLATFORM=>:android, :PLATFORM_NAME=>:android, :LANE_NAME=>"android alpha", :GRADLE_ALL_APK_OUTPUT_PATHS=>["/Users/phuang/GitRepo/SupplyDemo/app/build/outputs/apk/app-release.apk"], :GRADLE_APK_OUTPUT_PATH=>"/Users/phuang/GitRepo/SupplyDemo/app/build/outputs/apk/app-release.apk"}
[10:40:47]: Unresolved conflict between options: 'apk_paths' and 'apk'
+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | gradle                              | 2           |
| 4    | gradle                              | 18          |
| 5    | supply                              | 2           |
+------+-------------------------------------+-------------+
[10:40:47]: fastlane finished with errors
[!] Unresolved conflict between options: 'apk_paths' and 'apk'
Configuration Files
Fastfile:
# INSERT CONTENT HERE
lane :alpha do
    gradle(task: "clean")
    gradle(task: "assembleRelease")
    supply(package_name: "com.***.***.supplydemo",
           track: "alpha",
           metadata_path: "/***/SupplyDemo/fastlane/metadata/android",
           json_key: "/***/SupplyDemo/key.json",
           apk_paths: ["***/SupplyDemo/app/build/outputs/apk/app-release-unaligned.apk"],
           apk: "/***/SupplyDemo/app/build/outputs/apk/app-Release.apk")

    # sh "your_script.sh"
    # You can also use other beta testing services here
  end

### Environment

fastlane version (run `fastlane -v`): fastlane 1.102.0

Do you use bundler to execute fastlane (i.e. `bundle exec fastlane`)? NO

Do you use a Ruby environment manager (e.g. `chruby`, `rbenv`, `rvm`)? NO

@gagaJay Thanks for the questions.
The array format is correct for apk_paths.
You cannot specify both as params. If you have apk_paths from an environment variable (GRADLE_ALL_APK_OUTPUT_PATHS iss set because you ran gradle prior to supply) it will use that over the apk param.
Hope this helps. 👍

thanks for clarification!

👍


Add onDoubleClickRow Prop to Table

Description
Add an onDoubleClickRow Prop that can receive information when a row in a table component is double-clicked.
Problem Statement/Justification
Thank you, maintainers, for your wonderful library.
In complex business applications, you may want to assign a different operation when a row is double-clicked.
Currently, if you want to specify a handler for a double click on a row, you need to implement it in NativeTable, which is time-consuming.
Since the React event handler provides onDoubleClick, it seems natural for Yamada UI to provide this feature as well.
Proposed Solution or API
The following branches were implemented, tested, storied, and documentation updated
If all is well, we would like to create a pull request.
https://github.com/yamada-ui/yamada-ui/compare/main...bmthd:yamada-ui:feat/table-row-dblclick
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
Yes
Additional Information
No response

Hi, thanks for the issue!
This suggestion is very good!
I would love to implement it!
I looked at the source code for the branch.
It is very good.
However, there are a few things I would like to see fixed.

docs/contents/components/data-display/table/props.ja.mdx
docs/contents/components/data-display/table/props.mdx

These files do not need to be modified.
They are generated automatically.
And, there are also differences in the file except for some newly added logic.
This can be tricky to review, so please make sure that only the changes you make cause a difference.


listExperiments fix for concurrent rm and lm

Description
Introduced the rm=true flag for the ROS Remote Monitoring use case. When rm=true is passed in the listExperiments API, the API refers to remote monitoring tables. By default, the flag is set to false, which points to local monitoring tables. This feature is not critical for the ROS Remote Monitoring use case, as they do not utilize the listExperiments API. Therefore, a documentation update is not required.
Fixes # (issue)
Type of change

[ ] Bug fix
[x] New feature
[ ] Docs update
[ ] Breaking change (What changes might users need to make in their application due to this PR?)
[ ] Requires DB changes

How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

[ ] New Test X
[x] Functional testsuite

Test Configuration

Kubernetes clusters tested on:

Checklist :dart:

[x] Followed coding guidelines
[x] Comments added
[x] Dependent changes merged
[ ] Documentation updated
[ ] Tests added or updated

Additional information
Include any additional information such as links, test results, screenshots here

@msvinaykumar - Fault tolerant test in remote monitoring invokes listExperiments, can you please check if this runs fine or needs any changes.

@msvinaykumar - Fault tolerant test in remote monitoring invokes listExperiments, can you please check if this runs fine or needs any changes.

thank you will create seperate PR.

@msvinaykumar Please rebase this PR


fix: API\ResponseTrait can't return string as JSON

Description
Fixes #8397

When you pass a string, $this->respond() returns text/html. But it should return application/json.

When you pass a int, $this->respond() returns application/json.
When you pass a boolean, $this->respond() returns application/json.

Before:
$ curl -v http://localhost:8080/
...
< HTTP/1.1 200 OK
< Host: localhost:8080
< Date: Wed, 31 Jan 2024 07:57:40 GMT
< Connection: close
< X-Powered-By: PHP/8.2.15
< Cache-Control: no-store, max-age=0, no-cache
< Content-Type: text/html; charset=UTF-8
<
* Closing connection
message

After:
$ curl -v http://localhost:8080/
...
< HTTP/1.1 200 OK
< Host: localhost:8080
< Date: Wed, 31 Jan 2024 07:59:11 GMT
< Connection: close
< X-Powered-By: PHP/8.2.15
< Cache-Control: no-store, max-age=0, no-cache
< Content-Type: application/json; charset=UTF-8
<
* Closing connection
"message"

<?php

namespace App\Controllers;

use CodeIgniter\API\ResponseTrait;

class Home extends BaseController
{
    use ResponseTrait;

    public function index()
    {
        return $this->respond('message', 200);
    }
}

Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Unless we will be able to parse the same JSON on the input, I think I will not be in favor.
IMO we should support the same JSON parsing options for both: Request and Response.

We can parse the string JSON "message".
$routes->post('/', 'Home::index');

<?php

namespace App\Controllers;

class Home extends BaseController
{
    public function index(): string
    {
        $json = $this->request->getJSON();
        echo $json; exit;
    }
}

$ curl -H 'Content-Type: application/json' -d '"message"' localhost:8080/
message

Sorry, looks like I was mistaken. I thought we had a problem with that.

Added changelog and upgrade guide.


Remove extra media queries for setting gutters

Because we use media-breakpoint-up for setup the gutters we could validate if the previous gutter is the same of the current one don't add any media query.
I am wondering how many rules we could remove following the same concept 🤔 Every time we use media-breakpoint-up based on some map configuration we could validate the previous one like make-container-max-widths as well

@mdo if I remove my repo the PR goes away?

No longer relevant with #22940.


[ui] adjust header nav links so they are all aligned on the base line

makes logo and nav items all aligned on the same base line
use smaller icons for git/doc/login items for consistency

plz review @elibrumbaugh @airbnb/superset-reviewers

LGTM


event sales_order_invoice_pay

Hi, we are seeing some cases where the event sales_order_invoice_pay does not seem to be triggered on succesfull order entry. (update: function pay() here is not exectued - should we monitor another event?)
Does Adyen maybe advise another event? Or is this event not triggered?
(we need event to capture event where sale is made and paid!! for, either thru frontend, backend or API: so read: always! So a true true order so to speak)
thanksk!

Hi @seansan,
That is correct this is only triggered if you do manually an invoice.
You can use the status "Order status: payment confirmed" if you really want an event I am not sure if you can use any of the core events you could hook into the
Regards,
Rik
Adyen

What event do you advise to hook into to capture the "sale" (and send the
data to for example analytics recording the sale)
For the adyen extension I mean
On Tue, 16 May 2017 at 13:30, Rik ter Beek<EMAIL_ADDRESS>wrote:

Hi @seansan https://github.com/seansan,
That is correct this is only triggered if you do manually an invoice.
You can use the status "Order status: payment confirmed" if you really
want an event I am not sure if you can use any of the core events you could
hook into the
Regards,
Rik
Adyen
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Adyen/adyen-magento/issues/776#issuecomment-301753931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAn0a_5YvsuMgYc4JtrXJzSGeDF1mPPBks5r6YjbgaJpZM4NVbX3
.

Hi @seansan,
You can use the order_save_after event and check the status or you can hook into adyen_payment_process_notifications_after and check if authorization notification is received.
Regards,
Rik
Adyen

Hmmm there is no 1 absolute event?
I ask because we captured sales fine before version 2.8.1 ... when we upgraded from 2.7.x to 2.8.1 this is where the event stoppped working (and hence the sales registration).
I have been asking around and order->pay() is quite normal to call hence triggering sales_order_invoice_pay
https://magento.stackexchange.com/questions/11612/is-this-correct-event-to-observe-to-fire-once-order-is-completely-paid

(in short: our problem is that we are monitoring the event sales_order_invoice_pay  to register certain sales. This used to work before, but no longer after v2.8.1. We are trying to understand: why does it no longer work; what changed? and how can we capture the payment success event to register the sale again like we did before)
thx

Update. Looking @ https://github.com/Adyen/adyen-magento/blob/edbd45cbd01a78b166b1b1222432778550a65798/app/code/community/Adyen/Payment/Model/ProcessNotification.php#L1156
Indeed there is no real event to capture here. One could capture STATE PROCESSING but technically that state could be set multiple times ...
Would it be an idea to add an event in the code?
trigger
sales_order_payment_pay (I mean it is paid for now ...)
or sales_order_payment_capture (This is what the function does ...)
THis way Magento and all other items/ext's know what is going on

I'd just like to clarify a bit further. It seems that when events are triggered via processnotification that Mage::app()->getStore()->getStoreId() is empty. Hence some processes no longer work because they expect a  StoreId.

Maybe because triggered by the adminthml backend
but when watching this event we had to actively get the store id from the QUOTE or ORDER again
Indeed the StoreId variable is empty when watching the pay event and it comes back in via the backend API.
(so the quickext solution is to check this. If the StoreId is not set, then to set it?)

Hi @seansan,
Not sure what you need from us. If you need an new event feel free to open a PR to add an event handler that you need.
Regards,
Rik
Adyen


Client App Not Working

I spent 3 or 4 hours trying to connect to a server, also i tried to run it from the example. Same problem.
(The client app needs some implementation ?)

Try 7 hours more and it might start working

Client App is empty =.=

Client App is empty =.=

Have you successfully implemented the client?

Client App is empty =.=

I spent 3 or 4 hours trying to connect to a server, also i tried to run it from the example. Same problem. (The client app needs some implementation ?)
me too

Try 7 hours more and it might start working

Your mom helped me for 8 hours and it didn't work.

Try 7 hours more and it might start working

Your mom helped me for 8 hours and it didn't work. She told me that the client needs some implementation
why this can do,i am so confused
https://github.com/duidae/uWebSockets-example/tree/master


Training data non TEI-conformant

Hi, this isn't really a big deal but might be easy to fix. If your create your custom training files with the "createTraining" batch job, you get a file like this one:
10.1111_1467-6478.00057.training.references.authors.tei.xml
<?xml version="1.0" ?>
<TEI xml:space="preserve" xmlns="http://www.tei-c.org/ns/1.0" xmlns:xlink="http://www.w3.org/1999/xlink"
 xmlns:mml="http://www.w3.org/1998/Math/MathML">
	<teiHeader>
		<fileDesc>
			<sourceDesc>
				<biblStruct>
					<analytic>
						<author><forename>A</forename>. <surname>Phillips</surname></author>

						<author><forename>T</forename>. <surname>Brennan</surname> and <forename>C</forename>. <surname>Pateman</surname></author>

						<author><forename>M</forename>. <surname>Sawer</surname> and <forename>M</forename>. <surname>Simms</surname></author>

<!-- snip -->
					</analytic>
				</biblStruct>
			</sourceDesc>
		</fileDesc>
	</teiHeader>
</TEI>

However, this is not valid biblStruct, which must not have any non-marked-up content. The right element would be <bibl> here.

Also as you probably know, <middlename> is not valid TEI either (middle names are just  additional <forename>s... but I assume you're interested less in TEI conformance than in extraction efficiency. It's just that my auto-validating editor is mad at me for all those schema violations 😄.

AFAIK the training data files are not following strictly the TEI format, as they are "internal" files with the sole scope of being used for training, so in many case to avoid remapping all tags to the respective label there were introduced some additional tags 😄

Ok, I understand. Closing the issue.


Add MetricsContainer support to the Flink sources.

This is an updated version of the abandonned https://github.com/apache/beam/pull/25753.
I simply rebased master in the original PR and reviewed the code.
fixes https://github.com/apache/beam/issues/25741

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

The failing test is running fine on my machine. I think the test is just flaky. It would probably succeed if someone just re-triggers it.

assign set of reviewers

clicked to rerun the tests, maybe a flake?

Thanks @tvalentyn. It failed with the same error so I guess it's deterministic...

waiting on author

Actually, looking at the test execution, it passed:
BUILD SUCCESSFUL in 31s
103 actionable tasks: 64 executed, 39 from cache

Publishing build scan...
https://ge.apache.org/s/a7mu5k567st5o

and fails later. I am fine with filing a separate issue about test reporting, and merge this.

@jto do you prefer to merge it or you'd like to work more on https://github.com/apache/beam/commit/4296688a3caaf31910fb3dd804acc8910ffd2f7d ? Perhaps we should move out that commit into a separate PR to make sure we don't make the situation worse in this PR.


Bugfix/plots

Fix bugs for plots
Add CLI
I am not sure about ALGO_LEVEL values. Maybe HINT has to be the default value with -1

Beutiful readme and great work, thanks!


SAK-25289 - Breadcrumbs trail incorrect when accessing forum topics

From what I can see the problem here is some old code from 2005 in setSelectedForumForCurrentTopic. It did a check if selectedforums != null and returned but in this case for some reason the selectedForum wasn't null but it was the wrong forum from a previous request. In the regular forums workflow selectedForum is ALWAYS null so I don't even see the point of this, and it seems to be not even always doing what you'd expect a setter to do.
It seems to me like this is the best fix. An alternate might be to see why the selectedForum isn't reset. selectedTopic is always reset by this code in resetTopicById and I think it's expecting the forum to set along with the topic.

I could see if maybe this was an NPE check on topic but it's not. This pattern is too old to figure out what was going on here to me.


Checkbox State Not Maintained?

First off, thank you for making this plugin!  It is a relief that I can now have checkboxes in my tables.
I am having an issue related to the state of the checkbox, i.e. whether it is checked or not.  It seems like the html is not getting updated when the box becomes checked?  This is causing an issue with being able to sync the tables - if I check off a box on one device, the box still shows as unchecked on another device.
Is this intentional?

Can you double check if your checkboxes are in the correct format as described here?
Also, what version of Obsidian are you using?


Failed to create user namespace: user namespace disabled

singularity shell lolcow_latest.sif WARNING: failed to set O_CLOEXEC flags on image INFO:    Converting SIF file to temporary sandbox... WARNING: failed to set O_CLOEXEC flags on image FATAL:   while extracting lolcow_latest.sif: root filesystem extraction failed: extract command failed: WARNING: failed to set O_CLOEXEC flags on image WARNING: failed to set O_CLOEXEC flags on image ERROR  : Failed to create user namespace: user namespace disabled : exit status 1
How to solve?? thank you!

i installed sintularity with conda . conda install -c conda-forge singularity .

That's an unprivileged installation so it requires unprivileged user namespaces to be enabled in the Linux kernel.  That's not available on very old kernels, and other kernels (for example those based on RHEL7) require a non-default configuration option to be set.
By the way, this would be a more appropriate question on the main repository https://github.com/apptainer/apptainer or on the mailing list or slack than on this documentation repository.

i have installed it with root.
But it still doesn't work.

An Ubuntu subsystem was installed in the Windows 10 system for testing.

I guess the Windows System for Linux is not a complete enough emulation for Linux for this.  Somebody else ran into a different issue trying to use conda with singularity recently there, in apptainer/singularity#6340.
Closing, as there's not likely anything that can be done about this and in any case this the wrong place to discuss it.

@DrDaveD  thank you very much! Wls1 for windows linux subsystem needs to be upgraded to WSL2. i have solved it.