GH1274: Add GitLab CI Build System

This PR adds support for the build system GitLab CI (#1274).
I have added support for reading the environment variables added by GitLab as they are documented in the GitLab CI readme.
There are test fixtures for the new classes and I have extended the Build System test cases to cover GitLab as well.
I have run the test suite locally and everything passes as well as testing the new code on a GitLab instance to verify that the properties are all parsed correctly.

Hi @antwilliams, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, DNFBOT;

On the whole it looks quite well but I would not recommend the way you handle with environment variables requiring a least version of GitLab CI / runner.
For example the variable CI_PIPELINE_ID is only available for GitLab CI 8.10 or higher. In your implementation GitLabCI.Build.PipelineId will also return 0 if not defined. I think that if running on GitLabCI < 8.10 it should ether return null or throw an exception that it is not available for this version of GitLab.
Especially for string values which are not available. string.Empty is not the result someone would expect if a value is not set.
May we should ether change the default values for int to -1 and string to null or compare against CI_SERVER_VERSION and throw an exception.

Thanks for the feedback @reicheltp, I agree on the different variables requiring different versions of GitLab.
I wasn't sure what the "Cake Philosophy" was when it came to handling situations like that. Should we throw or should we return some sort of default value?
The issue in my mind is that if we throw then we will potentially have different behaviour between variables that depend on the server version through CI_SERVER_VERSION and variables that depend on the runner. There isn't a variable defined (or at least a documented one) that lets you determine the version of the runner, this means we will have to handle that gracefully.
We could:

validate version on server variables and ignore runner version
continue as implemented (return String.Empty or 0 for missing values)
ignore version but throw an exception if an environment variable is missing (probably due to incorrect version)

I copied the philosophy of ignoring missing environment variables from the implementation of the other build systems, Bamboo and BitBucket specifically (since I am familiar with those systems too).
Do any of the Cake maintainers have any feedback?

I've just rebased this after PR #1222 was merged (merging build system changes is a pain!).
I notice that the ticket associated with this PR has been tagged as being part of the 0.17 release, I don't know when that is scheduled for but I am going on holiday tomorrow for a week. I won't be able to respond to any review actions until I get back.

@antwilliams thanks for rebasing, and for letting us know.  It may not be released until you get back, as we have quite a backlog of PR's that we want to work through.

@antwilliams your changes have now been merged, thanks for your contribution 👍


Update supervisor.py

This was quite confusing (encountered when modifying original tutorial https://github.com/tensorflow/models/blob/master/tutorials/rnn/ptb/ptb_word_lm.py )

Thanks for the fix!


Fix terraform consistent variables for machine deployment replicas

What type of PR is this?
Fixing terraform variables for consistency among cloud providers

What this PR does / why we need it:
To enable consistent variables among cloud providers for the machine deployment replicas.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.com/kubermatic/ps-team-flotilla/issues/99 ticket
Here is a link to the discussion: https://kubermatic.slack.com/archives/CF50UEULV/p1655967112739659
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Looks good to me. Please check with Artiom the following things:

On Hetzner this would be a breaking change. Ask Artiom if that is OK, at least we have to document it in the release notes that it is a breaking change
Please ensure that the docs are also updated. So the KubeOne docs and the examples in the KubeOne repo

You mean so the kubeone docs and example both rhyme with same updates?

yes


Grid randomizations

Wrote an example notebook to cleanly perform the first 2 steps of omics integration. Also added R visualization directly to the notebook.
Added grid search for randomization experiments. In fact, the new function _grid_randomization is a generalization of grid_search.

@iamjli this is looking quite nice. I think we're getting close to merging.

Thanks for the comments, @zfrenchee . There are a few functions in the example notebook that may belong in graph.py. Mind taking a look?

Seems to me like all three functions, summarize_grid_search, get_networkx_subgraph_from_randomizations, prune_network_graph all belong in graph.py.
But that would mean more back-and-forth. Are you alright with that?

Sorry it took so long to get back to you!

@zfrenchee I don't have write access.


Add capability to change environment

I created a new PR where I did that change. https://github.com/dmathieu/glynn/pull/55
But I'm not a full ruby developer, so I don't know how create unit tests for that change. Anyone can help me with that?

I'll look at your PR later. No need to open an additional issue :)


Send to thanks page after submit.

How can i load another url after submit the form, for conversion?

yeah I did similar to above my code looks like this, the thanks and error html files are in the same dir as the webform, my syntax is slightly different -
form.addEventListener('submit', e => {
e.preventDefault()
fetch(scriptURL, { method: 'POST', body: new FormData(form)})
.then(response => { console.log('Success!', response); window.location.href="thanks.html";} )
.catch(error => { console.error('Error!', error.message); window.location.href="error.html";} )
})

You might want to change the js

form.addEventListener('submit', e => {
e.preventDefault()
fetch(scriptURL, { method: 'POST', body: new FormData(form)})
.then(response => console.log('Success!', response), location = "yourpagehere.com)
.catch(error => console.error('Error!', error.message))
})

Which file is this in? Is it in the code.gs or on the js for the webpage? Sorry if it's a dumb question, I'm new to this haha


⚠ DDoS-Relay AU-syd1-02 has degraded performance

In 7384f20, DDoS-Relay AU-syd1-02 (http://<IP_ADDRESS>:42069/;csv) experienced degraded performance:

HTTP code: 200
Response time: 370 ms

Resolved: DDoS-Relay AU-syd1-02 performance has improved in 6db414f after 6 minutes.


Could you explain to me how to use the PsuedoClasses.Hover please?

My first reaction is this doesn't work, but most likely I don't know how to use it.
I created a new site that uses BlazorStyled:
Blazor Excelerate - Code Generate C# Classes From Excel Header Rows
Code: https://github.com/DataJuggler/Blazor.Excelerate
Live Demo: https://excelerate.datajuggler.com
I tried several ways to turn a link color orange on hover, when I have this class:
<Styled @bind-Classname="DownloadLink2">
background: none !important;
border: none;
padding: 0 !important;
font-family: Verdana;
text-decoration: none;
cursor: pointer;
height: 2.04vh;
line-height: 2.04vh;
font-size: @LargeTextSizeStyle;
font-weight: normal;
position: relative;
display: inline-block;
left: 114%;
top: .4vh;
margin-top: .4vh;
z-index: 41;

Then I tried a few different ways of using the same class name DownloadLink2 and creating another BlazorStyled entry with a PsuedoClasses.Hover:
<Styled @bind-Classname="DownloadLink2" PseudoClass="PseudoClasses.Hover">
color: orange;

And I tried another string variable
<Styled @bind-Classname="DownloadLink2Hover" PseudoClass="PseudoClasses.Hover">
color: orange;

And none of this worked. The only way I could get it to work is going to my site.css, and creating this:
.downloadlink2hover
{
color: white;
}
.downloadlink2hover:hover
{
color: orange !important;
}
Added a second class entry to my download link.
@Response.FileName
I would like to have done this all with BlazorStyled if I knew how.
Is this possible with just BlazorStyled?
Many Thanks,
Corby

The example on the homepage of https://blazorstyled.io use Hover to change the color of the text to white. Does that not do what you were expecting?

I will try it again as soon as I get a chance. I am pretty sure that is what I tried.
Thanks for the reply
From: Chanan Braunstein @.>
Sent: Monday, November 1, 2021 5:00 PM
To: chanan/BlazorStyled @.>
Cc: Corby Nichols @.>; Author @.>
Subject: Re: [chanan/BlazorStyled] Could you explain to me how to use the PsuedoClasses.Hover please? (Issue #115)
The example on the homepage of https://blazorstyled.io use Hover to change the color of the text to white. Does that not do what you were expecting?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/chanan/BlazorStyled/issues/115#issuecomment-956700937, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGI4P7K2COFIBLNWLCNLWZDUJ4EXDANCNFSM5GWO74MQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Refactor khalendar.expand

Don't modify the vevent -- I think there was a bug where we strip the
timezone information from DTSTART, but never add it back.

Remove special return-path for events without RRULEs

Linthub is for Python 2 code. It doesn't recognize Python 3 syntax.

I looked at this just now and I think it's okay, but because this is one of the most complex functions in all of khal, I'm going to do it again (hopefully tomorrow) before merging it.

Force-push to update commit status

looks good, please rebase and merge


Is there any way i can run a function on select disabled dates?

Is there any way i can run a function on select disabled dates? i need to show some alert when user click outside the allowed dates. Can i do this? thanks a lot :)

Hi @ivanyufen
Check out #42 for an example on how to achieve this:
https://github.com/MarceloPrado/flash-calendar/assets/8047841/f2947294-4a52-4add-bff9-4f238f16f3c1


Crowdsale improvements

First of all, @frangio thx for the amazing Crowdsale PR. I've really enjoyed reading the code. Great job :) !
While reading I've noted on a side a few comments and suggestions for improvements. I'd be grateful if you let me know what do you think about them:

Crowdsale contract is tightly coupled to MintableToken. Wouldn’t it be better to make the base Crowdsale as generic as possible? It will allow others to implement a model when the token pool is created before a sale and then transferred rather than minted. Currently, it’s impossible to override methods like:

	function createTokenContract() internal returns (MintableToken) {
I will suggest extracting:
token.mint(beneficiary, tokens);
to
 function distribute(beneficiary, tokens) internal {
  token.mint(beneficiary, tokens);
}

And probably rename:
function createTokenContract() => setupTokenContract()

Precondition checks are kept within a method body mixing with business logic. It’s a better practice to extract them to modifiers:

require(beneficiary != 0x0);
require(validPurchase());

Balance update is very verbose:

uint256 weiAmount = msg.value;
uint256 updatedWeiRaised = weiRaised.add(weiAmount);

….

// update state
weiRaised = updatedWeiRaised;

Am I missing any benefit of such separation? Why not just:
weiRaised = weiRaised.add(msg.value);

Code that checks if a sale has ended is duplicated leading to the risk of inconsistency once updated or overridden:

bool withinPeriod = current >= startBlock && current <= endBlock;
function hasEnded() public constant returns (bool) {
	return block.number > endBlock;
}

CappedCrowdsale. Conditions that checks if a cap is reached are independently implemented in two places (similar to above):

bool withinCap = weiRaised.add(msg.value) <= cap;

bool capReached = weiRaised >= cap;

CappedCrowdsale. Missing sanity check for cap > 0

RefundableCrowdsale. Missing sanity check for goal > 0

RefundVault. Should we start in an ACTIVE state when Crowdsale is not activated yet. This may potentially lead to accepting money outside of Crowdsale. The vault lifecycle should correspond to the Crowdsale lifecycle.

RefundVault Once again we may replace inline checks with modifiers:

require(state == State.Active); => inState(State.Active)

RefundVault. Function:

function refund(address investor)
is open to everyone. I think we limit the privilege to depositors or owner. It will be surprising if a third party initiate refunds. Why not use a standard pullPayment pattern in here.

RefundVault. It will be nice to have a clear policy regulating what to do with untouched funds. Part of them may be stuck forever due to lost keys. We may introduce a  refund period after which the remaining money may be sent to the crowdsale wallet or split among all of the investors.

It will be nice to have well-defined states that describe Crowdsale lifecycle like:

enum State {CREATED, ACTIVE, PAUSED, CLOSED, FINALIZED}
It will add more clarity and reduce code duplication in checking functions preconditions. We may even introduce a state machine pattern so derived Crowdsale contracts may easily add code when certain transition happen (like onTransition(ACTIVE,CLOSED).

The last comment is rather an invitation to discussion. What do you think about replacing inheritance with composition in the form of mixings (implemented as linked libraries)? My experience shows that this approach is usually more flexible and easier for maintenance. I’m just afraid that we may run into trouble when there are additional features requests and the inheritance hierarchy gets deeper. (Event currently there are 3 levels: Crowdsale -> FinalizableCrowdsale -> RefundableCrowdsale)

Thanks for reading that. I'm looking forward to hearing your opinions.

Thanks a lot @jakub-wojciechowski! The crowdsale contracts were a joint effort by the OpenZeppelin team 😄.
It's great to see you excited about collaborating. There's a lot of suggestions in this PR and I can't go over everything thoroughly at the moment but I will revisit it in the next couple of days and get back to you. Are you in the OpenZeppelin slack so I can reach you there?
In the meantime, though, there are a couple of suggestions which you can go ahead and open PRs for: 3, and the missing sanity checks.

Cool, thanks for the instant reply. I will open the PRs.
I've just joined the Slack as "kuba". I'm looking forward to discussing this stuff whenever you are ready.

Some projects prefer "allocate + burn" token sales over "mint" token sales. In this case the whole token supply is created with the token contract. Then one gives approve() for the crowdsale contract and the crowdsale contract does transferFrom().
https://github.com/TokenMarketNet/ico/blob/master/contracts/AllocatedCrowdsale.sol#L54

I totally agree. This is exactly the scenario that I'm describing in the 1. comment. Happy to hear that you have similar views.

I forgot to comment on that, but yeah I completely agree that we should make Crowdsale more generic! We want to stay pragmatic though, and not abstract more than people need.

For 2. Precondition oriented programming it's more about the coding style. In some point you hit the limits of Solidity language design. When you have a lot of precondition checks the function declarations grow longish. In this point you start to act against the original precondition oriented idea to make the code more readable. Furthermore in some cases it makes sense for preconditions happen in a certain order, after function has taken some preparation steps to calculate variables together.
But in the end, I feel it's a matter of taste and one really should not care as long as the project as a whole takes one approach and follows it from the start to the end.

Moved 1 to #351.
Moved 4 and 5 to #352.
3, 6 and 7 and have been fixed in #312.
2 and 9 we won't fix for the reasons @miohtama stated above. (The new require function makes preconditions in function bodies look much nicer.)
8 doesn't make much sense to me because the only address allowed to send money to the contract is the crowdsale, so there is no risk of someone sending money at a different time. Additionally, a specific crowdsale might have more stages in its lifecycle than the RefundVault might care, e.g. if there is a prefunding period the refund vault behaves the same.
Regarding 11, I'd prefer to keep the simpler current behavior. I think we can expect people to want their money back, and do without the added complexity.
12 would be nice but it seems non trivial to do. I will think about it. Allowing inheriting contracts to intercept state transitions sounds very attractive.
13 is very broad but it's on my mind too. We tend to favor inheritance for reasons of gas costs and to make deployment simpler. We could open an issue about this or discuss it in slack.

I love that you went through the code and proposed enhancements and things to discuss about it! Next time make sure to open separate issues so that we can discuss things separately and take action independently. 😄


option to update monthly?

hi, cool docker service to set up an in sync mirror, but is it somehow possible to only update let's say monthly? or maybe even only on demand?

Thanks
If you don't want to update "ever" the best is to comment these lines:
`
echo "Will run diff fetcher"
#run the diff fetcher
$BINDIR/fetch_osc_and_apply.sh $REPLICATE_SERVER --meta=yes &
#AREAS
echo "Will run areas"
cp -pR $OPASS_MAIN/src/rules $DBDIR/
$BINDIR/dispatcher --areas --db-dir=$DBDIR &
sleep 5
echo "Will run rules loop"
$BINDIR/rules_loop.sh $DBDIR &
`
However this won't generate areas.
If you want instead areas but not updates, you can comment the fetch_osc_and_apply line, areas will be generated each year. It's a bit of a waste of ressources but it's the simples way..
I could maybe to manage a patch if you really need this option .
Cheers

an --update=never  or --update=monthly would definitely be cool and save a lot of CPU time for people who don't really need a very up-to-date mirror...

hmm, even commenting all those lines out, i still see /Overpass-API/src/bin//update_database --meta do a lot of work?!?


Implementation of OpenTelemetry

Thank you for the wonderful tool. Have you considered SMTP level tracing on your mail server?
For example, it would be useful if you are using a mail server as a relay server and want to trace the processing results all at once.

I think you're interested in opentelemetry traces, with spans and attributes, right? With spans for individual SMTP commands, and/or activity like SPF or DKIM verification.
So far, the structured logging has been more than enough for me. What kind of use cases/insights will opentelemetry tracing help with? Performance debugging maybe?
I think it would require adding tracing calls throughout the (SMTP) code paths, to start & end spans, and to set attributes?
Mox can log SMTP protocol traces (and IMAP) with the trace* log levels, but I don't think that's what you're looking for.

I was thinking of using it for distributed tracing. For example, in the case of relaying mail servers in multiple stages, I think it would be good to have a mechanism to propagate the trace ID on each mail server.

So you would have to propagate the trace ID over SMTP to another mail server?
I'm don't know of a standardized way to pass such an attribute. A custom mechanism could be created.
Once that's available, including it in structured logging may be enough?
I'm not sure I really understand the use case. Is this a setup you already have (relaying mail servers in multiple stages)? And are you running into trouble that currently can't easily be debugged?
I tend to wait to implement things like this when there's a clear & strong enough need for it (that warrants implementing/maintaining the feature).

Currently, I am using Postfix and am having trouble debugging distributed tracing in such an environment.
I thought it would be possible to achieve something like this with this solution, so I would like to propose it again once this technology has matured further.
thank you


Fixes to Image Loading

Loading an image will no longer keep its file under lock until exiting the program.
Images are no longer cached, now you can make changes to the image and it can be reflected if you tell Markdown to reload. (I have not added a method to check for image changes.)

Looks good. Thanks for your contribution.
My apologies for leaving this hanging out there so long.


Download videos in 360p

Hello, get_highest_resolution() is not downloading videos in the highest available resolution (e.g., 720p, 1080p, etc.). Instead, the downloaded videos are being saved in 360p, even when higher resolutions are available in MP4 format.

Not a bug. This has been discussed recently. Search for the "closed" issues. Youtube changed on its side.
Start searching here: https://github.com/JuanBindez/pytubefix/issues/145


[trackedFunction]: fix error handling so Glimmer does die when an error is thrown

See also: https://github.com/qunitjs/qunit/issues/1736
ember-async-data's error handling isn't enough, as it turns out:
https://github.com/tracked-tools/ember-async-data/blob/main/ember-async-data/src/tracked-async-data.ts#L57
so here adds a try/catch with reactive state handling.

thankyou, I now seem to be able to write tests where I throw an error inside the tracked function, and the test can check that the error handling occurred & error message rendered


fix(lints): enable linter rules

Fixes #149
Describe the changes you have made in this PR -
In the previous pull requests of this issue, linter rules are fixed and removed from analysis_options.yaml. They must be marked as true to enable them.
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 14 (71.43%)  changed or added relevant lines in 9 files are covered.
8 unchanged lines in 7 files lost coverage.
Overall coverage remained the same at 71.894%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ui/views/ib/ib_landing_view.dart
0
1
0.0%

lib/ui/views/projects/edit_project_view.dart
0
1
0.0%

lib/ui/views/groups/my_groups_view.dart
4
6
66.67%

Files with Coverage Reduction
New Missed Lines
%

lib/models/ib/ib_showcase.dart
1
5.26%

lib/ui/views/contributors/components/contributors_donate_card.dart
1
84.21%

lib/ui/views/contributors/components/contributors_support_card.dart
1
94.44%

lib/ui/views/home/components/feature_card.dart
1
93.33%

lib/ui/views/projects/project_preview_fullscreen_view.dart
1
0%

lib/ui/views/teachers/components/teachers_card.dart
1
94.74%

lib/ui/views/ib/components/ib_pop_quiz.dart
2
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3860

Relevant Lines:
5369

💛  - Coveralls


Open/create pull request in browser

I'm not sure how well suited this is for neogit specifically but atm I still use a mismatch of tools to handle git in nvim. fugitive for diffs which #100 should resolve as well as lazygit.nvim but slightly more complex functionality (outside the scope of this issue) one such feature and currently my most sorely missed in neogit is the ability to open or create a pull request for the current branch.

o in lazy git whilst on the branch will open a new or existing pull request. Since this isn't something that git will give you directly.
I had a look at the source for lazygit
https://github.com/jesseduffield/lazygit/blob/069c7c9d3583c15aea34c08ff7c8be299c94f60d/pkg/commands/pull_request.go#L112-L139
It seems to be possible for a subset of providers which I think is fine for an initial implementation (github,gitlab, bitbucket) and hopefully people can contribute more once the system is in place.
The general idea seems to be essentially constructing and opening a url.
Does this sound like something that could be added to neogit? (Not sure in which popup, maybe the branch popup or a new PR one 🤷🏿 not sure how this plays with magit and what that does?)
PS: I could help try and put this together at some point in the future if there are no other takers/it was my bug bear/granted you approve

Have you looked at https://github.com/pwntester/octo.nvim before?

@TimUntersberger I have actually but octo is very specific to github and I work with gitlab and bitbucket from time to time so it wouldn't really be a multipurpose solution. Also I don't really need/want all of the functionality that octo provides just this bit about opening PR urls

@akinsho Until we figure this out you can use the following code in your config.
local neogit = require 'neogit'
local a = require 'plenary.async_lib'

neogit.setup {
  on_init = function()
    a.scope(function()
      local remote_url = a.await(neogit.cli.config.get("remote.origin.url").call())
      local repo_name = remote_url:sub(16, -5)
      local branch = neogit.repo.head.branch

      local open_pr_url = string.format("https://github.com/%s/pull/new/%s", repo_name, branch)

      a.await(a.scheduler())
      -- on unix
      -- vim.cmd("!open " .. open_pr_url)

      -- on windows
      vim.cmd("!start " .. open_pr_url)
    end)
  end
}

@TimUntersberger thanks for the snippet I just tried it out with some tweaking I can't seem to find where neogit.repo is though, this field is actually nil and I'm not sure what it should be instead

@akinsho yeah sorry. I pushed the commits to the wrong branch. Latest master should now be working.

@TimUntersberger I only changed it slightly because I needed it to work with a gitlab and github off the bat
command {
    "NeogitOpenPr",
    function()
      a.scope(
        function()
          local fmt = string.format
          local remote_url = a.await(neogit.cli.config.get("remote.origin.url").call())
          local repo_name = remote_url:sub(16, -5)
          local branch = neogit.repo.head.branch

          local services = {
            github = {
              pr_url = "https://github.com/%s/pull/new/%s"
            },
            gitlab = {
              pr_url = "https://gitlab.com/%s/merge_requests/new?merge_request[source_branch]=%s"
            }
          }

          local current
          for service, _ in pairs(services) do
            if remote_url:match(service) then
              current = service
              break
            end
          end
          if not current then
            return vim.notify(fmt("No supported service for %s", remote_url))
          end
          local open_pr_url = fmt(services[current].pr_url, repo_name, branch)

          a.await(a.scheduler())
          if as.has("mac") then
            vim.cmd("!open " .. open_pr_url)
          elseif as.has("unix") then
            vim.cmd("!xdg-open " .. open_pr_url)
          end
        end
      )
    end
  }

@TimUntersberger one thing I'd like to add to this is a check to see if the remote branch exists before opening the URL since if the branch hasn't been pushed that has to be done first. lazygit uses
// CheckRemoteBranchExists Returns remote branch
func (c *GitCommand) CheckRemoteBranchExists(branch *models.Branch) bool {
	_, err := c.OSCommand.RunCommandWithOutput(
		"git show-ref --verify -- refs/remotes/origin/%s",
		branch.Name,
	)

	return err == nil
}

But I'm not sure using the neogit API how to execute that git command

@akinsho added show-ref to the cli.
a.scope(function()
  local branch = neogit.repo.head.branch
  local remote_url = 'refs/remotes/origin/' .. branch
  local cmd = neogit.cli['show-ref'].verify.show_popup(false).args(remote_url)
  local exists = a.await(cmd.call()) ~= ""
end)

I set show_popup false, because the command will err when the remote doesn't exist and we normally would display the error popup in this case.

Awesome thanks I'll try that out

Actually I think maybe I spoke to soon. Will do some more testing but I think somehow exists is always coming back as true 🤔 . Will test some more and report back.

Also regarding this functionality in general I thought I had seen something about it in some Magit videos on youtube and it turns out it was https://github.com/magit/forge which provides this functionality for magit. Tbh that plugin is doing a lot, a lot of which is very cool but I don't know that a whole other plugin is needed for something as small as this. I think if more functionality like this was being added then it might warrant being split of into something separate but doesn't seem to warrant it now.

Actually I think maybe I spoke to soon. Will do some more testing but I think somehow exists is always coming back as false 🤔 . Will test some more and report back.

You could manually set the remote url instead of using the actual one if you want to test it.

@TimUntersberger I just ran the command in my terminal e.g. git show-ref --verify -- refs/remotes/origin/<my-branch> and that works but I get nothing back via the neogit so I think maybe it's the implementation of show-ref

Having this function randomly in neogit feels odd tbh. IMO we should just create a new plugin for this. We could then easily provide utility functions like this one. I also want to make the custom keybindings more flexible by supporting functions which could them be used by plugins to "inject" functionality.

Fair enough, was worth seeing if it would be a fit. I was tempted to start something like neoforge but I've already got too many plugins on my plate and I'm not sure I've got the time (or will) to create and maintain another. I can close this out  🤷🏾♂ ?
Think I'll just stick with tweaking the function here or lazygit.

Actually been thinking about this for a few weeks and thinking I might actually despite  ☝🏾 maybe look into how creating something like a neoforge plugin might work. I'm not sure what that sort of plugin would require need to watch more emacs tutorial on magit/forge, but from a few that I saw it seems like forge is able to create or add to the magits popups to inject it's own options into certain places.
Would that be something that would be possible @TimUntersberger or that if I fleshed out exactly what was needed (to start) you'd be up for?

Would that be something that would be possible @TimUntersberger or that if I fleshed out exactly what was needed (to start) you'd be up for?

Not too sure whether it is possible right now, but I would try my best to support someting like this 👍

@akinsho any updates on the forge like plugin? Closing this issue, because I think the original problem has been fixed.

@TimUntersberger I just ran the command in my terminal e.g. git show-ref --verify -- refs/remotes/origin/<my-branch> and that works but I get nothing back via neogit so I think maybe it's the implementation of show-ref

I think regarding the initial functionality, I stopped at this point since this wasn't working. I'm not sure if it would work now or not after the latest changes.
Regarding a new plugin I'm still mulling it over tbh, I noticed that the commit PR was refactoring some functionality so thought I'd wait and see anyway for that to land. I'm not sure now if I'd be able to use the neogit API to add in a popup to the status buffer or a switch to an existing popup?

I use this for this purpose: https://github.com/kristijanhusak/vim-create-pr
(super minimal)

Glad you said something @fnune - this was very straightforward to integrate. b o will use the new vim.ui.open API to open the pull request URL if a branch's upstream is configured.

Sweet!
Requires Neovim 0.10.0 :sob:
https://github.com/neovim/neovim/milestone/36
Really looking forward to it haha :)

Haha, or nightly builds, of course. The new vim.ui.open() api removes a lot of headaches


Bugfix electron cropping

Fixes issues in https://github.com/webmixedreality/exokit/pull/337.
This fixes some problems with using the Electron NativeImage crop functionality in our paint transfer. Basically crop (done via Skia in their code) seems to mess up the stride of the resultant bitmap, so we were blitting it incorrectly into the canvas.
The fix here is to do the damage blit ourselves in JS. This is probably more performant than what we were doing before with the image flip (which is still necessary), since we are flipping less pixels now.


Extension throws error on case-matched regex comparison, while CL Neovim does not.

Basically, vscode-neovim throws an error on the regex \m\\\@<!\%(\\(\|\\\@<!\\\[\|\$\$\|\$\) when used in a cased regex comparison (=~#), while the CL version of Neovim does not.
Steps to reproduce:
Neovim:

Launch your Neovim 0.5+ CLI (bash -c nvim)
Press : to enter command line mode
Paste if '$' =~# '\m\\\@<!\%(\\(\|\\\@<!\\\[\|\$\$\|\$\)' | echo 'true' | else | echo 'false' | endif
Press enter to run
Observe output "true"

VSCode:

Launch a VSCode instance with vscode-neovim installed
Open any file (you just need a buffer open)
Press : to enter command line mode
Paste if '$' =~# '\m\\\@<!\%(\\(\|\\\@<!\\\[\|\$\$\|\$\)' | echo 'true' | else | echo 'false' | endif
Observe error E54: Unmatched \(
Press enter to run
Observe: no printed output

Expected behavior:
Extension prints the same thing as CL Neovim.
Actual behavior:
Extension throws error when CL Neovim does not
Some context for decoding the regex:
This is a regex used by vimtex to locate math mode delimiters $, \(, and \[. pattern.txt has all the info you need for figuring out what items like \@<! (negative lookbehind) do. I tried to simplify the regex, but the error always seems to disappear! Also note that this only happens when doing a cased comparison. Non-cased comparisons and normal searches work fine.
My setup
My Neovim version is v0.5.0-728-gf6ac37560. I've checked that I'm using the same version for both VSCode and bash. I'm using a WSL Neovim installation and hooked up vscode-neovim to use that installation.

I can no longer reproduce this


Revert rename of .gitkeep for consistency

Merge after the inclusion of the merged PR https://github.com/twisted/towncrier/pull/647, which closed https://github.com/twisted/towncrier/issues/643, in the next release of towncrier.
Closes #6225.

I would argue this work isn't ready yet given the fact that there is no release yet for towncrier and as such the changelog run fails.
I also wonder if there shouldn't be a bit more info in the doc entry regarding the need for the rename to fix the towncrier which we can revert due to fix in the upstream project.
I also think this link should be in the issue description, https://github.com/twisted/towncrier/pull/647 it's your fix that we are waiting to be released.

@stevepiercy It looks like there's a release of towncrier with this change available now.

@davisagli I had the wrong link in the description. Updated. No release since 2024-07-31, so we have to wait a bit longer. I subscribed to Watch > Custom... > Releases so I will get a notification.

Towncrier 24.8.0 was released today, so we can merge the PR, after it passes checks.

Towncrier is happy now. Merging.


TLS 1.0 and 1.1 are retired

According to this:
"Starting January 13, 2020, Azure Container Instances will require all secure connections from servers and applications to use TLS 1.2. Support for TLS 1.0 and 1.1 will be retired." -link
So, I believe that the nginx.conf file in this section shouldn't have them listed for 'ssl_protocols'. Correct?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ed58f2c-446c-b500-122f-407628a8eb17
Version Independent ID: bce3f5a3-45d8-6b93-522e-a9af298068f5
Content: Enable SSL in a container group - Azure Container Instances
Content Source: articles/container-instances/container-instances-container-group-ssl.md
Service: container-instances
GitHub Login: @dlepow
Microsoft Alias: danlep

@marckassay Thank you for bringing this to our attention. I will have the content author review this and make an update as appropriate.

@marckassay - Thanks for pointing out this issue! We'll review and plan a doc update in the near future.

Doc update published - thanks again for raising the issue.
#please-close


*: add ColumnLimit for clang-format

What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tiflash/issues/7896
Problem Summary:
I choose a few files to show the effect of changing the clang-format.
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[x] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-integration-test


Binary intempl_Darwin_arm64.tar.gz v0.2.697 displays version 0.2.696

Not sure if the binary is the correct version compilation and only the version info is incorrect, but I got a little confused by this. Here's a video demonstrating:
https://github.com/a-h/templ/assets/469519/fe4bd531-5caa-4b88-8be7-4c074d594d1c

This was a small error on the release of this version, @a-h are we going to revoke this tag and re-tag?

Yes, I think that's sensible.

When ? (Because it complains about a wrong version, when generating)

I confirmed the issue with another of the artifacts of release v0.2.697:
/tmp/tmp.LmiNrOAo8r
$ wget https://github.com/a-h/templ/releases/download/v0.2.697/templ_Linux_x86_64.tar.gz
--2024-05-21 15:29:45--  https://github.com/a-h/templ/releases/download/v0.2.697/templ_Linux_x86_64.tar.gz
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://objects.githubusercontent.com/github-production-release-asset-2e65be/356677177/4a2fa23d-9e4a-4639-b023-caa50c94eb52?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240521%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240521T132835Z&X-Amz-Expires=300&X-Amz-Signature=e7c796acf76c965412c7c4c9f1b79f7b9bc3240c151aa438ac17196cdfbd38b0&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=356677177&response-content-disposition=attachment%3B%20filename%3Dtempl_Linux_x86_64.tar.gz&response-content-type=application%2Foctet-stream [following]
--2024-05-21 15:29:45--  https://objects.githubusercontent.com/github-production-release-asset-2e65be/356677177/4a2fa23d-9e4a-4639-b023-caa50c94eb52?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240521%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240521T132835Z&X-Amz-Expires=300&X-Amz-Signature=e7c796acf76c965412c7c4c9f1b79f7b9bc3240c151aa438ac17196cdfbd38b0&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=356677177&response-content-disposition=attachment%3B%20filename%3Dtempl_Linux_x86_64.tar.gz&response-content-type=application%2Foctet-stream
Resolving objects.githubusercontent.com (objects.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to objects.githubusercontent.com (objects.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 4219557 (4,0M) [application/octet-stream]
Saving to: ‘templ_Linux_x86_64.tar.gz’

templ_Linux_x86_64.tar.gz                           100%[==================================================================================================================>]   4,02M  --.-KB/s    in 0,1s

2024-05-21 15:29:45 (37,0 MB/s) - ‘templ_Linux_x86_64.tar.gz’ saved [4219557/4219557]

/tmp/tmp.LmiNrOAo8r
$ ls
templ_Linux_x86_64.tar.gz
/tmp/tmp.LmiNrOAo8r
$ tar xf templ_Linux_x86_64.tar.gz
/tmp/tmp.LmiNrOAo8r
$ ls
LICENSE  README.md  templ  templ_Linux_x86_64.tar.gz
/tmp/tmp.LmiNrOAo8r
$ ./templ version
v0.2.696

Confirmed on linux too

Confirmed:
go install<EMAIL_ADDRESS>templ version
v0.2.696

Sorry about the confusion.
I've updated the script that creates the version number to add a check to prevent future mis-tagging.
Today, I've released a new version with a couple of new features and some bug fixes: https://github.com/a-h/templ/releases/tag/v0.2.707 so I think we can close this one as "wont fix" since there's a new release out. I think doing anything else would cause more confusion.

confirmed (macos)


Add option to use polling instead of filesystem events when watching for filesystem changes

Describe the problem
Currently sveltekit uses cheap-watch to detect when files have changed while running the dev server (https://github.com/sveltejs/kit/blob/master/packages/kit/src/core/dev/index.js#L76). cheap-watch makes use of fs.watch, which uses a system-specific event callback when a file changes.
Unfortunately, when listening for events on a network drive (such as when using docker with a mapped folder), no events are emitted when files are changed. Other similar tools have an option to use filesystem polling instead of event callbacks, such as chokidar: https://github.com/paulmillr/chokidar#performance:

usePolling (default: false). Whether to use fs.watchFile (backed by polling), or fs.watch. If polling leads to high CPU utilization, consider setting this to false. It is typically necessary to set this to true to successfully watch files over a network

Describe the proposed solution
I believe the most flexible solution would be to switch to a different filesystem watcher that supports polling as well as filesystem events (such as chokidar). Configuring the module could then be achieved through the svelte.config.js file and a link directly to the module's documentation can be added to the current documentation for configuring watch settings.
Alternatives considered
Another option could be to use a secondary module for polling the filesystem and have a config option in svelte.config.js to either use polling or filesystem events.
Importance
would make my life easier
Additional Information
The current use case for me is to enable developing in docker. Currently, filesystem watching doesn't work at all due to network shares not triggering filesystem events, so HMR does not work. Everything works when running locally so it's not a showstopper, but it would be nice to have support for dockerized development environments.

One possible solution is to use Vite's file watcher from the dev server as well, which uses chokidar. I'm not sure how that would affect HMR, but it may be doable.

in https://github.com/sveltejs/kit/pull/3138 we switched to using Vite's chokidar instance, so you can configure the watcher via the Vite config: https://vitejs.dev/config/#server-watch


[pythonPackages.brotli] Fix src hash

Description of changes
The previous hash was incorrect, it didn't consider "forceFetchGit" flag. In repl:
nix-repl> :b pkgs.fetchFromGitHub { owner = "google"; repo = "brotli"; rev = "v1.1.0"; hash = "sha256-MvceRcle2dSkkucC2PlsCizsIf8iv95d8Xjqew166wc="; forceFetchGit = true; }
error: hash mismatch in fixed-output derivation '/nix/store/8kllgfcnhrqyndkixca38i7lvkjnpvdf-source.drv':
         specified: sha256-MvceRcle2dSkkucC2PlsCizsIf8iv95d8Xjqew166wc=
            got:    sha256-U1vAupUthD5W0xvlOKdgm9MAVLqsVyZUaFdeLsDAbDM=

but without forceFetchGit flag the old hash is fine.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

fixed in b68dd007fa2708e505e142751e2c8c1c8c50018d


Translate /concept/overview/working-with-objects/field-selectors in korean

/concepts/overview/working-with-objects/field-selectors/

/assign
/language ko

cancel this issue


Solution: createMany() throws an error "Problem with Directus".

The below line throws an error: "Problem with Directus"
https://github.com/apstanisic/directus-dart/blob/0bc0443fbf1a8ec4a0bb9038eaff520987131dec/lib/src/modules/items/items_handler.dart#L98
It should actually be converted to list like below
final mapData = data.map((item) => converter.toJson(item)).toList();

Can you open a PR?

Added your fix. Please try version 0.9.0, and reopen if problem persist


collection_date

Current term details
Please supply the current details of the term that you would like to update:
Term name - collection_date
Term ID - [if known]
Structured comment name -
Definition -  Date sample was collected
Expected value -  date
Value syntax -
Example -
Preferred unit - yyyy-mm-ddTHH:MM:SS
Package(s) - all

Suggested update(s)
Please supply the new suggestions for any of the details listed below (only insert text to those details that should be updated):
Term name -
Structured comment name -
Definition -
Expected value -
Value syntax -
Example -
Preferred unit -
Package(s) -

Additional context
Specifically within soil or sediment, often in a lab incubation, material is collected from the field, brought back to the lab & an incubation with treatments is performed. Often years later. For example, soil collected in 2014, and later a lab incubation is done with plant growth and temperature treatments. There's not a good way to separate field collection date and incubation collection date. Parent -> child relationships can link this. But doesn't explicitly define.
Add any other context about the update request here, e.g. why you think this needs to be updated.

@wdduncan
@cmungall

NMDC is adding incubation start and collection date

If a submitter asked me how to represent your scenario I think I would suggest the GSC term MIXS:0000016:
Term name: sample material processing
Definition: Any processing applied to the sample during or after retrieving the sample from environment. This field accepts OBI, for a browser of OBI (v 2018-02-12) terms please see http://purl.bioontology.org/ontology/OBI
Are you asking us to look at updating the collection date term here? If so, please can you specify what the change you're proposing is? If not, can I close this ticket? Thanks.

@only1chunts
With a quick search on OBI (I'd say a bit longer than I would expect someone filling out metadata to spend), I don't see a term that well details a lab incubation. Also, even if I can add a lab incubation date, I can't add a start & harvest date.
Now, one could argue, that by providing a source material or parent-child sample link, you'd have the field collection date from the "parent material", and the collection date of the 'new' sample (the lab incubation sample) would be the date the incubation ended. However, that leaves a lot of room for missed information. When a soil, sediment, or plant is harvest from the field, say October, is VERY different carbon chemistry than in say June. If someone harvests soil from the field then does a lab incubation 6 months later, the collection date can be misleading.
I think the term Collection Date should be updated / clarified for exactly at what point the sample is being collected (field vs lab/experiment end). As well as the addition of new terms. Say if a lab incubation is performed, indicate that in sample material processing (if non OBI terms can be used in this field?/ if there's a term in OBI that indicates this) & then provide the start and stop dates (lab_inc_start/end term addition).


Add json support for couch-config get

big +1 :)
should we release a new version soon?

Merged. Thanks.


Adding basic travis config for linux

Change-Id: I582fc8f514f9abd877fa1003f07589c38c98fafc

Non enough computation time or memory to build on Travis with OS X


Auto select the only address suggestion when enter/return is hit

Auto select the the address suggestion item (when only one address is returned) when enter/return is hit.

Done


Improving Flow types

In files like https://github.com/vuejs/vue/blob/dev/flow/component.js there's a lot of uses of any, Object, and Function.

I'm currently improving the documentation around this in Flow, because we don't do a good enough job of explaining it right now. Sorry about that.

These types aren't actually type-safe. They are there for convenience purposes.

Instead of any you should use mixed (or a more specific type).
Instead of Function you should use (type, type) => type
Instead of Object you should use { prop: type } or { [key: type]: type } (for maps)

This will drastically improve user's experience with Vue using Flow.

Yep, it could definitely use some improvements! The declarations were added mid-way when a pure ES codebase was already in place, so there are quite a few places I was just trying to get by. My  Flow knowledge is also limited so I'd appreciate PRs.

@thejameskyle have you any link about using flow with vuejs?
i was try yesterday, but i was have much problems
@yyx990803 It would be great to have documentation like the one that was made for TS.

Is currently someone working on this? If not I would like to try it.

@MarkusToe Thanks for offering to help! :) Currently we are not actively working on improving the typings - we only add/change stuff we find while working on other parts, fixing bugs etc.
So it would be great if you can improve the situation here!


Style the page (CSS)

Very simple CSS - with more UI elements some library should be used, angular-material perhaps


[ch3092] Create an instant validation for multiple form

create a route api to dynamicly validate form send
create js to hand any form and display errors

https://app.clubhouse.io/enmarche/story/3092/intégrer-l-instant-field-validation-sur-les-formulaires-de-don-et-d-adhésion

@cacahouwete What about my review comment ?

Be careful, data (and validation) should be consistent between front and backend. Also, i don't think it's a good practice to implement two different validation logic.

@salahm Yeap :+1:
I think we gonna install something like API Platform on this project because we are going to have some pages entirely rendered with React. So this system will be soon deprecated.


Fix link in TUTORIAL.md

The link to the tutorials are broken (extra \tutorials folder in path) in TUTORIAL.md

The link to the tutorials are broken (extra \tutorials folder in path) in TUTORIAL.md

Indeed, thanks for reporting it. It will be fixed in #459.


Fixed typo on readme

I don't think you are comparing DelayMiliseconds correctly on Features/Delay***() Shorthands & Aliases.
// UniTask
await UniTask.Delay(500, cancellationToken: cancellationToken);

// with UniTask Supplement
await UniTask.DelayMilliseconds(500, cancellationToken);

Thanks for your PR.
There is no "DelayMilliseconds()" in UniTask, and this is an alias provided by the UniTask Supplement.
So it is as I intended.


Investigate multiple currencies for incentive rewards

Currently, the loans pallet only allows for setting a single global currency for subsidy rewards. Look into what implementing multiple subsidy currencies entails.

We might consider adopting the new farming pallet for this which already supports paying rewards in multiple currencies: https://github.com/interlay/interbtc/pull/826


Requiring a module with __dirname ignores the inclusion of flow pragma.

Somewhat related to issue https://github.com/facebook/flow/issues/176.
Given the two files:
/* @flow */
// src/foo/foo.js
var bar require('../bar/hello-world');
module.exports = bar();

// src/bar/hello-world.js
module.exports = function() { return "hello world"; }

Flow will return an error stating the the required module could not be found. However if we change the require statement to the following, it shall not return this error message.
/* @flow */
// src/foo/foo.js
var bar require(__dirname + '../bar/hello-world');
module.exports = bar();

Umm, I'm pretty sure Flow has no idea what __dirname + ... resolves to. :)
Will revisit this once you provide more information about #176, OK?

I think you avoid the error because flow ignores require statements whose argument is not at string literal. Please reopen if this is different from #176, and you can share some repro code. Thanks!


Formatting issue in subject with UTF-8

An email with subject "Test nmail" send to a friend (Gmail in that case) arrived with "=?UTF-8?Q?Test nmail?=" as subject. The body text was alright.
Ubuntu 18.04 chrooted from SailfishOS, smtp: disroot.org (no such UTF-8 issue usually), nmail just installed from git.

Do you know in which email reader the string "=?UTF-8?Q?Test nmail?=" appeared? Gmail web interface?
At a low level (for sending) nmail encodes every email subject in UTF-8. It's not really necessary for plain-ASCII subjects, but I chose to encode all to keep the code simple. Generally the receiving email client would decode it before displaying - I've tested it in a few popular ones (Gmail web, Outlook web, macOS Mail, etc) and haven't seen any failing to decode it, so it would be interesting to know which client fails. If you could send a simple test email to me (d99kris at gmail dot com) from disroot it would be great, otherwise I can try sign up for disroot to test. Just in case it's something with the SMTP service.
In any case - one could argue nmail shouldn't do UTF-8 encoding unless needed, so I'll look into fixing that.

Good point, I wanted to check on the webmail but actually postponed and, since it was late, just ended up forgetting. The wrong formatting appeared in SFOS e-mail application, but when checking Gmail's webmail, no issue. I guess this is something with the SFOS application then. I will be trying with other e-mail accounts including yours soon (maybe later today) and see if the same issue appears when sending something with nmail. Note however that, usually, e-mails sent to Gmail and checked in the SFOS application do not result in this formatting issue.

Cool thanks. Yeah, I think I can change nmail to not do the UTF-8 for plain ASCII (english) subjects.

Hold on, I tested again with the disroot.org (Rainloop) and Gmail webmails, and no issue this time. Not sure what caused it the first time.
Side question: do you have an idea why backspace works on one device but not the other? No issue on my phone with hardware keyboard and Ubuntu chroot, but it just prints "^?" on my real Linux computer running Solus. Also, I can send emails from the phone but not the computer. I guess I might just be missing a couple dependencies on the computer.


bad SMARTS with negation and AND queries

Here's an example:
In [3]: Chem.MolToSmarts(Chem.MolFromSmarts("[!#6;D3]"))
Out[3]: '[!#6&D3]'

Discovered while fixing #893

Oops, confused myself. It doesn't actually matter since ! has the highest precedence.


typo and code is similar to math in linear_algebra, orth_proj, and lln_clt.

Previous commits also consist of replacing bellman_operator with T.

@arnavs  Please, notice that I pushed another commit to Pooya1 and you can see. Thank you!

Hey @PooyaFa, should I close the other PR in favor of this one?

Yes thank you. I will apply your suggestions, and will update this branch.

I will also, run and test them again, so we can be sure that everything works fine. I will commit on this branch very soon.

OK great, thanks.
For the tests, just to confirm, switch into the branch, make jupyter-test (or jupyter-tests or whatever we decided to call it, you can check the Makefile). Then run all cells in the relevant notebook, and you can just do a control + f for @testset and make sure that all of them pass.

@arnavs Hi. I fixed the mistakes and test all the files. Thanks.

Thanks @PooyaFa, this looks much better.


Fix order of dungeons in the dropdown menu

https://cdn.discordapp.com/attachments/585262697281748992/614780071097532417/unknown.png


Providing immutable default value in Shape @dataclass

When I tried to run the project with Python 3.11.5 I'd get the following error:
$ python3 game.py ~/storage/git/llama.cpp/main ~/storage/git/llama.cpp/models/somemodel.gguf prompt.txt
Traceback (most recent call last):
  File "/home/user/storage/git/llama-journey/game.py", line 144, in <module>
    @dataclass
     ^^^^^^^^^
  File "/usr/lib/python3.11/dataclasses.py", line 1230, in dataclass
    return wrap(cls)
           ^^^^^^^^^
  File "/usr/lib/python3.11/dataclasses.py", line 1220, in wrap
    return _process_class(cls, init, repr, eq, order, unsafe_hash,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/dataclasses.py", line 958, in _process_class
    cls_fields.append(_get_field(cls, name, type, kw_only))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/dataclasses.py", line 815, in _get_field
    raise ValueError(f'mutable default {type(f.default)} for field '
ValueError: mutable default <class '__main__.Style'> for field style is not allowed: use default_factory

I changed the field to use a default_factory of Style and it seems to have resolved it (though I'm encountering another error that prevents me from testing game functionality beyond moving and equipping an item)

Thanks!


Mark query roles API public in Serverless

Marks Query Role API as public in Serverless and generates related specification.
Relates to https://github.com/elastic/elasticsearch/pull/118798

closing in favour of https://github.com/elastic/elasticsearch-specification/pull/3316, since validation is not supported from forks


refactor(x/twap): computeTwap edge cases and tests

Progress towards #3541
What is the purpose of the change
This PR focuses on refactoring geometric computeTwap to account for edge cases and returning errors if any are found.
The following edge cases are tested here:

We are able to calculate geometric twap given a max spot price * 100 years
We are not able to calculate geometric twap with (1 / max spot price) * 100 years

this is due to losing precision and falling under sdk.Dec's precision of 18
return error instead

Currently, spot price of zero is set in twap on any spot price error. When that happens, the accumulators are not updated. As a result, we must handle this test case. Here, we validate that geometric twap still works under this condition

TODO:

[ ] underflow test

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? not applicable

This was separated into other PRs and merged


Check that running a declare v1 yields a higher fee than simulating it without validation

This PR adds two tests that check that running a declare v1 transaction with validation yields a higher actual_fee than running the same transaction without validations. One by executing the transactions on their own, and another using the simulate_transaction function.
I wasn't able to replicate the bug described in #1051.
The only case where I found that the fee was the same running with and without validations was when using the starknet_programs/account_without_validations.cairo file as account contract (as the validation is trivial, it only adds 12 extra steps and at a weight of 0,01 gas per step this has no effect on the final fee).
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #1076 (2a8b7d3) into main (6da0b77) will increase coverage by 0.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   89.25%   89.80%   +0.54%
==========================================
  Files          49       49
  Lines       13038    13324     +286
==========================================
+ Hits        11637    11965     +328
+ Misses       1401     1359      -42

Files
Coverage Δ

src/lib.rs
98.90% <100.00%> (+0.13%)
:arrow_up:

src/transaction/declare.rs
94.51% <100.00%> (+0.95%)
:arrow_up:

... and 8 files with indirect coverage changes


refactor: using bitwise operations to save gas #104

[x] Changes in all the contracts for bitwise refactor done and compiled successfully.
[x] Fuzzing altered accordingly.
[ ] Unit tests yet to be re-written in hardhat. Not yet ready for review.

closes #104

I added important comments to in the issue #104 to aid with this task


$cookies is type of uknown while using i18n micro

Hi I've opened issue under the Cookie control repository, but posting it here as well since it could be possible that i18n micro somehow rewrites provided variables to the nuxtApp  just fyi
https://github.com/dargmuesli/nuxt-cookie-control/issues/235

Just from reading the issue description, I suspect it's related to https://github.com/s00d/nuxt-i18n-micro/blob/8a668d4e1cb37b5286c63f20ab16738eabc5f477/src/runtime/plugins/01.plugin.ts#L417 which I think should be removed as described in the changelog for Nuxt 3.13.0. Augmenting vue might be enough.

ok it might be, but the strange thing is, that the typecheck passes when there is cookie module itself, once I add i18n-micro module it fails. So it seems like the i18n would somehow rewrites provided values to nuxtApp context imo

So, I’ve removed all types for now in version v1.21.5.
Let’s see how it works. If anyone can help with setting up typing in Nuxt, I’d be really grateful. It’s been working terribly, and I spent about 10 hours looking for examples and studying the documentation, but I couldn’t figure it out, and nothing works. For now, types will be handled through composables.

So, I’ve removed all types for now in version v1.21.5.
Let’s see how it works. If anyone can help with setting up typing in Nuxt, I’d be really grateful. It’s been working terribly, and I spent about 10 hours looking for examples and studying the documentation, but I couldn’t figure it out, and nothing works. For now, types will be handled through composables.

Yes, it seems to be fixed now. Thank you


How can I prevent juggling of columns in ngx-virtual-scroller?

Following is the issue I'm facing:
https://stackoverflow.com/questions/62351516/how-to-prevent-juggling-of-columns-in-table-in-an-angular-app
The columns keeps on juggling around when scrolled down.
Please help.

Hi, did you find a solution for your problem? I may have facing it right now


Adding specific error codes to LUIS APIs and adding the subscription key as a requirement to the APIs.

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: a-hohaze sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Automation for azure-sdk-for-java

Automation for azure-sdk-for-python

Automation for azure-sdk-for-node

Can one of the admins verify this patch?

@AutorestCI regenerate azure-sdk-for-go

@yangyuan
What the status here, this PR has been opened for a while now. I will close by end of week if there's no updates and you can re-open later if required


fix: add missing import UIKit

Examples/Maps-SwiftUI/Maps/SearchPanelPhoneDelegate.swift add missing import UIKit

I agree to the PR, but Maps-SwiftUI build passes without its import 🤔  Could you let me know the reason why its import is necessary?

I've been able to reproduce this issue on my environment. Thank you for your fix!


Address deprecation in Octokit

Deprecation: [@octokit/rest] "number" parameter is deprecated for
".issues.createComment()". Use "issue_number" instead

I think we have an open issue for that. It's complicated because it would be a breaking change in Probot if I recall correctly

Oh really? I can leave it then.


Variables and keywords created or imported in initialization files are not available in the lower level test suites, why are they?

It is recommended that one suite has less than ten cases in the UserGuide, when I organise my suites and cases, I find it inconvenient to write cases as long as the restriction it is.
My project is like this:
MyProject
|_______ModuleSuites1
|		|_____FunctionSuite1(import Resources)
|		|		|______FunctionCase1
|		|		|FunctionCase2
|		|		|….
|		|
|		|_____FunctionSuite2(import Resources)
|		|
|		|FunctionSuite3(import Resources)
|		|….
|
|_______Resources
As you can see, I must to import resources in every suite when writing cases. I really want to import resource once in ModuleSuites  and then they are available in many FunctionSuites.
Can you explain why variables and keywords created or imported in initialization files are not available in the lower level test suites?  Are there better solutions to my problem rather than repeatedly import?

This was a design decision to avoid keywords and variables in higher level accidentally causing issues in lower level suites. It has sometimes been debated was that a good decision, but personally I still think it is. Due to backwards compatibility issues it wouldn't be changed anyway, though.

Also, robotframework-users mailing list and other such forums are better for general questions that this issue tracker.


Manifest tool v2.1.0

Summary of changes

Update README.md
Update pelion-e2e-python-test-library.lib to v0.2.9

[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.
For new board enablements only:
[] I confirm the board is Mbed Enabled and passes the Mbed Enabled test set.
[] I confirm the contribution has been tested properly and the tests results for TESTS are attached.
[] I confirm mbed-os.lib and mbed-cloud-client.lib hashes or the content in folders mbed-os and mbed-cloud-client were not modified in order to pass the tests.

Maintainers of this repository update the Mbed OS and Client hashes.
Please report any issues through issues in relevant repositories.

build-only

build-only

CI is not starting

CI is not starting

build-only

build-only

build-only

build-only

build-only

build-only

@teetak01 , any news regarding the CI?

build-only

Test run: FAILED

Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Test run: FAILED

Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Test run: FAILED

Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Test run: FAILED

Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Test run: FAILED

Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Update to 2.1.1.
This PR is ready for merge as it is but the CI is still broken.


_tkinter.TclError: no display name and no $DISPLAY environment variable

headless VM (no X-GUI) virtual debian machine (Linux ortho 6.1.0-13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.55-1 (2023-09-29) x86_64 GNU/Linux)
I want to run a dedicated VM for autoortho. Downloaded scenery files  to (/nfs/Ortho4XP/.autoortho-data/downloads)
X-Plane (MacBook) will mount nfs share from this dedicated VM.
How can I install the downloaded scenery files without the gui?
`root@ortho:~# /usr/local/sbin/autoortho_lin_0.7.1.bin -c -H
Config file found /root/.autoortho reading...
Found sceneries: []
[]
Saving config ...
Wrote config file: /root/.autoortho
INFO:main:Setup logs: /root/.autoortho-data/logs, log level: 10
INFO:autoortho:AutoOrtho version: 0.7.1
INFO:aostats:Creating stats object
INFO:flighttrack:Start flighttracker...
INFO:aostats:Starting stats thread
WARNING:werkzeug:WebSocket transport not available. Install simple-websocket for improved performance.

Serving Flask app 'flighttrack'
Debug mode: off
INFO:werkzeug:WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
Running on all addresses (<IP_ADDRESS>)
Running on http://<IP_ADDRESS>:5000
Running on http://<IP_ADDRESS>:5000
INFO:werkzeug:Press CTRL+C to quit
INFO:autoortho:Running CFG UI
Traceback (most recent call last):
File "/tmp/onefile_13695_1699180650_938623/main.py", line 35, in
File "/tmp/onefile_13695_1699180650_938623/autoortho.py", line 355, in main
File "/tmp/onefile_13695_1699180650_938623/autoortho.py", line 279, in init
File "/tmp/onefile_13695_1699180650_938623/config_ui.py", line 43, in init
File "/tmp/onefile_13695_1699180650_938623/config_ui.py", line 64, in start_splash
File "/tmp/onefile_13695_1699180650_938623/PySimpleGUI/PySimpleGUI.py", line 9614, in init
File "/tmp/onefile_13695_1699180650_938623/PySimpleGUI/PySimpleGUI.py", line 10300, in finalize
File "/tmp/onefile_13695_1699180650_938623/PySimpleGUI/PySimpleGUI.py", line 10075, in read
File "/tmp/onefile_13695_1699180650_938623/PySimpleGUI/PySimpleGUI.py", line 10146, in _read
File "/tmp/onefile_13695_1699180650_938623/PySimpleGUI/PySimpleGUI.py", line 9886, in _Show
File "/tmp/onefile_13695_1699180650_938623/PySimpleGUI/PySimpleGUI.py", line 16817, in StartupTK
File "/tmp/onefile_13695_1699180650_938623/PySimpleGUI/PySimpleGUI.py", line 16704, in _get_hidden_master_root
File "/tmp/onefile_13695_1699180650_938623/tkinter/init.py", line 2304, in init
_tkinter.TclError: no display name and no $DISPLAY environment variable`

if I run it with -H, it clearly states that no scenery is installed
`root@ortho:/home/pi# /usr/local/sbin/autoortho_lin_0.7.1.bin -H
Config file found /root/.autoortho reading...
[]
Saving config ...
Wrote config file: /root/.autoortho
INFO:main:Setup logs: /root/.autoortho-data/logs, log level: 10
INFO:autoortho:AutoOrtho version: 0.7.1
INFO:aostats:Creating stats object
INFO:flighttrack:Start flighttracker...
INFO:aostats:Starting stats thread
WARNING:werkzeug:WebSocket transport not available. Install simple-websocket for improved performance.
INFO:autoortho:Running headless
WARNING:autoortho:No installed sceneries detected.  Exiting.
INFO:aostats:Stopping stats thread

Serving Flask app 'flighttrack'
Debug mode: off
INFO:werkzeug:WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
Running on all addresses (<IP_ADDRESS>)
Running on http://<IP_ADDRESS>:5000
Running on http://<IP_ADDRESS>:5000
INFO:werkzeug:Press CTRL+C to quit
INFO:aostats:STATS: ID: {}
INFO:flighttrack:FlightTracker shutdown requested.
INFO:flighttrack:FlightTracker exiting.
INFO:autoortho:AutoOrtho exit.
`

How to force the installation of downloaded scenery files ?


new wrap: BigInteger

Public domain library with the source found here:
https://mattmccutchen.net/bigint/

Not sure about the name, what do you think about mattmccutchen-bigint?

Sounds appropriate to me.

https://github.com/mesonbuild/mattmccutchen-bigint


Incorrect min_y?

Based on this metric I believe the linked line may be incorrect.
https://github.com/jamwaffles/ssd1306/blob/96170fd21419e73fdb2299f395b07836d52d090f/src/mode/graphics.rs#L161
If that's supposed to be height, I'm happy to fix it, otherwise please provide an explanation why it's width.

Yeah that definitely looks like it should be height - 1. There's a similar block of code here, so it might be worth moving the min/max reset into a private method.

I haven't given it much thought, but shouldn't these be rotation aware values? Is min_y the same when rotated by 90 or 270 degrees?

Yes, there're the other variables which take the rotation into account. However it's a bit weird to have the manual comparison in the code. There're max() and min() functions for that.

There's a similar block of code here, so it might be worth moving the min/max reset into a private method.

You mislead me :) That block is marking the whole display to be updated, the original block resets the area to nothing.

Oop yes you're right, min/max are swapped there. My bad!


Delete a blob file do not work

When we do a dvc gc with -c argument, the file is expected to be cleaned on the cloud.
However, the remove on dvc_azure.AzureFileSystem seems do not work, only removes the file locally ?!

@Toutatis64 Could you elaborate, please? Not seeing anything obvious in adlfs or our wrapper that could result in local file deletion.

Well sorry, i'm able to see that there are requests on API delete blob from Azure portal, so it's probably another issue ...
I close this one, i'll continue to investigate then.

Was due to retention policies of 7 days :/ Not clear on the interface, but debugging specific file, I realized that the file appear in deleted blobs ! Sorry for the lost time.


[LOG4J2-2919] Call ReliabilityStrategy's beforeStopAppenders() method before stopping AsyncAppender

Call ReliabilityStrategy's beforeStopAppenders() method before stopping AsyncAppender
to avoid errors caused by logging with AsyncAppender  while system is reconfiguring
Submitted by: gengyuanzhe<EMAIL_ADDRESS>

@rgoers  Can you help me review my pr?

Right, those test failures are caused by a commit I made yesterday or two days ago that I need to revert (haven't had a chance to do so yet). As long as your PR isn't introducing new failures, you won't need to worry about the build failures.

@jvz  Truly appreciate your reply. I'm newer for this project. I wonder what should I do next for this PR or issue?

If you're able to write a unit test that would fail without your PR and passes with your PR, that would help a lot in preventing regressions. Otherwise, one or more of the committers here will review and merge this.
There's been a bit of work recently in our unit tests (hence the test failures at the moment) which might make it easier to write a test for. You could use Mockito or some stub appenders to verify the behavior. Let me know if you have any questions about the testing framework as our Log4j-specific code (the JUnit 5 parts at least) are all relatively new still.

@jvz This PR is about a concurrent problem. As we all know, concurrency problems always require some kind of execution order.  I cannot write a standard unit test for this case.  But  by modifying the method org.apache.logging.log4j.core.appender.AsyncAppender#append and add a sleep() in the beginning, I can control the excution order and  reproduce the error in a unusual way.  I've describe the details in my issue. If you have some advices to write a standard unit test for my problem, please tell me. (I try to learn how to test this case from  LOG4J2-1121, which first introduce ReliabilityStrategy but miss handling the AsyncAppender case, but there are also no unit tests for the LOG4J2-1121).

I usually use https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html for chaining together asynchronous things (particularly in unit tests) where you can await the latch where you'd normally sleep, and countdown the latch in places where work is completed. However, since concurrency bugs like that are difficult to test sometimes, I think it'd also be acceptable if you include the detailed reproduction steps in the Jira ticket so that I can try writing one. I may be able to help you design a unit test here, though, depending on how comfortable you are with concurrency code.

@jvz I have described the reproduction step in great detail in LOG4J2-2919 of Jira, and draw a picture to illustrate the 2 thread excute order, as well as the test code and log4j2.properties
Need I copy it to LOG4J2-1121?

Just the one Jira is fine, thanks!

Just the one Jira is fine, thanks!

Ok, it seems that you just open my Jira link a minute ago :joy:. Any way, it's a big step forward. If you have question about my reproduction steps, please tell me. And please help me finish the unit test. Thank you~

Ooh yeah, this is going to be an interesting test to write. This will likely require some test-specific refactoring. Let me see if I can figure this out! :)

Turns out this didn't really need any concurrency primitives as I found an appropriate extension point to assert behavior upon.


Update inlets logo to latest design

Updates the OSS inlets logo to the latest design and
colour-scheme.
Signed-off-by: Alex Ellis (OpenFaaS Ltd<EMAIL_ADDRESS>Pre-submission checklist:
Already accepted via #1438. Updating the logo design and colours, everything else remains as-is

Deploy preview for landscape ready!
Built with commit a74f75d15393444e8f95c1ea892cc465208483fd
https://deploy-preview-1987--landscape.netlify.app

Thanks!

Thank you 👍


ARROW-6631: [C++] Do not build any compression libraries by default in C++ build

From the look of the diff, I would say that configuring a comprehensive build looks too complicated to me (it's only relevant for developers and packagers, though, so more a maintainability nuisance). Perhaps ARROW-6585 can help with this

Re: complexity, what if the cmake var was like ARROW_COMPRESSION=bz2,zlib,zstd,lz4,snappy,brotli and could take some subset of those, or all for all of them?

Single options toggling is better since it'll integrate with IDE and cmake-aware tools.

It'd be nice to have a shortcut. I suggest we tackle adding such shortcuts holistically. I think it's still helpful to have on/off flags in some cases

Looks like the wheels are failing for an unrelated reasons (something having to do with protobuf in Homebrew). I'll fix the Windows issue

Appveyor failure looks legit too: https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/27961055/job/4rdh31hvlbh6r184

@ursabot crossbow submit -g linux

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6d05bc8). Click here to learn what that means.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##             master    #5607   +/-   ##
=========================================
  Coverage          ?   88.86%
=========================================
  Files             ?      983
  Lines             ?   132995
  Branches          ?     1501
=========================================
  Hits              ?   118192
  Misses            ?    14438
  Partials          ?      365

Impacted Files
Coverage Δ

cpp/src/arrow/util/compression.h
100% <ø> (ø)

cpp/src/arrow/util/compression_test.cc
98.23% <100%> (ø)

cpp/src/arrow/util/compression.cc
84.26% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d05bc8...b01d857. Read the comment docs.


Fix broken documentation

Add + to show all of custom theme definition.

@ngbrown We're changing the documentation for themes in v0.12 (which is going to be released soon) so this would not apply then. Thanks for this though!


D1 - Download ParT dataset and do the model training

Use: ssh<EMAIL_ADDRESS>Download the dataset and train the transformer model

We've got all datasets downloaded in "retrain_test_1" folder inside the particle_transformer directory.
The model is ready to train, in order to do the verification, we change the epoch to speed up the training process.
For the first several tries, we made 0.83-ish accuracy, which shows the model is valid.
For further work, we are going to change the epoch back to 50, also trying to change the value of parameters in order to achieve as high accuracy as we can.


Warnings even when using the 'Recommended querier timeout'

I noticed the following warnings in the system log:
Dec 18 13:33:19 pfSense pimd[24]: Recommended querier timeout = Robustness x query-interval + response-time / 2 = 3 x 12 + 10 / 2 = 41
Which is in two regards strange:

the default used to be 42 and
given this warning I changed it to 41

And the warning is still there and repeating with some frequency
After noticing this I checked the actual settings with pimctl show status, which confirmed that the query interval is the advised 41
<EMAIL_ADDRESS>pimctl show status
PIM Daemon Status
Elected BSR
Address          : <IP_ADDRESS>
Expiry Time      : 0h0m40s
Priority         : N/A
Hash Mask Length : 30
Candidate BSR
State            : Disabled
Address          : <IP_ADDRESS>
Priority         : N/A
Candidate RP
State            : Enabled
Address          : <IP_ADDRESS>
Priority         : 0
Holdtime         : 150 sec
Join/Prune Interval  : 60 sec
Hello Interval       : 30 sec
Hello Holdtime       : 105 sec
IGMP query interval  : 12 sec
IGMP querier timeout : 41 sec
SPT Threshold        : Enabled
SPT Mode             : packets
SPT Packets          : 0
SPT Interval         : 100 sec

Yeah this should be changed to follow the RFC values for query and timeout (180 and 300 iirc).
Thank you for the reminder 👍


⚠ Bofrost.nl has degraded performance

In c695cd3, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 3361 ms

Resolved: Bofrost.nl performance has improved in 7eb5710 after 8 minutes.


Translation for the page 'API Reference -> ReactDOMServer'

Please help us translating this page in Italian!
Aiutaci a tradurre questa pagina in Italiano!
You can find all the details about how to help here: https://github.com/reactjs/it.reactjs.org/issues/1
GRAZIE! :smile:

Ciao. I will work on it.

Ready for review #125


Preprocessing in squeezenet demo

What kind of preprocessing is done when infer() in the squeeznet demo is called?
Is it only subtracting the imagenet mean or are the RGB channels also changed to BGR somewhere? If not, is there a way to do this?
Thanks!

It's just subtracting out the imagenet mean. We're going to have a transpose operation on the GPU soon!

Wouldn't there already be gpu switchdim in 0.3.1 due to #195?

Ah yes, @reiinakano is right (he implemented it), you can use switchDim. @reiinakano++
We're going to rename it to transpose soon (but wont break switchDim calls).

Great, thanks!


Rapid triggering of Redstone conduit can cause severe chunk re-rendering

Issue Description:
Rapid triggering of Redstone conduit appears to cause a lot of chunk re-draws.
What happens:
While visiting Rorax' base on ForgeCraft, I noticed that I was seeing severe framerate drops (60+fps down to 30). Upon investigating, I noticed that the performance graph in the debug menu was showing large spikes during flashing of her insulated redstone conduit that is causing events in her RFTools Endergenic Generator system.

The spikes in this image directly correlate to changes in the Redstone.

The reason I suspect this is an issue with Ender IO over RF Tools is because the problem goes away when you are not looking at the chunk, and RFTools does not seem to have any changes to it's static rendering with the redstone pulses.
What you expected to happen:
I expect the framerate to be relatively stable.
Steps to reproduce:

Set down approximately 25-30 conduits.
Set up a clock (redstone or otherwise, shouldn't matter) to tick every 1.5 seconds.
When the clock pulses, trigger a series of other redstone pulses 3 ticks offset from each other (I.e, 3, 6, 9, 12, and 15 ticks)
Observe a series of FPS spikes as the pulses.

Affected Versions (Do not use "latest"):

EnderIO: <IP_ADDRESS>_alpha
EnderCore: <IP_ADDRESS>-alpha
Minecraft: 1.9.4
Forge: <IP_ADDRESS>8

Your most recent log file where the issue was present:
[pastebin/gist/etc link here]
https://gist.github.com/AtomicBlom/f3b8df759a717464539c4d93fd068469

Sorry, that's just how redstone works. It triggers a chunk re-render when it changes state.

The conduits change color when active (like vanilla redstone), so have to be re-rendered
You could try putting facades on them but I suspect something recieving the changing signal will want to be re-rendered in response (e.g. a vanilla redstone lamp).
Not sure there is much we can do about this.

I have just finished a cleanup of the redstone conduit code and have (hopefully) significantly improved their behavior. Would you be able to update to the latest build and let me know if the issue is fixed? Anything version <IP_ADDRESS>+ will have the new code.

I'll give it a shot after work tonight.

Sorry about @CrazyPants, I couldn't get a spare moment last night. Performance is MUCH better. 105 fps with facades, 70fps for naked RS conduits with 1 change per tick.
Thanks for your hard work.


solidjs-fix: readme

Fix readme file.
Fixes: #884
Fixes: #883
Fixes: #882
Fixes: #881

There should be information that tells the user to use either npm, yarn or pnpm. We can't just take out pnpm run from the command. 😃

What if I add under the the Commands title something like "Run this commands with your favourite package manager" and then the list of pure commands?


removed required prover_did

closes #52
Implemented according to: https://github.com/hyperledger/anoncreds-spec/issues/107#issuecomment-1376698662
Also removed the dependency on indy_utils::DidValue which makes #40 a whole lot easier.
Signed-off-by: blu3beri<EMAIL_ADDRESS>

@TimoGlastra I think I fixed the issue, it was a bit unclear to me but this should hopefully be it.


Enable +bulk-memory for wasm by default.

As discussed in #466 , let's enable bulk-memory operations by default.

Thanks!
You'll need to increment this number from 2 to 3 to disable the CHANGELOG test. (If this crate was published, then a proper entry in the changelog would have been needed. But since the crate is still 0.1.0-git, no need to track changes yet.)

Got it, incremented the version and the test is passing now. Thank you.


feat: w3c anoncreds support

Summary of Changes
Add support for receiving w3c-anoncreds credentials via the new DataIntegrity attachment format
Add support for rendering dif pex presentation requests using the existing rendering logic
Add support for presenting credentials via PresentationExchange
Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Could you add a video demo where an AnonCreds credential is received using Data Integrity and shared using Presentation Exhcange?

cc @cvarjao @jleach @swcurran

Could you add a video demo where an AnonCreds credential is received using Data Integrity and shared using Presentation Exhcange?

https://www.loom.com/share/96e7dc8f407a40b7902b0f9472ead94f

@auer-martin Able to fix the two conflict and well get this merged in?

@auer-martin Able to fix the two conflict and well get this merged in?

done

it seems like the change is not backwards compatible to indy credentials. I'm getting the following error whenever I try and get an indy credential:
"name": "CredoError",
"message": "AuJrigKQGRLJajKAebTgWu:4:AuJrigKQGRLJajKAebTgWu:3:CL:209526:default:CL_ACCUM:9fc50d37-b15d-47f2-8ada-75c2249abc44 is not a valid did:indy did",

here is the demo you can use to get credentials: https://digital.gov.bc.ca/digital-trust/showcase/
Once that issue is resolved I'm happy to merge

@wadeking98 BTW it's OK to be on an alpha version for now. We'll be releasing 0.5.2 soon, and will make a follow up PR then to the stable version

okay sounds good, I'll do some testing in a bit and then we'll get this merged!

Okay seems to be working well if bifold, I'm still running into an issue when I link it to bc wallet but I think that must be an issue with some configuration on our end. Great work LGTM


Proxy keys should use proper URL forms rather than plain scheme strings. Instead of "localhost", use "localhost://"

I am trying the new sglang version v0.1.17 with FastChat and I am getting this error:
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/FastChat/fastchat/serve/sglang_worker.py", line 17, in <module>
    import sglang as sgl
  File "/sglang/python/sglang/__init__.py", line 30, in <module>
    from sglang.backend.litellm import LiteLLM
  File "/sglang/python/sglang/backend/litellm.py", line 9, in <module>
    import litellm
  File "/usr/local/lib/python3.10/dist-packages/litellm/__init__.py", line 236, in <module>
    module_level_aclient = AsyncHTTPHandler(timeout=request_timeout)
  File "/usr/local/lib/python3.10/dist-packages/litellm/llms/custom_httpx/http_handler.py", line 42, in __init__
    self.client = httpx.AsyncClient(
  File "/usr/local/lib/python3.10/dist-packages/httpx/_client.py", line 1458, in __init__
    {URLPattern(key): transport for key, transport in mounts.items()}
  File "/usr/local/lib/python3.10/dist-packages/httpx/_client.py", line 1458, in <dictcomp>
    {URLPattern(key): transport for key, transport in mounts.items()}
  File "/usr/local/lib/python3.10/dist-packages/httpx/_utils.py", line 364, in __init__
    raise ValueError(
ValueError: Proxy keys should use proper URL forms rather than plain scheme strings. Instead of "localhost", use "localhost://"

I was able to solve this issue by changing my no_proxy and no_proxy env variables to be in the format http://localhost instead of just localhost. However I am getting now this error:
2024-06-10 12:36:08 | ERROR | stderr | INFO:     Started server process [3975704]
2024-06-10 12:36:08 | ERROR | stderr | INFO:     Waiting for application startup.
2024-06-10 12:36:08 | ERROR | stderr | INFO:     Application startup complete.
2024-06-10 12:36:08 | ERROR | stderr | INFO:     Uvicorn running on http://<IP_ADDRESS>:30000 (Press CTRL+C to quit)
2024-06-10 12:36:08 | ERROR | stderr | Exception in thread Thread-1 (_wait_and_warmup):
2024-06-10 12:36:08 | ERROR | stderr | Traceback (most recent call last):
2024-06-10 12:36:08 | ERROR | stderr |   File "/sglang/python/sglang/srt/server.py", line 246, in _wait_and_warmup
2024-06-10 12:36:08 | ERROR | stderr |     assert res.status_code == 200
2024-06-10 12:36:08 | ERROR | stderr | AssertionError
2024-06-10 12:36:08 | ERROR | stderr |
2024-06-10 12:36:08 | ERROR | stderr | During handling of the above exception, another exception occurred:
2024-06-10 12:36:08 | ERROR | stderr |
2024-06-10 12:36:08 | ERROR | stderr | Traceback (most recent call last):
2024-06-10 12:36:08 | ERROR | stderr |   File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
2024-06-10 12:36:08 | ERROR | stderr |     self.run()
2024-06-10 12:36:08 | ERROR | stderr |   File "/usr/lib/python3.10/threading.py", line 953, in run
2024-06-10 12:36:08 | ERROR | stderr |     self._target(*self._args, **self._kwargs)
2024-06-10 12:36:08 | ERROR | stderr |   File "/sglang/python/sglang/srt/server.py", line 250, in _wait_and_warmup
2024-06-10 12:36:08 | ERROR | stderr |     print(f"Initialization failed. warmup error: {e}")
2024-06-10 12:36:08 | ERROR | stderr | UnboundLocalError: local variable 'e' referenced before assignment
2024-06-10 12:36:13 | ERROR | stderr | Traceback (most recent call last):
2024-06-10 12:36:13 | ERROR | stderr |   File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
2024-06-10 12:36:13 | ERROR | stderr |     return _run_code(code, main_globals, None,
2024-06-10 12:36:13 | ERROR | stderr |   File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
2024-06-10 12:36:13 | ERROR | stderr |     exec(code, run_globals)
2024-06-10 12:36:13 | ERROR | stderr |   File "/FastChat/fastchat/serve/sglang_worker.py", line 290, in <module>
2024-06-10 12:36:13 | ERROR | stderr |     runtime = sgl.Runtime(
2024-06-10 12:36:13 | ERROR | stderr |   File "/sglang/python/sglang/api.py", line 39, in Runtime
2024-06-10 12:36:13 | ERROR | stderr |     return Runtime(*args, **kwargs)
2024-06-10 12:36:13 | ERROR | stderr |   File "/sglang/python/sglang/srt/server.py", line 320, in __init__
2024-06-10 12:36:13 | ERROR | stderr |     raise RuntimeError(
2024-06-10 12:36:13 | ERROR | stderr | RuntimeError: Initialization failed. Please see the error messages above.
/usr/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '

I found the error for the first problem. My no_proxy was set to localhost,<IP_ADDRESS>,<IP_ADDRESS>, setting it to no_proxy=<IP_ADDRESS>,localhost,<IP_ADDRESS> fixed the problem.

My issue is solved. We can close the ticket.

@dmilcevski The no_proxy variable accepts mask, and <IP_ADDRESS> means "everything", so it should not be in no_proxy. I don't understand how you solved this problem, it looks like a bug.

I also got the same error:
ValueError: Proxy keys should use proper URL forms rather than plain scheme strings. Instead of "localhost", use "localhost://"
it is a bug!

Another solution is pip uninstall litellm if you aren't using litellm.


Nodes reconnecting due to fallen hosts don't connect properly to the new node

This worked fine in the last iteration of the web app with Vuetify. Switching to Quasar broke the functionality. I have noticed 2 issues:

If the connection is established, the video player doesn't reopen
The connection fails

(Note: It could be that the connection fails in the first case as well. This needs to be looked into more to pinpoint the exact problem)

The logoff message is not being sent when a client closes the tab. Because of that the network tree doesn't update. This is also causes peer count to not be updated for root node.

socket.on("disconnect", () => {     console.log("user disconnected " + socket.id);   });
We should somehow use this event to figure out which room a socket belonged in.


Accessibility Updates: Shift-Tab, div order, and button names

Fixes:

Previously Safari couldn't shift-tab, and now it can.  Added a check so Pixi won't be tricked by false positives for mouse movements.
Previously the fallback logic was broken for buttons without titles or hints.  A correction and a few extra checks mean it should now work as intended on all major browsers.
Previously buttons were in reverse order in the DOM.  Braille displays make use of that order and would show buttons in backwards-order.  Flipped this around (also makes debugging a little more intuitive).

Enhancement:
3. One of the first things I tried to do with Pixi accessibility was to update a button name to reflect a button's state change, but it had no effect when I tried.  The official Pixi demo is a great example of this need!  Buttons are toggled to light up the signs, but there's no indication of the button's new state.  I've added this functionality.
Live demo at:
http://superkeen.com/web/pixi
To get as many browser/screenreader combinations as possible to announce the change as soon as its made, I've added some ARIA attributes.  I've done quite a bit of testing to reveal how well this is supported.  See below for details:
Full support:
Windows Chrome (Narrator and NVDA)
Windows Firefox (Narrator and NVDA)
Windows IE (NVDA)
Partial support:
Mac Safari (Voiceover): fine until the focus leaves and returns to the page, then button name changes not announced right away, only on focus change; recoverable by restarting Voiceover
Win/Mac/ChromeOS Chrome (ChromeVox): when toggling, sometimes announces the old button name instead of the new one
No button name change support (just like legacy behavior):
Mac Chrome (Voiceover)
Mac Firefox (Voiceover)
Windows Chrome (JAWS)
Windows Firefox (JAWS)
Windows IE (Narrator and JAWS)
Windows Edge (Narrator, NVDA, JAWS)

@ivanpopelyshev thanks for demonstrating where the null value was coming from.  You're right, no need to check for undefined.  Should be addressed in newest commit.

@pbblair Thank you so much for this high-quality PR and sorry we haven't been more responsive. The team is spread a little thin right now trying to put a big effort into v5. @GoodBoyDigital is going to look at this when he's free. I'm for getting this in v4 since it does a better job at provide more device/browser coverage for accessibility.


chore: import repository https://github.com/hazemTa/thingsboard.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment