_versions file is now a separate chart

Symlinking the _versions file causes issues when having a requirements.yaml in some charts. This file is now moved to a seprate api-versions chart and all other charts can require it via requirements.yaml.
Whenever this chart is modified, make helm-dep-update must be called to update helm dependencies.
What this PR does / why we need it: Symlinking is broken and very hard to do correctly.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: I've uncommented all infa charts - I don't think that it's a problem
Release note:

NONE

Can you elaborate on the problems?
Are you really sure that uncommenting the values in the infra charts is safe?
Have you tested the changes for all Kubernetes versions we are supporting?

OK. Can you please rebase your branch? What about the remaining open questions from my previous comment?

ping

@rfranzke I've all of the Infra charts have their default values overwritten in their respected  .go files.

@rfranzke rebased to latest changes

⚠ #428 introduces a new symlink

@mvladev I have ran some tests locally and it seems that the machine-controller-manager is crashlooping because of missing permissions  machine-controller-manager 0/1       CrashLoopBackOff  . Also found that the machine-controller-manager addon is not specified in the requirements.yaml.
- name: machine-controller-manager
  repository: file://addons/machine-controller-manager
  version: 0.1.0

Can you please run another test and confirm?

FYI: Due to @zanetworker's analysis (changes needed) I have now merged other PRs, e.g., #428 which you were pointing add, @mvladev. Please also rebase and adapt your changes! Thank you!

@rfranzke I've tested it, but I recall that the cluster was created with no problem.
The problem might be with reading in runtime of the charts folder. I often switch branches - I probably ran controller with my local _versions branch and switched to some other branch - the charts dir was checkout-ed and It rendered correctly.
As a workaround and to ensure stability and reliability, when the controller is started, we might want to copy the entire charts folder in a temporary dir and read charts from it.
Sorry for the wasted time @zanetworker.

All issues should be fixed now - the cluster was created without any problems in 5ebf6b9
The only problem seems to be that after every single make helm-dep-update all archived tars are updated. This is a new behavior - in the previous versions they remained unchanged.

OK, thanks. Running make dep-helm-update is only needed if the api-versions chart itself changes, right? Hence, shouldn't happen too often, I guess.

@rfranzke it'll be needed also if you change one of the shoot-addons as well.

Oh ok, why?

@rfranzke it'll be needed also if you change one of the shoot-addons as well.
Oh ok, why?

Because, when using conditions in requirements.yaml, you can't reference them locally.:
dependencies:
- name: cluster-autoscaler
  repository: file://charts/cluster-autoscaler
  version: 0.1.0
  condition: cluster-autoscaler.enabled

This returns an error.

However, I really don't like that all the tgz files get modified on each and every single make helm-dep-update run. Can't this be worked around somehow?

Unfortunately, I'm not aware of way to do so.

What we can do is not to check them in and when the controller-manager is started to build them dynamically

Hm yeah, but this would increase start-up time significantly, right? And, for local development purposes we need them to be checked in, don't we?

What about -

We don't check them in git
When a developer clones the repo make helm-dep-update must be called.
The controller-manager can start as before
On change in charts -> make helm-dep-update
On build for release -> make helm dep-update

Yes, we could do this. However, I especially don't like the fourth point. Can we get to a state where we ONLY need to run make helm-dep-update if we change the api-versions chart? I don't want to run it for each and every change. That requirement is highly error-prone, especially with local files ignored by git (the tgz's).

⚠  PR has been updated with the new implementation. Checks for broken symlinks and template rendering have been added.
PR description has been changed to match with new changes

LGTM! Thank's for the check whether templates can be rendered!
PS: You should fix your editor formatting settings.

LGTM! Thank's for the check whether templates can be rendered!
PS: You should fix your editor formatting settings.

LGTM! Thank's for the check whether templates can be rendered!
PS: You should fix your editor formatting settings.

/lgtm

This PR is merged, but for some reason github doesn't recognize it as such.
Closing it.


Fixed  Error in remote asset sync on empty multi-value properties #3130

fixed https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/3130
@Roman-Skripka how's this look? It should skip making the property if the json array is empty.

looks good, thanks @davidjgonzalez . I will verify this at some point. For now I removed these properties from source instance to get it sync'ed.

This fix is in 6.0.14 (released)


Query configuration question

In my case, ADO items are organized in a multilevel parent-child hierarchy.
How do I configure the query such that I can filter mid-level items and show the output as:
parent item
mid-level item (apply filter based on Tags)
child item

@sdamodar - Thanks for your feedback; we appreciate it. To make sure we have all the information needed to address your issue, please let us know which article you’re referencing.
If your issue is a general one, not about a particular page, consider these resources:

Azure DevOps Services
Azure DevOps Support Bot
Azure DevOps on Stack Overflow


⚠ ClamAV has degraded performance

In ea410a9, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 62 ms

Resolved: ClamAV performance has improved in 90cf23a.


[Libra Framework] DesignatedDealer and ParentVASP account creation no…

… longer accepts base_url and compliance_public_key

Previously, creating a DesignatedDealer or ParentVASP account required specifying a (dummy, but valid) compliance_public_key and base_url. The idea is that the account owners will rotate to meaningful values after creation.
However, this creates a problem in the case that the private key for the dummy compliance_public_key is known: an adversary (including AOS, the creator of the dummy key) can use this to spoof dual attestation approvals.
Thus, this PR removes the dummy compliance_public_key and base_url at account creation altogether. Instead, these are filled with empty values that make dual attestation fail with a new EPAYEE_COMPLIANCE_KEY_NOT_SET error code. This change is in DualAttestation.move and is the only interesting part of the PR
One a DD or ParentVASP account has been created, the owner can rotate these fields to meaningful values (as before).

Concretely, what this does is:

Remove the compliance_public_key and base_url parameters from the create_parent_vasp and create_designated_dealer scripts (breaking change).
Remove the create_testing_account script, which is now identical to create_parent_vasp
Refactor the tests and prover specs that used the old scripts + functions

Awesome, that looks good on our end too!
Just a quick question: is EPAYEE_COMPLIANCE_KEY_NOT_SET only triggered for TR-subject transactions or all of them? Eg. can we send funds <$1000 without a compliance key

Btw, if we're already landing a breaking change, could we also change the DD creation to be sent by LR (instead of Blessed account)? IIUC this is the current requirement...

Awesome, that looks good on our end too!
Just a quick question: is EPAYEE_COMPLIANCE_KEY_NOT_SET only triggered for TR-subject transactions or all of them? Eg. can we send funds <$1000 without a compliance key

Only on TR-subject transactions; sending <$1000 before setting up a compliance key will work just fine.

Btw, if we're already landing a breaking change, could we also change the DD creation to be sent by LR (instead of Blessed account)? IIUC this is the current requirement...

No problem, will fix!

Btw, if we're already landing a breaking change, could we also change the DD creation to be sent by LR (instead of Blessed account)? IIUC this is the current requirement...

No problem, will fix!

I started doing this and it is is actually more complex than expected/raises some issues that make me question the requirement. I think we should consider this in a separate PR to give these issues appropriate consideration.

I started doing this and it is is actually more complex than expected/raises some issues that make me question the requirement. I think we should consider this in a separate PR to give these issues appropriate consideration.

Absolutely! I'm totally fine with both VASP and DD creation txns coming from the Blessed account. The LR requirements on this one is coming from your doc :)

/land

:boom: Tests timed-out

/land


Adding Phase Constraint UI

Still in the early stages

@catherine-martlin do we actually need to include t0?
https://github.com/ExoCTK/exoctk/blob/master/exoctk/phase_constraint_overlap/phase_constraint_overlap.py#L77

@mfixstsci We don't! We also need to address how we calculate obsDur now too - see #184 which has a few notes at the bottom about taking out T0 and updating obsDur. I made these changes in the other PR that had too much overlap with this one. If you want to update those things in this branch that's good with me - otherwise I can do a separate PR after this one to update those things.

Okay, this should make the code a little bit more robust. Ideally I would like it to let the user know they need to enter a period and observation duration in the form, but to have some overlap with the command line interface I changed the call from calculate_phase to calculate_phase_constraint. So right now, you can just enter the target name with period and/or transit == None and the behavior will be the same as if using the resolver. Not the type of functionality I want but Joe will be in tomorrow and I can ask him about the validators.

@catherine-martlin Should be ready now.

@hover2pi you still good to review this today if possible? Thanks!

I just pushed a change that addresses @jaymedina's comments.  Given the time, I suggest we tackle the if __name__ == __main__ stuff until after the workshop(?)
I will test this branch on the test server one last time.  Assuming the Travis builds pass, I think this is good to go.

@jaymedina @bourque the if __name__ == __main__ business is for people who want to run the tool from the command line. I don't know how useful that is but I'd say we work on making things more robust or changing that until after the workshop.


OSError: It looks like the config file at 'models/pytorch_model.bin' is not a valid JSON file

Hello,
Tested with Debian 11/12, cuda 11.7/11.8, different models, different precisions,with and without accel, etc. Other projects based on torch and transformers work well on the same machine.
I have these errors when running the script:
`python3 translate.py --sentences_path sample_text/en.txt --output_path sample_text/en2es.translation.m2m100_1.2B.txt --source_lang en --target_lang es --model_name models/pytorch_model.bin
Loading model from models/pytorch_model.bin
Traceback (most recent call last):
File "Easy-Translate/.env/lib/python3.11/site-packages/transformers/configuration_utils.py", line 702, in _get_config_dict
config_dict = cls._dict_from_json_file(resolved_config_file)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "Easy-Translate/.env/lib/python3.11/site-packages/transformers/configuration_utils.py", line 793, in _dict_from_json_file
text = reader.read()
^^^^^^^^^^^^^
File "", line 322, in decode
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 64: invalid start byte
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "Easy-Translate/translate.py", line 443, in
main(
File "Easy-Translate/translate.py", line 115, in main
model, tokenizer = load_model_for_inference(
^^^^^^^^^^^^^^^^^^^^^^^^^
File "Easy-Translate/model.py", line 75, in load_model_for_inference
config = AutoConfig.from_pretrained(
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "Easy-Translate/.env/lib/python3.11/site-packages/transformers/models/auto/configuration_auto.py", line 983, in from_pretrained
config_dict, unused_kwargs = PretrainedConfig.get_config_dict(pretrained_model_name_or_path, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "Easy-Translate/.env/lib/python3.11/site-packages/transformers/configuration_utils.py", line 617, in get_config_dict
config_dict, kwargs = cls._get_config_dict(pretrained_model_name_or_path, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "Easy-Translate/.env/lib/python3.11/site-packages/transformers/configuration_utils.py", line 705, in _get_config_dict
raise EnvironmentError(
OSError: It looks like the config file at 'models/pytorch_model.bin' is not a valid JSON file.`

Hi @vertikalm!
--model_name should be the path to either a HuggingFace hub model or to the directory path of a local model, not a pytorch_model.bin file. Inside the specified directory, you should have the model, the tokenizer, and the config.json file. The model should be stored in the hugginfface format (saved using model.save_pretrained(), tokenizer.save_pretrained() and config.save_pretrained()).

Thank you.
here a retired dinosaur Pascal/Assembler. Much to learn. I think that until now I have downloaded already quantified or cooked models. I understand.
Thanks for sharing this project.
Yo tampoco se vivir, estoy improvisando =:-)


log of memory bandwidth should also support zero value

https://github.com/gvsoc/gvsoc-core/blob/6ed2b5e31866b45297fd719bb0cef0126242a539/models/memory/memory.cpp#L231C8-L231C36
I propose the following change:
As the bandwidth is expressed as the 2log(bytes) in the python files a value of 0 would match a bandwidth of 1 byte per cycle.
Since this is a feasible bandwidth I'd suggest this statement should be:
if (_this->width_bits >= 0)
However this does mean that to configure memory with infinite bandwidth the value -1 should be used instead of 0.

Thanks a lot for your report ! I've merged the fix your propose.


fix(Workspaces): fix workspace member role update

Fix broken update on workspace's member role update.
Changes
Please list / describe the changes in the codebase for the reviewer(s).

Change filter_for_user query
Ensure that a user cannot update/delete his own membership

How/what to test

Test update of another user's role.
Check if you can delete/update your own role

@pvanliefland For the point Make sure that there is always an admin (i.e admins can't downgrade their role or remove themselves if there is no other admin) if we take these assumptions :


multilevel-offcanvas-menu not working in 6.4

Multilevel-offcanvas-menu does not completely function in 6.4
Since upgrading from 6.3 -> 6.4 I get a warning saying to use $offcanvas-vertical-sizes / $offcanvas-sizes instead of $offcanvas-vertical-size / $offcanvas-size.
Changing this breaks the set width of the menu and hides the MENU text when the menu is clicked.

Since upgrading the dropdown arrows on submenus no longer appear.

Finally the hamburger menu no longer transforms to an arrow when clicked.

Had to use a map such as $offcanvas-sizes: ( small: 250px, medium: 350px, large: 320px, ); outlined here. Doing this allowed the MENU box to slide correctly and not be hidden anymore.

The dropdown arrows were missing because of a missing reference to accordion-menu in the ul.

My code was

Accounting

AgentCO Report

Had to change to:

Accounting

AgentCO Report

Had to update the scss from

.is-open + .off-canvas-content.is-open .hamburger {
  .line:nth-child(1),
  .line:nth-child(3) {
    width: 12px;
  }

  .line:nth-child(1) {
    transform: translateX(-5px) rotate(-45deg);
  }

  .line:nth-child(3) {
    transform: translateX(-5px) rotate(45deg);
  }
}

to
.off-canvas-content.is-open-right .hamburger {
  .line:nth-child(1),
  .line:nth-child(3) {
    width: 12px;
  }

  .line:nth-child(1) {
    transform: translateX(-5px) rotate(-45deg);
  }

  .line:nth-child(3) {
    transform: translateX(-5px) rotate(45deg);
  }
}


Rancher agent restart

rancher agent restarts Repeatedly
when using rancher running on a separated RKE Cluster
using latest version of anything
and I done anything and nothing is working

Please use the issue template and provide the actual versions and the agent logs would be helpful too.


Recommend IMDSv2 with SSM, Recommend Disabling IMDS without SSM if No Instance Role Needed

I have my final feature request for the day, separate of SSM and LT that just occurred to me: if using SSM for Session Manager, the Instance Medata Service is required for the client agent on the instance to run. Recommending enforcing IMDSv2 only is a good call here to avoid token slurping from instance roles. So, a fun recommendation from a usefully opinionated tool like yours would be to say:

If using SSM for access via Session Manager or SSM more generally anyway, default to and recommend IMDSv2
If using any other instance role for authenticated AWS service access, still recommend IMDSv2
If passing an instance role profile of None, be super secure, default to and recommend not enabling IMDS (v1 or v2) at all

Not sure how you feel about this one. As always: if you like this recommendation, I am willing to give a go and code with/for you on GitHub.

Important idea! let me know if you can start working on this after #5.

Important idea! let me know if you can start working on this after #5.

Just putting it here for reference (or we can use this somehow):
https://github.com/salesforce/metabadger

OK now that we bumped a release, I can start working on this. :-)

OK now that we bumped a release, I can start working on this. :-)

Great! Waiting for your progress on this


Trying to update a share permissions role of a shared resource to a disabled role is possible

Describe the bug
When updating a share permissions role of a shared resource to any disabled role, the result is success.
Steps to reproduce

user Alice create a folder folderToShare
Alice shares folder folderToShare with any enabled share permissions role, for example, Viewer
Alice updates the share permissions role which is not enabled, for example, Secure Viewer

curl -kv -XPATCH 'https://localhost:9200/graph/v1beta1/drives/<drive-id>/items/<item-id>/permissions/<permissions-id>' \
-u alice:123456 \
-d '{
    "roles": [
        "aa97fe03-7980-45ac-9e50-b325749fd7e6"
    ]
}'

Actual behavior
The share update shows the successful result, the role is not assigned as the roles property is not listed in the response instead the response contains the available permissions actions.
{
<EMAIL_ADDRESS>[
        "libre.graph/driveItem/path/read",
        "libre.graph/driveItem/children/read",
        "libre.graph/driveItem/basic/read"
    ],
    "createdDateTime": "2024-12-13T12:11:31.544516667+05:45",
    "grantedToV2": {
        "user": {
<EMAIL_ADDRESS>"Member",
            "displayName": "Brian Murphy",
            "id": "1480417a-dbe1-4058-a511-99682915970c"
        }
    },
    "id": "d5727cf1-f2ea-4a4a-9725-0b97d9068c73:670bcf96-8fdb-4945-879b-3646dbb65f88:5fd78b77-4440-4cfa-be96-c5eff6d5816c",
    "invitation": {
        "invitedBy": {
            "user": {
<EMAIL_ADDRESS>"Member",
                "displayName": "Alice Hansen",
                "id": "670bcf96-8fdb-4945-879b-3646dbb65f88"
            }
        }
    }
}

Expected behavior
Not sure what should be the expected behavior. Is the current behavior valid or should the update fail?

This is expected behavior.

Closing this issue as the current behavior is the expected one.


Ability to hide Info and Warning Messages as a User Setting

currently all or nothing, you hide all info, or all warning messages, or both
hope to expand this later to allow the user to ignore specific types of info or warning messages, or even errors

Nevermind I'll handle the cleanup :) thanks again !

Thanks. I shouldn't have let that sneak through!


Initial filter ranges

Currently the filter initial state is hardcoded.
The filter should be automatically initialised according to the maximum ranges in the Jobdatabase. This requires a API to aquire min max values for all filter values.

The filter ranges should update according to the Cluster that is selected.

I got confused trying to amend to a previous commit, this issue was worked on in 094f9a7d75312996f04cdf7f4ddea8af71bc60ec (I originally wanted that to be two separate commits, sorry).
Leaving this issue open to quickly discuss something related: When the user selects a cluster, for now, the filters are changed to represent the full range of values for that cluster. This means prev. changes to settings like duration are thrown away. Would it maybe be better to clamp the values? Or leave them as they are even if they lie outside the range of values for that newly selected cluster?

Thats a good point. I would suggest to not throw the current settings away but only reset them if they are outside of the new cluster ranges and clamp them if this is the case.

Closed in 6345aaf9910779c25875f4787a5359474712b958.


Fixes #2835 Process Accept header MIME types in case-insensitive way

Use mime.ParseMediaType to parse the media types in Accept header in manifest request. Ignore the failed ones.
Signed-off-by: Yu Wang<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:yuwaMSFT2/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354572056
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Brawl Stars API

Hi! 😄
I deleted the fork I made earlier and was unable to make changes. This new PR is to correct what was requested in public-apis#1155.
Sorry and thank's.

Thanks for the PR, @matheusfelipeog!
Merging your PR now 🚀


fix: Correct output attribute mis-spelling

Description

Motivation and Context

Resolves #17

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 1.2.4 :tada:


refactor: is hovered renderers + change preview to dry-run

Changes

Show the context menu dots only on hover
Change Preview label to Dry-run

Screenshots

Checklist

[x] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

TBH it looks a little weird to me - but that's probably just because I'm so used to "Preview" :D

@CortNick would this change require any urgent updates to website (or any other) content?


perf: NetId is now 2 bytes instead of 4

NetId is now a ushort instead of uint.
That means the max amount of networked objects is 65K
Note NetId can now be recycled after a while.
Tx to MrGadget for the idea.
BREAKING CHANGE: NetId is now a ushort instead of uint

You can have more than 65K objects, so this might be too limited.
https://www.reddit.com/r/gamedev/comments/5vryia/unity_gamedevs_how_many_game_objects_can_you_load/

You can have more than 65K objects, so this might be too limited.
https://www.reddit.com/r/gamedev/comments/5vryia/unity_gamedevs_how_many_game_objects_can_you_load/


How can I add new buttons and images to the style editor panel ?

I want to add buttons and images to the places indicated in the picture. How can I do this?

You would need to create FormElements with the button and the image, then you would need to provide those to the forms in the options.
Maybe this can help:
https://github.com/dwilhelm89/Leaflet.StyleEditor/blob/945ac5a193545886aac2513dacd1f26999d9f3f8/src/StyleEditorWithLeafletDraw.html


Add release 8.10.0

Add downloadFrom fields for all multipart/form-data routes.
https://gotenberg.dev/docs/routes#download-from

Add password form field, allowing conversion of password-protected documents.
https://gotenberg.dev/docs/routes#page-properties-libreoffice

Only missing fixes for phpstan and then goot to go for me !


Add new (more flexible) main command to Base64 Extension

Description
Adds a new main command to the existing Base64 extension. I found the existing extension pretty inflexible when it comes to how to present the encoded / decoded data. Namely, the new index command supports the following:

Preview the encoded / decoded content directly inside the list view.
Preview the content you are encoding / decoding.
Automatically read from clipboard, by default.
Allow input override via the list search field (this is more seamless to me than using arguments).
Three actions: copy to clipboard, paste in active app, open URL (if the decoded content is a URL).
New preference: "default action" - allows users to configure which action gets executed when they press enter on the encode / decode list item.

I left the existing commands in place for backwards-compatibility.
I also elected to improve the existing extension rather than submitting a new one. I've seen a few other base64-related PRs pop up, only to be closed later because there are enough base64 extensions already in the store.
The main base64 extension has gone quite some time without some love with the new features available in the API, so I though I'd take a crack at it.
Screencast
https://user-images.githubusercontent.com/424093/204354746-c6c6e7c2-abf6-43bb-b0c4-c4e986c8e2ae.mov
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @sammarks 👋
Thanks for your contribution 💯
@DanielSinclair can you check this?

@pernielsentikaer do you have a policy on what happens if the original extension author doesn't respond to requests for a certain period of time?

Hi @sammarks. Looks fine to me! I hope Raycast can reevaluate how distribution/forking works; the namespace squatting and monorepo setup seems untenable as the platform has grown.

We are going to take some actions, it's a focus point for us to come up with a better solution 😊


[REFACTOR] Abstract the disk/lvol file operations in backupstore

What's the task? Please describe
This is a subtask of #6138
The backup store will serve the purpose of backing up and restoring both v1 and v2 volumes. File operations, such as seek, create and so on, for v1 volumes are conducted on sparse files. In contrast, disks files are represented as SPDK logical volumes. An abstraction for disk and logical volume (lvol) file operations is necessary.
Describe the sub-tasks

Additional context

@derekbit is there anything QA can test here? It seems backupstore refactored, so could run e2e tests related to backup & restore including system. WDYT?

Yes. I think e2e is enough.

Verified pass on longhorn master (longhorn-engine 014125,  backupstore 627369)
E2e pipeline did not observe outstanding issue related to backup after the backupstore refactored.

AMD64 build 745 : 3 failures
AMD64 upgrade build 678 : 3 failures
AMD64 2 stage upgrade build 377 : 5 failures
ARM64 build 692 : 5 failures
ARM64 upgrade build 684 : 3 failures
ARM64 2 stage upgrade build 370 : 6 failures

For the failures, most of them already recorded in https://github.com/longhorn/longhorn/issues/6659


Testing Issue

- Do you want to request a feature or report a bug?
- What is the current behavior?
- If the current behavior is a bug, please provide the steps to reproduce.
- What is the expected behavior?
- Please mention your node.js, NPM, Hugo and operating system version.

Just a test issue


patch: clear mentions of cloud projects

I would suggest updating everything to match the branding. So instead of Accelerate and Pulse it's Prisma Accelerate and Prisma Pulse. Otherwise, it looks good!

@mhessdev, thanks for the review 🙌 !
For your suggestion, I think it makes sense for me to handle that in a separate PR.

So instead of Accelerate and Pulse it's Prisma Accelerate and Prisma Pulse. Otherwise, it looks good!

There are plenty of mentions of Pulse and Accelerate. Doing a global search in Vscode I can see that there are:

Approx 163 mentions of Pulse in 19 files
Approx 370 mentions of Accelerate in 30 files.

Additionally, this PR is just intended to clear out the mentions of Cloud Projects, so I wanted to keep the changes specific to the issue title.
WDYT?


Fix: array list values are leaked on nested unnest operators

Which issue does this PR close?

Closes #10672 .
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Nice catch ! Thanks @duongcongtoai
Another simple way to reproduce it is
select unnest(column1) from (select * from (values([1,2,3]), ([4,5,6])) limit 1);

I'm not sure if this is a bug in arrow-rs or by design. It only slices the offset data of the ListArray, without slicing the child data.

I think current impl is correct, because the offset values after slicing is still offsetted based on original array. Else we have to do shifting for each offset elements like
Current buffers
            undearneath value: [1,?,3,?,5,6]
            nulls: [1,0,1,0,1,1]
            offset: [0,1,2,4,6]
            logical value: [1] [null] [3,null] [5,6]

Slice(2,2)
            logical values -> [3,null] [5,6]
            offset -> [2,4,6] << 2 = [0,2,4]
            unearneath_value.slice(2:) = [3,?,5,6]
            nulls.slice(2:) = [1,0,1,1]

I think current impl is correct, because the offset values after slicing is still offsetted based on original array. Else we have to do shifting for each offset elements like

I think the shifting operation should be done internally in arrow-rs if needed, as it depends on what the data in the values looks like. Moreover, we don't need to do shifting for FixedSizeListArray.
The current solution looks good to me.


Turbo 2.0: CircleCi exception

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

What package manager are you using / does the bug impact?
Yarn v2/v3/v4 (node_modules linker only)
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
turbo@npm:2.0.1
Describe the Bug
CircleCI will throw an exception in testing:
Oops! Turbo has crashed.

A report has been written to /tmp/report-031b50a3-6078-440d-b30e-ae1ab99c594c.toml

Please open an issue at https://github.com/vercel/turbo/issues/new/choose and include this file
Oops! Turbo has crashed.

A report has been written to /tmp/report-d7c3945b-76b5-4f9d-a3e3-bfe18a78ad37.toml

Please open an issue at https://github.com/vercel/turbo/issues/new/choose and include this file

Exited with code exit status 101

name = "turbo"
operating_system = "Ubuntu 22.04 (jammy) [64-bit]"
crate_version = "2.0.1"
explanation = """
file 'crates/turborepo-vt100/src/screen.rs' at line 878
"""
cause = "called `Option::unwrap()` on a `None` value"
method = "Panic"
backtrace = """

   0:   0x407e88 - <unresolved>
   1:  0x13273fe - <unresolved>
   2:  0x1306f99 - <unresolved>
   3:   0xefc176 - <unresolved>
   4:   0x9c7dc0 - <unresolved>
   5:   0x9c5cfd - <unresolved>
   6:   0x98e4db - <unresolved>"""

Expected Behavior
It succeeds
To Reproduce
Run CI
Additional context
No response

It seems to run from an interactive session fine: I SSH'd into the CircleCi box and ran yarn lint and everything seemed great.

This is odd, I need to do some testing to figure out what state the CircleCI box terminal is in for non-interactive sessions. It looks like there's a TTY setup even though it isn't a true terminal.
In the meantime you can add the env var TURBO_UI=false to disable the UI in CI and that should avoid the panic.

It seems this is a known bug/feature of CircleCI that they have a TTY session open e.g..
The turbo TUI output will not be helpful if not viewed in an actual terminal so I would suggest opting out of it so logs are useful. This is best done via the TURBO_UI=false environment flag, but can also be achieved by manually making turbo's stdout non-TTY: turbo lint | cat && test ${PIPESTATUS} -eq 0.
Keeping open as we shouldn't panic in this situation.

this workaround worked for me!
i just added it to my .circleci/config.yml step:
- run:
    name: Run TURBO lint
    command: yarn lint
    environment:
      TURBO_UI: "false"

We've now documented this workaround for the time being: https://turbo.build/repo/docs/guides/ci-vendors/circleci

Here is my report-<uuid>.toml file as requested:
circleci@7e33ff8c3102:/tmp$ cat /tmp/report-d8f38136-02f3-4045-b8e0-61ca6cb0ade4.toml
name = "turbo"
operating_system = "Ubuntu 22.04 (jammy) [64-bit]"
crate_version = "2.0.1"
explanation = """
file 'crates/turborepo-vt100/src/screen.rs' at line 878
"""
cause = "called `Option::unwrap()` on a `None` value"
method = "Panic"
backtrace = """

   0:   0x407e88 - <unresolved>
   1:  0x13273fe - <unresolved>
   2:  0x1306f99 - <unresolved>
   3:   0xefc176 - <unresolved>
   4:   0x9c7dc0 - <unresolved>
   5:   0x9c5cfd - <unresolved>
   6:   0x98e4db - <unresolved>"""

This also happens in terminals like Emacs eshell.

I believe this has been fixed with https://github.com/vercel/turbo/pull/8457 which was released as part of 2.0.4. If you encounter this with 2.0.4+ please reopen along with your terminal emulator and any other relevant information.


Extend session life

Kemal default is one hour.
But if we extend it to weeks/months, we'll have to keep track of last login, so we can enforce a reauthentication at intervals.
As this is a new property on the user, it makes sense to push after #3.

On further inspection: Kemal doesn't just set the cookie lifetime to the session timeout, but the engine gc also removes old sessions, so just setting timeout should suffice.

Fixed in 1.3.0 release.


fetchAccount() throws "TypeError: Cannot destructure property 'publicKey' of 'account' as it is null." error on accounts not included into ledger

Calling fetchAccount() for the account not included in the ledger with o1js 0.18.0 and one of the following devnet endpoints:
https://proxy.devnet.minaexplorer.com/graphql
https://api.minascan.io/node/devnet/v1/graphql

throws the following error:
TypeError: Cannot destructure property 'publicKey' of 'account' as it is null.

      at parseFetchedAccount (node_modules/o1js/dist/node/index.cjs:19925:11)
      at fetchAccountInternal (node_modules/o1js/dist/node/index.cjs:20270:17)
      at fetchAccount (node_modules/o1js/dist/node/index.cjs:20251:10)

To whoever from us is fixing this: It means that the node returns something which we don't recognize as an error, and try to parse as an account.


Give user feedback when container healthcheck fails.

Is your feature request related to a problem? Please describe.
When your custom nginx configuration is broken (e.g. you forgot to add /fpmstatus location to the nginx-site.conf, then ddev will fail to start without any meaningful information.
Also ddev logs is not helpful in this case.
Describe the solution you'd like
I would like to get a clear message like "Can not connect to nginx on http://..../fpmstatus", please check if your nginx-site.conf contains a /fpmstatus endpotint.

Definitely a good point. Related Reorganize nginx configs to share most elements #849, a custom nginx config really shouldn't have to do any of this.
And another annoyance: Because of apache change in (hopefully) next release, the /fpmstatus endpoint will probably change to /phpstatus. It's possible we can do something meaningful in there to fix that. AFAIK docker-compose doesn't inform us very well of what's going on. But maybe we can find something. I'd sure love to see this fixed.
BTW, could you mention what you're still having to do for custom nginx config? It would help to give a gist to the actual config that broke you as well.

Hi @rfay,
I did some tests, and after adding error message to stderr in the healthcheck.sh, I can see it when calling docker inspect in the log section. This not ideal (as not everybody would check inspect), but at last gives you some hints.

Excellent, thanks!

I use and recommend
Web container: docker inspect --format "{{json .State.Health }}" ddev-<project>-web | jq (for web container failure)
ddev-router: docker inspect --format "{{json .State.Health }}" ddev-router


Cannot listen to kebab-case events

Version
3.0.2
Reproduction link
https://codesandbox.io/s/laughing-merkle-esils?file=/src/components/HelloWorld.vue
Steps to reproduce

Listen to a kebab-case event (@my-event="listener")
Emit the event (emit("my-event"))
The event is not received

What is expected?
Kebab-case events should be listenable and preferred, as per the docs
What is actually happening?
My understanding is that #2278 normalizes all event listeners to pascal-casing, making it impossible to listen to kebab-case events.
In fact, binding with @myEvent="listener" works with both emit("my-event") and emit("myEvent").

I ran into this bug because of an issue posted to my library, in which my kebab-case listeners were not being triggered.

https://github.com/vuejs/vue-next/issues/2429 already reported this, my bad


Fix only the output not the input

Hey, great plugin, it reads the eslint config correctly.
However I'm using it with the fix option, and weirdly enough it also fixes the input files in the src/ folder.
Is there any way I can tell it to modify only the bundle outputted by rollup?

ESLint assumes you want to lint and fix things in your source code. Meaning that (as of now) there is no way to circumvent this behavior, as this gets handled by ESLint itself. This also isn't part of any integration, be it gulp-eslint, eslint-loader, or anything else, and probably won't be until there is an elegant way to achieve modifying the output but not the source, via the Node.js API.


chore(docs): add missing CRDs' documentation from docs.konghq.com's CRD reference

What this PR does / why we need it:
It moves pieces of the documentation that were present in the https://docs.konghq.com/kubernetes-ingress-controller/latest/references/custom-resources/ article. The article is going to be replaced with the generated api-reference.md.
Draft PR on the docs.konghq.com side: https://github.com/Kong/docs.konghq.com/pull/4813
Which issue this PR fixes:
Part of #3019.

Special notes for your reviewer:
After further investigation of the documentation on docs.konghq.com, I've decided to move the missing pieces of documentation to the code and effectively include it in the generated reference.
The old article  is going to be removed and the generated API reference will replace it.
Pieces of the old document that were relevant to be included in the reference were moved here, while the part of the doc explaining usage of the CRDs is already widely covered in Using Custom Resources guides (e.g. https://docs.konghq.com/kubernetes-ingress-controller/latest/guides/using-kongplugin-resource/).
PR Readiness Checklist:
Complete these before marking the PR as ready to review:
~- [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR~

While I really like this idea, what about the "examples" like https://docs.konghq.com/kubernetes-ingress-controller/latest/references/custom-resources/#applying-a-plugin-to-a-service ? Do we have an idea how to approach this? Move them or create a separate section for them?

While I really like this idea, what about the "examples" like https://docs.konghq.com/kubernetes-ingress-controller/latest/references/custom-resources/#applying-a-plugin-to-a-service ? Do we have an idea how to approach this? Move them or create a separate section for them?

As I mentioned in the notes, IMO they're already covered in the usage guides. E.g. the applying a plugin to a service is already covered in https://docs.konghq.com/kubernetes-ingress-controller/latest/guides/using-kongplugin-resource/#configuring-plugins-on-service-resource.


Feat/align init fragments

Summary

Test Plan

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

!canary


disable security

Hi,
i i have fallen in love with your design but i am to newbie to install it :)
is there a simple way to just get the theming part with out the Security addons ?
i dont whant to play around with my bootloader or encrypten its a PC if someone breaks into my apartment and steals it i got other worrys :laughing:
(i know its not that simple, but i am just starting out with nix and its abit overwhelming)
Thank you for your awesome work on the screenshots that design looks freaking awesome!
Best Regards

Hello again :)
i made it work, one thing bugs out pulseaudio if it try to open up the bars crash
do u got any advice what there could be wrong ?
thank u
best regards


Receiving error http://localhost:6420/#error=invalid_request&error_description=AADB2C90205 when using App Reg Preview Blade

When using the Azure B2C App Registration ( Preview ) blade Application to create my Web API Application, I receive the following error message:
http://localhost:6420/#error=invalid_request&error_description=AADB2C90205: This application does not have sufficient permissions against this web resource to perform the operation
I've completed all the consent per the documentation, but cannot get this to work.  Is there something that I am missing or that is not in the documentation?  Please let me know.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: caf9a656-6854-a501-acbf-1ca608406021
Version Independent ID: 87ec5552-fdc1-b266-69da-0433f2a8189c
Content: Tutorial: Protect a Node.js web API using Azure AD B2C and grant access to a single-page application (SPA) - Azure AD B2C
Content Source: articles/active-directory-b2c/tutorial-single-page-app-webapi.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@mmushatt Thanks for your feedback! We will investigate and update as appropriate.

@mmushatt I have followed the steps mentioned in the document and I am able to see correct results.

You may have missed something in the configuration. Please can you make sure that you have added permissions correctly in web API and configured apiConfig.js correctly -
.
Check for the Web API scopes  -

Also, validate if you have granted Admin consent for the API in web app.

Good Day,
Thank you for your assistance.  I was able to get this to work when I ensured that my Web API and Web App were both under the Application ( Preview ) blade.  I will keep trying with my Web App under the B2C Applications blade.  I do have a quick question that I’ve not been able to get working.  What if I want to use the Microsoft Graph API resource in my App, I cannot get this to work.
Thank you in advance,
~ Michael Cedric Mushatt
From: SaurabhSharma-MSFT<EMAIL_ADDRESS>Sent: Friday, May 01, 2020 7:26 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Michael Mushatt<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Receiving error http://localhost:6420/#error=invalid_request&error_description=AADB2C90205 when using App Reg Preview Blade (#53530)
@mmushatthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmmushatt&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531150007&sdata=0Per%2BpCZrvtcV0FySSRJeX6%2Bd1UDKWT7y9wn0BA7MNk%3D&reserved=0 I have followed the steps mentioned in the document and I am able to see correct results.
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F38112130%2F80848075-ce59d280-8bc6-11ea-8d86-b2aacf1c7ef8.png&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531159964&sdata=6Ev4nBS3kwCtR17%2B7iR7w0U0cUw1b3c5LByqiaKs%2BXk%3D&reserved=0
You may have missed something in the configuration. Please can you make sure that you have added permissions correctly in web API and configured apiConfig.js correctly -
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F38112130%2F80848215-6657bc00-8bc7-11ea-95c0-edab8270b419.png&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531159964&sdata=0RpO%2BdpFLXIqQdd56Cu7sANWCcGFS9ibX7pXD25TmDI%3D&reserved=0.
Check for the Web API scopes -
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F38112130%2F80848270-9010e300-8bc7-11ea-8260-cfbbdab2c7fe.png&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531169919&sdata=ZCGNKxuSXUBU%2BeJge9mVDO5s%2BhGAwHm3nY3v%2BMhxJwk%3D&reserved=0
Also, validate if you have granted Admin consent for the API in web app.
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F38112130%2F80848480-4d9bd600-8bc8-11ea-9cbc-c2c40e9704ef.png&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531169919&sdata=VpD8ND5578Zrqrqnc0WmfPVdUJDzqHm%2B0Sz0ZBoa8ck%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F53530%23issuecomment-622609340&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531169919&sdata=Tqgyo9AoK64SsxxxkuB2aKiTKsTY3QWwRjLRTW091qQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADFAN27DTXYXH4NBZM3554LRPNK7ZANCNFSM4MTFO5KA&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531179876&sdata=7C2%2B24En%2FtgyX4NWEZD7FTmAX4aRcsrPoMronXiTVYE%3D&reserved=0.

Good Day,
I was able to get this to work with the Web App under either of the blades.  Thank you.
Still would like to know how to get to the Microsoft Graph API resource.  I have two customers having this very issue.
~ Michael Cedric Mushatt
From: Michael Mushatt
Sent: Monday, May 04, 2020 5:22 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Mention<EMAIL_ADDRESS>Subject: RE: [MicrosoftDocs/azure-docs] Receiving error http://localhost:6420/#error=invalid_request&error_description=AADB2C90205 when using App Reg Preview Blade (#53530)
Good Day,
Thank you for your assistance.  I was able to get this to work when I ensured that my Web API and Web App were both under the Application ( Preview ) blade.  I will keep trying with my Web App under the B2C Applications blade.  I do have a quick question that I’ve not been able to get working.  What if I want to use the Microsoft Graph API resource in my App, I cannot get this to work.
Thank you in advance,
~ Michael Cedric Mushatt
From: SaurabhSharma-MSFT <notifications<EMAIL_ADDRESS>Sent: Friday, May 01, 2020 7:26 PM
To: MicrosoftDocs/azure-docs <azure-docs<EMAIL_ADDRESS>Cc: Michael Mushatt <mmushatt<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Receiving error http://localhost:6420/#error=invalid_request&error_description=AADB2C90205 when using App Reg Preview Blade (#53530)
@mmushatthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmmushatt&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531150007&sdata=0Per%2BpCZrvtcV0FySSRJeX6%2Bd1UDKWT7y9wn0BA7MNk%3D&reserved=0 I have followed the steps mentioned in the document and I am able to see correct results.
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F38112130%2F80848075-ce59d280-8bc6-11ea-8d86-b2aacf1c7ef8.png&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531159964&sdata=6Ev4nBS3kwCtR17%2B7iR7w0U0cUw1b3c5LByqiaKs%2BXk%3D&reserved=0
You may have missed something in the configuration. Please can you make sure that you have added permissions correctly in web API and configured apiConfig.js correctly -
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F38112130%2F80848215-6657bc00-8bc7-11ea-95c0-edab8270b419.png&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531159964&sdata=0RpO%2BdpFLXIqQdd56Cu7sANWCcGFS9ibX7pXD25TmDI%3D&reserved=0.
Check for the Web API scopes -
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F38112130%2F80848270-9010e300-8bc7-11ea-8260-cfbbdab2c7fe.png&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531169919&sdata=ZCGNKxuSXUBU%2BeJge9mVDO5s%2BhGAwHm3nY3v%2BMhxJwk%3D&reserved=0
Also, validate if you have granted Admin consent for the API in web app.
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F38112130%2F80848480-4d9bd600-8bc8-11ea-9cbc-c2c40e9704ef.png&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531169919&sdata=VpD8ND5578Zrqrqnc0WmfPVdUJDzqHm%2B0Sz0ZBoa8ck%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F53530%23issuecomment-622609340&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531169919&sdata=Tqgyo9AoK64SsxxxkuB2aKiTKsTY3QWwRjLRTW091qQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADFAN27DTXYXH4NBZM3554LRPNK7ZANCNFSM4MTFO5KA&data=02|01|mmushatt%40microsoft.com|ce2d5c60128b4ee8d7ff08d7ee26fc5e|72f988bf86f141af91ab2d7cd011db47|1|0|637239723531179876&sdata=7C2%2B24En%2FtgyX4NWEZD7FTmAX4aRcsrPoMronXiTVYE%3D&reserved=0.

@mmushatt Good to hear that you are able to proceed further.
For Microsoft Graph API, the process of assigning permissions are similar and you need to go to "API permissions" of web app and select "Microsoft Graph" from the blade.
.
Once selected you can then assign required permissions (like Directory.Read.All) to your web application.

Also, there are list of operations supported on Azure AD B2C for users, identity providers, user flows, custom policies, and policy keys which is listed over here.
Are you getting any error while using Microsoft Graph with B2C ?

@mmushatt We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


k3s: document upkeep process

k3s: document upkeep process
The user guidelines has to be improved too. But this is a start.
Let me know of corrections, improvements and objections.
CC K3s maintainers: @euank @yajo @Mic92

How should backport to stable work?
Currently it is broken. But after next release, it will be in sync again. So back-porting might be important.
I don't use stable myself. I continuously pin unstable. (Make unstable stable.) So I don't get to experience the stable issues.

@euank I need your feedback here. Release is happening. And I'm not sure I have correctly documented the process.
It seems I wrongly understood the removal of K3s versions happening after release. And not before release. What should I do?

It seems to me like the process you outlined here is very good 🤔

Thanks for writing this up @superherointj, appreciated!
Apologies for not keeping up with nixpkgs stuff for this release, your help on that is also very much appreciated!
You're right that the intention originally was to remove k3s versions from the next version's release branch, but to leave all supported ones on unstable.
I do feel like deleting all but the newest version on unstable periodically would be really convenient for those of us who only use unstable, but I think we're stuck with following something like I wrote before if we want to allow people to follow k8s's upstream upgrade recommendations, and also stick to nixos stable releases.
I think leaving versions in unstable is also required for backporting patches to older versions while they're supported, i.e. so we can backport 1.28 patches to 23.11 for the month-or-so after 24.05 when it's still supported. I think that's also necessary if we want people to be able to follow upstream k8s's upgrade recommendations (1 version at a time, always using the latest patch version iiuc)
Based on the timeline in https://github.com/NixOS/nixpkgs/issues/303285, it does sound like we have time to sort this out though hopefully!
If we're following what I wrote before, the required next actions would be:

[ ] Backport k3s 1.28 to release-23.11 (so people can upgrade safely from release-23.11 to 1.29 in release-24.05)
[ ] As soon as release-24.05 branches off, delete all but k3s 1.29 from it
[ ] Update the maintainer document a bit more to make this all clearer

Again, apologies for being busy and not putting as much attention into this as I should!
I can open a PR updating some of this documentation in the next couple days as a means to discuss it further, if that sounds good; I'm also happy to change my mind on any of this if we feel like taking some other approach is more pragmatic. The "trimming versions after we branch off" really is a tight timing window, and seems fraught, so I'd love an alternative to that :sweat_smile:
What do y'all think?
Do the above steps make sense for this release still, or do we have a better option to pursue?

As our time/resources are limited. And there are few people doing upkeep, we should strive to keep it realistic.
I suggest a simple middle way solution:

To continuously remove all and only K3s unstable versions that exist in stable.
To try, but not require, to back-port PRs from unstable to stable.
Whoever is interested in doing upkeep for stable can catch up with back-port of patches and newer versions.

So we don't have to do special upkeep for stable. I want to avoid the matrix/doubling of versions in stable, it's more than double the work as patches don't merge nicely.
This would mean, this release would keep k3s_1_28, but have all other previous versions removed from unstable.

@euank Thanks for correcting me. As always, glad to have you here!
I've reached a new understanding:
As contributors are limited. To be realistic. The criteria should not rely on individual contributors doing timely work.
Basically:

The pace of removal should match the pace of back-porting.
After release, all versions from unstable that exist in stable should be removed.

Currently, for example, would mean:

k3s_1_27 would be removed because it exists in stable.
k3s_1_28 would be kept because it doesn't exist in stable. Unless, k3s_1_28 gets ported to stable, then, it should be removed.

This way special upkeep for stable is optional (desirable, but not mandatory).
From unstable, back-porting should be triggered as usual. On failure, the maintainer gets to decide what to do.
Back-porting to stable speeds up package removal. With increased back-porting contributions, version removal will speed up naturally. It seems, this criteria naturally works for all situations.
I'm against forcing an external artificial deadline for packages, while not having the manpower to keep up with such level of contributions. As the package gets used more, new contributors may contribute and then the quality/speed of upkeep will improve naturally. We can't force better output than this. I honestly cannot keep up with much more than what I do already. If some package goes EOL, we have to be realistic. It is just debt that doesn't get solved by a deadline. Polar thinking is bad.
On agreement, I may open a PR fixing documentation with this new understanding.

I agree reducing maintainership load for k3s is important, and minimizing the number of k3s versions we support is good!
I also think what you've proposed means there's always a supported k3s upgrade path, though it does force people on unstable to upgrade more aggressively.
I think the main reason we ended up where we are in terms of versions was based on discussion in this issue: https://github.com/NixOS/nixpkgs/pull/224483
@yajo, since you had some thoughts then, just to double check, the above proposal works for you right?
I'm okay with the proposal personally, I just use unstable (and can pluck versions off release branches if I need to).
It doesn't feel ideal if we had unlimited manpower, but we don't, so it does seem like it might be a good compromise.
Thanks for writing it up @superherointj, happy to review a docs PR and help push towards that setup if @yajo's also onboard!

it does force people on unstable to upgrade more aggressively.

To avoid coupling system upgrade and K3s upgrade, it would be necessary to keep last stable version in unstable. This would avoid breaking K3s instantly on upgrades, and the user could migrate K3s version at his own timing, in a discrete manner. As Kubernetes has differences in application, such as manifests version, CRDs, adds-ons having to catch up to Kubernetes version. This makes sense. So, I agree, that last proposal was too aggressive to unstable (could affect applications not ready for lastest version) and stable (coupled upgrade). That kind of hasty upgrade was in trying to comply with previous nixpkgs release manager demands. Phew...
So the compromise of the compromise, would be to keep at least one/the last version of stable in unstable. Then, stable users can upgrade NixOS without going into a instant K3s upgrade crisis.
Thoughts?

I'm happy with that proposal, yup!
To be sure I understand the proposal, another way to say it is:

We try to keep the latest version of k3s up to date on unstable
We try to backport new versions of k3s to the stable release
If the newest version on the stable release is different from unstable, we also keep that "latest stable version" on unstable.

This leads to unstable having either 1 or 2 k3s versions, and stable having all versions between the version on unstable when it was cut, up to the current version on unstable, or one version before.
Specifically, that might lead to things like (using hypothetical future versions) "Stable has 1.28 (version when it was cut) + 1.29 + 1.30, unstable has just 1.30, or unstable has 1.30 + 1.31".
Does that sound accurate?
If I'm summarizing what you're saying correctly, that sounds good to me!

First, I'm sorry for being repetitive and stating obvious things. Communication is hard. I'm repeating some understandings for emphasis and checking that our understanding is shared. I hope it doesn't get too annoying, but I couldn't do much better for the moment.

1. We try to keep the latest version of k3s up to date on unstable

Yes.

2. We try to backport new versions of k3s to the stable release

Yes, stable will receive back-ports whenever possible. (All that merge fine for sure.)
Manual work for back-porting would be optional and executed by interested contributors.

3. If the newest version on the stable release is different from unstable, we also keep that "latest stable version" on unstable.

Yes, unstable would keep K3s last latest-stable version.

This leads to unstable having either 1 or 2 k3s versions,

Yes. Whenever latest-stable version would equate to unstable version, unstable would have a single K3s version.

and stable having all versions between the version on unstable when it was cut,

Yes.

up to the current version on unstable, or one version before.

Back-porting enables version removal from unstable at next release.
A release (without extra backports) automatically defines the slowest version removal pace.
Optionally, any newer version could be back-ported to stable, if there are interested contributors. But it's not guaranteed. So, the stable set of versions may lag in reference to unstable. This is not a problem.
The reference frame I have been using to think is unstable (and not stable, as you did):
As all changes are done to unstable, stable is a past mirror image of unstable.
The K3s package removal happens only at unstable. And stable inherits that from unstable at release.
So, unstable only needs to keep the latest-stable version for system upgrades happening smoothly.
The many versions stable has is not important for the upgrade process. At unstable, we look backwards to stable to check the latest version stable supports, and we keep just that.

Specifically, that might lead to things like (using hypothetical future versions) "Stable has 1.28 (version when it was cut) + 1.29 + 1.30, unstable has just 1.30, or unstable has 1.30 + 1.31".

I was thinking from unstable reference and you were thinking stable reference, a reversed frame of reference.

Unstable will always have latest-stable version.
Stable will have the versions from when unstable release happened + (optional) backports.

Considering latest-unstable as 1.31, looking back to stable to check:

If latest-stable is 1.31, unstable keeps 1.31 only.
If latest-stable is 1.30, unstable keeps 1.30+1.31.
If latest-stable is 1.29, unstable keeps 1.29+1.30+1.31.
If latest-stable is 1.28, unstable keeps 1.28+1.29+1.30+1.31.

So, yeah, the way reduce versions in unstable is to do back-porting. Then, it's desirable to do back-porting to limit the versions in unstable. On passive upkeep, the automatic release pace of removal happens.

Does that sound accurate?

I think, we are in sync. If not, we'll be now.

If I'm summarizing what you're saying correctly, that sounds good to me!

I'll prepare the documentation. Then, we can iterate in the PR.
Other considerations:

We should recommend users to continuously upgrade K3s. (To be at last available K3s version.)

It's becoming a bit complex to understand for me, I guess It'll be easier on the PR.
However, to put it simple, I a gree with this sentence:

To avoid coupling system upgrade and K3s upgrade, it would be necessary to keep last stable version in unstable

Reasoning:

A system upgrade is hard enough.
If something breaks, it'll be easier to know if it's k3s itself or the rest of your NixOS.

So, unstable and stable should share at least one minor k3s version.

However, to put it simple, unstable and stable should share at least one minor k3s version.

Yes. Let's sum up with that.


AWS Tags Support

It should be possible to apply tags to AWS resources which support them and we would like to have a uniform API for tags across the AWS construct library

Coming from #458 I agree that a generic tag implementation seems like the right idea.
Before I spend too much time proposing, does the group have strong opinions on the two high level concepts:

Implement tagg-able functionality on cdk.Resource

All resources will get a set of functions addTag, removeTag, getTags, hasTag, getTag, isTaggable
The functions would respond correctly if the props type has a field called tags, if the props does not have field called tags all of the methods would raise and isTaggable returns false
This means it's not hooked on constructs which implies our custom integrations later have to design and deal with their own tag concepts, however we could still define an interface to help them
The interface to the consumer would be cdk.Tag or {key: string, value: string} while the array would be backed with cdk.Token[] for the lazy eval

Use a mixin design pattern

Concept is well designed in Scala with Traits and Ruby, Typescript has some patterns; so first concern is how portable this is across the core languages?
Likely could hook cdk.Resource still, but I wonder if Construct is better?
Same methods as above except we would use a constructor style mixin

I'm much less certain about the pitfalls in option 2, but these are the first front runners for a cross cutting implementation in my mind. I am still new to typescript and if there is a better pattern for this cross-cutting implementation throw some links my way and I'll read up. If we think one of these is a good starting point, I can dig a little deeper and create some code to prototype.

Ok - big issue with option 1

Implement tagg-able functionality on cdk.Resource
All resources will get a set of functions addTag, removeTag, getTags, hasTag, getTag, isTaggable
The functions would respond correctly if the props type has a field called tags, if the props does not have field called tags all of the methods would raise and isTaggable returns false
This means it's not hooked on constructs which implies our custom integrations later have to design and deal with their own tag concepts, however we could still define an interface to help them
The interface to the consumer would be cdk.Tag or {key: string, value: string} while the array would be backed with cdk.Token[] for the lazy eval

Things like VpcSubnet <- VpcSubnetRef <- Construct ... so Resource has not relationship to VpcSubnet meaning this can't be attached to Resource.

In general, the CDK prefers composition over inheritance. So the rule of thumb is that constructs almost always directly extend the Construct class. To represent common behavior we use interfaces and sometimes utility classes.
So for example, you might envision something like:
interface ITaggable {
  tags: Tags
}

And then,
class VpcSubnet extends Construct implements ITaggable {
  constructor(...) {
    const resource = new cloudformation.VpcSubnetResource(this, 'Resource', ...);
    this.tags = new Tags(resource); // or some other way to let the Tags class manage tags for the resource
  }
}

`Resource`, specifically, is used as the base class for the generated CloudFormation resources (the classes under the `cloudformation` namespace in each library), and should not be "exposed" in the AWS Construct Library. It is very low-level and mostly deals with serializing CloudFormation. We should probably rename it to `CloudFormationResource`.

Can we first list some use cases? I'm not entirely sure what users will expect from this functionality...

@rix0rrr, you are right.
Here's an attempt:

It should be possible to specify tags when taggable constructs are defined (in "props").
It should be possible to add/modify/remove tags for taggable constructs.
Question: should tags should be recursive or maybe optionally recursive? If I add a tag to a construct which transitively includes multiple taggable resources in it, then would users expect that all the resources within this tree are tagged with the same set tag?

When aspects will be available, it should be possible to define aspects (#282) which will tag resources throughout a stack or a part of the stack. There is nothing special to do here in order to support this, but just calling it out.

I see two tagging related gaps

As a user, I want to be able to specify tags for a stack that flow down to all sub resources (note: this functionality is provided by CloudFormation but I don’t think it’s exposed in CDK).

As a user, I want things created to have meaningful names in the AWS console. Often unless you manually specify a Name tag this won’t happen. With CDK, users specify a name for each resource, so CDK could automatically create a Name tag based on StackName+ResourceName (unless overridden)

Question: should tags should be recursive or maybe optionally recursive? If I add a tag to a construct which transitively includes multiple taggable resources in it, then would users expect that all the resources within this tree are tagged with the same set tag?

I think tag propagation should be an option for each tag with a default=true. This matches other areas of the platform (such as auto scaling group tag propagation).

Okay, but there was also some Kubernetes-related use case right? That's how this started.
My question is not "how does the CDK enable tags", my question is "what do people use tags for".

EKS uses it for some purpose?
Cost queries
Presenting pretty names in the console (is that universally supported and distinct from the PhysicalName of a resource?)
...

👍 for propagate=true by default. This will allow implementing the stack-wide tagging by simply adding a tag at the stack level.
A note about a default "name" tag: I think this is something we will be able to implement using aspects once we have a common tagging interface. The aspect will simply traverse the construct tree and will automatically assign a "Name" tag to all taggable constructs. I would argue that the default "Name" should be the construct's path (which is unique within the stack) and not the construct's id (which is only locally unique within it's parent construct).

EKS has special tags that denote a VPC as an EKS VPC I believe this is to enable the communication back to the Master nodes not in the VPC and managed by AWS. I think there a few layers of security on the subnet besides tags, but without tags you can't use EKS.

Question: should tags should be recursive or maybe optionally recursive? If I add a tag to a construct which transitively includes multiple taggable resources in it, then would users expect that all the resources within this tree are tagged with the same set tag?

This is where my question was really going. In order to do this I need to make Construct aware of Resource. Today this is implied by the author of the construct, but there is actually no member or class level relationship. If Construct had private resources: Resource[] then Resource has properties and we could check if tags were supported. However, I didn't know if Resource and Construct were intentionally separated so that non-AWS resources could be added later?
I think we are in the right discussion, but if I sound way off the mark let me know. There is plenty of context I could be missing.

I don’t think Construct needs to be aware of Resource in order to implement tag propagation. As mentioned above, Resource is only used as a base class for generated CloudFormation resources, and this is about tagging support at the AWS Construct Library layer, which a rich, object-oriented framework.
AWS Constructs that support tagging should implement an interface ITaggable and then one can iterate on children via and identify that a child is taggble via duck-typing (e.g ”tags” in child).
I do realize there might be missing some design/architectural context, and happy to elaborate as needed.

I don’t think Construct needs to be aware of Resource in order to implement tag propagation. As mentioned above, Resource is only used as a base class for generated CloudFormation resources, and this is about tagging support at the AWS Construct Library layer, which a rich, object-oriented framework.

I think this might be my point of confusion. Construct tagging does not alone get me to Tags on AWS Resources does it? The Construct has to properly pass those tags to the Resource it creates? That's the part I added for #458? Without putting the tags into the ResourceProps.properties that support tags, how do I actually get the tags on my resources (e.g. for cost allocation or EKS)? What are the benefits and use cases of only tagging at the AWS Construct Library layer instead of the resulting AWS Resource?

@moofish32 I think I understand where the confusion is coming from. When AWS Constructs that support tags defines the inner CloudFormation Resource, they will have to let the "tag manager" assign tags.
Let's speak in code 😉
interface ITaggable {
  tags: Tags
};

// tag manager
class Tags {
  private tags: { [key: string]: string } = { };

  constructor(readonly parent: Construct, initialTags?: { [key: string]: string }) {

  }

  toJson() {
    return Object.keys(this.tags).map(key => ({ key, value: this.tags[key] });
  }

  setTag(key: string, value: string, propagate = true) {
    this.tags[key] = value;
    if (propagate) {
      applyTagToChildren(this.parent);
    }

    function applyTagToChildren(construct: Construct) {
      for (const child of construct.children) {
        if ('tags' in child) {
          // child implements ITaggable (duck-typing)
          child.tags.setTag(key, value);
        }

        applyTagToChildren(child); // recurse
      }
    }

  }
}

// s3 bucket
interface BucketProps {
  // ...
  tags?: { [key: string]: string }
}

class Bucket extends Construct implements ITaggable {
  constructor(...) {
    const tags = new Tags(this, props.tags);
    new cloudformation.BucketResource(this, 'Resource', {
      // ..
      tags: new Token(() => tags.toJson()) // render tags for this resource during synthesis
    });
  }
}

@moofish32  edited my comment above after reading your notes again...

💡 the moment where academically I can describe composition over inheritance, turns out to have occurred much sooner than I could apply it. This was my confusion. I was trying to figure out how to put the TagManager trait on either Resource or Construct so the developer didn't have to manage any of it. I see this composition pattern fits much more cleanly in as-built CDK lib. Thanks for taking the time to connect the theory and practice.


Updating Docker flow and instructions

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   35.04%   35.04%
=======================================
  Files          29       29
  Lines         799      799
  Branches       34       34
=======================================
  Hits          280      280
  Misses        519      519

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f307e3f...9b6dbaa. Read the comment docs.


[PartEditor] input for find operators

This will add input element for find operators by name and code.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

for #923, from #942


feat: add finally method on EitherAsync

Fixes #41
Hi @nythrox, I love this library and I am using it in a lot of projects. I really need the feature added in the PR for cleaning up resources like (closing DB connection or fs handle). Let me know what I can do to make sure this gets merged as soon as possible. Thanks

Cool! Thxs


SDK hangs when re-enabling SVO2 recording too frequent

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues.
[X] This issue is not a question, feature request, or anything other than a bug report directly related to this project.

Description
I've been using the SVO2 recording these days and it works flawlessly to produce SVO2 files until I try to create multiple SVO2 files by calling the enable_recording() and disable_recording(). Adding logs messages found that the execution hanged inside the disable_recording() API.  And it seems to happen faster if we re-enabling the recorder faster.
Steps to Reproduce

run the provided python script to open the zed camera and start recording e.g. "./SVOTest.pt ${PATH_TO_SVO2_FILE}"

import sys
import pyzed.sl as sl
import time
import os

# Create a ZED camera object
zed = sl.Camera()
zed.open()
# Enable recording with the filename specified in argument
output_path = sys.argv[1]
recordingParameters = sl.RecordingParameters()
recordingParameters.compression_mode = sl.SVO_COMPRESSION_MODE.H264
recordingParameters.video_filename = output_path
err = zed.enable_recording(recordingParameters)

frame_counter = 0
zed.enable_recording(recordingParameters)

while True:
    # Each new frame is added to the SVO file
    print("Before Grab")
    if (zed.grab() == sl.ERROR_CODE.SUCCESS):
        print("Grabbed")
        time.sleep(0.1)
        frame_counter += 1

        if frame_counter == 3:
            print("Disabling recording ......")
            zed.disable_recording()
            print("Disabled recording ......")

            # Reset frame counter
            frame_counter = 0

            print("Enabling SVO recorder")
            zed.enable_recording(recordingParameters)
    print("Failed to grab")

Expected Result
The SVO recorder should continue to write frame to the SVO2 file
Actual Result
Hanged when calling  disable_recording() with if running the provided codes:
ZED Camera model
ZED2i
Environment
aarch64
SDK 4.1.3
Recorder: SVO2

Anything else?
No response

I've managed to reproduce it in C++ library too.

Looks like it's been fixed. Closing the issue since I can not reproduce it with SDK 4.1.4.


Fix and extend push webhook documentation.

Why:
I implemented a webhook to handle pushes but the payload was not the same as the docs. I found the commits had an id attribute rather than an sha one as per the docs.

What's being changed:

Check off the following:

[ ] All of the tests are passing.
[ ] I have reviewed my changes in staging.
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

Thanks so much for opening a PR @coling! I'll get this triaged for review ⚡


Fix cell set bugs

Fixes bug reported by @ivababukova  on slack plus two others

Background

Change List

Only set additionalObsSets in coordination space when upgrade was necessary to prevent infinite loop.

Introduced in https://github.com/vitessce/vitessce/pull/1529

Fix bug causing cell set hierarchy created via Create hierarchy button to contain the string undefined (e.g., My hierarchy 1undefined)
Fix bug in CellSetSizesPlotSubscriber causing page to crash when no obsSets view is present (due to expectation of initialized obsSetSelection and obsSetExpansion coordination values).

Checklist

[ ] Ensure PR works with all demos on the dev.vitessce.io homepage
[ ] Open (draft) PR's into vitessce-python and vitessce-r if this is a release PR
[ ] Documentation added or updated

I think it has to do with AJV being a "validator" vs Zod being a "parser"
If AJV simply validates then it can return the same object (or throw an error). While I think the Zod "parsing" model is more likely to result in a new object with implications for equality checks downstream.

Zod is not the fastest (https://moltar.github.io/typescript-runtime-type-benchmarks/ https://github.com/colinhacks/zod/issues/205) but i do not think it is a major concern since the purpose is to use Zod at the boundary between the user and the system to parse untrusted user input.
For Vitessce, this is primarily the View Config JSON object, plus the cell set manager "import CSV/JSON" buttons.
We make more assumptions about data validity for the big-data parts of vitessce like AnnData and imaging loaders. Considering this, plus the fact that it is not JSON data, plus the zod performance characteristics, i do not think it would make sense to use in those places

Ok I was just doing release testing and didn't notice any performance knock e.g., with debug=true on.  https://github.com/vitessce/vitessce/pull/1552/files#diff-6b2ae5efdd37c0a36a5039622c21787d71e07723c1037b9b69a805fe6a74b9bdR80 was what prompted me to ask (maybe these things returned fast enough that it wasn't an issue before?)


jsii-pacmak java fails compilation if a struct as a field named "java"

:bug: Bug Report
Affected Languages

[x] Java

General Information

JSII Version: 1.16.0

What is the problem?

Trying to run jsii-pacmak in a project that exports an interface with a field named java:
export interface Repro {
  readonly java: string;
}

Results in a compilation error:
[ERROR] /private/var/folders/n2/6v4_tbz97ws0h4bn5gbyvzb0m8vcjb/T/npm-packEBNZXY/projen/src/main/java/org/projen/ConstructLibraryCdk8sOptions.java:[1358,38] cannot find symbol
[ERROR]   symbol:   variable util
[ERROR]   location: variable java of type org.projen.JsiiJavaTarget

Root Cause
An example of a line that fails compilation is:
this.author = java.util.Objects.requireNonNull(author, "author is required");

The reason compilation is failing is because the symbol java is defined in this scope to refer to the field java and not the package java.util.

Wow. Ouch. This one might be very tricky to generically address, because that could literally happen with ANY package name first segment... And this is a "free form" string to a large extent.

Wow. Ouch. This one might be very tricky to generically address, because that could literally happen with ANY package name first segment... And this is a "free form" string to a large extent.

But there is a limited set of package names being referenced by the generated code. Namely, java.xxx. I think if we just protect against java we will probably do 80%

But there is a limited set of package names being referenced by the generated code. Namely, java.xxx. I think if we just protect against java we will probably do 80%

Alternatively, is there a way in java to rename an import so that instead of java.util.Objects you'd refer to it as jsii$java.util.Objects or something like that.

Alternatively, is there a way in java to rename an import so that instead of java.util.Objects you'd refer to it as jsii$java.util.Objects or something like that.

Alternatively, is there a way in java to rename an import so that instead of java.util.Objects you'd refer to it as jsii$java.util.Objects or something like that? So it's kept under a symbol that users won't be able to override?

Nope there is no such thing in Java, unfortunately 😑


Code blocks without a language render as inline code

If you use code blocks with a language, like so...
```javascript
var i = 0;
```

...then it will render the code block, as expected, using <pre>.
However, if you use code blocks without a language, like so...
```
var i = 0;
```

...then it will render the code block as inline code using <code>.
It appears to be an issue with MDXC and not markdown-it if you use them on their live demo sites.

I've tried to dig into this off and on over the past day, but I've come up empty handed. In case it helps narrow down the problem, here's what I've tried.
I was able to add a failing test, but adding the following to test/fixtures/unwrapped/code.txt
.
```
{test}
```
.
codeBlock({}, "{test}\n")
.

Which did produce the following failure.

From there, I placed a truckload of console.log statements trying to pinpoint the issue.
Everything looks good until you get into the render function of mdxc.js. Specifically, the call to this.parse.
The call to this.parse will call the parse function in mdxc.js and everything still looks good there until it makes the call to super.parse, which calls the parse function down in the MarkdownIt class.
That call to super.parse will return the following.
[ Token {
    type: 'fence',
    tag: 'code',
    attrs: null,
    map: [ 0, 3 ],
    nesting: 0,
    level: 0,
    children: null,
    content: '{test}\n',
    markup: '```',
    info: '',
    meta: null,
    block: true,
    hidden: false } ]

It's at that point it's already made up it's mind that it should be a code and not a codeBlock.
And that's where I am stuck.
I know the online demos point the finger to MDXC, but the fact that the super.parse call is what returns the code tag leads me to believe it's a markdown-it issue somewhere.
Maybe the factories and ruler overrides / replacements in MDXC make markdown-it call back to MDXC to cause the problem, but I sure can't seem to find it.
I'd be happy to dig in further if someone could point me in the right direction, but at this point, I am stumped. :disappointed:

Thanks for the detailed issue! Should come in pretty handy when I get around to trying to solve it - probably will be a few weeks though due to work :-(


svg_loader: handle text node

The text node is handled, but default values
of the font-family and font-size as used in
the user's system are not.
For now font has to be loaded by the user.
@Issue: https://github.com/thorvg/thorvg/issues/2350

@mgrudzinska @JSUYA This is unrelated to the current review... I think the structure of the SVG loader is becoming a tangled mess, like spaghetti. I believe it needs to be redesigned with a clean architecture. The first job should be to separate the 'builder' and 'parser'.


No archive produced when specifying --only-downloads and --downloads-root

Describe the bug
I'm trying to only download the source for the dependencies specified in the vcpkg.json file located in the root of my Visual Studio project.
I'm attempting to only download the source at this time due to an air gapped build requirement we have at my company.
The idea is to download the required source on to a USB stick, then bring that USB stick to the air gapped machine which will then be used to build the product and all of its dependencies.
When I run the following command:
vcpkg install --x-wait-for-lock --triplet "x64-windows-static" --vcpkg-root "C:\dev\vcpkg\\" "--x-manifest-root=C:\Users\me\source\repos\MyApp\MyApp\\" "--x-install-root=C:\Users\me\source\repos\MyApp\MyApp\vcpkg_installed\x64-windows-static\\" --downloads-root="C:\Users\me\Documents\cache\" --only-downloads

I expected to see archives for each dependency (currently I only have fmt) I have listed in the vcpkg.json file located in the root of my project.
Instead I see nothing in the directory I specified using --downloads-root when calling vcpkg install.
This is the output I see on the command line:
Fetching registry information from https://github.com/microsoft/vcpkg (HEAD)...
Detecting compiler hash for triplet x64-windows...
Detecting compiler hash for triplet x64-windows-static...
The following packages will be built and installed:
    fmt[core]:x64-windows-static -> 8.1.1#1 -- C:\Users\me\AppData\Local\vcpkg\registries\git-trees\602d9743b7957c9e82a06d0e81d58637c6df5222
  * vcpkg-cmake[core]:x64-windows -> 2022-04-21 -- C:\Users\me\AppData\Local\vcpkg\registries\git-trees\8273918a04a5822ad7cc21ea5249402f2e999a7a
  * vcpkg-cmake-config[core]:x64-windows -> 2022-02-06 -- C:\Users\me\AppData\Local\vcpkg\registries\git-trees\24dc7dfc704406e9f745f033643dc25f56e4ca18
Additional packages (*) will be modified to complete this operation.
Starting package 1/3: vcpkg-cmake-config:x64-windows
Building package vcpkg-cmake-config[core]:x64-windows...
-- Installing port from location: C:\Users\me\AppData\Local\vcpkg\registries\git-trees\24dc7dfc704406e9f745f033643dc25f56e4ca18
-- Installing: C:/dev/vcpkg/packages/vcpkg-cmake-config_x64-windows/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake
-- Installing: C:/dev/vcpkg/packages/vcpkg-cmake-config_x64-windows/share/vcpkg-cmake-config/vcpkg-port-config.cmake
-- Installing: C:/dev/vcpkg/packages/vcpkg-cmake-config_x64-windows/share/vcpkg-cmake-config/copyright
Downloaded sources for package vcpkg-cmake-config[core]:x64-windows
Please ensure you're using the latest portfiles with `git pull` and `.\vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+vcpkg-cmake-config
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[vcpkg-cmake-config]+Build+error
including:
  package: vcpkg-cmake-config[core]:x64-windows -> 2022-02-06
    vcpkg-tool version: 2022-03-08-85dc3d9d4e1e7b643f811eac0b9d884419fead79
    vcpkg-scripts version: 8b14e7e87 2022-07-13 (12 hours ago)

Additionally, attach any relevant sections from the log files above.

I checked the logs located in the vcpkgroot\buildtrees and I see no errors for either fmt or  vcpkg-cmake-config.
Environment

OS: Windows 10 - 21H2
Compiler: Visual Studio 2022 - 17.2.5 - v143

To Reproduce
Steps to reproduce the behavior:

Create a project
Create the vcpkg.json file in project root
Add fmt as a dependency
Manually issue the vcpkg install command I showed above (making sure to specify --only-downloads and --downloads-root
Check to see if there is an archive produced in the directory specified with --only-downloads

Expected behavior
I expected to see the downloaded archived source in the directory I specified with --downloads-root
Failure logs
None of the logs show a failure

In my experience --only-downloads is broken. Simply run without --only-downloads. The downloads folder is the same.

One thing I do also want to mention. When I follow the above steps for our private registry whose packages are MSBuild based and not CMake it works as expected. I'm going to fork fmt today and attempt to perform the above steps and see if an archive is generated.

So, it appears the downloading of the source fails when the vcpkg-cmake-config (and other "host" packages) are required.

You're not using the latest version of the vcpkg tool. Please run the bootstrap script again to download the lastest version: bootstrap-vcpkg.bat.

Updating did solve the issue


[Enhancement] Adding Vector Calculator

Description
I would like to add vector Calculator where users can find Addition, Subtraction, Dot product or cross product of vectors.
Workflow :

The user will enter the vectors in the form (xi + yj + zk)
He/She will be prompted for Addition, Subtration, Dot or Cross Product among the vectors.
Subsequently the result will be displayed after calculation

I would like to work on this issue under JWOC 2023. Please Assign me. @Srijita-Mandal 😄

@pooranjoyb go for it.

@Srijita-Mandal
I would like to work on this under JWOC


1.4 update

hey,
could you please update the mootools libs to 1.4?

dublicate, because i dont know how to add pull requests to an oped issue ;( if thats possible at all


yeelight issues with offline bulbs and music mode

Home Assistant release: 0.38.3
**Python release: 3.4.2 **
Component/platform: Debian/Jessie amd64
Description of problem: electrically switched off bulbs are not detected when using music mode
Expected: a switched off bulb state should be unavailable
First off all, my lights are YLDP02YL, they worked straight away with the most basic config.
I'm now using the music mode to circumvent the command limit.
When you start HA with a electrically disconnected light its state is unavailable.
When you power it its state is correctly updated to "on" with the correct color.
When you power it off its state is not updated, it's stay on.
This issue only happens with party mode.
it's quite easy to reproduce :)
netstat shows the music mode connection from yeelight to HA as ESTABLISHED even after 12h being powered off.

Thanks for your report! When in music mode there is no any kind of polling/keepalives from homeassistant's/python-yeelight's side, so when you turn the power off it won't be able to inform anyhow that it's been disconnected.
I'll enable music mode on my bulbs and see if there's something I can do.

Hi,
Thanks for your answer and the fix, I'll give it a try this evening.
I have worked on a different workaround. I'll comment on your PR this evening.

https://gitlab.com/stavros/python-yeelight/merge_requests/4 this how I've fixed it.
this also permits to keep the light properties updated in music mode.

This could even be an issue in the homeassistant component but if that's the case I'll make a fix probably later this week.


feat: add test and try to reconsitution

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Authentication not supported in asp .net MVC

Authentication not supported
I want the basic HTTP authentication in my web API which is not supported in Asp .net MVC. I have tried all the possible fix to do so but it neither showing a pop-up for authentication key to enter nor added the input field for the same.

By ASP.NET MVC, you mean ASP.NET MVC 5 or ASP.NET Core MVC?

ASP.NET MVC 5

Following is the nested class need to be implemented:
private class AddRequiredHeaderParameter: IOperationFilter
{
public void Apply(Operation operation, SchemaRegistry schemaRegistry, ApiDescription apiDescription)
{
if (operation.parameters == null)
operation.parameters = new List();
            operation.parameters.Add(new Parameter
            {
                name = "Authorization",
                @in = "header",
                type = "string",
                required = true
            });
        }
    }

and finally used in Enable Swagger: c.OperationFilter();


Refetching Store Data?

I assume based on the README you'll need to rebuild your site to fetch any changes made to your store? Is there a proposed workflow for this? Do it manually??

That is correct - in development, that is done easy enough by just restarting the Dev server. In production, you can use Shopify notifications to rebuild the site when content changes.
So for example if you were using Netlify to host your gridsome site, you can get the build webhook from your account, and add it to a Shopify "product changed" notification - that webhook will then get pinged everytime you add/update a product. This can be replicated for collections etc.
Does that help?

Yes thank you kindly!


allow disabling of cursor movements

I'm using the face gestures together with a mouse and it is quite irritating that the cursor is moving another way.
To combat this, I've set the cursor movement to zero in the cursor.json.
It should be possible to disable the cursor movement completely by some toggle.

I think allowing the minimum value to be zero would be the easiest solution.

@tqphan if this is meant to be accessible software, a toggle switch is a must.

I'm using the face gestures together with a mouse and it is quite irritating that the cursor is moving another way.
To combat this, I've set the cursor movement to zero in the cursor.json.
It should be possible to disable the cursor movement completely by some toggle.

This is fantastic, thanks for contributing to Project Gameface, very useful addition that I will be experimenting with myself! Wish I had come up with this name but I was suggesting names like “GimpyG’s Fantabulous Face Contraption” which is probably too long.

An overall Face control ON/OFF keyboard short-cut would be very useful (e.g. for speech control / an accessibility switch etc.).
This would help in setting a user up with support, as it's quite fiddly to get to the on-screen toggle switch.