Does tiered storage support aliyun oss?

Is your feature request related to a problem? Please describe.
We're using aliyun oss as storage, How can we use aliyun oss offloader with Pulsar?
Describe the solution you'd like
Support aliyun oss tiered storage.

@yufan022 Currently aliyun oss is not supported yet. You're welcome to contribute a feature to us.

@sijie
Pulsar use jclouds  connect to the cloud provider.
jclouds doesn't support aliyun oss yet, How can we do this work?
I advise two options:

make jclouds support aliyun oss before adapting pulsar.
maybe pulsar need support customized API or SDK to support more cloud provider?

@yufan022 Currently aliyun oss is not supported yet. You're welcome to contribute a feature to us.

@sijie I create a pr, can you help me review it?


ExtensionDiscovery

Closed by #4653 which was merged successfully but due some glitch status didn't update.


Add TOML config file support

Sample TOML config file:
["cfg::Config"]
session_idle_timeout = "1 minute"
shared_buffers = "128MiB"
_pg_prepared_statement_cache_size = 10
listen_port = 5858

[[magic_smtp_config]]
_tname = "cfg::SMTPProviderConfig"
name = "gmail"
sender =<EMAIL_ADDRESS>port = 587
security = "STARTTLS"

[[magic_smtp_config]]
_tname = "cfg::SMTPProviderConfig"
name = "outlook"
sender =<EMAIL_ADDRESS>timeout_per_email = "PT1M48S"

The single-tenant server takes a new --config-file argument that points to a TOML config file like above. At the same time, a multi-tenant server accepts a new key "config-file" in its per-tenant config JSON. Each tenant could define its own TOML config file.
The TOML config file itself is reloadable (defined by --reload-config-files), and the config-file path in a multitenant config JSON file is also reloadable. The reloaded values do not affect running queries or active transactions; they are only effective with new queries, transactions, or backend connections.
The config values loaded from the TOML config file are placed in a new config tier, "configuration file," which overrides "environment variable" (and lower tiers) and is overridden by (not-yet-implemented) "command line" (and higher tiers). The root section in the TOML must be cfg at this moment.
Implementation-wise, the TOML values are JSON-ified and stored in the _edgecon_state temp table, so that different servers on the same backend Postgres may define different values in their TOML config files while not affecting each other (multi-tenancy for the backend). On reload, all alive pgcons shall run a SQL to re-insert reloaded TOML values as soon as they become idle; new pgcons automatically get to insert the reloaded TOML values.

[ ] Deal with backend_setting after reload
[ ] Add tests

Replaces #8059

Add a backport label?

I've spent some time investigating the overall backend_setting with static config (=config set in env var, config files, etc.). I think we have a few undecided issues and questions:

Config with backend_setting is not 100% working in static config.

Config with backend_setting is only effective when the "backend setting" value is set in the backend Postgres. When it comes to static config, the current server implemented by injecting command-line arguments when starting the backend Postgres like postgres ... -c statement_timeout=30s. This is fine with local PG clusters, but not remote ones with --backend-dsn - it's simply not effective.

EdgeQL CONFIGURE SYSTEM stops working on backend config if set in static config.

Background: postgresql.auto.conf is the single-source-of-truth for EdgeDB dynamic system config with backend_setting (if the PG cluster has filesystem access). It's set by SQL ALTER SYSTEM SET  followed by pg_reload_conf(), and read from pg_file_settings. At the same time, we keep a copy of its value in the system override store (usually the "metadata" JSON on __edgedbsys__ database description).
Because Postgres command-line arguments have higher precedence than "configuration file", the value set by the ALTER SYSTEM SQL was never effective, even though it displays to be up to date. For example:
$ env GEL_SERVER_CONFIG_cfg::query_execution_timeout='1s'  edb server &
$ edb cli
> select cfg::Config.query_execution_timeout;
{<duration>'0:00:01'}
> select sys::_sleep(1.5);
gel error: QueryTimeoutError: canceling statement due to statement timeout

Now increase the timeout. It looks like a success but it's actually not:
> configure system set query_execution_timeout := <duration>'2s';
OK: CONFIGURE INSTANCE
> select cfg::Config.query_execution_timeout;
{<duration>'0:00:02'}
> select sys::_sleep(1.5);
gel error: QueryTimeoutError: canceling statement due to statement timeout

For the mismatching display issue, it can be fixed by correcting the config source order like below, but I'm not sure if we want to do it:
diff --git a/edb/pgsql/metaschema.py b/edb/pgsql/metaschema.py
index 035b13e71..a2748a2ac 100644
--- a/edb/pgsql/metaschema.py
+++ b/edb/pgsql/metaschema.py
@@ -3119,10 +3119,10 @@ class SysConfigSourceType(dbops.Enum):
                 'environment variable',
                 'configuration file',
                 'command line',
+                'system override',
                 'postgres command line',
                 'postgres global',
                 'postgres client',
-                'system override',
                 'database',
                 'postgres override',
                 'postgres interactive',

For issue 1 and 2, another direction is to stop using command-line arguments as the implementation of static config. As non of the lower-level PG config sources are available to us, we'll have to share "postgres configuration file" with dynamic system config. This means, we'll need to:

Sync postgresql.auto.conf with static config + dynamic config from __edgedbsys__ metadata, because static config may be different from it was in the last run.
EdgeQL CONFIGURE SYSTEM RESET may issue ALTER SYSTEM SET instead of just RESET, because logically dynamic config is a different layer on top of static config, and users can only reset dynamic config.
On EdgeDB config file reload, we'll also need a sync just like at server start.

Do we actually want backend settings being configurable through static config?

One backend Postgres may have more than one EdgeDB server, each of them may have different static config. This was fine with the current server, when backend config are never effective if --backend-dsn is used. But if we fix that issue, the tenants will race to set their version of the static config to the same backend Postgres. This may lead to some confusion for multi-tenant-on-single-PG users especially after TOML config file and reloading support is added.
This may be potentially relevant to EdgeDB server command-line option --disable-dynamic-system-config, which prevents CONFIGURE SYSTEM commands on configs with cfg::system = true. However, this option does not stop dynamic user changes to 100% configs with cfg::backend_setting, because the 2 types of configs are not 100% overlapping. So this option is not an answer to question 3.
My answer would be "no", because we have to be able to statically configure those system configs which also have cfg::backend_setting, or there'll be no way to set them at all.

How about static config precedence over dynamic config?

This is to say, if one config is set in either environment variable or TOML config file, you can no longer run CONFIGURE SYSTEM on it. Only the server admin could modify the TOML file and reload the server to make hot changes. This almost deprecates --disable-dynamic-system-config and feels cleaner to implement.
An alternative design is just like postgresql.auto.conf, when CONFIGURE SYSTEM would actually store the values in a disk file. My gut feeling tells me this was something in early EdgeDB and long abandoned.


Revert "stats: add stats for specific 4xx codes (#902)"

This reverts commit 6cd5ffe1cb38c7a2e9834bb6dbbd45f158063ef0.
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

@buildbreaker looks like a github actions infra problem is coming for us again https://github.com/lyft/envoy-mobile/pull/916/checks?check_run_id=782352387#step:8:74 😭


Add support for WSL

For some reason, system("uname") returns an empty string. I added a check for this.
This also resolves #433
There are errors printed now, but that is from the server when unauthorized.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey, just noticed that the check for mac is has('darwin') but the docs for the "has" function seem to use 'mac' ie. it should be has('mac'). Can you double check whether that is the case?

Thanks, looks good. One last thing, could you add a quick comment explaining why specifically this was necessary? Saw in your nvim config files that you were previously explicitly setting vim.g.codeium_os to "Linux" in your init.lua file. Does the change you made in this PR fix that (as in, do you still need to set the codeium_os explicitly in your init file)?

Actually, I was looking through the code and tried setting that option to no avail. I just assumed I was setting it wrong and wanted to fix the code regardless.


Fix building indicator jittering

Fix building indicator jittering and change text

Codecov Report

Merging #2577 into canary will decrease coverage by 0.69%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           canary    #2577     +/-   ##
=========================================
- Coverage   14.52%   13.83%   -0.7%
=========================================
  Files         257      257
  Lines        9411     9333     -78
  Branches     1087     1054     -33
=========================================
- Hits         1367     1291     -76
+ Misses       7923     7921      -2
  Partials      121      121

Impacted Files
Coverage Δ

src/commands/deploy/latest.js
0% <0%> (ø)
:arrow_up:

src/util/metrics.ts
68.18% <0%> (-11.13%)
:arrow_down:

src/util/dev/builder-cache.ts
78.48% <0%> (-4.37%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea1b00...096e3bf. Read the comment docs.


Add parameter description.

Docs Build status updates of commit be7e5e4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/failoverclusters/add-clustervmmonitoreditem.md
:white_check_mark:Succeeded

docset/winserver2012-ps/failoverclusters/Add-ClusterVMMonitoredItem.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/failoverclusters/Add-ClusterVMMonitoredItem.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dariomws306 @get-itips @tseward
Peer review needed for this PR. Thanks.

Docs Build status updates of commit b93e5d8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/failoverclusters/add-clustervmmonitoreditem.md
:white_check_mark:Succeeded

docset/winserver2012-ps/failoverclusters/Add-ClusterVMMonitoredItem.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/failoverclusters/Add-ClusterVMMonitoredItem.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[feature request] Backup as you wish.

Currently backup is everything.
It should be separate like setting, novels and downloaded chapters.
for example backup setting. (not important)
Backup novels in library (Only List)
Backup Novels + Downloaded chapters. (This is not enough additional free space for me)
Due to not enough space for everything I can't use current backup. (currently Using screenshot as backup)

Is the current google drive backuo enough?


Accordion Expand Collapse All panels Using Two way binding

Bug Description
I have an accordion with [clrAccordionMultiPanel]="true"
All the panels are two way bound to a state object which is an array of booleans using [(clrAccordionPanelOpen)]
When trying to expand or collapse all of them one shot using the state array, only one of them opens at once
How to reproduce
https://stackblitz.com/edit/accordion-expand
Steps to reproduce the behavior:

Click Expand all
Click Collapse all

Expected behavior
All panels need to be opened and closed when they are two way bound
Versions
App

Angular: [~10.2.0]
Node: [ 12.x]
Clarity: [4.0.5]

Device:

All

Additional notes
I have added an alternate implementation that seems to work when the same behaviour is tried to be achieved through ViewChildren. I would not have to do this ideally. To get this, please use(in html) expandAllUsingVC and collapseAllUsingVC methods defined in ts

Looks like a lifecycle bug to me. May be related to the series of animations that need to be performed simultaneously.
Another workaround could be to request for change detection cycle for each panel you want to open/close like this:
  collapseAll() {
    this.state.forEach((state, i) => {
      this.state[i] = false;
      this.cdRef.detectChanges();
    })
  }
  expandAll() {
    this.state.forEach((state, i) => {
      this.state[i] = true;
      this.cdRef.detectChanges();
    })
  }

@Jinnie yes the workaround is okay for now. However it would be great to have this addressed without the cdref!

I spend some time working on some solution, the issue here is that we needed to redesign how we pass changes across the open/closed panels.
The problem is that after the first-panel update it states, it also updates all other panels with their previous state, basically overwriting them. So to fix that we need to update panel-by-panel but this requires much more refactoring that I think it would take, these changes will affect Stepper witch is sharing a lot of internals with the Accordion.
The effect of this could be easily demonstrated by pressing multiple times the close-all or open-all button and the pannels will change one-by-one in the order they are defined.
The code that is related to the issue could be found here
// projects/clr-angular/src/accordion/providers/accordion.service.ts

  protected emitUpdatedPanels() {
    this._panelsChanges.next(this.accordion.panels);
  }

For example trigger by this line or any other, that is updating panels
  togglePanel(panelId: string, open?: boolean) {
    this.accordion.togglePanel(panelId, open);
    this.emitUpdatedPanels();
  }

Will update only one panel and overwrite everything else with their previous state.
So for now the workaround will have to do the trick and spend some time rethinking it or address it into Core.

@bdryanovski do you guys have a tentative date in mind when this can be addressed?

There is a workaround available for this issue, and we recommend using it for Clarity Angular. We would consider a contribution to address this issue if someone is able to work out a solution. As we build Clarity Core implementations, we expect that this issue won’t be an issue or will be configurable on the application side. To help us clean up our backlog, we are going to close this with a functional workaround available and suggest you follow updates for Clarity Core for enhancements that can support your use case with Clarity Core components.


"Detach Tabs" -  toggle option

What feature or improvement do you think would benefit Files?
Option to enable or disable tabs detach functionality.
Make sliding tabs visually represented as sliding on one axis like in chrome
chrome example:

Requirements
This option will:

save a lot of pain to users that using tablets like Wacom, pen input are very sensitive and can cause a lot of dragging mistakes.
make faster tabs arrangement by dragging them on one axis
make it possible to choose you own working style (everything in one place like browser or separated in different windows)

Files Version
<IP_ADDRESS>
Windows Version
Windows 11 Pro Version	22H2 / build 22621.1778 / Feature Experience Pack 1000.22642.1000.0
Comments
No response

@vovapaukoff thank you for your feedback, this seems a little similar to #11081, can you confirm if fixing that will solve your issue?

Hi Yair.
In case of detach toggle, yes, it can do it.

We don't have an ETA for fixing it but it's on our todo list. You can subscribe to #11081 to be updated when the fix is ready.


Bring crowdinStatsCommand back

This command is temporarily disabled by @riknoll in #9954 .
I haven't done any testing because I can't use some API with my key.

ah, @sae220 I actually just opened a PR fixing this! Check it our here:
https://github.com/microsoft/pxt/pull/9962
Interesting that it doesn't work with your API key... do you happen to know which API was failing? what permissions did you give it?

Also, were you using this command? If so, can I ask what for? I might be interested in your use case to see if I could make something more comprehensive for you.

Thanks a lot for your great help.

do you happen to know which API was failing? what permissions did you give it?
SorceFiles API (like List Files). This returns 403 Forbidden. I gave all permissons.

Also, were you using this command? If so, can I ask what for?
I only did some test to try to solve #9926. I'm sorry that I can't give you interesting use case.

No worries! Thanks for the PR in any case.
I'll have to investigate if Crowdin has a way to get file IDs without list files, it's a really slow request and the permissions on it do seem weird.

I asked crowdin support team why I can't access some API. The answer is below.

Yes, to access all API capabilities you need to be a manager and have a manager token. Also developer role would work

Now I ask ganicke to give me in crowdin conversations.


:sparkles: Add Added processing when data acquisition fails on the notification screen.

Issue

Nothing.

Overview (Required)

I tried to display SnackBar when State is Error.
I added the process as a trial and would like to introduce it to other screens if the direction to display the SnackBar is acceptable.

Links

Nothing.

Movie
https://user-images.githubusercontent.com/13657682/191670119-765f0ae8-17cc-4e20-8093-cd51e16fc8aa.mp4

Thanks for addressing this problem.
I had an idea about this, and I'm a little particular about this. That's why there is no implementation of this.
If the state has an Error, I think the UI should show the UI Model's data. So if it is the error UI Model, I think we should always show something like error module instead of Snackbar.
If you want to show Snackbar, I think we should toggle UI Model like this.
https://developer.android.com/topic/architecture/ui-layer/events#consuming-trigger-updates

How about adding retrySuggestion:Boolean field in ui model? And toggle like this 👀
https://developer.android.com/topic/architecture/ui-layer/events#consuming-trigger-updates

@takahirom
Understood, I will try again tomorrow.
I am not sure I understand how you want to do one thing, so please let me confirm.

So if it is the error UI Model, I think we should always show something like error module instead of Snackbar.
What kind of UI is this "error module"?
So far, I have not been able to imagine what it would look like since there is no design design design.
So I would like to know more details.

Because I also don't have an idea about  error module.😅

@takahirom
Sorry, this is not the fix you suggested, but I fixed it.
It appears to be working on the face of it...🤔
Could you take another look at it?🙏

Thanks! Your codes are the base of our error handling implementation!
We are working on it in this PR. It will merge soon. If you can apply it to other screens, can you support us?
https://github.com/DroidKaigi/conference-app-2022/pull/702

@takahirom

We are working on it in this PR. It will merge soon. If you can apply it to other screens, can you support us?
Understood!🙆♂
I will work on it after the #702 merge.

@Corvus400 I'll take a look at the sessions screen. 🙏

@takahirom
Am I correct that you want me to refer to #718 and #702 and incorporate them into other screens?

@Corvus400 Yes, that is exactly what I mean. But I can make issues so you don't have to do that if you don't want to.👍

@takahirom
We will start putting implementation in place today in the areas that are TODO at this point.


Feature/refactor to class

refactor to es6 class
add es6 linting configuration for eslint

With the addition of Class and the necessary indentation, this diff looks a lot heavier than it is. It is really just explicitly defining the constructor and transforming the prototype methods to straight methods on the Class. The only strange one is the use of get for defaultOptions.

@bcVamp @chrisrng a lot of chatter here, what's the action item here?

@MikeGertrudes adding in a callback function optional param

@MikeGertrudes believe just removing extra iife and extra use strict

Ok @chrisrng RESOLVED. Removed use strict and IIFE. Anything else?

We're good to go except for that one last thing

@chrisrng should be resolved in this branch, but still - looking to maintain a merge request and not push to master. Can you advise?

Hmm weird.. let me try to merge it anyway

Fixed.. had to merge in master


Empty (zero byte) .torrent file

Follow up to #106
https://github.com/helloSystem/ISO/releases/tag/r0.4.0 noted with thanks.
Downloading from https://fosstorrents.com/distributions/hello/#downloads results in an empty hello-0.4.0_0d26-FreeBSD-12.1-amd64.iso.torrent

Will fix this issue in about an hour. Sorry for the inconvenience

Issue has been resolved on https://fosstorrents.com
The problem was due to a typo in the hash part of the filename
Expected: hello-0.4.0_0D26-FreeBSD-12.1-amd64.iso.torrent
Problem: hello-0.4.0_0d26-FreeBSD-12.1-amd64.iso.torrent

Thank you very much for looking into and fixing this @K-Jtan :+1:

Thanks. Seeding now.


chore: import repository https://github.com/keerthana4008/keerthana4008.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@jxbotaccount: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
e52cce4ab69cbc4fb07438f672da12cdc4e9e8b4
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Plans for MML-style document configuration?

A way to feed Simple Tiles XML or similar, and get back a map object that can render images.

Nope, I'm thinking this will be better handled with language bindings. I'd rather not be parsing XML in C.


Does spark DataFrame.limit guarantees any order?

This is just a question, not an issue.
Out of curiosity, does spark.DataFrame.limit guarantees the order ?
That method is used to implement many methods like .head, .iloc
In pandas the data is small and the order could be guaranteed. But in koalas, the data is distributed. Is it guaranteed those methods would keep order?

Yeah, this is a pretty important issue in Koalas.
Currently, it does not guarantees the natural order in general. Natural order can be kept when it only performs map operation (without shuffle) but if shuffle happens, the order cannot be kept.
So, if users want the order, they should sort by, for example, index.

We should still think about how we'll handle this in general.

Thank you!
Follow up of my last question, do you mean spark DataFrame.limit(n) will return first n result ( in natural order, if no shuffle happens)
For example, if read a file as DataFrame, the file would be split into partitions P1, P2 ... , where P1 contains first part of file, ...  If I tried to call df.limit(n), it will return first n of P1 (if n < # P1)
Is that correct? (sorry it more like a spark question but I asked here)

Yes, that's correct :-).

I was thinking about what pandas users expected when using iloc[slice(start, end, step)]
Do people really know which start index, end index he need when he is using an uncountable dataframe.
( but I think user still expected order if the DF is small )

Yes, it's a bit questionable at this moment. Maybe we should do one of these: ...

We just disallow all such cases
Document the case when the order can be deterministic
Document that the index always should be sorted before such operations
Internally always sort on the index in such cases

I think we can close this for now, since we have __natural_order__ column internally. https://github.com/databricks/koalas/pull/1146.


Acess to the model or all fields of a row

Hi there,
I want to get all field values of a row in setCallback closure. But DataRowInterface has only two public methods: getId and getCellValue.
Unfortunaltely the src property is protected and there in no public mthod to access whole row data. I think this may be useful if DataRowInterface has some public methods like: getModel, toJson or something like thsese.
...
'setCallback' => function ($val, DataRowInterface $row_data) {
    $data = $row_data->toJson();
}

I've found getSrc which actually do what I want.


DialogHost.Show?

Can we do ShowModal like in DialogHost.Show?
Is Window available in DialogHost.Show?
The portion of code that follows DialogHost.Show or DialogHost.ShowModal
Is it possible to wait until the answer from ShowModal is not working?
Thank you

Hi @mummyildiz
So the answer is yes, sort of. The DialogHost.Show methods return Task objects so they can be awaited allowing you to have the code that requires the result wait until it is available.
Take a look at the Dialog sample 3 for doing this.
You might also want to read up on the async/await in C#.

thank you.
What do I need to do to prevent the form being opened with DialogHost.Show from closing before the necessary checks are completed.
(Without MVVM)

@mummyildiz I am not entirely sure I understand the question.
The DialogHost.Show methods have several overloads that take a DialogOpenedEventHandler. This delegate is invoked just prior to the dialog being closed. It also allows you the Cancel the closing event, and instead manually call close at a later point by calling the Close method on the Session object.
Something like this:
await DialogHost.Show(content, OnClosing);

private async void OnClosing(object sender, DialogClosingEventArgs e)
{
    e.Cancel();
    await Task.Run(() => {/*Do something here*/});
    e.Session.Close();
}

Teşekkür ederim.

Rica ederim


Unpickling error when running some training and attempting to reload model

Using checkpoint from results/cartpole/2020-08-31--17-00-26/model.checkpoint
Traceback (most recent call last):
File "muzero.py", line 581, in
muzero.load_model(
File "muzero.py", line 402, in load_model
self.replay_buffer = pickle.load(open(replay_buffer_path, "rb"))
_pickle.UnpicklingError: A load persistent id instruction was encountered,
but no persistent_load function was specified.

Hi,
I can't reproduce it.
This can happen if you enter the model.checkpoint for the replay buffer path (instead of the path for replay_buffer.pkl).
model.checkpoint contains the weights and training information but the replay buffer is stored as replay_buffer.pkl
Can you make sure that you are loading replay_buffer.pkl for the replay buffer path ?

Ah that makes sense - didn't realize that!  That explains it


"The box is not able to report an address for WinRM to connect to yet" on windows machine that doesn't exist.

I am getting the following error when hostmanager is run on one of my non-existent windows machines.
The box is not able to report an address for WinRM to connect to yet.
WinRM cannot access this Vagrant environment. Please wait for the
Vagrant environment to be running and try again.
Looking at the logs I believe this is because winrm is raising VagrantPlugins::CommunicatorWinRM::Errors::WinRMNotReady and not catching it here https://github.com/smdahlen/vagrant-hostmanager/blob/a5f69d8e15f2285188deb36e26cc37934a979d7b/lib/vagrant-hostmanager/hosts_file/updater.rb#L16
This is happening on the master branch of vagrant-hostmanager and the default version winrm.

This commit fixes the issue for me.
https://github.com/RyanJarv/vagrant-hostmanager/commit/22edd634315897b54254cc2a08c26a468a514519
Note, this is happening on vagrant hostmanager and vagrant up, so I can't bring up the machine to workaround the issue.

I think this is an issue with the WinRM communicator in vagrant, I don't think it should be raising any exceptions on failure. The following issue is open on the vagrant project regarding this.
https://github.com/mitchellh/vagrant/issues/6356#issuecomment-153135797


Upgraded Jackson to address deserialization vulnerability and silence Snyk

Could you also bump the version to 1.1.1?


Pandas first 20 excluding 7 and 10 Spacy bugs are implemented.

I will try Pandas on my windows to see if it works. Otherwise I will check other APIs again.


Delete images on Delete key

Hello! Can you help to figure out whether it is possible to bind the delete of selected images to the Delete key? The only way for now to delete image is use context menu on selected image or set cursor after image and press Backspace key.
Thanks in advance.
Version
2.43.6

update sun-editor to 2.43.13, now it works! Thanks


TypeScript errors for native HTML attributes

What package has an issue
@svelteuidev/core
A clear and concise description of what the bug is
When I specify native HTML attributes on SvelteUI components, they work as expected, but the TS compiler always complains about them as you can see in the image below.

Is there a way to pass the native attributes up from the root component?

 TS Error Message
Type '{ type: string; }' is not assignable to type '{ class?: string; variant?: ButtonVariant; color?: SvelteUIColor; size?: SvelteUINumberSize; radius?: number | SvelteUINumberSize; ... 28 more ...; pr?: (string & Record<...>) | SvelteUINumberSize; }'. Object literal may only specify known properties, and '"type"' does not exist in type '{ class?: string; variant?: ButtonVariant; color?: SvelteUIColor; size?: SvelteUINumberSize; radius?: number | SvelteUINumberSize; ... 28 more ...; pr?: (string & Record<...>) | SvelteUINumberSize; }'.

In which browser(s) did the problem occur?
Chrome
Steps To Reproduce
Add any native HTML attributes on the components
Do you know how to fix the issue
No
Are you willing to participate in fixing this issue and create a pull request with the fix
Yes
Relevant Assets
No response

I investigated and button types were removed in v0.6  https://github.com/svelteuidev/svelteui/commit/9afb1f0079d83a67556dae4e582d27abb37a0a91 and the current implementation of intrinsic element attributes will show an error if $$restProps is spread to a native HTML Element, which is not a good approach. To mitigate the error something like https://github.com/carbon-design-system/carbon-components-svelte/blob/3c04f122b0ff154eedbe45b51c2d9a4eeccca24b/types/Button/Button.Skeleton.d.ts#LL4C56-L4C56 should be done adding svelte.JSX.HTMLAttribute HTML Element tag name lists to the component types in svelteui

Yes, you are right, this is a current problem. I started solving it in another branch, but I'll move it out of there and open a PR with a fix. If you want and can, you can also submit the fix you think is best.
Thank you for this bug report

@BeeMargarida if you have already started it, no need to duplicate work. But let me know if I can help. Working from @drewbitt comment, it seems like it would simply be modifying the types on the components from something like...
export interface ButtonProps extends DefaultProps<HTMLButtonElement | HTMLAnchorElement> to
export interface ButtonProps extends DefaultProps<svelte.JSX.HTMLAttributes<HTMLButtonElement | HTMLAnchorElement>
but I haven't tested it yet, so it might not be that easy 😅

Note, I just saw that two weeks ago svelte renamed svelte.JSX.HTMLElements into the new svelte/elements package
Migration to new typings
Seems like the way to go

This can be fixed with the svelte.JSX.HTMLAttributes or the new svelte/elements, but in fact a new migration will have to be made to provide correct typings for each component (slots, events, props), following something like this: https://github.com/sveltejs/language-tools/blob/master/docs/preprocessors/typescript.md#typing-components-authoring-packages
I'll make a quick fix to fix these problems (using svelte.JSX.HTMLAttributes for now - it will be ported to svelte 3.55 in the future), but I'll start working on the thing mentioned in the paragraph above.

This should be totally fixed in the new release 0.9.0


Require Julia 1.9 and update CI

This one's CI looks stuck as well

Can you bump to 0.3.4 and release after this ?


Cannot apply DbContext to existing database

Describe what is not working as expected.
I called IMigrator.Migrate() method on runtime with existing database. I would like to apply existing DbContext to existing database.
So my idea was to call:
dotnet ef migrations add --IgnoreChanges
However --IgnoreChanges option is not available in EF Core (it was available in EF).
Is it somehow possible to create initial EF Core migration with existing database?
I have a foreach loop running through all migrations but program runs exception because the model already exists. Here is the code:
var pendingMigrations = dbContext.Database.GetPendingMigrations().ToList();
            if (pendingMigrations.Any())
            {
                var migrator = metricContext.Database.GetService<IMigrator>();
                foreach (var targetMigration in pendingMigrations)
                {
                    migrator.Migrate(targetMigration);
                }
            }

Program tries to apply Initial migration for database that already exists and has the same structure as described in initial migration but fails with System.Data.SqlClient.SqlException telling that there is already an object named XXX existing in the database (I ommitted the real name of the object).

@zygmuntix This is being tracked by #2167, which also has some suggestions on how to proceed for now.


Feature Request: Add custom ClassNames instead of HEX, size, font, etc. or in addition too.

I believe it would be ver beneficial to be able to pass a classname to the
<g class="d3plus_rect" />
object to allow for greater style control.
<g class="d3plus_rect myClassName myOtherClassName ," />
This would make it easier to control the visualizations without having to do all the logic or minute config objects in the viz functions  like this
   .foo({
        size: {
          min: 5
        },
        font: {
          size: 12,
          family: "Open Sans"
       },
        width: 5,
        color: "#ffffff",
      })

It is still very valuable to pass these fine control config objects, but the ability to simply do this
   .foo({
        classNames: 'fooClass barClass myBrandClass'
    })

where the custom classNames are appended to the d3plus className would make some visualzations setup much simpler, faster and allow for greater style control on the part of the developer. In my case I need that control because of the many variations of nodes depending on its state.
Food for thought. FYI I am really liking this library so far. It made my life a lot easier where I am pressed for time on a huge project. Thanks for your efforts.

Also forgot this option.
Pass classNames as a string or in a function that returns the string like:
 .foo(function(d){
        var myClassNames = data.nodeValues[d.ref] || d.className;
        if(myClassNames === undefined){
          return;
        }
        myClassNames = (typeof myClassNames === "string")? myClassNames : myClassNames.className;
        return myClassNames ? palette[myClassNames]: palette["gray-light"];
      })

HA! I think the perfect solution is this. It does not get more simple and elegant than this:
Line 265 & Line 267 of draw.js. Does not affect any of the d3plus functionality and allows me to use the values that already exist in my data.
   //^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    // Groups Enter
    //--------------------------------------------------------------------------
    var opacity = vars.draw.timing ? 0 : 1
    var classNames = (vars.color.classNames)? " "+vars.color.classNames: ""
    var enter = selection.enter().append("g")
      .attr("class","d3plus_"+shape+classNames)
      .attr("opacity",opacity)
      .call(transform)

Here is the REAL fix I am using on the fork. Ignore my previous babbling and 8652a9b. I had a huge brainfart on that one.  This makes it so d3plus functionality remains unchanged and the user has the option of passing the className in the data itself. My data contains already has the className since the styles for each node are specific to user interactions and state.
//^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    // Groups Enter
    //--------------------------------------------------------------------------
    var opacity = vars.draw.timing ? 0 : 1
    var enter = selection.enter().append("g")
      .attr("class", function(d){
        var classNames = (d.className)? " " + d.className: ""
        return "d3plus_" + shape + classNames
      })
      .attr("opacity",opacity)
      .call(transform)

I love this idea, but we don't want to have any reserved words in a user's data (like "className").
The ideal solution would be to create a new .class( ) method that accepts either a String key to use for the class name or a function that returns the class name.
I can help implement this if you're having trouble.

Cool. I'm not sure how to implement the .class() function but I will take a look at the other functions to figure it out. I agree with the className thing. I have been massively swamped on a very large project so  the brain is taking shortcuts just to get things done.
Thanks

I totally get what you mean. I've been swamped as well.
That being said, I just implemented the new method :smirk:

YOU Rock! Thank You.


Fixing typo in the Helm chart available parameters

Fixing typo in the Helm chart available parameters

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: woernfl
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @woernfl. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: linsun, woernfl
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

thanks for the rebase @woernfl !

@woernfl: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
9c926895415df0e4d0e4d0648679867ca218ccd4
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woernfl: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9c926895415df0e4d0e4d0648679867ca218ccd4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun no problem :)

@woernfl: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9c926895415df0e4d0e4d0648679867ca218ccd4
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
9c926895415df0e4d0e4d0648679867ca218ccd4
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Design code filters

filters for design code objects
FilterLoader component

Fix these little bugs and we're ready to merge :)


[v-test][Themes] Holding Up or Down key when selecting a theme hangs the application

OS: Windows 10
Build#: 0.10.12-alpha
Node: 4.1.1
Steps:

Press F1 to open commands
Type Theme, Enter
Hold Up or Down key
Tries to keep up changing themes on the fly/demo them but can't and freezes after a few seconds.

Maybe we should buffer applying the theme with a timeout.


fix: don't replace lodash/fp imports with lodash-es/fp

When importing modules from lodash/fp we get breaking imports since babel-plugin-transform-rename-import renames all lodash imports to lodash-es for the esm build.
e.g import mergeAll from 'lodash/fp/mergeAll'; ends up being imported like import mergeAll from 'lodash-es/fp/mergeAll' and we get an error since lodash-es/fp doesn't exist.
With this fix we rename all lodash-es/fp imports to lodash/fp and we get the correct imports in the final esm build.

Thanks for the bug report and fix @altrim ! I've proposed a cleaner fix below using RegEx.
While I've tested the RegEx I've provided against the source, it would also be good to add an automated test for this behavior to ensure it always works properly. A test could be added to test/e2e/tsdx-build-default.test.ts with fixture in test/e2e/fixtures/build-default/src/index.ts
I'd also wonder if we should add a check for any other potential uses of lodash packages, but afaict, lodash/fp is the only other official one.

I've updated the PR to include the required changes. Anything else left or is this ok?

Hey @agilgur5 anything else left here or is it ok to merge?

@allcontributors please add @altrim for bug, code, test

Ack, while writing a test for #896 I got this in the logs during a UMD build:
No name was provided for external module 'lodash-es' in output.globals – guessing 'lodashEs'
No name was provided for external module 'lodash/fp' in output.globals – guessing 'fp'
No name was provided for external module 'lodash-es' in output.globals – guessing 'lodashEs'

lodash-es I assume would use the same global lodash (or maybe UMD shouldn't use the -es variant #759 ), not sure what lodash/fp should use... jotting this down, haven't quite looked into it yet.
It's an existing "bug" though (it's not an error, just a warning), this just added tests that show these warnings.


Known Issues 1.1.0

From 1.1.0 Changelog:

Cached stylesheets do not get deleted.
Commented out processing instructions () get processed anyways.

@BalduinLandolt

Thanks for opening the issue.
I don't have time to work on it atm, but I think it should be an easy fix: instead of hard-coding a search for <?xml-stylesheet one would have to SAX or DOM parse the document.
This could probably be done either with jsdom (https://www.npmjs.com/package/jsdom) or with or some SAXparser (e.g. https://www.npmjs.com/package/sax-ts)
I'm assuming SAX would be a lot faster in terms of performance.


No way to switch account without signing out

Right now if I want to sign in to another account I have to signOut first, and then I need to call signIn again, only then I can see google-signin modal. But if user changes his mind at this moment and cancels operation after he has signed out and called google modal to sign in again, he appeared to be logged out. Is there a way to show the auth modal without logging out? So if user decided not to sign in to another account, he would be still logged in to the old one.
Steps to Reproduce

Sign in to your google account.
Now call sign in again to change account (nothing happens)
or
Sign in to your google account.
Sign out. (here we loose out token's validity)
Call sign in, see the modal screen with google authentication.
Cancel operation (no valid token anymore for the old account)

Expected Behavior

Sign in to google account
Now anytime call sign in again and 1) see the modal again and 2) either sign in to another account or cancel operation and stay signed in to the previous one.

Actual Behavior
No way to switch account without logging out. After logging out token is no longer valid and if user canceled sign in operation when he wanted to switch account, he appeared to be logged out.
Environment

react-native version: 0.61.5
@react-native-community/google-signin version: 3.0.4

hello, I believe this qualifies as a duplicate of https://github.com/react-native-community/google-signin/issues/200 and so I'll close this.


Use default component metadata when not present

This PR makes the [package.metadata.component] section optional, using ComponentSection::default() if it's not present.
The thinking behind this, is that a user would never typically compile a regular wasm32-wasi module with cargo component. If they are using cargo component build, then they'd expect that the wasm module generated is a wasm component.
Closes https://github.com/bytecodealliance/cargo-component/issues/188

I think I'm generally onboard with this change, but we need to make sure that we only generate bindings only when the key is present, otherwise with this change I assume we'd generate empty bindings for every package in the workspace.

otherwise with this change I assume we'd generate empty bindings for every package in the workspace.

I see, I didn't realise thats how things were working internally.
I guess there's 2 possible solutions:

Could we only generate bindings for the crate thats being built somehow?
Or would this have some issues of its own (such as if the crate being built, depends on another crate within the workspace).

Is there any harm in generating bindings for all crates, even if they're not intended to be wasm components?
As mentioned, with this PR change, bindings might be generated for every package within the workspace.
However, I wasn't aware of this when testing my PR, even when working in a host & guest workspace.
Perhaps this would be fine, and wouldn't add any issues?

For the sake of simplicity, I still would love to avoid users having to mark every wasm component with [package.metadata.component], especially for projects like mine where I don't want the user concerned with the concept of wasm components (as my crate handles this with its own macro built on top of wit-bindgen), and I'd just like them to be able to use cargo component, so they don't have to worry about cargo build --target wasm32-wasi and wasm-tools component new ... with the adapter.

If you feel that you'd still like to go in the direction of marking each wasm component with the metadata, feel free to close this PR and the issue.
I've copied bits and pieces from the this codebase and implemented a thalo build command which does what i need (essentially wrapping cargo rustc -p <name> --lib --target wasm32-wasi --crate-type=cdylib)
https://github.com/thalo-rs/thalo/blob/main/crates/thalo_cli/src/cli/build.rs

Hi @tqwewe. I just wanted to express my thanks for opening this issue and working on a fix.
Given the current design of bindings generation and the absence of the package.component.metadata section being relied upon to bypass bindings generation for non-component packages, I think it's probably best to close this PR for now.
I'm definitely open to revisiting this design in the future if there's substantial confusion from our users when the section is missing (i.e. they created their source with cargo new).


Fixed go get path for the source install

this would make it so that you can't upgrade the CLI anymore, or get the executable when you run go get.


Add autoclosure attribute to materialize() as with init()

This can be used as follows:
// With this
materialize(try NSFileManager.defaultManager().removeItemAtURL(someURL))
// Without this
materialize { try NSFileManager.defaultManager().removeItemAtURL(someURL) }

This seems reasonable to me, although I would note that it’s a breaking API change.
@antitypical/result: Any thoughts?

I'm :+1: on API consistency.

That works for me :+1:

Thanks! :v:

Thank you!


Does finkel-mode exist?

There are no references to it, apart from
To use the finkel-mode, first clone the source repository:
$ git clone https://repository/of/finkel-mode.git

Which seem like a placeholder?

Indeed, it's a placeholder, thank you for pointing out.
Will push the repository and update the document.

Made a finkel-mode repository and update the document, closing this issue.


query client, more key parsing

query: re-usable object query moved from cmd/akash/query
keys: parse more types

Pull Request Test Coverage Report for Build 368

88 of 212 (41.51%)  changed or added relevant lines in 17 files are covered.
8 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.3%) to 65.217%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

keys/parse.go
14
16
87.5%

cmd/akash/query/query.go
1
3
33.33%

cmd/akash/query/account.go
6
9
66.67%

cmd/akash/send.go
0
3
0.0%

cmd/akash/query/deployment.go
7
11
63.64%

cmd/akash/provider.go
0
4
0.0%

cmd/akash/query/provider.go
7
11
63.64%

cmd/akash/query/order.go
6
11
54.55%

keys/keys.go
3
8
37.5%

cmd/akash/deployment.go
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

cmd/akash/query/lease.go
1
43.48%

cmd/akash/query/provider.go
1
78.26%

cmd/akash/query/deployment.go
1
78.26%

cmd/akash/query/order.go
1
73.91%

keys/keys.go
2
71.03%

cmd/akash/query/query.go
2
77.42%

Totals

Change from base Build 361:
-0.3%

Covered Lines:
3808

Relevant Lines:
5839

💛  - Coveralls


Web - The horizontal line separating the header and the messages

Details

Changes useRef implementation for shouldHideThreadDividerLine flag with useState to render the horizontal line correctly when a message is marked as unread.
Fixed Issues

$ #26529
PROPOSAL: #26529
Tests

Click on the FAB and request Money from any user this will take you to that chat room
Click on the IOU message to open the IOU report room
Hover over the first Message in the IOU report room and mark it as unread
An unread mark should appear and the grey horizontal line should be hidden

[x] Verify that no errors appear in the JS console

Offline tests

Same as Tests
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.webm

Mobile Web - Chrome

mweb.chrome.webm

Mobile Web - Safari

https://github.com/Expensify/App/assets/371291/55cdcc9c-8ada-43e3-b5b4-ff01115092b2

Desktop

desktop.webm

iOS

https://github.com/Expensify/App/assets/371291/e6cbbbbb-1173-4a21-a515-dca10e36667a

Android

android.webm

@deetergp, reassigning to you because I believe you were the internal engineer for this issue.

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

recheck

Also adding @robertKozik since he was the C+ on the issue.

Thanks @deetergp I'll review it as soon as possible

The code looks good, but in testing, I don't love that it jumps oddly when going from the gray line to the green line. Is there any way we can reign that in?

@zukilover please check your commits:

We have one lint error here - please fix it
Your commit is not signed properly - for help please refer to point 10 from CONTRIBUTING.md

@robertKozik If I sign the next commit, will it solve the gpg sign issue?

@deetergp I will add transition animation for the separator

@robertKozik If I sign the next commit, will it solve the gpg sign issue?

I'm afraid not. You'll need to retroactively sign all the commits in the branch.
But I see you force-pushed the signed one only, It will be sufficient

I have added animated view for the spacer. it should look smoother now @deetergp
animated.webm

I have fixed the lint issues @robertKozik , please check. Thanks.

Need to force-push for signed gpg.

I have applied your suggestions @robertKozik. Thanks.

@robertKozik I've refactored them into the CONST file, let me know if that works.

P.S.: I need to leave the SpacerView.defaultProps = defaultProps as is, otherwise the linter will complaint:
propType "style" is not required, but has no corresponding defaultProps declaration

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/61146594/0575ddb0-cbf1-4c79-a840-a46a8dc935c8

Mobile Web - Chrome
https://github.com/Expensify/App/assets/61146594/37ae9319-9071-49ae-987a-5efde79d37b8

Mobile Web - Safari
https://github.com/Expensify/App/assets/61146594/234078f0-e183-45e4-95d7-41edb6292a50

Desktop
https://github.com/Expensify/App/assets/61146594/6606aa70-e05b-42c3-be8b-b533874afe23

iOS
https://github.com/Expensify/App/assets/61146594/d52470f5-dde9-4e5d-943b-37dd9f039ca7

Android
https://github.com/Expensify/App/assets/61146594/2b387500-fecd-4e4f-a7b2-9c4f7c5b7af4

Now when I test this, I don't get a green line at all. Am I holding it wrong?

Disregard my prior comment. After logging out and back in again, it worked as expected 👍

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.72-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


catch event show button on osx

hello,
I can not find, how to catch the event when the user click on show button show,
How to get this event from node code ?
i try this :
nc.notify(   {     title: 'Notifications',     message: 'titit'   },   function(err, response, metadata) {     if (err) throw err;     console.log(metadata);     })
but the metadata already empty
best regards

i found sorry
option wait :)


(2.2.8) Failed find all necesary river flow data

IMPORTANT: Please first search existing bugs to ensure you are not creating a duplicate bug report!
Describe the bug
Maps with rivers are not generating correctly
Steps to reproduce the behavior (VERY IMPORTANT)

Generate a new world
use any seed, any size
select a tile with river
issue will trigger

Error Log
!!! Link to contents of Player.log or Error.log (MUST BE LINK) !!!
https://gist.github.com/c42cc7e886d4c8906b81850a50d852dc
Save file
!!! Please add a save file where the issue occurs to speed up testing and fixing of the issue !!!
This is a map generation issue, no way to provide a save for this one
Screenshots
!!! Add screenshots to help explain your problem here !!!
Mod list (For vanilla report, it has to be same as below list.)

Harmony
Core
Royalty (optional)
HugsLib
RimThreaded

does this happen in vanilla? rivers work fine for me...

tried with only vanilla RT, no errors that way. Further investigation is needed


[Feature Request] Update ANCOM to ANCOM-BC because it's faster

Are there plans to update ANCOM to ANCOM-BC in the future? ANCOM takes quite a bit of time especially when it's used on gene expression data and not small OTU/ASV tables.
https://www.nature.com/articles/s41467-020-17041-7

FYI, this will be implemented in qiime2. I have a qiime2 plugin here that will be officially supported in `q2-composition soon.

Is Scikit-Bio going to be developed in the future or is the push largely towards QIIME2?

I can't say about scikit-bio future development, but I can say with high confidence that we will not be reimplementing ANCOMBC in scikit-bio

Hello! Just trying to help with the future development question; taken from: https://github.com/biocore/scikit-bio/blob/master/README.rst
"""Important project update (April 2022): scikit-bio is currently in maintenance mode. Due to limited developer bandwidth, we are focusing on keeping scikit-bio up-to-date with Python and Python scientific computing libraries. We plan to do this through two annual releases of scikit-bio. At this time, we have less availability for reviewing or adding new features. We realize that scikit-bio is an important tool for the bioinformatics community, and we hope to transition back to more active development in the future. If you're interested in helping by taking a leadership role in the project, please reach out."""
Hope this helps.


Don't ignore an error

Codecov Report

Merging #650 (156283d) into develop (79175b1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #650   +/-   ##
========================================
  Coverage    51.89%   51.89%
========================================
  Files           23       23
  Lines         3486     3486
========================================
  Hits          1809     1809
  Misses        1412     1412
  Partials       265      265

Impacted Files
Coverage Δ

...ernal/ledger_for_evaluator/ledger_for_evaluator.go
60.40% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79175b1...156283d. Read the comment docs.


Fix ColorPickerButton to apply changes after picker popup closed

"modal_closed" signal seems removed from the master.
This PR restores the work of ColorPicker inside visual shaders and possibly other places where it happens.

Thanks!


Feature Request: Vi-alike Interface

What the title really means is to basically, instead of relying on another vocabulary of combinations of several hotkeys (which are mostly not at all cozy to press; for example, for the CTRL key, you'd need to put some effort to get back to a state when you could type again), maybe just introduce a vi-alike interface.
Right now pressing ESC clears the input, however the same thing, on my machine is also achieved by pressing CTRL + U; so that's a duplicated hotkey. What we can do instead is that, when we press ESC, it'd put a hint in the input field that we are currently in "Normal Mode" and then make use of all the keys which are easily accessible to control the UI elements, and when we type : in the normal, we will be greeted with a command line (we can just use the input field for this) where we can type ":insert" to go back to "Insert Mode".
The benefits of this implementation:

Super easy and cozy keyboard control of the UI.
Very easy to use "plugins" that you have planned (like a plugin to find servers and messages stored in cache; another to view avatars of servers and users; another to download the hinted image and convert it to a ASCII and then display it on the screen, this can be achieved by Go libraries like this; another to use jj for QWERTY users, or nn for Colemak users to activate "Normal Mode" in "Insert Mode").
Very easy to define custom commands.

Yes please, reason I use all my software in CLI/TUI is to avoid the mouse, my window manager is Wayland/sway sucks to have to go grab the mouse for 1 app, and yes, I use Nyxt also a browser with native Emacs/vim ;) I mention this because someone already told me some time a go, "what about for browser, you have to use the mouse" :)  cheers

I agree
Any TUI software should at least offer the possibility to use vi-like bindings
Someone wanting a tui version of discord has surely a high probability of using vim/nvim anyway ...

This would be very much appreciated !


make the scan lines a parameter

This way, the scan lines are optional and can be disabled if necessary.

Merged. More options are always welcome.


EGD: encoding mixed-metre verse

@arlogriffiths, I'm starting to move some topics raised in the EGD to issues here, for attention at an opportune time. None of these are urgent, but perhaps this way the EGD will be less cluttered and more responsive, and these issues will not be lost from view. Here is the first one.
We have not provided explicitly for the kind of upajāti that mixes 11-syllable and 12-syllable lines (triṣṭubh and jagatī types). I don't think I've ever seen an epigraphic example before now, but this sort of stanza is pretty common in the MBh. I have one now where the first line is in the vaṁśastha pattern, while the next three are in upendravajrā. (Vengi Calukya corpus 00070, Unpublished Eastern Cālukya CP, late 10th century.)
For the time being, I'm encoding this as upendravajrā, with @real on the anomalous first quarter. But this sort of implies that the line is metrically faulty, which is only true for classical Sanskrit verse, but it's a legitimate form in a looser set of conventions.
We could instead:
A. encode it as Vedic trimeter - but the rules there are much more lax, and the pattern is trochaic, so this is also inaccurate;
B. introduce yet another subrule for encoding metre (e.g. add @met="vaṁśastha" for the first line but keep "upendravajrā" or "upajāti" for the stanza as a whole), but this would complicate our approach further for the sake of a very uncommon phenomenon.
C. [I'm adding this now, as a complex but perhaps most satisfactory option that would cover a wide range of cases]: introduce a metre="mixed" option that could only be used on <lg> elements, and if a stanza has mixed metre, then @met would be mandatory on all of its lines.
In case you are interested, the stanza is
yaśo-vikāśāya vikāśitā diśo
daśāpi viśvasya pitāmahena|
śriyan nidhā(?yo)rasi yasya viṣṇu+ḥ
sva-mūrttitāṁ svaṁ ca tapāṁsi tepe||
I don't really understand the second half; the reading is very clear but emendation may be necessary. It may be a Puranic quote (though Google has not helped find it); pls let me know if it rings a bell.

I am inclined to favor option C. I cannot oversee the magnitude of the potential ripple effect of stanzas already encoded that will have to be reencoded should that rule be introduced. A way to find out might be to ask Axelle to generate a list of all stanzas in which @real has been used on any line.

@arlogriffiths , I assume that all instances where real has been used will be actual metrical anomalies and not cases of mixed metres, since nobody has raised that problem before. But I don't mind looking through such a list as a precaution.
@ajaniak , could you generate that list for me? Ideally, it would be lovely to have the text right there (i.e. each item on the list would be the complete contents of an <lg> that contains an <l> with @real on it), but if that is difficult to produce, then a list of filenames containing <l> with @real will also be OK; I'll then look up the texts manually.

I have checked through the list generated by Axelle, looking at many of them directly in the original XML, though after a while I just skimmed through the dozens of instances in the Khmer corpus, all of which concern vipulā (or strange) anuṣṭubh stanzas. The point is: there are no stanzas anywhere in the corpus that we need to change retrospectively if we introduce "mixed" as suggested above.
I have made the suggested changes (plus some more details) in the EGD, §§2.3.4 and 2.3.5.
@ajaniak: I am not sure to what extent our schema constrains the use of @met; I have encoded my mixed-metre stanza as suggested here, and it still validates, so it may not be necessary to do anything to the schema. But if you agree, I think it would be nice to introduce the following:
if an <lg> has @met with the value "mixed", then every <l> that is a descendant of that <lg> must have either @met or @real (or both)


Fails Certification Testing with Channel Behaviour Analysis: PosterGrid Node

Hello,
I'm facing the same issue with Channel Behaviour Analysis.

I used PosterGrid in My Application and applied DeepLinking. I performed DeepLinking by referring to this example.
In certificate testing. It's Shows "Unable to get valid XML layout".

I Tested DeepLinking Parameter using the DeepLinking tool. It's Playing fine. Also, FF and RW work successfully. Focus is also maintained.
My App required Login Functionality. But, It's not mandatory. Without Login, video content is accessible and playing.
Can Anyone Please guide me on what should I do with getting this type of error? It's really appreciated if you guide me regarding this issue.
Thank you

Hi did you find any solution or template that works I'm having the same issues:
Error    Deep Linking    5.1
Error    Performance    3.6
Warning    Automation    4.4
Warning    Automation    4.5


sst deploy fails after Cognito user pool schema changes are wrongly detected

I've hit a blocker issue with sst deploy and sst diff detecting that my Cognito user pool's schema field has changed and it then attempts to deploy it and fails with the error "cannot modify or remove schema items<EMAIL_ADDRESS>This error would be expected given that Cognito doesn't allow this, however, these fields have not changed in my code or in my AWS account and had been working fine through several deploys until I ran sst refresh when attempting to resolve a separate issue (Neon provider plugin crashed).  From then onwards, I get this error when I run deploy.
I'm using SST v3.2.36.
Here's my user pool definition:
export const mainUserPool = new sst.aws.CognitoUserPool("MainPool", {
  aliases: ["email"],
  transform: {
    userPool: {
      schemas: [
        {
          name: "user_id",
          attributeDataType: "String",
          developerOnlyAttribute: false,
          mutable: true,
          required: false,
        },
      ],
    },
  },
});

When I run sst diff, I get:
*  MainPool sst:aws:CognitoUserPool → MainPoolUserPool aws:cognito:UserPool
   * schemas[0].attributeDataType = String
   + schemas[0].developerOnlyAttribute = false
   * schemas[0].mutable = true
   * schemas[0].name = user_id
   + schemas[0].required = false
   * schemas[0].stringAttributeConstraints

Would be nice if the sst diff command had a --verbose argument to show for * items that have changed, what was the value it's being changed from so I could see why it thinks this field has changed

That's strange that it would detect that something changed when there were no changes. Could it be possible that the AWS provider was updated in between? Or did this happen between deploys without any changes in between?

Re: AWS provider bring updated, I didn’t explicitly run sst install. Is there another way this could have been updated?
This first happened yesterday and I ended up just deleting the whole stack to get unblocked. I redeployed new stack today and it had been deploying fine through multiple deploys until I ran sst refresh.
Referencing this Discord thread where another user hit the same issue: https://discord.com/channels/983865673656705025/983865673656705028/1290605674656694296

Adding some more info.
Running sst state edit to open the local state file, this is what is in the outputs of my user pool resource:
"schemas": [
                            {
                                "attributeDataType": "String",
                                "developerOnlyAttribute": false,
                                "mutable": true,
                                "name": "user_id",
                                "numberAttributeConstraints": null,
                                "required": false,
                                "stringAttributeConstraints": {
                                    "maxLength": null,
                                    "minLength": null
                                }
                            }
                        ],

And when I use aws cognito-idp describe-user-pool --user-pool-id XXXX --query 'UserPool.SchemaAttributes', this is what I get:
{
        "Name": "custom:user_id",
        "AttributeDataType": "String",
        "DeveloperOnlyAttribute": false,
        "Mutable": true,
        "Required": false,
        "StringAttributeConstraints": {}
    }

I can't spot anything that the diff command would flag as having changed.


Build and Run failed ( vault)

core-vault-1                | Error enabling: Post "http://<IP_ADDRESS>:8200/v1/sys/mounts/secret": dial tcp <IP_ADDRESS>:8200: connect: connection refused
core-vault-1 | 2022-10-05T18:53:35.669Z [WARN] unknown or unsupported field file found in configuration at /vault/config/vault.json
core-vault-1 | 2022-10-05T18:53:35.669Z [WARN] unknown or unsupported field tcp found in configuration at /vault/config/vault.json
core-eventlog-1             | 17:46:12.496 [main] ERROR org.springframework.boot.SpringApplication - Application run failed
core-eventlog-1             | org.springframework.vault.authentication.VaultLoginException: Cannot retrieve VaultToken from authentication chain; nested exception is org.springframework.web.reactive.function.client.WebClientResponseException$ServiceUnavailable: 503 Service Unavailable from POST http://vault:8200/v1/auth/app-id/login
core-market-1               | 17:46:20.379 [main] ERROR org.springframework.boot.SpringApplication - Application run failed
core-market-1               | org.springframework.vault.authentication.VaultLoginException: Cannot retrieve VaultToken from authentication chain; nested exception is org.springframework.web.reactive.function.client.WebClientResponseException$ServiceUnavailable: 503 Service Unavailable from POST http://vault:8200/v1/auth/app-id/login
core-api-1                  | 17:46:21.115 [main] ERROR org.springframework.boot.SpringApplication - Application run failed
core-api-1                  | org.springframework.vault.authentication.VaultLoginException: Cannot retrieve VaultToken from authentication chain; nested exception is org.springframework.web.reactive.function.client.WebClientResponseException$ServiceUnavailable: 503 Service Unavailable from POST http://vault:8200/v1/auth/app-id/login

core-vault-1                | 2022-10-05T18:53:35.669Z [WARN]  unknown or unsupported field file found in configuration at /vault/config/vault.json
core-vault-1                | 2022-10-05T18:53:35.669Z [WARN]  unknown or unsupported field tcp found in configuration at /vault/config/vault.json

core-matching-engine-1      | org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'orderKafkaConfig': Injection of autowired dependencies failed; nested exception is java.lang.IllegalArgumentException: An array of topics must be provided

database schema not initialized during installation:
postgres-accountant:
    <<: *postgres-db
    volumes:
      - ./accountant-data:/var/lib/postgresql/data/
    ports:
      - <IP_ADDRESS>:5433:5432

=>
$ PGPASSWORD=hiopex PGUSER=opex PGHOST=localhost PGPORT=5433 PGDATABASE=postgres PGDATABASE=opex psql
psql (12.12 (Ubuntu 12.12-0ubuntu<IP_ADDRESS>), server 14.5)
WARNING: psql major version 12, server major version 14.
         Some psql features might not work.
Type "help" for help.

opex=# \dt
Did not find any relations.
opex=# \l

Hey @salisbury-espinosa to help us manage your issues properly, please group these two comments into one issue and add some info about the OS/ arch/ docker version and how you have started the Opex.
Thank you.

@salisbury-espinosa could you please also provide the commands you're using to build/run the application?


Query user profile deprecated fields

(#100) The last_ad_referral and is_payment_enabled fields are now deprecated. Please refer to our Developer Document for more info., type=Optional[OAuthException], code=Optional[100], fbTraceId=Optional[BALnJ3YdOrl])

Check:
https://developers.facebook.com/docs/messenger-platform/identity/user-profile/
You can easily get the profile data yourself, until they fix this.

Fix with #114


Add Vanta required PR and Issue templates

All repos must have PR and Issue templates now. These aren't perfect, but are something to start with.

Our SOC2 audit window will be starting soon. We cannot have any repos that don't have these templates present. If this PR hasn't been merged by Sep 8, this repo will be archived.


[Node.js] re-enable sampling priority tests

Motivation
It was x-passing
Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present
[ ] To R&P team: locally build and push the image to hub.docker.com

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team
[ ] Once merged, add (or remove) it in system-test-dasboard nightly

dotnet team gave me approval to merge even if their tests are failing


import com.lugg.ReactNativeConfig.ReactNativeConfigPackage dont exist

System:
OS --> Windows 11
React Native --> 0.71

My settings.gradle

My build.gralde

My MainAplication.java

+1 facing the same issue
FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':app:compileProdDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

@gur22-09 @ChampiMagic
The Package Was Renamed
com.lugg.ReactNativeConfig

to
com.lugg.RNCConfig

Because name collision with the React Native Config internal package
then the import should be com.lugg.RNCConfig.ReactNativeConfigPackage

thanks @luancurti

The correct config is: import com.lugg.RNCConfig.RNCConfigPackage;
The screenshot is having it right though.


Revert "Bump docker/build-push-action from v1 to v2.2.2"

Reverts mongodb/mongodb-atlas-kubernetes#32

@vasilevp is it possible to mark this dependency as ignored so that dependabot didn't create PRs for it? I see ignored_updates in https://dependabot.com/docs/config-file/#ignored_updates

@vasilevp is it possible to mark this dependency as ignored so that dependabot didn't create PRs for it? I see ignored_updates in https://dependabot.com/docs/config-file/#ignored_updates

we can tell dependabot to ignore it when it pops up again

we can tell dependabot to ignore it when it pops up again


info

thanks again
daily secrets will it be completed today?

there is no daily secrets right now, only that we have added ("happy halloween")

and yes, we have in plans to implement it


Test suite start failing with upcoming 5.5.21RC1 / 5.6.5RC1

For your information, Fedora is running some CI on the PHP stack, which include running test suite of all the available packages test suite against the latest RC (so PHP 5.6.5RC1)
See http://koschei.cloud.fedoraproject.org/package/php-guzzlehttp-guzzle

Thanks for the heads up. I just removed that line from the test for now. I still have to figure out how to address the streams package. If I understand the change correctly, I believe you always have to call fread() more than once now to trigger an feof() now (which seems broken). Closing this issue, but leaving  https://github.com/guzzle/streams/issues/29 open.

I believe you always have to call fread() more than once now to trigger an feof() now (which seems broken).

Not really broken, but make memory streams consistent with file streams:
while (!feof($stream)) var_dump(fgetc($stream));  }

Previous PHP version with memory stream :
string(1) "t"
string(1) "e"
string(1) "s"
string(1) "t"
done

Previous PHP with file stream and new PHP with memory or file stream
string(1) "t"
string(1) "e"
string(1) "s"
string(1) "t"
bool(false)

But yes, behavior change are always uggly...


[Question]:  GlobalFilter  : after pipeline is no Required in the document description , But it's actually Required,

This is not Bug report or Feature request

[X] I confirm that this is not bug report or feature request.

Is this question answered in the documentation?

[X] I have searched the documentation

Is there an existing issue for this?

[X] I have searched the existing issues

Your question
after pipeline is no Required in the document description,
But it's actually Required,
Actually I just need before pipeline
wyatt@wyatt-VirtualBox:~/code/api/regs$ echo '
> name: globalFilter-example
> kind: GlobalFilter
> beforePipeline:
>   flow:
>   - filter: validator
>
>   filters:
>   - name: validator
>     kind: Validator
> ' | egctl object create
Error: 400: {"jsonschemaErrs":["afterPipeline: Must validate one and only one schema (oneOf)","afterPipeline.filters: Invalid type. Expected: array, given: null"]}

hi @wj-stack , I think this issue has already been fixed in #798 and I cannot reproduce it, the fix will be included in the next release. For now, please build from the main branch.


debug for spell.py

debugged the code for symspell  corrector
line  #225:
if word[-2:] == 'ak':
                inner = word[:-1]
                fuzziness.append(word[:-1])
                pseudo.extend(
                    self._augment(word[:-1], sp_tokenizer = self._sp_tokenizer)
                )

line 593:
if word[-2:] == 'ak':
                inner = word[:-1]
                result.extend(list(_augment_vowel_alternate(word[:-1])))

oh great! you can pull request actually.

oh great! you can pull request actually.

will bump asap, thanks!

will bump asap, thanks!

owh, don't know how github works, a noob here

owh, don't know how github works, a noob here


Fix to redact WIF keys, nep2 keys and contract metadata from the command history file (fixes #301)

What current issue(s) does this address, or what feature is it adding?
Fixes #301
How did you solve this problem?
By extending the FileHistory class to make a custom History object that redacts commands before appending them to .prompt.py.history file when one of the following commands import wif {wif}, export wif {wif}, import nep2 {nep2}, export nep2 {nep2} are executed. The WIF keys and the nep2 keys are replaced with <wif> and <nep2> respectively. Metadata (name, description) generated by the command import contract {path/to/file.avm} {params} {returntype} {needs_storage} {needs_dynamic_invoke} is also not added to the .prompt.py.history file.
How did you make sure your solution works?
I tried running the above specified commands and they are successfully redacted.
Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage remained the same at 78.238% when pulling aeaa2e0fbbcd4d7bf282a3c570899a292e623a33 on BSathvik:feature-history-redact into 94147d255adbf1492b46e33b44c4b73f4f4831d3 on CityOfZion:development.

Very nice! Thanks. :+1:
Just a small question / suggestion about this meta count thing.

Very nice, I like this a lot! 👍 Just a few more minor comments inline.

Ok, Instead of using raw_input or input i just removed the history object argument in the prompts of the import contract Metadata. Which makes it look more consistent and was an easy fix.

That's great! I think you've arrived at an ideal implementation 😉

Great! Thanks a lot :+1:

Thanks @metachris and @localhuman! This is one of my first open source contributions. I like it, I think I'm going to keep doing more.


Migrate use cases from use case repo

Copy use case markdown files and related images from FDC3/use-cases to FDC3/FDC3
Update navigation sidebar to reflect new use cases
Give new use cases ids and sidebar labels
Shorten use case ids
Add status section at top of each use case
Remove status field from header at top of each use case (caused a build warning)
Rename intro to overview
Show use cases all in one true, don’t use sub-sections in navigation side-bar

@rikoe could you please resolve the conflict on website/siteConfig.js?

@saori-tr I have removed the conflicts now.
I have also removed the "Accepted" banner across the top of the use cases, I think if only accepted use cases are included it is not necessary.
We do need to decided what to do about use case 6 though (see https://fdc3-use-cases.finos.org/2018/11/07/006-dynamic-discovery-in-chat.html). It is labelled as "In review" in the use cases repo.
You also previously mentioned a use case 15, I don't see one...
Finally, do we need the dates in the use case document names (e.g. "2018-06-08-001-equity-sell-side-trader.md") - in my opinion it would all be much simpler to work with if there was no date in the name, e.g. "uc-1-equity-sell-side-trader.md".
Example of how it will look once merged is here: https://rikoe.github.io/FDC3/docs/use-cases/overview

Looks Good to Me

@rikoe:
Will wait for you on the intro.md conflict.
Please ignore UC 15 for now, we will add it later (after this merge/before launch).
Are you able to just simply remove (not bring in) UC 6?  Could you please?
Thanks.

@saori-tr @nkolba I have merged in latest changes and also removed use case 6 entirely. Hope it is good for merge now!


Skidl sometimes not respecting ref_prefix dictionary keyword

Describe the bug A clear and concise description of what the bug is.
Skidl reference designators ref_prefix not respected on the call of a part, ie
#/bin/bash ipython3.10
In [14]: from skidl import *

In [15]: resistor = Part('CustomLibDevice', 'SD25', ref_prefix='RR')

In [16]: resistor.ref
Out[16]: 'U1'

To Reproduce Steps to reproduce the behavior:
#/bin/bash ipython3.10
In [14]: from skidl import *

In [15]: resistor = Part('CustomLibDevice', 'SD25', ref_prefix='RR')

In [16]: resistor.ref
Out[16]: 'U1'

Expect to see resistor.ref  prefixed with 'RR'. ~~
Desktop (please complete the following information):
OS: Windows/WSL/Debian 12 (bookworm)
Python version 3.10
SKiDL 1.1.0 (development)
Additional context Add any other context about the problem here.
 pip install git+https://github.com/devbisme/skidl.git@development
python3
>>> from skidl import *
>>> resistor = Part('CustomLibDevice', 'SD25', ref_prefix="RR")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ryanpavlovsky/.local/lib/python3.10/site-packages/skidl/part.py", line 191, in __init__
    lib = SchLib(filename=libname, tool=tool)
  File "/home/ryanpavlovsky/.local/lib/python3.10/site-packages/skidl/schlib.py", line 88, in __init__
    tool_modules[tool].load_sch_lib(
  File "/home/ryanpavlovsky/.local/lib/python3.10/site-packages/skidl/tools/kicad/kicad.py", line 93, in load_sch_lib
    v6.load_sch_lib(lib, f, filename, lib_search_paths_)
  File "/home/ryanpavlovsky/.local/lib/python3.10/site-packages/skidl/tools/kicad/v6.py", line 96, in load_sch_lib
    keywords = properties["ki_keywords"]
KeyError: 'ki_keywords'

Checked out development version per advice #172 but the code conflicted with a few custom parts, returning KeyError: 'ki_keywords'
The code contained at https://github.com/devbisme/skidl/blob/7cea69751e97e310d077aa2fc76c7adfa44889ce/src/skidl/tools/kicad/v6.py#L69-96 potentially requires that the part derives from parent parts, otherwise ki_keywords is never populated. Is there a template that could be provided there?

https://github.com/devbisme/skidl/pull/175 provides default values for key items not found. This is a hack, and possibly produces unwanted behavior. I haven't looked around the code-base to observe the impact of this yet.

#175 merged, therefore my issue is closed!

Great! Thanks for reporting the problems.


Update index.mdx

this is very old syntax not supported by the docs throughout. please update to the latest node template, or upgrade your project to this