Custom Through Models

Todo:

[ ] Write documentation for custom through models
[ ] Write documentation for specifying fields with an options object in addition to plain arguments
[ ] Write more tests

I've been looking around for a way to reduce boilerplate and provide an abstraction that's nice to work with. Redux-ORM seems like a great fit. However, there's one use case I have that isn't currently covered. It looks like this PR addresses it, though. The current relationship system is super useful, but it would be nice to define a custom through model. For example, I have person and role. This is a many-to-many relationship that is stored explicitly in my database as person_x_role. When a person gets a new role, I'd like to add an entry there explicitly, rather than add the role id to a field on person.  Is that what this PR accomplishes? If so, is there something I can do to help get it merged in?

Yep, this is exactly what the PR accomplishes.
I just finished writing the documentation for fields -- you can see see the latest commits to check that out.
I still need to do more testing. If you want, you can help out by trying it out in your own project and reporting any errors you encounter related to custom through models. You can do that by following these steps:

Clone the repo to your local computer, checkout to this branch.
In the repo root directory, run npm install and then make build.
Run npm link. This adds the current repo state as a NPM package you can refer to locally.
In your project that uses Redux-ORM, run npm link redux-orm. Now you should be using the Redux-ORM you just cloned and built. You can later reverse this with npm unlink redux-orm.

is it possible to use additional fields with with many-many?
E.g., in our case we have linking table, but each record there holds some addition fields, like:
User:
id, name

Dataset:
id, dataset_id, user_id, cfg, access_role


fix: correct the way fo calling function expression

What's change
Correct the way of how we call the function expression (causing error on example code). It should be with dot notation instead of calling it like regular function.
# Calling function expression in Elixir

hello = fn -> "hello" end
hello.() # we need dot notation when calling the function expression

Great catch!


Connect prefix lists directly to sessions

Is your feature request related to a problem? Please describe.
That's quite a common configuration to connect the prefix list directly to the BGP neighbor/peer without creating routing policies. At the moment that's not possible.
Describe the solution you'd like
It should be possible to have extra fields while editing BGP sessions such as: "Import prefixes" and "Export prefixes" with a drop-down of existing prefix lists. Also, it's good to see related BGP sessions on the prefix list view page.
Describe alternatives you've considered
It's possible to use a custom field for that but then we cannot see to what BGP sessions the prefix list is assigned.
Additional context
None

Hello,
Any suggestions on this?
Thanks

Hi @AleksBelytskyi !  Prefix list filter is part of the routing policy. it's just configured in another piece of config (for Cisco), but in fact it is routing policy.

Hi @k01ek,
First of all, thank you for your response. I appreciate it.
You are right. The prefix list filter can be included in the routing policy, but it can also be used separately and attached to the BGP peer directly. This means that general prefix filters can be applied to group routing policies, while unique prefix filters can be applied directly to individual peers. Many vendors, including Cisco, Arista, HP, and Huawei, support this functionality. (as far as I know, JunOS applies prefix filters through routing policies only).
Therefore, incorporating this functionality into the BGP plugin will provide more flexibility. Additionally, I believe that implementing it should not require a significant amount of effort (maybe I'm wrong :)

#181


Sharpmake.Options.Vc.Compiler.UseStandardConformingPreprocessor support

Added compiler option "Sharpmake.Options.Vc.Compiler.UseStandardConformingPreprocessor" to set the additional option "/Zc:preprocessor"
https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor?view=msvc-170

This seems reasonable. We’ll discuss it next week.


Add Hydra syntax hint (prompt) to input box for modify and queue experiment command

Closes #4465
This PR adds a hint to the input box for selecting new param values when running the modify and queue command.
Demo
https://github.com/iterative/vscode-dvc/assets/37993418/b4e9ba9c-666b-4979-ab32-75071675b827

Is your hint wrapped in exclamation marks like how it shows in the demo? Mine doesn't

I did remove the ! between recording the demo and finishing up with the PR. I felt that they were overkill.


ci: split dev from extra

closes #1651

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #<issue number>
Closes #<issue number>

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below

merging for now, can always modify later if needed, but i'm keen on not forcing all contributors to install pyspark


Acquire frame using L515 via Matlab failed

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ R200 / F200 / SR300 / ZR300 / D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
{ legacy / 2.. }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
Here is the error message I received when I tried to use matlab to acquire frames from L515, matlab successfully connect to the lidar as I can see its device name but can't get a frame back. Any idea?
Error using librealsense_mex
Frame didn't arrive within 15000
Error in realsense.pipeline/wait_for_frames (line 48)
out = realsense.librealsense_mex('rs2::pipeline', 'wait_for_frames', this.objectHandle);
Error in realsense.pointcloud_example (line 17)
fs = pipe.wait_for_frames();

Hi @zjk41   May I begin by asking the questions below, please.

Are you using Windows or Linux?

Is your L515 able to stream depth in the RealSense Viewer program?

Does it make a difference if you unplug the camera's USB cable from the base of the camera, turn the micro-sized connector around the opposite way and then re-insert it into the base of the camera (as USB-C cables are two-way insertion on the micro-sized end).

Which firmware driver version is currently installed in your camera?  If it is older than firmware version <IP_ADDRESS> and the camera was inserted in a USB 2 port (or mis-detected as being on a USB 2 connection even though it is inserted in a USB 3 port) then this could prevent the L515 from streaming, as USB 2 support was not added until firmware <IP_ADDRESS> onwards

Hi @zjk41   May I begin by asking the questions below, please.

Are you using Windows or Linux?

Is your L515 able to stream depth in the RealSense Viewer program?

Does it make a difference if you unplug the camera's USB cable from the base of the camera, turn the micro-sized connector around the opposite way and then re-insert it into the base of the camera (as USB-C cables are two-way insertion on the micro-sized end).

Which firmware driver version is currently installed in your camera?  If it is older than firmware version <IP_ADDRESS> and the camera was inserted in a USB 2 port (or mis-detected as being on a USB 2 connection even though it is inserted in a USB 3 port) then this could prevent the L515 from streaming, as USB 2 support was not added until firmware <IP_ADDRESS> onwards

Hi Marty,
Actually, it fixed itself after I left it there overnight. But I also wonder how do you convert the depth frame captured from the lidar into a 2D depth map, where a depth frame should be an array of 1024x768 and each pixel has a depth value.
In the depth example, it only colorizes the depth frame that doesn't preserve the depth value.
Thanks!
Jingkai

If you are aiming to obtain depth values from a MATLAB wrapper script, a RealSense MATLAB user shared their script in https://github.com/IntelRealSense/librealsense/issues/9773#issuecomment-925553900 for getting distance using the depth.get_distance instruction.

Hi Marty,
This works out very well! Thank you for your help!

You are very welcome.  It's great to hear that the script was helpful to you - thanks very much for the update!


Add a CLI param to override config variables

Something like -c https.enable=true.
This would remove the need to have ip/port/public/private params.

Should the ip/port/public/private params be removed in the same PR? I'll look into this issue

@toXel We'd want to deprecate them as not to break backwards compatibility for now.

@xPaw, I'm a bit on the fence about this idea. What's wrong with having explicit --port, --private etc. instead of -c port, -c private=true, etc.?
It might result in argument parsing duplication, but it's nicer from a CLI user point of view.
I'm not close to the idea, I just want to discuss the outcome before someone spends time on this :-)

The thing is: at the moment the parameters are not working correctly. For example:
lounge start --port 1234 or lounge start -P 1234 starts Lounge on default port 9000. Same with lounge --port 1234 start (That's the way lounge -h describes the usage)
To make it work you have to do lounge --port 1234, lounge -- start --port 1234 or lounge -- --port 1234 start which is not the way it should be, I think.
The whole CLI params parsing implementation has a problem.

Thinking back at this, and after fiddling with command line code and discovering the madness there, I agree with this.
A few random thoughts about the CLI, some of them being related to this very issue:

lounge <subcmd> is a nice thing, àla git. Problem is, it is very poorly handled at the moment. This should be improved by respecting this (we use cmd, just not correctly 😅)
config subcommand is pointless and should be deprecated. Config will most likely always be this config file and can be edited with any text editor (as opposed with user management which might evolve and subcommands for that are just a nice abstraction over that).
private/public/host/bind/port are indeed not necessary here for a normal use case. Esoteric use cases can use your suggested option.
Some options are still good to have: location of the configuration (currently home, but I'm not too happy with how it's handled), --help, --version, and maybe --debug? (even though this latter one can be enabled with your suggestion, there might be some benefits in having it at this level, like debugging configuration file issues, etc.)

So anyway, 👍 on the idea with some suggestions.


[iOS] Mismatch Pod dep in library

Getting ```
✔ update android in 105.58ms
✔ Copying web assets from dist to ios/App/App/public in 140.19ms
✔ Creating capacitor.config.json in ios/App/App in 451.04μs
✔ copy ios in 203.19ms
✔ Updating iOS plugins in 4.41ms
✖ Updating iOS native dependencies with pod install - failed!
✖ update ios - failed!
[error] Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "PurchasesHybridCommon":
In snapshot (Podfile.lock):
PurchasesHybridCommon (= 10.9.0)
    In Podfile:
    RevenuecatPurchasesCapacitor (from `../../node_modules/@revenuecat/purchases-capacitor`) was resolved to 7.7.0,
    which depends on
    PurchasesHybridCommon (= 11.1.1)

    Specs satisfying the `PurchasesHybridCommon (= 10.9.0), PurchasesHybridCommon (= 11.1.1)` dependency were found,
    but they required a higher minimum deployment target.

error: "cap" exited with code 1
error: script "refresh" exited with code 1

When trying to do a cap sync.

Looks like it's referencing the wrong `PurchasesHybridCommon` version.

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

Hi @patrickjquinn,
Can you try deleting the package from npm and the podfiles and reinstall? Sometimes npm gets stuck and doesn't install the SDK properly.

I tried this, nuked the package, did a fresh sync and then retried to install it. Same result. I will re-test though!

Confirming still getting the same results after trying again
✖ Updating iOS native dependencies with pod install - failed!
✖ update ios - failed!
[error] Analyzing dependencies
        [!] CocoaPods could not find compatible versions for pod "PurchasesHybridCommon":
        In Podfile:
        RevenuecatPurchasesCapacitor (from `../../node_modules/@revenuecat/purchases-capacitor`) was resolved to 7.7.0,
        which depends on
        PurchasesHybridCommon (= 11.1.1)

        None of your spec sources contain a spec satisfying the dependency: `PurchasesHybridCommon (= 11.1.1)`.

        You have either:
        * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
        * mistyped the name or version.
        * not added the source repo that hosts the Podspec to your Podfile.

error: "cap" exited with code 1
error: script "refresh" exited with code 1

Ah also confirming that installing 8.0.0-beta.4 fixes this.

I just hit this and fixed it by running pod install --repo-update in your ios/App folder, where the Podfile lives. The pod install command will not succeed unless you update the repo


[Doc]  Want to find the corresponding metrics

What issue do you find in Pulsar docs?
https://pulsar.apache.org/docs/en/2.8.0/reference-metrics/
What is your suggestion?
https://segmentfault.com/a/1190000023706815
In addition to the following metrics, I have found all the metrics that the article recommends to observe
The metrics that need to be focused on are as follows:

Pulsar Broker

loadbalance
Cache hit rate on the broker side
bookie client quarantine ratio
bookie client request queue

BookKeeper

bookie request queue size
bookie request queue wait time
journal create log latency
ledger write cache flush latency
entry read throttle

Do you have any references?
no
Would you like to fix this issue?
yes
Note

[X] I have researched my question.

You mean you can't find the corresponding metrics? like

loadbalance

pulsar_lb_unload_broker_count
pulsar_lb_unload_bundle_count

Cache hit rate on the broker side

pulsar_ml_cache_hits_rate
pulsar_ml_cache_misses_rate
pulsar_ml_cache_xxx

Hi @zcola
I've discussed with @hangc0276, the author of https://segmentfault.com/a/1190000023706815, here is the reply:
1. Pulsar Broker
loadbalance

pulsar_lb_unload_broker_count
pulsar_lb_unload_bundle_count

They have been documented here: https://pulsar.apache.org/docs/en/next/reference-metrics/#bundleunloading-metrics. Please read the docs carefully.
Cache hit rate on the broker side

pulsar_ml_cache_hits_rate
pulsar_ml_cache_hits_throughput
pulsar_ml_cache_misses_rate
pulsar_ml_cache_misses_throughput

They have been documented here: https://pulsar.apache.org/docs/en/next/reference-metrics/#managedledgercache-metrics. Please read the docs carefully.
bookie client quarantine ratio

bookkeeper_server_BOOKIE_QUARANTINE_count

Thanks for reminding us, we've added it here: https://github.com/apache/pulsar/pull/13574
bookie client request queue
As suggested by @hangc0276, users do not need to care about this.
2. BookKeeper
bookie request queue size

bookkeeper_server_BookieReadThreadPool_queue_{thread_id}

Thanks for reminding us, we've added it here: https://github.com/apache/pulsar/pull/13574
bookie request queue wait time

bookkeeper_server_BookieReadThreadPool_task_queued
bookkeeper_server_BookieReadThreadPool_task_execution

Thanks for reminding us, we've added them here: https://github.com/apache/pulsar/pull/13574
journal create log latency

bookie_journal_JOURNAL_CREATION_LATENCY

Thanks for reminding us, we've added it here: https://github.com/apache/pulsar/pull/13574
ledger write cache flush latency

bookie_flush

Thanks for reminding us, we've added it here: https://github.com/apache/pulsar/pull/13574
entry read throttle

bookie_throttled_write_requests

Thanks for reminding us, we've added it here: https://github.com/apache/pulsar/pull/13574


Adding configuration resolver Api for better integration with KeyVault and other use cases

Hi guys,
I recently started using the Azure KeyVault extension and I find it difficult to use. The fact that the key in the KeyVault must match the configuration key is difficult to manage and error prone.
In the example below, to override the connectionString with a secret, I need to add the key EventFlow--outputs--0--connectionString to my KeyVault. If I later on I add another entry to my array, let's say at position 0 (by mistake), the secret will not map to the correct value and my secret will be ignored.
{
  "EventFlow": {
    "inputs": [
      {
        "type": "EventSource",
        "sources": [
          {
            "providerName": "MyEvents",
            "level": "Informational"
          }
        ]
      },
      {
        "type": "Trace",
        "traceLevel": "Informational"
      }
    ],
    "outputs": [
      {
        "type": "EventHub",
        "eventHubName": "MyEventHub",
        "connectionString": "MY_CONNECTION_STRING"
      }
    ],
}

One option to make this simpler is to provide a configuration resolver Api which allow one to resolve values dynamically (instead of overriding keys) and use it to integrate with KeyVault (more info below). The configuration would look as follows (notice that the KeyVault key is marked with $KeyVault(myKeyVaultKey) ):
{
  "EventFlow": {
    "inputs": [
      {
        "type": "EventSource",
        "sources": [
          {
            "providerName": "MyEvents",
            "level": "Informational"
          }
        ]
      },
      {
        "type": "Trace",
        "traceLevel": "Informational"
      }
    ],
    "outputs": [
      {
        "type": "EventHub",
        "eventHubName": "MyEventHub",
        "connectionString": "$KeyVault(MyEventHubConnectionString)"
      }
    ],
}

In this case, the key of my secret in KeyVault would be MyEventHubConnectionString and I can move it anywhere I want in my configuration without having to update my KeyVault key (much better user experience).
Take a look at my fork for a work in progress of the configuration resolver Api (we currently have an internal implementation that we are using for KeyVault in my team).
Note that this Api also opens the door for other interesting configuration resolution, like relative configuration as shown below (which would be simple to implement and can help reducing duplication in configuration):
{
   "key1": "value1",
   "key2":
   {
       "key3": "&(key1)"
   }
}

Please let me know if that's something you'd be interested in integrating and I'll finish the work and submit a PR.
Thanks,
Nehme

We're considering this, or at least a part of this for 2.1. I'll file another issue and close this


Feat/colour perception

Remaining colour_perception metrics from the legacy.

[ ] Update Metric.json
[ ] Run Evaluator

[ ] Why these Luminance Types? Based on Legacy

In the comments/documentation, the range for all the results of LAB avg and std (m14) have been defined as [0, +inf). However, some evaluation results include negative values.
-> @kargaranamir Please, double check and update the implementation and/or ranges.

Thanks. I will check it ASAP.

Could you add more tests to verify the results of the Colorfulness metric (m15)? In their paper, they state "Since we consider that a greyscale image has no colourfulness". However, some of our greyscale test images output significantly higher than zero results. Is this correct?

Should we add Hue standard deviation as m16_1?

Should we add Hue standard deviation as m16_1?

Hue is a circular quantity, so it's not obvious how to compute Hue STD. Here are the links we used for the AVG:

https://en.wikipedia.org/wiki/Circular_mean
http://mkweb.bcgsc.ca/color-summarizer/?faq#averagehue

Are you familiar with how to compute the circular quantity STD? Quick search didn't turn up any good links, since legacy doesn't support it either, I did not implement it.

Should we add Hue standard deviation as m16_1?

Hue is a circular quantity, so it's not obvious how to compute Hue STD. Here are the links we used for the AVG:

https://en.wikipedia.org/wiki/Circular_mean
http://mkweb.bcgsc.ca/color-summarizer/?faq#averagehue

Are you familiar with how to compute the circular quantity STD? Quick search didn't turn up any good links, since legacy doesn't support it either, I did not implement it.

I assumed something like this was the reason. Thanks for verifying. Let's leave the metrics as it is.

Could you add more tests to verify the results of the Colorfulness metric (m15)? In their paper, they state "Since we consider that a greyscale image has no colourfulness [...]". However, some of our greyscale test images output results that are significantly higher than zero. Is this behavior correct?

I will design more test cases to see what happens. As a heads-up, we have implemented "7. A MORE EFFICIENT METRIC" from the paper. It reproduces the section 6 result more efficiently but it does not give the same result as section 6.

Could you add more tests to verify the results of the Colorfulness metric (m15)? In their paper, they state "Since we consider that a greyscale image has no colourfulness [...]". However, some of our greyscale test images output results that are significantly higher than zero. Is this behavior correct?

I will design more test cases to see what happens. As a heads-up, we have implemented "7. A MORE EFFICIENT METRIC" from the paper. It reproduces the section 6 result more efficiently but it does not give the same result as section 6.

Thanks for the clarification! Yes, M3.

According to the documentation, the max number of distinct HSV values is 255^3 (16581375). The generated histogram image, however, shows a max value of ~220.
@kargaranamir Is the implementation and/or documentation correct?

This is due to the paper threshold; only values covering more than 0.1% of image are counted, see "C1-C3". This is how I calculated 0.1 % of the image: 0.01 * image.width * image.height, but I'm not sure if it's what the paper wanted. It is also unnecessary to count RGB in this way. This is because in HSV, the unique number of HSVs does not matter, but the distinct number of each channel matters.

Aah, you are correct. I overlooked the 0.1% threshold filter and as all the results for distinct HSV were a tad under 255 I thought there could be a mistake in the code.
Thanks for pointing out the differences between RGB and HSV. C4 (m3) of the AVI'14 paper is then correctly implemented and there is no reason to count distinct values of Red, Green, and Blue. However, C1-C3 of the AVI'14 paper do not include a metric for the number of distinct HSV values (m17_0), right? Further, in your above comment you mentioned that "the unique number of HSVs does not matter, but the distinct number of each channel matters".
-> Should m17_0 be removed if i) it does not make sense to compute it and ii) it is not included as a separate metric in the paper?

Yes. I did not find any reference that explicitly pointed out the number of distinct HSV, but for the channels individually there are. I think we should delete m17_0, or if we want to keep it, there is no need to follow the 0.1% image threshold, cause this threshold is for the channels.
Ps. We maybe need to rename "Distinct RGB values" or "Distinct HSV values" cause one is for the whole RGB and one is for each channel separately, and they are not the same way. However, it is acceptable to keep these names as well.

Here my suggestion:

Let's delete m17_0 and modify the implementation and metrics.json accordingly
Let's rename m17 as "Distinct values of Hue, Saturation, and Value"

Could you kindly apply the above changes? I can then review the changes and run the evaluator + update the ranges in metrics.json.

Hi Amir, please let me know when you are done with your changes / fixes so that I can re-review the metrics. I still have 'Color Harmonization' to be reviewed in this set of metrics.

As soon as I make the changes, I will let you know. I have started doing a part now.

m14: I fixed m14 ranges, and also checked some test cases using this online converter: http://colormine.org/convert/rgb-to-lab
m13, m15: I made a mistake in implementing m13 and m15, and instead of RGB, I used BGR.
m15: I also made a mistake on the calculation of m15 based on the legacy. "abs" function should not be used, since it is not mentioned in the paper.  Based on what I found online, I checked my implementation with other implementations as well: [1], [2], [3]

All related files (metrics.json, ranges, implementation, histograms, tests, json values) are updated.

Here my suggestion:

Let's delete m17_0 and modify the implementation and metrics.json accordingly
Let's rename m17 as "Distinct values of Hue, Saturation, and Value"

Could you kindly apply the above changes? I can then review the changes and run the evaluator + update the ranges in metrics.json.

Done.

I reviewed metrics m13-m17. Only m20 to go.

Great. I checked them again, and I am concerned about m17. It says only those values covering over 0.1% of the image were used. Does that mean HSV values covering over the threshold together or individually? I implemented the threshold for HSV values together, since it's a color variability threshold.

Review of m20 is done, excluding checking m20_0 range values.
Do you still want to apply further changes to m17, or are we ready to merge this PR to the 'aim2' branch?

Have you checked m20's image outputs? Is everything okay with them?

m20 image outputs looked fine. I will do a merge, run all metrics, check ranges, and close this PR.


HTTP Request output with pipe occures stdout error on macOS

Crystal: 0.21.1 and 3c71228
LLVM: 4.0.0
OS: macOS Sierra
Shell: Bash and Fish
Codes
require "http/client"

response = HTTP::Client.get "http://www.example.com"
print response.body

Crystal 0.21.1
$ crystal [FILENAME] | cat
.
.
.

Example Domain</hstdout:

Crystal 3c71228
$ crystal [FILENAME] | cat
.
.
.

Example Domain</hcat: stdout: Resource temporarily unavailable

No problems on CentOS 7 and Crystal 0.21.1 (install via yum repos).

Duplicate of #2065 ?

Thanks.
Seems to same to issue #2713.
Should I close this Issue?

Duplicate of #2065


Multiple views/pages navigation fails by displaying the incorrect page

I have come across what I think is a major bug in version 3.0's navigation functionality. Firstly, it seems that pages maintain an 'active' status even when the user navigates to another page. Consequently, this leads to problems when a user revisits a page leading to the wrong page being displayed.
I am attaching a file that illustrates this problem. Simply install Kitchen sink, copy test.html to top directory and following instructions:
https://drive.google.com/open?id=0B2LCeg8SYplUZ2pOekswRlk1bG8
Notice how on revisiting a page, the correct header is shown but the incorrect page content is displayed.

As you can see below both pages have an 'active' class

                    Subpage 1

                    Subpage 2
                    You were expecting Page 1 weren't you (if not continue with the instructions)
                    Notice how on revisiting a page, the correct header is shown but the incorrect page content is displayed.

The way to fix this is to remove the 'active' status of a page when the user navigates away from it

We keep active classes when switching from different views.  I won't have time to look into your issue, hopefully someone else can help!

I realize you keep active classes but if different pages within the same view is hit twice, both pages maintain a 'active' status and the third view shows the wrong page (it basically shows the last active page, regardless of which page within the view is requested)

I ran into the same issue. seems like someone posted a pull request on the issue in April.
https://github.com/01org/appframework/pull/850
the update to af.ui.js adds to the runTransition function and removes the active class if found. it works, but it requires a transition to be set when calling the panels, and not sure if it's the best solution.

Not sure that timer to remove the 'active' status of a page is the best approach. Perhaps a function that is called when a page a navigated to that automatically removes 'active' from other pages within the same view.

I won't have time to look into this for a month (vacation and other priorities).  If someone has a fix, please submit a pull request WITH EXAMPLES of the error and the fix

Is anyone else at Intel working on this or is this a one man show? Trying to visit http://app-framework-software.intel.com now shows "The page cannot be displayed because an internal server error has occurred."

@jvence  - the server is maintained by the infrastructure team for HTML5 tools.  I've pinged them to ask what's going on.  Thanks for the heads up.

Sorry but my concern was more with the bug reported rather then the server. Is this framework actively maintained? Are you the only person working on fixing bugs? Thanks

You can view the commit log - https://github.com/01org/appframework/commits/master


ErrorException: Cannot unbind $this of closure using $this in file

Today i install tubor-laravel for new project and got error "ErrorException: Cannot unbind $this of closure using $this in file "
Stack trace show error in this line
https://github.com/tonysm/turbo-laravel/blob/main/src/TurboServiceProvider.php#L97
I tried to fix by change $this to request() and it started working again

Request::macro('wantsTurboStream', function () {
      return Str::contains(request()->header('Accept'), Turbo::TURBO_STREAM_FORMAT);
 });

I'm using :
Laravel 8.58.0
PHP Version 8.0.10
Turbo-laravel latest version

if i resolve $request and use $request->wantsTurboStream() everthing work fine !


Glyphs of generated TTF's are attached to the bottom

When I check the converted file, I can see that all the glyphs are stuck at the bottom, as shown in the screenshot.
And If I convert a BDF file other than this BDF file, it has been confirmed that it looks normal. (ex. GNU Unifont)
Here is header of my BDF file. What could be the problem?
STARTFONT 2.1
FONT -Galmuri11-Regular-R-Regular--16-16-75-75-c-80-iso10646-1
SIZE 16 75 75
FONTBOUNDINGBOX 18 19 -1 -3
STARTPROPERTIES 10
FAMILY_NAME Galmuri11
WEIGHT_NAME Regular
FONT_VERSION Version 2.0.2
COPYRIGHT Copyright (c) 2019-2022 Lee Minseo<EMAIL_ADDRESS>FOUNDRY Made with Bits'n'Picas by Kreative Software
FONT_ASCENT 14
FONT_DESCENT 2
CAP_HEIGHT 12
POINT_SIZE 12
X_HEIGHT 8
ENDPROPERTIES
CHARS 12947

I think I've figured out the cause. Unifont's bitmap data (left) also has vertical margins, while my BDF's bitmap data (right) excludes vertical margins.
Can't you make BBX's Y-axis data reflect?


Add request context processor to Jinja2 engine

@willbarton says this is needed to fix cfpb/wagtail-flags#30.
Additions

django.template.context_processors.request added to Jinja2's OPTIONS['context_processors']

Testing

Pull branch
???
Profit!!

Notes

I suppose I might be able to test this by trying to reimplement the flag that caused the issue in the first place. I'll try that tomorrow if I can find the time.

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Using context_processors with the Jinja2 engine is only supported in Django 1.11+. See docs here. That documentation also suggests that request is automatically added:

If a template is rendered with a request (e.g. when using render()), the Jinja2 backend adds the globals request, csrf_input, and csrf_token to the context.

FWIW I can see the usefulness of adding this generally, but I don't think this is the right solution for the django-flags issue. If a flag condition doesn't require a request to evaluate its logic, it shouldn't require it as a parameter.

Ah well.


Add availability aggregation to Catalogue API

Add a items.locations.type aggregation to show whether things are available physically or digitally.

Just leaving a little tidbit here to think about in relating this to the workType filter.
Currently we filter on workType.id from query string parameter workType.
These IDs will inevitably become redundant.
From this comment on how we might model labelled, arbitrarily-string-IDed objects (e.g. WorkType) I wonder if we could start to form some consistency.
e.g. 1 use .type
We could add the filter workType.type=Books and items.locations.type=DigitalLocation.
The benefit of this, bar consistency is that we could implement a filter that doesn't use the Sierra workType IDs without having to reversion to API.
e.g. 2 infer that if query path is to an object, we are querying on .type
This would then mean we could have:

workType=Books
items.locations=DigitalLocation

This feels a little to infer-y and reads a bit weird
e.g. 3 we create and query on API generated IDs
In this case we don't use the ontologies and what has been, until this point, system like properties.
So we would have:
{
  "workType": {
    "type": "Books",
    "id": "books"
  },
  "items": [
    {
      "locations": [
        {
          "type": "DigitalLocation",
          "id": "digital-location"
        },
        {
          "type": "PhysicalLocation",
          "id": "physical-location"
        }
      ]
    }
  ]
}

and use either of the strategies above to either infer .id.
We're in the process of creating ADTs for most labelled type data, and if we could think of a way of how we can query ADTs universally, that would be great.
We've got the the point now of when changing the model we need to think of storing and querying - hence brining this up.
PIng @alicefuzier and @warrd as they've been talking about it.


[Examples/Move] Port remaining Crypto Sui Programmability Examples

Description
Port over the following examples from sui_programmability/examples:

crypto/sources/ecdsa.move
crypto/sources/groth16.move
games/sources/drand_lib.move
games/sources/drand_based_lottery.move
games/sources/drand_based_scratch_card.move
games/sources/vdf_based_lottery.move

Modernising and cleaning them up in the process:

Applying wrapping consistently at 100 characters, and cleaning up comments.
Removing unnecessary use of entry functions, including returning values instead of transfering to sender in some cases.
Using receiver functions where possible.
Standardising file order and adding titles for sections.
Standardising use of doc comments vs regular comments.
Using clever errors.

This marks the final set of examples to be moved out of sui-programmability, which will then be deleted.
Test plan
sui-framework-tests$ cargo nextest run -- run_examples_move_unit_tests

Stack

#18525
#18526
#18557
#18558
#18595

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Removed the drand example as requested by @benr-ml!


Installing Luna is braking my PATH variable on Windows 10

Installing Luna 1.3 (upgrade from previous one) broke my user's PATH variable on Windows 10.
My PATH is long and may be the problem is that Luna installer may not handle correctly long Windows environment variables.

@varosi Could you provide more information about it? What does it mean it broke the PATH? What happened to id? Btw @sylwiabr please take lead here for future questions and discovery what happens.


Serving index.html

It doesn't look like statigz is serving index.html properly when it's left off the URL. (I am using the Mounting a subdirectory option from the README in case that's an issue.)
e.g. http://localhost/ should be serving index.html, but it's not.
http.FileServer will serve this properly.
In fact, it says in the http.FileServer docs:

As a special case, the returned file server redirects any request ending in "/index.html" to the same path, without the final "index.html".

...and then the code serving the files in http/fs.go has some checks to default to index.html in a dir.
It would be useful for statigz to handle this the same way so it can be a drop-in replacement.
Thanks!

Good catch! Let me check what I can do to align behaviors.

@asmaloney please check if the new v1.1.5 works well for you.

Works great - thanks Viacheslav.
And thanks for this package - nice and simple to use! 🎆


Failed running ccm start on osx

Tried running ccm start and I keep getting this exception
ccm start
[node1 ERROR] objc[51536]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
Error: Could not find or load main class org.apache.cassandra.service.CassandraDaemon

Prior to that, I created cluster using the following command ccm create -v 2.2.3 -n 4 mycluster
~/W/ccm ☕  ccm list
 *mycluster

~/W/ccm ☕  ccm status
Cluster: 'mycluster'
--------------------
node1: DOWN (Not initialized)
node3: DOWN (Not initialized)
node2: DOWN (Not initialized)
node4: DOWN (Not initialized)

~/W/ccm ☕  ifconfig lo0
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> mtu 16384
        options=3<RXCSUM,TXCSUM>
        inet6 ::1 prefixlen 128
        inet <IP_ADDRESS> netmask 0xff000000
        inet6 fe80::1%lo0 prefixlen 64 scopeid 0x1
        inet <IP_ADDRESS> netmask 0xff000000
        inet <IP_ADDRESS> netmask 0xff000000
        inet <IP_ADDRESS> netmask 0xff000000
        nd6 options=1<PERFORMNUD>

Anything I'm doing wrong? I installed Cassandra locally using homebrew, but I've killed the instance. Running on OSX 10.11.3 with Java8

Hi,
Its a known JDK bug in Mac OSX.
bug.java.com
bugs.openjdk.java.net
As per the first bug link, its fixed in JDK 7u60 (b01). Try reverting back to JDK 7 which works with current versions of C*.
Seems like bug is still unresolved in new versions of JDK as well.
Thanks,
Dinesh

You should still be able to compile and run C*, even with that message printed to stderr. What jdk version are you using, and what version of cassandra are you running?
What happens when you compile your local C* installation (or is it already compiled)?

@dins2k2 thanks! reverting to jdk 7 is not really an option as i need jdk 8 for my work :-/
@ptnapoleon i'm using jdk 1.8.0_74, locally I have cassandra 2.2.3 running (installed from homebrew).
If I run ccm start it just keep giving me the exception and it got stuck

If you have C* 2.2.3 installed from homebrew, which is an interesting way to install C*, can you let me know if that works by itself? So just starting 2.2.3 out of your installation dir, without involving ccm?

@ptnapoleon yup, i've been using it for my work environment. Running it locally works fine (using launchctl)
I wanted to try ccm to complete DS201 course on datastax :-)

@ronaldsuwandi Why don't you install JDK7 as well and set the JDK7 path in CCM?
This SOF link will help you to manage/install multiple versions of JDK in Mac OS.
Thanks,
Dinesh

The error message
Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.

has absolutely nothing to do with
Error: Could not find or load main class org.apache.cassandra.service.CassandraDaemon

which is the real problem.
Can you run
ccm invalidatecache
ccm create -v 2.2.3 -n 1 test -s
```?
Then, if that fails, can you please share the contents of `~/.ccm/repository/last.log`?

@ptnapoleon yeah, that failed
~/W/ccm ☕  ccm invalidatecache
~/W/ccm ☕  ccm create -v 2.2.3 -n 1 test -s
Downloading http://archive.apache.org/dist/cassandra/2.2.3/apache-cassandra-2.2.3-src.tar.gz to /var/folders/q4/cy5k4x5n3fz3xgx2cb3_6ys40000gn/T/ccm-Qpl4hR.tar.gz (22.939MB)
  24053447  [100.00%]
Extracting /var/folders/q4/cy5k4x5n3fz3xgx2cb3_6ys40000gn/T/ccm-Qpl4hR.tar.gz as version 2.2.3 ...
Compiling Cassandra 2.2.3 ...
Traceback (most recent call last):
  File "/usr/local/Cellar/ccm/2.0.3/libexec/bin/ccm", line 72, in <module>
    cmd.run()
  File "/usr/local/Cellar/ccm/2.0.3/libexec/lib/python2.7/site-packages/ccmlib/cmds/cluster_cmds.py", line 126, in run
    cluster = Cluster(self.path, self.name, install_dir=self.options.install_dir, version=self.options.version, verbose=True)
  File "/usr/local/Cellar/ccm/2.0.3/libexec/lib/python2.7/site-packages/ccmlib/cluster.py", line 51, in __init__
    dir, v = self.load_from_repository(version, verbose)
  File "/usr/local/Cellar/ccm/2.0.3/libexec/lib/python2.7/site-packages/ccmlib/cluster.py", line 64, in load_from_repository
    return repository.setup(version, verbose)
  File "/usr/local/Cellar/ccm/2.0.3/libexec/lib/python2.7/site-packages/ccmlib/repository.py", line 40, in setup
    download_version(version, verbose=verbose, binary=binary)
  File "/usr/local/Cellar/ccm/2.0.3/libexec/lib/python2.7/site-packages/ccmlib/repository.py", line 206, in download_version
    compile_version(version, target_dir, verbose=verbose)
  File "/usr/local/Cellar/ccm/2.0.3/libexec/lib/python2.7/site-packages/ccmlib/repository.py", line 238, in compile_version
    ret_val = subprocess.call([platform_binary('ant'),'jar'], cwd=target_dir, stdout=lf, stderr=lf)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1334, in _execute_child
    child_exception = pickle.loads(data)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py", line 1382, in loads
    return Unpickler(file).load()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py", line 858, in load
    dispatch[key](self)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py", line 966, in load_string
    raise ValueError, "insecure string pickle"
ValueError: insecure string pickle

log file is empty

Interesting. I have never seen this problem ever. Which version of python 2.7 are you on? How do you have ccm installed, from git or pypi?

I'm on python 2.7.11 - installed through homebrew.
ccm installed from homebrew as well (it comes built in from the cassandra brew).
Anyway I decided to use a virtual machine approach instead. I've got it working with ubuntu 14 on jdk8 running on virtualbox. Feel free to close the ticket or keep it open :-)


Replace population middlewars with protected-populate plugin

Replace functionality page-populate-middleware.js with protected-populate plugin (currently only for the population part since I am not yet done with filters)

Just realized that this does not work since I don't have suport for api tokens aaa

Still have to write a pr for my tool to make it work with api tokens after I done that I will open a pr to switch

@Boegie19 thanks for the update but once everything is ready would love to add your plugin to the starter.


It takes time for the required material window to appear.

When I left click on the favorites list, it now takes a considerable amount of time before the material window appears.
As of 1.21.0, this behavior was already in place.
In previous version, the material window appeared the moment the left click was pressed.
I prefer the previous behavior.

Do you mean the tree-view? Yes, v1.21.0 added a delay when I enabled prio-recipes to be clickable for highlighting. Maybe I made it too long, I'll look into it.

Reduced the delay in v1.21.2


Extend the DiddiScript standard library

Add more libraries, and extend the existing ones.

Ok, I wasted half of the commits with style fixes, but now we are ready.

Waiting for CodeQL to merge...
I've been thinking about this, and I think we will use this "useless" workflow, if we want libraries with Internet connections...


Does this model work with real examples?

Please elaborate if you have tested this model?

Check your answer in issue #19.


Add support for backup & restore to the service broker api

Problem
As a service user I want to have confidence that my service instance is backed up and know that if something bad happens that I can restore from a backup.
As a service operator I want to offer service users a self-service mechanism to perform backup and restores of the service instance, so I don't have to manage this process.
Workflows
As a service user I can trigger a backup for a given service instance
As a service user I can list all backups for a given service instance
As a service user I can restore to an existing service instance
As a service operator I can choose not to offer self-service backups
As a service operator I can choose not to offer self-service restores

Next steps

Community feedback on this feature
Create proposal google document

No strong opinion on this one yet but wanted to add that I thought these types of operations are normally considered to be extensions to the SB spec.  Meaning, a service provider may offer these to their users but they would be too specific to include as part of the core API. So, for example, they may be available via the admin/console URL provided by the service.  But definitely something we should discuss.

I think backup & restore is supported by the majority of services platforms in a generic way for traditional data services [1].
The improvement to the UX for developers vs going to a dashboard that's different for each service / service provider for a common operation like backup / restore is worth extending the API for.
Agree this is a good discussion item for the next call.
[1] Compose.io is a great example: https://help.compose.com/docs/compose-backups

Just need to be careful in assuming that all services are "data services". I have no idea what % fall into the "data service" category and which don't but I do know that its not 100%.

Good point, I would imagine this feature would be similar to bindable in the API today. This is an opt-in feature and brokers that don't support binding do not need to implement the endpoint.

@avade does this assume that SB is the one delivering the service?
In our use case SB is a gateway to different service providers, so effectively the only state stored in the broker is the instances and bindings information.
In our system this would be implemented via "events". We expose an API where users can send events to service instances. Backup is a perfect example of such an event.
That solution works for us because different providers offer different events (i.e. not all services provide backup) so we keep the API consistent all across the board.

Community feedback on this feature

I have no idea what % fall into the "data service" category and which don't but I do know that its not 100%.

Support for additional life cycle events beyond the current CRUD (Create Read(Bind) Update, Delete) is definitively needed for different use-cases, including:

backup/restore:

see related dingo pgsql requests by @drnic
db-dumper-service which which currently works around the issue through arbitrary params conveying side effect semantics in the update/bind verbs and end up providing a custom, non-portable UX through custom CLI plugin

other services such as autosleep that have diverse needs such as toggling state of services, and would benefit from such enhancements, see related  discussion and UX comparison. I'll try to provide some more examples.

An alternative to a normalized backup verb in the SB API, is the notion of service broker action proposed by @benlaplanche . The SB declares a set of additional actions supported (e.g. in a similar way than #59 with a JSON schema) that platform UIs (e.g. CF CLI, or Web UIs) can discover and use to expose extended actions in a uniform ways to platform users.

In our system this would be implemented via "events". We expose an API where users can send events to service instances. Backup is a perfect example of such an event.

@angarg12
The events concept seems interesting to detail, especially if this could be a concept also to also support other use-cases such as broker to app notification events:  credentials renewal/rotation, usage quota reaching limit....
Could you please share related spec URL ? How do you envision adapting this to the SB API ? How would this translate into UX, ie how does this gets leveraged in UIs (CLIs and web UI) ?

@gberche-orange The broker actions concept is interesting, but it does mean that we would have to rely on standards for broker action types. For example, broker A calls backups action take-backup broker B calls backups action trigger-snapshot, which is confusing for developers. A schema with descriptions would go some way to give clarity to users.
As always the more generic the spec the more decisions we push onto consumers and broker authors. Adding backup & restore as a first class concept would be taking an opinion that it's something the majority of services would want to support with a standard UX for consumers.
@angarg12 how do service users submit events to the broker via CF? As @gberche-orange said, a spec / example that we could see would be helpful.

Alex, this would be useful for persistence too, I think.  A developer with an app reading/writing to an NFS volume may very well want to back up that NFS volume, for example.  And later on restore it.

@avade

The broker actions concept is interesting, but it does mean that we would have to rely on standards for broker action types.

The same holds for catalog normalization, where CF community-driven-standards appeared to be both flexible and lightweight without putting that much load on service authors.

Adding backup & restore as a first class concept would be taking an opinion that it's something the majority of services would want to support with a standard UX for consumers.

We would need to detail the variations of backups that are required to support the different use-cases:

backups vs exports (that can be imported somewhere else, such as prod to non-prod)
data anonymization during exports
one-time backup vs scheduled backups
...

In our experience with db-dumper-service and its cli-plugin two "backup" and "restore" verbs are too limited: we need verbs to list/delete/download backups. We also plan to introduce additional verbs to manage backup stores (a container for backups with their quotas and eviction policies...).
I believe that it would be more useful to support additional generic verbs, than try to normalize the many backup/restore variations which only benefits/applies to data services as @duglin reminded, and would leave lots of other services (e.g. route services such as api gateways) without the needed extended verbs they need.

@gberche-orange @avade for the record I have asked my colleagues to provide me with the spec/examples on how these actions are implemented in our system. I am waiting for a reply, I will post details once I get them.

@gberche-orange good points. I am starting to agree that broker actions may be the way to go. It keeps the API simple but extensible for advanced use cases. We can offer a "community standard" guide as part of the spec, similar to CF.
How about we come up with a 2-4 page proposal for broker actions and reference some of the use cases in the document from @benlaplanche [1]. I have started a new issue for this here [2].
We can then discuss on the call next week if you can join?
[1] https://docs.google.com/document/d/1Y5vwWjvaUIwHI76XU63cAS8xEOJvN69-cNoCQRqLPqU/edit#heading=h.kzfeyua6md59
[2] https://github.com/openservicebrokerapi/servicebroker/issues/114

+1 for broker actions.  We have this story on our backlog that sounds very similar.

thanks @avade sounds great. Proceeding conversation in #114

@avade Do you want to close this one now that it's being tracked in #114?

Yep, added a link in #114 to this thread.


Token not seen when under a light

https://ptb.discord.com/channels/915186263609454632/1167222162634047570/1192634524731977758

Closing as not replicable.


I have some issue relate one user one domain one business

[while setting up Bios Domain Name and user account"KACHUY" As use +administration privilege and kachuy.com as biosnet id realize Profile for kachuy mach  the Profile of nt AUTHORITY\system creating a chaos with my picts documents music etc cuase somewere file UP as system (kachuy can't see o modify it) wonder 🤔 any idea]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 06c24fd7-43ce-1445-b734-ffd28410911f
Version Independent ID: b835d64a-a78a-95d9-11a7-8b93a23944c8
Content: Self-service sign up for email-verified users - Microsoft Entra ID
Content Source: docs/identity/users/directory-self-service-signup.md
Service: entra-id
Sub-service: users
GitHub Login: @barclayn
Microsoft Alias: barclayn

@kachuy
Thanks for your feedback! We will investigate and update as appropriate.

@kachuy
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

#please-close


Ensire JWT gets refreshed

We use JSON Web Tokens (JWTs) as tokens of authorization when accessing iNat on behalf of a user. Our JWTs expire after 30 minutes, after which the API should return a 401 response when you try to use them. We currently try to address this in getJWTToken (which should probably be renamed since we're getting a JSON Web Token, not a JSON Web Token Token) by storing the time when we retrieved the token, and the next time we ask for one, we check to see if the existing token is about to expire (or is past expiry) and if it is we fetch a new one.
However, occasionally the app reports problems about the JWT not working. I haven't found consistent repro conditions, but it seems to happen after the app has been idle for a while, which suggests the JWT is expiring and not getting refreshed.
I believe problems occur when components and hook hold on to the JWT in state, e.g. in the useApiToken hook, which seems to hold on to the token forever until the user logs out. So one solid TODO here is to make sure this doesn't happen, either by always using getJWTToken directly to take advantage of its expiration check, or to build the expiration check into hooks and components that hold on to the token.
You might also considering adding some defensive code to all authenticated API requests that responds to 401 and 403 responses by refreshing the JWT and trying again once.

FWIW, I hit what might be a related issue today: I installed the app with npm run android, signed in while connected to Metro, disconnected by device, drove into the woods where I had spotty Internet connectivity, opened the app again and was immediately signed out.

We merged changes so that now we will fetch a new token and retry if a 401 or 403 is hit using react-query. And we fetch the token on every render in useApiToken hook.


feat(bedrock): add checks for guardrails configuration and log encryption

Context
This PR addresses security concerns for Amazon Bedrock by introducing three new checks to strengthen protection against prompt attacks, sensitive data exposure, and log security. These checks aim to mitigate the risks associated with generative AI infrastructures being targeted by adversaries.
Description
This PR adds the following three checks:

bedrock_guardrail_prompt_attack_filter_enabled
Ensures the prompt attack filter is set to the highest strength to protect models from malicious prompts.

bedrock_guardrail_sensitive_information_filter_enabled
Verifies sensitive information filters are enabled to prevent data leakage in model outputs.

bedrock_model_invocation_logs_encryption_enabled
Ensures invocation logs are encrypted with AWS KMS to protect sensitive log data from unauthorized access.

These checks enhance Bedrock's security and data protection.
Checklist

Are there new checks included in this PR? Yes / No

If so, do we need to update permissions for the provider? Please review this carefully.

[ ] Review if the code is being covered by tests.
[ ] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
[ ] Review if backport is needed.

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22, changes done in https://github.com/prowler-cloud/prowler/pull/5385/commits/a50114f41424d69ff72472849b896ccd8ba27d89


Warcraft III.exe Path not configurable

It is not possible to give the path to the warcraft.exe in a config file.
If you have the game not in the default path it will always ask where the game exe is located.

Fixed in latest tool version. Please re-open if it's still not working for you.


Anime component makes div disappear

Am I doing something wrong?
import Anime from 'react-anime';

function Header() {
   return (

Header

         <Anime>

         </Anime>

   )
}

I've tried adding the props from the example, but without them I also get the same result. It simply makes my div disappear.

@luandro can you make a codepen of this so that we can inspect and see whats going on? Heres a base template for a codepen

@luandro actually I spotted the bug and it should be fixed. npm install react-anime to v0.2.0. It should be working. Thank you for raising this issue :)

@luandro if the problem went away with v0.2.2 feel free to close the issue.

@kennetpostigo got fixed, thanks a lot and great job on the project!


Hexadecimal speed conversion to Double

Hi anton, as I told you before I'm creating a slightly different protocol using GT06 protocol decoder but I need to convert speed from Hex to Double, how can I do that?
in GT06 I have this:
position.setSpeed(buf.readUnsignedByte() * 1.00);
(forget about the 1.00)
The device is sending speed in hex but is not sending 0x10 but only the integer part 10.
How can I convert that to Double ??
Thanks

Can you please provide example of the data you get and what you are highlight the part you are trying to convert.

I'm trying to change this from Gt06 protocol decoder:
// Speed
position.setSpeed(buf.readUnsignedByte() * 0.539957);
This is a speed conversion from knots to kms, but my device send speed as hexadecimal value not an integer, so I need a procedure to change hexadecimal to double and store the speed.
This is the speed spec in the documentation:
<IP_ADDRESS>.	Speed
One byte is consumed, defining the running Speed of GPS. The value ranges from 0x00 to 0xFF indicating a range from 0 to 225km/h.
e.g.   	0x00 represents 0 km/h.
0x10 represents 16km/h.
0xFF represents 255 km/h.

You can provide sample in HEX format like the one you get in the log.

Ok
First received:
787805120060c1a20d0a
78781f120f090b071308c90115565a074e36df003d2e02de041b6e008d1f000bf78d0d0a

So, where is the HEX data that is not an integer?

not a clue, I'm not able to see the incomming data I just want to store the correct speed, the gt06 protocol is reading the information, multiplying x 0.539957, I need to replace that and convert the buf.readUnsignedByte() which returns a short number with the hexadecimal equivalence explained here:
<IP_ADDRESS>. Speed
One byte is consumed, defining the running Speed of GPS. The value ranges from 0x00 to 0xFF indicating a range from 0 to 225km/h.
e.g. 0x00 represents 0 km/h.
0x10 represents 16km/h.
0xFF represents 255 km/h.
How can I do that?

can I do this?
double speed = (double) buf.readUnsignedByte();
position.setSpeed(speed);

Yes, you should be able to do that.

But the result is going to be... maybe the same right?

Please maybe this do the job:
##FUNCTION TO CONVERT TO HEX##
public static long parseUnsignedHex(String text) {
if (text.length() == 16) {
return (parseUnsignedHex(text.substring(0, 1)) << 60)
| parseUnsignedHex(text.substring(1));
}
return Long.parseLong(text, 16);
}
// Speed
String hex = String.valueOf(buf.readUnsignedByte());
long longHex = parseUnsignedHex(hex);
double d = Double.longBitsToDouble(longHex);
position.setSpeed(d);

Maybe this is it:
// Speed
String hex = String.valueOf(buf.readUnsignedByte());
double d = Integer.parseInt(hex, 16);
position.setSpeed(d);

No, just readUnsignedByte should work.

Anton, this is not working, the final string is not the sent by the device and for that the resulted speed is higher than real.
String hex = String.valueOf(buf.readUnsignedByte());
double d = Integer.parseInt(hex, 16);
position.setSpeed(d);
And this does not work, I received a incompatible types error (short cannot be converted to a string):
double d = Integer.parseInt(buf.readUnsignedByte(), 16);

What units does your device send speed value in?

78781f120f090b071308c90115565a074e36df003d2e02de041b6e008d1f000bf78d0d0a
this is what you sent luis
so you can see what the sends

the protocol specification says is sending speed as hexadecimal unit in Kilometers per hour.

Can you please send me protocol documentation to check? If you don't want to share it publicly, you can send it to me by email (address in profile).

It's looks like a standard GT06 protocol. Where does it say that the Speed is in HEX? Speed value is just a byte, so as I said before readUnsignedByte should work.

jum, ok ok, so basically it doesn't need anything special at all? I'm sorry
about my ignorance about this...
On Mon, Sep 14, 2015 at 5:14 PM, Anton Tananaev<EMAIL_ADDRESS>wrote:

It's looks like a standard GT06 protocol. Where does it say that the Speed
is in HEX? Speed value is just a byte, so as I said before
readUnsignedByte should work.
—
Reply to this email directly or view it on GitHub
https://github.com/tananaev/traccar/issues/1404#issuecomment-140214267.

Correct, it's a standard byte value in binary format.

Anton you are right the GPS device is not sending an accurate speed due to
factory failures.
Thanks a lot, the sad part is that we are returning 1000 Devices!!
On Mon, Sep 14, 2015 at 5:26 PM, Anton Tananaev<EMAIL_ADDRESS>wrote:

Correct, it's a standard byte value in binary format.
—
Reply to this email directly or view it on GitHub
https://github.com/tananaev/traccar/issues/1404#issuecomment-140216413.

That's a lot of devices. Are you sure it sends completely incorrect value or just using different speed units?

I did a test with a vehicle and it sends the speed correctly, apparently
this issue is present in a group of devices only, so we are testing
everything again. thanks for the support i think this can be closed now.
On Mon, Sep 14, 2015 at 7:57 PM, Anton Tananaev<EMAIL_ADDRESS>wrote:

That's a lot of devices. Are you sure it sends completely incorrect value
or just using different speed units?
—
Reply to this email directly or view it on GitHub
https://github.com/tananaev/traccar/issues/1404#issuecomment-140240694.


Adding Haptic Feedback?

I would be very interested in having SVProgressHUD automatically trigger Haptic Feedback events on the iPhone 7 when the success or error HUDs are called. Is there interest in this for anyone else? It would definitely be a configurable option, perhaps even disabled by default, so it doesn't get in the way of other Haptics that may be included in an app.
If there is interest I would be more than happy to work on this and submit a PR for it, but I don't want to develop it if it isn't wanted as part of the framework.
More information about the new API is here:
https://www.hackingwithswift.com/example-code/uikit/how-to-generate-haptic-feedback-with-uifeedbackgenerator

In general: Welcome this idea, however, the HUD must remain compatible down-to iOS 7. This would be work that is only available to a few users and I am not sure about how to use this feedback very "sensible".

Okay, well if you're open to the idea in general I'll put something together and send it as a PR and we can discuss more details there.
Agree that not many users would be able to use it at first, but with the functionality baked in it will be cool as users start to feel it in their existing apps when they get a new phone. Apple has specific feedback templates for success and error notices, so I'm hoping it will show up in various places around the system and feel right at home.

If Apple has really feedback templates for success and error notices this would be a solid justification as well as motivation for the PR. Please add them to the discussion.

I've created a PR (#665) where we can continue the discussion there.


miracode: init at 1.0

Description of changes
Miracode is a vectorized version of the Monocraft font.
Since this is my first contribution I am also adding myself to maintainer list!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

excellent work coca162


Improved reliability

See #31 for more info

Forgot to merge your hotfix....

Doesn't matter, it's fixed now!


https://supermarket.chef.io/cookbooks/mysqler not up to date

https://supermarket.chef.io/cookbooks/mysqler = v 1.0.6
https://github.com/wix/mysqler = 1.0.14
wonder if you could push your changes for ease of use in chef.
Thanks

Thanks for your comment.
Transferred to current owners of the cookbook to make the update.


Add Sparkler and Multiball effects. Update warp with black hole. Update eyes to use new color lib

Add sparkler effect, multi ball effect, update eyes to use new common color lib function call, and add a black hole in the middle of the warp field.

When adding new plugins we should update a small video into the effects readme and update it.   Ping me if you need a hand uploading them to github like the other videos I put up -- it's not obvious.


Added composer json

Hi,
How about the merge? Are there any difficulties in this matter? I would love to see the plugin in Packagist as well.


Chore/update footer

Problem
What problem or issue does this pull request solve Jira
Solution
I added the 2021 icon to footer component and it's corresponding link to cruzhacks2021 website
Change Summary:

Tidy, well formulated commit message
Another great commit message
Something else I/we did

Dev-Ops
If you added an ENV variable, please check off that you've updated the following

[ ] Key & Sample value to .env & sample.env
[ ] GCP Secret Manager (Both development and production)
[ ] Github Secrets (Added a development and production variable)
[ ] Github Workflows .github/workflows/dev.yml & .github/workflows/prod.yml
[ ] webpack-config.js

Images/Important Notes (optional):

Insert any notes/issues, dependencies added or removed, or images

@krishnakpandian I noticed it too, it looks a little wonky. I attempted to edit the SVG but I'm not sure what to do without making major changes like removing the background from it

@krishnakpandian I could try to remove the css highlighting all-together from the icons but I have a feeling that the other icons will look dull in comparison to the 2021

@Alperdec Yeah I agree with not removing it everywhere, I'll see if I can get an icon from design that has less highlighting, but otherwise it looks good.


SetRecordingFolder not working

Hi,
I'm currently facing an issue while attempting to set the recording folder using the OBS WebSocket API. I'm receiving the following error message: OBSWebSocketError: Your request type is not valid.
According to the documentation, the SetRecordDirectory method was introduced in version v5.3.0 of obs-websocket. However, the latest available version of obs-websocket is 5.2.3, which does not include this method.
I have also tried using the GetRecordDirectory method, but it does not return the desired value for my use case. Specifically, I need to retrieve the URL when using Custom Output (Ffmpeg) with the output type set to "Output to URL". Currently, the method only returns the value when the output type is set to "Output to File".
Note:
Since the latest version of obs-websocket (5.2.3) does not include the SetRecordDirectory method, I would appreciate any guidance or suggestions for a workaround to achieve my desired outcome of setting the recording folder with the specified output type.

@abenmohamed , in case you still need a solution:
Since OBS Studio currently doesn't have v5.3.0 implemented, you can't use SetRecordDirectory, you can use the old method's SetProfileParameter:
This is for JavaScript
// Sets a new recording path
obs.call('SetProfileParameter', { 'parameterCategory': 'SimpleOutput', 'parameterName': 'FilePath', 'parameterValue': selectedFolderPath })

// Prints the now changed values
obs.call('GetProfileParameter', { 'parameterCategory': 'SimpleOutput', 'parameterName': 'FilePath' })
    .then(result => {
        console.log('Result:', result);
    })
    .catch(error => {
        console.error('Error:', error);
    });

What worked for me was setting:
parameterCategory -> "SimpleOutput"
parameterName -> "FilePath"
Similarly you can change the output type. You can change these variables:
[SimpleOutput]
FilePath="path goes here"
RecFormat2=mkv
VBitrate=2500
ABitrate=160
UseAdvanced=false
Preset=veryfast
NVENCPreset2=p5
RecQuality=Small
RecRB=false
RecRBTime=20
RecRBSize=512
RecRBPrefix=Replay
StreamAudioEncoder=aac
RecAudioEncoder=aac
RecTracks=1
StreamEncoder=nvenc
RecEncoder=nvenc

Facing Same issue.
obs.call('GetRecordDirectory') is working just fine, but
    recordDirectory: "C:/Users/ASUS/Videos/saad"
  });

Not working at all


[zh] Sync kubeadm/kubelet-integration.md

[zh] Sync kubeadm/kubelet-integration.md

/approve
/lgtm


Plutus Language Spec: builtin types and functions in chapter 5 does not match implementation

Summary
The uplc program supports more constructs than mentioned in the current specification. Please update chapter 5 of the specification (aka the chapter titled "built in types, functions, and values") to reflect the V1 implementation.
Steps to reproduce the behavior
1 look at spec chapter 5
2 look at haskell files that correspond to builtin implementations
Actual Result
The information presented in chapter 5 should match the haskell file that corresponds to the builtin types and function
Expected Result
Chapter 5 is missing several builtin types and functions
Describe the approach you would take to fix this
No response
System info
Does not matter

This is fixed in the forthcoming new version of the specification.


[SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

What changes were proposed in this pull request?

This changes DropTableExec to also invalidate caches referencing the table to be dropped, in a cascading manner.
Why are the changes needed?

In DSv1, DROP TABLE command also invalidate caches as described in SPARK-19765. However in DSv2 the same command only drops the table but doesn't handle the caches. This could lead to correctness issue.
Does this PR introduce any user-facing change?

Yes. Now DSv2 DROP TABLE command also invalidates cache.
How was this patch tested?

Added a new UT

Test build #130482 has started for PR 30211 at commit cc4284d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35086/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35086/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35086/
Test PASSed.

Test build #130482 has finished for PR 30211 at commit cc4284d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class DropTableExec(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130482/
Test FAILed.

When you add [WIP], it's helpful for the other people if you convert your PR into DRAFT status in GitHub too.

Gotcha. Will do next time.

Test build #130620 has started for PR 30211 at commit b57e032.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35221/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35221/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35221/
Test PASSed.

Test build #130620 has finished for PR 30211 at commit b57e032.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130620/
Test FAILed.

Test build #130666 has started for PR 30211 at commit 850a992.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35277/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35277/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35277/
Test PASSed.

Test build #130666 has finished for PR 30211 at commit 850a992.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130666/
Test FAILed.

Test build #130673 has started for PR 30211 at commit a5114f7.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35284/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35284/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35284/
Test PASSed.

Test build #130673 has finished for PR 30211 at commit a5114f7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130673/
Test FAILed.

Hi, @sunchao .
The failures seems to be related. Could you take a look at them?

Retest this please

Oops - I didn't check the jenkins job. Will take a look. Not sure why they didn't appear in the github action, also I cannot reproduce them locally seems.

Test build #130678 has started for PR 30211 at commit a5114f7.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35289/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35289/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35289/
Test PASSed.

Test build #130678 has finished for PR 30211 at commit a5114f7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130678/
Test FAILed.

Test build #130738 has started for PR 30211 at commit 3f25675.

Test build #130739 has started for PR 30211 at commit c18ad8e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35347/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35347/

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35347/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35348/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35348/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35348/
Test FAILed.

Test build #130738 has finished for PR 30211 at commit 3f25675.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130738/
Test PASSed.

Test build #130739 has finished for PR 30211 at commit c18ad8e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130739/
Test PASSed.

cc @cloud-fan @rdblue

Test build #130801 has started for PR 30211 at commit fb4a634.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35410/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35411/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35410/

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35410/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35411/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35411/
Test PASSed.

Test build #130801 has finished for PR 30211 at commit fb4a634.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130801/
Test PASSed.

Test build #130856 has started for PR 30211 at commit 1b7c991.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35465/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35465/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35465/
Test FAILed.

Test build #130856 has finished for PR 30211 at commit 1b7c991.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130856/
Test PASSed.

thanks, merging to master!

thanks @cloud-fan for reviewing the PR!


Websocket traffic not showing

Describe the bug
When I capture traffic of pod it only captures the first websocket connection establishment.
To Reproduce
Steps to reproduce the behavior:

Run mizu pod-name ...
Open a websocket connection with the pod
Send messages through the created socket
Check the dump dashboard --> Nothing related to the socket is shown
Expected behavior
Show the messages related to websocket communication.

I experience the same issue, here what I've seen in the browser console:
WebSocket error:
error { target: WebSocket, isTrusted: true, srcElement: WebSocket, eventPhase: 0, bubbles: false, cancelable: false, returnValue: true, defaultPrevented: false, composed: false, timeStamp: 1164, … }
TrafficViewer.tsx:138:16

Firefox can’t establish a connection to the server at ws://localhost:8899/ws. TrafficViewer.tsx:127:19

same for me.
It could be great to have it of by default have tcp connections


RT-577:6mo button stays selected after zooming

Overview
We use the onZoomStart on that, we ate removing the focus of the range selector
How it was tested
Tested using the run showcase app locally.
Checklist

[x] The title contains a short meaningful summary
[x] I have added a link to this PR in the Jira issue
[x] I have described how this was tested
[ ] I have included screen shots for changes that affect the user interface
[ ] I have updated unit tests
[x] I have run unit tests locally
[ ] I have updated documentation (including README)

we have created another PR for the RT-577 branch.


Abandon resource finders

Specifying the ResourceFinders as part of the resource definition was creating issues with overriding the resource finder methods such as records due to them getting added at the end of the ancestors chain (ahead of the overrides). ResourceFinders were an attempt allow for multiple ORM handling schemes without changing the resource class. In retrospect it was poorly conceived and I should have gone with a more traditional multi-class approach instead of mixins.
This PR is mostly moving code around to eliminate the resource finders, along with a minor addition of internal code to allow for multiple root resource classes to stand in for the resource finders functionality.
The BasicResource class replaces the features of Resource that were not part of the resource finders. Derived classes, such as ActiveRelationResource, combine the BasicResource with the methods from the resource finders.
Resource is now derived from ActiveRelationResource in order to provide for backwards compatibility. It is expected that additional resources supporting different ORMs will use different names, or override the Resource class's ancestor class.
When reviewing this it is easier to see the changes if the commits are viewed independently before trying to focus on the combined set of changes.
All Submissions:

[ ] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ ] I've submitted a ticket for my issue if one did not already exist.
[ ] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[ ] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.

New Feature Submissions:

[ ] I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
[ ] My submission includes new tests.
[ ] My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

[ ] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.

Test Plan:
Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

This looks a lot cleaner to me :100:
What do you think about renaming BasicResource to BaseResource? To my ears, "base" seems to fit the abstract class that it is (as opposed to "basic", which sounds like it could apply to something simple).

@dgeb I chose BasicResource as analogous to BasicObject, the parent object in ruby. I originally used BaseResource, but it conflicts with our project code and some of the examples that I’ve shared. Plus people should rarely encounter BasicObject.


Change safeApiCall params order

Would you accept a PR to make safeApiCall
 safeApiCall(errorMessage: String, call: suspend () -> Result<T>)
instead of  safeApiCall(call: suspend () -> Result<T>, errorMessage: String) so that the call param  can be placed outside the parentheses?
example of usage:
suspend fun getComments(ids: List<Long>) = safeApiCall(errorMessage = "Error getting comments") {
    requestGetComments(ids)
}

Florina replied to the same suggestion in the comments on her KotlinConf talk about Plaid 2.0:

We didn't like how it looked by putting first what should happen in case of error, and only then to put the call, which was the most important thing from that function.

The error shouldn't be the most important thing there, but rather the call!


deepin.deepin-editor: 6.0.11 -> 6.0.15

Description of changes

https://github.com/linuxdeepin/deepin-editor/compare/6.0.11...6.0.15
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 268954 run on x86_64-linux 1

1 package built:

deepin.deepin-editor


chore(release): Preparing for 3.1.0 release

Pull Request Test Coverage Report for Build 1018

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.33%

Totals

Change from base Build 1012:
0.0%

Covered Lines:
3081

Relevant Lines:
3449

💛  - Coveralls


Add Launch with DNAnexus button

Feature Request
Add a Launch with DNAnexus button, similar to Launch with FireCloud/DNAstack buttons.
Should only be present for WDL.
┆Issue is synchronized with this JIRA Story
┆Sprint: Lighthouse Sprint 30 Danns
┆Issue Number: DOCK-29
┆Epic: Aim 2: Cloud Execution Integration

@coverbeck can you confirm that this is for WDL?
I noticed that the precision FDA tools (note tools, not workflows) that were exported to Dockstore are in CWL.
https://dockstore.org/search?namespace=pfda2dockstore&searchMode=files
Do they have the ability to convert from arbitrary WDL to CWL?

@denis-yuen Confirmed that it is for WDL. I asked them on the call yesterday. They have their own infrastructure for compiling and running WDL.
The Precision FDA work is a separate effort.

@coverbeck do you have more clarity on their relationship? Feel free to bring this to Slack

➤ Charles Overbeck commented:
DNANexus currently supports file-path import statements, but does not yet support http(s) imports. But http(s) support is coming soon.

Weird, that's like the reverse of Firecloud
ex:  https://dockstore.org/workflows/github.com/HumanCellAtlas/skylab/HCA_SmartSeq2:dockstore?tab=info
Maybe we need symbols for the n choose 2 combinations

Update: DNANexus now supports both file-path and http(s) imports.

It's also possible they may not work with our staging environment. At one point they said that they would only work with whitelisted domains, and they had only whitelisted dockstore.org.
On the other hand, I think I saw it working with my local build, so that may not apply any more, but I will investigate.

I think #1023 might be part of problem; the link is now: https://platform.dnanexus.com/panx/tools/import-workflow?source=https://staging.dockstore.org:443/api/api/ga4gh/v2/tools/%23workflow%2F%2Fhaplotypecaller-gvcf-gatk4.wdl/versions/1.0.1
Notice how api is there twice.

In the dockstore-ui2/src/app/shared/constants.ts file, there's a '/api/ga4gh/v2' , yet the API_URI also has it

The repeated api is unfortunately legit (but can be changed).
Initially we had https://dockstore.org:8443/api/ga4gh/v2/metadata but in #1023 it turned out places were blocking 8443, so I added
https://staging.dockstore.org/api/api/ga4gh/v2/metadata (no port)

This means the TRS link on the info tab is incorrect as well (has two api).

(The info tab link it actually correct)
Consider https://staging.dockstore.org/api/containers/published?limit=100&sortCol=stars&sortOrder=desc for example, our endpoints are under api. What I didn't notice till after it was working was that the GA4GH api is namespaced using api so it looks doubled for those URLs

URL generated seems legit with
DockstoreAPI - 1.5.0-alpha.8
DockstoreUI - 2.2.0-alpha.6