[BUG]_cat/nodes return stale OpenSearch version after upgrades from ES 7.x/6.8

Describe the bug
With the BWC fix, done as part of this PR, the upgrades were happening smoothly. After the upgrades finishing, the _cat/nodes still return the 7.10.2 response as version even after the master switch to OS-1.0.0. This is gives a false information since the version is upgraded to OS-1.0.0.
To Reproduce

Create a cluster with 3 dedicated master node and 3 data nodes cluster.
Do upgrade to Opensearch 1.0.0
after upgrade try this hitting  _cat/nodes api

curl localhost:9200/_cat/nodes?h=node.role,version,master
imr 1.0.0  -
imr 1.0.0  -
imr 1.0.0  *
di  7.10.2 -
di  7.10.2 -
di  7.10.2 -

We need to then kill the process to get the current response from the _cat/nodes.
Expected behavior
curl localhost:9200/_cat/nodes?h=node.role,version,master
imr 1.0.0  -
imr 1.0.0  -
imr 1.0.0  *
di  1.0.0 -
di  1.0.0 -
di  1.0.0 -

the current hypothesis on why this happening
As part of fixing version compatibility with Elasticsearch nodes during upgrade (https://github.com/opensearch-project/OpenSearch/pull/775). The BWC version (7.10.2) is passed from 2 places 1. during transport handshake 2. discovery node -  the version is used when node is joining the master. Consider the below flow:

There is an ES cluster (6.8 <= version <= 7.10.2)
Now OpenSearch nodes join the cluster. As master is an ES node, they pass their version as 7.10.2 to master and it gets stored in in-memory cluster state (DiscoveryNodes).
Upgrade is finished and one of the OpenSearch master eligible node becomes the master.
At this point, as all nodes are OpenSearch, it is expected all APIs including _cat/nodes should return the version as 1.0.0
But this is not the case as reported above, This is due to the reason that when OpenSearch node became the master, it had the cluster state from ES node which was the master and had the version as 7.10.2 in the state for OpenSearch nodes as well. And the _cat/nodes API response is generated from cluster state.

The current workaround is to bounce the nodes and they will reconnect to the master and version will show up as 1.0.0 until this issue is fixed.

@nknize @dblock @itiyamas : Need your opinion on this -
While debugging this found another issue:
When Elasticsearch node is master (during upgrade), it returns the version as below
Elasticsearch is the master and rest call comes to Elasticsearch Node
sh-4.4# curl localhost:9200/_cat/nodes?h=ip,id,name,version,master
<IP_ADDRESS> roLY opensearch-1    7.10.2 -
<IP_ADDRESS> Ez1X opensearch-3    7.10.2 -
<IP_ADDRESS> AWIm elasticsearch-2 7.9.0  *

Elasticsearch is the master and rest call comes to OpenSearch Node
sh-4.4# curl localhost:9200/_cat/nodes?h=ip,id,name,version,master
<IP_ADDRESS> roLY opensearch-1    7.10.2 -
<IP_ADDRESS> Ez1X opensearch-3    7.10.2 -
<IP_ADDRESS> AWIm elasticsearch-2 7.9.0  *

It will be full BWC mode.
Now, consider OpenSearch node has become master, should we let Elasticsearch nodes connect to OpenSearch master or not. In order to let Elasticsearch node continue to connect to it, OpenSearch master will have to send BWC version (7.10.2) to ES nodes for all OpenSearch nodes in the cluster and API responses will look like below:
OpenSearch is the master and rest call comes to any OpenSearch node:
sh-4.4# curl localhost:9200/_cat/nodes?h=ip,id,name,version,master
<IP_ADDRESS> roLY opensearch-1 1.0.0 *
<IP_ADDRESS> Ez1X opensearch-3 1.0.0 -
<IP_ADDRESS> AWIm elasticsearch-2 7.9.0 -

OpenSearch is the master and rest call comes to Elasticsearch Node
sh-4.4# curl localhost:9200/_cat/nodes?h=ip,id,name,version,master
<IP_ADDRESS> roLY opensearch-1 7.10.2 *
<IP_ADDRESS> Ez1X opensearch-3 7.10.2 -
<IP_ADDRESS> AWIm elasticsearch-2 7.9.0 -

If the above APIs are ok, then we will need to call out explicitly, so that this doesn't cause any confusion. Other option is to prevent Elasticsearch node from connecting to OpenSearch node altogether which could be more disruptive but no such confusion. I want all of your opinion on this.

I agree that it would be disruptive if ES nodes can't connect to OpenSearch master. That feels like a broken system.
Are you proposing that _cat/nodes return different things depending on who you ask? That seems odd to me, as you already point out. In bwc mode, what are the reasons not to always return the bwc version across the board, then turn the mode off once everything is rolled over to OpenSearch?

Thanks @dblock for taking a look.

I agree that it would be disruptive if ES nodes can't connect to OpenSearch master. That feels like a broken system.

Normally, the expectation is that user upgrades the non master eligible nodes first and then master eligible nodes, so that in case of incompatibility there are no issues as much as possible. From Elasticsearch documentation as well
"Upgrading the nodes in this order ensures that the master-ineligible nodes are always running a version at least as new as the master-eligible nodes. Newer nodes can always join a cluster with an older master, but older nodes cannot always join a cluster with a newer master."
Having said that yes not allowing nodes to connect is very disruptive and should be the last resort.

Are you proposing that _cat/nodes return different things depending on who you ask? That seems odd to me, as you already point out, but not necessarily bad.
In bwc mode, what are the reasons not to always return the bwc version across the board, then turn the mode off once everything is rolled over to OpenSearch?

The issue is that there is no definite way to say everything is rolled over to OpenSearch as customer can choose to use rolling upgrade or B/G deployment. There is an option to identify if the master is OpenSearch node and there are any Elasticsearch nodes in the cluster or not. In case there are no Elasticsearch nodes, the OpenSearch node can switch off the BWC mode but this is not reliable as Elasticsearch nodes could disconnect temporarily and join back. At this point, we end up with 2 options:

Return different responses from _cat/nodes, this ensure that Elasticsearch nodes can still join the cluster
Or, prevent Elasticsearch nodes from joining the cluster altogether.

I see the problem @shwetathareja. Thinking of (2), is there a failure case in a network partition where master thinks it has upgraded, prevents all ES nodes from joining, then another node re-appears and can no longer connect? Maybe there should be an actual API that says "starting upgrade" (which does all the things that we document such as flushing data, etc.) and "I'm done upgrading". The latter would do (2).
I think for 1.0 I'd just continue doing (1).

I see the problem @shwetathareja. Thinking of (2), is there a failure case in a network partition where master thinks it has upgraded, prevents all ES nodes from joining, then another node re-appears and can no longer connect? Maybe there should be an actual API that says "starting upgrade" (which does all the things that we document such as flushing data, etc.) and "I'm done upgrading". The latter would do (2).

Yes, not just during network partition, consider few data nodes running high on JVM and got disconnected and master switched to OpenSearch node and now these data will not be able to connect to OpenSearch node (2). Yeah, we can think of providing an upgrade API. The current work around the user can do is to put the OpenSearch masters in voting config exclusion, that ensures they never become the master until the exclusion is removed. This is an external control which can be used by the user during upgrade.

I think for 1.0, short of an upgrading API, I'd just continue doing (1).
I think that refreshing nodes after OpenSearch becomes master is OK and the network partitioning scenario can be ignored because in that case the node would not be master, and you would just upgrade that node that came back, and call it a day.

The current fix in Draft PR is to refresh the version as soon as OpenSearch node becomes master. Also the confusion in API response only arises if that Elasticsearch node that has come up will serve actual requests.

fixed by #865


844/Entry age filter

For issue 844 raised by Charlie about entry ages. @stephmarisa and I think we got something functional for the entry age filter. Not completely ready for code review. Can someone help us decide whether or not we should use a less than logic (i.e. all entries within 1 week, within 2 weeks...) or a price range selector by Albert (i.e. entries with entry age between 1-7. 8-14...)?

From our needs dataset, the vast majority will not be in the 1 week range. I still think integrating @4kbt's original as:

this week
two week ago (including 1 week entries)
this month (including 1 week and 2 week entries)
all (default)
makes sense because otherwise you won't see very many pins.

Or, if you want to keep the ranges you've set, please allow multi-select support. Right now when you selected "2 weeks" "3 weeks" and "1 week" pills, the "1 week" filter is set to supercede/trump all other logic :)

@stephmarisa @zhuochenwang do you guys want to try either the <7d, <14d, <30d or 1-7, 8-14, 15-21, 21+ price range logic with multiselect and see where you land? The first solution seems easier as a first past to get this up for people to use ASAP. The second solution can be a v2 on this filter menu and allow people more specific entry age control :)

@linderr I think we might go with the first options but change so it's this week, two weeks ago, and this month as Charlie suggested. Later on, we can work on the v2 of the logic with multi-select and price ranges.

If your logic is <7, <14, <30 days you don't need multi-select because <14 would include <7 :)

Sounds good, we will get on it later today/early tomorrow!

Defining multiselect is kinda weird using Selectr and interferes with clearing filters and other things... So I might just try to implement v2 since that will be the final version we are aiming to publish.

Ah I get it now, @linderr was recommending the multi-select version as the "phase 2" which you just did as phase 1 instead. that's fine!

@ngottlieb Hey nick, thanks for looking at the code. First time using the array.some() method which was interesting. I realized having to make one of the Selectr objects not multi-selectable might take more work for something we will eventually replace so I went ahead and did v2 of the filter. I also fixed the bug I mentioned on slack about the filters having an additional blank option that was due to the placeholder.

@zhuochenwang :+1: 🚢
@linderr anything else on this you're wanting to see? Looks good to me. @4kbt may also have some input?

Nice work @zhuochenwang & @stephmarisa ! 🎉 LGTM @ngottlieb 👍
I'll ping @4kbt on Slack to let him know this is uppppp!! OSMS will also be satisfied, only a few more requests to go 😅

Oops! I was too trigger happy --- just realized we missed adding an i18n tag for the filter and options :) @zhuochenwang @stephmarisa @ngottlieb

@zhuochenwang @stephmarisa would you guys like to do the honours for posting the Issue to add onto your GitHub contributions count? Here's a visual example:


Ctrl + S not working (on Mac)

When hovering the save button a tooltip Ctrl + s is shown, but this hotkey does not work on mac.

Hi @tavurth
I can't support Mac properly at the time (sorry for inconvenience;)
But it might be a manifestation of some Godot v3.2 issues with cross-platform keybindings such as this one:
https://github.com/godotengine/godot/pull/43662
The problem might be solved thanks to the new Godot updates (v3.4.x) which include a lot fixes and back-ported features from v4; Please update to new releases and check if it works.
P.S:
Just for the record. Currently, Mac users build their Arrow themselves. Configuring the Input Map if the problem remains, seems like an additional step to the process for the time being.


Update pom.xml

Can one of the admins verify this patch?

test please

test please

test please


[Node.js] fatal error: third_party/nanopb/pb.h: No such file or directory

Travis is failing to install grpc@master correctly: https://travis-ci.org/GoogleCloudPlatform/gcloud-node/jobs/118542656#L316
make: Entering directory `/home/travis/build/GoogleCloudPlatform/gcloud-node/node_modules/grpc/build'
  CC(target) Release/obj.target/grpc/src/core/census/grpc_context.o
  CC(target) Release/obj.target/grpc/src/core/census/grpc_filter.o
  CC(target) Release/obj.target/grpc/src/core/census/grpc_plugin.o
  CC(target) Release/obj.target/grpc/src/core/channel/channel_args.o
  CC(target) Release/obj.target/grpc/src/core/channel/channel_stack.o
  CC(target) Release/obj.target/grpc/src/core/channel/channel_stack_builder.o
  CC(target) Release/obj.target/grpc/src/core/channel/client_channel.o
  CC(target) Release/obj.target/grpc/src/core/channel/compress_filter.o
  CC(target) Release/obj.target/grpc/src/core/channel/connected_channel.o
  CC(target) Release/obj.target/grpc/src/core/channel/http_client_filter.o
  CC(target) Release/obj.target/grpc/src/core/channel/http_server_filter.o
  CC(target) Release/obj.target/grpc/src/core/channel/subchannel_call_holder.o
  CC(target) Release/obj.target/grpc/src/core/client_config/client_config.o
  CC(target) Release/obj.target/grpc/src/core/client_config/connector.o
  CC(target) Release/obj.target/grpc/src/core/client_config/default_initial_connect_string.o
  CC(target) Release/obj.target/grpc/src/core/client_config/initial_connect_string.o
  CC(target) Release/obj.target/grpc/src/core/client_config/lb_policies/load_balancer_api.o
In file included from .././src/core/client_config/lb_policies/load_balancer_api.h:40:0,
                 from ../src/core/client_config/lb_policies/load_balancer_api.c:34:
.././src/core/proto/grpc/lb/v0/load_balancer.pb.h:38:35: fatal error: third_party/nanopb/pb.h: No such file or directory
compilation terminated.

The direct cause of this failure is that the third_party/nanopb is a git submodule, and npm does not clone submodules when installing a package from GitHub. More generally, we use submodules to track dependencies that are commonly not already installed on users' machines. Nanopb will be the first such submodule that the Node package depends on unconditionally, and that currently means that you cannot have an npm dependency on the master branch of the GitHub repository.
In the future, if there is a significant need to have that dependency, it may be possible to make it work.

Okay, thanks for the info. We've been using v0.13, but in implementing support for the upcoming Datastore v1beta3 API (pr), we need some of the changes that have been merged since (namely, #5005 & #5006).
I saw that v0.13.1-pre is available on npm, and it seemed to work locally with the changes we need for the Datastore PR. However, it has some unwanted logging output that must have since been corrected (related: #5967), because installing from master did not output the same logs.
Are there plans for cutting a new release in the near future?

0.13.1 has now been released

Thanks!

I'm facing this issue when using Bazel build for Android x86 on GRPC 1.0.0

I have the same issue when I grab the zip file for grpc 1.0.0 -- the nanopb directory there is empty, but I'm not sure which version of nanopb corresponds to the grpc 1.0.0 file... ?


Use dev qs to load old qs files.

Addresses the first bullet of #125.

@jwildfire This is as much work as I did on the qs thing, as part of some exploration to get gsmApp working locally.


Passing custom headers to rpc

I want to pass custom headers to the rpc call, along with the auth headers.
I've digged in the source code and the implementation seems trivial.

You mean params?

No. The rpc call gets converted to an HTTP Post request, with the params in its body. I'm talking about the headers of that request.

@CodingSoot That is an interesting use case. Could I ask for more details on what you are trying to achieve ultimately here?

@CodingSoot Thanks for sharing your use case.
I am not sure if we want to add a option to set a custom headers on rpc call at the moment.
You can instead have custom backend, which will take care of calling app check endpoints and if the verification success, you can call rpc() from the backend with your Supabase service role key.
By default, rpc() functions are exposed, so you may want to edit the execute permissions on it so that anon key users cannot call it.
Let me know what you think about this workaround!

@dshukertjr May I ask why not? Because the js SDK doesn't support it?

@Vinzent03 Yeah, that is the main reason. What do you think about it? Should we consider adding it?
For this particular use case though, since there is already cloud function being used to verify the token, I thought it might be better to let the cloud functions handle the verification process.
BTW @CodingSoot do you not want to protect your other Postgrest routes like select() and insert()? Or is the plan to handle all of them in rpc()?

You can instead have custom backend, which will take care of calling app check endpoints and if the verification success, you can call rpc() from the backend with your Supabase service role key.

If I want to call rpc() as if the client made the request, I can use setAuth() in the backend before making the call, right ?

BTW @CodingSoot do you not want to protect your other Postgrest routes like select() and insert()? Or is the plan to handle all of them in rpc()?

For now, I'm planning to handle of them in rpc(), but I guess it would be useful if other Postgrest routes were protected too.

@CodingSoot

If I want to call rpc() as if the client made the request, I can use setAuth() in the backend before making the call, right ?

Yup, but if you expose the RPC so that with the same permissions as the client can call them, then wouldn't that defeat the whole purpose of hiding it behind a backend to perform app check?

For now, I'm planning to handle of them in rpc(). I guess it would be useful if other Postgrest routes were protected too, but how would you verify the tokens then?

I believe there is no way to protect Postgrest routes, and that was why I asked the question!

Yup, but if you expose the RPC so that with the same permissions as the client can call them, then wouldn't that defeat the whole purpose of hiding it behind a backend to perform app check?

Of course... I was hoping there would be a way to benefit from the RLS features with this setup. I guess the advantage of calling rpc from the client with a custom header is that we can have the rpc security set to "invoker", and thus benefit from RLS.

I believe there is no way to protect Postgrest routes, and that was why I asked the question!

Then protecting rpc would be more than enough, as we can use it for all sensitive operations.

@CodingSoot
I think I came up with a pretty good solution!
You could create your own extension method like this to create your own customRPC call. This pretty much does the same thing as the native rpc function with a custom header!
extension on SupabaseClient {
  dynamic customRpc(
    String fn, {
    required Map<String, String> customHeaders,
    Map<String, dynamic>? params,
  }) {
    final headers = <String, String>{...customHeaders};
    final authBearer = auth.currentSession?.accessToken ?? supabaseKey;
    headers['apikey'] = supabaseKey;
    headers['Authorization'] = 'Bearer $authBearer';

    final rest = PostgrestClient(
      restUrl,
      headers: headers,
      schema: schema,
    );
    return rest.rpc(fn, params: params);
  }
}

That's amazing, thanks !

Closing this for now as a workaround has been introduced, but feel free to reopen it whenever anyone feels is appropriate.

@dshukertjr - silly question, but where/how would that workaround be made. like - what language is that in? what file? what executes it?

@tonypee Feel free to open an issue on the js repo for any questions regarding the js library.

We did it btw: https://github.com/supabase/postgrest-js/pull/550

Now possible with .setHeader()


Clintox 3d conformation data seemly have something wrong

Clintox data https://unimol.dp.tech/data/finetune/molecular_property_prediction.tar.gz 中 test.lmdb, train.lmdb and valid.lmdb 的 target键对应的值格式好像不对，在计算损失时会报错。

目前格式为

相似任务的BACE数据格式为

报错信息为

Since ClinTox has two independent prediction tasks, there are two labels, while BACE has only one task.
Specifically, during training, the losses of the two are different, which can be referred to in the molecular property prediction section in Readme.

You're right. Sorry for my carelessness. Thanks

Thanks for your interest in our work :)


Add basic readme

Just the facts. Happy to add/edit/remove anything.

Thanks again! :slightly_smiling_face:


WRONG LINK!

Hello Twemoji,
in your jquery link i replaced "//twemoji.maxcdn.com/" with "//abs.twimg.com/emoji/v2/" from twitter and set the size to 72x72 and now I dont have any errors with the latest smileys :+1:
Hope you will fix this soon! (I had errors with 🤐 the smiley with the zapper as mouth)
also... your link is down or something, so I checked cdnjs.com for the link. Found https://cdnjs.cloudflare.com/ajax/libs/twemoji/2.0.5/twemoji.min.js < this one. But it had errors as I explained before
additionally: changing the link will not be enough because the regex only checks for valid unicodes. so you need to copy the emojicons that dont work and throw it in a javascript escape or online unicode decoder or create your own.
have a nice day

which jquery link? mind to file a PR instead?


Compilation error on a 32-bit operating system

What happened: When I tried to compile the client on a 32-bit operating system, I encountered an integer overflow error. Is there a plan to support running on a 32-bit system?

What you expected to happen: "I hope to be able to use this excellent software on a 32-bit system."
How to reproduce it (as minimally and precisely as possible):  To reproduce the issue, simply perform the compilation operation on a 32-bit Windows 10 system.
Anything else we need to know?
It appears that the error is occurring in the "consistenthash" and "tikv" dependencies referenced in the project.
Environment:

JuiceFS version (use juicefs --version) or Hadoop Java SDK version: main

Cloud provider or hardware configuration running JuiceFS:   Deploy it myself.

OS (e.g cat /etc/os-release):   windows10  32-bit

Kernel (e.g. uname -a):

Object storage (cloud provider and region, or self maintained):

Metadata engine info (version, cloud provider managed or self maintained):

Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):

Others:

There’s no plan to support it for now.

@hjx44599 Can you try to build with -tags notikv ?


 onLoad event spec

Description

Hello!
I was using <ImageBackground> for bg image, and trying to get properties of a loaded image for debugging purpose. What I have found out is the different spec of the onLoad event argument.
The doc says it should be:
function(ImageLoadEvent) => void

Where ImageLoadEvents is an object with props width, height and url.
But I'm getting a Synthetic Event instance, and those props actually are inside .nativeEvent.source property. For me it looks similar to Image#onError event. So I think that the spec of onLoad event should be changed.
Documentation version
0.64

I'm not sure, but it looks like it still requires the community's attention.


Searching with F1 or Ctrl+F1 doesn't fire when caret is at the end of a word

read.csv|  <- we need to include end

https://github.com/Microsoft/RTVS/commit/f1d0a4d931aa23970a69aba66b8f4b6748449c20


Using released versions of runner images?

The pipelines in this repo use the main-branch version of the runner-images repository to get the scripts for the various image-types.
If I'm not mistaken this main-branch is where all development is happening and this is regularly being formed into a (pre-)release. If this is correct, wouldn't it be better to only use the released versions of the runner-images?

Your understanding is correct. And yes, it would be better and more stable to checkout the latest release of each specific image type/version. This has been on my radar for a while, but I have yet to investigate and figure out how to fetch the latest release tag for an image type and then checkout that specific tag.
The second part is easy, but the first doesn't seem that straightforward. If you have any suggestions, I'll happily take them.


How to test ActionText components?

I know this isn't the correct place for this but I am honestly not sure where else to ask at the moment. I can't figure out how to possibly test ActionText components using RSpec. I tried posting about this on StackOverflow here https://stackoverflow.com/questions/57319708/how-to-test-actiontext-using-rspec but haven't had any luck at all so far. Is this currently supported by RSpec 3?

All of our Rails 6 support is in the 4-0-dev branch, and won't be backported to 3 due to the fact we're changing our release cycle to match rails, and releasing new major versions supporting the versions of rails that are, er, supported :joy:
I'm not sure if anyone has added actiontext support yet but thats where it'd be, @samphippen any ideas?

@mhoad Sorry for the delay. Are you still stuck? I don't think there is support at the moment

FWIW, any kind of active_storage support is probably going to have similar questions about ActiveStorage::Blobs (and action_text about ActionText::RichText) so it'd be good to have a plan for handling those consistently.
https://github.com/rspec/rspec-rails/pull/2119#pullrequestreview-233742463


Add .add_edge_unchecked method, for adding an edge without checking for cycles.

This might be useful for performance critical occasions where the user knows for certain that adding an edge would not create a cycle.

Going to avoid adding this until a case occurs where it's absolutely necessary.


Added CDI Example for #386

This is a demonstration for https://github.com/openzipkin/brave/issues/386 using CDI and Eclipse MicroProfile REST and Config APIs.
Please see the Producer and JUnit tests in particular.

sorry I dropped the ball on this. let me know if you plan to do a cleanup round or if I should on your behalf!


Align the Variant data member

This should avoid potential alignment issues when _mem holds real
values and speed up some floating point operations in some cases.

the code is a tad messy because of clang-format. For 3.2 we'll replace this with standard c++11 alignas and the ugliness will go away.

Thanks!

@hpvb You forgot to update the comment on line 120/127 (line 123 on current master).


Add some extra features and fixed somes bugs

now you can see the remaining time for torrent download.

And also you can also see how many percentage of files you have downloaded, which files are downloaded and which ones are left to do.
Also I fixed the bug concerning the download for example
the command :
peerflix "torrent.torrent" --list

When you click on ctrl+c it is impossible to stop the script.

:)


Support right-to-left layout on Windows

What kind of change does this PR introduce?

This PR adds support for setting right-to-left layout on Windows using the WS_EX_LAYOUTRTL extended style and others. My main use for this is to make menus appear to the right in an Arabic app. I plan to add support for this to Tauri.

[ ] Bugfix
[x] Feature
[ ] Docs
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Checklist

[ ] This PR will resolve #___
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[x] I have added a convincing reason for adding this feature, if necessary
[x] It can be built on all targets and pass CI/CD.

Other information

Let's make this platform-specific method if this is only for Windows.

It should be possible to implement on Linux and macOS at least. I'll need macOS support in my app in the future so I might add that too then (currently don't have the time to investigate it and want to get Windows support merged as soon as possible).
Will make it a platform-specific method and add a .changes file.

Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed.

Actually signed off the first commit and then forgot to sign the rest. Should be fine now I guess.


Change the design of the About us page.

You can change the design of about us page according to you and which looks good. You can also try by making cards and divide the same content into cards.
You can take reference from about us section from here (https://in.pinterest.com/pin/415738609355792449/)

maybe @vipul-rajput forgot this task, i'll do it

see my pull req.


What kind of repositories are supported?

This lib seems to work with Maven repos only. Would be nice to have this explicitly stated in the docs.

You're probably right. Feel free to send a PR


[loc][query] Translation question.

Description

IMPORTANT: if the defect is reproduced only in a workflow from within the Visual Studio IDE then do not report the issue here - instead, please report it using Visual Studio's "Send Feedback" option that can be accessed from the Help menu OR using this link https://developercommunity.visualstudio.com.
For a defect reproducable from the vstest command line, describe the issue you've observed.

File: Microsoft.TestPlatform.Extensions.TrxLogger\Resources\xlf\TrxResource.xlf:
String: Cannot get find an available filename for {0} using timestamp format '{2}' at {1}.
String ID: 0; "Common_CannotGetNextTimestampFileName"
Question: Please clarify all placeholders, thank you.
Steps to reproduce

What steps can reproduce the defect?
Please share the setup, commandline for vstest.console, sample project, target
framework etc.

Expected behavior

Share the expected output

Actual behavior

What is the behavior observed?

Diagnostic logs

Please share test platform diagnostics logs. Instructions to collect logs are here.
The logs may contain test assembly paths, kindly review and mask those before sharing.

Environment

Please share additional details about the test environment.
Operating system, Build version of vstest.console

Hi,

Placeholder
Name
Example

{0}
fileName
log.txt

{1}
directoryName
c:\data

{2}
timestampFormat
_yyyyMMddHHmmss

Resource string is used in:
https://github.com/microsoft/vstest/blob/de02d84384541d2fe423720abf6a4ce9d0f97ffc/src/Microsoft.TestPlatform.Extensions.TrxLogger/Utility/TrxFileHelper.cs#L180


Add emitter configuration support to remote configuration

Enable configuring relevant parts of the emitter configuration using remote configuration. The properties of interest would be:

bufferOption
emitRange
threadPoolSize
byteLimitGet
byteLimitPost
customRetryForStatusCodes
serverAnonymisation

These are already available in the 1-0-1 schema for the remote_config.

Thanks for creating this issue. Don't forget to also make these options available in the default configuration that can be used to set up the tracker before the remote config was loaded.


relation checkdecreased protein localization to heterochromatin during vegetative growth

decreased protein localization to heterochromatin during vegetative growth

in canto currently
decreased protein localization to heterochromatin during vegetative growth
has the child
decreased protein localization to heterochromatin during vegetative growth

FYPO:0002385 decreased protein localization to heterochromatin during vegetative growth
FYPO:0002909 decreased protein localization to heterochromatin during vegetative growth

ignore

FYPO:0002909 is plain chromatin, not heterochromatin


incorrect parentage "sister chromatid biorientation"

"mitotic sister chromatid biorientation"
should be a descendant of
mitotic GO:0007080 mitotic metaphase plate congression
(currently  this is only a child of metaphase plate congression)

By what relation?

sorry part_of
same as
http://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0031134#term=ancchart&chartTab=settings
just needs moving down

Doesn't obviously follow from definition.  Should probably extend the definition of congression to make it clear that one encompasses the other.
mitotic metaphase plate congression: "The cell cycle process in which chromosomes are aligned at the metaphase plate, a plane halfway between the poles of the mitotic spindle, during mitosis."
"mitotic sister chromatid biorientation": The cell cycle process in which mitotic sister chromatids establish stable attachments to microtubules emanating from opposite spindle poles.
part_of some 'mitotic metaphase plate congression'
Looks like  #12244 relevant.

See #12244  for fix.


[Bug]: The old style of linking to API docs from pages is broken

Plugin
@knodes/typedoc-plugin-pages
Typedoc plugin(s) version(s)
0.23.1
Typedoc version
0.23.8
Describe the problem
In the old pages plugin<EMAIL_ADDRESS>you could link to "objects" like classes etc in the API docs from pages like so [[Clazz | clazz]] but that seems like it is not supported anymore? Are there plans to support this in the future? If not, what is the suggested approach to specify these links besides providing the path to the generated docs like so [clazz](../classes/framework_Clazz.Clazz.html).
What did you expected ?
I expect [[Clazz | clazz]] to link to the Clazz in the generated docs

Typedoc now uses {@link Class} notation. See the typedoc documentation: https://typedoc.org/tags/link/

Thanks for getting back, I had tried the new link format and that wasn't working either with any of the entry point strategies.
For now I have a hack that resolves the issue, posting my solution here for posterity sake. If anyone has a better alternative please chime in.
My project is a module and it only has the public API exported in the index file and that appears to be the issue because typedoc is unable to resolve links if I don't export all the types in every folder in the index file, so I ended up generating an index file in every folder before I run typedoc and I delete it after. That's the only way I could get it to work.

Yeah indeed, typedoc collects symbols from your package entrypoint. This is somewhat understandable: API doc is mainly for 3rd party devs; why would they need to see internal symbols that are never used outside ? Using a secondary entrypoint for docs only can be indeed a good solution to be more explicit about what to put in documentation; yet, if user can see the symbol somehow from their code, like a typedef, they might be able to import it.
If you consider this issue not requiring more information, I invite you to close it. Thanks for the hint ;)


feat: add new section: to hide "Play your own games"

Add new section to hide "Play your own games". refer to reques #567
The screenshoot:

and this is the result:

Thank you, but I have plan to implement this feature differently


Attaching carts to horses to pull???

How do you attach horses to carts? The action key isn't working for it.

You ride a horse and then use the action key with a cart close by.

I have done this many times and it still doesn’t work. Even uninstalled and reinstalled the mod. (May be my sleep deprived self though lol)

Have you touched the config?

No I have not. Do I need to? :?

So I've figured out my problem. Regular horses work but the horses from Realistic horse genetics do not work.

Yes those need to be added to configuration unless you're using the latest 1.16 releases which then they should automatically work.

I'm using 1.15.2 How would I add them? Like the title????? If that makes sense. ^^'

Edit the astikor carts config file and add horse_colors:horse_felinoid to the lists of entities that can pull the carts.

Thank you!


GPU Support

Hi,
is there currently a way to create a GPU machine on GCP via the go cloud sdk? (because I couldn't find anything)
Regards,
Andreas

See the AcceleratorTypes service and the Instance.GuestAccelerators property. Also see
https://cloud.google.com/compute/docs/gpus/add-gpus#create-new-gpu-instance.


Adds ability to use multiple classes in view macro using array syntax.

Adds array syntax to the fancy class name syntax in the view macro for multiple classes to be controlled by the same class attribute.
e.g.
#[component]
fn App() -> impl IntoView {
  let (classes, set_classes) = create_signal(true);

  view! {
    <div
      class=(["class-1", "class-2"], classes)
    >
      <button
        on:click=move |_| set_classes(!classes)
      >
        Toggle
      </button>
    </div>
  }
}

Compared to the current style which requires creating a new class attribute for each class.
e.g.
#[component]
fn App() -> impl IntoView {
  let (classes, set_classes) = create_signal(true);

  view! {
    <div
      class=("class-1", classes)
      class=("class-2", classes)
    >
      <button
        on:click=move |_| set_classes(!classes)
      >
        Toggle
      </button>
    </div>
  }
}

This can be especially useful when using styling systems like Tailwind.
This was discussed in #2522.

Another route to go on this would be to use the current syntax, but split the class string at spaces.
e.g.
<div
  class=("class-1 class-2", true)
>
</div>

I like the array syntax a lot, and it seems to work in my testing. Thanks for this!


can we have a commnd to clear the porject cache ?

i dont think the reindex command actually re-index the whole project from scratch, rather it caches new files only.
this is helpfull incase u changed something from the config, ex. removing/adding from container.extension_classes

you can phpactor index:build --reset but adding a command to do that should be fairly simple:
https://github.com/phpactor/vscode-phpactor/blob/master/src/extension.ts#L118
adding a new command reindex (hard) or similar:
languageClient.sendRequest('indexer/reindex', {"soft": false});

i can make a PR with that logic if u want.

btw i think the LS should be restarted afterward, ex. changeing worse_reflection.stub_dir then runing the phpactor index:build --reset from the project path, doesnt update the LS until u restart the editor.

you don't have to restart the editor, Reload window from the command palette will restart the LSP server.

no, you will always need to restart the LSP after changing the config.
500 is the number of stub files - you'd see that if you were running index in a folder with no PHP files (or if it couldn't find any PHP files)

no, you will always need to restart the LSP after changing the config

maybe we can add executeCommand('workbench.action.reloadWindow') after languageClient.sendRequest('indexer/reindex', {"soft": false}); has finished.

you'd see that if you were running index in a folder with no PHP files (or if it couldn't find any PHP files)

actually i see it all the time regardless, whether i ran Phpactor: Re-index workspace or phpactor index:build --reset from the project root path which has multiple php files ex._ide_helper.php


More issues in tests

New issue as it's yet another issue with tests.
I built a few times in @fabxc 's branch and just got:
>> formatting code
>> building binaries
 >   prometheus
 >   promtool
>> running tests
?   	github.com/prometheus/prometheus/cmd/prometheus	[no test files]
?   	github.com/prometheus/prometheus/cmd/promtool	[no test files]
ok  	github.com/prometheus/prometheus/config	0.068s
ok  	github.com/prometheus/prometheus/notification	0.229s
ok  	github.com/prometheus/prometheus/promql	3.331s
ok  	github.com/prometheus/prometheus/retrieval	1.646s

SIGQUIT: quit
PC=0x45fd41 m=0

goroutine 0 [idle]:
runtime.futex(0xe7c1f0, 0x0, 0x0, 0x0, 0x0, 0xe7b800, 0x0, 0x0, 0x40e1d4, 0xe7c1f0, ...)
	/usr/lib/go/src/runtime/sys_linux_amd64.s:288 +0x21
runtime.futexsleep(0xe7c1f0, 0x0, 0xffffffffffffffff)
	/usr/lib/go/src/runtime/os1_linux.go:39 +0x53
runtime.notesleep(0xe7c1f0)
	/usr/lib/go/src/runtime/lock_futex.go:142 +0xa4
runtime.stopm()
	/usr/lib/go/src/runtime/proc1.go:1136 +0x112
runtime.findrunnable(0xc82001a000, 0x0)
	/usr/lib/go/src/runtime/proc1.go:1538 +0x69e
runtime.schedule()
	/usr/lib/go/src/runtime/proc1.go:1647 +0x267
runtime.goexit0(0xc8201d0300)
	/usr/lib/go/src/runtime/proc1.go:1773 +0x1a2
runtime.mcall(0x7ffe214019d0)
	/usr/lib/go/src/runtime/asm_amd64.s:204 +0x5b

goroutine 1 [chan receive]:
testing.RunTests(0xc1c558, 0xe77000, 0x7, 0x7, 0xc820017801)
	/usr/lib/go/src/testing/testing.go:562 +0x8ad
testing.(*M).Run(0xc8200b9ee8, 0xc1ea60)
	/usr/lib/go/src/testing/testing.go:494 +0x70
main.main()
	github.com/prometheus/prometheus/retrieval/discovery/_test/_testmain.go:66 +0x116

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
	/usr/lib/go/src/runtime/asm_amd64.s:1721 +0x1

goroutine 39 [chan send]:
github.com/prometheus/prometheus/retrieval/discovery.(*MarathonDiscovery).updateServices(0xc820167f18, 0xc82017c420, 0x0, 0x0)
	/home/richih/work/go/src/github.com/prometheus/prometheus/retrieval/discovery/marathon.go:80 +0x118
github.com/prometheus/prometheus/retrieval/discovery.TestMarathonSDSendGroup(0xc820198360)
	/home/richih/work/go/src/github.com/prometheus/prometheus/retrieval/discovery/marathon_test.go:114 +0x234
testing.tRunner(0xc820198360, 0xe77048)
	/usr/lib/go/src/testing/testing.go:456 +0x98
created by testing.RunTests
	/usr/lib/go/src/testing/testing.go:561 +0x86d

rax    0xca
rbx    0x0
rcx    0x45fd43
rdx    0x0
rdi    0xe7c1f0
rsi    0x0
rbp    0x1
rsp    0x7ffe21401828
r8     0x0
r9     0x0
r10    0x0
r11    0x286
r12    0x3
r13    0xc18c8c
r14    0x55555555555555
r15    0x38
rip    0x45fd41
rflags 0x286
cs     0x33
fs     0x0
gs     0x0
*** Test killed with quit: ran too long (10m0s).
FAIL	github.com/prometheus/prometheus/retrieval/discovery	600.013s
?   	github.com/prometheus/prometheus/retrieval/discovery/kubernetes	[no test files]
?   	github.com/prometheus/prometheus/retrieval/discovery/marathon	[no test files]
ok  	github.com/prometheus/prometheus/rules	0.185s
?   	github.com/prometheus/prometheus/storage	[no test files]
ok  	github.com/prometheus/prometheus/storage/local	27.385s
ok  	github.com/prometheus/prometheus/storage/local/codable	0.012s
?   	github.com/prometheus/prometheus/storage/local/index	[no test files]
ok  	github.com/prometheus/prometheus/storage/metric	0.011s
ok  	github.com/prometheus/prometheus/storage/remote	0.059s
ok  	github.com/prometheus/prometheus/storage/remote/graphite	0.015s
ok  	github.com/prometheus/prometheus/storage/remote/influxdb	0.024s
ok  	github.com/prometheus/prometheus/storage/remote/opentsdb	0.054s
ok  	github.com/prometheus/prometheus/template	0.119s
?   	github.com/prometheus/prometheus/util/cli	[no test files]
ok  	github.com/prometheus/prometheus/util/flock	0.056s
?   	github.com/prometheus/prometheus/util/httputil	[no test files]
?   	github.com/prometheus/prometheus/util/stats	[no test files]
ok  	github.com/prometheus/prometheus/util/strutil	0.011s
?   	github.com/prometheus/prometheus/util/testutil	[no test files]
?   	github.com/prometheus/prometheus/util/treecache	[no test files]
?   	github.com/prometheus/prometheus/version	[no test files]
ok  	github.com/prometheus/prometheus/web	0.034s
ok  	github.com/prometheus/prometheus/web/api/legacy	0.116s
ok  	github.com/prometheus/prometheus/web/api/v1	0.093s
?   	github.com/prometheus/prometheus/web/ui	[no test files]
Makefile:29: recipe for target 'test' failed
make: *** [test] Error 1

The code that throws up here has been touched quite a lot recently.
@RichiH Is this still happening?

I am having issues with the local hardware, I hope to get those fixed over the weekend...

This deadlock seems to be the consequence of issues several SD implementations are suffering from for a while now. They are sending on channels for which the consumer may disappear at any time. They must detect that by listening on <-context.Ctx.Done() (formerly simply <-done) simultaniously and everywhere.

@fabxc I believe you've resolved these?

Yup


Check for mesh tangling

It would be good to have a utility function for checking if a mesh has tangled and to do something when it happens. This could be raise an error, raise a warning or call a de-tangler/remesher, depending on user inputs.

Reolved by #10.


SP5: IPlotControl needs GetCoordinates()

Controls should have these helper methods.
They should be aware of DPI scaling too (#2760)
Note that most of this functionality already exists by interacting with the Plot itself, but it's not aware of DPI scaling.
formsPlot1.MouseMove += (s, e) =>
{
    // pixel-to-coordinates
    Coordinates coordinates = formsPlot1.Plot.GetCoordinates(e.X, e.Y);

    // coordinates-to-pixel
    Pixel px = formsPlot1.Plot.GetPixel(coordinates);
};

closing this, tracking progress in #2760


Creating Directory and save files in that directory

Describe the bug
Cannot create directory iCloud
Steps to reproduce
Try using RNClousdStorage.writeFile to create a directory,
await RNCloudStorage.writeFile("backupFolder", "", scope);

It should create a directory.
Then, try to save a file with directory
await RNCloudStorage.writeFile("backupFolder/backupFile.txt", "content", scope);

I get the following error when logging the error in console:
[Error: Error writing file backupFolder/backupFile.txt]

How can I save files in a directory in iCloud?
Environment:

Device: [ Mobile]
OS: [iOS]

This is indeed not supported yet. It's only possible to create files within directories that already exist for now.
Creating directories is planned for the next release (which should land on Tuesday).

This is now possible in version 0.6.0. Use the mkdir method to create new directories. You can check if a directory already exists using the exists or stat methods.


chore: Switch from edx-sphinx-theme to sphinx-book-theme

The edx-sphinx theme is being deprecated, and replaced with sphinx-book-theme. This removes references to the deprecated theme and replaces them with the new standard theme for the platform.
Testing instructions:

Run make docs and see that the docs are generated properly and use the sphinx-book-theme

See https://github.com/openedx/edx-sphinx-theme/issues/184

Thanks for the pull request, @xitij2000!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@xitij2000: On a fresh copy of the code, make requirements is failing for me due to lack of pip-sync. I'm wondering if this is because the Makefile isn't installing pip-tools.txt like in the cookiecutter? I don't have time at this moment to correct. Let me know if you can fix in a separate commit. Thanks.

@xitij2000 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

I added pip install -r requirements/pip-tools.txt in the Makefile for requirements after pip.txt, and left everything else as-is, and I was able to run make requirements ok.
That said, this is an independent issue, so I'm approving.
@timmc-edx: Thoughts on how and where we can ticket this, and what the final clean-up should look like?

Sorry for the late response. Yeah, I am facing the same issue on my system. Adding in that line fixes it. I tested mostly with a base environemnt with pip tools preinstalled and by running make docs which works.


Josh/terrible code update

I don't want to do any more updates to the README.  What do you think about that?

I really don't like this code. It's ugly.

James this code is awesome and elegant.
__
  Summary: :trophy: This code is awesome  |  Tags: Unreadable, Not secure, Inefficient, Inelegant

Use PascalCasing for abbreviations 3 characters or more (2 chars are both uppercase). This is consistent with the Microsoft’s .NET Framework. Caps would grab visually too much attention.
📄 Jesse Liberty
__
  Summary: :hammer_and_wrench: This code needs a fix

Adam this code is awesome and elegant
__
  Summary: :trophy: This code is awesome  |  Tags: Unreadable, Not secure, Inefficient, Elegant

Some simple recommendations to write better documentation:
Write Javadoc comments for each public class and method (maybe setters and getters could be omitted);
Avoid irrelevant and obvious comments. A comme...
📄 Toptal
__
  Summary: :hammer_and_wrench: This code needs a fix

charles this code is awesome and elegant
__
  Summary: :trophy: This code is awesome  |  Tags: Elegant

By following the naming convention rules, you can always tell:
Is this filed only for private use or publicly available;
Is this a static filed or no;
Is this a constant;
Is this filed was declared inside a c...
📄 Union Assets
__
  Summary: :hammer_and_wrench: This code needs a fix

i would like you to fix this please. 👎🏻
__
  Summary: :hammer_and_wrench: This code needs a fix

Have a look at the below:
There are many exceptions already predefined in .NET. Some of them being:
DivideByZeroException is thrown if the divisor is 0;
ArgumentException, ArgumentNullException, or ArgumentOutOfRangeException is thrown if invalid parameters are passed;
InvalidOperationException is thrown if a method call or property set is not appropriate in the object's current state;
FileNotFoundException is thrown if the file is not present;
IndexOutOfRangeException is thrown if the item being accessed from an array/collection is outside its bounds.
The predefined exceptions are sufficient in most of the cases. Hence introduce a new custom exception class only when a predefined one doesn't apply or you would like to have some additional business analytics based on some custom exception, e.g. A custom exception - TransferFundsException can be used to keep track of fund transfer exceptions and generate business analytics & insights from it.
📄 Ashwin's Blog
__
  Summary: :hammer_and_wrench: This code needs a fix  |  Tags: Not reusable, Brittle

Your solution should include a hash table, read here for more info:
In computing, a hash table (hash map) is a data structure which implements an associative array abstract data type, a structure that can map keys to values. A hash table uses a hash function to compute an ind..
__
  Summary: :hammer_and_wrench: This code needs a fix

Miche this code is elegant and awesome
__
  Summary: :trophy: This code is awesome  |  Tags: Inefficient, Inelegant, Not reusable

The software does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.
📄 Mitre
__
  Summary: :hammer_and_wrench: This code needs a fix

miche you did cross-site scripting...
The product uses a blacklist-based protection mechanism to defend against XSS attacks, but the blacklist is incomplete, allowing XSS variants to succeed.
📄 Mitre
__
  Summary: :hammer_and_wrench: This code needs a fix

Remember -- attributes from the global input variable might eliminate some levels of nesting, it makes the origin of the attribute(s) less apparent. Clearly differentiating input and data from values, functions, and rules defined inside of the same module helps in making things obvious, and few things beat obviousness!
In some contexts, the source of data is obvious even when imported and/or renamed. A common practice is to rename input in Terraform policies for example, either via import or a new top-level variable.
📄 Open Policy Agent (OPA)


2: Add Artemis devices to dodal

Fixes #2
To test:

Confirm unit tests pass (by running pytest tests/ -m "not s03")
Confirm structure of i03/s03 looks correct
Confirm history is somewhat preserved

Note that this adds devices as is from Artemis, there may well be improvements that could be made to this code but this PR should focus on getting the code into dodal, subsequent issues can be made to tidy it up.

This is too out of date to be useful now


Make app-footer view

@marktopper
Why the file extension is not .blade ? it is shown in the footer as a plain text.


AMD support and compatible with older browsers and add cover option

About cover option, I need to change container size in responsive web page.

Hi, thank you so much for the PR, but I have to ask you to edit: there are too many changes in the commits ( maybe because you changed the tabulation? )
You have to respect current tabulation rules and only add rows.
Thank you!

OH…The problem may be an anonymous function, let me try :)

Thank you so much!
Amazing PR.


Remove unused else block in client streaming receive function

Description:
In client streaming, when the server is sending Empty messages, the client's receive method currently looks as follows.
isolated remote function receive() returns grpc:Error? {
    var response = check self.sClient->receive();
    if response is () {
        return response;
    } else {
        _ = response;
    }
}

The else block is not needed and we need to remove it.

@keizer619 is this still valid? If yes, Can i work on this ??


Adding Footer to the website

Description
Adding footer to the website such that the footer it contains the social media links so that the user can contact and if they wish to add a episode they can add with the help of admins. The work of adding episodes can be simplified for that the footer section would be very helpful.
Current Screenshot

Expected

I am GSSoC'24 Contributor
Kindly assign me this issue @Avdhesh-Varshney

Hi there!
I just noticed that there isn't any footer section in the website, the foooter section plays a major role as it lets the users interact with us regarding any kind of queries, therefore i feel i can work on this issue easily so kindly assign this issue to me @Avdhesh-Varshney

@narayani9120 go ahead.

Hi @Avdhesh-Varshney,
I propose adding a footer to the website that includes social media links, making it easier for users to contact us. Additionally, this footer will streamline the process for users to submit episodes with the help of admins.
I am a GSSOC'24 contributor
Thank you,

@narayani9120 solve it within 1 day.

hi @Avdhesh-Varshney can i work upon it

hi @Avdhesh-Varshney can i work upon it

go ahead

@Avdhesh-Varshney If the Footer Issue is also not been solved I would like to work on this issue ...
I will Try to give the pull request by the end of the day if u assign mee today
Can You give me all the handles links so that I can make that footer responsive as well ?
I am A GSSOC Contributer

@Avdhesh-Varshney I can design a footer with name of site,links, and chanakya image on left hand side.I am a GSSOC contributor.Can you please assign it to me?I will surely complete it within a single day

I Would Like to work on this Issue @Avdhesh-Varshney
Screenshots
before

After

After (screenRecording)
https://github.com/Avdhesh-Varshney/chanakya-niti/assets/98605616/6383eca7-984d-4a0c-ade9-ec4211ad649f

Please Assign Me this Issue @Avdhesh-Varshney


Removing PC pre-req from Android quickstart instructions

@RickSaling and @ggailey777 the quickstart now does only Node.js backends, so I've removed the PC as a pre-requisite for the Android quickstart.

@krisragh : Thanks for your contribution to the Azure documentation! The author, @RickSaling, has been notified to review your proposed change.


Prep install 101 (#8091)

Prepare Helm charts for 1.0.1 release

An umbrella chart, of which Istio is, should not contain
a requirements.yaml.  Unfortunately because of how conditions
work in Helm, a requirements.yaml is required.  This patch
removes the comment noise relating to repos to reduce
cargo cult programming.

Clean istio-remote of incorrect cargo cult

Change all versions to 1.0.1

This includes appVersion, which may not be technically correct.
The version field should definately be 1.0.1 for all chart/subcharts
shipped with Istio as Istio is the umbrella chart.

Prepare Istio 1.0.1 for release

Address various appVersion problems

Address review comments

(cherry picked from commit 32cef7bbc075c622c913bb3f21a780ec53376629)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
If they are not already assigned, you can assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[minor] add user availability to UserStatus

This minor PR adds support for the availability field in UserStatus, added in 13.6.0.

FYI: the API docs for setting the availability is currently do not mention the availability parameter, but it works anyway, so I included it in the PR.


Check difficulty limit during block validation

Also make sure each block check has:

block test vector tests
failure tests

The coverage should improve in the next PR, which will add more proptests.


CI / Build optimizations

This PR

upgrades to go1.10beta1 which enables build and test caching

which will enable test caching in local development
the integration test suite make test-pps has test caching disabled

updates the travis config to cache the golang build cache between builds

enabling test caching on CI (per branch)

miscellaneous go vet fixes
disables go vet step since vet is part of test by default now? (Or do we want it early on still?)

This PR does NOT:

cache docker images / docker builds on ci see this issue

Hrmmmm seems like pike veto'd single line ignore directives
https://github.com/golang/go/issues/17058
But I bet I can silence this class of error w a flag. That'll disable all such errors though.


Low performance without TTA

Hi. Thank you for sharing codes and resources.
I have a question about your method without test-time augmentation.
How to reproduce it on the Modelnet40 dataset？
I only got 82-83 percent accuracy with the pretrained checkpoint, compared to 90.2 reported.

Hi there. It would require to trained from scratch with TTA disabled. My apology that we haven't recorded that checkpoint as it is not the primary result.

All right. Thanks.


Application not recovering when Startup throws exception

We have some test servers that reboot themselves every night. The web server reboots but it up before the SQL server is up. The .NET Core 2.2 application gets automatically started with the "Application Initialization" feature in IIS.
When the application starts automatically it runs some initialization in the Startup.cs Configure method. But because the database is unreachable an exception is thrown:
Application startup exception: System.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: Named Pipes Provider, error: 40 - Could not open a connection to SQL Server) ---> System.ComponentModel.Win32Exception (1231): The network location cannot be reached. For information about network troubleshooting, see Windows Help
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry)
   at System.Data.SqlClient.SqlConnection.Open()
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.OpenDbConnection(Boolean errorsExpected)
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.Open(Boolean errorsExpected)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.<>c__DisplayClass18_0.<Exists>b__0(DateTime giveUp)
   at Microsoft.EntityFrameworkCore.ExecutionStrategyExtensions.<>c__DisplayClass12_0`2.<Execute>b__0(DbContext c, TState s)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.Execute[TState,TResult](TState state, Func`3 operation, Func`3 verifySucceeded)
   at Microsoft.EntityFrameworkCore.ExecutionStrategyExtensions.Execute[TState,TResult](IExecutionStrategy strategy, Func`2 operation, Func`2 verifySucceeded, TState state)
   at Microsoft.EntityFrameworkCore.ExecutionStrategyExtensions.Execute[TState,TResult](IExecutionStrategy strategy, TState state, Func`2 operation)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.Exists(Boolean retryOnNotExists)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.Exists()
   at Microsoft.EntityFrameworkCore.Migrations.HistoryRepository.Exists()
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
   at Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.Migrate(DatabaseFacade databaseFacade)
   at App.Internal.Data.DataContext.Configure(IApplicationBuilder app) in C:\TeamCity\buildAgent\work\1057292a3d53e562\App.Internal\Data\DataContext.cs:line 36
   at App.Web.Startup.Configure(IApplicationBuilder app, IHostingEnvironment env, ICodeExecutor codeExecutor, IScheduler scheduler, ILogger logger, IOptions`1 config) in C:\TeamCity\buildAgent\work\1057292a3d53e562\App.Web\Startup.cs:line 142
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
   at Microsoft.AspNetCore.Mvc.Internal.MiddlewareFilterBuilderStartupFilter.<>c__DisplayClass0_0.<Configure>g__MiddlewareFilterBuilder|0(IApplicationBuilder builder)
   at Microsoft.AspNetCore.Server.IISIntegration.IISSetupFilter.<>c__DisplayClass4_0.<Configure>b__0(IApplicationBuilder app)
   at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder app)
   at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder builder)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
ClientConnectionId:00000000-0000-0000-0000-000000000000
Error Number:1231,State:0,Class:20
Hosting environment: Production
Content root path: D:\Sites\App-Test
Now listening on: http://<IP_ADDRESS>:36894
Application started. Press Ctrl+C to shut down.

When this happens the application stays unreachable, forever, until you manually restart the site + app pool.
Every time you try to access the app you get:
An error occurred while starting the application.
.NET Core 4.6.27414.05 X64 v<IP_ADDRESS>    |   Microsoft.AspNetCore.Hosting version 2.2.0-rtm-35687    |    Microsoft Windows 10.0.14393    |   Need help?

But the log files don't record anything, nor the event viewer.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core 2.2
Create a web application and have it throw an exception in the Configure method, but only the very first time the app starts up (maybe check if a file exists, if it doesn't create it and throw an exception).
Deploy the app to IIS and start it
Browse the first time to the site, an exception will be logged
The consecutive visits won't throw any errors but the site will still be down

Expected behavior
When the application fails to initialize it should retry to initialize every time it's requested.

Is the error page still rendered? We intentionally avoid re-running Startup in this case until the app is restarted. If you want us to continue attempting to run startup, you can disable capturing startup errors by calling .CaptureStartupErrors(false) on your WebHostBuilder.

I used .CaptureStartupErrors(false) and this morning the site was up this morning, so that seems to have solved it.
The error page was just the standard error:
An error occurred while starting the application. .NET Core 4.6.27414.05 X64 v<IP_ADDRESS>    |   Microsoft.AspNetCore.Hosting version 2.2.0-rtm-35687    |    Microsoft Windows 10.0.14393    |   Need help?
I realized that my WebHostBuilder is wrapped in a try catch:
            try
            {
                Log.Information("Starting host");

                WebHost.CreateDefaultBuilder(args)
                       .UseStartup<Startup>()
                       .ConfigureAppConfiguration((hostingContext, config) =>
                       {
                           config.SetBasePath(Directory.GetCurrentDirectory());
                           config.AddJsonFile("appsettings.json", false, false);
                       })
                       .CaptureStartupErrors(false)
                       .UseIISIntegration()
                       .UseSerilog()
                       .Build()
                       .Run();
            }
            catch (Exception ex)
            {
                Log.Fatal(ex, "Host terminated unexpectedly");
            }
            finally
            {
                Log.CloseAndFlush();
            }

Where Log is the Serilog logger, but is supposed to log the database, which is unavailable..
How does CaptureStartupErrors behave with the Application Initialization feature in IIS? I'm just wondering what the attempt to start interval would be.

CaptureStartupErrors stops the process from crashing when there's an Exception thrown during the execution of the methods in your Startup method, and instead renders a simple error page with the error message (in development mode).
As a result, when CaptureStartupErrors is on, the flow is something like this:

A request comes in from a client
IIS starts the app
Startup throws
ASP.NET Core catches the exception
ASP.NET Core starts a simple server to render a 500 error page with the error
IIS gets the 500

If the client makes another request, it goes through to the server ASP.NET Core set up to render the error page, so IIS doesn't think anything is wrong.
When CaptureStartupErrors is off, the flow is like this:

A request comes in from a client
IIS starts the app
Startup throws
ASP.NET Core does not catch the exception, so the process crashes
IIS returns a 500

Now, if the client makes another request, the underlying ASP.NET Core app isn't running so IIS starts it up again and keeps hitting the error.
Application Initialization (as far as I know, I'm not an IIS expert ;)) just configures IIS to make a request back to itself (at the path you specify) to "prime" your application before letting clients access the app. So, when CaptureStartupErrors is on, the IIS Application Initialization feature seems to get in a loop constantly thinking the app is failing to start (because the captured startup error just keeps causing a 500).
If you're using Application Initialization, I'd suggest one of two paths forward:

Disable CaptureStartupErrors. As long as you're monitoring logs and stack traces from your application, you'll get the startup errors through that so you don't really need this feature anyway

Add retry logic for expected or transient failures during startup (like database access)

I'm going to close this issue because there isn't anything we plan to fix here, but feel free to ask further questions if you have them!

Thanks @anurse for the write up!
Just as note for who sees this in the future, I'm using Application Initialization` due to hangfire tasks that run in the background.
I'm going to add a self-check mechanism that attempts restarting the app.
Thanks!

This was helpful. However, even after I added .CaptureStartupErrors(false) my app was still getting permanently stuck with a HTTP Error 500.30 - ANCM In-Process Start Failure page.
In my case there are some global config files that our app references that aren't there in the image when its starting up, but are put in place further on in the server provisioning process.
My solution was just to recycle the app pool once the script runs that puts those file in place:
Restart-WebAppPool APIPool -ErrorAction SilentlyContinue

That seems to have done the trick.


'lsp-enable' 2:6: 'set' wrong argument count

I've put this in my kakrc
%sh{kak-lsp --kakoune -s $kak_session}
but I get this error
/home/kieran/.config/kak/kakrc:397:13328: 'lsp-enable' 2:6: 'set' wrong argument count
/usr/share/kak/kakrc:87:12585: 'source' 397:13328: 'lsp-enable' 2:6: 'set' wrong argument count
error while parsing kakrc:
    1:1: 'source' 87:12585: 'source' 397:13328: 'lsp-enable' 2:6: 'set' wrong argument count

Also tried
eval %sh{kak-lsp --kakoune -s $kak_session}
and got the same error
/home/kieran/.config/kak/kakrc:1:1: 'eval' wrong argument count
/usr/share/kak/kakrc:87:12585: 'source' 1:1: 'eval' wrong argument count
error while parsing kakrc:
    1:1: 'source' 87:12585: 'source' 1:1: 'eval' wrong argument count

Sounds like you have pre-big-breaking-changes version of Kakoune. One option is to build Kakoune from the git repo, and another is to use kak-lsp version 4 — it has less features than 5, but is compatible with older Kakoune.

Oh wow didn't realise that the "stable" release was so out of date, changed to the git version and it works fine. Thanks for the help.


Add const folding optimization.

This change is

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 33 at r2 (raw file):
Previously, orizi wrote…
this is alive across blocks - how do we know for sure this is fine?
or if we have the same variable it is the result of a merge?
Also - are we assuming anything about the sorting of the blocks?

I can clear it.
but its we assume ssa.


Tiered prices breaking pull_stripe action

If I have a tiered price in Stripe
Choose your pricing model
Tiered pricing
Volume
and define tiers e.g. 1-10 units is 100$, then 11-infinity is 150$
then when I call manage.py pull_stripe, it cannot insert the price since it queries the price.unit_amount and it ends up as NULL which is not allowed, an exception is thrown.
And the price cannot be deleted from Stripe if it's been used.
What could be the solution?

Found out I can clear all test data at once in Stripe Dashboard


Fix initialization in browser without custom elements support if the script is placed in head and synchronous

The title says it all.
This use case (when no loader is used) currently crashes because the main script (szn-elements) cannot find the document.body element, since it doesn't exist yet.

This needs to be fixed in the szn-elements mutation observer runtime, either by delaying the DOM observer initialization, or by observing the whole document (should not increase the performance impact much).

Note: The mutation observer runtime will be used only by Edge and MSIE once Firefox 63 is released (scheduled for October 23, 2018).

Fixed in 61e2abdb064ab88efe1cb2d99cbd6776eb577260


[TC-ACE-1.2] SDK support required to send a subscription when two controllers are in same fabric.

Test Case ID :-
4.1.2. [TC-ACE-1.2] Subscriptions
Here explaining two scenario's

scenario 1

As per Test-plan, If TH1 and TH2 are in same fabric and tried to subscribe an attribute, DUT through an error as Status = 0x80 (INVALID_ACTION) instead of 0x00 (SUCCESS)
Expected  behavior :- 0x00 (SUCCESS)
Actual behavior :-  0x80 (INVALID_ACTION)
Reproduction steps :
On DUT
./chip-all-clusters-app
On TH1
./chip-tool pairing onnetwork 1 20202021 --commissioner-nodeid 0x1
./chip-tool interactive start
accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": [{ "cluster": null, "endpoint": 0, "deviceType": null }]}]' 1 0   --commissioner-nodeid 0x1
On TH2(same fabric as N1)
operationalcredentials subscribe nocs  1 30 1 0 --fabric-filtered false  --keepSubscriptions 0    --commissioner-nodeid 0x2
Test-Plan Reference :
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/AccessControlEnforcement.adoc#tc-ace-1-2-subscriptions-removed
PFA log below
TC-ACE-1.2-DUT.txt
TC-ACE-1.2-TH.txt

scenario 2

As per Test-plan, If TH1 and TH2 are in same fabric and tried to send ACL write cammand, DUT through an error as Status = 0x80 0x7e (UNSUPPORTED_ACCESS ) instead of 0x00 (SUCCESS)
Reproduction steps :
On DUT
./chip-all-clusters-app
On TH1
./chip-tool pairing onnetwork 1 20202021
./chip-tool interactive start
accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": [{ "cluster": null, "endpoint": 0, "deviceType": null }]}]' 1 0   --commissioner-nodeid 0x1
Expected  behavior :- 0x00 (SUCCESS)
Actual behavior :- 0x7e (UNSUPPORTED_ACCESS )
PFA log below
TC-ACE-1.2----DUT.txt
TC-ACE-1.2---TH.txt

I also encountered the same problem. When I executed instruction “operationalcredentials subscribe nocs  1 30 2 0 --fabric-filtered false  --keepSubscriptions 0”, the result was timeout, and I found that my instruction was different from yours, yours was accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": [{ "cluster": null, "endpoint": 0, "deviceType": null }]}]' 1 0 --commissioner-nodeid 0x1. Is this the instruction in the latest test document?

accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": [{ "cluster": null, "endpoint": 0, "deviceType": null }]}]' 1 0 --commissioner-nodeid 0x1

This does not match the test plan.  Test plan says:

Subjects field: [N1, N2]

but you are including only N1.  Then when N2 tries to subscribe, it gets UNSUPPORTED_ACCESS, because it does not have access.

I filed https://github.com/CHIP-Specifications/chip-test-plans/issues/2417 on the verification steps being wrong.

Ok, so is the test case TC-ACE-1.2 currently problematic or has it been updated with the latest test documentation?


Upgrade to C# 6.0

I am really excited to upgrade this particular library to use C# 6.0. I must wait a little while, though.
I do not think it's a good idea to upgrade until the language is a little bit more mature.

AlexArchive, I'd be interested in helping with this when you're ready. Thanks

@mgmccarthy Thanks for expressing interest, if you are interested in upgrading to C# 6.0 and the accompanying simplifications that would be possible, please feel free to do so and PR it. Alex passed off maintenance of this project to me and I've been busy with other things so haven't had much time to work on this.

Addressed in PR #43


when trying to retreive application insights key, the reply with connection-string is varied

Describe the bug
when using az spring build-service builder buildpack-binding show -n default --resource-group <> --service <> --subscription <> the json response with the connection-string value is varied. sometimes its connection_string others is connection-string
Related command
az spring build-service builder buildpack-binding show -n default --resource-group <> --service <> --subscription <>
Errors
the command doesn't fail, just building anything around the cli or using it via python requires extra checking and validation
Issue script & Debug output
from azure.cli.core import get_default_cli

cli: any = get_default_cli()

cli.invoke(
        [
            'spring',
            'build-service',
            'builder',
            'buildpack-binding',
            'show',
            '-n',
            'default',
            '--resource-group',
            'asa-e-rg-01',
            '--service',
            'asa-e-si-02',
            '--subscription',
            '5c6097b3-0798-4146-8d81-1e3ef0686c2d'
        ]
    )

print(cli.result.result)
data = cli.result.result
print(data['properties']['launchProperties']['properties']['connection_string'])

Expected behavior
to not fail, or have a the keys be the same and not change from _ to - as a sperator
Environment Summary
az cli 2.51
account | 0.2.5
application-insights | 0.1.19
serviceconnector-passwordless | 0.3.8
spring | 1.14.0
Additional context
No response

Thank you for opening this issue, we will look into it.


[SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS

What changes were proposed in this pull request?
Spark only  can drop partitions by exact values. For instance, Spark doesn't support:

ALTER TABLE mytable DROP PARTITION(mydate < '2018-04-06')

The PR adds the support to this syntax.
The PR takes input from the effort in #19691 by @DazhuangSu ,  in #20999 by @mgaido91 ,
, there are some related PRs: #15987,#16036,#19691,#15704.
some related issues:
https://issues.apache.org/jira/browse/SPARK-14922
https://issues.apache.org/jira/browse/SPARK-17732
https://issues.apache.org/jira/browse/SPARK-23866
How was this patch tested?
Add unittests.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

please fix all failures

Ping @cloud-fan @mgaido91 @maropu @DazhuangSu   Kindly review, thanks.

ok to test

Test build #112830 has started for PR 26280 at commit ce453ed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17765/
Test PASSed.

Test build #112830 has finished for PR 26280 at commit ce453ed.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
public class ExpressionBuilder
public final class Utilities

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112830/
Test FAILed.

please retry test

jenkins, retest this, please

retest this please

Test build #112845 has started for PR 26280 at commit ce453ed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17778/
Test PASSed.

Test build #112845 has finished for PR 26280 at commit ce453ed.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
public class ExpressionBuilder
public final class Utilities

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112845/
Test FAILed.

retest this please

retest this please

Test build #112919 has started for PR 26280 at commit ce453ed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17843/
Test PASSed.

Test build #112919 has finished for PR 26280 at commit ce453ed.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
public class ExpressionBuilder
public final class Utilities

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112919/
Test FAILed.

Test build #113000 has started for PR 26280 at commit a0c42fd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17923/
Test PASSed.

Test build #113000 has finished for PR 26280 at commit a0c42fd.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
public class ExpressionBuilder
public final class Utilities

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113000/
Test FAILed.

retest this please

retest this please

Test build #113022 has started for PR 26280 at commit a0c42fd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17944/
Test PASSed.

Test build #113022 has finished for PR 26280 at commit a0c42fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
public class ExpressionBuilder
public final class Utilities

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113022/
Test FAILed.

Test build #113084 has started for PR 26280 at commit 1bd2cd3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18001/
Test PASSed.

Test build #113084 has finished for PR 26280 at commit 1bd2cd3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
public class ExpressionBuilder
public final class Utilities

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113084/
Test FAILed.

Test build #113747 has started for PR 26280 at commit e27f13c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18625/
Test PASSed.

Test build #113747 has finished for PR 26280 at commit e27f13c.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
  case class ExpressionBuilder(val table: MetaStoreApiTable,

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113747/
Test FAILed.

retest this please

Test build #113757 has started for PR 26280 at commit 21cd780.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18632/
Test FAILed.

Test build #113757 has finished for PR 26280 at commit 21cd780.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
  case class ExpressionBuilder(val table: MetaStoreApiTable,

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113757/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18647/
Test PASSed.

Test build #113775 has started for PR 26280 at commit 0d5bc03.

Test build #113775 has finished for PR 26280 at commit 0d5bc03.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
  case class ExpressionBuilder(val table: MetaStoreApiTable,

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113775/
Test FAILed.

Test build #113834 has started for PR 26280 at commit 11b4cb0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18706/
Test PASSed.

Test build #113834 has finished for PR 26280 at commit 11b4cb0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
  case class ExpressionBuilder(val table: MetaStoreApiTable,

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113834/
Test FAILed.

Test build #113852 has started for PR 26280 at commit 9d3ede5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18722/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113852/
Test FAILed.

retest this please.
@cloud-fan @mgaido91  @maropu @DazhuangSuKindly review,  thanks.

Test build #114062 has started for PR 26280 at commit c2639d0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18922/
Test PASSed.

Test build #114062 has finished for PR 26280 at commit c2639d0.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PartitioningAttribute(
  case class ExpressionBuilder(val table: MetaStoreApiTable,

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114062/
Test FAILed.

@cloud-fan Could you review this PR , thanks.

This is also a requirement in our PROD environment, could anyone help review?


The NoneStreamEsDAO implementation doesn't use real index name to insert

@sunrongxin7666 I have found out the reason of your reported issue. The existing codes are using the template name rather than the index name(with time bucket suffix) to insert data, which is not supported by the ElasticSearch. We haven't a chance to test this case before, thanks for your detailed report, which makes me easier to catch the reason.
All existing metrics and traces insert/update are doing in the right now, but due to profile is new in the 7.0, it seems @mrproliu missed this, and this can't be caught by the current TTL e2e.
Resolves #4794.

Codecov Report

Merging #4796 into master will decrease coverage by 51.17%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544d419...f7c1a01. Read the comment docs.


Add main field into packageJSON

Hey man, since I am trying out electron, and you actually runs node code into chromium, there is no need to use browserify or those kind of technologies.
But if you attempt to require this module, it fails due to main field missing. Can you please add it? Same as browser field used by browserify and others.
Thanks.

Ah I never considered running this in electron, looks like there's no way for it to use the browser field which is a shame. I've changed it in 0.6.4 which should sort your problem :smile:


todo-app walkthrough steps confusing

In step 4, the below is mentioned :

Change the code in App.cs to reference the new TodoApp component instead of HelloWorld:
host.AddComponent(parent: this);

I think it is better to state explicitly to also remove the line:
MainPage = new ContentPage();
I confirmed this by looking at the sample code provided here
It spent me some time for figuring out the reason why an empty page is opened.
I am new to xaramin and android and clearer steps (esp the document is describing how to change the app from the HelloWorld sample into the Todo one) would definitely be helpful to any other people like me. (well I should look into the source earlier)

Hi @nickkfwong thank you for reporting this! The doc is indeed out of date. It was correct for Preview 1 but some changes in Preview 2 have caused the doc to be slightly incorrect. I will update this ASAP. Glad you got it working!

I took another look at this and made some updates to the doc that I hope will be published later this month.
The suggested code change was mostly correct, but I am making some updates to the docs to be more accurate with regard to the steps to take.