feat: add repository common definition

Add common repository definitions.
This update introduces two types of repositories:

ReadonlyRepository
Repository (which combines ReadonlyRepository and MutableRepository)

Additionally, it resolves an issue where an extra semicolon was automatically inserted after saving.
Closes #5, fixes #6.

Rich repository = anemic models. Anemic models are bad.
Rejected. Closes #5


Fix three typos.

#CHANGES
Fix some minor typos.
Please tell me if I did anything that doesn't fit your processes.

@prescod our process is generally that once the checks are green and someone has reviewed it, anyone may merge including the person who submitted the PR. Want to do the honors?
You can ignore the red test_release build. It's failing because we're in the middle of the Spring '19 release window and the packaging org for the CumulusCI-Test package is on a different version of Salesforce than the scratch org where the package is installed for testing. Should resolve itself this weekend.


UnblockPIN and VerifyPIN have differing behaviors

Hey, played around with it a bit more and can confirm that the PUK is properly decremented if I supply all the needed 12 + 6 bytes.
However, then I have a different issue:

In unblockPIN, you verify that the PUK + PIN is 18 digits, and don't fail the PUK attempt if the input is bad. This is imho good behavior.
In verifyPIN however you  do not check that the length is 6 digitas, so you do fail the PIN attempt if the input is bad.

I think both behaviors is fine as long as they are consistent across each other. At least this is what I would expect.

I agree with you that the VERIFY PIN behavior is somewhat inconsistent and should be changed to match the UNBLOCK PIN behavior. In the meantime format validation can be performed client-side to avoid wasting PIN attempts.


Implement code checking tools

Need to use husky(https://www.npmjs.com/package/husky) to implement gitleaks (https://github.com/gitleaks/gitleaks), eslint on pre-commit stage.

Implemented gitleaks on github actions


Fix odometry publishing

With these changes we can see the robot position history using the odometry visualization in rviz:

I re-indented one of the xacro files because it was hard to edit if not. I tried to minimize the changes to the other one though.
Closes #10

@francocipollone thanks for the review. Comments addressed!


Can't connect to an event whose handler type is inaccessible

Hello, i'm trying to use ClearScript with my internal class and everything is working fine, but i can't use a public delegate inside this class because i'm getting an error message with something like:  "Error: Access to "Microsoft.ClearScript.EventSource<PROJECT.ScriptContext.EmptyEvent>.connect(object)" is not possible due to the protection level.".
I'm not getting an exception using System.EventHandler instead of a custom delegate
C# code:
...
V8ScriptEngine engine = new V8ScriptEngine();

engine.AddHostObject("API", HostItemFlags.PrivateAccess, new ScriptContext());
...

internal class ScriptContext
{
    public delegate void EmptyEvent();

    public event EmptyEvent OnTest;

    internal void OnTestInvoke()
    {
        OnTest?.Invoke();
    }
}

Javascript code:
API.OnTest.connect(function() {

});

Maybe i'm doing something wrong but i can't find a solution for it.
Thanks!

Hi @EntenKoeniq,
We've reproduced the issue. It's an interesting one. Thanks for reporting it!
The problem here is that ScriptContext.EmptyEvent is inaccessible to script code.
Exposing a host object only provides access to the object's instance members. HostItemFlags.PrivateAccess doesn't change that; it only affects which instance members are visible.
In this case, script code can see API.OnTest and API.OnTestInvoke, but not ScriptContext.EmptyEvent, as that's a static member – a nested type.
Nevertheless, the expression API.OnTest yields an instance of the class EventSource<ScriptContext.EmptyEvent>. Because that class is parameterized by an inaccessible type, it too is inaccessible.
This is a situation we haven't encountered before. ClearScript is behaving as intended, but in this case, we consider its behavior undesirable and therefore a bug.
We'll take a closer look at this issue and include a fix in the next release. In the meantime, one possibility is to use ScriptEngine.AccessContext to make all your internals visible to script code. For example, you might do something like this:
engine.AccessContext = typeof(ScriptContext);
engine.AddHostObject("API", new ScriptContext());

Note that ScriptEngine.AccessContext only affects the visibility of exposed internals; it doesn't expose anything by itself.
Thanks again, and good luck!

Fixed in Version 7.2.5.


Upstream sync

Decred changes rebased/ported to upstream master branch.  Consists of small atomic commits which would help regular/frequent upstream syncing against the upstream release.
I added a Decred app variant that facilititates maintaining the UI/creative aspects of the fork without divergence.  For now I added creative assets as a placeholder, this is WIP status for now and needs polishing.  To start the build first run the below script to initialize the variant (this will also run npm install)
npm run apply:decred

npm start

NB The changeset doesn't include the i18n directory – to merge the message strings it would be more straightforward/sustainable to use Crowdin

Ok so in lieu of trying to merge this with our upstream branch, I've decided to make a new master-sync branch that is PR.  After brief testing this method of applying changes on top of the existing copay stack is the way to go.  We can now start to test and submit PRs to the new master-sync branch.  Closing this PR.

upstream will remain a marker as to our current position with the bitpay/copay repo

I think it would be useful to also add tags to the upstream branch whenever it is pulled from bitpay/master; so that in the next sync cycle a new PR can be made but the previous commit height is still recorded (in case or any merging issues etc).  Does that make sense?


New: "Working with local content in WebView2 apps"

Rendered article for review:

https://review.learn.microsoft.com/en-us/microsoft-edge/webview2/concepts/working-with-local-content?branch=pr-en-us-2353
Overview of APIs section:
https://review.learn.microsoft.com/en-us/microsoft-edge/webview2/concepts/overview-features-apis?branch=pr-en-us-2353#manage-content-loaded-into-webview2

GitHub version of rendered Markdown:

https://github.com/mikehoffms/edge-developer/blob/user/mikehoffms/working-with-content/microsoft-edge/webview2/concepts/working-with-local-content.md
Overview of APIs section:
https://github.com/mikehoffms/edge-developer/blob/user/mikehoffms/working-with-content/microsoft-edge/webview2/concepts/overview-features-apis.md#manage-content-loaded-into-webview2

Learn Build status updates of commit 306dca9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-content.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit aacf400:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-content.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 3c9e75c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-content.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit b8a2f52:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-content.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 33704e7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-content.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 658554a:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/working-with-content.md
:bulb:Suggestion
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-content.md

Line 122, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dotnet/api/microsoft.web.webview2.core.corewebview2hostresourceaccesskind' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 4c4711f:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/working-with-content.md
:bulb:Suggestion
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-content.md

Line 122, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dotnet/api/microsoft.web.webview2.core.corewebview2hostresourceaccesskind' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 1990809:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-local-content.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit a0aa05b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-local-content.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 47d345f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/working-with-local-content.md
:warning:Warning
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-local-content-images/demo-todo-page-as-string.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-local-content.md

Line 87, Column 18: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension/get-started' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 87, Column 18: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension/get-started' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 42a42d9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/working-with-local-content.md
:warning:Warning
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-local-content-images/demo-todo-page-as-string.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-local-content.md

Line 86, Column 18: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension/get-started' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 86, Column 18: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension/get-started' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit d18e23d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/working-with-local-content.md
:warning:Warning
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/overview-features-apis.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-local-content-images/demo-todo-page-as-string.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/working-with-local-content.md

Line 86, Column 18: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension/get-started' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 86, Column 18: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension/get-started' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


feat(data-manager): Added a data manager class

Per #80  made a DataManager class.
Probably easiest to get a sense of it through the examples, but highlight is that users don't need to do bookeeping because they can just do
        for ix in indices_to_label:
            original_ix = manager.get_original_index_from_unlabeled_index(ix)
            y = original_labels_train[original_ix]
            label = (ix, y)
            labels.append(label)
        manager.add_labels(labels)
        # clear_output()
    learner.teach(manager.labeled, manager.labels)

And the manager keeps everything in sync.
I bet the API can be improved, but it's a solid and convenient start. Looking forward to feedback

@talolard  Hi! I am really sorry, but I forgot to review the PR :( In the last month I was working crazy hard to launch a new startup and a new product, so I set everything aside. If it is still fine by you, I'll review it now and add it.

Codecov Report

Merging #81 (3281990) into dev (1e23453) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #81   +/-   ##
=======================================
  Coverage   97.19%   97.19%
=======================================
  Files          31       31
  Lines        1641     1641
=======================================
  Hits         1595     1595
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e23453...3281990. Read the comment docs.


Lesion masks are not in the same space as native flair images nor MNI space

Hi Julian,
Thanks for your efforts working on LST and LST-AI. The instructions you provided were really helpful to ensure a seamless setup. I am having a slight issue though, for some reason the lesion masks created are not in the native FLAIR images space nor are they in standard mni space. Do you have any suggestions to resolve this issue?
Best,
Ahmed

I ran a different scan and it is working now, sorry for the inconvenience!
Thanks,
Ahmed

@AABayoumi Thank you very much for checking out LST-AI and for your feedback, and I am sorry that you are experiencing some problems.
To debug your errors, could you please share the following information with me? :slightly_smiling_face:

Which platform and codebase are you using? Are you working under linux with native python implementation or are you running everything in docker?

With respect to the lesion maps, can you let me know which images / masks you are specifically loading (i.e. exact names) as image and which as lesion maps? Are you using the --temp option to preserve all processed files?

Another user asked me for a detailed explanation of all files, so there might be some room for misunderstandings, I am copying the description to this issue as well:
LST.AI performs segmentation and annotation in the MNI152 template space. For users that would like to keep the registered T1w and FLAIR images and their corresponding segmentation masks, we allow to keep these files if the user provides a temp directory. If you skip the --temp option, then LST-AI will create and delete the temp folder for you (and the temp files vanish).
├── affine_flair_to_mni.mat --> Registration Matrix obtained via greedy
├── affine_t1w_to_mni.mat --> Registration Matrix obtained via greedy
├── atlas_mask_warped.nii.gz --> Deformation Field obtained via greedy for annotation of lesions acc. to McD criteria
├── atlas_warp_field.nii.gz --> Deformation Field obtained via greedy for annotation of lesions acc. to McD criteria
├── sub-X_ses-Y_space-mni_brainmask.nii.gz --> Brain Mask in MNI space
├── sub-X_ses-Y_space-mni_desc-stripped_FLAIR.nii.gz --> Skull-stripped FLAIR in MNI
├── sub-X_ses-Y_space-mni_desc-stripped_T1w_mask.nii.gz --> Brainmask T1w in MNI space
├── sub-X_ses-Y_space-mni_desc-stripped_T1w.nii.gz --> Skull-stripped T1w
├── sub-X_ses-Y_space-mni_FLAIR.nii.gz --> FLAIR in MNI space (with skull)
├── sub-X_ses-Y_space-mni_seg-annotated.nii.gz --> Anno. Seg. in MNI Space
├── sub-X_ses-Y_space-mni_seg.nii.gz --> Binary Segmentation in MNI Space
├── sub-X_ses-Y_space-mni_T1w.nii.gz --> T1w (with skull) in MNI Space
├── sub-X_ses-Y_space-org_FLAIR_mask.nii.gz --> Brainmask in Native Space
├── sub-X_ses-Y_space-org_T1w_mask.nii.gz --> Brainmask T1w in Native Space
├── sub-X_ses-Y_space-orig_desc-stripped_FLAIR.nii.gz --> Stripped FLAIR in native space
├── sub-X_ses-Y_space-orig_desc-stripped_T1w.nii.gz --> Stripped FLAIR in native space
├── sub-X_ses-Y_space-orig_FLAIR.nii.gz --> copy of orig. FLAIR
├── sub-X_ses-Y_space-orig_seg-annotated.nii.gz --> output result: Ann. Seg. in native FLAIR space
├── sub-X_ses-Y_space-orig_seg.nii.gz --> output result: Binary Seg. in FLAIR space
└── sub-X_ses-Y_space-orig_T1w.nii.gz --> copy of T1w

Lastly, if you would be able to share an image (e.g. via mail), I would be able to take a look (however I know that due to privacy reasons this is not always feasible).
Kind regards,
Julian

@AABayoumi was this issue resolved? :slightly_smiling_face:


[WFLY-14912] Final step for vault removal.

This is the final step for vault removal.
https://issues.redhat.com/browse/WFLY-14912
https://issues.redhat.com/browse/WFLY-14996
This depends on the following PR to WildFly Core:
https://github.com/wildfly/wildfly-core/pull/4640

/retest

I figure the Galleon - Linux job failure is related.
Here are WF Preview runs:
https://ci.wildfly.org/viewLog.html?buildId=267152&tab=buildResultsDiv&buildTypeId=WF_Ee9BootableJarLinuxJdk8
https://ci.wildfly.org/viewLog.html?buildId=267150&tab=buildResultsDiv&buildTypeId=WF_WildFlyPreviewLinuxJdk11

The he Galleon - Linux job failure has a poor failure message. Here's what it means:
The test-standalone-reference-provisioning execution provisions using servlet-feature-pack's standalone.xml (i.e. no layers). So everything should be provisioned, equivalent to building servlet-dist.
The all-layers-provisioning execution provisions what's meant to be a complete set of layers.
The test compares the modules in the two provisioned installation and fails if any from the test-standalone-reference-provisioning are missing in the all-layers-provisioning. So javax.xml.stream.api no longer gets provisioned by all-layers-provisioning.

LayersTestCase.NOT_USED is the list of modules that are expected not to be provisioned. So the fix is likely just adding javax.xml.stream.api to the list.

@darranl I filed #14543 to let CI confirm my thinking about that test. Please do with it what you will.

FYI I am trying to reproduce locally as well but think I hit an unrelated failure.


App built with LitElement becomes whitewashed after leaving the tab and returning to it

How my app should look:

How my app looks after leaving the tab open and navigating to other tabs:

Parts of the screen is missing.

Browser: Chrome 76
OS: Mojave macOS

Another example:

Another example:

It looks like something wrong in the app itself. It'd be best to see if any re-render get triggered to verify such problem. A reduced test case might help.

Are the items in the DOM? Are they hidden with CSS? Some things to check before considering whether it's lit, the browser or something else ...

It's probably the browser. It can't be the app.
Related Slack thread (https://polymer.slack.com/archives/C03PF4L4L/p1566974952006700):

I will close this for now as it seems to be better in latest Chrome and also it doesn't seem to be a lit issue. Was hoping to hear from others, but looks like it's just me apparently.


Hamburg Altona has wrong evaId

Hamburg Altona displays not the main evaId.
We get 8002553 but expect 8098553 .

The parsing script picks the isMain EVA ID. Is that wrong?

It is not wrong. But it seems to pick not main sometimes

Whenever there's not isMain, it will pick the first one.

Turns out that, after a rebuild, db-stations will pick 8098553 as the main EVA ID.
cd db-stations
env API_TOKEN=… npm run build
cat full.ndjson | grep Altona

{
	"type": "station",
	"id": "8098553",
	"ds100": "AA",
	"nr": 2517,
	"name": "Hamburg-Altona",
	"coordinates": {
		"latitude": 53.552695,
		"longitude": 9.935175
	},
	"operator": {
		"type": "operator",
		"id": "hamburger-verkehrsverbund-gmbh",
		"name": "BWVI"
	},
	"address": {
		"city": "Hamburg",
		"zipcode": "22765",
		"street": "Scheel-Plessen-Str. 17"
	},
	"category": 1,
	"priceCategory": 1,
	"hasParking": true,
	"hasBicycleParking": true,
	"hasLocalPublicTransport": true,
	"hasPublicFacilities": true,
	"hasLockerSystem": true,
	"hasTaxiRank": true,
	"hasTravelNecessities": true,
	"hasSteplessAccess": "yes",
	"hasMobilityService": "Ja, um Voranmeldung unter 01806 512 512 wird gebeten",
	"hasWiFi": true,
	"hasTravelCenter": true,
	"hasRailwayMission": true,
	"hasDBLounge": false,
	"hasLostAndFound": true,
	"hasCarRental": true,
	"federalState": "Hamburg",
	"regionalbereich": {
		"number": 3,
		"name": "RB Nord",
		"shortName": "RB N"
	},
	"DBinformation": {
		"availability": {
			"monday": {
				"fromTime": "06:00",
				"toTime": "22:30"
			},
			"tuesday": {
				"fromTime": "06:00",
				"toTime": "22:30"
			},
			"wednesday": {
				"fromTime": "06:00",
				"toTime": "22:30"
			},
			"thursday": {
				"fromTime": "06:00",
				"toTime": "22:30"
			},
			"friday": {
				"fromTime": "06:00",
				"toTime": "22:30"
			},
			"saturday": {
				"fromTime": "06:00",
				"toTime": "22:30"
			},
			"sunday": {
				"fromTime": "06:00",
				"toTime": "22:30"
			},
			"holiday": {
				"fromTime": "06:00",
				"toTime": "22:30"
			}
		}
	},
	"localServiceStaff": {
		"availability": {
			"monday": {
				"fromTime": "06:00",
				"toTime": "22:00"
			},
			"tuesday": {
				"fromTime": "06:00",
				"toTime": "22:00"
			},
			"wednesday": {
				"fromTime": "06:00",
				"toTime": "22:00"
			},
			"thursday": {
				"fromTime": "06:00",
				"toTime": "22:00"
			},
			"friday": {
				"fromTime": "06:00",
				"toTime": "22:00"
			},
			"saturday": {
				"fromTime": "06:00",
				"toTime": "22:00"
			},
			"sunday": {
				"fromTime": "06:00",
				"toTime": "22:00"
			},
			"holiday": {
				"fromTime": "06:00",
				"toTime": "22:00"
			}
		}
	},
	"timeTableOffice": {
		"email"<EMAIL_ADDRESS>		"name": "Bahnhofsmanagement Hamburg"
	},
	"szentrale": {
		"number": 1,
		"publicPhoneNumber": "040-3918-1 053",
		"name": "Hamburg Hbf"
	},
	"stationManagement": {
		"number": 1,
		"name": "Hamburg"
	},
	"ril100Identifiers": [
		{
			"rilIdentifier": "AA",
			"isMain": true,
			"hasSteamPermission": true,
			"geographicCoordinates": {
				"type": "Point",
				"coordinates": [
					9.934858047,
					53.55257911
				]
			}
		},
		{
			"rilIdentifier": "AAS",
			"isMain": false,
			"hasSteamPermission": false,
			"geographicCoordinates": {
				"type": "Point",
				"coordinates": [
					9.934566886,
					53.551233586
				]
			}
		}
	]
}

ok?

The Travis CI build is almost done, after that the npm package should contain the latest data.

Ok great! I will check and close the ticket if it works 👍

Oh. Now I see.
It seems that db-hafas uses not the main evaId

Ok, let's continue this over at db-hafas. Would you mind to open a new ticket with more specific details? 😉

sure


Create table for storing form submissions

Now that we have a MySQL DB up and running on EC2, we need to create a table for storing raw form submissions.

Tables created via syncdb.


Added animated field to scrollResponderInputMeasureAndScrollToKeyboard() in ScrollResponder

Adds animated field to scrollResponderScrollNativeHandleToKeyboard()
which ultimately gets used inside scrollResponderInputMeasureAndScrollToKeyboard().

Test Plan
Video of the change in action:
Book Title field has animated set to false
Authors field is default

Related PRs
I don't think this will require a doc change. Please let me know if it does.

Release Notes

[GENERAL] [ENHANCEMENT] [ScrollResponder] - added animated field to scrollResponderInputMeasureAndScrollToKeyboard()

hey @hramos any updates on the status of this pr?

I don't have anything to add - please tag me when this has been reviewed by a member of the community.


Hey, i have a problem with BeeLogger

This is my problem
ine: cannot find '/root/.wine/drive_c/Python27/python.exe'
Traceback (most recent call last):
File "bee.py", line 161, in
main()
File "bee.py", line 134, in main
os.rename('dist/k.exe', 'dist/' + name)
OSError: [Errno 2] No such file or directory
sorry, i'm brazilian my english is bad

Hi, Please type "uname -a" and send me output.

turn on terminal
get on .../Desktop/BeeLogger/
write ls
write ./install.sh
or
python ./install.sh
it should help
check
write python bee.py

@krampus0101  excellent contribution, thank you. Greetings from Central America


Added _ErrorDescription.toString()

fixes: #106504
Minor change where I implemented the override of toString() in order to print a useful message in release mode as well as debug mode for an ErrorDescription. See issue for more info.
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

(triage) @gspencergoog Do you still have this one on your radar for review? Thanks.

I do!  Thanks for the reminder.

(triage) @Danau5tin Looks like one of the checks got stuck and unfortunately I cannot restart it. Could you rebase this PR with master to trigger the check again?


Add table of common Hutch data file sizes

This branch adds a table of common types of data generated by researchers at the Hutch and a general estimate of the size of one file of each data type. This will need to be updated once Amy has run the size estimates past Shared Resources staff.
This table was added to the beginning of the data_management_plan.Rmd

Resolves #7

Looks great!


Removed trailing newlines in bridged messages

Essentially there is a trailing newline at the end of bridged messages from discord to revolt, which is not present on the original message.
Since it only happens with messages send from discord and viewed in revolt I've only added the fix in discord.ts formatMessage as everything else seems to be working fine and I did not want to break something else.
Discord on left, Revolt on right
Before

After

Bonus, pic showing the issue does not happen when sending messages from revolt to discord.

I've ran the setup process on two different server pairs with two different bots just to make sure this wasn't a setup or server issue.
Not entirely sure if I'm the only one bothered by this, if nobody faced this issue so far or if I'm just the first one to make a PR for it...

I haven't encountered this issue, so I guess there is some special condition for it


Resolve WCAG 2.1 AA issues

Summary
Updating test structure for list items and adding aria roles for optgroups in the form-select based on https://github.com/w3c/aria/issues/719
This uses a version of terra-toolkit with the following rules enabled in axe-core:
'wcag2a', 'wcag2aa', 'wcag21aa', 'section508'

@bjankord will you be opening a pr in toolkit to add these?

@emilyrohrbough Yeah I plan to update the axe-core rules to 'wcag2a', 'wcag2aa', 'wcag21aa', 'section508' in terra-toolkit. Right now I've just been testing on these branches of terra-toolkit and terra-dev-site to resolve the issues before I turn on the rules in terra-core.


Testbed look_at() method doesn't seem to center the camera at the location given

I've been following the tutorial at https://nphysics.org/nphysics_testbed/ with some minor alterations but I can't understand what the look_at() method is doing. I have created a window and set the look_at position to the center of the view window (in theory) but this is not what appears.
Example code:
const WIDTH: f32 = 60.0;
const HEIGHT: f32 = 40.0;

fn main() {
    let mechanical_world = DefaultMechanicalWorld::new(Vector2::new(0.0, 0.0));
    let geometrical_world = DefaultGeometricalWorld::new();

    let mut bodies = DefaultBodySet::new();
    let mut colliders = DefaultColliderSet::new();
    let joint_constraints = DefaultJointConstraintSet::new();
    let force_generators = DefaultForceGeneratorSet::new();

    // Build a static ground body and add it to the body set.
    let ground_handle = bodies.insert(Ground::new());

   /// .. Spawn some objects at center and axis ...

    let mut testbed = Testbed::new_empty();

    // Tell the testbed your ground has an handle equal to `ground_handle`.
    // This will make it be drawn in gray.
    testbed.set_ground_handle(Some(ground_handle));
    // Provide to the testbed all the components of our physics simulation.
    testbed.set_world(
        mechanical_world,
        geometrical_world,
        bodies,
        colliders,
        joint_constraints,
        force_generators,
    );
    // Adjust the initial camera pose.
    let center = Point2::new(WIDTH / 2.0, HEIGHT / 2.0);
    println!("Center = {}", center);
    testbed.look_at(center, 20.0);
    testbed.add_callback(tick);
    testbed.run();
}

When run I get this window which is not the center I put in:

Is there a bug in the look_at() method or is there something we could add to the documentation to make it clearer what the expected behavior is?

Hi!
Perhaps explaining how the projection is setup will help understand how look_at works.
If you have a zoom factor equal to 1, the coordinate system of the 2D projection matrix is such that:

The point (0, 0) is at the center of the window.
The point (W/2, H/2) is at the top-right corner of the window.
The point (-W/2, -H/2) is at the bottom-left of corner the window.

where W and H are the width and height of the window.
So if you have a zoom factor equal to 20 as in your example, simply divide those values by 20, e.g., the point (W/40, H/40) will be at the top-right corner of the window.
In any case, no matter the zoom factor, if you want to position the camera such that objects at the coordinate (0, 0) lie in the center of the window, then you should simply look_at the point (0, 0).

Thanks for the explanation, I wasn't really sure what the zoom factor was. I think my problem is still a potential bug though as in the example I set the look_at position to be positive (30, 20) which I would expect to make the window center on that position instead of (0,0). However it seems to be doing something different (perhaps centering on (-30, -20)?).
The image isn't very clear but that line in the top half is a visible x-axis and there are balls spawned at (30,20) which should be visible.
    let center = Point2::new(WIDTH / 2.0, HEIGHT / 2.0);
    println!("Center = {}", center);
    testbed.look_at(center, 20.0);

This should be fixed in nphysics as of 0.14.0 as it updates kiss3d to 0.23.0 which contains the fix.


show on above the navigation bar

i try it but it show from top above the navigation bar,
how i can make it show under the navigation bar

in some case the script is fail in finding the navigation bar, can you plz add a hight, for it in that case so the control can act like if there is a navigation bar even if he faild to notice it

:+1: same problem for me

Yes, CVKHierarchySearcher fail.

@coverback  plz help

Hey! Can you try now, the 1.0.1?
I added a step to search for a UINavigationBar in controllers that don't use UINavigationController. I'm only searching in controller.view.subviews, though, to avoid a recursion.
In general, I'd recommend embedding view controller into a UINavigationController even if you don't push anything on top, to take care of the bar instead of adding it yourself.

Made another fix, now in CVKHierarchySearcher and bumped spec for AFMInfoBanner too.
Works for me for different combinations of tab, navigation and usual controllers.
If something is still not working for you, please comment and provide hierarchy for view controllers as well as if the controller has a custom navigation bar.

its still failng with the latest version
—
Sent from Mailbox
On Wed, Mar 11, 2015 at 11:59 AM, Romans Karpelcevs
<EMAIL_ADDRESS>wrote:

Closed #1.
Reply to this email directly or view it on GitHub:
https://github.com/ask-fm/AFMInfoBanner/issues/1#event-249969610

maybe you can grab some idea from this https://github.com/alobi/ALAlertBanner

That component uses incompatible approach by specifying the view to attach to. My goal is to show banner without having to specify anything.
Unfortunately I cannot assist you with your issue until there's a test-case.


Missing Typescript examples?

Type Inference was a major motivation behind the Function-API. Surprisingly, I can't seem to find examples or even mentions to Typescript support in the README.md. Only the Function-API RFC seems to cover Typescript support.

It works out of the box, pretty much everything is automatically or explicitly inferred because of how the api is designed. What were you expecting exactly?

I was expecting to see Typescript-specific examples, such as the ones in the RFC using createComponent() and showing how type inference works with props.
Everyone who's been following the RFCs pretty much knows that the Function-API supports Typescript naturally. But it would be great to make things more explicit especially for developers getting started with the new API.
I really want this epic API to take off.

Yeah, I think having docs in js makes it easy for both javascript and typescript developers to pick it up. Did you find any blocker when using typescript? Something that didn't work out of the box?

Typescript only works properly for me when using createComponent.

@pauloevpr  you can use Vue.extend()   to let TypeScript properly infer types  inside Vue component options
https://vuejs.org/v2/guide/typescript.html#Basic-Usage

I am not sure if I got your point. We are discussing about the new Function-API. According to the RFC:
"createComponent is conceptually similar to 2.x's Vue.extend, but it is a no-op and only needed for typing purposes."
So createComponent must be used instead of Vue.extend.
I opened this issue to report that the READ.me on this repo lacks Typescript examples. That is all.

@pauloevpr looks like the readme has a Typescript section now
https://github.com/vuejs/vue-function-api#typescript

Great. I am happy now. Thanks.


Should 1.1.12 have been a major version?

The new handling of negative numbers seems like it should have been considered a breaking change.

Note the first example in the readme is now wrong.
format( "#,##0.####", 1234567.890 );  // output: "1,234,567.89"
format( "$ #,###.00", -1234567.890 ); // output: "$ -1,234,567.89"

Please consider un-publishing and republishing as major

Sorry! I totally forgot it was a breaking change.
I've unpublished for now. I'll add it back with a minor update and a new option to turn that behavior on & off.

Hi, have you considered re-plublishing it ?
I could use ts support !
Thanx

@Mottie  Could you please publish the 2.0.0 release ? 🎉
Negative and Positive Signs are a game-changing feature !

Done... v2.0.0 has been released. I renamed the ignoreSign option to enforceMaskSign which is now false by default. Examples added to the readme.

Hmm, wow... even though all the tests pass, the readme examples and behavior with the enforceMaskSign is not what I am expecting.

Haha, nevermind... I forgot to update the readme examples.


Floating Horizontal Scroll Bar?

I am setting up Kanboard for use in project management. Swimlanes are project types; columns are key milestones in the project's life cycle. With large quantities of projects, the vertical height of the expanded Board grows and at quickly it becomes impossible to scroll to the right or left without first scrolling all the way to the bottom of the page, until the horizontal scroll bar appears.
Can that scroll bar be fixed in location and always visible?

If you click down the scroll-wheel on the mouse, you can scroll to the right / left - without having to go all the way to the bottom to locate the horizontal scroll bar.

Thanks for the tip, it works well!


Media Object, in Flexbox Mode, Content Overflows

Using 6.2 rc1 with flexbox mode enabled causes an issue with the media object. I have the following media object code:

Mission 10 February 2016

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris cursus facilisis arcu hendrerit egestas. In rhoncus arcu in magna imperdiet condimentum. Fusce fringilla quis dolor vitae scelerisque. Phasellus vel blandit tellus, ac suscipit mi. Pellentesque rhoncus ante non metus vehicula rutrum.

The paragraph in the media object section overflows the container.
In Firefox (v45) it overflows but does wrap eventually, screenshot:

In both Chrome (v48) and Edge (v25) the paragraph doesn't wrap at all and runs off the screen.
I can fix the issue by changing the CSS some:
This is the default:
.media-object-section {
    flex: 0 0 auto;
 }

Change to this:
.media-object-section {
    flex: 0 auto;
 }

I don't fully understand the flexbox properties yet (though I am learning!), so I don't know if that's the solution or if it's something else.

Media Object is the only component that requires a change in markup to work in flexbox mode. You need to add the class .main-section to the middle section of the media object, to change its flex property.
This is pointed out in the documentation, but it's not very obvious, so I wrapped it in a callout: e59bc2c965ef807ec332de657a79093bfc8b634a
I'm going to test your fix, but cross-browser issues might prevent it from working. Older browsers that implement flexbox have a habit of setting different defaults for various flex values, so sometimes omitting a value gets you into trouble.

Yes, I missed that. Thank you for adding the callout. It works properly now. :)

I tested your fix, and it doesn't work in Firefox if your media object has thumbnails, because Firefox has some wonky behavior with images inside of auto-sizing flex children. That behavior has been in place for a while in Firefox, but if it's ever fixed we could revisit your approach.

@gakimball - No worries! Thank you for checking. With .main-section I haven't had any problems so all is good. :)

@gakimball - This needs to be reopened and it is overflowing in IE 10 and 11 (Other browsers work fine.)
I tried changing this:
.main-section.media-object-section {
    -webkit-flex: 1 1 0;
    -ms-flex: 1 1 0;
    flex: 1 1 0;
}

to this:
.main-section.media-object-section {
    -webkit-flex: 1 1 auto;
    -ms-flex: 1 1 auto;
    flex: 1 1 auto;
}

And it appears to solve the problem but I just don't understand flex enough to fully understand what I'm doing there.
Is there a better solution?


Swipercore.use imports all modules in main bundle

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/s/dkqfem?file=/src/app/app.module.ts
Bug description
Hi (sorry about my english) I don't know how to put this build issue in codesandbox,
I am using swiper in angular 15 and installing modules via Swipercore.use,
Different modules in different lazy loaded pages, but then at build bundle, all modules are imported in main .js file for all routes, like this, this is main js file used in all routes

But in index component of any route I am installing like this, different modules for different routes:
Index component in Home Module

Index component inExample Module

And the router is like this:

(There are other pages that are not showed in the example)
Thanks for your help.
Expected Behavior
I would like to import different modules only in the route module that is used to avoid to generate an oversized main bundle file, and get correctly split code for child routes.
Actual Behavior
All modules are included in the main js file
Swiper version
1.8.x
Platform/Target and Browser Versions
Any
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

I just noticed that is becouse of the import methods
When you use
import { Thumbs, Keyboard, Lazy, Virtual } from 'swiper';
on lazy loaded modules, then the js files appears on the main.js file bundle

New Swiper v9 doesn't have Angular components anymore, it is recommended to use new Swiper Web Components instead.


OutOfMemoryError in Android WebSocketModule

Issue Description
We use two websockets simultaneous in our production app based on ReactNative. Exception tracking systems  Raygun and Google Analytics report that app crash sometimes with OutOfMemoryError while trying to create a new native thread in okhttp3.OkHttpClient.
According to the OkHttpClient manual, "OkHttp performs best when you create a single OkHttpClient instance and reuse it for all of your HTTP calls." However in the WebSocketModule OkHttpClient is instantiated on EVERY call of connect method (which in turn is called in WebSocket.js constructor).
I see here two problems:

If an app uses two websockets (like ours) OkHttpClient instance should be shared between websockets and likely with other networking communications done in WebSocketModule.
If a websocket is occasionally disconnection due to absence of Internet connection, then after reconnect the same underlying OkHttpClient must be used in order to save memory.

At the same time in ReactAndroid there exists a specific OkHttpClientProvider class which enforces singleton-style usage of OkHttpClient in all other Networking communications (in NetworkingModule).
@foghina, @mkonicek, what do you think? Should we use the same OkHttpClient in WebSocketModule which is used in NetworkingModule, i.e. invoke OkHttpClientProvider.getOkHttpClient() instead of instantiating a new OkHttpClient?
Or probably at least create another OkHttpClientProvider for websockets which is to provide OkHttpClient with websocket-specific timeouts?
Steps to Reproduce / Code Snippets
The issue is only reproduced in the production app deployed to Google Play on our customers' devices.
We could not reproduce it on neither of our developers devices.
Expected Results
WebSocketModule does not crash.
Additional Information

React Native version: issue reproduced in 0.32 (but in master branch WebSocketModule has the same code).
Platform(s) (iOS, Android, or both?): Android
Operating System (macOS, Linux, or Windows?): macOS

With each web socket using its own HTTP Client, and each client using its own connection pool, the number of threads in a React Native app can rapidly exceed 200:

Granted, after five minutes a cleanup thread wakes up and starts to deallocate these pools and thereby reduces the number of threads to a reasonable number - but only temporarily. Once the cleanup finishes, the number of threads starts to increase rapidly again - until the next five minute cleanup - and so on - in a continuous cycle.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with Canny! Check out its new home: https://react-native.canny.io/feature-requests/p/outofmemoryerror-in-android-websocketmodule


Spectral norm causes gradient signal to be lost when sigma exceeding coeff

Something I was struggling with with my own implementation of Gouk's spectral norm is that a spectral normalized layer seems to become stuck once the sigma values reach the coeff.
What I mean by this is:
Take a spectral normalized FC layer with 2 inputs and 1 output, and feed normally distributed random numbers into it, and ask it to maximize the output. This increases the weights until it reaches a sigma of > coeff.
Then take the same layer, feed the normally distributed random numbers into it and ask it to minimize the output. You'd expect this to decrease the weights until it reaches a sigma of 0, but it's sigma starts > coeff, nothing happens! In fact the weights don't receive very much gradient signal at all.
I think this might be because this line:
sigma = torch.dot(u, torch.mv(weight_mat, v))
happens with grad enabled, meaning that the gradient is propagated along this pathway, forcing the sigma to stay at 1.
I have made a notebook to demonstrate this problem, and my 'fix'
Gouk-jhjacobsen.zip
I'm not sure if this is the expected behaviour, I'd have thought this was analogous to the dying ReLU problem, as layers' sigmas become saturated they'd drop out and stop learning, which might be suboptimal.

Thanks very much for sharing your observations, we are looking into it and will get back to you here.

Not a problem. To further clarify, I think all that happens is that once
the layer reaches sigma > coeff, it's sigma becomes fixed at coeff, just
like the pytorch miyato implementation.
The layer weights can still update but they would be then constrained which
I think defeats the purpose of the soft normalisation.
I have a hunch that this may not be such a big problem in most cases as
only a few layers will run into sigma > coeff, as you pointed out that
MNIST training seems to be reversible even without the spectral norm.
On Tue., 18 Jun. 2019, 04:13 Jörn Jacobsen<EMAIL_ADDRESS>wrote:

Thanks very much for sharing your observations, we are looking into it and
will get back to you here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jhjacobsen/invertible-resnet/issues/4?email_source=notifications&email_token=AAOEUB7KZ7ZPSGBYX7U47PDP27H5NA5CNFSM4HYOSWS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4AJCQ#issuecomment-502793354,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOEUB6CM2CVMMJG73BQWC3P27H5NANCNFSM4HYOSWSQ
.

Now I understand what you mean, this is expected and in fact desired behaviour.


mergeDeep clobbers List items; concatDeep isn't implemented

merge appears to operate by key, which means merging two Lists together clobbers values (rather than appending them):
Immutable.List([1, 2, 3]).merge(Immutable.List([4, 5])).toJSON()
// [4, 5, 3]

concat doesn't have this problem; however, there's no concatDeep.
@leebyron, how do you feel about adding concatAll?  It would be a nondestructive union of any Immutable iterables, like so:
Immutable.fromJS(
  {
    "a":  [
            1
          ],
    "b":  {
            "fruits": [
                        "banana",
                      ],

            "place": "ireland",
          }
  }
).concatDeep(
  Immutable.fromJS(
    {
      "a":  [
              3
            ],
      "b":  {
              "fruits": [
                          "apple",
                        ],

              "author": "seuss",
            }
    }
  )
).toJSON()

// {
//   "a":  [
//           1,
//           3
//         ],
//   "b":  {
//           "fruits": [
//                      "banana",
//                      "apple",
//                     ],
//
//           "place":  "ireland",
//           "author": "seuss",
//         }
// }

This can currently be accomplished with a custom mergeWith:
var isList = Immutable.List.isList
var fromJS = Immutable.fromJS

function merger(a, b) {
  if (isList(a) && isList(b)) {
    return a.concat(b)
  }
  if (a && a.mergeWith) {
    return a.mergeWith(merger, b)
  }
  return b
}

fromJS({
  "a": [1],
  "b": {
    "fruits": ["banana"],
    "place": "ireland"
  }
}).mergeWith(merger, fromJS({
  "a": [3],
  "b": {
    "fruits": ["apple"],
    "author": "seuss"
  }
})).toJSON()

produces:
// {
//   "a": [
//     1,
//     3
//   ],
//   "b": {
//     "fruits": [
//       "banana",
//       "apple"
//     ],
//     "place": "ireland",
//     "author": "seuss"
//   }
// }

The root of this issue is what merge does on Lists, right @appsforartists? You expected merge to be the same as concat? I'm just trying to unpack the concerns listed here, I'm sure there's some API evolution we can do to make these ops easier to discover and viscerally understand.

I think you've got it, @leebyron!

Yeah, same thing here. When merging two Maps that have a List on a nested property, the second List overwrites the first one completely instead of the values being merged as well.
So, the following:
{todos: {list: [1, 2, 3]}}
{todos: {list: [3, 4, 5]}}
// gives
{todos: {list: [3, 4, 5]}}

I also definitely would love to see something to perform a deep concat!

merging by index isn't really useful behavior anyway, I think it should work as you propose @appsforartists but this will be a breaking change and need to wait for a version bump.

Ping for next major version!

Rather than add concatDeep, I think the functional expectation is that concat should be called deeply by default (monoids of monoids and all that).
One typical example is the Validation type:
Failure(
  Immutable.Map({
    username: Immutable.List.of("required")
  })
).concat(Failure(
  Immutable.Map({
    password: Immutable.List.of("is too short")
  })
)).concat(Failure(
  Immutable.Map({
    password: Immutable.List.of("must contain a special character")
  })
))

// expected:
Failure(
  Immutable.Map({
    username: Immutable.List(["required"]),
    password: Immutable.List(["is too short", "must contain a special character"])
  })
)

// actual:
Failure(
  Immutable.Map({
    username: Immutable.List(["required"]),
    password: Immutable.List(["must contain a special character"])
  })
)

-    password: Immutable.List(["is too short", "must contain a special character"])
+    password: Immutable.List(["must contain a special character"])

I've just faced an issue related to this fix. I have some merge calls on my code that merges maps with lists inside (those maps came from a normalisation using normalizr). The issue I face now is that everytime I merge, it duplicates the references for the other objects. I tried to change my reviver function on fromJS calls to transform those lists on Set, but I had another issue: Setdoesn't contain pop() or push() .
What do you guys suggest for this? Maybe a new Collection?


Fix a syntax error in Canvas2d.js

The fuzzing file Canvas2d.js contained a syntax error relating to quotes that cause Edge to throw a Javascript error and stop execution of any Javascript on the page.
This causes a problem because fuzzing is halted until Wadi restarts Edge, and then the problem repeats. It cuts down useful fuzzing time because when this bug is active, no fuzzing is going on.
I just changed the double quotes to single quotes and the problem was fixed.

Thanks, HunterStanton


BREAKING: Upgrade to Yarn 3

Upgrades the repository to use Yarn 3.

How is this breaking?

How is this breaking?

It isn't, will remove.


Add tests for Tokenizer, HashingTermFrequency and models

Add tests for core and runtime components of Tokenizer and HashingTermFrequency

This is taken care of by another issue to fully test mleap-runtime.


Make parser compatible with one-value truth value

✨New Feature
Make the Narsese parser compatible with one-value truth value(only frequency)
Example: (A --> B). %1.0% will be input as (A --> B). %1.0; 0.9%
📄Reference
OpenNARS:

PyNARS

Sure, thanks for the new feature!


retrieve attachments with find

hi
how can I retrieve attachments with find plugin?
I have tried using attachments:true,  in the find options but no success.

There isn't any way to do this currently in pouchdb-find; you would need to find the document ID and then do a separate get() or getAttachment() request. Looking at https://github.com/cloudant/mango it seems there is no explicitly-defined way to get documents or attachments, e.g. there is no include_docs.
Perhaps this would be a good opportunity to open an issue on CouchDB/Cloudant to support such a feature.

I'm closing this since its not an issue but a feature request. If you would like this feature the best approach is to send a mail to the CouchDB mailing list.


Trailing newline/whitespace included in macro expansion

Not sure if this is a ddox or dmd issue, but when there's a macro definition like this:
Macros:
	FOO = foo

	BAR = bar

(Note the blank line.)
The expansion of $(FOO) ends up being "foo\n\t" (ie, a trailing newline and tab) instead of "foo".

ddox implements it's own macro expander


Re-add support for dbt init <project_name>

Folks are used to being able to pass project name as a first positional argument to the dbt init subcommand. The new approach (new for v1!) is much more fun + interactive, but for muscle memory's sake, let's see if we can't find a way to keep supporting dbt init my_new_project, too.
If passed, I think this argument should be used as the implicit answer for "What is the desired project name?" We should set project_name accordingly here, and skip the prompt.
Related ask that we should foresee:

Ability to skip profile setup entirely, and just create scaffolding for a new project (--skip-profile-setup?). This could be used by tools which manage connection setup themselves, such as dbt Cloud
Ability to create project scaffolding in the current working directory, rather than always creating a new subfolder (#4141)

Hi @kadero, have you worked on this one already? If not, I am happy to raise a PR for it.

Hi @kadero, have you worked on this one already? If not, I am happy to raise a PR for it.

Hello @b-per,
Thanks for your message :slightly_smiling_face: .
Yes I began to work on it. I didn't find the time to finish the job (integration tests) and open a PR. I'm going to open a PR ASAP.
Thanks :pray:


Session updates can be overwritten in API

I added a test showing the bug. This fixes issue 40

@kristoferjoseph and @macdonst
If you guys can take a look at the test I added to double check my thinking. The feature could work either way, it just depends what we want it to do. Also, I can see people setting the session property on the json object in the API and being surprised that it gets overwritten. That is just something I think we need to document clearly.

We decided as a team to revert to the previous behaviour around sessions so this fix is no longer needed.


Upgrade to 18.03 results in herbsluftwm window nav resetting keyboard layout

Issue description
I upgraded to 18.03 this evening. My keyboard layout is getting forced to jp each and every time I navigate between windows. At one point in time I did use a jp keyboard, but lately I am back on a US layout and have set my configuration accordingly.
Steps to reproduce
Not entirely sure.
Technical details

system: "x86_64-linux"
host os: Linux 4.14.32, NixOS, 18.03.131792.becbe4dbe16 (Impala)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 2.0
channels(root): "nixos-18.03, unstable-18.09pre134503.e7d77fecfe2"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

Relevant part of my configuration.nix
    xserver = {
      enable = true;
      layout = "us";
      videoDrivers = [ "intel" ];
      xrandrHeads = [ "DP1-1" "eDP1" ];
      windowManager.default = "herbstluftwm";
      windowManager.herbstluftwm = {
        enable = true;
        configFile = "/home/bojo/.config/herbstluftwm/autostart";
      };
    };

Queries:
$ localectl status
   System Locale: LANG=en_US.UTF-8
       VC Keymap: us
      X11 Layout: us
       X11 Model: pc104
     X11 Options: terminate:ctrl_alt_bksp
$ setxkbmap -query
rules:      evdev
model:      pc104
layout:     jp,us  <- This goes back to "us" if I restart herb
variant:    ,
options:    terminate:ctrl_alt_bksp

The above layout in the setxkbmap resets if I swap back and forth between two windows.
Ping @the-kenny

It seems I had an errant .Xmodmap with jp settings confusing things.


Move Treehouse-based LazyColumn into upstream module

~I think this is what Veyndan ultimately wanted, but I'll chat with him next year to make sure it's everything.~ Looks like it based on #544.
Closes #544.

This is so dope


find alternative for tx outbox

currently we use gundb to store and encrypt transaction data that we want the receiver to have (in case we are sending directly to address and not via payment link)
consider

realmdb

create a new table on realmdb called 'inboxes'
index by txhash
add to out box

user read the recipient publickey from profile storage (Textile/crypto PublicKey.fromString(publickey))
user encrypt data using publickey
user save record to db {txhash,encrypted}

read from out box

user read record by txhash
user decrypt "encrypted" using his private key
user updates feed data

@vldkh pushed fix for dev+qa

@serdiukov-o-nordwhale @sirpy
The message in transaction feed cards is not displaying on the receiver side. Works only via the Recieve method.
Environment:
QA 1.30.1-13
DEV 1.30.1-13
Devices:
Windows 10 // Google Chrome v92
Attachments:
https://www.screencast.com/t/jUSo0IuVov

@vldkh fixed on dev

@sirpy
Checked transactions on DEV env. (1.30.1-14)
Transactions via the "Recieve" method:
There are still no messages displaying on both accounts. But to RECIEVER there are no feed transactions cards displaying.
SENDER has the feed transactions cards but without messages. In both cases, the balance was updated according to the send value
The same result with both methods of "Recieve"
Transactions via the "Send" method:
To RECIEVER - the feed transaction card is displayed but without a message.
To SENDER - the feed transaction card is displaying as "pending card".
The balance was updated according to the send value.
Environment:
DEV 1.30.1-14
Devices:
Windows 10 // Google Chrome v92
Attachments:
https://www.screencast.com/t/hLuvhOC36wWd

@sirpy
Also, the balance is not displayed on web QA env.
Environment:
QA 1.30.1-14
Devices:
Windows 10 // Google Chrome v92
Attachments:
https://www.screencast.com/t/R4V17EsW
Note: the balance is displayed on DEV and PROD envs

@vldkh fixed on dev
the balance issue on QA is because we upgraded to the new contracts. pushing a fix directly to QA...

@sirpy @lukasz-kilaszewski @johnsmith-gooddollar
checked via #3326


add grocy

What this PR does / why we need it:
Add Grocy, a web-based self-hosted groceries & household management solution for your home.
Which issue (if any) this PR fixes:
Fixes #691
Any other useful info:
Looks like a neat inventory app. I haven't fully explored it, but I'm going to try to track my home bar fridge.

Closing as a duplicate of #635


download artifact, no such file or directory

Greetings,
I have been testing out a fork of osv-scanner to add support for matrix's. Most of it works. however I am being stumped on this open /github/workspace/amd64.status': no such file or directory   error.
I have two artifact files that get uploaded and downloaded into the OSV action. The files successfully download into the correct directory, however the scanner finds no file.
Error

Logs:  https://github.com/GeoDerp/emhass/actions/runs/10026253342/job/27710383510
I can validate that the file is indeed being downloaded to the directory (/home/runner/work/emhass/emhass) that is being mounted to /github/workspace/:

Action snippet:
.
.
.
# previous job creates amd64.status and amd64-requirements.txt in ./OSV/
      - name: Upload package list as digest
        uses: actions/upload-artifact@v4
        with:
          name: ${{ matrix.platform.target_arch }}-packages
          path: ./OSV/*
          if-no-files-found: error
          retention-days: 1
.
.
.
  # Google OSV-Scanner
  osv-scan:
    needs:
      - build
    strategy:
      matrix:
        platform: [
          {target_arch: amd64},
          # {target_arch: armv7}
          # {target_arch: armhf},
          # {target_arch: aarch64}
        ]
    uses<EMAIL_ADDRESS>    with:
      download-artifact-directory: "./"
      download-artifact: "${{ matrix.platform.target_arch }}-packages"
      results-file-name: "${{ matrix.platform.target_arch }}.sarif"
      security-category: "${{ matrix.platform.target_arch }}-OSV-Scanner"
      scan-args: |-
        --lockfile='dpkg-status:./${{ matrix.platform.target_arch }}.status'
        --lockfile='requirements.txt:./${{matrix.platform.target_arch }}-requirements.txt'
        --recursive
        --skip-git
        ./
    permissions:
      security-events: write
      contents: write

The download-artifact-directory input will be removed before I make a PR, just for current testing.
Full action here: https://github.com/GeoDerp/emhass/blob/OSV-integration/.github/workflows/publish_docker.yaml
Used osv-scanner-reusable.yaml: https://github.com/GeoDerp/osv-scanner/blob/main/.github/workflows/osv-scanner-reusable.yml
Quick Note: I have tweaked things like permission variables in the main action. However, that does not seem to help.

Sorry we missed this issue for so long! I'll look into this next week and will try to figure out why this is happening.

https://github.com/google/osv-scanner/pull/1441
Closing due to finding the problem.
It was unhappy with ' in:
        --lockfile='dpkg-status:./${{ matrix.platform.target_arch }}.status'
        --lockfile='requirements.txt:./${{matrix.platform.target_arch }}-requirements.txt'

It would include the last quotation mark as the file name. Setting the action to:
        --lockfile=dpkg-status:./${{ matrix.platform.target_arch }}.status
        --lockfile=requirements.txt:./${{matrix.platform.target_arch }}-requirements.txt

Was enough to fix the issue.


perf(client): ⚡ Cache static assets

This PR changes URLs like /images/winloss/catfish-win.webp to URLs like /_app/immutable/assets/catfish-win-a02ca162.webp the a02ca162 at the end is a file hash so if we change the file contents we will also change it's URL. this means that we can tell the browser that the file at that URL will never change so it doesn't need to request it ever time it visits the page it can just use the one it cached last time the user visited the page.

there's two different height values for the body tag element

this was intentional because not all browsers supported the dvh unit so vh is a fallback
that being said Chrome has now added support for dvh so maybe we should consider removing the fallback
https://caniuse.com/mdn-css_types_length_viewport_percentage_units_dynamic

there's two different height values for the body tag element

this was intentional because not all browsers supported the dvh unit so vh is a fallback
that being said Chrome has now added support for dvh so maybe we should consider removing the fallback https://caniuse.com/mdn-css_types_length_viewport_percentage_units_dynamic

ahhhhh i see okay then this is good to go


Images not loading when using SSL proxy

Is there any documentation on proxying to librephotos with SSL terminating beforehand?
I'm getting this on the frontend when trying to do this:
 Failed to load resource: the server responded with a status of 401 (Unauthorized)

What do you mean when you say "terminating beforehand"?
Typically all client requests go through the proxy container (in my case nginx with Letsencrypt certs) and are then passed on within the server network without any SSL.

@polaroidkidd Yes that's what I said, SSL terminates on my own proxy server and is then forwarded to librephotos.
Is there any specific configuration needed on my proxy server to prevent the above and other errors? The site and dashboards load but no images load, they are blurred out.

SSL terminates on my own proxy server and is then forwarded to librephotos

This is the standard setup and should work as advertised.

they are blurred out

that's really weird. Can you show some logs of the network tab and if the console is throwing any errors?
Which version are you using? Can you try the dev tags and see if that resolves the issue?

@polaroidkidd  I think you are misunderstanding, I'm saying that I'm using my own proxy server for all of my services hosted here, I know it's normal setup but there are no included configs for nginx/apache so I'm asking if there are any specific proxy_headers or something required for this to work.
There are literally 100s of logs, it keeps hitting "api/rqavailable/" and getting 200OK, but maybe more in console including below, but the main issue seems to be the 401 for almost all requests.
Failed to load resource: the server responded with a status of 404 (Not Found)

/media/square_thumbnails/fe1a6a007086ca8d8cf76b26a1fa84dd1/:

Uncaught TypeError: Cannot read properties of undefined (reading 'userApi')
    at Object.extractRehydrationInfo (user.api.ts:31:21)
    at createApi.ts:234:7
    at c (defaultMemoize.js:123:20)
    at createApi.ts:260:21
    at c (defaultMemoize.js:123:20)
    at createReducer.ts:239:20
    at Array.filter (<anonymous>)
    at c (createReducer.ts:239:10)
    at reducer (createSlice.ts:325:14)
    at redux.js:528:29

its a crazy week at work atm and I'm afraid that I won't have the time to look into this more closely until the weekend, I hope that's not too late for you.

Right, so I had a quick look on my selfhosted instance and I can't reproduce the error. Are you also running the image tag 509200069a42 ?
It could also be a side effect of me migrating some of the API over to rtk-query recently. Does the error persist when you logout, clear all cookies and delete the local-storage entries?

@polaroidkidd no rush on this I'm only just getting set up for the first time.
This is what I'm running:
reallibrephotos/librephotos-frontend   latest    120def496c3c   8 days ago   31.4MB
reallibrephotos/librephotos            latest    20c8149351bd   8 days ago   6.64GB
reallibrephotos/librephotos-proxy      latest    85d68bbd1794   8 days ago   142MB

Not sure, if you ever got around to changing the tag, but the new release is also online which should fix this issue :)

@shaun-ba  are you still experiencing this or can we close this?

Having the exact same issue using my own reverse proxy (Nginx Proxy Manager), previews blurried and lots on unauthorized log messages everywhere doing anything:

The error is pretty clear. It can't find the thumbnail, which means, that you either played around with the proxy of librephotos, and it does not redirect to the protected_media folder anymore, or you did not set up the data folder properly.

os, and it does not redirect to the protected_media folder anymore, or you did not set up the data folde

True! Just managed to fix it, i didn't realise that protected_media was mounted also by proxy, and as i mount this volume on a NFS share i forgot to change proxy mounting path also... Thanks for the help :)


feat: added a convenience method that will return an existing item du…

…ring a check for insertion

Issue being fixed or feature implemented
This change implements a new function insert_if_not_exists_return_existing_element in GroveDB. The function allows for the insertion of an element if it does not already exist at the specified path and key. If the element already exists, the function returns the existing element instead of performing an insertion. This is useful for scenarios where we want to avoid overwriting existing data but still need to confirm its presence.
What was done?
•	Added a new function insert_if_not_exists_return_existing_element to GroveDB.
•	This function checks if an element already exists at the given path and key.
•	If the element exists, it returns the existing element.
•	If the element does not exist, it inserts the new element and returns None.
How Has This Been Tested?

Breaking Changes
This change does not introduce any breaking changes.
Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[ ] I have assigned this pull request to a milestone

@coderabbitai review


(@Clastia) gen9camovegg: adding tour code

@Clastia: "adding tour code"
Created via Iolanthe on Fri, 24 Mar 2023 22:46:54 GMT.

ignore this one too the code has double sleep moves clause


Make the PurchaseInfo class overrideable

Resolves #2399

As per #2399 - you can customize your strategy class, no need to customize PurchaseInfo. Thanks.