page.type fails on Japanese character

Steps to reproduce
Tell us about your environment:

Puppeteer version:1.4.0
chrome: 69.0.3497.81（Official Build)(64Bit)
Platform / OS version: El Capitan 10.11.6
URLs (if applicable): N/A
Node.js version: 8.11.2
npm: 5.6.0

What steps will reproduce the problem?
Error occurs when typing Japanese character(s)
    await page.waitFor('input.selector');
    await page.focus('input.selector');
    await page.type('input.selector', 'あいうえお'); <<<<<<

What is the expected result?
Expected to type Japanese character(s)
What happens instead?
Failed to type Japanese character(s)
stack trace
(node:8365) UnhandledPromiseRejectionWarning: Error: Protocol error (Input.insertText): 'Input.insertText' wasn't found
    at Promise (/Users/uu091430/project/jbg-ga/app/node_modules/puppeteer/lib/Connection.js:203:56)
    at new Promise (<anonymous>)
    at CDPSession.send (/Users/uu091430/project/jbg-ga/app/node_modules/puppeteer/lib/Connection.js:202:12)
    at Keyboard.sendCharacter (/Users/uu091430/project/jbg-ga/app/node_modules/puppeteer/lib/Input.js:151:24)
    at Keyboard.type (/Users/uu091430/project/jbg-ga/app/node_modules/puppeteer/lib/Input.js:166:20)
    at ElementHandle.type (/Users/uu091430/project/jbg-ga/app/node_modules/puppeteer/lib/ExecutionContext.js:413:31)
    at <anonymous>
  writeOut
  output
  process.on
  emitOne
  emit
  (anonymous function)
  _combinedTickCallback
  _tickCallback
(node:8365) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
  writeOut
  output
  process.on
  emitOne
  emit
  (anonymous function)
  _combinedTickCallback
  _tickCallback
(node:8365) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
  writeOut
  output
  process.on
  emitOne
  emit
  (anonymous function)
  _combinedTickCallback
  _tickCallback

Puppeteer only supports the Chromium version it is bundled with. Older versions won't work.


Add PyAnsys badge

Continuation of https://github.com/pyansys/pypim/pull/40.

Codecov Report

Merging #45 (c9185e9) into main (779ba4a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   90.95%   90.95%
=======================================
  Files           6        6
  Lines         221      221
=======================================
  Hits          201      201
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779ba4a...c9185e9. Read the comment docs.


User can submit feedback or bug reports

User Story

User starts TauLidarServer and navigates to web-based point-cloud viewer
User clicks on Feedback button in the sidebar (maybe a 💬  emoji?)
Observe modal shows up with:

Submit bug report or feature request - link to tau-lidar-server github issue page
where to go for general discussion about the Tau - link to Tau category on Onion Community Forum

User clicks anywhere outside of modal, observe help modal closes

Implemented in 908fb7a34997afd4fb6de84cff10fb7929d30a12
Released in v0.0.5


Perma ban statistics

There was an old one, but it gets old and no one is reporting anything there.
I have several accounts, all running fine for more than a week. Anybody else have banning issues?
At first, I thought it was the bot that is causing banning problem. But after I tested more, I find it's in the settings. If you do settings right, you should be fine.

My 2 cents: bans come by waves, and it will come again, dont worry.
All people snipping will get ban because it is easy to detect. Others might have a chance but I would not hope too much because bots are not perfect yet.

Yeah I would expect the next big ban wave to come when the Gen2 update hits. I believe thats rumoured to be happening in the next couple of months.
Don't count you're chickens just yet ;)

I think I broke the game! For about 1 month I am over Level 20. At this time lvl 29.
I started with a new ptc account and start only with the bot. At lvl 21 I logged in from my smartphone for the first time. I first had to choose my starter Pokemon (Squirtle CP 545). Then the guy said to me I had to move to a arena (or what ever he said), to choose my team (blue).
I got no avatar and when I want to create one to myself the game crash.
When I walk around I see no avatar walking, just a tiny round shadow.
I found out last week, after my first arena-fight, that when I am the leader of an arena and you try to fight me, the game crash again. This take affect for every player who wants to fight me.
At this time I am the leader of 13 arenas. The strongest Pokemon is a Venomoth (CP 787).
I use dev (pull every day) with standard config.json (no changes where made)

Well that is why the bot instructions do (or did) say you should complete the tutorial first, and why bot activity related to gyms is generally frowned upon...

still wait to see the ban wave to come.

I could be IP banned. The bot stopped working. I'll try to use the bot in a coffee shop later on. To see if it's IP ban or something else.

Nice chat, but not an issue. Take it to slack.


UnhandledPromiseRejectionWarning:

Bug Report

Node.js version: 9.1.0
TSLint version: 5.9.0
TypeScript version: 2.6.2
Running TSLint via: tslint-webpack-plugin 1.0.0

TypeScript code being linted
this project
https://github.com/javascript-obfuscator/javascript-obfuscator/tree/master/src
with tslint.json configuration:
https://github.com/javascript-obfuscator/javascript-obfuscator/blob/master/tslint.json
Actual behavior
error
(node:69959) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 4): TypeError: Cannot read property 'map' of undefined
(node:69959) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Expected behavior
no errors
Description
After updating from 5.8.0 to new 5.9.0 version i got this error. ts-lint is running via<EMAIL_ADDRESS>

Going to close this issue as it appears to be resolved by @peterreisz 's comment above.


Bad UTF-8 encoding (U+FFFD; REPLACEMENT CHARACTER) found while decoding string

After all possible installer updates, problem persist
unable to use flutter , unable to run flutter doctor
Exception: Bad UTF-8 encoding (U+FFFD; REPLACEMENT CHARACTER) found while decoding string: [
{
"instanceId": "fd040e54",
"installDate": "2022-03-26T13:34:42Z",
"installationName": "VisualStudio/16.11.11+32228.343",
"installationPath": "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community",
"installationVersion": "16.11.32228.343",
"productId": "Microsoft.VisualStudio.Product.Community",
"productPath": "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\devenv.exe",
"state":<PHONE_NUMBER>,
"isComplete": true,
"isLaunchable": true,
"isPrerelease": false,
"isRebootRequired": false,
"displayName": "Visual Studio Community 2019",
"description": "IDE avan�ado, gratuito para estudantes, colaboradores de c�digo aberto e indiv�duos",
"channelId": "VisualStudio.16.Release",
"channelUri": "https://aka.ms/vs/16/release/channel",
"enginePath": "C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service",
"installedChannelUri": "https://aka.ms/vs/16/release/channel",
"releaseNotes": "https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes-v16.11#16.11.11",
"thirdPartyNotices": "https://go.microsoft.com/fwlink/?LinkId=660909",
"updateDate": "2022-03-26T13:34:42.0551732Z",
"catalog": {
"buildBranch": "d16.11",
"buildVersion": "16.11.32228.343",
"id": "VisualStudio/16.11.11+32228.343",
"localBuild": "build-lab",
"manifestName": "VisualStudio",
"manifestType": "installer",
"productDisplayVersion": "16.11.11",
"productLine": "Dev16",
"productLineVersion": "2019",
"productMilestone": "RTW",
"productMilestoneIsPreRelease": "False",
"productName": "Visual Studio",
"productPatchVersion": "11",
"productPreReleaseMilestoneSuffix": "1.0",
"productSemanticVersion": "16.11.11+32228.343",
"requiredEngineVersion": "<IP_ADDRESS>712"
},
"properties": {
"campaignId": "5",
"channelManifestId": "VisualStudio.16.Release/16.11.11+32228.343",
"nickname": "",
"setupEngineFilePath": "C:\Program Files (x86)\Microsoft Visual Studio\Installer\setup.exe"
}
}
]
.


[BUG] Fix invalid replay argument for create and fresh materialized view

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #8008
Problem Summary(Required) ：

Fix invalid replay argument for create and fresh materialized view. If isReplay is true, it is used when replay image log. When create mv and refresh mv, it should be false.

@ABingHuang You should why you change it from true to false. I don't know why

[FE PR Coverage check]
:disappointed: fail : 1 / 2 (50.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
1
2
50.00%

LGTM

@ABingHuang You should why you change it from true to false. I don't know why

hi, @imay , taskManager.createTask's second argument is isReplay. If isReplay is true, it is used when replay image log. When create mv and refresh mv, it should be false.

How could we test this bug and where are the test cases?


Allow hiding password length

Addresses comments to #386
This PR allows you to set the HideCharacter to a space which will be interpreted by the RuneReader to mean that the user input should not be echoed and that it shouldn't print a "mask" either.

This seems good - mind adding a test case to [this file[(https://github.com/go-survey/survey/blob/master/tests/password.go)?

This looks good - mind adding a test case to this file?

I don't see how to add a test case there since the prompt is the same. I think this would require some refactoring. Do you want me to attempt?

@AlecAivazis can we get this moving?

Yea feel free to refactor the tests to verify this behavior

Whoops! Wrong button 😅


johndanz/ch5447/update-all-actions-to-pass-a-type-data-instead

https://app.clubhouse.io/augur/story/5447/update-all-actions-to-pass-a-type-data-instead-of-custom-property-names

This pull request introduces 1 alert when merging 69085798d821542b26267d1040a2db627c5a55e1 into 0ae7a1375cf6014bb4edcc9fc38573d7e2c31d09 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

Coverage decreased (-0.04%) to 63.796% when pulling 69085798d821542b26267d1040a2db627c5a55e1 on johndanz/ch5447/update-all-actions-to-pass-a-type-data-instead into 0ae7a1375cf6014bb4edcc9fc38573d7e2c31d09 on master.

This pull request introduces 1 alert when merging 7704c701057a58c9d2f1579d7f6759d1aadca37f into 154457a5b753b8c70ea26446ca0c88eb5d5eb548 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 08c61bdf071970beb185bdce12b6f2e55d624673 into 154457a5b753b8c70ea26446ca0c88eb5d5eb548 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 4c3f17e279172f95d02d0cd938fde8025b99efff into 69235ad3c7ff1465fdf02979b15b99dd9c43c8d0 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 0f2380791872291aac2028bf9ad85460b86693f4 into f2c000959a15e65e48d4c9e174272ceaae9ceadb - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert when merging c759394d517eed9f3a85bbc3a8eeb5b5e667edb2 into 6464ff10f2e2cb6ba3a4c2dbf862e180da7f1b8d - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com


Filter bar scrolling is broken

I'm here:

and then I scroll down a bit and filter bar starts scrolling up! that's not what we want. some recent PR must have created this bug :(

Can I close this issue?

Yep!
Sent from my iPhone

On Dec 29, 2018, at 11:33 AM, Hank Tadeusiak<EMAIL_ADDRESS>wrote:
Can I close this issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


refactor(concurrency): move commit_chunk API to ThreadSafeVersionedState

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.04%. Comparing base (aebdfae) to head (41a7e1e).

Additional details and impacted files
@@                                  Coverage Diff                                   @@
##           barak/execute_chunk/change_initial_state_to_arc_mutex    #1926   +/-   ##
======================================================================================
  Coverage                                                  78.04%   78.04%
======================================================================================
  Files                                                         61       61
  Lines                                                       8759     8759
  Branches                                                    8759     8759
======================================================================================
  Hits                                                        6836     6836
  Misses                                                      1485     1485
  Partials                                                     438      438

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added assertThatException

Add assertThatException in complement of assertThatThrownBy.
This patches add two classes: ExpectThrowableAssert and ChainedThrowableAssert. The first delegate to the second and will check that the lambda actually throw an exception of expected type.
Also, this allow for chaining:
IntConsumer lambda = int n -> {
  if (n < 0) throw new IllegalArgumentException(n + " is negative");
  if (n > 100) throw new IllegalArgumentException(n + " must be less or equals to 100");
}
assertThatException(IllegalArgumentException.class)
  .isThrownBy(() -> lambda.accept(-1))
    .hasMessage("-1 is negative")
  .isThrownBy(() -> lambda.accept(101))
    .hasMessage("101 must be less or equals to 100")
;

To be compared with the existing assertThatThrownBy:
assertThatThrownBy(() -> lambda.accept(-1))
  .isInstanceOf(IllegalArgumentException.class)
  .hasMessage("-1 is negative")
;
assertThatThrownBy(() -> lambda.accept(101))
  .isInstanceOf(IllegalArgumentException.class)
  .hasMessage("101 must be less or equals to 100")
;

As said in the javadoc, assertThatException is named like that because of assertThat(Class) and type erasure.

Thanks, that's interesting, I would rename hasMessage to withMessage to make things more fluent:
assertThatException(IllegalArgumentException.class)
  .isThrownBy(() -> lambda.accept(-1)).withMessage("-1 is negative")
  .isThrownBy(() -> lambda.accept(101)).withMessage("101 must be less or equals to 100");

I will review that in few weeks (pretty busy right now)

Good idea.
I pushed another commit bringing a lots of with method, and deprecated (in the Chained class) the hasXXX methods (I can't rename them, otherwise assertThat(Throwable).hasMessage(String) would lose its meaning).

closed after deleting java8 branch

I'm about to integrate this PR with few internal changes, I'm also thinking to change the entry point method to assertThatExceptionOfType instad of assertThatException, with that change assertion code would look like:
assertThatExceptionOfType(IOException.class).isThrownBy(() -> { throw new IOException("boom!") });
                                            .withMessage("boom!");

WDYT ?

I'm not against it, and even find it more fluent.

change done - PR integrated.


Scrollbar and tables

I am trying to add a scrollbar to the tbody of my table, so only the body scrolls and the table-head stay "fixed" - the scroll bar is being applied and it works fine, but the width of my table-body has shrank and it is not 100% as it should be.

The scrollabr is being added using the .scrollable class which you will find in
I have put a live test for you here: http://loai.directory/test1/admin/users.php
Please help

I have same problem

@TolgaKisa Can you send me a test page or link?

http://codepen.io/dragospaulpop/pen/asBcI check this it's work fine for me


Adapt for Multi Tenancy

Please note this is still a draft.
While this is working, and not giving exceptions, it's duplicating the event handlers in the report, as they are both registered as for example giftcard@tenant-aap, giftcard@tenant-noot, giftcard@tenant-mies as part of the giftcard event processor, which with this pr will add giftcard~t~tenant-aap, giftcard~t~tenant-noot, giftcard~t~tenant-mies because of the other 'unique' seperator. So I don't think this is a good approach, likely, at least with persistent streams mt extension, we can just ignore the mt event processor.

I validated with the old setup, removing the configuration for persistent streams, that it will also cause duplications. Therefore, I added a commit to simply ignore the combined multi-tenant event processor. Please note this change is not enough to make them show in the UI, but it does remove the class cast exceptions.


#[belongs_to()] silently ignores additional parameters

Versions

Rust: rustc 1.37.0-nightly (400b409ef 2019-06-09)
Diesel: 1.4.2

Problem Description
When a model has multiple associations, the developer might intuitively do the following:

belongs_to(Parent1, Parent2)

...whereas they are supposed to do:

belongs_to(Parent1)
belongs_to(Parent2)

When passing multiple parameters to belongs_to the compiler will silently ignore the second association and the code will compile. The problem is not exposed until the developer tries to call belonging_to(Parent2).
What are you trying to accomplish?
Create a model with two parent associations so I can call belonging_to() for either of those parents.
What is the expected output?
The compiler should warn about the incorrect syntax for belongs_to() and advise on the proper syntax. From a usability perspective, allowing multiple associations to be passed to belongs_to() would be an intuitive solution.
What is the actual output?
Nothing. The code will compile silently without error (unless belonging_to(Parent2) is called.
Checklist

[x] I have already looked over the issue tracker for similar issues.
[x] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)

Thanks
A massive thanks to the maintainers and contributors to Diesel. This is a really great ORM.

That is probably caused by this code. If anyone is willing to look into this just ping me for help/mentoring/…

@weiznich I looked into this and added the special warning in #2147. Due to the proc macro diagnostics being a nightly feature, the warning is eventually just printed to the console by default. Let me know if there's a better way to do this.

Is there actually nothing emitted? We have tests which say this would have emitted:

warning: Unrecognized option Parent2

with a span pointing to the problematic code on nightly, and just printing to stdout on stable

Previously it would emit a warning with "Unrecognized option {}". The change is to emit a more specific message if the option looks like an extra parent.


Evaluator device placement

This PR ads device placement for the pipeline in the evaluator. There are two mechanisms:

The user can pass a device to Evaluator.compute.
If no device is passed we attempt to infer if a GPU is available and device 0 is used.

Alternatively, a user can always use a custom configuration and initialize the pipeline before passing it to the evaluator. If the an initialized pipeline is passed the device has no effect.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Add kyphosis disease classification

Problem Link
This is a Kyphosis Disease Classification using decision tree and random forest.
Description
Kyphosis is a spinal disorder in which an excessive outward curve of the spine results in an abnormal rounding of the upper back.
This project allow us to predict the presence or absence of Kyphosis based on the Kpyhosis dataset using a Random Forest and Decision Tree Machine Learning Model.

@Mrdecent08 have look!

You can work on it and open a PR

Hey there !!!
I'm owing you an apology for not being able to respond further in the
process of making a pr. I have made more than 4 pr's which got matured
recently in hactoberfest . But, due to this invalid PR which you labelled..
it is affecting in contributing to hacktoberfest.
I am unfortunately unaware of the fact that making spam pr's will affect my
contribution as I'm a newbie in open source contribution. Please do kindly
consider my mistake and i owe you to remove that label. I'm making a
promise that i will create a new issue and surely i will work on it by
making a valid pr now.
I will seriously work on it right away.
Please do remove the label. I hope i will never do such types of mistakes
again.
On Thu, 14 Oct 2021, 2:16 pm Rakesh, @.***> wrote:

Closed #26 https://github.com/gdsc-gvp/Machine-learning/issues/26.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/gdsc-gvp/Machine-learning/issues/26#event-5462262994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASAIHMLKQQC5NFD4662KLXLUG2KHRANCNFSM5FHORNZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Feature Request: Ctrl+Space to see list of columns

When I press Ctrl+Space in the query input box, I wish a list of auto-completable column names would show up. It would make writing WHERE queries faster and easier.

Column completion is a really good idea. I'll get to it at some point


Add Walk Cancels Consistently

See title.
Currently only Klee has a manual exception for this, but technically this can be done with every character.
Currently mostly only relevant for catalyst attackers... Not sure if there's any instance of this happening often for non-catalysts since they mostly use dashes/jumps.

We can certainly add walk in as an action. Question becomes though what the frame count would be...

I poked around in KQM and was led to this ticket that attempted to explore the mysteries of walk cancels until it went untouched for a month and archived https://tickettool.xyz/direct?url=https://cdn.discordapp.com/attachments/923418129219092520/931977067698995231/transcript-catalyst-walk-cancel-frames.html

We can certainly add walk in as an action. Question becomes though what the frame count would be...

@srliao I checked a few videos and I think walks should by default be 1 frame given how both Klee and Ningguang's NA walk cancels work, so I added it in #258
If someone wants a longer walk then they can use the "delay" parameter that we'll be adding to all actions or something?


Mqtt2db

add db and mqtt2db services
closes #16

problems that were solved and documentation for this issue:
Discussion: https://github.com/Phape/smart-security/discussions/18#discussioncomment-920747
Wiki: Datenbank


dir does not allow templates:

          `dir` does not allow templates:

https://github.com/jdx/mise/blob/36a19f87b80aafb15f33dd818f3a4b4a0277c295/docs/tasks/toml-tasks.md?plain=1#L25
Originally posted by @powerman in https://github.com/jdx/mise/issues/2873#issuecomment-2453930927

this seems to be working now


Update akka-stream_2.13 to 2.6.8

Updates com.typesafe.akka:akka-stream_2.13 from 2.6.6 to 2.6.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka", artifactId = "akka-stream_2.13" } ]

labels: library-update, semver-patch

Superseded by #15.

Superseded by #15.


Missing plugin update prompt in Sketch

Sketch 50.2, "From Almost Sketch to Sketch" 3.0.2
In Plugins > Manage Plugins… there was no indication to update "From Almost Sketch to Sketch", despite 3.2.0 being the current version of the plugin.
This led to a little confusion , as I didn't realise there was a new version of the plugin — other plugins do show an update prompt — but did need to get the latest version for compatibility with story2sketch 1.1.0 (which depends on html-sketchapp 3.2.0).
Once I'd realised the problem, was simple to update by manually uninstalling asketch2sketch 3.0.2 and downloading/installing asketch2sketch 3.2.0.

Good call, thanks for reporting this! We should probably start embedding html-sketchapp version used in .asketch.json output and then check it in the plugin.


Add Rregression Models

@maneetgoyal sir , for now I am just trying to console log these things, but this is not creating the js files.

Yeah @maneetgoyal sir the above issues are okay, but I have tried it with simple regression modules and used simple arrays as well, but it was not creating the js file on build. Can you please make some changes according to the browser implementation and try to build the js file and check if the contents of models/regression/index.ts is there in the build file or not?

Can you please make some changes according to the browser implementation and try to build the js file and check if the contents of models/regression/index.ts is there in the build file or not?

Already mentioned that I will pull the branch in a bit. have some patience!

changes made, regression content sis now in final js bundle

demo can be made via separate PR, these changes can go in


Case insensitive comment string matching

resolves #35589

@oriash93 I don't know if this is true for all programming languages... But not a lot of programming languages use ASCII for comments either, so it might just work...

@alexandrudima Here is a comparison of comments in some programming languages..
As you can see, some do contain alphabetic characters. Are they relevant to vscode? If these cases worth considering a different solution, let me know.


QuickInfo navigation link underlines are difficult to see.

As mentioned in #4644 adding a TextDecoration to the navigable QuickInfo link results in a black underline that's difficult to see, especially in the dark theme.
This can likely be corrected by checking the theme's color and manually setting it in WpfNavigableTextRunViewElementFactory.fs.  See below; Uno, Dos, and Tres each have an underline.

Fixed in #4690.


Error when running test with pretrained weights

Hi,
I'm trying to run the test with my own dataset which has image resolution as (640, 360). There are two modifications I make. First, I modify the config to include train_configs['data_loader']['resolution_suffix'] = ['_down3']. Then, I change the corresponding paths to read RGB and depth information for the data loader. I read the depth as .png instead of .exr. However, I get the following error message:

The size of tensor a (12) must match the size of tensor b (11) at non-singleton dimension 2
Traceback (most recent call last):
File "TerrasentiaTester01.py", line 112, in
main()
File "TerrasentiaTester01.py", line 104, in main
demo1()
File "TerrasentiaTester01.py", line 100, in demo1
start_testing(train_configs, test_configs)
File "TerrasentiaTester01.py", line 20, in start_testing
output_dirpath = Tester.start_testing(train_configs, test_configs, save_intermediate_results=False)
File "/home/yixiaof2/DeCOMPnet/src/Tester01.py", line 283, in start_testing
pred_frames, masks, extras = tester.predict_next_frame2(video_name, seq_num, pred_frame_num,
File "/home/yixiaof2/DeCOMPnet/src/Tester01.py", line 101, in predict_next_frame2
pred_frames, pred_frames_mask, extras = self.predict_next_frame1(input_dict, return_intermediate_results)
File "/home/yixiaof2/DeCOMPnet/src/Tester01.py", line 84, in predict_next_frame1
output_batch = self.frame_predictor(input_batch, return_intermediate_results)
File "/home/yixiaof2/.conda/envs/decomp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/yixiaof2/DeCOMPnet/src/frame_predictors/FramePredictor01.py", line 76, in forward
flow_outputs = self.estimate_past_local_flow(flow_inputs)
File "/home/yixiaof2/DeCOMPnet/src/frame_predictors/FramePredictor01.py", line 150, in estimate_past_local_flow
feature_extractor_output = self.feature_extractor(feature_extractor_input)
File "/home/yixiaof2/.conda/envs/decomp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/yixiaof2/DeCOMPnet/src/flow_estimation/feature_extractors/PyramidFeatureExtractor01.py", line 55, in forward
x5a, m5a = self.conv5a(x4b, m4b)  # 8x8, 128
File "/home/yixiaof2/.conda/envs/decomp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/yixiaof2/DeCOMPnet/src/flow_estimation/libraries/partial_convolution/partialconv3d.py", line 73, in forward
output = torch.mul(raw_out - bias_view, self.mask_ratio) + bias_view
RuntimeError: The size of tensor a (12) must match the size of tensor b (11) at non-singleton dimension 2
Program ended at 14/11/2023 05:05:29 PM
Execution time: 0:00:06.239132

Do you know what might be the reason for this? Thank you so much for the help.

The flow estimator has six downsampling operations. With your resolution, you can't downsample and upsample six times - you will hit an odd number somewhere. To verify if that is the issue, load patches of size 256x256 or 512x256. If that works, then the issue with the odd resolution. You can either use patches or handle the odd resolution as suggested in the answers for this question

Thank you! But I I believe the image resolution for VeedDynamic is 1920 * 1080 right? It seems that downsample and upsample six times is also not possible?

Right. That's where we first encountered an issue. We solved that issue by padding zeros along the height. Should be somewhere in the code. Observe that our data_loader has padding parameter, which does that.

However, your error looks somewhat different. We got the error in the skip connection. The downsampled and upsampled tensor had a different resolution than the one that didn't go through up/downsampling. Yours is coming in the partial convolution layer. It could be a bug in the partial convolution code as well. I remember we found one such bug in the original partial convolution code and fixed it. This could be another. If you can run it in debug mode and go step-by-step, you should be able to figure it out. In case you find it, either you can let us know or create a pull request. We will glad to incorporate it.

Right. That's where we first encountered an issue. We solved that issue by padding zeros along the height. Should be somewhere in the code. Observe that our data_loader has padding parameter, which does that.

My bad. Upsampling in the flow estimation is done to the specified resolution instead of upsampling by 2. So, odd resolution error shouldn't occur there. It can occur during VideoInpainting. There, we are downsampling only three times. So, both 1080 and 360 should be good. It shouldn't cause an issue during inpainting.

Thanks! So you mean the error I encountered is not the issue of odd resolution?

Not sure. One easy way to figure it out is to crop your input frames to 256x256 and see if it reproduces the error.

I see. Just want to make sure when running the test, is it necessary to add resolution_suffix to train_config for images other than 1920*1080? Since in src/data_loaders/VeedDynamic01.py I see the get_frame_resolution() function but not seeing self.frame_resolution used anywhere.
If it is necessary to specify a resolution suffix, how to deal with resolution that is not divisible by the original one. For instance, if I get the height of the image as 256. According to the code, it is scaled down by 4 from 1080, then the resulting height is rounded to 270, which is an odd number.

Hey, there is no necessity to specify resolution suffix if you don't have downsampled videos. Or you can pass an empty string.


storing sympy expressions for large models uses too much memory

Models that expand to large numbers of species and/or reactions have a very high memory footprint (one model with ~4K species and ~50K reactions used almost 4GB on a 64-bit python). I think the bloat comes from all the SymPy expressions in model.odes and model.reactions, but I haven't completely verified this yet. If this is the case, perhaps we can just store a simplified representation of the reaction network and only generate the full SymPy expressions on demand.

This might be addressed by ac3dcf22a448e207526737864dd0e8d5f956ab9d but will require some formal testing to verify.


Add 4000 compounds we have trees for to MetAtlas database

My notebook, "Generate Pactolus Hit Summary for Groups of Files" identified 4000 trees that are not in the metatlas database according to the inchi-key of the neutralized inchi.
Add them

Done.


Introduce prometheus adapter skeleton.

This PR is the first step towards full prometheus integration. Prometheus, at the moment, is unique for adapters (pull model v. push). This PR represents an initial stab at what setting up a server from within an adapter might look like.
It is expected that in the pending move to go1.8 the server bits will be rewritten to provide for graceful shutdown of the started server.

This change is

Current coverage is 73.54% (diff: 45.45%)

Merging #208 into master will decrease coverage by 0.47%

@@             master       #208   diff @@
==========================================
  Files            39         41     +2
  Lines          1532       1565    +33
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1134       1151    +17
- Misses          369        385    +16
  Partials         29         29

Powered by Codecov. Last update 34169c8...7505976

I've never understood the naming we're using. I would personally just drop
any kind of prefix and just have the Name() method return the coe name of
the adapter proper (ipListChecker, prometheus, etc)
On Mon, Jan 30, 2017 at 10:17 AM, Douglas Reid<EMAIL_ADDRESS>wrote:

@douglas-reid commented on this pull request.
In adapter/prometheus/prometheus.go
https://github.com/istio/mixer/pull/208:

"istio.io/mixer/adapter/prometheus/config"

"istio.io/mixer/pkg/adapter"
+)

+type (

factory struct {

adapter.DefaultBuilder

srv server

}

prom struct{}
+)

+var (

name = "prometheus.io/exporter" // TODO: better name?

I'm not convinced that third-party integrations should be in the istio
namespace. We wouldn't expect istio/gcp or something would we? To me
istio/* are for bits where istio is doing everything (list checking, deny,
writing to stdio).
Thoughts?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/mixer/pull/208, or mute the thread
https://github.com/notifications/unsubscribe-auth/AVucHY7GJh3DKL2xnY2c0gT4KmspMvV4ks5rXik1gaJpZM4LwXwT
.

PTAL. Addressed most of the existing comments. Added a bit around Start() that panic()s if Start() returns an error.

PTAL.
Modified Start() to take an adapter.Logger.  I did not attempt to refactor Register() to provide an Env, but added a sync.Once to the factory.


Develop Router component?

Should be its own thing really, what with having external dependencies and involved use case requirements.
Proof of concept

Done


[Feature]: add option to filter out commits during changelog creation

Describe your feature
Uplift is capable of generating a changelog for every tag that is created on a repository. The diff can contain many different conventional commit messages based on the type of work carried out. Some of these commit messages are prefixed with chore, ci and docs etc. and can prove noisy on a changelog. To allow a user to generate a changelog that is focused on features, bug fixes and breaking changes, for example, certain commit messages should be filtered out
Your potential solution
Add a section to the configuration file that allows a configurable set of filters to control the type of commit messages contained within a changelog diff. The default behaviour should be to include all commit messages.
A possible config could allow the user to configure an includes or an excludes list of commit messages:
changelog:
  includes:
    - feat
    - fix
    - BREAKING CHANGE
    - *!
  excludes:
    - chore(deps)
    - docs
    - ci

Any additional information?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The default behaviour should include all commits within the changelog. This feature should focus on excluding commits only. This will help ensure uplift can be run without any form of configuration file

Allow the same excludes filter to be provided as an argument to the uplift changleog command. Something along the lines --excludes chore(deps),docs,ci


Error:Program type already present: org.apache.http.auth.AuthSchemeProvider

When I add the dependency into my project, i get the error

Error:Program type already present: org.apache.http.auth.AuthSchemeProvider

upon compiling.
Adding SDK using
    compile ('com.coinbase.android:coinbase-android-sdk:1.0.1')
This occurs in the Android SDK Example As well
Does anyone have a fix for this?

    compile ('com.coinbase.android:coinbase-android-sdk:1.0.1'){
        exclude group: 'org.apache.httpcomponents', module:'httpclient'
    }

Found this to be the answer

implementation ('com.coinbase.android:coinbase-android-sdk:1.0.1'){
    exclude group: 'org.apache.httpcomponents', module:'httpclient'
}


Refactor torii grpc queries

The gRPC entities endpoint supports three query clauses - HashedKeysClause, KeysClause, and MemberClause. Previously, the MemberClause could only filter one member of a single model. This PR renames it to ModelsClause and supports filtering multiple model members.
Example:
  "query": {
      "clause": {
          "models": {
              "members": [
                  {
                      "member": "remaining",
                      "model": "Moves",
                      "operator": "GTE",
                      "value": {
                          "int_value": 0
                      }
                  },
                  {
                        "member": "player",
                        "model": "Position",
                        "operator": "EQ",
                        "value": {
                            "byte_value": "BhYoltHXqyBMfMrG3V+Onnwl7NWuT8tK0y5XeGu0bgM="
                        }
                    }
              ],
              "operator": "AND"
          }
      },
      "limit": 5,
      "offset": 0
  }

Will be tracked by #1613 and some work was already done. 👍


Only replace {width} placeholder, without changing element

I'm using imager and also fluidbox, which is a relatively straightforward lightbox. It uses the following html:

Where the  links to the full size image (displayed on click), and the  is just the thumbnail (example). Since the image that the  links to is only displayed on click, it doesn't have any width before that. Which means that imager can't measure the width.
Since these images are full screen it would be awesome if I could just pass the screenwidth to imager, as that is the width that the image'll transform to on click. Is there a way to deal with such a use case?

I've seen the data-width attribute, but in this case I'd need to pass a variable instead of a static value. Would it be performant to update data-width on resize and then trigger imager, or are there better ways?

@ismay I've recently wanted to do something similar. I know it's several years later, but posting here in case it's useful to someone.
My fork doesn't replace the element, and has an option to use the page width rather than container width. You can also pass in selectors for source and destination attributes.

Thanks! Actually, for responsive images I’m currently using a simple script that sets the sizes attr automatically; https://github.com/ismay/ismaywolff.nl/pull/982
Means you don’t have to manually calculate it, and allows you to have more intricate layouts with responsive images. It has some trade offs, but I like it.