Manipulate blocks send to the client?

The idea is to manipulate the chunks/blocks send to the client. So that we can hide or fake certain types of blocks.
I am aware that we can send blocks to the player with the ´Viewer´ object. But if your trying to make something that prevents cheating (xray), It might be better to not send the blocks in the first place.

We should add a kind of ChunkTranformer that would edit the chunk data when the chunk is going to be sent to the client (without loading it ?)

Well it's possible, slightly buggy tho.

Yes but you're using mixin, it would be nice if the API would allow us to edit chunks when packets are generated. I've also seen you got a performance issue because you're loading a lot of unloaded chunks, to avoid loading them, the API should provide us a kind of raw data of the unloaded chunks being sent

Yeah, and so will Sponge 😉. Although the chunk issues are caused by the way I calculate the obfuscated blocks.
I think the neatest thing that should be in the API in some sort of "Player World" (this is about the same what my api in noxray does). So we could do the following for example:
//pseudocode
void onPlayerMove(event){
  player.getNetworkWorld().setBlock(Blocks.Gold, player.getPosition().translate(0,-1,0);
  player.getWorld().getGlobalNetworkWorld().setBlock(Blocks.Diamond, player.getPosition().translate(0,-1,0);
  //update blocks after modification to limit network traffic (bulk update)
  player.getGlobalNetworkWorld().update(p -> !p.getName().equals(player.getName()))
  player.getNetWorkWorld().update()
}

Also with have the following events:

NetworkBlockSendEvent: Sends a block to a certain location
NetworkChunkSendEvent: Sends a chunk to the client/player
NetworkWorldSendEvent: Sends a collection of chunks to player (on join/teleport/fast travel)

These events will basicly be fired upon sending and will also populate the NetworkWorld.
The only problem with this is that this does increase the memory footprint a lot. Since you basically hold a copy of the "viewable" world for each player. It's also important that it's a copy, if you for example wanna spoof the chest content you don't wanna edit the chest in the world. To make sure we don't hurt other servers that wanna use this the api would have to need some sort of Enable function, that plugins can call upon using.

Nice work! It would be nice if a similar API could be added in SpongeAPI. It could be a ClientBlockVolume, a ClientEntityUniverse, and many others client side stuffs, also, it might be related or an alternative to Contexts and Contextual data #1046
However, is the copy of the viewable chunk a copy of the whole chunk or only the modified blocks ? Is it really necessary to keep this copy ?

Maybe it shouldn't be. But upon modifying this "World" it's important that the blocks in the world remain unchanged. Problem with have some sort of link with the core blocks to avoid copying, will modify them if you call the method. Unless sponge has some sort of immutable class that can pass for a block, I don't think this would be a good idea.

Try BlockStates for the block storage, and EntitySnapshots and TileEntitySnapshots for the entities and tile entities.

I'm really interested in this so I could port NonEuclid from Spigot to Sponge. In NonEuclid, depending on a player's location, I want them to see one of two possible hallways (neither of which actually exist in the world). Using sendBlockChange() doesn't cut it because anything that causes the real block or chunk to be resent to the client causes the fake hallway to disappear. NonEuclid currently addresses this in Spigot by using ProtocolLib to modify block change packets and detect chunk packets. (I'm also interested in https://github.com/SpongePowered/SpongeAPI/pull/1046 so I can make it so a player who sees hallway A can't see a player inside it who sees hallway B.)
Is any of this idea affected by changes proposed in https://github.com/SpongePowered/SpongeAPI/pull/1046 or https://github.com/SpongePowered/SpongeAPI/issues/1614?

You might want to look at https://github.com/Yeregorix/Mirage I think it uses the same concept I explained here (since the plugin is based on my old NoXray plugin).
Pinging @Yeregorix.

Since the view will be different for each player I think the best solution is to mixin in PlayerChunkMapEntry to listen for block changes or packet sending and to modify these packets. However it's not very simple, you can also wait for an API but you may wait a very long time.


[EditedContent]

Edited in last line.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-blazor.md
84
27
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0ddc024:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-blazor.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-blazor.md
86
25
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit a659c80:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/messaging-extensions/how-to/enable-SSO-auth-me.md
:warning:Warning
View
Details

msteams-platform/get-started/first-app-blazor.md
:white_check_mark:Succeeded
View

msteams-platform/messaging-extensions/how-to/enable-SSO-auth-me.md

Line 19, Column 20: [Warning-hard-coded-locale] Link 'https://azure.microsoft.com/en-us/free/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit b5db5ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-blazor.md
:white_check_mark:Succeeded
View

msteams-platform/messaging-extensions/how-to/enable-SSO-auth-me.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-blazor.md
86
25
link
:white_check_mark:

msteams-platform/messaging-extensions/how-to/enable-SSO-auth-me.md
87
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Test PR


question

Is it possible to put the play button separate from the audio wave spectrum?
How can the MUTE control on / off and the 0-100% volume bar be switched on?
Can you make the audio persistent when changing pages?
wanting to put the player in a fixed bar at the bottom, and wanting to activate the playing of the audio from an external link to the player (single player at the bottom for all the music) is it possible?
Is it possible to transfer the data of an image, the title and the author next to the player?

Yes, it's possible.
It is not supposed to be but can be added lately.
Think it is not possible when you change page to another domain. The browser will not allow to play it as far as I know.
It is possible to do.
To what player?

OK! since most of the questions are feasible, now I ask: how can you do what I asked =? thanks

Yes, it's possible.
It is not supposed to be but can be added lately.
Think it is not possible when you change page to another domain. The browser will not allow to play it as far as I know.
It is possible to do.
To what player?

Download and inspect the sources. Then you should understand how to implement this thing.


feat: restructure psm1-file to use #requires in functions

In my scripts I'm using #Requires to check for modules and for the Core-version of PowerShell (I only develop for PS7). Building the module is not possible, because all these #Requires are thrown in one psm1-file and multiple of them are not allowed. ;-)
The following code picks up all #Requires, seperate them from the string, puts them at the beginning of the psm1-file and appends the "cleared" string (= all collected functions). This way it works like a charm and I can still continue to use #Requires instead of custom functions to check for modules and versions.
Hope that helps to improve your module. :-)

This is very helpful. Is there better way to handle other than regex find. I am thinking something in AST.
Your code looks great, let me double check once from my end.

Are you sure require statement is causing issue in module, this about page says require can be in any line and doesn't have to be on top.
Moreover, # require statements are more suited for loose scripts which doesn't have psd1 to support. Since we have psd1 file we can load all the things/requirement into manifest file.
Manifest psd1 fields available for achieving same functionality

PowerShellVersion
PowerShellHostVersion
DotNetFrameworkVersion
RequiredModules
RequiredAssemblies

OK, I see what you mean. Maybe it's a problem of the "old world" (as you already wrote: for loose scripts) and the "new world" (everything collected in one module). With that said, I should remove all #Requires from my scripts. If not, after using your build-scripts the new .psm1 throws errors because of multiple #Requires, so it can't be imported.
Thanks for making this clear. 😉

I will add provision to declare these stuff in project.json so you can add them easily.
Please check once that adding it in psd1 manifest serves your purpose without require statement.

In my tests it seems to work.
Beside that I have a similar issue with "using": In some scripts I use the class System.Collections.Generic.List. Unfortunately building the module throws everything in one pot and so the lines with "using" makes the .psm1 useless. Is there also an option in .psd1 to define classes?
Maybe my few rows of code could still help to collect them. Somehow. 😄

I almost always use Collections.List instead of powershell arrray. But I don't see much benefits of using the using namespace. The only advantage is you can instantiate a new list with shortname.
using namespace System.Collections.Generic
$MyList = [List[string]]::new()

Other than that I dont see any advantage, its simpler and more readable if you can do this instead, which consumes only one line. Clearly more verbose and can be used in any part of function/module.
## Alternative, simpler approach
$MyList = [System.Collections.Generic.List[object]]::new()

I am open to suggestions if you think there are other benefits or something I am missing out.

The only advantage is you can instantiate a new list with shortname.

Same here. 😃 I try to replace arrays with lists if possible.
Do you think you can modify your module to collect all "using" found in scripts and put them on top of the module-file? Or do you have any other idea how to use classes like [List[]] after building a module with "ModuleTools"?

Like I mentioned in above comment. You can declare it with full name instead of using using statement.
# this declaration does not need using statement
$MyList = [System.Collections.Generic.List[object]]::new()

Please check and let me know it works for you.
Almost all repository in my GitHub account have used collections.list at least once. And all of them are built using ModuleTools. It works just fine. Kindly check.


-unsafe compiler option required

To use HoloToolkit it is necessary to set the -unsafe compiler option. I'm new to C# so I'm not sure what this means, but I did find the following text on the Unity forums:
"Again, using unsafe doesn't give you much advantages, it just opens up for a huge variety of errors, mistakes and unexpected behaviour. Unless you know exactly what you do and you use pointers sparsely you shouldn't go for an unsafe context. " (http://answers.unity3d.com/questions/804103/how-to-enable-unsafe-and-use-pointers.html)
Is it wise to require unsafe? If this needs to remain then this should be documented in the readme (see link above for documentation)

Seems the above solution doesn't make the errors go away at build time. An example of the error I'm getting is "Assets\HoloToolkit\Assets\HoloToolkit\Sharing\Scripts\SDK\TagImage.cs(51,22): error CS0227: Unsafe code may only appear if compiling with /unsafe"
I've checked the "Allow unsafe code" box in Visual Studio, but that doesn't help.

I was doing it wrong, see the Getting Started guide submitted in #91.


Client-side config is ignored since 8.9.0

Hello @vladimir-bukhtoyarov,
First of all, as this is my first issue here, thank you for such a great library and for all your efforts!
I see that in bucket4j version >= 8.9.0, the new constructor in PostgreSQLadvisoryLockBasedProxyManager is ignoring ClientSideConfig that was previously expected from SQLProxyConfiguration.
Is it an intended change? If yes, then maybe the changes should also be reflected in the documentation examples?
Examples in the documentation: https://bucket4j.com/8.9.0/toc.html#postgresql-integration
Changed part: https://github.com/bucket4j/bucket4j/compare/8.8.0...8.10.0#diff-84bb27f35550de154b5b7a79fe04fed12eba7675fa240fa4e48d9de97e362663R66
Thank you in advance!

Hello @galexeyev
I forgot that cfg can be passed in this way. I will update docomentation.

Thank you!

I will update docomentation.

After rethinking, I have decided to fix original problem. Broken constructors have been fixed. Fix is available in version 8.10.1


Any way to run Package Sync: Sync from the command line?

Hope it's OK, to ask this here.
Is there a way to run the Package Sync: Sync command from the command line?
P.S. I noticed your issue https://github.com/atom/atom/issues/5810 but that was met with a deafening silence :P Was hoping there was an alternative/some way to be able to do this.
P.P.S. Awesome package! Couldn't have created a proper version controlled config of Atom without it. Thanks!

Definitely ok to ask questions here :grinning:
No, there isn't a way currently to run an Atom command from the command line. Adding the ability to execute this from the command line would be prohibitive because of that.
 I'm glad you like the package :bow:

Cool, thanks for the info! I'll +1 your Atom issue, who knows what will happen ;)


Complete (manual) projection of Calendar

Yeah, that's the limitation of mixins, in that they can't be directly instantiated. Conversely, the lack of multiple inheritance means that extends doesn't work for our use case. I was working on the basis that *Statics and *Factory should be classes, but I'm not certain how else to reason about other interfaces.


newline in console

I want to be able to write text to te console.log() of the browser. Is this possible? It is now redirected to the 'notes' div.
Or to be able to use newline and carriage return characters...
Anyone an idea?
Eric

In the Playground, you can use:
parent.console.log("aaa\nbbb");

as a workaround.


fix(Menu): Define color on menu item

Define color on menu item.

Tested by wrapping menu item in an <a>.  Closes #683.

If you wrapped li with an a then it is a bad test because it is an invalid HTML structure. ul/ol can only have li elements as direct children. Can you try using a inside li and tell whether your fix still works.

Anything else left in here before we merge? @adamhock
anchor issue we could address later on, right @mayank99  ?


Wrong actual deps

my block has such deps:
{block: 'i-bem', elem: 'html'},
but bemhint shows actual deps as
actual:   { block: 'i-bem', elems: [ 'html' ] }
so this is a huge difference: https://en.bem.info/tools/bem/bem-tools/depsjs/#include-several-elements

bemhint tries to normalize the actual deps and transforms them to comparable form with expected deps, I mean, that if your deps file is the following:
{block: 'i-bem', elem: 'html'}

and the expected deps are
{ block: 'i-bem', elems: [ 'html' ] }

there will be no diffs.

you can normalize them for comparison
but show actual deps while logging?

Yes, I think that actual deps should be shown AS IS in the log of diffs.


Add support for codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@f71ad1a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #30   +/-   ##
==========================================
  Coverage           ?   80.41%
==========================================
  Files              ?        9
  Lines              ?      286
  Branches           ?        0
==========================================
  Hits               ?      230
  Misses             ?       56
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71ad1a...c563e84. Read the comment docs.


[Fix][UI-Next][V1.0.0-Alpha] Fix error when deployed to nginx after compilation

close #8648

Codecov Report

Merging #8767 (cc60b1f) into dev (a4b34e6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #8767   +/-   ##
=========================================
  Coverage     45.29%   45.29%
  Complexity     4075     4075
=========================================
  Files           702      702
  Lines         27112    27112
  Branches       2897     2897
=========================================
  Hits          12280    12280
  Misses        13678    13678
  Partials       1154     1154

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b34e6...cc60b1f. Read the comment docs.


Added aria-label to search box input field.

Fixes #1379

I'm going to try to build this again. Not sure about what to make of the previous build error since Pull Request Builds are enabled and we have an Open Source plan for this repo.

I reached out to CircleCI support on this one. I think they are expecting contributors to sign in and authorize CircleCI to run checks for PRs here, which is very wrong. I'm guessing the forked repository base doesn't help here, but this was never a problem before they changed their pricing.

Merging this smaller change, it has another approval here: https://github.com/readthedocs/sphinx_rtd_theme/issues/1379#issuecomment-1317224192

Btw thanks for fixing this @dmundra :clap:
Direct contributions and accessibility insights always most welcome :+1:


Display two authors instead of "Author 1 & al."

Actually if a bibliographical reference have 2 authors, the citation display just the first, but it's useful to have both when there is less than 3 authors.
Current:

Expected:

This in-text citation style is more in line with APA 6th edition. APA 7th edition simply states: 1 author + _et al. — e.g. (Epron & al., 2016) — no matter how many authors (2, 3 or 25).
Thanks @HughP for bringing up the differences between APA 6 & 7. We will need to make a decision on this (see #34 for the discussion with publisher location for example).


Batching and Series naming from Select(ables)

@mrocklin ok with this?

Looks pretty good to me

cool thx for the review

Sorry my reviews have been sparse and shallow lately.

no problem! :) there's only so much time in the day


Updated source and header files with .clang-format Qt styles.

@sikanderrafiq
General Note Please, for future PRs don't forget to put a short description message whenever you open PR on GitHub, this will clearify for reviewers what changes did you make (and what are the intentions behind those changes), because sometimes it's not obvious from the code.
For example for this PR one line description would be more than enough:

Reformatted code in src folder to meet Qt C++ Style Guide.

Sure, I will add desc message in the open PR github as well. Do you able to see my comment "Updated source and header files with .clang-format Qt" which i have added when committing my changes to fork repo?

Yes, I do. But that message suggests that you updated all .cpp and .h files in the project, while in fact you only modified files in src folder. This is the reason why I pointed out that additional comment/description can be helpful for reviewers 🙂

Temporarily closed until everything is clarified.


Rethink URL normalization behaviour

Currently fetch-mock coerces any url into a canonical form
e.g /path/../other-path gets coerced to /other-path (in both the url passed in when defining a route and when fetchHandler is called)
This causes some bugs https://github.com/wheresrhys/fetch-mock/issues/669
And I wonder what the best behaviour should be
Some thoughts

When defining a matcher the user should in most cases enter a url without any 'funny business' (such as ../), with a few caveats
a) this should normalise the trailing slash on pathless urls
b) protocol relative urls should match any protocol
So the following are all valid: //a.com/blah, http://a.com/blah, image.jpg, and ../thing. But for the last two no attempt will be made to resolve them to an absolute url
When fetchHandler matches it should first try to match with the url as provided. If that fails, it will normalise the url and try matching again.
For relative urls it should probably error in environments where there is no location available. In fact, maybe fetch-mock should allow an option 'root' or 'hostname' so that a URL object can reliably be generated and used for matching. fetchMock.origin = new URL(window.location)// or some other choice
Perhaps there should be an option (global and at route level) to choose the behaviour... the options being 'normalise', 'don't normalise' and 'both', default being 'no normalisation

Thoughts on behaviour in a table:

Route
Request
Behaviour

//a.com
//a.com
match

//a.com
http://a.com
probably not, because if your application can ship to http pr https, you don't want to hard code any protocols

http://a.com
//a.com
probably not, because if your app is protocol agnostic, so should your tests be

image.jpg
image.jpg
match

http://a.com/page/image.jpg
image.jpg
match, but only if the context makes it clear what window.location is.

image.jpg
http://a.com/page/image.jpg
match, same reason

http://a.com/path/../other-path
http://a.com/path/../other-path
not sure

http://a.com/other-path
http://a.com/path/../other-path
not sure

http://a.com/path/../other-path
http://a.com/other-path
not sure

Readme driven development:
Full url matching
Match an exact url. Can be defined using a string or a URL instance, e.g. "http://www.site.com/page.html". The value * can be used to match any url.
Troubleshooting
To deal with the fetch API's behaviour regarding the transformation urls, fetch-mock implements the following behaviour.

Any urls that do not contain a path will always have a trailing / appended to the end before matching i.e. http:a.com will be changed to http://a.com/
If your application uses prototcol-less urls you must use protocol-less urls when defining your routes i.e. .route('http://a.com') will not match fetch('//a.com'): use .route('//a.com') instead
Requests using hostname relative urls e.g. fetch('/path') will in general behave predictably regardless of whether your tests run in node.js or the browser, even though node.js does not support relative urls. TODO - should these actually error by default. Add an option allowRelativeUrlsInNode. Or just fail an advise that jsdom shoudl be used?
Requests using page-relative urls e.g. fetch('image')will generally fail in node.js unless you use jsdom or similar to mock window.location. TODO - really, how shodul tehy behave with regard to matching based on the fully resolved url??
/..


Build fails on SunOS 5.11

Thanks for your time -- attached npm stack trace. Let me know if you need addl. debug info.
><EMAIL_ADDRESS>install /root/nodebb/node_modules/mmmagic
> node-gyp rebuild

make: Entering directory '/root/nodebb/node_modules/mmmagic/build'
  CC(target) Release/obj.target/libmagic/deps/libmagic/src/apprentice.o
  CC(target) Release/obj.target/libmagic/deps/libmagic/src/apptype.o
  CC(target) Release/obj.target/libmagic/deps/libmagic/src/ascmagic.o
  CC(target) Release/obj.target/libmagic/deps/libmagic/src/cdf.o
../deps/libmagic/src/cdf.c: In function 'cdf_read':
../deps/libmagic/src/cdf.c:303:2: warning: implicit declaration of function 'pread' [-Wimplicit-function-declaration]
  CC(target) Release/obj.target/libmagic/deps/libmagic/src/cdf_time.o
  CC(target) Release/obj.target/libmagic/deps/libmagic/src/compress.o
../deps/libmagic/src/compress.c: In function 'file_zmagic':
../deps/libmagic/src/compress.c:108:2: error: unknown type name 'sig_t'
../deps/libmagic/src/compress.c:113:11: warning: assignment makes integer from pointer without a cast [enabled by default]
../deps/libmagic/src/compress.c:140:2: warning: passing argument 2 of 'signal' makes pointer from integer without a cast [enabled by default]
In file included from /usr/include/signal.h:42:0,
                 from ../deps/libmagic/src/compress.c:48:
/usr/include/iso/signal_iso.h:63:15: note: expected 'void (*)(int)' but argument is of type 'int'
deps/libmagic/libmagic.target.mk:117: recipe for target 'Release/obj.target/libmagic/deps/libmagic/src/compress.o' failed
make: *** [Release/obj.target/libmagic/deps/libmagic/src/compress.o] Error 1
make: Leaving directory '/root/nodebb/node_modules/mmmagic/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/opt/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:810:12)
gyp ERR! System SunOS 5.11
gyp ERR! command "node" "/opt/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /root/nodebb/node_modules/mmmagic
gyp ERR! node -v v0.10.32
gyp ERR! node-gyp -v v1.0.1
gyp ERR! not ok

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the mmmagic package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls mmmagic
npm ERR! There is likely additional logging output above.
npm ERR! System SunOS 5.11
npm ERR! command "/opt/local/bin/node" "/opt/local/bin/npm" "install" "mmmagic"
npm ERR! cwd /root/nodebb
npm ERR! node -v v0.10.32
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! not ok code 0

This is a known issue upstream that has already been resolved. I was hoping they would have another release by now (since 5.22 in January of this year). I generally like to stick to releases, but I may have to just pull in current changes and do another mmmagic release if we don't see 5.23 soon...

Ok someone already asked this on the file mailing list and the developer said a new version should be coming within the next couple of weeks.

Awesome, thanks for the update :)
On Wed, 27 May 2015 23:13 Brian White<EMAIL_ADDRESS>wrote:

Ok someone already asked this on the file mailing list and the developer
said http://mx.gw.com/pipermail/file/2015/001738.html a new version
should be coming within the next couple of weeks.
—
Reply to this email directly or view it on GitHub
https://github.com/mscdex/mmmagic/issues/52#issuecomment-106157687.

I am getting same error on Ubuntu system. My Node version is 0.12.04. Please help.

Ok, 5.23 is in master. Please give it a try and let me know if it solves things for you.


Unable to access to _SCRIPTABLE and _EXPORTABLE from torch.hub

Hi @rwightman!
Thank you for your great implementation for efficientnet and its relatives.
I found the global param is _SCRIPTABLE and _EXPORTABLE in the config file. However, when I use torch hub to access the model, it is hard for me to acces these two variables and successful export the model. In this case I'm wondering is that possible to set _SCRIPTABLE and _EXPORTABLE as a parameter of EfficientNetBuilder?
Best,

Hmm, I'll think about how to do that cleanly, definitely an issue with the reduced interface you get via hub. Passing them all the way through the builder to the point where the layers are instantiated adds a lot of mess.

Besides, after I converted to the tensorrt, the inference time and memory cost is pretty high. Just kind of curious about that. Is it caused by the swishes? Is there the only way to improve it is to wait the tensorrt to improve their backend?
To renference, the speed I tested for the ssd-mobilenet v1 and v2 with batch 16 is 23.12ms & 34.58ms. The speed for ssd-efficientnetb0 with batch 8 is 26.45ms.

Yes, the Swish activation, and having an SE every block is fairly high cost for mobile/CPU inference. Not sure if Tensorrt has an optimal Swish impl yet? If it did, would likely require some annotation as there isn't one in native PyTorch.
If you check out my BENCHMARK.md, I ran a few forward passes on different ONNX exported networks here,  you can see how much % the sigmoids in the swish and se use compared to say a MobileNetV3 that uses hard-swish / hard-sigmoid and doesn't have SE every block.
I've converted the EfficientNet-Lite models, once I've verified them I'll add... they use ReLU6 and no SE so will have lower latency.

I don't really have a great solution for this, I don't want to duplicate code and push this through down to individual model creation helpers and entrypt fns, I have added support in create_model factory but not a good way of calling that via the hub interface. Not sure if I have any other brilliant ideas....


Screeps code doesn't run - CompileError: WebAssembly.Module() [...] Invalid Opcode (enable with --experimental-wasm-se) @+70767

To be honest, Web Assembly honestly seems like black magic to me and I hoped I wouldn't have to mess with it and just code in Rust, but as it stands, I couldn't even get the example code from https://github.com/rustyscreeps/screeps-starter-rust to work. The error messages vary between ticks for some reason, but the stack trace always ends at the code
const wasmModule = new WebAssembly.Module(bytes);
I googled a bit and it seems like the problem is that WebAssembly can't parse the binary data. As per the error message, I tried to add --experimental-wasm-se to the extra_options = [] in [build] in screeps.toml, but when doing that, the code isn't even compiled when running the command cargo screeps deploy.
For the reference, here is the entire error message from screeps:

caught exception: CompileError: WebAssembly.Module(): Compiling wasm function #55:core::num::flt2dec::strategy::grisu::format_exa... failed: Invalid opcode (enable with --experimental-wasm-se) @+43788
at screeps-starter-rust:410:20
at screeps-starter-rust:416:3
at Object.exports.evalCode (:15851:76)
at Object.requireFn (:46524:28)
at Object.module.exports.loop (main:28:27)
at __mainLoop:1:52
at __mainLoop:2:3
at Object.exports.evalCode (:15851:76)
at Object.exports.run (:46474:24)

I haven't changed anything in the code itself or the configuration, apart from changing the name of the destination directory from default to rust-screeps to compare the differences between my new and old code.

I'm not a developer of cargo-screeps, but encountered the same issue.
See https://github.com/rustyscreeps/screeps-game-api/issues/391 for a workaround.


Add a custom filter to make it convenient to point to a file

See custom liquid filter here:
https://deanebarker.net/tech/fluid/custom-filters/
As of v0.9.2 the template author has to remember to link to attached files like so:
/raytha/media-items/objectkey/{{ Target.PublishedContent.attachment.Value }}
I think this is unfair to expect the template author to remember the prefix of file route. Instead, we can easily do a custom liquid filter that renders it, but it would look like:
{{ Target.PublishedContent.attachment.Value | attachment_url }}

The liquid filter is raytha_attachment_url, usage example below.
{{ Target.PublishedContent.attachment.Value | raytha_attachment_url }}


[BACKLOG-9667] - ETL Metadata Injection step fails when we check the option 'Don't execute resulting transformation' for Synchronize after merge step

@bmorrise , @mdamour1976  please review.

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/synchronizeaftermerge/SynchronizeAfterMergeMeta.java
  engine/test-src/org/pentaho/di/trans/steps/synchronizeaftermerge/SynchronizeAfterMergeMetaInjectionTest.java

Newly Fixed Tests:
org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.testSerialization:
:red_circle: java.lang.RuntimeException
java.lang.RuntimeException: Error validating dateFormatLocale
	at org.pentaho.di.trans.steps.loadsave.LoadSaveTester.validateLoadedMeta(LoadSaveTester.java:176)
	at org.pentaho.di.trans.steps.loadsave.LoadSaveTester.testXmlRoundTrip(LoadSaveTester.java:223)
	at org.pentaho.di.trans.steps.loadsave.LoadSaveTester.testSerialization(LoadSaveTester.java:182)
	at org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.testSerialization(TextFileInputMetaLoadSaveTest.java:159)
Caused by:

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change:  + 7.14%
Complexity Change:  + 7.69%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change:  + .39%
Complexity Change:  + .51%
Instruction Change:  + .08%

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change:  + 1.00%
Complexity Change:  + 1.41%
Instruction Change:  + .30%

org.pentaho.di.trans.step.StepMeta

Instruction Change:  + .19%
Line Change:  + .27%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change:  + .66%
Complexity Change:  + .41%
Instruction Change:  + .50%
Line Change:  + .24%

org.pentaho.di.trans.steps.getfilesrowscount.GetFilesRowsCountMeta

Branch Change:  + 1.85%
Complexity Change:  + 1.30%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 1.04%
Complexity Change:  + 1.05%
Instruction Change:  + .14%
Line Change:  + .37%

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%
Instruction Change:  + .18%
Line Change:  + .48%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change:  + 3.33%
Complexity Change:  + 1.85%
Instruction Change:  + .28%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Branch Change:  + 5.29%
Complexity Change:  + 4.14%
Instruction Change:  + 5.32%
Line Change:  + 7.63%
Method Change:  + 6.67%

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change: -2.04%:small_red_triangle_down:
Complexity Change: -2.04%:small_red_triangle_down:
Instruction Change: -.32%:small_red_triangle_down:
Line Change: -.81%:small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -.91%:small_red_triangle_down:
Complexity Change: -.82%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileFilter

Complexity Change:  + 9.09%
Instruction Change:  + 9.26%
Line Change:  + 8.33%
Method Change:  + 9.09%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + 12.23%
Complexity Change:  + 5.20%
Instruction Change:  + 30.22%
Line Change:  + 22.74%
Method Change:  + 3.21%

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.step.BaseStep

Branch Change:  + .29%
Complexity Change:  + .18%
Instruction Change:  + .05%
Line Change:  + .08%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.01%:small_red_triangle_down:
Line Change: -.03%:small_red_triangle_down:


Update AMP compatibility logic

The AMP plugin continues to improve its support for Bento, see e.g. https://github.com/ampproject/amp-wp/pull/6722
I want to make sure this example repo works fine with that.
Not sure what's needed there yet.

cc @westonruter

The intention is that if you're using bento-prefixed components that it should automatically get converted. Your AMP_Carousel_Sanitizer is searching for bento-base-carousel components and that is fine because the conversion to amp-base-carousel would happen after that 3rd-party sanitizer.
Otherwise, you're currently omitting the custom Bento scripts when is_amp so the AMP plugin won't trip over them. But in the case where you're not self-hosting, the aforementioned PR would automatically identify the scripts and stylesheets for Bento components and automatically remove them since the plugin's auto-extension importing would add the AMP versions.
As I refine my PR I'll check to make sure it's working as expected with your plugin.

I think the script registration part would also need updating:
https://github.com/swissspidy/gutenberg-bento/blob/9b56b8237b4736f4998ad40a9e4d98c70223bc97/inc/namespace.php#L65-L69
https://github.com/swissspidy/gutenberg-bento/blob/9b56b8237b4736f4998ad40a9e4d98c70223bc97/inc/namespace.php#L74-L79
I wouldn't expect the AMP plugin to register any Bento assets.

Right, but what the new Bento sanitizer does in my PR is it removes those Bento-specific scripts and stylesheets.
Nevertheless, the scripts at least won't be enqueued anyway on AMP because of the is_amp() check here:
https://github.com/swissspidy/gutenberg-bento/blob/9b56b8237b4736f4998ad40a9e4d98c70223bc97/inc/namespace.php#L205-L207

I just tested with https://github.com/ampproject/amp-wp/pull/6722 and it seems to work just fine. On AMP pages, the bento-base-carousel is converted to amp-base-carousel and there are no validation errors raised.

With the latest changes in that PR, if you add style="aspect-ratio: 4/1;" to the bento-base-accordion you can eliminate these lines:
https://github.com/swissspidy/gutenberg-bento/blob/42e34904a3b9d639770e9ceb2193ec0fa2153fb6/inc/class-amp-carousel-sanitizer.php#L50-L54
The AMP_Bento_Sanitizer will look at inline styles on Bento elements and convert them into the required AMP layout attributes, where possible.

Are you suggesting adding that inline style in this sanitizer, or just generally? Right now the aspect ratio is set in the CSS file already

Actually rather that the inline style attribute could be output in the save function.

Makes sense. Just feels a tiny bit redundant as there's already an aspect ratio declaration here:
https://github.com/swissspidy/gutenberg-bento/blob/42e34904a3b9d639770e9ceb2193ec0fa2153fb6/src/carousel/view.css#L1-L6

Right. It doesn't have to be inlined. But it's an alternative that would reduce sanitizer logic. Definitely not required. But then again, somewhat better to not have the ratio defined in two places. What if you wanted to add an aspect ratio setting to the block too?

Thet is a good point 👍


Refactor relational metadata extensions

Changes

Add IRelationalMetadataExtensionsAccessor

Use it in the update pipeline

Don't derive SqlServerMetadataExtensions from RelationalMetadataExtensions

I considered calling the ISharedRelationalExtensions interfaces Virtual or Overridable. They basically designates which Relational metadata a provider should override. It separates them from the ones that they should not override like DescriminatorColumn and DefaultValue.

@bricelam Can you explain a bit about why you are making these changes so I can review from that perspective?

@ajcvickers Added a bit more info. Let me know if I need to add more.


Add files via upload

Grozny State Oil Technical University named after Academician M. D. Millionshchikov

@Superior5 Pull request merged. Thank you!


[SPARK-33844][SQL] InsertIntoHiveDir command should check col name too

What changes were proposed in this pull request?
In hive-1.2.1, hive serde just split serdeConstants.LIST_COLUMNS and serdeConstants.LIST_COLUMN_TYPES use comma.
When we use spark 2.4 with UT
  test("insert overwrite directory with comma col name") {
    withTempDir { dir =>
      val path = dir.toURI.getPath

      val v1 =
        s"""
           | INSERT OVERWRITE DIRECTORY '${path}'
           | STORED AS TEXTFILE
           | SELECT 1 as a, 'c' as b, if(1 = 1, "true", "false")
         """.stripMargin

      sql(v1).explain(true)

      sql(v1).show()
    }
  }

failed with as below since column name contains , then column names and column types size not equal.
19:56:05.618 ERROR org.apache.spark.sql.execution.datasources.FileFormatWriter:  [ angerszhu ] Aborting job dd774f18-93fa-431f-9468-3534c7d8acda.
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 1 times, most recent failure: Lost task 0.0 in stage 0.0 (TID 0, localhost, executor driver): org.apache.hadoop.hive.serde2.SerDeException: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe: columns has 5 elements while columns.types has 3 elements!
	at org.apache.hadoop.hive.serde2.lazy.LazySerDeParameters.extractColumnInfo(LazySerDeParameters.java:145)
	at org.apache.hadoop.hive.serde2.lazy.LazySerDeParameters.<init>(LazySerDeParameters.java:85)
	at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.initialize(LazySimpleSerDe.java:125)
	at org.apache.spark.sql.hive.execution.HiveOutputWriter.<init>(HiveFileFormat.scala:119)
	at org.apache.spark.sql.hive.execution.HiveFileFormat$$anon$1.newInstance(HiveFileFormat.scala:103)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.newOutputWriter(FileFormatDataWriter.scala:120)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.<init>(FileFormatDataWriter.scala:108)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.org$apache$spark$sql$execution$datasources$FileFormatWriter$$executeTask(FileFormatWriter.scala:287)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$write$1.apply(FileFormatWriter.scala:219)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$write$1.apply(FileFormatWriter.scala:218)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:121)
	at org.apache.spark.executor.Executor$TaskRunner$$anonfun$12.apply(Executor.scala:461)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1360)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:467)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

After hive-2.3 we will set COLUMN_NAME_DELIMITER to special char when col name cntains ','：
https://github.com/apache/hive/blob/6f4c35c9e904d226451c465effdc5bfd31d395a0/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java#L1180-L1188
https://github.com/apache/hive/blob/6f4c35c9e904d226451c465effdc5bfd31d395a0/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java#L1044-L1075
And in script transform, we parse column name  to avoid this problem
https://github.com/apache/spark/blob/554600c2af0dbc8979955807658fafef5dc66c08/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationExec.scala#L257-L261
So I think in InsertIntoHiveDirComman, we should do same thing too. And I have verified this method can make spark-2.4 work well.
Why are the changes needed?
More save use serde
Does this PR introduce any user-facing change?
No
How was this patch tested?

Test build #133048 has started for PR 30850 at commit 5967949.

gentle ping @wangyum

Test build #133050 has started for PR 30850 at commit 9703d6f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37650/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37648/

Test build #133048 has finished for PR 30850 at commit 5967949.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133048/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37650/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37648/

Test build #133050 has finished for PR 30850 at commit 9703d6f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37648/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37650/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133050/

Recheck spark-2.4, orc/parquet have similar problem too
Caused by: java.lang.IndexOutOfBoundsException: Index: 3, Size: 3
	at java.util.ArrayList.rangeCheck(ArrayList.java:657)
	at java.util.ArrayList.get(ArrayList.java:433)
	at org.apache.hadoop.hive.ql.io.orc.OrcStruct$OrcStructInspector.<init>(OrcStruct.java:195)
	at org.apache.hadoop.hive.ql.io.orc.OrcStruct.createObjectInspector(OrcStruct.java:549)
	at org.apache.hadoop.hive.ql.io.orc.OrcSerde.initialize(OrcSerde.java:109)
	at org.apache.spark.sql.hive.execution.HiveOutputWriter.<init>(HiveFileFormat.scala:119)
	at org.apache.spark.sql.hive.execution.HiveFileFormat$$anon$1.newInstance(HiveFileFormat.scala:103)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.newOutputWriter(FileFormatDataWriter.scala:120)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.<init>(FileFormatDataWriter.scala:108)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.org$apache$spark$sql$execution$datasources$FileFormatWriter$$executeTask(FileFormatWriter.scala:287)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$write$1.apply(FileFormatWriter.scala:219)

Caused by: java.lang.IllegalArgumentException: ParquetHiveSerde initialization failed. Number of column name and column type differs. columnNames = [a, b, (IF((1 = 1),  true,  false))], columnTypes = [int, string, string]
	at org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe.initialize(ParquetHiveSerDe.java:115)
	at org.apache.spark.sql.hive.execution.HiveOutputWriter.<init>(HiveFileFormat.scala:119)
	at org.apache.spark.sql.hive.execution.HiveFileFormat$$anon$1.newInstance(HiveFileFormat.scala:103)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.newOutputWriter(FileFormatDataWriter.scala:120)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.<init>(FileFormatDataWriter.scala:108)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.org$apache$spark$sql$execution$datasources$FileFormatWriter$$executeTask(FileFormatWriter.scala:287)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$write$1.apply(FileFormatWriter.scala:219)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$write$1.apply(FileFormatWriter.scala:218)

Change Ut  SPARK-25313 Insert overwrite directory should output correct schema
test("SPARK-25313 Insert overwrite directory should output correct schema") {
    withSQLConf(CONVERT_METASTORE_PARQUET.key -> "false") {
      withTable("tbl") {
        withView("view1") {
          spark.sql("CREATE TABLE tbl(id long)")
          spark.sql("INSERT OVERWRITE TABLE tbl VALUES 4")
          spark.sql("CREATE VIEW view1 AS SELECT id FROM tbl")
          spark.sql("SELECT ID, IF(1=1,1,0) FROM view1").show()
          withTempPath { path =>
            spark.sql(s"INSERT OVERWRITE LOCAL DIRECTORY '${path.getCanonicalPath}' " +
              "STORED AS PARQUET SELECT IF(1=1,1,0)")
            val expectedSchema = StructType(Seq(StructField("ID", LongType, true)))
            assert(spark.read.parquet(path.toString).schema == expectedSchema)
            checkAnswer(spark.read.parquet(path.toString), Seq(Row(4)))
          }
        }
      }
    }
  }

Failed with
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.IllegalArgumentException: field ended by ';': expected ';' but got 'IF' at line 1:   optional int32 (IF
	at org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getHiveRecordWriter(HiveFileFormatUtils.java:274)
	at org.apache.spark.sql.hive.execution.HiveOutputWriter.<init>(HiveFileFormat.scala:131)
	at org.apache.spark.sql.hive.execution.HiveFileFormat$$anon$1.newInstance(HiveFileFormat.scala:104)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.newOutputWriter(FileFormatDataWriter.scala:126)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.<init>(FileFormatDataWriter.scala:111)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:269)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$write$15(FileFormatWriter.scala:210)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:131)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:497)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1439)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:500)
	... 3 more
Caused by: java.lang.IllegalArgumentException: field ended by ';': expected ';' but got 'IF' at line 1:   optional int32 (IF
	at org.apache.parquet.schema.MessageTypeParser.check(MessageTypeParser.java:214)
	at org.apache.parquet.schema.MessageTypeParser.addPrimitiveType(MessageTypeParser.java:187)
	at org.apache.parquet.schema.MessageTypeParser.addType(MessageTypeParser.java:111)
	at org.apache.parquet.schema.MessageTypeParser.addGroupTypeFields(MessageTypeParser.java:99)
	at org.apache.parquet.schema.MessageTypeParser.parse(MessageTypeParser.java:92)
	at org.apache.parquet.schema.MessageTypeParser.parseMessageType(MessageTypeParser.java:82)
	at org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport.getSchema(DataWritableWriteSupport.java:43)
	at org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport.init(DataWritableWriteSupport.java:48)
	at org.apache.parquet.hadoop.ParquetOutputFormat.getRecordWriter(ParquetOutputFormat.java:388)
	at org.apache.parquet.hadoop.ParquetOutputFormat.getRecordWriter(ParquetOutputFormat.java:354)
	at org.apache.hadoop.hive.ql.io.parquet.write.ParquetRecordWriterWrapper.<init>(ParquetRecordWriterWrapper.java:70)
	at org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat.getParquerRecordWriterWrapper(MapredParquetOutputFormat.java:137)
	at org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat.getHiveRecordWriter(MapredParquetOutputFormat.java:126)
	at org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getRecordWriter(HiveFileFormatUtils.java:286)

Avro serde failed with
Caused by: org.apache.avro.SchemaParseException: Illegal initial character: (IF((1 = 1), 1, 0))
	at org.apache.avro.Schema.validateName(Schema.java:1147)
	at org.apache.avro.Schema.access$200(Schema.java:81)
	at org.apache.avro.Schema$Field.<init>(Schema.java:403)
	at org.apache.avro.Schema$Field.<init>(Schema.java:396)
	at org.apache.hadoop.hive.serde2.avro.TypeInfoToSchema.createAvroField(TypeInfoToSchema.java:76)
	at org.apache.hadoop.hive.serde2.avro.TypeInfoToSchema.convert(TypeInfoToSchema.java:61)
	at org.apache.hadoop.hive.serde2.avro.AvroSerDe.getSchemaFromCols(AvroSerDe.java:170)
	at org.apache.hadoop.hive.serde2.avro.AvroSerDe.initialize(AvroSerDe.java:114)
	at org.apache.spark.sql.hive.execution.HiveOutputWriter.<init>(HiveFileFormat.scala:121)
	at org.apache.spark.sql.hive.execution.HiveFileFormat$$anon$1.newInstance(HiveFileFormat.scala:104)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.newOutputWriter(FileFormatDataWriter.scala:126)

orc/rcfile/sequencefile is ok to write data.

also ping @maropu @cloud-fan

parquet and avro failed because the col IF(1=1, 1, 0) 's  col name is (IF((1 = 1), 1, 0)), break the schema parse process.
One solution may be suitable for all problem:
IF col name contains ,  or start with `(`, we replace it as `atribute_${index}`

Test build #133055 has started for PR 30850 at commit 7764395.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37655/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37655/

Test build #133055 has finished for PR 30850 at commit 7764395.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133055/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37655/

retest this please

Test build #133063 has started for PR 30850 at commit 7764395.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37663/

Test build #133063 has finished for PR 30850 at commit 7764395.

This patch fails from timeout after a configured wait of 500m.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133063/

hm, we need to add workaround code in master for the hive legacy behaviour? I hesitate to do so in terms of code maintenance.

hm, we need to add workaround code in master for the hive legacy behaviour? I hesitate to do so in terms of code maintenance.

But some case  also cause Parquet/avro. failed to write data. column. name with , always contains (, and ( make schema parse failed.

Which case you pointed out? This one?
scala> sql("select rand()").write.save("/tmp/test")
org.apache.spark.sql.AnalysisException: Attribute name "rand()" contains invalid character(s) among " ,;{}()\n\t=". Please use alias to rename it.
  at org.apache.spark.sql.execution.datasources.parquet.ParquetSchemaConverter$.checkConversionRequirement(ParquetSchemaConverter.scala:579)
  at org.apache.spark.sql.execution.datasources.parquet.ParquetSchemaConverter$.checkFieldName(ParquetSchemaConverter.scala:570)

Which case you pointed out? This one?
scala> sql("select rand()").write.save("/tmp/test")
org.apache.spark.sql.AnalysisException: Attribute name "rand()" contains invalid character(s) among " ,;{}()\n\t=". Please use alias to rename it.
  at org.apache.spark.sql.execution.datasources.parquet.ParquetSchemaConverter$.checkConversionRequirement(ParquetSchemaConverter.scala:579)
  at org.apache.spark.sql.execution.datasources.parquet.ParquetSchemaConverter$.checkFieldName(ParquetSchemaConverter.scala:570)

Yea, but InsertIntoHiveDir with parquet format don't have this check. If we don't concern make it work with hive < 2.3.
Maybe we should add similar check in InsertIntoHiveDirCommand?

Yea, but InsertIntoHiveDir with parquet format don't have this check. If we don't concern make it work with hive < 2.3.
Maybe we should add similar check in InsertIntoHiveDirCommand?

What's the behaviour of the current master when using parquet? It will throw a runtime exception?

Yea, but InsertIntoHiveDir with parquet format don't have this check. If we don't concern make it work with hive < 2.3.
Maybe we should add similar check in InsertIntoHiveDirCommand?

What's the behaviour of the current master when using parquet in the case? It will throw a runtime exception?

As this pr show, will throw runtime exception when write data. It will failed after query block executed. So I think we should check schema first

Maybe we should add similar check in InsertIntoHiveDirCommand?

+1

Maybe we should add similar check in InsertIntoHiveDirCommand?

+1

Can you review this part too https://github.com/apache/spark/pull/30869, it's one part about this pr.

gentle ping @cloud-fan @maropu also @dongjoon-hyun
Change code as  https://github.com/apache/spark/pull/30850#issuecomment-748601417 and add UT for this

Test build #133564 has started for PR 30850 at commit 0fa1a5b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38154/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38154/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38154/

Test build #133564 has finished for PR 30850 at commit 0fa1a5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133564/

thanks, merging to master!

thanks, merging to master!

@AngersZhuuuu can you open backport PRs for 3.1/3.0? thanks!

@AngersZhuuuu can you open backport PRs for 3.1/3.0? thanks!

@AngersZhuuuu can you open backport PRs for 3.1/3.0? thanks!

Sure, will raise pr and ping you  later.

@AngersZhuuuu can you open backport PRs for 3.1/3.0? thanks!

Sure, will raise pr and ping you  later.


parallels issue

Getting an error which says:
Try to find the installation package in a folder from which you can install.
Any suggestions. The package is there on the desktop. Moved it around to other places on the C: drive. No luck
Thanks

Sorry, parallels support is not guaranteed, so I can't provide any help.


Cow: Watch monsoonesdlabtable.com

Cow requests the watch of the watch_keyword monsoonesdlabtable\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

monsoonesdlabtable\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Fix back key handling for all backends

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

@rahul27 Please try it with all backends that we have and let me know what you think. Thank you.

Any opinions? I might have to merge this today to get it into the maven repo.

Will merge Friday after lunch if there are no objections.


where is the "self.image_info" initialized in dataset.py?

In your code, self.image_info plays an important role in many functions when loading the dataset. However, I haven't found any function or code snippet that initializes image_info. This has caused the inference or training program to fail to run successfully. How can this issue be resolved?

Check this method
https://github.com/sahithchada/NOCS_PyTorch/blob/f4ed85efec3b39476bda74ef84a314fcbcf8f0b3/utils.py#L169
self.image_info is updated for every image that is added to the dataset.

To expand on Sahith's answer, the NOCSData class inherits the utils.Dataset class. Here, we call the load_camera_scenes function of the NOCSData class:
https://github.com/sahithchada/NOCS_PyTorch/blob/f4ed85efec3b39476bda74ef84a314fcbcf8f0b3/train.py#L254
Looking closer at that function, we is it calls:
https://github.com/sahithchada/NOCS_PyTorch/blob/f4ed85efec3b39476bda74ef84a314fcbcf8f0b3/dataset.py#L308
which is a function of the utils.Dataset class. And we see that is where the image_info is appended
https://github.com/sahithchada/NOCS_PyTorch/blob/f4ed85efec3b39476bda74ef84a314fcbcf8f0b3/utils.py#L175
Hope this helps!


Update: Variables + Config handling

fix variables duplicating frame write
Alter variables workflows by adding UI panel and making entries async to config block
Add explainer under Variables panel
Add notification systems for missing variables
Edit figma2html settings block, grouping together (migration is built in)
Update reset/load/save functionality
refactor/write utils: isFigma2htmlFrame, textNodeVariable and extractTextFromHTML

@sawyerclick should we get this in next week

that would be great! can revisit next week


Method of exported class has to return instance of another class. Possible?

So I've got Class A and B in C++. They are both exported in the PHPCPP_EXPORT void *get_module() function so they are available for PHP.
And of course this works, I can instantiate these classes in PHP.
But what if Class A->someMethod() must return an instance of class B? Is that possible? I think it's not, because Php::Value supports only primitives and arrays of primitives.  Is this correct?
Like, is this possible:
<?php
$foo = new Presentation() // this class was exported from C++.
$foo->getSlide(0) // supposed to return an instance of class Slide (also exported).
?>

Thanks in advance!

Found it in the docs... yes possible..


The page fails to state where the configuration file is.

The implication is that is an ini file somewhere, but so far I have not located the file
By disabling the code analysis rule that's causing the warning, you disable the rule for your entire file or project (depending on the scope of the configuration file that you use). To disable the rule, set its severity to none in the configuration file.
ini
Copy
[*.{cs,vb}]
dotnet_diagnostic..severity = none
For more information about rule severities, see Configure rule severity.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 30ffb9d6-b391-47fe-0e2b-e36dfe0b498d
Version Independent ID: 9c462195-9e39-1393-0cf8-07ba50f8434b
Content: Suppress code analysis warnings - .NET
Content Source: docs/fundamentals/code-analysis/suppress-warnings.md
Product: dotnet-fundamentals
GitHub Login: @gewarren
Microsoft Alias: gewarren

Usually the file is an EditorConfig file. You can either add an empty file named ".editorconfig" to your project, or use the template in Visual Studio.


Have factions (teams) battling eachother

Depends on:

[x] #25 rendering units
[x] #37 revealing shroud

Acceptance criteria:

[ ] A team has a base color
[ ] The base color is visible on units/structures
[ ] A team has their own unshrouded map data (see #37)
[ ] Renders units with team color (depends on #25)
[ ] Renders structures with team color

Note: players are not 'humans' but more like 'sides' (teams).

#25 is solved, after #37 this issue is ready to build

#37 is now also solved, this issue is now ready to build


Fixed bug: option key "max_overflow" is an :atom, not a string

The poolboy option "max_overflow" was ignored silently because
max_overflow is fetched by the key :max_overflow, not "max_overflow".
The bug itself does not output any error, but the error can be reproduced when setting option as
"pool_size: 0, max_overflow: 10"
https://github.com/ericmj/mongodb/blob/master/lib/mongo/pool/poolboy.ex#L19

  @poolboy_opts ~w(max_overflow)
  # (omit)

  def start_link(name, opts) do
    {size, opts} = Keyword.pop(opts, :pool_size, 10)
    {pool_opts, worker_opts} = Keyword.split(opts, @poolboy_opts)
  # (omit)
  end

Thank you!

👍


Provider switching not supporting custom mappings

If I have a custom mapping:
importmap.json
{
  "imports": {
    "app": "./src/app.js",
    "lit"<EMAIL_ADDRESS>  },
  "scopes": {
    "https://ga.jspm.io/": {
      "@lit/reactive-element": "https://ga.jspm.io/npm<EMAIL_ADDRESS>      "lit-element/lit-element.js"<EMAIL_ADDRESS>      "lit-html"<EMAIL_ADDRESS>      "lit-html/is-server.js"<EMAIL_ADDRESS>    }
  }
}

and I install to a new provider:
jspm install --provider nodemodules

I get this error:
Error: Unable to resolve package npm:app in range "*" from parent file:///C:/Users/Guy/Projects/test/

We should be able to detect the custom mapping from the decomposition process and know not to try to switch providers on an entry that doesn't come from a provider.

In addition, the nodemodules should probably have a slightly better error for these resolution errors.
Rather than just saying cant resolve, we should say:
node_modules/app does not exist, try installing it with npm first with "npm install app"

Ah, I think what's actually going on here is that since you didn't specify a package to install, it's reinstalling all top-level imports (including "app"), and "app" is being interpreted as the package "npm:app" by the generator.


v1.17 Backports 2024-12-20

[ ] #36626 (@julianwiedmann) :warning: resolved conflicts
[ ] #36640 (@julianwiedmann) :warning: resolved conflicts
[ ] #36679 (@JacobHenner)
[ ] #36701 (@alagoutte)
[ ] #36734 (@sayboras)

Once this PR is merged, a GitHub action will update the labels of these PRs:
 36626 36640 36679 36701 36734

/test

[ ]  gh: e2e-upgrade: add coverage for 6.6 kernel #36626 (@julianwiedmann) ⚠ resolved conflicts

[ ]  gh: e2e-upgrade: add coverage for 6.12 kernel #36640 (@julianwiedmann) ⚠ resolved conflicts

I see these two in the v1.17 branch, so looks like they made the branch cut-off. Could you please drop them? Sorry for the trouble.

/test


wiki code review request

I added some code to the wiki that adds a preview to some of the git commands:

fco_preview
fcoc_preview
fshow_preview

These work nicely for me, and might warrant replacing the non-preview versions in the wiki, but since I'm not very well versed in shell scripting, I'd like to request a code-review for them.

Thanks. I just tried one of your functions and I realized you didn't set --ansi option for fzf so the ANSI escape sequences are shown in the list. Do you have it in your FZF_DEFAULT_OPTS? I don't recommend doing so, since it adds some overhead to fzf parser and makes it slower even when you don't have ANSI colors in the input.

Thank you!
Yes, I have --ansi in my FZF_DEFAULT_OPTS.
I'll change that in the wiki.

Hey @magnetophon thanks for the great scripts. I've been trying to use them but couldn't get them to run. I am currently trying to use fshow_preview which seems insanely useful, but had the following problems:

Initially I got a -bash: local: can only be used in a function message, which was caused by

local _gitLogLineToHash="echo {} | grep -o '[a-f0-9]\{7\}' | head -1"
local _viewGitLogLine="$_gitLogLineToHash | xargs -I % sh -c 'git show --color=always % | diff-so-fancy'"

I moved them into fshow_preview and that error dissapeared.

After that I got the error unknown option: {} which I think is caused by

local _gitLogLineToHash="echo {} | grep -o '[a-f0-9]\{7\}' | head -1"

but I dont really know how to solve it.
Do you have any idea of what I could be doing wrong? Thanks!

@joaqo I'm sorry to say I can't help you there; these are all googled together...
This is what I'm using atm, if that helps.

I ended up solving it, pasting the code here if anybody else is interested:
alias glNoGraph='git log --color=always --format="%C(auto)%h%d %s %C(black)%C(bold)%cr% C(auto)%an" "$@"'
_gitLogLineToHash="echo {} | grep -o '[a-f0-9]\{7\}' | head -1"
_viewGitLogLine="$_gitLogLineToHash | xargs -I % sh -c 'git show --color=always %'"
# _viewGitLogLine="$_gitLogLineToHash | xargs -I % sh -c 'git show --color=always % | diff-so-fancy'"

# fcheckout - checkout git commit with previews
fcoc_preview() {
  local commit
  commit=$( glNoGraph |
    fzf --no-sort --reverse --tiebreak=index --no-multi \
        --ansi --preview="$_viewGitLogLine" ) &&
  git checkout $(echo "$commit" | sed "s/ .*//")
}

# fshow - git commit browser with previews
fshow() {
    glNoGraph |
        fzf --no-sort --reverse --tiebreak=index --no-multi \
            --ansi --preview="$_viewGitLogLine" \
                --header "enter to view, alt-y to copy hash" \
                --bind "enter:execute:$_viewGitLogLine   | less -R" \
                --bind "alt-y:execute:$_gitLogLineToHash | xclip"
}
###################################### O ###############################################

@joaqo Cool, that seems to work on zsh as well.
Thanks for solving it, I\ll update the wiki.


Pi Linux Firmware

actually this could be in terra, should fix some devices on stock fedora pi?

let's keep it here for now

Package works!


Expand tests for UsdUtil, building out a bit more test infrastructure

Built out some more tests of UsdUtil. I feel like there's a way to remove repetition in prim/path creation/testing/removal, but I also suspect it would add more complication than it's worth at this stage. Also, happy to hear suggestions for better namespace organization.

I forgot to clang-format a header and removed a redundant import. This should actually be ready for review now


Remove .debug_pubnames and .debug_pubtypes sections

Summary of the Pull Request
What is this about?
PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

Codecov Report

Merging #3252 (8866f1a) into main (e1923b4) will decrease coverage by 3.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3252      +/-   ##
==========================================
- Coverage   29.65%   25.90%   -3.75%
==========================================
  Files         332      152     -180
  Lines       39289    16383   -22906
==========================================
- Hits        11651     4244    -7407
+ Misses      27638    12139   -15499

see 180 files with indirect coverage changes


Add Traditional Chinese localization

What's Changed

[x] Added Traditional Chinese Localization File
[ ] Localize strings (WIP)

Note
My localization is based on Apple Localization Terms Glossary and myself as a native speaker of Chinese.

hey @ethanhuang13 how is this PR coming along? Is it ready for review? Looking at merging all the new languages and making a release.

Hi @MattKiazyk
It's not ready yet. I won't finish it until the following week. Please ignore it if you are going to release a new version.

Personally, I will keep using the English version of Xcodes. Therefore I've decided not to localize it.
Someone could take over. Announced to the Traditional Chinese iOS community on Twitter.


PID file is not locked

I'm seeing this error whenever I try to start zfs-snap-manager.  It did work with the configuration one time but refused to start any longer.
* zfs-snap-manager.service - ZFS Snapshot Manager
   Loaded: loaded (/usr/lib/systemd/system/zfs-snap-manager.service; enabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Sun 2015-02-15 11:00:57 CST; 2s ago
  Process: 25262 ExecStop=/usr/lib/zfs-snap-manager/manager.py stop (code=exited, status=1/FAILURE)
  Process: 25257 ExecStart=/usr/lib/zfs-snap-manager/manager.py start (code=exited, status=1/FAILURE)
 Main PID: 25257 (code=exited, status=1/FAILURE)

Feb 15 11:00:57 arch manager.py[25262]: File "/usr/lib/zfs-snap-manager/manager.py", line 241, in <module>
Feb 15 11:00:57 arch manager.py[25262]: daemon_runner.do_action()
Feb 15 11:00:57 arch manager.py[25262]: File "/usr/lib/python2.7/site-packages/daemon/runner.py", line 267, in do_action
Feb 15 11:00:57 arch manager.py[25262]: func(self)
Feb 15 11:00:57 arch manager.py[25262]: File "/usr/lib/python2.7/site-packages/daemon/runner.py", line 217, in _stop
Feb 15 11:00:57 arch manager.py[25262]: raise error
Feb 15 11:00:57 arch manager.py[25262]: daemon.runner.DaemonRunnerStopFailureError: PID file '/var/run/zfs-snap-manager.pid' not locked
Feb 15 11:00:57 arch systemd[1]: zfs-snap-manager.service: control process exited, code=exited status=1
Feb 15 11:00:57 arch systemd[1]: Unit zfs-snap-manager.service entered failed state.
Feb 15 11:00:57 arch systemd[1]: zfs-snap-manager.service failed.

Here is my config.
$ cat /etc/zfssnapmanager.cfg
[tank/storage]
mountpoint = /storage
time = trigger
snapshot = True

Can you check what's inside /var/log/zfs-snap-manager.log? I suspect the process dying somewhere during the startup sequence, and this logfile might give more information on that.

I've made a small change so in the future a more user-friendly error will be logged indicating the exact issue if there are issues with the configuration file.

The README lead me to believe there was a default schema value.  See my pull request to update that language.

Thanks


Revert "sqlite{,-analyzer}: use the same src (#40945)"

This reverts commit e28a586f94e77f22d943288ad84f88be23c587f8.
autoconf doesn't set things the same way,
and as a result it seems that Nix built against this
is prone to crashing.
Quick comparison of the build logs and output artifacts:
on master (and after this PR):

-D_REENTRANT=1
references __assert_fail so asserts are probably enabled.

(good thing IMO)

references posix_fallocate64, strerror_r (glibc variant, and happily the posix/xsi variant as provided by musl)
Nix built against it no longer crashes \o/

current staging (without this PR):

nicer expression
picks up malloc_usable_size, strchrnul, utime
Nix built against this crashes

It's likely we can get the "best of both" with some effort/investigation,
but for now I suggest reverting this so it builds a working Nix again :).

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Hmm...

According to https://www.sqlite.org/download.html , sqlite-src is a copy of the raw source tree, sqlite-autoconf and sqlite-amalgamation contain a pre-processed source that essentially puts everything into a single big .c file, which results in better runtime performance (see https://www.sqlite.org/amalgamation.html). But it looks like sqlite_analyzer cannot be build from the "amalgamated" source, so besides the issues with nix, we lose that performance gain if we build everything from the raw source tree.
cc @yegortimoshenko


Added support for instantiating a generic JsonConverter from a JsonConverterAttribute

Added support for instantiating a generic JsonConverter from a JsonConverterAttribute.
Fixes #1332

Tried to rollback commit to fix merge conflict issue. Submitted a PR #1359 as a replacement.


Research Report on Multiparty Automation

Steps

Assignees - assign to community members responsible for work, leave blank if unknown
Add labels -  specify the state of item (ex. 'to do') and work group that is working on the issue (purple labels)
Project - assign to 'Baseline Outreach team' project
Milestone - add to '2022 Outreach Items' milestone
Complete the fields below

Research Report on Multi-Party Automation

Description
Related to the work outlined in [BLIP-] Analyst Report On Multiparty Workflow Spend and Tools, this item tracks the efforts for IDC to conduct an original study on multiparty automation. The effort will be sponsored by several organizations that aim to solve the same problems as the Baseline Protocol, around optimizing processes and spending between organizations, and gather research design requirements from participating organizations.
Anyone is welcome to join these efforts by reaching out to Baseline Outreach Members - Sonal Patel, Carol Geyer, or Paula Lowe.
Definition of 'Done'

[ ] Several companies join the effort as sponsors / stakeholders
[ ] Report is complete based on agreed upon proposal, including all research design reqs.

Steps

[x] Contact analyst firms to find good fit for report
[x] Work through draft proposals from IDC
[x] Obtain final proposal from IDC
[x] Start list of prospects to sponsor the study
[x] Write out messaging template for outreach to sponsors
[ ] Outreach to prospective organizations to sponsor the study
[x] Finalize list of sponsors for study
[ ] Outline needs for sessions to collect design requirements from sponsors
To be continued...

Updates
Issue comments will be used for logging updates and labels will be used for current status and work group responsible for current stage.

7/18/22:

Group session last week to align on immediate steps
Report Proposal being finalized with team to ensure it covers focuses
Prospects lists being wrapped up
Draft message being worked on
All these items to be complete this week to begin outreach

8/1/22:

Almost done with proposal
Sponsorship outreach will begin this week

8/15/22:

Report proposal, messaging for content, and prospects list is complete
IDC will be joining baseline show this week to explain proposal
Community should have consistency in messaging in case we are reaching out to the same companies

9/12/22:

Sonal will inform group on next steps

9/26/22:

Workgroup began outreach
Sonal working with EEA for marketing push

10/24/22:

2 potential sponsors replied to outreach
Sonal connecting with IBM today

1/30/23:

Currently iceboxed as pending sponsor interest


[GOBBLIN-1433] Bump up sql connector version

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1433

Description

[x] Here are some details about my PR, including screenshots (if applicable):

Tests involving SQL break on the latest version of Java 1.8, 1.8.291 which was released April 20, 2021.
Error is caused by
Caused by:                     javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inappropriate)                         at sun.security.ssl.HandshakeContext.<init>(HandshakeContext.java:171)
Recommended solution is to bump up SQL connector version to use compatible encryption methods
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3266 (ce11d12) into master (f11d68f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3266   +/-   ##
=========================================
  Coverage     46.46%   46.46%
  Complexity     9993     9993
=========================================
  Files          2036     2036
  Lines         79180    79180
  Branches       8831     8831
=========================================
  Hits          36794    36794
- Misses        38960    38962    +2
+ Partials       3426     3424    -2

Impacted Files
Coverage Δ
Complexity Δ

...lin/util/filesystem/FileSystemInstrumentation.java
85.71% <0.00%> (-7.15%)
3.00% <0.00%> (ø%)

...a/org/apache/gobblin/cluster/GobblinHelixTask.java
60.21% <0.00%> (-2.16%)
6.00% <0.00%> (ø%)

.../org/apache/gobblin/metrics/RootMetricContext.java
78.12% <0.00%> (-1.57%)
15.00% <0.00%> (-1.00%)

...main/java/org/apache/gobblin/yarn/YarnService.java
14.36% <0.00%> (-0.79%)
4.00% <0.00%> (-1.00%)

.../apache/gobblin/runtime/api/JobExecutionState.java
80.37% <0.00%> (+0.93%)
24.00% <0.00%> (ø%)

...in/java/org/apache/gobblin/cluster/HelixUtils.java
38.01% <0.00%> (+3.30%)
14.00% <0.00%> (+1.00%)

...he/gobblin/source/PartitionAwareFileRetriever.java
55.55% <0.00%> (+7.40%)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11d68f...ce11d12. Read the comment docs.


require('cutorch','cunn','cudnn') does not work

Hi,
My system is Ubuntu 14.04, CUDA 7.0, and I have update the Cmake to 3.2.2
I have install 'cutorch','cunn','cudnn', but when I require('cutorch','cunn','cudnn') ,it give this error:
require'cutorch'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: cuda runtime error (30) : unknown error at /home/sky/torch/extra/cutorch/lib/THC/THCGeneral.c:16
stack traceback:
[C]: in function 'error'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: in function 'require'
[string "_RESULT={require'cutorch'}"]:1: in main chunk
[C]: in function 'xpcall'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:645: in function 'repl'
.../sky/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:199: in main chunk
[C]: at 0x00406670
require'cunn'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: /home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: loop or previous error loading module 'cutorch'
stack traceback:
[C]: in function 'error'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: in function 'require'
[string "_RESULT={require'cunn'}"]:1: in main chunk
[C]: in function 'xpcall'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:645: in function 'repl'
.../sky/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:199: in main chunk
[C]: at 0x00406670
require'cudnn'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: /home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: loop or previous error loading module 'cutorch'
stack traceback:
[C]: in function 'error'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: in function 'require'
[string "_RESULT={require'cudnn'}"]:1: in main chunk
[C]: in function 'xpcall'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:645: in function 'repl'
.../sky/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:199: in main chunk
[C]: at 0x00406670
require('nn') just works fine, only 'cutorch' ,'cudnn'and 'cunn'.
I installed CUDA 7.0 driver and samples could be compiled correctly.
Anyone know how to solve this problem? Thanks

Your CUDA runtime is not initialized.
Run one of the CUDA samples as root (for example the deviceQuery) then you will be able to use CUDA based packages.

Thanks, 'cunn' and 'cutorch' works!
But the 'cudnn' still have the error,it give the erros:
require'cudnn'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: loop or previous error loading module 'cudnn'
stack traceback:
[C]: in function 'error'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:378: in function 'require'
[string "_RESULT={require'cudnn'}"]:1: in main chunk
[C]: in function 'xpcall'
/home/sky/torch/install/share/lua/5.1/trepl/init.lua:645: in function 'repl'
.../sky/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:199: in main chunk
[C]: at 0x00406670

From your command line run:
luajit -lcudnn
does that work? if no what is the error message?

The result is:
luajit -lcudnn
/home/sky/torch/install/share/lua/5.1/cudnn/ffi.lua:574: libcudnn.so: cannot open shared object file: No such file or directory
luajit: /home/sky/torch/install/share/lua/5.1/cudnn/ffi.lua:577: 'libcudnn.so not found in library path.
Please install CuDNN from https://developer.nvidia.com/cuDNN
Then make sure all the files named as libcudnn.so* are placed in your library load path (for example /usr/local/lib , or manually add a path to LD_LIBRARY_PATH)
stack traceback:
[C]: in function 'error'
/home/sky/torch/install/share/lua/5.1/cudnn/ffi.lua:577: in main chunk
[C]: in function 'dofile'
/home/sky/torch/install/share/lua/5.1/torch/init.lua:49: in function 'include'
/home/sky/torch/install/share/lua/5.1/cudnn/init.lua:4: in main chunk
[C]: at 0x0046ac00
[C]: at 0x00406670

@zhunzhon it does not find your cudnn lib, how did you installed it properly? is it in your path (see the install guide for cudnn)
Also in the future, you should post installation related questions on the forum https://groups.google.com/forum/#!forum/torch7

@albanD  Thanks! I have solve this problem after install Cudnn and add the lib.


Bump MLflow to 2.2.2

Describe changes
Bump the MLflow version and add a warning about the remote file access vulnerability
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Also the broken test is one we've seen before and I think can be ignored.


collapseGroups does not move attributes atomically

One thing the collapseGroups plugin does is move all attributes from a <g> element to its child if it only has a single child. It appears that the code intends this to be an "all or none" move (i.e., if any attributes can't be moved, then no attributes are moved).
As currently implemented, the code will move attributes partially and unpredictably - it moves attributes to the child sequentially until it encounters an attribute that it can't move, then it stops moving attributes. So it is possible that only some attributes are moved, and which ones are moved depends on the order of attributes, which may be changed by other plugins.
This bug is one of the reasons for regression failure of \scalable\devices\media-flash.svg.
SVGO 3.2

I see how this is something that should be fixed, but I don't see how this affects rendering. Can you make a MRE?

PR with test case coming shortly.


convert to bundles

Convert all existing CockroachDB Operator release metadata to bundle format

@J0zi  can you ack this? I am migrating with bundle format in this case

@J0zi  can you ack this? I am migrating with bundle format in this case


[WIP] Adding animations for bookmarks

Issue

close #899

Overview (Required)

Introduced Lottie for use in projects.
Replaced bookmark buttons with animated components using Lottie.

Links

https://stackoverflow.com/questions/75180240/use-lottieanimation-in-jetpack-compose-for-icon

Movie (Optional)

Light
Dark

Need help.
I partially replaced the bookmark button with LottieAnimation but the behavior is not what I intended as shown in the attached video.
I have been looking for several hours for a way to fix this but cannot find it.
https://github.com/DroidKaigi/conference-app-2023/assets/13657682/a9dfc633-15a6-4feb-ac47-67e2c329bea5

Well...I don't think it is a very good code even when I look at it myself.😕
But I'm sorry, I don't know how to make it better. 🙇


Refactor the JUL logger to maven logger

There is a simpler way to write it, and I think @Bullfrog666 could learn a few things discovering that better way. This is a follow-up to #154

Since Level is not an enum, the refactoring I was thinking about is in fact not possible


Add drinks icons

goblet-crack closely related to https://github.com/lucide-icons/lucide/pull/1372#issue-1761954212. Uses the same crack from https://lucide.dev/icons/heart-crack (existing wine glass is too small to fit…)

I feel like while the coffee->mug rename is justified, the to-go cup should not replace coffee, but instead be cup-to-go

@karsa-mistmere Welcome back, hope you enjoyed a well earned break!

the to-go cup should not replace coffee, but instead be cup-to-go

Done. However this change throws a “Category food-beverage uses the non-existing icon coffee.” error in the pre-commit hook…

@karsa-mistmere Welcome back, hope you enjoyed a well earned break!

the to-go cup should not replace coffee, but instead be cup-to-go

Done. However this change throws a “Category food-beverage uses the non-existing icon coffee.” error in the pre-commit hook…

Yeah, categories don't use icons anymore, but this is easy to fix if you replace the category icon with mug.

categories don't use icons anymore

@karsa-mistmere Surely all of the categories/*.json/"icon"s  should just be removed then…?

… cup-to-go

Wondering if cup-disposable would be a better name?

… cup-to-go

Wondering if cup-disposable would be a better name?

No way, man, cup-reusable is the way of the future. 😄

No way, man, cup-reusable is the way of the future. 😄

Ha sure, but we would never happen to have them with us on any actual visit to a café 🙈 So I just gave mine to a homeless person…
Maybe cup-to-go is best then…

An icon for drinking water 🚰 would also be useful for maps.

An icon for drinking water 🚰 would also be useful for maps.

@jguddas Feel free to chip in :)

the bottle just looks too small next to the wine glass.

@karsa-mistmere Fixed.

not sure whether we need both coffee-bean and coffee-beans, while both are nicely designed, I think we should just stick with the former.

Ok. Leaving them here for reference…

@danielbayley Can we make the bumps of plastic-bottle a bit more obvious. There a bit hard to see on 100% scale.

Done.

This PR is merged to the lab branch. This PR does not match our PR template, which requires valid use cases. To move on we merged this PR to the lab branch, which will be moved to a separate repo in the future.


API Authentication with SSO

Summary
Hi,
I have Argo Workflow 3.0.7 working with the SSO authentication configured (authenticating against a Keycloak server), I am able to login, access the web interface and launch workflows with a user in the Keycloak realm.
I am now trying to do the same thing via API but unfortunately when I try to pass the token that I get from Keycloak in the API request I get the following error: ""token not valid for running mode"
I am requesting the token from Keycloak via this url: https://keycloak/auth/realms/realm/protocol/openid-connect/token
Is there a different token that I need to request from Keycloak?
Thanks,
Giordano
Diagnostics
What Kubernetes provider are you using?
Kubernetes 1.19.7 on AKS
What version of Argo Workflows are you running?
3.0.7
What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
Did this work in a previous version? I.e. is it a regression?
Paste a workflow that reproduces the bug, including status:
kubectl get wf -o yaml ${workflow}

Paste the logs from the workflow controller:
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Paste the logs from your workflow's wait container:
kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow}

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

You should not use SSO token for API access. Please using client auth-mode with an aceoss token. You can find out how to do this is in the docs.

Hi @alexec that's exactly what I am doing right now.
If the external auth is not supported for the APIs then the issue can be closed.
thanks,
Giordano


Text node

How hard would it be to do a text node only text shows like an annotation in Vizio or just putting clear text next to notes for descriptions.

I could make a node with a textarea. And class transparent or color of note.
You might have a problem with the height of the node. You can see a solution here:

https://github.com/jerosoler/Drawflow/issues/250

Is it possible to have a different type of object for text and not a node ?  There is a line object - is that not different ?
It could be a small div with a transparent BG ... does that fit into this architecture ?

They are different yes, but they are in the core of the library.
There is no easy way to add a new element.
But a node is still a div. It can be made transparent with classes and without inputs and outputs.
You can see in the demo how there is a node without inputs and outputs. And another node with another type of color.

Yep - I created a simple node that has a transparent BG with no connectors ... just need to eliminate the border and it will do the job.
Thanks !


Fix status updater for machine controller

Description:
Resolves #

Codecov Report

Merging #51 (541f1ed) into master (042b191) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   82.76%   83.08%   +0.31%
==========================================
  Files          12       12
  Lines        1149     1153       +4
==========================================
+ Hits          951      958       +7
+ Misses        147      145       -2
+ Partials       51       50       -1

Impacted Files
Coverage Δ

pkg/controllers/machine_controller.go
76.43% <100.00%> (+0.27%)
:arrow_up:

pkg/controllers/machinenodepool_controller.go
81.66% <0.00%> (+1.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042b191...541f1ed. Read the comment docs.


about arcface_loss

Nice work! but you use cos_loss instead of arcface_loss.When i use the arcface_loss, the loss will be nan,and the accuracy will drop.Have you ever been in the same situation

since the cosine loss and arcface loss are similar, and in my experiment, the first reach better acc, so use the cosine loss advance. for your case, maybe you should modify the hyperparametes, and later when i have time i will update the source code.

close, when need reopen.