Creating an ingress object with no http rules makes the controller crash loop

Kubernetes Version
1.28
Helm Chart Version
0.15.0
Ingress Controller Version
0.12.0
System Info
Testing in EKS
Kubernetes Logs
{"level":"info","ts":"2024-09-11T16:34:29Z","logger":"setup","msg":"starting manager","version":"0.12.2","commit":"b28f15b633ca48c2d8ca771df4f4ff82affc7875"}
{"level":"info","ts":"2024-09-11T16:34:29Z","logger":"setup","msg":"configured API client","base_url":"http://api.controlplane.svc.cluster.local"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x15f42c3]

goroutine 1 [running]:
github.com/ngrok/kubernetes-ingress-controller/internal/store.Store.shouldHandleIngressIsValid({{{0x1cf47c0, 0xc0006301c8}, {0x1cf47c0, 0xc0006301e0}, {0x1cf47c0, 0xc000630210}, {0x1cf47c0, 0xc000630228}, {0x1cf47c0, 0xc000630240}, ...}, ...}, ...)
	github.com/ngrok/kubernetes-ingress-controller/internal/store/store.go:427 +0xc3
github.com/ngrok/kubernetes-ingress-controller/internal/store.Store.shouldHandleIngress({{{0x1cf47c0, 0xc0006301c8}, {0x1cf47c0, 0xc0006301e0}, {0x1cf47c0, 0xc000630210}, {0x1cf47c0, 0xc000630228}, {0x1cf47c0, 0xc000630240}, ...}, ...}, ...)
	github.com/ngrok/kubernetes-ingress-controller/internal/store/store.go:391 +0x58
github.com/ngrok/kubernetes-ingress-controller/internal/store.Store.ListNgrokIngressesV1({{{0x1cf47c0, 0xc0006301c8}, {0x1cf47c0, 0xc0006301e0}, {0x1cf47c0, 0xc000630210}, {0x1cf47c0, 0xc000630228}, {0x1cf47c0, 0xc000630240}, ...}, ...})
	github.com/ngrok/kubernetes-ingress-controller/internal/store/store.go:301 +0x11b
github.com/ngrok/kubernetes-ingress-controller/internal/store.(*Driver).PrintState(0xc00001a600, {{0x1cf17f8?, 0xc00047a180?}, 0x7f907095fb80?})
	github.com/ngrok/kubernetes-ingress-controller/internal/store/driver.go:258 +0x5d
main.getDriver({_, _}, {_, _}, {{0x7ffce9dd6c7f, 0x5}, {0x7ffce9dd6c93, 0x24}, {0x7ffce9dd6c62, 0x5}, ...})
	./main.go:413 +0x4d8
main.runController({_, _}, {{0x7ffce9dd6c7f, 0x5}, {0x7ffce9dd6c93, 0x24}, {0x7ffce9dd6c62, 0x5}, {0x7ffce9dd6bb2, 0x1b}, ...})
	./main.go:196 +0x8ce
main.cmd.func1(0xc00029c400?, {0x1a3b72d?, 0x4?, 0x1a3b731?})
	./main.go:111 +0x5b
github.com/spf13/cobra.(*Command).execute(0xc00028a608, {0xc0001b4010, 0xa, 0xa})
	github.com/spf13/cobra@v1.7.0/command.go:940 +0x882
github.com/spf13/cobra.(*Command).ExecuteC(0xc00028a608)
	github.com/spf13/cobra@v1.7.0/command.go:1068 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.7.0/command.go:992
main.main()
	./main.go:76 +0x18

Helm Chart configuration
standard
What happened
Tried to create a minimal ingress object in order to attach a traffic policy to. Since its a redirect, I don't care about the path or other rules, just the domain, so I tried to create an ingress object like this
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    k8s.ngrok.com/traffic-policy: k8s-redirect
  creationTimestamp: null
  name: k8s-redirect
  namespace: ngrok-operators
spec:
  ingressClassName: ngrok
  rules:
  - host: k8s.dev-ngrok.com

This ingress object causes the leader pod to crash, so a new pod takes over as leader which crashes, which continues till they are all down and ingress stops working
NAME                                                     READY   STATUS             RESTARTS        AGE
kubernetes-ingress-controller-manager-849d479c4d-2lqn8   0/1     CrashLoopBackOff   6 (2m40s ago)   10m
kubernetes-ingress-controller-manager-849d479c4d-hhxnm   0/1     CrashLoopBackOff   6 (118s ago)    10m
kubernetes-ingress-controller-manager-849d479c4d-lb5m5   0/1     CrashLoopBackOff   6 (2m22s ago)   10m

What you think should happen instead
At the very least this should not cause the controller to crash which would result in an outage for someone.
Ideally, this configuration would be accepted and result in a end with no routes assuming that would work with a traffic policy to handle redirects
How to reproduce
create an ingress object in the cluster with no rules, sit back and watch them start crashing

Looks like its probably https://github.com/ngrok/ngrok-operator/blob/1e2367de30c22a043fac83b7c946eb24925d4423/internal/store/store.go#L424

ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"starting api-manager","version":"0.13.1","commit":"038fd478397658abd72b656d386f617eb0e6462a"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"configured API client","base_url":"https://api.ngrok.com"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"found matching ingress","ingress-name":"chess-bot-ngrok","ingress-namespace":"ngrok"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"Migrating Kubernetes Ingress Controller labels to ngrok operator"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"Kubernetes Ingress controller labels migrated to ngrok operator"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"Ingress feature set enabled"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"Gateway feature set disabled"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"Endpoint Bindings feature set disabled"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"setup","msg":"starting api-manager"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"controller-runtime.metrics","msg":"Starting metrics server"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","msg":"starting server","kind":"health probe","addr":":8081"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:28Z","logger":"controller-runtime.metrics","msg":"Serving metrics server","bindAddress":":8080","secure":false}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l I1110 15:09:28.278226       1 leaderelection.go:250] attempting to acquire leader lease ngrok/ngrok-ngrok-operator-leader...
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l I1110 15:09:43.813373       1 leaderelection.go:260] successfully acquired lease ngrok/ngrok-ngrok-operator-leader
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"service","controllerGroup":"","controllerKind":"Service","source":"kind source: *v1.Service"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"service","controllerGroup":"","controllerKind":"Service","source":"kind source: *v1alpha1.Tunnel"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"domain","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"Domain","source":"kind source: *v1alpha1.Domain"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"domain","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"Domain"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"service","controllerGroup":"","controllerKind":"Service","source":"kind source: *v1alpha1.TCPEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"service","controllerGroup":"","controllerKind":"Service","source":"kind source: *v1alpha1.TLSEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"service","controllerGroup":"","controllerKind":"Service","source":"kind source: *v1alpha1.NgrokModuleSet"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"service","controllerGroup":"","controllerKind":"Service","source":"kind source: *v1alpha1.NgrokTrafficPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"service","controllerGroup":"","controllerKind":"Service"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"tlsedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TLSEdge","source":"kind source: *v1alpha1.TLSEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"tlsedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TLSEdge","source":"kind source: *v1alpha1.IPPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"tlsedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TLSEdge","source":"kind source: *v1alpha1.Domain"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"tlsedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TLSEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"tcpedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TCPEdge","source":"kind source: *v1alpha1.TCPEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"tcpedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TCPEdge","source":"kind source: *v1alpha1.IPPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"tcpedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TCPEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ippolicy","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"IPPolicy","source":"kind source: *v1alpha1.IPPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"ippolicy","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"IPPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"httpsedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"HTTPSEdge","source":"kind source: *v1alpha1.HTTPSEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"httpsedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"HTTPSEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ngrokmoduleset","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"NgrokModuleSet","source":"kind source: *v1alpha1.NgrokModuleSet"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"ngrokmoduleset","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"NgrokModuleSet"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"kubernetesoperator","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"KubernetesOperator","source":"kind source: *v1alpha1.KubernetesOperator"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"kubernetesoperator","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"KubernetesOperator"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ngroktrafficpolicy","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"NgrokTrafficPolicy","source":"kind source: *v1alpha1.NgrokTrafficPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"ngroktrafficpolicy","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"NgrokTrafficPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"cloudendpoint","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"CloudEndpoint","source":"kind source: *v1alpha1.CloudEndpoint"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"cloudendpoint","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"CloudEndpoint","source":"kind source: *v1alpha1.NgrokTrafficPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"cloudendpoint","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"CloudEndpoint"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","source":"kind source: *v1.Ingress"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","source":"kind source: *v1.IngressClass"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","source":"kind source: *v1.Service"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","source":"kind source: *v1alpha1.Domain"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","source":"kind source: *v1alpha1.HTTPSEdge"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","source":"kind source: *v1alpha1.Tunnel"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","source":"kind source: *v1alpha1.NgrokModuleSet"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting EventSource","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","source":"kind source: *v1alpha1.NgrokTrafficPolicy"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting Controller","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"domain","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"Domain","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"tcpedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TCPEdge","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"httpsedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"HTTPSEdge","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"tlsedge","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"TLSEdge","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","logger":"controllers.tls-edge","msg":"Listing TLSEdges for domain to determine if they need to be reconciled"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"ngrokmoduleset","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"NgrokModuleSet","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"cloudendpoint","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"CloudEndpoint","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"kubernetesoperator","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"KubernetesOperator","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"service","controllerGroup":"","controllerKind":"Service","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"ippolicy","controllerGroup":"ingress.k8s.ngrok.com","controllerKind":"IPPolicy","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:43Z","msg":"Starting workers","controller":"ngroktrafficpolicy","controllerGroup":"ngrok.k8s.ngrok.com","controllerKind":"NgrokTrafficPolicy","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:44Z","msg":"Starting workers","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","worker count":1}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l {"level":"info","ts":"2024-11-10T15:09:44Z","msg":"Observed a panic in reconciler: runtime error: invalid memory address or nil pointer dereference","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","Ingress":{"name":"chess-bot","namespace":"chess-bot"},"namespace":"chess-bot","name":"chess-bot","reconcileID":"2febccd3-de1b-44a7-b2d7-7fa4effd736c"}
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l panic: runtime error: invalid memory address or nil pointer dereference [recovered]
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     panic: runtime error: invalid memory address or nil pointer dereference
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xb5eab0]
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l goroutine 476 [running]:
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:116 +0x19c
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l panic({0x132ea00?, 0x24c82e0?})
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     runtime/panic.go:785 +0x124
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l k8s.io/api/networking/v1.(*Ingress).GetObjectKind(0x24d3620?)
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     <autogenerated>:1
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l k8s.io/client-go/tools/reference.GetReference(0x40001f0c40, {0x17f9960, 0x0})
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     k8s.io/client-go@v0.29.2/tools/reference/ref.go:59 +0x124
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l k8s.io/client-go/tools/record.(*recorderImpl).generateEvent(0x4000812880, {{0x1811d78?, 0x4000054700?}, 0x1?}, {0x17f9960, 0x0}, 0x0, {0x155a76a, 0x7}, {0x1567a2c, ...}, ...)
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     k8s.io/client-go@v0.29.2/tools/record/event.go:423 +0x6c
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l k8s.io/client-go/tools/record.recorderImplLogger.Event(...)
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     k8s.io/client-go@v0.29.2/tools/record/event.go:497
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l k8s.io/client-go/tools/record.recorderImplLogger.Eventf({0x4000812880?, {{0x1811d78?, 0x4000054700?}, 0x1815400?}}, {0x17f9960, 0x0}, {0x155a76a, 0x7}, {0x1567a2c, 0x12}, ...)
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     k8s.io/client-go@v0.29.2/tools/record/event.go:501 +0xa8
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l sigs.k8s.io/controller-runtime/pkg/internal/recorder.(*lazyRecorder).Eventf(0x400035a840, {0x17f9960, 0x0}, {0x155a76a, 0x7}, {0x1567a2c, 0x12}, {0x1589d82, 0x27}, {0x4000a02770, ...})
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/recorder/recorder.go:169 +0xec
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l github.com/ngrok/ngrok-operator/internal/controller/ingress.(*IngressReconciler).Reconcile(0x400053a180, {0x180d768, 0x400083a330}, {{{0x40003271b0, 0x9}, {0x4000327150, 0x9}}})
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     github.com/ngrok/ngrok-operator/internal/controller/ingress/ingress_controller.go:107 +0x534
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x1812048?, {0x180d768?, 0x400083a330?}, {{{0x40003271b0?, 0xb?}, {0x4000327150?, 0x0?}}})
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:119 +0x80
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0x40004f81e0, {0x180d7a0, 0x40004b4d70}, {0x13ba8c0, 0x40004da560})
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:316 +0x2d0
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0x40004f81e0, {0x180d7a0, 0x40004b4d70})
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:266 +0x158
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:227 +0x70
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 147
ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:223 +0x400
Stream closed EOF for ngrok/ngrok-ngrok-operator-manager-659bdbfdbb-jpr7l (ngrok-operator)

If you configure an ingress by accident with no host at all,
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: chess-bot-ngrok
  namespace: chess-bot
spec:
  ingressClassName: ngrok
  rules:
  - http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: chess-bot
            port:
              number: 8080

ngrok-operator-manager-6cc495dbbc-vhn6v {"level":"info","ts":"2024-11-10T15:35:02Z","msg":"Observed a panic in reconciler: runtime error: invalid memory address or nil pointer dereference","controller":"ingress","controllerGroup":"networking.k8s.io","controllerKind":"Ingress","Ingress":{"name":"chess-bot-ngrok","namespace":"chess-bot"},"namespace":"chess-bot","name":"chess-bot-ngrok","reconcileID":"c8a85fa3-ecef-4ab0-9ffd-f31766b2e1af"}
ngrok-operator-manager-6cc495dbbc-vhn6v panic: runtime error: invalid memory address or nil pointer dereference [recovered]
ngrok-operator-manager-6cc495dbbc-vhn6v     panic: runtime error: invalid memory address or nil pointer dereference
ngrok-operator-manager-6cc495dbbc-vhn6v [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xb5eab0]
ngrok-operator-manager-6cc495dbbc-vhn6v
ngrok-operator-manager-6cc495dbbc-vhn6v goroutine 429 [running]:
ngrok-operator-manager-6cc495dbbc-vhn6v sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
ngrok-operator-manager-6cc495dbbc-vhn6v     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:116 +0x19c
ngrok-operator-manager-6cc495dbbc-vhn6v panic({0x132ea00?, 0x24c82e0?})
ngrok-operator-manager-6cc495dbbc-vhn6v     runtime/panic.go:785 +0x124
ngrok-operator-manager-6cc495dbbc-vhn6v k8s.io/api/networking/v1.(*Ingress).GetObjectKind(0x24d3620?)
ngrok-operator-manager-6cc495dbbc-vhn6v     <autogenerated>:1
ngrok-operator-manager-6cc495dbbc-vhn6v k8s.io/client-go/tools/reference.GetReference(0x4000170e00, {0x17f9960, 0x0})
ngrok-operator-manager-6cc495dbbc-vhn6v     k8s.io/client-go@v0.29.2/tools/reference/ref.go:59 +0x124
ngrok-operator-manager-6cc495dbbc-vhn6v k8s.io/client-go/tools/record.(*recorderImpl).generateEvent(0x400078f7c0, {{0x1811d78?, 0x4000054700?}, 0x1?}, {0x17f9960, 0x0}, 0x0, {0x155a76a, 0x7}, {0x1567a2c, ...}, ...)
ngrok-operator-manager-6cc495dbbc-vhn6v     k8s.io/client-go@v0.29.2/tools/record/event.go:423 +0x6c
ngrok-operator-manager-6cc495dbbc-vhn6v k8s.io/client-go/tools/record.recorderImplLogger.Event(...)
ngrok-operator-manager-6cc495dbbc-vhn6v     k8s.io/client-go@v0.29.2/tools/record/event.go:497
ngrok-operator-manager-6cc495dbbc-vhn6v k8s.io/client-go/tools/record.recorderImplLogger.Eventf({0x400078f7c0?, {{0x1811d78?, 0x4000054700?}, 0xffffa8ea9130?}}, {0x17f9960, 0x0}, {0x155a76a, 0x7}, {0x1567a2c, 0x12}, ...)
ngrok-operator-manager-6cc495dbbc-vhn6v     k8s.io/client-go@v0.29.2/tools/record/event.go:501 +0xa8
ngrok-operator-manager-6cc495dbbc-vhn6v sigs.k8s.io/controller-runtime/pkg/internal/recorder.(*lazyRecorder).Eventf(0x400025bb00, {0x17f9960, 0x0}, {0x155a76a, 0x7}, {0x1567a2c, 0x12}, {0x1589d82, 0x27}, {0x400092bbf0, ...})
ngrok-operator-manager-6cc495dbbc-vhn6v     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/recorder/recorder.go:169 +0xec
ngrok-operator-manager-6cc495dbbc-vhn6v github.com/ngrok/ngrok-operator/internal/controller/ingress.(*IngressReconciler).Reconcile(0x40004a32c0, {0x180d768, 0x4000b53c80}, {{{0x4000c94147, 0x9}, {0x4000c94150, 0xf}}})
ngrok-operator-manager-6cc495dbbc-vhn6v     github.com/ngrok/ngrok-operator/internal/controller/ingress/ingress_controller.go:107 +0x534
ngrok-operator-manager-6cc495dbbc-vhn6v sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x1812048?, {0x180d768?, 0x4000b53c80?}, {{{0x4000c94147?, 0xb?}, {0x4000c94150?, 0x0?}}})
ngrok-operator-manager-6cc495dbbc-vhn6v     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:119 +0x80
ngrok-operator-manager-6cc495dbbc-vhn6v sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0x4000195e00, {0x180d7a0, 0x40002031d0}, {0x13ba8c0, 0x400045bea0})
ngrok-operator-manager-6cc495dbbc-vhn6v     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:316 +0x2d0
ngrok-operator-manager-6cc495dbbc-vhn6v sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0x4000195e00, {0x180d7a0, 0x40002031d0})
ngrok-operator-manager-6cc495dbbc-vhn6v     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:266 +0x158
ngrok-operator-manager-6cc495dbbc-vhn6v sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
ngrok-operator-manager-6cc495dbbc-vhn6v     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:227 +0x70
ngrok-operator-manager-6cc495dbbc-vhn6v created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 126
ngrok-operator-manager-6cc495dbbc-vhn6v     sigs.k8s.io/controller-runtime@v0.17.4/pkg/internal/controller/controller.go:223 +0x400
Stream closed EOF for ngrok/ngrok-operator-manager-6cc495dbbc-vhn6v (ngrok-operator)


Delete .github/workflows/ci-lint.yml

This pull request has been automatically closed due to 30 days of inactivity. If you believe this was done in error, please feel free to reopen the PR or reach out to the BT team for further assistance. Thank you for your contributions!


Crash triggered by [PFBaseSecureKeyWrapper getSignatureBytesUsingPrivateKey]

PayPal SDK Version
1.1.0
Environment
Both
Xcode Version
15.2
OS Version & Device
No response
Integration type
CocoaPods
Development Processor
Both
Describe the bug
Our app users are hitting crashes due to this line of code in iOS version 1.1.0 of the PayPal/PayPalNativePayments SDK.
(This crash has affected 31 users in the past 90 days.)
0x505b24 __75-[PFBaseSecureKeyWrapper getSignatureBytesUsingPrivateKey:data:completion:]_block_invoke + 72
Looks like a possible memory access issue.
Here is one example from crashlytics:

To reproduce
Unclear.  I can't reproduce it myself but this crash has been reported 31 times in the past 90 days via our crashlytics dashboard.
Expected behavior
No crash
Screenshots
No response

hi @patpatchpatrick 👋🏽 - thanks for bringing this issue to our attention. unfortunately, i've not been able to reproduce it on version 1.1.0. could you please try updating to our latest version 1.3.1 if possible and let us know if this issue still occurs.

Hello, we've forwarded this to team in charge of PayPalCheckout module to see if they can help.
Thank you for you patience.

It looks like it possibly started around April 18.  I'm not seeing any logs of this crash prior to then.
I can try updating and see if the resolves this issue.


Capture output of STRTCPSVR when running interactively

Fixes #117.
@chrjorgensen , please review. Thanks!

(never mind the JAva bugfixes I have on this same branch; I am too lazy to move them)

@chrjorgensen good find! I will experiment with this tomorrow. Not going through qshell would be great

@chrjorgensen that works great! Requesting review of the change


Fix niche case where alphabetical dll ordering was relevant

This is a bit of an arbitrary fix to a very niche issue, but it's benign enough that I think it's worth including.
Long story short: Having a dependency mod that has a different .dll name than internal Assembly Name will cause any directly dependent mods that come alphabetically before it to fail to load, crashing MelonLoader.
An example error of what happens without this change is below. AutoEscape comes alphabetically before but is dependent on an assembly named BloonsTD6 Mod Helper, but here that's been renamed to BtdModHelper.dll
Loading Melon Assembly: 'C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\Mods\AutoEscape.dll'...
[ERROR] System.TypeLoadException: Could not load type AutoEscape.AutoEscapeMod while decoding custom attribute: (null)
  at (wrapper managed-to-native) System.MonoCustomAttrs.GetCustomAttributesInternal(System.Reflection.ICustomAttributeProvider,System.Type,bool)
  at System.MonoCustomAttrs.GetCustomAttributesBase (System.Reflection.ICustomAttributeProvider obj, System.Type attributeType, System.Boolean inheritedOnly) [0x00013] in <e1319b7195c343e79b385cd3aa43f5dc>:0
  at System.MonoCustomAttrs.GetCustomAttributes (System.Reflection.ICustomAttributeProvider obj, System.Type attributeType, System.Boolean inherit) [0x00037] in <e1319b7195c343e79b385cd3aa43f5dc>:0
  at System.Reflection.Assembly.GetCustomAttributes (System.Type attributeType, System.Boolean inherit) [0x00000] in <e1319b7195c343e79b385cd3aa43f5dc>:0
  at System.Attribute.GetCustomAttributes (System.Reflection.Assembly element, System.Boolean inherit) [0x00014] in <e1319b7195c343e79b385cd3aa43f5dc>:0
  at MelonLoader.MelonUtils.PullAttributesFromAssembly[T] (System.Reflection.Assembly asm, System.Boolean inherit) [0x00000] in <e0709781047e4b5bb34a1650ae2b1be2>:0
  at MelonLoader.MelonUtils.PullAttributeFromAssembly[T] (System.Reflection.Assembly asm, System.Boolean inherit) [0x00000] in <e0709781047e4b5bb34a1650ae2b1be2>:0
  at MelonLoader.MelonAssembly.LoadMelons () [0x0008d] in <e0709781047e4b5bb34a1650ae2b1be2>:0
  at MelonLoader.MelonAssembly.LoadMelonAssembly (System.Reflection.Assembly assembly) [0x00083] in <e0709781047e4b5bb34a1650ae2b1be2>:0
  at MelonLoader.MelonAssembly.LoadMelonAssembly (System.String path) [0x00036] in <e0709781047e4b5bb34a1650ae2b1be2>:0
  at MelonLoader.MelonHandler.LoadMelonsFromDirectory[T] (System.String path) [0x0007d] in <e0709781047e4b5bb34a1650ae2b1be2>:0
  at MelonLoader.Core.Start () [0x00014] in <e0709781047e4b5bb34a1650ae2b1be2>:0

I've tried a lot of different workarounds, but it's hard to avoid when the error itself is coming from the actual .NET system code.
This is a pretty non-galaxy-brain fix here, just making a quick guess on if the mod might need its Assembly loaded first based on if it contains some common terms like "API", "Lib" or "Helper". This should not cause any breakage at all, but would help to avoid having to tell users to put _ and ~ characters at the beginnings of certain DLL names.
You can ping me @doombubbles in the #modders-chat of the MelonLoader discord if you've got questions / concerns / a better solution.

I am sorry but I would rather an actual fix be done to the Dependency Graph sorting system.
This change you provided can cause more issues with other games.
If a game happens to have a mod that has those words it will priority load them improperly.
For example say I had a mod named "SlapTheHamHelper" and it depends on a mod named "AlphaTurkeyBaster".
With your changes "SlapTheHamHelper" would end up loading before "AlphaTurkeyBaster" and breaking it.


Strict null check 'src/vs/workbench/parts/comments/*'

Part of #60565
Tracks updating src/vs/workbench/parts/comments/ to have strict null checking. There are about 100 errors in these files
You do not need to fix errors outside of src/vs/workbench/parts/comments/
Steps

Add src/vs/workbench/parts/comments/**/*.ts to the include section of src/tsconfig.strictNullChecks.json
Run yarn strict-null-check -- --watch
Fix strict null check compiler errors
Verify normal build still works
If there are still errors outside of src/vs/workbench/parts/comments/, don't include  the changes to  tsconfig.strictNullChecks.json when checking in

@RMacfarlane we can postpone the work after we refactor the whole API work.

These files were accounting for a quarter of the remaining the strict null errors in VS Code so I did a quick brute-force strict null check pass to get them enabled.
Because of the large number of errors and structure of this code—and because I did not want to heavily refactor in this pass—I had to use a number of null suppressions. Please revisit these when you can


Docker image

@florianschmidt1994 just wished for this :D

Great idea! Would also love this as I'm too lazy to set all things up :+1:

Great idea! 👍

Great idea, I would love to get the server up and running without manual setup steps. Hasn't it already been done here (https://github.com/publicplan/ParkAPI/commit/d2bf77346b2b80f9c219c8cb1c8d22735d1b8c7e)? @Mechtecs does it work?

Yes it works @jb3-2, it is used in production since I added it.

Wow, great! Could you maybe create a pull request towards the original repo so we can all profit from that easily? Thank you so much!

I have merged #171. Can you please check if everything works? We could the close this issue.

Since this seems to be fixed I'll close this issue. Reopen if required.

The current Dockerfile has live_scrape set to true, which shouldn't be the case for actual production usage. This causes the application to fetch current data on every request to /<city>, potentially causing lots of unnecessary load on data providers.

We've opened a pull request for this.


Maven Dependencies: com.ibm.sparktc.sparkbench:sparkbench:2.3.0_0.4.0: not found

Hi Spark-Bench team,
we have been using spark-bench into one of our SANSA benchmarking suite for improvement of RDF parsing.
I see that spark-bench has recently gone through an extensive rewrite, therefore the dependency we are using is missing from Maven Central Repository (e.g. https://mvnrepository.com/artifact/net.sansa-stack/sansa-rdf-spark_2.11/0.6.0).
Is there any plan to publish a dependency on which we can re-use it? or is there a workaround that keeps us using a legacy version of the system.
Update: We have removed the spark-bench dependency from our main APIs and used it only internally into SANSA-Bench repo.
Best regards,

Hi again,
I'm going to close this issue for now as we found a workaround. Please, do let us know if there is a plan&roadmap to publish the artifact.
Best regards,


Include the meta field in the node_info property description

Contributions

[X] I have read the contribution docs, and understand what's expected of me.

What page(s) or areas on docs.getdbt.com are affected?
https://docs.getdbt.com/reference/events-logging
What changes are you suggesting?
https://github.com/dbt-labs/dbt-core/pull/6493 adds the meta field to the node_info property of structured logs.
This issue suggests that the meta should be added to the list of fields in node_info.
Additional information
No response

Thanks for opening @tmastny, and nice work getting the contribution merged in time for inclusion in v1.4!
I'll include this update as part of the broader changes to events/logging (https://github.com/dbt-labs/docs.getdbt.com/issues/2639)


RFE - Regen Device Cert

It is common practice to regenerate the device cert with the CN as the hostname.  This needs to happen before HA, so the new cert is used HA/DSC/iQuery communications as needed.  This is also a big plus from a security perspective since it would help promote the generation of a new unique cert/key pair as part of the deployment.
It would be nice, at a minimum, to have a flag, possibly in the tenant class, like "regenDeviceCert": true/false, that would regen the device cert with CN=hostname.  Or maybe a new class to set import a cert/key, or set certificate details like more subject information, key-length, and days?
Commands I use for this:
# generate new cert/key, overwriting default
openssl req -x509 -nodes -days 3650 -newkey rsa:2048 -subj "/CN=$HOSTNAME" -keyout /config/httpd/conf/ssl.crt/server.key -out /config/httpd/conf/ssl.crt/server.crt
#  Add cert to trusted cert stores - This is necessary for proper device trust and iquery usage.
cat /config/httpd/conf/ssl.crt/server.crt >> /config/big3d/client.crt && cat /config/httpd/conf/ssl.crt/server.crt >> /config/gtm/server.crt
# restart httpd to pick up new cert/key
tmsh restart sys service httpd

Would having the ability to include certificates in the DO declaration satisfy your use case?

Potentially, however, I think it would make more work on the end user.  This would allow for enterprises to supply CA signed certs and KEYs.  Which is good from an enterprise security perspective (mostly), but it definitely complicates the environment with a DNS iquery mesh.  Where certs would have to be updated in a very specific way, or risk loosing iquery and supportin F5 DNS infrastructure.
On bigips, it is recommended to have self-signed device certs with a 10 year expiration for the best iquery stability.
I think both (user provided and self-signed on box) would be best for options.  My big hesitation is that whatever is sending the declaration would have to generate and/or manage device certificates/keys, which is another layer of complexity from just building and sending the declaration.
I guess this is something that is already being done with as3 and public application certs, but I feel that is unnecessarily complicates things since the device cert should be self-signed with a 10 year expiration.

Thank you for clarifying your use case. I agree that it would make sense to have this feature alongside the ability to upload certificates. Do you happen to have some documentation handy for those self signed certificate recommendations?

I have added this feature request to our internal product backlog as AUTOTOOL-957.

Hi @dstokesf5 when this feature will released ?

@tizianorosato-gr This item is in our product backlog, but not yet on the road map. If this feature request is urgent, please open a support case
(https://support.f5.com/csp/article/K2633) to get it more attention and escalate the priority of it.

I too would like to see the ability to import device certificates via DO. That would allow me to use certificates/keys issued from my PKI environment, rather than use self-signed.

Added to EPIC. This might be blocked. Flagging as a SPIKE

Update on this task for the next Sprint
They are Ok with providing Cert and Key with the DO Declaration.

That would be great if the certificate would be copy to GTM, on initial onboarding and if DNS is provisioned.
he is very aware that playing with GTM cert after the first deployment could be tricky and break existing DNS Mesh and even in the Non Automated world, DNS cert operations need to be carefully planned.


raspberrypi3-64.conf: Don't use raspberrypi as MACHINEOVERRIDES

The current setup broke the build for rpi3-64 when we wanted to port
some changes from rpi3 to rpi0.

@michal-mazurek could you add to this PR the change for bluez too?

Actually that was not merged. Wouldn't that help you too?

Friendly ping towards @michal-mazurek .

I'll get back to this PR soon.

@michal-mazurek any update on this?

Did you mean this commit? https://github.com/resin-os/resin-raspberrypi/commit/91e567ee290501311897bce92f6f627c2335c480 -- do you think it is still necessary after the change from this commit is applied?

I'm a little confused @michal-mazurek . That is in resinOS. I was talking about this commit in the BSP.

You asked me to "add to this PR the change for bluez". I was asking which "change for bluez" specifically you meant. Is it the one I linked to?


solve list cannot add to tuple error in make_signature function

[ ] closes #xxxx
[ ] tests added / passed
[ ] passes git diff upstream/master | flake8 --diff
[ ] whatsnew entry

Current coverage is 85.23% (diff: 0.00%)

Merging #13878 into master will not change coverage

@@             master     #13878   diff @@
==========================================
  Files           140        140
  Lines         50456      50456
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          43007      43007
  Misses         7449       7449
  Partials          0          0

Powered by Codecov. Last update d4f95fd...1ecdeb6

what exactly does this break?

when I run an example like:
`from pandas.util.decorators import make_signature
def f(a,b,c=2) :
return abc
print(make_signature(f))`
I will get an error as:
defaults = ('',) * n_wo_defaults + spec.defaults
TypeError: can only concatenate tuple (not "list") to tuple

hmm, that does fail (only in py3). Well must have been a typo in the copy paste a while back. Can you add a test in pandas/tests/test_util.py.  make_signature is actually used in pandas.core.groupby. Can you repro an error from something?

can you rebase / update?


Update zip code example

The zip code example doesn't compile. It needs to be updated to the latest version of its dependencies.

Done :smile:


Has anyone tried serving the app by any back-end frameworks like Laravel, Ruby on Rails or Phoenix?

Am trying to serve an app created by create-react-app from express-generator which has his own file structure.
the basic solution i have is moving the app into the express views directory..
i think Building for Relative Paths from the User Guide might get me closer the solution but am just confused..
any help?

Maybe check out this article => Running Create React App and Express (CRAE) on Heroku

Yep, hopefully it helps!
CRA just produces a static build folder with HTML.
You just need to either serve it statically, or load that HTML with Express and serve it from Express views (but don't forget to still serve JS and CSS statically).


Incorrect bit_set formatting behavior

Repro:
Format the following code:
Enum :: enum {
    Foo,
    Bar,
    Baz,
    Asd,
    Fff,
}

Bit_Set :: bit_set[Enum]

foo :: proc() {
    before_format := Bit_Set {
        // .Foo,
        .Bar,
        // .Baz,
        .Asd,
        // .Fff,
    }
}

The bit set is formatted as after_format := Bit_Set{.// .Foo,Bar, .// .Baz,Asd}// .Fff,
Note that the issue appears even in simpler cases, but it seems that there are a few separated but related formatting errors, depending on where the comments are placed.

Should be fixed.


Way to convey package depreciation warnings

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

Issue

With the release of 2.0 many packages are out there that have no hyper- prefix. Now that will be hard for a package maintainer to notify users that they need to update or switch packages. So now for the further releases there should be a way to display package depreciation warnings. Maybe a sweet notification will do the deal as there are notification for version update. Also I gave a thought to npm postinstall scripts but I believe hyper installs plugin silently so there will be no effect.
See discussion here -> https://twitter.com/wesbos/status/985920717052051457
I am truely hoping there is an way already

Oh okay I missed that one when I was searching that issues. Now I will follow that. :smile:


ip address

hi @matteo,
is possible to get the ip addess of a client? Or can you suggest me where is convenient to edit aedes or its modules, to add more information about the client (as the ip address) when the server parse the messages coming from mosca or other mqtt clients?

The underlining stream is available at https://github.com/mcollina/aedes/blob/master/lib/client.js#L21.
Refer to the stream (net, ssl, websocket-stream, etc) to how to get that information.

If you want to send a PR to make that easier, please do :).


style(spellcheck): Run a spellchecker and fix typos

Fix a broken link and a few misspellings.

Codecov Report

Merging #580 (5aa14a3) into main (faed120) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   61.18%   61.18%
=======================================
  Files          85       85
  Lines       12553    12553
=======================================
+ Hits         7680     7681    +1
+ Misses       4873     4872    -1


Bugzilla 1744245: Subscription should not point to deleted ip

Delete and recreate of a subscription object without any delay causes
operator install to fail.
How to reproduce:

Create a CatalogSource object, wait for it to become healthy.
Create a Subscription that refers to the CatalogSource above.
Wait for the operator to install successfully.
Update the CatalogSource
Wait for the updated CatalogSource to become healthy.
Delete the Subscription object ( created above ).
Recreate the Subscription object ( no time delay between delete
and create ). Delete and Create can be done one after another, there
is no need to make them concurrent.

Solution:

The InstallPlan object(s) are listed using a lister which may
return a deleted InstallPlan object. Use a non-cached client
to query list of InstallPlan object(s)

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1744245

/refresh bugzilla

/bugzilla refresh

/bugzilla refresh

/retest


Allow fuzzer to persist repro data on disk upon failure

Summary
Adds functionalities to:

allow fuzzer to persist problematic repro data (both input and result vector)
and expression on disk.
allow fuzzer to read from on-disk repro data and expression to reproduce
error.

Tests:
Initial run to get failed run, persisting on disk:
/Users/jtan6/git-repos/presto/presto-native-execution/cmake-build-debug/velox/velox/expression/tests/velox_expression_fuzzer_test --repro_persist_path /tmp/abc --seed<PHONE_NUMBER> --v=1 --logtostderr=1
Run log:
https://gist.github.com/tanjialiang/c97820551da3dd14a9a73625a1b5615a
Second run with first run's data:
/Users/jtan6/git-repos/presto/presto-native-execution/cmake-build-debug/velox/velox/expression/tests/velox_expression_fuzzer_test --repro_data_restore_path /tmp/abc/velox_vector_Fh7WYR --repro_sql_restore_path /tmp/abc/velox_sql_ZjSKgw --steps 1 --v=1 --logtostderr=1
Run log:
https://gist.github.com/tanjialiang/f4b4d70a416d1ff0ca280309496cf878

extract file creation logic out, common/file/..
save expr could be generic as stirng opertion. remove expr saver api to let caller to directly use VectorSavor
extract the result/exception comparison part of fuzzer out
use 3. to create another executable to specifically reproduce from saved files.
[next item] add support for crash persistency (write to file every iteration, reuse ostream to allow all in-memory operation)


p4rt-1.1: include traceroute ipv6 and ttl0/ttl2 use cases

Changes:

Validate Read/Write RPCs for all 8 entries instead of only 3 (traceroute ipv4 & ipv6 with TTLs=0/1/2 + gdp + lldp)
Minor optimization: remove unnecessary match counters

Resolves #2364

This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.

Pull Request Functional Test Report for #2362 / b23abac940d3f8eb25f6b7c08a87280ebcacab0b
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

P4RT-1.1: Base P4RT Functionality

Cisco 8000E

P4RT-1.1: Base P4RT Functionality

Cisco XRd

P4RT-1.1: Base P4RT Functionality

Juniper cPTX

P4RT-1.1: Base P4RT Functionality

Juniper ncPTX

P4RT-1.1: Base P4RT Functionality

Nokia SR Linux

P4RT-1.1: Base P4RT Functionality

Openconfig Lemming

P4RT-1.1: Base P4RT Functionality

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

P4RT-1.1: Base P4RT Functionality

Cisco 8808

P4RT-1.1: Base P4RT Functionality

Juniper PTX10008

P4RT-1.1: Base P4RT Functionality

Nokia 7250 IXR-10e

P4RT-1.1: Base P4RT Functionality

Help

Replied in b/310023505

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.168%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1643

Relevant Lines:
3275

💛  - Coveralls


Finetune model for Japanese language with LaboroTVSpeech corpus

Hi, thank you for all the work you did with the models training.
Recently I discovered quite good speech corpus for Japanese language: https://github.com/laboroai/LaboroTVSpeech. Could you please be so kind and add it to your finetuned model for Japanese language?

Thanks for the corpus link!
I'm planning to improve the Japanese model (and other languages too), but I'm running out of GPU resources, and I'm focusing on improving a small subset of my models right now, and unfortunately Japanese isn't in this subset 😢
But I'm figuring out how to get access to more GPU resources to improve my models, and Japanese is one of the models that I really want to improve soon, and the corpus you've sent will be handy for this 😃
Regards
Jonatas Grosman


Transform text/uri-list mime values in data transfers

Fixes #165636
This passes any text/uri-list mime values in a datatransfer through our uri transformers. Because these uri values are stored as a list of strings, they are not automatically transformed

Thanks @jrieken. I switched to a different approach. Please re-review when you have a chance!


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test

Docs Build status updates of commit e89d1dd:
:clock10: Pending: waiting for processors (10 builds ahead of you)
:warning: Docs Build is busy, currently there are 10 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit e89d1dd:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-27-05-12-36 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-27-05-12-36

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix GitLab build use of APP_VERSION

What this PR does / why we need it:
Fixes building/pushing images on GitLab
Release note:
NONE

/retest


(PUP-5577) Don't require /run/systemd/system for systemd

Revert this part of 7fe61647f23650fc4c93cd6b54c654a20ff7c9f9 because
it means systemd is not detected if running puppet within a chroot
environment where this is not yet mounted.

Heads up @whopper, since you've been looking at some other systemd use cases. Not sure if this overlaps at all or not, but figured it's worth a ping.

This isn't directly related to the recent systemd issues we've been having, as this potentially affects any platforms that run systemd.
Removing this bit would mean that the provider is only confined by the existence of the systemctl command. In most cases, this doesn't change puppet's behavior, since usually if systemd itself isn't functional, the command won't be on the system. However, there are consequences to this in the Debian family where all kinds of weird things can be done to rip out systemd to replace it with sysvinit.
For example, by following Debian's guide on using init over systemd in Jessie (https://www.debian.org/releases/jessie/amd64/release-notes/ch-information.en.html#systemd-upgrade-default-init-system), you'll end up with a system that uses sysvinit as its init system, but still has pieces of systemd left over even though it isn't functional. While the directory /run/systemd/system won't exist, the systemctl command will still be on the system.
This means that the systemd provider will be "suitable" on such a system, even though systemd cannot be used to manage services. The result of this is puppet displaying a bunch of services with the systemd provider which cannot actually be managed:
root@debian-8-jessie:~# puppet resource service --param provider
...
service { 'umountfs':
  ensure   => 'running',
  enable   => 'false',
  provider => 'debian',
}
...
service { 'syslog.service':
  ensure   => 'stopped',
  enable   => 'false',
  provider => 'systemd',
}
service { 'systemd-networkd.service':
  ensure   => 'stopped',
  enable   => 'false',
  provider => 'systemd',
}
service { 'umountnfs.service':
  ensure   => 'stopped',
  enable   => 'false',
  provider => 'systemd',
}
service { 'umountnfs.sh':
  ensure   => 'running',
  enable   => 'false',
  provider => 'debian',
}
...

The biggest issue comes when trying to manage a service which has both systemd and sysvinit bits, such as cron:
service { 'cron':
  ensure   => 'running',
  enable   => 'true',
  provider => 'debian',
}
service { 'cron.service':
  ensure   => 'stopped',
  enable   => 'false',
  provider => 'systemd',
}

If you try to do puppet resource service cron ensure=stopped', puppet will actually try to use the systemd provider to stop the service, which will fail. Thus, it becomes impossible to stop the cron service. With this confine still in place, puppet won't try to use the systemd provider at all. In addition, doing puppet resource service cron provider=systemdwill result inError: /Service[cron]: Provider systemd is not functional on this host` as it should, since systemd really isn't functional.
@melissa, do you remember if this was the specific reason for adding that confine in your original commit?

So another option that might work for everyone is to wrap this confine so it is Debian only?

@ianw ah, I can't think of a reason that wouldn't work. @branan what do you think of that idea?

This looks like a more general case where the Puppet run sets up the init system, and then wants to use the provider but it's already been excluded. There may be a more general solution to this problem.

This fix fixed the chroot functionality for non-debian systems, but let it be broken for debian systems.  In particular, during the installation of a Debian system, with a puppet version that includes the :confine, all systemd resources fail with an error, when with previous puppet versions they would exit without doing anything, because of the policy-rc.d file that states that the system isn't functional.

Note: The better check to make sure systemd is in use on Debian systems would be to check if /sbin/init links to /lib/systemd/systemd (if systemd is used, /sbin/init is such a symlink, even in chroots, at least on Debian)


chore: replace ko base image

the original base image is application/vnd.oci.image.manifest.v1+json replace to application/vnd.docker.distribution.manifest.v2+json
Changes

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Run make test lint before submitting a PR
[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide for more details.

暂不处理。

已内部沟通，先合并。


Work on rewards pipeline changes

Due to safety / correctness / complexity issues, we are adapting the rewards distribution pipeline for superfluid staking rewards to be correct / much simpler.

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #937 (da799de) into main (cd53acb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   20.55%   20.55%
=======================================
  Files         193      193
  Lines       25003    25003
=======================================
  Hits         5140     5140
  Misses      18926    18926
  Partials      937      937

Impacted Files
Coverage Δ

x/superfluid/keeper/epoch.go
66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd53acb...da799de. Read the comment docs.

Discussed IRL, seemed like we agree on for now doing what were currently doing. (Rewarding delegators for security already provided, rather security about to be provided)
Unsure if we agree on the same long term (I think the current is correct)


Add support for scoped packages

By changing the order of methods inside waterfall, ensure that module paths are picked from the dependency names(paths) given in package.json

😱 the diff is all over the place! Will checkout and review ASAP.


pull request for e2e test at 12/17/2016 09:56:20

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


truck-meshalgo depends on soon-to-be incompatible crate version

truck-meshalgo depends on vtkio 0.6 which in turn depends on nom v3.2.1 and quick-xml v0.22.0
Both of these dependencies are reported as future-incompatibilities
Updating to vtkio 0.7 will fix both deps

Yeah, we are aware of this. I hope vtkio will be updated, as there is no immediate solution we can take...


[BM-677] Decrease notification throttle

Task

JIRA

Description

Decrease notifications throttle time from 3 minutes to 15 seconds

          1 Message

:book:
:link: BM-677

JaCoCO Code Coverage 15.84% :white_check_mark:

Class
Covered
Meta
Status

co/netguru/baby/monitor/client/feature/babynotification/NotifyBabyEventUseCase
66%
0%
:white_check_mark:

APK file size

size

30.3MB

Number of method references

Dex file
count

classes.dex
46958

  Generated by :no_entry_sign: Danger


Pre commit

Hi
In this merge request I introduce the pre-commit package as a dev dependency and I also add a minimal configuration file .pre-commit-config.yaml for it.
To use the pre-commit package, run poetry install to install it (you might have to delete your poetry.lock file first) and then run pre-commit install once, for it to hook into gits pre-commit mechanism.
From then on, all pre-commit hooks are executed before a commit can be made, if any hook fails, the commit is aborted and you have to fix (or add the reformatted code in case of black) what is criticized by the hook.
To apply all hooks to the whole codebase at once, pre-commit run --all-files can be executed, which is the reason for the many code changes in this merge request, although only the pre-commit package and its config were added.
There are many more hooks available (https://pre-commit.com/hooks.html) but I only added a minimal useful selection of them:

black
This is an autoformatter which offers very little configuration options on purpose to settle any discussion about formatting instantly.
trailing-whitespace
All trailing whitespace characters are automatically removed
check-added-large-files
Prevents adding large files (>500kB by default) to the repository
mypy
Offers static type checking if type hints are introduced in the future. Although this is not very useful without type hints, it is also not in the way if they aren't used.

Although some pre-commit hooks and especially autoformatters are an acquired taste, they very much help with holding up a certain coding standard.

Thanks, appreciated. I like this additions a lot!
Because I've continued the development in the meantime, I've merged your additions manually in order to avoid a lot of merge conflicts.


Easier migration from rules_python pip_compile: test and update targets

The compile_pip_requirements macro in rules_python produces a [name]_test target to verify that requirements are up-to-date, and a runnable [name].update target to perform the update.
https://github.com/bazelbuild/rules_python/blob/fa13b0138924245c55f79922509e4688f252ff71/python/private/pypi/pip_compile.bzl#L46-L49
It's an extra burden for users migrating from that rule to account for the loss of these two targets when adding rules_uv.

I'm open to aliases that match the rules_python names.

Are you open to a breaking change where we just change [name]_diff_test to [name]_test to match rules_python? This variance seems accidental.
For updating, I suppose there's no harm allowing both bazel run [name] and bazel run [name].update - I went with the latter in rules_python due to the "custom verb" pattern as documented on https://bazel.build/rules/verbs-tutorial

I don't mind the test name change but would prefer an alias on the run target over a breaking change, as it'll cause a break on automation I have to go personally fix :)

fwiw, we intended the test to be called _diff_test in line with write_source_files' naming convention (it is, after all, a diff test)

I don't think that's how we named it either:
https://docs.aspect.build/rulesets/aspect_bazel_lib/docs/write_source_files

By default, a diff_test target ("{name}_test")


Feature/extended name parsing

Replace nodes_name function with a more generalized search_name function. Extended name search for NCBI and OTT and enable rank filter on name search.

Codecov Report

Merging #1 (4eb410c) into dev (5a474fa) will increase coverage by 0.12%.
The diff coverage is 98.77%.

@@            Coverage Diff             @@
##              dev       #1      +/-   ##
==========================================
+ Coverage   97.07%   97.19%   +0.12%
==========================================
  Files          15       15
  Lines        1059     1176     +117
==========================================
+ Hits         1028     1143     +115
- Misses         31       33       +2

Impacted Files
Coverage Δ

multitax/ncbitx.py
94.44% <96.15%> (+0.07%)
:arrow_up:

multitax/otttx.py
96.00% <97.61%> (+0.54%)
:arrow_up:

multitax/customtx.py
89.47% <100.00%> (ø)

multitax/greengenestx.py
94.28% <100.00%> (ø)

multitax/gtdbtx.py
91.42% <100.00%> (ø)

multitax/multitax.py
97.81% <100.00%> (+0.04%)
:arrow_up:

multitax/silvatx.py
94.44% <100.00%> (ø)

multitax/utils.py
92.40% <100.00%> (+0.19%)
:arrow_up:

tests/multitax/integration/test_common.py
100.00% <100.00%> (ø)

tests/multitax/unit/test_functions.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a474fa...4eb410c. Read the comment docs.


Convert that large gif into 5mb webm embed

From 28 to 5mb, also probably should just hyperlink all the files instead of having users download them with the project

If you edit the readme through github's web interface, you can just drag and drop videos/images so they dont need to be downloaded


Update native schema definitions from panther v1.16.0

Background
Schema updates from native Panther parsers.
Too many file changes due to better formatting of the export process. This should be stable in the future.
Changes

Some fields and description have changed after updates includet to panther v1.16.0

Testing

These schemas were already validated in panther repo code

I'll be frank, I don't understand these schemas particularly well so I will stamp just to not block.
They are automated export of the relevant Go structs in panther repo, so reviewing is done before they are committed there.

Can you update the CODEOWNERS file to add yourself and @kostaspap to it so that the data processing team can review & approve changes to schemas?

Sure


[2/x][lamport] Get rid of TransactionEffects::is_object_mutated_here

Spotted while working on lamport timestamps.  This function is only called in one place (AuthorityAggregator::get_object_info_execute) to check that a validator that object info is being read from isn't
Byzantine, but it is only used in Gateway, and benchmarks.  The former is going away soon, and the latter does not need to worry about byzantine validators.
Furthermore, the logic in this function for deleted and wrapped objects does not seem correct:  It asserts that an object is deleted in effects if it appears in the deleted effects at version - 1, but the logic in TemporaryStore::delete_object increments an object's version when it is deleted, so it should match.
Opting to remove the code to re-execute certificates instead of trying to make it work with lamport timestamps as there's a good chance it's not currently working and therefore needed.
Test Plan
$ cargo simtest
$ cargo nextest run

Stacked on #5748

@lxfind and I chatted about what is_object_mutated_here is being used for, and we think it may no longer be working correctly (and the code it's used in is also not long for this world).
Note that it's just the top commit that needs a review here, the rest are part of #5748.

Bringing forward the removal of is_object_mutated_here while I sort out the rest of lamport timestamps. @lxfind, could you take another look when you get a chance?


Change Theme Dynamically

Hey great job! Quick question, in my applications users are able to switch between dark and light, do you have an idea in how to implement this with this theme? Does it work out of the box?
Thanks!

Thanks for the feedback! @samuelcastro.
Yes the theme does switch between dark and light mode dynamically out of the box.

Thanks @stormynight9. I found some issues in the css, some borders are and details are not showing up. See images:

The account details page are actually good:


LAB 2, Knitting Error, Question 3 PT 2

I am currently trying to knit my rmd file but am receiving this error when doing so;

I believe this is an environment issue where "Commercial" is recognized in my current environment but not in the new, Knit environment.  I've tried a few things but still have not been able to successfully knit my lab. Does anyone know of any possible fixes? Thank you so much in advance

result <- downtown$yearbuilt >= 1980 & downtown$landuse == "Commercial"

n_commercial <- sum (commercial$yearbuilt <= 1980, na.rm=T)
# commercial buildings built during or after 1980

(n_commercial/nrow(downtown))* 100

I updated my first line to; result <- downtown$landuse == "commercial" & downtown$yearbuilt >= "1980"
and that did not fix the issue. I noticed throwing a "#" in front of the lines allows the knit to process but I do not think that's the right course of action here.

Please disregard, I realized a typo and variables were incorrect. Upon updating them my answer changed completely and the knit now runs.


Add new select aggregate methods

Closes #34

Still needs some specs around using aggregates with order, limit, and offset. Either make it work or at the very least raise a helpful error like is done with select_count


[android]fix stream res.ok is undefined when request has exception

CheckList:
if isBugFix :

[x] Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

[ ] Update API docs for the component.
[ ] Update/Add demo to demonstrate new feature.
[ ] Update test scripts for the feature.
[ ] Add unit tests for the feature.

hi @marekchen  you can rebase your branch on master branch in apache repository to update your pull request resolving conflicts here


C6326: undesired warning when the comparison depends on a template parameter

Consider the following example, taken from boost\random\linear_conguential.hpp:
template<class IntType, IntType a, IntType c, IntType m>
class linear_congruential_engine
{
static const IntType modulus = m;
/**
* If c mod m is zero and x0 mod m is zero, changes the current value of
* the generator to 1. Otherwise, changes it to x0 mod m. If c is zero,
* distinct seeds in the range [1,m) will leave the generator in distinct
* states. If c is not zero, the range is [0,m).
*/
void seed(const IntType&  x0_)
{
if(modulus == 0) {
_x = x0;
} else {
_x = x0 % modulus;
}
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 735f8012-a55e-0ec9-ccd8-c1393499d8aa
Version Independent ID: caa4822b-a7cd-e807-94c1-b9c9b097696f
Content: C6326 - Visual Studio
Content Source: docs/code-quality/c6326.md
Product: visual-studio-dev15
GitHub Login: @mikeblome
Microsoft Alias: mblome

investigating

@MaartenHilferink  Thanks for the feedback! Since PREfast is a local code analysis tool, it has a very limited capability to trace assignments outside of the current function under analysis. In this case we cannot know that the variable depends on the template parameter. This warning should not reproduce if the actual parameter is used in place of the const variable: if(m == 0) {  …


Avoid listing table data for destination of CREATE VIEW DDL queries.

CREATE VIEW DDL queries set a "destination table" field, but that table
is actually a view. If you attempt to list rows on the view table, it
results in an error.
The fix is to avoid listing rows altogether if getQueryResults() says
that a query has completed but the number of rows in the result set is
undefined.

Looks like I need to update a couple unit tests.

Unit tests are now passing. Ready for review!


box2d: disable physics and simulation rate blocks

Resolves #1171
Might resolve #925?
Adds 3 new blocks to the Box2D Physics extension:

Disables physics for the sprite.

Sets (or gets) the simulation rate; for example, you can set it and the project's framerate to 60 to make the physics run at 60FPS.

go to prettier.io/playground and use it on your code.
this will fix the format issue

go to prettier.io/playground and use it on your code.
this will fix the format issue

or just npm run format

oh yea

Lily approved the changes, nice!
Now let's wait for her to merge it :)


Missing "linear" label breaks GitHub to Linear sync

I set up a sync between Linear and Github through synclinear.com (readysettech/readyset <-> private Linear team). I see that syncs from Linear to Github are occurring just fine but not in the reverse direction.  I redeployed it once to see if it fixes things, but that did not help. Before I turn to self-hosting and debugging it, I wondered if you have suggestions on what I might look at.
Here is an example of an issue, where the sync from Github to Linear appears to be broken:
https://github.com/readysettech/readyset/issues/61

Same problem here. I had to manually create the linear label on GitHub, as it wasn't created automatically. Adding it doesn't seem to do anything. Here's an example issue that failed to sync with Linear.

I also had this issue. I added the linear label on github but it took a while to sync (at least a few minutes, maybe longer). Also the assignee on github did not get synced to linear.

Hey @gvsg-rs - sorry for the very late reply. Did you end up self-hosting successfully? If not, there seem to be a few issues related to this - working on a fix now. Thanks either way.

Closed by 3bca3146f4686afb79f0dc1ba04901f3eadbfc18

The issue is not fixed unfortunately. The sync works in some repositories, but not in others.
And the sync from Github to linear worked without the use of the "linear" label on the repositories where it works okay. I retried with and without the use of the new linear label. I reinstalled the sync relationship on synclinear.com as well.
Where it works, the title of the issue gets re-written with the issue on Linear. Like so:

Hey @gvsg-rs - sorry for the very late reply. Did you end up self-hosting successfully? If not, there seem to be a few issues related to this - working on a fix now. Thanks either way.

I did not unfortunately. I have not had an opportunity to debug this.

Deleting the webhook on Github, and then redeploying the webhooks again from synclinear.com did the trick for me and things are now working just fine.


Sync with master

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.14 out of 15 committers have signed the CLA.:white_check_mark: MaryamZi:white_check_mark: grainier:white_check_mark: nadundesilva:white_check_mark: warunalakshitha:white_check_mark: hasithaa:white_check_mark: madushajg:white_check_mark: Ibaqu:white_check_mark: ThisaruGuruge:white_check_mark: xlight05:white_check_mark: SupunS:white_check_mark: pubudu91:white_check_mark: gimantha:white_check_mark: rdhananjaya:white_check_mark: lochana-chathura:x: anupama-pathirageYou have signed the CLA already but the status is still pending? Let us recheck it.


docs: add link to new @labshare/services-build-cli plugin SHELL-1587

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ROCm doesn't detect GPU.

My laptop: ASUS TUF Gaming FX505DY-BQ024T.
I'm trying to set it up so that I can do mild training and running of TF models for my projects.
There's an internal Vega graphics as well as dedicated RX 560X 4GB.
I can't get the ROCm to detect my GPU using rocminfo or clinfo. Both int gpu and dedicated are detected in rocm-smi. What do I do?
rocminfo shows the resource exhausted problem. clinfo shows the number of devices as 0.
I'm using Ubuntu 20.04.1.
Should I change my ubuntu version or something?

Hi @JoseVSeb,
can you please share the output of the rocminfo or clinfo log?

@rkothako , output of rocminfo and clinfo (I've been trying to fix it for sometime now. this is not the first output that i got):

jvs@JVSTUF:~$ rocminfo
ROCk module is loaded
Unable to open /dev/kfd read-write: Bad address
jvs is member of render group
hsa api call failure at: /src/rocminfo/rocminfo.cc:1142
Call returned HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate the necessary resources. This error may also occur when the core runtime library needs to spawn threads or create internal OS-specific events.
jvs@JVSTUF:~$ clinfo
dlerror: /opt/rocm-3.1.0/opencl/lib/x86_64/libamdocl64.so: cannot open shared object file: No such file or directory
Number of platforms:				 1
Platform Profile:				 FULL_PROFILE
Platform Version:				 OpenCL 2.0 AMD-APP (3182.0)
Platform Name:				 AMD Accelerated Parallel Processing
Platform Vendor:				 Advanced Micro Devices, Inc.
Platform Extensions:				 cl_khr_icd cl_amd_event_callback
Platform Name:				 AMD Accelerated Parallel Processing
Number of devices:				 0

Looks like installation is not proper.
/opt/rocm-3.1.0/opencl/lib/x86_64/libamdocl64.so: cannot open shared object file: No such file or directory
Can you please correct installation problem?

Looks like installation is not proper.
/opt/rocm-3.1.0/opencl/lib/x86_64/libamdocl64.so: cannot open shared object file: No such file or directory
Are you trying to install ROCm 3.1? If yes, its very old.
Ubuntu 20.04 support is officially enabled from the latest ROCm release: 3.7

that doesn't matter, it's leftover from another try. The installed version is 3.7 itself

I think my issue is very similar to this: https://github.com/RadeonOpenCompute/ROCm/issues/1205
I have a similar setup. Laptop with AMD CPU, internal Vega 8 GPU and dedicated AMD Radeon GPU.

I am experiencing almost the same issue on a Mac Pro 5,1 using ubuntu 20.04.1 LTS.
At first I tried installing rocm exactly using the instructions given on the amd website and everything installed properly. rocm-smi is detecting my gpu (RX580 8GB) and showing me VRAM usage and so on but rocminfo only detects my CPU as the only HSA agent.
I first experienced this issue with kernel 5.4.0-42-generic and then I read on the amd website that only kernel 5.3 was supported so I downgraded to kernel 5.3.0-050300-generic and retried the entire install and ended up with exactly the same result.
(rocminfo, clinfo and rocm-smi outputs attached)
clinfo.txt
rocminfo.txt
rocm-smi.txt

Please, I need a solution. I'm here for using tensorflow with enough juice from my lap gpu. I can't (and don't know how to) fix the problems that arise in the installation of this software. I've tried everything that i could from my limited knowledge of how linux works and what i could find by scouring the issues. but nothing gives any direct indication to my problem. please help

Someone please say something!!! How can I get past this? Should I try an older ubuntu (currently using 20.04)? Should I try installing some other driver like amdgpu-pro before installing this (I tried once and it only introducing clash between the two)? Please, I've been stuck here for a month now. I need a way forward.

@data-stepper PCIe 3.0 atomics are required for using rocm with polaris graphics cards like your RX580 8GB. Your machine does not have these.

@JoseVSeb can you post the full output of sudo lspci -vvv  and lspci -tv? This will let me see if pcie 3.0 atomics are supported on your machine.

@ksteimel BTW. It looks like this machine is using AMD Ryzen 5-3550H. It is Zen+ based. So it should support PCIe Gen3 + PCIe Atomics.

#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;} Yes it should but every stage between the cpu and the gpu needs to support it. The motherboard could lack support for pcie v3 atomics even if every other part of the pipline does.                                                                                From<EMAIL_ADDRESS>October 5, 2020 2:37 PMTo<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>[External] Re: [RadeonOpenCompute/ROCm] ROCm doesn't detect GPU. (#1204)  This message was sent from a non-IU address. Please exercise caution when clicking links or opening attachments from external sources.
@ksteimel BTW. It looks like this machine is using AMD Ryzen 5-3550H. It is Zen+ based. So it should support PCIe Gen3 + PCIe Atomics.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

@ksteimel Fair enough, it might be something with BIOS, or who knows. Best to check lspci as you suggested.

Hi @JoseVSeb
Is the issue still observed?
Can you please check with the latest ROCm 3.10 and update the status.
Thank you.

Hi @JoseVSeb
Are you able to overcome this issue?
Can you try with the latest ROCm 4.0 and share an update asap?
I am not able to reproduce with the latest ROCm 4.0 + Ubuntu 20.04.1 + Vega64

Hi @JoseVSeb
Are you able to overcome this issue?
Can you try with the latest ROCm 4.0 and share an update asap?
I am not able to reproduce with the latest ROCm 4.0 + Ubuntu 20.04.1 + Vega64

No update for the last 3 to 4 weeks.
Hope issue is resolved.
Request t file a new issue, if any, we will handle with more speed.
Thank you.

No update for the last 3 to 4 weeks.
Hope issue is resolved.
Request t file a new issue, if any, we will handle with more speed.
Thank you.


OpenAI v1 Chat Completions API

Closes #145.
Usage:
Python:
from openai import OpenAI

openai_api_key = "EMPTY"
openai_api_base = "http://<IP_ADDRESS>:8080/v1"
client = OpenAI(
    api_key=openai_api_key,
    base_url=openai_api_base,
)

resp = client.chat.completions.create(
    model="",
    messages=[
        {
            "role": "system",
            "content": "You are a friendly chatbot who always responds in the style of a pirate",
        },
        {"role": "user", "content": "How many helicopters can a human eat in one sitting?"},
    ],
    max_tokens=100,
)
print(resp)

Streaming:
messages = client.chat.completions.create(
    model="",
    messages=[
        {
            "role": "system",
            "content": "You are a friendly chatbot who always responds in the style of a pirate",
        },
        {"role": "user", "content": "How many helicopters can a human eat in one sitting?"},
    ],
    max_tokens=100,
    stream=True,
)

for message in messages:
    print(message)

REST:
curl http://<IP_ADDRESS>:8080/v1/chat/completions \
-H "Content-Type: application/json" \
-d '{
  "model": "",
  "messages": [
  {
      "role": "system",
      "content": "You are a friendly chatbot who always responds in the style of a pirate"
  },
  {
      "role": "user",
      "content": "How many helicopters can a human eat in one sitting?"
  }
  ],
  "max_tokens": 100
}'

Finally, if the LoRA adapter has its own tokenizer and chat template, that will be used instead of the base model chat template:
resp = client.chat.completions.create(
    model="alignment-handbook/zephyr-7b-dpo-lora",
    messages=[
        {
            "role": "system",
            "content": "You are a friendly chatbot who always responds in the style of a pirate",
        },
        {"role": "user", "content": "How many helicopters can a human eat in one sitting?"},
    ],
    max_tokens=100,
)
print("Response:", resp[0].choices[0].text)

hi @tgaddair does it work for local adapter?
With original endpoint, I can add {adapter_source: "local"} to load adapter from local directory.
How can I do it via OpenAI  API?


initial commit for RT2.10

Initial commit for RT2.10
It resolves https://github.com/openconfig/featureprofiles/issues/1619

Pull Request Functional Test Report for #1847 / 023debe56bc80e08eec85ac773abd32acb5c583f
No tests identified for validation.
Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1341

Relevant Lines:
2824

💛  - Coveralls

/gcbrun

@wenovus can provide direction to resolving the OC path static analysis failure


fzf: 0.30.0 -> 0.31.0

Description of changes

Things done

Built on platform(s)

[x ] x86_64-linux

Changelog
https://github.com/junegunn/fzf/releases/tag/0.31.0

Duplicate of #182343.


Image Save node - Missing outputs in API

Hi
Very quick non-urgent issue I have come across today.
When using the save image node with show_previews: false there is no entry for output images in the /history endpoint
Naturally the fix is to enable previews, but something to consider if you get the time.
Cheers!
Rob

Yeah that probably doubles as both. Since if there is output, the node shows a preview. So can't have both.


"Class invalid" not always showing

Hi. Addon v0.0.9. I'm playing mage.
Mail armor item, which source and model are not collected, has "Class invalid". It is fine. https://www.wowhead.com/cata/item=55279/manacles-of-pain
But mace item, which source and model are collected, hasn't "Class invalid". Why so? Mages can't use maces. https://www.wowhead.com/cata/item=55777/torturers-mercy

Hello, there is a discussion in another issue thread where there was a suggestion to make the format more compact.
I have given it a bit of thought and made it the following (see message in the thread).
In short - if the model is collected - there is no reason to worry about it as you already got it. If it is not collected and the class is ineligible - it will display in red.
Let me know if this has become more confusing than before, I will try to think of other options

Thanks. But now error appear - https://github.com/DelaneDiamon/Transmog-Checker/issues/11


Simplify finding Osmium with dependencies (CMake)

After adding advanced FindOsmium to osmium-contrib, I noticed that it can also be included to main libosmium distribution. This will allow users to simply take FindOsmium.cmake from it sources and also make build scripts easier to maintain.
@joto Could you have a look? (and check on Linux)
https://github.com/alex85k/libosmium/commit/39f1d20be33cd9cf26f10f846afeefc269dec90a

@alex85k: not sure this is still relevant after all the recent cmake config changes. Can we close this?

@joto: Oh, I forgot about it and have too little time now...
This can be closed, if new compilation issues will arise, I'll create new tickets.


Lepiter pages should be cached by title, and it should be possible to search for words in arbitrary order


runserver_plus reloads on changes in pycache

It stands to reason that any changes in pycache would be coming from changes in the code which would already be detected. Hence pycache should be ignored for restarting runserver_plus.

Makes sense :-)


The function create_function has been DEPRECATED in PHP 8

Hi Pierre;
The Function create_function has been DEPRECATED in PHP8 and encoded programs will not run in a new server.
(PHP 4 >= 4.0.1, PHP 5, PHP 7)

Warning: This function has been DEPRECATED as of PHP 7.2.0, and REMOVED as of PHP 8.0.0. Relying on this function is highly discouraged. https://www.php.net/manual/en/function.create-function.php

$__________________ = 'Q1JFQXRlX2Z1bkNUaU9u';
$__________________ = $__($__________________);
// print $__________________."\n";
// $__________________ = "create_function";

Trace
[max@workstation Obfuscator-Class]$ php 2-input.php
CREAte_funCTiOn
PHP Fatal error:  Uncaught Error: Call to undefined function CREAte_funCTiOn() in /project/Obfuscator-Class/2-input.php:18
Stack trace:
#0 {main}
  thrown in /project/Obfuscator-Class/2-input.php on line 18

[max@workstation Obfuscator-Class]$ php 2-input.php
PHP Fatal error:  Uncaught Error: Call to undefined function create_function() in /project/Obfuscator-Class/2-input.php:21
Stack trace:
#0 {main}
  thrown in /project/Obfuscator-Class/2-input.php on line 21

What I find is obscured code want to use CREAte_funCTiOn function somethings is probably create_function. But this is not available in server.
$ php -v
PHP 8.0.5 (cli) (built: Apr 27 2021 18:07:13) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.5, Copyright (c) Zend Technologies

I'm not sure it's solved before or a trick and solution to solve this. Anyway I submit this since I see encoded programs cannot run anymore.
Best;

Try this:
if (!function_exists("create_function)) {
function __create_function($arg, $body) {
static $cache = array();
static $maxCacheSize = 64;

static $sorter;

if ($sorter === NULL) {
    $sorter = function($a, $b) {
        if ($a->hits == $b->hits) {
            return 0;
        }

        return ($a->hits < $b->hits) ? 1 : -1;
    };
}

$crc = crc32($arg . "\\x00" . $body);

if (isset($cache[$crc])) {
    ++$cache[$crc][1];
    return $cache[$crc][0];
}

if (sizeof($cache) >= $maxCacheSize) {
    uasort($cache, $sorter);
    array_pop($cache);
}

$cache[$crc] = array($cb = eval('return function('.$arg.'){'.$body.'};'), 0);
return $cb; } }


is the default gcTime of 5 minutes too long?

With @convex-dev/react-query the default gcTime of 5 minutes [edit: maybe] isn't appropriate because it means continuing to receive updates for a query for 5 minutes. This could be a problem especially if e.g. subscribing to a new query on keystroke, but even in normal cases it's too much.

Maybe two solutions are needed:

change the default: convexQuery() should use a gcTime of 30 seconds?
limit how many subscriptions to retain? We've talked about doing this per hook, when the arguments of a useQuery() hook change that should immediately invalidate the old one.

The argument in the other direction is generally TanStack Query has more aggressive defaults (like refreshing every query when the tab becomes active again) and once you start to tweak for performance and costs you dial these down, so something aggressive is nice. And that this way global changes to the default gcTime will be reflected in queries https://tanstack.com/query/latest/docs/framework/react/guides/important-defaults#:~:text=By%20default%2C%20"inactive"%20queries,1000%20*%2060%20*%205%20milliseconds.

I think a decent stop gap is to update the document with a Defaults section that describes the use case and let the user think about changing the gcTime! What "cache" actually means etc.

Here's where that might go, plus the README here https://docs.convex.dev/client/tanstack-query#differences-from-using-fetch-with-tanstack-query


Scrollbar appears incorrectly when auto resizing textfield

In the image you can see the scrollbar appear then disappear on resize
ScrollBarCrash.zip

This no longer appears to be issue.


What language do you want to use?

What language do you want to use? And what's a good POC to start with?

Golang and Angular2 (4?).
A good POC could be a few things.  I'll start a design doc and we can evolve it from there.


Fix na n problem

Issue Number
#17
Description of all changes
Sometimes the dtype of OpenML datasets is wrong, which leads to an exception when trying to calculate the standard deviation with numpy. I added a type check and type conversion before the standardization of the data.
All tests pass and the conversion fixes the exceptions for me. Closes #17
Checks
Ensure the following tasks have been completed

[ ] make install-dev
[ ] pip-sync requirements-dev.txt
[ ] make build
[ ] make format
[ ] make coverage
[ ] Confirmed auto merge is valid or will solve all merge conflicts
[x] Wrote Documentation, Docstrings, comments and tests.
[x] Put closes #XXXX in your comment to auto-close issues or added the issues to the PR.

(I am on Windows, so I don't have make. I ran all tests with Python 3.11 and they all pass. Realistically, the change is very small, so I hope that's fine for you)
Thanks for contributing 🎉!

Thanks for contributing! Really appreciate it!


Moving api to v1

As we are approaching v1.0.0 we should think about moving the camel-k API out of alpha/beta and move to v1
//cc @nicolaferraro @astefanutti

Totally makes sense.

We can set versions like this:
  versions:
    - name: v1alpha1
      served: true
      storage: false
    - name: v1
      served: true
      storage: true

It means that we store resources in version v1 but also clients using v1alpha1 will still continue to work (e.g. Knative Camel Sources and others).
This change assumes that there are no changes between v1alpha1 and v1. The alternative is to adding mutating webhooks, which complicates too much the deployment.
Since we're moving from alpha to stable, I'd do minor changes without caring about conversion (mentioning possible minor changes in release notes).
I'd migrate all APIs to v1 because Integration and IntegrationPlatform are pretty stable and all the others are internal APIs and people should not care a lot about their stability.
I'd do all changes after other big PRs are merged.. doing some tests now.

cc: @lburgazzoli , @astefanutti

Sounds like a perfect plan to me 👍


Request to TEST environment using TEST access token fails if production option is set to false

If i create the client object with TEST access token and production option set to false then request to any api endpoint fails with the status code 401 with error 'The access token you have used is not a valid API access token'. See below how the client object is initiated. and the subsequent error message
DuffelApiClient client = new DuffelApiClient("duffel_test_*******************************************", production: false);
Requesting offers
Failed with status: 401, request Id: FvK_lY1J3sT3G5cAAPwC
The access token you have used is not a valid API access token

But if i create the client object with TEST access token but change the production option to true then the code works against any api endpoints on TEST environment and executes all my requests successfully.
DuffelApiClient client = new DuffelApiClient("duffel_test_*******************************************", production: true);
So the option for production actually stops the api calls to TEST environment if set to false, which I presume is required for TEST environment calls.

Thank you for raising the issue, and sorry for the slow response time. I can reproduce and should shortly have a fix.