CLI doesn't display ALWAYS errors durning build/serve process

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.
@angular/cli: 1.0.0
node: 7.7.2
os: win32 x64
@angular/common: 4.0.1
@angular/compiler: 4.0.1
@angular/core: 4.0.1
@angular/forms: 4.0.1
@angular/http: 4.0.1
@angular/platform-browser: 4.0.1
@angular/platform-browser-dynamic: 4.0.1
@angular/router: 4.0.1
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.1

I want to import correctly my rxjs operator and instead importing whole "rxjs" lib I do import {Observable} from 'rxjs/Observable'; the problem is sometimes cli temm me in the console that this or this operator doesn't exist and break the build process but somes times cli doesn't tell me errors even if I don't import it explicitly.
So my follow code break only when running on browser after "ng b --prod"
Here iy my imports:
import {DataEventModification, DataEventType, SharedService} from '../shared.service';
import {ElementRef, EventEmitter, HostListener, OnDestroy, OnInit, Output} from '@angular/core';
import {TSABEntityType} from './lockable-form/form-locker.service';
import {FormGroup} from '@angular/forms';
import {Observable} from 'rxjs/Observable';
import {Subscription} from 'rxjs/Subscription';
import {DialogService} from '../dialog/dialog.service';

my code is something like :
if( this.formFilters) {
      this.formFiltersSubscriber = this.formFilters.valueChanges
        .debounceTime(this.filterDebounceTime)
        .skip(1)
        .subscribe(data => {
          this.filters = Object.assign(this.filters, data);

          for(let index in this.filters)
            if( this.filters[index] == "" || this.filters[index] == null)
              delete this.filters[index];

          this.saveTableState();

          this.reloadServerData(this.filters);
        });

      this.formFilters.reset();
      this.formFilters.patchValue(this.filters);
    }

skip is available an debounceTime too for webstorm and my angular-cli sucess compiling well using AoT!!  without errors BUT when I run app on browser I get this error : TypeError: this.formFilters.valueChanges.debounceTime(...).skip is not a function
All I need is import manually these two things :
import "rxjs/add/operator/skip"; import "rxjs/add/operator/debounceTime";
The problem is not about import manually the problem is it only break on browser with AoT, this is strange, and I need build using --prod flag it take a while then run this build on browser and I can get this error only at this moment.
I admit with this kind of code :
return dialogRef.afterClosed().flatMap(res => {
        switch (res ) {
          case 'cancel':
            return Observable.of(false);
          case 'continue':

            if( !comp.isDataValid())
              return Observable.of(false);

            return comp.getFormLocker().applyModifications(false, true).map(() => {
              return true;
            }).catch(()=> {
              return Observable.of(false)
            });

          case 'unlockAndContinue':
            comp.getFormLocker().abortModifications(true);
            return Observable.of(true);
        }
      }).first();

when I compile ng serve or ng build, cli tell me this great error ERROR in C:/Users/.../src/app/can-deactivate-entity.guard.ts (51,10): Property 'first' does not exist on type 'Observable<{}>'. but not on code above
Is this bug ?

RxJS imports have 2 side effects:

add the types to the global type system. This means you'll see it in WebStorm and it will not error when doing type checking, and
add the function at the time of import to the prototype.

The problem you see is there is a file that import the skip operator, but that file is not loaded by your browser.
This is a global problem with TypeScript global type declarations and something recurring with the pattern RxJS uses to declare operators. We suggest you put all your operators in polyfills.ts to fix it, or you always import it everywhere you actually use it.
Long story short, importing an rxjs/add/operator/... anywhere will add the operator to the RxJS types, but it might not be available in the files you're using it.

I did what you said (all operators in polyfills.ts) and I don't understand why rxjs is imported in pollyfill and vendor bundle, any hits ?
see screenshot


feat(image-with-caption): support responsive image

Related Ticket(s)
Refs #4300.
Description
Adds support for <dds-image-item> as child elements of <dds-image-with-caption>. To do that, adds support for <slot> as the child element of <dds-image>.
The story of <dds-image-with-caption> is updated to demonsrate this new feature.
Changelog
New

Support for <dds-image-item> as child elements of <dds-image-with-caption>.

Yes.  Thank you for this.


Test WRDS v3.0

Since WRDS is updating to version 3.0 to keep parity with the NWM, we need to test to make sure that the gage metadata and ratings don't have any schema changes.

Use tools/rating_curve_get_usgs_curves.py to pull a new set of gage data and check the outputs to make sure there's no glaring issues.

A work in progress branch exists (dev-usgs-gages-new-wrds) which updates the tools/rating_curve_get_usgs_curves.py script. There were some API errors which are addressed, but might not have been fully resolved.  The last test fails at the call to get_thresholds() in rating_curve_get_usgs_curves.py:
['385433114063901']
Populating..
Attributing mainstems sites
Recasting...
WRDS response error:
Traceback (most recent call last):
  File "/foss_fim/tools/rating_curve_get_usgs_curves.py", line 459, in <module>
    usgs_rating_to_elev(list_of_gage_sites=list_of_gage_sites, workspace=workspace, sleep_time=sleep_timer)
  File "/foss_fim/tools/rating_curve_get_usgs_curves.py", line 415, in usgs_rating_to_elev
    write_categorical_flow_files(metadata_list, workspace)
  File "/foss_fim/tools/rating_curve_get_usgs_curves.py", line 144, in write_categorical_flow_files
    stages, flows = get_thresholds(threshold_url, select_by='nws_lid', selector=nws_lid, threshold='all')
TypeError: cannot unpack non-iterable NoneType object

Notes:
As the WRDS API is internal to the NWC, it is recommended to run and test this script from a NWC environment (dev1).
Additionally, if it is not obvious, to get started, copy the appropriate .env in to the /tools directory before executing the /rating_curve_get_usgs_curves.py script.

@CarsonPruitt-NOAA @EmilyDeardorff @RyanSpies-NOAA
I updated the wrds tool to get gages data also for Alaska, and the results look reasonable. There are 111 USGS gages in Alaska from which 23 are "acceptable" with their SRC info available in "usgs_rating_curves.csv" file. Below shows acceptable gages:

Is there any specific check we need to do for confirming the veracity of these Alaska gages?

How does this interact with the FIM product?  It doesn't look like it is called as any part of FIM-pipeline. Does it update some input files for fim_pipeline?  Does it run live against post processing? Does it need to run for pre-clips?  Benchmark data? Please update here or better yet, the PR so we know we can start sorting out deployment plans. I usually need a number of lead days prior to merge if it affects inputs or pre-clips.

This change will affect the usgs_gages.gpkg, which I don't believe is involved in pre-clipping. Here is where the file is copied over into the temp HUC directory.

ok perfect. So we just download it and drop it in the right place in the inputs directory. Oh ya. now I remember Ali showing that to me. Just need to figure out what the acquire and pre-process looks like.  Ali might already have this down so we can just copy it around. Do I have this correct?

And just to confirm, there is no on-going live interaction with WRDS. Just pull down some new data, put it in inputs and we are ready to go.

Deployment Plan:

rename current usgs_rating_curves.csv to something like "usgs_rating_curves_bk_20240422.csv".
replace current usgs_rating_curves.csv with new edition.
do the same for the usgs_gages.gpkg and catfim_flows.cms.csv.
Add 4 other files created by tool and place beside the three files mentioned above.

sites_bool_flags.gpkg
acceptable_sites_pre.csv
acceptable_sites_for_rating_curves.gpkg
acceptable_sites_for_rating_curves.csv

ensure it is copied to all 6 enviros.


UnknownVideoError :  This live event has ended.

Describe the bug
Can't download a video from a past live event.
To Reproduce
Steps to reproduce the behavior:
from pytubefix import YouTube
from pytubefix.cli import on_progress

url = "https://youtu.be/qyltRTowCBY"

yt = YouTube(url)
print(yt.title)

ys = yt.streams.get_audio_only()
ys.download(mp3=True) # pass the parameter mp3=True to save in .mp3

Expected behavior
Download the video
Desktop (please complete the following information):

OS: Windows 10
Python Version 3.11
Pytubefix Version pytubefix-6.8.1

no error appeared?

After the live ends, it does not become available to download immediately, but only after a few hours or, in rare cases, after a few days.

I just used the same code and it worked perfectly, it downloaded completely

Thanks for the help.
For future reference, this particular event had ended a little more than 24 hours before my last attempt and a little more than 26 hours before @JuanBindez successfully downloaded the stream.

The error was:
Jam Oviedo 2.0 31-7-2024 Javi Queen
Unknown Video Error
Video ID: qyltRTowCBY
Status: OK
Reason: This live event has ended.
Developer Message: Unknown video status
Please open an issue at https://github.com/JuanBindez/pytubefix/issues and provide the above log output.
Traceback (most recent call last):
File "C:\Users\jalvarezferr\yt.py", line 9, in
ys = yt.streams.get_audio_only()
^^^^^^^^^^
File "C:\Users\jalvarezferr\AppData\Local\Programs\Python\Python311\Lib\site-packages\pytubefix_main_.py", line 552, in streams
self.check_availability()
File "C:\Users\jalvarezferr\AppData\Local\Programs\Python\Python311\Lib\site-packages\pytubefix_main_.py", line 336, in check_availability
raise exceptions.UnknownVideoError(video_id=self.video_id, status=status, reason=reason, developer_message=f'Unknown video status')
pytubefix.exceptions.UnknownVideoError: ←[91mqyltRTowCBY has an unknown error, check logs for more info←[0m


Add support for the language 'goLang'

On every request having language parameter as go, spawn a docker container of this language, execute the code and destroy that docker container. Read the documentation of the library dockerode if required.

Hi, kindly assign this issue to me.

@Garg-Doppler You can work on this issue.

@Sickaada I would like to contribute towards this issue. Can you assign me ?

@AbhishekJadhav2002 Please go ahead!


More fixes of insufficient atomics, and make most of the test suite runnable under miri

Hi there, here are some more bugs similar to these of #30.
Additionally, I added some cfg(miri)s to make the test suite run under miri in a reasonable time.
The reason I am doing all of this is that I noticed that this crate is incompatible with Tree Borrows (TB), a new aliasing model for Rust and a potential replacement of Stacked Borrows. While TB was designed to be more lenient than SB, it also gets rid of some dirty hacks, and these unfortunately were relied on this crate (along with a few others which I am doing my best to fix now).
Or, to be more precise: They break rarena-allocator, which is a dependency of this crate, but the breakage only shows up in the tests in this crate. Fortunately, that crate is another crate of yours.
Unfortunately, while I have fixed the TB errors there, the last published version of rarena-allocator is quite different from the development HEAD (and the version depended on by skl), so I am not sure how to best contribute them. Advice on how to proceed is appreciated, if you have any questions about Tree Borrows or why these changes are necessary, feel free to ask.

Hi, thank you so much!
Regarding the rarena-allocator, the upcoming skl version 0.14.0 (#29) will be based on the changes introduced in the rarena-allocator's pull request (https://github.com/al8n/rarena/pull/8). Therefore, I would like to suggest fix any miri bugs based on https://github.com/al8n/rarena/pull/8.

Wow, that's a lot of change. I'll aim my changes on top of these branches.

I just cleaned up TB errors in rarena-allocator and publish the new version of rarena-allocator. I also ddded CI jobs to test TB in #29, and found more TB errors in this project which not related to rarena-allocator,  https://github.com/al8n/skl/actions/runs/10621035558/job/29442139071

Nice. I think the error looks familiar, but of course it might just be a different thing at a similar place. I'll have a look at it after the weekend tho. Thanks for getting things published :)

Nice. I think the error looks familiar, but of course it might just be a different thing at a similar place. I'll have a look at it after the weekend tho. Thanks for getting things published :)

Thanks!

I am merging this PR and will create a new issue for tree borrow stuff.


drag and drop not working in Firefox browser

drag and drop not working in Firefox browser #1
Any Solution for this issue?

drag and drop not working in Firefox browser #1
Any Solution for this issue?

Code is using event.path which is not a standard. Use instead event.composedPath().
Replace all event.path with event.composedPath() in the file located in:
/react-form-creator/dist/index.js with the one attached here


JavaScript output is disabled in JupyterLab

after successful install of the extension I still get "JavaScript output is disabled in JupyterLab"

@chanansh This means the extension is not installed. A common situation I have seen happen to users many, many times is that they install something in one conda/venv but the jupyter they run is actually in a different conda/venv.


bug or docs issue: filters are always invoked for object inputs (regardless of identity or value equality)

https://plnkr.co/edit/d0J4zqlTZvrsSJvywM0y?p=preview
for primitive inputs, the filter is invoked only if the value changes
docs:

The filter function should be a pure function, which means that it should be stateless and idempotent. Angular relies on these properties and executes the filter only when the inputs to the function change.

so is the behavior for objects a feature or a bug?

This is expected behavior, as it's too expensive to keep a copy of an object around to determine if the object changed, see https://github.com/angular/angular.js/blob/eebbca0a8bdc47e0d4f4d59d6981b912d6605ccc/src/ng/parse.js#L1991-L2004
Do you want to submit a PR that updates the docs about this?


Updated pd.date_range-API in plot_sunpath_diagrams.py

freq='H' is depricated.
the parameter 'closed' was changed to 'inclusive'

[ ] Closes #xxxx
[ ] I am familiar with the contributing guidelines
[ ] Tests added
[ ] Updates entries in docs/sphinx/source/reference for API changes.
[ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[ ] Pull request is nearly complete and ready for detailed review.
[ ] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Right now our docs build uses python 3.7 (see https://github.com/pvlib/pvlib-python/blob/main/readthedocs.yml), which I'm guessing means it's also using an older pandas that doesn't support inclusive.  I'm in favor of upgrading our docs build configuration to a more modern environment.  @PhilBrk8 would you be up for trying that out in this PR?

Right now our docs build uses python 3.7 (see https://github.com/pvlib/pvlib-python/blob/main/readthedocs.yml), which I'm guessing means it's also using an older pandas that doesn't support inclusive. I'm in favor of upgrading our docs build configuration to a more modern environment. @PhilBrk8 would you be up for trying that out in this PR?

Hi there,
sorry - life got in the way a bit...
I'm currently doing the Solar Energy Engineering Program of the TU Delft on edx.org and i'm in the last of 4 courses.
I set my self the goal to transfer the content and calculations into code in order to review and solidify my learnings.
To go even further and incorporate useful parts into the library while bringing it up to a more modern environment might be a great opportunity to advance my python skills to the next level and polish up my github profile in the meantime as well.
@kandersolar Would you also be in favor of this?

@kandersolar Would you also be in favor of this?

Hard to say without hearing some specifics, but in general we enthusiastically welcome contributions!  Please open an issue describing any improvements you'd like to discuss :)

Closing this PR as it is now redundant after #2029.  Thanks @PhilBrk8, and hopefully we see more PRs from you in the future :)


Add "Get" /product API endpoint

Description
To support the use case of the AG Ministry and other end users utilizing the registry app's API endpoints, we want to add a new endpoint to retrieve information for a single product.
Technical Details

In addition to the existing LIST endpoint, introduce a GET /api/v1/private-cloud/products/<id or licenceplate> endpoint.
Include the user email attribute in both the LIST and GET endpoints.

Definition of Done (DOD)

A machine can retrieve product information by ID or license plate using a service account token.

The new API works as expected.
The emails of the users are included in the response of the body.

The list endpoint now displays the emails of the contacts too:


Linter complains paper-listbox attr-for-selected name when placed on paper-item

When using paper-listbox and attr-for-selected="value" with paper-item, the  linter complains below. Is this a error on the linter part? Everything looks legit Polymer wise. It doesn't matter what name I use for the  attr-for-selected, it will complain.
                value="[[picklistValues.ENHANCEDYESNO_DATANOTCOLLECTED]]">
                ~~~~~

src/sp-elements/sp-static-forms/sp-disabilities/sp-disabilities-form-edit.html(404,17) warning [set-unknown-attribute] - paper-item elements do not have a property named value. Consider instead:  role$

                <paper-listbox
                  attr-for-selected="value"
                  selected="yes"
                  class="dropdown-content">
                  <paper-item
                    value="[[picklistValues.ENHANCEDYESNO_YES]]">
                    Yes
                  </paper-item>

you have to set it as an attribute:
                  <paper-item
                    value$="[[picklistValues.ENHANCEDYESNO_YES]]">
                    Yes
                  </paper-item>

Thanks.
Could the verbiage need refinement? the value is a attribute. From documentation, $ is used for html native attributes or dynamic values. But the without the  $, value is still a attribute.

paper-listbox is getting the selected attribute using:
var propValue = item[dashToCamelCase(this.attrForSelected)];
return propValue != undefined ? propValue :
                                item.getAttribute(this.attrForSelected);

So it's getting the property first, and if it's not set it falls back to the attribute.
In this case, value isn't defined on paper-item as a property, so binding to it's attribute instead is a good way to avoid any issues with the linter, as I don't believe it should cause a linter error.


Using meaningful column/field names

Dear Benjamin and Daniel,
for starting a discussion around assigning meaningful English names to meteorological short identifiers, I wanted to humbly point out eaaf936e coming from our PR #55.
We had similar things within the knowledgebase module knowledge.py of dwdweather2 and recognized you also already started to put efforts into the aspect of appropriately mapping DWD-specific original parameters, names and such to identifiers which are more suitable for human consumption.
So, we would like to ask you if you appreciate the approach to expand that very aspect on all field names available?
With kind regards,
Andreas.

Dear @amotl ,
I had mainly left those "data column names" untouched because I'd have a hard time choosing the right names for the values. There are those given names by DWD which are sometimes as long as a sentence which is also not really an option.
Furthermore when extending the column names, the data becomes hardly printable as for data which has several parameters, this would easily span over the whole screen, thus the dataframe is hardly readable anymore. I'd prefer an opt in solution. Putting the full name also wouldn't be a problem if we'd melt the DataFrame (could also be opt in).
What do you think?

Dear Benjamin,

I had mainly left those "data column names" untouched because I'd have a hard time choosing the right names for the values. There are those given names by DWD which are sometimes as long as a sentence which is also not really an option.

I see. Maybe @wetterfrosch and I can work on that aspect to establish reasonable names here.

[In any case, ] I'd prefer an opt in solution [for that].

Your wish is my command. I will add an option humanized_column_names to the collect_dwd_data method.

Thank you, I merged the PR. Column names may also be lowercase as you wish.

Thank you, I merged the PR.

Thanks again!

Column names may also be lowercase as you wish.

Shall we make all things on the right hand side of column_names_enumeration.py lowercase then?

Thank you, I merged the PR.

Thanks again!

Column names may also be lowercase as you wish.

Shall we make all things on the right hand side of column_names_enumeration.py lowercase then?

Yes, sure!

After completing the list for the daily resolution, we should expand the list of column names for the 10_minutes and hourly resolutions next, see https://github.com/panodata/dwdweather2/issues/13#issuecomment-653950576.

I will try and setup up the names for the whole set of parameters. I already know that some values are not that clear, and with those I'll come back to you!

I will try and setup up the names for the whole set of parameters.

Thanks! You might want to get inspired by our naming scheme applied within the knowledgebase module knowledge.py of dwdweather2 to make the column names look and sound nice.
Examples: temperature_max_200, temperature_min_200, temperature_min_005, soil_temperature_002, soil_temperature_005, etc.

https://github.com/panodata/dwdweather2/blob/0.14.0/dwdweather/knowledge.py#L136-L153
https://github.com/panodata/dwdweather2/blob/0.14.0/dwdweather/knowledge.py#L193-L201

It would be cool to be able to give individual humanized column names to same columns per parameter, especially for the quality level columns like daily_quality_level_3 vs. daily_quality_level_4 vs. soil_temperature_quality_level in order to be able to merge data from different parameter sets into a single DataFrame without collisions. This relates to #106.

Please check out the new branch https://github.com/earthobservations/wetterdienst/tree/more-meaningful-column-names
I added all column names and had also added a function to create an individual mapping based on some anomalies within "kl" parameter, that has two quality flags within one file.
I still had some issues with the parameters:
RWS_IND_10
RS_IND_01
DD
CD_TER
DK_TER
FK_TER
NSH_TAG
JA_RR
JA_MX_RS
Maybe we can discuss those.


fix: Improved bugfix for CSP Restriction for TrustedTypePolicy Creation in Loading Indicator

…on in Loading Indicator

Details
This PR aims to fix the issue https://github.com/PlasmoHQ/plasmo/issues/985
The previous issue is exist on website like linkedin.com, I try to fix it
Code of Conduct

[ √] I agree to follow this project's Code of Conduct
[√ ] I agree to license this contribution under the MIT LICENSE
[ √] I checked the current PR for duplication.

Contacts

(OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.
To join the server, visit: https://www.plasmo.com/s/d

i create a hotfix for this issue on this PR #1000
you can test or use my bugfix

clone the repo
git clone git@github.com:agungjk/plasmo.git --recurse-submodules

install dependency
pnpm install

build the repo
pnpm run build:cli

go to the folder cd cli/plasmo and link the runtime pnpm link --global

you can test it by running plasmo dev instead of pnpm run dev on your plasma project

Has this been released? I'm still having trouble with Linkedin


kops: 1.22.4 -> 1.23.0

Description of changes

kops_1_23 init at 1.23.0
kops: 1.22.4 -> 1.23.0
drop kops_1_20
add me as maintainer

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@SuperSandro2000, is the preference to squash and merge here, since there are two commits? Would you mind doing it, if you feel it's ready?

we need to update the release notes. I notice they still say the default is 1.22.4


DSUBm_002: AuditEvent profiling is not done due to use of R4B

(see DSUBm_002 in issues.html)
The AuditEvents for each transaction are not yet profiled bacause the IG publisher, at the moment, does not allow to further constrain a Profile coming from a different FHIR version of the IG.

If we are going to switch to R4 we can use the BALP profile.
Otherwise, if we decide to remain in R4B, we could recreate what we need of BALP inside DSUBm

Decided to switch to R4 will use BALP.

profiled the AuditEvents for each transactions


Improve SonarQube Grade

Describe the bug
Due to recent changes SonarQube is failing; https://sonarcloud.io/dashboard?id=com.asanka.tutor%3Aopen-learnr
Expected behavior
Need to have a passing SonarQube grade :smile:

Yes, :) due to recent changes, for example, Video & VideoDTO has similar fields, it shows a duplicate finding in SonarQube. Let me check it.

@inspire99 : Thanks :smile:

Nice


Plans to support LISTEN/NOTIFY?

Are there any plans to support LISTEN and NOTIFY? Specifically, I'd like to configure a location block such that when I make an HTTP request, it will block, listening on some condition, until it is notified.

@pmahoney There is no such plan AFAIK. It should be much much easier to implement this in the pgmoon Lua library that is based on ngx_lua module's cosocket API, which is also 100% nonblocking inside NGINX:
https://github.com/leafo/pgmoon

Thanks for the tip; I'll check out pgmoon.


Mediasite Extractor issue

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.04.07. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2019.04.07

Before submitting an issue make sure you have:

[X] At least skimmed through the README, most notably the FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones
[X] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
C:\Users\User\Downloads>youtube-dl --cookies=cookies.txt --verbose https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--cookies=cookies.txt', '--verbose', 'https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.04.07
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134
[debug] exe versions: none
[debug] Proxy map: {}
[MediasiteNamedCatalog] mat200-v2019: Downloading webpage
ERROR: Unable to extract catalog id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbwh57p\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbwh57p\build\youtube_dl\extractor\common.py", line 529, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbwh57p\build\youtube_dl\extractor\mediasite.py", line 362, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbwh57p\build\youtube_dl\extractor\common.py", line 1004, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract catalog id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description of your issue, suggested solution and other information
Fails at extracting download links from catalog, leave a comment and I'll supply you with cookies.txt or username and password for the site (added dstftw to repository with username and password and cookies.txt as you have resolved my previous issues)

Ahh sorry, renamed it so must have broken link. Resent invite

Either invalid or expired cookies file.
> py -2.7 .\youtube_dl\__main__.py https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019 --cookies cookies.txt -i
[MediasiteNamedCatalog] mat200-v2019: Downloading webpage
[MediasiteCatalog] 5d5fac2b-9183-4986-94f9-747913dccfff: Downloading webpage
[MediasiteCatalog] 5d5fac2b-9183-4986-94f9-747913dccfff: Downloading JSON metadata
[download] Downloading playlist: MAT200 - Matematiske Metoder 2 - våren 2019
[MediasiteCatalog] playlist MAT200 - Matematiske Metoder 2 - våren 2019: Collected 41 video ids (downloading 41 of them)
[download] Downloading video 1 of 41
[Mediasite] fddc7950dbc643e6af1a903c2279f1071d: Downloading webpage
[Mediasite] fddc7950dbc643e6af1a903c2279f1071d: Downloading JSON metadata
[Mediasite] fddc7950dbc643e6af1a903c2279f1071d: Downloading ISM manifest
WARNING: Failed to download ISM manifest: HTTP Error 404: Not Found
[Mediasite] fddc7950dbc643e6af1a903c2279f1071d: Downloading MPD manifest
WARNING: Failed to download MPD manifest: HTTP Error 404: Not Found
[Mediasite] fddc7950dbc643e6af1a903c2279f1071d: Downloading ISM manifest
WARNING: Failed to download ISM manifest: HTTP Error 404: Not Found
[Mediasite] fddc7950dbc643e6af1a903c2279f1071d: Downloading MPD manifest
WARNING: Failed to download MPD manifest: HTTP Error 404: Not Found
ERROR: unable to download video data: HTTP Error 404: Not Found
[download] Downloading video 2 of 41
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading webpage
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading JSON metadata
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading ISM manifest
WARNING: [Mediasite]  is not a supported codec
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading MPD manifest
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading ISM manifest
WARNING: [Mediasite]  is not a supported codec
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading MPD manifest
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading ISM manifest
WARNING: [Mediasite]  is not a supported codec
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading MPD manifest
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading ISM manifest
WARNING: [Mediasite]  is not a supported codec
[Mediasite] 5f69fa18cf6946e192114c5fa9c88cf31d: Downloading MPD manifest
[dashsegments] Total fragments: 1092
[download] Destination: MAT200 mandag_4_8_2019-5f69fa18cf6946e192114c5fa9c88cf31d.fvideo1-1.2-1_V_video_1.mp4
[download]   0.2% of ~152.36MiB at 509.86KiB/s ETA 20:58
ERROR: Interrupted by user

Tried with new cookies.txt and just inputting username and password directly into youtube-dl commandline with --username and --password but I still just get the same error
'''
C:\Users\magnus\Downloads>py -2.7 C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl_main_.py https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019 --cookies=cookies.txt -i -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019', u'--cookies=cookies.txt', u'-i', u'-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.04.07
[debug] Python version 2.7.16 (CPython) - Windows-10-10.0.17134
[debug] exe versions: none
[debug] Proxy map: {}
[MediasiteNamedCatalog] mat200-v2019: Downloading webpage
ERROR: Unable to extract catalog id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\YoutubeDL.py", line 796, in extract_info
ie_result = ie.extract(url)
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\common.py", line 529, in extract
ie_result = self._real_extract(url)
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\mediasite.py", line 362, in _real_extract
r'CatalogId\s*:\s*"'' % _ID_RE, webpage, 'catalog id')
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\common.py", line 1004, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract catalog id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
C:\Users\magnus\Downloads>py -2.7 C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl_main_.py https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019 --username username --password password -i -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019', u'--username', u'PRIVATE', u'--password', u'PRIVATE', u'-i', u'-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.04.07
[debug] Python version 2.7.16 (CPython) - Windows-10-10.0.17134
[debug] exe versions: none
[debug] Proxy map: {}
[MediasiteNamedCatalog] mat200-v2019: Downloading webpage
ERROR: Unable to extract catalog id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\YoutubeDL.py", line 796, in extract_info
ie_result = ie.extract(url)
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\common.py", line 529, in extract
ie_result = self._real_extract(url)
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\mediasite.py", line 362, in _real_extract
r'CatalogId\s*:\s*"'' % _ID_RE, webpage, 'catalog id')
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\common.py", line 1004, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract catalog id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
C:\Users\magnus\Downloads>py -3.7 C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl_main_.py https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019 --username username --password password -i -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://mediasite.uis.no/Mediasite/Catalog/catalogs/mat200-v2019', '--username', 'PRIVATE', '--password', 'PRIVATE', '-i', '-v']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2019.04.07
[debug] Python version 3.7.0 (CPython) - Windows-10-10.0.17134-SP0
[debug] exe versions: none
[debug] Proxy map: {}
[MediasiteNamedCatalog] mat200-v2019: Downloading webpage
ERROR: Unable to extract catalog id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\YoutubeDL.py", line 796, in extract_info
ie_result = ie.extract(url)
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\common.py", line 529, in extract
ie_result = self._real_extract(url)
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\mediasite.py", line 362, in _real_extract
r'CatalogId\s*:\s*"'' % _ID_RE, webpage, 'catalog id')
File "C:\Users\magnus\Downloads\youtube-dl-master\youtube_dl\extractor\common.py", line 1004, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract catalog id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
'''
Even tried launching it from the command line like you did, even tried different versions of python. Are you using windows aswell?

nevermind it's working now


SubdirectoryHandler.SendAsync drops Port

[Enter feedback here]
IMHO first line in body of SubdirectoryHandler.SendAsync should rather be
var url = $"{request.RequestUri.Scheme}://{request.RequestUri.Host}:{request.RequestUri.Port}";
Otherwise a non-default port (e.g. 5001) gets redirected to the default port (e.g. 443)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c730b5f9-031e-beab-b838-6e2f8befde30
Version Independent ID: 84ddcb67-03be-655c-470a-f43a5152606f
Content: Troubleshoot gRPC on .NET Core
Content Source: aspnetcore/grpc/troubleshoot.md
Product: aspnet-core
Technology: aspnetcore-grpc
GitHub Login: @JamesNK
Microsoft Alias: jamesnk

To clarify, the above refers to this documentation.

Thanks for reporting this. Fix here - https://github.com/dotnet/AspNetCore.Docs/pull/25218


compilers/nim: do not modify hardening flags

Description of changes
Hardening can set -O𝑛 flags that contradict $CC flags added by the Nim compiler but this should be resolved later in the wrapper script.
Fix #243759
Things done
Nitter NixOS tests passes.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The nimmm package broke by the hardening adjustment, so I made some package updates to fix it and run more tests.

Result of nixpkgs-review pr 243803 run on x86_64-linux 1

1 package marked as broken and skipped:

hottext

4 packages failed to build:

nimPackages.eris
nimPackages.eris.bin
nimPackages.pixie
nimPackages.regex

59 packages built:

mosdepth
nim (nimPackages.nim)
nimPackages.asciigraph
nimPackages.asynctools
nimPackages.base32
nimPackages.base45
nimPackages.bumpy
nimPackages.c2nim
nimPackages.cbor
nimPackages.chroma
nimPackages.coap
nimPackages.flatty
nimPackages.freedesktop_org
nimPackages.getdns
nimPackages.hts-nim
nimPackages.illwill
nimPackages.illwillwidgets
nimPackages.jsonschema
nimPackages.jsony
nimPackages.nimSHA2
nimPackages.nim_builder
nimPackages.nimraylib-now
nimPackages.nimsimd
nimPackages.noise
nimPackages.npeg
nimPackages.parsetoml
nimPackages.preserves
nimPackages.rocksdb
nimPackages.safeset
nimPackages.sass
nimPackages.sdl2
nimPackages.segmentation
nimPackages.snappy
nimPackages.spry
nimPackages.spryvm
nimPackages.stew
nimPackages.syndicate
nimPackages.taps
nimPackages.tempfile
nimPackages.tkrzw
nimPackages.ui
nimPackages.unicodedb
nimPackages.unicodeplus
nimPackages.vmath
nimPackages.ws
nimPackages.x11
nimPackages.zippy
nimdow
nimlsp
nimmm
nitch
nitter
nrpl
promexplorer
snekim
swaycwd
tridactyl-native
ttop
vimPlugins.fruzzy

Seems eris is still failing actually.
2 packages failed to build:
nimPackages.eris nimPackages.eris.bin


chore: splitting utilities in sync/async

This PR is an experiment splitting some utilities into sync/async versions.
We have the original (hybrid) and the new one.
Hybrid approach
https://github.com/FuelLabs/fuels-ts/blob/3b9188ca9e5b916a727bbdfe3681ec23cdda1b24/packages/errors/src/test-utils/expect-to-throw-fuel-error.ts#L1-L47
Split approach
https://github.com/FuelLabs/fuels-ts/blob/e7075b6eac860ad8a8da2559e8341c056e84a873/packages/errors/src/test-utils/expect-to-throw-fuel-error.ts#L1-L55

I understand the sentiment in this approach and I'm okay with it.
My question is: should we really separate our testing utilities into separate sync and async implementations or write one utility that handles both its sync and async cases and use the type system's inference capabilities to let the user know which case they're dealing with? (See the implementation of expectToThrowFuelError in the base branch).
I lean more on the "one implementation covering both cases" side, but it's not something I have a hard opinion on. One might say that it's harder to maintain because you have to think about the type inference side of things as well - and they'd be right, but I like the benefit for the end user in that they have only one utility function to think about. In most cases, the type inference isn't really that problematic to wrap your head around and it'd be relatively easy to maintain. However, given the ubiquitous nature of the *async suffix in programming, it would be intuitive for the user to have two same utilities as well (utility, utilityAsync).
@FuelLabs/sdk-ts please chime in.

@nedsalk You front-ran my description for the PR. 😅
But yes, that's all there is to it, and I highlighted both implementations in the description:

Having a method that can behave sync/async depending on the received arguments
Having two methods: sync and async, to be used independently

Regardless of how this goes, I think the safeExec utility should follow the pattern. If this becomes too cumbersome, I can file this PR later on against master as well, just wanted to get it out there since I'd be primarily unavailable this week.

As a general rule I wouldn't like to see us trying utilising a hybrid approach for sync/async code for most cases. It can add a lot of noise to the function signature and abstracts the function away from it's actual utility. Maintaining simplicity and a simpler API I think is more beneficial in most cases.
However for test utilities like the former implementation of the above, I appreciate the flexibility it offers to test cases and am in favour of it.

@danielbate How are test utilities different from anything else?

I would regard them as different as the test utility contents shouldn't dictate the clarity of the test. For example, so long as it is semantically named, a utility like getForcProject or getTestWallet; these utilities bootstrap the tests allowing for the real value to be within the test case itself. How they go about doing that I think is an implementation detail that is irrelevant to the test case, and as long as the test assertions are setup correctly and show a valid change then it is a valid and comprehendible test.
Whereas inside of our service, the entire implementation is relevant to scrutiny as it has a direct implication on the validity and value of the service.

The methods getForcProject or getTestWallet aren't a good reference since they have only one behavior.
The usability criteria of something we expose shouldn't change just because it is intended to be used in tests. It is all the same, and unlike internal test utilities, it's good to reinforce that this one is also being exported for external consumption.
When we think about it, everything in the Javascript ecosystem is habitually split in sync/async, maybe because of how ambiguous things can get otherwise. Besides going against this habit, the hybrid implementation also looks hacky, unless we disregard how multiple @ts-expect-error and eslintignore directives are required to make it play nice.


removed breakpoints are still causing stops (v0.12.6)

Set a breakpoint
Run some code
Hit breakpoint
Repeat a few times
Remove the breakpoint
Continue running code

Expected: code does not stop on breakpoint.
Actual: about 50% of the time the removed breakpoint is still active somehow. It won't have a blue arrow on that line but the execution is still stopping on that line.
I'm sure this is a duplicate but I couldn't find another issue about this. Is it a bug in v8 debugger? Where would I submit that if so?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30842865-removed-breakpoints-are-still-causing-stops-v0-12-6?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github).

Still happening in 0.12.8:
$ node-inspector --version
Node Inspector v0.12.8

$ node --version
v4.4.4


Move Test-Connection tests back to using hostname

PR Summary
Fixes https://github.com/PowerShell/PowerShell/issues/13309.
Reverts some of the changes in https://github.com/PowerShell/PowerShell/pull/12943.
The Test-Connection tests first failed in CI due to a dependency on CI system DNS resolution. We tried to address that in #12943 but recently hit a failure where the new form of the tests using the gateway address also failed consistently across builds.
Given that the DNS issue was resolved, this changes the tests that have been failing back to using the hostname.
There's also a test that didn't work with DNS, was working with the gateway address, but is not working now. That test is now marked as pending.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@PaulHigin I'm seeing a remoting test failure here in the elevated Windows tests I think:
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at System.Management.Automation.Remoting.PrioritySendDataCollection.ReadOrRegisterCallback(OnDataAvailableCallback callback, DataPriorityType& priorityType) in D:\a\1\s\src\System.Management.Automation\engine\remoting\fanin\PriorityCollection.cs:line 240
   at System.Management.Automation.Remoting.Client.WSManClientCommandTransportManager.SendOneItem() in D:\a\1\s\src\System.Management.Automation\engine\remoting\fanin\WSManTransportManager.cs:line 3975
   at System.Management.Automation.Remoting.Client.WSManClientCommandTransportManager.OnRemoteCmdSendCompleted(IntPtr operationContext, Int32 flags, IntPtr error, IntPtr shellOperationHandle, IntPtr commandOperationHandle, IntPtr operationHandle, IntPtr data) in D:\a\1\s\src\System.Management.Automation\engine\remoting\fanin\WSManTransportManager.cs:line 3681
An error has occurred that was not properly handled. Additional information is shown below. The PowerShell process will exit.
Execution of {& $powershell $PSFlags -c $command} by build.psm1: line 1332 failed with exit code -1073741819
At D:\a\1\s\build.psm1:2192 char:17
+                 throw $errorMessage
+                 ~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : OperationStopped: (Execution of {& $po…it code -1073741819:String) [], RuntimeException
+ FullyQualifiedErrorId : Execution of {& $powershell $PSFlags -c $command} by build.psm1: line 1332 failed with exit code -1073741819
##[error]PowerShell exited with code '1'.

The macOS CI is still failing for the minute, so this doesn't seem to solve our problems with these tests. I'll need to find more time this week to work on this


Json fields missing when annotating on Windows [custom fields for quickview]

Describe the bug
Label Studio allows the import of a JSON file for creating tasks with specific fields. This is a great feature that allowed us to create custom behaviour that fits our unique dataset. However, when a task is clicked and the image shown, you'd expect to see the fields on the left, like in the attached screen capture.

However, this seems to work fine in Mac. On the Windows version, the fields don't exist in this view (they do on the general view, without clicking an image for annotation). Apologies for the lower quality screen capture, as for the Windows machine I had to use my phone to capture the screen:

To Reproduce
Steps to reproduce the behavior:

Import tasks using a JSON file to include custom fields
Click on a task to get to a view of the image to annotate

Expected behavior
All fields should appear in both the main view and the task view. We are working with 3D medical imaging data, and the ability to scroll between sequential images is key to correct annotation. Some of our annotators are working on a Windows environment, so are experiencing this bug.
Screenshots
See above
Environment (please complete the following information):

OS: Windows
Label Studio Version 1.2

Additional context
Add any other context about the problem here.

@royschwartz2 Looks like you are using a previous version of LS on mac, where the custom fields for quickview were available. We dropped custom fields by mistake in the latest versions.
We have an issue about it here: https://github.com/heartexlabs/label-studio/issues/1354

We've added a special gear icon in the quickview that controls these fields after v1.4.


JSON format for GUISkin

GUISkin can currently only be defined from code. This results in some very large blocks of code for the built-in skin in BuiltinResources, and also prevents easy modification. It would be better to establish a JSON format for GUISkin and then import all the properties from there.

You might consider, as an example, the ui XML format from the Qt project for the C++ widgets. Not saying to adopt that, just that it's an example to learn from, so you might be able to avoid some pitfalls.

Thanks, sounds like a good reference. I probably won't be adopting a full data driven GUI approach just yet, currently just the GUI skin is an issue, but it's certainly something to consider for the future.


wire node overlapped on circuit elements is now extendible

Fixes #856
Describe the changes you have made in this pr -
I put condition that the node can be extended if it is hovered upon.
And a CircuitElement can be dragged if it was last selected otherwise it was also being dragged when the wire node was being extended.
Screenshots of the changes (If any) -

Coverage remained the same at 83.902% when pulling 7aa1ceb092387aebca960f870fdeaf6fba948b3a on jha11aditya:overlap into 097930075bb42cc181a9742cfbd6d3e83431f826 on CircuitVerse:master.

@tachyons , It can be merged !! It's working fine for me.

Fixes #856
Describe the changes you have made in this pr -
I put condition that the node can be extended if it is hovered upon.
And a CircuitElement can be dragged if it was last selected otherwise it was also being dragged when the wire node was being extended.

@MrBartusek Could you please post a gif of both elements moving. Because I didn't encounter that.

@jha11aditya I just checked it and for some reason, it is working now, probably I broke something. One slight fix I would implement is a disabling element highlight when a node is highlighted. Awesome work 🚀

Good Attempt, Looks like it might work, on hold for now as this apparently insignificant change can have lasting consequences.

@mahmodHammad can u review this?

@ i will 👍

Awesome work, i believe it should work.
@satu0king this can get merged


Enable receivers to receive data with the dates in a specified timezone.

User Story:
As a receiver, I want to receive data with the dates in my local time, as I could in the Covid Pipeline by calling convertDateTimesToReceiverLocalTime.
Description/Use Case
This will be used to convert the times sent to a receiver into their local date time, or the timezone they request.
Risks/Impacts/Considerations
This is needed for CA.
Dev Notes:
Suggesting that we create a FHIR function that will handle converting date times to receiver local times.
Acceptance Criteria
Dates can have their timezone changed and the time itself changes accordingly.

Adding Jimmy as supplemental resource while Jessica is away.


Issue with parsing rpvars structure in latest 24.1

>>> import ansys.fluent.core as pyfluent
>>> solver = pyfluent.launch_fluent()
>>> len(solver.rp_vars())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\rpvars.py", line 59, in __call__
    else (self._get_var(var) if var else self._get_vars())
                                         ^^^^^^^^^^^^^^^^
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\rpvars.py", line 87, in _get_vars
    return {val[0]: val[1] for val in list_val}
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\rpvars.py", line 87, in <dictcomp>
    return {val[0]: val[1] for val in list_val}
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: unhashable type: 'list'

Some real-list type rpvars like (morpher/y-coords-custom () real-list #f ()) are parsed incorrectly as (['morpher/y-coords-custom', [], 'real-list', False, []], '#[free'). I think it is not ideal to parse the rpvars structure from a string representation. The eval/scheme_eval rpcs in scheme_eval service can return a Scheme structure as Python structure, we can use that here.
Related #2141 (found the current issue while investigating this)

Another thing to consider here is to restrict solver.rp_vars() to return only the rpvars which are persisted in a case file. I think '#[free' appears due to some rpvars which are not serializable.

The issue is in the scheme-eval service on Fluent side, will fix in 24.2.
Not changing the parser as the parsed results must be identical with results from parsing case files for which scheme-eval service is not used.

Fixed in 24.2


"getEndpoint is not a function"

Hello there.
I have a problem when I use this library.
As per official guideline, the library configuration in my main.ts is something like this.
  aurelia.use
    .plugin('aurelia-api', config => {
      config.registerEndpoint('api', 'https://some.api.site');
    });

and in one of the class

    constructor(conn: Config, private ea: EventAggregator)  {
      this.apiEndpoint = conn.getEndpoint('api');
      // snip...
     return this.apiEndpoint.find(params.kos).then(ids => // snip.

but I got an error about getEndpoint is not a function. And here's the part of the generated app-bundle.js from the snippet above.
            this.apiEndpoint = conn.getEndpoint('api');
            ea.subscribe(something_1.Something, function (msg) {
                var ids = msg.what;
                Object.assign(_this.ids, ids);
            });

Thank you for your explanation.

is it the right Config class there?

Yes.

what i mean is, conn apparently isn.t an instance of import {Config} from 'aurelia-api' since then it.d had that function. something is wrong with your (auto)inject or the way you create  instances of that

I'm sorry if the following sentence is unhelpful, but after I delete my node_modules directory and reinstall the modules, it works fine.
May I close this issue?


Auto-scroll to changes

Hoping that facebook/react#15124 fixes the cases where changing the version doesn't auto-scroll to the closest change


multiclass ROC metrics, from confusion matrix

i wnated to separate confusion matrix introduction from ROC, what I did.
we still had the follwoing, which didnt really fit in and i found a bit too advanced
if we introduce multiclass AUC and multiclass ROC stuff, it copuld be brought back,
not too valuable, but wanted to save the slides here

\begin{vbframe}{Multiclass Confusion Matrix}
  \begin{itemize}
    \item The performance of a multiclass classifier can also be summarized in a confusion matrix.
    \item E.g., in a 3-class classification problem with labels A, B and C:
    \item[] \includegraphics[width=0.9\textwidth]{figure_man/roc-multiclass_confmatrix.png}
    \item The overall accuracy is calculated similarly to the binary confusion matrix.
    \item Example:
          $acc = \cfrac{\# \text{TP}_A + \# \text{TP}_B + \# \text{TP}_C}{n} = \cfrac{30+60+80}{300} \approx 56\%$
  \end{itemize}

  \framebreak

  \begin{itemize}
    \item[]   \includegraphics[width=0.9\textwidth]{figure_man/roc-multiclass_confmatrix.png}
    \item Other measures, e.g. tpr, need to be calculated in a one-vs-all manner.
    \item Example (True Positive Rate for label A):
    $$\text{TPR}_A = \cfrac{\# \text{TP}_A}{\# \text{TP}_A + \# \text{FN}_A} = \cfrac{30}{30+50+20} = 0.3$$
    \item Example (Positive Predictive Value for label A):
    $$\text{PPV}_A = \cfrac{\# \text{TP}_A}{\# \text{TP}_A + \# \text{FP}_A} = \cfrac{30}{30+20+10} = 0.5$$
  \end{itemize}

\end{vbframe}

Maybe should be content in CIM?


Endianness-Issue in FIPS provider

OpenSSL master HEAD fails to load FIPS provider on s390 due to endianness problems.
Handling of parameter OSSL_KDF_PARAM_SSHKDF_TYPE caused endianness problems on
s390.  It is not possible to pass FIPS tests since the parameter was stored
with an integer value but read via a cast to char pointer.  While this works
on little endian machines, big endian s390 read the most significant bits
instead of the least significant (as done by, e.g., x86).
See https://github.com/openssl/openssl/pull/13781 for a possible fix.

This is now fixed.


for some reason this file is "unable to parse" in the build server

Build server is reporting a failure in this file, but I'm not sure why. Seeing if this helps
##[warning]Could not parse Jtokens from C:\BA\7861\s\source\tools\hostConfig\json-to-scss\package-lock.json file.
Microsoft Reviewers: Open in CodeFlow

Seems to have fixed it, forcing merge since it's just a change in spaces


Bump ruby to latest 2.x release

Ruby 2.6 is in security maintenance phase and will reach end-of-life soon [1].
This commit changes the .ruby-version file used by developers and tooling to use the current latest release of 2.7, which is the last in the Ruby 2.x series.

This doesn't work (although the tests pass), due to something to do with frozen strings?
tech-docs-monitor on  ldeb-bump-ruby took 10s at 14:04:05
% SLACK_WEBHOOK_URL=test bundle exec rake
rake aborted!
FrozenError: can't modify frozen String: ""
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/.bundle/gems/http-3.3.0/lib/http/response/body.rb:52:in `force_encoding'
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/.bundle/gems/http-3.3.0/lib/http/response/body.rb:52:in `to_s'
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/lib/notifier.rb:40:in `pages'
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/lib/notifier.rb:44:in `pages_per_channel'
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/lib/notifier.rb:19:in `run'
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/Rakefile:29:in `block (3 levels) in <top (required)>'
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/Rakefile:28:in `each'
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/Rakefile:28:in `block (2 levels) in <top (required)>'
/Users/laurencedebruxelles/Code/tech-docs-template/tech-docs-monitor/.bundle/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/Users/laurencedebruxelles/.rbenv/versions/2.7.5/bin/bundle:23:in `load'
/Users/laurencedebruxelles/.rbenv/versions/2.7.5/bin/bundle:23:in `<main>'
Tasks: TOP => default => notify:expired
(See full trace by running task with --trace)

Putting this as draft until I have time to write tests and fix.

This is probably related to https://github.com/httprb/http/pull/653
Going to raise a separate PR to try bumping the http gem.

Note, this PR broken concourse, because I forgot to update pipeline.yml. See #43.


Add Mohist Server Software

Mohist is an opensource Forge + Paper (1.12.2/1.15.2)implementation with our own optimizations.
Project URL: https://github.com/Mohist-Community/Mohist

Thank you!
Please take a look at my issue on your GitHub project about switching to the "Server Implementation" category: https://github.com/Mohist-Community/Mohist/issues/143


temporary WAR workaround till __double2half support enabled in HIP

This is a temporary fix for the following error , which is encountered  when running stable_diffusion inference with deepspeed inference
 till __double2half intrinsic support is enabled on rocm.
FAILED: gelu.cuda.o
/opt/rocm/bin/hipcc  -DWITH_HIP -DTORCH_EXTENSION_NAME=transformer_inference -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1013\" -I/opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/transformer/inference/includes -I/opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -isystem /opt/conda/lib/python3.8/site-packages/torch/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/TH -isystem /opt/conda/lib/python3.8/site-packages/torch/include/THC -isystem /opt/conda/lib/python3.8/site-packages/torch/include/THH -isystem /opt/rocm/include -isystem /opt/rocm/miopen/include -isystem /opt/rocm/hip/include -isystem /opt/conda/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -std=c++14 -O3 -std=c++14 -g -Wno-reorder -fPIC -D__HIP_PLATFORM_HCC__=1 -DUSE_ROCM=1 -DCUDA_HAS_FP16=1 -D__HIP_NO_HALF_OPERATORS__=1 -D__HIP_NO_HALF_CONVERSIONS__=1 -O3 -std=c++14 -U__HIP_NO_HALF_OPERATORS__ -U__HIP_NO_HALF_CONVERSIONS__ -U__HIP_NO_HALF2_OPERATORS__ -DROCM_VERSION_MAJOR=5 -DROCM_VERSION_MINOR=4 --amdgpu-target=gfx900 --amdgpu-target=gfx906 --amdgpu-target=gfx908 --amdgpu-target=gfx90a --amdgpu-target=gfx1030 -fno-gpu-rdc -c /opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/transformer/inference/csrc/gelu.hip -o gelu.cuda.o
Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead.
Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead.
Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead.
Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead.
Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead.
In file included from /opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/transformer/inference/csrc/gelu.hip:7:
/opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/includes/conversion_utils_hip.h:269:12: error: use of undeclared identifier '__double2half'; did you mean '__double2hiint'?
    return __double2half(val);
           ^~~~~~~~~~~~~
           __double2hiint
/opt/rocm-5.4.0/include/hip/amd_detail/amd_device_functions.h:440:30: note: '__double2hiint' declared here
__device__ static inline int __double2hiint(double x) {
                             ^
1 error generated when compiling for gfx1030.

@jithunnair-amd  @amathews-amd @jeffdaily


No plugin homepage link or route

I am logged as ad administrator but I cannot get either the link or the route for the admin plugin page:

The plugin is otherwise working and successfully loggin in by visiting the url /strapi-plugin-sso/azuread
Am I missing something?
Thanks

@giuliogatto
This is the first time I've encountered this issue.
I assume it should appear if the user's role is set as Super Admin.
If you could let us know the versions of Strapi and the plugin, we might be able to investigate this a bit further.
By the way, my local environment is like this

@yasudacloud thank you for your quick reply.
I am using Strapi "4.13.6" and I also have another plugin that I wrote (it's called Build website you can see in the screenshot above). I suspect this issue is either related to my Strapi version or to a conflict with my plugin.. I am trying to investigate and debug the code

@giuliogatto
Thanks for the information.
I have installed v4.13.6 and it seems to be working correctly.
If I could solve the problem any other way...)

try disabling the other one's plugin.
stop the process once and run yarn build && yarn start again

OK, I am debugging the code to find the culprit. Thank you for your assistance, I will let you know if i find something

Ok, rebuilding everything from scratch, after removing all other plugins, solved the issue


Add setting so version is only incremented once

Currently, it seems that each non-hidden commit type it finds increments the new version by one. So if I release version 0.0.1, then I add 3 fix: commits, the new suggested version is 0.0.4. It works similarly for feat with the minor version, and I would venture a guess with breaking/major.
Maybe this is desirable for some people, but it would be great if we could add a setting (if it doesn't already exist) so that once it determines what part of the version it needs to bump, it just increments by one.
Here is my example build in pom:
   <build>
        <plugins>
            <plugin>
                <groupId>team.yi.maven.plugin</groupId>
                <artifactId>maven-semantic-gitlog</artifactId>
                <version>0.22.0</version>
                <configuration>
                    <fileSets>
                        <fileSet>
                            <target>${project.basedir}/CHANGELOG.md</target>
                            <template>${project.basedir}/config/CHANGELOG.mustache.md</template>
                        </fileSet>
                    </fileSets>

                    <updateProjectVersion>false</updateProjectVersion>
                    <derivedVersionMark>NEXT_VERSION:==</derivedVersionMark>
                </configuration>
            </plugin>
        </plugins>
    </build>

I'm so sorry I have no time to reply to you! It's too busy these days.
about your issue, I have these suggestions:

this doc maybe help you: https://semantic-gitlog.github.io/semantic-gitlog/#/en-us/components/semantic-gitlog/?id=configuration

isUnstable It is useful to suppress the version surge caused by breaking changes during the development phase.
strategy if set slow, Regardless of how many similar changes there are, the corresponding version number is increased only once.
You can also use some options to customize the relationship between the commit type and the version parts: majorTypes, minorTypes, patchTypes and preReleaseTypes, buildMetaDataTypes.

the code logic at here: https://github.com/semantic-gitlog/semantic-gitlog/blob/master/src/main/java/team/yi/tools/semanticgitlog/VersionDeriver.java#L36

Awesome, I had a feeling i just needed a setting. strategy="slow" looks like the winning ticket. Thanks for the library!

Oops, a little premature in closing it. Looks like "strategy" isn't exposed to the plugin configuration so I can't set it in pom.xml.

Well, I compared my notes, and I removed the option "strategy" before publishing the code.
I'll add it again in few days.

I released version 0.22.1, please update it.

Hi! Thanks for the update. I am seeing better effect with strategy="slow". There is one unexpected behavior though, and that is when I have a breaking change AND either a fix or feat.
If I start with a tag of v1 and add two commits:
commit abcd2

fix: bugfix 2
--------------

commit abcd1

fix: bugfix 2

doesn't matter what type of change, just that it's breaking

BREAKING CHANGE: had to introduce a breaking change to fix the bug

This will result in it generating a new version of 2.0.1.
My expectation with SemVer + Convetional Commit is that if you have a feat AND fix, minor is bumped and patch reset to 0. When a breaking change occurrs, major is bumped and minor as well as patch are reset to 0.


tegola.Tile needs BoundingBox method

First cut will return the UL & LR points in degrees.

I don't think this is valid anymore.


Use pointer type for right use of mutex

Hi, I found a bug in a default SourceCodeLoader.
fsLoader uses sync.Mutex, but its receiver type of Load is a value.
So mu.Lock and mu.Unlock does not affects shared state.
It causes race condition when writing fsLoader.cache from multiple goroutines.

Thanks for the fix! 🍕

Thank you ! :+1:
I just had a panic/crash in production today concurrent map writes.
I think it will fix it.


Update .travis.yml to php 8.0snapshot

There is no php 8.0 in travis, the correct one is 8.0snapshot.

It should be coming soon, they are trying to build the image according to this discussion. Since we are blocked by a few other issues, it doesn't matter waiting a bit more until it will be available


Improve performance if IN list function

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11182
The initial implementation of IN and NOT IN followed the "functional first, and then fast"
There are several potential performance improvements for the IN and NOT IN implementation in Data fusion such as optimizing for large lists (use a hash table rather than repeated comparisons) and short circuiting results.


Client Allocation Request for: Blucon

Client Allocation Questions
Core Information

Name: Blucon
Website / Social Media: http://blucon.io/
Region: Asia excl. Greater China
DataCap Requested: 10TiB
Addresses to be Notarized: f3wxegeffsajm7qgmv7rqda373kbzuhkiwhmihk7s3bmzc4f7mh76zsswls7nydtcs4slmurcy6w2chxtcwiva
Notary Requested: IPFSUnion

@Blucon Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hi. I'm glad to meet you.
I'm Han, a member of the management team.
We are Blu Global Partners Co., Ltd. It is an integrated global payment platform company.
Website: http://blucon.io/
Facebook: https://www.facebook.com/projectblucon
Our company was founded in 2018 and is located in Seoul, South Korea. It is also in China and Singapore.
We were looking for a system suitable for blockchain technology and cryptocurrency and found out about a very effective and cost-effective storage system called FileCoin.
We have built our own blockchain virtual currency ecosystem, so we have ownership in all transactions or projects.
It has never been obtained before.
We hope to bridge the gap between virtual currency and traditional financial systems through FileCoin and develop into a global blockchain financial hub. It is proposing a way for current cryptocurrency to be used as a card, and it will use FileCoin to convert cryptocurrency into cash that can be used immediately and build a safe system, and all data on this will be stored in the Datacap. It is a storage system suitable for the BLU EXO-Platform we are envisioning.


Set up some pipelines to test data in teststroom

Create or re-use some pipelines

This depends on https://github.com/gchq/stroom-resources/issues/19
It could also be done as part of https://github.com/gchq/stroom/issues/646

Subsumed by other issue


prefix exe name to log file for better seggregation of logs in dev setup

Currently in development setup going through logs is a tedious process as logs from all processes ends up in ${env}.log file. This makes it really difficult to analyze requests and also the size of development logs grows enormously within few hrs of usage. Now each process will get its own log with this PR.

Pull Request Test Coverage Report for Build 1804

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 88.674%

Totals

Change from base Build 1802:
0.02%

Covered Lines:
8048

Relevant Lines:
8786

💛  - Coveralls


Don't request redraw in AnimatedTexture to decrease editor CPU/GPU usage

This means AnimatedTextures will update at an erratic rate if nothing else is causing the editor to redraw continuously (or projects, if Low Processor Mode is enabled). However, lowering the CPU/GPU usage by a significant amount is probably preferred in most situations.
This will not affect the editor if Update Continuously is enabled, or if Low Processor Mode is disabled in the project (which is the default).
This partially addresses https://github.com/godotengine/godot/issues/39758.
PS: I wonder why the old code isn't forcing a redraw request here instead: https://github.com/godotengine/godot/blob/40963cc9200d0f2f0990df05b9271e3772f57c70/scene/resources/texture.cpp#L2185
This would lead to lower CPU/GPU usage already, butit wouldn't fully resolve the original issue (especially at higher animation FPS).

One problem is that there are lots of similar cases to this that will cause redraw in 4.x, and it is impossible to know in advance which users will want to cause updates and which not. You could end up swapping this to not continuously update, then a user will complain that it doesn't continuously update, make another PR to flip it back in the source, repeat ad infinitum.
You could make it controllable per feature but this is probably overkill.
Overall my recommended approach for this use case would be to port #53463 to 4.x. I think reduz was unsure about the vital updates features at the time in master (maybe thinking that a low update rate would work as well), but the feature works great in 3.x. Perhaps we will get more feedback on this after 3.5 as many are unaware of this feature as yet.)

Again I dont think this is a problem. For a lot of users, more CPU usage is not a problem as long as things work properly, you should not break thing for them. We could see a special mode for laptops or something like that, but this is not the right way.

Closing in favor of https://github.com/godotengine/godot/pull/53463, which should be forward-ported to master eventually.


Changed inline editor close button icon to match the one in the console

Made changes to the close button icon for bracket's inline editor. I removed the "x" character so that it uses the close icon svg instead. Now it matches the close button icon in the console. Also made it possible for the color of the close button in the inline editor to change between both dark and light svgs whenever the user changes the theme of the brackets editor.
Tested and works in both chrome and Firefox.
This UI change is an attempt to fix the bug issue #2177 from the Thimble repo.
Link to the issue: mozilla/thimble.mozilla.org#2177

@humphd with regards to moving the file to src/styles/images/ how would I go about updating the users?

You can ask git to show you where all the users are:
$ git grep -n "images/close-icon"

That should show you all the files and line numbers where that pattern occurs in the code.  Then you can move the files:
$ git mv {old-filename} {new-filename}

Next you can update all the old uses to point to the new path.  Let me know if this is clear or if you need more advice.

I think I understand now how to go about it. Thanks for the clarification.

I will try to fix it now.

would you recommend I change background-image: url(../images/close-icon-dark.svg) in consoleTheme.less to point to the icon in src/styles/image ?

correction... in the folder src/styles/images/

Yes, exactly, and any other places that rely on the old file path, update them to point to this new one.

Flagging @flukeout for review of this.  Nice work @ericschv.

Checking it out now!

OK - cool this is great. I took a screenshot of some changes I think would be good to make.

So, lets...

Move the icon to the top right (matches how we treat the console)
Make it a bit bigger
Make the clickable area bigger than the icon graphic

We can do this by increasing the height & width of the icon but keeping the icon image smaller via the background-size property.

Nuke the margin-right property.

I took a screencap of the changes I made in my dev tools to achieve this.

Thanks for making this happen @ericschv - hope it's cool I just give you the exact values. Might be easier than asking for small changes as we work through the PR.
One thing I've noticed when people use this thing, is that they often look for an "OK" button when they find a color they like. Hitting the "X" might seem like a Cancel action, which we don't want.

Anyway, might be a good follow-up issue.

@humphd and @flukeout thank you both for the feedback. @flukeout would you prefer I modify the "X" button based on your recommendations and then create a new issue for the addition of the "OK" button, or would you rather I scrap the "X" button and just focus on the "OK" button for this PR?

@flukeout if we do the OK button idea, then we'd have to make it so that you can experiment with the colour and then restore it to what it was.  The OK would signify that you are responsible to accept the changes.
@ericschv I'd do the X version in this PR, and we can file a new bug on the OK stuff if we want to do that later.  Ideally you don't want a single bug or PR to scope-creep and start becoming about more than what it originally was.  This is getting there, and a new bug would be better imo.

@humphd I will focus on making changes to the X button for this PR only then. Just out of curiosity, will you or @flukeout be filing the bug for the OK button should you decide to go through with it?

@ericschv you can do it, or @flukeout can.

@flukeout I made the changes you recommended. Please let me know your thoughts. Also, would you be ok if I created a new issue regarding changing the X to an OK button or would you prefer to handle that?

Great, thanks! Will be testing now.

OK - we are almost there! One thing I realized is that if you make the editor view narrow enough, the (X) starts to be overlapped by the Colorpicker UI, hiding it and making it unusable...

However, I came up with a decent enough solution...

To achieve this we'll have to add some additional styling to that element, outlined below...
  background-color: rgba(0,0,0,.9);
  border-radius: 50%;
  z-index: 2;
  height: 30px;
  width: 30px;

The z-index makes it appear overtop of the UI.
The extra width & height give it a larger click area and leave more breathing room around the X
The background-color help it stand out.

Once you get this in, can you also please attach a screenshot of how it looks in the light-theme? We might have to make some adjustments there. Cheers!

Hey @ericschv forgot to ping you in my comment above, so just a heads up.

@flukeout no worries. I made the changes to the dark theme like you recommended. For the light theme the button will look really dark

So I made changes to the coloring of the background

To achieve this I used the following styling below
background-color: rgba(150, 150, 150, 0.9);

One thing I noticed when using the browser inspector is that whenever the scrollbar appears it overlaps with the background of the "X" button

I thought perhaps it would be ok to move the button over to the left like so

To achieve this I modified the right property with the following styling below
right: 20px

Please let me know your thoughts on the changes I made.

Oh, nice, thanks for jumping on the light theme too - checking it out now and will advise.

Hey @ericschv - have you pushed your latest changes to the PR? I'm not seeing the background color behind the X as it's showing in your screenshots. This is what I'm seeing...

It doesn't look like background-color: rgba(150, 150, 150, 0.9); you referenced above shows up in any files associated with this PR.

@flukeout sorry I forgot to mention that I did not make a PR as I wanted to get your opinion on the images before making a PR. I wasn't sure if it would be appropriate to do so, but I did not realize that you would have to view the code changes within the file. I will make the PR right now.

@ericschv is this ready for another review by @flukeout?

@humphd yes this is ready for another review.

Great, testing now!

Okay, this looks good to me! Thanks a lot @ericschv!
I've got a question for @humphd though, here in the CSS the PR is referencing an image in the basesrc/styles folder since it's an image shared across a few things. Is this OK or should we try to keep the images encapsulated within the extension folder?

OK - sorry I'm going to backtrack a bit. One thing that's bothering me is that the X isn't totally centered in the icon. I took a screenshot and overlaid some lines onto it to illustrate...

I'm not exactly sure why it's happening. Is something off with the svg perhaps? Can you check into it @ericschv and also confirm that you are seeing it? Cheers!

If we're using an image in both core and an extension, I'd rather we either a) duplicate it or b) put in the core styles and reference it there from the extension.  Since this is about unifying the icon, I think duplicating it is probably the wrong move, so let's leave it in core.

Sounds good to me @humphd, let's leave the image file where it is in the PR then.

This is bizarre https://twitter.com/justgitthings/status/918249717829656576

What the... haha. My comment got randomly scraped by a Twitter bot?

@flukeout I took some screenshots of the X for both dark and light themes and applied the same lines to gauge the center point.  Unfortunately the screenshots get pixelated so I'm not certain if the center point gets distorted.
Dark theme

Light theme

@humphd @flukeout indeed that twitter post is strange haha

@flukeout do you want to file a follow-up on the centring issue with the X so we can land this?  I think this is good to go otherwise.
Awesome work @ericschv!

Huh weird - yeah looks different in your screenshots for sure.
Yeah, let's land this - nice work!!


rows.Scan() returns '' for subsequent variables after one is null

If you run a query selecting multiple columns, and then do a Scan() on a row, Scan() fails to fetch values for the column after a column with a null value. That is, if you select foo, bar, and baz, and foo & baz have values where bar is null, baz will be returned also as null (or rather, the zero value for its type.)
This was super weird and took me a while to figure out what was even happening. Once I did, I came up with a repro case. See files in the attached zip. asdf.sqlite3 has junk data constructed to illustrate the issue.
Also see sample shell output, below.
I looked at the source a bit, but I'm totally unfamiliar with Go's C bindings, so it was beyond something I could track down quickly.
weird.zip
[morrildl@homunculus weird 💻]$ GOPATH=`pwd` go get github.com/mattn/go-sqlite3
[morrildl@homunculus weird 💻]$ GOPATH=`pwd` go build test1.go
[morrildl@homunculus weird 💻]$ GOPATH=`pwd` go build test2.go
[morrildl@homunculus weird 💻]$ ls
asdf.sqlite3  pkg  src  test1  test1.go  test2  test2.go
[morrildl@homunculus weird 💻]$ sqlite3 asdf.sqlite3 "select left, green, blue, right, purple from foo left join bar on left=red where left=42"
42|42|42||42
[morrildl@homunculus weird 💻]$ sqlite3 asdf.sqlite3 "select left, green, blue, right, purple from foo, bar where left=red and left=42"
42|42|42||42
[morrildl@homunculus weird 💻]$ ./test1
left='42' green='42' blue='42' right='0' purple=''
left='42' green='42' blue='42' right='0' purple=''
[morrildl@homunculus weird 💻]$ sqlite3 asdf.sqlite3 "select left, green, blue, purple from foo left join bar on left=red where left=42"
42|42|42|42
[morrildl@homunculus weird 💻]$ sqlite3 asdf.sqlite3 "select left, green, blue, purple from foo, bar where left=red and left=42"
42|42|42|42
[morrildl@homunculus weird 💻]$ ./test2
left='42' green='42' blue='42' purple='42'
left='42' green='42' blue='42' purple='42'
[morrildl@homunculus weird 💻]$

This is not a bug. Please check all of errors.
			err = rows.Scan(&v.left, &v.green, &v.blue, &v.right, &v.purple)
			if err != nil {
				log.Fatal(err)
			}

2018/05/05 21:38:45 sql: Scan error on column index 3, name "right": converting driver.Value type []uint8 ("") to a int: invalid syntax

Your right defined as int in s. But the type of the field is string.
package main

import (
	"database/sql"
	"fmt"
	"log"

	_ "github.com/mattn/go-sqlite3"
)

func doQuery(q string) {
	cxn, err := sql.Open("sqlite3", "./asdf.sqlite3")
	if err != nil {
		panic(err)
	}
	defer cxn.Close()
	if rows, err := cxn.Query(q); err != nil {
		panic(err)
	} else {
		defer rows.Close()
		type s struct {
			left                int
			right               string
			green, blue, purple string
		}
		for rows.Next() {
			v := s{}
			err = rows.Scan(&v.left, &v.green, &v.blue, &v.right, &v.purple)
			if err != nil {
				log.Fatal(err)
			}
			fmt.Println(fmt.Sprintf("left='%d' green='%s' blue='%s' right='%s' purple='%s'", v.left, v.green, v.blue, v.right, v.purple))
		}
	}
}

func main() {
	doQuery("select left, green, blue, right, purple from foo left join bar on left=red where left=42")
	doQuery("select left, green, blue, right, purple from foo, bar where left=red and left=42")
}

left='42' green='42' blue='42' right='' purple='42'
left='42' green='42' blue='42' right='' purple='42'


Question about the limitations

Hello thank you for this library, I couldn't find information of whether this library is implemented with SQLite or not.
The other famous library has one significant limitation on Android (due to its implementation on SQLite of course) :
https://react-native-async-storage.github.io/async-storage/docs/limits
Which is that you can not store more than 2mb in one single key, I was curious whether that limitation exists on your implementation or not?
Also would be nice to know if there exists a total size limitation or not?
Thank you so much in advance!

Hey!
MMKV is an in-memory key value storage. This means, it is insanely quick and efficient for small stuff, but anything larger will probably be a slow-down since everything is happening in-memory.
So in short, stuff like "user.refresh-token" or "settings.is-dark" is perfect for MMKV, but stuff like "user.profile-picture-base64" or other big values should be stored in another database (eg SQLite or WatermelonDB) instead.

Thank you for clarification!

I used this library to store more or less 0.5KB and I started to have problems


Windows installation - GraphQL hive fail to run

Discussed in https://github.com/kamilkisiela/graphql-hive/discussions/1214

Originally posted by fmorissette-equisoft February  1, 2023
Can someone help me to figure out if graphql-hive cli is properly supported on Windows ?
This is the error i'm getting :
throw new Error("Service '" + name + "' not found in architect app!");
^
Error: Service 'cli' not found in architect app!
at Architect.getService
Thanks !

@n1ru4l @kamilkisiela any idea how can we try to test/reproduce/fix?

@dotansimha We can run the CLI on a GitHub action windows runner.

I'm able to reproduce this on mac right now.


Flexible matrix/frame literals in DaphneDSL

Motivation: DaphneDSL’s matrix literals are a convenient way to specify small matrices. For instance one can write X = [1, 2, 3]; to get a (3x1) matrix containing the values 1, 2, and 3. This feature is very handy for writing small examples and test cases, and is also useful in complex scripts. Nevertheless, there are still a few points which could be made more convenient. Furthermore, besides matrices, DaphneDSL also supports frames, but there are no frame literals yet.
Task: This project is about adding more syntactic sugar around matrix and frame literals in DaphneDSLs. Implementation in C++. In particular, the following features should be supported:

Mixed value types: Currently, all values in a matrix literal must be of the same value type. Ensure that matrix literals like [1, 2.2] or [false, 3] are allowed. The value type of the resulting matrix should be the most general of the values types of the elements. You can use src/compiler/inference/TypeInferenceUtils.h to determine the most general value type.
Expressions for the matrix elements: Currently, all values in a matrix literal must themselves be literals, i.e., they must be known at parse-time. Ensure that the elements can be the results of complex expressions such as [sqrt(2), 3.1, sum([1, 4, 2] + fill(x, 3, 1))]. In such a case, the matrix cannot be constructed at parse-time. Instead, the expressions should be evaluated at runtime and operations should be generated to compose the overall matrix out of them.
Shape: Currently, matrix literals are a linear list of n elements and result in a (n x 1) matrix, i.e., n rows and 1 column. Any other shape must be achieved by explicitly reshaping the matrix. For instance reshape([1, 2, 3, 4], 2, 2) creates a (2x2) matrix. This is a bit verbose; a notation like [1, 2, 3, 4](2x2) would be great.
Frame literals: So far, DaphneDSL does not support frame literals. Instead, frames can be constructed from column matrices using the createFrame() built-in function, e.g., createFrame([1, 2, 3], [1.1, -2.2, 3.3], "a", "b"). As a first step, a simplification should be supported, such as {"a": [1, 2, 3], "b": [1.1, -2.2, 3.3]} (where the order of the columns is as specified).
Row-major frame literals: As a second step, it should be possible to specify frames row-by-row, e.g., {["a", "b"], [1, 1.1], [2, -2.2], [3, 3.3]}. Note that each column of a frame can have its individual value type, which should be determined as the most general value types used in that column.

Hints:

Have a look into the DaphneDSL parser in src/parser/daphnedsl/ and specifically into the ANTLR grammar in src/parser/daphnedsl/DaphneDSLGrammar.g4 and the core of the DaphneDSL parser in src/parser/daphnedsl/DaphneDSLVisitor.cpp.
Take the examples above as rough ideas, slight syntactical deviations are fine, if required to make it work.

I'd like to be assigned to this issue please

Sure, go ahead!