docs: Service Workbench installation guide

Issue #, if available:  GALI-988
Description of changes: New Service Workbench installation guide
Checklist:

[ ] Have you successfully deployed to an AWS account with your changes?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully tested with your changes locally?
[ ] If new dependencies have been added, have they been pinned to specific versions?
[ ] Is this change also required on the AWS Solution version?
[ ] Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
[ ] If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?

AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The new  SWB installation guide is now published.


Delete semantic_segmentation_vis_report

The interface of VisReports are changing rapidly.
I think it is better to restrict our focus on DetectionVisReport.

@Hakuyume
Can you merge this and #133?
We should concentrate on detection.

I agree we should concentrate on detection.


Need better JMeter result other than just fail

When running JMeter and things fail there is no way right now to know why it failed. Did it fail because the testing script is not there that is configured in jmeter.conf.yaml? or is it because a too high error rate?
Right now we only see this in the sequence screen

I suggest that JMeter - and hopefully all other tools that handle "test" events - to add a good "message" that explains why it failed

Want to add one more thing to this.
Many errors in JMeter are a result that JMeter cant access the passed URL. I therefore suggest that the JMeter service does a quick sanity check on resolving the DNS of the deploymentURI. If the there are any issues with DNS resolution the JMeter service could immediately return an error with a message saying "Cant reach URL a.b.com from JMeter-Service". This will especially be interesting in scenarios where we have a keptn execution plane that hosts the test infrastruture which is testing against an app running in a different environment

To improve, the function https://github.com/keptn/keptn/blob/master/jmeter-service/main.go#L260 has to recive a message and set the property: testFinishedData.Message = msg like the sendErroredTestsFinishedEvent function does.


Add blog post about service discovery

This is more of a general SD intro.
It doesn't have 100% coverage – I think this is more than enough to digest and we cannot replicate the whole config docs in a blog post.
Title suggestions welcome.

I reworked the wording on the entire post and changed the title (suggestion).

Sweet :+1:


Can I use the librealsense SDK in Qt (Mac OS)

Required Info

Camera Model
{ D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{MacOS

SDK Version
{ legacy / 2.<16>.<1> }

Language
{C++}

last time ,I follow what you say in my last question

,but the problem is..

thank you !please

Anything useful in CMakeOutput.log? / Error.log?

Hi Dorodnic, Core055 was referring to the case below, which I've linked to in order to show the steps that Core took that led up to their problem.
https://github.com/IntelRealSense/librealsense/issues/2813
There is a guide to installing QTCreator on MacOS that Core could check to see if their setup of QTCreator is correct before they try to open and run the project.
https://www.ics.com/blog/getting-started-qt-and-qt-creator-macos

here is all result running in the Qt

my cmake's version is 3.11.1  .   And I dont know how to do next.
Oneday in January,I  got a "XXX  .pro" using "qmake",  but I forget how to get  a  "XXX  .pro" again.

Hi @Core055. I use libRealSense with Qt on Mac. From your error message, I'd say either there is not C/C++ compiler in the system, or more likely, the Kits in Qt are not correctly configured.
To double check the Kits, you can go to Preferences in the application menu (⌘ , shortcut), and look for Kits. Choose the kit you use to build the project from the list. It can be something like Desktop Qt 5.9.1 clang 64bit (default). Then, make sure the entries in C and C++ compiler are correct and point to existing binaries.
If you don't know what kit you are using, it is likely the one marked as default. Or you can find it by selecting Projects on the left sidebar (the one that contains the buttons Welcome, Edit, Design, Debug, etc), and looking at the selected entry under Build & Run.

Could you please show me how to open librealsense via qt or your .pro file how to import header files and libraries?Thank you,my project is around deadline…

This is how I do it:

First make sure you built librealsense. For example, in my case:

cd /Users/dorian3d/librealsense
mkdir build
cd build
cmake ..
make -j
sudo make install

I create a directory for a new application called sample_librs:

cd /Users/dorian3d/
mkdir sample_librs
cd sample_librs

This sample application contains two files:
main.cpp:
#include <iostream>
#include <librealsense2/rs.hpp>

int main() {
    std::cout << "hello world " << std::endl;

    rs2::context ctx;
    std::cout << ctx.query_devices().size() << " connected devices" << std::endl;
}

CMakeLists.txt:
cmake_minimum_required(VERSION 3.1.0)
project(sample)
set(CMAKE_CXX_STANDARD 11)
add_executable(sample main.cpp)

find_package(realsense2 REQUIRED)
target_include_directories(sample PRIVATE ${realsense_INCLUDE_DIR})
target_link_libraries(sample ${realsense2_LIBRARY})

Now you can open this project with Qt Creator. From the Qt Creator menu, choose File / Open File or Project... and find the CMakeLists.txt file created in step 2.

Qt Creator will ask what Kit you want to use for this project. I choose the kit by default which, in my case, uses Clang as C++ compiler, cmake as CMake Tool, and Unix Makefiles as CMake generator.
I tell Qt Creator to generate the building files in directory /Users/dorian3d/sample_librs/build and I click on button Configure Project.

At this point, Qt Creator runs cmake to configure the project. If it works ok, then you are already able to build the project and run it.

If you see an error like this:

CMake Error at CMakeLists.txt:6 (find_package):
  By not providing "Findrealsense2.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "realsense2", but CMake did not find one.

  Could not find a package configuration file provided by "realsense2" with
  any of the following names:

    realsense2Config.cmake
    realsense2-config.cmake

  Add the installation prefix of "realsense2" to CMAKE_PREFIX_PATH or set
  "realsense2_DIR" to a directory containing one of the above files.  If
  "realsense2" provides a separate development package or SDK, be sure it has
  been installed.

then cmake could not find libRealSense because either it is not built or it is not installed in a standard path. You can manually specify where to find libRealSense by going to the Projects tab in Qt Creator (as I explained in my previous comment) and set the realsense2_DIR entry to the directory that contains the file realsense2Config.cmake (you have to search for it first). Then click on Apply Configuration Changes.

Thank you so much !!!
but  when I do "make -j",there is something wrong:

ZCY-Pro:build zcy$ make -j [ 12%] Built target realsense-file [ 12%] Linking CXX shared library librealsense2.dylib ld: library not found for -lusb-1.0 clang: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [librealsense<IP_ADDRESS>.dylib] Error 1 make[1]: *** [CMakeFiles/realsense2.dir/all] Error 2 make: *** [all] Error 2

ZCY-Pro:build zcy$ make -j [ 12%] Built target realsense-file\n [ 12%] Linking CXX shared library librealsense2.dylib\n ld: library not found for -lusb-1.0\n clang: error: linker command failed with exit code 1 (use -v to see invocation)\n make[2]: *** [librealsense<IP_ADDRESS>.dylib] Error 1\n make[1]: *** [CMakeFiles/realsense2.dir/all] Error 2\n make: *** [all] Error 2

That sounds like you did not install libRealSense dependencies. Follow these instructions to install libRealSense from source on Mac: https://github.com/IntelRealSense/librealsense/blob/master/doc/installation_osx.md

Thank you ! it worked !

and  I  new a Qdialog

It's  correct!!

Thank you  so much !!!!!!


Added bulma classes to display 2 article cards for 3 suggested topics below the carousel

This feature will display 2 article cards for breaking news, world news, and entertainment news below the carousel. This will give the page more content, and allow the user to scroll through some articles

The articles for each of the categories are working as it should.


Incorrect Update Detection for Docker Images with Similar Tags

MqDockerUp reports updates for Docker containers even when the image in use has no actual updates available. In my case, for the image nicolargo/glances:latest-full, an update is reported, but manual comparison of the hash with those on DockerHub indicates the update is instead related to nicolargo/glances:ubuntu-latest-full.
Steps to Reproduce

Create a container using the image nicolargo/glances:latest-full (command or compose).
Start MqDU
Observe the update results.

Expected Behavior
MqDU should correctly identify and monitor the update status of the specific image used for the container (nicolargo/glances:latest-full), without confusion with similarly tagged images.
Actual Behavior
The service reports an update for nicolargo/glances:latest-full, but manual hash comparison confirms that the update pertains to nicolargo/glances:ubuntu-latest-full.
Possible Cause and Solution
By analyzing the code, the DockerHub API documentation, and manually testing the API, I found that <complete_api_url>/tags?name=<retrived_tag>, does not perform a check on the specific tag, but rather a search, ergo it finds whatever tag contains <retrived_tag>.
But, from these part of docs, using <complete_api_url>/tags/<retrived_tag> can parse the digest of the specific tag

https://github.com/MichelFR/MqDockerUp/blob/652bca1deb87aece66b9484009d25e63516ff4ad/src/registry-factory/DockerhubAdapter.ts#L34C5-L44C6


An option to show templates that use a feature in feature search

Seems like it would be useful.

Unfortunately, it seems there's no upstream enforcement of the featureIds field in templates.
oras pull ghcr.io/devcontainers/index:latest
jq . devcontainer-index.json | less

Which means this would require either an upstream (breaking) change or parsing the tarball of every template.


Fix test instructions, and refactor tests for consistency

There are a couple of problems with the instructions for running tests in the current project README:

pyxl_tests.py was renamed tests\test_basic.py
Since then, many more tests have been added and the README does not address how to run them all as a complete test suite.

It seems the newer tests have a different 'style' to the original pyxl_tests.py: the new tests use pytest-style, ie. plain asserts in functions rather than the unittest2-style consisting of assertEqual etc.
This suggests that the intended way of running the full test suite is with pytest.
This PR does the following:
a. Makes the test suite consistent with itself: changes any use of unittest2 style testing to pytest style testing comprised of asserts in functions and removes any unittest2 dependencies.
b. Adds instructions to the README for running the full test suite.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding feature direction and moving suppression rules to each feature

Description

Added feature direction capability to each feature so users can select if anomalies should only be considered if they actual values goes either above or below the expected value.
Moved suppressionRules into the feature creation and redesigned it,
Fixed a bug when we had multiple rules with negative values where the toast message was blank.
Additional slight wording changes on different form fields

Check List

[x] New functionality includes testing.

[x] All tests pass

[] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I manually tested your code and found two issues.
First, I tested bwc by creating a detector using cli. By default, every feature has two rules like
"rules": [
            {
                "action": "IGNORE_ANOMALY",
                "conditions": [
                    {
                        "feature_name": "deny max",
                        "threshold_type": "ACTUAL_OVER_EXPECTED_RATIO",
                        "operator": "LTE",
                        "value": 0.2
                    },
                    {
                        "feature_name": "deny max",
                        "threshold_type": "EXPECTED_OVER_ACTUAL_RATIO",
                        "operator": "LTE",
                        "value": 0.2
                    }
                ]
            }
        ]

But when I open the detector from UI, I can see only one rule:

Second, I am expecting that I cannot define a suppression rule from the opposite direction a user has selected. For example, when I select "Rise above expected value", I should not be able to see the "below the expected value" from the rule section. But I do see it:

I will address these issue, in addition, I missed on the part with the default rules, I will make sure we show them correctly in UI and also now for every detector with a feature direction we will have just that one default rule show along with the change on the UI so selection for only one shows.

A few thoughts.
First, for every detector with a feature direction we will have just that two identical default rules show along with the change.

Second, current UX will overwrite my rules when I am playing around directions. For example, my double direction rules will not come back once I re-select "Deviation in any direction". Before cx click save, you have the original rules in record. You can restore them back, right?

Third, is it a good experience to change customers' rules when I change direction? For example, original rules are "above".

When I change to "below", both rules changed to "below":

Should we just hide the "above" rules?


[backport] Add optimizers.MSVAG to documentation

Backport of #7183

[automatic post] Jenkins, test this please.

LGTM

Jenkins CI test (for commit a89616b0929b25e4126f71e36de62ebfebcb1699, target branch v6) succeeded!


Headphone Jack

Hi, first thanks a lot for this EFI, I had a OS crack in my 5480 and in Monterrey I had some issues to update MSOffice, I did an upgrade to Sonoma and it is great, I am testing after some adjusts and Headphone Jack is not working, I tested the phone and is ok, I insert a USB phone and is ok, but P2 plug is not, any suggestion or guidance to find the problem?
 Thanks For the solution


Update Raja and Umpire TPLs

Summary
This PR updates Axom to reflect API changes in Raja-v0.9.0 and Umpire-v1.0.0.

[x] Changes for Raja-v0.9.0
[x] Changes for Umpire-v0.1.0
[x] Update Raja and Umpire TPLs on LC

I am getting the following on rzansel:
In file included from /usr/tce/packages/cuda/cuda-10.1.168/include/cuda_runtime.h:83:
/usr/tce/packages/cuda/cuda-10.1.168/include/crt/host_config.h:140:2: error: -- unsupported clang version! clang
      version must be less than 9 and greater than 3.2
#error -- unsupported clang version! clang version must be less than 9 and greater than 3.2
 ^

Are we aware of this issue? Is there a known workaround?

I got things building with a new host-config that uses<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


Incorrect handling of arguments with the same property name

Swift argument parser doesn't handle properties with the same name under different option groups gracefully.
The following snippet throws an error when run with no arguments, but I would expect no required arguments:
import ArgumentParser

struct Foo: ParsableCommand {
    @Option(name: .long)
    var `bar`: String = ""

    @OptionGroup
    var group: Group

    func run() throws { }
}

struct Group: ParsableArguments {
    @Option(name: .customLong("baz"))
    var `bar`: String?
}

Foo.main()

Output:
Error: Missing one of: '--bar <bar>', '--baz <baz>'

USAGE: foo [--bar <bar>] [--baz <baz>]

OPTIONS:
  --bar <bar>
  --baz <baz>
  -h, --help              Show help information.

ArgumentParser version: 0.4.3
Swift version:
swift-driver version: 1.20.1 Apple Swift version 5.5 (swiftlang-13<IP_ADDRESS> clang-13<IP_ADDRESS>)
Target: arm64-apple-macosx11.0

Checklist

[x] If possible, I've reproduced the issue using the main branch of this package
[x] I've searched for existing GitHub issues

Just ran into this issue between a few OptionGroups I have defining common values between commands. The hack I used to get around the issue for now was to namespace the actual parsed value like this:
public struct ExampleOption: ParsableArguments {
    @Option(name: [.customLong("foo")])
    var _valueExampleOption: Int // Add a prefix _ and a suffix of the type name
    public var value: Int { _valueExampleOption }

    public init() {}
}

This let me preserve the usage of value while making it so things could properly parse and function.

Yeah, I've had the same issue as @bscothern with regards to having two ParsableArguments instances with the same internal field (eg. var enabled: Bool, in my case) and different .customLong(...) values, and they both overwrite each other. In my case, it's a @Flag.
If anyone has any pointers on where to start and/or the appropriate section to add a test case, I'm happy to investigate.

I've tracked down the source of the bug, and have a PR at #495. If you want to test out my solution, my fix is in the following branch on my fork of the project:
https://github.com/randomeizer/swift-argument-parser/tree/randomeizer/322-duplicate-fields-in-OptionGroup


Oreo Android 8 or Android 8.1

Hello there good sir of earth, you have problems in Android O SDK ... with wakefulbroadcast receiver app ends after 3 minutes ... mybe you should use Jobscheduler ... acording to android studio have a nice day .

i have same problem
app is good but not useable in android oreo
with wakefulbroadcast receiver app crashed after intetval time. you should use Jobscheduler instead

Do you have any solution for it. Like the code Poslano z mobilnega telefona Huawei-------- Izvirno sporočilo --------Zadeva: Re: [nickfox/GpsTracker] Oreo Android 8 or Android 8.1 (#99)Od: kia1349 Za: nickfox/GpsTracker Kp: banc123 ,Author i have same problem
app is good but not useable in android oreo
with wakefulbroadcast receiver app crashed after intetval time. you should use Jobscheduler instead
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/nickfox/GpsTracker","title":"nickfox/GpsTracker","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/nickfox/GpsTracker"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kia1349 in #99: i have same problem\r\napp is good but not useable in android oreo\r\n\r\nwith wakefulbroadcast receiver app crashed after intetval time. you should use Jobscheduler instead"}],"action":{"name":"View Issue","url":"https://github.com/nickfox/GpsTracker/issues/99#issuecomment-388858749"}}}
{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [nickfox/GpsTracker] Oreo Android 8 or Android 8.1 (#99)","sections":[{"text":"","activityTitle":"kia1349","activityImage":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","activitySubtitle":"@kia1349","facts":[]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{"commandName":"IssueComment","repositoryFullName":"nickfox/GpsTracker","issueId":99,"IssueComment":"{{IssueComment.value}}"}"}]},{"name":"Close issue","@type":"HttpPOST","target":"https://api.github.com","body":"{"commandName":"IssueClose","repositoryFullName":"nickfox/GpsTracker","issueId":99}"},{"targets":[{"os":"default","uri":"https://github.com/nickfox/GpsTracker/issues/99#issuecomment-388858749"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{"commandName":"MuteNotification","threadId":332322170}"}],"themeColor":"26292E"}

Just storing this here for later. Looks interesting.
https://code.tutsplus.com/tutorials/using-the-jobscheduler-api-on-android-lollipop--cms-23562

good job
this is another
http://www.vogella.com/tutorials/AndroidTaskScheduling/article.html

https://github.com/martinraj/tracking-location-provider-android
this is another tracking app with job scheduler

that one looks very promising.
n

ye
and look this one
https://github.com/hypertrack/smart-scheduler-android


Translation process

I have ever gave this idea on Gogs. Now I give it again.
I think we can develop a language editor UI on admin panel. It could simple, there are two columns, left is English, right is another, he can select one from the supported languages above right column.
Every line is a translate, left is english word, right is the special language. After finished the translation, he can save it. After that, he can go and look at the UI immediately. Of course, if he like, he can download the locale file and send a PR to gitea repo.

Sounds like reinventing the wheel to me. This is what specialized translation code does.

I really like the idea if the tool is kept simple, yet I still don't know if that should be port of gitea.

@lunny this Idea is good, but Gitea will lose standard among all installations, since the user will be able to customize your translations. With this, I think that will be more hard to we understand and solve possible issues about UI.

So we have to assign language tanslation maintainer for LGTM locale file PRs.

@lunny Then I think that's the way it's better.
Option to change translations, a big alert stating that the layout may break if you do not use the feature with care and a resource displaying when local translation isn't default from Gitea.
Whit this I think we can avoid possible issues as this
"Problem with right menu"
"
Guys, my menu is bigger and ugly, I'm opening this issue to solve this

"

@lunny ah, other problem, will be more easy to use translation on admin to XSS, because current translations have some html elements. A not a nice person can put similar to <script>getMy(document.cookie)</script> as example

Hi, I think that's great! Users should control the size of name themselves.

When ins't defined this question, isn't good idea at least change manually on files from Gogs to Gitea for first release?

My take on this is more related to backend than frontend.
Keep all translation-files in a separate repo (subtree for pulling into Gitea).
Pros:

Each new translation-update can be done as a separate branch, without having to rebase on gitea-updates every 5 minutes.
Each branch can be spun up as a separate container on gitea.io for easy testing (e.g. new_branch.translate.gitea.io)
If new translations are added in en_US on master, you can easily rebase without having to update Gitea (less error prone at least)
Translation-tools that speak git (e.g. Weblate ) can be used without fscking around with the gitea history

Cons:

Someone has to merge the translations back into Gitea when they are mainlined :trollface:

Feel free to pitch in on pros/cons for this, as this list is very biased and I can't really find any cons :confused:

Maybe we should also use a more mature format like gettext? :)

@tboerger we need a colaborative platform to be easy to any Gitea collaborator help, like Crowdin, Weblate, Pootle and Zanata.

I remember @tboerger has sent a request to Weblate?

https://weblate.org/en/hosting/ @tboerger has you apply on this?

On Thu, Jan 05, 2017 at 07:06:02PM -0800, Lunny Xiao wrote:

https://weblate.org/en/hosting/ @tboerger has you apply on this?

I've made a request but never got an answer.
Never deployed it either so dunno how hard or easy it would be.

We could host weblate on our own server

Hi guys,
I can host on my servers too.
--
"O que quer que você faça na vida, será insignificante. Mas é muito
importante que você o faça... por que ninguém mais o fará." Gandhi
"Whatever you do will be insignificant, but it is very important that you
do it... because no one else will it." Gandhi

Joubert "RedRat" - Consultor em tecnologia - Technology consultant
/me at Linkedin http://br.linkedin.com/in/joubertredrat/ and Github
https://github.com/joubertredrat/
~(,,"> RedRat Consultoria
2017-01-08 7:54 GMT-02:00 Bwko<EMAIL_ADDRESS>
We could host weblate on our own server
https://github.com/WeblateOrg/weblate/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/go-gitea/gitea/issues/114#issuecomment-271141093, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABczF5ObntS5fhZ5YsHT_9WELYACXrbXks5rQLJBgaJpZM4KsByg
.

If we cannot received the response some days, we could consider host it on our server.

This sound suggestive :+1:
https://github.com/anthonynsimon/parrot

It was already discussed and proposed, so yes. Considering it.

So let's setup parrot and close this issue? @tboerger @bkcsoft any idea?

Parrot doesn't support the ini format, so we most use weblate or something else

@tboerger Are you sure it doesn't?

@tboerger Are you sure it doesn't?

Yes, I'm sure: https://github.com/anthonynsimon/parrot/tree/master/parrot-api/export

It seems the interface is simple so that we can write an ini one using the same library with Gitea's configuration using.

It seems the interface is simple so that we can write an ini one using the same library with Gitea's configuration using.

That sounds good, so somebody should do that and we will see how long it takes to get accepted. But beside that I personally prefer MariaDB, this supports only PostgreSQL.

And maybe we should move this to v1.2?

Parrot is pretty chaotic to setup, weblate doesn't directly support the ini format, so I have requested an OSS project on Crowdin and it have already been approved: https://crowdin.com/project/gitea

Does crowdin has an API?

Of course it got

So how should we copy TRANSLATION back to this repository?

I'll look at integrating this during the weekend.
Seems like I need 2 commands, push and pull.
push

on merge master check if translations are updated
upload to CrowdIn

pull

check if translations have been updated
pull changes from CrowdIn
add, commit, push, create PR (why of course, nothing gets in w/o reviews 😂 )

further extension on push is if a translation other than en_US is changed

pull
apply change
if no merge-conflicts, add,commit,merge,PR

I probably won't have time to check this in the near future


New toolbar icons

New Icons in use for the toolbar mode, and the edit mode submenu. The buttons' color/text now changes while hovering instead of its background color changing.

Before
Before

After
After

Very nice!


Unable to update Composer

Describe the bug
I have attached the gif that'd give an overview of what's happening. This issue popped up in earlier versions as well 4813
For the context, I tried both options Only me (user) or Everyone while installing Composer. I am also the administrator of this new machine.
Version
1.3
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to 'Help'
Click on 'Check for Updates'
See error

Expected behavior
It should have updated the Composer.
Screenshots

After this, I got this error:

Additional context

Hmm. Sorry to hear about your troubles @arafattehsin. I just picked up the latest nightly on Mac and it worked fine.

On Windows we ask users install the application for all users.
The following is a heavier operation but should put you in a clean install state:

Uninstall Composer (you won't lose any Bot Projects)
Delete your entire @bfc directory under C:\Users\AT\AppData\Local\. Composer will recreate this for you.
Reinstall Composer 1.3.0 here and turn on Early adopters to pick up the latest nightly

Hmm. Sorry to hear about your troubles @arafattehsin. I just picked up the latest nightly on Mac and it worked fine.

On Windows we ask users install the application for all users.
The following is a heavier operation but should put you in a clean install state:

Uninstall Composer (you won't lose any Bot Projects)
Delete your entire @bfc directory under C:\Users\AT\AppData\Local\. Composer will recreate this for you.
Reinstall Composer 1.3.0 here and turn on Early adopters to pick up the latest nightly

@cwhitten I can repro this on windows after delete entire @bfc and old composer as well.

@cwhitten I can repro this on windows after delete entire @bfc and old composer as well.

Update: this is largely related to somehow the permission to the disk is not correctly setup or the folder is occupied by another process somehow, still in the processing of understanding the exact cause. But at this moment, we don't think this is a ship blocker, because we are using the default setup for electron auto-update mechanism without doing any specific thing here, and it works well for all the cases i saw except @hibrenda's.

Update: this is largely related to somehow the permission to the disk is not correctly setup or the folder is occupied by another process somehow, still in the processing of understanding the exact cause. But at this moment, we don't think this is a ship blocker, because we are using the default setup for electron auto-update mechanism without doing any specific thing here, and it works well for all the cases i saw except @hibrenda's.

We figured out it's a race condition when autoUpdate = true in Brenda's case. @arafattehsin can you check if set autoUpdate = true, if yes, can you try turn if off?

We figured out it's a race condition when autoUpdate = true in Brenda's case. @arafattehsin can you check if set autoUpdate = true, if yes, can you try turn if off?

@boydc2014  It's still the same re: autoUpdate = false.

@boydc2014  It's still the same re: autoUpdate = false.

@boydc2014 It's still the same re: autoUpdate = false.

Can you try the following

start composer, assuming 1.3.0
turn off Composer's auto update in settings page
quit composer // this is necessary, because in step 1, the auto update already started working
start composer, and check auto update is off or not, if it's off, click "check for updates"

@boydc2014 It's still the same re: autoUpdate = false.

Can you try the following

start composer, assuming 1.3.0
turn off Composer's auto update in settings page
quit composer // this is necessary, because in step 1, the auto update already started working
start composer, and check auto update is off or not, if it's off, click "check for updates"

Thanks @boydc2014 - your series of steps were super helpful!
 - I have made a clip for your reference, there was some error which I think should be handled.

Thanks @boydc2014 - your series of steps were super helpful!
 - I have made a clip for your reference, there was some error which I think should be handled.

Happy to close this issue as it has resolved my problem though! Thanks team. 🤘

Happy to close this issue as it has resolved my problem though! Thanks team. 🤘

Happy to close this issue as it has resolved my problem though! Thanks team. 🤘

Thanks, yes, we are aware of this issue, so i opened up #5551 to track the issue. Once that been resolved, it should deliver the expected and hopefully users won't have to do the above steps to work around that.

Happy to close this issue as it has resolved my problem though! Thanks team. 🤘

Thanks, yes, we are aware of this issue, so i opened up #5551 to track the issue. Once that been resolved, it should deliver the expected and hopefully users won't have to do the above steps to work around that.


Adds shadow to loginbox

This PR adds a shadow to loginbox. I've also adds a new config option "loginshadow" to customize the color of the shadow.

Also I'm ready to merge multi-monitor whenever you are. I'm guessing not so many people are following the project here. I was hoping for feedback from people with different setups, but nothing yet. But it's been working fine for me on my desktop with two displays and my laptop.


[DO NOT MERGE] Auto PR to update dependencies of pilot

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
e8568aac2c7eb05f5887e54cd608a0bdc24ea2a6
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Merge Failures

Having different failure events for each module doesn't make sense when they all do the exact same thing and you can check the module by looking at what the Failure is responding to. Bring them all under one tent as a "Failure" module even.

Done in https://github.com/marrus-sh/laboratory/commit/4859a4b3aa9180222caf8df19fde78825e8f9261


Speech recognition supports offline mode ?

Use setPreferOffline(true)
https://github.com/gotev/android-speech/blob/dfc04d0e2aba569966dee065e8aa9146e1b852ef/speech/src/main/java/net/gotev/speech/Speech.java#L525-L535


Add a group-focus-within variant (and others)

Inspired by tailwindcss-interaction-variants, group-focus-within and other variants should be added to extend the functionality of this project.

I just developed a new plugin very similar to this one that has all Tailwind 3 features.
Check it out here: https://github.com/onmax/tailwindcss-labeled-groups


chore(main): release 0.37.9

:robot: I have created a release beep boop
0.37.9 (2023-06-30)
Miscellaneous Chores

deps: update dependency gradle to v7.6.2 (#355) (2651217)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CCXXXI/ecg_monitor/releases/tag/v0.37.9 :sunflower:


Upgrade to Picocli 2.0.0

[ ] Rework version and help display https://github.com/remkop/picocli/issues/162 https://github.com/remkop/picocli/issues/145
[ ] Consider https://github.com/remkop/picocli/issues/157 could be useful
[ ] Rework subcommand https://github.com/remkop/picocli/issues/152

Any chance of upgrading to 3.0.0?

If released yes i will directly upgrade to latest.

@bobtiernay-okta I just created a new branch picocli-3.0.0 where I upgrade picocli dep to 3.0.0-beta-1 (latest version in maven central, I will upgrade to beta-2 as soon as is will be available on maven central)
In addition I pushed the artifact with version
<dependency>
    <groupId>com.kakawait</groupId>
    <artifactId>picocli-spring-boot-starter</artifactId>
    <version>1.0.0-alpha-1</version>
</dependency>

Be careful I just pushed can take some time before available on maven central
Why alpha?
For two main reasons:

Not heavily tested
Not specific integration, just upgraded deps and fix compilation/runtime issues (in order to take advantage of new things/features)


add status badge for sonarcloud

https://github.com/marketplace/actions/regex-issue-labeler
https://github.com/marketplace/actions/auto-label


increasing file chunk size

Thanks for the great library.
I need to stream csv files which sometimes are huge. for instance I have a csv file which consists of 1000 columns.
inside the file.on('data', ()=>{}) event upon receiving the chunks, I get only two rows due to the number of columns and this causes computation overhead.
Is there a way you can set the chunk size for each file coming through the file.on('data', ()=>{})
I have already tried setting the highWaterMark and  fileHwm config while initializing busboy.
let busboy = new Busboy({ headers: req.headers, highWaterMark: 1024000, fileHwm:1024000});
but there was no luck.
Thanks in advance for your help.

This is more of a general node streams thing, but instead of using 'data' events, you could utilize file.read(n) and the 'readable' event instead if you want to read a specific number of bytes (where possible). Otherwise no, there is no way to increase the chunk size because either way the memory is getting buffered somewhere, whether it'd happen within node core or by the end user.

@yektayazdani How about you buffer these chunks together until you got big enough batch(like 50 rows) to start processing?


RangeError during Flutter Android build since v1.17.1

Steps to Reproduce
When I run the command flutter build appbundle with version 1.12 or with version 1.19.x (on master) everything works fine and the bundle is successfully created. But with 1.17.1 and 1.17.2 I get the following error:
Unhandled exception:
RangeError (index): Invalid value: Valid value range is empty: 0
#0      List.[] (dart:core-patch/growable_array.dart:146:60)
#1      SummaryCollector.createSummary (package:vm/transformations/type_flow/summary_collector.dart:691:47)
...
Target kernel_snapshot failed: Exception: Errors during snapshot creation: null
build failed.
FAILURE: Build failed with an exception.

Where:
Script 'E:\Programmieren\Flutter\packages\flutter_tools\gradle\flutter.gradle' line: 882

What went wrong:
Execution failed for task ':app:compileFlutterBuildRelease'.

FAILURE: Build failed with an exception.

Where:
Script 'E:\Programmieren\Flutter\packages\flutter_tools\gradle\flutter.gradle' line: 882

What went wrong:
Execution failed for task ':app:compileFlutterBuildRelease'.

Process 'command 'E:\Programmieren\Flutter\bin\flutter.bat'' finished with non-zero exit value 1

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 19s
Doctor:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel unknown, v1.17.1, on Microsoft Windows [Version 10.0.18362.295], locale de-DE)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.0)
[√] Android Studio (version 3.6)
[√] VS Code (version 1.44.2)
[√] Connected device (1 available)
• No issues found!

Also iphonesimulator failed. :(
Launching lib/main.dart on iPhone 11 in debug mode...
Running pod install...                                              2.7s
Running Xcode build...
Xcode build done.                                           77.4s
Could not find the built application bundle at build/ios/iphonesimulator/Runner.app.
Error launching application on iPhone 11.

/cc @alexmarkov @jensjoha

It looks like number of member.forwardingStubSuperTarget.function.namedParameters doesn't match member.function.namedParameters for a forwarding stub. @johnniwinther Do you know if there were any bugs or fixes related to that?
@devjeff Could you provide an example (or the whole application, if it is open-source) which could be used to reproduce the problem?

There hasn't been any recent changes to forwarding stubs. Last change was in February (implementing the consolidated model for mixed inheritance which shares implementation with the creation of forwarding stubs).
Sounds like we should assert the relation between member.forwardingStubSuperTarget.function.namedParameters and member.function.namedParameters in the verifier.

Hey, the app is not open source unfortunately. I have tried to create a fresh flutter app from scratch and could not build a bundle successfully. I tried to copy some parts of the original app, but still didn't find the code that makes the build break. I'll try to modify it further. Hopefully I can find the problematic part soon.

I wasn't able to extract the relevant code part that causes this problem. However, as the problem no longer occurs with version 1.20.1, I think, the issue can be closed.

Hi @devjeff
Given your last message I feel safe to close this issue,
if you disagree please write in the comments
and I will reopen it.
Thank you


Revert "upgrade ucx to 1.17.0"

Reverts NVIDIA/spark-rapids#11147
We observed issues running UCX with RoCE in the new version. We should revert to 1.16 while we work on resolving said issues.

build


add api7:2023 owasp api top 10

Add official references to SSRF.  Should be prove useful for those thinking about security :-)

@zekth  - Hi, can I get a review? Are there community meetings to discuss issues, PRs, etc?  thanks.

Looks good, thank you for the contribution!


Add additional test cases for DRILL-3474 based on previous review

Hi Rahul,
I added the additional test based on your previous comments. Can you please review the new tests?
Thanks,
Krystal

+1 LGTM


[TW#16551] Buffer overflow in ipc.c

In components/esp32/ipc.c
``80    const char* task_names[2] = {"ipc0", "ipc1"};
81     for (int i = 0; i < portNUM_PROCESSORS; ++i) {
82         s_ipc_sem[i] = xSemaphoreCreateBinary();
83         portBASE_TYPE res = xTaskCreatePinnedToCore(ipc_task, task_names[i], CONFIG_IPC_TASK_STACK_SIZE, (void*) i,
84                                                     configMAX_PRIORITIES - 1, &s_ipc_tasks[i], i);
85         assert(res == pdTRUE);
86     }
If portNUM_PROCESSORS is ever defined to be more than 2, task_names will be accessed past its end and tasks will have memory contents as names.

Thanks @drwheeler point it out, it's safe currently because we only support 2 CPU. Maybe it will be better if we can change it to support any number of CPUs.

Thanks @drwheeler , I have modify this code

Thanks @drwheeler, I have modify this code.
commit ID:https://gitlab.espressif.cn:6688/idf/esp-idf/merge_requests/1605


out of memory: select * from  where time > now() - 1m in over million rows

Hi,
We have a little instance running up in a 2-core / 8gb RAM machine here. We have a series with over a million writes, with constant writes (80k/hour ish).
Influx is dying of OOM all the time when querying with a minute long search, not sure what we're doing wrong.
Requests are being written with the write endpoint and the mem usage during writes is constantly in 3-4GB range.
We are writing 8 tags and 2 fields and we're using tsm1 engine, using nightly, config file is as follows:
### Welcome to the InfluxDB configuration file.

# Once every 24 hours InfluxDB will report anonymous data to m.influxdb.com
# The data includes raft id (random 8 bytes), os, arch, version, and metadata.
# We don't track ip addresses of servers reporting. This is only used
# to track the number of instances running and the versions, which
# is very helpful for us.
# Change this option to true to disable reporting.
reporting-disabled = false

###
### [meta]
###
### Controls the parameters for the Raft consensus group that stores metadata
### about the InfluxDB cluster.
###

[meta]
  dir = "/var/lib/influxdb/meta"
  hostname = "localhost"
  bind-address = ":8088"
  retention-autocreate = true
  election-timeout = "1s"
  heartbeat-timeout = "1s"
  leader-lease-timeout = "500ms"
  commit-timeout = "50ms"
  cluster-tracing = false

  # If enabled, when a Raft cluster loses a peer due to a `DROP SERVER` command,
  # the leader will automatically ask a non-raft peer node to promote to a raft
  # peer. This only happens if there is a non-raft peer node available to promote.
  # This setting only affects the local node, so to ensure if operates correctly, be sure to set
  # it in the config of every node.
  raft-promotion-enabled = true

###
### [data]
###
### Controls where the actual shard data for InfluxDB lives and how it is
### flushed from the WAL. "dir" may need to be changed to a suitable place
### for your system, but the WAL settings are an advanced configuration. The
### defaults should work for most systems.
###

[data]
  dir = "/var/lib/influxdb/data"

  # Controls the storage engine used for new shards. Engines available are b1,
  # bz1, and tsm1. b1 was the original default engine from 0.9.0 to 0.9.2. bz1
  # has been the default engine since 0.9.3. tsm1 was introduced in 0.9.5 and is
  # currently EXPERIMENTAL. Consequently, data written into the tsm1 engine may
  # need to be wiped between upgrades.
  engine ="tsm1"

  # The following WAL settings are for the b1 storage engine used in 0.9.2. They won't
  # apply to any new shards created after upgrading to a version > 0.9.3.
  max-wal-size = 104857600 # Maximum size the WAL can reach before a flush. Defaults to 100MB.
  wal-flush-interval = "10m" # Maximum time data can sit in WAL before a flush.
  wal-partition-flush-delay = "2s" # The delay time between each WAL partition being flushed.

  # These are the WAL settings for the storage engine >= 0.9.3
  wal-dir = "/var/lib/influxdb/wal"
  wal-logging-enabled = true
  data-logging-enabled = true

  # When a series in the WAL in-memory cache reaches this size in bytes it is marked as ready to
  # flush to the index
  # wal-ready-series-size = 25600

  # Flush and compact a partition once this ratio of series are over the ready size
  # wal-compaction-threshold = 0.6

  # Force a flush and compaction if any series in a partition gets above this size in bytes
  # wal-max-series-size = 2097152

  # Force a flush of all series and full compaction if there have been no writes in this
  # amount of time. This is useful for ensuring that shards that are cold for writes don't
  # keep a bunch of data cached in memory and in the WAL.
  wal-flush-cold-interval = "10m"

  # Force a partition to flush its largest series if it reaches this approximate size in
  # bytes. Remember there are 5 partitions so you'll need at least 5x this amount of memory.
  # The more memory you have, the bigger this can be.
  wal-partition-size-threshold = 20971520

  # Whether queries should be logged before execution. Very useful for troubleshooting, but will
  # log any sensitive data contained within a query.
  # query-log-enabled = true

  # Settings for the TSM engine

  # CacheMaxMemorySize is the maximum size a shard's cache can
  # reach before it starts rejecting writes.
  cache-max-memory-size = 524288000

  # CacheSnapshotMemorySize is the size at which the engine will
  # snapshot the cache and write it to a TSM file, freeing up memory
  # cache-snapshot-memory-size = 26214400

  # CacheSnapshotWriteColdDuration is the length of time at
  # which the engine will snapshot the cache and write it to
  # a new TSM file if the shard hasn't received writes or deletes
  # cache-snapshot-write-cold-duration = "1h"

  # MinCompactionFileCount is the minimum number of TSM files
  # that need to exist before a compaction cycle will run
  # compact-min-file-count = 3

  # CompactFullWriteColdDuration is the duration at which the engine
  # will compact all TSM files in a shard if it hasn't received a
  # write or delete
  # compact-full-write-cold-duration = "24h"

  # MaxPointsPerBlock is the maximum number of points in an encoded
  # block in a TSM file. Larger numbers may yield better compression
  # but could incur a performance peanalty when querying
  # max-points-per-block = 1000

###
### [hinted-handoff]
###
### Controls the hinted handoff feature, which allows nodes to temporarily
### store queued data when one node of a cluster is down for a short period
### of time.
###

[hinted-handoff]
  enabled = true
  dir = "/var/lib/influxdb/hh"
  max-size =<PHONE_NUMBER>
  max-age = "168h"
  retry-rate-limit = 0

  # Hinted handoff will start retrying writes to down nodes at a rate of once per second.
  # If any error occurs, it will backoff in an exponential manner, until the interval
  # reaches retry-max-interval. Once writes to all nodes are successfully completed the
  # interval will reset to retry-interval.
  retry-interval = "1s"
  retry-max-interval = "1m"

  # Interval between running checks for data that should be purged. Data is purged from
  # hinted-handoff queues for two reasons. 1) The data is older than the max age, or
  # 2) the target node has been dropped from the cluster. Data is never dropped until
  # it has reached max-age however, for a dropped node or not.
  purge-interval = "1h"

###
### [cluster]
###
### Controls non-Raft cluster behavior, which generally includes how data is
### shared across shards.
###

[cluster]
  shard-writer-timeout = "5s" # The time within which a remote shard must respond to a write request.
  write-timeout = "10s" # The time within which a write request must complete on the cluster.

###
### [retention]
###
### Controls the enforcement of retention policies for evicting old data.
###

[retention]
  enabled = true
  check-interval = "30m"

###
### [shard-precreation]
###
### Controls the precreation of shards, so they are available before data arrives.
### Only shards that, after creation, will have both a start- and end-time in the
### future, will ever be created. Shards are never precreated that would be wholly
### or partially in the past.

[shard-precreation]
  enabled = true
  check-interval = "10m"
  advance-period = "30m"

###
### Controls the system self-monitoring, statistics and diagnostics.
###
### The internal database for monitoring data is created automatically if
### if it does not already exist. The target retention within this database
### is called 'monitor' and is also created with a retention period of 7 days
### and a replication factor of 1, if it does not exist. In all cases the
### this retention policy is configured as the default for the database.

[monitor]
  store-enabled = true # Whether to record statistics internally.
  store-database = "_internal" # The destination database for recorded statistics
  store-interval = "10s" # The interval at which to record statistics

###
### [admin]
###
### Controls the availability of the built-in, web-based admin interface. If HTTPS is
### enabled for the admin interface, HTTPS must also be enabled on the [http] service.
###

[admin]
  enabled = true
  bind-address = ":8083"
  https-enabled = false
  https-certificate = "/etc/ssl/influxdb.pem"

###
### [http]
###
### Controls how the HTTP endpoints are configured. These are the primary
### mechanism for getting data into and out of InfluxDB.
###

[http]
  enabled = true
  bind-address = ":8086"
  auth-enabled = false
  log-enabled = true
  write-tracing = false
  pprof-enabled = false
  https-enabled = false
  https-certificate = "/etc/ssl/influxdb.pem"

###
### [[graphite]]
###
### Controls one or many listeners for Graphite data.
###

[[graphite]]
  enabled = false
  # database = "graphite"
  # bind-address = ":2003"
  # protocol = "tcp"
  # consistency-level = "one"
  # name-separator = "."

  # These next lines control how batching works. You should have this enabled
  # otherwise you could get dropped metrics or poor performance. Batching
  # will buffer points in memory if you have many coming in.

  # batch-size = 1000 # will flush if this many points get buffered
  # batch-pending = 5 # number of batches that may be pending in memory
  # batch-timeout = "1s" # will flush at least this often even if we haven't hit buffer limit
  # udp-read-buffer = 0 # UDP Read buffer size, 0 means OS default. UDP listener will fail if set above OS max.

  ## "name-schema" configures tag names for parsing the metric name from graphite protocol;
  ## separated by `name-separator`.
  ## The "measurement" tag is special and the corresponding field will become
  ## the name of the metric.
  ## e.g. "type.host.measurement.device" will parse "server.localhost.cpu.cpu0" as
  ## {
  ##     measurement: "cpu",
  ##     tags: {
  ##         "type": "server",
  ##         "host": "localhost,
  ##         "device": "cpu0"
  ##     }
  ## }
  # name-schema = "type.host.measurement.device"

  ## If set to true, when the input metric name has more fields than `name-schema` specified,
  ## the extra fields will be ignored.
  ## Otherwise an error will be logged and the metric rejected.
  # ignore-unnamed = true

###
### [collectd]
###
### Controls the listener for collectd data.
###

[collectd]
  enabled = false
  # bind-address = ""
  # database = ""
  # typesdb = ""

  # These next lines control how batching works. You should have this enabled
  # otherwise you could get dropped metrics or poor performance. Batching
  # will buffer points in memory if you have many coming in.

  # batch-size = 1000 # will flush if this many points get buffered
  # batch-pending = 5 # number of batches that may be pending in memory
  # batch-timeout = "1s" # will flush at least this often even if we haven't hit buffer limit
  # read-buffer = 0 # UDP Read buffer size, 0 means OS default. UDP listener will fail if set above OS max.

###
### [opentsdb]
###
### Controls the listener for OpenTSDB data.
###

[opentsdb]
  enabled = false
  # bind-address = ":4242"
  # database = "opentsdb"
  # retention-policy = ""
  # consistency-level = "one"
  # tls-enabled = false
  # certificate= ""
  # log-point-errors = true # Log an error for every malformed point.

  # These next lines control how batching works. You should have this enabled
  # otherwise you could get dropped metrics or poor performance. Only points
  # metrics received over the telnet protocol undergo batching.

  # batch-size = 1000 # will flush if this many points get buffered
  # batch-pending = 5 # number of batches that may be pending in memory
  # batch-timeout = "1s" # will flush at least this often even if we haven't hit buffer limit

###
### [[udp]]
###
### Controls the listeners for InfluxDB line protocol data via UDP.
###

[[udp]]
  enabled = false
  # bind-address = ""
  # database = "udp"
  # retention-policy = ""

  # These next lines control how batching works. You should have this enabled
  # otherwise you could get dropped metrics or poor performance. Batching
  # will buffer points in memory if you have many coming in.

  # batch-size = 1000 # will flush if this many points get buffered
  # batch-pending = 5 # number of batches that may be pending in memory
  # batch-timeout = "1s" # will flush at least this often even if we haven't hit buffer limit
  # read-buffer = 0 # UDP Read buffer size, 0 means OS default. UDP listener will fail if set above OS max.

  # set the expected UDP payload size; lower values tend to yield better performance, default is max UDP size 65536
  # udp-payload-size = 65536

###
### [continuous_queries]
###
### Controls how continuous queries are run within InfluxDB.
###

[continuous_queries]
  log-enabled = true
  enabled = true
  # run-interval = "1s" # interval for how often continuous queries will be checked if they need to run

this seems to be a running theme, looking the last 3 weeks to tickets. Is there any max memory set per query ?

@brenol the total number of points in the series isn't relevant to the query performance, only the number of points matching the selection criteria. There's no reason that a query sampling ~25 points should OOM.
What do the logs show? Does the query still OOM if you restrict it to the prior 30 seconds? 15 seconds? Can you share the actual query?
@mhiller there is no current way to limit RAM or kill running queries.

@beckettsean
I'm doing the following select:
> select count(elapsed) from send where time > now() - 10s
ERR: Get http://localhost:8086/query?db=sm&epoch=ns&q=select+count%28elapsed%29+from+send+where+time+%3E+now%28%29+-+10s: EOF
/run.sh: line 143:    10 Killed                  exec influxd -config=${CONFIG_FILE}

Thanks!

@brenol is the machine almost completely out of RAM before the queries are run? What does the resident set size look like before and during the query? I see no reason why that query should OOM the system.
Does it always OOM for the same query? Are there queries that never OOM?

@beckettsean nope, it's usually in the 3-4 GB area when we start running the query. Please note that it has 8GB RAM.
It always OOM for all queries in that database. Querying in another one has no issues at all (however, it barely has 10000 rows).
If there's anything else I can search for you (in logs), please tell me. I'm running it in the InfluxCli and it's just outputting err and then I see that the system killed the process.
Thanks!

Please include the logs when it OOMs. I have never heard of a system where all queries on a particular database OOM, but it sounds like corruption, possibly. I can think of no sensible reason why a query sampling a few points would need 3-4GB of RAM.
How are the points written to the database? Is that a different method than the points written to the database that doesn't OOM?

I have seen a few times that it did panic, however, it was a simple runtime error: out of memory. Most of the time there isn't any time for a panic to show up, though, as the system kills influxdb.
We are writing in the following way (concurrently, obviously):
curl -X POST "http://localhost:8086/write?db=sm&u=user&password=pass123" -d "sm,number=10902901,profile=03.12,ttl=3,la=212,parts=2,status=0 elapsed=10.0029,value=1"

The database that doesn't OOM writes using the Go client, and writes in batches (different data though).

If you aren't batching the writes to the sm database, perhaps it's the HTTP stack that's leading to OOM issues. 20-25 HTTP connections per second is non-trivial, and then the query introduces more. Is it possible to batch the writes and see if that mitigates the behavior in any way?
I'm not certain that this is the issue, and I have no mechanism to propose, but un-batched HTTP writes are rarely a good idea beyond trivial testing.

@beckettsean
We have also tried with disabled HTTP writes, and database keeps OOMing upon query. I'll try to build a test script to see if the problem can be reproduced.
Thanks!

I am experiencing the same or similar issue. I am running a single cluster with 8 Gb of ram. 3-4 Gb of ram is available at the time of query.  I am running on a Centos6 AWS node.
if i run a basic but large query I don't get any problems
select * from sample  / around 6000 results with 20 columns
but if i run a small but more complex it fails intermittently
SELECT mean("ssid_scan_time") FROM "sample" WHERE "device_id" = 'hgf_hfx_17' AND time ><PHONE_NUMBER>s and time < now() GROUP BY time(1m) fill(null)  / roughly 100 results with 2 columns

@benbjohnson some issues with complex but small returns for the old query engine, something to consider with the refactor.

@beckettsean the new QE should have a low, fixed memory usage per series. We'll have some optimization to do around high series counts (eg 1m) but reasonable series counts should perform well.

@jeremyforan can you be more specific about "fails intermittently"? Every other time? One in 10 times? Three times in a row and then not for 20 more tries?
I'd like to investigate more what specific complexity in the query causes challenges. What about queries like:

SELECT mean("ssid_scan_time") FROM "sample" WHERE "device_id" = 'hgf_hfx_17' AND time < now() - 20m GROUP BY time(1m) fill(null)
SELECT COUNT("ssid_scan_time") FROM "sample" WHERE "device_id" = 'hgf_hfx_17' AND time ><PHONE_NUMBER>s and time < now() GROUP BY time(1m) fill(null)
SELECT MEAN("ssid_scan_time") FROM "sample" WHERE "device_id" = 'hgf_hfx_17' AND time ><PHONE_NUMBER>s and time < now()

The first uses relative time range behavior rather than absolute time range behavior. The second uses MEAN() rather than COUNT(). The third uses raw data returns rather than GROUP BY.

I ran the first query 10 times without issue.
The second query crashes influx each time I run it
I ran the last query 10 times without issue.
I should note that I'm not drafting the queries manually but rather using grafana.  if I run a query with a time window of 5 minutes, seems to work fine.  If I expand it the window the queries break.  These same dashboards worked in previous versions of influxdb and grafana.
Would it help to post the grafana dashboards?

Should be fixed in 0.11


Use residentKey instead of requireResidentKey

Resolves #73

It just occurred to me that perhaps we should provide both keys, in case the deprecated requireResidentKey is still used somewhere.

@type1fool Please merge this one first. I rebased the other 2 off this one so their diffs include this work.

Good stuff @peaceful-james!


Parse software licences from scripts

Bpftrace currently assumes that all scripts it is given to run are GPL licensed: https://github.com/bpftrace/bpftrace/blob/9ef8cb42a941a97e1277f38aad5fad93a42404bd/src/attached_probe.cpp#L676
This is not always true, even for scripts in our own repository: https://github.com/bpftrace/bpftrace/blob/9ef8cb42a941a97e1277f38aad5fad93a42404bd/tools/bashreadline.bt#L13
In order to avoid further licensing issues, particularly once we have ahead of time compilation and source code isn't necessarily distributed with binaries, we should start checking licences in programs we're loading.
Maybe we could build in support for SPDX License IDs.

I assume we'd want to add new syntax, right?
Also this is something we should probably talk to a real lawyer about. I've wondered before if high level non-GPL code can be used to generate GPL machine code. If not, it seems like we have to force the user to declare a license and restrict the use of non-GPL kernel helpers accordingly

I suppose it depends on your understanding of the term "derivative work". Which I am absolutely not qualified to interpret


RYA-280-Periodic Query Service

This pull request contains four main components.  The first component
is the PeriodicQueryMetadata and observer framework for Fluo.  This capability
adds a periodic bin id to BindingSets as they percolate through Fluo.  The second component is a
PeriodicQueryResultStorage API, which essentially wraps existing PCJTables class and allows results to be queried based on their periodic bin id.  The third capability is the external PeriodicQueryService that generates periodic notifications.  When a notification is generated, it uses the time stamp of that notification to poll the PeriodicQueryResultStorage table for results whose periodic bin matches the notification's time stamp.  It then exports the matching results to Kafka.  The fourth and final component is a Batch Processing framework that allows Fluo to batch any process or task that could lead to an out of memory exception.  This can occur when Fluo issues a scan to its underlying table in the middle of
a transaction.  Using the Batch framework, a BatchInformation object is written to the BatchObserver column (the BatchInformation objects consist of a task (add, delete, update), a batch size, the column that the task will be applied to, and the query node id that it will be applied to).   Additional information is included as well, such as the Span (range of data that task is applied to).  When the BatchObserver processes a BatchInformation object, it performs the indicated task until it reaches the batch size, at which point it creates a new BatchInformation object with info detailing the stopping point of the last processing stage.  That BatchInformation object is then fed back to the BatchObserver, and this process continues until the task can be completed before reaching the batch size.
Tests
Integration tests were written to test that the PeriodicQueryMetadata
was being inserted correctly into Fluo, that BindingSets were being binned
correctly, and that all components of the external PeriodicQueryService were
operating as expected.  Integration tests can be found in rya.periodic.service.integration.tests
and rya.pcj.fluo.integration.
Links
Jira
Checklist

[ ] Code Review
[X] Squash Commits

People To Reivew
Andrew Smith, Aaron Mihalik

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/261/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/264/Build result: FAILURE[...truncated 8.58 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 57:05 min[INFO] Finished at: 2017-07-18T18:37:52+00:00[INFO] Final Memory: 204M/1043M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal on project rya.geoindexing: Could not resolve dependencies for project org.apache.rya:rya.geoindexing:jar:3.2.11-incubating-SNAPSHOT: Failed to collect dependencies at org.locationtech.geomesa:geomesa-accumulo-datastore_2.11:jar:1.3.0-m1 -> org.locationtech.geomesa:geomesa-feature-all_2.11:jar:1.3.0-m1 -> org.locationtech.geomesa:geomesa-feature-kryo_2.11:jar:1.3.0-m1 -> org.geotools:gt-process-feature:jar:15.1 -> org.geotools:gt-process:jar:15.1 -> org.geotools:gt-coverage:jar:15.1 -> it.geosolutions.imageio-ext:imageio-ext-tiff:jar:1.1.15: Failed to read artifact descriptor for it.geosolutions.imageio-ext:imageio-ext-tiff:jar:1.1.15: Could not transfer artifact it.geosolutions.imageio-ext:imageio-ext-tiff:pom:1.1.15 from/to geowave-maven-releases (https://s3.amazonaws.com/geowave-maven/release): Access denied to: https://s3.amazonaws.com/geowave-maven/release/it/geosolutions/imageio-ext/imageio-ext-tiff/1.1.15/imageio-ext-tiff-1.1.15.pom , ReasonPhrase:Forbidden. -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.geoindexingchannel stoppedSetting status of fa951132ef77f8f5849134f7f2d5b44acaf191e2 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/264/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

asfbot build

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/267/Build result: ABORTED[...truncated 7.28 MB...][INFO]                                                                         [INFO] ------------------------------------------------------------------------[INFO] Building Apache Rya PCJ Fluo Demo 3.2.11-incubating-SNAPSHOT[INFO] ------------------------------------------------------------------------[INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ rya.pcj.fluo.demo ---[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 13 iota=59[INFO] [INFO] --- apache-rat-plugin:0.11:check (check-licenses) @ rya.pcj.fluo.demo ---[INFO] 51 implicit excludes (use -debug for more details).[INFO] Exclude: /resources/META-INF/services/[INFO] 4 resources included (use -debug for more details)[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 4 licence.[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 13 iota=59[INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-mvn) @ rya.pcj.fluo.demo ---Build was aborted[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 13 iota=59[INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ rya.pcj.fluo.demo ---channel stoppedSetting status of fa951132ef77f8f5849134f7f2d5b44acaf191e2 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/267/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

hey @meiercaleb  this looked fine to me -- address Aaron's two comments and I think it is ready to merge.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/334/


Less debouncing and more snappiness

First of all, I'd just like to say iron-data-table is a beautiful thing. I love the concept of having an html template for each column.
Second, I just saw this today and I have no idea what I'm doing. I want to use iron-data-table, but I need it to be snappy. I saw several instances of 100ms debouncing inside iron-data-table.html, which would seem to cut back on snappiness. I made changes to update the iron-list synchronously when possible.
Don't feel obligated to accept this pull-request. Chances are, I'm messing something up. I hope you might find some use in it as food for thought.
Upon making this change in my personal project, it seemed to aggravate issue 68 for reasons I cannot fathom.

This change is

Hi and thanks for the kind words! 😄
I'm actually currently looking into #70 and looks like we could be able to remove the debounce altogether.

Closed with 3bca70e


[Feature Request]: Provide a way to update tools for an existing GPTAssistantAgent agent

Is your feature request related to a problem? Please describe.
When an existing GPTAssistantAgent is retrieved using name or ID, there is no method to update the tool configuration.
GPTAssistantAgent.register_function() doesn't appear to update the assistant's function/tools list.
Describe the solution you'd like
GPTAssistantAgent.register_function() should update the assistants' functions.
Additional context
No response

@gagb fyi

FYI, I'm using this workaround for now
config_list = ...
tools_config = ...
assistant_id = ...
oai_assistant = GPTAssistantAgent(
    name="...",
    llm_config={
        "config_list": config_list,
        "assistant_id": assistant_id,
        "tools": tools_config,
    },
    instructions=get_instructions(),
    overwrite_instructions=True,
)

# Workaround -  GPTAssistantAgent tools are not updated if the assistant already exists
if assistant_id is not None:
	oai_assistant._openai_assistant = oai_assistant._openai_client.beta.assistants.update(
        assistant_id=assistant_id,
        tools=tools_config
    )

for tool in tools_config:
    oai_assistant.register_function(....)

Closing this issue due to inactivity. If you have further questions, please open a new issue or join the discussion in AutoGen Discord server: https://discord.com/invite/Yb5gwGVkE5


Menu support

WordPress allows the ability to manage menus within the editor to easily make changes to navigation and other menus.

it seems like this requires a plugin to take advantage in the API
maybe this can be a tutorial for how to add it or a plugin to extend?

Now we have GraphQL this should be fun to do.


Ionic build android

When using this in the browser with ionic serve I have no issue. I have a controller shown just like in the example, and I can switch back and forth between the locales I included in my index.html. However when I use ionic build it is giving me this error.

I used bower to install my packages, so I am sourcing both "angular-dynamic-local" and "angular-i18n" which are sourced from index.html. I also changed the default directory for angular-dynamic-local to find inside of the /lib folder.
I find it strange that using ionic serve works fine, to me is merits enough that everything is configured correctly, but when I build and test on an android device it will not.

I am not familiar with ionic, so I am not sure if I can help you here, but
have you tried
https://github.com/lgalfaso/angular-dynamic-locale/issues/93#issuecomment-210826808
?
On Sat, Feb 11, 2017 at 1:51 AM Andrew Heyer<EMAIL_ADDRESS>wrote:

When using this in the browser with ionic serve I have no issue. I have a
controller shown just like in the example, and I can switch back and forth
between the locales I included in my index.html. However when I use ionic
build it is giving me this error.
[image: screen shot 2017-02-10 at 5 45 45 pm]
https://cloud.githubusercontent.com/assets/19435085/22849270/d55f84f6-efb8-11e6-9b08-e15db023b305.png
I used bower to install my packages, so I am sourcing both
"angular-dynamic-local" and "angular-i18n" which are sourced from
index.html. I also changed the default directory for angular-dynamic-local
to find inside of the /lib folder.
I find it strange that using ionic serve works fine, to me is merits
enough that everything is configured correctly, but when I build and test
on an android device it will not.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lgalfaso/angular-dynamic-locale/issues/111, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAX44j2B1veZKUt5NI0bMFkQMYwv7ReHks5rbQYCgaJpZM4L-Asu
.

That fixed it! Inspecting the device with google chrome dev tools shows the file, thus I am now able to use with my ionic app. Thank you!!!!


How to simply show the data in a template?

I'm having a very difficult time understanding how to show my template with some data. It is throwing some sort of error, but while I can catch the error I can't read what the error is stopping my twig logic to show.
// this is the data that I want to be passed into my shared template
let emailBodyData = { 'hi' : 'thank you for helping me kind reader' }

var template = Twig.twig({
            path: './templates/email/lorem.twig', // this is where my template lives
            rethrow: true,
        })
var el = template.render({ emailBodyData })

console.log(JSON.stringify(el))

Running this on a NodeJs app. Any help would be greatly appreciated.

It looks like this issue is with this line:
var el = template.render({ emailBodyData })

Unless there is an emailBodyData variable in the templates/email/lorem.twig template, it should not be wrapped like that, the data should be passed directly as the first parameter like:
var el = template.render(emailBodyData)

If this does not solve the problem, please comment with the contents of the templates/email/lorem.twig.


Any end to end example in C++, for both training and Inference?

thanks,

No.

Inference in c++?


Review package dependencies

Review which package dependencies could be removed, for example:

Claims depends on Data (could be removed by moving out getHolidayCalendars and passing that function as a parameter to rollPaymentSchedule. This would introduce a dependency on Data in Bond and Swap though.

The current dependency of Claims on Data means that Generic has an indirect dependency on Data, which might be undesirable.

Dependency graph is now available in LucidChart (reach out to me if you'd like the link). Dependencies that (in my opinion) could easily be broken:

Account -> Holding (by moving util functions to a different location)
Data -> Lifecycle (by moving the DateClock event)
Claims -> Data  (by using a calendar fetcher instead of the actual Calendar in Data)

Account -> Holding dependency removed in https://github.com/digital-asset/daml-finance/pull/409

Data -> Lifecycle dependency : to be discussed where the events should live, currently leaving as is

Removing the Claims -> Data dependency requires two items:

move the implementation-specific calendar logic outside of the Claims package
move the implementation-specific time conversion logic outside of the Claims package

In order to do the latter, the utility functions need to be refactored to avoid calling prepareAndTagClaims.

Re-opening this for one more issue, discussed in https://github.com/digital-asset/daml-finance/pull/471
Proposal:

duplicate Instrument.Q, qty to Common.Types
throughout the library, we should always import Instrument.Q, Instrument.K, Account.K, qty from Common.Types
this removes some dependencies on Interface.Account or Interface.Instrument.Base

Closed via https://github.com/digital-asset/daml-finance/pull/481


rgw-kms: skip unsupported configs

Signed-off-by: Jiffin Tony Thottan<EMAIL_ADDRESS>

/ok-to-test

/lgtm


Port fix for buildscript classpath state being discarded

Port fix from #27527 to 8.6.
Fixes #27521.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

@bot-gradle test and merge

The merge queue build has started. Click here to see all failures if any.

The merge queue build has failed. Click here to see all failures.

@bot-gradle test and merge

The merge queue build has started. Click here to see all failures if any.


onPressImage is not working

Hi there,
First of all, thank you for this wonder lib... It's the best one, I have tried a few and this is the only one which is actually working in all aspects.
I am facing an issue when trying to attach the function on onPressImage
goToDetails = (item: any, index: number) => {
    console.log("details: ", item);
}

<MasonryList
       key="2"
       images={images}
       columns={2}
       backgroundColor={colors.ghost_white}
       imageContainerStyle={{
               borderRadius: 7
       }}
       renderIndividualHeader={(data: MasonryImage) => {
               return <Text style={styles.pinHeaderStyle}>{data.title}</Text>
       }}
       customImageComponent={FastImage}
       customImageProps={fastProps}
       onPressImage={this.goToDetails}
/>

The goToDetails is not being triggered... I noticed when I was tapping the image ruthlessly, I see 2, 3 times it printed the console.

Hi,
A temporarily fix is to fully customize the image component of the react-native-masonry-list.  The description is shown below on how to use it.  If you would like an example, let me know.  I would be happy to help you out.

:large_blue_diamond: Props

Props
Description
Type
Default

completeCustomComponent
Custom function to return a fully custom component for each image.  ({ source: object, style: { width: number, height: number, margin: number }, data: object }) => React.Element  This function must return a React Component and it is required to have the source and style for the component to display proper masonry.
Function

The issue is being resolved at the moment.  Thanks for your patience.

You're using mostly customized props so it's recommended to use completeCustomComponent.  FastImage is another third party package that will be a lot more compatible with react-native-masonry-list in future releases.

Hi @Luehang
Thank you for all the help! I managed to get it working. I am posting my code below, for reference.
Thank you once again for this wonderful library!
Modified masonry list
<MasonryList
                key="2"
                images={images}
                columns={2}
                backgroundColor={colors.ghost_white}
                imageContainerStyle={{
                    borderRadius: 7
                }}
                renderIndividualHeader={(data: MasonryImage) => {
                    return <Text style={styles.pinHeaderStyle} onPress={() => Actions.details({ id: `${data.id}`})}>{data.title}</Text>
                }}
                completeCustomComponent={(props: any) => <MasonryCustomComponent {...props} />}
            />

Custom complete component
interface Props {
    source: any;
    data: MasonryImage;
    style: {
        width: number;
        height: number;
        margin: number;
    }
}

const MasonryCustomComponent: React.SFC<Props> = (props) => {
    return (
        <TouchableOpacity onPress={() => Actions.details({ id: `${props.data.id}` })}>
            <FastImage resizeMode="stretch" source={{uri: props.data.uri}} style={{width: props.style.width, height: props.style.height, margin: props.style.margin}} />
        </TouchableOpacity>
    );
}

export default MasonryCustomComponent;


Questions about K prototypes

Hi, I'm interested in your work. I wonder if there are k prototypes of some classes that become similar after training? For example, after visualization according to Figure 3 in the paper, it will be found that the activation area of each prototype is roughly the same. I found this problem while running your code. I suspect it's caused by some classes of my dataset that don't have meaningful parts.
Hope to receive your reply, thanks!

@RenLibo-aircas thanks for your interest. Basically, the equipartition constraint (see Eq. 8) in Sinkhorn-Knopp iteration can improve the diversity of the cluster centers. But in practice, case-by-case consideration is needed. For example, if the patterns of the semantic classes of your interest are simple or the number of training data is limited, there is no need to adopt a large number of prototypes.

Hi, I am interested in your work too!
If you don't mind, could you tell us how you visualize k prototypes?
thanks.


No reliable way to work with parenthesis

Proposal: add WithParens in analogy with func (l *Parser) WithFreeFloating().
That function asks parser to preserve info about parenthesis.
It can either introduce AST nodes that represent parenthesis or make them implicit, but positions info should respect them.
It's almost impossible to handle parenthesis in the source code right now. We can't reliably count a number of expression surrounding ( and ).
Imagine this binary expression:
(($x) + ((($y))))

If we use GetPosition and take a slice of src[pos.StartPos-1 : pos.EndPos], result would be:
$x) + ((($y

If we go to the left and right, we'll count 2 parens, but the binary expression itself has only 1 surrounding, while $y is surrounded by 3 pairs of ().
With proposed feature, I would expect binary expression position to capture the entire (($x) + ((($y)))). Sub-expression 1 should be ($x) and the 2 is ((($y))).
For clone expr like clone ($x) we get positions that encloses clone ($x.

Note for #81: you can encode parenthesis as a int field that represents how many ( ) around expr there are. It can even be a few bits from a flags field, I would say encoding up to 3 pairs (2 bits) is enough (0 - no, 1 - (), 2 - (()), 3 - ((()))).

One possible fix is to update '(' expr ')' definitions to set positions like this:
'(' expr ')'
  $$ = $2;
  $$.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition($1, $3))

So we don't loose parenthesis positions info.

Now I see that "free floating" might be the thing I'm looking for. :)

Yes, you can count ( free-floating tokens at freefloating.Start position. But be careful, I move all freefloating.Start whitespaces, comments, and tokens to the most parent node, but freefloating.End saves as is so ( and ) tokens can be coupled to different nodes.


refactor: Introduce enum like class for node types

In future versions (if support for <8.1 is ever dropped) this enum like class may be replaced with a proper enum. Then it could potentially replace several more strings (tag names) across the repo.


Missing .Net 2.1.300

I have the latest VS2017 (15.8.7 - vm from azure) version. To make the solution work I need to install .Net 2.1.300. follow the link:
https://www.microsoft.com/net/download/dotnet-core/2.1
to get the right version (below the middle of the page).

You can either update the global.json to the latest version of .NET Core or delete the global.json file entirely.


review 'Anaplasmataceae infectious disease' in human and non-human animal

Looking at the classification for human 'Anaplasmataceae infectious disease' (MONDO:0006922), it is unclear what the difference between 'anaplasmosis' and 'ehrlichiosis' is.
Depending on the answer above, we need to review the 'cross-species analog' between the non-human animal diseases and the human animal disease. For example, should 'anaplasmosis in cattle' (MONDO:0044748) be 'cross-species analog' some anaplasmosis (MONDO:0025303) or 'human anaplasmosis' (MONDO:0044747)
human classification:

Reviewed terms based on

Anaplasmosis
ehrlichiosis
Human Granulocytic Ehrlichiosis
human granulocytic anaplasmosis

Left to do:

'human anaplasmosis' (MONDO:0044747) needs to be merged to 'anaplasmosis' (MONDO:0025303)
MONDO:0005118	 - human granulocytic ehrlichiosis	 to be split to

human granulocytic ehrlichiosis
human granulocytic anaplasmosis


Update page.md

链接错误，应该为frontmatter而不是config

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[x] Bug fix
[ ] New feature
[ ] Documentation update
[ ] Other

Description

Screenshots

Before
After

链接错误，应该为frontmatter而不是config.md

Thanks for your contributions! ❤


Svelte debug panel doesn’t toggle player

First, great work getting the debug panel over into Svelte!
I’ve just installed v0.34.1 and I can’t seem to toggle the client’s player using the debug panel as I could previously.
Old debug panel

New debug panel

I wanted to check against the examples in the documentation to see if I needed to change how I hooked it up to my board component (everything’s in React on my end), but noticed they’re still using the old build, so I’m not sure if I need to reconfigure something or if this is a bug in the click handler in the debug panel.

I just forgot to Port this feature over :)

I'm going to be spending more time on the debug panel in the next week so this should be fixed soon.

Nice — for now I'm using an old branch of mine so no rush on my end.


Local repository directory defaults to an unwritable location

From a fresh install on MorphoCloud, I still get this:
gh command failed:
['repo', 'clone', 'MD_E15', './MD_E15-issue-7']
("fatal: could not create work tree dir './MD_E15-issue-7': Permission denied\nfailed to run git: exit status 128\n", None)

It was set to a value like: . and tried to write /
It still doesn't default to SceneRoot (which was /home/exouser/Slicer in this case)
>>> slicer.mrmlScene.GetRootDirectory()
'/home/exouser/Slicer'

Hmm, I just went through the whole process on a fresh jetstream instance so there must be something else going on.
Can you try again and/or give me access to an instance that demonstrates the issue?

I'm not seeing what you've reported.  I logged in to instance-62 and was able to load a PR for review and it used the configured path to /media/volume/MyData/MC_Repos.
I left if running for now so you can have a look.  I guess it'll shutdown in 4 hours, but if not and you don't have time to look now let me know and I'll shut it down.
If it's not clear why we are seeing different things, let's start a complete fresh instance and follow the steps that users would do and see if we can replicate any issues.

That's because i set it already.  Please unusual the morphodeppt reinstall and then try.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Steve Pieper @.>
Sent: Wednesday, November 13, 2024 6:06:52 AM
To: pieper/SlicerMorphoDepot @.>
Cc: muratmaga @.>; Author @.>
Subject: Re: [pieper/SlicerMorphoDepot] Local repository directory defaults to an unwritable location (Issue #8)
I'm not seeing what you've reported. I logged in to instance-62 and was able to load a PR for review and it used the configured path to /media/volume/MyData/MC_Repos.
I left if running for now so you can have a look. I guess it'll shutdown in 4 hours, but if not and you don't have time to look now let me know and I'll shut it down.
If it's not clear why we are seeing different things, let's start a complete fresh instance and follow the steps that users would do and see if we can replicate any issues.
—
Reply to this email directly, view it on GitHubhttps://github.com/pieper/SlicerMorphoDepot/issues/8#issuecomment-2473717940, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFCMSFFQUESA2K26W563SDD2ANMHZAVCNFSM6AAAAABRTE2IE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZTG4YTOOJUGA.
You are receiving this because you authored the thread.Message ID: @.***>

Still not clear how that happened.  Here's what I did:

Got a fresh morphocloud instance (instance-70)
checked that Slicer, SlicerMorph, and gh are installed
used gh auth login to get into my pieper923 account
cloned the MorphoDepot repository and added to Slicer
assigned an issue to my pieper923 account for review
entered the MorphoDepotReview module and refreshed
doubleclicking PR loaded files in a repo in /media/volume/MyData
going into MorphoDepot module and looking in advanced shows the same path

Ok i will test it my repo too. Meanwhile, can you modify the path to create a subfolder called MorphoDepot and clone them here.

I confirm it works for me. Leaving it open until you can incorporate the request below (automatically create a subfolder called MorphoDepot under the default scene root). We might also need to expose this setting to the review module, since a reviewer may never touch the MorphoDepot module.


All checks should return list of points

Even if there is only one point to return

Looks good to me but I will let Mike to resolve his questions.


[#34] logger behaviour

fixes #34

Coverage increased (+2.2%) to 88.696% when pulling 64d4dff68718841ee15da8cd9a55f9afa7f84689 on flavio.34.logger-behaviour into 08afe3833de3d84ccf84a2fd02a00f37eef6bb72 on master.

Coverage decreased (-1.6%) to 88.696% when pulling 78828b10de5dea8af4557e93d12290071aad142e on flavio.34.logger-behaviour into 87b745114d43ab1b398fbe959bac0d7b15ed2a6f on master.

ready @alemata


feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16

Ref #5211
Ref #5307
Upgrade API kubernetes 1.28 and controller-runtime to 0.16

Release Note
feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16

Is this expected to be merged for Camel K 2.3 ? It would be important to consider openshift 4.14 uses kubernetes api 1.27.

According to the kubernetes-version-compatibility, it should still be compatible with Kubernetes API version N-3 or N-4

Is this expected to be merged for Camel K 2.3 ? It would be important to consider openshift 4.14 uses kubernetes api 1.27.

For now this is for main, so post 2.3. Before backporting I need to run the test on Openshift 4.14.

According to the kubernetes-version-compatibility, it should still be compatible with Kubernetes API version N-3 or N-4

The test needs to run on Openshift 4.14 because other dependency upgrade that come with it, like the one on client-go, could have an impact somewhere, and the compatibility is not 100% (see https://github.com/kubernetes/client-go#compatibility-client-go---kubernetes-clusters).
After this one is fully done there should be the upgrade for API 1.29 and controller-runtime 0.17.

I don't think we should backport this to 2.3 as it may pose some compatibility problems with the existing running platform. Ie, the user is running a 2.3.0 version and the upgrade to 2.3.1 should work on the very same platform he's running 2.3.0.

@gansheer may I suggest a different strategy? Whenever we upgrade dependency, we better do it one by one instead of doing one shot, in order to understand which is the dependency that really fails. IMO, the first thing to do is to upgrade kubernetes only. We can bump to 1.28 and later to 1.29. Once we are sure that all is stable, we can bump any other dependency.


Boolean attributes sometimes are not generated properly

Describe the bug
Boolean attributes after a non-boolean attribute are not generated correctly:
jsx:

Check the attributes of this element

generated html:

Check the attributes of this element

Your Example Website or App
https://github.com/GiyoMoon/solid-attributes
Steps to Reproduce the Bug or Issue

git clone https://github.com/GiyoMoon/solid-attributes.git
cd solid-attributes
pnpm install
pnpm dev
Navigate to http://localhost:5174/
Have a look at the centered p element. Compare it with its jsx equivalent (https://github.com/GiyoMoon/solid-attributes/blob/main/src/App.jsx#L6)

Expected behavior
Every boolean attribute should have a space appended after/before it.
Screenshots or Videos
No response
Platform

OS: macOS
Browser: Chrome
Version: 117

Additional context
No response

Thanks for reporting. This is fixed in babel-plugin-jsx-dom-expressions 0.37.2. Since the preset is set to match range this should be fixed in any new install and will be bumped in the next release of Solid.


[BUG] Install TCP server fails when compiling C module

Describe the bug
When I run the install_tcp_server script, the command CRTCMOD fails. The issue is that the CRTCMOD command specifies TGTRLS(V7R1M0) but no ILE C *PRV compiler is installed.
To Reproduce
Run install_tcp_server on a IBM i 7.2 or higher with no ILE C *PRV compiler.
Expected behavior
The script should compile to current release - if compile to previous release is required, this should be an optional parameter to the script.
Verbose output
$ /QOpenSys/pkgs/lib/sc/tcpsvr/install_sc_tcpsvr
Command is > CRTLIB LIB(SCOMMANDER) TEXT('Service Commander')  <
CPF2111: Library SCOMMANDER already exists.
lib doesn't exist yet
Command is > DLTMOD MODULE(SCOMMANDER/SC)  <
CPC2191: Object SC in SCOMMANDER type *MODULE deleted.
Command is > DLTPGM PGM(SCOMMANDER/SC)  <
CPC2191: Object SC in SCOMMANDER type *PGM deleted.
Command is > RMVTCPSVR SVRSPCVAL(*SC)  <
TCP1640: TCP/IP server *SC removed successfully.
Command is > CRTCMOD MODULE(SCOMMANDER/SC) SRCSTMF('/QOpenSys/pkgs/lib/sc/tcpsvr/sc_tcpsvr.c') SYSIFCOPT(*IFS64IO) TERASPACE(*YES *TSIFC) TGTCCSID(37) TGTRLS(V7R1M0)  <
CZS0601: Module SC is not created because statement errors occurred.
CZM0613: The compilation failed.

Fixed by #78