Importing file without loader returns file's path

Is this a bug report?
No.
I'm trying to load some content from a Markdown file, to process with remark and remark-react.
// TermsAndConditions.js
import React from 'react';
import termsAndConditions from './TermsAndConditions.md';

function TermsAndConditions() {
  console.log(termsAndConditions);
  return <div />;
}

export default TermsAndConditions;

If <TermsAndConditions /> is used in a parent component, the <div /> does render, and the console.log gives me:
/static/media/TermsAndConditions.49f2cd99.md

So as far as I can tell, the import is resolving to a path to the bundled .md file. I can then pass that path to a fetch and load the Markdown asynchronously.
 I might prefer to use a webpack Markdown loader, or raw-loader, but I don't want to eject yet just for this wee thing. I can live with a fetch.
But I'd really like to understand this behaviour before my senior asks about it. How is webpack handling files without a loader in CRA?

Got it. I'll close this.
For anyone else finding this by searching, CRA is configured to handle certain file types (.js, .jsx, .css, .tsx...) and everything else is handled by webpack's file-loader, which emits the public URI of the file which is imported.

If you need the contents of the file you should use a Babel Macro; we decided this was the least surprising behavior.


Add sample project

Add sample project that will showcase the capabilities of the Monacs library.
Any ideas for what this project can be like are welcome. I was thinking about simple WebAPI app with file or SQLite storage, but I'm struggling to find some simple yet complicated enough domain to demo the features of the library.

Sample project will be added here.


Slug size is too large

Hi,
Great app. I tried deploying this app (for my learning purposes) and it gave me slug size error (630 MB). It looks like all dependencies are important. How did you deploy this app to heroku?
Thanks!

Hm. That's strange. My slug was 176.4M, which itself is also a bit big.

That's weird. The only thing I changed is adding "tensorflow" in the requirements.txt instead of: https://storage.googleapis.com/tensorflow/linux/cpu/tensorflow-0.10.0-cp34-cp34m-linux_x86_64.whl
because heroku gives me an error that this wheel is not supported. Which worked for me for other apps.
Here is my repo: https://github.com/moelgendy/deep-instrument-heroku

Aah, in requirements.txt there was not fixed-version output of pip freeeze. Thus a newer version of TensorFlow/Keras/etc. slipped in.
Should I just add a line the in the requirements.txt file = pip freeze ?

No I mean I forgot to run pip freeze > requirements.txt to fix versions of packages present in my environment.
TensorFlow was 0.10 and Keras something from that time, something 1.x.

So what do you suggest I do to be able to deploy this app?

you can try to specify library version from the time of the release
you can try to dig through your slug, check what takes so much space and remove that
you can try to remove some assets (eg. the example audio files) from the build and make them available eg. through S3
see other tips: https://robots.thoughtbot.com/how-to-reduce-a-large-heroku-compiled-slug-size

That's all I can advice you at the moment. Good luck.

I fixed it by changing the Tensorflow package version from 2.1.0 to 1.7.0 in requirements.txt
Give it a try but be careful it may lead to broken code !!
Cheers

Only few versions of TensorFlow have less size.
for me Tensorflow versions 1.5.0, 1.7.0, 2.0.0 worked.

try changing tensorflow version to 2.0.1 .. that worked for me !

Use tensorflow-cpu==2.1.0. Worked for me on heroku as we do not require GPU on Heroku.

pip install tensorflow-cpu==2.1.0


chore: Exclude unneeded files

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Simplify typeset function.

The typeset function can be dramatically simplified because we do not pass element collections to it. It was implemented to support collections because it was ported over from a jQuery implementation and jQuery objects are collections by default. But it is not necessary in the current codebase.
cf. https://github.com/ipython/ipywidgets/issues/544
cc: @jasongrout @SylvainCorlay

The docs for this function should be update to explain the new call signature.

@jasongrout 👍

Thanks!

:+1:
On May 3, 2016 5:30 PM, "Jason Grout"<EMAIL_ADDRESS>wrote:

Merged #557 https://github.com/ipython/ipywidgets/pull/557.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/pull/557#event-649450677


Parametric Deku

This PR is proof-of-concept for replacing the core ledger of Deku with a custom state transition function written in Go lang. It demonstrates the use of IPC over named pipes to process transactions collected by Deku in the Go process.
The main file to look at is the state transition Go file, which gives an idea of the API provided by this POC. Currently it is very low-level - the contract is given the raw bytes corresponding to an arbitrary JSON payload submitted by users of the network, and the contract implementors must deserialize this data to the appropriate Go type.
Task List:

[x] Rebase with #501  to get latest work on handling external processes
[x] Add an error message that the state machine can send to Deku to signal a bad state transition and trigger early exit
[ ] Add logs to signal a successful transaction
[ ] Show demo of multiple transactions in a single block.

Stacked PR Chain: d4hines

PR
Title
Status
Merges Into

#558
Simplify Sandbox.sh

-

#527
Dummy-ticket

#558

#536
feat: add block-by-level rpc

#527

#537
Add block rate and operation rate metrics

#536

#539
Benchmarking: ticket transfers

#537

#540
👉 (Draft)POC: Parametric Deku

#539

#560
remove static.Dockerfile

-

#559
add gh-stack variable

-

Can we have the exemple as typescript instead of javascript? We wouldn't promote straight js


fixed some key texts not translating by re-importing .csv and all .translation files

bro do not open the .csv with microsoft excel but instead with google sheets:
a Warning from Godot documentation:
**By default, Microsoft Excel will always save CSV files with ANSI encoding rather than UTF-8. There is no built-in way to do this, but there are workarounds as described here.
We recommend using LibreOffice or Google Sheets instead.**

Thank you very much! 👍


various perf fixes

this was based on some testing around the nav

Memoizing some styles. So styling overrides often create new objects and that causes render thrash. i think the longer term fix is to use something like glamourous but shortterm i just use lodash memoize so we get the same objects back
I turned off the global subscription throttle. We had this on due to cpu issues but it just bakes in latency we can't remove so we should fix it up the correct way and not re-render

@keybase/react-hackers


Update for xcode 6.3.1.

Thanks for the Readme updates. I am going to add these to master. I have updated the other Swift 1.2 issues.


Fixing ng-jq issue with getNgAttribute

The unit tests wasn't able to catch this unless it's on a 'fresh' angular page with ng-jq already added before angular bootstrapping. I've removed the need for jq() to rely on getNgAttribute and instead using element.getAttribute function with the found prefix.
Could use some direction on how to test ng-jq more thoroughly so this doesn't happen again in the future.
This fixes issue #11016.

@Narretz I agree that we should add e2e tests, but I find the current way of Angular doing e2e tests fairly confusing to understand and I haven't found much documentation on such.  Plus, I'm not sure how to setup the test in a fresh page that already has ng-jq predefined before Angular loads.
Any direction in this would be very helpful.

Maybe @caitp can help, she refactored the e2e a few months ago. @caitp do you think if it makes sense to e2e test this? And is this possible with the current setup?

First of all, I think this is the totally wrong approach to solving this issue.
The issue is about using the jquery api within getNgAttribute(), so all that needs to be done is to rewrite getNgAttribute() to not use the jquery api, which is pretty trivial.
For e2e testing, there is a sample test in test/e2e --- you basically just need to create a new fixture (give it a name, like jquery-binding or something), similar to the sample fixture, and adapt the sample test to fetch the new fixture, and write some tests to make assertions about the new fixture doing what you expect it to do.
There isn't much of a guide, but it should be simpler than writing docs e2e tests. I am happy to review and give pointers on writing the test(s) next week.

Thanks @caitp, I'll definitely add that in.  I would be keen to change the getNgAttribute function to not use jquery api and I agree with it as well since it's a dependency on an object that we don't know when it'll be available.  However, I didn't want to change it in case there's a particular use case needed for it and I don't know the angular project enough to make my own decision on this.
@Narretz Will definitely add e2e tests, but in the meantime, can we merge this to fix the issue?

@mboudreau: Since you seem to have fixed getNgAttribute() to not require jqLite/jQuery, should we revert back to the more concise variation that uses getNgAttribute(el, 'jq') ?

@gkalpak I was thinking about it, but since I am already searching for ng-jq through the prefixes, I didn't see the point of doing another loop through all the prefixes if I already know it.  I'll leave it up to you if that's a good idea, but figured it was only 1 loop through the prefixes that's needed, not 2.

@mboudreau, either way is fine, I guess. It's micro-optimizing performance vs micro-optimizing readability, so it's just a matter of taste :)
Leaving it up to you !

@gkalpak You make a good point, but it's not that hard to understand, just not using the helper function to make it 'easier'.  I'd take a readability hit for a performance gain on that unless someone on the angular team has a really big issue with it.

I'll see it like @gkalpak - I prefer getNgAttribute, but I don't insist on it.
We really should have the tests for merging this, though. I can look into it this week.

@Narretz @gkalpak @caitp I'm willing to try to get e2e tests going on this, but going to need some direction first.  Either that, or at the very least, merge this into master so it fixes the bug that was discovered by this PR.

I'm looking into e2e test now. We can't merge this atm -  we raelly only want to merge with tests.

New PR in https://github.com/angular/angular.js/pull/11182


Upgrade Kotlin and Gradle build plugin versions

Closing PR as #69 has been merged, which makes this obsolete and fixes another issue. Thanks for your contribution though


Windows support for VRX conversion

How can we use the VRX script on Windows

Unfortunately the VRX script is Mac only at this time. We have support for Windows on our backlog and will let you know once it is available.
Will leave this issue open and update it with progress.

Closing this issue as it is now tracking here -> https://github.com/viromedia/viro/issues/129


Unused expression does not trigger precondition in -O mode.

Description
Unused expression does not trigger precondition in -O mode.
Reproduction
Exhibit A
func identity<T>(_ x: T) -> T { x }

print("This does not trap in -O mode!")

_ = identity(0 as UInt) - identity(1 as UInt)

Exhibit B
func identity<T>(_ x: T) -> T { x }

print("This does trap, however!")

_ = identity(identity(0 as UInt) - identity(1 as UInt))

Expected behavior
I would expect (A) to trap with and without compiler optimizations.
Environment
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Target: arm64-apple-macosx14.0
Additional information
No response

Note: it's not due to lazy evaluation because it behaves the same way in a function:
func identity<T>(_ x: T) -> T { x }

print("This does not trap in -O mode!")

func run() {
    _ = identity(0 as UInt) - identity(1 as UInt)
}

run()


Fix: Installs While Using Node 20

Description
It's impossible to install dependancies using node 20 right now. The error lists the dependency responsible, so I tracked down it's parent a few layers up, uninstalled and reinstalled to upgrade ^x.x.x dependancies.
Test plan
nvm use 20
yarn install

confirm that yarn install and yarn build now work for at least the AA package!

done


Add env URI to role share query

Feature or Bugfix

Bugfix

Detail

If I have Group_1 that is invited to Env1 and Env2 and has existing shares for that group to Env1 - I still cannot remove the EnvGroup from Env2 (where no shares exists)

When we count resources to validate before removing group - for share objects in the count_principal_resources() we only filter by principalId and principalType but we also need to filter by environmentUri

This PR fixes query to add environmentURI filter when counting envGroup resources before removing groups

Relates
Security
NA
Please answer the questions below briefly where applicable, or write `N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
  - Is the input sanitized?
  - What precautions are you taking before deserializing the data you consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires authorization?
  - How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Looks good! @noah-paige  I wondered if we also count the consumption roles when we remove a team from an environment. I just checked and I don't think we do. Should we define ConsumptionRoles as EnvironmentResource?  wdyt?


Lazy load modules

TL;DR
The loading time can be reduced from 6~8 seconds to 0.25~0.30 seconds.
It can improve performance up to 30x when running a simple workflow.
@task
def demo_task():
    print("foobar")

@workflow
def demo_workflow():
    demo_task()

Before:

After:

Type

[x] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
use lazy_import in the flytekit to load module lazily.
Tracking Issue
https://flyte-org.slack.com/archives/CP2HDHKE1/p1681239386271109?thread_ts=1681235972.845179&cid=CP2HDHKE1
Follow-up issue
NA

blocked by https://github.com/modin-project/modin/issues/6022


upstream Content-Encoding header should not be always rewritten, because downstream may re-encode as gzip

gzip logic.xlsx

changing 3rd case to forcibly gunzip upstream response, then setting content-encoding to "identity" manually


Selecting a different GraphNode from code does not send a select or deselect signal

Godot version:
godot mono 3.2.3_RC5
OS/device including version:
Windows 10
Issue description:
Calling GraphEdit.SetSelected( node ) does not send a 'node_unselected' signal or a 'node_selected' signal
Expected behavior :
When a node is already selected and GraphEdit.SetSelected( node ) is used to select a new node, a 'node_unselected' signal should be sent
Steps to reproduce:
1 connect a listener to 'node_unselected'
2 Left click on an unselected node.
3 Call GraphEdit.SetSelected( node ) where node is a different node from the one selected
Notes :
This behavior might not be new in 3.2.3, but since that version added 'node_unselected' as a signal it may just now be noticeable.

Fixed


BCUT2D throws an error when it should return NaN

Describe the bug
When I use BCUT2D function on SMILES [Li]F, I get an error:
ValueError: ERROR: No Gasteiger Partial Charge parameters for Element: Li Mode:

To Reproduce
from rdkit.Chem import MolFromSmiles
from rdkit.Chem.rdMolDescriptors import BCUT2D

BCUT2D(MolFromSmiles("[Li]F"))

Expected behavior
NaN values for Gasteiger features. I don't believe that if we can't compute a part of a feature vector, it should always throw an error.
Additionally, based on other issues and discussions, e.g. this one, I assume that using separate BCUT descriptors actually does return NaN, not an error.
Configuration (please complete the following information):

RDKit version: 2023.9.5
OS: Ubuntu 22.04
Python version (if relevant): 3.11
Are you using conda? no
If you are not using conda: how did you install the RDKit? pip

This is not a bug metals have no charges. Envoyé de mon iPhoneLe 16 mars 2024 à 22:57, Jakub Adamczyk @.***> a écrit :
Describe the bug
When I use BCUT2D function on SMILES [Li]F, I get an error:
ValueError: ERROR: No Gasteiger Partial Charge parameters for Element: Li Mode:
To Reproduce
from rdkit.Chem import MolFromSmiles
from rdkit.Chem.rdMolDescriptors import BCUT2D
BCUT2D(MolFromSmiles("[Li]F"))
Expected behavior
NaN values for Gasteiger features. I don't believe that if we can't compute a part of a feature vector, it should always throw an error.
Additionally, based on other issues and discussions, e.g. this one, I assume that using separate BCUT descriptors actually does return NaN, not an error.
Configuration (please complete the following information):
RDKit version: 2023.9.5
OS: Ubuntu 22.04
Python version (if relevant): 3.11
Are you using conda? no
If you are not using conda: how did you install the RDKit? pip
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

I am not arguing that it should compute them, no charge message totally makes sense. However, ComputeGasteigerCharges function has throwOnParamFailure parameter exactly for this situation, which has default value False. So the default behavior is different in computing Gasteiger charges separately and when using them in BCUT2D.
So I think that:

This should be made consistent, i.e. BCUT2D should set either NaN or zeros for Gasteiger charges in those cases
BCUT2D should also have such a parameter to control this behavior

@thegodone the problem lies precisely here: https://github.com/rdkit/rdkit/blob/a6f0493fddad16f77db19b389cb107a86bddb7f4/Code/GraphMol/Descriptors/BCUT.cpp#L121C3-L121C50. throwOnParamFailure, the third argument, is hardcoded as true.

I think the main problem is that there is no way to currently extract the ones that succeed.  I think this should remain the default but adding an option to not throw on failure is valid IMO.  Making it explicit means the user needs to check the return values.

My two cents on this one: If there's a clear error condition, like this one, I would rather that the descriptor calculator throw an explict exception with an informative message (as it does here) than simply returning NaN.
It's easy enough, and much more explicit, for client code to catch the exceptions and insert whatever error-handling they think is appropriate.

@greglandrum so maybe I formulated this wrong: the problem is that the current code does not allow passing down the throwOnParamFailure parameter, which is hardcoded. As it is currently, I have to reimplement the whole BCUT2D from scratch in Python, just to pass this one parameter down to computeGasteigerCharges. I think this issue should be open, and instead maybe changed to adding this parameter to BCUT2D. The default behaviour should be as is, I agree, but this should be configurable.


Updated my review

Added my information as per you told to do with closing the issue number
#7

kindly merge with the tag hactoberfest-accepted

Solve conflicts. Just paste your code after updating the repo as changes have been made

idk why there is conflict there, Kindly explain me what to do further @IC1101Virgo

Update your repo and make changes

Closing PR due to inactivity


Access Riot tag instance

Is there a way to access the Riot tag instance that is created when Riot.mount is called to load the tag? Is it available through tagManager?

Nope, what do you want to perform with a Riot tag ?

Never mind on this - I should look at using RiotControl or just an observable for what I wanted.


Error timeout Axios

[updateUnifiData-login site undefined] error: timeout of 10000ms exceeded, stack: AxiosError: timeout of 10000ms exceeded at RedirectableRequest.handleRequestTimeout (/opt/iobroker/node_modules/axios/lib/adapters/http.js:643:16) at RedirectableRequest.emit (node:events:517:28) at RedirectableRequest.emit (node:domain:489:12) at Timeout.<anonymous> (/opt/iobroker/node_modules/follow-redirects/index.js:169:12) at listOnTimeout (node:internal/timers:569:17) at processTimers (node:internal/timers:512:7)

Same here
UniFi OS v3.2.7
Network Version 8.0.24
Protect Version 2.10.11

same here after updating to OS v3.2.7

Same here.
OS 3.2.7
[updateUnifiData-login site undefined] error: timeout of 10000ms exceeded, stack: AxiosError: timeout of 10000ms exceeded at RedirectableRequest.handleRequestTimeout (C:\Program Files\ioBroker\node_modules\axios\lib\adapters\http.js:643:16) at RedirectableRequest.emit (node:events:517:28) at RedirectableRequest.emit (node:domain:489:12) at Timeout.<anonymous> (C:\Program Files\ioBroker\node_modules\follow-redirects\index.js:179:12) at listOnTimeout (node:internal/timers:569:17) at processTimers (node:internal/timers:512:7)

For the Unifi-Protect Adapter the problem is solved: https://github.com/peterbaumert/ioBroker.unifi-protect/pull/199/files?diff=split&w=0
I modified my main.js an the adater is running now.
I tried to compare the main.js from unifi-protect with the main.js from unifi, but there are many differences and I can't figure out how the login is done here ...
So I hope somebody can adopt the solution from the unifi-protect adapter.

with the update of the adapter to 0.6.7 beta it works

@mcm1957 why close this issue? Where is the fix. I can't see a mentioned 0.6.7 "beta". The last commit is 3 weeks ago.

a) According to chris199512 's psoting two days ago the adapter works with 0.6.7.
So 've marked the issue as fixed.
b) If you cannot install 0.6.7 please open a topic at forum (https://forum.iobroker.net) This release ist available at latest and at stable repository. If you do not see ist, there could be something wrong with you installation.

c) If the problem still exists with adapter release 0.6.7 please attach a log and note the currently used versions of releavant adapters (Adpater - should be 0.6.7, js-controller, node, o/s)

a) The adapter functions, but it still triggers errors. Perhaps you misunderstood @chris199512's post. The error has not been resolved.
b) 0.6.7 is installed. But thank you for your advise.
c) Yes, it does:
**- Adapter: 0.6.7

js-controller: 5.0.17
node.js: v18.19.0**

time: 2023-12-30 11:31:15.497
debug: error
[updateUnifiData-login site undefined] error: timeout of 10000ms exceeded, stack: AxiosError: timeout of 10000ms exceeded at RedirectableRequest.handleRequestTimeout (/opt/iobroker/node_modules/axios/lib/adapters/http.js:643:16) at RedirectableRequest.emit (node:events:517:28) at RedirectableRequest.emit (node:domain:489:12) at Timeout.<anonymous> (/opt/iobroker/node_modules/follow-redirects/index.js:169:12) at listOnTimeout (node:internal/timers:569:17) at processTimers (node:internal/timers:512:7)

Thanks for detailled feedback.
I've removed the fixed label.

Thanks for detailled feedback.
I've removed the fixed label.

Thank you! My initial post should have been more detailed.

After a few days I don't get the error, but the clients aren't updating again. So the fix only fixed the login, which was also where this error was thrown. Sorry, it looked like it was working

Same here, reinstalled 0.6.7 over the "old" 0.6.7 and still I get the error and no updates after a while. Still the issue is not fixed. No idea where I can get the link for a possbile "beta" version...used the link from this github repo.

I'm very interested in a solution. Is anyone here still actively working on the problem? What other logs are needed to locate the problem?

Anyone feels motivated to look into it?
did not have time yet :-(

@jens-maus
@Scrounger
Any chance to take a look?
I don't have any matching equipment so I cannot do anything here.

hi ... is there already a solution?

Would be really great if a Developer can take a look ...

New version 0.7.0 seams to have solved this issue :-)!! Thanks.

Well, so I thought. Problem still exists:
[updateUnifiData-login site undefined] error: timeout of 10000ms exceeded, stack: AxiosError: timeout of 10000ms exceeded at RedirectableRequest.handleRequestTimeout (C:\ioBroker\node_modules\node-unifi\node_modules\axios\lib\adapters\http.js:643:16) at RedirectableRequest.emit (node:events:517:28) at RedirectableRequest.emit (node:domain:489:12) at Timeout.<anonymous> (C:\ioBroker\node_modules\follow-redirects\index.js:210:12) at listOnTimeout (node:internal/timers:569:17) at processTimers (node:internal/timers:512:7)

Fehler besteht auch noch bei V 0.7.0
unifi.0 | 2024-05-28 23:35:41.748 | error | [updateUnifiData-login site undefined] error: timeout of 10000ms exceeded, stack: AxiosError: timeout of 10000ms exceeded at RedirectableRequest.handleRequestTimeout (/opt/iobroker/node_modules/node-unifi/node_modules/axios/lib/adapters/http.js:643:16) at RedirectableRequest.emit (node:events:519:28) at RedirectableRequest.emit (node:domain:488:12) at Timeout.<anonymous> (/opt/iobroker/node_modules/follow-redirects/index.js:210:12) at listOnTimeout (node:internal/timers:573:17) at processTimers (node:internal/timers:514:7)

I raised the timeout to 30 seconds and did not have any issues since then.
Perhaps the unifi is just a little slower than 10 seconds form time to time? I would submit a pull to raise this to 30s and hope we are done then


HDDS-9333. Snapshot should use snapshot's keyManager in optimizeDirDeletesAndSubmitRequest

What changes were proposed in this pull request?
SnapshotDeletingService should use omSnaphot's KeyManager and not activeDb's KeyManager.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9333
How was this patch tested?
Existing Tests.

In all test case, we use create and delete snapshots with a single bucket and we don't add data to non-snapshot buckets. Add that case should have caught this. I'll add some tests here shortly.

Looking at the code, I think it should be fine to use Active DB's Key Manager. Because the directory is already deleted, iterating over Active DB or Snapshot DB would yield the same result as we can't add or delete anything inside the directory. I'm not sure if there are any other side effects to using Active DB instead of Snapshot DB. But it is better to use Snapshot DB for this purpose so that we don't mess up anything on Active DB.

Thanks for the patch @aswinshakil


The issue about breakout_a3c.py in 3-atari, when i execute source

PC1
cpu: intel i-5
no graphic card
python 3.5
tensorflow 1.14
keras 2.3.0
PC2
cpu: inter i-7
rtx-2070
python 3.5
tensorflow 1.14
keras 2.3.0
When i execute breakout_a3c.py ,
The following problem occurs on both computers
I guess that the issue is related to threading library...
Model: "model_18"
Layer (type) Output Shape Param #
input_9 (InputLayer) (None, 84, 84, 4) 0
conv2d_17 (Conv2D) (None, 20, 20, 16) 4112
conv2d_18 (Conv2D) (None, 9, 9, 32) 8224
flatten_9 (Flatten) (None, 2592) 0
dense_25 (Dense) (None, 256) 663808
dense_27 (Dense) (None, 1) 257
Total params: 676,401
Trainable params: 676,401
Non-trainable params: 0
Exception in thread Thread-2:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 207, in run
action, policy = self.get_action(history)
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 327, in get_action
policy = self.local_actor.predict(history)[0]
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training.py", line 1462, in predict
callbacks=callbacks)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training_arrays.py", line 276, in predict_loop
callbacks.model.stop_training = False
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/network.py", line 323, in setattr
super(Network, self).setattr(name, value)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'
Exception in thread Thread-3:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 207, in run
action, policy = self.get_action(history)
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 327, in get_action
policy = self.local_actor.predict(history)[0]
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training.py", line 1462, in predict
callbacks=callbacks)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training_arrays.py", line 276, in predict_loop
callbacks.model.stop_training = False
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/network.py", line 323, in setattr
super(Network, self).setattr(name, value)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'
Exception in thread Thread-4:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 207, in run
action, policy = self.get_action(history)
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 327, in get_action
policy = self.local_actor.predict(history)[0]
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training.py", line 1462, in predict
callbacks=callbacks)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training_arrays.py", line 276, in predict_loop
callbacks.model.stop_training = False
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/network.py", line 323, in setattr
super(Network, self).setattr(name, value)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'
Exception in thread Thread-5:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 207, in run
action, policy = self.get_action(history)
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 327, in get_action
policy = self.local_actor.predict(history)[0]
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training.py", line 1462, in predict
callbacks=callbacks)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training_arrays.py", line 276, in predict_loop
callbacks.model.stop_training = False
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/network.py", line 323, in setattr
super(Network, self).setattr(name, value)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'
Exception in thread Thread-6:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 207, in run
action, policy = self.get_action(history)
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 327, in get_action
policy = self.local_actor.predict(history)[0]
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training.py", line 1462, in predict
callbacks=callbacks)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training_arrays.py", line 276, in predict_loop
callbacks.model.stop_training = False
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/network.py", line 323, in setattr
super(Network, self).setattr(name, value)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'
Exception in thread Thread-7:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 207, in run
action, policy = self.get_action(history)
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 327, in get_action
policy = self.local_actor.predict(history)[0]
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training.py", line 1462, in predict
callbacks=callbacks)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training_arrays.py", line 276, in predict_loop
callbacks.model.stop_training = False
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/network.py", line 323, in setattr
super(Network, self).setattr(name, value)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'
Exception in thread Thread-8:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 207, in run
action, policy = self.get_action(history)
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 327, in get_action
policy = self.local_actor.predict(history)[0]
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training.py", line 1462, in predict
callbacks=callbacks)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training_arrays.py", line 276, in predict_loop
callbacks.model.stop_training = False
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/network.py", line 323, in setattr
super(Network, self).setattr(name, value)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'
Exception in thread Thread-9:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 207, in run
action, policy = self.get_action(history)
File "/home/name/AdvRL/reinforcement-learning/3-atari/1-breakout/breakout_a3c.py", line 327, in get_action
policy = self.local_actor.predict(history)[0]
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training.py", line 1462, in predict
callbacks=callbacks)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/training_arrays.py", line 276, in predict_loop
callbacks.model.stop_training = False
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/network.py", line 323, in setattr
super(Network, self).setattr(name, value)
File "/home/name/.local/lib/python3.5/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'

I soved the problem by downgrading keras.
=>
$pip3 install 'keras<2.3.0'


[Trailblazer Clues] Wrong area for Shilo Village furnace

This issue is for the external plugin: Trailblazer Clues
The "south of a river in a town surrounded by the undead, what lies beneath the furnace?" master cryptic clue is in Karamja and not in Morytania.

Could have sworn this was referring to Burgh de Rott. Good catch


Replace libsparsehash with sparsehash-c11

Category (leave one):

Other

Short description (up to few sentences):
Replace libsparsehash with sparsehash-c11
Detailed description (optional):

use sparsehash-c11 over libsparsehash
fix typos in find_sparsehash and users of the vars (s/SPARCE/SPARSE/)
drop libsparsehash-dev from docker images (but keep for unbunlded build)
use ::google over GOOGLE_NAMESPACE

Refs: https://github.com/yandex/ClickHouse/pull/6894#issuecomment-530175150

Functional stateless tests (thread) — fail:20, passed:44

this is not me, right?

@akazz, tech debt.

@Akazz, tech debt.

Noted!


Fix And Add Tests For Width_Bucket And Ascii

Fixes #239 , #238

@jczuchnowski , Fixed conflicts !!


PokemonOptimizer stopped working

Expected Behavior
PokemonOptimizer should transfer and evolve pokemon when bag is getting full.
Actual Behavior
No pokemon are being transferred or evolved.
Additional info
It worked in 8eba07a. Maybe it's related to the new inventory commit.
One thing I noticed is that before it showed:
[PokemonOptimizer] [INFO] Pokemon Bag: 192/250
after every catch, but now it doesn't.
Your FULL config.json (remove your username, password, gmapkey and any other private info)
      {
          "type": "PokemonOptimizer",
          "config": {
              "transfer": true,
              "transfer_wait_min": 1,
              "transfer_wait_max": 4,
              "evolve": true,
              "evolve_time": 20,
              "evolve_for_xp": true,
              "evolve_only_with_lucky_egg": true,
              "evolve_count_for_lucky_egg": 90,
              "may_use_lucky_egg": true,
              "keep": [
                  {
                      "top": 1,
                      "evolve": true,
                      "sort": ["dps","ncp","iv"]
                  },
                  {
                      "top": 1,
                      "evolve": true,
                      "sort": ["cp"]
                  }
              ]
          }
      },

Output when issue occurred
[PokemonCatchWorker] [INFO] [pokemon_inventory_full] Your Pokemon inventory is full! Could not catch!

Steps to Reproduce
Other Information
OS: Ubuntu
Branch: dev
Git Commit: 198510b70388f7d70478db847e77bf12095d004a
Python Version: Python 2.7.6
Any other relevant files/configs (eg: path files)

+1 same here with commit 324b752 ("Configurable altitude range  (#4250)", 2016-08-19)

Same issue here getting the following message's in the log.

016-08-19 11:14:48,205 [PokemonCatchWorker] [INFO] [pokemon_inventory_full] Your Pokemon inventory is full! Could not catch!
2016-08-19 11:14:48,217 [MoveToFort] [INFO] [moving_to_fort] Moving towards pokestop Together - 0.13km
2016-08-19 11:14:49,616 [PokemonCatchWorker] [INFO] [pokemon_inventory_full] Your Pokemon inventory is full! Could not catch!
2016-08-19 11:14:49,630 [MoveToFort] [INFO] [moving_to_fort] Moving towards pokestop Together - 0.12km
2016-08-19 11:14:50,894 [PokemonCatchWorker] [INFO] [pokemon_inventory_full] Your Pokemon inventory is full! Could not catch!

Duplicate : #4235

Same for me, Git Commit: 324b752f031cdb39d52c396ea50e14a59841535e

Something seems wrong with how a full bag is calculated.
In the app, I'm seeing 250/250, a full bag.
The bot however shows this :
2016-08-19 11:46:17,322 [PokemonGoBot] [INFO] Pokemon Captured: 241 | Pokestops Visited: 94
2016-08-19 11:46:17,463 [PokemonGoBot] [INFO]
2016-08-19 11:46:17,463 [PokemonGoBot] [INFO] --- redacted ---
2016-08-19 11:46:18,640 [PokemonGoBot] [INFO] Pokemon Bag: 241/250
2016-08-19 11:46:18,641 [PokemonGoBot] [INFO] Items: 225/350

Seems to be related to the new inventory system not counting eggs. Are eggs considered as used space in a bag.. ?

@Calcyfer I don't think this is a duplicate of #4235 as it works in there for awhile and then stops

Fixed by either #4258 or #4254

Indeed not a duplicate, removing the reference.

Think we can close this now. Is it working for you guys?

This issue has been fixed


Added virtual host support for RabbitMQ

Tested on latest BungeeCord (git:BungeeCord-Bootstrap:1.16-R0.5-SNAPSHOT:3d701fb:1545), no reason why it wouldn't work on any other system since the configs follow the format I found in them, and this is all in common rather than implementations. I will happily test it on all systems though on request.
Virtual hosts are used to split up things into different things basically (I'm not very good with explanations, see here), which allows you to isolate all your different projects that use it, so there's no interference.

Looks good, thanks!


Proposal: Add print function with tagged template literal

Adds GeneratedFile#printTag to improve the human-readability of plugins.
Please note that this PR is just a proposal. Also, the naming of printTag is debatable.
Example
Extracted from here
Before
f.print("    async ", localName(method), "(request: ", method.input, "): Promise<", method.output, "> {");

After
f.printTag`    async ${localName(method)}(request: ${method.input}): Promise<${method.output}>{`

Hi @yukukotani.  Thanks for the proposal!  This is actually something we've discussed as well.  I think we'd want this as an overload on the GeneratedFile type.  This way we can call both functions print.  Any interest in refactoring this PR?

@smaye81

I think we'd want this as an overload on the GeneratedFile type. This way we can call both functions print.

Sounds good! I've done the refactoring.

So apologies for the churn on this.  After discussing it with the team, I think we want to move the generated file logic into a generated-file.test.ts for consistency and proper separating of concerns.  The transpile.test.ts file should only focus on testing transpilation and in this instance, we don't need transpilation, just generated file content from the print function.
Could you create a new generated-file.test.ts test file alongside the others and move all your print testing there instead?  Inside the test file, you can add a new helper that looks as follows:
/**
 * Generates a single file using the plugin framework and the given print function.
 * The returned string array represents the generated file content created using printFn.
 */
function generateSingleFile(printFn: (f: GeneratedFile) => void): string[] {
  const req = new CodeGeneratorRequest({
    parameter: `target=ts`,
  });
  const plugin = createEcmaScriptPlugin({
    name: "test-plugin",
    version: "v99.0.0",
    generateTs: (schema: Schema) => {
      const f = schema.generateFile("test.ts");
      printFn(f);
    },
  });
  const res = plugin.run(req);
  if (res.file.length !== 1) {
    throw new Error(`no file generated`);
  }

  const content = res.file[0].content ?? "";
  return content.trim().split("\n");
}

Then your tests will look something like this:
  test("print with tagged template literal works correctly", () => {
    const lines = generateSingleFile((f) => {
      const Foo = f.import("Foo", "foo");
      f.print`export function foo(): ${Foo} { return new ${Foo}(); };`;
    });
    expect(lines).toStrictEqual([
      'import {Foo} from "foo";',
      "",
      "export function foo(): Foo { return new Foo(); };",
    ]);
  });

@smaye81 No problem, thanks for the detail suggestion!


Chore/commits

:tada: This PR is included in version 1.0.0-beta.2 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[DataPipe] Fix missing import in .pyi file

Stack from ghstack:

-> #758

@nivekt has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.


Closing or Back option is not available at feedback form

Issue - Once opened the feedback form there is no option to go back or return.
Solution - I want to add that.
Contributing to - Gssoc'24

@apu52 please assign me this issue under gssoc'24

@ananyag309 please try to raise the issues using the issue templates & properly so that make it understandable attaching demo img or videos

sorry to close this issue


Added routing for full and slim UI versions

I used react-router v4 to provide client-side routing for a "slim" version of the UI (just templates and editor) or the "full" version of the UI. These are served at the following routes:
localhost:3000/ (redirects to localhost:3000/#/) - serves full UI
localhost:3000/#/slim - serves the slim version of the UI
At present the routing scheme used is called Hash Routing and can be used entirely client side. A more familiar version of routing called Browser Routing is also possible, but requires a backend server to support the views served at each route. For now, hash routing was simplest.
For now the only way to navigate to the slim version of the UI is by modifying the URL in the browser's navigation bar. If you want to click on a button on the navbar to change routes, you'll need to move the NavBar component up into the new App.jsx file and add Link components to switch between routes.
This will be my last PR for awhile. Until then...

Can you switch it so the we have /patient which gives the view where it has a patient context (the current UI) and then the root URL will show the no patient view? If that's a big deal then leave it as you have it and add a jira to change it

@gregquinn2001 - I made the change. :)

thanks!!

This works as expected on my end. URL correctly navigates to slim view and full view (when adding /patient). Editor and staging form still works in the slim view

If you still have time, can you add the new technologies that you used for routing to our wiki page?

I think he left Nicole. I'll try to add it

done. I added react-router v4 to list on wiki


[Feature Request] Option to make only the talking NPC visble No side bar for Players

Now that Monks common display has been updated I can finialy use this module. So far it works great.
One thing for the way I use it would be the list of NPC's for selection I dont need that for My players to see so in the config page a turn this off for players would be useful.
keep up the good work.
Axium

A toggle in the config shouldn't be too hard to add and it allows for more flexibility, I will try to add it in the next release.

That's great news and thankyou for all your hard work this has been an excellent addition to my games.

As per your request, with release 5.3.0 I have added an extra toggle in the module settings (Display Participants List) which allows you to enable or disable the list of participants for the players.
If you have any issues or questions, feel free to reach out and I will answer as soon as possible!


Is Aider able to talk about specifc git commit?

Issue
Hi, I would like to ask, if there is an option to talk about specifc commit content and also about commit diff with prev, so quicky understand the changes. If no, I would like to participate to create such a functionallity. Thanks
Version and model info
No response

simple solution that i use currently is /run git log -p <commit_sha>. you can even talk about diffs (useful during code reviews) using /run git diff main or similar

thanks mate, lov this


Update docs with new contract addresses

Thanks for pushing these changes, Tim!
I'm inclined to let Victor and/or someone else more blockchain savvy give this a review before we land it; I don't really feel equipped to assess whether this is clear/sufficient.


Change order and names of anagram tests

Changed names of tests to be consistent and changed the order so that similar tests are grouped together. Added more tests using the canonical data. I didn't add tests for everything in the canonical data because some test cases appeared to be redundant. For example, it looks like the "does not detect false positives" test case checks the same thing as "anagrams must use all letters exactly once". However, I'm happy to add tests for every case if people think I should.
See issue #279 for discussion.

@FridaTveit a few comments in! We deviate in order quite a bit from x-common; I feel like we should either match the standard ordering or propose a change to the x-common ordering with justification. Which do you think is the right choice for this exercise?

I have always assumed that the scope of the "contract" with config.json and tracks only involved the contents of it and not the ordering.  No one told me this.  I didn't read it anywhere.  I just assumed it.
I figured that a given language's features (e.g. default values for arguments, error flows, available standard libraries) would make one path or another flow better.
I have gotten the impression, over the couple years I've been involved, that Track Maintainers have a good amount of autonomy; some argue too much (e.g. there are apparently a whole set of Haskell-oriented exercises in x-common).
I think the appropriate thing is what affords the best UX for the practitioner.  Here, balancing the immediate feel of the Java variation of this exercise with the general feel that all variations of the exercise having the same scope.
Thoughts?

I don't mind too much about the ordering. I found it very confusing as it was since there were two pairs of tests that had nearly exactly the same name but were far apart. Now that their names are slightly different it's less confusing. I still think it makes sense to group the two multiple anagrams tests together but it wouldn't bother me too much if there is another test between them.
Either way it would be nice for future reference to know whether the ordering of the tests in the canonical data is something we have to stick to or whether it's just a suggestion.

Good to know r.e. the ordering! I've always tried to match the canonical ordering, but the viewpoint that we are free to reorder depending on what makes sense in our language of choice seems eminently reasonable :)

@FridaTveit replied; once the changes I confirmed as requests are made, LGTM!

Nice work, @FridaTveit!


Option connectionTimeout should be connectTimeout

Typo: General connection option connectionTimeout  should be connectTimeout instead.

Tedious uses connectTimeout, node-mssql uses connectionTimeout.


feat: Optionally compile out Location APIs

What
Adds an option to compile-out any location privacy-sensitive APIs if you are not using them.
Simply set $VCEnableLocation=false to set the flag, and all CLLocationManager APIs will be removed.
This is useful to get past app review when you are not including the location tag in your Info.plist
Also, the enableFrameProcessors (and new enableLocation) flags in the expo config plugin now work!

Changes

Tested on

Related issues

Closes https://github.com/mrousavy/react-native-vision-camera/pull/2719

Hi Marc,
I get this error while building on Xcode 15.2:

whoops yea just pushed a fix.

@mrousavy i use expo sdk version 50, how to set $VCEnableLocation=false when i use expo build development. Please help me!

before writing "please help me", read the docs.
It's in the Location docs.

@mrousavy  thank you, i just see

https://react-native-vision-camera.com/docs/guides/location
Comment here for somebody same me!


Noise of the Bluetooth HFP via I2S (IDFGH-5488)

Environment
Hardware: ESP32-WROOM-32E
Software: esp-idf V4.3
Example project: \esp32\examples\bluetooth\bluedroid\classic_bt\hfp_ag
Problem Description
I has succeeded playing a sine audio in the Example project.
So I try to read audio data from I2S and send to the bluetooth HFP(HCI protocol).
I changed bt_app_hf.c in the Example project.
I take audio data from i2s_read() and put s_m_rb(RingBuffer) instead of bt_app_hf_create_audio_data().
Then, I heard only noise.
What should I do?
Code to reproduce this issue
I2S config is

i2s_config_t i2s_config = {
    .mode 			= I2S_MODE_SLAVE | I2S_MODE_RX,
    .sample_rate		= 8000,
    .bits_per_sample 		= I2S_BITS_PER_SAMPLE_16BIT,
    .channel_format 		= I2S_CHANNEL_FMT_RIGHT_LEFT,
    .communication_format	= I2S_COMM_FORMAT_STAND_MSB,
    .intr_alloc_flags 		= ESP_INTR_FLAG_LEVEL1,
    .dma_buf_count 		= 4,
    .dma_buf_len 		= I2S_BUFFER_SIZE,
    .use_apll             	= false,
    .tx_desc_auto_clear 	= false,
    .fixed_mclk           	= 0
};

Hi,
I look forward to hearing from you.

Hi, @m-kiso
Different codecs have different sampling rates. The sampling rate using CVSD codec is 8k, and the sampling rate using mSBC codec is 16K. If ESP32 is used as I2S slave, you need to pay attention to the problem of data format (big-endian or little-endian).
Thanks

Hi, @xiongweichao
Thank you for your reply.
I have the following configuration and I want to skip the audio data, but I hear noise in the headset.
[STM32] ---(CVSD 8kHz , 16bit , mono )---> [ESP32] ---( Bluetooth HFP)---> [Headset]
Also, I have written the source as attached, but I cannot come up with a source to convert the frequency.
I am sorry, but if you have a sample source to convert the audio data, please provide it.
audio_gateway\src\main.c
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <string.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "nvs.h"
#include "nvs_flash.h"
#include "esp_system.h"
#include "esp_log.h"
#include "esp_bt.h"
#include "esp_bt_main.h"
#include "esp_bt_device.h"
#include "esp_gap_bt_api.h"

//add
#include "bt_app_core.h"
#include "uart_ctrl.h"
#include "bt_pair_ctrl.h"
#include "i2s_ctrl.h"

#define TAG "MAIN"

void app_main(void)
{
    esp_log_level_set(TAG, ESP_LOG_INFO);

    /* Initialize NVS — it is used to store PHY calibration data */
    esp_err_t ret = nvs_flash_init();
    if (ret == ESP_ERR_NVS_NO_FREE_PAGES) {
        ESP_ERROR_CHECK(nvs_flash_erase());
        ret = nvs_flash_init();
    }
    ESP_ERROR_CHECK(ret);
    ESP_ERROR_CHECK(esp_bt_controller_mem_release(ESP_BT_MODE_BLE));

    esp_err_t err;
    esp_bt_controller_config_t bt_cfg = BT_CONTROLLER_INIT_CONFIG_DEFAULT();
    if ((err = esp_bt_controller_init(&bt_cfg)) != ESP_OK) {
        ESP_LOGE(TAG, "%s initialize controller failed: %s\n", __func__, esp_err_to_name(ret));
        return;
    }
    if ((err = esp_bt_controller_enable(ESP_BT_MODE_CLASSIC_BT)) != ESP_OK) {
        ESP_LOGE(TAG, "%s enable controller failed: %s\n", __func__, esp_err_to_name(ret));
        return;
    }
    if ((err = esp_bluedroid_init()) != ESP_OK) {
        ESP_LOGE(TAG, "%s initialize bluedroid failed: %s\n", __func__, esp_err_to_name(ret));
        return;
    }
    if ((err = esp_bluedroid_enable()) != ESP_OK) {
        ESP_LOGE(TAG, "%s enable bluedroid failed: %s\n", __func__, esp_err_to_name(ret));
        return;
    }

    /* create application task */
    printf("start\n");
    ESP_LOGI(TAG, "start");

    i2s_ctrl_init();

    bt_app_task_start_up();

    bt_pair_ctrl_init();

    uart_ctrl_task_start_up();
}

Regards,

Hi, @xiongweichao Thank you for your reply.
I don't know what this data format (little-endian or big-endian) is, because the audio data is output from the customer's STM32. We are checking now.
What I want to know in a hurry is what kind of conversion expression source I should write for the following configuration.
Or do I not need the conversion formula?
[STM32] ---(CVSD 8kHz , 16bit , mono )---> [ESP32] ---(Bluetooth HFP)---> [Headset].
Regards,

Hi, @m-kiso
Please try to modify the value of I2S_BUFFER_SIZE to be greater than 240. If it still doesn't work, please try the following code if it can solve your problem.
i2s_config_t i2s_config = {
    .mode = I2S_MODE_MASTER | I2S_MODE_TX | I2S_MODE_DAC_BUILT_IN | I2S_MODE_RX | I2S_MODE_ADC_BUILT_IN,
    .sample_rate = 16000,  // CVSD=8000  mSBC=16000
    .bits_per_sample = 16, /* the DAC module will only take the 8bits from MSB */
    .channel_format = I2S_CHANNEL_FMT_RIGHT_LEFT,
    .intr_alloc_flags = 0, // default interrupt priority
    .dma_buf_count = 8,
    .dma_buf_len = 1024,
    .use_apll = true,
};

Thanks

Hi, @xiongweichao
Thank you for your prompt reply!
I will try and reply as soon as possible.
Thanks,

Hi, @xiongweichao
I haven't changed the I2S_BUFFER_SIZE yet, but I did printf the data acquired by I2S and graphed it, and found that it was being sent in a digital data-like format.
Do I need to convert this data if I send it via HFP?

Thanks,

Hi, @xiongweichao

I set I2S_BUFFER_SIZE to 240 or more, but there was no improvement.
If you add the following configuration, ESP32 will reboot on startup

i2s_config_t i2s_config = {
    .mode = I2S_MODE_MASTER | I2S_MODE_TX | I2S_MODE_DAC_BUILT_IN | I2S_MODE_RX | I2S_MODE_ADC_BUILT_IN,
    .sample_rate = 16000, // CVSD=8000 mSBC=16000
    .bits_per_sample = 16, /* the DAC module will only take the 8bits from MSB */ .
    .channel_format = I2S_CHANNEL_FMT_RIGHT_LEFT,
    .intr_alloc_flags = 0, // default interrupt priority
    .dma_buf_count = 8,
    .dma_buf_len = 1024,
    .use_apll = true,
};

If you have a next move, please let me know.
Thanks,

Hi, @xiongweichao
Is there an update on this?
Thanks,

Hi, @m-kiso
Is bt_ctrl_play used?
Thanks

Hi, @xiongweichao
Yes, I do use bt_ctrl_play.
Also, the actual sound you hear is something like this.
2021_07_12_18_45_24.zip
Thanks,

Hi, @m-kiso
But in the source code you provided, I didn't see you using bt_ctrl_play.
You can try using the attachment below, this sound is not noise.
Thanks
audio_example_file.zip

Hi, @xiongweichao
Thank you for your prompt reply!
I apologize for the lack of explanation regarding bt_ctrl_play.
bt_ctrl_play is used in the following way when a message is received by UART.
void uart_ctrl_request_play_voice(uint8_t* dtmp, size_t size){
    uint8_t command = dtmp[3];

    if(m_resp_code == SUCCESS){
        if(command == '0'){
            ESP_LOGI(UART_CTRL_TAG, "play");
            bt_ctrl_play();
            //bt_a2dp_ctrl_play();
        }else if(command == '1'){
            ESP_LOGI(UART_CTRL_TAG, "stop");
            bt_ctrl_stop();
            //bt_a2dp_ctrl_stop();
        }else{
            ESP_LOGI(UART_CTRL_TAG, "unknown");
            bt_ctrl_stop();
            //bt_a2dp_ctrl_stop();
        }
    }

    uart_ctrl_send_response(m_resp_code, NULL, 0);
}

Please tell me, did you check the audio in audio_example_file.zip with HFP?
Thanks,

Hi, @m-kiso

Please check whether the data sent by stm32 is the same as the data received by esp32.
If the data of the two devices are inconsistent, please confirm whether esp32 is used as i2s slave or i2s master. If esp32 is used as slave, the mclk of stm32 needs to be provided by ESP32.
If these methods still cannot solve your problem, please provide the I2S configuration information of stm32 and esp32.

Thanks

Hi, @xiongweichao
I have some good news. I think I've solved this problem.
I shifted the i2s_read value by a higher bit as shown below, and heard clean audio data.
			ret = i2s_read(I2S_NUM, samples, sizeof(samples), &read_bytes, portMAX_DELAY);
			if ((ret == ESP_OK) && read_bytes) {
				len = read_bytes / 2;
					for (i = 0; i < len; i++) {
						buffer[i] = samples[i] >> 8;
					}
					xBytesSent = xStreamBufferSend(stream_buffer, (void*)buffer, len, pdMS_TO_TICKS(100));
			}

I'm not sure why the problem was solved by shifting the upper bits, but this problem can be closed.
Thank you for your support.

@m-kiso Thanks for reporting and sharing updates, and glad the issue resolved, feel free to reopen.


[3073] create openapi spec for courses

Context
Changes proposed in this pull request
Guidance to review
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Create OpenAPI spec for courses


Beautification problem with JS Single Line Comment <!--

In Javascript <!--  is treated as a single-line comment just like //.
js-beautify works as expected when the line starts with <!--:
Input:
<!--alert(1)commented
Output:
<!--alert(1)commented
Otherwise it will break the syntax:
Input:
alert(1)<!--commented
Output:
alert(1) < !--commented

In pure javascript, I don't think <!-- is a comment.
https://www.ecma-international.org/ecma-262/11.0/index.html#sec-comments
If that Javascript is inside a <script> tag in an html file, then <!-- should be treated as a comment.
Beautifier currently supports these as the first element, but not after.
This was due to limitations in the beautifier at one time at this time, it might be reasonable to remove the limitation.
https://github.com/beautify-web/js-beautify/blob/5c00e1d7ec2be058c1c652958bca24e38a1699af/js/src/javascript/tokenizer.js#L285-L300
This is has potential to break some cases so tests will need to be added.

Please refer to annex B1.3 of the ES6 espec.
https://www.ecma-international.org/ecma-262/11.0/index.html#prod-annexB-SingleLineHTMLOpenComment

B.1.3 HTML-like Comments
Comment::
MultiLineComment
SingleLineComment
SingleLineHTMLOpenComment
SingleLineHTMLCloseComment
SingleLineDelimitedComment

SingleLineHTMLOpenComment::
<!--SingleLineCommentCharsopt

Although it's a legacy support as noted:

This annex describes various legacy features and other characteristics of web browser based ECMAScript implementations. All of the language features and behaviours specified in this annex have one or more undesirable characteristics and in the absence of legacy usage would be removed from this specification. However, the usage of these features by large numbers of existing web pages means that web browsers must continue to support them. The specifications in this annex define the requirements for interoperable implementations of these legacy features.

These features are not considered part of the core ECMAScript language. Programmers should not use or assume the existence of these features and behaviours when writing new ECMAScript code. ECMAScript implementations are discouraged from implementing these features unless the implementation is part of a web browser or is required to run the same legacy ECMAScript code that web browsers encounter.

Just to be clear, I have no objection to someone filing a PR to fix this.

Hi
I'm new to contributing a project sources project.
Could I take this issue?

Go for it.

Could you give a example to replicate the ideal behavior? because I'm trying to comment a js code in script tag using <---, but it doesn't work and I did some research I found that it just work in old browsers.

Switch to JavaScript beautification an try the example from the original description.
alert(1)<!--commented

Hi Team, I'm new to contributing a open source projects. I'm unable to run the project in my local computer. it's throws error [make × ERR  not found: make-$(BUILD_DIR)/node] could you tell me how to resolve the issue.
link [https://user-images.githubusercontent.com/36472845/144790219-e9e8d060-8dd0-49a1-8fd8-8d662199126b.png]


tidy fractal

I was trying to use the collection configuration to make directories like partials / explore etc hidden.
It seems that that doesn't work - I'll be taking a peek into the fractal internals to see why not.
In the mean time - I switched to yml for config - comments welcome.

You can add an index.config.json to hide the e.g. explore directory. Or is that not what you mean?
{
  "hidden": "true"
}


Create github pipeline that will update version/hash for Apline (GitHub) and AUR (Git)

Is your feature request related to a problem? Please describe.
At this moment Apline/AUR updates are manual. Please, add github action pipeline that will do that automatically

GoReleaser V2 support AUR:

Arch User Repository Support (aka AUR)

@clee231 you have originally created tenv-bin. Do you want to be a main maintainer of this package? If so, I will add you to a list of maintainers/contributors.

@clee231 I've pushed the change to goreleaser and it updated the package. Do you have a chance to test it on Arch?

@kvendingoldo - I'd be happy to be a maintainer. I haven't done much go programming, but I'm willing to learn more.
Looks like the updates to go-releaser was merged in, so I'll disable my other management repo now. Thanks!

@clee231 I've pushed the change to goreleaser and it updated the package. Do you have a chance to test it on Arch?

Did a quick test and attempted to install the latest version (v2.1.1-1)

Looks like the current PKGBUILD only supports aarch64 and i686 architectures. I also noticed that the PKGBUILD references the arm64 release for a aarch64 architecture. If I'm understanding this correctly, this is the same architecture. I think arm64 is the more common name used in the Linux kernel.
It looks like we are releasing builds only for arm64, armv6, i386, and x86_64, so we should support those architectures in the AUR package too.

Will check goreleaser settings, and fix it tomorrow. Thank you for notice


fix(session): remove retry limit if could not get state

Intent
Keep polling session state if SAS server didn't provide it.
Implementation

Removed RETRY_LIMIT.
Added logic to log info with a particular server response status only once.
Added unit test to cover SAS response with the status 304.

Checks
No PR (that involves a non-trivial code change) should be merged, unless all four of the items below are confirmed!  If an urgent fix is needed - use a tar file.

[x] Code is formatted correctly (npm run lint:fix).

[x] All unit tests are passing (npm test).

[x] All sasjs-cli unit tests are passing (npm test).
Mocked:

Server:

[x] All sasjs-tests are passing (instructions available here).

This PR is tested against DC, everything is working correctly.


Avoid special handling of path-segments with conditional path points

Fixes issue #1351
Brief summary of changes
Fix indexing issue when passing from one path-segment to the next (restore default behavior)
Testing I've completed
Tested other models with visualization issues with conditional path points and multiple wrapping
CHANGELOG.md (choose one)

no need to update because this was a side-effect of earlier fix/internal

Thanks @carmichaelong 👍


feat: Standardize log patterns across all services for consistency.

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12438439560
Commit: 1c48cae7a0d980d487a9387aa96e8b5aaaedeadb
Cypress dashboard.
Tags: @tag.Sanity
Spec:
The following are new failures, please fix them before merging the PR:
cypress/e2e/Regression/ServerSide/OnLoadTests/PostgresConnections_spec.ts
cypress/e2e/Sanity/Datasources/Arango_Basic_Spec.ts
List of identified flaky tests.
Fri, 20 Dec 2024 21:38:49 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Enhanced logging capabilities for various services, including distinct log file paths incorporating hostnames.
Introduced event logging for standard output and error streams.

Bug Fixes

Improved error handling through updated logging configurations.

Chores

Reorganized configuration parameters for better clarity and management across multiple services.
Increased maximum log file sizes from 10MB to 30MB and set backups to zero for all services.

/build-deploy-preview


fix(build): gulp server process never finishing

@dhcodes This should fix the issue

Yep that did it @BerkeleyTrue


Better documentation for how to play a sound

It wasn't obvious to me how to play a sound on ios, here's the requirement:

Place your sound in public/, e.g. pubic/beep.wav
Reference your sound by including www/application/ e.g. www/application/beep.wav

Hmm, the sound referece should be the same in the api (paths could be off?)
https://github.com/raix/push/blob/master/lib/client/cordova.js#L117
https://github.com/raix/push/blob/master/lib/client/cordova.js#L76
I'll take pull requests if your up to it :)

Maybe I'm using an older version of the plugin, let me check that first
before I suggest any changes to the documentation.
On Wed, Feb 4, 2015 at 10:51 AM, Morten N.O. Nørgaard Henriksen <
<EMAIL_ADDRESS>wrote:

Hmm, the sound referece should be the same in the api (paths could be off?)
https://github.com/raix/push/blob/master/lib/client/cordova.js#L117
https://github.com/raix/push/blob/master/lib/client/cordova.js#L76
I'll take pull requests if your up to it :)
—
Reply to this email directly or view it on GitHub
https://github.com/raix/push/issues/36#issuecomment-72891151.

Well I updated to the latest version, but I'm still a little confused.
When is onNotificationAPN called? I'm currently using the push
notification api like so: sound: "www/application/audio/alarm.wav" if the
code you referenced is being called that would seem to result in the
unlikely filename application/www/application/audio/alarm.wav.
(I'm using Push.send to send notifications)
On Wed, Feb 4, 2015 at 10:55 AM, Joshua Ohlman<EMAIL_ADDRESS>wrote:

Maybe I'm using an older version of the plugin, let me check that first
before I suggest any changes to the documentation.
On Wed, Feb 4, 2015 at 10:51 AM, Morten N.O. Nørgaard Henriksen <
<EMAIL_ADDRESS>wrote:

Hmm, the sound referece should be the same in the api (paths could be
off?)
https://github.com/raix/push/blob/master/lib/client/cordova.js#L117
https://github.com/raix/push/blob/master/lib/client/cordova.js#L76
I'll take pull requests if your up to it :)
—
Reply to this email directly or view it on GitHub
https://github.com/raix/push/issues/36#issuecomment-72891151.

I haven't been using the sound part myself - so its something worth investigating/testing/documenting
The onNotification is called on in app notifications - I'm not 100% sure about playing sounds on notifications when the app is in background or closed. But theres a difference there I think.
If we can trigger sound on closed apps its prop. the native sounds?

Audio notifications definitely work differently, I've figured out how to
send audio messages using this format:
        Push.send({
          from: "MyApp",
          title: fromUser.displayName(),
          text: doc.message,
          badge: 1,
          sound: doc.safetyConfirmation ? "www/application/audio/alarm.wav"
: "default",
          query: {
            userId: doc.toId
          }
        });

On Sat, Feb 14, 2015 at 3:04 AM, Morten N.O. Nørgaard Henriksen <
<EMAIL_ADDRESS>wrote:

I haven't been using the sound part myself - so its something worth
investigating/testing/documenting
The onNotification is called on in app notifications - I'm not 100% sure
about playing sounds on notifications when the app is in background or
closed. But theres a difference there I think.
If we can trigger sound on closed apps its prop. the native sounds?
—
Reply to this email directly or view it on GitHub
https://github.com/raix/push/issues/36#issuecomment-74367854.

I agree that better documentation would be nice on this area - I haven't actually tested or used sound in my apps yet, so you guys are prop. better at it than me.
I'm closing this issue but referencing it from the Doc issue


close or refresh webpage trigger crash through nginx proxy

Describe the bug
Start ttyd.x86_64(1.6.2) under Ubuntu 18.04.4 through 'ttyd -p 8080 bash', config nginx(1.14.0) following the wiki instruction.
Then open with Chrome or Edge, If I close or refresh the page, the log says:
WS closed from <IP_ADDRESS>, clients: 0
killing process 26637 with signal: 1 (SIGHUP)
process killed with signal 1 (SIGHUP), pid: 26637
Segmentation fault

To Reproduce
Steps to reproduce the behavior:

Go to 'https://domains.org/ttyd'
Click on 'refresh' or close tab
Crash

Expected behavior
No crash after hard refresh or close.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

OS: Ubuntu 18.04.4
Browser: Any

Additional context
I've did some test and excluded the relation to https or subdomain. If use IP to access ttyd, the issue disappeared.

Seems #557 ist describing the same thing and finally lead to #491

Should be fixed on master now<PHONE_NUMBER>bb98d5f65aebf84f834a9c0913287c).

@flashlab @ravermeister can you check if the binary from this ci build works? thanks
https://github.com/tsl0922/ttyd/actions/runs/446529650

@tsl0922 It has been solved following the link you provide :grinning:
:+1::+1:

@tsl0922 confirmed, I tested the ttyd.aarch64 and it is working perfectly well thanks!


Bing Ads: Invalid client data

I'm using the Bing Ads service, with the getCampaignReport() method, and I keep getting this error:
Invalid client data. Check the SOAP fault details for more information. TrackingId: some-uuid-xxx

Here's my query:
$response = LaravelAds::bingAds()
    ->with($this->client->bing_ads_id) // I've verified I'm using the correct Bing AID
    ->reports($this->dates[0], $this->dates[1]) // The dates are well formatted: yyyy-mm-dd
    ->setFields([
        CampaignPerformanceReportColumn::TimePeriod,
        CampaignPerformanceReportColumn::AccountId,
        CampaignPerformanceReportColumn::CampaignName,
        CampaignPerformanceReportColumn::CampaignId,
        CampaignPerformanceReportColumn::CampaignType,
        CampaignPerformanceReportColumn::Impressions,
        CampaignPerformanceReportColumn::Clicks,
        CampaignPerformanceReportColumn::Conversions,
        CampaignPerformanceReportColumn::Ctr,
        CampaignPerformanceReportColumn::AverageCpc,
        CampaignPerformanceReportColumn::Spend,
    ])
    ->getCampaignReport();

I've double checked my credentials and even generated new ones to be absolutely sure. I've request a new access token, using the artisan command provided. Any ideas what could the issue?

I have same issue!

Hi again. I found the issue. You should change the scope and update Microsoft Bing package to last version
You must update your application to get user consent using the new msads.manage scope. All application developers must take action to use the new scope.
for more information read this document:
Document

@webmid Thanks for pointing me in the right direction with your comment.
My credentials expired yesterday and I couldn't get them renewed, even when manually changing the url to have the new scopes and enabling MFA on my account (Bing docs said MFA was now also mandatory).
Updating laravel-ads to dev-master, solved it.

@webmid How did you change the scope?

@zacksmash
You can see my changes here:
https://github.com/tmarois/laravel-ads-sdk/commit/04021abb4163affaa70be1fcc7f931bab9e9cb71

@webmid That's helpful, thank you!
Do we have an estimate on when this will be incorporated into the package, and released? @timothymarois


Fix for defect where streams are being closed prematurely

When calling methods that return a stream, the stream cannot be read from due to HttpClient being disposed, which results in any requests still in flight being disposed of.
I've done some refactoring so that HttpClient has only one instance and then the credential instances inject a httpmessagehandler rather than being responsible for creating the HttpClient.
Because I've had to make it a single instance I've had to make changes to the way timeouts work, so instead of setting the timeout value on HttpClient I configure the cancellation token to timeout which behaviour wise is the same.
I've also added configure await on awaited calls just as it's considered good practice.

@ItsVeryWindy Hello, thanks a lot for this pull request. It looks good to me overall. I'd love to hear @jgarverick's opinion as well. I don't have any windows build environment nowadays, does your change break the PCL build?
Also, are the changes in Docker.DotNet.BasicAuth/BasicAuthCredentials.cs relevant to HttpClient-related changes? If not, let's take it in a separate PR.

It builds just fine, I've not worked on PCL libraries so I'm not sure if there are additional steps required to make sure.
The changes to BasicAuthCredentials are relevant, because I've shifted the responsibility of managing the HttpClient to the DockerClient instead of it being managed by the Credentials class. Credentials now returns a HttpMessageHandler instead of creating a httpclient so I've had to change the way the authorization headers were being added.

I've made some additional changes to clean things up and ended up moving BasicAuthHandler out of BasicAuthCredentials which would make it more testable.

LGTM as well.  Since the basic auth module is outside the scope of the PCL library it shouldn't be an issue.  It does build just fine for me.  I'll take a deeper look later, though, and try to wire it up to a UWP app or something, just to be certain.

Thanks a lot @jgarverick @itsverywindy.


Add editorconfig and reformat Sonarr JSON files

For only the Sonarr JSON files, I performed a "Reformat Document" in Visual Studio Code. This solved a few issues:

Inconsistent style between JSON files
Difficulty reading the JSON files in web file viewer due to inconsistent indentation characters
Lack of consistent style within a single file

There will now be a consistent formatting style going forward enforced by .editorconfig file.
The diff is large, but all I did was reformat whitespace. There is NO change to the actual data in the JSON files.

@austinwbest I know you parse these files with your tooling. I hope the presence of the .editorconfig in the docs/json/sonarr directory is a non-issue. Can you confirm if that will be ok? I'm hoping you glob for *.json and don't just parse any file in the directory regardless of extension. I can move it out if it will be troublesome.
@TRaSH- Let me know if you prefer the .editorconfig at the root or at a higher level. The reason why I did not put it higher up is because I am not sure we want the style rules to apply to other files outside of this directory (for example the Radarr CF files)

@austinwbest When you get some time, could you bless my PR with your approval? Thank you 😃

Should be fine, i tweaked my side to ignore non .json files


Adds MPI timer for benchmark

This PR adds an MPI timer that wraps another timer. The timer will report the longest duration across all processes. This is mainly helpful to enable the repetitions=auto setting.

format!

rebase!


[Enhancement]Set the parallelism of low-cardinality field tasks to 1 (#31249)

Set the parallelism of low-cardinality field tasks to 1

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
1
1
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)


Add French translation

This is my proposal to add a French translation to FreeOTP.
I sometimes had to not stick to the English base sentences to make it clearer in French.
BTW, is there  difference between "issuer" and "provider"? I decided to stay with "fournisseur" in French which is closer to "provider". A possible translation for "issuer" could be "émetteur".

This is my proposal to add a French translation to FreeOTP. I sometimes had to not stick to the English base sentences to make it clearer in French.

Thank you for the PR.

BTW, is there difference between "issuer" and "provider"? I decided to stay with "fournisseur" in French which is closer to "provider". A possible translation for "issuer" could be "émetteur".

Issuer refers to this specific OTP URI field https://github.com/google/google-authenticator/wiki/Key-Uri-Format#issuer
which essentially means the same thing as the OTP provider.    The issuer parameter is a string value indicating the provider or service this account is associated with
If no more changes are needed I will go ahead and merge this, just let me know.

@justin-stephenson, thanks for the detail.
Let me triple-check my proposal in this case. Would be great if another French-speaking contributor could give it a look. Pinging @futal from PR #174 for example.

Hello
I've just translated the file in Corsican but I have good knowledges in French ;-)
In my opinion, there is no problem to translate issuer by « Fournisseur ».
I noticed a couple of typos on lines 114 and 118 and I added a comment on your file.
Best regards,
Patriccollu.

I've just translated the file in Corsican but I have good knowledges in French ;-)

Thanks for your review @Patriccollu.
Rebased, triple-checked and fixed the typos.
@justin-stephenson, my proposal is now ready to be merged if you are OK with it.

Hi. Sorry for the late reply. I confirmed the changes suggested by @Patriccollu. Here are some more typos I found in mobile/src/main/res/values-fr/strings.xml:

Missing accent (mandatory as it is another word without the accent) in line 65 "Cela peut être du à un changement de paramètres du verrouillage de l'écran." -> "Cela peut être dû à un changement de paramètres du verrouillage de l'écran."
Missing letter in line 117 "Les jetons FreeOTP ont désormais migré vers le magasin de clés Anroid\u00A0!" -> "Les jetons FreeOTP ont désormais migré vers le magasin de clés Android\u00A0!"
Translations on lines 120 and 121 are not good but the expected meaning is not clear enough for me to come with better translations.

Thanks @futal.

Added missing accent line 65 (dû) ;
Added missing d line 117 (Android).

As I understant it, lines 120 and 121 are content description for images (just like alt property for HTML tag img for example). I don't think they are really displayed but could be nice for accessibility, screen reader and stuff like this.

Then lines 120 and 121 are fine for alt properties (it is not clear out of context as there are no uppercase after "Image" but they become clear as alt tags which are usually pronounced with a different voice and the upper case does not matter there).

Thanks again for yours reviews @Patriccollu and @futal.


Add filters on term lists.

here is an example, which should make hbstack really stands out. Thank you.
https://gronskiy.com/tags/web/

is that a way to select both #Search and #DocSearch tags at the same time, where visitors scan just look at doc with #Search and #DocSearch at the same time.

That's possible, but it'll just filter the current list's posts, not all the posts, I don't want to load list data in JS way dynamically on a static site. For example, /series/docs/ list contains 100 posts, the filters of /series/docs/ will only be applied on those 100 posts, won't affect the paginated lists, e.g. /series/docs/page/2, /series/docs/page/3. But you're able to change the paginate (how many posts per list) to suit your needs, it should be good for any size of sites.
The filters below is what I can image:
* Year

* Tags

* Authors

* Categories

* Series

I'll work on it tonight if the solution is OK.

so just to make sure we are on the same page to improve hbstack (although I just asking feature)
visitors can choose,   any combinations of “
Year  (2020,2021,2022,2023)
Tags (linux, window, mac)
Authors (ceo, cfo)
Categories (guide, news)
Series  (s1,s2,s3)
”
like,  so 2020&2021&ceo   where should return all posts of years of 2020 and 2021 where authors is ceo? ( please notice two years are selected in this case of the same columns) , Not fancy UI is needed, just drop down, where visitors check to select tags by each columns ?
just ex:
2020,2021,2022 are selected return all those post with such those tags.
2020,2021,2022, window, mac and cfo are selected return all those post with such those tags, but with condition of  posts with window, mac and written by cfo.
yes. understand to keep good performance, we may need to avoid JS,  (maybe JS solution the solution,  but not as default; only when users of HBStack want good functions and ok with the performance result since it would be a good balance？）

2020&2021&ceo where should return all posts of years of 2020 and 2021 where authors is ceo in all posts?

Hi, thanks for explanation.
The JS is the only way to handle all posts, I could create indices for all posts, filter and show the results, but I'm not going to implement this (filtering all posts) on the list pages for some main reasons:

SEO: RAW HTML are always preferred, avoid using JS as possible.
Complicated: I don't want to combine both of JS and RAW HTML to render the every list pages and theirs pagination, it makes things worse.
Btw, the example sites you mentioned are putting all related posts in the same single pages, and filtering posts in place. This approach works fine on a small site, but it may become an issue if there are hundreds or even thousands of posts on a list. It's no difference with the solution above, you can control how many posts per page, and filter posts in place.

we can just "build" all possible combinations first.

I think that's impossible to create those combinations pages automatically during the build stage.
It sounds more like a search page request.

It sounds more like a search page request.

yes, you are right. seem like it as well.  if search can handle it, why can't just tag? where we pre-build the tags for pre-defined result?
"I think that's impossible to create those combinations pages automatically during the build stage.”  （kind of disagree)
(maybe we need to run a custom script to "build" up all the tags then, run hugo build?

(maybe we need to run a custom script to "build" up all the tags then, run hugo build?

To be clarified, I think we're talking about the prebuilt pages (pure HTML) for all combinations of taxonomies. e.g. /tags/tag1-tag2, /tags/tag-2-tag-3 and so on, if so, just image that, how many combinations pages on a regular site with 100 tags (probably 100! - 100 pages). Other than that, I haven't combined it with the categories, the authors and the years.
That's why I said that's impossible, and the JS is the only way to do that.

yes. was thinking per-build though pages， but not really doing the math at the same time.

That's why I said that's impossible, and the JS is the only way to do that.

so you decided to build a module within the HBStack for this feature  with JS?
Really like HBStack where it provides "whole" package as a solution,  where using one framework can build multiple different purpose sites.

so you decided to build a module within the HBStack for this feature with JS?

Still considering on it, let me summary it up.
You want to filter the all posts in the list pages in current page (not opening a new page to search), which have to render and paginate in both HTML and JS ways, it looks like that include a search page into the list page which I don't like to do, since it complicates the page, for example, we have to hide the original rendered content (posts list and pagination navigation) when performing a search, and re-render the results and create a new pagination navigation according to the results in JS.
We could open a new page to process the filters, but this feature overlaps with the search module, it makes more sense to add taxonomies filter on the search modal.

yes,  you are right,  wonder how we can handle the case where 2021 and 2022 are selected.  (assuming we add   taxonomies filter on the search modal.) since we can only choose one from one column, like below Language （or we can choose all from the column)

Honestly, since  hbstack framework is build with modules, it would make more sense to have a modules for filtering whether with CSS and HTML or JS.
Maybe we could have a filter search page ?  like a search page for complicated filtering.
Thank you for keeping the discussion open and sharing the reasons with it.

wonder how we can handle the case where 2021 and 2022 are selected. (assuming we add taxonomies filter on the search modal.) since we can only choose one from one column, like below Language （or we can choose all from the column)

The select input (dropdown) can have multiple options, e.g. select 2023 and 2022 at the same time.
Planed, but not high priority, probably a search page.

Thank you for accepting this feature, which makes hbstack really stand out comparing to other open source out them with the rest of package from hbstack, can't wait this feature. Thank you again.

Those features were introduced in the search module v0.3.1, I don't want to repeat the dynamic thing in list page, hope this suit your needs.


MultipleOf not used in CodeGeneration.CSharp

I noticed that MultipleOf on number properties is not used/considered when generating classes from JSON Schemas. It's an useful feature to ensure data truncation is noticed before data is serialized.
Is there a way to use it? I tried to use templates to add a custom attribute, but MultipleOf is not exposed in PropertyModel .
Using <IP_ADDRESS>.

What should this generate?

I came up with the following two possibilities that don't depend on external dependencies: https://gist.github.com/basilfx/22a6042ecb9f19da29f8b786e0658cfd.


Remove terminalLogService

It's no longer needed after https://github.com/microsoft/vscode/pull/192932 is merged. fyi @meganrogge

Actually we want to keep this for convenience and the workspace ID logging is still useful


Styled Search Page

Added initial styling to the search page.

Also added code to pull images from the National Parks API and add them to the activities list.


Add Tradegen project to dApp gallery

Description
Add description of Tradegen project and Github link to dApp gallery.

Is this project built on Celo? I don't see any reference to Celo on the website or in the github repo.

Yes, the project is built on Celo. I mentioned it in 'Decentralized social trading platform for tokenized algos' section on home page, 'Platform' section on about page, and on the token info page. I'm finishing testing on Alfajores this week, and will push the tests and Alfajores contract addresses to Github soon.


Typo in schema - fileMatch and url for mapProviders

See here: https://github.com/espocrm/ext-template/commit/eff9d45ea25fc6440bc8d9bbe70532bd80f43d9a#diff-a5de3e5871ffcc383a2294845bd3df25d3eeff6c29ad46e3a396577c413bf357R365
I believe that should be mapProviders instead of mapPproviders. This linke does not work:
https://raw.githubusercontent.com/espocrm/espocrm/master/schema/metadata/app/mapPproviders.json

However, this link does work:
https://raw.githubusercontent.com/espocrm/espocrm/master/schema/metadata/app/mapProviders.json

I assume the filematch argument also needs to be tweaked to remove the extra p.

Fixed. Thanks for reporting.


Windows/Cygwin support

added .bat files to launch "ruby SCRIPT" commands (srclib-ruby toolchain and yard commands)
switched used Ruby to 2.2.2 because 2.1.2 is not available on Windows (see http://rubyinstaller.org/downloads/)
Windows does not provide /dev/null, using NUL instead
srclib library used to parse/format command line options on Windows uses /ARG format, translating command line arguments received by srclib-ruby to POSIX style if needed
using proper executable to bundle or produce YARD documentation cache (bundle/bundle.exe, yard/yard.bat)
replaced invocation of "yard ARGS" with .yardopts_ruby when building YARD cache for Ruby, otherwise yard fails on my machine with SEGFAULT
updated test data to make tests pass
updated documentation, added Windows section

LGTM besides comments


Adding an item to the cart

Sorry, I'm super new to this API. I downloaded the cart example and uploaded it here http://languageofdesire.com/uc/cart_example/template.html I only have one product that has a flat price and no variation in options. How do I set up the one item in this cart? I am not really sure how to pass the API data that will render on this page. I have read all of the basic instructions here http://docs.ultracart.com/display/ucdoc/UltraCart+REST+Checkout+API but it seems as if there are many ways to accomplish this, but I really wanted to use this cart that is already set up. Any help would be greatly appreciated.
Thank you

The cart object has an array named items.  Add an item object to that
array and pass the cart to the /rest/cart (PUT) rest call. It will be
added to the cart.
The object API is out on docs.ultracart.com.  search for "checkout rest".
var items = [];
items.push( {itemId:'myitemid',quantity:1});
cart.items = items;


semantic map

Hi, I have two questions.

what's representation of object in semantic map, including the relationship between objects?
How to find a person after disappearing from the field of vision for robotic?

Hi @liucsg ,

For the semantic map, we use an external module that provides a message of type SemanticMapObjectArray - the SemanticMapObject message (https://github.com/vvasilo/semnav/blob/master/extras/object_pose_interface_msgs/msg/SemanticMapObject.msg) contains an object classification, the pose of the object in 3D and the associated keypoints with respect to the center of mass.
The person detection is more heuristic (just frame by frame), and the robot "remembers" the position in the map it last saw a human and tries to navigate there.


Verify service works with multiple initializations

Verify that service still works properly with multiple initializations.

matchCurrent() starts to stack when multiple initializations in different scopes on same page.

How to resolve this when services are singletons? Keep as a known issue and encourage one instantiation only?

Using new and OOP with services is anti-Angular. Find a different solution.


RFC: Renaming PM APIs

Rename _sys to sys_
Rename _sys_soc -> sys_

Fixes #11047

No objections to this change.
Do we have documentation somewhere which indicates the appropriate use of prefixes (z_, k_, sys_, etc)

@nashif why is this tagged as DNM?

recheck


fs can't load titlebar.css

i'm getting this error after installing and adding to my project
please help

Facing same issue


Jonathanhe/workload network

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

vmware

@zhoxing-ms, can you please review? See my earlier questions about the ids.

@jonathanhe-msft Could you please fix those CI issues?

@jonathanhe-msft Could you please fix those CI issues?

@zhoxing-ms All CI issues have been fixed

It looks good overall, but I have one small question: The file recording the release note is usually HISTORY.rst, and this one is CHANGELOG.md.  May I ask can CHANGELOG.md be modified to HISTORY.rst?

but I have one small question: The file recording the release note is usually HISTORY.rst, and this one is CHANGELOG.md. May I ask can CHANGELOG.md be modified to HISTORY.rst?

Please, let's not change that. A CHANGELOG.md is commonly used in Python long descriptions too. It reads better on Github.
https://github.com/Azure/azure-cli-extensions/blob/ae1689b92d996264961598c1156b58c1e3ef5693/src/vmware/setup.py#L15-L23


Add end-to-end test for Sandbox provisioning

Added tests for GKE cluster
a. Check if machine type is correct.
b. Check if node number is within range.
c. Check if all services are ready.

Your tests are more of integration tests than E2E tests.
E2E test simulate what customers would be doing. Current PR is testing provisioning (which is very important in itself)

Is it possible to test the endpoints to make sure they're returning 200s?

Is it possible to test the endpoints to make sure they're returning 200s?

Only a few endpoints are external. How can I reach them?

Is it possible to test the endpoints to make sure they're returning 200s?

Only a few endpoints are external. How can I reach them?

You can test that publicly facing endpoint of the hipstershop app returns 200 when you query it.
For loadgen, you can test that locust web UI is accessible

Only a few endpoints are external. How can I reach them?

You can find them using commands like this: https://github.com/GoogleCloudPlatform/stackdriver-sandbox/blob/8c0263cb0998e7a71612becd57b71f99a6d8da50/terraform/install.sh#L234
If you want to avoid doing that in Python code, you could make your script require them as arguments or something

Your e2e test fails with:
ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'tests/provisioning/requirements.txt'

@jiang95-dev, I suggest that you address the CR feedback iteratively in order to accelerate the feedback loop.
For example, you can address rebranding remarks first, while taking more time to address running the tests in a container.


buildimage tests: disable these tests due to coveralls reporting 0% coverage

Coverage decreased (-0.6%) to 87.168% when pulling 5b2f3602042123edf1dab65f7a62a7d6d1cf29a3 on coveralls-confusion into 723e8cfe11661599c34ed28e6663b378d62d0df4 on master.

Much better idea, yes.


FIX: python 3 compatibility

This project seems to be dead, but submitting the PR anyway.

Readme needs a update, too

@tacaswell as far as I know this project is not being maintained. I no longer have access to it. @closacco do you have any ideas on what the future of this project might be?

Yeah, unfortunately, there are no plans to maintain this project.

@tacaswell @robmadole @closacco so why wouldn't you give write access to other people interested in this project? I think you can pick several from the pull requests lists (like author of this PR) or from forks graphs.

I would decline to take any further responsibility for maintaining this project (including commit rights) if offered.