helm install turing turing/turing Error: INSTALLATION FAILED

I got this error during installation following this guideline https://github.com/gojek/turing/blob/main/infra/charts/turing/README.md.
Steps

helm install incubator/sparkoperator --generate-name

WARNING: This chart is deprecated
W1128 22:23:02.075723   56032 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1128 22:23:02.080260   56032 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1128 22:23:02.314421   56032 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1128 22:23:02.324651   56032 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
NAME: sparkoperator-1638112978
LAST DEPLOYED: Sun Nov 28 22:23:01 2021
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None

helm install turing-init turing/turing-init --namespace infrastructure --create-namespace

NAME: turing-init
LAST DEPLOYED: Sun Nov 28 22:23:53 2021
NAMESPACE: infrastructure
STATUS: deployed
REVISION: 1
TEST SUITE: None

helm install turing turing/turing

Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [unable to recognize "": no matches for kind "Gateway" in version "networking.istio.io/v1beta1", unable to recognize "": no matches for kind "VirtualService" in version "networking.istio.io/v1beta1"]
My local setup

k3d latest version https://k3d.io/v5.1.0/
helm v3.7.1
kubernetes v1.22.3

Hi @verramuktytoko, thanks for trying out the Helm charts.
As a side node, step 1 is not required.
On the second step, a init job will be created. It is likely that the second step was not completed before you proceeded with step 3. Step 2 takes a while to complete.
You have to check kubectl get pod --namespace infrastructure to check if the init pod has finished running. Programmatically if you run it in a script, you could do kubectl wait -n infrastructure --for=condition=complete --timeout=10m job/turing-init-init where this is a blocking action that will only complete if the service passes (exit code 0 denotes success and other exit codes means failure of the init pod).
Once the second step is complete then step 3 should be working.

I have updated the documentation but please let me know if you still have any more queries.

Hi @ashwinath the deployment is succesful now
NAME: turing-init
LAST DEPLOYED: Mon Nov 29 14:28:20 2021
NAMESPACE: infrastructure
STATUS: deployed
REVISION: 1
TEST SUITE: None
but when I check the pods, there are 2 crash, 1 is pending. as a result, I cannot continue start turing API server.
_kubectl get pod                                   NAME                                           READY   STATUS                  RESTARTS   AGE turing-postgresql-mlp-0                        0/1     Pending                 0          22m turing-vault-agent-injector-5976b6c65c-685lm   1/1     Running                 0          22m turing-postgresql-merlin-0                     1/1     Running                 0          22m turing-postgresql-0                            1/1     Running                 0          22m turing-merlin-567844c58-lqhwk                  1/1     Running                 0          22m turing-vault-0                                 1/1     Running                 0          22m turing-mlp-7cc5f9bb94-jppz7                    0/1     Init:CrashLoopBackOff   8          22m turing-64575957bc-h5dr5                        0/1     CrashLoopBackOff        8          22m_

@verramuktytoko we need more information from you in order to help you to get it running. You can ignore 2 crashing pods for now as it's expected (turing-mlp crashes because it can establish a connection to turing-postgresql-mlp, and turing crashes because it's dependent on turing-mlp). So the only question is why turing-postgresql-mlp is pending.
Can you post the output of:
kubectl get statefulsets/turing-postgresql-mlp -o yaml

My assumption is that because you run it on your local machine, maybe you don't have enough resources (cpu/mem) to accommodate all the necessary Turing components. If it's true, then you have to either 1) scale up your cluster or 2) reduce resources requirements on Turing deployment

If you run kubectl describe pod <pod name>, under the Events section you should be able to see the reason for failure. Could you send the results of kubectl describe pod turing-postgresql-mlp-0?

@romanwozniak this is the output of
kubectl get statefulsets/turing-postgresql-mlp -o yaml
apiVersion: apps/v1
kind: StatefulSet
metadata:
annotations:
meta.helm.sh/release-name: turing
meta.helm.sh/release-namespace: default
creationTimestamp: "2021-11-29T08:25:49Z"
generation: 1
labels:
app: postgresql-mlp
app.kubernetes.io/managed-by: Helm
chart: postgresql-8.9.8
heritage: Helm
release: turing
name: turing-postgresql-mlp
namespace: default
resourceVersion: "4271"
uid: 13e95212-1e07-413a-90d5-e0dba5c1f5aa
spec:
podManagementPolicy: OrderedReady
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app: postgresql-mlp
release: turing
role: master
serviceName: turing-postgresql-mlp-headless
template:
metadata:
creationTimestamp: null
labels:
app: postgresql-mlp
chart: postgresql-8.9.8
heritage: Helm
release: turing
role: master
name: turing-postgresql-mlp
spec:
containers:
- env:
- name: BITNAMI_DEBUG
value: "false"
- name: POSTGRESQL_PORT_NUMBER
value: "5432"
- name: POSTGRESQL_VOLUME_DIR
value: /bitnami/postgresql
- name: PGDATA
value: /bitnami/postgresql/data
- name: POSTGRES_USER
value: mlp
- name: POSTGRES_PASSWORD
valueFrom:
secretKeyRef:
key: postgresql-password
name: turing-postgresql-mlp
- name: POSTGRES_DB
value: mlp
- name: POSTGRESQL_ENABLE_LDAP
value: "no"
image: docker.io/bitnami/postgresql:11.8.0-debian-10-r1
imagePullPolicy: IfNotPresent
livenessProbe:
exec:
command:
- /bin/sh
- -c
- exec pg_isready -U "mlp" -d "mlp" -h <IP_ADDRESS> -p 5432
failureThreshold: 6
initialDelaySeconds: 30
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: turing-postgresql-mlp
ports:
- containerPort: 5432
name: tcp-postgresql
protocol: TCP
readinessProbe:
exec:
command:
- /bin/sh
- -c
- -e
- |
exec pg_isready -U "mlp" -d "mlp" -h <IP_ADDRESS> -p 5432
[ -f /opt/bitnami/postgresql/tmp/.initialized ] || [ -f /bitnami/postgresql/.initialized ]
failureThreshold: 6
initialDelaySeconds: 5
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
resources:
requests:
cpu: 500m
memory: 256Mi
securityContext:
runAsUser: 1001
terminationMessagePath: /dev/termination-log
terminationMessagePolicy: File
volumeMounts:
- mountPath: /dev/shm
name: dshm
- mountPath: /bitnami/postgresql
name: data
dnsPolicy: ClusterFirst
restartPolicy: Always
schedulerName: default-scheduler
securityContext:
fsGroup: 1001
terminationGracePeriodSeconds: 30
volumes:
- emptyDir:
medium: Memory
sizeLimit: 1Gi
name: dshm
updateStrategy:
type: RollingUpdate
volumeClaimTemplates:

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
creationTimestamp: null
name: data
spec:
accessModes:

ReadWriteOnce
resources:
requests:
storage: 10Gi
volumeMode: Filesystem
status:
phase: Pending
status:
collisionCount: 0
currentReplicas: 1
currentRevision: turing-postgresql-mlp-5c8ffd594f
observedGeneration: 1
replicas: 1
updateRevision: turing-postgresql-mlp-5c8ffd594f
updatedReplicas: 1

@ashwinath
I think Roman's guess is correct, this is due to insufficient memory on my local.
Name:           turing-postgresql-mlp-0
Namespace:      default
Priority:       0
Node:           <none>
Labels:         app=postgresql-mlp
                chart=postgresql-8.9.8
                controller-revision-hash=turing-postgresql-mlp-5c8ffd594f
                heritage=Helm
                release=turing
                role=master
                statefulset.kubernetes.io/pod-name=turing-postgresql-mlp-0
Annotations:    <none>
Status:         Pending
IP:
IPs:            <none>
Controlled By:  StatefulSet/turing-postgresql-mlp
Containers:
  turing-postgresql-mlp:
    Image:      docker.io/bitnami/postgresql:11.8.0-debian-10-r1
    Port:       5432/TCP
    Host Port:  0/TCP
    Requests:
      cpu:      500m
      memory:   256Mi
    Liveness:   exec [/bin/sh -c exec pg_isready -U "mlp" -d "mlp" -h <IP_ADDRESS> -p 5432] delay=30s timeout=5s period=10s #success=1 #failure=6
    Readiness:  exec [/bin/sh -c -e exec pg_isready -U "mlp" -d "mlp" -h <IP_ADDRESS> -p 5432
[ -f /opt/bitnami/postgresql/tmp/.initialized ] || [ -f /bitnami/postgresql/.initialized ]
] delay=5s timeout=5s period=10s #success=1 #failure=6
    Environment:
      BITNAMI_DEBUG:           false
      POSTGRESQL_PORT_NUMBER:  5432
      POSTGRESQL_VOLUME_DIR:   /bitnami/postgresql
      PGDATA:                  /bitnami/postgresql/data
      POSTGRES_USER:           mlp
      POSTGRES_PASSWORD:       <set to the key 'postgresql-password' in secret 'turing-postgresql-mlp'>  Optional: false
      POSTGRES_DB:             mlp
      POSTGRESQL_ENABLE_LDAP:  no
    Mounts:
      /bitnami/postgresql from data (rw)
      /dev/shm from dshm (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-bvf92 (ro)
Conditions:
  Type           Status
  PodScheduled   False
Volumes:
  data:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  data-turing-postgresql-mlp-0
    ReadOnly:   false
  dshm:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:     Memory
    SizeLimit:  1Gi
  kube-api-access-bvf92:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason            Age   From               Message
  ----     ------            ----  ----               -------
  Warning  FailedScheduling  21h   default-scheduler  0/1 nodes are available: 1 Insufficient memory.

@verramuktytoko as I suggested, you can try to scale (either vertically or horizontally) your local cluster and try it again.
Otherwise, you can reduce the default resource configuration of the mlp components:

Create configuration file values.yaml:

mlp:
   postgresql:
     resources:
       requests:
         memory: "128Mi"

merlin:
   postgresql:
     resources:
       requests:
         memory: "128Mi"

postgresql:
   resources:
     requests:
       memory: "128Mi"

Pass these values to helm during deployment:

helm install turing turing/turing --values values.yaml

You can learn more about the available configuration values here: https://github.com/gojek/turing/tree/main/infra/charts/turing

@romanwozniak
I have scales up the machine, but there's still 1 crash pod.
NAME                                           READY   STATUS             RESTARTS   AGE
turing-vault-agent-injector-5976b6c65c-r4gb6   1/1     Running            0          3m13s
turing-vault-0                                 1/1     Running            0          3m13s
turing-postgresql-merlin-0                     1/1     Running            0          3m13s
turing-postgresql-0                            1/1     Running            0          3m13s
turing-postgresql-mlp-0                        1/1     Running            0          3m13s
turing-5d546c895d-fmqcf                        0/1     CrashLoopBackOff   4          3m13s
turing-mlp-7cc5f9bb94-4g67s                    1/1     Running            0          3m13s
turing-merlin-567844c58-m4tt4                  1/1     Running            0          3m13s

kubectl describe pod turing-5d546c895d-fmqcf
Name:         turing-5d546c895d-fmqcf
Namespace:    default
Priority:     0
Node:         k3d-mycluster-server-0/<IP_ADDRESS>
Start Time:   Tue, 30 Nov 2021 15:29:12 +0700
Labels:       app=turing
              pod-template-hash=5d546c895d
              release=turing
Annotations:  <none>
Status:       Running
IP:           <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  ReplicaSet/turing-5d546c895d
Containers:
  api:
    Container ID:  containerd://f11e36000a629b2b7a7093f2cdb56956248385e54baf5bd119d8fcfece3d0f1f
    Image:         ghcr.io/gojek/turing:v1.0.0
    Image ID:      ghcr.io/gojek/turing@sha256:f3c25574f290590d76bb25de461faa5b7d08a40bfae034239cf8ddfc6be39e04
    Port:          8080/TCP
    Host Port:     0/TCP
    Args:
      -config
      /etc/turing/config.yaml
      -ui-config
      /etc/turing/ui.config.json
    State:          Waiting
      Reason:       CrashLoopBackOff
    Last State:     Terminated
      Reason:       Error
      Exit Code:    2
      Started:      Tue, 30 Nov 2021 15:32:26 +0700
      Finished:     Tue, 30 Nov 2021 15:32:26 +0700
    Ready:          False
    Restart Count:  5
    Liveness:       http-get http://:8080/v1/internal/live delay=60s timeout=5s period=10s #success=1 #failure=3
    Readiness:      http-get http://:8080/v1/internal/ready delay=60s timeout=5s period=10s #success=1 #failure=3
    Environment:    <none>
    Mounts:
      /etc/turing from config (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-tdlsj (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  config:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  turing-api-config
    Optional:    false
  kube-api-access-tdlsj:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   BestEffort
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason     Age                    From               Message
  ----     ------     ----                   ----               -------
  Normal   Scheduled  3m30s                  default-scheduler  Successfully assigned default/turing-5d546c895d-fmqcf to k3d-mycluster-server-0
  Normal   Pulling    3m30s                  kubelet            Pulling image "ghcr.io/gojek/turing:v1.0.0"
  Normal   Pulled     3m16s                  kubelet            Successfully pulled image "ghcr.io/gojek/turing:v1.0.0" in 13.709799337s
  Normal   Pulled     2m24s (x3 over 3m15s)  kubelet            Container image "ghcr.io/gojek/turing:v1.0.0" already present on machine
  Normal   Created    2m24s (x4 over 3m16s)  kubelet            Created container api
  Normal   Started    2m24s (x4 over 3m16s)  kubelet            Started container api
  Warning  BackOff    2m8s (x12 over 3m14s)  kubelet            Back-off restarting failed container

Another questions, if the turing installation has been successful, I can continue with this step Start Turing API server on this doc right https://github.com/gojek/turing?

@verramuktytoko Can you please share the logs of a failed pod?
Something like this would be helpful:
kubectl logs deploy/turing

Another question, if the turing installation has been successful, I can continue with this step Start Turing API server on this doc right https://github.com/gojek/turing?

No, not really. This is a developers guide, i.e. if you want to build and run Turing from the source. Provided helm chart aims to simplify the deployment of Turing and its dependencies, so there is nothing else required to do once your deployment succeeded

kubectl logs deploy/turing
T```
uring UI config found at /etc/turing/ui.config.json...
Overriding UI config at ./turing-ui/app.config.js
Done.
Launching turing-api server:  ./turing-api -config /etc/turing/config.yaml
{"level":"panic","ts":1638264393.6378675,"caller":"server/application.go:50","msg":"Failed validating config: Key: 'Config.ClusterConfig.VaultConfig' Error:Field validation for 'VaultConfig' failed on the 'required_without' tag\nKey: 'Config.MLPConfig.MLPEncryptionKey' Error:Field validation for 'MLPEncryptionKey' failed on the 'required' tag","stacktrace":"github.com/gojek/turing/api/turing/log.Panicf\n\t/app/turing/log/log.go:59\ngithub.com/gojek/turing/api/turing/server.Run\n\t/app/turing/server/application.go:50\nmain.main\n\t/app/turing/cmd/main.go:9\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"}
panic: Failed validating config: Key: 'Config.ClusterConfig.VaultConfig' Error:Field validation for 'VaultConfig' failed on the 'required_without' tag
Key: 'Config.MLPConfig.MLPEncryptionKey' Error:Field validation for 'MLPEncryptionKey' failed on the 'required' tag
goroutine 1 [running]:
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc000544370, 0x0, 0x0, 0x0)
/app/vendor/go.uber.org/zap/zapcore/entry.go:230 +0x545
go.uber.org/zap.(*SugaredLogger).log(0xc0000101a8, 0x2319204, 0x200a3fe, 0x1c, 0xc000807e48, 0x1, 0x1, 0x0, 0x0, 0x0)
/app/vendor/go.uber.org/zap/sugar.go:234 +0x100
go.uber.org/zap.(*SugaredLogger).Panicf(...)
/app/vendor/go.uber.org/zap/sugar.go:159
github.com/gojek/turing/api/turing/log.Panicf(...)
/app/turing/log/log.go:59
github.com/gojek/turing/api/turing/server.Run()
/app/turing/server/application.go:50 +0x267
main.main()
/app/turing/cmd/main.go:9 +0x20

https://github.com/gojek/turing/issues/136#issuecomment-982411614
so the turing API server is automatically started after deployment is successful?
and we can directly create router, open turing UI http://host:3001/turing

Another question, if the turing installation has been successful, I can continue with this step Start Turing API server on this doc right https://github.com/gojek/turing?

No, not really. This is a developers guide, i.e. if you want to build and run Turing from the source. Provided helm chart aims to simplify the deployment of Turing and its dependencies, so there is nothing else required to do once your deployment succeeded

so the turing API server is automatically started after deployment is successful?
and we can directly create router, open turing UI http://host:3001/turing

@romanwozniak there's a small bug here: https://github.com/ashwinath/turing/blob/1648cd2dc270f25c7ae72aafed6dd1207733b2e5/infra/charts/turing/values.yaml#L278
Needs to have a default key, but user is recommended to override it.
@verramuktytoko For now the workaround is to set this value in your values.yaml. So it should look something like this now:
mlp:
   postgresql:
     resources:
       requests:
         memory: "128Mi"

merlin:
   postgresql:
     resources:
       requests:
         memory: "128Mi"

postgresql:
   resources:
     requests:
       memory: "128Mi"

global:
  mlp:
    encryption:
      key: somevaluehere

Another question, if the turing installation has been successful, I can continue with this step Start Turing API server on this doc right https://github.com/gojek/turing?

No, not really. This is a developers guide, i.e. if you want to build and run Turing from the source. Provided helm chart aims to simplify the deployment of Turing and its dependencies, so there is nothing else required to do once your deployment succeeded

so the turing API server is automatically started after deployment is successful? and we can directly create router, open turing UI http://host:3001/turing

Due to how Kubernetes work, this is not the case. If your Kubernetes setup allows for LoadBalancer service type, you should be able to get the external ip from istio-ingressgateway in kubectl get service -n istio-system. i.e. echo "$(kubectl get svc -n istio-system | grep istio-ingressgateway | awk '{print $4}')/turing"

@romanwozniak there's a small bug here: https://github.com/ashwinath/turing/blob/1648cd2dc270f25c7ae72aafed6dd1207733b2e5/infra/charts/turing/values.yaml#L278

Yes, it's included in the values.minimal.yaml, but I agree that we may set a default key for it as well.
@verramuktytoko Please take a look at values.minimal.yaml as it may give you a better sense about what other config values you may need to tweak in your production deployment later on.

Another question, if the turing installation has been successful, I can continue with this step Start Turing API server on this doc right https://github.com/gojek/turing?

No, not really. This is a developers guide, i.e. if you want to build and run Turing from the source. Provided helm chart aims to simplify the deployment of Turing and its dependencies, so there is nothing else required to do once your deployment succeeded

so the turing API server is automatically started after deployment is successful? and we can directly create router, open turing UI http://host:3001/turing

You can also port-forward istio-ingresgateway to make the entire deployment accessible on your localhost:
kubectl -n istio-system port-forward istio-ingressgateaway 8080:80

With that, you'll be able to access Turing UI at localhost:8080/turing
Note: in order to access Turing UIm you need to configure oAuthClientId and pass it here: https://github.com/gojek/turing/blob/9fff67e9749a595a5164072357bd23bdf5bb1f6b/infra/charts/turing/values.minimal.yaml#L4
See: https://developers.google.com/adwords/api/docs/guides/authentication#generate_oauth2_credentials

is it correct if I use values.yaml like this? should I change the key value?
global:
  mlp:
    encryption:
      key: somevaluehere

I still got the same deployment error. Steps that I executed

re-create cluster
re-install turing/init
re-install turing/turing using this command helm install turing turing/turing --values values.yaml

Result
NAME                                            READY   STATUS             RESTARTS   AGE
turing-init-spark-operator-webhook-init-7rmsw   0/1     Completed          0          15m
turing-init-spark-operator-5b89d6567d-fgczn     1/1     Running            0          15m
turing-init-init-84xzh                          0/1     Completed          0          15m
turing-vault-agent-injector-5976b6c65c-xwzcs    1/1     Running            0          9m52s
turing-vault-0                                  1/1     Running            0          9m52s
turing-postgresql-merlin-0                      1/1     Running            0          9m51s
turing-postgresql-mlp-0                         1/1     Running            0          9m51s
turing-postgresql-0                             1/1     Running            0          9m51s
turing-mlp-7cc5f9bb94-kkr2g                     1/1     Running            0          9m52s
turing-merlin-567844c58-gttbx                   1/1     Running            0          9m52s
turing-5d546c895d-wnvhl                         0/1     CrashLoopBackOff   6          9m52s

Turing UI config found at /etc/turing/ui.config.json...
Overriding UI config at ./turing-ui/app.config.js
Done.
Launching turing-api server:  ./turing-api -config /etc/turing/config.yaml
{"level":"panic","ts":1638326620.3388672,"caller":"server/application.go:50","msg":"Failed validating config: Key: 'Config.ClusterConfig.VaultConfig' Error:Field validation for 'VaultConfig' failed on the 'required_without' tag","stacktrace":"github.com/gojek/turing/api/turing/log.Panicf\n\t/app/turing/log/log.go:59\ngithub.com/gojek/turing/api/turing/server.Run\n\t/app/turing/server/application.go:50\nmain.main\n\t/app/turing/cmd/main.go:9\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"}
panic: Failed validating config: Key: 'Config.ClusterConfig.VaultConfig' Error:Field validation for 'VaultConfig' failed on the 'required_without' tag

goroutine 1 [running]:
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc000728840, 0x0, 0x0, 0x0)
	/app/vendor/go.uber.org/zap/zapcore/entry.go:230 +0x545
go.uber.org/zap.(*SugaredLogger).log(0xc000486040, 0x2319204, 0x200a3fe, 0x1c, 0xc00077de48, 0x1, 0x1, 0x0, 0x0, 0x0)
	/app/vendor/go.uber.org/zap/sugar.go:234 +0x100
go.uber.org/zap.(*SugaredLogger).Panicf(...)
	/app/vendor/go.uber.org/zap/sugar.go:159
github.com/gojek/turing/api/turing/log.Panicf(...)
	/app/turing/log/log.go:59
github.com/gojek/turing/api/turing/server.Run()
	/app/turing/server/application.go:50 +0x267
main.main()
	/app/turing/cmd/main.go:9 +0x20

is it correct if I use values.yaml like this? should I change the key value?

You should change the values in turing/infra/charts/turing/values.minimal.yaml and use that as your values.yaml file.
As for the logs, why it's erroring out, it's due to a mistake in default values on our part. Could you override this value? turing.clusterConfig.useInClusterConfig should be true


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20211119163441911 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20211119163441911 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.61%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27086

Relevant Lines:
59040

💛  - Coveralls


[WIP] fix: discover instances in all available zones

Fixes #5239
Description
Updates instance type discovery to use zones from the instance type offerings rather than via DescribeAvailabilityZones. This maintains a single source of truth for zones while also discovering non-az zones (e.g. local zones).
How was this change tested?

[x] make test
[ ] /karpenter snapshot
[ ] local zone e2e tests

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 15 (100.0%)  changed or added relevant lines in 1 file are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 82.396%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.32%

pkg/fake/ec2api.go
8
85.86%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
4910

Relevant Lines:
5959

💛  - Coveralls


All features, can add the option to accept the contents of the file without having to pass in one file at a time.

Is it possible to add an option inside the program to accept code contents directly as input instead of having to accept a file?

I'm not sure if I understood you correctly, but you should be able to do things like:
cat some-file | verible-verilog-lint - , verible-verilog-lint - < some-file
I'm not sure if it is documented, after a quick look I couldn't find it.


Exports fail to codesign

Godot version
v4.0.rc2.mono.official [d2699dc7a]
System information
Windows 10
Issue description
I've just set up code signing but am being given a large number of the same error:

Steps to reproduce
Unsure, attempting to codesign using Identity Type = Certificate Store with a personal code signing certificate.
Minimal reproduction project
N/A

Changing Identity Type to PKCS12 file successfully signs the export with the following warnings:

Type = Certificate Store with a personal code signing certificate.

Have you entered a SHA1 hash in the codesign/identity field? Or are you using file + password.
There are two options for signing:

Auto: identity and password are ignored.
Certificate Store: identity should be SHA1 hash, password is ignored.
PKCS12: identity should be certificate file path and password should be set if certificate is encrypted.

Changing Identity Type to PKCS12 file successfully signs the export with the following warnings:

Check the log, this warning indicate that signing was not successful.

I tried both methods, only file + password works successfully.


RecoveryServicesClient methods are internal.

The constructors for RecoveryServicesClient are all marked as internal, so they can't be used at all.  Is this on purpose?

@johnwc Hey John, this is a known issue that is currently being worked on by the RecoveryServices team.
I will assign this to @dragonfly91 for future updates.

@Siddharth7 to take a look

@AdityaTulasi to take a look

Is this still an issue?


Implement bootloader to restore "golden copy" of firmware from FRAM storage

After researching and discussing with Toshi, we will utilize the dual banks in the flash memory, where the first bank will be the running Application while the second bank will be the Golden Copy. In order continue working on this, we will need to be able to upload a golden copy which will require its own telecommand and write the flash banks. Since this will be useful for #18, I will create another issue and continue working on that.


Fix issue #1454

Remove exception supression from remote_storage.FindRequest
Include intervals.py from Main
Update remote_storage.FindRequest.get_results to be compatible with both
old and new metrics/find api pickle packet formats

FWIW this PR returns the exact same test failures as 0.9.x, those failures should be corrected, but I'm not sure I have a stomach for the archeology to find where they were introduced.

s/1554/1454/g ?

@deniszh Yah, thanks. I fixed it

I'm :+1: for not swallowing the exceptions but I really dont think we should be bringing in the intervals stuff into 0.9.x or shimming in compatibility to cluster with the master branch

The safe unpickler in 0.9.15 ALREADY referenced graphite.intervals, so it appears that it was the intention of that code for it to already be available. I've not done the archeology to find when/why intervals appeared in master or what the alternative to that type in a pickle packet should be or how that mapping should be implemented.
I will say that if such a trivial change brings cross version api compat in a way that make federation work that it'd be a big win for facilitating changing versions in production without trying to cut everything over at once. It seems, to me, a good value from a marginally distasteful change.

So whats the consensus here? I'm fine running this patch out of tree to scratch my own itch, as it were. I still think this looks like the right way to handle this in tree. If bringing intervals from master is really that distasteful it seems that the unpickler code in 0.9.x should also have references to it scrubbed.

Yeah, the unpickler code should be cleaned up - I'm sure that's just
copypasta
I'd still like to see that exception swallowing go away, but I remain
unconvinced that bringing in compatibility across major versions is a good
idea. Supporting cross-version clusters complicates debugging user problems
and could cause people silent breakage rather than a fail-fast break as
things in master change. It's also bad precedent to set - we need to be
able to break compatibility to move forward. For instance, supporting
archived timesteps in Ceres will require significant changes to
intervals.py (support for comparing intervals of different timesteps). We
already have a sort of hell keeping the changes that come in to 0.9.x added
to master, I'd rather us not start committing to going the other direction
too
On Tue, Feb 2, 2016 at 11:07 AM, Dave Rawks<EMAIL_ADDRESS>wrote:

So whats the consensus here? I'm fine running this patch out of tree to
scratch my own itch, as it were. I still think this looks like the right
way to handle this in tree. If bringing intervals from master is really
that distasteful it seems that the unpickler code in 0.9.x should also have
references to it scrubbed.
—
Reply to this email directly or view it on GitHub
https://github.com/graphite-project/graphite-web/pull/1455#issuecomment-178692183
.

+1 to @mleinart's comment

K, fair. I'll rejigger this PR when I have a few moments free.


Windows support?

Was trying it out on Windows, it spits out:
    import pwd
ModuleNotFoundError: No module named 'pwd'

While in setup we see:
  Environment :: Web Environment

I guess it might be awesome to add windows support. I am willing to do it!

Personally I have no interest in adding Windows support or maintaining it.
But if someone else (e.g. you) is willing to do that and it doesn't complicate things too much (especially the logic to run it as a daemon) fine.

I plan to add it to the dev workflow of the shopyo project of mine as i don't want a ruby or node package and this seems the most viable option. I'll guess i have to look at the internals docs.

Abandoned Idea


Have copypaste handle an active network better

This fixes the issue with the roster UI showing up over the copypaste screen as well as supporting the copypaste view exiting to a better location
Closes #954
Tested by setting up connections with and without being logged in to Google as well and leaving the copypaste view both by ending the connection and clicking the back button.

There are a lot of potential issues we might run into if we support both copy+paste and social-network-login at the same time.  I think it would be safest just to disable copy+paste completely when logged into a social network, and vice-versa.
Examples of things I think will break or be weird if we support copy+paste and social-network-login at the same time:

the black status bar currently only accounts for logged in networks and not copy and paste
I don't believe remoteProxyInstance gets set by copy+paste.  This is what the social-network code relies on to tell if you are proxying or not
the icons setting code has some switches based on how many users you are giving access to.  Copy+paste does not interact with this code.
Logout currently disconnects any proxy sessions (either getting or sharing), but does not change copy+paste sessions

So in other words, right now if you are logged into a social network, you can't initiate a copy+paste session as a getter.  This is good.
But what I think is still missing is:

clicking on copy+paste links while logged into a social network should be disabled (we probably should just display an error message)
if you do start a copy+paste session as a getter, you shouldn't be able to click back and log into a social network without first stopping the copy+paste session (socksToRtc.stop())

Okay, I'm fine with changing that to disabled.  I think the first to commits in this request are still good changes overall  to have in the app but  am going to revert the third one since it does not fit with having the two modes totally exclusive of each other.

Sounds good.  Do you want to make the remaining changes in this pull request or another?

I'll make them here.
On Mon, Feb 23, 2015 at 11:38 AM, dborkan<EMAIL_ADDRESS>wrote:

Sounds good. Do you want to make the remaining changes in this pull
request or another?
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/pull/973#issuecomment-75578638.

:+1:


Add fieldset and legend to radio inputs in the shows components

The odin, python and the new math curriculum has radio inputs, and they don't have fieldset and legend elements, that give some context for the screenReaders.
here is an example
https://github.com/freeCodeCamp/freeCodeCamp/blob/28cbf6a4bdd2f81b936845112ecb8d23e4faa45a/client/src/templates/Challenges/video/show.tsx#L249-L274
We can add fieldset and legend to work as context for screen readers and add className sr-only so they won't change the visual looks in the page.
I don't know what context should be added tho.

There is no hurry to close this, what context did you use in your PR, and is it translatable?

This format makes sense to me 👍🤔.

I'm going to create a PR later today with a proof of concept on how this might work. I've already got most of it in place since I've been working on it this past week.

@huyenltnguyen Can you take a look at this?


Declaring minor version for dotnet-sdk-2.2

Problem encountered on https://dotnet.microsoft.com/download/linux-package-manager/debian9/sdk-2.2.101
Operating System: Linux Debian 9 - x64
While apt was updating my machine, I realized, that dotnet SDK was updated from 2.2.101 to 2.2.105. For my infrastructure its not possible to upgrade the application for now(Docker usage). Is there any way to specify the "2.2.101" version for apt?
Thanks in advance
Wolf

@sewol2405 - you can see specific available versions with apt-cache madison dotnet-sdk-2.2. To install, use apt-get install dotnet-sdk-2.2=2.2.101-1
Keep in mind that this will also install the older runtime files which means you will be missing any security updates which have been released. You can install the updated runtimes separately with apt install aspnetcore-runtime-2.2 (or if you don't need ASP, apt install dotnet-runtime-2.2)

Seems to be answered. Feel free to reopen if I am wrong. Thanks!


Backport "HBASE-28879 Bump hbase-thirdparty to 4.1.9" to branch-3

#6295

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m  5s

branch-3 passed

+1 :green_heart:
compile
8m 11s

branch-3 passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

-1 :x:
mvninstall
4m 34s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
8m  9s

the patch passed

-0 :warning:
javac
8m  9s
/results-compile-javac-root.txt
root generated 14 new + 1195 unchanged - 11 fixed = 1209 total (was 1206)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  2s

No new issues.

+1 :green_heart:
hadoopcheck
10m 39s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m  9s

patch has 36 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s

The patch does not generate ASF License warnings.

43m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6296

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 37fae04e681b 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 78f3aa0bed507267462585dbd9dc6d6e636a982a

Default Java
Eclipse Adoptium-17.0.11+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
192 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/1/console

versions
git=2.34.1 maven=3.9.8 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

-0 :warning:
yetus
0m  2s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m 46s

branch-3 passed

+1 :green_heart:
compile
2m 15s

branch-3 passed

+1 :green_heart:
javadoc
2m  5s

branch-3 passed

+1 :green_heart:
shadedjars
6m 17s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m  5s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
2m 25s

the patch passed

+1 :green_heart:
javac
2m 25s

the patch passed

+1 :green_heart:
javadoc
2m  8s

the patch passed

+1 :green_heart:
shadedjars
6m  8s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
21m 33s
/patch-unit-root.txt
root in the patch failed.

50m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6296

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3f392d58d4a2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 78f3aa0bed507267462585dbd9dc6d6e636a982a

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/1/testReport/

Max. process+thread count
1489 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s

branch-3 passed

+1 :green_heart:
compile
9m 48s

branch-3 passed

+1 :green_heart:
spotless
0m 55s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  1s

the patch passed

+1 :green_heart:
compile
10m 22s

the patch passed

-0 :warning:
javac
10m 22s
/results-compile-javac-root.txt
root generated 14 new + 1195 unchanged - 11 fixed = 1209 total (was 1206)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
hadoopcheck
13m 36s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 10s

patch has 36 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

51m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6296

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 66e91889bf37 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 70a101911382cf64fd46b21a5bf8594dfed90407

Default Java
Eclipse Adoptium-17.0.11+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/2/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
191 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/2/console

versions
git=2.34.1 maven=3.9.8 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 53s

branch-3 passed

+1 :green_heart:
compile
2m 10s

branch-3 passed

+1 :green_heart:
javadoc
2m 15s

branch-3 passed

+1 :green_heart:
shadedjars
6m  9s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s

the patch passed

+1 :green_heart:
compile
2m 21s

the patch passed

+1 :green_heart:
javac
2m 21s

the patch passed

+1 :green_heart:
javadoc
2m 35s

the patch passed

+1 :green_heart:
shadedjars
6m 18s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
323m 34s

root in the patch passed.

360m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6296

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 867d943784f3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 70a101911382cf64fd46b21a5bf8594dfed90407

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/2/testReport/

Max. process+thread count
8730 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 16s

branch-3 passed

+1 :green_heart:
compile
7m 57s

branch-3 passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  8s

the patch passed

+1 :green_heart:
compile
7m 52s

the patch passed

-0 :warning:
javac
7m 52s
/results-compile-javac-root.txt
root generated 14 new + 1196 unchanged - 11 fixed = 1210 total (was 1207)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
hadoopcheck
12m 17s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

44m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6296

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 3b0e0942950d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 6d1622a05972d65352f5b88c990d332b7e6f005f

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
191 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/3/console

versions
git=2.34.1 maven=3.9.8 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  5s

branch-3 passed

+1 :green_heart:
compile
2m  2s

branch-3 passed

+1 :green_heart:
javadoc
2m 15s

branch-3 passed

+1 :green_heart:
shadedjars
5m 32s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
2m  2s

the patch passed

+1 :green_heart:
javac
2m  2s

the patch passed

+1 :green_heart:
javadoc
2m 15s

the patch passed

+1 :green_heart:
shadedjars
5m 33s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
280m 57s

root in the patch passed.

315m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6296

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b3d568714fd5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 6d1622a05972d65352f5b88c990d332b7e6f005f

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/3/testReport/

Max. process+thread count
8396 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 21s

branch-3 passed

+1 :green_heart:
compile
10m 37s

branch-3 passed

+1 :green_heart:
spotless
0m 50s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 53s

the patch passed

+1 :green_heart:
compile
10m 40s

the patch passed

-0 :warning:
javac
10m 40s
/results-compile-javac-root.txt
root generated 14 new + 1196 unchanged - 11 fixed = 1210 total (was 1207)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
hadoopcheck
13m 39s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
1m 14s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

56m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6296

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 145030a068c3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / b28b7f480ab0933c3a2a6067ec6c30c8864cc003

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
190 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/4/console

versions
git=2.34.1 maven=3.9.8 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

-0 :warning:
yetus
0m  2s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  3s

branch-3 passed

+1 :green_heart:
compile
2m  4s

branch-3 passed

+1 :green_heart:
javadoc
2m 14s

branch-3 passed

+1 :green_heart:
shadedjars
5m 32s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
2m  6s

the patch passed

+1 :green_heart:
javac
2m  5s

the patch passed

+1 :green_heart:
javadoc
2m 15s

the patch passed

+1 :green_heart:
shadedjars
5m 30s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
284m  5s

root in the patch passed.

317m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6296

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3628d7bd25d7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / b28b7f480ab0933c3a2a6067ec6c30c8864cc003

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/4/testReport/

Max. process+thread count
8374 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6296/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Report helper function errors

Some helper functions return error codes when failing, but currently,
bpftrace does not check and discards it. Several times I had to use bcc
to check error codes for debugging.
This patch adds an error checking mechanism, and helper function errors
are reported in runtime. For example:
% sudo BPFTRACE_MAP_KEYS_MAX=2 ./src/bpftrace -e \
  'BEGIN { @[0] = 0; @[1] = 1; @[2] = 2;}'
Attaching 1 probe...
stdin:1:35-36: WARNING: Failed to map_update_elem: Argument list too long (-7)
BEGIN { @[0] = 0; @[1] = 1; @[2] = 2;}
                                 ~

^C

@[0]: 0
@[1]: 1

This mechanism is implemented as an async action. By default, errors of
bpf_probe_read()-related functions and bpf_map_lookup_elem() are not
checked. This is because when these functions fail, bpftrace returns
zero as a result, and some scripts already check it, for example, by
using predicate / @[tid] /. --check-all-helpers option forces to
check all errors including these functions. --disable-helper-check
option disables any helper error checks.
Note that the error check increases code size. All codegen tests are
performed with the error check disabled.

I think this solves #464.
I forgot to mention but this uses perf_event_output() for error reporting, so an error of perf_event_output() is not reported. An error message is printed using bpftrace.error() and is not included in json if an output format is json.

This is the comparison of processed insn sizes (not the actual code size. Since the verifier explorers all possible code path, processed insn size becomes larger than the code size). Multiple values mean that the scripts have multiple functions.
So, basically error checking increases the number of processed insn by tens or hundreds, but some scripts (especially which have many map updates) increase code size by thousands (e.g., capable.bt). I also measured the compilation times but I didn't see noticeable differences with and without error checking. I didn't measure runtime speed.
I'm still wondering what is the best default behavior, and I'd appreciate any feedback.

tools
default
--check-all-helper
--disable-helper-check

tcpsynbl.bt
14,14,185,185
14,14,478,478
14,14,139,139

bashreadline.bt
161,14
161,14
161,14

tcpaccept.bt
394,391
394,1166
394,331

tcpconnect.bt
362,14
362,14
362,14

runqlen.bt
14,92
14,251
14,70

writeback.bt
2094,34,516,14
2094,34,546,14
828,14,453,14

setuids.bt
270,154,154,272,200,201,314
270,154,154,272,298,299,513
270,45,45,71,123,124,197

mdflush.bt
149,14
149,14
149,14

loads.bt
14,66
14,215
14,66

biosnoop.bt
159,14,253,198
159,14,352,198
159,14,182,42

cpuwalk.bt
14,62
14,77
14,41

opensnoop.bt
211,36,36,266,266,14
211,36,36,318,318,14
211,15,15,193,193,14

capable.bt
10463,14,365
10515,14,379
3382,14,335

naptime.bt
256,182
256,633
256,154

dcsnoop.bt
193,175,14,42
193,223,14,86
193,121,14,21

biostacks.bt
14,14,278,278,132
14,14,341,341,132
14,14,185,185,27

xfsdist.bt
14,250,250,250,250,14,94,94,94,94
14,305,305,305,305,14,94,94,94,94
14,150,150,150,150,14,30,30,30,30

pidpersec.bt
14,42,41,14
14,57,41,14
14,21,41,14

biolatency.bt
14,14,191,34
14,14,236,34
14,14,134,14

runqlat.bt
14,36,36,363,14
14,36,36,388,14
14,16,16,135,14

tcpretrans.bt
3262,14,875
3262,14,1769
1229,14,875

threadsnoop.bt
117,14
117,14
117,14

statsnoop.bt
181,36,36,36,36,161,161,161,161,14
181,36,36,36,36,195,195,195,195,14
181,15,15,15,15,108,108,108,108,14

tcpdrop.bt
3278,14,975
3279,14,1915
1246,14,894

vfsstat.bt
14,41,14,42,42,42,42,42,42,42,42
14,41,14,57,57,57,57,57,57,57,57
14,41,14,21,21,21,21,21,21,21,21

oomkill.bt
14,14
14,14
14,14

syncsnoop.bt
177,70,72,70,72,72,72
177,70,72,70,72,72,72
177,43,44,43,44,44,44

syscount.bt
14,162,14
14,203,14
14,53,14

swapin.bt
41,14
41,14
41,14

execsnoop.bt
101,218
101,707
101,218

killsnoop.bt
227,93,171
227,93,270
227,29,115

bitesize.bt
14,198,14
14,221,14
14,177,14

gethostlatency.bt
193,14,216,216,216,94,94
193,14,275,275,275,94,94
193,14,163,163,163,30,30

tcplife.bt
490,14,1015
490,14,2110
490,14,635

Nice, this is useful :)
Seems like the processed instruction count is actually reduced in the --disable-helper-check case, what is going on there?

Thanks for the review, will fix.
"default" in the above table means the default behavior when this patch applied (so it checks errors other than bpf_probe_read_xxx / bpf_map_lookup_elem). --disable-helper-check does not check error at all, and this is the same behavior as the current.

I examined the generated code. Basically, this error check creates one branch and adds 10 instructions per helper function call. A problem is a branch creates another state and the verifier needs to explore paths both that take a branch and not. This is the reason the processed instructions sharply increase in scripts that call many helper functions. The verifier prunes a search if two states are equivalent, but unfortunately not.
I'm wondering if we can implement this functionality using bpf-to-bpf call. I guess it reduces states. I'll give it a try later. (there is little information about this..)

I fixed the reviewed points and changed the option since the initial version was a bit confusing:

-k : emit a warning when a bpf helper returns an error, except read functions (bpf_probe_read_xxx(), bpf_map_lookup_elem()).

The reason excludes these functions is described in the commit message.

-kk: check all helper function errors.

Therefore, if these options are not given, program behavior is the same as the current. What do you think about this? @fbs
(As I wrote, I'm seeing if bpf-to-bpf call is usable, but I don't plan to include it in this PR even if it works.)

Nice, this looks really useful. Code looks good to me. Can you add some codegen tests with the error checks and also a runtime test or two? Just so we don't accidentally break this later.
Sorry about the delay, didn't see this PR. In the future feel free to ping me if PR get delayed too much.

Updated:

Rebased onto master
Use unordered map instead of map
Add comments about IntCast
Add codegen and runtime tests

Please take a look when you have time @danobi


modify argument ordering in bi_gru encoder

So readthedocs runs python 3.4, which doesn't like having kwargs before positional args. This is "fixed" in 3.5. This PR makes the ordering backwards compatible
example (on 3.4, both work in 3.5):
In [1]: dict(y=2, **{'x': 1})
Out[1]: {'x': 1, 'y': 2}

In [2]: dict(**{'x': 1}, y=2)
  File "<ipython-input-2-5b28e96ee1a8>", line 1
    dict(**{'x': 1}, y=2)
                   ^
SyntaxError: invalid syntax

merging this while i can ;)


[$250] 'Recents' contacts when submitting expense does not update

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: n/a
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @flodnv
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724228186903849
Action Performed:

Submit an expenses 3 days in a row to the same workspace
Right after the 3rd time, go to submit another expense
Observe that the workspace is still not in 'Recents' (although another workspace is there that I don't even use on NewDot)

Expected Result:
The workspace where I always submit to should be in 'Recents' when using it every day
Actual Result:
I don't see the workspace in 'Recents', I have to type it out every day
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021833488575321005184
Upwork Job ID:<PHONE_NUMBER>321005184
Last Price Increase: 2024-09-17
Automatic offers:

c3024 | Contributor | 104052304

Issue OwnerCurrent Issue Owner: @Ollyws

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@flodnv are these steps right?

Submit an expenses 3 days in a row to the same workspace
Right after the 3rd time, go to submit another expense

Does it have to be 3 expenses over 3 days?

No, maybe it's just 1. I used 3 in my example to point out that it's obvious it should be there.

Put an iOS vid above, but doing a web one now for commentary, this is a real bug that I think is recreatable just by:

Be invited to a Workspace in a normal active Expensify account (that has recent chats)
Submit at expense on that workspace
Submit an expense from the "+" fab
In the "recents" which appear, the workspace doesn't appear at all

We should absolutely during the "Submit expense" flow especially be prioritising places you have submitted expenses before and Workspace chats overall, over ALL normal chats where no expenses have been shared whatsoever.
https://github.com/user-attachments/assets/c2dea30d-6d83-4caa-a351-84544c3a12d4

Asking for some proposals here: https://expensify.slack.com/archives/C01GTK53T8Q/p1726487090872509

Proposal
Please re-state the problem that we are trying to solve in this issue.
Recent reports do not show the workspace chat even though an expense was submitted to it recently.
What is the root cause of that problem?
We give the highest priority only to the active policy here in ordering
https://github.com/Expensify/App/blob/4b41dd187dc63ab01af824f106f1ea1bb189523d/src/libs/OptionsListUtils.ts#L1576-L1583
For all other policies, even though there were some expenses recently submitted to them they were given a lower priority than DMs here
https://github.com/Expensify/App/blob/4b41dd187dc63ab01af824f106f1ea1bb189523d/src/libs/OptionsListUtils.ts#L1594-L1599
So, only the user's active policy is at the top but after that DMs with others are prioritized over non-active policies.
What changes do you think we should make in order to solve the problem?
We should give a higher weightage for policies here after the active policies like
                if (option.isPolicyExpenseChat && preferPolicyExpenseChat) {
                    return 0; // or 0.1 if we want the policies to appear after the active policy. If we want to just order the policies (including active policy) by the last activity on it 0 works fine.
                }

Or we can break with a second argument to the sort like
return lodashOrderBy(
    options,
    [
        (option) => {
            if (option.isPolicyExpenseChat && preferPolicyExpenseChat && option.policyID === activePolicyID) {
                return 0;
            }

            if (option.isPolicyExpenseChat && preferPolicyExpenseChat) {
                return 0;
            }

            // other values
        },
        (option) => option.policyID === activePolicyID,
    ],
    ['asc', 'desc'],
);

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Recent reports do not show the workspace chat even though an expense was submitted to it recently.
What is the root cause of that problem?
We give the highest priority only to the active policy here in ordering
https://github.com/Expensify/App/blob/4b41dd187dc63ab01af824f106f1ea1bb189523d/src/libs/OptionsListUtils.ts#L1576-L1583
For all other policies, even though there were some expenses recently submitted to them they were given a lower priority than DMs here
https://github.com/Expensify/App/blob/4b41dd187dc63ab01af824f106f1ea1bb189523d/src/libs/OptionsListUtils.ts#L1594-L1599
So, only the user's active policy is at the top but after that DMs with others are prioritized over non-active policies.
What changes do you think we should make in order to solve the problem?

I think the order should be like this for Submit Expense flow

Active policy at the top
Sort reports by the time of last money request made
Other workspace chats (where no requests are not made yet)
Others in the other of last activity on the report

To achieve this order, we can add a field lastMoneyRequestTime to reportOption when there is an action in the request like this
if (!!action) {
                const iouReportID = reportOption.iouReportID;
                if (iouReportID) {
                    const iouReportActions = allSortedReportActions[iouReportID] ?? [];
                    const lastIOUAction = iouReportActions.find((iouAction) => iouAction.actionName === "IOU");
                    if (lastIOUAction) {
                        reportOption.lastMoneyRequestTime = lastIOUAction.lastModified;
                    }

            }

here
https://github.com/Expensify/App/blob/2af5a95b658f6426d411f1fa6ea5377507c65dbe/src/libs/OptionsListUtils.ts#L1983
and we can pass a parameter to orderOptions such as preferRecentExpenseReports here
https://github.com/Expensify/App/blob/2af5a95b658f6426d411f1fa6ea5377507c65dbe/src/libs/OptionsListUtils.ts#L2032
like this
recentReportOptions = orderOptions(recentReportOptions, searchValue, {preferChatroomsOverThreads: true, preferPolicyExpenseChat: !!action, preferRecentExpenseReports: !!action});

and the sorting in orderOptions can be changed to
function orderOptions(options: ReportUtils.OptionData[], searchValue: string | undefined, {preferChatroomsOverThreads = false, preferPolicyExpenseChat = false, preferRecentExpenseReports = false} = {}) {
    return lodashOrderBy(
        options,
        [
            (option) => {
                if (option.isPolicyExpenseChat && preferPolicyExpenseChat && option.policyID === activePolicyID) {
                    return 0;
                }
                if (option.isSelfDM) {
                    return 0;
                }
                if (preferRecentExpenseReports && !!option?.lastMoneyRequestTime) {
                   // We are reducing the `lastMoneyRequestTime` to a number between 0 and 1 with min and max times as -+1 years
                    const oneYearInMs = 365 * 24 * 60 * 60 * 1000; // Approximate milliseconds in one year
                    const today = new Date();
                    const minTime = new Date(today).getTime() - oneYearInMs;
                    const maxTime = new Date(today).getTime() + oneYearInMs;
                    const lastMoneyRequestTimestamp = (new Date(option.lastMoneyRequestTime).getTime() - minTime)/(maxTime - minTime);
                    return 1 - lastMoneyRequestTimestamp;
                }
                if (preferRecentExpenseReports && option.isPolicyExpenseChat) {
                    return 1;
                }
                // other reports
            },
            preferRecentExpenseReports ? (option) => option?.isPolicyExpenseChat : 0,
        ],
        ['asc', 'desc'],
    );
}

We can similarly pass the action prop to filterOptions from MoneyRequestPariticipantSelector
const newOptions = OptionsListUtils.filterOptions(defaultOptions, debouncedSearchTerm, {
           // other params
            preferPolicyExpenseChat: isPaidGroupPolicy,
            action,
        });

as use that action prop to check for preferRecentExpenseReports and pass it to orderOptions in filterOptions.
What alternative solutions did you explore? (Optional)

The order that @c3024 suggests sounds good to me:

I think the order should be like this for Submit Expense flow

Active policy at the top
Sort reports by the time of last money request made
Other workspace chats (where no requests are not made yet)
Others in the order of last activity on the report

Does this sound good to you, @twisterdotcom ?

Yeah, this seems logical. I see an argument for switching 2 and 3, but on balance I agree prioritising places you have submitted expenses before is better.

PR was deployed to production on 1-Oct. Payment is due today!
cc: @twisterdotcom

Payment Summary:

@Ollyws paid $250 via NewDot Requests
@c3024 paid $250 via Upwork here


Apply latest changes in Core elements in app templates

PR 27 has some layout issues (see Taipy issue 277).
This was fixed and need to be propagated.
Another problem in templates is the use of the non-recommended import * construct, that needs to be taken care of.

The default behavior solves the issue.


Add an example config for OpenRouter

Closes #2
Description
This PR updates the Installation section of the README to include some basic configuration that allows the simple example presented to run successfully.

Thank you


Avoid bypassing interceptors?

Hi,
I just started using your library for batch updates/deletes, and ran into a compatibility issue with another library that I use: https://efcache.codeplex.com/
It is a cache system for EF with automatic invalidation of cache entries when data modifications occur through EF. It uses interceptors on the database connection to check for inserts/updates/deletes.
However it does not work with batch updates/deletes coming from EntityFramework.Extended. I reported the problem here and the author said that it seems your code is bypassing interceptors, on which the other library relies. It there a reason for that and can it be changed?
Thanks
Xavier

+1
Not only delete and update are bypassed, but also even selects, if they go through "Future Queries" feature.

I believe this may be the same issue I'm seeing using MiniProfiler (https://github.com/MiniProfiler/dotnet) with FutureCount() queries.  Regular EF queries are captured by MiniProfiler but future calls (tried with both FutureCount and FutureFirstOrDefault) are not captured.

I put together a pull request for this.
https://github.com/loresoft/EntityFramework.Extended/pull/164

Hope to see this pull request merged in (and new NuGet package released) in the near future.  The future queries has the potential to really improve the performance of some apps I support but I can't really introduce this in without MiniProfiler working as I'm dependent on it for testing and opitimization.

Thanks for the fix! I hope this will get merged.
Would this also be applicable to batch updates/deletes?

I seems that the pull request only corrected the "Future" queries, however the same approach may be used to add interception support for batch update / deletes.

fixed with pull #140

Sorry but is this really closed? Seems like the referenced pull request is only about future queries, not batch updates/deletes?

ah, correct.  Sorry about that.

As I understand it, this fix would also solve problems when using with EntityFramework.DynamicFilters ( https://github.com/jcachat/EntityFramework.DynamicFilters) .

Unfortunately, it appears this fix did not help with MiniProfiler.  Just loaded up the latest NuGet package (168) and I still have nothing in the log for queries which go through the Future() call.  Verified against SQL Server Profiler and can definintely see the future query bundle being run and can see where in the MiniProfiler output the bundle should have occured.  Instead, all I have is a 100ms gap in the log.

We are also using EntityFramework.DynamicFilters. It is very important for our application but it does not seem to work with batch updates.
Could someone please fix that? :-|
Is there even a plan to fix this behavior?

Auditing seems to not be working with batch updates and deletes. I think this issue is related. The pull request merged by @pwelter34 seems to solve the issue only with future queries. How to get this working with batch updates and deletes?

I put https://github.com/loresoft/EntityFramework.Extended/pull/237 to support interception for BatchExtentions functions.


up2date and fixed

updated the cheat to the latest update.
"fixed" the crash on loading ingame on team selection screen.
Misc FrameStageNotify is the problem, so "fixed" it by commenting it out.
edit: The only thing broken by the "fix" is the third person view.
ESP/glow is also broken but probably because something there needs updating.

@akasarx I have tried your fork and it actually works, just visuals are not working for some reason...

Newest commit adds sanity checks to the saving, so for example saving or loading will no longer crash CSGO.
It also removes the IsDormant check as this no longer exists AFAIK

Fixed cursor.
cl_mouseenable is no longer in the game, so replaced with InputSystem()->EnableInput();

Added the full CInput struct, still can't fix the third person but oh well at least the cheat "works".
Interfaces::Input()->m_fCameraInThirdPerson on CMisc::FrameStageNotify is broken if anyone wants to try.


CUDA is not found in latest Docker image

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
Building CUDA-based packages is not possible in Docker container. This issue occurred after update Docker image.
CUDNN and TensorRT seems exist in container, reported by
dpkg -s libcudnn8
dpkg -s libnvinfer8

however cmake macros can't find them.
Expected behavior
Can build package.
Actual behavior
Can't build package.
Steps to reproduce
./docker/run.sh  --devel
cd /workspace
sudo rm -r install/tensorrt_common/ build/tensorrt_common/
colcon build --packages-up-to tensorrt_common

Output:
CMake Warning at CMakeLists.txt:15 (message):
  cuda, cudnn, tensorrt libraries are not found

It applies for all packages which use CUDNN / TensorRT.
Versions
No response
Possible causes
No response
Additional context
No response

@youtalk
Base on last commit I switched to 20240903-devel-cuda tag and it works. Maybe it will helpful for you for issue investigation.

Oh great! Could you close this issue?

Oh great! Could you close this issue?

@youtalk
I'm not sure if we can close this issue. If any breaking change within Autoware dependencies appear, 20240903-devel-cuda will become incompatible. universe-devel-cuda needs to allow CUDA-related packages to be built.
Is it an unknown bug or is it related to temporary state because of changes in Docker containers?

@amadeuszsz It might be an unknown bug because I expect the current autoware:base-cuda image is installed CUDA drivers https://github.com/autowarefoundation/autoware/blob/main/docker/Dockerfile#L28.

Hi @marioney
Packages which uses CUDA does not work in Docker container for now.  As mentioned in previous post, please use 20240903-devel-cuda image before fix release.

Thanks for the reply.
I'm using 20240903-devel-cuda in the meantime, hopefully this can be solved soon.  The main inconvenience of using an older version is that I need to compile most packages locally (e.g. the full autoware.universe stack) and to figure out the right version of the other packages.

Thank you for both of your feedback. The fixed images will be built within few hours.


Finding bundle locally?

Hi Rafael,
Firstly thanks for making this resource!
I'm trying to test the site locally so I'll run npm start & open the html file and it won't find the bundle.js file:
GET file:///build/bundle.js net::ERR_FILE_NOT_FOUND               index.html:94
It works fine on my github page domain (johnfiorilla.website). Can you offer some instruction on how to do this? Pretty new to webpack & stuff so I'd appreciate it! Thanks!

You need access the index.html from the server (in this case webpack-dev-server), the default is http://localhost:8080, or the scripts won't load. I just added a note to the readme about this.