Faster trace id generation

Replaces #786
While working on #786 we found that most of the performance benefit came from a more efficient method of generating trace ids. This PR implements the more efficient method while allowing us to continue using the simpler string implementation for trace and span ids.
/cc @Flarna

Codecov Report

Merging #824 into master will decrease coverage by 1.52%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #824      +/-   ##
=========================================
- Coverage   94.13%   92.6%   -1.53%
=========================================
  Files         242     241       -1
  Lines       10515   10714     +199
  Branches     1027    1042      +15
=========================================
+ Hits         9898    9922      +24
- Misses        617     792     +175

Impacted Files
Coverage Δ

...ackages/opentelemetry-core/src/platform/node/id.ts
75% <100%> (-25%)
:arrow_down:

...s/opentelemetry-core/test/context/B3Format.test.ts
50% <0%> (-50%)
:arrow_down:

packages/opentelemetry-core/test/utils/url.test.ts
50% <0%> (-50%)
:arrow_down:

...pentelemetry-core/test/internal/validators.test.ts
50% <0%> (-50%)
:arrow_down:

...elemetry-core/test/trace/spancontext-utils.test.ts
55.55% <0%> (-44.45%)
:arrow_down:

...lemetry-core/test/trace/ProbabilitySampler.test.ts
56.52% <0%> (-43.48%)
:arrow_down:

...s/opentelemetry-core/test/trace/tracestate.test.ts
65.06% <0%> (-34.94%)
:arrow_down:

...ntelemetry-core/test/trace/NoRecordingSpan.test.ts
71.42% <0%> (-28.58%)
:arrow_down:

...kages/opentelemetry-plugin-dns/test/utils/utils.ts
33.33% <0%> (-26.67%)
:arrow_down:

...entelemetry-core/test/common/ConsoleLogger.test.ts
77.01% <0%> (-22.99%)
:arrow_down:

... and 42 more

It would be nice to have some benchmarks
on the "crypto.randomBytes(TRACE_ID_BYTES).toString('hex')" vs uuid() vs "original implementation"
just for communicating those changes in a better way

It would be nice to have some benchmarks (numbers)
on the "crypto.randomBytes(TRACE_ID_BYTES).toString('hex')" vs uuid() vs "original implementation"
just for communicating those changes in a better way

UUID only generate 16 byte random values, introduces a dependency, and returns strings containing dashes which need to be stripped, but I have included it here for completeness.
'use strict';

const benchmark = require('./benchmark');
const crypto = require('crypto');

const suite = benchmark(100)
    .add('return start.toString() + end.toString()', function () {
        const start = crypto.randomBytes(8);
        const end = crypto.randomBytes(8);
        return start.toString() + end.toString()
    })
    .add('return input.toString("hex")', function () {
        const input = crypto.randomBytes(16);
        return input.toString('hex')
    })
    .add('uuid', function () {
        const uuid = require("uuid");
        return uuid.v4().replace(/-/g, '')
    })

// run async
suite.run({ async: false });

  return start.toString() + end.toString() x 231,749 ops/sec ±0.96% (100 runs sampled)
  return input.toString("hex")             x 442,410 ops/sec ±0.94% (100 runs sampled)
  uuid                                     x 335,371 ops/sec ±0.97% (100 runs sampled)

method
time

8 byte to hex + 8 byte to hex
4.315µs (91% slower)

16 byte to hex
2.26µs

uuid
2.982µs (32% slower)

Wow @obecny that is a big difference. The only concern I have is that this is lowercase only. I know the trace context spec states that the ids will be lowercase, but I think it is not a bad idea to be resilient to bad inputs where the case is the only problem.

@obecny applied your change

lgtm, if you can please add just simple unit test for function toHex.

That would require us to export the toHex function, but I don't think we should as it is an internal detail. As long as this test passes, we know ids are being generated correctly: https://github.com/open-telemetry/opentelemetry-js/blob/cf93906a9b736bd15d1f094ec803eae67c17bdde/packages/opentelemetry-core/test/platform/id.test.ts
I expanded it in f539c9939d19d67a494fe62a81872c9572179838 in order to make sure the ids we generate are robust, which you can see here: https://github.com/open-telemetry/opentelemetry-js/blob/f539c9939d19d67a494fe62a81872c9572179838/packages/opentelemetry-core/test/platform/id.test.ts


Talks about Repairnator

Talk at EclipseCon 2019: https://www.eclipsecon.org/europe2019/sessions/human-competitive-patches-automatic-program-repair-repairnator

Speaker: https://github.com/monperrus/
Automatic repair: http://web.eecs.umich.edu/~weimerw/p/weimer-tse2011-genprog-preprint.pdf
Human competitive patches<EMAIL_ADDRESS>Luc Esape: https://github.com/lucesape
Ditto patch: https://github.com/eclipse/ditto/pull/151/files
Repairnator: https://github.com/eclipse/repairnator/

Repairnator on Youtube: https://www.youtube.com/watch?v=sHkogNGyBSs


Fix player's vertical velocity taking too long to update when landing on ground

This PR seeks to fix #143, a problem that causes strange behavior when the player lands on the very edge of a corner while holding down to roll. The bug is caused by the line "parent.movement.y = min(parent.movement.y,0)" taking too long to trigger because it's in the physics_process function, which isn't typically an issue but causes problems in this one case. This PR makes this code execute in the state_activated function of the normal and rolling player states, setting the player's Y movement to 0 on the same frame as the landing and fixing this problem.

Just want to say we'll test this as soon as one of us have time. this has been sitting here a few days and I just want to make it clear this isn't being ignored, life just gets in the way

My immediate inclination is that this is the wrong approach to fixing #143 - There is something that has to kick off the transition to state normal / state rolling before the logic of activating the state can take effect, so whatever that is should be responsible for setting y velocity to 0 ahead of changing the state. The way this is, we would never be able to change to normal state without zeroing y velocity and I can't help but imagine that there are legitimate reasons to do that, particularly in the design of certain gimmicks or enemies.

The way this is, we would never be able to change to normal state without zeroing y velocity and I can't help but imagine that there are legitimate reasons to do that, particularly in the design of certain gimmicks or enemies.

Y velocity was zeroed when changing to the normal state before, since it's in the physics_process function of the state script. I can't imagine any kind of mechanic that would warrant delaying the change in velocity by a couple of imperceptible frames.

There is something that has to kick off the transition to state normal / state rolling before the logic of activating the state can take effect, so whatever that is should be responsible for setting y velocity to 0 ahead of changing the state.

To my understanding, the normal state is entered from the air state based on the ground bool set by PhysicsObject.gd, which is true if the object's raycasts are colliding or if move_and_slide determines that the object is on the ground. I don't think you'd want that script to determine this sort of thing, since interactions with the terrain should be decided by the object extending from the PhysicsObject class and not the class itself.
Perhaps, rather than having the ground and rolling states make this determination, it would be cleaner to put the logic in the Air state's state_exit function? Something like, "if parent.ground, then parent.movement.y = min(parent.movement.y,0)". I suppose it is quite messy to add activation functions to Normal.gd and Air.gd for this one problem, and I believe this would have the same effect.

I may have been mistaken about normal.gd being a state that you can be in while airborne. Not 100% positive on that still, it's not documented the best.
As far as I'm aware, PhysicsObjects don't normally use these states, it's only the player objects specifcially that do -- in which case we should be fine using a universal behavior for connecting to ground like this in the state rather than with the specific physic object. Am I mistaken?

As far as I'm aware, PhysicsObjects don't normally use these states, it's only the player objects specifcially that do -- in which case we should be fine using a universal behavior for connecting to ground like this in the state rather than with the specific physic object. Am I mistaken?

From what I know, you're right, the PhysicsObject class just sets flags that are used by the Player object to decide when to switch to some states; the PhysicsObject class doesn't have a state machine of its own.

I may have been mistaken about normal.gd being a state that you can be in while airborne. Not 100% positive on that still, it's not documented the best.

For this reason I named an equivalent state "Ground" in my own project. I'm almost certain that the Normal state is only for ground movement.
Soon I'll go ahead and make the change I suggested to this PR and then hopefully everything should be good from there.

Sorry if those commits are sloppily done, I've never edited a PR before. But I removed the changes to Normal.gd and Roll.gd and moved this fix to Air.gd's state_exit function, as I suggested. Everything should be good from here.

Looks minimally invasive and like it targets the problem directly. Approved.


Rename Button to LinkButton

Follow-up to discussions started here #342 and here #344.
Summary
The naming of Surface's <Button> component leads to confusion as it looks like a wrapper for a generic html <button>, but is actually based on Phoenix's Phoenix.HTML.Link.button/2 (thanks @mcrumm for pointing this out!).
Phoenix.HTML.Link.button/2 does not wrap a generic html <button>, it is a special helper for creating buttons that submit data to the server.
Here examples from Phoenix's documentation:

button("hello", to: "/world")
#=> <button class="button" data-csrf="csrf_token" data-method="post" data-to="/world">hello</button>

button("hello", to: "/world", method: :get, class: "btn")
#=> <button class="btn" data-method="get" data-to="/world">hello</button>

Reasons for this PR
We should rename Surface's <Button> to avoid confusion and help users better understand the purpose of this component.
Naming Suggestions:

Surface.Components.LinkButton
Surface.Components.Link.Button

I went with 1. as it's close enought to the Phoenix name, but also fits better into our module structure, but I'm open to discussion/suggestions.

@miguel-s changes look good to me, however, wouldn't be more intuitive to follow phoenix's naming as:
Phoenix.HTML.Link.button -> Surface.Components.Link.Button
It's not a strong opinion actually. It's more like a hunch :)

And just to make it clear, I would prefer LinkButton if we weren't trying to map Phoenix's components.

@msaraiva I did think about it. But then should we also change the <Link> component, which is based on Phoenix.HTML.Link.link?
Do we keep it as Surface.Components.Link or should we be strict and change it to Surface.Components.Link.Link (looks a bit silly 😅) to match the Phoenix helper, too?

 Let's leave it as LinkButton then :)

Personally I think LinkButton will make it less intuitive to newbies that it mirrors Phoenix's button helper.
I'm training multiple people on Phoenix/LiveView/Surface at work so this opinion doesn't come from a vacuum.

@paulstatezny great to have an opinion from developers in training 👍
So looks we have 3 options for naming these components:
Option 1: Strict mapping of Phoenix to Surface
Phoenix.HTML.Link.link/2 -> Surface.Components.Link.Link
Phoenix.HTML.Link.button/2 -> Surface.Components.Link.Button
Option 2
Phoenix.HTML.Link.link/2 -> Surface.Components.Link
Phoenix.HTML.Link.button/2 -> Surface.Components.LinkButton
Option 3
Phoenix.HTML.Link.link/2 -> Surface.Components.Link
Phoenix.HTML.Link.button/2 -> Surface.Components.Link.Button
Either 2. or 3. work for me. @msaraiva @Malian @paulstatezny @lnr0626 what's your vote?

I have a slight preference for 3

I also have a slight preference for 3.

Let's go with 3 then :)


size theme

https://github.com/Prometheum01/Flutter-Music-App/blob/5f86ea172bb99c650644ae1ef60a7c3c61043213/music_app/lib/widgets/duration_text.dart#L16
size theme dan okumali 14luk olani sen uretebilrisin

Temizlendi


problems encountered when running on a GPU

Hi,
I noticed that in trainer.py, when you write the code to return a numpy array from a tensor, you use tensor.detach().numpy() about five times without specifying the tensor.cpu().detach().numpy(). Please fix them. Thanks!
By the way, what should I do when the model selects zero gene sets?

Well, it seems that there are some other problems. When dealing with the annotator training step, some tensors are not on the same device, and I am not familiar with your code, so, can you also help me fix them?

hello, I tried different alpha values, but the model did not select any gene sets... Is it possible caused by some wrong input format? Could you please specify the requirements of input h5ad data?

Hi, thanks for reporting this. We've been mainly tested the method on CPU before and we are now investigating the problems when running it on a GPU. We will keep you posted.
As for the input data format, you may take a look at the example data (see section "Download and Preprocess the Input Data" for details). Briefly, we use gene symbols to match the input gene expression data with the known gene sets so it is desirable that your input .h5ad file is indexed with gene symbols (i.e.  your h5ad file.var.index should be gene symbols). Let us know if you still have problems in selecting gene sets.

Oh, yes, I forget to use the gene symbols, thank you for your tips!

Hi, sorry for taking so long but we finally fixed the errors having tensors on different devices when running with GPU. Thanks for your feedback again!

Thank you!


Config Validator failing when in isolated network environment

Version 2.3.0
Config Validator errors when running the scan. Inventory completes fine, CAI export is on the bucket.
Error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/scanner/scanner_builder.py", line 99, in _instantiate_scanner
    module = importlib.import_module(module_name)
  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/scanner/scanners/config_validator_scanner.py", line 21, in <module>
    from google.cloud.forseti.scanner.scanners.config_validator_util import (
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/scanner/scanners/config_validator_util/cv_data_converter.py", line 22, in <module>
    from google.cloud.asset.v1.assets_pb2 import Resource
ModuleNotFoundError: No module named 'google.cloud.asset.v1'; 'google.cloud.asset' is not a package

Confirmed
-rw-r--r-- 1 root root 12340 Oct 31 23:32 assets_pb2.py
located in:
/home/ubuntu/forseti-security/google/cloud/asset/v1
Deployed manually (via terraform, but not the module). Custom Startup Script:
#!/bin/bash
set -eu

# Env variables
USER=ubuntu
USER_HOME=/home/ubuntu
# # INTERNET_CONNECTION="$(ping -q -w1 -c1 google.com &>/dev/null && echo online || echo offline)"
INTERNET_CONNECTION=online
# export PIP_INDEX_URL="https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"

# # Log status of internet connection
# if [ $INTERNET_CONNECTION == "offline" ]; then
#   echo "Forseti Startup - A connection to the internet was not detected."
# fi

# forseti_conf_server digest: ${forseti_conf_server_checksum}
# This digest is included in the startup script to rebuild the Forseti server VM
# whenever the server configuration changes.

# set apt sources
# remove default cloud sdk apt
rm -f /etc/apt/sources.list.d/partner.list

# add ubuntu sources
sed -i 's~http://security.ubuntu.com/ubuntu~https://artifactory.xxx.xxx/artifactory/ubuntu-security~g' /etc/apt/sources.list
sed -i 's~http://australia-southeast1.gce.archive.ubuntu.com/ubuntu~https://artifactory.xxx.xxx/artifactory/au-archive-ubuntu~g' /etc/apt/sources.list

# add artifactory repo for gcloud sdk
if ! [ -e "/etc/apt/sources.list.d/google-cloud-sdk.list" ]; then
  echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] https://artifactory.xxx.xxx/artifactory/google-pkg/apt cloud-sdk main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list
  curl https://artifactory.xxx.xxx/artifactory/google-pkg-cache/apt/doc/apt-key.gpg | apt-key --keyring /usr/share/keyrings/cloud.google.gpg add -
fi

# Ubuntu update.
echo "Forseti Startup - Updating Ubuntu."
sudo apt-get update -y
# sudo apt-get upgrade -y
sudo DEBIAN_FRONTEND=noninteractive apt-get -y -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" upgrade
sudo apt-get update -y
sudo apt-get --assume-yes install google-cloud-sdk git unzip

if ! [ -e "/usr/sbin/google-fluentd" ]; then
  echo "Forseti Startup - Installing GCP Logging agent."
  cd $USER_HOME
  export http_proxy="http://x.x.x.x:80"
  export https_proxy="http://x.x.x.x:80"
  curl -sSO https://dl.google.com/cloudagents/install-logging-agent.sh
  unset http_proxy
  unset https_proxy
  # update repos to point at artifactory
  sed -i "s~REPO_HOST='packages.cloud.google.com'~REPO_HOST='artifactory.xxx.xxx/artifactory/google-pkg'~g" $USER_HOME/install-logging-agent.sh
  sed -i "s~deb\ http:~deb\ https:~g" $USER_HOME/install-logging-agent.sh
  bash $USER_HOME/install-logging-agent.sh
fi

# Check whether Cloud SQL proxy is installed.
if [ -z "$(which cloud_sql_proxy)" ]; then
  echo "Forseti Startup - Installing GCP Cloud SQL Proxy."
  cd $USER_HOME
  export http_proxy="http://x.x.x.x:80"
  export https_proxy="http://x.x.x.x:80"
  wget https://dl.google.com/cloudsql/cloud_sql_proxy.linux.amd64
  sudo mv cloud_sql_proxy.linux.amd64 /usr/local/bin/cloud_sql_proxy
  chmod +x /usr/local/bin/cloud_sql_proxy
  unset http_proxy
  unset https_proxy
fi

# Install Forseti Security.
cd $USER_HOME
if [ $INTERNET_CONNECTION == "online" ]; then
  rm -rf *forseti*
fi

# Download Forseti source code
echo "Forseti Startup - Cloning Forseti repo."
export http_proxy="http://x.x.x.x:80"
export https_proxy="http://x.x.x.x:80"
git clone --branch v2.23.0 --depth 1 https://github.com/GoogleCloudPlatform/forseti-security
unset http_proxy
unset https_proxy
cd forseti-security

# Forseti host dependencies
echo "Forseti Startup - Installing Forseti linux dependencies."
sudo apt-get install -y $(cat install/dependencies/apt_packages.txt | grep -v "#" | xargs)

# # Forseti dependencies
# echo "Forseti Startup - Installing Forseti python dependencies."
python3 -m pip install --upgrade setuptools wheel -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install --upgrade -r requirements.txt -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"

# Install sqlalchemy-migrate without version constraints first, so the specific version below will install:
python3 -m pip install sqlalchemy-migrate -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"

# Install forseti required packages - specific versions from setup.py
python3 -m pip install anytree==2.4.3 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install google-api-python-client==1.7.10 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install google-auth==1.6.3 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install google-auth-httplib2==0.0.3 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install Jinja2==2.10.1 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install jmespath==0.9.3 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install netaddr==0.7.19 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install pyyaml==4.2b4 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install python-graph-core==1.8.2 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install python-dateutil==2.7.5 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install ratelimiter==1.2.0.post0 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install retrying==1.3.3 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install requests[security]==2.21.0 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install sendgrid==5.6.0 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install simple-crypt==4.1.7 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install unicodecsv==0.14.1 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
# Setup related.
python3 -m pip install grpcio==1.22.0 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install grpcio-tools==1.22.0 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install protobuf==3.9.0 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
# Testing related.
python3 -m pip install parameterized==0.6.1 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install ruamel.yaml==0.15.37 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install pylint==1.9.4 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install pylint-quotes==0.2.1 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install PyMySQL==0.9.3 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install SQLAlchemy==1.2.18 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install sqlalchemy-migrate -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
python3 -m pip install sqlalchemy-migrate==0.11.0 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"

# Optional packages
# python3 -m pip install mailjet-rest==1.3.3 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"
# python3 -m pip install google-cloud-profiler==1.0.8 -i "https://artifactory.xxx.xxx/artifactory/api/pypi/pypi/simple"

# Setup Forseti logging
touch /var/log/forseti.log
chown ubuntu:root /var/log/forseti.log
cp $USER_HOME/forseti-security/configs/logging/fluentd/forseti.conf /etc/google-fluentd/config.d/forseti.conf
cp $USER_HOME/forseti-security/configs/logging/logrotate/forseti /etc/logrotate.d/forseti
chmod 644 /etc/logrotate.d/forseti
service google-fluentd restart
logrotate /etc/logrotate.conf

# Change the access level of configs/ rules/ and run_forseti.sh
chmod -R ug+rwx $USER_HOME/forseti-security/configs $USER_HOME/forseti-security/rules $USER_HOME/forseti-security/install/gcp/scripts/run_forseti.sh

# Install Forseti
echo "Forseti Startup - Installing Forseti python package."
python3 setup.py install

# Export variables required by initialize_forseti_services.sh.
export SQL_PORT=3306
export SQL_INSTANCE_CONN_STRING=forseti-projectid:australia-southeast1:forseti-db-id
export FORSETI_DB_NAME=forseti_security

# Export variables required by run_forseti.sh
export FORSETI_HOME=$USER_HOME/forseti-security
export FORSETI_SERVER_CONF=$USER_HOME/forseti-security/configs/forseti_conf_server.yaml
export POLICY_LIBRARY_HOME=$USER_HOME/policy-library
export POLICY_LIBRARY_SYNC_ENABLED=false
export POLICY_LIBRARY_SYNC_GIT_SYNC_TAG=
export POLICY_LIBRARY_REPOSITORY_URL=
export SCANNER_BUCKET=forseti-bucket

# Store the variables in /etc/profile.d/forseti_environment.sh
# so all the users will have access to them

FORSETI_ENV_FILE="$(cat << EOF
export FORSETI_HOME=$USER_HOME/forseti-security
export FORSETI_SERVER_CONF=$USER_HOME/forseti-security/configs/forseti_conf_server.yaml
export POLICY_LIBRARY_HOME=$USER_HOME/policy-library
export POLICY_LIBRARY_SYNC_ENABLED=false
export POLICY_LIBRARY_SYNC_GIT_SYNC_TAG=
export POLICY_LIBRARY_REPOSITORY_URL=
export SCANNER_BUCKET=forseti-bucket
EOF
)"
echo "$FORSETI_ENV_FILE" > /etc/profile.d/forseti_environment.sh

# Download server configuration from GCS
echo "Forseti Startup - Downloading Forseti configuration from GCS."
gsutil cp gs://forseti-bucket/configs/forseti_conf_server.yaml $USER_HOME/forseti-security/configs/forseti_conf_server.yaml
gsutil cp -r gs://forseti-bucket/rules $USER_HOME/forseti-security/

# Clear out old Config Validator constraints
sudo rm -rf $USER_HOME/policy-library
# Get Config Validator constraints
sudo mkdir -m 777 -p $USER_HOME/policy-library
if [ "false" == "true" ]; then
  # Policy Library Sync
  echo "Forseti Startup - Policy Library sync is enabled."

  # Install Docker
  if [ -z "$(which docker)" ]; then
    echo "Forseti Startup - Installing Docker for the Policy Library sync."
    sudo apt-get update
    sudo apt -y install apt-transport-https ca-certificates curl software-properties-common
    curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -
    sudo add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic stable"
    sudo apt update
    apt-cache policy docker-ce
    sudo apt install -y docker-ce
  fi

  # Setup local FS
  # Note: gsutil is using the -n flag so that once the SSH key is copied locally, it is not overwritten for any subsequent runs of terraform
  mkdir -p /etc/git-secret
  gsutil cp -n gs://forseti-bucket/${policy_library_sync_gcs_directory_name}/* /etc/git-secret/
else
  # DEPRECATED! Remove once users have migrated over to Git-Sync
  # Download the Newest Config Validator constraints from GCS
  echo "Forseti Startup - Copying Policy Library from GCS."

  # Attempt to download the config-validator policy and gracefully handle the absence
  # of policy files.  The config-validator is not required for the rest of Forseti
  # and should not halt installation.
  gsutil cp -r gs://forseti-bucket/policy-library $USER_HOME/policy-library/ || echo "No policy available, continuing with Forseti installation"
fi

# Start Forseti service depends on vars defined above.
echo "Forseti Startup - Starting services."
bash ./install/gcp/scripts/initialize_forseti_services.sh
systemctl start cloudsqlproxy
if [ "false" == "true" ]; then
  systemctl start policy-library-sync
  sleep 5
fi
systemctl start config-validator
sleep 5

echo "Forseti Startup - Attempting to update database schema, if necessary."
python3 $USER_HOME/forseti-security/install/gcp/upgrade_tools/db_migrator.py

# Start main Forseti service
echo "Forseti Startup - Starting Forseti service."
systemctl start forseti
echo "Forseti Startup - Success! The Forseti API server has been started."

# Create a Forseti env script
FORSETI_ENV="$(cat << EOF
#!/bin/bash

export PATH=$PATH:/usr/local/bin

# Forseti environment variables
export FORSETI_HOME=$USER_HOME/forseti-security
export FORSETI_SERVER_CONF=$USER_HOME/forseti-security/configs/forseti_conf_server.yaml
export POLICY_LIBRARY_HOME=$USER_HOME/policy-library
export POLICY_LIBRARY_SYNC_ENABLED=false
export POLICY_LIBRARY_SYNC_GIT_SYNC_TAG=
export POLICY_LIBRARY_REPOSITORY_URL=
export SCANNER_BUCKET=forseti-bucket
EOF
)"
echo "$FORSETI_ENV" > $USER_HOME/forseti_env.sh

USER=ubuntu
# Use flock to prevent rerun of the same cron job when the previous job is still running.
# If the lock file does not exist under the tmp directory, it will create the file and put a lock on top of the file.
# When the previous cron job is not finished and the new one is trying to run, it will attempt to acquire the lock
# to the lock file and fail because the file is already locked by the previous process.
# The -n flag in flock will fail the process right away when the process is not able to acquire the lock so we won't
# queue up the jobs.
# If the cron job failed the acquire lock on the process, it will log a warning message to syslog.

# commenting out cron for now
# (echo "0 2 * * * (/usr/bin/flock -n $USER_HOME/forseti-security/forseti_cron_runner.lock $USER_HOME/forseti-security/install/gcp/scripts/run_forseti.sh -b forseti-bucket || echo '[forseti-security] Warning: New Forseti cron job will not be started, because previous Forseti job is still running.') 2>&1 | logger") | crontab -u $USER -

echo "Forseti Startup - Added the run_forseti.sh to crontab under user $USER."
echo "Forseti Startup - Execution of startup script finished."

The only other errors I've noticed, is on startup:
11/1/19, 10:35 AM InternalError: (pymysql.err.InternalError) (1060, "Duplicate column name 'cai_resource_name'") [SQL: '\nALTER TABLE gcp_inventory ADD cai_resource_name VARCHAR(4096)'] (Background on this error at: http://sqlalche.me/e/2j85)
11/1/19, 10:35 AM InternalError: (pymysql.err.InternalError) (1060, "Duplicate column name 'cai_resource_type'") [SQL: '\nALTER TABLE gcp_inventory ADD cai_resource_type VARCHAR(512)'] (Background on this error at: http://sqlalche.me/e/2j85)
11/1/19, 10:35 AM InternalError: (pymysql.err.InternalError) (1060, "Duplicate column name 'violation_message'") [SQL: '\nALTER TABLE violations ADD violation_message TEXT'] (Background on this error at: http://sqlalche.me/e/2j85)
11/1/19, 10:35 AM InternalError: (pymysql.err.InternalError) (1060, "Duplicate column name 'resource_name'") [SQL: '\nALTER TABLE violations ADD resource_name VARCHAR(256)'] (Background on this error at: http://sqlalche.me/e/2j85)

But these errors are present on my test org system which works fine, so I've ignored them for now.

@pdutch Thanks for submitting this issue and providing those details.  In order to help me reproduce the error, could you please answer the following questions?

Is this a fresh install of Forseti 2.23 or is it an upgrade?
If this is an upgrade, from what version are you upgrading?
a. Also, was the previous version installed via the Python installer or Terraform?

It's was an upgrade from v2.22, but that version had the same issue. I've
since rebuilt the vm many times from fresh and gone straight to V2.23. Each
time it's been installed effectively from the startup script. I've cobbled
together my own terraform and startup script from what's available in the
module.
On Tue, 5 Nov 2019, 2:34 am Ken Evensen<EMAIL_ADDRESS>wrote:

@pdutch https://github.com/pdutch Thanks for submitting this issue and
providing those details. In order to help me reproduce the error, could you
please answer the following questions?

Is this a fresh install of Forseti 2.23 or is it an upgrade?
If this is an upgrade, from what version are you upgrading?
a. Also, was the previous version installed via the Python installer
or Terraform?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/forseti-security/forseti-security/issues/3398?email_source=notifications&email_token=AM6JGNNTBNLK2XGTAAYRZJLQSA6GXA5CNFSM4JINL5G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7VBHA#issuecomment-549408924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6JGNPVYOEAAGSRARN4LKDQSA6GXANCNFSM4JINL5GQ
.

FYI, while it would be interesting to understand why this is an issue, I believe the problem lies with some of the python dependencies. I've since provided the forseti server a proxy to get outbound internet access, which removed the need to use the artifactory mirror for python dependencies, and the issue is now resolved. Something to bear in mind however would be a way to deploy forseti without external dependencies. I've been looking into the GKE version, and hopefully the containers for that are fully self contained (other than policy files).


Molpro: (WIP) Added CCSD support to output parsing

Added CCSD support to output parsing. However, it looks like the ccsd keys (same as mp2 except with the ccsd label) need to be added to the supported keys. I believe in QCSchema?

[ ] Add support to QCSchema (?) for CCSD quantities

Yes, we have not yet added CCSD keys to the QCSchema. Should be a pretty simple add, you can open a PR modifying here if you wish.

While I was working on this today, I realized I may have mapped the Molpro and Molssi quantities incorrectly. Do you know if opposite_spin_correlation is the same as singlet pair energy or triplet pair energy (which is the notation used in Molpro. Doing a quick search I couldn't easily see how the naming conventions match up.

Yes, Molpro --> Psi4 (which in this case "wins" on precedent) needs a bit of math for same-spin/opposite-spin quantities.
            #}
            if ($line =~ /CCSD correlation energy/) {
               @ltemp = split( /\s+/, $line);
               $tempc = @ltemp[4];
            }
            if ($line =~ /Total correlation energy/) {
               @ltemp = split( /\s+/, $line);
               $tempd = @ltemp[4];
            }
            if ($line =~ /MP2 triplet pair energy/) {
               @ltemp = split( /\s+/, $line);
               $tempf = @ltemp[5];
            }
            #if ($line =~ / TEMP3            = /) {  # only printed with special instructions
            #   @ltemp = split( /\s+/, $line);
            #   $temph = @ltemp[3];
            #}
            if ($line =~ /CCSD triplet pair energy/) {
               @ltemp = split( /\s+/, $line);
               $tempg = @ltemp[5];
            }
         }

         $tempf *= 2/3;
         #$temph *= 2/3;
         $tempg *= 2/3;

Sorry I'm still a little confused. Are the final $tempf and $tempg quantities the conversion between triplet pair energy and the same spin energy?

something like that. if you can use a scaling with 2, 3 to get values like https://github.com/psi4/psi4/blob/master/tests/pytest/test_mp2.py#L13-L24 for https://github.com/psi4/psi4/blob/master/tests/pytest/test_mp2.py#L52-L54, you're in good shape.

I think I have it (1/3)*triplet + singlet = opposite and (2/3)*triplet = same. I'll update my pull request with the correct conversion.

This pull request introduces 2 alerts when merging 30035694c55a0b5ff828a1bcb4116040049a8a81 into ac47162013c78956580771ded14c0e055f6ab353 - view on LGTM.com
new alerts:

2 for Unused local variable

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 0be87d64b413380d4d428e9838647fff6bcbaa0d into ac47162013c78956580771ded14c0e055f6ab353 - view on LGTM.com
new alerts:

1 for Unused local variable

Comment posted by LGTM.com

This looks good! We need to crank out a new QCElemental release soon so that this can go through.

Okay sounds good! I'll keep an eye out for the QCElemental release.

QCElemental v0.4 is now out. Do we need to do anything here to get this in?

It should be good to pull unless you'd like me to update it with the current master branch.

Please do, it's been long enough that we want to run this through CI once more.

Okay everything looks good. Also just wanted to give a heads up, one of the testjobs I have added for Molpro does not pass, because it is unable to find the CCSD energy from the xml file when calling a gradient. I have an idea of how to fix this (maybe text parsing), but I was going to wait to fix that at a later date.


[docs] Demo how to use a specific slide direction for Snackbar

[X] I have followed (at least) the PR section of the contributing guide.

Fix #21053
In this comment, Olivier suggested putting the plain example under the "Change Transition" heading. However, I placed it under the "Control Slide direction" heading because I thought it suited better here. Please confirm.

@goncalovf It's a great first pull request on Material-UI. Thank you for working on it!

@eps1lon Thanks, happy to help!


refactor(rust): try to trigger a ci deadlock

This is a PR to test CI, please do not merge!

This issue was fixed with #7329


ChEMBL tractability data file for platform-input-support

This is a placeholder ticket (more detail to be added) to work out how to deal with the tractability file in future OT releases. ChEMBL are currently uploading both the evidence and tractability file into their OT bucket. At the moment, the platform-input-support script expects the file in the otar001-core/Tractability bucket. For platform-input-support to pick up the tractability file, naming conventions have to be adhered to.

Added to 19.11 release milestone - @cmalangone and I to resolve in that release

After discussing this with @cmalangone and @andrewhercules we have decided to ask ChEMBL (Tim for now) to upload the tractability file directly to the otar001-core/Tractability bucket.

I have confirmed with ChEMBL that they can upload file  to the otar001-core/Tractability bucket and have also shared the proposed file format of name_of_file_dd-mm-yyyy.tsv.


First pass at Evidence objects.

Oh, and can we also add some initial tests here as well. Fine to do in a followup PR though

If it's OK with you, I'll defer the tests for a later PR for now.  Not a lot to test anyway given that these are mostly data storage objects as of now.

Yeah, tests in a folloup PR is fine.
LGTM


Improvements for flake usage

This PR includes some things:

fix usage of extraSpecialArgs (we did not set the values of this argument as special arg but as _module.args which disallows usage of these values in imports in config modules)
remove parameters/simplify usage of lib.nixOnDroidConfiguration (inspired by https://github.com/nix-community/home-manager/pull/3037)
add option for text on shell startup to allow changing or removing it
add support for default config in flake, this is an easy convenience helper for people only using one device
some improvements for fakedroid environment testing

If you want me to split some commits into separate PRs, I can do that, but this may result in some merge conflicts that I tried to avoid with this big PR :)
Sorry for the high load of PRs lately, got quite some motivation and time the last weeks :) If I can make the review process easier for you, I am happy to help.

Sorry for the high load of PRs lately, got quite some motivation and time the last weeks :)

Ahem, nothing to be sorry about. Just hope you've got some patience with me to match, as I'm the one stifling it.

If I can make the review process easier for you, I am happy to help.

If you've got a spare device to run bootstraps + on-device-tests on, doing so after PR approvals and before merging would save me time.
Regarding the PR itself, all changes look OK to me. I'm not a big fan of that part where you merge config into modules, but that's a matter of taste, I guess, and it mirrors nixosConfigurations.

Ahem, nothing to be sorry about. Just hope you've got some patience with me to match, as I'm the one stifling it.

All fine, take your time :)

If you've got a spare device to run bootstraps + on-device-tests on, doing so after PR approvals and before merging would save me time.

Could do so, but these installs are really taking ages on my device. Not sure whats the reason for this. But will add a comment the PRs what I tested on device, so you don't need to do it :)

Force push was only rebase on master

Tested on device. Works fine. Will autosquash and merge.
That are really huge build times.. Is it just my device? :D

bootstrap channel: 15 min
run on-device-tests: 50 min
bootstrap flakes: 50 min

Huge build times indeed. What's the device? Do you use adopted storage?

It's a oneplus 5. What do you mean with adopted storage? There is no SD card or similar if you mean that.


[Bug]: Selecting a style with prompt longer than 75 characters results in RuntimeError: The expanded size of the tensor (77) must match the existing size (154) at non-singleton dimension 0. Target sizes: [77, 768]. Tensor sizes: [154, 768]

Selecting a Style that has either a positive or negative prompt longer than 75 characters results in the following error:
RuntimeError: The expanded size of the tensor (77) must match the existing size (154) at non-singleton dimension 0. Target sizes: [77, 768]. Tensor sizes: [154, 768]

As a workaround, you have to click the Apply select styles to the prompt button
This only happens if you load a Config Preset first. If you don't load a Config Preset, the Style will work as expected.

I'm unable to reproduce this issue on my end on Automatic1111 commit 226d840e84c5f306350b0681945989b86760e616 (Feb 1).
The Config Presets extension doesn't touch anything related to the styles widget, and I don't see how one could cause the other to error. Your issue is most likely a conflict with something else, or a bug within A1111.

I'll take a closer look.
Closing as NotRepro.


[BUG]

I imported a small english audio file for the purpose of translating into spanish. My choice of translation engine was google. I keep receiving this error a few seconds into the process: ERROR   - byte indices must be integers or slices, not str

sorry for the late reply, can you add more details. maybe showing me the log of the program

i'll close this for now, you can open it again and tell me the details when you feel like it


Create custom ArtifactRepository type

Expected Behavior
repositories {
  add(MyCustomArtifactRepository())
}

Current Behavior (optional)
No response
Context
We have an internal http service acting as a repository. Unfortunately, it does not following the maven standard regarding the file hierarchy, but we still want to fetch dependencies/jar/files from it using http.
Looking into the code, I need to implement a custom ResourceConnectorFactory, but this api is internal. Also there is no public api to register the custom connector, all possibilities are hardcoded in BaseRepositoryFactory.
It is also protected by client cert auth, see #27446

Thank you for your interest in Gradle!
This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

This is something we'd like to support, but we don't have any plans for adding this or creating a public API for this to be possible.


feat(Topology/Algebra/Order): continuous injective function on interval is strictly monotone

Suppose f : [a, b] → δ or f : (a, b) → δ is continuous and injective. Then f is strictly monotone.
Co-authored-by: Johan Commelin<EMAIL_ADDRESS>Co-authored-by: Yaël Dillies<EMAIL_ADDRESS>

Primary takeaway: do things for types first then sets.

@j-loreaux Thank you very much for your advice! Now the code has been refactored.

Thanks :tada:
bors merge

bors r-
bors d+

bors r+

Let's first wait for CI to finish.
bors r-

bors r+


fix scala 2.10 compilation

Pull Request Checklist

[X] Have you read How to write the perfect pull request?
[X] Have you read through the contributor guidelines?
[X] Have you added tests for any changed functionality?

Fixes
Although scala 2.10 is still a supported target, Travis was not configured to compile with scala 2.10. This PR fixes that and also an compilation issue in tests...
Purpose
Adds scala 2.10 compilation to travis.yml

Fixed at https://github.com/ReactiveMongo/ReactiveMongo/pull/773/files#diff-7ead187e5d5b55428cf9ff3b4a899884R99

Fixed at ReactiveMongo/ReactiveMongo/pull/773/files#diff-7ead187e5d5b55428cf9ff3b4a899884R99

Thx


AMP-Carousel with AMP-List

Adding an advanced component and endpoint so potential users can learn how a dynamic carousel might look and work

I signed it!


Please add to README how to run tests

pytest doesn't find any tests.

python -m unittest

will run the test with unittest.
I have not personally used pytest, but I believe
pytest tests

should also work.
Note, that to you will also need to build the C++/Cython parts of dimod. Usually done with
python setup.py build_ext --inplace

or
pip install .

Test fails for some reason:
 /usr/local/bin/python3.9 -m unittest  -v
dimod (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: dimod (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: dimod
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/unittest/loader.py", line 470, in _find_test_path
    package = self._get_module_from_name(name)
  File "/usr/local/lib/python3.9/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/disk-samsung/freebsd-ports/science/py-dimod/work-py39/dimod-0.11.4/dimod/__init__.py", line 18, in <module>
    from dimod.constrained import *
  File "/disk-samsung/freebsd-ports/science/py-dimod/work-py39/dimod-0.11.4/dimod/constrained.py", line 38, in <module>
    from dimod.binary.binary_quadratic_model import BinaryQuadraticModel, Binary, Spin, as_bqm
  File "/disk-samsung/freebsd-ports/science/py-dimod/work-py39/dimod-0.11.4/dimod/binary/__init__.py", line 15, in <module>
    from dimod.binary.binary_quadratic_model import *
  File "/disk-samsung/freebsd-ports/science/py-dimod/work-py39/dimod-0.11.4/dimod/binary/binary_quadratic_model.py", line 41, in <module>
    from dimod.binary.cybqm import cyBQM_float32, cyBQM_float64
  File "/disk-samsung/freebsd-ports/science/py-dimod/work-py39/dimod-0.11.4/dimod/binary/cybqm/__init__.py", line 15, in <module>
    from dimod.binary.cybqm.cybqm_float32 import cyBQM_float32
ModuleNotFoundError: No module named 'dimod.binary.cybqm.cybqm_float32'

----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)

It is run from repo root.
When it is run from dimod/ - no tests are found.

The tests are located under tests/ which is why running under dimod/ does not find them. When running from repo root, you need to build the package in place. With python setup.py build_ext --inplace. You could also run the tests from within tests/.


FediAct breaks common credit union banking software

For some reason this extension breaks all usage of the Alkami software, which is used by tons of banks and credit unions. For some reason after login it redirects people to api/v1/instance despite Alkami not existing. I don't know why it redirects to that endpoint either, as that just seems weird.

From what I can see more than just Alkami software is affected. The login on login.ionos.de, also breaks.
My assumption is that the extra request on every load of any page breaks the login flow on the server side.
With some tinkering and "remembering" if a website is a mastodon instance or not this could be avoided and we could save unneeded requests to actual instances too.
https://github.com/Lartsch/FediAct/blob/75cd8bb25a50fa75195e46a9409c9bd7cb2e96e7/src/inject.js#L1501-L1507
As a temporary workaround, add the EXACT domain (so for my example "login.ionos.de") to the blacklist.


internal/scaffold/helm/entrypoint.go: resolve merge issue

Description of the change:
Resolves a merge issue that occurred during #34
Motivation for the change:
Fix openshift/release#7420

/lgtm

/test images
/test e2e-aws-ansible


Fix issue #142

Coverage remained the same at 90.461% when pulling a3cb3a7a3003264658e54c3de9e3cefd8e6b53ec on issue_142 into b663b02c2b40697760c4bd5ad2b21e9f5609f46e on master.


stdout using watch does not complete

UnoCSS version
0.57.3
Describe the bug
Issue 1:
Due to the nature of stdout being a multiple line stream rather than 1 burst of data to stdout.  The application receiving the data has to stream in the lines.  Unfortunately there isn't a way to tell the application that the EOF has been reached.  Right now I'm hardcoding an <<<EOF for my app to look out for.  It would be nice for apps that need it, to have a EOF flag to set some sort of token/delimiter?
Edit: I have tried to hijack the unocss stdout output using awk.  Unfortunately when using the watcher param this doesn't work.  😦
Issue 2:
With the last update to the CLI that I did.  I inadvertently introduced 2 issues.
The following lines need to be hidden when stdout is being used.  Otherwise they become part of the payload.
https://github.com/unocss/unocss/blob/4a307b0979f8f66078800d81aabdb5e3cc42d583/packages/cli/src/index.ts#L56-L68 and https://github.com/unocss/unocss/blob/4a307b0979f8f66078800d81aabdb5e3cc42d583/packages/cli/src/index.ts#L99-L105
Issue 3.
When using watch and doing a save.  I see in the stdout.
change src/app/page.tsx
I am unable to find where this occurs.  If possible, this needs to be hidden from the stdout as well.  Please let me know where this is.
Finally, I am able to submit a PR with the following changes (except for issue 3).
Thanks!
Reproduction
For issue 1.
Install unocss globally so that it can run in the cli.
pipe out unocss to a custom cli application.
I'm using a simple Rust app.
The following code does not generate any output.
use std::io::{ self, Write, Read };

fn main() -> io::Result<()> {
  let mut input = String::new();
  io::stdin().read_to_string(&mut input)?;
  io::stdout().write_all(input.as_bytes())?;
  Ok(())
}

This does, but it's taking in each line and waiting for the next...
use std::io::{ self, BufRead };
use std::sync::mpsc;
use std::thread;

fn main() {
  let (tx, rx) = mpsc::channel::<String>();
  thread::spawn(move || {
    let stdin = io::stdin();
    let mut lines = stdin.lock().lines();
    while let Some(Ok(line)) = lines.next() {
      tx.send(line).unwrap();
    }
  });

  for received in rx {
    println!("Received: {}", received);
  }
}

Note: for os apps like tee.  It works fine.  The Rust app only works with that particular code.  Any other way of processing the stdin either throws an error with Node or it silently fails.
System Info
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I've now managed to circumvent the issues I have been having.  I'm no longer needing watch in my workflow and only relying on stdout.
It's still worth resolving this.  As I'm stripping out the issues myself.


update the services to allow for a field to be returned

@lukecampbell @FBRTMaka adds field to the request so we dont return all the data to the ui

@lukecampbell dont merge yet i wanna add time averaging to this one etc

You’ve also got conflicts!
On Feb 9, 2015, at 1:32 PM, Andrew Bird <notifications<EMAIL_ADDRESS>wrote:
@lukecampbellhttps://github.com/lukecampbell dont merge yet i wanna add time averaging to this one etc
—
Reply to this email directly or view it on GitHubhttps://github.com/asascience-open/ooi-ui-services/pull/188#issuecomment-73562555.

nm, you fixed it!
On Feb 9, 2015, at 1:32 PM, Andrew Bird <notifications<EMAIL_ADDRESS>wrote:
@lukecampbellhttps://github.com/lukecampbell dont merge yet i wanna add time averaging to this one etc
—
Reply to this email directly or view it on GitHubhttps://github.com/asascience-open/ooi-ui-services/pull/188#issuecomment-73562555.

@FBRTMaka get yo facts straight son!

@lukecampbell @FBRTMaka ready for merge

:+1:


Unexpected behavior in "disableAfterRate: false"

Unexpected behavior in "disableAfterRate: false" after re-rating by clicking with a lower rating since it applies the color of the lower rating but does not remove the color of the higher rating.

any fix for this?

https://github.com/nashio/star-rating-svg/issues/53 - This is the solution


Fix to axil client

This PR fixes the axi lite client for #1013. Writes are able to proceed at 100% throughput, but reads now take an additional cycle. Reads are much less common in our current AXI systems, but future enhancements could pipeline this as well by adding registers for the araddr and additional state

Not sure if I can follow. Are you meant to write 's_axil_awvalid_i & s_axil_wvalid_i'?
https://github.com/black-parrot/black-parrot/blob/61da1f66de2f517bf88e7652afa890c8c36764b1/bp_me/src/v/network/bp_me_axil_client.sv#L135

Not sure if I can follow. Are you meant to write 's_axil_awvalid_i & s_axil_wvalid_i'?
https://github.com/black-parrot/black-parrot/blob/61da1f66de2f517bf88e7652afa890c8c36764b1/bp_me/src/v/network/bp_me_axil_client.sv#L135

In ready, we send a write if awvalid and wvalid are both high. If only awvalid is high, then we latch it and move to send_write. In send_write, we wait until wvalid is high. This allows us to send writes with 100% throughput in the case of address being sent at the same time as data, as well as max (50%) throughput if address is sent first, then data.

I see. The reason why I looked at these changes was that, after applying them to zynq-parrot I wasn't able to run simulation on Verilator(AXI timeout), but after looking at the waveform it seems to me it is actually Verilator itself that generated the issue. VCS works well.

Yep, Verilator has some issues I'm working on in https://github.com/black-parrot-hdk/zynq-parrot/pull/21. Feel free to pull that in, or just use VCS in the meantime


"automake failed with exit status:1" ERROR

Hi, when I run autogen.sh, I get this error while doing 'autoreconf -isf' .
main::scan_file() called too early to check prototype at /usr/local/bin/aclocal line 618.
Useless use of /d modifier in transliteration operator at /usr/local/share/automake-1.11/Automake/Wrap.pm line 58.
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/${ <-- HERE ([^ \t=:+{}]+)}/ at /usr/local/bin/automake line 4113.
Makefile.am:9: Libtool library used but LIBTOOL' is undefined Makefile.am:9:   The usual way to define LIBTOOL' is to add AC_PROG_LIBTOOL' Makefile.am:9:   to configure.ac' and run aclocal' and autoconf' again.
Makefile.am:9:   If AC_PROG_LIBTOOL' is in configure.ac', make sure
Makefile.am:9:   its definition is in aclocal's search path.
autoreconf: automake failed with exit status: 1
Could you let me know why this happens? Thanks in advance!

the same error, waiting for response

@gmyofustc just 'libtoolize' command solved the problem. hope it works for you too !

@byuns9334  Yeah, I works, thanks


Update README to include automated steps

Include what the framework has automated (i.e. installed REX-Ray, mesos-module-dvdi, etc).

This PR https://github.com/codedellemc/scaleio-framework/pull/97 addresses this issue.


Validation if field value is empty Nillclass

Hi
I'm trying to create a datatable but I'd like to add validation like this:
<%= company.company_category.name unless company.company_category.nil? %>
Is this possible in the data section to avoid getting these kind of errors : NoMethodError (undefined method `postalcode' for nil:NilClass)
What I'd like to do is this :
def data
records.map do |company|
[
company.name,
company.address,
company.postindex.postalcode unless company.company_category.nil?,
company.city,
]
end
end
Thanks

@reyntjensw if you do that, that whole line will be missing from the json structure returned by the gem for some records (at least the ones that match the conditional), and thus will cause the jQuery.dataTables plugin to throw an error due to inconsistencies.
What you need to do, is to tell, don't ask your object to return a value: either the value expected, or a placeholder in case it does not match the conditional :smile:

Hi Antillas, thanks that worked out great!

Glad to have helped.


WIP debug HTTP Client header logging

Before contributing, please read our contributing guidelines and code of conduct.
Overview
Describe the changes present in the pull request
Submitter Checklist:

[ ] Include a link to the related GitHub issue, if applicable
[ ] Include a security review link, if applicable

Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist

[ ] Perform code review
[ ] Add performance label
[ ] Perform appropriate level of performance testing
[ ] Confirm all checks passed
[ ] Add version label prior to acceptance

Closing this PR, as it's not quite what we need to really solve this problem. See #1657.


Running empty test files

Sometimes, it's useful to create dummy .bats files that do not contain any test cases. However, the bats-exec-suite fails.
The reason: let count+="$(bats-exec-test -c "$filename")" evaluates to let count+=0, which fails under set -e.

I have hit this issue too, causing a whole bunch of not-immediately-obvious issue with various testing pipelines. It would be great to get this fixed


Build pipeline

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: hhughes0 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


feat: Add git migrator

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: abhinav-harness:x: atefehmohseni:x: karansaraswat19You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP] Test [SPARK-36035]

Test https://github.com/apache/spark/pull/33250 with pandas 1.0.1.

Test build #140819 has started for PR 33272 at commit 1d0b30f.

Test build #140819 has finished for PR 33272 at commit 1d0b30f.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45330/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140819/

Test build #140823 has started for PR 33272 at commit b095402.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45330/

Test build #140823 has finished for PR 33272 at commit b095402.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45334/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45330/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140823/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45334/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45334/

The unrelated module failed. Retriggered tests.


Can't detect when app open from a notification banner (Android, local notification)

"react-native": "^0.50.4",
"react-native-fcm": "^11.2.0",
Android emulator.
Hi! I created notification http://ipic.su/img/img7/fs/kiss_19kb.1517324749.jpg,
then at file index.android.js I added
http://ipic.su/img/img7/fs/kiss_37kb.1517325014.jpg,
And when notification appeared (app is closed) and I click on it, my app open but getInitialNotification method returns me http://ipic.su/img/img7/fs/kiss_5kb.1517325629.jpg
From manifest:
    <meta-data android:name="com.google.firebase.messaging.default_notification_icon" android:resource="@mipmap/ic_notif"/>
          <receiver android:name="com.evollu.react.fcm.FIRLocalMessagingPublisher"/>
          <receiver android:enabled="true" android:exported="true"  android:name="com.evollu.react.fcm.FIRSystemBootEventReceiver">
              <intent-filter>
                  <action android:name="android.intent.action.BOOT_COMPLETED"/>
                  <action android:name="android.intent.action.QUICKBOOT_POWERON"/>
                  <action android:name="com.htc.intent.action.QUICKBOOT_POWERON"/>
                  <category android:name="android.intent.category.DEFAULT" />
              </intent-filter>
          </receiver>

        <service android:name="com.evollu.react.fcm.MessagingService" android:enabled="true" android:exported="true">
             <intent-filter>
                    <action android:name="com.google.firebase.MESSAGING_EVENT"/>
             </intent-filter>
        </service>

       <service android:name="com.evollu.react.fcm.InstanceIdService" android:exported="false">
            <intent-filter>
                <action android:name="com.google.firebase.INSTANCE_ID_EVENT"/>
            </intent-filter>
       </service>

.....

I need to detect when app opened from notification.
Please help me find what I do wrong?

Thanks, it's helpful. FCM.on detect when notification show up. How detect when the user open app from notification? Maybe my intent-filter is wrong, or why getInitialNotification return action: null?
Or maybe, I don't understand, how correct must work click_action.

@gerdana2405 there is opened_from_tray flag

opened_from_tray return "1" anyway.

seems you are trying to figure out if user launched the app by clicking notification.
In that case opened_from_tray doesn't work, you can check if the initialNotification has any custom data you pass, e.g you can send a notification_type in data object

Does custom data work with local notification? Can you give me an example?

https://github.com/evollu/react-native-fcm/blob/master/Examples/simple-fcm-client/app/App.js#L61

there no example where custom data pass with local notification

localNotification itself is custom_data, you can put any item in it

yes, but getInitialNotification don't return any data I pass

what does your getInitialNotification return?
what is your local notificaiton payload?

FCM.scheduleLocalNotification({
fire_date: fire_date,
id: id,
body: body,
repeat_interval: "week",
click_action: 'fcm.ACTION.HELLO',
show_in_foreground: true,
sound: 'default',
priority: 'high',
title: "MyApp",
auto_cancel: true,
large_icon: "ic_launcher",
icon: "ic_launcher",
lights: true,
wake_screen: true,
ongoing: true,
data: {
notification_type: "REMINDER"
}
})
getInitialNotification:
{
fcm : { action : null },
pened_from_tray : 1,
}

try move notification_type outside of data. I remember the serializer can't serialize object
{
... your existing properies,
notification_type: "REMINDER"
}

It's object from scheduled list http://ipic.su/img/img7/fs/kiss_28kb.1519728253.jpg, and this from getInitialNotification, when I open an app from notification - http://ipic.su/img/img7/fs/kiss_7kb.1519728292.jpg
I used data: JSON.stringify({notification_type: "REMINDER"}).
Maybe I missed something else

just updated example. even object works
https://github.com/evollu/react-native-fcm/blob/master/Examples/simple-fcm-client/app/App.js#L91
you can trigger an scheduled notification. killed app. tap the notif. the initNotif field should contain all the data.

I found the problem. I have SplashActivity and MainActivity, and my SplashActivity is MAIN and LAUNCHER. So my data never take up to MainActivity. Do you have an idea how to fix that?

ah..
I use react-native-splash-screen myself.

I pass data to my  MainActivity :intent.putExtra("DATA", this.getIntent().getExtras());
startActivity(intent);

Is it possible to get list of fired notifications? Or I need to save them by myself?

it seems to be possible for Android
https://developer.android.com/reference/android/service/notification/NotificationListenerService.html#getActiveNotifications()
but not in this lib yet


Flutter web + firebase hosting is too slow but not in local

Steps to reproduce

visit my web application link
wait for fully rendering

Code sample
Code sample
[Paste your code here]

What target platforms are you seeing this bug on?
Web
OS/Browser name and version | Device information
Window | chrome  126.0.6478.115
Does the problem occur on emulator/simulator as well as on physical devices?
No
Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.19045.4529], locale ko-KR)
    • Flutter version 3.22.2 on channel stable at C:\Users\chuis'family\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (3 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\chuis'family\AppData\Local\Android\sdk
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop Windows apps
    X Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.90.2)
    • VS Code at C:\Users\chuis'family\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.90.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.4529]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 126.0.6478.115
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 126.0.2592.68

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

I'm getting this error on dev console of browser,
Exception while loading service worker: Error: prepareServiceWorker took more than 4000ms to resolve. Moving on.
Maybe the error was the cause for this issue?

Yeah kinda takes 3-4 seconds to load. But i always thought that this is the average loading time specially in Web. have you tried:
flutter build web --web-renderer canvaskit --release
? maybe this it will help.

Thanks I did the command what you mentioned, but It seems nothing improved.
then Is it normal that throwing
Exception while loading service worker: Error: prepareServiceWorker took more than 4000ms to resolve. Moving on.
this error?

do you use wasm?

Currently not, does it make better? if i use it?

I updated setTimeout second argument to 1000 in flutter_bootstrap.js  and deployed
then it is much faster than before,
But it seems not normal solution,
let r,t=new Promise((i,s)=>{r=setTimeout(()=>{s(new Error(${n} took more than ${1000}ms to resolve. Moving on.,{cause:b}))},1000)});
anybody help?

I'm having the same issue.
This also causes files to not load and breaks most functionality of the app

It appears to be related to the new 3.22 way of initializing the app
https://docs.flutter.dev/platform-integration/web/initialization
Following the upgrade instructions at the end of the page does not help.

@eso0117 Does the issue occur when running in release mode on your local machine?
Also, since the issue only occurs in a deployed site, it's not easy for us to look into what could cause it. For the issue to be workable, it needs to be reproducible with a completed and minimal reproducible code sample that doesn’t include 3rd party plugins or complex production code. Please provide such a sample.

@huycozy  apologies if it's inappropriate to intrude on this issue.
I've tested locally in release mode and did not see the issue.
Here's a public repo with the issue. https://github.com/LarryBauman/test_app
This was a newly created flutter app, that I simply ran flutter build web and then deployed to firebase.
Here's by flutter doctor -v output
    • Flutter version 3.22.2 on channel stable at c:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (3 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\Larry\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop Windows apps (Visual Studio Build Tools 2019 16.11.29)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
    • Visual Studio Build Tools 2019 version 16.11.33927.289
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 2023.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)

[✓] VS Code (version 1.90.2)
    • VS Code at C:\Users\Larry\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.90.0

[✓] VS Code (version 1.91.0-insider)
    • VS Code at C:\Users\Larry\AppData\Local\Programs\Microsoft VS Code Insiders
    • Flutter extension version 3.91.20240529

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22631.3737]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 126.0.6478.115
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 126.0.2592.68

[✓] Network resources
    • All expected network resources are available.

• No issues found!```

Thank you both for the update. I also tried to deploy a new Flutter project to my Firebase hosting but couldn't see the issue:

Did you build web with any optimization options (--dart2js-optimization)?  Can you share the command you used to build web?

@huycozy  I only ran flutter build web no optimizations

@huycozy
@LarryBauman
I've fixed my issue,
it was firebase-tools version issue for me,
I did run following command on my terminal
npm install -g firebase-tools
and re-deploy then it is working well

Glad you found it. Closing the issue as solved.


Error in class sit/set

In your file timesheet.css.sass and timesheet-white.css.sass, an error at line 20 and 32 : sit and set

Thanks!


Hide empty menu dropdown

Describe the bug
Between bug and enhancement. This is not something broken, but it's not the correct behavior.
When I open my dataset view (cross mode) with no annotation, I can click on annotation menu and view a piece of empty dropdown.
To Reproduce
Steps to reproduce the behavior:

Go to a dataset without annotation e.g "dataset-with-dates"
Click on 'Annotation into filter menu
See error

Expected behavior
I would like to avoid this unuseful action.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS [e.g. iOS]:
Browser [e.g. chrome, safari]:
Argilla Version [e.g. 1.0.0]:
ElasticSearch Version [e.g. 7.10.2]:
Docker Image (optional) [e.g. argilla:v1.0.0]:

Additional context
If there is no annotation in my dataset, I would not see Annotation filter in the filter menu.
If there is no prediction (when I'm creating a dataset to start annotate some data) I would say the same: No prediction

What is the behavior of the other filter group in same conditions? E.g. datasets with no predictions or no metadata.
I think the expected behavior should be the same for all of them

At least with predictions this doesn't happen and the prediction drop-down option is not shown so that one works as expected, that's the thing.
I agree that all should have the same behaviour, so this enhancement should make sure all filter options behave the same.

👍


Update README documentation

Top level README should include references to:

new config option allowed_domain
Route53 CNAME being optional
link to dashboard config howto
links to where head and paramedic are located eg. http://<host>/__es/_plugin/paramedic/

Fixed by 46214db895c9afa0779ab55a8e53289eb0de47aa


expose API to wait for a load event

Right now, the Navigate API implicitly waits for the page to load after issuing the page.Navigate command:
_, _, _, err := page.Navigate(urlstr).Do(ctx)
if err != nil {
        return err
}
return waitLoaded(ctx)

However, we don't expose the functionality of waitLoaded in any way. It can be useful for many other scenarios which the user knows will trigger a page navigation, such as:

clicking on a button
running some javascript
calling page.Navigate directly with custom parameters, such as https://github.com/chromedp/chromedp/issues/624
expecting a page to trigger a redirect/navigation after some time

The simplest option would be to expose waitLoaded as-is. It's simple to understand and use - the moment it's called, it sets up a target listener and blocks until a load event is received. However, it's inherently racy; if the load event already passed by the time we set up the listener, we will probably block forever.
A better way would be to expose a func(Action) Action which wraps an action, doing the following in order when the returned action is executed:

set up a listener
run the underlying action
wait until the load event is received

We could call this chromedp.WaitLoad, and it could be used like chromedp.WaitLoad(chromedp.Click(xxx)), or chromedp.WaitLoad(page.Navigate(...).WithOption(...)).

Hi @mvdan
I just found odd that the page object does expose such methods as WithReferrer or withReferrerPolicy but there's basically no way, simple or hard, to use them.
To solve my particular problem, and while I can hear the argument for keeping things simple, I'd rather have an NavigateWithOptions(url, options) thing as a compliment to Navigate(urlstr) (where the later just call the former internally with no options) than having to code something by copying existing code and inserting a couple of words in there.
I'm afraid I'm not qualified to comment on the merits of the other arguments for exporting WaitLoaded so hopefully others will chime in. Obviously, I'm happy with that solution too as it solves my use case.
Cheers

I just found odd that the page object does expose such methods as WithReferrer or withReferrerPolicy but there's basically no way, simple or hard, to use them.

I don't understand what you mean. You yourself proved it is possible to use them in your previous issue. With the proposed API above, you could end up with:
chromedp.Run(ctx,chromedp.WaitLoad(ActionFunc(func(ctx context.Context) error {
    _, _, _, err := page.Navigate(urlstr).WithReferrer(referrer).Do(ctx)
    return err
})))

You can say this is harder to do than just writing one line, but the chromedp API should be a tradeoff between what's most commonly needed versus what isn't. Having to write three extra lines for the cases where one needs custom navigation options seems fine to me.

Hi

I don't understand what you mean. You yourself proved it is possible to use them in your previous issue. With the proposed API above, you could end up with:

What I meant is that those methods are not exposed by the real "public" API and yes, to use them you have to copy a piece of chromedp in your own code, modify it slightly and use that.
It would make sense to me chromedp would expose publicly a way to set options for a method when it exposes that method publicly, does support options for that method and that APi is the most common way of accessing the service.
I understand the willingness to keep things simple hence the proposal for 2 separate methods, one with options, one without.
As long as it becomes doable, I'm fine, I'll just write a helper function to replace the call to navigate() to provide options.
Cheers


IF WE RUN  .JS LINK OF A SITE  AS REQUEST  IN OB2

IF WE RUN  .JS LINK OF A SITE  AS REQUEST  IN OB  IT MUST AUTOMATICALLY EXECUTES AND  SHOW US A RESULT LIKE IN BUILT BROWSER AND PUT THIS OPTION IN OB2.


Add support for AMQP

This is to support Rabbitmq exchange and queues in addition to SQS and Kafka from Netflix conductor.
fixes #1538
The code is inspired by this PR , which was not merged earlier.
https://github.com/Netflix/conductor/pull/1063.
The following needs to be added to server.properties to use this:
I have updated the version of RabbitMq client to 5.8
amqp_queue for queue
amqp_exchange for exchange
You can append parameters to the URI to set the following properties:
"exchangeType" : type of exchange topic, fanout, direct,...
"routingKey" : the routing key
"deliveryMode" : the delivery mode of message to publish
"durable" : is queue durable ? True by default
"exclusive" : is queue exclusive? False by default
"autoDelete" : is auto delete enabled ? False by default
"maxPriority" : Enable the priority feature on queue and set the max priority

Pull Request Test Coverage Report for Build 3834

9 of 389 (2.31%)  changed or added relevant lines in 7 files are covered.
16 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.7%) to 68.287%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contribs/src/main/java/com/netflix/conductor/contribs/AMQPModule.java
0
1
0.0%

contribs/src/main/java/com/netflix/conductor/contribs/queue/amqp/AMQPEventQueueProvider.java
0
11
0.0%

contribs/src/main/java/com/netflix/conductor/contribs/queue/amqp/AMQPConstants.java
0
13
0.0%

contribs/src/main/java/com/netflix/conductor/contribs/queue/amqp/AMQPConfigurations.java
0
29
0.0%

contribs/src/main/java/com/netflix/conductor/contribs/queue/amqp/AMQPSettings.java
0
80
0.0%

contribs/src/main/java/com/netflix/conductor/contribs/queue/amqp/AMQPObservableQueue.java
0
246
0.0%

Files with Coverage Reduction
New Missed Lines
%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java
8
69.86%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java
8
55.79%

Totals

Change from base Build 3833:
-1.7%

Covered Lines:
11492

Relevant Lines:
16829

💛  - Coveralls

@ritu-p Have you had a chance to take a look at the comment here about basicConsume? https://github.com/Netflix/conductor/pull/1063#issuecomment-477244947

@ritu-p Have you had a chance to take a look at the comment here about basicConsume? #1063 (comment)

@jkaipa ,
This seems like a good suggestion although i have not tested itf ro performnce and heavy load.I will make this change and update the PR

I @jkaipa I have made the changes as per your comments

@kishorebanala thanks for taking out time to review.
The comments have been addressed please have a look

@ritu-p Looks good to me. Please address the above comment on setUnackTimeout, we should be good to go. Thanks for your contribution 👍
@jkaipa Do you have anything else to add?

@kishorebanala and @jkaipa  I have implemented all the review comments
Kindly take a look

Thanks @kishorebanala

Hi @ritu-p
I have been using this ampq feature and i found an issue declaring an amqp queue in an event handler.
As part of my workflow definition, I created an event-handler to complete a WAIT task and set the event queue to be "amqp:some_queue_name". After starting a workflow i noticed that after a message was sent to this queue, the message was consumed but the event-handler action was not executed.
After debugging, i found out that after the message is received, conductor is not able to find the event-handler because internally it is stored as "amqp_queue:some_queue_name".Since the queue type strings are not the same no handler is found and no action is executed. (BTW if i use amqp_exchange it works).
I took a look at the code changes in the PR and i saw that the StringMapkey "amqp_queue"  was changed to "amqp".
Is there any workaround for this issue? is it possible to rename the StringMapKey back to "amqp_queue".
Thanks

@heinrichcohn
You are right .It is a miss in this code
	@ProvidesIntoMap 	@StringMapKey("amqp") 	@Singleton 	@Named(EVENT_QUEUE_PROVIDERS_QUALIFIER) 	public EventQueueProvider getAMQQueueEventQueueProvider(Configuration config) { 		return new AMQPEventQueueProvider(config, false); 	}
You can go ahead and make this change after raising an issue

@ritu-p
I'll do it, thanks


macOS VM does not have "Emulated VLAN" option

When I try to create a new macOS VM, (Ventura or Big Sur), the only options under "Network" are "Shared Network" and "Bridged"
Config:
UTM Version: Version 4.1.5
macOS Version: macos ventura
Mac Chip (Intel, M1, ...): M1

anyone?


fix: [FTL-9076] Updated CLI version

Updated to latest CLI version (with downgraded OCLIF package) to solve build issue

:tada: This PR is included in version 1.16.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Target netstandard 2.0

Based on this doc: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/cross-platform-targeting

DO start with including a netstandard2.0 target.

Most general-purpose libraries should not need APIs outside of .NET Standard 2.0. .NET Standard 2.0 is supported by all modern platforms and is the recommended way to support multiple platforms with one target.

AVOID including a netstandard1.x target.

.NET Standard 1.x is distributed as a granular set of NuGet packages, which creates a large package dependency graph and results in developers downloading a lot of packages when building. Modern .NET platforms, including .NET Framework 4.6.1, UWP and Xamarin, all support .NET Standard 2.0. You should only target .NET Standard 1.x if you specifically need to target an older platform.

This would prevent downstream libraries to support 1.x and would hinder adoption of new versions. In fact this is the case with hocon.configuration - we're stuck to 1.0.0

There's not really much benefit to this library targeting a higher version of .NET Standard than what it supports right now. We don't use much in the way of platform features, other than maybe reading from the file system - everything else is largely home-grown string manipulation APIs. Sticking with a lower .NET Standard target allows for developers running on legacy runtimes to use us easily, so I think we'll stick with that until there comes a point where we need to adopt a higher version of the standard.
This is the issue we're having with Akka.NET itself right now, actually - in order for us to take advantage of improvements in Socket I/O, serialization, memory management, TPL APIs, and so on we have to move onto a higher version of .NET Standard (1.6 -> 2.0) and we'll have to do another release in the future where we can use 2.1.
But I don't see the HOCON library having that issue - it mostly just does text parsing at startup to retrieve values and then that's about it. It should target the lowest common denominator and stay there unless there's some other ecosystem change that necessitates upgrading in the future.


Bot appears offline

Hi, I was testing your bot, I entered the token, and it has permissions for everything(I did all of this in a test server).
I also tried entering my userID, and I also tried to do my username.
The bot appears offline(not sure if this is intended), and this

is what the image looks like
It doesn't let me run any commands. Any help?

same issue

join the discord server for help we are not active here
the discord server invite link in on readme.md


Can this project run on BMV2?

I don't have a Tofino switch, can I run it on the virtual software switch bmv2 and can you provide a corresponding tutorial?

Hi,
Thanks for the comment.
Have a look at: https://github.com/p4lang/behavioral-model
This is bmv2 tutorial. Try to translate the Tofino logic to bmv2 perhaps?

Hello, thanks for your reply. However, I still face some challenges in converting Tofino logic to bmv2. Do you have a version of the program for bmv2? Can you provide a detailed tutorial or step-by-step guide on how to deploy and execute the program on bmv2?

Follow these tutorials to run bmv2 programs: https://github.com/p4lang/tutorials
Then try to translate the tofino logic to bmv2 perhaps? Do not have bmv2 program as of now.
For any doubts on bmv2, you can post on: https://forum.p4.org/


Improve verbose complain spec checker

Warning: don't start with this issue before #2001 is resolved, otherwise you'd end up with a lot of duplicated code
There are a number of specs that try to check if the code complains in verbose mode. An example from array/new_spec.rb:
-> {
  -> { Array.new { raise } }.should_not raise_error
}.should complain(/warning: given block not used/, verbose: true)

This complain expectation works like this;

Store the old value of $VERBOSE in a variable
Set $VERBOSE to true
Run the code
Validate the warning with the given regexp
Restore the value of $VERBOSE

This is only half of the test, since verbose: true also implies we shouldn't be seeing this message if we're in regular mode. And indeed, the given code does warn in Natalie in regular mode.
$ ruby -e 'Array.new { raise }'
$ ruby -e '$VERBOSE=1; Array.new { raise }'
-e:1: warning: given block not used
$ bin/natalie -e 'Array.new { raise }'
-e:1: warning: given block not used

If the verbose argument is set, we probably need to run the block twice, once in verbose mode which should print the warning, and once in regular mode which should not print the warning.

#2007 has an example of a spec that does not work with this change, which means we are unable to make these changes.


Station vocab - possibly remove test stations?

In the Station vocab there are some test stations. Could they be removed?

Requested by Rob (removal of 13773/TestBulkUload)
https://github.com/osparcomm/HARSAT/issues/227

@Osanna123 to check and deprecate the codes

Any development on this?

Codes were deprecated, @HansMJ to make sure they are flagged respectively in the webservices

Thanks @Osanna123, I will inform Rob about this. There is a issue in the HARSAT GitHub on this


Add github topics?

I forgot the name of this tool, and tried searching 'topic: json' and 'topic: cli', maybe those would help discoverability?

Great idea. Besides the mentione json and cli topics, I'd also suggest to add terminal, command-line, shell and go/golang.

Added, thank you :)