Tearsheet: Element focussed twice when using stacked tearsheets

Package
Carbon for IBM Products
Description
Expected : selectorPrimaryFocus to be focussed and not blurred
Actual: selectorPrimaryFocus is focused and then focussed again, causing the onBlur to fire with validation
The problem seems to be in TearsheetShell. The handleStackChange.claimFocus and useEffect both focus the element c
Component(s) impacted
https://github.com/carbon-design-system/ibm-products/blob/main/packages/ibm-products/src/components/Tearsheet/TearsheetShell.tsx
Browser
Chrome
@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version
<EMAIL_ADDRESS>Suggested Severity
Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.
Product/offering
NS1
CodeSandbox or Stackblitz example
https://stackblitz.com/edit/github-1qjirj?file=src%2FExample%2FExample.jsx
Steps to reproduce the issue (if applicable)
see example in stackblitz
Release date (if applicable)
No response
Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I checked the current issues for duplicate issues

@mconway-ns1 I've tried reproducing the issue after downloading the Stackblitz example you provided, but I can't reproduce it locally.
How did you find this issue in the first place, were you able to reproduce this issue locally?
In Stackblits:
https://github.com/user-attachments/assets/b9efd285-13d9-40d4-8c8d-4c29dc10efb9
In local (downloaded from Stackblits):
https://github.com/user-attachments/assets/0ecfb20b-4b7e-41ff-bdfa-25713218060a


Bumped client side dependencies in preparation for switch to dependabot

In order to minimize the initial noise once we switch to dependabot (#1005), I would like to update everything to latest first.
Signed-off-by: Milan Klanjsek<EMAIL_ADDRESS>

Better move quick before the deps are out of date again :trollface:


How to rename/name the tibber energy sensor?

How can I change (or re-setup) the tibber energy sensor with a sensible and short name?
Right now I have something like this in the energy dashboard
tibber:energy_consumption_783b7040e25640d097xxxxxxxx12456
Would prefer something like tibber:total_consumption (that fits the UI)

No relevant for this custom component

Thanks for a great integration/service
I partly understand the conclusion. If there is a way to influence the sensor name when setting up the Tibber integration, then it seems like a rename of a (historical) entity should be a core feature.
Is there a way to influence the name of the Tibber total consumption entity when setting up the integration?
(If so it'll solve my problem since I can remove the integration and redo the setup).

Now i noticed I ended up on the old custom component and not the standard one. I'll repost my request/issue there.


[openal-soft] Fix issue with cmake config.

On Windows, openal-soft config cmake (OpenALConfig.cmake) by default generates a file that contains an absolute path to an interface link library on the build system:
set_target_properties(OpenAL::OpenAL PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include;${_IMPORT_PREFIX}/include;${_IMPORT_PREFIX}/include/AL"
  INTERFACE_LINK_LIBRARIES "C:/Program Files (x86)/Windows Kits/10/Lib/10.0.18362.0/um/x86/WinMM.Lib"
)

This can break if the package is restored from a binary cache on a system where:

the OS is not installed on drive C.
the OS is not 64-bit -- or the package was built on 32-bit Windows but restored on 64-bit Windows.
the Windows SDK version does not match exactly (Visual Studio offers this as an option in the installer).

To fix this, we disable the WINMM and DSOUND backends in openal-soft. This does not result in any lost functionality because as of Windows Vista, WINMM and DSOUND are implemented by WASAPI in Windows itself. The consumer has no knowledge or control over the backend except at build-time. Further, it matches the behavior of the port on Linux and macOS where only a single audio backend is explicitly requested.

What does your PR fix?
See above.

Which triplets are supported/not supported? Have you updated the CI baseline?
No change.

Does your PR follow the maintainer guide?
Yes

Why do these files contain absolute paths?
It should be, example:
INTERFACE_LINK_LIBRARIES "WinMM.Lib"

Why do these files contain absolute paths?
It should be, example:
INTERFACE_LINK_LIBRARIES "WinMM.Lib"

Upstream is directly feeding the system library paths into the OpenAL target_link_libraries().

https://github.com/kcat/openal-soft/blob/openal-soft-1.20.1/CMakeLists.txt#L879
https://github.com/kcat/openal-soft/blob/openal-soft-1.20.1/CMakeLists.txt#L1198

It looks like some major work upstream to fix everything. The easiest fix is, IMO, to disable the libraries that effectively do nothing since Windows Vista.

Upstream is directly feeding the system library paths into the OpenAL target_link_libraries().

https://github.com/kcat/openal-soft/blob/openal-soft-1.20.1/CMakeLists.txt#L879
https://github.com/kcat/openal-soft/blob/openal-soft-1.20.1/CMakeLists.txt#L1198

It looks like some major work upstream to fix everything. The easiest fix is, IMO, to disable the libraries that effectively do nothing since Windows Vista.

/azp run

/azp run


readme: discord server invitation is no longer valid

Describe the bug
The invitation to the discord server is no longer valid.
To Reproduce
Readme page: https://github.com/sbi-dev/sbi/tree/ecfcec51b9d3eb60de4ad9c5760b62ca73488c2a
Discord Server link

Thanks for the pointer. I updated the link, see #1327 .
Until this is merged, you can use the already updated link in the GitHub discussions here: https://github.com/sbi-dev/sbi/discussions/1318


Fix for enabling the certificate store to work on cloud services.

Fix for the RSACryptoServiceProvider to use Machine key store to enable the library to run in an Azure App Service.

It seems to cause different issues on Azure when loading files from Blob Storage now. Any ideas how to fix that?
{
   "Type":"System.Security.Cryptography.CryptographicException",
   "Message":"Keyset does not exist\r\n",
   "InnerExceptions":[

   ],
   "StackTrace":[
      "   at System.Security.Cryptography.Utils.CreateProvHandle(CspParameters parameters, Boolean randomKeyContainer)",
      "   at System.Security.Cryptography.Utils.GetKeyPairHelper(CspAlgorithmType keyType, CspParameters parameters, Boolean randomKeyContainer, Int32 dwKeySize, SafeProvHandle& safeProvHandle, SafeKeyHandle& safeKeyHandle)",
      "   at System.Security.Cryptography.RSACryptoServiceProvider.GetKeyPair()",
      "   at System.Security.Cryptography.RSACryptoServiceProvider..ctor(Int32 dwKeySize, CspParameters parameters, Boolean useDefaultKeySize)",
      "   at System.Security.Cryptography.X509Certificates.X509Certificate2.get_PrivateKey()",
      "   at Mews.Eet.Communication.SoapSigner.GetRsaKey(SignAlgorithm signAlgorithm, X509Certificate2 certificate)",
      "   at Mews.Eet.Communication.SoapSigner..ctor(X509Certificate2 certificate, SignAlgorithm signAlgorithm)",
      "   at Mews.Eet.Communication.SoapMessage.GetSignedXmlDocument(X509Certificate2 certificate, SignAlgorithm signAlgorithm)",
      "   at Mews.Eet.Communication.SoapClient.<SendAsync>d__22`2.MoveNext()",
      "--- End of stack trace from previous location where exception was thrown ---",
      "   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()",
      "   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)",
      "   at Mews.Eet.Communication.EetSoapClient.<SendRevenueAsync>d__17.MoveNext()",
      "--- End of stack trace from previous location where exception was thrown ---",
      "   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()",
      "   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)",
      "   at Mews.Eet.EetClient.<SendRevenueAsync>d__13.MoveNext()",
      "--- End of stack trace from previous location where exception was thrown ---",
      "   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()",
      "   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)",
      "   at ..."
   ]
}


feat(span): format_compact_str! macro

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5611
#5610  👈
#5609
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


some bugs

Hi , i have been testing your new master repo and i found a few bugs .
here are some steps i did so far to bypass some bugs :
for some reason , your detection on "if exists files in original decompiled apk folder" had some issue , i had to by pass that check by ignoring the "if" code at lines : 271 to 274
then everything went well until i get this error :

Failed to run dx on proguard processed jar file
(the good thing is the log on the tool , that i checked this error :
dx unsupported major.minor version 52.0)

i had to ignore your last upgrade on dx file in your third party folder and use my OS dx tool .
for that i went to startup variables at line 29 and changed it to "dx" only , so it can use my system installed DX tool .
the i got another bug when the tool tries to detected the default smali file to hook and get an error :
https://s12.postimg.org/s9vztm0h9/backdoor_apk_001.png
at this part i got stuck because log did not output the cause of the error , only in the image before i knew the cause .
here it is the log :
http://pastebin.com/dgLpnx0F
(Note : i did not had much time yet to concentrate on your new changes and discover the reason , but as soon as i get some time i will check it out .)
for what i could see until now , your android third party upgrade must be back to 23.0 version , because of the dx call , or instead using your folder tools , you can make a simple install.sh file that installs from repository those tools , so you do not have to worry about them .
on debian , to install proguard you just have to write "apt-get install proguard" , every debian repo have this file , and in proguard config you can create a variable based on your tool "path" config , pointing to proguard configuration .
ex :
instead : $PROGUARD @android.pro >>$LOG_FILE 2>&1
you can set a variable like :
proconfig=$MY_PATH/android.pro
and use it as :
$PROGUARD @$proconfig >>$LOG_FILE 2>&1
The dx tool , according to debain repo , they have those tools you need under this package name :
google-android-build-tools-installer
so , "apt-get install google-android-build-tools-installer"
will fix this dependency .
https://s8.postimg.org/sweq1pnvp/repo_002.png
my repository is not the Kali repository , it is the devuan repo witch is a debian jessie fork .
in kali people just have to install it by : "apt-get install aapt dx apktool" etc ...
See if you can figure out (when you get time) , why does tool did not found an hook and why did not popup options for user to choose , like you told you were implementing .
During this weekend i will check the all other stuff , and make some tests .
I have your current repo cloned in my git , i will probably make a setup script to fix all those dependencies depending on user OS detected , and i will test them here .
If everything went good then i will upload the file to my git for you to check it out , and in mean time i will see if we can get rid of those third party folder tools you use .

Well , it looks that the output of backdoor apk depends on tools versions used .
I also noted that facebook.apk is the only one giving me issues after changing somethings here .
I am uploading a video to youtube showing all my changes in realtime and then testing new apks for you to see .
I also show in video how to bypass some errors that i encounter on some apps that backdoor-apk uses .
Finally , i will define a temp directory for backdoor-apk to work with payload and original file inside it .
On this video i show the changes using system instalation of dx app , but backdoor-apk still uses your proguard version .
I will change that .
Note: i will edit this post with youtube link for you to see as soon as i upload it .

@peterpt Hello. I'm sorry but it's not clear what is being reported. If you have a bug to report then please do the following:

Be as concise and accurate as possible
Describe the environment (version of backdoor-apk, has it been modified, etc.)
Attach the APK file used so that I (and others) can attempt to reproduce

Hi , well , it was a bug that i corrected in real time .

backdoor-apk does not work if the original apk is outside backdoor-apk main folder

Some apks give issues , but in generally the tool is wornking fine , the video have 50 minutes because i was not expecting so many susprises when i was testing the apks .
The man objective on video was to show you that if you try to compile a rat apk file on an app outside backdoor-apk folder then it gave issues , and at same time to show you that your tool was unable to work with the facebook apk .
But i got in the way of that process other unexpected issues that i was able to fix , this is why the video took so long time .
Anyway , you should create a few lines of code to copy the original apk file inside backdoor-apk and then work with that file inside your tool folder .
If you test there this command :
./backdoor-apk.sh   /someapp.apk
it will give you an error along the way .
backdoor-apk only works fine if the apk file is on main tool folder :
./backdoor-apk.sh someapp.apk


Using Isso JavaScript client with an alternative backend

Two months ago, I was looking for an open source JavaScript comment widget and backend for my personal sites, and I found Isso to be the best option (polished widget, great docs, actively maintained). However, the requirement for SQLite was a blocker. SQLite is not a good fit for my desired architecture. My reasons are pretty much the same as outlined by Heroku. I looked at modifying Isso to use SQLAlchemy to support both PostgreSQL and SQLite backends, but these changes would have to run fairly deep since there are some SQLite-specific patterns: use of locks for concurrency control, BLOB type (pg has bytea), PRAGMA statements, triggers. I am also not a fan of applications that take the "lowest common denominator" approach to databases, since they necessarily miss out on database-specific features that can provide big benefits in speed, space, and implementation simplicity.
So while I think SQLite is a great fit for many people due to its operational simplicity, I decided to write a PostgreSQL-driven comment backend, also in Python. And along the way, I wanted to create an architecture that allows changing almost any aspect of the application behavior through a plugin system. I just published the project, tentatively named "pg-discuss" (readthedocs, github). I have yet to publicize it: I wanted to run some things by Martin and other Isso contributors and users first.
First, there's no included JavaScript widget, nor do I want to create a new JS widget. I want to recommend users to use the Isso JavaScript client. There is an included extension that "shims" the API to match the expectations of the Isso client. Is there any objection to shipping a built version of the Isso client with this project, along with appropriate credit and links back to the Isso project?
Second, I would like to contribute to the Isso client, such as being able to configure: which input fields display, markdown preview, allowed nesting level, OAuth 2.0 hooks, lazy loading. It is possible that some of these things would be out of scope with the Isso backend. Is there a way we can add these as optional features to the JS widget, even if they may be out of scope for the Isso backend?
Finally, I am hoping these two projects can collaborate and cross-promote. While they are both MIT-licensed comment systems in Python with JS embeds, I feel they occupy different niches. Isso has a great story for easy installation on your own hardware because of SQLite, the built-in WSGI server, and because it is packaged for Debian. Configuration of Isso is very straightforward. pg-discuss has better stories for extensibility via plugins, production-grade storage, and running multiple instances. However, plugin installation and configuration adds some complexity.
Thanks for Isso, it has been a huge inspiration!

Hi Steffen,
good to see new development! I've only glanced over pg-discuss, but I agree with your points. There is a develop branch that uses SQLAlchemy (though I'm not very happy with it in terms of library size). Also, I am not very happy with the current state of Isso. I would like to see a spec that defines the API (server-client) and general interaction model (e.g. required minimum setup for comments and optional extensions, e.g. authentication (OAuth, whatever).
I am currently limited on time for this project and I hope we can indeed collaborate. The current server architecture needs rework and I would like to fix a few design issues, too:

requirement to GET the website and retrieve the title
using bloom filters to store votes

I like to hear your opinion on the API and in general of the concept. Isso is still in 0.x.y and I have a few ideas/change requests (e.g. interchangeable markup w/ hints as you mentioned, configurable url validation for threads and anti spam) before making a 1.x release.
But the core of Isso needs to be minimal (not pulling weird dependencies, e.g not depending on some third-party webservice, easy deployment).

Very interested in this thread. I was looking for Disqus alts and came across this. I would love the ability to write plugins to add support for things like gravatars and social logins, and the ability to write engines for different backends. Any updates since the last comment?

@reubano: pg-discuss has matured to the point where the core API should not change much. I will support whoever would like to write an extension. The default frontend for pg-discuss is currently a slightly modified Isso client. I would like to contribute these little changes back to Isso while preserving compatibility - being able to use the same JS frontend for both Isso and pg-discuss backends is a goal of mine. As to your specific topics:
user icons (eg. gravatar): This would require some changes to the Isso JS frontend. Perhaps an option to configure an icon provider URL in lieu of the JS-generated icons? This is mentioned in the Isso FAQ: https://github.com/posativ/isso/blob/HEAD/docs/faq.rst. The backend (Isso or pg-discuss) would also need to know which value(s) to hash, based on what the provider is expecting.
social logins: You can write an identity provider extension to pg-discuss to authenticate users. It should be possible to write an OATH2 login, amongst others.
Different backends: Do you mean supporting different databases? The Isso backend is probably the best candidate to add support for multiple data stores: it uses SQLite now, but I think @posativ would be open to using a database abstraction layer as long as it is simple and small. pg-discuss is very PostgreSQL-oriented. To take full advantage of Postgres features and also for performance reasons, extensions are allowed to use the PostgreSQL dialect via SQLAlchemy. pg-discuss could be adapted to other data stores, but it would have to be a fork with a different extension API.

@sprin I'm glad that pg-discuss is stable. I too would like to see any pg-discuss front end changes ported back to Isso. @posativ would it be possible to convert Isso to a stub repo that pulls in front-end and back-end submodules? That way pg-discuss (and others?), can pull in just the Isso front end dependency. It would also make it easier to contribute back if the front end was a sep repo.
Re social logins, how difficult would it be to implement your identitypolicy in Isso? I ask because I would like to support different dbs via sqlalchemy. I saw in a previous issue that there is such a branch. @posativ can you clarify on the issues you encountered implementing sqlalchemy? Also, would you be open to support multiple backends in Isso? If not, @sprin could you explain how to go about creating a "different extension API"?

Seems @sprin has diverted their attention elsewhere. pg-discuss development has seemingly stalled in 2016.
The issue for using a different database backend at https://github.com/posativ/isso/issues/61 is still open, but without the driving force of @sprin or contributors such as @reubano, I'm afraid the effort to make Isso's frontend pluggable into other backends will never be tackled.
Closing as such.


Add config for X-Forwarded-For trust

Use the same config option for set_real_ip_from when not using proxy protocol. The default remains <IP_ADDRESS>/0, which is insecure if the ingress is publicly accessible (or its upstream doesn't strip the X-Forwarded-For header). This at least provides a workaround for #200

This change is

CLA should be signed

Coverage decreased (-0.03%) to 46.953% when pulling dd894f0f73f00e06de568ec837fd0f99429ef2f1 on phekmat:patch-1 into 88ca7a555e1a10f03bfbbeb55b5584416fa05dc6 on kubernetes:master.

/lgtm

@phekmat thanks!


Email validation

It is accepting "." (dot) at the beginning of local-part, at the end of local-part, duplicated (like<EMAIL_ADDRESS>or<EMAIL_ADDRESS>and numbers on TLD (like<EMAIL_ADDRESS>instead of accepting only these http://en.wikipedia.org/wiki/List_of_Internet_top-level_domains

See readme

IMPORTANT NOTE ABOUT EMAIL VALIDATION. As of version 1.12.0 this plugin is using the same regular expression that the HTML5 specification suggests for browsers to use. We will follow their lead and use the same check. If you think the specification is wrong, please report the issue to them.


added Folktale to list

Added Folktale to the list of compatible implementations.

Implemented the necessary corrections. Let me know if it is ready to go!

LGTM. Would you mind squashing the commits?

Try running these commands:
$ git rebase 5f4288cb449116747ac6e7e1ad276065303cee03^ --interactive
$ # change ‘pick’ to ‘fixup’ for the second and third commits
$ git push origin master --force

Done!
Let me know if you need anything else!


chore(lintint): jest recommended linting

Jest recommended linting
Description of what's changing
Adding Jest specific linting.
First commit is after the CircleCI stuff is adding the linting; I expect circleCI to fail on this (proof)
the last commit should contain fixes for the jest tests.
...
What else might be impacted?
...
Which issue does this PR relate to?
https://github.com/intuit/user-data-for-fraud-prevention/issues/66
...
Checklist
[x] Tests are written and maintain or improve code coverage
[ ] I've tested this in my application using yarn link (if applicable)
[x] You consent to and are confident this change can be released with no regression

LGTM


Workday,Inc.OfficeConnect version 2022.105.2718.2929

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Package has a dependency on Microsoft Office, and cannot be installed on a clean system
[1D00:1D04][2022-09-08T12:31:03]i052: Condition '(Office1432Installed OR Office1532Installed OR Office1632Installed OR Office1464Installed OR Office1564Installed OR Office1664Installed)' evaluates to false.


Help running inference using yolov5, 6 & 8

Hi,
Thanks for this amazing package!
I'm having troubles running inference using different yolo versions, whenever I'm running tiny_yolov2 test the inference seems to succeed.
Whenever I try any of the other version it fails with segmentation fault - exported to onnx, tried different opsets (including 12) and increase MAX_NUMBER_OF_NODES since yolov8 has 259 nodes.
More observations:
Running resolve function from inferece.c outputs segmentation fault. When I copy the content of resolve function to connx.c it seems to be running (after commenting the part preparing the operators since the opset is already 12).
Doing the same with inference function did not work as it seems that all_context[nodeIdx].executer is NULL.
Can anyone assist please?

Most likely the models that you are using use operators that are not implemented. Note that this project is not currently actively maintained.

Thank you for the quick response!
Is there a way to review which operators are not implemented and implement them myself?

Would suggest adding some prints. Or well, you can also explore the onnx model and search in this repo wether its implemented or not.

Most likely the models that you are using use operators that are not implemented. Note that this project is not currently actively maintained.

@alrevuelta
as you said, this project is not currently actively maintained. is there any maintained/better and similar(pure C/onnx/embedded inference) project?


robustify S.port and D telemetry detection

@thedevleon This should not break existing S.port configs, but testing would be appreciated. It is reliably detecting (and differentiating) X4R and D4R receivers on Pixracer. Not tested on fmu-v2, but the only difference there should be the choice of serial port.
BTW: do you know if the X series receivers put an RSSI "sensor" on the bus? AFAIK, they only poll and we don't have access to the RX measure of RSSI, as we do with D telemetry.

@mcharleb Where (or how) do I define DEBUG_BUILD in order to enable PX4_DEBUG printout?

@thedevleon Can you cross-test?

@LorenzMeier sure, will be able to test as soon as I'm home again on tuesday!

@thedevleon How does testing look like?

@LorenzMeier just tested this with my X8R - everything seems to be working correctly.

@thedevleon do you know if the X series receivers put an RSSI "sensor" on the bus? AFAIK, they only poll and we don't have access to the RX measure of RSSI, as we do with D telemetry.

@kd0aij Yes. Without any smartport cable attached I still get SWR, RSSI and RxBt values - all with the ID 25.

Thanks!

@thedevleon :) By "we", I meant the frsky_telemetry driver, not the Taranis TX. I'm reading RSSI coming from my D4R receiver to the Pixhawk: https://github.com/PX4/Firmware/blob/master/src/drivers/frsky_telemetry/frsky_telemetry.c#L523


Detect if browser supports Framework7

This is a (multiple allowed):

[ ] bug
[x] enhancement
[ ] feature-discussion (RFC)

Hi Vladimir, is there any way to detect if the browser supports Framework7 or not? Neither in device API nor support API I found something. For example, IE 11 does not support Web Apps, Google Chrome does it well. So there should be any variable with true/false to use and show alerts according the status. Regards, Dennis

Define

IE 11 does not support Web Apps

@ZanderBrown - If I open an Framework7 app in IE 11, I have a black page with small grey menu on top - but no more. Open the same in Chrome, there is no issue. Dennis

I don't currently have access to IE11 but using IE NetRenderer to load Kitchen Sink produces:

@ZanderBrown - Please find attached my result for Internet Explorer 11.0.9600 on Windows 7

Are you sure it is related to F7? I see your errors are because of none supported "Object.assign" method. F7 doesn't use this method

Thank

@nolimits4web - Did you test on IE 11 - or, should it even work in IE 11?

Hi,
this is not an issue with framework7, but with framework7-vue.
Object.assign is used there in 4 places (see this link)
Using this polyfill fixed it for me:
https://github.com/rubennorte/es6-object-assign
It would be great to add this to framework7-vue to make ie 11 happy.

@akralj could you post this over at the f7-vue repo?


WIP: Add all routines to set up a voronoi mesh

Open issue for later: What variables do I actually need for the implementation of the FV method in Trixi.jl? For which variables does it make sense to convert the array to Julia-typical types (e.g. Int64) and when?  Can't happen directly after creation, since the following routines require C types.

For which variables does it make sense to convert the array to Julia-typical types (e.g. Int64) and when? Can't happen directly after creation, since the following routines require C types.

Maybe we should just not convert anything to Julia types in this package and instead leave it to the user? Alternatively, we could provide additional methods for those functions that accept the return element type as the first argument, i.e., foo(arg1, arg2) gets foo(Float64, arg1, arg2) etc.
For now, though, I'd just remove the conversion to default Julia types as you did 👍

I will add the routine's doctrings in another PR. So, this one here is ready to review/merge. Do you @sloede  @simonechiocchetti want to take a look before I merge it?


No vendor folder

public/index.php has this line:
require_once dirname(__DIR__).'/vendor/autoload_runtime.php';
dirname('public') takes us to demo-main which has no vendor folder.
What aren't you telling us?

You must run composer install to download vendors and autogenerate /vendor/autoload_runtime.php

Hey @threed-factory-store,
Please, follow the installation guide in the README to install it in a simple way: https://github.com/symfony/demo#installation
If you install this project in another (more advanced) way - we already suppose you know the basics of Composer

Victor is right. We provide two different commands to install the project (via Symfony CLI and via Composer). Both commands create the vendor/ directory and download everything that is needed. If users prefer other installation methods, we can't provide the instructions for it. Thanks for understanding!


Add betterdiscord plugin link to website?

BetterDiscord (discord modified application) now has a PronounDB plugin to see pronouns directly in the application, would be neat to link it on the main page or a subpage on pronoundb.org! Not sure if this is out of scope just lemme know :)
Link: https://betterdiscord.app/plugin/PronounDB

I'm aware it exists; just like the Powercord plugin it will not be listed on the website.


Upgrade to Doks v1.0.0

https://github.com/h-enk/doks/releases/tag/v1.0.0
I'm not sure about how complex it can be though.

@simonpasquier I attempted the update, tried a bunch of time but always had some issues. Should be fairly easy for someone familiar with the JS. Here are some changes,

The alert short code should be changed to callout note.

Old - {{< alert icon="👉" text="Prometheus Operator requires use of Kubernetes v1.16.x and up."/>}}
New - {{< callout note >}} Prometheus Operator requires use of Kubernetes v1.16.x and up. {{</ callout >}}

External images are not yet supported. I believe there are very few images and it could be handled easily.

working on this
cc @simonpasquier @pavangudiwada

/assign @Ayush9026 i'll solve this.


How to make collectioview show messages immediately

What needs to be done so that when the chatviewcontroller push-navigates, the data is already ready?
An empty collection is shown. then messages? Like no spawn animation.
i played with it
collectionView.contentInsetAdjustmentBehavior = .always
changed to this
collectionView.contentInsetAdjustmentBehavior = .never
then the collection of elements is loaded immediately
but there are a number of artifacts associated with tabbar navigation and inputAccessoryView
inputAccessoryView twitches and disappears and reappears 2 times
I attach screenshots

please help me how to do this, thanks

What exactly should I do?

remove

    override var inputAccessoryView: UIView? {
        inputBarView
    }

    override var canBecomeFirstResponder: Bool {
        true
    }

adding and change

    view.addSubview(inputBarView)
    inputBarView.bottomAnchor.constraint(equalTo: self.view.keyboardLayoutGuide.topAnchor).isActive = true
    collectionView.bottomAnchor.constraint(equalTo: inputBarView.topAnchor, constant: 0),

where to add this: let keyboardOffset = max(0, view.safeAreaLayoutGuide.layoutFrame.maxY - view.keyboardLayoutGuide.layoutFrame.minY)

func keyboardWillChangeFrame(info: KeyboardInfo) {
        guard !currentInterfaceActions.options.contains(.changingFrameSize),
              collectionView.contentInsetAdjustmentBehavior != .never,
              let keyboardFrame = collectionView.window?.convert(info.frameEnd, to: view),
              keyboardFrame.minY > 0,
              collectionView.convert(collectionView.bounds, to: collectionView.window).maxY > info.frameEnd.minY else {
            return
        }
        currentInterfaceActions.options.insert(.changingKeyboardFrame)
        let newBottomInset = collectionView.frame.minY + collectionView.frame.size.height - keyboardFrame.minY - collectionView.safeAreaInsets.bottom
        if newBottomInset > 0,
           collectionView.contentInset.bottom != newBottomInset {
            let positionSnapshot = chatLayout.getContentOffsetSnapshot(from: .bottom)

setupInsets() what is there?
eventHandler  what is there?

     private var isFirsAppearance = true
     override func viewDidLayoutSubviews() {
        super.viewDidLayoutSubviews()

        // Hack to prevent animation of the contentInset of first appearance. The same is used in MessageKit
        if isFirsAppearance {
            isFirsAppearance = false
            setupInsets()
            let initialCells = eventHandler.getInitialCells()
            if !initialCells.isEmpty {
                processUpdates(with: initialCells, animated: false, ignoreInterfaceActions: true)
            }
        }
     }

@Sabellus Yep you understand in general fine. But you should understand I am giving you a theoretical code. I can not write it for you. I can only give you some directions.
evenHandler in this case something that will return initial cells in the collection view
setupInsets looks something like

Appreciate your help! It works ❤


client support for reverse-proxied proxy

TL;DR This small patch allows the client to contact a remote proxy service which runs behind a URL which is not necessarily bound to /.
Background:
I've been trying to run PushProx proxy behind a reverse proxy.
The reverse proxy was listening on the URL http://servername/pushprox/
Once a connection comes in to the reverse proxy, the servername is replaced to the internal host and the /pushprox is stripped from the URL.
This configuration works just fine from the proxy process side. However, the client couldn't properly contact the serve because the /pushprox/ was stripped from the final URL.
The reverse-proxy configuration is based on nginx. This is the configuration block used:
        location /promproxy/ {
                # All requests originated to the "/promproxy/" are relayed to the prometheus "proxy" service and "/promproxy/" is truncated from requested URL.
                proxy_pass http://<IP_ADDRESS>:8080/;
                # Force HTTP/1.1 so websocket will work (the connection will be kept alive).
                proxy_http_version 1.1;
                proxy_set_header Upgrade $http_upgrade;
        }

The command line I use:
client --proxy-url=http://my-server/promproxy

The existing code should already be doing that. Are you sure this is what's going wrong?

Ok... So I double checked now.
Apparently, if the command is:
client --proxy-url=http://my-server/promproxy then the outgoing request will be to http://my-server/poll.
However, if the command is  client --proxy-url=http://my-server/promproxy/ (note the trailing '/') then the outgoing request will be to http://my-server/promproxy/poll.

I feel embarrassed for not checking this before...
I still think that a small fix is needed - the trailing '/' shouldn't be mandatory in input. Would you be interested that I'd provide such a fix?

It'd probably be best to always add the trailing /, so the user isn't tripped up by this.

I've updated the PR title and pushed new code to make sure the proxyURL ends with a single '/'.

Thanks!


[DOCFIX] Add javadoc for SpecificTierWriteIntegrationTest

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15613/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15666/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15680/
Test PASSed.

Merged build finished. Test PASSed.


Branding settings

Added branding settings page, where you can change favicon, brand logo and brand name.
Brand logo and name is displayed in place of "WIREGUARD UI" in the upper left corner.

Sorry, cannot find branding settings anywhere, any clues?


Library does not work with https

I just updated the p5.js web editor to use https, which broke @tigoe's p5.serial example. I had to change the file p5.serialport.js, on line 78, to
this.socket = new WebSocket("wss://" + this.hostname + ":" + this.serverport);

to get it to work.

@catarak when you made that change, were you working off a local version of your editor?  I get errors when I try to do this.  I assume they are HTTPS related since I don't have any certificates or exclusions for localhost setup.

No, I was working with the production version of the editor. In the p5 serial library you might have to check if the connection is http or https, as you might not be able to mix them. You were trying wss with an http connection?

Sadly, Chrome doesn't allow HTTPS (web or websocket) connections to localhost without at least a self-signed certificate running on the same machine.  (I am not sure why it worked for you which is what prompted my question.)  Unfortunately, users will still have to jump through hoops to allow the connection with a self-signed cert.
Longer term, we can probably come up with a solution using Let's Encrypt and a localhost type of domain name: localserial.processing.org or the like.
We also need HTTPS for getUserMedia and related things so it makes sense to require it with the editor but would it also be possible to allow plain HTTP in the online editor in the short term?


Slow UI startup during weak internet connection

When the update manifest file at https://neo.org/client/update.xml couldn't be reach during app startup, the main UI does not show until connection timeout or when the file is finally downloaded. Showing a "checking for updates" form would be helpful.

Hi @lock9 ,the url is a dead link now, do we have plans to improve it?

@Ashuaidehao  this is very important, this causes a really bad use experience, and has a very low "cost to fix".
Any chances you guys could make a PR to remove this load? If the url is dead, there is no sense  to keep this load.

Hi @erikzhang , is there someone who maintain the “update.xml” file?
If no one maintains it, maybe we should remove these useless code.

No one is currently maintaining this file. But maybe we can put this file on Github so that any core developer can maintain it.


Disable default filetype mappings

On 06/04/23, @nmkip asked on Discord::

Is there a way to disable all the default mappings in one line or do I have to go one by one?

This PR adds an option to disable all of the default mappings for the clients listed in g:conjure#filetypes.
I hope I didn't misunderstand what was wanted.

BTW, I forgot to mention that I arbitrarily chose conjure#mapping#enable_ft_mappings and am not terribly wedded to it. Please choose something that better aligns with your liking.

Thanks a lot! I like the name, it's as good as any and I'd only pick something similar. Just a colour of a bike shed really 😄 much appreciated!


Invalid thread values cause softlock on "Use Input"

Summary
When OFToast gets an error prompt for invalid thread values, typing a second invalid thread for "Use Input" prevents Advanced from being interacted with.

Step to reproduce

Launch OFToast
Navigate to Advanced.
Change the number of threads to an invalid amount (decimal, alphanumeric, symbols, etc).
In the error prompt, type in the text field another invalid amount.
Click "Use Input"

What I expected
OFToast should reject the second invalid input.
What actually happened
It accepts it and locks out the ability to press Advanced.
System Specifications

OFToast Version: v0.0.0-alpha3
OS: Fedora Linux 37 (KDE Plasma) (64 bit)
CPU: AMD Ryzen 5 2600 Six-Core
GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
OpenGL Version: 4.6
Screen resolution: 1920x1080

Issue is already being covered in #15


Applyfilterasync - enhancement

This method is most excellent for dynamically updating filters.  However, the problem we run into is when users deploy custom saved views, then the filters saved by the user should take precedence.
Within the extension logic, we can inspect the "document.url" and make a determination of a custom saved view by existence of the @ sign.  And this works well.  The time that this doesn't work is when we are embedding a view and the user chooses to set the custom saved view as default.  At this point, we never see the @ sign in the URL.

Hi Jeff,
We have some upcoming work related to handling Custom Views in the Extensions API a little bit better. Your request makes complete sense and we will incorporate it when we start the work to improve Custom Views support. Thanks!


fix: Handle the scenario where a package.json#browser field could be false

We recently shipped support for the browser field, but we discovered an edge case where instead of mapping to another string, the value could be false (eg, object-inspect), which indicates that this module should be treated as an empty object ({}) (evidenced by its usage here).
The code was previously erroring on the string's startsWith checks, causing the entire package to be omitted from the file mapping result. This ensures that if the value is false we'll continue on.

This one is failing on Windows only:
2024-06-24T23:06:19.1227177Z
2024-06-24T23:06:19.1227722Z   ● should correctly trace zeromq-node-gyp from cwd
2024-06-24T23:06:19.1228234Z
2024-06-24T23:06:19.1228583Z     expect(received).toEqual(expected) // deep equality
2024-06-24T23:06:19.1229108Z
2024-06-24T23:06:19.1229352Z     - Expected  - 0
2024-06-24T23:06:19.1229760Z     + Received  + 1
2024-06-24T23:06:19.1230017Z
2024-06-24T23:06:19.1230244Z     @@ -1,7 +1,8 @@
2024-06-24T23:06:19.1231259Z       Array [
2024-06-24T23:06:19.1232608Z<EMAIL_ADDRESS>2024-06-24T23:06:19.1234088Z     +<EMAIL_ADDRESS>2024-06-24T23:06:19.1235188Z<EMAIL_ADDRESS>2024-06-24T23:06:19.1236451Z         "node_modules\\zeromq\\lib\\draft.js",
2024-06-24T23:06:19.1237453Z         "node_modules\\zeromq\\lib\\index.js",
2024-06-24T23:06:19.1238165Z         "node_modules\\zeromq\\lib\\native.js",
2024-06-24T23:06:19.1240146Z         "node_modules\\zeromq\\lib\\util.js",

Confirmed this has nothing to do with this PR, tests are failing here too
https://github.com/vercel/nft/pull/432

@styfle there was already one here https://github.com/vercel/nft/blob/main/test/unit/browser-remappings-malformed/node_modules/pkg/package.json.
However I was hoping to revisit this after we land this to ensure that these tests are actually asserting what we think they are. That test, for example doesn't actually require the file mentioned in the browser setting in the entry. So improving on the tests feels a bit out of my depths

@jeffsee55 I'm not suggesting that you change the existing test. I want a new test that tests for browser as a string.
Something like:
{
  "name": "pkg",
  "main": "index.js",
  "browser": {
    "./browser.js": "browser.js"
  }
}

And then require('pkg') should emit node_modules/pkg/browser.js even though that file isn't explicitly required.
That would prove that your comment is correct when it says "Downstream processing is expected to handle this case, and it should remain in the mapping result"


Build to Heroku is Failing

Application Error
An error occurred in the application and your page could not be served. Please try again in a few moments.
If you are the application owner, check your logs for details.

Was there anything of note in the logs?

Also, was this a deployment using the Heroku Deploy button or a custom deployment? Did you change any of the configuration?
I just tested the Heroku Deploy button, with default configuration and it worked fine.

Must has been a fluke or just inbetween commits or something, I deteled app and tried again and sure enough it worked, Thank you guys for quick response, on this app were would the default logs go?


add SIMD support to mat4.multiply

work in progress. let's discuss things such as:

correct runtime detection
how to test this [properly]? (I had an || true and the SIMD.js polyfill)
garbage creation
should the loop be unrolled? or should we roll it up
maturity of SIMD.js spec (might be a while)
profiling (which I've yet to do)

or anything else

The code here looks really nice, and is generally what I'd want to see from this kind of optimization. I'd still love to understand the performance characteristics a bit better. I tried to do a quick and dirty jsperf comparison between the methods (http://jsperf.com/simdmat4), but jsperf is rather dead right now. :( I'll try and put together a local profiling script later.
Questions about detection and testing are good ones and I'll have to think on it a bit more. I'll definitely go on record saying glMatrix is in favor of loop unrolling, though!
For my information, what's the best way to get a browser (any flavor) that supports SIMD.js at the moment? It seems that the Firefox builds may only use it in the context of ASM.js?

Currently, Firefox nightly build supports SIMD.js. I have some numbers to report from my experiments with SIMD version of Mat4 operations; the results are averaged over 10 iterations, each repeating the operation for 500,000 times.
Multiplication
glMatrix - Avg: 20.2ms, Min: 19ms, Max: 21ms
glMatrix-SIMD - Avg: 6.8ms, Min: 5ms, Max: 15ms
Invert
glMatrix - Avg: 23.5ms, Min: 22ms, Max: 26ms
glMatrix-SIMD - Avg: 11.9ms, Min: 9ms, Max: 33ms
Translation
glMatrix - Avg: 4.8ms, Min: 4ms, Max: 6ms
glMatrix-SIMD - Avg: 1.9ms, Min: 1ms, Max: 4ms
Scaling
glMatrix - Avg: 5ms, Min: 4ms, Max: 7ms
glMatrix-SIMD - Avg: 1.6ms, Min: 1ms, Max: 3ms
Rotation (X axis)
glMatrix - Avg: 4.2ms, Min: 4ms, Max: 5ms
glMatrix-SIMD - Avg: 2.3ms, Min: 2ms, Max: 5ms
Rotation (Y axis)
glMatrix - Avg: 4.1ms, Min: 3ms, Max: 5ms
glMatrix-SIMD - Avg: 2.4ms, Min: 2ms, Max: 5ms
Transpose
glMatrix - Avg: 2.7ms, Min: 2ms, Max: 4ms
glMatrix-SIMD - Avg: 2ms, Min: 1ms, Max: 5ms

Those are really great numbers overall! Especially nice to see Multiplication approaching a 4X improvement on average.
 I'd love to start working this into the code base, but if the tradeoff is XX more garbage collection pauses for YY more performance it will have to be considered carefully. Unfortunately that's the kind of behavior that averages like this tend to gloss over.

@sunfishcode has some insights.  Particularly that SIMD vectors are value types as opposed to object types.  Not sure if that makes a difference to the GC or not.

Once the JIT warms up, SIMD values are compiled to raw SIMD values in hardware registers rather than on the GC heap.

That makes a lot of sense, thanks or the clarification! Given that I don't see any reason not to move forward with this PR as long as the detection is working as intended and we're cone up with a testing pattern that we're comfortable with.
I'm also going to suggest that since this is technically a backwards-compatibility-breaking change we default SIMD behavior to disabled during early development so that it doesn't disrupt current users but allows adventurous developers to test and contribute.

as long as the detection is working as intended

I'd like another day to do more testing. Particularly, I'm curious if various build systems might redefine this to not refer to the global context.

this is technically a backwards-compatibility-breaking

Is it?  I can't spot where.

default SIMD behavior to disabled during early development

Yeah, I think that's a good idea.  No rush on enabling SIMD fast paths, or even this pull request.  Please invite others for their input.  Particularly, I'd like to see if there's a way to "design for test," as in to see if we can inject the SIMD polyfill to test for correctness.  Maybe I can whip that up in a separate branch and we can land test harness support before this?

One of the more common patterns with glMatrix (which may even be used in
the tests, I don't recall) is to use online arrays as inputs. Like so:
mat4.translate(out, in, [10, 0, 5]);
If that's using SIMD on the back end that shorthand breaks. Same goes for
if you're using arrays-as-vectors from some other third party library. The
strict requirement for TypedArrays will probably cause a lot of minor
breakage across the board. Most of it should be easily fixable but it's
still a breaking change.
It's worth noting that glMatrix was first built at a time when TypedArrays
were still a poorly supported and WebGL-specific concept. We've largely
moved past that now, so I have no qualms about gently guiding the library
towards TypedArray use exclusively. Maybe that's a good target for glMatrix
3.0? TypedArrays everywhere with a focus on SIMD? In the meantime having it
optional in 2.x provides a good migration/experimentation path.
On Thu, Jul 30, 2015, 6:08 PM Nick Desaulniers<EMAIL_ADDRESS>wrote:

as long as the detection is working as intended
I'd like another day to do more testing. Particularly, I'm curious if
various build systems might redefine this to not refer to the global
context.
this is technically a backwards-compatibility-breaking
Is it? I can't spot where.
default SIMD behavior to disabled during early development
Yeah, I think that's a good idea. No rush on enabling SIMD fast paths, or
even this pull request. Please invite others for their input. Particularly,
I'd like to see if there's a way to "design for test," as in to see if we
can inject the SIMD polyfill to test for correctness. Maybe I can whip that
up in a separate branch and we can land test harness support before this?
—
Reply to this email directly or view it on GitHub
https://github.com/toji/gl-matrix/pull/172#issuecomment-126534075.

That sounds like a good plan; thanks for pointing out the compatibility implications.  Shall we disable for now with an && false or have two distinct flags SIMD_AVAILABLE and DISABLE_SIMD?

Yeah, let's do that. Minor style preference: ENABLE_SIMD instead.
On Thu, Jul 30, 2015, 6:31 PM Nick Desaulniers<EMAIL_ADDRESS>wrote:

That sounds like a good plan; thanks for pointing out the compatibility
implications. Shall we disable for now with an && false or have two
distinct flags SIMD_AVAILABLE and DISABLE_SIMD?
—
Reply to this email directly or view it on GitHub
https://github.com/toji/gl-matrix/pull/172#issuecomment-126536520.

I just had a thought on how we could test this.  We could reuse the idea of aliasing that's already used for matX.mul, just creating a mat4.multiply alias dynamically.  So instead of:
if simd
  return anonymous_function
else
  return anonymous_function

we'd have something more like:
mat4._SIMDmultiply = ->
  ...
mat4._nonSIMDmultiply = ->
  ...
mat.multiply = (->
  if simd
    return mat4._SIMDmultiply
  else
    return mat4._nonSIMDmultiply
)()

That way, in the tests for mat4, we can explicitly test both mat4._SIMDmultiply and mat4._nonSIMDmultiply. The downside here is that we would be exposing the two underscore-prefixed methods.  What are your thoughts on this idea?

I'm not opposed at all to exposing the two function variants, and in fact I don't think we should try and "hide" them either. What if we simply did:
mat4.multiply<Something?> = ...
mat4.multiply = (
  if simd
    return mat4.multiplySIMD
  else
    return mat4.multiply<Something?>
)()```

or alternately (and I think I like this better):

```mat4.SIMD.multiply = ...
mat4.<Something>.multiply = ...
mat4.multiply = (
 // You get the idea
)()```

Then testing is easy, and it benefits people trying to do code migration. They can switch on SIMD at some point and then replace a few incompatible bits with the explicitly backwards compatible version, or gradually replace bits of their code base with the SIMD version instead. Sounds like a win-win to me!

The hard part, of course, is figuring out the name for the non-SIMD path. :) "Legacy" sounds premature, "Compatibility" is too lengthy to expect anyone to type, "Core" makes it sounds like SIMD is a super set, as does "Base" or "Basic", "Array" is confusing because both SIMD and non will use TypedArrays. Hm...

Bikeshedding welcome on this one. ;D

How about "SISD" :P

Been :ghost: lurking on this thread. Looking forward to this.

"SISD" is actually not terrible, but I'm concerned that it's maybe a bit obscure for the average web developer who hasn't had to muck around in the world of SIMD until now. It also wouldn't hurt if it was a bit more visually distinct from "SIMD" at-a-glance to help with code readability. Not gonna rule it out just yet, though.

Agreed, quick readability and autocomplete are pretty important here.

I also made own SIMD.

Ok, so it looks like the polyfill is not an npm module.  This patch is not mergeable as is, since I did not commit the pollyfill itself.  Should we ask them to publish to npm and add it to our devDependencies?  Also, should I reimplement all of the tests from SISD for SIMD? [my guess would be yes].  Also, still open to ideas for replacing 'SISD'.  Maybe 'scalar'?

@sajjadt and others.  We really appreciate this (on behalf of the SIMD.js team).  I was curious about the numbers you reported for the mat4.invert() improvement.  A while ago I wrote an invert benchmark:
https://github.com/tc39/ecmascript_simd/blob/master/src/benchmarks/inverse4x4.js
It's using Cramer's rule.  I saw close to 8x speedups.
Have you posted your source code anywhere?

I'm really happy to see this kind of usage! Do you have any feedback for the SIMD.js spec? It's now right around the end of when it'll be OK to make changes.

I pester @sunfishcode all the time. ;)  I was asking for horizontal add for single precision floats, but that would only be useful to my initial naive implementation, so I don't really need that anymore.
IRT this particular PR, we now have left to decide on SISD or w/e.  Also, @toji , should I make the tests now split based on SIMD/SISD?
describe 'when SISD'
  describe 'a'
  describe 'b'
  describe 'c'
  ...
describe 'when SIMD'
  describe 'a'
  describe 'b'
  describe 'c'
  ...

I would guess 'yes', but wanted to defer to the maintainer (not sure how attached to git blame you might be).
Also, @juj points out that there is indeed a faster implementation of mat4 multiply in his MathGeoLib.  I'm happy to translate that, but would ask @toji if he would consider it in a follow up PR.  Landing this implementation would free up others to begin additional implementations of other functions, since here we've mixed mat4 multiply, the runtime detection, and testing in one PR.

@sajjadt I meant the source code for your SIMD version of mat4.invert(), not the mul()

Yes on splitting the tests into SISD/SIMD, but as I think about it we should make every effort to not actually repeat tests. The code should produce the same results in either mode, with maybe some minor additions around testing what types are accepted. I'm no jasmine expert, but I believe that we should be able to pull off a pattern like this:
function mat4Tests(use_simd) {
  glMatrix.ENABLE_SIMD = true;
  return function() {
    var mat4 = require("../../src/gl-matrix/mat4.js");

    describe("create", function() { /* ... */ });
    // etc...
  };
}

describe("mat4 (SISD)",  mat4Tests(false));
describe("mat4 (SIMD)",  mat4Tests(true));

Of course that will be a decently large refactoring, so I'm not going to block the pull request on it. For now it's sufficient to just add new tests specifically for the new SIMD methods and we can make it pretty later. I'm also fine pulling the existing algorithm and then improving on it with a follow up PR. I think it's more important to start establishing the code patterns for the new paths than it is to get an optimal implementation on the first pass.

Folks, great to see this development!
@sajjadt, excellent numbers. Looking forward to seeing SIMD.js use in CV libraries fro WebRTC.

@PeterJensen I ended up using that. Here's the link to the source code.

@mhaghigh  That would be a great contribution for OpenCV. Did @huningxin work on Emscripten SIMD support?

This looks like it's in a pretty good state now. Still not sure if I'm happy with "SISD" long term, but that's a pretty easy search and replace if we decide to change it later.
Anything else you wanted to address before the first merge?

Go for it, follow up issues have been filed and are being tracked.  All systems go!  May a thousand SIMD flowers bloom.

BOOM! SIMD in da house!

:rocket: :rocket: :rocket:

:+1:

@nickdesaulniers , thanks for doing this. Really nice work!

Did @huningxin work on Emscripten SIMD support?

I did. @juj is leading this effort. Please find more details at https://github.com/tc39/ecmascript_simd/issues/59#issuecomment-113824806

Quick note: After giving it some thought I decided to go with .scalar as the alternative to .SIMD. SISD was a good and as accurate as it gets, but being one character off from the alternative was bad for readability I felt. 'scalar' is still well understood in this context and more visually differentiated (and easier to autocomplete for you IDE types out there).


Discovery contract change. Wrap patient object around response object

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 3

Clones added
============
- hip-service-test/Discovery/Patient/FilterTest.cs  4
- hip-service-test/Discovery/Patient/DiscoveryUseCaseTest.cs  2

Clones removed
==============
+ hip-service-test/Discovery/Patient/PatientDiscoveryTest.cs  -2
+ hip-service-test/Discovery/Patient/PatientsControllerTest.cs  -2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1

Clones added
============
- hip-service-test/Discovery/Patient/DiscoveryUseCaseTest.cs  2
- hip-service-test/Discovery/Patient/FilterTest.cs  4

Clones removed
==============
+ hip-service-test/Discovery/Patient/PatientDiscoveryTest.cs  -2
+ hip-service-test/Discovery/Patient/PatientsControllerTest.cs  -2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3

Clones added
============
- hip-service-test/Discovery/Patient/DiscoveryUseCaseTest.cs  2
- hip-service-test/Discovery/Patient/FilterTest.cs  4

Clones removed
==============
+ hip-service-test/Discovery/Patient/PatientDiscoveryTest.cs  -2
+ hip-service-test/Discovery/Patient/PatientsControllerTest.cs  -2

See the complete overview on Codacy


How to provide configuration through hiera?

I'm having problems providing configuration for hashes through hiera. Does anybody have a working example of how to do it?
For example, this configuration:
loki::schema_config_hash:
  schema_config:
    configs:
      - from: 2020-05-15
        store: boltdb-shipper
        object_store: s3
        schema: v11
        index:
          prefix: index_
          period: 24h

fails with:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Lookup of key 'loki::schema_config_hash' failed: Value for key 'loki::schema_config_hash', returned from lookup_key function 'eyaml_lookup_key', when using location '/srv/puppet/oldenvironments/xyz/hieradata/bi/loki_prod.yaml', has wrong type, expects Puppet::LookupValue, got Hash[String, Hash[String, Array[Hash[Enum['from', 'index', 'object_store', 'schema', 'store'], Any, 5, 5], 1, 1], 1, 1], 1, 1] (file: /srv/puppet/oldenvironments/xyz/site.pp, line: 59, column: 1) on node puppet

i have a working setup documented here => https://github.com/attachmentgenie/vagrant-observability/blob/master/production/data/common.yaml

Thank you for your answer. Unfortunately, apart from not using profiles in my case, the configuration format seems to be the same?
Could this be related to having lookup_key: eyaml_lookup_key configured for my hierarchy?

that is what your error message suggests indeed it throws a type mismatch error.


Remove jasmine and phantomjs restrictions (Fixes Sierra issues)

Removes the restrictions on these dependencies to install the latest
version as there is a bug in phantomjs on MacOS Sierra seen
when running rake test:javascript (0 tests actually run)
I do not believe the issue seen in https://github.com/ManageIQ/manageiq/pull/11090 is an issue anymore

Wait, we have javascript in gems/pending?

I'll check again in the morning, but we have that restriction in because 2.5 was broken for us - incompatible with any version of phantom js that's available via gems... Just something to keep in mind ;-)

Wait, we have javascript in gems/pending?

Yeah, it's seems odd to have jasmine in gems/pending.  😕

2.5 was broken for us - incompatible with any version of phantom js that's available via gems

Yeah, I was going to say lets check with @himdel and Co. since he constrained it to "~>2.4.0" and that too very recently (just last month)

so the order of operations seems to be that phantomjs was locked down in https://github.com/ManageIQ/manageiq/pull/6716, followed by the lockdown of jasmine-core in https://github.com/ManageIQ/manageiq/pull/11090 .  The former lockdown is the only reason we needed the latter.  However, at this point in time, there doesn't seem to be a need to lock anything down, as everything at the latest works fine.

@fryguy.. Two things.. We locked phantom js because the new version sometimes just decided to hang, need to check if it still does that.
But the other, I tested Jasmine 2.5 with the newest available phantomjs and it was broken because Jasmine 2.5 needs a browser that supports es6. So nope, sorry :-)

But the other, I tested Jasmine 2.5 with the newest available phantomjs and it was broken because Jasmine 2.5 needs a browser that supports es6. So nope, sorry :-)

I don't understand, you tried then or you tried now?

Tried then, with 2.5.0 or 2.5.1 I think. If a new version came out since that doesn't have to problem, I withdraw all my complaints :-)
Will test tomorrow if this is still open then, bedtime now

Merging since this fixes Sierra users...we can always revert if it causes problems.

Aah.. the issue with jasmine-core & phantomjs got fixed in jasmine-core 2.5.1 - so we should be fine :).
There's still the issue of tests randomly hanging on the newer version of phantomjs, but maybe it got fixed since too :) We'll see :).
One thing though.. I'd feel much more comfortable if we fixed jasmine (and jasmine-core) to ~>2.5.0, given that everything broke the last time they upgraded..

Euwe Backport details:
$ git log
commit 1a4d3e2824b7c26eae487cb2646cadcd3089e1c4
Author: Jason Frey<EMAIL_ADDRESS>Date:   Tue Oct 11 15:49:57 2016 -0400

    Merge pull request #11834 from chrisarcand/fix-sierra-phantomjs

    Remove jasmine and phantomjs restrictions (Fixes Sierra issues)
    (cherry picked from commit 3a9cf6c8b6ea55a2facbb18e7b643a38f8e53e5d)


mercurial: 5.2.2 -> 5.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mercurial/versions.
meta.description for mercurial is: '"A fast, lightweight SCM system for very large distributed projects"'.
meta.homepage for mercurial is: '"https://www.mercurial-scm.org"

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 5.3 with grep in /nix/store/zhrw05i6alr2y15mkppqrwcmdgn4z1zm-mercurial-5.3

directory tree listing: https://gist.github.com/72e1635231a94304f79c865f3aefddde

du listing: https://gist.github.com/5bd364db134e82aac052518634ff5197

Rebuild report (if merged into master) (click to expand)

78 total rebuild path(s)
20 package rebuild(s)
20 x86_64-linux rebuild(s)
20 i686-linux rebuild(s)
19 x86_64-darwin rebuild(s)
19 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
cabal2nix
dep2nix
devpi-client
gitAndTools.git-remote-hg
gitAndTools.gitFastExport
hound
hydra
mbed-cli
mercurial
mercurialFull
nbstripout
nix-prefetch-hg
nix-prefetch-scripts
nix-update-source
python27Packages.hglib
python27Packages.hgsvn
python37Packages.hglib
python38Packages.hglib
reposurgeon
sourcehut.hgsrht

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zhrw05i6alr2y15mkppqrwcmdgn4z1zm-mercurial-5.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mercurial https://github.com/r-ryantm/nixpkgs/archive/523ea83cec773ba5c1816e19334972c59dfd8060.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zhrw05i6alr2y15mkppqrwcmdgn4z1zm-mercurial-5.3
ls -la /nix/store/zhrw05i6alr2y15mkppqrwcmdgn4z1zm-mercurial-5.3/bin

cc @edolstra for testing.

Changelog (for reference): https://www.mercurial-scm.org/wiki/Release5.3


onboarding: Customize Welcome Bot message for education organizations.

Fixes #21694
Testing plan:
I'm not sure how to test this change. Neither manually nor using the test suite.

@raghupalash - Thanks for working on this! Closing this PR as the issue has been fixed by #25362.


slack notify retry canceled due to unrecoverable error 403

ts=2024-02-18T18:53:00.366Z caller=dispatch.go:352 level=error component=dispatcher msg="Notify for alerts failed" num_alerts=1 err="slack-notifications/slack[0]: notify retry canceled due to unrecoverable error after 1 attempts: channel "#monitoring": unexpected status code 403: invalid_token"
alertmanager.yml
global:
slack_api_url: 'https://hooks.slack.com/services/T06L1G****'
route:
receiver: 'slack-notifications'
receivers:

name: 'slack-notifications'
slack_configs:

channel: '#monitoring'

Rules
groups:

name: os
rules:

alert: NodeExporterDown
expr: up{job="node_exporter"} == 0
for: 15s
labels:
severity: critical
annotations:
summary: "Node Exporter is down"
description: "Node Exporter is down for more than 2 minutes"

Hi, 403 error codes should not be retried. IT seems that there is some issue with your slack configuration:
https://api.slack.com/messaging/webhooks#handling_errors

Hi @rapphil
Does alertmanager retry only 5xx errors? Is there a documentation present on retry mechanism of Alertmanager?


Next nuget package

Describe your question
I wonder if it is planned to release a new version of a nuget package with last changes ? This could also be a preRelease version...
Which Blazor project type is your question related to?

Client-Side
Server-Side

We've discussed releasing a preview version for 2.0 internally and I think it would make sense.
@mariusmuntean what commit do you think we should base this preview release on? In my opinion the latest (e930f50db02bb42c00c8f7db47419e4c19ea1c6e) would make sense but we should discuss it beforehand.
Also do you think it makes sense to setup a new pipeline or just do it manually? I'm in favour of doing it manually since we don't need to have it automated (unlike nightly builds for example).

Setting up a new CI/CD pipeline for preview releases isn't a big deal, but we need to discuss the release strategy that we want. So I'm also leaning toward a manual build and publish.
Regarding which commit to take for the release: there is no reason not to choose the latest, but we also need to update the README.MD to reflect the API changes.

Defining a strict release strategy for previews is hard. I think we should just act spontaneous on those but with clear communication.

there is no reason not to choose the latest [commit]

Agree

but we also need to update the README.MD to reflect the API changes

We definitely cannot do that. The readme is what the people follow if they want to get started using the library. We tell them to use the (latest stable) nuget version, so the readme has to be according to that version. We should document the previewed changes but I think we should do so in the GitHub release. Other places I could see that is in a separate section in the readme (but I don't really like that) or in a  separate file. IMO the only thing we should mention in the readme is that there are previews available on nuget if the users want to try out the new features before they're released.

As you might've seen, 2.0.0-preview1 has been released and published to NuGet.
Should we close this issue?
Cc @mariusmuntean

Thanks a lot for the new nuget package, today I tried to update it, but then I came across 2 issues that might be of interest to others.
Firstly, now I see an exception when building my solution:
Error	TS18003	Build:No inputs were found in config file 'C:/Users/.../.nuget/packages/chartjs.blazor/2.0.0-preview1/contentFiles/any/netstandard2.1/tsbuild/release/tsconfig.json'. Specified 'include' paths were '["../../wwwroot/ts/*.ts"]' and 'exclude' paths were '[]'.
Secondly, it's not clear how to display a chart where bar and line charts can be displayed at the same time, with new Chart it is not possible any more. Old ChartJsBarChart did allow to do that.
Any insights how to fix that?

it's not clear how to display a chart where bar and line charts can be displayed at the same time, with new Chart<BarConfig> it is not possible any more. Old ChartJsBarChart did allow to do that.

Could you elaborate? The mixing aspect hasn't changed, in fact, it's been made easier with the datasets (but there's still issues). Can you show me the code that supposedly worked before but doesn't now?

Error TS18003 Build:No inputs were found in config file 'C:/Users/.../.nuget/packages/chartjs.blazor/2.0.0-preview1/contentFiles/any/netstandard2.1/tsbuild/release/tsconfig.json'. Specified 'include' paths were '["../../wwwroot/ts/*.ts"]' and 'exclude' paths were '[]'.

@mariusmuntean Could you please look into this? I'm assuming it has something to do with the recent update to the static assets (e.g. #130).

@Joelius300
The issue with datasets occurs on config.Data.Datasets.Add(lineDataSet);
Earlier it was possible to add LineDataset<ChartJs.Blazor.ChartJS.Common.Point>  there on the BarDatasetCollection,
in the last preRelease version only these methods are available : Add(IDataset<TimePoint> dataset),  Add(IDataset<FloatingBarPoint> dataset), Add(IDataset<int> dataset), Add(IDataset<long> dataset),  Add(IDataset<double> dataset) or do I am missing something?
@mariusmuntean
With the preview Version of the nuget package a new tsbuild-Folder is added to solution, there is a link to tsconfig.json, related to C:\Users....nuget\packages\chartjs.blazor\2.0.0-preview1\contentFiles\any\netstandard2.1\tsbuild\release\tsconfig.json, I think this causes the issue

Oh yea, I forgot I removed that. I disallowed adding point datasets to BarDatasetCollection because the bar chart doesn't understand those unless you specify a different type like line. The current solution with the dataset collections is nice when you exclude mixing scenarios like this but of course doesn't work for your use case. I will try to come up with a different solution for it.
Could you please open a new issue with a detailed explanation? I say "detailed".. you already did a good job in the last few comments but show us all the code, that's always helpful :)

Any update regards the error TS18003 described by @BorisGaliev ?
Does is it recommended to rollback to the latest stable version or is there any workaround (or fix)?

Sorry for the late response. I'm not well versed with typescript compilation and don't have time to look into it currently. @mariusmuntean is the contributor to do it but anyone else could too if they submit a PR.
Ps. Once I have more time, I might start to work on 2.0 again but lately most of my efforts have been devoted to other projects, outside of ChartJs.Blazor.

Hi I am experiencing the same issue  "No inputs were found in config file, @mariusmuntean any plan to look into it ?

It seems 2.0.0-preview1 NuGet package is in a pretty unusable state.
I needed to remove the line:
<files include="any/netstandard2.1/tsbuild/release/tsconfig.json" buildAction="Content" />

from c:\Users\XXX\.nuget\packages\chartjs.blazor\2.0.0-preview1\chartjs.blazor.nuspec to make it working.
BTW, example from the README is also outdated, it needs:
@using ChartJs.Blazor.Charts
@using ChartJs.Blazor.Util
@using ChartJs.Blazor.ChartJS.PieChart
@using ChartJs.Blazor.ChartJS.Common.Properties

and PieDataset is not generic anymore.
I'm not contributig any fixes as I'm totally not-Typescript developer and I;m in this project for 15 minutes so you will probably know better how to use this knowledge :)

It seems 2.0.0-preview1 NuGet package is in a pretty unusable state.

Indeed 😅 2.0 will be released very soon.

Hey, I just released version 2.0! Now in a more usable state than ever before :wink:
I encourage everyone to upgrade to 2.0. You can find a migration guide at the bottom of the release post.
This pre-release discussion was most relevant during the development of 2.0 so I'll close this issue now.


Feature Request: Else conditional support

Incremental-DOM appears to fully support if/else conditionals, but superviews.js at the moment only allows for if conditionals.

Yes - this is on the todo list.
I'm not sure how to approach it with attributes.

      description
      <input type="text" disabled="{data.isDisabled}">

    <if condition="data.showMe">
      I'm in an `if` block.
    </if>

Maybe implementing a switch-case block would be better?

I've found myself usually resorting to using the ternary conditional operator, which is a little messy, or handling the logic in the model, which can lead to models getting rather overpopulated with state booleans.  I'm not sure this is easily solvable with the available syntax though.
The nicest thing would probably be something akin to what Handlebars does, but I suspect that would require you to write your own parser, rather than relying on htmlparser2, which is probably out of scope for now.
If/Else blocks though do come up fairly frequently, and would probably be a fairly straightforward
<if condition="value">
  // true
<else>
  // false
</if>

A switch-case block would be interesting, although most use cases I've been able to think of result in a lot of duplicate HTML being used, and would be better written just using variables inside a single HTML block.

I think this could be achieved within htmlparser, I'll do some investigation.
Maybe even take it one step further:
<if condition="value">
  //
<elseif condition="foo">
  //
<elseif condition="bar">
  //
<else>
  // default
</if>

In the meantime, this ugliness is always an option:

foo

bar

07981b3028ba173d2560b16764573a6186f0bb43


#332 - branch v20230917 for client dev - draft diff for visibility only - do not merge

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


Request for listing badges and projectz

https://github.com/bevry/badges for html rendering and https://github.com/bevry/projectz for readme injection
been around for quite some time: https://github.com/bevry/badges/blob/master/HISTORY.md#v100-2015-september-16

Would you like to submit a pull request adding these to the readme?

Feel free to send a PR adding them, but I see no need to keep the issue open so going to close


Create Code of Conduct for this project

Something similar to Contributor Covenant, version 1.4:
https://www.contributor-covenant.org/version/1/4/code-of-conduct/
Or the latest version 2.1:
https://www.contributor-covenant.org/version/2/1/code_of_conduct/

Hey Adrian
I'd like to work on this issue.
Can you assign me the issue.

Welcome Himanshu, and thanks for the offer.


AMBARI-25374. Use host names instead ip addresses while checking hive interactive service status

Use host names instead ip addresses while checking hive interactive service status
(Please explain how this patch was tested. Ex: unit tests, manual tests)
unit
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5442/
Test FAILed.
Test FAILured.


foxit-reader: Copied from 'foxit-pdf-reader'

Closes #9629

Will be removed after scoop supports manifest alias feature.

[x] I have read the Contributing Guide.

out of date

@HUMORCE Why 'out of date'?

The foxit-pdf-reader could not be updated, nor this copied one.

/verify


Redux doc render a white page

Current behavior
The documentation on integration with redux doesn't load anymore.
In console there is this error message:
DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
Expected behavior
I want to see the documentation.
Reproduction
https://reactnavigation.org/docs/redux-integration
Platform

[ ] Android
[ ] iOS
[ ] Web
[ ] Windows
[ ] MacOS

Packages

[ ] @react-navigation/bottom-tabs
[ ] @react-navigation/drawer
[ ] @react-navigation/material-bottom-tabs
[ ] @react-navigation/material-top-tabs
[ ] @react-navigation/stack
[ ] @react-navigation/native-stack

Environment

package
version

@react-navigation/native

@react-navigation/bottom-tabs

@react-navigation/drawer

@react-navigation/material-bottom-tabs

@react-navigation/material-top-tabs

@react-navigation/stack

@react-navigation/native-stack

react-native-safe-area-context

react-native-screens

react-native-gesture-handler

react-native-reanimated

react-native-tab-view

react-native-pager-view

react-native

expo

node

npm or yarn

Me too.

Hey there!
we're fixed that issue :)


[radarr] added deployment annotations and bumped chart

Signed-off-by: Ryan Holt<EMAIL_ADDRESS>Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [radarr])

/nudge. :)


(issue-#24) enhancing performace avoiding defer unlocks

Signed-off-by: khushbuparakh<EMAIL_ADDRESS>I started from ReadAt, WriteAt functions.
So func (s *Server) had a defer func.
I avoided using that defer function
Then used at the very low level I/O code and
follow the path to know IO path in controller side, and,
similarly Handle() in rpc/server.go for replica side IO handling.

yeah! @payes fixing it

LGTM

Thanks @khushbuparakh for the PR. With the latest version of go there is significant improvement in performance with the use of defer as mentioned in this issue. So closing this PR


PyTeal Source Mapper

Please refer to the FAQ on the companion PyTeal PR

closing in favor of #217


⚠ Bofrost.be has degraded performance

In 99e3abc, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Bofrost.be performance has improved in 815cbb9.


ci: update actions

Summary of Changes
Updated various actions in CI/CD pipelines add more functionality and create a more robust and modern pipeline.

thank you for the contribution. could you open these upgrade separately so that we can revert things easily.

@yihau will do, and I'd like to learn how to open these upgrades separately

Also @yihau, these are just aimed to upgrade some of the actions and I think it can be seen from the files, so I didn't do something major


⚠ Blog博客 has degraded performance

In 5da0870, Blog博客 (https://blog.fangkehou.eu.org) experienced degraded performance:

HTTP code: 200
Response time: 14467 ms

Resolved: Blog博客 performance has improved in b9df835.


Fix for capture not working

This fix should clear up the problems Capistrano has with the latest ActiveSupport, as well as resolving any clashes with any arbitrary method defined on both Capistrano::Configuration and Kernel.

Thanks @siannopollo, I have a few things to merge, don't count on it today, but I'll ship a new release before the end of the working week.


Fix count() in ActiveQuery

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
https://github.com/yiisoft/yii2-mongodb/issues/173

Resolved by commit d7cfcf42f49928e6b480965069c213853f03e363


JS ContentIterator sample and collection not initialized error

Which PnP repository to report the issue?

PnP Samples - https://github.com/OfficeDev/PnP

Category
[ ] Bug
Environment
[ ] SharePoint 2013
Observed Behavior
Intermittent error "Uncaught Error: The collection has not been initialized. It has not been requested or the request has not been executed. It may need to be explicitly requested." is being thrown when calling getEnumerator on list collection.  Works most of the times, occasionally throws this error.
I'm pretty sure this is a scoping issue within the SharePointClient.js code - have tried several things with no luck.
Steps to Reproduce
-Use content iterator sample with following code -
//Use 'ContentIterator' from https://github.com/OfficeDev/PnP/tree/master/Samples/Core.ListViewThreshold.JSOMAndREST/Core.ListViewThreshold.JSOMAndREST to work around view theshold
SharePointClient.Services.JSOM.Initialize(function() {
                updatestatus('Loading complaints...');

                var listTitle = 'xxx';

                var listServices = new SharePointClient.Services.JSOM.ListServices();
                var context = new SharePointClient.Services.JSOM.Context();
                var viewfields = getViewVieldXML(field);

                var camlConstant = SharePointClient.Constants.CAML_CONSTANT;
                var camlQuery = new SharePointClient.CamlExtension.JSOM.CamlQuery();

                //note then query does not filter out non complaint records, we do this in the code when the results come back. when adding in a second where, the view threshold was being breached
                camlQuery.ViewAttribute(camlConstant.CAML_QUERY_SCOPE.RECURSIVE_ALL)
                    .Query('<Where><Geq><FieldRef Name=\"Date_x0020_Of_x0020_Receipt\" /><Value Type=\"DateTime\" IncludeTimeValue=\"TRUE\" StorageTZ=\"TRUE\">' + fiscalYearFrom + '-04-01T00:00:00</Value></Geq></Where>')
                    .ViewFieldsXml(viewfields)
                    .QueryThrottleMode(camlConstant.CAML_QUERY_THROTTLE_MODE.OVERRIDE)
                    .OrderByIndex()
                    .RowLimit(5000);

                listServices.GetListItemsBatchByListName(context, listTitle, camlQuery.BuildQuery()).Execute(function(result) {

                    $log.debug('Got dataset, mapping items...');

                    var listItemEnumerator = result.getEnumerator();

		//logic here
                });

            });

I should mention, this code is being called from an Angular controlled on a custom aspx page.  Looking at the network tab I saw a request to sp.core.js after my first processquery request.  My thoughts are that sp.core.js was doing some queries too and overwritting the response of mine.
Adding ExecuteOrDelayUntilScriptLoaded(loadComplaints, 'sp.core.js'); resolved this, so no issue in the library.


DWR for AU

@jess-shue The FF gives an option for dead with resprout when tree is AU. If DWR is selected when the tree is AU, it produces an error. Would it be possible to remove the DWR option from A and AU trees to ensure this error doesn't happen accidentally?

@emacmonigle DWR should no longer show if A or AU is selected - now on Version 16. I have to be careful when setting these rules, as sometimes they cancel one another out in some way and errors in functionality occur. Hopefully, we're close to having things set for you!

@jess-shue thank you for that update! Should be helpful since the A/AU with DWR error is not stated in the protocol, so this can help future surveyors not create these errors.
If there's any request to the FFF that I make that is causing too many errors or would cancel something out, then no worries. Please let me know so I can make a note on the protocol so that the instructions for future surveys will prevent errors from the start.


syncing over a header that's already been synced fails out for bridge nodes due to shard already exists

2023-02-20T15:36:38.301+0100	ERROR	header/sync	sync/sync.go:214	syncing headers	{"from": 1025, "to": 25337, "err": "failed to initiate shard registration: 908B3B93B13FE69A682915F5E66B234BB7A95D7C34700110698BC620894529D6: shard already exists"}

This is failing because bridge node is trying to sync over a header that is already synced -- and since bridges extend and put during sync process, this error pops up and prevents further syncing.

The root cause: if our syncing process fails for some reason somewhere in the middle, then our syncer will not have the latest header but the eds store will.

Duplicate of https://github.com/celestiaorg/celestia-node/issues/1785


[WIP] update for raspios 64 bit

Thanks. Note that there are "official" arm64 builds of tezos so it may not be necessary to compile: https://github.com/serokell/tezos-packaging#raspberry


Revert "fix: Updating ibm-cloud-sdk-core npm package version to fix vulnerability"

Reverts IBM/networking-node-sdk#136 reverting this PR as the integration tests are failing

@srukotla hi
the PR you merged is not deploying the build. The UTs are failing.
I had a PR out there to fix the porblem https://github.com/IBM/networking-node-sdk/pull/135 but was waiting for others to review.
you're going to have to pull out the changes.
As you can  here- https://github.com/IBM/networking-node-sdk/runs/29265188706 they're failing.


Global module import for multi root workspace

Hello,
I have read through several issues and didn't find an answer or resolved what is or should be correct behaviour for this case.
We have a multi-root workspace with several folders defined in .code-workspace (fld1, fld2) settings and one third party folder which contains modules.
root/xyz/fld1/file.py
root/uvw/fld2/file.py
root/3rd/module

Having settings with python.analysis.extraPaths: ["3rd/module"] resolves into a separate 'search path' for each workspace folder instead of for the root workspace as I would have expected.
Environment data

Language Server version: 2021.6.1
OS and version: Windows 10.0.19043
Python version (& distribution if applicable, e.g. Anaconda): 3.9

Expected behaviour
Search paths passed to pylance:
fld1/
/3rd/module

The path from extraPaths is absolute to the workspace and is not dependent on the workspace folder path, where the currently edited python file lies.
Actual behaviour
Search paths passed to pylance:
fld1/
fld1/3rd/module

The /3rd/module path is appended to the fld1 or fld2 path depending on the place where the python file is edited.
I would expect using python.analysis.extraPaths: ["./3rd/module"] is going to result in this behaviour instead, but it works the same.

I think then that's my misunderstanding of how VSCode workspaces work. I expected that there is a root workspace containing some other workspaces, define in the .code-workspace, isn't that the case? Isn't there an ability to have 'root workspace' settings applied for every workspace the same way and then relative settings in the sub-workspaces?
Using settings individually is for sure possible, but I don't think that it scales well with our approach. Adding one library results in adding multiple paths at multiple roots.

VS Code configuration is layered; when you query it, you get the setting for the specific workspace, then if not present, the setting from code-workspace, then if not present, the user configuration. From the querier's point of view, you're just getting a value back. Language servers get that final merged information and have no idea that the setting was set it one place versus another and that maybe the intent was for it to be relative to some other locations.
There are things we can do to try and ask VS Code for the raw settings at each layer, but this is sort of leaving the realm of the way that VS Code settings and the LSP were designed.

Seems that my expectations are against the design of VSCode. Thanks for the explanation.


Badge Request: GitLab tags and releases

Similar to GitHub badges, it would be nice to have GitLab badges for tags and releases as well. Both tags and releases are available for public repos from the GitLab API without authentication, examples:
curl -v 'https://gitlab.com/api/v4/projects/gitlab-org%2fgitlab-foss/repository/tags'
curl -v 'https://gitlab.com/api/v4/projects/gitlab-org%2fgitlab-foss/releases'

(I might have a go later this year, right now I'm a little overbooked due to COVID-19.)

Thanks for offering to work on this.
It has been a while since anyone looked at GitLab badges, but I think one of the issues we hit in the past was the rate limits on the API. You've noted that a token is not required to access these endpoints for public repos, but presumably there are rate limits on anonymous access?
Probably a good start would be to have a read over https://github.com/badges/shields/issues/541 to understand that history.
The reason we are able to provide badges for GitLab CI pipelines is because we can get the info for them without hitting their API.

@chris48s Two quick thoughts:

A few days ago, gitlab.com has switched to Cloudflare which could have a positive impact on rate limits. Haven't checked this though.
For self-hosted GitLab, possible rate limits should be ignored. Either the server admins lift them or the repo users don't used the badges. Either way, admins and users often are part of the same organisation.

I've started by creating a gitlab-tag service with GitLab tag (latest by date). This is the one I'm most interested in, but I'll get around to implementing the rest of them soon.

Tag support went live earlier today, with the standard by-date/semver and pre-release filters as other similar badges. Release support should get added via #7021 in the hopefully not too distant future


Subscriptions are not allowed error

Hi,
I'm just getting started with using graphene-subscriptions in my project that has successfully used queries and mutations before. Hence trying out this implementation.
In setting up the 'Hello world' subscription as described in the README, I am getting the following error:
{
  "errors": [
    {
      "message": "Subscriptions are not allowed. You will need to either use the subscribe function or pass allow_subscriptions=True"
    }
  ],
  "data": null
}

Turning on the Django (server-side) logging for requests, I see this output:
 2020-12-19 04:20:48,343 DEBUG daphne.http_protocol HTTP b'POST' request for ['<IP_ADDRESS>', 46226]
 2020-12-19 04:20:48,344 INFO django.request ^[[36mPOST /graphql/^[[0m
 2020-12-19 04:20:48,344 INFO django.request ^[[36mPOST /graphql/^[[0m
 2020-12-19 04:20:48,345 DEBUG django.request ^[[36m{'HTTP_X_REAL_IP': '<IP_ADDRESS>', 'HTTP_X_FORWARDED_FOR': '<IP_ADDRESS>', 'HTTP_HOST': '<IP_ADDRESS>:8000', 'HTTP_CONNECTION': 'close', 'HTTP_USER_AGENT': 'insomnia/2020.5.2', 'HTTP_AUTHORIZATION': '*****', 'HTTP_ACCEPT': '*/*', 'HTTP_COOKIE': 'csrftoken=YNHNgrX8bfquuNhZe8UfISxj8kCj7plKGWqVPwfuvWGRqtio1m6NEN5zfA9pgTvd'}^[[0m
 2020-12-19 04:20:48,345 DEBUG django.request ^[[36m{'HTTP_X_REAL_IP': '<IP_ADDRESS>', 'HTTP_X_FORWARDED_FOR': '<IP_ADDRESS>', 'HTTP_HOST': '<IP_ADDRESS>:8000', 'HTTP_CONNECTION': 'close', 'HTTP_USER_AGENT': 'insomnia/2020.5.2', 'HTTP_AUTHORIZATION': '*****', 'HTTP_ACCEPT': '*/*', 'HTTP_COOKIE': 'csrftoken=YNHNgrX8bfquuNhZe8UfISxj8kCj7plKGWqVPwfuvWGRqtio1m6NEN5zfA9pgTvd'}^[[0m
 2020-12-19 04:20:48,345 DEBUG django.request ^[[36mb'{"query":"subscription {\\n  hello\\n}"}'^[[0m
 2020-12-19 04:20:48,345 DEBUG django.request ^[[36mb'{"query":"subscription {\\n  hello\\n}"}'^[[0m
 2020-12-19 04:20:48,354 DEBUG django.db.backends (0.003) SELECT "auth_user"."id", "auth_user"."password", "auth_user"."last_login", "auth_user"."is_superuser", "auth_user"."username", "auth_user"."first_name", "auth_user"."last_name", "auth_user"."email", "auth_user"."is_staff", "auth_user"."is_active", "auth_user"."date_joined" FROM "auth_user" WHERE "auth_user"."username" = 'sysadmin'; args=('sysadmin',)
 2020-12-19 04:20:48,354 DEBUG django.db.backends (0.003) SELECT "auth_user"."id", "auth_user"."password", "auth_user"."last_login", "auth_user"."is_superuser", "auth_user"."username", "auth_user"."first_name", "auth_user"."last_name", "auth_user"."email", "auth_user"."is_staff", "auth_user"."is_active", "auth_user"."date_joined" FROM "auth_user" WHERE "auth_user"."username" = 'sysadmin'; args=('sysadmin',)
 2020-12-19 04:20:48,363 INFO django.request ^[[36mPOST /graphql/ - 200^[[0m
 2020-12-19 04:20:48,363 INFO django.request ^[[36mPOST /graphql/ - 200^[[0m
 2020-12-19 04:20:48,364 DEBUG django.request ^[[36m{'content-type': ('Content-Type', 'application/json'), 'vary': ('Vary', 'Cookie, Authorization'), 'x-frame-options': ('X-Frame-Options', 'SAMEORIGIN')}^[[0m
 2020-12-19 04:20:48,364 DEBUG django.request ^[[36m{'content-type': ('Content-Type', 'application/json'), 'vary': ('Vary', 'Cookie, Authorization'), 'x-frame-options': ('X-Frame-Options', 'SAMEORIGIN')}^[[0m
 2020-12-19 04:20:48,364 DEBUG django.request ^[[36mb'{**"errors":[{"message":"Subscriptions are not allowed. You will need to either use the subscribe function or pass allow_subscriptions=True"}],**"data":null}'^[[0m
 2020-12-19 04:20:48,364 DEBUG django.request ^[[36mb'{**"errors":[{"message":"Subscriptions are not allowed. You will need to either use the subscribe function or pass allow_subscriptions=True"}**],"data":null}'^[[0m
 2020-12-19 04:20:48,365 DEBUG daphne.http_protocol HTTP 200 response started for ['<IP_ADDRESS>', 46226]
 2020-12-19 04:20:48,366 DEBUG daphne.http_protocol HTTP close for ['<IP_ADDRESS>', 46226]

which confirms the client-side reported error.
Now, I realize that this is likely not a bug, since others have been able to get past this very early point. So, something in my setup. I have followed all steps in the README file and have verified each step multiple times.
Other details: Django version 2.2.17, channels: 2.3.0, graphene-django: 2.13.0.
Don't know what else to provide. Please ask away for additional details.
Thanks for the great work, BTW. The implementation is very intuitive and hides/exposes the right-level of detail.

I was able to get past this point and get the Hello World subscription working by following steps found on StackOverFlow to create a custom Graphql view and backend and wiring them to the /graphql end point.


Load text into yaml command

to be implemented in dcore:
load_text option in the yaml command for easily parsing api responses or other generic json text

This has no relation to Denizen-Core


Update add-chain script to support chains with fault proofs

Currently the add-chain go module expects a single, rigid list of contract names/addresses in the monorepo/deployments/.deploy input file. Chains with fault proofs will have a different set of contracts: L2OO will be absent and others (e.g. Dispute Game Factory) will be present. The add-chain script should support these types of chains in addition to chains without fault proofs. The add-chain/e2e_test.go setup will need to be modified to test multiple types of chains and input formats.
Reference for a chain with fault proofs: link
Additional Context

Github thread

@bitwiseguy @geoknee ok to close this one?

No we want this one to stay open.


Fix usage documentation

--blueprint is deprecated. So, changed it to --blueprints in usage documentation.

Please make sure the below checklist is followed for Pull Requests.

[ ] All continuous integration tests are green

[ ] Tests are added where necessary

[ ] Documentation is added/updated where necessary

[ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@A-5ingh : thanks :)


[BUG] Args are not passed through as is by default

I discover that args are not "passed through as is by default", as mentioned in the documentation.
By documentation I mean at least what we can read when executing shmake -h.
In fact you need to explicitly ask for it on the command line by specifying -a %s.
This is due to the fact that without being explicit, shmake.exe inject an empty string in the IDS_ARGS resource of shim.exe, and shim.exe pass args only if that resource contains %s somewhere.
I don’t know if we should fix the documentation, or shim.exe or shmake.exe or a bit of the two exe.
And I’m not sure to have more time to invest here since I’ve got a workaround.
But at least it‘s now traced by that issue.

Thanks for pointing this out! :+1:  Indeed, if the user haven't explicitly specified -a %s on the command line, the generated shim doesn't forward any arguments to the target executable.
I noticed your pull request #8 actually tries to fix two different bugs: one with argument passthrough, and another one with spaces in paths. Let's deal with them separately in order to keep things organized. I've created a new PR #9 that fixes the particular issue with argument passthrough - and only it. Proper handling of spaces in paths is discussed separately in #10 and resolved in #11.