Set up 10 new Linux hosts in the try pool and connect mokey devices to them

The version of Linux should be the same as on the other Linux hosts in the lab.

Hey @kentnguyen99, it looks like the corp dns ticket was resolved. Please let me know if there's anything else I need to do to move this along.

@zanderso, We still have another issue that all machines in the Device lab could not connecting to Salt master after network changed last week. There is a ticket opened and being working on by Network teams. https://gutsv3.corp.google.com/#ticket/228663253

@zanderso All new 10 Linux Bots are online and ready for production.
Hostname:
flutter-devicelab-linux-64.mtv.corp.google.com
flutter-devicelab-linux-65.mtv.corp.google.com
flutter-devicelab-linux-66.mtv.corp.google.com
flutter-devicelab-linux-67.mtv.corp.google.com
flutter-devicelab-linux-68.mtv.corp.google.com
flutter-devicelab-linux-69.mtv.corp.google.com
flutter-devicelab-linux-70.mtv.corp.google.com
flutter-devicelab-linux-71.mtv.corp.google.com
flutter-devicelab-linux-72.mtv.corp.google.com
flutter-devicelab-linux-73.mtv.corp.google.com

Thanks!

All ten new Linux Bots are online and have been rolled out production, ticket completed and closed.


UI: New pages for global and personal settings

Redesign of abapGit settings using HTML forms. Two functional changes to old settings page:

"Development Internal Settings" are only visible when using the developer version (not in standalone program)
"User-specific hotkey settings" are not available anymore. The default hotkeys continue to work as before.

Global Settings:

(in Dev Version):

Personal Settings:

Note: Using  required some small adjustments to HTML forms and HTML rendering since the innerHTML representing the value of the  field must not be indented.

Changed from drop-down menu to using a top menu bar for switching between "global" and "personal" settings:

thanks 👍

https://github.com/abapGit/abapGit/blob/56bd2b1b133ae4b526cb21c56f72615f5fea3127/src/ui/zcl_abapgit_gui_page_sett_glob.clas.abap#L259
This line breaks wildcards in proxy bypass lines. What was wrong with the popup that I put in there?
I think there should be a check for wildcards or the value should be enclosed in * and option CP should be used.

@thedoginthewok we are replacing all GUI popups step-by-step with HTML pages/forms in order to eventually support a pure web version.

Ah, that makes sense! I guess this might have something to do with cloud-based systems?

yes, https://github.com/abapGit/web_edition


Add instructions to install on mageia 8

I make a changes to README.md to add instructions to install on mageia 8
I hope all is right , i am beginner on this
README.md

sorry wrong fork


Security: JS injection issue in petition page

it is possible to inject JavaScript into the petition content in the petition page.
That could be used to steal the identification cookie for instance.
see : https://pytitiondemo.sionneau.net/petition/user/JeanMichelApathie/my-petition

It seems no longer possible to inject trivially JS.
I will mark this as fixed for v2.0 but I will open another ticket for CSP (Content Security Policy) integration as security obviously needs to be improved as a process.


Lock terminal scrolling

Is there a function which prevents one from scrolling outside the application? As it is still possible to use the terminal scrollbar to scroll up.
Or is this rather a question for the termion issues?

Are you encountering the same issue as #8 or is it a different behavior ? Using the MouseBackend from the termion backend should capture mouse events and thus remove the ability to scroll.

@fdehau its still possible - not with the scroll wheel but using the terminals own scrollbar - nano doesnt have this behavious Ill be looking that ones source code, maybe Ill be able to find something.

Then I think, you may need to use the AlternateScreenBackend. From my understanding, it disable the scroll back buffer and restore it when the application exits.

@fdehau Yes that works :D


which state vector of multiple Speller layers is suggested to be used for attention calculation

Hi there,
I can tell from your code that you applied the state vector at the first layer of Speller to calculate attention score.
https://github.com/Alexander-H-Liu/End-to-end-ASR-Pytorch/blob/55d39528b27b18249d1e9a084d7ac2516bfcd562/src/asr.py#L86
Did you compare it with other possible manipulations, such as

The state vector at the last layer of Speller?
The concatenation of all state vectors from all layers?

I am interested in the advice of optimal solutions. Original LAS paper did not mention which one is the best.
Thanks
Xuesong

Hi,
I've never tried them but I think it's all reasonable way to implement attention and most papers/implementations (I've read so far) are using the first layer.

Thanks man.


Unable to communicate with JSX parser.

Running MVC6 project, and trying to create .jsx file. But receiving message
"JSX Parser: Unable to communicate with JSX Parser".
I found no answers in Google. Someone have this problem too?

I am having this problem too.. but I think this only affect the syntax highlighting...

This is part of Visual Studio or one of its extensions, not ReactJS.NET. You'll need to report it as a bug to Microsoft :)

@Daniel15 Not sure this is coincidence or not, but when I downgraded to ReactJS.NET 2.1 it works!.. the syntax highlighting works and there is no more "JSX Parser: Unable to communicate with JSX Parser" error..

That's really odd... The version of ReactJS.NET shouldn't affect the JSX parser in Visual Studio :confused:

I believe this is caused by the use of Babel in version 2.0 of ReactJs.net.
See solutions here: https://stackoverflow.com/questions/34097915/visual-studio-2015-jsx-es2015-syntax-highlighting


Why specify podAffinity for slaves?

Hey there,
I'm pretty new to Kube and I'm using your charts as a jumping-off point to build my own. I was wondering why you've got the slaves specifying a podAffinity to the master with topologyKey: "kubernetes.io/hostname"? If my understanding of that is correct this ensures that all slaves are scheduled onto the same host as the master. This seems like a major oversight: It's not a distributed system if everything is running on a single host. And if you've got a 4-core host but you're running 10 slaves then all 10 slaves are sharing those 4 cores.
Thanks for sharing this, it's helped me get up and running quickly :)

@JDiPierro Thank you for your kind comment 😃I'm sorry about the late answer!
You are right, this was a temporarily fix to make sure the master was running before slaves were scheduled. There was an issue where slaves would not register properly if they started before the master and this was a "hack" to make control the order of deployment.
I'll update the template to get rid of the podAffinity!
Thanks!


feat: Feature/opentel

Description
Adds in support for Open Telemetry as an exporter
Changes include

[+] New feature (non-breaking change that adds functionality)

Closes issue(s)
https://github.com/thomaspoignant/go-feature-flag/issues/1375
Checklist

[+] I have tested this code
[+] I have added unit test to cover this code
[ ] I have updated the documentation (README.md and /website/docs)
[ ] I have followed the contributing guide

@thomaspoignant Can you let me know what you think of this?
Some of the more interesting spots.

I added in a dependency on testcontainers-go so that I could test out hooking into an otel collector
I wanted to use the default in memory exporter for testing, but it didn't do what I needed. I'm not sure how to handle that for this project license wise. I could get rid of the copy-paste and wrap the default one and only change the method I need.
Since the Value on FeatureEvent is an interface it was a bit tricky to get in as a set of attributes. I had to make some design decisions on how to do that.

There is some issue with tc running in GHA. I opened an issue about it - https://github.com/testcontainers/testcontainers-go/issues/2507

I am sorry to be slow on the review. I will do it very soon.

I am sorry to be slow on the review. I will do it very soon.

No problem. Life exists outside github!

@thomaspoignant Anything else on this? I'm going on holiday and am closing out my open pr's

Sorry I had no time to test it properly.
But don't worry we can look at it after your vacation.


论文中table10结果

我用您的代码，最好的结果是multivariate_forecasting，其中traffic跑出的结果（在历史窗口和预测窗口都为96的情况下）MSE：0.4173510670661926，MAE：0.28778335452079773，与您论文中的结果似乎还是有差距

Hi, thanks for your usage! According to the provided codebase and script, the reproduced result will be better than those reported in our paper:

I think one potential question is the experimental environment. Please try this configuration: PYTORCH2.0.0 CUDA11.2
If you have further questions, please refer to the checkpoint we provide here: https://cloud.tsinghua.edu.cn/f/dd6ec819d91c4c9889b8/?dl=1


robot_model: 1.12.9-0 in 'lunar/distribution.yaml' [bloom]

Increasing version of package(s) in repository robot_model to 1.12.9-0:

upstream repository: https://github.com/ros/robot_model.git
release repository: https://github.com/ros-gbp/robot_model-release.git
distro file: lunar/distribution.yaml
bloom version: 0.5.26
previous version for package: 1.12.8-2

collada_parser

No changes

collada_urdf

No changes

joint_state_publisher

No changes

kdl_parser

No changes

kdl_parser_py
* Unset origin xyz or rpy is now properly interpreted as zero vector (#187 <https://github.com/ros/robot_model/issues/187>)
* Contributors: eugene-katsevman

robot_model
* Adds deprecation message to robot_model package.xml (#196 <https://github.com/ros/robot_model/issues/196>)
* Contributors: Shane Loretz

urdf

No changes

urdf_parser_plugin

No changes

Ooops, forgot to change the status. Closing


.sass-cache isn't being ignored

I think you missed this one:

Hey @alfredoreduarte it looks like .sass-cache is already in .gitignore. Are you sure that wasn't generated after running a build?


Comments

Is it possible to download comments using ytcog-dl? Existing ones (forget the name) take more time to scrape the comments that it take to download a video.

Not yet. But coming soon.
I don't know how the performance will be.  It will have to make multiple requests for each batch of comments. So if there are many thousands of comments on a video it could some time.  You can't make parallel multiple requests to speed it up, either, because each request returns a continuation code, which is needed in order to make next request, and so on until completed.

Comments have now been added to ytcog.  Not yet implemented in ytcog-dl.


feat(canvas): demoed centroid and incenter

I demoed how to draw incenter and centroid with Canvas element.

OK

fine


perf/refactor: use PollSender for ActiveSession messages

Describe the feature
to apply backpressure, we store the latest message if the channel is currently at capacity
https://github.com/paradigmxyz/reth/blob/2436e019c68e10ce384989a6d19e74dc840ba3c3/crates/net/network/src/session/active.rs#L80-L81
and only continue if we can make progress:
https://github.com/paradigmxyz/reth/blob/2436e019c68e10ce384989a6d19e74dc840ba3c3/crates/net/network/src/session/active.rs#L543-L546
waking the tasking is essentially a busy loop until there's capacity again, which is suboptimal.
there's a util type for this:
https://docs.rs/tokio-util/0.7.8/tokio_util/sync/struct.PollSender.html
using PollSender would require some refactoring effort because currently, we rely on .clone().try_send to always deliver a critical message, which I guess is susceptible to a race condition where the new slot that clone creates is immediately occupied by another message from another task.
TODO

integrate PollSender in ActiveSession

Additional context
No response

I will fix this.

Do we want PollSender implemented in other sender than the MetricSender which is used by the ActiveSession?
Further, PollSender doesn't error except on a closed connection. Do we increment send_errors if the channel is full (but no error is returned)?

I've been looking at this; since a failed send due to backpressure does not result in an error when using tokio_utils::sync::PollSender, should the MetricSender still count an error?


Add linkinize extension

Description
Linkinize Raycast extension brings Linkinize integration right into your screen. quickly search and access your Linkinize bookmarks with power of Raycast
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

The login system feels a bit overengineered to me, maybe it's easier just to try with the current cached token, and if there is an error unset it and give the user a failure toast

@pernielsentikaer do you mean getting rid of the AuthComponent that displays the login issue completely? I'm afraid some users do not know how to set their credentials in the preferences.


Can i use to extract tiles from google ?

Hello!
Great Thanks for your work!!!
I tried and it worked successfully.

I'd like that you let me know if i can use the script to extract tiles from google maps. I'm making some works on google maps tiles to extract buildings of my country.

I'd like also that you let me know if we can extract type of buildings, or how can we do to have different buildings.

Thank you in advance!

Hey @JKKoffi while extracting satellite imagery is technically possible, it is unfortunately a violation of the google terms of service. You would need to contact their maps team to get permission to use the tiles and an appropriate API to pull them from.

Thanks @ingalls ingalls for these details. I learned also this.
But, using label-marker , is it possible to identify the type of buildings , or have a category of buildings?

@JKKoffi Not sure I follow what you are asking? Are you asking if Label-Maker will automatically classify buildings for you? Or if you can set it up so that a human user can select between classifications

Let me explain you @ingalls, i want to discriminate each building. Is label-marker willing to do it ?

But why the tiles from the country that i gave the coordinates in the bounding box are too much poor quality ? The coordinate i used are below: -4.03410418,5.31133473,-4.00415346,5.34186832. The zoom level is 18.


Rename ResourceMapper to Partitioner

Metrics and tests have shown that ClusterHashRing does not uniformly distribute resources to cluster members when the resource to cluster size ratio is low.
Inspired by the Kafka client, I would like to add alternative ways to assign resources to cluster members that are more suitable for event consumers.

AbstractPartitionAssignor
RoundRobinAssignor
RangeAssignor

I was going to add a RoundRobinResourceMapper or  aRangeResourceMapper.
This made me wonder if what ResourceMapper essentially does is partitioning resources to cluster members, would Partitioner or PartitionStrategy be a better name?

can you provide some context in the commit message? why is this a better name?

My recollection of the investigation so far is that we are unsure of the current hash ring algorithm is correct. There might be bugs. There have been bugs. Can we prove that it's a flaw of the algorithm and not a bug before moving on to alternate algorithms?

why don't we first rollout new impl of ClusterResourceMapper and prove out your theory. Also IMO ClusterResourceMapper is a pretty generic and easy to understand name. You would just provide a new impl ClusterRangeAssigner


changed PolygonPathFinder::get_closest_point to return the closest posit...

...ion inside, rather then the closest vertex.
This seems to be of much more practical use than returning the closest vertex.  Perhaps two different functions would be appropriate, one for each interpretation of "closest point".

asking punto what he thinks, since he is using this more than I do


Matrix

Inside matrix class do not write T(0) and T(1) for matrixes but zero() and one()
For example Matrix<MaxPlus, 2u, 2u>: T = MaxPlus and zero<MaxPlus>() = -inf and one<MaxPlus>() = 0.0

Fixed in f4b2a4499b5eb9bc6712bca5fba9e448302e4351


Doesn't have example of adding Redis to DI container

I looked everywhere on how to set up Redis, and the only mention of this is:
"An app configures the cache implementation using a RedisCache instance (AddStackExchangeRedisCache)."
Does that mean?
services.AddStackExchangeRedisCache(options => { });
Why not have that as an example instead, as all other MS documentation does for configuring the services?
It is absolutely misleading to talk about some RedisCache instance, in case that is what it is trying to convey. What 'RedisCache' instance does it talk about? It mentions AddStackExchangeRedisCache but doesn't say what class it is in. Are we supposed to magically guess where things are?
So I think services.AddStackExchangeRedisCache(options => { }); should be added. The page contains examples for the other cache providers,
services.AddDistributedSqlServerCache(options => ...
services.AddNCacheDistributedCache(configuration => ...

so why not for Redis?
Furthermore -- AddStackExchangeRedisCache doesn't seem to be documented anywhere. What options are mandatory? Does it work like other Azure services, such as Azure SignalR Service, that if no connection string is specified it will use the appropriate app service string/app setting automatically ("CacheConnection" in this case)? Or does it need to be set somewhere?
Documentation is supposed to tell these things. I shouldn't have to play detective to set something up as simple as this.
See https://docs.microsoft.com/en-us/azure/azure-signalr/signalr-quickstart-dotnet-core#add-azure-signalr-to-the-web-app for how other services document this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d01025d-86b2-bb2d-86c1-ef0695bc98e3
Version Independent ID: 5b9a6572-3671-0d54-b2ef-83d04f8b3e96
Content: Distributed caching in ASP.NET Core
Content Source: aspnetcore/performance/caching/distributed.md
Product: aspnet-core
Technology: aspnetcore-performance
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

See https://docs.microsoft.com/en-us/azure/azure-cache-for-redis/cache-dotnet-core-quickstart

See https://docs.microsoft.com/en-us/azure/azure-cache-for-redis/cache-dotnet-core-quickstart

Hi Rick and thanks for the answer. I can’t see AddStackExchangeRedisCache being mentioned at all in the document you linked to, nor the mandatory parameters in it. Maybe I’m just missing it?

@petrsvihlik can you provide the code to use Azure Redis cache?  Something like
 services.AddStackExchangeRedisCache(options =>
            {
                options.Configuration = <MyEndpoint>;
                options.InstanceName = "MyInstance";
            });

@Rick-Anderson yeah, here are the steps I've just taken to make it work with Azure Redis:

Spin up the Azure Cache for Redis
Navigate to the resource's Access Keys

Copy the connection string for StackExchange.Redis
Configure the Startup class as follows:

🎉🎈 It works!

PS: sorry for the delayed answer, we just had a baby so I'm quite busy :)

@petrsvihlik  Congratulations on the new baby. Thanks for this info, I'll get the doc updated.

@petrsvihlik  I can't have an example of copy/paste PW into code. How do you recommend I get the config? I could have them copy/paste into the environment and access that way.

@Rick-Anderson definitely. On a local machine, I'd go with User Secrets and anywhere else either Environment Variables or a Key Vault. So the env variables seem to be the easiest way to demonstrate the usage while not going against the best practices.


How to request for all data from a given provider?

Ask your question
I'm trying to use the google provider currently. It seems that by default nuxt auth is only requesting for the name, email, and image of the google account. How can I set it so that it requests all available information such as first name, last name, display name, etc..?
Additional information
No response

Nextauth mentions a scope parameter in the options but can someone tell me how to use it in nuxt auth?


Discarded invalid value for parameter 'sentry.interfaces.Message'

On-premise installation of Sentry 8.10.0 reports this error on every event submitted by Sentry/PHP 1.6.1

Discarded invalid value for parameter 'sentry.interfaces.Message'

{
  "name": "sentry.interfaces.Message",
  "value": {
    "message": {},
    "params": [],
    "formatted": {}
  }
}

I guess this could be because 'formatted' attribute is not part of the interface.

How are you generating this? It's invalid because message and formatted
must be strings.
On Dec 22, 2016 7:36 AM, "Sergey Tsivin"<EMAIL_ADDRESS>wrote:

On-premise installation of Sentry 8.10.0 reports this error on every event
submitted by Sentry/PHP 1.6.1
Discarded invalid value for parameter 'sentry.interfaces.Message'
{
"name": "sentry.interfaces.Message",
"value": {
"message": {},
"params": [],
"formatted": {}
}
}
I guess this could be because 'formatted' attribute is not part of the
interface https://docs.sentry.io/clientdev/interfaces/message/.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/getsentry/sentry-php/issues/394, or mute the thread
https://github.com/notifications/unsubscribe-auth/AABcOsGuIwvEXjlqK0kXxhTaB8jOvWS-ks5rKpjwgaJpZM4LUF7o
.

Closing this until we confirm its an issue internally.

Sorry, I confirm that this is not a bug with Raven_Client but rather wrong parameters being passed to captureMessage method. I use the yii2-sentry-log log target to report errors via Yii2's built-in logger, and the problem appears to be on that side.


feat: update to use azd for deployment

Update the doc to use azd for deployment

Remove deploy.sh
Update readme file to use azd and delete shell scripts part
Consolidate bicep file to only main.bicep + deploy.bicep, removed abbreviation
Other minor enhancement

@pmalarme , we can only define one scope in a bicep file.
In main.bicep we use scope subscription to create a resource group, and in deploy.bicep we use scope resourceGroup to create Azure resources under that resource group. Note, if we merge the content from deploy.bicep into main.bicep, we need add the rg scope for all the Azure resources. So here, I just use two bicep files to align the parent-child resource hierarchy.
What do you think?


CI jobs: validate-release-job failing with 'no space left on device'

Description

It seems we are now facing a new problem with one of our CI jobs validate-release-job throwing errors caused by a lack of space on the device.
When I run df -h on the runner, I got the following results:
Filesystem      Size  Used Avail Use% Mounted on
overlay          84G   71G   14G  85% /
tmpfs            64M     0   64M   0% /dev
shm              64M     0   64M   0% /dev/shm
/dev/root        84G   71G   14G  85% /__t
tmpfs           1.4G  1.2M  1.4G   1% /run/docker.sock
tmpfs           3.4G     0  3.4G   0% /proc/acpi
tmpfs           3.4G     0  3.4G   0% /proc/scsi
tmpfs           3.4G     0  3.4G   0% /sys/firmware

Version

main

I can see once goreleaser runs it fills up the whole overlay available space 😱 1
**overlay          84G   83G  737M 100% /**
tmpfs            [6](https://github.com/sigstore/cosign/actions/runs/5726129049/job/15515969205?pr=3150#step:7:7)4M     0   64M   0% /dev
shm              64M     0   64M   0% /dev/shm
/dev/root        84G   83G  [7](https://github.com/sigstore/cosign/actions/runs/5726129049/job/15515969205?pr=3150#step:7:8)37M 100% /__w
tmpfs           1.4G  1.2M  1.4G   1% /run/docker.sock
tmpfs           3.4G     0  3.4G   0% /proc/acpi
tmpfs           3.4G     0  3.4G   0% /proc/scsi
tmpfs           3.4G     0  3.4G   0% /sys/firmware

It seems to only happen when building windows_amd64_v1.

It works now! It seems as once we managed to successfully execute the job by changing some build settings, things got cleanup at a runner level.

@haydentherapper I'm gonna remove the execution of the validate release ci job for every PR.
I tried to only build a single binary (linux/arm64) but the rest of our building scripts use --platform=all which will require many more changes. After all this script only checks that the build of the amd64 binary was successful. So I propose to only running for the release- branches. Perhaps @cpanato has other ideas to solve the problem.

Another idea (thanks @bobcallaway) would be to delete the container before running validate-release-job.
If not that, then I think trying to build only a subset of our binaries like you suggested would be a good idea.

@bobcallaway found this example of clearing out packages from the base runners that arent needed for a Go project: https://github.com/GoogleContainerTools/distroless/blob/5f4db907b8106a9ef00e015af15e84f80e8d7c9a/.github/workflows/ci.yaml#L27
(TIL the 14GB includes the base image data)

Closing this as solved by https://github.com/sigstore/cosign/pull/3169!


Orchard.Layouts - Stuck in a dialog box when login has timed out / exception occurs

1.9.x branch
I had the admin panel open working on a content item with a layout (I've attached one to the blog post).
I'd ended up getting logged out of Orchard separately.
When I dragged the element (it was a H1-6 element) on to the canvas the Dialog box opened up.
Instead of showing the element it showed the login page of the site.
I tried to log in but after I submitted my login form it showed this:

Additionally I then couldn't escape from the Dialog. I tried clicking outside on the ghosted area and pressing esc. There were no dialog buttons for me to click to dismiss nor an X in the corner.
When I attempted to refresh the page I was reminded that I had unsaved content.
As a developer I could f12 in, delete the overlay div and save my content. Normal users would have ended up trapped though.

Yeah, there's a session that times out. We should either use a database table to transfer state from one screen to the next, or keep the session alive using a periodic AJAX ping.
A dialog dismiss button (such as an X or Close button) should definitely be added. Weird that you didn't see one, because it should have been there.

I just double checked:

Placing the mouse cursor anywhere in the title bar shows the four way arrows for move.
Clicking in the corner doesn't do anything.
Also I just tested letting it load successfully and there is never a dismiss, just the cancel button in the bottom when it loads correctly:

Let's create a component in the admin that will ping the site regularly to keep the session open. This will also fix issues when users create long blog posts and could lose everything because of that.

Would this component effectively remove timeouts?  We expect a user to be logged out if they keep their browser window open on the computer for an extended period of time.  Perhaps storing the data in local storage in the browser instead?

I agree with @sebastienros but also the dialog needs a way to exit using standard procedures like pressing esc or clicking outside the window. If an exception occurred while loading these panels in then you would still end up stuck in it even with the ping component.

Esc has been implemented to get out of the dialog if the error occurs so the original issue has been resolved.
Closing this but feel free to reopen if you think it should be open to continue the background timeout ping feature discussion.


Inaccurate tally

I think it has something to do with the check answer clicker function -- might be missing the last answer in the tally.

Save tally to local storage??


ConfigService is not Send + Sync

https://github.com/nacos-group/nacos-sdk-rust/blob/207421aad7bbf0f0f0e7945b9b94bd91977028b5/src/api/config.rs#L22C11-L22C24
Better changed to
pub trait ConfigService: Send + Sync {
//...
}

So that ConfigService can be async friendlier.

Could you please make a PR?  for  ConfigService and NameingService


Track your Location - (Add GeoLocation district wise)

Can you provide more details?

we can show initial data dependent on current location, if location is enabled.

No, we do not prefer the get the location of the users. It's quite unnecessary when the site has search and dropdown options to get the state/district information that the user needs. Thanks for the suggestion.


Fix DependencyBundlingAnalyzer

The DependencyBundlingAnalyzer has grown over time from multiple PRs to do things it was not originally intended to do (at least not at the phase it is running in). Additionally, how the bundling analyzer works in conjunction with the suppression analyzer it is possible that vulnerabilities are being hidden (see issue #629).  What needs to be done is the following:

Split the bundling based on package path into a separate analyzer that runs prior to CPE identification. This will allow us to better solve issues like #453. When doing this consider renaming package path to something more along the lines of coordinates as that seems to be more what we can "bundle" on. Note, this is solely for multiple file type analyzers that may each generate a dependency (based on different artifacts) for the exact same dependency. An example would be a dependency from analyzing NuSpec and another from analyzing the actual DLL - the goal would be to report only a single dependency with multiple sources of evidence.

Solve for CVE suppressions with regards to the bundling related dependencies. The vulnerability analysis should run, then the suppression analysis, then finally the bundling and we should only bundle what appear to be related dependencies if the vulnerability count is the same (based off of identical CPE identifications, etc.).

This has been implemented in  1.4.5-SNAPSHOT and will be included in the next release. The new DependencyMergingAnalyzer will likely need additional re-work when we solve #453.


deterministic random provider

we need a random provider that returns the deterministic representation of the distribution. also the mean random provider is actually a median random provider and should be named as such.

a deterministic random provider is not actually a random provider. a random provider provides a random number to inv cdf. we don't want to use the inv cdf tho for this need. we need most likely, mean, etc

not sure how to fix this. I want to compare the 1.4.3 compute without risk to the 2.0 compute without risk but they handle it differently, making troubleshooting challenging.


Spanish translation edit suggestions

I fixed some bugs in the Spanish translation, which should fix some issues with English sentences. In addition, I corrected some language typos and the inconsistent use of "tú/usted", "vosotros/ustedes".
Lastly, it didn't seem natural to me to refer to EN "hints" as ES "datos" so I suggested a version using ES "información" (EN "information") whenever possible.
Some other minor changes suggested for more clarity.

Hey @lumosan!
Thanks a lot for this PR. I am not fluent enough in Spanish so I approved everything!!! I tested though and it looks very nice now :D
Just one question

Do you know if some translations are more natural in Spain rather from Latin America? Just curious if datos is more natural in Latin America. Where are you from by the way?

Hi @sarahmamy!
I'm from Spain.
As far as I know, the translations could also vary from country to country, not only between Spain and Latin America.
All the Hanabi rules translations that I found online used either "pistas" or "información". In Spain, we would use "pistas", but I think that "información" should sound okay anywhere.


Include experimental design into pdf

addresses #263
Adds the experimental design information of an offer to the offer pdf

 Allow user to specify the experimental design separately


update to Quarkus 2.16.0

What this PR does:
Updated to 2.16.0. @tatu-at-datastax You could use the new annotation for CQL endpoint disabling once this is merged.

[ ] enable new grpc support

@ivansenic Yes, thank you! Good to see fast Quarkus releases still.


Can't Pry up grass tiles.

Description
When a flora anom goes off its not possible to pry up the grass without a RCD. A lot of the tile prototypes do exist and in reality you can cut and pull up grass squares with some ease. There used to be some of this functionality and was used to clean an area up back to station style.
Reproduction

Spawn a flora anom
Make it go boom
Try to remove grass tiles

Screenshots
NA
Additional context
Unsure its its just not using a particular grass tile, had a quick check with a couple and no joy.

the id of the tile is FloorAstroGrass and it cannot be pryied up, but cut with a wirecutter instead. There is no issue here.

use wire cutters instead. I agree its a touch inconsistent, Id prefer if we could also get the other astro-tiles to use a relevant tool, but last time I check you cant use welding or digging on a tile for some reason for e.g. astrosnow.

What? You all never mowed the lawn with wirecutters before?


Db support

Optionally save logs & reports in MongoDB

Added the 2 relevant services to consume the logs & save them in mongo.
Adding now the relevant changes to the gpt-researcher python service

All required files added.
Tested on Mac & all tests pass
Ready for review

Closing for now since there's a chance that commits were squashed on this branch.
We might be able to leverage the JavaScript code in this branch on the upcoming NextJS server, but should probably:

remove the Kafka middleman
save in postgres instead of mongodb
leverage the stream_output function

Requires design review if we'd like to implement Langchain Retrievers which leverage a PGVector  as proposed by this user in the discord.


config: track message ancestors for unknown fields

Signed-off-by: Tianpeng Wang<EMAIL_ADDRESS>
Commit Message: config: track message ancestors for unknown fields
Additional Description:
Risk Level: Low
Testing: unit test
Docs Changes: N/A
Release Notes: Required
Platform Specific Features: N/A

/retest

/azp retest

Needs main merge
/wait

/retest

/assign-from @envoyproxy/senior-maintainers

Sorry this will need a main merge due to my recent changes and then I can take a look.
/wait

This is still waiting for a main merge.
/wait

/wait

/wait

/wait

/retest

/retest


MergedObject with actix-web example

Expected Behavior
The server should return valid response
Actual Behavior
It seems to return App data is not configured, to configure use App::data()

Steps to Reproduce the Problem

Change actix-web example https://github.com/async-graphql/examples/blob/b36b5c44543b7323cb199ed229ea247e83b85d18/actix-web/starwars/src/main.rs#L21 to

#[derive(MergedObject, Default)]
pub struct MergedQueryRoot(
    QueryRoot,
);

#[actix_rt::main]
async fn main() -> std::io::Result<()> {
    let schema = Schema::build(MergedQueryRoot::default(), EmptyMutation, EmptySubscription)
        .data(StarWars::new())
        .finish();

Add #[derive(Default)] to QueryRoot as well

Specifications

Version: lastest master
Platform: macOS
Subsystem: NA

Because the Schema type is wrong, here is StarWarsSchema.
https://github.com/async-graphql/examples/blob/b36b5c44543b7323cb199ed229ea247e83b85d18/actix-web/starwars/src/main.rs#L7

Right thanks, I managed to compile a running code, cheers


Change branch specification

I'll add the changes to my fork so let's update branch used here not to break the tests.

@JohnTitor: no appropriate reviewer found, use r? to override


Create bot-status.rb

I made this as a example of how to change the bots status
Summary
So i added this to the /examples to show how a bot can have custom status
Added
Changed
Deprecated
Removed
Fixed

Thank you for your contribution! However, we generally don't wish to offer a full example for every functionality. In the same vein however, I may add a wiki page explaining how some actions must occur in/after ready since that is the main concept that isn't always intuitive.


Create simple way to expose server-side toggle value to clients

Or demos/samples showing this for WCF, webapi, etc

Just to clarify - this could be an additional package for ASP.NET that exposes toggles as Web API, etc. and point so that client side JavaScript can modify UI depending on if feature is enabled


Add Multiplier Command

Just a slow way of adding multipliers to the plugin, might not wanna use it, im really just using it for my server.

i forgot to add the plugin.yml change.....
`name: SellAll
main: AndreasHGK\SellAll\SellAll
version: 1.3.0
api: 3.0.0
load: POSTWORLD
author: AndreasHGK
description: Sell all items in your hand or all items in your inventory with the same type as in your hand
depend: ["EconomyAPI"]
commands:
sell:
description: "Sell command"
usage: "/sell all|hand|inventory"
permission: sellall.command
addmultiplier:
description: "Add multiplier to a player"
usage: "/addmultiplier player amount"
permission: sellall.addmultiplier
permissions:
sellall:
default: op
description: "SellALl root permission"
children:
sellall.command:
default: true
description: "Allows the use of /sell"
sellall.reload:
default: op
description: "Reloads the plugin"
sellall.addmultiplier:
default: op
description: "Add multiplier to a player"`


multicheckbox with true false value in array of objects from the model

Question
I have a list of questions where the user tick if happened/true.
I'm trying to make it dynamic on both sides, so I thought of returning a list of strings (labels) and a boolean value (true its ticked)
eg:
questionsList= [ { 	"label": "Blah blah evidence", 	"value": false }, { 	"label": "is ≤1 year of age xxx", 	"value": true }
However, passing similar values to multicheckbox will cause all the checkboxes to be ticked once we tick one, I tried to do it differently
So, I want a way to make the key and the options to be the same, is that possible? I can change the model I just can't find a way to make both drivings by the model so I don't need to do any processing.
Here is the closest I can get, an object instead of an array, options only, I want an array of objects so I can use the model directly
https://ngx-formly-ui-bootstrap-x1dqb2.stackblitz.io

The request: One array for both model and options
If I add type: 'array' and use { label: 'Option 2', value: true }
the model will just have a true/false array, no indicator of which label is that
Plus, all check-boxes with the same value (like false) will be checked together once we check one!
https://ngx-formly-ui-bootstrap-x1dqb2.stackblitz.io

can you check the last stackbitz ? is it a bug?

It's an expected behavior, it contains an array of unique values.

So, I want a way to make the key and the options to be the same

You can customize the option key using valueProp:
  fields: FormlyFieldConfig[] = [
    {
      key: 'checkboxsList',
      type: 'multicheckbox',
      templateOptions: {
        ...
+       valueProp: option => option,
      },
    }
  ];

@aitboudad
So it is possible to make options and the key point at the same array? I have changed the array to have a unique value
{ 	"availableTypes": [ 		{ 			"selected": false, 			"text": "B", 			"value": "56" 		}, 		{ 			"selected": false, 			"text": "V", 			"value": "57" 		}, 		{ 			"selected": false, 			"text": "Fun", 			"value": "58" 		} 	] }
But can't figure out how to change/stop what multicheckbox is adding then change it myself ?
https://stackblitz.com/edit/ngx-formly-ui-bootstrap-x1dqb2
or do I need a custom firmly type to achieve that?

use https://formly.dev/examples/advanced/repeating-section

Thank heaps @aitboudad
https://stackblitz.com/edit/angular-y3udpd?file=src/app/app.component.ts
Can you tell me if there is a better way to set the label value instead of using expressionProperties ?
Have a nice weekend

expressionProperties is the better way, you may pass a string value or an observable instead of function as well:
expressionProperties: {
  'templateOptions.label': 'model.text'
}

The second solution is to rely on valueChanges, https://github.com/ngx-formly/ngx-formly/issues/2747#issuecomment-799430559

@aitboudad Any idea if I can I use the same way with type: 'radio'?
https://stackblitz.com/edit/angular-y3udpd

radio type may not work properly for your case, use valueChanges and uncheck other fields instead + you could also define a custom validator as well.
hooks: {
  onInit: (field) => {
    // field.templateOptions.label = field.model.text;

    return field.formControl.valueChanges.pipe(
        // uncheck other fields
        ....
    );
  },
},

@aitboudad
Do you mean using repeat with hooks ? because radio doesn't render under repeat
https://stackblitz.com/edit/angular-y3udpd
If you mean without repeat, how can I stop the radio normal change to the model then apply the change I want only?

Do you mean using repeat with hooks ?

yes, repeat with hooks.

@aitboudad I found why radio doesn't render, I need to pass the values to option, I have used hooks to do that
I can't figure out the uncheck part, where is the selected value kept?
check it out: https://stackblitz.com/edit/angular-y3udpd


update rapids_sagemaker_higgs notebook

HI @jacobtomlinson this PR Is ready for review/merge. It's basically the same process as the hpo_extended notebooks testing on a different (HIGGS dataset). The training and hpo jobs are still running , have been running for a while >12 hours I'm guessing because the dataset is large.


supernova -c option to specify a configuration file is broken

Regardless of any -c command-line option, supernova's behaviour seems to be:

If there is a '.supernova' file in the current directory, use it;
... otherwise, use ~/.supernova;
... otherwise, fail with the output:

Traceback (most recent call last):
  File "/usr/local/bin/supernova", line 9, in <module>
    load_entry_point('supernova==2.0.8', 'console_scripts', 'supernova')()
  File "/usr/local/lib/python2.7/dist-packages/click-4.1-py2.7.egg/click/core.py", line 664, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click-4.1-py2.7.egg/click/core.py", line 643, in main
    with self.make_context(prog_name, args, **extra) as ctx:
  File "/usr/local/lib/python2.7/dist-packages/click-4.1-py2.7.egg/click/core.py", line 560, in make_context
    self.parse_args(ctx, args)
  File "/usr/local/lib/python2.7/dist-packages/click-4.1-py2.7.egg/click/core.py", line 822, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/usr/local/lib/python2.7/dist-packages/click-4.1-py2.7.egg/click/core.py", line 1326, in handle_parse_result
    self.callback, ctx, self, value)
  File "/usr/local/lib/python2.7/dist-packages/click-4.1-py2.7.egg/click/core.py", line 54, in invoke_param_callback
    return callback(ctx, param, value)
  File "build/bdist.linux-x86_64/egg/supernova/executable.py", line 36, in print_env_list
  File "build/bdist.linux-x86_64/egg/supernova/config.py", line 35, in run_config
  File "build/bdist.linux-x86_64/egg/supernova/config.py", line 45, in load_config
  File "build/bdist.linux-x86_64/egg/supernova/config.py", line 77, in get_config_file
Exception: Couldn't find a valid configuration file to parse

... regardless of the existence or otherwise of the specified file, and regardless of whether the '-c' option is used or not.
This is with Python 2.7.6 on Ubuntu 14.04.2 LTS, with supernova from github (commit 472e48a21b545681ecf37592fcf29caf0c710d9a) installed with 'python setup.py install' as root.
P.S. The '--help' text is a little unclear - stating:
-c, --conf TEXT        Manually specify a supernova configuration file

... appears to be a little ambiguous as to whether the anticipated argument is a file-path, or a text-string containing the relevant configuration entries.  Possibly consider changing "TEXT" to "PATH" or "FILENAME"?

Hey @stuart-shelton-hp, thanks for that.  Could you let me know what you're running on the command line?
I'm able to use -c and specify various configuration files when I run it.

For example, I have a user (/home/user) who cloned supernova from github (/home/user/supernova) - and, of course, the supernova source includes a configuration file.  I've also placed a global supernova configuration file in /usr/local/etc/supernova.conf.
As root (who has no supernova configuration in their home directory), if I run supernova -c /usr/local/etc/supernova.conf -l then the behaviour is as above: from the supernova source directory, the output is from the default configuration file, from the user's home directory the output is from their local configuration file, and otherwise the stack-trace is seen.
Running the same command as the user shows the default configuration in the supernova source directory, but the configuration from their home directory at all other times.
At no point is the command-line specified configuration in /usr/local/etc/supernova.conf ever used.
I've tried using long options (--conf/--list) in place of short options, and tried changing the order, and the results are (thankfully ;) the same.
If it makes a difference, the actual host is a VM within Microsoft's Azure cloud service.  I can't imagine it should, but there's always the chance for craziness...

Thanks for the clarification, @stuart-shelton-hp. I'm still working on reproducing it so I can figure out where the bug resides.

Ah, okay.  I am definitely seeing the bug with --list and I know where it is. ;)

@stuart-shelton-hp Could you try out this branch with --list and let me know what you get?
https://github.com/major/supernova/tree/github-issue-92

I think #117 (merged) probably fixed this issue. @stuart-shelton-hp: Can you try out the latest master branch from git and see if --list is respecting the -c option now?


Double tap to clear zoom

A common feature for image viewers is that whenever you have some zoom if you double tap it is gonna reset the zoom

This would be amazing. Started to look into it but a lot is over my head.
This is where I started: https://stackoverflow.com/questions/3967971/how-to-zoom-in-out-photo-on-double-tap-in-the-iphone-wwdc-2010-104-photoscroll
@PeterStaev my current thoughts are to call setZoomScaleAnimated in UIScrollView on iOS on a double tap on the container. I tried that by just doing
gallery.ios.setZoomScaleAnimated(5, true);
but it doesnt work. No errors and the method gallery.ios.setZoomScaleAnimated does exist, but the photo doesnt scroll. Thoughts?

@davecoffin , it is not that simple. The root scroll view is just for navigating between images. Then inside the this one there is another one that is for zooming:
https://github.com/PeterStaev/nativescript-image-swipe/blob/9ea9613d89f688ddfcc63db2bf04ad149803279b/image-swipe.ios.ts#L201-L207
So in order to zoom, you have to get instance of the zoomScrollView for the given page and use that method on it.

@davecoffin , try to use imageSwipe._views private property. This is an array that should contain properties for the pages:
https://github.com/PeterStaev/nativescript-image-swipe/blob/9ea9613d89f688ddfcc63db2bf04ad149803279b/image-swipe.ios.ts#L24
So using imageSwipe._views[page] (where page is your current page) should get you the object of the current page. From there in order to get the zoom view you can use imageSwipe._views[page].imageView.superview
As for how to get the current scale, using the zoomScale property of the UIScrollView should do the trick: https://developer.apple.com/documentation/uikit/uiscrollview/1619419-zoomscale?language=objc

OMG amazing that worked like a dream. I got double tapping working 🎉 Ok so one last question...the zoomScale is reporting unexpected results. It looks like when a photo is zoomed all the way in, the zoomScale is 1. But when its zoomed all the way out its not 0, it depends on the photo. I'm getting like .25, .3333 etc for photos that are zoomed all the way out. Any idea why?

I think I understand whats happening, the images are actually being displayed at more than 0 zoomScale in order to take up the full width of the device. I think I'll need to capture the initial zoomScale in a map or something.

zoomScale shows you how much the image is zoomed inside the scrollview. In most cases when you actually show photos this will be less than 1 so that the image fits on the screen. If it is 1 this means that the image is displayed 1:1 on the screen. It can never be 0 as then this means that the image is not shown.
No need to create a map as the plugin already has internally the "fit" zoom:
https://github.com/PeterStaev/nativescript-image-swipe/blob/9ea9613d89f688ddfcc63db2bf04ad149803279b/image-swipe.ios.ts#L264-L268
So if you want to reset zoom simply use the zoomScrollView's minimumZoomScale prop 😄

So my problem is id like to know if an image is zoomed in at all. But when a photo is loaded, the zoomScale is neither 0 nor 1 but somewhere in between. When a photo is zoomed in as far as it can go, the zoomScale is 1. The reason I need to know if its zoomed in is because for example if you pinch to zoom in and then double tap, it should zoom out. So at the point the user double taps, I need to know if the photo is zoomed in at all. I thought I could determine this by evaluating if zoomScale > 1, but zoomScale always has the image somewhere between 0 and 1.

Dude you rock. 1000% respect. Everything is working like a charm.

This is now available in the new version of the plugin available in the ProPlugins NPM registry.
All future work of this plugin will be available exclusively as part of ProPlugins initiative. So if you want to get the latest updates/fixes/features make sure you subscribe to the service. You get all my plugins plus many of the most used and high quality plugins for a small monthly subscription fee.

Thanks @PeterStaev you rock!


Added ControlFlowException

Hi guys. I hope I understood it right, I'm very new to this, so apologies if not.
I added the custom exception and changed some unit tests, but I'm unsure if that was the right thing to do.
Any feedback welcome 🙂

Btw this is in reference to this issue

Hi Jeppe, I know that currently we have a lack of meaningful exception types, but it's not as easy as you did it in your PR. I'm sorry I have to close this (also because we're moving to nuke-build/nuke again).
But thanks anyway for your contribution! 🤗

No problem, I had a feeling it wasn't as easy as that, but wanted to try. Thanks for the feedback anyway!


Maintain left and right padding when embedded

Hi, I'm wanting to use embedded: true to reduce the vertical padding between multiple instances of the card however when enabled the left and right padding is also lost making the start of the card misaligned with other cards in the view:

I had a look at the code and tried adding padding values to:
      .time-picker-row.embedded {
        padding: 0px 16px 16px;
      }

but that made no difference. My JS knowledge is very limited but if you could point me to what I need to tweak I'll adjust it myself.
EDIT: looks like it was just my browser cache misbehaving. This change is doing as I wanted.

Is the solution to this below setting?
.time-picker-row.embedded {
padding: 0px 16px 16px;
}
Because this does not appear to be working for me, even after clearing cache.

Is the solution to this below setting?
.time-picker-row.embedded { padding: 0px 16px 16px; }
Because this does not appear to be working for me, even after clearing cache.

did you delete the *.gz version of the card? If you don't that gets used instead so any changes you make to the *.js won't take effect.

Is the solution to this below setting?
.time-picker-row.embedded { padding: 0px 16px 16px; }
Because this does not appear to be working for me, even after clearing cache.

did you delete the *.gz version of the card? If you don't that gets used instead so any changes you make to the *.js won't take effect.

Ah, that indeed was needed. Thanks a lot.
I actually changed it to padding: 0px 16px 0px; for a more condensed look.

Hi,
If I understand correctly, you have 2 embedded cards - one with embedded: true, one without.
This is the expected default behavior:

when you set embedded: true the card expects it's nested/embedded within another card and removes all padding to align with other components that may be around it.
when the card does not have embedded: true it acts as if it's a standalone card.

Using embedded: true to reduce vertical padding is a cheat :) I see how it may be something people want though, I'll consider adding a separate option for that.

Version 1.3.0 adds a thin option that should help.


Add MariaDB client to the existing AWS AMIs

Description:
Need to modify existing Ubuntu & CentOS AMIs to include MariaDB cli. This will reduce the burden and time of the product deployment by not-having to install MariaDB client when deploying the product.
Related Issues:
#412

Added required changes to the AMIs.


[$1000] Web - LHN still displays "Deleted message" although we deleted comment and its thread completely

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to any chat report
Type a comment
Click "Reply on thread" context menu of this comment
Type a reply in that thread
Remove the parent comment of that thread
Verify that the LHN is displays "Deleted message" in original chat report, and in original chat report, we can still see the comment in step 2, with marked as deleted message
Delete the reply comment in step 4
Go to the original chat report, the comment in step 2 is disappear

Expected Result:
LHN should show the latest visible message.
Actual Result:
LHN still displays "Deleted message" although we deleted comment and its thread completely, and the comment is already disappear in the chat.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.43-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/420787f4-fd3d-442f-aefc-cd0c6d5cb727
https://github.com/Expensify/App/assets/93399543/4c0c0520-72aa-4aca-a313-7b5f483d1fc7
Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689983918865759
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01746b90b47c15e650
Upwork Job ID:<PHONE_NUMBER>183359488
Last Price Increase: 2023-09-15

It looks like this is an intentional behavior, but I think this is an inconsistency.

@cead22 / @marcaaron it looks like you are both assigned the above-linked issue. Can you investigate whether the linked PR caused a regression?

See my comment here @johncschuster https://github.com/Expensify/App/issues/19722#issuecomment-1648818264

Awesome. Thanks, @marcaaron! In that case, should we put this one on hold and wait until #19722 has been resolved to see if this behavior is still an issue, or are you confident #19722 will resolve this issue? If yes, I would close this issue.

Tbh I'm only involved because I am the deployer this week and something loosely related needed to be reverted to unblock the deploy. I would suggest seeking out and asking the original authors who introduced the regression directly.

HOLD does sound like a reasonable plan to me though since deleting the comment thread is not that critical of an action that people will take and doesn't have a great effect on the biz.

https://github.com/Expensify/App/issues/19722#issuecomment-1649225218

Proposal
Please re-state the problem that we are trying to solve in this issue.
The LHN keeps showing [Deleted message] without getting updated with the immediately previous visible message when the Parent Message comment for a threaded chat is deleted.
What is the root cause of that problem?
The root cause of the problem has to do starting from #19722. Here is a little bit of history of the implementations done before at #19722 for reference. #19722 was implemented using isLastMessageDeletedParentAction and specifically this condition reportAction.childVisibleActionCount > 0 through the PR implementation for this issue to resolve this problem. But, this had caused a blocker issue #23401 which was temporarily unblocked by replacing the condition with childVisibleActionCount === 0 in code here. However, as mentioned in a comment here, the issue is not done yet. This issue occurs when the number of visible actions in the thread chat (Chat T) becomes 0. In this case, isLastMessageDeletedParentAction is set because of which the LHN keeps showing [Deleted message] without getting updated with the immediately previous visible message. The workaround to overcome this issue is to add a new comment which will reset the variable.
What changes do you think we should make in order to solve the problem?
Instead of introducing isLastMessageDeletedParentAction, we can rely on the combination of existing variables: isDeletedParentAction and childVisibleActionCount. Since deleting a parent action is a one-way operation, it simplifies the complexity too. We can implement this as follows:

Currently, we set isDeletedParentAction to true in this code here when we delete a comment in parent chat (say Chat P) for which there are visible children in the chat thread (say Chat T). Once this is set, whenever the LHN option row is populated, we can check if this is a deleted parent action and return [Deleted message] as follows. We can implement this just before we check for an empty lastMessageText here in this code so that the text 'This is the beginning of..' is avoided.

 else {
        const lastAction = visibleReportActionItems[report.reportID];
        if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && ReportActionsUtils.isDeletedParentAction(lastAction)) {
            // Called when Parent Report has a most recent visible action that has a thread which is deleted but has more than one visible child comments.
            result.alternateText = Localize.translate(preferredLocale, 'parentReportAction.deletedMessage');
        }
      }

As we have already set the alternateText to the desired value, we can replace this line with the following and free ourselves from isLastMessageDeletedParentAction by depending directly on alternateText. Also, we can remove other references of isLastMessageDeletedParentAction in the code.

{optionItem.alternateText}

Additionally, there is one more bug that needs to be fixed in deleteReportComment here in this code . When the Parent Message is deleted in the Thread Chat, the childVisibleActionCount will also be decremented which will cause an issue where there is only one visible child action in the Thread Chat. In that case, the LHN will start displaying [Deleted message] even though it is not deleted. This can be overcome by checking if the current deleted comment is a parent action as shown below.

+    // Update optimistic data for parent report action if the report is a child report and the reportAction is that of the child report.
+    const currentReport = ReportUtils.getReport(reportID);
+    if(currentReport && currentReport.parentReportActionID &&  currentReport.parentReportActionID !== reportAction.reportActionID)
+     {
         const optimisticParentReportData = ReportUtils.getOptimisticDataForParentReportAction(reportID, optimisticReport.lastVisibleActionCreated, CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
         if (!_.isEmpty(optimisticParentReportData)) {
             optimisticData.push(optimisticParentReportData);
         }
+     }

Regarding BE, this proposal does not depend on isLastMessageDeletedParentAction and can be removed. Further, as the FE does not depend on the lastMessageText in report for display on deletion of the parent action, BE can behave as it is currently.
Note: Apart from this, there are refreshing issues on LHN which, I believe, are addressed in #23424.
What alternative solutions did you explore? (Optional)

@flodnv @rushatgabhane @dukenv0307, it looks like the PR linked to this issue may have caused a regression. Can you investigate that and leave a comment here so we know how best to handle this issue? Should we close it in favor of #19722?

@johncschuster yes we can hold this issue on #19722  and make it weekly or something

Sweet! Thanks, @rushatgabhane!

I'm still on parental leave and will be back on august 17th. I just wanted to point one thing out in the proposal here,

we can rely on the combination of existing variables: isDeletedParentAction and childVisibleActionCount

Feel free to correct me if I'm mistaken (or if things changed recently), but I'm pretty sure you cannot count on isDeletedParentAction because its in reportAction in onyx. When the user logs into the app, only onyx report data is up to date and reportAction is not up to date unless the user visits the chat report.
One way to test if your solution works is,

Apply your code solution.
Assume chat report 111 now shows [Deleted Message] in the LHN.
Click another chat report say 222 and leave some message.
Log out and log in to clear onyx.
Once logged in you should be seeing chat report 222 by default.
At this point does chat report 111 show [Deleted Message] in its LHN preview? I have a feeling it will not since it won't fetch the updated reportActions just yet.

but I'm pretty sure you cannot count on isDeletedParentAction because its in reportAction in onyx. When the user logs into the app, only onyx report data is up to date and reportAction is not up to date unless the user visits the chat report.

@chiragsalian  Thanks for your feedback. Please find attached a video with the test case run on the proposed proposal. The test runs well as expected and shows [Deleted message] even after logout and login. Also, the BE is sending the isDeletedAction and can be verified in API response.
I think, before you went on leave, isDeletedParentAction was not used effectively as it was always set to true. This was fixed sometime during early July as can be seen here. Maybe, that's how you arrived at  your understanding.
https://github.com/Expensify/App/assets/3004659/70d445e3-05c1-422d-a400-ad5c13bdfd35

Bumping to keep Melvin happy while we wait for our friend @chiragsalian to pop back in.

im back from parental leave. Also i thought some other internal engineer was helping out here. i didn't realize there was no movement here 😅
Anyway, thanks for the video @rojiphil. That's interesting. I did not think that would work. It looks like there is some flow loading some reportActions. I still doubt that reportActions is a good source of truth for LHN data.
I just tested today to confirm,

In production i logged out and back in to clear onyx.
I checked onyx data in Application -> Storage -> Indexed DB -> OnyxDB -> keyvaluepairs
For reportActions_ you can see there are just 13 values

But for report_ (which is what LHN normally uses) you can see i have 377.

It looks like there is some code that returns a few reportActions_ but as long as its count does not match report_ values it cannot be used as a source of truth for LHN UI. Let me know if that makes sense. Feel free to test yourself, you just need to test on an account that has a lot of chats.

Thanks for jumping in @chiragsalian!

I still doubt that reportActions is a good source of truth for LHN data.

@chiragsalian Welcome back. Will look into this and share my comments today

It looks like there is some code that returns a few reportActions_ but as long as its count does not match report_ values it cannot be used as a source of truth for LHN UI. Let me know if that makes sense. Feel free to test yourself, you just need to test on an account that has a lot of chats.

@chiragsalian
I did a test on an account that has lots of chats. My understanding is that it is not a must for every report to have its matching report action. The attached video shows that the report(1117098819918956) that does not have a matching reportAction is pointing to a reportAction(1992965932620012783) within another report(91639911042078). Further, we are already depending on reportActions for LHN as seen in code here. So, I think, it is safe to depend on reportActions here. Please let me know your thoughts.
https://github.com/Expensify/App/assets/3004659/133c6e59-7807-4d4b-8fbb-df09fc280036

Okay so to explain my perspective, this was my thought process,
Say we have 5 reports - assume reportIDs - 111, 222, 333, 444, 555
I'm saying, the moment we log in in onyx we are fetching all the reports and not all the reportActions i.e., in onyx we can see,

report_111, report_222, report_333 and report_444, report_555
but we are not fetching all the report actions, i.e., we might have
reportActions_111, reportActions_222 and nothing else.

Currently on LHN (i.e., SideBarLinks) we only use report data and not reportAction data for its UI. So for a reportID say 555 if we have report_555 and not have reportActions_555 but update SideBarLinks to use reportActions_555 it won't work well since onyx does not have the data for it (unless if we update backend to send all reportActions which i doubt we'll do since it does not sound feasible)

The attached video shows that the report(1117098819918956) that does not have a matching reportAction is pointing to a reportAction(1992965932620012783) within another report(91639911042078)

But this point is really interesting. It made me test and wonder why this was happening. So it took me a while and i found the backend code. So every report that we fetch, if it has a parent report action then we fetch the parent report action as well. So all reportActions that onyx initially has are all associated with child reports which are used to load the correct title for child reports since the parent report action is the source of truth.
Okay with that in mind your proposal might just be correct since we should always have the parent report action for a child report. I'll test a bit with the deleted action flow as well and review your proposal today.

okay isLastMessageDeletedParentAction , is definitely not needed since we always have the complete report Actions for a parent report action.
As for your proposal @rojiphil, it mostly looks good to me. There is a lot there. I think breaking each into a separate problem/solution would help with readability but from a high level it makes sense to me.
@johncschuster, I'm marking this as external so that a contributor can help out reviewing the proposal.

i removed HOLD since i think thats not needed either

Thanks @chiragsalian!

As for your proposal @rojiphil, it mostly looks good to me. There is a lot there. I think breaking each into a separate problem/solution would help with readability but from a high level it makes sense to me.

@chiragsalian  Thanks for your input. Based on the latest version, I had already broken up into separate problem/solution here. Awaiting review inputs from @rushatgabhane .

Not overdue, Melvin. We're waiting on input from @rushatgabhane

Bumping in Slack

In that case, can we close this one out?

In that case, can we close this one out?

@johncschuster I have opened a discussion here in slack to resolve this.

Thanks, @rojiphil! I'll review that thread shortly.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - LHN still displays "Deleted message" although we deleted the comment and its thread completely
What is the root cause of that problem?
[Deleted message] gets displayed in LHN as subtitle when childVisibleActionCount is 0 as shown here due to which isLastMessageDeletedParentAction is set. This causes the LHN to keep showing [Deleted message] because of this code here This results in the previous message not getting updated.
What changes do you think we should make in order to solve the problem?
To solve this problem, two changes can be made:

We can avoid setting the isLastMessageDeletedParentAction to true by replacing the code here with the following condition:

if (reportAction.childVisibleActionCount !== 0) {

Further, we can replace this line here with the following as isLastMessageDeletedParentAction is not set anymore.

{optionItem.alternateText}
What alternative solutions did you explore? (Optional)

Friendly bump @rushatgabhane, would you be able to review the proposal here.

Proposal
Updated
@allroundexperts
Added more context to the proposal. Also, added step 3 for some additional code cleanup.
Kindly review.

@allroundexperts That proposal had references to other issues. That’s why I left it there. Anyway, I have marked it outdated in this context to take this forward.

@allroundexperts Updated the proposal to add more context in alternate solution section. Hope that too helps.

@rojiphil Removing this would cause the Deleted text to never show up in LHN. Do we want to do that considering we might have a case where the parent action is deleted but the child count is not zero?

@allroundexperts We have comprehensively covered the topic of LHN subtitle display of [Deleted message] in the proposal here. Maybe, we should wait until that is done. What are your thoughts?

Is this still reproducible?

@hoangzinh can you please retest latest app?

@situchan The issue is reproducible in another way. But, the RCA is the same. Please refer to the test video in Slack here.

bumping to keep Melvin happy while the discussion continues

@allroundexperts where did we land in the discussion above? What do we need to move this forward?

@rojiphil Do you have anything to say here?

@allroundexperts
Looking into this today. Will share my findings.

@rojiphil Do you have anything to say here?

I was wrong in my observation of your analysis here. Sorry about that. If you observe the attached test video here for the mentioned steps, the deletion of the thread title will show previous visible message which is what we are fixing in PR here for #19722 .
Our current issue can be reproduced like this here. And, I could reproduce this in the latest main.

I also think that the proposal as mentioned here would fix this.
Hope this brings more clarity on the issue and the required fix.
Let me know your thoughts on this.
https://github.com/Expensify/App/assets/3004659/283405c7-7b32-455f-97da-91a30d94f00d

@allroundexperts what do you think about the above?

@allroundexperts
Gentle bump on reviewing this comment

bumped in Slack

hmmm, can we just remove isLastMessageDeletedParentAction? Did you test the steps from this PR. Won't the problem from the PR become an issue again if we remove isLastMessageDeletedParentAction?

hmmm, can we just remove isLastMessageDeletedParentAction? Did you test the steps from this PR. Won't the problem from the PR become an issue again if we remove isLastMessageDeletedParentAction?

@chiragsalian
We initially used isLastMessageDeletedParentAction when the usage of isDeletedParentAction and childVisibleActionCount was not there in LHN. But, since then, isDeletedParentAction and childVisibleActionCount have been used as a single source of truth for thread implementations. Also, the LHN updation logic in FE has been enhanced to use these variables. So, I think it is safe to remove isLastMessageDeletedParentAction and fix the issue here.
I just tested the steps from the mentioned PR (attached test video for reference) after removing isLastMessageDeletedParentAction. It works well.
Also, can you please check if isLastMessageDeletedParentAction can be removed from BE too? Not sure if there are any special cases that you would identify in BE for which we should test. If so, please let me know and I can test it out in FE too.
https://github.com/Expensify/App/assets/3004659/256f3004-b021-4aff-8e06-cef14796539e

Neat, thanks for checking, proposal LGTM feel free to create the PR @rojiphil.

If no regressions arise, payment will be issued on 2023-11-01. 🎊

@johncschuster
Gentle bump on payments here

Payment Summary:
The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉 (Comment)
@rojiphil requires payment offer (Contributor) - $1500
@allroundexperts does not require payment (Eligible for Manual Requests) - $1500
@hoangzinh requires payment offer (Reporter) - $250

@hoangzinh can you accept the offer on Upwork? I'll get payment issued to you once that's done.

I've issued payment to @hoangzinh. @allroundexperts, can you complete the BZ checklist when you get a moment? Thank you!

$1,500 payment approved for @allroundexperts based on this comment.


fix(security): updating all libs with vulnerabilities

All libs are up to date. In some cases libs with breaking changes had to be updated.

please merge this ASAP

any update?

Cc @acinader

please merge this ASAP

+1

Is this package still maintained?

+1

Any news?


Rancher integration test -  Harvester 1.1.2 + Rancher 2.7.9

What's the test to develop? Please describe
Rancher integration test on Harvester 1.1.2 + Rancher 2.7.9 to confirm the support status
Test Outline

Import Harvester in Rancher
Create RKE2 Harvester node driver cluster by manual and terraform
Deploy cloud provider and csi driver all the clusters.
Necessary checks for cloud provider and csi driver working on cluster.
Scale down and scale up of clusters basic operations.

Environment

Harvester

Version: v1.1.2
Profile: QEMU/KVM, 3 nodes (8C/16G/500G)
ui-source: Auto

Rancher

Version: v2.7.9
Profile: Docker, 1 node (1C/4G)
RKE2: 1.24

Terraform...

Reference

https://github.com/harvester/tests/issues/936

Prerequisites
Based on

Prerequisites

VLAN 1 network on mgmt and 1 network on other NICs
2 Virtual machines with data and md5sum computed- 1 running, 1 stopped
Create a new storage class apart from default one. Use the new storage class for some basic operations.

Setup

 Setup a 3 nodes v1.1.2 cluster :ballot_box_with_check:

Network

 Create network mgmt-vlan1 and ens5-vlan1 on mgmt and ens5 NIC respectively :ballot_box_with_check:

Storage

 Hot-plug disk to a node0 and node1 respectively :ballot_box_with_check:

node0

node1

 Attach blockdevice as storage and add disk tags :ballot_box_with_check:

node0

node1

 Create a new storrage class eext4 which selects new disks :ballot_box_with_check:

 Create a new 10G volume eext4-pred base on the new eext4 storage class :ballot_box_with_check:

VM Creation

 Running VM: Create vm-running :ballot_box_with_check:

Disk: jammy-server-cloudimg + Existing eext4 volume

Network: mgmt-vlan1

Mount eext4 volume and edit fstabubuntu@vm-running:~$ cat /etc/fstab
LABEL=cloudimg-rootfs   /        ext4   discard,errors=remount-ro       0 1
LABEL=UEFI      /boot/efi       vfat    umask=0077      0 1
UUID="f9b6dfad-135d-45a3-b959-8d7dfb4480d0"     /data   ext4    defaults  0 1

 Stopped VM: Create vm-stopped :ballot_box_with_check:

Disk: ubuntu-focal-cloudimg + On-demand eext4 volume

Network: "nonmgmt-untagged"

Mount eext4 volume and edit fstabubuntu@vm-stopped:~$ cat /etc/fstab
LABEL=cloudimg-rootfs   /        ext4   discard,errors=remount-ro       0 1
LABEL=UEFI      /boot/efi       vfat    umask=0077      0 1
UUID="b1cdd092-f937-40d0-8825-1bc6923a65aa"     /data   ext4    defaults    0 1

 Create some test data and computed checksum on both VMs :ballot_box_with_check:

 Restart both VMs from UI, checksum should also valid :ballot_box_with_check:

 Stop **vm-stopped** :ballot_box_with_check:

Rancher Integration
Outline

Test steps

Import Harvester in Rancher 2.7.9
Create rke2 custom cluster, Harvester node driver cluster, cluster using terraform
Deploy cloud provider and csi driver all the clusters.
Necessary checks for cloud provider and csi driver working on cluster.
Scale down and scale up of clustersbasic operations.

Import to Rancher

 Import Harvester to Rancher :ballot_box_with_check:

Rancher, go to "Virtualization Management" -> "Import Existing" -> "Create"

Register Harvester to Rancher

Imported Harvester shows Active

RKE2 Harvester Node Driver Cluster
Setup Cluster

 Create cloud credential :ballot_box_with_check:

Go to "Cluster Management" -> "Cloud Credentials" -> "Create" -> "Harvester"

 Create RKE2 cluster :ballot_box_with_check:

Go to "Cluster Management" -> "Clusters" -> "Create"

Cluster should be created and Active

Rancher

Harvester

:warning: Can only select v1.23.17+rke2r1 to conform to Harvester v1.1.2

v1.26.10+rke2r1

v1.25.15+rke2r1

v1.24.17+rke2r1

 :lady_beetle: (minor) UI broken if Click Rancher tab from Harvester.

Go to Virtualization Managemen

Enter Harvester

Click rancher tab will broken (Workaround: connect to Home tab)

** Workaround **
One workaround is to enter base rancher URL again.

 Create IP Pool :ballot_box_with_check:

Go to "Virtualization Management" -> harvester -> "Settings" -> "vip-pools"

Deployment with harvester-cloud-provider and harvester-csi-driver

 Both App & Workload should be Active :ballot_box_with_check:

App

Workload

 Check Harvester already set as the default storage class :ballot_box_with_check:

 Deploy nginx with on-demand PVC :ballot_box_with_check:

PVC

Mount

 Related resources are created :ballot_box_with_check:

Deployment

PVC

PV

Verify Load Balancer with IPAM "DHCP" :ballot_box_with_check:
${~~~\color{green}\textsf{V}}$

Go to "Service discovery" -> "Services" -> "Create" -> "Load Balancer"
Create lb-mynginx-dhcp with port mapping 8080->80 and selector name=mynginx

 Verify Load Balancer with IPAM "Pool" :x:

Go to "Service discovery" -> "Services" -> "Create" -> "Load Balancer"
Create lb-mynginx-pool with port mapping 8080->80, selector name=mynginx and IPAM Pool

> kubectl -n kube-system logs harvester-cloud-provider-69f9cf6b7f-2mrlc
...

 Plan: 3 to add, 0 to change, 0 to destroy.
 rancher2_cloud_credential.myharvester: Creating...
 rancher2_machine_config_v2.rke2-terraform: Creating...
 rancher2_machine_config_v2.rke2-terraform: Creation complete after 1s [id=fleet-default/nc-rke2-terraform-g2v5b]
 rancher2_cloud_credential.myharvester: Creation complete after 2s [id=cattle-global-data:cc-b8648]
 rancher2_cluster_v2.rke2-terraform: Creating...
 rancher2_cluster_v2.rke2-terraform: Still creating... [10s elapsed]
 rancher2_cluster_v2.rke2-terraform: Still creating... [20s elapsed]
 ...
 rancher2_cluster_v2.rke2-terraform: Still creating... [9m0s elapsed]
 rancher2_cluster_v2.rke2-terraform: Still creating... [9m10s elapsed]
 rancher2_cluster_v2.rke2-terraform: Creation complete after 9m12s [id=fleet-default/rke2-terraform]

 Create IP Pool :ballot_box_with_check:

Go to "Virtualization Management" -> harvester -> "Advanced" -> "Settings" -> "vip-pools"

Deployment

 Both App & Workload should be Active :ballot_box_with_check:

App

Workload

Check harvester-csi-driver

 Check Harvester already set as the default storage class :ballot_box_with_check:

 Deploy nginx with on-demand PVC :ballot_box_with_check:

PVC

Mount

 Related resources are created :ballot_box_with_check:

Deployment

PVC

PV

Check harvester-cloud-provider

Verify Load Balancer with IPAM "DHCP" :ballot_box_with_check:

Go to "Service discovery" -> "Services" -> "Create" -> "Load Balancer"
Create lb-mynginx-dhcp with port mapping 8080->80 and selector name=mynginx

 Verify Load Balancer with IPAM "Pool" :ballot_box_with_check:

Go to "Service discovery" -> "Services" -> "Create" -> "Load Balancer"
Create lb-mynginx-pool with port mapping 8080->80, selector name=mynginx and IPAM Pool

Scaling

 Scale Pool Up :ballot_box_with_check:

Go to "Cluster Management" -> "Clusters" -> cluster -> "+" sign
After

Deployment & LB still work

 Scale Pool Down :x:

Go to "Cluster Management" -> "Clusters" -> cluster -> "-" sign
After

Deployment & LB still work

* :lady_beetle: (Known) Possible scale down fail -   https://github.com/rancher/rancher/issues/42582


add libarchive 3.7.3 with tests and windows support

Based on https://github.com/zaucy/libarchive/tree/bazel-v3.7.3

adds tests
adds Windows support

Hello @dzbarsky, modules you maintain (libarchive) have been updated in this PR. Please review the changes.

@dzbarsky I would love your opinion on these changes since you were the original maintainer. If this works out I intend to subumit these changes for 3.7.2 as well.

Thanks for submitting! I'm about to go on vacation for a week, I will do my best to find time to look before that

The presubmit is mostly green after I've excluded some tests (with added notes for any future readers.)
However, there is a patch error only on ubuntu arm64 for some reason. If anyone has any insight on that, it would be very helpful.

This fix is required to allow rules_js to work on windows. Can it be moved forward?

@dzbarsky we do still need this, right?

yes currently https://github.com/bazelbuild/bazel-central-registry/pull/1916#discussion_r1594523428 is making me hesitant to say it's done. After that's resolved I'm happy to update this PR with 3.7.4.bcr.1 added as well.

Hello @dzbarsky, modules you maintain (libarchive) have been updated in this PR. Please review the changes.

Unfortunately the patches aren't applying for arm64 in the presubmit and I'm not sure why. If anyone has any insight it would be much appreciated.
https://buildkite.com/bazel/bcr-presubmit/builds/6046#018feebc-e114-416d-ab7c-66064716e347
Applying build_with_bazel.patch:
--
  | The next patch would create the file .bazelrc,
  | which already exists!  Applying it anyway.
  | patching file .bazelrc
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file .bazelrc.rej
  | The next patch would create the file BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file BUILD.bazel.rej
  | The next patch would create the file MODULE.bazel,
  | which already exists!  Applying it anyway.
  | patching file MODULE.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file MODULE.bazel.rej
  | The next patch would create the file WORKSPACE.bzlmod,
  | which already exists!  Applying it anyway.
  | patching file WORKSPACE.bzlmod
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file WORKSPACE.bzlmod.rej
  | The next patch would create the file bazel/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file bazel/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file bazel/BUILD.bazel.rej
  | The next patch would create the file bazel/config.bzl,
  | which already exists!  Applying it anyway.
  | patching file bazel/config.bzl
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file bazel/config.bzl.rej
  | The next patch would create the file bazel/libarchive_test.bzl,
  | which already exists!  Applying it anyway.
  | patching file bazel/libarchive_test.bzl
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file bazel/libarchive_test.bzl.rej
  | The next patch would create the file cat/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file cat/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file cat/BUILD.bazel.rej
  | The next patch would create the file cpio/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file cpio/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file cpio/BUILD.bazel.rej
  | The next patch would create the file libarchive/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file libarchive/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file libarchive/BUILD.bazel.rej
  | The next patch would create the file libarchive/test/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file libarchive/test/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file libarchive/test/BUILD.bazel.rej
  | The next patch would create the file libarchive_bazel_generic_config.h,
  | which already exists!  Applying it anyway.
  | patching file libarchive_bazel_generic_config.h
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file libarchive_bazel_generic_config.h.rej
  | The next patch would create the file libarchive_bazel_windows_config.h,
  | which already exists!  Applying it anyway.
  | patching file libarchive_bazel_windows_config.h
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file libarchive_bazel_windows_config.h.rej
  | The next patch would create the file libarchive_fe/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file libarchive_fe/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file libarchive_fe/BUILD.bazel.rej
  | The next patch would create the file tar/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file tar/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file tar/BUILD.bazel.rej
  | patching file tar/bsdtar.c
  | The next patch would create the file test_utils/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file test_utils/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file test_utils/BUILD.bazel.rej
  | patching file test_utils/test_common.h
  | The next patch would create the file unzip/BUILD.bazel,
  | which already exists!  Applying it anyway.
  | patching file unzip/BUILD.bazel
  | Hunk #1 FAILED at 1.
  | 1 out of 1 hunk FAILED -- saving rejects to file unzip/BUILD.bazel.rej
  | Traceback (most recent call last):
  | File "bcr_presubmit.py", line 513, in <module>
  | sys.exit(main())
  | File "bcr_presubmit.py", line 504, in main
  | repo_location, config_file = prepare_test_module_repo(args.module_name, args.module_version)
  | File "bcr_presubmit.py", line 245, in prepare_test_module_repo
  | apply_patch(source_root, source["patch_strip"], patch_file)
  | File "bcr_presubmit.py", line 202, in apply_patch
  | subprocess.run(
  | File "/usr/lib/python3.8/subprocess.py", line 516, in run
  | raise CalledProcessError(retcode, process.args,
  | subprocess.CalledProcessError: Command '['patch', '-f', '-p1', '-i', PosixPath('/workdir/modules/libarchive/3.7.4.bcr.1/patches/build_with_bazel.patch')]' returned non-zero exit status 1.

@meteorcloudy can we get some sort of linux arm platform that is supported? A lot of us are deploying software to Graviton these days for cost efficiency reasons and it's unfortunate to not have it tested upstream; especially for C code it can have a lot of architecture-specific bits

@fweikert What is the latest status of https://github.com/bazelbuild/continuous-integration/pull/1493? Is it possible to have Linux arm64 machines on our GCP project?

Yeah, it's possible, I just didn't have time to fix all the weird breakages.

@dzbarsky @meteorcloudy could this go in soon? Without it we are blocked in using rules_js on windows. Sorry for the nag and thanks in advance!

@DavidZbarsky-at the prebuilt release for this failed:
 In file included from external/libarchive~/libarchive/archive_hmac.c:32:
external/libarchive~/libarchive/archive_hmac_private.h:51:10: fatal error: 'CommonCrypto/CommonHMAC.h' file not found
   51 | #include <CommonCrypto/CommonHMAC.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

https://github.com/aspect-build/bsdtar-prebuilt/actions/runs/9529065254
Is it non-hermetic and some crypto system library has to be installed on the runner?

@DavidZbarsky-at the prebuilt release for this failed:
 In file included from external/libarchive~/libarchive/archive_hmac.c:32:
external/libarchive~/libarchive/archive_hmac_private.h:51:10: fatal error: 'CommonCrypto/CommonHMAC.h' file not found
   51 | #include <CommonCrypto/CommonHMAC.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

https://github.com/aspect-build/bsdtar-prebuilt/actions/runs/9529065254
Is it non-hermetic and some crypto system library has to be installed on the runner?

The CommonCrypto include was patched out in my original version and I guess the patch was not carried forward. I'm traveling for the next few weeks, @zaucy do you have a chance to fix it up?

I'll take a look.

Ah I see. I didn't notice the source patch. This is the one you're talking about right?
--- a/libarchive/archive_hmac_private.h
+++ b/libarchive/archive_hmac_private.h
@@ -40,12 +40,13 @@
  */
 int __libarchive_hmac_build_hack(void);

-#ifdef __APPLE__
-# include <AvailabilityMacros.h>
-# if MAC_OS_X_VERSION_MAX_ALLOWED >= 1060
-#  define ARCHIVE_HMAC_USE_Apple_CommonCrypto
-# endif
-#endif
+// Don't compile against CommonCrypto.
+// #ifdef __APPLE__
+// # include <AvailabilityMacros.h>
+// # if MAC_OS_X_VERSION_MAX_ALLOWED >= 1060
+// #  define ARCHIVE_HMAC_USE_Apple_CommonCrypto
+// # endif
+// #endif

I understand wanting to make bsdtar hermetic because its being used as a tool, but shouldn't we be avoiding modifying sources when submitting modules to the BCR? This feels like a patch that should be either done in a patch in the repo that wants it to be hermetic (e.g. https://github.com/aspect-build/bsdtar-prebuilt) and/or submitted as a feature request upstream to libarchive.
Regardless, I'll be fixing it since it was in the patch prior to this one.

Ah I see. I didn't notice the source patch. This is the one you're talking about right?
--- a/libarchive/archive_hmac_private.h
+++ b/libarchive/archive_hmac_private.h
@@ -40,12 +40,13 @@
  */
 int __libarchive_hmac_build_hack(void);

-#ifdef __APPLE__
-# include <AvailabilityMacros.h>
-# if MAC_OS_X_VERSION_MAX_ALLOWED >= 1060
-#  define ARCHIVE_HMAC_USE_Apple_CommonCrypto
-# endif
-#endif
+// Don't compile against CommonCrypto.
+// #ifdef __APPLE__
+// # include <AvailabilityMacros.h>
+// # if MAC_OS_X_VERSION_MAX_ALLOWED >= 1060
+// #  define ARCHIVE_HMAC_USE_Apple_CommonCrypto
+// # endif
+// #endif

I understand wanting to make bsdtar hermetic because its being used as a tool, but shouldn't we be avoiding modifying sources when submitting modules to the BCR? This feels like a patch that should be either done in a patch in the repo that wants it to be hermetic (e.g. https://github.com/aspect-build/bsdtar-prebuilt) and/or submitted as a feature request upstream to libarchive.
Regardless, I'll be fixing it since it was in the patch prior to this one.

Yep, that's the one. I don't have a super strong philosophical opinion on where the patch should live but compiling against and OSX SDK is a common pain point so I suspect others may want this patch as well.
I suppose if we're very motivated we could patch it to wrap this in another #define and allow configuring it with a build flag? Or add the feature upstream as you suggest

Some kind of #define in the upstream that we could configure would probably be the best call imo!
anyways here's the fix: https://github.com/bazelbuild/bazel-central-registry/pull/2271

hey @zaucy - any idea why we get
Action failed to execute: java.io.IOException: ERROR: src/main/native/windows/process.cc(202): CreateProcessW("C:\users\runneradmin\_bazel_runneradmin\snmkx6sz\execroot\_main\external\aspect_bazel_lib~~toolchains~bsd_tar_windows_amd64\tar.exe" --create --file bazel-out/x64_windows-fastbuild/bin/tar_empty.tar @bazel-out/x64_windows-fastbuild/bin/_tar_empty.mtree.txt): This version of %1 is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher.

when running this binary on windows?
https://github.com/bazel-contrib/bazel-lib/actions/runs/10913564506/job/30290275800

Oh it's an ELF-format binary.


TEP-0114: Remove Feature Flag enable-custom-tasks

Changes

Custom Tasks have been promoted to the beta version, hence, enable-custom-tasks is not required anymore. This commit removes the feature flag.
/kind misc
fix #5861
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Removed the feature flag `enable-custom-tasks`.

/retest

/lgtm


Update some nugets

Update some nuget packages

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.11%. Comparing base (be0090d) to head (c8ffad7).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3143      +/-   ##
==========================================
- Coverage   84.81%   82.11%   -2.71%
==========================================
  Files          79       76       -3
  Lines        3279     3125     -154
  Branches      555      526      -29
==========================================
- Hits         2781     2566     -215
- Misses        498      559      +61

Flag
Coverage Δ

Linux
82.11% <ø> (ø)

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM pending the question about the Autofac upgrade.

@martincostello: I updated xUnit package to 2.9.2, but in Swashbuckle.AspNetCore.ApiTesting.Xunit project it is 2.4.1. Should I delete VersionOverride tag?
<PackageReference Include="xunit" VersionOverride="2.4.1" />

No, leave all the version overrides alone - otherwise a future release of our xunit package would force an upgrade on people that they might not otherwise want.

Thanks for being our human dependabot 🤖 😄


log all inner exceptions

Fixes this problem:

and now outputs this:

This could be further optimized by moving var innerException = ex.InnerException; before the if statement and referencing the newly created innerException variable in the if statement. That being said, as it stands this PR adds value, thanks @spottedmahn!

Hey @gsacavdm - I like it.  I was pondering that actually... nice to have some confirmation about that!


Add reuse compliance

SPDX header
CI check
Readme badge
issue template config from org

@st3iny you might want to change https://github.com/nextcloud/calendar-availability-vue/pull/333/files#diff-380d439957b1ea48f4624d231e040af8bb63c44d41bb7d5bba5d7d2d3ea9c809 from AGPL3+ to MIT, else the lib is basically AGPL not MIT. I suspect this to be a simple c&p issue or file template issue.

@st3iny you might want to change #333 (files) from AGPL3+ to MIT, else the lib is basically AGPL not MIT. I suspect this to be a simple c&p issue or file template issue.

Good point. It is meant to distributed under the library's license, MIT.


Deployment Startup Order

Right now the worker on the dataset queue isn't waiting for virtuoso to start up and will produce errors while trying to communicate with it. Ideally the deployment would wait for Virtuoso to start up before starting the workers. Alternatively the source code of the worker could wait for an available triple store.
With kubectl, I can write a shell script that utilizes kubectl wait to pause the deployment of deployments until a particular deployment it ready. This will require a ReadinessProbe on the Virtuoso deployment; I think an HTTP GET should be enough of a canary to make the claim that Virtuoso is ready.

Merged in #48


Signal Subscription Suspension

Hi.
Sometimes it is useful to suspend observation for a period of time and to accumulate data during this pause.
As an example, you could think about a view controller which starts observation at viewWillAppear: and it suspends observation at viewDidDisappear:.

It seems Travis fails to sign code only on some jobs (I don't know why)

Thanks for the contribution @muccy. However, I'd like to keep Signals as lightweight as possible and your changes seem like functionality that isn't absolutely required.


Add the possibility to map to multiple remotes in the "deployment-config"

It would be nice to add the possibility to have multiple remote configs file and to switch between them.
It's common to have a config for the test server and another one for the production server.
This plugins has this behavior for Sublime Text 3

Hi @Tareck117 ,
I understand your demand, but I think that this plugin is not the best tool for your production deployment. Originally, it has been developed for the process development.
But I will think about it after fixing all other bugs.
Thank you for your feedback.

@RPDeshaies ,
This is duplicate issue from #12 .
There is a workaround but it require a little bit more work.
https://github.com/amoussard/sftp-deployment/issues/12#issuecomment-140293991
I think we should close this issue since is a duplicate.