[PoC] Default prop migration sample without new API

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

Closed as it was for PoC only


##[error]The deployment definition is invalid; TemplateLink RelativePath can only be used with api-version '2020-06-01' or later.

Question, Bug, or Feature?
Type: Bug/Feature
Enter Task Name: ARM Template Deployment
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

Issue Description
The relativePath property for Linked Templates is failing validation with an API error when I attempt to validate a collection of linked ARM templates in an ADO pipeline.
The exact error message is: ##[error]The deployment definition is invalid; TemplateLink RelativePath can only be used with api-version '2020-06-01' or later.
The resource code I'm attempting to deploy is as follows:
{
      "name": "LinkedServices",
      "type": "Microsoft.Resources/deployments",
      "apiVersion": "2020-10-01",
      "properties": {
          "mode": "Incremental",
          "templateLink": {
              "relativePath": "LinkedServices/_LinkedServicesMaster.json",
              "contentVersion": "<IP_ADDRESS>"
          },
          "parameters": {
              "uriTemplate": {
                  "value": "[replace(variables('uriTemplate'), '{0}', 'LinkedServices/{0}')]"
              },
              "appName": {
                  "value": "[parameters('appName')]"
              },
              "location": {
                  "value": "[parameters('location')]"
              },
              "regionShortName": {
                  "value": "[parameters('regionShortName')]"
              },
              "environment": {
                  "value": "[variables('keyVaultEnvironment')]"
              },
              "adfName": {
                  "value": "[parameters('adfName')]"
              },
              "keyVaultName": {
                  "value": "[variables('keyvaultName')]"
              }
          }
      }
  }

Hitting this too.. pl provide an ETA. Thanks!

I have the same issue. In my case I get: TemplateLink RelativePath can only be used with a Uri in api-version '2020-10-01' or later and I'm using "apiVersion": '2021-04-01' —ETA please? Thanks

I realized that apparently there are two tickets relating to this (Including this ticket)
Here is a link to the other ticket: https://github.com/microsoft/azure-pipelines-tasks/issues/14890


First pass review 5.2.0

Review JwtSecurityTokenHandler and Saml2SecurityTokenHandler for consistency of comments, apis and parameters

https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/644


Mind adding generic openAI support?

A lot of local servers use openAPI spec. tabbyAPI, textgen, llama.cpp server, etc. Is it possible to add support for that? ollama is very limiting and I want to use this with 70b+. I'm of course going to kludge the code to try but you may be able to support many projects all at once by generalizing one API.

couldnt you use litellm to act as a passthrough?

It was easier editing the code but I got stuck on the search. Now someone has made it happen so we can finally use this: https://github.com/stitionai/devika/pull/70

Not sure I understand. Why not using litellm? It's easier to handle models with litellm than having to deal with changing the URL. Mistral large and its function calling seems promising.

because I'm not using an API. i'm using my own model through textgen

You can use litellm to point towards OpenAI API and change the URL to point to the textgen local URL apparently.

It's 10x easier to just add the endpoint parameter to the openAI initialization than to run another proxy server.

Isnt that what https://github.com/stitionai/devika/pull/442 does?


Fatal error: Class 'Upwork\API\AuthTypes\MyOAuth' not found

Fatal error: Class 'Upwork\API\AuthTypes\MyOAuth' not found in C:\xampp\htdocs\workflow\vendor\upwork\php-upwork\src\Upwork\API\Client.php on line 55

Hello @spali90 ,
what configuration parameters contains your script. It seems that you specified own class which can't be found. This library doesn't use such class as "MyOAuth"


Ignoring all folders

Is it possible to ignore all folders?

Yes. Pass nodir: true in the options object.  From the readme:

nodir Do not match directories, only files. (Note: to match only directories, simply put a / at the end of the pattern.)


[distributed][models] add out-of-tree model registration support for distributed inference

fixes https://github.com/vllm-project/vllm/issues/5657

hmmm i believe this is a direct API for arbitrary code execution which might cause CVEs...

Basically, every worker needs to know & load users' registered model before loading the weights. The solution is to add a --worker-init-callback-script argument, where users can provide a script for vLLM to run before worker loads the model.
Kind of make sense if we want to enable out-of-tree model registration.
We can also change it to some intuitive name like --oot-model-definition-script , from the functionality perspective.

hmmm i believe this is a direct API for arbitrary code execution which might lead to CVEs...

that's actually the requirement of out-of-tree model registration, right? they want to execute part of code that is not inside vLLM.

arbitrary code execution might be bad, let's investigate with further discussions.


multilingual bert-training size

Hi, could you please specify how large is the training size of the multilingual version of BERT, in terms of GB?
Thanks

This is the dataset that they used: https://huggingface.co/datasets/wikipedia


Changing es-master svc to ClusterIP

BUG_REPORT
As I'm using AWS EKS, LoadBalancer type exposes my elastic masters. I don't need that, so I change es-svc, removing type: LoadBalancer, so that type will automatically change to ClusterIP
But deploing fails with strange:

Error: UPGRADE FAILED: Service "elasticsearch" is invalid: [spec.ports[0].nodePort: Forbidden: may not be used when type is 'ClusterIP', spec.ports[1].nodePort: Forbidden: may not be used when type is 'ClusterIP']

But there is no "nodePort" in any part of config files in the repo, where does it takes them from?

The problem is reproducing only on helm upgrade. Delete, purge, install - then no problem


SukiHost.ShowDialog becomes ineffective

I have two sukiWindows, one of which is a login window. After the login is completed, one sukiWindow is closed, and the other sukiWindow is launched. Then calling SukiHost.ShowDialog becomes ineffective.
The login window closes, and the code to open another sukiWindow is as follows:

This is indeed one of our problem. As Avalonia does not have built-in Dialog System, we wanted to make a super simple one.
However, as it relies on singletons to be called anywhere, it does not support multiple SukiWindows well. So basically only your first SukiWindow will get it.
More info : https://github.com/kikipoulet/SukiUI/issues/115
I had already thought that we could do a window style to have the style of SukiWindow for other windows and keep the Dialog system of the SukiWindow for the mainwindow.

Yeah right now the current implementation, which was only really meant to be temporary, attaches to the first-opened window once at instantiation and that's it.
There are some things I could do which would make this work better, and perhaps open it up to be addressable per-window.
I can take a look to see what the absolute minimum changes I'd need to make to make this happen, assuming I can do it without breaking the existing API (which should be possible) then it can probably make the 6.0 release.

Thank you for the prompt reply. I am very much looking forward to the next version update to fix this feature.


IOB frame count is 40 not 42.

Because IOB's live at the top of CLB_IO_CLK frame, the maximum on artix7
should be a base address of 0x004015A7, which from a base address of
0x00401580 is 40 frames.

Looks like this PR is wrong, there are definitely 42 frames https://github.com/SymbiFlow/prjxray-db/blob/master/artix7/xc7a35tcpg236-1.yaml


Logging in with Discord display name vs username

When I first created an account on craig-stars, it used my alias on the Discord server (ymmot_98292). That works fine from my home computer. But when I try to log on from my laptop, it picks up my general Discord username (invariate), so I don't see the games I saved under the original account.
I'm not sure if this is an issue or not, it may be a nuance of Discord that I'm missing.

I checked the user database. invariate has a discord id of 76754****  and ymmot_98292 has a discord id of 12149*****.
A while ago, discord did a user update thing to remove the discriminators from usernames (https://discord.com/blog/usernames), but that doesn't seem related to this. It seems like you have two discord accounts (at least by the ID)


Ignore common label-values in ProxyResponseHeap sort function

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
Change ProxyResponseHeap.Less function to compare only the label-values that are not in both series.
Some components are sorting the response before adding external labels, returning sets that might not be sorted after that. Because common label-values don't make a difference when comparing two label sets, ignoring these common external labels can help sort the response in the heap again.
I described the bug and how to replicate in https://github.com/thanos-io/thanos/issues/6257#issuecomment-1514160495
Verification
I added a few tests for ProxyResponseHeap that I used to replicate the bug and test the changes.

Is this and #6296 achieving the same outcome, but through different means? 🤔

I think we need both for this issue

Ah I didn't realize the first time that st.LabelSets() were the external labels in the store. I added a field to store them in advance.
Also, did I break the end-to-end tests? :thinking:

Thanks for the changes 👍 I ran the proxy benchmark locally using go test -bench BenchmarkProxySeries ./pkg/store/... -run none -count 5 -benchmem and noticed that this implementation introduces a memory and CPU regression. I would suggest the following changes to reduce the impact a bit: https://github.com/wallee94/thanos/pull/1. Here are the results from the main branch, this branch and proposed changes:
thanos $ benchstat main.out branch.out branch-optimized.out
name \ time/op                                                                          main.out     branch.out    branch-optimized.out
ProxySeries/1000000SeriesWith1Samples/4_client_with_1_samples,_250000_series_each-8      126ms ± 3%    250ms ±10%            159ms ± 2%
ProxySeries/1000000SeriesWith1Samples/single_client_with_1_samples,_1000000_series-8     177ms ± 1%    179ms ± 3%            168ms ± 0%
ProxySeries/100000SeriesWith100Samples/4_client_with_25_samples,_25000_series_each-8    13.5ms ± 4%   25.3ms ± 2%           16.5ms ± 2%
ProxySeries/100000SeriesWith100Samples/single_client_with_100_samples,_100000_series-8  16.9ms ± 0%   17.6ms ± 3%           17.9ms ± 1%
ProxySeries/1SeriesWith10000000Samples/4_client_with_2500000_samples,_1_series_each-8   16.4µs ± 2%   16.8µs ± 2%           16.4µs ± 1%
ProxySeries/1SeriesWith10000000Samples/single_client_with_10000000_samples,_1_series-8  7.53µs ± 1%   7.82µs ± 1%           7.74µs ± 2%

name \ alloc/op                                                                         main.out     branch.out    branch-optimized.out
ProxySeries/1000000SeriesWith1Samples/4_client_with_1_samples,_250000_series_each-8     83.9MB ± 0%  243.9MB ± 0%           83.9MB ± 0%
ProxySeries/1000000SeriesWith1Samples/single_client_with_1_samples,_1000000_series-8    83.4MB ± 0%   83.4MB ± 0%           83.4MB ± 0%
ProxySeries/100000SeriesWith100Samples/4_client_with_25_samples,_25000_series_each-8    7.64MB ± 0%  23.64MB ± 0%           7.64MB ± 0%
ProxySeries/100000SeriesWith100Samples/single_client_with_100_samples,_100000_series-8  8.21MB ± 0%   8.21MB ± 0%           8.21MB ± 0%
ProxySeries/1SeriesWith10000000Samples/4_client_with_2500000_samples,_1_series_each-8   7.85kB ± 0%   8.81kB ± 0%           8.23kB ± 0%
ProxySeries/1SeriesWith10000000Samples/single_client_with_10000000_samples,_1_series-8  3.52kB ± 0%   3.71kB ± 0%           3.77kB ± 0%

name \ allocs/op                                                                        main.out     branch.out    branch-optimized.out
ProxySeries/1000000SeriesWith1Samples/4_client_with_1_samples,_250000_series_each-8        302 ± 0%  2500311 ± 0%              308 ± 0%
ProxySeries/1000000SeriesWith1Samples/single_client_with_1_samples,_1000000_series-8       152 ± 0%      154 ± 0%              154 ± 0%
ProxySeries/100000SeriesWith100Samples/4_client_with_25_samples,_25000_series_each-8       251 ± 0%   250259 ± 0%              257 ± 0%
ProxySeries/100000SeriesWith100Samples/single_client_with_100_samples,_100000_series-8     132 ± 0%      134 ± 0%              134 ± 0%
ProxySeries/1SeriesWith10000000Samples/4_client_with_2500000_samples,_1_series_each-8      130 ± 0%      146 ± 0%              136 ± 0%
ProxySeries/1SeriesWith10000000Samples/single_client_with_10000000_samples,_1_series-8    78.0 ± 0%     80.0 ± 0%             80.0 ± 0%

If we want to completely the impact of ignoring external labels, we could probably add them in a separate field when sending data from stores, but for now we should be okay with a small regression.

Oh wow, I didn't expect so much memory regression. The new changes look great to me, I've merged them and the latest changes in main. Thanks again @fpetkovski !

@wallee94 have you checked whether this change solves your problem?

@fpetkovski Yes! I deployed the branch today to our dev cluster. We were seeing duplicated series from the ruler and sidecars, and this change fixed the issue


factor out PoolTable

more modular code and unittest
micro optimizations for findPool

I tried the following things to speed up findPool, but nothing was faster than the existing binary search.

single branch in binary search
separate array of baseAddr
unroll binary search

The only optimization I found was to help dmd a little with register allocation.

Maybe even move the table and its tests into a separate module

OK, done.

Apart from nitpicks, LGTM.

Auto-merge toggled on

Thx


[Feature Request] angimation Inverse staggering

Do you want to request a feature or report a bug?
Request a Feature
What is the current behavior?
We can define staggerings for animations, but they are incremental. From 0 to length...
What is the motivation / use case for changing the behavior?
Is possible to have staggering working inverse. Form length to 0? This way we can make animations that build and unbuild animations, with ng-repeat. Perhaps there is another solution.. But when animating with staggering is a common use case to reverse the animiations...

You can obviously do it by explcitly calling $animate.leave(...) on the elements in reverse order (similar to how it is done in the second example here, but in reverse order).
It would be interesting to have this possible through CSS-only animations.


Station Events never run

Description
Station Events never run which is very unfortunate if you want to test something with events.
Reproduction
Start survival round
Wait an hour
Nothing happens
Screenshots

Additional context
I am running this server on the most recent build with playercount overridden to 100.

you have to enable events


In section "Map your Azure DevOps project to your local model store and projects folder" step 3 to step 4 seems to be missing something

Step 3 says: "Map the Metadata folder of your team project to the root folder of the model store on your local drive (Typically K:\AOSService\PackagesLocalDirectory), an example is shown in the image below."
Step 3 image shows: https://learn.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/dev-tools/media/vsofolders21.png
Then step 4 says: "Click Map, and on the next dialog, click No."
What I think is missing:
No instruction is given on how to start the mapping. What I did was use File > Source Control > Advanced > Map
What is confusing:
The image shows c:\packages\ which makes sense if you're doing a tutorial not on a Cloud Hosted VM.

@JTWWI, thank you for your feedback. We have passed this feedback onto the product team for consideration.


RND-261 - Full access authorization mode

I may have overlooked it... but if not... could you add at least one test, in local.ownership-tests.http, to show that a full-access token (roles: ['host']) can access a resource created by one of the vendor tokens?

Yes - Added a test for POST and DELETE of a student using FULL_ACCESS  auth


[Q] Can't get this to work and log to the Console UI within Hangfire

Hey.
Might be me, but I'm using .net 7, Hangfire 1.8.3 and I cannot get this to work.
I'm configuring it in my program.cs
builder.Services.AddHangfireConsoleExtensions();
But I can't see any logs appearing within the hangfire jobs.
I'm using Microsoft.Extensions.Logging.ILogger<T>
Any ideas?  Just no logs are outputting.

If you check out this repo and change the examples to .net 7, does it work then?
If yes then it's most likely in your project, if not then it might be a bug.

Thanks, I've just checked out and created a new project (NET7) and the example seemed to have worked.
I've cross referenced and appears it was an issue with not adding UseConsole() & the ordering of the dependencies 🤦
Thanks @AnderssonPeter
Is it any interest to you to have the NET7 example within the code base? I can PR in if so, just .net 7 is slightly different to core3.1 in regards to the program/startup classes

I don't think i need a PR, I will port over all the examples when .net 8 is released, but thanks for the offer.


Add icon for NuGet packages

We now have a URL: https://cloud.google.com/images/devtools-icon-64x64.png.
Time to modify the project files...


Improve developer experience with default service automatically created

This is a small improvement to endpoints:

Don't require mqtt endpoint to be specified when infra config does not enable mqtt
Instead of throwing error on missing services, create the default endpoints for those services

Overall this is more intuitive for developers creating address spaces

@enmasse-ci run tests testcase=ApiServerTest


Use Verify.SourceGenerators

I created an extension to Verify specially for snapshot testing SourceGenerators  : https://github.com/VerifyTests/Verify.SourceGenerators
I would appreciate your thought on this approach

Any thoughts on the failing tests? I am thus far unable to reproduce on ubuntu locally

@SimonCropp If I now run the generator unit tests, I'm getting documents that are very much long and cryptic (ever since the new version of Verify.SourceGenerators). Can you take a look? I would be happy to file a new issue in the Verify.SourceGenerators project however I'm stuck doing something else for the next 24 hours


Add dummy_weights mode for mixtral tests

Many ttnn devs don't have access to either the CI weights in /mnt or the weka weights in /proj_sw/ and request a dummy_weights mode. This enables that and sets it as default for the model_perf test that doesn't need real weights anyway.

It would be useful to add a quick CI test to verify the feature.


Can this be only run on CUDA enabled pytorch?

I am getting assertion error "Torch version is not compiled for CUDA support" when try to run on macosx Mojave.

@naysumyat
A workaround:

Open up test.py
Comment out net.cuda() and img = img.cuda() lines
Add map_location argument to torch.load: net.load_state_dict(torch.load(cp, map_location=torch.device('cpu')))

@naysumyat
A workaround:

Open up test.py
Comment out net.cuda() and img = img.cuda() lines
Add map_location argument to torch.load: net.load_state_dict(torch.load(cp, map_location=torch.device('cpu')))

Thank you. it worked.


Html head values are ignored

Html document head informations are completely ignored.

I also wrote a test to check if styles work on jest. It works on jest but it is not put in to the generated remote file.
Also title does not change. as you see on the screenshot above.
test below and it is passing:

@s4847043 I'm not 100% sure, but the use case that you're describing might be the same as what's mentioned in this issue: https://github.com/codesandbox/sandpack/issues/32. If that's the case then it might not be possible with the template you're using.


Adding and Removing public config take long time to reflect

Description
It take a very long time to add or remove a public configuration.
When you click remove and the tab loads, then the config input disappears, but when you reopen it, it still appears, and you have to wait a long time and a refresh for it to disappear. The same happens in the add.
Logs/Alerts
Threefold Dashboard: Your Farms.webm

Issue update
Investigation and Solution:

Created the config object and set the value of the node public config inside it
Send the config object to the node as an event to update the UI
Created a separate function for toggling adding/removing the config to make it readable and easier to code.

Work Completed:

The bug should be fixed at https://github.com/threefoldtech/tfgrid-sdk-ts/pull/2052

Now it sometimes doesn't let you save a configuration, even if the value is valid but the save button is disabled.

screen-capture (3).webm

And when I change the values, despite closing the dialogue without saving the value, it's saved, and I can do it more often again. The only way is to reload the page.

screen-capture (4).webm

And as you can see in the video, some of the values aren't valid, but the save button is still enabled (validation isn't rechecked), which will give you an error after the save button is pressed.

Issue Update
Work in Progress
Currently addressing the issue related to transitioning from the current public configuration <Current state> to the node configuration <Default state>.
For context, when the component is mounted, the node's public configuration is initially set to null or remains unset. This situation results in undesired behavior, as demonstrated below in a Vue.js template:
<template>
  <v-text-field v-model="config.ip4" /> <!-- User's input changes both the form and the node config -->
</template>

<script lang="ts">
const config = ref<NodeConfig>(node.publicConfig) // Initial value is null
</script>

In this scenario, when the user modifies the IP4 field, the config value also changes. To rectify this, the correct behavior should involve taking a snapshot of the default node configuration, such as:
<template>
  <v-text-field v-model="config.ip4" /> <!-- User's input changes the form, but not the node config -->
</template>

<script lang="ts">
const config = ref<NodeConfig>({ ...defaultNodeConfig }); // Use a copy of the default config
</script>

By creating a copy of the default configuration, any modifications made by the user will only affect the form, and not the underlying node configuration. This approach allows for effective comparison between the default state and the current state, addressing the identified issue.

Issue update
Work Completed:

Extracted configuration fields to improve code readability.
Improved consistency in variable naming.
Removed redundant comments and added explanatory comments where needed.

The fix should be implemented in https://github.com/threefoldtech/tfgrid-sdk-ts/pull/2095

Verified,
Devnet, 0eda4cc.
The public config adding and removing is now applied instantly.
screen-capture (6).webm
I created another issue for the other bugs.


Cannot pull to Docker Hub

Expected behavior
Connect to Docker Hub
Actual behavior
Server 500 error
Information about the Issue
(HTTP code 500) server error - {"message":"Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)"}
Steps to reproduce the behavior
Use Kitematic to download MySQL container
Error occurs.

Please make sure that you're on a stable connection and use a solid DNS such as Google DNS.


broken link fixed.

Hi @v-rajagt - Thanks for creating a PR to fix the broken links on the Mobile Apps landing page.
Hi @codemillmatt - Could you review this PR? I think that the relative links will work if you remove ".md". This commit should be moved to the private repo so you can test updated links on staging.
The PR review team can help with this. Or @v-rajagt could re-create the PR in the private repo.
Move public changes by pulling to the private repo
Thanks.

@v-rajagt Do you want to remove the locales from the links? Sometimes, the person who creates the PR oddly cannot edit it. If you can't, let me know and I will do it.
-PR review team

So we can get these landing page links updated, I'll make the revisions.

@codemillmatt I've removed the locales. Because the new links are all external URLs, it's probably safe enough to merge to master from here without testing on staging. I copied and pasted each link to test in a browser and they work. We can merge the PR if/when you sign off. Thanks.

Thank you so much @ktoliver and @v-rajagt!
Looks great to me.
#sign-off

@codemillmatt: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


CIP-???? | CIP-30 ext: Bulk transaction signing

Replaces previous PR https://github.com/cardano-foundation/CIPs/pull/443 by adopting CIP-30 extension framework as well as to-be-merged CIP-30 namespace PR https://github.com/cardano-foundation/CIPs/pull/577.

(rendered proposal in branch)

@Scitz0 thanks for doing this. 🤓 I noticed you haven't closed https://github.com/cardano-foundation/CIPs/pull/443 yet; I would recommend closing it (or allowing us to) unless you post a reason for leaving it open.

I'm not the owner of that PR so I can't close it. Anyone with access feel free to do so. I added Martin who created that one to the author section and just copied most content and adjusted to fit into the updated cip30 workflow.

I will look into the other stuff you mentioned at a later time. Away on a team meetup at the moment.

@Scitz0: I'm not the owner of that PR so I can't close it.

my apologies, I must have been looking at the header of this PR when I thought I was checking the other one 😖 ... it's closed now.

I have now updated based on input and rewrote the text a bit. Please check https://github.com/cardano-foundation/CIPs/pull/587/commits/8c1591ca1d405a7d3e6ed9867282b3e1822d4873 for changes.

@Scitz0 the 2 pending wallet API proposals were confirmed as candidates at the CIP meeting today... congratulations & please rename your CIP content folder to CIP-0103 🤩

@Scitz0 I've put this on next CIP meeting agenda (https://hackmd.io/@cip-editors/87) in the hope of moving this forward; I'll follow the lead of the more wallet-oriented CIP editor(s) & approve this as soon as it passes their technical review.

@Scitz0 you were looking for progress updates & we did discuss these in yesterday's CIP Editors meeting.  We all think this is ready to go (cc @Ryun1 @Crypto2099) once we decide whether, or how, to present a mitigation strategy for the potential security issue that @yHSJ identified (if I remember correctly) when https://github.com/cardano-foundation/CIPs/pull/733 was being discussed.
@yHSJ if we could either dismiss that problem for this CIP itself, or if not then you and/or @Crypto2099 could contribute some "safe" language to characterise the problem here (hopefully stopping short of giving away an exploit), then we should be ready to merge this afterward.

We could merge https://github.com/cardano-foundation/CIPs/pull/733 with this CIP. As this one hasn't been finalized yet this makes it easier.
@yHSJ Do you want to take a stab at this or should I try to copy & paste what you have added in your CIP-111 draft into this one?

@rphair @Scitz0
I'm sorry I've missed this! I've been incredibly busy over the past 2 weeks. I am a little out of the loop here, so I apologize. Please feel free to ping me and fill me in on Discord.

@yHSJ if we could either dismiss that problem for this CIP itself, or if not then you and/or @Crypto2099 could contribute some "safe" language to characterise the problem here (hopefully stopping short of giving away an exploit), then we should be ready to merge this afterward.
I am not sure these two issues are related. I think CIP-103 is great (we use at JPG Store), but it is solving a different problem from CIP-111. CIP-111 (or some other solution) should be implemented regardless of the CIP-30 signing endpoint used (and perhaps, even regardless of the wallet standard implemented, although currently CIP-111 only names CIP-30 endpoints directly). Why would CIP-103 be blocked by the problem described in CIP-111?

We could merge https://github.com/cardano-foundation/CIPs/pull/733 with this CIP. As this one hasn't been finalized yet this makes it easier.

Similar statement as above. It doesn't make sense to merge the two CIPs as they address different problems and they don't really line up perfectly.

By the way, this is how we currently handle it in Eternl, by caching both signed and submitted transactions to be used to resolve utxo inputs and preventing signing if there are unknown inputs.

This is wonderful to hear! Does it follow CIP-111 (even accidentally)? If so, it would be great to list it as an implementation. Although, that conversation is probably best had over there https://github.com/cardano-foundation/CIPs/pull/733

Ok great


MySQL Password in Ubuntu Docs

When installing using the Ubuntu wiki page I installed MySQL and set a root password. I recommend adding to the docs that users should add the root password to grails-app/conf/DataSource.groovy in the production environment before compiling.

Added it. Thanks!


Fix golint in v1.1

Cherry pick b0efd685a959265fa3fb7c9a2032bc01e2a494fb from #848 into branch v1.1.
/cc @containous/traefik

LGTM


temporary files should be created in the same location as destination folder

There is an important reason why the default location of the temporary files should be the same as the destination: this could be on a mapped network drive and if temp is on another disk moving the finished file to the destination could take ages, adding unnecessary delays to the whole conversion process. If the locations do match the move is a rename and this is instant.
Also there are some other concerns regarding the size of the system temporary folder, which may not be big enough to store movies.

Check to see if your h265ize --help lists a -g option. That will allow you to set the temp directory. If it doesn't, your version does not use a temp directory.
Also, the destination is not used as the temp folder because often people have programs that watch the destination for new files/changes. If the destination was used as the temp directory, it would constantly trigger a watching program (such as plex) to update the library every time x265 flushed its buffer.


Add tests

Just for increase coverage.

Coverage increased (+1.2%) to 99.686% when pulling 1e28777e6e1b21a86e9bf18e1e733572239acbe6 on add-tests into 6d53978936a6fa80a75655d924595e0b9995c4e9 on master.

Coverage increased (+1.3%) to 99.765% when pulling<PHONE_NUMBER>aea99c518441d87d9a1ad825ea2399 on add-tests into 6d53978936a6fa80a75655d924595e0b9995c4e9 on master.

Coverage increased (+1.3%) to 99.848% when pulling 472e0f52e8bb16967c75af37b4d395a7a0922dd2 on add-tests into 6d53978936a6fa80a75655d924595e0b9995c4e9 on master.


No data for some Dashboards after 3 days?

Error is - azure sentinel "no data for the given query"
Audit & Sign-ins working OK, no Exchange online, No Identity & Access, No Office 365, etc...
It could be that I've done something dumb?
Feedback on Data Connectors page = why not provide a different colour + "connected" or "configured" once they are connected/working? As it stands they all simply sit their wanting to be connected...? But there is no feedback on this page as to the connectors that are/are not configured?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddafba5c-f652-3d1a-e4b4-f8eedc14e740
Version Independent ID: ea24a163-6533-24eb-630c-559bd1549dc7
Content: Onboard in Azure Sentinel Preview
Content Source: articles/sentinel/quickstart-onboard.md
Service: sentinel
GitHub Login: @rkarlin
Microsoft Alias: rkarlin

@dcaddick Thank you for your query . We will investigate and update further.

Can you please let me know the best place to provide feedback and discuss issues for the Sentinel SIEM please? Is it here, Yammer, or elsewhere?

@dcaddick Please use the link https://feedback.azure.com/forums/920458-azure-sentinel for providing feedback related to Azure sentinel . The product is still in preview hence some thing may not work as expected and things would change without notice during this period hence we suggest to test it on non-critical workloads. Product feedback can be provided using uservoice link provided above. and any documentation feedback can be provided on Github while for any issue troubleshooting we would suggest to open a MSDN thread here. https://social.msdn.microsoft.com/Forums/azure/en-US/home?forum=opinsights
Hope this helps.
Thank you

@rkarlin Could you please help the customer with this issue ?

Hi, you can get involved with the Azure Sentinel tech community here: https://techcommunity.microsoft.com/t5/Azure-Sentinel/bd-p/AzureSentinel
thanks
#please-close


Schedule Events Deleted after a Page Refresh

Hi,
I might be missing something here, but it seems like the calendar events are gone after I refresh the web page.
Should I take care of the data storage or is there something that I'm missing?
Thanks

The TOAST UI calendar only renders the entered event.
No data is stored separately.
You need to manage schedule data in your project.
We provide a default popup for convenience and fire the beforeCreateSchedule, beforeDeleteSchedule, and beforeUpdateSchedule events.


[Task] refeactor shenyu-logging-module

Description
refeactor shenyu-logging-module,refeactor logging-common-module
Task List
1.refeactor shenyu-logging-common module, extract shenyu-logging-common.
2.shenyu logging module will develop with factory strategy and comsumer strategy.

I will do it after finishing shenyu-logging-aliyunsls


Error while opening Git Extension "Access to the path 'c:.gitconfig' is denied" .

I am unable to save any config setting because of which unable to add any Diff tool in Git Extension.

Got the solution by going into thefolder where GitExtension is intsalled and then running GitExtension.exe as Administrator and then saving config file from there. This will create the config file if not present already.


[W6.1h][T15-B4] Deepak Buddha

Add Printable interface for Address, Name, Email, and Phone

@deep4k
Some comments added. Please ack & close the PR after reading comments.


Command-line output is cleared when focusing a different program window

Describe the bug
Vim in the terminal doesn't seem to support the FocusGained or FocusLost events.
But in some terminals (like xterm and st), it's possible to restore them by setting 't_ti' and 't_te' appropriately.
However doing so makes Vim redraw the screen and clear a multi-line output of an Ex command when focusing a different program window (like the one of the web browser for example).
To Reproduce

Write these lines in /tmp/vimrc:
 let &t_ti = "\e[?1004h"
 let &t_te = "\e[?1004l"
 exe "set <S-F18>=\e[O"
 exe "set <S-F19>=\e[I"
 fu! s:do(event) abort
     if exists('#'.a:event)
         exe 'do '.a:event.' <nomodeline> %'
     endif
 endfu
 nno <silent> <S-F18> :<c-u>call <sid>do('FocusLost')<cr>
 nno <silent> <S-F19> :<c-u>call <sid>do('FocusGained')<cr>
 augroup restore_focus_events
     au!
     au FocusGained * echom 'FocusGained was fired'
     au FocusLost * echom 'FocusLost was fired'
 augroup END

From xterm, start Vim with this minimal vimrc:
 $ vim -Nu /tmp/vimrc

Run an Ex command whose output contains multiple lines:
 :echo "foo\nbar"

Focus a different program window (web browser, email client, ...).

Focus back the xterm window.

The output of :echo "foo\nbar" has been cleared.

Expected behavior
I would expect the output of :echo to have been preserved even after focusing a different program window.
Environment

vim --version: VIM - Vi IMproved 8.1  Included patches: 1-1282
OS: Ubuntu 16.04.6 LTS
Terminal: st

Additional context
gVim does support FocusGained and FocusLost, and when you run an Ex command from gVim, whose output contains multiple lines, you can focus a different window without the command-line being cleared.
So, making Vim in a terminal preserve a multi-line output when focusing a different window, would make the latter more consistent with gVim.

The previous minimal vimrc can be reduced to these 2 lines:
let &t_ti = "\e[?1004h"
let &t_te = "\e[?1004l"

But if you want to avoid E349, you need these 2 additional statements:
exe "set <S-F18>=\e[O"
exe "set <S-F19>=\e[I"

If you want the code to be useful, you need these 7 additional lines:
fu! s:do(event) abort
    if exists('#'.a:event)
        exe 'do '.a:event.' <nomodeline> %'
    endif
endfu
nno <silent> <S-F18> :<c-u>call <sid>do('FocusLost')<cr>
nno <silent> <S-F19> :<c-u>call <sid>do('FocusGained')<cr>

And if you want the events to be restored in all modes, not just normal mode, you need 2 additional mappings for each missing mode.

@lacygoill Why close this? Is there a solution already?

@lacygoill Why close this? Is there a solution already?

No, but tweaking these particular terminal options looks like a hack, which is not worth being fixed.  The proper solution is to use the FocusGained and FocusLost events.  They are not yet available in the terminal, but there is a todo item:
https://github.com/vim/vim/blob/bb0956fc65ebe8df1da823f9c4d6a0013d9ba5c1/runtime/doc/todo.txt#L547-L549
As well as an open issue: https://github.com/vim/vim/issues/609.

No, but tweaking these particular terminal options looks like a hack, which is not worth being fixed.  The proper solution is to use the FocusGained and FocusLost events.  They are not yet available in the terminal, but there is a todo item:
https://github.com/vim/vim/blob/bb0956fc65ebe8df1da823f9c4d6a0013d9ba5c1/runtime/doc/todo.txt#L547-L549
As well as an open issue: https://github.com/vim/vim/issues/609.

@lacygoill I don't get it, I have vim --version:
❯ vim --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Aug 04 2021 20:30:52)
macOS version - arm64
Included patches: 1-3290
Compiled by Homebrew

but FocusGained/FocusLost are still not fired within tmux. I have xterm-256color outside, and tmux-256color inside tmux. The focus events seem to be firing outside tmux though...

You might need to set the terminal options :help 't_fe' and :help 't_fd'.
Try something like this:
if &term =~ 'tmux\|screen' && &t_fe == ''
    let &t_fe = "\<Esc>[?1004h"
    let &t_fd = "\<Esc>[?1004l"
endif

See :help xterm-focus-event.
Vim automatically sets these options when it thinks that the terminal supports the focus tracking feature.  Inside tmux, Vim doesn't know the true identity of the outer terminal, so it doesn't set these options for you ($TERM is tmux, screen or some derivatives, but the outer terminal could be anything).

In tmux, you also need to make sure that  the server option focus-events is set:
set-option -s focus-events on

We might want to document this:
diff --git a/runtime/doc/term.txt b/runtime/doc/term.txt
index 811d50752..9c757d0d6 100644
--- a/runtime/doc/term.txt
+++ b/runtime/doc/term.txt
@@ -556,6 +556,11 @@ If this feature is enabled by the 't_fe' sequence, special key sequences are
 sent from the terminal to Vim every time the terminal gains or loses focus.
 Vim fires focus events (|FocusGained|/|FocusLost|) by handling them accordingly.
 Focus event tracking is disabled by a 't_fd' sequence when exiting "raw" mode.
+
+If the feature is not enabled, you might need to set the options like this:
+	`let &t_fe = "\<Esc>[?1004h"`
+	`let &t_fd = "\<Esc>[?1004l"`
+
 If you would like to disable this feature, add the following to your .vimrc:
 	`set t_fd=`
 	`set t_fe=`

@lacygoill That worked, except that now when I the focus moves into vim from another pane (which just has my zsh login shell), at times it adds some weird escape sequence on top of text in vim buffer. Maybe its some tmux-vim interaction @ncim. I'll be away from computer, its late night here. Can add more logs tomorrow, but it could be related to this https://github.com/tmux/tmux/issues/2844. Though my machine is Mac, and I see this only with your suggested change to vimrc & when focus moves within vim (1 out of 20 times). It does not even happen with neovim...

Those are 2 identical SGR sequences:
^[[<0;70;52m

They report the position of the mouse using an encoding scheme allowing to go beyond the ordinate 223 (255 - 32).  It seems that Vim doesn't understand the sequence.  This suggests that the 'ttymouse' option is not set correctly.  It should have the value sgr, because that's the scheme which is used by your terminal to encode the ordinates of your mouse position.
Try to add this in your vimrc:
if &term =~ 'screen\|tmux'
    set ttymouse=sgr
endif

It's probably not set correctly inside tmux, because – again – Vim doesn't know the true identity of the outer terminal.  It relies on the Vim option 'term', whose value is derived from the environment variable $TERM, which – in tmux – must be tmux, screen or some derivative.  Since Vim doesn't know what are the true capabilities of the outer terminal, it falls back on the value xterm when setting 'ttymouse'; in turn, this prevents Vim from understanding the sgr encoding scheme, causing any sequence using this scheme to be simply sent back to the terminal which prints it on the screen.
We might need to either better detect the true identity of the outer terminal and automatically set those options correctly, or at least add a help tag for tmux/screen users, telling them which options they should set, why, and how (i.e. with which values).

or at least add a help tag for tmux/screen users, telling them which options they should set, why, and how (i.e. with which values).

As a suggestion, here is a patch:
diff --git a/runtime/doc/term.txt b/runtime/doc/term.txt
index 811d50752..99f053444 100644
--- a/runtime/doc/term.txt
+++ b/runtime/doc/term.txt
@@ -127,6 +127,42 @@ automatically, you can try using something like this: >
 	  exec "set t_PE=\e[201~"
 	endif
 <
+							*tmux-integration*
+
+If you experience issues when running Vim inside tmux, try this: >
+
+    if !has('gui_running') && &term =~ '^\%(screen\|tmux\)'
+        " better mouse support
+        " see :help 'ttymouse'
+        set ttymouse=sgr
+
+        " enable true colors
+        " see :help xterm-true-color
+        let &termguicolors = v:true
+        let &t_8f = "\<Esc>[38;2;%lu;%lu;%lum"
+        let &t_8b = "\<Esc>[48;2;%lu;%lu;%lum"
+
+        " enable bracketed paste mode
+        " see :help xterm-bracketed-paste
+        let &t_BE = "\<Esc>[?2004h"
+        let &t_BD = "\<Esc>[?2004l"
+        let &t_PS = "\<Esc>[200~"
+        let &t_PE = "\<Esc>[201~"
+
+        " enable focus event tracking
+        " see :help xterm-focus-event
+        let &t_fe = "\<Esc>[?1004h"
+        let &t_fd = "\<Esc>[?1004l"
+
+        " enable modified arrow keys
+        " see :help xterm-modifier-keys
+        execute "silent! set <xUp>=\<Esc>[@;*A"
+        execute "silent! set <xDown>=\<Esc>[@;*B"
+        execute "silent! set <xRight>=\<Esc>[@;*C"
+        execute "silent! set <xLeft>=\<Esc>[@;*D"
+    endif
+<
+
 							*cs7-problem*
 Note: If the terminal settings are changed after running Vim, you might have
 an illegal combination of settings.  This has been reported on Solaris 2.5

@lacygoill I already had ttymouse=sgr so there is something different going on. From my .vimrc:
set mouse=a
if !has('nvim')
    set ttymouse=sgr
    if &term =~ 'tmux\|screen' && &t_fe == ''
        let &t_fe = "\<Esc>[?1004h"
        let &t_fd = "\<Esc>[?1004l"
    endif
endif

OK, a few questions:

The issue happens when you focus back the Vim window, right?

Does it happen outside tmux, or only inside?

How do you focus back the Vim window?  Alt-Tab, left-click mouse, tmux key binding, ...
Does it even matter?

Which terminal are you using?

Can you reproduce in xterm, or is it specific to some terminal(s)?

If there is no issue outside tmux, what's the value of $TERM (again outside tmux)?

If the issue is specific to tmux, then it's probably related to a Vim (terminal) option.  If so, I know how to find which one(s) need(s) to be set, but the debugging process might take some time if you need a few dozen tests to reproduce the issue; which is why – ideally – I would prefer being able to reproduce on my machine (I can't).
The basic idea is to dump all the terminal options in a file outside tmux, then restart Vim sourcing this file.  For each test, you disable half of the file and start a bisecting process, until you find which option is the culprit.
You can dump all the terminal options in a file with :put =execute('set termcap').  The options are not split one per line (which helps to start bisecting); but I have a plugin which does this automatically.

Also, even if you've set ttymouse correctly, make sure that it has not been reset later:
:echo &ttymouse
sgr

And make sure you have the mouse_sgr feature:
:echo has('mouse_sgr')
1

Just checked, it happens outside of tmux inside vim when t_fe & t_fd are not manually set in .vimrc.

IIUC, if t_fe and t_fd are manually set, the issue is present outside tmux, but absent inside.
It might be caused by a terminal option.
If I were you, I would first try to get a diff of :set termcap inside vs outside tmux; both times with t_fe and t_fd set.
The default output is not suitable for a diff (because multiple settings are written on the same line), but I have a plugin which provides a :DebugTerminfo command to format the output 1 setting per line.  You don't need to install the plugin definitively; if you're interested, temporarily add this block in your vimrc:
set pp+=/tmp/.vim
let dir = '/tmp/.vim/pack/debug/opt/debug'
if !dir->isdirectory()
    call mkdir(dir, 'p')
    call system('git clone https://github.com/lacygoill/vim-debug ' .. dir)
endif
packadd debug

Then:

start Vim outside tmux (and with t_fe and t_fd manually set)
run :DebugTerminfo, then :saveas /tmp/inside_tmux.vim
restart Vim inside tmux (and with t_fe and t_fd manually set)
run :DebugTerminfo, then :saveas /tmp/outside_tmux.vim
get a diff of /tmp/inside_tmux.vim and /tmp/outside_tmux.vim

Also, you could get a log file:
$ vim +"call ch_logfile('/tmp/logfile', 'w')"

Reproduce the issue then look for the pattern [< and see whether there is something interesting around it.  As an example, here is what I get when I change the focus from xterm+Vim to a different window, then focus xterm+Vim back, using a left-click both times:
==== start log session ====
  0.000016 : raw terminal output: "^[[2 q^[[2;1H▽^[[6n"
  0.000051 : raw terminal output: "^[[2;1H  ^[[3;1H^[Pzz^[\^[[0%m^[[6n"
  0.000097 : raw key input: "^[[2;2R"
  0.000113 : raw key input: "^[[3;1R"
  0.000151 : raw terminal output: "^[]10;?^G^[]11;?^G"
  0.004814 : raw key input: "^[]10;rgb:3737/3b3b/4141^G^[]11;rgb:dbdb/d6d6/d1d1^G"
  0.008562 : SafeState: Start triggering
  0.012113 : raw terminal output: "^[[26;1H                                                           ^[[27;1H                                                           ^[[28;1H                                                           ^[[29;1H                                                           ^[[30;1H                                                           ^[[31;1H                                                           ^[[m^[[38;2;78;78;78m^[[48;2;208;208;208m^[[32;1H^[[1m^[[7m^[[38;2;135;95;95m^[[48;2;215;215;175m ^[[m^[[38;2;78;78;78m^[[48;2;208;208;208m^[[1m^[[38;2;135;95;95m^[[48;2;215;215;175m[No Name]^[[m^[[38;2;78;78;78m^[[48;2;208;208;208m^[[1m^[[7m^[[38;2;135;95;95m^[[48;2;215;215;175m                                       0,1  100% ^[[m^[[38;2;78;78;78m^[[48;2;208;208;208m^[[33;1H                                                           ^[]2;[No Name] - VIM^G"
  0.012439 : looking for messages on channels
  0.012451 : SafeState: back to waiting, triggering SafeStateAgain
  1.724664 : raw key input: "^[[O"
  1.725121 : looking for messages on channels
  1.725150 : SafeState: back to waiting, triggering SafeStateAgain
  4.524284 : raw key input: "^[[I"
  4.524393 : looking for messages on channels
  4.524411 : SafeState: back to waiting, triggering SafeStateAgain
  4.524921 : raw key input: "^[[<0;57;18M"
  4.525073 : SafeState: reset: key typed
  4.525108 : SafeState: Start triggering
  4.525666 : looking for messages on channels
  4.525684 : SafeState: back to waiting, triggering SafeStateAgain
  4.591695 : raw key input: "^[[<0;57;18m"
  4.591833 : SafeState: reset: key typed
  4.591856 : SafeState: Start triggering
  4.592119 : looking for messages on channels
  4.592127 : SafeState: back to waiting, triggering SafeStateAgain
  6.594258 : SafeState: reset: key typed
  6.647365 : SafeState: Start triggering
  6.647571 : looking for messages on channels
  6.647578 : SafeState: back to waiting, triggering SafeStateAgain
  6.850199 : raw key input: ":"
  6.850260 : SafeState: reset: key typed
  6.881682 : SafeState: Start triggering
  6.881723 : looking for messages on channels
  6.881729 : SafeState: back to waiting, triggering SafeStateAgain
  6.986116 : raw key input: "q"
  6.986178 : SafeState: reset: key typed
  6.986205 : SafeState: Start triggering
  6.986237 : looking for messages on channels
  6.986245 : SafeState: back to waiting, triggering SafeStateAgain
  7.074100 : raw key input: "!"
  7.074164 : SafeState: reset: key typed
  7.074229 : SafeState: Start triggering
  7.074263 : looking for messages on channels
  7.074270 : SafeState: back to waiting, triggering SafeStateAgain
  7.326184 : raw key input: "^M"
  7.326248 : SafeState: reset: key typed
  7.328328 : Exiting...
  7.340434 : ui_delay(1)
  7.341889 : ui_delay(1)
  7.343105 : ui_delay(1)
  7.344451 : ui_delay(1)
  7.345689 : ui_delay(1)
  7.346897 : ui_delay(1)
  7.348191 : ui_delay(1)
  7.349376 : ui_delay(1)
  7.350578 : ui_delay(1)
  7.352816 : closing channel log in the child process
  7.352995 : closing logfile /tmp/logfile
  7.368496 : raw terminal output: "^[]2;[No Name] - VIM^G"
  7.368646 : raw terminal output: "^[[?1006l^[[?1002l^[[?2004l"
  7.368662 : raw terminal output: "^[]2;xterm^G"
  7.368702 : raw terminal output: "^[[33;1H^[[K^[[33;1H^[[?1004l^[[?2004l^[[?1l^[>"

Notice that the pattern [< is present on these 2 lines:
4.524921 : raw key input: "^[[<0;57;18M"
4.591695 : raw key input: "^[[<0;57;18m"

^[[ is CSI (Control Sequence Introducer).
0 is the encoded button value (here a left-click).
57 and 18 are the mouse ordinates.
The final m means that the button was released, while a final M means that the button was pressed.

Thanks for the detailed steps. Some update, it happens both outside and inside tmux when t_fe & t_fd are manually set in .vimrc. Here are the files:
inside_tmux.txt
outside_tmux.txt
Here's what I had in .vimrc.

Sorry, I have health issues, so I don't have much time at the moment.  However:

Also, unlike what you said, the options don't seem to get printed one per line by :DebugTerminfo, unless I am missing something...

That's weird.  It works for me with and without config; I don't know why it fails in your case.  I'll have to think about it later.

Update: There could be something off with my terminfo. Check this out for instance: andmarti1424/sc-im#604 (comment)

Yes, in the linked thread, this comment seems relevant:

There's more than one xterm mouse-protocol. The one you're using is the older one, which is limited to 224x224. Here's an output from infocmp showing alacritty's version versus ncurses (ncurses on the left):

That could explain your issue.  If your terminal uses an old encoding which is limited to 224 columns and you click beyond the 224th column, Vim will probably receive an escape sequence which it doesn't understand.  You might need to update/fix the terminfo entry for the xterm terminal, or whatever $TERM you're actually using.
Here is how to update the whole database:
curl -LO http://invisible-island.net/datafiles/current/terminfo.src.gz
gunzip terminfo.src.gz
tic -sx terminfo.src

This link might give a little more info.


Add arm64 build instructions and daemon set

Signed-off-by: Alexey Perevalov<EMAIL_ADDRESS>

/assign @ahalim-intel

/cc  @ahalim-intel

Hi @AlexeyPerevalov, since this changes involved travis-ci changes, we are experiencing build delays issues lately due to our org travis-ci, we need to do an internal review of the impacts.
Unfortunately we need to put this on hold for now.
If you like you can create a separate PR with the docker file only.

Hello @ahalim-intel , I'll exclude .travis.yml from this commit. Also I found that that CI hooks ran when PR was created. I assumed docker push proceeded, but there is no nfvpe/sriov-device-plugin:arm64. Is it possible to submit image, avoiding travis?

Hello @ahalim-intel , I'll exclude .travis.yml from this commit. Also I found that that CI hooks ran when PR was created. I assumed docker push proceeded, but there is no nfvpe/sriov-device-plugin:arm64. Is it possible to submit image, avoiding travis?

Image will only be pushed when PR gets merged.
PR creation will trigger travis CI for basic verficiation, but not pushing image.

@AlexeyPerevalov I think you it's good idea to add the dockerfile

@zshi-redhat @ahalim-intel is possible to merge .travis with arm and all other necessary files just to make docker push and then revert just .travis file to release travis?

@AlexeyPerevalov I noticed that the arm64 daemonset is using image alexeyperevalov/arm64-sriov-device-plugin, is this available publicly and how would it be updated if there is new code change?
I understand we may not be adding it in travis build and push it automatically until we change to github actions.  but would like to know how it will be updated with latest changes.

@AlexeyPerevalov I noticed that the arm64 daemonset is using image alexeyperevalov/arm64-sriov-device-plugin, is this available publicly and how would it be updated if there is new code change?
I understand we may not be adding it in travis build and push it automatically until we change to github actions. but would like to know how it will be updated with latest changes.

This is temporary solution. I believe the image will be kept up to date in their own environment for now.

@AlexeyPerevalov I noticed that the arm64 daemonset is using image alexeyperevalov/arm64-sriov-device-plugin, is this available publicly and how would it be updated if there is new code change?
I understand we may not be adding it in travis build and push it automatically until we change to github actions. but would like to know how it will be updated with latest changes.

This is temporary solution. I believe the image will be kept up to date in their own environment for now.

ok, maybe add a TODO comment in the file?

@AlexeyPerevalov I noticed that the arm64 daemonset is using image alexeyperevalov/arm64-sriov-device-plugin, is this available publicly and how would it be updated if there is new code change?
I understand we may not be adding it in travis build and push it automatically until we change to github actions. but would like to know how it will be updated with latest changes.

This is temporary solution. I believe the image will be kept up to date in their own environment for now.

ok, maybe add a TODO comment in the file?
done

/lgtm


Configurable ttl for caches and/or entries in redisson Jcache

Hi, it would be nice to have a global configuration(using redisson-jcache.json, for example) option for the redisson Jcache to set the ttl for caches and/or entries.

Any progress so far?

it's not clear how to implement this since it's out of JCache specification. Currently you can use RMapCache object


Fix stylistic issues in HARK

We've adapted flake8 for "code linting", as per issue #171.  Now we need to use flake8's output to make our code more pythonic.  This is a great issue for newcomers who want to get familiar with our codebase.
To run flake8, make sure you've installed the requirements in requirements.txt (or simply type pip install flake8) and then run in your command line/prompt flake8 HARK/core.py, substituting the relative path is to the file you want to lint.
I've broken out the codebase into sections so multiple people can tackle this issue at once.  If you'd like to grab a section, comment below.

[ ] top level HARK folder (core.py; dcegm.py; estimation.py; interpolation.py; parallel.py; simulation.py; utilities.py
[ ] tests folder
[ ] ConsumptionSaving folder
[ ] FashionVictim folder
[ ] SolvingMicroDSOPs folder
[ ] cAndCwithStickyE folder
[ ] cstwMPC folder

I was thinking I will start off by linting the tests folder!

I will be working on pylinting on core.py

I just finished linting the Testing folder, and I will continue linting the tests folder (within the HARK folder which is probably where the linting was meant to be done anyways)

Awesome, thanks!  I guess @shaunagm probably should be the one to merge the PR's since she is on the spot (and knows more about this than we do anyway!)

I'm working on dcegm.py
I ran into this error for flake8
dcegm.py:155:25: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Patrick has probably gone to bed (I think it's midnight now in Copenhagen) so he can look at this tomorrow.
(I'm new to flake8.  My guess about that message was that it referred to what it thought was a problem on line 155 (not sure what the '25' was), but line 155 is     upperV_T = np.zeros(m_len) which does not seem related.  Maybe it is actually identifying line 158, which reads:
upperV_T[row_all_nan == False] = np.nanmax(commonV_T[row_all_nan == False, :], axis=1)
?

Hi,
Line 155 for me after I had removed some lines is
   idx_max[row_all_nan == False] = np.nanargmax(commonV_T[row_all_nan == False], axis=1)

Hmm, so do you think it is suggesting
upperV_T[if row_all_nan is False] = np.nanmax(commonV_T[if row_all_nan is False, :], axis=1)
?  That looks odd to me.

I've linted most of it the smaller issues:
The errors
dcegm.py:155:25: E712 comparison to False should be 'if cond is False:' or 'if not cond:' dcegm.py:161:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:' dcegm.py:175:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
I will make PR so you can see which lines those are

So it seems to be complaining that we're confusing "falsy" with "false".  In Python, "falsy" values are any values where bool(value) returns False, for instance False, [] and None are falsy, while only False is false.  "If not cond" is saying, "if cond is falsy", whereas "if cond is False" is saying "if cond is False".  It wants us to determine if cond should be falsy or false.  Can it be a [ ] or a None or can it only be False?

OK, that makes sense.  But I don't know the answer -- we'll have to wait for @pkofod

It looks to me like we can't use "cond is False", because cond is a
(boolean) array, not just a single bool.  You definitely can't put an if
statement inside indexing brackets.  I would write this line as:
valid_rows =  np.logical_not(row_all_nan)
upperV_T[ valid_rows   ] = np.nanmax(commonV_T[ valid_rows   , :], axis=1)
On Mon, May 6, 2019 at 5:00 PM Christopher Llorracc Carroll <
<EMAIL_ADDRESS>wrote:

OK, that makes sense. But I don't know the answer -- we'll have to wait
for @pkofod https://github.com/pkofod
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/262#issuecomment-489774734, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADKRAFM5PJQ5VDI72DK6E2DPUCL5NANCNFSM4HI4W2FQ
.

FYI Ingrid & I are grabbing estimation.py to lint.

Hi I will take SolvingMicroDSOPs folder

Since this issue has been made, we've converged now on black for linting/styling.
I wonder if we should make run this as the final step before the 0.10.7 release.
The problem with this change is that because it touches all the files, it's hard to do when there's a lot of ongoing work in PRs.
What do you think, @MridulS ?
I think we may also be waiting for more definite buy-in from @llorracc and @mnwhite on this.

We use black now. :)


Any plan to support sample with node attribute?

Example
euler_ops.sample_node(count=100, node_type=1, attribute={"gender":"man"})

support sample with node attribute will be in the next version

Good news. What time?

coming soon


Unable to initialize the image editor with vanilla javascript

Version

tui-image-editor.min.js
@version 3.5.2

Development Environment
Chrome, MacOS
Current Behavior
I am serving the dist files myself and loading them in my dom. Along with the dependencies
I cannot manage to initialize the image editor. I think it is with the selector. anything i should consider? it says :
tui-image-editor.min.js:10 Uncaught TypeError: Cannot read property 'nodeName' of null
i am invoking ImageEditor as follows
var imageEditor = new tui.ImageEditor('#tui-image-editor canvas', {
	cssMaxWidth: 1000, // Component default value: 1000
	cssMaxHeight: 800  // Component default value: 800
});

Expected Behavior
have the editor on my screen.

You should provide some data in the includeUI key:
     includeUI: {
         loadImage: {
             path: 'img/sampleImage.jpg',
             name: 'SampleImage'
         },
         locale: locale_ru_RU, // key-value object with localization
         theme: blackTheme, // or whiteTheme
         initMenu: 'filter',
         menuBarPosition: 'bottom'
     },
    cssMaxWidth: 700,
    cssMaxHeight: 500,
    selectionStyle: {
        cornerSize: 20,
        rotatingPointOffset: 70
    }
});

If this didn't help check the example.

I am on same issue, my error console showing this 'TypeError: tui.component is undefined'
Kindly reply

No good example :thumbsdown:


Incorrect documentation for release retention policies

The documentation is no longer correct when it comes to release retention

As an author of a release pipeline, you can customize retention policies for releases of your pipeline on the Retention tab.
The retention policy for YAML and build pipelines is the same. You can see your pipeline's retention settings in Project Settings for Pipelines in the Settings section.

-- these settings are now read-only for ADO projects, as seen below. We have no way to customize release retention policies right now.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43a285f9-738d-9f76-4de0-a4c4ecf6f5f5
Version Independent ID: 9581a043-4873-bf0a-138f-85f6a61ae950
Content: Build and release retention policies - Azure Pipelines
Content Source: docs/pipelines/policies/retention.md
Product: devops
Technology: devops-cicd-policies
GitHub Login: @juliakm
Microsoft Alias: jukullam

@jd-porter  Thank you for the feedback.
This issue was previously noted under https://github.com/MicrosoftDocs/azure-devops-docs/issues/3822.
Please refer there for further updates.


Escape the message as found by oliverklee

Using the stdlib CGI::escapeHTML. TIL that HTML encoding is also good
for XML! Thanks @oliverklee

Thanks for much for reporting this issue @oliverklee, and thank you @swalberg for implementing the fix!
Really appreciate the community support on this. I've gone ahead and released a hotfix in 0.17.1.


[Bug]: Passing --bail option to test does not exit on first test failure

Describe the bug
Passing --bail option to test does not bail out on test failure
Steps to reproduce
# Add code to fail test
$ sed -i "1s|^|console.log\('foobar'\);\n|" src/transforms/v2-to-v3/__fixtures__/api-await.input.ts

$ git diff
diff --git a/src/transforms/v2-to-v3/__fixtures__/api-await.input.ts b/src/transforms/v2-to-v3/__fixtures__/api-await.input.ts
index 6ba6791..377fecf 100644
--- a/src/transforms/v2-to-v3/__fixtures__/api-await.input.ts
+++ b/src/transforms/v2-to-v3/__fixtures__/api-await.input.ts
@@ -1,3 +1,4 @@
+console.log('foobar');
 import AWS from "aws-sdk";

 const client = new AWS.DynamoDB();

Observed behavior
The tests fail after ~600 tests have run within 4s, but jest does not bail out.
$ yarn test --bail
 ...
Test Suites: 1 failed, 3 passed, 4 total
Tests:       2 failed, 648 passed, 650 total
Snapshots:   0 total
Time:        73.413 s

Expected behavior
Jest to bail out when first test fails with error message.
Additional context
Recommended in https://github.com/awslabs/aws-sdk-js-codemod/issues/157#issuecomment-1320281684

This appears to be an issue with jest.
It has been discussed in multiple issues, the primary one being https://github.com/facebook/jest/issues/6527


Issue in generating refresh-token using powershell scripts

Hi Team
We are getting the below error when generating refresh token using the below powershell scripts.
$credential = Get-Credential
$token = New-PartnerAccessToken -ApplicationId 'xxxxxxxxxxxxxxxx' -Scopes 'https://api.partnercenter.microsoft.com/user_impersonation' -ServicePrincipal -Credential $credential -Tenant 'xxxxxxxxxxxxxx' -UseAuthorizationCode

I've installed the latest version of New-PartnerAccessToken module 2.0.1909.5.
And I've tried creating the new app using the powershell script provided here https://docs.microsoft.com/en-us/powershell/partnercenter/secure-app-model?view=partnercenterps-1.5 (BTW, performing the consent on this link is not updated with new command)
Have tried this approch using our sandbox account and LIVE account as well, same error.  Our current refresh token will expire in a weeks time due to 90 days limit.
Below is the request/correlation id's.
Request Id: 4a4f5424-8b51-4b9a-8012-2788d4a93500
Correlation Id: 8bc08715-0960-4bb9-9d69-bc0e9048cf91
Please advise.
Regards
Prabha

@vgponline starting with version 2.0 the expected reply URL has changed. You need to make sure that http://localhost:8400 is configured as one the possible reply URLs for the application registration in Azure AD. You can find a more detailed explanation regarding the change under the first example found here.

Thank you, it worked.


Fuel cell model does not report monthly energy

For hybrid configurations, need monthly electricity from fuel cell for monthly energy autograph.
Fuel cell model reports "Fuel cell annual energy discharged" fuelcell_annual_energy_discharged and "Electricity from fuel cell" fuelcell_power. Would be useful to also have monthly energy discharged.

see https://github.com/NREL/ssc/issues/1056 and #1509


Crash in Parse 1.14.1

Background: Push out an update of my app yesterday, the update passed through every QA test but users who installed the update are now reporting that they couldn't launch the app. I have checked my crash logs and found the following issue.
Line that cause the crash is in: PFObjectSubclassingController.m line 355
Specifically this line: strncpy(potentialPaths[0], bundle.executablePath.UTF8String, PATH_MAX);
Error is:
Crashed: com.parse.object.subclassing
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000000
At the moment, I have no idea why there is an memory address error when trying to access the item.
Attached is the stack trace.
stack trace.txt

Hi there, I report the exact same issue. Definitely introduced in 14.14 as it never happened before 14.4.0. It occasionally occurs on my testing device and in iOS simulator, today it crashed while trying to log in shortly after opening the app. I'm using CocoaPods so Parse is in dynamically linked framework.
Please see my screenshot showing the crash in Xcode debugger.

It looks this issue was solved in #981 so please try to upgrade the SDK.

1.14.2 should fix exactly this problem.
Please update and open new issues if you run into any problems.


Clipper2 update to 1.4.0

Library name
Clipper2
New version number
1.4.0
Other information that may be useful (release notes, etc...)
It seems like Clipper2 started exposing a proper Clipper2Config.cmake, so usage can be changed to use find_package(Clipper2) from pkg_check_modules(Clipper2): https://github.com/AngusJohnson/Clipper2/blob/Clipper2_1.4.0/CPP/CMakeLists.txt#L331

This issue has been fixed by PR https://github.com/microsoft/vcpkg/pull/40736

@FrankXie05 ooops, apparently I only checked the latest vcpkg release, not master. Sorry for the unnecessary issue!


chore(master): release 1.0.3

:robot: I have created a release beep boop
1.0.3 (2024-06-10)
Bug Fixes

调整发包错误,此版本同 1.0.2 (320d2d9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/lspriv/wc-plugin-multiple/releases/tag/v1.0.3 :sunflower:


Have Unshaky as a faceless app

Hey, thanks for your awesome package :) I'm writing well now.
I'm happy to use your app but is it possible to have it in faceless mode ? I mean possible to remove the icon from top bar ?
Regards

Glad it works for you.
See the article here for hiding task bar item
https://github.com/aahung/Unshaky/wiki/How-to-hide-Unshaky-from-status-bar


Add Italic, strikethrough and fix line draw bug

Added Italic support
Turned on Strikethrough (although it renders as underline)
Added Canvas gallery page
Removed dependency on Crayon library

Bug Fixes

Fix line draws 1 too many chars #132

Changes:

Remove dependency on Crayon library, as it didn't implement italics and added ConsoleUtils
Use Italic escape to handle FontStyle=Italic
Refactor DrawLineInternal into  DrawLineInternal and DrawRectangleLineInternal

Details:
The issue is that DrawLineInternal was written to draw rectangle borders and then simply reused as the DrawLine implementation. The original DrawLineInternal draws Corner + Line + Corner. This always ended up drawing 1 more than the desired line length, when reused for a simple line.
The solution was to refactor the code into

DrawLineInternal
DrawRectangleLineInternal

Summary by CodeRabbit

New Features

Introduced a new GalleryCanvas user control for enhanced graphical representation, including lines and rectangles.
Added text decoration demonstrations in GalleryTextBlock, showcasing underline, strikethrough, and italic styles.
New utility class ConsoleUtils for ANSI escape code definitions and text formatting.

Bug Fixes

Improved text rendering logic in InputLessDefaultNetConsole, allowing for more flexible formatting.

Refactor

Enhanced drawing functionality and error handling in DrawingContextImpl.
Updated strikethrough metrics in GlyphTypeface.

Chores

Removed unused package reference for Crayon.
Removed metadata attributes from GalleryColors, GalleryGradientBrush, and GalleryImage classes.
Removed references to unused XAML and code files in the project configuration.

@tomlm don't you know why "code inspection" build did not work in this PR ?

@tomlm  Is this correct drawing?

There should be an orange box pinned to lower right corner....

There should be an orange box pinned to lower right corner....

This one I've tried Fedora+Gnome Terminal

Hmmm, I'll try on Ubuntu proper, I was using Ubuntu on wsl

There should be an orange box pinned to lower right corner....
The upper left is testing horizontal and vertical one char lines
The bottom right is testing long lines that overlap
Lines look correct, but I don't know where the orange rect is

oh ok, it just did not fit:

I was thinking about this more and I'm not certain I'm doing this right.
If I understand the current code, the goal is that lines actually meet at corners.
Effectively, startChar and endChars are lines that end at the middle of the pixel, so when you merge them the corners align.
So if I draw a line from pixel 0->pixel 1, what should it draw? It actually seems like it should draw a DOT at the corner. That seems weird.
But right now with my delta it does the following:

DrawLineInternal => Draws from edge to edge.
DrawRectangleLineInternal => Draws from center to center.
That's why my lines make overlapping cross where they pass.

Thoughts?

I'm not sure I properly understand your concern.

I was thinking about this more and I'm not certain I'm doing this right.
If I understand the current code, the goal is that lines actually meet at corners.
Effectively, startChar and endChars are lines that end at the middle of the pixel, so when you merge them the corners align.

Correct.

So if I draw a line from pixel 0->pixel 1, what should it draw? It actually seems like it should draw a DOT at the corner. That seems weird.
But right now with my delta it does the following:
* DrawLineInternal => Draws from edge to edge.

* DrawRectangleLineInternal => Draws from center to center.
  That's why my lines make overlapping cross where they pass.

Thoughts?

Similar thoughts, but for now I can not fully understand how the line drawing is gonna be used. Will it be the line aligned to the text, like this?
────
The text.

Or will it be the line aligned to the rectangle, like this
╶─╴
┌─┐
│    │
└─┘

I would say we just need more input in the future on this question.

I'm thinking we should extend line rush to have a policy for character layout

Edge or center point
perhaps alignment top/center/bottom assuming we can honor them with appropriate characters

Sometime like that...


Create docker volume for mariadb container

Dont know shit about docker, will wait for a review from someone who knows docker stuff better.

I'll check this out, hold on...

The docker-compose part is fine but you should probably gitignore the volume folder :D

The docker-compose part is fine but you should probably gitignore the volume folder :D

Correct.

@Chicken if you give a green flag as well ill be merging this

Merging now


HDFS-17148. RBF: SQLDelegationTokenSecretManager must cleanup expired tokens in SQL

Description of PR
JIRA: HDFS-17148. RBF: SQLDelegationTokenSecretManager must cleanup expired tokens in SQL
These changes update the SQLDelegationTokenSecretManager to cleanup expired tokens found in SQL. Currently, AbstractDelegationTokenSecretManagers only cleanup tokens in its memory cache. The SQLDelegationTokenSecretManager was recently updated to use a LoadingCache with a short TTL, so most expired tokens won't be present in memory.
During token cleanup, the SQLDelegationTokenSecretManager will query SQL for a list of tokens that have not been updated recently, based on the modifiedTime column. We will limit the amount of results returned to prevent performance impact on SQL. Once the list is returned, the ExpiredTokenRemover will evaluate if the tokens are actually expired and delete them from SQL if so.
How was this patch tested?
Added unit test for different token cleanup scenarios:

Having an expired token in SQL. which should be deleted
Having a token with a long renewal time, which should not be deleted
Having a token recently renewed, which should not be deleted

For code changes:

[Y] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[Y] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[Y] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[Y] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Good catch!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
18m  9s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m  3s

trunk passed

+1 :green_heart:
compile
19m 16s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m 18s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 41s

trunk passed

+1 :green_heart:
mvnsite
2m 33s

trunk passed

+1 :green_heart:
javadoc
1m 59s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m  3s

trunk passed

+1 :green_heart:
shadedclient
39m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 31s

the patch passed

+1 :green_heart:
compile
17m 39s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 39s

the patch passed

+1 :green_heart:
compile
17m 14s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
17m 14s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
4m 33s

the patch passed

+1 :green_heart:
mvnsite
2m 26s

the patch passed

+1 :green_heart:
javadoc
1m 54s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
1m 44s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html
hadoop-hdfs-project/hadoop-hdfs-rbf generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
39m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 53s

hadoop-common in the patch passed.

+1 :green_heart:
unit
22m 24s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m  1s

The patch does not generate ASF License warnings.

299m  5s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs-rbf

org.apache.hadoop.hdfs.server.federation.router.security.token.SQLDelegationTokenSecretManagerImpl.lambda$selectTokenInfos$4(long, int) may fail to clean up java.sql.ResultSet  Obligation to clean up resource created at SQLDelegationTokenSecretManagerImpl.java:clean up java.sql.ResultSet  Obligation to clean up resource created at SQLDelegationTokenSecretManagerImpl.java:[line 165] is not discharged

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5936

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux dd74f5b2c166 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2d535427212f9c678422b05d0ae58b19fb53eadb

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/1/testReport/

Max. process+thread count
2607 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 30s

trunk passed

+1 :green_heart:
compile
18m 29s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m 59s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 42s

trunk passed

+1 :green_heart:
mvnsite
2m 33s

trunk passed

+1 :green_heart:
javadoc
1m 58s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m  6s

trunk passed

+1 :green_heart:
shadedclient
39m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 29s

the patch passed

+1 :green_heart:
compile
17m 33s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 33s

the patch passed

+1 :green_heart:
compile
16m 59s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 59s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 32s

the patch passed

+1 :green_heart:
mvnsite
2m 27s

the patch passed

+1 :green_heart:
javadoc
1m 53s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 23s

the patch passed

+1 :green_heart:
shadedclient
39m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 53s

hadoop-common in the patch passed.

+1 :green_heart:
unit
22m 20s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

281m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5936

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e66ca09926f6 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0c721a2df50771f821585ab1a47657081aaac84d

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/2/testReport/

Max. process+thread count
2652 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri @simbadzina  Can you help to review this pr? Thank you very much! From my personal point of view, this PR is good.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 42s

trunk passed

+1 :green_heart:
compile
19m 12s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
18m 13s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 42s

trunk passed

+1 :green_heart:
mvnsite
2m 37s

trunk passed

+1 :green_heart:
javadoc
1m 58s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 25s

trunk passed

+1 :green_heart:
shadedclient
42m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 40s

the patch passed

+1 :green_heart:
compile
19m 10s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
19m 10s

the patch passed

+1 :green_heart:
compile
17m 18s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
17m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 32s

the patch passed

+1 :green_heart:
mvnsite
2m 28s

the patch passed

+1 :green_heart:
javadoc
2m  2s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 56s

the patch passed

+1 :green_heart:
shadedclient
42m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 41s

hadoop-common in the patch passed.

+1 :green_heart:
unit
22m 34s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

292m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5936

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fc9f91861e77 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ccb908b3957b707a686739f3bbe8caf8d6bf49f4

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/3/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 34s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
38m 29s

trunk passed

+1 :green_heart:
compile
19m 43s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m 27s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 47s

trunk passed

+1 :green_heart:
mvnsite
2m 45s

trunk passed

+1 :green_heart:
javadoc
2m  5s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
5m 17s

trunk passed

+1 :green_heart:
shadedclient
43m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 41s

the patch passed

+1 :green_heart:
compile
18m 47s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
18m 47s

the patch passed

+1 :green_heart:
compile
17m 14s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
17m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 43s

the patch passed

+1 :green_heart:
mvnsite
2m 34s

the patch passed

+1 :green_heart:
javadoc
2m  3s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 41s

the patch passed

+1 :green_heart:
shadedclient
41m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 49s

hadoop-common in the patch passed.

+1 :green_heart:
unit
22m 50s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

294m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5936

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5585ce4906fe 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a7986ed4b96b7502709c6158007b764b22adfcc7

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/4/testReport/

Max. process+thread count
2918 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5936/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Meldung Falscher Typ seit admin 5

Hallo
seit dem Update auf Admin 5 bekomme ich mein log mit folgenden Meldungen gefüllt:
`

coronavirus-statistics.0
2021-08-17 13:00:10.976
info
(4125) Terminated (ADAPTER_REQUESTED_TERMINATION): Without reason

coronavirus-statistics.0
2021-08-17 13:00:10.870
info
(4125) State value to set for "coronavirus-statistics.0.Germany.Kreis.Nürnberger_Land.BL" has to be type "number" but received type "string"

coronavirus-statistics.0
2021-08-17 13:00:10.802
info
(4125) State value to set for "coronavirus-statistics.0.Germany.Stadt.Nürnberg.BL" has to be type "number" but received type "string"

coronavirus-statistics.0
2021-08-17 13:00:10.721
info
(4125) State value to set for "coronavirus-statistics.0.Germany.Kreis.Schwandorf.BL" has to be type "number" but received type "string"

coronavirus-statistics.0
2021-08-17 13:00:10.664
info
(4125) State value to set for "coronavirus-statistics.0.Germany.Kreis.Regensburg.BL" has to be type "number" but received type "string"

coronavirus-statistics.0
2021-08-17 13:00:10.584
info
(4125) State value to set for "coronavirus-statistics.0.Germany.Kreis.Neumarkt_id_OPf.BL" has to be type "number" but received type "string"

coronavirus-statistics.0
2021-08-17 13:00:10.517
info
(4125) State value to set for "coronavirus-statistics.0.Germany.Kreis.Amberg-Sulzbach.BL" has to be type "number" but received type "string"

coronavirus-statistics.0
2021-08-17 13:00:10.460
info
(4125) State value to set for "coronavirus-statistics.0.Germany.Stadt.Regensburg.BL" has to be type "number" but received type "string"

coronavirus-statistics.0
2021-08-17 13:00:10.375
info
(4125) State value to set for "coronavirus-statistics.0.Germany.Stadt.Amberg.BL" has to be type "number" but received type "string"

coronavirus-statistics.0
2021-08-17 13:00:09.875
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.5.testsPerOneMillion" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:09.856
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.5.tests" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:09.623
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.4.testsPerOneMillion" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:09.617
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.4.tests" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:09.481
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.3.testsPerOneMillion" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:09.472
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.3.tests" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:09.244
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.2.testsPerOneMillion" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:09.234
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.2.tests" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:08.880
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.1.testsPerOneMillion" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:08.846
info
(4125) State value to set for "coronavirus-statistics.0.country_Top_5.1.tests" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:06.916
info
(4125) State value to set for "coronavirus-statistics.0.Germany.testsPerOneMillion" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:06.906
info
(4125) State value to set for "coronavirus-statistics.0.Germany.tests" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:05.856
info
(4125) State value to set for "coronavirus-statistics.0.global_totals.testsPerOneMillion" has to be type "string" but received type "number"

coronavirus-statistics.0
2021-08-17 13:00:05.802
info
(4125) State value to set for "coronavirus-statistics.0.global_totals.tests" has to be type "string" but received type "number"

`

ist bereits in der letzten beta gefixt, erwarte die am WE auf stable zu publizieren


Add check to see if chaplain exists

https://github.com/WolfDKs-CK3-Modding/Easier-Culture-Religion-Spread/blob/0c698290adc06f02d71801d1b26b3a32805905cc/events/auto_council_events.txt#L68-L69
The chaplain doesn't necessarily exist. He could be dead and thus the position is vacant.
You could add it in with the limit above it.

That suggested change has been implemented. but still thanks for the input.