Now "Add lear organization to development environment"

For testing, this please create a realm called lear and add<EMAIL_ADDRESS>as a normal user. Then generate emails by visiting /emails.

@timabbott @rishig This is ready for a review

@timabbott This is ready for a review.

I merged one commit, and then split the followday1.source.html commit into two pieces, so the changes are a lot easier to understand (that first commit should be mergable, but I'm delaying that until we're more confident in the approach).  I think the next step for this to for @rishig and I to chat about what we want the modified text at the beginning of the email for the followup_day1 email to be (it feels like this has a lot of cases, and I'm not sure they're the right ones).

I think we can just simplify the email, instead of having essentially two different emails. The following should work, and we can style it (V2) to highlight the account details part.
[Learn more] can just be a link to zulipchat.com.
Welcome to Zulip!

if created:
    You've created the new Zulip organization {{ realm.name }}.
else:
    You've joined the Zulip organization {{ realm.name }}.

Your account details:
Organization URL: foo.zulipchat.com
Email<EMAIL_ADDRESS>(you'll need these to sign in to the [mobile and desktop] apps.)

if admin:
    Check out our [guide for admins], become a Zulip pro with a few [keyboard shortcuts], or [dive right in]!
else:
    [Learn more] about Zulip, become a pro with a few [keyboard shortcuts], or [dive right in]!

Cheers,
Team Zulip

PS: Follow us on ...

@timabbott @rishig This is ready for a review.

I edited the email log commit and merged it as 546fd5d60e7b61d744bf4449249c0bdaca88c289, after fixing the fact that I don't want us to run provision-type commands from inside the test suite (it's too unpredictable).  I think that result is a good balance between development convenience for working on the emails and predictability of the automated testing experience.
For the "Cleanup followup day1 email" commit, I think everything looks good, except that it doesn't seem you implemented the "Learn more" link -- is that intentional?  I think that sort of link is an important tool for helping new users being invited to a new organization by their admin understand why Zulip is different.
More importantly, I think there's a bug; the account details are not correct for users in an LDAP organization.  We should be doing something like:
if email_belongs_to_ldap(realm, user_profile.email) and require_email_format_usernames(realm):
    # specify LDAP username it as "LDAP username", not email as "email".

(both functions come from zproject/backends.py).
And

emails: Don't send day2 email if user already has an account

Needs a test.

@timabbott This is ready for a review

The lear realm commit should be broken into smaller pieces (e.g. the subscribe_to_streams function extraction should be its own commit); I'm skipping reviewing it for now.
The other commits look pretty good.  I merged with two changes:

Added __iexact in the check in 4a9cbf453e2b5512f363257997e523f6cce0d109, since email addresses are case-insensitive.
I realized that the algorithm for mapping from email -> LDAP username is not always possible to do (it's only possible in 2 of the 3 valid LDAP configurations; see configuration C in our LDAP auth docs for details: https://zulip.readthedocs.io/en/latest/production/authentication-methods.html#ldap-including-active-directory).  So, I just changed it to provide this text:

* Organization URL: https://zulip.example,com
* Use your LDAP account to login

(you'll need these to sign in to the mobile and desktop apps)

Merged those as the two commits ending with ba640bf89d7f08ed29e894294e8a10c848dea18c.
I suppose we can compute whether or not it's possible to get the user's LDAP username by checking for the LDAP_EMAIL_ATTR setting, and use that to determine whether we need to do what I merged, or the more informative thing that you had here; want to do a quick commit doing that?
Leaving this open since the Lear commit still needs splitting, so you can just add the final LDAP tweak here.
Thanks @hackerkid!  I think this is going to be a nice improvement to the zulipchat.com onboarding experience.

This is ready for a review.

I merged the first commit (though we'll want to fix #10917 soon), and the second commit after s/create/extract/ in the commit message (we generally reserve "create" for new code).
Looking at the third now.

Closing this since the PR has become stale.


Automator: update common-files@master in istio/ztunnel@master

Generated by Automator - 2022-11-17T02:44:52+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
8d55dc03d83283f5feff9c3d4a152c397a73014d
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test test

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
8d55dc03d83283f5feff9c3d4a152c397a73014d
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Looks like it's getting fixed in https://github.com/istio/ztunnel/pull/142

After #142 merged, we can close it safely.


Possible solution to LSTM concatenation problem

Hi Oscar,
firstly, thank you for sharing your code with all of us. I noticed you encountered the same trouble I had while I was trying to implement the f Full Context Embedding following the original paper description.
https://github.com/oscarknagg/few-shot/blob/672de83a853cc2d5e9fe304dc100b4a735c10c15/few_shot/models.py#L246
I build a LSTM model from scratch that could allow you to fix this problem.
You can find the model here: https://github.com/rtorrisi/LSTM-Custom-InOut-Hidden-Size
Let me know your thoughts.
Kind regards,
Riccardo

I can confirm that using the concatenation proposed the model gain a little bit of performance on validation (~2%) and training as shown in the plot below.

Blue and Orange lines are train and validation using the sum of h and readout.
Green and Red lines are train and validation using the concatenation of h and readout.


Admin views are not available in mobile. Show a message .

Admin views are not available in mobile at present. When an admin user checks from a mobile show a message saying that to use a desktop brower for admin pages.

Working on this


How to set up a multi-node cluster

I believe it goes like this...

Clone this repo to all machines, and npm install to get all the node_modules setup.
On the main server that you will communicate with run bin/server.js.  By default it will also start up local worker processes depending on the # of cpus available on the machine.  You can control this with command line params if you want, once #82 is merged.
On all other machines run bin/worker.js -H <server ip> -P <server port>

That should work.

I was trying to help out documenting the multi-cluster setup, however I could not find where the code for the documentation is.
Would you mind pointing me to the right direction ?
Cheers.


Add checks and tests for empty/unnamed arguments

Sometimes developers forget to change the argument information in method bindings when changing the method itself. This results in unnamed arguments in the documentation, which doesn't make good docs. We sometimes fix it by hand, but with this change we should start catching the issue on CI for every PR.
It would look something like this and the Static Checks task would fail.:
https://github.com/YuriSizov/godot/runs/7706112708?check_suite_focus=true

I've decided to change the default name of the unnamed argument/parameter for better grepping. I don't think it would break anything, and if it does then name your parameters 😈

I briefly played with an option to fail in the doctool itself, so developers can test it locally while running it to sync up the docs, but we don't have a way to fail CI from the doctool at the moment (even if you return a non-zero exit code). It is still possible to add checks to the doctool without making it fail, something like this (if we still want to report an exit code; otherwise swap for the ERR_CONTINUE_MSG macro):
// Log as error, but don't fail.
if (arginfo.name.is_empty() || arginfo.name.begins_with("_unnamed_arg")) {
	exit_code = EXIT_FAILURE;
	ERR_PRINT(vformat("In '%s' the '%s' method has unnamed argument in position %d; check '%s::_bind_methods'.", lang->get_name(), md.name, j, lang->get_name()));
}

We also don't typically check anything about classes in doctools, it just creates XML and make_rst.py does the checking on CI. So this would be an extra option, on top of this PR, if we want that.
For the reference, make_rst.py can be run locally with --dry-run to not produce any files and only check for errors. Can probably include in pre-commit hooks as a simpler solution?

While having a check in make_rst.py is nice to have, I think this should be checked by test_class_db.h directly.
As a matter of fact, this PR doesn't catch some methods which do lack argument names, because they're setters and their argument name isn't listed in the XML. But you can see them in the GDExtension API:
$ rg arg0
godot-headers/extension_api.json
34240:                                                  "name": "arg0",
67272:                                                  "name": "arg0",
212688:                                                 "name": "arg0",

Ah, I knew about setters, but didn't think about them in the context of the API generation. Makes sense. But it doesn't look like test_class_db.h would be enough. We also need to test the global scope (servers/singletons, variant utilities), and each script language built-ins.

Also for the record, in GDNative in 3.x the problem is much worse as all the "private" underscore methods bound for signals/UndoRedo/call also often don't have argument names, since we don't really care and they don't show in the docs. So there's plenty of arg0 and arg1 in the 3.x GDNative JSON: https://raw.githubusercontent.com/godotengine/godot-headers/3.x/api.json

Well, thank god we don't have tests in 3.x then 😛

From test_class_db.h testing alone, there are 17 cases of unnamed parameters, mostly setters:
===============================================================================
[doctest] test cases:     596 |     595 passed |  1 failed | 1 skipped
[doctest] assertions: 2298748 | 2298731 passed | 17 failed |
[doctest] Status: FAILURE!

===============================================================================
C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(833):
TEST SUITE: [ClassDB]
TEST CASE:  [ClassDB] Add exposed classes, builtin types, and global enums
  [ClassDB] Find exposed class

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'AnimationPlayer.set_movie_quit_on_finish_enabled'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'BitMap._set_data'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'ConfirmationDialog.set_cancel_button_text'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'Curve2D._set_data'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'Curve3D._set_data'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'MultiMesh._set_transform_array'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'MultiMesh._set_transform_2d_array'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'MultiMesh._set_color_array'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'MultiMesh._set_custom_data_array'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'OptionButton._select_int'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'PackedDataContainer._set_data'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'PackedScene._set_bundled_scene'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'PolygonPathFinder._set_data'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'ResourcePreloader._set_resources'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'SpriteFrames._set_animations'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'TextEdit.set_fit_content_height_enabled'.

C:\Projects\godot-engine\master\tests/core/object/test_class_db.h(377): ERROR: CHECK_FALSE( (p_arg.name.is_empty() || p_arg.name.begins_with("_unnamed_arg")) ) is NOT correct!
  values: CHECK_FALSE( true )
  logged: Unnamed argument in position 0 of method 'Translation._set_messages'.

I'll see how to test singletons, utility functions, and scripting languages next.

@akien-mga Done! I hope this is to your satisfaction. I've added a second commit that adds tests to ClassDB, Variant, and GDScript, and fixes what these tests have unearthed.

Thanks!


TO API test TestCDNs fails: Expected only one cdn response

I'm submitting a ...

bug report

Traffic Control components affected ...

Traffic Ops

Current behavior:

TestCDNs fails for API v4:
INFO: traffic_ops_test.go:71: 2021-06-17T00:00:33.129707062Z: Using Config values:
                           TO Config File:       ../conf/traffic-ops-test.conf
                           TO Fixtures:          tc-fixtures.json
                           TO URL:               https://localhost:6443
                           TO Session Timeout In Secs:  60
                           DB Server:            localhost
                           DB User:              traffic_ops
                           DB Name:              traffic_ops
                           DB Ssl:               false
               UseIMS:               true
=== RUN   TestCDNs
    cdns_test.go:386: Expected only one cdn response {[] {[]}}
--- FAIL: TestCDNs (1.62s)
FAIL
FAIL    github.com/apache/trafficcontrol/traffic_ops/testing/api/v4     2.130s
FAIL

Expected behavior:

TestCDNs should pass.
Minimal reproduction of the problem with instructions:

go test ./v4 -cfg=../conf/traffic-ops-test.conf -test.v -test.run '^TestCDNs$'

The Fatal call is hiding another error that occurs later in the test - checking for a 400 response code when TO returns 404 when attempting to delete a CDN that doesn't exist


Replace rm -rf with rimraf package to enable project 'npm run dev' on…

If you try to launch npm run dev on Windows machines you will get
'rm' is not recognized as an internal or external command
Of course, because rm -rf in unix command and for this purposes rimraf package exists
https://www.npmjs.com/package/rimraf

Hi @vdytsiak, thanks for a pull requests 👍


Sidekick is delayed: 5-7 minutes until response

Hi,
since around 20 minutes the response of Sidekick is delayed by about 5-7 minutes.
Any chance I can fix it by myself? I read you were trying giving shard restart to the users in 2018.
Kind regards

Edit: Seems like the issue fixed itself within the last 37 minutes.

Had the same issue

#232


Add full support for new Jetstream API

Proposed change
Not all functionality of the new Jetstream API is available here, and it would be great if it were!
Specifically, built-in support for batch processing, which I think was available in the old Java Jetstream API, and is supported in the Golang API, as demonstrated by this example from https://natsbyexample.com/examples/jetstream/api-migration/go :
	cons, _ = stream.CreateOrUpdateConsumer(ctx, jetstream.ConsumerConfig{
		InactiveThreshold: 10 * time.Millisecond,
	})
	fetchResult, _ := cons.Fetch(2, jetstream.FetchMaxWait(100*time.Millisecond))
	for msg := range fetchResult.Messages() {
		fmt.Printf("received %q\n", msg.Subject())
		msg.Ack()
	}

I would like to be able to get messages similarly to the above to pass them to a batch processor.
Thanks!
Use case
Batch processing for greater efficiency
Contribution
If I could convince my employer to let me do it during work time, yes!

Let me know if this is what you are looking for: https://github.com/nats-io/nats.java?tab=readme-ov-file#simplification


Review request where team will not review document does not have history

What happened?
When the secretary of the review team is doing assignments, he/she can mark documents so that "Team will not review version", meaning that there was not enough changes so there is no point of assigning review for that document. This review assignment will then be shown in the Closed review request list, and it correctly lists a state "Team Will not Review Version".
Now if you go to the actual review request page like
https://datatracker.ietf.org/doc/draft-ietf-dots-multihoming/reviewrequest/15694/
there is no indication about that. There is no state "Team will not review version", and there is no history of who did and what.
When the secretary marks document so that review team will not review it, this should also get history lines added to the history, and the status should be shown in the reviewrequest page of the review request.
What browser(s) are you seeing the problem on?
No response
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

Please talk this through with @russhousley and @jennifer-richards at the 114 sprint.


in-dexter:0.7.0

I am submitting

[ ] a new package
[x] an update for a package

Description:

Configurable range delimiter. Defaults to em-dash now.
Support for Ranges and Continuations (range references, f. ff.).
Fix: Consolidate multiple references to the same page.
Breaking: Change enum dict "indexTypes" to "indextype" to comply with the typst naming conventions.
Breaking: Change parameter "indexType" to "index-type" to comply with the typst naming conventions.

Thank you!
For info, you don't have to close and re-open your PRs if CI is failing, you can leave it open until you fix it (and mark it as draft or leave a comment to tell that it should not be merged yet).


Jib Cache Selector - FileAlreadyExistsException

Environment:

Jib version: 3.2.0
Build tool: Gradle 7.3.3
OS: Linux (Jenkins VM)

Description of the issue:
Builds will randomly fail with a FileAlreadyExistsException. It's unclear what unsticks it, it's quite flaky.
Expected behavior:
The build to complete succesfully.
Steps to reproduce:

Unable to provide, it's flaky. Sometimes it'll work, sometimes it won't.

Log output:
Caused by: com.google.cloud.tools.jib.plugins.common.BuildStepsExecutionException: /var/lib/jenkins/workspace/GUL_mock-dataservice_master/build/jib-cache/selectors/86a92a1db96dde1836553acbe913013699c4976077907f3f71d15bc5d034820f
at com.google.cloud.tools.jib.plugins.common.JibBuildRunner.runBuild(JibBuildRunner.java:285)
at com.google.cloud.tools.jib.gradle.BuildDockerTask.buildDocker(BuildDockerTask.java:125)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:104)
... 114 more
Caused by: java.nio.file.FileAlreadyExistsException: /var/lib/jenkins/workspace/GUL_mock-dataservice_master/build/jib-cache/selectors/86a92a1db96dde1836553acbe913013699c4976077907f3f71d15bc5d034820f
at com.google.cloud.tools.jib.cache.CacheStorageWriter.writeSelector(CacheStorageWriter.java:473)
at com.google.cloud.tools.jib.cache.CacheStorageWriter.writeUncompressed(CacheStorageWriter.java:295)
at com.google.cloud.tools.jib.cache.Cache.writeUncompressedLayer(Cache.java:144)

@tlefevre Thank you for the report!
Do you have gradle parallel builds turned on? It sounds like a race condition in the same broad area as #3347.

Hi @elefeint! Yes, our Gradle runner is enabled with parallel builds. However, this particular build is not building jib images in parallel.
Given that, I was unsure if it was related to https://github.com/GoogleContainerTools/jib/issues/3347. Do you think it would be a good idea to disable parallel builds for the jib task?

That would be a good experiment, if your environment allows it.
Another good (independent) experiment would be to turn on jib.useOnlyProjectCache to reduce interference between modules.

The above corruption is in a project that:

Has only a single Gradle module
Only builds a single image via Jib

I'll try disabling parallel first.
According to this link: https://github.com/GoogleContainerTools/jib/issues/1956#issuecomment-530523670 it looks like we're using our local cache, since the cache directory above is stated to be in the build directory? It seems given this, that useOnlyProjectCache would not do anything?

That's correct; @chanseokoh was just explaining to me why jib.useOnlyProjectCache won't work.

Tried used "--no-parallel", the build still failed.
java.nio.file.FileAlreadyExistsException: /var/lib/jenkins/workspace/_api_feature_GUL-5452_gspsupport/server/build/jib-cache/selectors/2cadfb6605804ff1e49f11ea4b53bca7e7f40548af5a1c9c2c5f5cc744f29cde

Tried adding the clean task to the Gradle command. Build still fails.

@tlefevre Try also setting jib.applicationCache to a non-default directory, such as /tmp. The best theory we have right now is that some parts of Jenkins filesystem do not suport atomic file moves.

What we see from the log:
at com.google.cloud.tools.jib.cache.CacheStorageWriter.writeSelector(CacheStorageWriter.java:473)

The line 473 where the exception is thrown is https://github.com/GoogleContainerTools/jib/blob/ff7546207a11e68860cdf35a6499cada62604b48/jib-core/src/main/java/com/google/cloud/tools/jib/cache/CacheStorageWriter.java#L472-L474
It's after Jib got AtomicMoveNotSupportedException, so it's almost certain that the directory /var/lib/jenkins/workspace/_api_feature_GUL-5452_gspsupport/server/build/jib-cache/selectors/2cadfb6605804ff1e49f11ea4b53bca7e7f40548af5a1c9c2c5f5cc744f29cde is on the filesystem that doesn't support atomic move (e.g., network filesystem).

I finally got a hold of someone that could explain a bit more how our Jenkins VMs are put together and there are no available physical discs on them. It's all network filesystems, we have no option of adding physical drives.
Do you have any recommendations?
I don't remember this always being an issue. It appears exclusively, we think, in building Grails applications. We also have a lot of Spring Boot applications that do not have the same error. The difference with Grails is that we have to depend on a few compile tasks, then add extra directories. This could potentially introduce more points into the build where we can get a failure.

That's excellent! How did you end up narrowing down the issue?

We figured that every time a layer got added it'd introduce a risk, which would most likely be connected to the extraDirectories functionality so we figured we'd take a closer look at that.

FTR, as a last resort, once can completely disable concurrency by setting the system/Maven property (e.g., -Djib.serialize=true or setting that in pom.xml), but this can of course be very slow.

@tlefevre Hi, we are having the same issue.
We have the same issue with FileAlreadyExists. In some builds it happen and in others it won't. Really Flakky.
We are using Jenkins on EC2, we don't have a network file system (such as NFS).
Can you help how you managed to solve this problem?
The build is failing every once in a while, on a different target every time

I said so in the comment just before I closed the issue.
Check your extra directories or see if Jib is trying to access the same file repeatedly.


Trying to create a custom widget using example from this repo gives errors.

I am following the Hello world example to create a custom widget. The example does not run properly. In the console of the browser there is a 404 for a file called "jupyter-js-widgets.js".

I am running jupiter in a virtual environment. I am using the following versions of packages
ipywidgets              == 4.1.1
jupyter                    == 1.0.0
jupyter-client          == 4.2.1
jupyter-console      == 4.1.1
jupyter-core           == 4.1.0
A similar issue was also reported here. It said that the problem occurs by using non compatible versions of ipywidgets and jupiter notebook. I think I am using compatible versions but still getting the same error.

+1, cannot creating custom widgets

I talked to @zsameem in the mailing list, the problem was that he had ipywidgets 4.1 installed and was looking at the docs in master (5.0).  The appropriate docs are here: https://github.com/ipython/ipywidgets/tree/4.1.1/examples


Maybe the latest Neo4j not matching to Stormspotter

I use docker to install Stormspotter, but meet issue when uploading resources scanning result.
The issue is that when I do some common query, alway get no results found.

Then I check the logs of results uploading, I found the data may not imported correctly.

However, when I config the docker with Neo4j version 3.5.18, it works well, I can upload the result and get the right output when querying.
So, I wonder if the latest Neo4j not matching to Stormspotter, or have to do some modifications in Stormspotter to adapt the latest Neo4j.
Thanks,
Xing.

nice job .. use 3.5.18 works..

Had the same issue, fixed by changing to 3.5.18 thanks for the pointer!
Can you still access the web interface of the Neo4j container after switching to that version?

Hi,
This version of Stormspotter only supports Neo4j v3.X. The new version will support v4+.


File google-services.json is missing. The Google Services Plugin cannot function without it.

Error:Execution failed for task ':app:processDebugGoogleServices'.

File google-services.json is missing. The Google Services Plugin cannot function without it.
Searched Location:
/Users/home/Watchlist-master/app/src/debug/google-services.json
/Users/home/Documents/Watchlist-master/app/google-services.json

just add google play service then problem will be solved
On Thu, 23 Jun 2016 3:45 pm Jeetu Pal<EMAIL_ADDRESS>wrote:

Error:Execution failed for task ':app:processDebugGoogleServices'.
File google-services.json is missing. The Google Services Plugin cannot
function without it.
Searched Location:
/Users/home/Watchlist-master/app/src/debug/google-services.json
/Users/home/Documents/Watchlist-master/app/google-services.json
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Ronak-LM/Watchlist/issues/6, or mute the thread
https://github.com/notifications/unsubscribe/AHNkzS1Wr9W86qO31ca4yO3YZsx1VDorks5qOlWvgaJpZM4I8oXh
.

Closed as the issues is an exact duplicate of https://github.com/Ronak-LM/Watchlist/issues/5
READ CONTRIBUTING.md


[wasmtime-api] Use HOST call convension in Func signature

Fixes #378

If this gets merged before my PR, I'll rebase and delete the commit that disables the test on Windows.


Support for Numpy 2.0

🚀 🚀 Pull Request
Impact

[X] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Description
Numpy 2.0 changes some of it's behavior in ways that are not compatible with the existing deeplake code.
This PR updates deeplake to be compatible with both 1.x and 2.0
Things to be aware of
Numpy removed support for can_cast() between python types and numpy types as part of https://numpy.org/neps/nep-0050-scalar-promotion.html . This PR makes deeplake's cast checks still support a comparison between a python sample and a dtype, but follows the new numpy standard of not taking the value into account.
Because python ints/floats are np int64/float64s, this means that you can no longer add a python int to an int32 tensor -- you must explicitly create it as an np.int32.
This better matches other codepaths deeplake already has, so is bringing more consistency. But, there may be cases where doesn't work with existing scripts.
Things to worry about

Additional Context

Closing this in favor of a < 2.0 constraint #2880 for now.
Will revisit this as demand for numpy 2.0 increases


[Bug]: Table widget breaks when table name is renamed to Number

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
2 issues are observed when renaming the table.

Table breaks when it is renamed to a number.
When user renames the table to 2 consecutive special characters it successfully renames as '__'

https://loom.com/share/9930dff46f2141f7bf1167256a8e2566
Steps To Reproduce

Drag and drop table widget
In property pane rename the table to number and observe.
2a. In property pane rename the table to 2 consecutive special characters and observe.

Expected behavior: Table must not break when renamed to just number or must show an error message that it is not allowed.
Environment
Production
Version
Cloud

@shwetha-ramesh Does this happen for every widget, API, query? Or is this only for the table widget?

@shwetha-ramesh Does this happen for every widget, API, query? Or is this only for the table widget?

I have observed only in table widget.

Numbers are not valid identifiers in javascript. The issue exists on other widgets as well. Widget won't break but we cannot use the widget properties in js expressions.
we should restrict users from renaming in this case.
somewhat similar to #8881

@sbalaji1192 is right, We should not allow numbers as widget name, I believe that is a platform level change.
cc @riodeuno

Probably should be a high priority issue and not critical. @ajinkyakulkarni ill leave the call to you

@somangshu @sbalaji1192 Yes, numbers should not be the first character in identifiers. It is illegal in JS.
Resolution approach:

We have functions in place which check for entity name uniqueness. (Explorer/Name.tsx uses this, so does PropertyPaneTitle.tsx)
We also have sanitiser functions which sanitise the spaces and special characters while entering the entity names (removeSpecialChars is the function name)

Using the above two features, we should disallow naming entities using numbers as the first character.

I did some analysis on this issue and we can add extra check on names if it starts with a number. Please let me know if you are accepting changes in table widgets before I proceed.


update of documentation

Since we have a new user,  @munechika-koyo, updating the documentation is, in my opinion the next urgent change for tofu.
I created a branch docupdate for this issue.

Hi @lasofivec
It's a great idea to improve the docs. The figures you've added area are also very nice.
I have two suggestions regarding this improvement:

build the documentation automatically via travis and upload it
use sphinx-gallery to generate a gallery of examples
Do you think this would be doable? I could probably help with the setup of sphinx-gallery (since I've done this before).

Hi @flothesof thank's for the feedback. Regarding your points

build the documentation automatically via travis and upload it

Yes, this is for sure the right way of handling the doc. However, the configuration of this can only be done by @Didou09 (currently in the Settings of the project via GitHub). And I think he won't be able to check this for a few more days.

use sphinx-gallery to generate a gallery of examples

I didn't know this, but it looks really nice. If you want to do it, I'll be more than happy :)
We added a few things to the README, and the wikipedia as a quick-fix solution. Hopefully in the near future everything will be in a single place and up to date !

A short note as I progress. It seems that sphinx is not listed as a dependency in setup.py.
As a user, this makes perfect sense.
As a developer, it doesn't.
I suggest to do the following. Add an extra 'dev' option in the dependencies that installs both the testing infrastructure and everything needed to locally generate the docs. This would replace the current 'test' and 'dev' options.
I'm going to add this my sphinx_gallery branch.

I saw this, great idea.

Some more random things: the README mentions IMAS, but I had to google what it is. Suggestion: add a link to an official IMAS document (I found this published paper about it: https://iopscience.iop.org/article/10.1088/0029-5515/55/12/123006/meta but I guess you guys have better link ideas)

For the record, I would say this is left to do:

[ ] Add IMAS reference
[ ] Add instructions on how to install
[ ] Add examples that create images in README
[ ] Add images/gallery corresponding to those images

@lasofivec , I guess with the last progress we can probably consider this issue as "fixed in devel" to include it in the next full release 1.4.2, do you agree ?
We'll open a new one for documentation updates for the following version (1.4.3), just to keep track of progress version-per-version

ok !


Amplify console cant connect a second branch after successful Github App authentication

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.20.1
Amplify CLI Version
12.10.1
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
Deploying a hosting only app with no backend. We've kept aws-exports.js in git to enable usage of Amplify React components (auth and S3) to existing resources.
Describe the bug
After starting a fresh Github app in gen 1 Amplify, and connecting a repo and branch successfully, it's impossible to connect a second branch. Authentication flow with Github completes successfully, but on the "Add repository branch" screen, the next button is always disabled making it impossible to add a new branch.

Expected behavior
Ability to add a second branch from the same repo after the first one is created.
Reproduction steps

Create a new Amplify (Gen 1) app
Choose Github as source
Authenticate
Choose repository with a hosting only setup (no amplify directory)
Choose branch to connect
First connected branch works well, can provision and deploy successfully
Click 'connect a branch' to add a second branch
See that authentication succeeds to Github, but as shown in screenshot above, impossible to click next to create the connection.

Project Identifier
amplify diagnose --send-report

No Amplify backend project files detected within this folder.

Log output
No response
Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @onejgordon, the issue appears to be on Amplify hosting, tried to reproduce this in a project but did not observe this behavior. As the AWS Amplify Hosting repository currently only accepts new feature requests. For technical support, we encourage you to open a case with AWS technical support.
On the case provide the App id and region, any errors observed in the browser debug console.


Separate puc

With this PR when puc is built (gulp build) output of that task will be multiple .js file. Each .js file is responsible for rendering ad of specific format:

amp.js
banner.js
mobile.js
native.js
video.js

Before, when puc was built, in the output we would have:

creative.js (for all formats except native)
native-render.js (only for native format)

Not a single function was changed, all functions were just moved around (some to different files).
Also, some OOP concepts were removed to make treeshaking easier.

Docs PR: https://github.com/prebid/prebid.github.io/pull/3645

@musikele When you get a chance, can you review/resolve the conflicts in this PR?  Thanks.

Hi when I pull down this and try npm ci I get the following error:

Prob because I am using NODE 12, when I use node 16 it works.
So I guess not a big deal but maybe we should commit the changes to package-lock.json as well?

@robertrmartinez Added package-lock.json to fix npm ci.

@musikele looks like we're ready to merge once conflicts are resolved?

@patmmccann came by to check up on things after our discussion today, is the README referencing https://cdn.jsdelivr.net/npm/prebid-universal-creative@latest/dist/%%PATTERN:hb_format%%.js out of sync with actual jsdeliver deployment right now<EMAIL_ADDRESS>is not available. Looks like there is just some flux in state of things, but wanted to bring it up if it mattered.


Compilation issue on Mac OS X

I'm on Mac OS X El Capitan (10.11.6). Elixir version
Erlang/OTP 19 [erts-8.2] [source] [64-bit] [smp:8:8] [async-threads:10] [hipe] [kernel-poll:false] [dtrace]
Elixir 1.4.1
==> html5ever
Compiling NIF crate :html5ever_nif (native/html5ever_nif)...
could not compile dependency :html5ever, "mix compile" failed. You can recompile this dependency with "mix deps.compile html5ever", update it with "mix deps.update html5ever" or clean it with "mix deps.clean html5ever"
** (ErlangError) erlang error: :enoent
    (elixir) lib/system.ex:564: System.cmd("cargo", ["rustc", "--no-default-features", "--release", "--", "--codegen", "link-args=-flat_namespace -undefined suppress"], [cd: "/Users/jonathanlin/Documents/blitz/blitz-cms/deps/html5ever/native/html5ever_nif", stderr_to_stdout: true, env: [{"CARGO_TARGET_DIR", "/Users/jonathanlin/Documents/blitz/blitz-cms/_build/dev/rustler_crates/html5ever_nif"}], into: %IO.Stream{device: :standard_io, line_or_bytes: :line, raw: false}])
    lib/mix/tasks/compile.rustler.ex:49: Mix.Tasks.Compile.Rustler.compile_crate/1
    (elixir) lib/enum.ex:1229: Enum."-map/2-lists^map/1-0-"/2
    lib/mix/tasks/compile.rustler.ex:12: Mix.Tasks.Compile.Rustler.run/1
    (mix) lib/mix/task.ex:294: Mix.Task.run_task/3
    (elixir) lib/enum.ex:1229: Enum."-map/2-lists^map/1-0-"/2
    (mix) lib/mix/tasks/compile.all.ex:19: anonymous fn/1 in Mix.Tasks.Compile.All.run/1
    (mix) lib/mix/tasks/compile.all.ex:37: Mix.Tasks.Compile.All.with_logger_app/1

Which version of rust do you have installed?

Well this is awkward. Didn't realize I needed to have Rust installed.
I library I upgraded seems to have added this to the dependency list without me realizing. Thanks for the quick reply, and sorry!

@jonzlin95 May I ask which library that is?

I think it's philss/floki, but as an optional dependency (and they do document the installation of Rust + HTML5Ever). I'm actually not sure how it crept into my mix.lock file, but upon removing it as a dependency, Floki worked fine.

Ah yeah, that makes sense.
I was slightly confused because I was fairly sure this package was an optional dependency of floki, so I thought it might have been something else.


strip dots in default project_slug

Description
This removes periods from the auto-generated project_slug (and also runs trim for good measure).
Rationale
Otherwise, if you have a "." in your project name (e.g., you used a website domain name as your project name), you will encounter an error about it failing for a project_slug.isidentifier() check.
Use case(s) / visualization(s)
In the old code, if you set project name to "example.com", the default for project_slug will appear as such:
> cookiecutter https://github.com/pydanny/cookiecutter-django
project_name [My Awesome Project]: example.com
project_slug [example.com]:

And if you use the default, at the end of the all the decisions you just made, you’ll encounter:
AssertionError: 'example.com' project slug is not a valid Python identifier.

This isn’t perfect, as other characters can fail too, but I’ve seen dots used enough to see value in adding this. Also, I stylistically chose to replace the dot with an empty string instead of an underscore, it seems to make more sense to me for dots.

OK, sure. I amended the prior commit and pushed it (to keep the PR at 1 commit).

@mrcoles it's best you keep the PR history continuous -- we're squashing branch commits before merging to master anyway, no need to worry.


feat: host_flavor can take a specific id as  multitenant

Description
Host_flavor can take a specific id as multitenant.
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
In this release-
If host_flavor is set to multitenant, this will place the database on a logically separated, multi-tenant machine with minimum resource configurations required for multitenant config.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

Is a whole new example, spinning up yet another database instance on every single PR and CI pipeline run necessary?
Should we change the basic test to use 8G of memory and change one of the two other_test.go tests to use multitenant? It is also less than

@shemau I thought so too but then we just have to add member_memory_mb variable in basic example, that should do it.

IMHO that would be less ongoing maintenance (less code) and by using other_test.go would also appropriately reduce the number of instances spun up for testing.

/run pipeline

:tada: This PR is included in version 3.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Delete manifests/j/JanDeDobbeleer/OhMyPosh/7.62.2 directory

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run


Add version checking to checkUpgradeForCompability

Summary
Ensure both counterparty upgrade and self upgrade version fields are equal in checkUpgradeForCompability
spec ref

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

This might require waiting for some of the other changes in the TRY/ACK handlers (unsure)


[GOBBLIN-1434]Make the maxWaitMills to get a hive client be configurable

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1434

Description

[ ] Here are some details about my PR, including screenshots (if applicable):
By default, maxWaitMills to get a hive client in HiveMetastoreClientPool is set to be -1L, and in this case, the get call will wait for the client object forever if there is no available one. This ticket is to make maxWaitMills configurable, so that after maxWaitMills, it will throw timeout exception. But still, the default value will be -1L.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
unit test

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3267 (cf5de20) into master (f11d68f) will decrease coverage by 37.47%.
The diff coverage is 0.00%.

:exclamation: Current head cf5de20 differs from pull request most recent head 7758d99.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11d68f...7758d99. Read the comment docs.

@hanghangliu Can you help take a look at it when you have a chance? Thanks


[CI] Pin actions/checkout in dependabot

The latest version of actions/checkout bumps its nodejs dependency to v20, which requires a newer glibc version than is available in the ASWF CY22 Docker image.
See errors in https://github.com/OpenAssetIO/OpenAssetIO-TraitGen/pull/46
Ultimately we aim to use GitHub release artifacts (https://github.com/OpenAssetIO/OpenAssetIO/issues/1094), negating the need for Docker (i.e. for making a throwaway build of dependencies). So in the meantime, just ignore major version updates of actions/checkout.
This may also be solved by updating to the CY23 container - https://github.com/OpenAssetIO/OpenAssetIO/issues/984

CI is failing due to https://github.com/OpenAssetIO/OpenAssetIO/issues/970, to be addressed in https://github.com/OpenAssetIO/OpenAssetIO/issues/970


get product description for API without html tags

Hi,
I'm working on API and when I get the flat product, the description/short_description fields are returned as HTML, even if I use strip_tags() function, still some HTML markup like \n \t  exist.
any suggestions to fix this?
Isn't it better if saved as text on the database, not as HTML?

Hi @MostafaAttia
You can override products edit page and can remove the editor (tinymce).
So, now the data will be saved like plain text instead of HTML.

I hope above reply solved you problem. I am closing this issue for now, feel free to reopen.


Feat: Toast notification

Removed the browser alert windows that pop up when clicking a value to copy in favor of a simple toast notification at the top of the screen that disappears after 5 seconds.
Used to be annoying when I mis-clicked and need to hit enter or click "Ok" to be able to copy again.

Open for suggestions about placement and styling if they need improvement!

Thanks :smile: @Peter-512 Awesome work


Missing newline after \id line

While generating the draft, there is no new line character after the \id . This causes creation of an invalid usfm.
eg:
\id MAT \c
This issue was preventing users from importing the generated text into Autographa for further editing.

Fixed
Edited the line

962: out_final = re.sub('(\\id .*)','\id ' + str(book_name), out_final)

962 out_final = re.sub('(\\id .*)','\id ' + str(book_name) + "\n", out_final)


丰富文档/CI增加了release自动化

PR 类型：

[ ] 新功能 Feat
[ ] 缺陷修复 Bug
[x] 文档改进 Doc
[x] 重构和项目优化 Refactor or Perfs
[ ] 添加测试用例 Test

❗ 请务必确保：

[x] ci actions checker钩子执行正确✅
[x] 代码经历过不少于 1 遍书写-构建-使用的自测流程
[x] 有描述清晰的组件文档
[x] TS 类型定义完整且没有恶意 any

⚠ 请尽量保证：

[x] 有完善的组件测试，覆盖率不低于 85%

⚠注意

在forked repo里进行了squash（因为ci本地一直搞不好，提交了很多重复message的commits），所以可能出现不可预知的bug。如果有就改。
修改内容几乎全部在文档，所以建议通过vercel-preview看效果，比code review要好。
现在release message可以自动生成了，这需要更规范的commit message，可以参考antd的规范。谁有时间可以提个「git message的规范的PR」来规范一下。 @jeekliang  @Fukiii

Codecov Report

Merging #126 (3c47ffe) into master (e88eed1) will increase coverage by 0.47%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   87.56%   88.04%   +0.47%
==========================================
  Files          17       17
  Lines         362      368       +6
  Branches      134      139       +5
==========================================
+ Hits          317      324       +7
+ Misses         43       42       -1
  Partials        2        2

Impacted Files
Coverage Δ

src/date-picker/index.tsx
92.85% <80.00%> (-0.90%)
:arrow_down:

src/button/index.tsx
100.00% <100.00%> (ø)

src/decode-phone/index.tsx
93.33% <100.00%> (+6.66%)
:arrow_up:

src/watermark/index.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88eed1...3c47ffe. Read the comment docs.

Codecov Report

Merging #126 (3c47ffe) into master (e88eed1) will increase coverage by 0.47%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   87.56%   88.04%   +0.47%
==========================================
  Files          17       17
  Lines         362      368       +6
  Branches      134      139       +5
==========================================
+ Hits          317      324       +7
+ Misses         43       42       -1
  Partials        2        2

Impacted Files
Coverage Δ

src/date-picker/index.tsx
92.85% <80.00%> (-0.90%)
:arrow_down:

src/button/index.tsx
100.00% <100.00%> (ø)

src/decode-phone/index.tsx
93.33% <100.00%> (+6.66%)
:arrow_up:

src/watermark/index.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88eed1...3c47ffe. Read the comment docs.


CAMEL-18456: convert camel-atom to camel-test-infra-jetty

Checkstyle issue is unrelated, so we are good to merge.


GitHub action

Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an x in each [ ])

[ ] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[ ] I've read and agree to the Code of Conduct.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@eec58c4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   82.32%
=======================================
  Files           ?        8
  Lines           ?      758
  Branches        ?      250
=======================================
  Hits            ?      624
  Misses          ?       78
  Partials        ?       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec58c4...00da09c. Read the comment docs.


permission deny call to homes

Hello, your project seems very interesting to me. I try to run it but I get this error message.
Do you know what permission this refers to?

The message 'Token expires...' is OK and proves that your Tuya login details are accepted!
The ERROR is about the API (the second is consequential):
Cloud Services - API Reference - Smart Home - Smart Home Basic Service - Home Management - Search for Home
And from Tuya documentation:
1106 | permission deny | No permission. | You are not authorized to access the API or device. Find the error details by TID from the API logs, or check if the device has been linked.
We need to find the source of the error, but I can't duplicate the situation.
What I can do is to ignore the error: But the presence of one Home is essential.!
Do you have one Home defined? (in SmartLife 'Home Management' page)?
Try to define one home.
You should provide me with information on the structure of the Home you use, whether you are the 'administrator' etc...

A tested a patch that you can apply yourself, so as not to block the program.
In the file 'tuyaui02.1.js':
before:
  445      sleep(20);
  446       const h = callAPI('GET', "/v1.0/homes/" + home);

after:
  445      sleep(20);
  446       const h = callAPI('GET', "/v1.0/homes/" + home)  || {} ;

In the image, how the tree looks without 'homes': devices are still grouped by 'rooms', but they are isolated.
Best regards

Hi, When reviewing the code I see that after obtaining the token, the next step consults the existing spaces and the next one uses the id of the space found to consult as a home but that is not the id of the home but of the space.

It's correct.
"Space" is an abstraction introduced with the API ver 2,
The smart-home definitions ("home", "room",...) are derived from the abstract space definitions. (ver.1).
The code is correct and works.
Again: the problem is Tuya ERROR in API call.
Have you set the correct       "const data_center"  in 'config.js' ?

I confirm: after further tests the cause of this behavior is caused by an error in the "data_center" value: not consistent with the one used by SmartLife/Tuya.
see https://github.com/tuya/tuya-home-assistant/wiki/Countries-Regions-and-Tuya-Data-Center
Sincerely
In version 2.2 I will capture the error and add a specific warning.


IPFS: Application Redirects

Overview
Shapeshift Web v2 needs to handle 404s with an ipfs-404.html that returns the actual index.html + a HTTP 404 response code, or a meta-direct to /index.html.
Reference
Extra context:
Handle 404s with a ipfs-404.html that returns index.html with a HTTP 404 response code, or a meta-direct to /index.html.
Acceptance Criteria
Application can handle 302 or meta directs when running on IPFS.
Screenshots/Mockups
No response
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info

partially solved by hash routing https://github.com/shapeshift/web/pull/1457

outstanding scope of work - add an ipfs-404.html page to /public and with an html meta redirect back to index.html
docs - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta


Seperating node constructor from the replay and other sync logic

Currently, the CometBFT node is initialized using NewNode (or its variants). However, this is not exactly a traditional constructor, as it doesn't return the node instance until the node has synced with the network, either through block-sync or state-sync. This creates challenges for applications built on top of CometBFT, as the app cannot access the CometBFT state until the network synchronization is complete.  This makes it really hard to have a consistent view of state across the nodes especially the ones that requires consensus on cometbft.

Validator set
Consensus Params etc.

Is there a reason why the network sync can't be moved to node.Start() and free the node constructor from this?
node, err := cometNodes.NewNodeWithContext(
		ctx,
		conf,
		privateValidator,
		&p2p.NodeKey{
			PrivKey: privateKey,
		},
		proxy.NewConnSyncLocalClientCreator(app), // "connection-synchronized" local client
		genesisDocProvider(genDoc),
		cometConfig.DefaultDBProvider,
		cometNodes.DefaultMetricsProvider(conf.Instrumentation),
		NewLogWrapper(logger),
	)

Other issue: Is there a reason why cometbft proposes blocks using node addresses rather than public key?

This is more of a feature-request than a bug, can be moved there.


Deprovision: Find and delete all resource created by NATS manager.

Description:
removing the NATS CR from a cluster should result in a full removal of the resources created by the module.
Acceptance:

[ ] all resources that have been created must be removed
[ ] existing streams blocks removal of the component. (Finalizer will not be removed until it is safe to terminate them)

As long as there are Subscription CRs in the cluster, we cannot delete the NATS CR.
If there is any other stream in JetStream apart from sap, then we will not delete the PVCs.

for the sap stream, we know that watching the subscriptions is one solution. Another approach is to check consumers on configured streams. This solution should work with all streams even if they are not used by eventing

If CR was deleted and you cannot read stream information I would delete the cluster. No point in keeping it as it doesn't work and user requested deletion.


Johnrey edits

asset is now rotatable
can generate canvas
download as image
share to facebook
fix on url

pr ko, accept ko


fix: 108 - Fix for Firestore database create cmd.

Modified the readme files for updates regarding the correct command to create firestore database.

Hi Akshay, thanks for the PR.
I tested it but got an error when running:
gcloud firestore databases create --location="${FIRESTORE_DB_LOCATION}"

ERROR: (gcloud.firestore.databases.create) Resource in projects [...] is the subject of a conflict: Database already exists. Please use another database_id

This is because after gcloud app create --region="${APP_ENGINE_LOCATION}", a Firestore DB is already created in Datastore mode.
My suggestion: Use firestore update to native instead of create, see here

Hello David,
thanks for your suggestion, I have updated the files, please review them according to your convenience.

Thanks Akshay !


Vaporization Memory Management

I'd like to know more about this particular technique mentioned here:
https://www.slightknack.dev/perma/master/131/53d2e32b388719c6165058f69621281fb78b5669434cf69b6f704fde2eb35969
Do you think you could finish the blog post or give me a brief rundown here?
Also, I think your software has a lot of potential, hitting "watch" on GitHub for future development ;)
One more thing, I'm intrigued by the Veritable Computation Initiative but little information is given about it. Is a website coming soon?
🐝

The website's a bit outdated: So vaporization was a memory management technique I was working on for a while. It's essentially SSA + COW — at compile time, the compiler tracks how data moves through the program, and automatically determines the lifetime of certain objects. Using this information, it optimizes away what it can, and leaves simple instructions for the interpreter to automatically free memory when applicable. This circumvents the heap, and essentially makes just about everything really fast alloca-style allocation.
The main issue with this is closures. When you close over some data, you're basically making a reference to some data. This isn't an issue for COW semantics, the issue is mutation. Why have mutation in a functional language? a quote from withoutboats:

As I said once, pure functional programming is an ingenious trick to show you can code without mutation, but Rust is an even cleverer trick to show you can just have mutation.

Passerine isn't Rust, but it takes inspiration from it. Some problems can be solved elegantly with mutation, there's no other way to put it. I'm considering removing mutation in closures, but I'm still thinking about if. If I do that, I can move back vaporization, which will be pretty cool. For now passerine is just reference-counted with mechanisms in place to prevent cycles.
I've got to go for now, but I'll follow up with what Veritable is about later. Hope that helped clear some things up! (This was a super quick reply, so please forgive any silly eratta.)

Thanks for the quick reply! That's very interesting, I like it

One more thing, I'm intrigued by the Veritable Computation Initiative but little information is given about it. Is a website coming soon?

I'm working on a website, but it might be a while before I pull everything together.
What is Veritable? From kitbag's¹ README:

Many issues seem daunting today because we do not yet have the tools to solve them. Veritable is an open initiative to develop new tools to solve today's [and tomorrow's] technological problems. There are currently two publicized Veritable projects:

Passerine, a small extensible programming language.
Solidarity, a distributed platform built for communication and collaboration.

So to answer your question: Veritable is an Initiative to develop tools to tackle hard technological problems (we might not know exist yet). I'm starting small – with a programming language – but I'm in this for the long run:

My next goal [after Passerine has matured] is Solidarity, another project of the Veritable Computation Initiative. It will act as an alternative to the world-wide-web; built around privacy, collaboration, versioning, and local-first applications. I plan to use Passerine, Rust, and Wasm to build this future.
— Me, quote from here

My overarching goal is to create an organization of project leaders each overseeing and actively working on a bazaar-style open-source passion projects/tools (cornerstones) that further these goals.
It's ~fairly~ very ambitious, and will undoubtedly take a lot of hard work to pull off. This is something that will happen on the order of years, not days or weeks. I want to do it the right way: I'm still working out how leaderless merit-based governance, contribution recognition, project sponsorship, and a number of other factors can work together to create a strong, directed, – well – Initiative toward a common goal. I know it all sounds a bit crazy – I need to take things one step at a time – but I'm putting in the work, and hoping for the best.
😄
–

Kitbag being the (WIP) protocol that underpins Solidarity.

I appreciate the detailed reply! I'm super interested in stuff like this, and I'll be watching your progress from afar.
As a side note, you might be able to get some general inspiration from Urbit because they're doing something completely different (OS dev), but starting at ground 0 with a base programming language. The solutions to their various implementation challenges may be helpful to you.
I wish you the best on achieving your dreams with this/these projects!


Support the upcoming TZInfo v2.0.0 release

I'm the maintainer of the tzinfo gem. et-orbi currently depends on tzinfo with open-ended version constraints.
I'm working on a new major release of tzinfo (v2.0.0), which I hope to release sometime in the coming months. This will break backwards compatibility in a few ways that affect et-orbi:

The TimezonePeriod#to_local and TimezonePeriod#to_utc methods have been removed. Timezone#utc_to_local and Timezone#local_to_utc should be used instead.
TZInfo::TransitionDataTimezoneInfo has been replaced with TZInfo::DataSources::ConstantOffsetDataTimezoneInfo and TZInfo::DataSources::TransitionsDataTimezoneInfo.
Methods that return local times (such as Timezone#utc_to_local) now return results using the appropriate local UTC offset instead of always using UTC.

This pull request includes changes that make et-orbi compatible with both the upcoming tzinfo v2.0.0 release and existing tzinfo releases.
To test with the current development version of tzinfo instead of a released version, you can add the following line to the Gemfile:
gem 'tzinfo', git: 'https://github.com/tzinfo/tzinfo.git'

Hello @philr, yes, I know who you are. I follow you. Thanks for all your work. It's everywhere Ruby is.
Thanks for this, it spares me many many headaches.
Have a nice day!


records: remove from community

closes https://github.com/inveniosoftware/invenio-rdm-records/issues/1163

superseed by https://github.com/inveniosoftware/invenio-rdm-records/pull/1178


Herbal Measure returning homeopathy prodoucts

The herbal measure has started to return homeopathic products (see example) Checking the measure definition makes it most likely that homeopathic products are included in the table ebmdatalab.richard.herbal_list  as they are probably tagged in dmd by BSA as herbal.
Querying the table (SQL below) however only returns  Strains 9% homeopathic cream
Any ideas @richiecroker ? I'm sure I am doing something wrong on investigation.
SELECT *
FROM `ebmdatalab.richard.herbal_list`
WHERE name like "%homeo%"

These products all seem to have a code of "Homeopathic presentations - proprietary" - possibly incorrectly?

Here is a list of all the dm+d objects with that BNF code: https://openprescribing.net/dmd/bnf/190203000BBAAA0/relationships/.
This is derived from the latest mapping from the BSA (from September).  We could contact them about mistakes in the mapping, but as their mapping page says "The next version is currently delayed", I'm not hopeful!

@richiecroker How is richard.herbal_list curated?  Is it the current licence authority in dm+d?

And what should the BNF code be for these?

@inglesp yes anything with THR license in dm+d.
Sort answer I think is that mapping is wrong.  They are all mapped to same BNF presentation code, which is a shame.  I think the only thing we can do is exclude 190203000BBAAA0 from that measure.

They don't seem to have understood difference between "herbal" and "homeopathic"

I need to update list anyway, as it should be grouped and it isn't, leading to multiple lines for same product.  I will do that now.

Any update on this @richiecroker ?

@richiecroker @inglesp  does this PR fix this issue?

@brianmackenna yes it does


Asset Registry

pallet asset-registry

close https://github.com/paritytech/trappist/issues/51
adds primitives/xcm

integration tests

add tests for pallet asset-registry based on parachains-integration-tests
https://github.com/paritytech/trappist/issues/59

xcm-playground.toml

[BREAKING CHANGE]  - requires zombienet v1.2.67 or later - hrmp channels are now defined with camel_case, using older zombienet versions will not work (https://github.com/paritytech/zombienet/pull/390)
specify node ports (for parachains-integration-tests)
reduce relaychain validators from 4 to 2 (to optimize resource consumption)
increase collators per parachain from 1 to 2 (to ensure stable block production)

Looks great, thanks @bernardoaraujor ! Adding a last comment re. a potential later improvement: it could make sense to inject the multi-location validation logic via the Config trait.


Add Aave v3 LINK.e

Adds Aave Avalanche v3 LINK.e. API is deployed already.
Vault: 0x49cBd37fb87312C506fF84c7585A401C4377dDeD
Strategy: 0x0E6470E890A67c7BCdB818A9724d7E4E60716840

Need to run locally. ID is wrong and no apy loads.

Hey @MirthFutures, updated the ID, my bad. Checks are failing because of other pools. Let me know if I can do something else.


[Docs] ggml: add TriLM and BitNet documents in basic/README.md

After the following pull requests are merged, the TriLM and BitNet models will be supported by the ggml plugin with model type TQ1_0 and TQ2_0:

https://github.com/ggerganov/llama.cpp/pull/7931
https://github.com/ggerganov/llama.cpp/pull/8151

Hello, I am a code review agent on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Is it okay to use KAN for something other than PDE calculations, like MLP?

Is it acceptable to use KAN as a way to approximate f(x) when computing expressions such as y = g(f(x)) over other layers or functions rather than over a function for y = f(x), and are there any disadvantages to using adam as an optimizer rather than LBFGS for KAN models?

yes, totally! Just that I need high precision and my models aren't so big, I used LBFGS. if you don't need high precision or need efficiency, Adam is better.


Use nameof() in BoundParameters.ContainsKey()

We should replace code like BoundParameters.ContainsKey("Delimiter") with BoundParameters.ContainsKey(nameof(Delimiter)).
Old pattern come from old C# (<6.0) without nameof().

@SteveL-MSFT
There are still some examples of the old code. They can be found by BoundParameters.ContainsKey(". It is related to parameters like "WhatIf", "TotalCount" and so on. I don’t know how to fix them correctly and forced to leave it to your team, sorry.

@iSazonov no worries, I appreciate the work you've already done!


Handle 429 Retry-After header

Closes #43.
I don't love how this is tested, so if you know of a better approach I am more than happy to implement it.

Awesome - always more to learn - thank you!

Thank you!


Move CHANGES to project wiki

For Issue #7
Release Note added on the wiki page.

Any reason to use Wiki when we can just list the changes in the release description?
See: https://github.com/OHNLP/MedTagger/releases

That will work. Should we add historical changes (<1.0.3), too?


[wish,wip] wacoq build

This issue is to declare my intent and gather early feeback.
For the MC2022 school I'm preparing both platform installers and an online deployment based on wacoq. I'm amazed I could run Elpi, Hierarchy-Builder, Mathcomp (2.0+alpha), Algebra Tactics at a reasonable (for teaching purposes) speed in the browser with no stack overflows and minimal (if no) change to the original package sources.
In particular I'm working on a script which builds the wacoq deployment based on opam packages (rather than the current jscoq addon system). The idea would be that the same package pick of the platform also gets compiled/packaged for wacoq, hence wacoq addons need to be in 1:1 correspondence with actual opam packages (modulo required patches, if any), which today are not (hence the reason of existence of my scripts).
Open issues:

[ ] deployment URL is hardcoded. I only managed to hardcode a file:///absolutepath or https:// URL in wacoq-bin/src/backend/core.ts it would be nice if one could have the same build be tested locally and remotely

CC @corwin-of-amber @ejgallego

It makes indeed sense to have a way to turn an opam package into a wacoq package; have you looked at the jscoq/wacoq SDK ? Shachar gave a presentation at the Coq workshop which should be in youtube.
Main problem with opam is that it is really a PITA to instrument or to develop properly with it; in many scenarios you want to have a build workspace where you can rebuild jscoq + some addons in a fully incremental way (as to test quickly) ; but indeed, looking forward to have better addon build setup.

I see the approach based on dune and composition the main problem, the extra speed is not worth the complexity IMO.
It is not the role of the addons system to decide how packages are built or installed.
I want to package addons from the opam root, where they are installed in a standard way, not from a git checkout of a submodule which clones an upstream repo, superposes it with dune files, etc... to finally package what is in _build/ (which is also in the opam root after installation).
I don't want to maintain extra build systems, at most a simple patch. All the addons above build just fine without the dune overlays. The most tricky one due to the linking problem (I'm on 8.15) is elpi, and the patch is 1 line for an extra -dontlink (to disappear after findlib becomes usable in wacoq) and 2 lines to remove the call to Boot.Env.init (still unclear to me why it is needed, but it is). These I can maintain as part of wacoq addons, since they are specific to it.
If you package from the opam root installation you don't need to recompile .vo files to work on the packaging system, while the current addon setup mixes the two (dune does both the build of the package and the npx packaging).
I don't see why they can't be separated, e.g. move all the npx calls after the facts.
This is how the other installers of the platform are built.

deployment URL is hardcoded. I only managed to hardcode a file:///absolutepath or https:// URL in wacoq-bin/src/backend/core.ts it would be nice if one could have the same build be tested locally and remotely

I'm unsure I understood this, but that's a jsCoq issue please open an issue there, we have some improvements (see the PR "towards require.resolve") , but not sure if that will fully fix the problem you see.

It may be because I'm on the 8.15 branch, but wacoq needs to "upload" the coq worker, and the wa binary needs to be addressed somehow. Unfortunately it seems to only like absolute filesystem paths or absolute urls, while one would just want to use relative urls. I don't understand why browsers refuse to fetch from relative urls.

Oh I see, I have little idea about the restriction on relative paths (Shachar is the expert for this), but basically in the config options we used to pass the path, which I agree is a bit of a pain.
Tho, it is not hard to have the reference .html code look at the url of the page and set the path to jsCoq initalization properly.
On the topic of how wacoq handles paths, indeed I think the 8.16 / 8.17 branch was also improved.

Triage note: we close this issue because we are already struggling with maintaining the major platforms we do support. Also according to @rtetley wacoq/jscoq only works with Coq 8.17.

Note, wacoq / jscoq / coq-lsp work fine with Coq master.

@ejgallego : I see - there was some misunderstanding then. Does it also work with 8.19 or 8.20? Otherwise we can reopen it and set the mile stone to 8.21.

As of today we test our setup with Coq master, so indeed, it should work on 8.21.
What we haven't done is newer releases of jsCoq for Coq 8.18 and onwards, but this is due to a lack of resources.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!
On Sun, Aug 1, 2021 at 4:02 PM google-cla[bot] @.***>
wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle%2Fit-cert-automation-practice%2Fpull%2F15882
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/it-cert-automation-practice/pull/15882#issuecomment-890577593,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE45DQEW43SLA4TTIPDYEILT2WR57ANCNFSM5BLOUUQQ
.


Fix pool cards width

update pool cards grid to 3 columns maximum

Delicious. Ty!

Some visual feedback here
https://www.notion.so/modern-edamame/Responsive-design-VQA-ff4f4e7aaa244f88aae072c432c4434e
Repeating here some question:

Are we not yet implementing the Pools and tokens filters?
Are we not hiding the nbr of tokens for the reward into a tooltip/info icon, on the APR value?


I have problem with upgrade to flutter 1.0

Upgrading Flutter from C:\flutter...
Updating f37c235c3..5391447fa
error: Your local changes to the following files would be overwritten by merge:
        packages/flutter_tools/gradle/flutter.gradle
Please commit your changes or stash them before you merge.
error: Your local changes to the following files would be overwritten by merge:
        dev/automated_tests/pubspec.yaml
        dev/benchmarks/complex_layout/pubspec.yaml
        dev/benchmarks/microbenchmarks/pubspec.yaml
        dev/bots/pubspec.yaml
        dev/devicelab/pubspec.yaml
        dev/integration_tests/android_semantics_testing/pubspec.yaml
        dev/integration_tests/android_views/pubspec.yaml
        dev/integration_tests/channels/pubspec.yaml
        dev/integration_tests/external_ui/pubspec.yaml
        dev/integration_tests/flavors/pubspec.yaml
        dev/integration_tests/platform_interaction/pubspec.yaml
        dev/integration_tests/ui/pubspec.yaml
        dev/manual_tests/pubspec.yaml
        dev/tools/pubspec.yaml
        dev/tools/vitool/pubspec.yaml
        examples/catalog/pubspec.yaml
        examples/flutter_gallery/pubspec.yaml
        examples/hello_world/pubspec.yaml
        examples/layers/pubspec.yaml
        examples/platform_channel/pubspec.yaml
        examples/platform_channel_swift/pubspec.yaml
        examples/stocks/pubspec.yaml
        packages/flutter/pubspec.yaml
        packages/flutter_driver/pubspec.yaml
        packages/flutter_goldens/pubspec.yaml
        packages/flutter_goldens_client/pubspec.yaml
        packages/flutter_localizations/pubspec.yaml
        packages/flutter_test/pubspec.yaml
        packages/flutter_tools/pubspec.yaml
        packages/fuchsia_remote_debug_protocol/pubspec.yaml
Please commit your changes or stash them before you merge.
Aborting

C:\Users\sanpo>flutter upgrade -v
[  +71 ms] executing: [C:\flutter\] git rev-parse --abbrev-ref --symbolic @{u}
[ +169 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +3 ms] origin/beta
[        ] executing: [C:\flutter\] git rev-parse --abbrev-ref HEAD
[  +78 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] beta
[        ] executing: [C:\flutter\] git ls-remote --get-url origin
[  +81 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[        ] executing: [C:\flutter\] git log -n 1 --pretty=format:%H
[  +71 ms] Exit code 0 from: git log -n 1 --pretty=format:%H
[        ] f37c235c32fc15babe6dc7b7bc2ee4387e5ecf92
[   +1 ms] executing: [C:\flutter\] git log -n 1 --pretty=format:%ar
[  +79 ms] Exit code 0 from: git log -n 1 --pretty=format:%ar
[   +1 ms] 2 months ago
[   +2 ms] executing: [C:\flutter\] git describe --match v*.*.* --first-parent --long --tags
[  +84 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[   +1 ms] v0.9.4-0-gf37c235c3
[ +159 ms] executing: [C:\flutter\] git rev-parse @{u}
[ +125 ms] 5391447fae6209bb21a89e6a5a6583cac1af9b4b
[   +2 ms] Upgrading Flutter from C:\flutter...
[   +7 ms] executing: [C:\flutter\] git pull --ff-only
[+3374 ms] Updating f37c235c3..5391447fa
[   +5 ms] error: Your local changes to the following files would be overwritten by merge:
[   +7 ms]      packages/flutter_tools/gradle/flutter.gradle
[   +1 ms] Please commit your changes or stash them before you merge.
[   +1 ms] error: Your local changes to the following files would be overwritten by merge:
[   +1 ms]      dev/automated_tests/pubspec.yaml
[   +1 ms]      dev/benchmarks/complex_layout/pubspec.yaml
[   +1 ms]      dev/benchmarks/microbenchmarks/pubspec.yaml
[   +1 ms]      dev/bots/pubspec.yaml
[   +1 ms]      dev/devicelab/pubspec.yaml
[   +1 ms]      dev/integration_tests/android_semantics_testing/pubspec.yaml
[   +1 ms]      dev/integration_tests/android_views/pubspec.yaml
[   +4 ms]      dev/integration_tests/channels/pubspec.yaml
[   +1 ms]      dev/integration_tests/external_ui/pubspec.yaml
[   +1 ms]      dev/integration_tests/flavors/pubspec.yaml
[   +1 ms]      dev/integration_tests/platform_interaction/pubspec.yaml
[   +1 ms]      dev/integration_tests/ui/pubspec.yaml
[   +1 ms]      dev/manual_tests/pubspec.yaml
[   +1 ms]      dev/tools/pubspec.yaml
[   +1 ms]      dev/tools/vitool/pubspec.yaml
[   +2 ms]      examples/catalog/pubspec.yaml
[   +3 ms]      examples/flutter_gallery/pubspec.yaml
[   +1 ms]      examples/hello_world/pubspec.yaml
[   +1 ms]      examples/layers/pubspec.yaml
[   +1 ms]      examples/platform_channel/pubspec.yaml
[   +1 ms]      examples/platform_channel_swift/pubspec.yaml
[   +2 ms]      examples/stocks/pubspec.yaml
[   +1 ms]      packages/flutter/pubspec.yaml
[   +1 ms]      packages/flutter_driver/pubspec.yaml
[   +4 ms]      packages/flutter_goldens/pubspec.yaml
[   +1 ms]      packages/flutter_goldens_client/pubspec.yaml
[   +4 ms]      packages/flutter_localizations/pubspec.yaml
[   +1 ms]      packages/flutter_test/pubspec.yaml
[   +2 ms]      packages/flutter_tools/pubspec.yaml
[   +2 ms]      packages/fuchsia_remote_debug_protocol/pubspec.yaml
[   +1 ms] Please commit your changes or stash them before you merge.
[   +1 ms] Aborting
[  +41 ms] "flutter upgrade" took 3,715ms.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:26:3)
#1      UpgradeCommand.runCommand (package:flutter_tools/src/commands/upgrade.dart:53:7)
<asynchronous suspension>
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:372:18)
#3      _asyncThenWrapperHelper.<anonymous closure> (dart:async/runtime/libasync_patch.dart:77:64)
#4      _rootRunUnary (dart:async/zone.dart:1132:38)
#5      _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#6      _FutureListener.handleValue (dart:async/future_impl.dart:129:18)
#7      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:642:45)
#8      Future._propagateToListeners (dart:async/future_impl.dart:671:32)
#9      Future._complete (dart:async/future_impl.dart:476:7)
#10     _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#11     _AsyncAwaitCompleter.complete.<anonymous closure> (dart:async/runtime/libasync_patch.dart:33:20)
#12     _rootRun (dart:async/zone.dart:1124:13)
#13     _CustomZone.run (dart:async/zone.dart:1021:19)
#14     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23)
#15     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#16     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#17     _runPendingImmediateCallback (dart:isolate/runtime/libisolate_patch.dart:115:13)
#18     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:172:5)

Please commit your changes or stash them before you merge.

https://github.com/flutter/flutter/wiki/Workarounds-for-common-issues#flutter-installation-corrupted should help get around that.
Please consider asking support questions in one of the other channels listed at http://flutter.io/support .

Thank you for all. I can upgrade flutter 1.0

Just FYI, I had this same problem and the link above from @zoechi fixed it perfectly.  No idea why git thought I had changed those files, I'm guessing my flutter upgrade command bombed out along the way...


v0.3, switched to XML for parsing

Mostly the changes are separation of declaration and definition and inclusion of tinyxml2 for better parsing. Also some changes to API to improve it (string to const string&, maps for Factories instead of plain strings, etc.)

Also C++17 cause looks like we can switch to that on software we use.


[assemble] JPackage does not register custom launcher

The jpackage assembler has an option to configure custom launchers which is not used at all. The log shows that -add-launcher is never passed as an argument as it should be.
Environment Information

Operating System: N/A
JReleaser Version: 1.0.0
JDK Version: N/A

Hi @aalmiray, how can we test any part of the core/jreleaser-assemblers? I didn't seen any test folder in there (I would like to create one, if that's a good idea). Maybe newbie question, but I didn't seen a lot of tests in the project at all; is it intended?

Hi @Shawoll, that is right. The project is light on unit tests at the moment. Performing tests on assemblers, tool processors, announcers, etc takes a lot of effort and coordination. For the time being these kind of tests are performed manually (not ideal in the long run). There are also some smoke tests (review files inside .github/workflows) that can tell immediately if something is horribly broken on the surface as there are no assertions at the moment. We've been able to catch plenty of errors in this way but of course more automation would be preferred.
For the use case in point you'd have to ensure that the jpackage configuration created the extra launcher scripts. For this you need a Java project, configure jlink & jpackage, run the assembly, check the file system for a given file then checks its contents. That, or mock a lot of stuff which I think would be the wrong way to go.

Thanks. Of course, I've started working on this issue (as much as my family time allowed me :) ) and I like working on it. Yeah, the steps to reproduce this were little challenging to me, since I needed to configure JLink and other stuff, but I am making a nice progress and soon enough, I should have the pr ready for the review. I get it now, good starting issue: requires a knowledge of the system and synthetizes a lot of interesting features. I'll stay in touch. Thanks for the previous reply.

Hi @Shawoll, we're planning to release 1.2.0 by August 27th. If your changes are ready to merged in the coming days then please file a PR to have it included in that release. Thanks! 😄

Hi, currently I am unavailable, but as soon as I get to my workstation, I'll for sure file a PR. Thanks for the date reminder!


Mobile layout for storybook version 4

Mobile layout for storybook version 4
Hi, I love storybook and it is really helping me creating a React component library of React components using Bulma CSS framework.
I updated to storybook v4 and the layout on mobile has a font that ia too small, it seema to be not responsive, any hint?
Steps to reproduce
Just deploy a storybook v4 and look it on a mobile device, or see this storybook:
http://g14n.info/trunx
version of Storybook

@storybook/react 4.0.2

Affected platforms
Any mobile
Work summary
Please provide a responsive layout or give some tips to achieve it in a storybook build.
Who to contact
https://github.com/fibo

@igor-dv 	thanks for the hint, I tryed to modify font size, but to achieve the result I want, i.e. make it look nice on a mobile device, this meta tag (or something similar) is needed
<meta name="viewport" content="width=device-width, initial-scale=1">

hence I added a manager-head.html file as documented here with the meta tag above.

Thanks @fibo - that's exactly what I was looking for. I know it's important to prevent the default <head> of the main Storybook UI from being polluted, but is there a reason that I can't think of, that this particular viewport tag isn't included by default?
I think it's a fair assessment to say that most sites being built with Storybook are intended to be responsive (i.e. will usually have the above viewport tag), and that Storybook itself is intended to be responsive after PR #3337. But without setting device-width and initial-scale for the main UI, when viewing Storybook on mobile, it will still be significantly zoomed out.
I'm sure there could be a justification I'm not thinking of, but would people be open to a PR that includes @fibo's meta tag in the default head?

It would be also nice to have the navigator on mobile to be closed after click on a menu entry.