Fill in public key info from private key info?

When creating a DH key using EVP_PKEY_fromdata using the FFC_P, FFC_G and PRIV_KEY parameters, this will result in a key that only contains the private key information, but not the public key information. Is there some way to generate the public key from the private key using the EVP_PKEY API?
We currently have some code that manually computes the public key using BN_mod_exp_mont, which seems extremely dangerous to me, but I couldn't find a suitable API for this purpose.

Hmm, this looks like a serious deficiency of the new API when compared to the deprecated low level DH calls. The DH_generate_key() allowed computing just the public key when a private key was already present in the DH structure.
We could use that functionality with EVP_PKEY_gen() however the DH provider implementation does not allow skipping the parameter generation. This looks like a major defect and IMO it can be easily fixable before the release. But giving this is kind of new functionality in the provider(s) I think we need to discuss it within OTC first.

Do we have this problem only for DH?

I think the API problem (compute public key from private key) is a general one, but DH might be the only case where the low-level API provided a way to do so. I think most other key generation functions would always generate a full keypair, even if a private key was already present. At least that's the case for DSA_generate_key and EC_KEY_generate_key.

This problem was discussed back when OTC decided to change the convention for EVP_PKEY objects and consider valid also keys which only include the private components.
From that discussion, I will remark that, from a security perspective, it is paramount that, if public components are to be derived from the private ones, they must be generated when they key is first initialized, not on demand when an operation needs them.

OTC: this is missing feature which we are not going to add in 3.0. We will consider this Post 3.0.

Do we have this problem only for DH?

No, this issue also exists for quantum-safe/post-quantum crypto: One cannot re-create public from private keys for all algorithms there.

when OTC decided to change the convention for EVP_PKEY objects and consider valid also keys which only include the private components

Is this decision/position firm? It seems to contradict this statement from https://www.openssl.org/docs/manmaster/man3/EVP_PKEY_eq.html:

Since OpenSSL private keys contain public key components too the function EVP_PKEY_eq() can also be used to determine if a private key matches a public key

Reason for asking: When implementing a QSC/PQC decoder (decoding a private key) in an external provider, due to the PQ math limitation stated above, a full key pair cannot be re-generated and subsequent key equality tests "become a challenge"...
Thus, and in light of the apparent OTC decision, would it be reasonable to ask for the adaptation of the above statement in EVP_PKEY_eq documentation and probably for a change to the corresponding logic here: https://github.com/openssl/openssl/blob/8b6a7da304d4fdd0de38ddd6037d8a02491e3e4e/crypto/evp/p_lib.c#L344-L346 which seems to equate EVP_PKEY equality with public key material equality (?). This would eliminate the need for "special" key matching code in the oqsprovider.

when OTC decided to change the convention for EVP_PKEY objects and consider valid also keys which only include the private components

Is this decision/position firm? It seems to contradict this statement from https://www.openssl.org/docs/manmaster/man3/EVP_PKEY_eq.html:

Since OpenSSL private keys contain public key components too the function EVP_PKEY_eq() can also be used to determine if a private key matches a public key

...

Thus, and in light of the apparent OTC decision, would it be reasonable to ask for the adaptation of the above statement in EVP_PKEY_eq documentation and probably for a change to the corresponding logic here:
https://github.com/openssl/openssl/blob/8b6a7da304d4fdd0de38ddd6037d8a02491e3e4e/crypto/evp/p_lib.c#L344-L346
which seems to equate EVP_PKEY equality with public key material equality (?). This would eliminate the need for "special" key matching code in the oqsprovider.

This is a reasonable idea, and is quite easy, just change SELECT_PARAMETERS | OSSL_KEYMGMT_SELECT_PUBLIC_KEY to SELECT_PARAMETERS | OSSL_KEYMGMT_SELECT_KEYPAIR.  The documentation will have to be altered, though, since the "explanation" is no longer valid as written (this holds true either way).

This is a reasonable idea, and is quite easy, just change SELECT_PARAMETERS | OSSL_KEYMGMT_SELECT_PUBLIC_KEY to SELECT_PARAMETERS | OSSL_KEYMGMT_SELECT_KEYPAIR. The documentation will have to be altered, though, since the "explanation" is no longer valid as written (this holds true either way).

Thanks for taking this up with #16704. The proposed change above makes me wonder though whether I understood the selection bits correctly: Wouldn't setting OSSL_KEYMGMT_SELECT_KEYPAIR mean that both public and private key must be compared and matched (in the provider's key management match function)? Am I wrong in this understanding? My original assumption/proposal was to simply drop OSSL_KEYMGMT_SELECT_PUBLIC_KEY from SELECT_PARAMETERS | OSSL_KEYMGMT_SELECT_PUBLIC_KEY (and adapt the documentation, of course).

The way selectors have been specified (and implemented mostly) is a set of bits of what's desired, but leaving it to the backend implementations to decide what's reasonable.
This comment says a little more about that (and it's possible that it should be uncommented):
https://github.com/openssl/openssl/blob/398ae8231650c4bd8ddff0e5efd38233c23b1ca0/doc/man7/provider-keymgmt.pod#L203-L208

Could we discuss EVP_PKEY_eq() in #16704, please?

it is unclear to me what the path forward in this issue is.  The initial comment suggests that there is a desire to have an api to compute a DH public key from the private key, but @romen comment strongly suggests that doing so is a security concern, implying that such an api not be provided.
@nikic @romen @t8m any comment here?  Trying to decide if this  should be categorized for a future minor release, or marked as done/not planned

if this should be categorized for a future minor release, or marked as done/not planned

FWIW, I'd vote for the latter if the topic is not re-labelled to explicitly refer to DH keys as I do not see this as technically possible for all (incl. provided) key types and I think this comment by @romen goes in the same direction:

From that discussion, I will remark that, from a security perspective, it is paramount that, if public components are to be derived from the private ones, they must be generated when they key is first initialized, not on demand when an operation needs them.

ack, marking as inactive, to be closed at the end of 3.4 dev

Tagging @nhorman as to whether it's intentional that this has not been closed? Tagging @t8m as a reference to the discussion around "do keys always (need/have to) contain a public part?"

No, it should be closed, just hadn't gotten to it


Unhide --emit-index-url and --emit-find-links

Summary
I don't know why I hid these in the first place. Maybe I copied these over from the compat.rs version.
Closes https://github.com/astral-sh/uv/issues/1502.

I think the wrong params were changed here. The "extra-index-url" parameter should be shown in the requirements.txt. And maybe the "index-url"?
From what I can gather, this MR changes the visibility for the "emit-index-url". (which can stay hidden I think)


Mutation of State

Various operations within the app mutate state, creating unexpected behavior and usually are the source of various hard-to-diagnose bugs.
This has affected the implementation of SSO in relation to adding and removing cards. This issue includes both the fixes made for SSO as well as general fixes made to remove mutation of state from the app in general.
redux-immutable-state-invariant has been installed to help track down any actions and components that mutate state.

8daca0a fixes all mutations of state as well as various bugs that would throw errors throughout the app.

Verified in v6.0-rc, closing.


Even more controversial: Allow creation of a DbCommand from an EF IQueryable

Provides access to all the real parameter values, including facets. Should be executable.
However, pretty sure people will think this isn't a good idea...

This would be an alternative to #19334 rather than an addition, right?
I still find this very controversial :) A DbCommand can be seen as a tuple of SQL and parameters, which also happens to be directly executable. I like it. API-wise it's also a bit cleaner than #19334, where the parameters is an "out" parameter.
BTW it's good that this is restricted to relational - we should consider doing this regardless of whether we implement DbCommand or leave just query string.

@roji No, this is independent of #19334 which is not relational-specific (see Cosmos) and doesn't involve handling a disposable object.

Apologies, I meant to write above that I don't find this very controversial, but ended up writing the opposite.

@AndriySvyryd @smitpatel @roji @bricelam @maumar I think we agreed in the design meeting that we were going to to this. Can I get an approval?


change PageableTask and PageableTaskResult interfaces

add caching options and functionality as part of the pageable interfaces

Coverage decreased (-0.07%) to 81.21% when pulling 8f7b4bb9ab28814b389e3f52b8dcd3cb6010043c on m/pageable_stuff into c9bc5190261c203fb8a2641cd7be65e6f08f7fdc on master.


Export performance data as separate fields

According to docs performancedata is exported in the field "check_result.performance_data" as text.
It would be much cooler to have each perfdata in its own field (check_result.perfdata.size.value), possibly with related fields for thresholds, unit, ...
This would basically allow to get rid of graphite, influxdb, .. and just use the icingabeat + elastic + grafana. I'm currently working on a icingaweb2 module for grafana which could display the graphs from a dashboard using this data.

This would basically allow to get rid of graphite, influxdb, .. and just use the icingabeat + elastic + grafana

Completely OT: be careful with your wishes. I'm not sure whether you wouldn't wish to have those "old" tools back after the first few billion datapoints ;-) And believe me, I'm not a big fan of neither Graphite nor Influx. Apart from that, there is nothing wrong with the feature request itself I guess.
Cheers,
Thomas

The problem with performance data is that they are not structured when received from the API. I would need to parse them in icingabeat. I think parsing of perfdata should be done by Icinga and not by a third party tool. So this will not be part of Icingabeat.
However, @dnsmichi is currently reviewing an Icinga 2 feature that can send parsed perfdata to elasticsearch. I don't know if and when this will come out, it's still work in progress.

Details in icinga/icinga#4054


Image doesn't work right in toolbx

Error: invalid entry point PID of container boxkit

I think I need /etc/timezone and /etc/localtime.

podman logs boxkit says:
level=debug msg="Running as real user ID 0"
level=debug msg="Resolved absolute path to the executable as /lib/ld-musl-x86_64.so.1"
level=debug msg="TOOLBOX_PATH is /usr/bin/toolbox"
level=debug msg="Creating /run/.toolboxenv"
level=debug msg="Monitoring host"
level=debug msg="Path /run/host/etc exists"
level=debug msg="Resolved /etc/localtime to /run/host/usr/share/zoneinfo/Europe/London"
level=debug msg="Binding /etc/machine-id to /run/host/etc/machine-id"
mount: /etc/machine-id: mount point does not exist.
       dmesg(1) may have more information after failed mount system call.
Error: failed to bind /etc/machine-id to /run/host/etc/machine-id

This seems to be working now!


Pmyip3/integrating importing pubs

Description
Import publications form google scholar using the actual api instead of the hardcoded publications in json file.
Integrate PR101 and PR103
Type of change

[ ] Bug fix
[X] New feature
[ ] Refactoring
[ ] Documentation

Problem
Currently, we uses hardcoded publications in a json file to pretend it's imported by scholar api. We'll need to use the actual scholar api to import publications.
Solution description
Tests
All unit tests pass? N/A
Builds successfully? Yes
Attach screenshot of the expected result (e.g. UI of the website/ postman api call result/ database changes)
After entering a valid profile link, it should return the following 2 publications (currently hardcoded from backend, due to lack of time before the demo)
Valid link example: https://scholar.google.com/citations?hl=en&user=3tyGlPsAAAAJ

The following error would pop up for invalid link or length of author_id !== 12

The 2 publications will be added to the current publications list if confirming import

Provide steps in detail for reviewers to reproduce the expected result of the code changes.
Relevant document/ link (if any)
https://github.com/Researchify/Researchify/pull/101
https://github.com/Researchify/Researchify/pull/103
Risk
Identity the risk level (low, medium, high) and indicate which component(s) will be affected if bugs exist.
Medium. The import publication feature won;t work if bugs exist

Sorry for not catching these earlier in your PR but a few things:

Published typo
I think we can actually remove 'title:' and 'author:' because they're kind of self explanatory, and I don't like how the second publication is under the checkbox cause the title is too long. Is there a work around to get the part of the title that overflows to go under the checkbox instead of the whole title?

Sorry for not catching these earlier in your PR but a few things:

Published typo
I think we can actually remove 'title:' and 'author:' because they're kind of self explanatory, and I don't like how the second publication is under the checkbox cause the title is too long. Is there a work around to get the part of the title that overflows to go under the checkbox instead of the whole title?

@vgoh1 Fixed issues

Thanks for fixing those - I'll hit approve but just a few more nitpicky things:

Space before the colon in "Year published : 2018" should be removed like "Link:"
And speaking of "Link:", could you make the url a clickable hyperlink?
I think we can probably differentiate between the field and the value, that is "Year published" can be underlined so that it's not the same font style as the year - but this can happen as a future improvement, I'll put it in the improvements ticket on Trello
And lastly, static analyzer says there's some unused imports - please get rid of those.
Feel free to merge after you've dealt with the issues above. Thanks!


Add Dockerfile

Hi,
It would be really helpful if a Dockerfile was available.
Please consider.
Thanks.

Thanks for suggestion.
I will consider add a Dockerfile. But it may take some time to test.

We have added the Dockerfile. We will close this issue first, reopen it for any other questions.


add playJava to SwaggerPlugin

I want to create a pull request to submit the following changes
add playJava to SwaggerPlugin
use the parameter to switch how to generate the definition properties
true: use jackson introspect
false: use default
upgrade snakeyaml to 1.2.4 and add typed parameter to load method
add mapper to java.time.*
remove the play java request from generated parameters

@kailuowang please let me know when do you think this can be released

0.8.0-PLAY2.7 is released. Thanks very much for you contribution!


Case sensetive captcha not working.

Stable working api does not have parameters for case-sensetive captcha.

@manoj19 hi, 2captcha-javascript  has a regsense parameter for the imageCaptcha method:

@manoj19 Could you describe your problem in more detail ?
If despite sending the regsense parameter, you get incorrect answers, then you need to send a reportbad for incorrectly recognized captcha.


Fix typo in About page

Context for documentation change
The first sentence of the about page says "This is example project of the game Quarto, built using the Elm programming language." Missing the word 'an' between 'is' and 'example'
Proposed solution

Go to the view function in About.elm
Fix typo

See here in the read me for how to run and install the application.
See here in contributing for the basics on forking and cloning the repository.

@LeoUCon refactoring this one to need a little code, unfortunately


Dialog doesn't close when pressing escape

Problem description
Pressing escape should close dialogs. Instead nothing happens.
Note that just calling onRequestClose is not the right thing here, since you don't always want clicking outside the dialog to close it, but you do want escape. So you'd need another argument to onRequestClose to tell you if it was being closed because of escape.
Steps to reproduce
Try any dialog in the docs site.
Versions

Material-UI: all.
React:  all.
Browser: Chrome.

Works for me, in chrome, on the docs site.  Please note that not all dialogs are the same, some do not respond to the esc key.

Can't you use the event to know the nature of the interaction that triggers a close request?

since you don't always want clicking outside the dialog to close it, but you do want escape.

@esprehn I confirm, you can use the event type: https://developer.mozilla.org/en-US/docs/Web/API/Event/type.

onRequestClose takes a boolean, not an event, how do I do that?

As far as I know, it takes an event on the v1-beta branch. Can't tell for the master branch.

The Dialog component will not close on ESC key if you don't supply the onClose prop.
Hope it helps anyone.


simd_div and simd_rem don't check for overflow cases

Both simd_div and simd_rem are missing an overflow check that is done for the regular division operators (i.e., / and %). Consider this example:
#![feature(repr_simd, platform_intrinsics)]

#[repr(simd)]
#[allow(non_camel_case_types)]
#[derive(Clone, Copy, PartialEq, Eq)]
pub struct i32x2(i32, i32);

extern "platform-intrinsic" {
    fn simd_div<T>(x: T, y: T) -> T;
    fn simd_rem<T>(x: T, y: T) -> T;
}

#[kani::proof]
fn test_normal() {
    let val_1: i32 = kani::any();
    let val_2: i32 = kani::any();
    kani::assume(val_1 == i32::MIN);
    kani::assume(val_2 == -1);
    let result: i32 = val_1 / val_2;
}

#[kani::proof]
fn test_simd() {
    let val_1 = kani::any();
    kani::assume(val_1 == i32::MIN);
    let values_1 = i32x2(val_1, val_1);
    let val_2 = kani::any();
    kani::assume(val_2 == -1);
    let values_2 = i32x2(val_2, val_2);
    let result = unsafe { simd_div(values_1, values_2) };
}

This is verification output for test_normal:
RESULTS:
Check 1: test_normal.assertion.1
         - Status: SUCCESS
         - Description: "attempt to divide by zero"
         - Location: tests/kani/Intrinsics/SIMD/Operators/div_rem.rs:19:23 in function test_normal

Check 2: test_normal.assertion.2
         - Status: FAILURE
         - Description: "attempt to divide with overflow"
         - Location: tests/kani/Intrinsics/SIMD/Operators/div_rem.rs:19:23 in function test_normal

Check 3: test_normal.division-by-zero.1
         - Status: SUCCESS
         - Description: "division by zero"
         - Location: tests/kani/Intrinsics/SIMD/Operators/div_rem.rs:19:23 in function test_normal

This is the verification output for test_simd:
Check 1: division-by-zero.1
         - Status: SUCCESS
         - Description: "division by zero"

Check 2: division-by-zero.2
         - Status: SUCCESS
         - Description: "division by zero"

There are several concerns here:

The overflow check is missing when using the vector operator.
The "attempt to divide by zero" check is missing when using the vector operator.

Note that Kani tweaks the output a little bit in this example. In particular, for properties with class division-by-zero it omits the variables, the original outputs are:
Check 3: test_normal.division-by-zero.1
         - Status: SUCCESS
         - Description: "division by zero in var_10 / var_11"
         - Location: tests/kani/Intrinsics/SIMD/Operators/div_rem.rs:19:23 in function test_normal

Check 1: division-by-zero.1
         - Status: SUCCESS
         - Description: "division by zero in var_16[0] / var_17[0]"

Check 2: division-by-zero.2
         - Status: SUCCESS
         - Description: "division by zero in var_16[1] / var_17[1]"

In https://github.com/diffblue/cbmc/issues/7367 I asked the CBMC folks about this missing check, but it turns out these checks are being generated by MIR! I don't think that the "attempt to divide by zero" property is needed here (as it's basically a duplicate of "division by zero"), but it's unclear how to insert the "attempt to divide with overflow" property for SIMD intrinsics.

While fixing this for integers, and thanks to @celinval's review, I've realized that CBMC does checks for overflow/NaN/division by zero on floating point division but apparently not for modulo. This seems to be corroborated by the CBMC manual on page 41 here. So for example:
#![feature(repr_simd, platform_intrinsics)]

#[repr(simd)]
#[allow(non_camel_case_types)]
#[derive(Clone, Copy, PartialEq)]
pub struct f32x2(f32, f32);

extern "platform-intrinsic" {
    fn simd_div<T>(x: T, y: T) -> T;
    fn simd_rem<T>(x: T, y: T) -> T;
}

#[kani::proof]
fn test_simd_div() {
    let dividend: f32 = kani::any::<i16>().into();
    let dividends = f32x2(dividend, dividend);
    let divisor: f32 = kani::any::<i16>().into();
    kani::assume(divisor > 0.0 && divisor < 5.0);
    let divisors = f32x2(divisor, divisor);
    let _simd_result = unsafe { simd_div(dividends, divisors) };
}

#[kani::proof]
fn test_simd_rem() {
    let dividend: f32 = kani::any::<i16>().into();
    let dividends = f32x2(dividend, dividend);
    let divisor: f32 = kani::any::<i16>().into();
    kani::assume(divisor > 0.0 && divisor < 5.0);
    let divisors = f32x2(divisor, divisor);
    let _simd_result = unsafe { simd_rem(dividends, divisors) };
}

The verification for test_simd_div gives, in part:
Check 1: division-by-zero.1
         - Status: SUCCESS
         - Description: "division by zero"

Check 2: NaN.1
         - Status: SUCCESS
         - Description: "NaN on division"

Check 3: overflow.1
         - Status: SUCCESS
         - Description: "arithmetic overflow on floating-point division"

[...]

However, test_simd_rem gives only:
RESULTS:
Check 1: division-by-zero.1
         - Status: SUCCESS
         - Description: "division by zero"

[...]

I was able to fix the original issue and implement an integer overflow check, however it looks like I'll have to implement floating point overflow/NaN checks specifically for simd_rem. Definitely going to have to do some reading on this one...

Upon further reflection/reading, I think simd_rem really doesn't overflow since the magnitude of its result should be less than the divisor. I don't think it needs a separate NaN check either since I think it can only produce NaN if the divisor is 0 which CBMC is already checking.


Is offset incorrect?

Hello, after the game is updated, I updated the offset in your project, but I reported an error during the compilation, I hope you can fix it, thank you very much!
Here are the error codes：
error[E0425]: cannot find value in module
--> src/dma/context/mod.rs:21:115
|
21 | ...fsets::engine2_dll::dwBuildNumber)?;
| ^^^^^^^^^^^^^ not found in dwBuildNumbercs2dumper::offsets::engine2_dllcs2dumper::offsets::engine2_dll
error[E0425]: cannot find value in module
--> src/dma/context/mod.rs:107:77
|
107 | batcher.read_into(pawn + cs2dumper::client::C_CSPlayerPawnBase::m_bIsScoped, &mut is_scoped);
| ^^^^^^^^^^^ not found in
|
help: consider importing this constant
|
1 + use crate::dma::cs2dumper::client::C_CSPlayerPawn::m_bIsScoped;
|
help: if you import , refer to it directly
|
107 - batcher.read_into(pawn + cs2dumper::client::C_CSPlayerPawnBase::m_bIsScoped, &mut is_scoped);
107 + batcher.read_into(pawn + m_bIsScoped, &mut is_scoped);
|m_bIsScopedcs2dumper::client::C_CSPlayerPawnBasecs2dumper::client::C_CSPlayerPawnBasem_bIsScoped
warning: unused import:
--> src/dma/context/mod.rs:2:5
|
2 | use crate::dma::cs2dumper::client::C_CSPlayerPawn::m_bIsScoped;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: on by defaultcrate::dma::cs2dumper::client::C_CSPlayerPawn::m_bIsScoped#[warn(unused_imports)]
For more information about this error, try .
warning: (bin "radarflow") generated 1 warning
error: could not compile (bin "radarflow") due to 2 previous errors; 1 warning emittedrustc --explain E0425radarflowradarflow

That's not my project... Open an issue on that repo instead.

I used the offset you just updated, but when I compiled it, it prompted an offset error? Isn't it a problem with your deviation?


Fix caching issue

The cache-keys for fragments rendered in the Specific Service and
Specific Council pages we incorrectly missing an identifier. This meant
that some services were occassionally appearing for unexpected councils.

:+1:


Added new icon

Added the new icon  on public/favicon and 3 PNGs with the sizes requested and an SVG file for future necessities on src/plugin/user_interface/assets.

Awesome, this is great! Thank you!


Added PayPal Payer Id

While creating Paypal Nonce, Currently there is no way we can get PayPal Payer Id. I have tried to add that in the PaymentMethodResponse.

Thank you!


BDD

I have to use BDD instead of TDD. It will be easier to reuse testing code, and the tests will be much cleaner. In an out to in development like this TDD is not so good.

I am currently working on supporting cucumber https://github.com/inf3rno/javascript-project-template/issues/9
After that I'll migrate to the new project template.


Avoid mulu in std.container.array.Array!T when T.sizeof == 1

LDC 1.15 and GDC with optimizations enabled recognize that mulu with a second argument of 1 will never overflow and elide unnecessary operations but DMD and LDC 1.14 do not.

However, @WalterBright, would it be possible to detect and optimize mulu in cgelem ?

Actually wait. Wouldn't it be possible to do the bypass in the backend ?


Banner not showing

It's not an issue as much as a question... What should I look for when I select a picture for a banner? Is there a guide?
Here is my context... I added many roms to my Steam buddy and all the banners, except one, are showing... I tried selecting different picture arts of different types (png, jpeg), changed the resolution to the same as other banners that works, tried redownloading them, delected the entry and created it anew, after a reboot with a new picture... Nothing works. There is just one banner in the 30+ roms that stubbornly refuses to show. So weird... Why?
Keep doing your awesome work on this GamerOS project. Imo, it's what SteamOS should have been.
#Thumbsup

Any png or jpeg should work.
Very strange. I would try re-uploading the image or try deleting the
shortcut and re-creating it.
The upcoming release will have improved file uploading and SteamGridDB
integration.
Hopefully, that will help if you still can't get it to work.
On Fri, 27 Mar 2020 at 09:45, Mohandevir<EMAIL_ADDRESS>wrote:

It's not an issue as much as question... What should I look for when I
select a picture for a banner? Is there a guide?
Here is my context... I added many roms to my Steam buddy and all the
banners, except one, are showing... I tried selecting different picture
arts of different types (png, jpeg), changed the resolution to the same as
other banners that works, tried redownloading them, delected the entry and
created it anew, after a reboot with a new picture... Nothing works. There
is just one banner in the 30+ roms that stubbornly refuses to show. So
weird... Why?
Keep doing your awesome work on this GamerOS project. Imo, it's what
SteamOS should have been.
#Thumbsup
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gamer-os/steam-buddy/issues/56, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIWMWBFBTLBPKJRQQJ7YXDRJSUV3ANCNFSM4LVAPIUA
.

Already tried both solutions, a couple of times, but it's not a big problem. It's just one rom (and always the same) that's causing the issue. Just wanted to know if I missed something. I will try again with the next GamerOS update.
Thanks for the quick answer.

No matter what image you upload for that ROM?
If so, maybe it is the name. Is there anything special about the name of
the ROM?
Try using a different name?
On Fri, 27 Mar 2020 at 10:29, Mohandevir<EMAIL_ADDRESS>wrote:

Already tried both solutions, a couple of times, but it's not a big
problem. It's just one rom (and always the same) that's causing the issue.
Just wanted to know if I missed something. I will try again with the next
GamerOS update.
Thanks for the quick answer.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gamer-os/steam-buddy/issues/56#issuecomment-605031491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIWMWEVC2DRWPAUM33DIDTRJSZ6FANCNFSM4LVAPIUA
.

Nothing special... Tried renaming them (rom & banner). It doesn't work either. Oh well...

Is there a way to do a manual cleanup of the Steam Buddy folders (terminal)? Just curious to see if an error/corruption could have occured in the GamingOS rom's folder...

Everything is under ~/.local/share/steam-buddy.
Another possibility is something is going wrong when copying the file to
Steam's directory.
The Steam images are stored under
~/.local/share/Steam/userdata/<steam-user-id>/config/grid.
Taking a peek at those locations might help.
You could also try running steam-shortcuts manually. Maybe there is an
error message.
Best to run it while Steam is not running, so, first run systemctl stop lightdm to stop the Steam session.
You can run systemctl start lightdm to bring the Steam session back up
again.
On Fri, 27 Mar 2020 at 10:56, Mohandevir<EMAIL_ADDRESS>wrote:

Is there a way to do a manual cleanup of the Steam Buddy folders
(terminal)? Just curious to see if an error/corruption could have occured
in the GamingOS rom's folder...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gamer-os/steam-buddy/issues/56#issuecomment-605045513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIWMWAB63LFSYJ4DUDGCB3RJS5C7ANCNFSM4LVAPIUA
.

I'll have a look later. Will keep you posted.

I now believe this may be a duplicate of #57
I have fixed that issue in steam buddy 0.4.3
Please update and try again.

Did you ever try using a different name for the ROM when you create the shortcut entry in Steam Buddy?

Nope... And I just added the console's name at the end of the shortcut name and it and it solved the issue.
I knew I was missing something! ;)
Thanks for your help.


Null safety support

Hi @hadukin,
Can you update this package version to support null safety?

Nice


[BugFix] Fix const expression with in subquery bug

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

[FE PR Coverage check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
1
1
100.00%


ci: Add a PR comment w/ the published alpha versions

This is a little heavy-handed, I couldn't really find something that did what I wanted but I didn't have time to write something. Might come back and write a small open-source tool to handle this commenting stuff.
In the meantime this works :)

💌Published Alpha Packages:@codecademy/gamut-icons@2.1.5@codecademy/gamut-styles@2.2.11@codecademy/gamut-templates@2.2.30<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-icons@2.1.5@codecademy/gamut-styles@2.2.11@codecademy/gamut-templates@2.2.30@codecademy/gamut@2.4.6


Customize the left and right buttons

Allow adding icon and text together for left and right buttons in the NavigatorIOS

Warnings

:warning:

:clipboard: Test Plan - This PR appears to be missing a Test Plan.

:warning:

:clipboard: Release Notes - This PR appears to be missing Release Notes.

  Generated by :no_entry_sign: dangerJS

NavigatorIOS is deprecated and will be removed in a future release. We’d recommend moving to a better supported navigation system for React Native. Check out the navigation page of the docs for more info.


ERA-912 revert version to 19 and exit on error in release script

Important: kill publishing CI job immediately after merge, because 19 is already published.

I don't understand this PR. What is the issue we try to solve with this one?

I don't understand this PR. What is the issue we try to solve with this one?

Full story is here: https://digitalasset.atlassian.net/browse/ERA-912.
The issue is already solved, it's just a tidy up in version number and for the script.


Publish the .xpi file

Please publish the .xpi file to the releases page.
Like FoxyProxy: https://github.com/foxyproxy/firefox-extension

Thanks for your release.
https://github.com/Webb-L/ProxyExtensionFirefox/releases/tag/v1.0.9
I close this issue.


Sdk minor changes

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update

Checklist

[x] My pull request is atomic and focuses on a single change.
[x] I have read the contributing guide and my code conforms to the guidelines.
[x] I have documented my changes clearly and comprehensively.
[x] I have added the required tests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.10 out of 11 committers have signed the CLA.:white_check_mark: Fluder-Paradyne:white_check_mark: rounak610:white_check_mark: jedan2506:white_check_mark: Tarraann:white_check_mark: CaptainLevi0007:white_check_mark: sayan1101:white_check_mark: namansleeps:white_check_mark: TransformerOptimus:white_check_mark: Arkajit-Datta:white_check_mark: luciferlinx101:x: Jagtar SagguJagtar Saggu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[sdl] Only blit rectangles to windows that they intersect

This pull request modifies the sdl_draw_to_window_rect to skip attempting to blit rects which do not intersect the window the function is currently operating on. This prevents SdlWindow#blit from returning false and short-circuiting the drawing loop. In a single-window session, it's reasonable to assume that something is wrong if any of the rectangles being blitted do not interesect the window, but in a multimon session each rectangle will only be applicable for one window. Because the primary window is always handled first, all rectangles which intersect a different window will fail to be blitted to the primary one and immediately short-circuit the draw loop.
This PR doesn't modify the analogous functions for smart-sizing, because currently smart-sizing appears to be completely broken on SDL with multimon enabled.

on second thought, might be simplest to ignore these in SdlWindow::blit

@caseif thank you for bringing this to my attention.
I´ve created #9962 to ignore SdlWindow::blit that does not intersect instead though, as we don´t necessarily know the updates intersect with the surface (even in single window mode, once we add resizeability without resolution changes)

Thanks for taking care of this. This was my initial thought but I was a bit nervous about potentially obscuring an error condition, but if that's not an issue then I agree it's a much nicer solution. :)


PhpdocSeparationFixer - fix regression with lack of next line

added utest without fix that crashes on CI: https://travis-ci.org/github/FriendsOfPHP/PHP-CS-Fixer/jobs/673531958

Desc should have included "Closes https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4869.".

sorry, didn't saw that PR.
damn, that means you spot the problem month ago but didn't go the path to fix it?

I sent a PR which fixed the bug, but I wasn't sure of the exact case that reproduced it.

I only had a non-isolated example, which was no good to use.


Puzzle CRUD: Unordered Puzzle

Loom video: https://www.loom.com/share/24b293a808b14530bc1d981298d05a21

@amoliksingh - Small issue when I go from higher image count to lower image count.
Steps to reproduce:

select 3 images for unordered puzzle
upload 3 images
go down to 2 images for unordered puzzle
go back to 3 (or 4/5) images
the third one will show that a file is uploaded (but not show the preview)

See image below:

What I assume is happening is that the image won't actually show up on the user side, but the file names array isn't getting cleared properly on # of image change.

@amoliksingh - Small issue when I go from higher image count to lower image count.
Steps to reproduce:

select 3 images for unordered puzzle
upload 3 images
go down to 2 images for unordered puzzle
go back to 3 (or 4/5) images
the third one will show that a file is uploaded (but not show the preview)

See image below:

Expected behaviour:
When changing to 2 images, 3rd image should be completely wiped from memory. So if I were to save at 2, that image is gone and won't show up. If I change back to 3, 4, or 5 that image won't show up anywhere.
What I assume is happening is that the image won't actually show up on the user side, but the file names array isn't getting cleared properly on # of image change.

Images are getting cleared when going from 3 --> 2 --> 3+, there was a small bug affecting the uploaded state variable, should be fixed now


docs: Update \operatorname in supported_table.md 0.12.0

Codecov Report

Merging #2571 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2571   +/-   ##
=======================================
  Coverage   93.83%   93.83%
=======================================
  Files          84       84
  Lines        6148     6148
  Branches     1262     1262
=======================================
  Hits         5769     5769
  Misses        348      348
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b81e7d...a97de26. Read the comment docs.

@ylemkimon Any idea why adding test screenshots label isn't getting the screenshotter to run here? It worked fine in #2570...
(It would also be great to not have to run screenshots when it's just documentation changes, like we do for other tests...)

Any idea why … ?

I created this PR differently than usual. I edited the file online, using the GitHub web editor. That may have something to do with it?

The issue seems to be due to https://www.githubstatus.com/incidents/28js6274ybpb.


Polygon disappears even though lineWidthMinPixels is > 0

Actual Result
Polygon disappears when zooming out
Expected Result
Polygon's stroke lines maintain at least lineWidthMinPixels pixels width
Reproduce Steps

Use GeoJsonLayer.
Set lineWidthMinPixels to 2
Load a polygon into it
Zoom way out

Code Example
Reproduces with the following polygon GeoJsonLayer:
https://gist.github.com/supersonicclay/e61000878939f04c79474bdfdc1a8515
Paste this into https://deck.gl/json:
https://gist.github.com/supersonicclay/e61000878939f04c79474bdfdc1a8515#file-deck-gl_repro-json
To Do List

[ ] Add label and assign to milestone
[ ] Coding
[ ] Test

when the whole polygon size is less than the size of lineWidthMinPixels, don't need respect the min pixel size here, otherwise we need fake data.

could be related to #2384

You can reproduce it pretty easily by rendering the united states - both east and west coast disappear past a certain zoom level. Attached GIF is from 6.3.0.

@tgorkin Thanks! Will test it out.


Automatic Update to Component Status When Issue is Set to Fixed

Can we have a feature so that when an incident is set to Fixed that the component status is automatically set to Operational.

You can change the component status through the dashboard whilst you're adding a new "incident".

I know, I'm talking about when I'm editing an incident to show it is fixed. For example:

Ah I see, you're using Cachet differently to how it's intended (which goes back to #715 - I can't wait to redo everything!).

@jbrooksuk I can't wait for you to as well. Please hurry!


Added more translateable stuff and missing objective reported by Deerlord

Thanks to @Deerlord0 for reporting missing objective description.

As mentioned in ReactiveDrop/reactivedrop_public_src#180, the worldspawn properties should be erased, not translated. I could go either way on translating the example map's boss bar.

i just reverted my changes for worldspawn


MonthYear Picker

🚀 Feature Proposal
Please make the Datepicker support a month/year selection.
Motivation
I have a requirement that I need to select the month&year without the date and it seems like the current Datepicker does not support this or at least I can't find it.
Example
<Datepicker mode="month" />
<Datepicker mode="year" />

My team would also find this useful.

+1

+1, at the moment were hacking this, using placeholder to show the selected month name and rendering a TouchableOpacity in the renderMonth prop to be able to close the calender on press and return the value

<Datepicker startView={CalendarViewModes.MONTH} /> seems to do what you are requesting

@tinvujasinovic Your approach actually works. did you able to customize the Year selection dropdown?


Wowhead tooltips should use the player's selected level

We generate these tooltips through ActionID but right now we're also defaulting to lvl 60 tooltips. This can create confusion for users as sometimes these tooltips are wildly wrong. We should investigate what is needed to be able to provide the player's level instead.

https://www.wowhead.com/tooltips - official examples by wowhead on how to use their tooltips
Adding more stuff that is related to this task.
We can also properly show the Buff description for auras instead of the spell description


Split packageName and dtoPackage by dot

Thank you!

Could you please release a new version with this fix?

Yep, one minute please

@cponomaryov Released to both maven central and bintray, thank you for your patience

@blast-hardcheese I can't see the release in maven central: https://search.maven.org/search?q=a:guardrail-maven-plugin_2.12

@cponomaryov This was my mistake, I forgot to close and release the repository in Sonatype. I've done it now, it should sync shortly. The released version is <IP_ADDRESS>.

@blast-hardcheese thanks!


Nx 17+ terminates tasks with  ELIFECYCLE  Command failed with exit code 128.

CTRL+C any Nx running task since upgrading to Nx 17 and I'm seeing this error in the console:
 ELIFECYCLE  Command failed with exit code 128.

It also happens in Nx 18.
So I think they've refactored how tasks & processes are managed, and somehow exiting the task runner more aggressively.
This appears to be affecting the Firebase serve executor, since it no longer gets the SIGINT and just bails out, which means the Firebase emulator no longer gets opportunity to shutdown.
Anyone else seeing this?

This was happening in Node 18, and I tried updating to Node 20 based on a random comment elsewhere, but no difference (yet).
I'm short on ideas for how to fix this, because we have to invoke the custom serve executor from nx task runner, even when spinning up our own process in there, it gets killed without firebase CLI command getting the SIGINT it needs to shutdown the emulator cleanly.
Ideas are very welcome, since it's not great for workflow atm.


Fix CI setup

The requirement for lcobucci/jwt means that there is no way to install dependencies on PHP 7.2 or 7.4, making PHP 7.4 the de-facto requirement.

@steverhoades it looks like the ocular.phar executable of Scrutinizer is broken on PHP 8. Is this upload of code coverage still needed or could it be dropped ?

7.4 as the minimum supported version makes sense at this point. I don't think code coverage is still needed, it can be dropped. Thank you for the contributions!

@steverhoades this is now ready.
I would also suggest dropping Scrutinizer entirely from this repo: code coverage is not uploaded anymore (which requires disabling it on their side so that they don't wait for it, blocking concurrent runs) and their static analysis is a lot less powerful than phpstan.


make Date the default type to use for moments in time

and ban any juggling with the seconds/nanos objects

I'll have a look tonight, but note #309 (though maybe that's not relevant here)

Instead of Date we could also use the ISO date string. We could even use the seconds/nanos object supplied by the backend, but I do not find it very readable and it does not work well with the libraries we use.


Can we use pr-agent with custom llm provider?

Is this feature available yet?

yes
https://pr-agent-docs.codium.ai/usage-guide/additional_configurations/#changing-a-model

In addition, in the near future, PR-Agent Pro would also offer seamless support of claude3 along with GPT-4

I have llama2 running in my local, and I have made the necessary adjustments in .secrets.toml, configuration.toml and __init__.py, as specified here:
[__init__.py]
MAX_TOKENS={
    "ollama/llama2": 4096,
    ...,
}

[config] # in configuration.toml
model = "ollama/llama2"
model_turbo = "ollama/llama2"

[ollama] # in .secrets.toml
api_base = "http://localhost:11434/"

And this is the output I keep getting:
2024-04-17 16:11:29.179 | ERROR    | pr_agent.algo.utils:load_yaml:437 - Failed to parse AI prediction: mapping values are not allowed here
  in "<unicode string>", line 8, column 180:
     ... on in your `.pr_agent.toml` file:
                                         ^
2024-04-17 16:11:29.181 | INFO     | pr_agent.algo.utils:try_fix_yaml:459 - Failed to parse AI prediction after adding |-

2024-04-17 16:11:29.241 | INFO     | pr_agent.algo.utils:try_fix_yaml:488 - Successfully parsed AI prediction after removing 57 lines
2024-04-17 16:11:29.242 | ERROR    | pr_agent.tools.pr_reviewer:run:150 - Failed to review PR: 'str' object has no attribute 'get'

as the error message says, remove the '...'

Thank you for your feedback. I did not have ... in __init__.py Attached are a few screenshots of the setup:

Run again this morning:

I agree, llama2 is weak, and I was wondering if I can use a custom llm provider, and use their API KEY token, instead of OpenAI.

pr-agent-docs.codium.ai/usage-guide/additional_configurations/#changing-a-model

closing this issues, as it was discussed and solve in the Discord channel

@mrT23 can you share the link to the discord channel?

@ElonaZharri @mrT23 any suggestions for the error above?. Am also facing the same error with ollama/llama3.2 .

llama3.2 is too weak to run properly code tasks, and returns an output that does not obey the prompt, so it cannot be parsed.
use better models

llama3.2 is too weak to run properly code tasks, and returns an output that does not obey the prompt, so it cannot be parsed.
use better models

Got it, thanks. Any suggestions with local llms that might support this usecase ?


Dioxus android bootstraping error

Problem
When setting up a new mobile (android) project on Linux, the build.gradle.kts seems to have "buildTypes -> getByName -> packaging mangled. All entries appear on the same line which causes gradle to not be able to build.
Steps To Reproduce
Steps to reproduce the behavior:

follow setup as the docs shows
create fresh project with newest tauri-mobile
select wry
cargo add dioxus
cargo add dioxus-desktop --no-default-features --features tokio_runtime
Modify src/lib.rs file to include source code shown in docs. (and use dioxus_desktop::Cofig)
replace main function with aformentioned
add the app function
cargo android open
start emulator
cargo android run

source code for refference
use anyhow::Result;
use dioxus::prelude::*;
use dioxus_desktop::Config;
#[cfg(target_os = "android")]
use wry::android_binding;
use wry::{
    application::{
        event::{Event, StartCause, WindowEvent},
        event_loop::{ControlFlow, EventLoop, EventLoopWindowTarget},
        window::WindowBuilder,
    },
    http::Response,
    webview::{WebView, WebViewBuilder},
};

#[cfg(target_os = "android")]
fn init_logging() {
    android_logger::init_once(
        android_logger::Config::default()
            .with_min_level(log::Level::Trace)
            .with_tag("testmobile"),
    );
}

#[cfg(not(target_os = "android"))]
fn init_logging() {
    env_logger::init();
}

#[cfg(any(target_os = "android", target_os = "ios"))]
fn stop_unwind<F: FnOnce() -> T, T>(f: F) -> T {
    match std::panic::catch_unwind(std::panic::AssertUnwindSafe(f)) {
        Ok(t) => t,
        Err(err) => {
            eprintln!("attempt to unwind out of `rust` with err: {:?}", err);
            std::process::abort()
        }
    }
}

fn app(cx: Scope) -> Element {
    let items = cx.use_hook(|| vec![1, 2, 3]);

    log::debug!("Hello from the app");

    render! {
        div {
            h1 { "Hello, Mobile"}
            div { margin_left: "auto", margin_right: "auto", width: "200px", padding: "10px", border: "1px solid black",
                button {
                    onclick: move|_| {
                        println!("Clicked!");
                        items.push(items.len());
                        cx.needs_update_any(ScopeId(0));
                        println!("Requested update");
                    },
                    "Add item"
                }
                for item in items.iter() {
                    div { "- {item}" }
                }
            }
        }
    }
}

#[cfg(any(target_os = "android", target_os = "ios"))]
fn _start_app() {
    stop_unwind(|| main().unwrap());
}

#[no_mangle]
#[inline(never)]
#[cfg(any(target_os = "android", target_os = "ios"))]
pub extern "C" fn start_app() {
    #[cfg(target_os = "android")]
    android_binding!(com_example, testmobile, _start_app);
    #[cfg(target_os = "ios")]
    _start_app()
}

pub fn main() -> Result<()> {
    init_logging();

    // Right now we're going through dioxus-desktop but we'd like to go through dioxus-mobile
    // That will seed the index.html with some fixes that prevent the page from scrolling/zooming etc
    dioxus_desktop::launch_cfg(
        app,
        // Note that we have to disable the viewport goofiness of the browser.
        // Dioxus_mobile should do this for us
        Config::default().with_custom_index(r#"<!DOCTYPE html>

            <title>Dioxus app</title>
            <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />

       "#.into()),
    );

    Ok(())
}

fn build_webview(event_loop: &EventLoopWindowTarget<()>) -> Result<WebView> {
    let window = WindowBuilder::new()
        .with_title("A fantastic window!")
        .build(&event_loop)?;
    let webview = WebViewBuilder::new(window)?
        .with_url("https://tauri.app")?
        // If you want to use custom protocol, set url like this and add files like index.html to assets directory.
        // .with_url("wry://assets/index.html")?
        .with_devtools(true)
        .with_initialization_script("console.log('hello world from init script');")
        .with_ipc_handler(|_, s| {
            dbg!(s);
        })
        .with_custom_protocol("wry".into(), move |_request| {
            #[cfg(not(target_os = "android"))]
            {
                use std::fs::{canonicalize, read};
                use wry::http::header::CONTENT_TYPE;
                // Remove url scheme
                let path = _request.uri().path();

                #[cfg(not(target_os = "ios"))]
                let content = read(canonicalize(&path[1..])?)?;

                #[cfg(target_os = "ios")]
                let content = {
                    let path = core_foundation::bundle::CFBundle::main_bundle()
                        .resources_path()
                        .unwrap()
                        .join(&path);
                    read(canonicalize(&path)?)?
                };

                // Return asset contents and mime types based on file extentions
                // If you don't want to do this manually, there are some crates for you.
                // Such as `infer` and `mime_guess`.
                let (data, meta) = if path.ends_with(".html") {
                    (content, "text/html")
                } else if path.ends_with(".js") {
                    (content, "text/javascript")
                } else if path.ends_with(".png") {
                    (content, "image/png")
                } else {
                    unimplemented!();
                };

                Ok(Response::builder()
                    .header(CONTENT_TYPE, meta)
                    .body(data.into())?)
            }

            #[cfg(target_os = "android")]
            {
                Ok(Response::builder().body(Vec::new().into())?)
            }
        })
        .build()?;

    Ok(webview)
}

Expected behavior
Demo app opens with a short list with a button to add entries on emulator
Screenshots

Environment:

Dioxus version: 0.4.0
Rust version: rustc 1.74.0-nightly (2f5df8a94 2023-08-31)
OS info: Linux (kernel 6.4)
App platform: mobile

Questionnaire

[x] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[x] I don't have time to fix this right now, but maybe later

I think I had a similar problem. My build.gradle.kts were fine but my .gitignore file was all on one line.

Both of those errors seem more related to cargo mobile than Dioxus' setup. It is OK to have this issue here as well because it is Dioxus docs that led you to those commands, but you might have more luck opening or looking for an issue in the cargo mobile repo.
The first issue seems similar to https://github.com/tauri-apps/cargo-mobile2/issues/210 ?


Stdout not showing in light background terminal.

What happened?
When running devspace, output within "inverted commas" isn't visible.
Not sure but https://github.com/devspace-sh/devspace/blob/main/pkg/devspace/dev/dev.go#L36 explicitly mentioned white color is causing the issue
			ctx.Log().Infof("DevSpace UI available at: %s", ansi.Color("http://"+serv.Server.Addr, "white+b"))
dev:app Selected pod voyager-devspace-test-vc-devspace-657b784b97-sgtjt
dev:app open  Opening 'http://localhost:8089/' as soon as application will be started
dev:app ports Port forwarding started on: 3000 -> 3000, 9229 -> 9229
dev:app sync  Sync started on: ./server/dist <-> /home/ubuntu/deployment/voyager/dist
dev:app sync  Waiting for initial sync to complete
dev:app sync  Initial sync completed
dev:app ssh   Port forwarding started on: 10548 -> 8022
dev:app ssh   Use 'ssh app.devspace.devspace' to connect via SSH

It looks something like this in white background.

Looks completely fine with dark background

What did you expect to happen instead?
Wanted stdout to be visible.
How can we reproduce the bug? (as minimally and precisely as possible)
run commands in light background terminal

Sorry, but I don't think this solves the problem, because sometimes this tool is used internally by another script.  I've also seen that the code supports the NO_COLOR env variable, but instead of using a specific colour or cleaning, wouldn't it be better to just make text bold when you want to highlight something? You project is used by many people, and I think everyone would appropriate some accessibility.
Thank you for supporting this project


chore(ci): don't verify manifests for prerelease

What this PR does / why we need it:
When running a prerelease we don't want to have manifests bumped so the check is not needed.
Sample run that failed due to that: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/3837516608/jobs/6532907634

Which issue this PR fixes:
Part of https://github.com/Kong/team-k8s/issues/267.

Maybe we add a comment there so that people don't expect the bump to happen? What's the outcome of producing a prerelease? Will it produce the manifests with previous non-prerelease version?

Maybe we add a comment there so that people don't expect the bump to happen? What's the outcome of producing a prerelease? Will it produce the manifests with previous non-prerelease version?

The workflow is not responsible for bumping the manifests on its own, it is a manual step in the release process. The step is only responsible for verifying whether the tag we've got as input to the workflow is consistent with the manifests. Skipping this step for the prerelease workflows IMO makes sense as we want to keep manifests on main to point to the latest released version.
Added a comment for that: 4ab59b6

IMO makes sense as we want to keep manifests on main to point to the latest "stable" released version.

I'm not sure if we should make an exception here 🤔 main is what it is. There's no guarantees about what's in it.

Can we agree for now that only not pre-released tags will be used in the manifests?

You mean the release tags 😅? I mean sure, we can do that but in that case it should be obvious for all release process participants so that there are no surprises.
I'm specifically raising this point because to me rc, alpha, beta etc tags are just that: pre-release tags. They should not get any special treatment in my view unless explicitly agreed upon.

You mean the release tags 😅? I mean sure, we can do that but in that case it should be obvious for all release process participants so that there are no surprises.

Yup, I agree it should be obvious. I will hold on with the changes - we had a discussion with @mflendrich in which the conclusion was that we should approach the release process from a different angle, making it effectively to be run every night and only "promoted" once we decide it's time to cut a release. I'm trying to prepare something using reusable workflows so that we could use a single workflow for running nightly jobs and reusing that in a release workflow.


Video size in full_formats array

In the retrieved video info, each element of adaptive_formats has a clen field that indicates the video size, but such field is not present in full_formats array elements. How can I get the video size for a full before downloading it?
Thanks.

No file size is sent in the video info from Youtube for full formats. You should send a HEAD request to their url and get their size


Performance tunning

Describe the bug
Currently I am doing gateway performance test.
I have 1000 routes in my gateway application, routes like below:
spring.cloud.gateway.routes[0].id = cec64e03-fc5d-2222-a51c-000001
spring.cloud.gateway.routes[0].uri = lb://DEMO-Y-HELLO-SERVICE001
spring.cloud.gateway.routes[0].predicates[0] = Path=/664ceb75-80eb/api/84f2-287ceaa1db0a/lisuent/**
spring.cloud.gateway.routes[0].filters[0] = StripPrefix=1
spring.cloud.gateway.routes[0].order = 0
spring.cloud.gateway.routes[1].id = cec64e03-fc5d-2222-a51c-000002
spring.cloud.gateway.routes[1].uri = lb://DEMO-Y-HELLO-SERVICE002
spring.cloud.gateway.routes[1].predicates[0] = Path=/3c248795-6211/api/8f51-b277eff9f1ce/lisuent/**
spring.cloud.gateway.routes[1].filters[0] = StripPrefix=1
spring.cloud.gateway.routes[1].order = 1
......
spring.cloud.gateway.routes[999].id = cec64e03-fc5d-2222-a51c-000999
spring.cloud.gateway.routes[999].uri = lb://TARGET-SERVICE
spring.cloud.gateway.routes[999].predicates[0] = Path=/target/**
spring.cloud.gateway.routes[999].filters[0] = StripPrefix=1
spring.cloud.gateway.routes[999].order = 999
I found the performance is different and the gap of response time is large.
e.g.:
(1) my target service route is at the first place(order =0)

(2) my targe service route is at the last route (order =999)

throughput from 1900+ to 470+
So, the route match flow is one by one from 0 to 999 , am I right?
Is there any suggestion to improve the performance when my target service is at last ?

1000routes.txt
this is my route definition, it contains 1000 routes

They are matched in order. We can move the discussion there.
Duplicates #1683


This package fails to load my analyzer (but hfst succeeds)

When I call this:
parser = pyhfst.HfstInputStream("name_of_transducer.hfst").read()
pyhfst throws an error: UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfb in position 1: invalid start byte
The parallel call with hfst works:
parser = hfst.HfstInputStream("name_of_transducer.hfst").read()
I tried opening the transducer as a byte stream and passing that to pyhfst.HfstInputStream(), but that threw an error claiming that bytes, strings or file names were expected, not BufferedReader objects.

Running this on hfst vs hfstol files produces different errors. hfstol throws a list index out of range error as it tries to initialize the transducer alphabet. Is there a pyhfst-internal way to compile transducers that does not produce this error?

Is your transducer weighted or unweighted? We mainly deal with weighted transducers. Can you send us your transducer in optimized lookup format and an example input and expected output?

hfst.zip
It should be weighted. I am pretty sure I put some weights in the source code a while ago. I have included both an hfst file and an hfstol file.
input: mkizin
expected output: mkizin+NI, mkizin+NA

Issue identified and fixed in a425d53 and in pyhfst==1.2.0


Make Mandriva logo appear on Mandrake Linux

https://i.imgur.com/r6cns3q.png
AFAIK the logo hasn't changed since the Mandrake days. So it should be trivial to implement.

How do I add labels?

How do I add labels?

You don't, that's up to project collaborators.

and I don't get how it is unclear that

Neofetch supports almost 150 different operating systems. From Linux to Windows, all the way to more obscure operating systems like Minix, AIX and Haiku. If your favourite operating system is unsupported: Open up an issue and support will be added.

is referring to it not working, and not that it doesn't have a special logo.
(for onlookers, he was talking about this on discord, posting here for a bit of context to their issue)

Well, as I mentioned in the Discord. If I misunderstood the README, close the issue.


Sniff ruuvitag communication

We need to sniff ruuvitag communication with a working unit / framework so we can see the hardware address and data format.

Luckily VMWare can pass myb bt chip trough.
Running
bluetoothctl
scan on
Putting battery in ruuvitag:
[NEW] Device CD:99:36:8E:6E:70 CD-99-36-8E-6E-70

Getting:
[CHG] Device DD:DA:C4:7C:F3:5A ManufacturerData Key: 0x0499
[CHG] Device DD:DA:C4:7C:F3:5A ManufacturerData Value:
05 14 9e 26 10 d1 7f 00 34 00 0c 04 04 7e 76 c7  ...&....4....~v.
e2 85 dd da c4 7c f3 5a                          .....|.Z

They list protocols here:
https://github.com/ruuvi/ruuvi-sensor-protocols/blob/master/broadcast_formats.md

To me looks like 24 bytes of data here.

Protocol depends on production year. I bought my tags on 2020.
My data:
05 14 9e 26 10 d1 7f 00 34 00 0c 04 04 7e 76 c7 e2 85 dd da c4 7c f3 5a = 24 bytes
Looks like "Data Format 5 Protocol Specification (RAWv2)"
https://github.com/ruuvi/ruuvi-sensor-protocols/blob/master/dataformat_05.md
Yes, it is this.


chore: release 2.0.2

:robot: I have created a release *beep* *boop*
2.0.2 (2024-04-24)
Bug Fixes

v2: panic with --add-annotations (b8b9e83)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v2.0.2 :sunflower:


Add header-only INTERFACE library if no source files

@gzagaris does this address #5 for you?

@davidbeckingsale thanks for rapidly addressing this. I am using an older version of BLT and I had to backport your fix to try it out. I wasn't able to get it to work due to the way we were dealing with things like MPI etc. in the old version. For example, once the add_library( foo INTERFACE ) is added we were making calls to target_include_directories() and for an INTERFACE library, we would have to propagate the INTERFACE property to the downstream calls.
Your changes seem reasonable to me. I'll have to hold on a bit to try it out though until we move to a newer version of BLT, which I suspect will happen soon.

using INTERFACE seems like the right way to go assuming we can iron out the kinks. It looks like we need to provide abs paths.

Yup, I just noticed that, I think I can fix it 😄


Build Anax Docker images and upload to Dockerhub

When a PR is created, a GitHub Action runs the e2edev test against the new code. Once this is successful, the code should be merged in and a new GitHub Action should be kicked off that builds Anax and creates the Docker images. These images should be uploaded into Dockerhub.
Output of this Issue should be to create the second GH Action that builds and uploads the docker images. You can use your own fork for development and upload into your own Dockerhub private repo for testing. Once the code is finished and working, it should be changed to use the OpenHorizon org's Dockerhub repo.

Okay, can you assign it to me?

This work has been completed.


500 When Forking

When trying to fork the en-uhg repo as user bellekell I receive a 500 error.  See attached screenshot.

Note this happens on every repo I've tried to fork as this user.  Possibly relevant sanitized log data from the server:
Nov 30 23:45:15 git gogs: [Macaron] 2016-11-30 23:45:15: Completed /js/jquery.are-you-sure.js 404 Not Found in 7.826229ms
Nov 30 23:45:17 git gogs: [Macaron] 2016-11-30 23:45:17: Started POST /repo/fork/5047 for <IP_ADDRESS>
Nov 30 23:45:17 git gogs: 2016/11/30 23:45:17 #033[1;31m[...routers/repo/pull.go:132 ForkPost()] [E] ForkPost: updateUser: e-mail has been used [email: XXXXXXXXXXXX]#033[0m
Nov 30 23:45:17 git gogs: 2016/11/30 23:45:17 #033[1;34m[D] Template: status/500#033[0m
Nov 30 23:45:17 git gogs: [Macaron] 2016-11-30 23:45:17: Completed /repo/fork/5047 500 Internal Server Error in 18.480572ms

Seems like the ForkPost() is trying to update the user's email address?  Is that possible?
See if this can be reproduced on latest code.  If it can, create new issue to fix the problem.  Otherwise, retest on production after #100 .

You can't make a repo as user bellekell because that user and jesse_test both have an email address. This is a known issue that needs to be fixed. tS develoeprs were having problems with this.
If you change the email address for one of those users, it will then work.

Closing this. If we need to fix this, we need to open a new issue.


superset unable to connect postgresql 10.0

Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.20
Expected results
able to connect to pg
Actual results
ERROR: {"error": "Traceback (most recent call last):\n  File "/etc/docker/venv/lib/python2.7/site-packages/superset/views/base.py", line 71, in wraps\n    return f(self, *args, **kwargs)\n  File "/etc/docker/venv/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py", line 52, in wraps\n    return f(self, *args, **kwargs)\n  File "/etc/docker/venv/lib/python2.7/site-packages/superset/views/core.py", line 1698, in testconn\n    'The error message returned was:\n{}').format(e))\n  File "/etc/docker/venv/lib/python2.7/site-packages/sqlalchemy/exc.py", line 58, in unicode\n    return self.str()\n  File "/etc/docker/venv/lib/python2.7/site-packages/sqlalchemy/exc.py", line 319, in str\n    details = [self._message()]\n  File "/etc/docker/venv/lib/python2.7/site-packages/sqlalchemy/exc.py", line 43, in _message\n    return compat.text_type(self.args[0])\nUnicodeDecodeError: 'ascii' codec can't decode byte 0xe8 in position 28: ordinal not in range(128)\n"}
Steps to reproduce

Please reproduce with the latest released version.


Implement expit

Resolves #27  .

Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines, including the relevant style guides.
[x] Read and understand the Code of Conduct.
[x] Read and understood the licensing terms.
[x] Searched for existing issues and pull requests before submitting this pull request.
[x] Filed an issue (or an issue already existed) prior to submitting this pull request.
[x] Rebased onto latest develop.
[x] Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

Implements the expit function.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #27

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Ended up using 1.5 * EPS for the tests as discussed in the gitter chat.

@stdlib-js/reviewers

@MatthewCochrane To run C benchmarks,
$ make benchmark-c BENCHMARKS_FILTER=.*/expit/.*

In order to run these C benchmarks, you do not need to install Boost. You only need Boost to run benchmarks against Boost, which the C benchmarks in this PR does not use.
Note: in order to compile C benchmarks, you will need gcc installed, which, if you are not on Windows, should not be required.
And you are correct. The benchmarks in the other languages are included in order to compare implementations to (1) reference implementations and (2) baseline performance implementations. In this case, including a C benchmark is useful for establishing baseline performance and assessing how much a JavaScript implementation deviates from the baseline.

Ahh great. Good to know, thanks.  Yep, makes sense.

@MatthewCochrane No problem! Taking a final look at the PR now!


Smoke test legacy

Docs Build status updates of commit 28ab50f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

System.ArgumentException: Illegal characters in path.
   at System.Security.Permissions.FileIOPermission.EmulateFileIOPermissionChecks(String fullPath)
   at System.Security.Permissions.FileIOPermission.QuickDemand(FileIOPermissionAccess access, String fullPath, Boolean checkForDuplicates, Boolean needFullPath)
   at Microsoft.DocAsCode.GlobUtility.ExpandFileMapping(String baseDirectory, FileMapping fileMapping)
   at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.ConfigToParameter(BuildJsonConfig config, TemplateManager templateManager, ChangeList changeList, String baseDirectory, String outputDirectory, String templateDir)
   at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument(BuildJsonConfig config, TemplateManager templateManager, String baseDirectory, String outputDirectory, String pluginDirectory, String templateDirectory)
   at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument()

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Proposal: argo cp command to download artifacts

This proposal is for an argo CLI command to download artifacts from a workflow step. Given a workflow result like:
$ argo get artifact-passing-jg2k8 -o wide
Name:             artifact-passing-jg2k8
Namespace:        default
ServiceAccount:   default
Status:           Succeeded
Created:          Thu Jan 18 15:02:42 -0800 (9 hours ago)
Started:          Thu Jan 18 15:02:42 -0800 (9 hours ago)
Finished:         Thu Jan 18 15:03:31 -0800 (9 hours ago)
Duration:         49 seconds

STEP                       PODNAME                            DURATION  ARTIFACTS  MESSAGE
 ✔ artifact-passing-jg2k8
 ├---✔ generate-artifact   artifact-passing-jg2k8-2089725168  25s       hello-art
 └---✔ consume-artifact    artifact-passing-jg2k8-2707584000  23s

One could do something like:
$ argo cp artifact-passing-jg2k8-2089725168:hello-art /tmp/

The workflow YAML already has most of the information required to download the artifact (e.g. bucket name and key) as seen in the node status:
    artifact-passing-jg2k8-2089725168:
      finishedAt: 2018-01-18T23:03:07Z
      id: artifact-passing-jg2k8-2089725168
      name: artifact-passing-jg2k8[0].generate-artifact
      outputs:
        artifacts:
        - name: hello-art
          path: /tmp/hello_world.txt
          s3:
            accessKeySecret:
              key: accesskey
              name: argo-artifacts-minio-user
            bucket: my-bucket
            endpoint: argo-artifacts-minio-svc.default:9000
            insecure: true
            key: artifact-passing-jg2k8/artifact-passing-jg2k8-2089725168/hello-art.tgz
            secretKeySecret:
              key: secretkey
              name: argo-artifacts-minio-user

The issues here are that:

the artifact repository may not directly accessible from the client (e.g. internal minio server)
the secrets may not be accessible

However, we could at least support the use case for GCS and AWS, where the repository will be directly accessible. Regarding bucket secrets, we can either lookup the secrets using the k8s go-client, or rely on the .aws config/credentials in the user's home directory for the download.

Would be possible to do with a proper API server.

You can now curl artifacts.

To get an artifact we need to know

namespace
workflowName for current workflows, UID for archived workflows
nodeID
artifactName
is it an input or output

So you can create an identifier for them:
/{namespace}/{uid|name}/{uid/name}/{nodeID}/{input|outputs}/{artifactName}

So we can create a new endpoint. This is probably not enough for most users:

They want to download all artifacts (probably quite common).
They want to download just artifacts, but don't know the node ID, instead they know the template name.

argo cp outputDir --namepace=... --name=... --nodeId=... --templateName=... --artifactName=... --artifactType=input
argo archive cp outputDir --uid=... --nodeId=... --templateName=... --artifactName=... --artifactType=input

argo artifact search --namespace=... --workflowName=...


Make one comment in the PR and keep updating it

Closes #16
Thanks @glemaitre for the suggestion.

Hello @OrkoHunter! Thanks for submitting the PR.

There are no PEP8 issues in the file pep8speaks/handlers.py !

In the file pep8speaks/helpers.py, following                are the PEP8 issues :

Line 51:9: E123 closing bracket does not match indentation of opening bracket's line
Line 53:8: E221 multiple spaces before operator
Line 463:17: E123 closing bracket does not match indentation of opening bracket's line

Here you go with the gist !

You can ask me to create a PR against this branch with those fixes. Submit a review comment as @pep8speaks pep8ify.

@OrkoHunter

Hello @OrkoHunter! Thanks for updating the PR.

There are no PEP8 issues in the file pep8speaks/handlers.py !

There are no PEP8 issues in the file pep8speaks/helpers.py !


Enable use of rawLua in arrays

Previous version of nix2lua only cared about custom types such as rawLua in attrsets. Thus making someModule.attr = {someVar, someOtherVar} impossible to represent.
This was my solution, if you find it suitable.
P.S. Really promising project.

Hey, can you add this to the test? If i recall correctly we have simple test which compares definition and parsed result

I think I managed to include a crude check for this:
https://github.com/gytis-ivaskevicius/nix2vim/blob/cca7b958cd7e190692929a2bcc5d26a2e890b3d8/checks/default.nix#L30-L41
https://github.com/gytis-ivaskevicius/nix2vim/blob/cca7b958cd7e190692929a2bcc5d26a2e890b3d8/checks/default.nix#L66-L68

Sorry that it took this long to merge this, it looks great. Thanks!!!


Mixup between OCI and Docker layer formats

Since stable version 1.44.0 it seems the manifest is broken...
some clients ignore that fact but buildah breaks with the following error:
error creating build container: error preparing image configuration: error converting image "containers-storage:[overlay@/home/runner/.local/share/containers/storage+/run/user/1001/containers]@1a00a379b1b45b5f5a1d19e230b108ed0cd8c189fc593f5d2a079b9ea9fd6aa9" from "application/vnd.oci.image.manifest.v1+json" to "application/vnd.docker.distribution.manifest.v2+json": Unknown media type during manifest conversion: "application/vnd.docker.image.rootfs.diff.tar.gzip"

after some research it looks like the issue is similar to https://github.com/containers/buildah/issues/3668
i did compare v1.42.0 and v1.44.0 and see the sub manifest media type changed
v1.42.0
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
  "manifests": [
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "size": 756,
      "digest": "sha256:5564844986abed0569fad566752215c8c86cf8d279d05806f521aa4614c04c28",
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    },
...

v1.44.0
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "size": 728,
      "digest": "sha256:63e48fc5eefa389bba9aaf22d31f7b4eabf2975b0cbbd1c32327c2b571a0570a",
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    },
...

maybe that created the issue -> https://github.com/tailscale/mkctr/commit/c4fd5c4936565517a6d12665f051466f0a5a89ef

Hi @zyclonite
This should have been fixed in https://github.com/tailscale/mkctr/pull/14
unstable-v1.57.76 and later tags should have the fix and it will be included in v1.58 when we release that- let us know if it works for you!


Fix reported repo and tool version

Fixed swapped output of repo and tool revision on build errors.
E.g.: here https://github.com/microsoft/vcpkg/issues/21146
CC @autoantwort

Hm, IIUC trouble starts with this line.
fatal: expected flush after ref listing

indicating problems accessing GH.
IMO the tests shouldn't need more than the vcpkg-tool repo (already fetched) and maybe the vcpkg repo. But I noticed another one which should become a separate branch here IMO, https://github.com/vicroms/test-registries/issues/1
CC @vicroms

/azp run

Thanks for fixing the transposition!


[Kleiner Schönheitsfehler]: CWA zeigt zunächst „Unbekanntes Risiko“ um danach „Niedriges Risiko“ anzuzeigen…

{„Android one - Nokia 7.1“, Android 10 mit Sicherheitspatch vom 01.  Am Morgen des 24.06. war im Infobereich des Startscreens ein Virus-Symbol zu sehen und das nachfolgende Öffnen der CWA zeigte „Unbekanntes Risiko“. Nach Schließen und erneutem Öffnen der CWA wechselte die Anzeige wieder auf „Niedriges Risiko“.
Seitdem wird beim Öffnen der CWA regelmäßig für knapp eine Sekunde zunächst „Unbekanntes Risiko“ angezeigt um danach automatisch auf „Niedriges Risiko“ zu wechseln.
Das könnte unbedarfte Nutzer irritieren. Es wäre also wünschenswert gleich das korrekte Risiko (hier: „Niedriges Risiko“) anzuzeigen.
Mit freundlichen Grüßen, Joachim.

[Small blemish]: CWA first shows "Unknown risk" and then shows "Low risk" ...
{"Android one - Nokia 7.1", Android 10 with security patch from May 1st, 2020, CWA 1.0.4}
Hello,
since June 16 runs the CWA and initially only showed "Low Risk". On the morning of June 24th there was a virus symbol in the information area of the start screen and the subsequent opening of the CWA showed "Unknown Risk". After closing and reopening the CWA, the display changed back to "Low Risk".
Since then, when you open the CWA, “Unknown Risk” is displayed regularly for just under a second, after which it automatically switches to “Low Risk”.
This could irritate inexperienced users. It would therefore be desirable to immediately display the correct risk (here: "Low Risk").
Sincerely, Joachim.

Just to clarify, did the virus symbol show up in the Corona-Warn-App or just on your phone's home screen as a push notification?

Das Virus-Symbol wurde auf dem Home-Screen in der Benachrichtigungszeile (oben links) angezeigt.
(Weitere CWA-Infos wurden nach dem Herunterwischen in der üblichen Weise angezeigt.)

The virus symbol was displayed on the home screen in the notification line (top left).
(Additional CWA informations was displayed in the usual way after wiping down.)

Eine, vielleicht wichtige, Besonderheit habe ich vergessen: Mein Smartphone darf nur per WLAN ins Internet.

I forgot one, perhaps important, special feature: my smartphone can only access the Internet via WLAN.

We are currently in process of analyzing how we best show the querying of data. Your status is a result of us still evaluating your risk level and thus it did not update right away after a day. Sometimes this takes a while and thus you see this screen. We will update here once we have the proper solution defined and in a PR

I can confirm, that when starting the app, the initial view says that "Risk Unknown" and after about 1-2 seconds it will change to the actual risk level, which is irritating.
It would be better, if the initial view would display a message like "please wait" until the app knows what to display.

Genau, das wäre eine Idee.

Exactly, that would be an idea.

On the morning of June 24th there was a virus symbol in the information area of the start screen

Did look like the screenshots in #734 ? If so, that part issue is traced separately in #734 and this issue could focus on the other aspect(s):

Since then, when you open the CWA, “Unknown Risk” is displayed regularly for just under a second, after which it automatically switches to “Low Risk”.
This could irritate inexperienced users. It would therefore be desirable to immediately display the correct risk (here: "Low Risk").

Which not only irritating, it can also desensitize as people get used to that behavior.

Hey everyone, sorry for us being silent on this for a while. We are working on a loading indicator that indicates the fetching of data in case we need to fetch additional key packages before showing a risk state on the app startup. This is the first step that (together with optimised background behavior) should solve or at least mitigate most of the issues and display behaviors that are occurring in 1.0.4

Did look like the screenshots in #734 ?

Ich meine mich zu erinnern, dass diese Anzeige bereits „Unbekanntes Risiko“ beinhaltete.
I think I remembered that this screen already included "Unknown Risk".
@jakobmoellersap
Danke für die Info.
Thanks for informaton.

@Jo-Achim does this problem still exist, or has this been solved in the meantime?
Is this issue related to- or superseded by https://github.com/corona-warn-app/cwa-app-android/issues/1081?

Sorry, I've lost sight of the little thing. But I will look into the matter again with the next notification.
Regarding https://github.com/corona-warn-app/cwa-app-android/issues/1081#issuecomment-713344103; see my post today.
(The problem may be related to https://github.com/corona-warn-app/cwa-app-android/issues/998#issuecomment-677286822 !?)

@Jo-Achim

(The problem may be related to #998 (comment) !?)

Good question 🤔. I guess we shouldn't exclude the possibility but tbh I'm not familiar enough with all the factors surrounding this issue to make any confident guess there currently.

@Jo-Achim, is this still an issue? Thanks for feedback.
Best wishes,
DS

Corona-Warn-App Open Source Team

@dsarkar, thank you for your demand.
I guess it's not an issue anymore. At least I didn't notice it anymore.
Best regards.

@Jo-Achim,
Thanks for the feedback. I will forward info to the developers and close this issue. Thanks again for contributing.
Best wishes,
DS

Corona-Warn-App Open Source Team


[W10H02] First Commit

Tests for W10H02

ArtemisTest.java Tests following Artemis Examples
Lib.java Reflections for getting private fields and static penguins.
UnitTest.java Tests not from Artemis using extra special pingus.

If you want to add yourself as a penguin do it in Lib.java

Would suggest to push this as per Dominik’s approval and edit in another PR

@Friendly-Banana review please


board mps3_corstone300_fvp_ns fetching code from external repositories and failing in CI

Describe the bug
New board fetching code from external repositories in violation of zephyr rules and causing build issues in CI:
-- Build files have been written to: /__w/zephyr/zephyr/twister-out/mps3_corstone300_fvp_ns/samples/psa/persistent_key/sample.psa.persistent_key.tfm/tfm/lib/ext/ethos_u_core_driver-subbuild
[1/9] Creating directories for 'ethos_u_core_driver-populate'
[1/9] Performing download step (git clone) for 'ethos_u_core_driver-populate'
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': The requested URL returned error: 503
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': The requested URL returned error: 503
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': The requested URL returned error: 503
-- Had to git clone more than once:
3 times.
CMake Error at ethos_u_core_driver-subbuild/ethos_u_core_driver-populate-prefix/tmp/ethos_u_core_driver-populate-gitclone.cmake:31 (message):
Failed to clone repository:
'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver'
To Reproduce
https://github.com/zephyrproject-rtos/zephyr/actions/runs/11929471451/job/33248728397?pr=79931
Expected behavior
Builds and no dependency on external sources
Impact
Violation of zephyr project rules and CI failures.
Logs and console output
https://github.com/zephyrproject-rtos/zephyr/actions/runs/11929471451/job/33248728397?pr=79931

So, if I understand correctly, this is a violation of the "no fetch during build time" from TF-M: https://github.com/zephyrproject-rtos/trusted-firmware-m/blob/main/lib/ext/ethos_u_core_driver/CMakeLists.txt


DSND-2692: Remove service prefix from LB paths and endpoints

Describe the changes

Remove service prefix from LB paths and endpoints

Related Jira tickets
DSND-2692
Developer check list
General

[ ] Is the PR as small as it can be?
[ ] Has the Jira ticket been updated with any relevant comments?
[ ] Is the README up to date?
[ ] Has the POM been updated for the latest versions of dependencies?
[ ] Has the code been double-checked against main?
[ ] Does the code adhere standards in this repository, including SonarQube checks?

Testing

[ ] Do the code changes have unit and integration tests with code coverage > 80%?
[ ] Has the code been tested locally and/or passed the API Karate tests on Tilt?
[ ] Have mandatory manual test cases been run?
[ ] Are extra Karate tests required?
[ ] Are all the test data resources up to date?

Release preparation
Where possible, add links to the respective Jira tickets when an item is checked

[ ] Have these changes been included in a release ticket?
[ ] Are changes required to the docker-chs-development deployment or test data?
[ ] Are any changes required to the environment added to deployment repositories?

Notes to the tester
Add any testing hints or instructions here.

CI: No security warnings found


Experimental cleanup in CSS-in-JS templates

Closing as it is properly fixed in a later version of JSCodeShift


Improved Waveshare TFT handling and added Readme

Display is better - @kylefmohr you might like to update to this version

@i-am-shodan nice, adding CI builds was something I was thinking about, good idea!


Retained Messages Delivered Only Once?

I've run into a strange behaviour in which I have 5 retained messages across different topics (all under msg/<something>, and a client connecting and subscribing to msg/#. Now, if the client connects using a clean session, these retained messages are delivered every time the client connects (the expected behaviour). However, if clean session is set to false, the client only receives them once (the first time the client connects). I would say this behaviour is unexpected, as I believe retained messages should be delivered every time an interested client connects (regardless of whether its session is clean or not). Could you reproduce this @erylee?

BTW, I'm using both  0.11.0 and 0.12.1.

@erylee it may be interesting to notice that I can work around this by first unsubscribing from msg/# and then re-subscribing it. However, this is a workaround I would prefer not to use.

@bmcustodio, sorry for late reply. A business trip to Beijing yesterday.
The retained messages will be delivered when new subscriptions created. The persistent sessions(clean session = 0) cached all the subscriptions, so retained messages will not be dispatched when a client resume an existed session.
I will check the MQTT V3.1.1 protocol specification to check if the broker works properly.

@erylee no problem at all. I have re-read the protocol spec now and, indeed, I see no mention as to whether retained messages should be re-delivered in case of a non-clean session (so this might indeed be expected). However, it would be great if the broker's behaviour could be extended to support this (the way I see it the protocol leaves this matter open, so it could be implemented as an extension). What do you think? Do you agree?

Okay, I will check it later. Maybe we could add a config item in etc/emqttd.config to support this feature.

@erylee that would be great indeed :-)

@emqplus We have an issue with version 2.2
Where a client that subscribes to topics
when connects again with with clean session false
does not get the retained message for the topics it subscribed.
This is a good breakdown of the differences of behavior,
http://www.steves-internet-guide.com/mqtt-clean-sessions-example/
is Test 4. Supported? Whe QoS 1 for publish and subscribe yields retained
messages when re-connecting?


Scorecard is difficult to read

No opacity, increase font size / try a different font style

Increased font size, No opacity


Carriage Returns in text qualified fields create new lines

If a field in the CSV data contains line feeds (CRLF) or similar, the line will get split regardless of any text qualification.

Can you include a sample snippet to demonstrate the bug?

It handles CRLF that are quoted. See WriteWithNewLine() unit test as an example.


Order available voicingManager voices by priority

I'm using the voicingManager for the SpeechSynthesisButton in Number Play, and recently noticed that the current voice being used on my machine (MacOS + Chrome) was different (and less desirable) than a few weeks ago.
I looked at the available voices in voicingManager.voices and found that all the same ones that I remember were there, they were just in a different order (Google's voices used to be at the top of the list, now they appear to be at the bottom). And voicingManager, as well as the locale-specific voice choosing code I'm using in Number Play, just selects the first one in the list. So it was unclear to me why the order changed (browser update, maybe?), but it seems like we should be giving preference to the voices we like best so that when they do exist on a particular browser/machine, they are intentionally chosen instead of relying on the order of the list.
@jessegreenberg and I made some comparisons, both on MacOS + Chrome, and found that while we have a lot of the same voices, they were not in the same order. This seems like another case where, if we both have the same list, running a sim should use the same voice so our experience is consistent (unless we need to take into consideration people choosing a specific voice for their machine @jessegreenberg? do you know if that affects what voice the browser chooses?).
After figuring this out, @jessegreenberg recommended a couple things we could do to prioritize what voices are used - first, we could order the list of all voices by putting the types we like at the top, like Google's voices. This would be general support for all locales, so that once we filter down to, say Spanish, if a Google voice exists for that locale, it will be chosen. However, this only gets us so far because desirable types of voices may not exist in all browsers (non-Chrome browsers, for the example above). So, we could also create an explicit list of ordered voices for English, so we can get specific with the voices by their name, which might look more like getBestSoundingEnglishVoice. Something like this would ensure that two Mac users would hear the same thing when in english.
@jessegreenberg offered to try this out, thank you!

unless we need to take into consideration people choosing a specific voice for their machine @jessegreenberg? do you know if that affects what voice the browser chooses?).

@chrisklus helped me look into this. There is a default property on Voices, and according to the spec it behaves like

"This attribute is true for at most one voice per language. There may be a different default for each language. It is user agent dependent how default voices are determined."

We tested out changing the default OS voice and seeing how it impacted the default voice for the browser. On my Windows 10 machine changing the OS voice had no impact on the default voice in Chrome, even when I fully restarted Chrome. But on @chrisklus Mac changing the default system voice did change the default Chrome voice.  So we are hesitant to force a different default voice when the original default voice may have been purposely selected by the user.
But we did decide to add a function like getPrioritizedVoiceList that would return the list of voices but with the best sounding ones at the top (google, microsoft, at the top. then others). This could be used in the number-play case if that is best. I am not sure whether to use this for Voicing yet.

A basic function was done in the above commit to prioritize "Google" voices.
I asked the Voicing team on slack whether something like this should be used for Voicing.
@chrisklus will this function work for number-play for now?

Thanks @jessegreenberg!
I noticed that the existing sort was alphabetizing the remaining voices after prioritizing Google voices, so @jessegreenberg and I chatted on Slack about a fix. I pushed a commit above that appears to be fulfilling the behavior we would like. If a browser doesn't have Google voices but does have the system default first in the list, it will preserve that order.
I noticed that Safari just provides the list of ordered voices, without putting the current system voice first, like Chrome does. Do we know if Safari defaults to the current system voice a different way (not by ordering the list of voices?). I'd be curious to how we can best support prioritizing voices for all browsers.

Thanks looks good, thanks @chrisklus. I tested in Chrome to verify that Google voices come first, then tested in Firefox and Edge to verify that order of voices stayed the same when there are no Google voices.

Do we know if Safari defaults to the current system voice a different way (not by ordering the list of voices?)

I don't see anything in the W3C spec about the order of the voices list (https://wicg.github.io/speech-api/#dom-speechsynthesis-getvoices). I don't think we can assume that the first in the list is the voice with the default attribute. And in https://github.com/phetsims/scenery/issues/1282#issuecomment-921247063 we found that the voice with the default attribute may or may not adhere to operating system preferences set by the user.
Over slack I asked Voicing team if we should prioritize voices even though that could go against user settings and @terracoda said

I agree that presenting the best voices we know of would be a good idea. [...] if someone really loves Fred, they can always choose him, and eventually someday we may have a way of saving ones preferences, right?

For now, I am going to change the sorting to be "google first, Fred last" because "Fred" is by far the most robotic sounding voice.

In my initial commit I noticed that 'Fred' was not at the bottom on macOS Chrome. To understand why I found examples at https://stackoverflow.com/questions/29829205/sort-an-array-so-that-null-values-always-come-last which demonstrate when you want to make sure something as at the front/end of a list using sort you have to specify the behavior for both values in the comparator function. So after https://github.com/phetsims/scenery/commit/e2619a51919fb6921bdfa4a67dcada557f36baee the sorting is as I would expect, with "Google" voices first and "Fred" last.
I am also using this function in the joist/PreferencesDialog now so that voice options use this priority.
@chrisklus can you please review this change?

@jessegreenberg and I returned to this issue today while investigating https://github.com/phetsims/number-play/issues/134 and we tested the first method from https://github.com/phetsims/scenery/issues/1282#issuecomment-935466165 and found to work well on all browsers. Thank you @samreid! We are ready to close.


fixes #62 - enpty errors coming from proxy

Description
This PR fixes the case where an error issued by the proxy would be eventually be received as an empty string by the client.
Related issue

#62

Root cause
Errors are always embedded inside a RequestResponse object. In case the error is triggered by Kuzzle, the response object has already been serialized during the transport of the message from Kuzzle to the proxy.
This serialization process was not done when the error was directly issued by the proxy, and because the RequestResponse native object does not actually have any content property, the end result would be an empty string.

Codecov Report

Merging #63 into rc.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             rc.x      #63   +/-   ##
=======================================
  Coverage   98.98%   98.98%
=======================================
  Files          16       16
  Lines         690      690
=======================================
  Hits          683      683
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc2e7b...4e7e087. Read the comment docs.