Redis Subscription Fails with: Unexpected Execution Error (HC0008)

Describe the bug
I try to add a RedisSubscription Provider to my GQL API. If I do replace the Redis Subscription handler with the In Memory Subscription handler: Everything works as expected.
To Reproduce
Steps to reproduce the behavior:

Create A Azure Cache with default Settings.
Use the following code to set everything up:

var redisConnectionConfiguration = new ConfigurationOptions()
{
    Ssl = true,
    AbortOnConnectFail = false,
    Password = "TAKE_FROM_AZURE_PORTAL",
};
redisConnectionConfiguration.EndPoints.Add("TAKE_FORM_AZURE_PORTAL.redis.cache.windows.net:6380");

services.AddRedisSubscriptions(_ => ConnectionMultiplexer.Connect(redisConnectionConfiguration));

Send an Event using ITopicEventSender -> You can view the data in redis using psubscribe *.
Call the GQL Subscription that does work if you use a InMemeorySubscription Handler.

Expected behavior
The Event Data which is visible in Redis is shown in my GQL Client (Banana Cake Pop). But I do get the following Error:
{
  "errors": [
    {
      "message": "Unexpected Execution Error",
      "extensions": {
        "code": "HC0008"
      }
    }
  ]
}

Desktop (please complete the following information):

OS: MacOS 11.2.3
Version: 11.2.2

When you debug your application you should be seeing a more concrete exception than the Unexpected Execution Error presented to clients. Would be helpful, if you could include said exception.

I have the same behaviour. I use an in memory subscription but I guess the reason might be the same. I get HotChocolate.Subscriptions.InMemory.InvalidMessageTypeException .
The return type of my subscription is a generic one. Actually in that case it was an enum. Can that cause the error?


Version for new release?

@cnweaver and I would like a new release to grab some of the latest features from master. I can do the work to put out a new release, but wanted to check that this would correspond with a minor version bump or major? It's not clear to me what the API changes introduced by the work @cnweaver added and how much of this is backwards incompatible.

It is backwards incompatible enough to quite noticeably break code written against the old interface, unfortunately: https://github.com/scimma/hop-client/issues/158 .
Whether you want to treat that as a major version change or not is mostly up to how you want to interpret the version number.

I have no preference personally on whether we go with 2.0.0 or 1.3.0. Following SemVer to the letter would be nice in principle.

Yes, since this is a breaking change, it should be 2.0.0, I think.


FormatterPos in cmsalpha.c broken for swapped-endian case

Hi Marti,
Thank you for the quick fix to #159.  I believe another fix is needed.
FormatterPos in cmsalpha.c (line 346) is currently broken; it never hits the final test of T_ENDIAN16 (because it will have already exited at previous test if (b == 2 && !T_FLOAT(frm))).  And, if it did reach the T_ENDIAN16 test, it would return a wrong index into the table (should return '2' not '3').
This small change seems overkill for a formal pull request, so here is my guess at a fixed function:
// Returns the position (x or y) of the formatter in the table of functions
static
int FormatterPos(cmsUInt32Number frm)
{
    cmsUInt32Number  b = T_BYTES(frm);

    if (b == 0 && T_FLOAT(frm))
        return 5; // DBL
#ifndef CMS_NO_HALF_SUPPORT
    if (b == 2 && T_FLOAT(frm))
        return 3; // HLF
#endif
    if (b == 4 && T_FLOAT(frm))
        return 4; // FLT
    if (b == 2 && !T_FLOAT(frm))
		if (T_ENDIAN16(frm))
			return 2; // 16SE
		else
			return 1; // 16
    if (b == 1 && !T_FLOAT(frm))
        return 0; // 8

    return -1; // not recognized
}

Thank you!

fixed in 2.10 rc1


Using OWL-QN correctly

I'm trying to minimize the L1 norm of x for the system  Ax==b using the OWL-QN algorithm. However, it's not clear to me from the documentations of libLBFGS and pyLBFGS how to do this. I'm assuming that we should use the fmin_lbfgs(...) method, but how to define the callable f and its gradient vector g? Any quick suggestions?

Yeah, same here. Could somebody explain how to set the property for OWL-QN correctly?
I think that the function handle f is independent of the chosen algorithm. To my understanding, this can be set somehow.
But does anybody knows how?

@mettmexx It has been over a year since I struggled with this, but I finally figured it out (for my use-case). Maybe take a look at my alternative, Python 3 version "pylbfgs" here: https://bitbucket.org/rtaylor/pylbfgs
Also, I use it in an actual project here: http://www.pyrunner.com/weblog/2016/05/26/compressed-sensing-python/
No promises, but those links might help you. Cheers!


ctlptl does not work when containerd integration is enabled

Repro steps:

Enable containerd integration on Docker
Run ctlptly apply -f ./examples/kind.yaml

Result:
Error response from daemon: Bad response from Docker engine

We believe this is a docker engine bug. Working with them on it.

this should be fixed in Docker Desktop 4.17. (minikube support is a bit dicey but nothing ctlptl specific)


fix header styles

Related Issue

resolves issue #21
Summary of Changes

Updated header and navigation components styles and some structure to better match original version.

Thank you!  🙏


sc-4867: display PKCS12 password on registration

Codecov Report

Merging #489 (e79ead9) into main (b5b4f98) will decrease coverage by 9.48%.
The diff coverage is n/a.

:exclamation: Current head e79ead9 differs from pull request most recent head c8586b0. Consider uploading reports for the commit c8586b0 to get more accurate results

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   46.94%   37.46%   -9.49%
==========================================
  Files         233      151      -82
  Lines       11673     2389    -9284
  Branches      608      608
==========================================
- Hits         5480      895    -4585
+ Misses       5234     1319    -3915
+ Partials      959      175     -784

Impacted Files
Coverage Δ

...com/trisacrypto/directory/pkg/bff/api/v1/client.go

...b.com/trisacrypto/directory/pkg/gds/interceptor.go

...github.com/trisacrypto/directory/pkg/bff/status.go

...m/trisacrypto/directory/pkg/gds/store/trtl/trtl.go

...com/trisacrypto/directory/pkg/gds/admin/v2/auth.go

...ithub.com/trisacrypto/directory/pkg/gds/members.go

...thub.com/trisacrypto/directory/pkg/bff/parallel.go

...isacrypto/directory/pkg/gds/store/trtl/iterator.go

...com/trisacrypto/directory/pkg/bff/api/v1/errors.go

...com/trisacrypto/directory/pkg/utils/wire/rewire.go

... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b4f98...c8586b0. Read the comment docs.


Use new infra for sierra_adapter

What is this PR trying to achieve?
Update the sierra_adapter to use the new infra modules.
Who is this change for?
Folk who want simpler infra!

I’m going to review this now.


unable to align center in jspdf

i want to align barcode in center as we can add style in our doc.text("Item: " , x , y ,{ align: 'center' })..
how can i do this?

Hi @hamzaakramPaleBlue , I've added the feature. Try to upgrade the library to version 0.0.8
let me know if there is still any issue


[Core feature] Add Raw AWS Batch Task

Signed-off-by: Kevin Su<EMAIL_ADDRESS>TL;DR
Run regular tasks on AWS batch service
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[x] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Add AWS batch job plugin
Example:
import typing
from flytekitplugins.awsbatch import AWSBatch
from flytekit import TaskMetadata, map_task, task, workflow

config = AWSBatch(
    parameters={"codec": "mp4"},
    PlatformCapabilities=["EC2"],
    PropagateTags=True,
    RetryStrategy={"attempts": 10},
    Tags={"hello": "world"},
    Timeout={"attemptDurationSeconds": 60},
)

@task(task_config=AWSBatch(Tags={"hello": "world"}))
def t1(a: typing.List[int]) -> str:
    return str(a[0])

@task(task_config=AWSBatch(Tags={"hello": "flyte"}))
def t3(a: str, b: str) -> str:
    return b + "".join(a)

@task(task_config=config)
def create_list(n: int) -> typing.List[int]:
    res = []
    for i in range(n):
        res.append(i)
    return res

@workflow
def my_wf(a: int, b: str) -> str:
    l = create_list(n=a)
    y = t1(a=l)
    d = t3(a=y, b=b)
    return y

if __name__ == "__main__":
    x = my_wf(a=3, b="hello")
    print(f"Workflow output: {x}")

Tracking Issue
https://github.com/flyteorg/flyte/issues/1792
Follow-up issue

Should we allow people to define the job definition or the submitjob input structs?
"most" of the properties set on the job definition can be overridden in the SubmitJobInput, the benefit of reusing a job definition is 1) there is a limit on the number of job definitions and the rate of creation and 2) reducing the number of API calls needed to launch a job is always a good thing for reliability standpoint....
So please go through both links and let me know if there are properties that you need users to set that are only available in job definitions...

@kumare3 @pingsutw ^

@pingsutw I agree with @EngHabu, we should try and minimize job definition creations

oh and end to end testing worked on demo right?


FR: "blackbox_edit FILE" should encrypt if not already encrypted, and call $EDITOR

It would be convenient to just be able to type "blackbox_edit FILE" and not have to think about the entire process:
Is the file encrypted already?
No: Ask "are you sure?" and then blackbox_register_new_file.
Yes: decrypt.
Call $EDITOR
Was "-d" option specified?"
Yes: Re-encrypt and delete the plaintext version.
No: Re-encrypt and leave the plaintext version alone. Output instructions on how to safely shred it.

I'm resolving this without the "-d" flag implemented. If you want the -d flag, just use blackbox_edit_start.


Save last uuid to fix issue with EndCall Transaction

The issue is that the link to uuid is not being saved anywhere and than the call to self.callKitCallController requestTransaction:transaction ends up with an error = 4 because it doesn't have the object internally.
Simply saving the link solves the issue (of course it has to be improved when you do the group calls and on-hold calls, but it does the job for now)

Hi @viniychuk, thanks for the PR. I've got 2 questions:

I didn't see you use the saved _lastUUID instance variable. If it's not being used why we are going to save it?
Looks like there are some fixes that isn't related to this PR, which are under functions configureAudioSession and performSetHeldCallAction. If they are needed by your side can you please submit a separated PR and elaborate it more?

Cheers!


feat: RegisterUser UseCase tests

At this point, i made some adjust for my tests to verify the mock actions made, this impacts on how i build the useCase class mock adding some lines at the test but it keep simple,


[dartdevc] DDK does not properly handle external constant tearoffs

Test case:
import 'dart:math' as math;

main() {
	var a = [1, 2, 3];
	a.fold(0, math.max);
}

This passes in DDC but crashes in DDK. DDC wraps the external JS function as:
  a[$fold](core.int, 0, dart.gbind(dart.fn(math.max, dart.gFnType(T => [T, [T, T]], T => [core.num])), core.int));

But DDK only generates:
  a[$fold](core.int, 0, dart.gbind(math.max, core.int));

Any kind of Dart member access on math.max fails since it's not converted properly to a dart object.
Underlying issue of: https://github.com/dart-lang/sdk/issues/37822

Fix out at: https://dart-review.googlesource.com/c/sdk/+/112756


'Host' header missing when HTTP3 is in use prevents "SecRule REQUEST_HEADERS:Host" rules from being effective.

Hello Team and thanks for your work on the modsec connector for Nginx.
We built nginx with modsec and the modsec connector using the official 'nginx-quic' branch for implementing HTTP3. We use nginx primarily as a global reverse proxy server for our web infrastructure, providing SSL/TLS encryption for our web apps as well as threats protection thanks to modsec.
Everything is working fine apart from several rules we implemented which at the time seemed ineffective, for some unknown reasons.
After some debugging (by enabling modsec's audit logs), it appears that the 'Host' header is missing when the clients request via HTTP3 (that header is not present in modsec's audit logs). That would explain our issue: since that header is unavailable to modsec, all rules like "SecRule REQUEST_HEADERS:Host" are ineffective when clients connect via HTTP3. We then checked with both HTTP1.1/2: the Host header is present in the audit logs, and our rules are applied successfully as they should. We tried to find a workaround by using the 'headers-more' module from openresty and applying custom inbound headers. However it seems like modsec's processing is done prior to our custom headers being injected, which makes such workaround hopeless. Not quite sure what to do next. It's also possible that the Host header not being present is an HTTP3 specification, possibly. It is to note that rules using REQUEST_URI are working normally via all protocols, including HTTP3. Any possible to suggest? Is anybody else experiencing the same? Thanks in advance for your help!

I had to disable 2 rules to get HTTP/3 working:
2023-05-25 disable HTTP/2 check (which affects quic and HTTP/3)
SecRuleRemoveById 920180
"Request Missing a Host Header"
SecRuleRemoveById 920280

Hello @jsoranzo ,
Your inquiry seems to be mostly focussed on particular rules you are using with ModSecurity. Questions and issues related to the engine itself (at the repo https://github.com/SpiderLabs/ModSecurity ) or the nginx connector (this repo) can be directed to to these locations but questions about particular rules are usually best addressed to the ruleset publishers.
However, I will make a couple of observations that may help:
First note that it is entirely normal in most deployments to have to exclude certain rules or write exceptions, no matter what ruleset one is using -- and that is particularly true for generic rulesets. Such rules generally try to identify suspicious content but  often have some level of possibility of false positives.
Regarding the Host: header, for example, it is required in HTTP 1.1, therefore its absence may be a source of suspicion. However, that same requirement may not be in place for HTTP3.
In other words, modifying a request to add an extra header merely to have your rules work is likely not the best approach. Instead, if the absence of a Host: header is expected, you should feel free to disable the relevant rules either:

always or
only if the protocol is HTTP3

Thank you for your comments.
A precision: we're using the OWASP core rule set.
Just as @jpopovitch, we had to disable a couple rules for HTTP3 to work properly the set: 920180 and 920280.
We also adjusted rule 900230 to allow the HTTP/3 protocol.
Now from our perspective, the main problem with not having that Host header present with HTTP3 clients is when we want to disable or adjust specific rules for specific domains. Our Nginx proxy servers serve many applications over multiple domains. The idea is to keep as many core rules enabled as possible (in order to provide the highest level of protection possible), and only disable the ones impacting our web apps' normal operations (false positives). Using the Host header allows us to easily set which rules we want to modify/disable and for which domain.
I guess we'll have to adapt to that header's non-presence with HTTP/3, and find other ways to adjust rules, such as using REQUEST_URI instead as previously mentioned.


Consider making EF Core 2.x work with ASP.NET Core 3.0

Things to consider:

[ ] 2.2 packages can load in 3.0 app, including lifting dependencies as needed
[ ] 2.2 command line tools work with 3.0

The problematic issue here is getting dotnet-ef to work with the new ASP.NET generic host builder pattern, since there is no way to update the dotnet-ef we shipped in 2.2.

[ ] Ensure ASP.NET Identity works
[ ] Ensure Database Error Page works
[ ] Ensure MusicStore works
[ ] Ensure Health Checks works
[ ] Ensure Identity templates work
[ ] Ensure ASP.NET scaffolding works

Another possibility: ship a 2.3 which is not in the shared framework and makes these things work.

there is no way to update the dotnet-ef we shipped in 2.2

We can update dotnet-ef: We ship a working version of dotnet-ef on NuGet that can be used with the 3.0 SDK.

We'll need to patch EFCore.Design to understand the the generic host pattern. I think there were some issues with patching EFCore.Design, but they shouldn't affect projects using the 3.0 SDK.

Note: this is not a finalized plan, but rather something we want to investigate.

@ajcvickers is this no longer potentially going to happen?
We was really looking forward to using .NET Core 3 features (eg: Blazor) but we need to talk to Oracle databases, which has just been released for EF Core 2.2

@chris5287 This was a backup plan in case we were not able to deliver EF Core 3.0 by the ship date for .NET Core/ASP.NET Core 3.0. Following a review yesterday we agreed that EF Core 3.0 does not need to slip, and hence we don't need this backup plan.
That being said, it might still be worth doing this for reasons like you mention. I'll re-open to discuss with the team. However, it certainly won't happen until after 3.0 ships.
/cc @divega

We discussed this in triage and while we are not going to do anything to proactively support this, we also don't plan to do anything to block it. If people are trying to do this and things don't work, then please file issues and we will look at them on a case-by-case basis.


Update build for 11.7.1

Update build to use locally sourced cuda headers, remove some dependencies, lock to gcc 11.2 since cudatoolkit 11.7 can't use gcc 12.1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [20, 21, 22, 23]

@conda-forge-admin, please rerender

Does something run-export a different compiler version?

@leofang The headers get passed in via the CUDA_PATH or CUDA_HOME variable, which gets declared as the first line in the build script.
It looks like CF already locks to gcc 10.*, so my locking to 11.2 ends up making the 11.2 look like a build string, creating an unresolvable environment. Reverted, let's see if there's anything else.

Looking good now, let me commit and approve.


lightning talk details

Is Session 2 the one that Emily Vaughan will be emcee'ing? If so let's put her name as an additional DRI so folks know who to find day-of for questions or concerns.


async iterator shutdown mechanic

I am developing an application with this library and occasionally the application crashes during development. This often leaves my terminal in a 'tty raw' state, where I cant use keys like "ctrl+c". For now the fix is to add a Deno.setRaw(Deno.stdin.rid, false) somewhere in my shutdown code. Ideally though, this library would add a close() hook, or the ability to pass in an AbortController. For instance, this is how Deno.watchFs handles cleanup:
const watcher = Deno.watchFs('./folder')
for await (const event of watcher) {
  console.log(event)
}

setTimeout(() => {
  watcher.close()
}, 1000)

Let's try watcher_test.ts from PR. It is still need to press something to break for..of cycle, because there are no ways to abort Deno.stdin.read();
My be close method of watcher is a good workaround in some cases, but it can be completely messy if i pass my reader explicitly.
I think we need to think about it a little bit more.


Fix out-of-bounds access possibility in safe code.

With the id and tree fields of NodeRef and NodeMut being public, it was possible to assign to them. For example, it was possible to build a NodeMut for large ID/index in a small tree/Vec. Since some APIs use unchecked indexing, this would let users of this library cause out-of-bounds access in a Vec without writing unsafe code themselves.
This commit fixes that issue by making the fields private and instead providing read-only access via accessor methods. Now the fields can only be set by the ego-tree crate, which can make sure to only ever use an ID that is in-bounds for a given tree.

Yikes. If I remember correctly this used to be the API but at some point I switched to public fields thinking that NodeId being opaque was enough.

I’ve added an intermediate commit with a SemVer-compatible version that keeps the fields public but deprecates them. Publishing both commits might be best to do now.

Great idea. Thanks

0.5.1 and 0.6.0 published


Please update librdkafka to last RC version in Beta packages

We would really like to test new beta packages of Confluent.Kafka. But there are some bugs in librdkafka 1.0.0-PRE1 that referenced in last v1.0-beta2 package, which impede testing. It would be very great if your release new beta package with last librdkafka 1.0.0-RC5 with a lot of fixed bugs. I think it will very help community to test and adopt new features.

Closing this as we're on v2.4.0 now.


Define JSON standard for json-storage and contract

For support BigNumber, I defined replacer and reviver for JSON.stringify and JSON.parse, but I forgot to consider how to deserialize these in contract with rust.
In order to keep unified standards for JSON with kuai and contract, we should define which types can use in JSON and how to serialize and deserialize them.
If we only support simple type maybe we only need to give an example, but if we support complex type(BigNumber), we may need to export a rust SDK to deserialize the hex string to a struct.
@zhengjianhui How do you think?

We will remove support BigNumber, json-storage will only support string in simple types.

It is recommended to use hex

For support BigNumber, I defined replacer and reviver for JSON.stringify and JSON.parse, but I forgot to consider how to deserialize these in contract with rust.
In order to keep unified standards for JSON with kuai and contract, we should define which types can use in JSON and how to serialize and deserialize them. If we only support simple type maybe we only need to give an example, but if we support complex type(BigNumber), we may need to export a rust SDK to deserialize the hex string to a struct.
@zhengjianhui How do you think?

It is recommended to use hex


Split-screen multitasking on iOS 9

Hey there,
I've been using auto-layout with storyboard in the past, but I started to realise that it's quite limiting/becomes more of a burden when it comes to complex designs. I've been looking at alternatives, even if that means doing more in code, rather than the easy "drag and drop" storyboard way of constraining UI elements.
My question is, would the new iOS 9 split-screen multitasking feature work just fine if I used PureLayout instead of auto-layout directly via storyboard? I don't see any reason why not, since (as far as I understand it) PureLayout is just a wrapper for auto-layout. But I just wanted to confirm it.
Thanks in advance! :)

Hi Junaid,
Yes, you can implement support for split-screen multitasking very well using PureLayout. PureLayout just makes creating & managing auto layout constraints easier. But they are the same constraints you'd get if you used Interface Builder instead.
I gave a talk earlier this year, Adaptive Auto Layout, which talks about lots of things you will want to be aware of when building your app to support adaptivity. I highly recommend watching the YouTube video there if you're interested in learning more, including some specific discussion about PureLayout as well.
If you don't have time to watch the video, make sure you understand how trait collections are inherited, and then implement traitCollectionDidChange: to set up and change your constraints at runtime, primarily based on the horizontalSizeClass.

Will certainly watch the video. Thanks a lot for your help, appreciate it!
J


Bug: code is true although unrealistic latency

I guess the code in the second row should be false, not true.
$ curl <IP_ADDRESS>:8080
  3.647861ms code:true    133.747739ms code:true  225.949762ms code:true
  0s code:true            0s code:true            0s code:true
  522.235376ms code:true  610.539559ms code:true  97.737339ms code:true

ah yeah, makes sense. I guess we should differentiate between the null-value for the latency and an actual zero value (unmeasurably fast!!!!)


Super classes and interfaces of annotated classes should also be reflectable.

This is needed in order to walk the super chain to get all members of a class. It is not possible to add an annotation to all super classes since many of them live in the sdk (Object for example).
For example, currently this will fail:
class MyReflectable extends Reflectable {
  const MyReflectable() : super(instanceInvokeCapability);
}
const myReflectable = const MyReflectable()

@myReflectable
class MyClass {}

main() {
  var typeMirror = myReflectable.reflectType(MyClass);

  // Throws exception because `Object` is not reflectable.
  var superclass = typeMirror.superclass;
}

This could be hidden possibly under a capability, such as superclassCapability or something along those lines to avoid code bloat in cases that don't need it?

I think that it is reasonable to say that it is already covered. The inclusion of otherwise-not-reflectable superclasses is implied by typeRelationsCapability, because that capability subsumes the superClassCapability (which never existed, but it is implicitly present on p.7 in Fig.1 in the capability design document, and is then later unified with others into typeRelationsCapability).
Granted, it's not the same thing to promise that superclass can be used on a ClassMirror, and promising that the set of reflectable classes will be upwards closed (i.e., that all direct and indirect superclasses of reflectable classes will also be considered reflectable). However, it has essentially a zero cost to support the use of the superclass method among class mirrors for a given set of reflectable classes, whereas the upward-closure may have a substantial cost (because it can make many additional classes reflectable, and each of them has many features).
Based on  this, I'll go for a model where upward-closure of the set of reflectable classes is part of the semantics of typeRelations. If needed, we can still split capabilities into more fine-grained ones, and reinterpret the more coarse-grained ones as 'grouping tokens' (p10 in the design document).
I'm currently implementing this. Note that many other parts of typeRelations are still not implemented.

ok, I filed a separate bug about the current error that is thrown and linked it here

FYI: Now sending a CL to review that includes code for upwards-closing the set of reflectable classes in case there is a typeRelationsCapability on the given reflector.


Settings sync stopped working after update to 1.59.0

Issue Type: Bug
Right after the update to 1.59.0 (system setup) and ever since, I am getting the following error (on two different computers) when trying to run settings sync. Another machine with version 1.58.2 (system setup) that I am yet to update, does not have this issue. Looks similar to https://github.com/microsoft/vscode/issues/114231
Error: Settings sync is suspended because of successive authorization failures. Please sign in again to continue synchronizing
VS Code version: Code 1.59.0 (379476f0e13988d90fab105c5c19e7abc8b1dea8, 2021-08-04T23:13:12.822Z)
OS version: Windows_NT x64 10.0.17763
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-2620 v4 @ 2.10GHz (32 x 2098)

GPU Status
2d_canvas: unavailable_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: disabled_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
undefined

Memory (System)
255.88GB (178.68GB free)

Process Argv
--crash-reporter-id 2d6b9e7e-2dbf-4a65-87b0-595066c88675

Screen Reader
no

VM
0%

Extensions (49)

Extension
Author (truncated)
Version

aws-toolkit-vscode
ama
1.27.0

armview
ben
0.4.5

bracket-pair-colorizer-2
Coe
0.2.1

docs-markdown
doc
0.2.96

docs-preview
doc
0.3.57

docs-yaml
doc
0.2.7

vscode-firefox-debug
fir
2.9.4

rest-client
hum
0.24.5

vscode-sshfs
Kel
1.21.2

azure-pipelines
ms-
1.188.1

vscode-apimanagement
ms-
1.0.3

vscode-azureappservice
ms-
0.23.0

vscode-azureeventgrid
ms-
0.1.1

vscode-azurefunctions
ms-
1.4.1

vscode-azureresourcegroups
ms-
0.4.0

vscode-azureserverlesspack
ms-
0.1.0

vscode-azurestorage
ms-
0.12.1

vscode-azurevirtualmachines
ms-
0.4.0

vscode-bicep
ms-
0.4.451

vscode-cosmosdb
ms-
0.18.0

vscode-docker
ms-
1.15.0

vscode-logicapps
ms-
1.0.17

csharp
ms-
1.23.14

vscode-dotnet-runtime
ms-
1.2.0

network-edge-devtools
ms-
1.0.0

python
ms-
2021.8.1105858891

vscode-pylance
ms-
2021.8.0

jupyter
ms-
2021.8.1195043623

remote-containers
ms-
0.191.0

remote-ssh
ms-
0.65.7

remote-ssh-edit
ms-
0.65.7

remote-wsl
ms-
0.58.2

vscode-remote-extensionpack
ms-
0.21.0

azure-account
ms-
0.9.8

azurecli
ms-
0.5.0

powershell
ms-
2021.6.2

vscode-node-azure-pack
ms-
0.2.1

azurerm-vscode-tools
msa
0.15.2

debugger-for-chrome
msj
4.12.12

debugger-for-edge
msj
1.0.15

vscode-sanddance
msr
3.3.0

vscode-data-preview
Ran
2.3.0

vscode-data-table
Ran
1.7.0

vscode-commons
red
0.0.6

vscode-yaml
red
0.22.0

vscode-inline-values-powershell
Tyl
0.0.5

shell-launcher
Tyr
0.4.1

vscode-java-debug
vsc
0.35.0

vscode-icons
vsc
11.6.0

I'm having the same issue, also since updating to 1.59.0. I am experiencing this on both Windows and macOS.

duplicate of #130314
you need last option from the context menu to choose an account for settings sync.

Choosing the account produces the same result. Instead of signing out, I chose the option to "Sign in with a Microsoft Account" and logged in with the same account. This appears to have fixed the problem.
Closing this GitHub issue in favor of duplicate https://github.com/microsoft/vscode/issues/130314
Thank you @SharakPL

I was already signed into both GitHub and Microsoft accounts in VSCode and signing in again did nothing. Last option to choose an account for Settings Sync did the trick.

I have the same problem at 1.60


Sample Code

The sample code in the ReadMe is wrong.
 <script src="https://unpkg.com/botframework-webchat/botchat.js"/>

should be
  <script src="https://unpkg.com/botframework-webchat/botchat.js"></script>

(only foxed me for an hour that one!) ;-)

Fixed as part of #348, thanks! And sorry for the lost hour.

Not your fault it was an hour, its been a loooong day 😅
Tah
On 24 Feb 2017 8:47 pm, "Bill Barnes"<EMAIL_ADDRESS>wrote:
Fixed as part of #348
https://github.com/Microsoft/BotFramework-WebChat/pull/348, thanks! And
sorry for the lost hour.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotFramework-WebChat/issues/349#issuecomment-282400350,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0IySNNDwT1I9sjU3NXcZzTFhXrgmX6ks5rf0HmgaJpZM4MLn3Z
.


How to identify Azure B2C Application Unique Id?

Hello All,
I have created two applications inside B2C. Say App1 and App2.
I have created one identity provider(IDPDemo) for pointing my identity server 4 instance.
But inside B2C, i linked same IDPDemo to both App1 and App2.
My Concern is how to identify inside my identity4 server which Azure B2C App(App1 or App2) has called to Identity server?
Any help on this would be appreciated.

This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use one of the our free or commercial support options
See here for more details.
Thanks!


[SPARK-27508][Test] Reduce test time of HiveClientSuites

What changes were proposed in this pull request?
The test time of HiveClientSuites on Jenkins is about 3.5 minutes.
The test suite itself is sometimes flaky.
I find that changing the default table from Managed table to External Table can fasten the tests, while the test scenarios are still covered.
How was this patch tested?
Unit test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10016/
Test PASSed.

Sorry, I think I have made some mistakes. The time is quite the same.


[1.12.2] Import Bus Crash

Issue description:
Placing an import bus seems to crash client on multiplayer
What happens:
One of my players was placing an import bus connected to a create (i believe) from Actually additions for the first crash and a Mystical Agriculture furnace for the second
What you expected to happen:
Suck items out of the adjacent block
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: 1.12.2-<IP_ADDRESS>73-universal  (not latest do to mod issues)
Refined Storage: 1.5.29

Does this issue occur on a server? [yes/no]
yes
If a (crash)log is relevant for this issue, link it here:

https://pastebin.com/md5QDbJR
https://pastebin.com/xVTwpP9t

[pastebin/gist/etc link here]

Oh shit, that shouldn't happen. A temporary workaround is to install mcmultipart. I will look into it tomorrow, I'm at a Christmas party now.

Sounds good. Honestly didn't even expect a response till after christmas XD Happy holidays

Duplicate of #1587

Fixed in 1.5.30! You too have a good one!


There should be an option to run provisioning scripts after mounts are done

Right now provisioning scripts cannot use files from the host filesystem because the mounts are created by the hostagent on request of the guestagent. There should be a mechanism to run additional provisioning scripts once the instance is deemed to be fully initialized.

Provisioning scripts should be executed always after mounts are setup

Is this issue still accurate?

I believe this issue is accurate when you are using mountType: reverse-sshfs. If you are using e.g. 9p then the mounts are already in place before the provisioning scripts run.


Added new sample - Hide SharePoint list from site contents

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

Related issues?
None

Solution Details

Q
A

Solution requires premium license
no

Which connectors are used?
SharePoint, Outlook

Solution uses on-premises connectors?
no

Solution uses custom connectors?
no

What's in this Pull Request?
New sample: Power Automate Flow to hide or show a SharePoint list on the Site Contents page.

Thanks again @michelcarlo. Will get this processed soon as well. You rock! 🧡💜🤩

Thanks again @michelcarlo. Will get this processed soon as well. You rock! 🧡💜🤩

Cheers David!!!🤩🤩🤩

Hi @michelcarlo - same for this one.  Could you please provide the zip file?

Hi @michelcarlo - same for this one. Could you please provide the zip file?

Hey April,
Sure, just submitted it.


depends on test-fixture ^2.0.1

Trying to delete that branch on test-fixture which is now merged into 2.0.0

@e111077 good to go


fix: SSR deep imports externalization (fixes #8420)

Description
Fixes the error reported by @benmccann here https://github.com/vitejs/vite/issues/8420
But after this fix, SvelteKit is still not building as there is an issue with .css imports
kit.svelte.dev:build: TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".css" for /Users/patak/ecosystem/kit/node_modules/.pnpm/@sveltejs+site-kit<EMAIL_ADDRESS>
We can still merge this one while we work on the other issue.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Tested SvelteKit and it is building after:
fix: don't externalize .css deep imports
We'll need to add later a .css dep in ssr test case in our CI


⚠ Samsung has degraded performance

In a468fb8, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2500 ms

Resolved: Samsung performance has improved in 8adc109.


Add eigen backend

Eigen is a bit faster, I think the speedup will grow if matrices get bigger.
Eigen also provide SparseMatrice & solver that could be interesting to experiment with.
| Metrics   |   Eigen | Regular | Eigen < Regular |
|-----------|--------:|--------:|-----------------|
|    99.00% | 0.00748 | 0.00765 |       TRUE      |
|    95.00% | 0.00737 | 0.00752 |       TRUE      |
|    75.00% | 0.00679 | 0.00734 |       TRUE      |
|    Median | 0.00640 | 0.00656 |       TRUE      |
|       Avg | 0.00624 | 0.00658 |       TRUE      |
| Deviation | 0.00071 | 0.00074 |       TRUE      |


[Feater Request] Add fill and stroke parameter

Hey @vaetas
thanks for that fantastic package which allows me to pass the stroke-width to the icon as well. I just took a look at the FeaterIcon class and am I wondering if it is possible to extend the parameters.
It wold be very nice if we could also pass the fill and the stroke parameter to the class. Do you think you can add this feature?
Kind regards

Hey @vaetas
this here is the offical linked answer by the team behind Feather Icon: https://github.com/feathericons/feather/issues/225#issuecomment-345473232
They basically say they will not support filled (solid) icons but theyself say you can change this by changing the fill attribute as the icon is in svg. I already tried this and it works without any problems. So, I don't see any problems here. Are we able to add that feature?
Thanks

I understand your point but only few icons make sense with fill color. I want to avoid situation where people try to use fill value and then achieve faulty icons.
I certainly need to give this problem some thoughts. Therefore I cannot give any ETA. Still, I lean towards not supporting this feature at all. I am not sure I would use something like this and if I want to support further development for this feature.
If you need this feature right now I suggest you copy the SVG and customize it yourself by hand for the icons you need. If you want all icons to be filled I still believe it would be better to find different icon set.

@vaetas thanks mate! I thinkn I will just fork you project then. I just need a couple of icons to be filled like a star or a bookmark icon when something is saved.


Users get offline ?

When the app goes background it completely stops all the communications. As a result the other end users see this user as offline. Also while the app is in background, if the other end user sends a chat message the current user not get notified. Is this normal behavior of this app (q-municate) ?

You are not the only one here. infact im also facing this problem for a week i have been still trying to find out how to send notifications to users using the GCM

GCM is working. Only thing is you need have actual devices for this. As far as I know the emulator is no good for this.
In quickblox control panel go to the Messages module. Then select the "Subscriptions" tab. In there you should see some entries. These are the GCM subscribed users in your quickblox application. Subscription happens with the login. Its there at  Mainactivity-Oncreate() method. Please check the attachment. Also you need to create a Google API application for this.
Use this link to create your google api application
https://code.google.com/apis/console

I created a server api and assigned it as production and development and i do have actual devices and i do see those lines but no notifications, Can we please Communicate through a chat application? because its been almost a week and a few days and im still trying to fix this, Thank you

Ok, Can you please give me your email ?. I can add you to my gtalk.
Thanks

<EMAIL_ADDRESS>

I need some help..Can you please add me?


add tufte-memo:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Description: this template package provides a memo document template inspired by the design of Edward Tufte's books.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

First time submitter (and not an avid Git user, either)... the checks fail on account of not finding the readme.md file, but this file is certainly present, from commit 22718be and also seen in my fork. Would someone be so kind as to point me in the right direction?

Ah. Case sensitive.

@elegaanz I've addressed your comments in 30a3616 - thanks.


Revert "[cxx-interop] Overhaul virtual method support"

Reverts apple/swift#71994

@swift-ci please test

Sorry about that! Would you mind disabling the tests instead? Reverting the entire PR would make git history a bit messy.

Egor's PR is the correct approach: https://github.com/apple/swift/pull/72050


Add more functions for retrieving incidents and incident notes

cc/ @batpad @ianshward
TODO:

[x] Pass PagerDuty URL in index.js, and check to see if all ✅ - @arunasank

Changed the index.js file so that the new calls work. @ianshward good to 🚢?

@arunasank I left a couple comments, and seeing that the README still needs to be updated to reflect the new constructor arguments.  It still says var pd = new Pagerduty('mySubdomain', 'myToken');
Otherwise, looks good to me.  Still no tests :sweat_smile: and I did not help w/ that situation since I didn't write any initally.  It might be a good point to add some though, while the code is fresh in your memory, and they could copy some of what you put together in the mbxcli branch (the mock PD server).

forgot to push tests!

LOL :spades: amazing

@ianshward Made some changes here. I think this will mean some minor changes in mbxcli, but was thinking that I'd make those once things get merged here so that there is not a lot of back and forth changes on code between here and there. Can you take a 👀 here when you find some time?

@arunasank LGTM, and the plan sounds good.

@ianshward Thanks! 🚢


amazon-ecs-cli: 1.18.0 -> 1.18.1

Motivation for this change
Simple update from 1.18.0 -> 1.18.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/md5-deprecated/6447/1

@GrahamcOfBorg build amazon-ecs-cli

waiting for darwin to finish


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_bf5124d5-d6da-4dde-9ac1-2577e041b0c8/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_bf5124d5-d6da-4dde-9ac1-2577e041b0c8.git

Docs Build status updates of commit 564e249:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-ServiceAccountCannotAccessRepository] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd3, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master#ops-e2e-ppe) and then retry the build. Don't know who to contact? Refer https://repos.opensource.microsoft.com/VSC-Service-Account/repos/docs-archive-test-source/permissions/ to get admin list of the repo if the repo is in one of the organizations Microsoft owns.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


⚠ Bofrost.lu has degraded performance

In 7b7d9ad, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1468 ms

Resolved: Bofrost.lu performance has improved in b51364e after 6 minutes.


Add support for category-parameter on ajax-calls.

Actually the ajax-handling for variants does not support the optional category-parameter (?c=32), which is passed in the url. This pull-request extends the ajax-call to pass this parameter, too.

@giginos: Thanks - will discuss it tomorrow with the others :)

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-14389.
Please use this issue to track the state of your pull request.

@giginos I was working on the ajax variants for the latest shopware release cause we had a small issue with the history management and fixed your issue as well.
You can see the changes here: https://github.com/shopware/shopware/commit/6dcc838b81c0f96b4a996b39a01762c96f28fce3


[move-prover] make inconsistency check instrumentation a separate pass(1)

Motivation
Trying to address consistent failures of the inconsistency test in CI
Description
The current inconsistency check instrumentation happens before the global invariant instrumentation pass, with the assumption that there will be no new verification targets created after the inconsistency check instrumentation.
This is OK until recently we start to create function instantiations according to the resource types touched by global invariants. Therefore, a function may have the following variants:
  - baseline
  - verification(regular)
  - verification(instantiation_1)
  - ...
  - verification(instantiation_n)

The current way of adding inconsistency invariant complicates the story.
  - baseline
  - verification(regular)
  - verification(inconsistency)
  - verification(instantiation_1) --> overriden to inconsistency check of instantiation_1

  ...
  verification(instantiation_n) --> overriden to inconsistency check of instantiation_n

This leads to the issue that a target of flavour verification(instantiation_n) is actually checking for
inconsistencies and timing out in this process is allowed. But the boogie wrapper thinks that it is a normal verification flavor and throws out an error on timeout.
Fix Added
The fix, which is this commit, is a refactor of the inconsistency check
instrumentation process. The inconsistency check instrumentation is now a standalone transformation pass in the pipeline and is purposely placed as the last pass in the pipeline. The instrumented scans for any target with a verification flavor and
forks that target and instruments the inconsistency check (which is an assert false; before return;) in the fork, and adds the fork back to the targets
After the instrumentation, we get
  - baseline
  - verification(regular)
  - verification(inconsistency(regular))
  - verification(instantiation_1)
  - verification(inconsistency(instantiation_1))

  ...

  - verification(instantiation_n)
  - verification(inconsistency(instantiation_n))

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
MVP_TEST_INCONSISTENCY=1 cargo test -p move-prover

Unfortunately, although we don't see timeouts anymore, we seem to have new inconsistencies detected
test prover diem[default]::modules/TransactionFee.move ... FAILED
error: there is an inconsistent assumption in the function, which may allow any post-condition (including false) to be proven
    ┌─ ../diem-framework/modules/TransactionFee.move:91:5
    │
 91 │ ╭     public fun burn_fees<CoinType>(
 92 │ │         tc_account: &signer,
 93 │ │     ) acquires TransactionFee {
 94 │ │         DiemTimestamp::assert_operating();
    · │
114 │ │         }
115 │ │     }
    │ ╰─────^

test prover diem[default]::modules/TreasuryComplianceScripts.move ... FAILED
Error: Unexpected prover output (expected none): Move prover returns: exiting with boogie verification errors
error: there is an inconsistent assumption in the function, which may allow any post-condition (including false) to be proven
    ┌─ ../diem-framework/modules/TreasuryComplianceScripts.move:308:5
    │
308 │ ╭     public(script) fun burn_txn_fees<CoinType>(tc_account: signer) {
309 │ │         TransactionFee::burn_fees<CoinType>(&tc_account);
310 │ │     }
    │ ╰─────^

/canary

/land

@ankitkacn :bulb: This PR is currently being canaried, cancel the canary before queuing for landing

:sunny: Canary successful

/land


Create a vanity import path at "nmstate.io/nmpolicy"

Following the path like other projects like kubevirt or k8s are consumed by other projects, maybe nmpolicy that is going to be consumed by kubernetes-nmstate and other projects need a vanity import like nmstate.io/nmpolicy that points to github.com/nmstate/nmpolicy, so the project is not stick to github.
One possible implementation is modify the "nmstate.io" page header and add the following meta:
<meta name="go-import" content="nmstate.io/nmpolicy git https://github.com/nmstate/nmpolicy">

This is how it's done at kubevirt: https://github.com/kubevirt/kubevirt.github.io/blob/main/_includes/head.html#L6-L18
Another alternative is to use a subdomain like go.nmstate.io similart to go.uber.org or go.opencensus.io so we don't have to modify the main webpage at nmstate.io.

If I understand this right, the motivation is to avoid being dependent on github.com?
Lets assume that a decision is taken to use some other source control hosting platform, can't we just do it then and declare a new version?

I must say, that I do not mind or have any hard opinion on this. I just want to "warn" about the domain, which is actually owned by Red Hat and not by any community organization.
In fact, most domains will be owned by someone, making that the dependency instead of github, so I am not sure if that is any better.

Right, same happends with kubevirt.io, I suppose it's owner by RedHat, but my main concern is that if we change to vanity imports when this project start to have some users (it's not like is going to be huge) we may end up with issues, but I think they are not that bad.

/kind enhancement


docs: Update README and CONTRIBUTING.md

Fixes #1 , #2
Rebased some commits

Will go though it soon

May i know why blob images is used for banner i didn't get that

May i know why blob images is used for banner i didn't get that
Edit nvm got that
Will merge in morning

Okay thanks 🚀


fix: reduce memory pressure while uploading files

Description of changes
This PR is a partial revert of https://github.com/aws-amplify/amplify-cli/pull/13493/files which caused https://github.com/aws-amplify/amplify-cli/issues/13681 .
I.e. using s3.upload API for all uploads puts a memory pressure due to https://github.com/aws/aws-sdk-js/issues/2552 .
This PR changes file uploading logic to buffer all files below 5mb in memory. This partially restoring previous behavior but avoiding full revert to s3.putObject API call which doesn't have retries.

Issue #, if available
https://github.com/aws-amplify/amplify-cli/issues/13681

Description of how you validated changes
PR checks and E2E tests.
Manual verification on t2.nano with sample test project where ENOMEM has been reproduced.
Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Change LGTM. Did you also verify that uploading on a slow network still works as expected? See verification description in the previous PR: #13493 (comment)

I played a bit with 3g profile, seems to be working.


PT hedging+transparent+stop

Fixed a problem with the negation, translated filtering files and updated rules.

I just wonder about (depNegations).toSet which must be an artifact left over from previous code.

Thanks for pointing it out. I have cleaned it out.

OK.  I don't want this waiting here to slow you down, so I'll merge.

I see that this is a different branch than the previous pt-neg+tets.  It looks like next time I should maybe resume deleting the branch after merging.  Would you go ahead and delete remote branches pt-* if you're done with them and/or have local copies?  Thanks, @gcgbarbosa.

Thanks @kwalcock. I deleted them, except for pt-tests because I am using it to synchronise the version of eidos I have in my machine and the version on the servers if i need to run something there. Idk if this is ok or if there is a better way to do that.

That's great.  I have a branch to do exactly the same.

Awesome! Thanks.


Add security group to RDS terraform definition to limit access by port

The current terraform plan does not include a security group to limit access to the RDS instance to port 3306 (mysql). The terraform RDS guide here, which links to the definition here, demonstrates how this would be done.

I was misreading that definition. From port and to port define a range of ports, not a source and destination.


5802

Issue #: /bcgov/entity#5802
Description of changes:

updated version to 0.5.3
deleted obsolete Bcol Error Dialog
added errors and warning to Payment Error Dialog
deleted obsolete Bcol Mixin
updated save error handling
replaced saveFiling by updateFiling
fixed Filing ID type in state
deleted saveFiling
updated updateFiling
updated unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Looks good, will review again when ready to be merged 👍

Looks good, will review again when ready to be merged 👍


Paste decorators before empty text nodes

Right now if you paste a decorator node (like the Youtubenode) on an empty text node, it'll insert the decorator node after the empty text. This feels a bit unintuitive, as then the user has a blank line.
Instead, if there's no text, we should insert the decorator before the empty text node so the user can go on typing, adding other content, etc.
New behavior:

Old/current behavior (on main):

Added a test, although I'm not sure if that's the best home for it.

@zurfyx not sure why but the test is now failing with the insert YouTube embed locally.. any idea? All I changed was how the url was added.

There's a couple tests not passing on main that are also failing here.

There's a couple tests not passing on main that are also failing here.

Do you mind rebasing? Main should be fine now. We're aware of some heavy flakiness for a couple Linux tests but otherwise the CI should pass

The below tests seem to be consistently failing, can you revise these please?
[1]   2 failed
[1]     [webkit] › packages/lexical-playground/tests/e2e/CopyAndPaste/html/HTMLCopyAndPaste.spec.mjs:195:3 › HTML CopyAndPaste › Copy + paste a paragraph element between horizontal rules
[1]     [webkit] › packages/lexical-playground/tests/e2e/HorizontalRule.spec.mjs:286:3 › HorizontalRule › Can copy and paste a horizontal rule

Hey @zurfyx sorry for the delay - tests were actually surfacing a likely unintended consequence of this update. I changed the logic to only use insertBefore if pasting only one node. Otherwise what you'd end up with out of order pasted contents. Let me know if that looks all right to you.

@zurfyx hey - would you be able to take another pass at this?

@zurfyx - is this something you're still willing to merge?


Fix couch_replicator_compact_test

This is a port of https://github.com/apache/couchdb/commit/aca6a459e454aa684cb864901899a3320a0c2480 to old replicator code

The build with this commit passes tests https://build2.cloudant.com/job/dbnext/6190/


Better handling of resource reconciliation errors

At present, the resource reconciliation logic is fairly straight forward in terms of its error handling. If we encounter any error whatsoever we return it immediately. However, this also has the effect of breaking the reconciliation cycle and blocking reconciliation of other resources that come later in the order. Not all resources created have equal importance and/or are worth blocking the reconciliation cycle for. We should consider which resources are critical for the functioning of the controller, and reserve returning errors only for situations where these resources produce some kind of failure
For instance, errors reconciling the metrics service should not block reconciliation of other resources
There could be further logic developed to fine tune how specific errors for specific resources should be handled (if not returned or ignored)

Closing as this appears not have any actionable items at this time. We should keep this is mind once the operator reconciliation logic becomes more complex!


Unable to use with GitHub Enterprise

I'm using hub with GHE and have the host and protocol set in the global git config.  But when I run the "hub pull-request" command I get the following:
Aborted: the origin remote doesn't point to a GitHub repository.

What's your git config --get-all hub.host?

$ git config --get-all hub.host
https://github.***.com

I also have this set:
$ git config --get-all hub.protocol
https

And does the origin remote point to github.whatever.com? Check with git remote -v

yes it does.  i do have two remotes though, origin points to that and upstream to something else.

@mislav any ideas?

Sorry for the late follow-up. If "upstream" remote is pointing to a non-GitHub instance, that might be what's tripping it up, because hub will prefer "upstream" remote over "origin" (this was an often-requested feature before). As a workaround you might want to consider renaming the "upstream" remote to something else, or specifying the pull-request base directly:
hub pull-request -b "<gh-username>:<branch-name>"

upstream also points to a non-github instance but it's the same GHE instance just a different fork.  i can try calling it something else and see how that works. more to follow.

Well, when I said "non-github instance" I meant a server that's not any version of GitHub, including GHE.
I don't know where the problem lies. The error message is certainly faulty, since both remotes point to some version of GitHub.

@hallem, is it possible that the explicit https:// prefix in your example is the problem?
(On my system it's just github.**.com with no prefix, and hub clone works fine.)

Could be private mode https://help.github.com/enterprise/2.0/admin/articles/private-mode/

I think @dlenski is right. Sorry for not catching that before.

Closing because I think the issue is what @dlenski described. The list in git config --get-all hub.host should be just hostnames without the protocol. Try that and please reopen if the issue persists.


Add minimumInputLength to Select2_ajax Filter

Hi guys, I believe this can be useful to someone.
PS Which one is better, minimumInputLength or minimum_input_length? I don't know if you prefer CamelCase or snake_case. The 2nd option would be better to mantain the same attribute name as in CRUD fields.

Hi @UgoRaffaele , I'm sorry nobody has taken a look at this so far - some things slip through the cracks. I agree it would be better for the select2, select2_multiple and select2_ajax filters to have a configurable minimum input length.
But I don't think this is the right implementation: not ALL filters need it (ex: simple, date, range, text), so I think it would be better if the feature was implemented in those particular filters , not in the CrudFilter object that all filters use.
The only say I see this possible right now is though a "preferences" array when calling addFilter(). That would require an optional fifth parameter to the ```addFilter() method, something like an array of preferences, that get placed on the object and can then be used inside the filter blade file.
Unfortunately I'll have to close this PR as it can't be merged as-is. I'll make a note of adding this feature in v4.
If you need this sooner than we can handle this (it's low priority for us, I'm afraid - currently focused on huge features for v4) and want to contribute with this, please make another PR.
The way I see it, we could even pass an entire select2 array, with a sensible default, say:
$this->crud->addFilter([ // select2 filter
  'name' => 'status',
  'type' => 'select2',
  'label'=> 'Status'
], function() {
    return [
            1 => 'In stock',
            2 => 'In provider stock',
            3 => 'Available upon ordering',
            4 => 'Not available',
            ];
}, function($value) { // if the filter is active
    // $this->crud->addClause('where', 'status', $value);
},
false, //fallback logic
[ // preferences
    'select2preferences' => [
       'allowClear' => true,
       'closeOnSelect' => false,
       'minimumInputLength' => 4
   ]
]);

That preferences array could be used instead in javascript if passed, if not, the default would be used:
                    $(obj).select2({
                    	allowClear: true,
    			closeOnSelect: false,
    			minimumInputLength: 2
                    });


232 preparing for inplace nlp

@jbcaillau For in-place code, I suggest adding unit tests with @allocated.
It's so easy to miss some allocations...
I recommend this kind of test: https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/main/test/test_allocations.jl#L37-L51
It guarantees that your code is in-place and that you won't introduce extra allocations in the future with new modifications.

@ocots more or less trivial changes to types / functions to include in_place definitions (constraints, dynamics, cost). everything kept for out_of_place to be still OK (ongoing test). please review the diff and tell me what you think.

@ocots more or less trivial changes to types / functions to include in_place definitions (constraints, dynamics, cost). everything kept for out_of_place to be still OK (ongoing test). please review the diff and tell me what you think.

[ ] need to check scalar case on in place with views

@amontoison another question about treating as uniformly as possible vectors and scalars, related to XXXXX: up to now we use .= to treat uniformly (length one) vectors and scalar, like in
julia> x = [0.]
1-element Vector{Float64}:
 0.0

julia> y = [1.]
1-element Vector{Float64}:
 1.0

julia> z = 2.
2.0

julia> x[:] .= y[1]
1-element view(::Vector{Float64}, :) with eltype Float64:
 1.0

julia> x[:] .= z[1]
1-element view(::Vector{Float64}, :) with eltype Float64:
 2.0

Introducing views to avoid copying the rhs is still OK with vectors, not with scalars:
julia> x[:] .= view(y, 1)
1-element view(::Vector{Float64}, :) with eltype Float64:
 1.0

julia> x[:] .= view(z, 1)
ERROR: MethodError: no method matching view(::Float64, ::Int64)

Of course, we can do sth like
julia> __view(x, rg) = (rg isa Integer) ? x[rg] : view(x, rg)
__view (generic function with 1 method)

julia> x[:] .= __view(y, 1)
1-element view(::Vector{Float64}, :) with eltype Float64:
 1.0

julia> x[:] .= __view(z, 1)
1-element view(::Vector{Float64}, :) with eltype Float64:
 2.0

but is it the best way?

@jbcaillau
I will probably use multiple dispatch so that the compiler knows the output type for each combination:
__view(x::Number, rg) = x
__view(x::AbstractVector, rg::Integer) = x[rg]
__view(x::AbstractVector, rg::UnitRange) = view(x, rg)

But it's quite cheap to use an array of length 1 instead of a scalar rhs, so it could be more efficient to a vector in all-cases such that the compiler can infer the type of each parameter and variable.
Instead of view, you could also use the 5-arguments version of copyto!:
A = zeros(10)
B = [i for i = 1:10]
start_A = 5
start_B = 3
N = 4
copyto!(A, start_A, B, start_B, N)

10-element Vector{Float64}:
 0.0
 0.0
 0.0
 0.0
 3.0
 4.0
 5.0
 6.0
 0.0
 0.0

@ocots @jbcaillau Before that I forgot, you are using quite often a foo::Union{Nothing, ...} inside your structures for the type of the attributes. The compiler doesn't like that and it leads to additional allocations because it needs to check at runtime that it's a Nothing or not.
You can change that for foo::T and at the top of your structure T <: Union{Nothing, ...}.

For all these kinds of stuff I used JET in the past and kept an example here.

@jbcaillau I will probably use multiple dispatch so that the compiler knows the output type for each combination:
__view(x::Number, rg) = x
__view(x::AbstractVector, rg::Integer) = x[rg]
__view(x::AbstractVector, rg::UnitRange) = view(x, rg)

Good point for multiple dispatch (instead of runtime if).

But it's quite cheap to use an array of length 1 instead of a scalar rhs, so it could be more efficient to a vector in all-cases such that the compiler can infer the type of each parameter and variable.

Sure. Actually, we want to allow the user to be able to use a scalar instead of a length one vector, as being compelled to write x[1] instead of x for a scalar would not be so nice.

Instead of view, you could also use the 5-arguments version of copyto!:
A = zeros(10)
B = [i for i = 1:10]
start_A = 5
start_B = 3
N = 4
copyto!(A, start_A, B, start_B, N)

10-element Vector{Float64}:
0.0
0.0
0.0
0.0
3.0
4.0
5.0
6.0
0.0
0.0

👍🏽 nice. I see it also works for scalar rhs. one con, though: in a high level language such as Julia, should be the compiler task to translate sth like x[…] = y[…] into an efficient copy.

@ocots @jbcaillau Before that I forgot, you are using quite often a foo::Union{Nothing, ...} inside your structures for the type of the attributes. The compiler doesn't like that and it leads to additional allocations because it needs to check at runtime that it's a Nothing or not. You can change that for foo::T and at the top of your structure T <: Union{Nothing, ...}.

@amontoison

these unions are with Nothing and various types (not a single one)
some fields might be nothing, some not

does your remark still apply?

@ocots @jbcaillau Before that I forgot, you are using quite often a foo::Union{Nothing, ...} inside your structures for the type of the attributes. The compiler doesn't like that and it leads to additional allocations because it needs to check at runtime that it's a Nothing or not. You can change that for foo::T and at the top of your structure T <: Union{Nothing, ...}.

@amontoison
* these unions are with `Nothing` and various types (not a single one)

* some fields might be `nothing`, some not

does your remark still apply?

Yes, you just need to parameterize your structures with the types
stuct OptControl{T1, T2, ..., TN}
field1::T1,
field2::Int64,
field3::T2,
field4::Float64,
...
fieldM::TN
end

You can still add restriction on Ti with Ti <: Union{...}.

👍🏽 nice. I see it also works for scalar rhs. one con, though: in a high level language such as Julia, should be the compiler task to translate sth like x[…] = y[…] into an efficient copy.

I agree with you but it's probably not that easy to implement.
For example, if two vectors x and y overlap in memory, you need to perform the copy in a certain order or allocate an additional internal buffer to ensure the result is correct.

👍🏽 nice. I see it also works for scalar rhs. one con, though: in a high level language such as Julia, should be the compiler task to translate sth like x[…] = y[…] into an efficient copy.

I agree with you but it's probably not that easy to implement. For example, if two vectors x and y overlap in memory, you need to perform the copy in a certain order or allocate an additional internal buffer to ensure the result is correct.

Right. Regarding copyto! the doc is clear about the semantics (= copy in increasing order). Would even be nicer to have a full BLAS 1 routine with increments for each array:
copyto!(A, start_A, inc_A, B, start_B, inc_B, N)

https://docs.julialang.org/en/v1/stdlib/LinearAlgebra/#LinearAlgebra.BLAS.blascopy!

It's blascopy!.

stride provided but no more starting index to cover general slices i:j:k. bref
julia> let x = zeros(2)
       y = ones(2)
       println(@allocated blascopy!(2, x, 1, y, 1))
       end
0

 julia> __view(x::Number, rg) = x[rg] # Throws an error for rg != 1
__view (generic function with 1 method)

julia> __view(x::AbstractVector, rg::Integer) = x[rg]
__view (generic function with 2 methods)

julia> __view(x::AbstractVector, rg::AbstractRange) = view(x, rg) # Allows StepRange
__view (generic function with 3 methods)

julia> x = 7.
7.0

julia> rg = 1
1

julia> __view(x, rg)
7.0

julia> __view(x, 2)
ERROR: BoundsError: attempt to access Float64 at index [2]
Stacktrace:
 [1] getindex
   @ ./number.jl:98 [inlined]
 [2] __view(x::Float64, rg::Int64)
   @ Main ./REPL[11]:1
 [3] top-level scope
   @ REPL[17]:1

julia> x = [1., 2., 3., 4.]
4-element Vector{Float64}:
 1.0
 2.0
 3.0
 4.0

julia> __view(x, 2)
2.0

julia> __view(x, 2:3)
2-element view(::Vector{Float64}, 2:3) with eltype Float64:
 2.0
 3.0

julia> __view(x, 1:2:3)
2-element view(::Vector{Float64}, 1:2:3) with eltype Float64:
 1.0
 3.0

julia> let x = zeros(4)
       y = 1.
       println(@allocated x[1:1] .= __view(y, 1))
       println(x)
       end
0
[1.0, 0.0, 0.0, 0.0]

julia> let x = zeros(4)
       y = ones(4)
       println(@allocated x[1:2] .= __view(y, 2:3))
       println(x)
       end
0
[1.0, 1.0, 0.0, 0.0]

julia> let x = zeros(4)
       y = ones(4)
       println(@allocated x[1:2] .= __view(y, 1:2:3))
       println(x)
       end
0
[1.0, 1.0, 0.0, 0.0]

@amontoison

check Base.maybeview
that is involved in @views

julia> let x = zeros(4)
                     println(@allocated x[1:2] = cos.(x[3:4].^2) .+ x[1])
                     end
176

julia> let x = zeros(4)
                     println(@allocated @views x[1:2] = cos.(x[3:4].^2) .+ x[1])
                     end
96

julia> let x = zeros(4)
                     println(@allocated x[1:2] .= cos.(x[3:4].^2) .+ x[1])
                     end
80

julia> let x = zeros(4)
                     println(@allocated @views x[1:2] .= cos.(x[3:4].^2) .+ x[1])
                     end
0

let x = zeros(4)
                     println(@allocated @views x[1:2] .= cos.(x[2:3].^2) .+ x[1]) # Overlap
                     end
80

julia> let x = zeros(4)
                     println(@allocated copyto!(x, 1, cos.(x[3:4].^2) .+ x[1], 1, 2))
                     end
176

julia> let x = zeros(4)
                     println(@allocated copyto!(x, 1, cos.(x[2:3].^2) .+ x[1], 1, 2)) # Overlap
                     end
176

julia> let x = zeros(4)
                     println(@allocated @views copyto!(x, 1, cos.(x[3:4].^2) .+ x[1], 1, 2))
                     end
96

julia> let x = zeros(4)
                     println(@allocated @views copyto!(x, 1, cos.(x[2:3].^2) .+ x[1], 1, 2)) # Overlap
                     end
96

@PierreMartinon please review before merging and testing in CTDirect.jl with updated nlp_constraints!

[ ] @jbcaillau check to use (for generated code in onepass, for in place functions in tests, as in test_model...) .= with views, e.g.

(r, x) -> (@views r[:] .= u * cos.(x[1:2]); nothing)


Add Test Coverage

Now that we are getting external contributions, I think it would be beneficial to have some sort of code coverage report in the prs.  @changusmc & @wclausen do you have any thoughts on what we should use?

Would you also be open to migrating to a more modern assertion library like truth or kluent?

Now that we are getting external contributions, I think it would be beneficial to have some sort of code coverage report in the prs. @changusmc & @wclausen do you have any thoughts on what we should use?

There's two parts to this. (1) Generate the coverage data, for Java and Kotlin, we'd likely have to use Jacoco. I don't know of any other tools that get coverage for Java/Kotlin. (2) Surface the coverage data and enforce coverage on new PRs, some popular tools for this is Coveralls, Codecov, Codacy, all free for open source, but we'll have to get dev-infra to install it for the Dropbox org. That would probably require a software request internally.

@ychescale9 sure! We use truth internally.  I'll make a different issue for tracking

some popular tools for this is Coveralls, Codecov, Codacy, all free for open source, but we'll have to get dev-infra to install it for the Dropbox org. That would probably require a software request internally.

I have no strong preference among those. They all seem good/easy to use. I'd go with codecov as their browser extension that shows what lines are covered vs not seems pretty nifty.

Reached out to infra. Let's see what we have available internally

In the meantime, I will be starting to implement Jacoco. Then we can jump onto the second part when the internal process is done.

Now that we are getting external contributions, I think it would be beneficial to have some sort of code coverage report in the prs. @changusmc & @wclausen do you have any thoughts on what we should use?

There's two parts to this. (1) Generate the coverage data, for Java and Kotlin, we'd likely have to use Jacoco. I don't know of any other tools that get coverage for Java/Kotlin. (2) Surface the coverage data and enforce coverage on new PRs, some popular tools for this is Coveralls, Codecov, Codacy, all free for open source, but we'll have to get dev-infra to install it for the Dropbox org. That would probably require a software request internally.

If you can get the merged coverage.xml and coverage.ec, that would be great
and can support any solution we move forward with. Thanks!
On Mon, Dec 16, 2019 at 12:58 PM Burak Eregar<EMAIL_ADDRESS>wrote:

In the meantime, I will be starting to implement Jacoco. Then we can jump
onto the second part when the internal process is done.
Now that we are getting external contributions, I think it would be
beneficial to have some sort of code coverage report in the prs.
@changusmc https://github.com/changusmc & @wclausen
https://github.com/wclausen do you have any thoughts on what we should
use?
There's two parts to this. (1) Generate the coverage data, for Java and
Kotlin, we'd likely have to use Jacoco. I don't know of any other tools
that get coverage for Java/Kotlin. (2) Surface the coverage data and
enforce coverage on new PRs, some popular tools for this is Coveralls,
Codecov, Codacy, all free for open source, but we'll have to get dev-infra
to install it for the Dropbox org. That would probably require a software
request internally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dropbox/Store/issues/19?email_source=notifications&email_token=ACCPWM5T2WK4NLMCGW7AKEDQY7TWLA5CNFSM4JZHLGZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHACGQI#issuecomment-566240065,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCPWM33JFH77OK7UVFISUTQY7TWLANCNFSM4JZHLGZQ
.


convertedData is undefined after finishConvert

Description
Hi!
Using ts-embl plugin I get convertedData object as undefined when finishConvert is triggered.
Steps to reproduce
In a React component:

import videojs, videojs-record and ts-enml as follows

let videojs

if (!process.env.TESTING) {
  import('video.js')
    .then((mod) => {
      videojs = mod.default
    })
    .catch((error) => {
      throw new Error(`Dynamic page loading failed: ${error}`)
    })
  import('videojs-record/dist/videojs.record.js').catch((error) => {
    throw new Error(`Dynamic page loading failed: ${error}`)
  })
  import('videojs-record/dist/plugins/videojs.record.ts-ebml.js').catch((error) => {
    throw new Error(`Dynamic page loading failed: ${error}`)
  })
}

set options as

this.playerOptions = {
  controls: true,
  fluid: false,
  plugins: {
    record: {
      audio: true,
      video: {
        // video constraints: set resolution of camera
        mandatory: {
          minWidth: 1280,
          minHeight: 720
        }
      },
      videoMimeType: "video/webm;codecs=h264",
      maxLength: this.props.maxLength,
      convertEngine: "ts-ebml",
      debug: true
    }
  },
  controlBar: {
    fullscreenToggle: false
  }
}

Load the player

this.player = videojs(this.videoNode, this.playerOptions, () => {
  // print version information at startup
  var msg =
    "Using video.js " +
    videojs.VERSION +
    " with videojs-record " +
    videojs.getPluginVersion("record") +
    " and recordrtc " +
    RecordRTC.version;
  videojs.log("log", msg);
})

Record a video
Listen to finishConvert action

this.player.on('finishConvert', function() {
 console.log('finished converting: ', this.player.convertedData)
})

Results
this.player.convertedData is returned undefined
Expected
this.player.convertedData should return a blob containing the converted video with metadata included
Error output
No error output
versions
video.js 7.5.5 with videojs-record 3.7.1 and recordrtc 5.5.4 on Google Chrome 75.0.3770.100

@soulpaul does the online example work for you? https://collab-project.github.io/videojs-record/examples/video-only-ebml.html

@thijstriemstra the online example works for me.
I tried to record video-only in my implementation but it does not work as well. Any idea on what I could be doing wrong?

The videoMimeType you specify cannot be used, see https://developer.mozilla.org/en-US/docs/Web/API/MediaRecorder/isTypeSupported#Example
On Firefox 67:
Is video/webm supported? Maybe!
Is audio/webm supported? Maybe!
Is video/webm;codecs=vp8 supported? Maybe!
Is video/webm;codecs=daala supported? Nope :(
Is video/webm;codecs=h264 supported? Nope :(
Is audio/webm;codecs=opus supported? Maybe!
Is video/mpeg supported? Nope :(

But more importantly, your finishConvert method uses the wrong scope. Use arrow function instead, otherwise reference to this.player can't be made.
this.player.on('finishConvert', () => {
 console.log('finished converting: ', this.player.convertedData)
})


Fixes for PR #799

Support multiple &xs= params in parallel
Fail on 'error' 'warning' events

@Sebmaster Can you please review this PR when you get the chance?

LGTM otherwise.


Video in Read Me is Private

https://www.youtube.com/watch?v=Jiz_gzM_4Y4

That was the old video. I fixed the link.
Thanks for pointing it out!


Showcase Submission for 46-asteroids

Thank you Jeff Owens for your contribution! A member of the Coding Train team will review it shortly.

Challenging Asteroids Challenge
Jeff Owens

Yay, this is terrific!


net.sourceforge.cobertura.javancss.parser.ParseException

During our cobertura builds, in a couple of places we get a net.sourceforge.cobertura.javancss.parser.ParseException.  We should figure this out and fix.

This is not causing the builds to fail AFAIK.  And is really a bug with cobertura.  We should report it to them to get a fix in.

We are not using Cobertura anymore.


Fix travis to not cleanup when publishing rswag-ui

This is to keep node_modules directory. Fixes #124

Awesome! Thx - just published in version 2.0.3 if you want to check it out

Works for me! Thanks!


fix typo

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@kpraxor : Thanks for your contribution to the Azure documentation! The author, @azdocprs, has been notified to review your proposed change.

@cherylmc Please review these proposed changes. Thanks.

Looks good. Thanks for catching that @kpraxor. #sign-off


Adding Docker image and update documentation

I've also add in last commit, modbus script provided and create a container for this.
I've updated code to quickly deploy. All works but please review it.

Yes. My bad. Only generate arm64 build. Now it's better

Can you try if now it's work with command defined in README ?

I like your work, you are free to put it your repository.
I' d like to leave here open the way how to send ModbusTCP commands to vsPLC.


Don't auto-install lefthook if not found

Closes # (issue)

:zap: Summary

As-is, if lefthook is not found, it will auto-install the latest lefthook from npm. (npx auto-fetches by default)
This isn't great:

Security: npm isn't known for being the most secure platform, and if the package was the target of an attack, all lefthook users with node installed would be affected, even those who don't use the lefthook npm package.

User friendliness: installing binaries on the user's computer without their permission isn't great, and one of those lefthook binaries (an .exe file) was flagged by an anti-malware package at my organization.

It seems that the intention was to just print a message when lefthook is not found (which I agree with) and it's possible that using npx's fetch-if-not-installed behaviour was just an oversight when implementing this. That said, anyone who has node installed will not get that far, and will be subject to the auto-install behaviour.
:ballot_box_with_check: Checklist

[ ] Check locally
[ ] Add tests
[ ] Add documentation

Relates to discussion: https://github.com/evilmartians/lefthook/discussions/599


Documentation could be clearer about where noTLSVerify option can be used

Expected Behavior
https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/configuration/configuration-file/ingress#noTLSVerify
Simply says you can have an option called noTLSVerify, doesn't say where it can be placed.
Actual Behavior
Googling has lots of people saying to use no-tls-verify, which is wrong. I tried 10 different combinations, each of which was silently ignored, before finding https://github.com/cloudflare/cloudflared/issues/277 .
Section that requires update
https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/configuration/configuration-file/ingress
Additional information
Perhaps an example with all options? Or each option could have a breakdown of which parts of the yaml structure they would be valid in?

(It says "inside of an ingress rule" - not "inside the originRequest part of an ingress rule". I'm not sure if the latter is correct though?)

hey @kierenj thanks so much for flagging. we've now added more details about the originRequest rule being necessary for properties such as noTLSVerify, and added further explanations on the example config file we provide https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/configuration/configuration-file/ingress#origin-configuration
Hope this helps!


Add Share Scene to APCOnboardingManager

Adding the share scene references back in that were lost in APCOnboardingManager refactor + merge.

r=me


Use gtoolkit_bridge PyPI package when running the Python Bridge from GT

https://pypi.org/project/gtoolkit_bridge/ is now used in the new PythonBridge setup (using PBNewPharoPlatform and PBNewPharoPipenvProcess)

Done


Release 6.0.0

Coverage remained the same at 99.815% when pulling f652493ecf32e457bf4b4304a68ac5c532d717fd on release_6.0.0 into a587a61271d581a1836c845bad23863df21a2f2b on master.

Coverage remained the same at 99.815% when pulling f652493ecf32e457bf4b4304a68ac5c532d717fd on release_6.0.0 into a587a61271d581a1836c845bad23863df21a2f2b on master.


Consume mode doesn't seem to work in a Neo4j Cluster

Guidelines
Please note that GitHub issues are only meant for bug reports/feature requests. If you have questions on how to use Streams, please ask on StackOverflow instead of creating an issue here.
Expected Behavior (Mandatory)
The cores in the causal cluster pick up messages from a topic queue and which ever is the leader will apply the writes
Actual Behavior (Mandatory)
Nothing is happening. No acknowledgement or errors are being thrown when a new event is added to a topic
How to Reproduce the Problem
Follow instructions for setting up a local cluster: https://neo4j.com/docs/operations-manual/3.5/tutorial/local-causal-cluster/
Prior to starting the cluster, use the following config:
kafka.zookeeper.connect=localhost:2181
kafka.bootstrap.servers=localhost:9092
streams.sink.enabled=true
streams.sink.topic.cypher.neorr=WITH event.payload as payload MATCH (p:Person) WHERE ID(p)=payload[0] SET p.pagerank = payload[1]
Set up a separate instance with the same db with Kafka configured for procedures
Simple Dataset (where it's possibile)
Use the movie db from :play guide
//Insert here a set of Cypher statements that helps us to reproduce the problem
//Run on non cluster instance
CALL algo.pageRank.stream('Person', 'DIRECTED', {iterations:20, dampingFactor:0.85})
YIELD nodeId, score
WITH  [nodeId,score] as res
CALL streams.publish('neorr',res)
RETURN count(*)

Steps (Mandatory)
As above
1.
1.
1.
Screenshots (where it's possibile)
Specifications (Mandatory)
Currently used versions
Versions

OS: Windows
Neo4j: 3.4.1
Neo4j-Streams: 3.4.0

@lju-lazarevic is that about what we talked about on Slack?

Hi Andrea, yes it is - let me delete it!
On Fri, Dec 21, 2018 at 3:31 PM Andrea Santurbano<EMAIL_ADDRESS>wrote:

@lju-lazarevic https://github.com/lju-lazarevic is that about what we
talked about on Slack?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/neo4j-contrib/neo4j-streams/issues/107#issuecomment-449418518,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdPoXTP2uMPUXC-BuVcPWEZwdCw0AvvWks5u7P7WgaJpZM4ZcVpi
.

--
Ljubica Lazarevic
Field Engineering
<EMAIL_ADDRESS>Tel: +44 (0)7745 126 478

On no problem I'll close this! Thanks a lot for the feedback!


Confirm on delete

it's easy to accidentally hit delete with it between the edit/close button, and lose the record
add a confirmation to it

Still need to add on strats, skill, and employees


Add ability to issue service calls from entity references

Currently, services can only be called via the hass.call interface. Digging into the full range of services that can be called with an entity is a bit of a search. That information should be accessible directly from the entity references
function MyService({ hass }: TServiceParams) {
  const sensor = hass.entity.byId("sensor.example_sensor");
  const mySwitch = hass.entity.byId("switch.example_switch");

  sensor.onUpdate(async () => {
    mySwitch.switch.turn_on();
  })
}

Format: {entity}.{domain}.{service}
For any service that takes in an entity reference, and this entity can be used.

@zoe-codez any reason not to do {entity}.{service}? are their entities with more than one domain?

That'd work for when domain matches entity domain, as a shorthand. That part of the note was written with the intent of covering service calls that are of different domains

Closing this as mvp complete. Might open a new ticket if the lack of secondary domains ever bothers me


Updated documentation - Added missing newline which prevented code block from showing.

I'm really sorry, my last PR broke the code block!
Sometimes newlines are important :sweat_smile:
I didn't even think to view it, since it looked like such a simple update. Lesson learnt, code always breaks lol.
The code block for the section "Updating Controls" doesn't show.
https://github.com/elParaguayo/qtile-extras/blob/main/docs/manual/how_to/popup.rst#updating-controls
And now it does show.
https://github.com/sslater11/qtile-extras/blob/documentation/docs/manual/how_to/popup.rst#updating-controls

No problem at all. Thanks for the fix.


Add useSetImmerAtom hook

Adds a hook that returns a setState immer-style function only.
Updates the jotai peer dep to >=2.0.0.
There is also a change in the signature of the useImmerAtom hook, which makes it type-incompatible for users of jotai v1.

Would you like to add/update the test cases too?

A test, an example, and an export from index.ts added.

Thanks for the library!

It's not merged yet.

@idrm Would you be willing to keep maintaining this library?

@dai-shi I'm not sure I'm qualified enough to take on the role (my experience with jotai, immer, and jotai-immer is only a few days old). I'd gladly sign up to be notified of new issues and PRs, and try to contribute when I can.

sounds good. feel free to let me know when you are confident to become a maintainer. for now, I don't think anybody is actively maintaining this repo.


PR: Change default format in array editor to ''

Description of Changes
Before, the default format in the array editor for non-numeric arrays was set to 's'. This meant that ArrayModel.data() returned a value of type numpy.str_ for string arrays instead of a value of type str. The consequence was that the contents of the array were not shown.
This PR changes the default format to '' to fix this. It also adds a regression test.

[x] Wrote at least one-line docstrings (for any new functions)
[x] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #22466
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Jitse Niesen

@meeseeksdev please backport to 6.x


[frontend] Refactor page/form components with Relay fragments

Specify Relay data requirements for a components (create/update forms) with fragments.
Fetch for latest entity data on view/update pages before rendering form.
Use locally cached list of entity data on list pages (if present) on first page render and fetch for latest data meanwhile.
Refactor queries on create/update pages to fetch entity data and form options in one query.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Fix LessonCode UI bug

Codecov Report

Merging #243 (d6af914) into master (c8fa9b0) will increase coverage by 0.37%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #243      +/-   ##
============================================
+ Coverage     77.01%   77.39%   +0.37%
- Complexity      699      718      +19
============================================
  Files            97       97
  Lines          2219     2287      +68
  Branches        274      287      +13
============================================
+ Hits           1709     1770      +61
- Misses          412      413       +1
- Partials         98      104       +6

Impacted Files
Coverage Δ

...in/java/seedu/address/model/person/ModuleCode.java
62.50% <0.00%> (-32.74%)
:arrow_down:

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...ulelesson/ModuleCodeContainsKeywordsPredicate.java
86.66% <0.00%> (+0.95%)
:arrow_up:

...commands/modulelesson/EditModuleLessonCommand.java
92.43% <0.00%> (+1.00%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
98.59% <0.00%> (+2.81%)
:arrow_up:

...seedu/address/model/modulelesson/ModuleLesson.java
77.55% <0.00%> (+4.08%)
:arrow_up:

src/main/java/seedu/address/model/Conthacks.java
93.75% <0.00%> (+4.16%)
:arrow_up:

...ess/model/modulelesson/UniqueModuleLessonList.java
87.23% <0.00%> (+4.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8fa9b0...d6af914. Read the comment docs.


Add OCR to windows search indexer (to index Images/videos text contents too).

Description of the new feature / enhancement
Add OCR engine to windows search indexer (let it run with ultra low priority). This will allow us to search within image/video text which is a very useful feature.
This feature was working fine before with Windows 10 (if files are in OneDrive). I guess the indexing was happening in online in OneDrive and windows search was retrieving the results from there. However now, even that is broken🤦🏻♂
Scenario when this would be used?
We always take pictures of business cards, info sheets, receipts, and other documents that we would like to directly pull out by searching within its content.
Supporting information
No response

xref #4371


Add autocompletions for Wrangler commands

For instance, typing wrangler p and then pressing tab should give a list like
publish      -- 🆙  Publish your worker to the orange cloud
preview      -- 🔬  Preview your code temporarily on cloudflareworkers.com

This could be done by providing a script to include in .bashrc or .zshrc, but it would be awesome if we could distribute the autocompletion along with the tool itself. That might be something to upstream into clap-rs.
EDIT: Looks like clap supports this

I'll take a look at this issue

I am having issues with creating App at build time and I think it would be best if this is held off until we upgrade to clap_v3.


Caustics are not visible under refractive object (can't see trough other transparent object)

Caustics are not visible (when there is refractive object over caustics) unless  shader has opacity on (smaller than -1.0) or architectural glass set on.
Here is the problem/limitation/bug demonstrated with video:
https://youtu.be/n2hduvre7No
can this be solved in future?

They are called SDS (Specular-Diffuse-Specular) paths and they require a very specific algorithm to be able to render them. You need to enable caustic cache to be able to see them.


Is it enabled for my sub?

Hi - Do I have to be on a whitelist to try this feature? Is it available in all regions?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 75687a2c-c9e0-262f-197b-4b88b8e6d27d
Version Independent ID: 58bd1e87-6399-d276-7258-b5022d1019a8
Content: Monitor Azure Storage services with Azure Monitor for Storage (preview) - Azure Monitor
Content Source: articles/azure-monitor/insights/storage-insights-overview.md
Service: azure-monitor
Sub-service: ****
GitHub Login: @bwren
Microsoft Alias: bwren

@Chai-NED Thank you for your query, we will look into this and get back to you at the earliest.

@Chai-NED Thank you for reaching out to us, i am checking with our internal team on this will update the thread accordingly.

@Chai-NED Quick update on this, Azure Monitor for Storage is in Public Preview and slated for GA in near future. Currently it does not require any boarding and it is Out of box available to all Azure customers.  Please let us know if you have any additional queries on this. Thank you.
Hope the above information helps. At this point it appears that there's no further edits or updates needed to the documentation. We will go ahead and close this issue, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you