[SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression.

What changes were proposed in this pull request?
The filter predicate for aggregate expression is an ANSI SQL.
<aggregate function> ::=
COUNT <left paren> <asterisk> <right paren> [ <filter clause> ]
| <general set function> [ <filter clause> ]
| <binary set function> [ <filter clause> ]
| <ordered set function> [ <filter clause> ]
| <array aggregate function> [ <filter clause> ]
| <row pattern count function> [ <filter clause> ]

There are some mainstream database support this syntax.
PostgreSQL:
https://www.postgresql.org/docs/current/sql-expressions.html#SYNTAX-AGGREGATES
For example:
SELECT
  year,
  count(*) FILTER (WHERE gdp_per_capita >= 40000)
FROM
  countries
GROUP BY
  year

SELECT
  year,
  code,
  gdp_per_capita,
  count(*)
    FILTER (WHERE gdp_per_capita >= 40000)
    OVER   (PARTITION BY year)
FROM
  countries

jOOQ:
https://blog.jooq.org/2014/12/30/the-awesome-postgresql-9-4-sql2003-filter-clause-for-aggregate-functions/
Notice:
This PR only support filter predicate without codegen. I will create another PR to support codegen.

Add new SQL feature.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Exists UT and new UT.

cc @gatorsmile

Test build #113365 has started for PR 26420 at commit d521be1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18263/
Test PASSed.

Test build #113365 has finished for PR 26420 at commit d521be1.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113365/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18268/
Test PASSed.

Test build #113370 has started for PR 26420 at commit d521be1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18270/
Test PASSed.

Test build #113370 has finished for PR 26420 at commit d521be1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113370/
Test PASSed.

cc @cloud-fan @rednaxelafx @maropu

I just looked over the current implementation though, I have one question; have you checked that we couldn't just transform this filter exprs into the Spark existing exprs/operators instead of the current approach (hard-coded in each Agg operators)?

This is a nice feature! I'd like to know how it's implemented. Seems like we can't transform it into another logical form that we support, and we need to adjust our backend engine.

I just thought a super simple case like this;
postgres=# select * from t;
 k | v1 | v2
---+----+----
 1 |  2 |  3
 1 |  4 |  5
 1 |    |  9
 2 |  3 |
 2 |  5 |  8
(5 rows)

postgres=# select k, sum(v1) filter (where v1 > 2), avg(v2) filter (where v2 < 6) from t group by k;
 k | sum |        avg
---+-----+--------------------
 2 |   8 |
 1 |   4 | 4.0000000000000000
(2 rows)

The query above might be transformed into...
scala> sql("select k, sum(v1), avg(v2) from (select k, if(v1 > 2, v1, null) v1, if(v2 < 6, v2, null) v2 from t) group by k").show()
+---+-------+-------+
|  k|sum(v1)|avg(v2)|
+---+-------+-------+
|  1|      4|    4.0|
|  2|      8|   null|
+---+-------+-------+

@maropu looks like a good idea. But we need to make sure the aggregate function ignore nulls. may not work for count(*) filter (where a > 1)

Ur, I see.... nice suggestion. I need more time to think about how to implement.

@maropu
You said：
I just looked over the current implementation though, I have one question; have you checked that we couldn't just transform this filter exprs into the Spark existing exprs/operators instead of the current approach (hard-coded in each Agg operators)?
I don't understand very well.

I meant we might not need to modify the physical plans for aggregates (e.g., HashAggregateExec). Instead, in the analyzer phase, we might be able to transform filter expressions into projections as shown above;
// For the query "select k, sum(v1) filter (where v1 > 2), avg(v2) filter (where v2 < 6) from t group by k"
scala> sql("select k, sum(v1), avg(v2) from (select k, if(v1 > 2, v1, null) v1, if(v2 < 6, v2, null) v2 from t) group by k").show()
+---+-------+-------+
|  k|sum(v1)|avg(v2)|
+---+-------+-------+
|  1|      4|    4.0|
|  2|      8|   null|
+---+-------+-------+

scala> sql("select k, sum(v1), avg(v2) from (select k, if(v1 > 2, v1, null) v1, if(v2 < 6, v2, null) v2 from t) group by k").explain(true)
== Parsed Logical Plan ==
'Aggregate ['k], ['k, unresolvedalias('sum('v1), None), unresolvedalias('avg('v2), None)]
+- 'SubqueryAlias `__auto_generated_subquery_name`
   +- 'Project ['k, 'if(('v1 > 2), 'v1, null) AS v1#190, 'if(('v2 < 6), 'v2, null) AS v2#191]
      +- 'UnresolvedRelation [t]

== Analyzed Logical Plan ==
k: int, sum(v1): bigint, avg(v2): double
Aggregate [k#127], [k#127, sum(cast(v1#190 as bigint)) AS sum(v1)#194L, avg(cast(v2#191 as bigint)) AS avg(v2)#195]
+- SubqueryAlias `__auto_generated_subquery_name`
   +- Project [k#127, if ((v1#128 > 2)) v1#128 else cast(null as int) AS v1#190, if ((v2#129 < 6)) v2#129 else cast(null as int) AS v2#191]
      +- SubqueryAlias `default`.`t`
         +- Relation[k#127,v1#128,v2#129] parquet

== Optimized Logical Plan ==
Aggregate [k#127], [k#127, sum(cast(v1#190 as bigint)) AS sum(v1)#194L, avg(cast(v2#191 as bigint)) AS avg(v2)#195]
+- Project [k#127, if ((v1#128 > 2)) v1#128 else null AS v1#190, if ((v2#129 < 6)) v2#129 else null AS v2#191]
   +- Relation[k#127,v1#128,v2#129] parquet

== Physical Plan ==
*(2) HashAggregate(keys=[k#127], functions=[sum(cast(v1#190 as bigint)), avg(cast(v2#191 as bigint))], output=[k#127, sum(v1)#194L, avg(v2)#195])
+- Exchange hashpartitioning(k#127, 200), true, [id=#320]
   +- *(1) HashAggregate(keys=[k#127], functions=[partial_sum(cast(v1#190 as bigint)), partial_avg(cast(v2#191 as bigint))], output=[k#127, sum#202L, sum#203, count#204L])
      +- *(1) Project [k#127, if ((v1#128 > 2)) v1#128 else null AS v1#190, if ((v2#129 < 6)) v2#129 else null AS v2#191]
         +- *(1) ColumnarToRow
            +- FileScan parquet default.t[k#127,v1#128,v2#129] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex[file:/Users/maropu/Repositories/spark/spark-master/spark-warehouse/t], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<k:int,v1:int,v2:int>

@maropu This is a good idea. As cloud-fan said how to treat count. In addition to count, there are other situations here. Such as: percentile, percentile_approx, approx_count_distinct and so on.

Test build #113566 has started for PR 26420 at commit f32ac4d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18454/
Test PASSed.

I'd like to propose a solution for the codegen part that'll augment this PR. The overall direction this PR is taking sounds good to me, although I haven't reviewed the full details yet (would like to do that some time this week).
I'll prepare a separate PR for demo purposes to show how it'll augment the codegen part. It's actually fairly easy and could also serve as a bit of code clean up for a lot of the declarative aggregate functions.
The tl;dr is that I'd like to have explicit support for the user-specified filter clause in the infrastructure, instead of solely relying on a rewrite.
A lot of aggregate functions are null-skipping by nature, e.g. count(), sum(), avg() etc. But that's not a property common to ALL possible aggregate functions, and some of them have interesting semantics like first()/ last() where you can configure whether or not you want to include the nulls as the result, or skip them and only take the non-null values.
Having explicit support for the filter clause in the infrastructure ensures that we can properly support this feature, without having to rely on logical rewrite that might work for most aggregate functions and then a handful of exception cases have to be implemented in really ugly ways.

Test build #113566 has finished for PR 26420 at commit f32ac4d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113566/
Test FAILed.

Test build #113584 has started for PR 26420 at commit 9ea4736.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18470/
Test PASSed.

Test build #113584 has finished for PR 26420 at commit 9ea4736.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113584/
Test PASSed.

This is a nice feature! I'd like to know how it's implemented. Seems like we can't transform it into another logical form that we support, and we need to adjust our backend engine.

I think so.

This case?
//PgSQL
postgres=# select * from t;
 k | v1 | v2
---+----+----
 1 |  1 |  1
 2 |  2 |  2
(2 rows)

postgres=# select k, sum(v1) filter (where v1 > (select 1)), avg(v2) from t group by k;
 k | sum |          avg
---+-----+------------------------
 2 |   2 |     2.0000000000000000
 1 |     | 1.00000000000000000000
(2 rows)

// This pr
scala> sql("select k, sum(v1) filter (where v1 > (select 1)), avg(v2) from t group by k").show()
19/11/14 16:48:15 ERROR Executor: Exception in task 1.0 in stage 13.0 (TID 207)
java.io.InvalidClassException: org.apache.spark.sql.catalyst.expressions.ScalarSubquery; no valid constructor
	at java.io.ObjectStreamClass$ExceptionInfo.newInvalidClassException(ObjectStreamClass.java:169)
	at java.io.ObjectStreamClass.checkDeserialize(ObjectStreamClass.java:874)
	at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2043)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1573)
	at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2287)
	at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2211)
	at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2069)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream

I personally think we consider more about the exact BNF grammar for aggregate filters that we will support in this pr.

Test build #113872 has started for PR 26420 at commit 4dcd0d3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18740/
Test PASSed.

Test build #113872 has finished for PR 26420 at commit 4dcd0d3.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113872/
Test FAILed.

Test build #113874 has started for PR 26420 at commit 060d3d4.

Test build #113874 has finished for PR 26420 at commit 060d3d4.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113874/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18743/
Test PASSed.

Test build #113877 has started for PR 26420 at commit 4443883.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18745/
Test PASSed.

Test build #113877 has finished for PR 26420 at commit 4443883.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113877/
Test FAILed.

Test build #113878 has started for PR 26420 at commit 8beff8a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18746/
Test PASSed.

Test build #113878 has finished for PR 26420 at commit 8beff8a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113878/
Test FAILed.

Test build #113978 has started for PR 26420 at commit 4d0c3aa.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18843/
Test PASSed.

Test build #113978 has finished for PR 26420 at commit 4d0c3aa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113978/
Test FAILed.

@maropu Do you know how to fix the fails of Spark unit tests. It seems the filter predicate for aggregate expression and the array function named 'filter' have conflicts.

Test build #114010 has started for PR 26420 at commit 14f2b21.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18872/
Test PASSed.

Test build #114010 has finished for PR 26420 at commit 14f2b21.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114010/
Test FAILed.

Test build #114043 has started for PR 26420 at commit 895f6ac.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18904/
Test PASSed.

Test build #114043 has finished for PR 26420 at commit 895f6ac.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114043/
Test PASSed.

Test build #114147 has started for PR 26420 at commit b677268.

@maropu Filter predicate has supported sub query .

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19006/
Test PASSed.

Test build #114147 has finished for PR 26420 at commit b677268.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114147/
Test FAILed.

Test build #114161 has started for PR 26420 at commit 4c644ca.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19016/
Test PASSed.

Test build #114161 has finished for PR 26420 at commit 4c644ca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114161/
Test PASSed.

Test build #114188 has started for PR 26420 at commit 255650a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19039/
Test PASSed.

Test build #114188 has finished for PR 26420 at commit 255650a.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
      class SpecificPredicate extends $
case class ArraySort(
case class TypeOf(child: Expression) extends UnaryExpression
abstract class BasePredicate
case class RenameTableStatement(
case class AlterNamespaceSetLocationStatement(
case class RenameTable(
case class LocalShuffleReaderExec(
case class RenameTableExec(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114188/
Test FAILed.

Test build #114200 has started for PR 26420 at commit 518aa4f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19051/
Test PASSed.

Test build #114200 has finished for PR 26420 at commit 518aa4f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114200/
Test FAILed.

Retest this please

Test build #114220 has started for PR 26420 at commit 518aa4f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19070/
Test PASSed.

Test build #114220 has finished for PR 26420 at commit 518aa4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114220/
Test PASSed.

@cloud-fan @maropu Could you continue to review this PR?

Test build #114312 has started for PR 26420 at commit 92330b1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19152/
Test PASSed.

Test build #114313 has started for PR 26420 at commit 6e2e2b7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19153/
Test PASSed.

Test build #114314 has started for PR 26420 at commit 244adc6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19154/
Test PASSed.

Test build #114314 has finished for PR 26420 at commit 244adc6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114314/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19155/
Test PASSed.

Test build #114315 has started for PR 26420 at commit ba14173.

Test build #114313 has finished for PR 26420 at commit 6e2e2b7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114313/
Test FAILed.

Test build #114315 has finished for PR 26420 at commit ba14173.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114315/
Test FAILed.

Can you check the BNF grammar for  <filter clause> defined in the ANSI/SQL standard?

Test build #114312 has finished for PR 26420 at commit 92330b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114312/
Test PASSed.

@beliefer Why did you close this?

@maropu I made a mistake and got rid of the branch information. Thank you, I will create another fork branch and another PR.


Create a simple card component in React that displays a random image

Issue #171

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Use CSS variables (and increase contrast)

changed too much to merge...
I updated color and you can take a look, it is readability now ?


Initramfs improvements

Motivation for this change
Fixes #55523
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via nixos/tests/boot.nix attr biosUsb (probably needs some more :slightly_smiling_face: )
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test boot


(Edit)Added SortCommandParserTest.Updated UserGuide

sort command parser test added

Codecov Report

Merging #93 (f3e5c1b) into master (53e2e44) will increase coverage by 1.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
+ Coverage     67.85%   69.26%   +1.41%
- Complexity      430      452      +22
============================================
  Files            79       79
  Lines          1406     1422      +16
  Branches        149      151       +2
============================================
+ Hits            954      985      +31
+ Misses          413      397      -16
- Partials         39       40       +1

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...ava/seedu/address/logic/commands/ClearCommand.java
33.33% <0.00%> (ø)

.../java/seedu/address/model/applicant/Applicant.java
75.80% <0.00%> (+3.22%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
97.82% <0.00%> (+10.86%)
:arrow_up:

...edu/address/model/applicant/ApplicationStatus.java
89.47% <0.00%> (+15.78%)
:arrow_up:

...java/seedu/address/logic/commands/SortCommand.java
30.00% <0.00%> (+30.00%)
:arrow_up:

...va/seedu/address/logic/commands/RemoveCommand.java
31.25% <0.00%> (+31.25%)
:arrow_up:

.../seedu/address/logic/parser/SortCommandParser.java
100.00% <0.00%> (+100.00%)
:arrow_up:

...eedu/address/logic/parser/RemoveCommandParser.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I added remove in the user guide as well as updated the table of the user guide

Added sort in user guide. Edited filter as discussed(filter [as/APPLICATIONSTATUS]).

LGTM, the test cases can be further improved in v1.4


A few RaceMenu (not vanilla) presets have purple meshes

This is because the presets use a skin or body mod that we're not using, and I was negligent when I went around finding a bunch of presets. That aspect of the mod list has not been changed for some time
The faulty ones will be removed in the next version

Required dependencies for RaceMenu presets have been added. A few single-preset mods have been removed.


Page jumps to start when trying to edit code block

Trying to edit a code block after scrolling down in a page.
As soon as I click the code block to edit (first click of double click), the cursor jumps back up to the first line of the page. This is happening in all my pages regardless of number of code blocks or how large they are.

Thanks. Details:

BookStack v0.24.3
WYSIWYG
Google Chrome Version 68.0.3440.106 (Official Build) (32-bit)

Can confirm, breaking on Google Chrome (Official Latest) as well as Safari. No logs in JS Console.


Add method to disable all parallax elements

Would make it easy to disable all effects on mobile or for users who prefers-reduced-motion
See here:
https://github.com/jscottsmith/react-scroll-parallax/issues/183

released in 1.6.0


Feature Request : Add the possibility to have a function to set data directly in field

The objective is to have in Field Return in props value, a function called onData to change directly the data without HTML Event passed.
Exemple :
<Field name="test">
          {(field, props) => (
            <>
<Switch
      {...props}
      value={props.value}
      onChange={(data: boolean | null) => {
        props.onData(data);
      }}
    /></>
          )}
        </Field>

Discord Conversation : https://discord.com/channels/722131463138705510/1100520819207184475/1179455802478698636
Thanks !

@fabian-hiller 👋

Thank you for creating this issue. I will probably answer to this in January.

any update on this @fabian-hiller  ?

Unfortunately not. The revision of Modular Forms will probably take 2 to 4 months longer than expected. It is a lot of work and at the moment I can only partially focus on the project.


Create metric card for METEOR

Proposing a metric card for METEOR

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


I wish make rotatescreen implementation for macOS.

Can I become project creator, from adding Mac-os version of screen rotation?

Of course! That would be excellent! If you'd like to create a fork and submit your pull request I'd be happy to take a look. :)

So, I get to work today!

Good evening. I already wrote Mac version. I need create a fork?

Yes, if you'd like to submit a pull request you can create a fork and I'll take a look


Stacking popups?

I'm trying to use Magnific-Popup to stack the modals, see this example of what I'm envisioning: http://www.bootply.com/86958
Is there any way to accomplish this with Magnific-Popup?

What's the issue? The first one disappears when the second one shows up? Or you don't know how to achieve this?

The problem is the first one disappears when the second one shows up.

For me in Windows FF the first modal stays there when the 2nd opens:


Sema: Redeclaration checking should not mark implicit decls as invalid

If both the 'other' and 'current' declarations are implicit, we don't
emit a diagnostic unless they are both derived from property wrappers
or lazy property storage.
However, we would still call setInvalid() unconditionally, which splats
an ErrorType into the interface type, which would crash in the AST
verifier if no other diagnostic was emitted.
Fixes rdar://problem/67259506.

@swift-ci Please smoke test

@swift-ci Please test source compatibility


IP address not displaying when network connected after startup with no network

Been testing failover handling. Noticed today if I start a device with no network, it will display <IP_ADDRESS> with the red link status led. If I then plug in the ethernet cable the link status turns green but the IP address stays <IP_ADDRESS>, even though the device has connected and has received a DHCP lease etc.
I think this is because the _ethernet->linkStatus() updates to LinkON before an IP address has been obtained by DHCP. So in OXRS_LCD.cpp on line 390ish your code detects the change in link status and updates the display, but the IP address is still <IP_ADDRESS>. And then once the IP address is assigned, the link status doesn't change, meaning the UI is never updated.

I can't reproduce this behavior with my setup. Probably my router is faster/different?
This PR should take care for it, please test and let me know.


Update api docs links

Please double-check this, because I'm really tired
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct

Sibling PR: https://github.com/rerun-io/rerun/pull/1314


[POAE7-2419] support extract for arrow format

What changes were proposed in this pull request?

add null check before extract because extract runtime functions are complex and time consuming
update tests

Why are the changes needed?

support arrow array
Does this PR introduce any user-facing change?

No
How was this patch tested?

Uts
Which label does this PR belong to?

For not null, IR will be
%9 = call i64 @extract_month(i64 %8)
For nullable, IR will be
%11 = call i64 @extract_month(i64 %10, i1 %8)


ECONN refused when doing apollo graphQL query from getInitialProps

Bug report
Describe the bug
Following the with-apollo-auth example
Successful behavior when I do client-side ApolloConsumer query. I pass the client through and query works.
Unsuccessful behavior when I attempt to do a server side query through getInitialProps. I pass the client through a handler that calls the same query and I get a ECONN refused error as shown below.

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

I set up my ApolloClient in the init-apollo file as follows:

  const httpLink = createHttpLink({
    uri: 'http://localhost:8080/api/graphql',
    credentials: 'same-origin'
  })

  const authLink = setContext((_, { headers }) => {
    const token = getToken()
    return {
      headers: {
        ...headers,
        authorization: token ? `Bearer ${token}` : ''
      }
    }
  })

  return new ApolloClient({
    connectToDevTools: process.browser,
    ssrMode: !process.browser, // Disables forceFetch on the server (so queries are only run once)
    link: ApolloLink.from([ authLink, httpLink ]),
    cache: new InMemoryCache().restore(initialState || {})
  })

I set up my query as follows:

import gql from 'graphql-tag'

export default apolloClient => {
  apolloClient
    .query({
      query: gql`
        {
          getUser {
            id
          }
        }
      `
    })
    .then(({data}) => {
      console.log(data);
      return { userDetails: data.getUser }
    })
    .catch((err) => {
      // Fail gracefully
      console.log(err);
      return { userDetails: {} }
    })
  }

I set up my getInitialProps function in the index.js file within the pages directory:

  import getUser from '../shared/services/get-user';

  static async getInitialProps (context) {
    const results = await getUser(context.apolloClient)
    console.log(results);
    return {}
  }

Expected behavior
I expect to see a log of the user returned, however I get an ECONNREFUSED error as shown above.
Screenshots
Screenshot above.
System information

OS: macOS Mojave
Browser (if applies) Chrome
Version of Next.js: 7.0.2
Version of ApolloClient: 2.4.12l

Additional context

Using Absinthe (Elixir+Phoenix) GraphQL API, url specified: http://localhost:8080/api/graphq
Using docker-compose to spin up multiple containers. API and NextJS client are in separate containers sitting behind nginx server. Nginx server routes to relevant container depending on the url endpoint specified. If url contains api, API container will be called.

@sc4224 having the same problem, how did you solve it?

@timneutkens,  @K-JHC is right. Unfortunately if you are using docker-compose, containers can talk to each other by using service name or ip. So instead of using localhost:3000/graphql you have to use serviceName|IP:3000/graphql in your network. o now I found next solution:

.env + dynamic client.urldepends on browser/server request  (localhost:3000 || serviceName:3000)  -> sounds like workaround for me :(
Some proxy or mappping serviceName < - >  localhost inside containers.

Hard topic basically.

Ran into the same issue. Solved it by setting up an nginx container that is the main point of entry for all services, where /graphql maps to the API app, and / maps to the rest.
docker-compose.yml
nginx-proxy:
        image: nginx:latest
        volumes:
          - ./server.conf:/etc/nginx/nginx.conf
        depends_on:
          - client
        ports:
          - 80:80

    client:
        ...
        expose:
          - "82"

    api:
        ...
        expose:
          - "81"

nginx.conf
worker_processes 1;

events { worker_connections 1024; }

http {

    sendfile on;

    server {
        listen 80;

        location /graphql {
            proxy_pass         http://api:81;

            proxy_redirect     off;
            proxy_set_header   Host $host;
            proxy_set_header   X-Real-IP $remote_addr;
            proxy_set_header   X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_set_header   X-Forwarded-Host $server_name;
        }

        location / {
            proxy_pass         http://client:82;

            proxy_redirect     off;
            proxy_set_header   Host $host;
            proxy_set_header   X-Real-IP $remote_addr;
            proxy_set_header   X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_set_header   X-Forwarded-Host $server_name;
        }
    }
}


Provide an example, how to remap default key bindings

Hi, thank you for such great plugin, very handy!
Can you please Provide an example, how to remap default key bindings?
Unfortunately current bindings are conflicting with many popular modules like NERDTree.
Thank you.

Thank you!
You should be able to override the global variables by just redefining them in your own vimrc:
let g:TasksMarkerBase = '[ ]'
let g:TasksMarkerDone = '[x]'
let g:TasksMarkerCancelled = '[-]'
let g:TasksMarkerBase = '-'
let g:TasksMarkerDone = '-'
let g:TasksMarkerCancelled = '-'
let g:TasksDateFormat = '%Y'
let g:TasksArchiveSeparator = '-----'
let g:TasksAttributeMarker = '#'

You can override any or all of them!

How can I override these?

<leader> n - new task below
<leader> N - new task above
<leader> d - toggle current task complete
<leader> x - toggle current task cancelled
<leader> a - send completed tasks to the archive

Ah! Sorry :)
I'm actually not quite certain what the "right" way to do this is, but you could just follow the format in https://github.com/irrationalistic/vim-tasks/blob/master/ftplugin/tasks.vim#L14 (minus the "buffer" bit) and set your own new bindings. Does that help?

Yes, it helped indeed! Thank you :)
I still think you should mention it in the README.md it's very useful to know.


DOC/BLD: set up automated doc builds with travis / doctr

Closes https://github.com/pyproj4/pyproj/issues/256
I added it in such a way that the doc build and upload only happens in a single build (using the DOC=true environment variable)

Note from doctr configure to a repo admin:
1. Go to https://github.com/pyproj4/pyproj/settings/keys
   and add the following as a new key:

    ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQC7OqGE1S72vUuOpvA/cv2MYImHu/NgrzBDZYzCzoTekb5nRhkPzBjxsg8TAzm6yM1x1EYiHqNDIqfR/jwEpYvvzkcgrt/I5RjcVNQnVktZe1q/1EkQFblSydnMRFCZMeIyL2ds7MeH4ZgGslA4aUnOc2v5VOMDoLsThVDOjqOBvpm1qktxxxizrSNJgg/MCKweQn0+gOr46/xiBs/bZPfI15oM7c7ug8sr8lSEtzJzGBLFQneAOBMPmxST+LNVP4TwRE29Xh7hhKluC9isanZhZchw7e1591XZegva0lMLszXPTgaT8jRkYXe0RZ//i71RwIaUd5PGswxPYZagc9XS4VoYoLriWXOcVDNc5x2BK7eDr6+7qI/Nk6LALAfrPfmZvZxS/LgZr0M5pq6BGc64/WN2oEwrMUwOJvtcdf8gphVqbg+4GIBrKZkDm54ijLdbGtiZpdzWoNwLTSzphGQMTMUzy94ihqQ9g7nCimK0Qwn2jiC9vFiAaQ8DMttajjQBTXWFhntOOTW3TLkAU3xhrUbMmsohSACxf1QfMQc2gZHUB9ZrkuR4xxiOyAxsZ5iXTDx8lBEzfS6j4qkn2hpS3sOxhBtgjPPqo/H3amF7fV4bRmCL/L4dBb5pmQ4FyDI2U/z8OtxTnJP8HSrXhfm6wwQaWjh4ZF1wSmg/PPWA6Q==
   Be sure to allow write access for the key.

See https://drdoctr.github.io/recipes.html#setting-up-doctr-for-a-repo-you-don-t-have-admin-access-to

@snowman2 we will only be able to actually test it once it is merged in master, since doctr only uploads the docs for commits in master, not in PRs

(also changed the sphinx theme, as discussed in the issue)
This should be ready now.

What are your thoughts on building the docs outside of the if and just be part of the tests?

I put it deliberately here, to only build the docs in a single travis build (with the idea: it not needed to build it in each one)
But for that particular build, it is still "part of the tests", meaning you can check the log output if everything is fine / it will fail if sphinx crashes

Also, what are your thoughts on deploying docs in the after_success section?

I don't mind much. Looking at the docs, there is a warning about it here: https://drdoctr.github.io/index.html?highlight=after_success#edit-your-travis-file (scroll a bit down). Saying that if you put it in after_success it will not cause the build to fail.

Good points. Probably better as is then. Thanks for the clarification!

Thoughts on updating the create_docs.sh and use that for building docs?

Thoughts on updating the create_docs.sh and use that for building docs?

Yep, I actually wanted to propose to move the added code in travis.yml to a separate script. But OK to put that in ci/travis/ then instead of top-level ?

But OK to put that in ci/travis/ then instead of top-level ?

Are you referring to the entire doctr process or only the sphinx part?

Ah, I was referring to the entire process. But you might want to have a script that just builds the docs, as it is now?

I am happy to do such a change (update the current create_docs.sh for just installing deps + building docs, no doctr) and use that in travis.yml.
But personally not sure how useful it is to have that in the top-level repo (compared to having a script in travis/ci), as I would assume that somebody locally simply does a cd docs; make html ?

It is convenient to have. Much simpler to autocomplete and it is nice have a reproducible way to build docs for newcomers to use as well.

I would personally say: then it should not install things (one should try to keep running a script and setting up environment separate IMO)
But, if that's actually the goal, it might be worthwile to add an actual Makefile, so you can eg do make docs from the top-level directory. And then we can also provide other development workflows, eg things like make inplace as a shortcut for building the C extensions inplace.

Anyway, this discussion is getting unrelated to the actual PR :) Will use that script for now, we can always update it in a separate issue/PR.

It would be fantastic to have a Makefile - but that is for another issue as you stated.

Updated

Note that before merging this, it is best to add the key mentioned above in https://github.com/pyproj4/pyproj/pull/278#issuecomment-485906648

@jswhit is this approach fine for you?

Alright, testing now :crossed_fingers:

Looks successful to me. Nice work @jorisvandenbossche!
https://pyproj4.github.io/pyproj/dev/index.html

Looks successful to me.

Great!


Dynamic button text and dropdown nesting fixes

Added capability for dynamic button text based on an entity+attribute
Tested and fixed CSS and a few functions so it's possible to nest a dropdowndivconverter inside of another one

Please fix the merge conflicts before we can do a merge

Ok all set!

All the features that were added are now already in the current mainline so no need to do a merge. thanks for the great input by the way. Love to hear more ideas for the dropdowndivconverter usage


⚠ Bofrost.de has degraded performance

In 5092786, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1475 ms

Resolved: Bofrost.de performance has improved in 499e496 after 7 minutes.


[FLINK-11903][tests]Improve FileStateBackendTest by using JUnit's parameterized.

What is the purpose of the change
Improve FileStateBackendTest by using JUnit's parameterized.
Brief change log
Use Junit's parameterized in FileStateBackend, and delete the class AsyncFileStateBackendTest
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks for review @StefanRRichter


EJS language syntax is not being highlighted

Steps to reproduce:
Here's the line of code that isn't working and the settings I have set

Expected result:
Syntax of <% and %> should be highlighted

Hello, I got this problem but still can't find right decision

Also my settings

may be you can give me some advice how I can to fix that.

I fixed it by installing EJS language supporter and it works but the syntax still don't highlighted

What is your language for the file set to? It should be HTML.
The brackets do not highlight but the code within should be seen as javascript.

Here is what I see when I wrote a quick test with your code.

What is your language for the file set to? It should be HTML.
The brackets do not highlight but the code within should be seen as javascript.

Is it correct highlights? I thought that the brackets also should be colorised

Here is what I see when I wrote a quick test with your code.

I understood. Thx you man)

Yup, everything looks to be correct to me. Glad it is fixed for you!


errors

.../../../../../Applications/Racket v8.14/collects/racket/contract/private/arrow-higher-order.rkt:375:33: last: contract violation
expected: (and/c list? (not/c empty?))
given: '()
This error occurs due to 450lang's strict contract system requiring non-empty lists in certain operations. The contract violation happens because:
When depth reaches 0, the function returns an empty list (mt)
450lang's contract system expects a non-empty list for the append operation
This is a language-specific constraint in 450lang where empty lists cannot be used in certain list operations
The error message indicates that the contract system was given an empty list ('()) when it required a non-empty list satisfying both list? and (not/c empty?)
The error is reproducible and demonstrates the strict type checking and contract enforcement in 450lang, which is a key feature of the language's design for catching potential programming errors.

Hi thanks for the report, but all submitted issues must follow include a descriptive title and must follow the bug report template. Please update the report with a more descriptive title and do not delete the bug report template parts

Closing this report since it's unclear what is being reported. Open a new ticket with the requested information if you wish to pursue further


Simulation fails for unknown reasons, unrelated to simulators

Simulation id: 5fdfae6ca2f1af479ae5c30a, OMEX file
Simulation id: 5fdfadc5a2f1af748fe5c302, OMEX file

I don't think its related to VCell. I ran the simulation again with VCell, and it succeeded.

Both jobs ran successfully on the HPC. If they were marked as failed, this was because the service was unable to connect to the hpc and get the updated status, and thus defaulted to failed to handle the error. The new host for the hpc should help with this as well, and I can create a new issue to handle ssh timeouts a little more robustly.
This is likely tied to #1712


update tests in Core.jl

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


[Bug Title here] Duplicate car in game number 76-CarGame

What happened?
A duplicate car appears, which though cannot be hit by enemy cars, is still ann ugly display

How can we reproduce this bug?
Pressing Space key, the duplicate car appears on the right edge of the road
Desktop Information (Optional)
OS: Windows
Browser: Firefox
Urgency (Optional)
Low priority

@VijaySamant4368 All the best 👍🏻


Ability to set Teams and Team Members at the Org level, not only Rulesets

Prerequisites:

Is the functionality available in the GitHub UI? If so, please provide a link to information about the feature.

Currently this functionality is available to set at the org level here: https://github.com/orgs/<org-name>/teams where teams can be created and members added to them.

Is the functionality available through the GitHub API? If the functionality is available, please provide links to the
API documentation (https://developer.github.com/v3/) as well as the Octokit documentation (https://octokit.github.io/).

Yes. API functionality is available for:

Managing teams teams: https://docs.github.com/en/rest/teams/teams?apiVersion=2022-11-28
Managing team members: https://docs.github.com/en/rest/teams/members?apiVersion=2022-11-28

New Feature
Currently it is not possible to target any org settings except for rulesets. We would like to use the safe-settings app to also manage our teams at the org level, and manage members. These functionalities are fully available in the GitHub UI right now, and have full API support, as referenced above. If it is possible to manage teams and team members with the bot, we do not need to have org owners that can use the UI to manually manage these settings and we can use the PR approval flow to keep things consistent across our org.
Because Teams can have sub-teams, it might make sense to have the settings for teams to be its own file like teams.yml where Team name, details, members, sub-teams, etc... can be defined below nested as deeply as users might need to.
A note for project maintainers... my company needs this functionality, so I am willing to contribute these enhancements back to the safe-settings app. Ideally I would like to align with maintainers on a few implementation details (naming, should this be in the main org settings.yml or a separate teams.yml or both, etc) before moving too far forward, so that there are no annoying refactors afterwards.

@decyjphr sorry to tag you here... but I have some free time this weekend and next week that I could spend adding this functionality. I would just like to know:

Would a PR adding this functionality be considered as part of the scope of this project and accepted?
Is there an opinion about having teams be included in the main settings.yml file or as a separate teams.yml file? (Separate could have a few benefits such as defining different CODEOWNERS)
Anything else you think I should know to make this successful in terms of expectations other than what is in the repository Contributing guidelines?

@brianespinosa We already have a config for Teams here
But so far we only intended to set the team permissions for repos and not manage the Team creation and Team memberships. Those were left to the Azure AD or some external system.
But we have seen requirements related to teams crop up. Here is one which I am planning to work on. So I think we might be at a point where we should consider a way to manage teams and team memberships.
For your question #2, I think we should keep teams under a separate folder, perhaps, teams, similar to how we have repos or suborgs
Also, we should consider a separate metadata.yml file which could have flags such as:
allow_only_idp_teams
that applies to the org in general

I really like this idea and as new user I started looking for this features documentation with in about an hour after setting up my first few repos.


Add question template

Add issue template for questions to avoid everything being a bug.

/test-force-approve


Redesign: NSFW content claim pages not masked/blocked

The Issue
In the redesign, you can still navigate to and download properly marked NSFW. The thumbnail does have the red image and note to go into settings on the Discover/channel pages, but you can still click on it to go to the claim page (should not be able to right?) and the claim page allows download/view (should not be able to unless setting is turned).
Sample URL - see homepage or lbry://curl#bcd555ff11ec3084dc23d3b3b70ac7b93e6b3912
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

This is intentional. I am very much in favor of allowing people to navigate to the file page. I think the red color and description is enough of a warning.
Interested in hearing others thoughts.

Ah, now I do remember that conversation. @kauffj do you have a strong stance one way or another?

@tzarebczan I have no opinion about this until my build is working again and I can actually see what we're talking about. I'm also archiving this thread, so please ping me again if you actually want an answer. Also, I trust @seanyesmunt, so we should do whatever he says.
(I do think, in time, it makes sense to evolve filtering from a binary option to a ternary of: on/blur/hide, but that'd be a new feature)


Migration Issue: Failed to Open Reference Table rooms

While migrating a database in Laravel, I encountered a problem with the following error:
  Dropping all tables ................................................................................................................... 148ms DONE

   INFO  Preparing database.

  Creating migration table ............................................................................................................... 14ms DONE

   INFO  Running migrations.

  2019_12_14_000001_create_personal_access_tokens_table ................................................................................. 137ms DONE
  2024_05_12_000000_create_failed_jobs_table ............................................................................................. 32ms DONE
  2024_05_12_000000_create_users_table ................................................................................................... 22ms DONE
  2024_05_12_100000_create_password_resets_table ......................................................................................... 19ms DONE
  2024_05_12_173148_create_admin_tables ................................................................................................. 245ms DONE
  2024_05_12_195726_create_room_types_table .............................................................................................. 10ms DONE
  2024_05_12_200746_create_borrow_rooms_table ............................................................................................ 13ms FAIL

   Illuminate\Database\QueryException

  SQLSTATE[HY000]: General error: 1824 Failed to open the referenced table 'rooms' (Connection: mysql, SQL: alter table `borrow_rooms` add constraint `borrow_rooms_room_id_foreign` foreign key (`room_id`) references `rooms` (`id`))

  at vendor/laravel/framework/src/Illuminate/Database/Connection.php:793
    789▕         // If an exception occurs when attempting to run a query, we'll format the error
    790▕         // message to include the bindings with SQL, which will make this exception a
    791▕         // lot more helpful to the developer instead of just the database's errors.
    792▕         catch (Exception $e) {
  ➜ 793▕             throw new QueryException(
    794▕                 $this->getName(), $query, $this->prepareBindings($bindings), $e
    795▕             );
    796▕         }
    797▕     }

      +9 vendor frames

  10  database/migrations/2024_05_12_200746_create_borrow_rooms_table.php:41
      Illuminate\Support\Facades\Facade::__callStatic()
      +35 vendor frames

  46  artisan:37
      Illuminate\Foundation\Console\Kernel::handle()

Problem Details:
Tables Involved: borrow_rooms
Reference Table: rooms
Error Encountered: Failed to open the rooms table when trying to add a foreign key constraint to borrow_rooms.
Please help to check and fix this problem. Are there any additional steps to take or settings to note in the database schema?

I provide an update on the migration issue where the reference table rooms failed to open when adding a foreign key constraint to borrow_rooms.
After investigating the problem, I discovered that the issue was caused by the order of the migration scripts. The rooms table needed to be created before the borrow_rooms table. By adjusting the migration order, I was able to resolve the issue.
If you encounter any other problems or have further questions, please feel free to reach out.


Mention Packt MicroProfile book on homepage

Mention the Packt book on MicroProfile https://www.packtpub.com/web-development/hands-on-enterprise-java-microservices-with-eclipse-microprofile in the resources section of MicroProfile.io (likewise for other books on MP)

perfect ticket @pilhuhn! :)

Hello @pilhuhn. Thank you for making this ticket. After discussing this topic with @aeiras, I voiced my opinion that it would probably be best to promote your "Packt book" with a blog post. I feel it would not be scalable if everyone who released a book to be featured on the home page. Especially that this is not a community push/ non profit publication.
Please let me know what you think about putting out a blog about your "Packt book" and we can promote in on MP social media.

Hi @aeiras  - I see I am assigned. Not sure what I need to do ?

Hey @phillip-kruger, we recommend a short to the point copy/paste of the abstract of the book in a blog format, adding in MP wordpress as a blog with the link to the book.
That blog then can be pushed via the MP media, say every 2 weeks, as the white paper is pushed today.
As it is, as explained during the MP community hangout and this thread, it is not scalable to add to resource tab b/c it requires human intervention. The resources tab in the website is the only part that is not automatic, therefore, any item that is added must be sure not to be later debt. Get it?
@cealsair forgot to pulled you in this thread on today's mktg call, please see above. I see you are also a collaborartor in the book.

hey writers,
is there a blog on this book via MP website? been too long, cannot find it.
thanks for the follow up, ideally, this book can be added to the 2020 constant media push, say 1 per month twitter push to remind interested readers about it.
Same initiate is being taken with e books, currently 2 already added to the blog that are hopefully to be approved by the authors as a constant running via MP media!
-- cheers

Oct 2019 to now, it seems that a blog for publish book is not in the cards.
Will close ticket, if the authors choose at a later time to write a blog, kudos :)


Decoding time is too long

Rendering a 150M gltf model locally using three.js requires about 4-5 display pages, but with the gltf-pipeline compressed model, the display takes about 8 seconds. Why is that?

The extra loading time is for decoding the compressed data. This is just the standard tradeoff when using compression, the model is smaller and faster to download but must be decoded before it can be rendered.

Is the difference between the two rendering times above correct? If it is normal, then under what circumstances is it appropriate to use gltf-pipeline to encode data for rendering?@lilleyse

How do I send the model to you? @lilleyse

You can send me a download link -<EMAIL_ADDRESS>

This is a download link：
https://sketchfab.com/models/25e0167e6d074d8e9896786b1ae67582
@lilleyse

I see a reduction from 174 MB to 34.6 MB (152 MB to 13 MB ignoring textures). That's really good.
Both ThreeJS and Cesium load it in 3-4 seconds on my machine. I think everything is working as expected, you'll just have to decide if the decode time is a problem. If it is, you can also just gzip the model, which produces a larger compressed file (45 MB), but can be decoded extremely quickly by the browser. gltf-pipeline hasn't have a command to gzip but there are other tools out there.

Will the time you use three.js be the model load time, or will the model render time displayed in the browser interface? In addition, what tools are used to implement the gzip compression model? What is the specific operation? @lilleyse

I just measured the total time it took to display the model after dragging it onto https://gltf-viewer.donmccurdy.com/. Not a super fine grained measurement so I don't have more exact numbers.
I used 7-zip to apply gzip compression. Just make sure that if you use gzip you need to tell your server to server the file as gzipped.
Is think this discussion is going beyond the scope of gltf-pipeline, but if you have more thoughts feel free to email me.

Thank you for your answer
------------------ 原始邮件 ------------------
发件人: "Sean<EMAIL_ADDRESS>发送时间: 2018年6月26日(星期二) 凌晨3:00
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [AnalyticalGraphicsInc/gltf-pipeline] Decoding time is too long(#381)
I just measured the total time it took to display the model after dragging it onto https://gltf-viewer.donmccurdy.com/. Not a super fine grained measurement so I don't have more exact numbers.
I used 7-zip to apply gzip compression. Just make sure that if you use gzip you need to tell your server to server the file as gzipped.
Is think this discussion is going beyond the scope of gltf-pipeline, but if you have more thoughts feel free to email me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


[Android Export] Unique Package Name / Application ID change should be required

Godot version:
Any
Issue description:
The default Unique Package Name / Application ID is set to "org.godotengine.$genname" in the export options and thus ends up being (for example) "org.godotengine.mynicegame" for most projects.
This leads to many Android projects on the Google Play Store that follow this same package naming scheme, instead of being correctly attributed to their creators - as seen on the /r/godot subreddit pretty much every week. This could also lead to people feeling mislead and thinking that those games are official Godot engine demos or similar.
I know this might be a "the user should know what they're doing when exporting for Android" issue, but the engine shouldn't make it this easy to make this mistake.
Proposed changes (whichever are the easiest / most comprehensive should be picked):

Warn about the default package name being used (but still allow it, for aforementioned official demos for example)
Provide a placeholder instead of a default value, and don't allow export without a package name
Additionally have the tooltip explain the application ID, maybe linking to https://developer.android.com/studio/build/application-id in the docs

Excellent! I had given the issues some searches but haven't checked closed pulls. Lesson learned for next time :)


Navigation & cache issue with tab & navpush

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[x ] 2.x
[x ] 3.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[ x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
https://github.com/ionic-team/ionic/issues/12454
Expected behavior:
Cache must be optional like ionic1 as we are making dynamic app not a static app. there should  must have some workaround to avoid above issue.
if you check around on ionic forum lots of pepole have similar cache issue. please consider cache by  choice
Steps to reproduce:

Related code:
insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

Hello! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to ionic-team/ionic-feature-requests#289


[FEAT] - Propagation Reconciliation Triggers

Priority
(Low) Something is a little off
Description
Investigate the reconciliations for propagated resources such as Teams, TeamMemberships.
Currently these controllers have the highest rate of reconciliation.
Acceptance Criteria:

[ ] reduce reconciliations (workqueue_adds_total)

Reference Issues
No response

superseded by #728


Failed to Execute "getComputedStyle" on Dropdown for Large Screen Dimension

Introduction
Hi, I'm in the process of recreating my website while in the process of migration from v0.100.2 to v1.0rc.1. After hours of migration process, I have stumble upon dropdown component. This is where the issue starts. The dropdown initialization is fine, meanwhile in the process of executing getComputedStyle during dropdown function, is failed.
Expected Behavior

The dropdown will show up without any errors.

Current Behavior

The dropdown doesn't show up due to failure execution of getComputedStyle
Dropdown does only work on small screen or lets say ranging <999px width. Technically speaking that the dropdown works only on small screens only. While in larger screens, it doesn't work as expected.

Test Case // Codepen and Website
https://codepen.io/CodexLink/pen/Xqxvzq
https://codexlink.github.io/
Debug Mode View of CodePen
https://s.codepen.io/CodexLink/debug/Xqxvzq/NQkzYqOKoOdA
What area that holds the function?
The problem is on the navbar on the right corner. If you see the bell, then that is the one that holds the dropdown function.
Description for CodePen
There are two buttons that holds the trigger for dropdown content. One is the bell and one is the center that I have taken from the Materialize Documentation. The Button that I took, is working. And for the bell is not working for larger screens, but except to small screens.
Reproducing the bug
Just resize your browser width in small dimensions, a width of 999px with any height value. Hover to the bell both on large and small screen and check the difference.
Context
The issue affects me the inability to provide incoming people to check for website updates through dropdown list that I can serve. The thing that am trying to accomplish is a notification like dropdown component with hover so that people will know what is currently happening.
My Environment

Version used: Materialize Release v1.0.0-rc.1
Browser Name and version: Chrome 66.0.3359.139
Operating System and version : Windows 10 64bit Arch, ver1703 (Creators Update)
Link to your project: https://codexlink.github.io/     // Main Website that has Bug
https://github.com/CodexLink/codexlink.github.io // For File

Files that affects some Materialize Components

ColorStyleScheme.css // Custom CSS that Overrides some Materialize Components (Few)
External_JavaScript/CodexLink_JQ_Dependency_CustomCode.js // JQuery Components
External_JavaScript/CodexLink_JQ_NonDependency.js // JS Materialize Component Initializers

Remarks / Note

I almost have zero knowledge on JavaScript so debugging it by myself is somewhat confusing.
I have tried initializing the process through console and it's same error shows up. This is the code: 'var dropdown_compatibility = window.getComputedStyle(dropdown_main, null);'
The Dropdown is part of AppBar Component.
The dropdown only works on small screens <999px. (Custom Dimension for Small Device)

Technical Detail for the Error
Uncaught TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.
    at Object.M.checkPossibleAlignments (materialize_v1rc.1.min.js:6)
    at s.value (materialize_v1rc.1.min.js:6)
    at s.value (materialize_v1rc.1.min.js:6)
    at s.value (materialize_v1rc.1.min.js:6)
    at s.value (materialize_v1rc.1.min.js:6)

This is a pretty confusing edgecase. So what our dropdown does by default is move the dropdown to right after the dropdown trigger. In this case, it is moving it after the trigger that is hidden on larger screens. The dropdown will not work when it is hidden.
To fix this you can either try reworking your markup to make sure you only 1 dropdown trigger and it is always visible.
You could also manually specify the container parameter as the nav-wrapper element. This will override the movement of the dropdown to the specified container element instead.

Thanks for the reply, I just fixed the issue just now. Reworking and observation is just what I need. Following the format on documentation seems to be great. The process that I did is to make two dropdown content for small and large scale device.
Hence, web_ver-historical id raises two ids web_ver-historical_small and web_ver-historical_large.
Which this concludes that I made two seperate dropdown content both exclusively for small and large scale device.
Realization
Warning : Poor Explaination
Although in the process of recreating my work, I found out that using only one dropdown content both for small and large scale device seems that it will likely to fail to calculate or to execute getComputedStyle due of complex reasons. Although I can't explain it yet because I don't know how would I said it. But to make clue it seems the 'getComputedStyle' only execute contents on one side-device scale. It cannot compute for both large and small scale, but only one type (large or small) for the content. So in overall, I cannot initiate it both for small and large (because I think it is confusing case and for the function as well), but only for  only. Which concludes the raise of two IDs that I stated from above. One for Large Scale and one for Small Scale.
In reply response
I'm not sure that two button holders for dropdown would interfere from calculating the style. Anyway, specifying container class wouldn't resolve the problem I guess, I tried and it doesn't override the movement.
Thank you for reply and I would likely to apologize for constructing poor explanation or statement but I hope you would understand. I will close the issue now since I fixed it.


wrong links

5.0.2 given links in releases page for "Release Notes & Install Instructions" are wrong

@rbhanda can you check?

@rbhanda can you check?

I have updated the release pages for 5.0.2 with correct links.

I have updated the release pages for 5.0.2 with correct links.


contiv-vpp: no vswitch connectivity when vpp is using multiple cores

deployment:

OS: ubuntu 18.04
simple deployment (1 x master, 1 x worker), static IPs, no STN
dedicated Mellanox NIC for data plane
test containers on different nodes communicate over contiv-vpp data plane

Issue:
with the config below everything seems to work as expected, however when I start the vpp with multiple cores for example by using "corelist-workers 2,3", the vswitch containers are not communicating any more with each other (ping 192.168.16.X is not working any more), and interfaces counters showing drops.
contiv-vpp.yaml:
    NodeConfig:
    - nodeName: "k8s-master"
      mainVPPInterface:
        interfaceName: "HundredGigabitEthernet7/0/0"
        ip: "<IP_ADDRESS>/24"
      gateway: "<IP_ADDRESS>"
    - nodeName: "k8s-worker1"
      mainVPPInterface:
        interfaceName: "HundredGigabitEthernet7/0/0"
        ip: "<IP_ADDRESS>/24"
      gateway: "<IP_ADDRESS>"

contiv-vswitch.conf:
unix {
   nodaemon
   cli-listen /run/vpp/cli.sock
   cli-no-pager
   log /tmp/vpp.log
   poll-sleep-usec 100
}
nat {
   endpoint-dependent
   translation hash buckets 1048576
   translation hash memory 268435456
   user hash buckets 1024
   max translations per user 10000
}
acl-plugin {
   use tuple merge 0
}
api-trace {
    on
    nitems 5000
}
cpu {
  corelist-workers 2
  main-core 1
}
dpdk {
   dev 0000:07:00.0
}

get-pods output:
NAME                                 READY   STATUS    RESTARTS   AGE     IP             NODE          NOMINATED NODE   READINESS GATES
contiv-crd-4ml9p                     1/1     Running   0          77m     <IP_ADDRESS>   k8s-master    <none>           <none>
contiv-etcd-0                        1/1     Running   0          77m     <IP_ADDRESS>   k8s-master    <none>           <none>
contiv-ksr-8rhbc                     1/1     Running   0          77m     <IP_ADDRESS>   k8s-master    <none>           <none>
contiv-vswitch-g9jjq                 1/1     Running   0          77m     <IP_ADDRESS>   k8s-master    <none>           <none>
contiv-vswitch-mpjwn                 1/1     Running   1          77m     <IP_ADDRESS>   k8s-worker1   <none>           <none>
coredns-86c58d9df4-h7j5z             1/1     Running   0          76m     <IP_ADDRESS>       k8s-master    <none>           <none>
coredns-86c58d9df4-hd8t6             1/1     Running   0          76m     <IP_ADDRESS>       k8s-worker1   <none>           <none>
etcd-k8s-master                      1/1     Running   0          4h24m   <IP_ADDRESS>   k8s-master    <none>           <none>
kube-apiserver-k8s-master            1/1     Running   0          4h24m   <IP_ADDRESS>   k8s-master    <none>           <none>
kube-controller-manager-k8s-master   1/1     Running   0          4h24m   <IP_ADDRESS>   k8s-master    <none>           <none>
kube-proxy-s5wbx                     1/1     Running   0          4h18m   <IP_ADDRESS>   k8s-worker1   <none>           <none>
kube-proxy-trh5t                     1/1     Running   0          4h25m   <IP_ADDRESS>   k8s-master    <none>           <none>
kube-scheduler-k8s-master            1/1     Running   0          4h24m   <IP_ADDRESS>   k8s-master    <none>           <none>

VPP interfaces and IPs (on master node):
vpp# show int
              Name               Idx    State  MTU (L3/IP4/IP6/MPLS)     Counter          Count
HundredGigabitEthernet7/0/0       1      up          9000/0/0/0     rx packets               2846420
                                                                    rx bytes<PHONE_NUMBER>
                                                                    tx packets                986407
                                                                    tx bytes               115507026
                                                                    drops                         29
                                                                    ip4                      2846404
                                                                    ip6                            2
local0                            0     down          0/0/0/0
loop0                             2      up          9000/0/0/0
loop1                             6      up          9000/0/0/0     rx packets               2846384
                                                                    rx bytes<PHONE_NUMBER>
                                                                    tx packets               1972786
                                                                    tx bytes               132373324
                                                                    ip4                      2846384
tap0                              3      up          1450/0/0/0     rx packets                  3396
                                                                    rx bytes                 1428440
                                                                    tx packets                  3389
                                                                    tx bytes                  254751
                                                                    drops                         13
                                                                    ip4                         3383
                                                                    ip6                            1
tap1                              4      up          1450/0/0/0     rx packets                  2000
                                                                    rx bytes                  156658
                                                                    tx packets                  2002
                                                                    tx bytes                  742350
                                                                    drops                          1
                                                                    ip4                         1999
                                                                    ip6                            1
tap2                              7      up          1450/0/0/0     rx packets                985012
                                                                    rx bytes                65501146
                                                                    tx packets               2845006
                                                                    tx bytes<PHONE_NUMBER>
                                                                    ip4                       985012
vxlan_tunnel0                     5      up           0/0/0/0       rx packets               2846384
                                                                    rx bytes<PHONE_NUMBER>
                                                                    tx packets                986393
                                                                    tx bytes               101696810
vpp#
vpp# show int addr
HundredGigabitEthernet7/0/0 (up):
  L3 <IP_ADDRESS>/24
local0 (dn):
loop0 (up):
  L3 <IP_ADDRESS>/24 ip4 table-id 1 fib-idx 1
loop1 (up):
  L2 bridge bd-id 1 idx 1 shg 1 bvi
  L3 <IP_ADDRESS>/24 ip4 table-id 1 fib-idx 1
tap0 (up):
  L3 <IP_ADDRESS>/24
tap1 (up):
  unnumbered, use loop0
  L3 <IP_ADDRESS>/24 ip4 table-id 1 fib-idx 1
tap2 (up):
  unnumbered, use loop0
  L3 <IP_ADDRESS>/24 ip4 table-id 1 fib-idx 1
vxlan_tunnel0 (up):
  L2 bridge bd-id 1 idx 1 shg

any one was able to run contiv vpp vswitch over multiple cores?

an update:
when disabling vxlan (useL2Interconnect: flase), vswitch containers running on multiple cores were able to communicate. seems like the issue is related to vxlan connectivity with multiple cores.

Hi @itaimlx
thanks for reporting this. Yes, we know that there might be some issues with using multiple cores on VPP, especially with the NAT plugin. Single-thread is the only supported mode for now.

The issue will be addressed with the upcoming VPP 19.08 release.


Improvements in MDExpansionChevronRight

I've always been infuriated that I can't open MDExpansionPanel by clicking on the arrow (chevron), and so I decided to eliminate this glaring flaw 😁

The PR is deprecated due to the new API of the KivyMD library 2.0.0 version


Cleaned up dimension tests

Hi
A bit of a cleanup of the dimension tests

move globals to class properties
add missing assert statement

Cheers
Alex
https://github.com/cubewise-code/tm1py/issues/301

Thank you @scrambldchannel


Migration::down() implementations

I manage all the migrations in my application automatically, including extensions' migrations.
A migration should be revertible.
I created the missing down functions in your migrations.

Thank you!


Feature Request: Accessibility

Accessibility for those with disabilities is something I take very, very serious and would like to completely comb every every aspect of GPT-Runner to ensure it is fully accessible. Tab indexes, alternate text, keyboard shortcuts, etc. Im open to discussion on this topic and interested in your recommendations to establish a reasonable plan. gpt-runner-web will be much easier for me than the others.

Your proposal is excellent. In fact, my experience with Accessibility is quite limited, and I am not very proficient in this area. I would highly appreciate if you could submit a PR regarding this.
@CogNetSys


added proxy support as parameter and output to CSV parameter for file based lookups

Thanks for taking the time to make a PR. I'll take a look and see about getting it merged in!

Thanks for the PR! I believe these additions are covered (at least mostly) by subsequent merged PRs so I'm closing for now.


Add a flag to use the 'signature' format for type annotations

The motivation here is that the type comment parser can't handle
Callable types and I want to be able to use pyannotate to add them.

I don't have write access

Just invited you -- doesn't it work?


[tables] Add RestError export

This adds the RestError class that can be thrown by the library to the exports so that consumers can more easily catch and perform instanceof checks on thrown errors.
This is the convention with @azure/storage-blob and @azure/storage-queue

Thanks for your contribution @dhensby. I'd like to understand a bit more about the context and scope of this fix, is there any scenarios where you find we should be throwing a RestError but we are not? Or is this change just meant to export the RestError to be referenced, without any intended changes in the SDK behavior?

Or is this change just meant to export the RestError to be referenced, without any intended changes in the SDK behavior?

That's absolutely right. It's so that the errors that are thrown can be caught and acted upon. For example:
const { TableServiceClient, RestError } = require('@azure/data-tables');

const client = new TableServiceClient(...);
client.createTable('mytable')
  .then(() => console.log('created table'))
  .catch((err) => {
    if (err intanceof RestError) {
      // some specific error handling
    }
  });

I have tried instead to import directly from the @azure/core-rest-pipeline library, but this is unreliable because of how npm can manage and de-dupe (or not) shared dependencies. So an approach like this that I have taken does not work in some instances:
const { TableServiceClient } = require('@azure/data-tables');
const { RestError } = require('@azure/core-rest-pipeline');

const client = new TableServiceClient(...);
client.createTable('mytable')
  .then(() => console.log('created table'))
  .catch((err) => {
    if (err intanceof RestError) {
      // some specific error handling
    }
  });

This PR isn't intended to change any behavior, instead it just more clearly defines the contract between the package and the consumer.

This point about importing error types from core being unreliable is good. We could probably have a guideline around always ensuring every error a package might throw has exported its type. This is also why I generally prefer people checking error name and code, but TS 4.4 made this a little more difficult in strict mode unfortunately.

This is also why I generally prefer people checking error name and code

This is what I've done for the meantime, but as I posted originally, other @azure/* packages to export their respective RestError class, so it just felt natural this this library should too.


Add PIN Based Authentication

Summary
I would like an optional PIN based authentication method to the app.
Basic example

The user opens the app.
The user creates a backup.
The user navigates to the "Security" menu.
The user is given the option to create a PIN for the app.

Motivation

Adding PIN based authentication provides an extra layer of security for those who want it. Some users prefer not to use passwords.
This is a convenient and easy to use alternative authentication method.

Some users prefer not to use passwords.

So we have password auth but not pin auth. You can still just type a few numbers in if you wanted for the "password". I don't think we have a length requirement for it, so it could just be 4 - 8 digits if you wanted.


[Apple Notes] Stopped working search notes and shows error

Extension
https://www.raycast.com/tumtum/apple-notes
Description
Stopped working after recent Raycast update and shows error: "Cannot search notes database disk image is malformed"
Steps To Reproduce
Open Raycast, write "Search notes" hit enter and see error.
Current Behaviour
No response
Expected Behaviour
No response

Same is happening to me

It appears that this is a duplicate of issue https://github.com/raycast/extensions/issues/6916, so I'll mark it as such.


Adds CM accesses to the aghost.

About the PR
Why / Balance
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

I know we're avoiding upstream changes but this shouldnt be an issue in the long run surely, if theres a conflict it would only need the accesses added again anyways :godo:

No godo in github?


Add version code back to version name

This was lost in 0b0edae2729a21372fc4be5c3cb2e25a979ca62f when moving the version handling script to use as a Gradle task. Initially it didn't have access to the version code, so I just dropped that from the version name. However, later I allowed passing the version code as an option to simplify generation of the version JSON file. Since the version code may be available, restore the -$version_code suffix in the version name if possible.

Works fine in 7.10.427 - QA pass.


RLS: 0.16.0

planning on a release on March 8/9. If any objections. pls comment.
@jorisvandenbossche @shoyer @TomAugspurger

:+1:

Do you mean final release? Because then I would vote for certainly having first a release candidate. But an rc by 8/9 march is OK.
I will also try to have a look at some issue to see if there are things I consider as blockers.

I don't really think we need an rc
this release -

on 2nd though. ok let's do a rc on sunday/monday. give us a bit more time to do the release.

In my first try I get a segfault, on Windows 64bit python 3.4, Winpython version using the pandas binary installer
statsmodels.graphics.tests.test_gofplots.TestTopLevel.test_qqplot_2samples_ProbPlotObjects ... alloc: invalid block:<PHONE_NUMBER>752D30: 40 25
(Still needs to be checked. I'm working on a new computer and I'm not fully setup yet, no other python or virtualenvs yet.)

@josef-pkt
these binary installers may not be 100% compat as I built them in kind of an odd way. (we actually distribute grohke whls.
can you give a try on 2.7.

@jreback   most likely false alarm
It now also crashing with pandas 0.15 (by just adding it back on the path), and I don't see any pandas involved in that test function. Another weird thing is that I can replicate the code test in the interpreter but get the segfault when I exit python.
I'm pretty sure that I ran the full statsmodels test suite before, but I might have messed up somewhere.

statsmodels master passes against 0.16.0rc1

also Ubuntu python-xy testing is using pandas 0.16.0 dev on one machine and all statsmodels tests pass.
https://launchpadlibrarian.net/200610490/buildlog_ubuntu-utopic-amd64.statsmodels_0.7.0~ppa27~revno-1841~ubuntu14.10.1_BUILDING.txt.gz

excellent thanks @bashtage and @josef-pkt
fyi I just uploaded some conda builds
conda install pandas -c pandas
will get you the latest (just windows ATM), I didn't upload the rest and binstar giving me issues

on winpython 3.4.3 32 bit, current stable statsmodels, pandas0.16.rc1
Python 3.4.3 (v3.4.3:9b73f1c3e601, Feb 24 2015, 22:43:06) [MSC v.1600 32 bit (Intel)] on win32
Type "copyright", "credits" or "license()" for more information.
>>> import statsmodels.api as sm;sm.test()
Running unit tests for statsmodels.__init__
NumPy version 1.9.2
NumPy is installed in D:\WinPython\basedir34\build\winpython-3.4.3\python-3.4.3\lib\site-packages\numpy
Python version 3.4.3 (v3.4.3:9b73f1c3e601, Feb 24 2015, 22:43:06) [MSC v.1600 32 bit (Intel)]
nose version 1.3.4
.......................................................................................................................S...S...S...........S........................................................................................................................................................................................................S...................................................................................................................................................................................................................................................................................................................................................Optimization terminated successfully.
         Current function value: 0.589409
         Iterations 5
................................................................................................................................................................................................
Warning (from warnings module):
  File "D:\WinPython\basedir34\build\winpython-3.4.3\python-3.4.3\lib\site-packages\statsmodels\genmod\tests\test_gee.py", line 1169
    df['constant'] = 1
SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy
..................................................................................................................................................................................................................................................................................
>>> ================================ RESTART ================================
>>>

@stonebig where did you get the installer for this?. The one on the pandas release may not be compat with this (as I think winpython packages them up slightly differently)

I got it from Christoh Gohlke http://www.lfd.uci.edu/~gohlke/pythonlibs/#pandas , March 13th 19h45 French Time

for the 64 bit version:
Python 3.4.3 (v3.4.3:9b73f1c3e601, Feb 24 2015, 22:44:40) [MSC v.1600 64 bit (AMD64)] on win32
Type "copyright", "credits" or "license()" for more information.
>>> import statsmodels.api as sm;sm.test()
Running unit tests for statsmodels.__init__
NumPy version 1.9.2
NumPy is installed in D:\WinPython\basedir34\buildFlavorRfull\winpython-3.4.3.amd64_build3\python-3.4.3.amd64\lib\site-packages\numpy
Python version 3.4.3 (v3.4.3:9b73f1c3e601, Feb 24 2015, 22:44:40) [MSC v.1600 64 bit (AMD64)]
nose version 1.3.4
.......................................................................................................................S...S...S...........S........................................................................................................................................
Warning (from warnings module):
  File "D:\WinPython\basedir34\buildFlavorRfull\winpython-3.4.3.amd64_build3\python-3.4.3.amd64\lib\site-packages\statsmodels\base\model.py", line 466
    "Check mle_retvals", ConvergenceWarning)
ConvergenceWarning: Maximum Likelihood optimization failed to converge. Check mle_retvals
................................................................S...................................................................................................................................................................................................................................................................................................................................................Optimization terminated successfully.
         Current function value: 0.589409
         Iterations 5
................................................................................................................................................................................................
Warning (from warnings module):
  File "D:\WinPython\basedir34\buildFlavorRfull\winpython-3.4.3.amd64_build3\python-3.4.3.amd64\lib\site-packages\statsmodels\genmod\tests\test_gee.py", line 1169
    df['constant'] = 1
SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy
..................................................................................................................................................................................................................................................................................
>>> ================================ RESTART ================================
>>>

didn't realize he packages them, oh ok.
so you'll have to be more specific on where it terminated (run with -v, to show all of the tests, maybe have to do that at the command line)

https://github.com/statsmodels/statsmodels/issues/2224
this and a label warning
It's fixed in master of statsmodels, and the incompatible code was in the unit tests, and I didn't see anything in the actual code
See @bashtage fix in https://github.com/statsmodels/statsmodels/pull/2260/files

sorry I don't catch what you mean by -v, can you write the whole command line that I should type on IDLE?

from the command line
nosetests -v statsmodels

ok, after what wrote @josef-pkt , you still need this -v test ? if so , on which one (32 ? 64 ?)

@stonebig or sm.test(verbose=3) then it shows the name of each test as it is run.
You got the same test_gee warning as in the statsmodels issue, no need to run verbose for it.

ok, let me know if you still need the sm.test(verbose=3) test. I understood that all is fixed in statsmodels master

0.16.0 is release, see here: https://groups.google.com/forum/#!topic/pydata/4KKZFpxS_4o
thanks to everyone for the hard work!

Thanks Jeff et. al! :tada:

Thank you Jeff!
On Mon, Mar 23, 2015 at 5:10 AM, Tom Augspurger<EMAIL_ADDRESS>wrote:

Thanks Jeff et. al! :tada:
Reply to this email directly or view it on GitHub:
https://github.com/pydata/pandas/issues/9598#issuecomment-84967222


ByteBufUtil.writeUtf8 and WrappedByteBuf

There is interesting comment:
// Maybe we could also check if we can unwrap() to access the wrapped buffer which
// may be an AbstractByteBuf. But this may be overkill so let us keep it simple for now.

But - simple HTTP server under load (like 5k req/sec) uses 38% time on String.getBytes. I use ByteBufUtil.writeUtf8 to write HTTP response (about 10Kb).
Please consider adding that check. Additional instanceof is cheap those days and do matter in some cases.
Well, I can try ByteBuf.unwrap() to get to AbstractByteBuf but is that safe?
Netty 4.0.32.Final, ResourceLeakDetector is on SIMPLE.

Will check

Am 03.10.2015 um 13:26 schrieb scf37<EMAIL_ADDRESS>There is interesting comment:
// Maybe we could also check if we can unwrap() to access the wrapped buffer which
// may be an AbstractByteBuf. But this may be overkill so let us keep it simple for now.
But - simple HTTP server under load (like 5k req/sec) uses 38% time on String.getBytes. I use ByteBufUtil.writeUtf8 to write HTTP response (about 10Kb).
Please consider adding that check. Additional instanceof is cheap those days and do matter in some cases.
Netty 4.0.32.Final, ResourceLeakDetector is on SIMPLE.
—
Reply to this email directly or view it on GitHub.

@scf37 can you show me your code and how this change would help you ?

Code is qute complex, but profiling via jmc states that writeUtf8 is the bottleneck.
How 20-30% improved performance would help me? Good question. Not even sure what to answer. May be I should stick with unwrap() hack, at least it is fast.
override def read(): Future[HttpContent] = {
  //reading by blocks of default socket buffer size
  val len = str.length

  if (readDone) {
    throw new IllegalStateException("Response.read() after EOF")
  }

  val size = Math.min(len - off, 65536)

  //netty internals use size * 3 to ensure buffer for utf-8 strings.
  //Set it as expected to avoid later resizing
  val buf = PooledByteBufAllocator.DEFAULT.ioBuffer(size * 3)

  //ByteBufUtil.writeUtf8 has fast path for WrappedByteBuf
  //unfortunately resource leak detector wraps it in WrappedByteBuf which is not detected
  //by writeUtf8
  //so, trying to unwraaaaap
  //see https://github.com/netty/netty/issues/4313
  val fastBuf = buf match {
    case buf: AbstractByteBuf => buf
    case buf if buf.unwrap().isInstanceOf[AbstractByteBuf] => buf.unwrap()
    case buf => buf
  }

  if (off == 0 && size == len) {
    ByteBufUtil.writeUtf8(fastBuf, str)
  } else {
    ByteBufUtil.writeUtf8(fastBuf, new CharSequenceView(str, off, size))
  }

  off += size

  if (off == len) {
    readDone = true
    Future successful new DefaultLastHttpContent(buf)
  } else {
    Future successful new DefaultHttpContent(buf)
  }
}

@scf37 ah got it! May I ask what  level for the leak detector you use ?

Default level. ResourceLeakDetector is on SIMPLE

@scf37 thanks... working on a patch.

@scf37 see #4345

@normanmaurer Assuming you are asking me to review. Done.

@scf37 replied to your comments


Define merkle trie interface

Description of the Change

Merkle trie interface is defined

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@507f54b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #51   +/-   ##
========================================
  Coverage          ?   75.8%
========================================
  Files             ?      76
  Lines             ?    2873
  Branches          ?       0
========================================
  Hits              ?    2178
  Misses            ?     695
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507f54b...b2ae6de. Read the comment docs.


Add HMR support

@andrewthauer This adds HMR support. It works in my local HMR configured app and on stackblitz.com (e.g. https://angular-9b55kc.stackblitz.io/).

@stevenkampen - Did you want to do a canary release of this fix and see which issues it fixes?


[QA-205] shorter domains

Changes Unknown when pulling 3ac25618e8d0ab40bf334f0363999f0683f22379 on fix/proper_domain into ** on master**.

:shipit:

A job will handle this PR ASAP on Jenkins

Rebase && testing in progress


DOCS-1372: Add support for Windows Server 2022

This PR is to
Product Version(s):
Calico OSS 3.26
Check with @coutinhop if the support to be extended to OSS 3.25 as well.
Issue:
https://tigera.atlassian.net/browse/DOCS-1372
Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Changes in this PR are addressed here. Closing this one.