FD_CLOSE, error 0, stream closes after 20-60 seconds with OBS

I hope someone can give me a tip or advice what could causing this, but I can't stream to my rtmp (newest nginx 1.13.0 + latest master) server (anymore), always getting this with OBS:
12:16:02: SO_SNDBUF was at 65536
12:16:03: RTMPPublisher::SocketLoop: Increasing send buffer to ISB 131072 (buffer: 0 / 528384)
12:16:05: RTMPPublisher::SocketLoop: Increasing send buffer to ISB 262144 (buffer: 0 / 528384)
12:16:53: RTMPPublisher::SocketLoop: Received FD_CLOSE, 7 ms since last send (buffer: 0 / 528384)
12:16:53: RTMPPublisher::SocketLoop: Aborting due to FD_CLOSE, error 0
12:16:53: FlushBufferedVideo: Flushing 46 packets over 750 ms
12:16:54: Total frames encoded: 3203, total frames duplicated: 0 (0.00%)
12:16:54: Total frames rendered: 3207, number of late frames: 1 (0.03%) (it's okay for some frames to be late)
12:16:54: Encoder closed

Doesn't  FD_CLOSE, error 0 mean the connection was closed by the server gracefully? What could cause this?
I don't really know why this is happening just randomly now, it worked before for months.
OBS studio logs say with same DCs happening:
13:04:42.514: [rtmp stream: 'adv_stream'] Connection to rtmp://***/live successful
13:04:42.519: ==== Streaming Start ===============================================
13:05:01.240: WriteN, RTMP send error 10053 (551 bytes)
13:05:01.240: WriteN, RTMP send error 10053 (61 bytes)
13:05:01.240: WriteN, RTMP send error 10038 (42 bytes)
13:05:01.240: [rtmp stream: 'adv_stream'] Disconnected from rtmp://***/live

My nginx config (though I havent changed anything in it):
#user nobody nogroup;
worker_processes  1;

#error_log  logs/error.log;
pid /run/nginx.pid;

events {
    worker_connections  1024;
}

http {
    include       mime.types;
    default_type  application/octet-stream;

    sendfile        on;
    keepalive_timeout  65;

    server {
        listen 8185;
        server_name localhost;

      	location / {
      	     allow <IP_ADDRESS>;
       	     deny all;
      	}

	      location /control {
	           allow <IP_ADDRESS>;
 	           deny all;

             rtmp_control all;
        }

        location /on_play {
	           allow <IP_ADDRESS>;
 	           deny all;

             if ($arg_p = "...") {
                return 200;
             }

	           #bad password
	           return 403;
        }

        location /on_publish {
            allow <IP_ADDRESS>;
 	          deny all;

            if ($arg_p = "...") {
                return 200;
            }

      	    #bad password
      	    return 403;
        }

	      location /hls {
            auth_basic "hls";
            auth_basic_user_file /etc/apache2/.htpasswd;

            # Serve HLS fragments
            types {
                application/vnd.apple.mpegurl m3u8;
                video/mp2t ts;
            }

            alias /tmp/hls;
            expires -1;
        }
    }
}

rtmp {
    server {
        listen 1935;
	      chunk_size 128;
	      ping 30s;

	      notify_method GET;
	      publish_time_fix off;

        application live {
            live on;
	          #record off;

            recorder rec1 {
               record all manual;
               #record_unique on;
               record_suffix -%d-%b-%y-%T.flv;
               #record_suffix _rec.flv;
               record_path /usr/local/nginx/tmp/Videos;
               record_unique on;
            }

      	    #hls
      	    hls on;
            hls_path /tmp/hls;
            hls_fragment 5s;

      	    allow publish all;
      	    allow play all;

            on_play http://localhost:8185/on_play;
            on_publish http://localhost:8185/on_publish;
        }

        # Video on demand
        application vod {
            on_play http://localhost:8185/on_play;
            play /usr/local/nginx/tmp/Videos;
        }
    }
}

Compiling the Nginx with the parameter "--with-debug" and specifying the "error_log" directive in the configuration file as "logs/error.log debug" may help you to find out that why the server closed the connection.

The log file becomes really big, about 8MB for a few seconds of stream, but this part is I think the time around something weird happens and it disconnects:
2017/05/07 19:33:01 [debug] 26105#0: *1 RTMP prep video (9) fmt=1 csid=7 timestamp=16 mlen=94 msid=1 nbufs=1
2017/05/07 19:33:01 [debug] 26105#0: *1 calling handler 3
2017/05/07 19:33:01 [debug] 26105#0: *1 hls: h264 NAL type=1, len=85
2017/05/07 19:33:01 [debug] 26105#0: *1 hls: video pts=1721970, dts=1719000
2017/05/07 19:33:01 [debug] 26105#0: *1 mpegts: pid=256, sid=224, pts=1721970, dts=1719000, key=0, size=94
2017/05/07 19:33:01 [debug] 26105#0: *1 mpegts: write 188 bytes
2017/05/07 19:33:01 [debug] 26105#0: *1 calling handler 4
2017/05/07 19:33:01 [debug] 26105#0: *1 recv: eof:0, avail:0
2017/05/07 19:33:01 [debug] 26105#0: timer delta: 12
2017/05/07 19:33:01 [debug] 26105#0: worker cycle
2017/05/07 19:33:01 [debug] 26105#0: epoll timer: 9756
2017/05/07 19:33:01 [notice] 26104#0: signal 15 (SIGTERM) received from 26129, exiting
2017/05/07 19:33:01 [debug] 26104#0: wake up, sigio 0
2017/05/07 19:33:01 [debug] 26104#0: child: 0 26105 e:0 t:0 d:0 r:1 j:0
2017/05/07 19:33:01 [debug] 26104#0: child: 1 26106 e:0 t:0 d:0 r:1 j:0
2017/05/07 19:33:01 [debug] 26104#0: termination cycle: 50
2017/05/07 19:33:01 [debug] 26104#0: sigsuspend
2017/05/07 19:33:01 [debug] 26105#0: epoll: fd:8 ev:0001 d:00007F5E523DA1E0
2017/05/07 19:33:01 [debug] 26105#0: channel handler
2017/05/07 19:33:01 [debug] 26105#0: channel: 32
2017/05/07 19:33:01 [debug] 26105#0: channel command: 4
2017/05/07 19:33:01 [debug] 26105#0: channel: -2
2017/05/07 19:33:01 [debug] 26105#0: timer delta: 2
2017/05/07 19:33:01 [notice] 26105#0: exiting
2017/05/07 19:33:01 [debug] 26105#0: flush files
2017/05/07 19:33:01 [debug] 26105#0: run cleanup:<PHONE_NUMBER>041CB0
2017/05/07 19:33:01 [debug] 26105#0: run cleanup:<PHONE_NUMBER>0390F8
2017/05/07 19:33:01 [debug] 26105#0: cleanup resolver
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>0589F0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>0569E0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>0549D0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>0529C0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>0509B0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>04E9A0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>04B980
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>048960
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>045940
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>02D740
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>027710
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>026650
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>025590
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>0244D0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>014250, unused: 0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>01D280, unused: 0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>028720, unused: 0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>02E750, unused: 0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>032760, unused: 0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>036770, unused: 0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>03A780, unused: 0
2017/05/07 19:33:01 [debug] 26105#0: free:<PHONE_NUMBER>03E790, unused: 2760
2017/05/07 19:33:01 [notice] 26105#0: exit
2017/05/07 19:33:01 [debug] 26106#0: epoll: fd:10 ev:0001 d:000000000105AE10
2017/05/07 19:33:01 [debug] 26106#0: channel handler
2017/05/07 19:33:01 [debug] 26106#0: channel: 32
2017/05/07 19:33:01 [debug] 26106#0: channel command: 4
2017/05/07 19:33:01 [debug] 26106#0: channel: -2
2017/05/07 19:33:01 [debug] 26106#0: timer delta: 6
2017/05/07 19:33:01 [notice] 26106#0: exiting
2017/05/07 19:33:01 [notice] 26104#0: signal 17 (SIGCHLD) received from 26105
2017/05/07 19:33:01 [notice] 26104#0: worker process 26105 exited with code 0
2017/05/07 19:33:01 [debug] 26104#0: shmtx forced unlock
2017/05/07 19:33:01 [notice] 26104#0: cache manager process 26106 exited with code 0
2017/05/07 19:33:01 [debug] 26104#0: shmtx forced unlock
2017/05/07 19:33:01 [debug] 26104#0: wake up, sigio 3
2017/05/07 19:33:01 [debug] 26104#0: reap children
2017/05/07 19:33:01 [debug] 26104#0: child: 0 26105 e:1 t:1 d:0 r:1 j:0
2017/05/07 19:33:01 [debug] 26104#0: child: 1 26106 e:1 t:1 d:0 r:1 j:0
2017/05/07 19:33:01 [notice] 26104#0: exit
2017/05/07 19:33:01 [debug] 26104#0: close listening <IP_ADDRESS>:8185 #6
2017/05/07 19:33:01 [debug] 26104#0: close listening <IP_ADDRESS>:1935 #7
2017/05/07 19:33:01 [debug] 26104#0: run cleanup:<PHONE_NUMBER>0390F8
2017/05/07 19:33:01 [debug] 26104#0: cleanup resolver

That's the reason.
It seemed that the worker worked fine and then received the SIGTERM signal from master or some other processes, it's confused!

But where does the SIGTERM come from, and why? The server worked fined just about a week ago, it's an Ubuntu 16.04.2 LTS, and I havent even updated or changed anything of the Nginx libs/executable since then.

Here is my init.d script, I use, if it helps anything:
#!/bin/sh

### BEGIN INIT INFO
# Provides:	  nginx
# Required-Start:    $local_fs $remote_fs $network $syslog $named
# Required-Stop:     $local_fs $remote_fs $network $syslog $named
# Default-Start:     2 3 4 5
# Default-Stop:      0 1 6
# Short-Description: starts the nginx web server
# Description:       starts nginx using start-stop-daemon
### END INIT INFO

PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
DAEMON=/usr/local/nginx/sbin/nginx
NAME=nginx
DESC=nginx

# Include nginx defaults if available
if [ -f /etc/default/nginx ]; then
	. /etc/default/nginx
fi

test -x $DAEMON || exit 0

set -e

. /lib/lsb/init-functions

PID=$(awk -F'[ ;]' '/[^#]pid/ {print $2}' /usr/local/nginx/conf/nginx.conf)
if [ -z "$PID" ]
then
  PID=/run/nginx.pid
fi

# Check if the ULIMIT is set in /etc/default/nginx
if [ -n "$ULIMIT" ]; then
  # Set the ulimits
  ulimit $ULIMIT
fi

test_nginx_config() {
		$DAEMON -t $DAEMON_OPTS >/dev/null 2>&1
		retvar=$?
		if [ $retvar -ne 0 ]
		then
			exit $retvar
		fi
}

start() {
		start-stop-daemon --start --quiet --pidfile $PID \
			--retry 5 --exec $DAEMON --oknodo -- $DAEMON_OPTS
}

stop() {
		start-stop-daemon --stop --quiet --pidfile $PID \
			--retry 5 --oknodo --exec $DAEMON
}

case "$1" in
	start)
		test_nginx_config
		log_daemon_msg "Starting $DESC" "$NAME"
		start
		log_end_msg $?
		;;

	stop)
		log_daemon_msg "Stopping $DESC" "$NAME"
		stop
		log_end_msg $?
		;;

	restart|force-reload)
		test_nginx_config
		log_daemon_msg "Restarting $DESC" "$NAME"
		stop
		sleep 1
		start
		log_end_msg $?
		;;

	reload)
		test_nginx_config
		log_daemon_msg "Reloading $DESC configuration" "$NAME"
		start-stop-daemon --stop --signal HUP --quiet --pidfile $PID \
			--oknodo --exec $DAEMON
		log_end_msg $?
		;;

	configtest|testconfig)
		log_daemon_msg "Testing $DESC configuration"
		if test_nginx_config; then
			log_daemon_msg "$NAME"
		else
			exit $?
		fi
		log_end_msg $?
		;;

	status)
		status_of_proc -p $PID "$DAEMON" nginx
		;;

	*)
		echo "Usage: $NAME {start|stop|restart|reload|force-reload|status|configtest}" >&2
		exit 1
		;;
esac

exit 0

I also just compile with "./configure --add-module=../nginx-rtmp-module-master" nothing special.

Hi, I have no idea about who sent the signal, it was very likely to be the master. A possible clue that I've found is that worker consumed the huge memory and then the OOM-KILLER was triggered.

Why doesn't the log tell anything about what triggered the kill signal? If it came from nginx itself it should be in the logs, no? Memory is no issue the server (VPS) has 1gb and just uses about 250mb all the time.

You can see /var/log/messages, maybe OOM-KILLER sent the signal to the master and then the master to the worker, same as we do kill -TERM pid_of_the_master_of_nginx.


Update circle cic test script

@thewtex @fbudin69500
This patch is for the dashboard branch. Thanks!

LGTM

This changes should be good to go into the dashboard branch.

Thanks. Merged to dashboard.


current_line_blame has no effect in config

I feel like maybe I'm seeing the opposite of #218 😅 no matter what current_line_blame is set to, it never actually shows. It works fine when I run :Gitsigns toggle_current_line_blame though. My config is just this:
require("gitsigns").setup {
    current_line_blame = true,
}

Oh, maybe had something weird caches. Ran :PackerSync and that seemed to resolve it (despite not seeing any updates to the plugin in Packer's output but.... 🤷🏼 ). Closing this out.


Adding A Custom Death Sound Option[REQ]

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
I personally believe that custom death sounds would be a good feature for Blox Strap, it would be more of a quality of life feature overall, but it would also be extremely nice for you(as in the user) to be able to use a custom death sound on roblox.

just replace the ouch.ogg file in %LocalAppData%\Bloxstrap\Modifications\ go into the sounds folder then replace the ouch.ogg

^
https://github.com/pizzaboxer/bloxstrap/wiki/Adding-custom-mods
If you're talking about making it easier to do so, I agree, we plan to make that happen soon.


guide: external data updates

and other related updates

@jorgeorpinel what is the scope, goal of this PR? can we split it if there are many changes?

All the changes are related the way I see it @shcheklein . The goal was to update the external data docs: https://dvc.org/doc/user-guide/external-dependencies and https://dvc.org/doc/user-guide/managing-external-data which were incomplete and outdated. Theres 2 more files that have small updates directly related to the changes in the aforementioned x deps/outs docs.

Thanks Ivan! Well, I'm going to merge this but lmk about making details sections or a summary of the comments in each H3 (that's kind of repetitive though) and I'll add it to the next PR (coming up).


Misc typo

This line in 4. above: create variable to hold the value.
should be: create a variable to hold the value.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 468329f8-220b-8b83-65f1-3c30f434ddff
Version Independent ID: a686c89c-7411-10c0-13ef-4ef78259e6bd
Content: How to: Use Streams to Write to Text Files - Dynamics NAV
Content Source: dynamics-nav/How-to--Use-Streams-to-Write-to-Text-Files.md
Product: dynamics-nav-2018
GitHub Login: @jswymer

Thanks for the feedback. The typo has been fixed and an updated article will be published soon.


Migrate to DSE 5

May need an LB for OpsCenter

In progress.  There's some issue with the updated scripts causing nodes to fail.

Complete.


feat(browser): add browser for ctor options

w/ protractor its a legit usecase to have multiple browser instances,
however PixDiff was not able to handle that before this patch, because
it was always using the protractor defined global browser instance

see this page for protractor-using-multiple-browsers-in-the-same-test

Tests are breaking for me on master too. :/ (jshint / unit is passing both on master and on this branch)


not able to use version 2.0.1 because I have to work with resource files name start with '$' sign

after updating java2smali to version 2.0.1 I was not able to do my work. it's giving me Error: '$' is not a valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
on version 1.6 I was able to use the plugin by adding
lintOptions {
        abortOnError false
}

to my build.gradle. but on the latest version it does not work and giving me the error for resource names

Hi @infahash,
could you provide a sample project that leads to your error?

It's available on any of decompiled app (XCIPTV app for example). While using resources from decompiled app new version always fails because of resources name error I mentioned

The plugin only works when the module or project of the Java/Kotlin file you try to compile to smali can be build.
I assume that you also cannot regularly build the decompiled project?

yes. I know. When works on some big projects I have to keep decompiled smali in one project, and making java code on another project. resources are synced between both. so there are a few or many files start with $ sign. while those files on java project the new version of plugin always failed and works fine when I downgrade.


Make  more reusable

Which package is this issue related to?
ffe-radio-button-react
Describe your issue (screenshots welcome!)
I'm implementing the following design:

The challenge here is that I want to use ffe-form-react's <InputGroup /> component, so that I can pass in a <Tooltip /> component (the question mark to the right). Unfortunately, <RadioSwitch /> (or more precisely <RadioButtonGroup /> provides its own input group implementation, which doesn't support stuff like error messages etc.
I don't want to nest ffe-input-groups either, so I'm kind of stuck in a place where I have to re-implement the <RadioSwitch /> component to fit the needs of my design. Not a good developer experience.
The way I see it, <RadioButtonGroup /> does too much. <RadioSwitch /> could benefit from a simplified API as well. The entire package is honestly up for a good ol' rewrite.
What is the expected behavior?
I'd like the <RadioButtonGroup /> to only handle the logic of which radio button is selected, and let me compose the rest.
My end goal is to put a <RadioSwitch /> inside of a <InputGroup /> component, and have it work nicely together.
What is the actual behavior?
What I require is not possible. I cannot easily insert a tooltip into the label of a <RadioSwitch />

Also noticed how incredibly convoluted the RadioBase is as well - including a custom implementation of Tooltips and what not. Rewrite is coming ^^


Required configurations changes for Redcentric express route

Redcentric Express route is in place and going to replace open Test VPN. There are OpenTest specific environment variables used in MHS docker images. Please share the required configuration changes we need when we use RedCentric Express Route.

This is something supplied by NHS and must be requested when onboarding. I will feedback that NHS should update their documentation.


Keyboard shortcuts for running query (Selected and all)

Is your feature request related to a problem? Please describe.
Hello just found this app a few days ago, and I think it is amazing. I think this request builds on #359, and will be a productivity boost if there was a keyboard shortcut to run current query.
Describe the solution you'd like
One of the shortcuts I thought would be useful is Ctrl+Enter for running selected query, and I believe less important is Ctrl+Shift+Enter for running the all the queries in the current tab.
Additional context
Also it would be great if the current query could be run without selecting it. For example the VSCode extension SQLTools does this
Screencast from 07-08-22 20:48:45.webm
Note that I am not selecting the query manually, the extension seems to detect the current query based on where my cursor is positioned (maybe using ; as the delimiter). And i am pressing Ctrl+Enter to go through the queries.

Hi @apaudel96,
by now the shortcut to run selected query, or all, is F5.
Regarding a shortcut to run current query based on the cursor may be a useful and pretty easy implementation, so i will add this request to roadmap.
I'm just working on a feature to allow users to see, edit, add or delete shortcuts. After that i will add new events to bound with shortcuts.

Thats great to hear. Thanks for all the hard work.


ZIO 2 version

How to build this branch in Scala 3? I get errors

How to build this branch in Scala 3? I get errors

What kind of errors? As you can see the CI builds the Scala 3 version as well: https://github.com/coralogix/zio-k8s/runs/7436082295?check_suite_focus=true

Think I've worked it out
sbt ++3.1.0 clean zio-k8s-client/compile zio-k8s-client/publishLocal

Merging the ZIO 2 branch, current state of master captured onto a new zio1 branch.


Something wrong with SyncBN

When I try to run voc detection training with command lines
python train_net.py --config-file configs/pascal_voc_R_50_C4_24k_moco.yaml  --num-gpus 4 MODEL.WEIGHTS ./output.pkl, it ran out of memory on 4 GTX 2080Ti (11G).
I think it makes no sense since the original pascal_voc_R_50_C4_24k_moco in detectron2 only takes about 7.5G per GPU. I found that the only difference between them lies in RESNETS.NORM, which is set to FrozenBN in detectron2 while SyncBN for moco.
I tried to change it to FrozenBN and the memory footprint looks good except that the loss turns to Nan after 30~40 iterations. Only after decreasing the lr from 0.2 to 0.05 can it maintain training stability. I am not sure why the SyncBN will add large amount of memory expense. Whether the training stability is caused by removing the SyncBN? Any help will be appreciated. Thanks.

I am not sure why the SyncBN will add large amount of memory expense

because SyncBN needs to be trained and needs to save activations for backprop

Whether the training stability is caused by removing the SyncBN

discussed in sec 4.2 of the paper, using SyncBN helps us fine-tune the model without worrying about tuning the learning rate.
You can try scale down batch size & learning rate to run on GPUs with limited memory.


Add InvalidType to analyzer and use it to suppress follow-on errors

Currently, when analyzing erroneous code for which a type can't be determined, the analyzer assumes a type of dynamic.  So for example, in the code below, the misspelling of String on line (1) causes the type of s to be dynamic, so there is no follow-on error on lines (2) or (3).
void f(String _) {}
main() {
  Strqing s = 'foo'; // (1)
  print(s.length); // (2)
  f(s); // (3)
}

However, using a type of dynamic doesn't suppress all follow-on errors.  For instance, in the example above, if --no-implicit-casts is enabled, then dynamic is no longer assignable to other types, so a follow-on error appears at (3): The argument type 'dynamic' can't be assigned to the parameter type 'String'
Furthermore, follow-on errors that aren't related to assignment are not suppressed; for example, in the following code:
class Base {
  void f(Strqing x) {} // (1)
}
class Derived extends Base {
  void f(String x) {} // (2)
}

the misspelling at (1) causes a follow-on error at (2): 'Derived.f' ('(String) → void') isn't a valid override of 'Base.f' ('(dynamic) → void').
We believe we can avoid these problems by introducing a new type InvalidType to the analyzer's type system.  It will only be created when analyzing user code for which an error has already been reported; therefore it can be used as a signal that no further related errors need to be reported.  So for example, we can cause isSubtypeOf to return true when either of its arguments is an InvalidType, and that would suppress the follow-on errors described above.

This "P1 high" issue at the build system would be greatly alleviated by an InvalidType in the analyzer: https://github.com/dart-lang/build/issues/295

This could also pave a path for de-duplication or improved messaging for unknown default parameter value: https://github.com/dart-lang/sdk/issues/26710

We can also not report COULD_NOT_INFER when the types involved include an InvalidType: https://github.com/dart-lang/sdk/issues/35828

Here's another issue which this would unblock: https://github.com/dart-lang/sdk/issues/23037

https://dart-review.googlesource.com/c/sdk/+/300181

InvalidType was added, which fixes the original issue.
Many linked issues were also fixed with additional following CLs.


how do embed fiber for c/c++?

I notice  that matz have added fiber  in mruby, and I want to known how do embed fiber for c/c++?
Thanks!

what are the API limitations preventing a function like mruby_fiber_new() from being written?

@matz
what are the API limitations preventing a function like mruby_fiber_new() from being written?

Just because Fiber execution cannot cross C function boundary. If you have implementation idea, let me know.

@matz
Does that mean that mruby code running inside a fiber cannot call into C at all? Is this is a similar issue to Lua's coroutines being unable to yield across the C boundary?
My use-case, essentially, is event-driven green threading. I would like to be able to suspend a Fiber which calls a blocking function (implemented in C) and then resume it when the result of that operation is available again.

This means you cannot switch context within C function, except for mrb_fiber_yield at return. And this is similar situation to Lua's coroutine. In fact, mruby's fiber is implemented very similar way to Lua.
I think it's possible to implement event-driven (non preemptive) green threads by combination of fibers and return mrb_fiber_yield(...).

Yeah, that's my suspicion too. What I can't figure out is, once I've yielded from a fiber, how do I resume that fiber later? Is that something I'll need to do in mruby instead of being able to do it from C?

Here's Lua example:
int prim_read(lua_State *L)
{
  if (nothing_to_read())
    return lua_yield(L, 0);
  lua_pushstring(L, read_some_data());
  return 1;
}

function read()
  local line
  repeat
    line = prim_read()
  until line
  return line
end

If there's nothing to read, lua_yield passes control to other fiber.  When it resumed prim_read will return with resumed value. You might need a counterpart of Lua's lua_yieldk() (yield with continuation function). If so tell me.  I will seriously consider adding that function.

From looking at a few of the libuv lua bindings, it looks like I'd need a counterpart to lua_resume(). The continuation functions may be useful too, but I think the yield/resume pair is the big thing I need.

I added mrb_fiber_resume in 0609abb

Oh hey, thanks! I'll get to work and flesh out my code, and will let you know how things work out.

prototype definition of mrb_fiber_resume?

Ah, I forgot.

To truly have fibers that can yield through the C boundary, we would have to implement fibers/coroutines in C. This cannot be done in pure ANSI C, but there are several platform-dependant ways in which this can work. See http://cvs.schmorp.de/libcoro/coro.h for an example of the wide range of possibilities.
Alternatively, a mruby_fiber_yield_with_continuation (or maybe mruby_fiber_yieldk) would be very useful to help work around the issue.


TextBox cropping WTF: is this a regression?! :-o

Amazingly, even though I've added the pretty self-evident fix of reducing the width to its proper size:
sf::Vector2f pos = getAbsolutePosition();
auto width = max (0.f, getSize().x - 2 * Theme::borderSize - 2 * Theme::PADDING); // glScissor will fail if < 0!
glScissor(
    (GLint)(pos.x + Theme::borderSize + Theme::PADDING),
    (GLint)(ctx.target.getSize().y - (pos.y + getSize().y)),
    (GLsizei)width,
    (GLsizei)getSize().y
);

...it wasn't there in the original, and yet, it never failed this way! :-ooo


3.0 Version of org chart

Breaking changes

Fixed typo in chart state property name, so neightbourMargin became neighbourMargin
Attached property  _directSubordinates now only shows nodes which are visible, if we want to also see get info about nodes hidden because of paging, we can use _directSubordinatesPaging

New Features

Added paging feature for nodes with many horizontal children
Node count is now visible by default

Improvements

Added new examples to showcase every distinct feature
Wrote more about the usage of the org chart and the functionality behind
Made Styled Tree example safari safe
Examples now are using the better-structured dataset
Made it easier to reliably override node expand & collapse button HTML
Made it easier to reliably override link path command generation algorithm
Zoom event notifications

Checks

[ ] Check that #221 PR is incorporated into this PR
[ ] Check that #222  PR is incorporated into this PR

👏🏼

Greetings.
Is native lazy loading (https://github.com/bumbeishvili/org-chart/issues/147) still planned / being considered?

It's planned but treat it as an idea only, I don't expect to have it done on the near future unless I will have an org-chart project involving that particular feature

@bumbeishvili
what do you think of adding a search button near the pagination button ? When you click a node it adds it immediately to the shown list.
The pic is so bad but something like this would be perfect along with the pagination system. This way we can show only the data we want.

Idea is interesting, but I am against it, since that UX does not seem familiar and will add additional burden which is not necessary.

That said it might make sense to expose methods which lets you control the node content and behavior for the show next 5 nodes button.
This way anyone will actually be able to implement the same functionality as in your image

I think it is necessary. Lets say the root has 50 person, and I want to show spesific 3 person under it to examine.

That said it might make sense to expose methods which lets you control the node content and behavior for the show next 5 nodes button. This way anyone will actually be able to implement the same functionality as in your image

That would be nice. I would add a dropdown button/menu which has the direct subordinates, and the selected ones would be shown in the chart.

Yep, good idea. I will keep it in mind and can get to it    If I find time outside my full time job and paid side projects , probably not for another 4-6 months


fix: copy flow types to where flow can find them

Fixes #554
I wasn't able to figure out how to rename a file while copying with cpx, so I renamed the source file instead. Hope this is ok.
Tested with node 10 latest by running yarn build:

Thanks for doing this! Will merge and a release should appear soon automatically

:tada: This PR is included in version 6.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: Adding backend interfaces support to CNS

Reason for Change:

This feature adds backend interfaces support to CNS
Issue Fixed:

Requirements:
CNS should be able to return back with PnPId to CNI with ipconfigs response.
CNS should be able to determine the PnPID based on the macaddress.

[ ] uses conventional commit messages

[ *] includes documentation
https://microsoft.sharepoint.com/:w:/t/Aznet/EQI_uDcvkwRDkjBX4X2yZo4BTkGR5g55ttvupXYG_TfC6Q?e=o8iR2s
[ ] adds unit tests
[ ] relevant PR labels added

Notes:

@shreyashastantram can you hit the Resolve conversation if the issue discussed in that conversation has been resolved, make the PR less clutter, thanks 🙂

/azp run Azure Container Networking PR


Switch from idle callback to post task.

Issue #149

This looks good to merge, but has a conflict now after the other merges.


pinned tab can not move the position

In the old version, I can use mouse to change the pinned tab positon. But the new version, it doesn't work. The stable version can move but not work, the autopush version can not move.

Yup we're aware of the issue and will be fixing it before we roll autopush to canary/stable. @stevegolton

Hi @AlphaZhang1990,
Thanks for catching this!
A fix will land on autopush shortly, which will roll out to canary today or tomorrow.
I'll look into cherry-picking it for stable.


doc: remove use of XXX in example descriptions

tickgit.com identifies XXX as label for TODO's. There is no need to
list the digest hash examples in the TODO list, so  replace the XXX
and YYY examples with XYZ and ZYX.
Signed-off-by: Niels de Vos<EMAIL_ADDRESS>

@mergifyio queue


Fix MSVC-32 CI

Unfortunately panicking isn't implemented just yet, so these need to be ignored
there for now.

(may want to wait for the green light on CI before merging)

Ah, right, I knew that but completely forgot! Thanks!


fix get OS on some of the windows computers

At least on my laptop, $(OS) returns Windows instead of Windows_NT. So I try to fix it.

Codecov Report

Merging #16007 (4e15dcc) into main (b4d1059) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main   #16007      +/-   ##
==========================================
+ Coverage   44.02%   44.05%   +0.02%
==========================================
  Files         682      682
  Lines       82407    82412       +5
==========================================
+ Hits        36282    36307      +25
+ Misses      40218    40205      -13
+ Partials     5907     5900       -7

Impacted Files
Coverage Δ

modules/auth/sso/reverseproxy.go
8.51% <0.00%> (ø)

services/repository/generate.go
0.00% <0.00%> (ø)

modules/web/middleware/cookie.go
64.65% <66.66%> (+7.75%)
:arrow_up:

modules/markup/markdown/goldmark.go
58.84% <70.00%> (+0.62%)
:arrow_up:

modules/auth/sso/basic.go
44.64% <100.00%> (ø)

modules/auth/sso/sso.go
36.66% <100.00%> (ø)

modules/markup/sanitizer.go
88.88% <100.00%> (ø)

modules/setting/indexer.go
91.42% <100.00%> (ø)

modules/setting/queue.go
67.92% <100.00%> (ø)

routers/repo/pull.go
31.15% <100.00%> (+0.07%)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39e79d...4e15dcc. Read the comment docs.


v-if on template stops custom directive hooks from being called

Version
3.2.31
Reproduction link
jsfiddle.net
Steps to reproduce
Define an element with <template v-if="true" v-custom /> where v-custom simply logs directive hooks. Observe that with the v-if present, no hooks are called. Removing the v-if causes the hooks to be called again.
What is expected?
The directive hooks should run as normal regardless of the presence of the v-if.
What is actually happening?
The hooks are not called.

The fiddle I've linked includes a number of other combinations looking for potential workarounds. None of them work as I expect when using the template tag. Based on my understanding:

example 1 turns on and off as expected, however the directive hooks do not run
example 2 runs the directive hooks, however the content is not rendered
example 3 runs the directive hooks, however the content is not rendered
example 4 does not render the content
example 5 works totally as expected (with a p tag)

Examples 2 through 4 appear to render as <template>#document-fragment.... Example 1 however renders the inner content and drops the wrapping template tag, which is what I'd expect of examples 2 through 4 as well.

<template> elements with v-ifon them are not rendered as actual elements, they serve as virtual wrappers to use a one v-if on a group of elements.
Since they are not rendered as elements, you can't use directives on them.

Ok, so a <template> with a v-if is handled specially by Vue, and there is no way get a genuine <template> tag to conditionally render.
Thank you. This explains the results of my tests, however I do like it breaks my expectations of the framework.

here is no way get a genuine <template> tag to conditionally render.

That's incorrect. You can of course nest two template elements to achieve what you wanted to do with one.
<template v-if="condition">
  <template v-custom>
    whatever
  </template>
</template>


Normalised competition scores are only updated upon task change

The ScoreboardsUpdatable is no longer 'stateful', i.e., I removed the dirty flag and instead, scoreboards are updated at a fixed interval (5 seconds).
I see the following argument for this approach: The dirty flags intention is to prevent superfluous updates to save resources. However, at the time resources need to be saved (when a task is running), this flag will be true all the time anyway, because it needs to be triggered by every submission. The only time the flag is false is when resources are not an issue (in between tasks). So we might as well remove it.

While I get the argument, from a user-experience point of view, this is a step in the wrong direction. The 5 second delay might be just long enough for people to be no longer able to associate their actions with the resulting changes. This is especially the case when there are several submissions in a sort time window. The update interval in the backend should be aligned with the update interval in the frontend in order to avoid inconsistent intermediate states.

I have my doubts that users will notice. But of course we can reduce the timeout.
In order to achieve what you want, however, we'll have to move to sub-second update interval. This then begs the question, why we don't just generate these scoreboards on the fly.

We might as well do that. If that takes too long, we can still add a very short-term caching mechanism.

Reopen this issue since it's still an issue

This has been addressed by rewriting the Scorer and Scoreboard subsystem:

Scorers are generally stateless and calculate scores on the fly upon invocation (with the exception of the CachingTaskScorer).
All (stateful) Scoreboards and the CachingTaskScorer now have a 'dirty' flag that triggers re-calculation for the next invocation.
Every time there is a change to DbAnswerSet, the Scorer of that task and all Scoreboards are marked as dirty. Here we use the TransientStoreSessionListener mechanism provided by Xodus DNQ.
ScoreUpdateable and ScoreboardUpdateable have been removed.


Upgrade to v2.4.0 of the AzureAD Terraform Provider

Fixes: #190
Fixes: #193
Fixes: #195

I'll add a note the changelog before release that the property has been renamed - that's the issue


glDrawElements causes GL_INVALID_OPERATION on Mac OS X

Here's an excerpt:
./miners -a conti miners
OpenGL version: 4.1 INTEL-10.24.45
GLSL version: 4.10
Vendor: Intel Inc.
Renderer: Intel HD Graphics 4000 OpenGL Engine
Loading file miners
aspect: 1.33333 (800x600)
read 639264 bytes
#points: 45871
aspect: 1.33333 (800x600)
OpenGL Error 1282
OpenGL Error 1282
OpenGL Error 1282
...SNIP

Using glDrawArrays works without issue but is very far from optimal.
Problem has been happening ever since https://github.com/fenollp/miners/compare/9868865...607a0cf.

Of course, the OpenGL profiler https://developer.apple.com/library/content/technotes/tn2178/_index.html
supports up to osx 10.11 https://developer.apple.com/download/more/?=graphics
which either crashes the app or plain doesn't work, even with https://forums.developer.apple.com/message/204679
It looks great when it works though http://gawdzik.net/2014/12/07/debugging-opengl.html


Additional model metadata

We need to write a JSON file containing additional metadata for Ollama models. Helpful information as if the model is multimodal cannot directly be retrieved using Ollama API as far as I know, that means we would have to deal with model families making things much more complex. Knowing if the model is multimodal would enable us to conditionally allow to add images as message attachments therefore reducing user confusion. Other less important infos I would like to add are: model creator, number of push and pulls of the model

We could fetch additional information from the ollama homepage.
The search API is producing a list of models it looks like this https://ollama.com/library?q=searchterm
Unfortunately that produces html which we would have to parse. There is no json search API.
For each model there is a own page like this one
https://ollama.com/library/llama3:70b
with a standardized section/table which contains additional model metdata. Unfortunately also that page does not list if a model is mulitmodal or what features it supports. That is only mentioned in the descriptive text.

Yes, I asked that yesterday on the ollama Discord server and they confirmed this. However I still wonder how the ollama executable checks whether a model exists or not if there is no library API

There are updates on the topic. See here on Discord


[Event Request] Codeunit 6501 - f(x) AssistEditTrackingNo

Hi!
We need an additional event before the RetrieveLookupData call in f(x) AssistEditTrackingNo in the Item Tracking Data Collection codeunit. We need the IsHandled pattern to be included.

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Please continue to update

Such a good plug-in Why not update the ah? can you continue to update ?

Haven't updated it mostly due to personal time constraints, but because I haven't explored the new version elasticsearch. Will investigate and hope I'll find the time.

@fadion it is great plug-in. Kindly continue to update.

Thanks @fadion for he plug-in I have made fork of your plug-in made little changes to support Elasticsearch 6.x and Laravel 5.6. Here is the package I hope it helps someone https://github.com/vikram0460/ElasticLaravel


Investigate the possibility of having ports for Next.js and Storybook configurable from cookiecutter

Added in https://github.com/Frojd/Wagtail-Pipit/commit/26059615e61943aacbcba2f2c94894de3e8dabd3


Using Inject with ReSwift

Hi, I am a big fan of the Hot reloading helper Inject. I was testing ReSwift with the CounterExample app, refactoring the UI layer to use a programmatic approach instead of storyboard. When updating the UI and saving (cmd + s), I am getting:
Thread 1: EXC_BAD_ACCESS (code=1, address=0x0) at that line

You can check the recording video.
I forked the Example repo so anyone can reproduce the error here.
Not sure if it is best to raise the issue here or on the Inject repo but I have been using Inject for a while without ReSwift without issues.
Thank you.

@florianldt Did you find out anything helpful in the meantime about the issue?


Remove extra padding

I love this PR because since day 1 I've always customized the padding (and needed to recompile workspacer everytime it updates).
However, a padding set to an empty string ("") instead of with a space (" ") leads to this behavior:
https://user-images.githubusercontent.com/68158964/123742181-d3570680-d8dd-11eb-927c-4b1493f2e8ce.mp4
because of an inconsistency in line 88 of WorkspaceWidget.cs:
 return visible ? LeftPadding + workspace.Name + RightPadding : $" {workspace.Name} ";
If both padding variables are "", then once you focus on a workspace its length shrinks on the bar.
I would've liked to submit a fix myself, but I'm still not comfortable with Git and programming in general.
Originally posted by @lauverityhill in https://github.com/workspacer/workspacer/issues/215#issuecomment-870251212

@lauverityhill would #224 fix your issue?


Feature freeze / testing

Every feature we add adds uncertainty and potential regressions. Therefore, in order to get to a beta release, we need to stop adding any more features and focus instead on testing.
Here are ways you can help:

Try to integrate the minifier in your project
Find bugs and reduce them to test cases for a given package and send a PR
(If you can fix the bug with your PR but a test case is better than nothing)
Look at existing PRs and issues and either fix or add related test cases

Yay! Did itbshio


Cant open X display

When I change the config of ly it doesn't change and Can't open X display show. I use git version on Debian

Hi.
Are there any logs of X, what config did you change, Debian "bookworm" I'm guessing, what is the Desktop Environment

Hi.
Are there any logs of X, what config did you change, Debian "bookworm" I'm guessing, what is the Desktop Environment

I am using awesome wm debian 12 , I changed the etc one that is referred to it in the github page qnd when I type ly in the terminal my configuration is applied but when i enter in the login the background is 100%black(not like the one in the ly default bg ) and in the password section it says Cant open X display. I will send yu the log of X when I open my computer


Modularity of core

So I was investigating flowdock/markdown-it-flowdock#3 and it would appear that markdown-it (and so is marked package with a false "hit") is handling _emphasis_ markdown syntax first then that package is failing with a "miss" since it is a post operation.
Hopefully not presuming too much... I can possibly see some logic alternatives to fix this:

Add a priority parameter somewhere that says "do this plugin before the core" ... I'm only a few days into in-depth checking this project out so thanks for your patience if this already exists. Still may present as an issue with anchor tags with textContent.
Refactor with a breaking change the core of this project to have all core markdown parsing handled as individual plugins... so that we can use them in whatever priority we choose. Still may present as an issue with anchor tags with textContent.
As a last resort we can blacklist _ and we already blacklist * ... this may break other sites if adopted and definitely going to confuse all users including ours when I go around and renaming their account with an announcement.

Any thoughts on this from this upstream here and downstream there?

https://markdown-it.github.io/markdown-it/#Ruler
You already can inject your plugin rules before/after some. Anything wrong with that?

Anything wrong with that?

Maybe... the core, which is this project, processes @_foo_ first and converts it to @foo which renders as @foo ... then the mentioned plugin incorrectly handles it and does foo which renders as (simulated on GH as they have the same issue) foo... e.g. if we could get the plugins to be able to execute first then have the core of this project it might handle it a little better with keeping the underscores intact with the issued username.
I guess better questions:

Can a plugin developer tell markdown-it to postpone handling its own built-in plugins until the third-party finishes first?
Does the core markdown-it name every "process" (say emphasis, strong, tables, etc)?

I appreciate your feedback as I'm still learning how to assist others with their plugins and perhaps writing one myself. :)

Can a plugin developer tell markdown-it to postpone handling its own built-in plugins until the third-party finishes first?

No. You need to inject your plugin with more high proirity than existing one to consume such content.

Does the core markdown-it name every "process" (say emphasis, strong, tables, etc)?

Yes.

Does the core markdown-it name every "process" (say emphasis, strong, tables, etc)?
Yes

So I might be able to change the priority of the core to be later then... e.g. postponing? (getting my terminology in sync with yours here)
Alright... I'll do some twiddling after the holiday here and see if I can get that plugins issue fixed as it's nearly exactly what we're looking for. I'd rather not blacklist _ from our usernames on our production site is the main reason. It seems that referenced plugins development just stopped a while back. I don't like using CSS content to modify things not to mention that plugin doesn't actually set the href yet.
If it's alright with you can I keep this issue open? I'll scour over the API very soon and see if my objective, and the reporters too, can be achieved.

I'd prefer to close it, because such common issues without clear resolution have tendency to be "endless". It's better to create a new one when needed. I think, after digging code, docs & existing plugins in npm, the number of your question will decrease significantly.

One trick of the trade is to use HTML entities too... so the flowdock plugin might be able to set the href textContent to an entity.

It's better to create a new token with separate renderer.

Alright.... plenty to "chew" on here... closing... Thanks for your assistance. :)


github-actions :: switch to LTS supported release-action

Use https://github.com/marketplace/actions/create-release to create a gitHub release based on the input tag. Also set to auto create release notes.

Worked on my fork: https://github.com/cfkoehler/emissary/actions/runs/11382362212/job/31665702670
Run ncipollo/release-action@v1
  with:
    tag: 8.15.0
    name: 8.15.0
    generateReleaseNotes: true
    makeLatest: true
    draft: false
    prerelease: false
    omitBody: false
    omitBodyDuringUpdate: false
    omitDraftDuringUpdate: false
    omitName: false
    omitNameDuringUpdate: false
    omitPrereleaseDuringUpdate: false
    removeArtifacts: false
    replacesArtifacts: true
    skipIfReleaseExists: false
    token: ***
    updateOnlyUnreleased: false
  env:
    JAVA_VERSION: 11
    JAVA_DISTRIBUTION: corretto
    MAVEN_OPTS: -Dhttps.protocols=TLSv1.[2](https://github.com/cfkoehler/emissary/actions/runs/11382362212/job/31665702670#step:10:2) -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf[4](https://github.com/cfkoehler/emissary/actions/runs/11382362212/job/31665702670#step:10:4)jMavenTransferListener=WARN -Djava.awt.headless=true
    RELEASE_VERSION: 8.1[5](https://github.com/cfkoehler/emissary/actions/runs/11382362212/job/31665702670#step:10:5).0
    JAVA_HOME: /opt/hostedtoolcache/Java_Corretto_jdk/11.0.25-9.1/x[6](https://github.com/cfkoehler/emissary/actions/runs/11382362212/job/31665702670#step:10:6)4
    JAVA_HOME_11_X64: /opt/hostedtoolcache/Java_Corretto_jdk/11.0.25-[9](https://github.com/cfkoehler/emissary/actions/runs/11382362212/job/31665702670#step:10:9).1/x64
    GITHUB_TOKEN: ***
    ```

@cfkoehler is it possible to see the generated release notes in your fork?  I see the 8.15.0 release has a changelog, is that the generated release notes?

@cfkoehler is it possible to see the generated release notes in your fork? I see the 8.15.0 release has a changelog, is that the generated release notes?

https://github.com/cfkoehler/emissary/releases/tag/8.15.0


Allow using numpad for zoom shortcuts in the 2D/code editors

This behavior is consistent with GIMP. This also helps work around issues with non-QWERTY keyboard layouts, as the numpad should work regardless of the keyboard layout. See https://github.com/godotengine/godot/issues/45747.

Thanks!


inference.py 中的model.train() 应该是model.eval()吧

Hi, Thanks for pointing out this issue! I just pushed a commit to fix this problem.


Subscribe to all Palindrom error callbacks

Done in https://github.com/Palindrom/palindrom-polymer-client/pull/50.


hello , run into a trouble

why can in new directory , but in dist directory exception is thrown

Given that there isn't very much information about your setup, I can only guess as to what's the problem. The best I can come up with is that your ignore settings ignored the file that's specified in your main key in package.json.
If you require more assistance, you'll likely be able to get more people to help you at one of the community sites. There aren't that many people looking at this issue tracker to answer questions.

@malept  thanks a lot , very very very good... sure enough is this problem.


Feature Idea: hierarchical dropping

I am thinking about a feature in my product, that needs "hierarchical dropping" (sorry couldn't find a better name).
If you drop (sufficiently) over an item, it will have the result that the item will be dropped in that item (like dropping a file on a folder).
Is there anyone also interested in that feature as well? Or does anyone have an idea how to accomplish this without changing the library? Happy to hear your thoughts!

I've found this library: https://github.com/primetwig/react-nestable
Not as sexy as this one, but handles hierarchical dropping

Sorry to jump in here a bit late, but I'd also recommend this library: https://github.com/atlassian/react-beautiful-dnd
It's pretty sexy (they were pretentious enough to add "beautiful" to the repo name, soo....). But it looks like it handles "hierarchical dropping". In the example you can have items move between groups but also reorder those groups. That feature seems like it would satisfy your requirement.
And it's supported by Atlassian, so won't go away any time soon! I still like this repo because the API is much easier to use for simple use cases, but if you need something more complex, then check out react-beautiful-dnd!

This isn't something I'm planning on supporting in the future, check out the libraries mentioned above if you're looking for this type of feature.


bug: Invalid id response value

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When the JSON-RPC "id" is a string, the service at relay.walletconnect.com replies with the corresponding integer value.
This could confuse some walletConnect client, as they expect the exact same id in the reply, to associate with the query.
Expected Behavior
As stated by the JSON-RPC standard :
The Server MUST reply with the same value in the Response object if included. This member is used to correlate the context between the two objects.
Steps To Reproduce
Send a JSON-RPC request with a string (from an integer).
Example:
-> {"jsonrpc":"2.0","id":"2","method":"irn_subscribe","params":{"topic":"648c3584817b016fc96a14085a6a8054cdca65466d805f65598a28f3cb5ec5bf"}}
Message received : {"id":2,"jsonrpc":"2.0","error":{"code":-32602,"message":"Request validation error: Invalid request ID"}}

Notice the "2" (string) is converted to 2 (number).
Environment
All? The interface is the socket.

Relevant log output
DEBUG:pywalletconnect.client:WalletConnect message sending to relay : {"jsonrpc":"2.0","id":"2","method":"irn_subscribe","params":{"topic":"648c3584817b016fc96a14085a6a8054cdca65466d805f65598a28f3cb5ec5bf"}}
DEBUG:pywalletconnect.client_v2irn:Waiting for Topic subcription ack.
DEBUG:pywalletconnect.websocket:WebSocket Text message received : {"id":2,"jsonrpc":"2.0","error":{"code":-32602,"message":"Request validation error: Invalid request ID"}}
D

Anything else?
In the case this behavior is a deviation needed for walletConnect, I propose that the server rejects all id when it's a string. Also this change in JSON-RPC must be duly documented at the relevant place in the WC standard.

Thx. Docs out of date. This is the wrong repo though so closing. https://github.com/WalletConnect/rpc-proxy/issues/171


Edit icon for link name translates very far away upon long name

Ref: #3409
If a label decoration is added to a node or link and it is made into a single line label, when a very long label is entered that exceeds the number of pixels specified in the width for the label, the edit icon gets pushed to end of where the label would display if it was not truncated.

For example if the following specification is used for a label decoration:
[
  {
    "id": "123",
    "label": "Craig",
    "position": "bottomLeft",
    "x_pos": 30,
    "y_pos": 30,
    "label_editable": true,
    "label_single_line": true,
    "width": 50,
    "height": 20
  }
]

When the edit icon first appears it is like this:

However after entering the text "Craig is a great developer" the result is like this:

Fixed to look like this after the edit:


hil: ota: use 1 Hz polling for reason and state test

Use 1 Hz polling in pytest to catch reason and state changes more efficiently.
This removes an arbitrary delay, instead trying multiple times to get the device's reported reason and state codes. On the final timeout, the asserts will always be run so we retain helpful logging messages. This PR also reduces the device delay by 3 seconds, which equates to 30 seconds saved across all reason codes.

Changes look good! Can we run the test a few times to see how stable it is?

Changes look good! Can we run the test a few times to see how stable it is?

I ran the entire suite twice (once with original PR and once last night on a force-push) and it passed both times. I ran the nsim-integration and linux-integration just now and those passed as well.


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Ankita Puri

Discord Username(if exists):

Additional Context: Youtube

:nerd_face:

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


[WIP] DJ Fixes for V8 update

"the SetHiddenPrototype method no longer exists, its been replaced by that RemovePrototype" says DJ


Change of token logo neccessary

Due to borders within the original image, the logo didn't look good when cropped in a circle. Please exchange for new version.

Could it be because you already have an image with the same name in the repository? In that case, I'd like to ask you to delete that and use the new one. I can't solve the conflicts as I have no write permissions to the repo.
I'm not using git that often with images; sorry if I broke something :-S

No worries updated it manually! You are good now!

Thanks! Nice working with you guys :)


doc: fix jsregexp install example

Just a small PR for an issue I found when installing this plugin! Let me know if anything needs to be changed.

No changes required :D
TY!!


Godot 4 ReflectionProbes are much glossier than default sky reflection

Godot version
v4.1.3.stable.official [f06b6836a]
System information
Godot v4.1.3.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4060 Laptop GPU (NVIDIA; <IP_ADDRESS>13) - 13th Gen Intel(R) Core(TM) i7-13620H (16 Threads)
Issue description
Godot 4 ReflectionProbes are glossier than default sky reflection, so when you turn one on and off, the sky reflection becomes glossier when on, and rougher when off

The sphere has a roughness of 0.4, ReflectionProbe OFF, sky looks correct

Reflection probe ON, sky and nearby cube is way too clear
Compared to godot 3, which is consistent

Reflection probe OFF

Reflection probe ON, nearby cube looks blurry enough
Steps to reproduce
Create a sphere with metallic 1 and moderate roughness (0.2-0.5)
Create a ReflectionProbe
Minimal reproduction project
Godot 4:
reflectionprobe test 4.zip
Godot 3:
reflectionprobe test 3.zip

I can confirm this on 4.2.rc 066e7d483.
Decreasing Reflection Size to 32 in the Project Settings then restarting the editor will get you closer to the sky radiance look (especially when the sky update mode in Environment is set to Real-Time), but it'll still look noticeably different.


Fix issue with BtcReleaseClientStorageSynchronizer

The Syncronizer should accept as many release_requested events from a single rsk tx hash as possible.
Improve btcReleaseClient performance
Add fix and test to cover issue

pipeline:run

pipeline:run

pipeline:run

LGTM.

Closing as this will be included in 3.2.0


memory error during import

Creating an import with tagging for 16 columns with a 4-field tag-template caused the Cloud-Run instance to crash, with an exceeded 512M memory error

Fixed


Feature: ES6

Hey David,
thank you very much for your great library.
How about switching to ES6 syntax? This would make the code way more easier to read and to maintain.
I suggest the following features:

import, export statements
class declaration
const, let for variables
template strings for class names

I would also create some extra wrappers for AMD, CommonJS and jQuery which allows all options without shipping unnecessary code.
ES6 import statements would allow to use tree shaking with e.g. rollup to reduce the filesize over all if some features are not needed.
If you like I could help you with some of these implementations. I am very open to hear you opinion on this one.

Hi! Thanks for this issue.
Officially, Infinite Scroll v3 supports IE 11. It's current market share is 3.5% globally, 6% in the US. When it drops to close to 1% (maybe in 1.5-2 years), I'll start looking at a major v4 update to start using ES6 features.

On this note, I don't see adopting ES6 as a big step forward for browser-based JS like Metafizzy libraries. There are some clearly great features (template strings, arrow functions instead of .bind( this )). But otherwise, implementing ES6 would clean up some code, at some complexity.
Consider that in order to implement a feature like import, it would require transpiling the codebase. Whereas right now I can easily debug the actual source code by running it directly in any browser. That direct application makes it the code so accessible. Not only can I debug it easier, but other users have that same access without having to know anything about its build process. I value that accessibility a lot.
So I'm open to it down the road. But for now, Infinite Scroll v3 is ES5. I'm closing this issue, but I appreciate getting the conversation started. ES6 will come soon enough!

@desandro Thank you David for your feeback.
I absolutely get your optionion, I had the same thought a couple of times before.
At the current state of browser support I would use a transpiler like babel to make sure the code is compatible with older browsers which only support ES5. Yes this would make the overall filesize a bit bigger but won't have that much impact if you are using some more libraries which use ES6 as well.
Fortunately modern browsers do support import on <script type="module"></script> which allows you to easily debug your source code in the browser. For all other browsers you could use sourcemaps to get a reference from your compiled code to your source code.
My prefered way to use technology is using the latest features and include a shim for older browsers. This way your code will always be ahead of time and modern browsers which so support newer features will benefit from that.
If you are changing your plan in the future, feel free to hit me up and I will help you as best as I can.
Cheers


create btp kafka by btp operate in  canary https://canary.cockpit.btp.int.sap/

ENV:  BTP canary.  https://canary.cockpit.btp.int.sap/
Error:
Message:               BrokerError:PublicEndpointsNotSupported, Status: 400, Description: Public endpoints for clusters are not yet supported in this landscape
the Yaml file:
apiVersion: services.cloud.sap.com/v1
kind: ServiceInstance
metadata:
name: canary-kafka
namespace: kafka
spec:
serviceOfferingName: kafka
servicePlanName: standard
externalName: canary-kafka
parameters:
public_ip: true
allow_access: "x.x.x.x"

Hi @minggongcheng
From the error message it seems like what you are trying to do is not supported, anyway this error is returned from the kafka broker and is not related to the BTP operator, please consult with the kafka team.
Thanks


Implements the feature request in issue #7408

Fixes #7408

The query builder is an assembler, not a data structure to be queried: please refrain from using it as such, and instead rely on the DQL AST if you really must introspect DQL.


Extract bboxes for detection

Hi,
is there a simple way to extract the bounding boxes that are used for the detection task? I've already found the function getGroundTruthBoxes(...) and the file classMapping40.mat but I haven't found the class mapping for the 20 classes you used for detection yet. Could you please give me a hint?

Hi, have you soved this problem?


Approve Budget and Fund fails after wallet factory reset

Reset the wallet using the factory reset: https://xstate-wallet.statechannels.org/factory-reset
Ensure xstate-wallet.statechannels.org is in your metamask connections:

Go to https://web3torrent.statechannels.org/upload/ and attempt to upload a file.
(Note: this also works with clicking 'Create Budget' from the budget screen)
See error:

messaging.ts:269 Uncaught (in promise) Error: No selected destination
    at convertToInternalEvent$ (messaging.ts:269)
    at tryCatch (runtime.js:45)
    at Generator.invoke [as _invoke] (runtime.js:264)
    at Generator.forEach.te.<computed> [as next] (runtime.js:98)
    at tryCatch (runtime.js:45)
    at invoke (runtime.js:137)
    at runtime.js:147

I suspect this is due to wiping out the wallet indexDB but still have the wallet in the metamask connections. The enableEthereum workflow won't run since ethereum.enabled is already true for the wallet domain so destinationAddress never gets set and is always null.

I think this might be a common enough scenario that users will run into, so we should probably fix this.


SSL certificate of https://docs.scipy.org/doc/scipy/ is expired

Hi,
Not sure if this is the right place to report this, but I found that the SSL certificate used on https://docs.scipy.org/doc/scipy/ is expired.
Reproduction:

Navigate to https://docs.scipy.org/doc/scipy/
Observe error message about invalid certificate:

Duplicate of #80

Thanks @maarten-ic for reporting.


Issue 207

Edwin and Jens, could you two please review this pull request for me ASAP since the refactoring will be clumsy if other branches start seeing lots of changes.
Ideally I would like for Jens to run the branch and review the UI on the home page and the admin stats pages, and for Edwin to do the code review (unless Jens you want to do that too).
You should not need to go to the admin/stats page and hit the regenerate button the first time as I added code to check and generate if its not been done

@liefeld @edwin5588
I have made some changes to the branch to

capture slight classification naming differences from legacy projects
include viral amps
do not count samples from the "Unclassified" group, as these are non-amplified samples
adjust table styling slightly

Tested with my updates (including the regeneration button) and works well locally. I am fine for @edwin5588 to merge (testing optional).


Move aiohttp_cors from src to toplevel directory

fix min required python version to 3.4.1 also

I see that this is a fix for #3 .
@asvetlov, do you have plans to do some work on aiohttp_cors right now?
Because I've planned to fix this issue too (with tests, docs etc), but a little later (around closest weekend) and if you don't need aiohttp_cors right now I would suggest to wait for me.

Sure, I can wait.
I don't need CORS support for my project in near future but like to see aiottp_cors finally released.

I merged this branch in PR #6 v0.1.0 branch.


Why use gumbel softmax before sampling actions?

Hi, I want to use OpenMatch to reproduce results of ReinfoSelect, and I found that you add gumbel softmax before sampling step, while in original code repository  of the paper there is no such gumbel softmax. I can't understand the purpose of adding the Gumbel Softmax here, could you explain it to me?

Both softmax and gumbel softmax are suitable for reinfoselect. I change the vanilla softmax to gumbel softmax because the probability distribution is smooth. Thus, using gumbel softmax can make the selection probability more shape.


flip shown to true for server-timing

This feature hadn't been enabled yet because the support data had not yet been reviewed. Have just done some extra research on server timing and updated the data (notable Firefox support has been added)


HttpError

I am getting an HTTPError while trying to run the Notion sync.  Can you please help me understand what is happening and if there is a workaround for it?

Since this repo is not being actively maintained (Unfortunately my current employer is not on Notion), it's going to be pretty hard for me to help you. If there is any chance of me helping you, you would have to give me a lot more information. If you're asking for help on the internet make sure you include the full stack trace (as text, not a screenshot so people can copy segments and also so it's searchable so other people with the same problem can find it) and also include your setup and inputs.

Thank you so much for your response. My apologies I didn't include much
information, I assumed since you have made it like a GitHub automation, any
issues must be very easy to understand since they will always be
reproducible and more widespread, as compared to making software which
people would download. You seem to have devised a fix for the error and
then reverted it back for some reason (#5
https://github.com/NarekA/git-notion/pull/5 reverts #3
https://github.com/NarekA/git-notion/pull/3). Here
https://github.com/APratham/git-notion/actions/runs/3728297478/jobs/6323176059
is the complete Workflow run, do you think that's helpful? I haven't done
anything, just cloned your repo and added my credentials. If there were a
problem with them, I would have got a different error, but whatever I do, I
seem to be getting the same error:
https://github.com/APratham/git-notion/actions. Do you think you can
help me?
[image: image.png]
On Wed, Dec 21, 2022 at 11:34 PM Narek Amirbekian @.***>
wrote:

Since this repo is not being actively maintained (Unfortunately my current
employer is not on Notion), it's going to be pretty hard for me to help
you. If there is any chance of me helping you, you would have to give me a
lot more information. If you're asking for help on the internet make sure
you include the full stack trace (as text, not a screenshot so people can
copy segments and also so it's searchable so other people with the same
problem can find it) and also include your setup and inputs.
—
Reply to this email directly, view it on GitHub
https://github.com/NarekA/git-notion/issues/9#issuecomment-1361780526,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH53RBTUDONXEW6ACNVSO3DWONBENANCNFSM6AAAAAATCP3FQM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Not able to select input channel 2 in Focusrite Scarlett solo 3rd gen

I have Focusrite Scarlett Solo 3rd Gen as my  audio interface. It uses Input channel 2 as Instrument input. It is not possible to select input channel 2 in NAM Standalone GUI. Please add this feature.

I do have the same problem with the arturia minifuse 2. Only channel 1 works for NAM standalone and channel 2's volume seems too low.

I do have the same problem with audio ìnterface Terratec Phase 22

Same problem here :( Input device is just Scarlet Solo USB without input 1 or 2.

Same with M AUDUO SOLO.

This should be fixed with #166 and will be available in v0.7.3.

Bad news I'm afraid: the fix breaks support for folks with single-input interfaces.
It's a tough call, but I've reverted the fix for this. I'll have to ask folks to continue to sit tight on this one while we work on getting the right fix in.

Would it be too messy to have to builds for the time being?

Would it be too messy to have two builds for the time being?

I've strongly considered it.
The reason that tipped me to the "no" side is that it'd open me up to potentially a whole other source of bugs to have to field, and it might be especially hard to get folks to provide the needed information (which version they're using). I just don't think I could handle it.

Would it be too messy to have two builds for the time being?

I've strongly considered it.
The reason that tipped me to the "no" side is that it'd open me up to potentially a whole other source of bugs to have to field, and it might be especially hard to get folks to provide the needed information (which version they're using). I just don't think I could handle it.

Fair enough, I just thought I'd ask.

I should have come here first .. lol.. yep.. same problem with ONLY the standalone version of NAM... within Reaper you can specify input #2 ... thanks for everything @sdatkinson

I can see you've identified the problem and a solution is incoming, but I'll add my interface to the list in case it matters in some way.  Steinburg UR12.

this is an iPlug2 bug, please add the iplug2 label!

this is an iPlug2 bug, please add the iplug2 label!

Does that mean that Steven can't really do anything about this issue?

@jonlinnarson kind of.
Technically, I could fix the problem in iPlug2. On one hand, I'm not an expert in the framework; on the other hand, I can reproduce this Issue myself, which makes a huge difference in how hard it is to figure out what to do about it! 🙂

Yes, that's really unfortunate. I have a Yamaha AG03 which has an hi-Z instrument input on channel 2 and it cannot be selected. I have also entered another issue on iplug2's preferences dialog a few minutes ago.

FYI: I'm working on fixing the standalone app I/O here: https://github.com/iPlug2/iPlug2/tree/app/flexible-io

@olilarkin if you have a PR you're mid-through, can you open so I can fork and help write tests/debugs .etc?

Any news on that problem?

No

From: Enrico Stragiotti @.>
Sent: Monday, October 21, 2024 12:06 AM
To: sdatkinson/NeuralAmpModelerPlugin @.>
Cc: seve54 @.>; Comment @.>
Subject: Re: [sdatkinson/NeuralAmpModelerPlugin] Standalone can only use interface's input 1 for mono input (Issue #157)
Any news on that problem?
—
Reply to this email directly, view it on GitHubhttps://github.com/sdatkinson/NeuralAmpModelerPlugin/issues/157#issuecomment-2425248312, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASLSAXST3NAQWTLZAXISKATZ4QSOLAVCNFSM6AAAAABQI5CIUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRVGI2DQMZRGI.
You are receiving this because you commented.Message ID: @.***>

+1 on getting a fix from me.  I have the Tascam 16x8 interface and port 1 in an XLR input.  1/4" inputs don't start until 9.


New Cassandra schema may create hot spots

Hi, I just pulled the recent code, and while it's great to see an upgrade from thrift-based schema in Cassandra to proper CQL, wouldn't the new schema create hot spots by not using the previous bucketing technique?  For example, the new schema for indexing spans by service name
CREATE TABLE zipkin.service_name_index (
    service_name text,
    ts timestamp,
    trace_id bigint,
    PRIMARY KEY (service_name, ts)

The service_name here serves as the row key, so for a heavily loaded service ALL spans will be hitting a single partition. The previous implementation was adding a random bucket number 1-10 to the service name, so that the inserts were uniformly distributed across 10 nodes, at the cost of having to do 10 queries when reading by service name. The previous bucketing would be roughly equivalent to this new schema:
CREATE TABLE zipkin.service_name_index (
    service_name text,
    bucket tinyint,
    ts timestamp,
    trace_id bigint,
    PRIMARY KEY ((service_name, bucket), ts)

Another observation - before the upgrade the Zipkin code has a -D switch to control the number of buckets, such that setting that param to 1 bucket would've been equivalent to the current/new schema. If we extend the schema as suggested above, people will have an option to use or not use the bucketing, with little overhead if they don't want to use it.

Indeed there will be hot spots on the service_name in this table.
That there was bucketing happening before I definitely missed.

bucketCount and "zipkin.store.cassie.indexBuckets", as you mention defaulted to ten previously.

it's pretty much in all tables, e.g. annotations_index for standard annotations like cs/cr/ss/sr will be always hitting row key "${serviceName}:${annotation}". The old code was using BucketedColumnFamily for most of the tables.

yes. thanks for spotting this. i'll have a fix out in the next hour or so.

also, if we go for a dedicated bucket column included in the composite row key, I would suggest changing the schema for annotations_index. Right now it is stored as a composite string ${serviceName}:${annotation} [:$annotationValue]. I would suggest the following schema instead:
CREATE TABLE IF NOT EXISTS zipkin.annotations_index (
    service_name      string,
    annotation_name   string,
    annotation_value  blob, -- optional for non-binary annotations.
    bucket_no      tinyint,
    ts             timestamp,
    trace_id       bigint,
    PRIMARY KEY ((service_name, annotation_name, annotation_value, bucket_no), ts)
)

that would be a separate ticket @yurishkuro
i looked into that while doing the related pull request, but because there's a blob there i left it for now. in a later pull request i'd like to remove all the blobs so we have a completely transparent schema.

at least keeping the bucket number as a separate column would be useful to start with.

@yurishkuro you want to take a look at that pull request for us?

Looks good, just missing the schema change for service_name table.

i really don't think bucketing will help for service_name.
and while we get hot partitions there, beyond "tombstones" (old writes), each partition only ever has one column. it might be smarter to change the compaction to LeveledCompactionStrategy rather than bucketing. i also added a comment in the code regarding caching writes, since this table is going to see basically just duplicated writes going to it.

I agree, bucketing doesn't seem particularly helpful for service names. But the pull request does contain code to use buckets for this table, so I was pointing out to mismatch with the schema. Maybe undo the code change for this table?

noooooo, where? :-)
(might be easier to write those comments against the code lines in the PR)

sorry. my bad, got tripped by the column name. Good to go!

@michaelsembwever when do you plan to merge this?
I've tested with my collector (written in Go), the new schema works well.

it's merged


Merging with the other 'kernel-modules' cookbook

Hey everyone,
We definitely should merge our 2 cookbooks: https://github.com/criteo-cookbooks/kernel-modules since you only support Debian based distributions and we support Rhel distribution, don't you think?
Regards,
JM

Any love, about this request?

I would love to see this happen as well if the Shopify folks are cool with that.

@jmauro The latest version of this cookbook (1.1.1) now supports Debian/Ubuntu/Fedora/Suse/RHEL. We've moved this cookbook over to our org with the intention of shipping this resource in Chef 15. Let me know if you think we're missing anything, but the InSpec tests make it look like it's working everywhere.

Sound great @tas50 will then deprecates our cookbook then.
Regards,
JM


How to add static pages with external css

@jakubsta
I need help with few things.
Things to finish:

Resolve app.js conflict
In /communities the 'Add your token' should trigger Intercom
Video launch
Video exit
When the video's launched the scroll should be disabled


[Bug] Chunking is missing some text from bullet section

Search before asking

[X] I searched the issues and found no similar issues.

Component
Other
What happened + What you expected to happen
Example pdf file earth.pdf is transformed using pdf2parquet.  This one is parsing the document correctly.
pdf2parquet output
But chunking is missing some text from last section.
Last segment
Basic facts about Earth:
• Distance from the Sun: Average of 149.6 million kilometers (93 million
miles)
• Rotation Period: 24 hours (one day)
• Moons: One moon, called Luna or simply “the Moon”.

Chunking output
Earth
· Distance from the Sun: Average of 149.6 million kilometers (93 million miles)
· Rotation Period: 24 hours (one day)

Note how the last bullet item is missing
chunking output
Reproduction script
code to reproduce : https://github.com/sujee/data-prep-kit-examples/blob/main/dpk-intro/dpk_intro_1_python.ipynb
Anything else
could be issue with bullets segment or last item on the page?
OS
Ubuntu
Python
3.11.x
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

not happening in dev3 release.  closing for now


feat(react-apollo): add SignIn with Apple

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (85723d7) 86.84% compared to head (6e61dce) 86.84%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2353   +/-   ##
=======================================
  Coverage   86.84%   86.84%
=======================================
  Files          85       85
  Lines        9352     9352
  Branches      495      495
=======================================
  Hits         8122     8122
  Misses       1230     1230

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG] Recurring backup job stuck if interrupted by powering down the node

Describe the bug
The job for backup stuck forever if the attached node to the volume is power down for sometimes.
To Reproduce
Steps to reproduce the behavior:

Create a volume, attach to a pod.
Enable recurring backup job for every 5 mins.
Write 1 GB to the data.
Scale down the pod.
When the scheduled recurring job attaches the volume to a node (Auto attach to node). Power down the node where the volume is attached.
Once the longhorn UI start showing the 'power down' icon for volume. Power it on.
The job stuck in running state forever and volume continues to be attached to the node.

Expected behavior
There should retry to complete the backup or time out for the failure.
Log
time="2020-10-14T22:10:57Z" level=info msg="Automatically attach volume volume-test-2 to node khush-test-lh-wk2"
time="2020-10-14T22:11:00Z" level=info msg="Volume volume-test-2 is in state attached"
time="2020-10-14T22:11:00Z" level=info msg="Running recurring backup for volume volume-test-2"
time="2020-10-14T22:11:08Z" level=debug msg="Creating backup , current progress 1"
time="2020-10-14T22:11:13Z" level=debug msg="Creating backup , current progress 1"

longhorn-support-bundle_500d104c-4b30-4a34-9d25-cd191662eb8e_2020-10-14T22-30-21Z.zip
Volume name - volume-test-2
Time - "2020-10-14T22:15:13Z
Environment:

Longhorn version: longhorn-master 10/13/2020
Kubernetes version: 1.18.9
Node OS type and version: ubuntu 18.04

Additional Context
If only the job is triggered on another node from the volume is attached to, this issue is reproducible.

@khushboo-rancher can you check if it's the same if the volume is already attached and working, then the node down happens during recurring backup in progress?

In the case of the volume attached to a pod, I observed the recurring job always got scheduled on the same node as the volume attached to. So when the node went down, the job became an unknown state and then failed. The next backup worked fine if the pod moved to another node or after I powered on the node.
I tried node scheduling in rancher for the recurring job, seems like it didn't work.

In fact we're removing the associated node ID for the pod #1796 . So it will be a problem once we removed the node limitation.

Reproduce:
Case 1: Volume is using by workload pod

Write 1GB to the volume
Create a recurring backup job that runs every 3 mins
Wait until the recurring backup job start (check its log), kill engine manager pod of the volume's engine.
The recurring backup job stuck running start forever. No future recurring job is run in the future.

Case 1: Volume is in detached state

Write 1GB to the volume
Detach the volume
Create a recurring backup job that runs every 3 mins
Wait until the recurring backup job start (check its log), kill the engine manager pod of the volume's engine.
The recurring backup job stuck running start forever and volume remains to attach to the wrong node which prevents any workload from using it.

Manual Test Steps:
Case 1: Volume is using by workload pod

Write 1GB to the volume
Create a recurring backup job that runs every 3 mins
Wait until the recurring backup job start (check its log), kill the engine manager pod of the volume's engine.
Verify the recurring backup job is canceled and the next time it runs, everything goes back to normal.

Case 1: Volume is in detached state

Write 1GB to the volume
Detach the volume
Create a recurring backup job that runs every 3 mins
Wait until the recurring backup job start (check its log), kill the engine manager pod of the volume's engine.
Verify the recurring backup job is canceled but the volume remains to attach to the wrong node which prevents any workload from using it.

We created a sperate issue (https://github.com/longhorn/longhorn/issues/1922) for the auto reattachment problem mentioned in case 2 in the manual test plan

Verified with longhorn-master 11/02/2020
Validation - Scenario 1 worked. In case of scenarios 2 and 3, the cron job stuck.
Below scenarios are tested.
Sceanrio-1 - Node is powered down and powered on later.

Enable Allow Recurring Job While Volume Is Detached.
Attach a volume to pod of a statefulSet, write data into it and set a recurring backup.
Detach from the pod by scaling down the statefulSet.
The attached node to volume is power down when the recurring job backup was in progress.
The recurring job remains in running state.
The node is switched on.
The corn job becomes unavailable and a new job got created which completes the backup successfully.
Verified the data by restoring the backup.

Sceanrio-2 - Node is powered down and remains powered down.

Enable Allow Recurring Job While Volume Is Detached
Attach a volume to pod of a statefulSet, write data into it and set a recurring backup.
Detach from the pod by scaling down the statefulSet.
The attached node to volume is power down when the recurring job backup was in progress.
The recurring job stucks in running state with the same progress.

Sceanrio-2 - Node is powered down and volume detached manually.

Enable Allow Recurring Job While Volume Is Detached
Attach a volume to pod of a statefulSet, write data into it and set a recurring backup.
Detach from the pod by scaling down the statefulSet.
The attached node to volume is power down when the recurring job backup was in progress.
The volume is manually detached.
The recurring job stucks in running state with the same progress.

Verified with longhorn-master - 11/06/2020
Validation - Pass
The below scenarios are tested.
Scenario 1- Allow Recurring Job While Volume Is Detached disabled, pod detached, node powered down.

Create a volume, attach to a pod, and write 800 Mi data into it.
Set a recurring job. Scale down the pod to 0.
No auto attachment is observed

Scenario 2- Allow Recurring Job While Volume Is Detached disabled, pod attached, node powered down.

Create a volume, attach to a pod, and write 800 Mi data into it.
Set a recurring job.
While the recurring job is in progress, scale down the pod to 0
Volume first detached and cron job gets completed saying unable to complete the backup.
Volume again gets auto attached to another node and cron job gets recreated.
After backup completion, the volume gets detached.

Scenario 3- Allow Recurring Job While Volume Is Detached enabled, pod attached, node powered down.

Enable Allow Recurring Job While Volume Is Detached
Create a volume, attach to a pod, and write 800 Mi data into it.
Set a recurring job.
While the recurring job is in progress, scale down the pod to 0
Volume first detached and cron job gets completed saying unable to complete the backup.
Volume again gets auto attached to another node and cron job gets recreated.
After backup completion, the volume gets detached.

Sceanrio-4 - Cron job and volume attached to same node, Node is powered down and volume detached manually.

Enable Allow Recurring Job While Volume Is Detached
Attach a volume to pod of a statefulSet, write data into it and set a recurring backup.
Detach from the pod by scaling down the statefulSet.
The attached node to volume is power down when the recurring job backup was in progress.
The volume is manually detached while the cron job remains in unknown state.
The cron remains in unknown state for about 7 mins and then another pod gets created
Volume get attached to another node and once the job is completed, volume gets detached.

Sceanrio-5 - Cron job and volume attached to different node, Node is powered down. (Reported scenario)

Enable Allow Recurring Job While Volume Is Detached
Attach a volume to pod of a statefulSet, write data into it and set a recurring backup.
Detach from the pod by scaling down the statefulSet.
The attached node to volume is power down when the recurring job backup was in progress.
Another cron job pod gets created with logs in the previous pod as below

time="2020-11-09T07:39:10Z" level=info msg="Automatically attach volume volume-test-2 to node node-1"
time="2020-11-09T07:39:12Z" level=info msg="Volume volume-test-2 is in state attached"
time="2020-11-09T07:39:12Z" level=info msg="Running recurring backup for volume volume-test-2"
time="2020-11-09T07:39:22Z" level=debug msg="Creating backup , current progress 0"
time="2020-11-09T07:39:27Z" level=debug msg="Creating backup , current progress 4"
time="2020-11-09T07:39:32Z" level=debug msg="Creating backup , current progress 6"
time="2020-11-09T07:39:37Z" level=debug msg="Creating backup , current progress 8"
time="2020-11-09T07:39:42Z" level=debug msg="Creating backup , current progress 10"
time="2020-11-09T07:39:47Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:39:52Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:39:57Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:02Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:07Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:12Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:17Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:22Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:27Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:32Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:37Z" level=debug msg="Creating backup , current progress 11"
time="2020-11-09T07:40:42Z" level=info msg="Automatically detach the volume volume-test-2"

Volume get attached to another node and once the job is completed, volume gets detached.


[REQUIRED 1.15.0] revert TLS workaround when 1.15.0 images are available

Signed-off-by: Kevin Earls<EMAIL_ADDRESS>Merge this once 1.15.0 images are available

This should probably be out of draft now, right ?

@jpkrohling I think so, will take a look next week.

@kevinearls is this still relevant?

@jpkrohling I'll check it now


In getStorageAccounts(), convert this.wallet.pubKey to base58 string

… this function isn't working because it's not passing an expected base58 string to the memcmp.bytes property.

@khaIilnafis Can you please review this and merge if it's still relevant?

@jokumusic can you share error logs or steps to replicate getStorageAccounts not working? Have not received any other reports of this and works ok in my tests

Unfortunately, I don't remember exactly where it was failing, but I was passing in a PublicKey defined in the @solana/web3.js package.
I got my app working by creating a patch: https://github.com/jokumusic/shadow-storage/blob/master/patches/%40shadow-drive%2Bsdk%2B3.0.8.patch
This is where the code that uses the shadow-drive package is: https://github.com/jokumusic/shadow-storage/blob/master/src/GlobalProvider.tsx

This issue was replicated by another user, requiring it to be converted .toBase58(). @khaIilnafis please merge this change


How to use Multi Adapter?

No documentation, your uploaded samples are all 404. And the new ones seems that don't solve the problem.

I fixed the endless scroll issue which I opened.. But now I want to have the progress item in the footer adapter but I can't add the footer adapter to the FastAdapter

Your FastAdapter requires a Post item. if you want to have different types. your FastAdapter can not be with a specific type. it will require to be a GenericFastAdapter too due to type requirements

the sample app is still there: https://github.com/mikepenz/FastAdapter/tree/develop/app
if you see broken links. the sample activites are all there. please report those broken links so we can fix them

the sample app is still there: https://github.com/mikepenz/FastAdapter/tree/develop/app
if you see broken links. the sample activites are all there. please report those broken links so we can fix them

I already have seen this repo.
And the code in the screenshot is copy pasted from there .
I've changed it to GenericFastAdapter type and still getting the same error.
Please tell me to not waste my time anymore since I should have already finished this in 30 minutes or so but now I wasted like 12 hours today just to figure out how your undocumented library works so I can decide whether to use it or not in my projects.

The endless scroll works but I can't see the progress spinner

So I thought that I have not added the footer adapter, and when i tried to add it.. That happened.

See!

Please help mate

Please reply mate

Solved it.
Thanks for the ton of confusion in your readme and samples. With all respect to your hard work I'm not using it.
Keep up the good work @mikepenz

What's up with your attitude? As Mike mentioned, we'd gladly take in bug reports for broken content as it's our best intention to keep docs informative. Your screenshot is also clearly a generics issue beyond what is used in FastAdapter, the same way as you not being able to add an object to a List<String>.
What library you use is up to you, and you are welcome to post issues here or on stack overflow, but there's no need to ping us repeatedly or proclaim the time you've wasted on what you deem to be trivial problems.

Thanks @AllanWang


Hard Refreshing on sub-pages breaks site totally

The new SystemJS stuff appears to try and serve things from the wrong place, and refreshing on any page which isn't a direct child of the root causes bad things (a single utterly blank page, with possible background image on desktop) to happen.
So [hard] refreshing on /why_physics works fine, but refreshing on /questions/_regression_test_ breaks things and gives the (second) error below:

It appears to be trying to load app.js from a path relative to the current page /questions/, rather than the root!

Appears to be fine on the 'new-equation-editor' branch!


Updated chromedriver_powershell_version to access stdout property

I've been getting the following error when trying to run the selenium grid node recipe on some windows 2008R2 VMs.
 ================================================================================
 Error executing action `unzip` on resource 'windows_zipfile[C:/chromedriver/chromedriver_win32-2.23]'
 ================================================================================

 Zip::DestinationFileExistsError
 -------------------------------
 Destination 'C:/chromedriver/chromedriver_win32-2.23/chromedriver.exe' already exists

 Resource Declaration:
 ---------------------
 # In c:/chef/cookbooks/chef-selenium-grid/config/local-mode-cache/cache/cookbooks/chromedriver/recipes/default.rb

  48:   windows_zipfile driver_path do
  49:     source cache_path
  50:     action :nothing
  51:     not_if { chromedriver_powershell_version >= 3 }
  52:   end
  53: end

 Compiled Resource:
 ------------------
 # Declared in c:/chef/cookbooks/chef-selenium-grid/config/local-mode-cache/cache/cookbooks/chromedriver/recipes/default.rb:48:in `from_file'

 windows_zipfile("C:/chromedriver/chromedriver_win32-2.23") do
   action [:nothing]
   retries 0
   retry_delay 2
   default_guard_interpreter :default
   declared_type :windows_zipfile
   cookbook_name "chromedriver"
   recipe_name "default"
   source "c:\\chef\\cookbooks\\chef-selenium-grid\\config\\local-mode-cache\\cache/chromedriver_win32-2.23.zip"
   path "C:/chromedriver/chromedriver_win32-2.23"
   not_if { #code block }
 end

 Platform:
 ---------
 x64-mingw32

 INFO: Running queued delayed notifications before re-raising exception
 ERROR: Running exception handlers
 ERROR: Exception handlers complete
 FATAL: Stacktrace dumped to c:/chef/cookbooks/chef-selenium-grid/config/local-mode-cache/cache/chef-stacktrace.out
 FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
 FATAL: Zip::DestinationFileExistsError: windows_zipfile[C:/chromedriver/chromedriver_win32-2.23] (chromedriver::default line 48) had an error: Zip::DestinationFileExistsError: Destination 'C:/chromedriver/chromedriver_win32-2.23/chromedriver.exe' already exists

So, I was looking into it and was very sure that my Powershell version is greater than '3', and I ran $host.version.major which returns 4 on my system. I then started up chef-shell and tried to run the chromedriver_powershell_version library and found that out is an object returned from shellout with no method to_i. I think the correct fix is to access the stdout property on that object and cast it to an integer. I made this fix in my branch, and the selenium grid node recipe seems to be running fine :)

This has been released as v1.2.2. Thanks for the pull request.

FYI, theopenskyproject.com email has to be registered with you github account in order to show up as a contributor.


High-Resolution Widget Image

Using the app icon is uggo because of the size of the widget.

Nope #8.