Update to Netty 4.1.80.Final

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Update to Netty 4.1.80.Final
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #4359 (00da4ea) into main (d72861f) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4359      +/-   ##
============================================
+ Coverage     70.59%   70.66%   +0.07%
- Complexity    57186    57245      +59
============================================
  Files          4611     4611
  Lines        275279   275279
  Branches      40302    40302
============================================
+ Hits         194328   194532     +204
+ Misses        64631    64425     -206
- Partials      16320    16322       +2

Impacted Files
Coverage Δ

...n/indices/forcemerge/ForceMergeRequestBuilder.java
0.00% <0.00%> (-75.00%)
:arrow_down:

...pensearch/client/cluster/RemoteConnectionInfo.java
0.00% <0.00%> (-73.18%)
:arrow_down:

.../indices/forcemerge/TransportForceMergeAction.java
25.00% <0.00%> (-58.34%)
:arrow_down:

...a/org/opensearch/client/cluster/ProxyModeInfo.java
0.00% <0.00%> (-55.00%)
:arrow_down:

...a/org/opensearch/client/cluster/SniffModeInfo.java
0.00% <0.00%> (-52.95%)
:arrow_down:

.../java/org/opensearch/node/NodeClosedException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...ava/org/opensearch/action/NoSuchNodeException.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...cluster/coordination/PendingClusterStateStats.java
20.00% <0.00%> (-48.00%)
:arrow_down:

...rch/client/transport/NoNodeAvailableException.java
28.57% <0.00%> (-42.86%)
:arrow_down:

.../admin/cluster/reroute/ClusterRerouteResponse.java
60.00% <0.00%> (-40.00%)
:arrow_down:

... and 487 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta do we really need to backport to all the versions ?

@reta do we really need to backport to all the versions ?

thanks @saratvemulapalli , with respect to Netty, we keep updates in sync for all branches, those all low risk updates (most of the time).
[1] https://github.com/opensearch-project/OpenSearch/blob/1.x/buildSrc/version.properties#L23


My current focus is on support or tasks related to the SAP product standardisation.


Transient waveport boundary condition

Hi there. I was learning MFEM to implement some transient EM projects. Palace is really experienced with EM problems, so I try to ask for some help here.
It confuses me, to set the waveport boundary condition in transient problem for a rectangular waveguide. TEM mode is easy to apply as an impedance BC, but TE mode and TM modes are frequency dependent. The method proposed in The Finite Element Method in Electromagnetics by Jianming Jin requires convolution, seems a bit complex. How does palace, or commercial softwares such as COMSOL address it?

Hi @Wayne901, thanks for opening this issue. In Palace, the wave port boundary condition is actually only implemented for frequency domain problems and not in the time domain. I believe you are correct that in general, the wave port boundary for transient simulations would require a convolution as described in the Jin textbook. There may be better ways to do it, however.
We would definitely welcome contributions to add this type of functionality to Palace and could provide help where needed for the implementation.

I just moved from frequency domain problems to time domain ones. The waveport boundary is tricky in time domain...
Thank you for your reply.


Syntax validation for ECMAScript 5

Does Monaco support syntax validation for ECMAScript 5 code?
My naive impression was that using language: "javascript" during editor creation and setting the ScriptTarget to ES5 would do the trick:
monaco.languages.typescript.javascriptDefaults.setCompilerOptions({
	target: monaco.languages.typescript.ScriptTarget.ES5,
});

monaco.editor.create(document.getElementById("container"), {
	language: "javascript"
});

However, the editor still lets me use ES6 features and even Typescript-specific syntax (i.e., type annotations) without complaining. Am I just misunderstanding what these configuration options do?

Yes, the target property determines only what environment you have access to, like Map, Set or String.startsWith. The syntax kind cannot be validated and our implementation doesn't allow for that. It should come from the outside using a linter


@todo should have an indexed

The @todo tag should have it's own page and index along with classes, namespaces, and files.  The todo listings should also link to the generated page for the file it comes from.

👍
I agree: available and optional!
It would be a great support.


"Segmentation Fault" after getting POST body data

Compiling on Linux - GCC 10.0.1
During "res->end("Thanks for the data!");" call, it raises 'Segmentation Fault'.
I tried "res->close();" instead and got the same.
Thanks
int main()
{
    std::vector<std::thread*> threads(std::thread::hardware_concurrency());

    std::transform(std::cbegin(threads), std::cend(threads), std::begin(threads), [](std::thread* t) {
        return new std::thread([]()
		{
			auto thread_id = static_cast<std::stringstream&>(std::stringstream{} << std::this_thread::get_id()).str();

			uWS::App()
				.post("/*", [](auto* res, auto* req) {
					res->onAborted([]() {
						std::cout <<  "Aborted!" << '\n';
					});
					res->onData([&](std::string_view data, bool last) {
						std::cout << "Got data: " << data << ", it's the last: " << last << std::endl;

						if (last) {
							res->end("Thanks for the data!");
						}
					});
				})
				.listen(5000, [&thread_id](auto* token)
				{
					if (token)
						std::cout << "Thread " + thread_id + " listening on port 5000" << '\n';
					else
						std::cout << "Thread " + thread_id + " failed to listen on port 5000" << '\n';
				})
				.run();
        });
    });

    std::for_each(std::begin(threads), std::end(threads), [](std::thread* t) {
        t->join();
    });
}

Can you try older versions from v18 forward and see where it starts to fail?

You are capturing a reference to the pointer res, then using that reference (which is stack allocated and long gone) in the callback. This is not an issue with the library but rather your use of C++.

Ah that's fine, I've seen way worse!


[NEW]: The Verge: Warner Bros.' Lord of the Rings NFT “experience” is just The Fellowship in 4K.

Links
https://www.theverge.com/2022/10/20/23413237/lord-of-the-rings-movie-nft-wb-movieverse-metaverse
Agreement

[X] I irrevocably agree to release my contribution under the CC-BY 3.0 License

Attribution name
Patrick Wood
Personal link
No response

https://web3isgoinggreat.com/?id=warner-bros-reinvents-dvd-navigation-menus-with-their-web3-movieverse


Working towards fixing date formatting #520

Current NJsonSchema is making all sorts of weird build errors for me (Can't nuget restore DotLiquid 2.0.84 I think?), so I've blind fixed this maybe.
Trouble with fixing it is that the code for formatting a Date object can't go all on the right hand side, so I've had to introduce a method and a string replace to plug it in.
Not sure if there is a nicer way to do this?
I also haven't updated the liquid templates or rebuilt the cs files from the tt.

T4 templates will be removed soon. We need this as liquid template and code artifact.. will wxplain later.

Hi @danzel can you create the fix for the Liquid templates? This replace logic in the template is not possible with Liquid... The T4 templates will be removed soon... For more information: https://github.com/RSuter/NJsonSchema/wiki/Templates

Hey, sorry been away a few days.
How do you think I should implement this in liquid?
I could add DateToStringCodePre and DateToStringCodePost, and put those in?
(item.{{ DateToStringCode }} becomes {{ DateToStringCodePre }}item{{ DateToStringCodePost }})
Or can you think of a nicer way?
Need a bit of advice please :) Thanks!

I think we should just add a new property UseJsDate and inline the code like
{% if UseJsDate %}formatDate({{ value }}){% else %}{{ value }}.format(...){% endif %}

Three times?

Haha yeah good idea :+1: Will do this later today

Thank you. And please rename UsesJsDate to UseJsDate to be consistent with the rest

And for now, please do all changes in T4 and liquid. I will remove T4 soon, but i dont know exactly when...

Ok, had a second go at this, tests work locally.
Do we need to have an option to control generating the formatDate function? Where would I put that? (is there an example to refer to?)

Thanks for the PR.
I removed the T4 templates because it is too complicated to maintain both...
The formatDate function is now added here as artifact:
https://github.com/RSuter/NJsonSchema/blob/master/src/NJsonSchema.CodeGeneration.TypeScript/TypeScriptGenerator.cs#L85
This artifact is later inserted into the file...
These artifacts are used to output into multiple files later: https://github.com/RSuter/NJsonSchema/issues/514

Ok, now I've removed all T4 templates in NJS and NSwag... Please test with the latest NSwag CI builds...

This bit is padded out an extra tab, everything else looks the same or similar enough :+1:


plugins/slate: resolve serializer issues with a, u, i

Changes Unknown when pulling e343d8c94e7b398d15bdb49e69858455fcf7005c on check-import into ** on master**.


Docker image build time on main is huge

It took 25 minutes to build the docker image. The reason is that it builds everything from scratch without caching
https://app.circleci.com/pipelines/github/zenithdb/zenith/3967/workflows/af369227-1d25-48ad-bd58-57721d042abf/jobs/35386
@cicdteam Is it known issue?

will look how to optimize it in ci and in Dockerfiles itself

I've taken a stab at it and can share more context.

First, there are multiple docker image builds happening nowadays:

one as e2e tests for https://github.com/zenithdb/console/ repo
one as e2e tests for https://github.com/zenithdb/zenith repo

While they do build the same image, they do that separately and not sharing either build cache (that is nonexistent) or build results.
We also plan to add arm builds at some point, so those builds could double, if we decide to run e2e tests with arm images too.

The image builds and e2e tests are run on GitHub actions only, CircleCI is not involved into that.

I don't think we can expect big decrease in rust compilation speed with time. We can sure put some effort into crate minimization, but no drastic compilation decrease in the near future can be expected. On the other hand, we do run the same compilation multiple times in a row, so feels like it's also more profitable get the build caching on board instead.

Caching can be done two different ways:

cache via https://github.com/Swatinem/rust-cache and similar using GitHub actions mechanism.
Those tools are useful when builds is happening on the build agent, yet our build agent runs the docker build ... command instead, fully encapsulating whatever build side-effects we have.
It's possible to pass fs into docker build process with docker buildkit, but I'm not entirely sure that it would work fully with the GitHub Actions caching.
It's possible to rework this and we will have to eventually, if we plan to deliver native platform binaries in some form and/or test the builds on macOs.

cache via https://github.com/mozilla/sccache , https://github.com/paritytech/cachepot and similar using a distributed cache

There's a way to configure sccache to use an arbitrary S3 bucket via IAM or direct credentials usage.
Alas, sccache itself is not currently supporting modern S3 protocol, so it does not work with the new buckets (it will get improved with https://github.com/mozilla/sccache/pull/1086)
Yet there's a fork of this tool, https://github.com/paritytech/cachepot that has pretty much the same settings and works nice with modern S3.

export AWS_SECRET_ACCESS_KEY="..."
export RUSTC_WRAPPER="/usr/local/cargo/bin/cachepot"

This way it works for me, yet does not show big impact in arm builds.
We can try cachepot already and see if it brings any gains to our build speed.

In general, I think sccache/cachepot is still a right direction to go in our set up (with builds run in Docker images) and we should debug and make it better.
I've added stats printing as a first step: https://github.com/zenithdb/zenith/pull/1387 that will show multiple things:

what kind of cache was configured
cache misses
whether cachepot was at all enabled


feat: Add api to update mulitple layout

Description
We need an API to update multiple page layouts with a single request. For the mobile responsiveness project, the client migrates an existing app from fixed layout to auto layout. After the migration is done, it needs to send the updated layout one by one. With this new API, the client needs to make a single API call to update all the layouts.
Fixes #21104
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

Manual
Junit tests

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=97eb45977b2d07850b52bd2e933f7b9c390f374b

/ok-to-test sha=97eb45977b2d07850b52bd2e933f7b9c390f374b

/ok-to-test sha=893bb190279a7cb6d147834fdc40a81ce45118cc


feature request: list all repos with precog enabled

Nice but not necessary: listings under https://precog.mapzen.com/mapzen and https://precog.mapzen.com/transitland showing all the enables for which precog has previews available.

Unfortunately, this won’t be possible. Precog has no persistent datastore of any kind, and there’s no formal concept of “enabled”—it’s just a passthrough way of displaying HTML from the CircleCI build artifacts.

O.K. Good to know.


It's broke

Problem
It don't work
Seriously though, it does not connect to Rococo and selecting "Other endpoint" does not show the input.

Because of course now it works


Public API vs internal API

Jeffrey Phillips Freeman made a good point today. He considered that some API we are currently only using internally might get reused externally.
Parts which we could decide on are
Nar/TruthValue/Concept/etc
internal inference logic
Should the inference rules and mechanisms be configurable and exposed to the outside?
Variable-Unifier
Should the unifier be usable from the outside with a nice API?

@patham9  @TonyLo1  @freemo  What is your opinion on the location of the interfaces?
I was thinking about api/{public, base}, public is for all interfaces which are exposed and base for really basic interfaces


feat: use HTTP interceptors

Just make a simple example illustrating how to use HTTP interceptors. Use this post for guidelines.

Obsolete.


Typo in migrate-mirror.ps1

Really useful script but found the following typo:
Line 41 of migrate-mirror.ps1 currently reads:
git clone --miror $cloneUrl .
Should be --mirror.

Hey, thanks for the Issue. Good Catch.
I fixed it.
Not sure how it is possible that I had that typo since I've used this script before 😕, probably I've committed an earlier version..
I will re-check the entire codebase to make sure everything is correct.


Error message on .render()

Hello,
I've been trying to get your plugin to work, but every time I attempt to render I get this error message;
Uncaught (in promise) ReferenceError: hljs is not defined(…)                 embed.min.js:10

I've installed via npm and loading the minified version from /dist
I've also tried a CDN and I tried to load from /src but the same error keeps coming back.

Earlier highlightCode was set to true by default so it need highlight.js . Now its fixed and set to false by default. If you set it to true you will have to load highlight.js to enable code highlighting.


Align JSON settings to v2 changes

In v2 we should use json_settings from blacksheep.settings.json instead of json_plugin from blacksheep.plugins

Thank You @tyzhnenko!


Try adding minherit syscall

@dvyukov @mptre  this is call for help, not a ready patch. I must be missing something simple because running gmake generate_sys causes an error:
gmake generate_sys
export HOSTOS=openbsd
export HOSTARCH=amd64
export TARGETOS=openbsd
export TARGETARCH=amd64
export TARGETVMARCH=amd64
export CC=c++
export ADDCFLAGS=-m64 -static -lutil
export NCORES=2
export EXE=

go build "-ldflags=-s -w -X github.com/google/syzkaller/sys.GitRevision=79594b0481b740add47ee3539228584f5b5fa6f8" -o bin/syz-sysgen ./sys/syz-sysgen
bin/syz-sysgen
generating akaros/amd64...

...

generating freebsd/amd64...

generating netbsd/amd64...

generating openbsd/amd64...
mm.txt:18:1: unsupported syscall: minherit due to missing const SYS_minherit

syscall minherit is unsupported on all arches (typo?)
gmake: *** [Makefile:170: generate_sys] Error 1

First, there is something wrong with your CLA which we need to sort out.
After changing descriptions you need to run:

make extract TARGETOS=openbsd SOURCEDIR=/openbsd/checkout/dir
make generate

See https://github.com/google/syzkaller/blob/master/docs/syscall_descriptions.md for details.
And then you need to commit all changed files too.

I used @mptre's script (which I added to the repo) and things converged. I'm still unclear why gmake check_diff and syz-sysgen don't agree on source formatting, but I can make check_diff happy.
This should now be ready for review.


migrations errors

_journal.json references 0002_short_dagger  which does not exist on the migrations folder

remove all files and subfolder in migrations folder and run this command bun db:generate

thanks!

remove all files and subfolder in migrations folder and run this command bun db:generate


Add Org -- Page or Modal?

Overview
Product needs to recommend whether this experience is a modal or a stand alone page so that we encourage user completion rates.
UX has recommended updates to the form so that it is more user friendly. We want to check with development first before any work is done.

It will be a modal on the tag generator page and standalone when it redirects from other pages (example: faq page)

@chalimar @meismith See Olivia's comment


[Windows] Fix Windows iSCSI workflow failed to start

Problem:
The msiscsi service enabled by flexvolume plugin will cause storage fail to mount.
Solution:
Start msiscsi service before running agent.
Issue:
#20192

LGTM

lgtm


Refactor: Sparkle Writers should be initialized inside class

In the current interface for Sparkle, we are passing Writers as writers: List[Writer]. it should be refactored to writers: List[type[Writer]], similar to readers argument.
Reason is initiaizing a Writer requires a SparkSession which we decided to let Sparkle create that session; So it means during initializing a Sparkle app, we don't have access to SparkSession yet and Sparkle should be responsible for initializing Readers and Writers.

@farbodahm didn't we suggest in our call to instead of passing writers: List[type[Writer]], to use some kind of Enum or TypedDict instead, to hide implementation away from final user and avoid unnecessary imports?

@wtfzambo I created #24 to address that issue; For now I would prefer to keep it like this and continue developing Damavand to have something working.


[Bug][Java]: SDF Wrapped Bounded sources don't implement progress tracking leading to poor performance.

What happened?
While investigating performance of Java pipelines on Dataflow RunnerV2, we've determined that SDF wrapped legacy Bounded Sources perform and scale poorly compared to the legacy runner v1 worker that interacts with the sources directly.
There are 2 things to resolve in this issue.

First:
The BoundedSourceAsSDFRestrictionTracker does not implement the (optional) HasProgress interface, which per RestrictionTracker documentation can lead to poor auto-scaling and splitting performance.
The Unbounded counterpart does implement getProgress  which may possibly be used as a basis for the bounded implementation.

Second:
The SplittableFnDataReceiver has different splitting characteristics vs normal DoFns:
When getting progress for splits of SDFs and there's no HasProgress method, then the receiver returns 0, note however that in some anonymous implementations this may be overridden (see elsewhere in FnAPIDoFnRunner).
This will override default behavior that's used for non SDFs, which is to return progress of 0.5, when determining a split
That is, estimated split progress is different between these two cases:
for NonSDF => 0.5 ; for SDF without getProgress => 0.
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[ ] Component: Python SDK
[X] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

cc: @kennknowles @robertwb @malo-denielou


Switching between networks  is disabled in Firefox extension

I use Stacks Wallet v2.12.2 on Firefox (v90). When I want to switch the network, all the networks are disabled.
If I use Chrome, I can easily switch the network.
Here is a screenshot of the network switch pane:

It's working fine for me

See https://github.com/blockstack/stacks-blockchain-api/issues/540#issuecomment-885162028
@n4cr can you confirm whether this is working for you now?

@markmhx I confirm it is fixed as well! Except for the Localnet which I believe is because I don't have a localnet running.
Thanks for the quick fix!


Problem escaping 'static' and 'operator'

Version of protoc (protoc --version)
3.0
Version of ProtocolBuffers.framework
3.0.0
.proto file to reproduce
syntax = "proto3";
package Test;

enum Operator
{
    OperatorA  = 0;
    OperatorB  = 1;
    OperatorC  = 2;
}

message Value
{
	bool nil = 1;
	Operator operator = 2;
}

message Expression
{
    repeated Operator code = 1;
	Value static = 2;
}

Description
I have modified the kKeywordList in swift_helpers.cc to include support for escaping the keywords nil and operator. It would be great if nil and operator were already part of the list. The keyword static was already present in the list.
After generating Swift code, there are a couple of places where the escaping of the keywords fails.
Here is the operator issue. Note the unescaped operator.toString() on line 11.
01    override public func encode() throws -> Dictionary<String,Any> {
02      guard isInitialized() else {
03        throw ProtocolBuffersError.invalidProtocolBuffer("Uninitialized Message")
04      }
05
06     var jsonMap:Dictionary<String,Any> = Dictionary<String,Any>()
07      if hasNil {
08        jsonMap["nil"] = `nil`
09      }
10      if hasOperator {
11        jsonMap["operator"] = operator.toString()
12      }
13      return jsonMap
14    }

And here is the static issue. Note the unescaped if static != nil on line 5.
01      public func getStaticBuilder() -> Test.Value.Builder {
02        if staticBuilder_ == nil {
03           staticBuilder_ = Test.Value.Builder()
04           builderResult.`static` = staticBuilder_.getMessage()
05           if static != nil {
06              try! staticBuilder_.mergeFrom(other: `static`)
07           }
08        }
09        return staticBuilder_
10      }

Done. Thanks!

Excellent! Thank you.
That addressed the static scenario great, but the operator scenario is still occurring.

Now, will be ok.


Add trove classifier for PyPy support

Tested during CI since 761da6ff612966214fe9e34ac6bc86499e34da26.

Is there a reason beyone "users could technically filter by them in PyPI" to use these? I don't use them in any other projects, in Pallets or otherwise.

I find them useful because they allow potential users to know -- at a quick glance -- what Pythons are supported by a library. Sometimes when integrating a library with my own projects, I'll use this information to help decide if it is good for integration.
As the trove classifiers have a consistent form, they are also used by sites and offline scripts to analyze the changes in the Python community. Some examples:

https://python3wos.appspot.com/
https://hugovk.github.io/drop-python/

If you don't support PyPy as a platform, then I don't think you should add it. But PyPy is included in CI, so it appears that compatibility is desired. I think adding CPython is only useful in contrast to PyPy so as not to give the impression that the library is PyPy only.
Up to you.


data.query function names need changing

the following functions in data.query.py operate on pandas dataframes.
rFilter
rProject
rGroupBy
rAggregate
these should be renamed to:
dfFilter
dfProject
dfGroupBy
dfAggregate

also removed some unused junk


tunneling socket could not be established, statusCode=403

Hi there,
I'm having some issues installing this module from behind a proxy. I've followed some online examples and set up my .npmrc to include the http and https proxy settings:
proxy=http://myproxy:port/
https-proxy=http://myproxy:port/
strict-ssl=false
ca=null
registry=http://registry.npmjs.org/

but I'm still getting the error when npm gets to the node lib/install.js stage.
Also, I have environment variable set up for HTTP_PROXY and HTTPS_PROXY on my machine too.
My setup is as follows:
OS: Windows 7 enterprise 64bit
NODE: v6.11.3
NPM: v3.10.10
I have no issues with this at home (no proxy).
Will you be able to help please?

Closing as this looks unrelated to this package and it's very old.


Control with Alexa

The input.select for the programs and the button entities are really nice and clean. This is working well inside Home Assistant.
But there is no chance to control the device with Alexa.
Could you also add switches for on/off and the programs? So we can use the input.select and button with Home Assistant and can use the switches to control the device with Alexa.

The integration automatically creates the type of control which is appropriate for the value provided by the API. Binary values become switches, numeric values become numbers and textual values become selects. This is done automatically, the thing is that some values you would expect to be binary, like the power state of the appliance, are actually provided by the API as text so they become selects (because in that example there is also a "standby" state, not only on/off).
Once the main functionality is verified to be working properly I'll look into adding Alexa support.

Thank you very much.
I am available for testing with a
Siemens CoffeeMaker TI957FX1DE
and a
Siemens WasherDryer WD14U592

[...] Could you also add switches for on/off and the programs? So we can use the input.select and button with Home Assistant and can use the switches to control the device with Alexa.

When you just need it to start the command with voice you can always add a template (binary) sensor or template switch in HA. I use it that way to control many switches that are not switches in reality with Genie. This way you can also assign a more practical name to the "skill" and don't need to alter the original entity.
It adds a layer of complexity but helps tremendously when you e.g. change the appliance from Bosch to AEG or whatever because your skills will stay the same.

Thanks @NODeeJay. It would be great if you can give a detailed example of how to do it for those who wish to integrate with Alexa.

Thanks @NODeeJay for the suggestion with the template.
It might not be perfect, but I gave it a shoot.
A switch is now exposed to my voice assistant (Google Home), so I can start/stop my Siemens iQ500 dishwasher with voice commands.
Her is what I put into my configuration.yaml:
`
switch:

platform: template
switches:
iq500:
friendly_name: "Opvaskemaskine"
unique_id: "siemens_iq500_startstop"
value_template: "{{ not is_state('button.012050388751000127_stop', 'unavailable') and is_state('button.012050388751000127_start_pause', 'unavailable') }}"
availability_template: "{{ is_state('binary_sensor.012050388751000127_bsh_common_status_doorstate', 'off') and is_state('binary_sensor.012050388751000127_connected', 'on') and is_state('binary_sensor.012050388751000127_bsh_common_status_remotecontrolstartallowed', 'on') and is_state('binary_sensor.012050388751000127_bsh_common_status_remotecontrolactive', 'on') and not is_state('sensor.012050388751000127_bsh_common_status_operationstate', 'aborting') }}"
icon_template: "mdi:dishwasher"
turn_on:
- service: switch.turn_on
target:
entity_id: switch.012050388751000127_bsh_common_setting_powerstate
- service: button.press
target:
entity_id: button.012050388751000127_start_pause
turn_off:
service: button.press
entity_id: button.012050388751000127_stop
`

Hopefully you can also make it work @ekutner.

I was playing with this and in node red I was able to create a thermostat-like appliance that supports on/off and to set a temperature. It is not perfect and I can’t change modes or set alarms, but 95% of the time I use heat from top and bottom so it’s not bad.
However the node-red package I’m using is unmaintainded and this feels like something that should be baked in.
What would require to expose ovens like thermostats natively to Alexa? That’s for now the best solution I’ve found other than creating a custom skill that requires you to use the obnoxious “Alexa, ask Home Assistant to turn on the oven at 220 degrees”. I really hate having to use the skill invocation name for this.

Looks like this should be a discussion, not an issue, so moving it there.


Is it possible to get the exp and nbf from the pass where they can be read?

Similar to #50 is it possible to return the exp and nbf where they can be read?  (Sorry I had a go at coding it based on #50 but got lost pretty quickly).
Expected Behavior
Return the exp and nbf dates if you can determine them from the QR code so I can put nice messages like (your pass expires in under a month, go to blah to get a renew).
Actual Behavior
There isn't a exp or nbf value returned.
Steps to Reproduce the Problem

Call verifyPassURI with a valid | bad exp | bad nbf pass
There isn't a exp and/or nbf in the result

Specifications

Version: Node 1.0.2
Platform: Windows

This works perfectly in 1.1.0 - Thank you all!!!


Build in Release Android error Label with floatingLabel

Hi Guys ! i have a problem.
in my code it's like this and when compiling in debug it works, but when the build release does not work, the sequencing of the images occurs and my code in sequence
In my code it's like this and when compiling in debug it works, but when the build release does not work, the sequencing of the images 1 2 happens and my code is in sequence, I verified this problem on the internet and found nothing similar if they know how to solve the path. In image 2 is hide labels.  thank you.

Package.json
{
"name": "newproject",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "node node_modules/react-native/local-cli/cli.js start",
"test": "jest"
},
"dependencies": {
"native-base": "^2.8.0",
"react": "16.4.1",
"react-native": "0.56.0"
},
"devDependencies": {
"babel-jest": "23.6.0",
"babel-preset-react-native": "^5",
"jest": "23.6.0",
"react-test-renderer": "16.4.1"
},
"jest": {
"preset": "react-native"
}
}

#2264


Cargo should strip features of dev dependencies

Problem
https://github.com/rust-lang/cargo/pull/7333 added stripping of dependencies, but did not strip features pointing to those dependencies.
This causes a rather unintuitive error where cargo says the dependency does not exist. Which one would only understand if they knew about the stripping that cargo does.
Proposed Solution
Cargo should also strip these features from the manifest before publishing.
If foo is a dev-dependency being stripping then a = ["foo/a"] should be transformed to a = [].
Notes
No response

@rustbot claim

Hello, I submitted a PR to fix this。 Would you kindly review my PR and provide your feedback? :heart_decoration:

@rustbot claim
I'm going to try, and if I haven't moved for a long time, feel free to pick it up and continue.


Release v1.0.2

Fixes #1010
VOTE: https://groups.google.com/a/opencontainers.org/d/msg/dev/8GeFsgXvSM8/lTwNIWlOBAAJ

LGTM

LGTM

Updated, PTAL
thanks @h-vetinari for the ChangeLog update

@vbatts, I think you need to rebase and reorder the patches (in case you want the changelog to be complete for the tagged version) - you applied my suggestion after setting the version 1.0.2.
PS. If you want, you can use: Co-Authored-By: H. Vetinari<EMAIL_ADDRESS>PPS. I would also be fine if you just squash my update into your changelog commit, I don't need attribution for this trivial patch.

right again. This updates the commit that @tianon already corrected me about, but I think this is fine. :grimacing:
new tagged v1.0.2 would be on c4ee7d1

LGTM

LGTM

Congrats everyone for getting this one out the door!


chore: upgrade from tsd to typings

switch to typings
remove webpack settings that are no longer needed
update readme
should resolve #140

In case of any issue with the upgrade, run npm run clean then npm install.

:shipit:


typings files not getting picked up by the Typescript virtual project until you open the file

Testing out fresh install of VS Update 2 RC with TS <IP_ADDRESS>, I don't see the *.d.ts files getting included in the TypeScript virtual project until you actually open the *.d.ts file once. Then they are included.
This prevents Intellisense from working on those packages..
@mousetraps Please confirm if you are also seeing this as well.

The behavior is correct on VS 2015 Update 2, 14.0.25117.00 with TS <IP_ADDRESS>
Checking to see now if it the TS version or the VS version that matters.

Confirmed that you need full Update 2 for this to work. Closing the issue. We should make sure that the release notes make it clear that we depend on the actual release of update 2. Right now searches for "VS 2015 update 2" may return links to the RC instead of the full release.


Support openssh authorized_keys format for sshPublicKey ldap field

This is probably incompatible with how you've structured things internally, but it seems a tad more user-friendly (and also more compatible with what github enterprise excepts from an LDAP server). The difference boils down to calling ssh.ParseAuthorizedKey in the key loop in usercache.go instead of base64.StdEncoding.DecodeString and then ssh.ParsePublicKey. Perhaps it could be configurable?
I'm also happy to make PRs for these changes, if that's helpful.

Anyone have thoughts on this feature request? My main issue is that the current key format seems fairly nonstandard, whereas I can just pipe ~/.ssh/id_*.pub into an ldap modification tool with ParseAuthorizedKey.

Hey,
I certainly agree that the current way of doing this is awkward, and I'd much rather see something like what you suggest, we'd probably need to make it another config option (or maybe try to autodetect with fallback?) as I don't see us changing the way these are stored internally at the moment.
But yeah, I'd like to see this happening.

Reopening as hologram-authorize support is needed.
We need a flag to hologram-authorize that allows us to upload the keys in authorized_keys format instead of the current format, so users can decide what format to upload the keys in.
This is probably best done at the same time or after https://github.com/AdRoll/hologram/issues/36


Now storing password in config files as base64 encoded

This will base64 encode the password fields in the various config files. It will not auto-re-encode existing files but the next time config writes the password to the file it will become encoded.

resolves https://github.com/ansible/tower-cli/issues/134

Seems the same arguments could apply to tokens @ryanpetrello what are your thoughts?

Thinking more on this... another argument might be that this would actually be really non-standard from an Ansible perspective. Look at how we write credential files for other cloud sources in AWX:
https://github.com/ansible/awx/blob/devel/awx/plugins/inventory/cloudforms.ini.example
One of tower-cli's primary purposes is to be the upstream library for the tower_* modules, and soon we'll be adding the inventory plugin. Correspondingly, the config file that we're using now as .tower_cli.cfg would then likely be ported into the AWX credential creation, and no other similar examples use encryption or obfuscation. This might still work, but I would conservatively prefer to hold off until those changes have been implemented.

@ryanpetrello
I don't think the intent is "Secure" I think its obfuscation and as long as we don't tout it as being secure hopefully no one is under a false sense of security.
Many companies I know just don't want "plain text passwords" in files but they don't say they require security. At a past company someone was telling me that something to the affect of: if someone has to do something to get a password (decrypt it, unencoded it, etc) it proves intent whereas "just seeing it" and using it could be interpreted as an accident (disclaimer: I'm not a lawyer).
Also, tokens will be cool as long as people have the automation to refresh the token. i.e. if someone was using Jenkins with TowerCLI (which hopefully they are using my plugin) they would need something to rotate Jenkins token (if they set it to expiring). Also, until people have migrated to a version of Tower which supports Tokens us telling them to use a token is kind of pointless.
@AlanCoding
When using TowerCLI via Ansible/Tower it makes sense to use a vaulted password/Tower credential and you don't need a config file so this change would be mute. When coding it, I actually thought about using a vaulted password in the config file but then we would need to require ansible libraries on the box. I also thought about actually encrypting the password as well but didn't want to require libcrypt or another library (plus were open source so we couldn't 'hide' the decryption key). As for other files within Ansible I would say "see above". At my client they don't even keep the Tower inventory file around after building a Tower cluster because it has unencrypted passwords in the file, it is only tolerated on the filesystem for the duration of the buildout.


add pytest-monitor

Purpose of PR?:
Fixes #1970
Does this PR introduce a breaking change?
installs pytest-monitor for testing
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (Non-API breaking changes that adds functionality)
[ ] PR Title follows the convention of  <type>: <subject>
[ ] Commit has unit tests

the monitor is very helpful, but we may look first why a test crashes that way

retrying


Update docs README with instructions for new pages

Contributor Checklist

[N/A] Did you add Scaladoc to every public function/method?
[N/A] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

documentation

API Impact

No impact
Backend Code Generation Impact

No impact
Desired Merge Strategy

Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Updated documentation documentation with more explicit instructions for adding new pages.
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

@Burnleydev1 (and any other outreachy applicant working on website docs) please LMK if these instructions are helpful!


visual studio code, open in browser extension

Hello
I download "open in browser" extension but its not active I cant find the option can somebody help me please !
Thank you

/causedByExtension


[feature-request] Allow to set git push options

It would be useful, if there would be a option to provide git push -o options as a config.
gitlab is using push options for some CI features which would simplify my pipeline. (https://docs.gitlab.com/ee/user/project/push_options.html)

Thanks for this! ✨


Frontend support for a single facility in the style of multiple facilities

This PR implements the frontend support for multiple facilities. Note: most API calls will need to be updated and disabled inputs/buttons will need to be implemented when we have backend support for multiple facilities.

converting this back to a draft to rebase off of benwarfield-usds/persist-multiple-facilities

This seems to make it impossible to change the name of a facility?

Why is it impossible to change the name of a facility? (Note: disabled form fields were removed after database support for facilities)

I think based on subsequent conversations that I misunderstood how two pieces of code were interacting. 😑


Simplify submodules outputs

Instead of:

https://github.com/opsd-io/terraform-aws-users-management/blob/a824d832f8530b7847402efc11983076af705cc4/modules/policies/outputs.tf#L3
https://github.com/opsd-io/terraform-aws-users-management/blob/a824d832f8530b7847402efc11983076af705cc4/modules/policies/outputs.tf#L8
https://github.com/opsd-io/terraform-aws-users-management/blob/a824d832f8530b7847402efc11983076af705cc4/modules/policies/outputs.tf#L13
please use directly

value = aws_iam_policy.main.SOMETHING

Same on features breanches ie. https://github.com/opsd-io/terraform-aws-users-management/blob/1-create-submodule-to-user-creation/modules/users/outputs.tf
Returning direct values makes values handling much easier when using submodule directly - you don't have to fetch value from one-element maps with changing key (the name). That is you can use module.bob.user_arn without knowing actual username and having to do it like this: module.bob.user_arn["bobby"] (assuming var.name was "bobby").
I understand the rationale of that solution, so you could do this:
value = merge([for user in module.users : user.user_password]...)

but, after change you can still have the same result with:
value = { for name, u in module.users : name => u.user_password }

which is exactly same length, but easier to cope with ;)

All right, I changed submodule outputs in main and feature branches.
Your advice on how to get the same result is great. Thanks :smile:.


Horizontal scrolling

Currently using the following components
<AutoSizer>
  <InfiniteLoader>
    <FlexTable {...props}>
       {children}
    </FlexTable>
  </InfiniteLoader>
</AutoSizer>

This works perfectly but we have a use case where the user can add or remove new columns and the table can become unreadable if it just truncates the columns. I've been trying to think of a good way to tackle supporting horizonal scroll so the table has a minimum width and above that it should show a horizontal scroll bar.
Can this be done currently with <VirtualScroll /> HOC?

Hi @ryanseddon,
Have you considered using the Grid component for this purpose? VirtualScroll and FlexTable were built with vertical scrolling in mind only. FlexTable's columns are configured in such a way to grow (or shrink) to fill its available space. Grid on the other hand scroll (or not, your choice) in both directions and seems like a better fit for what you're describing.

By the way, let's frame our discussion in terms of version 5 (source, docs, overview) since I hope to be releasing it soon (maybe even this weekend) and it changes things a bit.
v5 adds a new HOC, ScrollSync that can be used to synchronize scrolling between 2 or more virtual components. I mention this in case you might also consider pairing a FlexTable (for your fixed columns) and a Grid (for your dynamic ones). Essentially something like this:
<InfiniteLoader
  isRowLoaded={...}
  loadMoreRows={...}
  rowsCount={...}
>
  {({ onRowsRendered, registerChild }) => (
    <ScrollSync>
      {({ onScroll, scrollLeft, scrollTop }) => (

            <FlexTable
              onScroll={onScroll}
              scrollTop={scrollTop}
              {...props}
            />

            <Grid
              onScroll={onScroll}
              scrollTop={scrollTop}
              {...props}
            />

      )}
    </ScrollSync>
  )}
</InfiniteLoader>

Ah grid is exactly what I want, I completely overlooked it as I kept thinking it forced me to have a pinterest/instagram style layout.
ScrollSync genius! Looking forward to v5.
Thanks for answering my poorly researched question.

No problem! Happy to hear that there's a simple solution available. That's always nice. :)

FYI @ryanseddon, version 5 just went out this evening. Would love to hear any feedback you have (if you decide to play with it). I think it's a pretty substantial improvement.

That was quick! Will definitely check it out.

It's been a work-in-progress for a couple of weeks. Glad to finally get it out there. Thanks! :)


Feat: Added workflow

Checklist
Make sure you have

[ ] Added relevant @nestjs/swagger decorators wherever required
[ ] Added test cases (unit and integration) wherever required

Description
Describe the aim/objective of this PR
Steps to test
Add steps to run and test teh desired changes
References
Add relevant links and screenshots outlining the working status of this PR
Demo
If relevant to your change, attach a screen recording showcasing that the change is working and giving desired results.

Summary by CodeRabbit

Chores

Introduced a GitHub Actions workflow for automated testing on push and pull request events.

#154 solved for this hence closing this one out.


Upgrade base images

Highlight to the new debian:stretch-slim images which significantly reduces the image size for the Debian variant.

https://github.com/Cinnamonrou/docker-bitcoin-core/commit/f72a0422ad376be47d4946d471702033246325f6


Curse Downloader

So we can write `compile 'computercraft:ComputerCraft 1.76pr3' instead. The easiest thing to do might be to setup a website that redirects to the appropriate download.

I implemented this with Accursed, but it doesn't appear to work with Gradle: Redirects aren't supported.


enable author profile status

I don't understand why this template doesn't just use the vars and instead does ${VAR_NAME} for every property.

when the venue request form is modified, it is always being synchronized with the properties of the templates. That means we always set the webfield  as template + venue properties. If the webfield is changed using the group editor, the next syncronization will override this change unless the line // webfield_template is removed. But this line is not supported in the components because they must start with // Webfield component. I'm not sure how to fix this in the API 1 without having to set a property in the request from to override in the template.


refactor: Refactored the way Output is handled.

Instead of putting the responsibility in the action executor mock implementer, to add action generated values correctly, instead just have to give the generated output to the ActionResult and the flow runner handles the rest. This simplifies development of mocks and makes action executors more simple. There should be no need at all, to depend on any state related dependencies, they should all automatically be resolved before execution and after, by itself.

:tada: This PR is included in version 1.0.0-alpha.24 :tada:
The release is available on:

GitHub release
v1.0.0-alpha.24
v1.0.0-alpha.24

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.24 :tada:
The release is available on:

GitHub release
v1.0.0-alpha.24
v1.0.0-alpha.24

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0
v1.0.0

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0
v1.0.0

Your semantic-release bot :package::rocket:


Emoji getting censored

https://mybearworld.github.io/roarer/#/posts/cffb5de0-5d7d-425a-a49b-0c98a1c4fd3a
Unless I'm wrong, 6b1ca80 was supposed to prevent this or I'm just dumb
Probably the latter

Ah, that's going to be annoying to fix, thank you

This emoji got removed (and a patch got commited) so I guess this can be closed.

An emoji with swears in its name still exists. When a Discord user sends it, it'll still have a swear in its name


"installing packages" links on pypi.org are broken

Describe the bug
At least two "installing packages" links on pypi.org are broken. The "Download files" panel says "Download the file for your platform. If you're not sure which to choose, learn more about installing packages." and links to https://packaging.python.org/installing/, which doesn't exist. The page footer has an "Installing packages" link with the same problem. Perhaps there are other such links elsewhere on the site that I haven't encountered?
Expected behavior
The "installing packages" links should probably be to https://packaging.python.org/tutorials/installing-packages/ instead?
To Reproduce
I noticed this on https://pypi.org/project/google-re2/#files right after I sent it to someone who probably needs that documentation. :(
My Platform
N/A
Additional context
N/A

Looks like this is caused by https://github.com/pypa/packaging.python.org/issues/1026, which mentions /installing/ should redirect to /tutorials/installing-packages, but it's masked by a redirect to /en/latest.

This should now be resolved per https://github.com/pypa/packaging.python.org/issues/1026#issuecomment-992538633.


cctail abruptly stops with no error messages

Description
I am using this solution to ingest many logs from Salesforce Commerce Cloud (~200k logs/hour). Ingesting this many logs seems to make the cctail application unstable. Every few hours, I will see on NewRelic that log ingestion has abruptly stopped. When I checked the container, everything appeared to be normal (the container was running and all applications inside the container were in a RUNNING state). Docker stats was also normal with no concerns regarding CPU, memory, or I/O.
The only thing that was not normal is the cctail application logs. I am running cctail in debug mode using the CCTAIL_ARGS environment variable (CCTAIL_ARGS=-d) as mentioned in the documentation. So the cctail application will log each time it polls a log file on Salesforce. I noticed that the cctail application was no longer logging its requests to Salesforce, despite cctail being in a RUNNING state. It also does not produce any error logs at the time of the crash, it just stops logging. The cctail application stopped logging at the same time that NewRelic stopped receiving Salesforce logs.
It seems like cctail is either crashing or being killed. I initially tested this container against my development environment which is generating far fewer logs, and I did not see this issue. This issue only showed itself once I started ingesting a larger number of logs.
Environment Details

Docker version 18.09.7, build 2d0083d
Red Hat Enterprise Linux (version 7.9)

I have modified the cctail command in the /etc/supervisord.conf file to include the --max-old-space-size node option to increase the heap size of the cctail application.
command=sh -c "node --max-old-space-size=2048 cctail/dist/cctail.js %(ENV_CCTAIL_ARGS)s | awk '{ print strftime(\"cctail:\ %%Y-%%m-%%d\ %%H:%%M:%%S\ -\"), $0 }'"

I have not been observing the crashing behavior mentioned in the initial issue since I made this change. Will continue to monitor and update this issue with any findings.

I did some debugging to determine the root cause of this issue. I modified the supervisor.conf file to enable garbage collection trace on cctail (with node runtime option --trace-gc). Using this, I could see that the GC was filling up quite quickly and maxing out at around 2GB. This inevitably resulted in a JavaScript Heap Out of Memory error causing cctail to exit.
I modified the supervisor.conf file again to increase the heap size to 4GB (with node runtime option --max-old-space-size). This temporarily worked until the GC eventually maxed out at around 3.5GB which is when the system actually ran out of memory and killed the cctail process. I saw the following message in the syslog:
Out of memory: Kill process 24993 (node) score 535 or sacrifice child
I'm not sure if this is considered a memory leak or just a consequence of the design of cctail. Either way, cctail cannot currently handle this large number of logs. To solve this, I ended up creating multiple instances of this container and modifying the log.conf.json file in each container so that each container only ingests one or two log types. This way, the load is spread across multiple instances instead of processing this large number of logs on a single container.
Just in case anyone is using this solution to ingest a large number of logs and is facing this same issue, I recommend the solution above.


why use alpha/r in stead of alpha?

Paper said we need scale the lora learning rate with alpha/r. But why use alpha/r in stead of alpha?

The magnitude of the preactivation after B is \Theta(r) after training with adaptive optimizers. Dividing by r stabilizes it and makes HP tuning easier as mentioned at the end of the paragraph.

The magnitude of the preactivation after B is \Theta(r) after training with adaptive optimizers. Dividing by r stabilizes it and makes HP tuning easier as mentioned at the end of the paragraph.

Thx!
But I want to further know about "The magnitude of the preactivation after B is \Theta(r)", would you like to show us an explanation? @edwardjhu


Avoid/Control clear-screen behaviour

Clear and concise description of the problem
Since https://github.com/vitest-dev/vitest/pull/2228 vitest clears the screen in both watch and non-watch mode which I find rather disturbing because it removes potentially useful information from commands that ran before.
https://github.com/vitest-dev/vitest/issues/2070 specifically only requested the clear-screen only for watch mode so I think the implementation forgot about non-watch mode.
Suggested solution
I would suggest to never clear the screen when in non-watch mode and make the behaviour of the clear in watch mode configurable, like vite does via the clearScreen option.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Vitest already respects clearScreen option

Fixed in https://github.com/vitest-dev/vitest/commit/c3d89504e1b8b3cf8d055ef4f70ca2019e60fe9d

Thanks.

Vitest already respects clearScreen option

I don't see this option documented in either --help or on https://vitest.dev/. Are the docs missing?

It’s an option in Vite config (since Vitest extends Vite config, it inherits the same options), its not available ad a CLI option.


Provide BlockVolume support

To be able to stack storage classes on top, for example rook, we should support BlockVolumes.

implemented but untested


crashes on debian 10.1, python 3.7.3

From a fresh clone of this repo, master branch, I modified the first line to be this:
#!/usr/bin/python3

It crashes:
./ssh-ident me@somehost

Traceback (most recent call last):
  File "./ssh-ident", line 316, in <module>
    import distutils.spawn
ModuleNotFoundError: No module named 'distutils.spawn'

Python3's distutils module has a different interface from python2, but my sense is that you're mainly using it for the find_executable feature.  There is shutil.which() in python3 that might be a good alternative.

I created a pull request for this at #56

I have this very issue.


Use only one Dockerfile

As both Dockerfiles are totally identical, let's use only one to ease the maintenance and reduce the build time.

In addition to this don't use ubuntu:20.4 it is failing.
Building nginx-relay
Step 1/8 : FROM ubuntu:20.04
20.04: Pulling from library/ubuntu
ERROR: Service 'nginx-relay' failed to build: no matching manifest for unknown in the manifest list entries

I changed it to debian:buster and it worked fine.

In addition to this don't use ubuntu:20.4 it is failing.

I've not encountered this issue when playing with this project.


Artifact versions ordering

When Artifact CRs are applied in parallel, there is a non deterministic provisioning of schemas in the registry.
For instance if I apply:
apiVersion: artifact.apicur.io/v1alpha1
kind: Artifact
metadata:
  name: x-1
...
spec:
  artifactId: x
  type: AVRO
  version: '1'

and at the same time:
apiVersion: artifact.apicur.io/v1alpha1
kind: Artifact
metadata:
  name: x-2
...
spec:
  artifactId: x
  version: '2'

sometimes the different versions will be registered as 1 and 2 (2 is being the latest), and sometimes it will be 2 and 1 (1 is the latest).
we need versions to be strictly ordered in a deterministic way.
specifically if on day 1 I push version 2, it should be considered the only and latest version.
and if on day 2 I push version 1, then it should create version 1 in the registry prior to version 2, and latest stays on version 2.
with that improvement, I could apply Artifact CRs in any order, which means also that I could apply them in parallel.

This is an interesting use-case.  The issue we have today is that version numbers are not meaningful to the registry, especially when provided by the client (as I think is being done in this case).  In other words, registry doesn't really know that 2 should come after 1.  So if 2 is added first, and then 1 is added, registry will think that 1 is the latest version.  Which is obviously not ideal.
So it would be up to the client to ensure proper ordering of operations based on whatever criteria is desired.  In this case, I think you're suggesting (correctly) that the sync operator should sort the versions to ensure consistent ordering.  I agree, although we should probably support three (configurable?) sorting algorithms:

Simple numeric (interpret the version as a number and do a numeric sort)
Simple alphabetic
Semver

The issue we have today is that version numbers are not meaningful to the registry, especially when provided by the client

hmm. that is not what I see. If I create a spec with:
spec:
  name: my-movie
  artifactId: org.acme.Movie
  groupId: default
  version: 'foo'

then I do see it in the registry, as expected:
$ curl -k  https://broker-schema-registry-infra-kafka-sbiz.apps.dev.ocp.dev.biz.lodh.com/apis/registry/v2/groups/default/artifacts/org.acme.coucou.Movie2/versions
{"count":1,"versions":[{"name":"my-movie","description":"super movie avro","createdOn":"2022-08-17T15:36:55+0000","createdBy":"","type":"AVRO","labels":["avro","kafka","ocpdeploy"],"state":"ENABLED","globalId":165,"version":"foo","properties":{"custom1":"bubu","custom2":"lala"},"contentId":98}]}

So it would be up to the client to ensure proper ordering of operations based on whatever criteria is desired.

sorting is one thing when all artifacts are there is one thing.
but I think this should support out of order apply as well.
in other words, I should be able to apply v2, then later v1, and still end up with v1 being considered as an older version compared to v2 (i.e. v2 is latest).
this is very important because gitops tooling does not always enforce strict ordering. it assumes desired state principle only.
for instance argo will enforce strict ordering between waves  only. and using waves to order artifacts is overkill.
inside a wave, argo will order object types (e.g. ConfigMap first). But inside an object type (e.g. Artifact), I am not sure there is a strict guarantee that v1 will be applied before v2, just because there are in sequence in the same document.
and even if they are, and argo honors this, argo will not wait for the individual statuses. It will only do this at the end of the wave.
This opens up edge cases were argo applies v1, and for some reason the operator fails to create the artifact (e.g. temporary connectivity issue with the registry), then argo applies v2, and the operator creates v2 as the latest (without v1).
later the operator retries v1 in its reconcile loop, and add it to the list of versions. now v1 is latest.
now it depends on the operator failure handling. we do not want to guess.
in this situation, I should be able to apply v1 then v2, or v2 then v1, with the exact same result, assuming I chose the versions to be strictly ordered according to the version field.

we should probably support three (configurable?) sorting algorithms:

seems reasonable.

this is very important because gitops tooling does not always enforce strict ordering. it assumes desired state principle only. for instance argo will enforce strict ordering between waves  only. and using waves to order artifacts is overkill. inside a wave, argo will order object types (e.g. ConfigMap first). But inside an object type (e.g. Artifact), I am not sure there is a strict guarantee that v1 will be applied before v2, just because there are in sequence in the same document. and even if they are, and argo honors this, argo will not wait for the individual statuses. It will only do this at the end of the wave. This opens up edge cases were argo applies v1, and for some reason the operator fails to create the artifact (e.g. temporary connectivity issue with the registry), then argo applies v2, and the operator creates v2 as the latest (without v1). later the operator retries v1 in its reconcile loop, and add it to the list of versions. now v1 is latest. now it depends on the operator failure handling. we do not want to guess. in this situation, I should be able to apply v1 then v2, or v2 then v1, with the exact same result, assuming I chose the versions to be strictly ordered according to the version field.

Understood.  We've been discussing the gitops use-case internally the last week or two, actually.  There is definitely some work to do to facilitate it.  There are some design choices (immutability of versions, for example) that are impactful.  We may need to loosen some restrictions we currently have, and add some features we currently do not have (like deleting versions), in order to properly support the use-case.  With the assumption that in a GitOps configuration, only one (or very few) service accounts will be responsible for all WRITE operations.  And users will be restricted to READ-ONLY access.

With the assumption that in a GitOps configuration, only one (or very few) service accounts will be responsible for all WRITE operations. And users will be restricted to READ-ONLY access.

yes. this is exactly our situation.

hello, any news on this?

Nothing concrete at the moment.  The GitOps use-case is important and something we're talking about in various contexts here at Red Hat.  But we don't have a specific path planned yet, I'm sorry to say.

any news on this?

The only news we have for this is that we have started working on a Gitops storage variant for Apicurio Registry v3 that will add those capabilities to the repository.


[BUG] Incorrect Git tag for version 2.1.1

Describe the bug
Currently, the 2.1.1 tag points to commit https://github.com/Ousret/charset_normalizer/commit/47c8e714accc5aa8a9446319a9a6f3f002f2e248. However, the version bump from 2.1.0 to 2.1.1 happened afterwards, in commit https://github.com/Ousret/charset_normalizer/commit/86cda88ce13c8456c229b7564c08fc98b44a7e95. Due to this, if one checks out tag 2.1.1 and installs the package, the installed package has the incorrect (2.1.0) version.
To Reproduce
git clone https://github.com/Ousret/charset_normalizer && cd charset_normalizer
git checkout 2.1.1
pip install .
# (....) Successfully installed charset-normalizer-2.1.0

Expected behavior
Version of installed package should match the tag (2.1.1)
Additional context
This can be fixed by rewriting the tag and pushing:
git tag --force 2.1.1 86cda88ce13c8456c229b7564c08fc98b44a7e95
git push --force --tags

Thanks for the report, this is now resolved.


running as a windows services

I'm using nssm to install the otel collector as a windows service.
But every-time the service wants to start it goes in pauze mode.
What i'm i missing to install the collector as a windows service?
Using collector version 0.60.0.
thx
Timmy

I'd be interested to know how it installs the service? Maybe a windows registry screenshot? I can't get the service to start from a new-service command in powershell

@elitistphoenix if you're running into issues w/ v0.63.0, it's possibly related to https://github.com/open-telemetry/opentelemetry-collector/issues/6433

I don't think we have any maintainers using Windows, we need your input and engineering help to determine what's the cause and how to fix it.

I'll try to implement this, we have already some go apps which we install as service on windows.

@Outek that would be awesome thx!

I'd be interested to know if @Outek had any success in turning the Otel collector into a  windows service as I find myself in the position of using a service creation tool like NSSM 🙏

Hey @simcot I think I've run into the same problem when using NSSM. After adding the env variable "NO_WINDOWS_SERVICE=1" (as mentioned here ) to the configuration on NSSM, the new service started correctly. Hope this helps!

@open-telemetry/collector-maintainers I didn't test this on NSSM, I'm not familiar with it, but, I think we can close this one, since detection to run as a service was fixed via #9042

Closing, please file a new issue if you have trouble with running the Collector as a Windows service


chess.js in Angular 7

I try to import chess-js to angular 7 with this type:
1º npm i @types/chess.js  . With this way the error is : chess_js__WEBPACK_IMPORTED_MODULE_2__.Chess is not a constructor
. This error is in @types/chess.js/index.d.ts in declaration of Chess
export const Chess: {

    (fen?: string): ChessInstance;

    new (fen?: string): ChessInstance;
};

2º I try https://github.com/jhlywa/chess.js/pull/167/commits/89e9ea6f98756e21c3e1ed075cb0d867ddab6b13 like the test file
import * as ChessJs from 'chess.js';
import { Chess } from 'chess.js';

    let chess = new ChessJs.Chess();
    console.log(chess.ascii());

and this error and other:
ERROR in src/app/modulos_lichess/play.ts(2,17): error TS2305: Module '"chess.js"' has no exported member 'ChessInstance'.
src/app/modulos_lichess/play.ts(81,23): error TS2339: Property 'san' does not exist on type 'string | VerboseMove'.

Has anyone succeeded in importing chess.j to angular?

I've used chess.js in an ionic 4 / angular 7 project (without type defs) : https://github.com/supertorpe/chessendgametraining

@digither i was having the same issue when i was trying to import chess.js to vue.js application.
I tried to add the @types/chess.js and create my own declaration, but i didn't get success in those ways.
I solved my problem using the following import:
const Chess = require('chess.js');

So i can call the constructor:
const chess = new Chess();
console.log(chess.ascii());

it happens because of this code in https://github.com/jhlywa/chess.js/blob/master/chess.js:
/* export Chess object if using node or any other CommonJS compatible
 * environment */
if (typeof exports !== 'undefined') exports.Chess = Chess
/* export Chess object for any RequireJS compatible environment */
if (typeof define !== 'undefined')
  define(function() {
    return Chess
  })

Webpack supports both exports and define. So if you use webpack "Chess" will be imported as default.
So you could do:
import Chess from "chess.js";
But then it will not match the type definitions in<EMAIL_ADDRESS>Instead, I suggest disable AMD in webpack config:
{
  test: /chess.js/,
  parser: {
    amd: false,
  },
},


Code_of_Conduct.md

Please assign me to make a code of conduct file.

Please assign me to make a code of conduct file.


Upgrade to Junit 4.13

Removed the third_party module and all usage of
JunitBackPort. replacing them with Assert.assertThrows.

This change is

quick question, does this totally remove Junit 4.12 from our dependencies? I have been having dependency issue in Intellij after merging the junit upgrade. The symptom is that Assert.assertThrow cannot be found as Intellij uses Assert from 4.12 instead of 4.13, I guess it is because both versions exist in the classpath and it depends which one is loaded first. BTW, I can still build the project from command line, it is just Intellij having this problem.

Reviewable status: 0 of 22 files reviewed, all discussions resolved (waiting on @jianglai)

It should, unless we have other dependencies on 4.12.


feat(common): use autoware_cmake to avoid Boost warning

Description
https://github.com/autowarefoundation/autoware.universe/pull/849 からBoostのwarningが出ているパッケージだけを抜き出して適用
Related Links
https://tier4.atlassian.net/browse/AEAP-488
Tests performed

下記のコマンドでビルドしてBoostのwarningが出ないこと
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --catkin-skip-building-tests --parallel-workers 8 --packages-up-to  $(colcon list --base-path src/autoware/universe/common/ | awk '{print $1}')

Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Codecov Report

:exclamation: No coverage uploaded for pull request base (beta/v0.3.16@ee0f0d2). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.16    #528   +/-   ##
==============================================
  Coverage                ?   9.84%
==============================================
  Files                   ?     426
  Lines                   ?   35769
  Branches                ?    8016
==============================================
  Hits                    ?    3522
  Misses                  ?   28861
  Partials                ?    3386

Flag
Coverage Δ

differential
9.84% <0.00%> (?)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Remove scipy.zeros from Python Utilities

In GitLab by @stuartmuldrew on Sep 11, 2020, 12:17
Following python warning:
%../process/utilities/mfile_comparison.py:117: DeprecationWarning: scipy.zeros is deprecated and will be removed in SciPy 2.0.0, use numpy.zeros instead
values = scipy.zeros(n)

This has been done but bizarrely it fails the integration test for just changing scipy to numpy !!!!

Fixed by #3149, issue was not linked to PR properly so was never closed


Fix URL query identifiers

When constructing the final URL, use the original identifier.
Before:
http://localhost:8081/api/channel/files?query_q=git
After:
http://localhost:8081/api/channel/files?q=git
cc @mattjbray

Thanks! I was a bit overzealous with the find-replace in the test suite.


Variable renaming in decompiled function

I can't figure out how it is possible to rename generated variables in the decompiled function like in IDA or Ghidra.

@xkubov ?


Add support for user managed identity for policy assignments

Overview/Summary
Azure policies who implement a deploy if not exist (DINE policies) require an identity to have the right permission to deploy the missing resources. By leveraging the user managed identities, customers can reduce the number of system identities created by the assignments by using a user managed identity. The other benefit of using a user managed identity is the decouple the role assignment from the policy.
This PR fixes/adds/changes/removes

Add support for UserAssigned msi to a policy assignment
Support migration from SystemAssign to UserAssigned by overriding the policy assignment in the lib folder
Closes issue #712

Breaking Changes
no breaking changes
Testing Evidence
Updated examples/400-multi-with-orchestration to show how to modify an existing policy assignment from SystemAssigned to UserAssigned
# module.core.module.alz.data.azapi_resource.user_msi["/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/policyAssignments/Deploy-VMSS-Monitoring"] will be read during apply
  # (depends on a resource or a module with changes pending)
 <= data "azapi_resource" "user_msi" {
      + id                     = (known after apply)
      + location               = (known after apply)
      + output                 = (known after apply)
      + parent_id              = (known after apply)
      + resource_id            = "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/msi/providers/Microsoft.ManagedIdentity/userAssignedIdentities/ms1"
      + response_export_values = [
          + "properties.principalId",
        ]
      + tags                   = (known after apply)
      + type                   = "Microsoft.ManagedIdentity/userAssignedIdentities@2018-11-30"
    }

  # module.core.module.alz.azurerm_management_group_policy_assignment.enterprise_scale["/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/policyAssignments/Deploy-VMSS-Monitoring"] will be updated in-place
  ~ resource "azurerm_management_group_policy_assignment" "enterprise_scale" {
        id                   = "/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/policyAssignments/Deploy-VMSS-Monitoring"
        name                 = "Deploy-VMSS-Monitoring"
        # (9 unchanged attributes hidden)

      ~ identity {
          ~ identity_ids = [
              + "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/msi/providers/Microsoft.ManagedIdentity/userAssignedIdentities/ms1",
            ]
          ~ type         = "SystemAssigned" -> "UserAssigned"
            # (2 unchanged attributes hidden)
        }

        # (1 unchanged block hidden)
    }

  # module.core.module.alz.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/policyAssignments/Deploy-VMSS-Monitoring"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/roleAssignments/1e6eb635-dc9a-54d5-9bb5-7506132bff67"] must be replaced
-/+ resource "azurerm_role_assignment" "for_policy" {
      ~ id                               = "/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/roleAssignments/1e6eb635-dc9a-54d5-9bb5-7506132bff67" -> (known after apply)
        name                             = "1e6eb635-dc9a-54d5-9bb5-7506132bff67"
      ~ principal_id                     = "9ce8936e-cdd6-4a7c-a2a5-0e695c9ef8a5" # forces replacement -> (known after apply) # forces replacement
      ~ principal_type                   = "ServicePrincipal" -> (known after apply)
      ~ role_definition_name             = "Virtual Machine Contributor" -> (known after apply)
      + skip_service_principal_aad_check = (known after apply)
        # (2 unchanged attributes hidden)
    }

  # module.core.module.alz.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/policyAssignments/Deploy-VMSS-Monitoring"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/roleAssignments/55ffe1be-e389-5d46-9488-8d6915a8b60e"] must be replaced
-/+ resource "azurerm_role_assignment" "for_policy" {
      ~ id                               = "/providers/Microsoft.Management/managementGroups/myorg/providers/Microsoft.Authorization/roleAssignments/55ffe1be-e389-5d46-9488-8d6915a8b60e" -> (known after apply)
        name                             = "55ffe1be-e389-5d46-9488-8d6915a8b60e"
      ~ principal_id                     = "9ce8936e-cdd6-4a7c-a2a5-0e695c9ef8a5" # forces replacement -> (known after apply) # forces replacement
      ~ principal_type                   = "ServicePrincipal" -> (known after apply)
      ~ role_definition_name             = "Log Analytics Contributor" -> (known after apply)
      + skip_service_principal_aad_check = (known after apply)
        # (2 unchanged attributes hidden)
    }

Plan: 2 to add, 1 to change, 2 to destroy.

As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.

/azp run unit

/azp run update

Hi Laurent,
I need this user assigned managed to put in the policy assignment ASAP. Could you please help to push into the main branch

And May I know any ETA when it will be release to main branch?

Hi all,
Same for me, thanks for letting us know when we can expect the feature release!

@matt-FFFFFF can you explain why you have reverted the commit after the 5.0.0 release? https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/commit/3d7e1face7f120a35f53994e9712a900a71a1185#diff-7e1164cc87147ec53c109f9360619dae48a9e676ca8020b7c6d152f43f3c4ddd

Hi. As described in #844. The commits from your branch were accidentally merged after an attempt to resolve some merge conflicts.
Afterwards, the tests did not pass and I could not fix the issue. I was left with no choice but to revert.


[PDI-9920] [fix ROUND(Integer, -p)] Calculator ROUND (A) function use…

…s a different rounding method than ROUND (A, B)
Additional fix according to http://jira.pentaho.com/browse/PDI-9920?focusedCommentId=225541&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-225541
@mattcasters , @brosander , @mattyb149, could you review it?

@ivanpogodin I'm picking up checkstyle errors

checkstyle fixed
@mattcasters , @brosander , @mattyb149, could you review it?

@mattcasters , @brosander , @mattyb149, could you review it?


Mock Test for AWS Batch Service. AWS StreamtoS3Buffer (incomplete)

New pull request created with changes effected


Missing scrollbars

I must admit I am not entirely sure whether this is an issue with the script specifically or with AutoHokey itself; however, when used on a screen with a high level of zoom, say 150%, not all the content of the window is displayed, but there are also no vertical scrollbars, making it impossible to view the whole window.
If the scrollbars are controlled by the specific script, would you think it possible to add them?

This is mostly an issue with AutoHotkey. I would like scroll bars as well but there's no trivial solution for adding them like you would other GUI elements in AHK.
This means that sadly, scrollbars will not be added to the script in the foreseeable future.


Bug with multiple upload fields

I have multiple upload fields per page. Every time I delete an image from one of the fields, all images in all other fields are replaced by the images in that field.
Before:

After trying to delete the first image in the field:

I already re-downloaded grav and copied the user data to the new install.  I don't know if it's the same for @lepascal, but it doesn't seems to happen when you properly delete the image (I mean deleting the file itself by clicking the trash icon), but when you remove the file from the field (using the cross icon instead).
I noticed it on both Grav 1.4.2 and 1.4.3.

@guins @w00fz
It is the same behavior with me. But clicking the trash icon on an upload field deletes the field with all its files. This has nothing to do with the media.header_order field, which is working fine.
Things I have tried so far:
Changing the upload location from/to page folder
Randomizing file names
Hiding and un-hiding the media.header_order field

Just a question. Why do you have to have the whole upload funcitonality for every image? I solved similar request by using page media select for every image and then just picked an image from the uploads. Would that logic help in your case?

@drnasin I use it the same way, I think it much more user-friendly to be able to upload in-place instead of having to upload files / go to gallery tab / select for each field an image file.
With a lot of images, it could easily become a nightmare for the contributors 😅
By the way, I came here to say that I have the exact same bug, I will try to investigate

This should now work with Grav 1.6 + latest (RC) plugins.


MeasureLayout is deprecated in the new architecture. Is there an alternative?

Description
The method of measureLayout used in the new architecture is inconsistent with that used in the old architecture.
Steps to reproduce
无
React Native Version
0.72.5
Affected Platforms
Other (please specify)
Areas
Fabric - The New Renderer
Output of npx react-native info
view.measureLayout(
						nodeHandle,
						measureCallback,
						() => {
							// console.log('Failed to measure Drax view in relation to parent nodeHandle');
						},
					);

Stacktrace or Logs
ref.measureLayout must be an instance

Reproducer
no
Screenshots and Videos
No response

const measureWithHandler = useCallback(
(measurementHandler?: DraxViewMeasurementHandler) => {
const view = viewRef.current;
if (view) {
const nodeHandle = parentNodeHandleRef.current;
if (nodeHandle) {
const measureCallback = measurementHandler
? buildMeasureCallback(measurementHandler)
: updateMeasurements;
// console.log('definitely measuring in reference to something');
// UIManager.measureLayout(
// 	findNodeHandle(view),
// 	nodeHandle,
// 	() => { },
// 	() => {
// 		measureCallback
// 	}
// )
				view.measureLayout(
					nodeHandle,
					measureCallback,
					() => {
						// console.log('Failed to measure Drax view in relation to parent nodeHandle');
					},
				);
			} else {
				// console.log('No parent nodeHandle to measure Drax view in relation to');
			}
		} else {
			// console.log('No view to measure');
		}
	},
	[
		parentNodeHandleRef,
		buildMeasureCallback,
		updateMeasurements,
	],
);

ERROR  Warning: Warning: ref.measureLayout must be called with a ref to a native component.

Hi @Qy742698! Thanks for the question.
You have 2 alternatives, depending on your use case:

https://reactnative.dev/docs/direct-manipulation#measurecallback
https://reactnative.dev/docs/direct-manipulation#measureinwindowcallback


Negative test case for loadOccupancyMap failed.

Test case:
Should get correct data loadOccupancyMap() -  Negative -

@lisa0314 please take over this issue.


fixed syntax error of an example

Thanks a lot for taking the time to fix this.

Thanks again for this fix. I have merged it into the 'develop' branch.


Versioning

The versioning with autotools is different from what was used so far. Version numbers are defined in configure.ac and then exported to generated files in config/ .
I do not particularly like the way it sets the version now, as opposed to what we had previously. Maybe we can work on a better solution to the define the macro.
Also adds back the generate build.h file.

First I do not think it is bad move the version numbers from clientversion.h into configure.ac. In that case the clientversion file should be removed. It is just a change of names. Have you considered moving JUST the version numbers into separate file? Is it allowed in the language? (what language is .am?)
Having the commit hash in the version helps when debugging. I do not think that the overcomplicated system of genbuild.sh, build.h, version.h cpp and more files is desired. I think that should be axed down as much as possible.

Axed clientversion and moved its code to version.h . Kept the extra definitions in version.h .

@thecharlatan That is fine. The pro file was just needed to maintain buildability while migrating.


Generate answer key

[ ] Function that takes in image and generates ascii key
[ ] Stores the key and a picture object
[ ] Anser key height and width will be image_height/80 and image_width/80

Created a method that breaks the image into blocks and then gets the average brightness of those blocks.

Done


hyprland/wokspaces mouse clicks on workspace not work

"modules-left": ["hyprland/workspaces", ....]

Activate action not work by mouse click, but mouse scrolling work fine:
"hyprland/workspaces": {
    "on-click": "activate",
    "on-scroll-up": "hyprctl dispatch workspace e+1",
    "on-scroll-down": "hyprctl dispatch workspace e-1"
}

Void Linux
Hyprland 0.26.0_1
Waybar 0.9.19

afaik you still need to apply the patch
http://wiki.hyprland.org/Useful-Utilities/Status-Bars/#compiling-manually

afaik you still need to apply the patch http://wiki.hyprland.org/Useful-Utilities/Status-Bars/#compiling-manually

In 0.9.19 version file workspace_manager.cpp already patched

@hvppydvddy We're tracking this issue here: https://github.com/Alexays/Waybar/issues/2271
This PR contains the changes you want: https://github.com/Alexays/Waybar/pull/2316
The module is still in development, it's maybe better to use wlr/workspaces with the hyprland patch for the time being.

this has been fixed already, you can use it (without any patches) by building from the main branch

"modules-left": ["hyprland/workspaces", ....]

Activate action not work by mouse click, but mouse scrolling work fine:
"hyprland/workspaces": {
    "on-click": "activate",
    "on-scroll-up": "hyprctl dispatch workspace e+1",
    "on-scroll-down": "hyprctl dispatch workspace e-1"
}

* Void Linux

* Hyprland 0.26.0_1

* Waybar 0.9.19

This should be closed, now. Workspace switching works in hyprland on wlr/workspaces with experimental enabled and hyprland/workspaces. The config displayed also doesn't even match supported properties in the module. https://github.com/Alexays/Waybar/wiki/Module:-Hyprland

a few days ago, the workspaces are not displayed anymore on my system.
doesn't work with "hyprland/workspaces" nor with "wlr/workspaces".
I am on arch and tested 9waybar, waybar-hyprland, waybar-hyprland-git) all with the same result

a few days ago, the workspaces are not displayed anymore on my system. doesn't work with "hyprland/workspaces" nor with "wlr/workspaces".
I am on arch and tested 9waybar, waybar-hyprland, waybar-hyprland-git) all with the same result. I added the workspaces another time in my bar and it showed me an empty slice and when I click on it I get sh: line 1: activate: command not found

wlr/workspaces won't work anymore
you probably have format:"{id}" instead of format:"{name}"

@MightyPlaza hey
I have tested it with
	"hyprland/workspaces": {
	"format": "{name}: {icon}",
	"format-icons": {
		"1": "",
		"2": "",
		"3": "",
		"4": "",
		"5": "",
		"active": "",
		"default": ""
	},

from the example code, doesn't work for me

are you sure you're using the hyprland/workspaces module?

@MightyPlaza thank you. I still had wlr in my modules-left, no clue why I missed that.
It is resolved. thx a lot

@MightyPlaza thank you. I still had wlr in my modules-left, no clue why I missed that. It is resolved. thx a lot

@Alexays mind closing this ? hyprland/workspaces click handling is implemented in https://github.com/Alexays/Waybar/pull/2316


Add pixels for multiple refreshes

Task/Issue URL: https://app.asana.com/0/72649045549333/1208470923077006/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#5094  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joshliebe and the rest of your teammates on  Graphite


Adds Beaker docker testing to .travis.yml

Adds CentOS 6 Beaker docker file
Adds travis matrix entry to run beaker-docker tests

Is beaker officially compatible with ruby 2.2 now?

I believe has for a while according to https://tickets.puppetlabs.com/browse/BKR-537

It looks like the issue is with beaker-rspec and some versions rspec, this seems to be the workaround: https://github.com/puppetlabs/puppetlabs-firewall/pull/597/files

To simplify things I switched it back to 2.1.0 anyways

Awww, the ticket likely explains the failure I've seen.  This module isn't pinning the rspec version so it should, in theory, be able to work.

Tangentially, https://github.com/jenkinsci/puppet-jenkins/pull/473 fixes the unit tests under puppet 4.2+.

Cool, was gonna say, those tests take ages and 1.9.3 is EOL now :smile:

I thought #473 has already been merged. so I just put it in.  It probably causes a merge conflict in the .travis.yaml.  My bad. ;(
1.9.3 is in the matrix as this is still the low bar for puppet 4.

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

It looks like travis lost a worker mid-build.  I have restarted the job.

Travis died mid build again :/

I've kicked it again.  If this keeps up, we may need to stand up a jenkins instance ;)

And I've kicked it again... what is going on?

@jhoblitt I'm not against spinning this up in the ci.jenkins-ci.org instance since it is fairly "official"
Should I file a ticket for that?

@rtyler That certainly wouldn't hurt!  From looking at the other jobs, it appears that the GitHub Pull Request Builder plugin is already installed.

@jhoblitt Does it make sense to remove the 1.9.3 tests if they're causing the issues? https://github.com/jenkinsci/puppet-jenkins/issues/509

@petems I suspect we may have to but note that puppet 4.x is technically supported on 1.9.3 and we are not using the AIO packages with travis.

@jhoblitt Can we move the 1.9.3 tests into allow_failure?

@petems 1.9.3 is still the default Ruby packaged up for a lot of people, myself included, running not-the-latest-versions of PE.
The error with the build in Travis isn't a segfault but something stopped outputting anything which to me means that somebody went either into an infinite loop or prompted for something on stdin.
I do not wish to remove 1.9.3. testing plz

Ok, will kill the issue then! :+1:

It looks like the ruby 1.9.3 build times have pretty consistently been longer than ruby 2.1.0.  Here is a build from ~4 months ago.
https://travis-ci.org/jenkinsci/puppet-jenkins/builds/86419131
Puppet 4.3.0 is just a tad slower than previous puppet versions, which is why we are all of a sudden hitting the travis 10min output limit.  However, at least once I have seen other ruby 1.9.3 combos fail as well.  We need to identify what test is taking slow long to execute.  As an interm, I think it would be reasonable to exclude the ruby 1.9.3/puppet 4.3 combo from the matrix.
Since I have convinced myself that the failure is not related to anything in this PR (it is also happening in #508), I'm going to go ahead and merge this.
@petems - I really appreciate the time you have put into this PR.  This module is in desperate need of acceptance tests that cover the jenkins<->puppet interface that rspec-puppet can't address.


docs: improve DIY and Releases docs

related: https://github.com/digitalbitbox/bitbox-base/issues/290
Because:

It was not mentioned that only eMMC is supported and booting from a
Mender MicroSD card does not work

This commit:

adds this note about only supporting eMMC
generally improves DIY and Releases docs

Merging this docs update, contains only .md files.


Performance data aggregation on file_age check

Hey there 👋
I've added the possibility to enable performance data aggregation on the file_age check.
There are two modes: One calculates the mean (average) over the sum of all checked files and directories. The second mode returns the median from those age checks.
I tried to respect all of your code guidelines and made sure to provide a test case as well. That being said, the test scenario ended up being really ugly and might suffer from inconsistencies as there's some time derivation caused by touch on certain file systems.
I also only edited the file3.py check since Python 2 dropped their complete support over 2 years ago by now and I don't want to encourage people to make use of something that's considered insecure and abandoned. Feel free to add this logic to the Python2 version as well if you wish to.
Here's the output of the test run on my testing environment:
[xxx@xxx file-age]# python --version | python3 --version
Python 2.7.5
Python 3.6.8
[xxx@xxx file-age]# ./test3
.............
----------------------------------------------------------------------
Ran 13 tests in 0.783s

OK
[xxx@xxx file-age]# lsb_release -a
LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: CentOS
Description:    CentOS Linux release 7.9.2009 (Core)
Release:        7.9.2009
Codename:       Core

Cleaned up the testing scenario. Hope this should fit your needs.

Thank you very much for you contribution :)


test: add docstrings mypy check

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[x] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #1410
Closes #<issue number>

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below

The test takes a bit too long to run (15-20minutes). Will see if there's another way to go about it.
It did find issues though
Checking narwhals/stable/v1/__init__.py all
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py col
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py nth
<string>:17: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py len
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py lit
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py min
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py max
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py mean
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py median
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py sum
<string>:15: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py sum_horizontal
<string>:17: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py all_horizontal
<string>:20: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

Checking narwhals/stable/v1/__init__.py any_horizontal
<string>:20: error: Name "IntoFrameT" is not defined  [name-defined]
Found 1 error in 1 file (checked 1 source file)

thanks a tonne for doing this!

It did find issues though

nice, I did suspect we'd find something which --doctest-modules wasn't picking up
Maybe even just running python on each example would be a good start, and be fast enough?

Thanks @EdAbati and @MarcoGorelli for the feedback! Will take another look


Update recommended version tp 3.6 in readme

Keep it in sync with hex.pm
Summary of changes
I'll review the commits, so I mostly want to understand the "why" rather than the "what"
Checklist

[ ] New functions have typespecs, changed functions were updated
[ ] Same for documentation, including moduledocs
[ ] Tests were added or updated to cover changes
[ ] Commits were squashed into a single coherent commit
[ ] Notes added to CHANGELOG file which describe changes at a high-level

Coverage remained the same at 72.116% when pulling 248612634e6d071128fe575785f024d8e7298289 on ryan-senn:patch-1 into 45424fa293066b210eaf94dd650707343583d085 on bitwalker:master.