module CLI commands renames

This implements a bare minimum subset of the polish described here and discussed separately: https://github.com/dagger/dagger/issues/6291#issuecomment-1911592394
Specifically, it's mainly just the stuff that's backwards incompatible, with the addition of dagger develop --sdk=... --name=... since it was trivial to support and needed as a follow-up to https://github.com/dagger/dagger/pull/6386
Changes in this PR

sync is renamed to develop

it also supports --name and --sdk flags for updating the name+sdk of a module that does not currently have those set
support for changing name + sdk of module with those already set will be a follow-up

init/install/develop/publish are all top-level commands under dagger now, not under dagger mod.

I left in stubs for the old dagger mod ... commands that redirect to the new command

dagger mod (for printing config) -> dagger config

no extra subcommands on dagger config yet, will bikeshed that in separate standalone PR, it just prints config information atm

dagger init

-m is not supported anymore, you can just specify an extra arg if you want to init at a path other than cwd
--name is optional and defaults to the name of the directory being init'd in

Follow-ups

install/update/uninstall

add support for dagger update to update existing deps
change install to fail if dep at different version already exists
add uninstall
--dry-run (if worth effort in short term, otherwise can backlog)
consider a more explicit syntax for install, re: https://github.com/dagger/dagger/pull/6533#issuecomment-1922358536

I also think the convention suggested of doing dagger -m MOD install dep may suffice instead

dagger config

decide on approach in terms of git config style, set/get, etc.
add support for setting+updating include/exclude

develop

support renaming a module with existing name and "re-sdk'ing" a module with existing sdk

Old PR description (outdated)

Expand
A few things worth detailing and/or discussing:
What to do with dagger mod?
This change currently leaves in dagger mod (no subcommands) with the same behavior as before of printing module configuration (name, sdk, source path, root path, dependencies, etc.)
This isn't awful, but I do feel a better name might be dagger config.
And at that point, I'd probably want to tweak dagger update such that:

dagger config - print the module configuration
dagger config update --name foo --sdk go - update the module configuration

I like that option the most, but holding off until I get feedback from others on this so I don't waste time 🙂
dagger update
This currently can only be used to set the name+sdk of a module that does not already have one set. E.g. this sort of use case that's possible now via https://github.com/dagger/dagger/pull/6386:

dagger init - create an empty nameless+sdkless module
dagger install<EMAIL_ADDRESS>- add a dependency that can now be invoked with e.g. dagger call -m coolmod
dagger update --name mymod --sdk go - now initialize a real module with the deps from before

Attempts to update the name/sdk of a module that already has those set result in an error.
The reason for this restriction at the moment is that actually updating the module name/sdk from existing values is a bit thornier:

If you rename your module, in at least the go SDK you'd need to also update your code to use that name in the structs, but obviously much better would be if we did that automatically somehow

Need to double check if true in other SDKs @helderco @TomChv
One alternative option is to just accept the papercut around updating module code and print a helpful message

If you change your SDK, we can't translate your existing code into the new SDK lang, but it's also not clear if we should delete it (often fine, but it's scary to delete user files)

So starting out with errors in these cases made the most sense, but easy to iterate on too.

If you rename your module, in at least the go SDK you'd need to also update your code to use that name in the structs, but obviously much better would be if we did that automatically somehow

Need to double check if true in other SDKs

Yes, that's mostly true. Only in the Python SDK, if you use top-level functions instead of a class, then you don't need to update the code if you rename the module. The Python SDK dev module is an example of this. There's nothing in code referencing the PythonSdkDev object.
However, I've been rethinking the support for top-level functions in Python. Even though there's usually a preference for functions over classes in the ecosystem, over time we've added state in the form of object fields, constructors, main object description..., so I'm worried that users will start with functions and find the need to upgrade to a class pretty often, so I've been considering deprecating the top-level functions support.
There was a lot of pushback in the React community because the same time happened where you could create components with either functions or classes. People preferred the simplicity of functions, but had to upgrade to a class for more "advanced" lifecycle hooks. It took some time but later they implemented hooks in a way that could be used in functions so that took care of it.
Coming back to changing code on a rename, we could make this easier if the main object wasn't named after the module, but instead be something static that the engine would then rename automatically. Same as in GraphQL you have the Query object type that's mandatory. Then this static and conventionalized class name would be handled in codegen and engine so there's less to worry about on a rename.

This isn't awful, but I do feel a better name might be dagger config.
And at that point, I'd probably want to tweak dagger update such that:

dagger config - print the module configuration
dagger config update --name foo --sdk go - update the module configuration

I like that option the most, but holding off until I get feedback from others on this so I don't waste time 🙂

Yeah, I like dagger config. If we add support for the $HOME/.config/dagger.json file later, we can use dagger config --global update ....

sync is renamed to develop

👍 I think develop should also take care of initializing the SDK if needed. This way dagger develop is all you ever need to run to start developing.
Example usage scenario, starting from a codeless module:
$ dagger develop
Error: no SDK configured. Please specify one with --sdk
$ dagger develop --sdk go
Error: no module name configured. Please specify one with --name
$ dagger develop --sdk go --name mymod
Saving new SDK configuration: Go
Downloading SDK...
Building SDK...
Initializing SDK...
No source file detected. Generating template...
Generating source files...
To start developing, edit ./main.go
$

Then to re-generate as you develop:
$ dagger develop
Generating source files...
To start developing, edit ./main.go

You can change SDK, but it's disruptive and expected to be uncommon.
$ dagger develop --sdk python
Error: SDK is already configured. Use --force to start over with a new SDK.
$ dagger develop --sdk python --force
Saving new SDK configuration: Python
Downloading SDK...
Building SDK...
Initializing SDK...
No source file detected. Generating template...
Generating source files...
To start developing, edit ./src/main.py

dagger update can be used to set name+sdk of module

I think that is wrong, dagger update should be for updating installed dependencies:
dagger update [--all] [MODULE_NAME...]
I think it's best to keep configuration CRUD out of it.
Open question: does dagger update also update the SDK itself (ie, update to the latest version of the SDK), or should that be a flag in develop?

Option 1: dagger update [--sdk] (remaining question: does --all imply --sdk?)
Option 2: dagger develop [--update-sdk]
Option 3: a new command for sdk: dagger sdk update. But I'm trying to avoid too many subcommands if possible..

Thoughts?

What to do with dagger mod?
This change currently leaves in dagger mod (no subcommands) with the same behavior as before of printing module configuration (name, sdk, source path, root path, dependencies, etc.)

Ha, I didn't even know you could do that :)

This isn't awful, but I do feel a better name might be dagger config.

dagger config - print the module configuration

Yeah that's pretty good.

dagger config update --name foo --sdk go - update the module configuration

This is where we are going to hit the limits of CLI crud.  I don't know if mapping each top-level key to a flag will be enough - for example how do you manage root-for which is a list?
Possible options:

git config style. I don't remember what it is, but it exists so worth using as a baseline :)
Specialized map keys to subcommands:

dagger config: print configuration
dagger config set KEY VALUE: set a configuration key. Note, making KEY a subcommand makes it enumerable.
dagger config get KEY: print the value of a key

Not allow generic config crud, and use specialized commands instead, for example dagger develop --sdk to change the SDK field; dagger install to change the Dependencies field, etc. Then just have dagger info to print information about the current Dagger configuration - including the contents of your config, but also engine version, etc.

dagger update
This currently can only be used to set the name+sdk of a module that does not already have one set. E.g. this sort of use case that's possible now via #6386:

dagger init - create an empty nameless+sdkless module
dagger install<EMAIL_ADDRESS>- add a dependency that can now be invoked with e.g. dagger call -m coolmod
dagger update --name mymod --sdk go - now initialize a real module with the deps from before

See above my note about using dagger develop for that.

We're also going to need:

dagger uninstall (not urgent, but should fit in the model)
A way to check for available versions of dependencies without actually installing them - --dry-run for install and update?
A command for managing root-for. How will that work?

Note from Nipuna about another adjustment I think we should consider to dagger install syntax: https://discord.com/channels/707636530424053791/1202734818358595635/1202735318403645480
He was in a dir for module A and wanted to install ../b and ../c and ran the command dagger mod install -m ../b ../c, reasonably intuiting that would mean "install ../b and ../c to the current module directory".
But the syntax actually meant "install ../c to module ../b", with -m ../b meaning "install to module at ../b and the trailing ../c being the module to install.
He suggested having more explicit flags here like:
dagger mod install --source a --target b

The exact name of the flags is worth bikeshedding, but I fully agree that more explicit flags here would result in more obvious syntax.

Just adding as a comment here in case it makes sense to tackle. Otherwise will spin out to separate issue.

From @shykes, we should retire --workdir since it's mostly redundant with -m for module commands now.
I think at the very minimum it should not be a top-level flag on dagger and only be used by some of the older subcommands like listen, the hidden SDK util session command, etc. But maybe even those no longer need it.

I have a few items for a follow up left from (see Todo):

https://github.com/dagger/dagger/pull/6549

I've been changing PersistentFlags to Flags a lot these past few days. Just because of all the rebases/new/changed flags and just giving priority to other things like text wrapping so never commiting. But I did start experimenting with removing "Global Flags" from --help.
For TUI and module flags, once the flags are parsed there's no sense continuing to have them available on sub-commands. It's too late to apply. Most of the others could be shown only on the root dagger help command. Some also on top-level commands, but no further.

For TUI and module flags, once the flags are parsed there's no sense continuing to have them available on sub-commands. It's too late to apply. Most of the others could be shown only on the root dagger help command. Some also on top-level commands, but no further.

I like that!

👍 I think develop should also take care of initializing the SDK if needed. This way dagger develop is all you ever need to run to start developing.

Yep that makes sense to me. My only source of hesitation was that there's a lot of fields in dagger.json and it's not always clear which command is for updating which field. But I think the idea could be that:

modifying any settings that involve module references gets it's own specialized subcommand

e.g. dagger install (modifies dep mod refs), dagger develop (modifies sdk mod refs)

all other settings get bucketed into dagger config

e.g. include, exclude, root-for

I think that is wrong, dagger update should be for updating installed dependencies:

Just for context, updating deps today looks like e.g.:

Install new dep not already present: run dagger mod install github.com/foo/bar/depmod

This results in github.com/foo/bar/depmod@<latest commit> being newly added to your list of dependencies

Later, you want to update to the latest commit: run dagger mod install github.com/foo/bar/depmod

The engine knows that you already have a different version of depmod in your dependencies so it replaces the old entry with github.com/foo/bar/depmod@<new latest commit>

The above works when specifying @<tag/commit/etc.> too, the idea being that the engine will always replace an existing different version of the dep with the one specified in install.
I do like having a separate command for this though since it would be much more explicit and obvious in many ways. And also agree that we'd then want dagger update to be for that rather than updating arbitrary config (which can instead be bucketed in dagger config in one form or another)
In this new model, I think it would make sense for dagger install to now fail if you try to install a dep that is already present at a different version. Just double checking others agree too.

On a high-level note: I'm going to update this PR to just contain the things that seem clear in terms of consensus and split out some of the thornier parts to separate follow-ups (will make issues). That'll unblock parallelizing those efforts.
Updating it to have just:

mod init/install moved to top-level
sync -> develop and support for dagger develop --sdk=... --name=...
dagger mod (for printing config) -> dagger config

no extra subcommands on dagger config yet, will bikeshed that in separate standalone PR

Follow-ups:

install/update/uninstall

add support for dagger update to update existing deps
change install to fail if dep at different version already exists
add uninstall
--dry-run (if worth effort in short term, otherwise can backlog)

dagger config

decide on approach in terms of git config style, set/get, etc.
add support for setting+updating include/exclude

cc @shykes @helderco

Attempts to update the name/sdk of a module that already has those set result in an error.

While developing modules I find myself renaming them occasionally. It would be great to have at least basic support for it. I am happy even if it comes with a warning. It would be great if dagger can identify local dependent modules and update their references also but I understand that may be to complicated/error prone.

Don't forget ./hack/make docs:generate 🙂

dagger init -m feels confusing. I think we should cut it, and later when/if -m becomes a global flag like we discussed, then it will apply equally to all subcommands.
dagger init [PATH] would be a nice addition, especially combined with a default value for --name. dagger init foo is nicer to type than mkdir foo && cd foo && dagger init --name foo

Yeah I can see how -m is confusing for init. Agree that [PATH] would be much clearer, will update 👍

dagger init should not have --sdk at all. The idea is that init becomes much more lightweight: just add a dagger.json. Later if you want to add code to your module, you develop functions with dagger develop

@shykes I feel like this just results in extra boilerplate in that if you want to init a module and develop on code right away you have to do two commands: dagger init and then dagger develop --sdk=go --name=foo. Obviously if that's not what you want to do you are free to dagger init (no flags) and then maybe do dagger develop later if you want.
But what's the harm in supporting dagger init --sdk=go --name=foo as a shortcut for when you want to start out with an sdk+name right away? I don't really see any right now.

dagger init should not have --sdk at all. The idea is that init becomes much more lightweight: just add a dagger.json. Later if you want to add code to your module, you develop functions with dagger develop

@shykes I feel like this just results in extra boilerplate in that if you want to init a module and develop on code right away you have to do two commands: dagger init and then dagger develop --sdk=go --name=foo. Obviously if that's not what you want to do you are free to dagger init (no flags) and then maybe do dagger develop later if you want.
But what's the harm in supporting dagger init --sdk=go --name=foo as a shortcut for when you want to start out with an sdk+name right away? I don't really see any right now.

I see what you mean.
The harm (big word but I'll run with it :) would come from making it slightly harder to understand the purpose of each command, because init does more things and has more flags, and there are two ways to achieve the same thing.
Not worth holding back merge though.

The harm (big word but I'll run with it :) would come from making it slightly harder to understand the purpose of each command, because init does more things and has more flags, and there are two ways to achieve the same thing.
Not worth holding back merge though.

@shykes Yeah that's true too. My gut feeling is that the cost of having --sdk on both init and develop is less than the cost of forcing users to always run two commands in the case where the know what sdk they want. I think it's pretty straightforward to explain what --sdk does in both cases. But very much splitting hairs.
I'll just leave it as is for now until I hear other opinions (cc @helderco or anyone who wants to be a tie-breaker here 😄).


Chaotic Feat: Automation of project structure updation using GitHub workflows and Python scripts

Describe your chaotic idea
Currently, the project doesn't have a project structure. And, it would be a bit difficult for newcomers to understand the project and how to add more chaos to it's existing structure completely. Also, it's difficult for anyone to manually change the project structure as it grows in size day by day. So, automating this with GitHub workflows and Python script will make the maintenance easier and enhance organised chaos(metaphor!).
I want to add a detailed project structure in a separate file(redirect in README.md) for the contributors to refer to and automate its updation process as new files are added in the projects. This will help them refer to the structure and will make it easier for them to understand the structure and spread more chaos to the project. Also, it's difficult for anyone to manually change the project structure as it grows in size day by day. So, automating this with GitHub workflows and a Python script will make the project more accessible to the Contributors and spread more chaos.
Add Screenshots or Sketches
Sample of how the workflow would be automated and the project structure after updation in readme:

Confirm

[X] I understand that my idea will add to the chaos and I'm okay with it
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this feature
[X] I'm GSSOC'24 Extd registered Contributor
[X] I'm Hacktoberfest registered Contributor

The project structure is already there in CONTRIBUTING.md file

@vansh-codes the project structure is just showing the folders and not the content files in it. For example:

The files inside the assets tab is not shown here.

Ohh yes, so it will be automated you are saying?

Since the Structure would become much longer, I was thinking of not keeping the dependencies(.gitignore,etc). Rather keep the main file structure in a much detailed manner.

Ohh yes, so it will be automated you are saying?

Yes I will write code to automate the process. I was trying out in one of my repositories. That is the sample that I have shared with you. Since I have not tried this out with any other repositories so I cannot share and other repositories samples with you

yeah right, I am asking how will it be automated?
For ex:
If I create a new file, will it be automatically updated in the structure as well?

yeah right, I am asking how will it be automated? For ex: If I create a new file, will it be automatically updated in the structure as well?

Yes, it will add automatically using GitHub workflows and Python scripts that will help the GitHub bot to update the structure automatically. I would prefer to make a separate file and update the structure there to avoid any clash with the main contributing file.

go ahead!

How much time will it take to create a PR?

Are you familiar with Github workflows? What I will be doing is similar to that but I will add another layer to it by writing python code to automate the process

How much time will it take to create a PR?

It is late night for me write now and I have college tomorrow. It would be great if you provide me time till tomorrow. Since I have to test the feature too. I will share the updates of the work with you tomorrow after I have successfully implemented the feature. Since this is the first time I am trying it on someone's repository I want to work on it very carefully and try to make the best out of it.

Sure have your time no worries!

I might need some time, but I ensure you that I will give my best into the work and hopefuly you will like it.

Take your time brother no worries!

@vansh-codes It is working finally after a lot of checks. There was a small issue but it caused a lot of problems in the feature. It is finally resolved.

I want your opinion on something. Since the Project structure is quite lengthy, I have made a separate file named PROJECT_STRUCTURE.md and have added a redirect to it. Where do you want me to add the following redirect within the README.md file:

Also, this is how the file is looking:

Please let me know your thoughts on the changes. I hope you like it.

Yeah its perfect, great work @rajdeepchakraborty-rc

You can create PR for this so I can review your code as well

@vansh-codes I want your opinion on something. Since the Project structure is quite lengthy, I have made a separate file named PROJECT_STRUCTURE.md and have added a redirect to it. Where do you want me to add the following redirect within the README.md file or any other file:
Please let me know where you want this redirect to be in.

@vansh-codes please share your opinion on this

Yeah its perfect, great work @rajdeepchakraborty-rc

Thanks for the words of appreciation. I am glad you liked it.

Yeah its perfect the way you did!

Good job! Keep it up!
Create a PR i will review, you can do this task for my second project also

Yeah its perfect the way you did!

I asked about where you want me to keep the redirect message, in readme file or contributing.md file?

Good job! Keep it up! Create a PR i will review, you can do this task for my second project also

Sure. Could you please share the other project that you are talking about?

yup first lets get this one completed, create PR so I can review it better, I will share second proj link to you in the PR

@vansh-codes I have opened the PR


refactor: rewrite ReportGenerateRow in React

@mkobayashime I'd to hear your impression of the reimplementation using React (e.g. whether the not over complex manipulations like ReportGenerateRow should be implemented with plain DOM API or  React).

@yudukikun5120
I think a disadvantage of using React over the pure DOM APIs is it makes the final bundle size bigger and loading time longer (in this case contentScript/reportTemplate.js will include whole the React runtime) in general, but we can virtually ignore it when it comes to Chrome extensions where all assets are downloaded/saved in the local disk beforehand, so we can use React without hesitation (this also is a reason why I chose React instead of Preact). Please note that this doesn't mean all existing DOM modification codes have to be rewritten with React: we can still use pure DOM APIs for simple manipulation and rewrite them when it become too complex to be done with pure DOM APis.


More use of move semantics in deserialization

Short version
For certain cases, where copying things is an issue (as the one described below), I would like to favor examples similar to move_only_type over the creation of a from_json function, but specializations of adl_serializer does not seem to work with containers of types for which the specialization exist.
Ideally, I would like to have a "return by value" version of from_json. The STL container of those types would be built by emplacing the values returned by from_json into the container.
Long version / context
We currently use your library (vendoring the json header for now) in xeus, a native C++ implementation of the Jupyter protocol.
In this work, some of the classes that we deserialize from json have a value semantics and implement the RAII pattern. Basically, constructor and destructors amount to acquiring and freeing the resources. Any non-move copy acquires a new version of the resource (with a different id). Move constructor and assignment transfers the resource to the moved-to object.
This is a context in which being able to move things to a container would make a lot of sense...

Hello, do you have a small example that fails to compile?
If I understand you correctly, the bug is in the library-provided conversions?

I just want to avoid copies when filling the e.g. an std::vector<my_type>, using e.g. emplace_back.

The following code works fine, there is no copy involved:
#include <iostream>
#include <json.hpp>

struct test {
  test() = default;
  test(test const &) = delete;
  test(test &&) { std::cout << "move" << std::endl; };

  test &operator=(test const &) = delete;
  test &operator=(test &&) = default;
  ~test() = default;
};

namespace nlohmann {
template <> struct adl_serializer<::test> {
  static ::test from_json(json const &) { return {}; }
};
}

int main(int argc, char const *argv[]) {
  auto j = nlohmann::json{1, 2, 3};
  auto v = j.get<std::vector<test>>();
  v.emplace_back(nlohmann::json(1));
}

I think I misunderstand your issue, feel free to post some code :)

Hum, it seems that you have well understood that issue, and your snippet works well. Issue must be on my side (I am tracking assignments and seeing a few). Closing, thanks for your reply.


haskell.packages.ghc98.ghc-lib{,-parser}: <IP_ADDRESS>40223 -> <IP_ADDRESS>41022

The new version of ghc-lib was released recently. With this we should be able to switch to ghc983 in nixpkgs

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Yes, great. We are currently waiting on staging-next getting merged into master so that we can do our next round of bumps.

As staging-next has not been merged into master yet, could we merge this PR into staging-next and then switch to GHC 9.8.3 in staging-next?

Good question. I don’t know. I have to say I am not super in a rush with this. I am very certain that we will get this in for the next release.
@sternenseemann wdyt?

This PR edits the autogenerated hackage-packages.nix file manually. But I think it’s obsoleted by the auto-update anyway.

Now that I've done the proper bump independently, I've also discovered that this change wouldn't even be enough to successfully compile HLS with GHC 9.8.3.

Thanks for looking into this 👍 Yes i haven't checked that HLS actually compiles after ghc-lib-parser was compiling.


added gamers witness stuffing

Witness stuffing with same RSSI/SNR values
Proof/screenshots in #2338
Closes #2338

Seems OK to be added, based on the obvious proof.  But it still needs to be sorted correctly in denylist.csv .
I'll discuss and sign if OK and when sorted.

The command I am using to sort:
cat denylist.csv | LC_COLLATE=C sort | uniq | sponge denylist.csv


whitespace-only fix indenting in lib/transport

Seemed to be using tabs rather than the 2 spaces that the rest of the
codebase uses.

thanks!


AmoTime is missing PRE_OPEN

AmoTime currently support only OPEN, OPEN_30, OPEN_60. PRE_OPEN is supported in web and is supported in v2. Please see amoTime in the link https://api.dhan.co/v2/#/operations/placeorder. However when using this package, it is still not supported. Please include support for PRE_OPEN.

v2 hasnt been updated here.

Hello @williamzerner @bailakare
Yes, this is pending. We will soon upgrade to v2 for entire Python library and you should be able to use all new features then.

Hello @williamzerner @bailakare
We have updated the library for DhanHQ v2. This is now available as part of the library. Do try it out and let us know your feedback.
DhanHQ-py v2


Guest Entries Plugin Validation Errors Missing

Question
The Guest Entry Plugin https://github.com/craftcms/guest-entries#usage  returns with an entry variable if there validation errors but that is not returned when using Sprig. I changed it to something unique "guestentry" and then I did this
{% if sprig.isInclude %}
{% else %}
    {{ dump(guestentry) }}
{% endif %}

but I get "variable guestentry is not defined" error. If I dont try to dump that variable after submitting I am getting a response 200 like the form submitted fine but of course not with success.

For now I decided to use ajax to submit ( I know we are suppose to avoid that :) ) as it gives me a success message too. The guest entries plugin does not return a success variable.

As of Sprig 1.3.0, a variable called entry should be returned on error and a boolean variable called success should be returned regardless of whether there were errors or not. Is this not the case?

I am getting a success boolean back but not the entry variable which I have renamed to guestentry. I have tested with both and dumping it but I get that error above about not being defined.

It looks like a variable called variables is returned, containing the entry...
https://github.com/craftcms/guest-entries/blob/c69b1f90f6f675f43336dcb5f0970b30173779d7/src/controllers/SaveController.php#L205-L208
Can you try this?
{{ dump(variables.guestentry) }}

I just fixed this in https://github.com/putyourlightson/craft-sprig/commit/921e9bae27b0f6de9048584b2c12900568147545 for the next release, so that the variable guestentry will be available in the template.

Yes {{ dump(variables.guestentry) }} works - Cool thanks for looking into it and fixing so quick!

Released in version 1.3.3.


chore: update the docs

fixes #35

Codecov Report

Merging #36 (f85c9cd) into main (4b4fdd9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   71.60%   71.60%
=======================================
  Files           9        9
  Lines         493      493
=======================================
  Hits          353      353
  Misses         97       97
  Partials       43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4fdd9...f85c9cd. Read the comment docs.


Doesn't allow receiving CTRL-C (SIGINT) signal

Hi,
Under OSX, different terminals (terminal, iterm2), and shells (bash, zsh) don't seem to process the signals when the bars are displayed (it doesn't respond). You need to send it directly with the kill program to the process. And, when you do so, the shell is broken and you need to manually reset it.
This is the code I'm using:
	sigc := make(chan os.Signal, 1)
	signal.Notify(sigc,
		os.Interrupt,
		syscall.SIGHUP,
		syscall.SIGINT,
		syscall.SIGTERM,
		syscall.SIGQUIT)
	go func() {
		s := <-sigc
		log.Fatal("Exit with incomplete download")
		os.Exit(1)
	}()

Awesome library, thank you! :+1:

Sorry for the very late response. I had notifications turned off and did not see this.
I tested out signal handling and it appears to be working (maybe I pushed up a change after this issue was made?). You can check out the tests added with this commit.
If you run this test with a go run main.go, it will show signal handling working. Similarly, you can run the demo and send a ctl+c to it.
Cheers!


Staging Environment

Create an OpenNEM staging environment with dev/rc releases on production data

[ ] basebackup of prod database onto staging server
[x] setup docker stack on staging server
[ ] monitoring-staging slack channel
[ ] separate environment in settings, configs, sentry etc.
[ ] setup domain names
[ ] setup s3 bucket for staging.data.opennem.org.au
[ ] write out all outputs into buckets
[ ] adapt FE for separate environment

cc @chienleng

Going to split this ticket. BE is done and I'd like the FE to work like feature branches (auto build and deploy).

FE ticket: https://github.com/opennem/opennem-fe/issues/212


Not being able to login on Sankaku Complex

What steps will reproduce the problem?
Go to the source list and try to put in your credentials. When you click on test it will always say that it fails althought it has the right credentials. Here is a screenshot:
https://i.imgur.com/mzvI78L.png
What is the expected behavior? What do you get instead?
Being able to login when I click on test. What I get instead is a failure message when I try to login.
How often does this problem occur? On which sources?
Everytime on chan.sankakucomplex.com
What version of the program are you using? On what operating system?
Version 6.0.1 on windows 10
Please provide any additional information below

You can actually login, it's just that the testing itself fails.
It works by trying to load a far away page (by default 100 for Sankaku), considering that anonymous users can't load said page, but logged in users can. But it seems Sankaku updated their page limits and it's now 25 for anonymous users and 50 for logged in users.
You can change the setting here:

The default value will be set to 50 in the next version 👍


Feature Request: per-namespace apply

I noticed that landscaper supports the --namespace option for setting the namespace a helm chart is deployed to. To be clear - this is not what I'm after....
I would like landscaper to be able to do diffs based on a namespace.
eg.
namespace-foo>
                             deployment1.yaml
                             deployment2.yaml
namespace-bar>
                             deployment3.yaml
                             deployment4.yaml

currently, if landscaper knows about deployments1-4, there's no way to only consider/diff/apply changes to a particular namespace only.
eg.
I change all of the deployments, but I only want to consider "namespace-bar" changes for landscaping right now.
I could then do
landscaper apply --only-namespace namespace-bar *.yaml
and only changes to deployment3-4 would be applied
My use case is I have multiple teams, each working in different namespaces. With landscaper currently, a mistake by one team can block deployments in another team. Applying by namespace would solve this.
thanks
James M

Hi James,
How are you organising your landscape component files? We had a similar challenge with multiple namespaces in our repository, so now we use a directory per namespace. Then our release manager landscapes each namespace independently when changes are made to that directory.
Cheers,
John.

I do have a directory per namespace. However, landscaper tries to remove all deployments not in that directory/namespace if I only apply on a subset.

You can use the --disable=delete flag. This will prevent deleting what is not in your subset.

Perhaps, but that's a manual workaround at best - not suitable for a CI process.


update of the doc

Codecov Report

Merging #77 into develop will increase coverage by 11%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           develop   #77    +/-   ##
======================================
+ Coverage       43%   54%   +11%
======================================
  Files           15    20     +5
  Lines         1114   869   -245
  Branches        85     0    -85
======================================
- Hits           480   469    -11
+ Misses         633   400   -233
+ Partials         1     0     -1

Impacted Files
Coverage Δ

Cargo/Handlers/Adobe/CARAdobeTagHandler.m
4% <0%> (+1%)
:arrow_up:

...argo/Handlers/ATInternet/CARATInternetTagHandler.m
84% <0%> (-4%)
:arrow_down:

Cargo/Handlers/Facebook/CARFacebookTagHandler.m
88% <0%> (-1%)
:arrow_down:

Cargo/Core/Utils/CargoItem.m
21% <0%> (-1%)
:arrow_down:

Cargo/Core/Cargo.m
44% <0%> (ø)
:arrow_down:

CargoTest/CargoTest.m
100% <0%> (ø)
:arrow_up:

Cargo/Core/Tags.m
0% <0%> (ø)
:arrow_up:

App/main.m

App/ViewController.m

App/AppDelegate.m

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204a285...5a47c1d. Read the comment docs.


Add Code of Conduct to website

This should be, at least for now, at the top level menu. The link to the google doc can be found in the diversity channel in slack.

I will have this done tomorrow!

Could you do that so that the direct link will be ismir2021.ismir.net/coc ?

Done! The permalink is, as requested, https://ismir2021.ismir.net/coc/


Parallelize e2e tests

Please check if the PR fulfills these requirements

[ ] The formatter, linter, and tests all run without an error
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Attempt to parallelize e2e tests

What is the current behavior? (You can also link to an open issue here)

All e2e tests run on single thread
What is the new behavior (if this is a feature change)?
Each e2e test module runs on separate thread
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information
This is work in progress, I will keep this PR as draft until I've done enough testing to see if this parallelization doesn't lead to any unpredictable problems.

I believe it would also (partially) resolve #134


Add SVG

Add the IShapeCollection.AddNewPicture(int xCoordinate,  int yCoordinate, Stream svgContent) method to able to add SVG picture:
using var pres = SCPresentation.Open("some.pptx");
var svgContent = new MemoryStream(File.ReadAllBytes("some.svg"));
var shapeCollection = pres.Slides[0].Shapes;

shapeCollection.AddNewPicture(100, 100, svgStream);

@ashahabov This is something I need, so it may make sense to do it as part of ShapeCrawler if I have to figure it out anyway. Would you have any getting-started pointers on this?

FYI, I am working on this now. https://github.com/jcoliz/ShapeCrawler/tree/issue/350-add-svg. So far, so good. Reasonable passing tests. But I haven't actually confirmed by loading into PowerPoint yet.

@ashahabov This is something I need, so it may make sense to do it as part of ShapeCrawler if I have to figure it out anyway. Would you have any getting-started pointers on this?

The SVG image format and 2D graphics in general are still new topics for me, so I am open to suggestions on this.
Currently, graphic manipulations are implemented using SkiaSharp. The idea was to use it for all graphics, if possible, without introducing an extra third-party library dependency.
One of the contributors planned to implement a feature to convert shape to SVG image. He suggested using the svg-net/SVG library (I noticed you are also trying to use this library in your PR). His feedback was that converting even a simple shape is challenging with SkiaSharp.
Unfortunately, the contributor disappeared after a few email messages🙂

FYI, I am working on this now. https://github.com/jcoliz/ShapeCrawler/tree/issue/350-add-svg. So far, so good. Reasonable passing tests. But I haven't actually confirmed by loading into PowerPoint yet.

Thank you for your contributions!

@ashahabov Ok, I will have a look at SkiaSharp to see if this can be used instead. I have a large library of SVG graphics to import, so it will be a good test.

@ashahabov Update: Does not seem possible to do this with SkiaSharp. Based on my research this morning, I believe that dependency on SVG library is the only tractable solution to add SVG loading into ShapeCrawler.

There was a https://www.nuget.org/packages/SkiaSharp.Svg library, however has not been released since 2018.
SkiaSharp.Svg was folded into SkiaSharp.Extended.Svg
SkiaSharp.Extended.Svg is now deprecated, see https://github.com/mono/SkiaSharp.Extended/issues/84.
https://github.com/wieslawsoltes/Svg.Skia just uses same SKG library I'm using here, so now we'd have an indirect dependency.


Docker images do not push SHA and travis build number tags

related to #283
It also fixes all-in-one image, latest is published per commit and added release tags.

Coverage remained the same at 100.0% when pulling dc7cfd54448a30025fa008100b65b6d6ca9957b4 on pavolloffay:docker-image-do-not-publis-travis-sha into 413942a087934711620cc1e15ea72886eebadffd on uber:master.

Coverage remained the same at 100.0% when pulling 10d4c1440f717019b7508a5225a62b54e19987e2 on pavolloffay:docker-image-do-not-publis-travis-sha into 413942a087934711620cc1e15ea72886eebadffd on uber:master.

Right, so as you notice it explicitly mentioned "remove other tags like travis build number and commit hash -- we might still want those for crossdock images"

I have added back sha images for xdock

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>dae0bb625f366cd8027385cdb00542 on pavolloffay:docker-image-do-not-publis-travis-sha into 413942a087934711620cc1e15ea72886eebadffd on uber:master.

Coverage remained the same at 100.0% when pulling fe07cc66534562fd3561d4a024939efb7ceab337 on pavolloffay:docker-image-do-not-publis-travis-sha into 413942a087934711620cc1e15ea72886eebadffd on uber:master.

Coverage remained the same at 100.0% when pulling 2adf2c786c83715ff60d5abb69106f0b9a7d4fef on pavolloffay:docker-image-do-not-publis-travis-sha into 5d5a16b7039500274b5f63f3dbf895273278f671 on uber:master.

Coverage remained the same at 100.0% when pulling 46171fc3486ce7bcd2cac1eb85e1457ad9592d07 on pavolloffay:docker-image-do-not-publis-travis-sha into d17b46832a3f4043a22f00aa0d11e2f2f39f93bb on uber:master.


Add 7/CMX

I would like to keep this as a separate RFC for the following reasons:

It is a different solution, a different communication pattern, and is not directly compatible with 5/CMX.
Editor change (see 2/COSS. Branching and merging)

Merged to avoid stalling. (As well as to avoid merge conflicts with future changes to the index table.)


Implement search functionality on environments

On the 'Environments' page, where the user can see all the environments, there should be a search bar whereby the user can specify a bunch of packages, and all environments which contains (or closely matches) these packages should be shown.

There is now a search bar on the environments page.


SetupTask's "ext" property causes naming conflicts

The SetupTask currently has a property named ext of type NodeExtension.  The name ext is probably a bad idea since Gradle developers will expect ext to be an ExtraPropertiesExtension based on http://www.gradle.org/docs/current/dsl/org.gradle.api.plugins.ExtraPropertiesExtension.html.
Even worse, the standard way of adding a property (or method) to a task is with a statement like task.ext.myProperty = 'myValue', but if a developer of plugin tries to do this, they will get a NullPointerException because ext starts out null.

Thanks for noticing this. Will fix this by using another variable name.

Issue fixed.


Availability and workload redundancy

A couple of typos but most importantly, it assumes that these "nodes' have elastic sizing and are not sized to meet throughput needs (viz., meet number of customers, number of sessions, Network bandwidth, etc.)
From https://learn.microsoft.com/en-us/azure/operator-nexus/concepts-nexus-availability#considering-workload-redundancy-requirements:
Consider a workload that requires 400 nodes across the entire deployment in order to meet the network demand at peak load. If this workload is part of your critical infrastructure, you might not wish to relay on "scaling up" to handle failures at times of peak load.
The node count continues to increase for deployment across fixed size Nexus viz., the VM size continues to shrink.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bd34d790-8187-70d3-613b-624257a03b3f
Version Independent ID: 6f6f625a-f131-dc4b-278f-353f3921dc7b
Content: Azure Operator Nexus: Availability
Content Source: articles/operator-nexus/concepts-nexus-availability.md
Service: azure-operator-nexus
GitHub Login: @joemarshallmsft
Microsoft Alias: joemarshall

@pgoyal01
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Return undefined if information was not found after retry.

Signed-off-by: Masaki Muranaka<EMAIL_ADDRESS>This will fix #10.

Ooops, there have unsuitable patches. I'll re-push soon.

Thank you for your contribution - it it very much appreciated!
Would you be able to add a unit test for this? I'm trying to keep the coverage at 100% since it is a small library. There is already a test for the retry on a 404. Maybe this could be adapted, or a new, similar test added?


Does WinUI support multiple languages now ? It seems x:Uid doesn't work

The same code works in UWP

Could you please provide more information about what is not working for you? Is this specific to the Winui3 preview, or a particular version of winui 2?

Hi StephenLPeters,
I try to make app localizable with Winui3 preview but doesn't work.
the code in below picture works in UWP but not in Winui3 preview.

Thanks, that helps route the issue to the right spot :)

@StephenLPeters : Not sure I understand on why this is closed. Is it fixed? I am using Preview 2 and its not working for me.

@StephenLPeters : Not sure I understand on why this is closed. Is it fixed? I am using Preview 2 and its not working for me.

This issue is not closed.

Thank you!

as a workaround, use full path for x:Uid.
for example, given <ProjectDir>/Strings/<Language>/<ResourceFileName>.resw:

key
value

TextBlock1.Text
Test123

do this in your Whatever.xaml:
<TextBlock x:Uid="[ProjectName]/[ResourceFileName]/TextBlock1"/>

@alwu-msft is this a known issue?

This should be functional, without need for workarounds, as of Preview 3.

Where is the tutorial located?about WinUI support multiple languages.

@Palatis  Your solution does not work. Can you create a sample?

Where is the tutorial located?about WinUI support multiple languages.

Look here
https://github.com/microsoft/WindowsAppSDK-Samples
But no xUid was used and the translation was done in c# code

@Palatis  Your solution does not work. Can you create a sample?

i dunno, maybe something changed internal.

Oh oh
I think the problem was solved  And this issue can be closed 😁
I used the following and everything works fine
<TextBlock  x:Uid="TextBlock1"/>

key
value

TextBlock1.Text
Test123

The point is that I did not pay attention to the last part TextBlock1.Text

i tested in version 1.0.0-experimental1
@StephenLPeters  i think you can close this issue and related issues

How can I control the language used to get values for x:Uid for unpackaged Desktop apps?

Oh oh I think the problem was solved And this issue can be closed 😁 I used the following and everything works fine
<TextBlock x:Uid="TextBlock1"/>
key	value
TextBlock1.Text	Test123
The point is that I did not pay attention to the last part TextBlock1.Text

i tested in version 1.0.0-experimental1 @StephenLPeters i think you can close this issue and related issues

I can't get this to work on my computer with latest stable 1.0.0. Can we get a full example somewhere?

This probably needs to be reopened.
Expected: The <TextBlock> says TestWinUI.

@sakurai-5317 The name of the string resource in the .resw needs to include the name of the property you are specifying a value for, e.g.
<data name="AppDescription.Text" xml:space="preserve">
  <value>TestWinUI</value>
</data>

I'm working on this NuGet package for dynamic localization and it works for me. 😎


NullReferenceException while navigating to a UserControl has poor exception message

Describe the bug
When calling the method Navigate (or any of its overloads) on a Microsoft.UI.Xaml.Controls.Frame with a parameter that is not a type that inherits from Page, a NullReferenceException is thrown. The exception message is very generic and could be improved.

Steps to reproduce the bug

Steps to reproduce the behavior:

Add a Frame (MyFrame) anywhere in an application
Make the following method call: MyFrame.Navigate(typeof(UserControl))

Expected behavior

An ArgumentException with a descriptive text would be better if the non-generic solution is needed. Changing the signature of the method to the suggestion below would be better still in some scenarios:
bool Navigate(object parameter = null) where T : Page
Screenshots

Version Info

NuGet package version:
[Microsoft.WinUI 3.0.0-preview4.210210.4]
Also happened in UWP according to this SO post: https://stackoverflow.com/questions/38620255/uwp-frame-null-reference

Windows app type:

UWP
Win32

No
Yes

Windows 10 version
Saw the problem?

May 2020 Update (19041)
Yes

Device form factor
Saw the problem?

Desktop
Yes

Additional context

Frame is designed to navigate to Page instances, not UserControls.

@Jaiganeshkumaran I am aware. This is a suggestion to improve the exception, not change the behaviour.

re: bool Navigate(T parameter = null) where T : Page, WinRT doesn't support restrictions on generics so this could only be implemented as a special case in cswinrt, and not at the winui API layer. I don't see the stack trace/exception msg in your post but it sounds like it could be made better.

Would be nice if we were going back to change design of the signature here, but absent of this we can't fix it. Closing out the issue. Appreciate the suggestion though.

Fair enough regarding the signature, but an ArgumentException("Type must be a subclass of Page") would still be an improvement over a NullReferenceException without any message.

Fair enough regarding the signature, but an ArgumentException("Type must be a subclass of Page") would still be an improvement over a NullReferenceException without any message.

Fair suggestion. The internal mechanism here must be passing the failed cast on as a null value resulting in the less-than-helpful suggestion. Fix would be to offer up a better exception type. Reactivated.

I just spent a lot longer than I wanted to trying to diagnose this issue as well, a more explicit exception message would be much appreciated. Thank you TroelsL for including the solution.

FWIW I've just hit this issue navigating to a Window rather than a Page by mistake.  A better error message would definitely have helped.

Please don't close without resolving.

I just hit this problem as well.  Somewhere in the documentation it said I could navigate to a UserControl, I forget where, and no matter what I tried I kept getting a NullReferenceException and couldn't track it down until I found this page.  There should be a more descriptive error message.


[Refactor] Use constant to indicate size of IndexValue and add a getter for kv_pair_size, and reduce a parameter.

What type of PR is this：

[ ] bug
[ ] feature
[ ] enhancement
[x] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

not sizeof(IndexValue) and add it with key_size every single time, and reduce a parameter

The original intention is we may support other Value lengths to save space usage, for example, if  rssid is small or rowid is small, we don't need to use uint64

run starrocks_admit_test

run starrocks_admit_test


Rebalance suggestion

This is for the AP system, basically add a material cost to all upgrades after retooling the AP gain from enemies so people don't cheese it with stuff like the ruin mission.
If it remains purely AP based, people will find a way.

Sidenote - an exploit for AP fast seems to be dealing 90% damage to any space encounter monster with mech, then finishing it off with a standard weapon


mutable params and the developers who love them

At some point I developed the conceit that this test should work.  The question is whether @Clyybber and company are going to put the kibosh on this due to some hidden addr bs.
    block:
      ## reassignment of var proc params
      ## https://github.com/disruptek/cps/issues/22 (2nd)
      proc foo(a, b, c: var int) {.cps: Cont.} =
        a = 5
        noop()
        b = b + a
        noop()
        check:
          a == 5
          b == 7
          c == 3
      var (x, y, z) = (1, 2, 3)
      trampoline foo(x, y, z)
      check:
        x == 5
        y == 7
        z == 3

I've tested the resulting transform with manual changes to use views + storing var int in env. The result is SIGSEGV. We can't support this until the compiler gain proper views support.


added snake online website game

Can you please create Snake Game directory then create index.html inside it like :
Snake Game / index.html


test_generator fails due to subtle difference

test_generator is validating that qualname is correct for nested generators. But Python goes through a slightly odd path to make this happen via _PyEval_EvalCodeWithName.  We don't current emulate that, and lose the qualified name.
http://bugs.python.org/issue26093

Implemented in #237


Unable to edit scenes after adding new scene

Release Type: Official Release/GitHub (please choose appropriate option)
Official Release
Version: Version number and/or git branch
<IP_ADDRESS>-beta4-1254
Platform(s): Does the problem occur on Windows, Android...?
Windows
Describe the bug
A clear and concise description of what the bug is.
After I added a new scene to the assets, I can no longer edit the contents of a scene. The Asset preview remains blank no matter what I select.
To Reproduce
Steps to reproduce the behavior:

Add new scene to project with Main Scene.

Expected behavior
A clear and concise description of what you expected to happen.
Should be able to edit any scene
Screenshots
If applicable, add screenshots to help explain your problem (use GitHub drag & drop)

Log and callstacks
If any, please attach here any log or callstack (preferably in a .txt file using GitHub drag and drop)
NA Project here. https://github.com/LanceJZ/Stride-Asteroids
Additional context
Add any other context about the problem here. None of my projects will show asset properties now. Re-install, restart, nothing fixed it.

This is not an issue, it is user error. The Property Grid view was closed.


Updated Gallery ApplicationVersion specs.

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Changes in this PR has no user impact, it will not cause user breaking because no one is using it

thanks for confirming no customer impact. Is the change on Prod already? Will there be any future change in this preview version before SDK releasing? It's better combine all change in one PR to make it ready

@yb

Changes in this PR has no user impact, it will not cause user breaking because no one is using it

thanks for confirming no customer impact. Is the change on Prod already? Will there be any future change in this preview version before SDK releasing? It's better combine all change in one PR to make it ready

@yungezz the changes are in prod. There are no more changes that are required to the specs for my feature.


Support variadic tuple inference from trailing optional to non-optional

Fixes #39607.

Is it worth having an ElementFlags.Individual to describe something that's just not a rest element?

Is it worth having an ElementFlags.Individual to describe something that's just not a rest element?

I was close to adding an ElementFlags.Fixed for the ElementFlags.Required | ElementFlags.Optional combination, but not sure it adds a lot of clarity.


Remove spurious files

Update readme to correct project name
Signed-off-by: Ry Jones<EMAIL_ADDRESS>

@delventhalz PR updated per feedback

@ryjones Awesome. You should be good to merge.


Create an issue template

@alex-zige @quintuschen Hi team, please help review the issue template. Cheers.

LGTM :)

I made a few minor tweaks, good job @openstacker !


New Window Style

Is there a way to turn off the new window style?
Really not a fan of the nonstandard style; it's now a different colour and style to every other window on my desktop.

Yes. Desktop Settings -> Use system window borders (checked).


Feature request: Turn off/on all checkers

Hi, is it possible to add "slider" to turn off/on all checkers at once?
Thanks
Seth

I have tons of alarms and turning everything off and on one by one is tedious. This would be a great new features

This feature will be included in the next release. Below is a screenshot of how it will look.
If you have any comments, let me know.

Looks great, good job man!

Great, is it possible to add 2 functions? Disable/enable all checkers and disable/enable active checkers.  Thanks.

@sethxp Every checker has only one state - enabled (on) or disabled (off). What do you mean by enabling active checkers?

I mean i have for example 15 checkers, 10 enabled 5 disabled. At night i want to click Disable active checkers. And in morging click on activate/enable last state before disabling - 10 on 5 off.Dne 18. 6. 2021 15:58 napsal uživatel Aneonex Software @.***>:
@sethxp Every checker has only one state - enabled (on) or disabled (off). What do you mean by enabling active checkers?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

@sethxp Do you turn off checkers at night because of the sound of the alerts?
If you turn off the checkers completely, then you will not see the latest price alerts in the morning in the notification bar.
Perhaps you need something like a quiet mode?
@Kerbox2000 Please describe your case, for what purpose you turning off all checkers or alerts?

Yes, i need some kind of quiet mode at night because price notifications are also sended repeatly to my smart watch untill dismiss. So one slider to turn off/on notifications?Dne 19. 6. 2021 19:27 napsal uživatel Aneonex Software @.***>:
@sethxp Do you turn off checkers at night because of the sound of the alerts?
If you turn off the checkers completely, then you will not see the latest price alerts in the morning in the notification bar.
Perhaps you need something like a quiet mode?
@Kerbox2000 Please describe your case, for what purpose you turning off all checkers or alerts?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

I turn off my alerts so I can sleep at night, I am not a day trader but still curious about price movements.

Any news on this? I would be just fine with on and off function for all alerts for now.

I can't find simple and clear solution yet. I see one of the following options:

"Silent mode" - turns off all sounds, including speech and vibration. Price updates and alerts still work silently in the notification bar.
Disadvantages: This does not solve the issue with smartwatch notifications.
"Quiet mode" - same as "Silent mode" but alerts also does not work, only the price is updated silently.
Disadvantages: It makes unreliable the alerts and price checkpoints updates. Also not sure if this will solve the smartwatch issue.
"Stop mode" - stop all price updates. Likewise, when all checkers are disabled. Simply to use.
Disadvantages: No price updates, no alerts, no any notifications in the top bar.

Option 3 seems to me the simplest and most clear. This is most close to the original issue.
One more note.
Android has standard "Do Not Disturb" mode (with night schedule and app filters), which does not require additional application settings to disable notifications. Have you tried using this?

Ok, number 3 Stop mode. I like that. It's kind of suprise every morning if prices are up or down from latest "stop".Dne 16. 8. 2021 16:01 napsal uživatel Aneonex Software @.***>:
I can't find simple and clear solution yet. I see one of the following options:
"Silent mode" - turns off all sounds, including speech and vibration. Price updates and alerts still work silently in the notification bar.
Disadvantages: This does not solve the issue with smartwatch notifications."Quiet mode" - same as "Silent mode" but alerts also does not work, only the price is updated silently.
Disadvantages: It makes unreliable the alerts and price checkpoints updates. Also not sure if this will solve the smartwatch issue."Stop mode" - stop all price updates. Likewise, when all checkers are disabled. Simply to use.
Disadvantages: No price updates, no alerts, no any notifications in the top bar.
Option 3 seems to me the simplest and most clear. This is most close to the original issue.
One more note.
Android has standard "Do Not Disturb" mode (with night schedule and app filters), which does not require additional application settings to disable notifications. Have you tried using this?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

Design preview:

"Stop mode" is renamed in a more intuitive "Pause".

Again, this looks good, hope this will make it to the next release :-)

Ok, perfect, thanks.Dne 16. 8. 2021 20:41 napsal uživatel Kerbox2000 @.***>:
Again, this looks good, hope this will make it to the next release :-)
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

This feature implemented and included to the new release 2.45. Will be available during this week.


Pages global permissions admin view does not honour the CMS_RAW_ID_USERS setting

On DjangoCMS 3.1.3:
Adding/editing a Pages global permissions, all users are shown in the dropdown even when CMS_RAW_ID_USERS = True
Maybe GlobalPagePermissionAdmin method needs a raw_id_fields method much like PagePermissionInlineAdmin

I don't if this should be raised as part of this issue, but GlobalPagePermissionAdmin also has a list_filter that includes user.
list_filter = ['user', 'group', 'can_change', 'can_delete', 'can_publish', 'can_change_permissions']
The list of users in this filter could also get very long.

Thanks for reporting

No problem :)

Solved in #4951


Added support for deserialization of types derived from IEnumerable<>

Fixed issue when type derived from IEnumerable<>, ICollection<>, or IList<>, etc.. is used deserialization fails.
For details please see issue #92

Hi @michal-novak-pos-digital, thanks for your PR. I will accept but will add your logic to get type in Reflection.cs class to be more easy to migrate to Portable version.


(typings) Models can have composite keys

idColumn can be an array of strings
Example from docs:
Person.idColumn = ['firstName', 'lastName', 'dateOfBirth'];

Coverage decreased (-0.003%) to 97.037% when pulling 8bd9a3314e883d05f60f6395571a9edfcbbf4c37 on kbkk:patch-5 into 1a8803137569ca6bb04e882aaf1b036b6fea0e2f on Vincit:master.

Coverage decreased (-0.003%) to 97.037% when pulling 8bd9a3314e883d05f60f6395571a9edfcbbf4c37 on kbkk:patch-5 into 1a8803137569ca6bb04e882aaf1b036b6fea0e2f on Vincit:master.

Thanks!


Using Mattermost Platform CLI on docker install

Please excuse my ignorance because I am quite new to docker but I would like to use the Mattermost command line tools (https://docs.mattermost.com/administration/command-line-tools.html) on an instance of mattermost I have installed with docker-compose.  When I try to run platform I am getting command not found.  The docs say this must be run from the directory where the Mattermost platform is installed but I am not sure where this would be if installed via Docker.  Any help would be appreciated.

The directory is /mattermost in your mattermost container. Try this:
docker exec -it <your-mattermost-container-name> /bin/bash
cd /mattermost
bin/platform -help

The container name may be mattermostdocker_app_1 if you installed mattermost with docker-compose.yml in this repository.
Good luck to you!

That works thank you so much!!!


pull request for e2e test at 12/18/2016 03:26:17

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Changed project to node.js

Hey, this resolves issue: #1
Changes made

deleted everything
added discord.js starter code

Noted Dude.


Possibility to ignore paths when using the recursive parameter

Clear and concise description of the problem
Adding a parameter to exclude a path when using it in a monorepo.
Suggested solution
Equivalent to the include and exclude parameterr I would suggest the following conversion:
taze --ignore __OLD__/,ignoreMe/
Alternative
No response
Additional context
In our monorepo we have a few projects that we want to explicitly exclude because they are not to be upgraded.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

After having a look at the source code, I have already found an option for this. This is already possible with --ignore-paths. Sorry for the issue


Hardcoded font-size in form-validation-state

I use $font-size-base: 0.8125rem;.
Because the form-validation-state mixin has a fixed font-size of .875rem, I got validation messages of an unexpectedly bigger font.
Could this be changed to percent values or variables?

Might #24768 be related to this issue? I'll drop that here just in case.


Responsive / auto-optimized image configuration

For projects that rely on auto-generated assets (e.g. thousands of dashboards, like in this discussion), it would be nice to have image assets auto-optimized with tools like Sharp -- and support for responsive images.
Not sure if this is out-of-scope for Framework! Thinking of plugins like this for Vite: https://github.com/ElMassimo/vite-plugin-image-presets

This is probably covered already by “file transforms“ idea #849, which is registering data loaders for request patterns, which is a variant of the parameterized data loader idea #245. But it is a common-enough need that it might be worth calling out and designing specifically for.


number of sentences

In the example, MSRpar2012 has only 750 lines of sentences.
The theory works fine with small volume of data.
But for big data, for example, the number of sentences is near 400,000.Then the calculation of pca could be a big problem.
Can SIF handle big data?

The algorithm itself will not be very sensitive to the scale of the data, but the current implementation just uses the PCA function in sklearn. One can better algorithms to compute the PCA (e.g., randomized algorithm for PCA in sklearn).

Thank you. I tried on big data and it seems working.

A follow-up question:
Have you done any experiments to see how sensitive the results are to the number of sentences? Is there a rule of thumb as to how many sentences would reveal c0  or is it really task/data-dependent?  @YingyuLiang

@YingyuLiang The computation complexity for sentence embedding is ok, but how can I compute the first singular vector for millions of sentences, can I sample some sentences and compute $u$??Or is there any other methods?


3.0.0 Stable Release

When do you plan on releasing stable version of 3.0.0?

In the next 2 weeks it should be out :) I need to make sure it's stable

okie thx

Is it stable now?

Not quite, but the beta 4 is a solid beta:
https://github.com/michalsnik/aos/releases

What is the differences between v2 and v3? Are there any limitations or risks of upgrading to aos-next beta 6?

It's been 2 years now and no 3.0.0 stable release… Is this project on halt? Are there any plans of actually releasing a stable version? How safe is it to use beta 6 on a production site?
I'm also (@dlewand691) not quite sure what the differences are between v2 and v3. Any hints, please?


Create file error(0x800FFFF)

Hi,
OS: Windows 10 Enterprice(version 1803, OS build 17134.1365) //cracked :p
Steps: 1) Mount disk
2) Right-click mouse ->  New -> Text Document
After these steps Windows throw error:

If press "Try Again" -> file will create, but error reappears.
If press "Cancel" -> file will create and all OK.
Need to fix these error..
In debug mode no errors from debugger, only this error from Windows.
If i copy file(ctrl+v) in directory, no any errors.
If i create file by cmd, file creates, but...

Log from Dokan, when error appear in attachments(1,2,3,4).
Code taken from here: https://github.com/HackcatDev/XakepFS/tree/master/XakepFS
Help me please <3
ATTACHMENTS

Regards haD.

Hi @haDDah ,
The code might not be updated or compatible with the dokan version you have installed.
https://github.com/HackcatDev/XakepFS/blob/master/XakepFS/packages.config#L3
Dokan 1.2.1 is compatible with it. Try to update the nuget package and install dokan version if that's not the case already.

Hi @Liryna ,
Thanks you for answer.
I updated version, as you said, but the problem did not resolve.
Sorry to take so long.

Have you tried to directly contact the project owner?
That's not a dokan issue but more how it is used / version.

Hi @Liryna ,
Thanks you for answer.
No, I didn’t contact him. The whole project was in bugs that I fixed gradually and only this remained.
I’ll try to find the error or rewrite the function from scratch.
Maybe you have an example how to use the file creation function correctly?

There is a mirror sample in this repository that might help you. Otherwise you have the documentation in dokany that might contains some hints that are good to know.


Update order's metadata & private metadata do not trigger ORDER_UPDATED async webhook event

What I'm trying to achieve
I expected the ORDER_UPDATED event to be triggered when I update an order's metadata or private metadata.
Steps to reproduce the problem

Create a webhook with async events ORDER_UPDATED.
Update an order's metadata or private metadata using the Saleor Dashboard.
The ORDER_UPDATED event is not fired.

** The ORDER_UPDATED event is fired when I add a tracking number or fulfill an order.
What I expected to happen
I expected the ORDER_UPDATED event to be triggered when I update an order's metadata or private metadata.
When I update a product's metadata or private metadata, the PRODUCT_UPDATED event is triggered.
Screenshots and logs

n/a
System information

Saleor 3.3.8
Saleor-dashboard 3.3.1

Saleor version:

[x] 3.3.8
[ ] dev (current main)
[ ] 3.0
[ ] 2.11
[ ] 2.10

Operating system:

[ ] Windows
[ ] Linux
[x] MacOS
[ ] Other

1 we noticed this too (on Saleor 3.2.x, 3.5.0)

There is now a draft PR that implements metadata events: #10520
We don't want them to trigger the regular "object updated" events as apps often update metadata in response to those which leads to a thundering herd effect.


Solved problem with components path

Description
Currently js or ts files inside src/main/webpack/components folder are not being compiled correctly because of this issue.
Another option is going up one level in path:
// Stylesheets
import "./main.scss";

// Javascript or Typescript
import "../**/*.js";
import "../**/*.ts";

Motivation and Context
It allows js and ts files to compile correctly when using package.json scripts like npm run watch
Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x] I have signed the Adobe Open Source CLA.
[x ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

this should be fixed with https://github.com/adobe/aem-project-archetype/commit/337d6cd7fee8079e167318727c88b20b8e7e341b


Implement cobra for command line

/approve

@gabemontero ptal

/hold
Should probably wait for https://github.com/openshift/csi-driver-projected-resource/pull/15 to merge and then I can rebase this one if needed.

/lgtm

/approve

/refresh


at each tick the bots receives the full list of bullets

Describe the bug
As far as I know the bullets of other bots should be invisible to the bot but right now at each tick, inside the
tick-event-for-bot there are the bullets of other bots too
To Reproduce
I'm seeing this because I'm develping a full botApi in a different language so I can't explain step by step, if you read any tick-event-for-bot while any bullet is on the field you will see that those bullets are included in the bulletStates
Expected behavior
the bulletStates inside the tick-event-for-bot must contain only the bullets owned by the bot that shoot them
Print out
example of 2 consecutive ticks I've captured
TICK T
(bulletId: 3, ownerId: 1, power: 1.0, x:<PHONE_NUMBER>593531, y:<PHONE_NUMBER>302621, direction:<PHONE_NUMBER>511403, color: "")
my id is 2
TICK T+1
(bulletId: 3, ownerId: 1, power: 1.0, x:<PHONE_NUMBER>187843, y:<PHONE_NUMBER>441377, direction:<PHONE_NUMBER>511403, color: "")
my id is 2
Robocode Server version
Robocode Tank Royale Server 0.17.4

@SirStone Thank you for both discovering and reporting this issue.
Of course, the bugs must not be able to see the bullets of the other bots, so this must be fixed ASAP.

@SirStone This should be fixed now with the release of version 0.18.0

@SirStone I consider this issue as solved. Otherwise, just re-open it. 🙂


feat: added mocks for browser to fix window, document, HTMLElement an…

…d navigator issues on server

PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[x] Other: Server related change
What Is the Current Behavior?
We sometimes use window and prevent issues by using 'isPlatformBrowser'. This works fine, but unfortunately we sometimes face issues with third party dependencies (AgmMarkerCluster for example), becaude they use window without checking if it's defined.
What Is the New Behavior?
With these browser mocks we prevent any issues regarding window, document, HTMLElement and navigator.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information

@nickyhaze Thank you for your contribution. 👍
In the best case scenario, we can always use Angular specific adaptions of libraries that are hopefully SSR-ready. I have seen it myself in projects that this is not always the case. However, for the base project, we should strongly stick to the clean approach, so customer projects have the best solution available for customization. Long story short: I would rather see this feature not activated by default. 😅
Would you be fine with the addition of a commented-out version?

Would you be fine with the addition of a commented-out version?

sth like this:
// uncomment this block to prevent ssr issues with third-party libraries regarding window, document, HTMLElement and navigator
// tslint:disable-next-line: no-commented-out-code
/*
const domino = require('domino');
const template = fs.readFileSync(join(DIST_FOLDER, 'browser', 'index.html')).toString();
const win = domino.createWindow(template);

// tslint:disable:no-string-literal
global['window'] = win;
global['document'] = win.document;
global['HTMLElement'] = win.HTMLElement;
global['navigator'] = win.navigator;
// tslint:enable:no-string-literal
*/

Perfect, sounds like a good solution to me!


fix new file scanning

Fixes relation between photo and linked files.
In order to link a file to a photo, the photo must first exist in the database.

Thanks for fixing it!


Is it possible to make QuickAccent's character set support multiple selection

Description of the new feature / enhancement
Supports multiple choice of character sets.
Scenario when this would be used?
The character set can now only be selected as "select all" or as a single selection. If you use the all-character set, there are too many characters, resulting in inefficiency. For example, if I select Pinyin, I cannot use the numeric subscripts, but if I select all, there will be a lot of characters that I don't need.

Supporting information
I use Deepl for machine translation, hopefully without too much ambiguity.

/dup #21261


Questions about second stage

@tianweiy
Hi tianwei,
I am confusing for the sencond stage in roi (https://github.com/tianweiy/CenterPoint/blob/8fcdc944bbb455bd25943b331aaf961aa0ab32cd/det3d/models/roi_heads/roi_head_template.py#L175). I found you predict offset by fc layer and directly add it to the first stage prediction result. But offset can be negative. For bbox size(w,h,l), if you add a very small negative number, the final refine bbox size will also be negative, is this reasonable. I found in the first stage, the size is sent to a torch.exp function to make it greater than 0.
Looking forward to your reply, thanks!

yeah, I see the problem. here we follow previous works and just predict the absolute offset. It seems to work generally well in practice as the offset is learned to be a near zero value.


Workaround for issue #3117

This workaround for issue #3117 works in Go 1.6 (amd64, windows).
//This doesn't work as per https://github.com/golang/go/issues/3117 .
//var m = map[string]struct{x, y int} {
//    "foo": {2, 3},
//}
//This syntax works by changing the comma to a semi-colon
//and specifying the type for both members
var m = map[string]*struct{x int; y int} {
"foo": {20, 30},
"bar": {51, 81},
}
https://play.golang.org/p/tCCJr5iKpP
That issue is closed so I'm posting here.

Please do not use the issue tracker for discussions.
Note also, that this has nothing to do with #3117, which already states a work-around.
Also, both variable declarations above work, there's no difference between struct{x, y int} and struct{x int; y int} as far as the types are concerned.


Handle invalid basebackup binlog position

The binlog position reported by XtraBackup does not always match the
actual start position of the transaction following the last GTID
included in the backup but it may be the one following that. This looks
to be locking issue on MySQL side that causes inconsistent state to be
returned.
To work around the issue add manual matching of the reported last GTID
to actual binlog position while restoring backup. It would be better to
fix this in the actual backup creation phase but that would require much
more complex logic and doing this in restoration allows coping with old
backups that are already broken.

Still pending additional verification but creating pull request for review/merge in case that passes.

Test passed (104 rounds). Details documented at
https://app.clubhouse.io/aiven/story/12492/mysql-insert-into-row-lost-while-doing-backup-and-upgrade-to-mysql-8-0-19


Avoid allocating a redundant function in the Provider

I'm gonna pass on this one. I can see the argument for dropping a meaningless use case, but also I don't think there's enough actual benefit here to justify the change.

Fine by me 👍


[EPIC] Schema metadata handling / bugs

Is your feature request related to a problem or challenge?
As described by @wiedld on https://github.com/apache/datafusion/pull/12729

A https://github.com/apache/datafusion/pull/11989 (and released in 42.0.0) has added a check that the logical and physical plan input schemas (to an aggregate node) are the same.

This check fails for us in several different queries now downstream in InfluxDB and this ticket tracks the list of issues we found
Issues

[x] https://github.com/apache/datafusion/issues/12687
[x] #12734
[x] #12735
[ ] https://github.com/apache/datafusion/issues/12736
[x] https://github.com/apache/datafusion/pull/12951
[x] https://github.com/apache/datafusion/issues/13010
[ ] https://github.com/apache/datafusion/issues/13190

@wiedld  has found several more issues:

[ ] https://github.com/apache/datafusion/pull/12951
[ ] https://github.com/apache/datafusion/pull/12954

Found another issue that triggers a schema issue here: https://github.com/apache/datafusion/issues/13190

Found another issue that triggers a schema issue here: #13190

Thanks -- added to the list
Note I now have added the config option to work around the issue in https://github.com/apache/datafusion/pull/13176 for anyone who hits these

Found, and fixed, another schema issue here: https://github.com/apache/datafusion/pull/13305. Reproducer test cases are also included.


linearGradient siblings are moved inside linearGradient

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
<EMAIL_ADDRESS>Link to runnable example
No response
Steps to reproduce
Fun the following script:
import { raw } from 'hast-util-raw'

const reformatted = raw({
  type: 'root',
  children: [
    {
      type: 'element',
      tagName: 'svg',
      properties: {},
      children: [
        {
          type: 'element',
          tagName: 'circle',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'rect',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'linearGradient',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'path',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'g',
          properties: {},
          children: []
        }
      ]
    }
  ]
})

console.dir(reformatted, { depth: Number.POSITIVE_INFINITY })

This causes https://github.com/remcohaszing/rehype-mermaid/issues/17
Expected behavior
It logs:
{
  type: 'root',
  children: [
    {
      type: 'element',
      tagName: 'svg',
      properties: {},
      children: [
        {
          type: 'element',
          tagName: 'circle',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'rect',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'linearGradient',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'path',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'g',
          properties: {},
          children: []
        }
      ]
    }
  ],
  data: { quirksMode: false }
}

Actual behavior
It moves all siblings after linearGradient inside its children.
{
  type: 'root',
  children: [
    {
      type: 'element',
      tagName: 'svg',
      properties: {},
      children: [
        {
          type: 'element',
          tagName: 'circle',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'rect',
          properties: {},
          children: []
        },
        {
          type: 'element',
          tagName: 'linearGradient',
          properties: {},
          children: [
            {
              type: 'element',
              tagName: 'path',
              properties: {},
              children: []
            },
            {
              type: 'element',
              tagName: 'g',
              properties: {},
              children: []
            }
          ]
        }
      ]
    }
  ],
  data: { quirksMode: false }
}

Affected runtime and version
<EMAIL_ADDRESS>Affected package manager and version
<EMAIL_ADDRESS>Affected OS and version
Pop!_OS 22.04
Build and bundle tools
No response

Weird. It seems to be the camelcase.
If I pass any other lowercase string (even lineargradient) through, it nests adjacently fine.
And the weird thing with lineargradient: if I pass that in, I get linearGradient out!

My guess for what’s going on is that the HTML parser is case-insensitive for tag names.
So, parse5 lowercases things.
When we here pass a cased string in, most things go fine, but when doing the closing tag, it doesn’t match up to the current open tag, and is thus discarded.

released in 9.0.3!


Make ZooZap keyword executable

In future, please check for references to main class names before removing their main method.

Fixed in #2597


Not working

companion keeps showing There are no current request yet. and i have configured the config file and restarted server

Same here.

Same here.

Yep, same issue. I'm wondering if, in my case, this is a docker issue?
Does this work with containers?

Yep, same issue. I'm wondering if, in my case, this is a docker issue?
Does this work with containers?

@jbxonline In a container, you would need to change the host IP-address. Is it possible to change your config in the config/debugbar.php like this and fill in the host ip address:
'storage' => [
    'enabled'    => true,
    'driver'     => 'custom', // redis, file, pdo, custom
    'provider'   => \App\SocketStorage::class, // Instance of StorageInterface for custom driver,
    'host' => 'YOUR HOST IP ADDRESS HERE'
],

@jbxonline In a container, you would need to change the host IP-address. Is it possible to change your config in the config/debugbar.php like this and fill in the host ip address:
'storage' => [
    'enabled'    => true,
    'driver'     => 'custom', // redis, file, pdo, custom
    'provider'   => \App\SocketStorage::class, // Instance of StorageInterface for custom driver,
    'host' => 'YOUR HOST IP ADDRESS HERE'
],

Hello,
same issue here.
Changed driver in config/debugbar.php to 'socket' (instead of 'app' proposed in client),
and after debugging it creates and send data to socket, but the client (windows) is not processing the payload.
After enabling developers toolbar in windows client, it shows this:

seems like this is the problem:

Hello,
same issue here.
Changed driver in config/debugbar.php to 'socket' (instead of 'app' proposed in client),
and after debugging it creates and send data to socket, but the client (windows) is not processing the payload.
After enabling developers toolbar in windows client, it shows this:

seems like this is the problem:

@lubop This is fixed by commit 1fcfdf2, but @mpociot didn't create a release yet. If you want, you can use the current master-branch.

@lubop This is fixed by commit 1fcfdf2, but @mpociot didn't create a release yet. If you want, you can use the current master-branch.

@DavyDeCoster thanks, that was the problem.
Managed to build release from current master branch and now it works...

@DavyDeCoster thanks, that was the problem.
Managed to build release from current master branch and now it works...

According to the documentation, the class "SocketStorage" says that it is in master repo of DebugBar, but it is also in the stable version.
Version 0.1.0
OS: Win10 x64
DebugBar version: 3.5.2
I change file "config / debugbar.php" to "driver=>socket". (When starting the app Companion, it says to put "driver => app" on it, but it must be "soket").
The info is sent correctly to the socket (I have tried listening to the port with https://packetsender.com/ and the info is sent from the Laravel app).
The Companion app never shows the information.

According to the documentation, the class "SocketStorage" says that it is in master repo of DebugBar, but it is also in the stable version.
Version 0.1.0
OS: Win10 x64
DebugBar version: 3.5.2
I change file "config / debugbar.php" to "driver=>socket". (When starting the app Companion, it says to put "driver => app" on it, but it must be "soket").
The info is sent correctly to the socket (I have tried listening to the port with https://packetsender.com/ and the info is sent from the Laravel app).
The Companion app never shows the information.

@DavyDeCoster how do i then compile the code to an electron app executable by windows

@DavyDeCoster how do i then compile the code to an electron app executable by windows

@spartyboy install all dependencies using Yarn and then run yarn run build:win should build a executable. If not, try yarn run publish:win

@spartyboy install all dependencies using Yarn and then run yarn run build:win should build a executable. If not, try yarn run publish:win

yea, indeed we need to wait for a new release, master branch it works fine.

yea, indeed we need to wait for a new release, master branch it works fine.

Same here, waiting for a new release

Same here, waiting for a new release

@spartyboy install all dependencies using Yarn and then run yarn run build:win should build a executable. If not, try yarn run publish:win

Thanks @DavyDeCoster, i was able to build the app from the master branch, it's working now

@spartyboy install all dependencies using Yarn and then run yarn run build:win should build a executable. If not, try yarn run publish:win

Thanks @DavyDeCoster, i was able to build the app from the master branch, it's working now

@spartyboy install all dependencies using Yarn and then run yarn run build:win should build a executable. If not, try yarn run publish:win

$ yarn electron:build -- --win  --x64 --ia32 -p always
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
$ vue-cli-service electron:build --win --x64 --ia32 -p always
'vue-cli-service' is not recognized as an internal or external command,
operable program or batch file.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
here is the error i get on trying to build it

@spartyboy i can send you the .exe installer, just let me know

@spartyboy i can send you the .exe installer, just let me know

pls do

For all those who need it, in the following link you can download the installer for Windows:
https://www.4shared.com/s/fW17WRXY1iq

@mpociot Any chance of getting a fixed release for Mac?

for anyone who - like me - googled this issue when looking how to set up debugbar companion to work with docker:
in docker-compose.yml (add to container with laravel):
extra_hosts:
    - 'host.docker.internal:host-gateway'

in config/debugbar.php set
'storage' => [
    'hostname' => 'host.docker.internal'
    (...)
]

@mpociot could you please make a release for mac? Still doesn't work unfortunately


merge package template from Kronos-Tools/npm-package-template

Updated standard to latest version

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   88.42%   88.42%
=======================================
  Files           1        1
  Lines         216      216
=======================================
  Hits          191      191
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320bd3d...00655a1. Read the comment docs.


Eliminate redundant state propagation

This change eliminates several cases of redundant state propagation during the new resume operation. The new code for resume implements its own state propagation, but several calls that happen as part of the OnStateChange function invoke the old method of state change propagation. Specifically, I changed the following:

When there is an error, instead of setting the state of the asset to Failed immediately, I throw an error that is caught by the StateUpdater, which sets the state to Failed.
For cases in which a state change triggers another state change, I allow OnStateChange to return a new state and continue looping and changing state until no more state changes are needed. This capability is only used in CompositeAssetVersionImplD::OnStateChange when setting the state to Succeeded.
There is one case that is not easily handled. Some assets cannot create their children until their inputs have completed. In these cases, OnStateChange calls DelayedBuildChildren to create the children of the asset. StateUpdater doesn't currently handle asset trees that change in the middle of an operation (such as by adding children). Thus, in this case, I revert to the legacy state propagation and abandon the operation in StateUpdater.  This is the call to SyncState in CompositeAssetVersionImplD::OnStateChange. When we work on cleaning up the build operation we can handle this in a better way.

Note: in order to run this code you have to set GraphOperations to 1 in misc.xml. That doesn't apply to unit tests, though, as those don't use misc.xml.

some integration tests failed the first time around. disappeared upon seccessive tests. that being said, lgtm


how to customize and check user-agent?

I read the doc which contains:

pyspider's default user agent string is: pyspider/VERSION (+http://pyspider.org/)

However, which option can set a different user-agent?
try:
pyspider all --user-agent "Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:<IP_ADDRESS>) Gecko/20091201 Firefox/3.5.6"

It didn't work.

http://demo.pyspider.org/debug/js_test_sciencedirect

user-agent is a option for fetcher not all. http://docs.pyspider.org/en/latest/Command-Line/#fetcher
If you want a project level default UA, http://demo.pyspider.org/debug/js_test_sciencedirect is an example.
If you want a global default UA and running with all, using a config.json like this: http://docs.pyspider.org/en/latest/Deployment/#configjson


Categories + pages are now translatable

Marking as draft until Azuriom/Azuriom#46 is merged.

Closing this, as Azuriom/Azuriom#46 is now closed