ipv4/ipv6 field validation, cannot untick ipv6, ...

built wg-manager image from latest source today 5th Jan 2021. Few things won't work

ip4/6 field validation is incorrect. I have to input 10.x.x.x/24 instead of 10.x.x.x, otherwise it won't let me proceed.
cannot disable ipv6, if disabled container logs will throw error, then redirected to login page. Could be related to issue (1)
Error: sqlalchemy.exc.IntegrityError: (sqlite3.IntegrityError) NOT NULL constraint failed: server.v6_subnet

I'm having the same issue. Because I need to put x.x.x.x/xx into the "IPv4 Address" and the "IPv6 Address" fields, while also specifying the Subnet in the Subnet dropdowns, it results in making calls while specifying the IP parameter like "x.x.x.x/xx/xx" e.g. in "ip link add wg0 .... -4 address add x.x.x.x/xx/xx ..." which makes the calls fail. Is there any work around how I can modify the stored addresses or subnet information to get it working?

I'm having the same issue. Because I need to put x.x.x.x/xx into the "IPv4 Address" and the "IPv6 Address" fields, while also specifying the Subnet in the Subnet dropdowns, it results in making calls while specifying the IP parameter like "x.x.x.x/xx/xx" e.g. in "ip link add wg0 .... -4 address add x.x.x.x/xx/xx ..." which makes the calls fail. Is there any work around how I can modify the stored addresses or subnet information to get it working?

@AlexanderAllmendinger  I've added a migration that should enable nullable on v6_subnet. Does this fix your problem?
@ethaniel86 I suppose the latest version should fix your issue

@AlexanderAllmendinger  I've added a migration that should enable nullable on v6_subnet. Does this fix your problem?
@ethaniel86 I suppose the latest version should fix your issue

man you're fast ... thanks for getting back that quick
Unfortunately this didn't do the trick. I'm no web development expert but looking at your commit it looks like you are not allowing that the subnet fields are not set and therefore null.
What I'm trying is creating a new configuration with default parameters (see screenshot). But even with default parameters the validation of the IP addresses for v4 and v6 are failing and therefore I cannot safe the configuration. Once I'm adding a /24 to the ip address fields, the validation works but the IP address is stored with <IP_ADDRESS>/24/24 and therefore any follow up usage fails.
I hope this helps with understanding my issue.

man you're fast ... thanks for getting back that quick
Unfortunately this didn't do the trick. I'm no web development expert but looking at your commit it looks like you are not allowing that the subnet fields are not set and therefore null.
What I'm trying is creating a new configuration with default parameters (see screenshot). But even with default parameters the validation of the IP addresses for v4 and v6 are failing and therefore I cannot safe the configuration. Once I'm adding a /24 to the ip address fields, the validation works but the IP address is stored with <IP_ADDRESS>/24/24 and therefore any follow up usage fails.
I hope this helps with understanding my issue.

@AlexanderAllmendinger hopefully it is not working in the latest update

@AlexanderAllmendinger hopefully it is not working in the latest update

I just gave it another try, unfortunately still no luck...
The validation still blocks entering only an IP Address. I hope I'm not missing a step. I basically pull your commits from the github project and then rebuild the frontend, backend and start the server. But I think that should work...
Anyway, when I'm entering only an IP, the validation is still failing and the field is marked red:

The result of this failed validation is that the "Add Server" button is blocked:

When I then add the /24 to the IP Address the validation succeeds:

Then I can add the server:

But still the stored address is wrong as it has the Subnet mask twice:

I just gave it another try, unfortunately still no luck...
The validation still blocks entering only an IP Address. I hope I'm not missing a step. I basically pull your commits from the github project and then rebuild the frontend, backend and start the server. But I think that should work...
Anyway, when I'm entering only an IP, the validation is still failing and the field is marked red:

The result of this failed validation is that the "Add Server" button is blocked:

When I then add the /24 to the IP Address the validation succeeds:

Then I can add the server:

But still the stored address is wrong as it has the Subnet mask twice:

I'm not able to replicate this. Are you building master branch?

then clicking "add server" works fine here:

I'm not able to replicate this. Are you building master branch?

then clicking "add server" works fine here:

Worth mentioning that it is indeed a bug that you can add subnet in that field.

Worth mentioning that it is indeed a bug that you can add subnet in that field.

Yes, I'm building the master branch and I can see you latest update in the history of my local repository ... but still to me the behavior didn't change yet. Are there any cache files I need to delete?

Yes, I'm building the master branch and I can see you latest update in the history of my local repository ... but still to me the behavior didn't change yet. Are there any cache files I need to delete?

That may very well be. there is an option for disabling cache in chrome
(F12) and the cogwhell. if not you could try opening it in incognito mode
and see if that works.
fre. 22. jan. 2021 kl. 14:13 skrev AlexanderAllmendinger <
<EMAIL_ADDRESS>
Yes, I'm building the master branch and I can see you latest update in the
history of my local repository ... but still to me the behavior didn't
change yet. Are there any cache files I need to delete?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/perara/wg-manager/issues/66#issuecomment-765387261,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4ZS7XKETY5I66YVV7IYSLS3F2VXANCNFSM4VOBMQAA
.

--
[image: photo]
Per-Arne Andersen
PhD Candidate in Artificial Intelligence, University of Agder
+47 905 315 06 <+47+905+315+06> |<EMAIL_ADDRESS>|<EMAIL_ADDRESS>https://www.sysx.no | : dryper11
https://mail.google.com/mail/u/0/#SignatureSanitizer_SafeHtmlFilter_
Spikkelia 28 4821 Rykene, Norway
http://scholar.google.no/citations?user=oPth46oAAAAJ&hl=no
http://github.com/perara http://www.facebook.com/pereher
http://www.linkedin.com/in/perara http://twitter.com/PerArneAndersen

That may very well be. there is an option for disabling cache in chrome
(F12) and the cogwhell. if not you could try opening it in incognito mode
and see if that works.
fre. 22. jan. 2021 kl. 14:13 skrev AlexanderAllmendinger <
<EMAIL_ADDRESS>
Yes, I'm building the master branch and I can see you latest update in the
history of my local repository ... but still to me the behavior didn't
change yet. Are there any cache files I need to delete?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/perara/wg-manager/issues/66#issuecomment-765387261,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4ZS7XKETY5I66YVV7IYSLS3F2VXANCNFSM4VOBMQAA
.

--
[image: photo]
Per-Arne Andersen
PhD Candidate in Artificial Intelligence, University of Agder
+47 905 315 06 <+47+905+315+06> |<EMAIL_ADDRESS>|<EMAIL_ADDRESS>https://www.sysx.no | : dryper11
https://mail.google.com/mail/u/0/#SignatureSanitizer_SafeHtmlFilter_
Spikkelia 28 4821 Rykene, Norway
http://scholar.google.no/citations?user=oPth46oAAAAJ&hl=no
http://github.com/perara http://www.facebook.com/pereher
http://www.linkedin.com/in/perara http://twitter.com/PerArneAndersen

Ok, I don't know what is being cached but there was something cached. I created a new system and now it works fine. Thanks for the fast responses and fix!
You take care and stay well!

Ok, I don't know what is being cached but there was something cached. I created a new system and now it works fine. Thanks for the fast responses and fix!
You take care and stay well!


Show "Your recently pushed branches" on all pages of repo

Haven't looked into how doable this is yet, just curious if there is any interest.
I never go to Pull requests tab and manually click New Pull Request - I exclusively use the following button on the homepage of the repo.

I'd love to see this bar show on more pages of the repository than just the landing page. Thoughts?

Yes! I don't know how you can replicate this alert on other pages though. I usually push, refresh whatever page I have open, get disappointed it's not showing up, and hunt down the create PR button.
It'd be cool if it were a permanent tab on the upper right (when relevant). The only issue with that suggestion is if multiple branches are pushed in a short time frame they get stacked, so I don't know how to handle that.
A simple solution is to just shove the green "Create PR" button in the tabs so you can find it all the time.

Interesting - I never really have to click refresh if I'm on the landing page for the repo.
It looks like GitHub JS opens up a websocket connection, and then calls this URI whenever it gets a notification that a branch related to the repo has been touched.
The URI returns markup for the button, which we can probably just append directly to the DOM.

Wow, GitHub made this super simple to accomplish with a custom element.
Here is some quick POC code I was messing with that seems to get the job done
const touchedPRs = new IncludeFragmentElement();
touchedPRs.src = 'https://github.com/sindresorhus/refined-github/show_partial?partial=tree%2Frecently_touched_branches_list';

Once that is appended to the DOM, GitHub's JS takes care of updating it when a new branch is touched.

I HATE THIS HOW DO I REMOVE IT

@NOTANO0B In extension settings, uncheck this:

ahh ok thanks

wait where is extension settings @kidonng

I don't know what browser you are using. Go to your browser's extension page and look for Refined GitHub, click extension details and you are going to find it.


use VersionParsing.jl to parse version numbers

I notice that you have some parsing machinations for handling foreign version numbers via VersionNumber(string). You might try vparse from https://github.com/stevengj/VersionParsing.jl instead.

Based on https://github.com/stevengj/VersionParsing.jl/blob/master/REQUIRE this would require a mimum Compat Compat 0.62.0. In the process of #21 we have to increase to 0.47.0. anyway. Maybe we should increase to 0.62.0 right away?

No, in general you should list the Compat version that your own code relies upon.   The Pkg system is responsible for merging that with the requirements of your dependencies.

I see, thanks.

See https://github.com/JuliaPackaging/Git.jl/pull/21/commits/932699bcd4c5691208efca17f5211daf83cd227c.

Fixed by #21.


Broken test for requireSpacesInsideArrayBrackets: 'all'

disallow passes, require fails.
I'm assuming that the require one should cover this case?

Maybe related to #1198?

See for more info - https://github.com/jscs-dev/node-jscs/issues/429
Use (require | disallow)SpacesInsideBrackets rules instead

@markelog Should requireSpacesInsideArrayBrackets be deprecated? string.split returns an array, so it's at least deceptively named. requireSpacesInsideLiteralArrayBrackets?

After #429 was fixed (require | disallow)SpacesInsideArrayBrackets started to catch those cases, but we received couple issues about it, some people consider this behaviour as unexpected and want these rules to miss them.
This is why we introduced new more strict rules and removed this logic from (require | disallow)SpacesInsideArrayBrackets

Ah, okay. Thanks!

@SimenB fyi, when you change your message github doesn't notify the participants, could you open a pull for that?


Update maximum domain list on turn-external-sharing-on-or-off.md

https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/1871
In the next article it as update 1 month ago:
https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/blob/live/SharePoint/SharePointOnline/turn-external-sharing-on-or-off.md
PR:
https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/commit/d0b7ac2c33e34fcac73595964b4e62d697e56fd0

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Feature request: add a swap and transaction history to the wallet

I am experimenting with this wallet to understand how it works before committing any significant token amounts to storage. One useful feature of modern wallets is ability to see transaction and swap history.  Do you plan to implement this in the future?

No plans for this. Sollet feature development is mostly done on an as needed basis by people that want the feature. PRs are welcomed.
Also, in the future, please file wallet features in https://github.com/project-serum/spl-token-wallet. This repo is for the swap component, which is used as a library by apps other than sollet.


Saving more than one point_data using TimeSeries

Hello, is it possible to use xdmf.TimeSeries to save more than one result field in the same file? I tried to use it as shown below, but when I read the file, all the data are not present.
       with meshio.xdmf.TimeSeriesWriter('out_file.XDMF') as writer:
              points = nodes
              cells = [("hexahedron", connectivity)]
              writer.write_points_cells(points,cells)
              for i in range(len(time_vector)):
                  t=time_vector[i]
                  writer.write_data(t, point_data={"Temperature": temperature_1[:,0]})
                  writer.write_data(t, point_data={"Qx_flux": q_all_nodes[:,0]})
                  writer.write_data(t, point_data={"Qy_flux": q_all_nodes[:,1]})
                  writer.write_data(t, point_data={"Qz_flux": q_all_nodes[:,2]})`

Note: Saving just one field in a file, "Temperature" for example, works fine.
Thank you.

Hi @mwenceslaucosta,
You should gather all your data in a single dict:
with meshio.xdmf.TimeSeriesWriter('out_file.XDMF') as writer:
    points = nodes
    cells = [("hexahedron", connectivity)]
    writer.write_points_cells(points,cells)
    for i in range(len(time_vector)):
        t=time_vector[i]
        writer.write_data(t, point_data={
            "Temperature": temperature_1[:,0],
            "Qx_flux": q_all_nodes[:,0],
            "Qy_flux": q_all_nodes[:,1],
            "Qz_flux": q_all_nodes[:,2],
            },
        )

Another issue with your code is that you are saving the same arrays at each time step.


Update FileTypes.cs

Compress it Update FileTypes.cs

Please stop spamming these pull requests. I'm not going to merge something which just removes whitespace.


Proposal: Replace HSCI and KCI with causal-learn package functions

The causal-learn package provides more sophisticated implementations of the kernel independence tests. Instead of reimplementing it, we utilize the existing functions from causal-learn instead.

Closing for now until the license issue is resolved.


roboai train en nlu is not working

It trains both nlu and core

It's working... It's roboai train en --nlu


Release ocluster-worker and associated library as a standalone package

This PR attempts at replacing #151.
I'm introducing a new package, ocluster-worker, which contains the public ocluster-worker binary and public ocluster-worker library (the previous PR only exposed the library in this package).

However there is an issue with the obuilder git submodule that causes linker errors when trying to use the resulting ocluster-worker library: It gets compiled with the pinned obuilder, but it still requires a dependency on the publicly released obuilder (causing a conflict, see https://github.com/ocaml/dune/issues/3911). That's why the second commit removes the submodule and replaces it with an opam pin. Is there an alternative solution to this issue that you would prefer?

The ocluster-worker package will now depend on the correct released version of the obuilder package: in this mode, obuilder is not vendored as a submodule. If projects using the ocluster-worker library just depend on the ocluster-worker package and link with the library, I think this solves your problem.
The main issue we've been having with vendoring projects as submodules is when the same project gets vendored multiple times. Unless I'm wrong, that's not what's happening with your use case.
I'm not entirely convinced we need a new package either: we could just expose the ocluster-worker library as part of the ocluster package. It also seemed more logical to add the ocluster-worker binary to the ocluster-worker package.
I've also made the ocluster package depend on ocluster-worker as a kind of meta-package.
cc @ElectreAAS @art-w
EDIT: we've confirmed offline the current-bench project just needs the ocluster-worker library exposed. Do we want to expose it as part of the ocluster package, or in a new package?

Thanks!


[ci skip] [skip ci] [cf admin skip] NO_CI Add ABI Migration v1.17.x

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Docker container not able to communicate to SQL server

I have two ASP.NET Core 2.0 application "App A" and "App B".
App A is the hosted in Host machine IIS and communicate with SQL server to get data from database.
App B is deployed in Docker container and communicate with App A. But I am getting error when App A is trying to establish connection with MS SQL server and giving error like below:
"Login failed for user 'NT AUTHORITY\ANONYMOUS LOGON'"
When I create user 'NT AUTHORITY\ANONYMOUS LOGON' in SQL server then it is able to communicate correctly and getting data from the database.
Can you please suggest why it is required the 'NT AUTHORITY\ANONYMOUS LOGON' user under SQL server? Can we have connection without this user creation?
App B Docker File:
FROM microsoft/aspnetcore:2.0
WORKDIR /app
COPY ./DeployPackage .
ENTRYPOINT ["dotnet", "AppB.dll"]
App B Docker-Compose File:
version: "3"
services:
api:
build:
context: .
dockerfile: Dockerfile
image: tscon
ports:
- "80:80"

Hi, @VijayPatel1 , this doesn't appear to be a docs issue. Would you please ask your question on the forums? https://forums.docker.com/  Thank you!


Add skeleton implementation

Introduce local cache on client side

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7463/
Test FAILed.

alluxio-bot, merge this please.


[Feature Request]: Want to improve Signup Signin Cards Ui #466

Description
Fixed Cards Ui #466
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X ] My code follows the code style of this project.
[ X] My change requires a change to the documentation.
[ X] I have updated the documentation accordingly.

hey @sanket95droid @dinxsh  can you review this pr

Hey @dinxsh can you add level and gssoc labels toh this and assign it to me as well please


v0.4a2 - Solo or group setting button disappearing

If you switch to event songs then go back to "non-event" songs, the button to select solo or team setting has disappeared.

Looks workin gin WIP branch, avaiable in next release


chore(deps): update resource server to version 1.2.0

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines

Description of change

https://github.com/Jasig/resource-server/releases/tag/resource-server-1.2.0

Resource server is working, some libraries need to be updated to a newer version.

👍
Don't forget to look into portlets that aren't in the default layouts.


Reviewing mode on the editor doesn't show individual component structure drawings

The issue appears to be that validateCompound is never called; investigating.

validateReaction only "clicks" visible validation buttons, so this is a race condition between freeze and validate.


Use models after training to classify unknown data

Hi, first of all: Thanks for your work! I'm new to GNNs in the domain of fake new detection and I could reproduce the training. My question is now what to do next with those models? Or how can I check a news article if it is fake or not?

Hi, thanks for your interest in our project!
There are two future directions you can work on given our repo:
1. Methodology-oriented:
Given the UPFD dataset, you can split the existing data into training&test sets and devise a better GNN model that can hit higher performance on the test set.
2. Application-oriented:
Following the same approaches described in our UPFD paper, you can crawl news posts and their engaged tweets on Twitter and construct news propagation graphs. Then you could train and test the GNN models introduced in this repo on a new set of news.

@YingtongDou thank you for the fast reply. I'd go with the application oriented approach. Can you tell me how I can:

construct a new propagation graph?
test the GNN models from this repo on a new set of news?
Or provide any sources that adress these tasks?

I got so far that I collected data from twitter, created a custom data object using bag of words as feature but I'm struggling how to apply the model I train to new data. Normally, I'd to a fit and transform in machine learning. But for GNNs I only find information on how to do the fit, not how to do the transform.

construct a new propagation graph?
Please refer to Section 2.2 in paper for details on constructing a news propagation graph.
Moreover, you need to check out the data_loader.py to figure out how to transform the collected data (adj matrix, node features, news labels) into pyg data format.

test the GNN models from this repo on a new set of news?
Testing on a new set of news also starts from collecting news data from Twitter and then building the news propagation graph. During training the model on old data, you can save the variables of the best-performed model. Then you can load the best-performed model to classify the newly collected news based on their propagation graphs.


Text bug when resizing browser window

Hey, when implementing my needs of your progressbar plugin, I came across a bug. I wrote some code to initially hide my progress bar so I could show it at a later point. It works like a charm but I randomly see a piece of my 'amount_format' text displayed at the very left of the bar.
I created a fiddle to simulate the problem: http://jsfiddle.net/kLvje0o6/4/
It happens almost randomly but I found a way to reproduce it 100%. if you risize the window between my function call 'progressTo(0)' and 'progressTo(1)', it will show.
I wrote a timeout in the fiddle, just resize your browser window (width or height) in the 4 seconds of the timeout when you run the fiddle.
Interesting to note that, if you resize it again after that, the piece of text dissapears again.
Screenshot: http://oi62.tinypic.com/2lsbm7k.jpg

It is probably a bug due to the fact I set 'display' to 'none' and the plugin can't access the bar's width anymore. If this is the case, any suggestion on how I should properly hide my progressbar?

I am also seeing this issue; in my case, it's because the progress bar is inside a collapsible bootstrap panel, which is collapsed by default. Upon expanding the panel, you get the duplicated offset text, but after resizing the window while the panel is open, it fixes itself.


SPTextUtil.harSPINRDF() to allow non-SPIN properties on Commands

Fixes #2
This method should probably move to Command.hasSPINRDF() eventually

https://github.com/blog/1506-closing-issues-via-pull-requests
@pumba-lt  Can we try to the GH automation? Please add "resolves #2" as a commit message and (I think!) it will close the issue when this is merged. (It can be an empty commit - it is just the message that matters.)

Uhm, but I commit to my fork/branch where there is no such issue?
I had added "Fixes #2" to the pull request message here -- isn't that the same?

Reading the GH documentation (see link above) I think what you have done will work.  We'll find out!

And who decides whether to merge the PRs?

See issue #6. The suggestion is when enough "+1" are given.

So, how long before anyone gives +1? I don't know if I should contribute more if the changes will take forever to merge...

Time comes and goes :-) actually, I though I had but it seems I hadn't. No bad.
Merged.


spirv-fuzz: fuzzer_replayer failure

To reproduce:
Clone 636f449e, comment out these lines
https://github.com/KhronosGroup/SPIRV-Tools/blob/636f449e1529a10d259eb7dc37d97192cf2820f8/source/fuzz/fuzzer.cpp#L253-L255
and run FuzzerReplayerTest.Miscellaneous6. The issue occurs on seed 69.
What's known so far.
The test fails because replayer is unable to reproduce some transformations. Diffs for the transformation sequence and decompiled code are below.
--- fuzzer.json 2020-06-03 11:37:05.149236422 +0300
+++ replayer.json       2020-06-03 11:37:05.153236518 +0300
@@ -815,43 +815,6 @@
   {
    "replaceIdWithSynonym": {
     "idUseDescriptor": {
-     "idOfInterest": 318,
-     "enclosingInstruction": {
-      "baseInstructionResultId": 324,
-      "targetInstructionOpcode": 81
-     }
-    },
-    "synonymousId": 335
-   }
-  },
-  {
-   "replaceIdWithSynonym": {
-    "idUseDescriptor": {
-     "idOfInterest": 318,
-     "enclosingInstruction": {
-      "baseInstructionResultId": 340,
-      "targetInstructionOpcode": 80
-     },
-     "inOperandIndex": 1
-    },
-    "synonymousId": 338
-   }
-  },
-  {
-   "replaceIdWithSynonym": {
-    "idUseDescriptor": {
-     "idOfInterest": 335,
-     "enclosingInstruction": {
-      "baseInstructionResultId": 324,
-      "targetInstructionOpcode": 81
-     }
-    },
-    "synonymousId": 318
-   }
-  },
-  {
-   "replaceIdWithSynonym": {
-    "idUseDescriptor": {
      "idOfInterest": 335,
      "enclosingInstruction": {
       "baseInstructionResultId": 360,

--- fuzzer.dis  2020-06-03 11:37:05.157236614 +0300
+++ replayer.dis        2020-06-03 11:37:05.157236614 +0300
@@ -315,7 +315,7 @@
 %570 = OpLogicalNot %319 %372
 %425 = OpAccessChain %114 %418
 %571 = OpLogicalNot %319 %564
-%340 = OpCompositeConstruct %76 %357 %338
+%340 = OpCompositeConstruct %76 %357 %318
 %572 = OpLogicalNot %319 %501
 %410 = OpLogicalNot %319 %377
 %370 = OpCompositeConstruct %94 %454 %360

As you can see, three transformations are missing from the replayer sequence. The first one is missing because IsApplicable method returns false in replayer here
https://github.com/KhronosGroup/SPIRV-Tools/blob/636f449e1529a10d259eb7dc37d97192cf2820f8/source/fuzz/transformation_replace_id_with_synonym.cpp#L47-L51
However, if you are to print a sequence of facts that gets added into the FactManager in both fuzzer and replayer, you'll see that those sequences are completely identical.

This could be to do with the fact manager giving up adding synonyms. Maybe it could be to do with iteration over unordered containers. I would suggest printing out ALL facts at each step and comparing the fuzz vs replay.


Ask plugin if given source is supported url format

hi,
video.js asks via "canPlay" if a given source object can be played. I would like to extend that method so that if no type is provided, a reggex is used.
Is there any way to easily implement this, so I don't have to duplicate the test code?
for the vimeo plugin I solved it this way:
videojs.Vimeo.canPlaySource = function(srcObj){
  if (srcObj.type)
      return (srcObj.type == 'video/vimeo');
  else {
      var regExp = /^.*(vimeo\.com\/)((channels\/[A-z]+\/)|(groups\/[A-z]+\/videos\/))?([0-9]+)/;
      var match = srcObj.src.match(regExp);

      return (match)
  }
};

This seems to have changed quite a bit on the core. I'll have to check how we can handle that.

Did it?
Actually, Video.js asks the plugin if it can play a given source. The current implementation only checks the source type, but not the src.

I was trying to check when canPlaySource is called and your else will never happen. The reason is if we don't have a type, it will not even check. It makes sense for regular videos but not for 3rd party services.
I think I know a great way to do that so I will propose a fix to them so canPlaySource can get called and we'll see what they think.

In the mean time, you can specify your type (video/youtube or video/vimeo) so the tech are changed.

It get's called when you add child source elements, and not when you set src in the video element.

It will get called only if you specify the type like that:
player.src({ type: 'video/youtube', src: 'https://www.youtube.com/watch?v=7MAVG2BfTHc' });

I am doing a PR that will let tech like YouTube take over when their is a youtube URL but for now it is impossible.


fix(types): use module dts in package types

This PR uses the modules dts in the default package export types and types entries: the module types from previous PR missing #3212
🔗 Linked issue

#3201
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have added tests (if possible).
[ ] I have updated the documentation accordingly.

/cc @danielroe
That's weird, generating the dist on my local Windows the types dts are fine, both dts exports shared types, on linux/unix only exporting module types:

while in Linux wsl (ubuntu):

The problem is the export * from ./typesin themodule.ts`: on Windows, that export is "expanded" while on Linux no: check screenshot debugging the nuxt module builder build:

Windows

Linux


Migration error on PostgreSQL 15

Pulse Version
1.0.0-beta7
Laravel Version
10.37.3
PHP Version
8.2
Livewire Version
3.3.0
Database Driver & Version
PostgreSQL 15
Description
I'm using Forge+DO for my dev servers.
If you run php artisan migrate with pgsql connection (PULSE_DB_CONNECTION=pgsql) you will have an error message:
SQLSTATE[42601]: Syntax error: 7 ERROR:  syntax error at or near ")"
LINE 1: ...(16) not null generated always as (unhex(md5(key))), "valu...
^ (SQL: create table "pulse_values" ("timestamp" integer not null, "type" varchar(255) not null, "key" text not null, "key_hash" char(16) not null generated always as (unhex(md5(key))), "value" text not null))
Solution is to create tables, manually :
create function unhex(text) returns text language sql immutable strict as $$
  select encode(decode($1, 'hex'), 'escape')
$$;

create table pulse_values (timestamp integer not null, type varchar(255) not null, key text not null, value text not null, key_hash char(16) generated always as (unhex(md5(key))) stored);

And I had to do it for other tables too...
Steps To Reproduce
Use Postgres for your database, install Pulse and run php artisan migrate...

Same issue on 14.

Same issue on 14.  Pulse Beta 8. Oddly Postgres 13 works fine in dev env.

I've updated laravel to latest version and migration worked fine)

Same issue on 14.  Pulse Beta 8. Oddly Postgres 13 works fine in dev env.

I've updated laravel to latest version and migration worked fine)

Hmm.. I ended up having to create my triggers and stuff with a little help from GPT.


Improve management plane lro implementation

Fix #3076
Description
Add your description here!
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

Please hold the merge of this PR.
Could you generate the SDK PR so that we could understand the impact?   cc @ArthurMa1978

Please hold the merge of this PR. Could you generate the SDK PR so that we could understand the impact? cc @ArthurMa1978 Arthur Ma FTE

The regen is here and this PR will not be merged at present as many tests in management plane will be affected.

Please hold the merge of this PR. Could you generate the SDK PR so that we could understand the impact? cc @ArthurMa1978 Arthur Ma FTE

The regen is here and this PR will not be merged at present as many tests in management plane will be affected.

Can we add that link to the top level description so its easy to find


gR is not working in elfeed

gR is not working in elfeed because of typo here
It should read as :map elfeed-search-mode-map

Good catch! As of c1f973b this issue should be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!


Add code property to redis errors

The redis protocol implies all error responses will begin with an all-caps error code, which could be included in the code property of the parsed error object.
function require_error(label, code) {
  return function (err, results) {
    assert.notEqual(err, null, label + " err is null, but an error is expected here.");
    assert.strictEqual(err.code, code, label + " expected err with code " + code + ", got code: " + err.code);
    return true;
  };
}

client.evalsha("ffffffffffffffffffffffffffffffffffffffff", 0, require_error("EVALSHA", "NOSCRIPT"));

@skeggse what is the benefit of adding the .code? Does it make any difference for you if you just test the error message in your code for the error code instead?

It's just for convenience. It doesn't degrade performance in any meaningful way - this kind of exception path should generally not be optimized.

@skeggse would you be so kind and rebase this and add some tests?


Add resume section

You have created many pull requests, all these commits could have been done in just once PR.
Make sure this doesn't happen in the future 🙂 . I would squashed all the commits into one. So many PRs doesn't seem so good.


[Request-For-External]  Codeunit 8 "AccSchedManagement"   AccPeriodStartEnd

Can you please set the funktion AccPeriodStartEnd   from local to global?
procedure AccPeriodStartEnd(ColumnLayout: Record "Column Layout"; Date: Date; var StartDate: Date; var EndDate: Date)
    var

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Brazilian Portuguese Language

Proposed Changes

Brazilian Portuguese language added.

Related Issues

(Github link to related issues or pull requests)

Thanks 😊


⚠ Turnos 24x7 has degraded performance

In 29552f6, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1000 ms

Resolved: Turnos 24x7 performance has improved in 3bc9b4d.


Plot JSON

@sampreets3 how is this going ?

I have been able to plot the data in a tabular format, as shown in the picture below. Just need to figure out the axes and I am done

Hey @guilyx I am thinking of doing a simple plot where I just show the stats for each key in a plot. Like mean jitter time, how it changes from key 0 to 20. What do you think?

Hey @guilyx this is the result I have been able to achieve as of now. Working to make this better, by omitting useless data

Closed in #15


Allow for asynchrony between main and worker lwaftr for stats

If you've tested that it works, LGTM

i have indeed tested it and it works, tx for review


Fix algolia searchbar (firezone#884)

Pull Request Test Coverage Report for Build 34902052eb0c1df63034571855e6c5ee20a545bf-PR-9

52 of 63 (82.54%)  changed or added relevant lines in 17 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.3%) to 69.348%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

apps/fz_http/lib/fz_http/users/password_helpers.ex
0
1
0.0%

apps/fz_http/lib/fz_http/repo/notifier.ex
2
7
28.57%

apps/fz_http/lib/fz_http_web/channels/user_socket.ex
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

apps/fz_http/lib/fz_http_web/views/layout_view.ex
1
66.67%

Totals

Change from base Build 6a08d2dcbb1da9d4350c4de18370527287927c48:
0.3%

Covered Lines:
1000

Relevant Lines:
1442

💛  - Coveralls


make everything compile on the stock toolchain

This makes everything compile on the stock toolchain! Also everything still compiles on tensorflow-0.12 toolchain, so that you can continue working with that.
@ProfFan, let me know if it's okay for me to merge this with the tracking branch and also update the tracking branch to work with the stock toolchain. If it's okay, I'll do that next.
Note: The process for installing the stock toolchain with the required TensorFlow libraries is currently a bit complicated, so I wouldn't suggest trying it yourself yet. Soon we should have a simplified process. But if you really want to try it yourself, let me know and I can describe the process.
The required changes were:

import _Differentiation to enable differentiation
The stock toolchain seems a bit more strict about requiring @differentiable annotations on functions that are called by other @differentiable functions, so I added a few more @differentiable annotations.
Conditionally import PythonKit only if it is available, because it's not available by default on stock toolchains.
Delete the dependency on swift-models (because it doesn't compile on stock toolchains yet), and copy-paste the required code from swift-models into a ModelSupport module.

Nice! I get: warning: dependency 'swift-argument-parser' is not used by any target.
Suggest you remove that from Package.swift

How do I get a stock toolchain this works with?


Please invite me to the community

Name
Shubham Kukreti
Discord Username (if applicable)
Shubham Kukreti#7346
Additional Context
Let's go 🚀

Can u try again, the workflow failed ehehehe but now fix


after creating service with invalid yamls, create service fails for ever even you use the valid yamls

In GitLab by @liyanq528 on Jan 17, 2019, 11:01

In GitLab by @liyanq528 on Nov 8, 2019, 08:02
This issue did not show when after test.

In GitLab by @tmon546596046 on Nov 8, 2019, 08:02
after upload the deployment and service yaml， then close the Chrome or Firefox，then you can't upload same yamls again. this issue descirbed by sangchenggang.

In GitLab by @tmon546596046 on Nov 8, 2019, 08:02
the problem disappears in release 2.0 beta

In GitLab by @sokril on Nov 8, 2019, 08:30
closed

In GitLab by @sokril on Nov 8, 2019, 08:30
assigned to @tmon546596046


Change mutiple code snippets execution procedure

Purpose
Fixes #35685
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.15 out of 16 committers have signed the CLA.:white_check_mark: MaryamZi:white_check_mark: sameerajayasoma:white_check_mark: HindujaB:white_check_mark: warunalakshitha:white_check_mark: rdulmina:white_check_mark: lochana-chathura:white_check_mark: azinneera:white_check_mark: udda1996:white_check_mark: DamithaSenevirathne:white_check_mark: pcnfernando:white_check_mark: gimantha:white_check_mark: NipunaRanasinghe:white_check_mark: nipunayf:white_check_mark: SumayyaZiyad:white_check_mark: prabushi:x: Sumayya ZiyadSumayya Ziyad seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


PCSTR.ToString() should convert as an ASCII string

Actual behavior
PCSTR seems to have a wrong Encoding.
See Data-types
Expected behavior
Either documentation or implementation is wrong.
Repro steps

NativeMethods.txt content:

PSTR
PCSTR

NativeMethods.json content (if present):

Any of your own code that should be shared?

Context

CsWin32 version: [0.2.110-beta]
Win32Metadata version (if explicitly set by project):
Target Framework: [net6.0-windows]
LangVersion (if explicitly set by project): [e.g. 9]

Are you saying that it should use ANSI instead of UTF8 when decoding the bytes?
I think wikipedia describes the situation well. In the docs, ANSI isn't a particular character set. If we were to be strict about it, I think the correct encoding to use would be whatever the current codepage is for Windows (as returned from the GetACP function).
A great resource for learning about this is here: https://learn.microsoft.com/en-us/windows/win32/intl/code-pages
In practice, I think many narrow character functions actually assume a UTF-8 encoding, but I'm not sure.
@mikebattista, thoughts?


Add AzureADRecon

AzureADRecon is a tool which extracts and combines various reconnaissance artifacts out of an Azure AD environment with a valid credential.
This PR is blocked until @269 is resolved.

@nos3curity bump

this package depends on a deprecated powershell module. closing this.


The directory link error

when clicking any link，it shows like this

not what it should be ,  anyone who can help me solve this ,many thanks!

Hello,
Can you send me your settings and the command you use to start the server ?

@onigoetz   Hi, I used the MAMP to start an apache server .  and change settings of httpd.conf file as the others said online.  when I download a former version of daux, nothing changed of setting , it worked, so I think maybe there is something wrong with the latest version,  when clicking the subdirectory and page files, it shows a strange page just like the second screenshot

Thank you for your answers, did you do a composer install after the download ?
If not that means you are using daux.phar which is an unsupported version (the previous way to package the applications)

@onigoetz  Many thanks,
not yet, I'm not familier with coding, I just download the zip file，unpacked it ，and use MAMP to serve it， do you mean if I do the composer install, this problem will be solved ? cause I am using the old version, and it seems OK right now


entur_public_transport - fails if no "StopPlace" defined

Home Assistant release with the issue: 0.84.0b4

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.): Hass.io on Ubuntu

Component/platform: https://www.home-assistant.io/components/sensor.entur_public_transport/

Description of problem: Component fails if only "Quay" is defined, adding a "StopPlace" line resolves the problem
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
#This config fails
- platform: entur_public_transport
  name: Busstider
  expand_platforms: true
  show_on_map: true
  stop_ids:
    - 'NSR:Quay:12089'
    - 'NSR:Quay:11976'

#This config works
- platform: entur_public_transport
  name: Busstider
  expand_platforms: true
  show_on_map: true
  stop_ids:
    - 'NSR:StopPlace:548'
    - 'NSR:Quay:12089'
    - 'NSR:Quay:11976'

Traceback (if applicable):
2018-12-12 20:02:43 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up platform entur_public_transport
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/sensor/entur_public_transport.py", line 80, in setup_platform
    data = EnturPublicTransportData(API_CLIENT_NAME, stops, quays, expand)
  File "/usr/local/lib/python3.6/site-packages/enturclient/api.py", line 27, in __init__
    self._expand_all_quays()
  File "/usr/local/lib/python3.6/site-packages/enturclient/api.py", line 74, in _expand_all_quays
    if len(stop_place['quays']) > 1:
TypeError: 'NoneType' object is not subscriptable

Additional information:

@hfurubotten Any idea ?

If you set expand_platforms: false it should work without the *:StopPlace:* in the configuration.
The *:Quay:* ids are the platforms coming from the stations found in EnTur's systems, so the expand_platforms would only be useful with a *:StopPlace:* in the config.
Throwing an exception is a bug, so I would have to fix that, but this should work for now, @aherbjornsen  😃

Yes, I can confirm that when setting expand_platforms: false it does work.
I can live with that (I could even live with a "dummy" stop). @hfurubotten Thanks.


Sheep don't regrow coats.

Exactly as title says, sheep wont regrow their coats if you don't disable them in the config.

Not entirely sure, reporting this as someone who downloaded, dragged & dropped the plugin into my servers plugins folder, & restarted my server. It works fine for everything else, but if I had to assume it’s probably remove-ai, because the sheep aren’t even trying to eat grass

If you've not changed any settings then the sheep should only be affected by the disable-collisions and remove-random-movement actions, which I've just tested locally and confirmed do not affect wool regrowth. Check your config to see if you've enabled any profiles that use remove-ai or remove-awareness and also check in-game with /farmcontrol status to see if any entities are affected by those actions. Otherwise, I don't think it's a FarmControl causing it


rkt run appends arguments to CMD from Dockerfile instead of overriding CMD

Environment
rkt Version: 1.29.0
appc Version: 0.8.11
Go Version: go1.7.6
Go OS/Arch: linux/amd64
Features: -TPM +SDJOURNAL
Linux 4.14.11-coreos x86_64
NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1576.5.0
VERSION_ID=1576.5.0
BUILD_ID=2018-01-05-1121
PRETTY_NAME="Container Linux by CoreOS 1576.5.0 (Ladybug)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://issues.coreos.com"
COREOS_BOARD="amd64-usr"
systemd 234
+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK -SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT -GNUTLS -ACL +XZ +LZ4 +SECCOMP +BLKID -ELFUTILS +KMOD -IDN2 -IDN default-hierarchy=legacy
What did you do?
/usr/bin/rkt run --volume volume-consul-data,kind=host,source=/mnt --net=host -- -insecure-options=image docker://consul -- version
What did you expect to see?
Consul should return his version.
What did you see instead?
[64151.271073] consul[6]: ==> config: Unknown extra arguments: [version]
Workaround
/usr/bin/rkt run --volume volume-consul-data,kind=host,source=/mnt --net=host -- -insecure-options=image docker://consul --exec docker-entrypoint.sh -- version
I'm still not 100% sure if it's rkt bug. For me it looks like rkt is adding given arguments to CMD from Dockerfile instead of overriding it as long as --exec argument is not given.

Thanks for the report. I'm not sure I've exactly understood your expectation, but the argument-passing behavior is documented here: https://github.com/rkt/rkt/blob/2401fd846a941ca4e567eba658aa59a80581b6f6/Documentation/subcommands/run.md#passing-arguments
Is your container image behaving differently than that or were you just expecting a different behavior?

The main point is Dockerfile specify CMD which can be used to run image with default arguments. Using docker run this arguments can be easily overridden. This is different in rkt where it requires adding --exec to override it. This requires knowing ENTRYPOINT to override CMD and in my opinion is not intuitive regarding Dockerfile documentation stating main purpose of CMD: is to provide defaults for an executing container.. I would rather expect this defaults should be overridden by provided arguments.


Call echo_logs only when in DEBUG mode

The echo_logs function prints out the logs from the container (i.e. the output of aiidalab-launch logs) while the user waits for the container to start. However, logs are printed with logging.DEBUG so there's no point in calling this function unless this level of logging is enabled (via the -vvv cmdline parameter).
We have some indication that this function is problematic in #154 so calling it only when neccessary might help. We also have issues with flaky tests, #163. While the change here does not solve the flakiness (see failures here and here), it does seem to help since the test suite no longer times out, but actually fails in a reasonable amount of time. I haven't been able to pinpoint the reason for the failures, looking at the error messages it seems that the container fails to start randomly. So more investigation is needed but this seems to be a step in right direction at least.

I am going to release it after this one is merged.

@unkcpz thanks. Feel free to merge, I do not have permissions.

@danielhollas merged thanks!

I do not have permissions.

Let me know if you need higher permission for convenient management.


Can this query cause a cartesian explosion?

This query completed in 20000 ms for a few samples.  Is it beause of the cartesian explosion ? or What is the reason for this delay? .
await   context.Schools.Where(x => x.Id == schoolId)
                    .Include(x => x.Faculties)
                        .ThenInclude(x => x.Departments)
                              .ThenInclude(x => x.Teachers)
                                   .ThenInclude(x => x.Lectures)
                    .Include(x => x.Faculties)
                        .ThenInclude(x => x.Departments)
                              .ThenInclude(x => x.Teachers)
                                   .ThenInclude(x => x.Courses)
                    .Include(x => x.Faculties)
                        .ThenInclude(x => x.Departments)
                              .ThenInclude(x => x.Teachers)
                                   .ThenInclude(x => x.Projects)
                   .FirstOrDefaultAsync();

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 43baa9f3-c415-c328-6c10-53aabaaec652
Version Independent ID: 4e789a1b-aa88-d194-dc2e-0a23251250d7
Content: Single vs. Split Queries - EF Core
Content Source: entity-framework/core/querying/single-split-queries.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @roji
Microsoft Alias: avickers

Yes, this is exactly the scenario described in the docs; try executing the SQL generated by EF and seeing how many rows are returned. The docs describe how to deal with this, e.g. use split queries.


Support custom discovery URLs and no auth in samples

Add a trivial foo.v1.json discovery doc to test.

Codecov Report

Merging #1163 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb99e1...fa5855f. Read the comment docs.

OK, I've cleaned up the snippets a bit, it's a bit tricky with these templates. I've only done it for the statements where there's no code duplication or extra lines.
I wish there was snippet support for more complex statements :/ at least a continue in a switch case or something...


pythonPackages.distributed: 1.15.1 -> 1.22.1

Motivation for this change
Wanted to run dask distributed on python 2.7 and 3+. Additionally wanted all tests to pass. A lot of work had to be put into adding testing frameworks and ensuring that all the underlying libraries were also compatible.
Things done
For all the following all tests pass and run on python 2.7, 3+ now.
pythonPackages.distributed: 1.15.1 -> 1.22.1 and refactor
pythonPackages.pytest-repeat: init at 0.6.0
pythonPackages.joblib: 0.21.1 -> 0.21.2 and refactor
pythonPackages.python-lz4: init at 2.1.0
pythonPackages.pytest-faulthandler: init at 1.5.0
pythonPackages.pytest-timeout: refactor

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

Requires myself to be added to maintainers (pull request #44655) list before this pull request

@GrahamcOfBorg eval

@dotlambda I would really like to thank you for how detailed you have been in your code reviews. I have learned a lot on how to properly package with nix and several git techniques I didn't know how to do (squash, reset --soft, etc.) really helped me with learning how to create good looking commits.
There are a lot of packages updated in the following commit. It was necessary in order to make all the tests run and ensure that it also worked on python 2.7. Looks like it was neglected in some of the packages that I have refactored.
Some questions I have about style.

is the goal to eventually move all packages out of pkgs/top-level/python-packages.nix -> pkgs/development/python-modules/...?
pypi archives most of the time do have all the tests and setup. Is it good form to use the github repository instead? At least here we can run all the tests

is the goal to eventually move all packages out of pkgs/top-level/python-packages.nix -> pkgs/development/python-modules/...?

Yes, and I think more than 2/3 have already been moved.

pypi archives most of the time do not have all the tests and setup. Is it good form to use the github repository instead? At least here we can run all the tests

Fetching from GitHub has the disadvantage that our batch upgrade script won't work until https://github.com/NixOS/nixpkgs/pull/41149 is done. I sometimes open upstream PRs to add tests to the tarball, e.g. https://github.com/ethereum/eth-hash/pull/20.

@GrahamcOfBorg build python2.pkgs.distributed python3.pkgs.distributed

@costrouc These commits all look very nice. Thank you for your thorough work!

Failure on x86_64-linux (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed
Partial log (click to expand)
cannot build derivation '/nix/store/clzis8sxxbjxrgcpzj59jd1zpqpwdmjs-python3.6-joblib-0.12.2.drv': 1 dependencies couldn't be built
test_pytest_timeout.py ...................................               [100%]

========================== 35 passed in 94.51 seconds ==========================
cannot build derivation '/nix/store/ixjalzamq475gcf8nkm6lqwymaijfdb0-python2.7-distributed-1.22.1.drv': 3 dependencies couldn't be built
test_pytest_timeout.py ...................................               [100%]

========================= 35 passed in 121.42 seconds ==========================
cannot build derivation '/nix/store/6vbqnpivvxj2vjx2ylq633i6lkpb79hn-python3.6-distributed-1.22.1.drv': 3 dependencies couldn't be built
error: build of '/nix/store/6vbqnpivvxj2vjx2ylq633i6lkpb79hn-python3.6-distributed-1.22.1.drv', '/nix/store/ixjalzamq475gcf8nkm6lqwymaijfdb0-python2.7-distributed-1.22.1.drv' failed

Failure on aarch64-linux (full log)
Attempted: python2.pkgs.pytest-timeout, python3.pkgs.pytest-timeout, python2.pkgs.pytest-faulthandler, python3.pkgs.pytest-faulthandler
Partial log (click to expand)
plugins: timeout-1.3.1
collected 35 items

test_pytest_timeout.py ...................................               [100%]

========================= 35 passed in 517.85 seconds ==========================
test_pytest_timeout.py ...................................               [100%]

========================= 35 passed in 527.26 seconds ==========================
error: build of '/nix/store/n77309chczgsd6bbvkl6cjj4q5v6jw2q-python3.6-pytest-faulthandler-1.5.0.drv', '/nix/store/x1sdwl4z2mfhl301ha5ifnrr89if7cj8-python2.7-pytest-faulthandler-1.5.0.drv' failed

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/rplfrxvynrzr52fvlh84n2alflm0n9i8-python2.7-pytest-timeout-1.3.1/lib
patching script interpreter paths in /nix/store/rplfrxvynrzr52fvlh84n2alflm0n9i8-python2.7-pytest-timeout-1.3.1
running install tests
============================= test session starts ==============================
platform darwin -- Python 2.7.15, pytest-3.6.3, py-1.5.4, pluggy-0.6.0
rootdir: /private/tmp/nix-build-python2.7-pytest-timeout-1.3.1.drv-0/pytest-timeout-1.3.1, inifile: tox.ini
plugins: timeout-1.3.1
collected 35 items

error: unexpected end-of-file

Failure on aarch64-linux (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed
Partial log (click to expand)
                                        ^~
building of '/nix/store/0bsfv0mr6vf1xvi11nm6fd52adjhz3aq-python2.7-pandas-0.23.3.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/d6yshyck6a178j2sfdswq3zy8xr86b1p-python2.7-partd-0.3.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mx6yr91v3v9kvs60h7sb4izj01a5qjzg-python2.7-dask-0.18.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9mzxjjdyzwsxxq3sdh47vc111b2n889d-python2.7-distributed-1.22.1.drv': 4 dependencies couldn't be built
building of '/nix/store/qvrv5d2dw6zxdmqxc311fq0f4ixwvdpm-python3.6-pandas-0.23.3.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/22hdlj49g7a3zjsnh2n8sfz85wqsrbng-python3.6-partd-0.3.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/c3mvsf26s2sb639p3mvxdrjx5c2ycjsc-python3.6-dask-0.18.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/cdg226yxavzz9zyp9j7d5533p41rby9s-python3.6-distributed-1.22.1.drv': 4 dependencies couldn't be built
error: build of '/nix/store/9mzxjjdyzwsxxq3sdh47vc111b2n889d-python2.7-distributed-1.22.1.drv', '/nix/store/cdg226yxavzz9zyp9j7d5533p41rby9s-python3.6-distributed-1.22.1.drv' failed

I have made all of the requested changes.
The one change I have not made is

Do you know if there's a way to set the timeout to infinity?

This is because I am just copying the tests that were run on travis ci.
Otherwise all done and thanks for the help!

(triage) From what I understand, this is waiting for:

Removal of the lines pointed to by https://github.com/NixOS/nixpkgs/pull/44657/files#r208727864
At least setting timeout to 0 as per https://github.com/NixOS/nixpkgs/pull/44657/files#r208964330

@costrouc, it's your move :+1: Thank you for contributing!

@Ekleog I have made the additional changes thanks for pointing them out. I have tested that with the changes all packages build with --option sandbox true.

Should be ready for merge now with all the requested changes made.

@ryantm ready for merge. Thanks for the reminder!

@ryantm I will never use the github merge editor for a quick fix. Thats why the builds failed. I have fixed the issue and tested that the builds succeed now for both joblib and distributed.

@GrahamcOfBorg build python2.pkgs.distributed python3.pkgs.distributed python2.pkgs.joblib python3.pkgs.joblib

Failure on x86_64-darwin (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed, python2.pkgs.joblib, python3.pkgs.joblib
Partial log (click to expand)
3.04s call     distributed/deploy/tests/test_adaptive.py::test_worker_keys
3.00s call     distributed/deploy/tests/test_local.py::test_silent_startup
2.98s call     distributed/tests/test_client_executor.py::test_cancellation
2.63s call     distributed/tests/test_profile.py::test_basic
2.51s call     distributed/tests/test_failed_workers.py::test_restart_sync_no_center
2.37s call     distributed/tests/test_failed_workers.py::test_restart_sync
2.36s call     distributed/diagnostics/tests/test_progress.py::test_AllProgress
== 1 failed, 1051 passed, 114 skipped, 5 xfailed, 4 xpassed in 434.46 seconds ==
builder for '/nix/store/84m9s23yl37v3kwl8xzcks03x74sc6ix-python3.6-distributed-1.22.1.drv' failed with exit code 1
error: build of '/nix/store/84m9s23yl37v3kwl8xzcks03x74sc6ix-python3.6-distributed-1.22.1.drv', '/nix/store/fmmqhlivdvpqzif035d70awqqilqnfm1-python2.7-distributed-1.22.1.drv', '/nix/store/iwxnw0vy2g76f9h1qrvkfcyrwpsh60mf-python2.7-joblib-0.12.4.drv' failed

Failure on x86_64-linux (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed, python2.pkgs.joblib, python3.pkgs.joblib
Partial log (click to expand)
distributed/tests/test_as_completed.py ..........                        [ 21%]
distributed/tests/test_asyncio.py ................s..                    [ 22%]
distributed/tests/test_asyncprocess.py ..........                        [ 23%]
distributed/tests/test_batched.py .......s.s..                           [ 24%]
distributed/tests/test_client.py .......................s.........ss.... [ 28%]
........................sss........X.ss....s.....s.......s.............. [ 34%]
................ssss.............................................s...... [ 40%]
............................/nix/store/i6vl5lwlz5jbkg4r6p340dwmj6fha3xq-stdenv-linux/setup: line 1290:  3123 Aborted                 py.test distributed -m "not avoid-travis" -r s --timeout-method=thread --timeout=0 --durations=20 --ignore="distributed/cli/tests"
builder for '/nix/store/h486hzbaqscqa8acbm0qaryjknlf073d-python3.6-distributed-1.22.1.drv' failed with exit code 134
error: build of '/nix/store/h486hzbaqscqa8acbm0qaryjknlf073d-python3.6-distributed-1.22.1.drv' failed

Timed out, unknown build status on aarch64-linux (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed, python2.pkgs.joblib, python3.pkgs.joblib
Partial log (click to expand)
../../nix/store/8j80sfr6rmn7yd161v1f0f1zqm28b1g6-python3.6-pandas-0.23.4/lib/python3.6/site-packages/pandas/tests/test_strings.py . [  4%]
building of '/nix/store/b5j1ydbjjxkn2nvnxsyc4rsllrzlbkm5-python2.7-pandas-0.23.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/ygqffarb34clqzghzfilrzjniv6viw95-python2.7-partd-0.3.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6vr0l3c25khg7s4wj5lwpm4n2jan7sxc-python2.7-dask-0.18.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/kf7c7bsaxzckjf14m7k57h86vfi0flgl-python2.7-distributed-1.22.1.drv': 2 dependencies couldn't be built
building of '/nix/store/qa3qf1ckgx2aiq3ngqm1ir2dqqf3wzp1-python3.6-pandas-0.23.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/qjrb7bqk05ylddl5kz7qzalhl5jmlz3y-python3.6-partd-0.3.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/niacdp5h3hpc0zclqcz7mcqj8wlmamls-python3.6-dask-0.18.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9gaq1bb2x16nfrpfc37lc3542zr1kca7-python3.6-distributed-1.22.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/9gaq1bb2x16nfrpfc37lc3542zr1kca7-python3.6-distributed-1.22.1.drv', '/nix/store/9w6xk081d3r5cs8gkchn4gc56f94nfga-python3.6-joblib-0.12.4.drv', '/nix/store/gws5ach6mbyyjkh44pqssssrf8wfwsd4-python2.7-joblib-0.12.4.drv', '/nix/store/kf7c7bsaxzckjf14m7k57h86vfi0flgl-python2.7-distributed-1.22.1.drv' failed

I have been trying to reproduce the failed tests and everytime I ignore a test another magically seems to fail. I think that turning off the tests is fine. There are 800 tests and only 1 or 2 seem to fail each time. @ryantm is this acceptable? I am sorry that this has taken so long.

@costrouc There are a lot of python packages with the tests disabled. Obviously it is preferred to have them enabled, but if they can't be made reliable, it is better to not have them. Hopefully the package maintainer runs their own tests as part of the release process.

Fixed. I set doCheck = false for pythonPackages.distributed

@GrahamcOfBorg build python2.pkgs.distributed python3.pkgs.distributed python2.pkgs.joblib python3.pkgs.joblib

Success on x86_64-linux (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed, python2.pkgs.joblib, python3.pkgs.joblib
Partial log (click to expand)
[DEBUG:MainProcess:QueueManagerThread] closing call_queue
[DEBUG:MainProcess:QueueManagerThread] telling queue thread to quit
[DEBUG:MainProcess:QueueManagerThread] joining processes
[DEBUG:MainProcess:QueueFeederThread] feeder thread got sentinel -- exiting
[DEBUG:MainProcess:QueueManagerThread] queue management thread clean shutdown of worker processes: []
[DEBUG:MainProcess:MainThread] running the remaining "atexit" finalizers
/nix/store/2q33qrmnphzc7hr4pdams7cb8z6sbqm7-python2.7-distributed-1.22.1
/nix/store/93ipmi0zapd8ckfxrrgrqsld7jdbl62i-python3.6-distributed-1.22.1
/nix/store/24i4w686088i6k6pmxkrd2k8cnfgiil9-python2.7-joblib-0.12.4
/nix/store/13ldlwmd3qj4ihhkn0cp2g0agb1klxkc-python3.6-joblib-0.12.4

Woo! 🎉

Failure on x86_64-darwin (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed, python2.pkgs.joblib, python3.pkgs.joblib
Partial log (click to expand)
[DEBUG:MainProcess:Dummy-677] Interpreter shutting down. Waking up queue_manager_threads [(<Thread(QueueManagerThread, started daemon<PHONE_NUMBER>90368)>, <joblib.externals.loky.process_executor._ThreadWakeup instance at 0x10b84c4d0>)]
[DEBUG:MainProcess:QueueManagerThread] queue management thread shutting down
[DEBUG:MainProcess:QueueManagerThread] closing call_queue
[DEBUG:MainProcess:QueueManagerThread] telling queue thread to quit
[DEBUG:MainProcess:QueueManagerThread] joining processes
[DEBUG:MainProcess:QueueFeederThread] feeder thread got sentinel -- exiting
[DEBUG:MainProcess:QueueManagerThread] queue management thread clean shutdown of worker processes: []
[DEBUG:MainProcess:Dummy-677] running the remaining "atexit" finalizers
builder for '/nix/store/iwxnw0vy2g76f9h1qrvkfcyrwpsh60mf-python2.7-joblib-0.12.4.drv' failed with exit code 1
error: build of '/nix/store/iwxnw0vy2g76f9h1qrvkfcyrwpsh60mf-python2.7-joblib-0.12.4.drv' failed

Timed out, unknown build status on aarch64-linux (full log)
Attempted: python2.pkgs.distributed, python3.pkgs.distributed, python2.pkgs.joblib, python3.pkgs.joblib
Partial log (click to expand)
building of '/nix/store/9w6xk081d3r5cs8gkchn4gc56f94nfga-python3.6-joblib-0.12.4.drv' timed out after 3600 seconds
building of '/nix/store/b5j1ydbjjxkn2nvnxsyc4rsllrzlbkm5-python2.7-pandas-0.23.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/ygqffarb34clqzghzfilrzjniv6viw95-python2.7-partd-0.3.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6vr0l3c25khg7s4wj5lwpm4n2jan7sxc-python2.7-dask-0.18.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bfc1k8ncmfqij286lkm75zi63vv4zdyw-python2.7-distributed-1.22.1.drv': 1 dependencies couldn't be built
building of '/nix/store/qa3qf1ckgx2aiq3ngqm1ir2dqqf3wzp1-python3.6-pandas-0.23.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/qjrb7bqk05ylddl5kz7qzalhl5jmlz3y-python3.6-partd-0.3.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/niacdp5h3hpc0zclqcz7mcqj8wlmamls-python3.6-dask-0.18.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/fv7f8y18rhl0zcy0zqmacbrv5aawmb0a-python3.6-distributed-1.22.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9w6xk081d3r5cs8gkchn4gc56f94nfga-python3.6-joblib-0.12.4.drv', '/nix/store/bfc1k8ncmfqij286lkm75zi63vv4zdyw-python2.7-distributed-1.22.1.drv', '/nix/store/fv7f8y18rhl0zcy0zqmacbrv5aawmb0a-python3.6-distributed-1.22.1.drv', '/nix/store/gws5ach6mbyyjkh44pqssssrf8wfwsd4-python2.7-joblib-0.12.4.drv' failed

@costrouc It looks like the tests of joblib are failing on darwin :(


Going forward on the integration with DBS

Describe the bug
This is not exactly a bug, more of a report of missing information on how to integrate everything.
While using this branch of the DBS (in which I added this project as a git submodule, and added a docker-compose file listing it + the appropriate MariaDB container config), when trying to use the getQuote/ endpoint with that JSON data input:
{
          "type": "filecoin",
          "files": [
            {"length":2343545},
            {"length":2343545}
          ],
          "duration":<PHONE_NUMBER>,
          "payment": {
              "chainId": 80001,
              "tokenAddress": "0x9aa7fEc87CA69695Dd1f879567CcF49F3ba417E2"
          },
          "userAddress": "0x6aa0ee41fa9cf65f90c06e5db8fa2834399b59b37974b21f2e405955630d472a"
}

I am getting this response:
{"error":{"message":"ValidationError: Invalid address. \'payment\\" must be of type object. \\"files[0]\\" must be of type object. \\"files[1]\\" must be of type object"}}' <Response [406]>

So a few questions:

How to get a valid Address ? At least something I could use as demonstration/validation material. Same for the actual user wallet.
In the json input, it looks to me that the payment and files are of type object. What am I missing ?

Thanks in advance for helping going forward on this integration :-)
To Reproduce
Steps to reproduce the behavior:

Go to the DBS repo
Clone the project
Checkout the feature/docker-compose branch
Navigate to the root of the project
Rename the .env.example file into .env
Execute docker-compose build
Execute docker-compose up
Navigate to http://localhost:8000/docs/
First trigger the POST on /register/ example query with filecoin as default example
Then execute the POST on /getQuote/ example query
You should get the error.

Expected behavior
I should get a valid response with 200 status code or 201 and a quoteID.
Screenshots
If applicable, add screenshots to help explain your problem.

Thanks for the feedback. The repo you referenced in your walkthrough wasn't this repo. However, from the payload you shared, the userAddress appears to be a private key and not a valid Ethereum address

Thanks for the feedback. The repo you referenced in your walkthrough wasn't this repo

Yes, it is the actual DBS, which will reference this one and mount it using the proper Dockerfile.

However, from the payload you shared, the userAddress appears to be a private key and not a valid Ethereum address

Your comment here is valid, digging into the arweave integration I know that my user address was not ok. Though the comment regarding the payment object structure is still valid.

Works now, closing.


Build error on FancyZones.cpp

Error	C2228	left of '.showZonesOnAllMonitors' must have class/struct/union	FancyZonesLib
C:\Users\crutkas\Source\Repos\PtMain\src\modules\fancyzones\lib\FancyZones.cpp	886
I'm on:
ID	Author	Date	Message
8c17d825d958cf3d733df5c4c5da1c3ac10a94eb	Clint Rutkas<EMAIL_ADDRESS>3/13/2020 3:48:24 PM +00:00	moving the license.rtf file out of the root dir.  compiled both msix and msi and both worked. (#1565)

Opening the PR with the fix shortly.

As for the cause of the break, these commits were building successfully in the isolation in their own PRs and didn't cause any merge conflicts, but when merged they still caused the build errors due to both touching the same class.

https://github.com/microsoft/PowerToys/commit/0af6348913ebcb38dc775d298800e4a8e6dfaf3c
https://github.com/microsoft/PowerToys/commit/0ac6c01d65df2322754f43adda979a3454658666

I wonder if we can set up the CI in a way that it cherry-picks PR commits against the actual master to prevent build breaks in the future.

The CI system would have blocked the PR from being merged due breaking the build.

@crutkas yes, that's exactly what I'd want for it to do automatically.


Got error on Proposal#is_valid, marking invalid:

Hi,
On one of testnet masternodes i've got following error from Sentinel:
"Got error on Proposal#is_valid, marking invalid:"
As You see there is no error message.
Only on this mn this message keeps repeating.
Here is debug:
2017-01-22 10:12:09 Voting valid! Proposal: 705
2017-01-22 10:12:09 Found a vote for this gobject/signal...
2017-01-22 10:12:09 Already voted for this same gobject/signal/outcome, no need to re-vote.
2017-01-22 10:12:09 In Proposal#is_valid, for Proposal: {'_data': {'payment_address': u'93Lwsxp7h86mPTkk8vnHdDPbaQMhkH741W', 'name': u'\u0342\u033e\u01b0\u012a\u02c5f\u0363\u03d9\u03b3\u0330
\u030c\u022f\u03a0\x9c\u01df\xffq\xe2\u0260\u035c\u0199\u02ff\u0178\u02b6\u0223~\xca\u02fc\u0123\u0358\u0379\u0248\u01f5\u0298z\u0202\u022a\u0363\u02e7\u035d\u0217\u02d2\u038f\x881\u0236\u01a3^\xc3\u0176\u0132\xe9\u0
3a2~\x9c\u0136\n\u0156\u0176\u02db\u0327\u0307\u0109\u01c33\u020e\u02fa\xc8\u02f8\u0202\u02eeY\x82\u03c2\u0372\u01b3\u03c1\u0168\xc3\x7f\u01f6\u011c\u01ca\u03dc\u03e4\u0377\u0187\u027c', 'url': u'http://bit.ly/1e1EYJ
v', 'start_epoch':<PHONE_NUMBER>, 'governance_object': 864, 'end_epoch':<PHONE_NUMBER>, 'payment_amount': Decimal('-40'), 'object_hash': u'fcbaff08b319a613dccbcebac4626d966f2900fb9c5cae5e92bbf70ef7ab053b', 'id': 706}, '_ob
j_cache': {}, '_dirty': set([])}
Got error on Proposal#is_valid, marking invalid:
2017-01-22 10:12:09 Voting INVALID! Proposal: 706

Thanks for reporting. This debug output isn't an error with Sentinel per-se, but the Proposal validation failed (as intended) because Sentinel wasn't able to parse the proposal name, which looks to be binary/gibberish.

Working as designed


set workers based on recommended number of cores

Update:
To avoid the Namespace already exists, I turned off the recreate_views flag which prevents Beanie from attempting to recreate views if they already exist. This seems to work.

I moved all the synchronous operations into a thread pool using the run_in_threadpool method.

This approach allows the synchronous tasks to be executed in a separate thread, preventing them from blocking the main asynchronous event loop.
You can read more about this approach here.

More importantly, I realized we were not utilizing the maximum number of workers.

Uvicorn has built-in process management capabilities that can leverage multiple processes for better concurrency. You can read more about using workers here.
To set the number of workers, you can use the --workers {num_of_workers} option in Uvicorn.
Based on this recommendation, I configured 17 workers.

Expected behavior:

When downloading a large dataset, you can immediately navigate away from the page and still request other endpoints.
The backend will take some time to prepare the ZIP file.
Once the ZIP is ready and the streaming begins, the download will start automatically, regardless of which page you are on.
The browser will handle the download process

Created #1189 to fix the work around.


Add file path and location support, update swift to 5.7

💬 Summary of Changes

Add files path and location support for failure tests (partially address https://github.com/buildkite/test-collector-swift/issues/8)

Update Swift version to 5.7

Bump up package versions to 0.4.1

🧾 Checklist

[x] 🧐 Performed a self-review of the changes
[x] ✅ Added tests to cover changes
[x] 🏎 Ran Unit Tests and they all passed
[ ] 🏷 Labeled this PR appropriately

📝 Items of Note

The BK runner pipeline hasn't been set up properly yet so failing now


[HO] Week of April 19

[ ] Fill-out architecture document with content from deconfounder work

Deliverable: pushed edited architecture document to new branch
Estimate:
Actual:

[ ] Read and synthesize useful information from the discussion on deconfounder paper

Deliverable: Summary markdown pushed to new branch
Estimate:
Actual:

[x] Try to figure out a set of conditions under which the deconfounder works -- start with using their simulation example

Deliverable: New partial notebook reproducing Blei's results
Estimate:
Actual:

[x] More work on presentation

Deliverable: Updated presentation
Estimate:
Actual:

[ ] More refactoring work

Deliverable: Updated notebooks with assertions at the bottom of the notebook and rewritten functions
Estimate:
Actual:

[x] Weekly Meeting

Estimate: 2hrs
Actual: 1hr

@hassanobeid1994 just a gentle ping/reminder to update your task list and push commits with your work before our meeting tomorrow!

Closing this due to inactivity.


fix: sign typed data using inAppWalelt with salt in domain

PR-Codex overview
This PR focuses on fixing sign typed data in inAppWallet for domains with a salt param.
Detailed summary

Fixed sign typed data for domains with a salt param in in-app-account.ts
Updated chainId retrieval using TypedDataDefinition["domain"]
Refactored domain assignment for signTypedDataV4 params

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

/release-pr

/release-pr


Unable to access private Docker registry

I am running MicroK8s 1.14. I have used EKS and tried to deploy the same configuration to my MicroK8s without any luck.  We are using an official private Docker registry and required some configuration on EKS to allow authentication. I tried running the same command on my MicroK8s but getting authorization failed.
kubectl create secret docker-registry regcred --docker-server=https://index.docker.io/v1/ --docker-username=<dockeruser> --docker-password=<dockerpass> --docker-email=<dockeremail>

This creates the configuration which can be verified with kubectl get secret regcred --output=yaml. Looks good and the base64 encoded configuration matches my EKS configuration. When trying to deploy my pods, I am getting the following error on the deployment:
  Normal   Scheduled  13m                   default-scheduler  Successfully assigned default/buffet-parser-6c4fc4d5c6-flsht to kraken
  Normal   Pulling    12m (x4 over 13m)     kubelet, kraken    Pulling image "appdev/buffet-parser:latest"
  Warning  Failed     12m (x4 over 13m)     kubelet, kraken    Failed to pull image "appdev/buffet-parser:latest": rpc error: code = Unknown desc = failed to resolve image "docker.io/appdev/buffet-parser:latest": no available registry endpoint: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
  Warning  Failed     12m (x4 over 13m)     kubelet, kraken    Error: ErrImagePull
  Warning  Failed     11m (x6 over 13m)     kubelet, kraken    Error: ImagePullBackOff
  Normal   BackOff    3m41s (x43 over 13m)  kubelet, kraken    Back-off pulling image "appdev/buffet-parser:latest"

Hi @feered
I do not know what exactly might be wrong, but here are some links to resources related to the subject:

MicroK8s accessing ECR https://discuss.kubernetes.io/t/microk8s-ec2-and-ecr/6476
Configuring microk8s' /var/snap/microk8s/current/args/containerd-template.toml https://github.com/containerd/cri/blob/master/docs/registry.md
General guidelines on how to use registries https://microk8s.io/docs/working

Hope this helps. Really interested to see what the issue might be. I would like to beef up the guidelines with concrete examples on accessing private secure registries.

I've seen your second and third link which are related to my issue. I have attempted to create the necessary configuration based on the second link and am still unable to access the Docker repository. My images are hosted on hub.docker.com which seems to be the default registry for MicroK8s. I would assume all I would need to do is provide my own auth config as demonstrated in the second link.
So I am a bit confused. Kubernetes recommends configuring authentication via the kubectl create secret docker-registry command but is apparently ignored by MicroK8s. Was this intentional or a limitation of Kubernetes when building MicroK8s?

I just tested this and it worked. Here is what I did.

On dockerhub you are given one private repository so I created one
On MicroK8s (I am on 1.15 now) I created a secret like this:

kubectl create secret docker-registry regcred --docker-username=[myusername] --docker-password=[mypassword]<EMAIL_ADDRESS>--docker-server=https://index.docker.io/v1/

Build the image of the following Dockerfile:

> cat ./Dockerfile
FROM nginx:alpine

Build tag and push the image to the repository I named private:

docker build .
docker tag bfba26ca350c [myusername]/private:alpine
docker push [myusername]/private:alipne

Use the image in the following yaml:

> cat ./private-repo.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: [myusername]/private:alipne
        ports:
        - containerPort: 80
      imagePullSecrets:
      - name: regcred

(sorry for the misleading nginx references, I was just reusing an old manifest)
What am I doing differently? Please provide all the steps i need to take to reproduce this issue.

Thank you for taking the time to troubleshoot this with me. I am using kompose to orchestrate the deployment of my pods with a docker-compose.yml script. The docker-compose.yml has labels kompose.image-pull-secret: regcred that are translated into service labels in Kubernetes.
I have updated my version of Kompose and now it seems to be working. I apologize and thank you for taking the time to step through this with me. This is definitely a user error.
Cheers.


update and prettify README.md

I know you guys took all that time to write the docs, however the readme is the first thing a potential pallets follower and user will see. I did not edit any pre existing content, just added a badge and some installation / usage examples.

Could you also include the README in setup.py using the long_description kwarg? This would make its content be displayed on its PyPI project page.
Note that traditionally, this would require the README to be in reStructuredText (i.e. rename it to README.rst and change the formatting - mostly the links and headings - slightly). I read, I think in the Python weekly newsletter a few weeks ago that it's now possible to tell PyPI the content type (or so), i.e. use MarkDown and specify that explicitly in setup.py.

Agreed. Thanks for commenting. You might actually get this request some attention.

Thanks. Going forward, please use reStructuredText, not Markdown.

README still not included in setup.py :unamused:

I will update all the metadata to match the Flask repo before the next release.


Add TripsLayer example

Background
v7.0 audit

Change List

add embeded trip layer demo
add layer browser example

Coverage remained the same at 61.849% when pulling d69d8d712c4a3738921c820db60ceb4ec1c85777 on xx/trips-demo into 6044706e2637890c80c7cbdb05cc95f52046a636 on master.


[html] script end tag is not correctly indented

Testing #16526
<!doctype html>

Lines 7 and 12 should be indented. Lines 3 9 and 14 are empty lines the formatter creates.

Lines 3 9 and 14 are empty lines the formatter creates.
This controlled by the setting "html.format.extraLiners" which has default "head, body, /html"

I'd like to point out to lines 7 and 12 too. They are outdented, when they should not be. :(

Oh, sorry, I didn't intend to close it.

@aeschli it seems line 7 not is correct as the commit fixed indentation of script end tag. But line 12 is still not correctly indented.

I took this bug for the indent issue of the closing script tag. Please file a separate issue for line 12.


How long will it be down for?

3 months ...

You having a laugh

yes

how long till he fixes it ?

about 3 months

Umm why so long?????

mrknow is m.i.a he got fbi on his back :(

damn that really sucks

possible no more

i Hope Not

i am surprised that they went after him , thats so stupid

all he needs to do for now is fix it back to the way it was for now where everything was working

i think they going to put him in Guantanamo Bay detention camp

there not going to put him there

they have no internet no free wifi

he should have it fixed soon

have you notice he hasn't been on the internet lately

@xxcriticxx beta is out for Specto

Is it working

@joshwaa123 the beta works

Wooooo

you know how to install zips ?

Is it a different zip file to what it was before

@joshwaa123  https://github.com/mrknow/filmkodi/issues/159

@joshwaa123 installed it ?

https://github.com/mrknow/filmkodi/issues/166

Can I get this on my android box

@joshwaa123 what android box do you have ?

MCQ

MXQ

can you Transfer zips to your box ?

I've never done it before

doesn't the MXQ box have a micro SD card you can add in it ?

join to the chat easier to talk - http://chatwing.com/Karnage11#


wave-folder final output level is a bit low

Increase the gain in the final output amplifier of the wave-folder.

Raised final output level by changing R21 to 82k (from 56k)


How to handle redirect

Dear sir,
per title, how to handle url redirect and where can do the operation?
Thanks.

Hello @836608061,
this client does not support HTTP redirect.
Not even the chrome websocket does support this. Why do you need such a feature?
Greetings
marci4

Any update?

I realize this question is closed (for a while now), but I just ran into the same problem.
Our entire environment, including the ws server, is hosted in OpenShift. There is some magic redirection based on the URI path.
I am using just the ExampleClient from your examples. When I try to connect to our server, the initial handshake fails with:

Close connection, by: us, reason: Invalid status code received: 302 Status line: HTTP/1.1 302 Found, code: 1002

Anything I can do about this?


Document which permissions are required

We're currently suggesting people should give admin access to their IAM accounts in the README, this is probably not a very secure thing to suggest.
We should figure out which exact permissions the plugin needs and document them, preferably through a JSON policy.

I have an IAM policy with the exact permissions that I need, I'll get it later tonight. It might not cover all use cases though.

Should be a good starting point!

Could I get some feedback on this? I'll make it pretty later, and maybe include a sample policy in JSON format too.

Required permissions:
Basic permissions
s3:HeadBucket
s3:ListBucket (for the bucket)
s3:GetBucketLocation (for the bucket)
s3:GetObject (for all objects within the bucket)
If acl is configured as null (Recommended)
s3:PutObject (for all objects within the bucket)
If acl is not configured or is not null (Not recommended)
s3:PutObjectAcl (for all objects within the bucket)
If generateRoutingRules is true or not configured (Recommended)
s3:PutBucketWebsite (for the bucket)
If removeNonexistentObjects is true or not configured (Recommended)
s3:DeleteObject (for all objects within the bucket)
If you’re following the With CloudFront recipe and are doing automatic CloudFront invalidations (Optional)
cloudfront:CreateInvalidation
cloudfront:GetInvalidation (optional)
If you are using gatsby-plugin-s3 to automatically create the bucket for you
s3:CreateBucket

This worked for my first deploy.  On subsequent deploys the upload succeeded, but S3 threw up a 403 when I tried to load the site in a browser.  Updating all files to be public allowed the site to load correctly again.  Removing acl: null and adding the s3:PutObjectAcl permission also resolved it.

With acl: null, you need to add a bucket policy to allow public access. Please see this example. This is recommended, because ACLs are considered legacy by Amazon. "As a general rule, AWS recommends using S3 bucket policies or IAM policies for access control. S3 ACLs is a legacy access control mechanism that predates IAM."
Source

Yup, that worked for me.  Thanks!

This looks good!
@JoshuaWalsh Let's make a default sample policy and in the recipe guides, recommend people to add the additional perms to their policies.

I have applied all these permissions on a new bucket, with acl: null and still am having issues getting past here:
- Retrieving bucket info...
✖ Failed.
  AccessDenied: Access Denied

I use a dedicated user for CI, and attached this policy to the user, and have the bucket policy for public access.  I was able to deploy the first time, but not after that and I manually created the bucket.  Do we have a concise set of steps and settings needed to get this working all the way on the first shot?  I'm ok with giving this free reign on that particular bucket, the content is reproducible after all.
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "s3:PutAccountPublicAccessBlock",
                "s3:GetAccountPublicAccessBlock",
                "s3:ListAllMyBuckets",
                "s3:HeadBucket"
            ],
            "Resource": "*"
        },
        {
            "Effect": "Allow",
            "Action": "s3:*",
            "Resource": [
                "arn:aws:s3:::mysite.com/*",
                "arn:aws:s3:::staging.mysite.com/*",
                "arn:aws:s3:::mysite.com",
                "arn:aws:s3:::staging.mysite.com"
            ]
        }
    ]
}

As a suggestion, it might be nice to better print debug info for non-advanced users as I had to look through the source to find what action Retrieving bucket info... was trying to take, and then look up in the docs to find what that IAM policy might look like.  Seems like we could print those details in the log output upon failure, perhaps?
I'm very thankful for this package, as it really helps solve one of the most boring, and boilerplate tasks for a S3 static site.  I'm so close!

@chris-erickson I just got this setup for me and was running into similar issues. This is the IAM policy I created:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "AccessToGetBucketLocation",
            "Effect": "Allow",
            "Action": [
                "s3:GetBucketLocation",
                "s3:CreateBucket" <- if you want this plugin to create the bucket if it doesn't exist
            ],
            "Resource": [
                "arn:aws:s3:::*"
            ]
        },
        {
            "Sid": "AccessToWebsiteBuckets",
            "Effect": "Allow",
            "Action": [
		"s3:PutBucketWebsite",
                "s3:PutObject",
                "s3:PutObjectAcl", <- if you don't want to set acl: null
                "s3:GetObject",
                "s3:ListBucket",
                "s3:DeleteObject"
            ],
            "Resource": [
                "arn:aws:s3:::your-bucket.com",
                "arn:aws:s3:::your-bucket.com/*",
                "arn:aws:s3:::staging.your-bucket.com",
                "arn:aws:s3:::staging.your-bucket.com/*"
            ]
        },
        {
            "Sid": "AccessToCloudfront", <- if you want to invalidate a cloudfront distribution cache
            "Effect": "Allow",
            "Action": [
                "cloudfront:GetInvalidation",
                "cloudfront:CreateInvalidation"
            ],
            "Resource": "*"
        }
    ]
}

Thanks, somehow GetBucketLocation got lost, but I still am having the same error.  For me I:

Am using acl: null (because I might as well?)
Not letting it create the bucket
Not using CloudFront

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "s3:GetBucketLocation"
            ],
            "Resource": "arn:aws:s3:::*"
        },
        {
            "Effect": "Allow",
            "Action": [
                "s3:PutBucketWebsite",
                "s3:PutObject",
                "s3:GetObject",
                "s3:ListBucket",
                "s3:DeleteObject"
            ],
            "Resource": [
                "arn:aws:s3:::mysite.com/*",
                "arn:aws:s3:::staging.mysite.com/*",
                "arn:aws:s3:::mysite.com",
                "arn:aws:s3:::staging.mysite.com"
            ]
        }
    ]
}

This policy is attached to the CI user which has access key/id added.  🤷♂

Hi @chris-erickson ,
My IAM policy also includes HeadBucket (not sure if this is necessary) and PutObjectAcl (which theoretically shouldn't be necessary with acl: null, but maybe this isn't working as expected). Could you please try adding these and seeing if it works correctly?

@JoshuaWalsh the s3:ListBucket permission includes access for the HEAD Bucket operation in addition to the GET Bucket operation, you can see here: https://docs.aws.amazon.com/AmazonS3/latest/dev/using-with-s3-actions.html#using-with-s3-actions-related-to-buckets.
And in my IAM policy, I left out the PutObjectAcl permission since I'm setting acl: null and it's working fine.
@chris-erickson for my configuration, I was also able to set all the "Manage public access control lists (ACLs)" and "Manage public bucket policies" options to true and it's working for me.
If you're still having issues, what I did to see where I was failing was to install the aws-sdk npm package, set my AWS access/secret tokens as env vars (which the sdk sees) and open up a node shell, then try running each of the s3 commands in bin.ts to see which ones failed. For me, it was the s3.getBucketLocation command, because I didn't have that permission before.

It should show the stacktrace by default, but the AWS SDK is probably throwing some weird non default error object without a stacktrace.

This is perfectly working, but does not make the Cloudfront invalidation.
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "VisualEditor0",
            "Effect": "Allow",
            "Action": [
                "s3:PutObject",
                "s3:ListBucket",
                "s3:DeleteObject",
                "s3:GetBucketLocation",
                "s3:PutBucketWebsite"
            ],
            "Resource": [
                "arn:aws:s3:::credijusto.info",
                "arn:aws:s3:::credijusto.info/*"
            ]
        }
    ]
}

Something I just discovered: If you're allowing gatsby-plugin-s3 to create the bucket for you, you may also need PutBucketAcl. I imagine this isn't necessary if you've set acl: null in your config, but I haven't tested that yet.

For frustrated developers arriving here from google...
One cause of the error:

- Retrieving bucket info...

✖ Failed.

  AccessDenied: Access Denied

Is a non-unique S3 bucket name. The plugin will attempt to get info on the bucket name you specified before doing its other work. If you don't own that bucket (since someone else already has the name you picked) it will quite rightly fail with a 403 and give you an error message that is about as much use as a chocolate tea pot.

still facing:
✖ Failed.
  AccessDenied: Access Denied

after a gatsby-plugin-s3 deploy

bump on adding this to the README