update libass or add harfbuzz !!

hi,
i  used right to left language [ arabic ], and libass doesn't support all the character for all language rtl,
i tried to add harfbuzz and compile it but i get error in build,
for now i used SubtitlesOctopus in other language but for arabic [rtl] language libass doesn't .
harfbuzz is a best solution for this issue, and for all rtl languages,
if you would can make another version of SubtitlesOctopus with harfbuzz that would be highly great,
thanks

or at least update libass to last version
in libass 0.13.3 they make a good update for rtl language ,
look at this issue https://github.com/libass/libass/issues/224
so all i need is just update to libass, to solve rtl issues.
thanks.

i get error in compile
~/emsdk-portable/JavascriptSubtitlesOctopus# make
cd build/fribidi &&
git reset --hard &&
patch -p1 < ../fribidi-make.patch &&
touch configure.ac aclocal.m4 configure Makefile.am Makefile.in &&
aclocal && autoconf && autoheader && automake --add-missing &&
emconfigure ./configure
CFLAGS=-O3
NM=llvm-nm
--prefix="$(pwd)/dist"
--disable-dependency-tracking
--disable-debug
--without-glib
&&
emmake make -j8 &&
emmake make install
HEAD is now at 1a6935c 0.19.7
patching file Makefile.am
patching file gen.tab/Makefile.am
lib/Headers.mk:22: warning: shell cat $(top_srcdir: non-POSIX variable name
lib/Headers.mk:22: (probably a GNU make extension)
doc/Makefile.am:26:   'lib/Headers.mk' included from here
lib/Headers.mk:22: warning: shell cat $(top_srcdir: non-POSIX variable name
lib/Headers.mk:22: (probably a GNU make extension)
lib/Makefile.am:28:   'lib/Headers.mk' included from here
test/Makefile.am:30: warning: '%'-style pattern rules are a GNU make extension
/bin/sh: 6: emconfigure: not found
Makefile:95: recipe for target 'build/fribidi/dist/lib/libfribidi.so' failed
make: *** [build/fribidi/dist/lib/libfribidi.so] Error 127
how do it correctly ?

Looks like you didn't installed EMSDK. If you installed it and still getting error then probably you didn't activated it using command like source ./emsdk_env.sh.
I'm planning to try out harfbuzz in future and compare speed to fribidi, but not sure when that future will be :)

i activated but i get error through compiling..
so in the last i edit the font fontcreator v11 and everything now ok..
but it need to edited every font i use!
for now  i will managed this issue through edit fonts and i will waiting new update
thanks..

checking for rand_r... yes
checking for readlink... yes
checking for fstatvfs... yes
checking for fstatfs... yes
checking for lstat... yes
checking for posix_fadvise in fcntl.h... fcntl.h
checking for struct statvfs.f_basetype... no
checking for struct statvfs.f_fstypename... no
checking for struct statfs.f_flags... yes
checking for struct statfs.f_fstypename... no
checking for struct dirent.d_type... yes
checking for FREETYPE... no
configure: error: Package requirements (freetype2) were not met:
No package 'freetype2' found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables FREETYPE_CFLAGS
and FREETYPE_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
Makefile:77: recipe for target 'build/fontconfig/dist/lib/libfontconfig.so' failed
make: *** [build/fontconfig/dist/lib/libfontconfig.so] Error 1
any idea ?

any idea ?
You could try to run make clean before running make (maybe you have cached paths). And if that doesn't helps, please send gist with full log.

I've updated libass to latest version. could you check it again?
But not sure that it'll help because the commit you liked before was already included in version of libass we had before.
Also, can you send a small .ass file to check the issue?

thanks for updating
i checked but the same problem :(
I am going to explain things.
first one in adobe arabic font
in libass without harfbuzz "ألّا يَجِب عليكَ الذهاب هذه المرّة؟"

and this in vsfilter is the same result in libass with harfbuzz

in libass without harfbuzz the character "ه" it's changed to "هـ"
and "ألّا" it's changed to "ألّـا" and that wrong
The character ﻻ is a combination of two letters, ل and ا . When these two letters come beside each other, they are replaced by the ﻻ character.
in vsfilter or libass with harfbuzz is appears no problems 100%
i tested https://github.com/dead/libass.js/ it's libass with harfbuzz but the problem this lib consume a lot of memory.
but JavascriptSubtitlesOctopus it's consume less memory .
another font Arabic Typesetting
libass

vsfilter

all the others fonts not like "adobe arabic" fonts! it's like "Arabic Typesetting" in libass
and it's make space between character if exist ّ َ ً ُ ٌ ِ ٍ
but in vsfilter or libass with harfbuzz there no problem at all
you see this comparison
https://imgur.com/a/p9wJB
this script+fonts
script+fonts.zip

Thanks for explanation and test files.
I'll try to build with harfbuzz when I'll have time. Looking at https://github.com/dead/libass.js/ that shouldn't be a problem.

for https://github.com/dead/libass.js/ there is no problem at all in the fonts..
but as i said before it's consume a huge memory ..
JavascriptSubtitlesOctopus in chrome or firefox around 230~260mb
libass.js consume 440~500mb! and thats too huge
and another things make me prefer JavascriptSubtitlesOctopus like fontselect.. etc..
it would be great if you make another branch build with harfbuzz ..
until then if you don't have a comment, you can close this issue..
thanks..

500MB (and 260MB too) for subtitles, modern world, heh 😄
I'm planning to use harfbuzz as main one (if there is no performance disadvantage).
I don't close issue as it's still not resolved and I'm planning to do so.

there is libjass and it's a good but it's didn't support all tags and some issues.
yes (JavascriptSubtitlesOctopus and libass.js) is too future but i think it's work like charm :100: ..

Yeah, I know about libjass. I worked a little bit with it before. In one of issues, Arnavion wrote thoughts about using asm.js and that's where idea of this project comes from.

yes, in fact i found out JavascriptSubtitlesOctopus through one of your comments in one of issues in libjass :laughing:

Great job with JavascriptSubtitlesOctopus 😄
Not sure why libass.js consumes more memory than JavascriptSubtitlesOctopus. It should be the same... The only diference is the harfbuzz. But maybe I'm leaking memory somewhere...
I was testing JavascriptSubtitlesOctopus with this test subtitle (railgun opening with krk fx) and it crashed. It is a super heavy subtitle that I use to benchmark.
I had the same problem when compiling with Web Assembly in libass.js and it can be fixed using -s "BINARYEN_TRAP_MODE='clamp'".
I also would like to suggest to use requestFrameAnimation instead setTimeout in JavascriptSubtitlesOctopus.

I was testing JavascriptSubtitlesOctopus with this test subtitle (railgun opening with krk fx) and it crashed. It is a super heavy subtitle that I use to benchmark.
I had the same problem when compiling with Web Assembly in libass.js and it can be fixed using -s "BINARYEN_TRAP_MODE='clamp'".

Thank you, I'll try it 😃

I also would like to suggest to use requestFrameAnimation instead setTimeout in JavascriptSubtitlesOctopus.

requestAnimationFrame already used when possible but it can't be used inside of web worker. With introduction of Webassembly I'm not sure if web worker still necessary (but it still can be necessary on mobile).

I would be interested in seeing the Railgun subs with different subtitle implementations. We use our own implementation at openings.moe, and that OP can be seen here.
(there's a known positioning issue with Chrome at the start. it works in Firefox.)

I fixed the issue @dead talked about.
Here is example with Railgun: https://dador.github.io/JavascriptSubtitlesOctopus/railgun_op.html (I've used subtitles that @dead sent before).


you can get to the submit button with tab

well, not anymore >:)

@sysengineer13 looks like one of your other commits overwrote this


Added cyclecloud example + snippets

OK, candidate example but having seen the plethora of earlier ARM examples and peeps reusing of code with dated API versions I wanted us to consider creating a library of well maintained snippets/components/.. whatever that can be rapidly assembled.
How many examples already create a vnet. Possibly with alder APIs and which do not includes tags or locks on the vnet? Mine certainly doesn't but the snippets could be fleshed out to show all properties and kept current. It would also make finding an example of how to deploy a particular resource much simpler and highlight gaps.
Thoughts?

Thanks for the contribution!

but having seen the plethora of earlier ARM examples and peeps reusing of code with dated API versions I wanted us to consider creating a library of well maintained snippets/components/.. whatever that can be rapidly assembled.

Totally agree with this. Now that we have modules we need to rethink how these foundational components can be built to be reused. Have you take a look at modules yet? It looks like you can consume the snippets you created as modules instead of duplicating the code. Thoughts?

I think there may be a place for both.
The advantage of the snippet approach is they can be simply discovered, cut and pasted to help create a Bicep file and by structuring them it makes finding snippets easier. However, this might be better done by the IDE in the manner VS (used to/still does?) let you pull in resource definitions when editing ARM templates. I also found using the API definitions useful when refining the snippets so maybe just better pointers to these sources would negate the benefits/need for them. Just having some intellisense in VSCode already starts to make this easier.
The modules approach is interesting but there is a distinction between an approach that individuals may adopt (for example I might pull out the networking pieces in my example to create an easily reused, by me, module) and attempting to build a library of reusable modules for others. As the permutations for modules and parameters grow they can become overly complex and there is no means to determine where a module may be being used and the impact of any changes to it. Great for building lab/demo environments but a lot of IaC is deployed and left unchanged for long periods and I would not want the code once used to create it morphing over that time, any changes should be very explicit.
I've updated the snippets but will probably look to replace this PR with one that has the single file CycleCloud example (more approachable) plus an example that demonstrates the use of modules.

Well I'm impressed with how easy modules are to work with. I was getting a false warning in VSCode: The type "outputs" does not contain property "vnetId".bicep(BCP052)
id: '${network.outputs.vnetId}/subnets/Default'

but it builds and deploys fine and revisiting the code to investigate the below error the warning is no longer occurring.
However, as can be seen by the test results something is still wrong as while it builds and deploys on my WSL:Ubuntu with Bicep CLI version 0.1.226-alpha (eb3d221626) the build tests produce a different output :( I'll have to add Bicep to my Windows environment and see what that gives me.
Hints welcome :)
The modules are quite seductive and it is going to be interesting exploring how they might be generalised

Hints welcome :)

@lr90 Things are moving rather fast as we're getting ready for the 0.2 release. So I think you've just got a bit unlucky as the main branch (which the tests run agains) keeps changing. You should be able to sort it out by:

git fetch - fetch the latest changes.
git merge --no-ff origin/main -  merge the latest from main into your branch.
dotnet test -- 'TestRunParameters.Parameter(name=\"SetBaseLine\", value=\"true\")' - run the test suite, and update all baseline files (note you need to change \" to \\\" in the command if you're running it on Windows powershell).
Commit and push the changes.
Ping one of us to merge this PR before another conflicting commit gets pushed to main 😄

Thanks. I might have to wait until 0.2 is released. Done the fetching and merging and everything is now up to date with the main branch but the testing is failing as I don't have the bicep-types-az files so am not able to generate updated json files for testing

Codecov Report

Merging #843 (9c72d83) into main (d374dc2) will increase coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
+ Coverage   94.69%   95.22%   +0.53%
==========================================
  Files         302      298       -4
  Lines       13605    13443     -162
  Branches       12        0      -12
==========================================
- Hits        12883    12801      -82
+ Misses        722      642      -80

Flag
Coverage Δ

dotnet
95.22% <ø> (-0.12%)
:arrow_down:

typescript
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cep.Core.UnitTests/FileSystem/FileResolverTests.cs
76.66% <0.00%> (-23.34%)
:arrow_down:

.../Bicep.Core.UnitTests/Assertions/BaselineHelper.cs
60.86% <0.00%> (-17.40%)
:arrow_down:

src/Bicep.Core/FileSystem/PathHelper.cs
96.15% <0.00%> (-3.85%)
:arrow_down:

src/Bicep.Core/Emit/ScopeHelper.cs
92.23% <0.00%> (-0.30%)
:arrow_down:

src/Bicep.Core/TypeSystem/DeclaredTypeManager.cs
89.23% <0.00%> (-0.09%)
:arrow_down:

...p.LangServer/Completions/BicepCompletionContext.cs
96.11% <0.00%> (-0.06%)
:arrow_down:

src/Bicep.Core/TypeSystem/TypeValidator.cs
91.28% <0.00%> (-0.04%)
:arrow_down:

src/Bicep.Core/Emit/ExpressionConverter.cs
95.65% <0.00%> (-0.02%)
:arrow_down:

src/Bicep.Core/Parser/Parser.cs
94.40% <0.00%> (-0.02%)
:arrow_down:

....LangServer/Completions/BicepCompletionProvider.cs
98.34% <0.00%> (-0.01%)
:arrow_down:

... and 6 more


Produce log output for flakey test

For the flakey test replaced the default logger with Xunit's ITestOutputHelper in order to see what's going wrong when the flakey test will eventually fail.

aspnet/AspNetCore-Internal#1337

Why not use LoggedTest infrastructure? Inherit from LoggedTest and use this.LoggerFactory
https://github.com/aspnet/AspNetCore/blob/010c1f0c9f22fba3f6a0e82461fa7553e9114b44/src/Servers/Kestrel/test/InMemory.FunctionalTests/DefaultHeaderTests.cs#L12-L17

+1 I second that, use LoggedTest is much better to use here. I plan on adding functionality like being able to take a dump based on a condition as well so you'll want that eventually.

Had no clue that existed. 👏 Will change.

🆙 📅


Episode appears in feed during youtube premiere and has incorrect duration

Episodes which are youtube premieres appear in the feed during the premiere and have very short duration (~6-9 minutes) and contains YouTube premiere countdown sound at the beginning.
Examples:

https://www.youtube.com/watch?v=Be3aFgnB4JM. Feed duration - 9:04. Youtube duration - 1:02:10
https://www.youtube.com/watch?v=z5vJdh9d3zI. Feed duration - 9:00. Youtube duration - 1:31:26

2022/11/06 08:39:08.558 [INFO]  new entry [1] Be3aFgnB4JM, ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск, Ксения Ларина, {ChannelID:UCmt9BtDz7nSiau3iLWgIGBQ, VideoID:Be3aFgnB4JM, Title:"ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск", Published:2022-11-05T15:07:05-05:00, Updated:2022-11-06T02:13:08-06:00, Author:Ксения Ларина, File:, Duration:0s}
2022/11/06 08:39:09.873 [INFO]  ERROR: [youtube] Be3aFgnB4JM: Premieres in 20 minutes
2022/11/06 08:39:09.930 [WARN]  failed to download Be3aFgnB4JM: failed to execute command: exit status 1
2022/11/06 08:54:08.478 [INFO]  new entry [1] Be3aFgnB4JM, ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск, Ксения Ларина, {ChannelID:UCmt9BtDz7nSiau3iLWgIGBQ, VideoID:Be3aFgnB4JM, Title:"ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск", Published:2022-11-05T15:07:05-05:00, Updated:2022-11-06T02:13:08-06:00, Author:Ксения Ларина, File:, Duration:0s}
2022/11/06 08:54:09.985 [INFO]  ERROR: [youtube] Be3aFgnB4JM: Premieres in 5 minutes
2022/11/06 08:54:10.047 [WARN]  failed to download Be3aFgnB4JM: failed to execute command: exit status 1
2022/11/06 09:09:08.488 [INFO]  new entry [1] Be3aFgnB4JM, ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск, Ксения Ларина, {ChannelID:UCmt9BtDz7nSiau3iLWgIGBQ, VideoID:Be3aFgnB4JM, Title:"ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск", Published:2022-11-06T09:00:07-06:00, Updated:2022-11-06T09:00:07-06:00, Author:Ксения Ларина, File:, Duration:0s}
2022/11/06 09:09:29.967 [INFO]  downloaded Be3aFgnB4JM (ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск) to var/yt/4d3fd6714844e875d1a3f424efa2e53d379fe7bd.mp3, size: 10929826, channel: {Name:Ксения Ларина ID:UCmt9BtDz7nSiau3iLWgIGBQ Type:channel Keep:0 Language:ru-ru Filter:{Include: Exclude:}}
2022/11/06 09:09:30.003 [INFO]  save<PHONE_NUMBER>-b00ea2394b07e1bb716ed6ef9398cf1d27a2550e - {ChannelID:UCmt9BtDz7nSiau3iLWgIGBQ, VideoID:Be3aFgnB4JM, Title:"ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск", Published:2022-11-06T09:09:29-06:00, Updated:2022-11-06T09:00:07-06:00, Author:Ксения Ларина, File:var/yt/4d3fd6714844e875d1a3f424efa2e53d379fe7bd.mp3, Duration:545s}
2022/11/06 09:09:30.005 [INFO]  set processed 4d3fd6714844e875d1a3f424efa2e53d379fe7bd - {ChannelID:UCmt9BtDz7nSiau3iLWgIGBQ, VideoID:Be3aFgnB4JM, Title:"ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск", Published:2022-11-06T09:09:29-06:00, Updated:2022-11-06T09:00:07-06:00, Author:Ксения Ларина, File:var/yt/4d3fd6714844e875d1a3f424efa2e53d379fe7bd.mp3, Duration:545s}
2022/11/06 09:09:30.006 [INFO]  saved Be3aFgnB4JM (ЖЕЛЕЗНЫЙ ЗАНАВЕС НАВСЕГДА? // Александр Генис и Ксения Ларина, @The Insider  04.11.22 20:00 мск) to var/yt/4d3fd6714844e875d1a3f424efa2e53d379fe7bd.mp3, channel: {Name:Ксения Ларина ID:UCmt9BtDz7nSiau3iLWgIGBQ Type:channel Keep:0 Language:ru-ru Filter:{Include: Exclude:}}

this part of logs shows what it does. As soon as yt api feed shows the new episode feed-master requests download via yt-dlp. Initiall attempts to download failed on yt-dlp level with "Premieres in 20 minutes", "Premieres in 5 minutes" and so on, but at some point yt-dlp accepts the request and downloads it. Looks like it downloads a partial file in this case.
I'm not sure if such behavior is a bug on  yt-dlp side, or maybe this is what it does by design. To me it looks like a bug. Another possibility - maybe yt-dlp has a flag to reject partial (live)  downloads, but I don't know if this the case and what the flag

if anyone can reproduce the issue with yt-dlp and figure how to avoid it, pls make a pr or at least describe the fix you found

I think  --match-filter "!is_live should do the trick. @algot -pls let me know if the issue fixed for you

apparently this is a little bit more complicated. The filter is working however it doesn't communicate back such a filtered entries as an error, and feed-master has no clue what happened. It detects such files as successfully downloaded but the actual file is absent.
I have altered the logic of youtube.feed.Downloader to check if file was actually dowloaded by yt-dlp and if not - this will be treated as any other temporary error and the next loop will try it again

@umputun no episodes from  Живой Гвоздь appears in the feed on the evening today
https://www.youtube.com/channel/UCWAIvx2yYLK_xTYD4F2mUNw/streams
e.g. this one https://www.youtube.com/watch?v=8jsveJkBvyk

yeah, figured this one some time ago and the fix already in place

according to my logs it works fine now, this is an example:
new entry reported by yt and detected at 11:46, however it was "live" and was not downloaded, to eliminate partial file
2022/11/09 11:46:00.252 [INFO]  new entry [7] jR8M18WdCuQ, Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022, Живой Гвоздь, {ChannelID:UCWAIvx2yYLK_xTYD4F2mUNw, VideoID:jR8M18WdCuQ, Title:"Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022", Published:2022-11-08T11:26:03-06:00, Updated:2022-11-09T01:56:01-06:00, Author:Живой Гвоздь, File:, Duration:0s}
2022/11/09 11:46:01.873 [INFO]  skipping {ChannelID:UCWAIvx2yYLK_xTYD4F2mUNw, VideoID:jR8M18WdCuQ, Title:"Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022", Published:2022-11-08T11:26:03-06:00, Updated:2022-11-09T01:56:01-06:00, Author:Живой Гвоздь, File:, Duration:0s}

the same thing was detected at 12:01 again, this time it didn't have "is_live" and was fully downloaded and publshed
2022/11/09 12:01:00.233 [INFO]  new entry [7] jR8M18WdCuQ, Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022, Живой Гвоздь, {ChannelID:UCWAIvx2yYLK_xTYD4F2mUNw, VideoID:jR8M18WdCuQ, Title:"Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022", Published:2022-11-08T11:26:03-06:00, Updated:2022-11-09T12:00:24-06:00, Author:Живой Гвоздь, File:, Duration:0s}
2022/11/09 12:02:18.249 [INFO]  downloaded jR8M18WdCuQ (Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022) to var/yt/169000bd06c8c129ecc5afe0ccf03cca4b8bea9a.mp3, size: 71665500, channel: {Name:Живой Гвоздь ID:UCWAIvx2yYLK_xTYD4F2mUNw Type: Keep:8 Language:ru-ru Filter:{Include: Exclude:}}
2022/11/09 12:02:18.474 [INFO]  save<PHONE_NUMBER>-b249486deea7d9baadccb2cf1520eeb10351a963 - {ChannelID:UCWAIvx2yYLK_xTYD4F2mUNw, VideoID:jR8M18WdCuQ, Title:"Живой Гвоздь: Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022", Published:2022-11-08T11:26:03-06:00, Updated:2022-11-09T12:00:24-06:00, Author:Живой Гвоздь, File:var/yt/169000bd06c8c129ecc5afe0ccf03cca4b8bea9a.mp3, Duration:3330s}
2022/11/09 12:02:18.477 [INFO]  set processed 169000bd06c8c129ecc5afe0ccf03cca4b8bea9a - {ChannelID:UCWAIvx2yYLK_xTYD4F2mUNw, VideoID:jR8M18WdCuQ, Title:"Живой Гвоздь: Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022", Published:2022-11-08T11:26:03-06:00, Updated:2022-11-09T12:00:24-06:00, Author:Живой Гвоздь, File:var/yt/169000bd06c8c129ecc5afe0ccf03cca4b8bea9a.mp3, Duration:3330s}
2022/11/09 12:02:18.478 [INFO]  saved jR8M18WdCuQ (Живой Гвоздь: Цена вопроса / Сергей Алексашенко и Лиза Аникина // 09.11.2022) to var/yt/169000bd06c8c129ecc5afe0ccf03cca4b8bea9a.mp3, channel: {Name:Живой Гвоздь ID:UCWAIvx2yYLK_xTYD4F2mUNw Type: Keep:8 Language:ru-ru Filter:{Include: Exclude:}}

feel free to close if the fix works as expected

Here we go again
This episode is reproduced the bug

hmm, found a similar report in yt-dlp repo. Someone suggested to extend condition to --match-filter "!is_live & live_status!=is_upcoming & availability=public". I'm not sure what it supposed to resolve but changed, will see.
pls report if you see truncated files again

It seems only live videos have been processed now. E.g. two latest videos first and second from Майкл Наки channel not in feed

i have dropped live_status!=is_upcoming, it seems to bring those missing episodes back

I'm not sure if it solved the original problem; however, it solved another problem – the long (very long, 2+ hours) episodes are not truncated anymore.

Original problem is solved I believe.
But I will keep watching whether everything is alright

Is reproduced again on this video
https://www.youtube.com/watch?v=7z-zNzeKxnw

Is reproduced again on this video
https://www.youtube.com/watch?v=7z-zNzeKxnw

Yeah, I have also seen partial downloads for some enormous episodes. Frankly, I have no clue what can be done here and am not even sure if smth can be done on the feed-master side. I'll mark this ticket as "help needed"; maybe someone will figure it out.
Btw, I still think the issue is in yt-dlp. You can try to reproduce it by running the same command feed-master running and observing what it downloaded. Maybe you will see some pattern and will be able to report it to yt-dlp. This is the command (template, replace  {{.FileName}} and {{.ID}} parts):
yt-dlp --extract-audio --audio-format=mp3 --audio-quality=0 -f m4a/bestaudio "https://www.youtube.com/watch?v={{.ID}}" --no-progress -o {{.FileName}}.tmp --match-filter "!is_live & availability=public

Not much else we can do here


TFinstall Fault

Description
What steps will reproduce the problem?

Spyder has encountered an internal problem! What should I do?!
Traceback
  File "E:\D\PYTHON\envs\keras\lib\site-packages\traitlets\traitlets.py", line 528, in get
    value = obj._trait_values[self.name]
KeyError: 'banner'

During handling of the above exception, another exception occurred:

ImportError: numpy.core.multiarray failed to import

Versions

Spyder version: 4.1.4
Python version: 3.7.7
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Windows 7

Dependencies

# Mandatory:
atomicwrites >=1.2.0           :  1.4.0 (OK)
chardet >=2.0.0                :  3.0.4 (OK)
cloudpickle >=0.5.0            :  1.5.0 (OK)
diff_match_patch >=20181111    :  20200713 (OK)
intervaltree                   :  None (OK)
IPython >=4.0                  :  7.17.0 (OK)
jedi =0.17.1                   :  0.17.1 (OK)
nbconvert >=4.0                :  5.6.1 (OK)
numpydoc >=0.6.0               :  1.1.0 (OK)
paramiko >=2.4.0               :  2.7.1 (OK)
parso =0.7.0                   :  0.7.0 (OK)
pexpect >=4.4.0                :  4.8.0 (OK)
pickleshare >=0.4              :  0.7.5 (OK)
psutil >=5.3                   :  5.7.0 (OK)
pygments >=2.0                 :  2.6.1 (OK)
pylint >=1.0                   :  2.5.3 (OK)
pyls >=0.34.0;<1.0.0           :  0.34.1 (OK)
qdarkstyle >=2.8               :  2.8.1 (OK)
qtawesome >=0.5.7              :  0.7.2 (OK)
qtconsole >=4.6.0              :  4.7.5 (OK)
qtpy >=1.5.0                   :  1.9.0 (OK)
rtree >=0.8.3                  :  0.9.4 (OK)
sphinx >=0.6.6                 :  3.1.2 (OK)
spyder_kernels >=1.9.2;<1.10.0 :  1.9.2 (OK)
watchdog                       :  None (OK)
zmq >=17                       :  19.0.1 (OK)

# Optional:
cython >=0.21                  :  None (OK)
matplotlib >=2.0.0             :  None (OK)
numpy >=1.7                    :  None (OK)
pandas >=0.13.1                :  None (OK)
scipy >=0.17.0                 :  None (OK)
sympy >=0.7.3                  :  None (OK)

Hi @Modamam,
It seems this isn't a problem of Spyder rather than from traitlets. Did you encountered this problem after installing tensorflow in your environment? And how did you installed it?

Hi @Modamam,
It seems this isn't a problem of Spyder rather than from traitlets. Did you encountered this problem after installing tensorflow in your environment? And how did you installed it?

Hi Stephannie, thanks for your answer.
I faced it after installing hdf5 by adding it to anaconda's environment. I didn't have any clue about hdf5 but I saw an error of hdf5 version when I tried to import newly installed tensorflow .
Then I tried to uninstall installed libraries, but I can't

Can you please try to install everything in a new environment to see if it works?

I did and encountered this problem
"from keras import models
Traceback (most recent call last):
File "E:\D\PYTHON\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 64, in
from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed: The specified module could not be found.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "E:\D\PYTHON\lib\site-packages\keras_init_.py", line 3, in
from tensorflow.keras.layers.experimental.preprocessing import RandomRotation
File "E:\D\PYTHON\lib\site-packages\tensorflow_init_.py", line 41, in
from tensorflow.python.tools import module_util as _module_util
File "E:\D\PYTHON\lib\site-packages\tensorflow\python_init_.py", line 40, in
from tensorflow.python.eager import context
File "E:\D\PYTHON\lib\site-packages\tensorflow\python\eager\context.py", line 35, in
from tensorflow.python import pywrap_tfe
File "E:\D\PYTHON\lib\site-packages\tensorflow\python\pywrap_tfe.py", line 28, in
from tensorflow.python import pywrap_tensorflow
File "E:\D\PYTHON\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 83, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "E:\D\PYTHON\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 64, in
from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed: The specified module could not be found.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
from keras import models
File "E:\D\PYTHON\lib\site-packages\keras_init_.py", line 6, in
'Keras requires TensorFlow 2.2 or higher. '
ImportError: Keras requires TensorFlow 2.2 or higher. Install TensorFlow via pip install tensorflow"
Actually the tensorflow version shown on my new environment is 2.3!

I will suggest you to follow the official guide of installation of tensorflow, https://www.tensorflow.org/install in a new environment. If you continue to encounter problems, please open an issue in the tensorflow repository https://github.com/tensorflow/tensorflow
We cannot do anything further because this is not a problem related to Spyder, hope you can fix it and thanks for reporting!

OK. Thanks for you explanation


upgrade SDK and rust compiler urgently needed

This SDK is behind Intel's SDK for quite a while already and the supported rust compiler is very old.
We currently face a deadlock because https://github.com/dtolnay/proc-macro2/pull/296 breaks our build. We can't downgrade, because other dependencies request proc-macro2-1.0.29. But we can't upgrade because teaclave's rust compiler support is outdated.
Please upgrade ASAP

Thanks for the report. I'll link a related PR here: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/349

@brenzi, as discussed with @volcano0dr, he's working on a new release recently. You'll see the changes in this month.
In the meantime, I suggest to pin to a specific version (through vendoring) to avoid such problem.

@mssun, @volcano0dr: Do you have any status update about the new release? Can SDK users or contributors do anything to help?

We were able to test it and it seems to work perfectly, thanks alot. proc-macro was updated to v1.0.32 and rust version to nightly-2021-10-01, which successfully built. (https://github.com/integritee-network/worker/pull/486)
Currently, ugly patching to a teaclave fork is neccesary for the mesalock libraries to work, since cargo does not allow patches to the same github repo. Other than that, nothing to complain about. Thanks alot for your effort!

when can we expect the release of 1.1.4?

Some update: Upgrade to rust-toolchain nightly-2021-11-13 is not possible, because of the following error:
error[E0522]: definition of an unknown language item: `begin_panic_fmt`
   --> /.cargo/git/checkouts/incubator-teaclave-sgx-sdk-f208006cdf70a903/19355dc/sgx_tstd/src/panicking.rs:406:1
    |
406 | #[lang = "begin_panic_fmt"]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition of unknown language item `begin_panic_fmt`

@haerdib I will upgrade rust-toolchain again recently to support rust edition 2021.

Upstream release: Intel SGX SDK 2.15.1 Release Notes (12 Nov 2021)
Changes in version 2.15.1:

Upgraded to OpenSSL 1.1.1l.

Does v1.1.4-testing need any update for this?
Is anything else still blocking it from being merged?

@PiDelport
v1.1.4-testing can support intel sgx sdk 2.15.1 and dcap 1.12.1

Awesome!
Does that resolve this issue?

@haerdib I have upgraded rust-toolchain to nightly-2021-11-01.

@PiDelport This issue has been resolved.


[SPIKE/RESEARCH] Async Snowflake Operator

Today SnowflakeOperatorAsync does not support submitting multiple SQL statements sequentially, which is the behavior of the SnowflakeOperator.As a note, the Snowflake SQL API allows for submitting multiple SQL statements in a single request. In combination with aiohttp, this may be an option for creating a SnowflakeOperatorAsync that matches the query submission behavior of the SnowflakeOperator.

Started working on this, as per documentation trying to submit the create query and insert query in one single query

Adding the related discussion here: https://github.com/astronomer/astronomer-providers/discussions/240.
Here are the docs I found through some research, regarding potential auth methods for this operator:

Using Key Pair Auth
Key Pair Auth and Rotation

Started implementing the separate SnowflakeSQLOperator by using AsyncA API call to existing connection won't be sufficient to make the API call we need find way in large context to support both SQL API type operator and snowflake connector type

Git hub repo link https://github.com/astronomer/astronomer-providers/tree/snowflake-multiple-sql

Finished coding part and pushed the code for snowflake SQL API operator, blocked with mapping public key to the snowflake user yesterday it was sorted by IT team now I need to test it with the Key's pair authentication
Git hub repo linkhttps://github.com/astronomer/astronomer-providers/tree/snowflake-multiple-sql

Tested the code with key pair authentication, pushed the changes to snowflake-multiple-sql branch, with example DAG
Git hub repo linkhttps://github.com/astronomer/astronomer-providers/tree/snowflake-multiple-sql

@ReadytoRocc You can pull the code from snowflake-multiple-sql branch I have added example, you can pull the code and run the example DAG with private key in  the connection

@bharanidharan14 I dont see any PR created for this issue . If this needs to be delivered to customer, then we need to create PR and go through our release process. Can you please confirm what is the plan here?

@phanikumv I Pinged @ReadytoRocc on this, whether this has to be delivered to customer or not, once he confirm PR can be raised we can follow the release process. from our side I made sure this is developed as separate operator and its in working state with multiple Query Implementation and async execution.

@ReadytoRocc Can you add your comments on this

Thanks @bharanidharan14. After some basic tests, this operator works well. Some thoughts:

I received a 403 error initially, because the account field in the connection did not include the region.
a. While this is noted in the Snowflake docs, the SnowflakeHook handles this by using the region configured in the connection.
b. This is something we may want to specifically note in the documentation.
We may want to offer an option to decrease the verbosity of the logging here.
a. For example, by default we could log some basic metadata about the query such as the statementStatusUrl, message, and createdOn fields.
b. If the full response is needed, this could be set via an argument.

Thanks @bharanidharan14. After some basic tests, this operator works well. Some thoughts:

I received a 403 error initially, because the account field in the connection did not include the region.
a. While this is noted in the Snowflake docs, the SnowflakeHook handles this by using the region configured in the connection.
b. This is something we may want to specifically note in the documentation.
We may want to offer an option to configure the verbosity of the logging here.
a. For example, by default we could log some basic metadata about the statements such as the statementStatusUrl, message, and createdOn fields.
b. If the full response is needed, this could be set via an argument.

@ReadytoRocc Thanks for commenting

I have added about account locators identifiers in the documentation, and user may want to add the account along with the region.
if I logged the statementStatusUrl, message, and createdOn it will be logged in the trigger and web server UI won't be having this log
I have logged the whole return response we can able to see the metadata of the query and rows got affected and more details like we see in sync snowflake operator
@phanikumv your thought on setting argument for logging the full response

we need your thoughts whether this operator can be open sourced ?

As per Discussion with @ReadytoRocc This Async Snowflake SQL Operator works as the expected, it can able submit multiple SQL statements sequentially, and poll for the status, and this operator can be released as  open source operator along with few requirements fix. so closing this ticket


[Event Request] Page 5875 Physical Inventory Order - Action "CalculateLines" - OnBeforeCalculateLines

Please add the following Event/-s OnBeforeCalculateLines to Action "CalculateLines" in Page 5875 Physical Inventory Order
[Event Request] Page 5875 Physical Inventory Order - action(CalculateLines)
{
    ApplicationArea = Warehouse;
    Caption = '&Calculate Lines';
    Ellipsis = true;
    Image = CalculateLines;
    ToolTip = 'Add physical inventory lines for items that are currently recorded in inventory.';

    trigger OnAction()
    var
        CalcPhysInvtOrderLines: Report "Calc. Phys. Invt. Order Lines";
        IsHandled: Boolean;    // <- ADDED
    begin
        IsHandled := false;      // <- ADDED
        OnBeforeCalculateLines(Rec, IsHandled);  // <-- NEW EVENT
        if IsHandled then        // <- ADDED
            exit();                       // <- ADDED

        CalcPhysInvtOrderLines.SetPhysInvtOrderHeader(Rec);
        CalcPhysInvtOrderLines.RunModal();
        Clear(CalcPhysInvtOrderLines);
    end;
}

[IntegrationEvent(false,false)]
local procedure OnBeforeCalculateLines(var PhysInvtOrderHeader: Record "Phys. Invt. Order Header"; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 13791.


Add ProfilePort to the API to allow enable pprof

ebpf agent need profileport configuration to open http connection and allow pprof collection as described in https://github.com/netobserv/netobserv-ebpf-agent/blob/2dca243a8dc5aa449aa0ff18a6924252cfab6c79/docs/profiling.md
However the operator didn't have this configuration knob.

/ok-to-test

It seems for pprof there is a generic way to configure ebpf profile port, so need to add additional fields to flowcontroller object
---
agent:
  type: EBPF
  ebpf:
    imagePullPolicy: IfNotPresent
    sampling: 50
    cacheActiveTimeout: 5s
    cacheMaxFlows: 100000
    interfaces: []
    excludeInterfaces:
      - lo
    logLevel: info
    resources:
      requests:
        memory: 50Mi
        cpu: 100m
      limits:
        memory: 800Mi
    kafkaBatchSize: 10485760
    debug:
      env: PORT_PROFILE:"6060"


Model Assets / Liabilities as accounts

Types
NOTE: f64 is used for simplicity of understanding. In reality, it should be Money, but for now treat it as an f64.
struct Transaction {
  amount: f64,
  from: String,
  to: String
}

type TransactionIterator = Iterator<Item = (NaiveDate, Transaction)>;

type Accounts = HashMap<String, f64>;

type AccountsIterator = Iterator<Item = (NaiveDate, Accounts)>;

an income stream will generate a TransactionIterator;
a liability account (Eg. annual interest) will generate a TransactionIterator;
Need to compose TransactionIterators into an AccountsIterator to get the value of an Account at any given date.

The core idea of modeling this as an accounting problem has been implemented. The architecture is still in flux, so I will close this issue for now.


detect for and do/while loops?

http://paste.ubuntu.com/p/MRRyBND2mt/
in https://github.com/Gegel85/norminette/blob/master/src/double_to_str.c there is a for loop as well as a do / while, but neither are flagged in the ouptut when running norminette on the codebase

That is not forbidden so that's why it's not flagged

in the PDFs i've seen in section II.8, it mentions they are forbidden. but i guess they are not, thanks!


Documentation textfix: Launch Drizzle Studio

Issue: Lack of Documentation Update when Switching Installation Options
Description:
When attempting to change the installation option (for example, from npm to yarn) for the project, the installation documentation remains unchanged. This can create confusion among developers and make the project setup process challenging.
Steps to Reproduce:

Go to the project's installation documentation page.
Try to change the installation option (for example, switch from npm to yarn).
Notice that the documentation remains unchanged, regardless of the selected installation option.

Expected Behavior:
The installation documentation should automatically update according to the selected installation option (npm, yarn, etc.) to provide accurate instructions for developers.
Current Behavior:
The documentation remains unchanged regardless of the selected installation option, which can lead to confusion and hinder the project setup process.
Impact:
This may slow down the project setup and configuration process and create confusion for new developers unfamiliar with the chosen installation option.
Proposed Solution:
Update the installation documentation to automatically adapt to the selected installation option, ensuring accurate instructions for developers.
Priority:
Medium

This has been addressed.


Make update object metadata API atomic

Protect updating object metadata on an existing entry to be safe against concurrent modifications, deletions, and commits and merges to the branch. This is a bit tricky because it needs to work for both committed and staged objects.
Fixes #8262 - a race that would give an odd result if update object metadata managed to lose against concurrent delete and uncommitted GC, or potentially merges into the branch.

Reviewers: I know that tests fail.  Please review anyway, we will likely need >1 round -- and these will be easy enough to fix, and not in the areas modified in this PR.

LookED good to Nir 😭

LookED good to Nir 😭

I'll review it today 😃

ObMeme:


Add Support for Nervos

Reference

https://github.com/satoshilabs/slips/blob/master/slip-0044.md (CKB / 309)
https://github.com/nervosnetwork/ckb

SDK

https://github.com/ashchan/ckb-sdk-swift
https://github.com/nervosnetwork/ckb-sdk-js

Address format

https://github.com/nervosnetwork/rfcs/blob/master/rfcs/0021-ckb-address-format/0021-ckb-address-format.md

Serialization

https://github.com/nervosnetwork/molecule
https://github.com/nervosnetwork/rfcs/blob/master/rfcs/0008-serialization/0008-serialization.md

Cell/Script/Transaction

https://github.com/nervosnetwork/rfcs/blob/master/rfcs/0019-data-structures/0019-data-structures.md

Closing until we have more interest in Nervos integration.


Provide guidance for :telemetry_prefix when you have multiple dbs

Speaking with @bryannaegele, we were incorrectly setting telemetry prefixes for our app that uses multiple databases. This should help push others in the right direction.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


[$1000] Chat - After submitting :shaka emoji from the search does not close

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Login with any account
Type in :shaka into the chat input
Tap on the submit button

Expected Result:
Emoji search suggestions should be automatically closed after a message is sent.
Actual Result:
Emoji still open after sending message.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/230737027-4c9e5e61-a988-4685-84b1-96698c49d072.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b8e6ae09568f44d5
Upwork Job ID:<PHONE_NUMBER>893933056
Last Price Increase: 2023-04-11

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Confirmed on Chrome. Opening this up.

Job added to Upwork: https://www.upwork.com/jobs/~01b8e6ae09568f44d5

@garrettmknight i think this is duplicate

I aggree, thanks @gadhiyamanan.

Based on the information needed for a developer to help resolve the issue, here are the steps to follow:
Analyze the code related to the chat and emoji search functionality.
Find and explore existing solutions related to closing emoji search suggestions after a message has been sent.
Test these solutions to make sure they solve the problem.
If none of the existing solutions work, develop a new solution that solves the problem.
Test the new solution to make sure it doesn't create new problems or bugs.
Make changes to the code related to the chat and emoji search functionality using the new solution.
Perform testing after changes have been made to ensure that the issue has been fully resolved.
Publish the corrected code to the staging server and ask the QA team to verify that the problem has indeed been fixed.
If the issue was successfully resolved on the staging server, publish the corrected code to the production server.
As to the cause of the issue, it could be due to a bug in the chat and emoji search functionality code that causes unwanted behavior. The developer should review the code associated with this functionality to identify and fix the bug. It is also possible that the problem is related to the conflict between different components in the application, causing unexpected results. In this case, the developer must examine which components interact in the chat and emoji search functionality in order to identify and fix the conflict.

📣 @YevsiukoVitaliy! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

📣 @YevsiukoVitaliy!📣
Эй, кажется, у нас еще нет данных о вашем участнике! Вам нужно будет сделать это только один раз, и именно так мы наймем вас на Upwork. Пожалуйста, выполните следующие действия:

Получите адрес электронной почты, используемый для входа в вашу учетную запись Expensify. Если у вас еще нет учетной записи Expensify, создайте ее здесь . Если у вас несколько учетных записей (например, одна для тестирования), используйте адрес электронной почты основной учетной записи.
Получите ссылку на свой профиль Upwork. Это необходимо, потому что мы платим только через Upwork. Вы можете получить к нему доступ, войдя в систему, а затем нажав на свое имя. Это будет выглядеть так . Если у вас еще нет учетной записи, зарегистрируйте ее здесь .
Скопируйте формат ниже и вставьте его в комментарий к этой проблеме. Замените текст-заполнитель вашими фактическими данными.

Формат:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e8d184d768ca7c74

⚠ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

⚠Отсутствует/неверный адрес электронной почты или ссылка на профиль upwork. Убедитесь, что вы добавили адрес электронной почты Expensify и ссылку на профиль Upwork в указанном формате.

The data is correct

⚠Отсутствует/неверный адрес электронной почты или ссылка на профиль upwork. Убедитесь, что вы добавили адрес электронной почты Expensify и ссылку на профиль Upwork в указанном формате.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e8d184d768ca7c74

✅ Contributor details stored successfully. Thank you for contributing to Expensify!


Problems with adding passenger

Reporting another issue with the tool:
I am adding new passengers through the admin page, but the driver doesn’t see the added passengers for some reasons. Refreshment o the page doesn’t help, internet is fine.
And I see them new passengers on my page in the tool.
We were standing next to each other and were directly witnessing this glitch

@OlaPAH I've just tried to recreate the issue on my local environment (using exactly the same version as is on production) and was not able to do so.
Can somebody confirm, that:

it's still an issue
it happened even when reload is triggered (that's usually dragging webpage content to down of the screen
it happened also when the user logs in using a desktop browser

If so, please provide (on Slack) login and password of a driver that has such an issue.
Thanks in advance!

As we decided on a call with @OlaPAH due to inactivity we're closing that one. If that problem still occurs please create a new ticket.


How to Refresh Image source

I am uploading an image in cropper container with the help of jquery. whenever I try to upload image on container, It does not refresh image source with base64 string generated at runtime in "cropper.js". So I wrote a function to generate base64 string in my controller and assigned it to some other image tag which is not being used by cropper, It works fine for  that but It is not working for image container in cropper.
please let me know how to refresh the source.
Thanks.

Restart the cropper or call the replace method to change image src.

How do I call the replace method?

hi,
same problem with version 2.3.4;
i have used also
.cropper('destroy').cropper('replace', new_image)
but not working, the image on cropper-canvas is always old
have with problem only with base64 images, when use file image working without problems.
Thanks.

#45


Fix doc typo in WidgetsApp.supportedLocales

Description
Simple doc fix in WidgetsApp.supportedLocales.

I think the doc is OK (it appears to render correctly - https://master-api.flutter.dev/flutter/widgets/WidgetsApp/supportedLocales.html), markdown for numbered list items just has to show a leading number; any number.


ci: Integrate SonarCloud

This will give us details coverage and static and static code analysis attached to every PR. It also allows us to enforce certain code quality attributes.
Example in my private fork:

PR
SonarCloud

Open Questions/Please note:

The checks can only work if/when @sbernard31 enables SonarQube as mentioned above
If/when this PR got merged...

we should have a look at all findings
we could add shiny badges in the top-level readme :)

To enable the integration for your own fork, take the following steps:

Log in to https://sonarcloud.io/ using your GitHub account
Visit https://sonarcloud.io/projects/create, add Wakaama (fairly
self-explanatory)
Create a PR in your repository to verify the integration

@qleisan @mlasch @sbernard31 @sbertin-telular Would like to hear your opinions on this.

The checks can only work if/when @sbernard31 enables SonarQube as mentioned above

I never did that but if we want to I guess I need to ask for permission to eclipse webmaster ( see https://bugs.eclipse.org/bugs/show_bug.cgi?id=572407)

Would like to hear your opinions on this.

No strong opinion on it. I didn't play so much with sonar, so I guess I can not give you relevant feedback.
I contributed to few projects where it was used and some time feedback returned was annoying but I guess this is more setting issue. So maybe the question could be : is it no too much time consuming to set it to report really useful feedback ?

I contributed to few projects where it was used and some time feedback returned was annoying but I guess this is more setting issue. So maybe the question could be : is it no too much time consuming to set it to report really useful feedback ?

I think there are two aspects:

Code coverage: Very easy to set up and maintain - just specify the code coverage level needed to allow a PR to be merged. Proposing to get this integrated in the merge workflow soon-ish.
Static code analysis: More work to set up initially, will have some maintenance cost for reviewing the findings. In my opinion the benefits of having this analysis nevertheless outweigh the efforts needed and I am willing to take care of it (initially and later on). However, I am not a committer, therefore I can not do this due to the lack of access. We could still have the analysis enabled but not enforcing it on PRs though.

I just rebased the branch. Now that I have committer permission, I think I am able to open the relevant issues in the Eclipse Bugzilla myself.
@sbernard31 Given I am taking care of the initial (just me) and ongoing maintenance (adjusting rules, help with findings in PRs, etc.) would you be OK with moving forward?

Now that I have committer permission

:tada:
@rettichschnidi  should you get feedback from other members of the team before to open bugzilla ?

@rettichschnidi should you get feedback from other members of the team before to open bugzilla ?

You are right - 2nd try: @qleisan @mlasch @sbernard31 @sbertin-telular Would like to hear your opinions on this. :smile:

To enable the integration for your own fork, take the following steps:
Log in to https://sonarcloud.io/ using your GitHub account
Visit https://sonarcloud.io/projects/create, add Wakaama (fairly
self-explanatory)
Create a PR in your repository to verify the integration

Pushed this branch to my wakaama fork repo and got sonarcloud to execute (after setup)
Check out the result here

SonarCloud Quality Gate failed.
Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells
99.8% 99.8% Coverage
0.0% 0.0% Duplication

The findings do already exist in the master code, but since master never got scanned, those show up now for the first time, causing the PR to get rejected.
Looking good (as expected) to me.

@sbernard31 We are facing some issues with the setup of SonarCloud. Can I please get your +1 so that I can get admin temporary permissions on this repository to debug/fix the issue?

@rettichschnidi, done.
Sorry for the delay but  I was out of office yesterday. By the way this will probably happen often during april/may because I will work something like 3 days by week during this period. (too many day off accumulated :grimacing: )

Sorry for the delay but I was out of office yesterday. By the way this will probably happen often during april/may because I will work something like 3 days by week during this period. (too many day off accumulated grimacing )

Not a problem at all - enjoy your time!

Turns out, that running SonarCloud for external PRs can not be done in a secure fashion [1][2].
I will change my PR to run the analysis only on commits, not on PRs. I might come up with an improvement which allows committers to selectively run PRs using a combination of pull_request_target [3] and labels [2], but this will take a while, will be a separate PR.
[1] https://jira.sonarsource.com/browse/MMF-1371
[2] https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
[3] https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target


could not find Lazy implicit value of type io.circe.generic.extras.encoding.ConfiguredObjectEncoder

I believe I have a pretty simple and reproducible case that will cause the error above. In Principal.scala:
package test
sealed trait Principal {
  def name: String
}

object Principal {
  case class UserPrincipal(name: String) extends Principal
  case class AgentPrincipal(name: String) extends Principal
}

And in CirceSerializers.scala
package test
import cats.syntax.either._
import io.circe._
import io.circe.generic.extras.semiauto._
import io.circe.generic.extras.{Configuration => CirceCfg}
import test.Principal._

object CirceSerializers {
  implicit val circeCfg: CirceCfg = CirceCfg.default.withDiscriminator("kind")

  // --
  // -- Principal Serializers
  // --
  implicit val AgentPrincipalEncoder: ObjectEncoder[AgentPrincipal] = deriveEncoder[AgentPrincipal]
  implicit val AgentPrincipalDecoder: Decoder[AgentPrincipal] = deriveDecoder[AgentPrincipal]

  implicit val UserPrincipalEncoder: ObjectEncoder[UserPrincipal] = deriveEncoder[UserPrincipal]
  implicit val UserPrincipalDecoder: Decoder[UserPrincipal] = deriveDecoder[UserPrincipal]

  implicit val PrincipalEncoder: ObjectEncoder[Principal] = deriveEncoder[Principal]
  implicit val PrincipalDecoder: Decoder[Principal] = {
    Decoder.instance[Principal] { cursor =>
      cursor.downField("kind").as[String].flatMap {
        case "UserPrincipal" => cursor.as[UserPrincipal]
        case "AgentPrincipal" => cursor.as[AgentPrincipal]
        case other => DecodingFailure(s"Could not locate a Principal decoder for json with `kind` value '$other'", Nil).asLeft
      }
    }
  }
}

Having these definitions yields the error described in the title of the issue.
If I simply move the definition of Principal and its companion object into CirceSerializers.scala before the definition of object CirceSerializers, the error goes away.
A repro repository can be checked out here: https://github.com/gavares/circe-error-repro that will generate the error.

FWIW, changing from scala 2.11.8 to 2.12.1 also resolves the issue.

Hi @gavares, I just tried this on 2.11.12 and it compiles (I confirmed the failure on 2.11.8), which means this is almost certainly a case of SI-7046, which was partially fixed in either 2.11.9 or 2.11.10. Closing now, but please reopen if you can reproduce the error on 2.11.12.


Card.Media should be an image in some cases

On the material components demo, the media is often and <img> and not a <section> or <div> with a background. This is useful for layouts using Card.HorizontalBlock (#181).
I think it would be nice if we could make Card.Media an <img> if we pass a src to it and keep it as a <section> if there's no src. Or maybe it would be easier to add a Card.MediaImage, what do you think?

Actually, I guess i should be a Card.MediaItem and not a Card.Media because the class should be mdc-card__media-item and not just mdc-card__media.


User is unable to upload TCX file

Error message is displayed when user wanted to upload 1.5MB big TCX file.

There was a size limit on reverse proxy nginx and within application.
Both limits have been changed to support bigger file sizes.

The issue is now resolved. Issue will be closed.


iterator_interface constrained friend operators fail to compile in gcc-13

The 1.82.0 iterator_interface fails to compile in gcc-13 and trunk. You can see that in this godbolt example. The constraints have changed since 1.82.0, and I can't test them directly because trunk doesn't seem to be available on godbolt, but I expect the same problem.
I reported this as a gcc-13 regression, but was told that gcc is correct and that the construction isn't valid.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109751
I believe that the fix is to use template member functions, not template friends, for the operators that are being constrained based on D.

Thanks For reporting this, and for such a nicely reduced example!
I don't have easy access to GGC13 right now.  Could you try this with tip of the develop branch, at https://github.com/boostorg/stl_interfaces?  The constraint has changed (it was nonsensical, as pointed out in the GCC bug thread :).  The change might make things work.
Zach

If I paste the header into the godbolt code from above it seems happier. So this seems fixed in the trunk code. Sorry for the false alarm.


Update front-end deps, remove unnecessary front-end files

This PR:

Deletes the eregs_core/js/, eregs_core/css/, eregs_core/img/, eregs_core/font/ directories (as far as I can tell they're not used in any way).
Adds an .eslintrc file for linting JS files.
Updates .gitignore to ignore node modules and the static/ dir in the project's root that gets created by collectstatic.
Updates the front-end dependencies in package.json

hooray


Send a Message/File to a Thread

Includes the enhancement suggested in #100  A little bit different implementation than originally outlined, but very similar.
Examples:
Send-SlackMessage -Text 'Doing Something' -Channel chatops -Thread '1623039865.004000'
Send-SlackFile -Content "Here You Go" -FileType Text -FileName File.txt -Channel chatops -Thread '1623039865.004000'

Example output:

Seems backwards compatible, and at a glance lgtm - this working for you?

Yes! I was using this branch to do some testing with PoshBot for creating threaded responses. You can see some examples over there https://github.com/poshbotio/PoshBot/pull/232

eek, who knows if builds still work 🤞

It looks to be working from some manual testing.


Generate metadata from pyproject.toml

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Trying to lint the recipe locally throws:
Traceback (most recent call last):
  File "C:\Users\mcdevin\Miniconda3\envs\wot_build\envs\conda-smithy\Scripts\conda-smithy-script.py", line 9, in <module>
    sys.exit(main())
  File "C:\Users\mcdevin\Miniconda3\envs\wot_build\envs\conda-smithy\lib\site-packages\conda_smithy\cli.py", line 670, in main
    args.subcommand_func(args)
  File "C:\Users\mcdevin\Miniconda3\envs\wot_build\envs\conda-smithy\lib\site-packages\conda_smithy\cli.py", line 514, in __call__
    lints, hints = lint_recipe.main(
  File "C:\Users\mcdevin\Miniconda3\envs\wot_build\envs\conda-smithy\lib\site-packages\conda_smithy\lint_recipe.py", line 978, in main
    content = render_meta_yaml("".join(fh))
  File "C:\Users\mcdevin\Miniconda3\envs\wot_build\envs\conda-smithy\lib\site-packages\conda_smithy\utils.py", line 90, in render_meta_yaml
    content = env.from_string(text).render(context)
  File "C:\Users\mcdevin\Miniconda3\envs\wot_build\envs\conda-smithy\lib\site-packages\jinja2\environment.py", line 1301, in render
    self.environment.handle_exception()
  File "C:\Users\mcdevin\Miniconda3\envs\wot_build\envs\conda-smithy\lib\site-packages\jinja2\environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 1, in top-level template code
jinja2.exceptions.UndefinedError: 'load_file_data' is undefined

...is the linter unable to handle conda's own functions!?

Indeed, it looks like some conda-build functions are not supported by conda-forge, including load_file_data. This same issue was brought up in https://github.com/conda-forge/conda-smithy/issues/1414 with load_setup_py_data (which was sort of the ancestor of load_file_data), and there was never much movement associated with it.
I will leave this PR open, but looks like it still might be awhile before automation with pyproject.toml works with conda-forge. This means we will still have to manually update dependencies if they change between releases.


Any plan to support fasthttp?

I've using grace for my project together with echo (v1). It works great and I love it 😃
Since v2, echo add support for fasthttp.
Switching between standard net/http and fasthttp is easy, but grace won't work with fasthttp.
Is there any plan to support fasthttp?
Would like to hear your feedback :)

gracehttp is the thing that provides the easy to use net/http logic. This is built on top of gracenet and httpdown -- the latter is specific to net/http in that it relies on https://golang.org/pkg/net/http/#ConnState to track active requests. You should be able to rely on gracenet since it's generic and works at the net.Listener level, but you'll need to build something like httpdown for fasthttp -- not sure how easy that is or if there are enough hooks for it. Happy to guide to through it, but I think it's best to have it be in a separate repo!


Working with a secure element chip questions

Hi,
I am fairly new to TLS I am working on a commercial product which requires it. The product currently has a  an ATECC508 secure element.
I have to replace mbedtls_ecdsa_sign() because we can't read the private key and thus we need to do the signing on chip.
Is this done every time we need to transmit and receive data. I am concerned about through put.

Hi @umanayana Thank you for your question.

Is this done every time we need to transmit and receive data.

Signing of data is not done on every transmission of data. In the server side, it is done when sending the serverKeyExchange message, on some ciphersuite. And on the client side, it is done in the certificateVerify verify message, if you are using a two side authentication.
When receiving data, there is no use in signing, as the point of signing is to let the other side authenticate you. When receiving messages, signature verification with the public key is used.
If for some reason, you are generating certificates on the fly, the they will be signed as well.
What about key exchange? Does it require secure element?

Hi

So as far as I understand I need to replace all features of MBEDTLS_ECDSA_SIGN_ALT.  As this need to be done on the co-processor. I've been reading more on TLS protocol to my understanding this is done only during handshaking to figure out the shared secret.


persists after deinstallation?

I removed the plugin, and after that i removed the SIMBL entirely but the icons are still colorful in the menu bar. The sidebar has old icons though

Restart Finder?

Yeah, I've restarted it, even after reboot it's still there

Wait i think that's default on my os version sorry lmao


uart_stm32: fix a dead lock on poll_out if it's called in interrupt

If the function poll_out is called in an interrupt with a higher
priority than the usart priority, the function could lock forever. In
fact, the lock variable is never unset if the usart interrupt is no
longer called. So now, we don't use the lock variable if poll_out is
called in interrupt.
Signed-off-by: Julien D'ascenzio<EMAIL_ADDRESS>

@jdascenzio Thanks, though I think there's a wider issue to fix, cf https://github.com/zephyrproject-rtos/zephyr/issues/40775

I modified the patch to fix #40775. I hope this commit is the last to fix competitive calls to fifo_fill and uart_poll!

add lock to uart_stm32_irq_tx_enable and uart_stm32_irq_tx_disable to avoid race condition

I do some self test on my system (stm32L4A6, zephyr 2.5) and noticed that I lost bytes on terminal :( . Exmp. in switch interrupts kprint("ZzzzZ"); . On terminal output I often see zzzZ[0m or zzzZJ... . So I lost first Z, but at and I see strange symbols. Log messages lost too. hmm.

Do you have CONFIG_PM enabled in your build? It could be related to this issue #39220
The "strange bytes" (starts with [ followed by 0m/J/etc) are the control characters / color code for the shell.

I do some self test on my system (stm32L4A6, zephyr 2.5) and noticed that I lost bytes on terminal :( . Exmp. in switch interrupts kprint("ZzzzZ"); . On terminal output I often see zzzZ[0m or zzzZJ... . So I lost first Z, but at and I see strange symbols. Log messages lost too. hmm.

Do you have CONFIG_PM enabled in your build? It could be related to this issue #39220 The "strange bytes" (starts with [ followed by 0m/J/etc) are the control characters / color code for the shell.

Yes you right. Than you.

It seems to me, that need change uart_stm32_fifo_fill function too. Protection from nested interrupts .
static int uart_stm32_fifo_fill(const struct device *dev,
				  const uint8_t *tx_data,
				  int size)
{
	USART_TypeDef *UartInstance = UART_STRUCT(dev);
	uint8_t num_tx = 0U;
	int key;

	if(LL_USART_IsActiveFlag_TXE(UartInstance))
	{
		key = irq_lock();//prevent nested interrupts or thread switch
		__DSB();
		while ((size - num_tx > 0) && //only max 2 bytes sent at time - no latency, because first byte in shift register second hold in TXD register
			   LL_USART_IsActiveFlag_TXE(UartInstance)) {
			/* TXE flag will be cleared with byte write to DR|RDR register */

			/* Send a character (8bit , parity none) */
			LL_USART_TransmitData8(UartInstance, tx_data[num_tx++]);
		}
		irq_unlock(key);
		__DSB();
	}

	return num_tx;
}

You are right, it is necessary to protect here the reading of TXE flag.
However, I'm not familiar with memory/instruction barrier. But, if you say that there may be a problem with the order of the execution of the instructions (usage of DSB), after irq_[lock/unlock], then, the type of problem could happen every time these functions are used. It would then be perhaps more judicious to integrate this barrier directly in irq_[lock/unlock]....

Is this ready to merge yet @jdascenzio ? Will you be adding the __DSB() calls that @DariusBabrauskas asked for?

Setting DNM until the direction is clear.

I added a lock in fifo_fill function.
For me, irq_lock already has an instruction barrier with isb:
static ALWAYS_INLINE unsigned int arch_irq_lock(void)
{
 # .......

#elif defined(CONFIG_ARMV7_M_ARMV8_M_MAINLINE)
	unsigned int tmp;

	__asm__ volatile(
		"mov %1, %2;"
		"mrs %0, BASEPRI;"
		"msr BASEPRI_MAX, %1;"
		"isb;"
		: "=r"(key), "=r"(tmp)
		: "i"(_EXC_IRQ_DEFAULT_PRIO)
		: "memory");

@DariusBabrauskas, Don't you think that's enough?
The character that you were losing, was it not related to the forgotten lock in fifo_fill?

I added a lock in fifo_fill function. For me, irq_lock already has an instruction barrier with isb:
static ALWAYS_INLINE unsigned int arch_irq_lock(void)
{
 # .......

#elif defined(CONFIG_ARMV7_M_ARMV8_M_MAINLINE)
	unsigned int tmp;

	__asm__ volatile(
		"mov %1, %2;"
		"mrs %0, BASEPRI;"
		"msr BASEPRI_MAX, %1;"
		"isb;"
		: "=r"(key), "=r"(tmp)
		: "i"(_EXC_IRQ_DEFAULT_PRIO)
		: "memory");

@DariusBabrauskas, Don't you think that's enough? The character that you were losing, was it not related to the forgotten lock in fifo_fill?
Possible lost symbols was terminal log problem, which try hide escape sequences. I enabled binary log then I see all symbols. No lost with dsb or without (fifo_fill was edited).
So maybe you are right,- isb is enought.
It seem too me, that dsb must be after isb. I see dsb after isb in others systems. This operatios are different.

Let's have a new round of review and test, considering the recent changes.

@cfriedt This PR was tagged "Blocked: HW tests". It should not have been merged..
Hopefully the tests will be passed.

@cfriedt This PR was tagged "Blocked: HW tests". It should not have been merged..
Hopefully the tests will be passed.

Apologies @erwango - best to request changes so that it does not make it past filters.

@cfriedt Agree, but then, let's remove "Blocked: HW test", if it can be trusted.

Ok, tests are passed. At least the in tree ones. I trust @jdascenzio to test the PM ones

No problems for me with CONFIG_PM. I don't lose any characters


Allow wrapping allocators other than System.

Hi! I was missing some feature to this effect, so I wrote one possible implementation.
Unfortunately, it’s backwards-incompatible, because now dhat::Alloc needs to store an internal allocator. It could be made backwards-compatible by leaving dhat::Alloc be and introducing a new type, e.g. dhat::WrapAlloc, but that would complicate API somewhat.

Thanks for the PR. I'm surprised to see how many thumbs up responses this has received, which suggests its of interest. So I'd be happy to take it, though I would like to have at least one test that it works. Could you add one?

Yeah, sure. I pushed a test that shows that alloc calls are properly forwarded and heap stats counting still works.
I’d also like to note that mintex 0.1.3 fixed an issue that sometimes caused a deadlock in dhat-rs, so I think it makes sense to bump the version in Cargo.toml before next release. Thanks (and sorry for the late reply)!


Sam2 run

This PR adds and implements SAM2 object tracking and mask generation for primary objects and extracts features for each cell channel and compartment using CellProfiler.

@jenna-tomkinson Could you please take a look at the .cpipe file specifically??


Don't require Eq for LedgerView

This was used only for the lemmas, but it was getting in the way of the
HardFork combinator (which wants an EpochInfo in the ledger view).

bors merge


Update sourcemap link between source lines and generated lines

When generating source maps using jade's updated compileDebug format, the source and generated lines were not always being linked correctly.
I've also stopped multiple entries being created for a single source line where generated code creates more than one reference.

Will submit new PR. Line numbers still one out due to PREFIX \n.


test: add unit&storybook coverage to codecov

test: add storybook coverage to codecov
test: add unit test coverage to codecov

storybook coverage isn't showing up quite right:

all flags are showing coverage data

with full coverage of all files available as well


Fix for js-controller 5.x

Issue #27 fixed: https://github.com/BuZZy1337/ioBroker.doorbird/blob/master/main.js#L25 leads with js-controller 5.x in an uncaught exception. Fixed with getAbsoluteInstanceDataDir.

@Apollon77 could you please merge this pr?

Plan to review and merge today/over the weekend.

@todde99 One qiuestion: What is done with that file? because in fact it is not reachable (old way or new way) by any web adapter or anything ... so it is just laying around there ... ?! Or how it is used?

@Apollon77 , I don't know what the original developer had in mind but I'm using it e.g. to send it via the telegram adapter to a chat when someone rings the bell: sendTo('telegram.1', {text: '/opt/iobroker/iobroker-data/doorbird.0/snap.jpg', chatId: '000001']);

Ok yes so it works :-)

I merge now ... for release I hope find time before my vacation, but then github version is working. Thank you!

Perfect! Thank you @Apollon77 for all your support and effort!!! I will close the issue #27 after testing the github version.


 We can disable it again if we want to ignore line length.

how about merging the tidy3d branch first?

they are independent

https://github.com/gdsfactory/gplugins/pull/250


Failed assertion: Init ops are not currently supported in OptiX

Problem

Init opts are currently not supported in the OptiX run time. This means that using such notation as initializing vector parameters from global variables (e.g. vector v = vector(u, v, 0) ) is not supported and you will hit the assert in the tittle of this ticket. This notation is used quite frequently in the publicly available OSL shaders that the 3DSMax guys have written here and its a shame not to be able to use them. Is there any plans on adding support for these anytime soon? At least having a graceful fallback so that the run time doesn't crash with these shaders would be great!

Steps to Reproduce
The following patch will modify the testoptix test to reproduce the issue. Simply run,
testrender.exe -optix scene.xml -r 320 320 out.exr
This will give the following assert,
llvm_instance.cpp:495: failed assertion '! sym.has_init_ops() && "Init ops are not currently supported in OptiX"'
--- a/testsuite/testoptix/checkerboard.osl
+++ b/testsuite/testoptix/checkerboard.osl
@@ -41,7 +41,7 @@ checkerboard
         [[  string description = "scale factor for s coordinate" ]],
     float scale_t = 4
         [[  string description = "scale factor for t coordinate" ]],
-    color Ca = color(1, 1, 1)
+    color Ca = color(u, v, 1)
         [[  string description = "color of even squares" ]],
     color Cb = color(0, 0, 0)
         [[  string description = "color of odd squares" ]],
diff --git a/testsuite/testoptix/scene.xml b/testsuite/testoptix/scene.xml
index 1a2956e..e33f646 100644
--- a/testsuite/testoptix/scene.xml
+++ b/testsuite/testoptix/scene.xml
@@ -4,7 +4,6 @@
    <ShaderGroup>
       param float scale_s 20;
       param float scale_t 20;
-      param color Ca 0.1 0.1 0.1;
       param color Cb 0.5 0.5 0.5;
       shader checkerboard tex;
       shader matte layer1;

Versions

OSL branch/version: master
OS: Windows 10 / Centos 6.0
C++ compiler: clang 5
LLVM version: 5.0.2
OIIO version: master

Fixed by #1057


Removing Mixed Query Flags

As part of https://github.com/ava-labs/avalanchego/pull/1428 we are removing mixed queries, so the corresponding configs can be removed.

Shouldn't be merged until avalanchego v1.10.3 is released

ty! lgtm will approve and merge at the next release

@danlaine @joshua-kim are there any other changes that should be made here given today's release?

@danlaine @joshua-kim are there any other changes that should be made here given today's release?

There's a few I believe but they're not related to this PR. I think we did change a few things in the latest release (e.g staking-enabled -> sybil-protection-enabled but we can chat about it offline.


Generate inner queries instead of join+distinct

When applying filters with related entities, CanCan used to generate a LEFT JOIN plus
a DISTINCT clause to avoid repeated records. This is problematic for a number of reasons:

Postgres is picky about setting ORDER BY with a column not on the DISTINCT clause, because it applies the ORDER after the DISTINCT so it cannot 'see' the referenced column.
Groups and Counts become more difficult to do because foo.distinct.count is not the same as foo.count.

The way to avoid this problem is to use inner queries that don't multiply the number of returned records. We do this by running the query we were previously using inside a WHERE IN block.
This is a different approach than #600.
cc @ghiculescu
Fixes #596

I can't reproduce the CI failures locally. AFAICS, the only difference is with the postgres version (I'm using 11, CI appears to use 9.6).

I have reproduced this with postgres 9.6. The problem is that selecting custom columns and preloading of associatons in accessible_by_{integration,has_many_through} are non-deterministic since the result set contains two records and the order is not ensured. I fixed those tests by adding a condition ensuring a single result.

@fsateler Great work!

When applying filters with related entities, CanCan used to generate a LEFT JOIN plus
a DISTINCT clause to avoid repeated records. This is problematic for a number of reasons:

One more reason to avoid DISTINCT — it would fail when used on tables with json columns (PostgreSQL have no equality operator for type json).
ERROR: could not identify an equality operator for type json LINE 1: SELECT DISTINCT "users".* FROM ...

Any update on this? Excited to see this get merged in.

I am running the last tests and I included also #608 . Please see #619 . Will be released soon. Very nice work community! ❤ you.

closed in #619


Don't count HAL projects towards language stats

Caused by: https://github.com/vkottler/hal-xmc4700

Normally Python would be the highest.

That's fixed.


Fixes attribute names not being translated for non-default messages (laravel4)

(laravel4) At the moment, raw attribute names are used for all rules handled in the JqueryValidation Message class. This PR moves the getAttributeName method from Converter to Helper and adapts the Message class to call this method.

superseded by #12


cargo install failed

OS/Arch: Darwin arm64
cargo install nostui
error[E0308]: mismatched types
    --> /Users/tjex/.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/nostui-0.1.0/src/components/home.rs:287:34
     |
287  |             self.input.set_block(block);
     |                        --------- ^^^^^ expected `ratatui::widgets::block::Block<'_>`, found `ratatui::widgets::Block<'_>`
     |                        |
     |                        arguments to this method are incorrect
     |
     = note: `ratatui::widgets::Block<'_>` and `ratatui::widgets::block::Block<'_>` have similar names, but are actually distinct types
note: `ratatui::widgets::Block<'_>` is defined in crate `ratatui`
    --> /Users/tjex/.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/ratatui-0.25.0/src/widgets/block.rs:233:1
     |
233  | pub struct Block<'a> {
     | ^^^^^^^^^^^^^^^^^^^^
note: `ratatui::widgets::block::Block<'_>` is defined in crate `ratatui`
    --> /Users/tjex/.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/ratatui-0.26.3/src/widgets/block.rs:64:1
     |
64   | pub struct Block<'a> {
     | ^^^^^^^^^^^^^^^^^^^^
     = note: perhaps two different versions of crate `ratatui` are being used?
note: method defined here
    --> /Users/tjex/.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/tui-textarea-0.4.0/src/textarea.rs:1648:12
     |
1648 |     pub fn set_block(&mut self, block: Block<'a>) {
     |            ^^^^^^^^^

error[E0277]: the trait bound `impl ratatui::widgets::Widget + '_: ratatui::widgets::Widget` is not satisfied
   --> /Users/tjex/.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/nostui-0.1.0/src/components/home.rs:288:29
    |
288 |             f.render_widget(self.input.widget(), input_area);
    |               ------------- ^^^^^^^^^^^^^^^^^^^ the trait `ratatui::widgets::Widget` is not implemented for `impl ratatui::widgets::Widget + '_`
    |               |
    |               required by a bound introduced by this call
    |
    = help: the following other types implement trait `ratatui::widgets::Widget`:
              text_note::TextNote
              BarChart<'a>
              ratatui::widgets::Block<'a>
              Canvas<'a, F>
              Chart<'a>
              ratatui::widgets::Clear
              Gauge<'a>
              LineGauge<'a>
            and 5 others
note: required by a bound in `ratatui::Frame::<'_>::render_widget`
   --> /Users/tjex/.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/ratatui-0.25.0/src/terminal.rs:614:12
    |
612 |     pub fn render_widget<W>(&mut self, widget: W, area: Rect)
    |            ------------- required by a bound in this associated function
613 |     where
614 |         W: Widget,
    |            ^^^^^^ required by this bound in `Frame::<'_>::render_widget`

Some errors have detailed explanations: E0277, E0308.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `nostui` (bin "nostui") due to 2 previous errors
error: failed to compile `nostui v0.1.0`, intermediate artifacts can be found at `/var/folders/45/5qcnyymn0gj_241x_c9trs1m0000gn/T/cargo-installT0JXBu`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Thank you for your reporting

I also just ran into this trying to cargo install on my PopOS laptop (x86_64)


UnicodeEncodeError in split_sentences

  s_iter = [''.join(map(str,y)).lstrip() for y in s_iter]

E       UnicodeEncodeError: 'ascii' codec can't encode character u'\u2014' in position 85: ordinal not in range(128)

Use latest version from pip (pyteaser==1.0)

This was raised before and closed without being fixed. :(
https://github.com/xiaoxu193/PyTeaser/issues/33

@grimpunch Thought this was fixed with https://github.com/xiaoxu193/PyTeaser/pull/34
Apparently not. Will look into this personally

It seems threre are old version in pip. Code from master have not this error.

My apologies, vetal4444 is correct. I'm using master now. Pip definitely has an old version

@vetal4444 @grimpunch thank you guys for spotting the error!

Pip has been updated: https://pypi.python.org/pypi/pyteaser

README has been updated to reflect the change. https://github.com/xiaoxu193/PyTeaser/pull/43

@xiaoxu193 can you tell me what sbs and dbs method names means in pyteaser.py ?

I am still getting the same error. I did tried encode to utf-8 etc. not working :( .

Can you post the link that you tried to run the algorithm on?

Sorry that I didn't thanked you for the awesome work you have done. Thank you dude.
Coming back to the problem :
Strange thing is I have installed pytease via pip and have updated via pip install -U .
An earlier version was using pyteaser.py file which is just copied to my folder. That worked from there. But only the pip installation is failing . I am also new to Python. My background is PHP.
from goose import Goose
>>> from pyteaser import Summarize
>>> g = Goose()
>>> page_url = "http://nikic.github.com/2012/06/29/PHP-solves-problems-Oh-and-you-can-program-with-it-too.html"
>>> try:
...     page = g.extract(page_url)
...     description = page.cleaned_text.encode('utf-8')
...     title = page.title
...     summarylist = Summarize(title, description)
... except:
...     # Exception
...     print "Error occured in summary"
...     raise
...
Error occured in summary
Traceback (most recent call last):
  File "<stdin>", line 5, in <module>
  File "/usr/local/lib/python2.7/dist-packages/pyteaser.py", line 85, in Summarize
    sentences = split_sentences(text)
  File "/usr/local/lib/python2.7/dist-packages/pyteaser.py", line 209, in split_sentences
    s_iter = [''.join(map(unicode,y)).lstrip() for y in s_iter]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 1: ordinal not in range(128)

Hi @xiaoxu193 ,
I have a question what about keeping a try catch ?
    another = ''
    for y in s_iter:
        try:
             another += ''.join(map(unicode,y)).lstrip()
        except:
            print "some way to catch"
    s_iter = [another]
    s_iter.append(sentences[-1])
    return s_iter

This is a pseudo code though which didn't worked :( .
Just my thought.
Thank you.

The problem occurring is with split(u'(?<![A-ZА-ЯЁ])([.!?]"?)(?=\s+\"?[A-ZА-ЯЁ])', text, maxsplit=0, flags=REGEX_UNICODE)


Add a helm chart

Push the image to docker hub oamdev/core-resource-controller and add a helm chart

https://github.com/crossplane/addon-oam-kubernetes-local/issues/3


Feature/pr template

The guidance/instructions are now comments. This means if they are not deleted they are not visible in the rendered view of the issue.

This? https://github.com/nhsuk/frontend-library/pull/18/files#diff-195a635ad245ded9076330e31134bd80R30

How did it miss that!?


ci: explicitly use stable channel for downloads

Signed-off-by: Snow Pettersen<EMAIL_ADDRESS>This should resolve the CI issue of the system image depending on a beta emulator.
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Closed in favor of https://github.com/envoyproxy/envoy-mobile/pull/1695


Drag drop not working on any mobile browser

Have deployed the application on below URL:
http://ec2-18-220-151-90.us-east-2.compute.amazonaws.com/
It is working fine in desktop browser but not it is not working on any mobile browser, or Windows 10 touch device. You can check this in gameplay section from above url.
Also if you check the provided plunker demo that is also not working with mobile device

@AmitBisht14, this is a limitation. The Html drag drop Api does not work on Touch.
See this: https://github.com/ObaidUrRehman/ng2-drag-drop/issues/47#issuecomment-302653094


Set Gain to 32 bit

Hello,
i have only a question becouse i dont find it in the documentation and i like your code very much.
To my question, How can i set the gain to 32 bit to can read the channel B?
Thanks very much

I dont believe this works due to src/HX711_ADC.cpp#L306
This doesnt gather the value for (24 + GAIN), it stops at 24 which is only Channel A.
Happy to have this clarified but I don't understand how this will ever work.

Hi!
You should be able to use channel B by using function setGain(uint8_t gain) with argument value 32.

Hi Olkal,
I tried this however the value given for channel B is not the same as the Channel A.
I. E connect a load cell to channel A and put an object on it, note the weight (for example 10KG)
Connect the load cell to channel B, setGain(32) put the same object on it, the weight is not ouput as 10KG, it was 4KG for example.
This is not suitable for my application unless I am missing something.
Thanks,
Matt

Yes, as you change from 128bit gain to 32bit gain I guess the output value form B will be about 25% of A. I don't think there are many people that are using the B channel, if you want to use two load cells the best solution is to use two HX711's, one for ea load cell.

Closed due to low activity.


No documentation on creating custom widgets and adding custom methods.

I'm trying to create a custom element called text_div which is really just a label but with the div tag. We use GWT and much of the html is not proper, but it's not possible to fix now. All I want is to have an element text_div(:thing, id: 'thing') where it creates a method thing() that returns the text of the div.
In the PageObject code it looks like adding a class method accessor_elements should do something, but there is no documentation on how to use it. I've tried a lot of different things but not a single thing has worked. Can the wiki please be updated to show how to make a custom element? Or even the Cucumber & Cheese book showing it would be fine.
This is what I've got so far, none of it has worked
class TextDiv < PageObject::Elements::Label
  def self.accessor_methods(class, name)
    # didn't work
    eigenclass = class << something; self; end
    eigenclass.instance_eval do
      define_method(name) do
        send(name).text
      end
    end
    # didn't work
    something.class_eval do
      define_method(name) do
        send(name).text
      end
    end
    # didn't work
    something.send :define_method, name do
      send(name).text
    end
  end
end
PageObject.register_widget :text_div, TextDiv, 'div'

Turns out this was just me being dumb. send(name) was recursing, as I meant to put send("#{name}_element")


Which pins support PWM?

This board looks idea for a project I'm working on, however I can't see which pins support PWM on the pin-out diagram.
I've tried various options on the board along with analogWrite(<pin>, <valule>); but can't even get a basic LED to fade.
Where am I going wrong?

ESP32 does not support the analogWrite() function. Use the ledcWrite() function. Refer to the official example .

@LilyGO perfect, thanks, this is my first foray into "proper" ESP32 territory, I've been using ESP8266's up until now!


363 validate resolvers

Wondering what need the explicit validateResolvers key would serve. There is low likelihood for an user to configure this. And if the need really comes up, (s)he can use publishConfiguration. Am I missing something obvious?

I agree.  Perhaps just call warnResolversConflict in mkIvyConfiguration without need for a separate task.


Fix integration tests broken by recent PR

Integration tests have broken, likely because we didn't set successful status of integration tests as mandatory gates for merge.
I'll look into how to correctly set up GitHub checks later...

wow this is already the 2024th issue/PR in this repo!

MacOS tests are failing but they are always flaky in GitHub Actions environment. I'll disable that test...


JJ is unshippable

I wonder if I can ask duncan to rig it so my love score is 0 with everyone

https://discord.com/channels/512711766845947922/688775582049239188/1216819017134641275

Can: Yes
Will: no


Docker build fails on COPY api/

Bug Report
Following the Golang Based Operator Tutorial, the step to Build the Docker image fails due to a bug in the Dockerfile.
What did you do?
brew install operator-sdk and followed the tutorial up to the point of building the Docker image:
make docker-build IMG=bndw/test-operator

What did you expect to see?
A Docker image successfully built.
What did you see instead? Under which circumstances?
A failed Docker step to COPY files:
Step 7/14 : COPY api/ api/
COPY failed: stat /var/lib/docker/tmp/docker-builder338415037/api: no such file or directory
make: *** [docker-build] Error 1

Environment
Operator type:
/language go
Kubernetes cluster type:
Kind
$ operator-sdk version
operator-sdk version
operator-sdk version: "v1.2.0", commit: "215fc50b2d4acc7d92b36828f42d7d1ae212015c", kubernetes version: "v1.18.8", go version: "go1.15.4", GOOS: "darwin", GOARCH: "amd64"

Possible Solution
I was able to work around this by updating the Dockerfile to copy ./apis instead of ./api:
diff --git a/Dockerfile b/Dockerfile
index 74eb9d7..a765127 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -11,7 +11,7 @@ RUN go mod download

 # Copy the go source
 COPY main.go main.go
-COPY api/ api/
+COPY apis/ apis/
 COPY controllers/ controllers/

I'd be happy to submit a PR for the above patch if you can point me to the source Dockerfile (I couldn't find it in this repo tree).

@bndw if that changes works, then I assume your PROJECT file has multigroup: true as well? If so, did you run operator-sdk edit --multigroup? That command should have updated your Dockerfile appropriately.

@estroz Yes, I did add multigroup: true to the PROJECT file and didn't realize there was an additional command needed.
I just reverted my manual change to the Dockerfile and tried your suggestion, but hit an error:
operator-sdk edit --multigroup
Error: unknown command "edit" for "operator-sdk"

Did you mean this?
	init

Run 'operator-sdk --help' for usage.
FATA[0000] unknown command "edit" for "operator-sdk"

Did you mean this?
	init

Either way, feel free to close this issue if you believe it's working as designed.

@bndw I referenced an unreleased command, whoops. operator-sdk edit was added in #4156 and will be released in v1.3.