Update kqlmagic.md

Removed reference to Azure Notebook, added reference to Azure Data Studio, and added additional note for passing region in the connection string.

@ManojRaheja : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @ManojRaheja -- This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. Would you make this content update in the private repo instead? Thank you! We'll close this PR.

@ManojRaheja - I pulled your changes into PR: https://github.com/MicrosoftDocs/dataexplorer-docs-pr/pull/1113
I removed the Azure Notebooks file as discussed and created a redirect to the new Azure Data Studio article.
Thanks for your assistance in making the needed changes.


update immediate dependencies

cycled this until the outdated list was empty
cargo outdated -d 1
cargo upgrade somecrate --all

and the list was quite large so giving this a try in a pr.
probably means we have a gap here to get automatic prs for dependency updates

ah, yeah, i was trying to figure that out. weird error.
our setup is the same as tokio's examples, but they also rejected dependabot for completely understandable reasons in https://github.com/tokio-rs/tokio/pull/3744 so maybe it's good to just run this periodically before breaking version bumps.


Recommend installing current agent v1.5.2482.0

We should be encouraging customers to install the latest version of PTA agent which is 1.5.2482.0 1.5.389.0 is over 5 years old and missing several features and improvements available in the most recent version.

@billmath,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Fish Parser Rewrite

Now the fish parser (scripts/fish.py) uses the Data/Locations to correctly obtain the seasons in which the fish are caught (excluding ginger island).

Legends Fish now get the location from Data/Location file

The fishes that are possible to catch in the night market submarine and in a different season are shown as "Winter (submarine)" otherwise it will be only Winter.

created the function utils::get_fish_info that returns the fish information (minimum fish level, seasons) according to the locations where the fish can be caught.

Rewrote utils::convert_time function to fix errors.

Added the new src/fish.json with the new parser fixes.

Fantastic PR, thank you so much!


wallet stuck at [NTP] Starting clock sync...

Linux Mint 19
Navcoin Core 6.1
Always had this issue at any version, any ideas how to fix?
Linux permissions?

Does this issue persist with the lastest build?
Clock sync on latest build should timeout after failed attempt and continue
without ntp clock sync.
On Thu, Jun 3, 2021, 00:40 Pawel Cioch @.***> wrote:

Linux Mint 19
Navcoin Core 6.1
Always had this issue at any version, any ideas how to fix?
Linux permissions?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/navcoin/navcoin-core/issues/846, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIDAKKJXJYWX7WRWQPWLXLTQZNHLANCNFSM457DFZPQ
.

I've got an impression the app just froze, and had to force quit it

I was able to run on windows from VM
Got back to linux,
Tested if I can talk to NTP from terminal
ntpdate -q time3.google.com
This was fine, so
added those two to navcoin.conf
ntpserver=time3.google.com
ntptimeout=10

Log:
2021-06-03 22:09:51 [NTP] Starting clock sync...
2021-06-03 22:09:51 A connection could not be made to any ntp server. Please ensure you system clock is correct otherwise your stakes will be rejected by the networkinit message: Synchronizing clock attempt 1...
And the app stucks on attempt 1 ignoring timeout

I see no problem on Ubuntu 18.04.5 LTS, so something is not right with my Linux Mint, maybe firewall vs DNS discovery of NTP servers.
I guess it's up to me to figure it out

Linux Mint uses systemd-timesyncd for time synchronization. Seems ntpd is being deprecated across multiple distributions by systemd-timesyncd and chrony. Since we cannot continue to rely on ntpclient working correctly on all Linux systems we'll have to account for how to sync time when alternatives are used for time sync on Linux hosts that use alternative time sync services.
https://forums.linuxmint.com/viewtopic.php?t=300466
https://forums.linuxmint.com/viewtopic.php?t=311081


HelloGuiLite display unexpected pixels

When I run BuildLinux/HelloGuiLite /dev/fb0, it shows:

and the command line output:

Why ? Can anyone help?
system: CentOS Linux release 7.6.1810 (Core)  (official minimal installation)
platform:  VMWare 12.5.2 800M RAM

If I set the max resolution of vmware to 640 X 480, then it shows nice (but imcomplete):

The complete nice show is expected to be like this:
https://github.com/idea4good/GuiLite/raw/master/documents/HelloGuiLite.gif

please run in xWindow mode, you can get more detail in readme file


Can I publish a set of snippets to VS Code

I'd like to create a set of snippets of code for .astro files but publishing them would be a pain. Can you please allow me to publish them to vs code. Thanks.

Hey @louiss0, I still don't have a clear vision about this request, can you share more details about what you want to achieve and what limitations the extension has regarding that. Thanks!

Hey @louiss0, I still don't have a clear vision about this request, can you share more details about what you want to achieve and what limitations the extension has regarding that. Thanks!

Never mind


Unable to set totalRows

The onRowsRequest is kinda inconvenient and not elastic enough to use when using React Query for data fetching.
I would like to be able to set totalRows in sync mode but instead totalRows are only able to be set when in async mode which need the use of onRowsRequest but I don't need to use onRowsRequest with ReactQuery.
https://github.com/NadavShaar/react-grid-table/blob/c71ff5b03a1991d9d9b9b756e8170e80e23dce49/src/hooks/useRows.jsx#L34
Whenever I provide the property to the table it should take it no matter if its async or sync mode.
ReactQuery handles all internal data fetching logic and returns the results -> { isLoading, isError, data, refetch }
so I want just to supply the returned data to the react-grid-table via the rows and totalRows but I can't control totalRows in this case which prohibits me of using this like that.

Are you sure that you can't integrate react-query with onRowsRequest?

So I was able to integrate reactQuery using fetchQuery instead of useQuery hook. It works but I wish I was able to use useQuery because with fetchQuery I have to do all error handling manually by myself inside the onRowsRequest and extra flexing around with useRef coz useState behaves very weird and I could not get it working.
I wonder if I could get it working somehow with useQuery tho. Would you mind trying to do some PoC if it would work useQuery?? Maybe Im doing something wrong. With your internal knowledge about react-grid-table maybe you can pull it of?? I would appreciate greatly

I'm not a react-query expert, but i think you should be able to integrate useQuery with onRowsRequest.
if you can share a live example that uses react-query with a basic table implementation I'll try to help.

@NadavShaar Ah sorry for the delay I was really busy.
Here is some repro https://codesandbox.io/s/react-grid-table-async-forked-odt8ii
I can see that data is changing. Request is fired on pagination change but the data of the table itself is not updated.

Fixed: https://codesandbox.io/s/react-grid-table-async-forked-1o3w4h?file=/src/App.js
You should have worked with the refetch function in order to fetch on demand, and disable the auto fetch (unless you need the data for another component).

Oh god... I knew I was missing something! This will simplify a ton of my component. Thanks a lot <3

I have one more problem. How Do i handle the external state with the table.
In order to trigger the useQuery with different values for page,pageSize,name and any other filter I need to have external state that when it changes it setups useQuery with new data. But when the external state change it resets the table and all its components lose the state itself.
I want to handle search and Headers with custom dropdown filters.
For search I managed to pull the search component out of the table components and its state is preserved but I need to manually handle all the details regarding resetting pagination etc. Which again Im doing it wrong and hacking around.
Secondly for my Test select component I can't manage to get the external state to drill down to it. It does update on top level but inside the Test component it doesn;t change why that could be ?
https://codesandbox.io/s/react-grid-table-async-forked-t5bhmh?file=/src/App.js

@NadavShaar
If I pass the external state to the additionalProps then I can access it in test component and update the select value accordingly but this feels wrong and hacky.
https://codesandbox.io/s/react-grid-table-async-forked-0wr7j1


[WIP][SPARK-45153][BUILD][PS] Rebalance testing time for pyspark-pandas-connect-part1

What changes were proposed in this pull request?
This PR proposes to rebalance the tests for pyspark-pandas-connect-part1.
Why are the changes needed?
We rebalance the CI by splitting slow tests into multiple parts, but pyspark-pandas-connect-part1 takes almost an hour than other splitted pyspark-pandas-connect-partx tests as below:

pyspark-pandas-connect-part0
pyspark-pandas-connect-part1
pyspark-pandas-connect-part2

1h 51m
2h 55m
1h 54m

Does this PR introduce any user-facing change?
No, this PR is proposed to improve the build infra.
How was this patch tested?

We should manually check the CI from GitHub Actions after PR is opened.
Was this patch authored or co-authored using generative AI tooling?

No.

Thank you for keeping improving this, @itholic .

Result summary:

pyspark-pandas-connect-part0
pyspark-pandas-connect-part1
pyspark-pandas-connect-part2
pyspark-pandas-connect-part3

1h 55m
1h 56m
1h 50m
1h 32m

Now each tests run within 2 hrs. I think it seems to be better balanced than before.
cc @HyukjinKwon @dongjoon-hyun WDYT?

Merged to master for Apache Spark 4.0.0.


Feature Request: Support for lemon squeezy payment option

I like the template a lot. It would be awesome to have a lemon squeezy payment integration option. I would love to use stripe but it's  not supported In my country (india). If possible I would try to do the code for it as well.

Sounds good! I'll ping the Lemon Squeezy team on X to see if they're keen to collab on a guide.

Done! Let me know if you get stuck or need any further documentation.
https://docs.next-forge.com/migrations/payments/lemon-squeezy


refactor: Make fetching DRY

The three fetching functions have been merged into one fetchData function. Some names and code has been refactored around for cleaning up as needed. The only change that may not be obvious on why: init has been moved out of the fetchServerData to domUpdates.js because it makes the code more SRP.
Closes #34

Nicely done, Charles.


Introduce separate rosetta debian

Split daemon debian into rosetta and daemon one. Then, used both in mina rosetta docker

!ci-build-me

!ci-build-me

!ci-nightly-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me


Play again button

Perhaps a sticky bar at the top when the game has finished?
Could also be combined with stuff like watch replay and show information about how the game ended.

Could be put at the top of the PlayGame component


fix 14478: support non-copyable elements in many range algorithms

same as #8714
code not fully covered

@WebFreak001 the testers are failing. Are you willing to push this to the finish line?

thanks!

Thank you!

This PR results in issues at Weka with retro for a struct that has void opAssign()(auto ref const(typeof(this)) that) const defined, i.e. a struct that allows const assignment. The problem is that assignment is allowed, but move is not (because it would be a memcpy to const memory).
The cause of the problem: retro checks for hasAssignableElements, but then does a move rather than an assignment.
https://github.com/dlang/phobos/pull/8721/files#diff-705ed5d9f4ea4f9dadcb07d7116df8dc8397e851639a28538dc0b1d6fa446f56L312-R318
Testcase:
import std.range;

struct Handle {
    int[5] entries;
    void opAssign()(auto ref const(typeof(this)) that) const { }
}

const(Handle)[100] arr;
auto foo() {
    return arr[0..5].retro;
}

the problem is fixed by reverting the lines for retro.

This PR results in issues at Weka with retro for a struct that has void opAssign()(auto ref const(typeof(this)) that) const defined, i.e. a struct that allows const assignment. The problem is that assignment is allowed, but move is not (because it would be a memcpy to const memory).

Aside from anything to do with the specific changes here, what does a const opAssign even do? Conceptually, that seems like it would be illegal, because mutating const violates the type system (though without the compiler having extra checks to prevent it, it makes sense that opAssign would be treated like any other function in its ability to be const). Is this opAssign casting away const to mutate anyway? Or is it just mutating something outside the object instead of the object itself? Or is not actually doing any kind of assignment?

Aside from anything to do with the specific changes here, what does a const opAssign even do?

It's used to enable assigning to a const(Handle!Block) as if it is a Handle!(const(Block)), and it's indeed writing to something outside the object. There could be better solutions, but "it worked" before...

Aside from anything to do with the specific changes here, what does a const opAssign even do?

It's used to enable assigning to a const(Handle!Block) as if it is a Handle!(const(Block)), and it's indeed writing to something outside the object. There could be better solutions, but "it worked" before...

I'm not trying to argue against changing the Phobos code. I'm just trying to understand why anyone would be doing anything with a const opAssign, since at a glance, it seems like something that's violating the type system.
Regardless of the details of your code, you've clearly shown that retro's template constraint is wrong, because it checks for one operation and then does another instead.

The hasAssignableElements is used in most of the range operations I touched in this PR, should all of them be changed as well?

I'll have a PR for this in a bit.

https://github.com/dlang/phobos/pull/8969

#8969

thank you!


Error when using custom mapping on Typescript

🐛 Bug Report

To Reproduce
Steps to reproduce the behavior:
using custom mapping
Expected behavior
no error message

Link to runnable example or repository (highly encouraged)

{   "components": {     "Input": {       "meta": {},       "appearances": {         "default": {           "variantGroups": {             "status": {               "basic": {                 "labelColor": "text-basic-color",                 "borderColor": "background-color",                 "backgroundColor": "input-background-color",                 "state": {                   "focused": {                     "borderColor": "background-color",                     "backgroundColor": "input-focused-background-color"                   },                   "disabled": {                     "backgroundColor": "input-background-color"                   }                 }               }             }           }         }       }     }, } }

UI Kitten and Eva version

Package
Version

@eva-design/eva
2.1.1

@ui-kitten/components
5.1.2

Environment information

try this
customMapping={{ ...eva.mapping, ...customMapping }}>

@rayhk6 hey! from your custom mappings snippet it seems that the problem is in your mappings. as I can see meta field is empty, which is required to describe parameters which may be configured for current component. please check CustomSchemaType type it describes interface expected as custom mappings. also you can check eva default mappings as a reference. perhaps there is inconsistency with documentation, but from source code side it seems all meta fields a required (even in case of overriding existing components).

@rayhk6 I have checked applying custom mappings with the snippet you had provided and I can confirm that describing mappings properly (e.i. according to declared interface) makes ts validation being correct. we'll check if our docs are outdated for custom mappings, but for now I'll close this ticket.


Change link on the support page for commercial support

The home page has a box 'Commercial Support' - the link goes to https://rancher.com/support-maintenance-terms/ - it should instead take the user to the support page.

This was done by Richard for the about page change


Environmental Ontology Term Requests

This issues serves as a tracking for terms that we require (e.g. under material) but do not currently fall under EnvironmentalOntology

[ ] pelvic sediment
[ ] burial (sediment/soil)
[ ] grave (sediment/soil)

For Uberon:

[ ] dental calculus

For Uberon:

[ ] osteocrust (see McDonough 2018 10.1093/jmammal/gyy080)


Debug writer

DebugWriterTool - simple app for getting basic info about PC/Mac when using CFD.

Is this still being worked on?


Update architect-orb to 2.1.0

Towards giantswarm/giantswarm#15898

@mig4 can we archive this repository or do you plan to continue working on this operator?

Yip, we can archive, I'll take care.


slow average response time

I can't understand what is it:
Sinatra: Refile::App/GET ([^/?#]+)/([^/?#]+)/([^/?#]+)/(.*?)/([^/?#]+)/((?:[^\./?#%]|(?:%[^2].|%[2][^Ee]))+)(?:\.|%2[Ee])((?:[^/?#%]|(?:%[^2].|%[2][^Ee]))+)
http://cl.ly/image/3U1n1T1D403r

Processing images and streaming files is slow. I don't know if that's supposed to be surprising?

can I cached files after processing?

@eddiefisher you could taken advantage of a CDN. The request URL for your images stays the same, so they are cached. There some explanation in the project readme file.
I also setup my app that way using AWS Cloudfront, it works pretty good.


API: Follow PEP8 naming (sumAll -> sum_all).

I noticed this while writing release notes. Since it hasn't been in a release yet I think
we should fix the name.

Mixed on this, we do consistently use _ in component names elsewhere, it has been pointed out by Claudio that we also use _ as the joiner to replace '.' in the default names so parent_long_child_name_grand_child is impossible to tell where Device edges are.

This would be the first place we break PEP8 conventions for component names and the ~100th place we reinforce the problem flagged by Claudio. He raises a good point, but I'm not inclined to spend long musing on this on release day.

Thanks, @stuartcampbell.
@tacaswell I made a separate issue about Claudio's point so we can discuss it in a less rushed moment.


negative signs missing. Can't tell if transaction is income or expense

Either money leaving your accounts should be a negative number, and money coming in should be a positive number, or vice versa. But currently, there seems to be no way to tell income and outgoing money apart
For example, I purchased something for $10, and then returned it for a refund. On the mint website, I see my purchase as -$10, and my return as $10, so they cancel out. But using this tool, both my purchase and my return have $10 as the amount, making it seem like I bought it twice and spent $20

Nevermind, just noticed the transaction type is credit if it's income, and debit if it's an expense. Credit and debit does not refer to whether a transaction was made with a credit card or debit card like I assumed it meant


Cannot read property 'remove' of undefined.

Azure Data Studio Version: Versión 1.5.2 (1.5.2)

When I change Query Tabs. Close all the tabs and for each tab indicate the error of the:
Cannot read property 'remove' of undefined.

Closing older issues that don't have recent repros.  The shell code in ADS has changed significantly since this issue was created.  Please let us know if the issue persists on current builds.


[Fix] no-unused-prop-types with typescript eslint parser

Hi there,
This is a first draft to solve https://github.com/yannickcr/eslint-plugin-react/issues/2569
I would be thankful if someone involved in this rule creation could give feedback about edge cases to be handled (spread operator, etc.). I am afraid to have forgotten some...
Thank you !

ok I pushed a new version with :

flatMap
handling interfaces props declaration (and a test)
better variable names

ok, I don't get how to make flatmap work :(

@eltonio450 i can fix the branch, but since you made the PR from ovrsea and not from eltonio450, i can't. can you add me to https://github.com/ovrsea/eslint-plugin-react so i can force push to it?

done :) thank you :)

thank you !

no no, thank you!


[WIP] Integrate Horovod training API as part of MXNet native distributed training API

Description
Integrate Horovod training API as part of MXNet native distributed training API by making Horovod one special type of KVStore as proposed in https://github.com/apache/incubator-mxnet/issues/16795
Part of MXNet 2.0 project tracked by https://github.com/apache/incubator-mxnet/issues/17111
Checklist
Essentials
Still need to debug the integration tests core dump.

@chaokunchang FYI


Clarified a paragraph on "hot" partitions

Clarified a paragraph on Hot partitions to hopefully better convey cause and consequences of picking wrong partition key

@tkhadimullin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@SnehaGunda: I'm sorry - only the author of this article, @deborahc, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Repeated error HTTPError 429 Client Error

I'm trying to get POSTS (without media) and comments from a user on Instagram.
How I'm running it:
instagram-scraper vip -u me-the-stalker -p password --comments --media-types none --no-check-certificate
What I get:

Just tried again and again, and finally got it working. It seems that my rate of requests has been too high and the server was not willing to accept it.

I figured out why it was actually happening. It was because I was trying to access Instagram pages from the browser at the same time.

I notice this same error consistently every time with only -i -u -p and --comments but only for some users, such as miia_draws_
Adding --verbose 2 shows the error appear several times more during the querying process.


Gap analysis: evaluate chrisproject.org against Open Source Way 2.0 guidelines

The Open Source Way is a nice guidebook on how to run effective and collaborative open source communities. We would like to have the current https://chrisproject.org evaluated against The Open Source Way's guidelines (some of the guidelines in the book specific to project websites are in this section: https://www.theopensourceway.org/the_open_source_way-guidebook-2.0.html#_communication_norms_in_open_source_software_projects but there are many throughout the book that would be relevant for ChRIS.)
A successful outcome for this ticket would be a checklist list of actionable items where we could do better along the Open Source Way's guidelines with references to The Open Source Way passages for each. For example, The Open Source Way mentions social media as a good way to get the word out about a project community - ChRIS does not have a social media presence. So you might recommend we consider creating a social media presence on specific platforms.

@mairin how can I fix this issue ?

The points below are some of the ways ChRIS can implement some of the guidelines provided in The Open Source Way:

Create a social media presence on specific platforms to provide an avenue for upcoming advertising events, live streaming of content, marketing, and technical support.
Add a frequently asked question (FAQ) section to ChRIS website.
Have a project roadmap to document goals.
Get more out of the issue tracker on GitHub by using issue templates to enable contributors to know the community convention for filing a helpful bug report.
Create a glossary of commonly used terms for easier communication
Translate the documentation to other languages to make the project more accessible.
Create a code of conduct to document expectations around the civil discourse.

@mairin @jennydaman


Improvement suggestions

Great software, some feedback:

would be nice to have an ability to hide Desktop/Downloads/etc. altogether
initially the app doesn't have permission to access drives, so it doesn't show any of them, perhaps it would be nice to suggest granting the permission on first start
favorite directories

We plan on an option to unpin favorites.
We plan on adding a dialog for this, however I should point out that the next version of Windows will no longer require you to give access for the file system.
Can you elaborate what you mean by this?

Thanks for the answers!

Can you elaborate what you mean by this?

basically have a quick access panel with bookmarked directories like we have in browsers.

basically have a quick access panel with bookmarked directories like we have in browsers.

You can already pin directions to the Quick Access pane on the sidebar.

This issue has been resolved with the latest release in the Microsoft Store v0.10.0.


Fix 17: split_string()

Fixes #17

Logic was corrected by @cbeleites in https://github.com/r-hyperspec/hyperSpec/commit/dbbad96b7d0c52f73996639e75feace2951458bf

Instead of throwing error:
Warning message:
In length(pos) == 1 && pos[[1]] == -1 :
  'length(x) = 11 > 1' in coercion to 'logical(1)'

Gives a correct result:
y <-
  hySpc.read.spc::read_spc(
    filename = system.file("extdata/1.spc", package = "ir"),
    log_txt = TRUE,
    log_bin = TRUE,
    log_disk = TRUE,
    keys_hdr2data = TRUE,
    keys_log2data = TRUE,
    no_object = FALSE
  )
hyperSpec::plot(y)

Created on 2022-07-15 by the reprex package (v2.0.1)

@cbeleites , can you, please, find out why this PR fails on Linux and R-devel on CI?


Community - Games

Description

Let’s make the folder community /games be a place where all the cool games people have come up with.
I think it can be linked to by the main index.ipynb but I let @quantumjim come up with how this folder should be arranged.  The goal should be how to learn qiskit and quantum computing though games.
Landing from the main file
3.2 Quantum Games with Qiskit¶
Learn quantum computing by having fun. How is there a better way!
Your Environment

QISKit version:
Python version:

@quantumjim should we close this now and then you can open another one later for changes or make a project for it if there is lots of planning remaining.


Fix FTP file descriptor leak

This PR addresses the issue as described in #2108

Thanks @Zhumos. I'm pretty sure this is already resolved in #2060. We might want to make a bugfix against the v1.4 branch though. Do you mind making a PR against v1.4 instead?


Register for any handler

Hi
I used to use the version 4 where I could do this:
self.bridge = [WebViewJavascriptBridge bridgeForWebView:self.webview handler:^(id data, WVJBResponseCallback responseCallback) {
            [self methodToProcessData:Data];
}];

Which it used to make me easier because I register for any handle and in the block I process the data.
With the current version I have to duplicate code:
        [self.bridge registerHandler:@"bla" handler:^(id data, WVJBResponseCallback responseCallback) {
            ...
            [self methodToProcessData:Data];
        }];
        [self.bridge registerHandler:@"more bla" handler:^(id data, WVJBResponseCallback responseCallback) {
            ...
            [self methodToProcessData:Data];
        }];

Can I do it like in the past and get the method called for any call sent? So I will process the data when is sent.
Thanks in advance :)

I'd suggest:

On JS side, create a sendWildcardData wrapper function which calls callHandler('wildcard')
On ObjC side, create a wildcard handler which calls[self methodToProcessData:data]


CYF London | Nadika Zavodovska |  Module User Focused Data | Week 1

Learners, PR Template
Self checklist

[x] I have committed my files one by one, on purpose, and for a reason
[x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x] I have tested my changes
[x] My changes follow the style guide
[x] My changes meet the requirements of this task

Changelist
I have created a webpage about Git that contains three articles. I used HTML5, CSS3, and Web Design to develop this webpage.
Questions
Are my commit messages well written?
Thank you!

Welcome to ITP! Congratulations on your first Pull Request! 🎉
It's a wonderful start, @nadika-zavodovska ! You can see your work deployed on a PR preview here
https://deploy-preview-189--cyf-ufd.netlify.app/wireframe/
for your question: yes your commits msg looks good


Fix #496 issue with load_ard

Proposed changes
@lauragow picked up an issue with the load_ard function where the function failed when no measurements were specified. This was caused by Sentinel-2 and Landsat ARD data loading ancillary variables (e.g. fmask, contiguity) with different names by if no measurements are specified:

Landsat: oa_variable_name
Sentinel-2: variable_name

To fix this, I've added a test at the beginning to test whether the user is loading Landsat or Sentinel-2 data. Hopefully a future Sentinel-2 collection upgrade will make the variable names consistent!
Closes issues (optional)

Closes Issue #496

Hey @lauragow , feel free to accept then 'squash and merge' this - I think it should fix the problem you were having!

Thanks @robbibt. I'll test it now and let you know if I have any problems.

Looks like that fix worked fine @robbibt. I had no problems. Thanks


Game Initialization

Game Initialization Procedure

backend publishes on RabbitMQ topic
first player clicks ready button -> REST call to backend (incl. player ID) -> listen on queue
second player clicks ready button -> REST call to backend (incl. player ID) -> listen on queue
backend publishes event {'playerIds': [23, 10]} on queue with two relevant ID's of players -> initializes game state logic
two players switch into game view
requests according to game state machine

Backend RabbitMQ implementation
https://kennay-kermani.medium.com/simple-pub-sub-implementation-with-spring-boot-docker-and-rabbitmq-4ed7461de239
Frontend RabbitMQ implementation
...

description should be adjusted to WebSocket rather than RabbitMQ I guess

Done via WebSockets, see e.g. #82, #110


UND_ERR_HEADERS_TIMEOUT 访问经常返回

Verify latest release

[X] I verified that the issue exists in the latest chatgpt release

Verify webapp is working

[X] I verify that the ChatGPT webapp is working properly for this account.

Environment details
centos
Describe the Bug
0|main  | send error: TypeError: fetch failed
0|main  |     at Object.fetch (node:internal/deps/undici/undici:11404:11)
0|main  |     at async file:///tmp/18890990/chat/node_modules/chatgpt/build/index.js:265:25 {
0|main  |   cause: HeadersTimeoutError: Headers Timeout Error
0|main  |       at Timeout.onParserTimeout [as callback] (node:internal/deps/undici/undici:9596:32)
0|main  |       at Timeout.onTimeout [as _onTimeout] (node:internal/deps/undici/undici:7899:17)
0|main  |       at listOnTimeout (node:internal/timers:568:17)
0|main  |       at process.processTimers (node:internal/timers:511:7) {
0|main  |     code: 'UND_ERR_HEADERS_TIMEOUT'
0|main  |   }
0|main  | }

请问这个有什么解决办法

@youminxue this may be due to https://github.com/transitive-bullshit/chatgpt-api/issues/419

我的服务部署在国外的机器上，应该不是类似的问题，而且不是所有的请求都这样，复杂的问题比较容易出现。

@youminxue it's likely that the IP you're using has been blocked for some reason.
Also see #453

openai在封锁商用行为，需要研究一下如何解决

This project is undergoing a major revamp; closing out old issues as part of the prep process.
The chatgpt package is pretty outdated at this point. I recommend that you use the openai package or the openai-fetch package instead.


Fix: #2071 - OrderBy() not translating to SQL ORDER BY?

Improve translation of Distinct such that OrderBys are preserved when the ordering columns are present in the projection.

@maumar @mikary

:shipit:


Add ARM test suite trigger commands to mass comment script

Add new trigger phrases for all post commit ARM test suites.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

i think we should add commands into a text file for consistency and simplicity; there is jenkins_jobs.txt. @damccorm should we rename that or there is some advantage to split Jenkins and GH actions trigger commands in separate files?

@damccorm should we rename that file to smth like test_trigger_commands.txt or there is some advantage to split Jenkins and GH actions trigger commands in separate files?

I think splitting into separate files makes sense. Jenkins triggers can be programatically determined (and we do that to update them as part of our release process) so having a distinct file for them makes management easy

Run Go PostCommit Dataflow ARM

Run Go PreCommit

Here is the console output for mass_comment.py which will give the hint needed to fix this:
...
('Run PythonFormatter PreCommit', 'beam_PreCommit_PythonFormatter_Phrase')
('Run PythonLint PreCommit', 'beam_PreCommit_PythonLint_Phrase')
('Run RAT PreCommit', 'beam_PreCommit_RAT_Phrase')
('Run Spotless PreCommit', 'beam_PreCommit_Spotless_Phrase')
('Run Typescript PreCommit', 'beam_PreCommit_Typescript_Phrase')
('Run Whitespace PreCommit', 'beam_PreCommit_Whitespace_Phrase')
Run Go PostCommit Dataflow ARM
Run Java_Examples_Dataflow_ARM PostCommit 8
Run Java_Examples_Dataflow_ARM PostCommit 11
Run Java_Examples_Dataflow_ARM PostCommit 17
...

I see the issue, going to fix along with #28665


Handling forms within live.

Description
As required by the issue, a new class Live::Form has been created for the server side handling of forms, it is a child function of Live::View. Live::Form provides a new class variable @recieved_form which is a serialized hash version of the form data. This PR also comes with a fix for the details argument not being passed properly. Two new javascript Live class functions are added for clientside handling of forms, see the live-js PR.
Types of Changes

New feature.

Testing
I tested my changes locally.

It looks good to me so far, I've given you some feedback.


try to remove linearly dependent states

Try to get rid of the linearly-dependet basis functions during the orthogonalization phase.

I introduced a debug variable project_out_here. If true, the projection and filtering of new basis functions (preconditioned residuals) happens in davidson(). If false - in wf_ortho(). They should be identical! However, they are clearly not. In first case the davidson fails to converge, in the second (which is a default for the main branch) - it converges. To test, run test_davidson --num_bands=8`


[zfs send -w] Support sending encrypted datasets

Raw sends are incompatible with multiple features of zxfer like backing up
properties or sending encrypted datasets to older OpenZFS versions.
Nevertheless zxfer is still very useful in these cases due to the snapshot
handling logic, the newly added -w flag specifies that zfs send should perform
raw sends.
No checks are performed on either side as to whether or not they support these
flags, zfs (send|receive), and therefore zxfer will fail when it's not the case.
This patch has been tested, not to affect other workflows negatively and it works for the intended use-case. Sadly I currently lack the time to polish it some more and check more potentially incompatible flags.
This might also be considered to close #23.

This is exactly what I was looking for, thanks @evilham!

That's great, if you do test the patch, and it works for you, please also provide some feedback; it'd be useful.
(I assume that if it doesn't work you'll come back anyway :-p)

Evilham: thanks for this. If you have time, could you do up a 2nd one that expands on the $sendflags concept you used, but is more generic. basically add 2 new command line flags, that let you specify the send or recv flags.
There are cases where you want to be able to set the recv flags to 'do not mount', or, where you want to use the new OpenZFS 2.0 feature where you can override a property like encryption or compression.

@allanjude That'd make sense, the biggest issue I have is... Picking the flag letters >,<...
Since oOrRsS are all being used, the next thing that came to mind is zZ. but then that'd raise the question of which one is send and which one receive.
Suggestions?

Added a preliminary implementation of -z for send flags and -Zfor receive flags.
Haven't tested it yet, but the changes are mostly straightforward.
Notably manpage and USAGE texts still have to be updated, it'd be great if someone could help with that <3.


IsMaximizable Ignored When Content Extends into Title Bar

Describe the bug
AppWindow::Presenter::IsMaximizable is ignored when MainWindow::ExtendsContentIntoTitleBar(true);

Steps to reproduce the bug

New Blank WinUI 3 Project
MainWindow::ExtendsContentIntoTitleBar(true)
Get the AppWindow using <winrt/Microsoft.UI.Interop.h>
Get the AppWindow::Presenter
Set Presenter::IsMaximizable(false);

Expected behavior
The maximize button should be disabled the same as when the content is not extended into the title bar.
Screenshots
See above
NuGet package version
Windows App SDK 1.2.4: 1.2.230217.4
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

Could you share your code to reproduce the bug?

Yep. Give me a few mins. I'll push a branch and link it here.

Here you go.
https://github.com/jamespack/IsMaximizableBug

I cannot resolve the  bug, but I will share information related to AppWindow.
https://github.com/microsoft/microsoft-ui-xaml/issues/7628
https://github.com/microsoft/microsoft-ui-xaml/issues/8201

Thanks for the material. I was able to get it working by setting an empty custom titlebar and setting its ExtendsContentIntoTitleBar property to true. Thats a hack though. Id still say this is a bug unless the intention is to remove this api at some point in favor of the AppWIndow api.

With a hopefully improved AppWindow API :)

Unfortunately, there are 2 different "ExtendsContentIntoTitleBar" right now:

WinUI 3's custom title bar in Microsoft.UI.Xaml.Window class
AppWindow's custom title bar in Microsoft.UI.Windowing.AppWindowTitleBar

Since the IsMaximizable property is set on an AppWindow presenter, you would need to use appWindow.TitleBar().ExtendsContentIntoTitleBar(true); for it to function properly.
We might look into merging some of these title bar customization options in the future, so that the API surface is easier to use and unambiguous.

The entire window/title bar api is kind of messy. I know it's still relatively early. So hoping that improved over time. Over all super excited about Windows Apps and the future for windows devs!

I hit the same and had a user report this in WinUIEx as well. The IsMinimizable and IsMaximixable does gray out the buttons, but they are still fully interactive.

Unfortunately, there are 2 different "ExtendsContentIntoTitleBar" right now:

WinUI 3's custom title bar in Microsoft.UI.Xaml.Window class
AppWindow's custom title bar in Microsoft.UI.Windowing.AppWindowTitleBar

Since the IsMaximizable property is set on an AppWindow presenter, you would need to use appWindow.TitleBar().ExtendsContentIntoTitleBar(true); for it to function properly.

Thanks for saving my life.

Closing this as duplicate. microsoft/microsoft-ui-xaml#8666 looks like a direct duplicate which we have an internal tracking issue for.


⚠ Bofrost.lu has degraded performance

In e4c7b21, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1127 ms

Resolved: Bofrost.lu performance has improved in 0131a4d after 6 minutes.


"ValueError: operands could not be broadcast together with shapes"

Hi!
I try to use your script to align a stack of photos. It works great, but after about 70 pictures, the script stop and I get this message. I tried skipping a few pictures, but it did not help. Unfortunately, I'm not sure how to proceed to debug this myself.
Traceback (most recent call last):   File "../pada.py", line 148, in <module>     img_thresh=cfg['img_thresh'])   File "/home/ubuntu/face-align/pada/align.py", line 177, in align_images     for idx, (n, im, lms) in enumerate(ims_and_landmarks):   File "/home/ubuntu/face-align/pada/align.py", line 111, in get_ims_and_landmarks     for n, im in images:   File "/home/ubuntu/face-align/pada/align.py", line 48, in read_ims     if prev_im is None or numpy.linalg.norm(prev_im - im) > img_thresh: ValueError: operands could not be broadcast together with shapes (3264,2448,3) (4032,3024,3)

This issue is that your input images are of varying size.  The code was originally written for processing video input (ie. where all the frames are the same size) however there's no reason it can't be adapted to suit sequences of images.  Can you try changing the condition to:
if (prev_im is None or prev_im.shape != im.shape or
numpy.linalg.norm(prev_im - im) > img_thresh):
...and reply letting me know if it works?

Oh. That makes sense - I changed my camera after about a month and forgot about it.
I tried changing that same line to a very simple "if 1:", which stopped the errors, but I frankly don't really know what that does. I did not yet see the output that I got from that change.
I'l try your proposition as soon as I can and I'll let you know. Knowing the source of the issue, I may just "make sure" that all my pictures are of the same size (by padding them with black if needed).
Thanks for your fast answer! I'll let you know if it fixes it.

@matthewearl I tried that but the landscape image is way out of position from the just previous portrait image. The subsequent landscape images are all aligned correctly.
Is there a way to solve this ?
Thank you :)

I ended-up resizing all my images in Photoshop so they have the same size (adding black letterbox/pillarbox/allaroundbox if needed). The script then aligned them correctly (and I re-cropped them to save space after that).
With that said, I'm sure there's a better solution 😉

@maximepriv Thank you ! That fixed it. I made a Python script to resize the images : https://github.com/subins2000/SelfieADay

Yay!
It'll be great to scan the inputs to find the largest width/height and use that as the new image size while resizing (or trying to change the original script so it'll work with multiple image file), but I usually just do it by hand - that works well enough for my limited use.

@maximepriv Update: I modified that image resize script to adjust with different sizes too. In my project, I change my camera in between, the resolutions got different, but the script still works.


[Suggestion] Support GCC 4.8

Quite a number of institutions and companies are still running on RHEL 7 / CentOS 7 which runs GCC 4.8. It would be great if brew could lower the minimal requirement for GCC from 4.9 to 4.8. I could cook up a new PR if the team is happy to support.

Please always fill out the issues template @runlevel5!
For suggestions Discourse is probably a better bet (or, perhaps, the feature request template).
Closing but will let @Homebrew/linux chime in with thoughts.

I will post this on discourse. Cheers

@runlevel5 GCC 4.7 or later is new enough to build glibc 2.23, which is a hard requirement, unless you are able to install in /home/linuxbrew/.linuxbrew, in which case you don't need any compiler at all. Then brew install gcc will install GCC 5, and you're off to the races. Open an issue and tag me if you have encounter an error installing Homebrew.

I've created a new thread in the discourse https://discourse.brew.sh/t/suggestion-support-for-gcc-4-8/7632
Please continue with the discussion there.


Update done command

fixes #228

Coverage decreased (-0.07%) to 54.871% when pulling 39fda1f01307f03b675e65c70eaa795fea8ed05e on Drashti96:update-Done_command into cfc7051c8f7614439d51a1141133cfa39d62ca68 on CS2103AUG2016-W15-C4:master.


Use of att.slashCount and definition of data.SLASH

There is an inconsistency with mensur@slash and<EMAIL_ADDRESS>(defined in att.mensural.vis, namely that the first is a member of att.slashCount  for @slash while att.mensural.vis defines mensur.slash directly as a <rng:data type="positiveInteger"/>.
The other question is the definition of data.SLASH used by att.slashCount that reads The number of slashes to be rendered for tremolandi., which obviously does not make sense.

data.SLASH was originally used for tremolos (see a6f4335), and obviously only reused for mensural notation. As the model has been changed for tremolos it should be time now to have a better data type here.
In the literature I didn't find more than three lines mentioned, so maxInclusive should be 3 in this case. Also, nobody seems to write about slashes, but strokes. So maybe data.STROKE or data.MENSURSTROKE would be more appropriate?
Furthermore looking at the respective SMuFL range I wonder if there should be the possibility to encode the direction of the strokes.
Any comments from @annplaksin or @martha-thomae?

@rettinghaus, a search of the web shows that "stroke" and "slash" are often used interchangeably, as in this passage from the Wikipedia article on "tremolo" --
In musical notation, tremolo is usually notated as regular repeated
demisemiquavers using strokes through the stems of the notes. Generally,
there are three strokes, except on notes which already have beams
or flags: quavers then take two slashes, and semiquavers take one.

I haven't performed an extensive analysis, but perhaps "slash" is used more in the lay community and "stroke" is used by those who want to sound more "professional".  However, it's an overstatement to say "no one" uses the term "slash".  That being said, I don't think it matters which term is used for tremolo notation as long as it's well-defined and employed consistently.  Just in case it needs saying, I don't recommend, however, replacing the term "slash" with "stroke" in the context of rhythmic slash notation; that is,

Yes, @pe-ro, but we're not talking about tremolos or repeats anymore, this is only about mensural music now.


DBZ-5386 Missing "previousId" property with parsing the rename statement in kafka history topic

https://issues.redhat.com/browse/DBZ-5386

@harveyyue Applied, nice example of defensive coding!


Netbird UI Windows RPC Error

Describe the problem
A clear and concise description of what the problem is.
If I want to connect to the UI, I can still enter my password and the error message shown below opens.
To Reproduce
Steps to reproduce the behavior:

Connect to Server via UI and then the Error commes.

Are you using NetBird Cloud?
Please specify whether you use NetBird Cloud or self-host NetBird's control plane.
Self-Host Netbird Control Plane
NetBird version
0.27.4
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

did you fix it?

Also getting this error

Even I had the same issue, it could be some other services/clients are using same  Host Network Service.
I tried the below to fix it.
Open Powershell/ Command Prompt in Administrator mode.
net stop hns
net start hns


License type

Can you add license to repo?.
I need add this library to my thesis, but i cant add if have no license.

I have added a license file.


Make summon environment

Suggesting a new environment, similar to "parking-v0", with the following changes:

Vehicle starts in a particular parking spot
Parking lot is populated with random vehicles (either in the "middle lane" or in other parking spots)
Goal is in the "middle lane", either to the left or right side of the parking lot.

This gym environment could be a useful way to train "Summon" type behavior (a la Tesla).
I think it should be ready, but please review to see what changes you may need to add this to the repository.

Hi @vinnnyr, I love your idea!
One remark: instead of creating this ParkingVehicle class, you could just set their target_velocity to 0.
But I'll just merge this pull request and propose some refactoring.
Also, why did you choose to have them accelerate randomly?

Hi @eleurent , thank you! Sure, I can work on refactoring this environment to align with your proposed changes. Be on the lookout for another request.

Also, how do you generate the GIFs in the readme? I should also update that to include the new environment.

I pushed a few modifications, you can iterate from there.
About the gifs: I generate MP4 videos with the usual gym.Monitor, and then convert them to gif with ffmpeg.


feat:[CDS-99130]: Add info for new pre-flight check in doc

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6696168ee850a145264bbb5f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://669616f9e850a1445f4bbc43--harness-developer.netlify.app


Type any passed in callback argument, when defined in type parameter that use another type param that is populated by parameter with different structures (array or object).

I have function example:
/**
 * @template {string} N
 * @template {(obj: {
 *    [key in N]: Something
 * }) => unknown} F
 * @param {N[] | {
 *     names: N[],
 *     func?: F
 * }} opts
 * @returns {F extends () => infer R ? R : {
 *    [key in N]: Something
 * }}
 */
function example(opts) {
    const { names = [], func } = Array.isArray(opts)
        ? { names: opts, func: null }
        : opts || {}

    let something = createSomething(names)

    something = func ? func(something) : something;

    // this doesn't mutate `something` variable.
    some_more_logic(something);

    return something;
}

when I call it like:
const test1 = example(["a", "b", "c"]);
const test2 = example({
    names: ["a", "b", "c"]
})
const test3 = example({
    names: ["a", "b", "c"],
    func: (obj) => obj; // this doesn't make sense, but for example it's fine
})

test variables 1 and 2 have correct type, but type 3 has type any (because obj is alredy type any), when I return something else in func, it will infer type correctly.
But when I change:
--- * @param {N[] | {
+++ * @param {
    *     names: N[],
    *     func?: F
    * }} opts

and remove test1 example (because is invalid), both test2 and test3 have correct type, as well as obj in func callback.

To expedite the triage process, we need everyone to follow the issue template and instructions.
When you clicked "Create New Issue", the issue form was pre-populated with a template and some instructions. We need you to read those instructions completely, follow them, and then fill in all the fields in that template.
We are not able to assist with issues that don't follow the template instructions as they represent a significantly larger amount of work compared to issues which are correctly specified. Thank you for understanding.


Add batch window

Description:
Batch window is different from length window. The batch window splits incoming events into the given maximum batch size and if the number of events left for the last batch it doesn't wait to fill it, rather they are returned.
Sample:
from TempStream#window.batch(10)
select avg(temp) as avgTemp, roomNo, deviceID
group by roomNo, deviceID
insert into AvgTempStream;

If TempStream contains 23 events, then above batch window will produce 10, 10, and 3 event batches.
Affected Product Version:
Siddhi v4.x.x

Still pending to implement support for batch size.

Closing the issue as it is fixed by Buddhi.


support ujson v3 (part 2)

This is the same that @sroet did in #917. I only added the ujson_kwargs to another call to ujson.dumps.

Looks good to me. Also looks like you need to associate an email GitHub knows about with the git config on the computer where you did this ;-)

Good catch!...I have too many e-mails and GitHub did not know yet about this one :)


Bootstrap 5 fixes 1

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-oss-check/30/ : SUCCESS in 4s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-oss-check/31/ : SUCCESS in 4s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-oss-check/32/ : SUCCESS in 4s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-oss-check/33/ : SUCCESS in 4s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-oss-check/34/ : SUCCESS in 4s

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-fossa-scanning-oss-zuul/23/ : SUCCESS in 34s (non-voting)
https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-merge-compliance-check/8/ : SUCCESS in 10s


Figure out if we need more distinct error types or fewer

Right now we have some errors as distinct variants. It's unclear if it's useful for them to be distinct and their usage is inconsistent. At the same time you can have everything be one generic kind with message.

I already created an issue for this before #690


Improve bash commands in LM1B README.md

What does this PR do?
Improve bash commands in LM1B README.md.
Also fixes a reference to AUTOTUNE, which lives in tf.data.experimental in the tensorflow==2.2.0rc3, which is the recommended version given in the README.

Fixes # (issue)
Checklist

[ ] This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
checks if that's the case).
[ ] This change is discussed in a Github issue/
discussion (please add a
link).
[ ] The documentation and docstrings adhere to the
documentation guidelines.
[ ] This change includes necessary high-coverage tests.
(No quality testing = no merge!)

Codecov Report

Merging #1329 (e8bb077) into master (0f9cc8b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1329   +/-   ##
=======================================
  Coverage   82.33%   82.33%
=======================================
  Files          65       65
  Lines        5316     5316
=======================================
  Hits         4377     4377
  Misses        939      939

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9cc8b...e8bb077. Read the comment docs.

Oh awesome! Curious what prompted you to look at this? Do we need to also update other examples? cc @sshahrokhi


The headers with same key are overwritten

Starlette responses adds cookies as headers with the same key.
       self.raw_headers.append((b"set-cookie", cookie_val.encode("latin-1")))
In your middleware handle outgoing request over writes the same key with only the last value.
        async def handle_outgoing_request(message: Message) -> None:
            if message['type'] == 'http.response.start':
                headers = {k.decode(): v.decode() for (k, v) in message['headers']}
                headers[self.header_name] = correlation_id.get()
                headers['Access-Control-Expose-Headers'] = self.header_name
                response_headers = Headers(headers=headers)
                message['headers'] = response_headers.raw
            await send(message)

Lets say my header list contains a list with keys as set cookies and values
as access_token, refresh_token(diff entries).
Then it just keeps the last refresh token and doesn't keep the first value
of access token.
On Wed, 2 Mar, 2022, 2:25 pm Sondre Lillebø Gundersen, <
@.***> wrote:

If I recall correctly, the intended behaviour was for headers =
{k.decode(): v.decode() for (k, v) in message['headers']} to capture
existing headers, and to add to that before writing back to the message
headers. In other words, it should add, but not change unrelated header
values.
I'm not sure I understand the issue 100%, can you elaborate on what
exactly the issue is?
—
Reply to this email directly, view it on GitHub
https://github.com/snok/asgi-correlation-id/issues/22#issuecomment-1056607764,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMH5VSYMGE3UKSORZE2UKQTU54UIJANCNFSM5PWM4WRQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

But this middleware does not set a set-cookie header. Are you referring to another header being overwritten?

Yes it overrides other headers.
On Sat, 12 Mar, 2022, 9:51 pm Sondre Lillebø Gundersen, <
@.***> wrote:

But this middleware does not set a set-cookie header. Are you referring
to another header being overwritten?
—
Reply to this email directly, view it on GitHub
https://github.com/snok/asgi-correlation-id/issues/22#issuecomment-1065911580,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMH5VS3NHXELFSYXETYH5ZLU7S77VANCNFSM5PWM4WRQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Could you open a PR with a failing test to illustrate what is wrong? I'm not able to replicate the issue on my own

You can check this image, here in message there are 4 headers with key as set-cookie and different values:

 headers = {k.decode(): v.decode() for (k, v) in message['headers']}
replaces the same key with different values with just 1 key and 1 value.

I see. That seems worth fixing! Would you be interested in creating a PR with a fix? 🙂

https://github.com/snok/asgi-correlation-id/pull/25

@sondrelg can you please merge the PR and release a new version I will then start using it.

Yes I'll review it early tomorrow morning (~15 hours from now) 👍 Thanks for the effort @lakshaythareja


Add blank line in sbt file.

The spec for sbt require a blank line between Scala expressions. IntelliJ fails to import the project when there isn't one.

:star:

⭐  Thanks @tonyd3! Can we also bug you to sign the CLA, here: https://buoyant.io/cla/individual/

signed!


OpenMP LD flags don't propagate

Xmake Version
2.8.6
Operating System Version and Architecture
Ubuntu
Describe Bug
When compiling a static library that depends on OpenMP and then adding it as dependency to a binary target, the openmp link flag (-fopenmp) is not passed to the GCC linker when assembling the binary target. Even adding {public=true} doesnt work.
Example: https://github.com/samayala22/tinyvlm/actions/runs/7760008649/job/21165288163
Expected Behavior
The behaviour can be fixed by manually add_packages("openmp") to all targets that depend on the original. But this is not desirable.
Project Configuration
Very simple reproducible example. Just run xmake in the root and it should fail to compile on Ubuntu with GCC compiler.

Just to be clear, you're saying add_packages("openmp", { public = true }) doesn't work?

Just to be clear, you're saying add_packages("openmp", { public = true }) in "depA" doesn't work?

Yes, doesnt work for me.
target("depA")
    set_kind("static")
    add_packages("openmp", { public = true })
    add_files("src/depA.cpp")
    add_includedirs("include", {public = true})

...
[ 75%]: linking.release main
/usr/bin/g++ -o build/linux/x86_64/release/main build/.objs/main/linux/x86_64/release/main.cpp.o -m64 -Lbuild/linux/x86_64/release -ldepA
/usr/bin/ld: build/linux/x86_64/release/libdepA.a(depA.cpp.o): in function `depA()':
depA.cpp:(.text+0x22): undefined reference to `GOMP_parallel'
/usr/bin/ld: build/linux/x86_64/release/libdepA.a(depA.cpp.o): in function `depA() [clone ._omp_fn.0]':
depA.cpp:(.text+0x3a): undefined reference to `omp_get_num_threads'
collect2: error: ld returned 1 exit status


Cannot finish build process

Keep getting hit with this error. This is my first time using a lot of this stuff, so is most likely user error.

Hi there! You'll need to install the Dotnet CLI.
The README currently only lists Homebrew as an installation method, but that tends to get a bit technical. If you prefer an installer, you should be able to follow the download instructions here: https://dotnet.microsoft.com/en-us/download. Make sure to select ARM64 if you're on an Apple Silicon Mac. The installation is succesful if you can run dotnet from the terminal.
Will make this prerequisite a bit more clear in the README in the future 👍

Hey Tim,
Thanks for the help. Got it up and running now, and I have to say, it's running great.
The Mac Gaming community salutes you.
Cheers.


Rename socket to socket_id to make TopologyEntry members consistent

LGTM, but will merge via a larger merge with other staged changes


calling stop_propagation() on immutable events

I was disappointed to discover this won't work:
On::<ScrollWheel>::listener_component_mut::<Scrolling>(move |ev, scrolling| {
    // (Do stuff)
    ev.stop_propagation(); // ERROR: 'ev' is immutable
}),

The problem is that listener_component_mut gives me an immutable listener, rather than a mutable one; most of the other convenience methods have the same limitation. So if I want to call stop_propagation() I have to use run().
I generally want to call stop_propagation() in most handlers, which means that the convenience methods hardly ever get used.

I think this was just an oversight, I'll make this change and publish a new version.

FYI, you can make an extension trait if you want to make a grab-bag of reusable listener builders.
trait MyListeners {
    fn listener_remove_noisy<B: Bundle>() -> Self;
}

impl<E: EntityEvent> MyListeners for On<E> {
    fn listener_remove_noisy<B: Bundle>() -> Self {
        println!("My version prints an annoying message");
        Self::run(|event: Res<ListenerInput<E>>, mut commands: Commands| {
            commands.entity(event.listener()).remove::<B>();
        })
    }
}

Then, as long as your extension trait is in scope, you can call your methods as if they were defined in this library:
commands.spawn(On::<Eat>::listener_remove_noisy::<Food>())


DDR mode bugfixes & baby difficulty

Adds very easy difficulty, makes press feedback consistent, fixes misplaced pulse indication.
Also renames difficulties to be doom themed

Actually, hang on I need to edit this rq

Love the difficulty names!
This is throwing a warning because there's a fourth score saved now:
settings_t settings =
{
    .SaveLoadKey = 0,
    .isMuted = 0,
    .menuPos = 0,
    .savedDemon = {0},
    .ddrHighScores = {{{0}}, {{0}}, {{0}}},
    .gitHash = {0},
    .selfTestPassed = false,
};

Please also increment SAVE_LOAD_KEY, since the gitHash and selfTestPassed bytes are now shifted.
Other than that, looks great!


Admin UI

Create basic UI. More to come

Should get all routes when we land on the site
Search bar will auto suggest paths, also excepts text that aren't in auto suggestion
Eye icon will open a new tab with the mocked response
Nav bar items should call reset endpoint (endpoint isn't set up yet)

Resolves https://github.com/caribou-crew/mezzo/issues/2


Add overload authenticateSuccessfully of SimpleAuthOutput with parameter to clear auth passws after authentication

card: https://hivemq.kanbanize.com/ctrl_board/4/cards/26231/details/

@cla-bot just signed it, thank you.


Update content for Nodes setup info button

Summary of bug
When doing node setup for Cosmos and Substrate base chains (step 3 of 5), we show an info button next to the text, 'Here you will configure the nodes you want monitored and triggering alerts' we show an info button which when clicked presents the node operator with a popup covering two sections - Basics and Tips (see below). The content of both sections needs some minor adjustments.

'As is' behaviour

The first line of the Basics section reads, "This is the node's setup step, here you will configure the node you want monitored and alerted on".
The last line of the Tips section reads, "Do not use [] in your names as you will not be able to load the configuration".

'To be' behaviour

The first line of the Basics section should read, "This is the node's setup step, here you will configure the node you want to be monitored and alerted on".
Update the content of the Tips section to read, "We suggest to add the IP Address to the node name so you know where to look for the node. For example, cosmos_main_validator(IP)". The example node name shown should be representitve of base chain. So if for example, the node operator is setting up a substrate node, then the example would read, "polkadot_main_validator(IP)".
When showing the node name use monospace font & secondary colour.

Steps to reproduce

Get to step 3 of 5 of the installation process.
Click on the info button next to the text, 'Here you will configure the nodes you want monitored and triggering alerts'.

Acceptance criteria
Given: The node operator is on step 3 of 5 in the installation process.
When: He clicks on the info button
Then: He is presented with updated content as per above.

This requirement was omitted.
When showing the node name use monospace font & secondary colour.


Add resource parameter to PAR

As recommended by the OpenID4VCI draft 14, use RFC8707 resource parameter when requesting issuance using scope parameter.
The exact phrasing in the draft reads:

If the Credential Issuer metadata contains an authorization_servers property, it is RECOMMENDED to use a resource parameter.

The information about existence of authorization_servers property is unfortunately lost in the TO → domain conversion, so it's not taken into account.
This fix has already been applied to the iOS library in https://github.com/eu-digital-identity-wallet/eudi-lib-ios-openid4vci-swift/pull/56.
Closes #302

Thanks for quick reply, a few thoughts:

In general, we can understand whether the credential issuer is a resource server that uses another authorization server or whether is both resource & authorization server by comparing the credentialIssuerId and the authorizationIssuer attributes.

Technically this is against the specification, as it states (emphasis mine):

If the Credential Issuer metadata contains an authorization_servers property, it is RECOMMENDED to use a resource parameter [RFC8707] whose value is the Credential Issuer's identifier value to allow the Authorization Server to differentiate Credential Issuers.

I understand this is hard to determine this way as the information is lost in the domain conversion and to me it feels like you're suggesting to capture the "spirit of the specification" instead of literally implementing it. I think there's two more alternatives to consider:

Using the resource parameter always when scope is used, as it's currently implemented in this PR. Does it hurt that we're redundantly including the parameter? I wasn't able to find any harmful consequences from the RFC nor the OpenID4VCI spec. It does add one extra parameter that increases the HTTP request payload, though.
Determining the "issuer as authorization server" value literally as stated in the draft (i.e. resolving it during JSON parsing and exposing it in the domain object).

I know I'm not in the position to demand how it is to be implemented, but wanted to point out my opinion and the alternatives.

If location attribute has to be populated in the authorization_details (your last change)
if resource attribute needs to be populated in the PAR (your first change)
if resource attribute needs to be populated in the simple authorization request (not PAR) at line 190

Good catch! This issue came up during interop and obviously I was focused on the code paths related to our use case. 😄

Dear @spheroid ,
I don't agree with your assessment :smile:
AuthorizationEndpointClient is being instantiating by providing - among other attributes :

The credentialIssuerId  : representing the credential issuer to interact with
The authorizationIssuer :  representing the authorization server to target

This means, that it is not the responsibility of the this class to choose (based on the issuer metadata) which authorization server will be used.
Whose responsibility is this?
Unfortunately it is not so simple to determine with which authorization server to interact.
The caller's of course and in our case, Issuer instantiates this client
(https://github.com/eu-digital-identity-wallet/eudi-lib-jvm-openid4vci-kt/blob/a2840254fee36cbbb0d98abbbdd51906bc3ab871/src/main/kotlin/eu/europa/ec/eudi/openid4vci/Issuer.kt#L120)
As you can see, for the initialization a CredentialOffer is being used. This class is not a simple Transfer Object. Rather represents the validated issuer & authorization server metadata.
Here we choose among the authorization server possibly found in the grants of an offer or (in the absence of it) fallback to the first authorization server advertised by metadata (or the credential issuer itself)
https://github.com/eu-digital-identity-wallet/eudi-lib-jvm-openid4vci-kt/blob/a2840254fee36cbbb0d98abbbdd51906bc3ab871/src/main/kotlin/eu/europa/ec/eudi/openid4vci/internal/DefaultCredentialOfferRequestResolver.kt#L106
In summary, in my subjective opinion, we are fully aligned with the specification and no information is being lost.
PS: Why choose the first authorization server advertised ?
On the Issuer side, credential offer can make it explicit.
On the Wallet side, we wanted to keep it simple. In the future we could allow wallet to define a predicate for choosing an authorization server.

I don't agree with your assessment 😄
This means, that it is not the responsibility of the this class to choose (based on the issuer metadata) which authorization server will be used.

I know I'm splitting hairs here but that's not my point. My point is that the current draft says that it's both recommended to use the resource parameter and mandatory to use the locations parameter when the authorization_servers property is set, despite what authorization server you're using.
Don't get me wrong, I do agree that your approach makes sense. Perhaps this issue should be raised in the OpenID4VCI repository instead to clarify their point: Is it tied to the existence of the authorization_servers property or whether the credential issuer is acting as the authorization server.

I don't agree with your assessment 😄
This means, that it is not the responsibility of the this class to choose (based on the issuer metadata) which authorization server will be used.

I know I'm splitting hairs here but that's not my point. My point is that the current draft says that it's both recommended to use the resource parameter and mandatory to use the locations parameter when the authorization_servers property is set, despite what authorization server you're using.
Don't get me wrong, I do agree that your approach makes sense. Perhaps this issue should be raised in the OpenID4VCI repository instead to clarify their point: Is it tied to the existence of the authorization_servers property or whether the credential issuer is acting as the authorization server.

I really value your comments and of course I don't get you wrong.
Unless I missing something, locations and  resource make sense when the credential issuer is not acting as an authorization server. Only in this case, there is a need to populate authorizations_servers.
Mind though that nothing stops an issuer (acting as authorization server) to populate authorization_servers with its issuer id.
Raising an issue to spec sounds like a good idea. I think there are two options:

Either authorization_servers should not contain credential issuer id (if present), in this case requirements for resource and locations can be left as they are, or
Clearly state that resource & locations is needed when credential issuer is not an authorization server.

Yes, exactly. 👍
Anyway – thank you for the discussion and accepting this PR in such a quick manner!

@spheroid FYI https://github.com/openid/OpenID4VCI/issues/378


gzip not working with mirror and uglify

var fs = require('fs');
var path = require('path');
var gulp = require('gulp');
var gzip = require('gulp-gzip');
var gutil = require('gulp-util');
var uglify = require('gulp-uglify');
var concat = require('gulp-concat');
var rename = require('gulp-rename');
var mirror = require('gulp-mirror');
var sourcemaps = require('gulp-sourcemaps');
gulp.task('build-ide', function() {
var distDir = './js';
var commonFiles = fs.readFileSync('build/common_files', 'utf8').split('\n');
var gameFiles = fs.readFileSync('build/gamebuilder_files', 'utf8').split('\n');
var min = rename('gamebuilder.js');
min.pipe(uglify())
.pipe(gzip({append: true}));

return gulp.src(gameFiles.concat(commonFiles))
.pipe(sourcemaps.init())
.pipe(concat('gamebuilder-debug.js'))
.pipe(mirror(min))
.pipe(sourcemaps.write('./'))
.pipe(gulp.dest(distDir));

});
the result cant generate min files, but can not gzip files,

Hey @Luncher! I tried my best to reproduce your gulp task to see what is going on.
What is the result of gameFiles.concat(commonFiles)? Does that concatenate the contents of those files? gulp.src takes in a glob string rather than the contents of files.
Also, I got an exception from uglify unless I wrote it like this:
  var min = rename('gamebuilder.js')
    .pipe(uglify())
    .pipe(gzip({append: true}));

Does that make a difference for you?

Hey @jstuckey
thank you for your reply， the gameFiles.concat(commonFiles) result is file path, not the file contents.
I am gulp beginners, I think this is the relative lack of learning materials .
Can you help me explain the following two methods are different?
var min = rename('gamebuilder.js')
.pipe(uglify())
.pipe(gzip({append: true}));

var min = rename('gamebuilder.js');
min.pipe(uglify())
.pipe(gzip({append: true}));

The value that gets assigned to min is different. In the original, the value of min is only the rename stream. In the new version, the value of min is the pipeline of the three streams (rename, uglify, and gzip)
For example:

var min1 = rename('gamebuilder.js');
min1.pipe(uglify())
  .pipe(gzip({append: true}));

var min2 = rename('gamebuilder.js')
  .pipe(uglify())
  .pipe(gzip({append: true}));

console.log(min1)
console.log(min2)
console.log(min1 === min2)

got it, but  I still do not understand why can not generate gzip.

I was able to generate a gzipped file using
var min = rename('gamebuilder.js')
  .pipe(uglify())
  .pipe(gzip({append: true}));

Does that not work for you?


Improve "antctl mc" usage

When I used the wrong Antrea version tag by mistake, I got the following error:
antctl mc deploy leadercluster -n antrea-multicluster --antrea-version 1.15.0
Error: json: cannot unmarshal string into Go value of type unstructured.detector

The error is because the tag should b v1.15.0 instead of 1.15.0.
It would be good IMO if the v was optional (i.e., we could support both formats). And it would also be good to have a better error message if someone provides an invalid tag or a tag that doesn't exist.
cc @luolanzone

@hjiajing

@hjiajing

Thanks for the reminder, I will check and fix this.

can I work on this issue?

@EraKin575, @hjiajing may be working on this already. If not, you are welcome to submit a PR.

Hi @antoninbas , I have not worked on this yet, maybe @EraKin575 could do it.

@EraKin575 feel free to submit a PR for this

Hi @EraKin575  are you still actively working on this issue?

Hi @luolanzone! I am working on this issue and will try to raise a PR by today.

Fixed by #6287


Update kafka-avro-serializer to 5.5.0

Updates io.confluent:kafka-avro-serializer from 5.4.1 to 5.5.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.confluent", artifactId = "kafka-avro-serializer" } ]

labels: library-update, semver-minor

Closing in favor of #421.


Wrapping a Wrapper should be a no-op.

Unmutable wrappers should not be able to be nested. A wrapper is a way of calling methods on a deep data structure, rather than a data container in its own right.
Depends on https://github.com/blueflag/unmutable/issues/15

Done in v0.11.0


Add a third slash to make sure generated docs include comments.…

…b/13812238

Merging and will consider a cherry-pick to M56 tomorrow.


Detect websocket disconnection

Detect websocket disconnection and do something. Maybe display a toast ? We could refresh the page but if there is no internet it will go into an infinite loop

For now I just displayed a permanent toast message.


Update connections.py for Azure Databricks

#29
Azure databricks requires one to specify the organization id of the workspace the cluster belongs in.  There was a hardcoded 0 in the spark URL before, which wouldn't allow for authentication.  Perhaps that's how AWS databricks works?
Anyway, I've suggested a few changes (and totally open to feedback, as I'm learning the code structure still).  Happy to discuss further...P.S.  I"m guessing at what branch to specify for the pull request, so feel free to point me up differently!

Thanks @poidra02 - this looks great! Is the organization for you on Azure DataBricks always an integer? The image in the Azure Databricks documentation makes this look like a string to me!

I imagine there's no harm in making that config parameter a string, then using "0" as the default. This should work when the id is either an integer or a string.

That's surprising @poidra02 - I can't think of a place in dbt-core where strings are checked for alpha contents, but it's totally possible. If you're able to send through some logs or a stack trace, I'd be happy to take a look!

Hey @drewbanin - So I'm having a little trouble firmly pointing at the cause, but here's what I see so far.  When I set organization in SPARK_CREDENTIALS_CONTRACT to this:
        'organization': {
            'type': 'string'

and include this in profile yml:
organization: 123

(that's obviously not a real organization though) it fails with this error:
Profile loading failed for the following reason:
Runtime Error
  Credentials in profile "rob", target "test" invalid: Runtime Error
    Invalid arguments passed to "SparkCredentials" instance: organization.123 is not of type 'string'

If I change string to a number in the contract (and use a real org), it goes through.  I'm sure the above is not all that much to go on, but if it all scopes in where you might suggest I look next, I'd definitely appreciate any pointers.
Completely unrelated- if I have a question on how to setup a custom snapshot strategy to set the valid to dates to 1/1/3000, should I open an issue on the main project to get some help?

Got it! I think one answer could be to specify the organization id as a string, eg:
organization: "123"

When this yaml document is parsed, it will render out as "123" (a string) instead of 123 (a number). We can also make some changes in the dbt-spark plugin to coerce a provided integer into a string, since this is an unfortunate and confusing error to run into. This might be as simple as writing changing this line of code to something like:
if 'organization' in kwargs:
  kwargs['organization'] = str(kwargs['organization'])
else:
  kwargs['organization'] = '0'

This code (in __init__) should run before the provided credentials are validated with the supplied JSON schema. Note: a lot of this code is changing in 0.15.0 (we're nixing JSON schemas), but I'll follow up with a patch to bring dbt-spark up-to-date with dbt v0.15.0 in the future.

Completely unrelated- if I have a question on how to setup a custom snapshot strategy to set the valid to dates to 1/1/3000, should I open an issue on the main project to get some help?

Sure! You can feel free to open an issue in the fishtown-analytics/dbt repo. We haven't documented custom strategies yet because the interface they use is subject to change in future releases. I'd be happy to follow up with you in a new issue and document this functionality (with an appropriate "unstable" warning) in the dbt documentation.

Thanks so much @drewbanin!  That was spot on.  I wound up doing the string checking so as to not force people to figure out putting quotes in the yaml file.
Looks like those commits made their way to the pull request, so feel free to give it a review when you get a chance and let me know what you think.
dbt debug seems to be connecting successfully afterwards and I see an org of 0 when you leave it out in the logs (though that obviously doesn't connect, but that's to be expected).

hey @poidra02 - I set up a branch with a CI env over here: https://github.com/fishtown-analytics/dbt-spark/pull/36
Looks like there are a couple of kinks to work out still, but we're pretty close! I'm going to check out this PR more in-depth tomorrow, running it against our test env. Looking forward to getting this merged!

@poidra02 @drewbanin I've tested this pr on our azure databricks cluster, and it seems to work perfectly. Is there anything I can do to help this pr getting merged?

Can you merge master into this branch to get the tests running? This code largely LGTM :)

hey @drewbanin -  I think I have it merged successfully now.  If I can help with anything else, feel free to get me pointed up!


Removed deprecated RobolectricGradleTestRunner.

More info here.

Nice! I'm actually haven't watched Robolectric for like half a year and glad to see such changes

Uh nice since when is it deprecated? I'm also happy to see it.

Uh that change looks fantastic. Thanks for that I'll also change it.

God, the more I work on OSS on GitHub the more I don't like free (yes, it's free, I understand) cloud CI… restarted CircleCI build (died unexpectedly)

Thanks for the heads up! I'll update my person projects that use Roboelectric as well.

Current coverage is 77.73% (diff: 100%)

Merging #198 into master will not change coverage

@@             master       #198   diff @@
==========================================
  Files            38         38
  Lines           557        557
  Methods           0          0
  Messages          0          0
  Branches         49         49
==========================================
  Hits            433        433
  Misses           92         92
  Partials         32         32

Powered by Codecov. Last update 7449773...1ca6dfd

Thanks, @zsavely!

No problem! 👍


Different types of variables at the same function

The function weekDayBuilder has different type of variable according to the view calendar. If its weekview, the function has date as a DateTime but if we use MonthView is an integer. Why?
WEEKVIEW:

MONTHVIEW:

Also different variables in oneventap of month and day view:
MONTH VIEW:

WEEK VIEW:

@Saliim17  Closing this as there is no problem with development.
In MonthView weekDayBuilder accepts int (which represents the number of day in week) because that's what we need to show the week title. But in WeekView, we need date as well that's why weekDayBuilder in week view accepts DateTime instead of int.
Same for onEventTap. onEventTap is called when user taps on any event tile. In monthview evey event tile will have only one event. But in WeekView and DayView when MergeEventArranger is used, event tile can have multiple events.
If you have any better suggestions on how these functions should be implemented, feel free to reopen this issue and share it with us.


White Boots - Add temp image for the relic

Also, White Boots needs one extra image for when it's spent through the combat.

And done.

Forgot the grey version for when the relic is used.

Done!


Add on screen entertainment segments

basically what i mean is that on an original weatherstar 4000 the forecast was in between on screen entertainment so maybe add an option to enable or disable that and if its enabled either a user can add it to for example obs studio and then place an image on top or be able to set a video url

yes but the video ticker had the date and time embedded aswell as it was the same one used as the NWS warning screen

you can also just make the top part a greenscreen and then let the user be able to overlay an video on top

Hello @Sonic4Tails according to the following article all that you need to do is add an overlay that is playing the entertainment and then use the WeatherStar 4000+ has the background.
Refer to the following article for more information:
https://support.streamelements.com/en/articles/25-adding-an-overlay-to-obs-studio

@vbguyny
you would not have the added clock and date shown like with the alert segments


Extend readme

Run init steps separately (&& doesn't work for every shell)
Show how to exit the pixi shell again

Thanks!!


Implement DOI resolver recommendation

See https://www.doi.org/doi_handbook/3_Resolution.html#3.8
I have a script that could switch all these old DOI URLs, but I'm guessing that is only useful for some filetypes or uses.
If I'm guessing correctly and you are interested in more such PRs, please let me know where the updates are most useful.

I'm not sure about these build errors, but reading the error messages, I don't think they were caused by my change.

Katrin,
The active code development is now on https://github.com/petermr/ami3 (I
think your fail was a missing library). Could you please try that.
Thanks
On Tue, Nov 19, 2019 at 12:19 PM Katrin Leinweber<EMAIL_ADDRESS>wrote:

I'm not sure about these build errors
https://travis-ci.org/ContentMine/norma/builds/601742819#L639-L641, but
reading the error messages, I don't think they were caused by my change.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ContentMine/norma/pull/75?email_source=notifications&email_token=AAFTCS6KVYTL5H57N2GVCH3QUPKWDA5CNFSM4JD7BCJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEN77MQ#issuecomment-555483058,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFTCSYEMWEJD7X6EVYFYMTQUPKWDANCNFSM4JD7BCJA
.

--
Peter Murray-Rust
Founder ContentMine.org
and
Reader Emeritus in Molecular Informatics
Dept. Of Chemistry, University of Cambridge, CB2 1EW, UK

Not immediately, sorry. That code seems much larger and the old resolver is present in many more files.


Update README.md

Non critical change. Failure with message for environment variable not found.


Wirelink error

Need to add 'if not inp then return nil end' after line 335 of acf_rack/init.lua to keep it from shitting itself if you try to use wirelinks on a rack.

Tried it out, yes it does cause this error, would be really cool you fix it since he already gave you the solution to the problem, b0ss pls I want my wirelinked racks.

Done!
Thanks for the report, let me know if the problem persists.