Issues with node_cpu_seconds_total

I tested the latest changes, and still not right...
Panel CPU Utilization by Node "expr": "avg by (node) (1-rate(node_cpu_seconds_total{mode=\"idle\"}[$__rate_interval]))",yields:

Seems to be the total of all nodes? It is not picking up the multiple nodes, It should look like:

Panel CPU Utilization by namespace is still dark and using old metric: "expr": "sum(rate(container_cpu_usage_seconds_total{image!=\"\"}[$__rate_interval])) by (namespace)",  I did try something like above "avg by (namespace) (1-rate(node_cpu_seconds_total{mode=\"idle\"}[$__rate_interval]))"  that is not right, only got one namespace listed:

Both Memory Utilization Panels are still dark based on container_memory_working_set_bytes when I use your unmodified files.

Kicking around some other ideas and learned how to merge two metrics which share a common key.
"expr": "avg by (nodename) (instance:node_cpu:ratio * on(instance) group_left(nodename) node_uname_info)"

Hi @reefland,
Yes I noticed that too... will try to fix this today and let you know when everything works with 37.*.

I think the "REAL" RAM usage is now including all kinds of cached memory as "used".  Previous method is reporting 12.9GB RAM used, new method is reporting 39.8GB RAM used (I have both running side by side).  It's not a measurement of what Kubernetes is using anymore.
According to RedHat https://access.redhat.com/solutions/406773  (Covers most of the node_memory_* counters)
Mem: used  =  MemTotal - MemFree - Buffers - Cached - Slab
So I tried:
sum(node_memory_MemTotal_bytes - (node_memory_Buffers_bytes + node_memory_Cached_bytes + node_memory_MemFree_bytes + node_memory_Slab_bytes))

This dropped it a bit to 34.3 GB.
For me ~23.6 GB usage is ZFS Arc cache which ZFS will return to OS if any memory pressure happens.  Temporary used, but still used I guess.

The CPU Utilization by node should probably be renamed to by instance now.
The CPU Utilization by namespace is still dark, not updated yet.

I also noticed a difference with the previous method that didn't included everything. I think it make sense to have "Real" match the system resources usage. Otherwise you could see available resources on the dashboards but the scheduler could fail to start pods due to the lack of resources behind the scene.
With the new method, the REAL value should match the system /proc.
I compared metrics with free/top on my side and everything looked good. I'll try to test on a cluster with more load to see if I need to exclude cache.
For your ZFS Arc cache, maybe is not seen as cache by the system and I'm not sure how to get around this. Do you have a way to test Memory Usage panel from Views / Nodes?
CPU Utilization by namespace should work, is it still a label issue with k3s?

I think you have the memory right.  Checked other tools like LENS and it lines right up.
The CPU & Memory by namespace, Memory Utilization by node are dark as I do not have metrics with a image= attribute.    I wonder if I can set it with a relabel but not sure what the image value is supposed to be, is it a docker image reference?  I manually change image= to pod= and the panel seems to work fine.
I also upgraded to Kube Stack Prometheus 38.0.1 which has this:
     # Drop cgroup metrics with no pod.
      - sourceLabels: [id, pod]
        action: drop
        regex: '.+;'

Which caused container_network_receive_bytes_total  and container_network_transmit_bytes_total to get dropped.  Noticed after a few hours I lost all my network stats since upgrading.  I removed that drop and my network stats came back.

I still can't use your dashboards unmodified:

My networking metrics are looking good again.  But I think my overrides are still in place...
I've not been able to find a rule that would drop the image label.  Honestly, I'm not even sure where to look.  I assume I can use Prometheus configuration screen, prometheus-kubelet job?
Nothing stands out:
- job_name: serviceMonitor/monitoring/prometheus-kubelet/1
  honor_labels: true
  honor_timestamps: true
  scrape_interval: 30s
  scrape_timeout: 10s
  metrics_path: /metrics/cadvisor
  scheme: https
  authorization:
    type: Bearer
    credentials_file: /var/run/secrets/kubernetes.io/serviceaccount/token
  tls_config:
    ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt
    insecure_skip_verify: true
  follow_redirects: true
  enable_http2: true
  relabel_configs:
  - source_labels: [job]
    separator: ;
    regex: (.*)
    target_label: __tmp_prometheus_job_name
    replacement: $1
    action: replace
  - source_labels: [__meta_kubernetes_service_label_app_kubernetes_io_name, __meta_kubernetes_service_labelpresent_app_kubernetes_io_name]
    separator: ;
    regex: (kubelet);true
    replacement: $1
    action: keep
  - source_labels: [__meta_kubernetes_service_label_k8s_app, __meta_kubernetes_service_labelpresent_k8s_app]
    separator: ;
    regex: (kubelet);true
    replacement: $1
    action: keep
  - source_labels: [__meta_kubernetes_endpoint_port_name]
    separator: ;
    regex: https-metrics
    replacement: $1
    action: keep
  - source_labels: [__meta_kubernetes_endpoint_address_target_kind, __meta_kubernetes_endpoint_address_target_name]
    separator: ;
    regex: Node;(.*)
    target_label: node
    replacement: ${1}
    action: replace
  - source_labels: [__meta_kubernetes_endpoint_address_target_kind, __meta_kubernetes_endpoint_address_target_name]
    separator: ;
    regex: Pod;(.*)
    target_label: pod
    replacement: ${1}
    action: replace
  - source_labels: [__meta_kubernetes_namespace]
    separator: ;
    regex: (.*)
    target_label: namespace
    replacement: $1
    action: replace
  - source_labels: [__meta_kubernetes_service_name]
    separator: ;
    regex: (.*)
    target_label: service
    replacement: $1
    action: replace
  - source_labels: [__meta_kubernetes_pod_name]
    separator: ;
    regex: (.*)
    target_label: pod
    replacement: $1
    action: replace
  - source_labels: [__meta_kubernetes_pod_container_name]
    separator: ;
    regex: (.*)
    target_label: container
    replacement: $1
    action: replace
  - source_labels: [__meta_kubernetes_service_name]
    separator: ;
    regex: (.*)
    target_label: job
    replacement: ${1}
    action: replace
  - source_labels: [__meta_kubernetes_service_label_k8s_app]
    separator: ;
    regex: (.+)
    target_label: job
    replacement: ${1}
    action: replace
  - separator: ;
    regex: (.*)
    target_label: endpoint
    replacement: https-metrics
    action: replace
  - source_labels: [__metrics_path__]
    separator: ;
    regex: (.*)
    target_label: metrics_path
    replacement: $1
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: (.*)
    modulus: 1
    target_label: __tmp_hash
    replacement: $1
    action: hashmod
  - source_labels: [__tmp_hash]
    separator: ;
    regex: "0"
    replacement: $1
    action: keep
  metric_relabel_configs:
  - source_labels: [__name__]
    separator: ;
    regex: container_cpu_(cfs_throttled_seconds_total|load_average_10s|system_seconds_total|user_seconds_total)
    replacement: $1
    action: drop
  - source_labels: [__name__]
    separator: ;
    regex: container_fs_(io_current|io_time_seconds_total|io_time_weighted_seconds_total|reads_merged_total|sector_reads_total|sector_writes_total|writes_merged_total)
    replacement: $1
    action: drop
  - source_labels: [__name__]
    separator: ;
    regex: container_memory_(mapped_file|swap)
    replacement: $1
    action: drop
  - source_labels: [__name__]
    separator: ;
    regex: container_(file_descriptors|tasks_state|threads_max)
    replacement: $1
    action: drop
  - source_labels: [__name__]
    separator: ;
    regex: container_spec.*
    replacement: $1
    action: drop
  - source_labels: [node]
    separator: ;
    regex: (.*)
    target_label: instance
    replacement: $1
    action: replace
  kubernetes_sd_configs:
  - role: endpoints
    kubeconfig_file: ""
    follow_redirects: true
    enable_http2: true
    namespaces:
      own_namespace: false
      names:
      - kube-system

Ok we'll use this issue to understand why your k3s setup is missing both the image and the container labels from cAdvisor.
Just installed k3s on my laptop and got everything working out of the box using the default configuration.
OS: archlinux
k3s version:
david@laptop ~ $ sudo k3s kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5+k3s1", GitCommit:"313aaca547f030752788dce696fdf8c9568bc035", GitTreeState:"clean", BuildDate:"2022-03-31T01:02:40Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5+k3s1", GitCommit:"313aaca547f030752788dce696fdf8c9568bc035", GitTreeState:"clean", BuildDate:"2022-03-31T01:02:40Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"}

kube-prometheus-stack version:
david@laptop ~ $ helm ls -n monitoring
NAME    NAMESPACE       REVISION        UPDATED STATUS  CHART   APP VERSION
david@laptop ~ $ helm ls -n monitoring
NAME                    NAMESPACE       REVISION        UPDATED                                         STATUS          CHART                           APP VERSION
kube-prometheus-stack   monitoring      1               2022-08-17 15:13:29.783638314 +0200 CEST        deployed        kube-prometheus-stack-39.8.0    0.58.0

Everything is running:
david@laptop ~ $ sudo k3s kubectl get pod -n monitoring
NAME                                                        READY   STATUS    RESTARTS   AGE
kube-prometheus-stack-prometheus-node-exporter-qgzwl        1/1     Running   0          19m
kube-prometheus-stack-operator-5995b5478d-vlrss             1/1     Running   0          19m
alertmanager-kube-prometheus-stack-alertmanager-0           2/2     Running   0          19m
kube-prometheus-stack-kube-state-metrics-5f6d6c64d5-tpnmt   1/1     Running   0          19m
kube-prometheus-stack-grafana-c9569b849-28zxf               3/3     Running   0          19m
prometheus-kube-prometheus-stack-prometheus-0               2/2     Running   0          19m

All dashboards are working:

And I also have the image and the container labels:

Can you try to deploy a copy of your setup with no customization at all (no values, no parameters etc...) Just raw k3s with the latest version of kube-prometheus-stack and the latest dashboards.
Also, can you please share again as much information as possible on your setup:
Hardware (and/or Hypervisor with version), processor architecture, guest OS, k8s version, k3s version, kube-prometheus-stack version etc...
I'll do my best to get as close as possible to your setup to figure this out.
Let me know,
David

Can you post what your default containerd config file looks like?  /var/lib/rancher/k3s/agent/etc/containerd/config.toml
I don't have one to compare against.

$ sudo cat /var/lib/rancher/k3s/agent/etc/containerd/config.toml

[plugins.opt]
  path = "/var/lib/rancher/k3s/agent/containerd"

[plugins.cri]
  stream_server_address = "<IP_ADDRESS>"
  stream_server_port = "10010"
  enable_selinux = false
  sandbox_image = "rancher/mirrored-pause:3.6"

[plugins.cri.containerd]
  snapshotter = "overlayfs"
  disable_snapshot_annotations = true

[plugins.cri.cni]
  bin_dir = "/var/lib/rancher/k3s/data/05cfd5aec8ddf622207749ef3eda0e0efa12d8900105fdac78815a8cd6c73685/bin"
  conf_dir = "/var/lib/rancher/k3s/agent/etc/cni/net.d"

[plugins.cri.containerd.runtimes.runc]
  runtime_type = "io.containerd.runc.v2"

Could you try setting this in your kube-prometheus-stack values and see if it changes anything?
kubelet:
  enabled: true
  serviceMonitor:
    ## Enable scraping /metrics/resource from kubelet's service
    ## This is disabled by default because container metrics are already exposed by cAdvisor
    resource: true

Didn't had time to test further but according to https://github.com/containerd/containerd/issues/4541#issuecomment-974709561, they tried to fix an issue between cAdvisor and containerd in k8s 1.23. It's a bit different, but maybe there's something to dig arround here.
Also, cAdvisor has a dedicated containerd tag for their image in their repository:
https://console.cloud.google.com/gcr/images/cadvisor/global/cadvisor (v0.45.0-containerd-cri)
Maybe it's worth trying to disable cAdvisor from kube-prometheus-stack and deploy the v0.45.0-containerd-cri version as a demonset and create a dedicated serviceMonitor to scrape the metrics.
Let me know if you try any of theses.

I tried...
       resource: true
       # From kubernetes 1.18, /metrics/resource/v1alpha1 renamed to /metrics/resource
       resourcePath: "/metrics/resource"

container_cpu_usage_seconds_total{image!=""} still returns an empty set.

Effort to reduce variables, greatly reduced the size of the containerd config file, everything still works great, but I don't see any difference in the metrics.
main differences besides the snapshotter, was stream_server_port from 0 to 10010 and changed sandbox_image to use the same one as k3s which bumps version from 3.5 to 3.6 as well.
$ cat /etc/containerd/config.toml

root = "/var/lib/containerd"
state = "/run/containerd"
version = 2

[plugins]
  [plugins."io.containerd.grpc.v1.cri"]
    stream_server_address = "<IP_ADDRESS>"
    stream_server_port = "10010"
    enable_selinux = false
    sandbox_image = "rancher/mirrored-pause:3.6"

  [plugins."io.containerd.grpc.v1.cri".cni]
    bin_dir = "/usr/lib/cni"
    conf_dir = "/etc/cni/net.d"

  [plugins."io.containerd.grpc.v1.cri".containerd]
    default_runtime_name = "runc"
    snapshotter = "zfs"

Was there anything interesting in this options directory with your install?
[plugins.opt]
  path = "/var/lib/rancher/k3s/agent/containerd"

I played around with your suggestion cAdvisor Kubernetes Daemonset on a test node:
$ k get all -n cadvisor
NAME                 READY   STATUS    RESTARTS   AGE
pod/cadvisor-pm2lw   1/1     Running   0          13m

NAME                      DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
daemonset.apps/cadvisor   1         1         1       1            1           <none>          13m

When I curl for a metric, seem rather large, does this seem normal in your experience?
$ curl http://<IP_ADDRESS>:8080/metrics | grep container_cpu_usage_seconds_total

container_cpu_usage_seconds_total{container_label_alertmanager="",container_label_app="",container_label_app_kubernetes_io_component="",container_label_app_kubernetes_io
_csi_role="",container_label_app_kubernetes_io_instance="",container_label_app_kubernetes_io_managed_by="",container_label_app_kubernetes_io_name="",container_label_app_
kubernetes_io_part_of="",container_label_app_kubernetes_io_version="",container_label_chart="",container_label_com_suse_eula="",container_label_com_suse_image_type="",co
ntainer_label_com_suse_lifecycle_url="",container_label_com_suse_release_stage="",container_label_com_suse_sle_base_created="",container_label_com_suse_sle_base_descript
ion="",container_label_com_suse_sle_base_disturl="",container_label_com_suse_sle_base_eula="",container_label_com_suse_sle_base_image_type="",container_label_com_suse_sl
e_base_lifecycle_url="",container_label_com_suse_sle_base_reference="",container_label_com_suse_sle_base_release_stage="",container_label_com_suse_sle_base_source="",con
tainer_label_com_suse_sle_base_supportlevel="",container_label_com_suse_sle_base_title="",container_label_com_suse_sle_base_url="",container_label_com_suse_sle_base_vend
or="",container_label_com_suse_sle_base_version="",container_label_com_suse_supportlevel="",container_label_component="",container_label_controller_revision_hash="",cont
ainer_label_description="",container_label_helm_sh_chart="",container_label_heritage="",container_label_io_cri_containerd_kind="container",container_label_io_kubernetes_
container_name="grafana",container_label_io_kubernetes_pod_name="grafana-5c9dc97c-mqxr6",container_label_io_kubernetes_pod_namespace="monitoring",container_label_io_kube
rnetes_pod_uid="b32a26d7-b940-4dce-8172-9091c0b7f255",container_label_jobLabel="",container_label_k8s_app="",container_label_longhorn_io_component="",container_label_lon
ghorn_io_engine_image="",container_label_longhorn_io_instance_manager_image="",container_label_longhorn_io_instance_manager_type="",container_label_longhorn_io_managed_b
y="",container_label_longhorn_io_node="",container_label_maintainer="",container_label_maintainers="",container_label_name="",container_label_operator_prometheus_io_name
="",container_label_operator_prometheus_io_shard="",container_label_org_openbuildservice_disturl="",container_label_org_opencontainers_image_created="",container_label_o
rg_opencontainers_image_description="",container_label_org_opencontainers_image_documentation="",container_label_org_opencontainers_image_licenses="",container_label_org
_opencontainers_image_revision="",container_label_org_opencontainers_image_source="",container_label_org_opencontainers_image_title="",container_label_org_opencontainers
_image_url="",container_label_org_opencontainers_image_vendor="",container_label_org_opencontainers_image_version="",container_label_org_opensuse_reference="",container_
label_pod_template_generation="",container_label_pod_template_hash="",container_label_prometheus="",container_label_release="",container_label_revision="",container_labe
l_statefulset_kubernetes_io_pod_name="",container_label_upgrade_cattle_io_controller="",cpu="total",id="/kubepods/besteffort/podb32a26d7-b940-4dce-8172-9091c0b7f255/274f
72dd18fb5c829d8a63bb0941eda804c5d44a7cbd899a21b389ff3f87b7d6",image="docker.io/grafana/grafana:9.0.5",name="274f72dd18fb5c829d8a63bb0941eda804c5d44a7cbd899a21b389ff3f87b
7d6"} 267.270606<PHONE_NUMBER>400

At least it does include an image key now:
image="docker.io/grafana/grafana:9.0.5"

Sure does spit out a lot...
$ curl http://<IP_ADDRESS>:8080/metrics | wc -l
13734

I haven't tried to disable cAdvisor from kube-prometheus-stack nor added this as a scrape yet.

Not sure if it's normal but:

there's a lot of empty labels in your metric...
you have the image label but not the container one, instead, you have container_name

Still not good :disappointed:

A little more tweaking, it looks like this:
$ curl -s http://<IP_ADDRESS>:8080/metrics | grep container_cpu_usage_seconds_total | grep grafana

container_cpu_usage_seconds_total{container_label_io_kubernetes_container_name="grafana",container_label_io_kubernetes_pod_namespace="monitoring",cpu="total",id="/kubepods/besteffort/podb32a26d7-b940-4dce-8172-9091c0b7f255/274f72dd18fb5c829d8a63bb0941eda804c5d44a7cbd899a21b389ff3f87b7d6",image="docker.io/grafana/grafana:9.0.5",name="274f72dd18fb5c829d8a63bb0941eda804c5d44a7cbd899a21b389ff3f87b7d6"} 299.354727<PHONE_NUMBER>910

I added a PodMonitor to scape metrics (have not disabled KPS cadvisor yet), within Prometheus it looks like:
container_cpu_usage_seconds_total{container="cadvisor", container_label_io_kubernetes_container_name="grafana", container_label_io_kubernetes_pod_namespace="monitoring", cpu="total", endpoint="http", id="/kubepods/besteffort/podb32a26d7-b940-4dce-8172-9091c0b7f255/274f72dd18fb5c829d8a63bb0941eda804c5d44a7cbd899a21b389ff3f87b7d6", image="docker.io/grafana/grafana:9.0.5", instance="<IP_ADDRESS>:8080", job="monitoring/cadvisor-prometheus-podmonitor", name="274f72dd18fb5c829d8a63bb0941eda804c5d44a7cbd899a21b389ff3f87b7d6", namespace="cadvisor", pod="cadvisor-tqbj6"}
| 305.831161

Slightly better maybe?

It seems to be marking everything as its container and namespace:

It seems like some items could be dropped and other stuff relabeled to get what is needed?

This is the ONLY namespace that lights up your dashboard, and it does seem like everything is lumped together :)

At least, you can kinda test the dashboard now!
Just realized I missed the label name because it was a new line!
The container label equivalent is container_label_io_kubernetes_container_name in your case (not container_name).
Even if you make this work, you will still have a pretty uncommon setup and maybe uncommon problems in the future...
Maybe it's not a big deal for you, but I feel this is far from an ideal solution...
Did you tried to post in the #k3s channel of the Rancher Slack to :

Get k3s to support your ZFS setup (feature request or support)
Explain the problem to see if anyone else had a similar problem with cAdvisor?

Left a question on #k3s slack see if I get a nibble.

Found this: https://github.com/k3s-io/k3s/issues/66, looks like ZFS support for k3s is a dead end for now...
Will this be something for you https://github.com/k3s-io/k3s/issues/66#issuecomment-520183720 ?

I'm retiring my old ZFS/Docker server to be ZFS/Kubernetes.
There are cleaner ways to get ZFS working with Docker.  Issues tended to be a race condition with Docker not waiting for ZFS filesystems to be in-place, Docker would then create a file/directory which prevented ZFS from mounting the dataset as the mountpoint was no longer empty.  There are systemd tricks you can use to force docker to wait until ZFS has completed.   Been running smooth for years since.
As to using a zvol for ext4 for that one directory to use the bundled containerd...   Potential solution, but using standard containerd works great minus this odd Prometheus label issue.  I think its just a configuration tweak to fix if we can figure out which projects needs to make it.
My understanding is Azure using containerd by default as well and LENS project has similar issues with metrics.

Hi @reefland,
Did you manage to make everything working together?
Would be cool to share it if someone with a similar setup ends up reading this thread :blush:
As it's not related directly to this project, maybe we can close this issue what do you think?

Was not able to make it work.   I do think the right course of action is to use a EXT4 formatted ZFS ZVOL for containerd and go back to the standard snapshotter to reduce complexity of the installation.   I'm not sure if I can do that level of swapping the engine out while the plane is in flight....  and I doubt I will rebuild the cluster from scratch just for these metrics.
I'll close the issue, don't expect this to be resolvable for a while.  Thank for your time on this. Much appreciated.

@dotdc - Just wanted to follow-up that I was able to get the cadvisor deployed as a daemonset working.  What I was missing with the last attempt was relabelings on the job doing the daemonset scrape.  Plus it seemed an extras space in the whitelisting of labels in the kustomize example they provide caused an issue too.
Within my Kube-Prometheus-Stack Helm chart / values.yaml section, I needed to add:
           additionalScrapeConfigs:
              # CADVISOR SCRAPE JOB for externally installed cadvisor because of k8s with containerd problems
              - job_name: "kubernetes-cadvisor"
                kubernetes_sd_configs:
                  - role: pod  # we get needed info from the pods
                    namespaces:
                      names:
                        - cadvisor
                    selectors:
                      - role: pod
                        label: "app=cadvisor"  # and only select the cadvisor pods with this label set as source
                metric_relabel_configs:  # we relabel some labels inside the scraped metrics
                  # this should look at the scraped metric and replace/add the label inside
                  - source_labels: [container_label_io_kubernetes_pod_namespace]
                    target_label: "namespace"
                  - source_labels: [container_label_io_kubernetes_pod_name]
                    target_label: "pod"
                  - source_labels: [container_label_io_kubernetes_container_name]
                    target_label: "container"

Now I have image=, container=, and pod= values:

And your dashboard lights up as expected:

This is only on my test cluster so far, but still a great sign.

Hi @reefland,
Really happy to learn that you finally managed to fix this and able to use the new version of the dashboard! :partying_face:
Thanks for sharing your settings, it may help someone using a similar setup!
Wish you a happy holiday season!

Thank you!
Another update... I yanked the external cAdvisor daemonset.   Prometheus started to constantly complain about duplicate, out of order and dropped labels. Hundreds per second.  It just felt like I was digging a deeper and deeper hole.
So instead node by node, I yanked the external containerd /  runc / ZFS snapshotter.  I moved the /var/lib/rancher to the side, added a 30GB ZVOL formatted with XFS and mounted it to /var/lib/rancher.   Removed the tweaks added to the k3s and k3s-agent services for an external containerd. And copied back in the directory structure.
Was able to swap out all this without a reinstall and no down time. I'm luv'n Kubernetes :)
So I still have all the pluses of ZFS on bare metal (mirrors, compression, encryption, snapshots, boot environments, rollbacks) and the one important directory for K3s is now on a ZFS backed (mirrored / compression / encrypted) XFS filesystem (which allows easy volume expansion in the future if I need it).   And K3S can use its default overlayfs and all the metrics just magically work.
Even dashboards from Mixin which have never worked for me, started to light up within seconds of the first node being converted:

I'm monitoring my system logs, everything looks great, Prometheus is happy. All my dashboards are working as expected with a standardish K3S "default" install.


querySelectorAll not working the same as dev console.

Bug description
This might not even be a bug.
This is for a project with 2captcha. I am trying to get the sitekey or data-sitekey of a div with a captcha, in this specific page.
On Stack Overflow, i found this question and i used the code's answer to try to get the sitekey.
On the browser's console, it works.

But in VS Code, the code is not returning anything.

Is there something i am missing?
Puppeteer version
1.1.3
Node.js version
16.17.0
npm version
8.19.2
What operating system are you seeing the problem on?
Windows
Configuration file
const browser = await puppeteer.launch({
        timeout: 1000000,
        waitUntil: "networkidle2",
        args: [
          "--disable-gpu",
          "--disable-dev-shm-usage",
          "--disable-setuid-sandbox",
          "--no-first-run",
          "--no-sandbox",
          "--no-zygote",
          "--disable-features=IsolateOrigins,site-per-process,SitePerProcess",
          "--flag-switches-begin --disable-site-isolation-trials --flag-switches-end",
        ],
        devtools: false,
        headless: false,
      });

      const page = await browser.newPage();
      await page.setViewport({ width: 1280, height: 720 });

await page.goto('http://validate.perfdrive.com/e322ed16d936a33af2290341348fc02b/?ssa=71f034b9-fe4a-425e-9cfa-679daf62f698&ssb=26670295055&ssc=https%3A%2F%2Fsfc.sistemascr.com.br%2Fautorizador%2FMenuWeb%2FINSS%2FDadosBeneficiario%2FUI.CD.DadosBeneficiario.aspx&ssi=e6b0498e-bqq7-4f9f-b28e-ba5a2f85a74a&ssk=support@shieldsquare.com&ssm=1323577568833067218018566818224215&ssn=80547da664534bba3c8bcf9d9998f4d074f1b3d1c3c6-71c6-48df-aba00f&sso=b340a98e-f516c43fa44c703f5d229e62e1304d444bac3d190c22277b&ssp=73301035451668642896166860736834877&ssq=74464052002568640130317986228661056232925&ssr=NDUuMjM1LjE5My4zMg==&sst=Mozilla/5.0%20(Windows%20NT%2010.0;%20Win64;%20x64)%20AppleWebKit/537.36%20(KHTML,%20like%20Gecko)%20Chrome/74.0.3729.169%20Safari/537.36&ssv=&ssw=&ssx=W10=', {
        waitUntil: "domcontentloaded"
      });

await page.waitForSelector('.h-captcha');
          const el = await page.evaluate(() => {
            return document.querySelectorAll('.h-captcha');
          })
          console.log(el);

Relevant log output
el returns as:
{
  "0": {
  },
}

Hey, please try using the latest version! Also, it does not look like a bug: .querySelectorAll is exactly the same as it is evaluated in the page context. There is a difference in console implementation between devtools and nodejs though so it might explain different print outs. E.g., DevTools references the live object and allows interacting with it and NodeJS only serializes to text. Also, you cannot really copy elements across the process boundary so page.evaluate returns a reference (ElementHandle) and that is what gets printed.

@OrKoN I'm using the latest version. I wrote it wrong in the issue.


closes #8

properly labeled this one to the correct issue this time

Good job on adding the export feature, TJ.


Try this

global.unpackPos(global.packPos({x : 48 , y : 21, roomName:'W16S78'}))
result in :
[room W17S78 pos 48,21]

#5


Get user username when scraping by location?

Hi! I need to get the username for posts scraped by location. I understand we can't use the -t flag for custom templates, and looking through the source code shows me that the username variable is in fact simply the input from the CLI - so even when using --location the location ID is saved as username in the code.
Is there not a way to get the real username from the post metadata? All I got where some owner-id's, but I need the actual username (@handle).
Edit: just saw that the API does not return that info :/.

Hi, did you solve the issue?


Prevent CI from running when only comments have changed

Currently we do not run CI if only css, md, html,... files have changed.
We should further modify this so that it does not run when only:

[ ] (doc) comments have changed in rs files
[ ] (doc) comments have changed in .roc files

I'm interested to work on this, but after making changes, how to test it. I don't even know how to check the situation:
where if I modify a comment in a .roc file, the CI is running or not?

Are you able to make a PR against your fork of the repository maybe? That might allow you to see if the change trigger the action?

Yeah, I think with a PR against your fork you can test it.


Allow passing pre-allocated buffers to VarCharVector

Describe the bug, including details regarding any error messages, version, and platform.
Allow VarCharVector and LargeVarCharVector to let the caller take in a pre-allocated buffer. The Text class was originally designed for this purpose but VarCharVector does not currently let the caller supply their own Text object.
The purpose of this change would be to allow a caller iterating through a VarCharVector to re-use a buffer without having to do extra allocations.
Component(s)
Java

take


Broken initial state

Hey, thank you for a PR! Can you provide any additional information? Looks like 1.2.2 ver. works for me.

I added a test that checks the rendering. Also updated the dependencies and added the initialState. Just in case, added a check for the existence of the instance where it is used


Configure wm_metadata access through different repo

This adds one line to build.sbt
    "com.github.kwalcock" % "Ontologies" % "master-SNAPSHOT",

to fetch a jar containing /org/clulab/wm/eidos/english/ontologies/wm_metadata.yml that can be used in eidos more or less as if it was really in the local /src/main/resources directory.
The location contains a forked version of the WorldModelers/Ontologies project with three small changes:

a fairly simple build.sbt has been added
the README.md file was updated with a jitPack icon
the repo was configured for use with jitPack

The last one might be the sticking point.  Someone with sufficient privileges needs to arrange this.
There are options other than "master-SNAPSHOT", and one might want to use a tag or release instead of whatever happens to be in master.

@kwalcock is there a way to do this without the fork?  as in if we configure the real repo with the jitpack bells and whistles and the build.sbt, could we use it directly?  would we want to do that anyway? or does that stuff not belong in a shared repo...? (ping @MihaiSurdeanu too)

btw -- YAY!

Yes.  I didn't explain that well.  Can you do to the real repo what I did on the fork?  I could try to PR the fork, actually, if that's the thing to do.  I'm probably not allowed to hook it to jitPack, though.

I PR'd the fork to WorldModelers/Ontologies last night in case it is helpful.  A tool like http://www.yamllint.com/ might likewise be useful.  The original wm.yml appears to be valid even while wm_metadata.yml is not.  Does this imply a problem with strip_metadata.py?
There is a test TestDomainOntology, but it would not have caught the problem, because the file names are hard-coded there and the new one was not included.  It probably does this so that eidos doesn't have to be loaded, which couldn't happen if there's a problem with the ontologies that eidos uses.  There's a PR in the works with this test added.
FYI @vanh17

awesome, thanks! and yes I like the idea of a linter for the yaml!
Especially since others are potentially using this ontology.  Can we set it
up as a github PR-hook-thing? (kinda like we do with travis chez nous?)
On Thu, May 30, 2019 at 8:55 AM Keith Alcock<EMAIL_ADDRESS>wrote:

I PR'd the fork to WorldModelers/Ontologies last night in case it is
helpful. A tool like http://www.yamllint.com/ might likewise be useful.
The original wm.yml appears to be valid even while wm_metadata.yml is not.
Does this imply a problem with strip_metadata.py?
There is a test TestDomainOntology, but it would not have caught the
problem, because the file names are hard-coded there and the new one was
not included. It probably does this so that eidos doesn't have to be
loaded, which couldn't happen if there's a problem with the ontologies that
eidos uses. There's a PR in the works with this test added.
FYI @vanh17 https://github.com/vanh17
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/590?email_source=notifications&email_token=ABJCPCLTBFRLP2RPC3HWJATPX72FXA5CNFSM4HQ5JRPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWSW5DY#issuecomment-497381007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJCPCKGGHZKOIJOHM6ZEOLPX72FXANCNFSM4HQ5JRPA
.

Well, probably, but I'd do at least two other things first: see if build.sbt and the connection to jitPack work at all on the Ontologies repo, and then modify strip_metadata.py to at least first do a formal parse of wm.yml to make sure it's a valid file.  For bonus points it could also check the resulting file.  The eidos unit test for the ontologies just uses org.yaml.snakeyaml.Yaml which will complain on a malformed file and then it also double checks for duplicates, etc.  An internal test would be more feasible than an online (page or service) for linting.

Fair enough. I am trying to get ready for the demos, but i’ll try to work
some on this soooooooon
On Fri, May 31, 2019 at 10:00 AM Keith Alcock<EMAIL_ADDRESS>wrote:

Well, probably, but I'd do at least two other things first: see if
build.sbt and the connection to jitPack work at all on the Ontologies repo,
and then modify strip_metadata.py to at least first do a formal parse of
wm.yml to make sure it's a valid file. For bonus points it could also check
the resulting file. The eidos unit test for the ontologies just uses
org.yaml.snakeyaml.Yaml which will complain on a malformed file and then it
also double checks for duplicates, etc. An internal test would be more
feasible than an online (page or service) for linting.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/590?email_source=notifications&email_token=ABJCPCIC4ZXVQF5RNQJAY33PYFKT7A5CNFSM4HQ5JRPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVZTUI#issuecomment-497785297,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJCPCMIX6CPZTRA2T2KBCDPYFKT7ANCNFSM4HQ5JRPA
.

This now fetches the wm ontology from WorldModelers/Ontologies which has been attached to jitPack.

I don't think that eidos is configured to use this ontology right now, but it is being tested, and so apparently fetched properly.

Should we also point eidos.conf to point to this ontology?

Yes, it can be added back in now.


Which JWT module does oauthlib depend upon?

I installed oauthlib 2.0.1 using the virtual environment support in the pyCharm IDE. When running a short test program, I get an exception from oauthlib/oauth1/rfc5859/signature.py line 473 where it tries to execute:
import jwt.algorithms as jwtalgo

I've installed a module called "jwt" version 0.3.2 and that didn't solve the problem. Obviously that is not the JWT module it expects to be using, since it doesn't have an algorithms module.
Which JWT module does oauthlib depend upon, because there's about 30 different modules available with the word "jwt" in their name!
It would be good if this was documented in the installation instructions. Thanks.

Never mind. I found the answer in the "OAuth 2 ServiceApplicationClient and OAuth 1 with RSA-SHA1 signatures say “could not import jwt”. What should I do?" question at https://oauthlib.readthedocs.io/en/latest/faq.html


[ES] Add more sentences to test getting the temperature

Particularly I added masculine examples and examples that used "de la / del" instead of "en la / en el", which is also a valid way command that wasn't tested.

Somewhat unrelated, but I figured out why ¿Cual es la temperatura del salón? didn't work for me. It was because my living room didn't have a thermostant entity on it, it had a temperature sensor instead.
Turns out temperature sensors are not valid targets for temperature queries, and I don't think that's right. It doesn't seem exclusive to spansh language. I have temperature sensors in my pool and in my greenhouse, none if which will ever have a thermostat. That seems like it should change.

About this, I would open a different issue, as it's unrelated to the language.

@davefx I opened this issue: https://github.com/home-assistant/intents/issues/2469
I'm still not sure if this belongs on this repo or on HA Core, but someone will tell me either way.


[Bug]: App card is created even when app import fails and no action can be performed on this app card

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
App card is created with no timestamp details when app import fails. This app card is a placeholder and performing any action like edit or launch throws a resource not found error.

Steps To Reproduce

Try to import a corrupt app and observe an internal server error displayed when import fails
Refresh the page and observe an app card created for this app and have no timestamp details.
Clicking on Edit or Launch does not yield expected behaviour instead shows resource not found

Environment
Production
Version
Cloud

This happens even when app duplication fails - except in this scenario the dummy app card created has timestamp details

@ramsaptami re-iteration here to keep the expectations consistent, in failure scenarios server should throw a friendly error message and the app card should not show up. Is there anything other we are looking for?

Yep, think that should be good

reducing priority since it doesn't break an existing app

Stats

Stat
Values

Reach
28

Effort (months)
0.25


style(Checkbox): update docs to the latest standards

Current coverage is 100% (diff: 100%)

Merging #839 into master will not change coverage

@@           master   #839   diff @@
====================================
  Files         137    137
  Lines        2244   2244
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits         2244   2244
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 3ba4c79...ddbda18


OutgoingResponse.prototype.flush is deprecated

OutgoingResponse.prototype.flush is now deprecated. Prefer the new flushHeaders method.
See:
https://github.com/expressjs/compression/blob/master/index.js#L69
https://github.com/nodejs/node/wiki/API-changes-between-v0.10-and-v4

Can you provide the full code that reproduces that? We run tests on all versions of Node.js and none of them cause that message to be printed.

There will be no output.
The node project just marked that as deprecated in their documentation.

Yes, but that's you calling that method on Node.js core; it was deprecated because this module was already using it, i.e. it was deprecated so this module could use it :)

I am not sure I understand.
This is deprecated for node 4, but on 6 and later I am not sure what the status is.

What is deprecated is calling the res.flush method provided by Node.js. This module never calls that method, instead it is installing a completely different method with the same name that is not deprecated. One of the reasons the Node.js method was deprecated is because they choose a name that conflicted with user land modules like this one, so the name was changed so we could continue to provide the res.flush method.

Ok, makes sense. Thanks for the clarification.


Sensor subscription levels tag

Description:
Settings page would have a way to show features available on shared sensor
Waiting for Cloud implementation https://github.com/ruuvi/ruuvi.cloud.js/issues/388
Example:
Free user would see Pro feature greyed out
Tap on the greyed out feature to see what Pro subscription offers
Original idea was to show coloured tag label with for example Pro

Closing this, since we have other way to implement this


Update not working

Just found this and installed the "server" on one of my docker hosts. I then added the agents to my 3 other docker hosts. Those are able to be updated with the docker pull. I am unable to get "beszel-agent update" to work on all of the hosts and VMs that I installed the agent on as a system service using the curl command to install and configure. Should I just re-run the curl command and restart the service? Planning to make an ansible playbook for this so I just need to know the correct approach.

That approach works, but I'd also like to fix the update command if it's broken.
Just to be clear, you're running the agents as binaries, right? And running ./beszel-agent update?
If running the hub as a binary, the command would be ./beszel update
Just tested linux amd64 and it seems to work. What version are you using?

Just to be clear, you're running the agents as binaries, right? And running ./beszel-agent update?

This works for me as well. The instructions don't mention the "./" so I didn't use it. Not used to doing updates like that as most are apt-based. I will start working on my playbook to get the rest updated.
Thanks!

Yeah no worries, it's just a subcommand built into the binary so you have to run it on the file.
If you want the command to be available globally, you can put the file in /usr/local/bin, then you should be able to run it without the ./


Normalize and standardize newlines

New lines are starting to become a headache around when changie adds them compared to when they are expected from formats, files or anything else. This may introduce visual differences but I do not think it is backwards incompatible and can be done in a minor release.
Solution 1:
Remove all manual new lines and expect files and inputs to be handled by the end user
Solution 2:
Add a newline before and after all supplied files and formatting
Solution 3:
Create configurations for when to add new lines and when not to, for example before + after headers, footers, changes, kinds, components, etc
Solution 4:
Create configurations but only for files and templates.
Solution 5:
Just like solution 3 but with numbers instead of bools... just cause you might want to have more than one empty line.
Solution 5 works the best, a separate "Newline" section to config would make the most sense.
Something like:
Config:
  Newlines:
    BeforeVersion: 0
    AfterVersion: 1
    BeforeComponent: 1
    AfterHeaderFile: 0
    AfterFooterFile: 0
    ... etc

As I mentioned in https://github.com/miniscruff/changie/issues/119#issuecomment-1133744100 I have some questions, maybe I misunderstood the format:
Newlines configs should be in the .changie.yaml, If so where is it fit in the yaml file?

I was thinking the later with some capitalization changes, to match typical yaml key values.
newlines:
 beforeVersion: 0
 afterVersion: 1
 beforeComponent: 1
 afterHeaderFile: 0
 afterFooterFile: 0

I'm busy this week, I can work on this on the weekend, and maybe think on the issue over the week :), if it is fine with you then I would like you to assign it to me.

I'm busy this week, I can work on this on the weekend, and maybe think on the issue over the week :), if it is fine with you then I would like you to assign it to me.

No worries, I don't plan on shipping anything too soon. I will assign it to you, just unassign it if you become too busy to work on it.


Automating Testnet and Futurenet Reset Data in Stellar

Bounty PR for Issue #608

@briwylde08 this is ready for review.

Thank you for the submission! We'll get this assigned and reviewed.

Hi @ElliotFriend , Thank you so much for the reviews and feedbacks 😁.
I have updated and made some changes, Including Adding a CreateLiquidityPool and DeployContract scripts.
also I updated the IssueAsset script too and corrected the nitpicks you pointed out.
kindly please review again, Thank you.

Alright , Thank you for this Feedbacks @ElliotFriend , I will look into now and make necessary changes.

Hello @ElliotFriend , I made neccssary corrections and updated the code walk flows too.

HI @ElliotFriend , GM!
I have updated the scripts.
For the createAccount I made is flexible for users to restore their account or create an account.

Hi @KodeSage! Thank you again for another great submission! We'll get this merged and take the award conversation back to the corresponding issue.


[backport] Change Deformable Convolution 2D docs to match arguments

Backport of #7402

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit c9f9c628a8a5eb38a995fee0e29c1915062b1062, target branch v6) succeeded!

LGTM!


Cherry-pick the fix for #314 and push it to 1.x

SSIA

Thank you very much. I have applied it by directly using git cherry-pick -x 240ffb9 though. Ended up as commit e33e464d3 in 1.x.


Clicking "delete" on user-defined function in a for loop deletes the for loop.

Clicking "delete" on user-defined function in a for loop deletes the for loop.
brick-pattern.mob.zip

fixed


Added missing answer

added an answer for Node-26) What are some of the most popular modules of Node.js?

also added missing answer to JSGeneral-4) What are the pros and cons of functional programming vs object-oriented programming?


Fixed HHH-11157 and extended identifier handling

@beikov, thanks for the pull request! We still need add a test case for this, so please add a commit with a test case.

Well, actually the testcase for HHH-9329 could have already caught that error if the tests were run on Derby, but apparently they aren't. Maybe you need to add a build matrix entry for that?
Anyway, I would still like to add a flag for disabling this behavior just in case and add some tests for other databases with special identifiers.

@beikov There's an easier way to test on any DB. All you need to do is just run:
> gradle clean test -Pdb=derby
The databases.gradle contains all the supported DBs we use for testing. There you can also customize your own DB credentials if they differ.
I'm going to test this PR against the WithClauseTest on Derby.

Tests running just fine on Derby now and on H2 as well. Applied upstream, thanks.


feat(python): Set up for fine tuning: basic QADataset and chat completion model

Very WIP. I'm thinking of merging individual pieces in this feature branch instead of main so we can still review code in pieces and avoid polluting main.

Adds support for creating corpus from llama-index text-node object (aim to remove this dependency)
Adds very basic support for LLM api for chat completion, will expand as need arises.

let's have this in a separate directory (i.e., a peer of the python subdir) or perhaps a different repo even for now so we can move quicker?

So the target branch for this is not main, which should be similar to having a separate repo...Or did you want to develop this as a plugin that lives outside the the main repo/

This branch is fked after rebasing. Will open a new PR


Ran cargo update

What does this PR do?
Updates to the latest dependencies.
Motivation
Avoid dependabot alert.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
For Reviewers

[ ] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
[x] This PR doesn't touch any of that.

I have merged in main and downgraded a few libs to maintain Rust 1.69 compatibility.


Disable dismiss efect

I have this code:
    <Lightbox
                        navigator={this.props.navigator}
                        activeProps={
                            {
                                style: {
                                    width: Dimensions.get('window').width,
                                    height: Dimensions.get('window').height
                                },
                                resizeMode: 'contain'
                            }
                        }
                    >
                    <Image
                        source={require('../Resources/centro.png')}
              resizeMode= {Image.resizeMode.cover}
              style={{height: 120, flex: 1}}
                    />
          </Lightbox>

The problem is the effect when image dismiss.
The effect run perfect but i have diferent "resize mode" in full screen and in normal mode.
How can i disable the effect? The effect image istn similar in size and position that the real image in resizeMode 'contain'.
Edit: I like more the effect image than the real image on "Image" item. How can i reproduce it?
Some screens for explain better:
Image during effect (overlay navBar) :

Final Image on cover mode:

I'm having the same issue while dismissing the lightbox.
Can we disable all animations for opening and closing the lightbox ?

+1

+1

Has anyone found a solution for this yet?

set this
springConfig={{tension: 900000, friction: 900000}}

Thanks @harrydema I'll give that a go and report back.


fix: changed the font of table

Resolves  #467

@AnakinSkywalkeer please make sure you post the QA link before asking for a review. If its not done yet, please make the draft PR.

@AnakinSkywalkeer please make sure you post the QA link before asking for a review. If its not done yet, please make the draft PR.

sure


Insufficient documentation for supplying env variables to an action

https://stackstorm-community.slack.com/archives/community/p1450470647008498
Reported by: Justin Mound on slack.

The log link went stale. @lakshmi-kannan please elaborate, issue title makes little sense to me.


feat: add go 1.22

add both alpine and debian-based variants

FYI I've pushed the 1.22 on https://github.com/vbehar/devspace-containers/pkgs/container/devspace-containers%2Fgo
from this branch: https://github.com/vbehar/devspace-containers/tree/go


Upgrade Guice to 5.0.1+

Is your feature request related to a problem? Please describe.
Finatra depends on Guice 4.2.x which depends on cglib which is no longer being developed and has not been updated to the new JDK9+ module system. See this Guice issue for more discussion.
Describe the solution you'd like
Upgrade Guice from 4.2.x to 5.0.1+.
Describe alternatives you've considered
With Guice 4.2.x's use of cglib, users need to add --add-opens java.base/java.lang=ALL-UNNAMED or something like it to their JVM startup options.
Additional context
N/A

@greggdonovan Thanks for the issue, please note that Finatra is still only targeted to work with JDK8 at the moment (and soon JDK11).

@cacoco Thanks! FWIW, we've been running Finatra for a year in production with JDK11 with no issues. This issue came up during testing of our JDK16 upgrade.

@greggdonovan that's great! Thanks again for the issue.

Any update on the timeline for next supported version of JDK?

@redkhalil we're targeting JDK11 support for Q1 or Q2 of 2022.


Multline comments getting flagged with fct_hard_coded_references

While fixed for ordinary comments:
https://github.com/dbt-labs/dbt-project-evaluator/blob/9f9c1db78e0382abb75a688a07a9196bf5fb171e/macros/find_all_hard_coded_references.sql#L17-L20
Mentioning table names inside multline comments
/*
my_database.my_table
*/

will result in a failure.
~For now I switched from multiline SQL comments to jinja2 comments (which are multiline by default)~
Switching the jinja2 multiline comments also does not cut it and gets flagged.
{#
my_database.my_table
#}

Fixing this could be nice 🙇 . Thanks!

I think this is where we reach the limits of what we can do with some already complex (but not insanely complex) regex.
I'd say that the best here is either to add the line comment in your multiline comment
/*
this is some comment
-- my_database.my_table
and this is some comment as well
*/

or use Jinja comments like you did
or convert your multi-line comments to multiple single-line ones

We could technically fix your specific use case, but I don't really want to then have to maintain it for all the combinations of multiline comments for every supported data warehouse


[Crossdata-482] ADD APP implementation

Description
ADD APP myApp.JAR [AS report] WITH MAIN CLASS com.mycompany.myApp": This sentence makes Crossdata to send the JAR to HDFS. "report" is an optional alias of the JAR (by the default, the alias will be the name of the JAR file). In addition, Crossdata must keep the relation among hdfs path of the JAR file, the alias and the main class with the alias as key.
Testing

[x] Unit, integration tests
Added a test to DriverIT tests

Documentation

[x] https://stratio.atlassian.net/wiki/display/CROSSDATA/Reference+Guide#ReferenceGuide-AddAppCommand

This PR is included in https://github.com/Stratio/Crossdata/pull/563


X-CSRF-Token header is missing due to mismatch in operationName and OperationMetadata keys

Bug description
In the newest<EMAIL_ADDRESS>I noticed that the X-CSRF-Token header is no longer present in the requests, causing the WunderGraph backend to reject the request.
I think this is due to this comparison, where the keys in operationMetadata no longer match the actual operation names, causing this if condition to always evaluate to false. For example, if I define an operation in .wundergraph/operations/images/GetImages.graphql, the operationName becomes images/GetImages while the key in operationMetadata is ImagesGetImages.
How to reproduce
see above
Expected behavior
No response
WunderGraph information
<EMAIL_ADDRESS>Environment & setup

OS:
Go version:
Database:
Node.js version:

WunderCtl Version
wunderctl 0.127.0

Thanks for reporting. We'll have a look.


UNR-1000 make sure all dirty blueprints are compiled before schema generation

Description
Make sure that all "dirty" blueprints are compiled before schema generation. If there are errors compiling blueprints, fail schema generation and output error messages specifying which blueprints were causing issues.
NOTE: this PR requires these changes to the engine to be merged in first!
Release note
"Bugfix:" Automatically compile all dirty blueprints before schema generation.
Tests
Prior to this PR, changes that were made to blueprints did not get picked up by schema generator unless the blueprints were explicitly compiled before generating schema. You can see that by making changes to a BP, generating schema, going back to the BP window and observing that the compile button has a question mark on it, showing that the BP is still dirty and has not been compiled. When you run the game, you can see that changes to the BP have not been picked up.
With these code changes, you'll see that after schema generation compile button will have a green tick on it for all the changed BPs, showing that they have been compiled. If any BPs have compilation errors, schema generation will fail and output error messages. If you now run the game, you can see that changes to BPs have been picked up.

The required engine PR has now been merged into 4.20-SpatialOSUnrealGDK branch. @m-samiec let me know if you're ok with this PR going in now.

As this change requires an engine rebuild - lets hold off merging until the BK pipeline has been merged. Will update here when it's gone in.


Issue with Rollup Functions

I'm gettting very odd behaviour using the Rollup Functions action. When I run the action with this query it runs fine:
<?xml version="1.0"?> <fetch distinct="false" mapping="logical" output-format="xml-platform" version="1.0"> <entity name="opportunity"> <attribute name="estimatedvalue"/> <attribute name="opportunityid"/> <order descending="false" attribute="estimatedvalue"/> <filter type="and"> <filter type="or"> <condition attribute="customerid" value="{{Record ID(Get Record ID)}}" uitype="account" operator="eq"/> <condition attribute="xrmt_targetedentity" value="{{Record ID(Get Record ID)}}" uitype="account" operator="eq"/> </filter> <condition attribute="statecode" value="2" operator="eq"/> </filter> </entity> </fetch>
Now when I go and change the statecode filter value in the last filter condition from "2" to "0" suddenly the action fails with the following error message:
[msdyncrmWorkflowTools: msdyncrmWorkflowTools.RollupFunctions]
[msdyncrmWorkflowTools (<IP_ADDRESS>): Rollup Functions]
Load CRM Service from context --- OK _FetchXML=<?xml version="1.0"?> <fetch distinct="false" mapping="logical" output-format="xml-platform" version="1.0"> <entity name="opportunity"> <attribute name="estimatedvalue"/> <attribute name="opportunityid"/> <order descending="false" attribute="estimatedvalue"/> <filter type="and"> <filter type="or"> <condition attribute="customerid" value="{1304ab78-ebff-e911-a811-000d3a6540e8}" uitype="account" operator="eq"/> <condition attribute="xrmt_targetedentity" value="{1304ab78-ebff-e911-a811-000d3a6540e8}" uitype="account" operator="eq"/> </filter> <condition attribute="statecode" value="0" operator="eq"/> </filter> </entity> </fetch> Value: 8a3cac22-5d05-ea11-a811-000d3a65469c Value: f9c664d9-8e0f-ea11-a811-000d3a654d16 Value: 1511de66-900f-ea11-a811-000d3a654d16 Value: Microsoft.Xrm.Sdk.Money Query Data --- Done
Strangely it seems the query itself is being executed without issue, and to me the error that does pop up seems strange, as the first field in the fetch is a monetary field.
*Tried changing the filter to "1". works perfectly as well...
*Tried removing the status filter entirely, results in the same issue
*Tried using a filter condition with operator="in" to include al statuses, results in the same issue
*Tried using a filter condition with operator "not-null" for the statecode, results in the same issue
*Tried a And clause with a "ne" filter on status 1 and 2. Also no luck :(
now moving to query leads with the rollup functions it reacts the exact opposite way and ONLY accepts the query with lead status = "0"
It's getting impossible to reach my goals using this plugin. For me this seems to be a major bug (at least it's really bugging me..).
I'm out of ideas here. Any help would be much appreciated!

@xrmthomas I've just faced the same issue.
It happens because one or few (I didn't check this) records in your query has blank field estimatedvalue, so plugin uses next field, which is GUID and it crashes when trying to execute this:
https://github.com/demianrasko/Dynamics-365-Workflow-Tools/blob/7514493ecac43534637157897b976da99cfad93d/msdyncrmWorkflowTools/msdyncrmWorkflowTools/Class/RollupFunctions.cs#L203
@demianrasko — in previous versions we could use non-decimal/non-money fields in first attribute of fetchXML. Cause in most cases we just need to count records. In version 55 we could use this FetchXML and it worked
<fetch version="1.0" output-format="xml-platform" mapping="logical" distinct="false" >
   <entity name="gg_container" >
        <attribute name="gg_containerid" /> -- GUID
        <order attribute="gg_containerid" descending="true" />
        <filter type="and" >
               <condition attribute="statuscode" operator="eq" value="140120011" />
               <condition attribute="gg_bookingid" operator="eq" value="{PARENT_GUID}" />
           </filter>
       </entity>
   </fetch>

But in version 57 it started causing crashes, cause it hasn't money/decimal fields, so we:

Added it
Forced Dynamics to populate field

So, our Fetch now looks like:
<fetch version="1.0" output-format="xml-platform" mapping="logical" distinct="false" >
	<entity name="gg_container" >
		<attribute name="gg_loadweight" />  -- Money/Decimal field
		<attribute name="gg_containerid" /> -- GUID
		<order attribute="gg_containerid" descending="true" />
		<filter type="and" >
			<condition attribute="statuscode" operator="eq" value="140120007" />
		    <condition attribute="gg_bookingid" operator="eq" value="{PARENT_GUID}" />
		</filter>
	</entity>
</fetch>

Can you smth with it and return us ability not to use money/decimal fields in FetchXML, please!

Thanks miklemiracle for the explanation, I think that if maybe I return a "0" instead an exception it should work. I just updated a fix for this.
Thanks!


Feature/translations 0 0 59

thanks man 🙏  i really could have helped with this .. would have saved you time. I didnt realise at the time the repurcussions of adding the boolean   😢

It's alright man. I wasn't very specific about this on the refactoring either.
In general don't like leaving things like these for later, as the more time goes on, the harder it is to refactor, as things get built on top of it. As they accumulate, it all very quickly becomes a mess of postponed work.
Only thing left I'm not quite satisfied about is the dynamic boolean field. We could retrieve the subscription model and use it in the app same way we use UserNotificationsSettings and have a single API for updating these but was a bit too much work already.
Let's do that as soon as we touch the subject of community/user notifications later on.


support elasticsearch auto re-index with zero downtime via alias switch

Support elastic search auto-re-index
Use alias switch to achieve zero down time.
If it is first time index created or alias does not exist yet, create new alias for the first time
The job will be schedule running ever 12hrs, so our search data can be kept up-to-date. In the past, this was manually done every few weeks
The index alias name can be defined in elastic search ETL job configuration file
The index mapping data model changes for 5.5
The index mapping file location needs to be specified in job configuration file via env variables

Coverage remained the same at 25.862% when pulling ed4fe1a54201a18e6eb162ba0e45b760af1ac11d on camelliazhang:master into d2cba22f5c13120d360e38e6d5289c43e3fa6cd1 on linkedin:master.

try again

Restart build as the previous travis build gets terminated (not sure why)

Added changes in template of es ETL job.

Removed extra spaces, thanks for pointing that out.

Coverage remained the same at 26.307% when pulling 54237ff5ca448e99cd8a1687ab02faaaeecf3c57 on camelliazhang:master into f18ddd92b5c3e687013e746d229d5c1626b29663 on linkedin:master.

Coverage remained the same at 26.307% when pulling 54237ff5ca448e99cd8a1687ab02faaaeecf3c57 on camelliazhang:master into f18ddd92b5c3e687013e746d229d5c1626b29663 on linkedin:master.


feat!: migrate to postgresql

So far the experiment is a success 👀
I'll be monitoring for a bit before officially merging this


FWXV-195 Pedal Logic Test

@Bafran @ay0fasan Just checking in with this PR. What's the state of this? Does more need to be done?


fix: Billable - Billable toggle should have a locked icon in split details view.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/43756
PROPOSAL: https://github.com/Expensify/App/issues/43756#issuecomment-2167844911
Tests

Billable option is set to default to billable on Old Dot

Go to workspace chat
Split a manual expense with billable toggled enabled
Click on the split preview
Verify the switch button is locked and has disabled cursor.

[x] Verify that no errors appear in the JS console

Offline tests

Billable option is set to default to billable on Old Dot

Go to workspace chat
Split a manual expense with billable toggled enabled
Click on the split preview
Verify the switch button is locked and has disabled cursor.

QA Steps

Billable option is set to default to billable on Old Dot

Go to workspace chat
Split a manual expense with billable toggled enabled
Click on the split preview
Verify the switch button has locked icon and has disabled cursor.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/e442e714-b334-4541-bdf8-637d9025fa81

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/3900cd74-5460-4ee6-b2ae-436f1eece788

iOS: Native
https://github.com/Expensify/App/assets/85894871/82c7a707-3856-4994-9223-7ef4fb1e1960

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/1a47987e-cd9c-4f0d-ab2e-ab2420425c2d

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/072945ee-7ce8-4896-8b9a-9980537e7433

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/4cf2e14a-2d26-42b6-bebd-a6e0e9c61ea1

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add flexible instance types support for ibmcloud

@yoheiueda @Amulyam24 @huoqifeng @stevenhorsman does anyone of you or from your team want to handle this issue ?
Unfortunately I don't have access to a paid IBM cloud account and won't be able to test the code

@bpradipt , let me talk it with @stevenhorsman and assign it to right person.


fix(configtree): update sentinel key when tree is imported in etcd

Description
This PR adds the logic to update the sentinel key when config is imported into etcd.
Wrike Task: https://www.wrike.com/open.htm?id=1459385386

:tada: This PR is included in version 8.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CentCom Hardsuit

Adds a centcom ERT hardsuit which can be used during events where the central commander needs to not die via atmospheric loss.

:cl:

add: CentCom Hardsuit

pull master real quick and delete the empty file you have

I deleted the file and made sure it's pushed to most recent, I think it should be okay now?

yeah


Error codes for compiletime and runtime exceptions.

Added error codes for all compiletime and runtime exceptions. This will help with unit testing for failure cases.
Use an enum for every different error (eg DIVIDE_BY_ZERO, LIST_SIZE_NOT_INTEGER, STATEMENT_END_EARLY, etc). Have strings for all the different error messages.

Refactored Runtime exceptions to use different exception classes.


add per-environment tags to kombustion.yaml

Completes work on #70

Pull Request Test Coverage Report for Build 430

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.825%

Totals

Change from base Build 429:
0.0%

Covered Lines:
636

Relevant Lines:
1597

💛  - Coveralls


PNG to WEBP silently fail and create 0 byte image

Are you using the latest version?
Yes
Is the version currently in use as reported by npm ls sharp the same as the latest version as reported by npm view sharp dist-tags.latest?
$ npm ls sharp
--<EMAIL_ADDRESS>$ npm view sharp dist-tags.latest
0.25.1

What are the steps to reproduce?
I have a PNG image of 215ko (542px x 700px) that I want to convert to webp. I'm using the following code. Once the code is completed, there is a new file with the expected filename having 0 byte. I used then and catch with console.log on the promise to see what is happening, but I got nothing.
If I resize the image (....clone().resize(250).webp(...) before the webp transformation, it works. A memory error? I'm converting other large images and it works fine.
What is the expected behaviour?
I expect a new webp image generated, and if not, an error to be thrown.
Are you able to provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem?
const initialPipeline = sharp(filePath);
...
filename = `${baseDest}/${fileName}.webp`;
pipeline
  .clone()
  .webp({
    quality: 80,
  })
  .toFile(filename);

Also tried with:
sharp.cache(false);
const initialPipeline = sharp(filePath, {
  sequentialRead: true,
});

Are you able to provide a sample image that helps explain the problem?
Unfortunately, I cannot make this image available publicly.
What is the output of running npx envinfo --binaries --system?
$ npx envinfo --binaries --system
npx: installed 1 in 2.613s

  System:
    OS: Windows 10 10.0.18363
    CPU: (8) x64 Intel(R) Xeon(R) CPU E3-1505M v6 @ 3.00GHz
    Memory: 8.19 GB / 31.81 GB
  Binaries:
    Node: 10.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.15.2 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD

If you're able to share the image privately, please use the email address in https://github.com/lovell/sharp/blob/master/package.json#L5

@lovell Thank you! I just sent you the image :)

I cannot reproduce this using the sample image and code. Please can you provide a complete, standalone code sample. Perhaps there is logic not shown here that is (re)moving files on the filesystem?

Oh well, I feel bad right now...
Sorry for your time, it was my mistake. It is part of a larger resizing scripts. Unfortunately, I was not awaiting the promise for the original webp transformation. It was working for some images, but not this one.


each chapter should have an owner/maintainer

...and the list should be somewhere in the guide (e.g. as a chapter_owners.md or in the README.md)

Fixed, see https://github.com/NLeSC/guide/blob/master/chapter_owners.md


Capability System: Split up capabilities into 2 representations _Internal_atom/External_atom

To reduce the complexity of a change (for easier PR reviews) the larger https://github.com/shader-slang/slang/issues/4347 task will be split into multiple smaller issues.
Problem:
Currently when printing capabilities we have a problem, we print _capability atoms.
Due to this printing, users attempt to solve capability problems using these _capability atoms. _ prefixed atoms are internal to Slang and generally only work for 1 target.
Using _ has 2 problems for User Slang code written:

_ atoms are normally designed to only work with 1 target
_ atoms change in definition and can break user-code.

Solution:

Enforce in the capability-generator during capability creation that all _myAtom capabilities must have a corresponding myAtom capability, myAtom should be fully defined on all targets with related features.
During capability printing don't print _ if a atom is prefixed with a _
[should be a new issue] Warn any-users using a _ prefixed capability since only non _ prefixed atoms should be used.

Note: this will likely require making all _internal atoms isolated to a target and all external  atoms fully defined on all targets.


flask-admin pages inaccessible in production

Hi,
I did a pretty simple implementation of flask-admin in my flask application, without creating any html pages, with something like this:

admin = admin.Admin(app, 'App Administration')

It works really well in development, and I can access the admin pages via mysite.com/admin/ .
Now, when I want to deploy my app with Apache and mod_wsgi, everything works fine at mysite.com/myapp/ , except flask-admin, which I expected to be available at mysite.com/myapp/admin (but I just get a 404).
Is there some extra configuration to be done with Apache ?
I didn't see anything in the documentation about going into production.
Here's my Apache configuration:

<VirtualHost *:443>
WSGIDaemonProcess myapp user=myapp group=myapp threads=5
WSGIScriptAlias /myapp /var/www/code/MyApp/wsgi/myapp.wsgi
WSGIScriptReloading On
WSGIPassAuthorization On
SSLEngine on
SSLCertificateFile /var/www/code/MyApp/ssl.crt
SSLCertificateKeyFile /var/www/code/MyApp/ssl.key
SSLVerifyClient None
SSLOptions +StdEnvVars
<Directory /var/www/code/MyApp/wsgi>
                WSGIProcessGroup myapp
                WSGIApplicationGroup %{GLOBAL}
                Order deny,allow
                Allow from all
</Directory>
</VirtualHost>

I checked the Apache error log but I don't get any error.
Thanks for any help.

Hi,
Actually, I am facing the same problem. I did all nginx configuration possble and for flask but still, when I try to edit a model, I receive a 500 error. Here my config, its a gist file.
Thank You
Burak

Same issue guys! its a pain. I am trying to run the app in uwsgi and none of the links are routed. Seems like flask-admin isn't good enough for production environment. uwsgi + flask + nginx is standard and if that isn't working well then perhaps better to switch to something else.
uwsgi --http <IP_ADDRESS>:3031 --wsgi-file app.py --callable app --stats-server <IP_ADDRESS>:3032 --processes 10

@harishkashyap Well, I'm sorry, but it certainly not Flask-Admin problem. It is your problem.
Please enable Flask debugger and see why 500 is showing up. I suspect it has something to do with your database permissions.

Thanks @mrjoes for your quick response. I appreciate it. However, it indeed is a flask-admin issue unless you can prove otherwise.
Yes, it is initialized properly. Here are steps to repeat the bug quickly:
go to flask-admin/examples/pymongo

python app.py works perfectly.
uwsgi --http :3031 --wsgi-file app.py --callable app --stats-server <IP_ADDRESS>:3032 --processes 10

only shows the home page and none of the other pages are rendered.
uwsgi as you might already know is the best way in production to host the flask app.

I'm using uwsgi with Flask and Flask-Admin in large project in production it works fine.
And only reason why this particular sample does not work with uwsgi:
if __name__ == '__main__':

This check fails if script is hosted by uwsgi and Flask-Admin is not initialized.

Thanks @mrjoes. Can you please point a quick example where the uwsgi works with?

It seems like layout-bootstrap3 example initializes Flask-Admin globally, so it would work with uwsgi.
Just to reiterate - it has nothing to do with uwsgi (or gunicorn, modwsgi, etc). These samples were supposed to be used by developers to learn how to do various stuff with Flask-Admin.

you are right and I am wrong! thanks for the clarification.


CafeBot not dispatching to BookTable correctly.

Fixes #937
Proposed Changes

Modify README.md to use --noDecorate in clone instructions.
Modify code so user doesn't have to modify LUIS reference in code (--noDecorate).
Fix BookTable dispatch so it runs BookTable correctly.
Fix default bot file in startup (recently changed to cafe-bot.bot)
Fix up storage issues associated with null SetAsync() which fail in ConcurrrentDirectionary.
Fix JObject paths to reference LUIS results correctly.
Remove SendAsync() with empty string.

Testing

Tested with latest msbot/az client with undecorated LUIS.

@vishwacsena I don't have enough context here to have an opinion. Everything here looks reasonable to me, but if you could look and review, I think that would be best.


install fails if git is present but not executable

Prerequisites

[X] I've checked the existing issues and I'm not duplicating a report.
[X] I've checked the zimfw Changelog and I'm not being affected by documented changes.
[X] I've checked the zimfw 📢 Announcements and I'm not being affected by announced changes.

Bug description
The installation fails if there is a git binary present, but the user does not have execution permission for it. Unlike the case where no git binary is present, where the installer switches to degit
Steps to reproduce

cd ${$(mktemp -d):A} && \
    ZDOTDIR=${PWD} HOME=${PWD} ZIM_HOME=${PWD}/.zim && \
    curl -fsSL https://raw.githubusercontent.com/zimfw/install/master/install.zsh | zsh && \
    exec zsh

Add more steps here ...

Current behavior
) Using Zsh version 5.9
) ZIM_HOME not set, using the default one.
) Zsh is your default shell.
) Downloaded the Zim script to /tmp/mktemp.1cmj9lRz/.zim/zimfw.zsh
) Prepended Zim template to /tmp/mktemp.1cmj9lRz/.zimrc
) Prepended Zim template to /tmp/mktemp.1cmj9lRz/.zshrc
x git: Error during git clone
_zimfw_tool_git:7: permission denied: git
Expected behavior
Installer switches to degit
zimfw info
zimfw version:        1.13.0 (built at 2024-02-17 02:05:06 UTC, previous commit is 9de3984)
LANG:
OSTYPE:               netbsd
TERM:                 xterm
TERM_PROGRAM:
TERM_PROGRAM_VERSION:
ZIM_HOME:             /tmp/mktemp.1cmj9lRz/.zim
ZSH_VERSION:          5.9

Additional context
% id
uid=1337(cluesch) gid=100(users) groups=100(users)
% ls -l /usr/pkg/bin/git
-rwx---r-x  1 root  users  4017280 Oct 18  2023 /usr/pkg/bin/git

Hi @cluesch. Thanks for reporting this!


[e2e]: generic schedule main attestation-name slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3879829333
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.attestation-name.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.attestation-name.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Jan 10 03:08:54 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3889294256
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.attestation-name.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.attestation-name.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Jan 11 03:13:26 UTC 2023
Tests are passing now. Closing this issue.


[1.16.5] [v1.0.6] Crash Report

Line 195
2022-04-09-1.log
Issue fixed by uninstalling.

Fixed in 1.1.1


es module is imported wrongly with webpack 4

What version of React-Table are you using?
 "react-table": "^6.8.6",

What bug are you experiencing, or what feature are you proposing?
I've used to run our app with webpack 3. With that, everything worked smoothly. Now I've switched to webpack 4 and when I am in development, the export has double default prop.
Meaning that on erendering any react-table I get this error:
warning.js:33 Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.

Check the render method of `Query`.
    in Query (created by AdminDashboard)
    in div (created by AdminDashboard)
    in AdminDashboard (created by Route)
    in Route (created by AdminRoutes)
    in Switch (created by AdminRoutes)
    in div (created by AdminRoutes)
    in Router (created by HashRouter)
    in HashRouter (created by AdminRoutes)
    in ApolloProvider (created by AdminRoutes)
    in IntlProvider (created by AdminRoutes)
    in AdminRoutes
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.

Check the render method of `Query`.
    at invariant (invariant.js:42)
    at getFiberTagFromObjectType (react-dom.development.js:9647)
    at createFiberFromElement (react-dom.development.js:9607)
    at createChild (react-dom.development.js:11978)
    at reconcileChildrenArray (react-dom.development.js:12229)
    at reconcileChildFibers (react-dom.development.js:12542)
    at reconcileChildrenAtExpirationTime (react-dom.development.js:12902)
    at finishClassComponent (react-dom.development.js:13104)
    at updateClassComponent (react-dom.development.js:13047)
    at beginWork (react-dom.development.js:13715)

When I change
 <ReactTable />

// to

 <ReactTable.default />

everything renders fine again.
Weird thing is that this only happens when I run webpack in mode development. When I switch to production it all works fine even without the .default.
This could be that my webpack config is somehow wrong, but seeing as it only happens with react-table I suspect there might be a bug in the module entry point.

I also experimented with removing   "module": "es/index.js",
from package.json locally and that helped too.

so I've figured it out- I had excluded node_modules in my webpack config. Apparently it's not a good practice anymore.
{
        test: /\.(js|ts|tsx)$/,
        use: {
          loader: 'babel-loader',
          options: babelConfig // we don't rely on babel-loader to be able to pickup .babelrc because that fails outside of front-end/src
        }
        exclude: /node_modules/
      },

Although I am not sure about closing this bug, because do we really want to force the consumer of this lib to use babel? Sure most people do, but wouldn't we want to make it as easy as possible for newcomers? IMHO we should when it's possible. I've tried on my namespaced package and it is indeed possible to produce an ES6 module export which does work with webpack even with node_modules excluded. If you want to try it out, install @capaj/react-table. So I'll leave this one open and I'l just rename it.

This one is a pretty nasty bug I ran into as well.
Even with excluding the node_modules it doesn't work for me. If I import ReactTable, I'll get an object instead of the default export...
After upgrading  react-table to the latest version, I now need to do this...
I was on React-Table 6.7.5 before the import worked ok.
/** <WHAT THE HECK IS GOING ON HERE??> **/
import * as ReactTableBla  from 'react-table';
const ReactTable = ReactTableBla.default.default;
/** </WHAT THE HECK IS GOING ON HERE??> **/

This feature/issue has been tagged as one that will likely be fixed or improved in the next major release of React-Table. This release is expected to be completed in the next 6 - 8 months. Please see #1143 for more detail. If you believe this feature can be easily fixed, we invite you to fork the project, attempt the fix, and use it until the latest version is available. If the fix is simple enough, we will also consider it as a PR to the current version.


Doesn't work for me, I don't know how to debug it

Hi!
I'm using Vim8 on Windows, the plugin installed fine (using Vundle) and :scriptnames shows the autoload script for it, I added this to my .vimrc:
let g:validator_python_checkers = ['flake8']
(flake8 is in the path and working).
But it doesnt do anything, calling:
:call validator#enable()
No error, no output, no checking.
:call validator#get_status_string()
No error, no string.
There is a validator.log file  in the plugin directory, but it is empty.

Found the problem will sent you a merge request soon.


typeError: loader._compilation.applyPluginsWaterfall is not a function

Module build failed (from ../node_modules/postcss-loader/index.js): TypeError: loader._compilation.applyPluginsWaterfall is not a function
constantly getting this error on build. cant perform build for project
postcss-loader v 3

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.
We don't have applyPluginsWaterfall function
Also v3 is not supported


[3.0] Move to a configuration file

I've noticed a couple of PRs adding more and more command-line options. Currently, there are 13 command-line options. I'm thinking it would be better to move to a config file to make things cleaner.

We can define a config file which the user can publish, say config/apidoc.php. By default, the package will use settings from the config file, but individual options can be overriden by specifying a command-line argument,
This would especially be helpful for teams which want to add a one-line composer script to generate docs.


Failed to execute command. Status code: 500

Hi, there!
I am continuously using your excellent  benchmark framework on Azure and since yesterday , it will give every code that agent generated this response:
[31mERROR python/182-MainProcess] Failed to execute command. Status code: 500
My last success was on 11.18 ,so I merged your latest code on main branch to mine. But still the same. Before 11.18 , it never happens.
Thank you for your time!

I have successfully solved this issue by Rebuilding the golden image of windows, using the latest bash code in this repo.
I guess it is due to the version conflict of QEMU . As my old one is 8.4.2 ,while the current is 9.1.0.
Maybe you can mention it in your readme.md.


Use sparse checkout for CI/live tests and release pipelines

We have sparse checkout templates that are used in various places to speed up pipeline job runtime, especially in repos like java and net where test recordings are substantial and make the full repo clone very large.
In java, we use sparse checkout across CI, live tests and release. Generally this results in about a 3-4 minute improvement per job and should be similar for net.
There are a few considerations with sparse checkout that need to be handled when adding support:

Excluding test recordings has the most impact.
Excluding other SDK and mgmt directories also has benefit, but takes more work (sometimes there are file dependencies across directories).
Certain types of files need to be included everywhere or in most places, such as markdown files, xml files and CODEOWNERS files.

Related: https://github.com/Azure/azure-sdk-for-net/pull/21789
@weshaggard @pakrym

Excluding other SDK and mgmt directories also has benefit, but takes more work (sometimes there are file dependencies across directories).

Can we only exclude recordings in other directories?

Can we only exclude recordings in other directories?

Yeah I think this would be a great starting point.


add option to expose hystrix metrics to statd collector

add WithStatsDCollector option to expose hystrix metrics to statsD collector.

Coverage remained the same at 100.0% when pulling 29e3c094cca97dc0409728b4d9ca01885ab98147 on darshanime:hystrix_metrics into 2c43ae59b43bda40ed8c00c402969b2758687475 on gojek:master.


specify shell

Currently opens in the last default shell. Having the ability to specify what kind of shell would be nice (powershell, wsl, git, etc).

see https://github.com/EthanSK/restore-terminals-vscode/issues/8

Hi, has there been any progress in this?

+1 for this feature.
Would like to specify a profile in splitTerminals. 🤩


GL: USER REG: User registration email is not sending to global users

Per testing with @sergii-tkachenko, no user reg email was trigged upon registration.
He is testing from Ukraine, so this affects GL users.

This template should actually look like the Niche.com template

@marahml Note the example registration is from CZ (Czech Republic) which is considered a "global user" and thus will get the US templates. A test with a Brazilian user produces the template you're looking for:


Improve opentelemetry-proto

Add Python and Go proto bindings

@bazel-io skip_check unstable_url

Hello @keith, modules you maintain (opentelemetry-proto) have been updated in this PR. Please review the changes.

ci issue

@keith can you trigger the CI again please?

@keith same here, one more time please.

done

@keith again please? Thx.


Add SDK install note

Codecov Report

Merging #11 (2b5bcc1) into master (6566ce2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   89.84%   89.84%
=======================================
  Files          15       15
  Lines        1142     1142
  Branches      179      179
=======================================
  Hits         1026     1026
  Misses        116      116

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Closing this in favour of instead adding note to Ocean.


FirebaseRecyclerAdapter

here is my database structure :
Friends >>  Uid1 >>   Uid4 , Uid3
>>   UId2 >>  Uid4
Users >> UId1 > name , age , online
>> Uid2 > name , age , online
I used FirebaseRecylceradaptper  with index query

the indexed query is  "Friends/Uid1 " to get all his friends
the reference is  "Users "

I get all friends of Uid1
but what if i want to get only online friends what should i do ?

Please post on Stack Overflow or fill out the template.

https://stackoverflow.com/questions/52154201/firebase-recycler-adapter-indexing-problem


hplip: don't reference gcc in binaries from /share and other locations

Motivation for this change
Make hplip packages not reference gcc-unwrapped,
Things done
Removed reference of all hplip variants to gcc-unwrapped. It was mostly easy with a stripDebugList attribute, but for the default hplip removeReferencesTo was needed.

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Thanks!


Shot and killed by sniper scav while inside BTR

General information:
Project issue is for:
SPT AKI (3.8.0) Bleeding Edge Test
Expected result:

I had hoped to safely travel inside the BTR without any issues.

Actual result:
2. Was shot and while inside the BTR taking a stroll then it led to a black screen with no way to close it besides task manager.

I had entered the BTR by the collapsed crane and paaid for Items to stash and a ride to the PineWood Hotel. Once the BTR had begun to move I had taken shots from either a PMC or Scav and was immediately killed while still inside the BTR

Attachments

server-2024-02-03.log (1272 KiB)
LogOutput.log (205 KiB)
2024.02.03_21-33-34_<IP_ADDRESS>.28476 traces.log (30843 KiB)

Originally written by MapoCinder

Should be fixed with: https://dev.sp-tarkov.com/SPT-AKI/Modules/commit/2ebabeffc9dd311d7cff98c91ae67a776ed2590f

Originally written by DrakiaXYZ


Select input on show

Is your feature request related to a problem? Please describe.
It is not possible to select or focus input.pcr-result on 'show'.
I went through the code, I noticed the selection is disabled on launch [I suppose in order to prevent mouse scrolls altering the value before someone clicks inside the input?]
Describe the solution you'd like
Add the option to select/focus the result input on 'show'
Describe alternatives you've considered
N/A
Additional context
My use case: I need to enable a user of my app to quickly add a new color by pasting the contents of the clipboard.
I noticed I am not able to attach an event listener in order to use 'Enter' key to save. Possibly related.

Here you go. The browser needs to to two repaints (Recalculating position and updating HTML Properties if I remember correctly).

That fixes it. Thanks!


Add faction icons as "small image"

There's a small chance that I could read the faction that the current user is rolling with. If possible, it would be sweet to show that faction as the "small image" in the Rich Presence. Below are the factions.

I've discovered the location of the current faction! It's engine.dll+7A7383. Here's the enum order:
0: Apex Predators
1: The 6-4
2: Vinson Dynamics
3: Marauder Corps
4: Angel City Elite
5: ARES Division
6: Marvin's Finest Hour

Nice.


Introduce openstack native load balancer to terraform example config

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?
/kind cleanup
Special notes for your reviewer:
Does this PR introduce a user-facing change?