Create a PR merging checklist

This issue keeps track of

creating a PR merging checklist
and enforcing the checklist somehow

There was a bug about signing scheme (TODO: add link here), there were missing changelog entries, and so on.

draft

Changelog entry is added for changes visible to users
Modified Solidity lines are covered by tests
Signatures sign the common format
Solidity functions' parameters are documented
New Solidity functions' gas consumption is measured

[to be continued]

way of enforcement

add the checklist in the contribution guide
somehow make GitHub show the contribution guide during the PR review (or PR creation).

I'll add the checklist in the PR template.


There is no way to know which contributor is doing/knowing what

A file would be useful to know who knows what and who is currently working on the repository since when.

It has been decided to use github teams for that purpose


machine state seems to be stuck at connecting without throwing error

I'm attempting to experiment with SecSync in a React application and have completed the initial setup for Yjs and TipTap using useYjsSync as per the guidelines outlined in here.
I used the provided test WebSocket server wss://secsync.fly.dev . However, I encountered an issue where my state wasn't persisting to the server. Upon inspecting the browser's network tab, I noticed that there was no WebSocket connection being established and the application didn't throw any errors, and the machine state remained stuck in the connecting state. This problem persisted even when I attempted to run the WebSocket server locally.
btw, i was able to get everything up and running together without issues from the docker setup, i am not sure what i am missing here. ws://localhost:4000 in the code below points to the backend service from the repo running locally.
here is my entire react code:
import React, { useEffect, useRef, useState } from 'react'
import sodium, { KeyPair } from 'libsodium-wrappers'
import * as Yjs from 'yjs'
import { useYjsSync } from 'secsync-react-yjs'
import { EditorContent, useEditor } from '@tiptap/react'
import StarterKit from '@tiptap/starter-kit'
import Collaboration from '@tiptap/extension-collaboration'
import uuid from 'react-uuid'

const SecSync = () => {
  const [authorKeyPair] = useState<KeyPair>(() => {
    return sodium.crypto_sign_keypair()
  })
  const yDocRef = useRef<Yjs.Doc>(new Yjs.Doc())
  const documentKey = sodium.crypto_secretbox_keygen()

  const [state, send] = useYjsSync({
    yDoc: yDocRef.current,
    documentId: uuid(),
    signatureKeyPair: authorKeyPair,
    websocketHost: 'ws://localhost:4000',
    websocketSessionKey: 'your-secret-session-key',
    onDocumentUpdated: async ({ knownSnapshotInfo }) => {
      console.log(knownSnapshotInfo, 'knownSnapshotInfo')
    },
    getNewSnapshotData: async ({ id }) => {
      return {
        data: Yjs.encodeStateAsUpdateV2(yDocRef.current),
        key: documentKey,
        publicData: {},
      }
    },
    getSnapshotKey: async (snapshot) => {
      return documentKey
    },
    shouldSendSnapshot: ({ snapshotUpdatesCount }) => {
      // create a new snapshot if the active snapshot has more than 100 updates
      return snapshotUpdatesCount > 100
    },
    isValidClient: async (signingPublicKey: string) => {
      return true
    },
    sodium,
    logging: 'debug',
  })
  const editor = useEditor({
    extensions: [
      StarterKit.configure({
        // the Collaboration extension comes with its own history handling
        history: false,
      }),
      Collaboration.configure({
        document: yDocRef.current,
        field: 'page',
      }),
    ],
  })
  return (

SECSYNC

      <EditorContent editor={editor} />

{state.matches('connected') ? 'CONNECTED' : 'DISCONNECTED'}

      {state.matches('connected') && 'Connected'}
      {state.matches('connecting') && 'Connecting …'}
      {state.matches('disconnected') && 'Disconnected'}
      {state.matches('failed') && 'Error in loading or sending data'}
      <button
        onClick={() => {
          send({ type: 'CONNECT' })
        }}
      >
        Connect
      </button>{' '}
      <button
        onClick={() => {
          send({ type: 'DISCONNECT' })
        }}
      >
        Disconnect
      </button>

  )
}

const Test = () => {
  const [libsodiumIsReady, setLibsodiumIsReady] = useState(false)

  useEffect(() => {
    sodium.ready.then(() => {
      setLibsodiumIsReady(true)
    })
  }, [])
  if (!libsodiumIsReady) return <>Loading</>
  return <SecSync />
}

export default Test

hey @Joshua-onwuzu, so sorry for the late reply. Somehow this didn't end up in my Github notifications.
I recently upgrade to xstate5 and did important fixes. Will do more this week and then publish a new version. Would you be interested to try again then?

@nikgraf I also was having this problem the other day. I'd definitely be willing to test a version 0.2.0 and a 0.2.1 to test a fix

@ncallaway just published a new version, would appreciate if you you can verify that it now works

@nikgraf Just tested with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>and it's working for me

closing the issue, let me know once it comes up again


Jumping behavior when waitForAnimate is set to false

I encountered a strange "jumping" behavior, when waitForAnimate is set to false and there are more than 1 element visible at the same time.
Link to fiddle: https://jsfiddle.net/xx3mc124/1/
Please click on the 3rd dot and very quickly (while animation is still ongoing) click on the 1st dot.

@rlayeh May also be related to https://github.com/akiran/react-slick/issues/1415.


source code learn

I'm learning the source code，But I found that there were few comments in the code !  Excuse me, is the project itself like this ?

tl;dr: Yes it is.
The source code of webpack is not straightforward. We try to put more and more comments on the newer part and to describe the used algorithms but the codebase is huge. However, what I like to do when learning a codebase that lacks of comments is commenting it! It helps to understand what's happening and to remember what you previously learned. If you start such process, I'll be happy to review a PR merging your comments.


Does AltAz always fail below horizon?

Question for @eteq / @adrn / @cdeil  – the AltAz docs indicate:

Near and below altitudes of 0, [AltAz] can even give meaningless answers, and in this case transforming to AltAz and back to another frame can give highly discrepent results. For much better numerical stability, leaving the pressure at 0 (the default), disabling the refraction correction (yielding “topocentric” horizontal coordinates).

In the constraints module, I'm adding a constraint for finding the targets visible at night, i.e. AtNight(max_solar_altitude=0*u.deg), and I will likely make subclasses of this constraint like BetweenAstronomicalTwilights(max_solar_altitude=-18*u.deg), etc. In order to check if the sun is below those altitudes, I will be trying to use negative altitudes in just the way that the AltAz docs discourage.
Are these altitudes predictably screwy in certain circumstances that we can avoid? For example, should we transform get_sun to AltAz with pressure=0 always, to avoid the wonky computations?

I have a similar use case of wanting AltAz below the horizon and actually
hadn't seen that note in the docs so I am glad you pointed it out.
We want to be able to point our mount directly down toward the ground (or
some target specific close to that) so I have been taking AltAz coordinates
that effectively just point down and transforming those into local HA/Dec.
The mount itself is capable of moving below the horizon but we were seeing,
well, wonky things.  I've just spending this week testing this and working
around.
But yes, I would like to be able to use an AltAz below the horizon if
possible as well, otherwise figure out a workaround.
Aloha,
On Wed, Aug 12, 2015 at 9:27 AM, Brett M. Morris<EMAIL_ADDRESS>wrote:

Question for @eteq https://github.com/eteq / @adrn
https://github.com/adrn / @cdeil https://github.com/cdeil – the AltAz
docs
https://astropy.readthedocs.org/en/stable/api/astropy.coordinates.AltAz.html?highlight=altaz
indicate:
Near and below altitudes of 0, [AltAz] can even give meaningless answers,
and in this case transforming to AltAz and back to another frame can give
highly discrepent results. For much better numerical stability, leaving the
pressure at 0 (the default), disabling the refraction correction (yielding
“topocentric” horizontal coordinates).
In the constraints module, I'm adding a constraint for finding the targets
visible at night, i.e. AtNight(max_solar_altitude=0u.deg), and I will
likely make subclasses of this constraint like
BetweenAstronomicalTwilights(max_solar_altitude=-18u.deg), etc. In order
to check if the sun is below those altitudes, I will be trying to use
negative altitudes in just the way that the AltAz docs discourage.
Are these altitudes predictably screwy in certain circumstances that we
can avoid? For example, should we transform get_sun to AltAz with
pressure=0 always, to avoid the wonky computations?
—
Reply to this email directly or view it on GitHub
https://github.com/astroplanners/astroplan/issues/60.

--
~Wilfred Tyler Gee

@bmorris3 – I have no idea what kind of refraction correction Astropy applies for targets below the horizon.
Maybe you could just try and see what happens?
And if it doesn't work out of the box, come back with a concrete example where the default Astropy behaviour is no good here and we can discuss how to work around it.
Adding more tests, even for pathological input parameter cases, is always nice, to check that Astropy / astroplan react in a reasonable way (i.e. compute something sensible, or warn or error).


Data upload fails with projects containing jdx and jdf files

This is due to space (prefix) in the file names that are being uploaded. Please ensure that the file names have no trailing empty spaces. Also, nmrXiv webapp will trim the name when processing them, so this should be resolved. Also, please attach a file that you have tried for us to test and confirm if everything is working fine as intended.

Uploading projects with trailing space and jdx and jdf files is working now


Consolidate versions.

Description
Adds a bunch of new versions, consolidates workflows.
Let's see how much we can break things.

Description
Adds a bunch of new versions, consolidates workflows. Let's see how much we can break things.

Hello, everyone.
I saw in the qmk source, the .deb package is still using the old version, while the latest package is already at version 1.1.2, and also the .rpm version is already at the latest version.
What about .deb package with version 0.3.5-1?
~# apt search qmk
Sorting... Done
Full Text Search... Done
qmk/stable 0.3.5-1 all
  Quantum Mechanical Keyboard (QMK) Firmware.\n\nQMK is an open source keyboard firmware that can build a firmware and custom\nlayout for hundreds of keyboards, or your own custom design.

Hi, @tzarc.
Let this trivial thing bellow, be one pull requests in your version-consolidation, please replace this:

Debian 10 (buster)
Add this to /etc/apt/sources.list:
# QMK
deb https://linux.qmk.fm/ buster main

Then follow the instructions under All Debian-like distributions.
Debian 11 (bullseye)
Add this to /etc/apt/sources.list:
# QMK
deb https://linux.qmk.fm/ bullseye main

Then follow the instructions under All Debian-like distributions.

With this:

Debian 11 (bullseye)
Add this to /etc/apt/sources.list.d/:
# QMK
echo "deb https://linux.qmk.fm/ bullseye main" | sudo tee /etc/apt/sources.list.d/qmk.list

Then follow the instructions under All Debian-like distributions.
Debian 12 (bookworm)
Add this to /etc/apt/sources.list.d/:
# QMK
echo "deb https://linux.qmk.fm/ bookworm main" | sudo tee /etc/apt/sources.list.d/qmk.list

Then follow the instructions under All Debian-like distributions.

And replace this:

All Debian-like distributions
Add the QMK GPG Key:
curl https://linux.qmk.fm/gpg_pubkey.txt | sudo apt-key add -

Update apt:
sudo apt update

Install QMK:
sudo apt install qmk

With this:

All Debian-like distributions
Add the QMK GPG Key:
wget -qO - https://linux.qmk.fm/gpg_pubkey.txt | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/qmk-gpg-pubkey.gpg > /dev/null

Update apt:
sudo apt update

Install QMK:
sudo apt install qmk

Because, in Debian, sudo apt-key add - is warning:
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).

I think it's like that on Ubuntu and Debian-like too. So putting the qmk source here /etc/apt/sources.list.d/ is preferable, like this and/or  this.
Thank you, I'm waiting for the qmk update for me to install on my Debian GNU/Linux.


Remove BLOB support

Feature description:
We will remove the official BLOB support from Crate. There are several resons that made us take this decision.
Some of the major issues we have with BLOB:

CrateDB doesnt have a built in backup solution for BLOB data
Apparently it is not used a lot (by our none customers & users)
It needs to be maintained and code has to be adopted
PostgreSQL clients have no interface to utilize BLOBs

The plan is to first deprecate the BLOB support most likely in version 4.5. Final removal will probably happen with the next major version update (5.0) somewhen later this year.
If you are looking for an alternative to BLOB storage e.g. https://min.io/ is a viable solution that can be used in combination with CrateDB.

Deprecation in 4.x
Removal in 5.0

Issues about blobs:

Blobs without sha hash
copy from/to local blob storage
Blob table backups
Object name for blob table
CREATE BLOB TABLE IF NOT EXISTS table_name

Ouch... Blobs tables are used in production on my side since a long time.. which works really fine.
And I implemented it in my CrateDBAdmin client to promote it on usage.
I’m crying...

PostgreSQL clients have no interface to utilize BLOBs

PostgreSQL clients don't have an interface to use BLOBs wit CrateDB. In general PostgreSQL and client support binary formats also e.g. with the lo_ module.

Thank you @MikeMaxFR for the inputs.
Part of the reason we opened up this issue early is so that users like you still have the opportunity to give feedback.

Each FS on a production environment must have a backup. For CrateDB node or anything else.

Not necessarily. We often see the pattern that customers distinguish between data (which of course requires a backup) and configuration. The configuration is managed by another system (Salt, Ansible or similar - also with backups).
Say you manage a CrateDB node via Ansible, then the only production data is within the tables of the cluster. In such a scenario you can use the snapshot functionality for the backups and don't need any additional FS backup mechanism. It's actually not really supported to use FS level snapshotting or rsync functionality to backup non-blob tables.
If you use the blob feature additionally, you'd have to have two solutions: Backups for blobs via FS, Backups for regular user tables via snapshots. That's not an ideal experience.

Not a lot but it should be more used with easier usage maybe ! ;)

True, but we have to set priorities. See last answer

PostgreSQL clients have no interface to utilize BLOBs <= i don't use PostgreSQL Clients, i'm using CrateDBAdmin.net Client, which can manage blobs with preview ;)

From the perspective of a user who favors a PostgreSQL client, having to add a second client to utilize the blob feature is not ideal. See also my next answer.

It needs to be maintained and code has to be adopted <= ..as every feature :)

True, but everything that has to be maintained has an ongoing opportunity cost. What aren't we taking care of while we're busy maintaining a feature. Sometimes a feature can even prevent us from building another, maybe more useful feature, or at least make it more difficult to build.
Blobs were one of the first features and over time the market for CrateDB became more clear and the product vision also evolved. We now have a couple of "core pillars" or product principles that are used as sanity check when we add new features. Two of which are "SQL Standard" and "PostgreSQL compatibility". Blob support doesn't fit into that in it's current form. It's a bit like having two separate products within the same distribution.
There would be another option beside removing it: Integrate it better. But that requires work, and we saw little demand, so it's difficult for us to justify putting work into this.
There are also some issues with the implementation that limit the scalability (Some operations block on the transport thread).
That said. CrateDB is open source, and open for contributions. There are several options:

Somebody could step up and help maintain it
A customer could put $$ behind it to help fund ongoing maintenance
We could consider alternative integrations or features that would cover your use case.

For example we're currently considering adding a binary data type that is suited for small payloads and can be used in columns of regular tables. Could you elaborate a bit more on your use case? What data are you storing?

Hello,
I'm not convinced of your argument about adapting (or rather constraining) to PostgreSQL compatibility at the expense of a feature that seemed promising if it had been maybe better promoted among users (and that was already very useful for my company in its current version).
In my case I use blobs for few millions of "small" files like PDFs indeed (order forms, delivery notes, Image Logos, etc..) and also for mail and private messages attachments (we can have bigger files on this (15/20MB)), but a potential size limit in the management of a binary type could be more limiting than blobs. But it would be better than nothing (what would be the maximum size of a binary entry ?).
Too bad that we can only do "better than nothing".
But keep up the good work for SQL Standard , it already works very well :)... For PostgreSQL, i still consider that is another product and it blurs the identity of the CrateDB product (i see the interest of an easy compatibility to attract PostGreSQL users, but SQL Standard seems to me to be enough, especially if you lose time by forsaking other features especially for those who have no special interest to use PostGreSQL compatibility).

After some more (internal) discussion, we've decided to NOT remove the BLOB support by now.
We agree about the use-case of storing large binary objects and planning to come up with a SQL based implementation (e.g. BLOB data type) in future which should then also support backup & restore of these binary objects (no ETA at all).
Until we or a contributor can provide such an alternative solution for storing BLOBs, we do not plan to change or remove the current implementation.
But please be aware that until such a solution is implemented we probably won't add the missing backup & restore support to the current implementation.


settings: Use the same height for selected and unselected languages.

The height of the row containing the selected language, 'Catalan', is greater than the heights of the rows containing all other unselected languages.

This isn't really an issue of usability, I just think it would feel a bit more polished if the heights of the rows remained consistent.
@gnprice @borisyankov Thoughts?
@zulipbot add "area: layout"

Yeah, agreed on all counts. Thanks for raising this!
This isn't a particularly great UI for this task, but it looks like its design is trying to imitate an iOS style found in some settings, like the example with checkmarks in the right-hand screenshot at the top of this iOS HIG page.
It'd be good to fix the layout here so that it works right, with all the items staying at the same height. I think the items could all use a bit more padding; and the icon can probably be smaller, too (like it is in that screenshot, and in the system settings on my iPhone.)
For the exact padding, I'd refer to the Material guidelines for a list. It's possible the checkmark size that looks good here (in mimicing iOS conventions) will be smaller than Material Design prescribes, though -- after all the Material prescription for this UI is somewhat different anyway (namely radio buttons.)
At some point it may be worthwhile to come back and replace this with a better language-selection UI, but that'll be more work. (Alternatively, FWIW: if this were for a task where this basically is the right UI model, then the ideal thing would be to follow platform conventions and use on Android something that won't be so alien to Android users. But for language selection there are better UIs anyway.) A quick layout fix here should be easy and will be well worth it.

@zulipbot claim


security holding package

Hi,
it seems you have accidentally added fs but this is not a package on npmjs, fs is an internal NodeJS module.
https://github.com/OfficeDev/Office-Addin-Scripts/search?q=0.1-security&unscoped_q=0.1-security
See https://nodejs.org/api/fs.html
You might want to remove it using npm uninstall fs.

Thanks for letting us know!


Add description to Dockerhub lemonsaurus/blackbox

It's empty now. May be at least link to README on GitHub
https://hub.docker.com/r/lemonsaurus/blackbox

https://github.com/peter-evans/dockerhub-description looked like a promising way to automate this, but sadly it has no support for 2FA and Personal Access Tokens, it requires your actual DockerHub password to an account with no 2FA.
That's never going to happen, so I guess I'll just copy paste in the readme for now. 🤷🏼

I've added one to the DockerHub readme now, and added a little disclaimer that it might be out of date.


IBleManager scanning while the phone is locked

IF YOU DON'T ANSWER THIS TEMPLATE - THE BOT WILL AUTOMATICALLY CLOSE YOUR ISSUE!  PLEASE DON'T ASK FOR WORKAROUNDS OR TIMELINES - THIS IS FREE SOURCE CODE
Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[ ] iOS
[ x] Android
[ ] UWP

PLATFORMS THAT YOU CANNOT FILE ISSUES ON RIGHT NOW: Tizen, watchOS, tvOS, macOS
Feature Library
beta components are not fully done - issues MUST include full reproducible sample and stacktrace or they will be closed without explanation!!!

[ ] Core
[ ] Locations
[ ] HTTP Transfers
[ ] Notifications
[ ] Push
[ ] Push - Azure Notification Hub
[ ] Push - Firebase (beta)
[ ] Sensors
[ ] AppCenter Logging Integration
[ ] Location Sync (beta)
[ ] Photo Sync (alpha)
[x] BluetoothLE (beta)
[ ] Beacons (beta)
[ ] SQLite Integration

Version of Library
<IP_ADDRESS>5
Version of OS(s) listed above with issue
Android 9.0
Steps to Reproduce

call  IBleManager.Scan
lock the phone (screen off/ sleep)
new BLE peripheral is not discovered by IBleManager.

Expected Behavior
Actual Behavior
Question: Should the IBleManager continue scanning when the phone is locked?
or the BLE is still under work?
Thanks for the great library.
I am trying to move from BluetoothLE.Plugin.

Please read the Android documentation.  Support is given to project sponsors only and the betas (as noted in the issue template) require reproducible samples.  However, this is not a big which the Android docs will tell you


Reading GeoTIFFs with rioxarray/rasterio

A basic reader for GeoTIFF files using rioxarray under the hood. To address #120.

Implements GeoTIFFReader, GeoTIFFFieldList, GeoTIFFField, GeoTIFFMetadata and GeoTIFFGeography.
The unit test comes with a small multi-band test file.
New geotiff optional dependencies in pyproject.toml.

There is not much in terms of metadata extraction other than the projection information yet, but many GeoTIFFs don't provide much metadata in the first place, unfortunately.
I have configured the reader to apply masking and scaling to the values by default, even though rioxarray doesn't.
Small things adjusted along the way:

Turned shape of the core.geography.Geography abstract class into a method (was a property), since that is how it seems to be used in practice.
Added a TransverseMercator projection, which seems to be common for GeoTIFF data.
Changed utils.projections.cf.CF_PARAMS_TO_GLOBE_KWARGS["inverse_flattening"] to "inverse_flattening" (was "flattening").

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@chpolste , thank you very much for this development.  I tested it and works nicely.  I made a few comments, once these and the branch conflict are sorted out the PR can be merged.
As for the documentation, what notebook example do you think should be added? What should it be highlight?

Codecov Report
Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.08%. Comparing base (acda540) to head (2598847).

Files with missing lines
Patch %
Lines

tests/readers/test_geotiff_reader.py
85.71%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #503      +/-   ##
===========================================
- Coverage    91.09%   91.08%   -0.02%
===========================================
  Files          147      148       +1
  Lines        10744    10765      +21
  Branches       510      511       +1
===========================================
+ Hits          9787     9805      +18
- Misses         794      796       +2
- Partials       163      164       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[WIP] [CI] actually check special action docs code samples

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[ ] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context

Description

          1 Warning

:warning:
Pull Request is Work in Progress

  Generated by :no_entry_sign: Danger

@janpio Looks like we have conflicting files here. Also, if you have a PR that has changes from another PR inside of it, you can either combine them into 1 PR if small enough or merge the other PR into the other PR. Either of these would be 💯 with me 😊

Conflict solved.
I didn't want to combine any of these PRs as they really do different things and I wanted to make sure we get a commit per change after merging - in a year we will be happy about that ;)


Paste shows only when content on clipboard (reopened)

Description
Reopened from https://github.com/flutter/flutter/pull/54902 due to weird version errors in the tests.
On native, the paste button in the text selection menu only shows when there is something to paste on the clipboard.  This PR adds the same functionality for Flutter.
There was a long standing TODO in the code about making the canPaste method consider what's on the clipboard.  I did not take this approach, because checking the clipboard is asynchronous and canPaste is used synchronously.
Instead, the text selection menus check the clipboard asynchronously when they're rendered and rerender if needed.  The clipboard is also checked when the app is resumed.  This results in the selection menu always being up to date, even if it's sometimes 1 frame late.  The only way I can find to trick it is by clearing the clipboard while the selection menu is still visible using the command line.  This shouldn't be possible in a production app, only while running an emulator.
Related Issues
https://github.com/flutter/flutter/issues/4355
Tests

Check the appearance of the Paste button when there is and is not content on the clipboard.

Looks like I saved the original PR https://github.com/flutter/flutter/pull/54902, so I'll close this.


Use updated window size in bevymark example

Objective
Have the bird spawning/collision systems in bevymark use the proper window size, instead of the size set in WindowDescriptor which isn't updated when the window is resized.
Solution
Use the Windows resource to grab the width/height from the primary window. This is consistent with the other examples.

My one concern with this is that bevymark is intended to be a benchmark, to test bevy's sprite performance across platforms - I'm not sure how useful having the window be resizable is for that purpose.

If we don't want the window to be resizable, it should set resizable to false when creating it rather than not handling the size correctly. Currently the window is resizable but birds will still bounce on the size of the window at start

Yup I agree that this is a positive change because it encourages people to follow best practices (accessing WindowDescriptor data at runtime is rarely a good idea). Possibly worth disabling window resizing, but im cool with merging this as is.

bors r+


Add reference time

When converting from time in seconds to a date-time string, the program needs to know what time the seconds are referenced to in order to complete the operation accurately. As an example, it is common for seconds to be referenced to UNIX time, which is Jan 1 1970. However, certain GPS processing software may have different reference times. For instance, the records produced by the JPL software GipsyX references seconds to 12:00 on Jan 1 2000.
Thus, we should consider implementing a flag so the user can set a time reference for the conversion so that input data can be read correctly

Thanks for raising this issue! This is a really great description. 😄

I want to leave some more thoughts on this issue.
This will likely vary by surface platform, but the data feeds most likely to have their own independent time stamps are the two-way travel times, the roll/pitch/heading values, and the GPS data. Of these, the time reference of the GPS data will depend on the software used to process the data, but I would expect the others to be relatively static.
What I'm considering is whether it is worth adding up to three variables for input, whether it is fine to stick to one, whether it may be better to rely on the user to make this transformation themselves and provide the relevant references in the documentation, or whether it may be simplest to write a small and flexible utility for the end user to use.


Add support to only perform an s2k key derivation once while encrypting/decrypting multiple private keys

In previous versions, it is not possible to encrypt multiple private keys with the
same encryption key derived from a passphrase.
A fresh encryption key is derived for each encryption and
similar s2k key derivations are repeated for decryption.
This commit adds support for encrypting/decrypting multiple private keys
with a single encryption key derived with a single s2k key-derivation:

Adds two high-level methods on Entity called LockAllKeys and UnlockAllKeys

Adds two functions in packet called PrivateKeysEncrypt and  PrivateKeysDecrypt
that allow encrypting/decrypting multiple PrivateKeys with the same passphrase.

Refactoring in PrivateKey encryption and decryption

Adds Cache in the s2k package to avoid recomputing similar
key derivations in packet.PrivateKeysDecrypt

Changes the type of the s2k.Params salt field to byte array
and introduces a getter for retrieving the salt.

Thanks, I applied the suggestions.


Please add option to Close with hotkey

Please add option to Close with hotkey

To Close the Editor? Use... Alt-F4.

Not sure if you are trolling me or not... I should have been more specific, not closing the application but closing an open file.

Ctrl-F4... of course.


New rule: no space between identifier name and colon when declaring types

No space after a variable name and before colon when writing type and return declaration.
Right:
var quantity: number = 101;

Wrong:
var quantity : number = 101;

Right:
public getSomething(source: string): string {

Wrong:
public getSomething(source : string) : string {

Note: ternary operator explicitly asks for a space before and after semicolon, tsc will complain if you don't put it.

this was implemented in tslint's whitespace rule


Can not load the file './dmp/data/40x40-smnist.mat'

Hi, I am doing this project as my final master project, but when I run the command as your guide, the code can not run due to not found a file '40x40-smnist.mat'. Could you help me solve this problem?

Hi @linksdl,
Sorry about that we got rid of the dependency in smnist_loader.py: 6c8afe3. However, the array file is too large to share on the repo, so I have provided a downloadable link here: https://drive.google.com/file/d/1oqJBbczrURrGmOU37J3TSCAkwSbqeXzG/view?usp=sharing. Note that you must add the path to this data file in the smnist loader.

@shikharbahl  Thanks for your help very much. I was preparing for my final exam recentely. I will try to run this project.


crash before launching

So i added a few mods to my already working custom modpack and clicked play. nothing happened for about a minute, so i looked at the launcher log. this it what it said. I couldn't get anything from that at all, except it said pg85 and OTG. so, I uninstalled otg and all other mads that i had added since it last worked and got the exact same error. It still mentions OTG, even though i removed OTG. Can someone explain what is happening here?
EDIT: Ok so i figured out why it was still giving me the error after i removed it. It made a file in the 1.12 folder in my mods folder called OTGCore.jar that i had to delete. however, the pre-launch crashes are still happening.

Hey TheGoldenProof, OTGCore.jar is required for OTG to work. Whenever you update OTG (get a new OTG jar) you need to delete it though so that OTG can create a new OTGCore.jar. If you delete OTGCore.jar, then run MC with only the OTG jar, do you see a new OTGCore.jar being created?


[2.9.0] 1373 support authentication with service account tokens

Fixes #1373
Reminders

See the README for more details on how to work with the Rancher docs.

Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.

Description
From issue:
Ranchers auth proxy can now support authentication of requests that specify a Service Account token in the Authorization Bearer header.
More info/context:
JWT Authentication is also known as Service Account Token Authentication.
This feature, when enabled, lets a user set up a downstream cluster to support authentication, through Rancher, of tokens that are created for a service account that exists on a downstream cluster (those tokens are in the form of a JWT).
Prior to this feature, Rancher would reject such requests because Rancher would only support Rancher-issued tokens (which are NOT JTWs). Some users worked-around this limitation by issuing those requests directly to the downstream cluster, rather than relying on Rancher's auth/security. With this feature enabled, users no longer have to work-around Rancher.
A common use case for this is to enable integration of secret vault solutions (like Hashicorp Vault). You can see the original rancher/rancher issue for more details https://github.com/rancher/rancher/issues/22417.
Comments / Questions

Referencing https://github.com/rancher/rancher-docs/issues/1373#issuecomment-2243357194, @crobby may you provide the steps to manually create a ClusterProxyConfig object in the target clusters namespace on the local cluster to enable/disable the feature?

@crobby May you provide a review when you get the chance? Thanks!


Create Export instances for Output.Export in cfn2py

Please close this PR and use #1895 from doctorondemand instead.

Closing per request.


Persistent bindings with objects added to repeater array

When you add an object to a v-repeat array that has bindings attached to it, the bindings persist. Is this intentional?
Very crude and simplified version of my problem, after adding an item delete some of the text from the input box:
http://jsfiddle.net/FyrY6/2/
I noticed when the object was added to the array it inherited the new bindings and methods from the v-repeat directive (which is awesome), but did not remove its old bindings. Is there a way to destroy the old bindings of an object after it has been added to a repeater array?
edit: updated fiddle link

Darn. I was really hoping to find a built in way to push a copy of the whole object. In my case
this.items.push(this.newItem)

breaks down to
this.items.push({
    name:        this.newItem.name,
    start:       this.newItem.start,
    end:         this.newItem.end,
    description: this.newItem.description,
    tag:         this.newItem.tag,
    notes:       this.newItem.notes
})

That is a lot of pointless repetition. Instead I am using jQuery's $.extend since I already have it:
this.items.push($.extend({}, this.newItem)); //use $.extend(true, {}, this.newItem) for deep

There is an internal equivalent: Vue.util.extend, although it's not documented.

Awesome. This is what I was looking for. I created a StackOverflow Q and A to hopefully help out others that run into this. http://stackoverflow.com/questions/30578254 It includes fiddles that show a before and after: http://jsfiddle.net/huLygoag , http://jsfiddle.net/huLygoag/1 , http://jsfiddle.net/huLygoag/2

Hi,
I have a situation where I have the following object
data : {
			navigation : {
				step : {
					prev : 0,
					current : 1,
					next : 2
				},

				phase : {
					prev : 0,
					current : 1,
					next : 2
				},

				next_type : 'phase',

				can : {
					prev : false,
					next : false
				}
			},

			history : []
		},

but using javascript Vue.util.extend( {}, this.navigation )   maintains the data binding. Thus if I say this.navigation.phase.current = 5 it will also update the object pushed in this.history which I am trying to avoid.
Can anyone advise if am doing something wrong or if it is an actual bug to the util.export?
I played around with the fiddle above and forked into a new version where I could replicate my issue http://jsfiddle.net/5kxrwuag/. Right now my only option seems to be this.history.push( { navigation : { phase : Vue.util.extend ( this.navigation.phase ), ... for each properties

@jjaulimsing if your data is nested, you need to make a deep copy. One option to do this is JSON.parse(JSON.stringify(...)). To make this work your data has to be plain (no circular or shared references, no prototypes, no functions).

@jjaulimsing Vue.util.extend only does a shallow clone - it only copies the top level properties. Vue.js data objects are reactive by reference, so if you want a non-reactive copy, use a deep clone. The easy way is JSON.parse(JSON.stringify(object)), or use something like https://lodash.com/docs#cloneDeep

It was real troublesome to find a solution for this. Is it possible to add notes about this in the documentation, my suggestion is in the section just below example with todo list in List Rendering


Gitlist version not updated in footer

Downloaded and installed latest 5.0 stable from http://gitlist.org/
Vesion shown in footer is still 0.4.0 (wish is vulnerable).
CF :  https://github.com/klaussilveira/gitlist/blame/master/themes/default/twig/footer.twig#L2

This has been fixed in master.

As there's already a v6.0.0 release I don't think there will be a new tarball for v5.0.0. However, this issue has been fixed in e70cb0f as described in #654.


The post iteration example sample request content is malformed

The json string "{"id":"a589a806-bf11-4d4f-a031-c19813331553"}" makes no sense. I would expect fields describing start/end date, path etc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40322a53-16c3-606c-4ae2-f3deeda4ba68
Version Independent ID: 34ed6e00-7eb5-6aa4-7ce3-977412760578
Content: Iterations (Azure DevOps Work)
Content Source: docs-ref-autogen/5.1/work/Iterations.yml
Product: devops
Technology: devops-ref
GitHub Login: @wnjenkin
Microsoft Alias: whjenkin

what is the relaitonship  between IterationID and uuid?
how can i get uuid by  IterationID?

I'm getting "The guid specified for parameter rootIterationId must not be Guid.Empty" when POSTing using an iteration identifier obtained from the project iterations list. The documentation doesn't even indicate this parameter exists.

Hi Guys,
After wasting a lot of time trying to solve this issue here is the fix.
Hope Microsoft updates the documentation.
To Post Team Iteration pass the JSON as :
Correct -->  { "id": "5ca00e3b-4a1c-49ef-aa02-78983168eb65" }
Incorrect -- > "{"id":"a589a806-bf11-4d4f-a031-c19813331553"}"
The above id is the classification node identifier you can fetch from here :
https://docs.microsoft.com/en-us/rest/api/azure/devops/wit/classification nodes/get?view=azure-devops-server-rest-5.0
Hope this helps.

Correction, edit to the above post :
Incorrect -- > "{"id":"a589a806-bf11-4d4f-a031-c19813331553"}"
Correct -->  { "id": "a589a806-bf11-4d4f-a031-c19813331553" }

Just noticed comments are being formatted by editor. Take away is pass the JSON in the above format.


Controlling Flash with nipple on touchscreen, what about buttons?

Hello, I'm currently toying the nipple in order to control Flash content in the Ruffle emulator on touchscreen devices:
https://www.txori.com/stuff/ruffle/nipplejs.php

I was wondering if nipples could be use as buttons too, or if not, if you had plan to add buttons?
Thanks

So I programmed my own buttons, thanks to this useful hint.
Now I'm trying to use a static nipple instead. It's there, working, but not throwing any events...
I just got from this:
	var nippleManager = nipplejs.create({
	    zone: document.getElementById('box'),
	    color: 'red'
	});

to that:
	var nippleManager = nipplejs.create({
	    zone: document.getElementById('box'),
	    color: 'red',
	    mode: 'static',
	    position: {left: '100px', bottom: '100px'}
	});

What am I missing?

I made a very simple test, and everything is working but the static nipple:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
		"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<title>Nipple debug</title>
<meta http-equiv="content-type" content="text/html;charset=UTF-8" />

I really don't know what's going on with it...
It is available here:
https://www.txori.com/stuff/ruffle/simplenipple.php


Google Colab install via pip fails

INPUT
!pip install --upgrade pip
!pip install git+git://github.com/mkrphys/ipython-tikzmagic.git
%load_ext tikzmagic
OUTPUT
fails with the following error:
WARNING: Discarding git+git://github.com/mkrphys/ipython-tikzmagic.git. Command errored out with exit status 128: git clone -q git://github.com/mkrphys/ipython-tikzmagic.git /tmp/pip-req-build-i8kbszvw Check the logs for full command output.
ERROR: Command errored out with exit status 128: git clone -q git://github.com/mkrphys/ipython-tikzmagic.git /tmp/pip-req-build-i8kbszvw Check the logs for full command output.
ModuleNotFoundError                       Traceback (most recent call last)
 in
2 # https://github.com/mkrphys/ipython-tikzmagic
3 get_ipython().system('pip install git+git://github.com/mkrphys/ipython-tikzmagic.git')
----> 4 get_ipython().run_line_magic('load_ext', 'tikzmagic')
Solved by downloading the repo first and installing it manually:
SOLUTION:
!git clone https://github.com/mkrphys/ipython-tikzmagic.git
!pip install -e /content/ipython-tikzmagic/

Try using the following command instead:
pip install git+https://github.com/mkrphys/ipython-tikzmagic.git

This error is probably related to GitHub deprecating the git:// protocol

@herocc I propose, you update the docs for that. Had the same issue.

As of 2023-10-23, the following commands work to run ipython-tikzmagic on Google Colab:
!apt update
!apt install imagemagick
!apt install pdf2svg
!apt install texlive texlive-latex-extra
!pip install git+https://github.com/mkrphys/ipython-tikzmagic.git
!sed --in-place --quiet 's/policy domain="coder" rights="none" pattern="PDF"/policy domain="coder" rights="read|write" pattern="PDF"/g' /etc/ImageMagick-6/policy.xml
%load_ext tikzmagic

where the apt install commands are from here and the the sed command is necessary to fix the ImageMagick permissions issue identified here.


Item Prices plugin doesn't show High Alchemy profit unless Show Grand Exchange Prices is enabled

Please check if your issue is not a duplicate by searching existing issues

I was unable to find a duplicate, but this seems very similar to issue #9011

Describe the bug
When the "Show High Alchemy Profit" radio is selected and the "Show Grand Exchange Prices" radio is unselected, the High Alchemy profits are not displayed on the item.
To Reproduce
Steps to reproduce the behavior:

Enable the Item Prices tab
Disable the "Show Grand Exchange Prices" radio
Enable the "Show High Alchemy Profit" radio
Hover over an item

Expected behavior
The High Alchemy profit should be displayed on the item.
Screenshots

Environment (please complete the following information):

OS: Windows
RuneLite version: 1.8.3
Launcher version: 2.1.7

Additional context
N/A

Hi. This appears to still be an issue as I am experiencing this today.


set the charset to utf8mb4 instead of utf8

Fixes "Error: ER_COLLATION_CHARSET_MISMATCH: COLLATION 'utf8mb4_unicode_ci' is not valid for CHARACTER SET 'utf8'"
Mac OS X
MySQL 5.7.10 (homebrew)

thanks for opening this. the changes landed here: https://github.com/jsperf/jsperf.com/commit/9d84caedebccada956454f4db0461b83a345df5c. we need to fix travis so that PRs from forks pass. right now secure environment variables are not being exported which break the tests :cry:


Need to remove .eslintignore file

There are still 54 problems (mostly eqeqeq) that should be fixed before we can remove .eslintignore file.

Files to be fixed:
ConfigEditor.tsx (3 errors)
VariableQueryEditor.tsx (5 errors)
QueryEditor.tsx (22 errors)
DataSource.ts (24 errors)


Microsoft VBScript runtime error: Object required: 'LogStream'

PS C:\Offscrub> C:\Offscrub\Remove-PreviousOfficeInstalls.ps1
Detecting Office installs...
Removing all Office products...
Microsoft Customer Support Services - Office 2013 MSI Removal Utility
Version: 	2.10
64 bit OS: 	True
Removal start: 	9:36:31 AM
OS Details: Microsoft Windows 7 Professional , SP 1, Version: 6.1.7601, Codepage: 1252, Country Code: 1, Language: 1033
cmd.exe : C:\Offscrub\OffScrub_O15msi.vbs(3912, 5) Microsoft VBScript runtime error: Object required: 'LogStream'
At line:1 char:4

cmd <<<<  /c cscript //Nologo "C:\Offscrub\OffScrub_O15msi.vbs" CLIENTALL  /QUIET /KEEPUSERSETTINGS /REMOVELYNC

CategoryInfo          : NotSpecified: (C:\Offscrub\Off...ed: 'LogStream':String) [], RemoteException
FullyQualifiedErrorId : NativeCommandError

I am able to run the VBS script manually, but when trying to run the PS1 out of Powershell I get the above results.  Looks like it's asking for an additional parameter in the command line.

Looks like running the PS1 in PowershellISE as admin did not throw that same error, but could not find the Offscrub script.  It failed to set $scriptpath to the local directory.  I was able to hardcode C:\Offscrub and it ran successfully.
I'm going to continue testing it.

It defaults to C:\Windows\System32 when invoking over a UNC path...


[Feature][JsonSplit-api] modify API to Restful-01

#5498
This table records the modifications completed.

name
API
UI

name
API
UI

name
API
UI

ProcessDefinition
1
1

AlertPluginInstance
2
2

Executor

ProcessInstances
1
1

DataSource
2
2

WorkFlowLineage

TaskDefinition
1
1

Monitor

Login

TaskInstances
1
1

Queue

WorkerGroup

Project
1
1

Resource

DataAnalysis

AccessToken
2
2

Scheduler

UiPlugin

AlertGroup
2
2

Tenant

Logger

a document about modification

These also need to import other packages, such as PutMapping and DeleteMapping. I didn't change this part. The IDEA editor automatically changes to *.

@ruanwenjun

These also need to import other packages, such as PutMapping and DeleteMapping. I didn't change this part. The IDEA editor automatically changes to *.

Codecov Report

:exclamation: No coverage uploaded for pull request base (json_split_two@ee4e64a). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             json_split_two    #6016   +/-   ##
=================================================
  Coverage                  ?   45.33%
  Complexity                ?     3631
=================================================
  Files                     ?      605
  Lines                     ?    24646
  Branches                  ?     2837
=================================================
  Hits                      ?    11174
  Misses                    ?    12379
  Partials                  ?     1093

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4e64a...032f243. Read the comment docs.

pls fix confilct first


Fix for Identity 851

Changed variable names and strings to be consistent with the standard. Did not alter names not exposed through user-mgt.xml.

Please add Carbon JIRA.

This need to be reviewed. Please add tests.

this remote branch was deleted by a mistake. The same pr is now at #645


JNI coverage doesn't include JNIgen tests

The coverage seems to be low since it's not adding the tests in package:jnigen that also cover key functionalities of package:jni.
Originally posted by @HosseinYousefi in https://github.com/dart-lang/native/issues/998#issuecomment-1997446372

dart pub global run coverage:test_with_coverage is run for both package:jni and package:jnigen separately. I don't know if package:coverage has any support for running for mono_repos.
packages package:native_* have the same issue. (There I end up writing tests in the packages themselves to increase coverage.) So they would benefit from the same improvement.

The test_with_coverage script only handles very simple use cases. Internally it runs the test, then calls collect_coverage and format_coverage. You might need to manually run those steps like we do in ffigen.
All of package:objective_c's functionality is covered by ffigen tests, so I just had to update ffigen's coverage script to allow objective_c through the filter: https://github.com/dart-lang/native/pull/1061/files#diff-11be0910e38d60287f7b12288096c1421f3e8f3912daccf0de351c46abb6f48a
You'll probably need something similar for jni.

Thanks for diving into this @liamappelbe!


How to set command (script) in relative path like your example.

I have tried to do it, but it show me with error cannot found the file (script) specific!
I need to specified with full path from C:\... I think it's not good practice due to the work we do it together with team, and use Git as source control, when change to other developer environment, it is different from the SPECIFIC path.
You don't provide a tool to select file or output just spamming the unknown reason of which path you mean is 'not found the file specific'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbca10bd-8636-496e-91a3-e77fb1dfcd84
Version Independent ID: fb4fceda-3a4f-f8fd-3965-1a858e240d31
Content: Web application templates for Python - Visual Studio
Content Source: docs/python/python-web-application-project-templates.md
Product: visual-studio-windows
Technology: vs-python
GitHub Login: @JoshuaPartlow
Microsoft Alias: joshuapa

Thank you for your input. We agree and have added this work to our planning board. We will go ahead and close this issue, but continue to track the work internally.  If you think this issue should remain open, please reopen it with a comment explaining why. Tag me for visibility.


tf.distribute.MultiWorkerMirroredStrategy does not replicate tf.Variable among workers

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
2.9
Custom Code
Yes
OS Platform and Distribution
tensorflow/tensorflow:2.11.0
Mobile device
No response
Python version
3.8.10
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
A variable is created with `synchronization=tf.VariableSynchronization.ON_WRITE`. But if `.assign(1)` is called the value is not distributed among workers.

Expected behavior: the variable is set to `1` on all workers.

There might be a lack of understanding on my side on how the distribution is working.

Standalone code to reproduce the issue
`src/minimal-example.py`:

#!/usr/bin/env python3
# COPYRIGHT HSLU 2023 PFAEFFLI, ALL RIGHTS RESERVED
import json
import logging
import os
import time
from pathlib import Path

import tensorflow as tf
os.environ[
    "CUDA_VISIBLE_DEVICES"
] = "-1"  # Prevent that any GPUs are allocated unintendendly

def _is_chief(task_type, task_id, cluster_spec):
    return (
        task_type is None
        or task_type == "chief"
        or (
            task_type == "worker"
            and task_id == 0
            and "chief" not in cluster_spec.as_dict()
        )
    )

def train():
    if "WORKER" not in os.environ:
        logging.warning("Missing env 'WORKER'")
        wname = "UNK"
    wname = os.environ["WORKER"]

    # Logger
    FORMAT = "%(asctime)s - " + wname + " %(message)s"
    logging.basicConfig(format=FORMAT)
    logger = logging.getLogger(wname)
    logger.setLevel(logging.INFO)
    logger.info(f"{tf.version.GIT_VERSION}, {tf.version.VERSION}")

    # Load arguments
    tf_config = json.loads(os.environ["TF_CONFIG"])
    cluster_spec = tf.train.ClusterSpec(tf_config["cluster"])
    # Debug info to check if tf_config is set correctly
    logger.info(f"{wname}: TF_CONFIG {os.environ['TF_CONFIG']}")

    # Prepare model
    strategy = tf.distribute.MultiWorkerMirroredStrategy()
    with strategy.scope():
        dist_is_ready = tf.Variable(
            initial_value=tf.constant(0, dtype=tf.dtypes.int64),
            name="dist_is_ready",
            synchronization=tf.VariableSynchronization.ON_WRITE,
            aggregation=tf.VariableAggregation.SUM,
        )

    logger.info(f"{wname}: Replicas in sync: {strategy.num_replicas_in_sync}")
    logger.info(f"{wname}: {dist_is_ready}")

    task_type, task_id = (
        strategy.cluster_resolver.task_type,
        strategy.cluster_resolver.task_id,
    )
    if _is_chief(task_type, task_id, cluster_spec):
        logger.info(f"{wname}: Assign ready")
        dist_is_ready.assign(1)
    else:
        while dist_is_ready.numpy() < 1:
            logger.error(f"{wname}: dist_is_ready is {dist_is_ready.numpy()}...")
            logger.error(f"{wname}: Wait for chief...")
            time.sleep(5)

    logger.info(f"{wname}: All done. dist_is_ready is {dist_is_ready.numpy()}.")

if __name__ == "__main__":
    train()

docker/Dockerfile
FROM tensorflow/tensorflow

RUN pip install --quiet --upgrade --pre tf-nightly
RUN mkdir -p /app/log

COPY ./src/* /app/

WORKDIR /app

docker-compose.yml
services:
  worker0:
    image: local/worker
    build:
      dockerfile: ./docker/Dockerfile
      context: ./
    command: ["./minimal-example.py"]
    networks:
      - cluster
    environment:
      TF_CONFIG: '{"cluster": {"worker": ["worker0:30000", "worker1:30000"]}, "task":
        {"type": "worker", "index": 0}}'
      TF_LOGDIR: /app/log
      WORKER: worker0
    volumes:
      - ${PWD}/log/worker0:/app/log

  worker1:
    image: local/worker
    build:
      dockerfile: ./docker/Dockerfile
      context: ./
    command: ["./minimal-example.py"]
    networks:
      - cluster
    environment:
      TF_CONFIG: '{"cluster": {"worker": ["worker0:30000", "worker1:30000"]}, "task":
        {"type": "worker", "index": 1}}'
      TF_LOGDIR: /app/log
      WORKER: worker1
    volumes:
      - ${PWD}/log/worker1:/app/log

networks:
  cluster: {}

Start with
docker compose build && docker compose up

### Relevant log output

```shell
distributed-learning-worker1-1  | 2023-03-27 07:52:46,080 - worker1 worker1: dist_is_ready is 0...
distributed-learning-worker1-1  | 2023-03-27 07:52:46,080 - worker1 worker1: Wait for chief...
distributed-learning-worker0-1  | 2023-03-27 07:52:46,082 - worker0 worker0: All done. dist_is_ready is 1.
distributed-learning-worker0-1 exited with code 0
distributed-learning-worker1-1  | 2023-03-27 07:52:51,087 - worker1 worker1: dist_is_ready is 0...
distributed-learning-worker1-1  | 2023-03-27 07:52:51,087 - worker1 worker1: Wait for chief...

</details>

@pfaeffli
I tried to replicate the issue on the virtual linux machine using TFv2.12  but facing a different error. Please find the below screenshot for reference:

Could you please provide detailed steps to replicate the issue reported here ?
Thank you !


auto (magically) build ext adapter_java.jar

this isn't something completely new - has been used on master before
I mean it was working fine with :git sources pointed towards AR-JDBC.
gist of it is that the adapter_java.jar is removed from repo and git ignored.
on release (there's a rake task for that) the adapter .jar is git add -f and commited.
the problem is that it seems to me that we're forgetting to commit the .jar
even if this is fixed eventually, as there are native changes, per branches it might cause headaches.
anything against this piece? really would prefer having to now worry about missed .jar commits

@enebo @rdubya any objections?

@kares So rake will commit it but only when we release.  Otherwise we ignore it and reduce clutter of making our git repo slowly huge?  Sounds good if that is it.
An alternative may be to just require that anyeone who works on our project must just have javac installed and we just ignore it all the time?  That seems a lot simpler with the caveat that we inched the bar up a little bit for new developers.

I think it makes sense. I was never sure if I should be committing it on every change or not, and if we forget then it then it messes with the tests.
I could see skipping it altogether like @enebo mentioned too. Guessing most people trying to run this stuff would already have the jdk installed anyways, but it would potentially raise the bar a bit.

An alternative may be to just require that anyeone who works on our project must just have javac installed and we just ignore it all the time?

well, its pretty much ignored all the time, but when releasing you want to include the piece so you do not trigger an ext build when installing the gem (but I see how it might be consufing). if I got it right than yes a full exclude is doable - include that one file despite it not being in the repo on release, guess we won't miss being able to lookup a tag. will look into that as a follow-up.

@kares it will be double plus super saiyan awesome to get rid of that jar being committed!!!

@enebo actually that is done, already. but thanks for the encouragement :)


remove unused perspective from header parsing

Codecov Report

Merging #1625 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1625      +/-   ##
==========================================
- Coverage   87.57%   87.57%   -0.01%
==========================================
  Files          98       98
  Lines        6252     6249       -3
==========================================
- Hits         5475     5472       -3
  Misses        555      555
  Partials      222      222

Impacted Files
Coverage Δ

packet_handler_map.go
93.13% <100%> (-0.15%)
:arrow_down:

internal/wire/header_parser.go
93.75% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0fa1f...9028537. Read the comment docs.


Encode MJPEG into h264 and stream it by means of WebRTC

Hi,
Thanks for RTSPtoWeb, it works really well with WebRTC.
I have a scenario where I need to use a videocamera unable to send a stream; it can only send raw frames to the PC it's connected to. It's easy to generate a MJPEG stream from such frames, but it's highly inefficient.
I'd like to encode the frames of this MJPEG stream in h264 and serve the h264 stream by means of WebRTC. Would it be possible to implement this feature? I'd be willing to pay for helping the development.
Thanks,
Alessandro

Sure, here's my docker-compose.yaml file:
version: "3.3"
services:
  rtsp-server:
    privileged: true
    restart: unless-stopped
    ports:
      - "8554:8554"
      - "8888:8888"
    environment:
      - RTSP_PROTOCOLS=tcp
    image: aler9/rtsp-simple-server

  ffmpeg-1:
    privileged: true
    restart: unless-stopped
    image: akashisn/ffmpeg:4.4.1-qsv
    links:
      - "rtsp-server:rtsp-server"
    devices:
      - /dev/dri/renderD128
    depends_on:
      - rtsp-server
    command: ${FFMPEG_INPUT_OPTS} -i ${STREAM1_URL} ${FFMPEG_OUTPUT_OPTS} ${RTSP_SERVER}/${STREAM1_NAME} ${FFMPEG_OUTPUT_OPTS}

and my .env file:
FFMPEG_INPUT_OPTS="-loglevel warning -hide_banner -hwaccel_output_format qsv -hwaccel qsv -qsv_device /dev/dri/renderD128 -avoid_negative_ts make_zero -fflags nobuffer -flags low_delay -strict experimental -fflags +genpts+discardcorrupt -use_wallclock_as_timestamps 1 -f mjpeg -re"
FFMPEG_OUTPUT_OPTS="-an -g 20 -c:v h264_qsv -r 10 -global_quality 25 -look_ahead 1 -f rtsp -rtsp_transport tcp"
RTSP_SERVER="rtsp://rtsp-server:8554"

STREAM1_NAME="stream1"
STREAM1_URL="http://xxx"

If you don't have an Intel CPU you can remove some of the hardware acceleration stuff. Incidentally this also gets you an HLS stream, so you may not even need RTSPtoWeb for browser playback.
(Inspired by https://github.com/blakeblackshear/frigate/issues/4153)


Wrong Result on Sync Cron

Hi, as I am developing my schedule service, I found that this package does not have any feature to save/persist the job that have been inserted, and so each time the program restarted, the job will also be gone.
So I came up with idea to save the job to the database and in my case, i am using mongodb.
The idea is each time the program restarted, I will do "sync cron" from my db to my cron.
Here is my code in golang:
func SyncCron(myCollection *mongo.Collection) *cron.Cron {

	c := cron.New()

	filter := bson.M{}
	cursor, err := myCollection.Find(context.TODO(), filter)
	if err != nil {
		log.Fatal().Err(err).Msg("failed to find schedule collection")
	}

	records := model.MyModel{}
	err = cursor.All(context.TODO(), &records)
	if err != nil {
		log.Fatal().Err(err).Msg("failed to translate data from db to object")
	}

	for _, record := range records {
		entryIdInt := -1
		if record.IsActive {
			log.Info().
				Interface("record", record).
				Str("record.Url", record.Url).
				Msg("add record")

                       // iterate each record to be sync/saved again to the cron,
                       // including the record.url (in this case, my command is to call some url using curl GET)
                       // and the url is mostly unique
			entryId, err := c.AddFunc(record.Spec, func() {
				http.DefaultClient.Get(record.Url)
			})
			if err != nil {
				log.Fatal().Err(err).Msg("cron.AddFunc failed")
			}
			entryIdInt = int(entryId)
		}

		filter := bson.M{"compression_id": record.CompressionId}
		update := bson.M{"$set": bson.M{"entry_id": int(entryIdInt)}}

		updateRes, err := myCollection.UpdateOne(context.TODO(), filter, update)
		if err != nil {
			log.Fatal().Err(err).Msg("scheduleCollection.UpdateOne failed")
		}

		log.Info().Int64("updated count", updateRes.MatchedCount).Msg("update result")
	}

	c.Start()

	return c
}

But the problem is, when the cron running, all the records hit to the same url same with the last one from the db records.
For example I have 3 records, with url to Url-A, Url-B, Url-C.
After sync, all record will hit to Url-C instead of to 3 different URL.
Any help on why this happened will be very much appreciated.
Thank you

[SOLVED]
I found the solution,
it seems that the parameter "cmd" with data type func() need to be returned from another function as a func.
-updated code below

new function that will return func()

func createCurlCommand(url string) func() {
	return func() {
		http.DefaultClient.Get(url)
	}
}

and on line that insert it into new function.
entryId, err := c.AddFunc(record.Spec, createCurlCommand(record.Url))


Using keystrokes in Explorer

A nice addition to the Explorer would be the ability to use keystrokes to navigate through folders/files.
In a standard Windows/MacOS explorer, whenever you start typing a file/folder name, the pointer travels to the file/folder with letters beginning with whatever you've typed.
Having that in VSCode's explorer could help navigate throughout the app and the file system using only the keyboards faster.

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.


is this working well in Xcode 7.3 as it supports Swift 2.2?

Hello,
I am starting my new project but I have xcode 7.3 which support Swift 2.2 version.
Is this working in that without any issue?
Thank you,

Hi.
I am working now on a complex project and we faced some issues with disappearing access-token in response header. I have not noticed any other problems. I am working on latest Xcode and Swift 2.2. I am using http request: POST, GET, PATCH and DELETE and they work fine - except the token issue.


Can't withdraw rewards

I have ~360 Ada in rewards and Nami says I can't withdraw:

This is an issue with version 1.1.3. Version 1.1.4 should be out soon that fixes this again

1.1.4 is out now. Let me know if it works now and then we can close the issue.

I will test again next epoch as I withdrew rewards with Daedalus.

Can confirm that it works now. Thanks!


Update autocomplete setup for tags selection

This PR:

updates the autocomplete component to use the latest version
updates the autocomplete setup to narrow down suggestions after typing 3 characters

Trello card

@alex-ju I think you need to turn off 'showAllValues', otherwise it'll ignore the minLength option.

@benthorner that's right. I did that by removing the showAllValues options, which is false by default.

@benthorner thanks! I'll wait to discuss the approach with our PM before merging it.


Timeout

I have aa parrot flower that is correctly responding when using app from android  ( first version)
My device is correctly detected by my android app
but I have  a timeout value exceeded when dealing from HASSIO
I wander if it is possible to  change the timeout value for sensors ?
I tried to modify the def value in the  *.py but without success.
Tried also to put a timeout value in yaml without success
any Idea to fix it ?
extract of hassio log
(<Thread(SyncWorker_9, started<PHONE_NUMBER>33392)>) 2022-05-29 12:09:12 INFO (SyncWorker_0) [custom_components.parrotflowerpower.sensor] Polling data for FlowerPower HIDE Light Intensity 2022-05-29 12:09:12 INFO (SyncWorker_0) [custom_components.parrotflowerpower.parrotflowerpower_poller] Filling cache with new sensor data for device 90:03:B7:hide:hide:hide:hide. 2022-05-29 12:09:22 WARNING (MainThread) [homeassistant.helpers.entity] Update of sensor.flowerpower_hide_light_intensity is taking over 10 seconds

Sorry, I don't have Flower Power anymore so I'm not maintaining this anymore. You are free to fork it, if you want to continue it.
The warning about polling taking more time is "normal", I see it often with different sensors.
I don't know what kind of hardware are you running on, but Raspberry has many issues with bluetooth, most often when programs try to access it at the same time.

Hi
Thks
I am running on docker with NipoGi
Debian
No pb with other ble devices except Flower Power
10 juin 2022 11:33:49 MarkoMarjamaa @.***>:

Sorry, I don't have Flower Power anymore so I'm not maintaining this anymore. You are free to fork it, if you want to continue it.
The warning about polling taking more time is "normal", I see it often with different sensors.
I don't know what kind of hardware are you running on, but Raspberry has many issues with bluetooth, most often when programs try to access it at the same time.
—
Reply to this email directly, view it on GitHub[https://github.com/MarkoMarjamaa/homeassistant-flowerpower/issues/2#issuecomment-1152168949], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AD7K4I6I3JNYYAZSBVWF5KTVOMDXXANCNFSM5XH6BF6Q].
You are receiving this because you authored the thread.[Image de pistage][https://github.com/notifications/beacon/AD7K4I4HBYYTPJR2SYGYAGTVOMDXXA5CNFSM5XH6BF62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOISWLH5I.gif]


Various bug fixes.

This PR contains fixes for various bugs I ran into while using this crate, separated into different commits. Here is a summary:

Channel needs to be Send to be used as an rtic resource. I think this is safe, but I'm not totally sure what the potential safety issues are in this context.
Interrupt flags need to be cleared by setting the relevant bits, not clearing them.
TransferDescriptor was missing functions to adjust the beat size.
TransferDescriptor's implementation of Default called itself, leading to infinite recursion
DMA trigger source definitions were wrong

SAMD5x trigger sources were missing Sercom2Tx and Sercom3Rx, causing all subsequent source IDs to be wrong.
Trigger sources were not defined for the SAMD21 (the SAMD51's were incorrectly used instead)

Thanks for submitting this PR! I've already made some of the changes you have in my local copy, but I never pushed them until now. Specifically, commits bd4d9a3 and c02e592, which add the (get|set)_beat_size methods and fix the Default recursion problem. I'd recommend you cherry-pick the other commits into a new branch, and submit another PR with that branch. I'm happy with the rest of the changes, so once you do that I'll approve it ASAP.

Thanks for submitting this PR! I've already made some of the changes you have in my local copy, but I never pushed them until now. Specifically, commits bd4d9a3 and c02e592, which add the (get|set)_beat_size methods and fix the Default recursion problem. I'd recommend you cherry-pick the other commits into a new branch, and submit another PR with that branch. I'm happy with the rest of the changes, so once you do that I'll approve it ASAP.


⚠ Bofrost.de has degraded performance

In 68acaab, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1617 ms

Resolved: Bofrost.de performance has improved in e4969f3 after 8 minutes.


Doesn't work for polygons

I can't convert a GeoJSON file with polygon data to CSV!
e.g. https://gist.github.com/ngoldman/05603d639276b0c1f69d
Long story short it ends up producing some very invalid CSV data:
lat,lon
43.2421875,56.17002298293205,55.54687499999999,46.07323062540838,86.484375,56.559482483762245,61.17187499999999,63.074865690586634,48.8671875,61.438767493682825,43.2421875,56.17002298293205,undefined

I stumbled onto this while trying to figure out what the standard notation for a polygon is in CSV. So far the only reliable one I've found is WKT which is a little gross. Thoughts?

:ship: :wave:


npmName check bug: True/False behaviours are reversed

When a name is taken in npm, you will NOT be re-prompted to choose a new name (npmName(answers.name) === false)
When a name is available in npm, you will be re-prompted to choose a new name (npmName(answers.name) === true)
This is happening in a fresh install of node, npm, yeoman, and generator-node, on OSX 10.10.3
In line 72 of index.js, done(...) is directly provided the result of the call to npmName(answers.name). So the done(...) function is given true when a name is available - but true being provided to done(...) indicates the question should be asked again - so the solution is just flipping this boolean.
Will have an incredibly brief PR submitted shortly!
Hopefully I'm not missing something obvious or seeing atypical behaviour (wrong version of something, or something), feel free to let me know here or in the PR if I am!

As touched on in PR, slightly misunderstood the issue - fix involves calling done() when ready to proceed, done(true) to re-prompt if name is already taken in npm

Ah! Thanks for the fix. I updated and it was working again.


[Details Nerdlet] Fix GINORMOUS checkbox image on Firefox

The verified checkbox shows up GINORMOUS in Firefox
steps to repro

[ ] go to staging and view I/O > pack details on Firefox
[ ] See giant image

PR  GH ENT catalog-pack-details/pull/30


fix: class name case

was a bit tricky, because it passed in docker-bundle - different build environment


WPT tests for script.evaluate

[ ] wpt-metadata/.../bidi/script/evaluate is removed.

https://github.com/GoogleChromeLabs/chromium-bidi/issues/211


Question: skipping the host selection

Hi.
I daily use remote-edit to edit files on a unique remote Unix machine.
Most of the time, during several days, I have to edit files from a same remote directory.
Up to now - or do I misss something- I recall remote-edit in the palette, select the host from the list (the list contains all the target directory on the unique host I have deal with during the month) and then select the file to open.
Is there a way to skip the host selection -aka always open the same destination from the list- to go directly to the browse of remote files ?
Thx

If you have enabled the "Remember last open directory" in the settings panel it will automatically take you to the same directory for said host that you were in last time. You still have to do the host selection. Alternatively, if you want to edit the same file, you can use "Show open files".


docs: improve component doc page ux

✅ Simplified header, moved theme switcher to top right

✅ Header is sticky and blurs background content

✅ Smaller/simplified example card icon buttons

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


(fix): correct typing of AnnData.X

[ ] Re: https://github.com/scverse/anndata/pull/1598#issuecomment-2314890727
[ ] Tests added
[ ] Release note added (or unnecessary)

I don’t quite know why that one is an enum, maybe we can replace it with

I also didn't know but don't really question these sorts of things.  I imagine it served a purpose at some point, but like I said in the related PR, that seems to have changed recently.

I guess then we should unify the two. Either as part of this PR or later, as you wish

We could maybe use __instancecheck__ and is_array_api_obj:
import array_api_compat

class ArrayApiMeta(type):
    def __instancecheck__(cls, instance: object):
        return array_api_compat.is_array_api_obj(instance)

class ArrayApi(meta=ArrayApiMeta):
    pass

I'm going to push back on the array-api here because I think it's out of scope and testing for it will be non-trivial.  I think we should make a separate branch/PR for that specifically, and stick it in 0.12.  We can test for jax, which now has a working CPU implementation (like numpy).  This would be a very cool feature.

There's even an issue for this: https://github.com/scverse/anndata/issues/1195


Fixed Issue #68194 involving ColorPicker being allowed to align horizontally when it shouldn't

Fixed the ColorPicker class to disallow the vertical checkbox option in the editor and be set to vertical by default.
This fix was implemented by making the ColorPicker class a subclass of VBoxContainer and initializing with the VBoxContainer constructor.
Bugsquad edit: Fixes #68194

Looks good, but the docs should be synced too with doctool: https://docs.godotengine.org/en/latest/community/contributing/updating_the_class_reference.html
(Or apply the diff from https://github.com/godotengine/godot/actions/runs/3394381224/jobs/5642870378)

Thanks!

My pleasure.


MB-10490 add duty location model, migrate GHC

Jira ticket for this change
Summary
In the ongoing saga of migrating duty station -> location this PR adds the model, swagger definitions and migrates the GHC API. I tried doing the internal one at the same time and the PR got really bloated. Following I'll migrate the other APIs - internal and orders seem like they'll have the most changes.
Most of this is renaming, in some places we still have the old dutyStation reference.
 Make sure the moves queue is still working as expexted.
Verification Steps for Reviewers
These are to be checked by a reviewer.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Messages

:book:
:link: MB-10490

  Generated by :no_entry_sign: dangerJS against f87277a648020ed3b1a3c8afa070f6a5c3dd345b

closing to open a new one, cherry-picking got this branch into a weird state


The Gezira code embedded in nile-compiler.html won't compile with the Maru compiler.

The Gezira code embedded in compilers/js/nile-compiler.html won't compile under the Maru compiler.
After extracting the code (w/o the prepended prelude.nl) to a file and running it under the Maru compiler, ala:
bash nile-to-c-compiler.sh gezira ../../examples/gezira.nl
It aborts when it tries to ask a nile-recordtype for it's name.  Simple variable typo fix in compilers/maru/nile-ast-nodes.l
With that fixed, code generation still fails due to five type issues Maru found.  After fixing those, both the C and Maru code generators properly generate code. And the JS compiler still appears to be happy.

Nice work.
Regarding using the embedded Gezira code: that was copy-n-pasted from some version of the code from the gezira repository. There is an issue with synchronizing three moving parts: the Javascript-based Nile compiler, the Maru-based Nile compiler, and the code in the gezira repository. Because Nile is a moving target, I'm actually surprised that you've come up with a version of all three that are mutually compatible.
There were even later versions of those that I never made public. I was still in the process of developing them when I swore off working on this until I could write my dissertation. That's what I'm doing now.

You're definitely a mind reader – That was one of two questions I was going to ask you (Gezira variants).
The other question deals with the generated code.  The C code the Maru generator is generating right now isn't the same as the committed examples (in Nile's examples/c/, or Gezira's c/). Just to help get everything back in sync, my question to you is which style you would bless as the current? I understand this may be a bit hazy, so if function signatures help to jog your memory:
Committed examples:
static nile_Buffer_t * gezira_TransformBeziers_body (nile_Process_t *p, nile_Buffer_t *in, nile_Buffer_t *out)
vs.
Current Maru generated code:
static int gezira_TransformBeziers_body (nile_Process_t *p, float *in, int i, int m, float *out, int j, int n)
Of course these changes look very much related to the runtime changes I made the other day.  Maybe those weren't necessary after all?

The latter example is the more recent one. I do think that it was an improvement over the previous approach.
IMO, neither is really above the threshold to bless, so to speak. But until I've finished writing, it'll have to do.
You may be interested in seeing what the very latest function signature looked like:
typedef void (*nile_Process_function_t)
(nile_Process_t *p, nile_Stream_t *input, nile_Stream_t *output,
void *process_memory, void *resume_point);
The "process_memory" is for accessing the process parameters and variables, and the "resume_point" is for pausing and resuming processes at any point of process execution (still cooperative multitasking style, though). I used computed GOTOs first, but later just wrapped most of the generated process function body in a giant switch statement (that's where the "resume_point" is used). Didn't think it would work. But it did. I'm pretty sold on that approach now.


Convert SitemapItem to an ES2015 class

@ekalinin This one (and #153) are good to go too :)

@realityking
Done. Thanks a lot for your help!


[NEW] Kubernetes Operational View

Create Helm Chart for Kubernetes Operational View.

The Chart should work, tested with helm 2.1.3 and Kubernetes 1.5.2 :smile:
NOTE:

the Chart does not yet expose "advanced" configurations to monitor multiple clusters (i.e. it only shows the cluster it currently runs in)
the Chart does not yet configure a Redis backend, i.e. it uses a memory-only backend for message pub/sub which only works correctly for replicaCount=1.

@k8s-bot ok to test

@prydonius updated to 63 chars :smile:

@prydonius ready for your next pass

thanks @hjacobs, lgtm!


Add a note the plugin can be installed from the marketplace

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   44.03%   44.03%
=======================================
  Files           8        8
  Lines         822      822
=======================================
  Hits          362      362
  Misses        433      433
  Partials       27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9ea1c...28b0081. Read the comment docs.

/update-branch

Codecov Report

Merging #144 (074d909) into master (d533d34) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   41.34%   41.34%
=======================================
  Files           7        7
  Lines         803      803
=======================================
  Hits          332      332
  Misses        450      450
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d533d34...074d909. Read the comment docs.


Add TOML syntax highlighting to README

Before:

After:

Thanks! Ignore the noise from AppVeyor, that's something else :-)


CB-13332: (iOS) Error When Taking Picture Missing NSPhotoLibraryAddU…

…sageDescription

Platforms affected
iOS
What does this PR do?
Fixes issues in iOS when taking a photo where app would crash because of missing NSPhotoLibraryUsageDescription
What testing has been done on this change?
Change was tested on an ionic app on iPhone 6s running iOS 11.
Checklist

[X ] Reported an issue in the JIRA database
[X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[X] Added automated test coverage as appropriate for this change.

To use this, you must add to your config.xml
<variable name="PHOTOLIBRARY_ADD_USAGE_DESCRIPTION" value="Access Photo Library for Profile Picture" />

Thanks for you PR, but you are just duplicating NSPhotoLibraryUsageDescription, the one needed for iOS 11 is NSPhotoLibraryAddUsageDescription.
Anyway, we are removing the preferences like this from the plugin.xml as it causes conflicts with other plugins requiring the same permissions.
The correct way of adding the permissions is using edit-config tag in the config.xml like this
<edit-config target="NSPhotoLibraryAddUsageDescription" file="*-Info.plist" mode="merge">
    <string>need to save on the photo library for some reason</string>
</edit-config>

Can you close the PR?

FYI, NSPhotoLibraryAddUsageDescription is required when your plugin needs write access (shouldn't be required for read access) https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html

Yeah, it's only required if you have saveToPhotoAlbum option set to true, for reading then you need NSPhotoLibraryUsageDescription
Either way, you have to use edit-config tag to set them, the plugin is removing the variables as they caused a lot of problems when other plugins wanted to set the same values


Video playing stopped when i Remove youTubePlayerView view from it's parent

Im trying to create a media App, so I'm playing videos from code and not via xml using this library :
youTubePlayerView = YouTubePlayerView(this)
    youTubePlayerView.addYouTubePlayerListener(object : AbstractYouTubePlayerListener() {
        override fun onReady(youTubePlayer: YouTubePlayer) {
            youTubePlayer.loadVideo("0EVVKs6DQLo",0f)
            layout1.addView(youTubePlayerView)
        }
    })

when i add youTubePlayerView to another layout to show video on my activity for example as bellow :
layout1.removeView(youTubePlayerView)
layout2.addView(youTubePlayerView)

video was stopped !!, is there any solution to make video still playing even if i remove it's relative view (youTubePlayerView) from it's parent (layout1) because i still have youTubePlayerView instance which is not yet destroyed ? !
Thank's

Hi, i don't think this is possible.


Expose local logical volumes and attach them to the local node

Which issue(s) this PR fixes:

Issue Longhorn/longhorn#8551
What this PR does / why we need it:
Expose local logical volumes and attach them to the local node

Expose local logical volumes and attach them to the local node
To expose a logical volume and attach it to the local node, NGUID should be provided.

Special notes for your reviewer:
Additional documentation or context

LGTM. Merge this after updating the dep.

Updated. Thank you.


Serializing Prompts with Partial Variables

I am interested in making using of Prompt serialization in order to allow for more modular use of models / chains.
I noticed when partial variables were initially added in this PR, there was some discussion about their interaction with serialized prompts, which resulted in these lines being added to disable serialization of prompts with partial variables.
In my testing I found that partial variables seem to work well as is, if those lines are removed, as done in this PR.

https://github.com/hwchase17/langchain/pull/3734

I'm happy to help with developing this feature, but would be interested to hear more about what the reasoning was for initially disabling it, as I am sure there are edge cases I am missing. Thanks!

Interested as well!


Deprecated subdependencies found: maybe upgrade these packages?

These dependencies were introduced by this plugin and are now the only deprecated packages in my project:
 WARN  3 deprecated subdependencies found<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Hi @GZTimeWalker! Fixed with v3.9.5


Collect additional iface metrics: mtu, num tx/rx queue and tx queue length

What does this PR do?
Collect iface metrics exposed in /sys/class/net on linux.
Motivation
Having MTU available is useful to chase down possible misconfigured instances which could increase IP fragmentation and lower network performance.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Added Linux only mentions

From #metrics-resolution we've added these new metrics to our tables on gov, us5, us3, eu1, us1, and staging 👍

👋 from metrics-resolution we've updated the metrics-metadata tables in all DCs so we're ready when you are 👍

👋 from our end we've updated the metrics metadata tables in all DCs so we're ready when you are 👍


Inline grid editor not rendering date picker in date column

This was reported by QA testing of a client app and is currently reproducible in toolbox: https://toolbox-dev.xh.io/app/grids/inlineEditing
You expect the editable date column to show you a date picker, and I believe it used to behave this way. Based on the client app, it appears the behavior changed between versions 56.6.0 and 59.3.2.

Upon closer inspection of the DOM, it looks like the date picker is still there but there has been a change to the element's styling, setting the display to none.


Add gradient of Erlang

I do not fully understand what the log-partition function means with respect to the first natural parameter, as it can only take a countable set of values. Yes, indeed symbolically we can take this derivative, but it's strange.


[SPARK-9352] [SPARK-9353] [HOTFIX] Reverts PR #7668 on branch-1.4

MasterSuite.makeMaster() doesn't compile under 1.4. Master is still an actor in branch-1.4, and can only be created via ActorSystem.actorOf, or with TestActorRef.

cc @andrewor14

I'm merging this to branch-1.4 to bring Jenkins 1.4 builders back.

Merged build triggered.

Merged build started.

Test build #38510 has started for   PR 7686 at commit 089a1a8.

Thanks @liancheng for fixing this. I'll do a more careful job back porting next time.

(could you close this since it's already merged?)

Test build #38510 has finished for   PR 7686 at commit 089a1a8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


updated EO version to 0.29.4

PR-Codex overview
This PR updates the version of the eo-runtime and eo-maven-plugin dependencies, and makes some minor changes to code in three files.
Detailed summary

Updated eo-runtime and eo-maven-plugin dependencies to version 0.29.4
Changed the return type of walk function in dir.eo from /array to /tuple
Minor changes to memory-as-output.eo and bytes-as-input.eo files

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256 Please, have a look

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)


make the shadow cover only one single row when hovered

Would there be a way I could make the shadow cover only one single row in list facet? And how could I do that?

As far as I read the tooltip part, there would not be suitable configs for that. What I want to do is to give accurate feedback for interaction, and now it would be easy to misunderstand I haven't hover on the right bar.
If I missed anything in the doc, please let me know.

It is a bug of interval geometry, we'll fix it.


Add exports file for XMLSTOREDP

XMLSTOREDP currently exports a ton of functions, most of which should be exported from the main XMLSERVICE service program (#26) instead. Basically just the iPlug* entries should be exported from XMLSTOREDP for use by the stored procedures (https://github.com/IBM/xmlservice/blob/master/src/xmlstoredp.sql.in).

Are the iPLUGR* exports the ones in question?  Those functions don’t exist in XMLSERVICE, so do they need to be moved?

All the functions referenced by https://github.com/IBM/xmlservice/blob/master/src/xmlstoredp.sql.in need to be exported by XMLSTOREDP service program, but nothing else should be. Currently it just exports everything, which leaks a lot of internals.

OK, I see now.  The unwanted exports are coming from the copybooks.  So we need binding source to only export the needed functions.  I don't see that the project currently has any binding source.

I assume the file needs to go in the src directory?
What's the standard for the binding source signature?
I believe the CRTSRVPGM in Makefile.in would need to be changed.   As far as the signature goes, I'm up for suggestions. CRTSRVPGM doesn't allow export source from an IFS file, so the Makefile will need changes to create a source physical file and copy it in to it.

For signatures, here we just use the *SRVPGM name and a date or version number.  We don't distribute software, so we've never really put a lot of thought in to it.
I've committed the binding source (https://github.com/Justin-E-Taylor/xmlservice/blob/master/src/xmlstoredp.bnd) but haven't submitted a PR yet.  I haven't got the local build working yet, and I want to do that first.
As an aside, what's with the .rpglesql extensions, shouldn't they be .sqlrpgle?  RDi recognizes .sqlrpgle but not .rpglesql.

what's with the .rpglesql extensions, shouldn't they be .sqlrpgle?

You'd need to ask @rangercairns on that. :man_shrugging:
That's bugged me too. Feel free to change it (make sure to updated Makefile.in rules).

I'm probably too much of a newb to rocking the boat too much regarding file extensions.
I compiled the *SRVPGM locally and submitted the PR.  The PR shows action required, but that will have to wait until next week.

The "action required" is resolved.  I haven't looked at the makefile yet. I wanted to get the binding source up ASAP for feedback on the signature.

After thinking about it afterwards, we should just use *GEN for the signature, since nobody should be actually linking to this service program. (Db2 doesn't care about signatures as it loads everything dynamically at runtime).

I had just a few minutes last week and I tried to run the makefile as-is.  It failed but I didn't have time to dig into it.  I got back to it today, looked more closely but still can't determine the problem.
Here's what I get:
-bash-4.3$ ./configure --lib JUSTIN
-bash-4.3$ make
make: Cannot find a rule to create target JUSTIN.lib from dependencies.
Stop.
-bash-4.3$

I have only the most basic familiarity with Makefiles, but it looks it looks like it should create the library.  It does not.
Any suggestions?

I think you need to install GNU make: yum install make-gnu (make sure to run hash -r afterwards if you've already run make in that session).

Bingo!  I keep forgetting IBMi is "batteries not included".  Thanks

@Justin-E-Taylor I just found 'RUNASCII' was missing from the exportsrc. Looks like some procedures are supposed to be called outside xmlservice in plugrun.xml.

@jimoibm I opened #37 for that problem.


.

.
.
.
more
form filler

Current dependencies on/for this PR:

main

PR #173   👈

This stack of pull requests is managed by Graphite.


repl component should replicate brackets as well as normal IPs

I discovered that the repl component does not replicate bracket IPs. It seems like it should.
If you agree, this is the PR for you!
If not, please let me know and let me know the rationale - I'd be curious

Well spotted...!  Definitely a bug - however... I believe a bracket IP can have contents as well.  Or at least, it should be able to.  So repl needs to replicate the type as well as the contents.  I'll leave this as an exercise for the reader - you!  :-)

Doh! Fixed.