Use IDictionary.Contains instead of exceptions to get glimpse request id

Don't use exceptions for control flow when it's not an 'exceptional' situation, and a perfectly good alternative exists. It's bad (tm). Or more to the point, it's friggen annoying when debugging (also slower etc).

@jeffora Sorry for the delay. We are going to be doing some work on this stuff tomorrow night and will bring this in then. Thanks for the patch!

how about this:
var guid = context.Items[GlimpseConstants.GlimpseRequestId] as Guid?;
        if (guid.HasValue)
            return guid.Value;

        Guid result;
        context.Items[GlimpseConstants.GlimpseRequestId] = result = Guid.NewGuid();
        return result;

Yeh that would work. Forgot about the need to store the new GUID when answering yesterday. Sorry took so long to comment, I didn't have access to a computer yesterday and wasn't sure on whether the context dictionary would throw a KeyNotFoundException. I'll update the commit with your change

@nikmd23 are we good to pull this one in?

Closing this as I don't think it's relevant anymore leading into v1.0


Add built-in support for GLSL Integer Functions

Implements #467.
OpenGL versions including and above 3.1ES and 4.0 support integer functions. The function signatures do not change between versions, nor were any functions added after 3.1ES, so I went ahead and added to the ShadingLanguageVersion interface instead of manually checking all the versions in TyperHelper.
Regarding the change in TyperTest, the test was not set up to handle void-returning functions, producing statements like:
uint testwhatever()
{
return imul(u0, u1, u2, u3);
}
when imul() is a void function. This would cause a validation error, so I added a void type check.

(This PR will require #525 to be merged before it passes tests - the test failures here are related to that PR.)

I've readded the functions that require out parameters, since I put up PR #533 that fixes issues #522 and #524. This PR will need that one merged before it passes tests.


question about fs2 infer

Hi, thank you very much for your valuable SVS corpus and code.
I strictly follow your instruction until step "2. Training Example" for SVS, in https://github.com/MoonInTheRiver/DiffSinger . Then I am somewhat stuck here. The error message is:
Validation sanity check: 0%| | 0/1 [00:00<?, ?batch/s] Traceback (most recent call last): File "tasks/run.py", line 19, in run_task() File "tasks/run.py", line 14, in run_task task_cls.start() File "/data/juicefs_speech_tts_v2/public_data/tts_public_data/11090357/singing/diffsinger/DiffSinger/tasks/base_task.py", line 256, in start trainer.fit(task) File "/data/juicefs_speech_tts_v2/public_data/tts_public_data/11090357/singing/diffsinger/DiffSinger/utils/pl_utils.py", line 489, in fit self.run_pretrain_routine(model) File "/data/juicefs_speech_tts_v2/public_data/tts_public_data/11090357/singing/diffsinger/DiffSinger/utils/pl_utils.py", line 565, in run_pretrain_routine self.evaluate(model, self.get_val_dataloaders(), self.num_sanity_val_steps, self.testing) File "/data/juicefs_speech_tts_v2/public_data/tts_public_data/11090357/singing/diffsinger/DiffSinger/utils/pl_utils.py", line 1173, in evaluate for batch_idx, batch in enumerate(dataloader): File "/root/miniconda3/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 363, in next data = self._next_data() File "/root/miniconda3/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 989, in _next_data return self._process_data(data) File "/root/miniconda3/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1014, in _process_data data.reraise() File "/root/miniconda3/envs/diffsinger/lib/python3.8/site-packages/torch/_utils.py", line 395, in reraise raise self.exc_type(msg) FileNotFoundError: Caught FileNotFoundError in DataLoader worker process 0. Original Traceback (most recent call last): File "/root/miniconda3/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 185, in _worker_loop data = fetcher.fetch(index) File "/root/miniconda3/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch data = [self.dataset[idx] for idx in possibly_batched_index] File "/root/miniconda3/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in data = [self.dataset[idx] for idx in possibly_batched_index] File "/data/juicefs_speech_tts_v2/public_data/tts_public_data/11090357/singing/diffsinger/DiffSinger/usr/diffsinger_task.py", line 93, in getitem fs2_mel = torch.Tensor(np.load(f'{fs2_ckpt}/P_mels_npy/{item_name}.npy')) # ~M generated by FFT-singer. File "/root/miniconda3/envs/diffsinger/lib/python3.8/site-packages/numpy/lib/npyio.py", line 416, in load fid = stack.enter_context(open(os_fspath(file), "rb")) FileNotFoundError: [Errno 2] No such file or directory: 'checkpoints/popcs_fs2_pmf0_1230/P_mels_npy/popcs-说散就散-0000.npy'
It seems that the required file is not properly process in "1. Data Preparation" step, though the first step was passed successfully with the following prompt:
test_input_dir: , test_num: 0, test_prefixes: ['popcs-说散就散', 'popcs-隐形的翅膀'], test_set_name: test, timesteps: 100, train_set_name: train, use_denoise: False, use_energy_embed: False, use_gt_dur: True, use_gt_f0: True, use_nsf: True, use_pitch_embed: True, use_pos_embed: True, use_spk_embed: False, use_spk_id: False, use_split_spk_id: False, use_uv: True, use_var_enc: False, val_check_interval: 2000, valid_num: 0, valid_set_name: valid, validate: False, vocoder: vocoders.hifigan.HifiGAN, vocoder_ckpt: checkpoints/0109_hifigan_bigpopcs_hop128, warmup_updates: 2000, weight_decay: 0, win_size: 512, work_dir: , | Binarizer: <class 'data_gen.singing.binarize.SingingBinarizer'> | spk_map: {'SPK1': 0} | Build phone set: ['', '', '', 'a', 'ai', 'an', 'ang', 'ao', 'b', 'c', 'ch', 'd', 'e', 'ei', 'en', 'eng', 'er', 'f', 'g', 'h', 'i', 'ia', 'ian', 'iang', 'iao', 'ie', 'in', 'ing', 'iong', 'iou', 'j', 'k', 'l', 'm', 'n', 'o', 'ong', 'ou', 'p', 'q', 'r', 's', 'sh', 't', 'u', 'ua', 'uai', 'uan', 'uang', 'uei', 'uen', 'uo', 'v', 'van', 've', 'vn', 'x', 'z', 'zh', '|'] 100%|████████████████████████████████████████████| 27/27 [00:13<00:00, 2.01it/s] | valid total duration: 330.677s 100%|████████████████████████████████████████████| 27/27 [00:13<00:00, 2.04it/s] | test total duration: 330.677s 100%|████████████████████████████████████████████| 1624/1624 [11:55<00:00, 2.27it/s] | train total duration: 20878.560s
I guess the output of Step 1 and input of Step 2 are possibly not chained perfectly. Any help or hints will be welcome. Thank you in advance.

Yes, you are right. There is a problem. You need run "CUDA_VISIBLE_DEVICES=0 python tasks/run.py --config usr/configs/popcs_fs2.yaml --exp_name popcs_fs2_pmf0_1230 --reset --infer" in advance to produce the files "P_mels_npy". I have fixed the readme file. Thanks for your report!

I have a question about it, if we are training from scratch and we don't have any saved models for inference, how does the P_mels_npy(predicted mels I guess) generated?
Originally posted by @Cescfangs in https://github.com/MoonInTheRiver/DiffSinger/issues/11#issuecomment-1038568795

I guess we should train fs2 models first in order to generate P_mels_npy?

What? I'd updated the new readme yesterday.

What? I'd updated the new readme yesterday.

Sorry, I didn't notice you've updated the readme file yesterday


Cleanup Figma File

Description / User Story
This task is to cleanup the Figma file. This includes i.e.:

deleting empty pages
deleting / moving internal pages
check if some duplicates, instances or fragments are lying around somewhere in the pages, that do not belong there

If we have time we should also do:

Review & Read all texts
Spellchecking
Token Overview has been added / updated (Token configuration page in Figma)

TIMEBOX: 1 iteration

Acceptance Criteria

[ ] Cleanup of Figma File has been done

Background information

...

@larserbach , @m-nti , this issue has been finished, so we can close it, right?


SHGetFolderPathA: Escape backslash

Escaped backslashes to prevent formatting breakage.

@xerif : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Adding custom CSS classes to Html element component | form design

Updating the documentation to include

custom CSS classes to Html element component to override existing behaviour of the components
add new CSS class for specific purpose and refer back in advanced components.
Update the existing example form reference with new form with CHEFS team members.

Looks good, although I think that the version of form.io that we're using has a bug that is allowing this. You shouldn't be able to put <style> into these components :(
https://help.form.io/userguide/form-building/layout-components#html-element

Maybe something to discuss with the POs? We might not want to be encouraging behaviour that will break in the future?

Looks good, although I think that the version of form.io that we're using has a bug that is allowing this. You shouldn't be able to put <style> into these components :( https://help.form.io/userguide/form-building/layout-components#html-element  Maybe something to discuss with the POs? We might not want to be encouraging behaviour that will break in the future?

thank you for pointing this out, I will bring it up with Keyvan, Duncan and Matt about it. We may not need this at all.


GPU memory leak in adahessian optimizer?

Hi
I am using your library and appreciate all the work you have put into this capability.  I started using the adahessian optimizer and found that my GPU memory would increase until it used all my GPU memory and the run crashed as the optimizer operated.  The leak seems to be within the get_trace routine and I believe it is can be fixed by changing
      hvs = torch.autograd.grad(
            grads, params, grad_outputs=v, only_inputs=True, retain_graph=True
        )

to
      hvs = torch.autograd.grad(
            grads, params, grad_outputs=v, only_inputs=True, retain_graph=False
        )

If you get a chance to check this out, please comment to let me know.
Thanks!

@sjscotti Would you like to submit PR with proposed fix? Could be counted as part of hactoberfest.

Thanks for the suggestion, but I don't have experience in submitting pull requests.  I did give it a try but I was stuck at the first step (comparing branches).
BTW, you might also add a @torch.no_grad() decorator before each routine in adahessian.  I saw that done for some other implementations of adahessian (and there may be other optimizers in your library that could also use this decorator).


sample/zoap_server: correct large-update/large-create block handling

When testing against etsi_coaptest.sh, test cases TD_COAP_BLOCK_03/04 will get stuck. This is because these testcases send out a blockwise transfer but with an empty payload. Although this should be a legit request, large-update/create handlers did not check "MORE" flag in block1 option and always return an error when a request comes with an empty payload.
Corrected as below

Initialize zoap_block_context when first block arrives.
(SIZE1 option is not always available. In the case that SIZE1 is
unavailable, the zoap_block_context will be re-initialized each time
a new block has arrived)
Check "MORE" flag of block1 option. If it's the last block, then an empty payload should be allowed.
Response w/ 2.04 CHANGED when the last block has arrived
Remove adding block2 option to the response since we are not sending back any data to the caller

I re-apply the work on top of #1232 when it's merged.

Rebase on top of #1232, @rveerama1 please take a look at the patch.

LGTM.

@jukkar please help to take a look at the PR. Thanks


Editor: Only HTTPS URLs

iOS and Android only support HTTPS URLs. This means we need to ensure no HTTP URLs are set in the editor. If a user enters a HTTP URL, we should check if the resource is available with HTTPS. If yes, the link could be updated automatically. If the resource is not available, the user should be warned and the link rejected.

Duplicate of #68


TwitterKit navigate to Twitter App to connect but my app crash when return back

I use TwitterKit and when twitter application installed on iOS device my application twitter share property opens the installed twitter application to connect. Besides when return back to my application after connect page my application CRASH
Here is my code:
if ([[Twitter sharedInstance].sessionStore hasLoggedInUsers]) {         TWTRComposerViewController *composer = [TWTRComposerViewController emptyComposer];         composer.delegate = self;         [self presentViewController:composer animated:YES completion:nil];     } else {         [[Twitter sharedInstance] logInWithCompletion:^(TWTRSession *session, NSError *error) {             if (session) {                 TWTRComposerViewController *composer = [TWTRComposerViewController emptyComposer];                 [self presentViewController:composer animated:YES completion:nil];             } else {                 UIAlertController *alert = [UIAlertController alertControllerWithTitle:@"No Twitter Accounts Available" message:@"You must log in before presenting a composer." preferredStyle:UIAlertControllerStyleAlert];                 [self presentViewController:alert animated:YES completion:nil];             }         }];     }

This repository is for Twitter Kit for Android, not iOS. I'd recommend that you join the developer forums and see whether anyone else has had the same issue. That would be the best place to reach the development team.


what abot IoT Core?

talk about IoT Core requirements

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1fe9907-f850-a8ae-112b-30d154468fe1
Version Independent ID: b1f64595-9c3c-61ce-4c51-84c642371af4
Content
Content Source
Service: unspecified

Self-assigned @barrygolden for investigation.

Initiated contact with IoT Core team resources for information on UEFI requirements for IoT Core.

@dvescovi1, thanks for reaching out to the Windows driver developer documentation team and filing an issue on the docs regarding UEFI on IoT vs. traditional Windows platforms. We've filed an internal work item (18382061) to add more information about this in a future documentation update.
If you have specific scenarios that you'd like discuss with the IoT or driver developer community, we recommend that you visit the following forums, where other driver developers and Microsoft engineers can be found. The community there is quite responsive.
MSDN Windows Hardware WDK and Driver Development forum
NTDEV forum at OSR Online
Feel free to submit a pull request on the driver docs to help us benefit from your knowledge and experience with the WDK.


Can we specify a port to bind to?

I can spin up a container .withExposedPorts(1234) but that doesn't let me specify the port that it gets bound to on the host. I know I can get call .getMappedPort(1234) after the container is started, but I need to define a healthcheck that curls the container (like in the example), and the mapped port isn't available then.
Can we specify a fixed port on the host to bind to, and error if it's not available?

Hi @helgridly, there isn't a way to specify a port to bind to.
The health checks run within the container so if the port is 1234 you can use that directly (eg curl http://localhost:1234)

Oh - I assumed they ran from the outside, on the host. Thanks!


[$250] Pronouns - Default Priority Mode Not Highlighted and marked, Causing Inconsistency

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.64-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Create a new account and navigate to Account Settings > Preferences > Priority Mode
Note that "Most Recent" is the default selection but is not highlighted or marked, leading to inconsistency with other default selections such as Language and Timezone

Expected Result:
The "Most Recent" default selection should be automatically highlighted and marked, aligning with other default sections like Language and Timezone
Actual Result:
The default priority mode is not highlighted or marked, causing inconsistency with other sections like Language and Timezone
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/9fcd1ed0-a30e-4012-bb5c-0dd1d152a485
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014e981393fc9a3ead
Upwork Job ID:<PHONE_NUMBER>003403264
Last Price Increase: 2024-04-23

@puneetlath  I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We don't store anything if the priority mode isn't gsd, so I think it's easier to have the front-end handle the default in this scenario.

Great, assigned @ZhenjaHorbach.

@ZhenjaHorbach has been paid.
@fedirjh bump on the checklist.

Issue for regression tests: https://github.com/Expensify/Expensify/issues/395853
Everyone has been paid. Thanks y'all!


Doesn't work in Sublime 3 ?

This doesn't to work in Sublime any more - tried with package installer and installing manually

Yes very sad that the # lines in my markdown are no longer colored. :( Hoping to find someone who has this working in ST4


Bring back older packages

Back by popular demand.  This is a revert of a26376148ef0d0d83e450d25439190400516e2b9 with the packages marked as deprecated.
I'll modify the build def to publish continue publishing the old packages to the buildtools feed while the newer ones will get published to the msbuild feed.  The older ones will continue to follow the versioning scheme 0.1.0-X and the new ones are versioned 15.1.X.
When I rename MSBuild.exe to MSBuild.dll I'll have to update the old packages as well.  Hopefully soon we can stop building them.
FYI @nguerrera @eerhardt

@dotnet-bot test OSX Build for CoreCLR please
and make sure it passes this time

Seems ok. 👍

@dotnet-bot test OSX Build for CoreCLR please


Added spanish translation

I've translated your awesome picker to Spanish! Thanks a lot for such an amazing work!
If you wanna I can upload your project to maven too.
Thanks!

I would be wonderful if we could use this component through gradle.
Enviado desde mi iPhone.

El 11/03/2015, a las 13:15, Javi<EMAIL_ADDRESS>escribió:
I've translated your awesome picker to Spanish! Thanks a lot for such an amazing work!
If you wanna I can upload your project to maven too.
Thanks!
You can view, comment on, or merge this pull request online at:
https://github.com/roomorama/AndroidCountryPicker/pull/15
Commit Summary
Added spanish translation
File Changes
A CountryPicker/res/values-es/strings_countries.xml (5)
Patch Links:
https://github.com/roomorama/AndroidCountryPicker/pull/15.patch
https://github.com/roomorama/AndroidCountryPicker/pull/15.diff
—
Reply to this email directly or view it on GitHub.


[ffmpeg] Slow build process with low CPU utilization

Describe the bug
When installing ffmpeg with vcpkg, the build process is extremely slow, taking up to 1.6 hours to complete. Additionally, CPU utilization remains very low during the build (consistently below 30%).
Environment

OS: Windows 11 Professional 23H2
vcpkg version: 2024-11-12-eb492805e92a2c14a230f5c3deb3e89f6771c321
Toolchain: Visual Studio 2022, MSVC 14.42.34433
Triplet: x64-windows
Hardware: Intel i9-12900K, 32GB RAM

Reproduction Steps

Install ffmpeg using the command:
.\vcpkg.exe install ffmpeg

Observe that the build process is extremely slow, taking over an hour to complete, and CPU utilization remains consistently below 30%.

Expected Behavior The build should leverage more CPU cores and complete significantly faster, especially on high-performance hardware.
Additional Context

I've already tried restarting my computer and reinstalling vcpkg, but the issue persists.
No other CPU-intensive programs were running during the build.
Proxy is configured: <IP_ADDRESS>:7890
The problem seems related to inefficient use of system resources during the build.

Logs Below is the complete log from the build process:
PS D:\ymj\code\cpp\vcpkg> .\vcpkg.exe install ffmpeg
Computing installation plan...
The following packages will be built and installed:
<EMAIL_ADDRESS>Detecting compiler hash for triplet x64-windows...
-- Automatically setting %HTTP(S)_PROXY% environment variables to "<IP_ADDRESS>:7890".
Compiler found: D:/VisualStudio/VC/Tools/MSVC/14.42.34433/bin/Hostx64/x64/cl.exe
Restored 0 package(s) from C:\Users\ymj\AppData\Local\vcpkg\archives in 174 us. Use --debug to see more details.
Installing 1/1<EMAIL_ADDRESS>Building<EMAIL_ADDRESS>-- Using cached ffmpeg-ffmpeg-n7.1.tar.gz.
-- Cleaning sources at D:/ymj/code/cpp/vcpkg/buildtrees/ffmpeg/src/n7.1-d40f62baf3.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source D:/ymj/code/cpp/vcpkg/downloads/ffmpeg-ffmpeg-n7.1.tar.gz
-- Applying patch 0001-create-lib-libraries.patch
-- Applying patch 0002-fix-msvc-link.patch
-- Applying patch 0003-fix-windowsinclude.patch
-- Applying patch 0004-dependencies.patch
-- Applying patch 0005-fix-nasm.patch
-- Applying patch 0007-fix-lib-naming.patch
-- Applying patch 0013-define-WINVER.patch
-- Applying patch 0020-fix-aarch64-libswscale.patch
-- Applying patch 0024-fix-osx-host-c11.patch
-- Applying patch 0040-ffmpeg-add-av_stream_get_first_dts-for-chromium.patch
-- Applying patch 0041-add-const-for-opengl-definition.patch
-- Applying patch 0043-fix-miss-head.patch
-- Using source at D:/ymj/code/cpp/vcpkg/buildtrees/ffmpeg/src/n7.1-d40f62baf3.clean
-- Found external ninja('1.12.1').
-- Getting CMake variables for x64-windows
-- Using cached msys2-automake-wrapper-20240607-1-any.pkg.tar.zst.
...
-- Fixing pkgconfig file: D:/ymj/code/cpp/vcpkg/packages/ffmpeg_x64-windows/debug/lib/pkgconfig/libswscale.pc
-- Dependencies (release):
-- Dependencies (debug):
-- Installing: D:/ymj/code/cpp/vcpkg/packages/ffmpeg_x64-windows/share/ffmpeg/usage
-- Installing: D:/ymj/code/cpp/vcpkg/packages/ffmpeg_x64-windows/share/ffmpeg/copyright
-- Performing post-build validation
Stored binaries in 1 destinations in 3.5 s.
Elapsed time to handle ffmpeg:x64-windows: 1.6 h
ffmpeg:x64-windows package ABI: 5bae88431e5dfc894accc3cd6c3f2e25b029f99a02c116498c89acd3985bfe7c
Total install time: 1.6 h
To use ffmpeg add the following to your CMake project:

    find_package(FFMPEG REQUIRED)
    target_include_directories(main PRIVATE ${FFMPEG_INCLUDE_DIRS})
    target_link_directories(main PRIVATE ${FFMPEG_LIBRARY_DIRS})
    target_link_libraries(main PRIVATE ${FFMPEG_LIBRARIES})

PS D:\ymj\code\cpp\vcpkg>

Suggestions

Could the low CPU utilization be due to inefficient parallelization during the build process?
Is there a way to manually increase the parallelization level or optimize the build process?

Thank you for your assistance!

The build uses parallel jobs via make -j${JOBS}. The actual value is found in the build.sh script which is generated at build time.
(However, this port doesn't use the regular vcpkg_build_make.

There should be much need for tuning. Check the logs if something goes wrong. Check the environment to not limit VCPKG_MAX_CONCURRENCY. Check that antivirus operations don't cause interference.

FTR vcpkg CI has:
Installing 324/2396<EMAIL_ADDRESS>....
Elapsed time to handle ffmpeg:x64-windows: 23 min

Thank you all for your help and suggestions! The issue has been resolved.
I was able to restore the normal build speed by using the dControl software to disable the Antimalware Service Executable process on my system. I hope this solution can help others facing similar issues.
Thanks again for the support from the community!


First attempt at adding fonts to imgui. imgui.PushFont(font1) is not …

…working but imgui.ShowFontSelector("font selector") is

This method is not going to work so closing this request and will open a new one.


fix: multiple writeack in IBC core #187

Description:
Commit Message
fix: multiple write ack in IBC core #187

see the guidelines for commit messages.
Changelog Entry
0.1.0: Added Check to prevent ack overwrite.

Checklist:

[x] I have performed a self-review of my own code
[x] I have documented my code in accordance with the documentation guidelines
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run the unit tests
[x] I only have one commit (if not, squash them into one commit).
[x] I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Codecov Report

Merging #640 (8dba201) into main (f6d2e8f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #640      +/-   ##
============================================
- Coverage     69.02%   69.01%   -0.01%
  Complexity      408      408
============================================
  Files           151      151
  Lines         14016    14012       -4
  Branches        294      294
============================================
- Hits           9675     9671       -4
  Misses         4185     4185
  Partials        156      156

Flag
Coverage Δ

rust
67.16% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...bc-core/src/ics04_channel/packet/receive_packet.rs
81.15% <100.00%> (+0.14%)
:arrow_up:

.../src/ics04_channel/packet/write_acknowledgement.rs
100.00% <100.00%> (ø)


Pinging a Doctor

Hi @emilyncosta
This is where I'm working on documenting the process of preparing a pipeline for the analysis of your genomes.

@emilyncosta I'm working on a single-script / single-genome based solution as of now.
The script is here https://github.com/abhi18av/BioDragon/blob/master/Genesis/Genomes/1_single_genome/genesis_test_script.sc
The structure of directory is
.
|-- G04868_R1_p.fastq
|-- G04868_R2_p.fastq
|-- NC000962_3.fasta
`-- genesis_test_script.sc


fix TestClient to preserve raw URI

Summary of Changes
When following raw URL recipe based on RAW_URI, it breaks routing with TestClient because TestClient hard-code RAW_URI CGI variable to /.
Related Issues
#2157
Pull Request Checklist
This is just a reminder about the most common mistakes.  Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

[x] Applied changes to both WSGI and ASGI code paths and interfaces (where applicable).
[x] Added tests for changed code.
[x] Prefixed code comments with GitHub nick and an appropriate prefix.
[x] Coding style is consistent with the rest of the framework.
[x] Updated documentation for changed code.

[x] Added docstrings for any new classes, functions, or modules.
[x] Updated docstrings for any modifications to existing code.
[x] Updated both WSGI and ASGI docs (where applicable).
[x] Added references to new classes, functions, or modules to the relevant RST file under docs/.
[x] Updated all relevant supporting documentation files under docs/.
[x] A copyright notice is included at the top of any new modules (using your own name or the name of your organization).
[x] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.

[x] Changes (and possible deprecations) have towncrier news fragments under docs/_newsfragments/, with the file name format {issue_number}.{fragment_type}.rst. (Run towncrier --draft to ensure it renders correctly.)

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.

Thank you for merging. I did it primarily for myself :-) My API heavily relies on correct %2F handling. When will it be approximately released in the PyPI?


iOS Ionic Cordova build fails.

XCode won't build an iOS app in Ionic 4 with this plugin installed. Just installing the plugin, without even calling the plugin the app fails to build in Xcode.

+1

Same problem +1

same problem


Consider implementing entries(&mut self) -> impl Iterator<Item = OccupiedEntryRef>

See my comment here for the motivation: https://github.com/rust-lang/rust/issues/59618#issuecomment-1520583112 .
Unfortunately, the impl can't just be added. hashbrown's EntryRefs are currently Send, which means that they can't be allowed to co-exist. Allowing this API would require removing the Send impls on those types. Before someone starts with the implementation, is that something the crate would consider? The tradeoff is pretty clearly well-motivated imo, especially since the entry types already have lifetimes and so aren't exactly likely to be sent across threads much.

That doesn't work due to the way the Iterator trait works: the value returned by next() is not tied to the lifetime of the iterator, which means you can call it multiple times and end up with multiple OccupiedEntryRef at the same time. This is unsound since they each hold a mutable reference to the underlying HashMap.

@Amanieu sure, but that's fixable by just... Not doing that, right? We can have them hold a *mut HashMap and a pointer to their bucket or something like that

The problem is in the Item type on the Iterator trait: it has to contain a lifetime but this lifetime cannot refer to the lifetime of the iterator itself. Consider IterMut of Vec for example, it returns &'a mut T but you can call .next mutliple times on it to obtain multiple mutable references to distinct elements at the same time.

I understand that. My point is that we should allow OccupiedEntryRefs to coexist - that's a feature. I don't think there's any reason that can't be implemented outside of needing to make them non-Send

This exposes too much of the implementation details of the current hash table implementation. For example, the previous implementation (before hashbrown) would shift adjacent entries on deletion. This would invalidate references to other elements in the table.

No, I would like to keep the high-level HashMap/HashSet independent of the underlying implementation. Of course this is not the case for RawTable which directly exposes implementation details.


Issue with Deploying Teams Recording Bot

Describe the issue
on deployment team-recording bot namespace tls-ingress is not in ready state. So the certificate is note ready
deployment code:
https://github.com/jinik21/TeamsRecordingBot/blob/master/03_IaC/00_AzureCLI/02_AKS_iac.ps1
Expected behavior
certificate should be generated and teams recording bot container should be ready.
Logs
kubectl get pods -n teams-recording-bot
output:
NAME READY STATUS RESTARTS AGE
teams-recording-bot-0 0/1 ContainerCreating 0 42m
can't setup certifcates:
kubectl get cert -n teams-recording-bot
NAME READY SECRET AGE
ingress-tls False ingress-tls 41m
kubectl logs -n teams-recording-bot teams-recording-bot-0
Error from server (BadRequest): container "recording-bot" in pod "teams-recording-bot-0" is waiting to start: ContainerCreating
pod logs:
[Pod] [teams-recording-bot-0] FailedMount: Unable to attach or mount volumes: unmounted volumes=[certificate], unattached volumes=[kube-api-access-bnvqt certificate]: timed out waiting for the condition
11 mins ago [Pod] [teams-recording-bot-0] FailedMount: Unable to attach or mount volumes: unmounted volumes=[certificate], unattached volumes=[certificate kube-api-access-bnvqt]: timed out waiting for the condition
1 min ago [Pod] [teams-recording-bot-0] FailedMount: MountVolume.SetUp failed for volume "certificate" : secret "ingress-tls" not found
682 msecs ago [Pod] [teams-recording-bot-0] Scheduled: Successfully assigned teams-recording-bot/teams-recording-bot-0 to aksscale000000

Which version of certificate manager and nginx ingress are you using?

OK, so it seems like that you're cluster issuer still uses the template for older version, I think you should replace it with the new solver selection from the cert manager docs

I made changes in the template
can you follow :https://docs.microsoft.com/en-us/answers/questions/903197/container-remains-in-container-creating-state.html?childToView=915702#comment-915702
getting persistence volume mount error.
if possible can you share some reference links

I assume the bot stays in container creating because the certificate fails to create and k8s can not mount the Certificate to The bot pods as the certificate does not exist, for changing the cluster issuer checkout the cert manager docs

can you go through this file that I am using:
https://github.com/jinik21/TeamsRecordingBot/blob/master/00_RecordingBot/deploy/cluster-issuer.yaml

The sample was build up on old versions of ingress and cert Manger, if you are using newer versions you also have to update the templates so you're cert manager and und you're ingress work as intended

@1fabi0 Can you please have a look at this? This is a similar issue while doing deployment on AKS for teams recording bot samples with the latest Kubernetes versions > 1.22
https://github.com/microsoftgraph/microsoft-graph-comms-samples/issues/594


feat: sort by serial number

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[ ] Refactoring

Context

[ ] Closes #<issue_number>
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[ ] My DOT address: Payout

Screenshot 📸

[ ] My fix has changed UI

@yangwao @exezbcz should we add back sort by s/n? wdyt?

It does not load on items explore

It does not load on items explore

aahh thank you, I filtered out on items explore
seems like error on the queries

it works well if you filter by collection, but if you don't numbers are not serialized properly on profile:
https://deploy-preview-9551--koda-canary.netlify.app/ahk/u/CmWHiv7h4m9tEzKD94DH4mqwGTvsdYQe2nouWPF7ipmHpqA?sort=sn_DESC


Optimize  ´_process_decoded_element´

What is needed?
With large number of events the decoded process is taking long times causing indexing delays.
The main reason looks to be _process_decoded_element, then we should find out how to optimize this function.

is_setup_indexed is consuming in some situations a few more time.
In the next picture we can see that this is happening during ProxyFactory event decoding, that should happen after the Setup event.
This two events are frequently indexed in a short time between them.
Creating a cache and storing that the Setup is indexed during the setup indexing, will avoid to hit database during ProxyFactory indexing.

tested and verified!


Make cirq.final_state_vector and cirq.AbstractCircuit.final_state_vector consistent

There are some inconsistencies that we should resolve:

cirq.final_state_vector does not have ignore_terminal_measurements - we should decide if we want this everywhere or not, but inconsistency is the worst
the AbstractCircuit version seems to have its own simulator (iterating through unitaries) instead of using Simulator - we should have AbstractCircuit delegate to cirq.final_state_vector or similar...

This has sat around for long enough that both methods are out of date. I'd like to consolidate on:
def final_state_vector(
    circuit: 'cirq.CIRCUIT_LIKE',  # cirq.fsv() only
    *,
    initial_state: 'cirq.STATE_VECTOR_LIKE' = 0,
    param_resolver: 'cirq.ParamResolverOrSimilarType' = None,
    qubit_order: 'cirq.QubitOrderOrList' = ops.QubitOrder.DEFAULT,
    ignore_terminal_measurements: bool = True,
    dtype: Type[np.number] = np.complex64,
    seed: 'cirq.RANDOM_STATE_OR_SEED_LIKE' = None,
) -> 'np.ndarray':
    # invoke cirq.Simulator(...).simulate(...)

This involves:

For Circuit, adding param_resolver and seed and dropping qubits_that_should_be_present
Also for Circuit, enforcing kwargs instead of positional args
For the top-level method, adding ignore_terminal_measurements

xref https://github.com/quantumlib/Cirq/issues/5242

But wait, there's more!

The two methods have different default final measurement behavior (Circuit ignores them, cirq fails on them)

ignore_terminal_measurements is a strange parameter in general. At best, it's a "I know what I'm doing" flag for people to get state vectors out of circuits with measurements, but a default of True completely undermines that.

The two methods use different default dtypes (Circuit uses complex128, cirq uses complex64)

Cirq is wildly inconsistent about which of these to use (48 and 53 files for 64 and 128, respectively), but the simulators prefer complex64 so that's what I'll use here.
Our results show that double-precision floats don't significantly improve simulation fidelity over single-precision.


to add docs for install mina-create-legacy-ledger

We don't have the doc for installing mina-create-legacy-ledger, this could cause some confusion for the user. Let's add that to the doc.

Package no longer exists in repo, and the upgrade has completed. Closing.


pushing intensity.py and associated test

I think this should do it, but let me know if there are any functionality and/or style things I'm missing.

Sorry for making a huge mess of this! I'll fix it tomorrow

sounds good -- ping me when you're to have this looked at

This is now functional! @JBGreisman let me know if I'm handling input types correctly; it seemed consistent with other similar functions to accept lists, numpy arrays, and rs.DataSeries.

I am going to make the changes above, and push them to a new branch intensities-clean. This is hopefully the easier path than trying to untangle the above PR.

See #156

@dennisbrookner Can this be closed now that a new PR has been started?

Yes, closing this


OCPBUGS-14824: Bump efs-csi-driver-operator library-go

Bump library-go
The library-go fix openshift/library-go/pull/1541 merged we also need to bump the library-go dependency for operators.
$ go get -u github.com/openshift/library-go
go: downloading github.com/spf13/cobra v1.6.1
go: upgraded github.com/openshift/api v0.0.0-20230509100629-894b49f57a15 => v0.0.0-20230613151523-ba04973d3ed1
go: upgraded github.com/openshift/library-go v0.0.0-20230508110756-9b7abe2c9cbf => v0.0.0-20230626162119-954ade536d6d
go: upgraded github.com/spf13/cobra v1.6.0 => v1.6.1
$ go mod tidy && go mod vendor

/test operator-e2e

Namespace ci-op-mnyr3ghg deleted, trying once again before taking a deeper look.
/test operator-e2e

/test ci-index-aws-efs-csi-driver-operator-bundle

/lgtm
/label docs-approved
/label px-approved

/retest

/approve


Fix max error message wording

I've changed the max error message to say 50 or less instead of 'less than 50` since you can enter the maximum amount.

Let's keep it consistent with what Laravel has and use the following:
'numeric' => 'The :attribute may not be greater than :max.'
'string'  => 'The :attribute may not be greater than :max characters.'
Can you change it to that?

@skaterdav85 done!

thanks!


Add CODEOWNERS to the repo

Currently there are no CODEOWNERS configured in this repo, and I clearly missed some GitHub notifications for #50

Created a PR for this. @oleg-nenashev @christian-kreuzberger-dtx should additional people be added?


Bugfix/htlc flush shutdown

Change Description
This change fixes an issue where we would fail a channel when a peer sent us a shutdown message while there were still active HTLCs: see #6039
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

Deleted the staging branch, but this should go into master.
I can't re-open this for some reason.

I don't think mvar is necessary here and the same thing can be accomplished in a simpler way.

@Crypt-iQ can you hint at what the easier way might be? Maybe it's an atomic.Pointer[func ()] ? I worry about using that as it leaves a lot of the synchronization stuff to the caller and I'm trying to move us towards a world where we aren't actively coding synchronization everywhere in the codebase.


[T3A4][T11-A2]Tong Fionna

Ready for review.

@fionnatong Some comments added. Please close the PR after reading comments.


Use OpenSSL for SipHash implementation, drop vendored siphash.{cc,h}

This is similar to #25: since tkconv already depends on OpenSSL, through cpp_httplib's Client, we can use its implementation of SipHash instead of bundling our own.
The upside is less clear here, since the bundled implementation is small and OpenSSL's implementation has some generality that is not needed here. Still, I wanted to offer this as an option.
Behavior should be unchanged.

There is no dependency on openssl per se, only if we want to. So see no upside here, sorry!


⚠ Minecraft has degraded performance

In 0f80bc0, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 784 ms

Resolved: Minecraft performance has improved in bc36112.


Add support for empty delimiter in String.split()

Using split() with empty delimiter was resulting in no splits, because the method uses find() to find the delimiter. I added a special case for 0-length delimiter and now it splits every character ("string" becomes ["s", "t", "r", "i", "n", "g"]). It's also now a default argument.
EDIT:
Closes https://github.com/godotengine/godot-proposals/issues/5719

dgf

Formally, this PR breaks compatibility. Although in practice the current "string".split("") -> ["string"] makes little sense.

Thanks!

I forgot to add a test for rsplit().


notification stuck

I can't seem to get rid of my last notification. Help, my OCD is killing me.
my log id: 878b46f7f3c8ead3d1fd8c1c

I should clarify on mine then. I have not experienced the issue on Android.

cc @buoyad and @chrisnojima
we're changing this right now.  but if you are on the home page (with the "consider following..." section, etc), and then you click to a different tab, it should clear the badge.
it won't clear the badge if you start on the home screen, then click on the new follower, then click to a different tab (which we're fixing)
if i'm wrong lmk

It appears to have been fixed! Can't confirm for others, but I'll close this issue.


Use specific error in Authorisation Service golem-worker-service-base

closed in #269

Closed in https://github.com/golemcloud/golem/pull/269


Custom keyword filters possible?

Any chance of sometime in the future getting an option to add filters that let us filter out tasks that have words/phrases of our choice in them?
For instance I got some requesters that I like doing hits for but they often put up a ton of hits that I'm not eligible for and I could easily filter those out if I could just create a list of keywords that would automatically hide the task from showing up.
Also it'd make hiding anything transcription related super easy since 9/10 transcription hits have the word Transcribe in it.

Thanks for this suggestion @Omniphantasm. This seems possible but the challenge is making it so users don't inadvertently hide a HIT (or many HITs) that they would have otherise liked to do. I might be able to ship it within a few major versions but in the mean time, I'll try to make blocking single unwanted HITs as simple as possible.


implementation of an algorithm for the binary union operator

This should be straightforward.
The class that contains this algorithm may be called ExecOpBinaryUnion (in package se.liu.ida.hefquin.engine.queryplan.executable.impl.ops). A few simple unit tests should also be written for this new class (including one that tests that duplicates are kept).
To include the algorithm in the query planning, a corresponding implementation of BinaryPhysicalOpForLogicalOp is needed (to be added in the package se.liu.ida.hefquin.engine.queryplan.physical.impl).

Once the operator is in place, it can be hooked into the query planner to be when creating an initial physical plan for a given logical plan. The place for doing so is the method convertUnion in LogicalToPhysicalPlanConverterImpl. After that, it should be possible to test the operator in an end-to-end query process, which can be done by adding another unit test to QueryProcessorImplTest. This unit test should use a simple SPARQL query with a SERVICE clause that contains a UNION pattern.

This TODO has been addressed by PR #30.


Add E2E test: [Trigger] Info icon is clickable and opens popover

### Tasks
- [ ] Add E2E automation script

Moved to Dev Ops


not working

i have years of experience dealing with servers and mapping drives and permissions etc
no matter how i type the share path
this app will NOT WORK.
i tried IP address
tried domain name
tried two windows local admin accounts
tried public folder.
NOTHING
really disappointed
is anyone reading these issues?

yes @ejmichel same here.
I have tried everything.
Now I am starting to read the code.
Let's see.


Location header changed incorrectly

I have seen that there already are a few Location header related issues but after looking through them I'm not sure whether they describe the same issue we are seeing.
Consider this nginx configuration:
server {
    listen <IP_ADDRESS>:8080;

    server_name app.internal.net;

    pagespeed on;
    pagespeed FileCachePath /var/cache/nginx/pagespeed;

    location / {
        proxy_pass http://<IP_ADDRESS>:9090;
    }
}

And this "app":
require 'socket'

server = TCPServer.new('<IP_ADDRESS>', 9090)
loop do
  socket = server.accept
  socket.gets

  socket.print "HTTP/1.1 302 Moved Temporarily\r\n"+
               "Content-Type: text/html; charset=UTF-8\r\n"+
               "Location: /home\r\n"+
               "\r\n"
  socket.close
end

The nginx configuration represents an app server in the internal network that receives requests from some loadbalancer facing the world.
Making a request to the application directly is not surprising at all:
# curl -I <IP_ADDRESS>:9090 \
    -H Host:app.internal.net \
    -H X-Forwarded-Host:example.com
HTTP/1.1 302 Moved Temporarily
Content-Type: text/html; charset=UTF-8
Location: /home

The Host and X-Forwarded-Host headers reflect the loadbalancer configuration.
If we send the request through a pagespeed enabled nginx instead, the Location header changes:
# curl -I <IP_ADDRESS>:8080 \
    -H Host:app.internal.net \
    -H X-Forwarded-Host:example.com
HTTP/1.1 302 Moved Temporarily
Content-Type: text/html; charset=UTF-8
Location: http://app.internal.net:8080/home
X-Page-Speed: <IP_ADDRESS>-4448
[ further headers omitted]

http://app.internal.net:8080/home is not reachable for the user agent that originally requested http://example.com/.
To me it is surprising that the header changes in the first place. If there is a good reason for that, I would really like #716 to be implemented.
Thanks for taking the time to look at this.
Cheers,
Peter

@crowell @jeffkaufman
Any concerns if optional X-Forwarded-Port and X-Forwarded-Host support would be added?
Alternatively to implementing those, we could add an option to override part of the document base (protocol://host:port/) via a (scriptable) pagespeed directive, e.g.
If we could allow script support for that, one could either hard-code a single host (safe) in configuration or fill in the protocol/host/port at request time via scripting when there's a trusted proxy running in front which always sets those.
# Hard coded, no worries about external manipulation
pagespeed UrlBaseOverride "http://foo.com"

or
# Can only do this when there's always a trusted proxy running in front which guarantees those are set
pagespeed UrlBaseOverride "$http_x_forwarded_proto://$http_x_forwarded_host:$http_x_forwarded_port"

The Location header should be an absolute URL by the RFC.


HA 0.92 - Frontend not available - Event loop is closed

Home Assistant release with the issue:

0.92
Last working Home Assistant release (if known):
0.91.4
Operating environment (Hass.io/Docker/Windows/etc.):

Armbian, arm64, venv, python 3.5.3 (khadas vim pro)
Component/platform:

Frontend
Description of problem:
On the start of Home Assistant debug log shows the traceback below. Systemctl shows that service is running, rolling back to the previous version shows that sensors values are collected to the database, but frontend is not loading
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
The problem persists no matter if custom components are enabled in config or not

Traceback (if applicable):
ERROR (Thread-15) [concurrent.futures] exception calling callback for <Future at 0xffff42d6e208 state=finished returned NoneType>
Traceback (most recent call last):
  File "/usr/lib/python3.5/concurrent/futures/_base.py", line 297, in _invoke_callbacks
    callback(self)
  File "/usr/lib/python3.5/asyncio/futures.py", line 463, in _call_set_state
    dest_loop.call_soon_threadsafe(_set_state, destination, source)
  File "/usr/lib/python3.5/asyncio/base_events.py", line 618, in call_soon_threadsafe
    self._check_closed()
  File "/usr/lib/python3.5/asyncio/base_events.py", line 357, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

Additional information:

Could you post the log coming from the same thread earlier than traceback? For example, in your posted log, it is Thread-15.
Also please turn on debug logging
logger:
  default: debug

it was always from a different thread. once with the amcrest component, then with the telegram and then on the main thread. Somehow the issue disappeared after about 20 minutes of waiting. As I cannot reproduce the issue anymore, I will close it. Thank you

I'm getting the same issue... always different thread.
Running Debian Stretch (Python 3.5)

it doesn't seem related to any specific component but with core. Each restart a different component thread gets the exception.

Upgrading to Python3.7 (buster) fixes the issue

I'm getting this error too since upgrading to 0.92.1. I'm using HassOS, so upgrading Python is not an option

If you use custom updater... try to comment it out in you config. That worked for me

I'm not using the custom updater. Only commenting out this component did work

I'm not using the custom updater. Only commenting out this component did work

I am confused, are you using custom updater or not?

Well I got the issue without ANY custom component

@awarecan Sorry, I was misleading. I'm not using the custom updater, and by "this component" I meant this repository aka the alexa_media component.

@balloob, maybe change
https://github.com/home-assistant/home-assistant/blob/fe1840f9016c87288840f307620484e8683885cc/homeassistant/core.py#L269-L270
to
        elif is_callback(check_target):
-           self.loop.call_soon(target, *args)
+           self.loop.call_soon_threadsafe(target, *args)

I tracked down above code from alex_media_player (sync)
https://github.com/keatontaylor/alexa_media_player/blob/298a002d761a3b867dbdaa717a5c88f8ac67c869/alexa_media/__init__.py#L145-L147
=> configurator (async)
https://github.com/home-assistant/home-assistant/blob/5d5f073cffa1bcb93830300961eed66023a1898d/homeassistant/components/configurator/__init__.py#L220-L221
=> core (async_add_job)
https://github.com/home-assistant/home-assistant/blob/fe1840f9016c87288840f307620484e8683885cc/homeassistant/core.py#L269-L270
=> back to alexa_media_player (sync)
https://github.com/keatontaylor/alexa_media_player/blob/298a002d761a3b867dbdaa717a5c88f8ac67c869/alexa_media/__init__.py#L136-L139
I think there are too much thread switch, maybe we should make this call_soon more safer.
BTW, the author of alexa_media_player need to have some reading about async programming,

We shouldn't call threadsafe functions inside the event loop, as that can block things. We should be fine with calling call_soon. Calling call_soon also means that the thread switch is actually "done", and the event loop will call the function later on. However, the challenge is that call_soon doesn't return a task, so HA doesn't know it has to wait for it to finish in async_block_till_done.


[website] Revise homepage copy below the hero section

This PR revises all copy on the mui.com homepage below the Hero header—see #31212 for my Hero copy revisions.
The purpose is to bring more clarity to the brand and its products, implement the style guide and brand lexicon, and center our users and their needs throughout the copy.

For Hero section revisions, see #31212

Reviving this since we're getting closer to launching Base, and I think that would be a great time to refresh the marketing site!

What do you all think about this tagline for MUI Core?
"Foundational components for shipping features faster."
The structure runs parallel to MUI X's tagline—"Advanced components for complex use cases"—and I think it helps to quickly differentiate these two product lines at a glance.


Allow for module manifest adaptations

When using the command Export-CrescendoModule to generate an updated module, the module manifest (.psd1) file is also rewritten from scratch. This file often contains customizations and adaptations to the module that are outside of the scope for Crescendo: e.g. custom formats, default command prefixes. All such adaptations must then be re-inserted from scratch.
I can understand that Crescendo maintains "full ownership" of the .psm1 part of the module, but the manifest needs to be customizable at time of export, e.g. through parameters. Either that, or one should be given the option to keep it unchanged.

+1 to this issue.
My custom module manifests getting overwritten is the primary reason why my pipelines are pinned to Crescendo 0.4.1, because otherwise I'd have to rewrite them to back up and restore my custom module manifest every time the module is built.

@tbergstedt and @ethanbergstrom - Thank you for reporting this issue.  We are investigating the best implementation to handle this -  I will provide our thinking here as the investigation progresses.

@tbergstedt @ethanbergstrom
It looks like this is a incredibly tricky problem that I don't think I can address by inspecting and then rewriting the manifest (the variability in what a manifest can contain can't be created with New-ModuleManifest). However, it would certainly be possible to not create a manifest at all. How about a switch -NoUpdateManifest and the manifest will not be overwritten. This means that the burden would fall on the user to update versions, etc.
Behaviorally, if you use -Force -NoUpdateManifest I would rewrite the .psm but not the .psd1. If you use -Force only, I'll rewrite both. That makes this a non-breaking change as well :).
Any attempt to rewrite the manifest with string reading/writing is apt to be incredibly fragile and bug laden. It's the reason I went with New-ModuleManifest in the implementation (that and all the commentary it makes). If PS had an Update-ModuleManifest I might be able to use it, but it's a really tricky problem. I tried implementations in few ways;

an object approach read the manifest with Import-PowerShellDataFile, then package up new-modulemanifest arguments

dotsource the manifest, spelunk the object and package up arguments to new-modulemanifest

parse the file, spelunk the AST and package up arguments to new-modulemanifest
while I can read the data just fine, it boils down toNew-ModuleManifest doesn't provide for the allowed variability of a manifest contents.

No1 failed immediately because you can have branch logic for some elements so you can't even import the psd1 with import-powershellDataFile
No2 failed immediately because you're left with the result of the branch logic not the code of the branch
No3 was looking pretty good, but I couldn't convince new-modulemanifest to take my branch logic as an argument and you can still put stuff in a manifest which you can't express as an argument to new-modulemanifest.

and if you have a different suggestion for the parameter name, let me know.

I get the problem, and that sounds like a reasonable workaround. And I'm not that familiar with the Powershell grammar to think of any better parameter name. But since I don't know what the Export-CrescendoModule usually want to enter into the manifest file (apart from the obvious .psm1 reference, etc.), I think it would be helpful if that was described in the help text for the parameter. E.g. "When using this parameter, be sure to check that the following items still are correct in your manifest file: ..."
Does that sound doable?

I'm also good with a simple flag to not overwrite an existing manifest.
As far as naming the parameter, I don't have any strong opinions, but NoClobber is a standard PowerShell parameter.
However, that is intended for a cmdlet that only writes a single resource, whereas here we're not wanting to overwrite just a piece of that resource (the manifest of the module to export), so perhaps NoClobberManifest?

NoClobberManifest it is
as for the parameter help - I'm thinking a more pithy Do not overwrite the module manifest and we'll update the documentation to be more expansive.

Fair enough.

Thanks @JamesWTruher for the update.  I also vote for -noClobberManifest

fixed with #171

Thank you! Fixed/closed - in release: https://www.powershellgallery.com/packages/Microsoft.PowerShell.Crescendo/1.1.0-RC1


Models with skeleton bone maps and parent rotations are not imported correctly

Godot version
Latest master, 4.0.dev.cd0f1e9b102fe899d37921c1155df08966549363
System information
macOS 13.1
Issue description
Models with skeleton bone maps and parent rotations are not imported correctly. I thought this had something to do with the Apply Node Transforms option, but it's broken even without that enabled.
In the below screenshot, the middle one is the expected behavior (unrotated in model, then I rotated it in the scene), and the other two are nearly the same GLTF file but I added a Quaternion rotation of [0, 1, 0, 0] (180 deg around Y) to the root node (named "Armature_deform"). The one on the left side of the image has Apply Node Transforms enabled, and the one on the right side of the image has it disabled. Both have broken shoulders, arms, and feet.

Steps to reproduce

Download and open the reproduction project.
Open test_model_rot.tscn.
Observe the behavior in the above image.

Minimal reproduction project
b_chan.zip

This is not a bug. If you apply the T-poser Fix Silhouet, the asset must be oriented +Z to match the SkeletonProfile.

If the T-poser is not able to handle rotated transforms, then why doesn't it show an error message when it encounters rotation? There is absolutely an actionable improvement that can be made here.

It is because in glTF, the specification defines that the model is +Z forward facing.
You can ignore the specification, but it is your fault that it is undetectable. That is really indistinguishable from the case where there is a character with its face behind it.

@aaronfranke The import process is correct and the remapper assumes that the model is front facing because this is how artists work in the DCC in the vast majority of cases (This is not really related to glTF, that is just the convention there, but even for other formats Godot just converts the coordinate system so it matches the DCC). To properly handle models looking in other orientations, an option will have to added at some point, but this is beyond the scope of 4.0 at this point and we can discuss it later.
I would also refrain from doing further pull requests and opening issues on this topic. If in doubt, feel free to discuss this topic with me on the chat instead.


When is v2.0.0-pre.2 version going to be released?

We are facing an issue in v1.0.2 while deleting an attribute but it was recently fixed in the latest version v2.0.0-pre.2. We need that fix on priority. Can we expect a release soon?

See #551.

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


Create android.yml

Thanks for the PR. Can you please add the step to run unit test and lint check ?


Null Pointer exception when names don't match up

If the mocks variable name doesn't match the bean name, it can't find the bean to mock, and it falls over with a NPE. I can get round it by making the names match, but seems a bit inflexible.
for example:
@AutowiredSpy ProjectionService spy
java.lang.NullPointerException
	at org.spockframework.mock.MockUtil.asMock(MockUtil.java:54)
	at org.spockframework.mock.MockUtil.attachMock(MockUtil.java:68)
	at com.pchudzik.springmock.spock.spring.MockAttachingTestExecutionListener.beforeTestMethod(MockAttachingTestExecutionListener.java:59)

should work better in latest snapshot. 1.1.1-SNAPSHOT.
Will release it soon.

It is released as 1.1.2
http://search.maven.org/#artifactdetails|com.pchudzik.springmock|springmock-spock|1.1.2|
http://search.maven.org/#artifactdetails|com.pchudzik.springmock|springmock-mockito|1.1.2|


Set a larger github.com/fuse resource volume

to resolve #5169

Coverage remained the same at 33.999% when pulling 4050dc4108c45d2db8a999fb5a3c4ad49a55c1d2 on zhiyuhe/fix_fuse into 1a641c0272e827f0e8c34e5d0decc4151e3009eb on master.


Update GazeInteractionLibrary.md

Fixed namespace from UWP to Uwp

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/gaze/GazeInteractionLibrary.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


How to use ANTs utilities in a C++ project?

I tried to use the adaptive none local mean denoise filter (itkAdaptiveNonLocalMeansDenoisingImageFilter.h in Utilities folder) in ANTs in my C++ project. Attached is the source code (main.cpp), Cmakefile of my project. I got some errors (Error_Message.doc) when I build the project. It seems like I would need to include some other dependancies in ANTs. Could you let me know how to configure the cmakefile in order to make it work?
Thank you in advance for the help!
attached.zip

Although I could be wrong, I don't think you're setting up the cmake file correctly.  Can you test if the same error occurs if you try to include another class instead of the itkAdaptiveNonLocalMeansDenoisingImageFilter.h?

I tried itkVarianceImageFilter.h before and got no error. Could you give me some suggestions about how to configure the cmake file? Thanks!

Yeah, the variance image filter has minimal ITK dependencies compared with the denoising filter so I'm not surprised.  I'm actually getting ready to leave to meet Brian right now but will look more at your question probably tomorrow or Wednesday, if you haven't figured it out by then.

Just take your time. Thank you for helping me with this!

Okay, the problem is your inclusion of the ITK/VTK glue component in your CMakeLists.txt file.  Once I took that out, your program compiled without a problem.  If you need to include that for your project, I would recommend seeking help from the ITK list as I don't have much experience with that.

ITK recently fixed a problem with using ITK/VTK glue and then subsequently needing VTK in your own project.  There was an error where the find_package(VTK .....) inside ITK was clobbering previous calls to find_package(VTK) for private packages.

It works now! Thanks!


desktop dev server is broken

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: dev
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701876472900869
Action Performed:
npm run desktop
Expected Result:
No error
Actual Result:
what Server is broken
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

This is somehow caused by https://github.com/Expensify/App/pull/30927, although I'm not sure why 🤔


cargo: update dependencies

Signed-off-by: Vincent Batts<EMAIL_ADDRESS>

should rebase once #5 is merged.

See https://github.com/kinvolk/afterburn/pull/12#discussion_r589787816, we first need to test the coreos-overlay ebuild file and also bump the commit once changes are merged here.

rebased to use the rust action

Thanks, inhttps://github.com/flatcar/update-ssh-keys/pull/7 I've also ran cargo update (the same was also done on master by CoreOS folks since we branched) and tested building and running.


improve local development experience

add api test file for use with REST Client extension
Ignore local appsettings file to prevent accidentally commiting
credentials

To make sure that my understanding is correct:

New Dev will create the appsettings.Development.json
Use appsettings.sample.json as an example to populate appsettings.Development.json
Set ASPNETCORE_ENVIRONMENT=Development

Yup, didn't want to modify README and duplicate your work so will let you made the addition :)
ps: would be great to also explicitly mentioned that they will have to edit the cosmos connection string & auth key, plus instruction on where to retrieve that information

@michaeldeongreen
Yup, didn't want to modify README and duplicate your work so will let you made the addition :)
ps: would be great to also explicitly mentioned that they will have to edit the cosmos connection string & auth key, plus instruction on where to retrieve that information

Yep, already have that in the README.  Will add what I wrote as well, just wanted to make sure I understood.

I think we should not delete appsettings.json file otherwise LGTM.
One thing to check before you merge this PR. Deploy this app to App Service and see if it works without the appsettings.json file. We are using DatabaseName & Container name from appsettings.json. Otherwise I can set these attributes as part of the deployment.

@Humoiz it's not deleted, just rename so user are aware it's the base setting

I think we should not delete appsettings.json file otherwise LGTM.
One thing to check before you merge this PR. Deploy this app to App Service and see if it works without the appsettings.json file. We are using DatabaseName & Container name from appsettings.json. Otherwise I can set these attributes as part of the deployment.

That seems strange to me that we're only using the DatabaseName & ContainerName from appsettings.json but not the cosmosDB connection string

I think we should not delete appsettings.json file otherwise LGTM.
One thing to check before you merge this PR. Deploy this app to App Service and see if it works without the appsettings.json file. We are using DatabaseName & Container name from appsettings.json. Otherwise I can set these attributes as part of the deployment.

That seems strange to me that we're only using the DatabaseName & ContainerName from appsettings.json but not the cosmosDB connection string

I dont want to hardcode the connection string into appsettings.json. Anyway at this point I have setup connection string, database name & container name as part of the CD pipeline so no dependency here for production.

I think we should not delete appsettings.json file otherwise LGTM.
One thing to check before you merge this PR. Deploy this app to App Service and see if it works without the appsettings.json file. We are using DatabaseName & Container name from appsettings.json. Otherwise I can set these attributes as part of the deployment.

That seems strange to me that we're only using the DatabaseName & ContainerName from appsettings.json but not the cosmosDB connection string

I dont want to hardcode the connection string into appsettings.json. Anyway at this point I have setup connection string, database name & container name as part of the CD pipeline so no dependency here for production.

base on this guide, appsettings.json shouldn't be check in at all, which I agree with.

/az

/azp help


fix: resource:day click

The event handler for @click:resource:day is currently triggered when the day is clicked. The resource sent with the event is always the first resource in the list.
This PR moves the click event to __renderDayResource instead of _renderDay.

@stefanvanherwijnen Sorry, I missed this PR before re-organizing QCalendar for the new UI kit. Can you adjust your PR so there are no conflicts so I can merge it in. And, thanks for finding this issue. :heart:

@stefanvanherwijnen Actually, looks like you did the PR after the re-org, but the "component" folder was renamed to "components" - should be an easy fix.

I just manually merged this in. Thanks for helping out and finding issues. :heart:

will be released in v1.0.10

I botched it up, so will be fixed in v1.0.11


Improved lazy loading of prettier by only requiring it when it's first used

This PR ensures that prettier is now only loaded when it's actually used for formatting for the first time. It turns prettier.format into an async call, which the first time it's called loads prettier via CDN (with a 15 second timeout).
Since it's loaded via CDN, subsequent requests to the page are done to the disk cache.
If you like this, we could also do this with Elk.

If you like this, we could also do this with Elk.

Yes please!

Is this good to go in?


Stateful process_results

Hi, I'd like to use an external model for calculating some metrics, and I'm currently doing process_results: !function utils.my_model; is there a nice way to load the model only once, and free the memory afterwards? Should I be creating a Task class instead?

Hi! As currently set up, you could load the model once when task/folder/utils.py is first run, and then use the process_results() function referencing that single model, I'm pretty sure.
a Task class would definitely work, or to add a method like TaskSubclass.setup() and TaskSubclass.cleanup() that run before and after the process results calls.
If this is a common use case, we could support something like the above for if people are going to want to do e.g. inference using a reward model. Thoughts?

What about a process_all_results that takes a list of instances and labels instead? Then one can do the reward model allocation and cleanup within that!
This sounds good to me and I think makes sense, can put this on the roadmap--would this mean you can still use a YAML for your purposes?

would this mean you can still use a YAML for your purposes?

Yup, ideally, one could use the same syntax of process_results, with the difference that the provided function will be able to process a list of instances and results instead.
BTW I was digging a bit into the logic of lm-eval-harness, in case I could do a quick pull request for this, and it seems non-trivial to do -- will do a task class instead 🙂


[ci skip] adding user @jonashaag

Hi! This is the friendly automated conda-forge-webservice.
I've added user @jonashaag as instructed in #36.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #36

Why does it not skip CI even with [ci skip]?

@jonashaag it skips on merge


Use constructor to set properties in swagger

I am building an API and using swagger to test the endpoints. I have a ProductDTO:
public string ProductName { get; set; }
.
.
.
public Price Price { get; set; }
in this DTO I want to use Price class which is used throughout my code. Price class looks like this:
public class Price
{
public Price(decimal amount, string currency)
{
Amount = amount;
Currency = currency;
}
public decimal Amount { get; private set; }
public string Currency { get; private set; }

}
But since private setters are used in Price class I cannot set these values using swagger (it has readonly attribute on those). I really like this approach of having private setters and setting values with constructor, which by the way is public. Is there any way I could set values for Price class using swagger and still use private setters on properties?
This case is working in 4.0.1 version but not in the last version

Which serializer are you using - Newtonsoft or System.Text.Json? I'm asking because the latter currently only supports publicly settable properties on deserialization. So, given your question, I'm assuming you're using Newtonsoft?
That being the case, then I think this issue is really a dup of #849, which I'm going to prioritize resolving next. If it's OK with you I'm going to close this issue and continue tracking with the original. If you feel this si trully different just let me know and we'll try an iron out the distinction.

i am not using serializer
i wan to share example codes
this code is working 4.0.1 of version it do no need any serializer  so why does not work in the last version
[DataContract]
public class AddOfferWithQuotationsCommand : IRequest<int>
{
    public AddOfferWithQuotationsCommand(List<QuotationItemViewModel> quotations, int tenantId, string tenantName, int customerId, string customerName,
                                         int offerTypeId, DateTime estimatedStartDateTime, DateTime validityDateTime) : this()
    {
        this._quotations = quotations.Select(x => x.Map<QuotationItemDto>()).ToList();
        this.TenantId = tenantId;
        this.TenantName = tenantName;
        this.CustomerId = customerId;
        this.CustomerName = customerName;
        this.OfferTypeId = offerTypeId;
        this.EstimatedStartDateTime = estimatedStartDateTime;
        this.ValidityDateTime = validityDateTime;
    }

    public AddOfferWithQuotationsCommand()
    {
        this._quotations = new List<QuotationItemDto>();
    }

    [DataMember]
    public int TenantId { get; private set; }

    [DataMember]
    public string TenantName { get; private set; }

    [DataMember]
    public int CustomerId { get; private set; }

    [DataMember]
    public string CustomerName { get; private set; }

    [DataMember]
    public int OfferTypeId { get; private set; }

    [DataMember]
    public DateTime EstimatedStartDateTime { get; private set; }

    [DataMember]
    public DateTime ValidityDateTime { get; private set; }

    [DataMember]
    private readonly List<QuotationItemDto> _quotations;

    public IReadOnlyCollection<QuotationItemDto> Quotations => _quotations;
}

The "Serializer" is the component in ASP.NET Core that takes the submitted JSON payload and uses it to populate an instance of  AddOfferWithQuotationsCommand. It's a critical part of any API built on ASP.NET Core and it's also a key dependency for Swahbuckle as it needs to honor serializer behavior to create an accurate description of JSON payloads (both in and out of your API).
Prior to ASP.NET Core 3.x, Newtonsoft was the default/built-in serializer. From 3.x onwards though, they've switched to a new native serializer System.Text.Json (STJ). However, 3.x applications can still switch back to Newtonsoft if they wish. You should know which serializer your application is configured to use.

This is still not properly working, even after adding the nuget package from the link you provided.
For example:
You have a class
    public class TestValidationRequest
    {
        [JsonConstructor]
        public TestValidationRequest(string phoneNumber, string email)
        {
            PhoneNumber = new PhoneNumber(phoneNumber);
            Email = new EmailAddress(email);
        }
        public PhoneNumber PhoneNumber { get; }
        public EmailAddress Email { get; }
    }

It still shows the api endpoints as requiring these complex objects vs  what is defined via the jsonconstructor attribute.


Support custom newline symbol(s) for format option

WHY
The feature is required to support proper multi-line logging of JSON content is lambda functions.
See stack overflow discussion
https://stackoverflow.com/questions/47446002/how-does-multi-line-logging-work-in-lambda-cloudwatch
AWS CloudWatch renders multi-line JSON (property) if \n is replaced with \r.
Since, the library supports already format(ing) and pretty printing, then  a new option to customise newline symbol fits nicely there
WHAT

new option newline to format function is added.

ping!

Sorry about the delay. I think this is fine. I'll merge today after I give it another thorough review. Thanks!


TopAppBar does not collapse with WebView

Describe the bug
The Accompanist Webview "content" does scroll with the TopAppBar but the TopAppBar does not collapse on scroll. TopAppBar does collapse with other views, for example - https://developer.android.com/reference/kotlin/androidx/compose/material3/package-summary.
Repo
https://github.com/jaredsburrows/android-gif-example
Code
https://github.com/jaredsburrows/android-gif-example/blob/32d96e6d5b1575141c7b4ae57ec2a7c199303c33/app/src/main/java/com/burrowsapps/example/gif/ui/license/LicenseActivity.kt#L110
@Composable
fun DefaultPreview() {
  val navController = rememberNavController()
  val scrollBehavior = TopAppBarDefaults.enterAlwaysScrollBehavior(rememberTopAppBarScrollState())

  Scaffold(
    modifier = Modifier.nestedScroll(scrollBehavior.nestedScrollConnection),
    topBar = { TheToolbar(navController = navController, scrollBehavior = scrollBehavior) },
    content = { paddingValues ->

      val context = LocalContext.current
      val state =
        rememberWebViewState("https://appassets.androidplatform.net/assets/open_source_licenses.html")

      com.google.accompanist.web.WebView(
        state,
        modifier = Modifier.padding(innerPadding).nestedScroll(scrollBehavior.nestedScrollConnection),
        onCreated = { webView ->
        },
        client =  { }
      )

    }
  )
}

If I use a different view other than WebView, it will scroll like the example in the documentation.

Wrapping this in a Box with Modifier.verticalScroll(rememberScrollState()) gives the desired collapsing TopAppBar. But now prevents "clicks" in the WebView.
@Composable
fun DefaultPreview() {
  val navController = rememberNavController()
  val scrollBehavior = TopAppBarDefaults.enterAlwaysScrollBehavior(rememberTopAppBarScrollState())

  Scaffold(
    modifier = Modifier.nestedScroll(scrollBehavior.nestedScrollConnection),
    topBar = { TheToolbar(navController = navController, scrollBehavior = scrollBehavior) },
    content = { paddingValues ->

      val context = LocalContext.current
      val state =
        rememberWebViewState("https://appassets.androidplatform.net/assets/open_source_licenses.html")

      Box(modifier = Modifier.verticalScroll(rememberScrollState())) {
        com.google.accompanist.web.WebView(
          state,
          modifier = Modifier.padding(innerPadding).nestedScroll(scrollBehavior.nestedScrollConnection),
          onCreated = { webView ->
          },
          client =  { }
        )
      }

    }
  )
}

Nothing unfortunately, my attempted fix caused other issues. We haven't made any progress on this yet, it remains an open issue. If you do work anything out, please feel free to submit a PR.

@bentrengrove I just added a rememberScrollState and added it after the modifier clipToBounds in your implementation. and it works perfectly. However, don't know if it will create any further issues.

I actually have this working in my repo now: https://github.com/jaredsburrows/android-gif-example/blob/b2b4bcf0c240cdd463930b399089eca0700da489/app/src/main/java/com/burrowsapps/example/gif/ui/license/LicenseScreen.kt#L128.


Adding ObjectOwnership properties to S3 Buckets

Description of changes:
Added ObjectOwnership properties to S3 Buckets to ensure that we can deploy to the regions that were affected by the most recent S3 change.
This PR also includes changes were necessary in order to get this package through our pipeline. This included adding new packages, upgrading our buildspec to python 3.10, and specifying package versions to get around vulnerabilities.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We need to update the changelog and we also need to update the version number in the README.


upgrade Gadgetron and ISMRMD versions

Updates for new VM based on Ubuntu 18.04 LTS.

addresses #149

this looks fine to me, but I see failures on Travis... @paskino, can you have a look? We probably will have to update .travis.yml to use appropriate compilers.
Can you also add a lines to the CHANGES.md?

will need changes to Travis, similar to #157  (but there it's currently only for DEVEL_BUILD=On)

Are these versions ok?

@casperdcl, we're getting close to finish this. Relevant changes include using at least g++-6 and add an extra blas package. I presume this would have to be done in the docker stuff as well, but

I wouldn't know where the compiler is set
somehow the devel build is still compiling anyway, which is weird.
Possibly the docker build uses Ubuntu 18.04 already?

GCC on Ubuntu 18.04 LTS is gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0

I think this PR can probably closed as it was superceded by #205.

yes. looks that way. you could try and merge master on here and see how it looks like.

I've checked. This PR is obsolete since merging #205. I've put in the last few things in aac6edb59863b5a6140ec33e2e1992e6c37bb218.