Fix calling default constructor to use uniform initialization.

Hello,
I faced an error that let C be a template parameter, C() is interpreted as a function call when C is a type alias.
So, I replaced all ambiguous expression C() to uniform initialization C{}.
Could you please merge this PR?

This looks fine, thanks. For completeness, could you add a test somewhere (src/ImathTest/testVec.cpp maybe?) that fails with the current () initializers but succeeds with the change?

We discussed this in today's technical steering committee meeting, and we support this contribution in principle and we'd like to work towards accepting it.
We'd like to confirm what versions of CUDA this relies on, and confirm that the #ifdef's properly exclude ones it doesn't.
We'd also like to add a CUDA validation job to the CI.
We are planning a v3.2 release in mid-August, which will be cut from the main branch, so we'd like to wait until after that before merging the PR. That will provide more time for evaluation before official release.
In spite of my earlier advice to add a test, your original submission to switch to uniform initialization is fairly uncontroversial, so if you'd like to submit that as a separate PR, we can accept that right away, while we work through the issues with the addition of the CUDA test.
Again, thanks for your contribution and your patience.


[FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle  and sqlserver.

[hotfix] fix the problems with special table name characters of postgres and oracle  and sqlserver.

add the commit to update test case

I guess we can extract information about current quote identifier directly from JDBCDriver
java.sql.DatabaseMetaData#getIdentifierQuoteString
and then we don't need to hardcode it for every dialect

I guess we can extract information about current quote identifier directly from JDBCDriver java.sql.DatabaseMetaData#getIdentifierQuoteString and then we don't need to hardcode it for every dialect

In this case, special characters of various data sources need to be preset, and the workload is relatively large

I guess we can extract information about current quote identifier directly from JDBCDriver java.sql.DatabaseMetaData#getIdentifierQuoteString and then we don't need to hardcode it for every dialect

I get it. If there are no compatibility issues, It's better this way.

I guess we can extract information about current quote identifier directly from JDBCDriver java.sql.DatabaseMetaData#getIdentifierQuoteString and then we don't need to hardcode it for every dialect

I get it. If there are no compatibility issues, It's better this way.
I just had a look at it and found that the interface was in the test package

quote identifier

I thought the method Java.SQL.DatabaseMetaData#getIdentifierQuoteString to dynamically access quote identifier, the price is too big, need to introduce Connection object which is very heavy, It is not reasonable for the existing dialect class design.

yep, may be it is a point to see whether we could adapt it or not
btw I haven't found any test reproducing the issue, can you add one?
Also I would say the issue is more complex than just adding sql quote identifiers
e.g. even though there are quotes queries with fields containing question marks ? will fail FLINK-34211
i guess we need to a have a number of dedicated tests for that


Add dapr label to injected sidecar pod

Description
Add dapr injected label dapr.io/sidecar-injected when patching pod in MutatingWebHook.  This will help to filter pods injected with sidecar by the webhook, and this way it can be used in the operator to list pods filtering out those with the label present and thus reducing the memory issue mentioned in ticket below.
Issue reference
This will not close but is one step to fix #5693
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Perfect. However there are some issues with the CI. Can you please take a look at the test failures?
Looks like you may need to run "make modtidy-all"


As a user, I have access to an episode's transcript, so that I can be more engaged with the episode

User Story: Displaying Real-time Transcript on Episode Player Page
Acceptance Criteria:

[ ] Add a visible "Transcript" button on the episode player page.
[ ] Clicking the button shows the full transcript with current audio line synchronization.
[ ] Ensure the transcript is readable and well-formatted.

Demo Steps:

Open the episode player page.
Verify the presence of the "Transcript" button.
Click the button to confirm the transcript display with real-time audio line synchronization.

Potential Risks:

[ ] Transcript availability may vary for different episodes.
[ ] Possible display issues with specific browsers.
[ ] Synchronization of audio line with the transcript may have slight latency.

BACKEND:

to close this issue , this should be done :

[ ] backend setup a functional . issue #183
[ ] crud api calls are set up issue. issue #183
[ ] component created in the frontend for the transcript to be viewed.


Split Razor Components topic

Fixes #16904
Internal Review (links to the Components topic; navigate the remaining from the sidebar TOC)

Seems to have split rather cleanly. I was able to turn the Components BOOK! into a much shorter, focused topic with split out topics for ...

Data binding
Event handling
Templated components
Integrate components (into RP/MVC apps)
Globalization and localization
Advanced scenarios (Just one right now, Manual RenderTreeBuilder logic. We can add more as needed going forward.)

Examine the ordering in the toc.yml file at the end of the diff to see if this sequence makes sense reading these top-to-bottom, as many devs consume node topics in that sequence.
The new Integrate components topic is especially good here given that it combines app-level concerns that were covered in the Hosting model config topic with the component-level concerns from the Components topic.

Build issue of some sort ... rebuilding with an open-close of the PR.


Review

Review schematic and PCB

You can find the PCB parts list here
The schematic is here

You seem to be missing reverse polarity protection as in #10

consider adding another ws2812b led such that one indicated i2c communication to telemetry and another to flight control and possibly lora

consider increasing the resistor values for the power and status led to ease on the heat produced by the led being too bright as was seen here @Mike-Kimani  can confirm this

What is status 1 led used to indicate? If it multifunctional, consider an RGB led as it allows for many more possible indication options

Is the flash memory circuit missing or will it be included in the pcb

You seem to be missing reverse polarity protection as in #10

Done by https://github.com/nakujaproject/N2-onboardTelemetryComputer/commit/6289f43dfff52caed5843c49452a45dad5a00bb6

consider adding another ws2812b led such that one indicated i2c communication to telemetry and another to flight control and possibly lora

Done by https://github.com/nakujaproject/N2-onboardTelemetryComputer/commit/6289f43dfff52caed5843c49452a45dad5a00bb6

consider increasing the resistor values for the power and status led to ease on the heat produced by the led being too bright as was seen here @Mike-Kimani can confirm this

Done by https://github.com/nakujaproject/N2-onboardTelemetryComputer/commit/6289f43dfff52caed5843c49452a45dad5a00bb6

consider increasing the resistor values for the power and status led to ease on the heat produced by the led being too bright as was seen here @Mike-Kimani can confirm this

It isn't public 😂

What is status 1 led used to indicate? If it multifunctional, consider an RGB led as it allows for many more possible indication options

I have both RGB and white LED

Is the flash memory circuit missing or will it be included in the pcb

Implemented by https://github.com/nakujaproject/N2-onboardTelemetryComputer/commit/6289f43dfff52caed5843c49452a45dad5a00bb6


Change the config.js to tailwind.js tht is recommended in step 3.

In step 2 of installation you say:

We recommend creating a tailwind.js file in your project's root.

Then in Step 4:
./node_modules/.bin/tailwind build styles.css [-c ./config.js] [-o ./output.css]

Why config.js and not tailwind.js that you recommended earlier? This PR I just tried to unify the docs. 😄

Hey there Eric! So, the reason it's different here is because when you use tailwind build it will name the config file tailwind.js by default. The -c option allows you to change this to something else. This is why we had something different here, to illustrate that you can use a non-default value. But maybe that's confusing and it still makes sense to show the default value?

Actually without the -c option it uses no config file, so it probably makes sense to be consistent with the name. The reason for using config there though was to make it clear that the argument is your config file, but maybe that’s still clear even without the word config there?

Right! I'm getting confused with init. I think originally we actually had your-tailwind-config.js here, but I shortened it to make it fit in the docs without scrolling:

I'd still like to keep it from scrolling, but also agree that using tailwind.js is better. I'll merge this in.


Carthage support

It would be great if we could use this with carthage: https://github.com/Carthage/Carthage

Blocked because of an issue with command line compiling:
Bitcast requires types of same width
  %15 = bitcast i128 %0 to %Sq.19, !dbg !2804
Stored value type does not match pointer operand type!
  store %Sq.19 %15, i128* %23, align 8, !dbg !2807
 i128LLVM ERROR: Broken function found, compilation aborted!

Carthage support added since v2.2.2.


Feature Request: change menu bar opacity

Are there plans/Does it make sense to add support for changing menubar opacity to AeroSpace? yabai has recenly added it and it's useful

AeroSpace is focused on practical features. The project only care about workflows. "look and feel" is out of scope of the project. Please see the values in the readme.
I want to neither implement nor support appearance features


Clarify in docs that admin is separate module

The java client page gives instructions for pulling in the pulsar
client, but not for pulling in the admin client. Given this, a user
will assume that the admin client is part of the same module.
This change adds the maven artifact to the table so that it is clear
that it is separate.

@piotrblasiak I was actually thinking we could remove the maven/gradle snippets completely. If you click on the artifact maven central will give you the snippet.

@ivankelly that´s also a good solution.

@lucperkins @merlimat ?

@lucperkins @merlimat what do you think of removing the maven/gradle examples completely, since they're already in maven central?

@ivankelly I'd leave the maven snippet (Don't care much about gradle since I don't use it :) ), since it's visually easy to figure out. Though, I'd prefer the version directly in the <dependency> tags instead of the variable indirection, just to make it easier to copy/paste.


add the base map from google maps

Dear all
I think of if you could add a command that download the basemap using google maps, srtm etc directly from internet.
Best regards

Hi @rezamn, thanks for the feedback! The google maps data is tricky because it's not open-source. So we can't use it. But there are plans to use coastline data from open street map in GMT. That will take some time because it would require some big changes in GMT.
The SRTM data is something that already works in GMT6. I haven't ported that to Python yet but it will be coming soon.


[Feature Request] Integrate with Sketchpacks Relay to serve auto-updates

More details found @ https://github.com/integration/sketchpacks-relay
Example

It looks like this plugin is already present in Sketchpacks. Is there additional integration required?


Problems under pyftsubset

Problems with special symbols in VERTICAL
parameters used
pyftsubset "\DS3617\方正准圆_GBK.TTF" --text="「」" --output-file="\DS3617\CO8FABC0.TTF" --font-number="0" --layout-features='*'
normal

pyftsubset

'
What parameters do I need to enter to be the same as the original?
方正准圆_GBK.zip

There is a paragraph in GSUB

pyftsubset
Because should keep uni300C uniFE41
There are also relevant information on the GSUB table

This works for me.


Custom font color does not save ?

Font -> Custom Font
The dialog isn't clear how the font setting is changed/saved.

how do I change the color, or is it broken ?
Thanks,

Changing the color isn't supported here. Hex Fiend will use default OS colors.
Can you go into more details on what you're trying to do?

Changing the color isn't supported here. Hex Fiend will use default OS colors.
Can you go into more details on what you're trying to do?

I'm trying to change the font color of the data in the hex view
If it isn't supported, why does it show a font dialog with a color picker ?

It shows the system's font panel and it appears that's the default view.
However it appears there may be a way to customize this via https://developer.apple.com/documentation/appkit/nsfontchanging/3005181-validmodesforfontpanel?language=objc - I'll need to do some experimenting.

I figured out a way to make the font panel only allow customizing the font face, to reduce confusion.
Currently HF only allows customizing the background color of a selection via "highlighting". You can access this from the context menu


Case insensitive commands

Just because sometimes on the phone, you type Log me rather than log me..

Thanks!


Apple M1 chip (macOS.arm64) support

Would you mind add support for macOS with M1 chips? The macOS.x64 doesn't seems not work on M1
➜  rnp ./rnp
[1]    37091 killed     ./rnp

yea, would be great to get this flavor added, the biggest problem right now is that... i don't have any apple machines with m1 chip and azure pipeline has no macos.arm64 support as well.... so could not make a build for it.

Thanks! It's okay, I can build it locally :)

Let’s see if this can solve this problem or not. But it will take time.
https://github.com/r12f/rnp/pull/70

emmmm.... i think my project needs more stars...
2021-08-01T04:27:26.8366810Z Running: brew audit --new-formula rnp
2021-08-01T04:27:35.4682600Z Error: 4 problems in 1 formula detected
2021-08-01T04:27:35.4781210Z rnp:
2021-08-01T04:27:35.4783570Z   * 1: col 1: Carriage return character detected.
2021-08-01T04:27:35.4786750Z   * 2: col 9: Description shouldn't start with an article.
2021-08-01T04:27:35.4788000Z   * 2: col 45: Description shouldn't end with a full stop.
2021-08-01T04:27:35.4789170Z   * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
2021-08-01T04:27:35.4789700Z Failed running brew audit! Exit.

will get there over time : )

Already tried my best. Hope so. 😊


Add API v1

Based on #20
Closes #21
Builds API data and deploys to static file hoster

Personally I'd keep leave them untested for now. At the end this is very simple copy/pasting of data and creating tests for that would be a lot of overhead.


Don't track changes of non persistent entities for autosave

While it is a performance optimization that isn't based on any profiling I think it is reasonable to do it: This change basically halves the memory usage for non persistent entities.
See comments of commits for further details.

@immortius you got a few minutes for this one? :-)

Bump - any further discussion needed here or are the raised issues more philosophical in nature than indicating a need more more changes? :-)

The guard statements are philosophical and don't need changing.
I am really loathe to merge the private deprecated method though.

It is a bit early to really worry about deprecated anyway. If any module is using the code we remove then me running the PR through my mega-workspace will reveal anything broken, and I can fix.The few modules I don't cover are either already broken or not done :-)

That isn't the problem. If it was a deprecated public method, sure. But the method is been switched to private, so any code using it would already break. The only methods that could possibly be using it to trigger the deprecated warning are in from same class, and there are none.
I do understand what @flo is trying to do - by leaving the set method there, and developer in the future that tries to add the set method should discover it and see that it shouldn't exist. At the very least the method doesn't need to be tagged deprecated to serve this purpose though. More generally I simply do not believe in maintaining dead code in a code base, and feel that the case of a developer trying to add the setPersistence method without looking at any of the surrounding documentation on the behavior of the persistence attribute is remote enough it isn't worth the cost of the method. It would be much better to make it so the persistence flag cannot be changed after creation at a lower level.

Okies, thanks for the explanation :-)

I did the requested changes, and rebased the patches, not sure if it's my patches or not but the character didn't get stored in my tests.

Thanks :-)
What do you mean with the character note? A unit test meant to save the player character is reporting a problem?

No a manual test, I started a game moved a round with charcter quit/saved and started/loaded the game again. The character was at original position and had all items again.

Oh, interesting. I'll be sure to do a before-after test tonight when I get home :-)
Is that in plain single player?

yes, I tested that singleplayer only

Okay, managed to test, and yep, I get the same behavior :-(
World seems to save fine, but the player reverts. Somehow it seems the player doesn't count as persisted? An entity dump shows "persisted": false, on the only player entity I can spot with that attribute both before and after the change. Maybe for some reason before it was persisting anyway?

Oh, also, I found a hit on setPersistent being used in BlockPicker's BlockPickerScreen. Some thoughts on how to change that would be appreciated :-)

@Cervator The players were indeed not persistent and thus did not get saved anymore.
The BlockPicker module should not have any issues anymore, maybe you forgot to pull rhe latest version?
Can you retest again please?
@immortius You may want to have a look at the latest patch (and it's commit message):
https://github.com/flo/Terasology/commit/b01e9602bd07002d1c06eecd5d834dc3393ed2d
I hope that's okay.

Excellent, thanks, will retest tonight :-)

Thank you both - merged at last :-)


Update Get-CsOnlineUser.md

Updating some of the docs from the Skype for Business cmdlets which have been modernized for Microsoft Teams. This will be the first PR of multiple recently modernized cmdlets (40 in total).

Docs Build status updates of commit 9f83081:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7db7f2a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hey @pupara - here's a first pass at the Get-CsOnlineUser updates we discussed. Mostly removing those deprecated parameters, and adding "Microsoft Teams" where relevant - let me know your thoughts. Preview page here.

These parameters are still available in version 2.5.1. It might be a good idea to leave it with the description they have now.

Good catch, are these going to be removed soon @alexdale0 ?

These parameters are still available in version 2.5.1. It might be a good idea to leave it with the description they have now.

Good catch, are these going to be removed soon @alexdale0 ?

Yes, they will be deprecated soon https://skype.visualstudio.com/DefaultCollection/SBS/_workitems/edit/2496244 - CC @pupara

Thank you for sharing this update.
Is there any communication forthcoming on why some parameters (we think) are essential for Direct Routing are on the list of deprecated parameters? - Collected a few here: https://github.com/MicrosoftDocs/office-docs-powershell/issues/8261
Thanks,
David

@alexdale0 we usually include all the parameters that appear in the code because we often receive issues asking about these parameters. We add something like "This parameter is reserved for internal Microsoft use." as a description so that the reader knows that they are available in the code but that you cannot use it.

@tseward

Thanks @dariomws . Decided to leave in those params for now and just add a note that they will be deprecated in the near future.

Docs Build status updates of commit a537c3f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tiburd Please merge this PR. Thanks

Docs Build status updates of commit d067ff1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


v1.4.4 release checklist

Release Checklist
Backlog Status

[ ] Manual Tests

[ ] EKS - BottleRocket
[ ] EKS - Gravitron (ARM64)
[ ] EKS - Amazon Linux 2
[ ] GKE COS (AppArmor)
[ ] GKE COS (BPF-LSM)
[ ] RHEL (certain BPF_LSM primitives are not available on RHEL)
[ ] minikube - VM Based
[ ] AKS Cluster - Ubuntu
[ ] AKS Cluster - Azure Linux - No AppArmor packages
[ ] VM support - test kubearmor packages without k8s on RHEL and Debian based systems
[ ] VM Support - Docker Compose
[ ] KubeArmor Performance Benchmarking Data for BPF-LSM
[ ] Seccomp implementation in all cluster envs mentioned above

[ ] MarketPlace Image updates

[ ] AWS/EKS Marketplace
[ ] RedHat Catalog
[ ] MicroK8s Plugin
[ ] Digital Ocean 1ClickApp

[ ] Release Blog
[ ] Mark as stable release
[ ] Update to getting-started guide for helm
[ ] Does it require a manual update to Operator bundle? (No change required)
[ ] Check helm charts has been released

Note: Release checklist is needed since testing of certain platforms is not automated in CI env due to non-technical (primarily cost) concerns.

@Prateeknandle EKS - Amazon Linux 2


Make it easier to attach a native script to an object after the fact

Currently, the script constructor naively calls the script type constructor directly. Since the NativeScript constructor cannot take arguments, this behavior has led to the internal type "pattern" that we might want to integrate into the library somehow:
#[derive(NativeClass, Default)]
#[inherit(Reference)]
pub struct Foo {
    internal: Option<Bar>,
}

struct Bar {
    actually: Interesting<Thing>,
}

impl Foo {
    fn new(_owner: Reference) -> Self {
        Foo::default()
    }

    /// Verbose, non-obivous way to construct instances from an internal value.
    pub fn with_thing(actually: Interesting<Thing>) -> Instance<Foo, Unique> {
        let instance = Instance::new();
        instance.map_mut(|foo, _| foo.internal = Some(Bar { actually }));
        instance
    }
}

...instead of the former, we might want to be able to write something like:
#[derive(NativeClass)]
#[inherit(Reference)]
pub struct Foo {
    actually: Interesting<Thing>,
}

impl Foo {
    fn new(_owner: Reference) -> Self {
        panic!("do not create from GDScript!")
    }

    pub fn with_thing(actually: Interesting<Thing>) -> Instance<Foo, Unique> {
        Instance::emplace(Foo { actually })
    }

    /// Just a method to show the desired API
    pub fn attach_with_thing<Access: ThreadAccess>(
        owner: TRef<Reference, Access>, actually: Interesting<Thing>,
    ) -> Instance<Foo, Access> {
        Instance::attach(owner, Foo { actually })
    }
}

Implementing something like Instance::emplace would also allow us to add a blanket OwnedToVariant impl for all NativeClass (technically a breaking change, but users aren't supposed to implement variant conversion for script structs anyway?).
Implementation
There are several ways that I can think of, but all have some form of drawback:

Make the user-data wrappers contain Option<T> instead of T, and transparently call the default constructor lazily when first mapped over, if a value isn't emplaced. This would lead to surprising behavior when the constructor is not pure.
Do not modify the wrappers, but add a global mutex for emplacement. This would add a little bit to runtime cost even when emplacement isn't used, because the locked state will have to be checked by the constructor to see if emplacement should be performed, even if it should just be one atomic operation with parking_lot. This would greatly surprise users who may want to emplace scripts in parallel, but that should be much less common a use case compared to impure constructors, and we can document that relatively easily.
Do nothing fancy: just map_mut and drop the previous script. This would still require users to write their own internal-type "pattern"s. and can be costly if the default constructor is expensive.

Currently, I like solution 2 the best, but solution 3 is also acceptable. The drawback of solution 1 sounds too surprising to me, so I'm not inclined towards it. If there are any better methods, please let me know!

Perhaps a better solution than a global mutex might be a thread local static containing a RefCell<Option<Box<dyn Any>>>. It should be unnecessary to use a type map, since it should be impossible for user code to run between a call to Instance::emplace and NativeScript::_new (and subsequently our constructor wrapper).


[FEATURE REQUEST] Syncing and File rename

I like this app very much! One feature would make it perfect:
When a file is renamed in the app the new name doesn't appear in sync order. It appears only the choosen time format.
When a file is renamed in sync order it will be synced again next time (so you have it twice in sync order: one with old, one with new name).
Would it be possible to include the new file name in syncing process?

@schlackenfuchs thanks! What do you mean by sync order?
The issue is that if you change to name of a document it is not synced with remote (like webdav)?

@farfromrefug Thanks for your fast reply! And sorry for my incomprehensible post...
No, renamed documents are synced, but (1) they loose their name, if they are renamed before syncing, or (2) they will be synced again, if they are renamed in sync folder.
For a better understanding a short description what I do and the results:
1

I scan one document. The file is named as defined in settings | document naming template.
For a better overview I rename some files in the app via long press | rename.
When I sync the documents, I can find them in the folder defined in settings | sync | sync document images | folder (in my case a folder on the device).
In this sync folder the documents have the name as defined in settings | sync | sync document images | filename date format, so they loose the name from step 2 above.
or
2
I scan one document. The file is named as defined in settings | document naming template.
I sync the documents.
For a better overview I rename some files in the sync folder.
Next time the sync process can't find the original file in sync folder (because it has a new name), so that file comes second time...
Clearer now?
It would be helpful if the sync process would regard the new file name.
Or is there already such an option, but I didn't see it?

I found a solution for me:
Syncing not the document images, but the document PDFs allows to use the document name. That is what I need.
Thanks a lot for that really helpfull app!
Best regards

@schlackenfuchs thanks for the great explanation! i see your issue. Indeed syncing image cant really use the document name as their could be multiple images. I could do documentName_$imageIndex. Seems like a good idea will look at it


Can we replay a json sample file with eventgen.conf to show current timestamp?

What config is needed to simply replay a sample json file, but replace the timestamp with current timestamp, so as to have continuous stream of events?
I tried with mode=replay and the it generates the files with the timestamp as in the sample file. It doesn't change timestamp as per timestamp formating

That's the purpose of replay mode. I would double-check your syntax, especially the timestamp regex. If you paste your .ini files and a sample of the data, we can maybe find the issue.
https://github.com/splunk/eventgen/blob/develop/documentation/TUTORIAL.md#the-configuration-file

Any chance of review?

//eventgent.conf
[myalerts.txt]
sampleDir = /opt/splunk/etc/apps/myapps/samples/
mode = replay
#timeMultiple = 1
outputMode = file
fileName = /tmp/myapp_alerts.log
#outputMode = splunkstream
#maxQueueLength = 5
interval = 60
backfill = -15m
backfillSearch = index="myapps_index" sourcetype="mysourcetype"
#TIME_FORMAT = "end": "2018-04-10T09:55:43.132Z"
token.0.token = end":\s"\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}Z"
token.0.replacementType = replaytimestamp
token.0.replacement = %Y-%m-%dT%H:%M:%S.%fZ


d2i_X509_fp is leaking

Hi,We are using d2i_X509_fp to load certificate.How to free memory allocated by d2i_X509_fp and when.

Call X509_free() on the returned certificate when you have finished using it. Note that an X509 object is reference counted. The d2i_X509_fp function returns an X509 object with a single reference. The X509_free() function decrements the reference count and frees the object if the ref count gets to 0. If you increase the ref count (for example by calling X509_up_ref()). Then you will need to call X509_free() for each reference you have obtained.

Still it is leaking:-
==21753== 3,858 (328 direct, 3,530 indirect) bytes in 1 blocks are definitely lost in loss record 38 of 38
==21753==    at 0x4A069EE: malloc (vg_replace_malloc.c:270)
==21753==    by 0x4F478F5: CRYPTO_zalloc
==21753==    by 0x4EB7CC0: asn1_item_embed_new
==21753==    by 0x4EB5E1E: asn1_item_embed_d2i
==21753==    by 0x4EB648D: ASN1_item_ex_d2i
==21753==    by 0x4EB6513: ASN1_item_d2i
==21753==    by 0x4EA3A43: ASN1_item_d2i_bio
==21753==    by 0x4EA3AC5: ASN1_item_d2i_fp
certificate =d2i_X509_fp(certificate_file, NULL);
freeing
d2i_X509_fp(certificate);

How are you using your certificate once it is loaded? If you are definitely freeing it, and it is still reporting as leaked then almost certainly something else is holding onto a reference to the object, i.e. so that the reference count never gets to 0 and it never "really" gets freed.

Is it there a way to forcefully free it before process exit?

Is it there a way to forcefully free it before process exit?

Don't do that. If it is not being freed when you call the free function then something else is holding a reference to it. If you forcefully free it anyway and that other thing also frees it then you will get a double free == crash.
You need to figure out what is holding onto the reference.

Problem is, for example, you need only EVP_PKEY and have function which returns just EVP_PKEY extracted from x509. In this function you do x = d2i_X509() then pkey = X509_get_pubkey(x) then X509_free(x) and return pkey. In that case you have memory leak which is very hard to fix. After X509_get_pubkey(x) x reference is incremented and after return reference to x is lost and you can not free it. When you later EVP_PKEY_free(pkey) referenced x (with 0 reference counter) is not freed.
Please suggest how would it would be better to solve such problem?

After X509_get_pubkey(x) x reference is incremented

Err, no? X509_get_pubkey(x) does not increment the reference count of x. It does increment the reference count of the returned EVP_PKEY. So something like this should work without leaking a reference to x (error handling omitted for brevity):
X509 *x;
EVP_PKEY *pkey;

x = d2i_X509(...);
pkey = X509_get_pubkey(x);
X509_free(x);

return pkey;

@mattcaswell Thanks for your answer!

FWIW: I can confirm that leakage for older OpenSSL versions. I had a unit test running, which basically calls fopen() on some client cert, d2i_X509_fp() on the FILE* pointer I got, does some operations on the X509* pointer you get, and eventually calls X509_free(). I was running my test on different hosts with Valgrind and these are the results:

status
OpenSSL version
host

✘
1.0.1t   3 May 2016
Debian GNU/Linux 8 (jessie)

✘
1.0.2o  27 Mar 2018
ptxdist 2018.05.0

✔
1.1.0l  10 Sep 2019
Debian GNU/Linux 9 (stretch)

✔
1.1.1d  10 Sep 2019
Debian GNU/Linux 10 (buster)

So it appears there was a memleak in 1.0.x which was fixed in 1.1.x … don't know if anyone is motivated to find the exact commit, it does not really matter to me for now.

1.0.1 hasn't been supported for years, 1.0.2 hasn't been supported since December.  I doubt that this will ever be fixed in either.


FB_Tree_Map.Remove() balancing

Hi @fisothemes
When removing an element from a FB_Tree_Map the map is balanced. I suspect the balancing here is not correct. Because the node is deleted first and then the balancing is done with this deleted node, which memory is not anymore in use.
As you can see in the printscreen, the memory area of the pTemp node which was removed before is now already in use again by other dynamic objects (in my program). This can lead to exceptions.
I'm not sure, but shouldn't balancing be done from the previsous node (pTemp^.pParent) in this case?
Which have to be saved before removing the pTemp.
e.g.
pPrevious := pTmp^.pParent;
THIS^.Remove_Node(pTmp);
THIS^.Balance(pPrevious);

Hi @freiurs thanks for bringing this to my attention, very detailed and helpful issue. I'll try to fix it as soon as I can, it might not be this week since I'll be away on Holiday.

Hi @fisothemes
No stress, have a nice Holiday!

Fixed on pre-release 1.0.5,25


Slow Mouse when Full Screen on Linux

I see the mouse slows down a lot when using Linux in Full screen... If I enable "Software Mouse" it gets a bit better but still it's slow, while if I exit full screen mouse is working normal as expected.

I have no idea what this is, sounds like hardware mouse isn't used for bigger mouse cursor sizes. Works fine here.

I haven't personally noticed any odd fullscreen slow down on Arch, what distro do you use @ayskura?
also do you have any noticeable errors or weirdness looking through logs relating to your mouse from the kernel or DE?

I haven't personally noticed any odd fullscreen slow down on Arch, what distro do you use @ayskura? also do you have any noticeable errors or weirdness looking through logs relating to your mouse from the kernel or DE?

I am using few Raspberry pi (2/400/02w)
the mouse gets very strange when goin full screen

@ayskura i wonder if you tried with debian arm64, if it would make a difference... what version of ft2-clone are you using?

@ayskura i wonder if you tried with debian arm64, if it would make a difference... what version of ft2-clone are you using?

I tried different versions and all of them have the slow mouse issues, I tried it on different Raspian version, I don't have Debian Arm64, but Raspian should be based on Debian? the way it is, It is really sluggish and makes it impossible to use

The reason for the slow mouse in fullscreen mode is because you are using a Rasbperry Pi. This is even described in the "Known bugs" section in the FT2 help screen.

The reason for the slow mouse in fullscreen mode is because you are using a Rasbperry Pi. This is even described in the "Known bugs" section in the FT2 help screen.

that's a shame as it's such a nice combination (Raspberry pi with FT2Clone) :(


Typo in AdbcDriver/ConnectionGetDbSchemas

It should say AdbcConnection for the first parameter, not Connection

Fixed, thanks!


Fix/decimals

Description of change
Adapt the current code to use 18 decimals for SMR native on L2
Links to any relevant issues

Type of change

Bug fix (a non-breaking change which fixes an issue)
Enhancement (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Fix

How the change has been tested

Change checklist

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that new and existing unit tests pass locally with my changes
[ ] I have updated the CHANGELOG.md, if my changes are significant enough

@begonaalvarezd
As discussed on Slack, pls help review/merge this PR.
Thanks


"node server.js" results in "Error: Cannot add an empty service to a server"

I'm going through this tutorial and have already hit #5 / #6 due to grpc being updated since the tutorial was written. Now I've hit the following issue:
When https://codelabs.developers.google.com/codelabs/cloud-grpc/index.html?index=..%2F..%2Findex#4 instructs you to run "node server.js" for the first time, it doesn't say you should get an error, but you do:
$ node server.js
/Users/<user>/src/cloud-grpc/start/node_modules/grpc/src/node/src/server.js:735
    throw new Error('Cannot add an empty service to a server');
    ^

Error: Cannot add an empty service to a server
    at Server.addService (/Users/<user>/src/cloud-grpc/start/node_modules/grpc/src/node/src/server.js:735:11)
    at Server.addProtoService (/Users/<user>/src/cloud-grpc/start/node_modules/grpc/src/node/src/server.js:786:8)
    at Object.<anonymous> (/Users/<user>/src/cloud-grpc/start/server.js:7:8)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:418:7)

It looks like I can ignore this one and keep going through the tutorial, but thought I'd open this so you're aware of this issue too. I think I'll stop here though, and hopefully you can take care of any other updates that are required so users can get through the tutorial smoothly. Thanks!
/cc @MakMukhi

+1 to this.
It would be great to fix the tutorial such that the initial version of books.proto defines at least one rpc in the service definition like this one:
syntax = "proto3";
package books;
service BookService {
  rpc List (Empty) returns (Empty) {}
}
message Empty {}

@Tuxdude thanks for the fix, we are updating this now! Will close once the new lab is published


dots in interface names problematic?

on 1.0.2
root@dcg-1:~# ypconfig createconfig
Traceback (most recent call last):
  File "/usr/local/bin/ypconfig", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.5/dist-packages/ypconfig/cli.py", line 68, in main
    cfg = config.Validate(cfg)
  File "/usr/local/lib/python3.5/dist-packages/ypconfig/config.py", line 238, in Validate
    document[iface] = Interface(document[iface], iface)
  File "/usr/local/lib/python3.5/dist-packages/ypconfig/config.py", line 128, in Interface
    ret['name'] = Ifname(iname)
  File "/usr/local/lib/python3.5/dist-packages/ypconfig/config.py", line 81, in Ifname
    raise ValueError("Invalid interfacename: %s" % (teststring))
ValueError: Invalid interfacename: eth7.108
root@dcg-1:~#

Obviously! Vlanid and parent!


Cannot set up guest memory ‘pc ram’: cannot allocate memory

Hi guys!
I’m new here.
I have installed UTM on my iPhone 8 jailbreak iOs 14.2.
When I star my VM Android 9 there is that error.
I attached screen for help me.
I’m sorry for my English 🥲

Hi joker3492, welcome to github.
have you tried decreasing the ram?

Yes! The app crash.

Error is due to using too much RAM.


Components no longer work in if statements

Components now return the number literal opcode when returning numbers, and if statements don't use the number literal opcode, breaking it.

Fixed in ed949a4. If statement now use number literals.


how to  refresh data in terms of plotview on DockDocument?

hi, @RobinPerris, thanks for your great work first!
currently i have a question for help.
i added a plotview control on DockDocument.  but cannot refresh data on tabbed document(plotview.invalidate() doesn't work) when new date coming in.
could you help me how to refresth new data on plotview?
Thanks!

@biotech7 this may seem quite obvious, but have you tried either .Update() or .Refresh() on both of the controls?

@ohhsodead, i use plotview.Refresh() and plotview.Update(), don't work. i want to add control plotview on tab "Document 1", not tab "Document  2"( or other tabs), how can i specify tab "Document 1" distinguishing from other tabs and refresh it alone? this issue puzzles me.

If you load up the Examples project and look in Forms/Docking you can see how tabbed content panels should be designed. You can then look at MainForm.cs to see how to initialize and manage instances of these controls.
There is also a writeup in the Wiki here: https://github.com/RobinPerris/DarkUI/wiki/Tabbed-document-interface
There is no PlotView control in the default WinForms library. Is this an external control you added?

thanks for your reply.  i'll follow your instruction to check the problem.  i add plotview control of Oxyplot lib. into dockdocument container. it's not fully compatible with DockDoument mainly at a result of malfunction of refreshing data.

This isn't related to DarkUI - what you're struggling with is using OxyPlot. Check out the documentation here: https://oxyplot.readthedocs.io/en/latest/getting-started/hello-windows-forms.html
I took the OxyPlot WinForms example, pasted it in to the DarkUI examples project and it worked just fine:
https://streamable.com/aa79gq

@RobinPerris，very appreciated for your verificatin. i can reproduce this example.
but my issue is a little different from the example (my datasource from remote server, refreshing method is automatic by calls from other function) . i'll try to figure out it. In conclusion, this maybe is not a bug but a demand for further improvment.

Closing this as it doesn't seem to be a bug with DarkUI itself - feel free to open a new one if you're still having problems.


Add support for bumping docker container versions referenced from within Helm files

This PR extends the recent Kubernetes support for Docker containers to common Helm chart formats:
foo:
  image:
    repository: sql/sql
    tag: 1.2.3
    registry: docker.io

or alternatively:
foo:
  image:
    repository: sql/sql
    version: 1.2.3

@brendandburns : The docker CI / CI (docker, docker) (pull_request) build failed. There are few failures due to the naming convention  of the method and variable names (Naming/MethodName:). Request you to fix that. Thank you.

@honeyankit thanks I'll take a look. (is there a way that I can run these locally?)

@honeyankit style issues addressed (I hope) ptal

is there a way that I can run these locally?

https://github.com/dependabot/dependabot-core#running-the-tests describes how to run the Rubocop style checks. I highly suggest running those commands within the docker container as described in the section just above that one.

Rebased.

@honeyankit this seems to be failing because of a permission problem unrelated to this PR.
If it is something in this PR please let me know and I will try to fix it.

Also, can you please squash the lint change commit into the original commit?
We currently can't merge via squash due to a limitation in our release script so whatever the commit history is on this branch is what makes it into main...

Comments addressed, commits squashed and rebased.
Please take another look.
Thanks!

Comment addressed.  Please take another look.

@jeffwidman
newlines added. fwiw, the JSON formatter for VS Code/Codespaces removes the newline at the end of JSON files, so I'm not sure that newlines for JSON is standard, but nonetheless they should be there now.
Please take another look.
Thanks!

fwiw, the JSON formatter for VS Code/Codespaces removes the newline at the end of JSON files, so I'm not sure that newlines for JSON is standard, but nonetheless they should be there now.

Oh interesting. I'm surprised by that, I'll have to research that a bit more.

Hmm... something wrong here, I clicked the Update via Rebase and now it says:

dependabot-ci authored and jeffwidman committed 1 minute ago

Hmm... I'm going to amend the commit to ensure Brendan is the author here.

That looks better, @brendandburns see ☝ I have no idea what went wrong, something in GitHub's Update with Rebase command... Anyway, I wasn't sure what email you preferred to use, and there was no history due to the force push so I used your @microsoft.com email, as that's what it looks like you used elsewhere on other commits on your profile.
I'll deploy this once CI goes green, and assuming everything looks good in production will merge this later tonight.

@jeffwidman Thanks and yes, the @microsoft.com address is generally what I use.
Great to see this merge!

That looks better, @brendandburns see ☝ I have no idea what went wrong, something in GitHub's Update with Rebase command... Anyway, I wasn't sure what email you preferred to use, and there was no history due to the force push so I used your @microsoft.com email, as that's what it looks like you used elsewhere on other commits on your profile.
I'll deploy this once CI goes green, and assuming everything looks good in production will merge this later tonight.

Hi @jeffwidman, Do we need to cut a new tag to use this feature?

It is already deployed to GitHub prod, but requires a feature flag. If you are using it somewhere other than GitHub than you'll need to use mainas not yet on a tagged release.

It is already deployed to GitHub prod, but requires a feature flag. If you are using it somewhere other than GitHub than you'll need to use mainas not yet on a tagged release.

I am using it outside of GH. When it'll be available on tagged release?

@jeffwidman Any timeline on when the tag release will cut?

I am using it outside of GH. When it'll be available on tagged release?

We don't really do tagged releases anymore as our deployment model has changed a bit and we don't need them anymore, you can just pull the changes in from a sha

cc @mburumaxwell

Long term, I think we probably should still make tagged releases available
on RubyGems to make life easier for those who run Dependabot in custom
ways.
But since we are now deploying multiple times a day straight from PR
branches before they merge back to main we'll probably move away from
manually running the release scripts that push to RubyGems and instead
automate it to cut versions on a monthly or weekly basis. This also means
we'll likely need to move away from semver guarantees.
That said the above is my personal opinion and others on the team may feel
differently... So just overall there's some planning / internal discussion
that needs to happen and no one has had the bandwidth to drive that yet..
I'm hopeful I might have time before end of quarter but I can't guarantee
it.
On Tue, Oct 25, 2022, 10:38 AM Nilekh Chaudhari @.***>
wrote:

cc @mburumaxwell https://github.com/mburumaxwell
—
Reply to this email directly, view it on GitHub
https://github.com/dependabot/dependabot-core/pull/5738#issuecomment-1290913434,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADV74VL5ETQ3CDZ4ZZYARTWFALIRANCNFSM6AAAAAAQOQMKOA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Currently this is buried behind a feature flag for folks on GitHub.com...
We'd like to start slowly rolling it out for everyone, but before I do that, I'd like to test on a few repos to ensure no unexpected issues. I can / will setup a fake test repo, but there's nothing like live data to confirm things.
Anyone watching this PR care to volunteer to have their repo(s) be part of the beta test?
Repos must match the following criteria:

on GitHub.com
public, because for security reasons we can't access private repos w/o jumping through some hoops
have helm files... ideally with a combination of up-to-date and outdated docker image tags

If interested, please comment on this thread with the URLs of any repos you own/maintain.

@nilekhc This is now live on RubyGems: https://rubygems.org/gems/dependabot-omnibus/versions/0.213.0

Currently this is buried behind a feature flag for folks on GitHub.com...
We'd like to start slowly rolling it out for everyone, but before I do that, I'd like to test on a few repos to ensure no unexpected issues. I can / will setup a fake test repo, but there's nothing like live data to confirm things.
Anyone watching this PR care to volunteer to have their repo(s) be part of the beta test?
Repos must match the following criteria:

on GitHub.com
public, because for security reasons we can't access private repos w/o jumping through some hoops
have helm files... ideally with a combination of up-to-date and outdated docker image tags

If interested, please comment on this thread with the URLs of any repos you own/maintain.

Hey @jeffwidman, we can test with our repo if you are still looking for volunteers.
https://github.com/Azure/secrets-store-csi-driver-provider-azure
Let me know what I need to do.
cc @aramase

Awesome thanks @nilekhc
I will enable the feature flag on your repo tomorrow, and then since it's a public repo I think I can internally trigger a dry-run to test it. I'll post a follow-up once the flag is enabled.

Also @nilekhc you'll need to enable a "docker" ecosystem check in https://github.com/Azure/secrets-store-csi-driver-provider-azure/blob/master/.github/dependabot.yml for the whatever folder holds these files. IIRC, the check will recursively search for files, so if you've got nested subdirs of charts, targeting the "docker" check at the parent dir should be fine.

Also @nilekhc you'll need to enable a "docker" ecosystem check in https://github.com/Azure/secrets-store-csi-driver-provider-azure/blob/master/.github/dependabot.yml for the whatever folder holds these files. IIRC, the check will recursively search for files, so if you've got nested subdirs of charts, targeting the "docker" check at the parent dir should be fine.

PR - https://github.com/Azure/secrets-store-csi-driver-provider-azure/pull/1014

@jeffwidman It's working on our repo -
https://github.com/Azure/secrets-store-csi-driver-provider-azure/pulls

Awesome news thanks for circling back!

☝ is resolved, right @nilekhc ? Catching up on old notifications... 😀

☝ is resolved, right @nilekhc ? Catching up on old notifications... 😀

It is!


There is a vulnerability in Guava: Google Core Libraries for Java 19.0,upgrade recommended

https://github.com/apache/rocketmq-mqtt/blob/0fb52d19159fe1e2cd053165714ff6d694d589e2/pom.xml#L143-L147
CVE-2018-10237 CVE-2020-8908
Recommended upgrade version：30.1.1-android

Would you like to pr for this update, I am willing to help you merge:-)


Generate fresh databases (with migrations applied) while testing

This creates a DBSpec trait which may be extended by a scala-test
spec class to provide the following behavior:

Initializes a new testing_template DB if it doesn't exist
Initializes and runs migrations on the testing_template DB
Creates a new DB, copied from the empty, but migrated template
Uses the new DB during testing
Removes the test DB after testing is complete

Testing

Run the tests via: ./scripts/test (yes, they've been re-enabled).
They should pass, and you should also notice the list of migrations that are run.
Re-run the tests
You should notice that the migrations are run, but there are none to apply, since the testing_template DB is intentionally not deleted.

+1


byte index 6 is out of bounds of ir56 at compiler/src/abi/builder.rs:181:41

Compiling this file:
contract Foo:
    pub def bar(x: i256, y: ir56) -> i256:
        return x - y

Warning: bytecode output requires 'solc-backend' feature. Try `cargo build --release --features solc-backend`. Skipping.
thread 'main' panicked at 'byte index 6 is out of bounds of `ir56`', compiler/src/abi/builder.rs:181:41
stack backtrace:
   0: rust_begin_unwind
             at /rustc/c0b64d97beebb09325b5587abed39f4f1621026f/library/std/src/panicking.rs:493:5
   1: core::panicking::panic_fmt
             at /rustc/c0b64d97beebb09325b5587abed39f4f1621026f/library/core/src/panicking.rs:92:14
   2: core::str::slice_error_fail
   3: fe_compiler::abi::builder::type_desc
   4: fe_compiler::abi::builder::func_def_arg
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Aborted

On latest github master, built with
[profile.dev]
debug = true
panic = "abort"

for fuzzing.  Using https://github.com/agroce/afl-compiler-fuzzer (we've found more than 50 bugs (that were worth fixing, and have been fixed) in solc using this afl variant) + afl.rs.
This might be a more interesting type of bug, if you think fe is ready for fuzzing at all.

Fixed by #217


Merge process

Just a suggestion - when merging a PR, the "Squash and Merge" option tends to lead to a cleaner git history - especially if the individual commits within a pull request aren't particularly descriptive. This takes all the commits in a PR, squashes them into one named after the PR title, and puts it on top of main. You can also configure this to include the PR description.
If you do want to keep all individual commits from a PR, the "Rebase and Merge" option will stack them all on top of main instead of potentially interleaving them with other commits. This isn't the case for merge commits. For example, some commits from #66 are displayed before 28a932f7ef0c29e682419bad9ab50714150c1fee even though you merged #66 after 28a932f7ef0c29e682419bad9ab50714150c1fee. "Rebase and Merge" avoids this.
Both "Squash and Merge" and "Rebase and Merge"  make the git history more readable by avoiding having several merge commits on the main branch. I'd recommend using either of those instead of merge commits.

I definitely want to keep the commits intact for the moment, but that might change over time if this crate grows significantly.
Will start rebasing - thanks fo the advice. 👍


Scroll animation audit (part 1) — target date 01/15

Overview
Explore existing patterns and components previously built out, and see how to scroll animation could, should, and will be applied. This epic contains links to all of the issues required to complete this work.

[x] ~Review and Identify components / patterns~
[ ] Design approves stories to be created
[ ] Create stories to design for these moments of motion.

Resources

Scroll animation [box][codepen][research]
Scroll into view [box]

Moving https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/4827#issuecomment-755436559 from #4827

Here are some stories I'm going to ~create today~ when design approves focusing on low-level elements at first. Especially focusing on media and cards first we can get some heavy hitters out with minimal effort.

[ ] Card group

Content group with cards
Card section
Content block with cards
Locale modal

[ ] Logo grid
[ ] Content Group with Pictograms

Pictogram Item

[ ] Content group horizontal

horizontal item

[ ] Media (image, and video)

Card
Content block simple
Content block media ?
Contetnt block segmented
Content group simple
Logo grid

Moving https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/4827#issuecomment-755436559 from #4827

Here are some stories I'm going to ~create today~ when design approves focusing on low-level elements at first. Especially focusing on media and cards first we can get some heavy hitters out with minimal effort.

[ ] Card group

Content group with cards
Card section
Content block with cards
Locale modal

[ ] Logo grid
[ ] Content Group with Pictograms

Pictogram Item

[ ] Content group horizontal

horizontal item

[ ] Media (image, and video)

Card
Content block simple
Content block media ?
Contetnt block segmented
Content group simple
Logo grid


feat(custom-templates): introduce custom templates

closes #3861

@pull-dog go fetch

@pull-dog get lost

@pull-dog get lost

@pull-dog go fetch

@chiptus this one needs a rebase

in custom templates list add delete and edit buttons to the create stack form

@pull-dog get lost

@pull-dog go fetch

what about creating a custom template from an app template? this will let our users customize their own templates

@pull-dog up

@pull-dog up

@chiptus weird that Pull Dog did not react here. Will investigate later today and coordinate with @deviantony.

@pull-dog down

@pull-dog up

CI build failed, probably why pull-dog did not react (no API request sent).

@pull-dog down

@pull-dog down

4. when creating a template called "test" as the admin, and assigning access control to it so only Admins can use it, i can login as user and create a template also called "test", and set the access control to "private". when i login as the admin, both of the templates have access control as admin, even though one is actually private and one is admin.

template name should be unique?

For access control, the constraint should be set on the template ID, not the template name.

@chiptus this one now needs a rebase after the introduction of #3987


[bilibili] Cannot extract formats higher than 480P

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I'm running yt-dlp version 2023.07.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
China
Provide a description that is worded well enough to be understood
Even cookies are provided using --cookies-from-browser, yt-dlp cannot extract formats > 480P at present, but I believe it's working a few days ago.
Watching online with Chrome is okay.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', '--cookies-from-browser=chrome', 'https://www.bilibili.com/video/BV1mX4y147LG', '-F']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[b532a3481] (pip)
[debug] Python 3.11.4 (CPython x86_64 64bit) - macOS-10.15.7-x86_64-i386-64bit (OpenSSL 3.1.1 30 May 2023)
[debug] exe versions: ffmpeg 6.0 (setts), ffprobe 6.0, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.18.0, brotli-1.0.9, certifi-2023.05.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-11.0.3
[Cookies] Extracting cookies from chrome
[debug] Extracting cookies from: "/Users/qianbinbin/Library/Application Support/Google/Chrome/Default/Cookies"
[debug] using find-generic-password to obtain password from OSX keychain
[Cookies] Extracted 2437 cookies from chrome
[debug] cookie version breakdown: {'v10': 2410, 'other': 0, 'unencrypted': 27}
[debug] Proxy map: {}
[debug] Loaded 1855 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>[BiliBili] Extracting URL: https://www.bilibili.com/video/BV1mX4y147LG
[BiliBili] 1mX4y147LG: Downloading webpage
[BiliBili] BV1mX4y147LG: Extracting videos in anthology
[BiliBili] Format(s) 1080P 高清, 720P 高清, 1080P 60帧 are missing; you have to login or become premium member to download them. Use --cookies-from-browser or --cookies for the authentication. See  https://github.com/yt-dlp/yt-dlp/wiki/FAQ#how-do-i-pass-cookies-to-yt-dlp  for how to manually pass cookies
[BiliBili] 357460305: Extracting chapters
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[info] Available formats for BV1mX4y147LG:
ID EXT RESOLUTION FPS │ FILESIZE  TBR PROTO │ VCODEC        VBR ACODEC      ABR
───────────────────────────────────────────────────────────────────────────────
0  m4a audio only     │ ≈2.47MiB  42k https │ audio only        mp4a.40.5   42k
1  m4a audio only     │ ≈5.67MiB  96k https │ audio only        mp4a.40.2   96k
2  m4a audio only     │ ≈9.42MiB 160k https │ audio only        mp4a.40.2  160k
3  mp4 640x360     29 │ ≈3.19MiB  54k https │ avc1.64001E   54k video only
4  mp4 640x360     30 │ ≈2.59MiB  44k https │ av01.0.08M.08 44k video only
5  mp4 640x360     30 │ ≈3.59MiB  61k https │ hev1.1.6.L120 61k video only
6  mp4 852x480     29 │ ≈5.20MiB  88k https │ avc1.64001F   88k video only
7  mp4 852x480     30 │ ≈3.32MiB  57k https │ av01.0.08M.08 57k video only
8  mp4 852x480     30 │ ≈4.85MiB  83k https │ hev1.1.6.L120 83k video only

Do they show if you pass --allow-unplayable-formats?

Do they show if you pass --allow-unplayable-formats?

I've just tried but no luck.
Bilibili uses HEVC/AVC/AV1 for high bitrates videos, which are commonly supported.
This script works fine: https://github.com/the1812/Bilibili-Evolved

Related: #5874, #5655

Surprisingly I logged in with Safari and tried with --cookies-from-browser=safari, and it works.
After that I refreshed Chrome page and my account was logged out automatically. Then I logged in again, and --cookies-from-browser=chrome magically works.
Indeed Bilibili supports signing in on multiple browsers/devices with the same account. I guess it may be something wrong with the cookies, but for some reason Bilibili didn't tell me that.
Anyway, many thanks for your help! I'll close the issue.


Data loader uses old route params, when navigation changes to to fast.

Data loader uses old route params, when navigation changes to to fast.
Reproduction

Go to example https://stackblitz.com/edit/vitejs-vite-xntgcq
Click on link "Test 2" few times, then quickly click on link "Test 1"
Observe that params from current route, and data loader mismatch.

https://github.com/posva/unplugin-vue-router/assets/8914032/d1f6daad-8bf9-425a-85bc-a2cd24906a49

This might be related to #201. I think it's a mix of the current cached behavior and not properly discarding old fetching. I think adding different stages to the data, e.g. waiting for all of the loaders to be resolved before applying will help for this and #201

I am trying to patch this locally for myself and it seems, shouldFetchAgain entry  can resursively point to itself.

I am not sure if that is intended, but the quick fix could be to change this code
https://github.com/posva/unplugin-vue-router/blob/5d9f1086cbe884e8a5e065a0de92665ff6c87b76/src/data-fetching/defineLoader.ts#L301-L315
to check if entry and child entry are not the same
Array.from(entry.children).some((childEntry) =>
      entry !== childEntry && shouldFetchAgain(childEntry, route)
     )

@minht11 Some heads-up: this and other bugs are fixed but the next release will likely be a major that replaces the current implementation of defineLoader. I haven't written the changelog yet and I do hope to add deprecations in the meantime but the new fixed version does not have a cache (yet) and things like invalidate, pendingLoad, and cacheTime do not exist anymore. Ideally, I will create another define loader for cache that uses a light lru cache but I think the priority should be having a loader with no cache (since most of GET cache should be handled at server level anyway) and move from there to support other patterns and update https://github.com/vuejs/rfcs/discussions/460


Use of compareTo in android.arch.lifecycle.Lifecycle.State

This is not a bug it is more a suggestion and is referred to the usage of the Enum compareTo method (based on constants ordinals). As suggested by Joshua Bloch in Effective Java (Item 31 "Use instance fields instead of ordinals") I'd go for this approach given that it is less fragile and self-explaining.
Keep up the good work.
Paolo

Need more info


bpf: Fix sockops compile/verify on newer LLVM

Older versions of Clang/LLVM (7.0 and earlier) compile this line into a
32-bit read followed by a shift:
  r8 = *(u32 *)(r6 + 64)
  r8 >>= 16

Newer versions of Clang/LLVM will compile this instead into a single
16-bit read into an offset from the context like this:
  r8 = *(u16 *)(r6 + 66)

Unfortunately, the kernel verifier (at least as of v5.0, possibly newer)
does not currently support reads into 'struct bpf_sock_ops' at such
offsets, which leads to verifier errors when attempting to load the
program when compiled on newer compilers.
Fix it by forcing a 32-bit read and shifting it.

This change is

test-me-please

I'm removing the need to backport this to v1.5, we are only doing critical security fixes in v1.5 now.

Coverage decreased (-0.01%) to 45.515% when pulling 5d8e4a637dc8a6667cab2e83c2c52f867f424ef0 on joestringer:submit/fix-sockops-compile-newer-clang into cf479af2e47d6be69c11487e5591e14e9ab4657d on cilium:master.

test-me-please


Search and filters should stay on the current record when they're cleared

Issue:
When a user clears the search or the filter, they want to remain on the current record that's in view instead of being returned to the top of the file.
DoD:
When the user clears the search bar, or resets the filter the user is kept on the same record they were already on.

@birchamp  @BincyJ  -- @Joel-C-Johnson just finished #927
should he work on #928 too ?


Sql->ds does return column names as string

Thia is not really a big deal.
But appending datasets works with column names being keywords.
Running sql->ds returns column names as string.
Its counterituitive when I can create a new table and append data with columns that are keywords. But when querying it gives back string names.

key-fn is an option here so just like parsing a CSV - :key-fn keyword will do what you expect.  In fact many of the standard parsing options are available here.

oh very nice! Perhaps you want to add this to the docs. Because I didnt see this option anywhere.


Separated mob loading from TE loading and moved to PreInit

resolves https://github.com/aidancbrady/Mekanism/issues/5136

not sure I follow, it's called in the preInit evenhandler similarly to how it was previously called from init, I just separated it from addEntities, made a nearly identical function called addMobEntites that only does the mob registering and called that in pre-init instead of init to match the coding style already in place.

there is a specific registry event for mobs

yeah I'm not sure when I'll have time to work on this again I'll just close for now, maybe someone else will have time to fix it for Vyraal's request, if not I'll revisit once I have some time from work


Explicit hydrogen addition to chemical formulas

Dear Ketcher Development Team,
My name is Nikolaos Papageorgiou and I am a Chemistry teacher in a Greek High School.
First of all, let me congratulate you on your marvelous work with ketcher.
I have been assessing it for a while and I am amazed with its abilities and unparalleled simplicity !
From what I have witnessed, there is only one feature missing for my everyday use:
The ability to add explicit hydrogens in chemical formulas and produce a more accurate 2D representation of
the molecule that I sketch after clean up !
Just showing hydrogen labels does not give a single hint regarding actual stereochemistry to students and I badly need to give them a view about it !
Please accept my wishes for courage, inspiration and innovation !
Regards,
Nikolaos Papageorgiou

Thanks for your feedback.
We have added this feature to the roadmap.


add mosaic search + other updates

This PR adds a mosaic/list endpoint to list/search mosaic registered in PgSTAC database
ref:

https://github.com/developmentseed/eoAPI/issues/22
https://github.com/stac-utils/titiler-pgstac/pull/45

Other fix/additions

Pin mangum to >0.14 (ref https://github.com/developmentseed/eoAPI/issues/34)
update PgSTAC version (https://github.com/developmentseed/eoAPI/issues/35)
Update titiler-pgstac version

breaking changes

add CDK_ prefix to deployment related environment variables

not at my computer, there are some other small not critical changes in your
query generation, but the big one is don't use "metadata::json" in your
filters. the metadata column is jsonB and casting it to json will cause it
to need to do the cast for every record and will prevent your index from
getting used
On Fri, Mar 4, 2022, 5:36 AM Vincent Sarago @.***>
wrote:

@.**** commented on this pull request.
In src/eoapi/raster/eoapi/raster/factory.py
https://github.com/developmentseed/eoAPI/pull/36#discussion_r819497047:

                           ),

                       ),

                       model.Link(

                           rel="tilejson",

                           href=self.url_for(

                               request, "tilejson", searchid=search.id

                           ),

                       ),

                   ],

               )

               for search in searches_info

           ],

           links=links,

           numberMatched=int(nb_items),

           numberReturned=len(searches_info),

       )

@bitner https://github.com/bitner can you check that I'm not doing any
stupid SQL (or python, or general) stuff.
—
Reply to this email directly, view it on GitHub
https://github.com/developmentseed/eoAPI/pull/36#pullrequestreview-900121638,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABIHXDKJ2ZFFNRSFNTLJXTU6HYUVANCNFSM5P5JKURA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


[Bug]: little_exif::metadata::Metadata::write_to_file is too slow and requires optimization

As the title suggests, the little_exif::metadata::Metadata::write_to_file method is too slow and needs to be optimized.
I am using little_exif as a dependency in a CLI app of mine. I love the API design and appreciate the good use of Rust's type system (especially for EXIF tags). However, there is a major drawback when it comes to the performance of the crate. Most (~99%) of the time in my core logic function (that involves writing a single EXIF tag to a JPEG image) is spent in little_exif::metadata::Metadata::write_to_file. Before this, my core logic function also reads the same file using std::fs::read and computes its hash, and yet that part of the logic seems to only take ~1% of the time.
My program without little_exif::metadata::Metadata::write_to_file takes less than 100ms (even after including logging IO) for 10 JPEG images (~20MB each). But with little_exif::metadata::Metadata::write_to_file it takes over 4s with the same data under the same conditions. That is 40x the original execution time. And this was just a sample dataset. The program's expected input specification states the JPEG image count to be >=60,000, the size of each image being >=20MB. This means a task supposed to be completed in under 10 minutes will take over a day, which is unacceptable to say the least.
A flame graph of the little_exif::metadata::Metadata::write_to_file part of my core logic function:

When I asked for help on the Rust Community Discord server, someone mentioned that little_exif::metadata::Metadata::write_to_file was likely reading the same file again and again, 4 times in total, therefore increasing the time as well as the memory consumption. I haven't gone through little_exif's source code, so I thought I should let you know about this possible bug source.

Yeah i was appalled by the execution time too.
The issue lies in the clean_metadata() function which write_to_file() calls.
It pounds the fs with syscalls byte by byte to find and remove the APP1 segment from JPEG.
I've refactored the JPEG part into in-memory mutation but since then wrote my own parser for PNG and JPEG for all the markers.
I can submit the pull request if the owner is fine with refactor of the clean_metadata() for only one format.

@SFM61319 Thanks for your feedback - glad you like the API design! :) Regarding the performance issue: Speed was never one of the main objectives of little_exif. I’m aware that some functions are primitive and have a lot of room for improvement regarding performance. So far during development it was a trade-off between speed and being able to follow what is going on, how metadata is encoded, etc. This however does not mean that I am not open for suggestions/pull requests/etc. on how to improve the current situation! Speaking of pull requests:
@Xuf3r I'd be happy to incorporate your modifications to metadata cleaning!

@SFM61319 There is now a new version that includes the optimized version for metadata clearing from @Xuf3r. Would be great to hear from you whether this fixed the performance issue you experienced!

Nice! There is a major performance boost in the new update. I appreciate the quick response from your side, and a satisfying one at that! Thank you so much!
Here is the new flame chart:


fix: typo on Readme

i am sorry, there is some function need to add () on readme, to make sure users can use correctly

approved


Exit if instance cant create

Purpose
In case a service instance can't be created, currently the btp-setup-automator moves on, and might run into several unforseen states in the code. Therefore, this PR stops the execution of the btp-setup-automator for such cases.
Does the PR solve an issue
[ ] Yes - Please add issue number
[x] No

Does this introduce a breaking change?
[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test
Very difficult, as this case only happens in those cases, where the creation of a service instance runs into a timeout.
What to Check
None.
Other Information

Integratin Test was executed successfully: https://github.com/SAP-samples/btp-setup-automator/actions/runs/4291395497


spirv-diff: Refactor instruction grouping and matching

In preparation for supporting OpTypeForwardPointer, which adds more
usages like this.  This change refactors common code used to group
instructions and match the groups.

@s-perron This is purely a refactoring change that doesn't affect functionality


Podman needs go >1.13 for building

/kind bug
Description
Recent versions of libpod fail to build when using go1.12
Steps to reproduce the issue:

Install go1.12

make podman

Describe the results you received:
# github.com/containers/libpod/pkg/bindings/system
pkg/bindings/system/system.go:69:7: undefined: "github.com/pkg/errors".Is
make: *** [Makefile:188: bin/podman] Error 2

Describe the results you expected:
Either a successful build. Or a more helpful error message.

I ran into this very issue this weekend.  @rhafer I'm not sure we can do anything about the error message.  Are there places that you think we should document this need?

Are there places that you think we should document this need?

Updating the go version in go.mod helps. You get a slightly more helpful error then. See #6709

Thanks @rhafer


Still Active?

Just checking, is camanJS still being maintained? I haven't seen any updates in the last 9 months.

I've been on a bit of a hiatus due to how busy my job has been, but yes... it is being maintained. I actually did a bunch of work on a new branch not too long ago. I would like to jump back in and really go through the backlog of issues soon, and continue work on the refactoring I started soon.


Update .gitignore

This is actually unnecessary, as this can be resolved in the move to babel for code transpilation.


Backport relevant master branch code to 4.10.x

The following is a list of actions performed based on PRs merged to master which should land in the 4.10.x release - more info at https://gist.github.com/Iristyle/8a3236d04e246a7a1159c188fb4ca133
A merge-up to master results in only 2 conflicts:

locales/puppet.pot based on automation generating translations
lib/puppet/pops/types/ruby_generator.rb due to PUP-7212 / PUP-7222 / PUP-7227 code landing

A merge-down to stable is clean
History Added In This Order
Features / refactors / other code changes that could plausibly be Puppet 4

PR 5472 - (PUP-4283) Update Puppet Module Tool to use SemanticPuppet::Version - PUP-4283

git cherry-pick 4d297235bb666dd2770955f1740af0bc91eb4b8d

resolved conflicts

Features / refactors / other code changes that could plausibly be Puppet 4

PR 5505 - (PUP-5027) Prevent that metadata.json is parsed multiple times - PUP-5027

git cherry-pick f2e8e6649d392d5d3b7b8e79efbf15815adcdcc8

resolved conflicts

PR 5504 - (PUP-7100) Add Hiera version 5 lookup_key function for eyaml - PUP-7100

this code was already brought into stable via another backport - skipping the 5 commits:
b42ef28cfec54a6072a489b5a631624cbd42d92f
26ca009b5aeca8d4b8c5e3057ceb79830b467ba5
078273acbe99cff80d35d805e6bd168ff189f607
a7790be2c3e16999bf6bdb3bd29e3cc627f95ae4
66457e73e076cf19589f90d17626f95457e22a78

Bugfixes that should probably be Puppet 4

PR 5557 - (PUP-6006) Change phrasing of multiple errors final error - PUP-6006

git cherry-pick efcdf580b1013541da3f92104e0ac3ebac52f901

Glisan Agent UTF-8

PR 5522 - (PUP-7122) Add wrapper for gettext:update_pot rake task - PUP-7122

git cherry-pick d32d3e26ea624a4d1ac7f0bd83b0fcf5e242814d
note: only took one commit as i18n.rake no longer exists

Bugfixes that should probably be Puppet 4

PR 5615 - (PUP-7168) Add #== alias for #eql? method of Pcore Objects - PUP-7168

git cherry-pick 36d98197a60d388cd47055ed3e413e77319dc37b

Features / refactors / other code changes that could plausibly be Puppet 4

PR 5502 - (PUP-6494) Support sensitive commands in Exec resource type. - PUP-6494

git cherry-pick e1dd130100316f7fcaf7f2dc095f6b50c98cc6be

Bugfixes that should probably be Puppet 4

PR 5546 - (PUP-7129) Use systemd service provider for Debian 9 (Strech) - PUP-7129

git cherry-pick e20c4bd2a5a38fe34ef052be37be254db2a1d965
git cherry-pick 5bd1a659f7e8b3d57028f964d07f37575e8f9f90

Glisan Agent UTF-8

PR 5594 - (PUP-7152) AIX encrypted user passwords are ASCII - PUP-7152

git cherry-pick d6aaca5877b20f0772aaaba7ceefa19f93f72cdc

PR 5593 - (PUP-7151) Read selinux module version as BINARY - PUP-7151

git cherry-pick 80af250667b05d37c65dcd2cd50973a25c1be325

Bugfixes that should probably be Puppet 4

PR 5632 - (PUP-7191) consider non-existent services on AIX to be stopped/disabled rather than failing - PUP-7191

git cherry-pick 68aea974d7144bb6e6830ccfe92774f6315361fe
git cherry-pick 55a67e6b1b6d7246cba921b6d8514fb381dab83c
git cherry-pick b63c540cc205eb1e897db9d33da8111d859e2847
git cherry-pick 55a67e6b1b6d7246cba921b6d8514fb381dab83c

Glisan Agent UTF-8

PR 5384 - (PUP-7134) Use Puppet::FileSystem for file access / explicitly specify encodings for SSL files  - PUP-7134

git cherry-pick dfebcf700cd17ee7f2bc33374d55fff9568aa05e
git cherry-pick a8406be58b8bef6cf8cce843cdeff692fe916125
git cherry-pick f0dab056df37adcb1fd014df1a13620aaac52722
git cherry-pick 4ad7717fbf0453466a62af1b49a776afd93a5bb9

Bugfixes that should probably be Puppet 4

PR 5639 - (PUP-7214) PUP-6663 causes a regression of PUP-535 - PUP-7214

Note - this was backported to Puppet 4 already

PR 5650 - (PUP-7102) Fail with error on access problems with environment directory - PUP-7102

GIVEN NEXT PR REVERTED, DID NOT PERFORM - git cherry-pick e4a4e09323436c5e44bc3b3154f42cd020c05a92
GIVEN NEXT PR REVERTED, DID NOT PERFORM - git cherry-pick ae58568128348a4a425444b98cec78e9420f13a9

PR 5667 - Revert "(PUP-7102) Fail with error on access problems with environment directory"

GIVEN THIS REVERTED PRIOR PR, DID NOT PERFORM - git cherry-pick b1d12540ae06943e3a793d5136ee1fe57b90684d

Glisan Agent UTF-8

PR 5633 - (pup-7021) establish central string encoding conversion - pup-7021

git cherry-pick df46662011d00f95345a9e846115042de1249166
git cherry-pick<PHONE_NUMBER>96ff1a6d7c169a818c7453c0cc47a6

MISC

(maint) fix minor spec regex warning

git cherry-pick 56cda69cbed18b3ce5fc2037efe338256165f67f

Commits Not Added
Removals / changes that should wait for Puppet 5

PR 4999 - (PUP-6372) Remove unused Puppet::Transaction.failed? method - PUP-6372
PR 5479 - (PUP-5434) Remove deprecated experimental lookup implementation - PUP-5434
PR 5491 - (PUP-6481) Remove external_facts feature - PUP-6481
PR 5492 - (PUP-6219) Remove deprecated req_bits setting - PUP-6219
PR 5493 - (PUP-3670) Remove Facts#strip_internal method - PUP-3670
PR 5494 - (PUP-4933) Remove deprecated cfacter setting - PUP-4933
PR 5642 - (PUP-5973) Remove symbol string monkey patch - PUP-5973
PR 5616 - Revert "Merge pull request #5276 from DavidS/notify-everywhere (PUP-6783)"
PR 5619 - (PUP-7142) Autoload Pcore types from TypeSet. - PUP-7142
PR 5626 - (maint) Remove redundant code from AST Model Factory
PR 5641 - (PUP-7212) Add a Pcore Annotation type and an annotate function - PUP-7212
PR 5645 - (PUP-7222) Add RubyMethod annotation and let RubyGenerator act on it - PUP-7222
PR 5646 - (PUP-7227) Add "reference" as a valid Pcore Object attribute kind - PUP-7227

Breaking changes that must wait for Puppet 5

PR 4584 - (PUP-5609) Protect shared state with filesystem lock - PUP-5609
PR 5480 - (PUP-6112) Make trusted_server_facts always be true - PUP-6112
PR 5610 - (PUP-7173) server_set facts rb failing with undefined local variable or method `master opts - PUP-7173
PR 5510 - (PUP-4947) Make app management keywords standard - PUP-4947
PR 5603 - (maint) update version.rb for 5.0
PR 5617 - (PUP-7175) lookup.rb failing automatic parameter lookup with module data binding - PUP-7175
PR 5556 - (PUP-3170) Cap integer size - PUP-3170

git cherry-pick 112e3b3ac03394258ac0b47d47b7faff5638c2c4
git cherry-pick 956f7556870fe90e54d7a6fae17b410ed509422c
git cherry-pick 0a5c85a109889fe70535dc261e27245e82a76fc5
git cherry-pick 189a6f8b8f21919353e6f650eea2e8fc59e623a2
git cherry-pick 67f22dfd0262009dd740b7d148e89c2050add3df
git cherry-pick 33252a1c9a938cb19366992e9b9f306950a314ff
git cherry-pick e2ba08435e7487e641a437b0ed9f111ae92c4e7e
git cherry-pick 5094ac2a0f0d6d6e1bcc4c70a3f89b47fac1e783

PR 5511 - (PUP-5954) Make class merge an error - PUP-5954

git cherry-pick 75a81f6cb9e81b4b3094c1e6324c462da6f61f43
git cherry-pick 0a36704e2f7a6ca09ce84b7ea471ab45031434a8
git cherry-pick e9356dd36f47ded66e82d5174c2f035fc5c0ddcb

PR 5477 - (PUP-6930) Make DUPLICATE_DEFAULT an error - PUP-6930

git cherry-pick c2d14d8359ac51d65e881f2e6b33b67a0ed4ccd4
git cherry-pick 485518c0353525a1dab3639ffe3e70211551af25

git log --oneline --decorate origin/stable..4.10.x
9d67eff (HEAD -> 4.10.x, Iristyle/4.10.x) (maint) fix minor spec regex warning
b7269fc (PUP-7021) i18n wrap string in character_encoding.rb
b22adb2 (pup-7021) establish central string encoding conversion
846920d (PUP-7102) Fail with error on access problems with environment directory
f15026c (PUP-7102) Make MemoryFile respond to #stat
7faa87a (PUP-7134) Use Puppet::FileSystem in ssl
6dae736 (PUP-7134) Puppet::SSL::Key explicit encodings
bedd54f (PUP-7134) Add csr_attributes UTF-8 tests
4650056 (PUP-7134) UTF-8 test user type authorized_keys
98eed8d (PUP-7191) update acceptance for non-existent AIX service
c0613a1 (maint) remove unreached line in aix service provider
efb261c (PUP-7191) consider non-existent services 'stopped' on AIX
56f75e4 (maint) whitespace fixes in aix service provider
5707e82 (PUP-7151) Read selinux module version as BINARY
fa13af4 (PUP-7152) AIX encrypted user passwords are ASCII
79f7560 (PUP-7129) Add support for stretch/sid and buster/sid
0c1748e (PUP-7129) Use systemd service provider for Debian 9 (Strech)
e416fb1 (PUP-6494) Support sensitive commands in Exec resource type.
e93b58b (PUP-7168) Add `#==` alias for `#eql?` method of Pcore Objects
e863de7 (maint) Ignore vendored code when searching for marked strings
f1c873a (PUP-3170) Add tests for arithmetic overflow
e92e499 (PUP-3170) Change Factory to deal with Integer instead of Fixnum
07ad330 (PUP-3170) Add test for cap of Integer literal values
fea0cb8 (PUP-3170) Add literal integer cap and cap on arithmetic
6b55722 (maint) Fix indentation
78eba5d (PUP-3170) Move definition of MIN/MAX_INTEGER to Pops namespace
3cf5cdf (PUP-3170) Add test for nested Integer out of range.
c282b56 (PUP-3170) Add cap to Integer and forbid BigDecimal values
6291125 (PUP-6006) Change phrasing of multiple errors final error
00c7f4c (maint) mark TypeCollection class as @api private
bf568cf (PUP-5954) Make attempt to merge class other than '' an error
849f276 (PUP-5954) Change how 'settings' class is set in type collection
e6ef082 (PUP-5027) Prevent that metadata.json is parsed multiple times
d8f9ab1 (PUP-6930) Modify test for logic that is unaffected by --strict
b5a1537 (PUP-6930) Make DUPLICATE_DEFAULT an error
033957f (PUP-4283) Update Puppet Module Tool to use SemanticPuppet::Version
26644d8 (origin/4.10.x) Updating POT file for d7d63f8c1c596b6ff56a57f244205bcf2d975a15
d7d63f8 Merge branch 'stable' into 4.10.x
1efd231 Updating POT file for b30d12114011153c524c8bc3ed485f1b9c39481b
b30d121 Merge pull request #5666 from thallgren/issue/pup-7204/hiera-mapped-paths
7f7b0f7 (PUP-7204) Add tests asserting that paths are included in explain output.
98702fc (PUP-7204) Add tests for when variables are shadowed by mapped paths
08d76b7 (PUP-7204) Add support for mapped paths to hiera.yaml
1795af8 Merge commit '29c05d63e69a3f4ebbdb8a5f9abfd736fff7183e' into 4.10.x
29c05d6 Updating POT file for 9d9360e17852fb905e778302315cdb7b86702073
65137c3 Updating POT file for 9d9360e17852fb905e778302315cdb7b86702073
9d9360e Merge pull request #5698 from Magisus/remove-rake-wrappers
b549bcc (maint) Remove gettext rake task wrappers
ad99698 Merge pull request #5695 from hlindberg/PUP-7306_allow-newline-in-regexp
7bf37e8 (PUP-7306) Accept newline in literal regular expressions
5d05e7c Merge branch 'stable' into 4.10.x
794515a Merge branch 'stable' into 4.10.x
c3d5f90 Merge remote-tracking branch 'upstream/stable' into 4.10.x
542e938 (packaging) Bump version to 4.10.0
79dcc5b Merge branch 'stable' into 4.10.x
4c2a795 Merge remote-tracking branch 'upstream/stable' into 4.10.x
ad61f80 Merge pull request #5680 from Magisus/PUP-7042/fix-specs
4871e4e Merge branch 'stable' into 4.10.x
36eaa777 Merge branch 'stable' into 4.10.x
6056b12 (PUP-7240) Fix bug when using lookup_options with 'global_only' lookup
8961e31 (PUP-7240) Prevent invocation inheritance when lookup adpater differs
9a11bfc (PUP-7042) Fix some problematic strings
7b05d6d (PUP-7042) Fix spec failures

👍

@hlindberg @thallgren can you do the merge up to master? I'm getting a conflict in  lib/puppet/pops/types/ruby_generator.rb related to https://github.com/puppetlabs/puppet/pull/5615.

Note that a later commit reverted the work in #5472  / PUP-4283


Use thread_local for XBYAK_TLS when supported

Some compilers may not support __declspec(thread) but they can build apps using >= C++11 by default.

Thanks for the nice patch.


Add ExternalDependency support to MiskTestExtension

We currently spin up external dependencies like Vitess and SQS in tests,
by inserting additional services into the service dependency graph. It
has forced us to use different workarounds, like ServiceTestingModule
which modifies the service graph in tests, and StartVitessService which
is a production dependency but really doesn't belong there.
@ryanhall07 had the idea that we could have the MiskTestExtension start up
external dependencies instead, since they really are just test fixtures
and are better handled by the testing framework.
It converts the DockerSqs service, which is
simple but is a good enough demonstration.

LG! 🐑 it

This is awesome.


405-gdrive-client-alternatives-db-dumps-to-s3-not-drive

Update clean_and_apply_db_dump.yml to provide s3 argument
https://trello.com/c/0jAgMP0d/405-gdrive-client-alternatives-db-dumps-to-s3-not-drive
Requires:
https://github.com/alphagov/digitalmarketplace-aws/pull/509
Change upload to go to s3

Should we remove the gdrive token and install steps from ansible in this PR?

@katstevens There's another job that still uses it on Jenkins


Hostname/IP doesn't match certificate's altnames

On startup of the server, I get the following ERROR.
➜  jsecademy git:(master) ✗ sudo brackets --port 80 --proj-dir /var/www --supp-dir /var/brackets

  listening on port 80

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: Hostname/IP doesn't match certificate's altnames
    at SecurePair.<anonymous> (tls.js:1379:23)
    at SecurePair.EventEmitter.emit (events.js:92:17)
    at SecurePair.maybeInitFinished (tls.js:982:10)
    at CleartextStream.read [as _read] (tls.js:469:13)
    at CleartextStream.Readable.read (_stream_readable.js:320:10)
    at EncryptedStream.write [as _write] (tls.js:366:25)
    at doWrite (_stream_writable.js:221:10)
    at writeOrBuffer (_stream_writable.js:211:5)
    at EncryptedStream.Writable.write (_stream_writable.js:180:11)
    at write (_stream_readable.js:583:24)

Looks like this is a bigger issue, than I thought.
Work around
NODE_TLS_REJECT_UNAUTHORIZED=0 brackets --port 80 --proj-dir /var/www --supp-dir /var/brackets

Source https://github.com/chilts/awssum/issues/164


[otbn,dv] Cleanups of wsr.py in otbnsim

Minor cleanups to wsr.py, the code that represents WSRs in otbnsim. There shouldn't be any functional change, but the code is a bit easier to understand and it runs (very marginally) faster.

Thanks, @matutem, for taking a look. This change is only on the Python side, so it feels reasonably safe (if I've messed up, it will just cause an overnight failure :-D). And I don't intend it to change behaviour at all!
I'm going to merge this now. @GregAC: Would you mind taking a look? If you see anything dubious, I'm very happy to drop everything else and sort it out pronto!


akon47.ScreenRecorder version 1.1.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Why is the "Validation-Executable-Error" label displayed?

Why is the "Validation-Executable-Error" label displayed?

An engineer will take a look. It might be a false positive.

When I attempt to run ScreenRecorder.exe on a clean windows installation nothing launches. Are there any runtime dependencies that may be missing?

oh.. I tested it in the sandbox and found the cause.
ScreenRecorder requires "Microsoft.VC++2015-2019Redist-x64".
i added
Dependencies:
  PackageDependencies:
  - PackageIdentifier: Microsoft.VC++2015-2019Redist-x64
    MinimumVersion: 14.29.30037.0

But that dependency is not installed. Is there any way I can make the dependencies be installed automatically?

When I attempt to run ScreenRecorder.exe on a clean windows installation nothing launches. Are there any runtime dependencies that may be missing?

oh.. I tested it in the sandbox and found the cause.
ScreenRecorder requires "Microsoft.VC++2015-2019Redist-x64".
i added
Dependencies:
  PackageDependencies:
  - PackageIdentifier: Microsoft.VC++2015-2019Redist-x64
    MinimumVersion: 14.29.30037.0

But that dependency is not installed. Is there any way I can make the dependencies be installed automatically?


mtriple, mcpu and march

onnx-mlir right now provides mtriple and mcpu as options to both the onnx-mlir executable as well as the backend tests, however, it does not provide march. For tools such as opt or clang generally mtriple defines both march and mcpu, but for more granular control (if mtriple is not desirable), both mcpu and march exist as options.
Something to consider is whether mcpu is needed for onnx-mlir (since mtriple already exists as an option) and if march should be added as well.

@sstamenova can we close this?

I would like to see an answer to the question before we close it. That way if it comes up again for someone, they can find it.

@gongsu832 or @etiotto : since you've touched these options in the past, are both mcpu and mtriple needed? Should march be added for completeness?

I don't think I did anything with these options. If I ever touched them, it was probably only because I need to preserve them when I made changes to other parts.

From LLVM llc (similar for opt) documentation:
-mtriple=<target triple>
Override the target triple specified in the input file with the specified string.

-march=<arch>
Specify the architecture for which to generate assembly, overriding the target encoded in the input file. See the output of llc -help for a list of valid architectures. By default this is inferred from the target triple or autodetected to the current architecture.

-mcpu=<cpuname>
Specify a specific chip in the current architecture to generate code for. By default this is inferred from the target triple and autodetected to the current architecture.

So -march and -mcpu are used to provide finer level of control than -mtriple.
Currently onnx-mlir has -mtriple and -mcpu, however it lacks -march.  I think, for completeness and flexibility we should provide -march as well.


My PR

This is the text that describes the PR and it can span multiple lines

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mighani
If they are not already assigned, you can assign the PR to them by writing /assign @mighani in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mighani: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr-build
5f1bc47f51244358767bf44df1783fc40ee9474e
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

:star: PR built and available in a preview environment mighani-jxspring-pr-1 here


Support blink 1.5.1

Will you support blink 1.5.1 wich use savepoint version3 and is base on flink 1.5.1?
I changed Gradle dependencies form org.apache.flink to com.alibaba.com and changed flink version to 1.5.1 and some java classes.
I read state from savepoint successfully but failed while writing state back.
My changes here : https://github.com/DG-Wangtao/bravo/commit/5cf25896f1a52378baeb48722b3dcd3f13150939

Hi!
The Ververica folks have started some initial work on adding a state connector (similar to bravo) to flink itself. The jira is tracked here:  https://issues.apache.org/jira/browse/FLINK-12047
if you could modify the dependencies to work with blink 1.5.1 to some extent thats good but I dont plan to work on supporting new versions while the work in flink is also on-going

of course if you need help with a specific use-case feel free to reach out to me or write on the flink-ml

Yeah, thanks.
I just want to use bravo to read some state from my savepoint and it works well.
Waiting for the Savepoint connector in flink.