Feature/finalize hooks

Overview
This PR changes the following

added useStore implementation (9ce6f07)

also fixed a bug with hook components not being updated when parent and child are both subscribed to a store (see packages/melody-hooks/src/component.js in 9ce6f07)

added useActions implementation (2ec1e12)
better shallowEqual implementation (e391d88)

now we are using one implementation that can handle all cases
added tests

Don’t compare the first argument passed to useEffect/useMemo/useCallback (b5f849e)

this was an unnecessary optimization that we ported from react.
they also removed it in react here https://github.com/facebook/react/pull/14594

added performance markers 🎹

now we can see how much time it takes to run componentFn, render, effects & unmount logic in dev tools

API Examples
useStore(store, selector)
Select & derive state with hooks
const selector = state => ({
    deals: state.dealsByItemId[state.itemId],
    sorting: state.sorting
});

const Component = props => {
    const { deals, sorting } = useStore(store, selector);
    const sortedDeals = useMemo(() => sortBy(deals, sorting), [deals, sorting]);
    return {
        deals: sortedDeals,
        sorting,
    };
};

Select & derive state with hooks with props
const Component = props => {
    const { itemId } = props;
    const selector = state => ({
        deals: state.dealsByItemId[itemId],
        sorting: state.sorting
    });
    const { deals, sorting } = useStore(store, selector);
    const sortedDeals = useMemo(() => sortBy(deals, sorting), [deals, sorting]);
    return {
        deals: sortedDeals,
        sorting,
    };
};

Reselect: select & derive state from store
const dealsSelector = createSelector(
    state.itemId,
    state.dealsByItemId,
    state.sorting,
    (itemId, dealsByItemId, sorting) => sortBy(dealsByItemId[itemId], sorting)
);

const selector = createStructuredSelector({
    deals: dealsSelector,
    sorting: state => state.sorting,
});

const Component = props => {
    const { deals, sorting } = useStore(store, selector);
    return {
        deals,
        sorting,
    };
};

Reselect: select & derive state from store with props

const createDealsSelector = itemId => createSelector(
    state.dealsByItemId,
    state.sorting,
    (dealsByItemId, sorting) => sortBy(dealsByItemId[itemId], sorting)
);

const createSelector = itemId => createStructuredSelector({
    deals: createDealsSelector(itemId),
    sorting: state => state.sorting,
});

const Component = props => {
    const { itemId } = props;
    const selector = useMemo(() => createSelector(itemId), [itemId]);
    const { deals, sorting } = useStore(store, selector);
    return {
        deals,
        sorting,
    };
};

useActions(store, actionCreators)
Single action creator

const Component = props => {
    const setSorting = useActions(store, setSortingActionCreator);
    return {
        setSorting
    };
};

Multiple action creators
const actionCreators = {
    setSorting: setSortingActionCreator,
    setFilter: setFilterActionCreator,
};

const Component = props => {
    const { setSorting, setFilter } = useActions(store, actionCreators);
    return {
        setSorting,
        setFilter
    };
};

Hey @flpwgr @fbring @jamesb3ll, would also like to hear what you guys thing about the useStore/useActions API

I'm not sure about whether we actually want to have useActions. As described here: https://melody-js.gitbook.io/docs/melody-hooks/event-handling#avoiding-the-platform there are better ways to achieve the things it's used for.
I'd prefer to not include it. In the end, the engineer can also use const myAction = useMemo(() => (...args) => store.dispatch(actionCreator.apply(undefined, args)), [store, actionCreator]); in the rare cases where this could be useful.

I'm not sure if custom events/bubbling is a good idea. You will always need a DOM inbetween two modules to let them communicate. I actually never had any problems with just passing a simple handler down to the template. IMO, moving to such a different model needs more investigation & proof that it makes the engineers life easier before advertising it.
Anyways, we have a lot of legacy use cases where we simple want to replace connect with useStore and useActions. Therefore it would be good to have it.


fix(storybook): try using more explicit patterns to fix routing

This change: (check at least one)

[ ] Adds a new feature
[x] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[x] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[x] Test suite(s) passing?
[x] Code coverage maximal?
[x] Changeset added?

What does this change address?
Routing to the Storybooks still only works when a trailing slash is included. This could be because Netlify treats URLs with/without a trailing slash as equivalent to maximize cache hits, and our redirects weren't sending some requests explicitly to the backing app, instead just trying to append a slash to the incoming URL.
How does this change work?
Create an explicit redirect to the backing app for each of:

/storybook
/storybook/*
/storybooks/react
/storybooks/react/*
/storybooks/wc
/storybooks/wc/*

Additional context
I also simplified the from values to be just the paths rather than the full URL, and ordered them by route from most general to most specific.

Closing in favor of #62


Create a simple example

A simple standalone application that uses the API and streams an image

Minimal host memory example added


Update dependencies to latest versions

Most of these haven't been updated for more than a year.

Fixes #17 @tschuy r?


fix no limit no offset.

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?
修复当 limit 为非正整数时，offset 的设置将无效的问题。
User Case Description

仅设置 offset，能正常追加到 SQL
多次设置  offset，将使用最后设置的值
设置 offset 后可再次设置 limit，互不干涉

thank you for your PR.

Hello, I am a user who is using gorm v1 to upgrade to gorm v2. I use snowflake id in part of the schema, but this needs to be INT64.
func (limit Limit) Build(builder Builder) {
...
    builder.WriteString(strconv.FormatInt(limit.Offset, 10))
}

The following changes enable Limit to support int64, but since drivers are dependent on a different repo, and drivers updated offset 11 hours ago, direct changes will not pass the test, and presumably will not be able to launch PR.
If this is a feasible solution, please let me know how to contribute to gorm and the drivers that have been established.
Thanks.

@omegaatt36 It's a good idea. but I don't think that's necessary.

How do you deal with uint64？It's bigger than int64.
Most machines are 64-bit, int equal int64.
Even though you're using a 32-bit machine, int32 max value is 2,147,483,647, it's to big for a table.

I think you can use int(int64limit).
Thanks.


Switch to rollup-plugin-babel-minify

Fixes #47

Codecov Report

Merging #49 into master will decrease coverage by 5.88%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage     100%   94.11%   -5.89%
==========================================
  Files           2        2
  Lines          17       17
==========================================
- Hits           17       16       -1
- Misses          0        1       +1

Impacted Files
Coverage Δ

src/index.js
90.9% <100%> (-9.1%)
:arrow_down:

src/utils.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc0e85...51eb28a. Read the comment docs.


Is Server-Sent Events(SSE) stream of HTTP/2 supported?

I'm trying to receive a stream response which is based on Server-Sent Events (SSE) of HTTP/2 from OpenAI's chat API with stream: true and Accept header is text/event-stream.
The status code is 200 but the following fatal client error is occurred. I would like to know SSE is supported or not.
Swift/ErrorType.swift:200: Fatal error: Error raised at top level: Client error - operationID: createChatCompletion, operationInput: Input(path: OpenAPITest.Operations.createChatCompletion.Input.Path(), query: OpenAPITest.Operations.createChatCompletion.Input.Query(), headers: OpenAPITest.Operations.createChatCompletion.Input.Headers(), cookies: OpenAPITest.Operations.createChatCompletion.Input.Cookies(), body: OpenAPITest.Operations.createChatCompletion.Input.Body.json(OpenAPITest.Components.Schemas.CreateChatCompletionRequest(model: OpenAPITest.Components.Schemas.CreateChatCompletionRequest.modelPayload(value1: nil, value2: Optional(gpt-3.5-turbo)), messages: [OpenAPITest.Components.Schemas.ChatCompletionRequestMessage(role: system, content: "You are the world no1 progrrammer", name: nil, function_call: nil), OpenAPITest.Components.Schemas.ChatCompletionRequestMessage(role: user, content: "Please write fizzbuzz", name: nil, function_call: nil)], functions: nil, function_call: nil, temperature: nil, top_p: nil, n: nil, stream: Optional(true), stop: nil, max_tokens: nil, presence_penalty: nil, frequency_penalty: nil, logit_bias: nil, user: nil))), request: path: /chat/completions, query: <nil>, method: HTTPMethod(value: OpenAPIRuntime.HTTPMethod.(unknown context at $1001d7918).OpenAPIHTTPMethod.POST), header fields: [accept: application/json, content-type: application/json; charset=utf-8], body (prefix): {
  "messages" : [
    {
      "content" : "",
      "role" : "system"
    },
    {
      "content" : "Please write fizzbuzz",
      "role" : "user"
    }
  ],
  "model" : "gpt-3.5-turbo",
  "stream" : true
}, baseURL: https://api.openai.com/v1, response: status: 200, header fields: [openai-organization: user-***, Date: Thu, 17 Aug 2023 08:41:09 GMT, x-ratelimit-limit-tokens: 90000, Content-Type: text/event-stream, cf-ray: ***-***, Server: cloudflare, Cache-Control: no-cache, must-revalidate, x-ratelimit-remaining-tokens: 89968, Alt-Svc: h3=":443"; ma=86400, openai-processing-ms: 6, x-ratelimit-reset-tokens: 21ms, x-ratelimit-remaining-requests: 3499, openai-version: 2020-10-01, Strict-Transport-Security: max-age=15724800; includeSubDomains, Access-Control-Allow-Origin: *, x-ratelimit-limit-requests: 3500, x-request-id: ***, cf-cache-status: DYNAMIC, x-ratelimit-reset-requests: 17ms], body: data: {"id":"chatcmpl-***","object":"chat.completion.chunk","created":1692261669,"model":"gpt-3.5-turbo-0613","choices":[{"index":0,"delta":{"role":"assistant","content":""},"finish_reason":null}]}

data: {"id":"chatcmpl-***, underlying error: Unexpected Content-Type header: text/event-stream
2023-08-17 17:41:12.056097+0900 OpenAPITest[69661:8827643] Swift/ErrorType.swift:200: Fatal error: Error raised at top level: Client error - operationID: createChatCompletion, operationInput: Input(path: OpenAPITest.Operations.createChatCompletion.Input.Path(), query: OpenAPITest.Operations.createChatCompletion.Input.Query(), headers: OpenAPITest.Operations.createChatCompletion.Input.Headers(), cookies: OpenAPITest.Operations.createChatCompletion.Input.Cookies(), body: OpenAPITest.Operations.createChatCompletion.Input.Body.json(OpenAPITest.Components.Schemas.CreateChatCompletionRequest(model: OpenAPITest.Components.Schemas.CreateChatCompletionRequest.modelPayload(value1: nil, value2: Optional(gpt-3.5-turbo)), messages: [OpenAPITest.Components.Schemas.ChatCompletionRequestMessage(role: system, content: "You are the world no1 progrrammer", name: nil, function_call: nil), OpenAPITest.Components.Schemas.ChatCompletionRequestMessage(role: user, content: "Please write fizzbuzz", name: nil, function_call: nil)], functions: nil, function_call: nil, temperature: nil, top_p: nil, n: nil, stream: Optional(true), stop: nil, max_tokens: nil, presence_penalty: nil, frequency_penalty: nil, logit_bias: nil, user: nil))), request: path: /chat/completions, query: <nil>, method: HTTPMethod(value: OpenAPIRuntime.HTTPMethod.(unknown context at $1001d7918).OpenAPIHTTPMethod.POST), header fields: [accept: application/json, content-type: application/json; charset=utf-8], body (prefix): {
  "messages" : [
    {
      "content" : "You are the world no1 progrrammer",
      "role" : "system"
    },
    {
      "content" : "Please write fizzbuzz",
      "role" : "user"
    }
  ],
  "model" : "gpt-3.5-turbo",
  "stream" : true
}, baseURL: https://api.openai.com/v1, response: status: 200, header fields: [openai-organization: user-***, Date: Thu, 17 Aug 2023 08:41:09 GMT, x-ratelimit-limit-tokens: 90000, Content-Type: text/event-stream, cf-ray: ***-***, Server: cloudflare, Cache-Control: no-cache, must-revalidate, x-ratelimit-remaining-tokens: 89968, Alt-Svc: h3=":443"; ma=86400, openai-processing-ms: 6, x-ratelimit-reset-tokens: 21ms, x-ratelimit-remaining-requests: 3499, openai-version: 2020-10-01, Strict-Transport-Security: max-age=15724800; includeSubDomains, Access-Control-Allow-Origin: *, x-ratelimit-limit-requests: 3500, x-request-id: ***, cf-cache-status: DYNAMIC, x-ratelimit-reset-requests: 17ms], body: data: {"id":"chatcmpl-***","object":"chat.completion.chunk","created":1692261669,"model":"gpt-3.5-turbo-0613","choices":[{"index":0,"delta":{"role":"assistant","content":""},"finish_reason":null}]}

data: {"id":"chatcmpl-***, underlying error: Unexpected Content-Type header: text/event-stream
(lldb)

Hi @SokichiFujita,
I took a look, and there are a few things interacting here.

Neither OpenAPI 3.0.3 nor 3.1.0 explicitly support SSE. However, that doesn't mean that you can't successfully document APIs that stream response bodies.
The OpenAI OpenAPI document seems incomplete. When you pass "stream": true in the request, it returns the content type text/event-stream, but that content type isn't documented in the OpenAPI document. For example, in the createChatCompletion operation, they should add something like:

responses:
  "200":
    description: OK
    content:
      application/json:
        schema:
          $ref: "#/components/schemas/CreateChatCompletionResponse"
+      text/event-stream:
+        schema:
+          type: string
+          format: binary

Once that do that, you will get a new case generated in the Output enum for the binary data. You can then process that raw data according to OpenAI's instructions, such as to split the data by empty newlines, then taking each JSON event and decoding the event using JSONDecoder, etc. But you'll have to do that manually, since there's no way to express this pattern in OpenAPI, so the generator can't really help much here.
However, for now, you'll get a buffered data blob, until we address #9, which is planned for next month - at which point, you'd be able to fully asynchronously stream the data and parse it as it comes in.
To summarize:

OpenAI (or you, locally) need to update the OpenAPI document to include the second content type they return when "stream": true, and document the returned payload as binary data.
You then need to further process the raw data by splitting it into individual events, and parsing the JSON of those events (hopefully the events are documented in the OpenAPI document, so you can use one of the generated Codable types).
Finally, once we address #9, you'll be able to fully asynchronously stream those events into your program, instead of waiting for the response to return all the data and getting back the full buffer (which happens today).

Hope this helps!

There are some OSS Swift libraries for parsing the Server-side Events/EventSource format, which you could use to parse the stream and get the individual events out, which you can then feed into JSONDecoder, again for example when the event format is described by the CreateChatCompletionStreamResponse schema.
Closing this issue, but I'll file a new one to document how to document an SSE endpoint in OpenAPI.

Added this pattern to our docs: https://github.com/apple/swift-openapi-generator/pull/208

Thank you the very helpful quick response. I understand the situation and plan.
Regarding SSE, OpenAI does not provide the schema in the document. But they uses only simple data: JSON_STRING  (does not use id: or event:) and the stop word is data: [DONE]. During developing a macOS AI app, I wrote the stream parser for URLSession based private OpenAI API client. So the parser will be able to use in the future.
ThenI will try to replace my client with generated code by swift-openapi-generator if the async byte stream is supported.
Thank you.

I just tried and this worked well with manual parsing. For now this solution seems to be enough for me. Thanks.
openapi.yaml
  /chat/completions:
    post:
      operationId: createChatCompletion
      tags:
        - OpenAI
      summary: Creates a model response for the given chat conversation.
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: "#/components/schemas/CreateChatCompletionRequest"
      responses:
        "200":
          description: OK
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/CreateChatCompletionResponse"
          content:
            text/event-stream:
              schema:
                type: string
                format: binary
                $ref: "#/components/schemas/CreateChatCompletionStreamResponse"

A part of response:
Ok(headers: OpenAPITest.Operations.createChatCompletion.Output.Ok.Headers(), body: OpenAPITest.Operations.createChatCompletion.Output.Ok.Body.text("data: {\"id\":\"chatcmpl-***\",\"object\":\"chat.completion.chunk\",\"created\":1692339765,\"model\":\"gpt-3.5-turbo-0613\",\"choices\":[{\"index\":0,\"delta\":{\"role\":\"assistant\",\"content\":\"\"},\"finish_reason\":null}]}\n\ndata: {\"id\":\"chatcmpl-***\",\"object\":\"chat.completion.chunk\",\"created\":1692339765,\"model\":\"gpt-3.5-turbo-0613\",\"choices\":[{\"index\":0,\"delta\":{\"content\":\"Sure\"},\"finish_reason\":null}]}\n\n

Ah interesting - I didn't realize we generate a String underlying type for the bytes, not raw data (because the MIME type starts with text/). Added a note to #9 that we might need to consider streaming not just raw bodies, but also (at least some) text bodies.

Yes, for the type: string, there are several values of the correspondent format like text(if format is not defined), binary, byte, date,... It's little bit complex.
https://swagger.io/docs/specification/data-models/data-types/#object

Right, in this case we derive the underlying raw type not from the JSON schema, but from the content type. So even if you did
text/event-stream: {}

you'd get the same generated code.

FYI #494


[Unexpected Behavior] USB Joystick Adapter - not showing up in devices - osx Catalina

What you're using
macOS Catalina Version 10.15.5
Running the Latest Build [5.3 Alpha 4.6] (though I did not get this to function properly otherwise).
Running "Stepmania.app" after giving permissions using "xattr -dr com.apple.quarantine /Applications/Stepmania-Outfox-Alpha-4.6.0-MacOS-date-20200711/StepMania.app"
Expected behavior
Outfox ought to recognize USB controller adapter as it does others, but fails to populate "Test Input" menu.
Current behavior
Terminal debug window displays message acknowledging USB controller connect; also does not recognize button inputs in Mapping Menu / Test Input Menus. Debug window outputs message when controller is plugged in:
"OutFox Engine (SDL Input Debug) - Joystick Added For Mapping 02 (DragonRise Inc. Generic   USB  Joystick  )"
My USB controller (Reyann Zero Delay Arcade USB Encoder https://www.amazon.com/gp/product/B00UUROWWK/ref=ppx_yo_dt_b_asin_title_o00_s01?ie=UTF8&psc=1).
Program Registers / accepts inputs from other USB joysticks fine; other programs recognize input from "Reyann" Controller fine (why i figured this qualified as a bug and not a tech support issue).
This is my first bug - forgive me if I need to make some sort of correction in reporting etiquette / standards.

You will need to use the SDL Tool and add a mapping for the controller before it can work on Mac OSX. You do not have a bad device, but the mapping is likely wrong for your pad.
If you need help on mapping the pad, or have any other questions, join our discord and ping Squirrel and I'll help you. I will leave this open until Alpha 5.0.0.

Hello @cmhoneycutt343
Project Moondance Discord Moderator here, a while ago we created a bug hunter system, users who make issue on this repository gain points and can be rewarded in our discord, so I'm here to ask, are you in Project Moondance discord?
If not, you can join using this link: https://discord.gg/3DgsbSg
If you don't wish to join, that's okay. Please be sure to contact any moderator if you join.

This one was fixed with the user in Discord, Glad you're able to enjoy the game!


other taxa this name proposed

Delivers Pivotal #155310823 as revised by the comments therein.

Fixes exclude_consensus search parameter
Tests all combinations of exclude_consensus, include_all_name_proposals (formerly include_nonconsensus), and include_synonyms.
Eliminates links (in "Observations of" areas of show_name and show_observation pages) to "Other Taxa, this name proposed"
Updates Parameter Search and Search Help

Note: We decided to eliminate the code which provoked the bug, rather than attempt a complicated re-write to support a search for which there was a weak, or no legitimate, use case. See Slack discussion.
Manual Testing

Go to any Name or Observation Page. Result:

There is no link to "Other Taxa, this name proposed" or the equivalent
There is a link to all Observations where the name was proposed

Goto http://localhost:3000/observer/search_bar_help.

Result: it includes descriptions of exclude_conensus, include_all_name_proposals.

On any page:

Paste name:"hydnum neorepandum" exclude_consensus:yes include_all_name_proposals:yes into the Search Bar Window
Select Observation, click Search
Result: All Observations where H. neorepandum was Proposed, but is not the consensus.

Coverage decreased (-0.03%) to 91.8% when pulling 6fa4cecfd903c1ec9ec4c008840d989fbded18b8 on JoeCohen:155310823-other-taxa-this-name-proposed into a9ed036c6fb5c032bd61a6bd607bd9fb151bf01c on MushroomObserver:master.

I think you might need to do
@where = ["FALSE"]
but yes, that should be fine.
On Wed, Jul 17, 2019 at 3:43 PM Joseph D. Cohen<EMAIL_ADDRESS>wrote:

@JoeCohen commented on this pull request.
In app/classes/query/modules/conditions.rb
https://github.com/MushroomObserver/mushroom-observer/pull/501#discussion_r304609436
:

@@ -163,6 +171,10 @@ def add_has_notes_fields_condition(fields, *joins)
add_joins(*joins)
end

 def add_false_condition(col)

   @where << "#{col} = FALSE"

Can I get away with:
@where = FALSE
Makes things a little simpler for mySQL. But can it mess things up? I.e.,
is there ever a case where there are no Observations but there are results?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/501?email_source=notifications&email_token=AAYTNNLSVWERSN2MN6FDW7LP75Y7JA5CNFSM4ID4DYE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6YUJXA#pullrequestreview-263275740,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYTNNIET4LUPN7R47WI4KDP75Y7JANCNFSM4ID4DYEQ
.

I think this is still ready for review/merge despite the supposed coverage issue. There are no newly missed lines.
Also I am effectively gone until Tuesday.

I think this can be merged because there are no newly uncovered lines (despite the coverage decrease). Coveralls says:

37 of 37 new or added lines in 5 files covered. (100.0%)
182 existing lines in 4 files now uncovered.

See https://coveralls.io/builds/24791698

Works for me.  I think this is ready to merge soon as the tests pass (and
they do now, right?)
On Thu, Jul 25, 2019 at 10:12 AM Joseph D. Cohen<EMAIL_ADDRESS>wrote:

I think this can be merged because there are no newly uncovered lines
(despite the coverage decrease). Coveralls says:
37 of 37 new or added lines in 5 files covered. (100.0%)
182 existing lines in 4 files now uncovered.
See https://coveralls.io/builds/24791698
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/501?email_source=notifications&email_token=AAYTNNIBBEF3VAQZBTKBYJLQBGYFJA5CNFSM4ID4DYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ZTCSY#issuecomment-515060043,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYTNNOCUD23SXVYFOKEMYDQBGYFJANCNFSM4ID4DYEQ
.

Right. The test suite (Travis CI build) passes. https://travis-ci.org/MushroomObserver/mushroom-observer/builds/563563577

Hooray!
On Thu, Jul 25, 2019 at 10:26 AM Joseph D. Cohen<EMAIL_ADDRESS>wrote:

Right. The test suite (Travis CI build) passes.
https://travis-ci.org/MushroomObserver/mushroom-observer/builds/563563577
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/501?email_source=notifications&email_token=AAYTNNP6MVLPNDX42UAU5ETQBGZYVA5CNFSM4ID4DYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ZUNWQ#issuecomment-515065562,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYTNNLRJXILDR5KC7DYFZDQBGZYVANCNFSM4ID4DYEQ
.


Improve performance of SplitLocale

This improves performance and makes the code more readable.
Benchstat:
goos: linux
goarch: amd64
pkg: github.com/fyne-io/go-locale
cpu: Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz
              │   old.txt    │              new.txt               │
              │    sec/op    │   sec/op     vs base               │
SplitLocale-8   119.75n ± 1%   20.55n ± 1%  -82.84% (p=0.002 n=6)

              │  old.txt   │              new.txt              │
              │    B/op    │   B/op     vs base                │
SplitLocale-8   64.00 ± 0%   0.00 ± 0%  -100.00% (p=0.002 n=6)

              │  old.txt   │              new.txt               │
              │ allocs/op  │ allocs/op   vs base                │
SplitLocale-8   2.000 ± 0%   0.000 ± 0%  -100.00% (p=0.002 n=6)

Closing in favour of https://github.com/jeandeaual/go-locale/pull/23


Documentation updates

Add note about secrets and CC

@bot-gradle test and merge

I've triggered a build for you.


Request: non-sticky diff editor window

I noticed VS Code User Voice portal has been deprecated and redirects here, so:
Scenario:

setup VS Code so to show differences in files side by side
make some changes to a versioned project
go to Source Control pane
start clicking on several changed files

Actual behavior:
Any clicked files opens a new diff editor window, which stay open. After clicking through some changed file, there's a whole lot of opened diff windows hanging around.
Desired behavior:
Have a setting available in VS Code deciding whether diff editor windows should remain open (sticky) or not. When option is "sticky", everything stays the same as now. When option is "not sticky", clicking through different changed files should be the same as clicking through files in explorer pane: only the last clicked diff should be visibile as an editor.
Thanks!

#26184


[core-paging] add to-elements method

Packages impacted by this PR
core-paging
Issues associated with this PR
Describe the problem that is addressed by this PR
In many cases (app-configuration for example), the page is not a list of elements, and we need an iterator over elements.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Added an optional function to-elements to extract elements from a page
Are there test cases added in this PR? (If not, why?)
To be added
Provide a list of related PRs (if any)
https://github.com/Azure/azure-sdk-for-js/pull/23333
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-core-paging


Switched to rh-sourced prometheus images

quay.io/openshift /origin-prometheus:4.1.0 for Maistra
registry.redhat.io/openshift4/ose-prometheus:v4.1.0-201905191700 for Service Mesh

Closing, as we are going to build our own prometheus images.


flutter run -d server fails when Chrome not present

I'm in the process of attempting to run Flutter tooling alongside the VS Code in the Cloud product code-server. I can install the flutter tooling, change to master, upgrade, and set the config to enable web, but then attempting to run just the server fails.
$ flutter doctor --verbose
[✓] Flutter (Channel master, v1.10.4-pre.72, on Linux, locale en_US.UTF-8)
    • Flutter version 1.10.4-pre.72 at /home/coder/flutter
    • Framework revision 4c724b9b7d (2 hours ago), 2019-09-18 21:48:41 -0400
    • Engine revision 7f7250f476
    • Dart version 2.6.0 (build 2.6.0-dev.1.0 cb80ea7ba9)

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/setup/#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, set ANDROID_HOME to that location.
      You may also want to add it to your PATH environment variable.

[✗] Chrome - develop for the web (Cannot find chrome executable at google-chrome)
    ! CHROME_EXECUTABLE not set

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/setup/#android-setup for detailed instructions).

[✓] Connected device (2 available)
    • Chrome • chrome • web-javascript • unknown (unsupported)
    • Server • web    • web-javascript • Flutter Tools

! Doctor found issues in 3 categories.
$ flutter config
Configure Flutter settings.

[Elided help output - bjm]

Settings:
  enable-web: true

Analytics reporting is currently enabled.
$ flutter run -d server
Unable to locate a development device; please run 'flutter doctor' for information about installing additional components.

The device id is called web - perhaps I should change the name from Server to Web to make it more apparent?

Hmm, my command line disagrees with you.
$ flutter run -d web
Unable to locate a development device; please run 'flutter doctor' for information about installing
additional components.

Oh, I see the issue:

• Chrome • chrome • web-javascript • unknown (unsupported)

You need @DanTup 's fix at https://github.com/flutter/flutter/pull/40757

Yeah, this is the same issue I saw on GitPod - the web workflow is disabled when Chrome is not available. I'll try and figure out the test failures on that PR this morning so I can get it landed.

Similar issue in Manjaro Linux platform. Chrome defaults to google-chrome-stable, the SDK is unable to find google chrome executable.

@bparrishMines I think  your issue is a little different - @domesticmouse was passing -d server which is to use the headless server (doesn't launch a browser). This isn't really what you want, as it disables significant functionality. I think you should raise a new issue if Chrome's executable isn't named chrome on your platform.

@bprayush I think your issue is a little different - @domesticmouse was passing -d server which is to use the headless server (doesn't launch a browser). This isn't really what you want, as it disables significant functionality. I think you should raise a new issue if Chrome's executable isn't named chrome on your platform.

Okay.

Similar issue in Manjaro Linux platform. Chrome defaults to google-chrome-stable, the SDK is unable to find google chrome executable.

I had this same problem in manjaro, if you installed by AUR run the following command
$ export CHROME_EXECUTABLE=/opt/google/chrome/chrome
and then
$ flutter doctor
Result:
(base) [felipe@datacrypto-analytics ~]$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 1.25.0-8.3.pre, on Linux, locale pt_BR.utf8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Chrome - develop for the web
[!] Android Studio (not installed)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

Similar issue in Manjaro Linux platform. Chrome defaults to google-chrome-stable, the SDK is unable to find google chrome executable.

I had this same problem in manjaro, if you installed by AUR run the following command
$ export CHROME_EXECUTABLE=/opt/google/chrome/chrome
and then
$ flutter doctor
Result:
(base) [felipe@datacrypto-analytics ~]$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 1.25.0-8.3.pre, on Linux, locale pt_BR.utf8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Chrome - develop for the web
[!] Android Studio (not installed)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.


Incompatible with sequelize 6.0.0-beta.6

Versions

sequelize: 6.0.0-beta.6
sequelize-typescript: 1.1.0
typescript: 3.9.2

I'm submitting a ...

[ ] bug report
[x] feature request
Actual behavior:

2322 Type 'typeof MyClassName' is not assignable to type 'Includeable'.   Type 'typeof MyClassName' is not assignable to type 'typeof Model'.     Types of property 'init' are incompatible.       Type '(attributes: ModelAttributes<Model<any, any>>, options: InitOptions<Model<any, any>>) => void' is not assignable to type '<M extends Model<any, any> = Model<any, any>>(this: ModelCtor<M>, attributes: ModelAttributes<M>, options: InitOptions<M>) => Model<...>'.
Expected behavior:

sequelize-typescript must be compatible with sequelize 6.0.0-beta.6 or higher

Just created PR #787 to solve this. Please give that a try and report your results.


TypeError: init() got an unexpected keyword argument 'episode_length'

/home/smilewater/anaconda3/envs/tensorflow-gpu/lib/python3.6/site-packages/h5py/init.py:34: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
Using TensorFlow backend.
Traceback (most recent call last):
File "dqn_agent.py", line 129, in
environment = SpreadTrading(spread_coefficients=[1], data_generator=generator, trading_fee=trading_fee, time_fee=time_fee, history_length=history_length, episode_length=episode_length)
TypeError: init() got an unexpected keyword argument 'episode_length'

remove episode_length from line no. 126


Fix for Shortcut Guide appears only on primary monitor #607

Summary of the Pull Request

References

PR Checklist

[x] Applies to https://github.com/microsoft/PowerToys/issues/607

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: PrzemyslawTusinski sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Great work!
Adding support for multi-monitor revealed other issues with the current implementation that needs to be made more multi-monitor aware and not assume that the screen is always the same/the primary.
Taskbar shortcuts location and the fade-in animation are effected by this.
We'll open issues to track the work to complete the multi-monitor support.
Some of the code will have to be refactored and unit tests will have to be added.


docs: add documentation

Guides / useful links

https://guides.lib.berkeley.edu/how-to-write-good-documentation
https://www.madcapsoftware.com/blog/write-code-documentation/
Python: https://realpython.com/documenting-python-code/
React: https://react-styleguidist.js.org/docs/documenting/

Documentation for code base - across many repos
repos:

DMSS
dm-core-packages
dm-job
dm-cli
dm-docs

Rules:

When starting on an issue, add your name to it with @ + name.
when creating a PR, link the issue to relevant task with # + PR number
After completing an issue (merged PR), check the relevant box

Example:

[ ] Add documentation for function foo(). #903 @KristianKjerstad

bonus task
Find out how to document decisions made in meetings.

A separate page in dm-docs?
somewhere on github?
external file in SharePoint?

sub tasks
DMSS

[ ] endpoints - explanation of parameters and what the end point does

[ ]  attribute_feature.py

[ ] blob_feature.py

[ ] blueprint.py

[ ] document.py

[ ] entity.py

[ ] export.py

[ ] file.py

[ ] lookup_table.py

[ ] meta.py

[ ] personal_access_token.py

[ ] reference.py

[ ] search.py

Add docstrings to various classes and functions in the dmss repo

[ ] ?

dm-core-packages
Good documentation for a plugin includes:

what features are available

how to use the plugin

[ ] For react components in folders:

[ ] dm-core

[ ] example

[ ] blueprint-hierarchy

[ ] blueprint

[ ] explorer

[ ] file

[ ] form

[ ] grid

[ ] header

[ ] job

[ ] json

[ ] list

[ ] pdf

[ ] table

[ ] view_selector

[ ] yaml

dm-job

[ ]

dm-cli

[ ] validation

[ ] add docstring to cli commands:

[ ]  reset

[ ]  create-lookup

[ ]  import-plugin-blueprints

[ ]  ds import

[ ]  ds import-all

[ ]  ds init

[ ]  ds reset

[ ]  entities delete

[ ]  entities import

[ ]  export

[ ]

dm docs

[ ] Go through the dm docs and clean up things that are wrong

[ ] add search bar to docs page

[ ] explanation of address syntax - info about the DataSOurce/$uid syntax, how we select attributes of an object (. syntax), how we extract data from lists (DS/$uid.list[2]), how the .^ syntax works relative references (./document)

[ ] how the look-up table works in DMSS. see http://localhost:8082/db/dmss-internal/data_sources/"data-source-name"

[ ] references

[ ] link reference

[ ] storage reference

[ ] concept: primitive vs complex types

[ ] concept: modeling. All features that are available for modeling: what are the primitive types, all blueprints and entities must have a type, how to define lists, storage/model contained, storage/model uncontained.

[ ] what the package.json file is for in local folders is for.

[ ] concept: ui plugins, ui recipes, initialUiRecipes. How are ui recipes uploaded to dmss?

[x] overview of all repos related to development framework. Just add a list with links + maybe 1-2 sentences for each about what they are for.

[ ] Dictionary of different concepts/ things : Address, reference, resolve reference, Tree, Node, etc

For later:
go through dm-docs and cleanup, fix things that are wrong

we should avoid duplicating docs in both readmes in the repos and in dm-docs


Update libs.versions.toml

log4j zero day is long gone and the project is in stabler versions

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks! the version needs to be put in double quotes

i am sorry, dint realize then :(

Thanks @shekarroy15 ! 😎


fix(sdk-node): Allow Defining Sampler with Exporter in Env

Which problem is this PR solving?
Previously if the exporter was defined via the environment, any configured values like samplers would not be read from the NodeSDK configuration. By updating the check we allow for those configurations to be read even if the traceExporter/spanProcessor is not defined directly in the NodeSDK configuration.
Fixes # (issue)
#4212
#4004
Short description of the changes
Modies the SDK such that if the trace exporter is configured via the environment we still create/configure the tracerProvider.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Tested locally using a sample application to confirm that the changes allow the sampler to be read from the NodeSDK configuration even when the exporter is not defined outside of the environment.
Also added a test to ensure that when the exporter is defined in the environment that the appropriate tracerProvider is created.
Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added
[ ] Documentation has been updated

I had another look, as I was wondering how this affects the setup when

a sampler is configured manually
an exporter is configured via the environment

and now it looks like the sampler is configured, but the exporter is not. @JacksonWeber would you mind having another look to verify? I think we'd want the config to merge so that the exporter is configured via the environment, but the sampler is set to what's passed to NodeSDK.

Took a look into this. You were correct that it would ignore the configured exporter. I've updated the logic to use a TraceProviderWithEnvExporters in the case that the OTEL_TRACES_EXPORTER is defined, even if the rest of the configuration options are populated manually.


refactor(connector-besu): common interface invoke-contract

Resolve #609
Signed-off-by: AzaharaC<EMAIL_ADDRESS>

Timeout in the tests, we need to review the testing pipeline this is happening for most new PRs
@petermetz

Timeout in the tests, we need to review the testing pipeline this is happening for most new PRs
@petermetz

@kikoncuo Please up-vote my PR(s) on the mailing list, hopefully the fix will get fast tracked for approval :-) (sent out the email just a few hours before your comment)


I updated to Angular 2.0.1 and nothing seems to be broken

**I'm submitting an information (not an issue)
Current behavior
I updated to Angular 2.0.1 and nothing seems to be broken
What is the expected behavior?
Update package.json ? do you want i test something ?

**ng2-translate version:**2.5.0

Angular version: 2.0.1

Browser: Chrome

**Language:**TypeScript 2.0.3

Why do you want to change anything ? The peer dependencies are correct:
"peerDependencies": {
    "@angular/core": "~2.0.0",
    "@angular/http": "~2.0.0"
}

I updated to angular to 2.0.1 and nothing was broken indeed, but update ng2-translate to 3.0.0 has broken the systemjs loader.

I had the same issue here but if you point to the bundle in SystemJS, make sure you use the correct key.
paths: {
    'ng2-translate/ng2-translate': 'node_modules/ng2-translate/bundles/ng2-translate.js'
}

It's important you use ng2-translate/ng2-translate.
Another option is to just use ng2-translate but to make sure you import from ng2-translate instead.
import { TranslateService } from 'ng2-translate`;

Does that work?

I have the same problem, SystemJS reports an error "Unexpected token <" when loading module on require("ng2-translate/ng2-translate") inside compiled .js file.

Ok both solutions work thank you SamVerschueren, I put the alternative for people who did like this:
In your jspm config file:
paths: {       // paths serve as alias       'npm:': 'node_modules/'     },
map: {     'ng2-translate': 'npm:ng2-translate/bundles/ng2-translate.js'   }
and in your sources files:
import { TranslateService } from 'ng2-translate'

Thanks, I need to update the docs

Done: next time you can check out the plunkr which I'll keep updated


Ability to use the signed in OAuth token in Software Templates

Here's a draft start of how we can solve secrets in Software Templates and the scaffolder-backend.
This just solves the secret context in the frontend, and it's still not finished yet.
Also the backend work is not started yet.
Closes #7684

This PR is going to be replaced by 3 PR's.

#8576
#9038
Collect Secrets from the frontend form and customFieldExtensions

Things are looking pretty merged, close? :grin:

Updated the list above now with the last PR, so we can move everything there now. Closing!


resoultion

The toast messages showing the image resolution are not correct. I will try to fix it. Also it seems that 1080x1920 works for me when the app asks for 2840x2160 but the ratio is the same if you divide the numbers. When you take the picture the apps collapse because every app makes a request to the camera api with a different resulotion thats why the toast messages were helpful but since they are wrong we need to check what is the resolution that the app needs. im guessing that will work. not sure though

@karmaisback1 my telegram... text me to fix together


gasLimit should be hardcoded at constants.ts

Currently we hardcode gasLimit to be 500,000
https://github.com/api3dao/airnode/blob/3d59a9dd1bd78da4c1cad83ad2e16a81cf4cdf40/packages/node/src/evm/fulfillments/api-calls.ts#L17
We also have a constants file
https://github.com/api3dao/airnode/blob/3d59a9dd1bd78da4c1cad83ad2e16a81cf4cdf40/packages/node/src/constants.ts
This variable should be defined in the constants file.

Tracked by https://api3dao.atlassian.net/browse/AN-136


Partially fixes not being able to find indexes

I stumbled in a problem today: I was not able to find elements such as user[0][name], even when I escaped it. That was the cause and I made this little change so It could work. You won't be able to search for an element's ID, though.
Not a full fix, but will help some people.

If it's not a full fix let's rethink it.


Add href field to ErrorInformation

LGTM 👍 But there are a few weird code formatting things going on in this PR (but I'm no iOS expert) 😅 Do you have any linter in the project that makes sure the code looks good? If not then maybe it'd be a good idea to add one? 😉

there is an external tool called swiftlint but it's not used in this project. I don't if it's even possible to add it to Xcode IDE when we have the project configured as a Swift Package Manger. I'll try to add it as a pre-commit hook in another PR. I


Merge version1.2 to main

Merge VPC changes from Version1.2 branch to main

VPC config changes LGTM. @kingman Please review delete doc changes

The delete script changes LGTM


reconcile: allow atomic reconciliation of release

Last commit is in need of some additional documentation. In addition, I need to compile a list of rendered event/conditions to ease reviewing.

Hi @hiddeco, is this PR related to solve https://github.com/fluxcd/helm-controller/issues/186?

It is in preparation of, but not solving it by itself.

Thanks, @kingdonb 🤝  happy new year! 🍾🥳

Merging this as the CI failure is something that will be addressed by rewriting the actual wiring of the HelmRelease reconcilers, and the Go tests pass.


User feedback is important! 👩🏻⚖

Added the /feedback command handler and it's working pretty fine.

Fixes #36


Change first day of week through props.

Hi there.
Would just like to start by saying great package. :+1: Been looking for a pure React calendar component. All other calendars have been using bootstrap or some other frameworks.
I would really like to change the first day of week without changing global moment locale. This is a deal breaker for our company. I created this patch, but feel free to change the implementation.
:smile:

Great :) thanks @CarlRosell

https://github.com/Adphorus/react-date-range/releases/tag/v0.1.8

Thanks :smile:


KAFKA-17874: Avoid the extra bytes copy when compressing telemetry payload

Avoid using AbstractMessageLite to initialize bytes with serialized size, it can lead to adding extra bytes.
Instead, ByteArrayOutputStream is used for the buffer capacity, which is initially 32 bytes, though its size increases if necessary.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@chia7712 @apoorvmittal10
Could you review the PR, please?
I welcome your feedback.


Get 1.0.0 out

Thoughts on this? We almost have ES2016 at this point.

I'd hoped to make it more modular first so that v1.0.0 would collect a bunch of breaking changes at once, but that's OK to do in a v2.0.0.
I would like to drop bower and component support as part of v1 at least, as well as start with a fixed tagging scheme.

It would be good, because on projects like Angular 2 that allow minor version upgrades it can be upgraded. Now it is not possible because of pre 1.0 version.

@blacksonic it should still work fine if using ^, which for < 1.0 releases upgrades the patch version (which is the only nonbreaking thing that can be updated pre-1.0)

Yes i just realized that minor version changes pre-1.0 are actualling breaking changes


Stabilize benchmarks

Previous discussion: https://github.com/mizdra/eslint-interactive/issues/202
We want to be able to more accurately identify performance degradation/improvement.
Perhaps it would be a good idea to adopt the methods described in the following article.

https://pythonspeed.com/articles/consistent-benchmarking-in-ci/

ref: https://github.com/search?q=setarch+uname+-m+-R+path%3A.github%2Fworkflows&type=code


Profile creation - signuature toasts

design

updated in https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=9705-14201&t=9GbSkL2xREJSKk5Z-11
new 2 types of toast notifs - in progress, confimed
please use these two only for the profile creation, the confirmed one can be moved somewhere else
it will replace the steps when you click the save profile - then there is the loading modal and the confirmation modal

essential

the main reason to do this, is because user waits on the profile modal for some time, with this, it will be completed in background. No signature is needed, so why put a big modal in the middle of screen.

dark mode

- otherwise follow the rules of color pairing
nominating @hassnian

failed toast


OpenAPI Allow Multiple API Keys

Currently there seems to only be a single key allowed when using API key. It would be great to allow multiple keys like https://swagger.io/docs/specification/authentication/api-keys/#multiple. I've tried adding two structs like below:
#[derive(SecurityScheme)]
#[oai(type = "api_key", key_name = "X-API-Key", in = "header")]
struct Key(ApiKey);

#[derive(SecurityScheme)]
#[oai(type = "api_key", key_name = "X-API-Secret", in = "header")]
struct Secret(ApiKey);

and passing them into the API as below:
    #[oai(path = "/route1", method = "get")]
    async fn route1(
        &self,
        key: Key,
        secret: Secret,
    )

But the secret overwrites the key. It would be amazing if there was a way of passing this in as a tuple. Something like
#[oai(type = "api_key_multiple", key_name = ("X-API-Key", "X-API-Secret"), in = "header")]

I have tried to copy and alter this file https://github.com/poem-web/poem/blob/master/poem-openapi/src/auth/api_key.rs but base is private

Works perfectly.


Fix issues with hashchange in subscriptions modal.

The fixes are detailed in the commit message.
There were mainly two bugs,

Opening the Subs Modal would cause a number of unnecessary hashchanges (#streams/all -> #streams/subscribed -> #streams/all).
https://chat.zulip.org/#narrow/stream/9-issues/subject/slow.20subscriptions.20modal/near/617326
The behaviour of clicking the main stream settings button changes after opening it from a streams popover.

Can you make this two commits, one for each of the two bugs, with each one detailing why it's correct and what bug it fixes?  Basically I think you have all the info here in the PR description and commit message, but it's not organized in the ideal way for future spelunkers to understand why we did this.

@timabbott Fixed.

@timabbott No, it's to change the default thing (#streams), so you have to specify exactly where you want to go (All or Subscribed). The gear menu URL is already correct #streams/all.

I meant the "Manage streams" entry in the upper-right gear menu.


nuxt.com throwing errors

Environment
production
Reproduction
https://nuxt.com/docs/getting-started/installation
Describe the bug

Additional context
No response
Logs
No response

Closing in favor of https://github.com/nuxt/nuxt.com/issues/1569


Autocomplete adds the column name to the existing column, rewriting it partially (resulting in a wrong query), rather than replacing the whole column name

Description
Use Ctrl + Space:
https://github.com/dbeaver/dbeaver/assets/33929221/56595d0c-081b-45d7-b81a-744e3846bc4b
DBeaver Version
Community Edition 24.1.2

thanks for the report

Similar issue:
https://github.com/dbeaver/dbeaver/assets/33929221/1ccee8bb-3f99-4f22-9c17-a299b9c10ee1

Perhaps this problem has escaped your attention.
Just a small reminder...
Could you kindly consider adding it to some upcoming milestones?
This issue is quite painful, because it makes difficult to use autocomplete and type queries.

Thank you for drawing our attention to it


Bad connection string rewrite on DB change

The connection string is badly rewritten on DB change when no database was specified for the current connection:

Connect without specifying a database name
On the top left, change to another database
The change fails

It appears that the connection string has a path of /. And the function that rewrite it will replace the first slash that follows the scheme. So we got a connection string that looks like this:  Changed Url: postgres:/newdbname/user:pass@<IP_ADDRESS>/?sslmode=disable
I'll submit a PR right away for this issue.

Fixed in master.


Allow the Kestra API schema in VSCode to be applied only to selected folder(s) e.g. the  "_flow" folder (rather than to all YAML files)

I try to fallow this note in the documentation to limit kestra:/flow-schema.json only to _flows folder in my workspace.

But nothing is working.
I need to deinstall this extension because in my workspace I also have other types of json and yaml files.
Could someone geve some better explanation how to properly configure vscode and limit kestra:/flow-schema.json to be applied only to specific yaml files or specific folders and not to whole workspace.

thanks so much for reporting it, we will look into this soon

@brian-mulier-p, can you estimate whether this can be easily done or is a more complex issue?

Looks easy but not sure when I'll be able to have a look

Hi, you can now add a configuration in your settings.json that allows you to provide a regex to match for the schema to be apply: kestra.schema.match-path
For example, the following configuration :
"kestra.schema.match-path": "_flow"

will only match files that have "_flow" in their path

FYI: I extended the documentation a bit https://github.com/kestra-io/vscode-kestra/commit/fba7711b440b25ffe96d3a815c196f13b4664359


parse getMarketplaceData into friendly "human" values

The getMarketplaceData() helpers return hexadecimal data that must be parsed into friendly "human" values.

now return an object like :
{
  owner: '5DAAnrj7VHTznn2AWBemMuyBwZWs6FNFjdyVXUeYum3PTXFy',
  kind: 'Public',
  commissionFee: { percentage: 12 },
  listingFee: { flat: '13.0000 CAPS' },
  accountList: [ '5Cf8PBw7QiRFNPBTnUoks9Hvkzn8av1qfcgMtSppJvjYcxp6' ],
  offchainData: 'testing purpose'
}

vs before :
{
  owner: '5DAAnrj7VHTznn2AWBemMuyBwZWs6FNFjdyVXUeYum3PTXFy',
  kind: 'Public',
  commissionFee: { flat: '0x00000000000000000de0b6b3a7640000' },
  listingFee: { percentage: 10000 },
  accountList: [ '5Cf8PBw7QiRFNPBTnUoks9Hvkzn8av1qfcgMtSppJvjYcxp6' ],
  offchainData: '0x74657374696e6720707572706f7365'
}

Let's confirm flat format is right

Nice humanization, maybe we can remove CAPS unit from the flat value like we are doing on event classes (e.g. listingFee: { flat: '13.0000' }


initialize_all_variables is deprecated

for the code  of tf14 and tf15
WARNING:tensorflow:From full_code.py:62 in .: initialize_all_variables (from tensorflow.python.ops.variables) is deprecated and will be removed after 2017-03-02.
Instructions for updating:
Use tf.global_variables_initializer instead.

Thanks, I've updated all codes


Fixing issues with String.format() for floats and fling gestures

Please review and accept my changes. The library did not work when I switched the system language to Russian or Polish (or probably French and others that use decimal comma instead of dot). Plus fling gesture for scrolling was not working in WebView.

@gregko Thanks for the PR!
I've been away from Android dev for a long time, so I need some time to check it.
But I'll check it this weekend, if possible.

Sorry for late response. It works perfectly.
Very Thanks:)


spec two new error types

Fixes https://github.com/matrix-org/matrix-doc/issues/1254
Fixes https://github.com/matrix-org/matrix-doc/issues/1252

What is the related spec proposal for this?

This is small enough that this can qualify as a proposal imho.

The PR doesn't explain why this is even a thing, so I respectfully disagree. It really ought to be explained properly.

I concur with Travis here. Especially as it's literally a dictionary of errors that you don't need to send if you don't implement.

Both of these errors are related to the work done to satisfy GDPR and should be included in a spec proposal for that work as I stated in #1290.

just for keeping the record updated: after further review I agree: a larger GDPR proposal should be required.

ok let's close this for now pending a GDPR spec.


Placeholder homepage video

@fritzjooste once we have the video we'll slot it in. If you've got any ideas for making this a bit nicer, go for it.

Closing in favour of ui-videos.


Added Missing dependency

Summary
I'd followed all along with docs and executed all steps but in the end when I was trying to run gatsby develop
I'd got the following error:
This dependency was not found:

netlify-cms-app in ./node_modules/gatsby-plugin-netlify-cms/cms.js

To install it, you can run: npm install --save netlify-cms-app

See Here for reference to docs for Gatsby that can be applied here. I am wondering if we should include the link at the bottom as a reference.

Gatsby.md file seems fine, Is it?


Issue Title: Enhance User Interaction by Adding Backgrounds to Buttons in Light Mode in project section

#135


Tried to correct some syntatical errors with issue #4890

Do inform about the correctness and any further development if required.

Also try to compile locally before sending any future patches please :)


How to combine the pairwise alignments into multiple sequence alignments？

@baoxingsong Hello！
I'm pleased to have a seamless experience with your software, but I do have some queries while using it. How can I utilize pairwise alignments to achieve multiple sequence alignments? Additionally, are there any user-friendly downstream tools available for this purpose?

Hi @socialhang !
I have some practical experience in this, and I hope this can help you.
I developed a tool to generate a pseudo-maf, which produces multi-sequence alignment of other query genomes for each reference genome.
For details and examples, you can read here : https://github.com/wjwei-handsome/wgatools?tab=readme-ov-file#experimental-generate-pseudo-maf-from-all-to-all-paf
Please let me know if you have better suggestions and other needs:)
Best wishes,
Winnie

Thanks a lot! I will try!
| |
Hang Zong
|
|
@.***
|
---- Replied Message ----
| From | @.> |
| Date | 3/31/2024 14:08 |
| To | @.> |
| Cc | @.> ,
@.> |
| Subject | Re: [baoxingsong/AnchorWave] How to combine the pairwise alignments into multiple sequence alignments？ (Issue #70) |
Hi @socialhang !
I have some practical experience in this, and I hope this can help you.
I developed a tool to generate a pseudo-maf, which produces multi-sequence alignment of other query genomes for each reference genome.
For details and examples, you can read here : https://github.com/wjwei-handsome/wgatools?tab=readme-ov-file#experimental-generate-pseudo-maf-from-all-to-all-paf
Please let me know if you have better suggestions and other needs:)
Best wishes,
Winnie
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@wjwei-handsome
I am writing to express my keen interest in trying out wgatools. However, I am encountering difficulties installing it from GitHub. I am wondering if you happen to have a compiled version for CentOS 7 or a mature Docker image available?
Your assistance in this matter would be greatly appreciated.
Thank you for your attention to this inquiry.
Best regards,

@socialhang
This issue should not belong to this anchorwave repo.
You can open a new issue under wgatools for moving discussion.


Updated README and added CONTRIBUTING.md file

Summary of changes
Created CONTRIBUTING.md
Updated license information in README.md
Impact of changes
None
Migration actions required
None.
Documentation
None.
Pull request type
[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)
Test results
[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR
Reviewers
@ARMmbed/mbed-os-core

@LDong-Arm Your comment was addressed so are you happy to approve?

@harmut01 Could you rebase your PR as this should remove the first commit?

@evedon I have rebased the PR, this should address your comment.


Add test to check that if a key is rotated...

but the requisite piece of metadata hasn't been resigned, that an update fails because the
cached version is no longer valid.
Signed-off-by: Ying Li<EMAIL_ADDRESS>This fixes #361

Awesome tests, and glad to see that issue close!  LGTM after comments :+1:

LGTM!


transcode: certain resolutions result in confusing ABR ladders

Examples:
https://asset-cdn.lp-playback.monster/88d4wozqpkshndy3/index.m3u8 --> higher rendition not ordered correctly
https://asset-cdn.lp-playback.monster/e074cgxcl69f6q2a/index.m3u8 --> low bitrate with same resolutions

The examples in the initial post may not be relevant atm since we changed the ABR ladder slightly.
This is probably the most relevant example:
https://asset-cdn.lp-playback.monster/hls/d915vjabpzht1dg4/index.m3u8
Input video is the 30min bbb loop file. Technically 720p should have been selected as a profile but we only got 360p and 1080p (source resolution). It may be b/c Mist reports the bitrate of the first segment only (?) which causes us to leave out the 720p profile.


Heyo! working great, but sometimes hangs!

Ahayo ! this is working great, except for sometimes it hangs for some reason and doesn't search, not sure why.
Starting Fishing Rod found Bait found
Like this for example

Hey, glad you like it! Thanks also a lot for the feedback!
The problem is with that little info I can't reproduce the error. Maybe you could tell me a bit more detail or give me the console output when this happens.
If the bug is easy to find I will probably fix it. But I already got a better fishing-bot in the making, which is taking all my time atm.
Also I would really like to know how you found this bot, since I couldn't find it myself via google xD
Again thanks a lot for the Feedback! Would love to here back from you!
Also maybe leave a star on the project ;D


Add reference name and version to selection for processing

The current setup is pretty much already set for reference changes, so this adds that information to the params displayed.
To be clear: If the reference is added to the reference table, then used in a params row, it will show up as a new parameter because it is in that row.

Coverage increased (+0.01%) to 78.49% when pulling c1b159e004dfae4d84fdf123f115106f563a6951 on squirrelo:select-reference into 6130e46c7c882d490af3322ee6bb485127088f25 on biocore:master.

Good for review

:+1: can someone else review?

Coverage increased (+0.08%) to 78.56% when pulling fee58741b6357acae17c3aa18ac7ba91e569fdab on squirrelo:select-reference into 6130e46c7c882d490af3322ee6bb485127088f25 on biocore:master.

:+1:


Other npm packages have references pages.css

I encountered a problem：when i used other other npm packages ,and it have references sanitize.css/pages.css ,when i  'yarn' , and install 13.0.0, but  cannot find module ‘sanitize.css/page.css’

When updating, is it compatible with previous versions

MAJOR is not compatible, very normal.

An issue is here in postcss-normalize, where they did not bind the include to a specific or even major version:
https://github.com/csstools/postcss-normalize/issues/58

yup this just broke my package because of the indirect dependency through postcss-normalize. :(


API Playground embed throws errors

What is the issue?
To reproduce:

Visit https://docs.dagger.io/593914/quickstart-hello
Click the Play button in the API playground embed (any language)
Login if prompted
Click the Play button
An error message appears like forwarding ResolveImageConfig: no such job 7lnkxo8kly8o9exjzsue7qgv0

this is already being worked on


IPFS-Pinner-DTM-RC:v0.1.15

#71 (Kubo update to boxo)

I'm running the latest image on my local setup. It's working great so far


Nested bootstrap .nav > .tab-content conflict

if put one nested bootstrap .nav component in the jquery-bootstrap-scrolling-tabs content div, refreshDataDrivenTabs will append scrolling tab pane to the nested .nav > .tab-content div redundantly.
FYI: my workaround is change the code in the jquery.scrolling-tabs.js  from '$currTabContentPanesContainer = $container.find('.tab-content')' to '$currTabContentPanesContainer = $container.find(' > .tab-content')'

With your workaround, do the tabs actually function correctly?
Per the Bootstrap docs, nested tabs are not supported, and so my plugin also doesn't support them.
I just added a note to the README indicating this.

I did a simple test with this workaround and it worked fine. Of course, I'm not sure it really resolve the problem or  support nested tabs.


Fix parsing of timeDescription while using Family Sharing

When parsing Apple Card transaction screenshots while using Family Sharing, family member's names are prepended on the date line, which causes the date to be improperly defaulted to "Just now."
This PR attempts to address that by:

Detecting when a timeDescription contains spaces and is not a relative timestamp and splits after the first space (the family member's name.)
If a family name is split, this is also added to the memo field.
Created a new unit test class in TransactionReaderOCRTextTests to verify that the date parsing changes work.
New extensions, Date+current and Date+mock which statically set the date for testing, adapting examples from: https://dev.to/ivanmisuno/deterministic-unit-tests-for-current-date-dependent-code-in-swift-2h72

Note: The article also recommends adding a pre-commit hook to verify that Date() is no longer used in the code in favor of the new Date.current which is easier to mock in testing.

Wow, thanks!
I've been pretty busy lately so it's going to take me a while before I can truest look this over.
I had a go at fixing this some months ago, but life events got in the way.

No problem! Take your time, I totally understand.
Thanks for releasing this in the first place. It really came in handy for the project I made to get Apple Card transactions imported into the budgeting software I use.

I just made a revision to improve the handling based on testing this branch on transactions since I first made these changes. There seems to sometimes be some inconsistent behavior when VisionKit parses the screenshot and separates the fields. To address this, I added an isTimestamp() method which uses regex to see if the string contains a valid timestamp and keep appending to the string until it contains a valid timestamp. I also updated the Family Sharing test to verify that different variations on this are still processed correctly.


Add codegen attribute tags

Fixes: https://github.com/Azure/autorest.csharp/issues/4385
Description
Add your description here!
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang I do think unifying is what we want to achieve, however I think in mgc these will be public attributes instead of making customers create their own copies of them.

@ArcturusZhang I do think unifying is what we want to achieve, however I think in mgc these will be public attributes instead of making customers create their own copies of them.

yeah making them public is a way, but I think if we let the generator to generate those attribute, in this way, we do not have to make those attribute public, which might be valuable since the public API is reduced, and those attributes are useless outside this generated library, therefore I think if possible to keep them internal, we should.
Customers are impossible to use these attributes without a document, therefore I am imagining this way of using them:
The generator will always generate them in the same namespace, but since no classes are using them, they will be removed by post processor (I think we still will have this in MGC, right?), and the customer reads the document to know that I need to add this attribute on the customized code and regenerate, they just write the code, despite the attribute does not exist, after they regenerate, the attribute now has a usage, and will no longer be removed, and everything should work as expected.
What do you think? I think this is a way to do both "not make them public" and "make everything to work properly" considering the fact that every time we add customization code, we will have to regenerate the library again

@ArcturusZhang opened a tracking issue to finalize on this https://github.com/Azure/autorest.csharp/issues/4551


pulseaudio-dlna

Motivation for this change
Resolves https://github.com/NixOS/nixpkgs/issues/35231
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

made the changes you requested @Mic92

@Mic92 rolling back the version issue we discussed, as the 0.5.2 version does not correctly connect to the pulseaudio daemon in 17.09 otherwise

@dotlambda made all the external apps that can be called optional but defaulted to true and bad include you pointed out. fixed formatting as per @FRidh  request.

@mogorman Can please split the commit into two seperate ones for notify2 and pulseaudio-dlna?
@GrahamcOfBorg build python2.pkgs.notify2 python3.pkgs.notify2 pulseaudio-dlna

Failure on x86_64-linux (full log)
Partial log (click to expand)
Package ‘faac-<IP_ADDRESS>’ in /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/pkgs/development/libraries/faac/default.nix:32 has an unfree license (‘unfreeRedistributable’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

Failure on aarch64-linux (full log)
Partial log (click to expand)
Package ‘faac-<IP_ADDRESS>’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/development/libraries/faac/default.nix:32 has an unfree license (‘unfreeRedistributable’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

We should set faacSupport to false by default.

@dotlambda 2 commits and changes made.

@GrahamcOfBorg build python2.pkgs.notify2 python3.pkgs.notify2 pulseaudio-dlna

@GrahamcOfBorg build python2.pkgs.notify2 python3.pkgs.notify2 pulseaudio-dlna

Success on x86_64-linux (full log)
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01
gzipping man pages under /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01/lib  /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01/bin
patching script interpreter paths in /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01
checking for references to /tmp/nix-build-pulseaudio-dlna-2017-11-01.drv-0 in /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01...
wrapping `/nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01/bin/pulseaudio-dlna'...
/nix/store/3zik190r9lxzvg2d022wfkajak3i4zd9-python2.7-notify2-0.3.1
/nix/store/30rxrg124ya5dylib8wncmix13rxvfqm-python3.6-notify2-0.3.1
/nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01

Success on aarch64-linux (full log)
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01
gzipping man pages under /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01/lib  /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01/bin
patching script interpreter paths in /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01
checking for references to /build in /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01...
wrapping `/nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01/bin/pulseaudio-dlna'...
/nix/store/qshwzrbg28wsbym3hy4glkd7xs5v2kqj-python2.7-notify2-0.3.1
/nix/store/mnc59qrqx5mgb0fbr6w3k5bwjg30i669-python3.6-notify2-0.3.1
/nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01


Linux build error

Linux build errors encountered due to the usage of c++17 classes like std::variant and std::visit in files under the UsdBridge directory. Setting CMAKE_CXX_STANDARD to 17 in UsdBridge\CMakeLists.txt fixes the problem.

Thanks, fixed in https://github.com/NVIDIA-Omniverse/AnariUsdDevice/commit/480b8af80da7c358d167bda5a6d631e2dfe21328


chore: update sequence diagrams

updating sequence diagrams
readme to be updated in another pr

Lets merge this pr contains updated sequence diagrams - I can try and update readme tomorrow - in the meantime adding data from our devpost submission


[Always On Top] Not working with elevated windows when not elevated

Microsoft PowerToys version
0.55.0 RC
Running as admin

[ ] Yes

Area(s) with issue?
Always on Top
Steps to reproduce
Open cmd as administrator and press keyboard shortcut.
✔ Expected Behavior
Windows is always on top.
❌ Actual Behavior
Unpinning sound is played.
Other Software
No response

this is working as expected.  A non-elevated app doesn't have elevation permissions.


HIVE-28355: Fix intermittent failure of TestHplSqlViaBeeLine#testUNIX_TIMESTAMPHplSQLFunction

What changes were proposed in this pull request?

Compare absolute UNIX timestamps value instead of using regex.
Why are the changes needed?

https://issues.apache.org/jira/browse/HIVE-28355
Does this PR introduce any user-facing change?

No
Is the change a dependency upgrade?

How was this patch tested?

mvn test

There were Sonarcloud issues for variable names not complying with the naming convention for some variables. So, I made the appropriate refactoring changes for these variables.

@okumin Please review

I might need some more time since I am not familiar with the issue, maybe. Also, please note that you finally need to get +1 from a committer

Have you worked on it?

The description of HIVE-28355 is super great. Thanks for the detailed explanation. This change would resolve the problem.
For reference, I am putting alternatives that came to my mind. I don't have preference and the current PR looks fine to me.

Just to remove the non-deterministic test case
To change the expected text to {System.currentTimeMillis()/10000}|{System.currentTimeMillis()/10000 + 1}
Control the output using hive.test.currenttimestamp

Thank you for the quick review. The first alternative would not work as the test result depends on the time of execution of test. For the latter one, the test would fail when the timestamp differs other than ten's digit. Could you please tag a committer to get +1? Thank you.

@zhangbutao Could you also please review this? Thank you.
This issue is occuring intermittently depending on the time of execution of the test.
Screenshot from recent occurence:

Thank you @okumin and @zhangbutao for the review!


Refine Configuration File location doc

This PR makes the following improvements to the documentation for the configuration file config:

Explicitly states the file name as config, ensuring readers understand both the file name and its possible locations.
Use $HOME to refer to the home directory,  instead of both ~ and $HOME
Introduce a new header structure (XDG Configuration Path and macOS-specific Path) for better readability and a more organized presentation. IMHO this is formatted better than using a combination of numbered lists, and un-ordered sub-lists.

Looks good to me thanks


add inkColor and inkWidth to config PKInkingTool for canvas

Thank you for contribution. This is closed by #18 because improvement will be merged with more tools feature.


[Fix #10474] Fix a false positive for Style/DoubleNegation with EnforcedStyle: allowed_in_returns when inside returned conditional clauses

Fixes https://github.com/rubocop/rubocop/issues/10474
This PR fixes a false positive for Style/DoubleNegation when code like the following:
def foo?
  if condition_foo?
    !!foo
  elsif condition_bar?
    do_something
    !!bar
  else
    !!baz
  end
end

def foo
  if condition_foo?
    { foo: !!foo0, bar: bar0, baz: baz0 }
  elsif condition_bar?
    do_something
    { foo: !!foo1, bar: bar1, baz: baz1 }
  else
    { foo: !!foo2, bar: bar2, baz: baz2 }
  end
end

def foo
  case condition
  when foo
    [ !!foo0, bar0, baz0 ]
  when bar
    do_something
    [ !!foo1, bar1, baz1 ]
  else
    [ !!foo2, bar2, baz2 ]
  end
end

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

I updated this PR. Thank you so much!

Oops, sorry for the appearance.
I updated this PR.

Thanks!

Thanks!


About Visualization

Hello, this is a very good job! If I want to use DETAD for visualization (FN, sensitivity analysis, etc.) as in your paper, can you provide the code to generate the json file of the results of your model？

Hi, Thank you for your interest in our project. We may not provide the convert code soon, but I can give you some instructions.
DETAD uses a standard evaluation process with GT json (they provided that in their repo) and predicted json, you only need to transfer the output to a valid json format.
With THUMOS14 dataset as an example, you first need to get the prediction output, you can use the saveonly args to get an output pickle file. The only thing is that you need to transfer the target pickle file to the specific json format. I think you only need to convert the class name.

Mark as resolved.

Hi, what should I do to use DETAD on EPIC results instead?

For EPIC datasets, you need to follow instructions in DETAD to create the groundtruth annotations file with extra annotations (like Context Size, Context Distance) as in the DETAD paper. Then you need to follow the previous answer to get the prediction json file and use DETAD to compute the figure.


[FEATURE] Support flat object querying and searching

Is your feature request related to a problem?
Support new OpenSearch data type: flat_object
What solution would you like?

Support querying such fields, for example in select * query.
Support search for sub-fields of such fields.

What alternatives have you considered?
N/A
Do you have any additional context?
https://opensearch.org/docs/latest/field-types/flat-object
https://github.com/opensearch-project/OpenSearch/pull/6507

this issues have been open for a year now anyone going work on this???.


Cairo Trace and Memory representation and import

Cairo Trace and Memory representation and import
Description
Added a representation for Cairo Trace and Memory inside Lambdaworks, and a function to load it from a file or bytes. In the future we could load it by chunks.

[ x ] New feature

Checklist

[ x ] Unit tests added

Codecov Report

Merging #219 (fbce503) into main (337225b) will increase coverage by 0.10%.
The diff coverage is 96.51%.

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   92.28%   92.38%   +0.10%
==========================================
  Files          66       69       +3
  Lines        7244     7446     +202
==========================================
+ Hits         6685     6879     +194
- Misses        559      567       +8

Impacted Files
Coverage Δ

proving_system/stark/src/cairo_vm/errors.rs
0.00% <0.00%> (ø)

proving_system/stark/src/lib.rs
63.34% <ø> (ø)

proving_system/stark/src/cairo_vm/cairo_mem.rs
94.80% <94.80%> (ø)

proving_system/stark/src/cairo_vm/cairo_trace.rs
98.37% <98.37%> (ø)

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


SearchBox#onReset test no longer passes

see https://github.com/algolia/instantsearch.js/pull/4156#discussion_r331552971
It seems like the reset event no longer is triggered after migrating to preact X, the tests have been updated, but the event doesn't get called correctly
https://github.com/algolia/instantsearch.js/blob/92a21308a272e391de726a47bfaf84e794077697/src/components/SearchBox/__tests__/SearchBox-test.js#L288-L345
We suspected JSDOM initially, but it seems the event does get fired. This means it's enzyme which doesn't trigger the event correctly.

The reason why the test fails is that the reset event is not fired in Jest 24 because it relies on jsdom 11 which has an issue with form resets (see jsdom changelog).
This will be fixed as soon as Jest 25 is released because they'll upgrade to jsdom 15 (see Jest changelog).


AccessFunction is only a syntactic sugar

fn = .field
{- generates

   AccessFunction [ field ]

   which is only a syntactic sugar for:
-}
fn = \x -> x.field
{- that generates

   Lambda [ Variable [ "x" ] ] (Access (Variable [ "x" ]) [ field ])

   `x` variable used in example has to be different from `field`;
   may be generated like field ++ "_"
-}

So it seems that additional algebraic element is not needed here. For sake of (model) simplicity it could be removed.

I'm not sure what you are suggesting.
Are you suggesting that
fn = .field
{- should generate
  Lambda [ Variable [ "x" ] ] (Access (Variable [ "x" ]) [ "field" ])
-}

or that
fn = \x -> x.field
{- should generate
  AccessFunction [ "field" ]
-}

?
Either way, my opinion is that things are fine the way they are now. Having the distinction allows for better analysis. For instance, in a tool I'm working on that analyses your code and reports improvable patterns, I report this exact behavior that could be simplified, so that the user can fix it (see SimplifyPropertyAccess). If the AST does that simplification for me, I have no way of knowing how it is written and reporting it to the user.

Hi @jfmengels, you are totally right. Described proposal was based on a specific use case, and as you pointed out it is not proper for general parsing library.
Thanks!
Ps.: it was about removing AccessFunction and to directly write it using simplified type.


New AMAZON WEBSERVICE FREE COURSE ADDED

@shobhit9070 Bro Kindly Merge The Pull Request

Hello @PragnaReddy11 Brother Kindly Merge It😇


distgen: init at 1.3

Motivation for this change
This tool is mainly used in openshift to build source to image containers.
Building a source to image container required dg to be present.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

ping @bachp

@worldofpeace Thanks for reminding me.
I added the unit tests and they seem so to work.
The PR is updated to address all your change requests.

Force push put the testing dependencies in checkInputs.


attempt doesn't handle exceptions in Aff function

It appears that attempt is supposed to handle exceptions in the Aff function it runs, but it doesn't despite having a try ... catch... block in its FFI implementation.
Repro case:

Checkout https://github.com/Thimoteus/purescript-simple-request.git
Change reddit.com to reddit.com:8088 at https://github.com/Thimoteus/purescript-simple-request/blob/master/test/Main.purs#L34
Run the test with pulp test

The program bails out with EPROTO exception (because there's nothing ready for SSL handshake at port 8088).
Expected result: Left Error from attempt with the corresponding exception.

The first place to look is here. Make sure any place which can cause an exception will call the onErr callback.

@jdegoes Does this mean that functions in Aff indeed do not catch exceptions and we need to catch ourselves and call error callbacks?
In Aff.js _attempt does use try...catch..., _runAff doesn't, _liftEff does again. I can't understand the system and difference.

@kika If you create your own Aff, you need to make sure that you always use the error callback in the event of an error. I am not sure why _attempt uses try / catch, probably we can delete that. The point is that if you create your own native Affs which are functioning correctly, then attempt will always "catch" the error (through the error callback). If that does not happen, then it's a bug in Aff and will be fixed right away (in this case, I am not sure, but the Javascript code does not look safe to me).

Aff now only uses try/catch in liftEff and makeAff. It's expected that anything else uses the error channels.


Implement AR feature for mobile (idea)

When out in the street, it could be interesting to look around with your phone in AR mode: with the trees depicted as pins, possibly with additional information such as tree type, amount of water in the past month, etc.
AR.js does Augmented Reality for the web and has been improving a lot recently, they now also have a feature to depict items based on geolocation.
https://ar-js-org.github.io/AR.js-Docs/

@julizet I just found this issue here - really cool idea which can be very useful when walking around the city. I'm not sure how easy it will be to integrate this into the existing codebase but maybe we could also just launch a separated app on a subdomain e.g. ar.giessdienkiez.de to build the experience there.


Slow performance problems than JS

win7 64
go1.6beta1
go
package main

import (
	"fmt"
	"time"
)

func main() {
	t1 := time.Now()
	count, a, b := 0, 1, 3
	for 2*a-b < 0 {
		for i := 12000; i > 0; i-- {
			if (a*i+1)%b == 0 {
				count++
				a, b = (a*i+1)/b, i
				break
			}
		}
	}
	t2 := time.Since(t1).Seconds() / int64(time.Millisecond)
	fmt.Println("Time: ", t2, "ms") //236362 ms
	fmt.Println(count-1)
}

js
    console.time('TIME');
    var count = 0;
    var a = 1;
    var b = 3;

    while (2 * a - b < 0) {
        for (i = 12000; i > 0; i--) {
            if ((a * i + 1) % b == 0) {
                count++;
                a = (a * i + 1) / b;
                b = i;
                break;
            }
        }
    }
    console.timeEnd('TIME'); //127927.607ms
    console.log(count-1);

http://www.oschina.net/code/snippet_95905_53494

cup:i7 3770k

The line t2 := time.Since(t1).Seconds() / int64(time.Millisecond) doesn't compile and doesn't make sense.
In any case, I don't think there is anything clear for us to do here.  Javascript and Go are very different languages that work in very different ways.  If you can identify specific reasons why Go is slower, then perhaps we can improve it.
This is a case where gccgo is likely to generate faster code than the gc compiler.  On my laptop the code generated by gccgo -O2 is 6% faster.  Both print 7295372 at the end.  Of course, that is much less than the difference you report between Go and Javascript.  I admit to being puzzled by how Javascript can be so much faster.  It would be interesting to find out what the Javascript JIT turns the inner loop into.
However, I'm going to close this issue as there is nothing useful we can do to fix it.

Javascript integer type is 4 bytes (int32 in Go). If you change your Go program to use int32 it will be much faster (1m46s vs 4m55s on my PC). int is int64 on 64 bit processor and int64 division is slower than int32 division.

@kostya-sh  int64 division is slower than int32 division.Thanks! :satisfied:


Add Leaflet.Control.SideBySide plugin

Once I started writing Leaflet plugins I just couldn't stop...
https://github.com/digidem/leaflet-side-by-side

Nice work!


System metrics not available on linux host with kernel < 3.14

Bug description
I see the following exception twice whenever I start a (django) application and execute a transaction for the first time.

Exception in thread eapm metrics collect timer:
Traceback (most recent call last):
File "/opt/pack/PYT/envs/pyt-<IP_ADDRESS>/lib/python3.6/threading.py", line 916, in _bootstrap_inner
self.run()
File "/data/nielks/virtualenv/lib/python3.6/site-packages/elasticapm/utils/threading.py", line 64, in run
self._function(*self._args, **self._kwargs)
File "/data/nielks/virtualenv/lib/python3.6/site-packages/elasticapm/metrics/base_metrics.py", line 86, in collect
data = metricset.collect()
File "/data/nielks/virtualenv/lib/python3.6/site-packages/elasticapm/metrics/sets/cpu_linux.py", line 73, in collect
self.gauge("system.memory.actual.free").val = new["mem_available"]
KeyError: 'mem_available'

As a result, no information related to CPU & memory usage is collected.
Environment (please complete the following information)

OS: Linux, kernel 3.0.101-108.18-default
Python version: 3.6.6
Framework and version  Django 2.1.4
APM Server version: 7.1.0
Agent version: 4.2.2

Additional context
Looking at the implementation of elasticapm/metrics/sets/cpu_linux.py, I see that the "mem_available" gauge is evaluated from the "MemAvailable" line of /proc/meminfo.
That info was added in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=34e431b0a, release in 2014 in kernel 3.14.
My host machine has a kernel older than this, hence the exception.
I managed to implement a simple fix, that works fine on my machine:
    def collect(self):
        new = self.read_process_stats()
        new.update(self.read_system_stats())
        with self._read_data_lock:
             # ...
            mem_available = new["mem_available"] if "mem_available" in new else new["mem_free"]
            self.gauge("system.memory.actual.free").val = mem_available
            # ...

    def read_system_stats(self):
        stats = {}
        # ...
        with open(self.memory_stats_file, "r") as memfile:
            for line in memfile:
                if line.startswith("MemTotal:"):
                    stats["mem_total"] = int(whitespace_re.split(line)[1]) * 1024
                elif line.startswith("MemAvailable:"):
                    stats["mem_available"] = int(whitespace_re.split(line)[1]) * 1024
                elif line.startswith("MemFree:"):
                    stats["mem_free"] = int(whitespace_re.split(line)[1]) * 1024

        return stats

This will silently fallback to the value of "MemFree", if "MemAvailable" is not present.
I can create a PR for that, if the behavior is fine for you. (would you rather log a warning ? not provide the metric ?)
Best regards

Hi @NielkS
thanks for opening the issue, great find! Your fix makes sense in my opinion. Would be great if you could open a pull request! If you're up for it, you could also add a test to this file: https://github.com/elastic/apm-agent-python/blob/7c831287a67166588395221c56994e23dddfafac/tests/metrics/cpu_linux_tests.py, but I can also do that after you submit your PR :)