[Request] Delivery Status Improvements

I see there is a scheduled delivery sensor which shows the time windows etc nicely.
As an addition to this, would it be possible to have a section for if there is a delivery planned and if a delivery was successful?
I seem to recall having these in the Homey app, and would help me setup flows a lot easier.

Adding if there is a delivery planned can be done easily. I think that I'll implement this via the state of the delivery sensor. This will include the following states:

Unknown (default)
Order_placed (order is placed but manipulations (may) be possible)
Order_announced (The order is announced (can't be manipulated))
Successful (delivery was successful)

Does this work for you? This will mostly mirror the homey implementation

Sure, that works for me, it's all the info I need 👍

I've implemented some variation of the idea above in the dev branch. It seems to be that Picnic has implemented the same system in their api, but I'm not able to test that yet. My next order will somewhere around next week, so I'll be able to test it then ;)

You can now find the updated sensor states in the new release v0.2.0!
The states are:

order_placed
order_announed (update to the eta mostly and the morning of delivery)
order_delivered

Good luck! ;)


Move tests dockerfile to root directory.

Coverage remained the same at 100.0% when pulling 71d1959ee999992de845740bc91f60cc137f057f on dockerfile-root-directory into 8a877637ce74650d6b46e14907fd7c6f301d8bee on master.


CI: Move FeaturePeek to separate job

Moving this to outside the test matrix so it only executes once per CI run

Hi @williamdanger – cofounder of FeaturePeek here. It looks like a FeaturePeek environment didn't get created for this PR because the GitHub App was uninstalled from the AugurProject org. You can reinstall it on the org/repo here: https://github.com/apps/featurepeek/installations/new

Closing for now until we really need this / can update the branch to make work.


Post back full error log to orchestration node

When an error is detected is is hard to debug. Send back both nodoes log and wrapper script logs to orchestration host. Probably the best way to do this is by HTTP POST to orchestration application, which will then write the files out by job number to a log directory. Suggest new API

POST error-log with params jobid, log-name
GET error-log with params jobid, log-name to see logs via browser.

Need a new page UI page to show full text from the logs.

Completed, click through from job details.


Home page gauge charts: Random string appears in French

Affects: Country page
I'm looking at country pages translated into French, on Production. Check this out:

I do not see anything similar in Spanish or English -- only French.

QA Passed:

Glossed over many programs on country pages in french, was unable to see error described in image attached to this ticket:


[SQL] az sql server create/update: Add --enable-public-network to support PublicNetworkAccess

History Notes:
[SQL] (sql server create:) Add optional public-network-access 'Enable'/'Disable' flag to sql server create.
Ex: sql server create -g {} --name {} --admin-user {} --admin-password {} --public-network-access 'Disabled'
[SQL] (sql server update:) make some customer-facing change.
Ex: sql server update -g {} -n {} --public-network-access 'Enabled'
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

add to S166.

@Juliehzl Merge?


list availability of conda lammps package to lammps documentaion

Might be a good idea to submit a PR to https://github.com/lammps/lammps and list this conda package as another source for binary install (both linux and mac).

I informed the LAMMPS developers about the conda forge package when I pushed some changes to the python interface. I guess it is up to them to list it to the sources for binaries https://github.com/lammps/lammps/pull/1315#issuecomment-462022580 but if you know some of them personally maybe you can emphasize this point again. I would be very happy to see conda listed as official source and I am always open to add more people as maintainers if they are interested in supporting the conda packaging.

@jan-janssen I'll be happy to join as a maintainer of this repo.  I'll see if I can put together a PR to update the lammps install docs.


MSUnmerged: support to inclusion/exclusion directory filters

Superseeds https://github.com/dmwm/WMCore/pull/10702
Fixes #10701
Fixes #10703
Status
not-tested
Description
This PR adds the following:

support to two new service configuration parameters:
dirFilterIncl: a list with explicit directories to be included by the service
dirFilterExcl: a list with explicit directories to be excluded by the service cleanup. If the same path is provided in the included and excluded, excluded always has higher precedence.
made gfal2 import optional. In case we do not have gfal2 in our stack, like in the unit tests, just set it to a None object and carry on with MSUnmerged tests
created a new service configuration parameter emulateGfal2 to be only used by unittests (allowing it to bypass ImportError exception with the gfal2 library)
isolated gfal2 context creation to its own function
fixed a mock import error

Is it backward compatible (if not, which system it affects?)
yes
Related PRs
none
External dependencies / deployment changes
none

Todor, feel free to review it at your convenience. Merging it to bring it in into testbed and production tomorrow.


Stream.close() function seems to hang when called from finished_callback

Hi,
FYI, I'm using sounddevice in its last version (v0.3.7), with PortAudio relying on ALSA (Fedora 25).
I'm building the basis of a sound player/recorder/analyzer for an experimental setup (something related to bubbles, but that's completely out of subject here... ^^).
So, I have some calls to the stop() method of a RawOutputStream object in my code and I'm using the finished_callback to make some proper clean up (closing the file, resetting everything sound-related) when I actually want the stream to be stopped (i.e. not paused). I have no trouble whatsoever, as long as I only ask for pause, but when my stream_cleanup() functions actually gets called, I can detect (with some trivial print() tests) that the close() function has a hanging behavior.
However, I'm still able to resume the stream where it stopped after calling this cleanup function (which is clearly not the intended behavior !).
Here are two parts of my code that I think should clarify what I just wrote above:
# How the finished_callback is defined
def finished_callback():
    if not self._pause_flag.is_set():
        # If the stream is not stopped for a simple pause, clean up
        self.stream_cleanup()
# [...]
# How my cleanup function is defined
def stream_cleanup(self):
    try:
        # Resources have to be cleaned properly
        print("Before")
        self._stream.close()
        print("After")
        self._sndfile.close()
        # For security reasons
        self._stream = None
        self._sndfile = None
        # Everything went fine
        print("Stopped audio stream")
    except (AttributeError, OSError):
        print("Can't stop unexisting audio stream!")

-> "Before" gets printed correctly, "After" never does, unless self._stream.close() is commented out, but that doesn't sound very clean.
I've seen your recent pull request #75 in which you discussed something similar, but you were pointing that hanging problem only when the stop() method hadn't been called before. Which is definitely not the case here, since the finished_callback is actually called when I ask the stream to stop, with the stop() function...
Do you have any idea how this could be solved in a cleaner way ?

| something related to bubbles,
Like literal physical bubbles? Sounds interesting :o
Ah, so, you cannot operate on the stream in the finished_callback, or at least not stop/abort/close it. This is a portaudio behavior. In fact, from what I've seen calling stop()/abort() will block until your finished_callback has returned so obviously calling close() inside the callback will cause the thread to hang.
I would suggest using the with statement, i.e.,
with RawStream() as stream:
    # do stuff

That way it's guaranteed that close() will be called on the stream.

Thanks for the quick answer!
Yep, physical bubbles, like the ones we all played with when we were younger ! :smile:
Ah ! That's interesting, although not really satisfying my needs... :/
I already thought about using the context manager functionality, but due to my design (maybe a bad one), I'm not able to do this without losing the possibility of interacting with my GUI, to manually pause or stop the media, for instance...
That's actually why I thought about this clean-up function getting called at the end of the stream and I even moved from PyAudio to sounddevice to be able to use this callback functionality that PortAudio implements (but PyAudio doesn't, yet).
To be clear, what I currently have is: a play method (linked to a PLAY button) which creates a stream appropriately (and if it doesn't already exists) and then starts without waiting for it to finish. It then exits, leaving the stream in background which can be interrupted by clicking on the PAUSE (stream can be resumed) or STOP (stream is closed) buttons. Thus, if I use the with statement inside the play method, I'm afraid I will only be able to launch the pause and stop methods when the stream has actually finished playing.
Two solutions I've been (and am) thinking about:

raising a signal inside the finished_callback. The signal would then be watched regularly by a sort of recurring timer to call the stream_cleanup function at the right time (maybe not thread-safe depending on the implementation...)
doing everything directly stream-related in a secondary thread and sending signals to it when an interrupting action has to be performed. That way, I would be sure that the stream is handled thread-safely and that it doesn't interfere with the GUI in the main thread.
It's just that I can't see these come with the mess of handling threads (which I'm not quite comfortable using in Python, yet), and I wanted to keep the app the simplest possible. I guess, I will go for the 2nd option, that way I should have less trouble integrating the video part later, using a similar pattern.

Wow, a long message from my side, again. ^^" Anyway, thank you again, it helped me think a bit further :wink:

It is indeed off-topic, but I would still be interested in seeing some pictures of the bubbles, or even a video!
The documentation is not very specific about the problem you are describing, but I assume this statement about the callback argument is also true for the finished_callback argument (see the sounddevice.Stream docs):

With the exception of cpu_load it is not permissible to call PortAudio API functions from within the stream callback.

The two solutions you have mentioned should work, but if your situation allows it, there might be another, better choice:
What about creating the stream before PLAY (probably at program startup) and keeping it running after STOP?
You could implement a callback function that simply writes zeros to the output. And whenever PLAY is pressed, it starts writing the appropriate audio data until it's finished and afterwards again zeros.
In this scenario, you need to do the cleanup only once, at the very end of your program.
I've implemented such a callback function in C in https://github.com/mgeier/python-rtmixer/, but a similar (but probably simpler) thing could be done in Python as well.

OK so let me try to understand what you want to accomplish wrt the audio part of your application:

To be clear, what I currently have is: a play method (linked to a PLAY button) which creates a stream appropriately (and if it doesn't already exists) and then starts without waiting for it to finish. It then exits, leaving the stream in background which can be interrupted by clicking on the PAUSE (stream can be resumed) or STOP (stream is closed) buttons.

So it sounds like you just want to be able to start and stop a single stream. So why do you want to close the stream every time the user hits stop? Why not just call stop? It is perfectly possible to start and stop an open stream as much as you want. Then you only need to close your stream once when the application exits.

Thank you guys for your answers. I'm building the app progressively, but in the medium/long term, I want to be able to read different files throughout an experiment session, so I'm afraid your solutions won't apply in that case.
@mgeier Yeah, I had seen that line in PortAudio's doc as a note, but it never occurred to me that it would apply also for the finished_callback... :/
Even more so, since the documentation of PaStreamFinishedCallback doesn't have that note.
So I'm not sure I'm gonna use your suggestion, but I think I'll have an eye on your C cleanup callback, it might still be interesting for my personal knowledge.
As for the bubbles themselves, I won't be able to send you that kind of picture or video for now, but when I've reached that part of the project, I'll try to remember and show you some demo of the experiment ;)

It shouldn't be a problem to handle multiple files, either at different times or at the same time. You should still use a single stream with a single callback. The callback just has to be written in a way that it can receive the data, add multiple signals if they appear at the same time, and play zeros whenever no signal is available.

your C cleanup callback

It's not a cleanup callback, it's just the "normal" audio callback.

@AodhAnd Any news on the bubbles?


RHEL 6.5 install issues.

suid isn't available on RHEL 6.5. I removed it (do we need to run it as etcd?). Also, the directory give is wrong. My /etc/init/etcd.conf on control node is (also nee similar changes for compute):
[root@calico-rh04 ~]# cat /etc/init/etcd.conf
description "etcd"
author "etcd maintainers"

start on stopped rc RUNLEVEL=[2345]
stop on runlevel [!2345]

respawn

script

        env ETCD_DATA_DIR=/var/lib/etcd
        export ETCD_DATA_DIR

        exec /usr/local/bin/etcd --name  calico-rh04                                                        \
                           --advertise-client-urls "http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001" \
                           --listen-client-urls http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001              \
                           --listen-peer-urls http://<IP_ADDRESS>:2380                                    \
                           --initial-advertise-peer-urls "http://<IP_ADDRESS>:2380"                \
                           --initial-cluster-token calicorh6                                         \
                           --initial-cluster calico-rh04=http://<IP_ADDRESS>:2380                  \
                           --initial-cluster-state new
end script

I can't install libffi-devel - its not available from the repos setup so far. I tried rpmforge ( https://gist.github.com/rderoldan1/5920539 ) with el5 replaced with el6 and it still failed.

Ugh.
We don't need to run etcd as a non-privileged user, but it makes me sad to just run everything as root. At this point though RHEL 6.5 is kinda forcing my hand, so we can remove it.
The libffi-devel requirement is a weird one. We need it because python-etcd depends on PyOpenSSL, but we don't actually need PyOpenSSL here (because we aren't using SSL at any point). Which is kinda crappy.

Solution for libffi-devel:
Enable Redhat repository Optional subchannel as follows:
•	Search /etc/yum.repos.d for the string ‘rhel-6-server-optional-rpms’
•	In the ‘rhel-6-server-optional-rpms’ section change the enable = value from 0 to 1
•	Run ‘yum list libffi-devel’ – to verify the package is now seen (investigate if not)
•	Run ‘yum install libffi-devel’

The plugin is hitting exceptions:
2015-04-24 16:14:54.001 1464 ERROR calico.openstack.mech_calico [-] Exception in periodic resync thread
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico Traceback (most recent call last):
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico   File "/usr/lib/python2.6/site-packages/calico/openstack/t_etcd.py", line 88, in periodic_resync_thread
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico     self.provide_felix_config()
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico   File "/usr/lib/python2.6/site-packages/calico/openstack/t_etcd.py", line 333, in provide_felix_config
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico     prefix = self.client.read(iface_pfx_key).value
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico   File "/usr/lib/python2.6/site-packages/python_etcd-0.3.3_calico_2-py2.6.egg/etcd/client.py", line 349, in read
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico     timeout=timeout, check_cluster_uuid=check_cluster_uuid)
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico   File "/usr/lib/python2.6/site-packages/python_etcd-0.3.3_calico_2-py2.6.egg/etcd/client.py", line 610, in api_execute
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico     return self._handle_server_response(response)
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico   File "/usr/lib/python2.6/site-packages/python_etcd-0.3.3_calico_2-py2.6.egg/etcd/client.py", line 626, in _handle_server_response
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico     etcd.EtcdError.handle(**r)
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico   File "/usr/lib/python2.6/site-packages/python_etcd-0.3.3_calico_2-py2.6.egg/etcd/init.py", line 193, in handle
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico     raise exc(msg, payload)
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico UnboundLocalError: local variable 'payload' referenced before assignment
2015-04-24 16:14:54.001 1464 TRACE calico.openstack.mech_calico

Calico felix doesn't start:
Traceback (most recent call last):
File "/usr/bin/calico-felix", line 9, in
load_entry_point('calico==0.16', 'console_scripts', 'calico-felix')()
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 299, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 2229, in load_entry_point
return ep.load()
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 1948, in load
entry = import(self.module_name, globals(),globals(), ['name'])
File "/usr/lib/python2.6/site-packages/calico/felix/felix.py", line 33, in
from calico.felix.fiptables import IptablesUpdater
File "/usr/lib/python2.6/site-packages/calico/felix/fiptables.py", line 30, in
from gevent import subprocess
ImportError: cannot import name subprocess
I checked, and I do have python-gevent installed:
yum list python-gevent
Loaded plugins: product-id, security, subscription-manager
Installed Packages
python-gevent.x86_64                                                            0.13.8-3.el6                                                            @epel

Well the subprocess thing is going to be a problem. gevent.subprocess was added in gevent 1.0, which it looks like RHEL 6.5 does not have.

The installed python-gevent can be upgraded to a suitable version by running yum install python-pip, pip install gevent --upgrade.  Felix then proceeds further before hitting the same bug as the plugin.

The immediate plugin (and Felix, given a suitable gevent) problem is a bug in python-etcd - init.py:handle references the undefined payload if the .format() fails.
This hides an underlying issue though - when a read is issued for a non-existent key, an etcd.EtcdException: Unable to decode server response exception is emitted.

The python-etcd issue is caused by it not properly supporting python 2.6.  See https://github.com/Metaswitch/python-etcd/issues/4.

EL6 comes with ipset v6.11, which doesn't support -file (EL7 uses v6.19).
FailedSystemCall: Failed system call (retcode : 2, args : ('ipset', 'restore', '-file', '/tmp/tmplxoZzh'))   stdout  :   stderr  : ipset v6.11: Unknown argument -file

The ipset issue can be resolved by installing v6.19 by running rpm -Uvh on the 2 rpms linked below:
http://rpm.pbone.net/index.php3/stat/4/idpl/23986399/dir/redhat_el_6/com/libipset3-6.19-32.1.x86_64.rpm.html
http://rpm.pbone.net/index.php3/stat/4/idpl/23986390/dir/redhat_el_6/com/ipset-6.19-32.1.x86_64.rpm.html

There's also an iptables issue (this is a regression from zmq Felix) - v1.4.7 (installed) doesn't support --wait.  The right thing to do is probably just not pass it.

Removing the --wait flag from the (single) call that uses it fixes this - ipsets are programmed and everything seems shiny.

IIRC, --wait is needed to allow multiple (green) threads to (successfully) program iptables at the same time.

There was a lot of discussion about this at the time, involving it not doing quite what it suggested anyway, I suggest finding the older issues.

So why was --wait still there then?
But I don't want to be a pain here, because this isn't something that I've paid close attention to.  Just trying to flag something in case it was important and had been forgotten...

Tagging this with 0.21 just to give it a label.  Please triage before 0.21.

At the moment, we're waiting for someone to confirm that they actually need RHEL 6.5 support - until we get that confirmation, we're not going to proactively fix our RHEL 6.5 code/instructions.  @fasaxc Have you any evidence that RHEL 6.5 is required by any of your contacts or were you just flagging this so that all our issues were labelled?

The latter, just forcing us to triage so it didn't get lost.

Closing this as we currently have no active plans to resurrect RHEL 6.5 support.

python-etcd 0.4.3 doesn't work on python 2.6.  0.4.2 works: there's also a 0.4.2+calico version we made with some better logging that works.

Since #946 removes our unit testing of Python 2.6, there's some more risk that the code itself drifts away from being 2.6 compatible.  This shouldn't be too difficult to get running again (with old python-etcd) if needed: the differences in other packages are more scary.
Note that Red Hat will support OSP 5 (the last one that supports RHEL 6) until June 2017.


[CON-1172] Implement stream call interface for Gramine integration

Changes

Implement socket call interface classes and associated tests.

Notes
The new interfaces are reliable but slow, even over localhost. We will need to investigate named pipes, datagram sockets or memory mapped files to get performance to an acceptable level. This remains as future work.

@bonifazi-r3 please also take a look.

Added Marco as a reviewer to get more exposure on this code.

Added Marco as a reviewer to get more exposure on this code.

@bonifazi-r3 Just a heads up, I wouldn't spend too much time looking at this. The performance is good enough for a PoC but it's unlikely to be sufficient for the final thing, we're probably going to need to replace it later. I'd advise you just familiarise yourself with the constructors and the start/stop methods.

Added Marco as a reviewer to get more exposure on this code.

@bonifazi-r3 Just a heads up, I wouldn't spend too much time looking at this. The performance is good enough for a PoC but it's unlikely to be sufficient for the final thing, we're probably going to need to replace it later. I'd advise you just familiarise yourself with the constructors and the start/stop methods.

Having a look now and we can have a quick chat tomorrow morning if I have questions, deal?

Yeah, don't spend too much time on this. More so that you get familiar with the code and it makes sense.


Affine

canonical-data

All in all I am feeling pretty good about this.  Barring anything horrible getting spotted I think this is good to go.

Let me know what you think now.

Oh btw, one think I thought was odd was to pass the key as a pair of pairs. Why not just name a and b explicitly as arguments? The parsing would be something like '(,@(map cdr (lookup 'key input)) ,(lookup 'phrase key)) or whatever the names are in canonical

Hmm, I like the key object, because it matches the problem description very well.
If I were writing a brute force program to decrypt affine cipher messages I would want to store all possible keys in a list of such data structures.  I like how explicit it is.  If this is not very idiomatic for Scheme, then I am open to different possibilities, but I like having them grouped together as a unit.
If this were Haskell I would probably just use:
type Key = (Int, Int)

and there would still be clarity.
That could be mimicked in Scheme:
(key . (15 . 12))

But I don't know if that kind of type spoofing would be considered necessary.
If you are against the current data structure, how do you feel about a simple pair?
(15 . 12)
``` ?

***** Asterisks: Variants, Internal Routines, Mutable Globals

Affix an asterisk to the end of a name to make a variation on a theme
of the original name.

Example: let -> let*

Prefer a meaningful name over an asterisk; the asterisk does not
explain what variation on the theme the name means.

Affix an asterisk to the beginning of a name to make an internal
routine for that name.  Again, prefer a meaningful name over an
asterisk.

Affix asterisks to the beginning and end of a globally mutable
variable.  This allows the reader of the program to recognize very
easily that it is badly written!

Cool. So it is okay to simply affix an asterisk to mimic the identifier' style of Haskell?

A pair for the key is fine. I'm bothered by having a symbol-value pair where the symbol only serves to name the value... That's what the variable name is for!

I just pushed a namiong convention fix before I saw your last feedback, so I will update it now.

I love that style guide by the way!  I strongly agree with his sentiment about [ in Scheme, but I figure that perspective is losing pretty badly these days.

Yeah it's full of a lot of wisdom. Don't hesitate to call me out if I'm breaking some of its rules!

I'm gonna re-marge master in this branch to get it up to date.
Are you cool with this PR now?

We probably don't need all 13 of these commits in the history.
Once you approve this I will rebase to just a couple commits that represent the developement process without cluttering

Yeah maybe squash them. Last thing I wanted to check was the key, all looks good!


Stop access to file:///

This worked before then BrowserLoadURL changed in Firefox and upstream didn't do anything about it. However I think Mike has shown me some code that effectively solves this problem! :)

This is checked in.
a whitelist is allowed in the profile directory - webconverger.whitelist
This file uses regular file system paths.
So on Windows, C:\Users in that file would give access to that directory and all subdirectories


[Relay] Target annotation for external codegen

This PR introduces the op based annotation to Relay so that we can conveniently register and decide which compiler should be used for codegen for a given op. This discussion is here:
https://discuss.tvm.ai/t/rfc-op-based-annotation-for-external-codegen/5709/39
Only we only introduce the register API in this PR. @comaniac and I will have a followup PR for the build pipeline and naming.
@tqchen @soiferj @mbaret @icemelon9

I've mostly got a few questions about the direction of the PR. The thing that concerns me is the lack of support for composite operators. I know this is mentioned on a to-do, but registering the 'is supported' logic as an operator attribute is not something we can do with composite functions in the current implementation. Do you have a proposal on how you're going to support composite functions?

Since we are still discussing the naming and format of the pass sequence for annotation, this PR does not consider composite functions yet. The follow-up PR will update the annotation pass to annotate not only ops but also functions (with the composite attribute).

@mbaret We can check composite in the op register only if it is an op. Otherwise, we can check the CallNode whose op is a function annotated with composite in the annotation pass.

What I'd like to understand is what the composite equivalent of this line will be:
static auto fannotate = Op::GetAttr<FTVMAnnotateTarget>("target." + target_);

As you say, composite functions aren't ops so we can't store this information with op registering.

@mbaret We shouldn't even get to that line because the op in the call is not a primitive op, but a FunctionNode. We need to check the object type first. For example, we may have something like:
auto op = call->op;
if (op.as<FunctionNode>()) {
} else if (op.as<OpNode>()) {
}

Where will we register the composite equivalent of FTVMAnnotateTarget?

no need to register if we don't have an op for it. They are annotated already.

But if we want to register a check that depends on the attrs/args, then we will need to provide a function here.

I probably missed something, but we already have a function because the composite pass has been executed, right?

More specifically,
auto op = call->op;
if (op.as<FunctionNode>()) {
  # Check function attribute "composite" which type is string.
} else if (op.as<OpNode>()) {
  # Check op attribute "target.dnnl" which type is FTVMAnnotateTarget.
}

Op attribute "target.dnnl" has to be registered as this PR has shown. Function attribute "composite" will be added by the merge composite pass. As a result, we don't have to register it again.

To give an example, we match qnn.conv_2d -> bias_add -> requantize to a composite convolution (which represents a tflite quantized convolution). But we can still have additional requirements if, for instance, only convolutions with a certain kernel size or tensors of a certain size are supported. Merge composite just does a structural pattern match, it doesn't allow for you to insert arbitrary logic on whether a particular set of attrs and args are supported.

IMHO, if you want to define a pattern by yourself, you should be clear about what can be supported and specify it in the pattern. Otherwise the scenario looks weird to me. Say you define a pattern to match an instruction, and merge composite generates a composite function accordingly. Later on we found that an op in this function does not fit an additional requirement. What should we do then? Should we decompose the function back to origin, or just left the composite function with your instruction attribute there without annotation?
If we want to define a fuzzy pattern (e.g., an op in a pattern can be a set of candidates like your example, and you can somwhow specify the requirements for candiates), we should think about how to enhance pattern specification and pattern matching mechanism. This mechanism, however, does not have to be considered in this PR.

The motivation behind merge composite was to make it so that this annotation mechanism could handle the case where there's a many-to-one mapping between Relay ops and your codegen. Merge composite resolves that many-to-one problem by ensuring all mappings are one-to-one or one-to-many. That way you could just treat composite functions equivalently to operators in the annotation pass (and partitioning pass). But just because some ops are merged does not imply they are supported, it just formats them in a way that can be easily handled in the annotation pass.
It wasn't the intention to add the 'is supported' check into merge composite as it's just a structural pattern matcher. The logic in FTVMAnnotateTarget can get quite complicated and won't be expressable as a pattern.
If composite functions don't get annotated as supported, they should still be valid Relay. If having them interferes with further lowering passes, then yes we'd need an 'inline composite' pass after.

@mbaret Thanks for all discussions. I think this is actually a separate issue to this PR. We probably want to have an RFC for it. We can say this PR mainly focuses on the annotation of operators, while currently composite isn't really an op but a function. We need to have some special custom_op to make op registration take it.
But even if you have some ops in a composite function cannot be mapped to external codegen, this pass is still okay. For example, we can have a checker to see if we should add compiler annotations for it, this checker then could be a simple helper visitor.

After reading the RFC and implementation I'm not sure if per operator is the right way to do validation for the HW platform. I'll try to follow up with more comments later tonight.

@jroesch thanks for commenting. Could you please comment on the discussion forum and share more alternative solutions so that we can make a decision on it soon? We have several use cases that users only provide a list of operators that they can support. That’s why we also want to provide the per operator annotation and propose algorithms to merge them. If this is not a good way,  we probably need to close the pr and quickly move to other solutions. Thanks.

@mbaret Please take another look and see if the comment makes sense. Let's bring this in soon so that your algorithm PR can be unblocked. Thanks.

@jroesch Let's bring this in to unblock @mbaret. We will move to the pattern infra once it is done.

Thanks @zhiics @comaniac @mbaret @lhutton1 @soiferj


Unify roachprod run and roachprod ssh

The run and ssh subcommands are almost but not quite identical: ssh can be interactive, but only runs against one node, while run is never interactive but supports parallel execution across multiple nodes. There are other subtle differences, like the fact that ssh runs the expander on its arguments while run does not. We should combine these into one command that supports multiple nodes in non-interactive mode (so we only have one interpretation of non-interactive commands) while also supporting interactive use on a single node.

I agree this is confusing. I think I have a TODO about this some where.


The type of OverrideDefaultWindowCommandsBrush should be Brush rather then SolidColorBrush

by @whopacha asked in Gitter
Any reason why OverrideDefaultWindowCommandsBrushProperty uses SolidColorBrush rather than Brush?

@punker76 I am wondering why this change is a breaking change? I always thought that SolidColorBrush inherits Brush, so the change should work with previous code. Am I wrong?
Happy coding
Tim

@timunie You're right! 👍


Revisiting / refactoring deprecation

As currently defined, deprecation and simulated removal (as of no-deprecated configuration) are kind of mixed together in the macros DEPRECATEDIN_x_y_z, which makes function declaration and function implementation look quite different:
/* in whatever.h */
DEPRECATEDIN_3_0(WHATEVER *WHATEVER_new(void))

/* in whatever.c */
#ifndef OPENSSL_NO_DEPRECATED_3_0
WHATEVER *WHATEVER_new(void)
{
    ...
}
#endif

Furthermore, if we want to deprecate things that are already declared through other macros, a lot of duplication of macro conditions is required, so for example, DECLARE_ASN1_FUNCTIONS would explode macros like DECLARE_ASN1_FUNCTIONS_DEPRECATEDIN_3_0, which would have to duplicate the complex version checking preprocessor code with have in include/openssl/macros.h.
Proposal
I propose that we switch to use attribute macros that are separate from the removal simulation, for example OPENSSL_DEPRECATEDIN_3_0.  That would force us to switch our declarations to look like this:
/* in whatever.h */
#ifndef OPENSSL_NO_DEPRECATED_3_0
OPENSSL_DEPRECATEDIN_3_0 WHATEVER *WHATEVER_new(void);
#endif

This corresponds more clearly to the implementation guard, and also has the benefit of looking more like C.
A stronger benefit is that we can use that same attribute macro for declaration macros.  Imagine a DECLARE_ASN1_FUNCTIONS_ATTR that can be used like this:
#ifndef OPENSSL_NO_DEPRECATED_3_0
DECLARE_ASN1_FUNCTIONS_ATTR(WHATEVER, OPENSSL_DEPRECATEDIN_3_0)
#endif

A bonus is that this is likely to simplify the preprocessor in include/openssl/macros.h

+1

#13074 is my proposed implementation


datadog reporter in k8s environment

Hi there.
I'm using datadog for my observability solution. I'm deploying in k8s environment and there they have a dogstatsd agent and basically they take care of buffering on that agent itself. The agent not only handles metrics but also logs, traces etc.
I wanted to use app-metrics to measure things, but the datadog reporter seems like it directly connects to datadog API. Is there a way to forward the metrics to dogstatsd instead of reporting directly to the API? Or does the statsd reporter work for this usecase?
Thanks in advance.

I found out that statsd with datadog flavor works for datadog.


Align NISAR to VEDA notebook guidelines

EPIC
#240
Description
The Tutorial for simulated NISAR data access notebook should be reviewed using the this guidance and includes the following components:

Style
Rendering Information
Notebook Sections

Acceptance Criteria (Tasks):

[x] Style should be consistent with guidance provided
[x] Rendering information should be complete and accurate. If there is no author/date information available, consult MAAP leads @wildintellect @abarciauskas-bgse for guidance
[x] Ensure notebooks include the recommended standard sections

PR: https://github.com/MAAP-Project/maap-documentation/pull/301

Approved and merged


Linux android views flake when killing zombie processes

Seems like the logic to kill processes either identified a process that is no longer running or it failed to kill it.
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux android views/245/overview

\cc @blasten

https://flutter-review.googlesource.com/c/recipes/+/18060

fixed


Hopefully the last build fixup for enabling V4L2 accelerated video decoding on Linux/ARM

Ensure that the V4L2 Video Decoder Accelerator gets actually and
initialized in GpuVideoDecodeAcceleratorFactoryImpl::CreateVDA(),
so that the HW accelerated video decoder is actually used.
This commit should be squashed into "Enable V4L2 accelerated video
decoding on Linux/ARM" during the next rebase.
https://phabricator.endlessm.com/T13250

So it was my fault. Sorry for not noticing this. :(

@mcatanzaro That's not entirely true: I also reviewed the patch and did not notice that slippery missing bit, because it was not that obvious. It only caught my eye when I was explicitly "hunting" it, don't worry.


Add (default value) as an optional parameter to the Get function.

Add the ability to set the default value ti the get function like the following:
localStorageService.get('some_key','def_val');

Coverage remained the same at 88.41% when pulling 573b845c2cfeabea7d07cb13c05be96f7292146e on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

Can you please create tests for this changes ?
Thanks @ayman-alkom

Coverage remained the same at 88.41% when pulling 8b9d93948ca93617f687720788316a1646ed6401 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

Coverage remained the same at 88.41% when pulling e03ca4cf1ca46c7d4cbcd5202d1deaff0bd2c653 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

Coverage remained the same at 88.41% when pulling e03ca4cf1ca46c7d4cbcd5202d1deaff0bd2c653 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

I am sorry but this is my fist pull request ;)

Coverage remained the same at 88.41% when pulling e03ca4cf1ca46c7d4cbcd5202d1deaff0bd2c653 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

I am sorry but I don't know how to create tests
@a8m

Coverage remained the same at 88.41% when pulling f45bebd3d099094c8f6fc3d248f3b95e6505e384 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

Coverage remained the same at 88.41% when pulling 9c156815fcc5b76df4f546db4728f28e5d319575 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

Coverage remained the same at 88.41% when pulling 8df324cdf6666038e3c18b601a2653bff8390508 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

Coverage remained the same at 88.89% when pulling ba9468fdfed64ea635cee232f9fc2ab6435e46bd on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

Coverage remained the same at 88.41% when pulling bdff8f99cc7a233fc88ccddc38fdcf91bba98fd5 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.

Coverage remained the same at 88.41% when pulling 113542f4eb9d24088888f6be1ed7e8495667d250 on ayman-alkom:master into c41d9ffff68e74eb9b6422ed83a9e8d627a614de on grevory:master.


adding dynamic swap fee to fx pools

closes #802

Hi @gmbronco, don't we also need to update how the fees24h is computed in pool.snapshot-service.ts? (note: this file seems to exist in two places)
The code assumes a static pool swap fee, but FX pools have a dynamic swap fee
fees24h: volume24h * parseFloat(poolAtBlock.swapFee)

I'm thinking something like this might work:
fees24h: parseFloat(pool.totalSwapFee) - parseFloat(pool24hAgo.totalSwapFee)

Hi @gmbronco, don't we also need to update how the fees24h is computed in pool.snapshot-service.ts? (note: this file seems to exist in two places)
The code assumes a static pool swap fee, but FX pools have a dynamic swap fee
fees24h: volume24h * parseFloat(poolAtBlock.swapFee)

I'm thinking something like this might work:
fees24h: parseFloat(pool.totalSwapFee) - parseFloat(pool24hAgo.totalSwapFee)

Good catch. We'll need to think about that as we'll change the snapshot generation not to rely on subgraph pricing anymore. We can calculate fees24h based on the swap events for example which would be more accurate.

Great, that makes sense to me!

@franzns this one is ready apart from the snapshot's fees24h, which we don't have in subgraph ATM. (added a separate ticket for it here: https://github.com/balancer/backend/issues/1182)


Load / refresh from key vault service

version    -> don't know how to do after application start up.
enable / disable    ->    Setting "server.ssl.key-store-type"

Closing this issue because related PR has been merged.


Uploader, stderr vs stdout in ERT context

All output from uploader is currently sent to stderr, stdout is (usually?) empty. Ideally, only errors should be sent to stderr which should be empty when no errors.
Investigate why this happens, and fix. Ideal outcome is:

Regular info is printed to stdout.
If errors, they are printed to stderr.
If no errors, stderr is empty.

Tried to edit src/fmu/sumo/uploader/config_jobs/SUMO_UPLOAD and use this:
STDERR    sumo_upload.stdout
STDOUT    sumo_upload.stdout
instead of the old:
STDERR    sumo_upload.stderr
STDOUT    sumo_upload.stdout
Result in ERT GUI: both the STDOUT and the STDERR shows the exact same output as we are used to see in STDERR.
AKA: this is not the solution to the problem.

Tried PO logging.basicConfig(stream=sys.stdout) proposal.
Result in ERT GUI: the STDOUT shows the INFO msgs, while STDERR shows the UserWarnings.

Andre ERT forward models som tydeligvis gjør logging riktig:
ECLCOMPRESS:  INFO:subscript.eclcompress: ...
PRTVOL2CSV: INFO:subscript.prtvol2csv: ...
ECL2CSV: INFO:res2df.summary: ...
Basert på
https://github.com/equinor/subscript/blob/main/src/subscript/__init__.py
testet ut med uploader fil _logging.py og innhold:
import logging
import sys
def getUploaderLogger():
logger = logging.getLogger("fmu.sumo.uploader") #name)
if not len(logger.handlers):
formatter = logging.Formatter("%(levelname)s:%(name)s:%(message)s")
		stdout_handler = logging.StreamHandler(sys.stdout)
		stdout_handler.addFilter(lambda record: record.levelno < logging.ERROR)
		stdout_handler.setFormatter(formatter)
		logger.addHandler(stdout_handler)

		stderr_handler = logging.StreamHandler(sys.stderr)
		stderr_handler.addFilter(lambda record: record.levelno >= logging.ERROR)
		stderr_handler.setFormatter(formatter)
		logger.addHandler(stderr_handler)
	return logger

OG SÅ I hver enkelt py-fil:
from fmu.sumo.uploader._logger import getUploaderLogger
# logger = logging.getLogger(name) OLD; COMMENTED OUT
logger = getUploaderLogger()
MEN da ble det logget til BÅDE stdout og stderr, så mangler noe mer iforhold til de ERT forward models som gjør dette riktig.
Dessuten ble det også logget til stdout for 33 pre-processed (noe vi ikke ønsker).

PO: do not print all logs to the console (33 pre-processed), keep the logging here low

The other ERT forward models that solve this problem: do they also have the issue with the 33-pre-processed writing to console?
Can we find a way to log as little as possible for the 33-pre-processed, while still log to stdout for the others?
Can we use the root logger basicConfig statement without creating issues for others?

https://github.com/equinor/fmu-sumo-uploader/pull/54


Add project documentation

Description
Add contents to MkDocs.
Tasks

[x] Create Home page
[x] Create Quickstart page
[x] Create Deploying App page
[x] Create Creating Survey Files page
[x] Create Garbling page under Concepts section
[x] Set up Analyzing Results page

Contents to be contributed by PIs

[x] Create Getting Help page
[x] Set up Contributing page

Contents to be fleshed out later

[x] Update README
[x] Create contents for the Contributing guide
[ ] Gather and integrate feedback on drafts

Make Contributing a separate section outside Guides

Feedback from Eric:

I enjoyed seeing your work on this! A few comments:

If the main target audience is academics, I would put a citation and link to the paper that introduces the method front and center on the first page.
Same again with the quickstart guide.
You could probably get more technical on the garbling explainer page. Once the site is built out a bit more, if this looks like similar sites I’ve seen, I should probably (?) be able to fully understand the technical details just by reading the website.
Make the link to the example XLSForm more prominent
Contributing tab looks great
Might be worth mentioning more about what this is NOT. For example, my impression is that this is NOT designed to help, say, HR identify cases that need following up. Instead it’s just designed to yield valid population mean estimates.

Plus, he suggested giving more concrete/specific guide on parameter values (e.g., "X is a good garbling rate if your survey has Y number of respondents").

Feedback from Joel:

Documentation website questions and comments:

Overall, this looks fantastic. You have a lot of content here already and the site is snappy.
The YouTube demo video is great to have here.

I noticed the video is currently unlisted, which makes sense. Will it eventually be listed?
Are you comfortable with the video being associated with your personal YouTube channel?

The search bar is excellent – fast and with preview results.
I like the MkDocs approach. It’s good that the documentation website itself is part of the application’s git repo.

I am curious if the static site immediately and automatically reflects changes in the repo?

Links that leave the website could open to a new window:

Home page link to repo (in the top right corner)
Link to installing Docker from Quickstart page
Link to the paper at bottom of Garbling page
Link to Stats4SD on bottom of Creating Survey Files page.
Link to discussions on the Getting Help page.

Apart from linking to the DDSS GitHub repo, do you want to link to https://ddss.princeton.edu/ somewhere (or otherwise advertise the DDSS)?

Other questions:

It seems unavoidable that, in the end, the user must trust that the application is doing what it says it is doing (whether it is an anonymized or garbled survey or e2e encrypted messaging service or something else). Open sourcing the code can help mollify concerns, but there’s always the possibility of bugs. What else can be done to minimize the amount of trust required from the user? Perhaps publishing results of application testing? Third-party testing?
This might be a bad idea, but, can the garbling strategy (e.g., block vs IID) change dynamically as a function of the number of survey respondents?

Closed this for a formal wrap-up of the project.


Create Event Request - Table 27 - OnBeforeCheckPurchLine

Add the following procedure customization, please:
local procedure CheckPurchLine(CurrFieldNo: Integer)
        var
            IsHandled: Boolean;
            PurchaseLine: Record "Purchase Line";
        begin
            OnBeforeCheckPurchLine(IsHandled, Rec, CurrFieldNo);//new Event
            if IsHandled then
                exit;

            PurchaseLine.SetCurrentKey(Type, "No.");
            PurchaseLine.SetRange(Type, PurchaseLine.Type::Item);
            PurchaseLine.SetRange("No.", "No.");
            if PurchaseLine.FindFirst() then begin
                if CurrFieldNo = 0 then
                    Error(Text000, TableCaption(), "No.", PurchaseLine."Document Type");
                if CurrFieldNo = FieldNo(Type) then
                    Error(CannotChangeFieldErr, FieldCaption(Type), TableCaption(), "No.", PurchaseLine.TableCaption());
            end;
        end;

        [IntegrationEvent(false, false)]
        local procedure OnBeforeCheckPurchLine(var IsHandled: Boolean; Item: Record Item; CurrentFieldNo: Integer)
        begin
        end;

@AlexanderYakunin
Hello. Have you had a chance to review this request? Are there any updates on this?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11042.


Fix show ports shear

Hi @joamatab ,
This PR fixes issues with visualizing the port face in complex scenarios, particularly when a non-zero shear_angle is set. The fix sets the attribute  Port.info["face"] to the normalized delta of waveguide face from its center point. In this way, we can retain a definition of the face which is robust to arbitrary transformations of the cell reference later on. I think this solution should be robust to other complex "non-normal face" situations in the future, should there be any, as long as they are created via extrude().
Complex example behavior:
import gdsfactory as gf

if __name__ == "__main__":
    P = gf.path.euler()

    s = gf.Section(width=3, offset=0, layer=gf.LAYER.SLAB90, name="slab")
    X1 = gf.CrossSection(
        width=1,
        offset=0,
        layer=gf.LAYER.WG,
        name="core",
        port_names=("o1", "o2"),
        sections=[s],
    )
    s2 = gf.Section(width=2, offset=0, layer=gf.LAYER.SLAB90, name="slab")
    X2 = gf.CrossSection(
        width=0.5,
        offset=0,
        layer=gf.LAYER.WG,
        name="core",
        port_names=("o1", "o2"),
        sections=[s2],
    )
    t = gf.path.transition(X1, X2, width_type="linear")
    c = gf.path.extrude(P, t, shear_angle_start=10, shear_angle_end=45)
    c2 = gf.Component()
    r = c2 << c
    r.movey(-100)
    r.rotate(30)
    c2.add_ports(r.ports)
    c2 = c2.flatten()
    c2.show(show_ports=True)

Fixes #483

Zoomed in diagram of what's going on at the port:

The triangle is formed by the two endpoints of the face, p1 and p2, as well as p0, which is placed directly straight from the port center, in the orientation of the port, a half-port-width away. p1 and p2 need not be normal to the face, as is the case when a shear-angle is applied.

looks great! thank you Troy!


Query Parameter extracted from Object doesn't recognize public field without getter

Version: 2.9.0
Actually the following this issue:
https://github.com/springfox/springfox/issues/1625
It's currently WORKING for me if the POJO parameter has getter
public class DateRange {

	public String from;

	public String to;

	public String getFrom() {
		return from;
	}

	public String getTo() {
		return to;
	}
}

But if I remove the getters, won't work
public class DateRange {

	public String from;

	public String to;

}

Should be straight-forward to reproduce so not submitting a demo.
I know I can use some setter/getter preprocessor like https://projectlombok.org/, but would be nice to bbe able to recognize public field in springfox as well 🕺 .

Thanks for reporting!

Thank you for fixing it!

you're welcome!

Hi everyone, I have a related question about this change.
Previously I rely on this behavior to ignore a POJO's field from being included in the generated swagger file. What's the correct approach if we want to hide a field from POJO as in this example?


Game broken

When attempting to access this at https://githubschool.github.io/github-games-crosenberg16/, I am getting a 404. This could be caused by a couple things:

GitHub pages needs to be enabled on master. You can fix this in the repository settings.
the index.html file is incorrectly named inde.html. We will fix this together in class.

Can you please fix the first bullet @crosenberg16?

fixed both


Incredibly long time to backfill repos.

Hi,
I have seen a few other comments with the same issue, however none seem to be on the same scale as our problem.
We migrated to Atlassian Cloud a couple of weeks ago, installed the Jira <> Github plugin and started backfilling things. A couple weeks later and its still backfilling. We are currently on 966/4692 repos.
We have just noticed as well that some repos have automatically generating commits, so wonder if that might be the issue.
Right now, we are wondering the following:

What happens when we restart the backfill? Does it clear everything it has already done and start from scratch? Would data be lost? Would users notice that links are missing?
Can you check the progress of a backfill, or are we just flying blind and hoping that it finishes eventually.

Thanks,
Sam Hardern

Hi again,
Another week later and our backfill is still at 966. Any help that can be given on this would be much appreciated.
Thanks,
Sam

Hey @shardern. I've just updated our FAQs doc which will hopefully give you some more insight into this issue. Please let me know if you have more questions.

Hi,
Thanks for sending that. Good to know that our users can create new links and they will appear. Any idea if there is a way to track specific which repo is being backfilled at the moment? It might help us identify which repo the backfill is stuck on.
Additionally, can you clarify what happens to existing links if we restart the backfill? Does it clear everything it has already filled, or will that data be retained?
Thanks for the help.

Hi @rachellerathbone - to add to Sam's question, I saw in the instructions that if the backfill gets stuck, we should identify the large repo it's stuck on, remove it, and then restart the backfill. How can we know which repo the backfill is currently stuck on, are there logs anywhere for this?
What we're struggling with, is that we can restart the backfill but:

Is that going to wipe all Github->Jira links and recreate them again, which is an issue for our users
Is the backfill going to get stuck again at the same point
If yes, how can we identify and remove the repo its stuck on

We've started doing some preliminary work on making the backfill more visible to our users.  The cause of slowness is 2 pronged:
1 - Github API has a throttle limit so we can't get everything right away and need to wait.  This includes very large and old repositories with thousands if not hundreds of thousands of commits.
2 - For some larger organizations with large repos, the Github API will just up and fail for no reason and return a 500.  These needs to be investigated by github themselves to figure out a fix.  Sadly, our backfill process will get blocked on these as it wants to get all the data our of all repos.
We're working on making everything more transparent and easier to raise a case with Github when something does go wrong on their end.

Hi @mboudreau - Thanks for the response. I'd be surprised at this point if this particular repo was so large it was still being backfilled more than a month later (although not outside the realm of possibility). I will contact our Github team and see if they think it would be worth contacting Github in case its the second option that we have encountered.
Looking forward to more features being added to the tool as its a great connector used by lots of our users.
Thanks

Hi,
we have the same issue with to long backfill of our github repos. even if we backfill only 24 hours back It takes like 5 days to backfill the data and meanwhile we lose the historical data in the development field for all tickets.
This is a huge issue for our developers and it is a showstopper for some of their work.
Also, some of the automations  in Jira had to be stopped due to wrong status of PRs shown in Jira, but different (correct) in Github.
any advise how to fix that and what we can do to make sure our data is current and accurate will be highly appreciated. not to mention that the backfill needs to be automatic - when there is a change - show it in a prompt manner.

Hello,
We have the same problem. Is there already a solution foreseeable or is there a workaround?
Kind Regards
Holger

Hello. any progress or workarounds here?

Any update on this issue???

Is there any chance that this bug will be fixed in a timely manner?

Hey folks, we have made significant improvements in backfill performance during the past several months. Could you please try to restart backfill and report back how it went?

If you still have troubles, please don't hesitate to re-open the issue and provide your Jira hostname so we can troubleshoot on case-by-case basis.


2 fixes on new conversations and removal

New conversations via new message received

When new conversations appear, they have no avatar on the conversation list and impossible to open details

Handle to add client_conversation was already available, but it was a bit conservative (only adding when conversation did not exist)
When a conversation starts via a new message received a conv. skeleton is created thus rendering the handle useless
Removal of conversation
after confirming that we want to remove, changes to top conversation
previous behavior kept interface to remove user (that was already removed)

had to make a correction to part of this commit as unread count was not correct.
pushed to master
see 7b97e167bc7b10de4e5a2f8e8a04c00c48f2c68a


Package index-server-monitor in indexing-tools

Note that this is pending for https://reviews.llvm.org/D101516 to land first.

https://github.com/llvm/llvm-project/commit/34593ae9982ad267639893ed4ce41242f9493056 has now landed, this is safe to merge.


Write documentation in Swahili

I'm looking for someone to convert all documentation that exists in the docs/en folder in English to Swahili in the docs/sw folder.
Important that spelling is correct and that the information is accurate according to what was written in the english docs.

This has been partially updated by @MGASALUCAS but we'll need more help with it in November.

Thank you @jurmy24  looking forward to it.

Hey @MGASALUCAS, we have updated the GETTING_STARTED.md document (development branch) in this PR. I was wondering if you could translate the changes into Swahili, so we can keep both documents up to date 😉

Hi @alvaro-mazcu , Got it and congrats, I will update that.


Per-stroke parameters

This pull request introduces per-stroke parameters, meaning each stroke of the brush can have an independent size, color, etc.
It also introduces the new spacing parameter that allows you to put blits along the brush path closer or further apart.
It also contains some optimizations that makes drawing overall quite a bit faster.
It does not yet fix bug https://github.com/GraphiteEditor/Graphite/issues/1237.

I'm done with work for today, but I do notice a strange 'instability' issue while drawing - the blits for some reason move around a bit.

@orlp Great work on this so far, it works really nicely.
I've added a commit to your branch for inserting a brush stroke node into a layer with an image in (just drag a png into the viewport and then draw with the brush tool on top of it). As part of that I've also committed a fix for the transform issue you were having - hopefully that is helpful.

Regression to fix before merging:

I don't have time to fix this, but I suspect it is something to do with the ExtendImageNode as this only starts happening when the brush strokes are not entirely contained within the background image.

@orlp we'll merge this now and have you fix the bounds expansion bug (video above) in a followup PR when you get the chance. Thanks.


Updating image-dimensions in accordance to generator scripts

The current codes assume inputs of height 32 pixels, while the images generated by the first python script were of sizes 36 pixels. I have updated the codes with this fix. Please merge the PR if possible :)

thanks @NightFury13 , you are right.


React-Native(v.0.68.2) iOS TestFlight/AppStore app random crashes across the app with error-RCTFatal + 668 (RCTAssert.m:146)

Description
Dear All,
I am facing React-Native iOS TestFlight app random crashes with exception inside the react-native framework.
Crashlog capture through TestFlight app from AppStoreConnect is as follows:

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note:  EXC_CORPSE_NOTIFY
Triggered by Thread:  15
Last Exception Backtrace:
0   CoreFoundation                	0x180cf7d1c _exceptionPreprocess + 216 (NSException.m:200)
1   libobjc.A.dylib               	0x198517ee4 objc_exception_throw + 56 (objc-exception.mm:565)
2   MyAppName              	        0x10020b168 RCTFatal + 668 (RCTAssert.m:146)
3   MyAppName             	        0x10028a84c -[RCTExceptionsManager reportFatal:stack:exceptionId:] + 488 (RCTExceptionsManager.mm:68)
4   MyAppName             	        0x10028b12c -[RCTExceptionsManager reportException:] + 1408 (RCTExceptionsManager.mm:135)
5   CoreFoundation                	0x180c85dd0 invoking + 144 (:-1)
6   CoreFoundation                	0x180ca1ea8 -[NSInvocation invoke] + 300 (NSForwarding.m:3378)
7   CoreFoundation                	0x180cd62cc -[NSInvocation invokeWithTarget:] + 76 (NSForwarding.m:3475)
8   MyAppName              	        0x10023df3c -[RCTModuleMethod invokeWithBridge:module:arguments:] + 460 (RCTModuleMethod.mm:584)
9   MyAppName             	        0x100240530 facebook::react::invokeInner(RCTBridge*, RCTModuleData*, unsigned int, folly::dynamic const&, int, (anonymous namespace)::SchedulingContext) + 540 (RCTNativeModule.mm:183)
10  MyAppName               	0x100240160 facebook::react::RCTNativeModule::invoke(unsigned int, folly::dynamic&&, int)::$_0::operator()() const + 68 (RCTNativeModule.mm:104)
11  MyAppName             	        0x100240160 invocation function for block in facebook::react::RCTNativeModule::invoke(unsigned int, folly::dynamic&&, int) + 112 (RCTNativeModule.mm:95)
12  libdispatch.dylib             	0x1809b7094 _dispatch_call_block_and_release + 24 (init.c:1517)
13  libdispatch.dylib             	0x1809b8094 _dispatch_client_callout + 16 (object.m:560)
14  libdispatch.dylib             	0x1809934a4 _dispatch_lane_serial_drain$VARIANT$armv81 + 600 (inline_internal.h:2622)
15  libdispatch.dylib             	0x180993f44 _dispatch_lane_invoke$VARIANT$armv81 + 388 (queue.c:3944)
16  libdispatch.dylib             	0x18099d8e0 _dispatch_workloop_worker_thread + 608 (queue.c:6732)
17  libsystem_pthread.dylib       	0x1dc044e10 _pthread_wqthread + 284 (pthread.c:2599)
18  libsystem_pthread.dylib       	0x1dc04493c start_wqthread + 8 (:-1)

I tried to enable the Hermes-engine by adding the following piece of lines in iOS Podfile and did the pod install / update:
use_react_native!(
:path => config[:reactNativePath],
# to enable hermes on iOS, change false to true and then install pods
:hermes_enabled => true
)
But, no use of it. On launching the app, immediately app is crashing all the time due to hermes-engine. So, I disabled it again.

ReactNative version: 0.68.2
Tested iOS devices: iPhone 12 (iOS version: 15.6), and iPhone 8 (iOS version: 15.6 & 15.4).
References: https://developer.apple.com/forums/thread/704860

Appreciate on your quick response by sharing the fix / your thoughts, if any one found the solution, as we are stuck on fixing this issue.
Thanks in advance.
Version
0.68.2
Output of npx react-native info
lg@apples-MacBook-Pro homecinema-companion-app-mobile % npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 12.4
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 198.98 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 14.16.0 - /usr/local/bin/node
Yarn: Not Found
npm: 6.14.11 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7784292
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
Languages:
Java: 12.0.2 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.68.2 => 0.68.2
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Random crashes, there is no specific steps to reproduce, but only with TestFlight / AppStore apps, not debug mode app.
Snack, code example, screenshot, or link to a repository
On enabling hermes-engine, app is crashing, screenshot is as follows:

i hava the same problem，there are solutions?

@react-native-bot  Is there a solution？

@black1997 @sivaprasadkv did you guys manage to fix this issue?

@sivaprasadkv sorry for the issue. A couple of questions to have more information:

Is it happening ONLY with Hermes enabled? Without Hermes does it works properly?
Is it still happening in the latest version of React Native? The lowest version we support is 0.69, but it would be helpful to understand if a recent version may have fixed it (so we can bisect the problem and backport it)

Closing as the author is unresponsive


Consider some sort of Stream::windows combinator to match chunks

Slices have a chunks and a windows method.  Streams have a chunks but not windows.
For my own use, I wrote
use futures::{Async, Poll};
use futures::stream::{Stream, Fuse};

/// The Stream created from calling `PairableStream::pair`.
pub struct PairStream<S>
    where S: Stream
{
    queued: Option<S::Item>,
    stream: Fuse<S>,
}

impl<S> PairStream<S>
    where S: Stream,
          S::Item: Clone
{
    fn new(stream: S) -> PairStream<S> {
        PairStream {
            queued: None,
            stream: stream.fuse(),
        }
    }
}

impl<S> Stream for PairStream<S>
    where S: Stream,
          S::Item: Clone
{
    type Item = (<S as Stream>::Item, <S as Stream>::Item);
    type Error = <S as Stream>::Error;

    fn poll(&mut self) -> Poll<Option<Self::Item>, Self::Error> {
        loop {
            match try_ready!(self.stream.poll()) {
                None => return Ok(Async::Ready(None)),
                Some(item) => {
                    if self.queued.is_none() {
                        self.queued = Some(item);
                    } else {
                        let first = self.queued.take().unwrap();
                        self.queued = Some(item.clone());
                        return Ok(Some((first, item)).into());
                    }
                }
            }
        }
    }
}

/// A trait to put the `pairs` method on Streams.
pub trait PairableStream
    where Self: Stream + Sized,
          Self::Item: Clone
{
    /// Consume this stream and return a new stream that provides pairs of
    /// elements from this stream.  Pairs are returned in order.  If the
    /// stream only contains one element no pairs will ever be returned.
    fn pairs(self) -> PairStream<Self>;
}

impl<S> PairableStream for S
    where S: Stream + Sized,
          S::Item: Clone
{
    fn pairs(self) -> PairStream<S> {
        PairStream::new(self)
    }
}

You might find a more generic version of that useful.

Seems plausible to me! It's unfortunate that <[T]>::windows doesn't have any bounds and this'd have to have an Item: Clone bound, but I suppose that's inevitable.


Ensure image for all arch in the same file

They are doing this for the same purpose, should in the
same file.
Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

/cc @dieterreuter

ping @Govinda-Fichtner, @StefanScherer.
Please check where is the best place to handle the Docker images for the integration tests. I'd like to have it only within a single file, if this is possible. Then it's easier to maintain.
Even with this PR, the logic is split into two files, .ensure-frozen-images and .ensure-images.

@hqhq Could you explain why it is necessary to have a separate .ensure-images?
@hqhq @LK4D4 @DieterReuter @StefanScherer I personally feel it would reduce the level of indirection if we just kept everything in one place. In my opinion this should be the existing .ensure-frozen-images.
I think there is room for improvement when it comes to fetching and tagging the architecture specific images. Here it should be possible to come up with a generic approach that gets its input from variables defined in the architecture specific Dockerfile.
As a first step I would like to keep everything in .ensure-frozen-images. Afterwards I would love to create a PR that comes up with a generic solution for fetching and tagging the architecture specific images in .ensure-frozen-images.
What do you think?

@Govinda-Fichtner Agreed, I don't see the necessity to have a separate .ensure-images, I've changed the PR, PTAL.

LGTM, but it looks like it needs a rebase.

LGTM.

Close in favor of https://github.com/docker/docker/pull/18506


Refactor components with hooks

Project name: Math Magicians - refactor with hooks❗❗
Project description: In this project the Calculator component that was developed in the past projects will be refactored. Instead of using class based components, now hooks will be used.
Project requirements:

Refactor the Calculator component (components/Calculator.js) from a class based component to a functional component with hooks.
After the refactor is done, test the app in the browser. It should keep the same functionality.

❗❗❗❗❗❗ IMPORTANT NOTE: If you already use functional components, you can create a GitHub issue in which you describe how you use functional components and ask for a code review based on your issue.
Note: The project was at first developed using class based component. But it was refactored to a functional component based on code reviewer's feedback.
Project requirements link: https://github.com/microverseinc/curriculum-react-redux/blob/main/math-magicians/project_refactor_with_hooks.md

Hi @lenkon,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

The calculator is working fine ✔
Refactor is done ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @roshan-bajgain ,
Thanks for your valuable time in going through my code.
Best Regards,
K. Inoulen Shanongba


lint(all): upgrade golangci-lint to v1.50.1

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/7271
What is changed and how it works?

Upgrade golangci-lint to v1.50.1
Remove deprecated lint varcheck, structcheck, ifshort, deadcode

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

Codecov Report

Merging #7558 (6266077) into master (c0c9a43) will increase coverage by 0.0494%.
The diff coverage is 51.9580%.

Additional details and impacted files

Flag
Coverage Δ

cdc
67.0443% <45.9825%> (-0.3601%)
:arrow_down:

dm
52.1123% <73.6994%> (+0.0966%)
:arrow_up:

engine
61.4584% <51.9047%> (+0.4310%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #7558        +/-   ##
================================================
+ Coverage   59.8343%   59.8838%   +0.0494%
================================================
  Files           804        822        +18
  Lines         92365      93835      +1470
================================================
+ Hits          55266      56192       +926
- Misses        32287      32770       +483
- Partials       4812       4873        +61

/merge

/run-engine-integration-test


fastest way to process multiple content images for video

Perhaps I am missing from the docs, but it does not seem you can pass in multiple content images. Do we need to make a script that processes batches of files?

Simple script found from this video. Also it seems from #171 you should probably use a constant seed.
for a in 'seq -w 000 100'; do
th neural_style.lua \
-gpu 0 \
-seed 100 \
-style_image style.png \
-content_image frame_$a.png \
-output_image result_$a.png


Include documentation in sources

In developing the sometimes not connected to the Internet. It would be great to have on hand offline version of the documentation, the source code is located.

I'd like the idea :). The same doc and maybe with more possibles examples. What about using markdown ;)

The documentation is available online and can be cloned locally. https://github.com/Intervention/docs


CSRF vulnerability almost all forms

For example USer creation form has no csrf token validation, so that attacker can create own account by sending malicious link
POC :

last_name	<input type="text" value="abuthahir++" name="last_name">

username	<input type="text" value="abu" name="username">

email	<input type="text"<EMAIL_ADDRESS>name="email">

role	<input type="text" value="" name="role">

password	<input type="text" value="reset!23" name="password">

<input type="submit" value="http://django-crm.micropyramid.com/users/create/"></form>```

EXPLOIT REQUEST:

POST /users/create/ HTTP/1.1
Host: django-crm.micropyramid.com
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-GB,en;q=0.5
Accept-Encoding: gzip, deflate
Referer: https://django-crm.micropyramid.com/users/create/
Content-Type: application/x-www-form-urlencoded
Content-Length: 112
Cookie: sessionid=g8up9d4xvqga5rwk1m7f4e4mhxmy111
Connection: close
Upgrade-Insecure-Requests: 1

first_name=syed&last_name=abuthahir++&username=abu&email=test%40gmail.com&role=&password=reset%2123

User Edit Form has CSRF
Expoit Request:
POST /users/25/edit/ HTTP/1.1
Host: django-crm.micropyramid.com
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8
Accept-Language: en-GB,en;q=0.5
Accept-Encoding: gzip, deflate
Referer: https://django-crm.micropyramid.com/users/25/edit/
Content-Type: application/x-www-form-urlencoded
Content-Length: 81
Cookie: csrftoken=zTfdp0GE2eqwRNnPNqfBX4seYXdFq8j8JtyzmYtaLWu3waAFjyfa7umOscWkO1iQ; sessionid=kta9sxfstfmi6mi2r4vankx5h1zuvvic
Connection: close
Upgrade-Insecure-Requests: 1
first_name=Adam&last_name=Chan&username=adamchan&email=test%40test.com&role=ADMIN

CSRF while delete account
Exploit link https://django-crm.micropyramid.com/accounts/123/delete/

there is no use if csrf token present in cookie

csrf token should be present in form or custom header as well as validate that csrf token on server side before save the forms or delete something.

Reference : https://www.owasp.org/index.php/Top_10_2013-A8-Cross-Site_Request_Forgery_(CSRF)

@abuvanth thanks for your observation and there is no chance of CSRF for auth protected applications. CSRF is for something like contact forms which doesn't not need to get authenticated to access.
Read "Am I Vulnerable To 'Cross-Site Request Forgery (CSRF)'?" section in the OWASP link provided by you.
There are very simple scripts we can execute in terminal to get CSRF token and send it back in no time.
Anyway, we will review and add o remove it completely to eliminate these confusions about security.
Thank you.


刪除測驗應用程序的 PR 構建過程

https://github.com/jlooper @https://github.com/microsoft/IoT-For-Beginners/blob/b3cde63e788b047a3286693f4f5c8c56afef78ea/.github/workflows/azure-static-web-apps-brave-island-0b7c7f50f.yml#L32

I don't see a problem, can you be more descriptive please?


Is systeminformation can integrated with scanning to network?

Hi all,
I'm mostly find this module dependencies by googling after all, and it was great! I found something that I want to build with this module.
But I have problem right now, like I want to integrate this module to network scanner so, the specific IP on network can show the specification of hardware details, then I've been search all of the documentation but i've got nothing.
Is there any module that can used for scan the network and get the IP, and the IP can be checked for scanning the system information? or maybe I can integrate it with any language e.g Python?
p.s I've been using this dependencies with Python but i've got nothing at all, if u guys can help please can you recommend me what tools or framework that can used for scanning the network and the specific host because i've been looking so hard for this solution.

@rizkyfaza20 here some comments:
Generally, each system on a network would prohibit to track detailed system information due to security reasons. So there are of course possibilities in a secure network environment (like e.g. wmic on windows would allow to get data also from other computers if authorization is correct). So if you do not have access to the other machines at the network: this should not. be possible!
 As soon as you scanner detects an IP of one of your machines, the scanner requests data from the client and the client then respond with the wanted data. Be sure to protect the API, so that no one else can retrieve your machines data ;-)
Closing this for now.

Dear Sebastian,
Thank you for your reply, I hope i can implement it very soon.
Best regards,
Rizky Faza
Pada tanggal Sab, 20 Feb 2021 pukul 13.25 Sebastian Hildebrandt <
<EMAIL_ADDRESS>menulis:

Closed #494
https://github.com/sebhildebrandt/systeminformation/issues/494.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebhildebrandt/systeminformation/issues/494#event-4355300115,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AICQMNNFARWYN6YKE5K7TL3S76Z5HANCNFSM4X3VLMIA
.


Add a guide on how to change the endpoint

fosscord locked as too heated and limited conversation to collaborators

Why did you assign me?


Using persistent_disk_fs: xfs on GCP causes deployment to fail

When env.persistent_disk_fs is set to xfs on GCP, it causes the deployment to fail with this message:
13:26:19 | Error: Action Failed get_task: Task 976303a9-dd64-496d-6b5f-b959d2263eb3 result: Mounting persistent disk: Formatting partition with xfs: Shelling out to mkfs.xfs: Running command: 'mkfs.xfs /dev/sdb1', stdout: '', stderr: 'warning: device is not properly aligned /dev/sdb1
Use -f to force usage of a misaligned device

The relevant changes are:
persistent_disk: 10000
env:
  persistent_disk_fs: xfs

The same experiment works fine in AWS.
The  grootfs team is specially interested in this issue because this might impact some future feature requests where the ephemeral disk also could have and xfs option.
Here is a minimal bosh manifet to reproduce: (Note that the grootfs release is only used because it needs one, works with any release).
---
name: persistent-test
stemcells:
- alias: trusty
  os: ubuntu-trusty
  version: latest
releases:
  - name: grootfs
    version: latest
jobs:
- name: persistent-test
  instances: 1
  vm_type: n1-standard-1
  stemcell: trusty
  lifecycle: service
  persistent_disk: 10000
  env:
    persistent_disk_fs: xfs
  azs:
  - z1
  networks:
  - name: bosh-deployments
  jobs:
    - name: grootfs
      release: grootfs
update:
  canaries: 1
  max_in_flight: 3
  serial: false
  canary_watch_time: 1000-240000
  update_watch_time: 1000-240000

@cunnie thoughts?

That's interesting.
I'd expect that to occur with an MBR-formatted disk but not a GPT formatted disk (for no other reasons than MBR is old and assumes 512byte sectors (which used to be all the rage in the seventies, eighties, and nineties)). Also there were often alignment problems (e.g. you wanted to have the partitions on a cylinder boundary, where Cylinders consisted of many Heads, and Heads were made up of Sectors) ("CHS") (A bad legacy of MBR).
A person who has a similar problem has an MBR disk formatted via cfdisk and fixed it by reformatting the drive with GPT via parted

🆙
Is there any update on this bug?

Can you provide the stemcell you're using? Also, does this happen every time?

I've just hit this today:
Error: Action Failed get_task: Task c74caa06-8c76-4e8e-55d2-6193524ecaac result: Mounting persistent disk: Formatting partition with xfs: Shelling out to mkfs.xfs: Running command: 'mkfs.xfs /dev/sdb1', stdout: '', stderr: 'warning: device is not properly aligned /dev/sdb1
Use -f to force usage of a misaligned device
': exit status 1

Running 264.7.0 with stemcell bosh-google-kvm-ubuntu-trusty-go_agent/3541.5

We experience the same issue deploying MongoDB 3.4 on GCP.
According to the MongoDB documentation:

With the WiredTiger storage engine, use of XFS is strongly recommended to avoid performance issues that may occur when using EXT4 with WiredTiger.

As this seems to be a general issue, blocking the recommended way of deploying MongoDB 3.4+, is it possible to update the agent to use GPT formatted disks by default?

I'm seeing MBR formatted persistent disks from bosh by default on GCP (bosh-google-kvm-ubuntu-trusty-go_agent-3468.13):
master/8679c9bb-d655-4e6c-8a53-0468599f7c50:~$ sudo parted -l
Model: Google PersistentDisk (scsi)
Disk /dev/sda: 21.5GB
Sector size (logical/physical): 512B/4096B
Partition Table: msdos

Number  Start   End     Size    Type     File system     Flags
 1      32.3kB  3071MB  3071MB  primary  ext4
 2      3071MB  6951MB  3880MB  primary  linux-swap(v1)
 3      6951MB  21.5GB  14.5GB  primary  ext4

Model: Google PersistentDisk (scsi)
Disk /dev/sdb: 5369MB
Sector size (logical/physical): 512B/4096B
Partition Table: msdos

Number  Start  End     Size    Type     File system  Flags
 1      512B   5364MB  5364MB  primary  ext4

@cunnie is this different from your expectations?
@ansd It looks like there's a few options to force the agent to use parted instead of sfdisk today:

Use a persistent disk over 2TB (src). This will certainly provide a GPT formatted disk.
Use the Ubuntu Xenial stemcell (src). This may work, assuming parted has a different set of defaults.

@cunnie @dpb587-pivotal - we have confirmation that >2TB disks will force parted and unlocks using XFS on GCP.

we are also enabling parted as a default in upcoming xenial stemcell.
Sent from my iPhone

On Mar 30, 2018, at 10:17 AM, Eric Johnson<EMAIL_ADDRESS>wrote:
@cunnie @dpb587-pivotal - we have confirmation that >2TB disks will force parted and unlocks using XFS on GCP.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

That's great @cppforlife, is there a rough ETA for when they'd be available on bosh.io?

xenial v40 is on bosh.io.


Static page

Creating pull request for static page verification test
Here assuming that index.html and appspec.yml files are copied to scripts/pipeline folder and the same is copied in this PR

Remove all unnecessary lines of code. Leave only ones necessary to implement static page verification test workflow.

Change destination branch to dev.


~/.credentials-private-repo-netrc file for curl

Curl can read credentials from netrc files.
Then we can get rid of the hack in
https://github.com/scala/scala/pull/4481/files#diff-661d447ea0c178cb62b2e4e9b2c84f66R432

@adriaanm added a commit to move workers to java 7

Aha! Another way to do this :-) At https://github.com/adriaanm/binfu/blob/master/sonafu.sh#L8, I used the -K option to slurp in .sonatype-curl. I have a mild preference to stick to this, but happy to discuss.
Regarding Java 7 -- I think we should go deep here and figure out how to install and manage multiple JDKs on windows.

Ah, I didn't find -K. Both approaches work equally well for me. Then we have to generate a .sonatype-curl?

Ja, we'd need a .private-repo-curl


"Can't find empty area for the patch :("

Hi,
I just would like to mention that latest patch (07a46b5) works with latest Windows 10 1809 (build 17763.737)
Earlier patch (debf825) had an error after the last update of Windows 10 1809:  "Can't find empty area for the patch :("
Br,
Zoltan

Hi,
I don't know which Windows update has broken it again... but the issue is back. Could you help. please? :)

Hi,
same here. Help, please. Can't live with constant taskbar flashing.
One of those Windows 10 updates must have broken this script:

Security Update for Microsoft Windows (KB5044273)
Update for Microsoft Windows (KB5044029)
Servicing Stack 10.0.19041.4950

It looks like Update for Microsoft Windows (KB5044029) breaks DisableFlashingTaskbarButtons.

is there any fix for this

Did any of you try the fix in this:
https://github.com/Ciantic/DisableFlashingTaskbarButtons/pull/7/files
I don't have Window 10 anymore, it's hard to try. I guess I could try with some Hyper-V image.

I merged the pull request, I don't have way to verify, but hope it works?

Thank you! The fix works :)


fix: Ensure all lazy loaded modules issue warning instead of errors

Lazy loaded modules that are blocked from loading by third party tools such as adblocking mechanisms will issue a warning to console instead of throwing an error.

Overview

Related Issue(s)
NR-335501

Testing

@cwli24 Hey there, just found this after getting alerted to 5000+ JS errors in Bugsnag! It caused us to hit our rate limits and we're losing insight on stuff that matters. Do you know if this will be fixed soon, as it's now affecting customers in production... Thanks in advance 🙏

@JackWH Sorry about this, we are getting this rolled out now.  Should hopefully reach customer hands within a few hours

@metal-messiah Good to know, thanks for the speedy reply 😊


fix(lint): correct lint issue breaking semantic release

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #109
Summary:
Fix linting issue breaking semantic release
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


bosh create --final release failing

During final release call we were getting error.
Building packages
-----------------
Building golang...
  Using final version '95c358c1eeabe9495e089de333e0c91eee2fef0c'
  Uploading final version '95c358c1eeabe9495e089de333e0c91eee2fef0c'...
  Uploaded, blobstore id '5924ebab-6dec-411b-86c5-8491e94064fc'

Building bosh-helpers...
  Using final version 'e1bbff85fa1e4b1d51887ba6ecff6949ca92e8f6'
  Uploading final version 'e1bbff85fa1e4b1d51887ba6ecff6949ca92e8f6'...
  Uploaded, blobstore id 'ad205f16-f98a-4045-a609-74e9b341c3a9'

Building docker...
  Using final version '45062aefa4be8e9f0a2af53e5591e04be5a8db0b'
  Uploading final version '45062aefa4be8e9f0a2af53e5591e04be5a8db0b'...
  Uploaded, blobstore id 'f932657e-3a77-414d-b90d-fe2c2a42f138'

Building service-fabrik-broker...
  No artifact found for service-fabrik-broker
  Generating...
  Pre-packaging...
  Generated version 'aec6a7837e3d7b2995506145cbeada2c4134ca8f'
  Uploading final version 'aec6a7837e3d7b2995506145cbeada2c4134ca8f'...
Blobstore error: Failed to create object, S3 response error code NoSuchKey: The specified key does not exist.

We were using bosh cli v1 (BOSH 1.3262.26.0) to create final release.
The issue is solved after separating bucket name and folder parameter in config/final.yml

The issue fixed in the PR https://github.com/SAP/service-fabrik-boshrelease/pull/5


Support multi webapp

#202

Pull Request Test Coverage Report for Build 547

242 of 399 (60.65%)  changed or added relevant lines in 31 files are covered.
67 unchanged lines in 27 files lost coverage.
Overall coverage increased (+1.5%) to 49.157%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java
2
3
66.67%

sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/constant/Constants.java
0
1
0.0%

sofa-ark-parent/support/ark-springboot-integration/ark-compatible-springboot1/src/main/java/com/alipay/sofa/ark/springboot1/endpoint/IntrospectBizEndpoint.java
2
3
66.67%

sofa-ark-parent/support/ark-springboot-integration/ark-compatible-springboot1/src/main/java/com/alipay/sofa/ark/springboot1/endpoint/IntrospectBizEndpointMvcAdapter.java
3
4
75.0%

sofa-ark-parent/support/ark-springboot-integration/ark-compatible-springboot2/src/main/java/com/alipay/sofa/ark/springboot2/endpoint/IntrospectBizEndpoint.java
1
2
50.0%

sofa-ark-plugin/config-ark-plugin/src/main/java/com/alipay/sofa/ark/config/OperationProcessor.java
0
1
0.0%

sofa-ark-plugin/config-ark-plugin/src/main/java/com/alipay/sofa/ark/config/zk/ZookeeperConfigurator.java
23
24
95.83%

sofa-ark-plugin/config-ark-plugin/src/main/java/com/alipay/sofa/ark/config/RegistryConfig.java
11
14
78.57%

sofa-ark-parent/core/api/src/main/java/com/alipay/sofa/ark/api/ArkConfigs.java
0
4
0.0%

sofa-ark-plugin/config-ark-plugin/src/main/java/com/alipay/sofa/ark/config/util/NetUtils.java
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

sofa-ark-parent/core/common/src/main/java/com/alipay/sofa/ark/common/thread/CommonThreadPool.java
1
0.0%

sofa-ark-parent/core/common/src/main/java/com/alipay/sofa/ark/common/util/FileUtils.java
1
0.0%

sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/argument/LaunchCommand.java
1
73.33%

sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java
1
83.72%

sofa-ark-parent/support/ark-support-starter/src/main/java/com/alipay/sofa/ark/support/thread/IsolatedThreadGroup.java
1
0.0%

sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/pipeline/HandleArchiveStage.java
1
55.0%

sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/test/TestClassLoader.java
1
0.0%

sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/test/TestHelper.java
1
0.0%

sofa-ark-parent/support/ark-support-starter/src/main/java/com/alipay/sofa/ark/support/listener/ArkTestNGAlterSuiteListener.java
1
91.18%

sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/service/plugin/PluginDeployServiceImpl.java
1
83.72%

Totals

Change from base Build 543:
1.5%

Covered Lines:
1632

Relevant Lines:
3320

💛  - Coveralls


Fix typo

Now that I think about it, it might not have been a typo after all.
At a first glance it seemed that your internet browsing sounded better, but if it's wrong feel free to close this 🙂

Yup @XhmikosR this is a typo.  Thanks!
Merging.


fix: 4900 - backup_scheme.xml type fix

What

Typo in backup_scheme.xml, which crashes the build on FDroid.
Detected by @licaon-kter

Fixes bug(s)

Fixes: #4900

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5ffdca3) 9.68% compared to head (a3fa7e1) 9.67%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4901      +/-   ##
==========================================
- Coverage     9.68%   9.67%   -0.01%
==========================================
  Files          318     318
  Lines        16121   16115       -6
==========================================
- Hits          1561    1559       -2
+ Misses       14560   14556       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


"HID(R):LIBUSB_ERROR_TIMEOUT" error when trying to flash bootloader to iMX8MQ EVK board

Constantly failing with "HID(R):LIBUSB_ERROR_TIMEOUT" when using UUU to flash eMMC.
I'm using ubuntu guest on Apple MacBook with M1 SoC.  Please see the screenshot of failing messages.
Between these two commands,  I enabled "SE blank M859" USB ID and "USB mass storage" for ubuntu guest in the background.

Would much appreciate your support!
Thanks,
BTW,  device side logs captured here for reference.
u-boot=> ▒
U-Boot SPL 2022.04-lf_v2022.04+gbb6108298d (Sep 05 2022 - 09:51:39 +0000)
PMIC:  PFUZE100 ID=0x10
DDRINFO: start DRAM init
DDRINFO: DRAM rate 3200MTS
DDRINFO:ddrphy calibration done
DDRINFO: ddrmix config done
SEC0:  RNG instantiated
Normal Boot
Trying to boot from USB SDP
SDP: initialize...
SDP: handle requests...
Downloading file of size 1662208 to 0x40400000... ▒

It looks like SPL dead.

I think I have a related problem. We also get a LIBUSB_ERROR_TIMEOUT.
The UUU Tool does not consistently exit at a fixed step and many of the commands of the "uuu.lst" work fine until the libusberror eventually appears. Hence, initial steps like loading the bootloader or the fsl initramfs work fine. We found that executing commands e.g., with "FSKB: ucmd" are the last ones before the error occurs.
Here is an example output from UUU with an error:
[...]
The partition table has been altered.
Calling ioctl() to re-read partition table.
Syncing disks.
2:19>Okay (0.314s)
2:19>Start Cmd:FBK: ucmd sleep 1
2:19>Fail Bulk(R):LIBUSB_ERROR_TIMEOUT(2.008s)
uuu.lst.txt

I have not seen "ucmd sleep 1" in your script

Sorry my bad. We created another script where we added lots of echos and sleeps to trigger the LIBUSB_ERROR_TIMEOUT every time we run the script. The output from above is from this altered script.
But figured that this would rather add another error than make the error more clear. But nevertheless I added this script here.
uuu_echo_sleep.lst.txt


Error with REQUIRE(ptr == nullptr)

ubuntu trusty
ii  catch                                  1.0+m10git1e2f1d16-1                  amd64        C++ Automated Test Cases in Headers
REQUIRE(opt1 != nullptr);

Is producing the following error:
/usr/include/catch.hpp:683:49: error: ambiguous overload for ‘operator<<’ (operand types are ‘std::ostream {aka std::basic_ostream}’ and ‘std::nullptr_t’)
enum { value = sizeof( testStreamable(s << t) ) == sizeof( TrueType ) };

Please also try {{REQUIRE_FALSE(opt1 == nullptr);}}

Hi, downloaded the latest catch.hpp, and installed it in the development environment, and its fine!!
The ubuntu package is a bit outdated ...
Thanks for the suggestion!
Regards,
Mario

@mjscosta Can you close this issue now? Thx


Not highlighting attack modifiers.

Foundry v9.242
PF2e <IP_ADDRESS>09
Module is not highlighting all modifiers.
Effects altering the target's AC seem to be highlighting properly, but ones affecting the attack are not.

Opened issue simultaneously.

Duplicate of #4, fixed on version 1.1.0!


Download multiple videos

When you try to download multiple videos from the same course it save only the first one. To solve this you could add a simple variable that increases in the for at the end of the name of the output file.

I'm already doing this (with the release v1.1.0).
If a file with the same name already exists, it will renamed adding a timestamp in the filename.
Did you have this problem with the release v1.1.0 too?

Closed for inactivity