[BUG] when using a remote desktop Linux machine, crc cleanup hangs on "Removing pull secret from the keyring"

General information

OS: Linux

CRC version
CodeReady Containers version: 1.25.0+7f9df845
OpenShift version: 4.7.5 (not embedded in executable)

Host Operating System
Connecting to a remote Fedora 32 desktop machine.
Steps to reproduce

ssh remote
crc cleanup

Expected
success
Actual
hangs
Logs
$ crc cleanup
...
DEBU 'nmcli' was found in /usr/bin/nmcli
INFO Removing the crc VM if exists
DEBU Running 'virsh --connect qemu:///system domstate crc'
DEBU Command failed: exit status 1
DEBU stdout:
DEBU stderr: error: failed to get domain 'crc'
INFO Removing pull secret from the keyring
^C

I presume there is a pop-up showing up on the screen of the remote machine. I can't click on it :)
crc start also hangs when it tries to load the secret.

On the remote machines I've tried this on, it's correctly falling back to a prompt:
DEBU Cannot load secret from configuration: empty path
DEBU Cannot load secret from keyring: The name org.freedesktop.secrets was not provided by any .service files
CodeReady Containers requires a pull secret to download content from Red Hat.
You can copy it from the Pull Secret section of https://cloud.redhat.com/openshift/create/local.
? Please enter the pull secret

Can you check if you have something providing org.freedesktop.secrets and if it's running? For example, on my f33 system it's
$ cat /usr/share/dbus-1/services/org.freedesktop.secrets.service
[D-BUS Service]
Name=org.freedesktop.secrets
Exec=/usr/bin/gnome-keyring-daemon --start --foreground --components=secrets


array#clone returns the wrong type if subclassed

Array#clone calls Array(T).new, but it should be calling self.class.new . If it is subclassed, it will not return the subclass type.
def clone
    Array(T).new(size) { |i| @buffer[i].clone.as(T) }
end

API version 0.35.1

I've tried to adress it similar to how I did it in #9871 but as soon as I define only this:
private class ArraySubclass(T) < Array(T)
end

array spec fails with
$ bin/crystal spec spec/std/array_spec.cr
Using compiled compiler at .build/crystal
Showing last frame. Use --error-trace for full trace.

In src/spec/expectations.cr:4:5

 4 | def initialize(@expected_value : T)
     ^---------
Error: no overload matches 'Spec::EqualExpectation(Array(Array(Float64 | Int32)).class)#initialize' with type Array(Array(Float64 | Int32)).class

Overloads are:
 - Spec::EqualExpectation(T)#initialize(expected_value : T)

I'm not sure how to fix this failure.

@vlazar What's the full error? And please send a diff or a PR, otherwise we can't know what to do to reach that point that you reached.

Oh, and the error is probably because if an Array is extended then that type changes everywhere in the compiler and compiler specs, and we have tons of bugs related to generics so that might be one such bug.

@asterite
$ git diff
diff --git a/spec/std/array_spec.cr b/spec/std/array_spec.cr
index 39a4d5cc6..ea1b2a32c 100644
--- a/spec/std/array_spec.cr
+++ b/spec/std/array_spec.cr
@@ -23,6 +23,9 @@ private class Spaceship
   end
 end

+private class ArraySubclass(T) < Array(T)
+end
+
 describe "Array" do
   describe "new" do
     it "creates with default value" do

FULL ERROR

$ bin/crystal spec --error-trace spec/std/array_spec.cr
Using compiled compiler at .build/crystal
error in line 1
Error: while requiring "./spec/std/array_spec.cr"
In spec/std/array_spec.cr:1821:45
1821 | typeof([[1.0], [1]].transpose).should eq(Array(Array(Int32 | Float64)))
^-
Error: instantiating 'eq(Array(Array(Float64 | Int32)).class)'
In src/spec/expectations.cr:293:30
293 | Spec::EqualExpectation.new value
^--
Error: instantiating 'Spec::EqualExpectation(T).class#new(Array(Array(Float64 | Int32)).class)'
In src/spec/expectations.cr:4:5
4 | def initialize(@expected_value : T)
^---------
Error: no overload matches 'Spec::EqualExpectation(Array(Array(Float64 | Int32)).class)#initialize' with type Array(Array(Float64 | Int32)).class
Overloads are:

Spec::EqualExpectation(T)#initialize(expected_value : T)

Closing per https://github.com/crystal-lang/crystal/issues/10328#issuecomment-769812463

Closing per https://github.com/crystal-lang/crystal/issues/10328#issuecomment-769812463


[Request] Pop out the VBM window

Not sure if possible, but an option to pop out the VBM window to place on my second monitor would be nice to clear up screen space.

Didn't actually realise Dalamud had built in multimonitor support! Fixed.


Add support for StructuredGrid (2D and 3D) in Downscale transform

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.16%. Comparing base (746c930) to head (7f54f75).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   94.91%   95.16%   +0.25%
==========================================
  Files          17       17
  Lines         806      848      +42
==========================================
+ Hits          765      807      +42
  Misses         41       41

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


FR: Put data.json[[navigationHistory]] in a separate config file

When placing the ExcaliBrain plugin configs under git version control, it is inconvenient that changes are staged in which only the navigationHistory key-value pair in data.json is changed.
Could we store such frequently changing values into a separate file we can .gitignore?
🙏 Appreciate the plugin, brings great new perspectives.

For now, (in 0.2.0) I stopped saving navigation history on each update, but will only save it each time the plugin offloads.
I will think about a better solution.


Release 1.0.0 beta2

Preparing a new release, with some patches:

https with .env
update carto-react reference
CHANGELOG

Closing in favour of https://github.com/CartoDB/carto-react-template/pull/126


COMP: Using SimpleITK from C++ need operators

Add documentation, instructions, and recommended
proceedures for adding math operators for simpleITK
so that C++ more closely mirrors python syntax
behaviors for math operations on images.

I pushed an updated patch to gerrit:
http://review.source.kitware.com/#/c/21452/

topic merged into next


Fix the SSH proxy hostname used in the localhost controller

Right now we are using the inventory_hostname, that may not be a valid hostname, that's why now we default to the ansible_host.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

/approve
/lgtm
good catch!

recheck


Add "dotenv" to use environment variables?

Right now we have a variety of methods for configuring the project: reading npm variables from package.json, certain settings for Gulp in its config/ directory, etc.
Should we consider adding Dotenv and moving these configurations into environment variables?

This is a worthwhile improvement IMHO. It kills me that pure JSON files have no option for comments. I've seen this pattern implemented in PHP too.

Agreed. I'll do a little more research into this and start a feature branch.

Closed by #44.


Add inspect command to display info of running application only

- What I did
Add an app inspect command to display info on running applications
- How I did it
Create a new command
Display information from Installation Claim for Installation, Application & Parameters section
Call the status CNAB action to display the list of running services
- How to verify it
TBD
- Description for the changelog
Add a new inspect command to display information on running applications
- A picture of a cute animal (not mandatory but encouraged)

Is the coverage completely wrong or does this PR really reduces the coverage?


Support --shapeInformation for .mlir input files

This patch is to make --shapeInformation work with .mlir input files. It was only working with .onnx input files.

@gongsu832 it looks like Jenkins AMD64 has some connection issue. Do you have any idea on what happened?

@jenkins-droid test this please

Jenkins Linux amd64 Build #12661 [push] Support --shapeInformati... started at 09:43

Jenkins Linux s390x Build #12681 [push] Support --shapeInformati... started at 10:43

@tungld works like a charm, thanks.

Jenkins Linux ppc64le Build #11674 [push] Support --shapeInformati... started at 10:52

Jenkins Linux amd64 Build #12661 [push] Support --shapeInformati... passed after 1 hr 27 min

Jenkins Linux ppc64le Build #11674 [push] Support --shapeInformati... passed after 3 hr 22 min

Jenkins Linux s390x Build #12681 [push] Support --shapeInformati... aborted after 3 hr 25 min


attribute-typo: Add more known attributes

https://github.com/jtojnar/nixpkgs-hammering/issues/33

Seems to fix the most common cases now.

Am I correct that these unused attributes end up as environment variables in the build, and if so, they might actually be used? Should we have a special way of treading all caps unknown attributes if so?
Lots of packages use rec attrsets, so these attributes are "used" elsewhere in the attrset passed to makeDerivation. Should the warning message recommend using a let binding or something?

Lots of packages use rec attrsets, so these attributes are "used" elsewhere in the attrset passed to makeDerivation. Should the warning message recommend using a let binding or something?

Wouldn't that trigger for all version's which are reused? Usually we do the opposite and move things from let in to rec because it is cleaner.

@SuperSandro2000: Yeah, totally fair. I'm just wondering if this attribute-typo check is going to be printing a lot of false positives.

Here's an example of what I mean -- the libPath attribute is flagged as a typo and I'm genuinely not sure if we want it to be: https://github.com/NixOS/nixpkgs/pull/112852#issuecomment-777948585

Am I correct that these unused attributes end up as environment variables in the build, and if so, they might actually be used? Should we have a special way of treading all caps unknown attributes if so?
Correct. Yeah, I thought about handling all caps differently and concluded that there probably will not be many similar attributes for the env vars (except the shortest ones but we handle those separately now). Eventually, I would want to move env vars into a separate attribute.

Lots of packages use rec attrsets, so these attributes are "used" elsewhere in the attrset passed to makeDerivation. Should the warning message recommend using a let binding or something?

Yeah, I think we should move stuff that does not concern stdenv or some setup hook to let to avoid contaminating the environment. Second use case are output attributes and those should go to passthru instead of being passed to stdenv directly.

Here's an example of what I mean -- the libPath attribute is flagged as a typo and I'm genuinely not sure if we want it to be: NixOS/nixpkgs#112852 (comment)

Yeah, that libPath is not used by stdenv so I would suggest moving it in let binding in postFixup or moving the libs to buildInputs and adding autoPatchElfHook. (Perhaps that can be a check.)

Maybe if the arguments passed to stdenv are a rec block and the "possible typo"-d attribute is used elsewhere within the rec block, we ought to be giving a different warning message or recommendation rather than calling it a typo?

Yeah, that is pretty reasonable. Unfortunately, it requires a static check so it cannot be done in overlay. (Thought maybe a Nix plug-in could do that.)
For now, maybe the bot could exclude this check? Maybe we could add maturity levels to checks.

Yeah -- this will be more work to implement and is totally independent of this PR, which I think is good to merge now.


init repo setup

Related Issue
resolves #4
Summary

CONTIBRUTING.md
LICENSE.md and updated package.json using MIT
CODE_OF_CONDUCT.md from Contributor Covenant
.editorconfig
Issue and PR templates
engines field in package.json, .nvmrc, and netlify.toml all set Node v16.14.0 LTS
Update README to recommend npm ci instead of npm install to avoid updating / committing package version changes
Removed <link> tag for CSS file not found in the repo (and unneeded .gitkeep file)

TODO / Feedback
I defer / delegate to the team on these:

[ ] Netlify hosting and Deploy Previews - I don't have permissions to set this up myself but this includes most of the things needed to apply for the Open Source Plan.  Last thing needed would a Netlify link / logo on the home page)
[ ] Branch protections and / or Codeowners - no permissions to set this myself
[ ] GitHub Actions - Probably not needed unless we want to add linting / testing to the project.  Just building in Netlify should be good for now, and we can include that status check as a requirement for merging PRs
[ ] As far as CI / CD, my vote is to deploy right from the main branch, but in the linked issue there was also discussion of a git flow like setup including  a staging branch.  Deploy previews should hopefully give us that staging workflow without the needed for a dedicated branch, IMO

Looks good to me. @mtom55 can you take a look at the Code of Conduct to make sure it aligns with your thoughts?
https://github.com/OpenWebAdvocacy/website/blob/6178bd6a4a3597f79520ebcf9848faf07651b28a/CODE_OF_CONDUCT.md
The Contributor Covenant is a good place for us to start and we can refine it with some of our own language further down the line if we choose to do so.
Pending approval of the Contributor Covenant as our initial code of conduct, I will merge this into main. Great job @thescientist13!

This looks great!

I have merged this branch into main. Thank you for your contribution @thescientist13!
Let's have a discussion about CI/CD in Discord. I'll cite this PR.


Emmet configuration is not multi-root fit

It looks like we are looking for emmet specific configuration files inside the workspace: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/emmet/electron-browser/emmetActions.ts#L289
This will not work anymore once we are in a multi root environment. I am not sure what the configuration is for but you probably need to read it per workspace root and then support it based on from which file the emmet action is executed.

We wouldnt need that once we move completely to new emmet which should be by 1.15
Do you still want to keep this issue to track it?

@ramya-rao-a that is awesome to hear, yeah l will rename the title then

Moving this to August.
Though we are turning the new emmet on for 1.5, we are retaining the option to use old emmet as there are few upstream issues still not fixed.

Though we are turning the new emmet on for 1.5, we are retaining the option to use old emmet as there are few upstream issues still not fixed.

With https://github.com/Microsoft/vscode/pull/31783, you force to use the new emmet, or where can I enable the old emmet? https://github.com/Microsoft/vscode/pull/31783/files#diff-9ee74d46e46b70e6a90f571978e9df07R258

Yes, the PR is was prep work for when we do decide to deprecate emmet.
Which I thought we had to move as there were a few other issues for which I needed upstream fixes.
See https://github.com/emmetio/abbreviation/pull/2 and https://github.com/emmetio/abbreviation/pull/3
But they got approved in the last hour :)
So I am planning to go ahead with this now.


nightly toolchain still required

As far as I'm aware, cargo-contract doesn't require the nightly toolchain anymore to be installed since v2 but instead the stable one. Though, contracts-node still requires it, which results in the need to install both toolchains when setting things up. Is this still really required or is this error only a leftover?

Substrate still requires nightly. It is the wasm-builder crate that enforces this rule.


update to rxjs 6 and angular 6

Hi,
Rx changed their import statements. Looks like these changes should be enough to make module compatible with Angular 6 and RxJs 6. Some versioning changes of this package should be also made

Hi,
Thank you for your contribution! I'll take a look on your PR this weekend. I have also to add some notes to README mentioning starting new version at least rxjs 5.6.0-forward-compat.4 will be required

@vitaliy-patsay I'm not able to push to your fork branch. I have a small fix in peer dependencies and update of README file. Please see attached screenshot to see how allow me to push to your fork branch:

Hi Szymon,
It's checked. So you should be able to make edits if I understand this flag correct.

Ok... now i see it. Your forked not directly from kneefer/ngx-translate-resx-http-loader but from KwintenP/ngx-translate-resx-http-loader... So only KwintenP is able to push changes to your fork. Now we have 3 options:

Create new, direct fork from my repo and I will be able to push to your fork this way
Add me as a collaborator to your existing fork temporarily
I can create new branch on my repo and merge your changes and apply mine and recreate PR (but I don't like it since it is more transparent in history when it's visible that PR was initiated by you)

Done, I've added you as collaborator.


Particles diameter fix

Hello. In your code diameter changing was realized like subtracting slider value from initial particles radius:

It may lead to negative particle radius and cause errors, so you used absolute value. Of course, it's bad hack, so your particles diameter changes looked pretty strange (some of them didn't increease when moving diameter slider to the right, but decreased when moving slider to the left, so if we move slider left and then right some of particles get zero radius value and never increase, you can check it out by youself)
To fix this trouble i realized radius changing not by increasing or decreasing radius value, but by multiplying initial radius by slider value. So, at first, in particle constructor u need to save initial radius:

Then i have fixed your random function:

We don't need to floor values here, because we want to get value with floating point
And here is a fix of your bug:

Now we to calc particle radius take initial radius, multiply it by slider value
And the last change i have made is changing initial radius range, because particles were too big before:

Actually for me it's also the first time when i fix someone's bug on github
I don't know English at a good level, so somewhere i could have mistranslated

Excellent @Vishota , that is a very clear and comprehensive explanation. The initial solution was certainly a (functioning) hack that was a placeholder until I found the time to revisit it.
Now, let me see if I can merge this Pull Request and close the issue without messing up :laughing: .
Thanks again for your contribution.


Scenario name set as default in molecule.yml, when init a new one

Issue Type

Bug report

Molecule and Ansible details
ansible 2.6.1

molecule, version 2.19.0

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Desired Behavior
Using the following command to add a new scenario in an existing role (molecule init scenario --role-name myrolename --scenario-name myscenarioname --driver-name vagrant), the scenario name in the generated molecule.yml file should be the same provided through the --scenario-name option.
Actual Behaviour (Bug report only)
It's currently set as default:
scenario:
  name: default

And when I launch a simple molecule converge, I have this error:
ERROR: Duplicate scenario name 'default' found.  Exiting.

Because I already have a default scenario present in the folder. So I need to change manually default to the actual scenario name, and everything works fine again.

I can not reproduce.
[jodewey:~/git/molecule_2]   : master+ ± cd myrolename
[jodewey:~/git/molecule_2/myrolename]   : master+ ± molecule init scenario --role-name myrolename --scenario-name default --driver-name vagrant
--> Initializing new scenario default...
Initialized scenario in /Users/jodewey/git/molecule_2/myrolename/molecule/default successfully.
[jodewey:~/git/molecule_2/myrolename]   : master+* ± molecule init scenario --role-name myrolename --scenario-name myscenarioname --driver-name vagrant
--> Initializing new scenario myscenarioname...
Initialized scenario in /Users/jodewey/git/molecule_2/myrolename/molecule/myscenarioname successfully.
[jodewey:~/git/molecule_2/myrolename]   : master+* 2 ± molecule list
--> Validating schema /Users/jodewey/git/molecule_2/myrolename/molecule/default/molecule.yml.
Validation completed successfully.
--> Validating schema /Users/jodewey/git/molecule_2/myrolename/molecule/myscenarioname/molecule.yml.
Validation completed successfully.
Instance Name    Driver Name    Provisioner Name    Scenario Name    Created    Converged
---------------  -------------  ------------------  ---------------  ---------  -----------
instance         vagrant        ansible             default          false      false
instance         vagrant        ansible             myscenarioname   false      false

As I though, it was a weird behaviour on my side, following the creation of a scenario. It works now as expected, sorry for the unnecessary noise...

@blackillzone no problem thx for the report!


Uncaught Error: Cannot call function 'getPosition' on missing remote object 23Error: Cannot call...

[Enter steps to reproduce:]
Sorry, but no idea about what happened.
Atom: 1.26.1 x64
Electron: 1.7.11
OS: Mac OS X 10.13.4
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot call function 'getPosition' on missing remote object 23
Error: Cannot call function 'getPosition' on missing remote object 23
at throwRPCError (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:143:17)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:354:7)
at emitMany (events.js:127:13)
at EventEmitter.emit (events.js:204:7)
at WebContents. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:256:13)
at emitTwo (events.js:106:13)
at WebContents.emit (events.js:194:7)
At /Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:234

Error: Cannot call function 'getPosition' on missing remote object 23
Error: Cannot call function 'getPosition' on missing remote object 23
    at throwRPCError (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:143:17)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:354:7)
    at emitMany (events.js:127:13)
    at EventEmitter.emit (events.js:204:7)
    at WebContents.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:256:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:194:7)
    at metaToValue (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:234:13)
    at Object.remoteMemberFunction (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:118:18)
    at AtomEnvironment.getWindowDimensions (/Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:694:40)
    at AtomEnvironment.storeWindowDimensions (/Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:731:40)
    at WindowEventHandler.handleWindowBlur (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:191:32)

Commands
  5x -3:13 editor:move-to-beginning-of-word (input.hidden-input)
     -3:08.9.0 core:save (input.hidden-input)
     -2:16.5.0 pane:show-next-recently-used-item (input.hidden-input)
     -2:15.9.0 pane:move-active-item-to-top-of-stack (input.hidden-input)
     -2:14.8.0 pane:show-previous-recently-used-item (input.hidden-input)
     -2:14 pane:move-active-item-to-top-of-stack (input.hidden-input)

Non-Core Packages
git-plus 7.10.2
git-status 0.3.4
minimap 4.29.8

Thanks for the report!

Sorry, but no idea about what happened.

No problem, this looks like a duplicate of #16630 so you can subscribe there if you'd like.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Cov fixes

fix some dead code warnings (one actually being a bug)
replace (type)Stream_Buffer(s) with Stream_BufferAs(s, type)

minor changes + renaming, merging as is.


Open folder on <enter>

Currently, I'm looking for a replacement for the "simple file dialog" in VSCode since by default TAB does not autocomplete but instead switches focus between UI elements unlike your extension which autocompletes the path.
Currently, I'm struggling to get the keybindings to work to get the following behavior:

On ctrl+p, open the "Quick Opener" view (works)
When on "Quick Opener" and the current item is a File, open it in the current editor area on enter (works)
When on "Quick Opener" and the current item is a Directory, open the folder in the current workspace on enter (does not work)

In the last case, when I press enter nothing happens until I change the focused item (down-arrow, up-arrow) to a File inside the Directory. After changing the focus, pressing enter refreshes the "Quick Opener" view and uses the Directory as a "root" path to search again for a file to open.
What I would like to do is that on the first enter, if a File is selected then it should be opened in the current editor area, if a Directory is selected then it should open the folder in the current window (like the F1 > File: Open Folder... command), and if I write a path that it does not exist then it should create it.

Would you want enter on a directory to always trigger the "Open folder" action, even when the current vscode window already has a workspace (folder) opened? That is, should it open another window? I think it might be preferable for it to act like ctrl+o in the current QuickOpener version, eg. open folder if none has been opened, or add folder to workspace if a folder has already been opened.

I think it might be preferable for it to act like ctrl+o in the current QuickOpener version, eg. open folder if none has been opened, or add folder to workspace if a folder has already been opened.

As a starting point would like to somehow remap Ctrl+o to <enter> to open a folder when the current window has no workspace or add it to the workspace when one is already present.
Personally, my use case is as follows:

If there is no folder open in the current workspace, <enter> should open the folder in a new workspace in the current window (current behavior of Ctrl+o)
If there is a folder open in the current workspace, <enter> should replace the currently open folder in the current window (unlike Ctrl+o that opens a new window)

Got it!

If there is a folder open in the current workspace, <enter> should replace the currently open folder in the current window (unlike Ctrl+o that opens a new window)

I'm not sure if this is possible, but will look into it when time allows.
Note to self: These may be usable
https://github.com/microsoft/vscode/blob/c67ccc70ece5f472ec25464d3eeb874cfccee9f1/src/vs/platform/windows/electron-main/windowsMainService.ts#L274
https://github.com/microsoft/vscode/blob/c67ccc70ece5f472ec25464d3eeb874cfccee9f1/src/vs/platform/windows/electron-main/windows.ts#L98


Windows Storage Spaces not hidden [treated as if removable]

Etcher version: v1.3.1 (and lower versions as well)
Operating system and architecture: Windows 10 64bit LTSB, Win 10 64bit latest CB [Fall Creator], and Win 8.1 64bit
Image flashed: None [issue is pre-flash with destination selection]
Do you see any meaningful error information in the DevTools?:  I do not.  However, I believe this is an edge-case that's just not tested for.  (as Storage Spaces use is uncommon)

Bug Description:  Etcher treats Microsoft "Storage Spaces" volumes as removable devices.
https://i.imgur.com/4XEIsEJ.png
Per the screenshot above:
-"Unsafe Mode" is unchecked / disabled. (no changes from default settings)
-"Dynamic Disk" array (boot volume) is correctly hidden from selection.
-"Storage Spaces" array (storage volume) is not hidden from selection.
Image:
Tested a disk-span, 3-way mirror, and single-disk volume with similar results.  Win 8.1 and 10 behavior are identical.
eg, it seems all that needs to be done to reproduce this is to create and mount anything with Storage Spaces.

Oh yikes; that's a bug in drivelist then – but we are already ignoring the Storage Spaces driver enumerators there... curious. Will have set that up & try to reproduce.
Thanks for the detailed report!


Test application migration from Diego to DEA

Closed since we're not offering DEA side-by-side with Diego on govcloud. :us: :cloud:


Muter should run without configuration file in a vanilla swift package

This might be too opinionated. But projects conforming to the Swift Package Manager have a very predictable structure and could easily be mutation-tested without any configuration.

Tests can be run with swift test
Package.swift should be ignores (you're already doing this)

And so, a default configuration can be used (admitting that the location of swift may be different, but I think muter could attempt to resolve that as well).
{
    "executable": "/usr/bin/swift",
    "arguments": [
        "test"
    ],
}

I love the suggestion @fcanas as it definitely makes Muter much easier to use with projects that use the swift package manager.
That said, there is a whole lot of other work that is more priority right now, so i'm marking this as de-prioritized - we may come back to this in the future. Part of what informs this decision is a lack of understanding around how many of our users are using swift package manager vs. carthage or cocoapods, and whether or not the config file is painful for users.

Closed as part of some backlog grooming. If this becomes important again in the future, this issue will be reopened.


vm: fix live test failures on using custom images

This will fix vm related failures mentioned in #5740 by capturing vm images on the fly. To absorb extra test executing time, I combined 2 related tests into one.
@troydai, this should address the last set of live test failures in vm/vmss area
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

Codecov Report

Merging #6693 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           dev   #6693   +/-   ##
===================================
  Coverage    0%      0%
===================================
  Files       11      11
  Lines      145     145
  Branches    11      11
===================================
  Misses     145     145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d409c0e...147f3a2. Read the comment docs.


UnicodeEncodeError: 'ascii' codec can't encode characters in position 31-35: ordinal not in range(128)

Prerequisites

[X] Did you read FAQ section?
[X] Did you test with the latest releases or commit ?

Description
while downloading my bookmarked images at some point on a random image it stops with an error about encoding, i believe this is due to the username of the account that uploaded the image since i can't download anything from them
Terminal output (i have replaced some details with <...>) : https://pastebin.com/FSPen0uu
Steps to Reproduce
it happens randomly but on the same image every thime, for exampe in image_id=50549969
Versions
PixivDownloader2 version 20191118

latest version require python 3.


Basic SIER codec implementation

Beginning implementation laying out the general structures we'll use for the future.

There's no possibility of it actually panicing. The method will always return Some(...).


[Docs] how to visualize the instance seg result

Branch
master branch  https://mmdetection.readthedocs.io/en/latest/
📚 The doc issue
After I trained the maskrcnn model, when I visualize the demo image, I got the same color of one class,how can I got the instance seg result, the instance of same classes have different color? thanks
Suggest a potential alternative/fix
No response

The current design is really not considered and we will consider improving it.


Repo name

rename the repo's name to GTAVRemoteVehicleControl to avoid possible confusion with Toxic Scams' Vehicle Control and better describe its function

This repository was created in April 2018, predating that mod. Not going to consider the idea.

copy that 👍


Feature Request: Respect --quiet/-q cli flag

Problem
Homebrew bundle has quite verbose output at times, such as the Using package_x output (source) when running brew bundle install.
brew bundle --help lists the standard homebrew --quiet/-q flag in its output, which is intended for use cases where the user wishes to suppress extraneous output. Currently homebrew bundle does not appear to respect this flag.
My Usecase
I use homebrew bundle as part as my standard dotfiles setup to maintain a consistent development setup across multiple macos devices and to minimise disaster recovery time.
As part of this, I run brew install --global --quiet --cleanup on every call to brew which would potentially change the state of my brewfile.
I'd like the --quiet flag to reduce the output from this command, so that it only tells me if it is installing/uninstalling packages/casks from my system.
Solution
Update homebrew bundle to respect the --quiet/-q flag by replacing relevant direct calls to puts with a custom log function which acts as a noop if the flag is active.

Thanks for the good write-up. What would you expect the output to be with --quiet? Nothing unless there are errors?

I think it is best to mirror the behaviour of the brew command, which I think would mean "Nothing unless there are errors" as you say.
Though, that aside, just as a cli user I'd expect:

quiet: log errors or prompts for input only (i.e. if something goes wrong or the user needs to elevate to sudo etc)
default: same as quiet, plus logging changes to the system (i.e. things being installed or removed).
verbose: same as default, plus logging where changes to the system aren't required (i.e. where something is already installed, etc).

quiet: log errors or prompts for input only (i.e. if something goes wrong or the user needs to elevate to sudo etc)

Agreed. I think the default and verbose already behaves as described so I think that'd be good scope for this issue.
@maxcbc Do you want to give this a go implementing it yourself? Happy to provide review and help on a partially working/CI failing draft PR?

@MikeMcQuaid Sure. It'll probably be a few weeks before I can get to it, but a good opportunity to refresh my ruby skills.
Watch this space 🙂

I'd like this as well.

Let us know if you made some progress and stuck on something!

Taking a look at this, there are 61 places we're using puts instead of calling a logging function.
@MikeMcQuaid Is there a reason not to use ohai for the majority of these? I see that at least cmd/bundle.rb uses onoe in a few places, implying that ohai is available.

Taking a look at this, there are 61 places we're using puts instead of calling a logging function.
@MikeMcQuaid Is there a reason not to use ohai for the majority of these? I see that at least cmd/bundle.rb uses onoe in a few places, implying that ohai is available.

@colindean Yes. We should be using puts instead. This is what Homebrew/brew does. ohai is not any more of a logging function: it's just a puts with a prefix. Homebrew/brew also uses puts all over the place, intentionally.


Allow imports from inside a module without specifying the module name.

Is your feature request related to a problem? Please describe.
Taking the leap from 'hey this is nice' to scaling to a medium size problem is very unintuitive when it comes to package management. I have provided feedback in other threads, but a particular bug bear is that you need to 'domain' name your module, to cross import packages inside the same module.
Eg.
cue.mod
module: "cue.localhost" // better default than example.com, seperate issues

component.mod
import "cue.localhost:somepackage"
import "cue.localhost.someotherpackage"

While this does work, imagine the work now if I decided to brand and publish my module, so I get a namespace going. Now I have to update every cue file. It also makes the encapsulation a bit weird, 'internal' packages need to now the module name.
I have seen some other discussions about relative paths, and I think this is solvable without that, mainly as a 'special' case to the package manager.
Describe the solution you'd like
We already have
import strings -> builtin type
import dns.com/path:package -> reference modules and packages

What I would like
import /:package -> reference packages inside this module, starting from the 'root' of the module.
import /path/to/x:package -> if its in folders in the 'current' module

Which at the moment gives
cue.localhost@v0: import failed: no location found for package "/":

or something along the lines of, but this might be ambiguous for built ins.
import :otherpackage
import path/to/x:otherpackage

Describe alternatives you've considered
At the moment sprinkling a fake dns name works, and is useable, but it's also adds to the 'mental stack', why do we need a label to refer to our selves, we have the 'information' for a self, so it would be nice to infer it. The more items you need to keep track of, the more chances for mistakes
There's also a possibility of having a special name 'localhost', in the imports. Which could mean 'this package', and it's guaranteed to not have someone squatting it, but is that 'very weird' from a usability perspective.
Additional context
As far as I can tell, using a '/' isn't a case currently 'taken' by the import logic, there's built-ins, which are just paths, and dns, which is other cue code.  So it wouldn't cause conflicts, I think.
This would also allow people to have empty module names, if it's not intended to be shared anyway. Which makes sense, and they can change a module name later without much work.
I believe this could be described as the 'root' of the module, for any paths and documentation, so that it does help put people on the 'entrypoint' of a 'project'/module being wherever cue.mod is located.
I couldn't find a simple overview of imports though (eg different use-cases) so I may have missed something in the documentation, so this may not be possible.
This shouldn't be against the disallowing of the relative imports (it's more absolute imports), but would possibly provide an alternative for people seeking it, and I think the logic of resolving a cue module would be relatively hermetic.
Implementation wise, it would be detecting a special case '/' and adding in the 'module name' implicitly for the user. Built-ins won't start with /, and neither would a proper module name.

Thanks for raising @btrepp. We've previously had discussions in this space. I'll leave @rogpeppe to reply here.

@btrepp  Thanks for the report!

a particular bug bear is that you need to 'domain' name your module, to cross import packages inside the same module.

It's interesting you mention this, because there I've had some private discussions about the fact that the default module name cue.example is very arbitrary and rather unintuitive.

What I would like
import /:package -> reference packages inside this module, starting from the 'root' of the module.
import /path/to/x:package -> if its in folders in the 'current' module

Unfortunately from my p.o.v. this isn't a great solution:

currently any import path found in a CUE file can be provided on the command line, but the command line also needs to distinguish filesystem paths from import paths, and rooted paths (starting with /) are always treated as filesystem paths; this would break that usage
in general, it's a nice property that import paths are absolute, even if we're not... absolute about that requirement (e.g. we allow an implied major version)

There's also a possibility of having a special name 'localhost', in the imports. Which could mean 'this package', and it's guaranteed to not have someone squatting it, but is that 'very weird' from a usability perspective.

This suggestion aligns more closely with the solution we were thinking of.
Specifically, this is what we came up with:

cue mod init with no arguments will use .local as the default module path
update the module code to allow this otherwise invalid module path in import statements
add a cue mod rename cue.com/foo/bar command (or whatever) something unambiguous to find imports of the local module inside import statements and in CUE code, so that it's easy to move away from .local when the time comes to publish a module.

So, to provide a full example, in txtar format:
-- cue.mod/module.cue --
module: ".local"
-- foo.cue --
package foo
x: 1
-- bar/bar.cue --
package bar
import ".local:foo"
y: foo.x
-- baz/baz.cue --
package baz
import ".local/bar"
z: bar.y

WDYT?

@btrepp  I think there is already an issue (#403) that is directly related to relative import paths (including module-root-relative import paths), so I'm going to retitle this issue to be about the specific pain points that you've mentioned, and create a couple of other issues to track some specific proposals designed to address those pain points.

add a cue mod rename cue.com/foo/bar command (or whatever) something unambiguous to find imports of the local module inside import statements and in CUE code, so that it's easy to move away from .local when the time comes to publish a module.

This actually might be the powerhouse idea here, if the name is trivially changeable you don't hit the naming things problem. It's a tricky barrier to go 'I need to pick a name, but I am not sure of the impacts'. However hey it's easy to rename later eliminates that.

I think there is already an issue (https://github.com/cue-lang/cue/issues/403) that is directly related to relative import paths (including module-root-relative import paths), so I'm going to retitle this issue to be about the specific pain points that you've mentioned, and create a couple of other issues to track some specific proposals designed to address those pain points.

I think I had read that, but I wasn't asking for relative paths, so it was a slightly different discussion, but agree with the renaming and splitting.


[cherry-pick] [BugFix] Add defensive code to prevent the corresponding column from not being found in the TabletSchema

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

starrocks_be_unittest succeeded.


Adds pangram exercise

Hi, this PR is to add a new exercise for pangram, here is a link to the problem-specifications
This is one of the exercises on the list in issue #149
I'm still learning Dart, so feel free to point out anything that needs to be change or improved.
One note, this may need to be rebased if #172 is merged due to conflicts in the config.json file.
Thanks! :)

Ah, looks like there is an issue with this code for Dart 1.24.3. I'll look at updating this for it works for both Dart 2 and 1.

Updated the code, and all test pass for both Dart 1 and 2.

@amscotti thanks for submitting your first PR!! @Stargator is the owner of the repository, and he will provide guidance for the config.json. He, along with myself and @devkabiir work on many of the exercises here, and we typically all review each others submissions before merging.
We'll get it reviewed and provide feedback :) thanks for your contributions!

Just looked at our open PRs and realized this isn't your first PR :) still, thanks for contributing!


Deploying with the RAC Storage Container: failed to start containers: racnode1

Failed to start racnode1 with below error.
[root@ip-xxx-xxx-xxx-xxx ~]# docker start racnode1
Error response from daemon: error while mounting volume '/var/lib/docker/volumes/racstorage/_data': error while mounting volume with options: type='nfs' device=':/oradata' o='addr=<IP_ADDRESS>,rw,bg,hard,tcp,vers=3,timeo=600,rsize=32768,wsize=32768,actimeo=0': connection refused
Error: failed to start containers: racnode1
Thanks in adv.

Did you create RAC-Storage container? Please share following:
docker ps -a
docker volume ls
docker logs -f racnode-storage
docker network ls

I have created RAC Storage container. As you can see below

docker logs -f racnode-storage
ASM_STORAGE_SIZE env variable is not defined! Assining 25GB instead of 50GB default
Oracle user will be the owner for /oradata
Checking Space
Space check passed : /oradata has avilable space 44 and ASM storage set to 25
Creating ASM Disks /oradata/asm_disk01.img of size 5
/oradata/asm_disk01.img file already exist! Skipping file creation
Creating ASM Disks /oradata/asm_disk02.img of size 5
/oradata/asm_disk02.img file already exist! Skipping file creation
Creating ASM Disks /oradata/asm_disk03.img of size 5
/oradata/asm_disk03.img file already exist! Skipping file creation
Creating ASM Disks /oradata/asm_disk04.img of size 5
/oradata/asm_disk04.img file already exist! Skipping file creation
Creating ASM Disks /oradata/asm_disk05.img of size 5
/oradata/asm_disk05.img file already exist! Skipping file creation
#################################################
Starting NFS Server Setup
#################################################
Setting up /etc/exports
/oradata *(rw,sync,no_wdelay,no_root_squash)
Starting RPC Bind
Exporting File System
Starting RPC NFSD
Starting RPC Mountd
Checking NFS server
####################################################
NFS Server is up and running
Create NFS volume for /oradata/
####################################################
0

docker ps -a
CONTAINER ID        IMAGE                                       COMMAND                  CREATED             STATUS                      PORTS               NAMES
3c775b01ba84        oracle/database-rac:<IP_ADDRESS>                "/usr/sbin/oracleinit"   7 minutes ago       Created                                         racnode1
47f2ea2124ea        oracle/rac-storage-server:<IP_ADDRESS>          "/bin/sh -c 'exec ..."   19 minutes ago      Up 19 minutes                                   racnode-storage
0fa6bb1b9355        store/oracle/database-enterprise:<IP_ADDRESS>   "/bin/sh -c '/bin/..."   2 days ago          Exited (137) 41 hours ago                       catcdb
bc6a3587e503        store/oracle/database-enterprise:<IP_ADDRESS>   "/bin/sh -c '/bin/..."   2 days ago          Exited (137) 41 hours ago                       mxpdb

docker volume ls
DRIVER              VOLUME NAME
local               04cdc8b6424b293b404dc8835c24eb20ec5ec387852071210dbeedf5f1e4a34b
local               0c6cd1bbdd263303a78db4dc3f20985170ac413c9c9ba024ccd52353d54d7134
local               1e0dc3827019b455e4709f48424a815e561461a5106d96452ee739ef9ab9643b
local               228e37af4c31af2481c91eb521094937c550f6fb2443f2531b46e6386cf5b73d
local               472520202fd81906e9851cd27249df1976c756dceeb8d6612464281edf25ba21
local               4ef7d45140e4ae04b27697651c0f35250cbd75155c5592441fc5f36d72646826
local               6dc993c7612bf16c23bbce9fbcc6fc4de34c51c6ae301621d652ce4ea3e72c11
local               721c75927058c747465be1dccd6bd7437b397f7ace5d255df946792ddfb4c442
local               7b1dbbcd19092145069d06d86c380231bbfe9e75597deb048e2f337325a03951
local               b8f57998aaf80b1775473b7f02395119fdb4c6c958434f53a66dcde462aa926d
local               c4adcbceeab80a52724ab78a958338346437df5777d16d3378f400a0597f2521
local               d43e465f94026d5e0e524036dea2e27d62367ccb30fbe85c68f09c305131d803
local               racstorage

docker network ls
NETWORK ID          NAME                DRIVER              SCOPE
47daa93faab0        bridge              bridge              local
7f11e556dc51        host                host                local
2a70667460e9        none                null                local
b3d495bff13b        rac_priv1_nw        bridge              local
5f6e430f9fc0        rac_pub1_nw         bridge              local

On docker start racnode1
Got Error response from daemon: error while mounting volume '/var/lib/docker/volumes/racstorage/_data': error while mounting volume with options: type='nfs' device=':/oradata' o='addr=<IP_ADDRESS>,rw,bg,hard,tcp,vers=3,timeo=600,rsize=32768,wsize=32768,actimeo=0': connection refused
Error: failed to start containers: racnode1
FYI:
[root@ip-1xx-xx-xx-xxx asm_vol]# ls -l /docker_volumes/asm_vol
total 26214400
-rw-r--r--. 1 54321 54321<PHONE_NUMBER> Aug  2 10:37 asm_disk01.img
-rw-r--r--. 1 54321 54321<PHONE_NUMBER> Aug  2 10:38 asm_disk02.img
-rw-r--r--. 1 54321 54321<PHONE_NUMBER> Aug  2 10:38 asm_disk03.img
-rw-r--r--. 1 54321 54321<PHONE_NUMBER> Aug  2 10:39 asm_disk04.img
-rw-r--r--. 1 54321 54321<PHONE_NUMBER> Aug  2 10:40 asm_disk05.img

Though setup looks correct, I have a question why ASM disks are 25GB total? I think they should be by default 50GB. Did you change the size? if yes, please create ASM disks of size 50G.
Also, can you paste outpu of following from Docker host:
showmount -e <rac_storage_server_container_ip>
Execute following on docker host:
rpm -qa | grep nfs-utils
Did you install nfs server packages on docker host?
rpm -qa

I allowed custom allocation of 25GB instead default 50 GB. I think it should be fine for my requirement. Evidently we do not see any error due to ASM disk allocation. As you mentioned nfs-utils was missing, so I installed the rpm and tried restarting racnode1 , this time it passed the earlier error , now it is different error -
$ docker start racnode1
Error response from daemon: oci runtime error: container_linux.go:247: starting container process caused "process_linux.go:258: applying cgroup configuration for process caused "failed to write 95000 to cpu.rt_runtime_us: write /sys/fs/cgroup/cpu,cpuacct/docker/f5b353f1026e525258705d503b16e413889a70aa5113f55a8038c9602566896d/cpu.rt_runtime_us: invalid argument""
Error: failed to start containers: racnode1
my env: AMI ID
RHEL-7.5_HVM_GA-20180322-x86_64-1-Hourly2-GP2 (ami-6871a115)

Hi,
I would request you to look into following threads:
https://github.com/oracle/docker-images/issues/837
https://github.com/oracle/docker-images/issues/838
I also request you to check following thread if you are using overlay FS.
https://github.com/oracle/docker-images/issues/839
Param

Keep me posted if you see any issue.

Thread #838 helped. I can connect to racnode1 container
docker logs -f racnode1
Failures were encountered during execution of CVU verification request "stage -pre crsinst".
Welcome to Oracle Linux Server 7.5!
Set hostname to .
Failed to parse kernel command line, ignoring: No such file or directory
Failed to parse kernel command line, ignoring: No such file or directory
Failed to parse kernel command line, ignoring: No such file or directory
/usr/lib/systemd/system-generators/systemd-fstab-generator failed with error code 1.
Cannot add dependency job for unit display-manager.service, ignoring: Unit not found.
Couldn't determine result for ConditionKernelCommandLine=|rd.modules-load for systemd-modules-load.service, assuming failed: No such file or directory
Couldn't determine result for ConditionKernelCommandLine=|modules-load for systemd-modules-load.service, assuming failed: No such file or directory
Verifying OS Kernel Parameter: semopm ...FAILED
racnode1: PRVG-1205 : OS kernel parameter "semopm" does not have expected
current value on node "racnode1" [Expected = "100" ; Current = "32";
Configured = "100"].
Verifying OS Kernel Parameter: rmem_default ...FAILED
racnode1: PRVG-2044 : Command "/sbin/sysctl -a | grep
rmem_default[[:space:]]*=" failed on node "racnode1" and produced no
output.
racnode1: PRVF-7544 : Check cannot be performed for kernel parameter
"rmem_default" on node "racnode1"
racnode1: PRVG-1205 : OS kernel parameter "rmem_default" does not have expected
current value on node "racnode1" [Expected = "262144" ; Current =
"unknown"; Configured = "262144"].
Verifying OS Kernel Parameter: rmem_max ...FAILED
racnode1: PRVG-2044 : Command "/sbin/sysctl -a | grep rmem_max[[:space:]]*="
failed on node "racnode1" and produced no output.
racnode1: PRVF-7544 : Check cannot be performed for kernel parameter "rmem_max"
on node "racnode1"
racnode1: PRVG-1205 : OS kernel parameter "rmem_max" does not have expected
current value on node "racnode1" [Expected = "4194304" ; Current =
"unknown"; Configured = "4194304"].
Verifying OS Kernel Parameter: wmem_default ...FAILED
racnode1: PRVG-2044 : Command "/sbin/sysctl -a | grep
wmem_default[[:space:]]*=" failed on node "racnode1" and produced no
output.
racnode1: PRVF-7544 : Check cannot be performed for kernel parameter
"wmem_default" on node "racnode1"
racnode1: PRVG-1205 : OS kernel parameter "wmem_default" does not have expected
current value on node "racnode1" [Expected = "262144" ; Current =
"unknown"; Configured = "262144"].
Verifying OS Kernel Parameter: wmem_max ...FAILED
racnode1: PRVG-2044 : Command "/sbin/sysctl -a | grep wmem_max[[:space:]]*="
failed on node "racnode1" and produced no output.
racnode1: PRVF-7544 : Check cannot be performed for kernel parameter "wmem_max"
on node "racnode1"
racnode1: PRVG-1205 : OS kernel parameter "wmem_max" does not have expected
current value on node "racnode1" [Expected = "1048576" ; Current =
"unknown"; Configured = "1048576"].
Verifying OS Kernel Parameter: aio-max-nr ...FAILED
racnode1: PRVG-1205 : OS kernel parameter "aio-max-nr" does not have expected
current value on node "racnode1" [Expected = "1048576" ; Current =
"65536"; Configured = "1048576"].
racnode1: PRVG-10048 : Name "racnode1" was not resolved to an address of the
specified type by name servers o"<IP_ADDRESS>".
racnode1: PRVG-10048 : Name "racnode1" was not resolved to an address of the
specified type by name servers o"<IP_ADDRESS>".
PRVG-1101 : SCAN name "racnode-scan" failed to resolve
cluvfy.tar.gz

OK.  It seems some kernel parameters are not set in you env. Did you make sure as per the README.MD, you set the following at Docker Host level:
Please setup some kernel parameters at host level

OK. It seems some kernel parameters are not set in you env. Did you make sure as per the README.MD, you set the following at Docker Host level:
fs.file-max = 6815744
net.core.rmem_max = 4194304
net.core.rmem_default = 262144
net.core.wmem_max = 1048576
net.core.wmem_default = 262144
net.core.rmem_default = 262144
sysctl -a
sysctl -p
However, I am wondering you are kernel.sem cvu messages as well. If you still see issue, please setup following at host level:
oracle-database-server-12cR2-preinstall setting for fs.file-max is 6815744
fs.file-max = 6815744
oracle-database-server-12cR2-preinstall setting for kernel.sem is '250 32000 100 128'
kernel.sem = 250 32000 100 128
oracle-database-server-12cR2-preinstall setting for kernel.shmmni is 4096
kernel.shmmni = 4096
oracle-database-server-12cR2-preinstall setting for kernel.shmall is<PHONE_NUMBER> on x86_64
kernel.shmall =<PHONE_NUMBER>
oracle-database-server-12cR2-preinstall setting for kernel.shmmax is<PHONE_NUMBER>104 on x86_64
kernel.shmmax =<PHONE_NUMBER>104
oracle-database-server-12cR2-preinstall setting for kernel.panic_on_oops is 1 per Orabug 19212317
kernel.panic_on_oops = 1
oracle-database-server-12cR2-preinstall setting for net.core.rmem_default is 262144
net.core.rmem_default = 262144
oracle-database-server-12cR2-preinstall setting for net.core.rmem_max is 4194304
net.core.rmem_max = 4194304
oracle-database-server-12cR2-preinstall setting for net.core.wmem_default is 262144
net.core.wmem_default = 262144
oracle-database-server-12cR2-preinstall setting for net.core.wmem_max is 1048576
net.core.wmem_max = 1048576
oracle-database-server-12cR2-preinstall setting for net.ipv4.conf.all.rp_filter is 2
net.ipv4.conf.all.rp_filter = 2
oracle-database-server-12cR2-preinstall setting for net.ipv4.conf.default.rp_filter is 2
net.ipv4.conf.default.rp_filter = 2
oracle-database-server-12cR2-preinstall setting for fs.aio-max-nr is 1048576
fs.aio-max-nr = 1048576
oracle-database-server-12cR2-preinstall setting for net.ipv4.ip_local_port_range is 9000 65500
net.ipv4.ip_local_port_range = 9000 65500
sysctl -a
sysctl -p
This is strange that you are getting kernel parameters as we have modified some kernel parameters at container level. I will look into it.

double checked for kernel parameters at host,  all seems to be set properly.
Failures were encountered during execution of CVU verification request "stage -pre crsinst".
Verifying OS Kernel Parameter: semopm ...FAILED
racnode1: PRVG-1205 : OS kernel parameter "semopm" does not have expected
current value on node "racnode1" [Expected = "100" ; Current = "32";
Configured = "100"].
Verifying OS Kernel Parameter: rmem_default ...FAILED
racnode1: PRVG-2044 : Command "/sbin/sysctl -a | grep
rmem_default[[:space:]]*=" failed on node "racnode1" and produced no
output.
racnode1: PRVF-7544 : Check cannot be performed for kernel parameter
"rmem_default" on node "racnode1"
racnode1: PRVG-1205 : OS kernel parameter "rmem_default" does not have expected
current value on node "racnode1" [Expected = "262144" ; Current =
"unknown"; Configured = "262144"].
Verifying OS Kernel Parameter: rmem_max ...FAILED
racnode1: PRVG-2044 : Command "/sbin/sysctl -a | grep rmem_max[[:space:]]*="
failed on node "racnode1" and produced no output.
racnode1: PRVF-7544 : Check cannot be performed for kernel parameter "rmem_max"
on node "racnode1"
racnode1: PRVG-1205 : OS kernel parameter "rmem_max" does not have expected
current value on node "racnode1" [Expected = "4194304" ; Current =
"unknown"; Configured = "4194304"].
Verifying OS Kernel Parameter: wmem_default ...FAILED
racnode1: PRVG-2044 : Command "/sbin/sysctl -a | grep
wmem_default[[:space:]]*=" failed on node "racnode1" and produced no
output.
racnode1: PRVF-7544 : Check cannot be performed for kernel parameter
"wmem_default" on node "racnode1"
racnode1: PRVG-1205 : OS kernel parameter "wmem_default" does not have expected
current value on node "racnode1" [Expected = "262144" ; Current =
"unknown"; Configured = "262144"].
Verifying OS Kernel Parameter: wmem_max ...FAILED
racnode1: PRVG-2044 : Command "/sbin/sysctl -a | grep wmem_max[[:space:]]*="
failed on node "racnode1" and produced no output.
racnode1: PRVF-7544 : Check cannot be performed for kernel parameter "wmem_max"
on node "racnode1"
racnode1: PRVG-1205 : OS kernel parameter "wmem_max" does not have expected
current value on node "racnode1" [Expected = "1048576" ; Current =
"unknown"; Configured = "1048576"].
racnode1: PRVG-10048 : Name "racnode1" was not resolved to an address of the
specified type by name servers o"<IP_ADDRESS>".
racnode1: PRVG-10048 : Name "racnode1" was not resolved to an address of the
specified type by name servers o"<IP_ADDRESS>".
Attached racnode1 : sysctl.conf.gz

DNS/NTP error is expected because DNS is not available but it can be ignored and it is instrumented in the installation scripts in RAC docker image. For testing prupose, you can use single SCAN and can ignore DNS but not recommended and supported in your application workload or production workload.
Kernel parameter errors are strange to me as I never faced them.

However, I have a question:
Are you running cvu manually? or these errors are thrown by our scripts shipped with DockerFiles?
Also, I again tested it on my env and it looks like following:
=====
Verifying Physical Memory ...PASSED
Verifying Available Physical Memory ...PASSED
Verifying Swap Size ...FAILED (PRVF-7573)
Verifying Free Space: racnode1:/usr,racnode1:/var,racnode1:/etc,racnode1:/sbin,racnode1:/tmp,racnode1:/u01/app/grid ...PASSED
Verifying User Existence: grid ...
Verifying Users With Same UID: 54332 ...PASSED
Verifying User Existence: grid ...PASSED
Verifying Group Existence: asmadmin ...PASSED
Verifying Group Existence: dba ...PASSED
Verifying Group Membership: dba ...PASSED
Verifying Group Membership: asmadmin ...PASSED
Verifying Run Level ...PASSED
Verifying Hard Limit: maximum open file descriptors ...PASSED
Verifying Soft Limit: maximum open file descriptors ...PASSED
Verifying Hard Limit: maximum user processes ...PASSED
Verifying Soft Limit: maximum user processes ...PASSED
Verifying Soft Limit: maximum stack size ...PASSED
Verifying Architecture ...PASSED
Verifying OS Kernel Version ...PASSED
Verifying OS Kernel Parameter: semmsl ...PASSED
Verifying OS Kernel Parameter: semmns ...PASSED
Verifying OS Kernel Parameter: semopm ...PASSED
Verifying OS Kernel Parameter: semmni ...PASSED
Verifying OS Kernel Parameter: shmmax ...PASSED
Verifying OS Kernel Parameter: shmmni ...PASSED
Verifying OS Kernel Parameter: shmall ...PASSED
Verifying OS Kernel Parameter: file-max ...PASSED
Verifying OS Kernel Parameter: aio-max-nr ...PASSED
Verifying OS Kernel Parameter: panic_on_oops ...PASSED
Verifying Package: binutils-<IP_ADDRESS>.1 ...PASSED
Verifying Package: compat-libcap1-1.10 ...PASSED
Verifying Package: libgcc-4.8.2 (x86_64) ...PASSED
Verifying Package: libstdc++-4.8.2 (x86_64) ...PASSED
Verifying Package: libstdc++-devel-4.8.2 (x86_64) ...PASSED
Verifying Package: sysstat-10.1.5 ...PASSED
Verifying Package: ksh ...PASSED
Verifying Package: make-3.82 ...PASSED
Verifying Package: glibc-2.17 (x86_64) ...PASSED
Verifying Package: glibc-devel-2.17 (x86_64) ...PASSED
Verifying Package: libaio-0.3.109 (x86_64) ...PASSED
Verifying Package: libaio-devel-0.3.109 (x86_64) ...PASSED
Verifying Package: nfs-utils-1.2.3-15 ...PASSED
Verifying Package: smartmontools-6.2-4 ...PASSED
Verifying Package: net-tools-2.0-0.17 ...PASSED
Verifying Port Availability for component "Oracle Remote Method Invocation (ORMI)" ...PASSED
Verifying Port Availability for component "Oracle Notification Service (ONS)" ...PASSED
Verifying Port Availability for component "Oracle Cluster Synchronization Services (CSSD)" ...PASSED
Verifying Port Availability for component "Oracle Notification Service (ONS) Enterprise Manager support" ...PASSED
Verifying Port Availability for component "Oracle Database Listener" ...PASSED
Verifying Users With Same UID: 0 ...PASSED
Verifying Current Group ID ...PASSED
Verifying Root user consistency ...PASSED
Verifying Node Connectivity ...
Verifying Hosts File ...PASSED
Verifying Check that maximum (MTU) size packet goes through subnet ...PASSED
Verifying Node Connectivity ...PASSED
Verifying Multicast check ...PASSED
Verifying Device Checks for ASM ...
Verifying ASM device sharedness check ...
Verifying Package: cvuqdisk-1.0.10-1 ...PASSED
Verifying Shared Storage Accessibility:/asmdisks/asm_disk04.img,/asmdisks/asm_disk01.img,/asmdisks/asm_disk06.img,/asmdisks/asm_disk05.img,/asmdisks/asm_disk02.img,/asmdisks/asm_disk03.img ...PASSED
Verifying ASM device sharedness check ...PASSED
Verifying Device Checks for ASM ...PASSED
Verifying I/O scheduler ...
Verifying Package: cvuqdisk-1.0.10-1 ...PASSED
Verifying I/O scheduler ...PASSED
Verifying Network Time Protocol (NTP) ...
Verifying '/etc/ntp.conf' ...PASSED
Verifying '/var/run/ntpd.pid' ...PASSED
Verifying '/var/run/chronyd.pid' ...PASSED
Verifying Network Time Protocol (NTP) ...FAILED
Verifying Same core file name pattern ...PASSED
Verifying User Mask ...PASSED
Verifying User Not In Group "root": grid ...PASSED
Verifying Time zone consistency ...PASSED
Verifying VIP Subnet configuration check ...PASSED
Verifying resolv.conf Integrity ...
Verifying (Linux) resolv.conf Integrity ...FAILED (PRVG-10048)
Verifying resolv.conf Integrity ...FAILED (PRVG-10048)
Verifying DNS/NIS name service ...
Verifying Name Service Switch Configuration File Integrity ...PASSED
Verifying DNS/NIS name service ...PASSED
Verifying Single Client Access Name (SCAN) ...WARNING (PRVG-11368)
Verifying Domain Sockets ...PASSED
Verifying /boot mount ...PASSED
Verifying Daemon "avahi-daemon" not configured and running ...PASSED
Verifying Daemon "proxyt" not configured and running ...PASSED
Verifying loopback network interface address ...PASSED
Verifying Oracle base: /u01/app/grid ...
Verifying '/u01/app/grid' ...PASSED
Verifying Oracle base: /u01/app/grid ...PASSED
Verifying User Equivalence ...PASSED
Verifying File system mount options for path /var ...PASSED
Verifying zeroconf check ...PASSED
Verifying ASM Filter Driver configuration ...PASSED
Pre-check for cluster services setup was unsuccessful on all the nodes.
Failures were encountered during execution of CVU verification request "stage -pre crsinst".
Verifying Swap Size ...FAILED
racnode1: PRVF-7573 : Sufficient swap size is not available on node "racnode1"
[Required = 16GB (1.6777216E7KB) ; Found = 8GB (8388604.0KB)]
Verifying Network Time Protocol (NTP) ...FAILED
Verifying resolv.conf Integrity ...FAILED
racnode1: PRVG-10048 : Name "racnode1" was not resolved to an address of the
specified type by name servers o"<IP_ADDRESS>".
racnode1: PRVG-10048 : Name "racnode1" was not resolved to an address of the
specified type by name servers o"<IP_ADDRESS>".
racnode1: Check for integrity of file "/etc/resolv.conf" failed
Verifying (Linux) resolv.conf Integrity ...FAILED
racnode1: PRVG-10048 : Name "racnode1" was not resolved to an address of the
specified type by name servers o"<IP_ADDRESS>".
racnode1: PRVG-10048 : Name "racnode1" was not resolved to an address of the
specified type by name servers o"<IP_ADDRESS>".
Verifying Single Client Access Name (SCAN) ...WARNING
racnode1: PRVG-11368 : A SCAN is recommended to resolve to "3" or more IP
addresses, but SCAN "racnode-scan.k8local.com" resolves to only
"<IP_ADDRESS>,<IP_ADDRESS>"

I would request if you can paste the steps so that I can try to reproduce internally and will look into it.

I followed the steps as per README.MD
My env is on AWS AMI ID
RHEL-7.5_HVM_GA-20180322-x86_64-1-Hourly2-GP2 (ami-6871a115)
No sure if its tested on this environment.

This is strange as no one reported this kind of error yet. Technically, it should work on RHEL . However, I have no idea if any policy or setting at AWS causing issue which I have no idea.

Also, I looked at your sysctl conf file, where did you update this? on Docker Host i.e. your AWS instance or at container?
After looking at the file, it seems it is at racnode container level. What is the conf of your sysctl.conf at host level?
Can you set following parameters at docker host level where your docker engine is running:
edit /etc/syctl.conf and following
fs.file-max = 6815744
kernel.sem = 250 32000 100 128
kernel.shmmni = 4096
kernel.shmall =<PHONE_NUMBER>
kernel.shmmax =<PHONE_NUMBER>104
kernel.panic_on_oops = 1
net.core.rmem_default = 262144
net.core.rmem_max = 4194304
net.core.wmem_default = 262144
net.core.wmem_max = 1048576
net.ipv4.conf.all.rp_filter = 2
net.ipv4.conf.default.rp_filter = 2
fs.aio-max-nr = 1048576
net.ipv4.ip_local_port_range = 9000 65500
sysctl -p
sysctl -a

Please find my comments inline
Also, I looked at your sysctl conf file, where did you update this? on Docker Host i.e. your AWS instance or at container? Docker Host level
After looking at the file, it seems it is at racnode container level. What is the conf of your sysctl.conf at host level?
fs.file-max = 6815744
net.core.rmem_max = 4194304
net.core.rmem_default = 262144
net.core.wmem_max = 1048576
net.core.wmem_default = 262144
net.core.rmem_default = 262144
kernel.sem = 250 32000 100 128
kernel.shmmni = 4096
kernel.shmall =<PHONE_NUMBER>
kernel.shmmax =<PHONE_NUMBER>104
kernel.panic_on_oops = 1
net.ipv4.conf.all.rp_filter = 2
net.ipv4.conf.default.rp_filter = 2
fs.aio-max-nr = 1048576
net.ipv4.ip_local_port_range = 9000 65500
It seems some parameters are pulled from host during racnode1 setup except for kernel param
could you please check from your end
FYI
systemctl status systemd-modules-load
● systemd-modules-load.service - Load Kernel Modules
Loaded: loaded (/usr/lib/systemd/system/systemd-modules-load.service; static; vendor preset: disabled)
Active: inactive (dead)
Condition: start condition failed at Fri 2018-08-10 20:38:07 UTC; 1h 22min ago
none of the trigger conditions were met
Docs: man:systemd-modules-load.service(8)
man:modules-load.d(5)

Will it be possible to take control of my instance AMI for a first hand look. If so I will need rsa pub key

Will it be possible to take control of my instance AMI for a first hand look. If so I will need rsa pub key

Why not the other way around? Deploy an Oracle Linux 7 AMI and see if that works.

The Clckwrk OEL version adds a hefty surcharge of $0.06 per hour  :(

systemd-modules-load.service service is in failed state is expected as we are running in non-priv mode. We are not starting any service which is not required.

No change. Got same error again
Verifying OS Kernel Parameter: semopm ...FAILED (PRVG-1205)
Verifying OS Kernel Parameter: rmem_default ...FAILED (PRVG-2044, PRVF-7544, PRVG-1205)
Verifying OS Kernel Parameter: rmem_max ...FAILED (PRVG-2044, PRVF-7544, PRVG-1205)
Verifying OS Kernel Parameter: wmem_default ...FAILED (PRVG-2044, PRVF-7544, PRVG-1205)
Verifying OS Kernel Parameter: wmem_max ...FAILED (PRVG-2044, PRVF-7544, PRVG-1205)
Verifying OS Kernel Parameter: semopm ...FAILED
Verifying OS Kernel Parameter: rmem_default ...FAILED
Verifying OS Kernel Parameter: rmem_max ...FAILED
Verifying OS Kernel Parameter: wmem_default ...FAILED
Verifying OS Kernel Parameter: wmem_max ...FAILED
[grid@racnode1 ~]$ rpm -qa |grep systemd
systemd-libs-219-57.0.1.el7.x86_64
systemd-219-57.0.1.el7.x86_64
systemd-sysv-219-57.0.1.el7.x86_64

Systemd version seems to be fine. However, I am wondering why these kernel parameters are not being picked up in container.  Kernel.sem can be namespaced. where kernel.sem is equal to following:
kernel.sem = SEMMSL SEMMNS SEMOPM SEMMNI
Now, I am wondering why SEMOPM is not updated in the container but rest of them being picked up. Please check following docker documentation:
https://docs.docker.com/v17.06/edge/engine/reference/commandline/run/#configure-namespaced-kernel-parameters-sysctls-at-runtime
Also, rmem/wmem parameter must be picked from host. In my env which is a Oracle Linux 7.5 and 7.4, I am not facing this error.
 Here is the issue, Docker must be running on UEK 4 on docker host and your docker engine is running on UEK3 and this is not supported for RAC on Docker. I will also update this in docker RADME.MD but please update docker kernel host to UEK 4 and it should work.
For details, please check following:
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_oracle_docker-2Dimages_issues_955-23issuecomment-2D412339558&d=DwMFaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=X58wTh19-3pzEbGg2iSTddwjmPMBoBS8ARmjEV0fzYE&m=UXEYXNQrhwbqoyOmzekm7q0kYMhHpyPVAbrdE8W-bJs&s=7QuklurT0VmDymbHE37BpsI-YpSO3i19Q4sF4URJx8I&e=
Docker version 1.9 and later require that you configure the system to use the Unbreakable Enterprise Kernel Release 4 (UEK R4) and boot the system with this kernel. If you are using either UEK R3 or the Red Hat Compatible Kernel (RHCK), you must configure Yum to allow you to install UEK R4.

https://docs.oracle.com/cd/E52668_01/E87205/html/docker_install_upgrade_yum_uek.html

Actually @psaini79, that's not Oracle Linux at all. It's either RHEL or CentOS running the stock RHCK with Docker 17.05-ce installed.

Hi @Djelibeybi, you are right. It is not OEL. I would recommend @smbptnk  to test it on OEL 7.5 with UEK 4.


Fix bug with short circuiting pageX when it's 0

See #107.
Storing values in variables for shorter line length.

Thanks!


Partner portal: listing-edit/creation validation

We chatted with Safiya about which listing fields are required vs. nice-to-have. For the required fields, we should make sure that we have validation in place so that if someone tries to edit a listing in the partner portal and those fields are empty --> they are notified and prevented from saving the listing.
Required fields:

Project Name
Owner Company
Management Company
Property Phone
Manager Email
Project Address
Zip Code
Unit summary info (number of studios/1BR/2BR/..., AMI percentages for each unit type)

Note: the last category of data ("unit summary info") is not currently populated for any listings; we are trying to collect that data from the property manager survey. Safiya indicated that that unit summary info should be a required field, since it's so important for housing seekers to determine if they even qualify for any units in a particular listing. So we may have to be thoughtful about navigating the transition from "we don't have this data for any listings" to "we are requiring this data for any listing edited through the partner portal".

Also maybe in scope for this ticket: making sure that the typeorm/DB requirements match these HRD requirements. (There are fields that typeorm/DB require that aren't actually necessary, according to HRD and this list.)


Direct Memory OOM issue during upgrade to 0.4.0

The table has a few no-dictionary columns.
After the upgrade, the servers are experiencing OOM issue even when querying SELECT * FROM myTable.
Caused by: java.lang.OutOfMemoryError: Direct buffer memory
        at java.nio.Bits.reserveMemory(Bits.java:694) ~[?:1.8.0_252]
        at java.nio.DirectByteBuffer.<init>(DirectByteBuffer.java:123) ~[?:1.8.0_252]
        at java.nio.ByteBuffer.allocateDirect(ByteBuffer.java:311) ~[?:1.8.0_252]
        at org.apache.pinot.core.io.reader.impl.ChunkReaderContext.<init>(ChunkReaderContext.java:38) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-01cdc55f514b10bee2d8108d9736d4b57c48b517]
        at org.apache.pinot.core.io.reader.impl.v1.VarByteChunkSingleValueReader.createContext(VarByteChunkSingleValueReader.java:93) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-01cdc55f514b10bee2d8108d9736d4b57c48b517]
        at org.apache.pinot.core.io.reader.impl.v1.VarByteChunkSingleValueReader.createContext(VarByteChunkSingleValueReader.java:32) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-01cdc55f514b10bee2d8108d9736d4b57c48b517]
        at org.apache.pinot.core.operator.docvalsets.SingleValueSet.<init>(SingleValueSet.java:35) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-01cdc55f514b10bee2d8108d9736d4b57c48b517]
        at org.apache.pinot.core.operator.blocks.SingleValueBlock.<init>(SingleValueBlock.java:41) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-01cdc55f514b10bee2d8108d9736d4b57c48b517]
        at org.apache.pinot.core.segment.index.datasource.BaseDataSource.getNextBlock(BaseDataSource.java:105) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-01cdc55f514b10bee2d8108d9736d4b57c48b517]

cc @siddharthteotia @Jackie-Jiang @kishoreg

@fx19880617 , do we have the segments handy? We can load the segment and look into the file header to see number of documents per chunk. I had made an improvement (as part of supporting text blobs for text index) by deriving the number of documents per chunk based on the length of data as opposed to hard coded 1000. So if we pack more than 1000 rows per chunk, the size of each chunk will increase.
I don't think that would be the issue since I had this PR https://github.com/apache/incubator-pinot/pull/5470 which was included in the 0.4.0 release (a new RC was cut by Haibo to include this) and actually made this behavior configurable (disabled by default)

Segments are not handy and downloadable, I feel I need to write a program to run in prod then load segment and see the file headers. Those segments are created using 0.3.0 release.


Introduce an AOT alternative to using components index in DefaultPersistenceUnitManager to look up JPA entities

I tried to remove spring.components resource native configuration since I thought it was not needed anymore at runtime, I did that by commenting this line in SpringBootHints and this line in ConfigurationCollector but I then have the following error at startup in petclinic-jpa:
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'ownerController': Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'ownerRepository': Invocation of init method failed; nested exception is java.lang.IllegalArgumentException: Not a managed type: class org.springframework.samples.petclinic.owner.Owner
	at org.springframework.aot.beans.factory.InjectedConstructionResolver.resolve(InjectedConstructionResolver.java:90) ~[na:na]
	at org.springframework.aot.beans.factory.InjectedElementResolver.resolve(InjectedElementResolver.java:19) ~[na:na]
	at org.springframework.aot.beans.factory.InjectedElementResolver.create(InjectedElementResolver.java:50) ~[na:na]
	at org.springframework.aot.beans.factory.BeanDefinitionRegistrar$InstanceSupplierContext.create(BeanDefinitionRegistrar.java:168) ~[na:na]
	at org.springframework.samples.petclinic.owner.ContextBootstrapInitializer.lambda$registerOwnerController$1(ContextBootstrapInitializer.java:10)

After discussing with @snicoll, @christophstrobl and @schauder it seems it could come from ClassPathScanningCandidateComponentProvider usage in org.springframework.data.jpa.support.ClasspathScanningPersistenceUnitPostProcessor. We could implement a custom BeanPostProcessor like we did for invoke init/destroy callbacks to perform that step at buildtime and allow spring.components hint and synthesize removal.

@sdeleuze I have a quite similar exception, reported in gh-963, when trying to run native image with entities and repositories from separate jar.
I recently commited a data-jpa sample modification which produces:
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'dataJpaApplication': Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'fooRepository': Invocation of init method failed; nested exception is java.lang.IllegalArgumentException: Not a managed type: class org.springframework.experimental.domain.Foo

@ch4mpy I experience the same thing also. I thought my setup is wrong. The JPA reference to an entity from another jar.
I can't really solve even if I put in EntityScan in the SpringBootApplication

@ch4mpy I experience the same thing also. I thought my setup is wrong. The JPA reference to an entity from another jar.
I can't really solve even if I put in EntityScan in the SpringBootApplication

Thanks for bringing this to our attention. To address this issue we require changes in data-commons that will likely not be resolved prior to the next major data release that is planned to be supported by Boot 3.

@sdeleuze The ClasspathScanningPersistenceUnitPostProcessor is about to be deprecated in Spring Data. This issue seems to be better solved for DefaultPersistenceUnitManager which does also use the components index (scanPackage(...)) to identify candidate types.

Hi, I am facing similar issue when trying to update my project to build native images. My project requires to register entities from another dependent jar. Is there a workaround for this while it is being addressed?

This should be fixed in Spring Boot 3.0.0-M5. Please give that a try.

Thanks for the reply @snicoll
As suggested i'm giving it a try with 3.0.0-M5 but I face below issue when trying to execute the native image. Any pointers?
Caused by: jakarta.persistence.PersistenceException: Unable to resolve persistence unit root URL
	at org.springframework.orm.jpa.persistenceunit.DefaultPersistenceUnitManager.determineDefaultPersistenceUnitRootUrl(DefaultPersistenceUnitManager.java:643) ~[na:na]
	at org.springframework.orm.jpa.persistenceunit.DefaultPersistenceUnitManager.preparePersistenceUnitInfos(DefaultPersistenceUnitManager.java:462) ~[na:na]
	at org.springframework.orm.jpa.persistenceunit.DefaultPersistenceUnitManager.afterPropertiesSet(DefaultPersistenceUnitManager.java:443) ~[na:na]

Caused by: java.io.FileNotFoundException: class path resource [] cannot be resolved to URL because it does not exist

Thanks for trying @mikhilsanghvi. Can you please create a new issue in the Spring Framework issue tracker with a small sample that reproduces the issue?

Spring Native is now superseded by Spring Boot 3 official native support, see the related reference documentation for more details.
As a consequence, I am closing this issue, and recommend trying your use case with latest Spring Boot 3 version. If you still experience the issue reported here, please open an issue directly on the related Spring project (Spring Framework, Data, Security, Boot, Cloud, etc.) with a reproducer.
Thanks for your contribution on the experimental Spring Native project, we hope you will enjoy the official native support introduced by Spring Boot 3.


Wrong files are deleted

Storage Explorer Version: 1.14.1
Build Number: 20200711.2
Platform/OS: Windows 10
Architecture: x64
Regression From:  Yes
Bug Description
I selected 31 files, right-clicked and chose "Delete", and the wrong 31 files were deleted.
Steps to Reproduce
1.) Write to Blob from Spark.
2.) Attempt to delete the zero byte files in a directory.
Expected Experience
Zero byte files should be deleted (ideal), or at least deleting them should be a no op (previous experience).
Actual Experience
When writing to Blob, Spark creates zero byte files with the same name as the "real" folder names. These can be deleted in the Azure Portal, but not in the Storage Explorer desktop app. With a new version of the app installed, I decided to test if it can delete these empty files now. The outcome is worse than before: now it deletes the actual folders!
1.) I have a directory with 31 folders with data:

2.) The directory also has 31 empty files, an annoying Spark+Blob artifact:

3.) I selected the 31 empty files and chose "Delete":

4.) The actual folders were deleted and the 0 B files remained:

Additional Context
None.

@joappleMSFT If I guess correctly, those 0 byte blobs are stub blobs to represent the folders, which have the metadata "hdi_isFolder=true". If it is the case, it is by design to delete the actual folder when deleting their stub blobs (the blob with the same name and the "hdi_isFolder=true" metadata). You are supposed to treat these blobs as the folders themselves. Having only the 0 byte stub blob deleted without deleting the folders will create an invalid state with respect to the Spark data structure.
Regarding why those 0 byte stub blobs aren't deleted, there is a known bug about deleting such blobs in batch. The current workaround is to single select and delete them one at a time. We are working with AzCopy to get this bug fixed.

Hmm. If that's true, is it better to not show them at all? It makes it very easy to shoot yourself in your foot.
Note that when you copy a directory with them, the copied folder either doesn't have them or they are hidden.
Just my $0.02!

Note that when you copy a directory with them, the copied folder either doesn't have them or they are hidden.

@JasonYeMSFT please investigate this. We might need AzCopy to support this.
As for hiding the stub files, this isn't something we'd look to do right now.

@joappleMSFT we are not able to repro the stub files not being copied. Can you please connect with @JasonYeMSFT over teams and show him what you're talking about? If you can't find him in teams then I'd suggests looking at my org chart.

Closing due to lack of response. In the future, we'll be hiding these 0 byte blobs by default. See #3314


Add common/scripts/x86_64/Ubuntu_14.04/_installVersion.env to store DOCKER_VERSION and AWSCLI_VERSION

https://github.com/Shippable/pm/issues/10115

this is done, closing


Add API

TODO:

Endpoints to run scrape of all current products
Get info about one or more products

Will abandon this PR in favour of a new PR for adding a API


bump version to 0.8.0

Better late than never. Closes #240.

Good catch. Interestingly enough, the v0.8.0 binary shows the correct version:
><> ./confd-0.8.0-darwin-amd64 -version
confd 0.8.0

the v0.8.0 binary shows the correct version

Well good. :relieved: But I wonder if they were built from sources that weren't pushed to GitHub?
$ cd $GOPATH/src/github.com/kelseyhightower/confd
$ git checkout master
Previous HEAD position was 59ca7ec... ping the go-etcd client to v0.4.6
Switched to branch 'master'
$ git checkout master && git pull
Already on 'master'
Already up-to-date.
$ ./build && bin/confd --version
Building confd...
confd 0.7.1
$ git checkout v0.8.0
Note: checking out 'v0.8.0'.
...
$ godep go build && ./confd --version  # no ./build in this tag?
confd 0.7.1


Remove ResourceManagerWithCultureStringLocalizer and WithCulture interface member

The ResourceManagerWithCultureStringLocalizer and WithCulture interface member are often sources of confusion for users of Localization, especially if they want to create their own IStringLocalizer implementation. These items give the user the impression that we expect an IStringLocalizer instance to be "per-language, per-resource", when actually they should only be "per-resource", with the language searched for determined by the CultureInfo.CurrentUICulture at execution time.
Neither of these has any usage that I was able to find with a cursory search, and it's difficult for me to imagine when they would be the correct option, so let's just get rid of them in 3.0.

Or we can move WithCulture as extension method as I mentioned here

@ryanbrandenburg can we mark them as Obsolete in release 2.2 branch and removing them in the master branch?

Yeah, marking them as Obsolete would probably be step one, but this is just a suggestion on my part at this point. We'll have to talk it over with @mkArtakMSFT and probably @DamianEdwards to decide if they want this and what the plan would be first.

Sound good .. hope you check my earlier points in the issue that I referenced with them too ..

Another issue in WithCulture is if we passed a null it will create another instance with the same culture!!

@ryanbrandenburg any updates on this?

@mkArtakMSFT any update on this? Can we mark the types as Obsolete? or shall we make a PR for 3.0.0?


Show build status of master branch

@fabxc

:+1: Out of curiousity, do you know what it shows otherwise?

The most recently tested one. That's how I noticed it as fabxc/dev is broken.


Use Principled BSDF / Deprecate custom glTF node groups

Support the export of basic principled BSDF node.

/cc https://github.com/KhronosGroup/glTF-Blender-Exporter/issues/101

As discussed, having the importer and exporter in one place, this will finally result in a "smooth" round trip import - export.

Roughness does not export, have tried almost eeverything I can think of.

@Chaoss86 see in-progress docs: https://gltf-blender-io-docs-fuznnktuig.now.sh/addons/io_gltf2. If that node structure is not working for you, could you file a new bug with more details?


Unit test fails

Laravel Version: 8.14.0
PHP Version: 7.4.12
Database Driver & Version:

Description:
Base Unit test looks like this:
public function testBasicTest()
{
    $this->assertTrue(true);
}

when I add that line $users = User::all(); - and of course on top of file use App\Models\User; - I get:
Error: Call to a member function connection() on null

/var/www/cpt.local/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1492
/var/www/cpt.local/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1458
/var/www/cpt.local/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1265
/var/www/cpt.local/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1182
/var/www/cpt.local/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1218
/var/www/cpt.local/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1171
/var/www/cpt.local/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1161
/var/www/cpt.local/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:475
/var/www/cpt.local/html/tests/Unit/ExampleTest.php:18

The same line works in all Feature tests.
Steps To Reproduce:
Try to run that test:
public function testBasicTest()
{
    $this->assertTrue(true);
    $users = User::all();
}

You're extending the PHPUnit test case instead of the Laravel TestCase. If you need a database connection write a feature test.
Also: it's always a good idea to try to search for your issue before posting as this has been posted many times before.

Did you have describe it in https://laravel.com/docs/8.x/database-testing?
I only see:

Unit tests are tests that focus on a very small, isolated portion of your code. In fact, most unit tests probably focus on a single method.

I don't see that in docs. :confused:


"Connecting to" log msg always doubled

Every time controller connects to a node for GRPC, we log two lines:
pmem-csi-controller-0 Connecting to node controller : tcp://<IP_ADDRESS>:10001
pmem-csi-controller-0 Connecting to <IP_ADDRESS>:10001

2nd of those shows completely redundant information and can be avoided.
In a typical e2e test this produces thousands of lines which don't add value.

Both log messages are give at level 3.
Simplest solution is just to drop log line from Connect:
+++ b/pkg/pmem-grpc/grpc.go
@@ -29,7 +29,6 @@ func Connect(endpoint string, tlsConfig *tls.Config) (*grpc.ClientConn, error) {
        if err != nil {
                return nil, err
        }
-       glog.V(3).Infof("Connecting to %s", address)
        dialOptions := []grpc.DialOption{grpc.WithBackoffMaxDelay(time.Second)}

There are 2 callers currently (aside from unit test call) logging message using explanation where they connect. This is useful information.
To make the fix more correct, we could keep the log inside Connect() and delete outer calls,
that would guarantee all other (future added) callers also get logging automatically.
But then we would throw away those useful texts "to node controller" and "to registry server",
so what about adding another parameter "dest string" to Connect(), log using this inside Connect, and delete the log lines (2 occasions) before calling Connect.

Olev Kartau<EMAIL_ADDRESS>writes:

But then we would throw away those useful texts "to node controller" and "to registry server",
so what about adding another parameter "dest string" to Connect(), log
using this inside Connect, and delete the log lines (2 occasions)
before calling Connect.

Let's not add parameters that are only useful for creating better log
messages. The right solution for this is to pass a context and in that
context have a logger that the function is meant to use. Then with
structured logging, the caller can extend the logging in all invoked
functions with additional contextual information, for example the
request that is currently being processed or (in this case) what it is
that is supposed to be connected to.

This is nice plan, but isn't that quite close to what you plan to avoid: "added parameter (i.e. context) only useful for creating better log". And this variant comes with more source lines.
Passing context would make sense if that context is useful overall, but here we only add it for better logging?

Olev Kartau<EMAIL_ADDRESS>writes:

Passing context would make sense if that context is useful overall,
but here we only add it for better logging?

A context parameter is also useful to carry additional information, like
a deadline for the operation.


Support cross-subscription resource ID

Preconditions

[X] No need to upgrade Python SDK or the Python SDK is ready.

Related command
az network lb create
az network lb frontend-ip create
az network lb frontend-ip update
az network lb address-pool create
az network lb address-pool update
az network lb address-pool address add
az network lb address-pool address update
Resource Provider
Microsoft.Network/loadBalancers
Description of Feature or Work Requested
The SLB team is launching a cross-subscription feature for Azure Load Balancer. Currently, the CLI parameters (vnet, subnet, public IP addresses) accept resource IDs, but the IDs are limited to same subscription as the LB.
CLI should now support accepting resource IDs without this restriction and accepts Ids across subscriptions.
In addition, the command "az network lb create" vnet parameter should be able to take in an ID value (currently only accepts a name).
Minimum API Version Required
2023-04-01
Swagger PR link / SDK link
N/A
Request Example
No response
Target Date
2024-02-02
PM Contact
mahipdeora, anniefang
Engineer Contact
irrogozh
Additional context
Please reach out on teams for additional questions

Thank you for opening this issue, we will look into it.

@mahipdeora If my understanding correctly, except az network lb create, other commands already supported cross-subscription. Could you please confirm it for me? Thanks.

The CLI exits out with the following:
Command: az network lb frontend-ip create -g MahipCrossSUBCarnary -n MyFrontendIp --lb-name MyLb --public-ip-address '/subscriptions/56a332c0-57e2-46a2-a204-2d85d11e0e71/resourceGroups/crosssubTest/providers/Microsoft.Network/publicIPAddresses/Test'
Exit Code:
(LoadBalancerMustReferenceResourcesFromSameSubscription) LoadBalancer /subscriptions/6bb4a28a-db84-4e8a-b1dc-fabf7bd9f0b2/resourceGroups/MahipCrossSUBCarnary/providers/Microsoft.Network/loadBalancers/MyLb must use network resources from the same subscription and should not reference resources from different subscriptions.
Code: LoadBalancerMustReferenceResourcesFromSameSubscription
Message: LoadBalancer /subscriptions/6bb4a28a-db84-4e8a-b1dc-fabf7bd9f0b2/resourceGroups/MahipCrossSUBCarnary/providers/Microsoft.Network/loadBalancers/MyLb must use network resources from the same subscription and should not reference resources from different subscriptions.
The same command done through rest API/ARM works.

Yes you are correct for frontend. There is a bug with the backend CLI command (taken offline), so I can only test that once the bug is resolved.
Could we build support out for LB create?

Hi @mahipdeora .
According to the help message, the argument --subnet in az network lb create can accept an existing subnet from another subscription. Is this working for you?

I think modifying the --vnet-name argument is unnecessary if the --subnet argument already supports cross-subscription.
The --vnet-name argument is meant to be used with the --subnet argument, and changing it to accept vnet-id or adding a new argument --vnet-id would only confuse the users.

@mahipdeora It means --subnet and --vnet-name under az network lb create, does the creation support cross subscription when input --subnet in ID format as the help message says?

Name or ID of a subnet. Uses existing resource or creates new
if specified, or none if omitted. If name specified, also
specify --vnet-name. If you want to use an existing subnet in
other resource group or subscription, please provide the ID
instead of the name of the subnet.

Right but when a customer sets the subnet property/vnet name, do we add that vnet to the backend pool of the LB? For example, in LB create if I specify a BE pool, vnet, and subnet, does the BE pool get assigned the vnet?

@mahipdeora Thanks for your clarification. IMO, the subnet/vnet settings are related to frontendIPConfigurations (i.e., subnet_id), backendAddressPools is independent from it. https://github.com/Azure/azure-cli/blob/759bb130cc6736c80aab945a0902d13a75ce7b8f/src/azure-cli/azure/cli/command_modules/network/_template_builder.py#L356-L370

Ah in that case, the subnet should be fine and we won't need the vnet ID.

@mahipdeora Yes..., but our concern is currently --subnet in ID format is cross-subscription or not, could you please confirm it for us?

I just attempted this, and it fails with the following
az network lb create -g MahipCrossSUBCarnary -n MyLb2 --sku Standard --subnet '/subscriptions/56a332c0-57e2-46a2-a204-2d85d11e0e71/resourceGroups/crosssubTest/providers/Microsoft.Network/virtualNetworks/vnet/subnets/default'
subnet
/subscriptions/56a332c0-57e2-46a2-a204-2d85d11e0e71/resourceGroups/crosssubTest/providers/Microsoft.Network/virtualNetworks/vnet/subnets/default does not exist. Specify ( --subnet NAME [--vnet-name NAME] ) to create a new resource.

Just attempted and it fails with
az network lb create -g MahipCrossSUBCarnary -n LBNAME2 --sku Standard --subnet '/subscriptions/56a332c0-57e2-46a2-a204-2d85d11e0e71/resourceGroups/crosssubTest/providers/Microsoft.Network/virtualNetworks/vnet/subnets/default' --location eastus2euap
subnet /subscriptions/56a332c0-57e2-46a2-a204-2d85d11e0e71/resourceGroups/crosssubTest/providers/Microsoft.Network/virtualNetworks/vnet/subnets/default does not exist. Specify ( --subnet NAME [--vnet-name NAME] ) to create a new resource.

Same deployment goes through via ARM template.

Hi @mahipdeora .Thanks for your confirmation.
I'm working on supporting cross-subscription resource ID for --subnet and --public-ip-address.
However, I ran into a SubscriptionNotRegisteredForFeature when I tried to test this functionality. The error message says 'Subscription 0b1f6471-1bf0-4dda-aec3-cb9272f09590 is not registered for feature AllowCrossSubscriptionReferences required to carry out the requested operation.'
Unfortunately, I cannot register this feature myself due to a FeatureRegistrationUnsupported error. Could you please help me register this feature for the test subscription 0b1f6471-1bf0-4dda-aec3-cb9272f09590?