fix(sbb-pearl-chain-vertical): add width to columns

Preflight Checklist

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Issue
This PR Closes #
Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:

Browsers
I tested the build on the following browsers:

[ ] Firefox Desktop
[ ] Chrome Desktop
[ ] Edge Desktop
[ ] Safari Desktop
[ ] Chrome Mobile
[ ] Safari Mobile

Screen readers
I tested the build on the following browsers:

[ ] JAWS Firefox Desktop
[ ] JAWS Chrome Desktop
[ ] NVDA Firefox Desktop
[ ] NVDA Chrome Desktop
[ ] VoiceOver Safari Desktop
[ ] VoiceOver Chrome Desktop
[ ] VoiceOver Safari Mobile
[ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Codecov Report

Merging #1452 (2a2a6dd) into master (ab917b0) will increase coverage by 1.09%.
The diff coverage is 65.19%.

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
+ Coverage   54.85%   55.94%   +1.09%
==========================================
  Files          49       67      +18
  Lines        1659     2599     +940
  Branches      406      691     +285
==========================================
+ Hits          910     1454     +544
- Misses        671     1045     +374
- Partials       78      100      +22

Impacted Files
Coverage Δ

src/components/sbb-clock/sbb-clock.tsx
0.00% <0.00%> (ø)

src/components/sbb-logo/sbb-logo.tsx
0.00% <0.00%> (ø)

src/components/sbb-menu/sbb-menu.tsx
26.49% <ø> (ø)

...ents/sbb-pearl-chain-time/sbb-pearl-chain-time.tsx
100.00% <ø> (ø)

...in-vertical-item/sbb-pearl-chain-vertical-item.tsx
93.75% <ø> (ø)

...-pearl-chain-vertical/sbb-pearl-chain-vertical.tsx
100.00% <ø> (ø)

src/components/sbb-pearl-chain/sbb-pearl-chain.tsx
67.74% <ø> (-3.69%)
:arrow_down:

src/components/sbb-section/sbb-section.tsx
85.00% <ø> (ø)

src/components/sbb-signet/sbb-signet.tsx
0.00% <ø> (ø)

...mponents/sbb-slot-component/sbb-slot-component.tsx
100.00% <ø> (ø)

... and 48 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Going to reopen a new one as github actions seems to be messed up.


Duplicate tolerations key in chart template nodeplugin-daemonset.yaml

[cinder-csi-plugin] Duplicate tolerations key in nodeplugin-daemonset.yaml, analogous to #1599
https://github.com/kubernetes/cloud-provider-openstack/blob/2155ee9bc6e9376459a971672d936dd17678a022/charts/cinder-csi-plugin/templates/nodeplugin-daemonset.yaml#L16-L17
https://github.com/kubernetes/cloud-provider-openstack/blob/2155ee9bc6e9376459a971672d936dd17678a022/charts/cinder-csi-plugin/templates/nodeplugin-daemonset.yaml#L128
Once I locally fixed it, it worked.
Note:
Add the existing tolerations into the default values.yaml, see L16:
      tolerations:
        - operator: Exists

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
Error when deploying the chart with Flux2 (uses Kustomize underneath). Yaml validation failed because of duplicate key.
What you expected to happen:
Deploy cinder-csi-plugin chart without any issues with Flux2/Kustomize v4.
How to reproduce it:
Install chart with flux >= 0.16.1
Anything else we need to know?:
See #1599
Environment:

openstack-cloud-controller-manager(or other related binary) version:
OpenStack version:
Others:

Looks like we need to keep the validation as part of CI . Thanks for reporting the issue.

Fixed as part of #1609


Absolute paths in the generated PBRT file

For the test scene I am using RTB4+mPBRT introduce absolute paths for all the texture files. This causes problems when the computation is Dockerized because the absolute paths are not accessible from inside the Docker container (i.e. volumes are not being mounted).
For example
Texture "black_metal_spectrum" "spectrum" "imagemap"
"string filename" "/share/wandell/data/3DScenes/City/black_metal.exr"

Hi.  I can see how this would be an issue, but I would need more details before I can help.  Can you share the test scene so that I can reproduce the error on my end?

I'll do this later today.
Sent from a mobile device.
Dnia 15.02.2017 o godz. 06:52 Ben Heasly <notifications<EMAIL_ADDRESS>napisał(a):
Hi. I can see how this would be an issue, but I would need more details before I can help. Can you share the test scene so that I can reproduce the error on my end?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/RenderToolbox/mPbrt/issues/4#issuecomment-280031388, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEDRKeBNFIsn6IKCqIUq09Ty4XJP4rR0ks5rcxFAgaJpZM4MBOZA.

I think we resolved this in another thread.


added contributors.md

fixed #50
@Rakshit-gen
pls check

hey @Rakshit-gen can you please add the labels gssoc extd and level 1

and hacktoberfest too please


New upgrade of Belarusian language

Выпраўленыя недакладнасці, а таксама была разабрана граматычная тэрміналогія

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 29.435%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1318

Relevant Lines:
5476

💛  - Coveralls


Fix: Required input llm for module LLMChain not found

There is a recurring intermittent bug, where Chains fail to validate, with an error "Required module ____ for module ____ not found". This happens frequently for all LLMs that inherit from the LLM class (example Cohere's wrapper).
This is caused by this chunk of code.
This also explains why the bug is intermittent and not every time. "in" is matching LLM from source_types with BaseLLM from target_reqs. Also, this doesn't need to be a nested loop, it can be done with one loop.
I'm an avid user of LangFlow, and a first time contributor. Thanks!

Please let me know if this is acceptable, or if any changes are needed.  Thanks!

Hey, @sudo-update. Welcome!  Thanks for this bugfix.

Also, this doesn't need to be a nested loop, it can be done with one loop.

I think the reasoning at the time was that maybe the type would be Chain for the output but the target_req would be ConversationChain, something like that..
What do you think about this case?

Because the value of output and target_reqs are strings, partial matches will pass the condition.
`e = next(
(
output
for output in ['a', 'b', 'c', 'intended match']
for target_req in ['d', 'e', 'f', 'g', 'bad match', 'intended match']
if output in target_req
),
None,
)
print(e)`
The output of this code will be 'a' because output contains 'a', and target_reqs contains 'bad match' which contains 'a'
In this example flow of ConversationChain + BufferMemory + Cohere, when it hits this function, target reqs will be:
['BaseLanguageModel', 'str', 'str', 'langchain.callbacks.base.BaseCallbackHandler', 'BaseMemory', 'BaseLLMOutputParser', 'BasePromptTemplate', 'code', 'bool', 'str', 'bool']
The source_type for the BufferMemory will be:
['BaseChatMemory', 'ConversationBufferMemory', 'Serializable', 'BaseMemory']
And the source_type for the Cohere will be:
['Serializable', 'Cohere', 'BaseLanguageModel', 'BaseLLM', 'LLM']
so it will work in this case, because this problem won't happen, since BaseLanguageModel will match in both source and target.  If target was LLM instead, this problem will happen since BaseLLM will match with LLM since BaseLLM appears first in the sources.

Awesome! I'm very glad to make my first contribution!


How-to regarding dependency mirrors added

Summary
This adds the documentation on how to configure Paketo Buildpacks to use dependency mirrors as described in RFC 0060
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@paketo-buildpacks/utilities-maintainers

I am not entirely sure what is wrong with the CLA but you may need to rebase your PR to remove the commit that my account is on. Sorry about that.


Update mdBook dependencies

Should this be good to merge in? Have we double checked there won't be weirdness?

i didnt see any in the special parts, so i think its good, if it doesnt work, we can just revert :3


✨ Add CLI tests

This adds tests for the CLI/main function.
We need additional tests for other errors (rekor, signatures, etc)

probably worth keeping the tests that match vtag/tag against a workflow_dispatch/no tag, but lgtm, thank you!

I have not removed them, or at least it was not my intention. Which did I remove?

probably worth keeping the tests that match vtag/tag against a workflow_dispatch/no tag, but lgtm, thank you!

I have not removed them, or at least it was not my intention. Which did I remove?

my bad, some were commented out. Good catch

probably worth keeping the tests that match vtag/tag against a workflow_dispatch/no tag, but lgtm, thank you!

I have not removed them, or at least it was not my intention. Which did I remove?

my bad, some were commented out. Good catch

Fixed.


better syntactic ux for parallel zql queries

Currently parallel flowgraphs are specified as semi-colon separated operators ( proc ; proc ; proc) | ...
This is hard to author and hard to read.  One idea is to highlight the entry point of each parallel path in a group with => as follows...
(
  => (
       => count_src=sum(count) by host=id.orig_h | sort host
       => count_dst=sum(count) by host=id.resp_h | sort host
     ) | join host count_dst
  => filter _path=dns qtype_name="TXT" | count_dns=count() by host=id.orig_h | sort host
) | join host count_dns

instead of
(
  (
    count_src=sum(count) by host=id.orig_h | sort host ;
    count_dst=sum(count) by host=id.resp_h | sort host
  )  | join host count_dst ;
  filter _path=dns qtype_name="TXT" | count_dns=count() by host=id.orig_h | sort host
) | join host count_dns

We should also think about how a switch operator would jibe with a new syntax like this.

We should also think about how a switch operator would jibe with a new syntax like this.

Over in https://github.com/brimsec/zq/blob/gingest/zng/docs/draft-gingest.md#switched-parallel-flowgraphs, I sketched out
... | switch (
    <boolean expression> => ... | ...;
    <boolean expression> => ... | ...;
    ...
    ) | ...

Just a sketch. The reason I had semicolons at the end of each line was for consistency with regular split flowgraph syntax. I wasn't aware of this issue, but if the syntax is changing , then so should this!
Whatever we go with, the one thing I think we should keep is that the switch condition (<boolean expression>) should be syntactically demarcated  from the procs to its right. In my sketch I had started off with <boolean expression> | ... | ...; but this is a bit deceptive.

filed #1790 for switch

This has been worked over quite a bit to date.


Offline #6: git new-pull-request

Please update the base of this PR

All comments addressed

All comments addressed


Fix cli command restore-repo: "units" should be parsed as cli.String

The "units" should be splitted to string slice, to match the old behavior and match the dump-repo's behavior https://github.com/go-gitea/gitea/blob/main/cmd/dump_repo.go#L129-L130
Before, the #19953 was misled by #19935 (sorry that I didn't find the problem at that time, just followed these 3 LGTMs).
This PR should make everything correct and consistent, and more stable by trimming / checking

LGTM


revert: feat: add query options

This reverts commit 661f8f5785bad84b9f052614fb8075d8c83ee60c.
Reverts googleapis/google-cloud-php#2726
Preparing a revert in case we need to do a PHP library release that doesn't include this change. See comment for details.

@jdpedrie please feel to remove the "do not merge" and merge if it becomes necessary to do a release.

Closing since it's fine to merge in this change into a release.


Render user profile pictures as suggestion icons

Testing https://github.com/microsoft/vscode-internalbacklog/issues/947
IMHO it would be better if the user profile picture would be rendered as the suggestion icon instead of the current icon:

https://github.com/microsoft/vscode/issues/91541, which could enable this.

The API that was added still doesn't support using profile pictures. Closing as upstream.


Add HTTP types adapter for SwiftNIO

Add swift-http-types adapters that works with SwiftNIO HTTP protocols.
Motivation:
SwiftNIO Channel implementations should be able to use the shared HTTP currency types.
Modifications:
3 new targets:

NIOHTTPTypes: version independent data types
NIOHTTPTypesHTTP1: convertors between http1 types and new http types
NIOHTTPTypesHTTP2: convertors between http2 types and new http types

@swift-server-bot add to allowlist

@guoye-zhang I think this is missing the dependency?

Oh we need to reduce the swift version of swift-http-types to 5.6

I updated the Package.swift to only depend on swift-http-types on 5.8 or later since it depends on a few new language features.

cc @Lukasa

Should I bump the Swift version to 5.7.1 in this PR?

Should I bump the Swift version to 5.7.1 in this PR?

Yes let's do that.

There are still a few Dockerfiles mentioning 5.7, but those should mean latest 5.7.x? Do I need to change them?

They mean latest 5.7.x. That's typically fine, 5.7 just means "floating" in most cases.


gccgo: “use a small discontiguous stack for goroutines” may not be specified clearly enough to be implemented elsewhere

At https://golang.org/doc/install/gccgo#Gold is written:

On x86 GNU/Linux systems the gccgo compiler is able to use a small discontiguous stack for goroutines. This permits programs to run many more goroutines, since each goroutine can use a relatively small stack. Doing this requires using the gold linker version 2.22 or later. You can either install GNU binutils 2.22 or later, or you can build gold yourself.

This means, that ld.bfd and ld.lld do not support “small discontiguous stack “. As can be seen at https://sourceware.org/bugzilla/show_bug.cgi?id=28141 , this feature cannot be implemented in ld.bfd, because it lacks clear specification.
• Provide at https://sourceware.org/bugzilla/show_bug.cgi?id=28141 a clear specification for the feature of ld.gold “usage of small discontiguous stack for goroutines”

CC @ianlancetaylor.

Added the spec to the sourceware bugzilla.


Fix GCE TODOs floc 4241

Here we've improved timeouts, error handling and we can walk the pages when listing volumes. We have 2 lingering todos: fixing logging which will come in a separate PR and alternative GCE credentials (FLOC-4242).

Thanks @justnoise

The branch needs merging forward.
I left a few comments and questions.
There are some lint errors.

Please answer or address those and merge when green.

Great feedback @wallrj!


10 SEP 2024 - InnerSource SIG Meeting Minutes

Date
Tuesday 10 SEP 2024 - 10:00am EST / 3:00pm UK
Attendee Identity
Please identify yourself when you attend the meeting by providing your name and affiliation in reply to this thread. Alternative we will need to add you here if you do not have a Github id

Fullname, Affiliation, (optional) GitHub username
...

Meeting notices

FINOS SIG Leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS SIG meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene & roll call (5mins)
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
[ ] Approve past meeting minutes
[ ] Establishing a InnerSource SIG Project board - Chamindra
[ ] Continuation of InnerSource metrics discussion and next steps
[ ] InnerSource Chargeback model discussion - Brittany
[ ] Moving forward InnerSource Licensing templates - Chamindra
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Minutes

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Zoom Details

https://zoom.us/j/97717618541
Meeting ID: 977 1761 8541
Passcode: 878599)

Join by phone
Find your local number: https://zoom.us/u/adJnH9JOiY
Mailing List
Email<EMAIL_ADDRESS>to subscribe to the InnerSource SIG
mailing list.

Brittany Istenes - FNMA

Joseph Zang - FNMA

Daniel Izquierdo - Bitergia

Katrina Novakovic - Citi


Add support for custom telephone types

PR Type: Feature
What does this PR do:
Add support for custom telephone types, as from RFC: (https://datatracker.ietf.org/doc/html/rfc6350#section-6.1.4), see pages 34/35.
Notes (if any):
Tested with Android Galaxy phone

@bolorundurowb can you take a look to this PR?
I'm not able to reproduce the CI error locally (I'm running Windows), any ideas why it's failing?

I found it. I did not pull your latest commits.
Updating
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0" />
<PackageReference Include="NUnit3TestAdapter" Version="3.9.0" />

to
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.2.1" />

breaks the build.
The change has been introduced with this commit:
(https://github.com/bolorundurowb/vCardLib/commit/532d9ff774a876d0fabf91413bed5affb948a880).
Do you need/want support all these (old) frameworks?

hey @rallets, I'll take a look at the CI as that may need updating

Hey @rallets can you update your branch with the latest master? I have changed the appveyor build image and updates the target frameworks

@bolorundurowb tks, not the build looks fine!

@bolorundurowb tks!


Port over name fixups from https://github.com/youknowone/gitstat/blob…

…/servostat/local_settings.py

This change is

Going to wait on merging until I see how the Travis CI build goes :-)

@edunham would you expect that failure with credentials.py? I assume it only works for things on master? I'm hesitant (as always) to just push something to master :-)


Release Google.Cloud.Speech.V2 version 1.0.0-beta05

Changes in this release:
New features

Add processing strategy to batch recognition requests (commit bbd6a85)

Created release for Google.Cloud.Speech.V2-1.0.0-beta05


error when installing (legacy version)

When executing installation instructions

@Hunam6 please checkout the master branch (git checkout master) if you want to use the legacy version.


chore: migrate AWS SDK for JavaScript v2 APIs to v3 in static-website

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

Maintainers: I'm not sure why CI is failing.
Feel free to take over this PR when you review it.

Maintainers: I'm not sure why CI is failing.
Feel free to take over this PR when you review it.

It is because the SDK versions need to match across packages. I've just updated them for you :)


haskell.packages.ghc921.cabal2nix: make dependencies build

Motivation for this change
Especially the distribution-nixpkgs fix is a bit ugly, could be fixed by making a new 1.6.2 release.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Will merge as soon as gitlab.haskell.org stops 502ing…


Use heuristics and dimension lifting

We should investigate using information about machine to generate optimal dimension lifted forms.
at LLVM level we could use https://llvm.org/docs/CommandGuide/llvm-exegesis.html and see also http://lists.llvm.org/pipermail/llvm-dev/2018-March/121841.html

Closed since covered by general #17


multiple chart types?

hey @santosjorge - thoughts on the best way to plot multiple chart types, i.e. a bar and a line?
type as an array or a dict, sort of like how secondary_y works:
df = pd.DataFrame({
     'y1': [3, 1, 5],
     'y2': [30, 50, 20]
}, index=[1, 2, 3])

df.iplot(kind={'y1': 'bar', 'y2': 'scatter'})

df.iplot(kind=['bar', 'scatter'])

this pattern could apply to any of the non-array figure properties, e.g.
df.iplot(mode=['markers', 'text'], marker=[{'color': 'blue}, {'color': 'red'}])

Hey Chris,
Currently the way to do this would be:
fig=cf.tools.figures(df,[{'kind':'bar'},{'kind':'scatter','mode':'markers','color':'red'}])
cf.iplot(fig)

cf.tools.figures takes a DataFrame and then a list of dictionaries with all the specs.
This works today. But of course it could be enhanced if you think it could be made easier. I think passing the 'kind' types in a dict is intuitive enough, the problem is when you start passing specs. That is why I went down this way, but let me know what you think.

got it! that looks like a good solution for now!

hey @santosjorge - I'm just giving this a try today. Since cf.tools.figures returns a list of figures, it seems like I need to merge the figures before I plot them, e.g.
df = cf.datagen.lines(2, 5)

figs = cf.tools.figures(df, [
    {'kind': 'bar'},
    {'kind': 'scatter', 'mode': 'markers'}
])

fig = {'data': [], 'layout': {}}
for f in figs:
    fig['data'].extend(f['data'])
    fig['layout'].update(f['layout'])

I'm not sure if the solution is for cf.tools.figures to return a single, merged figure or for another cf.tools function like cf.tools.create_figure, or the original suggestion of letting df.iplot accept values as an array. Thoughts?

Hey Chris,
cf.figures returns a single figure already merged. You should be able to do
df = cf.datagen.lines(2, 5)

figs = cf.tools.figures(df, [
    {'kind': 'bar'},
    {'kind': 'scatter', 'mode': 'markers'}
])

cf.iplot(figs)

without any issue.
But I'll work in a new function to do accept values as an array. I will try first with df.iplot, I am just concerned about overloading it too much. I'll get back to you on this.

Hi.
I am trying to have different kind of plots with different data and with a secondary axis. But in the last step of having a different axis I have had problems. How I could solve this step?
I try adding a secondary y axis, but it doesn't work.
df = pd.DataFrame({'y1': [3, 1, 5], 'y2': [30, 50, 20], 'y3': [300, 500, 200]}, index=[1, 2, 3])
fig=cf.tools.figures(df,[{'kind':'bar','keys':['y2','y1']},
                         {'kind':'scatter','keys':['y3'],'mode':'markers','color':'red',
                         'secondary_y':['y3']}])

Version '0.17.0'
Thank you so much in advance.


Da Psych Engine SITCHEEATEEON

What is your question?
Are you gonna do a newer version (if you are, what is a rough estimate of how close you are to completing it) of the Psych Engine for the Pit Stop update (i kinda want that shiz rn)

I'd recommend closing this issue because Shadow Mario already addressed this question on the Psych Engine server.

ok not sigma b ut respect it, makes sense bc the updates basically made it a whole new game.


Toggle ReportCaller on specific log calls

Is it possible to toggle ReportCaller on Fatal/Fatalf and Error/Errorf calls but not the remaining calls?

I did something like this, making a service for logging and then calling this throughout my project.
package loggy

import (
	"github.com/charmbracelet/log"
	"os"
)

type Logger struct {
	*log.Logger
}

func New() *Logger {
	return &Logger{log.NewWithOptions(os.Stdout, log.Options{
		ReportCaller:    true,
		ReportTimestamp: true,
	})}
}

func (log *Logger) Fatal(args ...interface{}) {
	file, err := os.OpenFile("logfile.txt", os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0644)
	if err != nil {
		log.Fatal(err)
	}

	log.SetReportCaller(true)

	log.SetOutput(file)

	log.Fatal(args)
	file.Close().Error()
}

Hope this was helpful.

@JustJordanT
Definitely helpful, thanks.
I hadn't even considered making a wrapper around it.


Add CVE-2023-6932

Hey. The backup_artifacts step seems to be always failing. Not sure what I can do about it. I first created a draft PR and thought it was because of it, but re-running the checks on the real PR did not seem to resolve the issue.

Hey! Sorry, the backup_artifacts step failed because a bug on our part. I am running the checks again - hopefully now everything will be successful.

Hey @liona24, thanks for your submission! In the exploit documentation it was a bit unclear that the timer_list function gets called with a reference to the timer structure. Making it a bit hard to follow the __register_binfmt part, in the end we figured it out but could you make some changes to the documentation so that's a bit clearer to other folks who want to learn from this exploit :) Other than that it looks good!

Hey @JordyZomer , thanks for having a look. I did some changes to the documentation hopefully addressing your feedback, feel free to have a look again :)


[conformance] Gateway Dynamic Listener Ports

What type of PR is this?
/area conformance
/kind feature
What this PR does / why we need it:
This adds a conformance tests where  listeners with dynamic ports are added
Which issue(s) this PR fixes:

Part of https://github.com/kubernetes-sigs/gateway-api/issues/1842
Does this PR introduce a user-facing change?:

Hey @dprotaso, thanks for the PR! I'm realizing my issue wasn't very clear, but the goal of that issue was to actually first ensure we'd reached consensus on requirements and added them to the API spec before we added conformance tests to exercise this. I unfortunately did not communicate that very well, sorry!
In general, I think we need to be careful anytime we're adding conformance tests that require behavior that isn't explicitly required by the spec. I think it's always much safer to agree on the requirements we want via API Spec updates and then to add conformance tests once we've reached an agreement.
/hold

@robscott yeah no worries - I just forgot to mark this as a draft - this was done for the purposes of the discussion.
Also FWIW this test passes on Istio (cc @howardjohn) 🎉

I marked this PR ready for review since this test is behind a flag

@dprotaso before we go too far with this conformance test can you actually propose an update to the spec? We absolutely can't let a conformance test merge unless it's based on something in the API spec.

@robscott sound's good - done here https://github.com/kubernetes-sigs/gateway-api/pull/2065

@robscott #2065 has merged - PTAL

rebased

Since this hasn't been updated in a while, and has some conflicts I'm going to mark it as a draft again for now as this helps us organize our reviews. Once we're updated and ready for review please feel free to set it back to ready again.


Update base template

Sorry, this is not really warranted for a missing dependency on a pretty much dead project used by maybe 3 people. A complete rewrite of a working build system is not necessary, especially not fundamentally changing the file organisation of the project. If the missing files can be located elsewhere they either just need to be linked to, or included in the project.


ScrollSpy skips short sections

#15729
This is still an issue that needs "solved" in Bootstrap 4
if the last section(s) are short, when reaching the bottom of the page, bootstrap will skip over anchors that didn't get scrolled to the top of the page and consider the last anchor to be "active"

Hi @bkdotcom can you provide a test case in v4 ?

Closing due to lack of response. You can comment here and we can re-open the issue.
This is an automated reply

I stole the bootstrap 3 example and converted it to bootstrap 4:
https://codepen.io/bkdotcom/pen/vYEyeVr

Hello everyone! This problem seems to be heavily dependent on where the short content is on the page. The example @bkdotcom provided accurately represents the case that led me to this issue in the first place. However, if you take that same example, slice the two short <sections> and re-insert them in the second and third slots within the container div, the scrollspy works correctly.
As best as I can tell, the current logic for determining the active <div> within the scrollspy is as follows:

If the top of the scrollElement is at a location greater than or equal to the top of the scrollElement when you can't scroll anymore, make the last target active and return.
Consider each possible target, working from the bottom of the page
If the top of the scrollElement is beneath the top of the considered target AND the top of the scrollElement is beneath the top of the previously considered element, mark the current index as active.
Else, change your target to the next element further up the page and repeat step 3.

(The logic is in the _process method, with the check on line 234 being the interesting case.
When stepping through the debugger on the provided example, it's clear that the bottom of the scrollElement is reached, triggering the short-circuit logic in case 1, before the smaller divs have a chance to have the top of their bounding box reach the top of the scrollElement which would make them active.
The key insight here is that you can't actually scroll through the total height of the scrollElement amount of space, but rather total_height - amount_viewable_at_any_given_time.
This suggests the trivial fix, which is just add an empty element with a height of _getOffsetHeight() as this would allow you to scroll every target up to the top of the scrollElement. Obviously, this would leave a lot of white space and wouldn't provide a great UX.
One alternative would be calculate the percentage height that each target makes up of scrollElement height. Then, as the user scrolls, we can calculate the relative amount they've scrolled compared to the maximum possible scroll distance. Then, we can use the same comparison logic that's already in place to figure out what bucket we're in.
What do y'all think? I'm happy to put up a PR if we can agree on an approach.

@stevenbuccini would your proposed fix handle the case where you click on an anchor link, rather than scrolling to it manually? In the test case, for example, clicking on the penultimate "Cat ipsum" activates "Batman ipsum", even though it's not the one you clicked on. That behavior is less intuitive than when scrolling manually, in my opinion.

I can't say with certainty as I haven't looked at this in several months. However, it seems like clicking an anchor link directly should bypass the height offset calculations entirely and simply call _activate() on the appropriate target.

Unfortunately, that doesn't seem to be the case. From what I can tell, Scrollspy only responds to scroll events, so it doesn't know that the scrolling was caused by clicking an anchor link. Clicking on "Cat ipsum" in the example from @bkdotcom selects the link below it, "Batman ipsum".

It looks like clicking an anchor link triggers the scroll event which is why the ScrollSpy gets called and the wrong link is highlighted. However, the above link seems to suggest that perhaps the Scrollspy could check to see if there is valid value in window.location.hash to short-circuit the scroll height computation.

It looks like clicking an anchor link triggers the scroll event which is why the ScrollSpy gets called and the wrong link is highlighted. However, the above link seems to suggest that perhaps the Scrollspy could check to see if there is valid value in window.location.hash to short-circuit the scroll height computation.

That approach has some challenges, too. In @bkdotcom's example, clicking on a link doesn't actually add the hash to the URL, so I'm not sure if we can rely on that. When I run  bootstrap/js/tests/visual/scrollspy.html from the current main (a 5.0.0 alpha), clicking a link does update the URL hash, but it also uses smooth scrolling, so the scroll event gets triggered multiple times. If you then scroll to another section manually, it keeps the old URL hash, so the short-circuiting would need to be in effect during that initial smooth scroll, but return to normal when it reaches the target or you scroll elsewhere.

I had the same issue with @bkdotcom  on Chromium. But in Firefox, the active item or anchor is always first. Can't change at all

This should hopefully be addressed in v5 by #33421. Closing out and leaving as a won't fix in v4.


Dense Regression Branch

Could you please explain a little bit where the Dense Regression Branch is in your model? I think I only find the bounding box, cls, and landmark branch but not the dense regression branch. Thx

I will add this part later if time permits.

need +1

Need +1

@biubug6 Did you finished dense regression branch?

这篇文章大的创新点应该就是加入3Drender分支，希望能加入这个分支

Need + 1


Nice formatting on Activities page

What is a quick description of the change?
Show more information on the activities page to make for more intuitive planning.
Is this fixing an issue?
Provides a temporary fix for #132.
Are there more details that are relevant?

Moves +Add button to top of page
Shows more information upfront (includes addition of trip util)

Check lists (check x in [ ] of list items)

[x] Test written/updating
[] Tests passing
[x] Coding style (indentation, etc)

Please explain why any are not present, if any.
See #140.
Any additional comments?
Just a smidge more intuitive
Before:

After:

Received @Hiram-Silvey 's verbal approval to merge since this is the last day of the internship and he was not able to review the PR.


Use OSI API to check cross ref links

Fixes #141
Signed-off-by: Gary O'Neall<EMAIL_ADDRESS>

The CI is failing for the same reason we couldn't access the licenses in the first place.
See https://github.com/spdx/license-list-XML/issues/1582#issuecomment-1287531392 for more information.
Once this passes the CI, I'll merge it in.


Isolate node fetch for jupyter to use our own

For #11830
The version of node-fetch that jupyter uses isn't compatible with other versions. Forcing it to use our global one seems to fix the problem.

I'm still a little iffy on why this was happening in the first place. Why was jupyter's node-fetch coming from the other package? Shouldn't node isolate these things?
I verified in the debugger that doing this means jupyter is actually using ours, but I'm not 100% sure webpack isn't messing something up here.
It might just be working because the version matches now (I tested the vsix too)


Make tsconfig.*.json all use tsconfig.json icon

[x] I'm sure this issue is not a duplicate.

[x] I'm submitting an icon request:

Type: tsconfig
Icon Name: tsconfig
Extensions: json
Filenames: tsconfig.*.json
Language ids: typescript

Language Extensions: TypeScript

More info:

Right now tsconfig.base.json is using the icon. Want to expand it to any file matching tsconfig.*.json

Not technically possible yet.

Thanks for the quick update.
Would that be desirable and support that in the future?
If so, maybe you can keep this open for tracking. 🌷

@unional Please upvote here: https://github.com/Microsoft/vscode/issues/12493

@jens1o Exactly what I was looking for. Thanks

Bookmarks are useful ;)


Add support for FULLTEXT indexes

The tool is currently returning the following:
2017/11/29 20:01:17 cannot get table table_fulltext struct: cannot read constraints: sql: Scan error on column index 5: unsupported Scan, storing driver.Value type <nil> into type *string

CREATE TABLE `table_fulltext` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `string` text NOT NULL,
  PRIMARY KEY (`id`),
  KEY `string` (`string`(15)),
  FULLTEXT KEY `FT_string` (`string`)
) ENGINE=InnoDB;

Done. Thanks for the bug report


fix: 403 get response error

When I use this project then I see this exception:
io.github.jwdeveloper.tiktok.exceptions.TikTokLiveRequestException: Failed to fetch room id from WebCast, see stacktrace for more info.

This pull request solve this issue. I removed "Accept-Encoding" header because it will get json parse issue.

Thank you for your PR I will include it to the next update


Turbo morph displays progress bar

First of all, the new morphing feature feels extremely seamless whenever a refresh is triggered. If it weren't for the progress bar, I'm not even sure I'd know that it was happening. As an end user of an app that utilizes morphing it is likely not necessary and is instead potentially distracting to see a refresh bar appear when they aren't even expecting the page to refresh. Is there any way to disable the progress bar for page morph actions?

@jorgemanrubia thoughts on this proposal? I think it would be beneficial to allow users to disable the progress bar both globally and at the frame/stream level. This would provide greater flexibility in managing user experience.
Example:
// Turns off the progress bar globally
Turbo.progressBar = 'off';

<turbo-stream action="refresh" target="example_target" progress-bar="off">
  <template>
    <!-- Content updates here won't trigger the progress bar -->
  </template>
</turbo-stream>

<turbo-frame id="example_frame" progress-bar="off">
  <!-- Content here won't trigger the progress bar when loading -->
</turbo-frame>

across the board control can also be achieved with an attribute on the turbo-refresh-method meta tag  instead of JS config e.g.
<meta name="turbo-refresh-method" content="morph"  progress-bar="off">

or a new meta tag for the progress bar only e.g.
<meta name="turbo-progress-bar" content="off">


_getModule fix

这个 PR 实现什么功能/修复什么问题:
*_getModule mods长度为1时，直接返回mod，忽略版本检查
是否需要 backport 到之前的 release 分支:
release/3.0
/area region
/cc @swordqiu @yousong

Codecov Report

Merging #4766 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4766      +/-   ##
=========================================
+ Coverage    6.78%   6.79%   +<.01%
=========================================
  Files         524     524
  Lines       89719   89719
=========================================
+ Hits         6091    6093       +2
+ Misses      83120   83119       -1
+ Partials      508     507       -1

Flag
Coverage Δ

#aFlag
6.79% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/appsrv/response.go
69.23% <0%> (+3.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c31d1a...1b7acb4. Read the comment docs.

/cc @zexi

/lgtm

/lgtm

/approve


callbacks onLoadStart & onLoadStop brocken on version 6.2.0

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
On loading and stop loading view callbacks don't work

Expected Behavior
For example on version 6.1.5 all is fine:

Steps with code example to reproduce
default example from library is used
Stacktrace/Logs
[WebPlatformInAppWebViewWidget] (Web) WebPlatformInAppWebViewWidget ID 0 calling "onWebViewCreated" using []
4
null

Flutter version
3.24.4
Operating System, Device-specific and/or Tool
Web
Plugin version
6.2.0
Additional information
No response
Self grab

[ ] I'm ready to work on this issue!

Released official new version 6.2.0-beta.1.


Document async codemod dependency on v7.9+

@christian-bromann: This pull request documents the async codemod's dependency on WebDriver 7.9+, as discussed in https://github.com/webdriverio/codemod/issues/89#issuecomment-1445448642.

@prust thanks for the PR, mind signing the CLA?

@christian-bromann: not at all, but FYI the linux foundation's EasyCLA tool seems to be struggling at the moment (I got a 500 error adding my manager on the "Identify CLA Manager" screen, my manager then tried the "Are you a CLA Manager for your organization?" workflow, but that appears to be having issues as well. He'll try again tomorrow.
https://status.linuxfoundation.org does say "Service Under Maintenance", so perhaps that's the issue? (I don't see a status line that's specific to EasyCLA):

@christian-bromann: FYI, the CLA is now signed


Why?

why? just... why?

What "why"?

Why patch based? What are the advantages?

I think that if the project aims to be collaboration oriented clean source is better.

Faster recompile, faster changes review

Yeah but less people working on it.

you can download jar from CI

I'm talking abot PRs

There is rebuildPatches.sh script

this is just an useless complexity

join to us irc :wink:

nevermind, the project is yours... let it became like spigot (collaborative -110%)

I'd argue it's easier for everyone. It makes it easy to merge commits with Bungeecord. Once you have the environment setup, it's easy to submit changes. Learn how to use git before you start complaining.

It's not for me, i know how the patches works, in my opinion in this way everyone who isn't a git expert is unable to contribute to the project.

They are completely able to contribute. If they don't want to learn how to use git then they probably don't know enough to contribute good code.

Contributing should be easy, this is the purpose of github.

GitHub is a git hosting site. It does not guarantee that contributing to a project will be the easiest thing in the world. It is easy enough to submit changes with this patch system. Obviously, a separate code base is easier for skids to hack, but a patch system makes it easy to merge upstream.

But, what is hard in patches? Just change project code, rebuildPatches.sh, git commit, git push

We agreed to switch to a patch based system because it allows us to easily see and manage the diff with upstream.
It also allows us to easily merge upstream (it got very complicated in the old system).
Once you know how to contribute, its easy, although we should add a guide #10.
Making a large contribution to waterfall already has a relatively high barrier of entry, and switching back to the old system won't make it that much easier.
We will not be switching back to the old system just to slightly reduce the learning curve for contributing small patches to the repo.


Lets Encrypt v2 API plans

Hi,
I wondered if you had any current plans to support the v2 API, in particular people are pretty keen on the idea that wildcard certificates might be supported.
I'm currently looking at existing c# acme client implementations and gauging whether to implement my own or adopt an existing one.

Yes, will definitely follow up as LE/Boulder implements API v2 and wildcard certificates.
Will work on implementing the account/order flow according the latest spec soon.

The v2 API is supported in v2. :heavy_check_mark:


Bezier curve tension

The regular line graph does support this with a value being i.e.
bezierCurveTension: 0.3

Support for this would be nice, if you want graphs to be less messy and more straight if the data is close to each other.
Example of short time difference generating curves:

This issue isn't correct. It is implemented, and what I looked for was to disable it with bezierCurve: false. Otherwise this will now and then generate shapes which aren't functions, and thus impossible.


Make console log only when in DEV mode

@tadas-subonis Are you going to fix errors?

I will
On Mon, Aug 15, 2016 at 12:43 PM, Pavel Aksonov<EMAIL_ADDRESS>wrote:

@tadas-subonis https://github.com/tadas-subonis Are you going to fix
errors?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aksonov/react-native-router-flux/pull/1050#issuecomment-239765348,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPFsk5LXBE2FJr7dFQ_NArStAWUzZE8ks5qgDSkgaJpZM4Ji5W_
.

--
Kind Regards,
Tadas Šubonis

Not sure what I can do about failing lint

@tadas-subonis You can use // eslint-disable-line no-undef on these specific lines.
http://eslint.org/docs/user-guide/configuring#disabling-rules-with-inline-comments

looks good, can u merge it?

CI doesn't like the global variable, we need to disable it for these specific lines like @adrienthiery said.


Error: EPERM: operation not permitted, copyfile

I bumped the package from 6.1.1 to 9.0.1 and started getting this error when I re-run the tests. The initial run works fine but it tries to copy the files to the same directory with a .snap suffix for the consequent runs and throws this error below.
It seems to override the files and doesn't have the permission to do so. Though, it shouldn't override them if the snapshots are the same, right?
  1) size-small-ltr:
     Error: EPERM: operation not permitted, copyfile '/e2e/packages/package/screenshots/src/components/avatar/Avatar.vrt.ts/size-small-ltr.png' -> '/e2e/packages/package/screenshots/src/components/avatar/Avatar.vrt.ts/size-small-ltr.snap.png'

It doesn't have any stack trace, only this error which makes it hard to debug. I run the tests on Docker locally.
A similar error was reported here.
Cypress: v13.6.2
Docker image: cypress/included:13.6.2
Webpack: v5.89.0
OS: macOS Sonoma 14.1.1

Can you give some detail on how you've organised things with config options and folder structures?
I've not seen or been able to recreate this error so far

We have a monorepo that holds web libraries hold Vue and React component libraries, and others such as libraries to run Cypress tests for Vue and React components.
vue-library/
react-library/
env-core/ // holds framework-agnosting Cypress config
env-react/
env-vue/

env-core
This is the base Cypress config that it holds
export default {
  // `devServer` is provided by the platform packages
  component: {
    video: false,
    specPattern: "**/*.vrt.{jsx,tsx,ts,js}",
    // This folder is different from the snapshot plugins folder because it's recreated from scratch on every test run
    screenshotsFolder: ".ui/screenshots/.tmp",
    fixturesFolder: ".ui-env/dist/vrt/fixtures",
    supportFile: ".ui-env/dist/vrt/support/component.js",
    indexHtmlFile: ".ui-env/dist/vrt/support/component-index.html",
    setupNodeEvents: (
      on: Cypress.PluginEvents,
      config: Cypress.PluginConfigOptions
    ) => {
      addMatchImageSnapshotPlugin(on);
      cypressSplit(on, config);
      return config;
    },
  },
};

env-vue and env-react
These have framework dependencies and they get the base config from env-core
import { defineConfig } from "cypress";
import cypressConfig from<EMAIL_ADDRESS>import webpackConfig from "./webpack.config";

export default defineConfig({
  component: {
    devServer: {
      framework: "react",
      bundler: "webpack",
      webpackConfig,
    },
    ...cypressConfig.component,
  },
});

And this is the docker command that I run
docker run -i --rm -v /Users/user/workspace/monorepo:/e2e -v /Users/user/workspace/monorepo/packages/env-core:/e2e/packages/vue-library/.ui-env -w /e2e --ipc=host --shm-size=2g --entrypoint=cypress cypress/included:13.6.2 run --component --project /e2e/packages/vue-library --config-file /e2e/packages/vue-library/.ui-env/dist/vrt/cypress.config.js --spec packages/vue-library/dist/components/action-bar,packages/vue-library/src/components/action-bar

I encountered the same problem, the error is coming from this line:
  if (updated) {
    log('snapshot updated with new version')
  }

  await fs.copyFile(snapshotNameFullPath, snapshotDotPath)   < ---- error coming from here

  // don't remove if the paths are the same, this can happen
  // if the user passes empty string for snapFilenameExtension

I think the root cause of this problem is a wrong permission somewhere in the docker container. I'm using gitlab-ci-local to test my pipeline locally, which has a job for visual testing using this plugin.
It works fine if I run it on my machine from terminal, without gitlab-ci-local, I did not try yet on GitLab itself.
My question is, is there any reason why this code is there? I can see that we are creating a copy of the snapshot, then after processing the current screenshot, we update the original snapshot with the copy we created.
  const isExist = await pathExists(snapshotDotPath)
  if (isExist) {
    await fs.copyFile(snapshotDotPath, snapshotNameFullPath)
  }

/* .... processing screenshot .... */

  if (updated) {
    log('snapshot updated with new version')
  }

  await fs.copyFile(snapshotNameFullPath, snapshotDotPath)   < ---- error coming from here

  // don't remove if the paths are the same, this can happen
  // if the user passes empty string for snapFilenameExtension

Is something modifying the original snapshot in the process?


Gestalt Bug - even after level up - classes stay / go back to level 1 - Character levels drop to 0 after loading

As stated:
Select Muliclassing and classes for a char --> Respec said char level 8 -> Get the level up screen -> level up back 8 times-> check the char screen and find out:

All classes level 1
Bab level 1
All selected feats during the leveling up are gone
*Check toybox to find out that indeed all classes are level 1
*The character level appears on toybox as either 0 or 8  (always 0 after loading a save for companions I multiclassed weeks ago)

edit: I also was using 2* feature

Are you very sure you don't have the class you chose after respec still set as a gestalt class in the class overview (not the gestalt config). I saw the same when beginning with main class A and gestalt B, then changed gestalt config and respeced to main B and gestalt C. If you do that you still need to manually remove the gestalt checkmark from class B in the classes overview.

Thanks, this worked but was hard to find/unclear. Its not on the level up page, its on the party page under the character. Its not under the multiclass on that page, its further down beneath 'mythic level' option. There is a check box with gestalt next to your classes. The one for the 'main' class needs to be unchecked.

The respec button should probably clear gestalt flags from classes. They'd be set again anyway if you have them in your gestalt config.


[BUG] Add-PnPPage throws MissingMethodException

I found this issue using the PnP.PowerShell module.
Initially, when I tried to invoke a site template using Invoke-PnPSiteTemplate, I got an MissingMethodException over and over again - no matter what I tried. I've been trying multiple scenario's, configurations and parameters.
Then, I discovered that running Add-PnPPage resulted in the same exact error, even in a very basic form:
Add-PnPPage -Name "My Page"

This is the error I get:
Add-PnPPage : Method not found: System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1<Boolean> Enumerator.MoveNextAsync().
At line:1 char:1
+ Add-PnPPage -Name "My Page"
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : WriteError: (:) [Add-PnPPage], MissingMethodException
    + FullyQualifiedErrorId : EXCEPTION,PnP.PowerShell.Commands.Pages.AddPage

I suspect that something in the paging engine is broken.
Any clues? I'm running the latest stable build, 1.5.0
Thanks in advance and keep up the good work!
matsn0w

@matsn0w - Can you update please? I don't have this issue with 1.5.52-nightly.


refactor tokengen and txgen to avoid go mod import

This PR does the following:

It removes txgen ad command line tool
It moves the bulk of the txgen's code under integration/nwo
It moves the tokengen's cobra commands under cmd/tokegen
It simplifies go mod dependencies

The approach is at least consistent with tokengen; the cmd directory is the entrypoint for code that is in the integration folder. There is some inconstency with certifier-keygen and pp though (and tokengen version - which all have some part in token/core). It's also not that pretty that all the commands depend on the integration package: for instance tokengen is also used for production... but then it imports integration because it also does artifactgen which is 100% for testing. I guess that was the reason @alexandrosfilios had the txgen cmd in the integration folder; to make the difference clear.
Could there be a more clear or consistent approach? If we are ok with having commands purely for testing in the cmd folder (which is fine with me), shouldn't we then have all the cobra stuff inside cmd folder? In the spirit of clean architecture and separation of concerns, splitting the presentation layer from the logic. Although if there's code that's only used by the cli tools, we might as well put that in the cmd folder too... What do you think?

@arner , good point. Let me try to refactor the code accordingly. If a tool is used only for testing, we can have it positioned under integration/nwo/cmd. What do you think?

@arner , all comments addressed. Thanks :)


MPI_ERR_NO_SUCH_FILE because different physical nodes do not have a shared file system

Transferred from a Slack conversation.
People involved: @DanielBThomas, @chervias.

Dan Thomas
8:03 PM
Hi both
Kolen as I mentioned, Carlos has encountered some issues on Blackett that we are hoping you can help with.
This is his latest message:
Do you know in Blackett if I launch with 2 MPI jobs (machine_count = 2) the /tmp dir is the same one seen in both jobs?
I cannot successfully run the toast tests python -c 'import toast.tests; toast.tests.run()' with MPI as described here https://souk-data-centre.readthedocs.io/en/latest/user/pipeline/3-MPI-applications/1-OpenMPI/
I get a IO error, I suspect a file cannot be accessed since at least one of the MPI jobs cannot see a directory. But the toast tests work fine in a single job.
Carlos Hervías
8:06 PM
this is the output from running the mpi.ini example as exactly described in the instructions. You can see the code failing at the end
This file was deleted.
8:07
Plain Text
mpi-0.out.txt
Plain Text
8:09
I get this MPI_ERR_NO_SUCH_FILE: no such file or directory which I suspect because its trying to write a file to a directory that is not there (edited)
8:13
this runs successfully in a single job, only fails for me when I try parallel
Kolen Cheung
6:28 PM
Hi, Carlos. Sorry for the late reply, comments below:

different HTCondor processes sees a different /tmp directory, even when they lands on the same physical nodes (/tmp is actually a symlink to somewhere within scratch there, and scratch is unique to HTCondor processes.) I will add this to our documentation.
regarding your MPI_ERR_NO_SUCH_FILE situation, I am able to reproduce your error and will investigate into it. (This error is stateful as I haven’t seen it last I set it up.) For the interim, you can run MPI applications with 1 node. It can be done either by changing machine_count to 1 in https://simonsobs-uk.github.io/data-centre/user/pipeline/1-classad/3-classad-parallel/, or by adapting the Vanilla Universe job to call mpirun directly without calling my wrapper script. I’ll document this later method in the documentation.

Carlos Hervías
2:16 AM
Thank you Kolen, so if I set machine_count=1 would that be a single MPI job?
Carlos Hervías
2:22 AM
So the only way I can take full advantage of many processors is by running a single MPI job with 64 threads or something?
Kolen Cheung
11:26 AM
Machine count is the number of nodes. I think the largest node we have right now has 20 threads, which equals to 10 cores. Once you request machine count equals to 1 and number of cpu equals to 20, in that job you can use mpirun/mpiexec -n 10 …
11:28
Correction: 10 physical cores per CPU, but it has 2 sockets. So you can request 40 cpu and set -n 20 in MPI.
Dan Thomas
11:33 AM
we have 8 64 thread machines; I think 4 can run vanilla universe and they can all run parallel universe.
Kolen Cheung
11:41 AM
If you set machine_count=1 and request parallel universe, it should works. Remember the request_cpu corresponds to number of logical cores, so requesting 64 of them corresponds to -n 32.
Carlos Hervías
1:17 PM
ok thanks, I did some tests in the vanilla universe where I requested 32 cpus and then ran toast with mpiexec -n 8 … for example (I’m running each job with 4 threads). What is the maximum cpus I can ask for right now? I could not ask more than 32 in my tests, the job would go into the idle queue. So if I wanted to run 32 mpi jobs with 2 threads each for example, I could do it requesting 64 cpus?
Kolen Cheung
1:29 PM
You may need to change it to the parallel universe in order to use the 64 threads machine. I think you mean an MPI job with 32 processes? When you say 2 threads each, do you mean OMP_NUM_THREADS? Bear in mind if you requests 64 cpus, that corresponds to 32 physical core, so the recommended setting would be 32 MPI processes with OMP_NUM_THREADS=1 (which is set automatically if you use my wrapper script for parallel universe.)
1:31
Ie N_MPI_PROCESSES times OMP_NUM_THREADS should equals to total no of physical cores. Otherwise there will be oversubscription and you will find it slower (in most cases except those that are IO bound.)
Carlos Hervías
1:31 PM
ah ok I get it, thanks! I thought the hyperthreading was on, but it is best not to use it
Kolen Cheung
1:40 PM
Yes, hyperthreading is enabled, but only in specialized cases that would be beneficial, so the recommendation is not to setup your OMP threading like that unless it is proven to be useful.
Kolen Cheung
10:01 PM
Hi,
@Carlos Hervías
, just to go back to your previous issue about the MPI error. You can safely ignore that. The TOAST 3 test assumes that different MPI processes can see the filesystem at the same path, which is not true in Blackett. I.e. the master processes created a directory at a certain path, and one of the other processes are writing to that directory. It also means that any script making that assumption would break, but that should be ok most of the time, as MPI processes shouldn’t rely on the filesystem to communicate anyway (hence a script trying to have one process write to a file and have another process to read it is slim). For scripts that assumes this, it should be a quick and easy fix.

To reiterate, this results from an assumption that different MPI processes can access the same filesystem at the same path, which is not true at Blackett. Any script / test needs to be modified to remove this assumption, which is typically not needed in MPI applications.


Discovery: Version history feature

Goal of Ticket
Describe the task
We need to learn how users and the business area would prefer to set up version history and editing. Requires communicating with devs as to the feasibility and looking into existing solutions for this.
Ticket #176 may closely inform the progress of this ticket as well. This may be informed by work being done in the supplementary reports discovery
Acceptance Criteria

[x] book a session with devs to understand how we can approach version history, and examples of it in past apps, understanding how we want to go about supplementary/corrective reports (touches upon the work being done in #176)
[x] design a workflow(s) to come up with some solutions for MVP
[x] Make wireframes
[x] share with team and business area for feedback
[x] ensure BA is in alignment about those decisions
[ ] refine wireframes + workflow

Additional context
Add any other context about the task here.
Definition of Ready:
Note: If any of the points are not applicable: delete or mark N/A

[ ] Topic is clearly Defined.
[ ] Task Description is Clear.
[ ] People to speak to are identified (if applicable).
[ ] Acceptance Criteria is Clear.
[ ] Ticket Title is Clear.
[ ] Ticket is reasonably Split up/sized.
[ ] Value/Pain is Clear.
[ ] Relevant Team Members are assigned.
[ ] Ticket Estimated.

Definition of Done.
Note: If any of the points are not applicable: delete or mark N/A

[ ] Rough User Stories Proposed.
[ ] Follow-up Tickets created (if necessary).
[ ] Findings are documented (if necessary).
[ ] Reference docs/spreadsheets identified and indexed.
[ ] Value Proposition Canvas (if required)

Related to https://github.com/orgs/bcgov/projects/123/views/1?filterQuery=-status%3Adone+report&pane=issue&itemId=57276041 , we'll keep you up to date on that discussion as it happens @suhafa

During Giraffe Collab on May 1, wireframes were reviewed.
Next steps:

confirm with John about how to approach the language for Corrected vs Supplementary reports
Meet with Mike to talk about statuses and feasibility of the design

Completed with those discussions happening captured in #176


[AKS] update aks vendored sdk to 9.0.1

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.
updates vendored SDK to 9.0.1 to pickup a bug fix in 202003 API specs

add to S168


Is Snappy algorithm available with Blosc?

Hello there,
I was just wondering if Snappy algorithm was available again with Blosc compressor?
From what I've read, it was temporarily unavailable because of c-blosc upgrade in version 0.9.0.
But it's currently written in last version (numcodecs 0.12.1) docs of Blosc that cname parameter is:

A string naming one of the compression algorithms available within blosc, e.g., ‘zstd’, ‘blosclz’, ‘lz4’, ‘lz4hc’, ‘zlib’ or ‘snappy’

Also, it seems like Snappy is made available with last versions of c-blosc.
Despite all this, I can't find Snappy algorithm in the list provided by
numcodecs.blosc.list_compressors()

['blosclz', 'lz4', 'lz4hc', 'zlib', 'zstd']

Is there a problem with my installation or is Snappy not available? If so, when will it be available again?

Value of numcodecs.__version__ : '0.12.1'
Version of Python interpreter:  Python 3.9.16
Operating system (Linux/Windows/Mac): Linux
How NumCodecs was installed : using pip into virtual environment

Thanks in advance for your answer!

snappy is not currently included in https://github.com/Blosc/c-blosc/tree/main/internal-complibs which is where numcodecs would normally obtain the compression libs from.

Ok, thanks for your reply!


Edit version badge link

The Readme states that the MSRV is 1.41.1 but this badge linked to 1.44.1 instead. Was that just a mixup?

Codecov Report

Merging #389 (89a6318) into trunk (922d193) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk     #389   +/-   ##
=======================================
  Coverage   67.10%   67.10%
=======================================
  Files          10       10
  Lines         766      766
=======================================
  Hits          514      514
  Misses        252      252

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922d193...89a6318. Read the comment docs.

Codecov Report

Merging #389 (ee7dbaa) into trunk (a876934) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk     #389   +/-   ##
=======================================
  Coverage   67.10%   67.10%
=======================================
  Files          10       10
  Lines         766      766
=======================================
  Hits          514      514
  Misses        252      252

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a876934...ee7dbaa. Read the comment docs.


Not Working with IOS Simulator and iPhone

Hi,
Thanks for developing a very useful plugin. It working fine with ionic server and even its working properly in my android but not working with ios.
I am too much confused how to solve this issues.
In ios date picker model is appear but when i am clicking on Ok button date time value didnt fill in my input.
Kindly help me and thanks in advance.
Here is my code
<input type="text" placeholder="e.g 25-12-2016 14:00" ion-datetime-picker id="interview_date_time" name="interview_date_time" ng-model="datetimeValue" readonly="readonly"  value="{{datetimeValue| date: 'yyyy-MM-dd H:mm'}}" required="required"  />

Hi Tejas,
this is not how it is supposed to be done. Use non-input element and style it instead. Furthermore, you are using interpolation in value attr, but its behaviour is undefined in angular.

Then how its working in Android ?

Undefined behaviour means Sometimes works, sometimes not. Please use a proper angular way.

Thanks, Its working fine in my all device.
Thanks for your great support, I really appreciate your precious time for developing such a great plugin.

Thanks, I'm glad you made it working 👍


Hyper-parameter for VPT

Thanks a lot for the great work! I am having trouble re-producing the results for VPT [46], so I wonder whether it's possible to share your hyper-parameters for training VPT that are reported in Table 5 under the supervised pre-training?

Kind regards,
Haoyu

Hi, Thanks for your interest.
We use strictly the same training recipe for all fine-tuning methods. The training code for the video is released.  For image, please refer to https://github.com/ShoufaChen/AdaptFormer/issues/2.
Would you mind sharing your reproducing performance? higher or lower than ours?

Hi Shuofa,
Thanks for your prompt reply :)! Can you be more specific? E.g., Are you using 1 prompt for CIFAR-100, SVHN, and Food-101? Is the final lr for 1024 batch-size 0.4 according to this line? Are the prompts initialized with Xavier uniform initialization?
Many thanks,
Haoyu

(1) Yes, the number of prompt is 1 for image datasets;  (2) The real LR is 0.4 according to the linear scaling rue. However, We found it is not stable in cases, especially for Swin Transformer. As mentioned in https://github.com/ShoufaChen/AdaptFormer/issues/2, we found smaller lr can bring further gains for all fine-tuning methods. (3). Prompts are initialized by
for eee in self.embeddings:
    torch.nn.init.xavier_uniform_(eee.data)

for both video and image.
It would be appreciated if you could share your performance.

Many thanks!
Currently, I can only achieve 90.4% on CIFAR100 while this paper achieves 91.1% top-1 accuracy. I will let you know how it goes with your provided specifications! I will close this issue for now :)
Kind regards,
Haoyu


OAuth 2.0

Update OAuth implementation to 2.0 by using oauth2-extensions. The author has also created a walkthrough.
This may also be useful for #72 but an additional adapter may be required.

After playing around a bit with this I'm not sure if this will be ideal in all cases. It seems using this with Google URL Shortener will then mean access tokens can expire after a minute and will need to be refreshed. I'll have a look at how the refresh flow works and see if it's viable. Otherwise, I'll only be implementing this partially to support bitly, if it works for that.
Also, it appears not to callback if the OAuth fails or the flow is broken (e.g. user cancels/closes tab), meaning the login button doesn't revert back to its enabled. This was the same for the current implementation but was easily tweaked so I'll need to see if the same can be done for this.
Finally, there seems to be a problem with setting up bitly applications right now so I won't really be able to test this properly yet.

To refresh tokens I just need to call authorize. However, since this function could also open the popup I need to check that we already have the accessToken and a refreshToken and call it just before the endpoint.
To make using this framework easier I'm probably going to fork it and make the following changes;

Add a bitly adapter
Add a new hasAccessToken function (!!getAccessToken)
Change how values are stored in localStorage (e.g. adapterName_variableName_apiScope)
Reduce how many values are stored in localStorage (i.e. config values can be stored as private variables)
Add a new refreshIfRequired function to shortcut desired functionality

This is pretty much done and I'm about to create a pull request with my changes.
Regardless, I'll be using my bespoke version of this framework and committing the changes soon.


feat: add namespaces to annotation template

#2549

Extends current Annotation XML template
Enhances @sap-ux/adp-tooling to fetch $metadata for a given Data Source
Extends @sap-ux/adp-tooling writing logic to render the new template
Consumes the new functionality on sap-ux add annotations CLI implementation
Extends the sap-ux add annotations to be based on the merged descriptor and not the base descriptor

@Jimmy-Joseph19 as we discussed, the change of the subfolder containing manifest changes from /manifest to /changes will be done as part of a new PR for all generators.


4.x: Handler for converting body to Entity (EntityHander)

Environment Details

Helidon Version: 4.0.7
Helidon SE
JDK version: 21.0.2
OS: Windows
Docker version (if applicable):

Problem Description
In previous versions, the POST and PUT methods, etc., used an entityHandler when receiving a body.

~ 3.X

    @FunctionalInterface
    interface EntityHandler<T> {

        /**
         * Functional method handles {@link ServerRequest request}, {@link ServerResponse response} and HTTP request content
         * entity.
         *
         * @param req    an HTTP request
         * @param res    an HTTP response
         * @param entity an entity representing the HTTP request content
         */
        void accept(ServerRequest req, ServerResponse res, T entity);

    }

    @Override
    public void update(Routing.Rules rules) {
        rules.post("/pokemon", Handler.create(Pokemon.class, this::insertPokemon));
    }

    private void insertPokemon(ServerRequest request, ServerResponse response, Pokemon pokemon) {
        dbClient.execute(exec -> exec
                .createNamedInsert("insert-pokemon")
                .indexedParam(pokemon)
                .execute())
                .forSingle(count -> response.send("Inserted: " + count + " values\n"))
                .exceptionally(throwable -> sendError(throwable, response));
    }

This was a great way to reduce the amount of code without the need to read content on the method side.
In Series 4, the only test provided is to retrieve from content as shown below, but is there any expectation to create a handler to hook it as before? Also, I would like to know if there is an alternative implementation method.

4.x ~

    private void postBook(ServerRequest request, ServerResponse response) {
        switch (jsonLibrary) {
            case JSONP:
                JsonObject jo = request.content().as(JsonObject.class);
                addBook(BookMapper.decodeJsonp(jo), response);
                break;
            case JSONB:
            case JACKSON:
                Book book = request.content().as(Book.class);
                addBook(book, response);
                break;
            default:
                throw new RuntimeException("Unknown JSON library " + jsonLibrary);
        }
    }

The following process is performed in the PokemonService of example.
    @Override
    public void routing(HttpRules rules) {
        rules.get("/", this::index)
                // List all types
                .get("/type", this::listTypes)
                // List all Pokémon
                .get("/pokemon", this::listPokemons)
                // Get Pokémon by name
                .get("/pokemon/name/{name}", this::getPokemonByName)
                // Get Pokémon by ID
                .get("/pokemon/{id}", this::getPokemonById)
                // Create new Pokémon
                .post("/pokemon", Handler.create(Pokemon.class, this::insertPokemon))
                // Update name of existing Pokémon
                .put("/pokemon", Handler.create(Pokemon.class, this::updatePokemon))
                // Delete Pokémon by ID including type relation
                .delete("/pokemon/{id}", this::deletePokemonById);
    }

    /**
     * Insert new Pokémon with specified name.
     *
     * @param pokemon  request entity
     * @param response the server response
     */
    private void insertPokemon(Pokemon pokemon, ServerResponse response) {
        long count = dbClient.execute().createNamedInsert("insert-pokemon")
                .indexedParam(pokemon)
                .execute();
        response.status(Status.CREATED_201)
                .send("Inserted: " + count + " values\n");
    }

In addition to this implementation, it would be ideal to be able to handle ServerRequests within the insertPokemon handler.

The closest thing is:
static <T> Handler create(Class<T> type, BiConsumer<T, ServerResponse> handler) {
    return (req, res) -> {
        handler.accept(req.content().as(type), res);
    };
}

E.g.
.put("/pokemon", Handler.create(Pokemon.class, this::updatePokemon))

However ServerRequest is not available when using this method.

You can re-implement EntityHandler like this:
@FunctionalInterface
interface EntityHandler<T> {

    void handle(T entity, ServerRequest request, ServerResponse response);

    static <T> Handler create(Class<T> type, EntityHandler<T> handler) {
        return ((req, res) -> handler.handle(req.content().as(type), req, res));
    }
}

static final class MyService implements HttpService {

    @Override
    public void routing(HttpRules rules) {
        rules.post(EntityHandler.create(String.class, this::handle));
    }

    private void handle(String entity, ServerRequest req, ServerResponse res) {
        res.send("received: " + entity);
    }
}


Allow plugging in different server clients into V1_Engine

Summary
This PR starts the process of abstracting the server client implementation used by V1_Engine so that a different server client can be used for the VS Code extension. It does the following:

Renames V1_EngineServerClient to V1_RemoteEngineServerClient, which will be the default server client used for interacting with an engine server.
Creates a new V1_EngineServerClient interface which defines all the properties and functions that an engine server client needs to implement.
Adds a new graphManager param to the GraphManagerState constructor so that we can plug in our own custom graph manager implementation to the GraphManagerState.
Adds a new, optional serverClient param to the V1_PureGraphManager constructor so that we can plug in our own custom implementation of the new V1_EngineServerClient interface when creating a new V1_PureGraphManager. If no serverClient is provided, then we create a new V1_RemoteEngineServerClient and pass it to the V1_Engine that is created.
Adds a new, optional serverClient param to the V1_PureGraphManager initialize function so that we can plug in our own custom implementation of the new V1_EngineServerClient interface when creating a new V1_PureGraphManager. If no serverClient is provided, then we create a new V1_RemoteEngineServerClient and pass it to the V1_Engine that is created.
Updates the V1_Engine constructor so that it requires a serverClient param of type V1_EngineServerClient.
Updates the buildPureGraphManager helper function to take an optional serverClient param so that we can plug in our own custom implementation of the new V1_EngineServerClient interface when building a V1_PureGraphManager.

So, the new flow for creating a new GraphManagerState with a custom server client would be:

Create a new server client instance (instance of a class that implements V1_EngineServerClient).
Create a new AbstractPureGraphManager instance by calling buildPureGraphManager and pass in your class from step 1.

V1_PureGraphManager creates a new instance of V1_Engine and passes in the server client received from step 2. If no serverClient param is passed, it creates a new instance of V1_RemoteEngineServerClient.
V1_Engine uses the server client from above as its engineServerClient prop.

Call new GraphManagerState and pass in the AbstractPureGraphManager instance created in step 2.

How did you test this change?

[ ] Test(s) added
[x] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

Manually started up studio to ensure that a project loads, query builder loads, and a query can successfully execute:

I think your general approach is promising, I just think it'd better be done at a different layer: the engine.
The general structure is:
PureGraphManager
  |__ Engine
         |__ EngineServerClient <----- you're abstracting this

Now, the problem with abstracting the client is, semantically, not generic enough. Someone who create an implementation for this is forced to think, "I'm adding a new client implementation, so the thing I'm building is an API client" while in fact, what they need to implement is the engine that does something (think about AbstractPureGraphManager). Rather than thinking "Let's create a client where when call the method parseQuery", they should think let's create an engine that "can parse a query".
I know the nuance is not that apparent, but let's try. You can see work has been done before to foresee this type of change, refer to V1_EngineConfig extends TEMPORARY__AbstractEngineConfig.

I thought about abstracting Engine instead, but I felt like there would be a lot of duplicate code if I did that. If all we're changing is the client that the engine communicates with (going from a legend-engine server to a VS Code LSP server), then wouldn't we be duplicating a lot of code to create a whole new Engine implementation that talks to VS Code LSP server? Wouldn't it be simpler to just make a new client that the existing Engine implementation uses for its engine requests?

Abstraction at the client level makes little sense, I think there's no harm in duplicating code here but let's abstract Engine instead.

Abstraction at the client level makes little sense, I think there's no harm in duplicating code here but let's abstract Engine instead.

Sounds good! Will work on those changes.

Closing in favor of https://github.com/finos/legend-studio/pull/3553


docs-fr: make the Ingress TLS example match EN version (example URL mainly)

This PR is a minor update to the Ingress documentation in French: the page is talking about TLS everywhere, but the example DNS record used remains sslexample.foo.com. This PR simply changes it to tlsexample.foo.com for more consistency. Noticed it thanks to @franck-cussac !
As suggested in https://kubernetes.io/docs/contribute/new-content/overview/#choose-which-git-branch-to-use I tried to find a branch dedicated to the updates of the FR translation but didn't find any, so I'm filing this against master. Let me know if I should do something else!

I've signed the CLA now dear bot :slightly_smiling_face:

I've signed the CLA now dear bot :slightly_smiling_face:

Glad to see you review this PR @rekcah78 :slightly_smiling_face:
I added modifications according to your suggestions, and also added a small bit of text to better match the EN version - and renamed the PR accordingly.
Let me know if there is any other change you want me to do, if I need to squash my commits, etc. !

Glad to see you review this PR @rekcah78 :slightly_smiling_face:
I added modifications according to your suggestions, and also added a small bit of text to better match the EN version - and renamed the PR accordingly.
Let me know if there is any other change you want me to do, if I need to squash my commits, etc. !

je voulais dire de remplacer tout le code du yaml par {{< codenew file="service/networking/tls-example-ingress.yaml" >}}
cela permet de toujours pointer sur l'exemple de référence.

Got it! Didn't know that there was such template blocks in the site gen, pretty cool :slightly_smiling_face:
Fixed it

je voulais dire de remplacer tout le code du yaml par {{< codenew file="service/networking/tls-example-ingress.yaml" >}}
cela permet de toujours pointer sur l'exemple de référence.

Got it! Didn't know that there was such template blocks in the site gen, pretty cool :slightly_smiling_face:
Fixed it

Looks like the CI is failing because it's searching for the YAML file under the FR translation directory. What's the usual solution to this? I have a bunch in mind but I guess that it's something common here :slightly_smiling_face:

Looks like the CI is failing because it's searching for the YAML file under the FR translation directory. What's the usual solution to this? I have a bunch in mind but I guess that it's something common here :slightly_smiling_face:

Looks like the CI is failing because it's searching for the YAML file under the FR translation directory. What's the usual solution to this? I have a bunch in mind but I guess that it's something common here 🙂

You right, you need to copy the file in contents/fr/examples/ directory
plus d'info ici

Looks like the CI is failing because it's searching for the YAML file under the FR translation directory. What's the usual solution to this? I have a bunch in mind but I guess that it's something common here 🙂

You right, you need to copy the file in contents/fr/examples/ directory
plus d'info ici

@rekcah78 well, I find it a bit weird to duplicate the file if the primary objective is to keep content coherent across all languages. Wouldn't it be better to reference the EN file in some way to avoid having to periodically "sync" the EN example file into the FR examples?
Anyway, updated the PR according to your suggestion :slightly_smiling_face:

@rekcah78 well, I find it a bit weird to duplicate the file if the primary objective is to keep content coherent across all languages. Wouldn't it be better to reference the EN file in some way to avoid having to periodically "sync" the EN example file into the FR examples?
Anyway, updated the PR according to your suggestion :slightly_smiling_face:

/lgtm

/lgtm

What's the next step when it's marked as LGTM by a code owner? :slightly_smiling_face:
It looks like I can't merge it myself. Let me know if I have anything to do here!

What's the next step when it's marked as LGTM by a code owner? :slightly_smiling_face:
It looks like I can't merge it myself. Let me know if I have anything to do here!

/lgtm
/approve

/lgtm
/approve

@remyleone any insights on the point/question I raised earlier in the comments? This one:

@rekcah78 well, I find it a bit weird to duplicate the file if the primary objective is to keep content coherent across all languages. Wouldn't it be better to reference the EN file in some way to avoid having to periodically "sync" the EN example file into the FR examples?

@remyleone any insights on the point/question I raised earlier in the comments? This one:

@rekcah78 well, I find it a bit weird to duplicate the file if the primary objective is to keep content coherent across all languages. Wouldn't it be better to reference the EN file in some way to avoid having to periodically "sync" the EN example file into the FR examples?

You could have code snippets with comments in French, Chinese or Korean for instance. As the code snippets grow, comments are getting more and more useful to understand what is going on.

You could have code snippets with comments in French, Chinese or Korean for instance. As the code snippets grow, comments are getting more and more useful to understand what is going on.


Network statistics are not preserved from reboot (ATZ)

Fixed.
Waring, now it means that at the first boot the stats are not relevant, which imply that an ATZ command should be run to clear the stats.
Note that :

An ATZ command will clear the stats
An ATZ1 will keep the stats


Better error when can't open config file

Also log when opening config file.
Before:
[marca@marca-mac2 gandalf]$ go run webserver/main.go
2015/01/02 10:31:12 Could not find gandalf config file. Searched on /etc/gandalf.conf.
For an example conf check gandalf/etc/gandalf.conf file.\n open /etc/gandalf.conf: no such file or directory
panic: Could not find gandalf config file. Searched on /etc/gandalf.conf.
For an example conf check gandalf/etc/gandalf.conf file.\n open /etc/gandalf.conf: no such file or directory

goroutine 1 [running]:
log.Panicf(0x50b9d0, 0x71, 0xc20807bf70, 0x2, 0x2)
        /usr/local/Cellar/go/1.4/libexec/src/log/log.go:314 +0xd0
main.main()
        /Users/marca/go/src/github.com/tsuru/gandalf/webserver/main.go:32 +0x3ab

goroutine 6 [chan receive]:
github.com/tsuru/tsuru/db/storage.retire(0xc20804e140)
        /Users/marca/go/src/github.com/tsuru/tsuru/db/storage/storage.go:111 +0x7f
created by github.com/tsuru/tsuru/db/storage.init·1
        /Users/marca/go/src/github.com/tsuru/tsuru/db/storage/storage.go:106 +0x61
exit status 2

After:
[marca@marca-mac2 gandalf]$ go run webserver/main.go
2015/01/02 10:31:29 Opening config file: /etc/gandalf.conf ...
2015/01/02 10:31:29 Could not open gandalf config file at /etc/gandalf.conf (open /etc/gandalf.conf: no such file or directory).
  For an example, see: gandalf/etc/gandalf.conf
exit status 1

Thank you!


selectedOption never get called

Hi,
I am trying your example however, I see that the selectedOption here never gets called so I don't get chance to check if user select something. Overtime, its showing "User cancelled".

@satyamub what device are you using? could be more descriptive?

I am testing this on Simulator.. is there an issue with simulator...

I just clone the repo, and did the whole process and it works,
I'm using xcode 7.3.
There's a video I just capture.

I am having this problem and can't seem to fix it.  I an't select any of them, it just says "user cancelled"

Oh I see, you have to long tap to get them to pop up, then release, then long tap to select one again.  Is it supposed to be like that?  I want to make it so that I can release the initial long-tap on one of them to select, or release and then single tap one to select it.

@aliasnoa  is that the way that facebook works, one tap = like, long tap open the Reactions, then you can scroll to select your reaction. Maybe in the next version I can put a selection in each reaction like a button.

but what I'm saying is, you have to long tap to bring up the reactions, then release and long tap again to pick one

@aliasnoa indeed, in this version works in that way.

I'm just saying if you could do it all in one long press instead of 2, it would be just like Facebook.  I'm trying to figure out how to do it but there's a lot of stuff I'm not familiar with

For sure I'll do it in the next version, but right now I don't have time. The thing is, that the control of the touchesBegan method, work in the first button but then I create another overlay to track the tap position, the control from the long tap is not transferred to the overlay. This will still open while I implement it.

Okay.  Well i'll let you know if I figure it out before then but I doubt I will..would be really cool though because it's so close right now to being perfect...it's very impressive.

I wonder if it would be possible to do the hold to pull them up, then select one on single click.  I'm going to try that...that wouldn't be too bad.

Go ahead my friend. Just let me know if you make some progress! 🤓

@lojals @aliasnoa What ever I do .. I can't select one...

Fixed this!


Error after running scripts longer then 50min with connect-ExchangeOnline

Hi,
I use Connect-ExchangeOnline to connect to Office 365 and extract some relevant logging, this process can take multiple hours. What happens (I think after 50min), the session expires and as result it cant find the cmdlets I am using for example the: Search-UnifiedAuditLog.
The term 'Search-UnifiedAuditLog' is not recognized as the name of a cmdlet
I never had this problem by using the basic authentication:
New-PSSession -ConfigurationName Microsoft.Exchange -ConnectionUri https://outlook.office365.com/powershell-liveid/ -Credential $UserCredential -Authentication Basic -AllowRedirection
Is it possible to use ExchangeOnline for long running scripts, if not is there any other connection method that uses modern authentication that you could recommend?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de2836a0-0af3-c147-2d4a-78220ac4e0f1
Version Independent ID: 2cde9735-6281-bb9f-bf07-b30b2f6c7f37
Content: Exchange Online PowerShell V2
Content Source: exchange/docs-conceptual/exchange-online/exchange-online-powershell-v2/exchange-online-powershell-v2.md
Service: exchange-online
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

Hi @jrentenaar, thank you for your feedback.
In this article you can find the following sentence:
"When you use the Exchange Online Remote PowerShell Module, your session will end after one hour, which can be problematic for long-running scripts or processes. To avoid this issue, use Trusted IPs to bypass MFA for connections from your intranet. Trusted IPs allow you to connect to Exchange Online PowerShell from your intranet using the old instructions at Connect to Exchange Online PowerShell. Also, if you have servers in a data center, be sure to add their public IP addresses to Trusted IPs as described here."
Besides, the Exchange Online PowerShell V2 module is currently in Preview. If you have any feedback, concerns, or are facing any issues with the EXO V2 module, contact us at exocmdletpreview[at]service[dot]microsoft[dot]com (email address intentionally obscured to help prevent spam).

@dariomws  Thank you very much for the contribution and sharing this explanation. @jrentenaar
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


can I directly control the torque of the joints?

Hi, may I know if there is a way to directly control the torque of the joints? In our dynamic model, the input is torque rather than position. Thus, we need to command torque to the joint. However, I didn't find such a way to do it. Looking forward to your response!

Hi,
Sorry, there is no way to control the torque of the joints.
If you want, you have to develop the software using Dynamixel SDK.

Github
E-manual

Regards,
Kayman

Maybe you can try using Dynamixel Workbench application to control each Dynamixel

Hi,
Sorry, there is no way to control the torque of the joints.
If you want, you have to develop the software using Dynamixel SDK.

Github
E-manual

Regards,
Kayman

thank you sooooo much!

Maybe you can try using Dynamixel Workbench application to control each Dynamixel

thank you, bro!


Does not make a distinction between pointer-nil and value-zero

if an object contains a pointer and is written to a queue (did only test it with priority queues) then reading the object from the queue can result in a different object when the dereferenced pointer has a zero value. In that case the pointer itself is nil instead of a pointer to a zero-value.
See the output of the following program:
package main
import (
"fmt"
"github.com/beeker1121/goque"
"log"
)
type Obj struct {
A *int
B int
}
func (o Obj) String() string {
if o.A != nil {
return fmt.Sprintf("%v %v %v", o.A, *o.A, o.B)
} else {
return fmt.Sprintf("%v %v", o.A, o.B)
}
}
func main() {
queue, err := goque.OpenPriorityQueue("queuetest", goque.ASC)
if err != nil {
log.Fatal("OpenPriorityQueue()", err)
}
o1 := Obj{new(int), 1}
*o1.A = 0 // not necessary
    // *o1.A = 10 // this will work
    // o1.A = nil // will work, too

log.Println("Writing to queue:", o1)

_, err = queue.EnqueueObject(0, o1)
if err != nil {
    log.Println("EnqueueObject()", o1, err)
}

item, err := queue.Dequeue()
if err != nil {
    log.Fatal("Dequeue()", err)
}
o2 := Obj{}
err = item.ToObject(&o2)
if err != nil {
    log.Fatal("ToObject()", err)
}

log.Println("Read from queue:", o2)

queue.Drop()

}

Just Googling on the gob package, I saw this post which looks like it might address this very thing: https://groups.google.com/forum/#!topic/golang-nuts/VnFs2Cv0_UY
Does this fix the issue?

Yes it looks like the gob package is the problem here. There are other problems with it, like fields that are structs that have only unexported fields. gob can't encode them either. I now use custom en-/decoder methods:
func (t *SomeType) MarshalBinary() ([]byte, error) {
buf, err := json.Marshal(t)
return buf, err
}
func (t *SomeType) UnmarshalBinary(data []byte) error {
err := json.Unmarshal(data, t)
return err
}

Nice fix, I might implement this as a feature update (JSON encoding of objects) if that's cool.

Added this in ef8bb7f


ProcessResult in InferenceTest.inl is bugged, produces range [0, 1000] or 1001 categories

The code that sorts the predictions from the inference has a bug. While testing 300 images from ILSVRC2012_val (the first 100 + all 50 of category 0 and all 50 of category 999) produce a range of predictions from 0 to 1000, which is 1001 categories, which is not possible.

Which test are you running? The TfLite and Tensorflow models are all trained with an extra zeroth class ("background") and therefore there are 1001 activations in the last softmax layer.

Oh, my mistake.
I'm using the MobileNet_v1_1.0_224 model from here...
https://github.com/tensorflow/models/blob/master/research/slim/nets/mobilenet_v1.md
...and did not realize the output layer is (?, 1001) because I had been working from the ILSVRC2012 validation set only, assuming 50,000 inferences from 1000 classes.
Closing... Thanks!


fix proxy pass parsing on some keys #393

Fix issues due to nginx proxy pass rewriting (https://serverfault.com/questions/459369/disabling-url-decoding-in-nginx-proxy)
For example if your key is a:b:{"url","https,//c.com"}
then redis-commander will call /key/<some-connectionId>/a%3Ab%3A%7B"url"%2C"https%2C%2F%2Fc.com"%7D
that will become /key/<some-connectionId>/a:b:{"url","https,/c.com"}  (with one slash) when received by redis-commander server.
See more on https://github.com/joeferner/redis-commander/issues/393

Thanks for the PR - i was thinking about something similar too...
Do you checked https://developer.mozilla.org/de/docs/Web/API/btoa ?
MDN mentions some browsers having problems with Unicode chars in btoa (and linked from this page https://developer.mozilla.org/en-US/docs/Glossary/Base64#solution_.232_.e2.80.93_rewriting_atob()_and_btoa()_using_typedarrays_and_utf-8) therefore the solution shall work too for all types of keys if possible.
It does not mention the browsers itself, tests with the most used ones is needed...
And I did not implement it until know because base64 adds additional length to the strings, maybe there is a solution without this additional costs i did not thought of by now...

Do you found some time to test different browsers with your patch? Do the code versiones mentioned at MDN work too?
This fix may (potentially) help on other cases too - having redis keys with binary data in it...

I've got access to browserstack if needed but for me, as you said before, i think it can create other problems (utf8 char, url to long). For me the best way, to do it is to give up on the strict Rest API and to use a POST /key/:connectionId/manipulate endpoint. Key will be on the body which eliminate all the problems once for all.
Ps: Do you get a purpose in keeping all apiv1 routes (they seem only used twice https://github.com/joeferner/redis-commander/search?q=apiv1) ?


info_locals() function for gdb gives incorrect result

(gdb) "side-by-side-2.py:19 if param_a == 5
No source file named side-by-side.py.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (side-by-side.py:17 if param_a==5) pending.
(gdb) r side-by-side-2.py --api=numba
(gdb) info locals

gdb.info_locals() in gdb.py returns the following values:
\rparam_a = 0\r\nparam_b = 0\r\nparam_c = 10\r\nparam_d = 0\r\nresult = 0
However the expected values are:
info_args() also gives incorrect result for numba-dpex.
param_a = 5
param_b = 5
param_c = 15
param_d = 2.5
result = 0

Same reason as here https://github.com/IntelPython/numba-dpex/issues/1232


Wrap Assign does not work if object has prototype.

Describe the bug
Wrap Assign does not work if object has a prototype.
Object Assign works perfectly, i think that this is a bug and it should perform the same as Object Assign.
To Reproduce
@Embeddable()
export class PersonName {
  @Property()
  first: string;

  @Property({ nullable: true })
  last: string;
}

@Entity()
export class Person {
  @PrimaryKey()
  id: number;

  @Embedded({ prefix: "name_" })
  name: PersonName;
}

const person = await ctx.em.findOne(Person, { id: 1 });

const data: any = {};
data.name = new PersonName();
data.name.first = "Test";
ctx.em.assign(person, data);
await ctx.em.persistAndFlush(person);

It performs:
update "person" set "name_first" = NULL where "id" = 1
Versions

Dependency
Version

node
v12.16.3

typescript
v4.0.5

mikro-orm
v4.3.0

i can confirm this.

Fix can be tested in latest dev version - 4.3.1-dev.9.