Unable to clone repository with submodule url<EMAIL_ADDRESS>

Bugs in the new version of go-git
Same as this problem description, it can be avoided by rolling back to version 3.4
https://github.com/go-git/go-git/issues/397

will wait go-git resolution go-git/go-git#397

fix: Relative submodules in git artifacts. Fixes #7141 (#7162)

I created a PR on go-github, lets wait and see. Hoping to get it merged ASAP since this bug breaks SSH cloning.
go-git/go-git#464

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

keep

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Keep

@Hunter-Thompson  Any update on this ?
Is there any workaround available

@Hunter-Thompson Any update on this ? Is there any workaround available

There is no work around, Id suggest going back to v3.2.4

@Hunter-Thompson Any update on this ? Is there any workaround available

There is no work around, Id suggest going back to v3.2.4

it can be avoided by rolling back to version 3.4

Rolling back to 3.2.4 causes the ssh issue for checkout of code from GitHub .
Issue :
You're using an RSA key with sha-1 , which is no longer allowed , please user a newer client or a different key type

When is this pr going to be released ? any tentative date ?
Thanks

Can the go-git version being used not be rolled back within argo? This is a really painful break.


add support for "*" in sql select

This commit adds super for "*" in select clauses as an empty ast.Assignment.  There isn't yet support for id.* style selections. We also reworked the selection naming convention to use the last name in a dotted path, which is what SQL does.
The SQL semantic logic was also reorged and renamed a bit to better position it for the comming work on scoping and binding.

Verified in super commit 9de86ad.
Before:
$ super -version
Version: v1.18.0-95-gac8b7e0f

$ super -c 'SELECT * FROM "customers.bsup" LIMIT 1'
super: parse error at line 1, column 15:
SELECT * FROM "customers.bsup" LIMIT 1
          === ^ ===

Now:
$ super -version
Version: v1.18.0-99-g9de86ad2

$ super -c 'SELECT * FROM "customers.bsup" LIMIT 1'
{CustomerID:1(int32),CustomerName:"Alfreds Futterkiste",ContactName:"Maria Anders",Address:"Obere Str. 57",City:"Berlin",PostalCode:"12209",Country:"Germany"}

Thanks @mccanne!


Generalize CLIPArchitecture

Summary:
Generalize CLIPArchitecture to handle MUGEN's audio/text/video CLIP by allowing a variable number of encoders, and added a corresponding test suite.
Test plan:
Run command pytest --cov=torchmultimodal/architectures/ test/architectures/test_clip.py::TestCLIPArchitecture -vv to run the unit tests included in this PR.

@langong347 I do see @ankitade's point here. At the very least this is no longer really CLIPArchitecture since the LI in CLIP stand for language and image 🙂. A separate question is whether we want to keep CLIPArchitecture because it is a foundational model. Seems like the two options would be to either
(1) keep CLIPArchitecture as is and implement a separate generalized architecture to be used by MUGEN, or
(2) rename this to e.g. ContrastiveArchitecture and let both CLIP and MUGEN use it.
To me, the argument for (1) is that CLIP is a very important model and should be a first-class citizen with its own architecture. While the argument for (2) is better generality (I think we have said we should not have an architecture unless it is used by multiple models anyways). Personally, I would lean slightly towards (2) but would like to hear others' thoughts as well.

@ebsmothers I'm leaning towards option 1. CLIPArchitecture is just a convenient wrapper around encoder -> projection -> l2 norm -> output (on a separate note, where is the projection layer?). Since it has been used many times in different papers, I think that warrants it's own architecture even though it would be an image-text instance of a general ContrastiveArchitecture (much like Video VQVAE gets its own file even though it's an instance of VQVAE).
As for MUGEN, the linear projection layer after the encoder is slightly different than the CLIP paper (which only uses one linear layer I believe?): https://github.com/mugen-org/MUGEN_baseline/blob/02c7058cd221f4b651d4ace2276b085cac1c5efd/lib/models/videoclip/modules.py#L15. So that leads me to believe MUGEN should have its own ContrastiveArchitecture.
As for supporting more than two encoders, I'm not convinced of the benefit for that over multiple CLIPs, other than convenience for getting all three embeddings at once for training or inference. That seems MUGEN specific, warranting the separate contrastive architecture for MUGEN anyway.

Codecov Report

Merging #89 (7e18d8b) into main (3beffd9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   88.96%   89.00%   +0.03%
==========================================
  Files          33       33
  Lines        1722     1728       +6
==========================================
+ Hits         1532     1538       +6
  Misses        190      190

Impacted Files
Coverage Δ

torchmultimodal/architectures/clip.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3beffd9...7e18d8b. Read the comment docs.

In the final state, we should just have models/clip.py with the CLIPModel (some version of current CLIPArch) + different standard instantiations clip_vit16 etc (we already have this i think)

For video clip (standard one, not mugen specific, if they dont line up), there can be models/video_clip.py if we want to add it and it does something different like Rafi's point about projections being different

If we start making clip take in a dict of modalities, its confusing for people for whom contrastive loss with batch negatives work for 2 dimensions (aka modalities for us).  Actually I don't understand how the loss and 0 shot will eventually work for more than 2 entries in the dict

where is the projection layer?

Both the original CLIPArchitecture and this generalized CLIPArchitecture avoided explicitly including the projection layer(s) because users may want different types of projections and projection logic can be folded into the encoder that's passed in. We also can't guarantee that any projections passed in as arguments by the user have the same output size, so I don't see an advantage to including a projection argument. (Though this choice does assume that we want one general clip architecture and not two versions)

For video clip (standard one, not mugen specific, if they dont line up), there can be models/video_clip.py if we want to add it and it does something different like Rafi's point about projections being different

The projection can be absorbed into the encoders (see Sophia's post), we can reuse the same CLIPArchitecture for arbitrary pair of modalities --- that's how CLIP has been extended for other research.

Agree with both @langong347 and @sophiazhi's points about keeping the projection layer out of the architecture. Even in CLIP the projection layer is not guaranteed to be present (I think they have one in the ViT version but not the ResNet one). A corollary to this would be that MUGEN does not need its own architecture just because it has a different projection layer.
I wouldn't recommend returning the similarity as part of the architecture though. Then we are starting to integrate our loss into the architecture, which we don't want in general. This had to be done for ALBEF because of how the similarities get used in the multimodal encoder, but this is also part of the reason that class was implemented as a model and not an architecture (since it then becomes much more specific to that particular model). Also, even simple old cosine similarity can be implemented in different ways, with both FLAVA and CLIP handling propagation of gradients differently. So I would keep this out and leave it up to the user how to use the embeddings.
For @ankitade's 3rd point, agree that returning more than two modalities doesn't really make sense for zero shot. Though hopefully if the user is running zero shot (or contrastive with batch negatives), they wouldn't pass more than two modalities anyways. However, these assumptions plus excessive generality could potentially cause confusion for the users on the "flagship" instantiation of CLIPArchitecture (CLIP 😉 ).
So ultimately I agree with @RdoubleA: leaving CLIPArchitecture as is feels like the right path. But I do think we should generalize the MUGEN architecture to return a dict (as opposed to an arbitrary pair). Otherwise in a case like this, we would have to call each of the encoders multiple times.
(As an aside, this whole convo is yet another interesting test of our "don't generalize until you need to" principle...)


Deadname being replaced on other's people names

When a deadname is to be displayed, it is replaced even if the last name is not a match. This results in instances of other people's names being identified as a deadname instance and being replaced
Ex:
Dead Name: Joe
Dead Last Name: Doe
Name: Joane
Dead Last Name: Doe
Original text: Joe Smith
Changed text: Joanne Smith

Hi @OlliePoyo and thanks for the feedback! This is a pretty common issue that gets reported, with good reason.
I just wrote up a good explanation on this in issue #207; going to close as duplicate but please check out my explanation there and pass along any ideas or feedback in that issue :relaxed:


converting to ContigSet should use a shock id instead of a handle id

[Current coverage][cc-pull] is 79.61%

Merging [#225][cc-pull] into [develop][cc-base-branch] will not change coverage

@@            develop       #225   diff @@
==========================================
  Files            24         24
  Lines          3566       3566
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2839       2839
  Misses          727        727
  Partials          0          0

Powered by Codecov. Last updated by [94be38a...9e1050e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/kbase/data_api/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/kbase/data_api/compare/94be38ae76c7099fe0c00c3212c58fa20ed01c0b...9e1050eed68a9ed710b8933b9bb26528717e0c9c
[cc-pull]: https://codecov.io/gh/kbase/data_api/pull/225?src=pr


Part of speech naming rules

Added NounNamig rule
Added OpenNLPUtil
Added unit tests for Split method
Added error handling in case of missing EnglishPOS.nbin file

After recent fix in the pull request #11 this pull request is ready to review.


updated postman files.

Updated policy files to reflect the changes with Conjur Cloud.

These endpoints were added through the Postman platform and synchronized to this repository.


Food quantity approximation not working

In documentation there is an example of food approximation parsing, but that doesn’t seem to be working. I see from commit history that this was removed at some point. What’s the reason for this?

Hello niksy, indeed when I started to develop the library I thought to integrate a calculation of the approximate quantities by ingredient for needs on another of my projects. This involved having an up-to-date ingredient database / file. The needs are not urgent on my other project, so I gave up this feature for the moment.

Is it possible to return this functionality? Is there some error in that? Maybe add support for minimum and maximum quantity?


It should be a parse error if a class static method contains a 'super'

From https://code.google.com/p/esprima/issues/detail?id=633:
@jeffmo says:

As of the latest version of the spec, it is no longer statically valid to have references to 'super' in static class methods:
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-class-definitions-static-semantics-early-errors
Currently esprima will parse this without issue, but it should through a syntax error.
Clarification: It's only invalid to have super() call in any method...not just static methods.
(this is a recent constraint as of the Jan15 tc39 meeting)
Further clarification: super.whatever (member-expression-ish thing) appears to still be valid

Harmony branch is not developed anymore (#1172).


fix: performance enhancement

Description
This PR improves performance of SC4SNMP. The following changes were introduced:

deleting RabbitMQ (Redis instead)
using redbeat instead of celerybeatmongo for periodic tasks
implementing autoscaling for pods (disabled by default)

Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix
[x] New feature
[x] Refactor/improvement
[x] This change requires a documentation update

How Has This Been Tested?
Integration tests, unit tests, manual tests
Checklist

[x] My commit message is conventional
[x] I have run pre-commit on all files before creating the PR
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

Codecov Report

Merging #483 (2c990ee) into develop (a9481db) will decrease coverage by 0.28%.
The diff coverage is 89.91%.

:exclamation: Current head 2c990ee differs from pull request most recent head 52abd1d. Consider uploading reports for the commit 52abd1d to get more accurate results

@@             Coverage Diff             @@
##           develop     #483      +/-   ##
===========================================
- Coverage    87.00%   86.72%   -0.29%
===========================================
  Files           23       24       +1
  Lines         1424     1416       -8
===========================================
- Hits          1239     1228      -11
- Misses         185      188       +3

Impacted Files
Coverage Δ

splunk_connect_for_snmp/poller.py
100.00% <ø> (ø)

splunk_connect_for_snmp/traps.py
0.00% <ø> (ø)

splunk_connect_for_snmp/common/schema_migration.py
75.40% <33.33%> (-13.96%)
:arrow_down:

splunk_connect_for_snmp/customtaskmanager.py
91.66% <94.11%> (-2.78%)
:arrow_down:

splunk_connect_for_snmp/celery_config.py
100.00% <100.00%> (ø)

splunk_connect_for_snmp/common/task_generator.py
100.00% <100.00%> (ø)

splunk_connect_for_snmp/inventory/loader.py
94.44% <100.00%> (+0.19%)
:arrow_up:

splunk_connect_for_snmp/inventory/tasks.py
95.79% <100.00%> (+0.71%)
:arrow_up:

splunk_connect_for_snmp/snmp/manager.py
94.33% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9481db...52abd1d. Read the comment docs.

:tada: This PR is included in version 1.6.3-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Pre-training Data Release

Hi, nice work. When will the pre-training dataset will be released?

@vateye Hi vateye, the specific release time will be discussed by us later. I will inform you as soon as we make a decision.

@vateye Hi vateye, the specific release time will be discussed by us later. I will inform you as soon as we make a decision.

Hello, thanks for your great work. when will you release VALOR-1M's annotation file? thanks.

We also look forward to the release of VALOR-1M

Hi @TXH-mercury, thanks for the awesome work, do you have any updates on the pretraining data release for VALOR-1M? Thanks!

VALOR-1M will be soon released after be accepted by the journal.

Has Valor-1M been released?

Hi, same question here, will the Valor-1M be released soon?

it has been released now


How to update LUIS dispatched model when child LUIS model changes ?

I implemented LUIS dispatcher using [1] with my 1 LUIS model & 1 QnA. Now, I am in a situation where I plan to have more QnA and new LUIS model connected to same bot.
How can I use dispatcher to make new QnA and new LUIS under the same umbrella ?
Dispatcher tool just combines utterances and intents to new model. So is there any way to add new QnA and new LUIS model or Intent as a part of dispatcher ?
[1]https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-tutorial-dispatch?view=azure-bot-service-4.0&branch=master&tabs=csaddref%2Ccsbotconfig

@CezaryMarcjan can you assist?

Yes, you can add additional components (luis or qna) by running additional "dispatch add ..." commands to your dispatcher for each new component. Dispatcher supports multiple LUIS apps and multiple QnA KBs.


Add notebooks to docs

This is roughly working but the output is quite messy: https://stellargraph--1279.org.readthedocs.build/en/1279/demos/index.html
The script currently just takes the directory names containing demo notebooks and uses that as section headings, which is not ideal.
Notebooks also contain markdown headings which are inconsistently styled at the moment, which messes up the TOC tree.
Follow-ups:

messy sections https://github.com/stellargraph/stellargraph/issues/1294
binder/colab buttons https://github.com/stellargraph/stellargraph/issues/1293
broken links https://github.com/stellargraph/stellargraph/issues/1292
readme as indices https://github.com/stellargraph/stellargraph/issues/1298
validate script in CI https://github.com/stellargraph/stellargraph/issues/1299

#1159

I think there's two more follow up issues we could have:

reusing the README.mds as the indices somehow (one approach would be to convert them into README.rsts and just have the toctree within them)
validating that the committed directory structure matches the one computed with the script on CI so there's no divergence? (Long term I guess it would better for it to be a Python script instead of a bash one, since that's more controlled/flexible.)

Thanks, that makes sense. I've created two more issues #1298 and #1299


ci(github): add semantic release token to permit the bot to push

Requirements

Fill out the template below.
The pull request must update the test suite.
After you create the pull request, all status checks must be pass.

Type

[ ] Bug fix
[ ] Feature change
[ ] Refactor
[ ] Documentation
[x] CI/CD
[ ] Test
[ ] Build
[ ] Style
[ ] Chore

Issue (only for type bug fix/feature change)
Description of the Change
add semantic release token to permit the bot to push to the protected branch master
Possible Drawbacks

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v1.0.2

Your semantic-release bot :package::rocket:


Add a button that scrolls the page back to top

Expected Behavior
The button should have the functionality to smoothly scroll the page back to the top upon being clicked.
Current Behavior
Right now, we have to manually scroll up the page, which can be a hassle, especially when reading blogs.

Any ideas on where something like this should be added or examples of blogs with it?

Yeah, something like this

A button on the right side of the page similar to the one homepage that when clicked smoothly scrolls the page to the top

I think I can work on this, just one thing where would I get the icon from?

@MadhavKrishanGoswami I'm trying to mock up something for the mobile design and then you can take it. 🦾

@dev-palwar @NiallJoeMaher  check this below screen shot i have created this button to scroll to top smoothly. i want to make pr. can you guys add hacktoberfest labels to this issue #542

@akashsiddamshetty Great job! The icon looks good. IMO we should not use gray color because it looks dull and not visually appealing. We can try sticking to the design in 2nd screenshot or else we can use gradient color that is in our theme.

@akashsiddamshetty Great job! The icon looks good. IMO we should not use gray color because it looks dull and not visually appealing. We can try sticking to the design in 2nd screenshot or else we can use gradient color that is in our theme.

@Bitnagar like this

The problem is when we are on mobile. I just haven't seen a pattern on mobile I like. 😅 Any examples of sites doing it well?


Support both meta and alt + arrow keys

It turns out iTerm2 reports the alt+arrows as meta+arrows with 1;9, whereas most other xterm terminals report alt+arrows correctly with 1;3. Currently tcell's alt+arrows support works well in iTerm2 but does not work in the Ubuntu terminal because it reports 1;3. This PR adds Meta and Alt key support and the just maps the meta+arrows to ModAlt so there is no difference for the users.
For a description of iTerm2's use of meta instead of alt, see here.
We could use ModMeta instead of ModAlt, but I don't really understand the difference between meta and alt and it seems nicer if everything were just one or the other.

I think we should report them separately and let applications choose whether to treat them as the same or not. I would do so in my own apps but critically it should be a choice made by the app (which could offer it as a user preference.)
Sent from my iPhone

On Apr 30, 2016, at 7:42 AM, Zachary Yedidia<EMAIL_ADDRESS>wrote:
It turns out iTerm2 reports the alt+arrows as meta+arrows with 1;9, whereas most other xterm terminals report alt+arrows correctly with 1;3. Currently tcell's alt+arrows support works well in iTerm2 but does not work in the Ubuntu terminal because it reports 1;3. This PR adds Meta and Alt key support and the just maps the meta+arrows to ModAlt so there is no difference for the users.
For a description of iTerm2's use of meta instead of alt, see here.
We could use ModMeta instead of ModAlt, but I don't really understand the difference between meta and alt and it seems nicer if everything were just one or the other.
You can view, comment on, or merge this pull request online at:
https://github.com/gdamore/tcell/pull/102
Commit Summary
Support both meta and alt keys as 'alt'
File Changes
M database.go (108)
M mkinfo.go (18)
M terminfo.go (8)
M tscreen.go (7)
Patch Links:
https://github.com/gdamore/tcell/pull/102.patch
https://github.com/gdamore/tcell/pull/102.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Ok, fair enough. I've changed the PR so that the meta keys are reported as ModMeta instead of ModAlt.

Sorry, I'll get to this shortly.

I'm going to rebase this into a single commit, single issue.

Also I'm adding you the AUTHORS file, and updating the 2016 copyright.

Rebased, with AUTHORS and copyright additions:
commit f72273380933216f93863d040fe2272413338373
Author: Zachary Yedidia<EMAIL_ADDRESS>Date:   Sat Apr 30 10:32:37 2016 -0400
fixes #109 Support both meta and alt + arrow keys

After struggling with the inconsistencies between alt and meta, I'm inclined to reverse my stance and just make everything do Alt.  Notably Meta is not supported on Windows.


docs: follow kubernetes/k8s.io branch rename:

Related:

Part of: https://github.com/kubernetes/k8s.io/issues/1597

/cc @coderanger @jberkus

Thanks!


fix: double quote when extending inline styles

fixes https://github.com/Stranger6667/css-inline/issues/392
I believe the issue is that the write_declaration method — which is responsible for replacing double quotes — is not called when there are existing styles.
In order to preserve the performance optimization of not rewriting the name in the case where we're overwriting an existing style, I split out write_declaration_value from write_declaration so that it could be used independently. I have low confidence about this.
Please let me know how I can improve this patch, or feel free to run with this as a start.
Thanks again!

Merging! I am going to look at WASM test failures a bit later and will issue a new release. I'll be back to my regular schedule next Monday

🎉
thanks a bunch!


Check if table exists before executing query

Task/Issue URL: https://app.asana.com/0/488551667048375/1204439154734764/f
Description
This PR checks it the cookies table exists prior trying to execute the delete query.
Steps to test this PR

[ ] In SQLCookieRemover change the line 93 so it tries to get the table info from a table that doesn't exist i.e. 'myfaketable`
[ ] Launch the app and open a website with cookies, i.e. cnn.com
[ ] Use the fire button
[ ] The code to delete cookies should not be executed, i.e. the code below line 97 does not happen. You can add a log statement to double check.

Current dependencies on/for this PR:

develop

PR #3088   👈

This comment was auto-generated by Graphite.


Implement Nullish Coalescing operator

This PR takes work begun by @boingoing in #6254 and completes it to implement the stage 4 tc39 proposal for a nullish coalescing operator.
Proposal repository: https://github.com/tc39/proposal-nullish-coalescing
The implementations passes most relevant test262 test cases - exception being ones also involving tail call optimisations which is a separate JS feature that CC does not support.
A switch ESNullishCoalescingOperator is included but set to true by default.
The basic logic of this implementation is fairly simple - though one key complexity is that a ?? b || c is not permitted without brackets around one of the two operations, this required some extra tracking in the parser.
Within the bytecode emitter the noalish coalescer is de-sugered so that:
result = node1 ?? node2;
becomes
result = node1;
if (result == null) {
  result = node2;
}

@ppenzin @Fly-Style please could one of you take a look?

Word of warning that per the DOM spec, document.all is falsy but is expected to be treated as truthy by operators like ?? - Edge doesn’t use Chakra anymore so this is less important but something to keep in mind since I don’t think embedders can emulate this behavior in userland.

Word of warning that per the DOM spec, document.all is falsy but is expected to be treated as truthy by operators like ?? - Edge doesn’t use Chakra anymore so this is less important but something to keep in mind since I don’t think embedders can emulate this behavior in userland.

Falsely shouldn't be a problem - only if tests with == null if it does that's bizarre BUT I've implemented what the spec says and this isn't currently used in a browser anyway so I think we just roll with it.

Yeah, oddly enough document.all == null is actually true even though it’s an object, verified in Chrome console. Apparently it’s some compatibility baggage from ancient Internet Explorer.
I don’t think it’s a major issue in practice, like you said. Just wanted to state it for the record since embedders have no way to emulate this behavior.

Doing the usual clopenning to clear persistent CI failure.

Yeah, oddly enough document.all == null is actually true even though it’s an object, verified in Chrome console. Apparently it’s some compatibility baggage from ancient Internet Explorer.
I don’t think it’s a major issue in practice, like you said. Just wanted to state it for the record since embedders have no way to emulate this behavior.

Thinking about it - if any browser does embed this and if a developer wants to do document.all ?? something and is confused at getting something as the result that's on them - the sort of special casing required to avoid that is IMO not worth the performance cost it would entail for all other uses.

It turns out that the special case under discussion is actually formally encoded in the ES spec, see https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot

It turns out that the special case under discussion is actually formally encoded in the ES spec, see https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot

Yeah I read it - and I don't think it's worth supporting for now, to handle it in this operation could either:
a) implement a whole new opcode OR
b) use two strick equal comparisons instead of one number comparison
(a) would be a lot of extra code and (b) would be a performance hit - if anyone actually makes a new webbrowser with CC and wants spec perfect support for window.all we can revisit.

Alright, that makes sense. Just wanted to make sure everything was on the table first before a decision was made.  I’ll duck out now 🦆

Closing and reopening in hopes to clear the CI failure.
CC @divmain ;)

@ppenzin interestingly there's an option to override the CI and merge - I'm guessing there's no way to retrigger it now the repository has been transferred - considering it passed everything other than windows 7 - think we should just merge it?

@rhuanjl agree - we should merge it.


Cannot change accounts (e.g. from xbox to steam)

The unauthorise option in the settings menu doesn't work for this?

Ah, I see. I'll take a look, potentially a bug that exists cuz I don't have a multi platform account to test with. Thanks for the additional info!

Looks like I just never added support for when you have memberships via multiple platforms. I believe based on a bit of experimentation on my end that if you enabled cross save it would make the API send deepsight your steam membership, which would allow it to work? But don't bother, I'll add support for switching which membership you're looking at anyway, for others in your situation. ETA the next couple days probably!

Alright, I've just pushed support for both cross save (by default, it shows the currently cross saved platform's characters) and manually selecting a specific platform to show the characters from. It's in the Settings tab if with your setup you're still seeing your Xbox characters by default.
Let me know how it goes! I'm going to pre-emptively close this assuming it's good, but I'll reopen if there's any issues.


[Examples] Upgrade to babel 6 for browserify

I have also remove the stage.

Good job, thanks :+1: :+1:


Kafka monitoring

What this PR does / why we need it:
Currently this chart does not expose jmx metrics to prometheus. This PR is basically a helm-ification of the changes at: https://github.com/Yolean/kubernetes-kafka/commit/5a2b8c72d43c82c4333c3f523e23bbbc17833fc9, which adds an exporter.
@faraazkhan @h0tbird @benjigoldberg

Can you bump the version number to 0.5.0 ?   Given this is adding resources we'd consider it to be a minor update rather than a patch under semver.

Not a problem, can totally do that.
That being said, it also seems like the standard in other charts is for metrics to be disabled by default, so I'll get that flipped too

After looking through some of the metrics that this is providing, I'm not 100% sure that these are necessarily the correct metrics that should be included in the chart (ie, I think there are metrics that should be included, but are not).
Based on that, I think we should put this on hold for right now. I'd hate to get something merged in upstream only for it to not actually solve the problem it aimed to.

So I agree that metrics would be super nice and I've been working on it as well.  Few things to bring up.
(1) the whitelist/pattern is removing a lot of useful stats.  I think its too limiting
(2) There should be a way to override the config map values or enable/disable it (related to #1)
(3) This works for standard install of prometheus but doesn't work with the prometheus-operator, I guess both should probably be supported (I was actually working on it the other way, using prometheus-operator)
(4) I setup as a sidecar, we already get stats about cpu/memory from prometheus, so to me a sidecar seemed a little more appropriate but open to discussion
(5) It would be nice to setup some generic alerts that every kafka cluster would want (although maybe that's a separate PR)
Also I'd gladly contribute too, but not quite ready for a PR, my codes working but still needs some love.

@bradenwright
Completely agree on points 1 and 2. I actually pulled the rules out into the config, and left what I had just as an example/template. I found that I was missing stuff, and so for now I'm just collecting everything.
Regarding the other points:
3) I have really no experience with the prometheus operator. I'm more than happy to make it work for both, but I'm really not sure what any of the differences are.
4) The foundation of this was taken from the commit referenced in the PR message. My understanding is that this chart was meant to follow that implementation, so I have it matching that.
5) Totally agree that that would be pretty cool, but I think that would probably be best as a separate PR

@nrmitchi cool, that's where I started too.  There ended up being a number of metrics I thought were overkill, so I was gonna blacklist so stats but make configureable.
(3) I more than happy to contribute that part, I'm hoping to have it all done by Monday, if not earlier
(4) I just think this probably deserves some discussion.  And it maybe more appropriate to run as a java-agent.  https://github.com/prometheus/jmx_exporter#jmx-exporter mentions running as java-agent as being the preferred, but reading the reasoning I thought it fit better as a sidecar (just seemed to fit the docker/k8s model better).  And I felt it was actually a little easier to configure as a sidecar in certain ways.  But again very open to discussion on this.
(5) cool!
I'm more than happy to collaborate however you want on this, I think it will work out will that you did it with Prometheus and I did it with Prometheus Operator.

Code wise to if you/anyone wanted to compare, again I can push my code running as a sidecar instead of java-agent for a comparison (if wanted), again I'll have a clean PR Monday maybe earlier.

Updated to include both the jmx exporter, as well as the kafka-exporter referenced at: https://prometheus.io/docs/instrumenting/exporters/
Considering adding a configurable burrow (https://github.com/linkedin/Burrow) deployment as well.
Also planning to swap out the default image that is currently being used with the base jmx_exporter (https://github.com/prometheus/jmx_exporter) rather than the custom one that is currently being used

@bradenwright I would be interested in seeing your sidecar approach, especially if it works with prometheus-operator

@NicolasTr a member of my team did a lot of the initial work in getting the jmx export up and running, but my understanding is that the readiness probe change was taken from the upstream (non helm) kubernetes-kafka project, and the pre-existing one didn't work due to a port conflict.
I'm honestly not entirely sure if it is the best readinessProbe, but again I'm trusting the change upstream (https://github.com/Yolean/kubernetes-kafka/blob/master/kafka/50kafka.yml#L63)

So I still need to do a little clean up, and I'm currently tweaking jmx-exporter-configmap.yaml to produce stats that are more appropriate for Prometheus, but it should be fine to discuss things above:
https://github.com/spothero/kubernetes-charts/pull/3/files

@nrmitchi the readiness probe is a good one, we're going to merge another PR from @t-d-d that already has this change included in it. If possible, it would be nice to just hone this PR down to just the changes around JMX and metrics export.
My initial thoughts are that I prefer the sidecar method to modifying the core container to export metrics as well. Sidecars are a fairly common paradigm in the community generally, and are typically recommended for this kind of metrics export operation from what I've seen.
full disclosure: @bradenwright and I are coworkers at SpotHero
The final thought I have -- I think the zookeeper metrics are great -- but my initial reaction is that they likely belong with zookeeper. Although many users will deploy a zookeeper cluster with a kafka cluster, that isnt universally true. I'd prefer to encourage people to think about and package metrics with the component to which they belong.
What do you think @nrmitchi? How about others on this PR @bradenwright @t-d-d do you have any opinions given your time using Kafka?

@benjigoldberg
Totally agree about the zookeeper metrics in the config; I'll get the pulled out of this PR.
I also agree that the sidecar approach does fit the k8s model better, however the recommended use of the jmx_exporter in particular is as a java agent (https://github.com/prometheus/jmx_exporter#jmx-exporter).
I'm watching #4093, and will also remove the readinessProbe change when that PR is merged.

@nrmitchi @benjigoldberg my feeling on the java-agent is they say its preferred b/c you get more metrics from things like Memory/CPU metrics (those should be accessible via kubernetes metrics already) and its easier to config (I personally think the sidecar is easier to config in K8s, and you could log in and restart a container without restarting kafka if you wanted to change the jmx exporter config map).   I felt the sidecar approach was more appropriate in K8s land.  That's what swayed me to not use the java-agent approach even though it was "recommended"  https://github.com/prometheus/jmx_exporter#jmx-exporter

@nrmitchi @benjigoldberg I agree that the javaagent adds a lot more complexity (changing the broker image)  Unless someone can point to a concrete advantage...
@nrmitchi Why the different approach to the 2 exporters?  One as a sidecar and one as standalone deployment?
@bradenwright your changes are looking promising.  Maybe flatten the values nesting a bit?  Should the 'exports' be at global level?
This is all looking very promising - a combination of these will be great.

I'll confirm if running as jmx exporter as a sidecar is duplicating data or not, and post back.

@bradenwright My concern isn't duplicate scraping for the jmx_export exporter, but for the kafka_exporter

@nrmitchi my bad, I didn't start digging yet.  I'll check out kafka exporter.  I should have time later today.

@nrmitchi  Sorry, I was confused as to what you meant by 'java-agent'.  I understand that approach to be loading a plugin into the jvm running the application.  That isn't what is happening in either of the approaches here - that would require augmenting the kafka base image.  And I'm not sure it would actually give anything more than we already have.  https://github.com/Yolean/kubernetes-kafka/tree/master/prometheus is using the sidecar approach, as is your jmx-exporter option.
Can't you get all the metrics that kafka-exporter gives you vie jmx-exporter?

@t-d-d you do not get all the stats with jmx-exporter.  Kafka exporter compliments it, things like:
kafka_topic_partition_current_offset
kafka_topic_partition_under_replicated_partition
Aren't exposed via JMX from what I've been able to find.

@t-d-d Sorry about the confusion there

@bradenwright OK, I can see the logic in @nrmitchi 's approach of having a separate deployment for the kafka service-level monitoring (via kafka-exporter) as well as the broker process stuff from jmx-exporter sidecars.  But with that approach, do we need the option having a replicaCount > 1 for the deployment?  In the case of a network partition (e.g. the node hosting the kafka-exporter pod goes down) you could lose your monitoring at precisely the time when you need it.  And then I start to think it's simpler to just go with sidecars.
The main downside with the sidecar approach is that these are pretty heavy as each runs a JVM.
At the moment I'm undecided which is the best approach.  I think I slightly favour sidecars.

So for the Kafka exporter having it run as a sidecar kind of duplicates metrics.  I say kind of b/c there is an instance label, so they are technically saved as separate metrics.  But we then have X number of metrics (x being number of kafka exporters)

kafka_topic_partition_current_offset{endpoint="kafkaexporter",instance="<IP_ADDRESS>:9308",job="kissed-swan-kafka",namespace="default",partition="0",pod="kissed-swan-kafka-0",service="kissed-swan-kafka",topic="test1"} | 2
-- | --
kafka_topic_partition_current_offset{endpoint="kafkaexporter",instance="<IP_ADDRESS>:9308",job="kissed-swan-kafka",namespace="default",partition="0",pod="kissed-swan-kafka-2",service="kissed-swan-kafka",topic="test1"} | 2
kafka_topic_partition_current_offset{endpoint="kafkaexporter",instance="<IP_ADDRESS>:9308",job="kissed-swan-kafka",namespace="default",partition="0",pod="kissed-swan-kafka-1",service="kissed-swan-kafka",topic="test1"} | 2

@bradenwright I would consider that a duplication of metrics, mostly because there isn't a sane way to roll that up, without picking an arbitrary instance/pod name to select on (in which case we are back to the "well what if that instance is missing" problem).
If there is a nice way in Prometheus to select just one of a random set of metrics (with the assumption that they're all the same) then it could be a possibility, but it seems like a lot of overhead compared to just running a separate deployment.

I don't think that is possible in prometheus without maybe some metric relabeling on the server.
To me it makes sense to have the kafka-exporter as a separate deployment. It eliminates the issue of duplicate metrics. Kafka-exporter also provides cluster-level metrics, so having it be tied to the number of brokers feels wrong. I'm okay with making the kafka-exporter replicas configurable though.

@nrmitchi @ebabani I agree!  I was just trying to be clear about the results, but it requires too many hoops to jump through.
If there is an easy way to de-dup then maybe I could see the argument, but then also what would we be gaining from running as a sidecar, we'd have redundancy, but at that point way not just run a pod with 2 replicas?
I haven't had a chance to dig, but at this point my preferences are (1) running Kafka Exporter as its own pod and (2) running JMX exporter as a sidecar.  I think everyone is in agreement on (1) at this point.

@bradenwright  I agree with both points :)

Yes, sounds good.
On Tue, 27 Mar 2018, 22:11 Ergin Babani<EMAIL_ADDRESS>wrote:

@bradenwright https://github.com/bradenwright I agree with both points
:)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/charts/pull/4138#issuecomment-376539527,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEa7djMox7JHA6kRfXbAp2uO0Xdt0NIhks5tikh2gaJpZM4So9tK
.

Anything else required for this to go in (besides a rebase due to a new chart version)?
For what it's worth, I like the way this PR scopes the jmx options under the metrics key, and don't think it would be hard for users to update their values file with the new key path.

Apologies, I kind of let this fall of my radar.
I believe the two outstanding things (beside the rebase) are:

[ ] Try to use a tagged version of the jmx image, rather than the hashed version as a default (I feel like this would be best practice?)
[ ] Parameterize the jmx port (rather than always using 5555)

I'll try to get those both done shortly, and bump the chart version appropriately.

Also, adding the new value params to the readme

@ebabani I've taken care of those last 3 things. Let me know if there's anything else I should be doing to push this forward

/ok-to-test

related: https://github.com/kubernetes/charts/pull/4931
Awesome stuff!  I have a similar branch for kafka locally that I will PR after this merges.  It adds JMX and Kafka exporters too, but also refactors similar to #4931.  I'll hold back filing my kafka PR until this PR merges -- and I get feedback on #4931's pattern.  Thanks!

@nrmitchi if we clean up the jmx port definition I think we're good to go. Lets use the structure you've defined and remove the one at the top level and update the docs to remove that.

@benjigoldberg 👍

/lgtm

@nrmitchi thanks much for your contribution and working through all the questions/requests with us!

@nrmitchi I am trying to install kafka chart after this merge. Now I get this message "Error: render error in "kafka/templates/statefulset.yaml": template: kafka/templates/statefulset.yaml:174:28: executing "kafka/templates/statefulset.yaml" at <{{template "kafka.co...>: template "kafka.configmap" not defined"

@nrmitchi I run prometheus/grafans cluster using charts here - https://github.com/camilb/prometheus-kubernetes
After bringing up kafka cluster, where do I configure prometheus to collect metrics from kafka?

@aruneli the conflict seems to be with this PR which was merged in between the initial branch for this PR, and the merge: https://github.com/kubernetes/charts/commit/ff9f02d671d0359875a09825d701b5d941d060f6#diff-e4513710c9e51c6f539000cb48ad85f0
Putting something up to fix it.

@nrmitchi Thanks. Could you also please check my other comment on how to enable running prometheus to scrape data from the kafka exporter.

@aruneli It would be similar to how you have configured prometheus to scrape other pods. That seems like a better question for https://github.com/camilb/prometheus-kubernetes

How you scrape the metrics would be entirely up to you; they are exposed, but I'm not sure how that particular chart determines its targets.
This chart now adds annotations to the statefulset if you enable the jmx metrics (and to the kafka-exporter if you enabled that), so it should work out of the box if you prometheus config uses service discovery.

@nrmitchi thanks for putting this together, I'll make sure to open an new PR to add support for Prometheus Operator.

@bradenwright Thanks

In case anyone is follow here I opened a PR for the Prometheus Operator changes: https://github.com/kubernetes/charts/pull/5120


Ramping with directly transition time of the lamp

Describe the bug
Ramping with directly transition time of the lamp if available
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '...'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots & Logfiles
If applicable, add screenshots and logfiles to help explain your problem.
Versions:

Adapter version:
JS-Controller version:
Node version:
Operating system:

Additional context
Add any other context about the problem here.

Working on it.
ramp over ramp time/transition time will replace the current manual ramp over loop


@sazzad16 why close me issues?

https://github.com/xetorthio/jedis/issues/2110
https://github.com/xetorthio/jedis/issues/2109
The purpose of the two issues I published was to ask Jedis officially, which version will be implemented in the future, rather than shutting down my issues directly, and no answer, which made me angry, and several of the releases I published were not implemented in future version plans. Our requirements are just that Jedis need a relatively complete implementation of the Redis API, and this is only the most basic Jedis user requirements.
@sazzad16

@startjava Each of the closed issues has a comment stating the reason. If there is anything to ask about those comments, please ask in respective issues. Thanks!
In case you don't understand, both of the mentioned issues are duplicates of already existing issues created by none other than you.

#2110 is a duplicate of #2073
#2109 is a duplicate of #2081

@startjava Just to clarify,

Our requirements are just that Jedis need a relatively complete implementation of the Redis API,

Whom are you referring exactly by Our?

What are your contributions towards fulfilling your requirements (other than creating Github issues)?

What are you willing to do or provide to complete Redis API implementation in Jedis?


Support Unicode 15.0

It would be great to have the new unicodes available in this library

Agreed! Unicode 15 is now in Maven Central for Java 8+ under version 15.0.1.


Add (official?) I2P

i2pd should probably be renamed to purpleli2p later

Just note that the official names for the respective routers for the i2p and purplei2p projects are i2p and i2pd respectively. Using i2p as attribute is better since those looking for purple will most likely understand the difference. You're missing a maintainer field and perhaps you could supplement the PR with a nixos service. Also did you test this? Perhaps add an assert for i686 Linux since this build seems amd64 dependant.

I made some fixes. A nixos service would be nice, I may provide one later. I tested it on dingo (a869), so it should work for others.

Great, thanks!


@Ignore PassivationTestCase.testPassivationMaxSize

@tadamski FYI, as you have the JIRA assigned.

Linux Build 9801 outcome was FAILURE using a merge of 3e1574c4f8f46df0d8531abd0fe5c52de2e39f69
Summary: Tests failed: 2 (2 new), passed: 3391, ignored: 194 Build time: 01:00:26
Failed tests
org.jboss.as.test.integration.ejb.compression.CompressionTestCase: java.lang.RuntimeException: org.jboss.as.arquillian.container.ManagementClient$UnSuccessfulOperationException: "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-invocation-compression-test.jar\")]' not found"
	at org.jboss.as.arquillian.container.ManagementClient.getProtocolMetaData(ManagementClient.java:202)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.deploy(CommonDeployableContainer.java:145)
Caused by: org.jboss.as.arquillian.container.ManagementClient$UnSuccessfulOperationException: "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-invocation-compression-test.jar\")]' not found"
	at org.jboss.as.arquillian.container.ManagementClient.checkSuccessful(ManagementClient.java:357)
	at org.jboss.as.arquillian.container.ManagementClient.executeForResult(ManagementClient.java:348)
	at org.jboss.as.arquillian.container.ManagementClient.readResource(ManagementClient.java:343)
	at org.jboss.as.arquillian.container.ManagementClient.getProtocolMetaData(ManagementClient.java:193)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.deploy(CommonDeployableContainer.java:145)
------- Stdout: -------
07:38:29,159 ERROR [org.jboss.as.arquillian.container.ServerSetupObserver] (main) Setup task failed during tear down. Offending class 'org.jboss.as.test.integration.ejb.client.descriptor.EJBClientDescriptorTestCase$EJBClientDescriptorTestCaseSetup@26d18c': java.lang.RuntimeException: "WFLYCTL0367: Cannot remove capability 'org.wildfly.network.outbound-socket-binding.ejb-client-descriptor-test-outbound-socket' as it is required by other capabilities:
capability 'org.wildfly.remoting.outbound-connection.ejb-client-descriptor-test-remote-outbound-connection' requires it for attribute 'outbound-socket-binding-ref' at address '/subsystem=remoting/remote-outbound-connection=ejb-client-descriptor-test-remote-outbound-connection'"
	at org.jboss.as.test.integration.ejb.remote.common.EJBManagementUtil.execute(EJBManagementUtil.java:524)
	at org.jboss.as.test.integration.ejb.remote.common.EJBManagementUtil.removeLocalOutboundSocket(EJBManagementUtil.java:234)
	at org.jboss.as.test.integration.ejb.client.descriptor.EJBClientDescriptorTestCase$EJBClientDescriptorTestCaseSetup.tearDown(EJBClientDescriptorTestCase.java:91)
	at org.jboss.as.arquillian.container.ServerSetupObserver.afterTestClass(ServerSetupObserver.java:138)

 [0m07:38:29,174 INFO  [org.jboss.as.repository] (management-handler-thread - 4) WFLYDR0001: Content added at location /opt/buildAgent/work/a31d203e70e89f90/testsuite/integration/basic/target/jbossas/standalone/data/content/fb/2cfc6357b8b988034d3a3274c8ef72df7cf8af/content
 [0m07:38:29,180 ERROR [org.jboss.as.arquillian.container.ManagementClient] (main) Operation {
    "operation" => "read-resource",
    "recursive" => "true",
    "address" => [("deployment" => "ejb-invocation-compression-test.jar")]
} did not succeed. Result was {
    "outcome" => "failed",
    "failure-description" => "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-invocation-compression-test.jar\")]' not found",
    "rolled-back" => true,
    "response-headers" => {"process-state" => "reload-required"}
}
07:38:29,184 WARN  [org.jboss.as.arquillian.container.ArchiveDeployer] (main) Cannot undeploy: ejb-invocation-compression-test.jar: org.jboss.as.controller.client.helpers.standalone.ServerDeploymentHelper$ServerDeploymentException: java.lang.Exception: "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-invocation-compression-test.jar\")]' not found"
	at org.jboss.as.controller.client.helpers.standalone.ServerDeploymentHelper.undeploy(ServerDeploymentHelper.java:114)
	at org.jboss.as.arquillian.container.ArchiveDeployer.undeploy(ArchiveDeployer.java:55)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.undeploy(CommonDeployableContainer.java:150)
Caused by: java.lang.Exception: "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-invocation-compression-test.jar\")]' not found"
	at org.jboss.as.controller.client.helpers.standalone.impl.ServerDeploymentPlanResultFuture.getActionResult(ServerDeploymentPlanResultFuture.java:134)
	at org.jboss.as.controller.client.helpers.standalone.impl.ServerDeploymentPlanResultFuture.getResultFromNode(ServerDeploymentPlanResultFuture.java:123)
	at org.jboss.as.controller.client.helpers.standalone.impl.ServerDeploymentPlanResultFuture.get(ServerDeploymentPlanResultFuture.java:85)
	at org.jboss.as.controller.client.helpers.standalone.impl.ServerDeploymentPlanResultFuture.get(ServerDeploymentPlanResultFuture.java:42)
	at org.jboss.as.controller.client.helpers.standalone.ServerDeploymentHelper.undeploy(ServerDeploymentHelper.java:107)
	... 86 more

org.jboss.as.test.integration.ejb.container.interceptor.ContainerInterceptorsTestCase: java.lang.RuntimeException: org.jboss.as.arquillian.container.ManagementClient$UnSuccessfulOperationException: "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-container-interceptors.jar\")]' not found"
	at org.jboss.as.arquillian.container.ManagementClient.getProtocolMetaData(ManagementClient.java:202)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.deploy(CommonDeployableContainer.java:145)
Caused by: org.jboss.as.arquillian.container.ManagementClient$UnSuccessfulOperationException: "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-container-interceptors.jar\")]' not found"
	at org.jboss.as.arquillian.container.ManagementClient.checkSuccessful(ManagementClient.java:357)
	at org.jboss.as.arquillian.container.ManagementClient.executeForResult(ManagementClient.java:348)
	at org.jboss.as.arquillian.container.ManagementClient.readResource(ManagementClient.java:343)
	at org.jboss.as.arquillian.container.ManagementClient.getProtocolMetaData(ManagementClient.java:193)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.deploy(CommonDeployableContainer.java:145)
------- Stdout: -------
 [0m07:38:29,235 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /opt/buildAgent/work/a31d203e70e89f90/testsuite/integration/basic/target/jbossas/standalone/data/content/63/2e855a82377919f81d2939913390ee758cf97d/content
 [0m07:38:29,240 ERROR [org.jboss.as.arquillian.container.ManagementClient] (main) Operation {
    "operation" => "read-resource",
    "recursive" => "true",
    "address" => [("deployment" => "ejb-container-interceptors.jar")]
} did not succeed. Result was {
    "outcome" => "failed",
    "failure-description" => "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-container-interceptors.jar\")]' not found",
    "rolled-back" => true,
    "response-headers" => {"process-state" => "reload-required"}
}
07:38:29,246 WARN  [org.jboss.as.arquillian.container.ArchiveDeployer] (main) Cannot undeploy: ejb-container-interceptors.jar: org.jboss.as.controller.client.helpers.standalone.ServerDeploymentHelper$ServerDeploymentException: java.lang.Exception: "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-container-interceptors.jar\")]' not found"
	at org.jboss.as.controller.client.helpers.standalone.ServerDeploymentHelper.undeploy(ServerDeploymentHelper.java:114)
	at org.jboss.as.arquillian.container.ArchiveDeployer.undeploy(ArchiveDeployer.java:55)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.undeploy(CommonDeployableContainer.java:150)
Caused by: java.lang.Exception: "WFLYCTL0216: Management resource '[(\"deployment\" => \"ejb-container-interceptors.jar\")]' not found"
	at org.jboss.as.controller.client.helpers.standalone.impl.ServerDeploymentPlanResultFuture.getActionResult(ServerDeploymentPlanResultFuture.java:134)
	at org.jboss.as.controller.client.helpers.standalone.impl.ServerDeploymentPlanResultFuture.getResultFromNode(ServerDeploymentPlanResultFuture.java:123)
	at org.jboss.as.controller.client.helpers.standalone.impl.ServerDeploymentPlanResultFuture.get(ServerDeploymentPlanResultFuture.java:85)
	at org.jboss.as.controller.client.helpers.standalone.impl.ServerDeploymentPlanResultFuture.get(ServerDeploymentPlanResultFuture.java:42)
	at org.jboss.as.controller.client.helpers.standalone.ServerDeploymentHelper.undeploy(ServerDeploymentHelper.java:107)
	... 86 more

@Ignored test ran after the ones that failed, so the @Ignore was not the cause, so in it goes!


Create hello world pipeline

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mikemmz sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mikemmz sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mikemmz sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Add Liquid Engine

(from #202)
SteamDB app page links to a few games using this
https://steamdb.info/app/91200/
https://steamdb.info/app/236730/
https://steamdb.info/app/251530/
https://steamdb.info/app/252170/
https://steamdb.info/app/282070/
https://steamdb.info/app/294750/
https://steamdb.info/app/323190/
Brief explanation of the change
Added Detection of Liquid Engine
closes #202

This War of Mine has this file in a folder so you'll have to change the regex rule to also check if it's in a folder (like the other rules)

This War of Mine has this file in a folder so you'll have to change the regex rule to also check if it's in a folder (like the other rules)

i'll do that in a second :D

This War of Mine has this file in a folder so you'll have to change the regex rule to also check if it's in a folder (like the other rules)

maybe you could explain how to add multiple checks in one regex? i cant figure it out

whats wrong with it now

why did it reference SteamDatabase#1 lmao

@Lifeismana regex101.com was arguing about that slash so i removed it xd

bruh GitHub desktop doesn't want to push stuff now, gives me timed out errors even tho i am online

On that site you have to change the delimiter from / to ~ (click the thing just left of the regex)

Looks good to me now, thanks for the pr !

thanks for helping me with making this pr too!


What is the best method to store title and/or alt attribute for the uploaded image?

Is there any addon available that manages this?

probably just as another model accessor. please ask this sort of question on the google group, rather than as an issue - thanks


PageSpeed: SEO error

Describe the bug
Recently several of my SvelteKit websites started showing up an error on Google PageSpeed Insights.
Simply put, the "SEO" parameter totally fails to load.
Two errors come up:
Document has a valid hreflang Error!
Document has a valid rel=canonical Error!

Reproduction
Did setup a brand new SvelteKit project and this also happens.
https://skitseotest.vercel.app/
https://pagespeed.web.dev/analysis/https-skitseotest-vercel-app/3rpg9ky5bg?form_factor=desktop&hl=en
Logs
No response
System Info
---

Severity
annoyance
Additional Information
No response

Issue seems related to Google's Lighthouse / Node HTTP Link and not SvelteKit
https://github.com/GoogleChrome/lighthouse/issues/14972
https://github.com/jhermsmeier/node-http-link-header/issues/29


When I add thirdpart login in this project, something went wrong

When I add thirdpart login in this project, (github or what), I added service-configuration,accounts-github module and try the code
eg.
ServiceConfiguration.configurations.upsert(
{ service: 'github' },
{
$set: {
loginStyle: 'popup',
clientId: 'balabala',
secret: 'balabala',
},
}
);
the errors happened
error on boot.js Error: update +  is not available on the server. Please use updateAsync() instead.
I20231218-10:57:40.518(8)?     at Object.ret. [as update] (packages/mongo/remote_collection_driver.js:52:15)
I20231218-10:57:40.518(8)?     at Collection.update (packages/mongo/collection.js:961:31)
I20231218-10:57:40.518(8)?     at Collection.upsert (packages/mongo/collection.js:1066:17)
I20231218-10:57:40.518(8)?     at packages/service-configuration/service_configuration_server.js:38:41
I20231218-10:57:40.518(8)?     at Array.forEach ()
I20231218-10:57:40.518(8)?     at packages/service-configuration/service_configuration_server.js:37:25
I20231218-10:57:40.518(8)?     at Function.time (/Users/float/Code/joi-ai/great-prompt/.meteor/local/build/programs/server/profile.js:277:30)
I20231218-10:57:40.518(8)?     at /Users/float/Code/joi-ai/great-prompt/.meteor/local/build/programs/server/boot.js:389:21
I20231218-10:57:40.518(8)?     at processTicksAndRejections (node:internal/process/task_queues:95:5)
I20231218-10:57:40.518(8)?     at /Users/float/Code/joi-ai/great-prompt/.meteor/local/build/programs/server/boot.js:438:9
I20231218-10:57:40.518(8)?     at startServerProcess (/Users/float/Code/joi-ai/great-prompt/.meteor/local/build/programs/server/boot.js:435:5)
I20231218-10:57:40.518(8)? Error: update +  is not available on the server. Please use updateAsync() instead.
I20231218-10:57:40.518(8)?     at Object.ret. [as update] (packages/mongo/remote_collection_driver.js:52:15)
I20231218-10:57:40.519(8)?     at Collection.update (packages/mongo/collection.js:961:31)
I20231218-10:57:40.519(8)?     at Collection.upsert (packages/mongo/collection.js:1066:17)
I20231218-10:57:40.519(8)?     at packages/service-configuration/service_configuration_server.js:38:41
I20231218-10:57:40.519(8)?     at Array.forEach ()
I20231218-10:57:40.519(8)?     at packages/service-configuration/service_configuration_server.js:37:25
I20231218-10:57:40.519(8)?     at Function.time (/Users/float/Code/joi-ai/great-prompt/.meteor/local/build/programs/server/profile.js:277:30)
I20231218-10:57:40.519(8)?     at /Users/float/Code/joi-ai/great-prompt/.meteor/local/build/programs/server/boot.js:389:21
I20231218-10:57:40.519(8)?     at processTicksAndRejections (node:internal/process/task_queues:95:5)
I20231218-10:57:40.519(8)?     at /Users/float/Code/joi-ai/great-prompt/.meteor/local/build/programs/server/boot.js:438:9
I20231218-10:57:40.519(8)?     at startServerProcess (/Users/float/Code/joi-ai/great-prompt/.meteor/local/build/programs/server/boot.js:435:5)
=> Exited with code: 1
=> Your application is crashing. Waiting for file change.
when I change ServiceConfiguration.configurations.upsert to ServiceConfiguration.configurations.upsertAsync, the error disapeared, but the code doesn't work well.
Then I realized th Meteor 2.7+ should  use Meteor settings by setting your services under Meteor.settings.packages.service-configuration. eg.
{
"packages": {
"service-configuration": {
"github": {
"loginStyle": "popup",
"clientId": "balabala",
"secret": "balabala"
}
}
}
}
when I change to that, the first error show again
what should I do when I need to add third part login in this project(meteor 3) ?
I am a newbee, plz show me the code

Hey @zexiplus, I just set up Login with GitHub. Instead of using code, I added the GitHub credentials in the settings.json file. You can check the instructions in the README.md and test it at https://simpletasks.meteorapp.com.


Consistent handling for task arguments

A little followup for the discussion in #17.
Regarding having username and password etc, as arguments in tasks or only based on information from the inventory my first use case will be to use Brigade as part of a network discovery process. I will have a number of ip addresses and a number of different sets of credentials. I won't know which credentials to use for each of the device and will have to each one until I find something which works. In that scenario I wouldn't want the credentials to be tied to the inventory, i.e. it would be good to have both where the task arguments would override the inventory.
I do however like the idea of reusing the logic between different tasks so that we don't invent the wheel for each set of tasks.
Also for consistency I think we should enforce the naming of common arguments so they remain the same for all tasks.
As an example I used host as an argument for the tcp_ping task. The similar argument with napalm_cli is hostname, for the netmiko task it's ip or host. I think all of these only use one argument and that it should be host instead of hostname or ip, the reason being that a host could be either an ip address or a hostname.
Also I think we should standardise other arguments too, for example that all tasks use username instead of having some tasks with username and others with user, api_user or something else.
A starting list for this could be (examples actual names can be changed):

host
username
password
ignore_certs
http_proxy
https_proxy
device_type
filename
destination

Ping @dbarrosop, @ktbyers.

Regarding names, I agree. That's why I added the host properties for host, username, etc... to make sure they are named consistently and they are also resolved in the same way.

I think we can close this one, right?


ExecutionDuration missing for advanced vis for SQL DBs

Please add ExecutionDuration attribute for SQL based advanced vis. Thanks!!

Thanks for the feature request! Currently, Temporal doesn't have an ExecutionDuration attribute specifically for SQL-based advanced visualizations. However, you can achieve similar functionality using other approaches.
You could try calculating the duration of SQL queries within the application logic and passing the calculated duration as a custom attribute to the Temporal workflow. This way, you can visualize the duration using the available visualization tools.
Let me know if you have any further questions or need more specific guidance.

Thank you for the feature request!  Currently, Temporal doesn't have an ExecutionDuration attribute specifically for SQL-based advanced visualizations.
However, you can achieve a similar effect by:

Calculating Execution Duration in your SQL Query: Include a calculation within your SQL query to determine the execution time of your operation. For example, you could subtract the timestamp of the start of your process from the timestamp of the end of your process.

Let me know if you have any further questions or require more specific guidance!

Thank you for your feature request! This is a great idea. Unfortunately, Temporal does not currently support an ExecutionDuration attribute for SQL-based advanced visualizations. However, you can achieve a similar effect by using the following workarounds:

Create a custom metric: You can create a custom metric that measures the time it takes for a query to execute. This metric can be displayed on the advanced visualization dashboard.
Use a third-party tool: There are several third-party tools that can be used to monitor the performance of SQL queries. These tools can provide detailed information about the execution time of each query.

We appreciate your feedback and will consider adding this feature in the future. Please let us know if you have any other questions.

Thank you for the feature request! We understand the need for the ExecutionDuration attribute in SQL-based advanced visualizations. Currently, Temporal doesn't have this functionality built-in.
As a workaround, you could consider adding the ExecutionDuration information to your SQL query results. You can achieve this by utilizing the NOW() function in your SQL statements to capture the timestamps before and after your query execution, and then calculating the difference to obtain the ExecutionDuration.
We appreciate your suggestion, and we will consider it for future enhancements.


Propose trait associated items and autoimport traits on completion

Closes #7248

bors r=matklad
Here we go 🎉

bors r=matklad
Here we go 🎉

Formatting was a bit off.
bors retry

Formatting was a bit off.
bors retry


Exclude information for Continuous Back up in the Recommended content

Recomended Content in the Faq area for Cassandra Managed Instanaces show Continuous Back Up for Cosmos

While one understands that this  is for Cosmos DB with Cassandra API it could be better to show this in the Cosmos Area
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a28efb0b-65cc-5be9-e2a1-5e7fbd116916
Version Independent ID: 20e7bbca-879d-982e-beb9-07c668af2882
Content: Frequently asked questions about Azure Managed Instance for Apache Cassandra from the Azure portal
Content Source: articles/managed-instance-apache-cassandra/faq.md
Service: managed-instance-apache-cassandra
GitHub Login: @TheovanKraay
Microsoft Alias: thvankra

@DavideDelVecchio  - Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can update the document accordingly.

I will do and close this one . Thanks @TheovanKraay


add to short course student team

Please add me to the Short Course Students GitHub team.
Username:
akpost21

@akpost21 I sent an invite. Once you confirm you'll be on the team!


Type JS's arguments object based on function parameters

Search Terms
type "arguments" object parameters
Suggestion
Within a function x, the type of the arguments object should be Parameters<typeof x> & IArguments, with undefined removed from the type of any entries in Parameters<typeof x> if that parameter has a default value.
Use Cases
class A {
   fn(it: number) { return true; }
}

class B extends A {
  fn(it: number) {
    // this shouldn't error, because arguments must be at least length 1.
    // instead we get ERROR: Expected 1 arguments, but got 0 or more.
    return super.fn(...arguments);
  }
}

Checklist
My suggestion meets these guidelines:

[?] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

What about using rest arguments? The following typechecks:
class A {
   fn(it: number) { return true; }
}

class B extends A {
  fn(...args: [number]) {
    // this shouldn't error, because arguments must be at least length 1.
    // instead we get ERROR: Expected 1 arguments, but got 0 or more.
    return super.fn(...args);
  }
}

What about using rest arguments?

Rest arguments work, but:

I don't think they work if any of the arguments have default values;

They make the code less readable, since I can't give each argument its own name in the signature (which effects IDE popup docs too)

For example, my real subclass's function signature looked more like:
fn(
  data: PartialDataProps<X> | PartialDataProps<X>[] = {},
  options: Parameters<typeof A["fn"]>[1] = {}
) { return true; }

Holding aside the default values, having the arguments named data and options was much clearer than:
fn(...args: [
  PartialDataProps<X> | PartialDataProps<X>[],
  Parameters<typeof A["fn"]>[1]
]) { return true; }

Also, I just noticed that the Parameters adds | undefined to the type of each argument that has a default value, which makes sense. But, for my proposal that | undefined shouldn't be present in the type of arguments, as the default value will have been applied. I've updated the OP accordingly.

The strictBindCallApply feature makes the following show an error for passing arguments where an array is expected. That might be fixed by what is being discussed here as well.
function one(a: string, b: number) {

}

function two(a: string, b: number) {
	one.apply(null, arguments);
}

This bit me again today, where I had a function like:
function wrapper(a: A, b: B, c: C, d: D, e: E) {
  // callthrough to the wrapped function, which should have same signature
  if(!someCondition) {
    return wrapped(...arguments);
  } else {
    // do something clever
  }
}

Using rest parameters for one or both functions would've made their signatures basically unreadable. And every way I could think of to type-safely maintain the type of the arguments list in only one place (and then ig cast ...arguments to that before the call) was a mess.
This example is similar to @chrmarti's, although with wrapper/wrapped I'm trying to show that, in my case, the signatures didn't just coincidentally match (and I wasn't dealing with bind/apply.

I've also tried to work around this by manually casting arguments to Parameters<typeof fn>, but that gives an error:
function wrapper() {
  // Errror: Type alias 'Args' circularly references itself.
  type Args = Parameters<typeof wrapper>;
  return wrapped(...(arguments as Args));
}

@ethanresnick For complex signatures, it will currently hit: https://github.com/microsoft/TypeScript/issues/43731

This now works:
function fn(a: number, b: string) {
    let args = arguments as IArguments & Parameters<typeof fn>;

}

It has the problem that now args is typed as an array while it's not an array, but it's better than nothing.


SearchInput autocomplete

Describe the bug
Background turns white when input autocomplete is done
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response

@cangnss did you start working on this or is this just a report?

No, i didn't start working. Just a report. But I can work on this.

No worries, i just wanted to make sure that we don't have duplicate work from different people.

I see. No problem

Do you know if this issue is still active? I can't reproduce @UgurKacak


Does nebula support multipath / dynamic pathing?

Wanted to ask for clarification, as I cant find much documentation regarding this - and find it hard to simulate this accurately.
Does nebula automatically switch to an alternative connection, if an existing (ie. direct path to server A in region A, to server B in region B), is degraded, to an alternative path (ie. Indirect path to server C in region B, and hopping over to server B in region B). Note this is not regarding "connection down" and more like connection "degraded" situation (latency spikes, bandwith throttle, etc). Which unfortunately happens quite frequently for a region we deploy into.
Zerotier implements multipath : https://www.zerotier.com/manual/#2_1_5
I believe that Cisco SD-WAN uses the dynamic path approach.

Short answer is no.
Longer answer is that we will visit some form of this with a relaying feature.  We had originally planned to do multipath but determined it wasn't a good fit for Slacks production use case. Hub and spoke VPNs are difficult to scale effectively and we really didn't want dedicated transit nodes anymore, getting rid of these was a primary design goal. We also didn't want every node to be eligible to proxy traffic as that could lead to a full mesh outage in the worst case scenario.

Short answer is no.
Longer answer is that we will visit some form of this with a relaying feature.  We had originally planned to do multipath but determined it wasn't a good fit for Slacks production use case. Hub and spoke VPNs are difficult to scale effectively and we really didn't want dedicated transit nodes anymore, getting rid of these was a primary design goal. We also didn't want every node to be eligible to proxy traffic as that could lead to a full mesh outage in the worst case scenario.

Thanks for clarifying.
Having experienced first hand distributed system failure, with cascading workload moving from one node to another. I agree with the choice on not wanting every node to be eligible to reroute traffic for another node. Until the needed safeguards are in place.
Awesome work here!

Thanks for clarifying.
Having experienced first hand distributed system failure, with cascading workload moving from one node to another. I agree with the choice on not wanting every node to be eligible to reroute traffic for another node. Until the needed safeguards are in place.
Awesome work here!


Allow array<char*> (preserves orig functionality)

Overview
The idea is to provide additional functionality, while leaving orig functionality in-place.
Allowing for the array<char*> simplified my life in writing several methods for a class inheriting from CSVReader.
Commit message

Add convenience type aliases
In set_column_names and read_header, new function takes array<char*>
Add template function to construct array from parameter pack, pass to above

can you explain on a high-level what the additional functionality is?

Sorry for slow response. I've been thinking critically about this. I'm
relatively new to TMP, and your library has been a nice tool to learn on.
And I see now that I can keep the parameter pack intact and hand it off
within the class - in particular, to generate a vector to be filled by
read_row.
In the end, I used a helper template to feed individual elements of an
auto-generated vector into read_row to be filled.  In essence, this is the
opposite of the pull request - starting with a vector<char *>, and ending
with a parameter pack.
Thanks for the nice library!
-Christian
On Mon, May 23, 2016 at 5:45 AM, breznak<EMAIL_ADDRESS>wrote:

can you explain on a high-level what the additional functionality is?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/ben-strasser/fast-cpp-csv-parser/pull/23#issuecomment-220958179

--
A man, a plan, a cat, a ham, a yak, a yam, a hat, a canal – Panama!

Hi,
it's nice to see people using the library and thanks for the patch. :)
However, I will not merge the patch because of several reasons:

Unless I'm mistaken your code only works with const char* parameters as column names. The old code works also with std::string and everything convertible to std::string. This is a breaking interface change.

Originally the code compiled with GCC 4.6. If I recall correctly, then this is still the case. template aliases however require GCC 4.8. I'm not saying that I never want to switch to GCC 4.8 however, the new feature should be worth it.

I do not see the advantage of the new code.

Best Regards
Ben Strasser


Update .md files

Summary of the pull request
Update .md files and 970c387902549f960f830e2d9cb7f4c0d2d18dab
References and relevant issues
#3494
Detailed description of the pull request / Additional comments
Update .md files and 970c387902549f960f830e2d9cb7f4c0d2d18dab
Validation steps performed
Check all .md files.
PR checklist

[X] Closes #3335
[ ] Tests added/passed
[X] Documentation updated

I would suggest not opening any additional PRs for md files. The changes you suggest do not follow our style guidelines. Some files, like NOTICE.txt, we are not allowed to change. It is also not a good idea to change a nuget version just because a bot told you to.


when I use 'tile:' in my script, e.g. 'hyprctl hyprpaper wallpaper monitor,tile:path' it assumes it is part of the path.

I have a script that preloads 2 random images from a specified folder (i have 2 monitors), but some images not showing correctly so I want to try other options (contain or tile). and I am getting syntax errors where 'tile:' is part of the path to the image. Here is that part of the script:
if pgrep -x "hyprpaper" > /dev/null
then
	# set wallpapers
	count=0
	hyprctl hyprpaper wallpaper unload all
	while [ $count -le $(expr "${#monitors[@]}" - 1) ]; do
		hyprctl hyprpaper preload "${randarr[$count]}"
		hyprctl hyprpaper wallpaper "${monitors[$count]},contain:${randarr[$count]}"
		count+=1
	done
	notify-send -i ~/.config/hypr/hyprpaper.png "Hyprpaper" "New wallpapers are set"
else
	hyprctl dispatch exec hyprpaper
	disown
fi

mhm next time try git first. tile is not in a release yet


Please document the build variable populated by the task

I wanted to use the nuget installed by this task in a later task.
So I needed the variable populated by this task that contains the path of the nuget executable.
I searched in the documentation and found nothing about it.
So I went on Github to find in the source code that the build variable populated was NuGetExeToolPath.
Please add this information to the documentation.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d4861e9-3c5e-ccc8-6918-f5a7327de545
Version Independent ID: 8681cf86-9935-2063-ab5d-7ece1e14a2b1
Content: NuGet Tool Installer task - Azure Pipelines & TFS
Content Source: docs/pipelines/tasks/tool/nuget.md
Product: devops
GitHub Login: @erickson-doug
Microsoft Alias: amullans

hello some people can me tell anything aboutthis githube ??


Issue #3453 fix. ghidraDev should lookup pydev pysrc directory by bundle path

Fixes #3453
Since the user can choose where their pool is located, it I figured the solution is to get the location of the pydev bundle, and use that to find the pysrc directory. Seems like that would work for all cases, pool or no pool, plugin or dropin.
This fix works for me. I can try setting up eclipse in a linux VM to test it there too, if that is needed. Don't have any macos access.

Thanks, I'll test this out.

Have you tested this in development mode, when you launch Eclipse/GhidraDev via the GhidraDev run configuration that's included in the Ghidra repo?  I'm getting the following exception in your new code:
java.net.URISyntaxException: Illegal character in path at index 24:
 file:/D:/Users/user/ghidra/GhidraBuild/EclipsePlugins/GhidraDev/GhidraDevPlugin/build/data/buildDependencies/pydev/plugins/org.python.pydev.core_<IP_ADDRESS>802272029/

Update: It's probably because of the spaces. I always put my repos in paths with spaces to catch these types of errors.

I was just going to ask if there was a space. There must be some sanitizing or encoding I need to do. I'll look into it this evening.

I just did a quick test and this worked:
Path pysrcDir = Paths.get(new URI(FileLocator.toFileURL(pydevCoreBundle.getEntry("/")).toString().replaceAll(" ", "%20")).normalize()).resolve("pysrc");

There's probably a more robust way to do the encoding.

Related: https://bugs.eclipse.org/bugs/show_bug.cgi?id=145096

Looks good.  I've tested it with the plugins/ and dropins/ directories, and out of the git repo (which contains a space).  I'll get it merged in.  Thanks!

@zZeck The email address you used on your commits will not associate your contribution to your GitHub account.  Are you ok with that?

@ryanmkurtz  Didn't even realize that worked that way with the email. Thanks for the heads up.


Doesn't load in Windows with 1.17.0-rc.5

The mod loads in Linux with Mono, but not in Windows with the Microsoft .net runtime. The crash report in Windows says there is a missing block. Really all of the blocks are missing, because the mod didn't load at all. For reference, this is the Windows crash report:
Game Version: v1.17.0-rc.5 (Unstable)
Loaded Mods<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>8/20/2022 3:48:41 PM: Critical error occurred
System.Exception: Don't know how to instantiate block of class 'BlockBrokenTeleport' did you forget to register a mapping?
   at Vintagestory.Common.ClassRegistry.CreateBlock(String blockClass) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\ClassRegistry.cs:line 129
   at Vintagestory.Common.BlockTypeNet.ReadBlockTypePacket(Packet_BlockType packet, IWorldAccessor world, ClassRegistry registry) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\Network\BlockTypeNet.cs:line 20
   at Vintagestory.Client.NoObf.GeneralPacketHandler.PopulateBlocks(Block[] blocks, Int32 start, Int32 maxCount) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 527
   at Vintagestory.Client.NoObf.GeneralPacketHandler.LoadBlockTypes() in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 449
   at Vintagestory.Client.NoObf.GeneralPacketHandler.HandleServerAssets_Step1() in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 416
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

The mod did not load because TeleportationNetwork.BlockPosArrayAttribute is missing the Clone function.
20.8.2022 15:48:24 [Error] [tpnet] Exception thrown when attempting to retrieve all types of the assembly TeleportationNetwork, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.Assembly.GetTypes()
   at Vintagestory.Common.ModContainer.GetModSystems(Assembly assembly) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\API\ModContainer.cs:line 428, InnerException: . Will ignore asssembly. Loader exceptions:
20.8.2022 15:48:24 [Error] [tpnet] System.TypeLoadException: Method 'Clone' in type 'TeleportationNetwork.BlockPosArrayAttribute' from assembly 'TeleportationNetwork, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
20.8.2022 15:48:24 [Error] [tpnet] An exception was thrown when trying to load assembly:
System.Exception: C:\Users\tori\AppData\Roaming\VintagestoryData\Cache\unpack\TeleportationNetwork_v1.16.5_v1.6.0.zip_6fbc17aa98f6\TeleportationNetwork.dll declared as code mod, but there are no .dll files that contain at least one ModSystem or has a ModInfo attribute
   at Vintagestory.Common.ModContainer.LoadAssembly(ModCompilationContext compilationContext, ModAssemblyLoader loader) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\API\ModContainer.cs:line 344

BlockPosArrayAttribute implements IAttribute. The official source code for IAttribute does not list a Clone function, but that's just because the source has not been updated. Disassembling VintagestoryAPI.dll from 1.17.0-rc.5 shows that the last function in IAttribute is Clone.
[kyle-minecraft@mihoshi vintagestory]$ ikdasm VintagestoryAPI.dll
...
.class interface public abstract auto ansi Vintagestory.API.Datastructures.IAttribute
{
  .method public hidebysig newslot abstract virtual
          instance void  ToBytes([mscorlib]System.IO.BinaryWriter 'stream') cil managed
  {
  } // end of method IAttribute::ToBytes

  .method public hidebysig newslot abstract virtual
          instance void  FromBytes([mscorlib]System.IO.BinaryReader 'stream') cil managed
  {
  } // end of method IAttribute::FromBytes

  .method public hidebysig newslot abstract virtual
          instance int32  GetAttributeId() cil managed
  {
  } // end of method IAttribute::GetAttributeId

  .method public hidebysig newslot abstract virtual
          instance [mscorlib]System.Type
          GetType() cil managed
  {
  } // end of method IAttribute::GetType

  .method public hidebysig newslot abstract virtual
          instance object  GetValue() cil managed
  {
  } // end of method IAttribute::GetValue

  .method public hidebysig newslot abstract virtual
          instance string  ToJsonToken() cil managed
  {
  } // end of method IAttribute::ToJsonToken

  .method public hidebysig newslot abstract virtual
          instance bool  Equals(class Vintagestory.API.Common.IWorldAccessor worldForResolve,
                                class Vintagestory.API.Datastructures.IAttribute attr) cil managed
  {
  } // end of method IAttribute::Equals

  .method public hidebysig newslot abstract virtual
          instance class Vintagestory.API.Datastructures.IAttribute
          Clone() cil managed
  {
  } // end of method IAttribute::Clone

} // end of class Vintagestory.API.Datastructures.IAttribute
...

Fixed in 1.7.0


Retarget winui_desktop_packaged_app_cpp.vcxproj to 22621

Description
Retarget winui_desktop_packaged_app_cpp.vcxproj to 22621 SDK to fix the issue with the Foundation ingestion with the error below.
##[error]midlrt(0,0): Error MIDL1002: [msg]error while reading input file [context]Error processing WinMD metadata. Custom attribute Windows.Foundation.Metadata.ExperimentalAttribute: Attribute Windows.Foundation.Metadata.ExperimentalAttribute could not be found.
Target Release
1.4
Checklist

[x] Samples build and run using the Visual Studio versions listed in the Windows development docs.
[x] Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
[x] Samples set the minimum supported OS version to Windows 10 version 1809.
[x] Samples build clean with no warnings or errors.
[ ] [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
[ ] If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
[ ] I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

/azp run SamplesCI-ResourceManagement


Error during start on Windows 10

Hi guys. I try to start pretty simple Node JS application with Orbit BD on Windows 10 and face with Error. Can anybody help me?
Precondition:
OS: Windows10
Server: Node JS v.9.2.0
Files:
package.json
{
  "name": "test-ipfs",
  "version": "1.0.0",
  "description": "Desc",
  "main": "app.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "express": "^4.16.2",
    "ipfs": "^0.26.0",
    "orbit-db": "^0.18.2"
  }
}

app.js:
var express = require('express');
var app = express();

var IPFS = require('ipfs');
var OrbitDB = require('orbit-db');
var ipfsOptions = {
  EXPERIMENTAL: {
    pubsub: true
  }
}
var ipfs = new IPFS(ipfsOptions);

ipfs.on('ready', async () => {
  const orbitdb = new OrbitDB(ipfs)
})

app.get('/', function (req, res) {
  res.send('HW!')
})

app.listen(3000, function () {
  console.log('Example app listening on port 3000!')
})

Expected result:
Application successfully run.
Actual result:
Error and stop the application.
Evidence:
Log:
S:\ProgramFilesSSD\node\node.exe --inspect-brk=50767 S:\orbit-test\app.js
Debugger listening on ws://<IP_ADDRESS>:50767/cd785dd0-f8ca-41c6-be04-82f6226581d2
For help see https://nodejs.org/en/docs/inspector
Example app listening on port 3000!
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4003/ws/ipfs/QmYUDE83QHirhqGwUH2fc8xRBxbTzJtnRpidbEgPyBXzr1
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4002/ipfs/QmYUDE83QHirhqGwUH2fc8xRBxbTzJtnRpidbEgPyBXzr1
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4002/ipfs/QmYUDE83QHirhqGwUH2fc8xRBxbTzJtnRpidbEgPyBXzr1
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4002/ipfs/QmYUDE83QHirhqGwUH2fc8xRBxbTzJtnRpidbEgPyBXzr1
Debugger attached.
S:\orbit-test\node_modules\ipfs-repo\node_modules\interface-datastore\src\key.js:45
      throw new Error(`Invalid key: ${this.toString()}`)
      ^

Error: Invalid key: /CIQPRU5S6XB2OALETECSFCCWTLBS745GTPY2GJANQBYTWCUDX2GCAVA
    at new Key (S:\orbit-test\node_modules\ipfs-repo\node_modules\interface-datastore\src\key.js:45:13)
    at keyFromBuffer (S:\orbit-test\node_modules\ipfs-repo\src\blockstore.js:20:10)
    at cidToDsKey (S:\orbit-test\node_modules\ipfs-repo\src\blockstore.js:30:10)
    at Object.has (S:\orbit-test\node_modules\ipfs-repo\src\blockstore.js:129:17)
    at each (S:\orbit-test\node_modules\ipfs-bitswap\src\decision-engine\index.js:207:23)
    at S:\orbit-test\node_modules\async\internal\withoutIndex.js:9:16
    at eachOfArrayLike (S:\orbit-test\node_modules\async\eachOf.js:65:9)
    at exports.default (S:\orbit-test\node_modules\async\eachOf.js:9:5)
    at eachLimit (S:\orbit-test\node_modules\async\each.js:80:24)
    at DecisionEngine._addWants (S:\orbit-test\node_modules\ipfs-bitswap\src\decision-engine\index.js:205:5)
Waiting for the debugger to disconnect...

Process finished with exit code 1

Hi @olegls2000 and thanks for reporting this! I believe Windows is not fully supported yet :/
There are some issues open for js-ipfs on Windows: https://github.com/ipfs/js-ipfs/issues/1075 and https://github.com/ipfs/js-ipfs/issues/1074 and until then, I don't think OrbitDB will be able to support Windows.
Any help solving this and getting it supported would be highly appreciated, we definitely want to get it working on Windows too!

The release ipfs 0.27.x supports Windows.  Please upgrade to the latest IPFS and try again.

That's great to hear @richardschneider! I don't access to a Windows machine right now so can't test it, but would appreciate any reports of success (or failure) running OrbitDB on Windows so that we can fix anything that is left to fix on OrbitDB side.

@richardschneider There's current windows support in a couple places:

PR here: https://github.com/orbitdb/orbit-db/pull/607
Npm package orbit-db-win is a community package, not officially supported, but it might work.

Closing for now


Looping through obj file groups / objects

I have one obj file with multiple groups / objects in it. Is there a way in ViroReact to be able to loop through each one of those groups / objects and add / remove properties as desired?

tl/dr : use a .forEach
As I don't have your current example I will use mine. I create multiple targets from an external file registering the different images.
2 files : arData.js for the data and scene.js
arData.js :
const arData  = [
    {
        id: 1,
        name: "",
        image: require(""),
        videoSource: require(""),
        height:0.1410,
        width:0.0795,

    },
    {
        id: 2,
        name: "",
        image: require(""),
        videoSource: require(""),
        height:0.1410,
        width:0.0795,
    },

}

scene.js :

import the data

import { arData } from '../arData.js';

create a target for each

arData.forEach(data => {
    let trackingObject = {};
    trackingObject[data.id] = {
        source : data.image,
        orientation : "Up",
        physicalWidth : 0.15
    };
    ViroARTrackingTargets.createTargets(trackingObject);
});

this way I'm able to loop in each of the objects from another file and use their properties.
Hope it helped


MeteorListView and MeteorComplexListView

Since that the Meteor calls and subscriptions are done in the containers, do you think it's still relevant to use MeteorListView and MeteorComplexListView with this boilerplate ?

Yes I think it works well with React Native Listview component.
Make your subscriptions in your container and use theses components in your views.

BTW I'm going to vacations next 2 weeks but I'm planning to add more relevant code to help new users use this boiler ;)

What do you mean by relevant?

I was wondering if features of MeteorListView/MeteorComplexListView were handled by this boilerplate


Refactor Javadocs comments

Codecov Report

Merging #393 (91cd0cc) into master (341e86b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #393      +/-   ##
============================================
- Coverage     68.41%   68.40%   -0.01%
  Complexity     1131     1131
============================================
  Files           135      135
  Lines          3866     3865       -1
  Branches        521      521
============================================
- Hits           2645     2644       -1
  Misses          996      996
  Partials        225      225

Impacted Files
Coverage Δ

.../main/java/seedu/address/logic/FeesCalculator.java
70.93% <ø> (ø)

...java/seedu/address/logic/commands/PaidCommand.java
67.69% <ø> (ø)

.../seedu/address/logic/commands/UndoableCommand.java
85.71% <ø> (ø)

...main/java/seedu/address/model/LastUpdatedDate.java
80.95% <ø> (-0.87%)
:arrow_down:

...rc/main/java/seedu/address/model/ModelManager.java
90.14% <ø> (ø)

...rc/main/java/seedu/address/model/lesson/Money.java
54.54% <ø> (ø)

...u/address/storage/JsonSerializableAddressBook.java
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341e86b...91cd0cc. Read the comment docs.


Make compatible with django 1.11

Django 1.11+ actually checks for a valid module, so 'notmigrations' is no longer valid.

..... wrong branch