Ratchet & Clank 3 [PCSF00486]

Game summary

Game name: Ratchet & Clank 3
Game serial: PCSF00486
Game version: 1.00

Vita3K summary

Version: v0.1
Build number: 1113-405a515
Commit hash: https://github.com/vita3k/vita3k/commit/405a515

Test environment summary

Tested by: Jenci
OS: Windows 10
CPU: Intel i5-4690k
GPU: NVIDIA GTX 1050Ti 4GB
RAM: 24 GB 2400mhz

Issues

Unicorn error, same applies as previous R&C as well.
Log
vita3k.log
Recommended labels

Nothing
Unicorn error

Vita3K v0.1.5 2594-4071eb35
goes ingame
intros are just green screen with music and sound fx playing
ingame black screen with glitchy graphic now and then with music and sound fx playing
plays really slow ingame
vita3k.log

App summary

App name: Ratchet & Clank 3
App serial: PCSF00486
App version: 1.00

Vita3K summary

Version: v0.2.0
Build number: 3691
Commit hash: https://github.com/vita3k/vita3k/commit/31826697
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: Benjamin Toledo
OS: Windows 11
CPU: AMD Ryzen 5 4600G
GPU: AMD Radeon(TM) Graphics (Vega 7 integrated graphics)

Issues

No issues, perfect.

Screenshot

Log
vita3k.log
Recommended labels

Playable


RBAC: LDAP support

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[x] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

spring:
  ldap:
    urls: ldap://localhost:10389
    base: "cn={0},ou=people,dc=planetexpress,dc=com"
    admin-user: "cn=admin,dc=planetexpress,dc=com"
    admin-password: "GoodNewsEveryone"
    user-filter-search-base: "dc=planetexpress,dc=com"
    user-filter-search-filter: "(&(uid={0})(objectClass=inetOrgPerson))"
oauth2:
  ldap:
    groupRoleAttribute: "cn" #default
auth:
  type: LDAP
rbac:
  roles:
    - name: "admin_staff"
      clusters:
        - local
      subjects:
        - provider: ldap
          type: group
          value: "ou=people,dc=planetexpress,dc=com"
      permissions:
        - resource: clusterconfig
          actions: [ "view", "edit" ]
        - resource: topic
          value: "ololo.*"
          actions:
            - VIEW
            - CREATE
            - EDIT
            - DELETE
            - MESSAGES_READ
            - MESSAGES_PRODUCE
            - MESSAGES_DELETE
        - resource: consumer
          value: "\_confluent-ksql.*"
          actions: [ VIEW, DELETE, RESET_OFFSETS ]
        - resource: schema
          value: "blah.*"
          actions: [ VIEW, CREATE, DELETE, EDIT, MODIFY_GLOBAL_COMPATIBILITY ]
        - resource: connect
          value: "local"
          actions: [ view, edit, create ]
        - resource: ksql
          actions: [ execute ]


Prevent FunctionSignatureOptimization from rerunning on its own thunk.

This is a bug fix that just bails out of FSO, which is exactly what we
should be doing in this case anyway.
This issue will be exposed in stdlib builds once I fix another bug in
the passmanager. Once the pass pipeline restart works as intended, we
will perform FSO on F, then devirtualization will discover a new
reference to F, causing it to be pushed back on the function pass
pipeline.

@swift-ci test.

@swift-ci benchmark.

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

DictionaryBridgeToObjC_Access
893
1018
+14.0%
0.88x (?)

Improvement

DataAppendDataLargeToLarge
51200
37800
-26.2%
1.35x (?)

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

--------------

Build failed
Swift Test OS X Platform
Git Sha - 958dd9701df5e731609bd258dea92d77510822f3

@swift-ci smoke test OS X Platform.


Answers doesn't log custom event

Hi, Answers Dashboard doesn't show custom attributes when adding a custom event!?

Custom events showed up in dashboard 24 hours later!


Naming Convention

The choice to use get/set-admin* is not consistent with other powershell modules and is not intuitive. We are not trying to set an admin object, we are trying to set a flow or PowerApp object. The role of the person executing the cmdlet should be included in the cmdlet name. If absolutely necessary, the role of person running the cmd should be included as a parameter, but ideally the role should be determined automatically by the context of the account.  I'm not aware of any other powershell modules that require this

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a682d40-fb0d-4938-b1ac-cee291c2bbff
Version Independent ID: c7fdffb8-c6b7-f02b-a5e0-6787218978c6
Content: PowerShell support (preview) - PowerApps
Content Source: powerapps-docs/administrator/powerapps-powershell.md
Service: powerapps
GitHub Login: @jamesol-msft
Microsoft Alias: jamesol

@DeanGross
Sorry for the much delayed response. Clearing a backlog, we noticed this hadn't be resolved. Thanks for your feedback. For product-related feedback, visit https://ideas.powerapps.com.


Multiple Logo instances/headers

Hi I'm working on this project in order to launch my own Moltin store.
At the moment it seems there are like 5 or 6 different places you need to change the header (Nav and logo). It would surely make more sense to just have this in one component so a developer picking this up only has to change this in once place?
I think the project is great and everything but this is surely something that most people will be doing so it would make sense to refactor this to be easier to change.

Hi @jonnysmillie
The react-demo-store is one of our oldest demo projects and is pretty rough shape. It could do with some TLC 🤗
Please feel free to submit a PR with your desired changes and I'll merge into master.
Please let us know how you get on with your project via the forum.

Hi @notrab, I created a PR for this, it's my first one, appreciate if you can check it out.


Console error when saving current Playground project

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

launch a brand new playground page
open developer console
click 'Save' button
you will see errors from console. see screenshot below

Expected behavior
No errors when trying to save a playground project
Desktop (please complete the following information):

OS: Mac OS X 11.6.1 (20G224)
Browser: Chrome
Version 96.0.4664.110 (Official Build) (x86_64)

Fixed in latest build


Fix semantics for assignment and post/pre increment

Fix #1921

[info] - should find that there is no flow from `y = 1` to exit node *** FAILED ***
[info]   1 was not equal to 0 (DataFlowTests.scala:1207)

That's the failing test w.r.t. the return node problem I mentioned.

Yep, just fixed that. It's in fact correct. There's a follow-up PR now that I'm working on that addresses the return value handling across functions.


Add SAIL & gSAIL to popular tokens list

Gsai2KN28MTGcSZ1gKYFswUpFpS7EM9mvdR9c8f6iVXJ

Apparently the project is no longer maintained and has been overrun with beggars.


Disable logging by default

node-windows-service-controller produces a lot of console.logs. I would like to make console.logs opt-in (user provides a flag saying that she wants to print to stdout).
Thoughts?

Good idea, I'd be open to a PR that adds a "silent" option. Would like the
default to remain verbose tho (as it's already in use in a number of build
scripts where verbose is required).
On Thursday, October 27, 2016, Paolo del Mundo<EMAIL_ADDRESS>wrote:

node-windows-service-controller produces a lot of console.logs. I would
like to make console.logs opt-in (user provides a flag saying that she
wants logging).
Thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mikeobrien/node-windows-service-controller/issues/2,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALdqTlROfuBpYvVt8TGMCgALj8U0ViJks5q4UWBgaJpZM4Ki-ON
.

Is anyone working on it yet? I'd really like this to be added.
If @mikeobrien is still open to this, I can submit a PR.

this would be very useful


@reactuse/core

Hi, this package has some ssr error, if you want to use it, you can upgrade it to v1.1.1.

Yes, will do that

haha, any bugs tell me and I will fix it


cargo metadata --offline requires Internet access

Problem
Actual behavior: running cargo metadata --offline in a dependency of the primary crate tries to access the Internet. If the host has no access, this fails with a network error.
Expected behavior: cargo metadata --offline does not attempt to access the Internet & returns a limited set of fields that can be calculated offline.
Weird complicating factor: if the crate in question is vendored as a path dependency, cargo metadata works without the --offline switch.
Error example
error: proc macro panicked
 --> C:\Users\some_user\.cargo\registry\src\-b20c50870c528e96\windows-0.3.1\build.rs:2:5
2 |     windows_macros::build!();
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^

  = help: message: Cargo metadata \\?\C:\src\.rustup\toolchains\stable-x86_64-pc-windows-msvc\bin\cargo.exe did not contain `workspace_root` key. Got stdout . Got stderr
          Updating crates.io index
          warning: spurious network error (2 tries remaining): failed to send request: The server name or address could not be resolved
          ; class=Os (2)
          warning: spurious network error (1 tries remaining): failed to send request: The server name or address could not be resolved
          ; class=Os (2)
          error: failed to get `const-sha1` as a dependency of package `windows v0.3.1 (C:\Users\some_user\.cargo\registry\src\-b20c50870c528e96\windows-0.3.1)`

          Caused by:
            failed to load source for dependency `const-sha1`

          Caused by:
            Unable to update registry `https://github.com/rust-lang/crates.io-index`

          Caused by:
            failed to fetch `https://github.com/rust-lang/crates.io-index`

          Caused by:
            failed to send request: The server name or address could not be resolved
            ; class=Os (2)

          .
   Ran from "C:\\Users\\some_user\\.cargo\\registry\\src\\-b20c50870c528e96\\windows-0.3.1"

error: aborting due to previous error

Steps

Create a binary crate C that depends on windows-rs.
Use cargo local-registry to create a local registry for C's dependencies.
Try to build C with the local registry replacing crates.io, and no Internet access. The build should fail with a cryptic error from the windows-rs build. To reproduce the error message I have above, modifying this line inside the local registry's copy of windows_winmd crate. There is almost certainly a simpler repro, but I suspect an exact repro won't be strictly necessary to address this bug.

Possible Solution(s)
When we make windows-rs a path dependency, it allows cargo metadata to run in that crate without errors while offline. Whatever this code path is, can do the same thing in the local registry case? My suspicion is that C's lockfile somehow applies to the cargo metadata command when windows-rs is a path dependency.
Notes
Output of cargo version:
> cargo version
cargo 1.48.0 (65cbdd2dc 2020-10-14)

Hi @0xngold, it looks like this error is originating from windows-rs here. When the build script is triggered for windows-rs, it makes another cargo call separate of the one you invoked.

Hi @Revantus, while the windows-rs crate at ToT doesn't currently use the --offline flag, I modified it to do so in a local registry for testing. Even with the --offline flag, the error still occurs. As far as I can tell, there is just one instance of the function (it seems the crate authors did some refactoring recently).

With the most recent update to windows-rs I'm unable to replicate the problem. I didn't dig too deep, but their refactoring and a recent workaround might have fixed it.
Can you try these steps? These are what I used to try to replicate the issue on WLS and Windows native.
$ mkdir test_offline
$ cd test_offline
$ mkdir c_local_registry
$ cargo new c
$ cd c
-- add 'windows = "0.5.0"' to the dependencies and build-dependencies in the Cargo.toml --
$ cargo generate-lockfile
$ cd ../c_local_registry
$ cargo local-registry -s ../c/Cargo.lock
$ cd ../c
$ mkdir .cargo
-- add the output from cargo local-registry into .cargo/config --
----------------------------SAMPLE---------------------------------
    [source.crates-io]
    registry = 'https://github.com/rust-lang/crates.io-index'
    replace-with = 'local-registry'

    [source.local-registry]
    local-registry = '/home/some_user/test_offline/c_local_registry/'    # WSL
    local-registry = 'C:\Users\some_user\test_offline\c_local_registry\'  # Windows Native
--------------------------SAMPLE_END-------------------------------

$ cargo build --offline

------OUTPUT------ WSL
$ cargo build --offline
   Unpacking const-sha1 v0.2.0 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking proc-macro2 v1.0.24 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking quote v1.0.9 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking squote v0.1.2 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking syn v1.0.64 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking unicode-xid v0.2.1 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking windows v0.5.0 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking windows_gen v0.5.0 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking windows_gen_macros v0.5.0 (registry `/home/some_user/test_offline/c_local_registry`)
   Unpacking windows_macros v0.5.0 (registry `/home/some_user/test_offline/c_local_registry`)
   Compiling .....
   Compiling c v0.1.0 (/home/some_user/test_offline/c
    Finished dev [unoptimized + debuginfo] target(s) in 17.76s
----OUTPUT_END----

------OUTPUT------ Powershell (Windows Native)
$ cargo build --offline
   Unpacking const-sha1 v0.2.0 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking proc-macro2 v1.0.24 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking quote v1.0.9 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking squote v0.1.2 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking syn v1.0.64 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking unicode-xid v0.2.1 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking windows v0.5.0 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking windows_gen v0.5.0 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking windows_gen_macros v0.5.0 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Unpacking windows_macros v0.5.0 (registry `C:\Users\some_user\test_offline\c_local_registry`)
   Compiling .....
   Compiling c v0.1.0 (C:\Users\some_user\test_offline\c)
    Finished dev [unoptimized + debuginfo] target(s) in 17.76s
----OUTPUT_END----

From what I'm seeing, Cargo is only unpacking the already downloaded and cached crates and not accessing the internet.
I think this issue can be closed.

It looks like the downstream worked around the problem. This change lagged the published version I tested with to file the bug report. I retested with 0.5.0 and it's working offline.
Is this workaround the desired long term state for cargo? Note that they're using --no-deps to get --offline behavior where --offline didn't work.

where --offline didn't work.

cargo metadata --offline should work, supposing either of the following two are done:

Use --filter-platform to only show metadata for a specific platform that has been downloaded.
Do a complete fetch with cargo fetch to fetch all platform dependencies.

cargo metadata without any flags needs all platform-specific dependencies to be downloaded, which I suppose is what you ran into?

Re cargo metadata --offline only working in particular situations, that sounds like what we ran into.
cargo fetch is not necessarily compatible with the idea of a local registry. I think we'd have to switch off (or supplement) local registries to use it. From what I've read, there are some elements which don't seem to be part of local registries, but are available from crates.io, and that's what the metadata command needs. This seems potentially incorrect to me as some of the items I saw it looking for are inside the crate package, but I digress.
I think this bug might be best scoped down to more of a UX issue [0]. In short, the real bug here is: when cargo metadata --offline "fails" and needs Internet access, there is currently no meaningful error. The failure modes also, at least as far as I could find, weren't documented.
[0]: why scope down? I think there's a level of enhancement that is being requested here as well (local registries should enable all offline operations), but that is probably a feature request.


is glVersion sniffing useful for Android?

I really appreciate the way that UserAgent.js can identify Apple hardware via glVersion - this is very useful for WebVR, where it helps to know device features (e.g. device outer dimensions) not reported from the browser. It is possible to detect Android phones (e.g. Galaxy 6) using webGL VERSION, VENDOR, SHADING_LANGUAGE_VERSION?

Thanks and sorry answer is delayed.
I do not have a Galaxy 6, but it is probably possible.
The easiest way to solve this question is to use the WebGLDetector.js.

Thanks for the reply! After leaving this message, I tried a few android smartphones. The Samsung smartphones all seem to have "OpenGL ES 2.0" .
However, I suspect that other Android models might be detected this way.


ZEPPELIN-2527 Changed editor cursor to thin

What is this PR for?
Previously, it's hard to recognize the cursor since it was too thick. After this PR, it will show the cursor same as other input boxes for consistency.
See the attached GIFs for comparison.
What type of PR is it?
[Improvement]
Todos

[ ] - Task

What is the Jira issue?

[ZEPPELIN-2527]

How should this be tested?

Build: mvn clean package -Denforcer.skip -DskipTests -Drat.skip
Open a paragraph
Check the cursor

Screenshots (if appropriate)
Before the change

After the change

Questions:

Does the licenses files need update?
Is there breaking changes for older versions?
Does this needs documentation?

\cc @1ambda

There was an issue with this PR, created a new one:
https://github.com/apache/zeppelin/pull/2462


Not Null tags getting ignored on AutoMigrate

I have the following model:
type Location struct {
	ID        int        `json:"id",gorm:"primary_key"`
	Name      *string    `json:"name",sql:"size:255;not null"`
	Longitude *float64   `json:"longitude",sql:"not null"`
	Latitude  *float64   `json:"latitude",sql:"not null"`
	CreatedAt time.Time  `json:"createdAt"`
	UpdatedAt time.Time  `json:"updatedAt"`
	DeletedAt *time.Time `json:"deletedAt"`
}

and when I AutoMigrate/Create it:
DAO.DB.AutoMigrate(&Location{})

I get the following table output:

Any ideas :) ?

Hello @codingrogue
AutoMigrate won't update current column to make sure your data to be safe.
But seems like update NOT NULL doesn't really matter, I will look into that to make AutoMigrate update some things that won't hurt data

But I deleted the database and recreated it with Automigrate. I thought when it's creating a fresh DB it's considering all tags including not-null?

My mistake! I used comma to separate the tags instead of space! Now the sql tags are getting interpreted correctly and not-null works now!


fix(core): stop rounding to nearest int in hrTimeTo*seconds() functions

Which problem is this PR solving?
Fixes https://github.com/open-telemetry/opentelemetry-js/issues/3986
Short description of the changes
Remove Math.round() calls from hrTimeTo{Milli,Micro}seconds() functions in order to preserve higher precision from floating point parts.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Existing tests are all passing
Would like to test this against contrib repo but not sure how to do that

Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added
[ ] Documentation has been updated

Seems like it doesn't break any tests. Have you been able to try this fork in a real world app?

Seems like it doesn't break any tests. Have you been able to try this fork in a real world app?

I tried it in a little test express server with the http instrumentation and it fixed the striping I mentioned in the issue. Is there a way to run the contrib repo tests against this branch?

Seems like it doesn't break any tests. Have you been able to try this fork in a real world app?

I tried it in a little test express server with the http instrumentation and it fixed the striping I mentioned in the issue. Is there a way to run the contrib repo tests against this branch?

Not an easy way that I can think of. We could release a -alpha tag version and push it to NPM.
I am very familiar with the trace SDK and don't expect this to be a problem, but can someone with more familiarity with the metrics SDK sanity check this? @legendecas @pichlermarc

The only call site of the conversion functions is merging two accumulations, e.g. https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/sdk-metrics/src/aggregator/LastValue.ts#L70. I believe it is fine to accept non-integer numbers here.

Test failures api-eol-node-test are unrelated to this PR, they are failing on HEAD commit 2b20565
Unexpected token {
npm ERR! Test failed.  See above for more details.

I'm going to land this and track the api-eol failure in https://github.com/open-telemetry/opentelemetry-js/issues/4029.


Doesn't seem to mock global by default

Trying this out and i've found that jest is always resolving fetch-mock to the CJS server entry, and not the browser one, which results in the global fetch not being polyfilled. Is there a config i'm missing?

https://jestjs.io/docs/en/configuration#browser-boolean

Oops spoke to soon, this doesn't work, because the browser field points to an mjs file, which jest can't handle

Hey - first real user issue raised. Welcome 😄
Have you tried any of the approaches mentioned here https://github.com/facebook/jest/issues/4637. It does feel more like a jest issue to workaround than a problem with this library (or with fetch-mock either)

Yeah so i realized that i was complicating it by failing to correctly setup fetch-mock with a polyfill first, but yeah, this is ultimately probably a problem with jest not handling mjs files. That said, since this is specifically a jest extension, it probably makes more sense to require the cjs file directly here instead of fetch-mock and hoping Jest does the right thing?
here is ultimately the jest config that got this working:
 },
  "jest": {
    "testEnvironment": "jsdom",
    "moduleNameMapper": {
      "fetch-mock$": "<rootDir>/node_modules/fetch-mock/cjs/client.js"
    },
    "setupFiles": [
     "whatwg-fetch"
    ]
  },

Yeah, that's a fair point. I didn't pay much attention to which file was being required, but am surprised that Jest - being the hippest test runner around - doesn't play nice with .mjs
I'll need to restructure this repo to have different server.js and browser.js exports in that case. No time to do so tonight, but maybe later this week.

Please try v1.2.0 of this library and reopen the issue if it's still broken


Configuration options "stats" missing in docs

I cannot seem to find any documentation about the stats option which seems to be valid according to the error message:
Warning: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration has an unknown property 'failOnError'. These properties are valid:
   object { amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry, externals?, loader?, module?, name?, node?, output?, plugins?, profile?, recordsInputPath?, recordsOutputPath?, recordsPath?, resolve?, resolveLoader?, stats?, target?, watch?, watchOptions? }

Sounds like your configuration has an extra property. Getting rid of that failOnError field might fix it.
That said, these fields need to be documented.

Yes I copied the error from webpack/grunt-webpack#81. Because i wanted to figure out what this option is doing, because if webpack is now printing the stats on it's own, when this option is set, I could remove the stats printing in the grunt plugin. But even after looking at the source I have no idea what it is doing. :D

I documented it here for dev-server, but it seems to be also valid for webpack.

Discussed with @bebraw: we'll move the current docs for stats in dev-server to a separate page, and refer to it from dev-server.


Clean up scaling pipeline

Content
Modify the scaling pipeline to autogenerate the configuration files
Remove config/scaling_configs
Clean up scaling plots a bit
Current scaling run:
https://buildkite.com/clima/climaatmos-scaling/builds/492

bors try

bors try

bors try

bors try

bors r+

bors r+


Problem running tools/generate_from_protos.sh

I'm getting the following error when I run 'tools/generate_from_protos.sh'.
I ran the configuration step before running the .sh script 'cmake -DBUILD_BACKEND=ON -Bbuild/default -H.' Anyone knows what am I missing?

Error
'protoc-gen-mavsdk' not found in PATH
Make sure 'protoc-gen-mavsdk' is installed and available

I think this changed, can you try:
pip3 install --user protoc-gen-mavsdk

It was called protoc-gen-dcsdk, but now it is protoc-gen-mavsdk indeed. The error message says that you need to install it, as @julianoes suggests above.


[ENH] Greedy Gaussian Segmentation

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.
[ ] The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

FYI @miraep8

This should be ready for review. Some notable design decisions:

the initialization happens through attrs with three separate groups of arguments defined explicitly:

__init__ args that are used to instantiate the estimator: k_max, lamb, max_shuffles, verbose, random_state
private instance state attributes starting with _: _intermediate_change_points and _intermediate_ll
attributes set by fit: change_points_

the compatibility layer with sklearn is coded in GGSEstimator by providing the common interface methods
Thanks to attrs default __repr__ shows not only the kwargs but also internal instance state based on the attributes that are not passed to __init__.

Here is a minimal example:
import numpy as np
from sktime.annotation.ggs import GGSEstimator
from sklearn.preprocessing import StandardScaler
from sklearn.pipeline import Pipeline

x = np.concatenate(tuple(np.ones(5) * i**2 for i in range(4)))
X = x[:, np.newaxis]

ggs = GGSEstimator()
print(ggs)
cp = ggs.predict(X)
print("Predicted segmentation vector", cp)
print(ggs)
print("Predicted change points:", ggs._adaptee.change_points_)

pipe = Pipeline([('scale', StandardScaler()), ('segment', GGSEstimator())])
predicted = pipe.fit_predict(X)
print("Predicted from pipeline: ", predicted)

which gives:
GGS(k_max=10, lamb=1.0, max_shuffles=250, verbose=False, random_state=None, change_points_=[], _intermediate_change_points=[], _intermediate_ll=[])
Predicted segmentation vector [0 0 0 0 0 1 1 1 1 1 2 2 2 2 2 3 3 3 3 3]
GGS(k_max=10, lamb=1.0, max_shuffles=250, verbose=False, random_state=None, change_points_=[0, 5, 10, 15, 21], _intermediate_change_points=[[0, 21], [0, 15, 21], [0, 10, 15, 21], [0, 5, 10, 15, 21]], _intermediate_ll=[-50.11068443455932, -2.8697641499393534, 39.44974322647064, 52.18875824868201])
Predicted change points: [0, 5, 10, 15, 21]
Predicted from pipeline:  [0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 2 2 2 2 2]

Let me know what you think @miraep8 @KatieBuc @fkiraly

FYI @KatieBuc

This should now be ready to be merged @fkiraly
FYI @Lovkush-A have a look if you are interested, as a follow-up on the base class conversation.

@Lovkush-A @GuzalBulatova @fkiraly @aiwalter could you approve this PR?

I am happy to approve with assumptoin that this is likely going to be changed after we decide on a uniform interface. Is that what you expecting too, @lmmentel?
General comments:

documentation will need adjusting for the next version. E.g. just having single word 'fit' or 'predict' for a docstring is not helpful for a user!  also, does not use numpy format that is used elsewhere in sktime
the attr package makes things look tidy! cant say i have understood exactly what it does (e.g. consequences of defining the intermediate variables in fit, rather than in init), but looks promising!
i have not tried at all to understand at all the nitty gritty of GGS. i presume it works. would need some more tests to really check it does what we intend
i have not thought about this much, but i do not see benefit of having two classes, with one wrapping the other. should be possible to add the methods in the Estimator class directly into the GGS class?

Thanks @Lovkush-A

I am happy to approve with assumptoin that this is likely going to be changed after we decide on a uniform interface. Is that what you expecting too, @lmmentel?

Yup, I do not consider the annotation module "finalized" although the exposed interface if GGS should be compatible with the ecosystem as shown in the minimal example :point_up:

General comments:
* documentation will need adjusting for the next version. E.g. just having single word 'fit' or 'predict' for a docstring is not helpful for a user!  also, does not use numpy format that is used elsewhere in sktime

I totally agree, right now the documentation lags behind and the current module will not be exposed in the docs https://www.sktime.org/en/stable/api_reference/annotation.html

* the `attr` package makes things look tidy! cant say i have understood exactly what it does (e.g. consequences of defining the intermediate variables in fit, rather than in init), but looks promising!

I'm happy to prep a short presentation for one of the devs meetings if more people are interested.

* i have not tried at all to understand at all the nitty gritty of GGS. i presume it works. would need some more tests to really check it does what we intend

Understood, there is a goal we set at some early stage to have a notebook at some point illustrating some of the segmentation methods, would that help in this case or are you thinking about a deeper dive into the theory behind GGS?

* i have not thought about this much, but i do not see benefit of having two classes, with one wrapping the other. should be possible to add the methods in the Estimator class directly into the GGS class?

Main reason is separation of concerns between the algorithm implementation (that can be reused in different contexts) and the adapter ensuring compatibility with sktime/sklearn.

I'm happy to prep a short presentation for one of the devs meetings if more people are interested.

this is a good idea!

Understood, there is a goal we set at some early stage to have a notebook at some point illustrating some of the segmentation methods, would that help in this case or are you thinking about a deeper dive into the theory behind GGS?

Ideally, I only approve a PR if I am confident the code does what we intend it to do. In this case, I neither know what psuedo-code is for GGS (what the intention for the code is) nor what the code actually does (i have not read any of the code corresponding to the algorithm itself).  this is separate from the theory. notebook might help with this - depends what is in the notebook!

Main reason is separation of concerns between the algorithm implementation (that can be reused in different contexts) and the adapter ensuring compatibility with sktime/sklearn.

i see. not obvious if such 'algorithm classes' should live in sktime or outside. cf hmmlearn.

In this case, I neither know what psuedo-code is for GGS (what the intention for the code is) nor what the code actually does

@Lovkush-A, neither do I, and for me that is actually a reason to request this via docstring as a blocking change request.

@fkiraly I updated the docstrings, hope this will be enough


fix 4.1 select2_from_array using 0 as key.

WHY
BEFORE - What was wrong? What was happening before this PR?
If you use 0 as key for select2_from_array field the current code checking for old(field) would not work properly so the value with key 0 would not be reselected when validation fails as reported in #4099
AFTER - What is happening after this PR?
It works as expected.
HOW
How did you achieve that, in technical terms?
We had already solved this for select_from_array in #3816 . This ports the same fix for this field.
Is it a breaking change or non-breaking change?
Non
How can we test the before & after?
Add a select2_from_array that contains the key '0' => 'some value', select it and force the validation error to trigger you will notice that the value you selected is no longer selected.
After it is.
Note @tabacitu this is fixed in 4.2 no need to port this fix there, our old() wrapper solves this.

A new inspection was created.

The inspection completed: No new issues

Note @tabacitu this is fixed in 4.2 no need to port this fix there, our old() wrapper solves this.

Uuu! Music to my ears! ❤


Adding CoreNLP tokenizer and taggers based on nltk.parse.corenlp

Added a couple of duck-types to use CoreNLPParser for POS and NER tagging.
Added a duck-type to use CoreNLPParser for tokenization.
Regarding the deletion of higher level import at nltk.tokenize.__init__.py,

there's some sort of cyclic imports between nltk.tokenize.* and nltk.parse.corenlp.
so to create a duck-type object based on nltk.parse.corenlp inside nltk.tokenize.stanford
it's necessary to leave out the parent import at nltk.tokenize.__init__.py.

I think we can slowly port code for ~StanfordPOSTagger~ , ~StanfordNERTagger~, StanfordSegmenter to use the nltk.parse.corenlp too.
Tokenizer is the easiest since it's already inside the CoreNLPParser, c.f. https://github.com/nltk/nltk/issues/1733#issuecomment-303450277
POS and NER taggers simply wraps around the CoreNLPParser.api_call.

Thanks @dimazest for the review! I can't make the edits now but I'll do it soon so that we can start asking people to stop using the Stanford APIs and use the CoreNLP ones.

@dimazest I can't find a way to start the CoreNLP server on the CI server such that the doctest would work and I really want to avoid starting the CoreNLP inside Python.
@fievelk any suggestion?

We might have to do that testing locally, as we do for several other of the wrapped interfaces.

Well, we could also mock the api_call() of CoreNLP parser.
Right, that's the reason CorenNLP tests are not run, because there are no jars.

How should we proceed with this PR?
Should we create a mock_api_call()inside nltk.parse.corenlp?

Is it just a question of knowing how to disable testing of a module on the CI server?

The current doctests are already skipped. But I'm not sure whether we need some sort of mock test for to return the values that we expect corenlp to return

I meant to use something like https://docs.python.org/3/library/unittest.mock.html
The method mocked_api_call() should be defined in a test, so you can specify a mocked return value that is propagated later to the code. The plus side is that the java process doesn't even need to be started, the downside is that the integration with it is not tested.
Maybe, it's a good idea to enable mocking if CoreNLP server is not accessible.
I need to think about it. It's most probably outside of this PR, if there are test that are executed if jars are accessible, that should be fine.

Mocking the corenlp output is alright to verify the rest of the code in parsing the .api_call() output. But one issue is that unittest.mock is Python3 only and we have to add an additional dependency for  mock in Python2.

To test locally, first start the CoreNLP server on command-line with:
wget http://nlp.stanford.edu/software/stanford-corenlp-full-2016-10-31.zip
unzip stanford-corenlp-full-2016-10-31.zip && cd stanford-corenlp-full-2016-10-31
java -mx4g -cp "*" edu.stanford.nlp.pipeline.StanfordCoreNLPServer -port 9000 -timeout 15000

Then in Python:
>>> from nltk.tag.stanford import CoreNLPPOSTagger, CoreNLPNERTagger
>>> stpos, stner = CoreNLPPOSTagger(), CoreNLPNERTagger()
>>> stpos.tag('What is the airspeed of an unladen swallow ?'.split())
[(u'What', u'WP'), (u'is', u'VBZ'), (u'the', u'DT'), (u'airspeed', u'NN'), (u'of', u'IN'), (u'an', u'DT'), (u'unladen', u'JJ'), (u'swallow', u'VB'), (u'?', u'.')]
>>> stner.tag('Rami Eid is studying at Stony Brook University in NY'.split())
[(u'Rami', u'PERSON'), (u'Eid', u'PERSON'), (u'is', u'O'), (u'studying', u'O'), (u'at', u'O'), (u'Stony', u'ORGANIZATION'), (u'Brook', u'ORGANIZATION'), (u'University', u'ORGANIZATION'), (u'in', u'O'), (u'NY', u'O')]

To test support for Chinese:
wget http://nlp.stanford.edu/software/stanford-corenlp-full-2016-10-31.zip
unzip stanford-corenlp-full-2016-10-31.zip && cd stanford-corenlp-full-2016-10-31
wget http://nlp.stanford.edu/software/stanford-chinese-corenlp-2016-10-31-models.jar
java -Xmx4g -cp "*" edu.stanford.nlp.pipeline.StanfordCoreNLPServer -serverProperties StanfordCoreNLP-chinese.properties -preload tokenize,ssplit,pos,lemma,ner,parse -status_port 9001  -port 9001 -timeout 15000

In Python:
>>> from nltk.tag.stanford import CoreNLPPOSTagger, CoreNLPNERTagger
>>> from nltk.tokenize.stanford import CoreNLPTokenizer
>>> stpos, stner = CoreNLPPOSTagger('http://localhost:9001'), CoreNLPNERTagger('http://localhost:9001')
>>> sttok = CoreNLPTokenizer('http://localhost:9001')

>>> sttok.tokenize(u'我家没有电脑。')
['我家', '没有', '电脑', '。']

# Without segmentation
>>> stpos.tag(u'我家没有电脑。')
[('我', 'PN'), ('家', 'NN'), ('没', 'AD'), ('有', 'VV'), ('电', 'NN'), ('脑', 'NN'), ('。', 'PU')]
# With segmentation
>>> stpos.tag(sttok.tokenize(u'我家没有电脑。'))
[('我家', 'NN'), ('没有', 'VE'), ('电脑', 'NN'), ('。', 'PU')]

# Without segmentation
>>> stner.tag(u'奥巴马与迈克尔·杰克逊一起去杂货店购物。')
[('奥', 'GPE'), ('巴', 'GPE'), ('马', 'GPE'), ('与', 'O'), ('迈', 'O'), ('克', 'PERSON'), ('尔', 'PERSON'), ('·', 'O'), ('杰', 'O'), ('克', 'O'), ('逊', 'O'), ('一', 'NUMBER'), ('起', 'O'), ('去', 'O'), ('杂', 'O'), ('货', 'O'), ('店', 'O'), ('购', 'O'), ('物', 'O'), ('。', 'O')]
# With segmentation
>>> stner.tag(sttok.tokenize(u'奥巴马与迈克尔·杰克逊一起去杂货店购物。'))
[('奥巴马', 'PERSON'), ('与', 'O'), ('迈克尔·杰克逊', 'PERSON'), ('一起', 'O'), ('去', 'O'), ('杂货店', 'O'), ('购物', 'O'), ('。', 'O')]

To test support for german:
wget http://nlp.stanford.edu/software/stanford-corenlp-full-2016-10-31.zip
unzip stanford-corenlp-full-2016-10-31.zip && cd stanford-corenlp-full-2016-10-31

wget http://nlp.stanford.edu/software/stanford-german-corenlp-2016-10-31-models.jar
wget https://raw.githubusercontent.com/stanfordnlp/CoreNLP/master/src/edu/stanford/nlp/pipeline/StanfordCoreNLP-german.properties

java -Xmx4g -cp "*" edu.stanford.nlp.pipeline.StanfordCoreNLPServer \
-serverProperties StanfordCoreNLP-german.properties \
-preload tokenize,ssplit,pos,ner,parse \
-status_port 9002  -port 9002 -timeout 15000

In Python
>>> from nltk.tag.stanford import CoreNLPPOSTagger, CoreNLPNERTagger
>>> stpos, stner = CoreNLPPOSTagger('http://localhost:9002'), CoreNLPNERTagger('http://localhost:9002')

>>> stpos.tag('Ich bin schwanger'.split())
[('Ich', 'PPER'), ('bin', 'VAFIN'), ('schwanger', 'ADJD')]

>>> stner.tag('Donald Trump besuchte Angela Merkel in Berlin.'.split())
[('Donald', 'I-PER'), ('Trump', 'I-PER'), ('besuchte', 'O'), ('Angela', 'I-PER'), ('Merkel', 'I-PER'), ('in', 'O'), ('Berlin', 'I-LOC'), ('.', 'O')]

To test support for spanish:
wget http://nlp.stanford.edu/software/stanford-corenlp-full-2016-10-31.zip
unzip stanford-corenlp-full-2016-10-31.zip && cd stanford-corenlp-full-2016-10-31

wget http://nlp.stanford.edu/software/stanford-spanish-corenlp-2016-10-31-models.jar
wget https://github.com/stanfordnlp/CoreNLP/blob/master/src/edu/stanford/nlp/pipeline/StanfordCoreNLP-spanish.properties

java -Xmx4g -cp "*" edu.stanford.nlp.pipeline.StanfordCoreNLPServer \
-serverProperties StanfordCoreNLP-spanish.properties \
-preload tokenize,ssplit,pos,ner,parse \
-status_port 9003  -port 9003 -timeout 15000

In Python
>>> from nltk.tag.stanford import CoreNLPPOSTagger, CoreNLPNERTagger
>>> stpos, stner = CoreNLPPOSTagger('http://localhost:9003'), CoreNLPNERTagger('http://localhost:9003')

>>> stner.tag(u'Barack Obama salió con Michael Jackson .'.split())
[(u'Barack', u'PERS'), (u'Obama', u'PERS'), (u'sali\xf3', u'O'), (u'con', u'O'), (u'Michael', u'PERS'), (u'Jackson', u'PERS'), (u'.', u'O')]

>>> stpos.tag(u'Barack Obama salió con Michael Jackson .'.split())
[(u'Barack', u'np00000'), (u'Obama', u'np00000'), (u'sali\xf3', u'vmis000'), (u'con', u'sp000'), (u'Michael', u'np00000'), (u'Jackson', u'np00000'), (u'.', u'fp')]

To test support for french:
wget http://nlp.stanford.edu/software/stanford-corenlp-full-2016-10-31.zip
unzip stanford-corenlp-full-2016-10-31.zip && cd stanford-corenlp-full-2016-10-31

wget http://nlp.stanford.edu/software/stanford-french-corenlp-2016-10-31-models.jar
wget https://raw.githubusercontent.com/stanfordnlp/CoreNLP/master/src/edu/stanford/nlp/pipeline/StanfordCoreNLP-french.properties

java -Xmx4g -cp "*" edu.stanford.nlp.pipeline.StanfordCoreNLPServer \
-serverProperties StanfordCoreNLP-french.properties \
-preload tokenize,ssplit,pos,parse \
-status_port 9004  -port 9004 -timeout 15000

In Python
>>> from nltk.tag.stanford import CoreNLPPOSTagger
>>> stpos = CoreNLPPOSTagger('http://localhost:9004')
>>> stpos.tag('Je suis enceinte'.split())
[(u'Je', u'CLS'), (u'suis', u'V'), (u'enceinte', u'NC')]

Finally, arabic:
wget http://nlp.stanford.edu/software/stanford-corenlp-full-2016-10-31.zip
unzip stanford-corenlp-full-2016-10-31.zip && cd stanford-corenlp-full-2016-10-31

wget http://nlp.stanford.edu/software/stanford-arabic-corenlp-2016-10-31-models.jar
wget https://raw.githubusercontent.com/stanfordnlp/CoreNLP/master/src/edu/stanford/nlp/pipeline/StanfordCoreNLP-arabic.properties

java -Xmx4g -cp "*" edu.stanford.nlp.pipeline.StanfordCoreNLPServer \
-serverProperties StanfordCoreNLP-french.properties \
-preload tokenize,ssplit,pos,parse \
-status_port 9005  -port 9005 -timeout 15000

In Python
>>> from nltk.tag.stanford import CoreNLPPOSTagger
>>> from nltk.tokenize.stanford import CoreNLPTokenizer
>>> sttok = CoreNLPTokenizer('http://localhost:9005')
>>> stpos = CoreNLPPOSTagger('http://localhost:9005')
>>> text = u'انا حامل'
>>> stpos.tag(sttok.tokenize(text))
[('انا', 'DET'), ('حامل', 'NC')]

Regarding the dependency on mock. A proof of concept my be py3 only, and then if it works, we might think of how to backport it to py2. Having py3 only tests is better than having none.

@dimazest Would it be better to have the mock tests in another PR? Or should this PR include a mock test for Py3 first?

@dimazest I've added the mock test, should be good for a last review now =)

:+1: looks good to be merged.

@dimazest could you change the review to approve if it looks good to merge? It'll be easier for @stevenbird to track which PR is merge-able when he sees that the CI checks pass and review approved =)

Hopefully, these issues will be fixed by suggesting users to use the new wrappers around the corenlp servers:

#929
#1311
#1375
#1390
#1396
#1424
#1426
#1443
#1476
#1518
#1523
#1603
#1625
#1632
#1652
#1733
#1746

Perhaps, we could start adding deprecation warning for nltk.tag.StanfordPOSTagger, nltk.tag.StanfordNERTagger and nltk.tokenize.StanfordTokenizer and nltk.tokenize.StanfordSegmenter in the next major release. =)

@alvations, @dimazest: thanks for this great work. @alvations you might like to tell people about it on nltk-dev


[git] File is shown under Changes even when all changes have been staged

VSCode Version: 1.1.0-inside
OS Version: Windows 10

Steps to Reproduce:

Open a file which has changes
Select some lines, and click on Stage Selected Lines in the ellipsis menu on top-right.
When you've staged all the lines, the file is still there in the Changes section.

What Should Happen:
File should be immediately removed from the changes section when all it's changes have been staged.

Do you still see this after 10seconds?
There is a small delay we use for refreshing the git viewlet

For me, switching tabs refreshes the list.

There is also the subtle bug which I encountered today, which triggered me to write this issue: I had not setup the autocrlf config for my repo, so even after staging all marked hunk diffs, vscode was not refreshing the CHanges section because there would have been ^M characters in the diff making the file unclean. This is not marked in the diff view, which caused some head-scratching.

@isidorn I'm sorry but on further investigation I think this is a false alarm. The files not clearing is definitely being caused by the hidden CRLF characters which are not marked in the vscode diff.
Should I raise a separate bug for that, or can we convert this one to read "vscode doesn't visualize changed newline characters in diffs" or something along those lines?

I believe there is already a feature request for that - please search for it, and if you can not find it please file a new issue - thanks!


search component rendered when not set

The search component renderer when not set in valaxy.config.ts.
It must be set as
search {
  enable: false
}

and the search component won't render.

I set the search to true by default, but I'll set it to false until the native local search is done.


Add link I removed from challenge

Added a link to a resource I removed from the challenge description

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


review[VNV3.6] - Automated Testing & Verification Tools: #127

#127

@AhmedAl-Hayali Pls complete review and merge. Created issue as to avoid PR from being blocked.

This issue is not visible in the project tracker, hence is not achieving its intended purpose. Going forward, please attach labels to issues (this would benefit from documentation, VnV, and deliverable item), attach them to a project (GenreGuru), and update the project status to "Ready" before the reviewer gets to it. This is all in extension to the assigning the PR reviewer as you've done. Thanks.


[BUG] Glob pattern for markdown files doesn't work properly

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
Hi, I'm using this action to find all changed markdown files like this.
files: |
  '**/*.md'

It would work but with a warning: "No match found for specified patterns. Ensure that subdirectory patterns a prefixed with "**/". See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet"
To Reproduce

A repo contains many markdown files and images.
A workflow like this:name: test

on:
  push:
    branches:
      - '*'

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - name: Check out a copy of the repo
        uses: actions/checkout@v3
        with:
          fetch-depth: 2
          path: main

      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v19
        with:
          since_last_remote_commit: "true"
          path: main
          files: |
            '**/*.md'

Modify some markdown files, commit and push them, "Non Matching changed files" will show up.

What OS are you seeing the problem on?
ubuntu-latest or ubuntu-20.04
Expected behavior?
I expect that
file: |
  '**/*.md'

would match all changed markdown files without the warning.
Relevant log output
Run tj-actions/changed-files@v19
  with:
    since_last_remote_commit: true
    path: main
    files: '**/*.md'

    token: ***
    separator:
    files_separator:

    files_ignore_separator:

    sha: 7575ed34ebf22251bb52b151d8a7d366885b9d9f
    use_fork_point: false
    quotepath: true
Run # "Set base sha..."
  # "Set base sha..."
  if [[ -n "" ]]; then
    echo "::set-output name=base_sha::"
  elif [[ "true" == "true" && "07a28ccd305f518ce489d5962f03eadd94957065" != "0000000000000000000000000000000000000000" ]]; then
      echo "::set-output name=base_sha::07a28ccd305f518ce489d5962f03eadd94957065"
  fi
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Run # "Calculating the previous and current SHA..."
  # "Calculating the previous and current SHA..."
  bash $GITHUB_ACTION_PATH/diff-sha.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GITHUB_SERVER_URL: https://github.com
    GITHUB_REPOSITORY: loopsocial/github_to_confluence
    GITHUB_BASE_REF:
    GITHUB_HEAD_REF:
    GITHUB_ACTION_PATH: /home/runner/work/_actions/tj-actions/changed-files/v19
    INPUT_SHA: 7575ed34ebf22251bb52b151d8a7d366885b9d9f
    INPUT_BASE_SHA: 07a28ccd305f518ce489d5962f03eadd94957065
    INPUT_TOKEN: ***
    INPUT_PATH: main
    INPUT_USE_FORK_POINT: false
changed-files-diff-sha
  Resolving repository path...
  Setting up 'temp_changed_files' remote...
  No 'temp_changed_files' remote found
  Creating 'temp_changed_files' remote...
  Getting HEAD SHA...
Run<EMAIL_ADDRESS>  with:
    files: '**/*.md'

    files-separator:

    escape-paths: true
    excluded-files-separator:

    working-directory: main
    base-sha: 07a28ccd305f518ce489d5962f03eadd94957065
    sha: 7575ed34ebf22251bb52b151d8a7d366885b9d9f
    include-deleted-files: true
    separator: |
    files-from-source-file-separator:

    excluded-files-from-source-file-separator:

    follow-symbolic-links: true
    strip-top-level-dir: true
/usr/bin/git rev-parse --show-toplevel
/home/runner/work/github_to_confluence/github_to_confluence/main
/usr/bin/git diff --diff-filter=D --name-only 07a28ccd305f518ce489d5962f03eadd94957065 7575ed34ebf22251bb52b151d8a7d366885b9d9f

Warning: No match found for specified patterns. Ensure that subdirectory patterns a prefixed with "**/". See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
Run bash $GITHUB_ACTION_PATH/entrypoint.sh
  bash $GITHUB_ACTION_PATH/entrypoint.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GITHUB_ACTION_PATH: /home/runner/work/_actions/tj-actions/changed-files/v19
    INPUT_FILES_PATTERN_FILE:
    INPUT_SEPARATOR:
    INPUT_PATH: main
    INPUT_PREVIOUS_SHA: 07a28ccd305f518ce489d5962f03eadd94957065
    INPUT_CURRENT_SHA: 7575ed34ebf22251bb52b151d8a7d366885b9d9f
    INPUT_TARGET_BRANCH: github_to_confluence~1
    INPUT_CURRENT_BRANCH: github_to_confluence
    INPUT_QUOTEPATH: true
changed-files
  Resolving repository path...
  Retrieving changes between 07a28ccd305f518ce489d5962f03eadd94957065 (github_to_confluence~1) → 7575ed34ebf22251bb52b151d8a7d366885b9d9f (github_to_confluence)
  Getting diff...
  Added files:
  Copied files:
  Deleted files:
  Modified files: specs/data-tracking/pixel-tracking/ad/comp50.md specs/data-tracking/pixel-tracking/commerce/README.md
  Renamed files:
  Type Changed files:
  Unmerged files:
  Unknown files:
  All changed and modified files: specs/data-tracking/pixel-tracking/ad/comp50.md specs/data-tracking/pixel-tracking/commerce/README.md
  All changed files: specs/data-tracking/pixel-tracking/ad/comp50.md specs/data-tracking/pixel-tracking/commerce/README.md
  All modified files: specs/data-tracking/pixel-tracking/ad/comp50.md specs/data-tracking/pixel-tracking/commerce/README.md

Anything else?
files: |
  '**/*.md'

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@jack-fireworkhq Seems that’s because the pattern itself is invalid.
You’ll need to remove the single quotes you have around the pattern.
files: '**/*.md'

Should be modified to
files: **/*.md

OR
files: |
   **/*.md

Hi @jackton1 , Sorry to bother you, but I tried what you said above with v19 and v20, and it's still not working.
Here are the output logs:
Run tj-actions/changed-files@v20
  with:
    since_last_remote_commit: true
    path: main
    files: *.md
  **/*.md

    token: ***
    separator:
    old_new_separator: ,
    old_new_files_separator:
    files_separator:

    files_ignore_separator:

    sha: 0c8280e8cbc5d829ac550394b41b4dfc0f94ddb6
    use_fork_point: false
    quotepath: true
Run # "Set base sha..."
  # "Set base sha..."
  if [[ -n "" ]]; then
    echo "::set-output name=base_sha::"
  elif [[ "true" == "true" && "6f2c00d9ba3f031cf1e0cabd4a3462613221db44" != "0000000000000000000000000000000000000000" ]]; then
      echo "::set-output name=base_sha::6f2c00d9ba3f031cf1e0cabd4a3462613221db44"
  fi
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Run # "Calculating the previous and current SHA..."
  # "Calculating the previous and current SHA..."
  bash $GITHUB_ACTION_PATH/diff-sha.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GITHUB_SERVER_URL: https://github.com/
    GITHUB_REPOSITORY: loopsocial/github_to_confluence
    GITHUB_BASE_REF:
    GITHUB_HEAD_REF:
    GITHUB_ACTION_PATH: /home/runner/work/_actions/tj-actions/changed-files/v20
    INPUT_SHA: 0c8280e8cbc5d829ac550394b41b4dfc0f94ddb6
    INPUT_BASE_SHA: 6f2c00d9ba3f031cf1e0cabd4a3462613221db44
    INPUT_TOKEN: ***
    INPUT_PATH: main
    INPUT_USE_FORK_POINT: false
changed-files-diff-sha
  Resolving repository path...
  Getting HEAD SHA...
Run<EMAIL_ADDRESS>  with:
    files: *.md
  **/*.md

    files-separator:

    escape-paths: true
    excluded-files-separator:

    working-directory: main
    base-sha: 6f2c00d9ba3f031cf1e0cabd4a3462613221db44
    sha: 0c8280e8cbc5d829ac550394b41b4dfc0f94ddb6
    include-deleted-files: true
    separator: |
    files-from-source-file-separator:

    excluded-files-from-source-file-separator:

    follow-symbolic-links: true
    strip-top-level-dir: true
/usr/bin/git rev-parse --show-toplevel
/home/runner/work/github_to_confluence/github_to_confluence/main
/usr/bin/git diff --diff-filter=D --name-only 6f2c00d9ba3f031cf1e0cabd4a3462613221db44 0c8280e8cbc5d829ac550394b41b4dfc0f94ddb6

Successfully created paths-output-file: /tmp/bd94ad23-4352-414d-931c-d21b727898d4.txt
Run bash $GITHUB_ACTION_PATH/entrypoint.sh
  bash $GITHUB_ACTION_PATH/entrypoint.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GITHUB_ACTION_PATH: /home/runner/work/_actions/tj-actions/changed-files/v20
    INPUT_FILES_PATTERN_FILE: /tmp/bd94ad23-4352-414d-931c-d21b727898d4.txt
    INPUT_SEPARATOR:
    INPUT_PATH: main
    INPUT_PREVIOUS_SHA: 6f2c00d9ba3f031cf1e0cabd4a3462613221db44
    INPUT_CURRENT_SHA: 0c8280e8cbc5d829ac550394b41b4dfc0f94ddb6
    INPUT_TARGET_BRANCH: github_to_confluence~1
    INPUT_CURRENT_BRANCH: github_to_confluence
    INPUT_QUOTEPATH: true
    INPUT_OLD_NEW_SEPARATOR: ,
    INPUT_OLD_NEW_FILES_SEPARATOR:
changed-files
  Resolving repository path...
  Retrieving changes between 6f2c00d9ba3f031cf1e0cabd4a3462613221db44 (github_to_confluence~1) → 0c8280e8cbc5d829ac550394b41b4dfc0f94ddb6 (github_to_confluence)
  Getting diff...
  Non Matching changed files: specs/data-tracking/pixel-tracking/ad/new_file.md
  Non Matching modified files: specs/data-tracking/pixel-tracking/ad/new_file.md
  Added files:
  Copied files:
  Deleted files:
  Modified files:
  Renamed files:
  Type Changed files:
  Unmerged files:
  Unknown files:
  All changed and modified files:
  All changed files:
  All modified files:
  All old & new renamed files:

And what I use is:
      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v20
        with:
          since_last_remote_commit: "true"
          path: main
          files: |
            *.md
            **/*.md


Error message during install via nabu casa

HA version: 2022.02.9
Issue:
Log error when setting up the integration. Tested when setting up therough nabu casa, but I will re-test local install and confirm behaviour.
Log:
2022-03-04 11:36:56 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Configuration.yaml for netatmo Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/config_entries.py", line 327, in async_setup     result = await component.async_setup_entry(hass, self)   File "/config/custom_components/netatmo/__init__.py", line 218, in async_setup_entry     cloud.async_listen_connection_change(hass, manage_cloudhook) AttributeError: module 'homeassistant.components.cloud' has no attribute 'async_listen_connection_change'

This is fixed when upgrading HA to 2022.3.


Do you need Chinese README?

I think Chinese developer is more.So, if you want have a Chinese README.I have a little help to you.I will write it. @fastred

http://wongzigii.github.io/2017/10/24/Optimizing-Swift-Build-Times/


Moved HtmlContentIRNode from renderer to writer

Issue - #1051
@NTaylorMullen @rynowak

🆙 📅 Changed the design a bit.


update export task to not infintely loop

If task export was ran with poetry run, it was possible to error poetry in a way that never ended.

Codecov Report

Merging #27 (af978c0) into main (3aa266d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #27   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          7       7
  Lines        321     321
=====================================
  Misses       321     321

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa266d...af978c0. Read the comment docs.

...

It is really hard to go through the tasks, can we break them into sections with the help of comments and indent them multiline, this format:
[tool.taskipy.tasks]
export = {
    cmd = "echo > requirements.txt && poetry export --without-hashes >> requirements.txt",
    help = "Export installed packages in requirements.txt format"
}

When I tried this I was getting errors, that it was not available pyproject.toml file.
Theres another format, if I recall correctly,  which is [tool.taskipy.task.export] but that ends up being so verbose.

Umm alright, then just break them into sections with comment headers.

Above commit:

If its below, then its at the bottom of this list.


add Brian brianlovega

Checklist

[X ] I ran npm test locally and it passed without errors. - all 62 passed

[X ] I only edited the _data/pixels.json file. - used an empty square did not change or remove anyone

[X ] I entered the username in the pixels.json that I'm also using to create this pull request. - brianlovega
[ X] I acknowledge that all my contributions will be made under the project's license.  yep

I have tried doing a git pull to get the updated correct list - says branch is up to date every-time I run it.

Tests:       62 passed, 62 total
Snapshots:   0 total
Time:        3.489s
Ran all test suites.
➜  open-pixel-art git:(master) git pull
Already up to date.
➜  open-pixel-art git:(master) git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

gonna re-clone and start over


jackett: 0.11.687 -> 0.11.751

Motivation for this change
Latest stable release of jackett.
Fix ygg and others.
I use this version on my server.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @edwtjo @nyanloutre

@GrahamcOfBorg test jackett


Not working in outlook 2016

Hello,
I have been thinking of such macro for long time !
On my side, I'm on outlook 2016 and I try to move emails from inbox to subfolder of the same inbox.
I did multiple tries, but all I get is "no folders found" whereas the conversation view clearly shows the firsts emails being in a subfolder.

Despite only being the second issue opened, this turned out to be a duplicate of issue #1.


raw_id_field search box does not show a search field

Hi,
Thanks for all of the effort on this! It's quite the achievement!
I am using the raw id field as I cannot get any of the autocomplete widgets (DAL, Select2.. ) to work in the admin.
However, if I click on the search button it shows a page where I can select the instance but there is no search field. That makes it very difficult to find the one instance I'm looking for in my 10000 pages.
Thanks

Ah, It seems like the search box is just hidden with the default size. If I resize the window it appears so it could be there needs to be some CSS or breakpoints changed?

yep, django-material admin has no support for other 3d party django extensions for autocomplete in the admin.

Thanks for the fast response. Is there a way to get the search window to open a bit larger by default so that the search box appears automatically and the user doesn't need to resize the window? and to drop the 'centering' of the table. As you can see in the image below there is a lot of dead space on the left hand side.

Closed due #373


fix(examples): Fixed the port number in the hello_walrus_webapi.py example

The prerequisites section in the code file requires to run Walrus in the daemon mode on the port 8899:
# Prerequisites:
#
# - Run the Walrus client in daemon mode:
#   $ ../CONFIG/bin/walrus --config ../CONFIG/config_dir/client_config.yaml daemon -b <IP_ADDRESS>:8899

but the script tries to access the walrus daemon by a different port:
ADDRESS = "<IP_ADDRESS>:31415"

This PR fixes the port number in the code.

Not at all @mlegner!


Marshall/op e1s power seq

Summary:

Support oem command to control e1s.
Implement e1s power onoff sequence.

Test Plan:
-Build code: Pass

Fix merge conflict and clang-format


deps: Update Eclipse Temurin version for Jib

Align the Eclipse Temurin version used by Jib with the one used in Dockerfiles. This is a fixup for c99a428.

I have created #801 to avoid this issue in future.


Kanban Board setup

Hi, this is the link to our kanban board kanban
We are a team of two people: @boo-shehab and @Abdessittir

Hi @Abdessittir & @boo-shehab,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


MythTV 0.24 support

Please provide support for the upcoming MythTV 0.24.  MythBoxee presently fails with this:
2010-11-07 19:07:21.000 Python Database Connection: Database schema mismatch: we speak 1254 but database speaks 1264

The Boxee Box is dead, this project is dead.


Can't build .framework using  Carthage

carthage update --platform  iOS
*** Fetching Starscream
*** Checking out Starscream at "3.0.5"
*** xcodebuild output can be found in /var/folders/9g/ddww949x5vs9b740lzn5f2dw0000gn/T/carthage-xcodebuild.9YPcAo.log
The dependency graph contained a cycle:
Starscream: zlib-spm, common-crypto-spm

I delete the folder Starscream in Carthage/Checkouts, then
$ carthage update --platform iOS --new-resolver
It can build now


Z index of Toast notifications is below the space wizard mal

@pmuir - can you be a bit more specific about what you'd like changed here?  It seems to be correct if I'm understanding the title of this issue correctly.

That does look correct. Maybe it was if you click wizard? If you replay yesterdays integration demo, that's where I spotted it.

it might be a browser issue, you should try Chrome and FF

@pmuir - I reviewed the demo video and tried again on Chrome (which was the browser used in the demo) - this issue appears to have been addressed (both on prod-preview and locally when I run it).  Moving to closed...


KeyUsages are not correctly added to issued certificate secret data

Bugs should be filed for issues encountered whilst operating cert-manager.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
If we create a Certificate with some keyUsage specified, the final tls.crt data in corresponding Secret doesn't contain any user's custom keyUsage .
Expected behaviour:
The final issued x509 tls.crt data in corresponding Secret should contain user's custom keyUsage  (expect defalut keyUsage).
Steps to reproduce the bug:

Create an Secret for Issuer

kubectl create secret tls ca-key-pair \
   --cert=ca.crt \
   --key=ca.key \
   --namespace=default

Create Issuer and a Certificate with keyUsage server auth

apiVersion: cert-manager.io/v1alpha2
kind: Issuer
metadata:
  name: ca-issuer
  namespace: default
spec:
  ca:
    secretName: ca-key-pair
---
apiVersion: cert-manager.io/v1alpha2
kind: Certificate
metadata:
  name: example-com
  namespace: default
spec:
  secretName: example-com-tls
  issuerRef:
    name: ca-issuer
    kind: Issuer
  commonName: example.com
  organization:
  - Example CA
  dnsNames:
  - example.com
  - www.example.com
  keyUsage:
  - server auth

Get tls.crt data from secret

kubectl get secret example-com-tls -o yaml

LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURFekNDQWZ1Z0F3SUJBZ0lRRUVzTi9WU2l5VmNrK0xzWW9BVWxuakFOQmdrcWhraUc5dzBCQVFzRkFEQVYKTVJNd0VRWURWUVFERXdwcmRXSmxjbTVsZEdWek1CNFhEVEU1TVRBeE56QTVORFV3TkZvWERUSXdNREV4TlRBNQpORFV3TkZvd0t6RVRNQkVHQTFVRUNoTUtSWGhoYlhCc1pTQkRRVEVVTUJJR0ExVUVBeE1MWlhoaGJYQnNaUzVqCmIyMHdnZ0VpTUEwR0NTcUdTSWIzRFFFQkFRVUFBNElCRHdBd2dnRUtBb0lCQVFESmhBZGNsdE5OYmFZWDlLL1IKcUwrcjgwMEZzMWlLVFRyMHZ4OGsxOUNxNlpMT0w0by9ySEZGYkJGdUVDeENFVFFDc04reWMyV0tYamR2dkQxbQprK2ZlQlRmOUg4MThDUXZ1M01wRVlpeWFLejZpZWlHVEZsSTE3VGphTGRzcWdwdmJ2MjhVbTNhaFgvQjZqclVMClJKTUFlZm1WSUxsbjhNWWNFY0dpeUFHb1RpWFQwc25oWkxSQXcvc09QVU12V0gxcWxRNlg2UCt5ZXoxbUxVbGMKZGJMbXZqSmEyTnRtQkJseDJYL3RzcVArS0YyNmZIY2NMbnJHWDdFR2FadFBrQ01EU0VKN0xzSFVyanNJa3kzMgpzZ3o2UEVqNlZTSW5kUTN6WkVnTHhaUE5ZQ1h0UHpmZDhDZFpnRE5UZkRCekJvNGRaMzQxL3J6dDl2MjFTMkM4CjkzdEZBZ01CQUFHalNUQkhNQTRHQTFVZER3RUIvd1FFQXdJRm9EQU1CZ05WSFJNQkFmOEVBakFBTUNjR0ExVWQKRVFRZ01CNkNDMlY0WVcxd2JHVXVZMjl0Z2c5M2QzY3VaWGhoYlhCc1pTNWpiMjB3RFFZSktvWklodmNOQVFFTApCUUFEZ2dFQkFCdm8vc0xnRmM3Z0JWM05aUzFpSHR3eGxGd09hMC80b1B4bVBHSmVZcXlHdDB2b3JKR1NuWlB2ClM5MnpZMFNaY3JQaDBGbzVuZjlFRGhKcFZHWVJMVHJTd1ZZVXBUTi9zQWNYK3ExZzRrakVlOUFnN005bWluVTgKQ0J3emFqTnJyZjNzckhXek1QNGh6MVpRRlMyMDdEai9TWGFDa1lBNDk5ZTVFWDkwT1l6V1BKZ01mS1NaUjEwMwovM05zb1hsa0ExZGE3RTRKTWdMVWxhZTZkU09Rb1I3OUNKUnByNWM5M3FRdlhYVjB4QWFaenBUMkpkMGxSY3ZUCjRFZkV2YVFVVkIzZTlHZSs4d3B2cEdaNURHNnNZbEN1VVROV09MdXVtSDNab09ybFdZU0xaMVlJcmRUWm9ZaHAKRjU4R0RVdnhKNlFUSDNrSmMzWEFlbTZaeVBITWZEQT0KLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=

Decode with base64 and x509 to get certificate and we can see that server auth keyUsage is not shown in certificate which should display as TLS web server authentication I think.

Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            10:4b:0d:fd:54:a2:c9:57:24:f8:bb:18:a0:05:25:9e
    Signature Algorithm: sha256WithRSAEncryption
        Issuer:
            commonName                = kubernetes
        Validity
            Not Before: Oct 17 09:45:04 2019 GMT
            Not After : Jan 15 09:45:04 2020 GMT
        Subject:
            commonName                = example.com
            organizationName          = Example CA
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (2048 bit)
                Modulus:
                    00:c9:84:07:5c:96:d3:4d:6d:a6:17:f4:af:d1:a8:
                    bf:ab:f3:4d:05:b3:58:8a:4d:3a:f4:bf:1f:24:d7:
                    d0:aa:e9:92:ce:2f:8a:3f:ac:71:45:6c:11:6e:10:
                    2c:42:11:34:02:b0:df:b2:73:65:8a:5e:37:6f:bc:
                    3d:66:93:e7:de:05:37:fd:1f:cd:7c:09:0b:ee:dc:
                    ca:44:62:2c:9a:2b:3e:a2:7a:21:93:16:52:35:ed:
                    38:da:2d:db:2a:82:9b:db:bf:6f:14:9b:76:a1:5f:
                    f0:7a:8e:b5:0b:44:93:00:79:f9:95:20:b9:67:f0:
                    c6:1c:11:c1:a2:c8:01:a8:4e:25:d3:d2:c9:e1:64:
                    b4:40:c3:fb:0e:3d:43:2f:58:7d:6a:95:0e:97:e8:
                    ff:b2:7b:3d:66:2d:49:5c:75:b2:e6:be:32:5a:d8:
                    db:66:04:19:71:d9:7f:ed:b2:a3:fe:28:5d:ba:7c:
                    77:1c:2e:7a:c6:5f:b1:06:69:9b:4f:90:23:03:48:
                    42:7b:2e:c1:d4:ae:3b:08:93:2d:f6:b2:0c:fa:3c:
                    48:fa:55:22:27:75:0d:f3:64:48:0b:c5:93:cd:60:
                    25:ed:3f:37:dd:f0:27:59:80:33:53:7c:30:73:06:
                    8e:1d:67:7e:35:fe:bc:ed:f6:fd:b5:4b:60:bc:f7:
                    7b:45
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Key Usage: critical
                Digital Signature, Key Encipherment
            X509v3 Basic Constraints: critical
                CA:FALSE
            X509v3 Subject Alternative Name:
                DNS:example.com, DNS:www.example.com
    Signature Algorithm: sha256WithRSAEncryption
         1b:e8:fe:c2:e0:15:ce:e0:05:5d:cd:65:2d:62:1e:dc:31:94:
         5c:0e:6b:4f:f8:a0:fc:66:3c:62:5e:62:ac:86:b7:4b:e8:ac:
         91:92:9d:93:ef:4b:dd:b3:63:44:99:72:b3:e1:d0:5a:39:9d:
         ff:44:0e:12:69:54:66:11:2d:3a:d2:c1:56:14:a5:33:7f:b0:
         07:17:fa:ad:60:e2:48:c4:7b:d0:20:ec:cf:66:8a:75:3c:08:
         1c:33:6a:33:6b:ad:fd:ec:ac:75:b3:30:fe:21:cf:56:50:15:
         2d:b4:ec:38:ff:49:76:82:91:80:38:f7:d7:b9:11:7f:74:39:
         8c:d6:3c:98:0c:7c:a4:99:47:5d:37:ff:73:6c:a1:79:64:03:
         57:5a:ec:4e:09:32:02:d4:95:a7:ba:75:23:90:a1:1e:fd:08:
         94:69:af:97:3d:de:a4:2f:5d:75:74:c4:06:99:ce:94:f6:25:
         dd:25:45:cb:d3:e0:47:c4:bd:a4:14:54:1d:de:f4:67:be:f3:
         0a:6f:a4:66:79:0c:6e:ac:62:50:ae:51:33:56:38:bb:ae:98:
         7d:d9:a0:ea:e5:59:84:8b:67:56:08:ad:d4:d9:a1:88:69:17:
         9f:06:0d:4b:f1:27:a4:13:1f:79:09:73:75:c0:7a:6e:99:c8:
         f1:cc:7c:30

Anything else we need to know?:
First, I check the Certificate and corresponding CertificateRequest CRD and found that custom keyUsage is shown in Certificate but not in CertificateRequest
I checked the source code of cert-manager and found what might be the reason of missing keyUsage.
In https://github.com/jetstack/cert-manager/blob/v0.11.0/pkg/controller/certificates/sync.go#L634, which is used to create new CertificateRequest for Certificate, the keyUsage field is not passed into CertificateRequest.spec.
And in  https://github.com/jetstack/cert-manager/blob/v0.11.0/pkg/util/pki/csr.go#L258, no user keyUsage will be returned other than default usage.
Environment details::

Kubernetes version (e.g. v1.10.2): v1.15.4
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): no
cert-manager version (e.g. v0.4.0): v0.11.0
Install method (e.g. helm or static manifests): static manifests

/kind bug

Hm, that line in sync.go does look suspicious - we do have end-to-end tests covering this though.
I suspect that perhaps our WaitCertificateRequestIssuedValid function in the e2e test suite is not properly checking the x509 certificate in these test cases 😬
cc @JoshVanL

Thanks for catching this, will deserve a backport
/assign

Hi - I'm experiencing the same issue.  kubernetes v1.15.3 , cert-manager  v11.0.0 .


Add CSV parser for csv read utility

Previously we were using readline and separating the values based on a comma. This doesn't correctly parse CSVs as they often have quotes and values with commas.
Also, readline had a bug on Node v0.10 where it would not read the last entry if it did not end with a newline.
Added ability to match columns using regular expression, whilst keeping the returned data keys consistent.
Tests have been changed to use fixture files.
closes #6865

switch csv-read to use a csv-parser for greater reliability and management of strings when importing a csv
enables use of regular expression lookups to match headers

@kirrg001 updated this to use the preferred file structure. Should be good to merge


rce: Added a test for runc version

Added a test to validate that versions of runc's
github source code match the compiled one match.
Signed-off-by: Yossi Eliaz<EMAIL_ADDRESS>

Not sure if it's really needed.


Clean up file comments and update to Docsy v0.1.0

I changed comment formatting in html partials from html comments to go template comments.
I adjusted comments and contents in SCSS files to match Docsy v0.1.0.
I added a fix for the height of headers, to allow for selection of items above them.
I adjusted layouts files to match Docsy v0.1.0 templates.

I fixed the last 2 partials to be updated to Docsy v0.1.0.
I also changed the Edit button property to take the user to the file blob on GH, but the edit page directly.

Approved via slack, merging


Set 4 Decimal points to be saved in the Database

Describe the bug
I have the next use case, which is to save 4 decimal digits:
Steps To Reproduce
MoneyInput::make('total_cents')
                            ->decimals(4)

.env
MONEY_DEFAULT_LOCALE=es_MX
MONEY_DEFAULT_CURRENCY=MXN
MONEY_DECIMAL_DIGITS=4

composer.json
"php": "^8.2",
"laravel/framework": "^11.9",
"filament/filament": "^3.2",
"pelmered/filament-money-field": "^1.4",

If I insert this value = 19.5455, the saved one is 19.5500
Expected behavior and actual behavior
Let the MoneyInput save the configured decimal digits.
Additional context
I debugged the code a little and found that the MoneyFormatter use the $moneyParser     = new IntlLocalizedDecimalParser($numberFormatter, new ISOCurrencies);
in which we have 2 minor units:
'MXN' =>
  array (
    'alphabeticCode' => 'MXN',
    'currency' => 'Mexican Peso',
    'minorUnit' => 2,
    'numericCode' => 484,
  ),

I can understand that for Money calculations this configuration is correct and that at the end we need to round the final changes, so maybe this is not a bug, but for my use case is almost impossible to find a solution, ty very much.

Thanks for the report!
Sorry for the late reply. I've been very busy the last month.
I was able to reproduce this. I looks like the number formatted gets properly configured with the MONEY_DECIMAL_DIGITS var, but IntlLocalizedDecimalParser does not respect that.
The problem is in IntlLocalizedDecimalParser as you said where it does not allow for more decimals then the minor unit for that currency. The only solution I can think of to fix this would be to allow that you inject your own Decimal parser that implements Money\MoneyParser and replaces IntlLocalizedDecimalParser.
Is that something you would want?

Hi @pelmered, ty for your response.  That sure will work for me.
I also was thinking of a way only to inject the currencies:
new CurrencyList([             'MXN' => 4, // minor unit pairs             'USD' => 2 // minor unit pairs         ])
instead of the ISOCurrencies.
new IntlLocalizedDecimalParser($numberFormatter, new ISOCurrencies);
But, reading your response, I can see better control if we can implement our own Money\MoneyParser.
Regards.


⚠ MeeseOS has degraded performance

In 4634689, MeeseOS (https://aaronmeese.com) experienced degraded performance:

HTTP code: 200
Response time: 1391 ms

Resolved: MeeseOS performance has improved in 89ede5d.


Known Issue could be more clear

The known issue session could be more clear. It references "A" and "B", sometimes it says "Customer A" or "Customer B" or "Data Factory A" or "Data Factory B". These are quite clear. But in other cases it just says "A" or "B"...and its not clear what that means. I think that it means "Customer A", but that could be more clear.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 04cca896-a855-6c8a-44fa-0ba83b5f058a
Version Independent ID: 3d841099-2213-9384-a0b9-568c04663630
Content: Azure Private Link for Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/data-factory-private-link.md
Service: data-factory
Sub-service: integration-runtime
GitHub Login: @lrtoyou1223
Microsoft Alias: lle

@marlobello
Thanks for your feedback! We will investigate and update as appropriate.

@marlobello
I've delegated this to @lrtoyou1223, a content author, to review and share their valuable insights.

Doc is updated, thanks for the suggestion. #please-close.


consider implementing a simpler PLD method

@barentsen suggested that I make an issue about implementing a simpler PLD implementation
Problem description

I've found that I get better performance in some situations using a different PLD implementation
Example
This is the code that I have inside the PLDCorrector class correct method

        if simple_tom:
            if cadence_mask is None:
                cadence_mask = np.where(self.time)

            aperture = self.tpf._parse_aperture_mask(aperture_mask)

            # generate flux light curve from desired pixels
            lc = self.tpf.to_lightcurve(aperture_mask=aperture)
            lc = lc.normalize()
            lc.flux -= 1.0

            # Build the first order PLD basis
            X_pld = np.reshape(self.flux[:, aperture_mask], (len(self.flux), -1))
            X_pld = X_pld / np.sum(self.flux[:, aperture_mask], axis=-1)[:, None]

            # Build the second order PLD basis and run PCA to reduce the number of dimensions
            X2_pld = np.reshape(X_pld[:, None, :] * X_pld[:, :, None], (len(self.flux), -1))
            U, _, _ = np.linalg.svd(X2_pld, full_matrices=False)
            X2_pld = U[:, :X_pld.shape[1]]

            # Construct the design matrix and fit for the PLD model
            X_pld = np.concatenate((np.ones((len(self.flux), 1)), X_pld, X2_pld), axis=-1)
            XTX = np.dot(X_pld[cadence_mask].T, X_pld[cadence_mask])
            w_pld = np.linalg.solve(XTX, np.dot(X_pld[cadence_mask].T, lc.flux[cadence_mask]))
            pld_flux = np.dot(X_pld, w_pld)

            corrected_lc = lc.copy()
            corrected_lc.flux = lc.flux - pld_flux
            return corrected_lc

Thanks @mrtommyb. Do you have a specific target ID for which this snippet performed better?

Ok, I'll add something. Another thought that I had is that for Kepler short cadence and TESS 2-min data I think we should default to use_gp=False. The code is very slow with the number of data points in short cadence data.

Hey @mrtommyb, thanks for the feedback. With #470 merged, PLD is much faster for 2nd order even with use_gp=True. It also allows you to pass pld_order into the correct function if you want a very quick 1st order pass, or take it to higher order. I agree that it was pretty broken for TESS 2-min cadence data, so this is a much needed fix!


Make reduced storage Accessors independent of Ginkgo

Move the accessor scaled_reduced_row_major and reduced_row_major to the global folder accessor/ in order for others to use it without compiling Ginkgo. row_major was not copied (it must not be moved since it is part of the public interface).
A separate range was also implemented because it is needed to use the accessors.

label!

One preliminary question - should the CB-GMRES-specific accessor functionality be in the new folder, or should it be part of Ginkgo proper? Would all multi-precision and layout helper code needed for Ginkgo end up in the new accessor folder? One option would be to keep fundamental accessor stuff in the new folder (those which would be needed for many types of things including matrices, preconditioners, solvers etc.) going forward, but keep solver-specific accessor code in the respective core (non-public) subfolders.

Sorry, I missed this comment.
I think it should be local to each solver, unless it is truly a generic solution that can apply to all existing accessors. Otherwise, it is harder to maintain.

format!

@thoasm , if it would be possible to do that, it would be great. But I think you will need core/test/utils.hpp, but maybe you need to copy that over and not include any ginkgo headers in that.

@pratikvn I am currently setting up a custom create_independent_test, which does not link to Ginkgo in any way and only adds Ginkgo_SOURCE_DIR as the include directory. That way, if I include any public header anywhere, it fails to compile.
Thank you very much for that input, having a check if it is truly independent is quite important here (so far, I only checked that with the accessor benchmark).


chore(dev): remove parcel

After trying to fix many issues with upgrading to Parcel 2, we're thinking it may be easier to remove it completely.
Checklist

[x] address comments
[x] clean up commits
[ ] update CHANGELOG.md

@code-asher ready for a second review 🎉


Use GitHub Actions instead of Travis and AppVeyor

Requires #410, #412, and #444
Closes #286

Closing in favor of #445, which takes a different approach.


Fixing an issue where CompareMultiplayerSessions would miss changes related to Matchmaking

CompareMultiplayerSessions wasn't comparing the sessions' MatchmakingServer's Target Sessions. This would result in no MultiplayerSessionChangeTypes when compared even though the Target Sessions had  changed.

@adityatMS,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Strange Farming Station crash.

Issue Description:
When the player placed down the Farming Station and placed an axe into the interface, the server crashed with the below stack trace. Server is running SpongeForge and is running a modpack. Modpack is 'AeonPack 1.10.2' on Twitch App. SpongeForge version 5.2.0-BETA-2353.
What happens:
Place down Farming Station.
Place axe in Farming Station (tested with Diamond Axe, and modded RF axes).
Server crashes with stacktrace shown below.
When server comes back up, farming station has lost its inventory.
What you expected to happen:
Place down Farming Station.
Place axe in Farming Station.
Nothing should now happen as Farming Station has no power.
Steps to reproduce:

Place down Farming Station.
Place axe into farming station.

Affected Versions (Do not use "latest"):

EnderIO: 3.1.193
EnderCore: <IP_ADDRESS>
Minecraft: 1.10.2
Forge: <IP_ADDRESS>6

Your most recent log file where the issue was present:
https://gist.github.com/NEXUS2345/86f8f1228bea0693822582169691e265 - crash report
I hope this is enough info for you. We aren't 100% sure how this is happening due to the nature of the crash. For clarification, the modpack is developed by us for our server. If you want to get in contact with me via Discord that is possible. Thanks for any help.

Did you forget to mention the gigantic tree in your report or does it really not exist at all? ;)

Thank you for that comment. I had another talk with the player and have found out that at the time, the farming station was surrounded by a lot of fully grown spruce trees. Almost a gigantic tree as you put it. I would still imagine this is a bug however, not sure if you would agree with that though.
At least now we can inform our players to avoid setting up farming stations among large numbers of already grown trees.

Ok, so it was a "tree too big" error, not an "infinite loop" bug.
Guarding something against an input set that is too big is always hard. Even harder when you don't actually know what "too much" is. I'll have a look if I can add some limiter there. That'll probably earn me some "that tree wasn't harvested completely!!!1!!11!" reports ;) ;)

You could loop over it instead of using recursion.
That would get rid of the stack overflow.
Now I don't actually know what you're doing with that tree, but if you're just removing it, I could imagine that you could iterate the tree (literally) down to the leaves (literally) and then remove those first. next tick, there'll be less crap to iterate, so the tree gradually disappears

If you iterate the result set from the algorithm above in reverse order, you should get the elements in topological order, starting from the leaves.
Might help in preventing loss of leaves due to decay.


Option to show both total number of tabs, and number of windows

First of all, awesome extension!! Really love it :) It's really cool to see that it's possible to see the counter in the title bar, instead along side all the other extensions. That really makes it stand out!
Here is a request for yet another slightly different way of working of this extension. If you don't maintain this extension anymore, then I definitely understand that, however, if you're still accepting PRs, then I'll try to add this myself, and contribute with a PR.

What I'd like, is to also have 2 numbers visible, however, I'd like to show both the total number of tabs, and total number of windows.

@DaAwesomeP FYI I have a branch ready to make a PR, if you're interested.

Stale


Add event.dataset for ECS logging

Also use global client for better service.name handling
Related issues
Ref https://github.com/elastic/apm-agent-python/issues/1006

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1061 opened

Start Time: 2021-03-08T17:35:15.960+0000

Duration: 22 min 27 sec

Commit: ff2c637c93ea99090c590bf8eb83de2fb754ac04

Test stats :test_tube:

Test
Results

Failed
0

Passed
7940

Skipped
5735

Total
13675

Trends :test_tube:

:green_heart: Flaky test report
Tests succeeded.

Expand to view the summary

Test stats :test_tube:

Test
Results

Failed
0

Passed
7940

Skipped
5735

Total
13675


Indeterminant tooltip position with element near screen edge

Bug description:
UIB tooltip alternates between bad position and desired position. Specifically, with elements near the edge of the screen. In this case, a float-right anchor. The tooltip has default position (top).
You'll notice that changing the element tag has no affect, and neither does changing the positioning to, for example, absolute with right: 0. The same result: an indeterminant tooltip position. I think it must therefore be related to the screen edge.
I explored whether this was a caching issue. I do not believe so. I am precaching locally and it does not resolve the issue. In the plunkr, I cache the template, and have verified it is in my chrome cache by inspecting chrome://cache.
Link to minimally-working plunker that reproduces the issue:
Plunker is here.
Version Info
Angular: 1.5.3
UIBS: 1.3.2
Bootstrap: 3.3.6

This is because the text is wrapping in the tooltip causing the tooltip container to grow.  I believe the TWBS exhibits the same problem.

I think this can be solvable if we modify the $uibPosition.positionElement method to insert the element into the DOM to properly calculate the height and then calculate proper positioning I think @RobJacobs .

I should note that since this is a breaking change, this will be fixed upon major version release, so 2.0.0 at earliest (after our 1.3.3 release, we are likely to start work on it).

@RobJacobs  @wesleycho Thanks for the responses. I'll be sure to keep an eye on this ticket.

Going to close as tracked by #5918


Things to add to the webpage

[ ] Primary measure for evaluation

[ ] Sampling rate for evaluation

[ ] Disclaimer for award

[ ] Rules regarding resubmission after leaderboard shows test data

@freeman-lab
We should also acknowledge the people how collected the data explicitly.

i added these to the website


Use images from RSS feed

If rss items contain images, use those images.
See http://www.lanaken.be/rss.jsp?objectid=b6b62225-405d-4b02-ad5f-e78246774f89
Needs https://github.com/rogerthat-platform/rogerthat-backend/issues/548

I would always keep our aspect ratio of 16:6 but when they click on the image (https://github.com/our-city-app/oca-backend/issues/1174) we should show the full image

server side i would remove the ratio check (we need to check if current clients can handle those images)

Estimate 4h


Finish the game

Good work @anniavdc  !!!
Here you have some tips to finish the game:

[x] On page load, execute 'getRandomNumber' function and store the returned value on a constant to work with it later.
[x] Use ONE addEventListener for each event. If you need to execute multiple functions at once perhaps you can call them inside your unique handler
[x] Don't use a return statement in a callback to return a value because it's not possible to get the value in the addEventListener
[x] Define the logic to make the counter work
[ ] Indent and avoid extra white spaces to improve readability and prevent bugs
[ ] Remove commented code

Let me know if you have any doubts ;)
Go for it!!

@nasivuela I was working on it yesterday and I think it's all done on improvements branch, do I have to do the changes on master branch also? I also erased the steps comments.
I used several listener to check it the functions where working ok with the click but I have a doubt: I saw that I was comparing two functions but without executing them, and after I execute them, I saw that I was generating several random numbers... so I did what you are saying, stored  the return value on a constant, but about not using a return statetement in a callback, that means that I store the value in a constant inside the handler's function right? At least that's how it's working now in the improvements branch, let me know if it is ok.

@anniavdc from now on feel free to merge into master.
And the answer to your question is YES! You have done it beautifully! Actually, if you remove the log into 'getUserNumber' it will be a function with only one expression which result is returned. What about converting it to an arrow function? And then you can make it a one-line arrow function, without brackets and return keyword :D
Also here you have more improvements to keep practicing:

[ ] Make your code cleaner removing logs
[ ] Move the feedback logic to a function an execute it on each click
[ ] Move you counter logic into a function and execute it on each click
[ ] You are writing many times "userResult.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'userResult'?

Then you can improve the game as you please, here you have some ideas:

Add new feedback when the number is bigger than 100 or smaller than 0.
Manage when the user hits the button and the input is empty.
Make the input work when hitting the enter key.
Add a reset button that cleans the input, the counter, writes the initial feedback and generates a new random number to play again!
Whatever you want!

@nasivuela I've merged to master branch and I think the second improvements are done, I also tried to use more arrow functions, I hope they're ok.

Sweet!!!

PD. Watch out it's not in master yet!


Add options to choose downloaded DALI version

This PR exposes in dcokerfiles the options to choose DALI version downloaded during the backend build.


Problem about scanning bin.hex file

Hi, I just want to use securify to scan some binary file, but when I find it produce no result.
alex@ubuntu:~/Downloads/securify-master$ java -jar build/libs/securify.jar -fh ./src/test/resources/solidity/UnrestrictedEtherFlow2.bin.hex
  Attempt to decompile the contract with methods...
  Success. Inlining methods...
  Propagating constants...
  Verifying patterns...

just like above.
Is securify can not scan binary file or I did something wrong?
I will be appreciate if you can solve my problem!

Hi @Unlocku,
thank you for contacting us.
This part is not well documented.
Currently you can run:
java -jar build/libs/securify.jar --livestatusfile /tmp/out.json  -fh ./src/test/resources/solidity/UnrestrictedEtherFlow2.bin.hex

to write the results to /tmp/out.json but we will improve this.

Hi @Unlocku,
thank you for contacting us.
This part is not well documented.
Currently you can run:
java -jar build/libs/securify.jar --livestatusfile /tmp/out.json  -fh ./src/test/resources/solidity/UnrestrictedEtherFlow2.bin.hex

to write the results to /tmp/out.json but we will improve this.

thanks!


Remove Testing folder

Removed final testing file and now-empty testing folder, per advice of @pkofod.

Duplicate of https://github.com/econ-ark/HARK/pull/304


Add Guava as a dependency of the examples project

We're using it in one of the sample snippets to initialize maps in a sane way (using ImmutableMap.of(...)).
@lesv @mziccard

I'd prefer not to show Guava classes in snippets (Guava is not standard java and not all users use it or know it, adding Guava classes in snippets might just be confusing for people not familiar with them).
Also I believe this change is not necessary, Guava should already be available as it's a dependency of google-cloud-core.

Changes Unknown when pulling f9f021db5dddcb7ac598b3ca7ff7e4bd0330fe46 on jcanizales:add-guava-to-example-dependencies into ** on GoogleCloudPlatform:master**.


refactor default ints in cad code

Awesome! Quick question, why did that result in two new regression files?

Awesome! Quick question, why did that result in two new regression files?

I think I accidentally created them while playing around with the test cases...they were identical to the original ones and are not created anymore when running the tests, so I removed them