FilterFields Doc

Hi;
I couldn't find any example of using filterFields. I am trying to filter local data list in redux grid.
Could you please direct me to the example or and documentation about filterFields?
I am in a desperate situation!

@Vanderslice you got any tips?

Hi.
UI componenst are here
/src/main/webapp/js/components/tagging/progress/ProjectProgress.jsx
look for
<div className="filtersContainer">
starting from line 323.
Request for searching is send from here
/src/main/webapp/js/state/actions/actions_datasets_transformed_search.js
look for
export const fetchDatasetSearch = (query, filter, project, csrfToken, datasetId, startIndex, limit, sort) => {
starting from line 121.
The filter variable is formed in
/src/main/webapp/js/components/tagging/progress/ProjectProgress.jsx
starting from line 228
const filter = (this.state.onlyMultipleTags) ? {

Hey, sorry, didn't see a message for this for some reason. I haven't worked with local filtering too much. My original use case for filterFields was really more for passing a filterFields object through that can be consumed by your datasource function for remote sort so you're not required to bind something like that. I think my assumption was that if you are using local data and filtering you would handle the filtering of the data array and setting the new data at the time of the search.
I could see an argument for building out local search and maybe adding configurable search at some point in the future.

@bencripps @Vanderslice I didn't see any Search option in this package. One of the major requirement in Grid functionality. Do we have Search? How can I enable that?  filterFields is realted to Search? If yes, Any update on how to use filterFields(Sample piece of code).

@raamkumaarb
I found a workaround for my own situation. Hope it's helpful for you.
I use datasource to grad server data. So I stored the search keywords as a state in Store and consume it in my datasource function.(Redux store is actually a javascript object. You can consume it wherever you want.)
import store from '../../../redux/configureStore';
export const dataSource = function getData({
pageIndex, pageSize
}) {
var newState =store.getState();
const searchingFilter = newState.app.searchingFilter;
return new Promise((resolve) => {
    const request = new XMLHttpRequest();

    const config = {
        method: 'GET',
        route: '#your_route'
    };
    if (pageIndex !== undefined) {
        config.route = `${config.route}page=${pageIndex + 1}&page_size=${pageSize}&key_word=${searchingFilter}`;
    }

    request.open(config.method, config.route, true);

    request.addEventListener(
        'load', (res) => {
            const response = JSON.parse(res.target.responseText);

            // if you have more data than is being shown
            // ensure you return a total, so the pager knows
            // what paging actions are possible

            resolve({
                data: response,
                total: response.length > 0 ? response[0].total : 0
            });
        }
    );

    request.send(config.data || null);
});

};

I has encountered the same problem.I find some action constants about filter in ActionTypes.js ,for example:
var SET_FILTER_VALUE = exports.SET_FILTER_VALUE = '@@react-redux-grid/SET_FILTER_VALUE';
var FILTER_DATA = exports.FILTER_DATA = '@@react-redux-grid/FILTER_DATA';
var CLEAR_FILTER_LOCAL = exports.CLEAR_FILTER_LOCAL = '@@react-redux-grid/CLEAR_FILTER_LOCAL';
var CLEAR_FILTER_REMOTE = exports.CLEAR_FILTER_REMOTE = '@@react-redux-grid/CLEAR_FILTER_REMOTE';
var SHOW_FILTER_MENU = exports.SHOW_FILTER_MENU = '@@react-redux-grid/SHOW_FILTER_MENU';
var SET_FILTER_MENU_VALUES = exports.SET_FILTER_MENU_VALUES = '@@react-redux-grid/SET_FILTER_MENU_VALUES';
but I don't find out the actions and reducers to implements these actions and I don't find the state where the filter object or function to be hold yet.  Mybe, @bencripps bencripps has a plan to complete it, but now ,it's not available to use.

@qingmulanyun Thanks a lot for your workaround. Let me try with this. :-)

The filter constants were previously used when the Grid implemented a filter bar -- this has since been removed :(
I think the current expectation is that users manage their own filter states (i.e. build a component with actions) that triggers a filtering of the data that gets passed into the grid.

I've removed all usages of the filter constants (there wasn't much since that feature was deleted a long time ago).


Handle indexer backpressure in Kakfa source

Description
Overflow to buffer when the consumer channel is full and keep polling at least once per max.poll.interval.ms. Drain buffer to channel when not full.
How was this PR tested?

Added tests
Ran cargo test --manifest-path quickwit/Cargo.toml --all-features -p quickwit-indexing

I am closing this PR for now. Backpressure is better handled downstream, and we should no longer not poll the for a duration that exceeds max.poll.interval.ms (if set sufficiently high). I will open another PR that tests the default value.


[CommonHTML] [Firefox] Anomaly with spacing before and after \text

The issue can be seen in https://cdi2tp.math.tecnico.ulisboa.pt/texto/10 with Firefox 52 on Linux Mint. This may be very browser, version, OS,..., specific problem. Absent from Firefox 51 on Windows or Firefox 52 on Android.

Spacing after the phrase "Existe um caminho unindo" in a displayed formula has disappeared although you can see it on mouseover.

Thanks for the report.
I see this on FF 51 on Windows 10 actually (and Linux) but not on macOS.
I also only see this for the CommonHTML output.

For the record, I don't see it with FF's dev channel on Win10, so it might be a browser bug with an upcoming fix.

The issue is not restricted to Firefox.  Here's what's going on:  because you are using mtextFontInherit:true, MathJax must measure the size of the text so that it knows how much space it takes up.  It gets the size in pixels, and must convert that to em's (which is what it uses internally).  This is done using the em-size of the font surrounding the math, but this value is determined empirically and so is only an approximation.  For a very wide item (like a long string of text), the inaccuracy of the em-size has a noticeable effect on the size that MathJax determines, and so the computed size is somewhat far off from the actual size.  The CommonHTML output forces the size of the items it measures to be the computed size (so that if it is off, that doesn't have ripple effects to the sizes of things that surround it).  So what you are seeing here is CommonHTML trying to force the long line of text to fit the size it thinks it is rather than the size it actually is.
One possible solution might be to have CommonHTML not set the width for items over a certain size, where the inaccuracy in the em-size measurements are magnified to such an extent that it becomes problematic, as in this case.  Or a second measurement could be taken after the size is set to see how far off it is (though that would cause an additional reflow performance hit).

The issue1718 branch of my fork of MathJax works around this.

==> Merged

==> In testsuite
MathMLToDisplay/Presentation/TokenElements/mtext/issue1718.html


docs, Add runbook for KubeMacPoolDown

Signed-off-by: Ram Lavi<EMAIL_ADDRESS>

/hold
still need to check that it works smoothly

/hold cancel
@sradco ready for review

/lgtm

/lgtm
/approve


Update popup need additional info.

I've had a few users reporting some confusion as to why they keep seeing the 'This version of sondehub is out of date' popup.
The answer is that they probably need to clear our their browser cache, or do a shift-refresh, but the pop just says to refresh.
It might be good to modify the text to provide more detail on what to do.

sondehub index page no longer sets cache-control so hopefully this won't be required.


Meilisearch Pod fails on Openshift due to root permission denial

We are using Openshift, and none of the pods have root access (for security reasons). This means the line in the Dockerfile CMD ["/bin/sh" "-c" "./meilisearch"] fails with message Error: Permission denied (os error 13), and the meilisearch fails with a CrashLoopBackoff error.
We were able to reproduce this behavior by creating a debug pod and running the command with the same result :
~ $ /bin/sh -c ./meilisearch
Error: Permission denied (os error 13)

Do you know why root access is needed for this operation ? Do you know of any workarounds ?
Thanks in advance.

Hi @NathalieNX,
Thanks for raising this issue but I need some details about the context:

Which version of Meilisearch did you use?
Which version of meilisearch-kubernetes did you use?
Which docker file are you referring to?
Did you check the permission of your binary file?

Thanks for the questions :

Meilisearch version v0.19.0 (specified in the meilisearch-kubernetes charts/meilisearch/Chart.yaml)
meilisearch-kubernetes version 0.1.14 (latest, released march 24th), included as a dependency in my project Helm chart
The dockerfile I am referring to is the one I found on Dockerhub for Meilisearch v0.19.0 (line 8 ; this is the command I tried to reproduce in the debug pod, see above) : https://hub.docker.com/layers/getmeili/meilisearch/v0.19.0/images/sha256-c01c7ef570667ded0ae0c930d7a0eafc1fa7222318cbc701b86816c3b8f5d96e?context=explore
testing the configuration locally shows the following permissions :

$ kubectl exec -it test-ms-local-meilisearch-0 -- sh
/ # ls -la
total 301348
drwxr-xr-x    1 root     root          4096 May 10 16:09 .
drwxr-xr-x    1 root     root          4096 May 10 16:09 ..
-rwxr-xr-x    1 root     root             0 May 10 16:09 .dockerenv
drwxr-xr-x    2 root     root          4096 Apr 23  2020 bin
drwxr-xr-x    4 root     root          4096 May 10 16:09 data.ms
drwxr-xr-x    5 root     root           360 May 10 16:09 dev
drwxr-xr-x    1 root     root          4096 May 10 16:09 etc
drwxr-xr-x    2 root     root          4096 Apr 23  2020 home
drwxr-xr-x    1 root     root          4096 Apr 23  2020 lib
drwxr-xr-x    5 root     root          4096 Apr 23  2020 media
-rwxr-xr-x    1 root     root     308505312 Feb  9 15:01 meilisearch
drwxr-xr-x    2 root     root          4096 Apr 23  2020 mnt
drwxr-xr-x    2 root     root          4096 Apr 23  2020 opt
dr-xr-xr-x  218 root     root             0 May 10 16:09 proc
drwx------    1 root     root          4096 May 11 09:59 root
drwxr-xr-x    1 root     root          4096 May 10 16:09 run
drwxr-xr-x    1 root     root          4096 Feb  9 15:02 sbin
drwxr-xr-x    2 root     root          4096 Apr 23  2020 srv
dr-xr-xr-x   13 root     root             0 May 10 16:09 sys
drwxrwxrwt    2 root     root          4096 Apr 23  2020 tmp
drwxr-xr-x    1 root     root          4096 Apr 23  2020 usr
drwxr-xr-x   11 root     root          4096 Apr 23  2020 var

I hope this helps, please tell me if you need more details.

Hi @NathalieNX,
Thanks for your info. Everything looks good to me. meilisearch will never need root rights to run just write rights.
So I guess the problem came from the fact that in Openshift the image is built as root and needs to run as the root user.
But I suppose recommended best practice is to avoid containers that need to run as root.
Hope this will help you

I'm closing this issue because it is outdated. Feel free to reopen it if you need it.


Support "Move to new file" action

Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like
In Typescript, there is an action called "move to a new file", which

moves a function / class / type to a new file,
carries any imports with it,
removes imports from the original file which are no longer used
adds an import to the original file to get the moved declaration

It would be great if this action were available in Python
Additional context
N/A

this is done now.


Terraform configuration for scheduled exports

Includes scheduling execution of sinopia-export task once per week.

is there a particular day this should be scheduled for?  If not, I'll set it to Sundays

sinopia-export fargate task is set to run on  Sundays midnight GMT via terraform on dev environment.


Ethereum subscription by tags

Currently, we require users to know which addresses they want information about when subscribing to ethereum_blockchain and ethereum_txpool events.
This introduces a lot of friction into the subscription flow as most users do not have a ready list of addresses they care about. Rather, most users know the kind of content they would like to subscribe to - e.g. NFT market activity, ERC20 token activity, exchange transactions, etc.
We should add support for subscription to ethereum_blockchain and ethereum_txpool events by this kind of activity.

Next steps:

[ ] @peersky to define UX
[ ] @Andrei-Dolgolev to create design doc about how to add semantic (kind) information to events - @Yhtiyar to review

Timeline:

[ ] Design docs reviewed by Friday, September 3, 2021.
[ ] Implementation started week of September 6, 2021.

For now, we will use slight modification to existing UX by adding a form builder using subscription type data.

Work is complete and change is in production. It is not enabled on frontend yet.


gdu: 5.13.2 -> 5.14.0

https://github.com/dundee/gdu/releases/tag/v5.14.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 174621 run on x86_64-linux 1

1 package built:

gdu


[BUG] CosmosDB ExtendedResourceProperties is not referenced in the code

https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/cosmosdb/Microsoft.Azure.Management.CosmosDB/src/Generated/Models/ExtendedResourceProperties.cs
The data model ExtendedResourceProperties should not exist as a separate object. It is not used anywhere.

Closing this out; the package referenced by this issue has been deprecated and is superseded by Azure.ResourceManager.CosmosDB.


enhance: backup service (WIP)

Explanation
This is not a ready PR, it is for discussing the proposed changes in the backup services.
This markdown file has thoughts and feedback about the backup service that we already have and how we can enhance it. https://github.com/CryptKeeperZK/ck-team-discussions/blob/main/Backup.md

More Information

Screenshots/Screencaps

Manual Testing Steps

Pre-Merge Checklist

[ ] PR template is filled out
[ ] IF this PR fixes a bug, a test that would have caught the bug has been added
[ ] PR is linked to the appropriate GitHub issue
[ ] PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

Moved to #305


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_bf5d3b89-8849-4791-aae4-fe6fe87c0cb6/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_bf5d3b89-8849-4791-aae4-fe6fe87c0cb6.git

Docs Build status updates of commit 0c5292a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Reload peer-pods-cm envs in cloud-api-adaptor daemonset

The cloud-api-adaptor daemonset was launched via: https://github.com/confidential-containers/cloud-api-adaptor/blob/main/entrypoint.sh
Which was defined in daemonset https://github.com/confidential-containers/cloud-api-adaptor/blob/main/install/yamls/caa-pod.yaml and the env comes from: https://github.com/confidential-containers/cloud-api-adaptor/blob/main/install/yamls/caa-pod.yaml#L30
It's common case that the env chanes in peer-pods-cm configmap but no cloud-api-adaptor binary changes like, PeerPod image changed, the PeerPod profiles changed etc.
Can we have a way to reload these env and reload it in cloud-api-adaptor with or without recreating the pod?
Options might be:

Reload controller like: https://github.com/stakater/Reloader/
Reload sidecar like vault
...

We should augment the peerpodconfig controller to watch for the configmaps and on any change recreate the daemonset.
The following code needs to be extended - https://github.com/confidential-containers/cloud-api-adaptor/blob/main/peerpodconfig-ctrl/controllers/peerpodconfig_controller.go#L278

We should augment the peerpodconfig controller to watch for the configmaps and on any change recreate the daemonset. The following code needs to be extended - https://github.com/confidential-containers/cloud-api-adaptor/blob/main/peerpodconfig-ctrl/controllers/peerpodconfig_controller.go#L278

That would be distruptive to existing peerpods no? Or is that the appropriate response, if configuration changes remake all the peerpods?

Yes, it'll be indeed disruptive. The pods will be recreated as the original pods will go to "error" state (at least that's what I recall).

I think the direct cause that triggers pod VM recreation is that failures in some kata agent APIs.
When a kata shim creates a new containers, it calls some long-running requests including WaitProcess, ReadStdout, and ReadStderr. These calls will return with failures when cloud-api-adaptor restarts, since the connection between the kata-shim and the cloud-api-I think the direct cause that triggers pod VM recreation is that failures in some kata agent APIs. When a kata shim creates a new containers, it calls some long-running requests including WaitProcess, ReadStdout, and ReadStderr. These calls will return with failures when cloud-api-adaptor restarts, since the connection between the kata-shim and the cloud-api-adaptor is lost. To avoid this issue, we need to add a retry logic in kata shim.
https://github.com/confidential-containers/cloud-api-adaptor/blob/7322a2ff36d57feec125ea1a4aadde3714c842d8/pkg/util/agentproto/redirector.go#L131
This is just my guess, and there is a possibility that the ttrpc client in kata shim does not return an error, and automatically reconnects to the server when its connection is lost.
Even after we fix the above problem, we still have another fundamental limitation in our design. cloud-api-adaptor does not currently support restarting, since it has on-memory states. The sandboxes map in the cloudService struct manages the mapping between sandboxID and peer pod VM instance. When cloud-api-adaptor restarts, this mapping is lost. When cloud-api-adaptor receives new requests, it cannot forward the requests to an appropriate pod VM.
https://github.com/confidential-containers/cloud-api-adaptor/blob/7322a2ff36d57feec125ea1a4aadde3714c842d8/pkg/adaptor/cloud/types.go#L41
This issue is described here. https://github.com/confidential-containers/cloud-api-adaptor/issues/375#issuecomment-1334894017

shall we choose an approach to reload the configuration for cloud-api-adaptor non-disruptively vs restart cloud-api-adaptor without recreating the PeerPod instance and keep it still running

I think it is better if restarting cloud-api-adaptor daemonset is non-disruptive when its configuration is NOT changed.
In the case of configuration changes, it is probably difficult to determine whether existing pod VMs should be recreated or not. For example, if API key is changed, I am not sure how cloud-api-adaptor handles existing pod VMs.

We talked about an approach on the meeting yesterday. Like below:
Daemonset supports rolling update but it can not guarantee all PeerPods get recreated before move to next nodes upgrade. Maybe it's helpful if we add a containers postStart hook to check whether all PeerPods get recreated and running after caa upgraded on one node. In this way, we can avoid the complete down time window on all nodes (caa upgraded but PeerPods instance not recreated yet). Alternative might be liveness or readiness probes if the containers lifecycle hooks does not work.

I think the correct approach here is using a readiness probe. The rolling update will not proceed until the containers are ready.

Close it and created https://github.com/confidential-containers/cloud-api-adaptor/issues/1322 for the implementation.


Make it easy to find drafts and submit them

Description

As a user i am not able to see my drafts and follow through with the submissions.
We can move the Choose from drafts

on the right with the submitted objects under different sections

We can also add to the button group there Submit so that we have Submit, Continue, Delete
Note: other ideas are welcomed
DoD (Definition of Done)

Move drafts to a location where users can easily find them
Testing

Unit and Integration testing

We can also add to the button group there Submit so that we have Submit, Continue, Delete
How would we like to handle Submit button click on drafts that aren't eligible for submission? E.g. draft can be missing required fields.

I'm thinking couple options:

We can try to validate draft data on Submit button click and show a message if form needs to be edited before submission.
Force user to edit form if user want's to submit draft

2nd option sound easier and has implication that the user actually sees the form when they try to submit it.
personally i would go with that.

This however can affect performance, since we need to validate data before sending it to object API

2nd option sound easier and has implication that the user actually sees the form when they try to submit it.
personally i would go with that.

Sounds good to me since validating draft data affects performance at some level. Also trying to submit invalid form in edit view gives better sight to what needs to be changed.


Improve cache support for APIs

Problem
The relay support caching for some endpoints and not others. We should assess which would no benefit from it and which may need TTL times updated based on usage
Solution
Add cache support to heavily utilized methods in which the response does not change

[ ] Assess endpoint metrics, what are the heaviest utilized
[ ] Assess endpoint responses, which are static based on params which do not yet have caching
[ ] Add caching logic with consideration for mirror node refresh times to ensure details are still fresh

[ ] #1059
[ ] eth_getBlockByHash
[ ] #1057
[ ] eth_chainId
[ ] eth_feeHistory
[ ] net_version

Alternatives
No response

Additionally, perhaps the mirror node could support an event stream (callbacks) that could notify of interesting events that would directly inform cache invalidation.  E.g., new block added.


Code completion does not prompt the "printf" function

The code completion in the 'C' file does not prompt the printf function, but works fine in the 'CPP' file.
test.c

test.cpp

compile_flags.txt
-target
x86_64-w64-mingw32

Well, that's embarassing. I can reproduce on linux (debian):
~/llvmbuild-opt/bin/clangd-indexer /usr/include/stdio.h -format=yaml -extra-arg-before=-xc-header | grep printf
Name:            vdprintf
Name:            _IO_vfprintf
Name:            dprintf

C++ works fine:
~/llvmbuild-opt/bin/clangd-indexer /usr/include/stdio.h -format=yaml -extra-arg-before=-xc++-header | grep printf
Name:            obstack_vprintf
Name:            vdprintf
Name:            printf
Name:            vsprintf
Name:            _IO_vfprintf
Name:            dprintf
Name:            asprintf
Name:            __asprintf
Name:            vprintf
Name:            sprintf
Name:            snprintf
Name:            vsnprintf
Name:            obstack_printf
Name:            fprintf
Name:            vfprintf
Name:            vasprintf

I guess we haven't been writing a lot of C recently. Will dig into it, thanks for the report!

OK, the problem is related to the name printf itself: void printffff(); indexes in C++ and C mode, void printf() indexes in C++ mode only.
Guess: related to the lack of overloading/namespaces in C, so the compiler can simply ignore any decl whose name matches a builtin?

I would expect it to be similar to: https://github.com/clangd/clangd/issues/15.
Since we don't deserialize everything from preamble, we are most likely missing "printf".
If you try code-completing after writing printf(to force deserialization of decl), it should work.

Thank you for your reply.
Yes, most built-in functions, such as scanf and printf, do not appear in the code completion list.

Fixed in r358098.
@kadircet indeed as we don't deserialize, we won't get this result from the AST (unless the full name is typed).
We should be getting this result from the dynamic index, but it wasn't being indexed. The reason is that in C, the declaration is treated as a redecl of the built-in function, which has the "implicit" bit set.
We don't index implicit symbols, but the fix is to check the implicit bit on the redecl, not the original decl (I think).


Test for containerIdx added

Coverage increased (+4.6%) to 34.661% when pulling e694d0adf06845e7086a0aa9282a482c03690101 on lukasmacko:master into 256126ca7740eb09906b36d91689d6179e3ebb49 on contiv:master.


Combined Reference Data.

we scrap the combined ref and only keep and update the all-variants-we-know-about-from-all-our-callsets-and-reference-data HT.

This is actually an open question we never landed on an answer to. Then last we discussed I took an action item to talk to Tim and determine feasibility, and the result was that it is feasible not to maintain 2 tables. Lets discuss further at Tuesdays meeting


Support Date type

IBM-Swift/Swift-Kuery#63

Codecov Report

Merging #64 into master will decrease coverage by -2.67%.
The diff coverage is 58.46%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   95.72%   93.06%   -2.67%
==========================================
  Files          35       35
  Lines        2857     3116     +259
==========================================
+ Hits         2735     2900     +165
- Misses        122      216      +94

Impacted Files
Coverage Δ

...s/SwiftKuery/ColumnAndExpressions_Extensions.swift
82.24% <0%> (-12.34%)
:x:

Sources/SwiftKuery/Predicate.swift
90.62% <100%> (+0.62%)
:white_check_mark:

Sources/SwiftKuery/Utils.swift
92.85% <100%> (+0.75%)
:white_check_mark:

Sources/SwiftKuery/QueryBuilder.swift
70% <100%> (+1.03%)
:white_check_mark:

...uery/Subqueries_GlobalFunctionsAndExtensions.swift
100% <100%> (ø)
:white_check_mark:

...s/SwiftKuery/FilterAndHaving_GlobalFunctions.swift
100% <100%> (ø)
:white_check_mark:

Sources/SwiftKuery/ConditionalClause.swift
85.96% <100%> (+1.05%)
:white_check_mark:

Sources/SwiftKuery/ScalarColumnExpression.swift
100% <100%> (ø)
:white_check_mark:

...urces/SwiftKuery/SpecialOperators_Extensions.swift
92.8% <50%> (-3.93%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9880a65...33ef9e2. Read the comment docs.


Replacing a node breaks indent

Maybe a bug, could also be a misunderstanding on my part.
Given a simple, but un-pretty XML document. Thanks to parsing with &:noblanks it can be pretty printed like so:
require 'nokogiri'
xml = <<~END
  <root>
  <first><child>foo</child></first>
  <second><child>bar</child></second>
  </root>
END
doc = Nokogiri.XML(xml, &:noblanks)
puts doc.to_xml(indent: 2)

<?xml version="1.0"?>
<root>
  <first>
    <child>foo</child>
  </first>
  <second>
    <child>bar</child>
  </second>
</root>

I now would like to replace the second node with some new un-pretty markup, however, this does away with the pretty printing:
require 'nokogiri'
xml = <<~END
  <root>
  <first><child>foo</child></first>
  <second><child>bar</child></second>
  </root>
END
doc = Nokogiri.XML(xml, &:noblanks)
xml = <<~END
  <third>
  <child>baz</child>
  </third>
END
doc.at_css('second').replace(xml)
puts doc.to_xml(indent: 2)

<?xml version="1.0"?>
<root><first><child>foo</child></first><third>
<child>baz</child>
</third>
</root>

Things look a little better when the trailing whitespace of the replacing markup is stripped, however, indent is still off:
require 'nokogiri'
xml = <<~END
  <root>
  <first><child>foo</child></first>
  <second><child>bar</child></second>
  </root>
END
doc = Nokogiri.XML(xml, &:noblanks)
xml = <<~END
  <third>
  <child>baz</child>
  </third>
END
doc.at_css('second').replace(xml.chomp)
puts doc.to_xml(indent: 2)

<?xml version="1.0"?>
<root>
  <first>
    <child>foo</child>
  </first>
  <third>
<child>baz</child>
</third>
</root>

The only workaround is to remove all whitespace between the nodes which yields the expected result:
require 'nokogiri'
xml = <<~END
  <root>
  <first><child>foo</child></first>
  <second><child>bar</child></second>
  </root>
END
doc = Nokogiri.XML(xml, &:noblanks)
xml = "<third><child>baz</child></third>"
doc.at_css('second').replace(xml)
puts doc.to_xml(indent: 2)

<?xml version="1.0"?>
<root>
  <first>
    <child>foo</child>
  </first>
  <third>
    <child>baz</child>
  </third>
</root>

Is there a (better) way to replace a node and maintain correct indent or could this be a bug?

% nokogiri -v
# Nokogiri (1.13.4)
    ---
    warnings: []
    nokogiri:
      version: 1.13.4
      cppflags:
      - "-I/Users/me/.gem/ruby/3.1.0/gems/nokogiri-1.13.4-arm64-darwin/ext/nokogiri"
      - "-I/Users/me/.gem/ruby/3.1.0/gems/nokogiri-1.13.4-arm64-darwin/ext/nokogiri/include"
      - "-I/Users/me/.gem/ruby/3.1.0/gems/nokogiri-1.13.4-arm64-darwin/ext/nokogiri/include/libxml2"
      ldflags: []
    ruby:
      version: 3.1.2
      platform: arm64-darwin21
      gem_platform: arm64-darwin-21
      description: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [arm64-darwin21]
      engine: ruby
    libxml:
      source: packaged
      precompiled: true
      patches:
      - 0001-Remove-script-macro-support.patch
      - 0002-Update-entities-to-remove-handling-of-ssi.patch
      - 0003-libxml2.la-is-in-top_builddir.patch
      - 0004-use-glibc-strlen.patch
      - 0005-avoid-isnan-isinf.patch
      - 0006-update-automake-files-for-arm64.patch
      - '0008-htmlParseComment-handle-abruptly-closed-comments.patch'
      - '0009-allow-wildcard-namespaces.patch'
      - 0010-Revert-Different-approach-to-fix-quadratic-behavior.patch
      libxml2_path: "/Users/me/.gem/ruby/3.1.0/gems/nokogiri-1.13.4-arm64-darwin/ext/nokogiri"
      memory_management: ruby
      iconv_enabled: true
      compiled: 2.9.13
      loaded: 2.9.13
    libxslt:
      source: packaged
      precompiled: true
      patches:
      - 0001-update-automake-files-for-arm64.patch
      datetime_enabled: true
      compiled: 1.1.35
      loaded: 1.1.35
    other_libraries:
      zlib: 1.2.12
      libiconv: '1.16'
      libgumbo: 1.0.0-nokogiri

After some more research, it seems as if pretty printing is not baked-in as such and &:noblanks in combination with to_xml(indent: n) only works if the document is not heavily altered.
If so, the way to go would rather be a XSL transformation right before the XML document is to_xmled, something along the lines of this article.
I leave this issue open in case the above statement is incorrect, feel free to close thie issue if it isn't. :wink:

@svoop Thanks for asking these questions. Nokogiri is built on top of libxml2, and the serialization behavior you're seeing comes from there.
Specifically, the logic libxml2 uses to control indentation/formatting is in the xmlNodeDumpOutputInternal function in "xmlsave.c":
https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/xmlsave.c#L854
Check out where unformattedNode is set:
https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/xmlsave.c#L948-953
and you can see that if any of a node's children are a) text, b) cdata, or c) an entity reference, then the node (and, recursively, its children) are considered to be "unformatted" and that subtree is serialized literally.
You can see this effect above when you remove the whitespace text nodes that would be children of root and then see that the siblings of the inserted node are then considered to be "formatted" and are serialized with indentation and formatting.
Hope this helps explain what's going on.

@flavorjones Thanks for your explication, good to know what's actually going on downstream... and hopefully find ways to work around it. Formatting is a cosmetic problem, I know, but since I'm dealing with XML files which contain sometimes funky content (in terms of "what the heck does this try to code in the first place"), having pretty printed automated tests are somewhat important.

@svoop If it's helpful, my recommendation to folks is usually to assert on the structure of the document and not the format.

How do you do so in a human readable manner (with minimal overhead)?
My tests currently look as follows (subject from factory):
describe :to_xml do
  it "builds correct complete AIXM" do
    _(subject.to_xml).must_equal <<~END
      <!-- Organisation: FRANCE -->
      <Org source="LF|GEN|0.0 FACTORY|0|0">
        <OrgUid region="LF">
          <txtName>FRANCE</txtName>
        </OrgUid>
        <codeId>LF</codeId>
        <codeType>S</codeType>
        <txtRmk>Oversea departments not included</txtRmk>
      </Org>
    END
  end
end

And that's a small one, other AIXM features or the entire documents are pretty large.

It depends on what you care about. My point is that you don't (or at least you shouldn't) care about the bytes in a serialized form of the document, particularly if whitespace is largely semantically meaningless to the consumer.
One approach, which admittedly isn't amazingly readable, is to assert on the things you care about like this:
#! /usr/bin/env ruby

require "nokogiri"

require "minitest/autorun"
require "minitest/spec"

describe "how I test XML doc structure" do
  it "looks like this" do
    xml = <<~XML
      <root>
        <thing>
          <!-- Organisation: FRANCE -->
          <Org source="LF|GEN|0.0 FACTORY|0|0">
            <OrgUid region="LF">
              <txtName>FRANCE</txtName>
            </OrgUid>
            <codeId>LF</codeId>
            <codeType>S</codeType>
            <txtRmk>Oversea departments not included</txtRmk>
          </Org>
        </thing>
      </root>
    XML

    doc = Nokogiri::XML(xml)
    node = doc.at_css("thing")

    # assert on children (note that whitespace is "text")
    assert_equal(["text", "comment", "text", "Org", "text"], node.children.map(&:name))

    # assert on non-blank children
    assert_equal(["comment", "Org"], node.children.reject(&:blank?).map(&:name))

    # assert on semantic structure and text contents
    (node > "Org").first.tap do |n|
      assert_equal("LF|GEN|0.0 FACTORY|0|0", n["source"])
      assert_equal(["OrgUid", "codeId", "codeType", "txtRmk"],
                   n.children.reject(&:blank?).map(&:name))
      assert_equal("LF", (n > "OrgUid").first["region"])
      assert_equal("LF", (n > "codeId").inner_text)
      assert_equal("S", (n > "codeType").inner_text)
      assert_equal("Oversea departments not included", (n > "txtRmk").inner_text)
    end
  end
end

Another shotgun approach might be to use libxml to parse the actual and the expected, and the compare their serialized versions (that is, round-trip the output) like this:
#! /usr/bin/env ruby

require "nokogiri"

require "minitest/autorun"
require "minitest/spec"

describe "how I test XML doc structure" do
  it "roundtrips" do
    # imagine this is the output from your code
    actual = <<~XML
      <root><thing>
      <!-- Organisation: FRANCE -->
      <Org source="LF|GEN|0.0 FACTORY|0|0">
      <OrgUid region="LF"><txtName>FRANCE</txtName></OrgUid>
      <codeId>LF</codeId>
      <codeType>S</codeType>
      <txtRmk>Oversea departments not included</txtRmk>
      </Org>
      </thing>
      </root>
    XML

    expected = <<~XML
      <root>
        <thing>
          <!-- Organisation: FRANCE -->
          <Org source="LF|GEN|0.0 FACTORY|0|0">
            <OrgUid region="LF">
              <txtName>FRANCE</txtName>
            </OrgUid>
            <codeId>LF</codeId>
            <codeType>S</codeType>
            <txtRmk>Oversea departments not included</txtRmk>
          </Org>
        </thing>
      </root>
    XML

    actual_doc = Nokogiri::XML(actual, &:noblanks)
    expected_doc = Nokogiri::XML(expected, &:noblanks)

    assert_equal(expected_doc.to_xml, actual_doc.to_xml)
  end
end

There's also a discussion on how using Ruby 3's pattern matching might help in this situation:
https://github.com/sparklemotion/nokogiri/discussions/2360
but that still needs a lot of thought before I start implementing it.

@flavorjones The latter appears more feasible, however, I'll just bookmark and shelve this for the moment. Since I'll be passing builder objects through my models once the migration from the "builder" gem to Nokogiri's builder is complete, only one or two edge cases (in terms of formatting) should be left... if any at all. But it's certainly a good point!


How can I get the current directory path in influx CLI? say for example to backup a DB so that it can be stored on a drive.

URL for relevant page?
What products and version are you using?
Where did you look before opening the issue?

Hi @sethakota, thank you for your question!
No specific command to view directory in influx CLI.
To view the current InfluxDB data directory path, use the influxd config command.  By default, the data directory is stored in /var/lib/influxdb/data.
To back up and restore a specific database, you can use influxd backup and influxd restore. For details, check out https://docs.influxdata.com/influxdb/v1.7/administration/backup_and_restore/.


updated and new tutorials and data files

closing to remove the large mnist tutorial and its large supporting db files... will refactor...


chore: relocate tests and test fixtures

@yurydelendik this is not finished yet, but I wanted to hear your thoughts first on the
proposed changes. WDYT?
Move the unit and integration test files into the test/ folder and
make sure they all have the test.ts suffix. Also move the test
fixtures into the test/__fixtures__/ folder.
Store the test expectations as Jest snapshots, and leverage
the existing functionality provided by Jest to manage (and
in particular rebaseline) the expectations easily.

this is not finished yet, but I wanted to hear your thoughts first on the
proposed changes.

I'm good with the folder structure change. Good to go once CI is green.

Great, I've split the folder structure change into a smaller change.

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(eslint): eslint idea compatibility

#1566

I am not sure. I think it's better to have IDEA fix it instead of reverting the version on our side

@antfu will be fixed in 2022.2.3 so there is no need to update here: https://youtrack.jetbrains.com/issue/WEB-57089

@antfu will be fixed in 2022.2.3 so there is no need to update here: https://youtrack.jetbrains.com/issue/WEB-57089
EDIT: it is 2 versions from current, this will take time... and it is a bad experience since we lose dx

+1

@antfu IntelliJ 2022.2.2 released and seems the error is gone, so we can revert this.


Allow "+" and "=" characters in values of SpecificAssetIds in order to support base64 encoded values

Problem description
I don't want to expose SpecificAssetIds' values directly while creating Digital Twin. So, I want to use base64 encoded value as value in SpecificAssetIds
Solution Proposal
We can just edit the regrex for validation of value of specificAssetIds which will allow base64 encoded value.
Note
This issue resembles to an issue in tractus-X. issue link: https://github.com/eclipse-tractusx/sldt-digital-twin-registry/issues/391

@richaashara Seems this issue is not relevant any longer? See discussion in https://github.com/eclipse-tractusx/sldt-digital-twin-registry/issues/391

@BirgitBoss ,
We can close this issue now.

Thanks


Optionally run pip3 install when the file is present.

Optionally run pip3 install when the file is present.

Is this to address an error you've experienced?

Is this to address an error you've experienced?

Hello, apologies for the delay in my response.
I don't recall exactly the details of my experience, but I do remember that the action was looking for requirements.txt on my project (NodeJS)

Hello, apologies for the delay in my response.
I don't recall exactly the details of my experience, but I do remember that the action was looking for requirements.txt on my project (NodeJS)

Got it - I've only tested this Action with Python, not Node.js. Were you able to use the Action with Node.js after making the changes here?

Got it - I've only tested this Action with Python, not Node.js. Were you able to use the Action with Node.js after making the changes here?

Got it - I've only tested this Action with Python, not Node.js. Were you able to use the Action with Node.js after making the changes here?

I did, I ran cdk synth

Got it - I've only tested this Action with Python, not Node.js. Were you able to use the Action with Node.js after making the changes here?

I did, I ran cdk synth


Allow to set the font family and sizes on the global theme

Clear and concise description of the problem
As a developer using Histoire I want to use a brand font family and sizes so that the component library can be styled in a way that fits the design system of the brand.
Suggested solution
Currently in the global theme you can set the colors (which is already great) and the logo. As it seems, Histoire is using tailwind css to style the library. In that case it would be a possibility to set the fontFamily, fontSizes and fontWeights within the global theme.
Alternative
No response
Additional context
I really appreciate the value that the Histoire library brings for Vue component library documentations as it is really easy to use and also fully done in Vue. Nevertheless, it would be really nice, if the styling of the library documentation has more options to align it with the design system of the company.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

I've also noticed inconsistent behavior between the dev and prod environments.
Using story:dev both my components and the Histoire UI use the fontFamily.sans set in my tailwind.config but after building and deploying or running story:preview the UI and my components all use 'Noto Sans'.
Setting font-sans on a global wrapper component will set my font on the components, but it looks better when the whole thing uses the same font.


Bump default version of OTP to 1.4.0

Released July 30th.
https://repo1.maven.org/maven2/org/opentripplanner/otp/

@azavea/operations does this need a review? It's pretty trivial.


feat: add new icons

We need to add new icons:

[ ] add-circle-fill
[ ] add-circle-line
[ ] barcode-fill
[ ] barcode-line
[ ] customer-service-fill
[ ] customer-service-line
[ ] file-copy-fill
[ ] file-copy-line
[ ] kakao-talk-line
[ ] kakao-talk-fill
[ ] github-fill
[ ] github-line
[ ] line-line
[ ] line-fill
[ ] naver-line
[ ] naver-fill
[ ] pie-chart-fill
[ ] pie-chart-line
[ ] qr-scan-fill
[ ] qr-scan-line
[ ] rocket-line
[ ] rocket-fill
[ ] search-fill (design update)
[ ] share-android-fill
[ ] share-android-line
[ ] share-ios-fill
[ ] share-ios-line

Thanks!

We use vitamin-android icons : https://github.com/Decathlon/vitamin-android/issues/142

@CorentinStamperDecathlon okay, thanks! So I close this issue :)


Pug cli rename

How to rename PUG file to different name HTML file (through CLI)
Eg- Want to rename
index.pug ⟹ main.html (through CLI)


Ignore RUSTSEC-2021-0080

Description
RUSTSEC-2021-0080 will be ignored until there is a new version of the tar crate with a fix.
There is already a pull request (alexcrichton/tar-rs#258).
Review Checklist

[ ] Code contains useful comments

Should we create an issue to track this?
I can merge this (as soon as I change the settings :) ) if you like.


fix README for production deployment

do not install dev only modules
prefer ipv4, because on ipv6 network the download get stuck on some modules
move husky to production list because otherwise "npm run start" fails

Uff I have just notice https://github.com/badlogic/heissepreise/pull/144 that is similar. When you merge #144 I will rebase this one on top of it.

Cheers!


WIP - DO NOT MERGE - Will be split: Signing machinery

THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (https://github.com/sigstore/model-transparency/issues/224, https://github.com/sigstore/model-transparency/issues/248, https://github.com/sigstore/model-transparency/pull/240, https://github.com/sigstore/model-transparency/issues/111).
CC @susperius

Separated first part of this to #259

Closing as all the API from here has landed. I have a Pr in works to do the in-toto conversion, should be able to send it tomorrow


EventHandlerV2 support handle event with replication.EventHeader

add EventHandlerV2 to get timestamp from event, so that canal can show the how much time delay when process like
func (s *handler) OnXID(header *replication.EventHeader, nextPos mysql.Position) error {
	s.queue <- model.Position{
		Name:      nextPos.Name,
		Pos:       nextPos.Pos,
		Timestamp: header.Timestamp,
		Force:     false,
	}
	return nil
}

it can show on UI like
binlog file: mysql-bin.000102
binlog position: 1142900
binlog timestamp: 2022-11-25 15:54:07<PHONE_NUMBER>)
tiem delay:  2 sec

Maybe we should change an EventHandler and increment semver as a major update?

Maybe we should change an EventHandler and increment semver as a major update?

change EventHandlerV2 name to another like EventHandlerWithHeader or change the method in EventHandler ?

Maybe we should change an EventHandler and increment semver as a major update?

Oh i forget that for major version updates we can break compatibility. I agree with this.

Maybe we should change an EventHandler and increment semver as a major update?

change EventHandlerV2 name to another like EventHandlerWithHeader or change the method in EventHandler ?

It means we can change the API interface while keeping the old name EventHandler.
But because this chance is rare, we might ask other developers what they want to change and do them at once

please fix CI, some test files need to be updated


ntr:basolateral protein secretion

Could I have:
basolateral protein secretion
def:The controlled release of proteins from a cell at the sides which interface adjacent cells and near the base.
PMID:27404358
Is_a GO:0009306 protein secretion
And:
regulation of basement membrane organization
def:Any process that modulates the frequency, rate or extent of the assembly, disassembly or arrangement of constituent parts of the basement membrane.
PMID:27404358
regulates GO:0071711 basement membrane organization

@hattrill
These two terms have now been added to the ontology:
id: GO:0110010
name: basolateral protein secretion
id: GO:0110011
name: regulation of basement membrane organization


fix: permit gen issue verification

Resolves #483
This is happening because we're checking the comments for the existing payout message, but we're checking the comments if there's any comment with the permit URL which bot going to post, which never existed so causing this issue.

Still waiting for resolving conflicts. but I think @b4s36t4 seems not here in recent days.

@wannacfuture you wanna pick this one up? You can use the linked pull request as reference.


WIP/RFC: Wildcards for banned_api

Summary
This PR is a heavy WIP and RFC for adding support for wildcard paths for banned-api.
In short, the goal would be to be able to do
[tool.ruff.flake8-tidy-imports.banned-api]
"some_package.ANCIENT*".msg = "None of the ancient powers of `some_package` may be invoked"

instead of having to spell out all of the ancients' names in the config.
How?!
This PR implements this by way of a new CallPathPattern struct, which is basically a CallPath but with possible wildcard segments (glob.Patterns; I looked at wildmatch and decided not to introduce another dependency) and can be matched against a qualified name CallPath. I'm not 100% sure that's the best way here, and especially e.g. config parsing becomes a bit hairier since turning the strings in the config to CallPathPatterns could fail (e.g. some_package.ANCI[ is invalid).
(I also noticed there's a NameMatchPolicy thing in the flake8_tidy_imports linter that kind-of does the same thing.)
Then, there's a possible concern about performance, since we can no longer just use an FxHashMap for looking up bans. (Since this is very much a WIP (and who knows, maybe this is deemed a Bad Idea all in all), I haven't measured things.)
Of course we could come up with a smarter data structure that's both an FxHashMap for the exact-match happy path, and a vector of CallPathPatterns for other situations?
Test Plan

Not very well yet. It's probably buggy (but compiles!). The patch is currently also peppered with TODOs.

Sorry to ping, but: any thoughts, @charliermarsh et al.? I wouldn't want to continue here until the whole idea is even slightly validated :)

I think the overall idea is reasonable. I assume we'd also want to support:
"some_package.*.ANCIENT".msg = "None of the ancient powers of `some_package` may be invoked"

One idea: could we use a GlobSet? So, combine all the patterns into one, and do that single test; if it passes, then run all the individual tests to find the relevant message.

@charliermarsh Mm, yeah! Using a GlobSet would be a grand idea otherwise, but it doesn't look like you can customize which character(s) the globs think are path separators, so I don't think we can just easily match them against full CallPaths then.
We'd want these patterns to consider . path separators, not / ... unless we do spooky things on our side and turn the CallPaths into slash-separated strings (which, tbh, isn't completely unreasonable, probably...)?

Oh hey, huh... there's some prior art: https://github.com/astral-sh/ruff/pull/5024

Emdraftened pending more discussion in https://github.com/astral-sh/ruff/discussions/8403...

@MichaReiser I've assigned you to this to decide what the path forward looks like. Let me know if that's not a good fit.

I only saw the ping when browsing through open Ruff PRs. I'm sorry.
I don't have a clear path forward for this, but I'm now looking into multifile analysis and plan to significantly change Ruff's semantic model. I think it does make sense to defer this work until we have a better understanding of how our semantic model looks (I don't expect CallPath to survive the refactor).


Minimal images

What, how
This change reduces the size of zipkin-base from 466.2 MB to 181.8 MB. This is achieved by switching from debian:sid to a minimal base image built on Alpine Linux; a Java Docker image doesn't get much smaller than this. Here's what changes.

Package management, obviously. Specifically, there's no Cassandra package for Alpine Linux, so we just install the dependencies manually, and download the binary tarball.
/bin/bash is /bin/sh
We go from OpenJDK 8 headless to Oracle server JRE 8. This may be a concern from a licensing point of view, looking for input on this. I still went with this image because I couldn't find a minimal, OpenJDK based image I could trust.

Testing
Pulled up docker-compose up with these images built locally, ran zipkin-tracegen against them, and saw traces on the web interface.

wrt Oracle JRE, I've noticed some just making a disclaimer about the implicit license agreement.
Also, there's zulu to consider? https://github.com/delitescere/docker-zulu

Zulu looks good, giving it a try. Thanks.

Layered on your work here #46


[Android] Missing interpolation type

I got an error when I pressed CustomSwitch component in android.
react: 18.0.0
react-native: 0.69.1
react-native-custom-switch: 1.0.7

@adexp01 thx, but I used https://www.npmjs.com/package/react-native-custom-switch-new instead of this.


typing and star pass

I set out to preventatively add the * in the kwargs list to force keyword-only args for easier future dev. And I thought I'd get a little typing under my fingers by filling in fn signatures. Then I realized I could be adding errors since those sigs are never checked (unless in pydantic class), so started mypy linting. I've fixed many alerts, but they're so numerous that I'd better get a gauge on what's wanted before proceeding.

I think this is all good things. Getting mypy working at some point would be great, but not in a huge hurry to do so at the moment.

This is the end of my current typing push. There are some legitimate fixes in here, so good to get it in and stabilized a bit before the next release.


trap console to file, masking all sensitive data

when debugging it is common to ask for the set -x change and to upload the console output.
the console output isn't always re-attainable, and can contain sensitive information.
is it possible to trap it to a file, mask out sensitive info, so it's ready and simple to share …?

merged.


React components for loginpage

First, an apology
As mentioned many times before: I bit off far too much with this attempt, tugged on a piece of string and ended up with the entire yarn ball in my lap. There's one monster commit which adds most things. @frederike-ramin I'm more than happy to walk through everything with you in a Huddle!
Changes

NB: This is still all "dead code", as in: it's not used anywhere in the Steuerlotse webapp.
Adds eslint plugins: airbnb (React styleguide: https://github.com/airbnb/javascript/tree/master/react) and jsx-a11y
Completes LoginPage and all necessary components.
Reorganises Storybook stories into its own directory
New components:

FormRowCentered - a simple row div
FormFieldIdNr - a form field for steuer-IDs
FormFieldUnlockCode - a form field for FSCs
FormFieldScaffolding - shared wrapper for form fields
FormFieldSeparatedField - creates the inputs that make up separated fields
FieldLabel, FieldLabelForSeparatedFields, FieldLabelScaffolding, Details, ExampleFieldInput, HelpButton, HelpDialog, OptionalHint - components for labels and other bits surrounding fields
FieldError - error messages

Changes to existing components:

Restructure LoginPage props to map better to components
Make StepForm accept children

Adds LoginPage story, plus assorted tests and stories.
Adds react-i18next for interpolating strings.
Makes input masking work (still using jQuery for now, which is a bit stupid).

Caveats / Things to note

Styling: I've only tested component styling as it's used on the login page. Some of the components have options that haven't been used and could be off still. Most components are also still using globally defined CSS classes (from e.g. components.css) instead of styled components. I was worried that I'd have to change too much at once and keep it in sync with any new changes and I wanted to wait with that until I had merged at least this initial batch.
Sharing behaviour: Still learning about good ways to do this, especially when there's dependencies from children to a parent element. Hopefully we can also simplify the components HTML later to make this less necessary. For now, I wanted to stick very closely to the jinja macros. I've introduced utility components FormFieldScaffolding (suggestions for better naming welcome!) and FieldLabelScaffolding, which use render props for extendibility, which kind of works but doesn't feel like the last word on this. The login page only uses separated fields, no "normal" ones, so the next page to port should be a step that uses normal fields, too, so we can figure out the right way to share behaviour.
Weird comments: I've constructed the field components by copying over the jinja templates and converting them bit by bit. What I've not done yet remains as comments in e.g. FormFieldScaffolding and I'd like to keep it as a sort of todo list of what hasn't been converted yet. Let me know if you hate this, though, and I'll keep it somewhere in my personal notes instead.
Testing: I've been a bit random with test coverage: although I tried being pragmatic and mainly adding tests for non-trivial behaviour (i.e. not just rendering props), I also added some really trivial tests and failed to get testing of some of the more complex behaviour like toggles to work (the problem is probably bootstrap/jQuery). But I thinks this is still a decent starting point!

@frederike-ramin I've updated the README and used the opportunity to split it up into more self-contained units (but added links between them). Let me know if this helps!
Btw, you can view a rendered version here easily: https://github.com/digitalservice4germany/steuerlotse/tree/react-components-for-loginpage

Oookay, a lot of questions

Incredibly great questions! Allowing me to revisit and explain a lot of things I introduced. Flagging this for @JulianRoesner to look over when he's back from holiday, too - I'm sure he has many of the same questions!


Dry run thoughts!

I just did a dry run of the tutorial, and wanted to share some notes I had here!

The ROOT_INSTALL issue is still present (see #1508).
There were a few small documentation fixes, addressed in #1531

Some minor nits with the frontend tutorial documentation:

[x] We direct readers to go to frontends/mrxl, but in order to run the example, they need to run a command from the root of the Calyx repository, and they go to frontends/mrxl in the next line. Maybe we remove it?
[ ] This command has comments next to it which made it finicky to copy, should we maybe make the explanation follow or precede the command?
[ ] This command and the next two after it might only need to reference the file by test/squares.mrxl? Since folks will be in the frontends/mrxl directory?

^ Happy to make any of the above changes folks agree on! We can check the ones we want!
Overall everything went very smoothly and these are just a few minor remarks, so this seems to be in good shape!

@anshumanmohan would love to hear your thoughts on the frontend tutorial edits when you have time! truly no rush :)

Please push on without me; I don't want to block. From your summary above, this all sounds good to me

@priyasrikumar The change related to comments sound good. I think there was a rewriting conflict with the latter stuff: @anshumanmohan wrote the docs assuming people where in frontends/mrxl and I wrote them people are in the repository root.
All things equal, I prefer to keep instructions tagged to the repository root because it seems like a good "default" place that people can go back to and have things work out. Either way, I don't have a strong opinion on this except that we should be consistent about one choice or the other.

Thanks for the catch; let's move to the consistent version for sure!

@priyasrikumar should we close this?


Binoculars test coverage increase

POC for increasing coverage on binoculars.  We now test most errors paths.

Codecov Report
Base: 74.60% // Head: 79.91% // Increases project coverage by +5.31% :tada:

Coverage data is based on head (5f2386c) compared to base (092be0d).
Patch coverage: 91.17% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   74.60%   79.91%   +5.31%
==========================================
  Files          12       12
  Lines        1642     1748     +106
==========================================
+ Hits         1225     1397     +172
+ Misses        321      276      -45
+ Partials       96       75      -21

Impacted Files
Coverage Δ

controllers/install/binoculars_controller.go
98.14% <91.17%> (+17.87%)
:arrow_up:

controllers/install/common_helpers.go
100.00% <0.00%> (+5.76%)
:arrow_up:

controllers/install/armadaserver_controller.go
63.82% <0.00%> (+11.67%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I'm going to close this for now.  Let's aim to hit all tests without having to mock controllerutil.
I think we can get really close to 85% without doing this. ;)


Fix error message to use correct params

The string interpolation at the moment uses non-existant params

No longer an issue with 2.0.0.


Bump to latest Cosign

There has been a CA root rotation on the remote signature repository (as it seems) so we need to update cosign: https://github.com/sigstore/cosign/issues/3614

That's made the v0.3.0 release unsigned. c.f. #3


GraphRbac: fix encoding of Users

@yugangw-msft I will push more testing before merging this. RestAPI PR is not done yet, waiting for Python to test here before.

Codecov Report

Merging #1594 into master will increase coverage by <.01%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
+ Coverage   54.52%   54.52%   +<.01%
==========================================
  Files        3677     3679       +2
  Lines       90913    90929      +16
==========================================
+ Hits        49567    49578      +11
- Misses      41346    41351       +5

Impacted Files
Coverage Δ

azure-graphrbac/azure/graphrbac/models/user.py
100% <ø> (ø)
:arrow_up:

...ac/azure/graphrbac/operations/groups_operations.py
10.27% <ø> (ø)
:arrow_up:

...phrbac/azure/graphrbac/models/service_principal.py
44.44% <ø> (ø)
:arrow_up:

...c/azure/graphrbac/operations/domains_operations.py
25% <ø> (ø)
:arrow_up:

...ure-graphrbac/azure/graphrbac/models/aad_object.py
21.73% <ø> (ø)
:arrow_up:

...phrbac/models/key_credentials_update_parameters.py
83.33% <ø> (ø)
:arrow_up:

...c/models/password_credentials_update_parameters.py
83.33% <ø> (ø)
:arrow_up:

...c/azure/graphrbac/models/user_update_parameters.py
40% <ø> (ø)
:arrow_up:

...phrbac/operations/service_principals_operations.py
11.18% <ø> (ø)
:arrow_up:

...bac/azure/graphrbac/operations/users_operations.py
67.2% <ø> (ø)
:arrow_up:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f1aa78...6b6934c. Read the comment docs.


Update swift keystoneauth options (1.2.x)

In our previous releases, we were not using keystoneauth to validate
user role, so anybody with a valid token was allowed to use Swift. Now
we'll allow member in, to match that functionality.
Also update the authtoken config to remove the old format of urls.
Remove the quotes on the cert file, as this seems to trip up requests.
(cherry picked from commit c8b8197a8ce29ee5c7ac99d64608cd4dcaf9bc76)

do we need this in master as well ?

It's already on master.

jlk

On Thu, Aug 27, 2015 at 1:00 PM, Paul Czarkowski<EMAIL_ADDRESS>wrote:

do we need this in master as well ?
—
Reply to this email directly or view it on GitHub
https://github.com/blueboxgroup/ursula/pull/1152#issuecomment-135536883.


⚠ Bofrost.at has degraded performance

In 7ce45ca, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2198 ms

Resolved: Bofrost.at performance has improved in 20f2edf after 13 minutes.


CI: verify stage fails

The role runs through fine on CI, but when creating a new app at the verify stage
https://github.com/dokku/ansible-dokku/blob/b40149b89bc7a33944f952d1c4e257755516243c/molecule/default/verify.yml#L43-L46
we get the error:
error during container init: error reopening /dev/null inside container: open /dev/null: operation not permitted: unknown.\\n !

Full context:
  TASK [clone example-app] *******************************************************
  fatal: [instance]: FAILED! => {"changed": false, "meta": {"error": "b'-----> Cloning example-app from https://github.com/heroku/node-js-getting-started#b10a4d7a20a6bbe49655769c526a2b424e0e5d0b\\n\\x1b[1G-----> Cleaning up...\\n\\x1b[1G-----> Building example-app from herokuish\\ndocker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error reopening /dev/null inside container: open /dev/null: operation not permitted: unknown.\\n !     Failure extracting app code\\n !     Removing invalid image tag dokku/example-app:latest\\n !     App build failed\\n'", "present": true}, "msg": "b'-----> Cloning example-app from https://github.com/heroku/node-js-getting-started#b10a4d7a20a6bbe49655769c526a2b424e0e5d0b\\n\\x1b[1G-----> Cleaning up...\\n\\x1b[1G-----> Building example-app from herokuish\\ndocker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error reopening /dev/null inside container: open /dev/null: operation not permitted: unknown.\\n !     Failure extracting app code\\n !     Removing invalid image tag dokku/example-app:latest\\n !     App build failed\\n'"}

It seems to me like dokku_app makes an assumption about the docker setup that is currently not fulfilled in the docker environment created by molecule?
@josegonzalez have you seen this before?

Possibly related: https://github.com/opencontainers/runc/issues/2204 , fixed by https://github.com/opencontainers/runc/pull/2391 for cgroups v1, but

A similar issue affects the cgroupv2 devices setup, but that is a topic for another time (as the solution is drastically different).

No, seems weird. Sounds like a docker issue?

Alright, I think I got all the CI bugs worked out.


springboot 2.2.1

hi,
i upgrade from springboot 2.1.13 to 2.2.1 and startup failed with :
Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'XXXX': Unsatisfied dependency expressed through field 'yyyy'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'XXXX' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)}
i remove batch-web-spring-boot-starter dependency and try again, server start and works.
will you maintain this library?
thanks.

I have release a new version with Spring Boot 2.2.6.RELEASE
I hope this fixes your problem.

I will try, thank you very much

Hi,
with 2.0.3, you upgrade java to version 11 and now cant compile with 8 :
class file has wrong version 55.0, should be 52.0

I have released a new version with Java 8 compiled classes.

i try with 2.0.4 but have same problem !!

I do need more details of the problem.
The message from above has XXX and YYY placeholders. What are those?

XXX is job configuration bean and YYYY is a service with @Service
`@Configuration
public class ArchivageJobConfiguration {
@Autowired
private ContratService contratService;

private final StepBuilderFactory stepBuilderFactory;

public ArchivageJobConfiguration(StepBuilderFactory stepBuilderFactory,
		ApplicationContext applicationContext) {
	this.stepBuilderFactory = stepBuilderFactory;
}

@Bean("jobArchivage")
public Job archivageJob(JobBuilderFactory jobBuilderFactory,
		@Value("${job.archivage.name}") String jobName, @Qualifier("stepRecuperationContrat") Step step1) {
	return jobBuilderFactory.get(jobName).incrementer(new RunIdIncrementer()).flow(step1).end().build();
}

@Bean("stepRecuperationContrat")
public Step step1(@Value("${job.archivage.step1.name}") String stepName,
		@Value("${job.archivage.chunk}") int chunk) {
	return stepBuilderFactory.get(stepName).<Contrat, Contrat>chunk(1).reader(contratsArchivablesReader())
			.processor(processor()).writer(writer()).build();
}

@Bean("readerArchivage")
@StepScope
public ListItemReader<Contrat> contratsArchivablesReader() {
	return new ListItemReader<Contrat>(contratService.getContratsArchivable());
}

@StepScope
@Bean
public ItemProcessor<Contrat, Contrat> processor() {
	return new ContratItemProcessor();
}

@StepScope
@Bean
public ItemWriter<Contrat> writer() {
	return new ContratItemWriter();
}

}
`

Looks like ContratService has not been created properly. Can I access the code in a public GitHub?

no i cant !!

So, I can't help you further more :-(


VS Eureka Mod (vs_eureka) has failed to load correctly

A player tried to run a modpack, and got this error.
The modpack has all the dependencies and runs fine for everyone else.
Minecraft version 1.16.5
message.txt

А как исправить ошибку то?


[WiP] PR: House cleaning

Pull Request Checklist

[x] Read and followed this repo's Contributing Guidelines
[x] Based your PR on the latest version of the correct branch (master or 3.x)
[x] Followed PEP8 for code style
[x] Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
modified the spyder/defaults directory, or added new icons/assets
[x] Described your changes and the motivation for them below

Description of Changes

Waiting on @ccordoba12 to attach the source files for the Oxygen icons; then I'll make a few final changes that need to go last, and this will at long last be done.
Final changes:

[ ] Add source files for Oxygen icon them-derived icons from @ccordoba12 : BLOCKING
[ ] Harmonize LICENSE, etc. to LF
[ ] Move LICENSE/AUTHORS to .txt and NOTICES to NOTICE and update MANIFEST
[ ] Add appropriate boilerplate/list to LICENSE, AUTHORS, and init
[ ] Fix license title and other details in LICENSE and init.py
[ ] Clarify/add links to AUTHORS like for docs
[ ] Add template and instructions to NOTICES.txt and checkbox to PR template

Also, is there anything that needs to be done to make sure the NOTICE.txt always gets shipped with the package on both conda and pip?
Clean up a lot of old mess that could potentially cause problems, particularly legal ones, and make everything much cleaner, clearer, more transparent and well-documented.
I tried to minimize modifications to files that were moved in split-plugins to only those that were strictly necessary. The files added or changed in locations there moved were:
Add:
spyder/utils/help/js/mathjax/LICENSE.txt
spyder/utils/help/LICENSE.txt

Modify:
spyder/utils/sourcecode/kill_ring.py
spyder_profiler/widgets/profilergui.py
spyder/utils/help/__init__.py
spyder/utils/help/js/collapse_sections.py
spyder/utils/help/js/copy_button.py
spyder/widgets/variableexplorer/dataframeeditor.py

Once merged to master, I will follow this up with a PR making a few master-specific changes (mostly to file paths listed in NOTICE.txt), if they are not modified in the merge itself.
For the icon files that were removed, I took numerous steps to ensure to the greatest extent practical that they were not used anywhere and their removal would not cause other problems. Included among these steps for each of the removed icons (where "name" is the name of the icon, without the extension):

Searched for all instances of "name" and "name + extension" in 3.x and master w/ both Github and Spyder Find in Files
Used Git Blame to trace and verify past usage(s) of given icons
Inserted temporary code to both print a debug message and raise an exception if an icon was not found
Started Spyder with all panes enabled and tested basic functionality in every pane as well as the File Switcher and File Open/Save dialogs
Tested both Python 3 and Python 2 icon sets, and compared functionality with clean Spyder 3.2.8
Ran all tests (including slow) locally
Filetypes-specific removal justification:

Added prior to July 2009, although a few additional types added as soon as ~2012
Checked every relevant icon(), get_icon(), get_std_icon(), get_image_path() and filetypes call
Tested file explorer with and without change in both icon sets with files of various extensions
Checked every "*.png" string

Thanks!

Hello @CAM-Gerlach! Thanks for submitting the PR.

In the file spyder_profiler/widgets/profilergui.py, following are the PEP8 issues :

Line 438:26: E128 continuation line under-indented for visual indent

@ccordoba12 Wrt the PEP8 issue, I'd have to fix the indent of the other lines in the block for consistency (which is why I didn't do it, particularly since it was in a file that was moved). Do you want me to?

Not sure what's going on with Travis; conda builds have been failing on several recent PRs on both branches with "wrapped C++ object has been deleted" errors on random tests.

Do you want me to?

Nop, let's leave things as they are.

Should I base my PR on 3.x then?

Yes, please.

@CAM-Gerlach, please rebase to see if our tests pass.

@ccordoba12 Sorry, not sure how I missed this—must have confused it with the same request at the same time in the other PR. Tests running now.

@CAM-Gerlach, this looks good. Thanks for helping us with this one!
I don't have time right now to add the missing files, but I will in a future PR. So please finish this one so I can merge it.

@ccordoba12 It is too much to ask to just email them to me or dump them on the Google drive, and I'll take care of the rest? (It feels kind of weird/wrong, but I could even fund you whatever for your time since this is sufficiently important). I would of course need to do or at least be directly involved in the actual change anyway, since it needs to be handled carefully and a couple specific things need to be changed/added.
The problems with leaving it for another PR include:

This PR doesn't really achieve much until it is done, since we are still not legally "clean" and that is one of the more severe and explicit license violations, especially if it drags on until after the next set of versions are released putting yet more "tainted" versions out there (especially as Spyder 3 becomes our "LTS" branch that is going to be out there for a long time yet)
If we commit this now, in NOTICE.txt we either have to admit we are violating their license, or knowingly lie that we are in compliance.
Making the change after moving the LICENSE, AUTHORS etc. to LF and .txt makes less of a clean and obvious break between clean and "dirty" versions, makes it more obvious we were not in compliance before, and makes it easier for others to use and redistribute "dirty" versions
Furthermore, knowingly submitting and approving this without such could lead to both legal and ethical liability on my end

especially as Spyder 3 becomes our "LTS" branch that is going to be out there for a long time yet

Spyder 3 will cease to be supported as soon as Spyder 4 is out.

I'll add the icons in another PR for 3.3.2. Until that version is released, I see nothing wrong about it.

Spyder 3 will cease to be supported as soon as Spyder 4 is out.

Yes, I'm aware, I meant more that it was going into a ~6 month period of only critical fixes, and also that many of our downstreams will carry it for much longer (some even still carry Spyder 2 in their older, still supported releases), and these are also the users and developers who are most aware of and sensitive to license issues and thus likely to find and act on any problem. However, as you've mentioned, so long as we get it in 3.3.2 and Beta 2 that's the best we can do.

I'll add the icons in another PR for 3.3.2. Until that version is released, I see nothing wrong about it.

Aside from Github distribution you're right with regard to that reason, isofar as it gets in before 3.3.2 is out the first reason is not an issue. Of course, there are also the other 3 reasons I detailed above that were left unaddressed; however, they are less important if I take careful steps to mitigate them, even if the overall result is not as clean. I guess I may as well go ahead and do that then finish this since it seems pointless to argue further.
Also, again, if you want to save yourself some work since I know you're so busy, why not just send me the relevant files or post them on our Google drive, and I can take care of it properly and cleanly without you having to figure out the specific additions/changes you would need to make in a few different places and/or a potentially drawn-out review (and possible rebasing); or even requiring a follow-up PR.

Also, again, if you want to save yourself some work since I know you're so busy, why not just send me the relevant files or post them on our Google drive

I don't know where I have them. I'll send them to you when I have some free time. But in the meantime, please finish this PR so we can merge it.

But in the meantime, please finish this PR so we can merge it.

Yup; already on it. It shouldn't take more than an hour since I only had to leave a few things to the very end.

@ccordoba12 At long last, this is finally done. If the tests fail, I'll merge the latest from 3.x,

@ccordoba12 Merged the latest and now tests are green. This is ready on my side; let me know if there are any changes you'd like me to make.

Also, don't forget to merge with master to fix our tests in Circle.

Also, don't forget to merge with master to fix our tests in Circle.

@ccordoba12  Did something further change in the last 24 hours? I merged it with 3.x a day ago to fix the failing tests, which indeed did so as of then.

I'm in the process of refactoring the About Spyder dialog window to implement #7844 and the content of this Pull request gave me an idea.
Would it be a good idea to add more information in the About Spyder dialog with a tab widget.
Something like in Inkscape for example:

@jnsebgosselin Fantastic idea!!! I had been eventually planning something like that, but as you mentioned earlier it would be well beyond the scope of this already bloated PR.
I was thinking it would be good to have a tab to display the license, the authors file (would we want to include every Github contributor though, or just display it as it is now and have a clickable link to the Github contributors page), and the notices file as scrollable/selectable plain text. It would be nice if the bare links could be made clickable, but that's not a priority. Of course, this makes it even more important for the dialog to be non-modal.
We could then remove the last paragraph of the current about dialog, since the authors would cover it. The first tab would be the about dialog more or less as it is now, and we could add the splash screen graphic in there at the top or bottom if we needed something to fill the space; and/or we'd have the room to list Spyder, OS, Qt, etc. versions in the same format as on Github, as a bulleted list, so users could simply copy and paste it directly if we wanted. We could also consider incorporating the dependencies dialog as a tab too, but that might be pushing it too far.

@ccordoba12 With regard to the failing test only on the pip build of Py3.6 Linux on Travis, the apparent cause is the new version of nbconvert, 5.4.0, which adds a shebang line at the top of the output Python file that results in the test_open_notebooks_from_project_explorer failing, as it checks for the file exactly matching the expected text which doesn't include the shebang. Should I create a new issue/PR to fix this in a straightforward manner (checking for the text including the shebang if nbconvert.__version__ >= 5.4.0), or is there a more robust way to handle this that won't break in the future if something else changes?

@jnsebgosselin Fantastic idea!!! I had been eventually planning something like that, but as you mentioned earlier it would be well beyond the scope of this already bloated PR.

Excellent, I'll open an issue so we can get discussed this and I'll implement it with your help in a PR if it is approved.

@ccordoba12 Thanks for putting up with my stubbornness; you have the patience of a saint.
Was the merge that bad?

Nop, fortunately it was quite easy :+1:

Good job 👍


withEventrixState - ref forwarding doesn't work

Hi.
I noticed that when we overlap a component with HOC withEventrixState, the passed react ref from the parent component to the middle of this overlap component is not visible. I think it will need to be fixed.

@wojciechstracilo thank you for report that issue. We will take care of that asap :)


Upgrade to Cypress 12

Description 📝
What does this PR do?
Upgrades Cypress and related dependencies for Cypress 12. For more information about what's new in Cypress 12, check out the Cypress changelog page.
This also makes some changes to our tests:

Fixes some issues where multiple elements were being selected when Cypress expected one; this used to be acceptable with previous versions of Cypress but causes an error in Cypress 12
Changes some interactions around action menus, primarily to address potential flakiness
Changes to element selection for the security questions test, also to reduce flakiness

How to test 🧪
How do I run relevant unit or e2e tests?
Run yarn dev, then separately run the E2E tests:
yarn cy:run

All E2E tests passed for me except "creates a volume from an existing Linode" in volumes/create-volume.spec.ts. However, on the develop branch that test is passing 🤔

Hey @hana-linode, sorry for the slow follow up! Do you remember if this test was failing consistently for you? I haven't been able to reproduce any failure in create-volume.spec.ts yet so I'm wondering if the failure you observed may have been some kind of fluke


Feature: Enable Org-wide visibility into projects

Stories
As private GitHub organization members
in order to be aware of all the work going on in our private org
I want to have read access to every repository in the organization
As a secret repository maintainer
In order to ensure that not everyone sees sensitive repositories
I want to exempt my repository from the org-wide visibility rule
Notes on implementation

[ ] Double-check with IT prior to ensure this isn't a policy issue (confirmed before but never hurts to double-check)
[ ] Decide on the "all org members" group name and add it to the configuration
[ ] Decide on the exemption tag name and add it to the configuration
[ ] Send a mass message to repositories to let them know this change is coming (include a date)

This is the kind of thing we'd probably want to follow-up on to make automated / scheduled (e.g. with an Azure Function). But this will be the quickest way to accomplish for now.
Initial format

Show list of repositories, split by exempt and non-exempt
Button to add the all org members group as viewers to the non-exempt repositories
Warning area to show exempt orgs that still have the group added, and a button to remove them
Show list of org members not added to the all-org-members group and a button to add them.

Closing this issue as it is now its own project.


Credits module.

Related changes in core - d4b9646

Integration with Payment module - ecffa34

Warning on home page when Cache is enabled and is generated first time. Can be reproduced each time the page is reloaded just after cleaning a cache:

Warning: file_get_contents(//main.css): failed to open stream: No such file or directory in [path_to_una]/inc/classes/BxDolTemplate.php on line 1933


When would winappdriver extend support for Windows12 or windows16 server

Hi,
When would winappdriver extend support for Windows12 or windows16 server., since I have service application that run only on Windows 12 server and client running on windows 10.
Thanks,
Mahendra

Hi @Manvibha,
WinAppDriver should work fine on Windows Server 2016 since it shares the same core are Windows 10. Are you seeing issues with it? You will need to enable developer mode on the server to run WinAppDriver.
Can you give a little more details on what you mean by a service application? I'm assuming that you have a UI on the server application as this is what WinAppDriver is interacting with.
Thanks

thanks for response. I did not attempt on Win2016 machine since it was never mentioned about it (Hope I am right) .
Any idea support for Win2012 server ?
Thanks,
Mahendra

There are no plans to support anything south of Windows 10 or Windows Server 2016.

hope "south" to be read as "out" from above response??


View rendering before the app goes in background

Hey guys,
I'm developing an IOS app using RN 0.25.1.
I currently have an issue with one of the feature, let me explain:
I would like to hide the app content when the app goes in the background.
So I'm detecting this using AppState and I'm updating my state accordingly.
The problem is the view is not updated before the app goes in background, only when it comes back, resulting in a small delay where you can see the app content.
Is there any way to be able to render a view before the app goes in background ? Maybe another event that I could use that is fired earlier ?
Thanks for the help

@facebook-github-bot stack-overflow

Hey @maxs15 and thanks for posting this! @charpeni tells me this issue looks like a question that would be best asked on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only. Will close this as this is really a question that should be asked on SO.

This looks more like a bug/feature for me @charpeni


Consider collapsing a [resource] function & its annotations/docs together

When collapsing a resource function, I have to manually collapse the annotations after collapsing the function. Since docs / annots / code go together, can we make collapse just fold all of it at once?

Language Server FoldingRange capability supports specifying a set of ranges to fold. If we fold docs and code together, we can make only a part of the doc(only the top part) visible, making it hard to identify the underline capability of code without its declaration.
IDEs like IDEA, VSCode support folding docs, imports, and any other similar indented code parts, separately.
Shall we follow a similar approach?


git autocomplete not working in subshell

Thanks a lot for this awesome project 👍
I am trying out for the first time. I have git autocomplete enabled, using this https://github.com/git/git/blob/master/contrib/completion/git-completion.bash
When I activate virtualenv using pipenv shell, git autocomplete doesn't work anymore

Hey @chhantyal, could you tell me what shell you're using and what the value of $SHELL is in your terminal? Thanks!

this is a side-effect of the way your shell is configured. I'd recommend getting more familiar with how your shell and its best practices.

@nateprewitt I am using bash.
This is default configuration on OSX. I have only added this line in ~/.profile
source ~/.git-completion.bash
to enable git completion. I thought it was bug because activating venv doesn't affect it.
Anyway, not big of an inconvenience. I will try to figure out what pipenv shell does.

@chhantyal by default pipenv shell will run the command pew workon <project_name> where project_name is the directory you are using pipenv in. There may be restrictions in pew that are not playing well with your use of source to activate git-completion.
As Kenneth said, you'll either need to work out the conflict between pew and your shell setup, or you can use the PIPENV_SHELL_COMPAT environment variable to use a simpler $SHELL -i command for activation.

@nateprewitt I am using bash.
This is default configuration on OSX. I have only added this line in ~/.profile
source ~/.git-completion.bash
to enable git completion. I thought it was bug because activating venv doesn't affect it.
Anyway, not big of an inconvenience. I will try to figure out what pipenv shell does.

try this for Mac terminals ...
source ~/.bash_profile
to solve the auto completion in Pipenv subshell ,Thank you

@nateprewitt I am using bash.
This is default configuration on OSX. I have only added this line in ~/.profile
source ~/.git-completion.bash
to enable git completion. I thought it was bug because activating venv doesn't affect it.
Anyway, not big of an inconvenience. I will try to figure out what pipenv shell does.

try this for Mac terminals ...
source ~/.bash_profile
to solve the auto completion in Pipenv subshell ,Thank you

@alexjolly28 Right, but that's a workaround and not a fix.
I'm curious to understand what the actual problem is. I'm using bash on macos.

By moving source ~/.git-completion.bash into ~/.bashrc then git autocompletion is restored.


nix-env fails with "feedgenerator: no such file or directory" error

Issue description
Today, I updated nixpkgs repository.
After updated, nix-env fails 'feedgenerator': No such file or directory
error: while evaluating anonymous function at /Users/lufia/nixpkgs/lib/meta.nix:42:54, called from /Users/lufia/nixpkgs/lib/attrsets.nix:199:52:
while evaluating ‘isDerivation’ at /Users/lufia/nixpkgs/lib/attrsets.nix:295:18, called from /Users/lufia/nixpkgs/lib/meta.nix:42:62:
while evaluating the attribute ‘feedgenerator’ at /Users/lufia/nixpkgs/pkgs/top-level/python-packages.nix:10801:3:
while evaluating ‘callPackageWith’ at /Users/lufia/nixpkgs/lib/customisation.nix:95:35, called from /Users/lufia/nixpkgs/pkgs/top-level/python-packages.nix:10801:19:
while evaluating ‘makeOverridable’ at /Users/lufia/nixpkgs/lib/customisation.nix:54:24, called from /Users/lufia/nixpkgs/lib/customisation.nix:99:8:
getting status of ‘/Users/lufia/nixpkgs/pkgs/development/python-modules/feedgenerator’: No such file or directory

ec117f761f01bc47c11dc24528faf4506f57ece1 has no error. but 7bb98bb02cd25fb4764aa120bd990d669f74d17f has above error.
Steps to reproduce

export NIX_PATH=nixpkgs=nixpkgs-repository
cd nixpkgs-repository
git pull
nix-env -qa --show-trace '.*rust.*'

Technical details

System: macOS 10.12.5
Nix version: 1.11.9
Nixpkgs version: 17.09pre-git
Sandboxing enabled: no

@Mic92 It looks like you forgot to checkout the file for feedgenerator in your commit https://github.com/NixOS/nixpkgs/commit/7bb98bb02cd25fb4764aa120bd990d669f74d17f .

See: https://github.com/NixOS/nixpkgs/pull/26030#commitcomment-22256173 .

sorry for inconvenience. error corrected.


wrap the absolute div in relative

I have a bug using your component, because it uses absolute div as the container.
here's how it looks in my form:

this is my fix. if you have a better suggestion I'll be happy to hear :)

Thanks !

<EMAIL_ADDRESS>


watch fails on Windows

Describe The Bug
Adding watch to a task causes the task to fail. There is an issue on the cargo-watch repo that mentions a solution to this, which is to install with the --locked flag. Per the documentation, I have tried adding CARGO_MAKE_CRATE_INSTALLATION_LOCKED = "true" to my env section but that didn't seem to get it to add the locked flag
To Reproduce
Use the Makefile.toml sample provided below
Error Stack
error[E0308]: mismatched types
   --> C:\Users\jack\.cargo\registry\src\index.crates.io-6f17d22bba15001f\notify-4.0.17\src\windows.rs:276:29
    |
276 |         overlapped.hEvent = request_p;
    |         -----------------   ^^^^^^^^^ expected `winapi::ctypes::c_void`, found `libc::c_void`
    |         |
    |         expected due to the type of this binding
    |
    = note: `libc::c_void` and `winapi::ctypes::c_void` have similar names, but are actually distinct types

Code Sample
[tasks.sample_task]
script_runner = "@duckscript"
script = '''
from = get_env PACKAGE_DIR
to = get_env OUTPUT_DIR
glob_cp ${from}/**/* ${to}
'''
watch = { watch = ["$PACKAGE_DIR"] }
private = true

ok so to solve that using the locked workaround, need to change the runner.rs which installs cargo watch in the first place.
dependencies :(
a workaround is that you install cargo watch yourself and than cargo-make will use that installation automatically (should work)

That worked. Thank you!


Rich Text Editing

Hi! Great stuff! Do you have plans to support basic RichText editing like adding bold or etc to you plugin? Can I try to like an integrate your code to the existing Zefyr? https://pub.dev/packages/zefyr

@JEuler Right now I don't plan on adding basic RichText editing features, although it is possible to this in the current implementation might need a fair bit of refactoring of code.
Also, can you explain what do mean by your second question in more detail.

Can I try to like an integrate your code to the existing Zefyr?

Hm, I don't know exactly :D Just looking for some rich text editor with mention functionality.
Maybe I will try to work with your repository and enhance it with richness like bold or italic. Will see.


selectYears and selectMonths not working

Hi Amsul,
I have recently downloaded your pickadate.js and implemented it on my project. It was very nice! however, I'm having difficulty with the selectYears and selectMonths options. It should be pretty straight forward tight? But for some odd reason it doesn't show any selectors at all. I'm developing on XAMPP windows using PHP and AngularJS Hope you can help me about this. Thanks!

`app.controller("homeController", function($scope) {
$('.datepicker').pickadate({
  	selectMonths: true,
  	selectYears: true
});

});`

Read the guidelines before opening a new issue: https://github.com/amsul/pickadate.js/blob/master/CONTRIBUTING.md. Please create a reproducible reduced test case first.
It clearly works here: http://amsul.ca/pickadate.js/date/#selectors. There is probably something else wrong in your application.


gopaddle: Low-Code Kubernetes IDE with AI Co-pilot

Thank you for making MicroK8s better
Please reference the issue this PR is fixing, or provide a description of the problem addressed.
Also verify you have:

[x] Read the contributions page.
[x] Submitted the CLA form, if you are a first time contributor.

Hey @Gayathri-Bluemeric! Sorry for the late reply and thanks for the PR!
LGTM


Second Contribution by Sagar Arya

Name: SAGAR ARYA
Projects: FluxML | BentoML
FluxML governance model:  https://fluxml.ai/governance/
BentoML governance model:  https://github.com/bentoml/BentoML/blob/main/GOVERNANCE.md
Overview
FluxML and BentoML are two open-source software projects with different goals and governance models.
FluxML and BentoML have distinct governance methods dependent on the projects' goals and ownership. FluxML is driven by the community and is based on meritocracy, whereas BentoML is driven commercially and is built on a combination of company ownership and community contributions. Both projects include code of conduct that encourage respect and inclusiveness.
Similarities
Although, FluxML and BentoML are two different frameworks designed for different purposes but they do have some similarities:

They are both intended for machine learning applications, with BentoML focusing on developing and deploying machine learning models as APIs and FluxML on developing and training deep learning models.
Both of them take a modular approach to model construction, which makes it simple to develop and test various parts of a machine-learning application.
Both frameworks provide comprehensive documentation and supportive user groups.
Both frameworks are open source projects and supports multiple programming languages.

Diffferences

FluxML focuses on constructing and training deep learning models, whereas BentoML focuses on building and deploying machine learning models as APIs.
FluxML provides a low-level interface for developing and training deep learning models, whereas BentoML provides a high-level interface for building and deploying machine learning models.
BentoML has built-in support for a variety of machine learning libraries, including TensorFlow, PyTorch, and scikit-learn, whereas FluxML is built on top of Julia and has its own collection of machine learning algorithms.
FluxML is targeted for training deep learning models on high-performance computing clusters, whereas BentoML is built to be highly scalable and manage large volumes of requests.

My opinion:
FluxML and BentoML are both powerful frameworks with distinct purposes. FluxML is recommended for academics and developers who desire low-level control over the training process, whereas BentoML is recommended for developers who want to quickly construct and deploy machine learning models as APIs. The decision between the two is based on the project's specific objectives and aims.

cc @arliss-NF


fix: snapPoints height calculation in android

fixed https://github.com/gluestack/gluestack-ui/issues/2388

I have a doubt. Specifying snappoints for android, pull it inside the safearea. is this intentional?