OpenAI function produces unescaped double-quotes inside JSON String value, causing DecodingError

Describe the bug
When using a JSON function, a JSON Decoding error is sometimes triggered. The error happens because of unescaped double-quotes occurring inside a JSON string value.
To Reproduce
Steps to reproduce the behavior:
The JSON string that causes the error:
"""
{      "question": "Which deep-sea creature is known for its ability to create its own light through bioluminescence?",      "question_summary": "Deep-sea creature that produces its own light",      "correct_answer": "Deep-sea anglerfish",      "incorrect_answer_1": "Lantern shark",      "incorrect_answer_2": "Glowing jellyfish",      "incorrect_answer_3": "Bioluminescent crab",      "humorous_answer": "Lightbulb shrimp",      "humorous_failure_reaction": "Close, but not quite as bright!",      "explanation": "The Deep-sea anglerfish is a fascinating creature that has a unique adaptation for finding food in the deep sea.  This lure is bioluminescent and acts like a "fishing rod" to lure unsuspecting prey."    }
"""
Error happens at "fishing rod" because double-quote is unescaped
Expected behavior
Double quotes inside JSON string values should be escaped.
Screenshots
dataCorrupted(Swift.DecodingError.Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "Badly formed object around line 1, column 757." UserInfo={NSDebugDescription=Badly formed object around line 1, column 757., NSJSONSerializationErrorIndex=757}))):
{      "question": "Which deep-sea creature is known for its ability to create its own light through bioluminescence?",      "question_summary": "Deep-sea creature that produces its own light",      "correct_answer": "Deep-sea anglerfish",      "incorrect_answer_1": "Lantern shark",      "incorrect_answer_2": "Glowing jellyfish",      "incorrect_answer_3": "Bioluminescent crab",      "humorous_answer": "Lightbulb shrimp",      "humorous_failure_reaction": "Close, but not quite as bright!",      "explanation": "The Deep-sea anglerfish is a fascinating creature that has a unique adaptation for finding food in the deep sea.  This lure is bioluminescent and acts like a "fishing rod" to lure unsuspecting prey."    }

I'm getting a similar error here, reproducable for me with this code:
let query = ChatQuery(model: .gpt3_5Turbo, messages: [
    .init(role: .system, content: "You are Librarian-GPT.   Use double quotes which appear both singly and in pairs.")
])

for try await result in openAI.chatsStream(query: query) {
    print(result)
}

Resulting in this:
OpenAITests.swift:133: error: -[OpenAITests.OpenAITests testChatsStream] : failed: caught error: "dataCorrupted(Swift.DecodingError.Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "Unterminated string around line 1, column 101." UserInfo={NSDebugDescription=Unterminated string around line 1, column 101., NSJSONSerializationErrorIndex=101})))"

I'd guess we fix the problem here in StreamingSession w/ a custom JSON decoder that can tolerate any sort of formatted body text? GPT shouldn't necessarily be giving back valid JSON itself, so with no intermediate parsing to go from GPT response -> valid JSON string, it'd make sense that decoding fails.

@brytonsf, @jcmourey,
Did you guys get function calling to work with streaming?
public struct Message: Codable, Hashable, Identifiable {
    public enum MessageType: String, Codable, Hashable {
        case function
        case message
    }

    public var id: String
    public var role: Chat.Role
    public var content: String
    public var createdAt: Date
    public var type: MessageType
    public var functionArguments: FunctionArguments?
}

public struct FunctionArguments: Codable, Hashable {
    public let location: String?
}

I am parsing the function calling arguments like this, with prints correctly the arguments:
                        // Fetch function arguments and assign to message variable
                        var functionArguments: FunctionArguments?
                        if let data = functionCallArguments.data(using: .utf8) {
                            let decoder = JSONDecoder()
                            if let arguments = try? decoder.decode(FunctionArguments.self, from: data) {
                                print("arguments.location is " + (arguments.location?? ""))
                                functionArguments = arguments
                            }

But then "location" is not displayed on the ChatBubbleView( ), probably because the streaming is not complete when the view is displayed
                   Text(message.functionArguments?.location ?? "location placeholder")
Maybe I am doing simmering wen where, and there is another way to fetch the arguments?
Did you get this working?

I got functions to work for me with streaming. I use a "for try await" loop:
var results = ""

for try await result in client.chatsStream(query: query) {
  guard !Task.isCancelled else { return }
  guard let argument = result.choices.first?.delta.functionCall?.arguments else { continue }

  results.append(argument)

I concatenate the results then process them manually. When I have something that looks like a complete JSON object, e.g. an complete element from a JSON array surrounded by matching { }, I use JSONDecoder() on it.
 let leftover = try await processPartialJson(results) // extract and decodes completed JSON objects and returns leftover, incomplete JSON object
 guard let leftover else { return }

 results = leftover
}

awesome! @jcmourey
I am trying to adapt your code to the Chat Demo, but its hard without the processPartialJson and other parts of the code...
Are you using the chat demo also? If yes, mind sharing your view model?

My processPartialJson is too specific for my use case, would be
incomprehensible. You need to think through when you have something out of
the stream string that could be JSON-decoded, extract it, decode it with
JSONDecoder, remove it from the string and keep going.
Le ven. 15 sept. 2023 à 18:17, Alexandre Lordelo @.***>
a écrit :

awesome! @jcmourey https://github.com/jcmourey
I am trying to adapt your code to the Chat Demo, but its hard without the
processPartialJson and other parts of the code...
Are you using the chat demo also? If yes, mind sharing your view model?
—
Reply to this email directly, view it on GitHub
https://github.com/MacPaw/OpenAI/issues/96#issuecomment-1721534186, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAATCIHE65N6LTI7AB45OPTX2R5P7ANCNFSM6AAAAAA3CRS3IQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@jcmourey , this is what I did that kinda works...
The arguments are printed to the console, but the issue is that the view doesn't get updated so I am trying to figure out the best approach....
I added a FunctionArguments to the Message:
import Foundation
import OpenAI
import SwiftUI

public struct Message: Codable, Hashable, Identifiable {
    public enum MessageType: String, Codable, Hashable {
        case function
        case message
    }

    public var id: String
    public var role: Chat.Role // Assuming Chat.Role is Hashable
    public var content: String
    public var createdAt: Date
    public var type: MessageType
    public var functionArguments: FunctionArguments?
}

public struct FunctionArguments: Codable, Hashable {
    public let location: String?
    public let date: String?
}

2- Then I fetch the arguments like this:
     // Fetch function arguments and assign to message variable
                        var functionArguments: FunctionArguments?
                        if let data = functionCallArguments.data(using: .utf8) {
                            let decoder = JSONDecoder()
                            if let arguments = try? decoder.decode(FunctionArguments.self, from: data) {
                                print("arguments.name is " + (arguments.location ?? ""))
                                print("arguments.font is " + (arguments.date ?? ""))
                                functionArguments = arguments
                            }
                        }

Full view model bellow:
          import Foundation
import Combine
import OpenAI

/// チャット画面のViewModel
public final class ChatViewModel: ObservableObject {
    public var openAIClient: OpenAIProtocol

    @Published var conversations: [Conversation] = [] // 会話一覧
    @Published var conversationErrors: [Conversation.ID: Error] = [:] // 会話エラー一覧
    @Published var selectedConversationID: Conversation.ID? // 選択中の会話ID

    var selectedConversation: Conversation? {selectedConversationID.flatMap { id in
        conversations.first { $0.id == id }
        }
    }

    // 選択中のチャット
    var selectedConversationPublisher: AnyPublisher<Conversation?, Never> {
        $selectedConversationID.receive(on: RunLoop.main).map { id in
            self.conversations.first(where: { $0.id == id })
        }
        .eraseToAnyPublisher()
    }

    public init(openAIClient: OpenAIProtocol) {
        self.openAIClient = openAIClient
    }

    // チャットを開始する
    func createConversation() {
        let conversation = Conversation(id: UUID().uuidString, messages: [])
        conversations.append(conversation)
    }

    // チャットを開始する
    func selectConversation(_ conversationId: Conversation.ID?) {
        selectedConversationID = conversationId
    }

    // チャットを開始する
    func deleteConversation(_ conversationId: Conversation.ID) {
        conversations.removeAll(where: { $0.id == conversationId })
    }

    // チャットを開始する
    @MainActor
    func sendMessage(
        _ message: Message,
        conversationId: Conversation.ID,
        model: Model
    ) async {
        guard let conversationIndex = conversations.firstIndex(where: { $0.id == conversationId }) else {
            return
        }
        conversations[conversationIndex].messages.append(message)

        await completeChat(
            conversationId: conversationId,
            model: model
        )
    }

    @MainActor
        func completeChat(
            conversationId: Conversation.ID,
            model: Model
        ) async {
            guard let conversation = conversations.first(where: { $0.id == conversationId }) else {
                return
            }

            conversationErrors[conversationId] = nil

            do {
                guard let conversationIndex = conversations.firstIndex(where: { $0.id == conversationId }) else {
                    return
                }

                let weatherFunction = ChatFunctionDeclaration(
                    name: "getWeatherData",
                    description: "Get the current weather in a given location and date",
                    parameters: .init(
                      type: .object,
                      properties: [
                        "location": .init(type: .string, description: "The city and state, e.g. San Francisco, CA"),
                        "date": .init(type: .string, description: "The city and state, e.g. San Francisco, CA")

                      ],
                      required: ["location"]
                    )
                )

                let functions = [weatherFunction]

                let chatsStream: AsyncThrowingStream<ChatStreamResult, Error> = openAIClient.chatsStream(
                    query: ChatQuery(
                        model: model,
                        messages: conversation.messages.map { message in
                            Chat(role: message.role, content: message.content)
                        },
                        functions: functions
                    )
                )

                var functionCallName = ""
                var functionCallArguments = ""
                for try await partialChatResult in chatsStream {
                    for choice in partialChatResult.choices {
                        let existingMessages = conversations[conversationIndex].messages
                        var messageType: Message.MessageType = .message // Default to message
                        // Function calls are also streamed, so we need to accumulate.
                        if let functionCallDelta = choice.delta.functionCall {
                            if let nameDelta = functionCallDelta.name {
                              functionCallName += nameDelta
                            }
                            if let argumentsDelta = functionCallDelta.arguments {
                              functionCallArguments += argumentsDelta
                                print("Debug: argumentsDelta is : \(String(describing: argumentsDelta))")

                            }
                            print("Debug: functionCallDelta is : \(String(describing: functionCallDelta))")

                            print("Debug: functionCallDelta.name is : \(String(describing: functionCallDelta.name))")

                            print("Debug: ffunctionCallDelta.arguments is : \(String(describing: functionCallDelta.arguments))")

                        }

                        //trying to get stream of
                        var funcDelta = choice.delta.functionCall?.arguments ?? ""
                        print("Debug: funcDelta is : \(funcDelta)")

                        var messageText = choice.delta.content ?? ""
                        if let finishReason = choice.finishReason {
                            if finishReason == "function_call" {
                                messageType = .function
                                messageText += "Function call: name=\(functionCallName) arguments=\(functionCallArguments)"
                            }
                        }
                        print(functionCallArguments)
                        print("Debug: Entire choice object: \(choice)")
                        print("Debug: Entire delta object: \(choice.delta)")

                        // Fetch function arguments and assign to message variable
                        var functionArguments: FunctionArguments?
                        if let data = functionCallArguments.data(using: .utf8) {
                            let decoder = JSONDecoder()
                            if let arguments = try? decoder.decode(FunctionArguments.self, from: data) {
                                print("arguments.name is " + (arguments.location ?? ""))
                                print("arguments.font is " + (arguments.date ?? ""))
                                functionArguments = arguments
                            }
                        }
                        print("Debug: functionArguments object: \(String(describing: functionArguments))")
                        let message = Message(
                            id: partialChatResult.id,
                            role: choice.delta.role ?? .assistant,
                            content: messageText,
                            createdAt: Date(timeIntervalSince1970: TimeInterval(partialChatResult.created)),
                            type: messageType,
                            functionArguments: functionArguments
                        )

                        // Debug: Print the entire message object
                        print("Debug: Created Message: \(message)")

                        if let existingMessageIndex = existingMessages.firstIndex(where: { $0.id == partialChatResult.id }) {
                            // Meld into previous message
                            let previousMessage = existingMessages[existingMessageIndex]
                            let combinedMessage = Message(
                                id: message.id, // id stays the same for different deltas
                                role: message.role,
                                content: previousMessage.content + message.content,
                                createdAt: message.createdAt,
                                type: messageType
                            )
                            conversations[conversationIndex].messages[existingMessageIndex] = combinedMessage
                        } else {
                            conversations[conversationIndex].messages.append(message)
                        }
                    }
                }

            } catch {
                conversationErrors[conversationId] = error
            }
        }
}


net/http: first byte of second request in hijack mode is lost

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.11 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jjz/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jjz/go"
GOPROXY=""
GORACE=""
GOROOT="/opt/go"
GOTMPDIR=""
GOTOOLDIR="/opt/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/x2/t219h_ks1wl4gjwnz82xc17h0000gn/T/go-build513787949=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
Hijack client http request to backend server in go http server.  If the underlay connection is reused which means more than one http request is send over the connection, when first request has body size >0, first byte of the second request will be eat.
To reproduce this issue, I wrote a simple testcase. Client send requests to a transparent proxy who forward requests to backend server in hijack mode. The backend server is a simple echo server, response request method and body to its client. Below are the codes:
Proxy & Server
package main

import (
	"net/http"
	"net"
	"sync"
	"io"
	"fmt"
	"bytes"
)

func echo(w http.ResponseWriter, r *http.Request) {
	w.WriteHeader(200)
	var buf bytes.Buffer
	io.Copy(&buf, r.Body)
	resp := fmt.Sprintf("method: %s, body: %s", r.Method, buf.String())
	w.Write([]byte(resp))
}

type Proxy struct {
	Backend string
}

func (p *Proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) {
	fmt.Printf("Receive a request from %v\n", r.RemoteAddr)
	hj, ok := w.(http.Hijacker)
	if !ok {
		http.Error(w, "webserver doesn't support hijacking", http.StatusInternalServerError)
		return
	}

	backendConn, err := net.Dial("tcp", p.Backend)
	if err != nil {
		fmt.Printf("err: %v\n", err)
		return
	}
	defer backendConn.Close()

	clientConn, bufrw, err := hj.Hijack()
	if err != nil {
		return
	}

	defer clientConn.Close()

	if err := r.Write(backendConn); err != nil {
		return
	}

	var wg = sync.WaitGroup{}
	wg.Add(2)
	copy := func(dst io.Writer, src io.Reader) {
		io.Copy(dst, src)
		if conn, ok := dst.(interface {
			CloseWrite() error
		}); ok {
			conn.CloseWrite()
		}
		wg.Done()
	}

	bufferedReader := io.LimitReader(bufrw, int64(bufrw.Reader.Buffered()))
	mr := io.MultiReader(bufferedReader, clientConn)

	go copy(clientConn, backendConn)
	go copy(backendConn, mr)
	wg.Wait()
}

func main() {
	go http.ListenAndServe(":8081", http.HandlerFunc(echo))

	p := &Proxy{Backend: "localhost:8081"}
	http.ListenAndServe(":8080", p)
}

Client:
package main

import (
	"net/http"
	"bytes"
	"io"
	"os"
	"fmt"
)

func req(client *http.Client, msg string) {
	body := bytes.NewBufferString(msg)
	r, err := http.NewRequest("POST", "http://localhost:8080/", body)
	if err != nil {
		panic(err)
	}
	resp, err := client.Do(r)
	if err != nil {
		panic(err)
	}
	defer resp.Body.Close()
	if _, err := io.Copy(os.Stdout, resp.Body); err != nil {
		panic(err)
	}
}

func main() {
	c := &http.Client{}
	fmt.Println("Send 'Hello'")
	req(c, "Hello")
	fmt.Println()

	fmt.Println("Send 'World'")
	req(c, "World")
}

Run the server in terminal: go run server.go
Open another terminal, run go run client.go

Output show that the letter P (of word POST) POST is lost.
What did you expect to see?
go run client.go
Send 'Hello'
method: POST, body: Hello
Send 'World'
method: POST, body: World

What did you see instead?
go run client.go
Send 'Hello'
method: POST, body: Hello
Send 'World'
method: OST, body: World

Is this a regression in 1.11?
/cc @bradfitz

@FiloSottile I tested go 1.8, 1.9, 1.10, 1.11 on MacOS and Linux， all of them have this issue。
https://go-review.googlesource.com/c/go/+/132479 is a fix.

@jzwlqx I have distilled your repro into an end-to-end test that you can then use in your fixing CL
package main_test

import (
	"bytes"
	"fmt"
	"io"
	"io/ioutil"
	"net"
	"net/http"
	"net/http/httptest"
	"net/url"
	"sync"
	"testing"
)

func TestIssue(t *testing.T) {
	backend := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		slurp, _ := ioutil.ReadAll(r.Body)
		_ = r.Body.Close()
		fmt.Fprintf(w, "method: %s, body: %s\n", r.Method, slurp)
	}))
	defer backend.Close()
	bu, _ := url.Parse(backend.URL)

	proxy := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		hj, ok := w.(http.Hijacker)
		if !ok {
			http.Error(w, "webserver doesn't support hijacking", http.StatusInternalServerError)
			return
		}

		bc, err := net.Dial("tcp", bu.Host)
		if err != nil {
			http.Error(w, err.Error(), http.StatusInternalServerError)
			return
		}
		defer bc.Close()

		cc, bw, err := hj.Hijack()
		if err != nil {
			http.Error(w, err.Error(), http.StatusInternalServerError)
			return
		}
		defer cc.Close()

                if err := r.Write(bc); err != nil {
			http.Error(w, err.Error(), http.StatusInternalServerError)
			return
		}

		var wg sync.WaitGroup
		wg.Add(2)
		cp := func(dst io.Writer, src io.Reader) {
			_, _ = io.Copy(dst, src)
			if conn, ok := dst.(interface {
				CloseWrite() error
			}); ok {
				conn.CloseWrite()
			}
			wg.Done()
		}

		lr := io.LimitReader(bw, int64(bw.Reader.Buffered()))
		mr := io.MultiReader(lr, cc)

		go cp(cc, bc)
		go cp(bc, mr)
		wg.Wait()
	}))
	defer proxy.Close()

	// And now for the client

	gotLog := new(bytes.Buffer)
	clientReq := func(msg string) error {
		body := bytes.NewBufferString(msg)
		req, err := http.NewRequest("POST", proxy.URL, body)
		if err != nil {
			return err
		}
		resp, err := proxy.Client().Do(req)
		if err != nil {
			return err
		}
		_, err = io.Copy(gotLog, resp.Body)
		resp.Body.Close()
		return err
	}

	payloads := []string{"Hello", "World"}
	for _, payload := range payloads {
		if err := clientReq(payload); err != nil {
			t.Fatalf("Payload %q ==> %v", payload, err)
		}
	}
        wantLog := "method: POST, body: Hello\nmethod: POST, body: World\n"
	if g, w := gotLog.String(), wantLog; g != w {
		t.Fatalf("\nGot =%q\nWant=%q", g, w)
	}
}

However, the test  passes undeterministically, for example with:

a count of 5, it passes 2/5 times

$ go test -count=5
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"

a count of 10, it passes 3/10 times

$ go test -count=10
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
--- FAIL: TestIssue (0.00s)
    issue_test.go:98:
        Got ="method: POST, body: Hello\nmethod: OST, body: World\n"
        Want="method: POST, body: Hello\nmethod: POST, body: World\n"
FAIL
exit status 1
FAIL	_/Users/emmanuelodeke/Desktop/openSrc/bugs/golang/27408	0.022s

@odeke-em thanks a lot for your test,  I will add it to the fixing CL.
Did you try run go test with set GOROOT to the newly built go?
Result in my environment with patched go:
% ls
main_test.go
% env GOROOT=/tmp/go-master /tmp/go-master/bin/go  test -count=20
PASS
ok      _/tmp/go-master/t       0.040s

@jzwlqx I ran the test before applying your patch, but as I showed, at times it worked alright and didn't fail 100% of the time. Perhaps that could be due to connection reuse? Anyways you've submitted the patch. Unfortunately your commit message edits aren't reflected on Gerrit so please try to edit them on the PR directly or on Gerrit itself.

@odeke-em That is because there are two goroutines try to read the same tcp connection. One is connRead.backgroundRead in net/http/server.go and the other is handler of proxy in the testcase above. One tcp data arrives, only one goroutine can get it and return from net.Conn.Read。Which goroutine would get the tcp input is undetermined. If backgroundRead read it, one byte lost, If io.Copy in handler get it, everything goes OK.
In the above testcase, body size is too small, if we construct a big enough body, it's inevitable that backgroundRead would get one byte at sometime and one byte lost.


Gateway service dev orchestration

Description

Merge all microservice initial package/module into backend-dev for team to start with
Tested Gateway and Eureka to ensure proper routing through a dummy endpoint created under user service
Note: there is extra domain namespace layer at microservice level, need to determine if it is necessary @pengc7
i.e
 mvc:  servlet:    path: /user-service

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Please also list any relevant details for your test configuration.

[ ] Unit Test

[x] Postman Test

[ ] Integration Test

[ ] End-to-end Test (Frontend + Backend)

Checklist:
Before you submit your Pull Request, please check you have completed the following:

[x] I have added tests that prove that my feature works or my fix is effective.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

Additional Notes

I think add one layer for each service like  mvc: servlet: path: /user-service is necessary. It helps to others to understand our services architecture and reduce ambiguity.


Remove dependencies descriptions from readme

Context for reviewers
Potentially controversial? I'm proposing we remove the list of dependencies from the README, because:

package.json already serves as a source of truth for finding what dependencies are installed

The list in the README only includes a description of each module, which can be found in the dependency's readme on its repo or NPM page. Some IDE's also provide the description automatically when you hover over the name:

This makes the README pretty lengthy, distracting from potentially more important documentation.

Project teams would have to maintain this list for it to remain relevant. Given its only descriptions right now, effort doesn't seem worth it.

I could see for example a docs/app/internationalization.md and a docs/app/architecture.md explaining the use of i18next and USWDS, respectively

For the record, I agree with this decision, I was the one who most recently brought it up to date with the package.json and found that process super monotonous, I should have thought of doing this then! But better late than never, I think it's a good call!

Thanks for doing this - much more maintainable!


Fix up flight_replay.py doc/example to DKPY2. Note, still has bug #355

This fixes up the flight_replay example and associated docs to be "DKPY2 compliant". This includes adding vehicle.close and connect, and making the example docs follow the same pattern as the other example docs.
NOTE:

This does not work! There is an exception due to #355 . The docs have a note to this effect. When the bug is fixed we'll have to revisit and retest the docs/code.
This hamishwillee dronecode key and api. The old version failed because droneshare now insists on a key with the correct format.
Even though this does not "work", it is a better example to have for DKPY2 for people to learn from. The old example would not work either due to the bad key!

Fixed. Ready to merge.


Auto build release, docker ..

Can refer to Helix project:
https://github.com/helix-editor/helix/blob/master/.github/workflows/release.yml

[x] auto create release with tags
[ ] nightly build every day
[ ] deploy docker

Added create release with tags, build to macos, linux gnu. Linux musl have some compile error about libopus


Exclude InputStreamReader.utf8 as invalid test

Related: https://github.com/eclipse/openj9/issues/7020
Signed-off-by<EMAIL_ADDRESS><EMAIL_ADDRESS>

Test: /Test_grinder/job/Grinder/3439/console


chore: updated some destination url

@degrammer what about the redirects? We deprive ourselves to fix links retroactively with packaged and released software. The idea wasn't to do one or the other PR but bring together both.


Only show contributions to active curators

Perhaps think of a way to show them to people who have been curators before, but are no longer, but hide them from regular users for sure.

Moot in new design


Initializing idleCpus

Since idleCpus was never initialized it never actually completes any cpu jobs.  I initialized idleCpus to the parameter value at the beginning of run.

Nice job finding this quicker than we did, hah. I more kosher way of doing this is initializing it properly in the constructor:
    Simulation(SimulationParameters p,                std::unique_ptr<ReadyQueue>&& r,                std::unique_ptr<CacheAlgorithm>&& c)       : queue(),         ready(std::move(r)),         cache(std::move(c)),         jobs(),         devices(),         idleCpu(p.cpus),         curTime(0.0f),         parameters(p)     {     }

As other parameter based items are not initialized until run I chose to
initialize it there.  Assuming you could call run multiple times.  I did
not read it enough to determine if you could actually run it multiple times.
On Mar 29, 2017 4:31 PM, "Jack Conrad Kiefer II"<EMAIL_ADDRESS>wrote:

Nice job finding this quicker than we did, hah. I more kosher way of doing
this is initializing it properly in the constructor:
Simulation(SimulationParameters p, std::unique_ptr&& r,
std::unique_ptr&& c) : queue(), ready(std::move(r)),
cache(std::move(c)), jobs(), devices(), idleCpu(p.cpus), curTime(0.0f),
parameters(p) { }
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ksundberg/CourseMaterials/pull/2#issuecomment-290246319,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3F955Df9aCQRGM7X-NsR0P3-4Z9Nhqks5rqtujgaJpZM4Mtf8n
.


e2e test pr_bot, codebuild image and sample test

Overview
Adds e2e testing requirements:

Codebuild image - tests are to be run in codebuild, custom image provides python 3.6.9 and 3.7.4 via pyenv.
pr_bot - lambda function that is scheduled to poll the repo for pr comments which contain the tag /do-e2e-tests. Comment must come from a user that is listed as a maintainer in the PROJECT_MAINTAINERS env var.
initial e2e test that checks whether taskcat cli is able to output help messages without failing.

will be testing the functionality here by putting in comments.

/do-e2e-tests

end to end tests passed

/do-e2e-tests

/do-e2e-tests

Nice work on this @jaymccon

/do-e2e-tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@95ca43d). Click here to learn what that means.
The diff coverage is 37.5%.

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage          ?   40.95%
=========================================
  Files             ?       28
  Lines             ?     3550
  Branches          ?      618
=========================================
  Hits              ?     1454
  Misses            ?     2002
  Partials          ?       94

Impacted Files
Coverage Δ

taskcat/_cli_core.py
16.66% <18.18%> (ø)

taskcat/_cfn_lint.py
51.13% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ca43d...e657885. Read the comment docs.

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

closing this due to all the testing comments, will re-open


Manage plan status

https://www.pivotaltracker.com/story/show/120867115
Plan statuses include:

draft

in review (call it something else; loose status w/no controls; add alerts for users to leave feedback on plans/notify when they receive new feedback)

complete

submitted: future status to mark plans of record/submitted to funder; corresponds with lifecycle; used for integrations, e.g., with repositories

Question about whether status changes can be done manually or whether they should only occur automatically (triggered by clicking a button e.g. "Export")
Note plan terms that correspond with the database:

Type (is it a test plan? y/n)
Status (draft...complete...)
Visibility (public/organizational/private)

Perhaps 'under comment' for 'in review' or do we need to differentiate this one?

per discussions w/ @sjDCC and UX I think we just need an automatically triggered 'complete' status for MVP. this will help us manage the Public DMPs list (by only displaying 'complete' plans in the list #88) and potentially to manage the admin view into plans created by users at their org.
larger discussions about status/lifecycle should wait for maDMP future enhancements

We now have a complete flag in the database table @sjDCC and @stephaniesimms. This flag gets set when > 50% of the questions have been answered. Should this ticket be closed?

yes let's close this stale issue. we have plan lifecycle/status indicators listed as a future enhancement on the wiki but it requires more discussion.


preparing dataset

I was wonderful to know that this repository gives considerable speech reverberation result.
So I've tried to train reverb model with LibiSpeech corpus.
I've all done making reverberation wave dataset.
But I dont well know how I can make mfcc and lps dataset.
I've used the script in calculation of mfcc like this:
"""
if [ $stage -le 6 ]; then
for part in dev_clean test_clean dev_other test_other train_clean_100; do
steps/make_mfcc.sh --cmd "$train_cmd" --nj 40 data/$part exp/make_mfcc/$part $mfccdir
steps/compute_cmvn_stats.sh data/$part exp/make_mfcc/$part $mfccdir
done
fi
"""
and i've replaced "compute-mfcc-feats" as "compute-spectrogram-feats" for LPS.
Then I am trying to use cmvn_train.ark cmvn_train_reverb.ark of "mfcc " directory as labels.cmvn and inputs.cmvn.
but I've got following error on stage 0.
"""
Prepare tr and cv data
Make Numpy format Global CMVN file ...
Convert data/train/inputs.cmvn and data/train/labels.cmvn to Numpy format
Input .ark file is not binary
"""
I dont well know also how I can make cv.list, train.list.
It would be greatly appreciated if you could tell me how to make it.
Thanks
Ting

You can find the details in my code about converting Kaldi binary format CMVN to numpy format. By the way, this code just support python2.X.
So I think this issue is likely because your CMVN file is not binary file. Maybe you should check your Kaldi command on CMVN generation.

Thanks for your reply.
may i convert simply .ark into binary format?

Could you share sample CMVN file?

Thanks for your reply.
may i convert simply .ark into binary format?
I think .ark file contains all cmvn features for all audio file.
your python file seems an parser file for only the cmvn file of an audio file.
RIght?

I think I have known your issue. For speech enhancement task, we'd better use global CMVN, but you used utterance-level CMVN. This is why you can't convert you CMVN file to Numpy format. I think you can refer to Kalid document and learn how to compute global CMVN.
By the way, if you use utterance-level CMVN, when you want convert the normalized LPS to original LPS, how can you get the CLEAN utterance-level CMVN in the test stage. This is why we use global CMVN.

Could you share sample CMVN file?

I'm really sorry to this. Because there are not some suitable audios in hand to extract LPS/MFCC and compute their CMVN.


Support partition upload

Signed-off-by: Jim Ma<EMAIL_ADDRESS>
Support partition upload
Optimize const url

Thank you, Jim : )


restart file creation for seedclim sites

I will go through the necessary steps to create proper restart files for simulations over the seedclim sites:
(1) thousands of years pre-industrial simulation
(2) historical simulation from pre-industry to present

When the new model versions are incorporated and new input data is ready, start running spin-up simulations and see when it stabilises

We have decided not to provide restart files for the first published version. Might be relevant to include for future releases.


Vendor compatibility with sklearn model_selection

In order to evaluate Vendor objects, it makes sense to ensure compatibility with some Sklearn features. Full compatibility with BaseEstimator is out of scope, because Vendors may support intent and entity recognition and as such are already somewhat incompatible with Sklearn BaseEstimator. But compatibility with some modules, e.g. model_selection, would be good to avoid reinventing multiple wheels...
As a minimum, we should define some rules for creating Vendors such that they can safely be used in model_selection, even if not fully implementing the BaseEstimator Interface, e.g.

ensure training always starts with a fresh untrained model
the object can be cloned safely
get_params method would probably also be useful, if just for nicer display with repr()

see also https://scikit-learn.org/stable/developers/develop.html


⚠ Bofrost.de has degraded performance

In 86fe51a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1171 ms

Resolved: Bofrost.de performance has improved in 0604106 after 9 minutes.


Fix subscribed bookend not displayed for newly subscribed stream.

discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/.F0.9F.8E.AF.20Missing.20subscribed.20bookends

Tested that subscribing to Denmark for Iago displays the subscribed bookend and updating the stream privacy works corretcly to only update the bookend if it displayed and not show one if it is not required.
Tested channel archieved booked is displayed when deleting a stream.

Tested toggle subscribed button works in the trailing bookend.

This is great, merged after changing the comment to refer to the possibility of non-stream views as suggested in https://github.com/zulip/zulip/pull/30736#discussion_r1667059636. Thanks @amanagr!


Support for armv7

Is your feature request related to a problem? Please describe.
I wanted to install netbird on a router from Teltonika. They have a package manager built-in. I saw that there are already integrations for Tailscale or ZeroTier. So it would be helpful to have the package built in to the web-ui.
But for now it would be great first to have support for this platform.
The error I get from the installation script:
Architecture armv7l not supported
Describe the solution you'd like
Support the platform armv7.
Describe alternatives you've considered
Alternative would be to use Tailscale instead.

@Lamera can you test with the arm6 binaries from our release page?
https://github.com/netbirdio/netbird/releases
https://github.com/netbirdio/netbird/releases/download/v0.28.2/netbird_0.28.2_linux_armv6.tar.gz

@mlsmaycon This binary works! Thank you!
Would be nice to see an official support in the install script or better via the package manager from Teltonika.

Sorry for the question but is there a way to change the binarys root from your post ? He searches in / but i need /opt because i'am running DD-WRT with Entware and on DD-WRT is / read-only.
I tried a few ways but he always stays in /.
Thank you ...

I'm actually trying to run armv6 binaries on Teltonika RUTX50 router (armv7) and having this issue:
2024-09-02T20:49:48Z ERRO util/grpc/dialer.go:38: Failed to dial: dial: dial tcp <IP_ADDRESS>:443: connect: invalid argument

Raspberry Pi 2B   also no longer supported )))
Why did you stop supporting so early armv7l?


cnt play

Could we have a command that
cnt update
rkt run # with DEBUG/TRACE level to see the resolving template.

This is for a quick iteration process.

not sure it's a good approch. especially since I don't know what should be the rkt parameters.
cnt update && rkt run --set-env=LOG_LEVEL=TRACE ... should do the job ?

use cnt update && rkt run --set-env=LOG_LEVEL=TRACE ... instead


Fixing structure typo in test setup

A curly brace is incorrectly placed leading to errors trying to setup tests.
PR Summary

PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Maybe worth trying to understand why this bug was undetected for so long.

/azp run PowerShell-CI-macos

/remind me tomorrow

/azp run PowerShell-CI-windows

/remind me tomorrow


Weaviate 0.22.3 displays the wrong version

Running 0.22.4 results in displaying:
{
contextionaryVersion: "en0.10.0-v0.4.7",
contextionaryWordCount: 677763,
hostname: "http://[::]:8080",
version: "0.22.3" <== WHOOPS
}

On the meta endpoint

Thanks for finding this. This means something in the build process must have gone wrong, as this is never set manually. I'll investigate.

Found the problem, the tag is on the commit that updates the swagger.json, but the generate_code_from_swagger hadn't run yet at that point, so that's only in the next commit. But Weaviate was already published at that point.

I'll republish which should fix this. Note that this is only a cosmetic issue, all changes are contained in the latest release.

Build is triggered. The issue should be fixed when the built is through, keeping open until then.

Cool, it was a bit confusing for me 😆

Fixed after re-release
curl -s localhost:8080/v1/meta | jq
{
  "contextionaryVersion": "en0.10.0-v0.4.7",
  "contextionaryWordCount": 677763,
  "hostname": "http://[::]:8080",
  "version": "0.22.4"
}


Has the maintenance of this repository been stopped?

Hi!
Has the maintenance of this repository been stopped?
Because i find that the codes haven't been updated in two years.

I guess so


Changing source

Hey there seems to be a problem with changing the source after its initially set, getting null exception on this line right here

Maybe the Element.Source you're changing to is not valid and Resources.GetDrawable returns null?

Indeed it did, VS were not treating the .png file as a android resource :/


add note to Swarm docs to refer to swarm mode in Engine

Add note to Swarm overview referring to "swarm mode".
Signed-off-by: Charles Smith<EMAIL_ADDRESS>

@dongluochen , for some reason, the local build doesn't include the Engine menu with the path swarm/index.md, but this is the correct path. It comes from the /docker/docker repo.
The only link issues found with the CI have to do with some Docker Mac/Docker Win items that are not accessible by the link checker:
23:49:36 	106.848304ms (152.584647ms)	   22.52 MB 	145465 Allocs
23:49:36 ERROR: 2016/06/17 23:49:35 content_renderer.go:56: LinkResolver: No page found for "/docker-for-mac/index.md" on page "engine/getstarted/step_one.md".
23:49:36 ERROR: 2016/06/17 23:49:35 content_renderer.go:56: LinkResolver: No page found for "/docker-for-windows/index.md" on page "engine/getstarted/step_one.md".
23:49:36 ERROR: 2016/06/17 23:49:35 content_renderer.go:56: LinkResolver: No page found for "/docker-for-mac/index.md" on page "engine/installation/mac.md".
23:49:36 ERROR: 2016/06/17 23:49:35 content_renderer.go:56: LinkResolver: No page found for "/docker-for-windows/index.md" on page "engine/installation/windows.md".
23:49:36 ERROR: 2016/06/17 23:49:35 content_renderer.go:56: LinkResolver: No page found for "/docker-for-mac/index.md" on page "engine/getstarted/last_page.md".
23:49:36 ERROR: 2016/06/17 23:49:35 content_renderer.go:56: LinkResolver: No page found for "/docker-for-windows/index.md" on page "engine/getstarted/last_page.md".
23:49:36 convert source:

Yes, the "/engine/swarm" link is ok, but won't be in the current make docs build, because that builds the "engine" docs for the current release (1.11). So, it's ok to merge, but it's annoying and I don't know what the best approach would be for CI :cry:
LGTM


Can't select Steam (165 degree Recipe)

Problem Description
Preface:
Using Industrial Revolution 3 and trying to use Electric Boiler
I have various buildings which need steam:

When I click to add new recipe, it automatically adds one (Without letting me select a recipe), which is boilers/etc. However, there is a recipe in game, that produces 165° steam, that can be used provided by the electric boiler. I'm unable to add that recipe to provide steam for the factory block. Here's a new block showing the 165° steam:

How do I have it choose this as a valid boiler to be used?
Reproduction
No response

Hello, thanks for the report, and sorry for not getting to it earlier.
This is indeed kind of a bug, I've known about it for a long time, but it's very hard to rectify. It'll require a redo of a whole underlying system, which I haven't gotten to yet. I hope to get to it soon, but don't know when yet.


publish pages automatically

publish playground to gh-pages automatically.

https://www.ruanyifeng.com/blog/2019/09/getting-started-with-github-actions.html


Yeoman and ng-table

Anyone tried this with Yeoman?
As soon as I add ['ntTable'] to the module, it kills all pages (with no errors nowhere).
Steps to reproduce:

yo angular (yes to all)  // generates an Angular application
bower install ng-table
yo angular:route Demo // creates a Demo route and controller
paste in Example #1 in views/demo.html
paste in Example#1 in scripts/controllers/demo,js
manually add "" to your index.html page
grunt serve // starts the application
http://<IP_ADDRESS>:9000/                // nothing will be there.
http://<IP_ADDRESS>:9000/#/Demo    // nothing will be there.
remove ['ngTable'] from the module definition in demo.js
http://<IP_ADDRESS>:9000                 // pages are back.
http://<IP_ADDRESS>:9000/#/Demo    // page is empty but it's rendering.

Thanks for your help!
BTW... Great directive...wish I could use it!
/sd

Hello,
I have the same issue..
But like u said mordra I've added the dependency in app.js like this :
"angular
.module('webAppApp', [
'ngAnimate',
'ngTable'
])"
Still doesn't work..
got this message in console
"
[$injector:nomod] Module 'ngTable' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
http://errors.angularjs.org/1.3.10/$injector/nomod?p0=ngTable"
I tried tons of things.. bower update/ tried to add in the index.html the link to the ng-table folder..
Still doesn't work..
Does anyone figured out something?
thx a lot !

hello,
Even i am getting the same error. ngTable is not working with angular with yoeman, Can anyone explain how to use ngTable with yoeman angular full stack. ??

Go to client/app/app.js and add 'ngTable' at the end like below:
angular.module('uolmsApp', [
  'ngCookies',
  'ngResource',
  'ngSanitize',
  'btford.socket-io',
  'ui.router',
  'ui.bootstrap',
  'ngTable'
])

Still doesn't work for me!
I have "ngTableParams" in my controller and ngTable in the angular.module but i still get the "Failed to instantiate module ngTable due to:
Error: [$injector:nomod] Module 'ngTable' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument."
Any idea anyone?
The module is imported correctly since I do this "console.log("initializing ngTable")"  right after
"(function(angular, factory) {
'use strict';
"
in ng-table.js..

you should install with --save the module  bower install --save ng-table, in my case if just use bower install ng-table this don't works

I've made sure that all the suggested solutions above are true for me, and I still get the same error.
I used bower install --save ng-table, and I use gulp-inject to put the bower_components in my index.html as you can see in the image below:

My app.tables module looks like this:
(function() {
  'use strict';

  angular.module('app.tables', [
    'app.core',
    'app.headers',
    'ngTable'
  ]);
})();

And my TablesController begins like this:
(function () {
  'use strict';

  angular
    .module('app.tables')
    .controller('TablesController', TablesController);

  TablesController.$inject = ['$filter', '$sce', 'NgTableParams', 'TablesService'];

  /* @ngInject */
  function TablesController($filter, $sce, NgTableParams, TablesService) {
    var vm = this;
    vm.title = 'TablesController';

    activate();

    ////////////////

    [...]

@jakehockey10 First thing I notice is- you have used 'NgTableParams', I believe that needs to be 'ngTableParams'. Another good thing to check the loading order of the ng-table script (gulp might inject it int the wrong order). Spend some time on re-ordering the scripts. Ideally, ngTable should load later as far as I can remember from my previous project.

@pmahmud I have tried both NgTableParams as well as ngTableParams many times back and forth.  I will try to make gulp inject it later, but I'm not familiar with gulp-inject as well as I need to be, so I'm not sure how to go about this quite yet.  I'll keep you posted of my findings.

Hi everyone!
I've recently updated Angular Full-Stack Generator to version 4.1.0 and I'm not able to use ngTable (version 2.1.0). In the older version of generator (3.7.6) it was working fine, so I'm not sure if they are not compatibles..
I import the module like this:
import ngTable from 'ng-table';
...
angular.module('myApp', [..., ngTable])

But I'm getting this error:
Error: [$injector:modulerr] Failed to instantiate module tachologyApp due to:
[$injector:modulerr] Failed to instantiate module {"ngTable":{"_invokeQueue":[],"_configBlocks":[],"_runBlocks":[],"requires":["ngTable-core","ngTable-browser"],"name":"ngTable"},"default":{"_invokeQueue":[["$provide","provider",{"0":"ngTableDefaultGetData"}],["$provide","value",{"0":"ngTableDefaults","1":{"params":{},"settings":{}}}],["$provide","factory",{"0":"NgTableParams"}],["$provide","factory",{"0":"ngTableEventsChannel"}]],"_configBlocks":[],"_runBlocks":[],"requires":[],"name":"ngTable-core"}} due to:
[ng:areq] Argument 'module' is not a function, got Object
http://errors.angularjs.org/1.5.8/ng/areq?p0=module&p1=not%20a%20function%2C%20got%20Object
minErr/<@http://localhost:3000/vendor.bundle.js:194:13
assertArg@http://localhost:3000/vendor.bundle.js:2018:12
assertArgFn@http://localhost:3000/vendor.bundle.js:2028:4
loadModules/<@http://localhost:3000/vendor.bundle.js:4752:12
forEach@http://localhost:3000/vendor.bundle.js:447:12
loadModules@http://localhost:3000/vendor.bundle.js:4727:6
loadModules/<@http://localhost:3000/vendor.bundle.js:4744:41
forEach@http://localhost:3000/vendor.bundle.js:447:12
loadModules@http://localhost:3000/vendor.bundle.js:4727:6
createInjector@http://localhost:3000/vendor.bundle.js:4649:20
bootstrap/doBootstrap@http://localhost:3000/vendor.bundle.js:1884:21
bootstrap@http://localhost:3000/vendor.bundle.js:1905:13
@http://localhost:3000/app.bundle.js:94:4
trigger@http://localhost:3000/vendor.bundle.js:3333:8
defaultHandlerWrapper@http://localhost:3000/vendor.bundle.js:3623:4
createEventHandler/eventHandler@http://localhost:3000/vendor.bundle.js:3611:10

http://errors.angularjs.org/1.5.8/$injector/modulerr?p0=%7B%22ngTable%22%3A%7B%22_invokeQueue%22%3A%5B%5D%2C%22_configBlocks%22%3A%5B%5D%2C%22_runBlocks%22%3A%5B%5D%2C%22requires%22%3A%5B%22ngTable-core%22%2C%22ngTable-browser%22%5D%2C%22name%22%3A%22ngTable%22%7D%2C%22default%22%3A%7B%22_invokeQueue%22%3A%5B%5B%22%24provide%22%2C%22provider%22%2C%7B%220%22%3A%22ngTableDefaultGetData%22%7D%5D%2C%5B%22%24provide%22%2C%22value%22%2C%7B%220%22%3A%22ngTableDefaults%22%2C%221%22%3A%7B%22params%22%3A%7B%7D%2C%22settings%22%3A%7B%7D%7D%7D%5D%2C%5B%22%24provide%22%2C%22factory%22%2C%7B%220%22%3A%22NgTableParams%22%7D%5D%2C%5B%22%24provide%22%2C%22factory%22%2C%7B%220%22%3A%22ngTableEventsChannel%22%7D%5D%5D%2C%22_configBlocks%22%3A%5B%5D%2C%22_runBlocks%22%3A%5B%5D%2C%22requires%22%3A%5B%5D%2C%22name%22%3A%22ngTable-core%22%7D%7D&p1=%5Bng%3Aareq%5D%20Argument%20'module'%20is%20not%20a%20function%2C%20got%20Object%0Ahttp%3A%2F%2Ferrors.angularjs.org%2F1.5.8%2Fng%2Fareq%3Fp0%3Dmodule%26p1%3Dnot%2520a%2520function%252C%2520got%2520Object%0AminErr%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A194%3A13%0AassertArg%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A2018%3A12%0AassertArgFn%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A2028%3A4%0AloadModules%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4752%3A12%0AforEach%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A447%3A12%0AloadModules%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4727%3A6%0AloadModules%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4744%3A41%0AforEach%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A447%3A12%0AloadModules%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4727%3A6%0AcreateInjector%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4649%3A20%0Abootstrap%2FdoBootstrap%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A1884%3A21%0Abootstrap%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A1905%3A13%0A%40http%3A%2F%2Flocalhost%3A3000%2Fapp.bundle.js%3A94%3A4%0Atrigger%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3333%3A8%0AdefaultHandlerWrapper%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3623%3A4%0AcreateEventHandler%2FeventHandler%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3611%3A10%0A
minErr/<@http://localhost:3000/vendor.bundle.js:194:13
loadModules/<@http://localhost:3000/vendor.bundle.js:4766:16
forEach@http://localhost:3000/vendor.bundle.js:447:12
loadModules@http://localhost:3000/vendor.bundle.js:4727:6
loadModules/<@http://localhost:3000/vendor.bundle.js:4744:41
forEach@http://localhost:3000/vendor.bundle.js:447:12
loadModules@http://localhost:3000/vendor.bundle.js:4727:6
createInjector@http://localhost:3000/vendor.bundle.js:4649:20
bootstrap/doBootstrap@http://localhost:3000/vendor.bundle.js:1884:21
bootstrap@http://localhost:3000/vendor.bundle.js:1905:13
@http://localhost:3000/app.bundle.js:94:4
trigger@http://localhost:3000/vendor.bundle.js:3333:8
defaultHandlerWrapper@http://localhost:3000/vendor.bundle.js:3623:4
createEventHandler/eventHandler@http://localhost:3000/vendor.bundle.js:3611:10

http://errors.angularjs.org/1.5.8/$injector/modulerr?p0=tachologyApp&p1=%5B%24injector%3Amodulerr%5D%20Failed%20to%20instantiate%20module%20%7B%22ngTable%22%3A%7B%22_invokeQueue%22%3A%5B%5D%2C%22_configBlocks%22%3A%5B%5D%2C%22_runBlocks%22%3A%5B%5D%2C%22requires%22%3A%5B%22ngTable-core%22%2C%22ngTable-browser%22%5D%2C%22name%22%3A%22ngTable%22%7D%2C%22default%22%3A%7B%22_invokeQueue%22%3A%5B%5B%22%24provide%22%2C%22provider%22%2C%7B%220%22%3A%22ngTableDefaultGetData%22%7D%5D%2C%5B%22%24provide%22%2C%22value%22%2C%7B%220%22%3A%22ngTableDefaults%22%2C%221%22%3A%7B%22params%22%3A%7B%7D%2C%22settings%22%3A%7B%7D%7D%7D%5D%2C%5B%22%24provide%22%2C%22factory%22%2C%7B%220%22%3A%22NgTableParams%22%7D%5D%2C%5B%22%24provide%22%2C%22factory%22%2C%7B%220%22%3A%22ngTableEventsChannel%22%7D%5D%5D%2C%22_configBlocks%22%3A%5B%5D%2C%22_runBlocks%22%3A%5B%5D%2C%22requires%22%3A%5B%5D%2C%22name%22%3A%22ngTable-core%22%7D%7D%20due%20to%3A%0A%5Bng%3Aareq%5D%20Argument%20'module'%20is%20not%20a%20function%2C%20got%20Object%0Ahttp%3A%2F%2Ferrors.angularjs.org%2F1.5.8%2Fng%2Fareq%3Fp0%3Dmodule%26p1%3Dnot%2520a%2520function%252C%2520got%2520Object%0AminErr%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A194%3A13%0AassertArg%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A2018%3A12%0AassertArgFn%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A2028%3A4%0AloadModules%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4752%3A12%0AforEach%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A447%3A12%0AloadModules%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4727%3A6%0AloadModules%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4744%3A41%0AforEach%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A447%3A12%0AloadModules%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4727%3A6%0AcreateInjector%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4649%3A20%0Abootstrap%2FdoBootstrap%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A1884%3A21%0Abootstrap%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A1905%3A13%0A%40http%3A%2F%2Flocalhost%3A3000%2Fapp.bundle.js%3A94%3A4%0Atrigger%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3333%3A8%0AdefaultHandlerWrapper%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3623%3A4%0AcreateEventHandler%2FeventHandler%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3611%3A10%0A%0Ahttp%3A%2F%2Ferrors.angularjs.org%2F1.5.8%2F%24injector%2Fmodulerr%3Fp0%3D%257B%2522ngTable%2522%253A%257B%2522_invokeQueue%2522%253A%255B%255D%252C%2522_configBlocks%2522%253A%255B%255D%252C%2522_runBlocks%2522%253A%255B%255D%252C%2522requires%2522%253A%255B%2522ngTable-core%2522%252C%2522ngTable-browser%2522%255D%252C%2522name%2522%253A%2522ngTable%2522%257D%252C%2522default%2522%253A%257B%2522_invokeQueue%2522%253A%255B%255B%2522%2524provide%2522%252C%2522provider%2522%252C%257B%25220%2522%253A%2522ngTableDefaultGetData%2522%257D%255D%252C%255B%2522%2524provide%2522%252C%2522value%2522%252C%257B%25220%2522%253A%2522ngTableDefaults%2522%252C%25221%2522%253A%257B%2522params%2522%253A%257B%257D%252C%2522settings%2522%253A%257B%257D%257D%257D%255D%252C%255B%2522%2524provide%2522%252C%2522factory%2522%252C%257B%25220%2522%253A%2522NgTableParams%2522%257D%255D%252C%255B%2522%2524provide%2522%252C%2522factory%2522%252C%257B%25220%2522%253A%2522ngTableEventsChannel%2522%257D%255D%255D%252C%2522_configBlocks%2522%253A%255B%255D%252C%2522_runBlocks%2522%253A%255B%255D%252C%2522requires%2522%253A%255B%255D%252C%2522name%2522%253A%2522ngTable-core%2522%257D%257D%26p1%3D%255Bng%253Aareq%255D%2520Argument%2520'module'%2520is%2520not%2520a%2520function%252C%2520got%2520Object%250Ahttp%253A%252F%252Ferrors.angularjs.org%252F1.5.8%252Fng%252Fareq%253Fp0%253Dmodule%2526p1%253Dnot%252520a%252520function%25252C%252520got%252520Object%250AminErr%252F%253C%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A194%253A13%250AassertArg%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A2018%253A12%250AassertArgFn%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A2028%253A4%250AloadModules%252F%253C%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A4752%253A12%250AforEach%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A447%253A12%250AloadModules%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A4727%253A6%250AloadModules%252F%253C%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A4744%253A41%250AforEach%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A447%253A12%250AloadModules%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A4727%253A6%250AcreateInjector%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A4649%253A20%250Abootstrap%252FdoBootstrap%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A1884%253A21%250Abootstrap%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A1905%253A13%250A%2540http%253A%252F%252Flocalhost%253A3000%252Fapp.bundle.js%253A94%253A4%250Atrigger%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A3333%253A8%250AdefaultHandlerWrapper%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A3623%253A4%250AcreateEventHandler%252FeventHandler%2540http%253A%252F%252Flocalhost%253A3000%252Fvendor.bundle.js%253A3611%253A10%250A%0AminErr%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A194%3A13%0AloadModules%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4766%3A16%0AforEach%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A447%3A12%0AloadModules%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4727%3A6%0AloadModules%2F%3C%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4744%3A41%0AforEach%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A447%3A12%0AloadModules%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4727%3A6%0AcreateInjector%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A4649%3A20%0Abootstrap%2FdoBootstrap%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A1884%3A21%0Abootstrap%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A1905%3A13%0A%40http%3A%2F%2Flocalhost%3A3000%2Fapp.bundle.js%3A94%3A4%0Atrigger%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3333%3A8%0AdefaultHandlerWrapper%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3623%3A4%0AcreateEventHandler%2FeventHandler%40http%3A%2F%2Flocalhost%3A3000%2Fvendor.bundle.js%3A3611%3A10%0A

Please, let me know if someone is also stuck on this or knows how to solve it.
Thanks in advance!

@nsanz same error, could you solve it?


"The table below describes the basic types of audit events. " - rephrase...?

I'm not certain whether the events in the table are logged at which audit level; the sentence "The table below describes the basic types of audit events. " suggests an audit level of basic will log these events.  Is my interpretation correct?  If so, perhaps rephrase that sentence
"With Audit Level set to Basic, AD FS logs these audit events;"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9b97a9e9-7fb7-1938-d023-4c3070511c8e
Version Independent ID: 3484cb96-6a87-13fb-a015-2cbb37f6f7f4
Content: Auditing Enhancements to AD FS in Windows Server 2016
Content Source: WindowsServerDocs/identity/ad-fs/technical-reference/auditing-enhancements-to-ad-fs-in-windows-server.md
Product: windows-server-threshold
GitHub Login: @billmath
Microsoft Alias: billmath

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close

#assign:IngridAtMicrosoft


Invalid next npm version tag

According to the installation guide and to this comment, the next npm version tag should refer to the 3.0.0-alpha.4 version.
Currently, it refers to the latest version (2.2.16).

Whoops, thanks for reporting this. It's now fixed


Add additional provisioning tests to OnTag

Issue:  Fix Ontag Automation runs

Problem

The OnTag runs that are ran currently lack a number of different provisioning tests. These include node provisioning tests for RKE2/K3s and custom cluster provisioning tests for RKE2/K3s. This PR aims to add support for those missing provisioning tests so that they are covered in the OnTag runs.
Solution

Added EC2/Azure node provider support for RKE2/K3s in the Jenkinsfile_ontag_matrix file. In the same file, added support for custom cluster provisioning for RKE2/K3s.
In order to properly run, a config file containing all of the different provisioning tests is added. Each test is separated by the YAML separator --- to make the tests cleaner/ability to use one big YAML instead of creating individual files.
Testing

Engineering Testing
Manual Testing

Automated Testing

Jenkins runs will be provided to the reviewers.

Closing in favor of https://github.com/rancher/rancher/pull/40794. The wrong release/v2.7 is being used.


Can not install nhttp after migrate to new version

please try again with npm create nhttp@latest.
ref => https://github.com/nhttp/create-nhttp/releases/tag/0.1.1


Documentation for OneStream Connector

This is the documentation for the OneStream connector which is being submitted for certification.

@os-mik,
Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request.
Thanks!
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@microsoft-github-policy-service agree company="OneStream Software"

@DougKlopfenstein -

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

NOTE: as a new article, the commits in this PR will need to be moved to the private repo for staging and a full review. Let us know if you'd like our assistance with that.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#assign:ptyx507x
#assign:jonburchel

@os-mik
Could you add a table of contents entry for this connector article? The table of contents file is toc.yml. The connectors are listed in the table of contents in alphabetical order.

@DougKlopfenstein
Table of Contents updated. Let me know if anything else needed. Thanks!

#sign-off

Hi @os-mik
Before this PR can be merged, you'll need to update the pbi-get-data.png image. That Power BI Desktop screen no longer exists. You might need to update your Power BI Desktop to get the modern screen. Also, if you take a new image, make sure any personal information (like a person's name or a server name) is fictional.
#hold-off

#sign-off

@os-mik - we'll merge this now, but MS style is for sensitive / private information to be obscured by substituting fictitious content OR by masking with the background color (erasing it). Blurring is not allowed. Can you follow-up with a pull request that replaces the images where you've blurred content? thanks!
cc: @DougKlopfenstein

@Jak-MS thank you, I will submit a new PR next week as I also have to change the logo (company just went through rebranding).
Thanks again!


Event stack never emptied when events are read

The events are not removed from event stack after they are read by master with an application scan.
I think that "EventStorage::ClearWritten()" is never reached.
I use 2.3.0 version
Master configuration:
master application instance: siodnp3::DefaultMasterApplication::Create()
(asiodnp3::MasterStackConfig *)->link.UseConfirms = true;
(asiodnp3::MasterStackConfig *)->master.disableUnsolOnStartup = true;
Outstation configuration:
outstation application instance: DefaultOutstationApplication::Create()
(asiodnp3::OutstationStackConfig *)->link.UseConfirms = true
(asiodnp3::OutstationStackConfig *)->outstation.params.allowUnsolicited = false

HI @adou07. Can you provide any pcaps showing this behavior?


Soul Sacrifice™ [PCSA00092]

App summary

App name: Soul Sacrifice™
App serial: PCSA00092
App version: 1.00

Vita3K summary

Version: v0.2.0
Build number: 3664-93759d9c
Commit hash: https://github.com/vita3k/vita3k/commit/93759d9
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: Me
OS: Windows 11 Pro, 10.0.22631
CPU: AMD Ryzen 7 5700G
GPU: AMD Radeon RX 5700 XT
RAM: 32 GB

Issues

Graphics are broken, cutscenes and audio play without problems.
Log
vita3k.log
Recommended labels
Ingame -
graphics bug

App summary
App name: Soul Sacrifice™
App serial: PCSA00092
App version: 1.30
Vita3K summary

Version: v0.2.0
Build number: 3691
Commit hash: https://github.com/vita3k/vita3k/commit/31826697
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: RetroGameTalk
OS: Windows 10
CPU: Intel core i7-3770KF
GPU: NVIDIA RTX 3070
RAM: 48 GB

Issues
Graphical glitches
One time it crashed but when I re-tried it didn't, I think it can happen randomly.
Screenshots

Log

vita3k.log
Recommended labels

Playable
graphics bug


Cannot create connection to Athena

I downloaded DBeaver 5.1.4, trying to create a new connection with Athena.
In the JDBC URL field, I cannot enter anything.
After typing something in the "User name" field, the above field is populated with a generic URL (jdbc:awsathena://AwsRegion=us-east-1;), which cannot be changes or deleted.:

Thanks!

You can change connection URL in driver setting. Standard Athena URL do not support database name and other standard parameters. Target database is defined by user credentials.

Unfortunately I can't test Athena connection right now.
As said here - https://s3.amazonaws.com/athena-downloads/drivers/JDBC/SimbaAthenaJDBC_2.0.2/docs/Simba+Athena+JDBC+Driver+Install+and+Configuration+Guide.pdf - is should support standard JDBC way to specify user credentials.
If not then you can set hem manually in driver properties (Username and Password properties).
Please write back if it will help. I'll improve connection dialog to simlify user experience for Athena.

I'm also not being able to connect to Athena using a driver. I have a different screen than @shanikovalsky 's:

What informations can I provide to help the case?

We added  comletely new connection age for Athena in 5.2.3. What DBeaver version do you use?

Also, not able to create an Athena connection using 5.2.3. Selecting Athena returns no page to enter connection details, credentials, etc...

Yep, it is a bug in Athena connection page in the latest version.
It should look look this:

Thanks for the bug report.

@serge-rider Thanks for Acknowledging the issue. Waiting for the fix. Approx. What version will this be fixed?

Thanks @serge-rider  and OP!
I have a question: For federated MFA user, how to set up connection? I've checked the configure file and the credential file, don't see the specific Access Key ID and Secret Key any more (they got overwritten when I set up MFA device)...


Inverse operation: open in vscode from github

Hello, great extension, thank you!
Very useful for code peer reviews over Slack / instant messaging, to exchange URLs whilst working locally from VSCode.
However the inverse functionality would be very useful too.
For example I would like to be able to copy such URL: https://github.com/fabiospampinato/vscode-open-in-github/blob/92aebc8183323697c29f36baf8b6a78dd360525b/src/extension.ts#L8-L11
https://github.com/fabiospampinato/vscode-open-in-github/blob/92aebc8183323697c29f36baf8b6a78dd360525b/src/extension.ts#L8-L11
...and to show src/extension.ts in VSCode with the code selection line 8-11 (extracted from the URL #L8-L11).
Any thoughts?

Sounds useful, perhaps that should be a separate extension, maybe that should be a browser extension.

I personally use https://github1s.com/ for stuff like that. That's out of scope with extension at this point in time.


RuntimeError: CUDA error: device-side assert triggered

Hi, I ran vall-e/train to train vall-e using the Korean dataset.
Created file 'qnt.pt ' and file 'normalized.txt' in python 3.10 environment.
The development environment has been established using the docker container.
Certain data can be learned, but using data from multiple speakers results in the following error.
It went well when I learned using data from two speakers to see if there was a problem with the multispers related part.
If anyone has experienced a related problem, please help.
Thank you.
Traceback (most recent call last):
File "/usr/local/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/data/vall-e/vall_e/train.py", line 131, in
main()
File "/data/vall-e/vall_e/train.py", line 122, in main
trainer.train(
File "/data/vall-e/vall_e/utils/trainer.py", line 157, in train
stats = engines.step(feeder=train_feeder, batch=batch)
File "/data/vall-e/vall_e/utils/engines.py", line 172, in step
raise e
File "/data/vall-e/vall_e/utils/engines.py", line 134, in step
maybe_loss_and_engine_stats = feeder(
File "/data/vall-e/vall_e/train.py", line 41, in train_feeder
_ = model(
File "/usr/local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/usr/local/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 11, in wrapped_fn
ret_val = func(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1832, in forward
loss = self.module(*inputs, **kwargs)
File "/usr/local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/data/vall-e/vall_e/vall_e/ar.py", line 49, in forward
return super().forward(
File "/data/vall-e/vall_e/vall_e/base.py", line 433, in forward
self.proms_emb(proms_list),
File "/usr/local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/data/vall-e/vall_e/vall_e/base.py", line 266, in forward
xi = F.one_hot(xi, num_classes=self.n_tokens)  # t l' k
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.

It was a problem caused by the difference in the number of tokens in Korean and English. It is solved by making the embedding layer dimension larger than the number of Korean tokens.


Issue with coma when in a vehicle

I had coma when I was driving and I could continue to drive until I get out of the car

Yes he would make a system, when you are in coma then u exit the vehicle

Just curious, how did you fall in coma while driving ?

@ARL64 are you sure about that ?

I think so, I will try on a fresh install because I have a customize version but when using NetworkRessurectLocalPlayer the playerSpawned isn't triggered so neither vRP:playerSpawned

Yes, that's the point. NetworkRessurectLocalPlayer prevent the death of the player, but the player will be in coma, if the player wait and die, or disconnect and reconnect, he will die and loose everything.


runtime/pprof: remove "(deleted)" from binary filename

What version of Go are you using (go version)?
2c01b7d632030c89ee608259597f850dd89965a0
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
4.15.0-22-generic
Ubuntu 18.04 LTS
What did you do?
Run a service with "net/http/pprof" and tried using pprof (https://github.com/google/pprof/) to profile this service.
As I said in https://github.com/google/pprof/issues/386, this is what I got:
$ pprof -http=:8080 foobar.lan:31571/debug/pprof/profile?seconds=5
Fetching profile over HTTP from http://foobar.lan:31571/debug/pprof/profile?seconds=5
Local symbolization failed for foobar-3.61.0-4290 (deleted): stat /local/foobar/bin/foobar-3.61.0-4290 (deleted): no such file or directory
Some binary filenames not available. Symbolization may be incomplete.
Try setting PPROF_BINARY_PATH to the search path for local binaries.
Saved profile in /home/marko/pprof/pprof.foobar-3.61.0-4290 (deleted).samples.cpu.002.pb.gz

Notice "(deleted)" in binary name and in profile name.
This is because binary for a running service was rewritten (deleted, moved, does not matter) and /proc/pid/maps gives you name of the binary with string "(deleted)" appended to tell you that the file was removed (inode is different or unexisting).
I propose for runtime/pprof to cleanup filename and remove "(deleted)" if it exists.
It is not needed and it would be easier to put the same file locally and get symbols and source code.
Initially I've opened an issue for pprof (https://github.com/google/pprof/issues/386), but they've decided that it would be better to fix it in Go.

Hey. I've fixed it in https://go-review.googlesource.com/c/go/+/116395
This is my first code contribution to Go. I hope it's fine :-)


Callback on slider that can return index of slide

How to destroy slide method?I want to click an '' turn to next page but not drag to left....


Add differentiation in repairs at /customer and /mechanic endpoints

There should be some differentiation between active and not active repairs like it is in the calendar (e.g. grey not active, green active)

We can e.g. change repair background:


Catalan translation qlcplus.appdata.xml and qlcplus-fixtureeditor.app…

…data.xml

That's it ! Thanks Santiago :+1:

It's OK now?. ;-)
2015-12-30 14:03 GMT+01:00 Massimo Callegari<EMAIL_ADDRESS>
That's it ! Thanks Santiago [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/mcallegari/qlcplus/pull/746#issuecomment-167992718.

Oh, you forgot to translate the summary of the fixture definition editor


Add flags to disable video recording and performance metrics

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

One small comment, otherwise looks good.


Add various SQL operators for 942120

Block attempts to use various SQL operators, some specific to certain database management systems.

Hi @terjanq, thanks for sending this!

Hi @karelorigin , thanks for sending this!

@karelorigin would you mind quoting the bug bounty ID (without the prefix) here?

Hi @dune73, the ID is the suffix of the branch name used in this PR (4L7DPMMR)

Actually no, since there is an additional online spreadsheet involved where Intigrity and we track the PRs. And we would now have to go through all the reports to find out which ones link to this PR here (and the website does not allow to search for links AFAICT).
So please do us a favor and name them here.

Thank you very much. We have this now for all the new PRs.

CRS Bug Bounty PR assessment

Rules affected (list rules): FIXME
Paranoia Level addressed (1, 2, 3, 4, full or explain): FIXME
FTW passes (yes or no) : FIXME
Rule(s) picked for solution (correct or not-correct or explain) : FIXME
Risk for false positives (irrelevant, adequate, substantial or explain) : FIXME
Regular expression quality (inspirational, decent base, needs work, adequate or explain) : FIXME
Documentation (needs work, adequate or explain) : FIXME
Tests (none or some or adequate) : FIXME

Verdict (Unusable, inspirational, usable, almost perfect or perfect) : FIXME

This is not meant to be final. As a CRS dev, feel free to comment below and edit this form directly. As committer or observer, feel free to comment below with feedback and we will think about updating the assessment accordingly.

Thank you!


Fix integer overflow ICEs from round_up_to_next_multiple_of

Turns out the standard library does have the function we need. So I swapped us to using the checked version in mmap/munmap where we can return an error, and we're still using the ICEy version in SIMD.
I found one of the ICE cases by running this test: https://github.com/wbcchsyn/rust-mmap-allocator/blob/765bcaab6e3bfd1cb1e6eaac80ac7e821fb5979b/src/mmap_allocator.rs#L195-L210

Hunh. Tests passed on s390x-unknown-linux-gnu. Odd...

Ah nice :)
@bors r+

:pushpin: Commit 9a64cb2a5b443813af9a4ff6eb47c1663864e371 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 9a64cb2a5b443813af9a4ff6eb47c1663864e371 with merge ef61546b2e7d0ead95ca215c08dfe0f0ecdbf825...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing ef61546b2e7d0ead95ca215c08dfe0f0ecdbf825 to master...


[KOGITO-3736] - Reconciler error in Data index controller when Kogito…

…Runtime is deployed
Jira issue : https://issues.redhat.com/browse/KOGITO-3736
Many thanks for submitting your Pull Request :heart:!
Analysis
As analysed provided logs, I have found that Data-index controller called to reconcile with name and namespace of KogitoRuntimeService. I happed because data-index controller is watching for config map whose owner is KogitoRuntime and handler is provided as of type `
EnqueueRequestForOwner`. Any controller should only watch object which it owns not others. But In this data-index controller is watching object which onwed by KogitoRuntime.
Solution:
KogitoRuntime should monitor configMap which it owns and update deployment object of data-index directly if protoBuf config map update. With this change there is no requirement to maintain seperate controller for data-index.
Please make sure that your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

/jenkins test

+1 to this refactoring!
@Kaitou786 @vaibhavjainwiz I remember you saying that we had to create another controller because of the unnecessary reconciliations in a scenario where we had lots of supporting services. I'm assuming that after this PR won't be a problem any more?

I had tested it for couple of scenerios. Thing should work as expected. :crossed_fingers:

/jenkins test

/jenkins test

/jenkins test

/jenkins test

@vaibhavjainwiz could you please rebase your PR and review the comments? Many thanks!

Otherwise the code looks ok, will try it on OCP instance.

/jenkins test
@spolti @sutaakar can you guys please take a look? :)

One general comment, I have noticed that *-protobuf-files config map is created even when there are no protobuf files in Kogito application. Would it have sense to skip creation of *-protobuf-files config map in that case?

One general comment, I have noticed that *-protobuf-files config map is created even when there are no protobuf files in Kogito application. Would it have sense to skip creation of *-protobuf-files config map in that case?

In the old feature, we always had to create it because the operator wouldn't know if there were protobuf files or not in the service. Now that we fetch for this information, I would say that we could skip this creation. Can you file a JIRA to follow this up? :D

Reported as https://issues.redhat.com/browse/KOGITO-3779


"climate" entity

Is it possible to have a "climate" entity for velis? If yes, how?

https://github.com/fustom/ariston-remotethermo-home-assistant-v3/issues/78#issuecomment-1451916920


Incorrect string highlighting when using template string placeholders in JavaScript

Lapce Version
0.2.0
System information
Using an M1 MacBook Pro with Monterey 12.6
Describe the bug
After using a placeholder value in a template string, the right bracket and rest of the string doesn't highlight

This looks like the same issue as #1168.

bug exists still and not resolved in v0.2.7.


Support different parameter tags

What do you want to change?
Currently the sql accepts arguments using native sql notation $1.
Additionally I'd like to have a different parameter notation, for example pyformat %(my_param)s
To be more explicit - currently that's the only way to pass an argument
select *
from users
where id = $1

This is how I'd like to pass an argument
select *
from users
where id = %(id)s

What database engines need to be changed?
No response
What programming language backends need to be changed?
No response

We support the database's native parameter format, usually ? or $1. In addition we also support the sqlc.arg macro, which is documented here. Support that macro has proved difficult enough that I have no plans to add additional parameter tags right now.


Link in release notes does not work well

The release notes mention a "new documentation site: kyanos.io." I expected this to lead to https://kyanos.io, but the link provided is https://github.com/hengyoush/kyanos/blob/v1.4.0/kyanos.io.

Thanks, i will fix it.


Suggest type definition install command using yarn when applicable

TypeScript Version:  2.8.1
Search Terms: yarn, Could not find a declaration, if it exists
Apologies if this was discussed before, I looked through issues and PRs, could not find anything.
When a yarn.lock file is present in the project directory, instead of recommending:
TS7016: Could not find a declaration file for module 'node-pkg'. '/[...]/node_modules/node-pkg/[...]' implicitly has an 'any' type.
Try `npm install @types/node-pkg` if it exists or add a new declaration (.d.ts) file containing `declare module 'node-pkg';`

it would be nice if the suggested command could make use of yarn add instead:
TS7016: Could not find a declaration file for module 'node-pkg'. '/[...]/node_modules/node-pkg/[...]' implicitly has an 'any' type.
Try `yarn add @types/node-pkg` if it exists or add a new declaration (.d.ts) file containing `declare module 'node-pkg';`

Related to https://github.com/Microsoft/TypeScript/issues/19997

This doesn't seem to be bothering anyone


Improve Diagnostics consistency

Summary
Closes https://github.com/PrefectHQ/terraform-provider-prefect/issues/212

Uses helper functions more consistently
Adds new helper functions
Ensure return on diagnostic errors
Fix diagnostic resource object references

To do

[x] Replace all repetitive Diagnostics with helper functions

This is a bigger one, but if you look at each commit, the changes are pretty repetitive/predictable. Also, a majority of the changes are lines removed rather than changed/added.


feat: stripe balance details refactoring

TRELLO_TICKET
Description

[x] Refactor Balances

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

 Stripe Balance Details refactoring

 Create teacher connect accounts and setup payouts from Stripe Bank Account


How do I use this script (serious help needed)?

Hello, I'm new to using scripts/programming. I've asked on several websites how to use your script but no one answers me. I hope you can help me.
I have MS Visual Studio 2017. I know how to change the path with "cd" (CMD) and how to use OrpheusDL (Tidal).
But I found no clue which files I need to open, how to change the configuration, or which file I need to start decoding my 360 audio files.
Can you please help me? I don't know where else I can ask for help. I appreciate any help I can get.
PS: I was able to change the line 1483 from what I saw on this post: https://github.com/ittiam-systems/libmpegh/issues/1#issuecomment-1072164585

Just solved this by myself. It's easier than I thought. Have a nice day!

hello, could you help me please


test is revised

why are the test values changed? was there a "physics" bug?

@Moelf
Thank you for comment.
No.
There is no physics bug in the code.
This is related to the number of MC steps and the random number generator in Julia.
To reduce test time on the Github actions, we modified the parameter slightly.


Netflix MSL

I've read on another forum that mitmproxy can decode Netflix MSL messages. If this is true

Does mitmdump decode them as well?
What do I need to do to enable this to happen. Does mitmdump need to see the key handshake sequence between the client and the server?

There is no Netflix MSL support in mitmproxy's core. A cursory Google search turns up https://github.com/nohajc/netflix-mitm-proxy/.

Apologies - I should have looked.


Auth.isAuthenticated() — service._currentUser is null

Hey guys,
So we are using angular_devise with our application and are trying to utilize the service.isAuthenticated function in devise.js beginning on line 183. The problem is that service._currentUser is null.
In an attempt to debug this on our end, I found that save which is supposed to be called on login line 158 in the then. The problem is that save expects the user argument. If I add save(user) in next .then block, isAuthenticated works.
E.g. Doesn't work:
return $http(httpConfig('login', creds)).then(service.parse).then(save).then(function (user) {
    if (withCredentials && !loggedIn) {
        return broadcast('new-session')(user);
    }
    return user;
    }).then(broadcast('login'));
},

Works:
return $http(httpConfig('login', creds)).then(service.parse).then(save).then(function (user) {
    save(user);
    if (withCredentials && !loggedIn) {
        return broadcast('new-session')(user);
    }
    return user;
    }).then(broadcast('login'));
},

Is there something we are doing wrong or is this an issue with angular_devise?

I have a similar problem. My app needs to be refreshed after log in so server can populate layout with some data related to user. Your example on previous comment work. But it doesn't after page refresh. While Auth.currentUser() returns the current_user on server but Auth._currentUser is still null and Auth.isAuthenticated() will return false in all cases.
This is what happens after refresh:
Auth.currentUser().then(function(user){
    console.log(user)
    // => Object { id: 28, first_name: null, last_name: null, customer_id: 1, status: "active",...}
})

console.log(Auth.isAuthenticated())
// => false

console.log(Auth)
// => Object { _currentUser: null, parse: AuthProvider/_parse(), login: AuthProvider/this.$get</service.login(),...}

I was wrong actually. Auth.isAuthenticated() is called before currentUser() get resolved.

:+1:


New package: Format2DB v0.1.0

Registering package: Format2DB
Repository: https://github.com/yakir12/Format2DB.jl
Created by: @yakir12
Version: v0.1.0
Commit: b2b1fd157fa58b021ada5979b1139168393590ff
Reviewed by: @yakir12
Reference: https://github.com/yakir12/Format2DB.jl/commit/b2b1fd157fa58b021ada5979b1139168393590ff#commitcomment-39438516

do not merge.

@yakir12 Would you like me to merge this PR? Or close it?

Close and delete it. I'm a LocalRegistry boy now :)
On Fri, Jun 12, 2020, 06:32 Dilum Aluthge<EMAIL_ADDRESS>wrote:

@yakir12 https://github.com/yakir12 Would you like me to merge this PR?
Or close it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JuliaRegistries/General/pull/15407#issuecomment-643058910,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZBIJJT2QPEMCM3ZWY6J2LRWGVVBANCNFSM4NKCFDKA
.


docs/concepts/architecture/leases is in hindi

Hello !
I have translated docs/concepts/architecture/leases page English language to Hindi language.

/easycla

is:closed


feat(bundler): cache appimage bundle tools

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

This is what the -N flag is for, it enables wget's timestamping so that it only downloads it if the remote file is newer.
With this if check it would never re-download the files even if there's a new version which happens relatively regular.
Thank you nonetheless.

This is what the -N flag is for, it enables wget's timestamping so that it only downloads it if the remote file is newer.

After some testing, I've found that -N and -O can't be used together and the -q option hides the warning.
Quote man:

      For this reason, -N (for timestamp-checking) is not supported
      in combination with -O: since file is always newly created,
      it will always have a very new timestamp. A warning will be
      issued if this combination is used.

With this if check it would never re-download the files even if there's a new version which happens relatively regular.

I've modified the code to keep using wget -N, if you are still interested. 351b676b09584a06daab5e6c0a19ab6811a309ea

After some testing, I've found that -N and -O can't be used together and the -q option hides the warning.

Ahh interesting!

I've modified the code to keep using wget -N, if you are still interested.

Yep, i am interested in that! Buuut i can't re-open PRs after there was a force-push, see isaacs/github#361, sorry for closing it too quickly, didn't know that this is a thing 😅


Dwedul/no params key

Description
Remove the params store key and transient store key from the app.
This is in draft because I need to test the upgrade again.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Closing this PR in favor of:

#2189

Need to get the change to main first, then will backport it to release/v1.20.x.