Bump up quartz version to 2.3.2 to prevent XXE

initDocumentParser in xml/XMLSchedulingDataProcessor.java in Terracotta Quartz Scheduler through 2.3.0 allows XXE attacks via a job description. Upgrade quartz from 2.3.0 to 2.3.2 to fix the vulnerability.

Codecov Report

Merging #6484 (b946133) into master (1beaab5) will decrease coverage by 1.57%.
The diff coverage is 59.87%.

@@            Coverage Diff             @@
##           master    #6484      +/-   ##
==========================================
- Coverage   66.44%   64.87%   -1.58%
==========================================
  Files        1075     1334     +259
  Lines       54773    65584   +10811
  Branches     8168     9565    +1397
==========================================
+ Hits        36396    42547    +6151
- Misses      15700    19996    +4296
- Partials     2677     3041     +364

Flag
Coverage Δ

unittests
64.87% <59.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...n/java/org/apache/pinot/client/ExecutionStats.java
15.55% <ø> (ø)

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <ø> (-51.10%)
:arrow_down:

...n/java/org/apache/pinot/client/ResultSetGroup.java
65.38% <ø> (+0.16%)
:arrow_up:

.../org/apache/pinot/client/ResultTableResultSet.java
28.00% <ø> (-6.29%)
:arrow_down:

... and 1179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830eb94...b946133. Read the comment docs.

Codecov Report

Merging #6484 (b946133) into master (1beaab5) will decrease coverage by 1.57%.
The diff coverage is 59.87%.

@@            Coverage Diff             @@
##           master    #6484      +/-   ##
==========================================
- Coverage   66.44%   64.87%   -1.58%
==========================================
  Files        1075     1334     +259
  Lines       54773    65584   +10811
  Branches     8168     9565    +1397
==========================================
+ Hits        36396    42547    +6151
- Misses      15700    19996    +4296
- Partials     2677     3041     +364

Flag
Coverage Δ

unittests
64.87% <59.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...n/java/org/apache/pinot/client/ExecutionStats.java
15.55% <ø> (ø)

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <ø> (-51.10%)
:arrow_down:

...n/java/org/apache/pinot/client/ResultSetGroup.java
65.38% <ø> (+0.16%)
:arrow_up:

.../org/apache/pinot/client/ResultTableResultSet.java
28.00% <ø> (-6.29%)
:arrow_down:

... and 1179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830eb94...b946133. Read the comment docs.


Compile Swift (& Java?) binaries once

As it takes so long to compile a Swift (and Java?) action, it would would be useful if they could be compiled once (preferably on upload) and stored so that all invocations used the binary and didn't suffer from the 1-2 second compile time.

as a further generalization, we've discussed the idea of "init" actions which receive a manifest of dependencies, install them locally inside an action runtime container, archive the result and create the intended action as a result. For swift, this included compiling the binary, for Java, pulling the dependencies, pruning and creating the Jar. For node, receiving a package.json, running npm install, and zipping up the dependencies, and for python, creating and sealing the virtual env.

That makes a lot of sense - for Swift we could then use a Package.json to collect dependencies as well.

Here is the first draft of design. I don't have much experience with creating actions in other runtimes than nodejs so adding only nodejs for now. Will add other runtimes as I finish experimenting with them. Any feedback will be highly appreciated.
Using the init action
The /whisk.system/init action offers a convenient way to deploy an action with its dependencies to OpenWhisk.
The action accepts following parameters:
Parameters

Parameters
Description

name
Name of the action to be created

location
Directory containing action files

kind
Action runtime for example: nodejs:default, swift:default

Creating action with nodejs runtime
To create an action in nodejs runtime, you must have index.js and package.js for any dependencies. /whisk.system/init installs dependencies locally using npm install followed by zipping up the action and its dependencies and creates an action using that zip file.
ls -1 helloworld/src/
index.js
package.json
cd helloworld/src/
npm install
zip -rq action.zip *
wsk action create helloworld --kind nodejs:6 action.zip

All you have to run is:
wsk action invoke /whisk.system/init --param name helloworld --param location helloworld/src --param kind nodejs --blocking

Question:
Should /whisk.system/init be worried about cleaning up after creating helloworld action?

Perhaps we should not call the action "init" as this has meaning in the context of the CLI.  Perhaps we should (as most actions should) name it according to its granular function.
Also, this would be better as an "implicit" action (not explicit) where we would possible do this as part of create perhaps?

Yeah I think it would be a package instead, with an action per runtime, since the action would need the runtime anyway to compile, might as well be in the target language
whisk.system/compile/nodejs
whisk.system/compile/java
whisk.system/compile/swift
whisk.system/compile/python

There is no need for parameter kind
I would make the action accept two modes.
Give it a git info to get the source code from, or a zip
@pritidesai
I don't follow why you do a npm install to create the zip to send to the action, that's what the action is suppose to do so any binaries from npm install are done in the correct runtime.
There should be specific parameters for each kind.
For example for nodejs, I might now that there is no binaries and is all pure js, so using webpack or something similar should be allow, maybe allow for a custom npm script like instead of npm install and zip you could run a npm run script.

I have implemented solution for nodejs and seeking your feedback, please find details on the solution on GitHub:
https://github.com/pritidesai/incubator-package-build#package-and-deploy-third-party-modules---nodejs

Another issue mentioned a builder service - the action loop proxy makes this easier.


Update scripts to run under windows

Some people want to run MM under windows, so this PR adds a new start script entry without the display stuff.
It also makes the tests runnable under windows thanks to the cross-env library.

The alert test still seems unstable after https://github.com/MichMich/MagicMirror/pull/2687 @khassel  ... Any idea on why it is so picky?

is install fixed?  vendor and fonts do not get installed as the script is wrong for windows batch

if we went back to a script for start, then there could be two scripts
start_it   (sh, but no extension)
start_it.cmd
then launch would the
"start":"./start_it"

Argh, you're right @sdetweil windows-npm-install doesnt traverse into the font/vendor dirctories.
Having scripts seems like the only viable solution. But I am not sure if @MichMich wants more files in the repo.
But it would help for those who would want to develop on windows. So, he might say yes or no ;-) ?

If @MichMich `s decision is to merge this, we should also update the documentation.
AFAIS there is no word about windows in the docs, so it should may mentioned here and also here.
May there are other places but searching does not work at the moment.
Tests are failing here due to:
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm ERR! notsup Valid OS:    darwin
npm ERR! notsup Valid Arch:  any
npm ERR! notsup Actual OS:   linux
npm ERR! notsup Actual Arch: x64

Oh, this isnt ready to be merged with the windows install being not proper. Will convert it into a draft until we know how to proceed.

I'm a bit conflicted with this PR. A while ago we made the decision to remove any non Raspberry support because it is simply not maintainable. The problem of adding these features is that people will rely on them and expect from us we make sure it keeps working. I personally have no interest or intention to maintain any windows support.
Since this PR does mainly add some convenience helpers it might be a better option to just add info to the docs.
What do you guys think?

I personally have no interest or intention to maintain any windows support.

+1
new dependency cross-env:
🚨 NOTICE: cross-env still works well, but is in maintenance mode. No new features will be added, only serious and common-case bugs will be fixed, and it will only be kept up-to-date with Node.js over time.
I would have no problem with adding this so far but adding additional bash/cmd scripts to get the installation working on multiple platforms would be contrary to #1860

Since this PR does mainly add some convenience helpers it might be a better option to just add info to the docs.

Funny, I looked in the docs and found something regarding this already in there: https://docs.magicmirror.builders/getting-started/installation.html#common-installation-issues
Maybe this section needs to be clearer about why it is there (non.raspberry installation)?

Created a PR in the MM Docs repo. Maybe that might help?

but the doc IMPLIES that you SUPPORT running on Windows, which you "don't",  so I would remove the doc too ..
you have to make up your mind.

I didnt thought about that since stuff about other (not officially supported) installation methods is in the docs too

Maybe this section needs to be clearer about why it is there (non.raspberry installation)?

yes, I saw this section and obviously the windows workaround is described there but windows is not mentioned ...

I think the best thing is to close this issue and to improve the docs. I've applied for Agolia DocSearch to make searching the docs better.

Closing in favor of https://github.com/MichMich/MagicMirror-Documentation/pull/92


Bad aggregate signature

I have everything setup correctly, I think, but I am getting an error when submitting the transaction. I have the testnet10 setup, some test XCH, and no errors up until submitting. fwiw: I am running on a M1 Mac.
Can anyone offer any help?
Failed to submit NFT: {"detail":"Failed to include transaction 'transaction###', error BAD_AGGREGATE_SIGNATURE", "success":false}}

I think we solved this issue via Discord.
The reason was that the wallet unexpectedly connected to mainnet.


 While 'Delete" works as expected

Try adding more than one... Note the repeat in the name :-)

@kentcdodds Oh.. got that. Sorry : D
Some animation could help here to demonstrate the mechanism. Thank you

Would you be willing to makeapullrequest.com to add a note in the README and/or a demo and/or add animation? :+1:

Yeah why not!

@kentcdodds proper animation could be tricky with this stateless design. Don't you have any suggestions for https://github.com/huston007/repeat-todo/commit/7979e72451bd90c28442cf647a086137a89f0be8?

I love everything except the fact that it's not in the right place ;-)

It looks like you made another commit that may have fixed that... Though this is what I'm seeing now... :-(

But I'm sure you'll get it worked out. As far as the animation, I love it. Super cool! Looking forward to the PR!

@kentcdodds there is some issue with this build system - it caches index html hardly. Try some refreshes, cmd+refresh and etc)
Also, please pull one more commit.

Oh, that's right, yeah, it caches index.html. Kinda annoying...

Fantastic!
Let's PR this :-) Thanks!

Also, if you're interested, could you add a Contributors section to the README.md following the https://github.com/kentcdodds/all-contributors spec?
If you've got time. Thanks!


Can't resize dropdown label.

Hello, and first of all thanks for your nice job with this project!
I'm having difficulties to resize the main label of the dropdown. The internal labels, ones that show the dropdown items those can be resized perfectly. But when i resize the Label that shows the selected item nothing happens.
I have a vertical layout set to child control size = true and child force expand = true, if i set this to false, the background of the label dissapears.
My question is: Is it possible to make the dropdown consistent with the vertical layout functionality?
Thanks for your time, and feel free to ask whatever you need to improve this project.
Best regards.

Hello Fernando,
I'll take a look at this today, and see what I can come up with as a solution.
Glad you like the project!

I think I'm able to re-create the issue that you are experiencing.  To do so, I'm working with the Demo scene that came in the package.  I went into the "Demo DropDown Panel" object and re-ordered the objects within as such: DDL Result Text, Progress Bar, DropDown Prefab and finally Clear DDL Button.
I then created and empty object, named it "DDL Container", put the top left corner of the object to the top left corner of the DropDown Prefab object, then put the bottom right corner of the object to the bottom right corner of the Clear DDL Button object (making the rectangle pretty much contain the two objects.  I then added a Vertical Layout Group to the DDL Container object, clicked all the check boxes on (auto set width and height, and expand), and set the spacing to 10.  Then I moved the DropDown Prefab and the Clear DDL Button into the DDL Container Object.
When I execute the code, it runs as expected....mostly.  I can see the drop down list, select an item, and have it show up as selected.  The thing that I think you may be seeing trouble with is when you click on the drop down list.  In order for the control to work, I drop it in the list of children in its parent to the bottom of the list.  That way, if there are any controls visible, the drop down list will show up above it, so you can scroll and select an item.  (otherwise, the drop down list would show up behind buttons or text, ad you couldn't actually use it).  In my example, when I click on the drop down list, the order of controls changes (the button is first in the list, the drop down list is last).  The Vertical Layout Group is re-ordering the objects when the drop down list is clicked open, then resetting them when a selection is made (or you close the control).
I did find a problem with the drop down item container object not being properly resized.  I posted an update a short time ago.  I don't know if this addresses your specific problem (it might, I hope).  Give it a try and let me know if that resolves your issue.   If it does not, we can discuss in more detail what the symptoms of the problem are.

Thanks for your fast response,
The issue is not related to when the dropdown is open. The only problem is that in the default state(closed), the text inside the dropdown is higher than the background itself. On top of that, the vertical layout that the container of the dropdown has consider the background height and not the text height.
I guess the issue is related with the "best fit" check of the dropdown label wich im setting to true [10 - 40]
Anyway, i'm going to change my project canvas scaler, and remove the vertical layouts to place all manually, so you can close the issue if you want.
Thanks for your time.

Ah, okay.
I did notice in the example I posted above that the text in the button did get smaller, and was moved to the top of the button (not the center, even though I told the text to be centered).  Vertical Layout Group can do some unexpected things with formatting, from my past experience.
Thanks for reporting this.  If anything, an unfound bug was found and fixed. So there is some win here.  :)


Limit the built versions for Travis website builds only.

@dekuhn PTAL

Upon pruning old versions and keeping the latest and last three versions, I see that the time Jekyll spends rendering Liquid has gone down from 195 seconds to 31 seconds.
Before:

After:


Using scene on fly won't work as expected

Scenario: I would like to use automation for stopping my air conditioner when windows are opened and turn it on again when closing the window. Easiest way to achieve it is to create scene on the fly and capture states before opening windows with the snapshot_entities parameter
Automation sample:
...
service: scene.create
data:
  scene_id: before_open_windows
  snapshot_entities:
    - climate.living_room
 ...

Unfortunately with the current implementation, air conditioner  will turn on when you close the window even if it was off before you opened the window
Issue comes from that the integration turn on the device when you update the swing_mode, temprature, preset_mode properties:

https://github.com/sockless-coding/panasonic_cc/blob/master/custom_components/panasonic_cc/panasonic.py#L316
https://github.com/sockless-coding/panasonic_cc/blob/master/custom_components/panasonic_cc/panasonic.py#L247
https://github.com/sockless-coding/panasonic_cc/blob/master/custom_components/panasonic_cc/panasonic.py#L258

For fan mode, the behaviour is different, it doesn't turn on the device:

https://github.com/sockless-coding/panasonic_cc/blob/master/custom_components/panasonic_cc/panasonic.py#L280

As it seems to be the expected behaviour, I won't flag it as a bug but:

Why changing prop fan mode mode has a different behaviour than others ?
Could we define an option to disable auto start ("power": self.constants.Power.On ) when changing properties as it is not always the expected behaviour ?

Hi @olivierSemet
I have a vague memory of that the power parameter was required to be set to On for the device to honor the other settings.
My Panasonic is currently not operational (Hopefully I get it fixed soon), so I can not verify this (and it might have changed).

HI @sockless-coding,
Tested this morning with pcomfortcloud app, it works well without turning ON devices:
pcomfortcloud <email>  <pwd> get 6
reading from device 'salon' (xxx)
id                       : xxxx
parameters
    temperatureInside    : 18
    temperatureOutside   : 21
    temperature          : 27
    power                : Off
    mode                 : Cool
    fanSpeed             : HighMid
    airSwingHorizontal   : Mid
    airSwingVertical     : DownMid
    eco                  : Auto
    nanoe                : Off

pcomfortcloud <email>  <pwd>  set -t 21 6

pcomfortcloud<EMAIL_ADDRESS>cirvef-makjo7-cazJed get 6
reading from device 'salon' (xxx)
id                       :xxx
parameters
    temperatureInside    : 18
    temperatureOutside   : 21
    temperature          : 27
    power                : Off
    mode                 : Heat
    fanSpeed             : HighMid
    airSwingHorizontal   : Mid
    airSwingVertical     : DownMid
    eco                  : Auto
    nanoe                : Off

I tested other parameters than temperature.
To fix my issue with automations and dynamic scenes, I added an option which I called CONF_ENABLE_AUTO_POWER_ON. By default this option is activated to keep the actual behaviour. It works fine except if you enable this option, there is no way to switch ON devices  on thermostat widgets. I might need to implement a custom component working like the one from the official comfort cloud mobile app.
I'll do a PR if you're interested by those changes.


HBASE-29027 Introduce a new WALProvider to generate WAL files consumed by Replication

https://issues.apache.org/jira/browse/HBASE-29027

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 11s

master passed

+1 :green_heart:
compile
3m 42s

master passed

+1 :green_heart:
checkstyle
0m 49s

master passed

+1 :green_heart:
spotbugs
2m  0s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 29s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
1m 39s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
1m 39s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 34s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)

-1 :x:
spotbugs
0m 40s
/patch-spotbugs-hbase-server.txt
hbase-server in the patch failed.

-1 :x:
hadoopcheck
1m 53s

The patch causes 20 errors with Hadoop v3.3.6.

-1 :x:
hadoopcheck
3m 48s

The patch causes 20 errors with Hadoop v3.4.0.

-1 :x:
spotless
0m 36s

patch has 65 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s

The patch does not generate ASF License warnings.

23m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 6cbb416eb307 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bc25864b03b1f0e5c3366792f8e9ec918eff832b

Default Java
Eclipse Adoptium-17.0.11+9

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 36s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 47s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
0m 47s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
javadoc
0m 51s

the patch passed

-1 :x:
shadedjars
3m 48s

patch has 20 errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 32s

hbase-common in the patch passed.

-1 :x:
unit
0m 47s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

24m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux dc9a78b62f63 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bc25864b03b1f0e5c3366792f8e9ec918eff832b

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/1/testReport/

Max. process+thread count
402 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 12s

master passed

+1 :green_heart:
compile
3m 45s

master passed

+1 :green_heart:
checkstyle
0m 47s

master passed

+1 :green_heart:
spotbugs
1m 59s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 57s

the patch passed

+1 :green_heart:
compile
3m 40s

the patch passed

+1 :green_heart:
javac
3m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 35s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)

+1 :green_heart:
spotbugs
2m 15s

the patch passed

+1 :green_heart:
hadoopcheck
11m 36s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 35s

patch has 65 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

40m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 26657a72ceee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2b1b89f453ab2a2fbbea6c7be9bfa53602ad2dd3

Default Java
Eclipse Adoptium-17.0.11+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/2/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed

+1 :green_heart:
shadedjars
5m 34s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 28s

hbase-common in the patch passed.

-1 :x:
unit
18m 26s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

45m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux<PHONE_NUMBER>c4 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2b1b89f453ab2a2fbbea6c7be9bfa53602ad2dd3

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/2/testReport/

Max. process+thread count
1786 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Thanks for this contribution, I think this would also help reduce wals accumulation in such use cases.
Can we just a UT that validates that we have two wals when using this config?

Refined as comments

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s

master passed

+1 :green_heart:
compile
4m  5s

master passed

+1 :green_heart:
checkstyle
0m 54s

master passed

+1 :green_heart:
spotbugs
2m 19s

master passed

+1 :green_heart:
spotless
0m 49s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s

the patch passed

+1 :green_heart:
compile
4m  6s

the patch passed

+1 :green_heart:
javac
4m  6s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 39s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
2m 39s

the patch passed

+1 :green_heart:
hadoopcheck
12m 15s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 41s

patch has 66 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s

The patch does not generate ASF License warnings.

44m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux 087750befaa6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bcf40ceb6a7953f60c383a76e7d48c0c1fd8d88c

Default Java
Eclipse Adoptium-17.0.11+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/3/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s

the patch passed

+1 :green_heart:
compile
1m 46s

the patch passed

+1 :green_heart:
javac
1m 46s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed

+1 :green_heart:
shadedjars
7m  4s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 11s

hbase-common in the patch passed.

-1 :x:
unit
21m  7s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

53m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ed9e22c984eb 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bcf40ceb6a7953f60c383a76e7d48c0c1fd8d88c

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/3/testReport/

Max. process+thread count
1803 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 57s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 37s

master passed

+1 :green_heart:
compile
3m 53s

master passed

+1 :green_heart:
checkstyle
0m 51s

master passed

+1 :green_heart:
spotbugs
2m  5s

master passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  0s

the patch passed

+1 :green_heart:
compile
3m 41s

the patch passed

+1 :green_heart:
javac
3m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 35s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
2m 14s

the patch passed

+1 :green_heart:
hadoopcheck
11m 35s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 36s

patch has 66 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

44m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux fe6f13d547ac 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c7ca5da6fab05d2ecb082159439c53902cfc903f

Default Java
Eclipse Adoptium-17.0.11+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/4/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/4/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 20s

master passed

+1 :green_heart:
compile
3m 46s

master passed

+1 :green_heart:
checkstyle
0m 49s

master passed

+1 :green_heart:
spotbugs
2m  5s

master passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  3s

the patch passed

+1 :green_heart:
compile
3m 44s

the patch passed

+1 :green_heart:
javac
3m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 49s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
2m 14s

the patch passed

+1 :green_heart:
hadoopcheck
11m 39s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

42m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux 3b2f2aa7d833 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b8a5e6c59d6c4e97740f81dbefbd0a8ac3083c4

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed

+1 :green_heart:
shadedjars
5m 51s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 29s

hbase-common in the patch passed.

-1 :x:
unit
432m 59s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

462m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 79c820469b1b 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b8a5e6c59d6c4e97740f81dbefbd0a8ac3083c4

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/5/testReport/

Max. process+thread count
4758 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s

master passed

+1 :green_heart:
compile
3m 46s

master passed

+1 :green_heart:
checkstyle
0m 49s

master passed

+1 :green_heart:
spotbugs
2m  2s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  1s

the patch passed

+1 :green_heart:
compile
3m 45s

the patch passed

+1 :green_heart:
javac
3m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 49s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
2m 17s

the patch passed

+1 :green_heart:
hadoopcheck
11m 31s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 44s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

41m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux 56a6181fb308 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 42850ccdb67c99e5728f5b9763a85eb49eb1930f

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 14s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 42s

the patch passed

+1 :green_heart:
shadedjars
4m 48s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  4s

hbase-common in the patch passed.

-1 :x:
unit
449m 10s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

477m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f48badf578c7 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 42850ccdb67c99e5728f5b9763a85eb49eb1930f

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/6/testReport/

Max. process+thread count
5072 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/6/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  3s

master passed

+1 :green_heart:
compile
3m 51s

master passed

+1 :green_heart:
checkstyle
0m 51s

master passed

+1 :green_heart:
spotbugs
2m  5s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  4s

the patch passed

+1 :green_heart:
compile
3m 48s

the patch passed

+1 :green_heart:
javac
3m 48s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 49s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
2m 26s

the patch passed

+1 :green_heart:
hadoopcheck
11m 35s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s

The patch does not generate ASF License warnings.

41m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux 2e0d0915d30d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 33b7e8897519be1e67fb4428120c3954831c5dca

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed

+1 :green_heart:
shadedjars
5m 12s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  2s

hbase-common in the patch passed.

-1 :x:
unit
431m 59s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

461m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 502c56f1d126 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 33b7e8897519be1e67fb4428120c3954831c5dca

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/testReport/

Max. process+thread count
4936 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

UT failures seem legit. Mind check those, @YutSean ?

Yeah. Busy these days will have a check then.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 25s

master passed

+1 :green_heart:
compile
3m 41s

master passed

+1 :green_heart:
checkstyle
0m 48s

master passed

+1 :green_heart:
spotbugs
2m  6s

master passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 59s

the patch passed

+1 :green_heart:
compile
3m 41s

the patch passed

+1 :green_heart:
javac
3m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 50s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
2m 14s

the patch passed

+1 :green_heart:
hadoopcheck
11m 36s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

41m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux 758ff7460735 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>d19157955b0d1b403b872083f75035

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s

the patch passed

+1 :green_heart:
compile
1m 55s

the patch passed

+1 :green_heart:
javac
1m 55s

the patch passed

+1 :green_heart:
javadoc
1m  4s

the patch passed

+1 :green_heart:
shadedjars
7m 25s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 21s

hbase-common in the patch passed.

-1 :x:
unit
220m 17s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

258m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6532

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 717d92f0b095 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>d19157955b0d1b403b872083f75035

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/8/testReport/

Max. process+thread count
5374 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/8/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Add ZFS operations and facts

This MR adds facts and operations for dealing with ZFS filesystems, and tests to cover them.
Most of the logic is in pyinfra.facts.zfs.Datasets and pyinfra.operations.zfs.dataset ("dataset" being the broad ZFS term for either a filesystem, a block volume or a snapshot) but I've also added convenience functions for each specific type of dataset, to make it a little easier to understand when in use.

I've cleared up the linter issues -- is there anything else you'd want changed?


Advice on symlinking config to config.toml leads to a different warning

Problem
If you have a ~/.cargo/config file, running Cargo commands gives this:
warning: `/home/chris/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`

But if you follow this advice, you get a warning:
warning: both `/home/chris/.cargo/config` and `/home/chris/.cargo/config.toml` exist. Using `/home/chris/.cargo/config`

Well, actually everything produces these warnings and infos twice, so it’s even a little worse.
A suggested course of action shouldn’t lead to a different warning. Currently, I can’t escape having a warning if I want to support cargo 1.38 or earlier.
Steps
No response
Possible Solution(s)
Suppress the new warning if config and config.toml have the same contents. (This is more general than just checking if one symlinks the other.)
Notes
No response
Version
warning: both `/home/chris/.cargo/config` and `/home/chris/.cargo/config.toml` exist. Using `/home/chris/.cargo/config`
warning: both `/home/chris/.cargo/config` and `/home/chris/.cargo/config.toml` exist. Using `/home/chris/.cargo/config`
cargo 1.79.0-nightly (c93926759 2024-04-23)
release: 1.79.0-nightly
commit-hash: c9392675917adc2edab269eea27c222b5359c637
commit-date: 2024-04-23
host: x86_64-unknown-linux-gnu
libgit2: 1.7.2 (sys:0.18.3 vendored)
libcurl: 8.6.0-DEV (sys:0.4.72+curl-8.6.0 vendored ssl:OpenSSL/1.1.1w)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: Arch Linux [64-bit]

Thanks for the report. This should already be resolved by https://github.com/rust-lang/cargo/pull/13793, which only warns when each file handle points to a different file.

Thanks! I didn’t find #13667 in my searches due to the words employed, and I missed #13793 due to not searching PRs (I normally remove is:issue from my searches, but didn’t this time for some reason).


Camera not focusing

When a QR code is brought closely to the camera it won't focus.

Every phone will have a good range for reading barcodes, you need to test your device yourself

The new version adds continuous active focus function


A0 2499 jf-withdraw

Implements withdraw relation in jellyfish.

Note is not an input to the outside relation it's subrelation or subcircuit in math meaning.


Any chance of a Linux port?

Just wondering if you think it's possible to create a linux port of Topo?

Hi Kehan,
I have added a unix build to the assets of https://github.com/NomisNostab/Topo/releases/tag/v1.21.40.
As noted in the OSX doco in a earlier issue there are some dependencies that you might have to sort out to get it going.
I am looking at swapping out the PDF generation package for another then hopefully doesn't have such dependencies.
My ultimate goal is to have Topo running as a web site so no installation is needed, but these cost $.
Good luck, and let me know how you go.
Simon.

Wow thanks will try it out. Happy to try to help out where I can

Unfortunately I didn't have much luck with that. None of the css/styling resources load when hitting the URLs.

When trying to generate the formatted (non CSV) reports I get the following error message:
An error occurred while processing your request.
Request ID: 00-cecca075095f256a87702636eaadd8de-b5c115c86c48e9ea-00

Development Mode
Swapping to Development environment will display more detailed information about the error that occurred.

The Development environment shouldn't be enabled for deployed applications. It can result in displaying sensitive information from exceptions to end users. For local debugging, enable the Development environment by setting the ASPNETCORE_ENVIRONMENT environment variable to Development and restarting the app.

Topo, helping you navigate the Terrain © 2022 - Topo - [Privacy](http://localhost:5000/Home/Privacy)

I set that env variable and now get:

I did some digging and found the following https://www.fast-report.com/en/blog/show/fastreport-net-core/
FastReport .NET 2017.4 now supports .NET Core, so users can utilize FastReport .NET in Windows, Linux and Docker containers. For using it under Linux one needs XServer, the "libgdiplus" and the "libx11-dev" libraries. The package includes a demo version, which allows to check whether FR.Net is working on your device. It can be found in the "\Demos\Core\FastReportCore.MVC" folder.
FastReport .NET Core corresponds with .NET Standard 2.0.

However after installing those libraries I get the same error message.

(I realise that I'm in the serious minority of users, so don't feel this is a complaint, just reporting back what I found)

Just had a look at the new library I am using, doesn't look hopeful.
https://www.syncfusion.com/forums/153861/using-pdf-component-on-windows-and-linux

Thanks for trying. I am in the process of swapping the FastReport library for something else to create the PDF documents. That should remove the GDIP problem but will most likely introduce some more.
My ultimate aim is to have a angular app hosted or running from the file system and using an AWS Lambda function to generate the reports. That way the whole thing is OS independent.

And free to run and pretty scalable

I have got Topo running on WSL, and have added instructions to the installation section.

Thanks so much working really nicely. The wallchart report is brilliant!


[Bug]: error message of resource role permission is not readable

ODC version
4.2.4
OB version
not related
What happened?

create a new odc user
login odc based on this user
attempt visit a project that isn't belong to him/her

as you can see, the error message is not readable.
What did you expect to happen?
the error message of resource role permission should be readable~
How can we reproduce it (as minimally and precisely as possible)?
follow 'what happened'
Anything else we need to know?
No response

fixed

PASS


Unable to load configuration file: readfp() got an unexpected keyword argument 'source'

I have a .gist file in /home. I also tried in .config/gist
⌂179% θ72° [thoraxe:~] master* 1 ± cat ~/.gist
[gist]
token: xxx

I installed gist with sudo pip install gist:
⌂142% θ72° [thoraxe:~] master* 130 ± sudo pip install gist
WARNING: Running pip install with root privileges is generally not a good idea. Try `pip install --user` instead.
Collecting gist
  Downloading https://files.pythonhosted.org/packages/1b/28/699079a0da8469853cf81360ac40d16b1c804a01e3b70c094b529f937fcc/gist-0.0.8.tar.gz
Requirement already satisfied: requests in /usr/lib/python2.7/site-packages (from gist) (2.20.0)
Collecting argparse (from gist)
  Downloading https://files.pythonhosted.org/packages/f2/94/3af39d34be01a24a6e65433d19e107099374224905f1e0cc6bbe1fd22a2f/argparse-1.4.0-py2.py3-none-any.whl
Requirement already satisfied: chardet<3.1.0,>=3.0.2 in /usr/lib/python2.7/site-packages (from requests->gist) (3.0.4)
Requirement already satisfied: idna<2.8,>=2.5 in /usr/lib/python2.7/site-packages (from requests->gist) (2.7)
Requirement already satisfied: urllib3<1.25,>=1.21.1 in /usr/lib/python2.7/site-packages (from requests->gist) (1.24.3)
Installing collected packages: argparse, gist
  Running setup.py install for gist ... done
Successfully installed argparse-1.4.0 gist-0.0.8

Not sure what's going wrong...

That's the wrong gist :)
To install this package from pip, try pip install python-gist.


src: Set MPTCP_PM_ADDR_FLAG_SIGNAL as needed.

The MPTCP_PM_ADDR_FLAG_SIGNAL flag is required when a port is specified.  Make sure it is set when setting flags for the given network address through through mptcpd_kpm_set_limits().
This also corrects an invalid argument (EINVAL) error exhibited by the test-commands unit test.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 64.739%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
1388

Relevant Lines:
2144

💛  - Coveralls


SUGGESTION: Link "latest" to current release

Hi bud.
Great work as always.
I jump in every few days to get an updated copy and see if I can spot / appreciate the differences.
To that end, is there a way to link "latest" somehow straight to a download / zip?
I pull up latest then scroll down to "Assets" to get a TTF or just pull the master.zip from the home page.
Is pulling master.zip the recommended way to stay up-to-date or can you somehow link "latest" to the current TTF?
Thanks!

Assuming that file names will not change, here are links to latest release files:
https://github.com/blobject/agave/releases/latest/download/Agave-Regular.ttf
https://github.com/blobject/agave/releases/latest/download/Agave-Bold.ttf

Documentation

Hi kajukenbo, that's a good suggestion. In the next release, I'll try to make the readme a bit more accessible in this regard.
The links provided by alexeyten also work well, and the filenames shouldn't change in the foreseeable future.
If you use git, and are willing to keep a copy of this project on your disk, you can also pull it every now and then and the font files under dist/ should get up to date.

I've added links to the latest Regular and Bold font files at the top of the README. I hope you find that easier to get to. Releases (which contain snapshots of the font files at specific versions) will continue to be posted as well.


Binary Counter Effect layer type

When I let my laptop go idle for x amount of time, I fancy the idea that I could be greeted by a Binary clock. This could be used as a new layer type through a base converter, and a designation for where bits should illuminate.
This would make use for a few things that I wish to accomplish.
Display larger values (Such as Levels, Kills and Headshots) in a compact, yet readable way
Allows clocks to be used as custom away layers triggered with the conditional layer.

The Bits could be assigned to keys in an array. The more keys, the more bits can be displayed.
If I assign a value to keys Q W E R T & Y It would count up to 64 With Q being the 32 bit and Y being the 1 bit.
The order and number of keys signifying the highest bit to use for the counter , and location of each bit.
What do you think?

In the dev version of Aurora there is an overrides system which is similar to the conditional layers but allows you to enable/disable ANY type of layer on a condition. In a future version (that's I'm currently working on now), I have added an idle 'evaluatable' for the overrides system which basically outputs true if the mouse hasn't been clicked or a keyboard button pressed in a configurable amount of time.
A binary-like counter layer should be easy to make, and then with this future update it could easily be used as an idle clock. I like this idea 👍


config: fix minor typo in error message

Signed-off-by: Rama<EMAIL_ADDRESS>Description: Minor typo fix
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A

@htuch minor typo. PTAL when you get chance.


python310Packages.rapidfuzz: 2.13.6 -> 2.13.7

Description of changes
https://github.com/maxbachmann/RapidFuzz/blob/v2.13.7/CHANGELOG.rst

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 207228 run on x86_64-linux 1

2 packages failed to build:

python310Packages.poetry
python39Packages.poetry

9 packages built:

darwin.builder
puddletag
python310Packages.cleo
python310Packages.levenshtein
python310Packages.rapidfuzz
python39Packages.cleo
python39Packages.levenshtein
python39Packages.rapidfuzz
spotdl


How to pass information from client to bot framework composer directly and pick that value in composer ?

'm able to get email id and name through direct line token generation api, I also need to capture some additional information from the payload in direct line web client (eg.City) directly in composer.
How to capture those values in composer ?
In this  https://docs.microsoft.com/en-us/azure/bot-service/rest-api/bot-framework-rest-direct-line-3-0-authentication?view=azure-bot-service-4.0 , mentioned as

How to send those contents before directline sends  conversation update ?

The Microsoft Bot Framework team prefers that how to questions be submitted on Stack Overflow #botframework.
The official Bot Framework Github repos are the preferred platform for submitting bug fixes and feature requests.

Hi @Elsa2604 , Did you find an answer to the question you asked? If yes, Can you share it?

@KowsikRaviukumar pls refer this #4451 (comment) this might help you.

Thanks!! @Elsa2604


AAD new actions are developed as part of Azure Sentinel effort

AAD new actions are developed as part of Azure Sentinel effort to enrich the Logic Apps Connectors gallery. The user stories were made by costumer requests or security scenarios that works together with Azure Sentinel connector and leverages Microsoft Graph and AAD API capabilities. Actions been added
Invalidate all refresh tokens for a user:
User story: A new alert indicates that an AAD user might be compromised. SOC would like to invalidate all of the user’s refresh tokens issued to applications
Reset a user’s password
User story: A new alert indicates that an AAD user might be compromised. SOC would like to enforce this user to change his password.
Action name: enforce MFA on a user
User story: A new alert indicates that an AAD user might be compromised. SOC would like to enforce this user perform multi factor authentication.
Get user details
This action brings more fields then original Get user.
User story: A new alert indicates that there is something suspicious about a AAD user. Would like to send an informative mail about the user and include other details such as his department or write this data to a separate table.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ytognder sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

update for new one https://github.com/microsoft/PowerPlatformConnectors/pull/239


DynamicRoutingGateway error on querying "getBoundingClientRect"

Still getting the DRG error when querying unfortunately after the new release 0.10.0
dynamic_routing_gateway.js:33 Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null
    at DynamicRoutingGatewayView.draw (dynamic_routing_gateway.js:33)
    at OkitDesignerJsonView.draw (okit_designer_view.js:76)
    at displayDesignerView (okit_designer.js:646)
    at redrawSVGCanvas (okit_designer.js:251)
    at OkitOCIQuery.complete_callback (okit_designer.js:505)
    at OkitOCIQuery.isComplete (okit_query.js:42)
    at Object.success (okit_query.js:375)
    at fire (jquery-3.4.1.js:3291)
    at Object.fireWith [as resolveWith] (jquery-3.4.1.js:3421)
    at done (jquery-3.4.1.js:9533)

Should be okay the odd condition during query should not be hit now.


UI Access is not supported for Desktop AppX processes

Describe the bug
Cant use .MSIX packaging for WinUI3 Desktop apps that uses UIAccess.
When launching the app an error "the request is not supported" pops up, and the app fails to launch.
The following error is observed in event viewer:
0x80070032: Cannot create the process for package fd6e7c45-f095-4b47-a46a-71657af65eae_<IP_ADDRESS>_x64__0dbdf1n3n58kt because UI Access is not supported for Desktop AppX processes. [LaunchProcess]
Steps to reproduce the bug

Steps to reproduce the behavior:
Package any Winui3 App with UIaccess = True
Install apps .msix
Run app
Error Occurs
Expected behavior
it works
Version Info
OS: Windows 11 Build 22489.1000
NuGet package version:
WindowsAppSDK 0.1.0-prerelease3

Windows version
Saw the problem?

Insider Build (xxxxx)
Yes

May 2020 Update (19041)
Yes

November 2019 Update (18363)
Yes

May 2019 Update (18362)
Yes

October 2018 Update (17763)
Yes

Additional context
This is a major problem as it prevents apps that require UIaccess = True from using .MSIX packaging, commonly assistive technologies apps.

@jeffstall @jvintzel Is there any timeline for when this will be fixed?

Does the uiAutomation rescap help at all here?

Hi @riverar, Thanks for the suggestion, unfortunately that doesn't work either, still get the same UI Access is not supported for Desktop AppX processes error.
This is the list of capabilities I'm currently using.
  <Capabilities>
    <rescap:Capability Name="runFullTrust" />
    <rescap:Capability Name="uiaccess" />
    <rescap:Capability Name="allowElevation"/>
    <rescap:Capability Name="uiAutomation"/>
   </Capabilities>

The combination of runFullTrust and uiAccess (did you have a typo in your manifest?) is supposed to work.  I will follow up on the msdn documentation which is erroneous in this area.
Assigning issue to jvintzel for further follow up.

@EHO-makai Thanks for the reply,
I have added a copy of the manifest I'm using below.
I have also tried adding UIaccess = True to a desktop bridge app published with MSIX and using rescap runFullTrust and uiAccess, but it still doesnt work.
I agree that the documentation for this needs improvements.
'

uiaccesstest1 (Package)
samue
Images\StoreLogo.png

'

In addition to those capabilities in your appxmanifest.xml do you have a Fusion (aka SxS) manifest specifying
<requestedExecutionLevel level="highestAvailable" uiAccess="false" />

?
Here's the definitive link I'm aware of
This link mentions how the allowElevation capability is necessary but insufficient. That just says the manifest can declare activatable extension points that can run elevated; the capability doesn't guarantee there are any that will run elevated. You need both.

@DrusTheAxe, yes except mine says:
<requestedExecutionLevel level="asInvoker" uiAccess="true" />
As we don't need to run with elevated permission, just uiAccess

Just tried changing to <requestedExecutionLevel level="highestAvailable" uiAccess="true" /> , Problem persists

If you use uiAccess="true" in your fusion manifest, your app will need to be Authenticode signed and put into one of several trusted locations (e.g. system32, program files). (I don't believe that uiAccess mechanism got extended to the WindowsApps folder, hence @DrusTheAxe's false usage.)

Thanks for finding the root problem @riverar.
I assumed that the Windows Apps folder would have been a trusted folder - more so than program files.
So I guess the problem still stands, msix doesn't support uiaccess = true, as you can't change the install location for msix distributed apps.

Actually, seems WindowsApps is okay. From the docs:

The application must be installed in a local folder that is writeable only by administrators, such as the Program Files directory. The allowed directories for UI automation applications are [...] %ProgramFiles% and its subdirectories.

What's not clear is the relationship of the fusion manfiest uiAccess=true and the appxmanifest uiAccess rescap. And the nebulous errors you're getting are the cherry on top.
Hope we get to the bottom of this and establish a working pattern for others!

@jeffstall @jvintzel @anarvekar-msft @DrusTheAxeIs there any timeline for when this will be fixed?
I'm surprised this isn't required internally.

@Samuel12321 something odd (or at least not widely understood) is going on. Please file a bug with FeedbackHub for further investigation.
In FeedbackHub under 2. Choose a category please specify Developer Platform > App deployment to ensure the key set of data is captured, and under 4. Add more details tap "Start recording", reproduce the issue, then complete the feedback and it'll report a bug with detailed logs.
+@timkur

@DrusTheAxe have filed the bug.
Bit concerned that this is the second time I have been told to report this elsewhere
MSIX GitHub repo -> WASDK -> Feedback Hub

Bit concerned that this is the second time I have been told to report this elsewhere MSIX GitHub repo -> WASDK -> Feedback Hub

No need for concern. WASDK is more on point than MSIX GitHub repo, but it's unclear why there's a problem so FeedbackHub is a convenient way to share detailed logs for analysis, and submitting them via FeedbackHub keeps them handled appropriately (GDPR etc).
Have no fear, you're in the right neighborhood for the issue.

https://github.com/microsoft/microsoft-ui-xaml/issues/6331

@DrusTheAxe @timkur
Just Thought i would add the link to the feedback Hub item https://aka.ms/AAf3d73
Let me know if you need anything else

As we don't need to run with elevated permission, just uiAccess

How come on earth your WinUI 3 or WinUI 3 Xaml Islands (when it's available)    supposed to work with  uiaccess=true when WinUI 3 itself  doesn't yet support running Elevated !
Support running elevated across Win10 and Win11
Elevated/administrator isn't supported in MSIX WinAppSDK app on Windows 10
Dynamic Dependencies doesn't support Elevation

The app im trying to use this for ModernFlyouts, will be a wpf desktop bridge app with winui 2 xaml islands.

Steps to reproduce the behavior:
Package any Winui3 App with UIaccess = True

your reproduce steps said full WinUI 3 app.
Also,  WindowsAppSDK's AppWindow supports these UI Frameworks :: pure window Handle/raw Win32, MFC, WPF, WinForm and WinUI3.  AFAIK, system XAML/WinUI 1 , WinUI2 or WinUI2 Xaml Islands is not one of them.
If possible Remove the WinUI2 Xaml Islands component and re check if the problem still persists.

I don't have a winui 2 island in a winui 3 app.
I created a normal basic winui 3 app to test and experiment with uiaccess = true, and this is what I discovered the bug with.
However what I actually want to apply this (uiaccess =true) to is a wpf desktop bridge app with winui 2 islands. And subsequent testing revealed that it doesn't work with this either.

Basically what I was trying to say in response to-winui3 doesn't support elevation, is that this bug isn't specific to winui3 and unrelated to elevation not supporting winui3.

Has there been any progress with fixing this?

Also having the same issue. Would like to know if winui 3 will ever support this?

Has there been any progress with fixing this?
@DrusTheAxe @jeffstall @CLFPosthumus @kanismohammed-zz

Getting this problem trying to repackage SuperNova (magnification software) as an MSIX package for Azure Virtual Desktop. Are there any workarounds?

Due to this issue we are currently unable to MSIX SuperNova for Azure AVD. Is there any workaound or a fix available?
Thanks

The ModernFlyouts team has been blocked by this for a while, there does not appear to be a workaround or a fix that i am aware of, and Microsoft doesn't seem interested in fixing this.

Due to this issue we are currently unable to MSIX SuperNova for Azure AVD. Is there any workaround or a fix available? Thanks

What type of app is SuperNova - uwp ?

@Samuel12321  "SuperNova (magnification software)" Here is the link to the vendor's site-- https://yourdolphin.com/en-gb/product/version/major?id=4

We are also building accessibility software, and we are unable to ship via MSIX due to this outstanding issue.
Is there anything we can do to help resolve this (e.g. pitch in on some code)?

@jonwis @DrusTheAxe Is this on the roadmap for the next release by any chance? cc: @dotmorten for awareness

Providing additional ideas for those struggling with this...
While there may be many issues preventing this from working, consider this.  UIAccess=true is supposed to work without elevation if the exe with that manifest is located in a "well-known location", which includes "C:\Program Files" and sub-directories.
Many think of "C:\Program Files\WindowsApps" as a subdirectory for this purpose, but I believe that it is not.  WindowsApps is a NAMESPACE that is mapped (my word) to this place.  Thus an internal manifest with AsInvoker and UIAccess=true still causes a UAC prompt.
But even when approved by the end-user, things still go bad and the application launch via CreateProcess fails with 0x10dd, an error code that makes no sense to me.  This is with the package capabilities listed with runFullTrust, uiAccess, uiAutomation, and allowElevation.
Placing the exe in the package under VFS\ProgramFilesX64 and starting the package using a native path (a technique that works with App-V) also does not work, although the symptoms appear differently.

I can't reproduce this on Windows 11 25915 rs_prerelease (Canary) / Windows App SDK 1.3.230502000. @Samuel12321 can you still reproduce this issue?

If I fusion manifest the app with uiAccess=true, it produces the following events on deploy (unsigned msix):
Microsoft-Windows-AppXDeploymentServer/Operational
Failed to set the Trust Label on package 34060d07-2249-491b-853e-84e888561736_<IP_ADDRESS>_x86__30zg041h3evk2 with flags 0x0. Error: 0x80073CFC.

Deployment Register operation with target volume C: on Package 34060d07-2249-491b-853e-84e888561736_<IP_ADDRESS>_x86__30zg041h3evk2 from:  (AppxManifest.xml)  failed with error 0x80073CF6. See http://go.microsoft.com/fwlink/?LinkId=235160 for help diagnosing app deployment issues.

AppX Deployment operation failed for package 34060d07-2249-491b-853e-84e888561736_<IP_ADDRESS>_x86__30zg041h3evk2 with error 0x80073CF6. The specific error text for this failure is: error 0x80070005: While preparing to process the request, the system failed to register the windows.uiAccess extension due to the following error: Access is denied.
.

Doesn't seem like CentennialUiAccess (https://task.ms/19447269, added 3 years or so ago) works properly. Or there's some magic undocumented incantation needed here. (Possibly due to lack of testing outside non-Microsoft signed PEs?)

@jonwis @DrusTheAxe @dotMorten @MikeHillberg @bpulliam
Any Progress on this, its now been 2 years?

I've just run into this problem. So there is not any workaround to use UIAccess from a WinUI app with MSIX deployed? What are the alternatives to achieve TopMost with UIAccess?
I would like to draw over start menu.

No worries, in the Microsoft Store itself they also won't allow you to use uiAccess capability after a lengthy review process; even if your app is specifically used as a mouse replacement utility.


ErrorLens syntax errors show up under Show Default Settings (Json)

Problem
Errors when you view: default settings (JSON)

Cause ?
Maybe these 3 urls need to be escaped?
{ "markdownDeprecationMessage": "Deprecated in favor of `#errorLens.severityText#` & `#errorLens.messageTemplate#`.\n\nhttps://github.com/usernamehw/vscode-error-lens/issues/92", }

from:
https://github.dev/usernamehw/vscode-error-lens/blob/b0435d6ca25a61a9537d47a54999bd090947d070/package.json#L184-L184

Duplicate of https://github.com/usernamehw/vscode-error-lens/issues/97
Upstream issue: https://github.com/microsoft/vscode/issues/131345


[SAFETY] set cap number of deposit records to be staked per epoch

Closes #134
What is the purpose of the change
We limit the number of ICA calls that could process per epoch in order to avoid a potential scenario in which, after the channel having gone down for some time, the pending number of ICAs to be submitted fills the BeginBlocker gas limit on Stride.
Note: we choose to send only one ICA per MsgDelegate, so that we don't exceed the gas limit on host zones (the transactions would just be included in the next block).
Brief Changelog

Added MaxIcaCallsPerEpoch param in x/stakeibc
Added logic to cap number of ICA txs processed each epoch in hooks.go:StakeExistingDepositsOnHostZones
*Modified scripts-local/2.sh to manually test limiting the number of DRs processed.

Testing and Verifying
For this test, set stakeibc/types/params.go's DefaultDelegateInterval to 10, set its DefaultDepositInterval to 1, and its DefaultMaxICACallsPerEpoch to 2. STAKEs should happen less frequently than TRANSFERs, so we can see a pile-up of STAKE records and observe the cap on STAKE records processed (more or less simulating what would happen if MsgDelegate functionality were to go down for some time)
Set the params in init_stride.sh:
    jq '.app_state.stakeibc.params.delegate_interval = $interval' --arg interval 10 $main_config > json.tmp && mv json.tmp $main_config
    jq '.app_state.stakeibc.params.deposit_interval = $interval' --arg interval 1 $main_config > json.tmp && mv json.tmp $main_config

To run the test: make init-local build=s, then run gaia integration tests to fund the account, then run 2.sh. The script 2.sh adds more than MaxIcaCallsPerEpoch DepositRecords. At the next epoch, only MaxIcaCallsPerEpoch of these should be processed! Check this in accounts.log manually.
For my example test, all DRs between epoch numbers 13-18 were type STAKE, and at the 20th epoch, only 13 and 14 were staked (bc I had a MaxIcaCallsPerEpoch limit of 2!)

@asalzmann I think this is ready to merge

@riley-stride Is it possible to add a unittest for this?
Sorry, might have missed this if you responded to it somewhere

My bad, should have replied here re: unit test. Scaffolding the unit test is involved, so I added a note to include a test for this on the sheet on Sam's unit test for this. Will make sure to review that one.
Tagging for visibility @asalzmann @sampocs

Reference https://docs.google.com/spreadsheets/d/1TN6l6B-gIcPJvreBpopIK9hubml4tGHas-spdzP6MdM/edit?disco=AAAAeyNpTIo


Be an AuthenticationProvider so connection passwords can be held in keystore

Connection passwords can either be stored as plaintext in the connection definition or else be prompted for every time you connect.
Become an AuthenticationProvider that can store passwords in the workstation keystore/keychain. This API arrived in VS Code 1.54.
I think this is better approach than the env-variables one suggested in #452.

@gjsjohnmurray thanks for taking on the feedback. Is this live right now?
If it's on the main current release I'll go and re-install the extension today :)

@DaveParr no it isn't implemented yet. When it is we will update this issue.


Make asDBKey and asDBValue protected

Fixes #1832

I think this makes sense yes.
looks good.

Coverage decreased (-1.9%) to 72.341% when pulling f28034a358ee39036622be4d7bfbbfa1ea84ae10 on i1832 into 6ae03fde6d315a2aade89c1d6f1abced1ac8983d on master.

thanks @timowest !


Sample TodoApp Web app does not compile

Could not determine the dependencies of task ':common:utils:jsTestPackageJson'.
> Could not resolve all dependencies for configuration ':common:utils:jsTestNpm'.
   > Could not find org.jetbrains.kotlin:kotlin-test-common:null.

Looks like it was broken in #1511. I will try to fix it in the coming days.

Should be fixed in https://github.com/JetBrains/compose-jb/pull/1607#issuecomment-995253256

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Get current epoch number in the model's forward pass

❓ Questions and Help
What is your question?
Would it be possible to get current epoch number during model forwarding?
The reason I ask is that I want to freeze part of the model in the first K epoch of training.
Code
I am thinking of achieving the goal as below, the only problem remain is to get the epoch number.
class TransformerEncoder():
  def forward(input):
    if current_epoch < 5:
       with torch.no_grad():
           x=model_operation_1(input)
    else:
        x=model_operation_1(input)
    x2=model_operation_2(x, input)
    return x2

What have you tried?
I understand that we can get the epoch number during training loops using 'epoch_itr.epoch'.
But I want to get this number in the model forwarding.
One possible solution is to pass current epoch number as parameters all the way from trainer->criterion->model.
But I am wondering is there any better solutions? So that I don't have to change the input for all models/criterions.
What's your environment?

fairseq Version:  master
PyTorch Version: 1.5

So, how did you solve this problem?


WIP: 107 chinese insert commands

See #107 .
Can you double check that i don't break existing behaviour here? Maybe a different solution is more elegant (e.g. trim()-ing command strings before testing them)

Coverage remained the same at 92.549% when pulling 7b80f457281989f3920961ef0d730cec1b319137 on 107-chinese-insert-commands into 732f77abf586a08d73af5b2415e18d6b9eebc92c on master.

Indeed, trimming seems safer… But feel free to move ahead with this PR if you prefer this solution.

Thanks for taking a look! I'll go for the .trim() approach then.


Make id values consistant

Currently there is a mix of snake_case and kebab-case names used for ids. The Textual preferred way to name these seems to be kebab case so all the snake case ids should be changed to kebab case.
One example of this can be found here where generic_error should be renamed to generic-error. All queries and classes referencing these ids should be updated as well.

Assign this to me.


Crash when trying to access camera on iOS 10.1.1

Bowser crashes when trying to get access to the camera:

[access] This app has crashed because it attempted to access privacy-sensitive data without a usage description.  The app's Info.plist must contain an NSCameraUsageDescription key with a string value explaining to the user how the app uses this data.
Same for NSMicrophoneUsageDescription

Fixed by adding:
<key>NSCameraUsageDescription</key> <string>Please allow camera access</string> <key>NSMicrophoneUsageDescription</key> <string>Please allow microphone access</string>
to Bowser-Info.plist

Why not submit a PR?

Mostly because I don't feel comfortable enough with my English to construct a proper message explaining to the user how the app uses this data.