feat: add mitigation for the d(HE)ater DoS attack via ssh

Hi,
This PR adds SSHd configuration to mitigate the ssh d(HE)eater DoS attack, the mitigation consists in disabling a Diffie-Hellman Key Exchange algorithm (diffie-hellman-group1-sha1), more details can be found at https://github.com/Balasys/dheater
It also applies some ssh hardening from https://www.ssh-audit.com/hardening_guides.html namely settings a hardened list of Key Exchange Algorithms, Ciphers, HostKeyAlgorithms and Message Authentication Code Algorithms.
Please let me know if you need any more clarification.

Having to maintain these cipher lists will be an additional maintenance burden. What is the stance of OpenSSH regarding this CVE? Is it or are they planning a fix? If yes, I suggest we just update openssh via alpine and leave those ciphers at their default.

From what I could find OpenSSH will not fix this in future releases (https://www.mail-archive.com/openssh-bugs@mindrot.org/msg15476.html), I agree that this list is painful, and it could be reduced to just the change in line 26 since the other lines are extra hardening, not related to the CVE (CVE-2002-20001 btw), but will still be painful. Anyway, if you believe keeping just line 26 I'm fine to update the PR if you still believe it's not worth maintaining I can drop the PR too.
Thanks for your time :)

There could be a configurable option like LogLevel ${SSH_LOG_LEVEL} or ${SSH_MAX_SESSIONS} to let users decide, instead of hard-coding the ciphers inside the config file.

There could be a configurable option like LogLevel ${SSH_LOG_LEVEL} or ${SSH_MAX_SESSIONS} to let users decide, instead of hard-coding the ciphers inside the config file.
Update: since there are quite a few options, maybe it's better to introduce a general config for Include (https://man7.org/linux/man-pages/man5/sshd_config.5.html), allow users to write anything they need in their private config files.

This looks like an awesome idea, I will take a look at it and update this PR, thanks @wxiaoguang

Closing this PR as https://github.com/go-gitea/gitea/pull/19842 replaces it


re-status says "Application is currently running" even if process died

If you re-start an application then kill it, re-status still says "Application is currently running."

Yeah, this is actually a known issue. To question the state of a forked process is something which is currently lacking from sbt's Process API. I thought I created an issue in the sbt project but it seems I didn't so I will do that later.


X509 Rest Authentication fixes.

additional changes to improve X509 REST Authentication.  Moved X509CertificateExtractor to a separate @Configuration so both webflow and rest have access to it.  Plus relaxed @RequestBody requirement to optional, and added != null checks to the CredentialFactories

all of the travis test failures are from the merge with master, just updated again to see if they are fixed.

I have no clue how to troubleshoot this x509 webflow failure:
org.apereo.cas.adaptors.x509.web.flow.X509CertificateCredentialsRequestHeaderActionTests > verifyCredentialsResultsInAuthnFailure FAILED     org.junit.ComparisonFailure: expected:<[authenticationFailure]> but was:<[error]>         at org.junit.Assert.assertEquals(Assert.java:115)         at org.junit.Assert.assertEquals(Assert.java:144)         at org.apereo.cas.adaptors.x509.web.flow.X509CertificateCredentialsRequestHeaderActionTests.verifyCredentialsResultsInAuthnFailure(X509CertificateCredentialsRequestHeaderActionTests.java:45)
It also seems something in the changes this past week has now broken local builds for me, even if I completely clean slate the build environment.
`

Task :webapp:cas-server-webapp-jetty:nodeSetup FAILED

FAILURE: Build failed with an exception.

What went wrong:
Failed to capture snapshot of output files for task ':webapp:cas-server-webapp-jetty:nodeSetup' property 'nodeDir' during up-to-date check.

Could not list contents of '/home/ruckc/Repositories/apereo-cas-6/webapp/cas-server-webapp-jetty/.gradle/nodejs/node-v8.11.2-linux-x64/bin/npm'. Couldn't follow symbolic link.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.`

Any suggestions would be appreciated.

Are you seeing that error when you run the test locally or on travis ci?

Issue here is that your extractor bean id is not in fact what is referenced by the call sites. You had the bean defined as X and then you had Qualifier references refer to it as Y. Since the references used ObjectProvider, you'd always get a null object for the extractor due to the bean naming mismatch, and thus the failure. This has been fixed.


Provide a shortcodes list as array or in json format

it is pretty hard to fetch all available shortcodes from page
https://www.paymentwall.com/en/documentation/Payment-System-Shortcodes/2044
it would be nice to have a list in this library or as external package.

we provided payment system api for this case.


Easterlies perturbation data moved

The easterlies perturbation experiments 01deg_jra55v13_ryf9091_easterlies_down10 and 01deg_jra55v13_ryf9091_easterlies_up10 both seem to have been moved from ik11 to cj50, but the DB still has entries pointing to the ik11 location.
This leads to errors like
FileNotFoundError: [Errno 2] No such file or directory: '/g/data/ik11/outputs/access-om2-01/01deg_jra55v13_ryf9091_easterlies_down10/output1047/ocean/ocean_scalar.nc'

Should the database indexing pick up changes like this? And if so, do we know why it isn't?

Should the database indexing pick up changes like this? And if so, do we know why it isn't?

Yes and yes.
The reason it doesn't is that it doesn't have any logic to detect this condition. It relies on the directory being present and then it sees the files have been deleted and removes them from the DB.
It is perfectly possible to add the logic required to detect this condition.
In an ideal world there would be a script to move data from one location to another. The script could do the move and make the required changes to the database, so the data doesn't have to be re-indexed.
Of course this would still require people to use it.


Godot freezes whole computer if i set the MSAA level to 16x

Godot version:
92d4deedaa542e9458845fdf2b2a44fedd19fde8 master
OS/device including version:
Windows 10, GeForce RTX 2060/PCIe/SSE2
Issue description:
If i set the MSAA level to 16x in the projects settings, my computer becomes immediately unresponsive. I have to force reboot. If i reopen the project after the reboot it immediately does the same thing after selecting the project. I have to manually remove the setting in the project.godot. All other MSAA levels work fine.
Unfortunally i can't provide error messages, because of the immediate freeze.

Duplicate of https://github.com/godotengine/godot/issues/37917.


Web App - Edit page enhancements

Yan Liu requested that the Web App interface be refined to make its usage clear to users.

Parameters that can be in the URL value need to be specified somewhere on the App resource instance editing page.  These are currently only available by digging through the source code.
There needs to be validation of the URL.

Help pages serve the purpose for (1);
User is responsible for the validity of the url they created, HS just does some simple checks to make sure the general syntax/format of the url is correct.
Closing


Playlist link will not work

I paste the link into the space for bulk download, but nothing will come up in the queue. I don't understand, here's the link. Can you tell me what's wrong with it? Thank you!
https://www.youtube.com/playlist?list=PLw8AM0LVcN7g4goEaqoz06KI89fDq6_VT

Possible a duplicate of https://github.com/shaked6540/YoutubePlaylistDownloader/issues/354.

Should be solved in the latest update (1.9.25)

Ok, thank you.
On Fri, Oct 4, 2024, 4:08 PM Shaked Dahan @.***> wrote:

Should be solved in the latest update (1.9.25)
—
Reply to this email directly, view it on GitHub
https://github.com/shaked6540/YoutubePlaylistDownloader/issues/364#issuecomment-2394493973,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLWE5KTUBLOQ5AYOKO6TTNLZZ3YS5AVCNFSM6AAAAABPBILPVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGQ4TGOJXGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Handle different failure/error scenarios during socket reads.

A system as versatile as a Database needs to handles large number of connections under different failure conditions and high contention scenarios. Such system can experience multiple types of connection errors/issues. To ensure robustness of the system and better observability, we should identify and handle these error/issues and ensure a well defined behaviour. We can further breakdown on which errors need special handling and which ones can be treated generically.
Here are a few scenarios that we should handle while reading from a socket:

EOF (peer closed connection): Detected by comparing the error to io.EOF. (Partially addressed)
Zero-byte read: A read of 0 bytes without an error. In case of IO multiplexed scenario this means
a closed connection.
Timeout: Check if net.Error and checking if it's a timeout.
Connection closed locally: Detect by checking for syscall.EBADF or os.ErrClosed.
Connection reset: Detect by checking for syscall.ECONNRESET.
Other errors: Any other errors are reported as general read errors.

Note: Similarly, we need to handle different error/failure scenarios for connections handling and socket writes.

@JyotinderSingh I would like to work on this issue. Please assign it to me.

@JyotinderSingh I would like to work on this issue. Please assign it to me.

Assigned

Hey @ayushsatyam146  Do you have any updates on this? If you have any blockers lets discuss this over the discord.
Thanks a lot for contributing.

Removing the assignment due to inactivity.

I would like to work on this. @arpitbbhayani can you assign this to me?

If this is pending, I would like to work on it

Hi @AshwinKul28 I see this issue is partially addressed by another contributor. It would be great if you can point me out to that PR. It would help me to get a better inderstanding.

@AshwinKul28 @soumya-codes @JyotinderSingh can you please take a look


Line break separators

Describe the issue
The parser tester at least does not accept line breaks as a sufficient separator despite TypeScript's parser accepting them as such.
To Reproduce
Please provide failing expressions and the actual parser output. You can use https://jsdoc-type-pratt-parser.github.io/jsdoc-type-pratt-parser/ for this.

Supply this type to the tester:

{
  range: boolean
  loc: boolean
}

See the result: Error: Unterminated record type. Missing '}'

Expected behavior
Please provide the expected parser output for the expression if you can.
{
  "type": "JsdocTypeObject",
  "meta": {
    "separator": lineBreak????
  },
  "elements": [
    {
      "type": "JsdocTypeKeyValue",
      "key": "range",
      "right": {
        "type": "JsdocTypeName",
        "value": "boolean"
      },
      "optional": false,
      "readonly": false,
      "meta": {
        "hasLeftSideExpression": false
      }
    },
    {
      "type": "JsdocTypeKeyValue",
      "key": "loc",
      "right": {
        "type": "JsdocTypeName",
        "value": "boolean"
      },
      "optional": false,
      "readonly": false,
      "meta": {
        "hasLeftSideExpression": false
      }
    }
  ]
}

Additional context
Add any other context about the problem here.

Thanks for the report. For this to work we will need a new Token 'LineBreak' in the lexer. Before it was just discarding any whitespace before and after each token. No I will add the new Token if a line break exists. The only issue might be that now other parsing fails where linebreaks where allowed before. Maybe I can add a kind of backtracking where it first tries to parse with the linebreak token and then without if it detects one.

I have a solution that works without adding another token type. The only problem that exists is the stringification of a type as at the moment we don't store any whitespace in the AST. The given example would be stringified as {range: boolean; loc: boolean}. I don't know if you use that, but I think this is still a good first step.

:tada: This issue has been resolved in version 3.0.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

ok. I was wondering about this. At the moment the first separator is returned, while other separators are respected but not returned.


Crawl state variables for smart contracts

Currently, we only crawl method calls and events. But a user may legitimately want to know what the value of a member variable on a smart contract was at a given point in time.
We should extend our crawlers to also crawl this information.

That would be great!

That would be great!


Fixed website insecure asset load

Updated insecure asset (logo) to be loaded securely from origin
Added the asset
Removed dead HTML code

@kevinthesun @srochel

lgtm. Only concern is usually we put large files into https://github.com/dmlc/web-data. But if logo image is not large, we can put it in money repository.


[React DOM Interactions] useFocus overrides outside click handling

When using the useFocus hook, clicking outside of the trigger element always closes the tooltip.
Example sandbox: https://codesandbox.io/s/quirky-stitch-sw9cru?file=/src/App.tsx
The problem can be recreated by commenting out the focus interaction from the array passed to useInteractions.
Expected behavior: setting focus to keyboardOnly (especially with outsidePress set to false in dismiss) makes the tooltip not close when clicking outside of the trigger element
Current behavior: the tooltip closes when clicking outside of the trigger element
If this is intended behavior, is there an example of using custom logic or hook props to ensure the tooltip stays open, while still retaining focus handling (for a11y reasons)?

The browser blurs the element in this case which acts similarly to "outsidePress". Why would you want it to stay open if it's no longer focused?

Might be an odd use case but I'd like to keep the tooltip open if alt-tabbing.

I'm not sure how to really handle this, maybe just don't use the useFocus hook and make your own one? Or if you have a solution, feel free to make a PR.


account linking for mobile apps

This issue is imported from pivotal
	- start from api call

store ALA session
return URL to app (with ALA-session)
App opens webbrowser with url
Find ALA session
Start OIDC flow
oidc-redirecturl  (new)
find request based on state
store account link
return to app /mobile/client/account-linked or /mobile/client/eppn-already-linked or /mobile/client/expired (if the user took to long)
App stows result to user and refresh /me/

https://github.com/OpenConext/OpenConext-myconext/commit/16c31ddcb00f30d1265c20f3ee7fa01982877717 (Okke Harsta - Mar 17, 2023)


chore: minor refactoring of parse and usage messages

Codecov Report

Merging #71 (a45ca2a) into master (878966e) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master      #71   +/-   ##
=========================================
  Coverage     14.96%   14.96%
  Complexity      103      103
=========================================
  Files            73       73
  Lines          1443     1443
  Branches        132      132
=========================================
  Hits            216      216
  Misses         1216     1216
  Partials         11       11

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/FindCommand.java
0.00% <ø> (ø)

...a/seedu/address/logic/parser/AddCommandParser.java
0.00% <0.00%> (ø)

...eedu/address/logic/parser/DeleteCommandParser.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/FindCommandParser.java
0.00% <0.00%> (ø)

...a/seedu/address/logic/parser/RecipeBookParser.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/ViewCommandParser.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878966e...a45ca2a. Read the comment docs.


Counting in background problem

When program is running in background. The timer not continue in correct way what should I do

You can use native or isolate.I'll see if I can solve the problem with isolate later

You can use native or isolate. I'll see if I can solve the problem with isolate later

Do you get any solution?

I used another lib and it's working well
11 Şub 2021 Per 14:49 tarihinde vivek dhameliya<EMAIL_ADDRESS>şunu yazdı:

You can use native or isolate. I'll see if I can solve the problem with
isolate later
Do you get any solution?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wuweijian1997/FlutterCountdownTimer/issues/23#issuecomment-777394168,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHKXXZJDA2FPL7GLC4PY3PDS6O75VANCNFSM4W5DDJJQ
.

I used another lib and it's working well 11 Şub 2021 Per 14:49 tarihinde vivek dhameliya<EMAIL_ADDRESS>şunu yazdı:
…
You can use native or isolate. I'll see if I can solve the problem with isolate later Do you get any solution? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHKXXZJDA2FPL7GLC4PY3PDS6O75VANCNFSM4W5DDJJQ .

which library?


Notification drawer example dropdown kebab broken

I was playing with the notification drawer example and found two issues, in notification-body.html:

The dropdownKebabRight ID is being used in the repeated region, i.e. possibly generates duplicate IDs
The data-toggle="dropdown" attribute on the <button> conflicts with the JS provided by bootstrap. This causes the kebab to activate after a second click only.

...This causes the kebab to activate after a second click only.
Hi @skateman, sorry, I'm not seeing this behavior?  The kebab opens on the first click for me?

Hi @skateman, ok I removed data-toggle="dropdown" from the <button/> in notification-body.html for the Notification Drawer ngDoc example and the kabob menu continues to work on a single click.
<button/> in notification-body.html still has uib-dropdown-toggle which I believe is the correct angular-ui bootstrap attribute.
I'll work on dropdownKebabRight ID issue next.
Thanks,
Dave

@dtaylor113 yes, the uib-dropdown-toggle is okay, I fixed the attribute to the data-toggle above, sorry and thanks

I fixed the attribute to the data-toggle above, sorry

Sorry, where did you fix it?

@dtaylor113 in the PR description I had dropdown-toggle instead of data-toggle="dropdown"

Hi @skateman, do you need id="dropdownKebabRight"?  I removed it from notification drawer example, and the example and our unit tests continue to work correctly.

Not sure about the aria- prefix on the dropdown content, it has probably some semantic value. Ideally here you would have to generate a dynamic ID for each notification as we do it here. I know it's not pretty, but it would be nice if we could prevent people from copy-pasting bad stuff (we have a bunch of copy-pasted PF examples that cause duplicate ID issues and that makes QE cry sometimes).

I'm still not sure that example generates a unique id across all kabob action dropdowns.  It's based on notification.id, where it should be something like 'dropdownKebabRight-{{ notification.id }}-{{ notification.action.id }}' because there may be mutliple actions per notification.

Yup, but only one dropdown per-notification and the ID belongs to the dropdown.

ah, yes, correct, it's been a while :-)


Saml2p: AuthenticationProperties are null for RemoteAuthentication failures

Our IdentityProvider is a client of a SAML External Provider. During the authentication mechanism, our IdentityProvider delegates the authentication to said provider:
var props = new AuthenticationProperties
{
    RedirectUri = Url.Action("callback", new { Provider = scheme.Name }),
    Items =
    {
        { "returnUrl", model.ReturnUrl },
        { "scheme", scheme.Name }
    }
};

return Challenge(props, scheme.Name);

If, for example, the remote authentication takes too long, then the RemoteAuthenticationFailure handler kicks in. When that happens, we don't have any info in the Properties field of the RemoteFailureContext object:

This works correctly when the external authentication process is successful. It also works well for other protocols such as OIDC and OAuth2.0. In other words, the properties field is not null when an external authentication error occurs for an OIDC/OAuth2.0 external provider.

@scottbrady91

Hi! For component support, please could you send your support request to<EMAIL_ADDRESS>Once you open a ticket there, I can get a developer working on a fix.

Thanks. E-mail has been sent


pytorch doesn't clear out gradients between backward() calls in the gradient collector

I've been following along the linear regression code in the Dive into Deep Learning book. When using the pytorch engine the gradients are not cleared between backward propagation runs.
For example (this code is scala but that makes no difference):
val x = mn.arange(4.0f)
x.setRequiresGradient(true)
println(s"x=$x")

for(i <- 0 until 4) {
  Using.resource(Engine.getInstance().newGradientCollector()){ gc =>
      val y = x.dot(x) * 2
      gc.backward(y)
  }
  println(s"gradient=${x.getGradient()}")
}

The following code shows:
x=ND: (4) cpu() float32 hasGradient
[0., 1., 2., 3.]

gradient=ND: (4) cpu() float32
[ 0.,  4.,  8., 12.]

gradient=ND: (4) cpu() float32
[ 0.,  8., 16., 24.]

gradient=ND: (4) cpu() float32
[ 0., 12., 24., 36.]

gradient=ND: (4) cpu() float32
[ 0., 16., 32., 48.]

ie the gradients keep getting summed between runs when using the pytorch engine but the correct output (below) when swapping out the pytorch dependency for the mxnet one (identical code)
x=ND: (4) cpu() float32 hasGradient
[0., 1., 2., 3.]

gradient=ND: (4) cpu() float32
[ 0.,  4.,  8., 12.]

gradient=ND: (4) cpu() float32
[ 0.,  4.,  8., 12.]

gradient=ND: (4) cpu() float32
[ 0.,  4.,  8., 12.]

gradient=ND: (4) cpu() float32
[ 0.,  4.,  8., 12.]

This is under MacOS both x86 and ARM (CPU).

This is the expected behavior for PyTorch - by default if a PyTorch Tensor (or in this case a DJL NDArray backed by the PyTorch engine) enablessetRequireGradient, the gradients are accumulated with calls to .backward(). This behavior is documented in the PyTorch documentation. So, multiple calls to backward will result in the behavior you observed here with PyTorch.
In PyTorch you would call optimizer.zero_grad() with the optimizer you are using in the training loop to reset the gradients back to 0. In DJL, we don't expose this method directly to users and instead we call it as part of the optimizer updates. So, for the current example you have provided here I don't think there is a way to zero out the gradients without also using a Trainer and built in Optimizer (see this example of Training MNIST for more details).
Are there specific code blocks in the D2L book you were using where this behavior is causing confusion? I can take a look and see what we need to update.
I'm not sure whether it makes sense to us to expose the zero_grad() method since it seems like PyTorch specific behavior and we try to keep the API agnostic, but I can take a look at our code and reevaluate.

Thanks for your reply. I am new to the project and naively would expect that the different backends functioned more or less the same with respect to usage. I understand that this is probably is the case when using a Trainer etc.
I was going through the examples in section 2.5 (Automatic Differentiation) which are not run in the context of a Trainer so I was confused about the varying results. When I switched to MXNet the problem went away which I found surprising. [Obviously I'd prefer to use an ARM native JVM (without Rosetta) which the pytorch backend allows but MXNet does not).
I think putting a note in the chapter would be sufficient if you don't want to zero out the gradients in the collector.
BTW: When I didn't find an accessible zero_grad, I found that I could zero the gradients via:
x.getGradient().subi(x.getGradient())

which was sufficient for testing purposes.

I'm glad you found a way to get around the issue - that solution certainly works @ajrnz.
I'll take a look at the D2L book and see where a good place for this disclaimer is. There are probably some other places within our jupyter notebooks and examples and see whether we need to add similar notes.
I'm closing this issue, but feel free to reopen it if you come across any other instances where this behavioral difference causes confusion.

Can we simply add a zero_grad() step in the PyTorch implementation of backward call @siddvenk ? This solution assumes that repetitive calling of zero_grad() is ok, considering in Trainer there is also a step of zero_grad()

@KexinFeng we could, but I don't think we should. In case someone is using DJL + PyTorch for distributed training, they may choose to accumulate gradients over some microbatches before updating the weights. I think we should keep backwards the same as it's implemented in PyTorch now to avoid confusing users.


Exception when found insert lines from stored procedures

my_obfuscate-0.5.3/lib/my_obfuscate/copy_statement_parser.rb:20:in `block in parse': Cannot obfuscate Postgres dumps containing INSERT statements. Please use COPY statments. (RuntimeError)
copy_statement_parser.rb Throws an error when found inserts in PL/pgSQL stored procedures definition, the rest of the SQL have the COPY statments,
CREATE FUNCTION actualizar_existencia() RETURNS void
    LANGUAGE plpgsql
    AS $$
declare
...
        if not found then
            -- si no existe, creamos
            insert into lote_deposito_temp(cantidad, lote_id, deposito_id)
...

Will be good if my_obfuscate just ingore the inserts from store procedures,

Ah, interesting!  We haven't use any before.

:+1:


[WIP] Adds English major.

Edited reqs.json to include the English ("ENGL") major in Arts & Sciences.
Summary

This pull request adds the Arts & Sciences English major requirements.

[x] 40 total credits ENGL 2000 level or above (excluding ENGL 2800, 2810, 2880, 2890)
[ ] 12 credits of courses fulfilling the pre-1800 requirement
[x] 8 credits of courses above the ENGL 4000 level
[x] 12 credits within a recognizable academic concentration

Test Plan
Screen shots:

Notes
Pre-1800 is not done yet because in the class roster, the pre-1800 indication inconsistently uses both "Comments:" and "Satisfies Requirement:".
To describe the major, the JSON format needs to be able to search both catalogSatisfiesReq and catalogComments for a single requirement.
Something like: "search": ["catalogComments", "catalogSatisfiesReq"]

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@willespencer please take a look at the notes section, the format needs some tweaks for the English major. Thank you! :)

Notes on the CI failures: they are expected because Megan's fork does not have all the secrets. However, @meganshe does need to sign the CLA requested by the bot.

@meganshe The English major has been added in #53! Thank you so much for the help 😄

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Official support for Dell Venue 8 (Windows 8 tablet)

Initial results on the Dell Venue 8 with IE 11 DC1 are very promising.  Cesium Viewer runs at 25 FPS in full-screen.
Issues:

[x] Only touch drag to rotate works.  Touch for zoom and tilt do not work.
[ ] Double tap doesn't zoom to objects in the Sandcastle CZML example.
[x] Sandcastle (probably all one issue; everything is fine in full-screen)

[x] Pinch-zoom scales the entire webpage.
[x] Touch drag doesn't work.
[x] Touch doesn't work with Cesium UI elements (but Dojo/HTML5 UI elements work and Cesium picking works).

[ ] Tests failures are the same as desktop IE, except Renderer/Texture can create a texture from the framebuffer fails sometimes (we can just disable it if needed).

CC #1616 (desktop IE 11 support).

I vote to close this issue, @shunter implemented Pointer Events for IE and I just went through and tested everything and checked off the ones that worked, above.  Since double tap doesn't work on any phone/tablet device I've tried it doesn't make much sense to leave this open. (I ran unit tests in Chrome, everything passed.  Did not run IE).
I would consider all Windows tablets capable of running WebGL as supported.

+1


Add waves effect to fixed floating buttons demo.

In the buttons demo, there is no waves-effect class on the floating action button.

If you'd like to submit a pull request for the website documentation, I think you are supposed to edit the files in the jade folder, as the HTML pages would be automatically generated from those.
Apart from that, the floating action button on the documentation page does not have the waves effect added in both the page itself and the documented HTML. I assumed this was deliberate, but I do not know, either way both the documentation and actual page code should correlate and this pull request only edits one of the two.

@carlosperate Oh, I didn't realise that. I'll close this.