Broken eslint typescript rules that makes this codebase uglier

Need to make proper issues in typescript-eslint repo:
@typescript-eslint/no-unused-vars
Doesn't respect _ on unused types

Hi there @krzkaczor , I keep getting the following error which I believe might be related to the issue you are reporting:
SyntaxError: '{' expected. (25:37)
  23 |
  24 |
> 25 |   export interface Committed_address[] {
     |                                     ^
  26 |     name: "Committed"
  27 |     args: {
  28 |     whitelist : (string)[],

I'm migrating a truffle project to a hardhat/typechain/trufflev5 stack but all the contracts should be compiled without an issue. Any recommendation on a workaround? eslintignore? Also, unrelated, but the --no-typechain flag works only to turn it off when compiling but not when running the tests.

This looks like a unreleated problem - it seems that typechain generates invalid code for your ABI / contract name? Can you provide a repro case (and create a new issue)?


feat: remove harvesterhci.io/owned-by

Problem:

The harvesterhci.io/owned-by annotation is for checking PVC used by which VM. If there is resizing/deleting/attaching PVC request, the system uses it to check whether PVC is used on a running VM.
However, the annotation may be updated by users. In this case, the system can't do correct determination for the PVC.
Solution:

Introduce a new index VMByPVCIndex, this indexer can search PVC correspond to which VM by PVC name. It doesn't rely on annotation, so users don't have chance to update it.
Related Issue:
https://github.com/harvester/harvester/issues/5383
Additional context
It looks like Attached VM on Volumes page is from harvesterhci.io/owned-by annotation. We need another UI PR to fix this.

Test plan:

Case 1: a volume on a running VM can't be resized

Create a VM and make sure VM is running.
Resize the VM volume and webhook will deny the request.

Case 2: a volume on a stopped VM can be resized

Follow Case1.
Stop the VM.
Resize the VM volume without any error.
Start the VM without any error.

Case 3: a volume on a VM can't be deleted

Follow Case2.
Delete the volume and webhook will deny the request.

Case 4: a volume without VM can be deleted

Follow Case 3.
Delete the VM but not the volume.
After VM is removed, delete the volume without any error.

Case 5: delete a VM with volume can work

Create a new VM.
Delete the VM with volume.
Both VM and volume are removed.

Case 6: A volume can't be attached to another VM

Create 2 VMs.
Create a data volume and attach to one VM.
Try to attach the data volume to another VM and webhook will deny the request.

Case 7: Old VM can work with new controller.

Create a v1.3.0 harvester.
Create a VM. Check VM has harvesterhci.io/VMController.UnsetOwnerOfPVCs finalizer and VMI has wrangler.cattle.io/VMIController.UnsetOwnerOfPVCs.
Change the harvester and harvester-webhook image to this branch.
Delete the VM with volume.
Both resources will be removed.

It looks like Attached VM on Volumes page is from harvesterhci.io/owned-by annotation. We need another UI PR to fix this.

BTW, is there a corresponding frontend ticket for this? I looked, but it's possible I just missed it. CC @torchiaf

It looks like Attached VM on Volumes page is from harvesterhci.io/owned-by annotation. We need another UI PR to fix this.

BTW, is there a corresponding frontend ticket for this? I looked, but it's possible I just missed it. CC @torchiaf

I add require-ui/small tag to the issue first. Feel free to create another issue to track this. Thank you.

The e2e test case test_delete_volume_on_existing_vm fails because it uses the deprecated annotation to find a volume's attached VM.

Expand to see the error message
self = <harvester_e2e_tests.integrations.test_1_volumes.TestVolumeWithVM object at 0x7faa7bf3eb80>
api_client = HarvesterAPI('https://<IP_ADDRESS>', 'Bearer token-68thc:xk44xbjzxjb2bt2m67zdd9kd72pg457mzpps8dhlflzjm6587htdgr')
ubuntu_image = {'display_name': 'img-07h53m05s183224-07-04', 'id': 'default/img-07h53m05s183224-07-04', 'ssh_user': 'ubuntu'}
ubuntu_vm = {'actions': {'addVolume': 'https://<IP_ADDRESS>/v1/harvester/kubevirt.io.virtualmachines/default/vm-07h53m05s183224-0...mplate', ...}, 'apiVersion': 'kubevirt.io/v1', 'id': 'default/vm-07h53m05s183224-07-04', 'kind': 'VirtualMachine', ...}
polling_for = <function polling_for.<locals>._polling_for at 0x7faa7bd28280>

    def test_delete_volume_on_existing_vm(self, api_client, ubuntu_image, ubuntu_vm, polling_for):
        """
        1. Create a VM with volume
        2. Delete volume should reply 422
        3. Pause VM
        4. Delete volume should reply 422 too
        5. Stop VM
        6. Delete volume should reply 422 too
        Ref. https://github.com/harvester/tests/issues/905
        """
        vol_name = (ubuntu_vm["spec"]["template"]["spec"]["volumes"][0]
                             ['persistentVolumeClaim']['claimName'])

        code, data = api_client.volumes.delete(vol_name)
        assert 422 == code, f"Should fail to delete volume\n{code}, {data}"

        self.pause_vm(api_client, ubuntu_vm, polling_for)
        code, data = api_client.volumes.delete(vol_name)
        assert 422 == code, f"Should fail to delete volume\n{code}, {data}"

        self.stop_vm(api_client, ubuntu_vm, polling_for)
        code, data = api_client.volumes.delete(vol_name)
        assert 422 == code, f"Should fail to delete volume\n{code}, {data}"

        # Check Volume
        code, data = api_client.volumes.get(vol_name)
        mdata, annotations = data['metadata'], data['metadata']['annotations']
        assert 200 == code, (code, data)
        assert mdata['name'] == vol_name, (code, data)
        # status
        assert not mdata['state']['error'], (code, data)
        assert not mdata['state']['transitioning'], (code, data)
        assert data['status']['phase'] == "Bound", (code, data)
        # source
        assert ubuntu_image["id"] == annotations['harvesterhci.io/imageId'], (code, data)
        # attachment
>       assert ubuntu_vm['id'] in annotations.get("harvesterhci.io/owned-by"), data
E       TypeError: argument of type 'NoneType' is not iterable

harvester_e2e_tests/integrations/test_1_volumes.py:176: TypeError

I don't feel removing an annotation breaks our API, but we must give a heads-up to QA.
The GUI uses the deprecated annotation to display a volume's corresponding VM on the volume page (GUI ticket ). Is there a fast way to find the corresponding VM of a volume? Besides building the relationship from all VMs.

The GUI uses the deprecated annotation to display a volume's corresponding VM on the volume page (https://github.com/harvester/harvester/issues/5905). Is there a fast way to find the corresponding VM of a volume? Besides building the relationship from all VMs.

Another way to find attached VM from PVC is that:

PVC.spec.volumeName -> LH Volume
Volume.status.kubernetesStatus.workloadsStatus.workloadName -> VM

However, the workloadsStatus is a list, so we have to filter podStatus: Running in it.

The e2e test case test_delete_volume_on_existing_vm fails because it uses the deprecated annotation to find a volume's attached VM.
Expand to see the error message
I don't feel removing an annotation breaks our API, but we must give a heads-up to QA.
The GUI uses the deprecated annotation to display a volume's corresponding VM on the volume page (GUI ticket ). Is there a fast way to find the corresponding VM of a volume? Besides building the relationship from all VMs.

@lanfon72 @albinsun can you help check this?

The e2e test case test_delete_volume_on_existing_vm should work after merging the UI part: https://github.com/harvester/dashboard/pull/1065

Rebase master branch. I can run dashboard without error. Thank you.

@mergify backport v1.4


chore: classify added lemma porting notes

Classifies by adding number (#10756) to porting notes claiming added lemma.

bors d+


Feature Request: Cursor type on hover over today word

Before Submitting: Double-check that you are running the latest version of the plugin. The feature might have already been included 😄

I did :)

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

No just small UX idea

Describe the solution you'd like
A clear and concise description of what you want to happen.

the functionality added in #56 is perfect, the only thing id like added is the cursor change to the hand pointer vs arrow cursor to show that it is something that can be clicked on like the < and > arrows on either side of today because I didn't discover the functionality of #56 until today by accident.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

🙃

Additional context
Add any other context or screenshots about the feature request here.

none

Expansion of request @liamcain, hovering over the < and > display a little information popup "Next month" etc.
can the hovering over Today display "Go To Today's Note" or something that further indicates that clicking it has some functionality?
:)


cannot play m3u8 streams

Hello can anyone managed to play m3u8 streams with mediakit? Whatever Url I am setting it always gives me the same error: Could not render any streams from the source Uri.
I am sure the streams are working becaouse I can play them with my UWP app's media element. Is this an issue or I am doing something wrong? Here is my code:
        private void MediaPlayer_Loaded(object sender, RoutedEventArgs e)
        {
            MediaPlayer.LoadedBehavior = WPFMediaKit.DirectShow.MediaPlayers.MediaState.Manual;
            MediaPlayer.Source = new Uri(
                @"Some Uri that ends with m3u8",
                UriKind.RelativeOrAbsolute);
            MediaPlayer.Play();
        }

<controls:MediaUriElement
            x:Name="MediaPlayer"
            Grid.Row="0"
            Grid.RowSpan="2"
            Loaded="MediaPlayer_Loaded"
            Stretch="Fill"
            MediaFailed="MediaPlayer_MediaFailed"/>

I am subscribed to MediaFailed event which fires twice. First time it gives me: Could not render any streams from the source Uri. Second time is object reference not set error. I cannot figure out which object since there is not any indication. Any help is appriciated.

WPF-MediaKit itself cannot play m3u8 (or any other media formats). It always depends on the codecs installed.
Do not know much about the m3u8, but LAV Splitter should be able to play it. Try to enforce to use the LAV Splitter. However, it's possible the support may be limited and maybe it cannot play all m3u8.


Wrong jemalloc profiling sample rate

Bug Report

Steps to reproduce

Run command to get jemalloc stats
 tiup ctl:v7.6.0 tikv --host <IP_ADDRESS>:20160 metrics -t jemalloc

What did you expect?
Found
 opt.lg_prof_sample: 19 (prof.lg_sample: 19)

What did happened?
Found
 opt.lg_prof_sample: 19 (prof.lg_sample: 63)

Close it as it's not a problem in public branches


fix(secret):create objectstore secret before calling scheduler deploy

Create the objectstore secret before deploying as the current approach can cause 409 issues when multiple proctypes are present.
The error scenario can happen when moving from one k8s cluster to another cluster with external storage because of a cluster crash or any other reasons or during an upgrade from pre-deployments support in workflow(2.1/2/3) to latest.

Current coverage is 87.77% (diff: 100%)

Merging #1104 into master will decrease coverage by 0.01%

@@             master      #1104   diff @@
==========================================
  Files            42         42
  Lines          3629       3632     +3
  Methods           0          0
  Messages          0          0
  Branches        619        620     +1
==========================================
+ Hits           3186       3188     +2
- Misses          291        292     +1
  Partials        152        152

Powered by Codecov. Last update 9582496...55781e8


obj material name not support chinese

When an obj file references a material file named in Chinese, garbled errors may occur.

Would you agree that this can be closed as a duplicate of https://github.com/CesiumGS/obj2gltf/issues/182 ?


Avoid some allocations

The Key.V allocations here on each fun calls could be avoided by storing the existential in the key itself here in a ekey : t field to be defined via a let rec.

I'm not exactly sure, I suspect it's orthogonal. I also have an implementation that stores more stuff in the key, I think. You can use as much code from there as you want.
This PR exists simply because I saw a simple fix to apply :-)


Update configure-sharepoint-content-source.md

Site Column 'Duration' is defined at global level, if customer uses Content Type Hub or other global reuse tool for site columns the name 'Duration' will be problematic - need to keep consistent and name the column 'ContentDuration' to avoid collision with internal SharePoint column names.

@bhaswatic
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

Finalizing edits.

Looking to merge changes made to list column Duration --> ContentDuration @bhaswatic let me know if you need addtl context.


Example of working with dotnet:2.2-sdk-alpine

I've been wrestling to get this working with the Alpine builds of the donet core SDK.
Is there an example of this anywhere?

@kieronlanning I am trying to add this to alpine dotnet docker images. Similar code should work on alpine boxes as well. You can check that here: https://github.com/shubham90/dotnet-docker/blob/3edfe02ca476abdd653193c4344bf08832b6699a/2.2/sdk/alpine3.8/amd64/Dockerfile#L25

@shubham90 Splendid, thanks! I'll try it tomorrow morning.
Is there a specific image I should pull from?

Right now this hasn't been merged yet. But any dotnet 2.* sdk image should work.

@shubham90 I may have missed something here, what do I do here? Copy that whole file as a replacement for my normal base image?

@kieronlanning You can copy just the download, untar the credential provider and set the env var steps from that file if you want the credential provider in your container.
Another example gist  on how you can do it in your base image.

Gotch, thanks!


Quick pick: Ctrl+Home and Ctrl+End should go to the start and end of the list respectively

https://github.com/microsoft/vscode/issues/93641
Version: 1.44.0-insider (user setup)
Commit: d7d1147d6b764a48b789000c03088ee9afabcd8a
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

They do the same as home/end currently (work on the textbox).

Home/End work when you tab first to give focus to the list. While the focus is on the textbox, I expect Home/End to go to the textbox. (I suggest to leave this as it is.)

@chrmarti I think Daniel asks for Ctrl+Home / Ctrl+End to work on the list if I understand correctly.
But I see this as a feature request for the quick input widget itself, so moving off March.

Should it be cmd on mac?

Probably cmd+up/down as that matches what happens in the editor? @chrmarti any reason quickInput.ts isn't using commands and context keys here?

Fixing by making CMD work on Mac. Converting these to commands is tracked with #98479.


Incorrect handling of German umlauts in permalink generation

Issue Summary
When creating a permalink for a post title containing German umlauts (ä, ö, ü), Ghost incorrectly translates these characters. Instead of using the proper transliteration (ä=ae, ö=oe, ü=ue), it simply removes the umlaut, resulting in incorrect permalinks.
Expected Behavior
The permalink should be generated as:
"dies-wuerde-ein-test-sein-koennen"
Actual Behavior
The permalink is incorrectly generated as:
"dies-wurde-ein-test-sein-konnen"
Additional Information
This issue affects the readability and SEO of German-language content. The correct transliteration of umlauts is important for maintaining the meaning and searchability of the content.
Steps to Reproduce

Create a new post in Ghost
Set the post title to "Dies würde ein Test sein können"
Observe the automatically generated permalink

Ghost Version
5.94.0
Node.js Version
20
How did you install Ghost?
Selfhosted
Database type
MySQL 5.7
Browser & OS version
Firefox 130
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Hey noezdev, thanks for raising the issue! 🙂 The letters ä, ö, ü are not translated automatically to the German-equivalent ae, oe, ue as this would be incorrect for other languages that also make use of the same letters (e.g. Swedish, Finnish, Estonian, Turkish).Instead, we recommend choosing the right permalink for your post by updating the permalink in the Post Settings directly (cf. demo attached).
CleanShot 2024-09-16 at 17.55.42-converted.mp4
Hope this helps. 🙂

Thank you for your response to my issue. I understand your point that converting special characters in the URL can be a challenge. Interestingly, this used to be the case with WordPress, but was later changed. There are a few possible solutions:

You could consider the set language of the page and adjust the conversion based on that. This way, the German rules would apply to German content.
Alternatively, you could create a conversion table that defines how certain special characters are converted into URLs. This would enable consistent handling across languages.

Another point is that the conversion from “Ä” to “a” is also not optimal for all languages. In Swedish, for example, “ae” would be the preferred variant, not “a”. It would be great if Ghost could find a more flexible solution here that takes different languages and their particularities into account. Let me know if you have any further questions or ideas!


It seems that 'reqhdr' is not used in httpd.h !?

Hello,
I have just compiled your code and I see the following :
gcc -I include/ -o src/httpd.o -c src/httpd.c -Wall -pedantic
gcc -I include/ -o src/http_server src/main.c src/httpd.o -Wall -pedantic
In file included from src/main.c:1:
include/httpd.h:25:17: warning: ‘reqhdr’ defined but not used [-Wunused-variable]
   25 | static header_t reqhdr[17] = {{"\0", "\0"}};
      |                 ^~~~~~
Is there any mistake in your code ?
Thank you.

It's very strange note. reqhdr used in https://github.com/foxweb/pico/blob/master/httpd.c#L120 in 4 lines.


Unity: ignore TextMesh Pro

Reasons for making this change:
TextMesh Pro is fully integrated in Unity since 2017 and all related resources are managed by Unity's Package Manager. So it would make sense to ignore them by default
Links to documentation supporting these rule changes:
Check out the official blog post from early 2017

@qCring thanks!

@qCring I think this may be incorrect.. While TextMesh Pro has indeed moved to the package manager, the TextMesh Pro folder is still created when importing the "TMP Essential Assets".
As the name suggests, these assets are essential for using TMP, as stated in the dialogue that appears when you first add a TMP object into a scene.

@heatblayze if you feel like this should be reverted or changed, I'm open to a PR which helps improve things

sorry for the delayed response!
@heatblayze I agree, you are absolutely right
I expected all related dependency resources to be managed by Unity's package manager without double-checking. NuGet (or gradle or other comparable tools) perform package-related operations like restore/update/upgrade on the client-side. Dependecies are referenced in some manifest instead of actually pushing files to the VCS. Unfortunately, Unity handles things differently in this case. But this is no excuse, I really should have checked. Sorry for the inconvenience!
So yes, this should be reverted!

So yes, this should be reverted!

@qCring @heatblayze I'm not able to quickly revert this PR (because of subsequent changes to the file) but I'd love to see a PR to close this out now we're on the same page.

@heatblayze do you want to create a PR since you pointed out the issue?

@qCring Sure thing! I'll get onto it now


Java Service Language is broken because of workspace-level build.gradle

This bug was first observed and fixed by #693. The observation made was that the Java Service Language provided by the VS Code extension Language Support for Java(TM) by Red Hat, which provide IntelliSense for Java, is broken when the file build.gradle is included in the workspace root folder. This file was recently added back in #714 to include workspace-level configuration for Spotless.
Tasks

[x] Report the issue to https://github.com/redhat-developer/vscode-java

Done: https://github.com/redhat-developer/vscode-java/issues/2682

[ ] Check if there is a way to make the VS Code extension Spotless Gradle  work with build.gradle located outside of the workspace root folder.

Added to Backlog

While this issue is the results of a bug in the language support for Java, this support is more important that IntelliSense provided by the VS Code extension Spotless Gradle. Until the bug is fixed, I need to find a way to fix the format of Java files with Spotless on saving, which for now can no longer be done with Spotless Gradle.

Solution 1: Format all projects
Run yarn nx affected --target=format when saving files. This seems to be the easiest command to run when a file is saved. Performance wise, it's nice that the command is run only on projects that have been changed, which should be limited to the project being edited.
On my PC, it takes 3.4 seconds on average to format the file when saving.
$ hyperfine --runs 10 'yarn nx affected --target=format'
Benchmark 1: yarn nx affected --target=format
  Time (mean ± σ):      3.451 s ±  0.244 s    [User: 2.990 s, System: 0.331 s]
  Range (min … max):    3.172 s …  3.784 s    10 runs

Note
This time would increase on hosts with less or slower CPU cores.

Solution 2: Format active project with Nx
It is possible to get the list of affected project in CSV format. Here I'm setting --base=HEAD so that I'm only considering the files that have been changed but not committed yet.
$ nx print-affected --target=build --select=projects
challenge-auth-service, challenge-config-service, challenge-core-service, challenge-user-service

It takes about 0.5 seconds to get the list of affected projects.
$ hyperfine --runs 10 'nx print-affected --base=HEAD --target=build --select=projects'
Benchmark 1: nx print-affected --base=HEAD --target=build --select=projects
  Time (mean ± σ):     444.8 ms ±   9.5 ms    [User: 484.5 ms, System: 73.5 ms]
  Range (min … max):   431.4 ms … 462.9 ms    10 runs

Alternatively, we could find the name of the single project that includes the file being saved.

Solution 0: Use the VS Code extension Spotless Gradle
This extension enables to format files on save almost instantly + provide IntelliSense. This extension depends on the VS Code extension Gradle for Java.

Here are the activation events of Spotless Gradle.
Here are the [activation events](https://github.com/microsoft/vscode-gradle
/blob/b22c003344b3de84bb3788cbc25997364b03cf88/extension/package.json#L35) of Gradle for Java.

Update: Dropping Spotless Gradle
Motivation:

The removal of the extension simplifies the dev environment.
The project Spotless Gradle is relatively small (3 forks, 10 stars on Sept. 20).

The last release was 6 months ago.
It is unclear how fast a solution could be found for this issue and future issues.


Discussions

Can we open Discussions tab on github to help beginners? Like me :)

Let's try it: https://github.com/carbon-design-system/carbon-components-svelte/discussions


RFM - Meteor

Meteor is a web app development tool and framework: https://www.meteor.com/install.
Install link: https://www.meteor.com/install
I believe there's some automated chocolatey tooling for building new packages when new versions of an installer are released at a url. Windows URL is https://install.meteor.com/windows.

It seems like there is a package submitted for this one that was approved on the 23rd this month.
While the version doesn't match unfortunately, it still fulfils this request.
https://chocolatey.org/packages/meteor


vimPlugins.vim-godot: init at 2024-02-17

Description of changes
Add vim plugin vim-godot.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 300691 run on x86_64-linux 1

1 package built:

vimPlugins.vim-godot


Proposal: cancel the previous run when a new event occurs for the same Pull Request (PR).

/assign @wwcchh0123


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.5.26 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


dbs-boot: modify the version of dbs-boot to v0.1.1

Modify the version number in the Cargo.toml file to v0.1.1.

could you change that to v0.1.1?

could you change that to v0.1.1?

done


FakeSMC 'update available' confusion

This is probably a misunderstanding on my part, but ... that might help you make Hackintool a better tool for the majority who may have limited comprehension of the correct kexts to use?
As shown in my included image, Hackintool 2.8.0 shows FakeSMC 1800 as installed, but with an 'update available'.
I grabbed FakeSMC from https://bitbucket.org/RehabMan/os-x-fakesmc-kozlek/downloads/  and the date is 9/15/18.
I looked at the suggested url of: https://github.com/RehabMan/OS-X-FakeSMC-kozlek/tree/master/FakeSMC and noticed that the last commit was 6/7/17 - which seems earlier than my version?
I gather that RehabMan may have been inactive recently, with some of his code forked and modified.  How do I resolve this?  What's the 'correct' kext to use for 10.14.6?
I've thought of switching to VirtualSMC, but Clover still seems to use FakeSMC to determine whether to inject kexts, so I can't tell if that's the way to go?  I suppose it would show in the 'superseder' column at that point?
I love the tool - and have one small feature request.
If you added a checkbox to the 'installed kexts' tab for 'only show installed', this would make it a bit easier to see the 'big picture' quickly.  And a button to output to a text file a list of the installed kext names and their versions would be very useful in documenting version changes to a Hackintosh volume.
Might even pull the kexts to be injected, .aml's, drivers used, etc. from the Clover EFI to a text file?  I spend a lot of time documenting, making Carbon Copy backups, and then making small incremental changes.  This would really help to document that current state of the custom kexts installed in S/L/E and the EFI setup.

I'd like to add a few other suggestions to your Great utility:
Show these in 'Installed Kexts':
XHCI-unsupported.kext from https://github.com/RehabMan/OS-X-USB-Inject-All
IntelMausi.kext https://github.com/acidanthera/IntelMausi
And a small cosmetic issue - possibly remember screen size and position?


Add support for type exclusion with a predicate

As of v3.8, it is possible to exclude a group of types using EnhancedRandomBuilder#exclude(java.lang.Class<?>...). However, if I want to exclude all types in a given package (for example in java.util), I would need to list all types manually.
RB should provide an API to exclude a type using a java.util.function.Predicate. For example:
EnhancedRandom enhancedRandom = new EnhancedRandomBuilder()
          .excludeType(cls -> cls.getPackage().getName().startsWith("java.util"))
          .build();

This will also make it possible to combine predicates with java.util.function.Predicate#and and java.util.function.Predicate#or. RB can provide some static factory methods to create common predicates. A first effort on this has been made in the predicates branch.

Resolved with 39b7d38e14506283742e79eb954ad847e2433aff.


Initial release

[x] Directory: Fix context menu, fetch handlers on demand

[x] Directory: Cols as computed property

[x] Directory: Move scrolled window outside, not related to logic

[x] Gio: Fix worker

[x] Gio: Pass file type enum value, no key lookup

[x] Gio: Query for required attributes only

[x] Mount: Fix

[x] Readme: Screenshot

[x] Actions in menus

[x] Gjs: Hot reload in development env only

[x] Get viewer and editor from env

[x] Pre-commit lint

[x] Readme: Move todos to issues

Resolved in 51f4d01.


RAM usage way to high

Microsoft PowerToys version
0.83.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
General
Steps to reproduce
Windows 11, new machine setup from scratch over the past 1-2 weeks. Windows and Powertoys up2date.
The high memory usage was noticed this morning, with version 0.82.0. After the update (now v0.83.0) it's the same.
Steps: just starting Powertoys and checking the memory usage. Close and restart doesn't change anything.
✔ Expected Behavior
Significantly lower memory usage.
❌ Actual Behavior
Only a small number of PowerToys apps are activate, still we are at around 3GB of RAM usage -- see attached screenshot.
I also attach a bug-report.
PowerToysReport_2024-07-31-09-42-02.zip

Other Software
No interaction, just Powertoys itself.

Github closed this is "completed", was looking for duplicate and found it now.
Closing as duplicate of https://github.com/microsoft/PowerToys/issues/33315


using functions for default doesn't allow to change defaultDescription

This is super ugly ATM because not only it uses Function.name which is readonly and forces the developer to use a wrapper function to rename it, but also you can't use parenthesis in the name.
Example:
const moniker_ = require('moniker').choose

let argv = yargs
  .option('id', {
    alias: 'name',
    type: 'string',
    default: function moniker() { return moniker_() } ,
    describe: 'The log stream id'
  })

Nasty names_ and wrapper function, when all I wanted is to print moniker() there. I used to override Function.toString() which is ugly but at least I was able to achieve the desired result.

@kilianc, you are able to change the default description if you use the .default() method rather than the .option() shorthand:
let argv = yargs
  .option('id', {
    alias: 'name',
    type: 'string',
    describe: 'The log stream id'
  })
  .default('id', require('moniker').choose, 'moniker')

Any thoughts, with regards to better syntax -- I like the .option() shorthand (and tend to use it myself), but I want to be careful not to overcomplicate the feature ... does it seem reasonable to expect a user to drop down to a method like .default() if they need to set complex configuration settings?

probably using a new key defaultName if it's a function fixes everything

See similar request for defaultDescription in #140.

@kilianc<EMAIL_ADDRESS>should take care of this via a defaultDescription property defined in the object passed to option():
var argv = require('yargs')
  .option('id', {
    alias: 'name',
    type: 'string',
    default: require('moniker').choose,
    defaultDescription: 'moniker',
    describe: 'The log stream id'
  })
  .argv

Please give it a test run and let us know if it satisfies your use case. Thanks!

Closing based on the addition of defaultDescription. If this doesn't satisfy your use-case, please open another issue. Thanks!


Hyphen-minuses in names becomes  -002D-

This behavior is visible everywhere, not just in lambda names.
AWS CLI output:
$ aws lambda list-functions

"Functions": [
        {
            "FunctionName": "get-client",
            "FunctionArn": "arn:aws:lambda:us-east-1:631001006968:function:get-client",
            "Runtime": "nodejs12.x",
            "Role": "arn:aws:iam::631001006968:role/service-role/get-client-role-xbocqvrg",
            "Handler": "index.handler",
            "CodeSize": 727,
....

Terraformer output:
2020/02/10 11:50:33 Refreshing state... aws_lambda_function.tfer--get-002D-client

Versions:
aws-cli/1.17.9 Python/3.7.5 Linux/5.3.0-29-generic botocore/1.14.9
Terraform v0.12.20

provider.aws v2.48.0

$terraformer --version
version v0.8.6

I can confirm this!

yes, it's by design https://github.com/GoogleCloudPlatform/terraformer/pull/263
Maybe ugly, but we has many problem with name of resources.
I be happy for better solution.

yes, it's by design #263
It would be great to document this in some way.

This is similar to the points converted to other characters. If this is by design, this bug should be changed to add documentation about this behavior.


Github Actions for CI and Artifacts

Uses Github Actions to run linux+mac builds and upload release artifacts. The presence of the .github/workflows/build.yml file should work right away, and start running the CI jobs on pushes and PRs to master!
I also had to make some changes for the Mac build and app bundle:

adds Info.plist (without this, the app bundle on retina macbooks runs blurry with 2x scaling)
adds std=C++11 flag to get the map declaration to work (unsure if there's another solution)

Example of output: https://github.com/vgmoose/Cute3DSCapture/actions/runs/300164718 (jobs and terminal output are along the left sidebar)

Please have a look at my two comments. I'm fine with merging this without solutions to them, but maybe those things are easy wins.

Updated the PR, version info is now taken from configure.ac, however I wasn't able to get the static linking for Linux builds working. It seems like it may need more effort due to changes in SFML. (I also saw that SFML now has a Vulkan renderer, which could be useful in the future?)

Merged! Thanks a ton! :)


Mulltiple checkbox bound to an array looses reactivity if data is modified before being assigned to the state

Version
2.6.14
Reproduction link
https://jsfiddle.net/0pmojd65/6/
Steps to reproduce

Uncheck Product 1 or Product 2 checkbox. You'll see no state visual changes but checkbox is unchecked.

What is expected?
Product 1 checkbox and Product 2 checkbox should no be unchecked
What is actually happening?
Product 1 checkbox and Product 2 checkboxes are checked/unchecked

I  just want to be able to make a "middleware" for user data manipulation: prevent some checkboxes from being unchecked in computed setter or Vuex mutation. But checkboxes state seems to be not reactive. The workaround is to make checkboxes disabled but I am sure there's an explanation of such behaviour because I'm sure that's just my own misconception. Thank you.

I asked at Vue discord channel
I posted a question at https://stackoverflow.com/questions/68412132/mulltiple-checkbox-bound-to-an-array-looses-reactivity-if-data-is-modified-befor

For this specific scenario with checkboxes you need to manually set the checked state back to its original value in the computed as Vue will not have anything to update.
Please use the chat or forum for questions


Created a Vyper contract for SignatureVerification

This PR converts contracts/lib/SignatureVerification.sol to vyper/contracts/lib/SignatureVerification.vy.
As part of the new contract, 3 functions from LowLevelHelpers.sol were also included in SignatureVerification.vy. But only the _staticcall function was implemented due to not having low opcode access in Vyper.

_assertValidEIP1271Signature and _assertValidSignature can have max signature length of 100 bytes; We can decide on a different upperbound.
_staticcall can have a max callData length of 512 bytes; This upper bound can also be changed.

@0age , removed the low-level internal functions.


Fixed error notification text and max size validation in Cloud volume service

What type of PR is this?
/kind bug fix
What this PR does / why we need it:
This PR fixes the text in the error message for modify cloud volume and the validation of max size  error.
Which issue(s) this PR fixes:
Fixes #441  #442
Test Report Added?:
/kind TESTED
Test Report:
442

441

Special notes for your reviewer:

As this is not blocker, let's take it post Greenland release

Closing since this has been handled in #456


bump any version file

to be able to use this great utility in rails and other projects, I made the following changes

use current working directory if no gemspec is found
add option to provide custom versionfile location

I understand this might not fit your goal for this gem. In that case feel free to reject it :-)

:+1:

@runningonfumes looks good - would you mind rebasing please?

:+1:

👍

Thanks for the suggestion, @runningonfumes! And sorry for letting this get stale. I suppose the missing rebase made this get lost.
I have ported this to 2.0.0.pre.1 https://github.com/svenfuchs/gem-release/pull/64 in https://github.com/svenfuchs/gem-release/pull/64/commits/1362327fb4613d724a98020f6635e49ca36c3193
In order to give credit to your efforts I have also used --author 'wimwintmolders<EMAIL_ADDRESS>on the commit.
Thanks again!


Fix for Expandables on Blog

Fixes issue with initializing the atomic Expandable on the Blog
Changes

Adds code to scope the initializing of the Expandable

Review

@anselmbradford
@jimmynotjim
@KimberlyMunoz

Testing

Run bulp build and visit the /blog. Click on the filter; it should expand.

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

:+1:


hyper-h2 content length tracking doesn't work with HEAD requests

Responses to HEAD requests may have a Content-Length header that corresponds to what their body would be, but provide no body. Our content-length tracking doesn't respect that. We should fix it!
See also: #254.

Would this exception only be thrown with a HEAD request? Could we not extract the request method and add it to this conditional?
https://github.com/python-hyper/hyper-h2/blob/master/h2/stream.py#L1082

@aidylewis We absolutely could, though in practice I think we should do the initialization properly instead (initialize the expected length to zero, don't bother looking for the actual Content-Length header.

@Lukasa That would mean deleting the _track_content_length method and all references to it. All it does is compare expected with actual.

No, we can use _track_content_length. _track_content_length works in tandem with _initialize_content_length, right above it. I'm suggesting that _initialize_content_length should have a new branch in it that, based on request method, forces _expected_content_length to 0 if it's a HEAD request.

Would would be the best way to extract the request method?

It'll have to be searched out of the request headers when they're sent. Probably in send_headers.

Resolved by #264 via #258. Thanks @aidylewis!


Responsive navbar

Description:
This pull request introduces a fully responsive navbar to improve the navigation experience across different devices. The navbar has been designed to adapt seamlessly to various screen sizes, ensuring a user-friendly interface on mobile, tablet, and desktop views.
Key Features:
Responsive design using CSS media queries and flexible layout techniques.
Collapsible menu on smaller screens for better usability on mobile devices.
Smooth transitions for expanding/collapsing the navbar on smaller screens.
Updated styling to maintain consistency across different viewports.
Compatibility across major browsers.
Testing:
Tested the navbar on various screen sizes and devices to ensure responsiveness.

@Anjaliavv51 please accept my pull request I have resolved all the branch conflicts

@Pranith-Kantamneni changes are not good
I am closing the PR , create some other issue and ping me , i will assign that issue.


[CSL-2260] Use Millisecond type in Timer

Have you checked all call sites of setTimerDuration and newTimer?

Good catch, I pushed the changes.  Indeed there was a typo in the title. I also fixed a warning when compiling with stack about not exposed module from a test in wallet-new

I also fixed a warning when compiling with stack about not exposed module from a test in wallet-new

Right I saw this warning too but I just ignored it :)
Who's in charge of wallet-new? @adinapoli-iohk ?

@avieth @coot I think (but I'm toasted so don't take my words for meaningful 😁 ) that this stems from some recent renaming work Mr @edsko did. In particular, now Handlers.hs points to a desolated cliff and we forgot to update the specs to actually use the handlers in LegacyHandlers.
Said that, considering the current specs are not very useful at this stage, I think that's a benign warning: it's really telling us that something changed and that we should address it, but in practice it won't make any substantial difference right now 😁  (I hope to have stated my thoughts clearly enough).

@coot I'd say leave the warning be. It's certainly beyond the scope of this patch.
The CI failure is weird. Some missing constraint on a binary spec test. How could these changes have caused it?

@avieth As this PR merged develop into the feature branch, I bet it's due to this PR 😀

@avieth I reverted the change.

The CI failure is weird. Some missing constraint on a binary spec test. How could these changes have caused it?

Fixed in #2514, please rebase/merge.

@gromakovsky current develop branch is broken:
    [25 of 29] Compiling Pos.Explorer.Socket.Methods ( src/Pos/Explorer/Socket/Methods.hs, .stack-work/dist/x86_64-linux-tinfo6-nopie/Cabal-<IP_ADDRESS>/build/Pos/Explorer/Socket/Methods.o )

    /home/marcin/repos/iohk/cardano-sl/explorer/src/Pos/Explorer/Socket/Methods.hs:58:1: warning: [-Wunused-imports]
        The import of ‘Control.Exception.Safe’ is redundant
          except perhaps to import instances from ‘Control.Exception.Safe’
        To import instances alone, use: import Control.Exception.Safe()

at the moment.

I wouldn't say it's broken. Warning is bad of course, but at least it can be built and CI passes.
https://i.imgur.com/pjd0HwP.png

ok; I though that -Werror is used in CI as in the local setup. Probably that's why the commit slipped to the develop branch.

Currently it's used only on Windows, unfortunately. And Windows doesn't build explorer.


Using blacklist

I'd like to enable and disable some blocks using blacklist, i.e. list of blocks that will not be added to a ship when assembling. The list goes like
S:forbidden_blocks <
minecraft:dirt
minecraft:grass
...
use_whitelist=false
minecraft:water and minecraft:flowing_water are in the black list so they are not added to the ship. But liquid redstone is not in the blacklist, and yet it's not added to the ship either, flowing or not. Is it because any liquid is excluded by default? It would be really nice if we could have nuclear reactors on the ships.
Also, I understand the format is probably mod_name:item_name, but how exactly does it work? How shall I provide mod name, i.e. with spaces or without, is capitalization important, where shall I find the "technical" item's name?
Blocks I want to disable are Thaumcraft 4 nodes, since now they can be moved along with ship very easily, rendering Thaumcraft's node moving mechanic pointless.
Blocks I want to enable are basically all the liquids other than water that could be used to cool Big Reactors reactors (liquid redstone, liquid ender and such, whatever their correct names are).
Thanks in advance for your help!

Fluids are disabled on ships because they can cause building issues, that's why they won't assemble with your ship. For item names, I find just using tab complete with /give works fine to find what I need. The format that forge uses is modid:unlocalizedName for example, buildcraft:engineStone(don't think this is right just an example)

Oh, also this is not an archimedes ships issue so I'll be closing it. Please open an issue in www.github.com/darkevilmac/movingworld


Add libuast iterators support

Fixes #62.
Note: CI will fail until the libuast functions' PR have been merged and tagged (I used 1.6.0 in this PR, but could update) because of the change of int to size_t in nodeiface **Size interface functions.

Yes, my idea was to add the filtering functions in another PR after the Scala and Go clients have the iterators too.


SSL certificate error- SSL CERTIFICATE_VERIFY_FAILED - mageto api

If you face this problem then please put this code before calling the client
not to verify ssl
import os, ssl
if (not os.environ.get('PYTHONHTTPSVERIFY', '') and
getattr(ssl, '_create_unverified_context', None)):
ssl._create_default_https_context = ssl._create_unverified_context

You can also use the chain.pem file from the host by referencing it from an environment variable.
SSL_CERT_FILE=/path/to/yourfile/chain.pem

Adding to my previous comment - which I think is probably wrong here, as I had two SSL cert errors I was getting. In my code I call my magento site directly for some images using requests which was solved by putting the path to the chain file in my .env file. That fixed that part, but I hadn't bothered to realize that using this library didn't honor that.
I'd hope to dig in and modify this library to be able to provide the proper cert file so that I'm not just disabling verification, but I got shit to do, and just disabling it for now using via @rakeshlanjewar comment is what I'm going to use for now.


These don't run. Help!

NONE OF THE DEMO PROJECTS ACTUALLY RUN (XCODE 9.2, SWIFT 4).

@Fadedglyph  are still facing this issue ? or you have found some solution in that regard ?


feat(sink): support sink rate limit for external sink

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes https://github.com/risingwavelabs/risingwave/issues/16253
Support SET SINK_RATE_LIMIT and ALTER SINK ... SET SINK_RATE_LIMIT for external sink. Sink into table is not supported.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[x] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
Support session config SET SINK_RATE_LIMIT to ... and ALTER SINK ... SET SINK_RATE_LIMIT to ... for external sink. Sink into table is not supported. See example in rate_limit.slt

quick question: if the sink rate limit makes more data buffered in LogStore?

quick question: if the sink rate limit makes more data buffered in LogStore?

If sink decoupled is on, yes. If sink decoupled is off, it will cause backpressure.

These logs are keep repeating. Let me try to fix.
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed
2022-10-11T06:02:13.840593Z  WARN actor{otel.name="Actor 231" actor_id=231 prev_epoch=3160993419558912 curr_epoch=3160993541062656}:executor{otel.name="Sink E700000001"}: risingwave_connector::sink::log_store: rate limit control channel closed


Implement Scheme AST

Implement the abstract syntax tree for Scheme programs. It should support:

[ ] pretty-printing the AST
[ ] walkable/getting children

Some AST features can be unimplemented!() as they will have their own issues. Such as:

compilation to SVM bytecode (#31)
type-checking/semantic analysis (???)
optimization?

Started: 6f62923313313c666ffbb4f52a04f48d801f12ef


Move "GetPathRelativeTo" from terragrunt and patcher here as a utility function

So far, we have had to copy and paste the GetPathRelativeTo function from terragrunt repo to the patcher/util repo package. We should instead have this command available here so we avoid duplication.

This function already exists in go-commons: https://github.com/gruntwork-io/go-commons/blob/master/files/paths.go#L70.
However, it seems that a bug fix has been implemented in the function in Terragrunt, and hasn't been ported here.
Therefore the right course of action is:

[ ] Port the above bug fix from Terragrunt to go-commons
[ ] Remove the definition of GetPathRelativeTo from Terragrunt (and any other repos that currently define their own versions of it) and use the function from go-commons instead

Another bug in GetPathRelativeTo() was discovered and I just posted a fix in #78. After this is merged, I'll release another version of go-commons and ensure that all the repos that start to make use of GetPathRelativeTo() use this latest version.

Another bug in GetPathRelativeTo() was discovered and I just posted a fix in #78. After this is merged, I'll release another version of go-commons and ensure that all the repos that start to make use of GetPathRelativeTo() use this latest version.

This has been done.


Chore(warn): Remove warning Neither --kubeconfig nor --master was specified for InClusterConfig

Signed-off-by: uditgaurav<EMAIL_ADDRESS>What this PR does / why we need it:

This PR removes the warning Neither --kubeconfig nor --master as it can be misleading the actual error with the warning.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Checklist:

[ ] Fixes #
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] E2E run Required for the changes

Logs:

custom-chaos-workflow-1649915018-3069283066.txt


Final Presentation

Please prepare a PowerPoint presentation, addressing the following points:

What is our research question? This could be: "How can we accurately forecast future air travel demand on arbitrary routes?"
Why is this useful? This could be: "LCA studies of future air transport need this number to accurately predict absolute fuel consumption. In order to make an assessment of intermodal competition, we need to know absolute numbers. AND most country-level forecasts are proprietary and/or expensive."
What are our methods? This could be: "Regression of historical GDP/RPK data, informed by a systematic literature review..."
What are our preliminary results? This could be an excerpt from the literature review table, the GDP/RPK figure, maps, etc.
What are we planning to do until the end of the project?

[!IMPORTANT]
Please re-read the Scientific Research Guidance document and the Guidelines for Semester, BSc and MSc Projects at PSI-LEA and ETHZ-ESA (sent to you via email on 05.03.2024). These documents are reasonable summaries of what Prof. McKenna will expect.

@dodedic & @arebe337, please collect some of the feedback Prof. McKenna provided. I'll provide some starting points:

make limitations of our case study explicit (we don't perform a full cost-benefit analysis)
check if there is significant "sunken cost" if an air route is already operated
check if it is legitimate (=if other people have done it) to disregard the added economic benefit of new airport/train station construction
data validation

I tried to make the importance of this issue clear, @dodedic & @arebe337.
Do you still remember the feedback you received? I certainly don't - that's why I wrote some of it down 2 weeks ago.
Complete this issue ASAP, please.

Hi @michaelweinold , sorry that this has not been done to your satisfaction. While both Ben and I realised the importance of this issue wo both thought that the bullet points you wrote down earlier in this thread actually already pretty much summarised the top-level feedback we received quite well, especially with respect to the feedback that our research has certain limitations. So in the meantime we have been focusing on the other issues.
I certainly can't remember the exact details/wording of the feedback anymore but I know that those were the main points raised. We will take greater care of more detailed note-keeping next time.


Improve the documentation pages on mobile devices

I think if I tried to refactor the stylesheet using bootstrap it would look much better on mobile. I'm willing to take a stab at this if you think it addresses this issue.

It might work; I'm not familiar with bootstrap.
I'd suggest first reproducing the issue on your machine: install Jekyll, use jekyll serve to see the page, and see the mobile version using Chrome Devtools to simulate a mobile device.
Then you could try editing docs/style.css (especially the stuff inside the media query at the bottom) to make it look better on mobile.
Once it works, consider posting before/after screenshots or sending a PR and I'll have a look.

Fixed by @sfdeloach in #73.


Spelling Mistake in Readme

In the paragraph starting with "Users can define their own ..."
There  is a spelling mistake. This sentence

All the user needs do is list the

should be

All the user needs to do is , list the

Just fixed, thanks!


Remove GNO from slow.trade

Hi - as there are no GNO auctions running, could we remove GNO from slow.trade. But such that users can still withdraw their funds.
@W3stside - could you do this?
Thank you :)
cc @anxolin

closed in tag v2.7.1


[WEB] weird indentation happening with top line of code examples

Select one ...  (check one with "x")
[X] bug
[ ] feature request
[ ] enhancement

With the NG4 update we are seeing some odd indentation with the first line of code examples on the website. It is probably unwanted whitespace.

Can this be related to the recent issue of Modal backdrop not covering the beginning of the page?
https://github.com/vmware/clarity/issues/739
I wasn't able to reproduce it myself, though...

I don't think this is related to #739, @Jinnie . The reason I say this is that #739 only appears to be happening in Firefox. This indentation is happening in all browsers.
We are thinking it is related to the code minification in the website.

The fix for this was pushed with https://github.com/vmware/clarity/commit/3407cdd92fde708875435b99c5cb35edad7ecc53
It should be fixed when the website is next deployed.


Creates a "example" folder with a simple example

Many thanks for this, it's really nice to have some better documentation in this repo!


fix(pci.projects.onboarding): correct translation

MSB-84

Even if the ticket is still in quality check I will merge this pull request in order to be able to provide a new release branch.
Feel free to correct me it shouldn't handled as is.
Otherwise use label to give more information about ticket status.
Thanks!


[Refactor] Issue filing handling

Description of changes
Refactor how we are handling 'file issue' button activation.
Currently, the button has a href property on it and also an onClick property (where we send telemetry).
Instead, the button should only send an action message to the background, which should send telemetry and handle the logic to file the issues against the proper service.
Also: remove unneeded custom string type; add missing test to ensure key uniqueness across issue filing services.
Pull request checklist

[x] Addresses an existing issue: WI 1518658
[x] Added relevant unit test for your changes. (npm run test)
[x] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[x] Ran precheckin (npm run precheckin)
[ ] Added screenshots/GIFs for UI changes.

Sorry for the conflicts :-)


IRGen: Make sure we compare equal units in type size comparison

This is in some code to initialize variables for the debugger.
From the original commit
"Zero-initialize uninitialized Dictionary variables for the debugger.
To avoid the debugger displaying garbage or having expressions crash
when inspecting an uninitialized dictionary variable, zero-initialize
the first word of the alloca at -Onone.
"
Unfortunately, we are comparing different quantities in that code.
rdar://40043512

@swift-ci Please test and merge

@swift-ci Please smoke test linux

@swift-ci Please test linux


remove mlock as option as it is long gone.

@bratseth or @geirst or @jobergum PR

This is step 2 for #6152


Broken CDN links at https://jqueryvalidation.org/

First, big congrats - jquery-validation receives more than 500 M requests per month at jsDelivr, which makes it the 7th most popular package we host!
I noticed your website shows some broken links. We switched to a fully automated system in May, and new versions (in your case > 1.15.0) are available under different URLs. The correct links are:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>(note: this minified file doesn't seem to be in the npm package, but jsDelivr is able to generate it on-demand)

Feel free to ping me if you have any questions regarding this change.

Hi Martin, thanks for reaching out.
WOW, That's a big number. I never realized or even thought that we will reach a number like that. Thanks for hosting our files and helping delivering it to developers across the glob.
I'm aware of your changes but didn't had the chance to update the links on our website, and it's the right time to do it.
For the minified version of additional-methods file, we forgot to add it to the files published on npm https://github.com/jquery-validation/jquery-validation/blob/5482dfd95ff01bb89a4fe5171f67c63d90c12198/package.json#L30-L35
I will fix that in a followup PR and will try to do a patch release soon to fix that.
Thanks again for the heads up.
/cc @staabm

Opened #2057 and jquery-validation/validation-content#40 to fix the mentioned issues

thank you guys. just merged the PR. will be deployed when time allows this week.

changes deployed


Revert updating lazy_static [ECR-3492]

This reverts commit ee450f5f

See: https://jira.bf.local/browse/ECR-3492
Definition of Done

[ ] There are no TODOs left in the code
[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage remained the same at 86.016% when pulling 0943e75dac4db7dfa43386afb81b4ff9b2dd7782 on rollback_lazy_static into 31eb1bf5c2a8a79f20f304f48e37af30b0de2f0f on master.


Improve contributing instructions

This builds on the changes from https://github.com/rust-lang/miri/pull/1612 and should not be merged before.

Fix incorrect comment
Recommend x.py setup over manually editing config.toml
Link to rustc-dev-guide

For reference, these are the current compiler defaults for x.py setup:
$ cat src/bootstrap/defaults/config.compiler.toml
# These defaults are meant for contributors to the compiler who do not modify codegen or LLVM
[rust]
# This enables `RUSTC_LOG=debug`, avoiding confusing situations
# where adding `debug!()` appears to do nothing.
# However, it makes running the compiler slightly slower.
debug-logging = true
# This greatly increases the speed of rebuilds, especially when there are only minor changes. However, it makes the initial build slightly slower.
incremental = true

[llvm]
# Will download LLVM from CI if available on your platform (Linux only for now)
# https://github.com/rust-lang/rust/issues/77084 tracks support for more platforms
download-ci-llvm = "if-available"

:umbrella: The latest upstream changes (presumably #1612) made this pull request unmergeable. Please resolve the merge conflicts.
Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

Thanks! @bors r+

:pushpin: Commit 43ce2c2844ebe1918716a1e599b159a0eb5885cd has been approved by RalfJung

:hourglass: Testing commit 43ce2c2844ebe1918716a1e599b159a0eb5885cd with merge 66a58d43cca2a446a01c2a4c0c48a16449fa346a...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 66a58d43cca2a446a01c2a4c0c48a16449fa346a to master...


Rubik Cube Solver

I want to add Rubik Cube Solver which will be made using Python.

@TusharAMD , Kindly assign


add - index on tx_out.payment_cred

handy if you want to query utxos by payment credential.

@mebassett Would you mind adding an index on pool.hash_id in this migration too?


API reference such as https://lazka.github.io/pgi-docs/?

I have a small Python script (using Gtk+3 and introspection) that I would like to “translate” to Lua.
I wonder whether there is something similar to https://lazka.github.io/pgi-docs/ but with the proper Lua names.
Sorry, this may constitute a misuse of an API reference, but this is the way I have to write a Lua version of a previous Python script.
Many thanks for your help.

Well.... I do not really know much about the "Gtk universe" and do not know how those pages were generated.

but with the proper Lua names.

I think the names in "Lua land" should be the same as in Python? Basically, all of these should use the GObject-Introspection data and that is based on the C function names. For example, gtk_widget_show(widget) ends up as a widget:show() in lgi and widget.show() in Python (where widget is a GtkWidget).


Using variables to DRY and not clutter requests file

Hi!
Great plugin, it's very similar to this one: https://github.com/baverman/vial-http, which I use for REST APIs. Thank you for maintaining it.
I have one question though, I'm trying to figure out if I can use variables to not clutter my requests file, and to avoid hardcoding stuff. This is what I would like to do:
grpc -H "authorization: Bearer $ACCESS_TOKEN" -plaintext localhost:50051 position.Position.RecordPosition
{
    "lat": 1234,
    "long": 42
}

I tried many variants of this command with no success. ACCESS_TOKEN is an env var in this context, but I wouldn't mind if it was just one variable at the top of the file.
I really want to do that because I have many different requests using an access token, and hardcoding the token in each of them is not practical (the token changes regularly).
Is there a way to do that?

Glad to hear you're finding this plugin useful!
Supporting env variables would be really nice, but isn't supported at the moment. If you're willing, I'd be happy to review + merge a patch :smile:
Otherwise, I can try to find some time to build this out myself.

+1
Envs + variables would be great!

Hey @hudclark, today i installed grpc-nvim and i really love it. its amazing.
Env variables would be really helpful 🙏

Some other maybe helpful ideas: functions like string to bytes (base64)


How to make the evil line have a single color?

How to make the evil line have a single color?

(I am using the latest evil line config.)

check your colorscheme Statusline color


fix(frontend): moved testset out of application scope

Description
This PR aims to resolve the UX bug in the testset by moving it from the application scope to the project scope.
Related Issue
Closes AGE-964
QA

You should be able to create test sets using all available methods without any issues.
All features and functionalities should work as expected.

Same here, clicking on View testset navigates to a 404 page

Same here in the Evaluation Comparison view


Implement default values for the data-operation functions

Based on the discussion initiated by @pjuergens at #524, this issue takes one of the further improvements discussed in that issue:
The initial solution implemented in #527 implicitly assumes None if a value for a specific index on a but not on b (or vice-versa). For illustration, model_a|scen_b is dropped in the unit tests, see https://github.com/IAMconsortium/pyam/blob/63bbea845284f1127e04b1d55aa830b567cd1e0a/tests/test_ops.py#L10
As an additional feature, it would be helpful to (optionally) set a default value in the data-ops functions if a value is defined in one argument but not another.

Update: there is now a fillna option, but this not work with pint.Quantity instances.


Fix flaky tests

Where we were cleaning up after tests by deleting all resources in a
manifest there could be some issues if the namespace gets deleted before
other resources.
e.g. https://github.com/cookpad/terraform-aws-eks/runs/3339274291?check_suite_focus=true
If we just delete the namespace then k8s will handle cleaning up all the
resources in the namespace.

I think one more to change in validateDNS?

I don’t think this change is relevant for validateDNS since it doesn’t create or delete a namespace. 🤷♂not sure why we didn’t follow that pattern there…

I don’t think this change is relevant for validateDNS since it doesn’t create or delete a namespace. 🤷♂not sure why we didn’t follow that pattern there…

Ah you're right 💡 .. wonder if we should change it to follow that pattern instead of using default


vite-plugin-dts does not support

Describe the bug
Use tsx in the script tag to write the vue3 component, and when packaging and generating the declaration file, an error is reported。
Reproduction
lihanqi.com
Steps to reproduce
No response
System Info
vue ui

Validations

[X] Read the FAQ.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

Would you provide a minimum reproduction?

same problem

@wuyuedefeng May you provide a reproduction?

@wuyuedefeng May you provide a reproduction?

Ok, this is the project: https://github.com/dyn-components/json-view-vue
build commond: npm run build:lib

from: https://github.com/qmhc/vite-plugin-dts/issues/347#issue-2400223986
Now I used the version: 3.7.3, it work ok.

@wuyuedefeng You can refer to this FAQ.

Thanks, It's solved.


add support for summarize endpoint

Add support for summarize endpoint. Tested against local deployment.

lgtm right now but gonna need to add other fields in response / request

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Callum Choi:x: dauletCallum Choi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@daulet @choicallum do you want to update this for merger or close for now?

@daulet @choicallum do you want to update this for merger or close for now?

Summarize is a cohere-only endpoint for now, part of why we wanted to push towards having an internal repo for development. We can probably close for now, but definitely no merge yet.


Replace container in the _ZoomEnterTransition

This is a pre-migration of #82670 . If we make the zoom transition as default, it'll break many tests with Containers count test.
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

Can you just make this change as part of https://github.com/flutter/flutter/pull/82670 to keep the tests passing? It's odd to have a test enforcing that the transition will never contain a container. That's kinda an implementation detail.

Can you just make this change as part of #82670 to keep the tests passing? It's odd to have a test enforcing that the transition will never contain a container. That's kinda an implementation detail.

Sure. Just thinking that the PR might be more complex if they are altogether.


Minor highlight hotfix

Solves issue #51 by making module end use names with the same colors

Made an inverted pull-request ... sry


Visual Issues when rendering gaps in the Terrain under GLES2 in Android devices

If you add masks to the terrain to create a Cave or a Gap, under GLES2 on Android, it gives the below visual issue

This only happens with "certain camera angles only" (look below) here the camera is rotated just a few degrees and the effects disappear

The error is caused by setting VERTEX /= 0.0; in the vertex shader. Using discard in the fragment shader fixes the issue.
Adding a warning inside the generated shader to warn the user about this problem.


Make the "next" button wider

In current user testing of https://github.com/nonprofittechy/docassemble-HousingCodeChecklist persistent feedback is that the next button is hard to interact with. Just a little extra left and right margin should help for this specific button. Perhaps best option would be a minimum width?

.btn {
  min-width: 8em;
}

Pay attention to the download screen buttons--maybe we want to make those a little narrower.

@plocket made some css changes for the download screen to horizontally align the buttons on mobile awhile ago, and they contain .btn. This new rule seems to be overriding those rules, therefore you get the vertical button lineup as shown in the above image.
We could either apply this new rule to large screens only, so that we preserve the effect of @plocket's changes:
@media only screen and (min-width: 450px) {
  .btn {
    min-width: 8rem;
  }
}

Or we specifically address just the Next button using a different selector, which has no effect on the download screen:
.btn[type='submit'] {
  min-width: 8rem;
}

Focusing on just the submit buttons is reasonable. Would that also work on yes/no buttons for a datatype: yesno question?
Personally I did not know about rem. I don't have an opinion but @plocket might

Well, the checkbox for datatype: yesno is actually an image, not a real button so I'm not sure if we can style it or not. I'll play with it and see if we have any luck.

I mean the button that replaces "Next", not the inline version. Styling .btn definitely changes the yes/no.

yesnomaybe: buttons are all [type='submit'], so that should work. We might want to continue to think about what kinds of buttons we want to change and what kind we don't. Sometimes da just doesn't have the specificity that would allow us to be too picky, but sometimes there are things we can do.
As far as excluding the download page buttons, I suggest avoiding the method above. We can use more specific selectors that will target those buttons instead as long as this new css doesn't do anything crazy. For example, we want to avoid !important.

A related question: should we use em or rem? Does it matter in DA? Right now both are used in our styles.

Maybe we can make a separate issue for this?

@nonprofittechy - could you post an image of the yes/no button widened by the new btn. rule?
Maybe I am missing something obvious. When I tried btn. it din't effect yesno nor yesnomaybe. Inspection shows that they are fieldset.

I ended up doing just .btn-primary and .btn-secondary (secondary is needed to set the state when someone clicks and it briefly turns grey)
.btn-primary {
  min-width: 8em;
}

.btn-secondary {
  min-width: 8em;
}

I see, the image shows two regular buttons labeled Yes and No, not a real datatype: yesno question. That explains.

I played with the radio button and checkbox, here is one way to make a difference, just not sure if it's worth the trouble because the label size is not easy to sync with the image size. (Left=modified, right=original)

Looks like .btn[type='submit'] is sufficient for our issue, I push the code.


Comment Handling

Frontend and Backend for creating, editing, deleting, and chaining comments together

Individual Story Points:
Ben: 5
Daniel: 4


Implement Password Expiry Notifications

Is your feature request related to a problem? Please describe.
Currently, the application allows users to store and manage passwords, but there is no mechanism in place to notify users when their passwords become outdated or are due for rotation. This could result in users keeping the same passwords for too long, which might increase security risks.
Describe the solution you'd like
I would like to implement a Password Expiry Notification feature. This feature will notify users when their saved passwords are approaching the expiry date (e.g., 90 days from the last update) or have expired. The notification system could work as follows:
Introduce createdAt and updatedAt timestamps for each password entry.
Set a default password expiration duration (e.g., 90 days).
Use a scheduled task (cron job) to check daily for passwords nearing expiration.
Notify users via email or in-app notifications when their passwords are about to expire or have expired.
Describe alternatives you've considered
Alternatively, instead of fixed expiration times, a customizable expiration period could be introduced, allowing users to set their own expiry dates for different accounts based on their preferences.
Additional context
This feature would enhance the overall security of the password manager by encouraging users to rotate their passwords regularly. Here's an example of a possible notification message: "Your password for [website] is about to expire in 5 days. Please update it for continued security."
kindly assign this to me

Hi @refa8, the idea is wonderful. But i feel that its completely unnecessary to ask users to change their password, instead you can create some security enhancements can be implemented to ensure there are no potential security risks.
What say you? @jinx-vi-0

Hi @refa8, the idea is wonderful. But i feel that its completely unnecessary to ask users to change their password, instead you can create some security enhancements can be implemented to ensure there are no potential security risks.
What say you? @jinx-vi-0

Exactly, there is no need for that. If there are hundreds of passwords, it will be a cumbersome process to update all of them over a period of time.


Updated command to restart Forseti in v2.24.1

Updated command to restart Forseti in v2.24.1

Verified on GCP instance and checked database.


Missing --disable-custom-ca-trust in aks-preview argument summary

Describe the bug
The argument exist but is missing here:

https://learn.microsoft.com/en-us/cli/azure/aks/nodepool?view=azure-cli-latest#az-aks-nodepool-update(aks-preview)
Related command
az aks nodepool update --disable-custom-ca-trust
Errors
N/A
Issue script & Debug output
N/A
Expected behavior
Appearing in "argument summary"
Environment Summary
{
  "azure-cli": "2.63.0",
  "azure-cli-core": "2.63.0",
  "azure-cli-telemetry": "1.1.0",
  "extensions": {
    "ai-examples": "0.2.5",
    "aks-preview": "8.0.0b1",
    "ml": "2.29.0",
    "ssh": "2.0.5"
  }
}

Additional context
No response

Thank you for opening this issue, we will look into it.


Failing unit tests in master

I think the unit tests are failing due to a change in the editor.moveToBeginningOfNextParagraph() in atom.
I opened atom/atom#11354 to fix the behavior.

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


(1.x) [ARTEMIS-931] Fix HTTP Upgrade Connection

Fix isEquivalent() method to take into account the activemqServerName
property when httpUpgradeEnabled is true. Two ActiveMQ server hosted on
the same app server may have the same host and port (corresponding to
the Web server HTTP port). The activemqServerName property is used to
distinguish them.
Iron out HTTP upgrade handler so that the latch is always count down
and the channel context is closed unless the handshake was completed
successfully

JIRA: https://issues.apache.org/jira/browse/ARTEMIS-931

PR for master: https://github.com/apache/activemq-artemis/pull/991

@jmesnil I've merged this onto the 1.x branch.  Can you please close this PR.

thanks


cherry-pick(filter): add block-device-tag filter during manual claiming (#404)

Enforce check on block device tag even for cases where block
devices are claimed with block device name.
cherry-pick #404
Signed-off-by: Akhil Mohan<EMAIL_ADDRESS>

Codecov Report

Merging #486 into v0.8.x will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           v0.8.x     #486      +/-   ##
==========================================
- Coverage   40.53%   40.51%   -0.03%
==========================================
  Files          71       71
  Lines        3488     3490       +2
==========================================
  Hits         1414     1414
- Misses       1966     1968       +2
  Partials      108      108

Impacted Files
Coverage Δ

pkg/select/blockdevice/select.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dc984...a5903fa. Read the comment docs.


Ambassador sends unexpected 503 on check_alive endpoint at startup

Describe the bug
Ambassador live probe sends "ambassador seems to have died" during k8s watch initializations.
I've put a simple bash script during the initialization  with a kubectl port-forward to evaluate how long it lasts :
kubectl port-forward <pod> 8877

while [ true ]
do
    date
	curl <IP_ADDRESS>:8877/ambassador/v0/check_alive
	curl <IP_ADDRESS>:8877/ambassador/v0/check_ready
	sleep 1
done

Here the post-mortem :
Thu 29 Aug 2019 22:59:19 EDT
ambassador liveness check OK (18 seconds)
ambassador waiting for config
Thu 29 Aug 2019 22:59:21 EDT
ambassador seems to have died (20 seconds)
ambassador waiting for config
Thu 29 Aug 2019 22:59:22 EDT
ambassador seems to have died (21 seconds)
ambassador waiting for config
[...]
Thu 29 Aug 2019 22:59:40 EDT
ambassador seems to have died (39 seconds)
ambassador not ready (Never updated)
Thu 29 Aug 2019 22:59:42 EDT
ambassador seems to have died (41 seconds)
ambassador not ready (Never updated)
Thu 29 Aug 2019 22:59:43 EDT
ambassador liveness check OK (42 seconds)

Ambassador is down during 24 s, and it's a problem because in your official helmchart, the liveness probe initial delay is only 30s (at this point, ambassador has already been started for 18s now, creating an infinite crash loop).
The failure of the live probe seems to correspond with the scan of the k8s watches, when Ambassador wait for them to start.
It just stops answering in the middle of the procedure. Here some logs at 59:23
2019/08/30 02:59:23 aggregator: initialized k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: waiting for k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: waiting for k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: waiting for k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: initialized k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: waiting for k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: initialized k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: initialized k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: waiting for k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: waiting for k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: initialized k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: initialized k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: waiting for k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: waiting for k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate
2019/08/30 02:59:23 aggregator: initialized k8s watch: secret|some-namespace|metadata.name=some-secret-with-certificate

Then it comes back up at 59:43, when all the watch are up to date :
[2019-08-30 02:59:39.559][240][info][upstream] [source/server/lds_api.cc:60] lds: add/update listener 'ambassador-listener-8443'
2019-08-30 02:59:39 diagd 0.73.0 [P155TAmbassadorEventWatcher] WARNING: Scout: could not post report: HTTPSConnectionPool(host='kubernaut.io', port=443): Max retries exceeded with url: /scout (Caused by ConnectTimeoutError(<urllib3.connection.VerifiedHTTPSConnection object at 0x7f6a98d51630>, 'Connection to kubernaut.io timed out. (connect timeout=1)'))
2019-08-30 02:59:39 diagd 0.73.0 [P155TAmbassadorEventWatcher] INFO: Scout reports {"latest_version": "0.73.0", "exception": "could not post report: HTTPSConnectionPool(host='kubernaut.io', port=443): Max retries exceeded with url: /scout (Caused by ConnectTimeoutError(<urllib3.connection.VerifiedHTTPSConnection object at 0x7f6a98d51630>, 'Connection to kubernaut.io timed out. (connect timeout=1)'))", "cached": false, "timestamp":<PHONE_NUMBER>.723536}
2019-08-30 02:59:39 diagd 0.73.0 [P155TAmbassadorEventWatcher] INFO: Scout notices: []

To Reproduce
Steps to reproduce the behavior:

Create a service like this on your cluster.

apiVersion: v1
kind: Service
metadata:
  annotations:
    getambassador.io/config: |
      apiVersion: ambassador/v1
      kind:  Mapping
      ambassador_id: production
      name:  my_service_mapping_number_n
      prefix: "/"
      service: service_n.namespace_n.svc.cluster.local
      host: service_n.domain.com
      ---
      apiVersion: ambassador/v1
      kind: TLSContext
      name: my_service_context_number_n
      ambassador_id: production
      hosts:
      - service_n.domain.com
      secret: my-service-certificate.namespace_n

Create a lot of them, like at least 15 different services.

Expected behavior
Ambassador should not say it dies during initialization when obviously it's not the case, it should
just say it is not ready.
This is painfull because in the helm chart, the initial delay is set to 30s.
Our ambassador is a shared service for us, with a lot of apps on it, so it takes more time
than that to start, and the live probe is able to catch the 503 errors described above.
Then kubernetes kills the pod and it's the infinite crash loop.
Versions

Ambassador: 0.73
Kubernetes environment: Google Kubernetes Engine
Version: 1.12.7

Additional context
We have a lot of services attached to this ambassador, and unfortunately it makes this bug
bigger than it really is.
The fact that ambassador has to load a huge amount of certificate doesn't help, but the security
team in the company don't want to give wild cards, and we can't afford to manage one ambassador per team.

Probably also related to #1661.
I know it works by increasing the waiting time, but this shouldn't be something to be done manually (in my case I'm using the chart.

Exactly !

Hello,
Tested today with the 0.81.0, same problem.
Thanks

Still waiting, don't close.


Add a module for implementing Hash-like objects

Similar to Indexable or Enumerable, there should be a module for implementing Hash-like objects. This module could be included into Hash as well other Hash-like classes/modules such as ENV. The module could then be used in type-signatures for methods that can accept any Hash-like object, provided the object implements Hash-like key access.
Proposed Code
module Hashable(K,V)

  abstract def [](key : K) : V

  abstract def []=(key : K, value : V) : V

end

I will let others provide opinions on which methods should be abstract (#[]?, #[]??, #has_key?) and which methods should be implemented in the Hash-like module (#[]?, #fetch?). The module could also be named something else, such as Keyed, Fetchable, Mapped, Hashed, etc.
Usage
class Hash(K,V)

  include Hashable(K,V)

  def [](key : K) : V
    ...
  end

  def []=(key : K, value : V) : V
    ...
  end

end

module ENV
  extend Hashable(String, String?)

  def [](key : String) : String?
    ...
  end

  def []=(key : String, value : String?) : String?
    ...
  end

end

class Command
  @env : Hashable(String, String?)

  def initialize(@env = Hashable(String : String?))
  end
end

cmd_with_full_env = Command.new(env: ENV)
cmd_with_test_env = Command.new(env: {"HOME" => "/home/test", ...})

I came with the following conclusion a while ago. Hashable can be defined as follows:
module Hashable(K, V)
  include Enumerable({K, V})
end

Any including type then only needs to provide an implementation for each(& : {K, V} -> _). The default methods on Hashable would interpret self as a sequence of key-value pairs. This gives us some more default implementations:
module Hashable(K, V)
  def fetch(key : K, & : -> V) : V
    each do |(key2, value)|
      return value if key == key2
    end
    yield
  end

  def fetch(key : K, default : U) : V | U forall U
    fetch(key) { default }
  end

  def []?(key : K) : V?
    fetch(key, nil)
  end

  def [](key : K) : V
    fetch(key) { raise KeyError.new }
  end
end

[]= is omitted because not all Hashable types are mutable. Some questions remain:

NamedTuple should include Hashable(Symbol, ???), but we cannot write out that value type yet.
Methods like #select would most likely have default implementations in Hashable too; in that case, should they always return a Hash just as most methods in Enumerable return an Array?

Is there a better name than Hashable? That usually refers to an object that you can compute a hash of, so this use of it could be quite confusing.

I'm vaguely recalling there had already been a discussion about this started somewhere. But I can't find anything. Maybe I just discussed in my head 🤔

@straight-shoota yup, I'm pretty sure there was such discussion too :)

I think a fitting name would probably be Map (or Mapable if we insist on an adjective). The name Hash is really just an inherited Rubyism. This data type implementation is usually known as a hash map or hash table (Ruby just shortened that, introducing possible confusion with #hash), and the more generic interface is typically called map, dictionary, or associative array. Hence Map would make a good module name.

Mutability is IMO worth a discussion. I don't like that we only have modules for reading from a collection. Modifying a collection is equally as important and there should be a standardized interface for that. Of course, there are more differences in what kinds of mutating actions a specific collection type supports. Some are even immutable.
But writing to a collection should also work independently of a specific data type implementation and thus the interface should be standardized in a module. Before introducing a new module that again only covers reading, I think we should consider if and how we want to proceed for writing.
In Java for example, the Map interface defined mutating methods but immutable implementations just raise an exception. That's similar to IO, where read/write methods also raise if they're unavailable in the respective implementation. Of course, this doesn't provide as much type safety. An alternative would be to have additional Mutable module types.

Mentioned previously here https://github.com/crystal-lang/crystal/pull/10674#issuecomment-832716155

Mutability of Indexable is covered in #5142.
I think the bigger issue at hand is how to reconcile Hash and NamedTuple's interfaces (plus HTTP::Headers to a lesser extent) if both include Map.

I honestly wouldn't be too worried about NamedTuple not fitting in the Map interface. Its use case is mainly for named arguments and there's no need to be compatible with Hash for that. If it works, that's fine. But it's not a must.

Btw. there are more map types in stdlib besides Hash and NamedTuple: HTTP::Headers, HTTP::Cookies, URI::Params, YAML::Nodes::Mapping. Maybe more.

By the way, I specifically mentioned HTTP::Headers because it uses forward_missing_to @hash, so having a dedicated Map module would facilitate removing stdlib's uses of forward_missing_to.

JSON::Any and YAML::Any would also benefit from this.

PHP has https://www.php.net/manual/en/class.arrayaccess.php as technically this syntax doesn't require the type be a map, but just allows the data to be accessed as it it was an assoc array (map/hash).

JSON::Any and YAML::Any cannot include Indexable or Map because they are not always arrays or hashes, and because we don't want to allow arbitrary Anys to behave like containers (e.g. they shouldn't be allowed as arguments to Enumerable#zip).

Btw. there are more map types in stdlib besides Hash and NamedTuple: HTTP::Headers, HTTP::Cookies, URI::Params,  YAML::Nodes::Mapping. Maybe more.

If we go outside the stdlib we get cases like different variants of trees and caches which would be well served by implementing something like this.
I think I'd prefer Fetchable, Lookup or something over introducing potential confusion with Enumerable#map, but it is not a strong opinion.


Don't warn if parameter is only used as trigger

What this PR does / why we need it:
Parameters can be used to only trigger plans without being used in any templates. In this case no warning should be printed when verifying a package.

Fixes #1617

My leaning has changed :), The more I think about it... there should be a verifier for triggers / plan names (which is performed irrespective of use).  This should be captured as an error and would cover this situation.   I'm not sure if that needs to be duplicated here.  This seems 👌  the way it is but we need additional logic which I will capture in an issue.


first spike of https://github.com/fabric8io/fabric8/issues/4143 so that we can automate the creation of a hubot user in letschat and setup letschat and hubot-letschat with the token correctly. Also created a stand alone chat app group

first spike of https://github.com/fabric8io/fabric8/issues/4143 so that we can automate the creation of a hubot user in letschat and setup letschat and hubot-letschat with the token correctly. Also created a stand alone chat app group

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/566/
Test PASSed.


docs: Add doc ULSIF, RULSIF, IWN, IWC, PRED...

Codecov Report

Merging #84 (77a8fb3) into master (4491aad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   92.74%   92.74%
=======================================
  Files          37       37
  Lines        4408     4409    +1
=======================================
+ Hits         4088     4089    +1
  Misses        320      320

Impacted Files
Coverage Δ

adapt/feature_based/_cdan.py
89.34% <ø> (ø)

adapt/feature_based/_mcd.py
97.41% <ø> (ø)

adapt/feature_based/_mdd.py
94.93% <ø> (ø)

adapt/feature_based/_tca.py
100.00% <ø> (ø)

adapt/feature_based/_wdgrl.py
100.00% <ø> (ø)

adapt/instance_based/_balancedweighting.py
88.46% <ø> (ø)

adapt/instance_based/_iwc.py
78.26% <ø> (ø)

adapt/instance_based/_ulsif.py
87.12% <ø> (ø)

adapt/instance_based/_wann.py
92.30% <ø> (ø)

adapt/parameter_based/_linint.py
100.00% <ø> (ø)

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


--prefix-components-with-info-prop repeats prefixes multiple times in $ref's randomly

When join multiple specification with the join command and the --prefix-components-with-info-prop flag, the resulting specification will contain references with prefixed repeated multiple times based of a random principle like that:
... $ref: '#/components/schemas/prefix_prefix_Component'

These references cannot be resolved later because components themselves prefixed one time as expected like that:
...
        prefix_Component:
...

can you provide a minimal example?

Yes. Joining redoc.yaml and swagger.yaml gives a duplicate at 428 line in the resulting openapi.yaml if run:
$ redocly join redoc.yaml swagger.yaml --prefix-components-with-info-prop version --prefix-tags-with-filename

Thanks for reporting!
@IgorKarpiuk could you check if this is related to https://github.com/Redocly/redocly-cli/pull/1291 and the corresponding issue?

@tatomyr It is not related


aws-sdk is vulnerable

https://nvd.nist.gov/vuln/detail/CVE-2020-28472
currently the version used is 2.784.0 https://github.com/elasticsearch-dump/elasticsearch-dump/blob/master/package.json#L32
Elasticdump should use at least the version 2.814.0.

Duplicate of #783


fix: Remove double semicolon

This may be partly an IE fix, but it makes sense for other browers too

Thanks for the fix!


Fix npm publish

Since adapter is not at root, we need to specify the package file location.

Wrong repo


Simplify the Credential.refresh* methods

Looks good to me.

Correct. If a developer really wants to deal with plain access tokens, they can use the Token object directly and don't need the Credential convenience class. If they are using the conveniences though, the recommended practice is to just use the authorize(_:) method to add authorization headers to a URLRequest.
The doc feedback I got was that it was confusing, during a refresh, what to do with the token. So it's clearer to just not return it, since there's nothing actionable on the part of a developer.


Bot talents not working not sure if this would be a solution

so i can tell they think they have the talents but they do not. i was wondering would it be possible to allow the player to open the bots talents and manually select the bots talents as a workaround? enabling this may help work on bots using lfg and bgs. the lack of talents may be linked to them not using lfg

Thank you for the idea! Unfortunately this would not be possible without client modifications. The client's talent UI is only for the player's talents. I think it will be easier to fix the original issue and let the bots choose appropriate talents.