Issue with ARM template for p2s connectivity

Hi,
I am trying to create an ARM template to set up P2S VPN connectivity with vWAN.
Using P2S VPN, I will connect to a VM in a Virtual Network. This Virtual Network will be connected to vWAN as well.
However, although VPN connectivity is established, I am not able to RDP to VMs in virtual networks.
Can someone please help in validating the ARM template as discussed below?
My vWAN and vWAN Hub have got following definition.
{
            "type": "Microsoft.Network/virtualWans",
            "name": "[parameters('vwanName')]",
            "apiVersion": "2020-05-01",
            "location": "[resourceGroup().location]",
            "properties": {
                "allowVnetToVnetTraffic": true,
                "type": "Standard"
            }
        }

{
            "type": "Microsoft.Network/virtualHubs",
            "name": "[parameters('vWanHubName')]",
            "apiVersion": "2020-04-01",
            "location": "[resourceGroup().location]",
            "dependsOn": [
                "[resourceId('Microsoft.Network/virtualWans/', parameters('vwanName'))]",
                "[resourceId('Microsoft.Network/virtualNetworks', parameters('spoke3VnetName'))]",
                "[resourceId('Microsoft.Network/virtualNetworks', parameters('spoke4VnetName'))]"
            ],
            "properties": {
                "addressPrefix": "[parameters('vwanHubAddressPrefix')]",
                "virtualWan": {
                    "id": "[resourceId('Microsoft.Network/virtualWans',parameters('vwanName'))]"
                },
                 "p2SVpnGateway": {
                    "id": "[resourceId('Microsoft.Network/p2sVpnGateways', parameters('vwanP2SVpnGatewayName'))]"
                },
                "virtualNetworkConnections": [
                    {
                        "name": "vhub-to-spoke3",
                        "properties": {
                            "remoteVirtualNetwork": {
                                "id": "[resourceId('Microsoft.Network/virtualNetworks', parameters('spoke3VnetName'))]"
                            },
                            "allowHubToRemoteVnetTransit": true,
                            "allowRemoteVnetToUseHubVnetGateways": false,
                            "enableInternetSecurity": true
                        }
                    },
                    {
                        "name": "vhub-to-spoke4",
                        "properties": {
                            "remoteVirtualNetwork": {
                                "id": "[resourceId('Microsoft.Network/virtualNetworks', parameters('spoke4VnetName'))]"
                            },
                            "allowHubToRemoteVnetTransit": true,
                            "allowRemoteVnetToUseHubVnetGateways": false,
                            "enableInternetSecurity": true
                        }
                    }
                ],
                "sku": "Standard"
            }
        }

VPN server config is as below.
{
            "type": "Microsoft.Network/vpnServerConfigurations",
            "apiVersion": "2020-05-01",
            "name": "vwan-p2s-vpn-config",
            "location": "[resourceGroup().location]",
            "properties": {
                "vpnProtocols": [
                    "IkeV2"
                ],
                "vpnAuthenticationTypes": [
                    "Certificate"
                ],
                "vpnClientRootCertificates": [
                    {
                        "name": "[parameters('clientRootCertName')]",
                        "publicCertData": "[parameters('clientRootCertData')]"
                    }
                ],
                "vpnClientRevokedCertificates": [],
                "radiusServers": [],
                "radiusServerRootCertificates": [],
                "radiusClientRootCertificates": [],
                "vpnClientIpsecPolicies": []
            }
        }

I create 2 hub route tables as shown below.
         {
            "type": "Microsoft.Network/virtualHubs/hubRouteTables",
            "apiVersion": "2020-05-01",
            "name": "[concat(parameters('vWanHubName'), '/defaultRouteTable')]",
            "dependsOn": [
                "[resourceId('Microsoft.Network/virtualHubs', parameters('vWanHubName'))]"
            ],
            "properties": {
                "routes": [
                            {
                        "name": "spoke3route",
                        "destinationType": "CIDR",
                           "destinations": [
                               "<IP_ADDRESS>/24"
                            ],
                        "nextHopType": "ResourceId",
                        "nextHop": "[resourceId('Microsoft.Network/virtualHubs/hubVirtualNetworkConnections', parameters('vWanHubName'), 'vhub-to-spoke3')]"
                    }
                 ],
                "labels": [
                    "default"
                ]
            }
        },
        {
            "type": "Microsoft.Network/virtualHubs/hubRouteTables",
            "apiVersion": "2020-05-01",
            "name": "[concat(parameters('vWanHubName'), '/noneRouteTable')]",
            "dependsOn": [
                "[resourceId('Microsoft.Network/virtualHubs', parameters('vWanHubName'))]"
            ],
            "properties": {
                "routes": [],
                "labels": [
                    "none"
                ]
            }
        }

P2S VPN Gateway is configured with following configuration.
{
            "type": "Microsoft.Network/p2sVpnGateways",
            "apiVersion": "2020-05-01",
            "name": "[parameters('vwanP2SVpnGatewayName')]",
            "location": "uksouth",
            "dependsOn": [
                "[resourceId('Microsoft.Network/virtualHubs', parameters('vWanHubName'))]",
                "[resourceId('Microsoft.Network/vpnServerConfigurations', 'vwan-p2s-vpn-config')]",
                "[resourceId('Microsoft.Network/virtualHubs/hubRouteTables', parameters('vWanHubName'), 'defaultRouteTable')]"
            ],
            "properties": {
                "virtualHub": {
                    "id": "[resourceId('Microsoft.Network/virtualHubs', parameters('vWanHubName'))]"
                },
                "vpnServerConfiguration": {
                    "id": "[resourceId('Microsoft.Network/vpnServerConfigurations', 'vwan-p2s-vpn-config')]"
                },
                "p2SConnectionConfigurations": [
                    {
                        "name": "P2SConnectionConfigDefault",
                        "properties": {
                            "routingConfiguration": {
                                "associatedRouteTable": {
                                    "id": "[resourceId('Microsoft.Network/virtualHubs/hubRouteTables', parameters('vWanHubName'), 'defaultRouteTable')]"
                                },
                                "propagatedRouteTables": {
                                    "labels": [
                                        "default"
                                    ],
                                    "ids": [
                                        {
                                            "id": "[resourceId('Microsoft.Network/virtualHubs/hubRouteTables', parameters('vWanHubName'), 'defaultRouteTable')]"
                                        }
                                    ]
                                },
                                "vnetRoutes": {
                                    "staticRoutes": []
                                }
                            },
                            "vpnClientAddressPool": {
                                "addressPrefixes": [
                                    "<IP_ADDRESS>/24"
                                ]
                            }
                        }
                    }
                ],
                "vpnGatewayScaleUnit": 1,
                "customDnsServers": []
            }
        }

Using P2S VPN created above, I am trying to connect to a VM. VM resides in a VNET and has NSG configured as shown below.
{

            "type": "Microsoft.Network/networkSecurityGroups",
            "apiVersion": "2019-08-01",
            "name": "spoke-vnet3-subnet-nsg",
            "location": "[resourceGroup().location]",
            "properties": {
                "securityRules": [
                {
                    "name": "default-allow-3389",
                    "properties": {
                    "priority": 1000,
                    "access": "Allow",
                    "direction": "Inbound",
                    "destinationPortRange": "3389",
                    "protocol": "Tcp",
                    "sourceAddressPrefix": "*",
                    "sourcePortRange": "*",
                    "destinationAddressPrefix": "*"
                    }
                }
                ]
            }
        },
        {
            "apiVersion": "2020-05-01",
            "type": "Microsoft.Network/virtualNetworks",
            "name": "[parameters('spoke3VnetName')]",
            "location": "[resourceGroup().location]",
            "dependsOn": [
               "[resourceId('Microsoft.Network/networkSecurityGroups', 'spoke-vnet3-subnet-nsg')]"
            ],
            "properties": {
            "addressSpace": {
                "addressPrefixes": [
                "[parameters('spoke3VnetAddressPrefix')]"
                ]
            },
            "subnets": [
                {
                    "name": "default",
                    "properties": {
                        "addressPrefix": "[parameters('spoke3SubnetAddressPrefix')]",
                        "networkSecurityGroup": {
                            "id": "[resourceId('Microsoft.Network/networkSecurityGroups', 'spoke-vnet3-subnet-nsg')]"
                        }
                    }
                }
                ]
            }
        }

VM itself is created with following definition.
{
            "apiVersion": "2015-06-15",
            "type": "Microsoft.Network/networkInterfaces",
            "name": "[parameters('vm1-spoke3-nic')]",
            "location": "[resourceGroup().location]",
            "dependsOn": [
                "[concat('Microsoft.Network/virtualNetworks/', parameters('spoke3VnetName'))]"
            ],
            "properties": {
                "ipConfigurations": [
                    {
                        "name": "ipconfig1",
                        "properties": {
                            "privateIPAllocationMethod": "Dynamic",
                            "subnet": {
                                "id": "[variables('Spoke3VM1SubnetRef')]"
                            }
                        }
                    }
                ]
            }
        },
        {
            "apiVersion": "2017-03-30",
            "type": "Microsoft.Compute/virtualMachines",
            "name": "[parameters('spoke3Vm1Name')]",
            "location": "[resourceGroup().location]",
            "dependsOn": [
                "[concat('Microsoft.Storage/storageAccounts/', parameters('storageAccountName'))]",
                "[concat('Microsoft.Network/networkInterfaces/', parameters('vm1-spoke3-nic'))]"
            ],
            "properties": {
                "hardwareProfile": {
                "vmSize": "Standard_A2_v2"
                },
            "osProfile": {
                "computerName": "[parameters('spoke3Vm1Name')]",
                "adminUsername": "spoke3vm1-uid",
                "adminPassword": "<my-secret-password>"
            },
            "storageProfile": {
                "imageReference": {
                    "publisher": "MicrosoftWindowsServer",
                    "offer": "WindowsServer",
                    "sku": "2012-R2-Datacenter",
                    "version": "latest"
                },
                "osDisk": {
                    "name": "[concat(parameters('spoke3Vm1Name'),'_OSDisk')]",
                    "caching": "ReadWrite",
                    "createOption": "FromImage"
                    }
            },
            "networkProfile": {
                "networkInterfaces": [
                        {
                        "id": "[resourceId('Microsoft.Network/networkInterfaces', parameters('vm1-spoke3-nic'))]"
                        }
                    ]
                }
            }
        }

My VPN connectivity is established successfully with vWAN after downloading the VPN client from Azure portal. Destination VM and its VNET are also created successfully.
But when I try to RDP to VM using its private IP, the connection doesn't go though.
What am I missing?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cb0224af-2059-f88c-bb14-926ef69bd835
Version Independent ID: c8859d92-dced-ecaa-a409-7af3cc064187
Content: Use Azure Virtual WAN to create a Point-to-Site connection to Azure
Content Source: articles/virtual-wan/virtual-wan-point-to-site-portal.md
Service: virtual-wan
GitHub Login: @KumudD
Microsoft Alias: alzam

To start, I would check 2 things:

If you are using VNET Peering to connect the hub and spoke, make sure that Gateway Transit is set up properly in the peerings.

Check the routes on your P2S computer to make sure it includes route for the address space of the remote VNET.

If this is not included, you might have to manually add the route and send it over the P2S VPN

Thanks @TravisCragg-MSFT .
I am using VWAN Hub and not the conventional hub and spoke network topology.  I am trying to connect to VNET using VPN. There is no Peering involved.
On 2nd question, having a working example with routes configured for P2S in VWAN will be really helpful.
In this issue, I think I have changed routes but the issue still remains.

#please-close


Scripts for testing write speeds on S3

Writer
Mean
Std
Min
Max
Total

TileDBWriter
13.088
88.0435
2.64519
3273.67
3275.73

ZarrSingleArrayWriter
8.533
3.78341
1.62613
27.1178
2135.86

ZarrMultiArrayWriter
1.034
0.0889437
0.713099
1.70147
258.799

TileDBOneWriter
0.755
0.0946
0.508
1.7500
188.90

NumpyWriter
0.294
0.0597357
0.119953
0.80135
73.5781

Codecov Report
Patch and project coverage have no change.

Comparison is base (d8e7d7d) 51.03% compared to head (dcf0e01) 51.03%.
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   51.03%   51.03%
=======================================
  Files          30       30
  Lines        3656     3656
  Branches      502      502
=======================================
  Hits         1866     1866
  Misses       1732     1732
  Partials       58       58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Change NGC key retrieval method with env var and doc update for Custom Bundle

Hi @yiheng-wang-nv , could you please take a look if this will break any integration test? Thanks!


Build Script uses internal alias 'lsfilter'?

Hi,
I'm trying to build the dataset on Ubuntu, and the build.sh script is failing. It says that it cannot find the command lsfilter . Could it be that this is an alias for ls with certain flags that you are using locally?

Nevermind, it was an error in loading config.sh that caused it.


⚠ Bofrost.be has degraded performance

In faddfee, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2648 ms

Resolved: Bofrost.be performance has improved in 5f57d50.


Egui v0.23,chinese punctuation cannot be inputted by IME, but copy/paste does work.

Egui v0.23,chinese punctuation cannot be inputted by IME, but copy/paste does work.
Egui v0.22 works fine.
Screenshots

https://github.com/emilk/egui/assets/71546076/2e5d87da-5ead-4605-9eda-774830d4a25c
Desktop (please complete the following information):

OS: Win10 LTSC
Browser  Native
Version 0.23

为啥我中文显示都是方块
因为你没有设置中文字体。egui内置字体不包含中文。我给你个添加了中文字体的demo。下载编译就行。
https://delongnas.synology.me:5001/d/s/vyVrJcxssuZfzNS3Qh13kmTTjnec4b4Q/FutcXndK_u2tWCXIOv_3uj9pyorWkV3w-Q7sAWJhD5Ao

Have you tried a git bisect to find the cause of this? From the changelog there were two PRs affecting IME:

https://github.com/emilk/egui/pull/3362
https://github.com/emilk/egui/pull/3376

Have you tried a git bisect to find the cause of this? From the changelog there were two PRs affecting IME:
* [Only show on-screen-keyboard and IME when editing text #3362](https://github.com/emilk/egui/pull/3362)

* [Prevent text from being cleared when selected due to winit IME #3376](https://github.com/emilk/egui/pull/3376)

PS E:\myfile\src\rust\egui-hello_world_cn\egui> git bisect start 5f4046d68aa482167198d5fa3b8f506f04242014 ad8b41cad65c632a3a35edd0b3dd6d25f6f962a9
Bisecting: 21 revisions left to test after this (roughly 5 steps)
[cfbad1f8656f90f02336890bb9f9f323af506e25] Update example screenshots
PS E:\myfile\src\rust\egui-hello_world_cn\egui> git bisect bad
Bisecting: 10 revisions left to test after this (roughly 4 steps)
[1b830bbcb4c8bfbbd17233be5850cb41854b730b] Less loud warning when loading old memories
PS E:\myfile\src\rust\egui-hello_world_cn\egui> git bisect bad
Bisecting: 5 revisions left to test after this (roughly 3 steps)
[99a1b5b62e60b2a2b3cb5728cc57108669242855] Add `Context::open_url` and `Context::copy_text` (#3380)
PS E:\myfile\src\rust\egui-hello_world_cn\egui> git bisect bad
Bisecting: 2 revisions left to test after this (roughly 1 step)
[c07394b5766053fcdb5cb506e369f60a535a4800] Only show on-screen-keyboard and IME when editing text (#3362)
PS E:\myfile\src\rust\egui-hello_world_cn\egui> git bisect good
Bisecting: 0 revisions left to test after this (roughly 1 step)
[d77c44657206d6a5a9eda0d3b10fac6e189acc27] Prevent text from being cleared when selected due to winit IME (#3376)

Bug locate at  #3362.

The idea of https://github.com/emilk/egui/pull/3362 was the IME should be enabled once the user clicks a text edit box, but apparently something broke. Luckily it is a very small PR, so it should be easy to figure out a fix if someone wants to work on it!

most likely fixed by https://github.com/emilk/egui/pull/4436


Feature: Option to specify the gender of the author

This would be useful since the male form of Kontoinhaberin is Kontoinhaber.
For example, we could add the boolean field female to author. If it is not set, it is set to true.

Would be good to have more flexibility in the future, but I think for now that would be sufficient.

I went with an interface that's a bit more complex, but is hopefully future proof


Is it possible to peer eureka over https

Hi,
Is it possible to peer eureka nodes over https?
I have 2 eureka nodes deployed in different hosts .
I see that they are registered to each other .
My micorservice  has Node 1 in the configuration and registered successfully to Node1
But Node 1 is not syncing the microservice status to the peer node Node2
Same works well with HTTP
In the logs i see "bad certificate" error.
So , it even possible to peer eureka nodes over https? Or Could it be an issue with my certificates?

It is possible. You need to either install the certificates in the jvm (easier, but environment specifc), or configure them in the jersey client used to peer (harder, but not env specific). I've not done it before, but may someone from @csterwa's team has done it?

Hello @asharani-m, there are two options that we have implemented for peer replication across foundations. The first of these is what we suggest:

Add the CA certs for both foundations to Java truststore for each. This should allow each side to validate the SSL certificate  without error. Here is an article on doing this:

https://medium.com/@codebyamir/the-java-developers-guide-to-ssl-certificates-b78142b3a0fc

This is not what we suggest but it is a way to make it work. You can write a certificate truster that will make it so SSL connections are not validated and you'll trust whatever cert comes through. This is not much better than using HTTP in the end and that is why we don't suggest it as a solution.

There is an implementation of this but as it says on that README it is highly discouraged.
https://github.com/pivotal-cf/cloudfoundry-certificate-truster
Hope this helps.

@spencergibb  / @csterwa Thank you for your response.
@csterwa I tried you suggestion , i get below
Warning: no suitable certificate found - continuing without client authentication
Steps i followed:

Create cert for Eureka Node 1  in host1- E1
Create cert for Eureka Node 2 in host2- E2
Create cert for Microservice in host2 - M2
Import E1 to keystore of Eureka Node 2
Import E2 to keystore of Eureka Node 1
Import M2 to keystore of Eureka Node 2, I am registering M1 to E2
I mention the trust store and keystore location while starting application (via -Djavax.net.ssl*)

I tried mutliple times , not able to figure out the issue.
This could be a question w.r.t certificated.
Any heads up is really appreciated
Thanks

@csterwa
I progress a little on this,
When Eureka Node (E1) and Eureka node(E2) are started.
I see SSL hand shake happening between nodes successfully .
When  i bring up microserve M2 , which is successfully registered to E2. E2 tries to sync with E1 about status of M2.
During this SSL handshake between E1 and E2 does not work as expected .
I get below error
Cert Authorities:
**<CN=serviceqaauth, OU=ib, O=ubs, L=ld, ST=uk, C=uk>
*** ServerHelloDone
Warning: no suitable certificate found - continuing without client authentication
*** Certificate chain

I have added the E1 cert to trust store of E2.

@csterwa
I progressed a little on this,
When Eureka Node (E1) and Eureka node(E2) are started.
I see SSL hand shake happening between nodes successfully .
Cert Authorities:
<CN=eurekaqaauth, OU=ib, O=ubs, L=ld, ST=uk, C=uk> *** ServerHelloDone matching alias: eurekaqa *** Certificate chain
When i bring up microserve M2 , which is successfully registered to E2. E2 tries to sync with E1 about status of M2.
During this SSL handshake between E1 and E2 , I see below error
Cert Authorities:
<CN=eurekaqaauth, OU=ib, O=ubs, L=ld, ST=uk, C=uk> *** ServerHelloDone Warning: no suitable certificate found - continuing without client authentication *** Certificate chain *****
I have added the E1 cert to trust store of E2.

I currently experience similar issue, We have two separate eureka nodes (different EC2's) with their certificates imported into the machine jvm, other services can successfully send heart bit to eureka but replication between eureka nodes fails with bad_certificate

@csterwa
I progressed a little on this,
When Eureka Node (E1) and Eureka node(E2) are started.
I see SSL hand shake happening between nodes successfully .
Cert Authorities:
<CN=eurekaqaauth, OU=ib, O=ubs, L=ld, ST=uk, C=uk> *** ServerHelloDone matching alias: eurekaqa *** Certificate chain
When i bring up microserve M2 , which is successfully registered to E2. E2 tries to sync with E1 about status of M2.
During this SSL handshake between E1 and E2 , I see below error
Cert Authorities:
<CN=eurekaqaauth, OU=ib, O=ubs, L=ld, ST=uk, C=uk> *** ServerHelloDone Warning: no suitable certificate found - continuing without client authentication *** Certificate chain *****
I have added the E1 cert to trust store of E2.

I currently experience similar issue, We have two separate eureka nodes (different EC2's) with their certificates imported into the machine jvm, other services can successfully send heart bit to eureka but replication between eureka nodes fails with bad_certificate

@Sinisterish  I could not resolve this yet.

Hello @asharani-m, there are two steps where I think the wrong cert was imported into the Java truststore. Instead of the generated cert being imported into the Java truststore, the Certificate Authority (CA) cert that was used to generate the certificate should be imported into the other Java truststore. The idea is that it is made available to validate the cert during the handshake. I think this may be the issue. Can you try this and let us know if that is the case?

@csterwa I used self signed certificate.
What is "the Certificate Authority (CA) cert that was used to generate the certificate" in this case?

@asharani-m I see. This changes everything. I had thought you were using a generated certificate from a trusted Certificate Authority. Self-signed certificates are less secure since they are not validated with a third party CA.
For a self-signed certificate, there is a need to add the trusted cert to the truststore of the JVM. Here is a sample of how to add it each certificate to the truststore of the other side's JVM:
https://stackoverflow.com/questions/2893819/accept-servers-self-signed-ssl-certificate-in-java-client

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.


error

"E:\Program Files\pythonProject6\venv\Scripts\python.exe" "E:/Program Files/pythonProject6/east/east.py"
Traceback (most recent call last):
File "E:/Program Files/pythonProject6/east/east.py", line 27, in
orig = image.copy()
AttributeError: 'NoneType' object has no attribute 'copy'

ur image not loaded yet, pls ensure ur image path is correct

usage: ipykernel_launcher.py [-h] [-i IMAGE] [-east EAST] [-c MIN_CONFIDENCE]
[-w WIDTH] [-e HEIGHT]
ipykernel_launcher.py: error: unrecognized arguments: -f /root/.local/share/jupyter/runtime/kernel-31c4f26b-bfc4-491a-bdfc-a33144085bd2.json
An exception has occurred, use %tb to see the full traceback.

import sys; sys.argv=['']; del sys
before parser.parse_args()

usage: ipykernel_launcher.py [-h] [-i IMAGE] [-east EAST] [-c MIN_CONFIDENCE]
[-w WIDTH] [-e HEIGHT]
ipykernel_launcher.py: error: unrecognized arguments: -f /root/.local/share/jupyter/runtime/kernel-31c4f26b-bfc4-491a-bdfc-a33144085bd2.json
An exception has occurred, use %tb to see the full traceback.

ur image not loaded yet, pls ensure ur image path is correct

I have the same path but i didnt put a path yet so it is kindof confusing


Doesn't allows to create project of newly created service.

Describe the bug

Created New service.
Then tried to Create project of it from projects page and Project Import page.

Screenshots
Project Page

Project Import Page

Team Page

Not able to reproduce

Whenever new staff pr Service is created then it requires to be added into team. And system assigns/makes changes in teams, on page load event of Team page. So, temporary solution is that, whenever new service or user has been created then user has to open team page. #518


refactor: review the home page && completion the language && move the body css into the varlet-site className

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information
review the home page && completion the language && move the body css into the varlet-site className

Codecov Report

Merging #413 (b087024) into feat/home-page (432aa88) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           feat/home-page     #413   +/-   ##
===============================================
  Coverage           96.49%   96.49%
===============================================
  Files                 217      217
  Lines                5114     5114
  Branches              978      978
===============================================
  Hits                 4935     4935
  Misses                175      175
  Partials                4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432aa88...b087024. Read the comment docs.


pango: 1.43.0 -> 1.44.6, fixes CVE-2019-1010238

Motivation for this change
Bumping version to incorporate a security fix.
Addresses: https://github.com/NixOS/nixpkgs/issues/70120
Upstream fix:
https://gitlab.gnome.org/GNOME/pango/commit/490f8979a260c16b1df055eab386345da18a2d54
Additional change required to build docs:
https://gitlab.gnome.org/GNOME/pango/commit/71461689b0e34d873018d46bff555475019fbf4a
The dropped patch is already incorporated into the version.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @7c6f434c

Previous patch releases had some breakage, we need to check if they were fixed. See also ttps://github.com/NixOS/nixpkgs/pull/65670

@jtojnar: Thanks, I will have a look.

I believe the issue was with pygtk https://github.com/NixOS/nixpkgs/pull/65670#issuecomment-533828520. So maybe you just need to give it some extra cflags to build now.

@worldofpeace: It doesn't seem like there is a 1.44.6-2 source tarball published on the regular mirrors yet, but I will try out and see if we can backport this as a patch.

From IRC:

sender
message

alatiera
mclasen: you did a 1.44.6-2 tag but didn't upload a tarball

bochecha
yeah, with a signle commit adding back PangoFontsetSimple

mclasen
alatiera: I believe that is the 1.44.6 tag

and there is a 1.44.6 tarball on d.g.o

alatiera
mclasen: the tarball is from first tag, we double checked it over the weekend

mclasen
alright, I'll try to get some pango time this week

alatiera
we could also include this one patch in the flatpak sdk till a .7 tag is around, from the issue it seems that the api is used by pygtk mostly

https://gitlab.gnome.org/GNOME/pango/compare/1.44.6...1.44.6-2
That should work for us. Could you try adding https://gitlab.gnome.org/GNOME/pango/commit/8a408d4f25ddb0e3d6020cdde0cd8f8a19ee8db2.patch to patches?

@jtojnar: Yes, this is the patch I was trying. While this solves the immediate error, it runs into another deprecated and removed API further down the line in:
pango.c:3822:32: error: ‘PangoFontClass’ {aka ‘struct _PangoFontClass’} has no member named ‘find_shaper’
     if (PANGO_FONT_CLASS(klass)->find_shaper)
                                ^~
pango.c:3823:38: error: ‘PangoFontClass’ {aka ‘struct _PangoFontClass’} has no member named ‘find_shaper’
         ret = PANGO_FONT_CLASS(klass)->find_shaper(PANGO_FONT(self->obj), lang, ch);

Let me push an updated version so that it can be tested via ofBorg.

Ouch, sorry, didn't notice the first time that the updated version is still not enough. Should I revert?

Hm, pygtk doesn't build indeed, with the same problem

https://gitlab.gnome.org/GNOME/pango/commit/48c5b52c944be0083a6c35caea86d186175b1640 is where find_shaper was dropped, reason unclear

The reason is upstream is trying to prune deprecated APIs. Unfortunately, pygtk is still reaching at us from its grave. On #gnome-hackers channel, there was some talk about post-mortem rejuvenation for pygtk.

I arrived at similar conclusions. I assune nobody feels overly enthusiastic about patching pango or being stuck witj an old version for all nixpkgs. should we consider splitting out a legacy version for pygtk and the possibly other cases until maybe sth moves upstream?
@7c6f434c: I think we probably should revert if we dont want to propagate all that pygtk breakage.

I am kind of afraid pygtk-using apps are also vulnerable to that invalid-UTF8-from-untrusted source CVE… Maybe apply the reverse of the find_shaper removal commit as a patch?

The reason is upstream is trying to prune deprecated APIs. Unfortunately, pygtk is still reaching at us from its grave. On #gnome-hackers channel, there was someone volunteering to perform post-mortem rejuvenation for pygtk. Until then, reverting the removal commit sounds good.

Agreed on ideally not having pygtk being vulnerable. I can try to patch that part up in a few hours but Id be a but worried that this could lead a but deeper than just this particular commit. From cursory glances yesterday it looked they like have been ditching a few things.

I guess another option is to try applying the CVE patch to 1.43?

I can try both avenues and test against pygtk and report back.

Alright, the backport of the CVE patch seems to work well and requires less fiddling than the reverts. I will open a PR just for this particular aspect. What do you think of making an additional PR bringing back a newer pango version, moving fixed-up 1.43.0 to a versioned attribute, attaching it to pygtk only for now and seeing if we can keep most of the software on the most recent pango until the pygtk saga resolves itself?


Suppress exceptions that occur when reading properties

A simple fix for #97 .

要写个test case~保证覆盖率。同时避免regression。

Codecov Report
Patch coverage: 50.00% and project coverage change: -1.58% :warning:

Comparison is base (096bc73) 100.00% compared to head (6c15849) 98.42%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #98      +/-   ##
===========================================
- Coverage   100.00%   98.42%   -1.58%
===========================================
  Files            5        5
  Lines          378      381       +3
===========================================
- Hits           378      375       -3
- Misses           0        6       +6

Files Changed
Coverage Δ

src/objprint/objprint.py
99.20% <50.00%> (-0.80%)
:arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

简单写了一个测试，天哥看看可以吗


Fix linting wCCD example

Purpose
fix linting in wCCD example
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

This should not be necessary. In the 1.0.0 version of the api-helpers (Which I have just released today)the parameter is removed from the payload's type.
(I set the job on main to re-run, to confirm this)


feat-syncing-node: Node Syncing POC, version 0 - works

, tested in small groups of 20-30 containers, still requires cleaning - POC alike code.
All the unwraps and commented out code removed.
Contains also the "feat-peer-connection-maintenance: POC, version 3, slimmed down to remove libp2p dependency" with requested corrections : https://github.com/vrrb-io/vrrb/pull/73

@vrrbmk There's a tiny bit of cleanup left. There were a handful+ of //TODO comments remaining, if these are complete, please remove them... Some of them had action items such as //TODO: fix compiler, if you could elaborate on this further, that'd be helpful, or if it's completed please remove the comment as to not confuse anyone in the future (or yourself) wrt future work that needs to be done, a number of the //TODO comments were blank, if there is indeed something TODO that is not within the scope of this PR, please create tickets for those action items and remove the comments. If there is not, then please remove the comments.
There were also a handful+ allow macros in the code, if these have been cleaned up and there is no leftover dead_code or anything of the sort that needs to be allowed to silence compiler warnings, then please remove those macros, if there is, and it is necessary, please document/comment why so, and if they are no longer necessary, then remove the instances of unused and dead code, if there are certain functions/methods not used within the crate, but that intend on being exported, that is ok, but let's remove the allow macros from this PR.

The current version of the Rust compiler cannot figure out that the variables and structs being used in an another tokio thread - and marks them wrongly as unused. So to get it compiled I had to mark some structs as "allow_dead_code".
I think it was  working in previous Rust versions.
Without those allows - half of the code gets marked as "unused". It looks bad, like warnings all around the place - so I've added those "allow + TODO" comments.
That's to remember about monitoring the situation and remove them ASAP, once the compiler gets fixed.


Go to anchor of Giscus form after login to Github

On a first visit to a Giscus instance I am presented with a login button for Github. Clicking it I am redirected to Github to login or automatically redirected twice to Github and back to the page. But the redirect ends me up at the top of the page, not the location of the giscus form. Is there a way to redirect to the form instead using an anchor?

Implemented in #439.
You can do so by adding an id to the element that has the giscus class, e.g.


hide_pages failed when switch to another visiable page

The hide_pages works well when loading the main page (showing visable pages and hiding the target page). But when switched to a visiable page other than the main page, the page link of a hidden page appears.

hide_pages is purely done by css, so it needs to be done on every page that you want to hide page on


Webpack do not work for "this.constructor = d;"

From @ignaciolarranaga on September 4, 2016 21:9
For example it does not work for the geolocation module, because of this code (extracted from the bundled code):
!*** ../~/nativescript-geolocation/nativescript-geolocation.ios.js ***!
  \*********************************************************************/
/***/ function(module, exports, __webpack_require__) {

	"use strict";
	var __extends = (this && this.__extends) || function (d, b) {
	    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
	    function __() { this.constructor = d; }
	    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
	};

At runtime it throws:
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: 1   0x108ff4c67 -[TNSRuntime executeModule:]
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: 2   0x106194322 main
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: 3   0x10bb6e92d start
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: 4   0x1
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: file:///app/bundle.js:145226:26: JS ERROR TypeError: Attempted to assign to readonly property.
Sep  4 18:04:19 MacBook-Pro-de-Ignacio com.apple.CoreSimulator.SimDevice.00A4117D-42D7-4D34-A741-4D4FAA4286CD.launchd_sim[96565] (UIKitApplication:com.gynto.client[0x5ed0][51653]): Service exited due to signal: Segmentation fault: 11

This is just an example, but also happen to me on other modules. The only pattern I was able to found is that happends at: function __() { this.constructor = d; }
Copied from original issue: NativeScript/nativescript-dev-webpack#16

I think the iOS runtime has issues with code using the "use strict" declaration. I think nativescript-geolocation has to be compiled without that.

Fixed in<EMAIL_ADDRESS>


Add debugger query parameter to devtools, disables debugger when set to false

Fixes # [insert GH or internal issue number(s)].
Author has included the following, where applicable:

[ ] Tests
[ ] Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

Checked for inclusion of relevant tests
Checked for inclusion of a relevant changeset
Checked for creation of associated docs updates
Manually pulled down the changes and spot-tested

Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

Closing for https://github.com/cloudflare/workers-sdk/pull/3787


Migrate Irony.GrammarExplorer to net 6.0

PR Details
Description
The Grammar Explorer allows developers to test, e.g how Stride Shader syntax (SDSL) works. This tool
has been ported to net 6. I also added latest few fixes from codeplex's Irony repository, since it was impossible to load the grammar.

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thanks !


zsh option 'noclobber' prevents autoupdate log from being updated

__zgenom_autoupdate_log:7: file exists: /home/henk/.zgenom/.last_autoupdate_log

AFAIK this might be caused by zsh’s noclobber option being set.
zgenom might have to unset that when it tries to overwrite the logfile.

Should be fixed now, @henk84.
Thanks for reporting 👍


SSU-4: Create input component

JIRA TASK: https://cheesecakelabs.atlassian.net/jira/software/c/projects/SSU/boards/414?modal=detail&selectedIssue=SSU-4
https://user-images.githubusercontent.com/13142876/186675025-0090edb7-095e-4f40-9c51-811ae7dc66d8.mov

I think you versioned your node_modules by mistake 👀


[TypeSpec APIView] ExternalError: Emitter "@azure-tools/typespec-apiview" failed

tsp compile . --options arm-types-path=../../../../../../common-types/resource-management
TypeSpec compiler v0.41.0
ExternalError: Emitter "@azure-tools/typespec-apiview" failed!
File issue at https://github.com/Azure/azure-sdk-tools/issues
Error: Unable to get name for node.
    at ApiView.getNameForNode (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@azure-tools/typespec-apiview/dist/src/apiview.js:878:19)
    at ApiView.tokenizeEnumStatement (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@azure-tools/typespec-apiview/dist/src/apiview.js:570:37)
    at ApiView.tokenize (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@azure-tools/typespec-apiview/dist/src/apiview.js:354:22)
    at ApiView.tokenizeNamespaceModel (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@azure-tools/typespec-apiview/dist/src/apiview.js:732:18)
    at ApiView.emit (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@azure-tools/typespec-apiview/dist/src/apiview.js:248:22)
    at Object.emitApiView (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@azure-tools/typespec-apiview/dist/src/emitter.js:159:21)
    at Object.$onEmit [as emitFunction] (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@azure-tools/typespec-apiview/dist/src/emitter.js:9:19)
    at runEmitter (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@typespec/compiler/dist/core/program.js:526:27)
    at compile (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@typespec/compiler/dist/core/program.js:238:15)
    at async Object.handler (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@typespec/compiler/dist/core/cli/cli.js:114:25)
    at runEmitter (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@typespec/compiler/dist/core/program.js:543:19)
    at async compile (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@typespec/compiler/dist/core/program.js:238:9)
    at async Object.handler (file:///home/stephane/code/aks-rp/swagger/containerservice/fleets.management/node_modules/@typespec/compiler/dist/core/cli/cli.js:114:25)

the tsp files i ran it on to test are the ones from this PR:
https://github.com/Azure/azure-rest-api-specs-pr/pull/11615/files#diff-52d57fc73af08f92895030a57d5e6201d952cff7109eafec2ed67dba6e2ec603R42

@serbrech what dependencies are you using? When I try and follow your repro I get 250 errors just in compilation--before it even gets to APIView.
Where is your package.json?

There are more dependencies than the typespec compiler. Looking at the enums in your spec the only thing that stands out is where you have an enum that just uses the spread operator. I'll take a look and see if that causes an issue.


WIP: zephyr: added initial support to Zephyr RTOS as host OS.

By submiting this PR, you agree with the associated license (Apache 2.0 or MIT) and with our Contributor License Agreement (CLA).
Before to begin
Thank you for contributing to the Luos project!
Before to begin, please follow these steps:

[x] Ensure that this PR is not a duplicate.
[x] Assign @Simonbdy to this PR
[x] Add the PR to the Luos contribution project

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.
PR Description section
Description and dependencies
This PR enables Luos to be built on top of Zephyr RTOS, as a result Luos is seen by Zephyr as an out-of-tree module, and a Zephyr application is able to include Luos and its features. It also brings zephyr specific code to the HAL and Robus/HAL sections enabling Luos on Zephyr supported boards.
Changes
Please choose the relevant options:

[x] New feature (non-breaking change which adds functionality)

WARNING: Do not edit the checklist below.

Developer section

[ ] [Documentation] is up to date with new feature
[ ] [Tests] are passed OK (non regression, new features & bug fixes)
[ ] [Code Quality] please check if:

Each function has a header (description, inputs, outputs)
Code is commented (particularly in hard to understand areas)
There are no new warnings that can be corrected
Commits policy is respected (constitancy commits, clear commits comments)

QA section

[ ] [Review] tests for new features have been reviewed
[ ] [Changelog] is up-to-date with expected tags
🆕 Feature: [Feature] Description...
🆕 Added: [Feature] Description...
🆕 Changed: [Feature] Description...
🛠 Fix: [Feature] Description...

@Simonbdy , @nicolas-rabault  PTAL it is on WIP state but since this touches in some of the common folders from Luos I would like to hear your options while I finish the Zephyr specific code.
The current state of this PR it is able to build and run on qemu zephyr target, but the final PR would add some boards.

Please refer the sample code below:
https://github.com/uLipe/luos_engine/tree/feature/luos_zephyr/examples/projects/zephyr

@Simonbdy, @JeromeGalan is working on it with @uLipe , I think @JeromeGalan will be more relevant than me about it.

Hi folks, it has been a while, just to update you I'm still working on this PR, probably will update things here at the end of this week.
cc: @Simonbdy @nicolas-rabault

Added initial port of robus hal, it still needs to finish the uart part, it just to you follow-up the progress.

cc: @JeromeGalan . @nicolas-rabault

Added the missing timeout functions, and now tested with high baud rate > 400k

👨💻👍
On Tue, 3 Jan 2023, 2:52 pm Nicolas Rabault, @.***>
wrote:

@.**** commented on this pull request.
In network/robus/HAL/zephyr/robus_hal.c
https://github.com/Luos-io/luos_engine/pull/398#discussion_r1060395959:

{

   uint8_t c;

   if(ring_buf_is_empty(&out_ringbuf))

   {

       uart_irq_tx_disable(luos_serial);

       RobusHAL_SetTxState(false);

   }

   else

   {

       RobusHAL_ResetTimeout(0);

       ring_buf_get(&out_ringbuf, &c, 1);

       uart_fifo_fill(luos_serial, &c, 1);

       LOG_DBG("Transmitting the following byte from serial 0x%x", c);

   }

   k_sem_give(&net_activity_sem);

If I understand it, you use it to trigger the Luos_loop task.
Here is a few thought about running Luos_loop like that.
We will need a deeper check, but I think:

Luos_loop don't need to do anything in case of TX.
Luos_loop need to run only one time per complete message (but you
can't manage it at HAL level, that is why a macro is interesting here)
Luos_loop check time during execution to trigger auto-update
messages. We have to find a way to avoid this polling strategy to be able
to male it completely event driven.

—
Reply to this email directly, view it on GitHub
https://github.com/Luos-io/luos_engine/pull/398#pullrequestreview-1234265820,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4522T73XIUWUX6LEGVXAKTWQPVTRANCNFSM6AAAAAARYUD4TY
.
You are receiving this because you commented.Message ID:
@.***>

Just rebased

Hi Folks, sorry for the long hiatus here, I got some hard times in my work, with almost no time for my open source stuff.
Once I find a proper timeslot I will finish this one.


Run Devfile personalization in interactive mode from empty directory

Signed-off-by: anandrkskd<EMAIL_ADDRESS>What type of PR is this:
/kind bug
What does this PR do / why we need it:
This PR adds the ability to personalization devfile when running  odo init in interactive mode from an empty directory
Which issue(s) this PR fixes:
Fixes #6313
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:
mkdir /tmp/testodo; cd /tmp/testodo
 odo init
  __
 /  \__     Initializing a new component
 \__/  \    Files: No source code detected, a starter project will be created in the current directory
 /  \__/    odo version: v3.3.0
 \__/

Interactive mode enabled, please answer the following questions:
? Select language: Go
? Select project type: Go Runtime
 ✓  Downloading devfile "go" from registry "DefaultDevfileRegistry" [2s]

↪ Container Configuration "runtime":
  OPEN PORTS:
    - 8080
  ENVIRONMENT VARIABLES:

? Select container for which you want to change configuration? NONE - configuration is correct
? Which starter project do you want to use? go-starter
? Enter component name: test
 ✓  Downloading starter project "go-starter" [733ms]

Port configuration using flag is currently not supported

You can automate this command by executing:
   odo init --name test --devfile go --devfile-registry DefaultDevfileRegistry --starter go-starter

Your new component 'test' is ready in the current directory.
To start editing your component, use 'odo dev' and open this folder in your favorite IDE.
Changes will be directly reflected on the cluster.

@rm3l I believe this might slightly affect your work on #5863. I remember we discussed something about port detection when the directory is empty, but I can't recall the exact thing.

@rm3l I believe this might slightly affect your work on #5863. I remember we discussed something about port detection when the directory is empty, but I can't recall the exact thing.

Indeed, we discussed this point. But I think #5863 should not be affected by this PR.
When the directory is empty, the interactive mode of odo init actually won't be affected by port detection (relevant only where there is source code, or later when running non-interactively with a --port flag, but that's a separate issue).

/override ci/prow/v4.11-integration-e2e
Flay e2e test failing
Pass on IBM Cloud

/override ci/prow/v4.11-integration-e2e
Infra error
Pass on IBM Cloud


Only show go_version segment if inside GOPATH

As of Go v1.8 GOPATH need not be set, as it will default to $HOME/go. By using go env GOPATH to retrieve the value first, this technique will work regardless of whether GOPATH is currently set by the user.

Thanks for the PR, @zikes! It looks like this PR is failing CI tests with:
$ test/segments/go_version.spec

testGo
ASSERT:expected:<%K{green} %F{255}go1.5.3 %k%F{green}%f > but was:<%k%F{NONE}%f >
testGoSegmentPrintsNothingIfGoIsNotAvailable
prompt_go_version:4: command not found: noGo

Ran 2 tests.

FAILED (failures=1)
The command "test/segments/go_version.spec" exited with 1.

So, the test that is failing is supposed to not be able to find Go and then confirm that the Go segment is not, in fact, printed. It's failing because something is in fact printed. I'm not familiar with Go myself, but based on @zikes' description of the change, perhaps this is expected.
@dritter - Is this a case of the test needing to be updated or this change doing something unexpected?

I would say both. 😉
testGoSegmentPrintsNothingIfGoIsNotAvailable sets an alias to an unknown function (noGo) and assures that nothing is printed. The new query of the GOPATH does not redirect STDERR, which is why this fails (an error is printed).
And the assertion for testGo fails, because there is nothing printed, where it should..

Looks like there is a minor question of handling GOPATH, per the comment thread in your recent changes. As soon as we know that out, I'm happy to merge :)

I don't want to lose track of this one, as I think @zikes has some really good improvements here. I'd love to get this merged ASAP now that v0.6.3 is out.
I'm actually having a bit of trouble following the review / changelog, here, on Github. @dritter, it looks like you requested changes, @zikes made changes, and then you have not yet re-reviewed. Is that correct?

That is correct @bhilburn . Apologies for the late review @zikes , I lost this one out of sight.
Reviewing now.

Fantastic! Thanks so much for the PR, @zikes! Welcome to P9k, and thanks for a great contribution =)


Add a missing import for the turtle namespace

thanks for the feedback, i updated the readme in the release i just committed.


No internet access on the server running docker containers

Issue Description:
I have a ubuntu server and i want to access it from outside my lan and i can't use ssh because i can't configure port forwarding so i want to use teamviewer but there is no internet access on the server but pinging <IP_ADDRESS> works flawlessly
Docker Run Command:
sudo docker run --restart unless-stopped -d --name steam-cache -p <IP_ADDRESS>:80:80 steamcache/generic:latest

sudo docker run --restart unless-stopped -d --name steamcache-dns -p <IP_ADDRESS>:53:53/udp -e STEAMCACHE_IP=<IP_ADDRESS> steamcache/steamcache-dns:latest

I'm not sure if steamcache/steamcache-dns or steamcache/generic is causing this.

hey, first of all you should run sniproxy too :
sudo docker run --name prox --restart=always -d -p 443:443 steamcache/sniproxy:latest
(for HTTPS requests)
secondly i am pretty sure its an IP issue or a Mikrotik Issue . try setting a manual DNS server <IP_ADDRESS> or <IP_ADDRESS> from the ubuntu network settings, if it doesn't work you probably need to check ur router/mikrotik configuration maybe some firewall rules, mangle rules..
and finally make sure u are running the latest updates for ubuntu :
sudo apt-get update
sudo apt-get upgrade

@sta3b thanks for offering to help with this, but please keep people in the issues so that we can provide official support if required


Transformer Factory getBinding() made public?

I have registered bindings for Model -> Transformers which is obviously a neat key value array of which transformers to use with which model.
However, methods collection() and item() in  Dingo\Api\Http\Response\Factory (via the Dingo\Api\Routing\Helpers trait) have prototypes such as
public function collection(Collection $collection, $transformer, array $parameters = [], Closure $after = null)

with suggested usage
return $this->collection($users, new UserTransformer);

But given I have a neat mapping of models to transformers surely it'd be nice if

potentially the method could determine the transformer if $transformer is omitted

potentially we could do something like
 return $this->collection($users, app('api.transformer')->getBinding($users));

The downside of 2. is such that Dingo\Api\Transformer\Factory->getBinding() is protected and therefore can't be used this way.

Is there a more sensible way of achieving this or could we make getBinding() public?

If you've registered the bindings with the transformer factory then you can just go right ahead and return the collections instead of using the $this->collection method (same with singular items).
It'll get matched with its binding automatically so you don't need to worry about it.
If you need more control over the response then just new up a response instance.
public function index()
{
    return new Dingo\Api\Http\Response(App\User::all(), 201);
}

Don't ask me why you'd return a 201 Created in this instance but it's just an example. If I had the following binding:
app('api.transformer')->register(App\User::class, UserTransformer::class);

Then it would automatically be applied to the response.

Ok, that makes sense, but can you suggest how I might apply the same logic to automatically eager loaded included resources?
Take the following abridged part of a Fractal transformer, extending Fractal\TransformerAbstract
/**
 * Include Applications
 *
 * @return League\Fractal\CollectionResource
 */
public function includeApplications(User $user)
{
    $applications = $user->applications;

    return $this->collection($applications, new ApplicationTransformer, 'applications');
}

Having registered the following binding
app('api.transformer')->register(App\Application::class, ApplicationTransformer::class, ['key' => 'applications']);

In theory I should be able to
return $this->collection($applications);

Or at least get the binding back from the app('api.transformer') to do this for me.


Empty Results

Thank you for open-sourcing this package! I was wondering if the following behavior is expected when running metacrafter scan-file --format short world+City.csv :

Processing file /data/bird_sql/train_csv/world+City.csv
2024-07-03 02:21:56,613 - root - DEBUG - Start processing None
2024-07-03 02:21:56,632 - root - DEBUG - Processing 1000 records of None
2024-07-03 02:21:56,651 - root - DEBUG - Processing 2000 records of None
2024-07-03 02:21:56,670 - root - DEBUG - Processing 3000 records of None
2024-07-03 02:21:56,689 - root - DEBUG - Processing 4000 records of None
No results

The top-5 rows of the csv file are:

ID,Name,CountryCode,District,Population
1,Kabul,AFG,Kabol,1780000
2,Qandahar,AFG,Qandahar,237500
3,Herat,AFG,Herat,186800
4,Mazar-e-Sharif,AFG,Balkh,127800

I was expecting the CountryCode column will be recognized by metacrafter. Is there anything I am missing or did wrong?
By the way, I found the message "Start processing None" is confusing, which is attributed to this line of setting fromfile to None. Probably these debug messages can be improved to be more informative.

@superctj it happend since by some reason identification rules not installed with the package. Rules are YAML files that loaded during tool launch.
Still metacrafter uses file .metacrafter to find rules if they are not in package dir. You could configure to the rules path in repository https://github.com/apicrafter/metacrafter
For example my .metacrafter file looks like
`
rulepath:

/home/ibegtin/reps/metacrafter/rules
/home/ibegtin/reps/metacrafter-rules/rules
`
and it's located in the home dir.

Send rule path is to the metacrafter-rulesrepository https://github.com/apicrafter/metacrafter-rules
It's not yet python package and you need to install it seperately with python setup.py installcommand since some rules use addition python code.
Final result with CSV file from these top-5 rows should look like this

I will take a look deeper why rules were not installed and probably switch to updating rules from repository automatically on first launch.
About debug messages, sure you right, it should be more polished. I will take a look too

Thank you @ivbeg for the quick response! Looking forward to the new release of the package

Hi @ivbeg am reaching out for help. I was facing same issue as what @superctj  was facing and I followed the recommendation provided by you. Adding the first rule path is working fine whereas when I added second rule path https://github.com/apicrafter/metacrafter-rules  gave following error:

ModuleNotFoundError: No module named 'metacrafterext'

I did follow the installation instructions by cloning metacrafter-rules repository and running python3 setup.py install which is producing following error:

AttributeError: 'function' object has no attribute 'endswith'

Following is the csv file that I am trying to analyze:

Following is the .metacrafter file:

When am not adding - /home/moon-walker/Learning/metacrafter-rules/rules in .metacrafter this is the output from the library:

Here it's not detecting First Name and Last Name.
@ivbeg  could you please help me resolve this issue?
Thanks in advance.

@NoelToy Hi! Thanks, that's my mistake. I didn't verified package installation and now fixed it. Package installation of the metacrafter-rules should work now. After it's installation rules should work well.
I've updated rules also to support "First Name" and "Last Name" rules, they are not very common field names
These are the results

for this test file

@ivbeg Thanks alot for quick reply and for resolving the issue. Let me re-install metacrafter-rules and try it once.


安全(security)支持

Use argon2 impl 2 functions.
Set features security and use make_password and verify_password


Problem to start gvmd in script ubuntu_22.4.0.sh

Hi,
I followed the script for installation but it is giving an error to start the gmvd service.
Below the captured log:
root@openvas:~ tail -n 20 /var/log/gvm/gvmd.log
md manage:WARNING:2022-08-02 12h38.00 utc:20526: sql_exec_internal: SQL: SELECT value FROM public.meta WHERE name = 'database_version';
md manage:WARNING:2022-08-02 12h38.00 utc:20526: sql_x: sql_exec_internal failed
md manage:MESSAGE:2022-08-02 12h38.00 utc:20526: No SCAP database found
md manage:MESSAGE:2022-08-02 12h38.00 utc:20526: No CERT database found
md manage:MESSAGE:2022-08-02 12h38.00 utc:20526: db_extension_available: Extension 'pg-gvm' is not available.
md manage:WARNING:2022-08-02 12h38.00 utc:20526: check_db_extensions: A required extension is not available.
md manage:WARNING:2022-08-02 12h38.00 utc:20526: init_manage_create_functions: failed to create functions
md   main:MESSAGE:2022-08-02 12h39.31 utc:20536:    Greenbone Vulnerability Manager version 22.4.0~dev1 (DB revision 250)
md manage:WARNING:2022-08-02 12h39.31 utc:20537: sql_exec_internal: PQexec failed: ERROR:  relation "public.meta" does not exist
LINE 1: SELECT value FROM public.meta WHERE name = 'database_version...
md manage:WARNING:2022-08-02 12h39.31 utc:20537: sql_exec_internal: SQL: SELECT value FROM public.meta WHERE name = 'database_version';
md manage:WARNING:2022-08-02 12h39.31 utc:20537: sql_x: sql_exec_internal failed
md manage:MESSAGE:2022-08-02 12h39.31 utc:20537: No SCAP database found
md manage:MESSAGE:2022-08-02 12h39.31 utc:20537: No CERT database found
md manage:MESSAGE:2022-08-02 12h39.31 utc:20537: db_extension_available: Extension 'pg-gvm' is not available.
md manage:WARNING:2022-08-02 12h39.31 utc:20537: check_db_extensions: A required extension is not available.
md manage:WARNING:2022-08-02 12h39.31 utc:20537: init_manage_create_functions: failed to create functions
Any tips?

Hello @machadommm reading the error logs you've shared it seems like the new postegreSQL helper/wrapper isn't correctly installed. This is new for the 22.4.0 release, make sure that you've installed that helper correctly. I've been running through my script 3 times already on a fresh Ubuntu 22.04 vm without any issues.

Hi,
I re-installed my virtual machine from scratch.
Now your installation script worked correctly. Well done!!
Thank you very much for your excellent work.
Cheers,
Mauro

No worries and thank you for the kind words! happy you got it to work!


TLS 1.1 support

Issue description
Dear colleagues,
The documentation states that Cloud Integration supports TLS 1.1 for outbound communication.
However, TLS 1.1 is considered insecure and shouldn't be used anymore.
Are there any plans to disable TLS 1.1 support in the future?
Best regards
Simon
Feedback Type (Optional)
None
Page Title on SAP Help Portal (prefilled)
Security Aspects of Data, Data Flow
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/cloud-integration/sap-cloud-integration/security-aspects-of-data-data-flow-for-cloud-integration

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

hi @stacke84,
Thanks for reaching out.
Cloud Integration doesn't support only TLS 1.1 for outbound communication. As you mentioned, the help topic mentions that for outbound communication, Cloud Integration supports TLS 1.1, 1.2, and 1.3 versions.
Also, Cloud Integration doesn't enforce the TLS protocol version during the handshake. It is the target system that determines the TLS protocol version when the connection is being established. Cloud Integration supports TLS 1.1 so that the target system that has the requirement to use this version benefits.
Hope this helps.
Regards,
Karuna


How to catch interrupted error?

Querying in some table is time-consuming, I want to intentionally interrupt previous query with db.interrupt(), which works fine.
But got below error from previous query, how can I catch the error without crashing the application?
SQLite/Statement.swift:211: Fatal error: 'try!' expression unexpectedly raised an error: interrupted (code: 9)

Tried below code, but to no avail.
    do {
        let sequences = try db.prepare(repos.select(key))
        rows = Array(sequences.enumerated())
    } catch {
        print(error)
    }

Also happening to me when I call db.interrupt()
Crashes in Statement.swift, on
extension FailableIterator {
    public func next() -> Element? {
        // swiftlint:disable:next force_try
        try! failableNext()
    }
}

Closing as it is a duplicate of #1118. We're going to keep only one issue opened to track this problem.


Fraud details missing user agent and accept language

It seems the customers user agent and accept language are not being passed to Komoju.
Only customer IP and e-mail are present. I suspect Spree doesn't pass these options in the gateway request so they returning null values.
https://github.com/komoju/spree_komoju/blob/master/lib/active_merchant/billing/gateways/komoju.rb#L94

You are right.  Spree does not seem to store or pass these values onto the gateway.  I am looking in to this to find a way to send these details along to Komoju without adding any columns to the database.


quick clean up and comment pass

Taking advantage of an awkwardly sized chunk of time to chip away at hygiene and comments

Codecov Report
Patch and project coverage have no change.

Comparison is base (20acf88) 100.00% compared to head (3af824f) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##               1.5     #1079    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           46        46
  Lines         2652      2414   -238
  Branches       396       354    -42
==========================================
- Hits          2652      2414   -238

Flag
Coverage Δ

foundry
?

production
100.00% <ø> (ø)

reference
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 29 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix unknown fragment errors on save

Fixes https://github.com/graphql/graphiql/issues/1963

Hmm thanks! I will have to check into the history of these function signatures and see why the legacy relay compat mode was originally inverted there, but if it seems to fix the issue that’s good. You’ve tested this fix locally?

I've tested locally and it fixes the issue, but I haven't tested the relay compat mode (I'm not sure how to).
I git blamed this line and this is when it was introduced https://github.com/graphql/graphiql/commit/5d073d21c7b9dbab806e6956d01688feb8fc9a4e but I can't find any PR associated with it.

@patrickszmucer awesome to hear! the relay compat mode is for ancient relay 1 legacy support, I would consider it mostly deprecated and would be removed in the future.

@patrickszmucer are you able to sign the CLA? you only need to do it once for any Linux Foundation or GraphQL Foundation project :)

@acao done! Again, sorry for the delay from my side.

np! @patrickszmucer really appreciate this!


[WIP] add new parameter to cascadedetect with outputlevels (#5347)

Please see #5347 for more information.
some WIP

I added the variable as requested please review if the name for the variable/parameter is appropriate and if the method for comparing the variable is ok or if it would be better to specify one specific stage.
@headupinclouds

Thanks for adding this.  This looks good to me, but buildbot doesn't like it  I am unsure how strictly the ABI tests are followed wrt the default parameter issues it reports:
http://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/4291/steps/Compare ABI dumps/logs/report-html
This seems like biggest potential issue:
The name of the appropriate symbol for this function on binary level has been changed from

_ZN2cv17CascadeClassifier16detectMultiScaleERKNS_11_InputArrayERSt6vectorINS_5Rect_IiEESaIS6_EERS4_IiSaIiEERS4_IdSaIdEEdiiNS_5Size_IiEESH_b
to
_ZN2cv17CascadeClassifier16detectMultiScaleERKNS_11_InputArrayERSt6vectorINS_5Rect_IiEESaIS6_EERS4_IiSaIiEERS4_IdSaIdEEdiiNS_5Size_IiEESH_bi.
This may cause "undefined reference" linker error in old client applications.

I suppose the alternative could be to hard code the old behavior with the exact same prototype and add a new method to provide the flexibility of your PR.  Thoughts?  Happy to help.

Could you tell me a good reason why you would want to have the opportunity of visualising the last x stages of detections? Shouldnt people just train a model with less stages then if they want to have those detections?

@headupinclouds could answer to this question.
For the ABI compatibility it seems that we cannot change it like this at all, so the only chance we got is maybe adding an additional method call but this seems a bit odd after already having 3 different method calls right now.

Shouldnt people just train a model with less stages then if they want to have those detections

I think if all detections are treated equally (regardless of rejection stage) that is true.  Hard coding the last four stages does seem very arbitrary.  Maybe this behavior isn't needed.

So we do not need this change right?
I did not think of training the model with less stages gives exactly the same effect.

So then the best functionality we got here is the one already implemented right?

The one already implemented is the hardcoded =0 one right? If so, yes that seems the best solution for me. Then I would add another overload function where you are able to specify which stage you want.

well unfortunately we have a problem here since the overloading is already at it's limit.
http://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/4301/steps/compile release/logs/stdio
I cannot arrange another int like parameter in the default set parameter list which is similiar to the already existing method.
Any suggestions here besides creating a new method?

I hope this build and tests are correct now then please review @StevenPuttemans
@headupinclouds please look as well if it is like you are expecting it.

Thanks.  I will have to look on Monday.
Sent from my iPhone

On Sep 19, 2015, at 7:17 AM, Philip<EMAIL_ADDRESS>wrote:
I hope this build and tests are correct now then please review @StevenPuttemans
@headupinclouds please look as well if it is like you are expecting it.
—
Reply to this email directly or view it on GitHub.

seems like we cannot get arround this or am i doing something wrong?
http://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/4319/steps/Compare ABI dumps/logs/report-html#Type_Binary_Problems_High

quite busy at the moment but will have a look later today :)

Looking back at this, the current check of
if( classifier->data.stages.size() + result == 0 )
also doesn't really do the right thing as it suffers from an off-by-one error (my fault); it should (I believe) fill rejectLevels and levelWeights with information about any proposal that failed the last stage. Instead, it fills them with information about proposals that passed the last stage (that is, that successfully passed the entire cascade).

I understand your concerns and agree that the current behaviour is not what you tried to explain.
For this PR i would like to get the parameter and the new method working and do a follow up PR which will change the real algorithm.

I agee with @Dikay900 that it might be good to first unify the behaviour in between branches to avoid different end results and then try to find a solution for what is the best way of adapting the algorith.
As to the parameter name, lastAcceptedStage seems fine to me, indeed we do need a good documentation on its use then!

@StevenPuttemans i won't revert the behavior for this method to 2.4 for just one commit or a very specific commit range since we will change this anyway to another method and i rather want to have the same functionality in 3.0 if someone used it already till now.
Renamed the variable added TODO comment for changing this method in follow up PR (could be done by someone else)
And testing if i get around this ABI compatibility...

:+1:

ok @achaldave i will change this line to

-result >= lastAcceptedStage
with a later commit i want to see if ABI_compatibility will get through now.

have to call for help again @alalek
I still got the same errors as in the beginning
http://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/4364/steps/Compare ABI dumps/logs/report-html#Type_Binary_Problems_High

@Dikay900 Looks like there is no easy way to resolve ABI problem with virtual functions.

Then it seems we cannot change anything in the CascadeClassifier without hacks or mess up the structure since the method calls goes back to the virtual methods of BaseCascadeClassifier.

Perhaps we can maintain the old, 2.0 version of the code in the default method, deprecate it in documentation, and add a new method that uses the new method?

unfortunately we cannot change any parameter in the base function you will call when you use the cascade so the only methods we can use are the three we currently have. We do not have any method with a parameter to provide this functionality we want, since we only can set outputRejectLevels to true or false.

#define CV_HAAR_DO_CANNY_PRUNING    1
#define CV_HAAR_SCALE_IMAGE         2
#define CV_HAAR_FIND_BIGGEST_OBJECT 4
#define CV_HAAR_DO_ROUGH_SEARCH     8

well i really do not like that idea although this is seems to be the only way to do this.
But i do not want to include such a workaround, i will change this PR to reflect the changed if line with default value 0 since no default value will reflect the old 2.4 behavior.

:+1:

will get reverted until ABI_Compatibility is resolved.
I think the current structure of the refactored Cascadeclassifier results into the diamond problem so we cannot get around the abi compiler it seems. (was my last thought digging through the code)


400 Bad Request without details

My code is https://gitlab.com/rawsec/rawsec-inventory-twitter-bot/-/blob/master/xBot.rb
In short (without the unnecessary parts):
require 'x'

X_CREDENTIALS = {
  api_key: ENV['twitter_api_key'],
  api_key_secret: ENV['twitter_api_key_secret'],
  access_token: ENV['twitter_access_token'],
  access_token_secret: ENV['twitter_access_token_secret']
}
# Initialize an X API client with OAuth credentials
x_client = X::Client.new(**X_CREDENTIALS)

x_client.post('tweets', "{\"text\":\"#{message}\"}")

And I'm just receiving this error without much details:
➜ ruby xBot.rb
/home/noraj/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/x-0.8.1/lib/x/response_handler.rb:41:in `handle': 400 Bad Request (X::BadRequestError)
        from /home/noraj/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/x-0.8.1/lib/x/client.rb:80:in `send_request'
        from /home/noraj/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/x-0.8.1/lib/x/client.rb:50:in `post'
        from xBot.rb:81:in `<main>'

PS: That's no credential issues, I had another error (401 or 403) when the credentials were wrong.

You're using application context to try to send tweets. You must use the user context instead.
You've probably seen user context authentication before. That's where you "log in with Twitter" with some other site, and you click the blue "Authorize App" button.
In your case, once you've logged in as some X user and clicked "Authorize App," X will send you a bearer token, and you can use that to send a tweet.
Here's some good sample code that shows you how to do the user auth: https://github.com/unasuke/twitter-login-app
Some docs on X: https://developer.twitter.com/en/docs/authentication/oauth-2-0/authorization-code

I'm not able to replicate. Try adding the 'httplog' gem in your Gemfile to see Twitter's response in greater detail. Also make sure you're using 3-legged OAuth user-context authentication and not app-context authentication.
json = { "text": "ok" }.to_json
client.post("tweets", json)
[...httplog headers omitted]
[httplog] 2023-09-22 16:12:29 -0600 Response: {"data":{"edit_history_tweet_ids":["1705344340552220696"],"id":"1705344340552220696","text":"ok"}}

When I try it again:
client.post("tweets", json)
[httplog] 2023-09-22 16:15:53 -0600 Response: {"detail":"You are not allowed to create a Tweet with duplicate content.","type":"about:blank","title":"Forbidden","status":403}

json = { "text": "ok" }.to_json
client.post("tweets", json)

Yeah was just a JSON escaping issue, my bad, I feel so lame.


Random crash / Mod incompatibility - Latest version 1.20.2

When I try to open the GUI:
Unreported exception thrown!
java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_4895 failed
at net.minecraft.class_3929.(class_3929.java:103)
at net.minecraft.class_634.method_17587(class_634.java:1150)
at net.minecraft.class_3944.method_17591(class_3944.java:37)
at net.minecraft.class_3944.method_11054(class_3944.java:11)
at net.minecraft.class_2600.method_11072(class_2600.java:23)
at net.minecraft.class_1255.method_18859(class_1255.java:156)
at net.minecraft.class_4093.mixinextras$bridge$method_18859$5(class_4093.java)
at net.minecraft.class_4093.wrapOperation$dhk000$carpet-tis-addition$yeetUpdateSuppressionCrash_implForThreadExecutorTaskExecuting(class_4093.java:570)
at net.minecraft.class_4093.method_18859(class_4093.java:23)
at net.minecraft.class_1255.method_16075(class_1255.java:130)
at net.minecraft.class_1255.method_5383(class_1255.java:115)
at net.minecraft.class_310.method_1523(class_310.java:1231)
at net.minecraft.class_310.method_1514(class_310.java:856)
at net.minecraft.client.main.Main.main(Main.java:253)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_4895 failed
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
... 17 more
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
at io.gitlab.jfronny.libjf.unsafe.asm.AsmTransformer.transformClassBytes(AsmTransformer.java:75)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
... 21 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector renderBg(Lnet/minecraft/class_8064;Lnet/minecraft/class_1703;Lnet/minecraft/class_332;FII)V in mixins.brb-common.json:SmithingScreenMixin from mod brb failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap brb-common-refmap.json
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1384)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
... 25 more

Saem, for some reason I am also getting a crash on start for some reason. If I disable the mod things work.
I am on 1.20.1
https://mclo.gs/J49MkRd

Ok, thanks for reporting this. I will investigate and try to get a fix out by tomorrow.

Awesome 😊

Ok didn't get it done by whenever tomorrow was but be assured I am working on it

These two are two very different cases though since they are concerning different versions of the mod so I will examine them separately. I will close this issue when both are fixed.

When I try to open the GUI:
Unreported exception thrown! java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_4895 failed at net.minecraft.class_3929.(class_3929.java:103) at...

I've tried to recreate this error on the newest version on Curseforge and had no success. Can you verify if you are really using the newest version?

I highly assume it's a mod compatibility error. But now you can't make a use of my mod list, since it's too big.
If I find time I could investigate more into it and spot which mods causing this issue.

I highly assume it's a mod compatibility error. But now you can't make a use of my mod list, since it's too big.
If I find time I could investigate more into it and spot which mod is creating this issue.

Can you upload the full crash log so I can investigate what specifically might be failing? If you are using fabric it would also be great to install the mixintrace mod beforehand to give me some extra information on what might be goign wrong.

I will do that later 😊

Saem, for some reason I am also getting a crash on start for some reason. If I disable the mod things work. I am on 1.20.1 https://mclo.gs/J49MkRd

This is probably a mod compatibility problem aswell. From the crash log it looks like another mod is messing with the dynamic slot icons in the smithing menu so BetterSmithingTable fails when trying to prevent them from rendering. If you are using a publically available modpack you can share it with me so i can attempt to debug the issue with your configuration.

I think it might be one of these:

Not using a public modpack, just some mods that I like.

I think it might be one of these: [...]
Not using a public modpack, just some mods that I like. I removed half of the mods I play with, mostly major mods, and this crash still happens when better smithtable is installed. crash-2024-01-04_13.15.06-fml.txt the crash also has the mods installed

[...]

I can see an error caused by the mod in the crash report but it's weirdly merged with fault in the Corpse mod. This might be because the two are incompatible, but it could also just be some weirdness in the way the error is logged. Try removing the Corpse mod and opening the smithing interface again.
If the issue still persists please upload the crash report again so I check if anything changed.

Actually looking at the code there is no reason this mod should mess with BetterSmithingTable, but please still try without it.

Actually looking at the code there is no reason this mod should mess with BetterSmithingTable, but please still try without it.

I also tested other UI mods, and both Better Recipe Book, and Recipe Book is Pain are causing the problem.

Thanks @ffuentesm, I use Better Recipe Book too, maybe that's the issue mod. I will investigate soon into it.

I can confirm that Better Recipe Book is the problem here.
I am using version: brb-1.10.0+1.20.2

Ok, I assume this issue can be closed now. I will look at Better Recipe Book and check if I can make the two compatible.

Ah yes, the incompatibiliy is very obvious. The same method call is being redirected once in Better Recipe Book and once in Better Smithing Table. The fix should not be too hard though.

I will close this issue after the fix is ready.

Thank you!! 🥳

Ok, the fix is in the new version for 1.20.2 - 1.20.4. The fix for 1.20.1 will take a little more time as I need to repeat the changes for the version for 1.20 - 1.20.1.

Thank you, I will update to that version soon.

2.0.0 should fix this for 1.20.1 as well


FirebaseApp name [DEFAULT] already exists!

Hi, after integrating firestack and setup my project in firebase (i've integrated google-services.json as well), i've got this error.
10-30 13:11:45.080    5443-5479/com.deck D/Firestack﹕ New instance 10-30 13:11:45.080    5443-5479/com.deck D/FirestackAuth﹕ New FirestackAuth instance 10-30 13:11:45.081    5443-5479/com.deck D/FirestackAnalytics﹕ New instance 10-30 13:11:45.081    5443-5479/com.deck D/FirestackStorage﹕ New instance 10-30 13:11:45.084    5443-5479/com.deck D/FirestackCloudMessaging﹕ Firestack initMessageHandler called 10-30 13:11:45.087    5443-5479/com.deck D/FirestackCloudMessaging﹕ New instance 10-30 13:11:45.451    5443-5480/com.deck I/ReactNativeJS﹕ '%cfirestack             |', 'color: hsl(222.4922359499622,99%,40%); font-weight: bold', '[info]', 'Creating new firestack instance' 10-30 13:11:45.451    5443-5480/com.deck I/ReactNativeJS﹕ '%cfirestack             |', 'color: hsl(222.4922359499622,99%,40%); font-weight: bold', '[info]', 'Calling configure with options', { debug: true } 10-30 13:11:45.451    5443-5480/com.deck I/ReactNativeJS﹕ '%cfirestack             |', 'color: hsl(222.4922359499622,99%,40%); font-weight: bold', '[info]', 'Calling native configureWithOptions' 10-30 13:11:45.453    5443-5481/com.deck I/Firestack﹕ configureWithOptions 10-30 13:11:45.454    5443-5481/com.deck D/Firestack﹕ Setting applicationId from params to: 1:260231527748:android:.... 10-30 13:11:45.454    5443-5481/com.deck D/Firestack﹕ Setting apiKey from params to: AIzaSyD... 10-30 13:11:45.454    5443-5481/com.deck D/Firestack﹕ Setting gcmSenderID from params to: 260.... 10-30 13:11:45.454    5443-5481/com.deck D/Firestack﹕ Setting storageBucket from params to: staging.... 10-30 13:11:45.454    5443-5481/com.deck D/Firestack﹕ Setting databaseURL from params to: https://staging.... 10-30 13:11:45.454    5443-5481/com.deck D/Firestack﹕ Setting databaseUrl from params to: https://staging.....firebaseio.com 10-30 13:11:45.454    5443-5481/com.deck D/Firestack﹕ Setting clientId from params to: 1:260231527748:android:... 10-30 13:11:45.454    5443-5481/com.deck I/Firestack﹕ Configuring app 10-30 13:11:45.454    5443-5481/com.deck E/Firestack﹕ ERROR configureWithOptions 10-30 13:11:45.454    5443-5481/com.deck E/Firestack﹕ FirebaseApp name [DEFAULT] already exists!
Some stack overflow answers suggested that this is due to missing apply plugin: 'com.google.gms.google-services' line, but i already have it at the very bottom of app build.gradle file
Am I missing somethig?

It seems that this error isn't important. I had problems couse of using android emulator with wrong image (without google API)

This isn't an error. It's happens for the same reason #98.


fix(core): ensure link component works with mailto

Signed-off-by: Andrew Thauer<EMAIL_ADDRESS>Hey, I just made a Pull Request!
This ensures that <Link<EMAIL_ADDRESS>/> works correctly (introduced in #4858)
NOTE: I did not include a changelog since #4858 has not been released yet.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks for taking a look!


[Feature Request] new OpenAI o1 model

🥰 需求描述
OpenAI introduced new o1 series model with SOTA performance.
And it can be used by API, I am wondering if ChatGPT-Next-Web can support new models.
🧐 解决方案
NOP
📝 补充信息
The o1 models are currently in beta with limited features. Access is limited to developers in tier 5
Tier 5 means user has paid over $1000 and it has been over 30 days since first successful payment

+1

+1

+1

+1

+1

Need some changes, o1-review does not support stream, no temperature, no max token.

how to use o1 model

#5416


Write design doc for azure-spring-messaging

Parent issue: #23402
Sample design doc: https://github.com/Azure/azure-sdk-for-java/wiki/Spring:-Design-doc-of-level-1-azure-spring-cloud-starter

Close this issue for design doc has been finished: https://github.com/Azure/azure-sdk-for-java/wiki/Spring-Cloud-for-Azure-Messaging-design


[dv/top] add ast_base prefix to ast reg block

Signed-off-by: Sharon Topaz<EMAIL_ADDRESS>The partner AST registers are extended from ast_base_reg (and not directly from dv_base_reg), so for now need this addition to support it.
Will also open an issue about it so in the future we can have a better solution.

This is a hack that is needed for us to progress forward. The point of contention here is the fact that ast_base_reg that has been added to the open source repo is a valid type name that is only visible in Nuvoton's internal repo. ast_base_reg is a class extension from which all of the 'real' AST register models extend from - it abstracts some of the common features of the AST design.
The problem is exacerbated with having to generate the complete chip level register model, where all blocks except AST extend from our open sourced dv_base_reg class. Its just the AST registers that need to extend from this special class.
Ideal solution would be to do away with ast_base_reg altogether so that the AST register models also extend from dv_base_reg. We will need to identify what modifications does this layer provide, and figure out if we can support them in a different way (perhaps with external callbacks?). @sha-ron, lets discuss this in detail?
@weicaiyang @cindychip
In the interim, to avoid blocking progress, we could maybe let this slide (with of course, a TODO and an issue filed). @eunchan / @tjaychen / @msfschaffner, thoughts?

This is a hack that is needed for us to progress forward. The point of contention here is the fact that ast_base_reg that has been added to the open source repo is a valid type name that is only visible in Nuvoton's internal repo. ast_base_reg is a class extension from which all of the 'real' AST register models extend from - it abstracts some of the common features of the AST design.
The problem is exacerbated with having to generate the complete chip level register model, where all blocks except AST extend from our open sourced dv_base_reg class. Its just the AST registers that need to extend from this special class.
Ideal solution would be to do away with ast_base_reg altogether so that the AST register models also extend from dv_base_reg. We will need to identify what modifications does this layer provide, and figure out if we can support them in a different way (perhaps with external callbacks?). @sha-ron, lets discuss this in detail?
@weicaiyang @cindychip
In the interim, to avoid blocking progress, we could maybe let this slide (with of course, a TODO and an issue filed). @eunchan / @tjaychen / @msfschaffner, thoughts?

sounds good. Let's get it in and figure out a better way later.

Sounds like a plan. Let us track this hack and brainstorm some real solution to this issue.

@sriyerg @weicaiyang
CI is failing on lint issue, I ran 'util/dvsim/dvsim.py -t veriblelint hw/top_earlgrey/lint/top_earlgrey_dv_lint_cfgs.hjson' but not sure in which log I can see the failures related to top_uvm_reg.sv.tpl.  Can you please tell under which veriblelint directory I can see the failure?

@sriyerg @weicaiyang
CI is failing on lint issue, I ran 'util/dvsim/dvsim.py -t veriblelint hw/top_earlgrey/lint/top_earlgrey_dv_lint_cfgs.hjson' but not sure in which log I can see the failures related to top_uvm_reg.sv.tpl. Can you please tell under which veriblelint directory I can see the failure?

This is due to tailing spaces at line 44 and 46.

@weicaiyang
Thanks for the help, fixed.
Just so I will know for next time, where did you found the failure?

@weicaiyang
Thanks for the help, fixed.
Just so I will know for next time, where did you found the failure?

The CI log shows there are some tailing space at the generated ral_pkg. Then I download this PR and open the edited file with gvim, since github doesn't show me the tailing spaces.


Add fixtures framework + commands

Problem:
When starting out with local dev using this app we have no data available to use. This can be problematic given it means we each need to manually create data for our DB every time we want to try some local dev
Aims:
Use a package like https://github.com/RobinCK/typeorm-fixtures to to create a fixture where a single user is created.

@ryanolee I'll have a try at this issue. ^_^

Sure thanks for picking this up @tsukimi2 ! Let me know if you need any help getting things set up!

Closing issue with merged code above.


feat: added support for setting the "origin" http header.

This commit adds an http origin header which is by default set to be the same as the referer without the trailing '/'.
This is to support certain popular IPTV providers.
A more elegant approach would be to define an origin header in the m3u8 file for each channel but that might be overkill. Perhaps in a future commit if i have the time.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d258089) 57.30% compared to head (3111a2c) 57.30%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##           electron     #349   +/-   ##
=========================================
  Coverage     57.30%   57.30%
=========================================
  Files            56       56
  Lines          1574     1574
  Branches        196      196
=========================================
  Hits            902      902
  Misses          671      671
  Partials          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thank you for the contribution!


[BUG] Crashing me pc on launch

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
It happened right when bloxstrap just updated. I tried to launch it but then my pc freeze and auto restarted it self, then the next time I try to open it up again, it asked me to download a deskstop runtime programm which I already did but it still don't launch, then i tried manually restart my pc and reinstall bloxstrap which somehow worked but then it crashes again after the next time I launch it again.
[And yes I did tried to open normal roblox without bloxstrap and it worked just fine]

Ello there and I am facing the same issue and like a month ago i belive the same thing happened but after a week it was working fine but now the problem has started agian

In what way does it crash? Do you get an error message?

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen.


re-add disk write test feature flag

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Yes. I thought the reboot would be enough for now, and the reports will let
us know how many hosts are affected, before we take more action.
On 2 Jan 2020, at 16:22, Valerij Fredriksen<EMAIL_ADDRESS>wrote:

@freva commented on this pull request.
In flags/src/main/java/com/yahoo/vespa/flags/Flags.java
https://github.com/vespa-engine/vespa/pull/11633#discussion_r362511015:

@@ -171,6 +171,12 @@
"Takes effect on next host admin tick",
NODE_TYPE, HOSTNAME, APPLICATION_ID);

public static final UnboundBooleanFlag ENABLE_DISK_WRITE_TEST =
defineFeatureFlag(

       "enable-disk-write-test", false,

       "Regularly issue a small write to disk and fail the host

if it is not successful",
The failing is TODO? (Since its currently only setting an unspecified
report)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vespa-engine/vespa/pull/11633?email_source=notifications&email_token=AACAUTAHNYB3CFQGINFSZHDQ3YBEPA5CNFSM4KCDEY4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQQQATQ#pullrequestreview-337707086,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACAUTDTTPU6X6GL4CQAWLTQ3YBEPANCNFSM4KCDEY4A
.


[Improvement] Bucket - Highlight all-out attack and defense moves.

When the bucket modifier is open, it would be handy to highlight an all-out attack and all-out defense moves.

Effectively a duplicate of https://github.com/crnormand/gurps/issues/122