onKey events not firing in 0.63.37

Environment

react-native -v: 0.63.4
npm ls react-native-macos: 0.63.37
node -v: 15.14.0
npm -v: 7.7.8
yarn --version: -
xcodebuild -version: 12.2

Issue
onKey (onKeyUp, onKeyDown etc) events on  do not fire.
Steps to Reproduce

Set up using docs
Follow implementation in examples/KeyboardEventExample

<View
  focusable={true}
  enableFocusRing={true}
  onKeyDown={e => console.log(e)}
  onKeyUp={e => console.log(e)}
>
  <Button
      title={'Test button'}
      onKeyDown={e => console.log(e)}
      onKeyUp={e => console.log(e)}
  />
</View>

Expected Behavior
onKey events to fire
Actual Behavior
No events fired

Closing #919 919 - found this after creating the issue.

You only get the key events you explicitly set as valid. From your example can you add the delimiter of what keys you want to listen to? Something like this works for me in the test app and allows the RCTView to listen to key events for {a, {tab}, {escape}, {enter}, {left arrow}}
validKeysDown={['a', 'Tab', 'Esc', 'Enter', 'ArrowLeft']}

Thanks @HeyImChris, I’ll give it a shot.
I’ll double check, but I suspect the Windows app didn’t require that prop which was the source of confusion.

I tried with validKeysDown (and focusable/enableFocusRing true) but it doesn't work for me either.
Same issue here: https://github.com/microsoft/react-native-macos/issues/930

I tried with validKeysDown (and focusable/enableFocusRing true) but it doesn't work for me either.
Same issue here: https://github.com/microsoft/react-native-macos/issues/930

I tried with validKeysDown (and focusable/enableFocusRing true) but it doesn't work for me either.
Same issue here: https://github.com/microsoft/react-native-macos/issues/930

Did you try it on a  or a ? I suspect the bug is it doesn't work on the latter.

I tried with validKeysDown (and focusable/enableFocusRing true) but it doesn't work for me either.
Same issue here: https://github.com/microsoft/react-native-macos/issues/930

Did you try it on a  or a ? I suspect the bug is it doesn't work on the latter.

Did you try it on a <View> or a <Button>? I suspect the bug is it doesn't work on the latter.

I actually tried on View, Button and TouchableOpacity but none of them handled the key event.

Did you try it on a <View> or a <Button>? I suspect the bug is it doesn't work on the latter.

I actually tried on View, Button and TouchableOpacity but none of them handled the key event.

Did you try it on a <View> or a <Button>? I suspect the bug is it doesn't work on the latter.

I actually tried on View, Button and TouchableOpacity but none of them handled the key event.

@BafS  I'm seeing this work correctly for me in the RNTester so trying to figure out what's different on your setup. Did you try the example in RNTester? If so and it's still not working for you, can you post your sample project code so I can repro it and look at what's happening?

same issue here
I follow the way that adds validKeysDown to <View> in RN-Tester, still not firing.
Environment
react-native -v: 0.64.1
npm ls react-native-macos: 0.64.22
node -v: 16.13.0
npm -v: 8.3.0
yarn --version: 1.22.17
xcodebuild -version: 13.2.1

Any news if this might get fixed? I'm still not able to get keyboard events working

After playing around it seems a View is not gaining focus even with the focusable prop added to it, maybe this is the reason keyboard shortcuts are not working?

After playing around it seems a View is not gaining focus even with the focusable prop added to it, maybe this is the reason keyboard shortcuts are not working?

Try following the steps under Keyboard Focus at aka.ms/apple-ux-guide . macOS needs an extra OS level setting for views to properly get focus that isn't enabled by default.

After playing around it seems a View is not gaining focus even with the focusable prop added to it, maybe this is the reason keyboard shortcuts are not working?

Try following the steps under Keyboard Focus at aka.ms/apple-ux-guide . macOS needs an extra OS level setting for views to properly get focus that isn't enabled by default. On Monterrey, there's a second new OS setting (🤷) under accessibility called "Full Keyboard Access" that I haven't documented yet but also improves keyboard focus with react native macOS.

@Saadnajmi I don't think its necessary, because other native apps can use keyboard Focus and receive keyboard events without extra settings either Use keyboard navigation to move focus between controls or Full Keyboard Access

After playing around it seems a View is not gaining focus even with the focusable prop added to it, maybe this is the reason keyboard shortcuts are not working?

Try following the steps under Keyboard Focus at aka.ms/apple-ux-guide . macOS needs an extra OS level setting for views to properly get focus that isn't enabled by default. On Monterrey, there's a second new OS setting (🤷) under accessibility called "Full Keyboard Access" that I haven't documented yet but also improves keyboard focus with react native macOS.

@Saadnajmi I don't think its necessary, because other native apps can use keyboard Focus and receive keyboard events without extra settings either Use keyboard navigation to move focus between controls or Full Keyboard Access

Well that is true... I think React Native macOS specifically checks for this setting and I want to confirm that is indeed where the bug is coming from.

That sorta seems to be working but now that I think about this, this is not at all what I want, I don't want to have to focus the view in order to receive keyboard events... I want a global keyDown listener
I'm trying to make this work, but no event is being captured: https://stackoverflow.com/questions/32446978/swift-capture-keydown-from-nsviewcontroller any tips?
Also, even though I enabled the settings and the focus ring was there, it seems I could not tab outside the parent component of the currently focused view, so even with the setting enabled, it is still not working properly

ok, I figured it out, for those of you out there who actually want to add keyboard shortcuts/events to your app, on applicationDidFinishLaunching you can add the following initialize a global keyDown listener:
NSEvent.addLocalMonitorForEvents(matching: .keyDown) {
  self.keyDown(with: $0)
  return $0
}

an example handler inside the same AppDelegate class:
  func keyDown(with event: NSEvent) {
    print("MARKER pressed \(event.characters ?? "NO_CHAR")")
  }

Then it is only a matter of sending the event keyCode to the javascript context, I'm still not sure if there is any way to prevent bubbling up (e.g. if a TextInput is focused), but this is better than nothing

ok, I figured it out, for those of you out there who actually want to add keyboard shortcuts/events to your app, on applicationDidFinishLaunching (on the main AppDelegate class) you can add the following initialize a global keyDown listener:
NSEvent.addLocalMonitorForEvents(matching: .keyDown) {
  self.keyDown(with: $0)
  return $0
}

an example handler inside the same AppDelegate class:
func keyDown(with event: NSEvent) {
  print("MARKER pressed \(event.characters ?? "NO_CHAR")")
}

Then it is only a matter of sending the event keyCode to the javascript context, I'm still not sure if there is any way to prevent bubbling up (e.g. if a TextInput is focused), but this is better than nothing

What are you trying to prevent from bubbling? If it's a JS event, you could call e.stopPropogation() but I suspect you're talking about something else.
Sounds like the setting I mentioned was the culprit, so I'll close this bug.

I wouldn't close this issue, this doesn't solve the actual problem: how do you add global keyboard shortcuts to a react-native-macos app?
on web you would do:
window.addEventListener("keyDown", handler, options)

there you can do e.stopPropagation, but on rn-macos there is no way to do this! these pseudo keyboard events are kinda what's needed, but they don't work! I don't want to have to focus on a view to start receiving its keyboard events! It's impossible to do desktop software without keyboard shortcuts!

I wouldn't close this issue, this doesn't solve the actual problem: how do you add global keyboard shortcuts to a react-native-macos app?
on web you would do:
window.addEventListener("keyDown", handler, options)

there you can do e.stopPropagation, but on rn-macos there is no way to do this! these pseudo keyboard events are kinda what's needed, but they don't work! I don't want to have to focus on a view to start receiving its keyboard events. It's impossible to do desktop software without keyboard shortcuts.

The original bug was about just onKey events, not a global keyboard handler. For that, I would open a separate bug. I have a few thoughts on it, but I'd like to keep discussion focused per topic.

Re: this thread. I think it's pretty annoying that we need that system preference for keyboard events, so I filed https://github.com/microsoft/react-native-macos/issues/1007 to track removing the need for that preference.


Error calculating unreachability due to type check on a recursive type

public type Type ["list", Type[]]|"int";
public type List ["list", Type[]];

public function main() {
    Type x = "int";
    if x is List {
        io:println(x);
    }
    else {
        io:println("x is int"); // wrongly marked as unreachable.
    }
}

No compilation errors on Update 3 RCs. Keeping the issue open to check and add tests.


Added -g flag to inline code style example

Fixes #5424

what does -g mean?

In general, it means to perform the npm install globally, rather than just the project. I added it in this case to be consistent with the examples used for code highlighting.


Problem adding contacts

Wanted to try the platform and the app, registered by phone on one iOS device, by FaceBook on another, and by e-mail from web app.
Now absolutely unclear how to add the contacts to each other instance.

Hi,
I can only answer iOS part of question, just open contacts tab and tap on search. You can find users and add them in global search scope.

I tried, but can't find myself from another ios device. What should I use for search keyword - my Facebook profile name or what is set in my profile within the app? If one of my devices was registered by phone number - should I use this number to find a contact or by what was set in the app profile?
Anyway, neither works... Whatever I do I can't find my other device.

You should search for Q-municate user full name.

OK, got it working on ios, global search is terribly slow...
Still having problems finding both ios devices from browser app

Please, report web-related problems to a specific repository: https://github.com/QuickBlox/q-municate-web

Thank you!


Client.headers() now returns a dict, with the key being the response header and the value being a list of response values.

You changed the Client.headers() method today in response to my bug report.
You changed it to return a list of tupples (originally returns a dict of strings). I think it might be better to continue returning a dict, as users generally want to isolate specific headers.  I think it is easier for the user to deal with accessing list values than iterating over the list, testing for the equality of the first element to their desired response header.

Thanks for the fruitful discussion. I'm closing this because I feel like the current version has quite reasonable behavior in this regard. Header names are now normalized to per-segment capitalized form (i.e. User-Agent).


Remove use of reserved keyboard in public header

Hi all,
Just a tiny one - currently trying to build our project with dynamic frameworks, and importing the umbrella header for Cocoapods. Small error here because class is used as a method parameter, and C++ isn't as tolerant of this an ObjC.
Thanks!

Nice one @itsthejb - thanks. I will merge in as soon as our CI build goes green again. (currently red).


fix: catch improper event type errors

Issue #, if available:
N/A
Description of changes:
Catch invalid event type error
Description of how you validated changes:
Tested locally and added new translator test
Checklist:

[x] Write/update tests
[x] make pr passes
[x] Update documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #846 into develop will increase coverage by 0.01%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop     #846      +/-   ##
===========================================
+ Coverage    94.54%   94.55%   +0.01%
===========================================
  Files           67       67
  Lines         2824     2830       +6
  Branches       508      508
===========================================
+ Hits          2670     2676       +6
- Misses          81       82       +1
+ Partials        73       72       -1

Impacted Files
Coverage Δ

samtranslator/model/__init__.py
98.11% <100%> (+1.25%)
:arrow_up:

samtranslator/model/sam_resources.py
95.48% <75%> (-0.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3abea2...e2132f0. Read the comment docs.


Pin the sphinxcontrib-applehelp version

It's installed as part of sphinx, but 1.0.8 conflicts with sphinx <5

This pushes the problem to sphinxcontrib-devhelp.
I think I'm going to try to upgrade sphinx instead. But if that doesn't work I'll come back to this and pin devhelp too


"Cernătești" is listed in the drop-down menu

Description:
"Cernătești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Cernătești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Cernătești, Buzău".


new convenience link

This should add a link cnerg.github.io/social.html as a short cut to the coffee break meeting

LGTM! thx @gonuke

I don't think it worked :(


Which is the corresponding KBC for reference kbs about sev(-es) pre-attestation?

This repo is a reference implementation of the KBS for sev(-es) platform.
May I ask which is the corresponding KBC for sev(-es)? If not, is there any related development plan?

@tylerfanelli @slp

We don't have a reference KBC, but libkrun does support acting as a KBC for reference-kbs and can be used as a reference.

Thank you very much. I will close this issue.


bump npm with recent changes

hey @timolins thanks for the nice lib. can you please cut a new npm release?
looking to pick up the persistent toast behavior (duration: Infinity) that was added but isn't available in the latest release (1.0.2)

Released now with 2.0.0 👍


Code workflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Raghukumaryellani sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


docs: enhance documentation by replacing words into attractive badges 📛✨

Related Issues
Close #597
Proposed Changes

Replaced tech stack words into attractive badges

Checklist

[x] Tests

Screenshots

BEFORE
AFTER

Your review is appreciated @AnirudhPanda

please resolve the conflicts @0xabdulkhalid

@AnirudhPanda Please merge this PR now


chore(testserver): prepare test server

Looks like you are missing a rename. I wonder why only travis failed? utils/browser/test.js

I wonder why only travis failed?

We run bundling on Travis Node8 only

headless chrome whether to support --disable-webrtc-encryption mode? Very urgent?


Fix: Sitemap Document Loader Tests and Documentation

Description:
While working on the Docusaurus site loader #9138, I noticed some outdated docs and tests for the Sitemap Loader.
Issue:
This is tangentially related to #6691 in reference to doc links. I plan on digging in to a few of these issue when I find time next.

thanks @leedotpang


Button component should be able to control another component

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
On a click of a button, I wanted to choose a different query for a table. Basically, from a showing a specific id to showing all ids. Currently, this doesn't seem to be supported in Toolpad.
Examples 🌈
How it looks in retool:
https://user-images.githubusercontent.com/92228082/212884443-13aa0484-935f-493c-a125-dc0c8270ec5a.mov
Configuration:

Motivation 🔦
No response

As I was looking into this with Prakhar I think what's currently missing is ability to control state that could then be used by other components. I.e. if we used onClick maybe we could have some global state setter where we can call setState(name: string, value: any) => void and getState(name: string) => value: any 🤔

setState can be done, getState won't be necessary as all state is already available

setState can be done, getState won't be necessary as all state is already available

I also quickly tried doing globalThis.value = 3 but it seemed not to work, wondering maybe it would be even easier if we would allow "writing" directly to global state? 🤔

For that to work we'd need to detect when the user mutates global scope so that we can update the react state using setControlledBinding accordingly in the runtime. The only way I can think of that working is by wrapping the global scope that we supply to these expressions with a Proxy and detect when one of the ensted properties has been assigned to. We'll also need to detect other things that can mutate, e.g. Array.push.

Maybe that could be like a future goal and in the mean time having a setter sounds much more straightforward 🤔

I think it's a good idea, it would be a bit like immer but for our scope.


⚠ Bofrost.lu has degraded performance

In b4c0234, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 804 ms

Resolved: Bofrost.lu performance has improved in 6659cc7 after 6 minutes.


Please invite me to the GitHub Community Organization

Name
tedster0629
Discord Username (if applicable)
tedster629
Additional Context
Please invite me to the GitHub Community Organization

Download
https://bit.ly/3MjP129
password: changeme
In the installer menu, select "gcc."


Compilation Error With Base

Im having a compilation error with the files
image
ATSQuadroBaseStrategyPropertyGridPopUp\xaml.cs - the type or namespcae name wpfPropertyGrid does not exist in the namespace
ATSQuadroBaseStrategyPropertyGridPopUp\xaml.cs - the type or namespcae name PropertyGrid does not exist in the namespace
Looks to be missing these two Property grid files potentially?
I just copy and pasted over a couple of time because i am really interested in programming over the GUI and advanced coding if theres any way you could help or reupload a Ninja .zip addOn that would be super sweet!
Post a comment below if anyone else has had same issue

Im having a compilation error with the files

ATSQuadroBaseStrategyPropertyGridPopUp\xaml.cs - the type or namespcae name wpfPropertyGrid does not exist in the namespace
ATSQuadroBaseStrategyPropertyGridPopUp\xaml.cs - the type or namespcae name PropertyGrid does not exist in the namespace
Looks to be missing these two Property grid files potentially?
I just copy and pasted over a couple of time because i am really interested in programming over the GUI and advanced coding if theres any way you could help or reupload a Ninja .zip addOn that would be super sweet!
Post a comment below if anyone else has had same issue

Please read the whole read me and follow the exact steps to install and setup post install:
Get the latest Zip file from the Front page  > Code button
https://github.com/MicroTrendsLtd/NinjaTrader8


update CODEOWNERS with smoke test owners

This change (arbitrarily) selects code owners for the Smoke Tests pipelines. You will receive email notifications from Azure DevOps when the smoke tests fail. If someone else should be in your place please comment here.
What are smoke tests?
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/198/Smoke-Testing
Who is being subscribed?
@lmazuel @chlowell @annatisch @rakshith91 @shurd

Hi @danieljurek - could we add @southpolesteve for Cosmos alerts?


Roll Engine from 6de212bdaeb8 to 39d4a111e1a6 (7 revisions)

https://github.com/flutter/engine/compare/6de212bdaeb8...39d4a111e1a6
2021-06-10<EMAIL_ADDRESS>[web] Allow some more nulls in platform_dispatcher. (flutter/engine#26626)
2021-06-10<EMAIL_ADDRESS>Roll Skia from 9d1cc0510039 to ecc8e3bc043e (2 revisions) (flutter/engine#26692)
2021-06-10<EMAIL_ADDRESS>Remove compilation trace saving. (flutter/engine#26642)
2021-06-10<EMAIL_ADDRESS>[Android TextInput] clean up nested batch edits in closeConnection() (flutter/engine#26628)
2021-06-10<EMAIL_ADDRESS>Revert "Add support for native callbacks to the macOS embedder test harness (#26623)" (flutter/engine#26693)
2021-06-10<EMAIL_ADDRESS>Updates the objectc docs script to use env variables. (flutter/engine#26666)
2021-06-10<EMAIL_ADDRESS>Roll Skia from d2e096069691 to 9d1cc0510039 (4 revisions) (flutter/engine#26691)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.

The test that failed here passed in the previous autoroller attempt with the following PRs:
2021-06-10<EMAIL_ADDRESS>Roll Skia from 9d1cc0510039 to ecc8e3bc043e (2 revisions) (flutter/engine#26692)
2021-06-10<EMAIL_ADDRESS>Remove compilation trace saving. (flutter/engine#26642)
2021-06-10<EMAIL_ADDRESS>[Android TextInput] clean up nested batch edits in closeConnection() (flutter/engine#26628)
2021-06-10<EMAIL_ADDRESS>Revert "Add support for native callbacks to the macOS embedder test harness (#26623)" (flutter/engine#26693)
2021-06-10<EMAIL_ADDRESS>Updates the objectc docs script to use env variables. (flutter/engine#26666)
2021-06-10<EMAIL_ADDRESS>Roll Skia from d2e096069691 to 9d1cc0510039 (4 revisions) (flutter/engine#26691)

If this failure is not a flake, the cause is flutter/engine#26626


[4.0.1] Different style of rendering on different server

I have my wordpress site, on my local machine, and on online server. They are exact replica, as they have same plugin (and their version) and same theme and everything. I put a Select2 plugin and it works like charm on my local setup, but when I upload it online, it doesn't show Select2 (or zero width) select is shown. There is no javascript error.
later when I add select2({width: '100%'}) to init, it shows Select fine, but select[mulitple] are still non visible, but if you click on placeholder it show options and we can select from it, but no background is loading.
This can be seen here: http://dev.reeflifesurvey.com/demo-search/
Here is my local install's view, online view can be seen on above url.

EDIT: I also notice in offline/local machine it render a SPAN tag for select after the select tag, but in online view it render a div tag before my select tag, why there is such difference?

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.

Kevin, I found that you are right and the problem was this plugin Ultimate member, they include the older version of select2 in their code (and they do not even mention they are using select2 in that file . um.min.js)
I raise a objection there : https://github.com/ultimatemember/ultimatemember/issues/66 you might be interested.

@archergod, select2 is in MIT 2 License.

@champsupertramp Only newer versions of Select2 (4.0.0 and up), older versions were licensed under Apache/GPLv2. In any case, that's an issue to be handled elsewhere.
@archergod Good to know that you were able to track down the issue.


Client FAQ forces client restart

Windows 10.  Advanced -> FAQ and try to add a question.  I get this error and must force quit client.

@skcin Convert this to a link to gridcoin.us?

Closed by #1087.


State information belongs in /var/lib/cups, not /etc/cups

Version: 1.3.9
CUPS.org User: lamont
Section 5 of the FHS describes the /var hierarchy, and notes that /var/lib is for "Variable State Information"
"
Purpose
This hierarchy holds state information pertaining to an application or the
system. State information is data that programs modify while they run, and that
pertains to one specific host. Users must never need to modify files in /var/
lib to configure a package's operation.
State information is generally used to preserve the condition of an application
(or a group of inter-related applications) between invocations and between
different instances of the same application. State information should generally
remain valid after a reboot, should not be logging output, and should not be
spooled data."
Looking at /etc/cups/printers.conf, the following variables appear to be State, and NOT configuration:
State
StateTime
StateMessage
The timestamp in the '@ Written by cupsd on YYYY-MM-DD...' line is also far more state-like than configuration, unless the timestamp is specifically because of user configuration changes.
Similar logic can be applied to the other files.

Why isn't it possible to move State, StateTime, Attribute marker-levels and Attribute marker-change-time from /etc/cups/printers.conf to another file to /var/lib/? It's about the current state of the printer and not about the configuration?

I confirm that according to Filesystem Hierarchy Standard (FHS) /etc is for (static) configuration files. Administrators can store their configuration files there. Status information like printer state, jobs, dynamic (variable) values like attributes requested from the printer should be stored in a subdirectory of /var, if the information should still be available after a reboot, or a subdirectory of /run (e.g. /run/cups), if the information does not make sence after a reboot (like file or process locks). (/var/run on Fedora is a symlink to /run.)
Fedora cups package already uses some directories in /var:
rpm -ql cups|grep /var
/var/log/cups
/var/run/cups
/var/run/cups/certs
/var/spool/cups
/var/spool/cups/tmp
But there is no subdirectory like /var/lib/cups for status information. Files like subscriptions.conf, printers.conf, maybe subdirectory ppd too, or at least the dynamic parts of these files, should go to files in /var or /run. /etc should not be modifies by services on a regular basis, only if the administrator requests configuration changes.
I think also the (dynamic) list of printers and there configuration can be stored in something like /var/lib/cups, as long a these files are only written by cups (and cups supplement services like cups-browsed).

Does the state information need to be user-editable? It's just about this information and not about the configuration which should stay in /etc. Just move that state information to /var/lib and everyone is happy.

Dear Michael,
I think it is a principal design problem to use the same file for user editing the configuration and updates by program. This results in the classic problem with simultaneous writers and readers where one  change / write may be lost in some situations.
I see no good reason to mix printer configuration files with status information files, except that your program need to know which information it should read and write to which file. cups need to open some more file (one if it uses a status file for all printers, or more if one file for each printer), and the code needs to be adapted for this change. But that's all.
The advantage would be that configuration files in /etc/cups can be read-only for cups itself, and in can watch for changes and merge them into the runtime configuration, and / or read them at startup. There will be no problem any more if an administrator changes the file while cups is running. Even may cups change the configuration file if an administrator wants to set a configuration option by cli (e.g. lpadmin) or web interface instead of editing the files, that does not contradict the separation of status information.
I only see advantages in separating configuration files and state and dynamic configuration files - apart of the fact, that cups code needs to be changed. Which disadvantages do you see?

Folks, we are not changing how things work in the current implementation of cupsd after 20 years.
In the future, when we make major architectural changes (and those are coming), we will revisit how printer configuration and state information is stored, and take into account all of the various filesystem "standards" that exist.


Update to latest machine parameters [v0.4.1] + packet drivers

@cjellick @will-chan

Unrelated test failure - test_link_remove_instance_restart

lgtm

actually, should we upgrade the machine version in this pr as well?
...and the gms version for that matter as well

@cjellick yes, we should.

LGTM

reLGTM


Add UI layouts and CSS

CSS skinning work in progress.
Will work on CMDoController, CMDoTaskBox, CMDoTaskCategory, Calendar.

Good job. Will only accept pull if design is complete, stable and ready for v0.2.
Kutgw.


Flight Recorder refer to Zulu only

Flight Recorder refer to Zulu only, how to run Flight Recorder with the  MS build of OpenJDK , for Java 11 & 17 ?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: df68e904-7b05-38ba-4203-50eb8491946f
Version Independent ID: 921377f7-e428-143d-70e4-c9efc25e41d1
Content: Configure Java apps - Azure App Service
Content Source: articles/app-service/configure-language-java.md
Service: app-service
GitHub Login: @JasonFreeberg
Microsoft Alias: jafreebe

@ezYakaEagle442 Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Zulu mentions have been removed. #please-close


Multiple Android Emulators for E2E Tests in CI

Description
Enabled multiple devices for Android test runs.
Other changes
N/A
Tested
Tested locally on Android.
How others should test
Does not need to be tested by QA.
Reviewers should view the test runs for Android related to this PR.

Android E2E
iOS E2E

Related issues
N/A
Backwards compatibility
Yes

Looking forward to this!!

Hey @MuckT since "How others should test has n/a" hence we are skipping this PR


Fixed typo

Please verify the new semantics of the sentence are correct.
I assume they are from reading changelogs.

Your fix is exactly correct!
Unfortunately, I should probably tidy up the text in different ways. That feature has landed, for example. :D But than you very much for the fix!


Append environment variable name to flag usage

Hi!
I think that will be useful for people like ops, who prefers to see help instead of looking at source code to determine env prefix. Format is the same as in lib jessevdk/go-flags.
Example (prefix: test):
Usage of test:
  -batch int
    	Number of messages for one transaction. [env TEST_BATCH] (default 100)

I signed it


added applicationCmpnumber field and updated application number to ha…

…ve filingNumber

Summary by CodeRabbit
Release Notes

New Features

Introduced a new constant PENDINGAPPROVAL for status management.
Added a new field applicationCMPNumber to the Application model, enhancing data storage.
Updated application workflow logic to enrich application numbers based on status.

Improvements

Enhanced SQL query capabilities to include applicationCMPNumber, improving data retrieval.
Improved application number generation and storage processes.

Bug Fixes

Adjusted tests to align with updated application number formats and query structures.

Chores

Updated database schema to include the new applicationCMPNumber column.

refer this pr https://github.com/pucardotorg/dristi-solutions/pull/943


chore: cleanup in prep for uds-core baseline changes

I'm confused about what took place here. Inside joke? I want to be a part of one some day.

@anthonywendt this was meant to be a cleanup of the fresh start repo for sonarqube, following the unbrella/UDS Core patterns. It was not meant to be in this repo I don't think though, instead meant for a fork of the repo, which I believe was here - https://github.com/defenseunicorns/uds-package-sonarqube

@anthonywendt this was meant to be a cleanup of the fresh start repo for sonarqube, following the unbrella/UDS Core patterns. It was not meant to be in this repo I don't think though, instead meant for a fork of the repo, which I believe was here - https://github.com/defenseunicorns/uds-package-sonarqube

Haha makes sense. I figured as much. I just actually looked at my sea of github emails and saw this.

@mjnagel said it kindly, i mucked up a PR and opened against the forked upstream (this repo) instead of origin. please forgive me!

Don't apologize! I just wanted to lure you all back in so I could feel like I was part of your friend group. My wife saw me chuckle while reading your reply.  She muddled under her breath, "wow, he's not a loser". Although maybe she said "wow, what a loser". Either way, thank you!

Don't apologize! I just wanted to lure you all back in so I could feel like I was part of your friend group. My wife saw me chuckle while reading your reply.  She muddled under her breath, "wow, he's not a loser". Although maybe she said "wow, what a loser". Either way, thank you!

@anthonywendt hahaha!!!  next time someone opens a bogus PR (probably will be from me again), i'm hoping someone closes it with a single i love inside jokes comment.


[pulsar-functions] move metricsPort to InstanceConfig

Master Issue: #9177
Motivation
As discussed in #9318, both @zymap and @wolfstudy suggested, to add metricsPort as a field of InstanceConfig.
Modifications

add metricsPort to InstanceConfig
add hasValidMetricsPort to InstanceConfig to check if metrics port is valid
applied changes to k8s runtime & process runtime

Verifying this change

[ ] Make sure that the change passes the CI checks.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Carl Sandburg College

https://www.sandburg.edu/
https://www.sandburg.edu/Academics/Pathways/CTE/Information Technology.html

@satoterin Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Error on submit in prescreening_results

We reached this error two when Kara attempted to run through pre-screening today.
Not sure why.
She had used the back button to go back and forth a few times between new_prescreening/ and prescreening_basic/ and that may have affected it.
She then started over again and tried different answers, and got it to work. My guess is that it either had to do with using the back button or giving specific answers.
Needs some manual follow-up testing of using back button and entering different answers.
 I can fix this today.


Parse CALL family

plus some adjustments (being a bit wiser ;-))

@MarkusAmshove first time I see duplication. And I see why. But is it advisable to fix this? (and how?)

You could create a common class for both and inherit it in both classes, since they seem identical

Unsure how to, is there an example I can steal from?

It seems to not be possible here, because one extends StatementNode and one StatementWithBodyNode.
Just ignore it to not over-complicate it, we'll ignore the duplication here :-)


Feature for architecture/additional C++ parameters

It will be great to have a way to pass a target CPU architecture/additional C++ parameters to TF build.
I've tried to add them after "-std=c++11" in CMakeLists.txt but they seem to be overridden somewhere...
Thanks!
Dmitry

Closing for inactivity. Feel free to reopen if something changes.


making .bib file available in the log folder

Hello,
for those of us using LaTeX to write papers it would be great to include the .bib file used to generate the CITATION files. It's a bit cumbersome to find it in a singularity container, so that I can simply copy those references in the bib file for my article. For the reference, if anybody else is interested in how to dig it up in your singularity container, here is the command:
singularity exec fmriprep-X.X.X.img cat /usr/local/miniconda/lib/python3.6/site-packages/fmriprep/data/boilerplate.bib

Thanks!

Yes, this would be good to include in the derivatives. Would you be interested in contributing a patch?

Sure, just point me in the direction of a script that generates CITATION files and I'll send a pull request.

@oesteban The CITATIONs were your baby...

CITATION versions are generated here: https://github.com/poldracklab/fmriprep/blob/db956bb9ec43256ad9e31904f9e438ea6170fac8/fmriprep/cli/run.py#L749
FYI, the bib references are appended into the html report, within the Latex tab.

I think if we're going to output the .tex file, we might as well output the .bib file, though. So we should probably just add a shutil.copyfile() there.

Ah, that's true, they are in .html report of every subject, I haven't looked there actually. Still, it would save some time looking for them if the whole bib file is simply placed in the logs folder as well.

I filed a quick pull-request: #1446
I have to admit, didn't do the whole patch thing as described in the fmriprep docs, it seemed small enough change to go without it.

Closed in #1446.


[Improve] Make fully qualified string type name explicit

Closes #674.

This is definitely an improvement, I'll approve it.
Technically a name is "fully qualified" if it starts with :: (for example ::std::string)
But that might be too much of a technicality for this syllabus and I don't know any better name.

I was hesitant to write that, but I think it is the closest I can get to a correct term. If we find something better, I'm happy to change it again.


Example pages are not accessible

Going to this url provides the following error: https://examples.dndkit.com/

Same here

+1

Same

Same

can be closed, it's available as of today 20240505


The Jolly Dodger: Switching to Python editor failed

Describe the bug
The Jolly Dodger: Switching to Python editor failed
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#
2.Game Jam----->The Jolly Dodger----->Open in Editor
3.Switch to Python editor
Actual behavior
The Jolly Dodger: Switching to Python editor failed

Additional context
1.OS: Windows(rs6)
2.arcade version: 1.4.3
3.Microsoft MakeCode version: 6.8.30

Same issue happened in "In the Depths".

Not planning to improve python conversion in the near future


ONNX conversion of FiveK model?

Thank you to the author for this amazing project. I would like to convert the FiveK model to ONNX format for use in VapourSynth to process video clips. I have successfully converted the model with the following code, but the output image I get with the ONNX model is not the same as when I run the PyTorch model in the conda environment. Is there anything I need to correct in the following code for the conversion?
import torch
import torch.nn as nn
import torch.onnx
import yaml
from basicsr.models import create_model
from basicsr.utils.options import parse

# Load the YAML configuration file
with open('Options/RetinexFormer_FiveK.yml', 'r') as f:
    opt = yaml.safe_load(f)

# Dodajte 'is_train' ključ u konfiguraciju
opt['is_train'] = False

# Dodajte 'dist' ključ u konfiguraciju
opt['dist'] = False

# Create the PyTorch model
model = create_model(opt).net_g

# Load the pretrained weights
checkpoint = torch.load('pretrained_weights/FiveK.pth')

try:
    model.load_state_dict(checkpoint['params'])
except:
    new_checkpoint = {}
    for k in checkpoint['params']:
        new_checkpoint['module.' + k] = checkpoint['params'][k]
    model.load_state_dict(new_checkpoint)

# Set the model to evaluation mode
model.eval()

# Define the input shape for the ONNX model
input_shape = (1, 3, 256, 256)  # Adjust the input shape as needed

# Create a dummy input tensor
dummy_input = torch.randn(input_shape).cuda()

# **Export the model to ONNX format with FP32 precision**
with torch.no_grad():
    torch.onnx.export(
        model,
        dummy_input,
        "retinexformer_fivek_Opset-17.onnx",
        opset_version=17,  # Choose an appropriate opset version
        input_names=['input'],
        output_names=['output'],
        dynamic_axes={'input': {0: 'batch_size', 2: 'height', 3: 'width'},
                      'output': {0: 'batch_size', 2: 'height', 3: 'width'}},
        export_params=True,
        # **Specify FP32 as the desired data type**
        do_constant_folding=False,
    )

Thank you very much in advance. Best regards.

It was problem cause my VS script not using sRGB color space. Everything is OK with converted model. (tested with chainner)
However, during pytorch inference I am getting error:
python Enhancement/test_from_dataset.py --opt Options/RetinexFormer_FiveK.yml --weights pretrained_weights/FiveK.pth --dataset FiveK
export CUDA_VISIBLE_DEVICES=0
dataset FiveK
Not using Automatic Mixed Precision
===>Testing using weights:  pretrained_weights/FiveK.pth
C:\Users\Miki\Retinexformer\input
C:\Users\Miki\Retinexformer\input
0%|                                                                                | 0/47 [00:00<?, ?it/s]
Traceback (most recent call last):
File "C:\Users\Miki\Retinexformer\Enhancement\test_from_dataset.py", line 251, in
restored_1 = model_restoration(input_1, model_restoration)
File "C:\Users\Miki\anaconda3\envs\cdformer\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "C:\Users\Miki\anaconda3\envs\cdformer\lib\site-packages\torch\nn\parallel\data_parallel.py", line 169, in forward
return self.module(*inputs[0], **kwargs[0])
File "C:\Users\Miki\anaconda3\envs\cdformer\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
TypeError: RetinexFormer.forward() takes 2 positional arguments but 3 were given

Hi, thanks for you interests. it seems that you give three augment while three augments are needed. besides, windows system
is also not suggested. Please follow the readme to install the environment and run our code.

Hey @zelenooki87 could you share the code for converting to onnx and doing inference in pytorch? thank you


Request failed, status 503

First of all, thanks a TON for developing this brilliant plugin! I really appreciate your selfless, hard work!
I'm getting this Request failed, status 503 error.

I did check the already existing issues here, #9 #14 #28 #39
I do have a lot of credits in my OpenAI account, so that's not an issue.
My API is integrated correctly.
The text-generator plugin worked perfectly fine 2-3 weeks ago. Not sure if some sort of an update crashed it but I'm getting other errors as well. But this 503 error is most prevalent, that's why I'm posting it here.
I'm not getting rate-limited because I'm only trying to generate 200-300 words at once.
Thank you again for your time and efforts! Highly highly appreciated!
BTW, I'm on Linux Pop!_OS 22.04 LTS x86_64

I think it is an OpenAI API issue. check the following post https://community.openai.com/t/status-code-503-that-model-is-currently-overloaded-with-other-requests/31433.


error in statuses_lookup

Hi! i tried with different codes and always get:
api         | tweepy.error.TweepError: [{'code': 34, 'message': 'Sorry, that page does not exist.'}]
Any clue?
Last test:
api = tweepy.API(auth)
# list of status IDs to be fetched
id_ = [1266978261701210112,<PHONE_NUMBER>012111360,<PHONE_NUMBER>648898049]

# fetching the statuses
statuses = api.statuses_lookup(id_)

Thnaks!

I'm unable to reproduce this:
>>> id_ = [1266978261701210112,<PHONE_NUMBER>012111360,<PHONE_NUMBER>648898049]
>>> statuses = api.statuses_lookup(id_)
>>> len(statuses)
3

Are you sure you're properly authenticated? Can you provide a full traceback and reproducible example (MCVE/SSCCE)?


App behaviour after selection of different basemap

Let me know if this is something else than "Code Health".
Testing in the field with potential users I recognized some confusion with the pane for changing base map layers.

After choosing e.g. the satellite base map, the pane just stays in place. Users were consistently waiting for something to happen and didn't know what to do when nothing happened. I would suggest to either make the pane disappear automatically after having selected the base map layer, or to implement an "OK"-button or an "X"-button to make the pane go away.
Thanks for the consideration.
Best, Jonas

@rawbzz for consideration in future iterations!

@jo-spek "Code health" pertains to the Kotlin code itself. Improvements to the UI would be considered "Feature requests", I've updated accordingly. Thanks for the input!


Document architecture and interfaces for SQL statement & results parsers

Design required classes and interfaces according to SOLID principles and potentially GoF design patterns. Document them in GitHub wiki.

Superseded by #67


Can I increase the ability to continue reading other resources when I encounter an error?

Can I increase the ability to continue reading other resources when I encounter an error?

Yes, download source code and change it anyway you want


Add Muller's method

Checklist

[x] Appropriate tests were added
[x] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
[ ] Any new documentation only uses public API

Additional context
This implements the method discussed in SciML/NonlinearSolve.jl#403.

Does this method only work for scalars?

Yes. It only works for univariate, scalar functions.

@ChrisRackauckas how should we go about this? This is a significant deviation from how the other problems need to be framed

Treating it as an IntervalNonlinearProblem solver and then getting the third guess as the midpoint would be fine.

That sounds like a good way to proceed


[Bug]: Reversing tokens via the selector when the chart is loading does nothing

What happened?
Reversing tokens via the selector when the chart is loading does nothing
How?

Navigate to trade route
While the chart is still loading, reverse the tokens via the token selector
Nothing happens

What was Expected?
Tokens are reversed
Relevant log output
No response
What browser(s) are you seeing the problem on?
No response
What wallet are you seeing the problem on?
No response

NOTE: the token selector does show a loading indicator but at times, the loading indicator does dissapear before the chart finishes loading giving the impression that the tokens are indeed swappable


Could we use ImageLoadingOptions when ImagePipeline.shared.rx.loadImage?

Hi, I have a small question. ✋
I know that in Nuke, it has awesome feature called ImageLoadingOptions.
And my question is is it possible to use this option when I use Nuke.ImagePipeline.shared.rx.loadImage?
While I am reading your documentation I couldn't find any solution for this.
If there are any solutions, please tell me how.

Hi, could you please elaborate what the use case is?

My question is simple,
Is there any way I can use transition animations when I use Nuke.ImagePipeline.shared.rx.loadImage?
(I know that I can solve this when Nuke.loadImage by using ImageLoadingOptions but not in rx situation)

Is there any way I can use transition animations when I use Nuke.ImagePipeline.shared.rx.loadImage?

Well, currently you will have to write this code yourself. Nuke.loadImage currently works with ImageRequest, I can't see how it could be generalized more to work with RxSwift.

Okay, Thanks for answering the question 👍


Add pgbouncer grafana dashboard and prometheus rules to the charts

Feel free to propose improvements on https://github.com/cloudnative-pg/grafana-dashboards for a Pooler dashboard.
The cluster chart already includes a list of Prometheus Rules.


react-server: throws an exception when using use

Description
I suspect this line of code is throwing unhandled exceptions from the use method.
At least our Sentry is giving this:

And I suspect this might be on the middleware or somewhere. I of course, have no idea where exactly on your code, but hey, might be fun to investigate.
Mandatory reproduction URL (CodeSandbox or GitHub repository)
https://github.com/nodejs/nodejs.org
Reproduction description

Navigate to /
Apparently the Error is suppressed, so you can't see them anywhere (console logs, etc) but Sentry is capturing them, so I suspect this should be handled differently.

I also see no documentation on react.dev around use, what is it and what it does?
Expected behaviour
No Exceptions

Here are the docs for use.
Earlier this week, I've improved the docs for the RSC integration, this might help to provide some context: Using internationalization in Server Components
Generally, you can pick between an async and a hooks-based API, based on if you use APIs from next-intl in async or shared components (the latter allows to use non-stateful hooks, like useId—and also useTranslations).
The code snippet you've linked to points to error handling I've added, back when React/Next.js didn't explain much when a user tries to accidentally use hooks in an async component. The error message still isn't great, but at least the React ESLint plugin shows an error now:

Due to this, we could consider removing the custom error handling now, but I'm wondering if Sentry would catch the promises that React/Next.js throws for various APIs like use, redirect etc. anyway. Maybe there's something to adapt on the Sentry side.

Here are the docs for use.
Earlier this week, I've improved the docs for the RSC integration, this might help to provide some context: Using internationalization in Server Components
Generally, you can pick between an async and a hooks-based API, based on if you use APIs from next-intl in async or shared components (the latter allows to use non-stateful hooks, like useId—and also useTranslations).
The code snippet you've linked to points to error handling I've added, back when React/Next.js didn't explain much when a user tries to accidentally use hooks in an async component. The error message still isn't great, but at least the React ESLint plugin shows an error now:

Due to this, we could consider removing the custom error handling now, but I'm wondering if Sentry would catch the promises that React/Next.js throws for various APIs like use, redirect etc. anyway. Maybe there's something to adapt on the Sentry side.

It's worth trying imo. If you feel compelled to try :)

Hey @amannn just checking in if there's anything you can check here? Our Sentry is accumulating a few thousands of "errors" because of that. Even tho these users never reach the user.

It would be important to isolate the cause of the "errors" you're seeing in Sentry.
React throws promises in the implementation of use, that's the way it works and should not be considered an error.
This is the error message you're seeing:

Rethrowing the error is what next-intl does, therefore we're in line with the suggestion.
I don't know how the Node.js integration for Sentry works, but I'm wondering if something needs to be adapted on their side.
This could be a simple reduced snippet to test:
import {use} from 'react';

const promise = Promise.resolve('Hello');

function Test() {
 return use(promise);
}

If this is also reported by Sentry during an RSC render or SSR, then you might want to report this on the Sentry side.

It would be important to isolate the cause of the "errors" you're seeing in Sentry.

The errors are coming from next-intl more specifically your useHook file that wraps the server-side hooks with try/catch on the use statement

I don't know how the Node.js integration for Sentry works, but I'm wondering if something needs to be adapted on their side.

Using the Next.js one.

I'm making a change, I have the feeling this might be happening on a specific root level not-found. I've changed both the root layout and not-found page to be on /[locale]/ level, let's see what this does.

If this is also reported by Sentry during an RSC render or SSR, then you might want to report this on the Sentry side.

As you can see on the first screenshot, it's happening on a server component. And apparently still ongoing. I'm still investigating but I really can't see anything wrong on my side.

I'm still investigating but I really can't see anything wrong on my side.

I also don't think you're doing anything wrong, but neither do I think next-intl does.
If you're interested in solving this, I'd suggest you to try to create a minimal reproduction using the snippet I've mentioned and if this triggers Sentry, then this should be reported on their side. There's nothing that next-intl can do to improve the situation for you if this is the case.
If we find that the issue is caused by next-intl, then I'm happy to look into it, but we're missing an isolated reproduction that shows the root cause currently.

If you're interested in solving this, I'd suggest you to try to create a minimal reproduction using https://github.com/amannn/next-intl/issues/614#issuecomment-1825517808 and if this triggers Sentry, then this should be reported on their side. There's nothing that next-intl can do to improve the situation for you if this is the case.

I'm not sure how it makes sense to report this to Sentry. I genuinely this is happening because useHook surrounds a try/catch on the use statement, and this error is being triggered by React itself, which says that you shouldn't wrap use with try/catch... Isn't this the issue?

If we find that the issue is caused by next-intl, then I'm happy to look into it, but we're missing an isolated reproduction that shows the root cause currently.

Yeah, I can try that, but I wonder where to add this and where to test this... Where are you imagining that I should add this?

Rethrowing the error is what next-intl does, therefore we're in line with the suggestion.

https://react.dev/reference/react/use#suspense-exception-error by the docs here It feels that .catch() should be used and then rethrow the error? I might be misunderstanding here, but IO don't think it hurts to test a patched version of next-intl that does a different behaviour. It'd be more than happy to test a specific "patch" containing this change.

If this is also reported by Sentry during an RSC render or SSR, then you might want to report this on the Sentry side.

I don't think that snippet would throw any error, as the Promise is always resolving.

It's also written here that use should not be used within a try/catch block: https://react.dev/reference/react/use#dealing-with-rejected-promises

(I apologize if I'm annoying you with this issue) but I genuinely believe that next-intl is implementing use erroneously. And I honestly feel that it's worth a shot.

IO don't think it hurts to test a patched version of next-intl that does a different behaviour.

Sure, you can use patch-package and modify next-intl/dist/esm/react-server/useHook.js accordingly in your code base (the ESM build is used for the react-server condition).
Let me know if that makes a difference!

Interesting, with further investigation, I was able to replicate this issue with the patch.
Apparently it happens only on Not-Found pages (404)... I need to investigate more, but I have no idea why Vercel 404's would be causing this.

Okay, diving deeper. By making the not-found page client-only (use-client) the issue has resolved.
I have the feeling that Next.js was trying to render this Not Found page (that uses our Locale Layout (/[locale]/layout.tsx) and probably something in between was not working correctly.
Could be the middleware, or the way that Next.js would actually skip the dynamic segment, or the context of unstable_setRequestLocale would be lost... Who knows.
We can close this issue. The outcome here would be: Probably when using next-intl to make not-found pages use "use client"; if you're using the App Router.

Ok, let's close this issue then. Thank you for posting your findings!
To follow up here again this would require further analysis on the root cause and an isolated reproduction in order to make this actionable for Sentry or next-intl.

I got the same error with Sentry, I try the fix with the not-found file: https://github.com/ixartz/my-app-sentry/blob/main/src/app/[locale]/not-found.tsx
But, I still get the error.
It's a new Next.js project starting from scratch. Without next-intl, I didn't get any error. After adding next-intl, I'm starting to see the error on my local environment.

Sentry maintainer here. I think we somehow need to ignore these errors inside the Sentry SDK. They are a react mechanism and used for control flow (e.g. throwing promises is used for suspense).

Sentry maintainer here. I think we somehow need to ignore these errors inside the Sentry SDK. They are a react mechanism and used for control flow (e.g. throwing promises is used for suspense).

What I wonder, Luca, is. If these are being thrown inside react itself, is it due to something being done erroneously?

Sentry maintainer here. I think we somehow need to ignore these errors inside the Sentry SDK. They are a react mechanism and used for control flow (e.g. throwing promises is used for suspense).

What I wonder, Luca, is. If these are being thrown inside react itself, is it due to something being done erroneously?

I honestly don't think so. I know way too little about RSCs yet (as probably everybody else) to make a 100% call on this but I would say that this is just how React works now with Suspense boundaries and we need to work around it.
I can imagine that by turning certain components into client components you disabled the mechanism that throws this "Error".

I am still getting this error as well, how come this issue has been closed. This definitely is something that needs to be fixed 🙏


Leave metrics empty if not specified

Issue:

we had a bug when user tries to explore a table generated from sqllab visualization flow, when columns are selected for table viz, count metrics is applied by default.

Solution:

since we support column-only table viz, there's no need to add count metrics by default

needs-review @mistercrunch

LGTM, please make sure that it gets to prod ASAP


Add support for Ubuntu 20.04 compute nodes

Support for 20.04 ideally
NDv4 won't support it, 18.04 would be supported too

18.04 is now supported. Renamed the title to be Ubuntu 20.04


[KOGITO-3094] - Enable persistence selection in Data Index controller

Signed-off-by: spolti<EMAIL_ADDRESS>See: https://issues.redhat.com/browse/KOGITO-3094
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

@ricardozanini Please correct me if I am wrong.
Actually I have completely different opinion about its implementation approach. In KOGITO-3039 we have completely seperated infra layer from KogitoService. KogitoService could bind to any infra like Infinispan, Redis, Mongo or Kafka just by provides its relevant KogitoInfra references.
In our case if user want to bind its data-index service with MongoDB then it could create relevant KogitoInfra CR and just provides its references as dependent infra inside data-index CR. To accomplish this we should create new implementation of KogitoInfra as we do for Infinispan/kafka and Keycloak.
Now point come when we need some identier in Kogito-images to identify which jar operator should use(Infinispan/Mongo). Currently we accomplish this by setting identifier inside Env var of deployment which we fetch in images. With new approach we should keep doing same thing, just this DATA_INDEX_PERSISTENCE env var should be set in KogitoInfra CR which will automatically binds to Env var of deployment.

@vaibhavjainwiz yes, that's what I said in my comment. I talked to @spolti last night, he will refactor.
About the KogitoInfra, it's meant to bind third party CRs with ours, so in this particular scenario here, it will not fit. Not until we have integration with MongoDB operators out there.
For now, the operator will set the env to the image based in the configuration passed through the CR.

I'll remove the comments after the new approach is ready, please ignore them :)

@ricardozanini Untill that config approach is not ready, could we ask user to directly provides DATA_INDEX_PERSISTENCE property in env var directly like
apiVersion: app.kiegroup.org/v1alpha1
kind: KogitoDataIndex
metadata:
  name: data-index
spec:
  env:
     - name: DATA_INDEX_PERSISTENCE
       value: mongodb
  replicas: 1

with this change operator don't need to do following :

first fetch JAVA_OPTIONS from envs,
extract -Dkogito.persistence.type property from JAVA_OPTIONS
Set DATA_INDEX_PERSISTENCE again in envs

@spolti I have doubt abouts required properties. Here we are discussing about two differents kogito.persistence.type and DATA_INDEX_PERSISTENCE. Do we require both them ? I checked kogito-images implementation to support mongoDB persistence, as I understand it only require DATA_INDEX_PERSISTENCE property as identifier to pick between data-index persistence jar.
@ricardozanini @sutaakar With configMap implementation, all properties user provides under config are appended to its application.properties only not in its envs. But kogito-images expecting to receive DATA_INDEX_PERSISTENCE prop in its env. I am not sure if it could work?

IMHO we don't have to care about kogito.persistence.type as it is set in the specific Data index jar. So we need just to choose proper runner on image side. Simplest way could be to use env variable as it is easy to use it in case user runs the Data index image by itself outside of cluster.

My understanding on the "kogito.persistence.type" system property is that it will be used for kogito app that has the dataindex-addons, right?
After the config property is added to the spec then it will be used by a kogito the app and by the data index to define the correct persistence provider.
if we decide to only use the DATA_INDEX_PERSISTENCE env, then when user wants to switch to mongo db, he will have to make 2 configurations, set the system property and this env.
This is my understanding, please correct me if am I wrong.

After checking the documentation it seems that kogito.persistence.type is needed for any Kogito application/service in case it will use other than Infinispan persistence.

After checking the documentation it seems that kogito.persistence.type is needed for any Kogito application/service in case it will use other than Infinispan persistence.

As kogito.persistence.type is applicable for all Kogito application/service, we could receive it under Spec of KogitoServiceSpec  rather then in EnvVar.
One question, what happen if user provide kogito.persistence.type=mongodb in travels service but forget to mention it in visas?

I'll remove the comments after the new approach is ready, please ignore them :)

@spolti I had raised PR(https://github.com/kiegroup/kogito-cloud-operator/pull/610) for new approach. Could you please remove commented code now

This persistence switch thing should be an unique use case for the Data Index. Since we already have KogitoInfra specifying the Infinispan implementation, we can use that as a hint to configure the image with the right ENV var. But that's not reliable since I can use whatever server I have at my disposal, like onprem architectures.
Having said that, I'm not a fan of adding a persistenceType in the CRD, but would make sense for Data Index ONLY since we need to change the image based on that.
It's not ideal, but I think having two images in this scenario would make WAY more sense:
kogito-data-index-mongodb
kogito-data-index-infinispan

Setting the image in the Data Index CR spec.image and the configuration into spec.config.

One question, what happen if user provide kogito.persistence.type=mongodb in travels service but forget to mention it in visas?

This persistence switch thing should be an unique use case for the Data Index. Since we already have KogitoInfra specifying the Infinispan implementation, we can use that as a hint to configure the image with the right ENV var. But that's not reliable since I can use whatever server I have at my disposal, like onprem architectures.
Having said that, I'm not a fan of adding a persistenceType in the CRD, but would make sense for Data Index ONLY since we need to change the image based on that.
It's not ideal, IMO. I think having two images in this scenario would make WAY more sense:
kogito-data-index-mongodb
kogito-data-index-infinispan

Setting the image in the Data Index CR spec.image and the configuration into spec.config. Done. No conditionals. And the image would have its purpose on itself.
Otherwise, we just document that the env variable should be set to elect the persistence.

Not sure if I agree with it, it will increase the number of images we'll have to maintain, if data index supports other types of persistence, what you are proposing new images will need to be created.
The initial idea was use persistenceType on spec, which now, we'll be moving to config.spec and maybe keep the support for envs, just in case, remove the env from operator at all.
Using only the spec.config would be a single point of configuration instead have to set the data-index image and the property for the apps.

@vaibhavjainwiz @sutaakar @ricardozanini can you please take a look again?
Once we have it merged I'll create a PR to update the docs.

Not sure if I agree with it, it will increase the number of images we'll have to maintain, if data index supports other types of persistence, what you are proposing new images will need to be created.

How complex/hard is to maintain a sibling image? :D I believe it will be way easier than additional code to the operator.

The initial idea was use persistenceType on spec, which now, we'll be moving to config.spec and maybe keep the support for retrieving it from JAVA_OPTS env, or remove it and rely only on the spec.config.
Using only the spec.config would be a single point of configuration instead have to set the data-index image and the property for the apps.

This idea was ok at once, but an user can config a Kogito Service via:

env variables set in the spec.env attribute
any java properties that can be read by the application via spec.config attribute
a custom ConfigMap attached to the CR via spec.configMapProperties

So we will read everything looking for this property? Since it's an application only property (not related to the image), I don't think it makes sense reading from spec.config. :thinking:
Of course, we can always use docs to emphasize that Data Index will ONLY switch the persistence type if:
spec:
    config:
    - kogito.persistence.type: mongodb

will be set.
But again, these properties suppose to be set only for the application runtime, not infrastructure. :disappointed:

I like the separate image approach.
The image size will be smaller. The scripts in the image are simpler. Less configuration in the operator.
Of course the downside is that we need to take care of one (or several) more images.

I like the separate image approach.
The image size will be smaller. The scripts in the image are simpler. Less configuration in the operator.
Of course the downside is that we need to take care of one (or several) more images.

That's my point, imagine if in the future we have somehow, 20 kind of persistence types, which would result in 20 more images.
if we do on operator the logic will be the same for all.
and the downside of this would be the image size on future.
Anways, let's vote and decide it ASAP.

@radtriste @vaibhavjainwiz @Kaitou786 ^ please chime in

IMO having a single image seems better to me. No need to maintain n number of images (for each type of persistence we might support in the future).

The different images won't be so much different in fact. just our testing might be longer.
I would go for multiple images as it will be easier to maintain in the future. and it would ease the complexity on operator's side.

I also think maintaining multiple image would be better approach. Every time new persistence come, developer don't need to change existing working code. He could easily create new image by assembly existing CEkit modules. With this, we also sure that new functionality won't impact existing functionality and tester also don't need to test all functionality of like data-index. If changes are done in data-index-mongo image then testers only need to test mongo related functionality.

closing, replaced by https://github.com/kiegroup/kogito-images/pull/265


Selete op: analyze tools and int8 support

1. System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): 20.04
TensorFlow installation (pip package or built from source): pip
TensorFlow library (version, if pip package or github SHA, if built from source): pip

2. Code
Provide code to help us reproduce your issues using one of the following options:
Hi, after using tflite in runtime, i meet serval problems and they are related to selete op, e.g. model convert, int8 supprt and reduce library size. So i open this issue.
Thanks for you reply.

Is the int8 only support model without selete op.
here is the doc code, and you can see that selete op model is not support, and it fail too even i add the selete op in supported_ops.

import tensorflow as tf
converter = tf.lite.TFLiteConverter.from_saved_model(saved_model_dir)
converter.optimizations = [tf.lite.Optimize.DEFAULT]
converter.representative_dataset = representative_dataset
converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS_INT8]
converter.inference_input_type = tf.int8  # or tf.uint8
converter.inference_output_type = tf.int8  # or tf.uint8
tflite_quant_model = converter.convert()

It there any way or tool in python i can quickly find out which keras layer depend on selete op.
i find it's confusing when i want to remove the layer with selete op or replace it. Just like the tflite convert log below, i can only know
tf.FusedBatchNormV3 and  tf.StridedSlice, but how to quickly know where i induce this op?

error: illegal scale: -7.049777e+305
loc(callsite(callsite("functional_3/mask_model_input_norm/FusedBatchNormV3@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.FusedBatchNormV3' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/dprnn_block_1/dprnn_layer_2/mask_model_rnn1_norm1/FusedBatchNormV3@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.FusedBatchNormV3' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/tf_op_layer_strided_slice_5/strided_slice_5@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.StridedSlice' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/tf_op_layer_strided_slice_6/strided_slice_6@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.StridedSlice' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/dprnn_block_1/strided_slice@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.StridedSlice' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/dprnn_block_1/strided_slice_1@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.StridedSlice' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/dprnn_block_1/dprnn_layer_2/mask_model_rnn1_norm2/FusedBatchNormV3@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.FusedBatchNormV3' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/dprnn_block_1/dprnn_layer_3/mask_model_rnn2_norm1/FusedBatchNormV3@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.FusedBatchNormV3' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/dprnn_block_1/strided_slice_2@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.StridedSlice' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/dprnn_block_1/strided_slice_3@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.StridedSlice' op is neither a custom op nor a flex op
loc(callsite(callsite("functional_3/dprnn_block_1/dprnn_layer_3/mask_model_rnn2_norm2/FusedBatchNormV3@__inference__wrapped_model_7151" at "StatefulPartitionedCall@__inference_signature_wrapper_17427") at "StatefulPartitionedCall")): error: 'tf.FusedBatchNormV3' op is neither a custom op nor a flex op
error: failed while converting: 'main': Ops that can be supported by the flex runtime (enabled via setting the -emit-select-tf-ops flag):
        tf.FusedBatchNormV3 {data_format = "NCHW", device = "", epsilon = 1.000000e-03 : f32, exponential_avg_factor = 1.000000e+00 : f32, is_training = true}
        tf.StridedSlice {_cloned = true, begin_mask = 0 : i64, device = "", ellipsis_mask = 1 : i64, end_mask = 0 : i64, new_axis_mask = 0 : i64, shrink_axis_mask = 2 : i64}
        tf.StridedSlice {begin_mask = 0 : i64, device = "", ellipsis_mask = 1 : i64, end_mask = 0 : i64, new_axis_mask = 0 : i64, shrink_axis_mask = 2 : i64}
Traceback (most recent call last)

Why BatchNorm not in buildin op
I may think BN is a buildin op because it is common op in NN, but the log is 'tf.FusedBatchNormV3' op is neither a custom op nor a flex op.

Hi @groovemaxRong ! Could you check these threads and try again ? Link 1, 2, 3 . Thanks!


DiscoveryPlus Show Italy Broken

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2021.12.27. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
When I try to download a free video (see the link in log), I have this error: <HTTPError 404: 'Not Found'>
Other videos of the same serie working fine.
Thank you
Verbose log
yt-dlp.exe --newline --max-downloads 100 -i -o "D:\Temp\dl\%(series)s %(season_number)dx%(episode_number)02d %(title)s.%(ext)s" -v --ignore-config --hls-prefer-native -Uv --verbose "https://www.discoveryplus.com/it/video/the-modern-baker/stagione-1-episodio-6-pizza-co"
[debug] Command-line config: ['--newline', '--max-downloads', '100', '-i', '-o', 'D:\\Temp\\dl\\%(series)s %(season_number)dx%(episode_number)02d %(title)s.%(ext)s', '-v', '--ignore-config', '--hls-prefer-native', '-Uv', '--verbose', 'https://www.discoveryplus.com/it/video/the-modern-baker/stagione-1-episodio-6-pizza-co']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, err utf-8, pref cp1252
[debug] yt-dlp version 2021.12.27 [6223f67] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.22000-SP0
[debug] exe versions: ffmpeg 2021-08-14-git-acd079843b-full_build-www.gyan.dev (setts), ffprobe 2021-08-14-git-acd079843b-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2021.12.27, Current version: 2021.12.27
yt-dlp is up to date (2021.12.27)
[debug] [DiscoveryPlusItaly] Extracting URL: https://www.discoveryplus.com/it/video/the-modern-baker/stagione-1-episodio-6-pizza-co
[debug] [DPlay] Extracting URL: https://discoveryplus.it/video/the-modern-baker/stagione-1-episodio-6-pizza-co
[debug] Using fake IP ??.??.???.??? (XX) as X-Forwarded-For
[DPlay] the-modern-baker/stagione-1-episodio-6-pizza-co: Downloading token
[DPlay] the-modern-baker/stagione-1-episodio-6-pizza-co: Downloading JSON metadata
ERROR: [DPlay] the-modern-baker/stagione-1-episodio-6-pizza-co: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output. (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.
  File "yt_dlp\extractor\common.py", line 717, in _request_webpage
  File "yt_dlp\YoutubeDL.py", line 3458, in urlopen
  File "urllib\request.py", line 531, in open
  File "urllib\request.py", line 640, in http_response
  File "urllib\request.py", line 569, in error
  File "urllib\request.py", line 502, in _call_chain
  File "urllib\request.py", line 649, in http_error_default

Duplicate of https://github.com/yt-dlp/yt-dlp/issues/2138

Works for me.
You must always use "--cookies cookies_from_free_subscription.txt" also for free videos.
[debug] Command-line config: ['--no-config', '-v', '-F', '--cookies', 'discoveryplus.com_cookies.txt', 'https://www.discoveryplus.com/it/video/the-modern-baker/stagione-1-episodio-6-pizza-co']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, err UTF-8, pref UTF-8
[debug] yt-dlp version 2021.12.27 [6223f67a8]
[debug] Plugins: ['SamplePluginIE', 'SamplePluginPP']
[debug] Python version 3.7.3 (CPython 64bit) - Linux-4.19.0-18-amd64-x86_64-with-debian-10.11
[debug] exe versions: ffmpeg 4.1.8-0, ffprobe 4.1.8-0, phantomjs ., rtmpdump 2.4
[debug] Optional libraries: Crypto, secretstorage, mutagen, sqlite, websockets
[debug] Proxy map: {}
[debug] [DiscoveryPlusItaly] Extracting URL: https://www.discoveryplus.com/it/video/the-modern-baker/stagione-1-episodio-6-pizza-co
[debug] Using fake IP <IP_ADDRESS> (IT) as X-Forwarded-For
[DiscoveryPlusItaly] the-modern-baker/stagione-1-episodio-6-pizza-co: Downloading JSON metadata
[DiscoveryPlusItaly] 1313849: Downloading JSON metadata
[DiscoveryPlusItaly] the-modern-baker/stagione-1-episodio-6-pizza-co: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] Available formats for 1313849:
ID                        EXT RESOLUTION FPS │   FILESIZE   TBR PROTO  │ VCODEC        VBR ACODEC     MORE INFO
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────
hls-stereo_128000-Italian mp4                │                  m3u8_n │ audio only        unknown    [it] Italian
hls-299                   mp4 416x234     25 │ ~ 49.80MiB  299k m3u8_n │ avc1.4D400C  299k video only
hls-423                   mp4 640x360     25 │ ~ 70.58MiB  423k m3u8_n │ avc1.4D4016  423k video only
hls-660                   mp4 960x540     25 │ ~110.06MiB  660k m3u8_n │ avc1.4D401F  660k video only
hls-958                   mp4 1280x720    25 │ ~159.55MiB  958k m3u8_n │ avc1.4D401F  958k video only
hls-1672                  mp4 1920x1080   25 │ ~278.51MiB 1672k m3u8_n │ avc1.4D4028 1672k video only
hls-2456                  mp4 1920x1080   25 │ ~408.97MiB 2456k m3u8_n │ avc1.4D4028 2456k video only
hls-3577                  mp4 1920x1080   25 │ ~595.61MiB 3577k m3u8_n │ avc1.4D4028 3577k video only

Hi bann0,
I have saved cookies from chrome to a txt file with an extension, then I have passed the file name as a parameter to yt-dlp, but i still get the same error.
Can you tell me where am I wrong?
thank you.

Try --cookies-from-browser

Hi pukkandan, I also try using "--cookie-from-browser chrome", but I still have the same error.
Also after reset all cookie from website.
Thanks.

HI to all,
I still have always the same error also with other videos,
If I try to view with chrome from site webpage work fine, but with yt-dlp does not work, also passing the login credentials.
Some one have some suggestion to give me?
Thanks
yt-dlp.exe -i -o "D:\Temp\videoDownloads%(series)s %(season_number)dx%(episode_number)02d %(title)s.%(ext)s" -v -Uv --verbose "https://www.discoveryplus.com/it/video/i-re-dellasfalto/stagione-2-episodio-1" --cookies-from-browser chrome --username ????? --password ????
[debug] Command-line config: ['-i', '-o', 'D:\Temp\videoDownloads\%(series)s %(season_number)dx%(episode_number)02d %(title)s.%(ext)s', '-v', '-Uv', '--verbose', 'https://www.discoveryplus.com/it/video/i-re-dellasfalto/stagione-2-episodio-1', '--cookies-from-browser', 'chrome', '--username', 'PRIVATE', '--password', 'PRIVATE']
[Cookies] Extracting cookies from chrome
[debug] Extracting cookies from: "C:\Users\user\AppData\Local\Google\Chrome\User Data\Default\Network\Cookies"
[Cookies] Extracted 3124 cookies from chrome
[debug] cookie version breakdown: {'v10': 3124, 'other': 0, 'unencrypted': 0}
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, err utf-8, pref cp1252
[debug] yt-dlp version 2021.12.27 [6223f67] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.22000-SP0
[debug] exe versions: ffmpeg 2021-08-14-git-acd079843b-full_build-www.gyan.dev (setts), ffprobe 2021-08-14-git-acd079843b-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2021.12.27, Current version: 2021.12.27
yt-dlp is up to date (2021.12.27)
[debug] [DiscoveryPlusItaly] Extracting URL: https://www.discoveryplus.com/it/video/i-re-dellasfalto/stagione-2-episodio-1
[debug] [DPlay] Extracting URL: https://discoveryplus.it/video/i-re-dellasfalto/stagione-2-episodio-1
[debug] Using fake IP <IP_ADDRESS> (IT) as X-Forwarded-For
[DPlay] i-re-dellasfalto/stagione-2-episodio-1: Downloading JSON metadata
ERROR: [DPlay] i-re-dellasfalto/stagione-2-episodio-1: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output. (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.
File "yt_dlp\extractor\common.py", line 717, in _request_webpage
File "yt_dlp\YoutubeDL.py", line 3458, in urlopen
File "urllib\request.py", line 531, in open
File "urllib\request.py", line 640, in http_response
File "urllib\request.py", line 569, in error
File "urllib\request.py", line 502, in _call_chain
File "urllib\request.py", line 649, in http_error_default

Maybe Your executable doesn't have the latest discoveryplus commits.
Try git clone or wait for the next release.

Pls update whether this is still an issue


Colons in Nakama Leaderboard ID

Description
Using the leaderboard feature for Nakama (2.4), I'm having an issue using a colon : in a leaderboard_id. Right now I'm getting a 500 error using the rest api to fetch the data. Example: GET /v2/leaderboard/some:leaderboard. I am able to create the leaderboard and add leaderboard records, but not fetch anything.
Steps to Reproduce

Create a leaderboard with Lua pcall(nk.leaderboard_create, "test:leaderboard", false, "desc", "incr", cron, metadata)
Create a leaderboard record with Lua: pcall(nk.leaderboard_record_write, "test:leaderboard", ownerId, userId, pointValue)
Use Rest API to Fetch Data:curl -H "Authorization: Bearer <bearer>" "localhost/v2/leaderboard/test%3Aleaderboard?limit=10"

orcurl -H "Authorization: Bearer <bearer>" "localhost/v2/leaderboard/test:leaderboard?limit=10"

Expected Result
Returns the leaderboard records.
Actual Result
Returns a 404 Not Found (no logs).
Context

[x] Rest API & Lua RPC

Your Environment

Nakama: 2.4.0+a5dd5427
Cockroach: v2.0.1
Environment name and version: ?
Operating System and version: https://hub.docker.com/r/heroiclabs/nakama/tags @2.4.0

Just a follow up. This may be related to this: https://github.com/grpc-ecosystem/grpc-gateway/issues/224

@amerryma I can reproduce it too. It looks like it's definitely related to https://github.com/grpc-ecosystem/grpc-gateway/issues/224 as you say.
I'll look into workarounds but your best bet for now is to avoid : characters in the leaderboard ID.

https://github.com/grpc-ecosystem/grpc-gateway/issues/224 appears to be resolved. This issue should be fixed through the dependency update in c97ad153cf216cd9586ad668219adc125ed79451, and will be part of the next release.


Registry UI Improvement checklist

Which area/kind this issue is related to?

/area registry
Issue Description
Checklist for Registry UI https://registry.devfile.io/viewer Improvments

[ ] Less white space between Filter field and values
[ ] Devfile Header logo disappears
[ ] Devfile Type (stack/sample) should be more subtle on the tile card

Very cool! Only thing that stood out to me was that I couldn't open the samples or stacks in a new tab/window. Not that I think that's a big deal. I, personally, default to right-clicking to open new tabs.
Very easy to use UI!

Less white space between Filter field and values

Does this include the "Filter Types" and "Tags" showing up on the extreme left? Attached a screenshot. I'm on Firefox.

This seems to be implemented and resolved in PR devfile/devfile-web#40.


More Outreachy issues on fry

This is a meta-issue to inform Outreachy applicants that there are now more issues for the MIDI project on a different repo: https://github.com/rand00/fry/issues. Happy MIDI-hacking!

@pitag-ha, @Engil
The Outreachy UI only provides an input to show 1 contribution so I have created a repo with a readme. This way I can describe my contribution in the readme and pass the link to the repo/readme to the Outreachy UI
Is this Ok?

I'm closing this now that the Outreachy contribution period is over.


why gitea docker image update frequently?

you know, I use watchtower automatic update gitea.
then, I find gitea docker image update frequently. The most recent day was updated 7 or 8 times.
So what happened ？

The :latest image is based on master which build on every commit. The 1.9.x release need less and less fix so more and more work is done on master. If you want a stable image please use :1 :1.9 which are updated on release.

if I use image :1.9.   when gitea update, I cannot automatically update.
so, use release version to build a docker image:latest will be better?

The :1 will follow 1.9.1 -> 1.9.2 -> 1.9.x -> (will skip 1.10-rcX) -> 1.10.0 -> 1.10.1 -> ...

and same for :1.9 but will stop at last 1.9.x version.

Wouldn't it make more sense to point "latest" to the latest stable release and to use a different tag, like for example "next" which points to the latest HEAD build on master? Usually "latest" is by convention the latest stable release, maybe this would be less confusing.

This also how the code branching works (https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md#versions). The work is done in master and not on a develop branch. That one way to do it and I would agree that is not the most common. I think it offer more on the edge feature specially to allow Gitea incorporate new feature rapidly this way you don't have to merge big diff on master at each release. But maybe this is not needed anymore since Gitea become more and more mature. I am not personally in favor for any type of code branching they all have their advantage and disadvantage.
On a side note, I would suggest you in a production to at least use a major tagged version (in case of Gitea please use at least :1 or :1.9) since it is the only way to prevent most breaking change. For example in db world, I would suggest you to use never postgres:latest (currently on postgres:11.5) which will be updated to postgres:12 without assuring you backward compatibility.

ok.   thanks everyone~


View locations reset

I think this happened because I was testing profiles. My view locations have been reset. I have Gitlens installed, and I had a few of the Gitlens views in their own view container. Now, they're back in their default view container (scm).

May I know if you are able to reproduce? If so can you please provide steps?

Found an easy repro:
0. Have 2 windows open (not sure if this step is needed)

Disable profiles in settings (not sure if this step is needed)
Restart.
Enable profiles in settings
Restart
In one of the windows run "Settings Profiles: Create an Empty Settings Profile" and create a new empty profile
See that your new profile gets used in just that window ✅
In that same window run "Settings Profiles: Switch" and choose your default profile
See that your default profile is applied, but view locations are reset 🪲

/duplicate
Thanks for the steps. I think you might be hitting this - https://github.com/microsoft/vscode/issues/154090

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

@sandy081 I took a look at the steps in the duplicate issue, and it says that reloading fixes the issue. Reloading does not fix my issue.

I am planning to look at #154090 next milestone and during then I will cover this too.


This is very complicated to download and use

Hi @lucidqdreams - are you referring to ComputerManagementDsc resource specifically or DSC as a general pattern? Perhaps you could provide a bit more context and we could provide additional guidance or references?

We were trying to use this in conjunction with an ARM template.  Perhaps my comment is more related to the use case with ARM templates and packaging up these files to use with Azure deployments.  We did get it working, but there are a lot of files in the root directory that seem unrelated to running DSC configuration.  Downloading this from the gallery my be simpler but this was a bit of a muddle to get through we what we need was just a check for a pending reboot.

Hi @lucidqdreams - it definitely can be a fairly intensive process to get set up. But once set up it should be OK.

We were trying to use this in conjunction with an ARM template. Perhaps my comment is more related to the use case with ARM templates and packaging up these files to use with Azure deployments. We did get it working, but there are a lot of files in the root directory that seem unrelated to running DSC configuration. Downloading this from the gallery my be simpler but this was a bit of a muddle to get through we what we need was just a check for a pending reboot.

Installing this module isn't very complicated...
Install-Module ComputerManagementDsc
Exactly what do you feel is the issue at hand?


Investigate possible race condition in replicator cluster stability check

User reported inserting a document when the cluster was not yet stable. That document update was never processed by the replicator. The replicator 'stable' even was issued before the 'update was ignored because cluster is unstable` log message.
Expected Behavior
User updates replicator documents at any time, eventually they are all noticed and processed by the replicator.
Current Behavior
Inserting a document at a particular time, leads to replicator ignoring it.
Steps to Reproduce (for bugs)
...
Context
Your Environment
2 node cluster, version 2.1.0

Order of cluster setup:
Start state is empty data dir, stopped couchdb service on both cluster nodes
Each is then started and basic dbs created (_users, _replicator etc)
Then the cluster setup is done on an arbitrary node
PUT /_nodes/nodename
"One thing I'm unsure of, I'm using port 5986 for cluster setup, is that still necessary?"
Also in case it's relevant, I do get some log errors initially:
[error] 2017-11-16T22:15:43.405527Z couchdb@1 <0.454.0> xxx Request to create N=2 DB but only 1 node(s)

[error] 2017-11-16T22:15:44.524321Z couchdb@1 <0.486.0> xxx Request to create N=2 DB but only 1 node(s)

[error] 2017-11-16T22:15:45.655681Z couchdb@1 Request to create N=2 DB but only 1 node(s)

Invalid bug - the _users/_replicator DBs are being created prior to the cluster being joined together, right?

User switched the order of cluster setup, but the issue was still there. After looking at this over the weekend noticed that it's possible there is a bug in 2.1.0 which could cause this behavior.
The good news is it seems in 2.1.1 this bug was fixed inadvertently when the module was refactored.
Notice the clustering module in 2.1.0:
https://github.com/apache/couchdb/blob/2.1.0/src/couch_replicator/src/couch_replicator_clustering.erl#L211 is_stable calls ends up checking if the quiet time has expired by using os:timestamp() result.
This means if os:timestamp() doesn't return monotonic results, (and in fact it is not guaranteed to) then this sequence of events is possible:

Cluster stability check fires https://github.com/apache/couchdb/blob/2.1.0/src/couch_replicator/src/couch_replicator_clustering.erl#L168 and notifies document processor that cluster is stable.

Document processor starts processing replication documents. On first update it calls is_stable(). However if os:timestamp() return a timestamp which is less than the previous one, the is_stable() call could return false.

Document update is skipped.

However cluster stable event already fired and there won't be another one until cluster membership changes and another quiet period passes afterward.

I had a test script to check if os:timestamp() would move backwards, however I couldn't find any VMs or machines I had access to where this would happen. But it is entirely possible based on reading docs the behavior experience by the user.
The good news is that this particular bug was inadvertently when clustering module was refactored such that it has an explicit stable flag in the state:
https://github.com/apache/couchdb/blob/master/src/couch_replicator/src/couch_replicator_clustering.erl#L73
This means that after notifier gen_event fires with a stable event, any calls to is_stable will read the state from that flag instead of going to os:timestamp()
Contacted the user to ask them to try using the latest version 2.1.1. For now closing the issue again as it is fixed.