[HOLD for payment 2023-05-29] [$1000] Normal cursor is displayed in some parts of compose box and on double click in that cursor, app doesn't focus on compose box but selects placeholder 'Write something...' text

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Lose focus from compose box
Hover over compose box and observe that few area above and below 'Write something...' text displays normal pointer
Double click when normal pointer is visible and observe

Expected Result:
App should display edit pointer on the whole compose box and on double click, it shouldn't select placeholder text
Actual Result:
App displays normal pointer on some parts of compose box when not in focus and on double click, it selects placeholder text
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/235006146-891216aa-f6b8-4ac2-873b-2a748cde79b8.mp4
https://user-images.githubusercontent.com/43996225/235006169-20aa26f3-f087-47b7-9351-f6ee0b23e77f.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682594448594829
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f860adb042d7b50e
Upwork Job ID:<PHONE_NUMBER>105691648
Last Price Increase: 2023-05-16

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

I've been rolling out the monthly leaderboard so I haven't been able to get to this yet.

Got the go ahead to work on this: https://expensify.slack.com/archives/C01SKUP7QR0/p1683645493591139

Proposal
Please re-state the problem that we are trying to solve in this issue.
Normal cursor is displayed in some parts of compose box and on double click in that cursor, app doesn't focus on compose box but selects placeholder 'Write something...' text
What is the root cause of that problem?

As you can see input itself is not covering all of the composer area. Thus, when we click on wrapper it won't focus composer
### What changes do you think we should make in order to solve the problem?
We should turn style outer wrapper to have `cursor: text`. Also we should turn `View` element into `Pressable` and when it is pressed we should focus composer if not focused
https://github.com/Expensify/App/blob/9b5397e91704a5e539c5d6e0d413363663f540dd/src/pages/home/report/ReportActionCompose.js#L883
We should also, add
```javascript
  onMouseDown={e => e.preventDefault()}
```
to prevent losing focus when outside of input element is pressed
### What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.

App displays normal pointer on some parts of compose box when not in focus

On double click, it selects placeholder text

What is the root cause of that problem?

The textarea is not covering the full height of the input
There's the paddingVertical: 5 here https://github.com/Expensify/App/blob/802e406cc8a7f8d5677061a13b2a5b4076f0bae5/src/styles/styles.js#LL1557C28-L1557C28 of the textarea container
And also when the textarea is 1 line, its height is only 20px while the height of the container is 38px (40px minHeight minus 2px border)
So when we click anywhere outside that 20px, it will show normal cursor since we're not hovering over the textarea but the container instead

The placeholder text of textarea is currently selectable, while placeholder of input is not as per this logic https://github.com/Expensify/App/blob/802e406cc8a7f8d5677061a13b2a5b4076f0bae5/web/index.html#L43

This can be reproduced not only as in the OP, but if we double click a bit below the composer container itself, we can select the placeholder text.
What changes do you think we should make in order to solve the problem?

We need to make the textarea capture the full height of the container.

Remove the paddingVertical: 5 in https://github.com/Expensify/App/blob/802e406cc8a7f8d5677061a13b2a5b4076f0bae5/src/styles/styles.js#LL1557C28-L1557C28, and add { paddingTop: 5, paddingBottom: 5 } to the composer style in https://github.com/Expensify/App/blob/802e406cc8a7f8d5677061a13b2a5b4076f0bae5/src/styles/styles.js#L1537 (I've tested and it doesn't cause the regression mentioned in https://github.com/Expensify/App/blob/802e406cc8a7f8d5677061a13b2a5b4076f0bae5/src/styles/styles.js#L1534, perhaps there was some updates in React Native that fixes it so it should be safe to set the paddingTop and paddingBottom now)
When numberOfLine of the Composer is 1, the lineHeight of it should be 38, so that the input is centered correctly when it's 1 line. For multiple lines the textarea height is already more than the container height so the lineHeight can remain as 20.

We need to add , textarea::placeholder to https://github.com/Expensify/App/blob/802e406cc8a7f8d5677061a13b2a5b4076f0bae5/web/index.html#L43 so that the disabling of placeholder text select is applied to textarea as well.

What alternative solutions did you explore? (Optional)
NA

Still reviewing proposals. @mananjadhav do you have any initial thoughts on these two entries?

@mananjadhav do you have some time today to evaluate the proposals?

Apologies for the delay, missed out of my tracker. Both the proposals point out the correct root cause, but @dukenv0307's proposal is better as it fixes the height of the textarea within the composer and also fixes the text selection.
@alitoshmatov I think we should avoid having View with pseudo behaviors of Textarea.
@tgolen what do you think?

I think @dukenv0307's proposal is sound as well. Let's go with that one.
@arielgreen can you please hire @dukenv0307 🟢 and @dukenv0307 you can start working on a PR.

Issue not reproducible during KI retests. (First week)

@mvtglobally Are we sure it isn't reproducible? I can still reproduce this on staging env.

@mananjadhav our team was not able to reproduce. Thanks for confirming it's still repro

I am still able to reproduce it as well. I think the double-click part has gone away, but the cursor change is still there.

https://github.com/Expensify/App/assets/1228807/3c839c3c-7d6a-4d18-862e-2800183e7e5c
I can double-click right below the input and it selects the placeholder text.

@dhanashree-sawant @mananjadhav @dukenv0307 please be sure to submit an application to the Upwork posting here.

@dukenv0307 Quick bump o the regression here.

@mananjadhav I am seeking solutions.

Thanks @arielgreen, I have applied to the upwork posting.

@dhanashree-sawant @mananjadhav offers sent.
@dukenv0307 still waiting on an application in Upwork.

@tgolen @mananjadhav The PR is ready to review. Please check.

@arielgreen I've applied, thank you!

Reassigning, OOO tomorrow/Monday.

@arielgreen unassigning myself based on this new process (SO here), and assigning you again since you were the original assignee; I'm going OOO.

I've tagged @mananjadhav in the C+ room to discuss.

@dukenv0307 please accept the contract and we'll get you paid!

All agents have been paid, contracts ended - closing


Implement MapFunc method to support function application over Series Elements

I am not sure if you find this in any way interesting. I am still planning to PR other bits, like the Histogram, but wanted to give it a bit more time and thought. I found having a mapping method that does not affect length of series useful, and while perhaps this is not the best implementation, if you think you have interest, I am sure given feedback we can make it better.
Thanks for considering this changeset. Cheers.

I think this sounds quite reasonable really. I feel like it is limiting in some ways to do this, but it does reduce the size of that worm can you mentioned. Let me give this a bit more thought and perhaps I will have a better alternative, otherwise given your suggestion will you consider merging it in, or do you feel value is not there, or not in line with what you see for this package? Thanks!

I think you are right about this one. I am going to go ahead make changes and make sure it feels OK, and add some tests.

@szaydel since you've already proposed a different solution in #57 I'm closing this one.


how can I train locally

I am trying to run the code without internet connection because I always failed to reach wandb.
I already add
"os.environ["WANDB_API_KEY"] = YOUR_KEY_HERE
os.environ["WANDB_MODE"] = "offline"
in src/main.py, yet it didn't work because it still seemed to try to get internet.
My command is
"python3 -m src.main +experiment=co3d_hydrant mode=test dataset/view_sampler=evaluation dataset.view_sampler.index_path=assets/evaluation_index/co3d_hydrant_extra.json checkpointing.load=checkpoints/co3d_hydrant.ckpt  "
My error is as follows:
wandb: Network error (ConnectTimeout), entering retry loop.
Problem at: /home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/pytorch_lightning/loggers/wandb.py 400 experiment
Error executing job with overrides: ['+experiment=co3d_hydrant', 'mode=test', 'dataset/view_sampler=evaluation', 'dataset.view_sampler.index_path=assets/evaluation_index/co3d_hydrant_extra.json', 'checkpointing.load=checkpoints/co3d_hydrant_kl.ckpt']
wandb: ERROR Run initialization has timed out after 90.0 sec.
wandb: ERROR Please refer to the documentation for additional information: https://docs.wandb.ai/guides/track/tracking-faq#initstarterror-error-communicating-with-wandb-process-
Traceback (most recent call last):
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/hdd2/llq202312/latentsplat-main/src/main.py", line 159, in
train()
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/main.py", line 94, in decorated_main
_run_hydra(
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/_internal/utils.py", line 394, in _run_hydra
_run_app(
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/_internal/utils.py", line 457, in _run_app
run_and_report(
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/_internal/utils.py", line 223, in run_and_report
raise ex
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/_internal/utils.py", line 220, in run_and_report
return func()
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/_internal/utils.py", line 458, in
lambda: hydra.run(
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/_internal/hydra.py", line 132, in run
_ = ret.return_value
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/core/utils.py", line 260, in return_value
raise self._return_value
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/hydra/core/utils.py", line 186, in run_job
ret.return_value = task_function(task_cfg)
File "/hdd2/llq202312/latentsplat-main/src/main.py", line 153, in train
trainer.test(model_wrapper, datamodule=data_module, ckpt_path=checkpoint_path)
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 753, in test
return call._call_and_handle_interrupt(
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 43, in _call_and_handle_interrupt
return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 105, in launch
return function(*args, **kwargs)
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 793, in _test_impl
results = self._run(model, ckpt_path=ckpt_path)
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 948, in _run
call._call_setup_hook(self)  # allow user to set up LightningModule in accelerator environment
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 86, in _call_setup_hook
if hasattr(logger, "experiment"):
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/lightning_fabric/loggers/logger.py", line 118, in experiment
return fn(self)
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/pytorch_lightning/loggers/wandb.py", line 400, in experiment
self._experiment = wandb.init(**self._wandb_init)
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/wandb/sdk/wandb_init.py", line 1195, in init
raise e
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/wandb/sdk/wandb_init.py", line 1176, in init
run = wi.init()
File "/home/llq/.conda/envs/latentsplat/lib/python3.10/site-packages/wandb/sdk/wandb_init.py", line 785, in init
raise error
wandb.errors.CommError: Run initialization has timed out after 90.0 sec.
Please refer to the documentation for additional information: https://docs.wandb.ai/guides/track/tracking-faq#initstarterror-error-communicating-with-wandb-process-

Hi BroenLin,
thank you very much for your interest in our work.
Could you try setting:
wandb:     ...     activated: false
in config/main.yaml.
Please let me know, whether this resolves the problem.
Best
Chris

Hi BroenLin,
thank you very much for your interest in our work. Could you try setting: wandb: ... activated: false in config/main.yaml.
Please let me know, whether this resolves the problem.
Best Chris

Thanks a lot, Chrixtar!
It worked. But there seems to be a new problem.
The code "get_encoder" in src/main.py didn't run well.
 "encoder, encoder_visualizer = get_encoder(
        cfg.model.encoder,
        d_in=autoencoder.d_latent if cfg.model.encode_latents else 3,
        n_feature_channels=autoencoder.d_latent,
        scale_factor=Fraction(cfg.model.supersampling_factor, 1 if cfg.model.encode_latents else autoencoder.downscale_factor),
        variational=cfg.model.variational != "none"
    )"

The error is as followed.


Impossible to access to tenancy assets

Bug description
I can't access to image saved in public folder of single tenant.
The image is saving by Image::make(__('Logo'), 'company_logo')->disk('public') and I retrieve the file on my app on this path: storage/tenant24087ec6-e592-40a3-a33b-0c436f231ac0/app/public/bSTuLvTlJViNKarET0OAtfgV68eqwPWDHcupjy2F.png
I use storage_path('bSTuLvTlJViNKarET0OAtfgV68eqwPWDHcupjy2F.png') and it return [tenant_domain]/tenancy/assets/bSTuLvTlJViNKarET0OAtfgV68eqwPWDHcupjy2F.png
Steps to reproduce
Image::make(__('Logo'), 'company_logo')->disk('public')
storage_path('filename')

Expected behavior
If I visit [tenant_domain]/tenancy/assets/bSTuLvTlJViNKarET0OAtfgV68eqwPWDHcupjy2F.png the app redirect my on primary domain.
Laravel version
9.5
stancl/tenancy version
3.5

If this is related to Nova, I recommend asking on our Discord, it's not really a bug with the package.


lib/base64: Support line breaks in base64 strings.

This allows to read directly ascii-armored blocks.
Signed-off-by: Philippe Pepos Petitclerc<EMAIL_ADDRESS>

This might be optimized later, but in the meantime, :shipit:

good enough. +0.9

+1

test this please


[FEATURE]: Assign hotkeys

Feature Title
Assign hotkeys
Motivation
The default L3 to open loot menu clashes with other bindings. This is probably only an issue due to other inputs not being suppressed properly, but the option to assign keys would be very beneficial.
Feature Description
Mcm submenu (or .ini) wherein a player can bind quickloot menu usage to keys of choice.
Additionally, some form of autoload of settings on new game would be very satisfying.
Additional Context
No response

This is planned, but it's going to take a while to implement.

As a workaround for now I would also be happy with an INI file where I can configure the key codes. I really love what Quickloot IE does, but sadly it's nearly unusable with a controller at the moment because the d-pad up key opens the container, which makes navigation through the menu one-way only.

The infrastructure for this feature is done as of #64. What's missing is the MCM integration and some code to show the correct keybindings in the button bar of the loot menu. Our resident MCM expert is busy at the moment, so I'll have to figure that out myself somehow. Until that is done you can bind the favorites menu to a different key, since that is the keybinding the current release version uses for the "Transfer" button.

Thank you for your efforts, higly appreciated! I will give the favorite menu rebinding a try.

I'm not entirely sure I understand that. Does Skyrim even allow binding actions to key combinations like A+D_UP? I don't play with controller myself, so I'm not very familiar with the gamepad settings.
Are you saying that binding D_UP to any action other than favorites breaks all keybindings globally? Or just keybindings that also include D_UP? Is that related to QuickLoot or just a Skyrim thing in general?

@AtomCrafty you can assign key combinations in vanilla skyrim in the controlmap.txt. This is also shown in tools like Skyrim Control Mapper. This is basically all just configuration for what vanilla skyrim can already do (but doesn't offer a native UI for it, god forbid):

In the screenshot above, you'd need to hold down the A button on the controller and then you could use the d-pad to perform various actions (opening the 4 main menu screens in this case), which is very useful because the number of buttons on a gamepad is obviously very limited compared to a full keyboard.
What I discovered to day is that if you unmap the functionality on the basic D-pad up/down (without any other modifier, just these two) to make room for a mod (e.g. quickloot) then all the combinations (e.g. A+d-pad up) simply stop working and won't do anything. I don't know yet if this is specific to the favorites menu or not.
TL;DR:
Skyrim's input system is bugged (surprise!) and it's hard to completely un-map the inputs for the d-pad. This would make configurable inputs for Quickloot IE all the more valuable, in particular for gamepad users. Quickloot IE already "grabs" the d-pad inputs when the popup is open and prevents them from triggering something else, e.g. the favorites menu (which is great!). All that's missing from my point of view is the ability to remap the "open container" functionality to some other button so we can navigate through the quickloot menu on the controller in both directions.

Okay, I see. The A button is the modifier key for those keybindings. I'm painfully familiar with how the control map works due to the recent rewrite of QLIE's input system.
Either way, that doesn't really seem relevant to QLIE, but an interesting observation nonetheless. On a different note, I'd be interested what you would consider an appropriate default key for the Transfer action. I just bound it to Y for testing, but it might be annoying to be unable to jump while looking at a body. The keybindings will be configurable, but it would still be best if we provided sensible defaults.
https://github.com/MissCorruption/QuickLootIE/blob/c4de9f5977cf6aacc4337a1b0d0c526e5246e5ce/src/Input/InputManager.cpp#L217-L224

I think that opening the full-blown container menu is a rather disruptive action and usually something the user will want to avoid doing by accident (that's kind of the point of the Quickloot idea after all). So I would not map it to one of the four main face buttons. Maybe the "back" button on the 360 gamepad? It's far enough away from the normal grip to be sure that the action is intentional.

MCM is done and hooked up. This can be closed now.

Great, thank you! Looking forward to the new version on the nexus :)


bug in the heart which selects the favorite.

Describe the bug

bug in the heart which selects the favorite.

Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

@gnikita432 I think now this bug has been resolved please check it once :)

Yes, It has been solved.

@gnikita432 I think you can change your issue that on clicking on Residue Methods nothing is displayed :)


add aot configuration

AOT as is documented here(https://angular.io/docs/ts/latest/cookbook/aot-compiler.html) will be really helpful for a production skeleton.

I have created one for myself, based on the AOT tutorial: aot-quick-start

That's great that you've done that for yourself. We have decide not to add AoT to this QS at this time.


Allow serving kibana with prefix

I'm not able to get separate hostnames for things easily, so we run everything under different /subdirectory/ type routes. The proxy should be able to have a configurable URL prefix that can be used by upstream.
With a proxy prefix in apache that looks like:
  ProxyPass /kibana/ http://localhost:9201/
  <Location /kibana/>
    ProxyPassReverse http://localhost:9201/
  </Location>

The only change in the kibana proxy that was needed was:
diff --git a/app.js b/app.js
index ebfe334..6e477fd 100644
--- a/app.js
+++ b/app.js
@@ -78,7 +78,7 @@ function kibana3configjs(req, res) {

   res.setHeader('Content-Type', 'application/javascript');
   res.end("define(['settings'], " +
-    "function (Settings) {'use strict'; return new Settings({elasticsearch: '/__es', default_route     : '/dashboard/file/default.json'," +
+    "function (Settings) {'use strict'; return new Settings({elasticsearch: '/kibana/__es', default_route     : '/dashboard/file/default.json'," +
       "kibana_index: '" +
       getKibanaIndex() +
       "', panel_names: ['histogram', 'map', 'pie', 'table', 'filtering', 'timepicker', 'text', 'hits', 'column', 'trends', 'bettermap', 'query', 'terms', 'sparklines'] }); });");

Should be trivial to implement.

Closed so it's no longer on my gigantic list of open PRs/issues since this project seems dead.


The problem when you are importing "dmstudio"

Hello! I couldn't to import this library.
>>> from dmstudio import dmcommands
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/pomponchik/Desktop/Projects/locklib/venv/lib/python3.9/site-packages/dmstudio/__init__.py", line 10, in <module>
    import dmcommands
ModuleNotFoundError: No module named 'dmcommands'
>>> from dmstudio import dmfiles
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/pomponchik/Desktop/Projects/locklib/venv/lib/python3.9/site-packages/dmstudio/__init__.py", line 10, in <module>
    import dmcommands
ModuleNotFoundError: No module named 'dmcommands'
>>> import dmstudio
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/pomponchik/Desktop/Projects/locklib/venv/lib/python3.9/site-packages/dmstudio/__init__.py", line 10, in <module>
    import dmcommands
ModuleNotFoundError: No module named 'dmcommands'

(This module has been downloaded from the pip)

And... this is the same import command in the case of cloned from this repo library:
>>> from dmstudio import dmcommands
Traceback (most recent call last):
  File "/Users/pomponchik/Desktop/Projects/go_go/dmstudio/main.py", line 1, in <module>
    from dmstudio import dmcommands
  File "/Users/pomponchik/Desktop/Projects/go_go/dmstudio/dmstudio/__init__.py", line 5, in <module>
    import dmstudio.dmcommands
  File "/Users/pomponchik/Desktop/Projects/go_go/dmstudio/dmstudio/dmcommands.py", line 1, in <module>
    import dmstudio.initialize
  File "/Users/pomponchik/Desktop/Projects/go_go/dmstudio/dmstudio/initialize.py", line 1, in <module>
    import win32com.client
ModuleNotFoundError: No module named 'win32com'

My platform is macbook m1.

ModuleNotFoundError                       Traceback (most recent call last)
 in
----> 1 import dmstudio.dmcommands as dmcommands  # panggil package dmstudio
~\Anaconda64\lib\site-packages\dmstudio_init_.py in
8 '''
9
---> 10 import dmcommands
11 import dmfiles
12 import special
ModuleNotFoundError: No module named 'dmcommands'

@Boudou92  @pomponchik Just download the files and paste them in your site packages directory. I don't thing the pip version will work. Also make sure you have the anaconda distribution installed. win32com comes by default


iOS bad implementation

On the iOS implementation, on the following line:
nativeMap.OverlayRenderer = GetOverlayRenderer;
The call to GetOverlayRenderer has a bad syntax and is missing both parameters.
I know the first parameter should be the nativeMap variable, but what about the other?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1b55b71-2bfe-63e3-5620-b7a485d956cf
Version Independent ID: 9ea09c8d-8de7-cfdd-4051-d58852045ab5
Content: Highlighting a Region on a Map - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/custom-renderer/map/polygon-map-overlay.md
Service: unspecified
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Sorry, my bad. It's a delegate.


npm install fails due to dependency not found

Hi tried, to install with npm install  and got this:
npm ERR! git fetch -a origin (git://github.com/Bartvds/update-notifier/) fatal: unable to connect to github.com:
npm ERR! git fetch -a origin (git://github.com/Bartvds/update-notifier/) github.com[0: <IP_ADDRESS>]: errno=No such file or directory
npm ERR! Error: Command failed: fatal: unable to connect to github.com:
npm ERR! github.com[0: <IP_ADDRESS>]: errno=No such file or directory
npm ERR!
npm ERR!
npm ERR!     at ChildProcess.exithandler (child_process.js:637:15)
npm ERR!     at ChildProcess.EventEmitter.emit (events.js:98:17)
npm ERR!     at maybeClose (child_process.js:743:16)
npm ERR!     at Process.ChildProcess._handle.onexit (child_process.js:810:5)
npm ERR! If you need help, you may report this entire log,
npm ERR! including the npm and node versions, at:
npm ERR!     http://github.com/npm/npm/issues
npm ERR! System Windows_NT 6.2.9200
npm ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "grunt-tsd" "-g"
npm ERR! cwd C:\dev\iandmine\Source\Client
npm ERR! node -v v0.10.26
npm ERR! npm -v 1.4.3
npm ERR! code 128
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     C:\dev\iandmine\Source\Client\npm-debug.log
npm ERR! not ok code 0

Thanks Bartvds!
The fix that worked for me is:
git config --global url."https://".insteadOf git://

Thanks @Bartvds !!

Thx @Bartvds it works !

Actually I was stuck with the same problem . Here's how I fixed it .

I found that the problem for me was having an older version of npm which was causing this issue.
I uninstalled it using sudo apt-get remove npm and installed it again using sudo apt-get install npm .
Then upgrade it to the latest version using sudo npm install npm@latest -g


tvOS not supported

I tried adding fastlane to a tvOS project. After completing fastlane init, I tried listing the lanes or invoking the beta action and got a few crashes. Here are a few of the crash ids:
9f4bae97ab5d5d5cddce1af2057c64d0
e46a1df88377aebc3b0da1523c36fe25
4ffd876398b5469f5b2778f81d8b829a
b8c5b74435c6b8f7da13fe960e1af1d3
After looking at the crash reports, it's clear what is the reason:
"message": "RuntimeError: \u001b[31mPlatform 'tvos' is not supported. Must be either [:ios, :mac, :android]\u001b[0m",

Let me know how can I help you to add support for the AppleTV

+1 for tvos support :)

+1 :)

There was some tvOS related changes on fastlane_core. Hopefully all tools will be update for tvOS as well.

@EmilYo we're busy working on it :rocket: It's not very easy and straight forward, as the tvOS app is tightly coupled with the iOS app.

Any update on the support for tvOS? Currently trying to use a sigh lane in my fastfile to pull down an adhoc provisioning profile of type tvOS, if I just perform the sigh command from the CLI it gives me the correct profile, but the sigh lane wont recognize the profile and I believe it is because the platform is not specified as tvOS.

Hey @mgazdich! Thanks for submitting the issue, looks like you got the problem taken care of? I am going to close the issue for now but please feel free to reopen/comment if you are still running into problems!


How do enable DOCKER_BUILDKIT and pass cmd line args to docker build?

When I build my docker images using docker_build() I need to run the equivalent of this command:
DOCKER_BUILDKIT=1 docker build --ssh github=$HOME/.ssh/id_rsa -t api:latest -f ./Dockerfile.dev .

How would I do about setting DOCKER_BUILDKIT=1 in the shell environment where docker is executed, and how would I pass --ssh?
I am also adding a live_update=... to the docker_build() so I can't just do a local(...) of the docker build command.
Thanks for any help!

I just noticed the custom_build() command that I can use for this. Closing this issue.


[AIRFLOW-1340] Add S3 to Redshift transfer operator

Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1340

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Currently RedshiftToS3Transfer (UNLOAD) exists but the opposite doesn't.
This PR adds COPY operation as S3ToRedshiftTransfer.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Newly added tests.operators.test_s3_to_redshift_operator.
Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3161 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3161      +/-   ##
==========================================
- Coverage   73.85%   73.83%   -0.03%
==========================================
  Files         191      192       +1
  Lines       14349    14378      +29
==========================================
+ Hits        10598    10616      +18
- Misses       3751     3762      +11

Impacted Files
Coverage Δ

airflow/operators/s3_to_redshift_operator.py
100% <100%> (ø)

airflow/task/task_runner/bash_task_runner.py
93.33% <0%> (-6.67%)
:arrow_down:

airflow/utils/helpers.py
51.14% <0%> (-2.88%)
:arrow_down:

airflow/jobs.py
79.64% <0%> (-0.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b125a...6084aa9. Read the comment docs.

I find this very functional and concise, I know that we would have used this operator in our pipelines

Updated PR.

Thanks for the review @Fokko! Addressed your comments.
Also, I saw #3201 and noticed the newly added operator was not in the document, so added a documentation fix to the revised PR.

All CI failures occurred on SchedulerJobTest and irrelevant to this PR.

Can you rebase onto master?

Sure! Rebased.


[FEATURE] Migrate client transports to Apache HttpClient / Core 5.x

Is your feature request related to a problem?
Reflecting changes in core to migrate to Apache HttpClient / Core 5.x
What solution would you like?
Migrate client transports to Apache HttpClient / Core 5.x
What alternatives have you considered?
N/A
Do you have any additional context?
https://github.com/opensearch-project/OpenSearch/issues/4256

Duplicate, closed https://github.com/opensearch-project/common-utils/pull/281


Ruff fails when attempting to produce an output file within a non-existent directory

I wasn't able to find a previously submitted issue surrounding this, apologies if I missed it.
Ruff fails (exit code 2) when trying to write to an output file (via --output-file) within a directory that doesn't exist with the following message:
ruff failed
  Cause: No such file or directory (os error 2)

I'd like to see Ruff automatically create the necessary directories to house the output file if they don't already exist rather than have to ensure the directory exists before invoking Ruff; or have Ruff have an option to automatically create the directories.
Reproducing the issue is fairly simple. Setting the --output-file flag to a filesystem location whose directories don't exist should do the trick (e.g. ruff check --isolated --output-file /tmp/does/not/exist/output.txt). This was tested on the latest Ruff (0.4.5). Creating the necessary directories (i.e. mkdir -p /tmp/does/not/exist) and then rerunning the command allows Ruff to succeed.

Thanks, will fix this real quick.


Surprising & non-discoverable behavior regarding snippet suggestions

VSCode Version: 1.45.1
OS Version: Windows 10.0.18363

Note: I open this as a bug. Might be a suggestion, but it's not for a new feature, but rather for a design rethink/discussion/adjustment. So there it is.
Before listing the repro, I have to say that I wasn't even aware of the whole "snippets" feature of VSCode until they started "messing with my finger memory", so to speak. One day, I suddenly started getting code generated for me as I typed, and I had no idea where it came from, or why. I usually would see it after typing (without looking at the screen) a ways past the point where the snippet was generated, so the end result was quite hilarious. My first attempts to find a disable flag in the settings page came up empty. I was looking for auto-formatting settings (which I had already disabled). I eventually tried to repro it more carefully, actually looking at the screen (the suggestions pop-up) and saw where it said "snippet", and that's how I found it.
Steps to Reproduce:

Start with snippet settings set to "inline" and ON. I write C++ code, so I get them from ms-vscode.cpptools (currently 0.28.1).
On a C++ file, type "struct", select the "struct" snippet in the suggestions popup, and then . It generates a name (from the filename), braces and a comment in the body.
In settings, disable snippets. For instance, on editor.suggest.showSnippets, and then try doing step 2 again.
This time there's no "struct" snippet offered. As expected. Use the "c++ keyword" suggestion instead.
Turn snippet suggestions on again (undo step 3), and then try doing step 2 yet again.
This time, the snippet suggestion is... not there. That can be extremely surprising. I mean... we re-enabled it, right!?

The reveal: the snippet is there. Scrolling up in the suggestions popup (pressing the UP arrow) will reveal it. If you select it and then try step 2 from scratch all over again the snippet will be back as the "default".
In order tor repro properly, you'd need to make sure that the suggestions popup has many suggestions. I normally get dozens or hundreds, as intellisense works properly less often than not (but that's a separate issue).
The fact that it was hidden tells me a likely reason (I'll never know for sure) why I hadn't noticed the existence of snippets in months of using VSCode. It was there... but hidden. At some point I must have hit the UP arrow then ENTER, or something like that, making it the default.
Summary/suggestions:

This behavior is surprising, and when things like this happen it can be difficult (and frankly annoying) to find the correct setting that matches the behavior and can correct it.
It would be great if the VSCode developers could ponder on this a bit. Options that come to mind:

Offer a "master switchboard" settings page to turn entire feature-sets on or off, without the noise of having every little setting all together in one page.
Consider having whole feature-sets off by default. Especially those that can affect or disrupt normal text-typing activities. This is supposed to be a text editor at its core, after all.
Consider having, by default, all popups not use any "natural" text-editing keys, like ENTER, and navigation arrows. Function keys and the like would be fine (although, I admit, perhaps awkward). This way, you wouldn't be able to activate auto-editing functions just by typing.
Maybe not having that by default, but as a nice, big, button in the master setting page I suggest above.

Does this issue occur when all extensions are disabled?: Yes/No
I didn't bother. Depends on extensions (I think) and it's more of a design issue in VSCode itself.

This is controlled via the editor.suggestSelection setting. By default, it remembers the last selected suggestion so that you don't always have to arrow up/down. What you want is the first options of that setting


Block parsing allows a few (<4) bytes of junk data after the last block

This is likely a bug but the following test relies on this behavior:
https://github.com/asdf-format/asdf/blob/3d46a99c69a06dcb806606190cc7815e15483a3c/asdf/_tests/test_array_blocks.py#L445C5-L465
Reading files with a streamed block also depends on this behavior as fd.fast_forward(-1) results in a seek to the last byte in the file (not the end of the file) so reading the input file after the streamed block is encountered results in reading the last byte in the stream.

This is partially addressed in #1537 which introduced a warning:
https://github.com/asdf-format/asdf/blob/96800153294b61c271bbf6608ba509cc239dc314/asdf/_block/reader.py#L142-L145
However a more thorough set of tests are needed.


[SERVER] Provision a staging environment with Terraform

This will largely be done in Terraform, with reusable modules we can use to complete #3.
Done in #72:

ECS cluster backed by t4g.micro instances for running Node.js apps (API, Game, SP, Worker)
S3 bucket for static assets (See #61)
Free-tier db.t4g.micro RDS instance for Postgres
Free-tier cache.t3.micro Elasticache instance for Redis
Free-tier CloudFront distribution (See #61)
Free-tier Application Load Balancer (ALB) with SSL certs via AWS Cert Manager

Since so much of the above qualifies for the AWS Free Tier, we should be able to provision an always-on staging environment very cheaply. The ECS instances will cost $0.0084 per hour, or $0.0025 if we can leverage Spot Instance pricing (we get a 2 minute warning before Spot Instances are reclaimed; might be suitable for API and Worker). The S3 bucket will have some minor costs (maybe a few dollars per month; depends on CDN configuration and user traffic). Everything else will be completely free.
Done in #75:

Getting our Node.js apps into ECR
Minimize Docker image size and ECR costs (We get 500MB of private storage free for 12 months, but each image is currently over 2GB; public storage is free up to 50GB)
Getting ECS to pull images from ECR

Done in #79:

Enabling logs in staging
Passing environment variables into deployed services, e.g. NODE_ENV=staging
Adding support for retrieving secrets in ECS tasks, e.g. Postgres connection string (which includes a password)

Much of this is done in #72, but there is a good bit of remaining work:

Getting our Node.js apps into ECR (or finding a way to dynamically start them from the node image, like we do locally)
Updating staging configs to make use of RDS and Elasticache; validating their networking configs
Remapping of ports on services to account for SSL, hosting Game+SP on the same LB, etc.
Github Actions to deploy service on merge (if we publish to ECR, that can be picked up automatically)
Update iamPolicy.json (which is already outdated given all the AWS access needed)

Done in #81


validate field NOT working

I've been trying to make validate field work, but it doesn't. I made a codepen for you to try it out.
https://codepen.io/phelipe-martin/pen/jpzzJG?editors=1010#
In the example, I'm trying to run form validation when user click "run function". However, I noticed while that validate form works, validate field doesn't (it returns boolean and does not change the UI).
Could someone check this out? Thanks!
OBS: I'm looking for a way to run the validation without submitting the form. The UI (error message) doesnt update properly with this check, unfortunately.

Semantic has built in support for validation on submit, blur and change https://semantic-ui.com/behaviors/form.html#form-settings

hammy, thanks for your input. I know that it works with submit, blur and change.
My problem is that validate field is not working


Allow Forcing Global Values After Manual Interaction

Currently, it is not possible to re-assert the applicability of Global Metadata after someone has manually interacted with an input—particularly a checkbox (boolean) input. We currently assume that checkboxes are always decoupled after interaction, whereas other inputs revert to the Global Metadata if cleared (i.e. cannot be empty if a global is set).
We need a way to allow for global values to assert themselves despite previous manual interaction.
Solutions
Checkboxes
To do this, we could have a "Force All" button on the global metadata popup, which will present a warning that this will overwrite any existing manual values.
Other Inputs
Similarly, we could include a "Force Empty" button that could take the place of automatic reversion to the Global Value.

@garrettmflynn How does the current global metadata behave? Is this needed any longer?

If a global default is specified, most inputs will fallback to this if cleared (e.g. text inputs, arrays, etc.).
However, checkboxes don't have a way to be cleared, so they're stuck with the user-defined state after the first interaction.
This would still be a nice feature to have—but we haven't had too many issues with it. There are very few checkboxes in the GUIDE at the moment

Summarized and moved to https://github.com/NeurodataWithoutBorders/nwb-guide/issues/846
Re-open again whenever this starts active development


Update paths parameter to reflect as a list item

This seems to be my issue too - getting:
resource script '/opt/resource/check []' failed: exit status 1

stderr:
2020/01/03 08:20:34 failed to unmarshal request: json: cannot unmarshal string into Go struct field Source.source.paths of type []string

And using a list instead of a string solved my problem.


Performance of state heavy applications

State heavy games seem to take a really hard toll on performance and dip well below the 80-90% performance rates I see everywhere else.
As far as I understand it would a similar caching mechanism to shader cache be able to be extended to any other element of the pipeline? Is it preferable to make some kind of a time/memory tradeoff in order to allocate GPU memory to reuse state to boost general performance?

What do you mean by "state-heavy games"?

Games heavily reliant on streaming elements that must be performed in a sequence.
Is it possible to cache any inputs of streaming elements so that they can be reused, the same way that shader state cache is done, and match them up to run calls in parallel?

I still don't understand what exactly you mean. What's a "streaming element"?

The game itself I'm having trouble with is Space Engineers now that it functions under wine at about 2/3 of the dx11 performance under most circumstances.
I don't know much about how graphical APIs work, was throwing some conjecture to see if I was onto anything, the game makes heavy use of stream output so I thought that might contribute, but I am going to try to get a trace of the game to pick through. What is your preferred trace method?
Would a Vulkan capture with renderdoc be any use for figuring out the slowdown?

Would a Vulkan capture with renderdoc be any use for figuring out the slowdown?

If you have an AMD Polaris card (RX 480/580 and similar models), then I could take a look at it, yes. Unfortunately, Vulkan renderdoc captures are not portable.
Otherwise, apitrace should hopefully work (see Wiki/Common Issues).

Closing due to the lack of feedback, and this doesn't seem to be a bug to begin with.


fix httpc warning at compiletime.

warning: :httpc.request/4 defined in application :inets is used by the current application but the current application does not directly depend on :inets. To fix this, you must do one of:

If :inets is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

If :inets is a dependency, make sure it is listed under "def deps" in your mix.exs

In case you don't want to add a requirement to :inets, you may optionally skip this warning by adding [xref: [exclude: :httpc]] to your "def project" in mix.exs

lib/zig/command.ex:197: Zig.Command.httpc_get/1

d1afc54


Wrap working directory path with quotes

Purpose
This changes will fix bal command broken issue in folders with spaces in their name.
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/32740
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.NipunaMadhushan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Can't hide the horizontal scroll indicator

I can't seem to hide the indicator, your example also shows it.  It's set to false in your class, but it's still there.  Any ideas?

You mean the horizontal scroll indicator @dcristolovean?
You have tried setting showsHorizontalScrollIndicator on the ScalingCarouselView itself?


Remove bucket configuration options

Per this discussion there are very few configuration options that are valid for bucket configurations and quite a few (ie most) that would be detrimental to performance.
We can consider:

strong flag value validation
named configuration sets (ie. can we classify when one valid config might be better than the other and have CONFIG_A, CONFIG_B, etc)
removal of the configuration option
leaving as-is and hoping documentation does the trick

cc @stevekuznetsov

duplicate of https://github.com/kcp-dev/kcp/issues/1592


Should the ‘concat’ parameter in line 20 of 'pytorch_geometric/examples/gat.py' be 'False'?

the code is below:
https://github.com/rusty1s/pytorch_geometric/blob/a6ed9c20da8784f4f39bd2e0eb062d9c87bbfb13/examples/gat.py#L20-L21
At the last layer, is it necessary to mean the output, that is, set 'cancat' to "False"?

No, it's not mandatory in case heads=1, but it might be if you add more heads.

It's changed in master now :)

Thanks for your prompt reply, I will close this issue.


Accessing SignInManager from class libraries

Describe the bug
In ASP.NET Core 2.x it was possible to access the SignInManager inside class libraries. The dependencies were resolved using DI, so I could write classes that access both the UserManager and the SignInManager. With ASP.NET Core 3 this is not working anymore.
Through the Microsoft.Extensions.Identity.Core package I can still reference the UserManager, but the SignInManager is not in there. If I change the project SDK to Microsoft.NET.Sdk.Web, everything is working as expected. But now a static Main method is required, something that I don't want in a class library.
To Reproduce
Steps to reproduce the behavior:

Use ASP.NET Core 3.0 preview 9
Create a new empty app
Create a new class library in the same solution
Try to create a class that references the SignInManager

Expected behavior
I've expected to see the SignInManager as well inside the Microsoft.Extensions.Identity.Core package, so using it from class libraries is still possible.
Additional context
Output of dotnet --info:
▶ dotnet --info
.NET Core SDK (gemäß "global.json"):
 Version:   3.0.100-preview9-014004
 Commit:    8e7ef240a5

Laufzeitumgebung:
 OS Name:     antergos
 OS Version:
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /opt/dotnet/sdk/3.0.100-preview9-014004/

Host (useful for support):
  Version: 3.0.0-preview9-19423-09
  Commit:  2be172345a

.NET Core SDKs installed:
  2.2.108 [/opt/dotnet/sdk]
  3.0.100-preview9-014004 [/opt/dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.NETCore.App 2.2.6 [/opt/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview9-19423-09 [/opt/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

UserManager lives on because it targets netstandard. Signin manager is tightly coupled to asp.net, cookies, http and so on, so it's not meant for class libraries. This is by design.
@davidfowl do you have any suggestions?

Me too, noticed this when i upgraded to newest preview (this broke the code). Also have a separation in which an extended signinmanager resides in class library. And if one would for example have handlers taking a signinmanager as injected dependency, i guess this means you are locked into having all these handlers reside only in the main project.
Is this something that might be changed or it is set in stone?

Your class library needs to target both .NET Core 3.0 and it needs a FrameworkReference to Microsoft.AspNetCore.App.

Thanks, that solved the issue.


ZIO 2 Updates

This is not intended to be merged into master. However, it shows some of the updates I made as part of "ZIO 2 Ecosystem Updates". Improvements and standardization of ZIO 2 naming conventions, mostly.
If no changes are required, would be nice to get another release for ZIO 2 out. 🙏
@fsvehla

Thanks, John.
Will cherry-pick for ZIO 1 branch


Better File API: Allow issuing multiple requests based on the same file

One of the problems with File API is that they take mutable references instead of immutable, despite that it has almost no state.
Originally posted by @NobodyXu in https://github.com/openssh-rust/openssh-sftp-client/issues/132#issuecomment-2222266655

Given that there's no request from users, I'm going to close this since I have a bunch of other stuff to do at this point.


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #17.
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #17

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Looks like cross-compiling with maturin works for linux-aarch64 but not linux-ppc64le.
Will have to take a closer look into why.

@mbargull do you have any idea how widespread use of linux-ppc64le is? E.g. download stats or similar?

@messense is the maturin expert, maybe he has an idea?
Might be worth trying build with linux-ppc64le on the main repo for pypi, just to see if the problem is just here.

I wouldn't be surprised if the build succeeds for native or emulated runs.
I haven't yet used those since I wanted to see if we can see why it fails (cause might be in maturin, but could also be in our Python builds, etc. pp.)
(I don't really care for PPC64le builds but I'm okay with having them if it "just works" alongside the other builds without much further effort. But debugging this could uncover bugs which might be relevant for other platforms as well.)

@mbargull do you have any idea how widespread use of linux-ppc64le is? E.g. download stats or similar?

There is https://github.com/ContinuumIO/anaconda-package-data :
(This is from the current year; data until August, inclusively.)
>>> import intake
>>> cat = intake.open_catalog('https://raw.githubusercontent.com/ContinuumIO/anaconda-package-data/master/catalog/anaconda_package_data.yaml')
>>> y = cat.anaconda_package_data_by_year(year=2022).to_dask()
>>> y[y.data_source == "conda-forge"].groupby("pkg_platform")["counts"].sum().compute().sort_values()
pkg_platform
linux-32                  0
osx-32                    0
linux-armv6l              0
linux-armv7l            911
linux-s390x          141494
win-32              1066070
linux-ppc64le      12173277
osx-arm64          45915883
linux-aarch64      59332597
osx-64            375839043
win-64            496141504
<PHONE_NUMBER>
linux-64<PHONE_NUMBER>
Name: counts, dtype: int64

I.e., only about 20 % w.r.t. linux-aarch64 (whereas you can expect increased usage for ARM builds over the next years).
(Personal opinion: I don't know why we burden maintainers with such a problematic (as in harder to get hardware/CI resources) platform.)

Nice, thanks for that. I assume the empty row is where you have no data for platform?

The only two failure are ppc64le pypy builds which I never tested 🤣.
Maybe you can just disable ppc64le pypy for now, I may take a deeper look when I have the time.

To be clear, I'm totally happy with dropping ppc64le completely - and especially with pypy.
@mbargull is that as simple as closing that PR, or do we need to do something else?

Nice, thanks for that. I assume the empty row is where you have no data for platform?

I'd assume those are the one from the noarch subdir (noarch: python/noarch: generic).

Let's leave this open for a few of days. If I don't get to look into it, I'll just drop those or try the emulated build.

I took a quick look and it's really just updating the sysconfig JSON file. I'll prep a PR for maturin.

I took a quick look and it's really just updating the sysconfig JSON file. I'll prep a PR for maturin.

See https://github.com/PyO3/maturin/pull/1258 .
Once we have a maturin package built with that change, we can rerun the CI here.
(We can just let this PR sit open until then.)

@mbargull The second issue you linked in your previous message is closed and was part of the v0.14.0 release a few days ago. Just letting you know.

@conda-forge-admin, please rerender

@mbargull The second issue you linked in your previous message is closed and was part of the v0.14.0 release a few days ago. Just letting you know n case you were not aware.

Nice, thanks! Then let's give this another go!

All builds are green. Can we merge this or is there still something to address here?


Login page does not load Jquery

Change login pages into
<!-- jQuery 2.1.4 -->
<script src="{{ asset('/plugins/jQuery/jQuery-2.1.4.min.js') }}"></script>
<!-- Bootstrap 3.3.2 JS -->
<script src="{{ asset('/js/bootstrap.min.js') }}" type="text/javascript"></script>
<!-- iCheck -->
<script src="{{ asset('/plugins/iCheck/icheck.min.js') }}" type="text/javascript"></script>

Sorry for the delay I was on holydays and I didn't see your issue? Could you give me more info? I don't understand the issue

I have added the above links to the base login page... Please add them...

Aghh ok I catch it! In my case sames all works ok (jquery is loading) bu I understand it could not work in all cases without asset!
Solved in new release 1.0.2


Death april

Original PR: https://github.com/biocore/qiita/pull/2099
Closed by mistake

The conflicts in this branch should be solved.

Codecov Report

Merging #2383 into dev will increase coverage by 0.04%.
The diff coverage is 98.6%.

@@            Coverage Diff             @@
##              dev    #2383      +/-   ##
==========================================
+ Coverage   94.42%   94.47%   +0.04%
==========================================
  Files         160      160
  Lines       19477    19694     +217
==========================================
+ Hits        18391    18605     +214
- Misses       1086     1089       +3

Impacted Files
Coverage Δ

qiita_db/test/test_util.py
99.65% <ø> (ø)
:arrow_up:

qiita_pet/handlers/rest/study.py
87.8% <100%> (ø)
:arrow_up:

qiita_db/handlers/tests/oauthbase.py
100% <100%> (ø)
:arrow_up:

qiita_pet/handlers/rest/study_samples.py
100% <100%> (ø)
:arrow_up:

qiita_db/handlers/prep_template.py
94.59% <100%> (ø)
:arrow_up:

qiita_db/handlers/artifact.py
97.46% <100%> (ø)
:arrow_up:

qiita_db/handlers/processing_job.py
96.92% <100%> (ø)
:arrow_up:

qiita_db/user.py
95.25% <100%> (+0.42%)
:arrow_up:

qiita_pet/handlers/rest/study_preparation.py
96.15% <100%> (ø)
:arrow_up:

qiita_db/handlers/core.py
100% <100%> (ø)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8b4c6...7022363. Read the comment docs.


Default replication factor

Description
According to the documentation the replication factor for a change log topic is 1.
This looks to be correct for change log topics but differs from the output of a call to .To(), which appears to assume the default value as configured by the broker.
I didn't spot in the documentation an option to change the replication factor for non change log topics.
Should there be configuration options for both change logs and standard streams?  My own preference is not to specify the option in code and to fall back to the default of the broker.  Is this currently an option for change log topics?
How to reproduce
Not a very useful example but does highlight the question...  Using the latest GA NuGet packages.
using Streamiz.Kafka.Net;
using Streamiz.Kafka.Net.SerDes;
using Streamiz.Kafka.Net.Stream;

var config = new StreamConfig<StringSerDes, StringSerDes>();
config.ApplicationId = "test-app";
config.BootstrapServers = "xxx";

StreamBuilder builder = new StreamBuilder();

builder.Stream<string, string>("test-input")
    .GroupByKey()
    .Reduce((x,y) => string.Concat(x,y))
    .ToStream("test-stream")
    .To("test-output");

Topology t = builder.Build();
KafkaStream stream = new KafkaStream(t, config);

Console.CancelKeyPress += (o, e) => {
    stream.Dispose();
};

await stream.StartAsync();

test-output has a replication factor of 3 in my environment
test-app-KSTREAM-AGGREGATE-STATE-STORE...... has a replication factor of 1

Hi @kevin-mcmanus ,
Streamiz just create the internal topics before starting the processing, that's why the replication.factor config is only applied for changelog or repartition topic.
Regarding the .To(..), this is not Streamiz which create the topic but directly the broker when the application try to produce the first message inside a none-existing topic
Kafka has a configuration to allow  the c
https://kafka.apache.org/documentation/#brokerconfigs_auto.create.topics.enable


Internal Server error when users log in and out of their profiles

As a User, I want a login to log information collected from completing a lab.
Associated Epic: None
Definition of Done

[ ] Acceptance criteria defined
[ ] Solution tasks specified
[ ] Feature branch created
[ ] Unit tests written (on API code only for now)
[ ] Solution passes full suite of unit tests
[ ] Design documents updated if needed
[ ] Pull request created
[ ] Code is reviewed
[ ] Code is merged to the develop branch
[ ] Tests pass on CI
[ ] Deployed to staging environment
[ ] Acceptance criteria is met

Acceptance Criteria

[ ] Given that when I log out of my account, I can use the site without my profile.
[ ] Given I log in with google, when I interact with google sso, then I'm signed into my user profile.

Solution Tasks

[ ] update package.json
[ ] update package call in auth.js
[ ] remove prior packages

![Screenshot 2023-03-26 at 1 47 55 PM](https://user-images.githubusercontent.com/16628631/227796611-1558041d-a041-4f4a-a045-5ca8f7b2ee23.png)


MultiCurl running past curl timeout

What is the expected behavior?
Each Curl instance is set with CURLOPT_TIMEOUT=>5 & CURLOPT_CONNECTTIMEOUT=>3 via the setOpt method. This should limit each handle to run a maximum of 5 seconds. If cURL multi is runs these instances in parallel, I would think the maximum time for each instance would be the maximum time for all instances.
What is the actual behavior?
It's taking much longer to run all of them. In fact, it's running faster with Curl than with MultiCurl
What steps will reproduce the problem?
This is run on a dedicated Centos server. Example code(modified):
$curl_opts = [
	CURLOPT_CONNECTTIMEOUT=>3,
	CURLOPT_TIMEOUT=>5
];
$multi_curl = new MultiCurl();
foreach($curl_opts as $key=>$value)
	$multi_curl->setOpt($key, $value);

$multi_curl->complete(function($instance){
	echo 1;
});

foreach($domains as $domain){
	$multi_curl->addGet('http://'.$domain);
	if(count($multi_curl->curls)>=5){
		$multi_curl->start(); // takes anywhere from 3s to 20s to run
		echo '<br>';
	}
}

Hi. You should probably only be calling start() once. In your example, it would be after queueing the requests.
$curl_opts = [
    CURLOPT_CONNECTTIMEOUT=>3,
    CURLOPT_TIMEOUT=>5
];
$multi_curl = new MultiCurl();
foreach($curl_opts as $key=>$value)
    $multi_curl->setOpt($key, $value);

$multi_curl->complete(function($instance){
    echo 1;
});

foreach($domains as $domain){
    $multi_curl->addGet('http://'.$domain);
}

$multi_curl->start();

Here's an another example
https://github.com/php-curl-class/php-curl-class/blob/master/examples/multi_curl_get_callbacks.php


ENH: add LTI class hierarchy and lti/dlti related functions

cross-ref https://github.com/cupy/cupy/issues/7403

[ ] StateSpace
[ ] TransferFunction
[ ] ZerosPolesGain
.
[x] dlti
[x] dlsim
[x] dimpulse
[x] dstep
[x] dbode
[x] dfreqresp
.
[x] lti
[x] lsim
[x] impulse
[x] step
[x] freqresp
[x] bode

Also add the matrix exponential, cupyx.scipy.linalg.expm.

DLTI hierarchy and related functions are done here. The PR is still in a draft status, for two reasons:

it depends on gh-7652, which brings low-level conversions between formats
static checkers complain about missing continuous LTI functions. These two, continuous and discrete LTI hierarchies, are sufficiently intertwined, so probably best to add both in the same PR. However continuous LTI evolution, lsim, relies on a matrix exponential, so this would require porting scipy.linalg.expm to CuPy.

We have a draft expm PR #5688, but don't hear from its author for so long, though.

Update:

Added expm. For the moment, only implement the Higham'2005 algorithm [1], in a simplified form:

[13/13] Pade approximant only (no selection of 3-5-7-9 orders)
no matrix balancing (this requires LAPACK's *gebal which is not available on CUDA): balancing could improve numerical stability.
the implementation is pure python + matmuls.

Added lsim, which is essentially expm(t*A) for t a linspace array. Like in scipy.signal, the computation is a python loop with a repeated application of expm(dt*A). While performance is not terrible, it can probably be improved by using an Al-Mohy & Higham 2010 algorithm for a t array [2]. Keeping it simple for now.

Added impulse and step, both are straighforward applications of lsim. Their APIs are annoyingly polymorphic (from 2000s), am keeping them compatible with scipy.signal. One annoying issue is that both use eigvals to estimate a default time span given the system matrix. Am delegating to np.linalg.eigvals. An alternative is to estimate the boundaries for the eigenvalues using Gershgorin theorems, but that would make the default behavior incompatible with scipy.signal.

[1] https://epubs.siam.org/doi/10.1137/04061101X
[2] https://eprints.maths.manchester.ac.uk/1300/1/

<rant mode on>  Have to admit I'm baffled by mypy complaining about ways to format module-level lists. What on earth is wrong with
b = [0] * 14
b[0] = 1
b[1] = 2
...

<rant mode off>
Anyway, this is fixed in https://github.com/cupy/cupy/pull/7660/commits/c4004004f7d1300cde3e0ed5bc2c0c72ee82b052.

OK, this now implements both continuous and discrete LTI functionality. Is ready from my side, modulo the need to rebase when   gh-7652 gets in.

Rebased on main, so this PR is ready for review from my side.

/test mini

have expm in another PR to separate from this one?

Done in https://github.com/cupy/cupy/pull/7744.
Meanwhile I hopefully fixed the CI errors in this PR, and will rebase this PR to remove expm-related commits when gh-7744 is decided on.

Done in https://github.com/cupy/cupy/pull/7744.

Thanks!

Rebased on main.

Pushed an update to relax the contiguity checks which were failing on CI for some configurations.

/test full

Thanks, @ev-br!


Please document required call to AddApiExplorer() when using services.AddMvcCore()

When ConfigureServices contains services.AddMvcCore() instead of services.AddMvc(), you need to chain a call to AddApiExplorer() (i.e. services.AddMvcCore().AddApiExplorer()) in order for the required services to be available for NSwag middleware to DI.
Couldn't find this anywhere on this page or in the NSwag docs and wasted time figuring this out when a couple of lines of explanation on this page would have avoided the issue :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2483813a-3c16-7ddd-3160-43e6843b55d4
Version Independent ID: 25f7fb5b-92b0-a45b-57ab-fdceab571884
Content: Get started with NSwag and ASP.NET Core
Content Source: aspnetcore/tutorials/getting-started-with-NSwag.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @zuckerthoben
Microsoft Alias: scaddie

Why are you calling services.AddMvcCore() instead of services.AddMvc() ?
AddMvcCore:  Adds the minimum essential MVC services to the specified . Additional services including MVC's support for authorization, formatters, and validation must be added separately using the returned from this method.


Bitwise subset

Is it possible to have a subset check (i.e. (a & b) == a) for two bitslices with no additional allocation using the current API?

Does this produce efficient code? If not, would a pull request implementing such API efficiently be welcome?

The compiler is generally pretty good about optimizing these accesses, but it is still a loop iteration per bit.
You can get faster behavior with
fn fast_subset<O, T>(a: &BitSlice<O, T>, b: &BitSlice<O, T>) -> bool
where O: BitOrder, T: BitStore {
  const W: usize = <usize as bitvec::mem::BitMemory>::BITS as usize;
  a.chunks(W).zip(b.chunks(W)).all(|| {
    let left = a.load::<usize>();
    let right = b.load::<usize>();
    a & b == a
  })
}

but it requires that a and b have the same type parameters. This is probably the case, and likely an easy change if not.

It sounds like you want .starts_with(). Right now this is a bitwise crawl, but I can speed it up with the implementation I wrote above.

In the next release, all behavior that uses == between two slices of the same type parameters (including .starts_with()) will use batched loading for accelerated comparison. Slices of different type parameters are not eligible for this acceleration, and will retain their individual-bit iteration behavior.


Error on Rate shop

I am getting an error when clicking Rate shop on Rate Rote workbench. The error says "Unexpected error occurred when processing request. Please verify server event log or contact administrator."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de983399-5d89-7c92-3663-91de7b2f5a58
Version Independent ID: 2b502fb3-764a-eeb0-7375-8a9b01472816
Content: Create a new transportation management engine - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/supply-chain/transportation/create-new-transportation-management-engine.md
Service: dynamics-ax-applications
GitHub Login: @MarkusFogelberg
Microsoft Alias: mafoge

Thanks for contacting us. Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: Support contact options.

I received the same error. The TMSLabelProvider class in the TMSFwkRateEngineFactory::createRateEngine class method was throwing this error on a local Dev VM: "Could not find engine assembly 'ThirdPartyTMSEngines.dll' at 'C:\AOSService\PackagesLocalDirectory\ApplicationSuite\bin\ThirdPartyTMSEngines.dll'." I moved the ThirdPartyTMSEngines DLL to the above directory and could see the expected result.


Extended cite completions

This adds cite completions from biblatex, natbib, apacite, and csquotes to the citation regex. I've also moved the regexes out of the refCiteComplete so they are compiled only once.

This is neat, and I would like to merge it. However, I'd like to at least think about the following improvement.
Right now, when cite completion is triggered by a keybinding, we capture whatever the user typed after { or ,---the "prefix". We don't use it yet, but the idea is to add the prefix to the filter editor in the select view. Then, as in Sublime, we would modify the code that actually inserts the completion so as to first erase the prefix. I haven't implemented it yet, but would like to. (It shouldn't be hard.)
This capturing is not done when cite completion is autotriggered. I turned it off to fix #72 . However, in a way, capturing a prefix would be more important to have for autotriggered text, because it would address Atom's slowness. On Sublime, as soon as I type \cite{, the panel is displayed instantaneously, so I can just continue typing as usual and the bibliography will be filtered as needed. So, while  (I think) the code still tries to capture the text after { or comma, in practice there is never any text that is actually captured. Atom instead waits for 300ms of no input before triggering autocompletions (if, as recommended and as we do, one uses onDidStopChanging to register an observer). In practice, this means that I very often manage to type a few letters after { before I catch myself and stop. If these letters were captured as a completion prefix, the perception would be much better.
However, we would then have trouble with #72 . The problem is the regex that allows for multiple, comma-separated citations. Right now, the logic is to allow for zero or more comma-separated citations, and then capture a prefix after that. Unfortunately, this also triggers if you have \cite{blah} in the editor and cursor back inside the curly braces. In a way, it's the correct behavior---if you typed \cite{blah and then paused, you would want to use blah as the prefix. But it's annoying. I think part of the problem is what Atom considers "changing": in principle, moving the cursor around should not qualify as such, but #72 proves otherwise.
So, for now, I have just left things as they are. But, if @ig0774 or someone else has a better idea, I'd love to hear it!


Suggestion: SS13 GitHub List

Summary
A list of SS13 codebases with links to their GitHub repos.
I went looking for one and initially didn't find one and was looking around your repo as to where to suggest you as one when I found your archived repo here: https://github.com/spacestation13/Space-Station-13 though it's a very short but detailed list. I'm curious to as why it's archived, and suggest you revive it or maybe add the list to this repo.

Feel free to revive that project if you want, just open PRs to it.


Sort docstring and kwargs of Tracks layer

References and relevant issues
similar to #6779, #6784, #6786, #6787 required for https://github.com/napari/napari/pull/6780
Description
For better discoverability, sort positional parameters of Tracks Layer Constructor.
Respectively, sort Parameters in docstring.
Required as we plan to add two new parameters in https://github.com/napari/napari/pull/6780

Same as the others, should we consider sorting Attributes too?


Add prompt or yes flag to helmfile delete

helmfile delete deletes all releases without any prompt. It may be dangerous because my colleague accidentally deleted all releases by the following command:
helmfile delete jenkins

He wanted to delete the specific release as like:
helm delete jenkins

I think the following behavior is nice.

helmfile delete should be error if any argument is given.
helmfile delete should show a prompt for delete confirmation, like Terraform.
helmfile delete --yes skips the prompt.

@int128 Hey! Thanks for the proposal.
I'm generally fine with the three improvements. Especially about 2 and 3, they sound like natural additions to helmfile given there's the momentum to make helmfile useful in use-cases similar to terraform.
The only thing I'd want to consider is that I and @cmeury found that helmfile delete would better behave similar to helm delete as discussed in https://github.com/roboll/helmfile/issues/71#issuecomment-376690779.

This doesn't conflict with my and @cmeury's intention to keep helmfile delete behave similar to helm delete(notice the difference between delete and destroy!

helmfile destroy --yes

I'd prefer --yes over --force because its short-hand -f is already occupied by --file 😉 I'm ok with --auto-approve if anyone wants a more terraform-like flag, but it doesn't make much sense given we already have difference between helmfile diff vs terraform plan!

WDYT?

This also brings up another point helmfile delete jenkins should result in a syntax error should it not?

Definitely! That would exactly be the 1. of the above suggestions, or am I missing something?

Looks good 👍. Also the help message says helmfile delete accepts some arguments but it should be fixed.
% helmfile delete --help
NAME:
   helmfile delete - delete releases from state file (helm delete)

USAGE:
   helmfile delete [command options] [arguments...]

OPTIONS:
   --purge  purge releases i.e. free release names and histories

Choice of CLI library is likely not a controversial issue; whatever works better works be my vote.

@mumoshu <3 cobra, but I would not be surprised if you did not have to make some breaking CLI changes to move to cobra since it handles things differently.


[Question] How to apply MS-AMP to only part of the model?

What's the issue, what's expected?:
I would like to apply MS-AMP to only parts of the model that are less sensitive to reduced precision.
Additional information:
Some parts of models are more sensitive to reduced precision than others but the current API makes it difficult to apply MS-AMP only to desired parts of the model. Is there an easy way of doing this?

Thanks! I will try it out!

Close this issue since there are no activities for a long time


Feature/ add Elasticsearch database alternative for typesense

Fixes #590  .
Changes proposed in this PR:

create abstract base database classes
created factory to instantiate one of the available databases
add elastic implementation for typesense databases
add datatoken address, nftAddress,  did in order index or schemas

How do we use elastic search on the nodes?
If i set this export DB_TYPE=elasticsearch
The node does not even starts ?
tkx

How do we use elastic search on the nodes? If i set this export DB_TYPE=elasticsearch The node does not even starts ? tkx

hmm strange, are you running barge with elastic search ? do you have the db env var pointing to proper elastic instance?

Nope, that's why we need to update documentation as well :-)

Looks like there are some conflicts, can you pull from main and resolve them?

i checked the conflicts. I think you can cherry-pick this commit for instance:
https://github.com/oceanprotocol/ocean-node/pull/706/commits/dcab22bea84010f078241dc98491106edcd8eb7b
We lost some functionality there, not sure why you deleted the utils function to check DB configuration..
Also, we cannot prooced to configure the DB transport if the DB url is not valid

i checked & fixed the conflicts on another branch. I think you can cherry-pick this commit for instance: dcab22b We lost some functionality there, for instance; we should not proceed to configure the DB transport if the DB url is not valid. That should be the first check Also, not sure why you deleted the utils function to check DB configuration.. what's the point of that? I'm also not sure about the try/catch on Database constructor (although i've kept it)... If there is an error being Throw doesn't that break the server startup? We should be able to use the node without DB

We should probably return null if we catch an error (instead on throwing a new Error)
and update the check on index:
const dbconn: Database = await new Database(config.dbConfig)
if (!dbconn || !hasValidDBConfiguration(config.dbConfig)) {
...
config.hasIndexer = false

@bogdanfazakas can you update from main? thanks

@bogdanfazakas can you update from main? thanks

Yep sure


support Matrix.reshape function

close #13

Good idea. I'm wondering, perhaps the reshape method should be on the Matrix prototype. In other words, you first build a Matrix and you can reshape it, which will return a newly constructed Matrix. What are your thoughts on this?

@hiddentao
If it's on the Vector prototype, then it sounds a good idea to me.
The problem is that Matrix has two dimensions, so we don't know how how to reshape from it.
For example, we may reshape from rows to cols and vice versa.
This is why numpy.reshape only accepts array like object for it's argument,
even though the library usually works with any dimensions.

Ok. I think it should be on Matrix since it produces a matrix and it should be called reshapeFrom. It should return a new Matrix instance:
Matrix.reshapeFrom([1,2,3,4,5,6],2,3).toArray();
// [[1,2,3],[4,5,6]]

Agree?

Perfectly Agreed!!

@hiddentao pushed!

Thanks.


vscode extension: use esbuild instead of rollup.

This shaves a couple seconds off our build & trims npm dependencies. I tested it using VSCode's "Install [Extension] from VSIX" option and it seems to work. Note that it changes the root of the package from out/src/main → out/main.
Fell out of the discussion in #9179

 +24 −373

<3
Just for my curiosity, what's -S for npm run? I couldn't find anything in the documentation.

Tested, I can confirm the faster build and that the extension still works (which isn't always the case after this kind of change).

Just for my curiosity, what's -S for npm run? I couldn't find anything in the documentation.

Good question! It's the save command. It appears to be unnecessary past Node 5, but I added it before I knew what it was since the 'Bundling Extensions' guide recommends it.

Seems that -S is just a typo then in the docs: unless I am missing something, it makes no sense in the given context. Let's remove it here (and might be a good idea to send a PR to upstream docs/examples)

Yeah, --save makes less sense for npm run, doesn't it?

bors r+
:tada:

Seems that -S is just a typo then in the docs: unless I am missing something, it makes no sense in the given context. Let's remove it here (and might be a good idea to send a PR to upstream docs/examples)

I think npm run -S ... is actually doing npm -S run ..., so the flag technically works. I wonder if they support node <= 5, but I have opend the PR and we can see what they say. I've removed it here.

changelog internal (first contribution) switch from rollup to esbuild.


Check default arguments even if a function has no body

This is needed for textual interfaces, but the behavior doesn't have to be specific to that, since functions without bodies don't come up in other situations.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - a50553a70cbb2bfc16f2843fece96a06b9489ce0

Oops. I saw that this test failed, but it's relying on old behavior of SourceLoader and isn't worth preserving.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - a50553a70cbb2bfc16f2843fece96a06b9489ce0

Build failed
Swift Test Linux Platform
Git Sha - a50553a70cbb2bfc16f2843fece96a06b9489ce0

Build failed
Swift Test OS X Platform
Git Sha - a50553a70cbb2bfc16f2843fece96a06b9489ce0

22:46:46 Failing Tests (3):
22:46:46     lldb-Suite :: lang/swift/conditional_breakpoints/TestSwiftConditionalBreakpoint.py
22:46:46     lldb-Suite :: lang/swift/stepping/TestSwiftStepping.py
22:46:46     lldb-Suite :: lang/swift/struct_init_display/TestSwiftStructInit.py

These three again. @dcci, maybe it's worth re-excluding them for now?

@swift-ci Please test Linux

@jrose-apple yes, I think we should exclude them again (cc: @fredriss/ @vedantk)

In fact, I thought they're still excluded (they're still marked as swift-test, but not swift-pr). I think this is because we now run the full suite (sorry I don't have more details, this was presumably deployed last week when I was out).

The swiftpr test whitelist was disabled recently. I filed a bug tracking a fix to the underlying issue with these tests. I'll mark these tests as being fully skipped for now.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In fa21b3e, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 6962 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in fcb64e1.


Converted OracleFeed to use Overflow table.

What kind of PR is this?:

/kind feature
What this PR does / why we need it:
Implemented Overflow table to make oraclesFeed more responsive
Which issue(s) does this PR fixes?:

Fixes #261
Additional comments?:
Developer Checklist:

[x] Read your code changes at least once
[x] Tested on multiple web browsers
[x] Tested responsiveness (e.g, iPhone, iPad, Desktop)
[x] No console errors
[x] Unit tests*
[x] Added e2e tests*

Codecov Report

Merging #265 (8e354ef) into main (1a8c838) will decrease coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   80.44%   79.93%   -0.52%
==========================================
  Files          51       51
  Lines         588      588
  Branches      132      132
==========================================
- Hits          473      470       -3
- Misses        106      110       +4
+ Partials        9        8       -1

Impacted Files
Coverage Δ

src/components/prices/PriceOracleTable.tsx
93.33% <100.00%> (+6.66%)
:arrow_up:

src/components/commons/popover/HoverPopover.tsx
60.00% <0.00%> (-20.00%)
:arrow_down:

src/pages/blocks/index.tsx
90.90% <0.00%> (-9.10%)
:arrow_down:

src/components/prices/PriceTickerDetail.tsx
75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a8c838...8e354ef. Read the comment docs.

please rebase properly


WIP: Fix broken ReflectionUnionTypes

Summary
This PR addresses issue #1129 , fixing exceptions thrown when a union type is present both in return type and parameter types
In php 8 ReflectionType class is subclassed by ReflectionUnionType , which is missing getName() and isBuiltin() methods. This code changes aim at defining an intermediary function that:

handles ReflectionUnionTypes by splitting them in an array of ReflectionNamedTypes.
handles single ReflectionNamedTypes, wrapping them in an array in order to handle the same data type

protected function extractReflectionTypes(\ReflectionType $reflection_type)
{
    if($reflection_type instanceof \ReflectionUnionType){
        foreach ($reflection_type->getTypes() as $named_type){
            if($named_type->getName()==='null'){
                continue;
            }

            $types[] = $this->getReflectionNamedType($named_type);
        }
    }else{
        $types[] = $this->getReflectionNamedType($reflection_type);
    }

    return $types;
}

the getReflectionNamedType() function wraps the old code for extracting the parameter name and adding \\ in case of builtin type:
protected function getReflectionNamedType(\ReflectionNamedType $paramType): string
{
    $parameterName = $paramType->getName();
    if (!$paramType->isBuiltin()) {
        $parameterName = '\\' . $parameterName;
    }

    return $parameterName;
}

These two functions are used to convert the two subclasses of ReflectionTypes to their respective dockblock strings
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist

[ ] Existing tests have been adapted and/or new tests have been added
[ ] Add a CHANGELOG.md entry
[ ] Update the README.md
[x] Code style has been fixed via composer fix-style

@def-studio first quick look looks good! you mentioned in the issue assistance with tests => let me ask you first, did you check out the existing ones? Especially the ModelsCommand has lots of them, please see https://github.com/barryvdh/laravel-ide-helper/tree/master/tests/Console/ModelsCommand

@def-studio first quick look looks good! you mentioned in the issue assistance with tests => let me ask you first, did you check out the existing ones? Especially the ModelsCommand has lots of them, please see https://github.com/barryvdh/laravel-ide-helper/tree/master/tests/Console/ModelsCommand

Just checking it, will update code soon (or ask for clarifications if needed :innocent:  )

@mfn I've added a new test directory tests/Console/ModelsCommand/UnionTypes which tests a model with some use cases:
union types in parameters:
public function scopeWithUnionTypeParameter(Builder $query, string|int $bar): Builder
{
    return $query->where('foo', $bar);
}

nullable union type in parameters:
public function scopeWithNullableUnionTypeParameter(Builder $query, null|string|int $bar): Builder
{
    return $query->where('foo', $bar);
}

union type in return type:
public function withUnionTypeReturn(): HasMany|UnionTypeModel
{
    return $this->hasMany(UnionTypeModel::class);
}

nullable union type in return type:
public function getFooAttribute(): string|int|null
{
    return $this->getAttribute('foo');
}


Path to support labels, text, images, etc in iOS

I tried to add labels/text input for the iOS example and ran into a bunch of feature flags.
Is there a way to get labels/text wired up for iOS?
If not, can you give some direction on how to add it via a PR? I understand some of the code patterns, but there's still some architecture (make an Architecture.md?) that I would need to dig into to understand how to enable it properly. Also, is there a obj-c spec you're working off of or just using your ios/macos dev experience to know which NS concepts to bridge over?

Unfortunately the iOS demo is (for the moment) barebones, yeah - it was mostly done first to make sure I could even support the UIScene+Delegate APIs that modern iOS needs, which was tricky to figure out how to do.
The good news is that from here on out adapting things shouldn't be too bad. I'm guessing the feature flags you hit were the target_os = "macos" ones in lib.rs? If so, yeah - that's mostly just to gate things so the iOS demo compiled, and it acts as a marker for what's support across the two.
If you want to jump in, the text module is probably the most straightforward to make compatible with iOS. It'd really come down to two things needing to be done:

If the target's iOS, just call UIFont instead of NSFont. No docs in front of me but the initializers should be common enough that I think this'll just work.
Add a label/ios.rs, which currently could be a clone of label/macos.rs but with swapped class names.
Update label/mod.rs to support UILabel, which with how it's currently set up, would mostly (I think) just be calling something other than stringValue.

Images are also theoretically decent to start with, but there's a custom draw handler I added and the API for that is slightly different across OS's so I might want to revisit it. Not sure.
I think an architecture.md is a great idea - I'm in moreso docs writing mode right now anyway so it fits in. If I can find some time this afternoon I'll get it added.

Oh, and:

Also, is there a obj-c spec you're working off of or just using your ios/macos dev experience to know which NS concepts to bridge over?

Ish, yeah. I've been aiming for somewhat of a "common" API between the two OS's for two reasons:

I think eventually Swift/UI will be the blessed path for Apple's ecosystem, and anything that's ultra confusing is just a negative in comparison.
Each control should always expose an objc property that can be unsafely message passed to directly if need be, so people can drop to the underlying ObjC level and do anything not covered.
I'm wagering that anybody who needs or wants the nuances of AppKit vs UIKit would be looking at writing separately in ObjC or Swift anyway. Gonna guess that Rust users would prefer the "one damn API" approach first with the option for flexibility.

I'd say that in general I try to err towards the iOS-style methods, since I think people are more familiar with those.
tl;dr yeah, a lot of it is my personal experience with ios/macos/tvos experience, but I'm pretty open to whatever. If it's helpful I suppose I could put together a channel somewhere for more discussion on this?

I threw together a basic Architecture document - not perfect by any means, but it walks (or stumbles) through the View<T> type to kind of explain how things are typically set up. Can try to find time to flesh it out more.

I could put together a channel somewhere for more discussion on this?

I would be interested to join! We are looking to build @tauri-apps for iOS/tvOS and maybe migrate our wry macOS implementation.
btw; amazing work!

Cool, I can look at setting something up today.
Tauri apps might be hard on tvOS, if I'm understanding (at a glance) what you want to do, as no WebView is supported there. It's by far the least explored platform for Cacao though, so plenty of time to dig further anyway.

FWIW, #48 adds image support for iOS. I would be curious what "core controls" people would need/want supported on iOS so that shoring up that side of things could happen.
(I know this issue is old, so apologies for raising a zombie here)

(#48 has been merged)


Resources tab behind instructions

Functional "Docs" tab behind console window and instruction tab.
This can start out as just a place for a static markdown doc, but has potential to hold dynamic help links based on the tutorial contents.

Tabs are gone in the new design.


form added; not to merge; to be done separately

tags added ; auto-complete to be implemented

Thanks! @ankita132.  I'll go ahead and merge this and make necessary changes and finally send a PR to the master branch.


Bytecode cache does not invalidate old items, leading to spurious errors after 2.8->2.9 upgrade

I've performed a 2.8.1->2.9.3 upgrade and experienced inexplicable macro errors*. When debugging these, the errors went away, and it turned out they were caused by the bytecode cache. Entries generated with Jinja 2.8 stayed in the cache and were found by 2.9.
The documentation or changelog makes no mention of a necessity for cleaning the bytecode during a version upgrade, so I would consider it a bug Jinja does not invalidate entries made using a previous version automatically. Thoughts?

For example, the macro argument count would be identified incorrectly, leading to runtime errors such as this:

    {{ abc.ABC(request, "one", "two") }}
TypeError: macro() takes exactly 3 arguments (4 given)

even when the macro is defined as
{% macro ABC(request, class_one="", class_two="") %}

That's indeed an oversight.

Thanks for the quick fix!


Skip leading whitespace when detecting JSON writes without content-type

Fixes #2834

Makes general sense to me, though I do think the check might be a bit broad. It allows lots of characters other than whitespace. +1 if you are sure this is the right thing to do.

+1


Version 1.0.1 broke semver guarantees

The release of version 1.0.1 broke semver compatibility guidelines by removing the overloads module:
https://github.com/jackmott/simdeez/commit/71f6edb1ac89cc4a233e62291f6920c43b6134fb#diff-b4aea3e418ccdb71239b96952d9cddb6L138
This subsequently broke my build as simdnoise depends on simdeez, and simdnoise has not yet been upgraded on crates.io to account for the breaking change.

sorry about that, fix incoming

ok grab latest rust-simd-noise and let me know if all is well

It's fixed now, thanks for the quick response!


Tagging

Check tagging via lassoing. It doesn't allow you to add a new tag or close on Save. Same with shortcut tagging.

@jessicagood close on shortcut modal cannot be done as we have the last spot created option on that modal. But the same is handled with lassoing tags.
Also the save tags makes sense because for shortcut modal, we create a spot as part of the save logic. Now if we remove save then it gets a bit cumbersome. Its still achievable, but we might have to handle a lot of cases like,
on the first check of a tag we create the spot, and questions like, do we delete the spot "if all the tags are unchecked etc ?" arise.
Please let me know how you want me to take this forward here.

Closing this issue with commit 91ba1aa3c2ca38ffeec491257e2d1503ca9c7f73


Lacks console tracing

Describe the bug
When an error occurs, it's not directly visible to a user. She has to find out name of the log file and look there.
To Reproduce
Set log level to DEBUG and run a jfrog-cli rt download command which fails with an SSH Agent error, e.g. due to a mistyped host name.
Expected behavior
The SSH Agent error is printed to stderr when verbosity is high.
Screenshots
You see the confusing error message below because the key is encrypted but SSH-Agent which failed, so the fallback to a different method is active
:
$ jfrog-cli rt download ...
 Log path: /tmp/jfh/logs/jfrog-cli.2020-11-04.09-55-50.27487.log
{
  "status": "failure",
  "totals": {
    "success": 0,
    "failure": 0
  }
}
[Error] SSH Key is encrypted but no passphrase was specified.

$ cat /tmp/jfh/logs/jfrog-cli.2020-11-04.09-55-50.27487.log
[Info] Performing SSH authentication...
[Info] Trying to authenticate via SSH-Agent...
[Debug] Usage info is disabled.
[Info] Authentication via SSH-Agent failed. Error:
 dial tcp: lookup artifactory.example.com on <IP_ADDRESS>:53: no such host
[Info] Trying to authenticate via SSH Key...
[Info] Authentication via SSH key failed.

Versions

JFrog CLI version: 1.40.1
JFrog CLI operating system: Debian buster / Debian sid
Artifactory Version: unknown, doesn't matter

Thanks for reporting this issue, @rico-chet.
The JFrog CLI shows a progress bar when a human user downloads or uploads files.
In order to show the progress bar neatly, we redirect all outputs to a file, except the command summary.
In CI servers we print the logs to the screen instead. Therefore, setting environment variable CI=TRUE will be an easy workaround for you. Simply run:
CI=TRUE jfrog-cli rt download

By the way, do you see this behavior in a CI server? I'd like to know.
Please let me know what you think.

Thank you for the response. I don't remember if I saw this in CI, I set it a year ago (and I am not sure we have the CI environment variable set...).
Now as a user, I run a script which caches a git LFS Artifactory repository for faster cloning. It's done via SSH and my keys are passphrase-protected with an SSH agent active to save the typing. I will add CI=TRUE to my script to get to the reason of failure faster next time. Maybe a new CLI parameter would be handy for this to be available in a more straightforward way. I cannot come up with a nice name, though.
You can close this issue if you like.


fix: add default disruption stanza (#1662)

Fixes #N/A
Description
cherrypicks 1662
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm