Razor stops working randomly in production with stacktrace that ends in Roslyn.Utilities.TextKeyedCache

Hi,
Not sure if this is the right asp project to post this in, but I have noticed that my asp application throws a null pointer exception after about a week of working fine (probably depends on the usage).
It's a asp.net core 1.0.0 app running in a docker container.
After the stack trace, the application becomes useless. Every request gives a 200 OK with no body. The stacktrace is produced every single time.
If this is not the right project to post this on, please point me in the right direction :)
Thanks
fail: Microsoft.AspNetCore.Server.Kestrel[13]
      Connection id "0HKTHG7OPLJ3E": An unhandled exception was thrown by the application.
System.NullReferenceException: Object reference not set to an instance of an object.
   at Roslyn.Utilities.TextKeyedCache`1.AddSharedEntry(Int32 hashCode, SharedEntryValue e)
   at Roslyn.Utilities.TextKeyedCache`1.AddItem(Char[] chars, Int32 start, Int32 len, Int32 hashCode, T item)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LexerCache.LookupToken(Char[] textBuffer, Int32 keyStart, Int32 keyLength, Int32 hashCode, Func`1 createTokenFunction)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer.QuickScanSyntaxToken()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer.Lex(LexerMode mode)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.SyntaxParser.PreLex()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.SyntaxParser..ctor(Lexer lexer, LexerMode mode, CSharpSyntaxNode oldTree, IEnumerable`1 changes, Boolean allowModeReset, Boolean preLexIfNotIncremental, CancellationToken cancellationToken)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser..ctor(Lexer lexer, CSharpSyntaxNode oldTree, IEnumerable`1 changes, LexerMode lexerMode, CancellationToken cancellationToken)
   at Microsoft.CodeAnalysis.CSharp.CSharpSyntaxTree.ParseText(SourceText text, CSharpParseOptions options, String path, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRoslynCompilationService.Compile(RelativeFileInfo fileInfo, String compilationContent)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.CompilerCache.CreateCacheEntry(String relativePath, String normalizedPath, Func`2 compile)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.CompilerCache.GetOrAdd(String relativePath, Func`2 compile)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRazorPageFactoryProvider.CreateFactory(String relativePath)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.CreateCacheResult(HashSet`1 expirationTokens, String relativePath, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.OnCacheMiss(ViewLocationExpanderContext expanderContext, ViewLocationCacheKey cacheKey)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.LocatePageFromViewLocations(ActionContext actionContext, String pageName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.ViewEngines.CompositeViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor.FindView(ActionContext actionContext, ViewResult viewResult)
   at Microsoft.AspNetCore.Mvc.ViewResult.<ExecuteResultAsync>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResultAsync>d__32.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResultFilterAsync>d__31.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAllResultFiltersAsync>d__29.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResourceFilterAsync>d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAsync>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.RequestServicesContainerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame`1.<RequestProcessingAsync>d__2.MoveNext()
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 30.2199ms 200

@glennc for context + area for the right project this should be posted to.

@NTaylorMullen Roslyn bugs go to https://github.com/dotnet/roslyn/issues/. Do we think this is a Roslyn bug? Or at least they would be best to investigate?

/cc @jaredpar

@Sebas- do you know what view was being rendered?

@davidfowl Yes, just scanned my log and it seems the authentication page is the most likely candidate. (site monitoring is hitting that page every minute, so that would make sence).
Since it's a login page, it has no special logic, so I doubt it's the cause (it only gets requested the most).
I've just scanned for all the null pointer exceptions in the docker logs output, and probably found another variation of the same issue. Since the log output is not timestamped by default(!) I can not tell you how often it threw the exception in which timespan.
One that might be related
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.SyntaxNodeCache.AddNode(GreenNode node, Int32 hash)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.ContextAwareSyntax.ArgumentList(SyntaxToken openParenToken, SeparatedSyntaxList`1 arguments, SyntaxToken closeParenToken)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseParenthesizedArgumentList()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseArrayOrObjectCreationExpression()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNewExpression()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseTerm(UInt32 precedence)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseSubExpressionCore(UInt32 precedence)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseSubExpression(UInt32 precedence)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseArgumentExpression(Boolean isIndexer)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseArgumentList(SyntaxToken& openToken, SeparatedSyntaxList`1& arguments, SyntaxToken& closeToken, SyntaxKind openKind, SyntaxKind closeKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseParenthesizedArgumentList()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseArrayOrObjectCreationExpression()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNewExpression()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseTerm(UInt32 precedence)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseSubExpressionCore(UInt32 precedence)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseSubExpression(UInt32 precedence)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseElementInitializer()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseVariableInitializer(Boolean allowStackAlloc)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseVariableDeclarator(TypeSyntax parentType, VariableFlags flags, Boolean isFirst, Boolean isExpressionContext)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseVariableDeclarators(TypeSyntax type, VariableFlags flags, SeparatedSyntaxListBuilder`1 variables, Boolean variableDeclarationsExpected)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseVariableDeclarators(TypeSyntax type, VariableFlags flags, SeparatedSyntaxListBuilder`1 variables, SyntaxKind parentKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNormalFieldDeclaration(SyntaxListBuilder`1 attributes, SyntaxListBuilder modifiers, TypeSyntax type, SyntaxKind parentKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseMemberDeclarationOrStatement(SyntaxKind parentKind, String typeName)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseClassOrStructOrInterfaceDeclaration(SyntaxListBuilder`1 attributes, SyntaxListBuilder modifiers)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseTypeDeclaration(SyntaxListBuilder`1 attributes, SyntaxListBuilder modifiers)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseMemberDeclarationOrStatement(SyntaxKind parentKind, String typeName)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNamespaceBody(SyntaxToken& openBrace, NamespaceBodyBuilder& body, SyntaxListBuilder& initialBadNodes, SyntaxKind parentKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNamespaceDeclaration()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNamespaceBody(SyntaxToken& openBrace, NamespaceBodyBuilder& body, SyntaxListBuilder& initialBadNodes, SyntaxKind parentKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseCompilationUnitCore()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseWithStackGuard[TNode](Func`1 parseFunc, Func`1 createEmptyNodeFunc)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseCompilationUnit()
   at Microsoft.CodeAnalysis.CSharp.CSharpSyntaxTree.ParseText(SourceText text, CSharpParseOptions options, String path, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRoslynCompilationService.Compile(RelativeFileInfo fileInfo, String compilationContent)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.CompilerCache.CreateCacheEntry(String relativePath, String normalizedPath, Func`2 compile)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.CompilerCache.GetOrAdd(String relativePath, Func`2 compile)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRazorPageFactoryProvider.CreateFactory(String relativePath)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.CreateCacheResult(HashSet`1 expirationTokens, String relativePath, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.OnCacheMiss(ViewLocationExpanderContext expanderContext, ViewLocationCacheKey cacheKey)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.LocatePageFromViewLocations(ActionContext actionContext, String pageName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.ViewEngines.CompositeViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor.FindView(ActionContext actionContext, ViewResult viewResult)
   at Microsoft.AspNetCore.Mvc.ViewResult.<ExecuteResultAsync>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResultAsync>d__32.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResultFilterAsync>d__31.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAllResultFiltersAsync>d__29.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResourceFilterAsync>d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAsync>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.RequestServicesContainerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame`1.<RequestProcessingAsync>d__2.MoveNext()
^[[100m^[[32minfo^[[39m^[[0m: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 1330.1372ms 200

and
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.EqualsValueClauseSyntax..ctor(SyntaxKind kind, SyntaxToken equalsToken, ExpressionSyntax value, SyntaxFactoryContext context)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.ContextAwareSyntax.EqualsValueClause(SyntaxToken equalsToken, ExpressionSyntax value)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseVariableDeclarator(TypeSyntax parentType, VariableFlags flags, Boolean isFirst, Boolean isExpressionContext)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseVariableDeclarators(TypeSyntax type, VariableFlags flags, SeparatedSyntaxListBuilder`1 variables, Boolean variableDeclarationsExpected)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseVariableDeclarators(TypeSyntax type, VariableFlags flags, SeparatedSyntaxListBuilder`1 variables, SyntaxKind parentKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNormalFieldDeclaration(SyntaxListBuilder`1 attributes, SyntaxListBuilder modifiers, TypeSyntax type, SyntaxKind parentKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseMemberDeclarationOrStatement(SyntaxKind parentKind, String typeName)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseClassOrStructOrInterfaceDeclaration(SyntaxListBuilder`1 attributes, SyntaxListBuilder modifiers)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseTypeDeclaration(SyntaxListBuilder`1 attributes, SyntaxListBuilder modifiers)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseMemberDeclarationOrStatement(SyntaxKind parentKind, String typeName)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNamespaceBody(SyntaxToken& openBrace, NamespaceBodyBuilder& body, SyntaxListBuilder& initialBadNodes, SyntaxKind parentKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNamespaceDeclaration()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseNamespaceBody(SyntaxToken& openBrace, NamespaceBodyBuilder& body, SyntaxListBuilder& initialBadNodes, SyntaxKind parentKind)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseCompilationUnitCore()
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseWithStackGuard[TNode](Func`1 parseFunc, Func`1 createEmptyNodeFunc)
   at Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.LanguageParser.ParseCompilationUnit()
   at Microsoft.CodeAnalysis.CSharp.CSharpSyntaxTree.ParseText(SourceText text, CSharpParseOptions options, String path, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRoslynCompilationService.Compile(RelativeFileInfo fileInfo, String compilationContent)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.CompilerCache.CreateCacheEntry(String relativePath, String normalizedPath, Func`2 compile)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.CompilerCache.GetOrAdd(String relativePath, Func`2 compile)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRazorPageFactoryProvider.CreateFactory(String relativePath)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.CreateCacheResult(HashSet`1 expirationTokens, String relativePath, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.OnCacheMiss(ViewLocationExpanderContext expanderContext, ViewLocationCacheKey cacheKey)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.LocatePageFromViewLocations(ActionContext actionContext, String pageName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.ViewEngines.CompositeViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor.FindView(ActionContext actionContext, ViewResult viewResult)
   at Microsoft.AspNetCore.Mvc.ViewResult.<ExecuteResultAsync>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResultAsync>d__32.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResultFilterAsync>d__31.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAllResultFiltersAsync>d__29.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResourceFilterAsync>d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAsync>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.RequestServicesContainerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame`1.<RequestProcessingAsync>d__2.MoveNext()

I also have found this one (only 1 occurrence), perhaps it is related:
System.NullReferenceException: Object reference not set to an instance of an object.
   at System.ArraySegment`1..ctor(T[] array, Int32 offset, Int32 count)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Infrastructure.MemoryPoolIteratorExtensions.GetArraySegment(MemoryPoolIterator start, MemoryPoolIterator end)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame.TakeMessageHeaders(SocketInput input, FrameRequestHeaders requestHeaders)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame`1.<RequestProcessingAsync>d__2.MoveNext()

and 2 null reference exceptions that cause the whole docker container (the app) to segfault and die.
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at System.Threading.ThreadPoolWorkQueue.WorkStealingQueue.TrySteal(IThreadPoolWorkItem& obj, Boolean& missedSteal, Int32 millisecondsTimeout)
   at System.Threading.ThreadPoolWorkQueue.Dequeue(ThreadPoolWorkQueueThreadLocals tl, IThreadPoolWorkItem& callback, Boolean& missedSteal)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
Aborted (core dumped)

Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at System.Threading.ThreadPoolWorkQueue.Dequeue(ThreadPoolWorkQueueThreadLocals tl, IThreadPoolWorkItem& callback, Boolean& missedSteal)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
Aborted (core dumped)

Probably unrelated, but again, no idea which project to post this in :)
Hope this helps.

@halter73 @cesarbs @mikeharder FYI about the Kestrel null ref in the memory pool a few call stacks above...
System.NullReferenceException: Object reference not set to an instance of an object.
   at System.ArraySegment`1..ctor(T[] array, Int32 offset, Int32 count)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Infrastructure.MemoryPoolIteratorExtensions.GetArraySegment(MemoryPoolIterator start, MemoryPoolIterator end)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame.TakeMessageHeaders(SocketInput input, FrameRequestHeaders requestHeaders)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame`1.<RequestProcessingAsync>d__2.MoveNext()

If it seems like there might be a Kestrel bug here please log a new Kestrel bug.

@Eilon A null reference exception from inside of ArraySegment1..ctor` is really weird. MSDN claims it should throw an
ArgumentNullException instead of a NullReferenceException. A quick look at the source on GitHub shows the same.
I double checked our code in GetArraySegment, and it seems to properly null check and return default(ArraySegment<byte>) if the argument would have been null, and there aren't any apparent race conditions. It seems to be something lower level than Kestrel that must have broken.

Been looking at the original roslyn stack trace:
System.NullReferenceException: Object reference not set to an instance of an object.
   at Roslyn.Utilities.TextKeyedCache`1.AddSharedEntry(Int32 hashCode, SharedEntryValue e)
   at Roslyn.Utilities.TextKeyedCache`1.AddItem(Char[] chars, Int32 start, Int32 len, Int32 hashCode, T item)

This is definitely a weird error.  The code inside AddSharedEntry, and all of it's called methods within Roslyn, has very few member accesses to inspect.  None of them appear to be a possible source for an NRE.
The source code is here for the curious.
The array value arr is accessed several times in the method:
if (arr[curIdx].Entry == null)
arr[idx].HashCode = hashCode;
Volatile.Write(ref arr[idx].Entry, e);

Yet arr is just a local that points to _sharedTableInst.  That in turn is a readonly field which is given a non-null value at object instantiation time.
private readonly SharedEntry[] _sharedTableInst = s_sharedTable;

Hence arr is non-null at creation time and is never assigned another value.  It is not the source of the NRE.
That is the only member access on a class in the method.  Looking at potentially inlined methods gives us one more member access in NextRandom:
return r.Next();

In that function though r is guaranteed to have a non-null value.  It's a local that's checked for null, then unconditionally assigned a new Random value before use.
It seems like other stack traces are also producing "impossible" NRE exceptions.  Is it possible that memory is corrupt here and leading to spurious NRE errors?

It seems like other stack traces are also producing "impossible" NRE exceptions. Is it possible that memory is corrupt here and leading to spurious NRE errors?

Could be. Also, once there was a JIT bug that IIRC caused an NRE at an unexpected place (but might have been AccessViolationException - @halter73 probably remembers it better than I do).

It was an AV. Here's the original issue: https://github.com/dotnet/coreclr/issues/4115

@NTaylorMullen can you take a look at this and see if we need to split this out into separate bugs, and file those as appropriate? It seems quite unlikely that there's a Razor bug here, and presumably no Roslyn bug, either.

Tried picking apart the NRE sources discussed in this issue and came up with two potential issues that Roslyn could work together with @Sebas- to solve:

https://github.com/dotnet/roslyn/issues/12912
https://github.com/dotnet/roslyn/issues/12913

As for the other unaddressed NRE's in this thread I couldn't find decent answers as to how they could even NRE to begin with. Memory corruption or a bad jit is the only conclusion one could draw. However, that's a masssssive problem space to investigate in without a repro. If @Sebas- is able to provide a  reproducible bit of code/project I can investigate further and potentially file issues.

Can you share the code that is producing the issue?

I'm unclear why the first Roslyn issue was filed.  As I elaborated in my comment, there is no known path for an NRE other than memory corruption.   The only possible action for the Roslyn issue is "Not Repro / External".

@NTaylorMullen I'm unclear why the first Roslyn issue was filed. As I elaborated in my comment, there is no known path for an NRE other than memory corruption. The only possible action for the Roslyn issue is "Not Repro / External".

@jaredpar The first Roslyn issue is about AddNode, not AddSharedEntry

@NTaylorMullen ah okay.  I will look into that.
Although I'm going to suspect that given Roslyn only NRE in this scenario and at least one is only explainable by Memory Corruption that it's extremely likely memory corruption is the root of many of the issues here.

@NTaylorMullen i've looked at the two issues you filed and came to the same conclusion which each as I did for the first NRE:  there is no plausible way for that code path to throw a NRE.  I added a specific break down to each of the bugs of why I feel that is the case.
That's three NRE in Roslyn that have no plausible explanation.  I think it's looking more and more like an underlying memory corruption issue here.

@jaredpar Thank you for taking a look! I'm glad it didn't end up being something more serious.

I'm glad it didn't end up being something more serious.

I'd vote for memory corruption as more serious than NRE 😄


Kanban setup

https://github.com/Alejandro-Bernal-M/Capstone-Project-Setup-Kanban
We are two people working on this project.

Status: ✔ Project Approved ✔
Hi @Alejandro-Bernal-M,
Everything is looking great! Please, merge this branch :shipit:
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

[OPTIONAL] This is the Capstone project, and a better name for this repository would be only Capstone-Project or the name of the project you want to give. It would be a better name if you rename this repository without the 'Setup-Kanban', this looks more like a branch name than the repository name.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.


Add variables values to URL

Proposal:
I'd like to be able to share a dashboard with the variables defined in the url
Current behavior:
Right now, if I have a dashboard with one or more variables and I want to share the dashboard with a collegue or a friend. I have to share the link of the dashboard and tell them to set the variables to the value I require
Desired behavior:
The value of the variables should be url paramethers much lilke in Chronograf
Use case:
Why is this important (helps with prioritizing requests)? We all know that sharing is caring, the easier we make the sharing of information the better. For better debugging of issues and postmortems

this is in prod now.. closed with #17522


fix: fix flash of demo banner when loading

In the long run there might be a better pattern for this through the useDemoUser hook

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SVG attachment viewer

image/svg+xml mime type
Interactive (javascript) svg supported
<object/> was used as recommended at http://www.sitepoint.com/add-svg-to-web-page/ - interactive images are supported.
HTML contains fallback: "Your browser does not support SVG". All modern browsers do support SVG. Regular user will never see it. So, the message is not translated to minimize localization (maintenance) cost.

SonarQube analysis reported 1 issue:

 1 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Function has a complexity of 11 which is greater than 10 authorized.

@qatools-ci should I add //NOSONAR like you do in the function above?

@volkovs it is a bot) I don't know does nosonar works for js so you can try

retest this please

Anyway, PR looks nice

LGTM


Adding Public board

https://user-images.githubusercontent.com/33022876/199240365-11c65ab9-5197-4e12-9282-f1f90133eb27.mp4

First of all,  thanks for building Agilix, it's so much better than some premium apps.

Why is this PR?

Actually, Agilix lacks the functionality I was seeking for—a public board that can be shared. I included it a few months ago for that reason. I also noticed that you added NextJS to this repo. So, I simply want to keep this "public board" feature available for people who need it.

It's up to you whether you merge it or not. Thanks.

firebase rule

rules_version = '2';
service cloud.firestore {
  match /databases/{database}/documents {
    match /users/{userId}/{document=**} {
      allow read, write: if request.auth != null && request.auth.uid == userId;
    }

   match /public-boards/{document=**}{
      allow read: if true;
    }

    match /public-boards/{userId}/boards/{document=**}{
    	allow write, delete: if request.auth != null && request.auth.uid == userId;
    }
  }
}

Hey, thank you for the PR, this looks awesome. I am actually planning to migrate this app to NextJS entirely, so probably wont be merging this PR. Thanks, again.


adding check for sub cert lints

Build error is fixed by #35. This fixes lints that do not properly check if they are CA certs before checking sub_cert specific tests.

fix tests and then you can merge.

@kumarde we agreed to get rid of these checks i think. can you check and close and/or update?

Closing based on a conversation we had out of band @zakird; I'll send a new PR with those changes.


MEC15xx/MEC1501: deprecate pinmux and move to pinctrl

Update MEC15xx/MEC1501 drivers to use pinctrl instead of pimux. Adding drivers one by one starting with ps2 and kscan.

ping

@jvasanth1  +1 ping

Any progress on this? The deadline for v3.2 is approaching fast.

Any progress on this? The deadline for v3.2 is approaching fast.

@jvasanth1 is out until 12th, so we either remove the boards for now or ask for an exception…

Any progress on this? The deadline for v3.2 is approaching fast.

@jvasanth1 is out until 12th, so we either remove the boards for now or ask for an exception…

This is for unblocking the pinmux common code cleanup right? Maybe we can leave the board and just remove the pinmux driver, and mark the corresponding board as known non functional?

Any progress on this? The deadline for v3.2 is approaching fast.

@jvasanth1 is out until 12th, so we either remove the boards for now or ask for an exception…

This is for unblocking the pinmux common code cleanup right? Maybe we can leave the board and just remove the pinmux driver, and mark the corresponding board as known non functional?

I'd advocate for temporary removal, having a broken board upstream doesn't sound like a good idea.

Any progress on this? The deadline for v3.2 is approaching fast.

@jvasanth1 is out until 12th, so we either remove the boards for now or ask for an exception…

This is for unblocking the pinmux common code cleanup right? Maybe we can leave the board and just remove the pinmux driver, and mark the corresponding board as known non functional?

I'd advocate for temporary removal, having a broken board upstream doesn't sound like a good idea.

Cool, it's a very strong signal, should we flag this for TSC discussion for now?

Any progress on this? The deadline for v3.2 is approaching fast.

@jvasanth1 is out until 12th, so we either remove the boards for now or ask for an exception…

This is for unblocking the pinmux common code cleanup right? Maybe we can leave the board and just remove the pinmux driver, and mark the corresponding board as known non functional?

I'd advocate for temporary removal, having a broken board upstream doesn't sound like a good idea.

Cool, it's a very strong signal, should we flag this for TSC discussion for now?

Ok

@jvasanth1 would you be able to prioritize finishing this PR? It's blocking pinmux deprecation and there are conversations about disabilng the boards from CI or remving them entirely. Would you be able to complete this before RC2? (that's next week)

will take this as priority once I am back early next week and try to close by end of next week

@jvasanth1 any update on this PR?

@jvasanth1 any update on this PR?

working on this PR and adding more commits

@jvasanth1 we are close to RC2 release date, when do you think this will be done?

@jvasanth1 we are close to RC2 release date, when do you think this will be done?

I am working on it but looks like I need more time to complete this effort.

@jvasanth1, can you help fix the CI failures on this PR. We can then merge this in and you can add an issue to complete any pending changes.

@jvasanth1, can you let us know what items are remaining?
@gmarull, can you take a look at this PR.

@jvasanth1, can you let us know what items are remaining?

adc and qmspi drivers are remaining and mec172x uart driver needs update to work with mec15xx as well. Also I need to review all other pins configured currently in pinmux.c

@jvasanth1, thank you for your updates. Among the pending work, can we prioritize updating mec172x uart driver.

@jvasanth1 in the interest of moving this forward, how about adding one more patch dropping pinctrl.c and CONFIG_PINMUX=y (you can cherry-pick https://github.com/zephyrproject-rtos/zephyr/pull/50442) and the submitting the whole thing? That would allow us to then proceed with deprecating the pinmux API, and would leave these two board semi-functional with the peripheral ported already, then on a second stage you can send a fixup PR for the remaining peripheral, of we can flag those as not working under "known issues" for 3.2.0 and then fix them in 3.2.1 once the patch is posted.

@jvasanth1 in the interest of moving this forward, how about adding one more patch dropping pinctrl.c and CONFIG_PINMUX=y (you can cherry-pick #50442) and the submitting the whole thing? That would allow us to then proceed with deprecating the pinmux API, and would leave these two board semi-functional with the peripheral ported already, then on a second stage you can send a fixup PR for the remaining peripheral, of we can flag those as not working under "known issues" for 3.2.0 and then fix them in 3.2.1 once the patch is posted.

ok, I will cherry pick #50422 commit and try to add adc and qmspi drivers as well today

@jvasanth1 in the interest of moving this forward, how about adding one more patch dropping pinctrl.c and CONFIG_PINMUX=y (you can cherry-pick #50442) and the submitting the whole thing? That would allow us to then proceed with deprecating the pinmux API, and would leave these two board semi-functional with the peripheral ported already, then on a second stage you can send a fixup PR for the remaining peripheral, of we can flag those as not working under "known issues" for 3.2.0 and then fix them in 3.2.1 once the patch is posted.

ok, I will cherry pick #50422 commit and try to add adc and qmspi drivers as well today

Cool, it's #50442 btw.

@jvasanth1. Instead of you cherry picking https://github.com/zephyrproject-rtos/zephyr/pull/50442 we would prefer the pinmux.c file delete is done as part of this PR. Can you help make this change, we would like to get in whatever is functional at the earliest along with delete of pinmux.c
You can then create a separate PR to work on the remaining features.

@jvasanth1. Instead of you cherry picking #50442 we would prefer the pinmux.c file delete is done as part of this PR. Can you help make this change, we would like to get in whatever is functional at the earliest along with delete of pinmux.c
You can then create a separate PR to work on the remaining features.

I am unable the cherry-pick anyway as my local workspace doesn't seem see the external commit.
I will delete the pinmux.c as part of this PR.

@jvasanth1. Instead of you cherry picking #50442 we would prefer the pinmux.c file delete is done as part of this PR. Can you help make this change, we would like to get in whatever is functional at the earliest along with delete of pinmux.c
You can then create a separate PR to work on the remaining features.

I am unable the cherry-pick anyway as my local workspace doesn't seem to see the external commit. I will delete the pinmux.c as part of this PR.

Yeah that works, thanks (and the two config lines as well)

@jvasanth1. Instead of you cherry picking #50442 we would prefer the pinmux.c file delete is done as part of this PR. Can you help make this change, we would like to get in whatever is functional at the earliest along with delete of pinmux.c
You can then create a separate PR to work on the remaining features.

I am unable the cherry-pick anyway as my local workspace doesn't seem to see the external commit. I will delete the pinmux.c as part of this PR.

Great, please give this a priority. Thank you.

added commits for adc and spi driver pinctrl and removed pinmux.c

@jvasanth1 Please take a look at this CI failure:
198/625 mec1501modular_assy6885   samples/drivers/espi/sample.drivers.espi           FAILED Cmake build failure (build)
INFO    - /__w/zephyr/zephyr/twister-out/mec1501modular_assy6885/samples/drivers/espi/sample.drivers.espi/build.log
ERROR   - Loading Zephyr default modules (Zephyr base).
-- Application: /__w/zephyr/zephyr/samples/drivers/espi
-- Found Python3: /usr/bin/python3.8 (found suitable exact version "3.8.10") found components: Interpreter
-- Cache files will be written to: /__w/zephyr/zephyr/.cache
-- Zephyr version: 3.2.0-rc2 (/__w/zephyr/zephyr)
-- Found west (found suitable version "0.13.1", minimum required is "0.7.1")
-- Board: mec1501modular_assy6885
-- Found host-tools: zephyr 0.15.0 (/opt/toolchains/zephyr-sdk-0.15.0)
-- Found toolchain: zephyr 0.15.0 (/opt/toolchains/zephyr-sdk-0.15.0)
-- Found Dtc: /opt/toolchains/zephyr-sdk-0.15.0/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.6.0", minimum required is "1.4.6")
-- Found BOARD.dts: /__w/zephyr/zephyr/boards/arm/mec1501modular_assy6885/mec1501modular_assy6885.dts
-- Found devicetree overlay: /__w/zephyr/zephyr/samples/drivers/espi/boards/mec1501modular_assy6885.overlay
devicetree error: 'pinctrl-0' is marked as required in 'properties:' in /__w/zephyr/zephyr/dts/bindings/spi/microchip,xec-qmspi.yaml, but does not appear in <Node /soc/spi@40070000 in '/__w/zephyr/zephyr/misc/empty_file.c'>

@jvasanth1, thank you for your prompt attention to this PR. Can you please let us know what portions were not addressed as part of PR?

@jvasanth1, thank you for your prompt attention to this PR. Can you please let us know what portions were not addressed as part of PR?

There are mainly 2 things remaining:

mec15xx didn't have a uart driver, the uart pins were configured in pinmux.c and uart worked with default ns16550 driver. Since there is no pinmux now to configure the uart pins, it needs to be done in a uart driver. So mec172xx uart driver needs to be updated to work for mec15xx as well.

You should'nt need a new uart driver. You can link the uart pinctrl pins into the uart node in the board dts file

Of course the ns16550 UART driver will need to be updated to use pinctrl


New check 7161 EFS encryption at rest enabled @rustic

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This is a check for EFS to see if encryption at rest is enabled. CIS has this a proposed benchmark in 1.5.

Thanks @rustic this is a good one! Just one comment here, the ASFF resource name here is AwsEfsFileSystem, can you update it? Thanks!

No problem. I have updated the file.


Specifying a table with 'lines'

Cookbook version
4.0.1
Chef-client version
12.16.42
Platform Details
Ubuntu 16.04 in AWS
Scenario:
Is there a way to specify a table when using lines rather than a template?
If not something like the following would be great:
iptables_rule 'foo' do
  lines '-I PREROUTING -p tcp -m tcp --syn --dport 80 -j CT --notrack'
  table :raw
end

Looks like you can achieve this with:
lines "*nat\n-A PREROUTING -i eth0 -p tcp --dport 80 -j REDIRECT --to-port 8080"

Seems a little hacky though.  I included https://github.com/chef-cookbooks/iptables/issues/76 to provide the table property for use with lines.  I'll provide tests if you're interested in this approach.

This is resolved with https://github.com/chef-cookbooks/iptables/pull/76.  Thanks!


Change corresponding color when changing brush

Can you change the corresponding color when changing the brush. For example, if you change the GlyphBrush, then it changes the color in GlyphColor too. If a gradient it's selected, then the first color it's applied.
This will be useful for keeping the color theme, and using the same color like the game description and shadows. For now if you use a white theme, you got to change the colors in the respective constants or settings in your ThemeModifier.

from Twiggy5471#9343 on Discord
sory idk if it would be something you can catch in the logs. i was experiencing it with multiple themes including default but was mainly trying with Harmony and it happens if i just got done editing one element the next one will change the last one edited too. i also deleted Harmony and Thememodifier and their data and installation folders for a clean install and was still happening.


add hg to hg-bulk getters

Convenience function for getting a bulk class from a mercury class. Especially useful when using an implicit bulk class (e.g. passing HG_BULK_NULL to HG_Init).

Actually, don't pull this quite yet - I'm going to add a convenience getter function for the bulk context as well.
Looking at the implementation, an implicit bulk context is created for each hg_context_t. IIUC, the hg_info struct is supplied this context, which is used by RPC callees, so there shouldn't be a problem in returning this directly?

Okay, I rebased and reworded the commit. Now, the (possibly implicit) bulk class and context can be gotten from their corresponding HG class/context.

Ok I think it is fine to me to have that, I was trying to avoid to have to go this way though :) but we will see that later... could you also please move HG_Get_bulk_class()/HG_Core_get_bulk_class() right after HG_Finalize()/HG_Core_finalize() and HG_Get_bulk_context()/HG_Core_get_bulk_context() after HG_Destroy()/HG_Core_destroy() ? Just to keep the routines organized.

When I say I was trying to avoid to have to go this way, I actually mean that it still annoys me a little that we have to get the bulk class etc from the hg class to then use the bulk routines, but maybe when I simplify things and keep only the context in most of the routines, it will be better.

Yeah, I understand what you mean RE getting at bits of mercury state.
Did you mean to say HG_Context_destroy/HG_Core_context_destroy instead of HG_Destroy/HG_Core_destroy?

Ah yes that's what I meant :) thanks for understanding me :)

Okay, reorganized and ready to go.

:+1:  thanks!


TF Plan security: Plan artifact in GitHub is not encrypted

Using v 0.4.6. Configuration of digger action - upload-plan-destination: github.
Issue: Plan artifact in Github is accessible to everyone who has read access on the repository (this is not configurable on GitHub). Terraform plan binary file can contain sensitive values and shouldn't be accessible to all users.
Suggestion for solution: Implement encryption of the file before storing it to artifacts. It can be either password protected zip file (that the plan is currently in) or file encryption on top of it.

Closing as this is duplicate of https://github.com/diggerhq/digger/issues/817


OneDrive Spaces to Plus

rclone v1.36 / Mac OSX 10.12.3 (Sierra) / OneDrive
rclone copy itunes --exclude-from excludes.txt  onedrive:/musictest --delete-excluded
When I try clone to OneDrive, it is creating files/dirs with a + instead of a space, but it is also creating the directories without the space.
Bit from the log:

2017/05/06 00:27:06 INFO  : 808 State/808 Utd. State 90/04 Kinky National.mp3: Copied (new)
2017/05/06 00:27:09 INFO  : 808 State/808 Utd. State 90/01 Pacific 202.mp3: Copied (new)
2017/05/06 00:27:14 INFO  : 808 State/808 Utd. State 90/03 Ancodia.mp3: Copied (new)
2017/05/06 00:27:21 INFO  : 808 State/808 Utd. State 90/02 Boneyween.mp3: Copied (new)
2017/05/06 00:27:34 INFO  : 808 State/808 Utd. State 90/06 Cubik.mp3: Copied (new)

Screen shots attempt to show what I'm talking about:

I've read through docs and forum, and searched github, but I don't see this particular issue--sorry if there is an easy answer or this is a dupe.
Thank you!

Can you try the latest beta please - this is likely fixed already.
Thanks

Indeed--beta works great. Thank you, and thanks for your work on this program!


[SPARK-41014][PYTHON][DOC] Improve documentation and typing of groupby and cogroup applyInPandas

What changes were proposed in this pull request?
Documentation of method applyInPandas for grouby and cogroup should mention in the main description that there are two allowed signatures for the provided function. The Examples state that this is possible, and the parameters sections states that for cogroup.
Also type information for PandasCogroupedMapFunction should mention the three-argument callable alternative.
Why are the changes needed?
Better documenting these alternative to find this piece of information quicker.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Untested

Can one of the admins verify this patch?

@HyukjinKwon @zhengruifeng this are minor improvements for documentation and typing of PySpark applyInPandas methods.

Merged to master.


Set up CI with Azure Pipelines

[skip ci]

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: omarcarreon sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


a better editor

like medium. WYSIWYG. smooth writing. no need to use markdown syntax. visual editing.
Maybe use something like https://github.com/yabwe/medium-editor

The medium-editor doesn't seem to be able to handle adding code, lists, etc 🤔

this seems like a good one https://editorjs.io/ but it use "block" which needs to be mapped to markdown, I don't know if that is possible.


Test normalize ast

Delete functhion and todo comment

я сделал то что ты сказал, разве не так ?
Отправлено из Mail.ru для Android пятница, 20 августа 2021г., 11:56 +03:00 от 0dminnimda  @.*** :
@.*** requested changes on this pull request.

In  .idea/inspectionProfiles/Project_Default.xml :
@@ -0,0 +1,25 @@
+
Could you please remove these xmls'?
You can use .gitignore to ignore all files in the .idea directory:
just add the line with .idea / to the file
In  tests/test_normalize_ast.py :
-# TODO: add a test that shows that ast.fix_missing_locations is in use,
-# it is probably better to take tests for ast.fix_missing_locations from python sources.
+
What's the point of just deleting this comment?
The fix_missing_locations function is still in use in the code,  look .
In  tests/test_normalize_ast.py :
-# TODO: add a test that shows that ast.fix_missing_locations is in use,
-# it is probably better to take tests for ast.fix_missing_locations from python sources.
+
And what is the reason for removing this function if you want to do this?
—
You are receiving this because you authored the thread.
Reply to this email directly,  view it on GitHub , or  unsubscribe .

Somehow the test_normalize_ast branch appeared, in order to delete it from this repository, I need to close this PR


Make use of Listener.EnableReusePort to replace deprecated ReusePort

Please provide a description of this PR:

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
268f1170f27ae532ff450861186aef06b19b56bd
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster_istio

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
268f1170f27ae532ff450861186aef06b19b56bd
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Make sure we don't allow competing continuous migrations

Currently, don't think there is a catch to make sure we haven't specified continuous migration between the same source/dest demes that have overlapping time intervals.
E.g., this should result in an error:
migrations:
- symmetric:
  - demes: A, B
    rate: 0.01
  - demes: A, B
    rate: 0.02

FYI, the  graphs() hypothesis strategy in the testing code will need to be changed as well because it will currently generate overlapping migrations. I have in mind an alternate way of writing this function that won't have that problem.


Voting Documentation

Documents the process of voting and how to remove someone's voting rights.

It was just to keep track of the images being added. I'm following Darryl's school of commits 😄


[changelog skip] Install node for apps with execjs

The execjs gem allows Ruby code to execute javascript. It does this by searching for several possible implementations:

The ruby racer (V8 distributed as a Ruby gem)

This gems is extremely heavy, takes a long time to compile, frequently fails compilation and is generally not commonly used.

MinRacer (A paired down interface to V8 distrbuted as a Ruby gem)

From the readme: Unlike therubyracer, mini_racer only implements a minimal bridge. This reduces the surface area making upgrading v8 much simpler and exhaustive testing simpler.

System installation of node

Prior to the introduction of mini_racer the most common and popular development strategy was to depend on a system version of node. This PR implements existing behavior in the old buildpack where we install node if execjs is present in the gemfile.lock https://github.com/heroku/heroku-buildpack-ruby/blob/38cb9c1e8e16fd09cdf2086387fe9a1882d920de/lib/language_pack/ruby.rb#L1153-L1154. While this might sound like an edge case. Our existing "getting started ruby" example app needs this behavior https://github.com/heroku/ruby-getting-started
Unlike the old Ruby buildpack we do not manually manage and install a node binary, instead we rely on the Node buildpack to install and manage node so that user expectations are more aligned.
Implementation details
The Node.js buildpack requires a package.json copy at the root of the buildpack for detection. In our case the developer may not have added one, but we still need to use the heroku/nodejs buildpack to manage our node for us. To accomplish this the Ruby buildpack detects this scenario and writes out a minimal package.json so that the nodejs buildpack will not fail detection.
CNB Concerns
This same strategy does not work for CNB because the detect phase runs in parallel so even if the Ruby buildpack writes a package.json to disk as part of it's detect phase, it's too late and the nodejs buildpack's detect has already fired. While this strategy seems to work well enough for the V2 interface, we need to figure out how to support this behavior with the CNB interface.

This same strategy does not work for CNB because the detect phase runs in parallel so even if the Ruby buildpack writes a package.json to disk as part of it's detect phase, it's too late and the nodejs buildpack's detect has already fired.

Are you sure this is true? The group order is specified so that each bin/detect runs in order: https://github.com/buildpacks/spec/blob/main/buildpack.md#process
Additionally, I need to think about this scenario. Technically, to use Node.js, you don't need a package.json, you just need it to use npm or yarn, so maybe we remove that constraint for people that either want to use their own package manager or only need the engine (it is supposed to be the engine buildpack anyways).

Are you sure this is true? The group order is specified so that each bin/detect runs in order: https://github.com/buildpacks/spec/blob/main/buildpack.md#process

From the spec if you search for "parallel" you come across this line:

The lifecycle MAY execute each /bin/detect within a group in parallel.

Technically, to use Node.js, you don't need a package.json, you just need it to use npm or yarn, so maybe we remove that constraint for people that either want to use their own package manager or only need the engine (it is supposed to be the engine buildpack anyways).

This is what I was thinking. The node-engine buildpack should always pass and provide node but not require it. This way any buildpack can use it. The npm/yarn buildpacks can require node and also contain the package.json detect logic. The only downside is that by removing the node-engine buildpacks node require, the node-engine buildpack isn't standalone. I'm not sure that is a use case we care about though. With these changes, the nodejs meta buildpack should be the same for end users.

The only downside is that by removing the node-engine buildpacks node require, the node-engine buildpack isn't standalone.

Can you elaborate on this? What would standalone entail? I think the only functionality it needs is to install Node (+ npm/npx) and be able to run code with node file.js. The requirement for package.json would be removed, but the user can still specify a Node version with a package.json if needed. @schneems do users specify a version?

Can you elaborate on this? What would standalone entail?

Yeah standalone would just be using the node-engine buildpack by itself without another buildpack requiring "node", since my suggestion is for the node-engine buildpack to only provide but not require it. If we just removed detect for package.json but kept the provide/requires the same it would always pass, which isn't what Richard wants.

I see. I have 2 questions then:

Would it be over engineering to remove the package.json detection from the nodejs-engine, then create a buildpack that wraps around nodejs-engine and uses looking for execjs to install?
Is there a way to add an optional buildpack on the fly? Or opting into a group based on the events of detect?

I think we need something that looks like this:

node-top-level

requires: nodejs if package.json
provides:
order: [node-always-run]

node-always-run

requires:
provides: nodejs
order: []

In this scenario the top level node buildpack would be a thin wrapper, all of the logic would be in the "lower" level buildpack.

Would it be over engineering to remove the package.json detection from the nodejs-engine, then create a buildpack that wraps around nodejs-engine and uses looking for execjs to install?

I think that's exactly what we want.

Is there a way to add an optional buildpack on the fly? Or opting into a group based on the events of detect?

I think the loose way this is allowed is by having a buildpack that "provides" things, but does not "require" them. But it's not very on-the-fly. I do wish this was a little more explicit, like in this V2 interface I can directly call another buildpack and don't have to make that decision upfront, but I also understand that could get pretty gnarly.

This PR as a stand-alone is okay to go. I documented the larger issue here that we can keep open until the CNB interface issue is resolved and we can move forward https://github.com/heroku/heroku-buildpack-ruby-experimental/issues/27


feat: upgrade therefore

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#38  👈
#37
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pevisscher and the rest of your teammates on  Graphite

Merge activity

May 27, 2:19 PM GMT+2: @pevisscher started a stack merge that includes this pull request via Graphite.


Json Schema validation blocking to create parent charts and used this lacework official chart as  dependencies subcharts

Hi Lacework support team:
We are facing the issue as below

We are using github private repo for our organization so CAN NOT directly using this  lacework official chart
We try to create a parent chart, including "this  lacework official chart" as dependencies subcharts, so we still get the newest release / update, and use the "parent chart we created" to deploy by ArgoCD
Below is my parent charts:

apiVersion: v2
appVersion: "1.0"
version: 5.5.0
name: lacework-agent
namespace: lacework
description: A Helm chart for Kubernetes Lacework Agent
type: application
icon: https://www.lacework.com/wp-content/uploads/2019/07/Lacework_Logo_color_2019.svg
dependencies:
- name: lacework-agent
  version: 5.5.0
  repository: https://lacework.github.io/helm-charts/

And we have a value.yaml file to inject the values
lacework-agent:
  laceworkConfig:
    accessToken: XXX
    serverUrl: "https://api.lacework.net"
    fim:
      coolingPeriod: 60
      crawlInterval: 60
      noAtime: true
      runAt: 03:01

    kubernetesCluster: XXX
    env: staging
    autoUpgrade: disable

  resources:
    requests:
      cpu: 200m
      memory: 128Mi
    limits:
      cpu: 300m
      memory: 1024Mi

When have try to helm template, it would get error as below

lacework % helm template -f ./value-dev-staging.yaml lacework-agent ./
Error: values don't meet the specifications of the schema(s) in the following chart(s):
lacework-agent:
- (root): Additional property global is not allowed

The issue is "parent chart is implicit to share the 'global' values from parent to child", but at https://github.com/lacework/helm-charts/blob/main/lacework-agent/values.schema.json, the "additionalProperties" is all  false
some other helm charts like istio also reporting same issue before, see below 3 links
https://github.com/istio/istio/pull/35496
https://github.com/helm/helm/issues/10392
https://github.com/helm/helm/issues/8489

The workaround solution is to either
A. change all "additionalProperties" to true
B. delete values.schema.json files ....

Can you please help for this issues? Thanks!~~

Hi @liliwangthescore, thanks for filing this issue! I can see why this is frustrating, as charts should be composable.
We chose to add schema validation and set additionalProperties=false due to seeing multiple customers raise run into problems with specifying arguments incorrectly (such as using a string when an object was expected) or having typos in variable names (server_url instead of serverUrl). Schema validation provides valuable protections for our customers.
Right now, my suggestions would be to fork the agent charts and disable schema validation in your charts. Sadly this means that you would need to perform a manual sync when new versions are released. You can sign up for release notifications at https://github.com/lacework/lacework-agent-releases if you want to be automatically notified of new agent releases via Github.
Longer term, perhaps we can allow for the existence of a global key to enable using this chart as a sub-chart. If you decide to fork the agent helm charts, can you let me know if this diff solves the issue?
diff --git a/lacework-agent/values.schema.json b/lacework-agent/values.schema.json
index a0ea0ff..58309c3 100644
--- a/lacework-agent/values.schema.json
+++ b/lacework-agent/values.schema.json
@@ -4,6 +4,10 @@
         "laceworkConfig"
     ],
     "properties": {
+        "global": {
+            "type": "object",
+            "$comment": "Blanket 'global' object to enable embedding this chart as a sub-chart"
+        },
         "daemonset": {
             "type:": "object",
             "properties": {

Please let me know your thoughts!

Hi @cirego
I test it, that is great, that would resolve the issue
     "properties": {
+        "global": {
+            "type": "object",
+            "$comment": "Blanket 'global' object to enable embedding this chart as a sub-chart"
+        },

This is I tested:
Lili.Wang@MacBook-Pro lacework % helm template lacework-agen .  -f value-dev-staging.yaml --include-crds
Error: values don't meet the specifications of the schema(s) in the following chart(s):
lacework-agent:
- (root): Additional property global is not allowed

Lili.Wang@MacBook-Pro lacework % ll
total 16
-rw-r--r--  1 Lili.Wang  staff  343 19 May 00:12 Chart.yaml
drwxr-xr-x  3 Lili.Wang  staff   96 18 May 23:26 charts
-rw-r--r--  1 Lili.Wang  staff  462 18 May 23:26 value-dev-staging.yaml
Lili.Wang@MacBook-Pro lacework % cd charts
Lili.Wang@MacBook-Pro charts % ll
total 0
drwxr-xr-x  10 Lili.Wang  staff  320 19 May 14:51 lacework-agent
Lili.Wang@MacBook-Pro charts % vi lacework-agent/values.schema.json
Lili.Wang@MacBook-Pro charts % cp lacework-agent/values.schema.json /tmp
Lili.Wang@MacBook-Pro charts % vi lacework-agent/values.schema.json
Lili.Wang@MacBook-Pro charts % cd ..
Lili.Wang@MacBook-Pro lacework % cd ..
Lili.Wang@MacBook-Pro apps % cd lacework
Lili.Wang@MacBook-Pro lacework % ll'
quote>
Lili.Wang@MacBook-Pro lacework % ll
total 16
-rw-r--r--  1 Lili.Wang  staff  343 19 May 00:12 Chart.yaml
drwxr-xr-x  3 Lili.Wang  staff   96 18 May 23:26 charts
-rw-r--r--  1 Lili.Wang  staff  462 18 May 23:26 value-dev-staging.yaml
Lili.Wang@MacBook-Pro lacework % helm template lacework-agen .  -f value-dev-staging.yaml --include-crds
---
# Source: lacework-agent/charts/lacework-agent/templates/access-token.yaml
apiVersion: v1
kind: Secret
metadata:
  name: lacework-agent-access-token
  labels:
    tier: monitoring
    app: lacework-agent
type: Opaque
data:
  agent-access-token: PHBhdGg6c2VjcmV0L2RhdGEvZGV2b3BzL2xhY2V3b3JrL2FjY2Vzc1Rva2VuL2hlbG1DaGFydCNhY2Nlc3NUb2tlbj4=
---
# Source: lacework-agent/charts/lacework-agent/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
....

We don't want do "fork the agent charts"
Are you able to push below code to master so we can use it?
     "properties": {
+        "global": {
+            "type": "object",
+            "$comment": "Blanket 'global' object to enable embedding this chart as a sub-chart"
+        },

Thank you so much!

Hi @liliwangthescore, I will push a fix for this now!

p.s. @liliwangthescore, you will want to make sure you disable that access token, as it can be decoded from the base64 contents of your secret.


No italics.

Hello. No italics for comments since v. 3.1.0 or so.

I can get Italic comments but only when italic keywords are enabled.
I am also not able to get bold keywords.
Seems like this all is related to each other(?)


feat: support num_ctx for /v1/chat/completions

https://github.com/ollama/ollama/issues/4447#issuecomment-2264425558

This does not follow OpenAI's API spec, as @mxyng commented in that issue https://github.com/ollama/ollama/issues/4447#issuecomment-2112784702, set the context in a Modelfile, or use Ollama's API. OpenAI's API doesn't allow setting the context length, hence Ollama's compatibility layer doesn't either.

This does not follow OpenAI's API spec, as @mxyng commented in that issue #4447 (comment), set the context in a Modelfile, or use Ollama's API. OpenAI's API doesn't allow setting the context length, hence Ollama's compatibility layer doesn't either.

I also understand that adding this would compromise the elegance of the code
The purpose of using OpenAI compatible interfaces is to facilitate calling, but modifying 'Modelfile' has become very troublesome because there are no commands to directly modify it, and creating a 'Modelfile' is required If we really want to do this, we need to read the 'Modelfile' of the original model and insert parameters to create a new model. The process is too complicated and difficult to maintain (because we also need to delete content that is no longer in use, which will create a lot of redundancy) At present, 'ollama run xxx' and then execute '/set parameter num_ctx 9999' can only take effect in the current conversation. It would be even better if a persistent modification command could be added, similar to 'ollama set xxxx' parameter num_ctx 9999
Or can other methods be used to simplify this problem

It would be even better if a persistent modification command could be added

You can create a Modelfile and use ollama create to save your model, then use that. It's all written in the Modefile documentation. https://github.com/ollama/ollama/blob/main/docs/modelfile.md#basic-modelfile
# Modelfile

# Specify the model you want to use
FROM llama3.1

# Modify its context length
PARAMETER num_ctx 4096

Then create a new model with ollama create.
ollama create my_model

If the Modelfile isn't in the same directory as you run ollama create, then supply the path to it using the -f flag.
ollama create my_model -f <Modelfile path>

Now you've created your own model with a modified context length, that you can use like any other Ollama model.
const completion = await openai.chat.completions.create({
  model: 'my_model'
  messages: [{
    role: 'user',
    content: 'Say this is a test'
  }]
})

It would be even better if a persistent modification command could be added

You can create a Modelfile and use ollama create to save your model, then use that. It's all written in the Modefile documentation. https://github.com/ollama/ollama/blob/main/docs/modelfile.md#basic-modelfile
# Modelfile

# Specify the model you want to use
FROM llama3.1

# Modify its context length
PARAMETER num_ctx 4096

Then create a new model with ollama create.
ollama create my_model

If the Modelfile isn't in the same directory as you run ollama create, then supply the path to it using the -f flag.
ollama create my_model -f <Modelfile path>

Now you've created your own model with a modified context length, that you can use like any other Ollama model.
const completion = await openai.chat.completions.create({
  model: 'my_model'
  messages: [{
    role: 'user',
    content: 'Say this is a test'
  }]
})

Thank you for your reply, but I am currently testing the performance under multiple models
So I hope to have a relatively simple repair method
At present, it seems that only one modification can be made one by one


[MINOR][BUILD] Exclude pyspark-coverage-site/ dir from RAT

What changes were proposed in this pull request?
Looks like a directory pyspark-site-coverage/ is now (?) generated and fails RAT checks. It should just be excluded. See: https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.7/6029/console
How was this patch tested?
N/A

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12050/
Test PASSed.

Test build #106834 has started for PR 24950 at commit 63acb5a.

This is fine too. Alternatively, maybe we should rather remove pyspark-site-coverage/ entirely explicitly after each run. pyspark-site-coverage/ was added in spark-master-sbt-hadoop-2.7 specifically as of https://github.com/apache/spark/pull/23117.
In the job specifically, it runs PySpark tests with coverage and updates it to https://github.com/spark-test/pyspark-coverage-site.
I met this issue before .. it was here - https://github.com/apache/spark/pull/23729 pyspark-coverage-site should be removed after each run but somehow it wasn't.
RAT checks happens after PySpark tests. So it's likely the same thing being happening again.
@shaneknapp and @srowen, maybe I have to reopen https://github.com/apache/spark/pull/23729 and manually remove to make sure such things don't happen.

Test build #106834 has finished for PR 24950 at commit 63acb5a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106834/
Test FAILed.

Test build #4807 has started for PR 24950 at commit 63acb5a.

this change is fine, but another option could be to move the RAT test to the beginning of dev/run-tests.py:main().

Test build #4807 has finished for PR 24950 at commit 63acb5a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master

yay!   happiness ensues:
========================================================================
Running Apache RAT checks
========================================================================
Attempting to fetch rat
RAT checks passed.


3.x - Response function isBadRequest()

Adds a helper method $response->isBadRequest() using StatusCode::HTTP_BAD_REQUEST

Coverage decreased (-0.06%) to 97.777% when pulling 0cf8fc72719558949d5be0869e0cd356f00f2746 on KarimChukfeh:3.x-Response-isBadRequest into eaee12ef8d0750db62b8c548016d82fb33addb6b on slimphp:3.x.

I'm not opposed to this @akrabat. We do have all the other helper methods on the Response object and this is just one more. I want your thoughts on this before merging though.

What is the use-case where this method would be needed?

I'm testing my responses using PHPUnit and slim-rest-helpers. An assertion look like this $this->assertTrue($this->client->response->isOk());
but there's no helper method for 400 Bad Request. So the 400 assertion has to look like this $this->assertEquals(400, $this->client->response->getStatusCode());`


Move libp2p to worker thread

Rationale
Main goals:

Move network crypto to thread
Isolate network to protect main thread of DOS attacks
Allow to throttle network processor better to keep main thread event loop lag under control

Also, for nodes subscribed to many subnets recent benchmarks show that network handling takes decent chunk CPU time, lagging the main thread and delaying other pipelines like block processing.

Part of https://github.com/ChainSafe/lodestar/issues/4856
WIP branch all-in-one https://github.com/ChainSafe/lodestar/pull/5229

Architecture
Simple and lame chart for general idea. libp2p instance is rooted on the TCP transport's socket. It pulls many components that are best together in the same thread:

peer manager
gossip
reqresp

On the other hand, the main thread is the only thread with access to the state cache, so the network processor must remain there. For now we'll place the network queues in the main thread, but those could be placed in the worker.

Interfaces
To do A/B testing we want to have a flag to switch the libp2p instance from being in a worker thread or the main thread. So we need

A) Main thread "public" facing network API with variable backend. Implements NetworkPublic and calls NetworkCore internally (either B or C).
B) Internal network class with logic de-duplicated from either backend. Implements NetworkCore with actual logic
C) Main to worker event based interface to wire A to B through worker. Implements NetworkCore and calls NetworkCore internally (B).

interface NetworkPublic extends NetworkCorePublic {
  // Functions using multiple reqresp / gossip methods
  publishBeaconBlockMaybeBlobs(signedBlock: BlockInput): Promise<void>;
  beaconBlocksMaybeBlobsByRange(peerId: PeerId, request: phase0.BeaconBlocksByRangeRequest): Promise<BlockInput[]>;
  beaconBlocksMaybeBlobsByRoot(peerId: PeerId, request: phase0.BeaconBlocksByRootRequest): Promise<BlockInput[]>;

  // ReqResp caller helpers
  // NOTE: Should map to a single fn to prevent boilerplate
  status(peerId: PeerId, request: phase0.Status): Promise<phase0.Status>;
  goodbye(peerId: PeerId, request: phase0.Goodbye): Promise<void>;
  ping(peerId: PeerId): Promise<phase0.Ping>;
  metadata(peerId: PeerId): Promise<allForks.Metadata>;
  beaconBlocksByRange(peerId: PeerId, request: phase0.BeaconBlocksByRangeRequest): Promise<allForks.SignedBeaconBlock[]>;
  beaconBlocksByRoot(peerId: PeerId, request: phase0.BeaconBlocksByRootRequest): Promise<allForks.SignedBeaconBlock[]>;
  blobsSidecarsByRange(peerId: PeerId, request: deneb.BlobsSidecarsByRangeRequest): Promise<deneb.BlobsSidecar[]>;
  beaconBlockAndBlobsSidecarByRoot(peerId: PeerId, request: deneb.BeaconBlockAndBlobsSidecarByRootRequest): Promise<deneb.SignedBeaconBlockAndBlobsSidecar[]>;
  lightClientBootstrap(peerId: PeerId, request: Uint8Array): Promise<allForks.LightClientBootstrap>;
  lightClientOptimisticUpdate(peerId: PeerId): Promise<allForks.LightClientOptimisticUpdate>;
  lightClientFinalityUpdate(peerId: PeerId): Promise<allForks.LightClientFinalityUpdate>;
  lightClientUpdatesByRange(peerId: PeerId, request: altair.LightClientUpdatesByRange): Promise<allForks.LightClientUpdate[]>;

  // Gossip publish helpers
  // NOTE: This functions could be stand-alone since each have usually one single caller
  publishBeaconBlock(signedBlock: allForks.SignedBeaconBlock): Promise<PublishResult>
  publishSignedBeaconBlockAndBlobsSidecar(item: deneb.SignedBeaconBlockAndBlobsSidecar): Promise<PublishResult>
  publishBeaconAggregateAndProof(aggregateAndProof: phase0.SignedAggregateAndProof): Promise<PublishResult>
  publishBeaconAttestation(attestation: phase0.Attestation, subnet: number): Promise<PublishResult>
  publishVoluntaryExit(voluntaryExit: phase0.SignedVoluntaryExit): Promise<PublishResult>
  publishBlsToExecutionChange(blsToExecutionChange: capella.SignedBLSToExecutionChange): Promise<PublishResult>
  publishProposerSlashing(proposerSlashing: phase0.ProposerSlashing): Promise<PublishResult>
  publishAttesterSlashing(attesterSlashing: phase0.AttesterSlashing): Promise<PublishResult>
  publishSyncCommitteeSignature(signature: altair.SyncCommitteeMessage, subnet: number): Promise<PublishResult>
  publishContributionAndProof(contributionAndProof: altair.SignedContributionAndProof): Promise<PublishResult>
  publishLightClientFinalityUpdate(lightClientFinalityUpdate: allForks.LightClientFinalityUpdate): Promise<PublishResult>
  publishLightClientOptimisticUpdate(lightClientOptimisitcUpdate: allForks.LightClientOptimisticUpdate): Promise<PublishResult>
}

interface NetworkCore extends NetworkCorePublic {
  // Service
  metrics(): Promise<string>;
  close(): Promise<void>;

  sendReqRespRequest(method, peerId: PeerId, request): ??;
  publishGossip<K extends GossipType>(topic: GossipTopicMap[K], object: GossipTypeMap[K], opts?: PublishOpts): Promise<number>;
}

interface NetworkCorePublic {
  getEnr(): Promise<SignableENR | undefined>;
  getMetadata(): Promise<altair.Metadata>;
  getConnectedPeers(): PeerId[];
  getConnectedPeerCount(): number;

  prepareBeaconCommitteeSubnet(subscriptions: CommitteeSubscription[]): Promise<void>;
  prepareSyncCommitteeSubnets(subscriptions: CommitteeSubscription[]): Promise<void>;
  reStatusPeers(peers: PeerId[]): Promise<void>;
  reportPeer(peer: PeerId, action: PeerAction, actionName: string): Promise<void>;

  subscribeGossipCoreTopics(): Promise<void>;
  unsubscribeGossipCoreTopics(): Promise<void>;
  isSubscribedToGossipCoreTopics(): boolean;

  connectToPeer(peer: PeerId, multiaddr: Multiaddr[]): Promise<void>;
  disconnectPeer(peer: PeerId): Promise<void>;
  dumpPeers(): Promise<routes.lodestar.LodestarNodePeer[]>;
  dumpPeer(peerIdStr: string): Promise<routes.lodestar.LodestarNodePeer | undefined>;
  dumpPeerScoreStats(): Promise<PeerScoreStats>;
  dumpGossipPeerScoreStats(): Promise<PeerScoreStatsDump>;
  dumpGossipQueue(gossipType: GossipType): Promise<PendingGossipsubMessage[]>;
  dumpDiscv5KadValues(): Promise<string[]>;
}

Is this technically complete now with #5229 ?


(V10) Token status link to vision modes should be configurable

Foundry V10 adds vision modes. Some defaults in the token status list automatically cause vision modes to be applied, including "invisible" which removes the token from the playing field from players that do not specifically have the "see invisible" vision mode, and "blinded" which makes the controlling player lose all playing field visibility.
As the 5e RAW assumes visibility statuses do not make actors untargetable or undetectable (good arguments at e.g. https://www.belloflostsouls.net/2022/01/dd-invisibility-doesnt-work-the-way-you-think-it-does.html), this functionality should be configurable. I would also like to suggest it being off by default because of these issues.

I diagree with the rules interpretation and disagree that the article has merit. The "See Invisibility" spell, for example, says "For the duration, you see invisible creatures and objects as if they were visible" (emphasis mine). As such - the target would not be gaining ANY element of the 'invisible' condition. This strongly indicates that Mr Crawford doesn't read the spells properly and just made a random ruling.
Foundry wise, players can still make an attack on the creature with an invisible status. It is simply implemented as "you cannot see this token" - which is accurate.
Having said all that - there is definitely an argument tobe made for customisability in general! :)

You should still able able to attack the invisible token until it hides, and players might decide to run over to it's square. While you can "do" this, the totally hidden token screws up many automation workflows, and even without automation it makes life difficult for the players to make movement decisions around invisible-but-not-hidden creatures.

[...] Mr Crawford doesn't read the spells properly and just made a random ruling

You realize that he wrote the rules, didn't read them, right? But how the rules work shouldn't really be decided in this issue thread I think. To me the point is that the "you" in the spell descriptions is the character, not the player, and this is at the core of the whole issue. This is also why v10 was pushed back, to split vision modes and detection modes.
I understand where both sides of the argument are coming from, but I also think that claiming that a token should be hidden from the playing field is just against the rules as written (as @benbarbour also points out as I was writing this).
Needs to be an option, should default to how the rules for D&D 5e work.


SV2 testnet4

close https://github.com/Sjors/bitcoin/issues/41
https://github.com/Sjors/bitcoin/issues/41#issuecomment-2102950255

For now I suggest cherry-picking the testnet4 commits on top of the sv2 branch. Once testnet4 is merged, I'll rebase.

@Sjors would you be willing to reconsider?
SRI tests are broken on testnet3, and we are pointing people to github.com/Sjors/bitcoin on the official Getting Started tutorial
cc @stratospher

I think it's fine. I'll try to merge this and bake some new binaries later this week

Thanks, I cherry-picked the testnet4 commits in my sv2 branch: https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2139129818


[backport] Remove unused test decorators

Backport of #7453 by @kmaehashi
Conflict manually resolved:
tests/cupy_tests/manipulation_tests/test_add_remove.py
tests/cupyx_tests/scipy_tests/signal_tests/test_signaltools.py
tests/cupyx_tests/scipy_tests/special_tests/test_binom.py

/test mini

Test failures looks irrelevant.


⚠ Fortnite has degraded performance

In 8a10417, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1577 ms

Resolved: Fortnite performance has improved in 07b2430.


Rename project in code

#144  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


My test

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

flows review again

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Support for FnSub

For #241. No rubocop tests as yet.

Awesome, thanks @cmaxwellau. Can you please fix up those rubocop issues, and also can you add some tests and docs? That'd be awesome.  Let me know if you need a hand with anything.
NB. there's a couple of rubocop fixes pending in #239

I've been waiting for the public release, the code was written a month ago :)
I've fixed everything the travis was warning me about, but it's still failing on some code not related to my commit (i think....)
:
lib/cfndsl/external_parameters.rb:56:23: C: Prefer JSON.parse instead of JSON#load.
params = JSON.load File.read(fname)
^^^^
lib/cfndsl/orchestration_template.rb:79:9: C: Use a guard clause instead of wrapping the code inside a conditional expression.
unless sname == pname
^^^^^^

@cmaxwellau I was reading the docs to write some tests, and it looks like you don't have to supply the hash if you are using AWS::Region for example.
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-sub.html
{ "Fn::Sub": "/opt/aws/bin/cfn-init -v --stack ${AWS::StackName} --resource LaunchConfig --configsets wordpress_install --region ${AWS::Region}" }

We should support that too, so we should make the second option optional.
e.g.
    # Equivalent to the CloudFormation template built in function Fn::Sub
    def FnSub(string, *substitutions)
      raise 'The first argument passed to Fn::Sub must be a string' unless string.instance_of?(String)
      raise 'Too many arguments to Fn::Sub' if substitutions.length > 1
      if substitutions[0]
      raise 'The second argument passed to Fn::Sub must be a Hash' unless substitutions[0].instance_of?(Hash)
            Fn.new('Sub', [string, substitutions[0]])
      else
            Fn.new('Sub', string)
      end
    end

Thinking tests might look like:
    context 'FnSub', 'String Hash' do
      it 'FnSub String Hash' do
        func = subject.FnSub('foo', 'x' => 'y')
        expect(func.to_json).to eq('{"Fn::Sub":["foo",{"x":"y"}]}')
      end
    end

    context 'FnSub', 'String' do
      it 'FnSub String' do
        func = subject.FnSub('foo')
        expect(func.to_json).to eq('{"Fn::Sub":"foo"}')
      end
    end

Thoughts?

With this, can we also add a deprecation warning to FnFormat? It was a cfndsl-only construct and it now seems obsolete.

diff --git a/lib/cfndsl/jsonable.rb b/lib/cfndsl/jsonable.rb
index 27d89c3..6b67857 100644
--- a/lib/cfndsl/jsonable.rb
+++ b/lib/cfndsl/jsonable.rb
@@ -101,27 +101,7 @@ module CfnDsl
     # TODO Can we simplyfy this somehow?
     # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity, Metrics/CyclomaticComplexity
     def FnFormat(string, *arguments)
-      array = []
-
-      if arguments.empty? || (arguments.length == 1 && arguments[0].instance_of?(Hash))
-        hash = arguments[0] || {}
-        string.scan(/(.*?)(?:%(%|\{([\w:]+)\})|\z)/m) do |x, y, z|
-          array.push x if x && !x.empty?
-
-          next unless y
-
-          array.push(y == '%' ? '%' : (hash[z] || hash[z.to_sym] || Ref(z)))
-        end
-      else
-        string.scan(/(.*?)(?:%(%|\d+)|\z)/m) do |x, y|
-          array.push x if x && !x.empty?
-
-          next unless y
-
-          array.push(y == '%' ? '%' : arguments[y.to_i])
-        end
-      end
-      Fn.new('Join', ['', array])
+      raise 'Fn::Format is no longer supported by CloudFormation. Consider using FnSub'
     end
     # rubocop:enable Metrics/AbcSize, Metrics/PerceivedComplexity, Metrics/CyclomaticComplexity
   end

Deprecating FnFormat will break a lot of existing templates. As long as FnJoin is supported, FnFormat will be needed.

@gergnz definitely agree on the optionality for FnSub

@cmaxwellau want to finish this one off, and we can bump a release that includes the new stuff in one go?  We can put FnFormat in a new issue, but is it still supported?  I couldn't find documentation.

FnFormat is a cfndsl construct only. AWS made FnSub, which obsoletes FnFormat and it should be deprecated. This doesn't mean ripping it out entirely, rather just issue a warning when the method is called that use of this method is discouraged in favor of something new, and its functionality is to be removed at a later time.

thanks for the clarification @kornypoet

@gergnz lets get the initial release in. I think there may be a discrepancy in the doco and need to validate expected vs actual behaviour.

@cmaxwellau Made a PR against your repo's branch.

@cmaxwellau Are you good with those adjustments so we can get this merged in?

Sorry for the away time @kornypoet @gergnz  I'm good with the adjustments

Quite excited to see this merged in and released with the next gem push.  :+1:

FnSub doesn't entirely supersede FnFormat.  For example,  array.push(y == '%' ? '%' : (hash[z] || hash[z.to_sym] || Ref(z))) allows for references to be resolved directly in the format string, which made a bit easier to read the code.
Would this be considered as an enhancement to the FnSub function in the future?