Preserve order of egg_info section in setup.cfg

egg_info is the dictionary with information that is injected
into setup.cfg. edit_config uses RawConfigParser which uses
collections.OrderedDict for all the data. Since we use a
simple dict(), when we loop through items in edit_config, we
see random behavior as a result the fields
tag_svn_revision/tag_date/tag_build are added to the setup.cfg
randomly. Let's add a OrderedDict to make it more predictable.

If we're going to make this something folk depend on, it really needs a test so that future developers don't break it by mistake.

Yes. I also think a test is called for. I'm not sure the implementation as written will work as I believe the keyword arguments will be ordered according to the PYTHONHASHSEED.

@rbtcollins @jaraco i've added a test and sorted the items by key. Seems to work. Please take a look.

It seems that the tests aren't capturing the new expectation in egg_info.py. If I apply the following patch to your branch, the tests still pass:
diff -r f08b20844fbd setuptools/command/egg_info.py
--- a/setuptools/command/egg_info.py	Mon Apr 18 15:08:49 2016 -0400
+++ b/setuptools/command/egg_info.py	Tue Apr 19 12:20:13 2016 -0400
@@ -2,11 +2,6 @@

 Create a distribution's .egg-info directory and contents"""

-try:
-    from collections import OrderedDict
-except ImportError:
-    OrderedDict = dict
-
 from distutils.filelist import FileList as _FileList
 from distutils.util import convert_path
 from distutils import log
@@ -72,10 +67,10 @@

     def save_version_info(self, filename):
         values = dict(
-            egg_info=OrderedDict(
+            egg_info=dict(
+                tag_svn_revision=0,
+                tag_date=0,
                 tag_build=self.tags(),
-                tag_date=0,
-                tag_svn_revision=0,
             )
         )
         edit_config(filename, values)

That leads me to believe the OrderedDict isn't required at all.
Furthermore, this new pull request alters the way that all config files are generated, which may have implications for files other than setup.cfg and sections other than egg_info. Rather than retaining the current order, it specifies a new order (sorted lexicographically).
In my experimentation, RawConfigParser will retain order of any existing options. It's only when new items are added that order is relevant (and they're always appended).
From the perspective of 'edit_config', I think I'd prefer to give control to the caller as to what order the settings are applied, rather than forcing lexicographic ordering.
Could you elaborate on what is the issue you're encountering that's inspiring this change?

Jason, Here's the background. We were trying to verify that old tarball(s) were not tampered with by generating fresh tar.gz(s) and comparing the two. Example output : https://etherpad.openstack.org/p/lJgI00FaLw

in the end, i'd like to be able to run md5sum on generated tar.gz(s) so we need the files generated to be deterministic.

@jaraco I don't know enough to say this fix is the best way to get what i want :) Any suggestions i'd be happy to explore

So I think that determinism is worth aspiring to. Note though that .gz
itself is not deterministic. In particular the mtime is that of the tarball
being compressed - E.g. now - and this we are going to have to address that.
I suggest a functional test that sdist of a reference project, done twice,
is byte identical - since after all, that is what you want to achieve.
Sorry if that is what your current test does - I'm responding to the email
thread.

We were trying to verify that old tarball(s) were not tampered with by generating fresh tar.gz(s) and comparing the two.

So updating setuptools won't support this use case for existing old tarballs, as they were already potentially generated with the nondeterministic ordering. This will only allow new tarballs, generated by users using this new functionality, to support this use case.

So I think that determinism is worth aspiring to.

Agreed, especially if the determinism doesn't also preclude giving control to the user over what fields appear in which order.
I'm slightly annoyed by how Setuptools is injecting default values into all of these tarballs. I wonder if instead Setuptools should just stop injecting these values, if that would solve the issue at hand.

Setuptools is injecting default values

That characterization isn't correct. These aren't default values, but overrides. Setuptools is replacing the user-supplied values, disabling 'tag_svn_revision' and 'tag_date', and instead materializing those values in 'tag_build'.
That makes sense, now that I think about it. You don't want those values being recalculated when the sdist is installed, but you want them materialized at build time so they're fixed to the build.

@dims: Does this latest implementation suit your needs?

@jaraco i'll test it and get back to you later today. thanks!


Do not display and filter deprecated referal_source in admin.

Coverage remained the same at 92.953% when pulling a653d28b153fd7e72df566504863e04a8410e6b7 on johngian:pr-1577 into 907f996b7aa7d0157a34a1866acdd22a952ea5f0 on mozilla:master.


Manage multiple models at the same time

Discussed in https://github.com/acturtle/cashflower/discussions/92

Originally posted by zchmielewska August 18, 2022

Let's assume that we have two models: example1 and example2.
To run both of them, we can use the following script:
import os
import subprocess

os.chdir("example1")
subprocess.run("python run.py")
os.chdir("..")

os.chdir("example2")
subprocess.run("python run.py")
os.chdir("..")


Only set topk webgl flags when using webgl backend

I think this will fix the CI failure.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

https://console.cloud.google.com/cloud-build/builds/80e92034-28ed-4047-a405-6b2e20769a82?project=834911136599

Perfect thanks for the fix!


Build summaries for Flutter SDK and core packages

This is a prerequisite for issue #26797.

We build Flutter SDK summaries, unlinked Flutter package summaries, and we build and use unlinked and linked summaries for pub.


Use source api endpoint in gitlab client for using self host gitlab

Hello @greysteil,
As we already discussed, we are very interested by your project.
But we use gitlab selfhosted, so we were waiting for the implementation of gitlab.
I discovered your project dependabot\dependabot-script and we tried to use it.
We got a lot of snafu but we got it at the end.
But to be able to make it work, we add to make some little changes. Here they are. Maybe it can be of some help.
You will maybe see that we didn't leave from master. There is a very good reason for that ! :smile:
We working on php/composer projects and we add a fatal yesterday due to this very recent commit on master : https://github.com/dependabot/dependabot-core/commit/319b92a99ecb0ff94a73dc1598b35a6bf3577215
Since we are on gitlab, we got no username to use for these credentials.
Maybe we can try to find a way to make it work.

👍 after the changes to the metadata classes. Thanks for this, and apologies you had trouble getting the script running!

Also, to get you back on master, you should be able to use your GitLab username combined with a personal access token - can you give that a try?

No need to apologise, I'm already amazed by the work dependabot did between our discussion in april and now. And there always need for alpha testing ! :smile:
For the username, I will try something before the end the week .

👍 👍. Failing spec is because I've got the wrong default for the GitLab API URL - will get this merged and fix that on master. 🎉


Class testing

Pull Request
Please include a summary of the change:
I created my mock data files for guests, rooms and bookings.
I made classes for Guest, Room, Booking, Manager and Hotel.
Room and Booking currently holding properties only.
Guest, Manager and Hotel have most of the methods and testing completed.
Need to review all classes against spec to see if additional functionality is needed.
I also added to basic structure and styling.
If it is a new feature, describe the feature and the iteration of the project spec it addresses. Note any questions or struggles as well.
These features address iterations 1 and 2.
Manager can login for iteration 1 but need to refactor so that guests can login as well as DOM updates.
Iteration 2 methods have been addressed in classes and testing.
Additional methods from next iterations may be needed.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the Turing style guidelines
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas

Files Modified:
modified:   src/Guest.js
modified:   src/Hotel.js
modified:   src/css/base.scss
modified:   src/domUpdates.js
modified:   src/index.html
modified:   src/index.js
modified:   test/Guest-test.js
modified:   test/Hotel-test.js
modified:   test/mock-booking-data.js
deleted:    test/sample-test-data.js

@Karlfunhouse PR buddy please review and merge if no conflix or concerns
Instructors @hannahhch @thatpamiam


dockerfile

Do you have the dockerfile？
I cant install pycuda
thanks you

I don't understand your question.  I tested the code in this repository on my Jetson Nano, Xavier NX and x86_64 PC.  I ran the code directly (without Docker).

ok , thank you.
Do you have try the yolov5 ？

Do you have try the yolov5?

No, I have not tried yolov5.

Do you have any idea to generate calibration for yolov5？

The procedure should be similar to how we do it for yolov4 and yolov3.


#level

Error!
Error: Missing discriminator!
using this command why?

should be fixed now, try updating the source code. close the issue if solved


fCube doesn't run on Ciao Prolog

One offending and not test covered code is:
rule(swff(t, ((A => B) => C)), S, NEWS, jumpbranch, IdxNewAtom) :-
	!,
	messageOnClosedSet([swff(t, ((A => B) => C))|S]),
	write('Left branch of T->->,'),
	partecerta(S, SCERTO),
	!,
	atom_concat(newAt, IdxNewAtom, NewAtom),
	semplificazione([swff(t, A)],
		[swff(t, A), swff(f, NewAtom), swff(t, (B => NewAtom)),
                swff(t, (NewAtom => C))|SCERTO], NEWS).

I guess it should use atomic_concat/3 or atom_number/2.
Test Case:
:- decide((~ (~ ( p_1
   <=> ( p_2
     <=> ( p_3
        <=> ( p_1
           <=> ( p_2
              <=> ( p_3
 ) ) ) ) ) ) ) ) ).

Fixed in 7233292e5079ba38d322c293a802b3033a6aeb31. All tests (including the one above) pass on Ciao Prolog (and other supported backends).


Feature flags to support building with stable Rust

We ought to support builds against stable since we don't rely on any of the features from nightly we use. We can achieve this using a feature flag and conditional compilation.

Finished in a157d30e8b67690efc9438d586383771405fa1ff


need fixed width font option while composing a message

It's difficult to see how many spaces there are for making nested lists without a fixed width font.
-

012345
iiiiiii <- FAIL
Most other apps use fixed width font (slack, githhub, etc...).

@devzzzero Hi, I would like to know more about this issue if you don't mind.

@devzzzero  Thanks for the suggestion, but I'm puzzled. Where do you see Slack or GitHub using fixed-width font in the compose box?
GitHub:

Slack:

@alya  I misspoke. You are right. github does not use fixed width font for message composing (but it does use it, for code viewing)
I'm trying to use zulip as a slack replacement for local team chat (for coding work, mostly), and not having fixed width font makes crafting nicely indented .md format messages a lot harder.
This shows up especially when trying to write an involved spec for something, requiring several levels of nesting for lists, etc..
Work around is to compose message in jupyter and copy-paste it into zulip, but that's just annoying.
Thanks for reading!

Got it. I'm going to close this issue as a duplicate of #24013.
In the meantime, https://zulip.com/help/preview-your-message-before-sending might be helpful.


Standalone now listens on 17513 by default

To make it not conflict with any other running node on the same network by default

bors merge


Update Curriculum Visualizer Tab

Description

Added UI elements to visualize curriculum units in curriculum Unit Sequence tab
Integrated Curriculum 2023 API for unit data
Updated subject phase picker to pre-select for current view
Deleted legacy subjects from subject phase picker

How to test

Go to https://deploy-preview-1798--oak-web-application.netlify.thenational.academy/beta/teachers/curriculum/maths-secondary/units
You should see a grid of the units in the maths secondary curriculum sequence
For years
You should see "Maths" and "Secondary" selected in the subject phase picker
In the subject phase picker, click on "Geography" then "Primary"
You should see a grid of the units in the geography primary curriculum sequence
Go to https://deploy-preview-1798--oak-web-application.netlify.thenational.academy/beta/teachers/curriculum/science-secondary/units
For year 10 and year 11, you should see filters for child subjects and tiers
Click "Physics" subject and "Higher" tier
You should see the units updated accordingly
Go to: https://deploy-preview-1798--oak-web-application.netlify.thenational.academy/beta/teachers/curriculum/english-primary/units
You should see domains for all years
Click "Grammar" for year 1
You should see the units updated accordingly

Checklist

[x] Added or updated tests where appropriate
[x] Manually tested across browsers / devices
[x] Considered impact on accessibility
[x] Design sign-off
[x] Approved by product owner

Some small UI things noted:
* The pink blocks that contain the unit cards should have a corner radius of 4px

* The unit card component in design has a background shape with rough edges. Is it possible to add this into the component? (I know sometimes these are tricky to work with)

* In the mobile journey, in design, the tabs component for the filters becomes a drop down to avoid them running over 2 lines. I’m not worried about this for now as I know we’re not optimising mobile, but is it possible to add some vertical padding, as they overlap when then run over 2 lines?

Otherwise, looks great!

Made changes in latest commit. There are some issues getting the spacing correct with the rough edges background, but should be an improvement!

I've manually confirmed:

4px border radius for pink containers
Rough borders for unit card components
Tab filters (child subject, domain) wrap onto
two lines.

My only query with the latter (@HelenHarlow) is whether there should be some extra padding below the tabs when there is no tier filter? (See third screenshot)

I've manually confirmed:

4px border radius for pink containers
Rough borders for unit card components
Tab filters (child subject, domain) wrap onto
two lines.

My only query with the latter (@HelenHarlow) is whether there should be some extra padding below the tabs when there is no tier filter? (See third screenshot)

Amazing that looks great now! Yes that does look a little tight, in Figma I have that gap as 16px

:tada: This PR is included in version 1.234.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


PNCircleChart "updateChartByCurrent: byTotal:" animation issues

I found that the circleChart animation does not work properly. For example, when the current value is less than the previous one, the circle will roll back at the end. Therefore, I made some changes to this function to make it work properly:
-(void)updateChartByCurrent:(NSNumber *)current byTotal:(NSNumber *)total {
double totalPercentageValue = [current floatValue]/([total floatValue]/100.0);
// add this section ===========
float previousStrokeEnd = [_current floatValue] / [_total floatValue];
float currentStrokeEnd = [current floatValue] / [total floatValue];

// when currentValue is less than or equal to previousValue
if ((fabs(currentStrokeEnd) < fabs(previousStrokeEnd) + FLT_EPSILON) ||
    (fabs((currentStrokeEnd) - (previousStrokeEnd)) < FLT_EPSILON))
{
    _circle.strokeEnd = currentStrokeEnd;
}
// when currentValue is larger than previousValue
else {
    _circle.strokeEnd = previousStrokeEnd;
}
// add this section ===========

if (_strokeColorGradientStart) {
    self.gradientMask.strokeEnd = currentStrokeEnd; // change to current stroke end
}

// Add animation
if (self.displayAnimated) {
    CABasicAnimation *pathAnimation = [CABasicAnimation animationWithKeyPath:@"strokeEnd"];
    pathAnimation.duration = self.duration;
    pathAnimation.timingFunction = [CAMediaTimingFunction functionWithName:kCAMediaTimingFunctionEaseInEaseOut];
    pathAnimation.fromValue = @([_current floatValue] / [_total floatValue]);
    pathAnimation.toValue = @([current floatValue] / [total floatValue]);

    if (_strokeColorGradientStart) {
        [self.gradientMask addAnimation:pathAnimation forKey:@"strokeEndAnimation"];
    }
    [_circle addAnimation:pathAnimation forKey:@"strokeEndAnimation"];

    if (_displayCountingLabel) {
        [self.countingLabel countFrom:fmin([_current floatValue], [_total floatValue]) to:totalPercentageValue withDuration:self.duration];
    }

}
else if (_displayCountingLabel) {
    [self.countingLabel countFrom:totalPercentageValue to:totalPercentageValue withDuration:self.duration];
}

//_circle.strokeEnd   = [current floatValue] / [total floatValue]; // remove this line
_current = current;
_total = total;

}
I hope that I could make some help : )

I also found this issue,but my solution is simpler.
Move _circle.strokeEnd  forward .
 if (_strokeColorGradientStart) {         self.gradientMask.strokeEnd = _circle.strokeEnd;     }
_circle.strokeEnd   = [current floatValue] / [total floatValue];


Crash when compressing Image

Godot version:
Godot 3.2.4 rc 2
Issue description:
Executing
extends Node2D

var q_Image : Image = Image.new()

func _process(_delta : float) -> void:
	if randi() % 2 == 0:
		q_Image.create((randi() % int(100)) - int(100 / 2.0), (randi() % int(100)) - int(100 / 2.0), bool(randi() % 2), (randi() % int(100)) - int(100 / 2.0))
	if randi() % 2 == 0:
		q_Image.create_from_data((randi() % int(100)) - int(100 / 2.0), (randi() % int(100)) - int(100 / 2.0), bool(randi() % 2), (randi() % int(100)) - int(100 / 2.0), PoolByteArray([]))
	if randi() % 2 == 0:
		q_Image.is_empty()
	if randi() % 2 == 0:
		q_Image.load(".")
	if randi() % 2 == 0:
		q_Image.save_exr(".", bool(randi() % 2))
	if randi() % 2 == 0:
		q_Image.detect_alpha()
	if randi() % 2 == 0:
		q_Image.is_invisible()
	if randi() % 2 == 0:
		q_Image.compress((randi() % int(100)) - int(100 / 2.0), (randi() % int(100)) - int(100 / 2.0), (randf() * 100) - (100 / 2.0))
	if randi() % 2 == 0:
		q_Image.decompress()
	pass

crashes with backtrace
core/image.cpp:367:52: runtime error: load of value<PHONE_NUMBER>, which is not a valid value for type 'Format'
core/image.cpp:291:41: runtime error: load of value<PHONE_NUMBER>, which is not a valid value for type 'Format'
core/image.cpp:292:45: runtime error: load of value<PHONE_NUMBER>, which is not a valid value for type 'Format'
core/image.cpp:293:36: runtime error: load of value<PHONE_NUMBER>, which is not a valid value for type 'Format'
core/image.cpp:295:28: runtime error: load of value<PHONE_NUMBER>, which is not a valid value for type 'Format'
core/pool_vector.h:307:75: runtime error: reference binding to null pointer of type 'const unsigned char'
thirdparty/squish/squish.cpp:177:23: runtime error: load of null pointer of type 'const u8'
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] godots() [0x16f757a] (/mnt/Miecz/godot3.2/platform/x11/crash_handler_x11.cpp:54)
[2] /lib/x86_64-linux-gnu/libc.so.6(+0x46210) [0x7fcbaa817210] (??:0)
[3] squish::CopyRGBA(unsigned char const*, unsigned char*, int) (/mnt/Miecz/godot3.2/thirdparty/squish/squish.cpp:177 (discriminator 2))
[4] squish::CompressImage(unsigned char const*, int, int, int, void*, int, float*) (/mnt/Miecz/godot3.2/thirdparty/squish/squish.cpp:218)
[5] squish::CompressImage(unsigned char const*, int, int, void*, int, float*) (/mnt/Miecz/godot3.2/thirdparty/squish/squish.cpp:237)
[6] image_compress_squish(Image*, float, Image::CompressSource) (/mnt/Miecz/godot3.2/modules/squish/image_compress_squish.cpp:194)
[7] Image::compress(Image::CompressMode, Image::CompressSource, float) (/mnt/Miecz/godot3.2/core/image.cpp:1975)
[8] MethodBind3R<Error, Image::CompressMode, Image::CompressSource, float>::call(Object*, Variant const**, int, Variant::CallError&) (/mnt/Miecz/godot3.2/./core/method_bind.gen.inc:2505 (discriminator 16))
[9] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/mnt/Miecz/godot3.2/core/object.cpp:919 (discriminator 1))
[10] Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) (/mnt/Miecz/godot3.2/core/variant_call.cpp:1129 (discriminator 1))
[11] GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) (/mnt/Miecz/godot3.2/modules/gdscript/gdscript_function.cpp:1089)
[12] GDScriptInstance::call_multilevel(StringName const&, Variant const**, int) (/mnt/Miecz/godot3.2/modules/gdscript/gdscript.cpp:1254)
[13] Node::_notification(int) (/mnt/Miecz/godot3.2/scene/main/node.cpp:58)
[14] Node::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/main/node.h:46 (discriminator 14))
[15] CanvasItem::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/2d/canvas_item.h:166 (discriminator 3))
[16] Node2D::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/2d/node_2d.h:38 (discriminator 3))
[17] Object::notification(int, bool) (/mnt/Miecz/godot3.2/core/object.cpp:931)
[18] SceneTree::_notify_group_pause(StringName const&, int) (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:988)
[19] SceneTree::idle(float) (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:528 (discriminator 3))
[20] Main::iteration() (/mnt/Miecz/godot3.2/main/main.cpp:2108)
[21] OS_X11::run() (/mnt/Miecz/godot3.2/platform/x11/os_x11.cpp:3634)
[22] godots(main+0x331) [0x16ee467] (/mnt/Miecz/godot3.2/platform/x11/godot_x11.cpp:57)
[23] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7fcbaa7f80b3] (??:0)
[24] godots(_start+0x2e) [0x16ee07e] (??:?)

I tried to reproduce this, but got  Image format not supported for saving as EXR. Consider saving as PNG. instead, which is quite informative, and as far as i know, expected behavior?
I tried this on Windows 10, and it seems you got a Mac, so maybe someone else should try to reproduce.
Tested on a simple scene with one Node2D-node and script as described.

I also don't quite understand what you are trying to do with this code. It seems like a product of fuzzing/monkey testing? Could you elaborate on the expected behavior of this code?

I also don't quite understand what you are trying to do with this code.  It seems like a product of fuzzing/monkey testing?

Yes, this is part of my fuzzing project.

I tried this on Windows 10, and it seems you got a Mac, so maybe someone else should try to reproduce.

I checked this project on 2 computers with Linux, and on both it crashes.
Crash happens due dereferencing null pointer which is undefined situation in C/C++, so it may not crash on other OS.

@mindtonix these snippets can be boiled down to one-liners most of the time, but requires some more testing and sometimes a build with sanitizer support (which is not available in Windows 10 for now, see use_usan, use_asan build options on Linux).

Closing this issue, since #46480 is duplicate but contains better reproduction projects


NumFOCUS onboarding

[ ] Add the “Powered by NumFOCUS” badge for your website and GitHub.
Markdown for adding NumFOCUS badge to project websites: ![Powered by
NumFOCUS]( https://img.shields.io/badge/powered%20by-NumFOCUS-orange.s
vg?style=flat&colorA=E1523D&colorB=007D8A )
[ ] Add the Fiscal Sponsor Readme Attribution to your project’s GitHub:
https://github.com/numfocus/templates/blob/master/fiscal-sponsor-readme-attribution.md
[ ] Add the NumFOCUS sponsored project logo ( with link to numfocus.org ) to your
project’s website (under About) and language indicating that you are a sponsored project
of NumFOCUS. For example: “[Project] is a fiscally sponsored project of NumFOCUS, a
nonprofit dedicated to supporting the open-source scientific computing community. If you
like [Project] and want to support our mission, please consider making a [donation](link
to Salsa campaign) to support our efforts.” (*We will provide you the campaign link to
include on your website once you’ve sent us the marketing materials listed above)
[ ] Link to the donation page. Please use this exact language alongside the donation link:
“NumFOCUS is a 501(c)(3) non-profit charity in the United States; as such, donations to
NumFOCUS are tax-deductible as allowed by law. As with any donation, you should
consult with your personal tax adviser or the IRS about your particular tax situation.”

For the last point, I think the sponsorship page is https://numfocus.org/donate-for-pybamm

hello @tinosulzer I would like to work on this issue. Can you please assign it to me?

Hi @dikwickley! We already have an ongoing PR for this #2614. If you want to contribute to PyBaMM a great place to start is by tackling one of the issues labelled as easy.


Update 'triage' workflow to use the 'pull_request_target' event hook

Change Overview
This should fix the ongoing issue where PRs from forks are not getting added to the project board. See doc here, under "Parameter token or opts.auth is required".
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[x] :hamster: Trivial/Minor
[x] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Closing this PR for now, as we shouldn't be using pull_request_target with untrusted forks. See this.

Good catch @ihcsim


Bug: Font settings interference

Sometimes the fonts will override each other. Here's an example:

This should be showing only monotype corsiva (the cursif one) in the code block in edit mode but it does not:

Are you sure that you spelled the font correctly? You might need to have capitalization in the name. It must match exactly how it is spelled at the OS level.

 You might need to have capitalization in the name. It must match exactly how it is spelled at the OS level.


Max Array Sum

Problem Link
https://www.hackerrank.com/challenges/max-array-sum/problem?h_l=interview&playlist_slugs[]=interview-preparation-kit&playlist_slugs[]=dynamic-programming
Coding platform
Hackerrank
Programming language

[ ] C
[ ] C++
[ ] Java
[ ] Python

Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.

I want to work on this issue in Java.

Please assign me in C++ :)

Hi @Nivedita967
I would like to solve it in Python. Please assign it to me.

I would like to do this in C.

Hello @Nivedita967 , I would like to do it in python. Kindly assign it to me! :)

Hello @Nivedita967 , I would like to do it in python. Kindly assign it to me! :)

Not open.

@Nivedita967 is it open??

@Nivedita967 is it open??

NO.

@kanak22 Are you working on this?

@kanak22 Are you working on this?

yes just give me half an hour :)

@Nivedita967  I made the PR. Kindly check :)


Include also some of the smaller HGBS sets

This includes the 10^{-5} and 10^{-7} variants of the HGBS basis sets, which may be useful for preliminary calculations; it indeed appears that even though the truncation error in the total energy is large for the 10^{-5} basis set, atomization energies may be already reproduced quite accurately, provided sufficiently many polarization shells are included in the calculation.
The 10^{-9} basis sets are still recommended for benchmark applications.

@bennybp ready to merge


Rename BinaryExpression and UnaryExpression

Ensure naming consistency between prefix, infix, and postfix expressions. Postfix expressions are already called PostfixExpression.
BinaryExpression -> InfixExpression
UnaryExpression -> PrefixExpression

Commit: https://github.com/johneastman/boomerang/commit/88c02d6880e888e9e697f27d2ff9dd35bf2fa888


integration-cli: make TestPsGroupPortRange fast

This PR reduces the number of ports in the port range. This change makes this test run in 4 seconds. It used to take 45 seconds to run this test.

assuming janky is happy, LGTM

nice, LGTM


Please do not use CDN for jquery, because we Chinese have a firewall.

I am also from China. There are some CDN services which are quite stable accessed from China.
For example: http://www.jsdelivr.com/  and  https://cdnjs.com/
Could you please have a try? Overall I prefer a CDN service instead of host a third party library.

All the doc files are auto generated
https://github.com/knsv/mermaid/blob/master/gulp/tasks/doc.js
Please don't update them directly. You'd have to update the doc generator instead.

All the doc files are auto generated
https://github.com/knsv/mermaid/blob/master/gulp/tasks/doc.js
Please don't update them directly. You'd have to update the doc generator instead.
I am also from China. There are some CDN services which are quite stable accessed from China.
For example: http://www.jsdelivr.com/  and  https://cdnjs.com/
Could you please have a try? Overall I prefer a CDN service instead of hosting a third party library.

The documentation has been moved to https://mermaidjs.github.io/, source code is here: https://github.com/mermaidjs/mermaid-gitbook
No jquery is being used.
Closing this PR.
Thank you all the same!


Landing page should be blank

The landing page of the popup cannot be determined before runtime, so it should be blank until directions are given by the backend.
(For instance, it can't be the Wallet Setup page in the case that the user's wallet is already set up, and cannot be the Home page in the case that no wallet is set up.)

[x] Create screen that redirects the page based on wallet status
[x] Assign screen to landing page

Fixed with ExistingWallet page.


[add-resource] New Plugin

I would like to add my new plugin/theme to the Grav Repository.
Here are the project details: finanalyst/grav-plugin-map-quest

Added to GPM for next update


Dropdown menu icon does not toggle open/close on click

When clicking a Dropdown menu icon (chevron), it is supposed to toggle the opened/closed state of the menu. Instead, only works clicking on the component area besides it.
Example from Storybook
By the way, it does work in similar components like ComboBox or Select.

@albertms10 Nice catch.
Patched in version 0.12.2


Upgrade dpl docs dependencies

Fixes:

Types now have some CSS styling
Cross references within backtick code work again
Fixed invalid nesting of HTML elements in some cases
Function attributes are highlighted
Automatic cross-referencing outside of D code is now disabled
@... built-in attributes are now highlighted as keywords

Still missing: sometimes keywords are not recognized as such, seems to be a bug in libdparse.

Automatic cross-referencing outside of D code is now disabled

Awesome. Now we just need to change the spec to match :)

Just saw that @.. is currently rendered incorrectly - should have waited for the CI to pass.

Selected package ddox 0.14.2 doesn't exist. Using latest matching version instead.
Root package dpl-docs contains reference to invalid package ddox >=0.14.0 <0.15.0

Hmm, do I need to do something on the server again?

Hmm, do I need to do something on the server again?

We really need to get out a new version of DUB. This is still the metadata cache issue (it doesn't recognize new package versions before 24h have passed, or if dub clean-caches is run).

Now we just need to change the spec to match

That would be really nice, with support for backtick code, the current "Emphasis"  handling appears like a useless crutch. BTW, looks like the spec got actually changed to allow links to be used - Walter used to oppose that idea when I first told him how DDOX works.

Hmm, with no links, the cheat sheets in module documentation are now useless:
http://dtest.thecybershadow.net/artifact/website-506f641ae1b0c3bdf4d23fa5150af8077b24db0f-d574e16d12b7bce09f483558c3467b83/web/library/std/traits.html

Maybe LREF in std-ddox.ddoc should be changed to $(D $1)?

Same with XREF and other macros there.

Looks good!
Style nit, there are some links with blue text and a red underline, which clash a bit.

Ouch, there's some HTML visible:
http://dtest.thecybershadow.net/artifact/website-7f3804b809d871c676c056e8def98a0cc7bf208c-99de2fdd99ed0a6a8cdb703744440eb6/web/library-prerelease/std/range.html

Looks good. BTW, in the future add a comment to a PR after updating it, as there's otherwise no notification, and I may forget to come back to it.

dlang.org updated.

                                                                                I forgot about it after waiting for the test build to finish (got company).                                                                                Gesendet von meinem BlackBerry 10-Smartphone.                                                                                Von: Vladimir PanteleevGesendet: Mittwoch, 20. April 2016 04:15An: dlang/dlang.orgAntwort an: dlang/dlang.orgCc: Sönke Ludwig; AuthorBetreff: Re: [dlang/dlang.org] Upgrade dpl docs dependencies (#1274)Looks good. BTW, in the future add a comment to a PR after updating it, as there's otherwise no notification, and I may forget to come back to it.

—You are receiving this because you authored the thread.Reply to this email directly or view it on GitHub


Gitpod should clone a fork

Extracted from https://github.com/iterative/dvc.org/pull/1226#issuecomment-624418719 and https://github.com/iterative/dvc.org/pull/1226#issuecomment-624437520

I tried using Gitpod from https://dvc.org/doc/user-guide/contributing/docs#development-environment to submit a change. It was all working nicely, (I even installed a VS Code plugin to the IDE.) But after committing with Git, I'm unable to push because I didn't grant Gitpod permission to push directly to dvc.org

Open source contributors will never have this permission. Can it be made so a fork is created in their accounts first, and then Gitpod launched from there?

For example, I tried with another account I own, @AyokVoluntarios, which doesn't have push access to this repo, but it also cloned the upstream directly:

So again, even if I tell Github to let Gitpod push to my repos, I simply can't do it from that account.

The user would need to configure the Git remote and branch manually from the IDE. Do you know whether that's the only solution, @nisarhassan12? Thanks

I tried using Gitpod from https://dvc.org/doc/user-guide/contributing/docs#development-environment to submit a change. It was all working nicely, (I even installed a VS Code plugin to the IDE.) But after committing with Git, I'm unable to push because I didn't grant Gitpod permission to push directly to dvc.org

Thanks, @jorgeorpinel This is happening maybe because you have not granted Gitpod the permissions to do so. You can manage the access control here: https://gitpod.io/access-control/

Open source contributors will never have this permission. Can it be made so a fork is created in their accounts first, and then Gitpod launched from there?

When a repo is opened where you don't have push access and you have made a change and are about to commit, A prompts appears from where one can fork and then push to his fork. Another way to fork is F1 > Fork. I think it would be nice if it's documented in the project contributing guide.

You can manage the access control

Unfortunately Gitpod wants access to manage repo settings and development keys so I don't feel comfortable giving it those permissions from my account, since I have admin access to the repo. Maybe for a developer in an org this would be OK but they will probably have a local dev env anyway.

When a repo is opened where you don't have push access and you have made a change and are about to commit, A prompts appears from where one can fork and then push to his fork. Another way to fork is F1 > Fork. I think it would be nice if it's documented in the projects contributing guide.

Yes, we would need to document this in the Gitpod block quote in https://dvc.org/doc/user-guide/contributing/docs#development-environment, would you like to send a PR @nisarhassan12? Feel free to use a <details> hidden section (example in https://dvc.org/doc/tutorials/get-started/configure)
But it may be turning a little complicated. Not sure how useful it will result. It's definitely a good option to have but... Casual contributors can make small changes directly from Github, and regulars will probably want to run things locally. For example it takes much longer to run the local dev server on Gitpod than on my Windows laptop. But anyway, if you can help us explain the whole process including forking etc up till the pull request is submitted (hopefully it's only a few steps) that would be great.

I'm removing the note for now, please revert https://github.com/iterative/dvc.org/pull/1195/commits/87906e25832197da18f700be49e1a6d0885b7e7d and complete the guide when possible. Thanks

Thanks! I'll make a PR soon.

No rush

Thank you!

Hey @jorgeorpinel I have already made this PR https://github.com/iterative/dvc.org/pull/1262

Closing this, see motivation here https://github.com/iterative/dvc.org/pull/1262#issuecomment-631160576


How to: regenerate the bindings?

Hi, I wanted to know how did you generate the zig bindings for the lib, to generate them myself using updated versions of wgpu.
Thanks in advance

I just cleaned up the zig translate-c generated file.


DCS-1689: ✨ Add endpoint to store a referring system

This PR supports the capability to allow services to navigate users to DPS, and configure DPS to provide dynamic navigation back to the original service.
To do this, I have created a new endpoint called /save-backlink which takes in the following query parameters:

service (required) - identifies the service which maps to a pre-registered hostname and default options.
returnResource (required) - allows the service to dynamically return the user to different resources, depending on the journey.
toResource (require) - where to redirect the user within DPS after storing backlink information. Allowing services to dynamically send users to different parts of DPS depending on journey.
defaultBackLinkText (optional) - Optional text that will be displayed within the DPS profile, each service has default text that is displayed.

I've also migrated the View most recent search functionality over to use this more general approach. The visible difference in this functionality due to this migration are:

The prisoner links on the prisoner search page read as /save-backlink?... instead of directly to the prisoner-page (though the users are redirected to the same place as before)
The return URL now reads as alerts[]=A,B,C instead of alerts%5B%5D=A&alerts%5B%5D=B. They seem to act the same functionally, though can't find any documentation on query parameter standards.

Just noticed there's a lot more query params in the search page. Going to go with @andrewrlee suggestions of passing in the URL to the template 👍 Put PR to draft for time being

Allowing clients to specify redirect locations is quite risky and as we've seen its easy for subtle security issues to sneak in, I think this is safe now..

@andrewrlee won't you have to do this some how? Wouldn't clients want to return back to a dynamic url, e.g go back to list of prisoners in a specific
prison in say MPC or whatever?

It feels like like we should be able to simplify this to something like
/prisoners/A1234AK?returnUrl=https://pathfinder.service.hmpps.gov.uk/mynominals?region=london
Then you can just build up an allowlist of domains when needed:
config: {
redirectDomainsAllowList: ['pathfinder.service.hmpps.gov.uk', 'someotherdomain']
}
Then the middleware is looking for the special returnUrl or some such thing.

It feels like like we should be able to simplify this to something like
/prisoners/A1234AK?returnUrl=https://pathfinder.service.hmpps.gov.uk/mynominals?region=london
Then you can just build up an allowlist of domains when needed:
config: { redirectDomainsAllowList: ['pathfinder.service.hmpps.gov.uk', 'someotherdomain'] }
Then the middleware is looking for the special returnUrl or some such thing.

Hi @andymarke, thanks for having a nosey at this! 😁 I see what you mean with the simplification; I think this would be a good idea if we were always landing on the prisoner profile. For our journeys, though, we want to send the user to other parts of DPS, more specifically, to add a case note on the initial landing.
Merged in the changes - I think it's good enough to go; it might need some refinement as we add other journeys into it. I know Cell Moves within DPS uses backlinks as buttons on the page, so some sort of display configuration may be required 🤔 We'll cross that bridge when we get to it, though! 🌉

Sounds good to me


Allow "else if" without nesting

As of v0.1, multiple if statements in a row require nesting:
if (cond1)
{
}
else
{
  if (cond2)
  {
  }
  else
  {
  }
}

I'd like to allow the more normal "else if" construction:
if (cond1)
{
}
else if (cond2)
{
}
else
{
}

Right now, this is prohibited by the requirement that if/else bodies must be surrounded by braces, but it may be possible to change the grammar to avoid this.

Golang requires braces but allows else-if; the grammar is
IfStmt = "if" [ SimpleStmt ";" ] Expression Block [ "else" ( IfStmt | Block ) ] .

I'd modify the grammar from:
IfStatement -> "if" "(" LogicalExpression ")" Block "else" Block

to
IfStatement -> "if" "(" LogicalExpression ")" Block "else" (Block | IfStatement)


[UI] Applications: Adding a default image for the broken / unsupported application Icons.

Description
A ss taken from the current situation.

Addition of a default image renders this ->

This PR fixes #6161
Notes for Reviewers
If there's no application type defined or one defined, but that is not supported (e.g. " "), we are trying to  incorporate a default icon which is taken to be https://drive.google.com/drive/folders/1izNTsbspq554e0qxCzv6d3AvjvIUkg4D as all other icons are also colored.
Signed commits

[x] Yes, I signed my commits.

@legendarykamal eslint check is failing here. 😬. Are you adding no verify flag while committing?

No , There is 1 error generated , the rest are key-prop warnings not related to this PR . I will fix the error. 👍

@legendarykamal Oh, I missed typed here we don't allow uploading an unsupported type in the application.

@Chadha93 fixed the ui eslint error and updated the required ss.

@legendarykamal Eslint workflow is fixed in master. :heavy_check_mark:
Will you look into the eslint errors on your PR? Please update the PR.

https://github.com/meshery/meshery/issues/6161#issuecomment-1379372765

Thanks for your help, @legendarykamal. Let's close out this PR as no longer desired.


fix typo in AnalyticsGenerator

{team.shortName} failed {problem.letter}.{problem.name} due to AC :)

Thanks, I've fixed myself a bit differently in 859a4d2f60


Build a Cool clock

Create a Clock
Tech Used:

Html5
Css3
Javascript

I am a GSSoC'22 participant.
I want to work in this issue.
Please assign this issue to me.

Already there on the website


Adding unique_id using python uuid to be used in URL like  /helpdesk/ticket/8a75346b-72f4-4884-8a47-f447005b9be5

Is your feature request related to a problem? Please describe.
We are building a production grade ticketing system using this very nice well built and maintained ticketing software for django. Right now, something that we find not so clear is the inclusion of the database id right inside the url. Because we plan for mass usage among different folks, we fear tempering with id in the url or guessing the next or previous ID which the user might not be entitled to acccess. True there may be some access control on particular kind of ticket, But we at least request a change on that to something so the ID does not appear on URL but instead something obstructed in the url from python uuid module.
Describe the solution you'd like
The solution is very simple and won't require much changes
unique_id = models.SlugField(blank=True, null=True, max_length=250)

   def save(self, *args, **kwargs):
       if (not self.unique_id):
           self.unique_id = str(uuid.uuid4())

If you can accept this, then you can assign this to me so that I can make the change need to push it right here
Thank you soo Folks

Thanks for the report! Many sites like even GitHub use the ticket ID right in the URL, I think it can be helpful to easily share the URL and verify it is the correct one for a ticket. I would suggest that better user permissions would help more so than trying to obfuscate the URL. Can you explain a little more your use case and why revealing the ticket numbers might be harmful?
If there's community support for such a feature I don't mind merging it in as an optional (not default) feature.

I thought about permission and probably, it will work.
As for our use case, we plan to deploy it out there and make it available to any one including companies. Because it is going to be in the wild, we thought, it would be a great idea to replace it with uuid_id generated automatically.
Otherwise thank you, we shall continue with the permission.

There is now a secret key associated with each ticket.

This is actually a valid concern from a security perspective.
It  is easily solved by changing the primary key generator to use a UUID instead of a sequential int which is the Django default.
To support alternative primary keys we should create a base class for models that uses the  django.db.models.Model class as the super class that is empty and then use that base class in all the Helpdesk models instead of models.Model.
Anyone using Helpdesk can then override the base class with a custom primary key and the URL's would then use the UUID which is solves the problem without using code to obfuscate the ID
The documentation should then be be enhanced to indicate this as a configiration decision when setting up Django Helpdesk.

Fair enough.


added a way to sanitise headers

This adds a way to sanitise http headers before saving them for rollbar. Basically RollbarFilter uses HeaderSanitizer to filter headers when storing them in MDC.
HeaderSanitizer implementation is project-specific and is not provided, except the default NoOpHeaderSanitizer which does nothing.

Coder reviewed.


Add CI for macOS 10.15.

Testing to see if building on 10.15 works...

(Moved to local repo, just to test stuff out more easily without clogging up here).


Markdown user snippet not working in math context or brackets

Issue Type: Bug
For the markdown file like the following, with "mu" defined as a prefix of "\mu" in user snippets.
mu

$mu$

$(mu)$

$$
mu
$$

mu

The user snippet
{
	"mu2":{"prefix": "mu",
		"body": [
			"\\mu ",
		],
		"description": "output mu"}
}

The suggestion is disabled for the "mu" in $(mu)$ or $$ mu $$. When using Ctrl+Space behind "mu", it shows "no suggestions". However, the suggestions works good for other "mu"s. And I can use Tab completion in these cases.
I noticed this situation from about Feb 2021. And I have the same issue on other platforms e.g. windows.

Your problem is a complex topic involving how:

TextMate-based tokenization works.

VS Code understands embedded languages.

Snippets and languages are connected.

I hope that the Scope Inspector and issue #142022 can help you understand it.
Given the current design (VS Code 1.65), your experience is basically the expected behavior.

I see, now I changed the user snippets instead of markdown snippets and it works, thank you very much.


The connect modal get stuck on Select wallets step

Hello,
we are experiencing a new issue regarding the Crossmint connect button.
version: 0.0.9-alpha.6

The user clicks on Connect button, and a Crossmint window is opened correctly
The user sees all the permissions he will give to the app, and clicks on "Connect" button
A "Select wallets access" window appears for a second and is closed immediately, the user has no chance to select any wallet. At this moment, the user is stuck. They can click on the "Connect" button again with the same result, so it is impossible to get past this step.

You can even experience the same behavior on the official demo: https://embed-crossmint.vercel.app/
Notes:
It worked fine a week ago with the same version and configuration on the client-side.
If the user has already authorized the app, step 2 is skipped and the process works fine.

@rychnovsky - thanks for the report! This issue is fixed. It doesn't require a package update.


[MESSAGING] Move Message Builder Methods to Messaging Modules

Instead of seperate MessageBuilder classes per module there should be one central class in the messaging module to build Messages.

In https://github.com/International-Data-Spaces-Association/IDS-Messaging-Services/commit/6ab4954df3a9b1b431fa48dfaf5b961f273738e3 the new RequestBuilders (and MessageTemplates) from the Messaging module are used, the MessageBuilder classes were deleted.
=> this is also linked to https://github.com/International-Data-Spaces-Association/IDS-Messaging-Services/pull/172


Fixed an issue in the sample code where if the prop enthusiasmLevel w…

fixes #185 There was an issue in the sample code where if the prop enthusiasmLevel was passed as 0 the error 'You could be a little more enthusiastic. :D' would never be thrown. Used reacts defaultProps to pass enthusiasmLevel's default value as 1. This should allow 0 to still be passed resolving the issue.

Please merge, I have the same issues when trying to follow the tutorial.

This issue has been raised here as well: https://github.com/Microsoft/TypeScript-React-Starter/issues/199
There are at least a couple of ways one could address this. I changed the constructor as follows:
  constructor(props:Props) {
    super(props);
    const defaultProps = { enthusiasmLevel: 1 }
    const mergedProps = { ...defaultProps, ...props };
    this.state = { currentEnthusiasm: mergedProps.enthusiasmLevel };
  }


TECKIN SP22 tasmota only makes backup.

I'm trying to flash tasmota to teckin sp22. Tuya-convert only makes firmware backup. I don't know what im doing wrong.
Im doing this on LinuxMint and KaliLinux. same errors in smarthack-psk.log
./start_flash.sh
Checking for network interface wlp3s0... Found.
Checking UDP port 53... Occupied by dnsmasq with PID 3472.
Port 53 is needed to resolve DNS queries
Do you wish to terminate dnsmasq? [y/N] y
Attempting to terminate dnsmasq
kill: (3472): Nie ma takiego procesu
Checking UDP port 67... Available.
Checking TCP port 80... Available.
Checking TCP port 443... Available.
Checking UDP port 6666... Available.
Checking UDP port 6667... Available.
Checking TCP port 1883... Available.
Checking TCP port 8886... Available.
======================================================
  Starting AP in a screen.
  Starting web server in a screen
  Starting Mosquitto in a screen
  Starting PSK frontend in a screen

======================================================

IMPORTANT
1. Connect any other device (a smartphone or something) to the WIFI vtrust-flash
   This step is IMPORTANT otherwise the smartconfig will not work!
2. Put your IoT device in autoconfig/smartconfig/pairing mode (LED will blink fast). This is usually done by pressing and holding the primary button of the device
3. Press ENTER to continue

======================================================
Starting smart config pairing procedure
Waiting for the device to install the intermediate firmware
Put device in EZ config mode (blinking fast)
Sending SSID                  vtrust-flash
Sending wifiPassword
Sending token                 00000000
Sending secret                0101

IoT-device is online with ip <IP_ADDRESS>
Stopping smart config
Fetching firmware backup
./start_flash.sh: linia 110:  4143 Zakończony             ./smartconfig/main.py
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1024k  100 1024k    0     0  14968      0  0:01:10  0:01:10 --:--:-- 14365
curl: Saved to filename 'firmware-62c14c.bin'
======================================================
Getting Info from IoT-device
VTRUST-FLASH 1.3
(c) VTRUST GMBH https://www.vtrust.de/35c3/
READ FLASH: http://<IP_ADDRESS>/backup
ChipID: 62c14c
MAC: 84:0D:8E:62:C1:4C
BootVersion: 4
BootMode: normal
FlashMode: 1M DOUT @ 40MHz
FlashChipId: 144051
FlashChipRealSize: 1024K
Active Userspace: user2 0x81000
======================================================
Please make sure to note the correct SPI flash mode!
Installing an alternative firmware with the wrong flash mode will leave the ESP unable to boot!

Next steps:
1. To go back to the orginal software
   # curl http://<IP_ADDRESS>/undo

2. Be sure the conversion software runs in user2
   # curl http://<IP_ADDRESS>/flash2

3. Flash a third party firmware to the device
BE SURE THE FIRMWARE FITS THE DEVICE AND USES THE CORRECT FLASH MODE!
MAXIMUM SIZE IS 512KB
put or link it to ./files/thirdparty.bin
A build of Tasmota v<IP_ADDRESS> is already included in this repository.
   # curl http://<IP_ADDRESS>/flash3
If you want to flash the included ESPurna 1.13.5 image use this command:
   # curl http://<IP_ADDRESS>/flash3?url=http://<IP_ADDRESS>/files/espurna-base.bin
Alternatively let the device download and flash a file via HTTP:
   # curl http://<IP_ADDRESS>/flash3?url=http://<IP_ADDRESS>/files/thirdparty.bin

HAVE FUN!
======================================================
Do you want to flash another device? [y/N] y
======================================================

IMPORTANT
1. Connect any other device (a smartphone or something) to the WIFI vtrust-flash
   This step is IMPORTANT otherwise the .. work!
2. Put your IoT device in autoconfig/smartconfig/pairing mode (LED will blink fast). This is usually done by pressing and holding the primary button of the device
3. Press ENTER to continue

....etc

Do you want to flash another device? [y/N] n
Exiting...

logs:
smarthack-web.log
smarthack-wifi.log
smarthack-psk.log
smarthack-mqtt.log

Did you follow the "Next steps"?

If you're looking for a more guided process that does everything automatically, check out the development branch. Otherwise you need to tell it what you want it to do.

Did you follow the "Next steps"?
now i see. few months ago installation tasmota has been little bit different as now. I will try in 15 mins and report results.

Tasmota flashed succesfully. Closed.


Sync with upstream 1.16.6

Manual sync as there were some conflicts.
Closes #822 .

/retest

/retest


blaa blaaa

just for testing

Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test")


rg351mp wont recognize second sd card for roms

running latest build 11042023
when i try to switch to secondary sd card i get the following error:
could not find a fat, fat32 exfat, ext4 or ntfs based sdcard to mount from slot2
i have tried to rebuilding arkos and tried samsung, sandisk and several cards but no luck. i even tried replacing the os sd card with another just so that i can try the os card on slot 2 but i still get the same error.  i also tried formating the sd card as fat32, ntfs and exfat.

Either something is wrong with your slot2 or your sd cards have more than 1 partition.  Have you tried any other OS including stock to see if the issue happens there?

no disadvantage.  Just a slight inconvenience if you ever need to reflash the OS.  You'd have to recopy your games as well.  Good luck and take care.

i ordered a second samsung sd card and that seemed to work. looks like your os is really picky with the sd cards, they must be a specific type. all good now, thank you for your help.


Update site-recovery-faq.md

fixing capitalization typo

Hi @adamglick, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@adamglick : Thanks for your contribution to the Azure documentation! The author, @rayne-wiselman, has been notified to review your proposed change.

Good to go
#sign-off


Package Management features

install: Install packages
uninstall: Uninstall packages
update: Update packages
list: List installed packages

outdated: List outdated packages

Is this specifically for development packages or global executable packages? You will have to forgive my inexperience with Haskell here in case many/none of the following are actually applicable.
If we are talking about system packages (also relevant in many cases for dev too) then it should have:

search/query - to search for the package and return descriptions, versions etc. e.g. cargo/npm/apt/dnf search
help - access to help file/documentation both for the package manager itself and for the package name given as an argument

If it is just for development then I assume it will need something to start a project. See: cabal init, stack new, cargo new/init, npm init.
And would also need the basic commands to add packages to the dependency file. See:
cargo add, npm install and the dev dependency equivalent flag e.g. --save-dev, -dev.
Then obviously commands to run, build, test etc. the package. I won't specify everything, you get the idea.

Thanks @Daeraxa !
There are some other issues about the CLI defined as well here, in case you want to take a look https://github.com/neohaskell/NeoHaskell/milestone/2

Right, I think I was hung up on the definition of "Package management" in a more general term, I've found lots of the things I mentioned in other sections now.


IOS - One extra space when delete content of the input field.

IOS

Type in a word in the input field (or type 'c')
Delete the word.

After delete the last letter (the first letter of the word), there is still one empty space left to delete. Noticed that on your main website too(http://react-autosuggest.js.org/), viewing on iphone.

set autoComplete="off" and autoCorrect="off" seems fix the issue for me

auto-correct is a non-standard attribute. Therefore, I think it should not be part of react-autosuggest.
You can always add it using inputProps.


Does not build Legacy XP

I am 99% sure you know about this, but there's no mention here.
Currently I can build PM3.6 fine, however Legacy XP boots to a black screen :(
Looking forward to the fix!

Would also love for it to support it!

Neither does it support Legacy TE.
:+1:

How have you guys gotten it to boot at all? Ive been trying to build a iso for my wiiu and all i keep getting are these errors. I tried this using the wii build for anyone wondering.

Boot Yes
Play No
This is probably a unrelated issue but the game starts for me (and maybe OP too i dont know) but comlains about a missing disk

I see, also i'm wondering if we'll hear back from the dev. Cause from the looks he's been inactive here for a while, hopefully there will be a fix.

Still has this problem ;(


HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

…region close requests

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m  2s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 41s
branch-1 passed

+1 :green_heart:
compile
0m 39s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 43s
branch-1 passed

+1 :green_heart:
shadedjars
3m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 39s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
2m 53s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 51s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 55s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 44s
the patch passed

-1 :x:
checkstyle
1m 39s
hbase-server: The patch generated 17 new + 279 unchanged - 2 fixed = 296 total (was 281)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
6m 12s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 37s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 53s
the patch passed with JDK v1.7.0_262

-1 :x:
findbugs
4m  8s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1 :x:
unit
139m 18s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

190m 31s

Reason
Tests

FindBugs
module:hbase-server

Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.hadoop.hbase.master.AssignmentManager.unassign(HRegionInfo, RegionState, int, ServerName, boolean, ServerName)  At AssignmentManager.java:may not be atomic in org.apache.hadoop.hbase.master.AssignmentManager.unassign(HRegionInfo, RegionState, int, ServerName, boolean, ServerName)  At AssignmentManager.java:[line 1982]

Failed junit tests
hadoop.hbase.client.TestAdmin2

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1755

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 854dba18eabe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1755/out/precommit/personality/provided.sh

git revision
branch-1 / 3235b56

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/artifact/out/diff-checkstyle-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/artifact/out/new-findbugs-hbase-server.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/testReport/

Max. process+thread count
4654 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apurtell  for review

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 48s
branch-1 passed

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 46s
branch-1 passed

+1 :green_heart:
shadedjars
3m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
3m  1s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 58s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
0m 41s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 46s
the patch passed

-1 :x:
checkstyle
1m 36s
hbase-server: The patch generated 17 new + 279 unchanged - 2 fixed = 296 total (was 281)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 30s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 29s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK v1.7.0_262

-1 :x:
findbugs
2m 52s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1 :x:
unit
128m 13s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

175m 54s

Reason
Tests

FindBugs
module:hbase-server

Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.hadoop.hbase.master.AssignmentManager.unassign(HRegionInfo, RegionState, int, ServerName, boolean, ServerName)  At AssignmentManager.java:may not be atomic in org.apache.hadoop.hbase.master.AssignmentManager.unassign(HRegionInfo, RegionState, int, ServerName, boolean, ServerName)  At AssignmentManager.java:[line 1982]

Failed junit tests
hadoop.hbase.client.TestClientScannerRPCTimeout

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1755

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 01f251a87674 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1755/out/precommit/personality/provided.sh

git revision
branch-1 / 3235b56

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/artifact/out/diff-checkstyle-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/artifact/out/new-findbugs-hbase-server.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/testReport/

Max. process+thread count
3874 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apurtell @bharathv  Incorporated the code review comments, please take a look
Also the Assignment Manager V2 already have the retry with back off logic for failed open/close requests (https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java#L360) , so the change is not needed for branch-2 and above.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 55s
branch-1 passed

+1 :green_heart:
compile
0m 40s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 51s
branch-1 passed

+1 :green_heart:
shadedjars
2m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
3m  2s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 59s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 53s
the patch passed

+1 :green_heart:
compile
0m 38s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 38s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 45s
the patch passed

-1 :x:
checkstyle
1m 40s
hbase-server: The patch generated 18 new + 245 unchanged - 36 fixed = 263 total (was 281)

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedjars
2m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 35s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 40s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
2m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
121m 25s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

163m 10s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1755

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 23c9fe6d5a60 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1755/out/precommit/personality/provided.sh

git revision
branch-1 / 61fa21e

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/2/artifact/out/diff-checkstyle-hbase-server.txt

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/2/artifact/out/whitespace-eol.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/2/testReport/

Max. process+thread count
4503 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@bharathv  pushed the latest changes incorporating review comments, please check

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 38s
branch-1 passed

+1 :green_heart:
compile
0m 55s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
1m  4s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
2m 25s
branch-1 passed

+1 :green_heart:
shadedjars
3m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 56s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 52s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
3m 42s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 39s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
2m 20s
hbase-server: The patch generated 18 new + 245 unchanged - 36 fixed = 263 total (was 281)

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedjars
4m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 58s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 39s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 53s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
3m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
131m 47s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

192m  1s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1755

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 256d68c4cf8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1755/out/precommit/personality/provided.sh

git revision
branch-1 / 61fa21e

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/3/artifact/out/diff-checkstyle-hbase-server.txt

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/3/artifact/out/whitespace-eol.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/3/testReport/

Max. process+thread count
4653 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 45s
branch-1 passed

+1 :green_heart:
compile
0m 40s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 43s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 48s
branch-1 passed

+1 :green_heart:
shadedjars
3m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
2m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 56s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 52s
the patch passed

+1 :green_heart:
compile
0m 41s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
checkstyle
1m 37s
hbase-server: The patch generated 0 new + 245 unchanged - 36 fixed = 245 total (was 281)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 36s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
2m 51s
the patch passed

_ Other Tests _

-1 :x:
unit
132m 20s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

180m  5s

Reason
Tests

Failed junit tests
hadoop.hbase.procedure.TestFailedProcCleanup

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1755

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 6acd71b1f34a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1755/out/precommit/personality/provided.sh

git revision
branch-1 / 61fa21e

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/4/testReport/

Max. process+thread count
4586 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1755/4/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


⚠ Bofrost.lu has degraded performance

In b2d11a2, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1479 ms

Resolved: Bofrost.lu performance has improved in efaa9a7.


Messages are not reported in Pulse

Reverb Version
1.3.1
Laravel Version
11.25.0
PHP Version
8.3.12
Description
Messages seem not to be recorded by Laravel Pulse for some reason. Connections are recorded fine. A record for a Reverb connection is added successfully to the pulse_aggregates table in my db. However, the db does not contain any records of type "reverb_message:received" or "reverb_message:sent" for some reason. I am using a separate db to log Pulse related data.
The sending of notifications from my backend to frontend (running on a subdomain) using Laravel Echo and Laravel Reverb works perfectly.
I've done some tracing in the source code. I can verify that the $this->pulse->record() method is called just fine in Laravel\Reverb\Pulse\Recorders#record after sending a notification to a user. Furthermore, I can verify that a new instance of Laravel\Pulse\Entry is created in Laravel\Pulse#record and that it is appended to the $this->entries variable of the pulse instance. I've logged the output of $entry->attributes() as well inside Laravel\Pulse#record and this contains output like:
array (
  'timestamp' =><PHONE_NUMBER>,
  'type' => 'reverb_message:sent',
  'key' => '######',
  'value' => NULL,
)

and
array (
  'timestamp' =><PHONE_NUMBER>,
  'type' => 'reverb_message:received',
  'key' => '######',
  'value' => NULL,
)

That's as far as I am able to trace what is happening.
Steps To Reproduce
Relevant content of config/pulse.php:
<?php
...
use Laravel\Reverb\Pulse\Recorders\ReverbConnections;
use Laravel\Reverb\Pulse\Recorders\ReverbMessages;

return [
    ...
    'recorders' => [
        ...
        ReverbConnections::class => [
            'sample_rate' => 1,
        ],

        ReverbMessages::class => [
            'sample_rate' => 1,
        ],
    ],
];

The config for supervisor:
[program:pulse]
process_name=%(program_name)s
command=/usr/local/bin/php /var/www/html/artisan pulse:check
autostart=true
autorestart=true
user=sail
redirect_stderr=true
stdout_logfile=/var/www/html/storage/logs/pulse.log
stopwaitsecs=3600

OK, Im going to close this again. I just tried to replicate this issue with a simplified set up (default Laravel Sail config) and there it is working just fine. My actual use case (i.e.  the case where it doesn't work) involves a more elaborate and customised Laravel Sail set up so I will need to do some more digging myself to figure out why it doesn't work there.
It does remain strange that the Reverb connections get recorded without a hitch, but the Reverb messages get lost somehow. I cannot think of a logical explanation for that... You'd think that either both or neither would get recorded due to some glitch in my set up.


[Feature]: Add docker support for arm/v7 for devices like raspberry pi

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Add docker support for arm/v7 for devices like raspberry pi
Creating network "appsmith_default" with the default driver
Pulling appsmith (index.docker.io/appsmith/appsmith-ce:)...
latest: Pulling from appsmith/appsmith-ce
ERROR: no matching manifest for linux/arm/v7 in the manifest list entries

Why should this be worked on?
the effort is not high and the gain is a full market of people using this devices

i will do it my self and just build it on my machine

running something like this
docker buildx build --platform linux/arm/v7 -t appsmith/appsmith-pi .
@Nikhil-Nandagopal any command to bootstrap the project for docker build ?
 => ERROR [11/22] COPY ./app/client/build editor/                                                                                0.0s
 => CACHED [12/22] COPY ./app/rts/package.json ./app/rts/dist/* rts/                                                                                0.0s
 => ERROR [13/22] COPY ./app/rts/node_modules rts/node_modules                                                                                0.0s
------
 > [11/22] COPY ./app/client/build editor/:
------
------
 > [13/22] COPY ./app/rts/node_modules rts/node_modules:
------
error: failed to solve: failed to compute cache key: "/app/rts/node_modules" not found: not found

if you need help i can help with multi stage build, it is more user friendly and safe (dependencies that build/install on the host, can cause issues when target architecture is different then the os)

workflow example

Hey @niradler, thank you for reporting this. We just pushed a fix that fixes the location of the http config file in the Docker image. Thank for offering to help, much appreciated 😃.

FYI - I manged to build the docker image on my Pi4 (aarch64) last week, runs fine.
The issue I had previously was MongoDB, which in current versions doesn't work on 32bit OSes anymore, after I upgraded my Pi to 64 bit bullseye things began to work. (with some tinkering with the build environment).

@niradler could you check and see if this issue still persists for you?

@Nikhil-Nandagopal it would be nice though if you guys could provide an arm/multiarch image on docker hub, though?

Hey @arminus, the image is indeed published for arm architecture, but for 64bit only, at https://hub.docker.com/repository/docker/appsmith/appsmith-ce/tags?page=1&ordering=last_updated. Is that what you're looking for?


login not happening after adding external login provider

Adding external login provider (facebook/google) cause issue with login process. I've added external login from QuickStart4_ExternalAuthentication sample.
app.UseCookieAuthentication(new CookieAuthenticationOptions
           {
               AuthenticationScheme = IdentityServerConstants.ExternalCookieAuthenticationScheme,

               AutomaticAuthenticate = false,
               AutomaticChallenge = false
           });
           //configure google authentication. http://docs.identityserver.io/en/release/quickstarts/4_external_authentication.html#adding-google-support
           app.UseGoogleAuthentication(new GoogleOptions
           {
               AuthenticationScheme = "Google",
               DisplayName = "Google",
               SignInScheme = IdentityServerConstants.ExternalCookieAuthenticationScheme,

               ClientId = "434483408261-55tc8n0cs4ff1fe21ea8df2o443v2iuc.apps.googleusercontent.com",
               ClientSecret = "3gcoTrEDPPJ0ukn_aYYT6PWo"
           });

After logging with Google account, user is redirected again to login page for the very first time. Clicking on Google button again, redirects to AccessDenied page.

Here's the reference sample:
https://github.com/IdentityServer/IdentityServer4.Samples/tree/dev/Quickstarts/4_ImplicitFlowAuthenticationWithExternal
does this work for you?

@leastprivilege Yes that sample alone works for me. However I need aspnet identity with external providers. So I get the code form that sample and configure the aspnet identity sample with google login. Local login is working fine. Issue is with Google login.
System initiate the login process redirects to Google auth page, Ask for user permission. After allowing the permissions, it again redirects back to login page.

I think is the issue is related to https://github.com/aspnet/Templates/issues/686

I'm not sure if it optimal solution, however this thing helps me out. @leastprivilege is this a good way to go?

If you're using ASP.NET Identity, then yes you need to use their constants for their cookies.

Do I need to use their constants in both, CookieAuthenticationOptions and GoogleOptions ? Or only with GoogleOptions ?

If you're using ASP.NET Identity, then you're using all of their cookies (and IdentityServer does too). So in short, use all of theirs.

Thanks @brockallen and @leastprivilege . I think there should be a note in startup.cs class, saying if you want to use external providers, use AuthenticationScheme used by aspnet identity itself. It will save a lot of efforts and time for those who want to use this template as base and write external provider mixed with it.

I added google to the ASP.NET Identity quickstart sample.

My guess, the problem is not about cookie name.
Try to login (with user and password), after this, manage account and add Facebook or Google external Account... Then remove it.. and after this try to add again.. Will be redirect to access denied.  I think the problem is the cookie "external" that was not removed at the first login or link. It is just removed if you do logoff..
The problem, is that you may not accept facebook authentication or else give some error, and the cookie will stay there. If the "Identity.External" cookie is there, probably every time when you try to authenticated externally, it will be redirected to Access Denied.

I work with Google Authentication but after sign-in google account it call back link:
http://localhost:5000/signin-google?state=xxxxx and throw error
I just follow the link:
https://identityserver4.readthedocs.io/en/release/quickstarts/4_external_authentication.html#refexternalauthenticationquickstart
How can I fix it...?


Added on click event and updated corresponding documentation.

Added a very simple on-click event that was modeled after the on-hover event already native to the code.  A consuming user of EventDrops can bind to the on-click event and process logic on execution.

Great, thanks!


refactor(examples): DetailedCart

Related issue

Closes #937
Closes #936
Scope of work

fix SfButton for --text with color modifier
changed transition in SfCircleIcon and change size to px
use 'sf-circle-icon--small' in SfCollectedProduct
fix for remove button slot in SfCollectedProduct
updated stories in SfCollectedProduct
add --detailed to SfCollectedProduct
add new example page DetailedCart
adjusted page to design

Screenshots of visual changes

Checklist

[x] No commented blocks of code left
[x] Run tests and docs
[ ] Self code-reviewed

@martaradziszewska please add notification and adjust spacing between price and property


Fixing vertical alignment in Alert

https://design-system-git-fix-link-alignment-strapijs.vercel.app/?path=/story/alert--base

Looks better, thank you :) Can we maybe central align the external link icon?

Looks better, thank you :) Can we maybe central align the external link icon?

because of the two different font-size, line-heights and the wrapping behaviour expected when being on a bigger Alert, I can't manage to make these aligned 100%. I'm still having those 3px difference somewhere

cc @maevalienard

I don't see any difference?

cc @maevalienard


Spaces in .env.dist file

When building site via Yii 2 starter kit on docker on windows - issuing command composer run-script docker:build, the build fails with the message
Output:

cp .env.dist .env
docker-compose up --force-recreate -d
In file ..env: environment variable name 'YII_DEBUG       ' may not contains whitespace.
Script docker-compose up --force-recreate -d handling the docker:start event returned with error code 1
Script @docker:start was called via docker:buil

Reason
The default .env.dist file in the root directory contains environmental variables formatted/aligned with spaces, and the docker fails to parse them.
Workaround
replace all the space characters in the environmental variables file .env.dist with no character, eg. in Notepad++ editor

What is "Yii 2 starter kit"? Which .env.dist are you talking about? Would you please post a link to the file in question?

wrong repo


Introduction - Martin Prpič (Red Hat)

@mprpic Welcome to the WG!

This PR has been open for a week, I think it is ready to land.


Update from SDK 2.0.0RC3 to 2.0.0RC5

Hi,
I'm the owner of the Azure SDK for Python at Microsoft. We just released the new 2.0.0RC4 with a little breaking change on the client creation (The XXXConfiguration classes no longer exist). You can find the release note with this change here:
https://github.com/Azure/azure-sdk-for-python/releases/tag/v2.0.0rc4
This is the code which needs to be modified to update from 2.0.0RC3 to 2.0.0RC4.
I will update module-extra as well asap.
Tell me if you need something else or if I can help.
Thank you!

Please hold this for now. I'm talking to the module owner on how to best go about this, as the new current version of the azure python module doesn't seem to honor module "version"

Hi @trondhindenes
I will update this PR to incorporate RC5. There is a tiny modification, because we moved to the latest REST API for storage (in the get_blob_client method). I will do it tomorrow asap.
Thank you,

@trondhindenes @nitzmahone This last commit should allow to move to 2.0.0RC5. Please let me know if you some difficulties on this.
Thanks!

@nitzmahone we should get this incorporated into the ansible project so that we can get back to versioned python modules. How do we proceed?

I should probably make this repo private since we're not doing development here anymore, lest more people trip over it. I'd just delete it, but the tests are still here (and have probably fallen into disrepair)- I don't want to bring those into the Ansible repo until we've got a better way for anyone to run them...
I'd already made the necessary changes to get rc4 working in https://github.com/ansible/ansible-modules-core/ (I remembered seeing an email notification about this PR, but couldn't find it on the core repo), so just need to bring over the new Storage changes.
@lmazuel - I'm happy to patch these over to the Ansible repo manually, but they'll have my name on them. Let me know if you're OK with that...

@nitzmahone no problem, you can create yourself the commits. Just tell me where I should do my PR the next time if it's not here :)

The Azure modules now reside in the main Ansible repository here:
https://github.com/ansible/ansible/tree/devel/lib/ansible/modules/cloud/azure/


0.25.5 and above, google-bigtable-v2 feature does not compile

Hey,
Thanks for your amazing work!
Recently I've found out when trying to upgrade that switching from 0.25.4 to any above version will cause errors when google-bigtable-v2 feature is enabled.
Minimal repro setup for that issue:
/
  /src
    /main.rs
  /Cargo.toml

Cargo.toml
[package]
name = "minimum_repro"
version = "0.1.0"

[dependencies]
gcloud-sdk = { version = "0.25.8", features = ["google-bigtable-v2"] }

> cargo check
    Checking gcloud-sdk v0.25.8
error[E0412]: cannot find type `Date` in module `super::super::super::r#type`
   --> /Users/kacpertlusty/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gcloud-sdk-0.25.8/src/../genproto/google.bigtable.v2.rs:462:48
    |
462 |         DateValue(super::super::super::r#type::Date),
    |                                                ^^^^ not found in `super::super::super::r#type`
    |
help: consider importing one of these structs
    |
426 +     use crate::google::bigtable::v2::r#type::Date;
    |
426 +     use chrono::Date;
    |
help: if you import `Date`, refer to it directly
    |
462 -         DateValue(super::super::super::r#type::Date),
462 +         DateValue(Date),
    |

For more information about this error, try `rustc --explain E0412`.
error: could not compile `gcloud-sdk` (lib) due to 1 previous error

I've tried that with 2015 and 2021 Rust edition.
> rustc --version
rustc 1.82.0 (f6e511eec 2024-10-15)
> cargo --version
cargo 1.82.0 (8f40fc59f 2024-08-21)

Hey, sometimes dependencies between google features break, thanks for reporting it!
I think I've fixed this in #169
Please try to update your dependency in Cargo.yaml directly to a master branch (or commit hash) on GitHub and let me know if it helps in your case.
If it works it will be released at the beginning of next month (which is a common cycle that I try to support).

I confirm, it works like a charm, thanks for so quick answer!