reactive extension compatibility

Do you have support for Rx, or I misunderstand the observer logic?

There’s no built-in extension for any particular reactive framework, though certainly Siesta’s architecture would fit quite naturally into a reactive project. Siesta’s built-in observer logic is sort of “reactive lite,” and gives some of the code-simplifying benefits of reactive programming without having to go fully Rx.
I’d love to add extensions for ReactiveCocoa and RxSwift to Siesta, either as examples in the docs or as optional plugins. Send a PR or a gist!

If there any updates? I would like to use ReactiveCocoa with Siesta!

reactivecocoa support would be amazing

I’m not actively working on it — my priority is stabilizing the API so we can cut a 1.0 release — but this is “help wanted” issue so I’d welcome a PR!
If anybody gets a plugin working and wants to submit it:

Put the plugin code in Extensions/ReactiveCocoa.
Add your code to the iOS & macOS  test targets in Xcode (but not the core project targets).
Add ReactiveCocoa to Cartfile.private.
Write specs.
Add a new subspec to Siesta.podspec. (You can use the Alamofire one as an example.)

I'm thinking about how this could be implemented, shall we need to return a hot signal for addObserver methods? what happens with request methods and one time hooks? Also resources can be released in cases of memory pressure, what happens to hot signals then?
What are the cases that need to be handled at minimum for this to work properly?

Here are some quick initial thoughts, which are probably have wrong so take them with a grain of salt:

Resources and requests should both be signal producers. They handle two different cases: one for when you want the latest data wherever it came from, and the other for observing a specific request.
Resource signals use addObserver. Request signals use onCompletion.
Resources only get released if nobody is using them. An active signal should retain a resource as long as it has subscribers … however that works in ReactiveCocoa.

For RxSwift
import Siesta
import RxSwift

extension Request {

  var rx_success: Observable<Bool> {

    return Observable.create { o in

      self.onCompletion { response in

        switch response {
        case .Success(_):
          o.onNext(true)

        case .Failure(_):
          o.onNext(false)
        }
        o.onCompleted()
      }
      return AnonymousDisposable { self.cancel() }
    }
  }

  var rx_response: Observable<Siesta.Response> {

    return Observable.create { o in

      self.onCompletion { response in
        o.onNext(response)
        o.onCompleted()
      }

      return AnonymousDisposable { self.cancel() }
    }
  }

  var rx_entity: Observable<Siesta.Entity> {

    return Observable.create { o in

      self.onCompletion { response in

        switch response {
        case .Success(let entity):
          o.onNext(entity)

        case .Failure(let error):
          o.onError(error)
        }
        o.onCompleted()
      }
      return AnonymousDisposable { self.cancel() }
    }
  }
}

Thanks for this, @VDKA! Is it similarly easy to make an extension for Resource? I feel like that's where the real reactive payoff would be — but I don’t know enough about the lifecycle of an Observable to know whether it would cause a Resource to be retained longer than it ought to be.

@pcantrell I'm thinking about implementing at least some RAC wrapper for the library, but there is one issue I'm not certain about. In RAC a signal is terminated when an error event occurs, however the ephemeral nature of the library requires the subscription to continue even if there is an error. I can think of a few ways to overcome this:

Do away with RAC error handling mechanism and send the Resource and ResourceEvent parameters as next: values, even though there may be some error.
Have a signal of signals that converts each resourceChanged() calls to signals that need to be subscribed by the observer each time, and if the event in the inner signal is an error, then forward it to error: instead of next:.
Make latestData, latestError, and isLoading seperate signals and handle each in separate blocks.
...?

If I can find a neat way to implement the bindings, this will be my first open source contribution so please feel free to nurture me with criticism. :)

@akaralar: I’d happily welcome a PR for this, and would be very happy to guide you through any Siesta-related points of uncertainty! Once you have some code worth sharing, even if it’s incomplete, put your work on a reactivecocoa branch in your own fork of the project and go ahead and open a pull request off that branch.
The solution to the error problem is clear. (Or at least I think it’s clear, which means I probably don’t understand it. Beware the obvious!)
A resource-centric signal would take a snapshot of the several Resource properties that change over time, and publish that snapshot. Here’s a sketch:
public struct ResourceState  // Crucial that it is a struct!
    {
    public var data: Entity?
    public var error: Error?
    public var isLoading, isRequesting: Bool
    }

public extension Resource
    {
    var state: ResourceState
        {
        return ResourceState(
            data: latestData,
            error: latestError,
            isLoading: isLoading,
            isRequesting: isRequesting)
        }
    }

A signal attached to a resource would expose only that ResourceState struct — not the resource itself. (The struct is immutable & threadsafe, or at least as threadsafe as the entity’s content. A Resource is neither immutable nor threadsafe.)
It’s probably smart to attach the content convenience accessors to that, so that you have typedContent():
extension ResourceState: TypedContentAccessors
    {
    public var entityForTypedContentAccessors: Entity?
        { return data }
    }

Or better yet — and here I’m going out on a limb — the standalone ResourceState struct avoids the limitations of Swift that prevented Siesta from having a fully generic Resource<T>, so you could probably make this work:
public struct ResourceState<T>
    {
    public var content: T?
    public var error: Error?
    public var isLoading, isRequesting: Bool
    }

public extension Resource
    {
    func stateSnapshot<T>() -> ResourceState<T>
        {
        let data: T? = latestData?.typedContent()
        let contentTypeError: Error? =
            (latestData != nil && data == nil)
                ? Siesta.Error(
                    userMessage: "The server return an unexpected response type",
                    cause: Error.Cause.WrongContentType())
                : nil

        return ResourceState(
            content: nil,
            error: latestError ?? contentTypeError,
            isLoading: isLoading,
            isRequesting: isRequesting)
        }
    }

extension Siesta.Error.Cause
    {
    public struct WrongContentType: ErrorType { }
    }

Too much of a brain dump? Let me know if that makes sense.

@pcantrell Thanks for the detailed explanation! Yeah that makes sense. Great food for thought :) Let me see if I can get something working and send a PR.

Closing this thanks to @akaralar’s contribution — but I’d gladly welcome an RxSwift extension as well.

PAUL!


Troubleshooting displaying bytes in the wrong hexadecimal number in certain cases.

Problems occur when byte values are 12, 14, and 15.

Actually, I think you should be able to just fix the fallback case and remove the special cases for 0..=8 and the ones that you're adding. You can do format!("\\x{:02x}", i) to ensure that the hex form is padded to 2 digits if it isn't already 2 digits long

OK, I fixed it.


Fix The stack can't be placed error for BLtruck

The error is very rare (less than 1 for 1000 instances).

I fixed a mistake: when placing a stack, I forgot to provide coveredcorners function with the right orientation of the stack.


Slow install time on Arch Linux

Installing on Arch linux, I downloaded using yay -Sy haskell-ide-engine-git, but the installation is taking a very long time. In total the install took about 110 minutes (!!!) with ~16 of those used to download the repo.
In the background I ran a speedtest and it reported 37Mb/s, so that was not a factor, though the git download speed was about 100 KiB/s (typical for a VCS).
Part of the problem probably lies in the fact it reported downloading 107MiB of repo data, which means it downloads the whole repo and not just shallow clone. Researching online shows this is a problem with pkgbuild/makepkg, so im not sure fixing this is possible.
The compile time for the project itself on a fresh system is incredibly long too and I hope we can reduce it.

You sure it didn't compile just every possible version of hie?

This is a known problem. The arch package installs hie for every ghc version from source, which Tales a very long time. Ideally, the binaries would be provided as a package on the aur, but this is currently difficult

You can specify the specific hie corresponding to specific ghc version.
For example, if your ghc version is 8.6.3.
git clone https://github.com/haskell/haskell-ide-engine --recursive
cd haskell-ide-engine
make hie-8.6.3
make build-doc-8.6.3

There should at least be a warning for the arch linux installation. I ran the install and left it running for >1h and came back and it's still running. My CPU has been at 100% utilization the entire time.
Also, couldn't there be a separate Arch package for each version?

There is a warning in the readme of this repository. Correctly packaging and shipping hie has turned out to be quite difficult in the past and the current package on the AUR is not the best solution either.


db2_execute call fails if parameterContainer returns empty array

https://github.com/zendframework/zend-db/blob/58271ef881bb310b0c029d1cfd17d8c35d4aa915/src/Adapter/Driver/IbmDb2/Statement.php#L236
db2_execute() will fail with error "db2_execute(): Param count incorrect" when an empty array is provided as the 2nd argument.
This makes calling DB2 stored procedures impossible, among other things.

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/28.


False negative for .is_valid()

>>> Language.get("cu-Cyrs").is_valid()
False

Expected to return True. Fails on the Cyrs script tag
Context (wikipedia):
cu: Old Church Slavonic
Cyrs: Cyrillic (Old Church Slavonic variant)
Both these tags are part of https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry

You're right -- langcodes can even describe it:
>>> langcodes.get('cu-Cyrs').describe()
{'language': 'Church Slavic', 'script': 'Old Church Slavonic Cyrillic'}

I'll look into whether the "validity" file I got from CLDR was wrong, or whether I parsed it wrong.

A few scripts are just plain missing from CLDR's validity.xml, it seems.
I didn't want to mess with the CLDR part in this release. Is it okay if I save this for a version based on CLDR v40 when it's released?

Fixed in version 3.3.


Add code style and Actions pipeline for scripts

We already have checks for spelling errors, but would be also good to add checks for code style. Also would be good to have these checks on the commit hooks or in the Github actions.
Cc: @andreriesco

This was partially covered by #108

I'm closing this one because we added some, is not perfect but we should open another tickets for handle this.


Feat: add RIP-7212 to the list of precompiles Cairo1Helpers module

Add the precompiled contracts p256verify to the list of precompiled contracts at address 0x0b following this implementation : https://github.com/ethereum/go-ethereum/pull/27540 .
I have chosen the 0x0b instead of 0x100 because of the amount of lines that the second one would have added to the precompiles.cairo and I am currently unaware of a precompiled contract at address 0x0b.
Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Resolves: #755
What is the new behavior?

p256verify is now added to the list of precompiled contract at address 0x0b

Does this introduce a breaking change?

[ ] Yes
[X] No

This change is

I have chosen the 0x0b instead of 0x100 because of the amount of lines that the second one would have added to the precompiles.cairo and I am currently unaware of a precompiled contract at address 0x0b.

You can just add a specific if / else before the match table handling this specific case for 0x100. This should not be an issue when deciding a precompile address. Given that it seems a consensus was found on using 0x100 - 0x1ff for rollup precompiles, let's go with 0x100

Chose 0x100 as precompiled address
Added length check ( nice catch )
Added tests concerning length check
Removed setup_contracts for unit tests

Corrected precompiled address range

some tests are failing, can you verify is 256 or 0x100 is an address used in tests?

Alright, my bad, I missed those since I struggle running every tests and didn't notice it on github.
But indeed, some tests were deploying on the 0x100 address which created conflicts. I changed them to deploy their test contract on 0x101.

Alright, my bad, I missed those since I struggle running every tests and didn't notice it on github.
But indeed, some tests were deploying on the 0x100 address which created conflicts. I changed them to deploy their test contract on 0x101.

0x101 is still too "close" we should ideally have a random value like 0xabfa740ccd

You're right ! 0xabfa740ccd it is then !


use the new wildfly maven plugin core API for deploy/undeploy

Need to wait for a couple things to be fixed in the wildfly plugin core API before we can merge.
Once version 1.1.0.Alpha10 is released, we'll need to upgrade parent-pom to reference it, then we need to bump up the agent's parent to use that parent pom version, then we should be able to merge.
Right now, itests for this branch will fail due to deployment enablement not working due to bug in maven plugin core api.

One parent pom version 45 is released (which should define maven plugin version property 1.1.0.Alpha10) this should be able to go green and then we can merge

This is building locally on my box, however, for some reason travis cannot download the new 1.1.0.Alpha10 release of the maven plugin core, even after I purged travis' cache. I don't know what the problem is, but it is a travis issue.

LGTM


How Can I Access The Dashboard?

At which url do I access the dashboard? "Admin" or "dashboard" don't do it.

Goto: {base_url}/auth/login and use following credentials
User: admin
Pass: admin123

The credentials worked for my first login. Then gave me this error:
Whoops! Error
El usuario o la contraseña no son correctos

The project will restart soon we hope to have your support you can participate with your ideas in trello and slack
Trello -> https://trello.com/b/dv9fqFK2/lms-laravel
Slack -> https://join.slack.com/t/lmslaravel/shared_invite/enQtMzkzNTUxNzAzMTEwLTVkNDBmZmU1YjEzMWIxNTk5Y2FiOGYyODYxNmFhYjgwYzQ5MjRhOWViOTRkZWM3ZjczOTcxMzVlOTU5YzdiNGI


Electrical Heating/HVAC issue

I hope this is not already known issue. Getting these messages to the log:
Logger: custom_components.nhc2.nhccoco.coco
Source: custom_components/nhc2/nhccoco/coco.py:119
Integration: Niko Home Control II ([documentation](https://github.com/joleys/niko-home-control-II/blob/master/README.md), [issues](https://github.com/joleys/niko-home-control-II/issues))
First occurred: 14:54:58 (9 occurrences)
Last logged: 14:54:58

Class CocoElectricalheatingAction not found module 'custom_components.nhc2.nhccoco.coco' has no attribute 'CocoElectricalheatingAction', device: [{'BasicState': 'Off'}]

Logger: homeassistant.components.climate
Source: custom_components/nhc2/entities/generic_hvac_climate.py:114
Integration: Climate ([documentation](https://www.home-assistant.io/integrations/climate), [issues](https://github.com/home-assistant/core/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+climate%22))
First occurred: 14:54:59 (2 occurrences)
Last logged: 14:54:59

Error adding entities for domain climate with platform nhc2
Error while setting up nhc2 platform for climate
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 504, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 700, in _async_add_entity
    capabilities=entity.capability_attributes,
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 282, in capability_attributes
    data[ATTR_PRESET_MODES] = self.preset_modes
                              ^^^^^^^^^^^^^^^^^
  File "/config/custom_components/nhc2/entities/generic_hvac_climate.py", line 114, in preset_modes
    for program in self._device.possible_programs:
TypeError: 'NoneType' object is not iterable

@sgi3200 can you provide me with a device list please? See: https://github.com/joleys/niko-home-control-II#i-need-to-see-the-device-list
Can you also tell which HVAC system is linked to your Niko Home Control system?

thank you Tijs, all required data sent by email, in the case you will find something else what I could help with, just let me know

Thx. I will try to have a look later this week.

@sgi3200 I think the changes in https://github.com/joleys/niko-home-control-II/pull/81 should resolve your issues. And you will see a new device "AC".
Are you able to do these changes manually in your local Home Assistant installation, and confirm if it is working?
But I need to take a better look at the warning Class CocoElectricalheatingAction not found module 'custom_components.nhc2.nhccoco.coco' has no attribute 'CocoElectricalheatingAction', device: [{'BasicState': 'Off'}] as that is still present.

many thanks @tijsverkoyen, changes to those 2 files applied, seems it really helped, no record in the logfile so far related to generic_hvac device / generic_hvac_climate entity after HA restarted

@sgi3200 I have another PR (https://github.com/joleys/niko-home-control-II/pull/82) which adds support for Electralheating Actions.
I suspect (as I don't own such a device) that you will be able to use the button to activate your electrical heaters from within Home Assistant.
If you apply these changes manually and would be able to test that would be very kind!

@tijsverkoyen thank you again, Tijs, you are really fast ;-) changes applied, it helped to resolve the issue with unecessary records in HA logfile but I think this topic requires more attention ;-)
"electricalheating" device based on mqtt devices list has 3 basic states: On, Off, Triggered.
It seems Niko developers let generic heating/cooling device depending on the vendor/partner based on the documentation (https://mynikohomecontrol.niko.eu/Content/hobbyapi/documentation.pdf), pages 70-71
Heating/cooling module has a H/C button for manul triggering heating or cooling:
https://guide.niko.eu/display/HGNHC2V2/Heating+or+cooling+module
so, implementation of button is aboslutely correct, even though I think it won't be used in real life.
Reagarding to binary sensor, maybe it would by better to create a sensor with state defined based on basic state of the physical device (on/off/triggered). I think the state "triggered" is handled by a thermostat, once there is a condition/demand for heating that has to be started (means room temperature is lower than required) a thermostat sends a signal to electrical heating and the basic state of "electricalheating" is changed to "triggered". But this is something what I have to check and confirm.
Another issue I have just found it the thermostat device. Available programs predefined by NHC thermostat are: Day, Night, Eco, Off, Cool, Prog1, Prog2, Prog3 but the integration entity provides the following attributes: Comfort, Sleep, Eco, Off, Cool, Prog1, Prog2, Prog3. I would also add the "demand" as an attribute for thermostat entity with the following options: Heating, Cooling, None.
I have to find a free time to check (thru NodeRed mqtt) what exactly I am getting from hobby/control/devices/evt topic once a heating is triggered by a related thermostat. Maybe this weekend I will spend some time on this and will contact you once I get some usable results.

Changes applied, it helped to resolve the issue with unecessary records in HA logfile but I think this topic requires more attention ;-)
"electricalheating" device based on mqtt devices list has 3 basic states: On, Off, Triggered.

That is correct, but the value Triggered is not an actual status, it will never have that status. It is only used to "trigger" the BasicState property of the device.
It works the same way as the NHC Mood Action, see page 53.

It seems Niko developers let generic heating/cooling device depending on the vendor/partner based on the documentation (https://mynikohomecontrol.niko.eu/Content/hobbyapi/documentation.pdf), pages 70-71
Heating/cooling module has a H/C button for manul triggering heating or cooling:
https://guide.niko.eu/display/HGNHC2V2/Heating+or+cooling+module
so, implementation of button is aboslutely correct, even though I think it won't be used in real life.

I think you are confusing some devices. The ne Electricalheating (Action) is not the "Generic Heating/Cooling Implementation"

Reagarding to binary sensor, maybe it would by better to create a sensor with state defined based on basic state of the physical device (on/off/triggered). I think the state "triggered" is handled by a thermostat, once there is a condition/demand for heating that has to be started (means room temperature is lower than required) a thermostat sends a signal to electrical heating and the basic state of "electricalheating" is changed to "triggered". But this is something what I have to check and confirm.

See above.

Another issue I have just found it the thermostat device. Available programs predefined by NHC thermostat are: Day, Night, Eco, Off, Cool, Prog1, Prog2, Prog3 but the integration entity provides the following attributes: Comfort, Sleep, Eco, Off, Cool, Prog1, Prog2, Prog3. I would also add the "demand" as an attribute for thermostat entity with the following options: Heating, Cooling, None.
I have to find a free time to check (thru NodeRed mqtt) what exactly I am getting from hobby/control/devices/evt topic once a heating is triggered by a related thermostat. Maybe this weekend I will spend some time on this and will contact you once I get some usable results.

Can you create another issue for this part please, but be aware that some programs are mapped/translated to the ones that are used by HomeAssistant, see https://developers.home-assistant.io/docs/core/entity/climate/#presets and https://github.com/joleys/niko-home-control-II/blob/master/custom_components/nhc2/entities/generic_hvac_climate.py#L119C48-L119C48

@sgi3200 I releases v3.1.2 which includes the bug fix. And also v3.2.0 which adds the support for Electrical Heating Action
If your are using HACS they will appear soon as an update. You can install it, it will overwrite your local changes.


Avoid Random.id() on addFile

I think its reasonable to switch from Random.id() to _id as a part of the insert callback.
https://github.com/VeliovGroup/Meteor-Files/blob/master/files.coffee#L1412
Moreover, it should be noted that fileRef in the callback of addFile is not the inserted document like described in https://github.com/VeliovGroup/Meteor-Files/blob/dd59d886db69e8d74db3ebb5e1c7bde74f0b64c9/docs/addFile.md

callback {Function} - Triggered after new record is added to Collection. With error, and fileRef, where fileRef is a new record from DB

Instead it's a predicted document, as data is not fetched from the database after insert. This may also fail on the next calls like proceedAfterUpload. We subclass collection.insert and add some extra fields like timestamps, in those cases we findOne(fileRef._id) to fetch the real document) and pass it to proceedAfterUpload on callback.

Hello @menelike ,
Updated in https://github.com/VeliovGroup/Meteor-Files/commit/81856738b0650c009c59fc22afed6f06a26f5505 an in https://github.com/VeliovGroup/Meteor-Files/commit/6e0b3a994b33519bed4c5be6725ed76a06b31c79

@dr-dimitru works like a charm. Thanks a lot, like always, great work/support!

Published as v1.7.6


edges_to_arcs naming convention

currently, the graphic-theoretic edges to network arcs crosswalk is named edges_to_arcs. However, the actual data structure is keyed on arcs with the values being graph edges.

[x] rename arcs_to_edges

Resolved in #228


hostPort get port but pod never leaves scheduling

Converting a home server with a public IP from docker-compose to microk8s and ran into 2 issues.
1) pod with nginx never start
2) IP port not released when deployment deleted. Must stop microk8s to release.
Note nothing else running. Microk8s installed not in a VM but directly on ubuntu 18.
How to reproduce sequence:
the only deployment
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx
spec:
  replicas: 1
  selector:
    matchLabels:
      app: nginx
  strategy:
    type: Recreate
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
        - image: localhost:32000/nginx:mainline-alpine
          name: nginx
          ports:
            - containerPort: 80
              hostPort: 80
            - containerPort: 443
              hostPort: 443

microk8s kubectl apply -f
NAME                     READY   STATUS    RESTARTS   AGE   IP       NODE     NOMINATED NODE   READINESS GATES
nginx-75f9b56945-zjzd2   0/1     Pending   0          18s   <none>   <none>   <none>           <none>

a long time later
microk8s kubectl  delete -f <the above file>
then try to relaunch my docker-compose and it fails with
ERROR: for nginx  Cannot start service nginx: driver failed programming external connectivity on endpoint production_hmt_nginx_1 (bd2968f015acf9d7fda0f74b2b19858663fa41eb5eefa6b8ff522c147f61a1cf): Error starting userland proxy: listen tcp <IP_ADDRESS>:443: bind: address already in use
so looks like microk8s did take the port.
microk8s stop
then docker-compose can take the port (ie: microk8s released port only when stop command issued).
took down docker-compose, repeated the above, same behavior.
btw, the Microk8s installation was super simple and fast. Good job.

inspection-report-20201122_193601.tar.gz

Looking at github, I see microk8s ingress also uses hostPort.
Ingress also leaks the hostPort and never gives it back (but it completes scheduling and route traffic to the service).
First the yaml file for the ingress experiment.
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: http-ingress
spec:
  rules:
  - http:
      paths:
      - path: /
        backend:
          serviceName: express-service
          servicePort: 3000

A warning when I apply the ingress
microk8s kubectl apply -f jjg_ingress.yaml
Warning: networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
ingress.networking.k8s.io/http-ingress created
john@john-trx40-designare:~/Documents/GitHub/help-me-transcribe/k8s/production$ microk8s kubectl get services
NAME              TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)    AGE
kubernetes        ClusterIP   <IP_ADDRESS>   <none>        443/TCP    26h
express-service   ClusterIP   None           <none>        3000/TCP   3m18s

Ingress is reported, but no indication of the port
john@john-trx40-designare:~/Documents/GitHub/help-me-transcribe/k8s/production$ microk8s kubectl get ingress
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
NAME           CLASS    HOSTS   ADDRESS   PORTS   AGE
http-ingress   <none>   *                 80      49s

Delete the ingress
john@john-trx40-designare:~/Documents/GitHub/help-me-transcribe/k8s/production$ microk8s kubectl delete -f jjg_ingress.yaml
Warning: networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
ingress.networking.k8s.io "http-ingress" deleted

confirm ingress is gone
john@john-trx40-designare:~/Documents/GitHub/help-me-transcribe/k8s/production$ microk8s kubectl get ingress
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
No resources found in default namespace.

... 10 minutes later
Now try docker-compose ... port still held by microk8s
Starting production_hmt_py_transcribe_service_1 ... done
426257439daa874a27808eb92f98b87a218328dde): Error starting userland proxy: listen tcp <IP_ADDRESS>:443: bind: address already in use

ERROR: for nginx  Cannot start service nginx: driver failed programming external connectivity on endpoint production_hmt_nginx_1 (6dbd97ef27f73f563613cba426257439daa874a27808eb92f98b87a218328dde): Error starting userland proxy: listen tcp <IP_ADDRESS>:443: bind: address already in use
ERROR: Encountered errors while bringing up the project.

Reverify ingress is off and services too
microk8s kubectl get ingress
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
No resources found in default namespace.
john@john-trx40-designare:~/Documents/GitHub/help-me-transcribe/k8s/production$ microk8s kubectl get pos
error: the server doesn't have a resource type "pos"

docker still failing
212a800e2980b0c16cf1f8fdff4bea74440f548d5): Error starting userland proxy: listen tcp <IP_ADDRESS>:443: bind: address already in use

ERROR: for nginx  Cannot start service nginx: driver failed programming external connectivity on endpoint production_hmt_nginx_1 (d09fffc20318446bb46a0b7212a800e2980b0c16cf1f8fdff4bea74440f548d5): Error starting userland proxy: listen tcp <IP_ADDRESS>:443: bind: address already in use
ERROR: Encountered errors while bringing up the project.

microk8s stop
[sudo] password for john:
Stopped.
Docker-compose now can run and allocate ports 80 and 443

The ingress is defined as a DaemonSet. Meaning it runs on all nodes in the cluster.  As you have seen it will use the ports 80 and 443.
Ingress are meant to be used to access into your services / pods from outside the cluster.
If you use hostPort in your container definition make sure you dont run into conflict with any ports in the host.

I found the problem with hostPort while not using ingress.  Then while exploring for a workaround, I found a similar issue with Ingress while not using hostPort.

have not seen for a long time


Time cost on Training

Hey,your job is excellent!Recently,I have a task which contains 2000+ classes and 5.6 millions images about cars, I had tried to train BCNN on my dataset, but it spent too much time on convergence of network.I did not get answer after reading your paper. Could you tell me about how long you had trained NTS-Net using CUB dataset on your 4 GPUs machine?Thank you.

You will need about 10 hours to train 100 epoch on CUB dataset using 4 Titan X, and 100 epoch is enough for CUB.


Pipeline visualizer

The pipelines should have a custom visualizer which:

enforces only one connection per input port
visualizes the inputs/outputs as ports
specifies the valid next operations given the current one (like the architectures but this will need to take care of upcasting data types)

The ports could actually be hidden until the node is selected and explicitly expanded... Would the user want to view the names of input/outputs of multiple operations at once?


Cursor vanishes after opening inventory and doing things

Nothing useful in the log except the following:
Running a couple of mods but nothing that touches the cursor.
[00:22:20.431] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.446] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.464] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.480] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.505] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.520] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.547] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.563] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.580] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.596] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.613] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.630] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.
[00:22:20.647] [Main Thread/ERROR] [OptimizedCursor]: SDL_SetCursor threw an error: CreateIconIndirect(): The parameter is incorrect.

Appears to be fixed with the rewritten version. Which isnt out yet but can be tested on the discord.

Should be fixed in commit 87d94ecd5abc551cd64eb9ea48cc02f036243f02.


Unexpected token E in JSON at position 0

We are facing the below error on using @electron/notarize v2.3.0

Not sure, what's the actual issue here. We are providing all the required params to the notarize function:

Having the same issue

This is the same issue as #177.

Same here

Looks like it is trying to parse a JSON that is not actually a JSON. notarytool returns a string instead of JSON when there is an error occurs.
I modified the<EMAIL_ADDRESS>file to make it throw an error with the JSON string, so that I can see the actual error message from Apple.
const result = yield (0, spawn_1.spawn)('xcrun', notarizeArgs);

throw new Error(result.output.trim());

const parsed = JSON.parse(result.output.trim());

For me the error is "Error: HTTP status code: 403. Invalid or inaccessible developer team ID for the provided Apple ID. Ensure the Team ID is correct and that you are a member of that team."

Turned out that you need to sign some new agreement on Apple Developer site.

Strangely, it still fails for me when using the plugin as is.
This change in<EMAIL_ADDRESS>magically fixes it for me:
            const result = yield (0, spawn_1.spawn)('xcrun', notarizeArgs);
            console.log('Attempting to parse that crap:', result.output.trim());
            let parsed;
            try {
                parsed = JSON.parse(result.output.trim());
            } catch (e) {
                console.error("Failed to parse JSON:", e);
                throw new Error(result.output.trim());
            }

Had the same issue, currently forking the repo to apply the above fix.

Rollback to version 2.2.0 where JSON is parsed correctly.
"@electron/notarize": "2.2.0"
Also be sure to add resolutions to your package.json so your other electron packages use the correct version.
"resolutions": {
"@electron/notarize": "2.2.0"
}

Ok, with the rollback to 2.2.0 the error has changed. now it says "Error: HTTP status code: 401. Not authenticated. Make sure all authentication arguments are correct." but when I run notarize locally everything is fine. The problem occurs only on gitactions. I use the three environment variables:
APPLE_API_KEY: ~/private_keys/AuthKey_${{ secrets.api_key_id }}.p8
APPLE_API_KEY_ID: ${{ secrets.api_key_id }}
APPLE_API_ISSUER: ${{ secrets.api_key_issuer_id }}

Turned out that you need to sign some new agreement on Apple Developer site.

Hi @andelf, can you provide more feedback as to what was missing?

I am encountering the same problem. May I ask if there is any way to solve it?

I have encountered this issue in my attempts. Leaving this here as it may help someone else.
The error for me happened when the notarize function tried to parse the response from the initial request.
In my case, it ended up being an issue with authentication as my Apple ID was wrong, so it return an error message ( Error: HTTP status code: 401. Invalid credentials... hence the start with E)
I guess electron-notarize could be more helpful in providing a better error as suggested in #191

Turned out that you need to sign some new agreement on Apple Developer site.

Thank you
I was also able to fix this by logging into my Apple Developer account and accepting the updated agreement.

This should be fixed by #191

If someone like me ended here today looking for solutions, make sure to npm update @electron/notarize and, as stated before, accept new terms on the Apple side of things.

For anyone else looking for quick link, go to https://appstoreconnect.apple.com/business and accept any agreements you have there 👍


Error on production setup

Hi, I'm hosting a Ghost blog on a Linux Azure VM, but I'm having trouble setting up PM2 deploy.
The issue I'm getting:

My ecosystem.json settings (in the root of the app):
{
  "apps": [
    {
      "name"    : "StoreFeeder Web",
      "script"  : "index.js",
      "env": {
        "COMMON_VARIABLE": "true"
      },
      "env_production" : {
        "NODE_ENV": "production"
      }
    }
  ],
  "deploy" : {
    "production" : {
      "user" : "storefeeder",
      "host" : "<IP_ADDRESS>",
      "ref"  : "origin/master",
      "repo" : "git@github.com:StoreFeeder/storefeeder-web-v3.git",
      "path" : "apps/ghost/htdocs",
      "post-deploy" : "npm install && pm2 startOrRestart ecosystem.json --env production"
    },
    "dev" : {
      "user" : "node",
      "host" : "<IP_ADDRESS>",
      "ref"  : "origin/master",
      "repo" : "git@github.com:repo.git",
      "path" : "/var/www/development",
      "post-deploy" : "npm install && pm2 startOrRestart ecosystem.json --env dev",
      "env"  : {
        "NODE_ENV": "dev"
      }
    }
  }
}

I'm about as Linux savvy as a teaspoon so I'm almost certain that I'm the issue and not PM2.
I've been doing the setup on the server with Putty as I'm on a Windows machine myself.
I have setup ssh keys both in GitHub and in .ssh, however I'm aware I could have set this up incorrectly. Would a "command not found" error indicate issues with keys? From what I gather a specific message should tell me if this was the case.
Any help appreciated.

Hello, install git on your remote server


Package code in more cases

Currently, the code is packaged for Batch runs only. To be able to fully replicate and version things, it would be nicer if code was always stored as an artifact of each step.

We are also missing this feature. We regularly make runs in local mode and would like to store our code as an artifact. Are there any plans to address this feature?

I mentioned in the community conversation (https://gitter.im/metaflow_org/community) that it would be super valuable to be able to rerun a previously successful Run, but with different Parameter(s) or different input data. Basically the resume command but on successful runs with the ability to change Parameter values
@tuulos mentioned that there is effort on providing a top-level command for bootstrapping a project based on an existing run. This would be very useful for us
Our particular use case right now for metaflow is to use it in creating datasets with proprietary feature engineering, and also have the ability to "replay" that same data set with additional/different input data points at any time in the future. Since our feature engineering logic may change over time, its important we can reproduce the same features from a previous run with new data

another +1 here https://gitter.im/metaflow_org/community?at=6075e54e06e2e024e84f645c

+1.  Teams we're speaking with want to pack all code into the docker images and avoid downloading it from S3.  "Everything in docker images" is aligned with corp. rules (central vulnerabilities scanning, licenses check, etc.) and becoming a problem otherwise.

another +1 here.

Are there any subtask tickets to help with this?

+1 from me as well

+1 from me as well

this issue was too long，did teams give a decision about this issue?


refactor: observation recording to update observation categories dyna…

…mically
Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 58 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 82.756%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
6215

Relevant Lines:
7510

💛  - Coveralls


Bug : Registration page is not accepting any value from user.

🐞 Bug Report
Describe the bug
Input fields are not accepting any value.
When user type their name or password in registration form, form is not accepting it.
Steps to Reproduce
Steps to reproduce the behavior:

Go to 'registration page'
Try to 'type name '
See error

Expected behavior
Registration form should work properly.
Actual behavior
Registration form is not accepting any value.
Screenshots or Video

https://github.com/user-attachments/assets/1fa0a1e2-facc-48fa-88aa-1ea12062479a
Environment
Please provide the following details:

OS: _e.g., Windows
Browser/Software: _e.g., Chrome
Version: e.g., 22.0

Logs & Error Messages

working for me


Adding support to run integ tests on iceberg tables

Description
This change adds the capability to run integration tests on iceberg tables.
Testing
sbt "integtest/test"

[info] Run completed in 34 minutes, 32 seconds.
[info] Total number of tests run: 302
[info] Suites: completed 29, aborted 0
[info] Tests: succeeded 302, failed 0, canceled 0, ignored 1, pending 0
[info] All tests passed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Agree on both your points! That's why I refactored the integration tests to support additional tables types but by default they just run as the CSV type they were running as before. I think once we have skipping index logic specific to Iceberg then we can visit actually running this test continuously and how to do that.

I'm a little concern about the approach that we run all the IT against different source file format. In the existing tests, we create CSV, JSON, Parquet table which is fine because all use the same FileStreamSource. For Iceberg, do you have a full list of streaming options it support? I don't find it in the documentation.
Meanwhile I checked the other acceleration framework Hyperspace which supports File, Delta, Iceberg. But I don't see they mix or share the test code for different source.

Iceberg supports micro batch streaming read. I'm not sure what you mean about file types. Iceberg uses parquet.
I don't see why we can't share test code between sources. Like if you create a skipping index for a hive table or iceberg table and test that the skipping index was created correctly or test that the query was accelerated correctly, the only different in those two tests is what kind of table you put in the SQL query.

Actually most test are not related to different source format. I'm thinking can we make Iceberg test capability a mix-in (similar like this? https://github.com/dai-chen/opensearch-spark/blob/improve-index-validation/integ-test/src/test/scala/org/apache/spark/sql/SparkHiveSupportSuite.scala) and only enable it for FlintSparkSkippingIndexSqlITSuite, FlintSparkCoveringIndexSqlITSuite, FlintSparkMaterializedSqlITSuite. I think these are the main IT focus on index create and refresh on different data source.
Later we only enable it on more test as needed or move it to Flint test base suite. Does this make sense?

Actually most test are not related to different source format. I'm thinking can we make Iceberg test capability a mix-in (similar like this? https://github.com/dai-chen/opensearch-spark/blob/improve-index-validation/integ-test/src/test/scala/org/apache/spark/sql/SparkHiveSupportSuite.scala) and only enable it for FlintSparkSkippingIndexSqlITSuite, FlintSparkCoveringIndexSqlITSuite, FlintSparkMaterializedSqlITSuite. I think these are the main IT focus on index create and refresh on different data source.
Later we can enable it on more tests as needed or move it to Flint test base suite. Does this make sense?

Yep, I have updated the PR. Thanks for the guidance!

@asuresh8
Given that our application now supports Iceberg tables, wouldn't it be more appropriate to include the Iceberg runtime dependency in the main package itself, rather than limiting it to the runtime scope of the integration tests.
The consumers could specify the catalog class when they want to use iceberg but expecting them to include iceberg every job submission. is this a common practice?

Agreed. That was the original approach, but Chen felt like this was better as there is no Iceberg specific code in Flint.

Agreed. That was the original approach, but Chen felt like this was better as there is no Iceberg specific code in Flint.

https://github.com/microsoft/hyperspace/pull/358
I saw the hyperspace pull request for iceberg support. It seems like expecting the packages were added as provided dependencies. So it feels like the burden is on the spark job executor to provide these dependencies. Not sure of the rationale behind this.

I'm a little concern about the approach that we run all the IT against different source file format. In the existing tests, we create CSV, JSON, Parquet table which is fine because all use the same FileStreamSource. For Iceberg, do you have a full list of streaming options it support? I don't find it in the documentation.
Meanwhile I checked the other acceleration framework Hyperspace which supports File, Delta, Iceberg. But I don't see they mix or share the test code for different source.

Iceberg supports micro batch streaming read. I'm not sure what you mean about file types. Iceberg uses parquet.
I don't see why we can't share test code between sources. Like if you create a skipping index for a hive table or iceberg table and test that the skipping index was created correctly or test that the query was accelerated correctly, the only different in those two tests is what kind of table you put in the SQL query.

@asuresh8
I couldn't comprehend @dai-chen's concern here: but I am more worried about sql plugin changes where we have changed the default catalog in all queries. Would this impact on adding auto refresh indices(leverages streaming jobs) on top of non-iceberg tables with different file format. Have we added integ tests verifying non-iceberg tables with different file formats ?

Changing to the default catalog to iceberg catalog is not a breaking change because it defaults to default catalog for non iceberg tables which is the exact same behavior that Flint does today. One of the iterations of this PR I had default catalog set to iceberg catalog for all tests as well and they all passed.


let us ignore changes in LT

sometimes LT versions are created using workflows outside of Terraform.
more than that, the LT code is compared with the latest version of the LT (when using terraform plan) sometimes it is not the one in use by the ASG and it is not the default version. so sometimes Terraform compares it to the latest version someone created to test something manually and has nothing to do with the "real" version we really use.
you already did that:
lifecycle {
create_before_destroy = true
ignore_changes        = [desired_capacity]
}
}
we need the option to make "desired_capacity" a variable and to support the "all" use case:
lifecycle {
ignore_changes = all
}

please consult the Terraform documentation first - this is not possible today


Release whiteboard-hypercard v0.3.6

Also fixes https://github.com/toltec-dev/toltec/issues/729
Changes since last published version:

https://github.com/fenollp/reMarkable-tools/releases/tag/v0.3.7
https://github.com/fenollp/reMarkable-tools/releases/tag/v0.3.6
https://github.com/fenollp/reMarkable-tools/releases/tag/v0.3.5

@Eeems Ready! What needs doing here?

@Eeems Ready! What needs doing here?

A maintainer (likely myself) will need to test this package and then approve and merge it.


Add Real World Phoenix

Thanks for collecting all of these awesome resources!

Hi! Should we merge this?


feat: add support for flat event kind

Fixes #499.
This is technically a breaking change, as we're adding a enum variant to EventFieldKind, but it would only break applications that exhaust all variants in a match expression, which I deem rather unlikely. If we want to make a release on top of 0.7.2 for this, I might just apply romantic versioning an make it a patch release as 0.7.3 instead of bumping minor to 0.8.0.

No one is going to fault you for 0.7.3 I imagine, especially with the wild west versioning going on in the ecosystem 😁


Need to understand generate component command

OS?

Windows 10.

Versions.

angular-cli: 1.0.0-beta.20-4
node: 6.9.1
os: win32 x64

Repro steps.

ng g component home

It's not an error. I only want to understand. Why when  I run the previous command it generates the following:

installing component
create src\app\home\home.component.css
create src\app\home\home.component.html
create src\app\home\home.component.spec.ts
create src\app\home\home.component.ts

why not separate, for example, this way:

installing component
create src\app\assets\css\home.component.css
create src\app\templates\home.component.html
create src\app\tests\home.component.spec.ts
create src\app\components\home.component.ts

?

Angular-cli follows the angular2 style guide.

I think the best place to ask quetions is Gitter :) https://gitter.im/angular/angular-cli
TL;DR - It's better to have everything related to a component together


PDF.js in Adroid native browser (4.0.3 and 4.0.4)

Hello!
Viewer (http://mozilla.github.io/pdf.js/web/viewer.html) not working on Android native browser (i tested it on 4.0.3 and 4.0.4 devices). PDF-file is loaded (progress bar show progress), but not displayed.

Agree +1

any workaround ?

Is it only with the native Android browser? I cannot reproduce this with Firefox for Android on a Nexus 6 with Android 5.0.1.

Could you see if the console gives you an error message?

No, console does not show any error.
Loading icon is always present.
Atentamente,
Departamento de soporte al cliente
ZICLOPE INGENIERIA INFORMATICA, SL
Web:   http://www.ziclope.net/ www.ziclope.net
Email<EMAIL_ADDRESS>Teléfono de Ayuda: 807 499 181
http://www.ziclope.net/oficinas-y-horarios.htm Horario de atención al cliente
Facebook:  http://www.facebook.com/ziclope http://www.facebook.com/ziclope
Twitter:  http://twitter.com/ziclope http://twitter.com/ziclope
Aviso legal:
Este mensaje electrónico está dirigido únicamente a la(s) dirección(es) indicadas anteriormente; el carácter confidencial, personal e intransferible del mismo está protegido legalmente. Cualquier revelación, uso o reenvío no autorizado, completo o en parte, está prohibido. Si ha recibido este mensaje por equivocación, notifíquelo inmediatamente a la persona que lo ha enviado y borre el mensaje original junto con sus ficheros anexos sin leerlo ni grabarlo, total o parcialmente.
Gracias.
De: Tim van der Meij<EMAIL_ADDRESS>Enviado el: martes, 20 de enero de 2015 21:03
Para: mozilla/pdf.js
CC: kyoK
Asunto: Re: [pdf.js] PDF.js in Adroid native browser (4.0.3 and 4.0.4) (#5568)
Could you see if the console gives you an error message?
—
Reply to this email directly or view it on GitHub https://github.com/mozilla/pdf.js/issues/5568#issuecomment-70722344 .  https://github.com/notifications/beacon/AKDrLuwbnHwhHhcFm4vBL--2SiMKyV9Nks5njqvjgaJpZM4DK-Tt.gif

Yes, native Android browser you can test it with Chrome:
Using device HTC:
Remember download to PC and test viewer.html directly.
Atentamente,
Departamento de soporte al cliente
ZICLOPE INGENIERIA INFORMATICA, SL
Web:   http://www.ziclope.net/ www.ziclope.net
Email<EMAIL_ADDRESS>Teléfono de Ayuda: 807 499 181
http://www.ziclope.net/oficinas-y-horarios.htm Horario de atención al cliente
Facebook:  http://www.facebook.com/ziclope http://www.facebook.com/ziclope
Twitter:  http://twitter.com/ziclope http://twitter.com/ziclope
Aviso legal:
Este mensaje electrónico está dirigido únicamente a la(s) dirección(es) indicadas anteriormente; el carácter confidencial, personal e intransferible del mismo está protegido legalmente. Cualquier revelación, uso o reenvío no autorizado, completo o en parte, está prohibido. Si ha recibido este mensaje por equivocación, notifíquelo inmediatamente a la persona que lo ha enviado y borre el mensaje original junto con sus ficheros anexos sin leerlo ni grabarlo, total o parcialmente.
Gracias.
De: Tim van der Meij<EMAIL_ADDRESS>Enviado el: martes, 20 de enero de 2015 21:02
Para: mozilla/pdf.js
CC: kyoK
Asunto: Re: [pdf.js] PDF.js in Adroid native browser (4.0.3 and 4.0.4) (#5568)
Is it only with the native Android browser? I cannot reproduce this with Firefox for Android on a Nexus 6 with Android 5.0.1.
—
Reply to this email directly or view it on GitHub https://github.com/mozilla/pdf.js/issues/5568#issuecomment-70722222 .  https://github.com/notifications/beacon/AKDrLhEeNnTcN2Yz7stn7rPaM5UsSdfAks5njqu1gaJpZM4DK-Tt.gif

I don't know if is realated to this issue but I'm having some warnings with a Cordova app trying to use PDFjs on android 4.0.4:
Warning: Setting up fake worker.
Warning: Unhandled rejection: Error: SYNTAX_ERR: DOM Exception 12

Could be, thank you for adding that.

Developers and leaders of Mozilla, which are shemales ass!

They should then put it long as needed by the throat until he swallows themselves in suicide!
You Mozilla is...

 And to do a favour... I'm going to do that!
I kicked her so hard failure golden eggs until they are ringing and sing you all the melodies of forward and back pain in an instant!

Was it expected?
Oh, Yes, that was!
A movement such as the Mozilla!
So happy that I never upgraded to Firefox 29 and beyond!
Let me tell you something Mozilla developers! If I would be still using your latest crap-ware that really my mission would at this time to find out where you live and then drill him often in Golden's failure until you analyzes and understands how to threaten power users in the correct way!
Without a doubt, has been said before - but may not be repeated enough... You are...

Developers and leaders of Mozilla, which are shemales ass!

They should then put it long as needed by the throat until he swallows themselves in suicide!
You Mozilla is...

 And to do a favour... I'm going to do that!
I kicked her so hard failure golden eggs until they are ringing and sing you all the melodies of forward and back pain in an instant!

Was it expected?
Oh, Yes, that was!
A movement such as the Mozilla!
So happy that I never upgraded to Firefox 29 and beyond!
Let me tell you something Mozilla developers! If I would be still using your latest crap-ware that really my mission would at this time to find out where you live and then drill him often in Golden's failure until you analyzes and understands how to threaten power users in the correct way!
Without a doubt, has been said before - but may not be repeated enough... You are...

Mozilla team! You betray the spirit of code open and another time! Fortunately, more and more people are realizing that kind of hypocrites you are!
You are never going to be the number one in the browser market! Stop thinking you could be a leader, never exceed Chrome! So stop running behind Google and again focus on geeks and power users, bring personalization back, stop adding more "Chrome parity"! Add place better "Vivaldi parity"-not from the development team, you can learn how users should be treated! With respect and with the aim of satisfying your needs instead of fleeing as it operates and betray its user base kernel and other time and again and again...
You is the Mozilla developers have a brain at all, or are you just treacherous opportunists in Google Paylist? Australis is an imitation without value of Google user interface - you betray your Open Source origins with the addition of DRM and ads... well, another step to sell, the same as add mess owner as of Pocket!
You're traitors to all related open source!
I only say vivaldi.com - palemoon.org - otter-browser.org or seamonkey-project.org

Mozilla team! You betray the spirit of code open and another time! Fortunately, more and more people are realizing that kind of hypocrites you are!
You are never going to be the number one in the browser market! Stop thinking you could be a leader, never exceed Chrome! So stop running behind Google and again focus on geeks and power users, bring personalization back, stop adding more "Chrome parity"! Add place better "Vivaldi parity"-not from the development team, you can learn how users should be treated! With respect and with the aim of satisfying your needs instead of fleeing as it operates and betray its user base kernel and other time and again and again...
You is the Mozilla developers have a brain at all, or are you just treacherous opportunists in Google Paylist? Australis is an imitation without value of Google user interface - you betray your Open Source origins with the addition of DRM and ads... well, another step to sell, the same as add mess owner as of Pocket!
You're traitors to all related open source!
I only say vivaldi.com - palemoon.org - otter-browser.org or seamonkey-project.org

Mozilla team! You betray the spirit of code open and another time! Fortunately, more and more people are realizing that kind of hypocrites you are!
You are never going to be the number one in the browser market! Stop thinking you could be a leader, never exceed Chrome! So stop running behind Google and again focus on geeks and power users, bring personalization back, stop adding more "Chrome parity"! Add place better "Vivaldi parity"-not from the development team, you can learn how users should be treated! With respect and with the aim of satisfying your needs instead of fleeing as it operates and betray its user base kernel and other time and again and again...
You is the Mozilla developers have a brain at all, or are you just treacherous opportunists in Google Paylist? Australis is an imitation without value of Google user interface - you betray your Open Source origins with the addition of DRM and ads... well, another step to sell, the same as add mess owner as of Pocket!
You're traitors to all related open source!
I only say vivaldi.com - palemoon.org - otter-browser.org or seamonkey-project.org

Mozilla team! You betray the spirit of code open and another time! Fortunately, more and more people are realizing that kind of hypocrites you are!
You are never going to be the number one in the browser market! Stop thinking you could be a leader, never exceed Chrome! So stop running behind Google and again focus on geeks and power users, bring personalization back, stop adding more "Chrome parity"! Add place better "Vivaldi parity"-not from the development team, you can learn how users should be treated! With respect and with the aim of satisfying your needs instead of fleeing as it operates and betray its user base kernel and other time and again and again...
You is the Mozilla developers have a brain at all, or are you just treacherous opportunists in Google Paylist? Australis is an imitation without value of Google user interface - you betray your Open Source origins with the addition of DRM and ads... well, another step to sell, the same as add mess owner as of Pocket!
You're traitors to all related open source!
I only say vivaldi.com - palemoon.org - otter-browser.org or seamonkey-project.org

I have the same issues on Android 4.0-4.3.
If pdf file has no image, it works fine, but if has some images, it shows "loading " and blank pages (some pdfs with images works just fine).
I tried to fix by myself and found an "unhandled exception" in file pdf.worker.js at
 PDFJS.createBlob

if I change code to:
PDFJS.createBlob = function createBlob(data, contentType) {
  //if (typeof Blob !== 'undefined') {
  //  return new Blob([data], { type: contentType });
  //}
  //// Blob builder is deprecated in FF14 and removed in FF18.
  //var bb = new MozBlobBuilder();
  //bb.append(data);
	//return bb.getBlob(contentType);

	if (typeof Blob !== 'undefined') {
		try {

			var blob = new Blob([data], { type: contentType });
			console.warn("create Blob:" + contentType);
			return blob;
		} catch (e) {
			console.error("Error:PDFJS.createBlob(" + contentType + "," + data + ":" + data.length + ")");

			if (!window.BlobBuilder) {
				window.BlobBuilder = window.BlobBuilder ||
					 window.WebKitBlobBuilder ||
					 window.MozBlobBuilder ||
					 window.MSBlobBuilder;
			}
			if (e.name == 'TypeError' && window.BlobBuilder) {
				var bb = new BlobBuilder();
				bb.append(data);
				return bb.getBlob(contentType);
			}
			console.error("Error:PDFJS.createBlob exception:" + e);
			console.error(backtrace());
			return null;
		}
	}
	// Blob builder is deprecated in FF14 and removed in FF18.
	var bb = new MozBlobBuilder();
	bb.append(data);
	return bb.getBlob(contentType);
};

(logs added just for debug)
The pdf file will be displyed but missing some images (show as empty blocks)
sample pdf file for test is "Visual Studio Icon Library - Icons.pdf" of "VS2012 Modern Image Library" which can be downloaded at: http://www.microsoft.com/en-us/download/details.aspx?id=35825
Another issue when load pdf in android is "out of memory" with larger file when scroll cross number of pages.

finally, I found a workaround for my case.
If I use BlobBuilder, the pdf will be displayed with some missing imges (not throw a exception but doesn't show image). If use "falling back to data schema", all images are displayed.
So I changed code as showed blow:
PDFJS.createBlob = function createBlob(data, contentType) {
		//if (typeof Blob !== 'undefined') {
		//  return new Blob([data], { type: contentType });
		//}
		//// Blob builder is deprecated in FF14 and removed in FF18.
		//var bb = new MozBlobBuilder();
		//bb.append(data);
		//return bb.getBlob(contentType);

		if (typeof Blob !== 'undefined') {
			try {

				var blob = new Blob([data], { type: contentType });
				//
				return blob;
			} catch (e) {
				if (e.name == 'TypeError') {
//bug in android browser?
					return null;
				}
				throw e;
			}
		}
		// Blob builder is deprecated in FF14 and removed in FF18.
		var bb = new MozBlobBuilder();
		bb.append(data);
		return bb.getBlob(contentType);
	};

and
PDFJS.createObjectURL = (function createObjectURLClosure() {
		// Blob/createObjectURL is not available, falling back to data schema.
		var digits =
		  'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=';

		return function createObjectURL(data, contentType) {
			if (!PDFJS.disableCreateObjectURL &&
				typeof URL !== 'undefined' && URL.createObjectURL) {
				var blob = PDFJS.createBlob(data, contentType);
				//failed, use fallback method
				if (blob) {
					return URL.createObjectURL(blob);
				}

			}

			var buffer = 'data:' + contentType + ';base64,';
			for (var i = 0, ii = data.length; i < ii; i += 3) {
				var b1 = data[i] & 0xFF;
				var b2 = data[i + 1] & 0xFF;
				var b3 = data[i + 2] & 0xFF;
				var d1 = b1 >> 2, d2 = ((b1 & 3) << 4) | (b2 >> 4);
				var d3 = i + 1 < ii ? ((b2 & 0xF) << 2) | (b3 >> 6) : 64;
				var d4 = i + 2 < ii ? (b3 & 0x3F) : 64;
				buffer += digits[d1] + digits[d2] + digits[d3] + digits[d4];
			}
			return buffer;
		};
	})();

I don't known this changed will make any issue to lib, so I posted as a comment and hope this will help fix the issue soon.

The stock Android browser is not supported anymore since Android 4.4. We are currently at Android 6.0.1, so there is not much we can do about this. There are open issues for the WebView component in Android (such as #7157), so I'm closing this one.

Use this!
https://crosswalk-project.org

Why is there no integrated PDF.js viewer in Firefox for Android?
Everytime I click on a PDF with my mobile phone (Android Marshmallow, Firefox Beta 48) it gets downloaded instead of displayed inside of the browser.
The extension is deprecated: https://addons.mozilla.org/de/android/addon/pdfjs/

is this proplem  fix ????
i need to fix this proplem  i have  app on google play i have  500K Download  but this  proplem  make my app have  lose many pople
pls  we want fix this proplem

Any news on it?

any version of pdf.js that is compatible with android version 4.0? even if it is old one.


Generate include fails when all labels are undefined

Generate include fails when all labels are undefined (Dirk)

Fixed in DD26


Fix bower.json

In bower, react points to react & react-dom.
https://github.com/reactjs/react-bower/blob/master/bower.json

LGTM :fish_cake: Merging :ramen:


BUG Changing price type on a sub page when scrolled there isn't working

Reproducing the problem
For example:

Open the website from the root
Select Email (Sähköposti)
Scroll down to extra product, e.g. Varmuuskopioiden palautus (1 tunti/kk)
Change the product price type (e.g. one year to 3 years)
The page jumps to the top of the page

Solution
We should implement a way to update browser's history while scrolling. This way, the location would update while scrolling and this (and other) problems would go away.
Good point to implement this would be the new SEOContainer component.

Already refactored the location implementation, but still not working correctly, since React Router DOM v6 doesn't support changing the route state without renavigation. Currently updating it directly, which doesn't update the state inside React Router DOM, hence it's not working correctly for this either.


docs: voyage ai quickstart

@billy-the-fish The base branch of this PR changed so the diff included a bunch more changes than I actually did. This was supposed to only be about the quickstart 😅
I did inlcude those comments though!

@Askir , doc looks great. Perfection would be to remove the mentions of we from this page:  https://developers.google.com/style/highlights#language-and-grammar. Approved.


treeview bbox for updates not quite right

when opening / closing tree nodes, render updates not covering all changes -- is not accurate until you move mouse or scroll..

also textview highlighting not quite right either.  often works but sometimes not..

fixed: issue was not updating order of drawing when updating an existing update region -- was still drawing newer before older.


Continuous Integration?

Any plans to add Jenkins testing like tensorflow ?

We do have some CI tooling that we use internally, but nothing external yet. At some point, we would like to switch to a system similar to what Tensorflow is using.

right now I just do bazel test //magenta/...  I think we could put a travis CI script for free ... the time is not as long as tensorflow's one to require a custom CI server.


LS as objects from vuex-persistedstate

Hello, I am storing my states in localStorage and problem is that this plugin store all objects in one big object and so on. Is there any way how to remove one specific obj.
I see in the doc. how to remove specific string but this is something that parsing to JSON.slice and back could solve. Or do you have something else on mind?

Hi, are you talking about reactivity? Storage is not reactive (should it be?)
// You should provide it's definition inside Vue instance/component
localStorage: {
  someArray: { type: Array }
}

// Than get it from localStorage, modify and write back
const someArray = this.$localStorage.get('someArray')
this.$localStorage.set('someArray', someArray.slice(1, 3))

Did I understand you correctly? (if not, provide some code)

It is object of objects so slice is useless. Tryed get->string->JSON->delete->string->set
Nevertheless the main problem is in the webpack. I went almost crazy, because after hour even removing whole storage done nothing :(
So I restarted dev-server and I don't even need that reactivity anymore ...
Thank you =)


Port stuff from the previous version of MFQP

2 main things are to be imported:

Utility scripts
CSS

Interested, could you please provide some more description to this issue?

Scavenge around the old MFQP repo. Find something that is not part of IQPS. :stuck-out-tongue:


Add API ML security overview to sidebar

Describe your pull request here: Add API ML security overview to sidebar
List the file(s) included in this PR: sidebars.js.md, zowe-api-mediation-layer-security-overview.md
After creating the PR, follow the instructions in the comments.

I disagree. The article isn't relevant for the extenders. The text belongs to the repository as it explains internal behaviors for the API Mediation Layer engineers.


Error running selected code generator.  The given assembly or codebase was invalid.

Hi,
I am running into the error below when scaffolding a controller and views in VS2017.  My csproj is at the bottom.  I am not sure how to fix this, so far I have tried:

Different version of Wed.CodeGeneration.
Different Package and DotNetCliToolReference configurations

Any help greatly appreciated.

I had to make the following modification to get scaffolding to work:
Remove the below package references:
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration" Version="1.1.1" />
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.EntityFrameworkCore" Version="1.1.1" />
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGenerators.Mvc" Version="1.1.1" />

The above packages are brought in transitively by Microsoft.VisualStudio.Web.CodeGeneration.Design, so you should not refer to them directly.
Let me know if this helps.

Hi @prafullbhosale that has worked.  Thank you so much.  I have been looking on the web for a long time to get to this point.

Sorry to reopen this but I find once again that the ability to scaffold controllers and views has disappeared and the same error message has returned.
I am on VS2017 15.3.4
My .csproj has just this package Microsoft.VisualStudio.Web.CodeGeneration.Design  at version 1.1.2 and tooling Microsoft.EntityFrameworkCore.Tools.DotNet at version 1.1.0-preview4-final.
I have checked on VS2017 developer community and can't find anything that might intimate what is wrong at this time.

This should be fixed in the latest versions.


This commit closes #12

This commit closes #12

Coverage increased (+4.3%) to 77.415% when pulling 0955f8bb93d5ef9d658ff864b32c9ae1be47b6aa on fix#12 into 4f4d9acfc057e84e3d1a20a73bac7daa37613360 on master.


grafana: 5.1.4 -> 5.2.0, replace hard coded version

Motivation for this change
New release with bugfixes and new features.
Things done
Replaced the hard coded version with the packaged version
and updated the source URL which changed with the latest release.
Before this PR the displayed version for all minor and patch releases was hardcoded to 5.0.0:
before:

now:

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

$ nix path-info -S /nix/store/qdq62vnk29h06sj1ljbi3ck635y62ssn-grafana-5.1.4-bin
/nix/store/qdq62vnk29h06sj1ljbi3ck635y62ssn-grafana-5.1.4-bin	  601745400

$ nix path-info -S /nix/store/bymmr8wr96jkh71bl36cxhy08136aajd-grafana-5.2.0-bin
/nix/store/bymmr8wr96jkh71bl36cxhy08136aajd-grafana-5.2.0-bin	  607335720

[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: grafana
Partial log (click to expand)
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/blocks/graphite1/conf/etc/my_init.d/01_conf_init.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/blocks/graphite1/conf/usr/local/bin/manage.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/blocks/smtp/bootstrap.sh: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/debtest/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/create_docker_compose.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/rpmtest/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/buildcontainer/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/buildcontainer/build_circle.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/buildcontainer/run_circle.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0...

Success on aarch64-linux (full log)
Attempted: grafana
Partial log (click to expand)
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/build/deploy.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/build/download-phantomjs.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash -e"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/build/sign_packages.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/circle-test-backend.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/circle-test-frontend.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/import_many_dashboards.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/trigger_grafana_packer.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/trigger_windows_build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0...
/nix/store/jisahshspam9147hvplxyajgrs3hv53l-grafana-5.2.0-bin

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: grafana
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg  test grafana

Success on aarch64-linux (full log)
Attempted: tests.grafana
Partial log (click to expand)
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 24.12s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/7ah97qyw50al6c969vk176n87gm8qd4s-vm-test-run-grafana

Success on x86_64-linux (full log)
Attempted: tests.grafana
Partial log (click to expand)
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 21.37s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/iyjz6fd5vl4n1xlwq009c5abprjp9apk-vm-test-run-grafana


How do I build a folder into dist-electron?

The folder is structured as:
electron/server/
electron/server/models/
electron/server/endpoints/

I'd like to automatically build all the content of the above folder in the dist-electron folder. Is it possible? Below the code I tried but it obviously doesn't do what I want
{
        entry: [
          'electron/server/db-connection.js',
          'electron/server/endpoints/colour.js',
          'electron/server/models/colour.js',
        ],
        onstart(options) {
          // Notify the Renderer-Process to reload the page when the Preload-Scripts build is complete,
          // instead of restarting the entire Electron App.
          options.reload()
        },
        vite: {
          build: {
            sourcemap: isDevelopment,
            minify: isProduction,
            outDir:   'dist-electron/server',
            rollupOptions: {
              external: Object.keys("dependencies" in pkg ? pkg.dependencies : {}),
            },
          },
        },
      }

You may need to use vite-electron-plugin


Implement folding traits for optimism crate

I increased from 2 to 3 because I learnt that the conversions between kimchi expressions and folding expressions was undone.


add a feature so that a players reputation in the server determines whether punish also gives out a KIA command

Hi! Just wanted to say first that your code is still being used in servers today, so thank you :)
I was wondering if you could add a feature so that if someone who requests a !punish has a low reputation on the server, the punish only counts as a tally towards a kick, but doesn't cause the killer to be killed by admin/killed in action. The issue were facing is new players who troll and bait team killing and use that to steal vehicles since !p results in KIA. If possible, it would also be cool if regardless of the victims reputation, if the killer's reputation passes a certain threshold, they don't get KIA for !p, only a tally towards kick.
We were trying to implement these changes ourselves but the coding was beyond our depth. If you could provide some help with this it would be really appreciated!!!
Thanks :)

This would be awesome.  I took a run at it but I'm not familiar enough with C# to deal with getting/parsing the response from AdKats regarding rep.

Thanks, it's great to know it's still getting used! I no longer have access to a server to test changes and can only offer general guidance. I'm not an AdKats expert but I believe it should be possible to handle that logic entirely in there?

Thank you for you willingness to help us, I know its been a long time since you uploaded this code. I have a simple question to start, if you could shed some light that would be great. So initially I tried to just completely disable the KIA commands so I added a return statement on line 1008. But when we tried to upload the modded script, procon said it could no longer detect the plugin. Do you have any idea why this might be happening?

Hmm, how Procon loads in the plugins is a bit of a dark art I'm afraid. Perhaps your modifications had a mistake? If you have a fork I could take a look. Did you remove the unmodified plugin first?

Im not the one who manages our server plugins, but I asked them and they said yes, they removed the old one first before trying to upload the new version. Im not too familiar with github, but I uploaded my version as a 'pull request' - I hope that works and that ur able to take a look.

Sorry where did you upload it? I don't have a PR in this repo: https://github.com/stajs/Stajs.Procon.TeamKillTracker/pulls


Disabling the first visible MenuItem of a Menu breaks the Menu (and entire app by extension)

Describe the bug
If you create a Menu control where the first visible MenuItem is disabled (IsEnabled="False"), the entire menu becomes bugged. Attempting to interact with any other non-disabled menu items causes the app to quietly lock up, requiring that it be force-killed from VS.
To Reproduce

Create a new Avalonia project (MVVM in my case)
Add a Menu control to the provided window with 2+ items pre-defined in XAML, and flag the first visible item as disabled.
Build and run the project, and try to interact with any of the non-disabled menu items. The app will lock up.

Expected behavior
The app should not have a mental breakdown at the sight of a disabled item in a Menu control's first slot.
FWIW, I did try adding an invisible non-disabled item to the Menu in an attempt to work around it, but no dice. Also, disabled items in second place onwards cause no ill effects.
Desktop (please complete the following information):

OS: Windows 11 (using VS 2022)
Version 0.10.10

@SomewhereOutInSpace I haven't been able to reproduce this bug yet. I created a new MVVM project and added the following to the MainWindow.axaml.
<StackPanel>
    <Menu>
        <MenuItem Header="Item 1" IsEnabled="False" />
        <MenuItem Header="Item 2" />
        <MenuItem Header="Item 3" />
    </Menu>
</StackPanel>

OS: Windows 11 (VS 2022)
Avalonia Version 0.10.11

@puppetsw Try adding sub items to Item 2 and Item 3 and the error should occur.
I'm having the same issue on my project.
My menu is defined as follows:
<Menu HorizontalAlignment="Stretch" VerticalAlignment="Top" Background="{DynamicResource CommandBarBackgroundOpen}">
    <MenuItem IsVisible="{Binding IsNotHomePage, Mode=OneWay}" Command="{Binding GoHomeCommand}">
        <MenuItem.Header>
            <ui:FontIcon FontFamily="{StaticResource SymbolThemeFontFamily}" FontSize="14" Glyph=""/>
        </MenuItem.Header>
    </MenuItem>

    <MenuItem Header="File">
        <MenuItem Header="New File" HotKey="Ctrl+N" InputGesture="Ctrl+N" Command="{Binding HomePageViewModel.NewFileCommand}">
            <MenuItem.Icon>
                <ui:SymbolIcon Symbol="Document"/>
            </MenuItem.Icon>
        </MenuItem>

        <MenuItem Header="Open File" HotKey="Ctrl+O" InputGesture="Ctrl+O" Command="{Binding HomePageViewModel.OpenFileCommand}">
            <MenuItem.Icon>
                <ui:SymbolIcon Symbol="OpenFile"/>
            </MenuItem.Icon>
        </MenuItem>

        <MenuItem Header="Close File" HotKey="Ctrl+W" InputGesture="Ctrl+W" Command="{Binding DocumentPageViewModel.CloseFileCommand}">
            <MenuItem.Icon>
                <ui:SymbolIcon Symbol="Cancel"/>
            </MenuItem.Icon>
        </MenuItem>

        <Separator/>

        <MenuItem Header="Exit" HotKey="Alt+F4" InputGesture="Alt+F4" Command="{Binding ExitCommand}">
            <MenuItem.Icon>
                <ui:FontIcon FontFamily="{StaticResource SymbolThemeFontFamily}" FontSize="18" Glyph=""/>
            </MenuItem.Icon>
        </MenuItem>
    </MenuItem>
...

</Menu>

When the first MenuItem's IsVisible is false, clicking on the File MenuItem causes the application to hang. If IsVisible is true then there is no issue.


[Feature Request] don't count empty line when toggle comment.

current behavior
{
	// int i, avail, new_len;
	// unsigned char *ptr;
	// struct sk_buff *skb;

	// if (!ab)
	// 	return;
}

after toggling

{
	// // int i, avail, new_len;
	// // unsigned char *ptr;
	// // struct sk_buff *skb;
	//
	// // if (!ab)
	// // 	return;
}

Expected behavior
{
	// int i, avail, new_len;
	// unsigned char *ptr;
	// struct sk_buff *skb;

	// if (!ab)
	// 	return;
}

after toggling

{
	int i, avail, new_len;
	unsigned char *ptr;
	struct sk_buff *skb;

	if (!ab)
		return;
}

Duplicate of #213

problem with this is, when you comment block of comment with empty line, its going to ignore empty line.

require'Comment'.setup({ ignore = '^$' })

it make more sense like this:
on toggle:
if selected block is uncommented and has empty line -> then comment (non-empty line + empty line).
if selected block is commented and has empty line -> then un-comment

it make more sense like this:

To me, it doesn't. Either you consider or ignore empty lines all the times, no special handling.


Initial commit

Initial commit

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: tharindu1st:x: grgrzybekYou have signed the CLA already but the status is still pending? Let us recheck it.


how is isInstanceOf migrated?

for instance in https://www.tbrc.org/xmldoc?rid=W1AC16

data too inconsistent


LibreOffice 5.0.0

Thank you for the contribution. It was merged directly as 73a84c4eacd7c21b6bc7dcab6f3a61b532c9eef9 to keep commit history cleaner. Your contribution is still credited to you.


Changes made as specified in #192

changes made as specified in #192

Score and popup should be responsive
Both score and popup are now responsive.
Text must be localized to adapt the current language
Language support added
Score during the game
I have removed the score from the game and it can be seen only at the end of the game.
Precision in accuracy
It is neccessary to add the precision as such a big number is not at all good to see for user thus two decimal point precision added.

There is still issues on responsive. See for example this screen capture (popup not centered, scrollbar on the left of screen).

The language support is hard coded, should use the webl10n library instead as mentioned earlier.

Please clean commented lines and trace log in the source code.

You must not include a fix for Speak activity into the same PR than a fix of Abecedarium if both are unrelated.

webl10n library is used and language is no longer hardcoded.
all commented lines and trace logs are removed.

score popup is now much more responsive.

No more pertinent


Add 2 more CRUD api routes + Add 1 more different user type (e.g. admin)

[ ] add leaderboard ? api route to get all players sorted by number of coins, also show # managers hired, etc.
[ ] delete all Business and Upgrade of the userId, and also reset User coins to 0.
[ ] 2nd type of user ? e.g. admin who can use delete/reset user function on the ui in a protected page

Role Based Authorization with Next-Auth and Next.js 13

Create new role admin as boolean in User collection, manually set to true via db.
2 routes:
(1) GET list of users -> display on protected page /dashboard
(2) DELETE user's data -> button per user to delete certain data (all business and upgrade collections of this userId)

to make table for admin page (and leaderboard) https://twitter.com/shadcn/status/1656019263394836480

server action: https://youtu.be/bfFCnjAy_9s

Done admin user, and delete route, total 10 routes including at least 1 C/R/U/D function


Provide additional conversions from Geometry and Value to Feature

While addressing #161, I once again had the feeling that this crate can be made of papercuts sometimes. Based on the assumption that one of the primary uses of GeoJSON as a format is the production of FeatureCollection objects, this PR provides some additional conversions from Value enum members and Geometry objects to Feature objects.
I'm also considering an additional From impl to construct a FeatureCollection from a geo_types::GeometryCollection Done!

Happy to merge this as is - but what would you think about a follow up to go directly from geo::Geometry/variants -> geojson::GeoJson.
GeoJson::from(geo::Polygon::new(...))
GeoJson::from(geo::Geometry::Polygon(Polygon::new(...)))
GeoJson::from_iter(vec![Polygon::new(...),])

etc.
It seems like it would be even closer to what @Robinlovelace was originally assuming would exist.
Do you think it'd be worth the bloat? It'd be something like 30 (short) methods.

Hmm so you could go from geo primitive or geometry member -> geojson::GeoJson::Geometry{Collection}, allowing you to go to a Feature{Collection} by tagging on an extra .into()?

My 10 cents:
   use std::iter::FromIterator;
   let gc = geo::GeometryCollection::from_iter(polygons);
   let fc = geojson::FeatureCollection::from(&gc);
   let gj = GeoJson::from(fc);
   gj

Is way better than what was there before, impressive improvement from a user perspective. Not sure how that code chunk would look if @michaelkirk's suggestion got implemented but happy to take a look and provide feedback. General thinking: one person writing a few lines of code once that allows many people to write fewer lines of code many times is often a good thing, especially if it does not affect computational efficiency or the readability of the code (in this case I think the code could be made more readable by these usability tweaks).

Aha there's a diff tag. So
 ```diff
- this
+ that
```

Becomes...

- this
+ that

I'm not too worried about the increased API surface – GeoJSON is purposely (?) underspecified so you always end up converting between things.
The binary size had never occurred to me! Let's pretend nobody cares.
Your idea also led me to wonder whether we could do something like
impl<T: geo_types::CoordFloat> FromIterator<Into<geo_types::Geometry<T>>> for GeoJson {
    fn from_iter<P>(geoms: P) -> Self
        where P: IntoIterator<Item = Into<geo_types::Geometry<T>>>
    {
        // etc
    }
}

with an extra Geometry::from() inside from_iter(), which would have saved the typing and explicit impl, but alas it doesn't look like you can do that because of a missing required Sized bound (missing as a consequence of geo_types::Geometry::GeometryCollection I assume), and my type-fu doesn't extend to knowing whether that can be solved.

bors r+
let's merge this as is, it's an uncontroversial improvement.
I'll create a new issue to track the proposal for the really wide API.


fix(onboarding): populate s3 bucket name into IAM policy JSON

fixes #562

[x] Populated s3 bucket name given in a previous step inside IAM policy JSON
[x] Added unit test to verify s3 bucket name is mentioned in JSON

//cc @lcouzens

Codecov Report

Merging #566 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   83.16%   83.21%   +0.05%
==========================================
  Files         162      164       +2
  Lines        2477     2485       +8
  Branches      408      408
==========================================
+ Hits         2060     2068       +8
  Misses        370      370
  Partials       47       47

Impacted Files
Coverage Δ

...c/pages/onboardingModal/iamPolicy/instructions.tsx
100% <100%> (ø)

src/components/charts/commonChart/chartUtils.ts
80% <0%> (ø)
:arrow_up:

src/components/copyClipboard/index.ts
100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beccfa6...6bbf73e. Read the comment docs.

Thanks @dlabrecq


Comments disappear

Input file
# frozen_string_literal: true

module Foo
  # Hello
  # world
  # comments
  # disappear
  #
  def foo
  end
end

Current output file
The comments attached to foo disappear
# frozen_string_literal: true

module Foo
  #

  def foo; end
end

Expected output file
# frozen_string_literal: true

module Foo
  # Hello
  # world
  # comments
  # disappear
  #
  def foo; end
end

This should now be fixed in v0.2.0.