useQuerystring seems not using 'querystring'

I try this, which is working
const opts = {
    url: base + url + '?' + querystring.stringify(data, null, null, {
      encodeURIComponent: fixedEncodeURIComponent
    }),
    json: true,
    method: 'GET'
  }

however if I use the following, it's not using the fixedEncodeURIComponent
const opts = {
    url: base + url,
    json: true,
    method: 'GET',
    qs: data,
    qsStringifyOptions: {
      sep: null,
      eq: null,
      options: {
        encodeURIComponent: fixedEncodeURIComponent
      }
    },
    useQuerystring: true
  }

do I miss something that how to make it use 'querystring' module?

See the querystring options

@simov
I make it identical to the doc which doesn't seem to work neither, if I understand it correctly :(
qsStringifyOptions: {
      sep: ';',
      eq: ':',
      options: {
        encodeURIComponent: fixedEncodeURIComponent
      }
    },
    useQuerystring: true

found the problem, was using a very old version, sorry for the noise


TAJO-1807: Not display "Finished Queries" in query.jsp

Hi,
I have implemented for this issue.
Thanks!

Hi @hys9958, thank you for your work.
I'm wondering hsync() does not work properly. If you have already tried, please share the result.

@hys9958
You should set history file path, if you can't use the system default
HISTORY_QUERY_DIR("tajo.history.query.dir", "file:///{your-query-history-directtory}/history")


ISSUE-726: Imported topology containing a notifier fails during deployment

Update the right notifier jar file name in the notifier config during a import.
Fixes #726

+1


Add accessibleOnly prop to Label

I needed this option for LanguageSelect and CountrySelect in the Dashboard. These don't have labels, as they are not part of a form.
What do you think, does this make sense?

Aren't we just cheating the tests? Shouldn't we simply ignore these errors on the spec if possible?


[TextEdit] Improve block/insert caret drawing.

Fix block caret alignment on empty line:

Fix block caret width, when the logical end of the line is visually in the middle:

Add secondary caret indicator:

Fixes #50245

When insert mode is enabled, it shows the block caret on empty lines. Other than that, everyhings seems to work well.

When insert mode is enabled, it shows the block caret on empty lines.

Fixed.

Thanks!


fix: 🐛 v7 multiSig errors by using payer/admin over creator

Description
fix issues when creating proposals due to some calls not being updated to the getAdmin/getPayer calls vs legacy getCreator call
Breaking Changes

JIRA Link

Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward


cranial cartilage

Add:
abnormal cranial cartilage morphology
DEF: any structural anomaly of any cartilage element that is part of the cranial skeleton
SYN: abnormal cranium cartilage morphology
SOURCE: UBERON:0003933
Annotation in J:76480

Added:
abnormal cranial cartilage morphology MP:0030464


Added PowerFit tutorial

Do not merge.
There are a few typos in the text, I'll email you about them. Also, I think it would make sense to use the coloring scheme we use in the molmod course for linux & pymol commands, instructions, questions, etc, to be consistent. Do you agree?

Sure - but we need it done very soon - planned for Taiwan over one week
=================================
Prof. A.M.J.J. Bonvin | Faculty of Science
Utrecht University | bonvinlab.org
<EMAIL_ADDRESS>| T: +31 30 2533859

On 05 Mar 2016, at 19:45, João Rodrigues<EMAIL_ADDRESS>wrote:
Do not merge.
There are a few typos in the text, I'll email you about them. Also, I think it would make sense to use the coloring scheme we use in the molmod course for linux & pymol commands, instructions, questions, etc, to be consistent. Do you agree?
—
Reply to this email directly or view it on GitHub.

On it.
@latrocinia Why do you use -a 20 if the default is 10? Would this impact the results of the search on this particular case?

Should run in a reasonable time for the tutorial...
===============================
Prof. A.M.J.J. Bonvin | Faculty of Science
Utrecht University | bonvinlab.org
<EMAIL_ADDRESS>| T: +31 30 2533859

On 05 Mar 2016, at 20:40, João Rodrigues<EMAIL_ADDRESS>wrote:
On it.
@latrocinia Why do you use -a 20 if the default is 10? Would this impact the results of the search on this particular case?
—
Reply to this email directly or view it on GitHub.

OK, so I got it wrong from the text. I thought 20 was slower than 10!
A sáb, 5/03/2016, 12:51, Alexandre Bonvin<EMAIL_ADDRESS>escreveu:

Should run in a reasonable time for the tutorial...
===============================
Prof. A.M.J.J. Bonvin | Faculty of Science
Utrecht University | bonvinlab.org
<EMAIL_ADDRESS>| T: +31 30 2533859

On 05 Mar 2016, at 20:40, João Rodrigues<EMAIL_ADDRESS>wrote:
On it.
@latrocinia Why do you use -a 20 if the default is 10? Would this impact
the results of the search on this particular case?
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
https://github.com/haddocking/haddocking.github.io/pull/37#issuecomment-192733766
.

Hi Gydo
I leave it to you to deal with Joao’s changes first.
Had a quick look at the files in GitHub. Did you add the structure validation / clash analysis part?
Did you get my email with the simple script to calculate distance histograms for the contacts up to 5A?
Cheers
Alexandre

On 05 Mar 2016, at 18:06, Gydo van Zundert<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/haddocking/haddocking.github.io/pull/37
Commit Summary
• Added PowerFit tutorial
File Changes
• M education/index.md (8)
• A education/powerfit-tutorial/index.md (202)
Patch Links:
• https://github.com/haddocking/haddocking.github.io/pull/37.patch
• https://github.com/haddocking/haddocking.github.io/pull/37.diff
—
Reply to this email directly or view it on GitHub.

Dr. Alexandre M.J.J Bonvin              | Professor of Computational Structural Biology
Faculty of Science, Utrecht University, Padualaan 8, 3584 CH Utrecht, the Netherlands
Phone: +31-30-2533859 / 2652      |   Fax: +31-30-2537623
Email<EMAIL_ADDRESS>http://www.uu.nl/staff/AMJJBonvin  |  http://www.bonvinlab.org

Indeed, the 20 degree interval results in fewer rotations -> Faster

From: Jo�o Rodrigues<EMAIL_ADDRESS>Sent: Saturday, March 05, 2016 10:48 PM
To: haddocking/haddocking.github.io
Cc: Zundert, G.C.P. van (Gydo)
Subject: Re: [haddocking.github.io] Added PowerFit tutorial (#37)
OK, so I got it wrong from the text. I thought 20 was slower than 10!
A s�b, 5/03/2016, 12:51, Alexandre Bonvin<EMAIL_ADDRESS>escreveu:

Should run in a reasonable time for the tutorial...
===============================
Prof. A.M.J.J. Bonvin | Faculty of Science
Utrecht University | bonvinlab.org
<EMAIL_ADDRESS>| T: +31 30 2533859

On 05 Mar 2016, at 20:40, Jo�o Rodrigues<EMAIL_ADDRESS>wrote:
On it.
@latrocinia Why do you use -a 20 if the default is 10? Would this impact
the results of the search on this particular case?
�
Reply to this email directly or view it on GitHub.

�
Reply to this email directly or view it on GitHub
https://github.com/haddocking/haddocking.github.io/pull/37#issuecomment-192733766
.

�
Reply to this email directly or view it on GitHubhttps://github.com/haddocking/haddocking.github.io/pull/37#issuecomment-192748328.

Hey Alex,
No I didn't actually. I'll add the part, for clashing analysis. Wait for the revision.
Cheers,
Gydo

From: Alexandre Bonvin<EMAIL_ADDRESS>Sent: Sunday, March 06, 2016 4:22 PM
To: haddocking/haddocking.github.io
Cc: Zundert, G.C.P. van (Gydo)
Subject: Re: [haddocking.github.io] Added PowerFit tutorial (#37)
Hi Gydo
I leave it to you to deal with Joao�s changes first.
Had a quick look at the files in GitHub. Did you add the structure validation / clash analysis part?
Did you get my email with the simple script to calculate distance histograms for the contacts up to 5A?
Cheers
Alexandre

On 05 Mar 2016, at 18:06, Gydo van Zundert<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/haddocking/haddocking.github.io/pull/37
Commit Summary
� Added PowerFit tutorial
File Changes
� M education/index.md (8)
� A education/powerfit-tutorial/index.md (202)
Patch Links:
� https://github.com/haddocking/haddocking.github.io/pull/37.patch
� https://github.com/haddocking/haddocking.github.io/pull/37.diff
�
Reply to this email directly or view it on GitHub.

Dr. Alexandre M.J.J Bonvin | Professor of Computational Structural Biology
Faculty of Science, Utrecht University, Padualaan 8, 3584 CH Utrecht, the Netherlands
Phone: +31-30-2533859 / 2652 | Fax: +31-30-2537623
Email<EMAIL_ADDRESS>http://www.uu.nl/staff/AMJJBonvin | http://www.bonvinlab.org
�
Reply to this email directly or view it on GitHubhttps://github.com/haddocking/haddocking.github.io/pull/37#issuecomment-192913679.

I see that the csh script requires the contact program in addition to xmgrace. Those programs should be made available in the VM.
There were some bugs in the csh-script, the numbers of the bins are incorrect. I'll upload an updated version in the powerfit-tutorial repo.

From: Alexandre Bonvin<EMAIL_ADDRESS>Sent: Sunday, March 06, 2016 4:22 PM
To: haddocking/haddocking.github.io
Cc: Zundert, G.C.P. van (Gydo)
Subject: Re: [haddocking.github.io] Added PowerFit tutorial (#37)
Hi Gydo
I leave it to you to deal with Joao�s changes first.
Had a quick look at the files in GitHub. Did you add the structure validation / clash analysis part?
Did you get my email with the simple script to calculate distance histograms for the contacts up to 5A?
Cheers
Alexandre

On 05 Mar 2016, at 18:06, Gydo van Zundert<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/haddocking/haddocking.github.io/pull/37
Commit Summary
� Added PowerFit tutorial
File Changes
� M education/index.md (8)
� A education/powerfit-tutorial/index.md (202)
Patch Links:
� https://github.com/haddocking/haddocking.github.io/pull/37.patch
� https://github.com/haddocking/haddocking.github.io/pull/37.diff
�
Reply to this email directly or view it on GitHub.

Dr. Alexandre M.J.J Bonvin | Professor of Computational Structural Biology
Faculty of Science, Utrecht University, Padualaan 8, 3584 CH Utrecht, the Netherlands
Phone: +31-30-2533859 / 2652 | Fax: +31-30-2537623
Email<EMAIL_ADDRESS>http://www.uu.nl/staff/AMJJBonvin | http://www.bonvinlab.org
�
Reply to this email directly or view it on GitHubhttps://github.com/haddocking/haddocking.github.io/pull/37#issuecomment-192913679.

Ok - xmgrace should be already there (I hope).
the contacts-chainID program should be added (taken from HADDOCK tools
As for the script you could probably write a much better one in Python… But it does the job

On 06 Mar 2016, at 17:18, Gydo van Zundert<EMAIL_ADDRESS>wrote:
I see that the csh script requires the contact program in addition to xmgrace. Those programs should be made available in the VM.
There were some bugs in the csh-script, the numbers of the bins are incorrect. I'll upload an updated version in the powerfit-tutorial repo.

From: Alexandre Bonvin<EMAIL_ADDRESS>Sent: Sunday, March 06, 2016 4:22 PM
To: haddocking/haddocking.github.io
Cc: Zundert, G.C.P. van (Gydo)
Subject: Re: [haddocking.github.io] Added PowerFit tutorial (#37)
Hi Gydo
I leave it to you to deal with Joao�s changes first.
Had a quick look at the files in GitHub. Did you add the structure validation / clash analysis part?
Did you get my email with the simple script to calculate distance histograms for the contacts up to 5A?
Cheers
Alexandre

On 05 Mar 2016, at 18:06, Gydo van Zundert<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/haddocking/haddocking.github.io/pull/37
Commit Summary
� Added PowerFit tutorial
File Changes
� M education/index.md (8)
� A education/powerfit-tutorial/index.md (202)
Patch Links:
� https://github.com/haddocking/haddocking.github.io/pull/37.patch
� https://github.com/haddocking/haddocking.github.io/pull/37.diff
�
Reply to this email directly or view it on GitHub.

Dr. Alexandre M.J.J Bonvin | Professor of Computational Structural Biology
Faculty of Science, Utrecht University, Padualaan 8, 3584 CH Utrecht, the Netherlands
Phone: +31-30-2533859 / 2652 | Fax: +31-30-2537623
Email<EMAIL_ADDRESS>http://www.uu.nl/staff/AMJJBonvin | http://www.bonvinlab.org
�
Reply to this email directly or view it on GitHubhttps://github.com/haddocking/haddocking.github.io/pull/37#issuecomment-192913679.
—
Reply to this email directly or view it on GitHub.

==================================
Alexandre Bonvin
Talingweide 91, 3403 AC IJsseltstein, NL
Tel: +31-30-7525883
Email<EMAIL_ADDRESS>

Great!! The script is fine, just some numbers were wrong :-)).

From: Alexandre Bonvin<EMAIL_ADDRESS>Sent: Sunday, March 06, 2016 5:42 PM
To: haddocking/haddocking.github.io
Cc: Zundert, G.C.P. van (Gydo)
Subject: Re: [haddocking.github.io] Added PowerFit tutorial (#37)
Ok - xmgrace should be already there (I hope).
the contacts-chainID program should be added (taken from HADDOCK tools
As for the script you could probably write a much better one in Python… But it does the job

On 06 Mar 2016, at 17:18, Gydo van Zundert<EMAIL_ADDRESS>wrote:
I see that the csh script requires the contact program in addition to xmgrace. Those programs should be made available in the VM.
There were some bugs in the csh-script, the numbers of the bins are incorrect. I'll upload an updated version in the powerfit-tutorial repo.

From: Alexandre Bonvin<EMAIL_ADDRESS>Sent: Sunday, March 06, 2016 4:22 PM
To: haddocking/haddocking.github.io
Cc: Zundert, G.C.P. van (Gydo)
Subject: Re: [haddocking.github.io] Added PowerFit tutorial (#37)
Hi Gydo
I leave it to you to deal with Joao�s changes first.
Had a quick look at the files in GitHub. Did you add the structure validation / clash analysis part?
Did you get my email with the simple script to calculate distance histograms for the contacts up to 5A?
Cheers
Alexandre

On 05 Mar 2016, at 18:06, Gydo van Zundert<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/haddocking/haddocking.github.io/pull/37
Commit Summary
� Added PowerFit tutorial
File Changes
� M education/index.md (8)
� A education/powerfit-tutorial/index.md (202)
Patch Links:
� https://github.com/haddocking/haddocking.github.io/pull/37.patch
� https://github.com/haddocking/haddocking.github.io/pull/37.diff
�
Reply to this email directly or view it on GitHub.

Dr. Alexandre M.J.J Bonvin | Professor of Computational Structural Biology
Faculty of Science, Utrecht University, Padualaan 8, 3584 CH Utrecht, the Netherlands
Phone: +31-30-2533859 / 2652 | Fax: +31-30-2537623
Email<EMAIL_ADDRESS>http://www.uu.nl/staff/AMJJBonvin | http://www.bonvinlab.org
�
Reply to this email directly or view it on GitHubhttps://github.com/haddocking/haddocking.github.io/pull/37#issuecomment-192913679.
—
Reply to this email directly or view it on GitHub.

==================================
Alexandre Bonvin
Talingweide 91, 3403 AC IJsseltstein, NL
Tel: +31-30-7525883
Email<EMAIL_ADDRESS>—
Reply to this email directly or view it on GitHubhttps://github.com/haddocking/haddocking.github.io/pull/37#issuecomment-192928677.

Sounds good! I'll close this PR then. @latrocinia make a new one with everything whenever you are ready. Indeed that script should be re-written to make things easier :) And matplotlib should be installed on the machine too!

No sure which script you are referring to, but doesn't the VM already have xmgrace? We should avoid installing too much stuff :-)
=================================
Prof. A.M.J.J. Bonvin | Faculty of Science
Utrecht University | bonvinlab.org
<EMAIL_ADDRESS>| T: +31 30 2533859

On 06 Mar 2016, at 20:10, João Rodrigues<EMAIL_ADDRESS>wrote:
Sounds good! I'll close this PR then. @latrocinia make a new one with everything whenever you are ready. Indeed that script should be re-written to make things easier :) And matplotlib should be installed on the machine too!
—
Reply to this email directly or view it on GitHub.


Missing import XICRA.modules.database in modules/tRNA.py

Hi !
I've got import error message:
File "/usr/local/lib/python3.8/dist-packages/XICRA/modules/tRNA.py", line 131, in run_tRNA
    options.tRNA_db = database.tRNA_db(options.database, options.tRNA_db, options.debug)
NameError: name 'database' is not defined

It would be great to fix it, thanks :)

Hi there,
I think I have fixed the issue. I can not reproduce the error in my laptop now so please let me know if you suceed to work it out or you encounter any additional errors.
Please, re-install XICRA via pip and make sure v1.4.3 is installed.
Best regards
Jose

Hi Jose,
There is a new error now:
Traceback (most recent call last):
  File "/usr/local/bin/XICRA", line 382, in <module>
    args.func(args)
  File "/usr/local/lib/python3.8/dist-packages/XICRA/modules/tRNA.py", line 132, in run_tRNA
    options.tRNA_db = database.tRNA_db(options.database, options.tRNA_db, options.debug)
AttributeError: 'Namespace' object has no attribute 'tRNA_db'

Thanks
Clement

Hi there,
I see where the problem is. I will fix it tomorrow and let you know.
Best regards and hope you find XICRA useful,
Jose

Hi there,
I guess I have fixed it. Make sure to install version 1.4.5.
I have found some missing packages not included in the YML file so it might be useful to update your conda environment too.
I have additionally added a test set of reads, either for miRNA or tRNA modules. Run XICRA test and then try either to run the shell script generated or step by step. Be aware some of the reads are either simulated or trimmed and might produce errors during trimming.
The tRNA module is working fine for me now,
Please, again, if any errors or doubts arise, please let me know.

Hi there @cplessis, I wonder if you found any other issues?
Best regards


a context change does nothing

I'm just testing the cds api and I am noticing that when posting to /content, a change in a resource strings 'context' field does not end up changing anything. It shows as skipped.

The context field cannot be altered after string creation, as it contributes to creation of the resource_string_id unique identifier of a string. You can see the relevant answer here as well: https://github.com/transifex/transifex-delivery/issues/75

yeah, just noticed the v3 api also does not allow 'context' in the patch payload. This is fine. I can work around this.


Mutual authentication and Secure Channel - Review the Kong plugin that ciphers and deciphers the secure channel

This is also tracked (duplicate) by dojot/dojot#195

This feature is no longer supported by dojot.


:memo: feat(docs-beta): Add ReadContract example

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #177   👈

This comment was auto-generated by Graphite.


Please merge revision 5919a12038920d5084116bd101e8013b789765bb into dev channel

@whesse @mit-mit @kasperl
This fixes serving apps from a subdirectory of web on windows, with ddc (see https://github.com/dart-lang/pub/issues/1622).
5919a12038920d5084116bd101e8013b789765bb
This merged cleanly

Note that I will have a few more coming as well, if you want to late and do them all at once.

Any more? I'll be doing this integration pretty soon.

There are two more coming, but one is still out for review and the other is blocked on it (but has lgtm).

OK - I'll go ahead with this one for tonight.
On Thu, May 25, 2017 at 4:25 PM, Jacob MacDonald<EMAIL_ADDRESS>wrote:

There are two more coming, but one is still out for review and the other
is blocked on it (but has lgtm).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/29724#issuecomment-304150884,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACAsW1LntbhVvGJ9wmRTiKrTzWUe9eYuks5r9g3zgaJpZM4NmdGi
.

Sgtm, thanks!

97b750425db5568aa16f3cf0fd808d933151e2dd is also ready now

https://github.com/dart-lang/sdk/commit/5919a12038920d5084116bd101e8013b789765bb no longer merges cleanly against dev.

Closing as we talked offline, looks like dev got moved up to a more recent version somehow....

It turns out that 5919a12038920d5084116bd101e8013b789765bb was already picked in 83c8cbd70005e58102f2a8457c8b4340808251bf .

97b750425db5568aa16f3cf0fd808d933151e2dd was merged in f5af3861966da44deb3092182433fd2436cb7b68


[Feature]: Api for the "img_object_embedding" pipeline

Is there an existing issue for this?

[X] I have searched the existing issues.

Is your feature request related to a problem? Please describe.
Make Api for any object detection pipeline " towhee/img_object_embedding"
Describe the solution you'd like.
An api which return the output similar to the https://towhee.io/towhee/img_object_embedding
Describe an alternate solution.
No response
Anything else? (Additional Context)
Working on this issue is highly encouraged for Google summer of code 2022 aspirants (Project 1)

Just to clarify, this is not a Towhee-level API, but a hosted API based on Flask/FastAPI/etc.

we can use Region-Based Convolutional Neural Networks (RCNN) because RCNN utilizes a selective search algorithm to propose region of interest in an image and, after that, uses a convolutional neural network to detect the presence of the object of interest within the proposed region.

Hello, can I work on this issue?

Hey can I work on this issue?


Connection handling: document best practices

RethinkDB users often raise questions about the best practices for handling connections, like:

Should I open a connection for each query?
How expensive is a connection in RethinkDB?
How long should I hold onto a connection for?

Details can vary based on your environment and application needs, but it would be good to have an article reviewing some common cases and best practices.

Pinging @danielmewes for these. My general sense is that #1 is "no," but I'm less certain about #3 and have no idea about #2.

These are great questions, but unfortunately I also don't have any real data. I'll try to benchmark this sometime and report my findings back here.
I think this can wait until we actually know what we are talking about.


Either /folder/index.html or /folder/other-file.html works but not both

I have this:

/content/folder/index.html
/content/folder/other-file.html

Behavior:

When I enter http://localhost:1313/folder/ it displays index.html.
When I enter http://localhost:1313/folder/other-file/ it displays 404 page not found.

But when I make any change to other-file.html then this now happens:

When I enter http://localhost:1313/folder/ it displays /layouts/_default/list.html (should be index.html)
When I enter http://localhost:1313/folder/other-file/ it displays other-file.html

It's random and interchangeable. I don't see any logic or fix.
Hugo Static Site Generator v0.40.3 windows/amd64 BuildDate: 2018-05-09T07:47:04Z

Thanks for getting in touch, but it feels like this is a question  that would be better suited to the Hugo Discussion Forum.  We prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug. You may also find the answers you search for in Hugo Documentation.

How is this a question? Do you see any question marks there?
This is a bug report: there are 2 separate behaviors (listed above). There should be 1 behavior.
Yes, this is a "genuine bug report".
I see that you (counter-intuitively) decided to make /content/folder/index.html not overwrite /layouts/_default/list.html. I don't like it because I was expecting that index.html will be present at http://localhost:1313/folder/ but that's OK.
I feel like I already explained what's the problem sufficiently above. This is happening RANDOMLY so I can't provide any exact steps to reproduce this issue.

I do hugo -serve and (according to your documentation this should not ever happen but it happens):

http://localhost:1313/folder/ it displays index.html
http://localhost:1313/folder/other-file/ it displays 404 page not found

I do a modification to /content/other-file.html and suddenly something else happens (or not) (according to your documentation this is the correct behavior):

http://localhost:1313/folder/ it displays /layouts/_default/list.html
http://localhost:1313/folder/other-file/ it displays other-file.html


Duplicate manifests. Remove foxit-reader.json

There is exactly the same package in another manifest foxit-pdf-reader.json That one is newer, and the manifest naming is more appropriate, as the name of the tool is "Foxit PDF Reader" and not "Foxit Reader". In any case, this manifest should be removed.

[+] I have read the Contributing Guide.

Will be fixed when we have some new feature.


Add pyproject.toml for Custom Node Registry

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.
The main benefits are that authors can

publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

[ ] Go to the registry. Login and create a publisher id (everything after the @ sign on your registry profile).
[ ] Add the publisher id into the pyproject.toml file.
[ ] Merge the separate Github Actions PR, then merge this PR.

If you want to publish the node manually, install the cli by running pip install comfy-cli, then run comfy node publish
Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

hey @spacepxl, wanted to send a small nudge and ask if you had any questions!

@spacepxl, wondering if there's any way we can support you on this PR!


Custom/Personal notifications with sound enhancement request

I'd like to be able to for example, set a notification to do the Mad King at 7pm and not only get a popup, but a noise. The alerts work very well, but if something is not entered, I think it would be very user friendly to let the user enter what notifications they want? Thanks for your consideration. I find Blish really useful since I've switched over to using it all the time because of the new map integration. Thank you so much!

This would probably be more suited for the Events Module (https://github.com/blish-hud/Community-Module-Pack/tree/master/Events Module)
As far as I know there are plans by @dlamkins and @Tharylia to merge it with the Event Table (https://github.com/Tharylia/Blish-HUD-Module-Releases/releases) Maybe they can elaborate about this feature.
I think that the Timers Module also had a discussion about a similar thing on our Discord.


Websockets - Join room

Description
When a user join into a chat room, should be able to read messages in real time
Taks

[ ] Add a Websocket that join user to a chat room
[ ] Update the DynamoDB table adding the new user
[ ] Notify all the users the new user is join
[ ] Validate if user is join as Authenticated User
[ ] Validate if user is join as Guest User

This ticket is blocked by #18

Unblocked #19


IndexedStack How to change index

I find that the index attribute of IndexedStack is final and cannot be modified. How to change the index property to switch pages

Just keep the index in state and use setstate.
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _currentIndex = 0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.refresh),
        onPressed: () {
          setState(() {
            _currentIndex = (_currentIndex + 1) % 3;
          });
        },
      ),
      body: Center(
        child: IndexedStack(
          index: _currentIndex,
          children: <Widget>[
            Container(height: 100, width: 100, color: Colors.red),
            Container(height: 100, width: 100, color: Colors.green),
            Container(height: 100, width: 100, color: Colors.blue),
          ],
        ),
      ),
    );
  }
}

Just keep the index in state and use setstate.
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _currentIndex = 0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.refresh),
        onPressed: () {
          setState(() {
            _currentIndex = (_currentIndex + 1) % 3;
          });
        },
      ),
      body: Center(
        child: IndexedStack(
          index: _currentIndex,
          children: <Widget>[
            Container(height: 100, width: 100, color: Colors.red),
            Container(height: 100, width: 100, color: Colors.green),
            Container(height: 100, width: 100, color: Colors.blue),
          ],
        ),
      ),
    );
  }
}

It will show error: "Only static members can be accessed in initializers"

It will show error: "Only static members can be accessed in initializers"

Please post code which is throwing the error.

It will show error: "Only static members can be accessed in initializers"

Please post code which is throwing the error.

"Only static members can be accessed in initializers"

indicates that you reference the variable that you are trying to initialize, which is invalid in Dart.
class Foo {
  var bar = Button(Text('click me'), onPressed: () => onButtonPressed(bar)); // referencing `bar` here is invalid
}

You would need to change that to something like
class Foo {
  Foo() { // this could also be done in `initState() { ... }` if `Foo` is a `StatefulWidget`
    bar = Button(Text('click me'), onPressed: () => onButtonPressed(bar));
  }
  var bar;
}

Please consider asking support questions in one of the other channels listed at http://flutter.io/support .


Issue connecting to AWS IoT's MQTT broker with TLS-only authentication

Hello! I've submitted a support ticket related to this, but I figured it's probably better to come to the source so others running into AWS configuration issues in the future could reference this.
I'm working to connect the Alfa development kit to AWS's IoT service, but I'm running into issues with their TLS-only authentication requirements.
In config.h I've made the following configuration changes, (1) enabling TLS certificates, (2) changing the port to 8883, and (3) commenting out the username and password...
#define USE_TLS_CERTIFICATES
//#define USE_USERNAME_PASSWORD

#define MQTT_BROKER_HOST "{{unique-endpoint-id}}.iot.us-east-1.amazonaws.com"
// MQTT_BROKER_PORT generally is 1883 for clear-text, 8883 for TLS
#define MQTT_BROKER_PORT 8883
#define MQTT_KEEP_ALIVE 0
#define MQTT_CLIENT_ID "prototype-1"
#define MQTT_PUBLISH_TOPIC "prototype-1/info"
#define MQTT_STATE_TOPIC "device/state"

#ifdef USE_USERNAME_PASSWORD
//#define MQTT_LOGIN ""
//#define MQTT_PASSWORD ""
#endif

And in tls_credentials.h I've added my certificate and private key generated in AWS's console, and AWS's RSA 2048 root CA...
#define TLS_DEVICE_CERT "" \
"-----BEGIN CERTIFICATE-----" \
"multiple" \
"line" \
"certificate" \
"goes" \
"here==" \
"-----END CERTIFICATE-----"

#define TLS_DEVICE_PKEY "" \
"-----BEGIN RSA PRIVATE KEY-----" \
"multiple" \
"line" \
"private key" \
"goes" \
"here" \
"-----END RSA PRIVATE KEY-----"

#define TLS_SERVER_CA "" \
"-----BEGIN CERTIFICATE-----" \
"AWS" \
"root CA" \
"certificate" \
"goes" \
"here" \
"-----END CERTIFICATE-----"

As a result, I'm seeing the following error code in the serial monitor after network registration completes...
00:03:56.347 WARN mqtt.h:109:mqtt_connect() Failed to connect to MQTT broker, error: -6
00:03:56.347 WARN mqtt.h:67:mqtt_loop() Reconnection failed

I've verified that my keys match, and are properly configured to the device in the AWS console. At this point I'm thinking there's either an issue with TLS-only authentication, or I made some novice formatting or configuration error in my simple code changes above. Hoping for some guidance on possible next steps for resolution.
Thanks, in advance, for your time. I really appreciate it!

Hi @iannerney,
did you already have a chance to try the master branch?

Hey @OYTIS, thanks for following up on this!
I configured a new sample from master, adding the temp and humidity sensor library, but still no luck with the connection. I'm still seeing the same connection error...
00:00:100:00:33.628 INFO OwlModemSocket.cpp:560:sendTCP() Sent data over TCP on socket 0 30 bytes 00:00:43.428 WARN mqtt.h:109:mqtt_connect() Failed to connect to MQTT broker, error: -6 00:00:43.428 WARN mqtt.h:67:mqtt_loop() Reconnection failed
I also checked the AWS logs, and I don't see any authorization errors or connection attempts using that certificate, so I'm still thinking something is off in my config or the tls credentials.
I'm new to MQTT, but based on AWS's documentation on MQTT, it looks like they might have some variations from other MQTT brokers. Do you see anything in here that might prevent the connection from being established?
I'll try to add some debugging steps in the code to get more verbose error messaging and will report back.

Hi @iannerney,
could you please post your updated config.h and tls_credentials.h? (feel free to hide the key and/or certificate, I just want to take a look at the general shape).

One thing that just occurred to me is the keep alive interval. Depending on your network conditions it might make sense to send MQTT_KEEP_ALIVE to something between 20 and 200.
Also please make sure your certificate has the right policy attached. An example of working policy:
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Action": "iot:*",
      "Resource": "*"
    }
  ]
}

If nothing helps, there are two things you can do to help us with debugging. To check if everything is alright with your credentials, you can try to connect with mosquitto_pub:
mosquitto_pub --cafile ./ca.pem --cert ./XXXX-certificate.pem.crt --key ./XXXX-private.pem.key -t device/data -m 'Hello!' -h XXXX.XXXX.amazonaws.com -p 8883

Finally, you can give us more insight into what is going on on your device by replacing owl_log_set_level(L_INFO); in your setup() procedure with owl_log_set_level(L_DBG);, and sharing the log (which is going to be pretty large).

Here is a ZIP of the config.h and tls_credentials.h as I currently have them configured, with the keys and endpoint URL replaced.
files.zip
As for your suggestions, I'll go ahead and run through these and will report back shortly. I can say that I have verified the certificate is attached to a working iot:* policy.
Thank you!

I've set the MQTT_KEEP_ALIVE value to 110, and verified that the policy matched yours.
I then used mosquitto_pub to send a message using the certificate, and I was able to receive the message in my AWS console.

As for the debug log, here's the output from the start of the process loop, through where the error is displayed. I've included it in a text file, so it's a bit easier to read.
debug_log.txt
Please review and let me know if you have any questions.  I also validated the certificates were the same that I used in mosquitto_pub.
Thank you for your help with this! If you'd prefer to see this in real time, we could setup a quick screenshare session. Just let me know what works best for you.

Hi @iannerney,
thank you for the detailed info. I can't see anything wrong in the config or TLS credentials. A live session would be great indeed. The only problem is that I am in CET timezone, so we'll have to do in in the (U.S.) morning if you don't mind. Please contact me on<EMAIL_ADDRESS>to schedule a session.

Sure thing, I'll shoot you an email now to coordinate. Thank you!

After the debugging session it turned out that AWS needs keepalive value to be in quite a narrow interval. It worked fine when set to 20 seconds, which is now the default value in our samples. Further investigations on what values are appropriate and why are needed.


Add several multi_queue_executor optimizations, automatic work distribution across streams, hipSYCL_prefer_execution_lane extension

Adds multiple features to DAG processing and multi_queue_executor:

This adds two important optimizations to DAG processing and the multi_queue_executor:

Add the optimization to simplify the DAG early on by removing requirements that are already implied by other requirements because they already appear in their requirement graph. This has been on the todo list for a long time and helps avoid massive graph growth when huge number of tasks are submitted as discussed in #380.
Add the multi_queue_executor optimization that synchronization with other execution lanes/streams is only necessary for the last dependency on a lane because of the in-order execution property of lanes/streams. In other cases, the synchronization can be removed.

Additionally, this finally adds initial support for automatic work distribution across the lane/stream pool of a device, allowing our runtime architecture to finally flex its muscles. Currently, the distribution is done by first attempting to minimize the number of dependencies on other lanes. This effectively causes task groups with dependencies between them to tend to execute on the same lane/stream, reducing latency. When this criteria is inconclusive, the multi_queue_executor will submit the task to a lane/stream that it thinks is underutilized. For this purpose, it records the lanes to which the last 100 tasks were submitted. A time-decay mechanism is added such that older information contributes less.
This approach is still a bit simplistic in some aspects, but it's a start.

Adds the hipSYCL_prefer_execution_lane extension. This is a command group property that carries a hint for the multi_queue_executor on which backend lane/stream to execute the operation:

std::size_t lane_id = 0; // Execute on first lane
q.submit({property::command_group::hipSYCL_prefer_execution_lane{lane_id}},
  [&](cl::sycl::handler &cgh) {
   cgh.parallel_for(...);
});

The operation will be executed on the provided lane id modulo the number of lanes.
This can be used in circumstances where the multi_queue_executor does not schedule in an optimal fashion.

[ ] TODO: We should expose the configuration used internally using the settings API to the user instead of just hardcoding numbers.

@hipSYCL-ci-bot test

@fodinabor no benchmarks yet, but I don't expect there to be a lot of additional overhead. Maybe the early DAG optimization if you have DAGs with a lot of requirements, but in that case you can just reduce HIPSYCL_RT_DAG_REQ_OPTIMIZATION_DEPTH to prevent it from descending too far down the requirement tree. The MQE stuff is probably only noticable because of likely substantial performance improvements for small kernels because they can a) run in parallel and b) fewer cuda/hipStreamWaitEvent are submitted.


Return legacy Monitoring Config from legacy Monitoring Config handler

What does this PR (Pull Request) do?

[x] This PR fixes #5754

Which Traffic Control components are affected by this PR?

Traffic Monitor
Traffic Ops

What is the best way to verify this PR?

Run the TO v1 and TO v2 API tests
If this is a bug fix, what versions of Traffic Control are affected?

master (473d9c2422)
5.1.2 (RC2)
5.1.1 (and all 5.x.x through 5.0.0)

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] Bugfix, documentation is unnecessary, though the release notes for the next release should mention that it is the first release for which Traffic Ops can be used with a ATC 4.1.1 Traffic Monitor.
[x] This PR includes an update to CHANGELOG.md
[x] This PR includes any and all required license headers
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Anyway, is the intention of this PR to only change the behavior for the "legacy" monitoring API endpoint? Because in 4.0 I'm still seeing:

I'm not sure why the format change was even necessary in the first place, but this seems like it needs to be fixed in both TO and TM. Basically, TO API 2.x needs to return the original format, and 3.x needs to continue returning the new format. On the TM side, we need to properly "upgrade" the 2.x format into the 3.x format. Currently, it only looks like the "servers" field is upgraded properly from 2.x to 3.x.
Essentially, if we were upgrading from 4.1 to 5.0, we would need to be able to do both:

upgrade TO to 5.0 first, leaving TM at 4.1
upgrade TM to 5.0 first, leaving TO at 4.1

If we only fix TO to return the old format at the old API version, that only fixes the 1st scenario.

Ah, so the behavior of 2,0/cdns/{{name}}/monitoring wasn't matching documentation/expectations?
Then I think you're good

... so I think the 2nd scenario is already covered.

Oh, I was confused. @ocket8888's comment made it sound like the format was changed as part of v3, but it wasn't. So yeah, the 2nd scenario is definitely covered. Carry on 😄

Hmm I'm noticing that API v1/v2/v3/v4 responses for cdns/{name}/configs/monitoring are now identical. Removed the legacy handler in 749ba38b60.

Hmm I'm noticing that API v1/v2/v3/v4 responses for cdns/{name}/configs/monitoring are now identical. Removed the legacy handler in 749ba38.

Well, the config section may be the same, but the trafficServer section is different, because as of APIv3 the servers will have interfaces

Well, the config section may be the same, but the trafficServer section is different, because as of APIv3 the servers will have interfaces

From what I'm seeing, the Monitoring Config at the latest TO API version has been totally unchanged from 4.1.1 through master at f84ae27eda. It's identical, line for line. The "trafficServer" array using TO API 2.0 at RELEASE-4.1.1:
    "trafficServers": [
      {
        "cachegroup": "CDN_in_a_Box_Edge",
        "fqdn": "edge.infra.ciab.test",
        "hashid": "7825f580-26e7-476f-af8a-8d5adfe7f741",
        "hostname": "edge",
        "interfaces": [
          {
            "ipAddresses": [
              {
                "address": "<IP_ADDRESS>",
                "gateway": "<IP_ADDRESS>",
                "serviceAddress": true
              },
              {
                "address": "fc01:9400:1000:8::3",
                "gateway": "fc01:9400:1000:8::1",
                "serviceAddress": true
              }
            ],
            "maxBandwidth": null,
            "monitor": true,
            "mtu": 1500,
            "name": "eth0"
          }
        ],
        "port": 80,
        "profile": "ATS_EDGE_TIER_CACHE",
        "status": "REPORTED",
        "type": "EDGE"
      },

Let me know if you can find any differences, but from my testing, my diff is completely empty when diffing the whole Monitoring Config between different TO versions.

Never mind, forgot to snap. Re-adding the legacy handler...

Rebased to fix a merge conflict in CHANGELOG.md.

Setting the Health Threshold Parameters when converting to the legacy-format Traffic Monitor Config in 662cbc95ec, this is ready for review again.


Use Julia 1.0

As of 9ebb2abd134a62a590218554624d81176bfe3fd4 tests pass with latest version of Julia, 1.0.2.


[LSP] Extract method to module refactoring

The PR adds a new refactoring code action "Extract method to the new module".
The refactoring cuts out the method code piece and puts it into a new module with a unique name on top of the file, and update all call sites for a refactored method.
The code action can produce incorrect code and it's up to the user to fix newly emerging Sorbet errors
Motivation

New refactoring!
Test plan

See included automated tests.

@jez thanks for such a detailed review, appreciate that! I think I've addressed all of the comments, would you mind taking a look one more time?

@jez would you mind taking a look one more time?
I've disabled the feature for the instance methods and disabled the call site renaming for non-trivial cases. Also a signature and a method body now cut together, so no weird trailing whitespaces anymore!

@ilyailya heads up that I pushed two commits to your branch that were slightly too annoying to do as suggested edits.
If you don't like either of them, feel free to back the changes out.


private dir / deploy aws-lambda / directory structure

Error:
2024-02-23 19:48:27.222 ERROR   Error: ENOENT: no such file or directory, open './private/data.json'
    at readFileSync (node:fs:453:20)
    at getData (file:///var/task/dist/templates/private-folder-page.js:18:31)
    at PrivateFolderPage (file:///var/task/dist/templates/private-folder-page.js:8:22)
    at ib (file:///var/task/dist/rsdw-server.js:562:7)
    at jb (file:///var/task/dist/rsdw-server.js:581:46)
    at P (file:///var/task/dist/rsdw-server.js:700:16)
    at Object.toJSON (file:///var/task/dist/rsdw-server.js:618:15)
    at stringify (<anonymous>)
    at nb (file:///var/task/dist/rsdw-server.js:814:53)
    at kb (file:///var/task/dist/rsdw-server.js:842:7) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: './private/data.json'

Problem:
the current working directory of the deployed code is different to local dev environment
local: - the current working directory is project
project
   private
   src
   public

deployed - the current working directory is task
task
   dist
       private
       src
       public

Using readFileSync('./private/data.json', 'utf8') fails as it will expect the folder here ./srv/private
sample code from an async template:
const getData = async () => {
  const jsonData=JSON.parse(readFileSync('./private/data.json', 'utf8'))
  const data = {
    jsonData
  };

  return data;
};

Solutions:

add an additional parameter to the the new plugin to handle path transformation during build process
only allow to access the private directory in code by accession the WAKU config value for CONFIG_PRIVATE_DIR -  which can be manipulated by the deployment adapter and gets replaced with the the final directory path

Just move private under task.
That's what we do for other cloud deployments.
As we discussed elsewhere, this may feel like a hack. We revisit this in the future and if it's too confusing, we consider dropping it.
By the way, why do you have task/dist/src in the deployed folder?

The deployment tool serverless framework will build a zip from directories in the projectdirectory.
I can include the project/private directory in the zip on the top layer. I tried to avoid this as it breaks the clean separation between build for deployment and deployment. The manual process to simply create a zip from the dist folder and deploy to aws becomes also more complex as you have to think about adding the private folder.
I close this for now by moving the handling of this to the deployment process.


introduce perf formatting for ustack()/kstack()

This will allow ustack() and kstack() to be used as follow:
ustack(): default stack limit, default formatting
ustack(perf): default stack limit, Linux perf formatting
ustack(16): stack limited to 16 frames, default formatting
ustack(perf, 16): stack limited to 16 frames, Linux perf formatting
Default formatting looks like this:
Attaching 1 probe...

        lele+0
        __libc_start_main+231

        lele+0
        __libc_start_main+231

Linux perf formatting looks like this:
Attaching 1 probe...

	55e79dd4264a lele+0 (/home/mmarchini/lsls/main)
	7f92eda4bb97 __libc_start_main+231 (/lib/x86_64-linux-gnu/libc-2.27.so)

	55e79dd4264a lele+0 (/home/mmarchini/lsls/main)
	7f92eda4bb97 __libc_start_main+231 (/lib/x86_64-linux-gnu/libc-2.27.so)

It should be possible to add more formats in the future (for example, folded), as well as a custom string format.
TODO before landing

[x] Refactor
[x] Update documentation
[x] Update tests

Ref.: #430

ready to merge?

Yes

thanks!

This format is still missing an event line to precede each stack trace. Is that something we might want to consider adding for compatibility with perf script output?

@jonhoo no, {ku}stack print stacks only. The event line can be printed with printf(). Plus the perf script event line format has changed across kernel versions, and probably will change again, so trying to support it is supporting a moving target.

I agree with @brendangregg. Besides, building the line with printf() gives us more flexibility to create custom flame graphs or other custom graphs/reports.

Makes sense. I wonder whether an example might serve users well though? Though I guess if the ultimate goal is ustack(folded), then the event line becomes relatively less important (at least for flamegraph purposes).

I'm nervous about giving newbies a bpftrace script that does "perf script" output -- it'd be a lousy first impression for BPF. It'd be perf script, but worse (without the binary output efficiencies).
I want to get bpftrace emitting folded format (however we need to get it done) and show people that, since it's better than perf -- it uses in-kernel summaries. Afterwards we can show perf script output from bpftrace as a secondary option.


Properly deal with InterruptedException on the JVM

Copying the issue from https://github.com/typelevel/cats-effect/issues/181 because Monix suffers from the same issue.
We have our own NonFatal implementation because the standard one also filters things like ControlThrowable, which is pretty dumb.
However this means we are no longer catching InterruptedException, which is a problem.
The problem is that on top of the JVM, when you catch an InterruptedException, you can't just swallow it like any other exception. This is a problem:
try {
  operation()
} catch {
  case ignored: InterruptedException => /* BIG PROBLEM! */
}

What needs to happen is that we need to "restore the interrupted status". This can be done like this:
try {
  operation()
} catch {
  case ignored: InterruptedException =>
    // Restores interrupted status
    Thread.currentThread().interrupt()
}

So we need a NonFatal specific to the JVM that, upon catching InterruptedException, it restores its interrupted status.

Can we check it with Platform.isJVM, or should we have two separate sources?

@kubukoz
I'll admit I'm not yet too familiar with how Scala.JS converts code - I guess if  VirtualMachineError is ok then InterruptedException probably too but it would be good to check how it's resolved assuming all tests pass for Scala.JS

From what I see, InterruptedException is possible in JS world as well... then if it has to remain unhandled we'd need to have two separate sources for NonFatal js/jvm - @Avasil @alexandru does that make sense?


Added champion mastery apis.

As the API challange 2016 just started, I noticed that the champion mastery endpoints weren't included in this package yet.

i would love to see this merge. +1

Thanks for this! Will publish to npm asap


Remove deprecated code

In the Python translations we have the functions with the same names as Fortran. This is to make future translations easier. However, in the long term these deprecated functions will need removing.

 remove old code and clean up


Update Git to include sparse-checkout feature branch

We are merging the features/sparse-checkout-2.24.0 branch into vfs-2.24.0 in microsoft/git#222. Update our version of Git to match.

I'll wait until @mjcheetham has his installer fix stuff ready and merged.

I'll wait until @mjcheetham has his installer fix stuff ready and merged.

Nevermind, since we are not using YAML so we are good.


Expose "reset" functionality to GUI

Whilst working on https://github.com/firezone/firezone/pull/6382, I figured that we could expose the "reset" functionality to the GUI perhaps?
In an ideal world, Firezone is so robust that users never need to use this, plus they can achieve the same thing by signing out / in.
Maybe as some form of "expert setting"?

We can make this conditional on a field expert_commands stored in the settings. Those can then be enabled either by manually editing the settings file (JSON for Tauri builds, PList files for MacOS).

The preferences for the tunnel in macos is found ind SystemConfiguration/preferences.plist under the <key> dev.firezone.firezone.
Each config is saved as an entry on a  <dict> in a <key> <string> map


Toxic orb

Lost polish commit when pull last time

Sorry. Saw it yesterday evening but needed to check something first. Merged it now.


Error in user activation process

When I click over the link that the app send me to confirm my registration, I got an error

@eddymdz This error can happen if the APP_URL in the backend has an invalid value. Does it have ' http://localhost:8080/ ' as value?

@PabloBerrettoni thanks, let me check

@PabloBerrettoni the problem was related with CLIENT_URL: https://github.com/AilynMS/ailyn-monitoring-system/commit/cb952489efe1e714dfdbeac342af9ea1b8863beb


Pretrained resnext-101-64f-kinetics model

Hi,
I have seen you uploaded pretrained models using 64 frames for ucf101 and hmdb51.
Is there a chance you can upload a 64f model pretrained using kinetics only?
I would like to compare results between 16f and 64f, but in order to make a proper comparison I would rather use the pretrained model only on kinetics as well.
Thanks for the great work!

OK, I will upload the model later.
Please wait a moment.

Thank you very much!

I uploaded the file resnext-101-64f-kinetics.pth.

Thank you!


chore: Update the correct destination instance in docs.

Could you help us to update the README.md on 'packages/core/plugins/plugin_idfa' please?

@edsonjab Sorry missed the notification, updated it


Implement Get Object Function

Depends on #1 and #2

Function to get an object or row in the database

[x] Create the function to get the data from the database: e.g. get_object
Takes 3 arguments: object table, object ID (optional), parent ID (optional). Execute select statements. If ID provided you specify the ID and call the function to create an object dict of that type. If no ID, you create a list of object dicts for all rows returned and return that. Parent ID can be included in the latter. A switch statement can be used to choose which create_dict function (see below) will be used, based on the object table parameter.

[x] Create function to create a user dict:
Add all the row data to the dict, Then create another key 'Routines' and call the get_object function using the Routine Table and the users ID as the parent ID. This will create a List of routine dicts that belong to the user.

[x] Create function to create a routine dict:
As with above but create a key with the name 'Steps' and call get_object using the Step table and the routine ID as the parent ID to create a list of step dicts that belong to the routine

[x] Create function to create a step dict:
Add all row data to the dict.

[ ] Test all of these

8/7/2024: finished the functions, getting user object by id is returning none even though I can see it calling the correct sql statements and getting the right data. Need to look into how objects are constructed within the python code.


When will this be considered stable and hit nixpkgs?

The current situation is a bit sketchy, there is buildGoModule, which is not ideal and for good reason and then vgo2nix which seems to have gone unmaintained and its infrastructure in nixpkgs. Then this project, which unfortunately isn't yet in nixpkgs and requires its users to pull in another dependency. What are the blockers for this to get upstreamed, preferably before the next nixpkgs release.

There isn't any firm benchmark as for when this is mature enough. It needs more real world usage with real world issues being found before I'm comfortable with a 1.0.


Add maven wrapper plugin to the project

Is your feature request related to a problem? Please describe.
Similar to Gradle wrapper, provide a Maven wrapper for this project.  This enables users to have a fully encapsulated build setup provided by the project.
Describe the solution you'd like
There is wrapper plugin for maven (https://github.com/takari/maven-wrapper) which is going to be a default wrapper in Maven 4.0.
Adding this wrapper plugin to this project, makes life easier for users as they don't have to manage different versions of Maven locally.  This also helps the CI system not to worry about managing Maven versions as well.
Describe alternatives you've considered
None
Additional context
N/A

I'd prefer to wait till Apache Maven accepts maven wrapper as a contribution.

I'd prefer to wait till Apache Maven accepts maven wrapper as a contribution.

It is already accepted and released as part of maven 4 which is to be released yet.
https://github.com/apache/maven-wrapper-plugin
https://issues.apache.org/jira/projects/MWRAPPER/issues/MWRAPPER-13?filter=allopenissues
So, for this version of maven this is the plugin to be used.

It needs to be part of the official Apache maven release and looks like will require upgrade to maven 4.0. Relying on a project that is not backed by Apache Maven may limit our ability to upgrade maven version to the next minor release.

Closing as we will be moving to Gradle soon.


Doesnt work with<EMAIL_ADDRESS>

Currently the highest ajv version we can use is 8.6.3 any higher version breaks the addFormats that do not accept the Ajv instance anymore.
Do you plan an upgrade to support newest versions of AJV?

Could you please post the code sample?
ajv-formats is tested with the latest Ajv version, so it must be something specific that fails in the newer version, not a general lack of support.

I cannot really debug VSCode warnings, sorry.
Please check the installed versions - both ajv and ajv-formats should be the latest - and post tsc output here, if it generates any errors.
VSCode warnings can be happening for various reasons, and are always not a reliable indication that there is something wrong with the types.

This works here: https://runkit.com/esp/61a74fca5dd82f000846a30f
Tests use typescript, so the latest version of ajv-formats does work with the latest version of ajv. You can just try re-installing all dependencies and restarting vscode.

we're using ajv in our project and from npm ls ajv I can see many other modules that is also using it (having in it's deps) with varous versions. The error appears at the addFormats as the Ajv type comes from different places:
the import Ajv from 'ajv' is imported from node_modules/ajv/dist/ajv.d.ts but the Ajv type in the addFormats from node_modules/ajv-formats/node_modules/ajv/dist/core.d.ts
The<EMAIL_ADDRESS>reports the<EMAIL_ADDRESS>version installed in its dependency (the package.json in devDependencies has ajv set as ^8.0.0
Regarding the uninstalling/restarting it was first thing that I did to no avail:)

the import Ajv from 'ajv' is imported from node_modules/ajv/dist/ajv.d.ts but the Ajv type in the addFormats from node_modules/ajv-formats/node_modules/ajv/dist/core.d.ts

that should not be a problem as the former is the subclass of the latter, as ajv-formats can be used with different Ajv classes (one for each JSON Schema version), all being subclasses of the parent class defined in core.ts.
I would like to see tsc output, as I said VSCode extension you use may have some issues with it, but it’s not something I can support.

In my case, I had ajv 8.8.* under ajv-formats/node_modules and 8.6.* in node_modules, fixing this version mismatch also fixed TS compilation issues.

Me too, seems it was an issue with my yarn.lock.
yarn remove ajv-formats and yarn add ajv-formats fixed the issue for me.

I had the same issue (upgrade AJV broke TypeScript compilation). It seems that this matches #13, which #15 fixed a couple years ago. The above solutions worked: uninstall ajv-formats and reinstall.
However, I noticed that the package.json has ajv as a dependency and a peerDependency. Therefore, in the “broken” state, I had ajv-8.9.0 in the node_modules, but ajv-8.6.3 (previous version) under ajv-formats’ node_modules.
I do not have that intimate familiarity with peer dependencies, but I would have expected only peerDependency entry and NOT dependency entry. (The package may also have devDependency for its internal testing.) Can others help shed some light here?
Also, if it should only have peerDependency, the upcoming 3.0 release could ease the (breaking?) change for folks. Let me know if I should create a new issue, too. Thanks!

I'm currently encountering this issue. Here's the output of tsc for me:
$ project-root/node_modules/.bin/tsc
src/broadcast/middleware/validators.ts:12:12 - error TS2345: Argument of type 'import("project-root/node_modules/ajv/dist/ajv").default' is not assignable to parameter of type 'import("project-root/node_modules/ajv-formats/node_modules/ajv/dist/core").default'.
  Types of property 'opts' are incompatible.
    Type 'import("project-root/node_modules/ajv/dist/core").InstanceOptions' is not assignable to type 'import("project-root/node_modules/ajv-formats/node_modules/ajv/dist/core").InstanceOptions'.
      Type 'InstanceOptions' is not assignable to type 'CurrentOptions'.
        Types of property 'keywords' are incompatible.
          Type 'import("project-root/node_modules/ajv/dist/types/index").Vocabulary | undefined' is not assignable to type 'import("project-root/node_modules/ajv-formats/node_modules/ajv/dist/types/index").Vocabulary | undefined'.
            Type 'Vocabulary' is not assignable to type '(string | KeywordDefinition)[]'.
              Type 'string | import("project-root/node_modules/ajv/dist/types/index").KeywordDefinition' is not assignable to type 'string | import("project-root/node_modules/ajv-formats/node_modules/ajv/dist/types/index").KeywordDefinition'.
                Type 'CodeKeywordDefinition' is not assignable to type 'string | KeywordDefinition'.
                  Type 'import("project-root/node_modules/ajv/dist/types/index").CodeKeywordDefinition' is not assignable to type 'import("project-root/node_modules/ajv-formats/node_modules/ajv/dist/types/index").CodeKeywordDefinition'.
                    Types of property 'code' are incompatible.
                      Type '(cxt: import("project-root/node_modules/ajv/dist/compile/validate/index").KeywordCxt, ruleType?: string | undefined) => void' is not assignable to type '(cxt: import("project-root/node_modules/ajv-formats/node_modules/ajv/dist/compile/validate/index").KeywordCxt, ruleType?: string | undefined) => void'.
                        Types of parameters 'cxt' and 'cxt' are incompatible.
                          Type 'import("project-root/node_modules/ajv-formats/node_modules/ajv/dist/compile/validate/index").KeywordCxt' is not assignable to type 'import("project-root/node_modules/ajv/dist/compile/validate/index").KeywordCxt'.
                            The types of 'gen._scope' are incompatible between these types.
                              Type 'import("project-root/node_modules/ajv-formats/node_modules/ajv/dist/compile/codegen/scope").Scope' is not assignable to type 'import("project-root/node_modules/ajv/dist/compile/codegen/scope").Scope'.
                                Property '_names' is protected but type 'Scope' is not a class derived from 'Scope'.

12 addFormats(ajv);
              ~~~

Found 1 error.

error Command failed with exit code 2.

Here's a bit of additional potentially useful debug info:
❯ head -n 10 project-root/node_modules/ajv/package.json
{
  "name": "ajv",
  "version": "8.8.2",
  "description": "Another JSON Schema Validator",
  "main": "dist/ajv.js",
  "types": "dist/ajv.d.ts",
  "files": [
    "lib/",
    "dist/",
    ".runkit_example.js"

❯ head -n 10 project-root/node_modules/ajv-formats/package.json
{
  "name": "ajv-formats",
  "version": "2.1.1",
  "description": "Format validation for Ajv v7+",
  "main": "dist/index.js",
  "types": "dist/index.d.ts",
  "files": [
    "src/",
    "dist/"
  ],

My current workaround whenever I updated ajv
npm un ajv-formats && npm i ajv-formats

This often installs the same version of ajv-formats (because its version did not change), but its underlying node_modules now gets the latest ajv as a “fresh” install.

Alternatively, you could manually update the lock file’s two (for me) locations of ajv under ajv-formats (update version and integrity).

I've tried to use 3.0.0-rc.0 above with yarn and typescript, but I still get the incompatibility error below. From what I can tell, yarn will still install the version of ajv specified in its package.json because it is listed as a dependency.
src/compile_schemas.ts:64:16 - error TS2345: Argument of type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv/dist/ajv").default' is not assignable to parameter of type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv-formats/node_modules/ajv/dist/core").default'.
  Types of property 'opts' are incompatible.
    Type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv/dist/core").InstanceOptions' is not assignable to type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv-formats/node_modules/ajv/dist/core").InstanceOptions'.
      Type 'InstanceOptions' is not assignable to type 'CurrentOptions'.
        Types of property 'keywords' are incompatible.
          Type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv/dist/types/index").Vocabulary | undefined' is not assignable to type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv-formats/node_modules/ajv/dist/types/index").Vocabulary | undefined'.
            Type 'Vocabulary' is not assignable to type '(string | KeywordDefinition)[]'.
              Type 'string | import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv/dist/types/index").KeywordDefinition' is not assignable to type 'string | import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv-formats/node_modules/ajv/dist/types/index").KeywordDefinition'.
                Type 'CodeKeywordDefinition' is not assignable to type 'string | KeywordDefinition'.
                  Type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv/dist/types/index").CodeKeywordDefinition' is not assignable to type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv-formats/node_modules/ajv/dist/types/index").CodeKeywordDefinition'.
                    Types of property 'code' are incompatible.
                      Type '(cxt: import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv/dist/compile/validate/index").KeywordCxt, ruleType?: string | undefined) => void' is not assignable to type '(cxt: import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv-formats/node_modules/ajv/dist/compile/validate/index").KeywordCxt, ruleType?: string | undefined) => void'.
                        Types of parameters 'cxt' and 'cxt' are incompatible.
                          Type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv-formats/node_modules/ajv/dist/compile/validate/index").KeywordCxt' is not assignable to type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv/dist/compile/validate/index").KeywordCxt'.
                            The types of 'gen._scope' are incompatible between these types.
                              Type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv-formats/node_modules/ajv/dist/compile/codegen/scope").Scope' is not assignable to type 'import("/Users/chris/dev/honeycomb/packages/backend-scripts/node_modules/ajv/dist/compile/codegen/scope").Scope'.
                                Property '_names' is protected but type 'Scope' is not a class derived from 'Scope'.

64     addFormats(ajv);

The correct solution is to remove ajv as a direct dependency of ajv-formats and only retain it as a peer dependency and dev dependency - there is no reason for ajv-formats to specify ajv directly as a dependency as the downstream user will need to have it in their package.json and referenced from their code anyway.

Under non-typescript proyects, having both ajv on peerDependencies and dependencies it's also causing troubles. Please see #12 #47 #69 or search for 'undefined' within issues...


Needle spins crazy on first change

I update the value with onclick="gaugePS.value=200", onclick="gaugePS.value=250" etc.
On first click the value goes like 541245 and after animation to 200
On second click everthing is ok

Could you, please, provide more detailed piece of code to make me able to reproduce this behavior?

`
570
583
830
`

Thank you for contribution!
Yes, there is a problem with this example. I will add some additional dumb checks which would prevent of these kind of problems in the next release. BTW, you can fix this issue on your side simply changing the type of the initial value you assign to the gauge by modifying this line:
gaugePS.value = "510";

to this one:
gaugePS.value = 510;

Hope it helps!

ok that was to easy :)
you can see my working example on my demo page http://new.mcchip-dkr.com/chiptuning-fahrzeug-datenbank
You need to select a car in the selects.
PKW -> Mercedes Benz ->C-Kl. (W204) -> 63 AMG 6.3 V8  457PS
Now you could see a button "Stufe 1", click on it an switch to "Stufe 2" or something else.

@stefanpoensgen, That looks really awesome! Are you satisfied with gauges?

yes it's awesome. exactly what i need for my new website. and it runs so smooth even on mobile devices.
and i could export it to pdf thats really cool. mercedes-benz-c-kl.-w204-63-amg-6.3-v8-stufe-6-mc830_print.pdf
But i want to set font to italic mode and could not find how to archieve that

For the moment it is not that easy to achieve... The only possible way I could imagine is that you may use the font which has italic glyph, but it is too crappy.
I will add a bit more advanced font-styling features in the next release, so you would be able to do that.

That would be nice :+1:

@stefanpoensgen Release 2.0.6 is published moments ago. You can now configure font-style and font-width on gauge text elements. More info in docs

Fixed in release 2.0.6


Awesome book using ES6

I have made it using ES6

Thank you for your inspiration and constructive feedback.


Change class methods to private #57

Branch has a merge conflict, can you please merge the latest code from thenewboston-developers:master to your branch ?

Its merged, but I will have to fix flake8 errors that I got from it:
FAILED tests/banks.py::FLAKE8
FAILED tests/validators.py::FLAKE8
FAILED tnb/banks.py::FLAKE8
FAILED tnb/base_client.py::FLAKE8
FAILED tnb/validators.py::FLAKE8

Conflict is because of fetch_multiple_page function present in your branch but its been removed in the master.

Yes I know, I removed it from my branch. But when I run pytest after the merge I am getting failed tests for flake8.

Hi @makaramkd , please share your account number so that we know where to send your coins. Every accepted PR gets paid. If you do not yet have an account then please download the account manager here https://thenewboston.com/download and follow these steps https://thenewboston.com/account-manager/create-an-account to create an account.

Hi @makaramkd , please share your account number so that we know where to send your coins. Every accepted PR gets paid. If you do not yet have an account then please download the account manager here https://thenewboston.com/download and follow these steps https://thenewboston.com/account-manager/create-an-account to create an account.

Hi, this is my account number:
b0302a7a0c02df1a5d298122de7c22a0bdd2394de75d1ae724f51a85bd13128e


Fixes for numpy 2.0 support

edgetest is failing on numpy 2+ as seen here: https://github.com/capitalone/datacompy/actions/runs/9811778718/job/27094423048
Need investigating and remediation.

Hi 👋
Any updates on support for numpy 2?
I noticed that latest release 0.14.0 from last week still pins numpy on version 1
A version with support for numpy 2 (preferrably including numpy 2.1) would be greatly appreciated, thanks!
Thanks!

BTW please also bump pandas to allow 2.2.3 (or 2.2.x, possibly <2.3.0 but no reason not to allow patch versions) without a pip conflict, thanks!

@filbranden thanks for the reminder. There are some weird conflicts between Spark, Pandas, and numpy at different versions. The matrix quickly grows out of control. The main culprit is: SparkPandasCompare. I'm mulling the idea of dropping it all together from the package in favour of the SparkSQL variant. Also numpy 2+ I believe has a Python 3.10 min version.

@ak-gupta @jdawang @gladysteh99 would appreciate your thoughts and opinions here.

Thanks!
numpy 2.0 has Requires-Python: >=3.9, numpy 2.1 dropped Python 3.9 so numpy 2.1 is Python 3.10+


Prevent admin user from adding duplicate eligibility or visibility conditions

Describe the bug
When editing a program, an admin user is able to add duplicate eligibility or visibility conditions.
To Reproduce
Steps to reproduce the behavior:

As a CF admin, go to the Programs dashboard.
Click "Edit" on a program block.
Click "Edit Visibility Condition".
Select a question and click "Add condition".
Select an operator from the dropdown in the 3rd field.
Select or input a value.
Click "Add values".
Select the same value as the you did previously.
Click "Save condition".
See the identical visibility or eligibility conditions.

Expected behavior
Validation catches the duplicate entry and prevents the user from saving the duplicate condition.
Screenshots

Desktop (please complete the following information):

OS: iOS
Browser: Chrome

@sijiayam This is one of the improvements we discussed.


Fix StereoTrigger non-deterministically discarding LST-1 in prod6 files

This was one of the weirder bugs I have ever tracked down. The symptom was that in consecutive runs of ctapipe-process on the same input file, sometimes LST-1 was missing from the output completely.
Tracking it down to the SoftwareTrigger class, which used a mixture of using TelescopeDescription and its string representation for storing and looking up things.
The dict _ids_by_type was the culprit, its content depended on the hash of str(TelescopeDescription), which was random, since hash of strings are random for security reasons in python.

Can you think of a test that could catch this problem?
Telescopes being silently dropped from the trigger is quite serious, and worrying it was not caught for two years.

This condition only happens with the new configuration of Prod 6, before all 4 LSTs were identical.
We haven't really worked on anything Prod 6 yet, it's not even finished simulating.

I'd prefer to fixing this the way I do it here as the other change would require us to do a 0.22 and adapt configuration files.
With the fix at it is now, we can just publish an 0.21.1 without adapting configuration files.
I will add a test that tests for the bug.

Rebased and changelog added, please approve again @Tobychev


fix: change background color #128

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #128  (issue, if applicable)
Summary:
Added white background color to default state.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Version bump to v2.1.0

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3e3939b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   87.52%
=========================================
  Files             ?       15
  Lines             ?      529
  Branches          ?       86
=========================================
  Hits              ?      463
  Misses            ?       54
  Partials          ?       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3939b...0436fc0. Read the comment docs.


JSON collapse

I'd like to replace the current JSON display library "KelpJSONView" with jJsonViewer, which among other features can collapse and expand JSON object and array children.
This would significantly enhance the readability of long responses and is probably an alternative to your pagination idea from #31
I'll attempt this for my personal build now and will submit a PR once I'm confident it works.

Mentioning #43

@mastacheata I can see that your directive here might not be properly followed by new JSON engine: https://i.imgur.com/hlhIsUc.png
https://i.imgur.com/Rl0lmdz.png
No line numbers are displayed. Can you please look what's up with that?
I think I'll merge this then... even though it seems resource intensive when collapsing.

Also, if we press 'SEND' many times while staying on 'Highlighted' screen, this is what we see: https://i.imgur.com/DWh6ZKx.png

That is a known bug.
I thought I had updated the pr to fix that already, so that should only be a matter of finding the right commit.
Will look into it on Monday, I guess.
Gruß,
Benedikt Bauer
Am 8. Juli 2016 11:33:24 MESZ, schrieb Paul<EMAIL_ADDRESS>
Also, if we press 'SEND' many times while staying on 'Highlighted'
screen, this is what we see: https://i.imgur.com/DWh6ZKx.png

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/odin-public/RESTClient-APS/issues/42#issuecomment-231317055

Ok the second issue is fixed. Missed adding that fix in the rebased PR.
The first one is a bit tricky, though. Either I can find a way to display continuous line numbers through multiple stacked lists or I'll need to change the jjsonviewer to print the line numbers directly.

So, the newest commit should have the line numbers and a minor performance boost.
I don't think, there's room for much to gain anymore.
New build can be found on my own build server:
https://teamcity.ymoq.de/guestAuth/app/rest/builds/id:376/artifacts/content/restclient-aps.xpi

This will be merged as it is. Still I've noticed something minor:

The first line has broken indentation. And it seems to be due to it being handled similarly to all subsequent lines by the engine, which leaves some space on the left for collaps/expand sign. That seems internal for that engine, but if you know how to fix that, you still have time before I merge this.

Also what about these commits? can you please make sure that the 'jjsonviewer' branch includes everything we need?

The lower 3 were squashed before creating the Jjson branch. The last ones are part of the merge request (you can see that github adds any additional commits into the same branch to the pr after creating it.
Gruß,
Benedikt Bauer
Am 13. Juli 2016 12:05:40 MESZ, schrieb Paul<EMAIL_ADDRESS>
Also what about these commits? can you please make sure that the
'jjsonviewer' branch includes everything we need?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/odin-public/RESTClient-APS/issues/42#issuecomment-232312959

I'm working on the develop branch and only cherry pick commits into the Jjson branch when development is done. That is because my develop branch contains unrelated changes as well.
Gruß,
Benedikt Bauer
Am 13. Juli 2016 12:05:40 MESZ, schrieb Paul<EMAIL_ADDRESS>
Also what about these commits? can you please make sure that the
'jjsonviewer' branch includes everything we need?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/odin-public/RESTClient-APS/issues/42#issuecomment-232312959

So I should merge only what's in PR, correct? What about the first line, any info?

That is correct. I'll check that first line issue any minute now.

The issue about the top-level elements collapser is now fixed in a way.
The collapsing/expanding logic doesn't work on the top-level element. (It also makes no sense to collapse that as you wouldn't see anything anymore)
So I removed the marker and the different cursor from the first expander/collapser.
Change is in the jjsonviewer branch and XPI build available at https://teamcity.ymoq.de/guestAuth/app/rest/builds/id:384/artifacts/content/restclient-aps.xpi

@mastacheata Thank you very much for the effort. Again, you can skip builds when you commit code, I will be using my own builds anyway since ultimately it's up to me to check that this exact code is working.

Well, I have the build server, It's free and I need to build my code anyways to see if it actually works.
So linking to the build is the easiest way to see if we're both on the same page with regard to the expectations.


question about Store function return type

I was wondering why the store function looks like:
Action => State => (State, Option[F[Unit]])

vs
Action => State => (State, F[Unit])

Since we know that F[_]: Concurrent and Concurrent extends Applicative so we could return F[Unit] via Concurrent[F].unit instead of None.
There is possibly an efficiency motivation, but if there isn't, I think the simpler type signature would be cleaner to use.

Good point! In fact, I've had doubts about this choice myself again recently. IIRC it was indeed motivated by efficiency: there is a supervisor.supervise(...) call for every Some(effect) and since most actions (in my experience) are pure state updates, this seemed wasteful. It was likely premature optimization and I'm open to change it.

I think you could internally check if the value == Concurrent[F].unit and if it does skip it. I don't see how that could be unsafe but would get you the optimization you are after with a cleaner API.
You could cache the unit value so that would be allocation free.

If we are after efficiency it seems like we want that inner function to be (Action, State) => (State, ...) since the current version has to allocate a new function on each action which we could avoid.

If we are after efficiency it seems like we want that inner function to be (Action, State) => (State, ...) since the current version has to allocate a new function on each action which we could avoid.

I think more important than the extra allocation is whether we prefer
  case Action.Foo() => _.copy(foo = 17) -> F.unit

or
  case (Action.Foo(), state) => state.copy(foo = 17) -> F.unit

I'm undecided... 🤔

I think you could internally check if the value == Concurrent[F].unit and if it does skip it. I don't see how that could be unsafe but would get you the optimization you are after with a cleaner API.
You could cache the unit value so that would be allocation free.

That's a nice idea and would certainly work for cats.effect.IO where unit is stable (no need for caching either since it's a val). There are no guarantees in general, however, as Applicative#unit is a def, or am I missing something?  I admit it's silly to worry about this since it will always be IO in practice. In any case, I think we should remove the Option wrapper. It's significant source breakage but at least it's localized to the store constructor and can be migrated fairly mechanically.

Applicative.unit is a def, but the idea is that it should be cached, otherwise pure(()) is just as good. The point of the method is to have the opportunity to reduce allocation (well, and maybe nicer syntax).

There's a PR for this now #224. Would you be willing to review?


fix syntax

Checklist
All items have to be completed before a PR is merged

[x] Adhere to Contribution Guidelines
[ ] Updates to Decision Records considered?
[ ] Updates to documentation at DX@Scale Guide considered?
[ ] Tested changes?
[ ] Unit Tests new and existing passing locally?

Codecov Report

Merging #1095 (0394b64) into develop (6a444e5) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0394b64 differs from pull request most recent head 09966e4. Consider uploading reports for the commit 09966e4 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1095   +/-   ##
========================================
  Coverage    60.61%   60.61%
========================================
  Files           54       54
  Lines         1785     1785
  Branches       379      379
========================================
  Hits          1082     1082
  Misses         703      703

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[DNM] update to protobuf 3

The protocol of Merge bases on protobuf 3, so let's upgrade it.
See also pingcap/kvproto#208

/run-integration-tests

LGTM.

PTAL

ping

@overvenus

/run-all-tests


Fix table of content link styles

Context
We are using RedCarpet to render our markdown files to html. RedCarpet is not adding the relevant govuk classes to links.
Setting $govuk-global-styles to true, means that paragraphs (<p>) and links (<a>) can be styled to look like govuk without explicitly having to apply the govuk-body and govuk-link classes.
Before

After

Changes proposed in this pull request
Guidance to review

We are using RedCarpet to render our markdown files to html. RedCarpet is not adding the relevant govuk classes to links.

Is the issue with the table of contents links or with other links? They are generated in different ways.

For context, the Markdown body is rendered using https://github.com/DFE-Digital/get-help-with-tech/blob/main/lib/govuk/markdown_renderer.rb which sets the right classes.
The table of contents could potentially be done using a custom renderer as well but that would basically involve re-writing the Redcarpet out-of-the-box functionality which felt like overkill. The TOC is wrapped in a div, .app-table-of-contents, which is used in other places to fix styling.

I think we should apply styles only to the TOC container. Not sure what effect enabling global styles will have now.


Can I validate again after the data was posted?

I need to post data first to check whether the data exist. If exist, I will know the id of that 'input'
so I tried to do sth like this
ajax.post({data}, (res)=>{
  Vue.set(validation.$error[res.id].only, true)
})

mean while in HTML
existed

but failed
or may be I just did the wrong way?

Closing Vue 1 compatible version issues. Async validators work in version 2


[Help Wanted] Adjust quality setting for images

If you're interested please comment here and come join our "Native Mobile Apps" channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.
New contributors please see our Developer's Guide, specifically for machine setup.

Notes: Jira Ticket
Change the quality setting for images from 0.5 to 0.7.
https://github.com/react-community/react-native-image-picker#options

PR: https://github.com/mattermost/mattermost-mobile/pull/537


⚠ Bofrost.at has degraded performance

In 1e2b83d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1399 ms

Resolved: Bofrost.at performance has improved in 6e83c1f after 8 minutes.


Take multiple VPC CIDR ranges into account

A VPC can have multiple CIDR ranges due to expanding an existing VPC.  Take this into account.

I'm closing this issue as the network diagram functionality of CloudMapper is no longer being maintained.  Other features of CloudMapper, such as the audit functionality, is still maintained. If someone is interested in maintaining the network diagram functionality they can look at the issues tagged unmaintained_functionality for all the issues related to this that have been closed as they will unfortunately not be worked on by me.


[storage] arb_blocks_to_commit: rely NOT on the DB

Motivation
We intend to make the DB dump, as in save whatever the upper layer asks to save, potentially losing the ability to calculate any hash. This removes the dependance on the DB's ability to calculate any Merkle hash, instead, the test helper being changed here relies on the in mem merkle tree algorithms directly.
Have you read the Contributing Guidelines on pull requests?
 The DiemDB knows how to map those results to binary KVs. The SchemaDB puts the KVs to RocksDB.

/land


usage not allowed in this context

https://community.shopify.com/c/Technical-Q-A/Include-usage-not-allowed-in-this-context-in-product-page-Debut/td-p/598022/page/2
https://help.shopify.com/en/themes/liquid/tags/theme-tags#render
The include tag breaking change might catch some people. Shopify has changed from 'include' to 'render' for sections but slate does or doesn't support it?
Either way, broke our theme. If you get the error do below.
Don't use the latest
{% render 'section-name %}
use the soon to be deprecated
{% include 'section-name %}

You can upload liquid files with the render tag using Slate, but if you use render the snippet can't use include anywhere down the chain.

I've been using {% render 'snippetName' %} within Slate for quite some time now and haven't had any issues. I think you'll find the fundamental change between how {% include %} and {% render %} work is more than likely the root cause of your issue. When you include a snippet it's aware of your template context, but when you render a snippet it's only aware of any data you pass to it or that is included in the snippet already.