Cruelty to animals

Say you torture a wild animal. How can you be prosecuted for this? The animal cannot consent to your prosecution. It has no owner.

Animal cruelty is indeed an issue, but unprecedented in a Constitution. I'd be interested in pursuing it, though.

We will have to have a judicial practice regarding torture of animals and/or laws. Animals are clearly not objects, but they are also not Natural Persons, because they can't ask for their personhood and can't defend it coherently. They are entities capable of feeling pain and possibly, likely of suffering. The judicial practice and/or law within the confines of the constitution will have to define the details. The new Constitution draft allows through our "Commerce Clause" to legislate if there are clearly present serious negative externalities. It is thinkable that those would pertain to animals, not just to humans. Does this make sense?

Please reopen the issue if you have more question. We have reviewed the constitution, you can see the new version here: https://docs.google.com/document/d/1RYgEHcb2oMgYJOa2MWUxe8E0aHRIgDpsiMG21MACIVg/edit#heading=h.yur44cl44s61
You can leave there your comments.


Setting light colour with {color: 'ffffff'} sets light to an orange.

Hey!
Whenever I set my light's colour through:
await tradfri.setDeviceState(65541, { color: 'ffffff' });

It sets the colour instead to an orange, '#efd275', specifically.
I can change states through setDeviceState, but not brightness, and using colorX and colorY worked.
I had a weird issue before, where after adjusting the brightness on the dimmer steering device, it sort of glitched in and out of the colour I set, and the orange-y one it seems to love so very much.

Also, if brightness is specified in the newState parameter, no change occurs.

I realize now that this project is old, and unmaintained.
For anyone stuck, as I was, I ended up using node-tradfri-client.


Bunny isn't handling unexpected disconnections properly

When bunny is disconnected from RabbitMQ an exception is being thrown when attempting to flush the write buffer.

Bunny\Exception\ClientException: Broken pipe or closed connection.

The issue is that that exception is being thrown via the __destruct method, which always creates a fatal error in PHP.

Attempting to throw an exception from a destructor (called in the time of script
termination) causes a fatal error.

http://php.net/manual/en/language.oop5.decon.php#language.oop5.decon.destructor

Reference #26

I have same problem. When i restart my RabbitMQ server, my php-daemon down with Fatal error.
Fatal error: Uncaught Error: Call to a member function done() on null in /vendor/bunny/bunny/src/Bunny/Client.php:56

Stack trace:
#0 [internal function]: Bunny\Client->__destruct()
#1 {main}
  thrown in /home/fantom/work/proj/okeyno/monorepo/parsers/vendor/bunny/bunny/src/Bunny/Client.php on line 56

Any updates on the issue so far?


⚠ Spryr has degraded performance

In 5fed691, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4531 ms

Resolved: Spryr performance has improved in 690c3d5 after 8 minutes.


hw: Moving software devices creation code from BSP to pkg_init.

Recently all peripheral device creation code was moved from hw/bsp/board/src/hal_bsp.c to hw/mcu/manuf/variant/src/mcu_periph.c. This prevents replicating code throughout BSPs.
This PR moves soft peripheral(i.e. soft pwm, uart bb) code to hw/mcu.

soft PWM and UART BB were not moved to MCU package because they are not MCU peripherals so it's up to BSP to provide those. I did not remove them from any BSP just so existing functionality is retained but tbh I think we do not need soft peripherals in standard BSP-s unless e.g. MCU lacks certain peripheral implemented in hardware. and also for this reason I did not add any soft peripheral to Dialog's BSP.

Completely agree, in fact I suppose we can move this code from the hal_bsp.c files into (optional) sysinit package initialization functions on those drivers' packages while maintaining the mynewt vals which include the packages on the BSP dependencies(not to break compatibility for now).

Now both devices are created on sysinit, UARTBB_0 and SOFT_PWM macros are kept in the BSPs' syscfg so we don't break compatibility until next release. UART bitbang was a added a baud rate restriction to its syscfg.


--connection param isnt working?

so i have two db configs keys one is mysql, one is restore-db.  i am using spatie to do a backup of mysql and then using this package to db defined in restore-db key.
when i run this command LOCALLY it SEEMS to be working fine.
 artisan backup:restore --disk=s3 --backup=latest --no-interaction --connection=restore-db
but on staging what it is doing is IGNORING restore-db, and restoring to db defined in mysql..

Have to do some digging here. Maybe that's related to #22 and we somehow mix up connection and driver.

I'm not able to reproduce this issue.
In #20 we've updated the command to show the exact connection information in the confirmation dialog.
We have tests that assert that the right connection is used and shown to the user.
By using --no-interaction Laravel/the command doesn't ask for confirmation and just proceeds with restoring the backup. Could you share the output you receive when running the command without ---no-interaction?
php artisan backup:restore --disk=s3 --backup=latest --connection=restore-db

Closing this issue as I'm not able to reproduce this issue.
Feel free to add a comment with more details if you still encounter this issue.


Tasks should run dependsOn before hashing inputs

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
https://github.com/JavaScriptBach/turbo-caching-bug
What package manager are you using / does the bug impact?
Yarn v2/v3/v4 (node_modules linker only)
What operating system are you using?
Linux
Which canary version will you have in your reproduction?
1.13.3-canary.4
Describe the Bug
If I have a task A whose input is a generated file produced by another task B, I have to Turbo task A twice before it gets cached.
What I think is happening
I think it's because on the first invocation:

Turbo hashes the input, but the generated file doesn't exist yet.
Turbo runs the dependent task, which produces the generated file
Turbo runs the original task and stores it under the now-stale hash.

On second invocation:

Turbo sees that the generated file now exists, so the hash is different from before, therefore it runs the original task again.

Why I think it's a bug
In order to obtain correct caching behavior, I currently have to exclude all generated files from the input. This is non-intuitive because the generated files are conceptually inputs to my task. Furthermore, I've already told Turbo that it depends on my codegen task.
It would be nice for Turbo to handle this, perhaps by running all dependsOn tasks before hashing the inputs to the original task?
Expected Behavior
Everything is cached after running Turbo once.
To Reproduce
See the linked repo.
Additional context
No response

Here's an example of 3 sequential turbo runs from the linked repository. You can see how it takes 3 runs to get to FULL TURBO:
$ turbo my-test --summarize
• Running my-test
• Remote caching disabled
my-codegen: cache miss, executing fb830814bce3d882
my-codegen:
my-test: cache miss, executing 2ef6da69cc2b018d
my-test:

  Tasks:    2 successful, 2 total
 Cached:    0 cached, 2 total
   Time:    373ms
Summary:    /Users/peplin/dev/turbo-caching-bug/.turbo/runs/2fejXqPcSUhLBGZsQgZ3Flk77ml.json

$ node_modules/.bin/turbo my-test --summarize
• Running my-test
• Remote caching disabled
my-codegen: cache hit, replaying logs fb830814bce3d882
my-codegen:
my-test: cache miss, executing fcb34ccdb1cf4377
my-test:

  Tasks:    2 successful, 2 total
 Cached:    1 cached, 2 total
   Time:    242ms
Summary:    /Users/peplin/dev/turbo-caching-bug/.turbo/runs/2fejY73vyb4eLqszBlFWviHymzE.json

$ node_modules/.bin/turbo my-test --summarize
• Running my-test
• Remote caching disabled
my-codegen: cache hit (outputs already on disk), replaying logs fb830814bce3d882
my-codegen:
my-test: cache hit, replaying logs fcb34ccdb1cf4377
my-test:

  Tasks:    2 successful, 2 total
 Cached:    2 cached, 2 total
   Time:    73ms >>> FULL TURBO
Summary:    /Users/peplin/dev/turbo-caching-bug/.turbo/runs/2fejYAIPKlkQD5auUDsWA7FLt2M.json

Here are the 3 summary files:
1.json
2.json
3.json
1.json does not include my-codegen.txt in its inputs, so the cache hash is different than run 2. I would expect the first run to be a cache miss, but with a generated hash that matches the second run.

Yeah, I think I might have a similar problem but for the codegen-task is in the same package, e.g. using:
{
  "$schema": "https://turbo.build/schema.json",
  "extends": ["//"],
  "pipeline": {
    "generate": {
      "outputMode": "new-only",
      "inputs": [
        "src/**/*.yml"
      ],
      "outputs": ["src/**/*", "!src/**/*.yml"],
      "cache": true
    },
    "build": {
      "outputMode": "new-only",
      "inputs": [
        "!src/**/*.yml"
      ],
      "outputs": ["lib/**"],
      "dependsOn": ["generate"],
      "cache": true
    }
  }
}

I also ran into this issue and made a repro of my own before I found yours: https://github.com/mattico/turborepo-repro
I can verify this issue still exists with version 2.0.15-canary.4.

Just met this issue. Confirming that 2.1.2-canary.0 is affected.


Looks like the WindowsVersionList is out of date again.

https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/inf2cat
What's the version identifier of Windows Server 2019 (1809)?

Hi @zjzhex, thanks for reaching out.  I believe 1809 is RS5, which does appear in the table with version identifier ServerRS5_X64.

Hi @tedhudek, thank you for the clarification!

Hi @tedhudek, thank you for the clarification!


New Crowdin translations

Enjoy!

Hey @teolemon,
Your changes looks good to me!

Hey @teolemon,
Your changes looks good to me!

Hey @teolemon,
Your changes looks good to me!


Add Time to the list of permitted classes for YAML

Detailed description
Nanoc 4.12.4 on Ruby 3.1.0 fails to parse metadata for pages if it contains a timestamp.
Nanoc::DataSources::Filesystem::Errors::UnparseableMetadata: Could not parse metadata for /path/to/article.yaml: Tried to load unspecified class: Time

This change adds the Time class to the allowed objects.
To do

[x] Tests

Related issues
#1560

I removed these to-do items since this PR does not introduce new features.

Documentation
Feature flags

Thank you! I added a test and merged it manually.

This is now released in Nanoc 4.12.5.


Select remote datacenter when not found locally

Datacenter IDs are now being inserted into all blob IDs.
Using this information, if a blob is not found in the local DC, it should be possible to target its original DC.
The change sorts replicas based on the order of (local -> original remote -> other remote) in OperationTracker initialization.

Could you add a description to this patch (you could add one when you do a git commit as that shows up here).
You could also reference the associated issue, I think it is this one: https://github.com/linkedin/ambry/issues/637

Codecov Report

Merging #827 into master will decrease coverage by 0.1%.
The diff coverage is 61.29%.

@@             Coverage Diff              @@
##             master     #827      +/-   ##
============================================
- Coverage     66.78%   66.67%   -0.11%
+ Complexity     4157     4155       -2
============================================
  Files           354      354
  Lines         27218    27240      +22
  Branches       3441     3444       +3
============================================
- Hits          18178    18163      -15
- Misses         8103     8132      +29
- Partials        937      945       +8

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com.github.ambry.router/DeleteManager.java
87.91% <ø> (ø)
15 <0> (ø)
:arrow_down:

....github.ambry.clustermap/StaticClusterManager.java
76.57% <0%> (-1.05%)
81 <0> (ø)

...thub.ambry.clustermap/CompositeClusterManager.java
68.42% <0%> (-1.85%)
19 <0> (ø)

...ain/java/com.github.ambry.router/GetOperation.java
96.42% <100%> (+0.06%)
20 <0> (ø)
:arrow_down:

...java/com.github.ambry.router/GetBlobOperation.java
90.77% <100%> (ø)
33 <0> (ø)
:arrow_down:

...ain/java/com.github.ambry.router/PutOperation.java
89.74% <100%> (-0.65%)
71 <0> (-1)

.../com.github.ambry.router/GetBlobInfoOperation.java
82.71% <100%> (+0.21%)
34 <0> (ø)
:arrow_down:

....github.ambry.router/AdaptiveOperationTracker.java
95.91% <100%> (ø)
6 <0> (ø)
:arrow_down:

.../java/com.github.ambry.router/DeleteOperation.java
91.11% <50%> (-2.13%)
43 <0> (-1)

...m.github.ambry.clustermap/HelixClusterManager.java
94.38% <66.66%> (-0.3%)
34 <0> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fa512...5c618b6. Read the comment docs.

Just noting what we discussed offline the other day: we want to introduce a config that will state whether other colos should be contacted if a blob is not found locally nor in the originating datacenter. The config will default to do-not-contact-other-colos, but having it gives us an ability to do quick rollbacks if needed.

Suggested the same thing in #637. I'd prefer that the change be split into two however. One change to just sort with the originating datacenter given preference and a second to have the config and do the do-not-contact. That change is a bit more involved since the OperationTracker is only told about "success" or "failure" in the current code. NotFound and anything other than NoError is considered a "failure" IIRC. Now it will need to differentiate b/w NotFound and other failures.

On the point of errors - I think we should take a step back and rethink our approach of reaching out to an exhaustive list of replicas for a partition.
If we have, say, 4 colos with 3x replication in each, the point of the 12x replication is not fault-tolerance. The point is performance (so that reads and writes can work out of the local colo most of the time).
Although we can tolerate up to 11 failures (or 10 or whatever is the math after taking success.target values into consideration) because there are 12 replicas, the benefit of doing that is too low to warrant the bother. The reason to potentially reach out to all 12 for an operation is not fault-tolerance, it is to support cross-colo read-after-write consistency - for which, previously, the router had to consider all 12 as candidates. With this patch, the candidate list can be safely limited to local + originating.
If we can agree on that, I think the change is limited to OperationTracker not inserting non-originating remote replicas into the list of candidates (conditional on the config value).

Based on @vgkholla and @pnarayanan's comments, we have two scenarios:

General case, it's better to use 12x replicas for fault-tolerance.
Read-after-write case, we need local + originating only.

Looks like if we do the change discussed last week, it applies to both above scenarios.
To 1, we probably don't want that.
I opened issue #832 to track it.

What if local DC == originating DC? The potential change limits request to one DC only, is this a risk?

@dharju Yingyi's remote get metric change may depends on this PR, which exposes datacenter id/name to OperationTracker.

@pnarayanan
The difference between our discussion and @vgkholla  suggestion is:
In the case local == originating,
You suggested the order:  local good > local bad > other good > other bad.
@vgkholla suggested: local good > other good > local bad > other bad. The reason is replica down and up can be detected by helix quickly. This unifies all the cases, making the logic easier: always arrange 6(configuration) replicas with the preference of local > originating > other.
The difference code:
https://github.com/linkedin/ambry/pull/827/commits/5a98b88f376927fc69bbef19ea4282cf45eb01b9

@pnarayanan @vgkholla Can one of you help review this when you got a time?
@asinghai suggested to push this change.

@zzmao This PR seems to have conflicts with the master, could you resolve them and update it?

@pnarayanan Some changes were made: routerConfig, more strict tests. Please review it when you get a time. Let's try to merge it this week.


Feature/dick/anomaly score normalization

Description

This PR adds anomaly score and anomaly normalization. A substantial refactor was needed to make this functionality compatible with the TorchMetrics evaluation design.

Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Adds NormalizationCallback, which normalizes the predicted scores and error maps based on the distribution of normal data in the training set.
A test case was added for the normalization callback, which asserts that the (image-level) performance with and without normalization is the same.
Normalization is repeated with numpy operations in the post-process method of the openvino inferencer.
Adaptive threshold and training set statistics are now implemented as TorchMetrics classes, which de-clutters the base anomaly module and allows automatic saving and loading of the values in the model's state dict.
F1 score is now computed by using TorchMetrics F1 class configured with the computed threshold, instead of OptimalF1.
Our custom FeatureExtractor was replaced by torchvision's create_feature_extractor. For this I had to bump up the torch and torchvision versions.

Checklist:

[x] My code follows the pre-commit style and check guidelines of this project.
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing tests pass locally with my changes

Thanks for the review @samet-akcay. I addressed your comments and updated the PR

Maybe we could use version 0.2.3 for this one?


Add --workingdir argument

Useful for running multiple instances, --workingdir <folder path> points the server to a custom working directory location, where it will look for config.json and state.json files.
This solves the issue of storing a separate 70MB binary for each instance

Looks good 👍! I'll add the readme instruction for the new option myself, thanks for contributing.


Write up conclusions of analyzing Crosslink against our best known attacks

This can be merged into #82.


Remove parseXXX helpers from module

Quick searches on github reveals that despite this module being in use in a lot of places, nobody currently uses these helper functions. This makes sense, because the module is most useful for quick modifications of other stuff before handing on modified values to the RTC API.
In my opinion. Having these functions in the library only inflates the payload code that is often sent to the browser. It's not essential to the library and should be removed.
New helpers are not going to be added to this library, so the helpers are kind of awkwardly standing on their own anyway. Killing them makes the library more focused on what is actually important.
If anyone have any objections, voice them here. Otherwise this will likely be the only real big change in 2.0.

On second, thought. These don't really hurt anyone.


Add support for specifing super type of type parameters

Suggestion

Currently it is possible to write type parameters that specify subtypes. This is very common and is done with the extends keyword.
For example:
function foobar<T extends MyInterface>(args: T): number { ... }

However, it is not very easy to specify a super type for type parameters. You can do something similar with conditional types but it is finicky and doesn't compose well.
function foobar<T>(args: MyInterface extends T ? T : never): number { ... }

Now, in most cases this is not very useful. However, it is useful to qualify the outer limits of what is allowed. For instance, there is the JsonValue type from the type-fest (https://github.com/sindresorhus/type-fest/blob/main/source/basic.d.ts).
Now, it is not very good practice to have JsonValue be the subtype for some function or class because TS then requires the index field.
However, if you are writing some library that only supports JSON serialization it would be very useful to be able to specify that at the type level. This becomes very useful when working with generic classes.
🔍 Search Terms

satisfies
type
super
generic
parameter

✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Add a new declaration T satisfies ConcreteType where a type error would be emitted if ConcreteType is not a super type of T.
📃 Motivating Example

Writing a class that is a generic interface over some type which must be no broader that some other type.
💻 Use Cases

For some small cases, using ConcreteType extends T ? T : never is possible, but can get very finicky quickly and doesn't always work.

Add a new declaration T satisfies ConcreteType where a type error would be emitted if ConcreteType is not a super type of T.

T extends ConcreteType already means this, though ("ConcreteType is a supertype of T" = "T is a subtype of ConcreteType").  Are you actually looking for #14520?

T extends ConcreteType already means this, though ("ConcreteType is a supertype of T" = "T is a subtype of ConcreteType")

The error when you specify a type outside that range is the interesting part.
But I think you have your supertype/subtype side backwards. A supertype is bigger than a subtype. So T extends ConcreteType means that T is "bigger" than ConcreteType and thus ConcreteType is a subtype of T and T is a supertyp of ConcreteType.
But yes, that is what I was looking for.

T extends ConcreteType means that T is "bigger" than ConcreteType and thus ConcreteType is a subtype of T and T is a supertype of ConcreteType

No, that's not what extends means.  extends means specifically "is assignable to", or in other words "is a subtype of".  If I have function foo<T extends number>() then T can e.g. 1 | 2 | 3 (a subtype of number) but can't be, say, string | number.
The relationship you describe is the hypothetical T super ConcreteType, which doesn't exist right now.


[JENKINS-29815] Add disabling of permission inheritance for Folders

This adds the same tick-box to disable inheritance of global permissions
to Folders as already exists for Projects. Consistency!
Support for the Folder plugin seems to originally have been done by
copy-pasting in an only slightly modified version of an ancient copy of
the AuthorizationMatrixProperty.java file. This commit is as such very
similar to the patch Kohsuke once applied to the Project's AMP:
6411fffb41e4e7b217d0e841462ef23a8e62c45a
Now, these two files are close to identical, and should be refactored
into one class in my opinion:
src/main/java/hudson/security/AuthorizationMatrixProperty.java
src/main/java/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty.java

@wouterhund, I saw that you have a similar endeavour going on in https://github.com/jenkinsci/matrix-auth-plugin/pull/15. But to me it looked like you would be able to rebase your change on top of this one, which merely adds consistency to how Project and Folder permissions can be configured right now. Thoughts?

Looks like it's similar indeed. Unfortunately my pull request doesn't seem to have much (or any) traction towards getting merged so far.
What do you propose? For one to rebase on the other and turn it into a single PR, or just see which one gets merged first and then have the other rebase on top of that.

@wouterhund, yea I noticed the lack of enthusiasm for your PR https://github.com/jenkinsci/matrix-auth-plugin/pull/15. That's why I made this standalone PR which merely fixes an inconsistency bug in my opinion.
I support the idea of refactoring the way permission inheritance is configured, and that should only be easier after this PR is merged, as there's less functional change then while refactoring.
So, keeping this and PR https://github.com/jenkinsci/matrix-auth-plugin/pull/15 makes sense in my opinion. Either way it's quite a trivial rebase, so let's just see which one wins the race :)

Sounds good.

I support the idea of refactoring the way permission inheritance is configured, and that should only be easier after this PR is merged, as there's less functional change then while refactoring.

I certainly do as well, but don't have the time to dig into this currently. For now my needs are satisfied with my own fork, but hopefully either of these PRs gets through and then we'll see.


Prompt Org Configs when Org Does Not Exist and Command Runs Against It

As a CCI user, I often think of what flow, task, or other action before I think of what kind of org to run that action against. It would be helpful to have a prompt with all available org configs display whenever I target and org that has not yet been created.
Example: When I run cci flow run dev_org --org <orgthatdoesnotexist>, then a prompt displays as follows.
Org information could not be found. Would you like to create one with the following config:
1. dev
2. qa
3. release
... [lists all existing org configs]

Describe alternatives you've considered

Add a config parameter to commands which will create an org with config: cci flow run dev_org --org <orgthatdoesnotexist> --config dev
Associating a default config with a task/flow so that whenever you run that task/flow it will use that config if no scratch org exists.
Having a default config for a project so that it will always be used if an org doesn't exist.

@Julian88Tex interesting idea. I definitely like this a lot better with the prompt than without (since the user could have simply made a typo for an org that already exists).
On a related note, there's an idea we're exploring about adding a way to specify a "setup flow" for an org config in cumulusci.yml. This flow would be run automatically when the org is created. So in this world, you would need to shift your thinking from which flow you want to run to what type of org you want to work in. But you would no longer need to keep track of which flow is the right one to set up that type of org. And you would not run the risk of using a flow like dev_org in an org where it had already run, due to forgetting or not realizing that the org already exists.
I'm curious whether this sounds like something you would use, and would be happy to meet and talk through your use cases to make sure we're solving the right problem(s).

@davisagli hm, that's a really interesting one. I definitely like the thought behind it. In some ways, it's almost like the next level of what I've described in terms of automation. The big plus I see is a strong tie between orgs & flows which I think already exists in most use cases but isn't that explicit in CCI.
Would definitely love to discuss this more and beta test time willing :-). I'm very curious how errors would be handled. Ideally, there would be some visual indication that the setup flow errored for a given org.


Suggested changes to path variables

You can split the path into a path and an archive name
For example, "C:\Users\alexl\Documents\Klei\DoNotStarveTogether\94654202\Cluster_1" can be changed to "C:\Users\alexl\Documents\Klei\DoNotStarveTogether\ 94654202" with "Cluster_1"
This will make it easier to change the dedicated server name

And you can combine persistent_storage_root with conf_dir to have the files stored in any location.

and you should add a 64-bit option


feat: robust cross-referencing with MyST, cleanup examples

Description
Cleanup of all of the sphinx crossrefernces before the migration to docs.quantinuum.com/tket happens.
See this useful page on MyST crosslinking syntax -> https://myst-parser.readthedocs.io/en/latest/syntax/cross-referencing.html
I've also added a link checker to the C.I. --> 1e2c271 and tested that it works it with a legacy example.
Speaking of legacy examples I've also deleted Forest_portabiltity_example and Spam_example as I think they are too outdated to be of any use.
I've tried to avoid using full URLs wherever possible and use intersphinx to link to all of the extension packages.
This means we should only need to change URLs in conf.py.
Related issues
Please mention any github issues addressed by this PR.

Are there plans to move the qujaxs docs to docs.quantinuum.com?

Are there plans to move the qujaxs docs to docs.quantinuum.com?

The pytket-qujax docs are already there -> https://tket.quantinuum.com/extensions/pytket-qujax/
As for the main qujax docs I don't think moving them to the docs.quantinuum.com site is a priority. They're fine on cqcl.github.io for now

Are there plans to move the qujaxs docs to docs.quantinuum.com?

The pytket-qujax docs are already there -> https://tket.quantinuum.com/extensions/pytket-qujax/
As for the main qujax docs I don't think moving them to the docs.quantinuum.com site is a priority.

I was talking about this: https://cqcl.github.io/qujax/


Implementation the FileManager API

API Suggestion:

get root folder
get list of file
...

To Do
Search operation

[ ] search()

File operations

[ ] createFile()
[ ] deleteFile()
[ ] saveFile()
[ ] moveFile()
[ ] downloadFile()
[ ] exportFile()
[ ] uploadFile()

Folder operations

[ ] createFolder()
[ ] deleteFolder()
[ ] openFolder()
[ ] previousFolder()
[ ] nextFolder()


[HOTFIX]: Minor clean up regarding skipped artifacts in build files.

There are two relevant 'skip' configurations in the build, the first
is for "mvn install" and the second is for "mvn deploy". As of 1.2,
we actually use "mvn install" to generate our deployed artifcts,
because we have some customization of the nexus upload due to having
to cross compile for Scala 2.10 and 2.11.
There is no reason to have differents settings for these values,
this patch simply cleans this up for the repl/ and yarn/
projects.

@vanzin or @srowen - mind taking a quick look?

Test build #25683 has started for   PR 4078 at commit 07ac835.

This patch merges cleanly.

Test build #25683 has finished for   PR 4078 at commit 07ac835.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SparkListenerJobEnd(
class SparkILoop(
   * @param id The id (variable name, method name, class name, etc) whose
   * Retrieves the class representing the id (variable name, method name,
   * @param id The id (variable name, method name, class name, etc) whose
   * @return Some containing term name (id) class if exists, else None
   * @param id The id (variable name, method name, class name, etc) whose
   * @param id The id (variable name, method name, class name, etc) whose
   * Retrieves the runtime class and type representing the id (variable name,
   * @param id The id (variable name, method name, class name, etc) whose
   * @param id The id (variable name, method name, class name, etc) whose

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25683/
Test FAILed.

So deploy is not really used for anything now? then its config can be completely removed. There are more occurrences of this configuration in tools, java8-tests, examples, assembly

I think it is likely still used by companies that publish Spark via the traditional route, either internally or for forks of Spark. For the upstream release publishing we do something a bit fancier because the built-in maven deploy plug-in does not nicely support cross building.

Hi @pwendell ,
I actually removed the skip from the install plugin in #2982. Sorry, I didn't realize that the build scripts used it to actually publish artifacts. But skipping install breaks some developer workflows - e.g., I'm pretty sure something like "mvn -pl :spark-assembly_2.10 package" breaks if you don't have all the needed artifacts installed in your local repo.
Maybe the build scripts can have a whitelist of things to publish, or the build can have a variable that controls whether the install plugins is enabled for these "internal" artifacts or not?


Updated aws-cluster-autoscaler Instructions

The aws-cluster-autoscaler instructions were revamped to describe the
required configuration parameters, how to supply them, and an example.
Also added instructions on how to verify the required parameters are
successfully configured.

I signed it!

@mgoodness can you chime in on this one?

@mgoodness ping

@pluttrell you may want to add something in the docs to mention that version numbers of the docker image very much correlate to your kubernetes cluster version (https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler#releases).  I was going to add it to a PR but saw all your great work here.

@mikesplain Let's make that change/addition in your PR instead. Merging this as-is.

@k8s-bot ok to test

/lgtm


Remove unused functions from ecma-helpers-number.

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély<EMAIL_ADDRESS>

We should not let dead code in our repository. Nice catch. LGTM

LGTM


Update README.md

New package element finder details.

A very very useful package! Thank you @potatoCutts


Early terminate orderby when columns already sorted

Description

Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ No]

Does this PR fix a zero-downtime upgrade introduced earlier?

[ No]

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ No]

Release Notes

Documentation

Codecov Report

Merging #8228 (ce0719a) into master (582d621) will decrease coverage by 50.20%.
The diff coverage is 0.00%.

:exclamation: Current head ce0719a differs from pull request most recent head c35f160. Consider uploading reports for the commit c35f160 to get more accurate results

@@              Coverage Diff              @@
##             master    #8228       +/-   ##
=============================================
- Coverage     64.28%   14.08%   -50.21%
+ Complexity     4312       81     -4231
=============================================
  Files          1581     1581
  Lines         83122    83172       +50
  Branches      12587    12597       +10
=============================================
- Hits          53436    11713    -41723
- Misses        25852    70586    +44734
+ Partials       3834      873     -2961

Flag
Coverage Δ

unittests1
?

unittests2
14.08% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582d621...c35f160. Read the comment docs.

Since we are only optimizing the case of all order-by columns are sorted, we can have the check within getNextBlock() and add a new method computeAllSorted() to only add the first limit records into the priority queue. Mixing the logic with existing computation will introduce extra overhead, and hard to read

I did consider doing that.
At the moment, getNexBlock has a conditional split for all/partially ordered columns (where computeAllOrdered is where all columns in select are also in the order by if I understand correctly )
If we introduce a case for when all orderBy columns are pre-sorted (early termination case) then wouldn't we again have a allOrdered/partialOrdered case within that as well?

At the moment, getNexBlock has a conditional split for all/partially ordered columns (where computeAllOrdered is where all columns in select are also in the order by if I understand correctly )
If we introduce a case for when all orderBy columns are pre-sorted (early termination case) then wouldn't we again have a allOrdered/partialOrdered case within that as well?

No. If all the order-by columns are sorted, we can simply pick the first limit docs without worrying about the optimization of partialOrdered case.

At the moment, getNexBlock has a conditional split for all/partially ordered columns (where computeAllOrdered is where all columns in select are also in the order by if I understand correctly )
If we introduce a case for when all orderBy columns are pre-sorted (early termination case) then wouldn't we again have a allOrdered/partialOrdered case within that as well?

No. If all the order-by columns are sorted, we can simply pick the first limit docs without worrying about the optimization of partialOrdered case.

May be we can get a slack call to resolve this quickly.
The code "without this PR" looks like below
    if (_expressions.size() == _orderByExpressions.size()) {
      return computeAllOrdered();
    } else {
      return computePartiallyOrdered();
    }

Here computeAllOrdered is where all columns in projection are in order by clause. And, computePartiallyOrdered is where projection has more columns that in order by clause.
The two cases will also apply to the early terminate case. So with this optimization we will have 4 cases.

computeAllOrderedWithEarlyTermination
computePartiallyOrderedWithEarlyTermination
computeAllOrdered
computePartiallyOrdered

I am not sure this is any more readable that what I have.

At the moment, getNexBlock has a conditional split for all/partially ordered columns (where computeAllOrdered is where all columns in select are also in the order by if I understand correctly )
If we introduce a case for when all orderBy columns are pre-sorted (early termination case) then wouldn't we again have a allOrdered/partialOrdered case within that as well?

No. If all the order-by columns are sorted, we can simply pick the first limit docs without worrying about the optimization of partialOrdered case.

May be we can get a slack call to resolve this quickly.
The code "without this PR" looks like below
    if (_expressions.size() == _orderByExpressions.size()) {
      return computeAllOrdered();
    } else {
      return computePartiallyOrdered();
    }

Here computeAllOrdered is where all columns in projection are in order by clause. And, computePartiallyOrdered is where projection has more columns that in order by clause.
The two cases will also apply to the early terminate case. So with this optimization we will have 4 cases.

computeAllOrderedWithEarlyTermination
computePartiallyOrderedWithEarlyTermination
computeAllOrdered
computePartiallyOrdered

I am not sure this is any more readable that what I have.

What I am suggesting is something like:
    if (allOrderByColumnsSorted()) {
      return computeAllSorted();
    } else if (_expressions.size() == _orderByExpressions.size()) {
      return computeAllOrdered();
    } else {
      return computePartiallyOrdered();
    }

If all order-by columns are sorted, we don't need to do the partially ordered optimization, and the logic is all separated which is more clear and can avoid unnecessary overhead

@Jackie-Jiang addressed review comment.


Feature Request: Filter out notifications for closed PRs

I often get asked to be a reviewer on PRs which are then reviewed by others and merged. We tend to ask everyone in our team and review on a first come first serve. It'd be nice to autoclose notifications which have already been merged.

+1

+1


Set correct "thisArg" when calling nonAsync jasmine lifecycle hooks

Summary
In the latest version of Jest, the thisArg for call when calling functions in the jasmine-async file is set every time to a new object ({}).
I am not sure why this was done, but this caused a regression bug for us: https://github.com/facebook/jest/issues/3956
In the code for v19, the thisArg is set to this:
https://github.com/facebook/jest/blob/v19.0.2/packages/jest-jasmine2/src/jasmine-async.js#L42
With this PR, I reverted back to the old code. I am not sure if the arguments parameter is needed either.
Test plan
My repo in https://github.com/facebook/jest/issues/3956 can help with reproducing this issue.
I'd love to add a unit test to this as well, but have no idea where to get started with that. I guess something similar to lifecycle_hooks_test would be needed?
Edit: I added a test in jest-jasmine2/__tests__/integration/lifecycle_hooks_test.js to test this case. However found 2 odd things:

This test file is never executed as far as I could tell. Because the suffix is _test and not .test. On the other hand, maybe integration tests are run somewhere separately?
The existing test in this file always seems to pass. The   afterAll(() => { doesn't seem to be executed. One can modify the expected array to anything and the test will pass (I ran it just by changing the file name to end in .test.js)

Codecov Report

Merging #3957 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #3957   +/-   ##
=======================================
  Coverage   59.86%   59.86%
=======================================
  Files         196      196
  Lines        6763     6763
  Branches        6        6
=======================================
  Hits         4049     4049
  Misses       2711     2711
  Partials        3        3

Impacted Files
Coverage Δ

packages/jest-jasmine2/src/jasmine_async.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b079d2a...601cc02. Read the comment docs.

We actually decided that we don't want to support this behavior going forward, so this is an intentional breaking change. We are currently working for a replacement for Jasmine and we are hoping to provide more and better APIs for this in the future and breaking this now will give us an opportunity to rethink some things.

Hmm - ok. The only thing I found in the change-log was the following - even though there was a re-write, I would have expected things to continue working as is.
Breaking Change: Forked Jasmine 2.5 into Jest's own test runner and rewrote large parts of Jasmine. (#3147)

Any specific reason why this behaviour is no longer supported? The current behaviour is imho really confusing.

@cpojer This is pretty frustrating. People who have used Jasmine for a while do this, as this has always been the recommended pattern within it. Now we have two projects that use it throughout that will require quite a bit of tedious work.  😢 😢 😢
Next time please consider deprecating this behavior to give those who use it a chance to rewrite. 😞  Or at least a clear breaking change notice in the release notes.
Thanks.

@ndp we have >4000 unit tests and we use this pattern in almost all of our tests. I think it shouldn't be that hard to write a code-mod that fixes this though?

For anybody running into this, here's a codemod that will get you most, if not all, of the way there: https://github.com/cpojer/js-codemod/pull/81


Top and bottom border cut off on status bar item border

Issue Type: Bug
Testing https://github.com/microsoft/vscode/issues/99350
Using the high contrast theme on mac, the top and bottom border of these boxes appear cut off:

VS Code version: Code - Insiders 1.47.0-insider<PHONE_NUMBER>0e48be84d86f5763e126c7c5bf22e0, 2020-06-30T09:01:06.154Z)
OS version: Darwin x64 18.7.0

Ah, this was on hover, not focus, if that makes any difference

Hmm yeah on hover I get the dotted lines, but I still get the botom border...

Not sure if you tried this, but you need to have the window not maximized, in that case the bottom window border covers the status bar item hover or focus border. I'll make a PR to try to fix this.


example does not work

only test on android.
App is start. but in debug console there has some info:

I/flutter (26301): Initializing...
I/flutter (26301): Initialization done
I/flutter (26301): Running false

and Status is always "Is not running."
there is nothing status change after start button press.
and after press stop button has a log info:

D/BackgroundLocatorPlugin(26582): Locator service is not running, nothing to stop

flutter doctor output:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.3.1 21E258 darwin-arm, locale en-CA)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.1)
[✓] IntelliJ IDEA Community Edition (version 2021.3.3)
[✓] VS Code (version 1.66.0)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

@royer Did the issue you're facing with the example got resolved?
I've been facing certain issues, just wanted to check are we facing the same issue or different.
Here is the issue link! issue link

Not yet.

Any updates on this?


Prototype new kind of configmap for spark app

Describe the problem:
Currently only one kind of configmap is supported: cluster It'd be nice to have a feature that would deploy new application. Now, there are multiple approaches to spawn or reuse existing Spark cluster that should be considered (or implemented).

Create a new one ad-hoc/ephemeral cluster or use some existing one? Passing the SPARK_MASTER should do the trick.

Using spark-submit w/ master being set to k8s:// so that we can leverage the native k8s Spark scheduling mechanism.

Steps to reproduce:
N/A (it's RFE)
Observed Results:
N/A (it's RFE)
Expected Results:
N/A (it's RFE)

notebooks(?)

done in pr #31
follow up issue is #42


I just use reporters: ['lcov'] and now all other default reporters like the report in the console are executed as well.
According to the scope of #79 it would be sufficient to just do the _.defaultsDeep on reportOpts:
- opts = _.defaultsDeep(opts, {
+ opts = _.defaults(opts, {
    coverageVariable: COVERAGE_VARIABLE,
    dir: defaultDir,
    reporters: [ 'lcov', 'json', 'text', 'text-summary' ]
+ });
+ opts = _.defaultsDeep(opts, {
    reportOpts: {
      dir: opts.dir || defaultDir
    }
  });

Would this issue be what's causing the text-summary reporter to run even when I'm only specifying json?

@ecozoic Exactly!

Fixed with v1.1.1

Works nicely. Thanks!


fix line end with new-line in some backend

In backend with golang (like https://github.com/sashabaranov/go-openai), the responseText always has a '\n'.

补充：在使用go实现的一些库中，返回的内容总是以换行结束，使得substring得到的块总是一个空值，为了得到相对正常的结果，也为了兼容类似的后端，判断时忽略掉最后两个字符，是个比较相对简便的方案。
Addition:
In some libraries implemented in Golang, the response text always ends with a newline character. As a result, when using substring to get chunks, it always returns an empty value. To obtain the correct result and to be compatible with similar backend implementations, ignoring the last two characters when detecting a newline is a practical and convenient solution.


HTML output, expand asciidoctor.css inline.

Currently, when exporting an Asciidoc document to HTML from within Brackets, the asciidoctor.css file is referenced using an absolute local path (which would differ from machine to machine). For example, on my laptop the asciidoctor.css file lives here:
<link rel="stylesheet" href="file:///home/wfouche/.config/Brackets/extensions/user/nerk.asciidoc-preview/themes/asciidoctor.css">

This prevents me from emailing the HTML file to others to read as all the formatting is lost due to the style sheet being unavailable.
The fix for this is very simple (just inline expand the asciidoctor.css file in the HTML file). Simply replace
<link rel="stylesheet" href= .....

with
<style>
... contents of asciidoctor.css file
</style>

I've written a Python script to post-process the HTML file but it would simplify things if this step is not required.
Thanks,
Werner

In Asciidoctor (Ruby), linking versus embedding of style sheets is controlled by the 'linkcss' attribute. By default , the 'linkcss' attribute is not set and the style sheet is embedded,
However, the preview extension uses Asciidoctor.js for rendering. From my experience, Asciidoctor.js has some problems to directly read files from the local file system. Depending on the 'Safe Mode' defined in the settings dialog, accessing local files is prohibited anyway. That's the reason why the preview extension internally always sets  'linkcss'  to true.
I could manually read the style sheet and insert it into the rendered output, pretty much like what your python script is doing. However, your document will still not be completely self-contained, because images will still be referenced externally.
If you really want to have a self-contained HTML document, I would recommend to use the regular Asciidoctor CLI and also define the 'data-uri' attribute. This will also embedd all images into the HTML.
I've already been thinking about an option for invoking the regular Asciidoctor CLI from the preview extension, which might be a more versatile way to create documents.

Asciidoctor.js open issues related to this:
https://github.com/asciidoctor/asciidoctor.js/issues/116
https://github.com/asciidoctor/asciidoctor/pull/1354

In the meantime, I've also updated the Python script to Base64 encode images to make the HTML file truely self-contained.
Thanks for pointing out that AsciidoctorJ has this functionality built-in. I've tried running asciidoctorj from the command-line just now with options "-b html5 -a data-uri" and it generated a self-contained HTML file; Python script not required anymore.
It would still be nice though if the brackets-asciidoc-preview component could recognize the :data-uri: attribute in the Asciidoc header and generate a self-contained HTML file. See:

http://asciidoctor.org/docs/render-documents/#managing-images

But since you are considering using the Asciidoctor CLI in the future, that to me sounds like the best approach going forward.

Glad it's working for you. AsciidoctorJ is, more or less, JRuby (Java implementation of Ruby interpreter) bundled with Ruby Asciidoctor. It's actually better suited to be used within your own Java application for processing Asciidoc, where you start it up once and then process documents repeatedly.
For processing of a document from the CLI, there is some significant overhead regarding initialization of the JVM, running JRuby which then executes Asciidoctor.
If you just want to run the Asciidoctor CLI and do not rely on Java-only Asciidoctor plugins, I would recommend installing Ruby. Then just run
gem install asciidoctor

to install Asciidoctor. After that, you can just invoke 'asciidoctor' from the commandline. Processing from the CLI should be much faster than AsciidoctorJ.

BTW, it is also possible to save the document from your browser as .mht file. See https://de.wikipedia.org/wiki/MIME_Encapsulation_of_Aggregate_HTML_Documents
This will include everything into a single MHTML file. Chrome and IE can render these files natively, for Firefox you'll need an additional plugin.
This might also be a convenient way to quickly share documents as a single standalone file.

Cool tip @nerk!


Add a test with directory level > 1

A new test case which tests path generation with directory levels > 1.
Includes special cases where the cache key is too short.
Fixes #45

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
#45

@particleflux Thanks 👍


Replace sfValidatorEmail with php builtin filter_var function

As this fork of Symfony1 depends on PHP 5.3 or greater, it is a good idea to use the PHP builtin function. The original implementation is at least as good as the Symfony regular expression and improves over the PHP versions.

Mmh @j0k3r or @GromNaN: What do you want to do with this PR?

👎 For this reason.


[Quest] Sensible defaults for RPC Requests

On a fresh install, scaffold-eth makes around 50/80 RPC requests per minute. This causes that most of the deployed scaffold-eth builds suffer from RPC errors (due to limits).
Issue: We are setting multiple providers & using hooks that make requests on each block (useOnBlock, useBalance, etc).
I think it's fine if someone want on-block updates, but shouldn't be the default.
Some updates that we could make:

Having a default polling time (like 5000ms) that is passed to every hook that accepts a pollTime.
LocalProvider vs MainnetProvider: If localProvider points to Mainnet, we don't need to have two providers (modify useStaticJsonRPC hook to accept a localProvider as an argument => if mainnet, return localProvider. If not, instantiate new provider.
Comment out useOnBlock hook.

Maybe we can omit some of these if we are working on localhost (so we have a more instant feedback)

Do we  have any data through which we know how much requests are coming from localhost vs Production?


Handling invalid connections

If a user incorrectly specifies their connection setting (e.g. typos the IP address), then bb8's get method will hit errors and retry until the timeout. Is there a way of marking certain errors as "just give up"?

There is currently no such way that I'm aware. The question is if this is really what you want -- it seems likely that many of these kinds of errors could be transient, so retrying them before timing out might actually be desirable.

Yeah, I agree with you in general. In my case, we have a shell utility connecting to a db. If the user typos their db name then it takes 30s (the timeout) to return an error. I know logging with the error sink will help, but really, retrying is pointless.

Maybe you should just set the timeout lower in your application?

Well, that’s not the only problem. The other is that the error message just says timeout.
Do you think bb8 should not have the concept of an exception that should not be retried on (is terminal for the get attempt and is exposed to the user)?

That's a pretty abstract question, to which I don't have a concrete answer. I'm skeptical that there's a straightforward way to implement this that doesn't make things worse for other users and doesn't incur a whole bunch of complexity for what in my opinion is limited benefit.
bb8 is chiefly intended for long-running (server) processes. Optimizing for startup doesn't necessarily make sense. You might just start a connection without bb8 to start with to validate the user's input.

The simplest thing I could think of would be to add
fn should_retry(err: &Self::Error) -> bool

to ManageCollection with a default impl that returns true. That's backwards compatible and doesn't "incur a whole bunch of complexity" in my opinion.
The get API already supports exposing the manager defined Error type:
pub async fn get(&self) -> Result<PooledConnection<'_, M>, RunError<M::Error>>

I'm probably missing something, though.

That seems fine to me, let's have a PR (please add some tests).

I ran into an issue where ManagedConnection::Error is not Clone. The problem arises because both get and ErrorSink want the error by value, so there needs to be a copy made. Currently, only the sink gets it because get always returns TimedOut and never UserError(M::Error). Not sure how to address this without adding a new bound which would not be backwards compatible.

I opened https://github.com/djc/bb8/pull/104 to discuss the path forward.


Oracle config schema has no docs, no example in repo, no code to generate

The only way to find the oracle config schema in recent releases is by reading the code.
Older versions provided an example file in the repo, but the file is no longer included and the schema has since changed.
connect/oracle/README.md states that the oracle config is documented in connect/oracle/config/README.md, but that file does not exist.

@danielkokobt linked a PR to address this - thanks for raising this issue


NonMatchingChecksumError on Spider dataset

Describe the bug
Failure to generate dataset spider because of checksums error for dataset source files.
Steps to reproduce the bug
from datasets import load_dataset
spider = load_dataset("spider")

Expected results
Checksums should match for files from url ['https://drive.google.com/uc?export=download&id=1_AckYkinAnhqmRQtGsQgUKAnTHxxX5J0']
Actual results
>>> load_dataset("spider")
load_dataset("spider")
Downloading and preparing dataset spider/spider (download: 95.12 MiB, generated: 5.17 MiB, post-processed: Unknown size, total: 100.29 MiB) to /home/user/.cache/huggingface/datasets/spider/spider/1.0.0/79778ebea87c59b19411f1eb3eda317e9dd5f7788a556d837ef25c3ae6e5e8b7...
Traceback (most recent call last):
  File "/home/user/py3_env/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 3441, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-5-d4cb54197348>", line 1, in <module>
    load_dataset("spider")
  File "/home/user/py3_env/lib/python3.8/site-packages/datasets/load.py", line 1702, in load_dataset
    builder_instance.download_and_prepare(
  File "/home/user/py3_env/lib/python3.8/site-packages/datasets/builder.py", line 594, in download_and_prepare
    self._download_and_prepare(
  File "/home/user/py3_env/lib/python3.8/site-packages/datasets/builder.py", line 665, in _download_and_prepare
    verify_checksums(
  File "/home/user/py3_env/lib/python3.8/site-packages/datasets/utils/info_utils.py", line 40, in verify_checksums
    raise NonMatchingChecksumError(error_msg + str(bad_urls))
datasets.utils.info_utils.NonMatchingChecksumError: Checksums didn't match for dataset source files:
['https://drive.google.com/uc?export=download&id=1_AckYkinAnhqmRQtGsQgUKAnTHxxX5J0']

Environment info
datasets version: 1.18.3
Platform: Ubuntu 20 LTS
Python version: 3.8.10
PyArrow version: 6.0.1

Hi @kolk, thanks for reporting.
Indeed, Google Drive service recently changed their service and we had to add a fix to our library to cope with that change:

#3787

We just made patch release last week: 1.18.4 https://github.com/huggingface/datasets/releases/tag/1.18.4
Please, feel free to update your local datasets version, so that you get the fix:
pip install -U datasets


Version 1.4.3 giving error : Unable to get property 'configurable' of undefined or null reference

Suddenly all our CI builds are failing from April 14. Comparing the node modules versions we found that this Package is updated to a new version and the faulty code is pointing to this NPM package.
Below is the Error we are getting while running our project. It's working fine on version 1.4.2 but not on 1.4.3
Error caught from window.onerror: Message: Unable to get property 'configurable' of undefined or null reference - URL: ms-appx
This Package is a dependency NPM package of npm module<EMAIL_ADDRESS>, so we are looking for a permanent fix for this.
Please help here on this fix ASAP.

Thanks - can you provide a bit more information? The only change in v1.4.3 is https://github.com/es-shims/RegExp.prototype.flags/blob/main/implementation.js#L37-L39.
module.exports should never be nullish in a working node module bundler. I don't use angular, or ionic, but is there a chance that Ionic Cloud isn't providing a compliant node module environment?

Please find the exact error I am getting on browser.
Error caught from window.onerror: Message: Unable to get property 'configurable' of undefined or null reference - URL: ms-appx-web://com.xxx.xxx/www/build/3.js?v=20.130.97 - Line: 1 - Column: 277884 - Error object: "TypeError: Unable to get property 'configurable' of undefined or null reference\n at r.functionsHaveConfigurableNames (ms-appx-web://com.xxx.xxx/www/build/3.js?v=20.130.97:1:277884)\n at Anonymous function (ms-appx-web://com.xxx.xxx/www/build/1.js?v=20.130.97:1:903235)\n at webpack_require (ms-appx-web://com.xxx.xxx/www/build/manifest.js?v=20.130.97:1:107)\n at Anonymous function (ms-appx-web://com.xxx.xxx/www/build/1.js?v=20.130.97:1:1202311)\n at webpack_require (ms-appx-web://com.xxx.xxx/www/build/manifest.js?v=20.130.97:1:107)\n at 1882 (ms-appx-web://com.xxx.xxx/www/build/3.js?v=20.130.97:1:275481)\n at webpack_require (ms-appx-web://com.xxx.xxx/www/build/manifest.js?v=20.130.97:1:107)\n at 1830 (ms-appx-web://com.xxx.xxx/www/build/2.js?v=20.130.97:1:607481)\n at webpack_require (ms-appx-web://com.xxx.xxx/www/build/manifest.js?v=20.130.97:1:107)\n at 1392 (ms-appx-web://com.xxx.xxx/www/build/2.js?v=20.130.97:1:219820)\n at webpack_require (ms-appx-web://com.xxx.xxx/www/build/manifest.js?v=20.130.97:1:107)\n at 742 (ms-appx-web://com.xxx.xxx/www/build/2.js?v=20.130.97:1:2077062)\n at webpack_require (ms-appx-web://com.xxx.xxx/www/build/manifest.js?v=20.130.97:1:107)\n at 1825 (ms-appx-web://com.xxx.xxx/www/build/2.js?v=20.130.97:1:361436)\n at webpack_require (ms-appx-web://com.xxx.xxx/www/build/manifest.js?v=20.130.97:1:107)"
Internally @ionic/cloud-angular uses some dependency which have this module dependency. Please check below the dependancy tree.
+--<EMAIL_ADDRESS>| --<EMAIL_ADDRESS>|   +--<EMAIL_ADDRESS>|   | +--<EMAIL_ADDRESS>|   | | +--<EMAIL_ADDRESS>|   | | | --<EMAIL_ADDRESS>|   | | +--<EMAIL_ADDRESS>|   | | +--<EMAIL_ADDRESS>|   | | +--<EMAIL_ADDRESS>|   | | | --<EMAIL_ADDRESS>|   | | |   --<EMAIL_ADDRESS>|   | | +--<EMAIL_ADDRESS>|   | | --<EMAIL_ADDRESS>|   | |   --<EMAIL_ADDRESS>|   | +--<EMAIL_ADDRESS>|   | +--<EMAIL_ADDRESS>|   | | --<EMAIL_ADDRESS>|   | |   --<EMAIL_ADDRESS>|   | --<EMAIL_ADDRESS>|   --<EMAIL_ADDRESS>|     +--<EMAIL_ADDRESS>|     +--<EMAIL_ADDRESS>|     +--<EMAIL_ADDRESS>|     | +--<EMAIL_ADDRESS>|     | | --<EMAIL_ADDRESS>|     | --<EMAIL_ADDRESS>|     |   --<EMAIL_ADDRESS>|     +--<EMAIL_ADDRESS>|     +--<EMAIL_ADDRESS>|     +--<EMAIL_ADDRESS>|     --<EMAIL_ADDRESS>FYI : We are using Node version 6.9.x , I know its little older.
For now as a workaround we forcefully installing<EMAIL_ADDRESS>which solves the issue.

This problem is because of the functions-have-names dependency, it assumes getOwnPropertyDescriptor will always return a value that is not true. I opened an issue there. https://github.com/inspect-js/functions-have-names/issues/11

Thanks @klaygomes  . Hope there will be a permanent fix for this on functions-have-names. For now the workaround works for me.

@klaygomes thanks; I’ll take a look there.


Support consistency query

Add ability to specify query consistency level in request
Handle piggybacked queries as part of RespondDecisionTaskCompleted

Pull Request Test Coverage Report for Build 428

6 of 26 (23.08%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 75.063%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/common/convert.go
0
3
0.0%

internal/internal_task_handlers.go
4
21
19.05%

Files with Coverage Reduction
New Missed Lines
%

internal/internal_task_pollers.go
2
73.76%

Totals

Change from base Build 426:
-0.1%

Covered Lines:
8681

Relevant Lines:
11565

💛  - Coveralls

Are we using these anywhere? Do we have unit tests for these scenarios?


mention zenondo to credit the service

It now reads as if zenodo is the only provider of such DOIs. It should rather be an example, shouldn't it?

I only know figshare as a possible alternative, are aware of any others?

No. It's fine with these two examples.


Godot crashes when starting a remote debug session, C#

Godot version
v4.2.stable.mono.official [46dc27791]
System information
Godot v4.2.stable.mono - macOS 14.1.2 - Vulkan (Mobile) - integrated Apple M1 Max - Apple M1 Max (10 Threads)
Issue description
Using remote debug, the process halt halfway through after which the whole engine needs to be force quitted.

Steps to reproduce

Open the project
Start remote debug with the icon in the upper right corner

Minimal reproduction project
Archive.zip

I'm unable to reproduce this issue in v4.2.2.stable.mono.official [15073afe3]. I was exporting from Linux, so maybe it's only reproducible on Mac.
You could try running Godot with the --verbose flag and see if you get any more information in the console output when using remote debug, like the output of the adb command.
Unrelated to the issue, your .csproj targets .NET 6.0 but exporting to Android requires at least 7.0. See the C# platform support documentation.

I'm unable to reproduce this issue in v4.2.2.stable.mono.official [15073af]. I was exporting from Linux, so maybe it's only reproducible on Mac.
You could try running Godot with the --verbose flag and see if you get any more information in the console output when using remote debug, like the output of the adb command.
Unrelated to the issue, your .csproj targets .NET 6.0 but exporting to Android requires at least 7.0. See the C# platform support documentation.

Thanks for the response. I haven't looked into this since opening the ticket and went to using Windows for my development. I'll check whether I can still reproduce on the Mac.

Couldn't that be the cause of the problem, knowing that version 6 was not to be used for mobile deployment?

It should fail to build or crash the application on launch, but you mentioned the engine hangs on the installation step so it looks like building finished but it never got to launch the application.


Babele seems to mess with the converter

I'm currently using Babele alongside foundryvtt-pf1-fr-babele to automatically translate official compendia, and it seems to mess up with converter.
I'm aware this is not caused by Foundry core, and I'll understand if you have no plan to address those issues. Nonetheless, it doesn't cost anything to point it out, right?
Here is a list of problems I have found:

It creates new skills instead of using translated ones
It has some fatal issues with creature type

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'data')
[Detected 1 package: pf1-statblock-converter]
    at creatureTypeParser.parse (VM7700 sbcParsers.js:716:36)
    at async parseBase (sbcParsers.js:369:63)
    at async parseCategories (sbcParsers.js:161:13)
    at async sbcParser.parseInput (sbcParser.js:207:58)
    at async sbcParser.prepareInput (sbcParser.js:61:13)
    at async sbcInput.js:112:17

No idea if there is an easy way to handle that, or perhaps just adding more type safety so that compendia not found / compendium entries not found is less likely to cause a problem.
Anyway great module, cheers!

Here is the monster I tried to import: https://www.d20pfsrd.com/bestiary/monster-listings/vermin/ant/ant-giant-worker/ , it worked perfectly well without Babele.

Yeah i am not sure i can fix that, as sbc works on a keyword basis and i have no idea when and how babele interjects or changes strings. I'll keep this issue up as info for others, but i don't think i can work on this in the near future.


[CAPC Provider] EKSA Controller unable to reconcile new worker group config CRD changes

What would you like to be added:
It has been requested for the Cloudstack provider to be able to create a new workernode group directly on the custom resource, and then when editing the "cluster" custom resource later to scale/use the new workernodegroup that should end up creating the workers, vm, etc.
Why is this needed:

This issue should be resolved with the release of cluster lifecycle
CloudStack support in v0.16.


Add Statistics output

Should be trivial.  there's already a setting in renderman scene properties, just needs to be exposed in rib and ui

Fixed.


chore(main): release 1.1.4

:robot: I have created a release beep boop
1.1.4 (2024-08-03)
Bug Fixes

minor animation fixes (194d9f7)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.1.4
:sunflower:


Add events to conferences

Coverage decreased (-5.0%) to 77.081% when pulling db8786389ca1ce65a6efa44afa15cac35efe0e40 on add_events into 6ecb67416b552eff669bbb430505203b032661ab on master.


Upgrade to go1.23

Current Behavior

Desired Behavior

Implementation

Acceptance Tests

Mockups

Contributor Guides and Resources

📝 Meshery Adapters Spreadsheet
🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

@devhindo here's one for you...


No antialiasing on fonts

A quick comparison between the original carbodesignsystem website and the demo website shows lack of the antialiased fonts:

I have noticed this as well.  Usually when I have seen this issue in the past, it is due to the proper font weights not being used. This means the browser has to interpolate the font into bold or whatever weight is requested.  The issue, for me at least, seems
to be noticeable at 1rem (16px) or .75rem (12px).

I'm unable to reproduce this. When inspecting styles on carbondesignsystem.com and https://carbon-components-svelte.onrender.com/, the body selectors both have the following properties defined:
body {
  -webkit-font-smoothing: antialiased;
  text-rendering: optimizeLegibility;
}


Boolean '\ifistart' undefined.

CVHeader gives the following error
! Package etoolbox Error: Boolean '\ifistart' undefined.

See the etoolbox package documentation for explanation.
Type  H <return>  for immediate help.
 ...

l.114 \makecvheader

Commenting out \makecvheader, then compiling, then uncommenting \makecvheader and again compiling works.

Silly thing, almost all conditionals in the header are missing an s. An updated version will be available within the next days, a week max.
@posquit0  I will be busy within the next few days. I hope you can adress this earlier, if not expect a PR for the weekend.

Created a PR: https://github.com/posquit0/Awesome-CV/pull/33
Many thanks for the awesome work!

OMG... I've not noticed about this typing error! Thanks so much @nipunbatra
@johannesbottcher Thanks for your contributions :+1:

Very late comment here, but I'm also having this issue...
Package etoolbox Error: Boolean '\ifistart' undefined. See the etoolbox package documentation for explanation. Type H <return> for immediate help. ...

l.49 \makecvheader```

But when I go to the definition of `\makecvheader`, I can't find any reference to a `\ifistart` (or anywhere else in the entire codebase), so I don't know where I could define it so it can be properly used.

Here's the beginning of the fxn:

% Usage: \makecvheader
\newcommand*{\makecvheader}{
\begin{center}
\headerfirstnamestyle{
@firstname
} \headerlastnamestyle{
@lastname
}
\
\vspace{0.4mm}
\ifthenelse{\isundefined{@position}}{}{\headerpositionstyle{@position\}}
\vspace{0.4mm}
\ifthenelse{\isundefined{@address}}{}{\headeraddressstyle{@address\}}
\vspace{-0.5mm}
\headersocialstyle{
\newbool{isstart}
\setbool{isstart}{true}
\ifthenelse{\isundefined{@mobile}}
{}
{
@mobile
\setbool{isstart}{false}
}
\ifthenelse{\isundefined{@email}}

Any ideas? Thanks (I'm using Overleaf)


Documentation on Attributes needed

e.g. there are several different "IPs" in the config and the peer. WHich is which?
"Peer Endpoint Allowed IPs" in the settings, "IP Address & Range" in the config, "Allowed IPs" and "Endpoint Allowed IPs" in the peer.
As they are named differently than in the wg config files, it's hard to know, what to enter where.
For each IP address field a short explanation is needed, what kind of an IP address to enter there.
Thanks!

What would you propose, like a small questionmark like this example

If Donald can make it work, of course.

I think is is possible :) Will add this in the todo list

Instead putting explanation in the app, I've decided to create the explanation in the WGDashboard Documentation :)

4.2?

this will be a on going task, regardless releasing new version :)


Update README and example cmake project

Previously the cmake projects in examples would not compile naively using the instructions in the README.  Specifically, the projects in the examples folder cannot be built as standalone cmake projects, they must instead be compiled "under" gtdynamics.
i.e. from GTDynamics/CMakeLists.txt, add_subdirectory(examples) then make example_forward_dynamics.run works.  However, doing something like
cd GTDynamics/examples/example_forward_dynamics
mkdir build
cd build
cmake ..
make -j8

does not work.
This PR clarifies the README instructions, and also creates an example cmake project that does work standalone.
Note we have a little bit of ugliness with sdformat.  I'll work on making a .cmake file so we can use find_package(gtdynamics).
Also note: I'm not sure what the original intention of the examples folder was and how it differs from scripts - perhaps these were supposed to be standalone all along but just at some point they stopped working.  Not sure.

I think scripts should be merged with examples since they both seem to serve the same purpose.

I think I was thinking examples would be more like how to use gtdynamics in external projects (kind of like the gtsam-project-python repo), whereas scripts get run inside this repo.  So running make script would run the script, but for the examples, those would get standalone outside of the main build directory.
And I guess the examples would not be normally built, only the scripts.
But I think more I was just confused why there were both scripts and examples and deduced from the README that this was the intention, so that's why I updated the cmake files to match the README intention.

Yeah the scripts directory should probably be merged into the examples directory. Examples are meant to be simple How-Do-I code files.
The scope of this PR should change to represent that.

I think I was thinking examples would be more like how to use gtdynamics in external projects (kind of like the gtsam-project-python repo), whereas scripts get run inside this repo. So running make script would run the script, but for the examples, those would get standalone outside of the main build directory.

The examples to me are more complex than scripts and thus need more files involved. A lot of the examples have the main C++ files along with python files for data generation or visualization. None of those projects really show how to integrate GTD, and the fact that we provide the relevant CMake files makes integration pretty straightforward.
Moreover, I think being able to run make <specific-example> and is cleaner so you won't have CMakeFiles littered all over in your root directory. That's messy and tedious to clean up.

And I guess the examples would not be normally built, only the scripts.

I don't quite see the reason for this. This is why we have a flag, so users can just turn that flag on when they need the examples built. Having examples within the repo makes more sense since it shows directly how to use certain features.


make list target to list all the targets

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature
make list to show all targets
Expected Behavior
Shows all targets
Use Case
I forget the targets so I have to go back to the README.md
Describe Ideal Solution
make list
Alternatives Considered
Explain what alternative solutions or features you've considered.
Additional Context
Ref: https://stackoverflow.com/questions/4219255/how-do-you-get-the-list-of-targets-in-a-makefile
I tried adding that to my Makefile after the included script and when I ran make list, it only returned:
travis/docker-login
travis/docker-tag-and-push

nvm make help/all


Timeline for 1.0

Has the roadmap for 1.0 been defined yet?
I'd like to see a 1.0-RC3 with the most recent changes. In particular, it would be nice to bump our codebase with #236, #241, and #250 because they're quality-of-line improvements.
It seems like #257 might be a blocking issue for a full 1.0 release though.

You're right about #257.  I'm testing a fix now.  Once that's in, I think we're ready for 1.0.


[LiveComponent] Re-initialize upon visibility

Hi,
Right now we're using a lazy Live Component in a modal, which gets initialized when the modal becomes visible; that's working great. I was wondering if it's possible to 're-initialize' a Live Component when become visible again, so not only the first time.
I only managed by adding a custom Stimulus controller that communicates with the Live Component by calling a 'init'-method.
Thanks in advance.

I don't think we want it in the core but this is a great think you can still share your code here! 😁

@WebMamba
Well, I think it's a great addition. Imagine the following use case: I have an overview with entities and in that overview I have an add-button which opens a modal with that Live Component. I do want to reset the underlying form everytime the modal get's openend. Right now, it's only 'reset' upon first init.

You can look how i did it for the icon modals on this page: https://ux.symfony.com/icons
(source code is in the repository)
I agree with you this is a frequent pattern, but ... the implementation is really different from a project to another.. so maybe we should write a short post in the cookbook ?

@smnandre Thanks, I will have look.

@smnandre just checked the repo, your implementation is slightly different from mine. Your trigger is the Click + Change event. I have added a create and edit (with livearg id) method in the live component, which is called from the records in the overview. The modal is shown using dispatchBrowserEvent.

@smnandre I end up using a single turbo-frame in my base-template. Using a Stimulus-controller I can change the src-attribute,
the route returns a complete modal-HTML. With the frame-events I can show a backdrop + loader during fetching. When fetch completes the Stimulus controller creates a Bootstrap modal. Turbo doesn't intercept Live Component, so far it's looking good.


[SPARK-15162][SPARK-15164][PySpark][DOCS][ML] update some pydocs

What changes were proposed in this pull request?
Mark ml.classification algorithms as experimental to match Scala algorithms, update PyDoc for for thresholds on LogisticRegression to have same level of info as Scala, and enable mathjax for PyDoc.
How was this patch tested?
Built docs locally.

Test build #57925 has started for PR 12938 at commit c72fa46.

Test build #57925 has finished for PR 12938 at commit c72fa46.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57925/
Test PASSed.

Test build #58153 has started for PR 12938 at commit 64942b7.

Test build #58153 has finished for PR 12938 at commit 64942b7.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58153/
Test FAILed.

Test build #58249 has started for PR 12938 at commit a73913b.

Test build #58249 has finished for PR 12938 at commit a73913b.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58249/
Test FAILed.

Test build #58255 has started for PR 12938 at commit 9e38ddf.

Test build #58255 has finished for PR 12938 at commit 9e38ddf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58255/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58264 has started for PR 12938 at commit f4df8f0.

Test build #58264 has finished for PR 12938 at commit f4df8f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58264/
Test PASSed.

Test build #58895 has started for PR 12938 at commit 5df5a93.

Test build #58895 has finished for PR 12938 at commit 5df5a93.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58895/
Test FAILed.

Merged build finished. Test FAILed.

Test build #58901 has started for PR 12938 at commit 2eec947.

Test build #58901 has finished for PR 12938 at commit 2eec947.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58901/
Test PASSed.

Test build #59158 has started for PR 12938 at commit e11dbf8.

Test build #59158 has finished for PR 12938 at commit e11dbf8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59158/
Test PASSed.

ping?

Test build #59406 has started for PR 12938 at commit 4111b2d.

Test build #59406 has finished for PR 12938 at commit 4111b2d.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59406/
Test FAILed.

Merged build finished. Test FAILed.

Test build #59408 has started for PR 12938 at commit 53ab790.

Test build #59408 has finished for PR 12938 at commit 53ab790.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59408/
Test PASSed.

Merged build finished. Test PASSed.

ping?

A couple minor comments, pending that LGTM.

Test build #60065 has started for PR 12938 at commit a7aadec.

Test build #60066 has started for PR 12938 at commit e4061f4.

Test build #60065 has finished for PR 12938 at commit a7aadec.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60065/
Test FAILed.

Test build #60066 has finished for PR 12938 at commit e4061f4.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60066/
Test FAILed.

Merged build finished. Test FAILed.

Test build #60139 has started for PR 12938 at commit 7b634b6.

Test build #60139 has finished for PR 12938 at commit 7b634b6.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class AttributeSeq(val attrs: Seq[Attribute]) extends Serializable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60139/
Test FAILed.

Test build #3077 has started for PR 12938 at commit 7b634b6.

Test build #3077 has finished for PR 12938 at commit 7b634b6.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class AttributeSeq(val attrs: Seq[Attribute]) extends Serializable

Test build #60332 has started for PR 12938 at commit 873f6c8.

Test build #60332 has finished for PR 12938 at commit 873f6c8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60332/
Test FAILed.

Test build #60363 has started for PR 12938 at commit 9fb2e41.

Test build #60363 has finished for PR 12938 at commit 9fb2e41.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
   public static class Prefix
case class RefreshResource(path: String)

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60363/
Test FAILed.

Merged build finished. Test FAILed.

Test build #60390 has started for PR 12938 at commit 74636b1.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60390/
Test FAILed.

What keeps causing this failure?  Is it the change in conf.py?

@jkbradley - I don't think that is the issue but it does seem like the only "real" change - strangely enough I get the same failure locally on vanilla master at e2ab79d5ea00af45c083cc9a6607d2f0905f9908 but jenkins master appears to be fine. I'll run a bisect on this while I'm finding coffee/breakfast.

Git bisect ends up blaming e2ab79d5ea00af45c083cc9a6607d2f0905f9908 - I'll poke at it some

Which of course seems to be more that things are flaky rather than that commit actually introducing it :(

Test build #60456 has started for PR 12938 at commit d925f38.

Test build #60456 has finished for PR 12938 at commit d925f38.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60456/
Test FAILed.

Test build #60462 has started for PR 12938 at commit 3981612.

Test build #60462 has finished for PR 12938 at commit 3981612.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60462/
Test FAILed.

Merged build finished. Test FAILed.

Test build #60466 has started for PR 12938 at commit 2be8cdf.

My guess is f7288e166c696da15e790c28fc3ed78531fd362d is the culprit but lets see.

Test build #60466 has finished for PR 12938 at commit 2be8cdf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60466/
Test PASSed.

Ok well that makes sense - I'll fix this to support both resource and system property based.

@holden does  f7288e1 need to be reverted?

I think you meant @holdenk
Otherwise the pr looks ok to me. ;-)

Test build #60499 has started for PR 12938 at commit 4431daa.

Test build #60499 has finished for PR 12938 at commit 4431daa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60499/
Test PASSed.

@MLnick I think its your call - as @rxin pointed out on another PR - during a release we normally revert rather than waiting to fix - but since I made a fix in the process of figuring out what the issue was I think it would also just be OK to merge this - but your call.

@holdenk master passes PySpark tests for me locally. Are we sure it is f7288e1? Is it intermittent? Because #13489 did pass Jenkins (including PySpark tests).

@MLnick - I think it just a timing condition - if the file is available in the resource path its all good but if it isn't then its sad. So https://github.com/apache/spark/commit/f7288e166c696da15e790c28fc3ed78531fd362d would have passed, but this PR probably changes how long the pylint check takes (adds mathjax) which surfaces this.

@holdenk ok weird - now master is failing for me locally with the same error and I confirmed your fix does work.
Failure is consistent for me locally. But it doesn't appear this is impacting open/recent PySpark SQL PRs... e.g. #13717, #13558. This PR is the only place it's failing on Jenkins, which is really weird to me, since even an intermittent failure should show up on someone else's PR. So for now I have not reverted f7288e1 ... cc @rxin @sameeragarwal
In any case let's rather isolate the issue/fix in a separate PR for SPARK-15954.

Sounds good will make that PR :)
On Friday, June 17, 2016, Nick Pentreath<EMAIL_ADDRESS>wrote:

@holdenk https://github.com/holdenk ok weird - now master is failing
for me locally with the same error and I confirmed your fix does work.
Failure is consistent for me locally. But it doesn't appear this is
impacting open/recent PySpark SQL PRs... e.g. #13717
https://github.com/apache/spark/pull/13717, #13558
https://github.com/apache/spark/pull/13558. This PR is the only place
it's failing on Jenkins, which is really weird to me, since even an
intermittent failure should show up on someone else's PR. So for now I have
not reverted f7288e1
https://github.com/apache/spark/commit/f7288e166c696da15e790c28fc3ed78531fd362d
... cc @rxin https://github.com/rxin @sameeragarwal
https://github.com/sameeragarwal
In any case let's rather isolate the issue/fix in a separate PR for
SPARK-15954.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/12938#issuecomment-226761030, or mute
the thread
https://github.com/notifications/unsubscribe/AADp9V03SpADeLij0leDvXuHD3lIlODuks5qMpjngaJpZM4IYbBk
.

--
Cell :<PHONE_NUMBER>
Twitter: https://twitter.com/holdenkarau

@holdenk can you back out 4431daa from this PR when you get a chance?

Sure thing.
On Tuesday, June 21, 2016, Nick Pentreath<EMAIL_ADDRESS>wrote:

@holdenk https://github.com/holdenk can you back out 4431daa
https://github.com/apache/spark/commit/4431daa9552426f02a993778eb5a5f2c2d87b183
from this PR when you get a chance?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/12938#issuecomment-227472608, or mute
the thread
https://github.com/notifications/unsubscribe/AADp9dSasgfL9zhu21irWOwssmXi0SNsks5qOABBgaJpZM4IYbBk
.

--
Cell :<PHONE_NUMBER>
Twitter: https://twitter.com/holdenkarau

So this reverts the support both, but leaves in the revert of the breaking change. Did you also want that removed @MLnick ?

Test build #60943 has started for PR 12938 at commit d842309.

@holdenk @MLnick Could this PR be split into smaller ones? I don't see a good reason to put changes to HiveTest and pyspark.ml Experimental annotations under the same PR. Keeping PRs minimal is a good practice and it also helps locate issues and backport bug fixes.

I did mean by my earlier comment that this PR should focus on the doc
changes and the other new (linked) one is handling the HiveTest issue.
On Tue, 21 Jun 2016 at 20:42, Xiangrui Meng<EMAIL_ADDRESS>wrote:

@holdenk https://github.com/holdenk @MLnick https://github.com/MLnick
Could this PR be split into smaller ones? I don't see a good reason to put
changes to HiveTest and pyspark.ml Experimental annotations under the
same PR. Keeping PRs minimal is a good practice and it also helps locate
issues and backport bug fixes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/12938#issuecomment-227533138, or mute
the thread
https://github.com/notifications/unsubscribe/AA_SB5KowL5vQrTp_YBBbovlqU27UnI2ks5qODCugaJpZM4IYbBk
.

Good, I'll revert the revert then as well :)

Stripped down to just the doc changes. I personally very much like having small PRs - the fix just happened to end up in here since it this doc change exposed the underlying issue (and it seemed like the doc change its self was small enough it would be ok to package the fix with it) as some people have asked that I group things together more.

Test build #60949 has started for PR 12938 at commit de63f9f.

Test build #60943 has finished for PR 12938 at commit d842309.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60943/
Test PASSed.

Merged build finished. Test PASSed.

Test build #60949 has finished for PR 12938 at commit de63f9f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60949/
Test PASSed.

Ok it's passing now :) LGTM

Merged to master/branch-2.0.


Tags Page

The tag page is being created ok. But I don't see any way to access it other than entering the URL of it by hand: <base_url>/tags. This causes the /tags/index.html page to show.
Is there a way to put this on the main menu?
Thanks in advance!

Lots of searching and reading led me to this easy solution. I added in content folder taxonomy.md with this content:
+++
title = "Tags"
date = "2014-04-16"
menu = "main"
weight = "12"
meta = "false"
url = "/tags/index.html"
+++

Keys to make this work:

must use the url variable
the value must be the full path from root
the filename must not be tags.md since that really confuses hugo (altho I didn't revert to tags.md after I discovered the url variable - so I might be wrong)

Thanks for a wonderful theme!


TypeError: vl.field.role is not a function

When loading the app with latest vl.

Can't reproduce .. have you pull the latest master and run bower install?

Reinstalled all deps.