Good Country pre-election

Aiming to have a proposal by May 6.
Good country wants to map who are the viable candidates for Venezuela's presidential elections. @medied they want to do an independent process, on their own time, and not following the narrative of the regime.
Here are a couple thoughts for how to format this:

Create a goodcountry.democracy.earth jurisdiction pointing to good country's account.

They create a hashtag (ex: #vzlapreelecciones ) and start asking for suggestions from Venezuelans. Then establish what is the threshold of votes for a candidate to be valid

or

They can create users impersonating potential candidates of Venezuela, that post their quotes and then they account for the number of delegations those users get. Other users can suggest more potential candidates to be impersonated.

They can create users impersonating potential candidates of Venezuela, that post their quotes and then they account for the number of delegations those users get. Other users can suggest more potential candidates to be impersonated.

I like this approach. We can include something in the avatar to signal it's just a representative account (and by include in the avatar.. in the image used as avatar, dont expect code for that).

I'd lean away from impersonating, I'm not understanding right now how that would play out. Or maybe I'm misunderstanding the idea entirely, maybe 'impersonating' is not the right word in this case.
Are we talking about getting a read or pulse on what's the support behind certain Venezuelan leaders? That is an idea we had explored earlier, and it makes sense to me for Good Country to execute on that front. From the Sovereign point-of-view, are we talking about gauging the support in the number of delegations (to a fake account) or the votes received (by a candidate proposition by Good Country)?
Paula and I were talking about that and exploring. It would be key that anyone could 'nominate' a leader. Also we considered timelines, we mentioned this doesn't necessarily have to be done by May 20th, it could be a good action to take post May 20 to keep momentum going. Also I think we all agree we should remain within the flexibility that Sovereign offers.

We must definitely follow momentum first.

What does that mean exactly?
If we prepare to launch elections a couple days after the launch of the initiative, this gives us more time to create a collaborative process with some of the other organizations involved in the initiative, where together we can determine how to access who are the potential candidates, and then more importantly what exactly will be the criteria to select the official candidates for the good country venezuelan election (top 5 most voted, or everyone that gathers 10% of the total amount of tokens owned by users of venezuela.democracy.earth, etc.) .

it is a good thing to keep the momentum going. a couple of days after launching the initiative, make a lot of noise saying "we are starting good country's venezuela's pre-elections! Join now" or something like this. Maybe even with a video from Simon and others describing the initiative.....
What do you think?
If by your comment you meant build momentum in advance of launch that we can try to speed up the process and make it inclusive anyways. Having a say from Venezuelans (that are living in Venezuela) is critical, many times we pivoted completely because of what they had to say.

So launching on May 20 to cease the moment where the world is paying attention.
I have a proposal:
This is not any election, it's a liquid democracy election. Meaning that we can center this around ideas, policies , and create room for the proponents of the best ideas to surface as political leaders.
We can have discussions around policies by having impersonated accounts from the main potential candidates listing what they have proposed in the past on many different things like economy, health, political reform and education (to be determined). We put an orange layer on top of the photo of the impersonated accounts signaling they are impersonations.
Each topic has a hashtag like #monetaryregulation (in adittion to the #venezuela hashtag), so that everyone who wants to analyze the different propositions on a given topic can access it. And then we let the delegations begin. The top x with more delegations qualify for the elections. Might be the regular political candidates, or might be people like Ricardo Hausmann, or a young student, or an activist.
Of course it will involve intense hustling.

@paulamlb I like that idea.  The representative avatars (which is what you mean by impersonations, right?) w/ orange filter becomes an ideas-based 'representation of the representative', correct? enabling leaders/Leadership to emerge from ideas & be voted on.

@paulamlb no. each paragraph makes a good post. structure the conversation that way.


SQLite Autoincrement Issue

Describe the bug
When creating column (primary key, autoincrement) in SQLite, if the length set is > 0, inserts will fail.  There also appears to be no way to set the length back to 0, any attempt will set the number back to what it was.
To Reproduce
1.) Add new table...
2.) Name [users]
3.) Add new field [id, integer, 0] - Primary Key
4.) Add new field [name, text, 0]
5.) Save
6.) Insert Row - Works
7.) Set id field length to 10
8.) Save
9.) Now unable to insert rows with error: SqliteError: NOT NULL constraint failed: users.id
10.) Try to set the length of [id] back to 0.  Will jump back to 10 once clicking outside of textbox
Expected behavior
Able to set length back to 0 or allow autoincrement when length > 0

The MySQL Sometimes lost AUTO_INCREMENT defaults after edit a table, this can be related with this issue?


Global setting for pagination seems to be wrongly typed

Bug Report
It looks like I can't set the pagination globally despite the types allow it.

I'd like to add
pagination: {
    defaultLimit: 100,
    limits: [100, 250, 500, 1000],
}

to the global configuration but some errors prevents that:
[15:47:44] ERROR (payload): There were 1 errors validating your Payload config
[15:47:44] ERROR (payload): 1: "admin.pagination" is not allowed
[nodemon] app crashed - waiting for file changes before starting...

Other Details
Latest version of Payloadcms (1.6.19)

Hey @wiesson  - we are removing the pagination type from the top level admin config types for now as global pagination is not implemented just yet - but I went ahead and created a feature request (here) - we will get to this as soon as we can!


Enhancement - Provide build system

Due to our single file structure, it's annoying and frustrating when multiple contributors are working in the codebase at once.
The easiest way to resolve this and clean up our code is to have the ability to break the code out into multiple files and have a build system of some kind (gulp, webpack, parcel) concatenate our files together.

Rohan brought this up in #43 - going to get rid of that one in favour of this, just for organizational purposes


npm run prod ERROR:

ERROR in ./javascripts/caravel-select2.js
Module not found: Error: Cannot resolve 'file' or 'directory' ../node_modules/jquery-ui/themes/base/jquery-ui.css in $SOFTHOME/caravel_install/caravel/caravel/assets/javascripts
@ ./javascripts/caravel-select2.js 5:0-62
What shall I do?

解决：
1、 vi caravel/assets/package.json
"jquery-ui": "^1.10.5",  ->  "jquery-ui": "1.10.5",
2、To install third party libraries defined in package.json, run the following within the caravel/assets/ directory which will install them in a new node_modules/ folder within assets/.
npm install
3、To parse and generate bundled files for caravel, run either of the following commands. The dev flag will keep the npm script running and re-run it upon any changes within the assets directory.
Compiles the production / optimized js & css
npm run prod
done!!!!  :)

@PickLiDan It's already fixed in master.


Polish documentation

fix small typos in comment, javadoc, error messages,
improve formatting

Signed-off-by: Marc Wrobel<EMAIL_ADDRESS>

Thanks @marcwrobel for cleaning this up!


--patch-module can not be used

and thus in-jdk  files can not be compiled

Runnable.java:1: error: package exists in another module: java.base
package java.lang;
^
1 error

canbe fixed by :
javac --patch-module java.base=.  Runnable.java

on cmdline. Any idea how to do that for CPLC?

I think we will be able to further hack around with our .class files existing only in memory using the PATCH_MODULE_PATH enum from https://docs.oracle.com/en/java/javase/17/docs/api/java.compiler/javax/tools/StandardLocation.html.
I will play around some time in future when I have more time.

Seems like https://github.com/mkoncek/classpathless-compiler/tree/patch-module-path can work.

yy. sounds correct. Two nits:

to guess module from ^java.* is awsome, and is simplifying hacking a lot. I agree on doin g that, but it shoudl be optional, and on demand.
there are also non jdk modules - eg custom apps - such must be allowed by some swithc, aka --patch-module :)

But the PoC is indeed awesome. TYVM!

Can you remind me: is adding new classes possible in JRD?
Do you see any problems with using Class.forName? I know we dumped it previously.
AFAIK, while other programs could have been built using modules and such, doesn't JRD discard the non-JDK modules anyway? Meaning there are no there modules visible in the CP listing.

I was pointing at the issue that Class.forName uses classes that are currently loaded, if new classes are added, then obviously Class.forName will not find a suitable class and won't be able to infer the module name. Now I wonder if packages are first order-classes in the Java world. I assume packages must be associated with modules.

Each package can be in only one module, thas unbreakable law. If I add new classes, then future class.forName will find them. Actually from my experiments with that it seems, that all classes added via that api I linked, are immediately loaded, so no need to call class.forName on them.

https://github.com/judovana/java-runtime-decompiler/pull/263 is adding the module to listing. But to make it properly working will take some time. There is nosurprise, and modules are correclty shown

Another proof of concept using package name -> module name associations.
https://github.com/mkoncek/classpathless-compiler/compare/master...package-modules
I am not in favor of handling the compiler options meant for javac and repurposing them, therefore I added another named argument for CompilerJavac.
I am also unsure about the name patchModules, but even if it may be somewhat misleading in context of the --patch-module argument for javac I still think it is the best name.

Pls no system exit.
--
Mgr. Jiri Vanek
@.***
---------- Původní e-mail ----------
Od: mkoncek @.>
Komu: mkoncek/classpathless-compiler @.
com>
Kopie: judovana @.>, Author @.>
Datum: 15. 2. 2024 20:29:30
Předmět: Re: [mkoncek/classpathless-compiler] --patch-module can not be used
(Issue #20)
"
Another proof of concept using package name -> module name associations.
master...package-modules
(https://github.com/mkoncek/classpathless-compiler/compare/master...package-modules)
I am not in favor of handling the compiler options meant for javac and
repurposing them, therefore I added another named argument for CompilerJavac
.
I am also unsure about the name patchModules, but even if it may be somewhat
misleading in context of the --patch-module argument for javac I still think
it is the best name.
—
Reply to this email directly, view it on GitHub
(https://github.com/mkoncek/classpathless-compiler/issues/20#issuecomment-1947076400)
, or unsubscribe
(https://github.com/notifications/unsubscribe-auth/AAWFCS2F4TGES7VX2AI4SBTYTZOZPAVCNFSM6AAAAAA6JHYVECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBXGA3TMNBQGA)
.
You are receiving this because you authored the thread. Message ID: <
@.***>
"

System.exit is called in the CLI tool.

Also I was confused, because it was the only splitting on ":" . Shoudlnt this be nahdled in lib?

I had merged the printing of modules. Also I have added the warning about --patch-module: https://github.com/judovana/java-runtime-decompiler/commit/393f5f85f5d440b4e5a2e7043b07ad6c0018620a
So the agreement is, that I' m supposed to parse the --patch-module out of arguments on my own, and pass to cplc separately? Maybe you can extract that method of yors whcih you have in cli to the lib?

I can do the parsing. I haven't implemented it yet.

I saw it in the cli :)

I saw it in the cli :)
That was a bit different.

With the latest commit I implemented --patch-module module.name=pkg.name1:pkg.name2 passed via compilerOptions as a string.
https://github.com/mkoncek/classpathless-compiler/commit/96c5b30522e4957cee85d865fbdc13ecab69c75c

Cool! I had tried that in JRD: -patch-module java.base=java.lang works as epxected,  --patch-module java.base=java.lang.Runnable correctly do nto work as advertised. Pls merge and release. We can tune it up in 2.3.something if ti goes wrong

Version 2.3 has been released, I believe this issue is done.


Client receives an error and logs out when game ends

Summary
When watching a game, the KGS client will receive an error and log the user out after the game ends and both players leave.
Steps to reproduce:

Watch a game
Wait until game ends
Wait for both players to leave

At this point an error is displayed and the user is logged out. The user needs to log back in before continuing to use the client.
This is the error shown:
Disconnected - Internal error (check webapp logs for stack trace): java.lang.RuntimeException: Unknown channel 26518795

Expected behavior:
The user should remain logged in and be able either continue reviewing the finished game, are navigate away from the game screen.

this is a server error (its a bug in the jsonclient api code).  I'll file a bug on the kgs issue tracker.


Returning Ok(None) ends the stream?

I'm working on a Server-Sent Events library that uses futures_codec to decode an event stream line by line. Some servers send heartbeat messages as comments (lines starting with :), which should be discarded by the decoder. So it's possible to get a stream of input like:
:heartbeat signal

[10 seconds later]
:heartbeat signal

[10 seconds later]
:heartbeat signal

After parsing the :heartbeat signal lines and getting to the end of the current buffer, my parser returns Ok(None), because there were no actual event messages in the input. At this point, FramedRead will return Poll::Ready(None) instead of Poll::Pending, thus ending the stream.
This test simulates the behaviour by emitting single bytes from an AsyncRead impl: https://github.com/goto-bus-stop/futures-codec/commit/3bebe0c7390639db45a3d0eff70ed0101e1661f7
The as represent event messages, and bs represent comments that should be ignored. When reaching a b, the decoder returns Ok(None) and the stream is ended.
Is this the intended behaviour? I think ending the stream is a legitimate use case, but I'm not sure how to implement a parser that doesn't emit a message for every input correctly. I thought I could work around it by not consuming the comment lines from the BytesMut input until there is an actual event message, but that would require re-parsing those comment lines on every call to decode(), and the buffer.is_empty() check will return an error because the buffer isn't empty after the call to decode().
For my use case, returning Poll::Pending if the decoder return Ok(None) would be a solution. The decoder itself can then no longer decide to close the stream, unless the return value is changed from Option<Self::Item> to something like
enum DecodeResult<T> { // T = Self::Item
    Item(T),
    Pending, // no item here, need more data
    End, // done, close the input stream
}

I know tokio had a decode_eof method in Decoder that's called when there are no bytes remaining in the stream. Would that solve your issue if you could then return Poll::Pending from that method?

I think decode_eof is a bit different. It's called when the input stream ends. In this case, futures-codec is ending the decoder stream when I return Ok(None) from my decode() implementation. With tokio-codec, returning Ok(None) indicates that the decoder needs more bytes from the input stream, but with futures-codec, it ends the stream. For me the tokio-codec behaviour is better, because the decode() implementation may be called multiple times with new data before it can return an Ok(Some(item)).

Opened #28 with behaviour that would fit my use case—if nothing else, I hope it clarifies what I mean! :laughing:

Oh gotcha, thanks for clearing that up! That definitely does sound like the desired behavior

Was 0.3.4 released to crates.io? I only see 0.3.3 there :speak_no_evil:


Create a mappingrepository interface so we can mock it

This PR add mappingrepository interface, so we can mock it to properly test: #54

@masayag PTAL


Update version of Java

In pom.xml, what works with default Cloud Run deployment (--source option) and a simple Dockerfile is having:
    <maven.compiler.source>1.8</maven.compiler.source>
    <maven.compiler.target>1.8</maven.compiler.target>

Apparently, you are supposed to be able to compress this down into:
<maven.compiler.release>11</maven.compiler.release>

... but that doesn't seem to play nice with a simple Cloud Run deployment.
I'd like to explore more how this works and probably get on the latest version of Java??
(after MVP ;) )

Successfully updated to Java 17, including deployment!
I had an issue with updating all the way to Java 21 (I don't think there is a version of Kogito that will generate correct code from DMN in this version).
17 is good enough for now, I think... no longer on a deprecated version anyway!
see 57bfcf3f65ca6304942809653407419f0787e4f5


Use of weak hash algorithm - CC_SHA1

Integration Method: CocoaPods / Carthage / Manual
Xcode Version: Version 10.1 (10B61)
Library Version: v3.4.7
Platform: iOS
Language: Objective-C
Description:
Similar to #858, MPWebSocket stringBySHA1ThenBase64Encoding uses the SHA-1 hashing algorithm. This algorithm is considered cryptographically weak and its usage is not recommended.
Solution:
As stated in iOS 13 CryptoKit documentation, update the code to use a stronger hash algorithm, like SHA-512.

Mixpanel is deprecating Messaging and Mobile A/B testing features(more details), please contact our support if you need to continue the conversation for any critical issues. Sorry for the inconvenience.


GP-LVM

I've started reading on how to use GPs for dimensionality reduction. In the example notebook:
http://nbviewer.jupyter.org/github/SheffieldML/notebook/blob/master/GPy/MagnificationFactor.ipynb

the variables represented on the lower dimensional space are m_gplvm.X
I'm wondering when new data becomes available, say Y_new, how would I find it's representation using the same transformation that produced m_gplvm.X. (for normal PCA, one use model.fit, followed by model.transform).

You can use the function: m_gplvm.infer_newX(Y_new). It is a
gradient-based optimization. The return values are a tuple: the first
entry is the inferred X_new and the second entry is the model created
for this inference.
Zhenwen
On 28/05/2016 05:38, IrishBeast1 wrote:

I've started reading on how to use GPs for dimensionality reduction.
In the example notebook:
|http://nbviewer.jupyter.org/github/SheffieldML/notebook/blob/master/GPy/MagnificationFactor.ipynb
`m_gplvm.X` I'm wondering when new data becomes available, say
`Y_new`, how would I find it's representation using the same
transformation that produced `m_gplvm.X`. (for normal PCA, one use
model.fit, followed by model.transform). |

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/SheffieldML/GPy/issues/395>, or mute the thread
<https://github.com/notifications/unsubscribe/AFwBWrirCkA7Fl6CEdsiAbHUqtBnq6z_ks5qF8a2gaJpZM4Io_jp>.


Firefox: 131.0b9 -> 132.0b5; 131.0 -> 131.0.2; 128.3.0esr -> 128.3.1esr; 115.16.0esr -> 115.16.1esr

https://www.mozilla.org/en-US/firefox/131.0.2/releasenotes/
https://www.mozilla.org/en-US/firefox/128.3.1/releasenotes/
https://www.mozilla.org/en-US/firefox/115.16.1/releasenotes/
https://www.mozilla.org/security/advisories/mfsa2024-51/
Fixes: CVE-2024-9680

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Tested all non-beta/devedition versions on aarch64-linux and x86_64-linux.

unstable tracker: https://nixpk.gs/pr-tracker.html?pr=347500
stable tracker: https://nixpk.gs/pr-tracker.html?pr=347540

Counter to what the PR tracker shows right now, these changes have reached the unstable channels.


Ship Physics randomly stop entirely.

I'm running version 87 off of curseforge and the ships stop moving altogether at seemingly random moments. After this, I'm unable to interact with anything on the ship. (break blocks, change controls, etc.) It seems to be some form of desync, as logging off and back on reloads the ship in a completely different place, functional for the next minute or so.

Can we see your log, do you have any other mods installed (if so, which ones), what are your PC specs?

I believe this issue has to do with how Ships try to interpolate their positions in the case of server lag. Your client probably went 20+ ticks without getting an update from the server, causing the permanent desync.
I'm looking into it, and hoping to have it fixed soon.

Hello!
I had a similar issue on our Spongeforge server. I added this mod (build 96) to the numerous other mods already installed on the server and tried to build a test barge. I experienced similar issues I posted in #66. Upon infusing the craft with physics, it started jumping like a wild horse, After it had settled down in a canyon, it sat there, crooked. I could not access the hovercraft controller or break any of the blocks of the ship. I am also attaching a fml-server-latest log I pulled from the server after I shut it down.
fml-server-latest.txt
I took a glimpse at this and saw that some mods seem to have an issue with VW (Gendustry and Opencomputers). I have very little knowledge of JAVA or the forge/spongeforge API however, so for all I know, this could be normal.

Strange, I know that Sponge works on its own with VW. The mod also works perfectly fine with the DireWolf20 pack from what I can tell.
As for Gendustry and Open Computers, I think I know the cause from the logs. I'll investigate why they're causing ASM failures and how I can fix these.

That would probably indicate that this could be a mod conflict, because I do not have any standard packs installed. Is there a quicker alternative to tracing that than adding mods one-by one?

Not particularly, from the log I saw the ships didn't put out a freezing message. I've fixed the incompatibility With Open Computers in the latest build, but I don't think that affects this problem as a whole. I'll look into it further once I get home.

I was curious if maybe the last build (98) didn't have this freezing issue, unfortunately it still persists. I'm uploading an image just so you could visualize it better. The bigger "ships" lunged into air after infusing, bounced and flipped after landing, then froze.

The smaller one in the background casually slid into the sea. It was lagging with the physics a bit, but didn't freeze. I was confused as to why it didn't rise to Y 76 as I instructed the controller, but then I realized I forgot to link the ether compressor and the hovercraft controller. After linking the two, it flew to the assigned Y level where it stay swiveling. It froze after I attached the second ether compressor:

I wandered away from the spawnpoint, built some vessels without the ether compressors and only regular thruster engines installed. These vessels seem to take longer to freeze. I came back to the spawnpoint to see this:

The ships responded to changing the Y level, but froze after a while. This all happened in a fresh SP world. I'm uploading the fml-client-latest just in case it could prove helpful:
fml-client-latest.txt

Can you send me your mods .zip? From your description I think it has something to do with the way Ships determine when to unload themselves, and if thats the case I might be able to fix this with a few lines of code!

I cannot upload the .rar here, because it's too big. I am posting it on Dropbox and sharing the link here:
https://www.dropbox.com/home/Mods folder of Liiw
Running on:
MC 1.10.2
forge  1.10.2-<IP_ADDRESS>9
Thank you for your continued effort in fixing this issue!

That's the link to your dropbox -_- . Nobody can access that but you.

Damn, How could I have missed that. I'm so sorry! Here is the sharelink:
https://www.dropbox.com/sh/0t2kqyixs3r5lz0/AAACV7nEPX-6ZCrQb9jeRiX5a?dl=0

The conflict was caused by ChickenChunks using some terrible code to accomplish its chunk unloading.
Thankfully because the lazy ChunkLoading relied on an event, I managed to write a method that hides all the Ship Chunks from ChickenChunks before it starts its purge, allowing me to bypass what should be an unloading.
Build #99 should be the death of this bug https://jenkins.ironhide.de/job/Valkyrien-Warfare-Revamped/99/ .
I just want to say thanks to @Liiw for all the support in getting me concrete scenarios that made debugging this possible in the first place (<3); and as usual, if I'm wrong and this bug persists please be sure to let me know on this thread. <3

The beast has been slain! No more freezing ships! I did have the occasional stutter, but that was probably due to the SP world generating while I was sailing the majestic hoverbarges:
However I do have other issues, which I will be addressing in a separate thread (ships behaving strangely).


SW-5565 Remove unused device manager API code

Commit 3baf69ac removed the UI code that called the device manager API endpoints.
Remove the actual API interaction code as well.

#2802  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite


[NoTicket] Delete BaseActivity and ActivityViewModel (MERGE DISCOVERY FIRST!)

📲 What
Remove the old BaseActivity and ActivityViewModel
Also remove some more old RX1 stuff that were using these classes
🤔 Why
Those classes were outdated and not going to be used in our new standard of coding
🛠 How
✂code✂
👀 See
No Visual Updates
📋 QA
Go through the app and make sure it all still works

This branch is built off of the changes for the discovery RX2 migration, please do not review or merge this until that branch is merged

Sorry, this turned into a massive PR

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 88.99676% with 34 lines in your changes missing coverage. Please review.

Project coverage is 68.14%. Comparing base (675b6ea) to head (075d4ac).

Files with missing lines
Patch %
Lines

...a/com/kickstarter/viewmodels/DiscoveryViewModel.kt
86.66%
10 Missing and 8 partials :warning:

...rc/main/java/com/kickstarter/libs/CurrentConfig.kt
88.09%
5 Missing :warning:

...tarter/libs/utils/extensions/DiscoveryParamsExt.kt
85.18%
2 Missing and 2 partials :warning:

...tarter/viewmodels/FacebookConfirmationViewModel.kt
94.66%
2 Missing and 2 partials :warning:

...ain/java/com/kickstarter/libs/NoopInternalTools.kt
33.33%
2 Missing :warning:

...er/ui/viewholders/ThanksCategoryHolderViewModel.kt
75.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2153      +/-   ##
============================================
+ Coverage     67.49%   68.14%   +0.65%
- Complexity     2215     2223       +8
============================================
  Files           368      365       -3
  Lines         22875    22692     -183
  Branches       3288     3264      -24
============================================
+ Hits          15439    15463      +24
+ Misses         5684     5477     -207
  Partials       1752     1752

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add the size of source code

It would be nice to see the size of source code in the editor, it usefull for cases when you prototype something and just want to see the impact fo the minifyer.
It is not a necessary feature, just to improve UX a little bit.

As in the non bundled source codes file size

I'm not sure if this is what you meant but I've added a src code size display,

Nice! Thank you!


Added some nice lists!

I resolved them.

@1w3j Thanks but I don't see a new commit or any changes... I will do it myself then.

Unfortunately I couldn't amend changes to your pull request directly, possibly because your fork has been deleted. I have committed your changes with my suggestions in 21b66b57ffe9b50a7ae8aebaebeb31d8a1a1dba0. Thanks again for your contribution!


feat: make intgration request and update integration request added in to utils file

description: feat: make intgration request and update integration request added in to utils file

@vishdha why is this in hotfix branch? rebase it to oct-sprint-1 branch

@vishdha why is this in hotfix branch? rebase it to oct-sprint-1 branch

when it will deploy on develop then?

@vishdha why is this in hotfix branch? rebase it to oct-sprint-1 branch

when it will deploy on develop then?
On which branch do you need this code and when?

Closing this added new PR https://github.com/Bloomstack/frappe/pull/794


Calculate the displacement of the center of the hip?

Description
Hi ! How to get the character's moving position from poseLandmarks to Unity's world coordinates

I don't know what you mean by "displacement", but maybe same as #432


Broken link to logger/context.go at https://docs.docker.com/engine/admin/logging/log_tags/

The page https://docs.docker.com/engine/admin/logging/log_tags/ provides link logging context to https://github.com/docker/docker/blob/master/daemon/logger/context.go that is not available any more.

I opened a pull request in the documentation repository to fix this; https://github.com/docker/docker.github.io/issues/1351


[Design] API for Transaction Mining

Phase 2 of our design to reduce costs involves creating an API for mining transactions that is independent from the main API.
To summarize, the layout is:
 +-------+
 |Wallets|
 +-------+
     |
     |      +------------------+
     v      |                  |
 HTTP API+--+ Tx Mining Server +---+Stratum
            |                  |       ^
            +------------------+       |
                                       |
                                   +------+
                                   |Miners|
                                   +------+

Wallets will call the API to mine transactions, and then call push-tx with the nonce included. The push-tx API should continue to accept transactions without nonce for a while, and in the future only accept txs mined externally.
We will connnect miners to the Tx mining server stratum, which will replace our only practical use for the Stratum built-in on the fullnode.

The HTTP API should look like this (specific formats, endpoint names, field names are up to change):

/submit-job: endpoint for the wallet to submit the required data to be mined, the server will return a job-id, and an estimated mining time
/job-status: the wallet, now in possession of a job-id, can request to check the status of a mining job at any time, these are the possible answers:

the job does not exist because either the job-id is incorrect or because it finished too long ago
the job is in progress, a new estimate will be returned
the job is finished, the nonce is returned, after a while (TBD) this job will be deleted

The reasons for this API to be modeled in a way that the client has to make multiple requests are:

Simpler implementation
No long polling requests: makes request throttoling make much more sense, fast responses are the norm, timed-out requests will always be an error (i.e. will never mean that mining could not finish in time)
Time estimate: the server knows its hashrate and rate of incoming mining requests, which it can use to estimate how long it will take for the mining to finish, this has a lot of UX improvement potential

Future improvements

This same design could be used to require a server fee
This same design could also be used to make a mining marketplace (external miners can receive the fees or a portion of the fees)
The tx-mining-server could push the transaction to the network, this might make sense if the proof-of-work ever becomes high enough that there is a significant fee/mining-time trade off, then it would make sense for a low-fee long-wait option, and it would be more practical for the tx-mining-server to push the transaction so a wallet actively waiting for a job result to push the transaction is not needed

On submit-job, what data did you plan to send? We need to make sure people can't abuse or attack the tx miners, possibly by sending a malformed or invalid tx.

It seems good to me, but I think we should give at least one example of the requests and responses. We should also add a throttling to both endpoints.

On /submit-job, what data did you plan to send? We need to make sure people can't abuse or attack the tx miners, possibly by sending a malformed or invalid tx.

Today we won't be any worse off by receiving the same data we receive on the push-tx endpoint

It seems good to me, but I think we should give at least one example of the requests and responses.

I'll work on adding and example.

We should also add a throttling to both endpoints.

We should use the same nginx throttling strategy as used on fullnode APIs.

For me it's good.
Only one thing was not 100% clear. After sending the first request (/submit-job) the wallets will need to check from time to time if the job is already finished, right?
If that's the case we should include this UI change in the wallet, so we can give a more precise feedback (Solving tx pow. ETA X. Then move to 'Propagate tx to the network'. Then success).

Another thing should be discussed is what will be done with the current thin_wallet/send_tokens API.
We should deprecate it but keep compatibility because old wallets might still be using it. And as @jansegre said

We will connnect miners to the Tx mining server stratum, which will replace our only practical use for the Stratum built-in on the fullnode.

When we decide that it's good to remove the compatibility with the old API we can think about removing the Stratum built-in on the fullnode.

We will connnect miners to the Tx mining server stratum, which will replace our only practical use for the Stratum built-in on the fullnode.

Nowadays we still have the stratum api available for miners. I'm not sure how many people are using it, but we need to check that before we can remove it.

Nowadays we still have the stratum api available for miners. I'm not sure how many people are using it, but we need to check that before we can remove it.

@pedroferreira1 @obiyankenobi I created a card to track the deprecation of the built-in stratum

Another thing that should be discussed is what will be done with the current thin_wallet/send_tokens API.

@pedroferreira1 As currently proposed in HathorNetwork/hathor-core#67 self-mining should be deprecated after a while. I added checkboxes to help track the progress. But I think we can either discus specific detals there or on a new issue, and keep this one just for the design of this new system.

With the new tx-mining API:

generate tx locally (outputs and inputs without signature)
[request to fullnode API]: get parents (new API call)
sign inputs
[request to tx-mining API]: create tx mining job (since it returns a time estimate this can be used - for UI feedback)

Parents are not part of the signature, so we don't need to get them before contacting the mining server. The full node could add them as part of /push-tx.

Parents are not part of the signature, so we don't need to get them before contacting the mining server. The full node could add them as part of /push-tx.

Yes, we don't need the parents for the signature but the /push-tx expects the tx already mined (with the nonce). And to mine the tx we need the parents, so we need to add the parents before sending to the mining server, I think.

@pedroferreira1 As currently proposed in HathorNetwork/hathor-core#67 self-mining should be deprecated after a while. I added checkboxes to help track the progress. But I think we can either discus specific detals there or on a new issue, and keep this one just for the design of this new system.

Ok, I agree with you. We should discuss the deprecation in another issue
For me the design is good to close. Can you just confirm this question, please?

Only one thing was not 100% clear. After sending the first request (/submit-job) the wallets will need to check from time to time if the job is already finished, right?

I like the design, but I think we should get into the pooling strategy. Should we check the status every X seconds, where X is half the expected mining time?
I also think we can discuss the changes in both wallets. Today, after clicking on Send Tx, the user sees a "Sending..." screen. I think we should split it into two screens: "Signing tx...", then "Resolving tx...", and finally, "Sending tx...".
In the "Resolving tx..." we can use the expected time to fill a progress bar. The progress bar can grow from 0% to 100% linearly on max(2, 2*X seconds) (where X is the expected time). While it is growing, we should check for the mining status every max(0.5, X/2) seconds.

Yes, we don't need the parents for the signature but the /push-tx expects the tx already mined (with the nonce). And to mine the tx we need the parents, so we need to add the parents before sending to the mining server, I think.

We could use some other API instead of /push-tx, like the one we currently use for sending tokens. But why do we need the parents to mine a tx?

I think we should split it into two screens: "Signing tx...", then "Resolving tx...", and finally, "Sending tx...".
What's each step? I understand signing and sending, but what's resolving?

Also, while I think we could have a progress bar, I'd leave it for future improvements.

We could use some other API instead of /push-tx, like the one we currently use for sending tokens. But why do we need the parents to mine a tx?

The parents are part of the graph hash used to calculate the tx hash. We could discuss about removing it from there but I think this should be done elsewhere. Right now we need the parents before sending to the mine API, so we can use our current /push-tx endpoint after returning from the mining.

Also, while I think we could have a progress bar, I'd leave it for future improvements.

I agree we could leave for the future but I think we should at least give a feedback of the steps (like we do when using the ledger).

The parents are part of the graph hash used to calculate the tx hash. We could discuss about removing it from there but I think this should be done elsewhere.

I completely mixed up things. They are not in the signature but we do need them for mining. My bad.

Parents are not part of the signature, so we don't need to get them before contacting the mining server. The full node could add them as part of /push-tx.

Yes, as @pedroferreira1 said, they are needed for mining.

For me the design is good to close. Can you just confirm this question, please?

Only one thing was not 100% clear. After sending the first request (/submit-job) the wallets will need to check from time to time if the job is already finished, right?

Yes, the wallet will need to do some polling to get the result.

I like the design, but I think we should get into the pooling strategy. Should we check the status every X seconds, where X is half the expected mining time?
I also think we can discuss the changes in both wallets. Today, after clicking on Send Tx, the user sees a "Sending..." screen. I think we should split it into two screens: "Signing tx...", then "Resolving tx...", and finally, "Sending tx...".
In the "Resolving tx..." we can use the expected time to fill a progress bar. The progress bar can grow from 0% to 100% linearly on max(2, 2*X seconds) (where X is the expected time). While it is growing, we should check for the mining status every max(0.5, X/2) seconds.

I like discussing UI/UX, but I think we could do it directly on the pull request of the respective wallets. Mainly because we could opt for the faster implementation, and also because the current proposal seems to already supports a wide range of UI/UX options.
About the polling strategy, I'll add that as the recommended strategy.

This is good for me.
As Jan mentioned, we should debate wallet UI/UX on a separate issue on each wallet.

Good for me!

Good for me as well.


Implement a Gherkin parser in crystal programming languange

I recently found that Crystal Programming language has similar syntax as ruby(approx 90%). It is a static type but with extreme performance. This is the home page: http://crystal-lang.org/
It is very fast see the benchmarks: http://www.stefanwille.com/2015/05/redis-clients-crystal-vs-ruby-vs-c-vs-go/

I don't want an open ticket for every imaginable obscure language. Please send a pull request if you have implemented the parser for a particular language.


feat(lualine): add fzf extensions.

Description
Similar to #5175, add fzf integration with lualine.
Note that similar to #5175, integration with fzf is included unconditionally. I think we don't need to check if the users choose fzf as their default picker to conditionally add the fzf integration with lualine.
Screenshots
Before:

After:

ty


Update VSLanguageServerClient reference to be in lockstep with WTE

This will allow us to consume the OnTypeRename support.

LGTM. Did you have a chance to run through a few basic scenarios in the editor? SDK upgrades like these have occasionally led to some regressions.

I haven't. These sort of in-step with WTE package upgrades are a bit difficult to test. I'm hoping that once this is merged, I can get you guys to create an insertion PR. Once that is created, I can augment it with the appropriate WTE insertion changes and I'll install the PR build for verification.


RuntimeError: inconsistent tensor sizes

Hi,
When I run the “main.py”，I get this error:
File "main.py", line 230, in train
for i, (data, target, coord) in enumerate(data_loader):
File "/usr/local/lib/python2.7/dist-packages/torch/utils/data/dataloader.py", line 196, in next
return self._process_next_batch(batch)
File "/usr/local/lib/python2.7/dist-packages/torch/utils/data/dataloader.py", line 230, in _process_next_batch
raise batch.exc_type(batch.exc_msg)
RuntimeError: Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/torch/utils/data/dataloader.py", line 42, in _worker_loop
samples = collate_fn([dataset[i] for i in batch_indices])
File "/usr/local/lib/python2.7/dist-packages/torch/utils/data/dataloader.py", line 119, in default_collate
return [default_collate(samples) for samples in transposed]
File "/usr/local/lib/python2.7/dist-packages/torch/utils/data/dataloader.py", line 96, in default_collate
return torch.stack(batch, 0, out=out)
File "/usr/local/lib/python2.7/dist-packages/torch/functional.py", line 66, in stack
return torch.cat(inputs, dim, out=out)
RuntimeError: inconsistent tensor sizes at /pytorch/torch/lib/TH/generic/THTensorMath.c:2864
It works well when running on LUNA16 dataset. But I get this error when I run on the other dataset.
Could you please explain it? Thanks very much！

Could you please provide more information, such as the tensor size of data, target, coord?

@wentaozhu Thanks for your reply.
The tensor size of data, target, coord is
torch.Size([4, 1, 96, 96, 96])  torch.Size([4, 24, 24, 24, 3, 5])  torch.Size([4, 3, 24, 24, 24])

Oh. I see what you mean. The LUNA16 is right. Running on other datasets causes the problem. It may be caused by the data preparation. https://github.com/wentaozhu/DeepLung/blob/master/prepare.py Check the values and do not use the savenpy_luna because you do not lung segmentation.

@wentaozhu
I don't use your  'prepare.py'.
I use https://github.com/lfz/DSB2017/blob/master/training/prepare.py

Check whether there are some invalid values during preparation. I remember we removed some CTs during preparation.

I'm very interested in your work. I want to make a friend with you, may I?
You can send your WeChat or other chat tools to me by email.
My email address is<EMAIL_ADDRESS>I will be be more than happy to hear from you.

@wentaozhu
I find a difference between my preprocessed label and your preprocessed label.
My z value has a negative value, but your z value is only positive.
For example:
my **_label.npy:
[[  -8.5<PHONE_NUMBER>  222.796875     6.28125  ]]
[[ -21.          94.1640625<PHONE_NUMBER>    3.5015625]]
[[ 101.           82.22265625   22.68164062    3.73828125]]
your  **_label.npy:
[[74.79098309999998<PHONE_NUMBER>4000002 71.68981980999999 6.529558333]]
[[84.55161559999999<PHONE_NUMBER><PHONE_NUMBER>4 6.943515582]]
[[202.99999300000002<PHONE_NUMBER>7000003<PHONE_NUMBER>9999997
3.8311131889999994]
Does this cause 'inconsistent tensor sizes' error?

Yes. You can remove it. Added you.

@wentaozhu Thanks, the problem is solved.


Check existance of seed/nthread keys before checking their value.

Currently, XGBClassifier.get_xgb_params() throws an error if seed or nthread are missing from the __init__ method of a child class of XGBClassifier.  Since nthread and seed are deprecated, we should not force child classes of XGBClassifier to include nthread and seed in the __init__ method.  This PR fixes the issue in XGBClassifier.get_xgb_params() by checking for the existence of the nthread and seed keys in the xgb_params dict before checking the values associated with the keys.

Codecov Report

Merging #2669 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2669      +/-   ##
==========================================
+ Coverage   37.57%   37.64%   +0.06%
==========================================
  Files          82       82
  Lines        7254     7254
  Branches      710      710
==========================================
+ Hits         2726     2731       +5
  Misses       4386     4386
+ Partials      142      137       -5

Impacted Files
Coverage Δ

src/metric/rank_metric.cc
91.35% <0%> (+0.54%)
:arrow_up:

src/data/sparse_page_dmatrix.cc
87.43% <0%> (+0.54%)
:arrow_up:

src/predictor/cpu_predictor.cc
72.9% <0%> (+0.64%)
:arrow_up:

src/objective/regression_obj.cc
87.43% <0%> (+1.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9d064...c738b32. Read the comment docs.

@wxchan I believe this touches code that you wrote recently, let me know your thoughts!


UnrealEnginePython_20181020_4_19_python27_win64   Can't use

Hello, I downloaded this version of the file, I installed python2.7 in Windows, and the environment variable path added python's path, but the project was opened incorrectly, please ask for help. Thank you very much!

Try to create an empty Python script named ue_site.py in your content folder. It has to be in a folder named Scripts.


issue

 Environment data

Language Server version: 2023.4.30
OS and version: win32 x64
Python version (and distribution if applicable, e.g. Anaconda):
python.analysis.indexing: true
python.analysis.typeCheckingMode: off

 Code Snippet

XXX

 Repro Steps

XXX

 Expected behavior
XXX
 Actual behavior
XXX
 Logs

XXX

Thanks for logging an issue.
Unfortunately, we need more information to figure out what your problem is.
Please enter the information as described here:
https://github.com/microsoft/pylance-release/blob/main/TROUBLESHOOTING.md#filing-an-issue


Prevent values of 9999 from entering the database

Seb found in the OpenAQ code that if a station is not providing a value for a pollutant then a value of 9999 is assigned (code here).  These values should be filtered out of the ETL process such that we don't store them.
Acceptance Criteria

There are no longer values of 9999 in the database, we filter out based on the original_value being 9999
Delete all pollutant values from the deployed database where the original_value is 9999
Ensure test are happy they have what they need before pulling the trigger on the delete

Test Checklist:

[x] Test Analysis & discussion with developer
[ ] Write Test Cases / Charters
[ ] Test Cases & Charters Reviewed
[ ] Test Cases Executed
[ ] Test Charters Executed
[ ] Regression tests executed
[ ] Automation Tests added to project

Test Analysis

Need to verify any existing original_value 9999s are removed from database

pre-deployment go and find existing examples of individual pollutants with values 9999 and verify the pollutant readings are removed post-deployment
pre-deployment go and find existing examples of documents where all pollutant values are 9999 and verify the documents are removed post-deployment

Integration test required - mock openAQ response

with pollutant value 9999, verify pollutant reading not added to the document with other valid pollutant readings
with all pollutant values for a site 9999, verify document not added to database

{
$and: [
{ "no2.original_value": 9999 },
{ "o3.original_value": 9999 },
{ "pm10.original_value": 9999 },
{ "pm2_5.original_value": 9999 },
{ "so2.original_value": 9999 }
]
}
{
$or: [
{
"no2.original_value": {
$gt: 500,
$lt: 9999
}
},
{
"o3.original_value": { $gt: 500, $lt: 9999 }
},
{
"pm10.original_value": {
$gt: 500,
$lt: 9999
}
},
{
"pm2_5.original_value": {
$gt: 500,
$lt: 9999
}
},
{
"so2.original_value": {
$gt: 500,
$lt: 9999
}
}
]
}

Before the change, there were 162 documents in the in_situ_data collection with all 5 pollutants registered as 9999

after, 0

both queries return no results in prod database now:
{
$and: [
{ "no2.original_value": 9999 },
{ "o3.original_value": 9999 },
{ "pm10.original_value": 9999 },
{ "pm2_5.original_value": 9999 },
{ "so2.original_value": 9999 }
]
}

{
$or: [
{ "no2.original_value": 9999 },
{ "o3.original_value": 9999 },
{ "pm10.original_value": 9999 },
{ "pm2_5.original_value": 9999 },
{ "so2.original_value": 9999 }
]
}
Before the deletion, I pulled every item in the database with pollutant values between 500 and 9998 to check they remain after the deletion of 9999 usign the below query:
{
$or: [
{
"no2.original_value": {
$gt: 500,
$lt: 9999
}
},
{
"o3.original_value": { $gt: 500, $lt: 9999 }
},
{
"pm10.original_value": {
$gt: 500,
$lt: 9999
}
},
{
"pm2_5.original_value": {
$gt: 500,
$lt: 9999
}
},
{
"so2.original_value": {
$gt: 500,
$lt: 9999
}
}
]
}
Running this query again after deletion, and comparing the spreadsheets (after sorting by name and measurement date), using a formula such as =AND(C3:J3=L3:S3) I was able to verify the data remained


Some cleanups to make the code more readable

I like it, merging. Thanks.

Thanks for merging! Can we expect a new release soon with the recent changes?

I'd personally like to get the default colors working for continuous output on Firefox/Chrome before releasing.
Speaking of which, let me look at that today.

Right, I already forgot about that one ;-)


No problem just a question

Can you give me the Modbus register addresses for the Deye Hybrid Inverters? I would like to do the configuration myself in the Modbus yaml, I did it myself with my SMA inverter.
If you have a document or a link to it, that would be enough for me.

Here you find the modbus registers:

Thank you very much you helped me a lot.


TabView fixes

Description
This PR fixes the following bugs:

When selecting a partially hidden tab when in overflow state, the full tab does not come into view (end of the tab is cut off from view). Updated StartBringIntoView() to add pixel padding to the TargetRect width.
Tab is cut off when creating a new tab where the last tab is selected and changes to scrolling mode.
Rearranging a selected tab does not keep the tab in view after being dropped

Motivation and Context
Fixes internal bugs 37609293, 37608918, 37608607

/azp run

/azp run


Interface labels in system font

Some of the interface labels would look better if they were in a system font (like Roboto) rather than font1.
e.g. the navigation drawer menu items, 'BOOK', 'CHAPTER', 'Highlights', 'About', etc.

@rpmargetts Looking at the fonts for "BOOK" (and other elements in the UI), it looks like it is using system fonts:
ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"
Are you wanting a different set of fonts?

@chrisvire, when I look at https://pwa-pr-208.surge.sh/, it is using the #container font-family for BOOK and CHAPTER, which is set to font1. There is no font-family set on .dy-tab.


Mobile view issue

Hello!
It is a great project, the problem is that when you open the game from your mobile, the view of the planet does not adapt to the screen of the phone and you can not zoom, so playing from the phone becomes strange.
Thank you!

@Alberolle7 Thanks for the suggestion.


⚠ Bofrost.be has degraded performance

In 1fdcb69, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1132 ms

Resolved: Bofrost.be performance has improved in ce4c5d8 after 6 minutes.


move sebastian/exporter lib to require section

Since the library is used in the AbstractConfigurationConstraint
class it must be included in the require section. Otherwise, it was
not usable in projects that did not require sebastian/exporter
themself.
This fixes #22.

Thanks! Don't you think that phpunit/phpunit should also be in the require section? Since the base classes are in that package, right. Anyway, I can just merge this as is since it fixes the previous issue.

@matthiasnoback You are right. I did not think about that (see #24).


Add full results of lm fits to OaxacaBlinderDecomp() output

As I mentioned in https://github.com/sinanpl/OaxacaBlinder/issues/5#issuecomment-1981561085, it might be a good idea to include the full output of each lm() call in the OaxacaBlinderDecomp results object.
Some pros and cons I can think of:
Pro

It'd allow functions like summary() and coef() to query more stuff from the fitted models
It'd tightly couple info about the models to the models that were actually fit, eliminating stuff like #5
It'd defer to lm() the decisions about what info to include in results (aside from the stuff that's unique to Blinder-Oaxaca)
It might make it easier to build further extensions like broom tidiers

Con

It could make OaxacaBlinderDecomp objects bigger (unless the current meta$data is removed)
The teeming throngs of OaxacaBlinder users might start to depend on the extra results, which could make it hard to take them away later if we change our minds

FWIW, oaxaca::oaxaca()'s output does seem to include the full fit objects, although its results are pretty maximal in general so I'm not sure that's something to emulate.
I'm on the fence about this one: I think I lean toward including the full lm fits eventually; but right now this only really affects #5, so maybe it's worth being more conservative and not including them until we have more actual use cases?
#5 does depend on this though, so @sinanpl let me know what you think.

can be considered!
i don't expect the object size to be a large issue here if the lm and OaxacaBlinderDecomp are cleverly stripped from overlapping data. in retrospect, it also helps debugging
i am not sure about how this relates to #5 - which is an issue that has to be solved regardless of including model fits, right?

Sounds good.  I don't think this is a super-high priority for me just yet, but I guess if it becomes so I can try to code this in and send a PR?

cleverly stripped from overlapping data

What do you mean by this?  (Though frankly, your point that object size might not be worth worrying about could be right regardless.)

i am not sure about how this relates to #5 - which is an issue that has to be solved regardless of including model fits, right?

Yes, in that issue the group sizes are calculated wrong because summary() queries the original input data and handles the NAs wrong.  But if the lm objects were in the OaxacaBlinderDecomp object, as this issue suggests, then I think it'd be easy to fix #5 by just having summary() query the model frame from the OaxacaBlinderDecomp's lm objects (in which the NAs are already properly handled).

Sounds good. I don't think this is a super-high priority for me just yet, but I guess if it becomes so I can try to code this in and send a PR?

Sure!

cleverly stripped from overlapping data

What do you mean by this? (Though frankly, your point that object size might not be worth worrying about could be right regardless.)

Fitted models to be included in these cases are: model for group A, model for group B and model for group A + B. Each lm object contains the source data. In this case, we could choose to remove the source data and only inlude one copy of the input dataset. Tbh, for I don't expect this to be a big problem nonetheless. If you feel like starting such a feature, feel free to include the 3 models as-is including all data.

Yes, in that issue the group sizes are calculated wrong because summary() queries the original input data and handles the NAs wrong. But if the lm objects were in the OaxacaBlinderDecomp object, as this issue suggests, then I think it'd be easy to fix #5 by just having summary() query the model frame from the OaxacaBlinderDecomp's lm objects (in which the NAs are already properly handled).

Noted, if models are included, the count can be extracted from the model objects.

Now depends #18 I believe.


Make testDirectMessageEcho not Oragono-specific

This is almost certainly fine (not sure what the conflict is?)


Cache factories result in local storage

Is your feature request related to a problem? Please describe.
Faster first paint 🏃
Describe the solution you'd like
Cached the API fetched factories data in local storage. Need to consider the cache timestamp and invalidation.

Related pin cluster issue
https://github.com/Disfactory/frontend/issues/121

可以用 swrv 或 vue-query 實作

https://github.com/Kong/swrv


second you have unsaved changes at bottom of list?

to make it more obvious

done (see next commit)


More readable assert_eq proposal

Rendered
Improve assert_eq failure message formatting to increase legibility
A continuation of https://github.com/rust-lang/rfcs/issues/1864.

I think panics in general could benefit from a multi-line scheme

@jethrogb While I wouldn't want to block this focused PR over that, yes, in general I'd love to see panics handled more gracefully.  I don't want to encourage people to use .unwrap(), but right now even .expect(...) produces a fairly user-hostile message.

Do note that textual diffs (mis)take the map for the territory; a == b does not imply that a and b have the same Debug output.  (e.g. -0. == 0.)
I don't think should be a deal breaker; but it is a limitation which spells diminishing returns for text-based strategies.  Compared to textual diffs, the linebreaks and 1-space alignment in the RFC provide quite a bit more bang to the buck.

I think we should only do string based diffing for strings, other types could have their own algorithms.

I think we should only do string based diffing for strings, other types could have their own algorithms.

Unfortunately that would require a new trait bound for assert_eq! (or an addition to the Debug trait), which seems to me like a nonstarter...
This is something that could be experimented with in a third party crate though.

Should we generally not put too many words into the panic message?
That is, print out details then panic with a short message. Something like this:
---- assertion `(left == right)` failed ----
left:  `"Syntax Error: a.rb:1: syntax error, unexpected end-of-input\n\n"`
right: `"Syntax error: a.rb:1: syntax error, unexpected end-of-input\n\n"`
         ~~~~~~ ^ ~~~~

---- log_packet::tests::syntax_error_test stdout ----
        thread 'log_packet::tests::syntax_error_test' panicked at 'assertion failure', src/log_packet.rs:102
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Thank you :)

@lpil Thanks so much for this! I think the libs team is generally in favor of this, and we think this could probably could have squeak its way through as a PR. However, we should just move forward with the RFC since it is already written. :-)

As the stdlib does not contain any terminal colour manipulation features

rustc certainly emits colored error messages, so there must be some support for that.

Might be a bit late but I think this would be great and really plays into the ergonomics goal of Rust in 2017. I'm in favor of it. If it could look like the Elixir example given in the RFC I'd prefer that personally but LLVM style arrows is good too if that's not possible yet.

The RFC should also address assert_ne (as suggested in https://github.com/rust-lang/rfcs/issues/1864#issuecomment-274386731).
How would those LLVM style arrows look like, if both left/right expressions wrap around several lines and the difference is somewhere in the middle? Would that still be readable and look good?
Just as a sidenote: git diff --word-diff uses a format, which is also readable without colors.
The quick [-red-]{+brown+} fox jumps over the lazy dog

Maybe printing a diff in this style could be a colorless alternative to LLVM style arrows, but it might become less readable or even ambiguous if the underlying text contains a lot of special characters, too.
Alternatively, inspecting/printing the diff of the debug outputs could be left to a third party crate like pretty_assertions. As already pointed out, diffing the debug output is nothing more than a heuristic anyway, since debug output equality can be completely unrelated to the values equality.

I've had a chance to use pretty_assertions recently and it made a painful search for a bug trivial 🎉
It would be useful for developing rustc itself, as we now have output diff tests for which line diff output can be very annoying to decipher (most of the lines look identical anyway, with small changes sprinkled).

It clearly is a major improvement which will surely make using Rust even more comfortable than it currently is. I don't see any reason why it shouldn't be approved. As mentioned above, colours would be great but we can settle for LLVM style arrows if that's currently not possible.

I think assert_ne should also switch to multi-line display. But highlighting difference only makes sense for assert_eq, not assert_ne. After all assert_ne is expected to fail when both variables are identical.

Unfortunately that would require a new trait bound for assert_eq! (or an addition to the Debug trait), which seems to me like a nonstarter...

Specialization provides a backwards compatible manner to add this feature: create a new trait AssertFormat for the richer formatting, and use trait specialization to either print using just Debug info (for types that don't implement AssertFormat) or Debug and AssertFormat.

Note that this has been discussed before: https://users.rust-lang.org/t/suggestions-for-better-test-output/7494

This RFC has now been merged! Discussion should move to the tracking issue.
I added a couple of unresolved questions, one of them for assert_ne; these should be resolved during the implementation, and I encourage folks to discuss them on the tracking issue.
For some reason github isn't recognizing the merge, so I'm going to manually close, but the official RFC is here.

Thank you :)

This is not strickly related to the RFC -- I think this is a great first step! -- but do you think we could have a new traits related to the Eq* variety, like maybe DebugEq and DebugPartialEq that would help with the debugging of more complex types like Array's and HashMaps. These types would return either Ok(()) for equal or Err(String) for not-equal with helpful information.
I ask because this is really great for comparing strings but does almost nothing in those extremely common cases.
Again, super happy to see this change!


 Let's investigate where all the weight is coming from. Maybe there's an opportunity to slim down the jar?

Interestingly alot of discussion is taken around reducing binary file sizes for android. I think it can be applied here:
Here is an example of reducing kotlin std lib by up to 99% by using the d8 obsfucation tool. Could possibly apply it here to reduce size if we cannot isolate out why it is so big in the first place.
https://jakewharton.com/shrinking-a-kotlin-binary/

that's awesome!

@bootstraponline ill assign it to myself as i have a good idea where to start.

Sounds good! For clarity, this ticket is about understanding the size. Once that's known, then I think we'd create another ticket to evaluate solutions.

So after some investigation,
The size of the expanded Flank jar contains many dependacies. The following dependacies are listed based on their size when expanded from a built Flank.jar file.

Total Size: 145.5 MB
com.google-> 31.8 MB

common-> 10.4 MB
api-> 9.3 MB
protobuf-> 6.2 MB
cloud-> 2.4 MB
gson-> 824 KB
other-> ~2.7 MB

com.fasterxml.jackson-> 7.3 MB
com.ctc.wstx->5.5 MB
com.bugsnag-> 286 KBS
io.netty-> 25.6 MB
io.ktor-> 10.9 MB
io.opencensus-> 1.7 MB
org.apache.(http, threeten)-> 17 MB
kotlinx-> 5.6 MB
kotlin libraries -> 18.5 MB
Binaries
nm-> 17MB

The largest collection of libraries come from the com.google namespace, then from io.netty, io.ktor and general kotlin libraries.
I will look into the actual dependancies in gradle and try see if there are any obvious issues.

Awesome. might be worth looking into graalvm

use a Graal native image to produce a minimal native binary
https://jakewharton.com/shrinking-a-kotlin-binary/

Yes, @bootstraponline thats definitely a good investigation point.
I see though from the investigation above that a-lot of the libraries are either essential to the project and/or sub-dependancies of other libraries. Especially since the google.commons is so large.
Therefore i investigated how we made the shadow jar.
There is a simple fix that can be applied for the gradle script for the shadow jar process:
https://imperceptiblethoughts.com/shadow/configuration/minimizing/
There is also a good reason to look into graalvm. i assume for graal we would be using the community edition (free).
There is also the possibility to apply the d8 optimisation tool that is well used within android (to create apks and lib files).
Lets create some sub-tasks and investigate each one independently.

GraalVM
D8
ShadowJar minimisation

I think this ticket "Understand Flank jar size" is done. We have an understanding now of why the Flank jar is large. The additional tasks will handle the actual reduction of the jar size.

@bootstraponline Sure!


ERROR: Audit report was not generated properly, skipped reporting

Cookbook version 5.0.3
[Version of the cookbook where you are encountering the issue]
Chef-client version Chef: 13.2.20
Platform Details ubuntu 16.04
Scenario: when trying to run audit cookbook and trying to make it as compliance node.
Expected Result: node should be added to the compliance and visible in chef automate UI
Actual Result:
WARN: No audit tests are defined.
ERROR: Audit report was not generated properly, skipped reporting
Attributes/default.rb
default['audit']['reporter'] = ['chef-server-automate','json-file']
default['audit']['profiles'] = [
{
'name': 'InSpec Profile',
'compliance': 'admin/cassandra'
}
]

@siddhu07 The error you're receiving indicates that there were no InSpec profiles configured to run so no report was generated. I'm afraid without any additional details, it's difficult to determine where the problem lies.
Can you please share additional information about how you configured the audit cookbook? What node attributes did you set?

@adamleff i have updated my question. i just downloaded audit cookbook from supermarket and tried to bootstrap. And i tried other way, just created a cookbook added "depends  audit" in metadata.rb and edited recipe, and tried to bootstrap.

thanks @adamleff , i got it. i bootstrapped with wrapper cookbook, deleted all dependencies and started from first.


How to disable/enable the datepicker on select dropdown value?

I tried using the headless attribute to disable but it doesn't work.
How to disable the datepicker?

@goutame headless disables the input box inside the datepicker. You can create a button that will open datepicker and disable it:
<button [disabled]="true" (click)="picker.toggle()" />
<ng2-datepicker [headless]="true" #picker></ng2-datepicker>


JsonCursor[From, To]

@jdegoes some quick questions here

Getting this into the topic branch, we can revisit the PR for discussion if necessary.


Set-up Levels

with voice chat too?

After further research, the event:

async def on_message(message):

will probably need to be overloaded, and adjusted into the background task.


Access requirements

When I read the documentation I got the impression that the PAT's in the config file are all you need to migrate a process.
But it turns out that I had to be logged in with my own Azure Devops admin account as well. Otherwise I get this error message:
VS402356: You do not have the permissions required to perform the attempted operation on this process.
Is this written somewhere in the documentation or is it a bug?

@code-on-git was this in the export or import phase?

It was in the import phase.

Thanks. Which Azure DevOps versions are you migrating from and to? The PAT should only need the "Work Items 'Read, Write, & Manage" permission scope.

From: Version Dev19.M235.1 (AzureDevOps_M235_20240304.10)
To: Version Dev19.M235.1 (AzureDevOps_M235_20240311.1)

Hi, I just tested it, and you don't need to be logged in

@code-on-git Had the same issue.
Problem was that i set the rights in the token, but my user itself did not have permissions to create a process on organisation level.
I did not find that requirement explicitely mentioned in the docu.


Always seems to set content type to Application/json

Run this: https://github.com/Azure/azure-webjobs-sdk-script/blob/d485616f4919fa22e984365a82fd3fab12869692/sample/HttpTrigger/index.js#L24
The content type set is always application/json
Is the sample current?

@mamaso Please investigate, could be related to changes in content negotiation.
Investigation should be in this milestone though fix might not be.

I can't repro this, @AndyCross are you using the latest version of functions (~1)?

I can't repro this either in production. Closing as no repro.


Do not use defer for unlocking in Scratch

It is a fairly costly operation:
benchmark                 old ns/op     new ns/op     delta
BenchmarkScratchGet-4     109           31.6          -71.01%

benchmark                 old allocs     new allocs     delta
BenchmarkScratchGet-4     0              0              +0.00%

benchmark                 old bytes     new bytes     delta
BenchmarkScratchGet-4     0             0             +0.00%
´´´

lgtm

Merged in c846b05

Also see: https://github.com/golang/go/issues/14939
For future reference: defer is a brilliant construct for closing files etc.; but if you use it in high-frequent places (millions ... billions of invocations?) it may be worth to do it explicit. 109 nanoseconds is a short time span, but it adds up.


provides a optional-plugin for tracking ignores enhancement(#1203)

Please answer these questions before submitting pull request

Why submit this pull request?

New feature provided

Related issues
#1203

New feature or improvement

The applications can set paths in the plugin cofig file to let agent ignore tracing, use ant path match
This plugin after packing will create its own directory in optional-plugins parent directory, this directory has README.md file(introduce how to use this plugin), config file(plugin config) and plugin jar. I  also write an unit test for the plugin

Maybe we can also support reading trace.ignore_path from environment variables.

Coverage increased (+0.4%) to 23.788% when pulling 18790363b3ba50738ea3e577b63506fce16a4e77 on SevenPointOld:master into 1bbd5e1c28afed0784834978cdba33d074a536a1 on apache:master.

I have revised code and pushed to repository, please review the new request

This is current optional-plugins look like

In the AntPathMatcher , the most of the code is copied form Spring Framework. I only remove the superfluous method, and make some revise  in order to pass through  checkstyle.
I've never had such experience before, and I don't know what the effect of adding Apache license to the code will be.
I'm sorry about that. If this can not be merged, I think it might be possible to use these extended functions in the form of third party plugins.

I'm sorry about that. If this can not be merged, I think it might be possible to use these extended functions in the form of third party plugins.

@SevenPointOld There is no need to sorry. But we do need to deal with source codes used, rather then distribution(*.jar) used in this cases.
I am going to ask our Apache mentor @michaelsembwever  to some suggestions. But I believe, we have to adjust LICENSE and NOTICE files in root.

This is current optional-plugins look like

Sorry, I didn't make myself clear. I mean what look like in distribution? After your package, you should find it in dist folder, and unzip it.

After your package, you should find it in dist folder, and unzip it.

After unzip it,  the whole distribution like this

@SevenPointOld Good to share. I think it is good. The last thing before merge, is we have to process the LICENSE in right way. Let's wait our mentor's suggestion.

@wu-sheng, i do not know how strict ASF would be on this, because Spring is also under Apache 2.0 license. But you can't just transfer the copyright like that.
So to be safe I would take the approach of using AntPathMatcher from the original dependency. That original dependency can be stripped down to just the one class, and the package name refactored for safety. This can be done using either, or both, the maven dependency and shade plugins.

@SevenPointOld please use shade plugin to transfer this class from spring denpendency, rather then use code copy. like this https://maven.apache.org/plugins/maven-shade-plugin/examples/class-relocation.html Please notice, only transfer the only one you need.
Based on this, I can trust on License.

@wu-sheng  Should I create a new module as a dependent transformation?

@SevenPointOld I think should add in this plugin module.

I think should add in this plugin module.

What about the distribution look like this?

Why do you want the redistribition in the separated module and jar?

Please notice, only transfer the only one you need
It's hard to transfer the only one, because of the Spring AntPathMatcher import some util class, the other util class also import others,  but they all belong to a same package, can I transfer the whole package org.springframework.util? exclude child package of course

@SevenPointOld Could you finish this PR soon? I look forward to merge this pr into beta2 release.

@wu-sheng  I'll try to rewrite the match logic.

I'll try to rewrite the match logic.

Try to make it a simple and easy one, at the first edition.

Promise

Merged, hope you could provide a blog to tell people to use it.

@SevenPointOld I think you miss add your README to incubating features menu.

Also, you should consider to add a section in Chinese document: https://github.com/apache/incubator-skywalking/blob/master/docs/README_ZH.md  The title should be 孵化特性.

OK,  I'll do it


The O'clock always shows as Oh clock

In the preview screenshots included in tweak desc, shows the time showing as 'six O'Clock', all mine shows it as is 'six oh clock' how do i change it? Ive messed with all settings & nothing has the time showing the right way, O' & oh are too different lol

Ill close this, apparently the O' is for 12hr clock, the oh is 24hr clock..


[sdc] Add clarifying comments to SDC file

Some of the constraints in the SDC file were not fully clear and this commit adds comments to provide relevant background information.
This is a follow-up of lowRISC/OpenTitan#24221.

LGTM

Thanks for your review @meisnere .
After discussing with @andreaskurth , I've now moved the PrimeTime waivers for SPI Host 1 to the section only active in PrimTime but not considered for synthesis.


Extract some Seq/IndexedSeq methods into a IndexedTraversable interface?

I'm looking at implementing an ArraySet, an order-preserving collection with O(1) indexed access, backed by an Array and a HashSet. Most IndexedSeq methods still make reasonable sense for an IndexedSeq that allows only unique elements, but some are more problematic if we want them to return the same type:

crossProduct() must either return a different, non-unique type, or drop some combinations
intersperse(T) must either return a different, non-unique type, or be interpreted as insert(1, element)
padTo() and leftPadTo() have similar problems, and cannot be guaranteed to return a (unique) sequence of the correct size

(Also, the behavior of insert(int, T) is somewhat undefined (if the element already exists, should we return this, or create a copy that moves the element to the new index?). Likewise insertAll(int, Iterable<? extends T>).)
It would be nice if the methods that don't assume duplicate values are allowed were on a superinterface that could be implemented cleanly.

Just a thought. Maybe it's worth considering splitting the base interfaces of IndexedSeq and Seq and others to a read-only view interface that doesn't allow any "change" (change in case of immutable collections meaning, of course, returning new instances of the underlying collection type), and another interface for the "change" methods. With that, types like ArraySet could be viewed as an indexed sequence, but not manipulated as one, as that doesn't really make sense in the context of ArraySet.

Hmm. You could say you can view ArraySet as a Seq but only manipulate it as a Set. But I do think that append(), prepend() etc. still make sense most of the time, as well as indexed methods like insert() and removeAt().

I don't know. What would be the the defined behavior if you would prepend an element into an ArraySet, that already contains that element. Same for append or insert? Maybe removeAt could make sense, but with all the other IndexedSeq methods not being self-evident, I tend to think that it's better not to have them in the first place. ArraySeq would be a special collection type, with well-defined behavior for some operations, and not so well-defined for others. Maybe it would be simpler to have just those operations that are self-evident. Having more fine-grained separation of interfaces might help achieving that goal.

A HashSet is near O(1) access - the default java implementation is actual O(load factor) which defaults to .75n. EnumSet in java definitely is O(1) because it uses the enum ordinal to index an array. The only way you can EVER achieve true O(1) access on a set is if the data is in a fixed domain bound (like a collection of enums). A general purpose hash can't do that but can get close enough
As for your order preserving requirement, I assume you mean iteration order - that's trivially implemented now with Java LinkedHashSet backed by a LinkedList
So: A vavr implementation would be a io.vavr.List + io.vavr.immutable.HashSet. The only addition would be to add the "before and after" indices for each entry so you can remove an element and connect the 2 elements in the LinkedList in O(1).
Basically what I am saying is: you're over thinking it. Implement a vavr version of a java LinkedHashSet and you're off to the races

@danieldietrich that sounds like a very good solution.

@chb0github I'm not clear on what you're proposing. Access to element m of an n-element HashSet (or LinkedHashSet) isn't O(1), it's O(n).

@dmolesUC3 Unless I am reading something different the run time for a HashMap in plain java is f * O(n) where f is the load factor. The default is .75. This is a classic implementation and is pretty easy to visualize: in an empty hash table any particular entry has a 1/t probability of colliding with a previous entry and thus requiring a resolution phase like mod-prob or linked list. Stands to reason that the more elements you put into a fixed size HashMap or set the more likely there is a collision such that it approaches O(N). The entries from wikipedia make it pretty clear that for a uniform, randomly distributed hash, this is amortized O(1)
The Linked part of LinkedHashSet is for iteration order . if you use the hash table to lookup the nodes to manipulate in the linked list that backs it, you can insert, delete and update in O(1) too.
Debate this point all you want - refer back to the above links when you do.
All I am saying is that you're overthinking the implementation.

Set doesn't not have an index. They are not numbered. So, you don't. Maybe I don't understand what the objective is. Hashing is, by it's nature, not indexable. I mean what would set.elementAt(1) retrieve? The element in the table at position 1 assumes

The underlying table event has something at position 1
Is based on an indexable structure like an array

Are you trying to have a Set with a predictable iteration order? That's perfectly reasonable and it's because of this you could fake it. So, if you would expect that `set.elementAt(1) would retrieve the 1st element in an iteration order than that's fine and useful.

@chb0github that's what ArraySet would provide. HashSet combined with Array, to provide (read-only) indexed access of insertion order in O(1).

Ok, now I get what you're after. Maybe just having an interface of Indexed and then IndexedSet and List and Vector already implement Indexed where as Set does not but IndexedSet does

Seq/Set are distinct Traversable types. We are able to add required methods to Set (that may also be present in Seq) without having a common super-type (like the imaginary IndexedTraversable). We will not introduce additional general collection interfaces (even if non-public).

It will be annoying to have to duplicate code that makes use of the similar methods, but I suppose that would still handle many use cases. Maybe some time around Java SE 15 we'll get proper structural typing.

When having proper Java 9 modules it will be a different story. Then (I think, without having verified it) it is possible to hide technical types from reflection. We will see...


fix simple issue #263

This PR makes the following changes:

logger.info (https://docs.python.org/3/library/logging.html)

I tested this PR by...
Fixes #263 .

Hi @tyg03485, thanks for filing this fix! I have one nitpick, and this should be good to merge in.

I made the change myself. Merging this in. 감사합니다. :)


Initialize context in opt::Instruction's move constructor

Fixes #4396.

@afd @s-perron @alan-baker ping.

@Vasniktel Can you rebase? The bots should pass then.


ci: fix clang-tidy

Description:
Fixes #9512.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Signed-off-by: Lizan Zhou<EMAIL_ADDRESS>

Need https://github.com/envoyproxy/envoy-build-tools/pull/39 and a image update for export-fixes

If you need 2 more test cases, these should be updated to nullptr which is covered by modernize-use-nullptr
https://github.com/envoyproxy/envoy/blob/master/source/common/http/utility.cc#L555
https://github.com/envoyproxy/envoy/blob/master/source/common/api/win32/os_sys_calls_impl.cc#L58

FYI - I don't mind doing the busy work of fixing the things flagged by clang-tidy once we have this correctly reporting the problems. I'll merge Lizan's branch locally and have a separate PR fixing the issues that we can merge, and that would make this PR green to merge.

I'm waiting for image update #10506 to make this CI green

I'm waiting for image update #10506 to make this CI green

oh yeah - it only runs on the diff.

@htuch good to go, verified clang-tidy CI detects failure: https://dev.azure.com/cncf/envoy/_build/results?buildId=35761&view=logs&jobId=3bf5ec37-bb6f-5fb6-2cf1-5134dc6106d6&j=3bf5ec37-bb6f-5fb6-2cf1-5134dc6106d6&t=41d571fe-3811-578d-07de-68468f467dae


How to deserialize into enums without failing with 'unknown variant'?

I currently use serde_json for a side project in order to parse GitHub events API's output.
The GitHub events API returns many event actions, such as:

created
rerequested
requested_action
etc.

I am trying to use serde_json::from_str to parse events for a subset of event actions. I have tried the workaround from issue https://github.com/serde-rs/serde/issues/912#issuecomment-379032835
#[derive(Debug, Deserialize, Eq, PartialEq)]
pub enum Action {
    #[allow(non_camel_case_types)]
    created,
    #[allow(non_camel_case_types)]
    closed,
    #[allow(non_camel_case_types)]
    opened,
    #[allow(non_camel_case_types)]
    #[serde(skip_deserializing)]
    unknown,
}
use serde::Deserialize;
fn deserialize_field_action<'de, D>(deserializer: D) -> Result<Action, D::Error>
    where
        D: Deserializer<'de>,
{
    Ok(Action::deserialize(deserializer).unwrap_or(Action::unknown))
}

But it visibly does not work:
$ cargo run --quiet -- --repository nicokosi/pullpito

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: StringError("Cannot deserialize GitHub API content: missing field `action` at line 1 column 2339") }', libcore/result.rs:945:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

See the code diff.
Any idea/recommendation? Thanks in advance.

Cannot deserialize GitHub API content: missing field action at line 1 column 2339

This means that not every "payload" has an "action". Check out https://serde.rs/attr-default.html for some ways to provide a default value when there is no action.

Thank you @dtolnay! I now use default values: https://github.com/nicokosi/pullpito/commits/issue_22_unknown_variant. 🎉
I close this issue.


getState doesn't work with function component

Hello, I'd like to use getState with a function component, but it does not work for me. Most probably I'm doing something wrong, or didn't read the docs completely. See pseudo component below:
const component = props => {
  return (

         ...
         {Radium.getState(this.state, 'container', ':hover') ? <AnotherComponent /> : null}

   );
}

Maybe I have to change this.state with something else? Thanks!

Functional components are stateless components. This means they should only be used for composing other components. You're better off handling conditional rendering of components in a stateful component.

Makes sense duhduhdan. Thanks for the quick response.

If you used the function syntax, Radium could call your stateless component with the this value of the stateful component wrapper it creates. But most uses of stateless components I've seen use arrow-methods, which already have this bound.
We should add something to the docs for this.

@ianobermiller
hi ianobermiller !
Here's my confusion :

const Aconponent = (props, context) => {
   return
 hi! there

}

export default Radium(Acomponent)

What's wrong with the above code ?
Thanks !

@vimniky, are you saying that Radium is no longer working correctly with stateless functional components? The code you posted should work fine.


ci: add json-schema-check workflow

Description
This adds json-schema-check workflows that is used in Autoware Universe
Related links
Parent Issue:

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

Since the there should be a package with json schema to test the workflow, I have tested in this sample PR if it works fine: https://github.com/autowarefoundation/autoware.core/actions/runs/11814926235/job/32915018111?pr=89
It runs successfully against the map_projection_loader.schema.json


SECURITY ALERT - INCORRECT SHA256 ON NVNGX.DLL ON NEXUSMODS

I just downloaded the 200.8.2 package from nexusmods, extracted the nvngx.dll, and the SHA256 was:
SHA256: ef75f00383c4f170a53e1d54efd7cb63565941e60cd3de32de3da61a6ed3266b
826 KB (846,240 bytes)
Windows 11 AV did not flag it as malware

Ah looks like the hashes in the <IP_ADDRESS> release post didn't get updated, were left the same as the hashes from <IP_ADDRESS> release 😓
Odd since I use some scripts to handle packing releases for different games & creating the release text, should have been updated fine, will have to look into those scripts again, maybe something is still being kept from previous builds.
Updated hashes are below, will update the post in a second, thanks for letting me know.
nvngx.dll

MD5: BFD664DAA13129CB34159D725A8734D2
SHA-1: 4BEFD03D2BEFF8CA4D73BEEBC6F6DAC1713922CC
SHA-256: EF75F00383C4F170A53E1D54EFD7CB63565941E60CD3DE32DE3DA61A6ED3266B

DLSSTweaksConfig.exe

MD5: B3E28E05ABC7EE25CF39111A6706AC28
SHA-1: FBE8C6022132CD32B9DEDCB3D3B18AF7F4154DF5
SHA-256: 931E5E38ECDB41BDD47291013640EEB3D6E2A4F8E7DF136327F0126CF049A825


Make TimeGraph optional in CaptureWindow.

TimeGraph contains a lot of information/logic to draw capture
related information in the CaptureWindow. However, if we don't have
a capture yet, it will still be queried, e.g. for the capture duration.
This let to a couple of rendering bugs in the past. With this change
the time_graph of CaptureWindow is a unique_ptr (optional does not work
as TimeGraph is not easily movable) and is nullptr before a capture
was taken/loaded.
This also has the nice effect that the capture window is really
clean before taking a capture (no scrollbar, no time track, no
vertical green line).
Test: Try different actions (like clicks) on the empty capture window.
Load a capture and take a caputre.

LGTM Florian! :) Thanks for this!
All seems perfect. I'm only not 100% sure about making it std::optional instead, but as you already mentioned it in the PR message, I will trust in your criteria.

I wished it to be optional, but it is just not worth it. We would need to make a lot of classes that are explicitly neither movable nor copiable at least movable and deal with the mutex (which is also not movable!). It is probably doable but requires a lot of effort.


Provide minified version

I'd prefer not to minify this library myself, especially since minifiers can introduce their own issues.
Could you provide a minified version of your code in the code base?

I'm very open to PRs that use esbuild or other simple solutions.

A minified version is now included as of v1.0.0.


Points Table added in readme

Description
add Points table in readme.md
Fixes #77

@arpit456jain u can merge it


Evaluate and fold sequences of IO operations lazily

Strict evaluation of IO sequences is undesirable as errors are not caught after the first one occurs.

Closed by 73979a7b2f0db6c564e63098f2d93278a9f617fe.


Rule: Not existing resource

Check if the imported resource exists and notify if not.

Won't do it because Robocop is a static code analysis tool and this goes beyond its purpose.


Application crashes on launch

I installed the latest version of browse-ocrd from the master branch of the git repository. When launching, I get the following error message:
Traceback (most recent call last):
  File "/usr/local/bin/browse-ocrd", line 5, in <module>
    from ocrd_browser.main import main
  File "/usr/local/lib/python3.10/site-packages/ocrd_browser/main.py", line 26, in <module>
    resources = Gio.resource_load(str(BASE_PATH / "ui.gresource"))
gi.repository.GLib.GError: g-file-error-quark: Failed to open file “/usr/local/lib/python3.10/site-packages/ocrd_browser/ui.gresource”: open() failed: No such file or directory (4)

It seems that ui.gresource is missing. I also cannot find it in the repository, maybe it wasn't pushed with the last update?

Hmm, that file should get generated by make install and is excluded from git by purpose. Did you try to install via make install?

Oh yeah sorry, that was a mistake on my end. I simply installed it with pip install git+https://github.com/hnesk/browse-ocrd
It works fine with make install.

Oh, I didn't know that was possible with pip. I just added the generated ui.gresource file to the repository. 27kb is a fair price to pay for that feature.


Base geometry without any Additions or Subtractions ignores the scale

I dont know if this is a bug or expected bahaviour, but in this sandbox
https://codesandbox.io/s/csg-house-forked-phdnhl?file=/src/App.js I conditionally add Subtractions only when there is enought space fore it. If the contion is true, everything is fine. But when it is false and only Base component remains, the scale of Base component is Ignored.  If this is no bug, how coul I do this in a proper way. Than you.

Hey! did you solve this?

No, still using something like<Addition geometry={box} scale={[0, 0, 0]} />when needed

uhmm, annoying. I'm dealing with the position.
If I try to use
<Base position={position} geometry={geometry}>
Base completely ignores the position and always aligns with centre [0,0,0].
Any ideas how I can solve this?

@drcmda @isaac-mason @Sam-Apostel


added 404 page

Description
In This PR, I've added a 404 page.
Checklist:

[ ] This pull request follow our contribution guidelines
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (postman and swagger)
[ ] I have written tests for the code
[ ] I have updated .env.example file for new .env variables

What is current behavior?
this file is fully functional on my system

Closes #28
What is new behavior?

Breaking Changes?

Additional information

@Mohit-Aasirwal Wrong design! please the design first


Memory leak in planck?

User @ GalacticSeal on the p5.play discord made a bullet hell game and thinks there's a memory leak in planck:
Is data from removed sprites of groups left over that would cause extra use of RAM or a memory leak? I'm asking because I think there might be a memory leak from p5.play, as I know the final attack from my latest project causes everything to start lagging even after that spell is done and the projectiles are removed

Someone just had the webpage of the bullet hell crash because of a fatal memory error on the final spell card lol
There is definitely either a direct problem with the amount of memory that spell takes or a memory leak somewhere in the code that I don't know about
For right now, I guess people are just going to need higher-end PCs or something

https://editor.p5js.org/GDD140-J_Chaput/full/XP4LGd8ZK
Behind the scenes in p5.play I am using this function to remove planck bodies:
 this.p.world.destroyBody(this.body);

I am I missing something? How can I remove that body entirely to free up memory?

You can rule out if this is a memory leak or a browser gc issue using Dev Tools.
Run your intensive effect a few times, watch the memory increase, and then hit the 'collect garbage' icon in Dev Tools (trash can icon on the Memory tab). If memory drops, then the issue is not with planck, because it obviously freed up its internal references and objects correctly. Otherwise, clicking this icon wouldn't make any difference if it was incorrectly holding on to them.
If memory doesn't drop significantly, then yes, there's an issue.

Thanks! I think I figured it out, now I set this.body = null after removing it and I think that works!


use  dlv.exe debug report “could not launch process: Access is denied.”

Please answer the following before submitting your issue:
Note: Please include any substantial examples (debug session output,
stacktraces, etc) as linked gists.

What version of Delve are you using (dlv version)?
C:\Users\Administrator>dlv version
Delve Debugger
Version: 0.11.0-alpha
Build:
What version of Go are you using? (go version)?
C:\Users\Administrator>go version
go version go1.7rc1 windows/amd64
What operating system and processor architecture are you using?
Windows7
What did you do?

package main
import (
"errors"
"fmt"
"log"
"os"
"path/filepath"
http "github.com/valyala/fasthttp"

)
func main() {
fmt.Println(Listen("http", ":1789", "", ""))
}
func Listen(proto, ip, crt, key string) (err error) {
File, err := os.Create("run.log")
if err != nil {
return err
}
defer File.Close()
s := server(http.CompressHandler(Router), log.New(File, "", log.LstdFlags))
switch proto {
case "http":
err = s.ListenAndServe(ip)
case "https":
err = s.ListenAndServeTLS(ip, crt, key)
default:
err = errors.New("Not found proto")
}
return
}
func server(handle http.RequestHandler, lg http.Logger) *http.Server {
return &http.Server{Handler: handle, Logger: lg}
}
var fs = &http.FS{Root: "./src", AcceptByteRange: true}
var fileHandler = fs.NewRequestHandler()
func Router(ctx *http.RequestCtx) {
switch string(ctx.Path()) {
case "/":
ctx.WriteString("Please Login in.")
case "/download", "/download/":
download(ctx)
default:
ctx.NotFound()
}
}
func download(ctx *http.RequestCtx) {
path := string(ctx.FormValue("file"))
if len(path) <= 0 {
ctx.Error("Request error", http.StatusNotFound)
return
}
filename := filepath.Base(path)
ctx.Response.Header.Set("Content-Disposition", "attachment; filename="+filename)
ctx.Request.SetRequestURI(path)
fmt.Println(string(ctx.RequestURI()))
fileHandler(ctx)
}

What did you expect to see?
how i can debug this code.
What did you see instead?

League of Legends? See #600 for other reasons you may be getting access is denied. If none applies reopen this issue.