Getting Object self from event on 'pointerdown'

Basically I've been trying to generate a graphic in the preload then re-use it over again for buttons. Within the create function they are given interactivity with the gameObject.on.('pointerdown', function(gameObject)), which has a function that gathers its self stored object data on the click which isn't going to work because:
gameObject.emit('pointerdown', pointer, gameObject.input.localX, gameObject.input.localY, pointer.camera);

Doesn't seem to have the gameObject itself as an argument.
Adding it to be:
gameObject.emit('pointerdown', pointer, gameObject, gameObject.input.localX, gameObject.input.localY, pointer.camera);

allows for the use of:
gameObject.on.('pointerdown', function(gameObject){
        console.log(gameObject.index);
});

The 2 methods I've used:
The first method is from the example
events / listen to game object event.js
function preload() {
    var box = this.make.graphics({
        x: 0,
        y: 0,
        add: false
    });
    box.name = "box";
    box.fillStyle('0xffffff', 1);
    box.fillRect(0, 0, 100, 100);
    box.generateTexture('box', 100, 100);
}

function create() {
    // METHOD 1
    for (var x = 1; x <= 3; x++) {
        var widget1 = this.add.image(10*(x*10), 10*(x*10), 'box').setOrigin(0, 0);
        widget1.setInteractive();
        widget1.name = x;

        widget1.on('clicked', displayName, this);
    }

    // METHOD 2
    for (var x = 1; x <= 3; x++) {
        var widget2 = this.add.image(920-(x*100), 10*(x*10), 'box').setOrigin(0, 0);
        widget2.setInteractive();
        widget2.name = x+3;
        /**
         * Have to change phaser.js line 88630 for this to work
         * gameObject.emit('pointerdown', pointer, gameObject.input.localX, gameObject.input.localY, pointer.camera);
         * to
         * gameObject.emit('pointerdown', pointer, gameObject, gameObject.input.localX, gameObject.input.localY, pointer.camera);
         */
        widget2.on('pointerdown', function(pointer, gameObject){
            console.log(gameObject.name);
        });
    }

    // METHOD 1
    this.input.on('gameobjectdown', function (pointer, gameObject) {
        gameObject.emit('clicked', gameObject);
    }, this);
}

// METHOD 1
function displayName(gameObject) {
    console.log(gameObject.name);
}

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

http://jsfiddle.net/hs58yjqs/2/

It doesn't have gameObject as an argument because it's the scope of the event. So within the event listener using this refers to the gameObject.


v6: Remove default type of spo site list. Closes #3526

Closes #3526
This PR type option, so that it does not default to TeamSite and the All value is no longer allowed.
Not specifying the type (and webtemplate) options now implies you want to retrieve all sites.
When specifying --includeOneDriveSites the validation now blocks using type or webTemplate.
Because type is more like a convenience option for webTemplate, I named it as such in the documentation. We might add more values to help people list the sites they want. But that is for another issue.

Thank you for your contribution. Manually merged


Create 8844a8d94bfffff

look at this hex 8844a8d94bfffff 44 hotspots same day different accounts

If you already took the choice to make a PR instead of the normal way of adding through the recommended way... At least make it a usefull PR.....


What about supporting SAML 2.0 in this library?

Hi everyone!
I have a concern to use this library.
Could you explain me about supporting SAML 2.0 Protocol there?
https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-saml-protocol-reference

@aukhatov MSAL implements the OAuth2.0 and OpenID Connect protocols, and does not support SAML 2.0. You can read more about the supported scenarios in the wiki page

@sangonzal Thank you.
What about the future? Will this library support the SAML 2.0?

There is a second part of the question
Now we use SAML 2.0 to authenticate via the https://login.microsoftonline.com endpoint.
Could we just replace SAML 2.0 authentication way with MSAL?
My point is based on the same endpoint to authenticate, according to the documentation paper https://docs.microsoft.com/en-us/azure/active-directory/develop/authentication-national-cloud and https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/src/main/java/com/microsoft/aad/msal4j/IClientApplicationBase.java#L18 where the default authority endpoint is https://login.microsoftonline.com.

@aukhatov The short answer is that there are no plans to support SAML 2.0 in MSAL. The longer answer is that if you look int the code, you'll actually see that we use SAML assertions internally for certain scenarios (for example federated username password flow), but these details are never exposed to the user. From the perspective of the user, you are just doing OAuth2.0 username password grant.
Can you provide more details about your scenario? Are you starting a new project or working with a legacy system?

@sangonzal  I'm working with legacy software.
We also use SAML 2.0 for federated username password flow. And we must support it because our customers already use it and authenticated in this way.
When MS announced about closing and supporting the ADAL library and released the MSAL we have been started the migration to the MSAL. And during migration, I've just found how we use username+password auth flow. But I can't support this flow by the MSAL. This is my concern.
@sangonzal Is this information enough for you? Do you have additional questions?

@aukhatov If I understand correctly, you already have a working implementation in ADAL, and are trying to migrate to using MSAL?
If so, then MSAL supports all scenarios supported by ADAL, and you should be able to migrate. Take a look at the Username Password sample and see if it works for you.
If you are running into any issues migrating from ADAL to MSAL, please post the ADAL code here and details about the error.

@sangonzal You understood almost correctly. I misled you a little about my concerns.
We have also the way when we use Federated or Managed (according to the user realm) username+password authentication for our customers. And my concerns are related to that.

@aukhatov MSAL can handle username+password for both managed and federated users without you having to worry about this. From your end, it looks the same for managed vs federated, without having to worry calling the user discovery endpoint or implementing SAML. You can see how it's done here

@sangonzal Thank you!
How can I use that?
I don't know how should I create a com.microsoft.aad.msal4j.PublicClientApplication instance without clientId?

@sangonzal Could you share some examples of usage?

@aukhatov This sample has instructions on how to register an application in the azure portal, as well as the code for acquiring tokens.
You'll need an app registration to use MSAL. When you register the application you'll receive the clientId. I assume even when you used your own implementation, you still had to register an app in Azure Active Directory?

@sangonzal Hi!
Actually yes, if I register an app it is easiest to acquire a token.
But what in the case when I don't have a registered app in Azure AD? Just by username and password.

@sangonzal Hi!
Actually yes, if I register an app it is easiest to acquire a token.
But what in the case when I don't have a registered app in Azure AD? Just by username and password.

@aukhatov having a registered app is a prerequisite for using MSAL. Client registration is part of the OAuth2.0 Spec. Without a client identifier, you can't interact with Azure AD via OAuth2.0

@aukhatov having a registered app is a prerequisite for using MSAL. Client registration is part of the OAuth2.0 Spec. Without a client identifier, you can't interact with Azure AD via OAuth2.0

@sangonzal Great.
I think we can close this question.
Thanks.

@sangonzal Great.
I think we can close this question.
Thanks.


Update peer dependency

This should just list Prettier v3. Not v2 as well.

So the plugin no longer supports Prettier v2 from 0.5.x?
0.4.x seem to support both v2 and v3 according to https://github.com/tailwindlabs/prettier-plugin-tailwindcss/pull/179
There is no mention of this breaking change in the changelog.
devDependencies:
- prettier-plugin-tailwindcss 0.4.1
+ prettier-plugin-tailwindcss 0.5.1 (0.5.4 is available)

 WARN  Issues with peer dependencies found
.
└─┬ prettier-plugin-tailwindcss 0.5.1
  └── ✕ unmet peer<EMAIL_ADDRESS>found 2.8.8


unable to disable auto resize of textbox

I dont want the tags to be with in the input field and so iam placing them out of the input filed. and when i type something on the input filed it is resizing the texbox. and i dont want that to happen. i have tried couple of solution to stop the autosize but none of them worked. how to stop "autosize" directive to resize my textbox based on the input. i want to have a fixed width for my input field.
Kindly solve this issue

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


Make it possible to create a LES with no account

This doesn't mean that you don't need an actual account
Import -> Perform Import -> New -> Create
The create action should redirect to the sign_up or sign_in page and should return back to the new page with all the changes in-tact. Than the user should be able to save it.
The polluting solution would be:

Creating the testing ground without a user
Sign up and sign in the user
Attach the testing ground to the user
Create a cron job that cleans up LES's without users every night.

The nice solution is:

Remembering the import table in cache
Sign up and sign in the user
Returning to the import table with a user
Save it

I would imagine it is easier to have the import or new actions redirect to a sign-up/sign-in page. It feels like a bit of a tease to allow someone to choose their technology mix and design their LES, only to hit a wall when hitting submit.

I would imagine it is easier to have the import or new actions redirect to a sign-up/sign-in page

Yes, it would and I agree.


Cannot override Text KeyMap

Describe the bug
WithKeyMap does not seem to have any effect on the Text field.
To Reproduce
Steps to reproduce the behavior:
textField := huh.NewText().
	Title("...").
	Value(&message).
	WithKeyMap(&huh.KeyMap{
		Text: huh.TextKeyMap{
			Next:    key.NewBinding(key.WithKeys("ctrl+enter"), key.WithHelp("ctrl+enter", "next")),
			Prev:    key.NewBinding(key.WithKeys("shift+tab"), key.WithHelp("shift+tab", "back")),
			NewLine: key.NewBinding(key.WithKeys("enter", "ctrl+j"), key.WithHelp("enter / ctrl+j", "new line")),
			Editor:  key.NewBinding(key.WithKeys("ctrl+e"), key.WithHelp("ctrl+e", "open editor")),
		},
	})

form := huh.NewForm(
	huh.NewGroup(
		textField,
	),
)

Help text at the end of the field does not reflect the new KeyMap and the default keymap still applies.
Expected behavior
Next and NewLine should have been overriden.

Hi! Thanks for the report. For now, you can change the keymap on the form to achieve the same effect:
textField := huh.NewText().
	Title("...").
	Value(&message)

form := huh.NewForm(
	huh.NewGroup(
		textField,
	),
).WithKeyMap(&huh.KeyMap{
	Text: huh.TextKeyMap{
		Next:    key.NewBinding(key.WithKeys("ctrl+enter"), key.WithHelp("ctrl+enter", "next")),
		Prev:    key.NewBinding(key.WithKeys("shift+tab"), key.WithHelp("shift+tab", "back")),
		NewLine: key.NewBinding(key.WithKeys("enter", "ctrl+j"), key.WithHelp("enter / ctrl+j", "new line")),
		Editor:  key.NewBinding(key.WithKeys("ctrl+e"), key.WithHelp("ctrl+e", "open editor")),
	},
})

closing per @meowgorithm response


Sign UP - Not working

The users should be able to register a new account using email / password credentials

Fixed in v1.1.0-enh1.
Ty @umarali


[Bug] NRE on quit to menu

hey there,
just noticed an NRE showing up twice on quitting a game to the main menu.  Almost certainly not a major issue, but figured I'd report it here
[07:50:50.0198154] [Info   :TwoRadarMaps] Terminal is hidden.
[07:50:50.0198154] [Info   :OpenBodyCams] Getting MoreCompany cosmetic models for Zombie
[07:50:50.0198154] [Info   :OpenBodyCams] Collected 9 third-person cosmetics objects for Zombie.
[07:50:50.0198154] [Info   :OpenBodyCams] Collected 0 first-person cosmetics objects for Zombie.
[07:50:50.0248173] [Error  : Unity Log] NullReferenceException
Stack trace:
TwoRadarMaps.TerminalVisibilityTracker.OnDisable () (at <b0c6750f72d44bd0bb91860da10c7d1b>:IL_002A)

[07:50:50.0248173] [Error  : Unity Log] NullReferenceException
Stack trace:
TwoRadarMaps.TerminalVisibilityTracker.OnDisable () (at <b0c6750f72d44bd0bb91860da10c7d1b>:IL_002A)

[07:50:50.0248173] [Info   : Unity Log] Terminal disabled, disabling ESC key listener

Forgot to mention in the changelog, but I believe I should've silenced this in 1.3.8. It's always seemed to be intermittent whenever I saw it, so I can't confirm, but pretty sure I squashed it.
Thanks!


Change gemspec to allow Rails version bigger than 5.2

Closed by https://github.com/richardvenneman/trestle-active_storage/pull/120


Add contribution paragraph in main README.

This makes easier for newcomers to catch a starting point from
the main documentation of the ciao repo.
Signed-off-by: Simental Magana, Marcos<EMAIL_ADDRESS>

Coverage remained the same at 66.425% when pulling d25f295be2034ef49157befd73bab9fce97686b7 on mrkz:add_contribution_readme into c8950093a6e5b8fd7cfc1f2d9d41f85eb3c7b119 on 01org:master.

Coverage decreased (-0.01%) to 66.413% when pulling d25f295be2034ef49157befd73bab9fce97686b7 on mrkz:add_contribution_readme into c8950093a6e5b8fd7cfc1f2d9d41f85eb3c7b119 on 01org:master.

Coverage decreased (-0.01%) to 66.413% when pulling d25f295be2034ef49157befd73bab9fce97686b7 on mrkz:add_contribution_readme into c8950093a6e5b8fd7cfc1f2d9d41f85eb3c7b119 on 01org:master.

Coverage decreased (-0.02%) to 66.407% when pulling d25f295be2034ef49157befd73bab9fce97686b7 on mrkz:add_contribution_readme into c8950093a6e5b8fd7cfc1f2d9d41f85eb3c7b119 on 01org:master.

Okay for me with a few changes.  @tpepper  is this okay for you?

Yep Mark's input sounds good!

Coverage increased (+0.04%) to 66.413% when pulling e89bcdd24ce560c632b1249f24e5ed04f22043df on mrkz:add_contribution_readme into 69179236aced4ccdd8ec336bc508a1accd3a6ff9 on 01org:master.

Coverage increased (+0.01%) to 66.388% when pulling e89bcdd24ce560c632b1249f24e5ed04f22043df on mrkz:add_contribution_readme into 69179236aced4ccdd8ec336bc508a1accd3a6ff9 on 01org:master.

Coverage increased (+0.01%) to 66.388% when pulling e89bcdd24ce560c632b1249f24e5ed04f22043df on mrkz:add_contribution_readme into 69179236aced4ccdd8ec336bc508a1accd3a6ff9 on 01org:master.

@mrkz  There's just two typos to fix and then we can merge this.

Coverage increased (+0.06%) to 66.538% when pulling 78f220354c1f4c01d75326234c19aabc8d101356 on mrkz:add_contribution_readme into 14763447a6eaeacf8010dc1e200fa43dfcd155b2 on 01org:master.

Coverage decreased (-0.006%) to 66.471% when pulling 78f220354c1f4c01d75326234c19aabc8d101356 on mrkz:add_contribution_readme into 14763447a6eaeacf8010dc1e200fa43dfcd155b2 on 01org:master.


Remove ember data to fix build issue

This fixes an issue related to: https://github.com/emberjs/data/issues/5024
We don't use ED in this addon so lets just get rid of it.
@thefrontside/staff can someone regenerate the yarn.lock file for me?

@Robdel12 yarn.lock added.


Current command injection behavior isn't correct

Consider the following test file:
import subprocess
my_val = 'do_something; ' + evil_value
subprocess.Popen(my_val, shell=True)
This is obviously a high risk command injection issue, but Bandit currently only reports a low.  Since all we can tell is that it's a dynamically constructed string we have to assume HIGH severity IMO.

Launchpad bug to Github issue import error


Issue in non-combat caluclations

I just did an AE on spiderman for Might. So added the +1 on non combat Melee checks in the AE tab. Then rolled a non combat Melee check and if I'm not wrong it should have been 18 with the +1 but it's showing 17 in the chat card.

There is an AE of +1 that fid not add I think.
Le lun. 13 mai 2024, 10 h 12, Jalen @.***> a écrit :

I think this rolled and calculated correctly. Your melee value is 5, and
the non-combat value is 6. You rolled a 2, 3 and 6, which added together is
11. 11 + 6 = 17, as shown.
—
Reply to this email directly, view it on GitHub
https://github.com/jalensailin/mvrpg/issues/19#issuecomment-2107936161,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM3T6AC4LPBWMRBPZ6YAVBLZCDJ4DAVCNFSM6AAAAABHSEGOEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXHEZTMMJWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

if there is, i am not seeing it in the screen shot. The base melee value is 5, you have an AE that adds 1 to non combat checks for melee. The melee non-combat section correctly reads as 6 (5+1). Then the roll correctly adds the modifier of 6 (which includes a +1) for non-combat rolls to the total of the roll. Let me know if i'm missing something 😄

Closing this. Can always open it back up again if necessary


docs: deprecate this package

This package will be deprecated as well as request. Thank you very much for your great works.
'request-promise-native' has already been deprecated.(https://github.com/request/request-promise-native/issues/57)

Coverage remained the same at 100.0% when pulling 052331d005559c7dac66da16e3a4eee4d4a05efa on shisama:patch-1 into b4dafe49fdfe57cdee7468c00613443e78ae5e7e on request:master.

Thanks a ton for taking care of this repo, too @shisama !

@shisama @analog-nico why instead of deprecating this repo not just use a maintained drop in replacement for request such as teeny-request?


not use the type of module being imported

VSCode Version: 1.18.0
OS Version: macOS 10.12.6

Steps to Reproduce:

npm i node-fetch and import fetch from 'node-fetch'
var a object as RequestInit type
the type should be<EMAIL_ADDRESS>-> RequestInit, because I has imported node-fetch. But the type use/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/lib.es2017.full.d.ts -> RequestInit.

Reproduces without extensions: No

How are you declaring that a is of the RequestInit type? We will not pick up the library type automatically so you'll typically have to write fetch.RequestInit instead

node-fetch's d.ts does not contain namespace. But library d.ts exports the type.
I use import fetch, { RequestInit } from 'node-fetch' instead of import fetch from 'node-fetch' solved the problem. Thanks.


feat(microsoft.azure): check state before deferring AzureDataFactoryRunPipelineOperatorAsync

Like the SnowflakeOperatorAsync, we try to verify if the submitted job has already completed before deferring it to prevent unnecessary deferring. This way, we can skip deferring the task if it has already been finished.


Bugfix for MySQL backups to S3

This commit follows on from e00e8265b8cb0a35ff2e24b123a5428131717b20. This has a failure condition where when it moves the temporary filename to be named "base.xbcrypt", it actually just moves the temporary filename into a directory named "base.xbcrypt". This means that we haven't lost any data, but when we come to restore it would be called a file we don't expect (we call it s3:///latest/base.xbcrypt so when we restore we can easily find the latest backup). This seems to happen because of the recursive option being set, and since this option does not seem to be needed for any of the incremental backup tasks, I think we can safely remove this from the base backup task and ensure the condition described above no longer occurs. This removes the --recursive flag from the s3cmd mv command.
Note: I've put a fix in place in Production and disabled Puppet on the machine where this occurs. It's currently breaking and causing files to pile up when they should be archived.

Merge away.


Exclude iOS, Android and Web samples from CI build

Blazorless web backend PR noticeably slowed down CI build speed.
This PR makes it faster, almost how it was before.
Before blazorless:

Current master:

This PR:

You can test this PR using the following package version. 11.0.999-cibuild0024780-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


Build sync failed

I cloned the project, but when I trying to open it building fails. I see following error:
Build file '/Users/igorskryl/Downloads/rive-android-master/kotlin/build.gradle' line: 45

A problem occurred evaluating project ':kotlin'.
> Cannot run program "adb": error=2, No such file or directory

It doesn't allow me to make a submodule. Can anybody help? Thanks!

Hi @burnix13!
It looks like the shell is having trouble finding adb.
If you haven't installed and you're using Android Studio, install the Android SDK Platform-Tools package and that'll install adb too. And once that's installed, add it to your PATH variable.
Hope this helps!

Thanks! It helped!


shellenv: prepend colon to MANPATH if set

The current appended colon means system man pages always shadow Homebrew's. There's also no point adding Homebrew's man dir, nor filling out an empty MANPATH, since man and friends will add the necessary dirs according to PATH.
Closes https://github.com/Homebrew/homebrew-core/issues/176037.
Also fixed a syntax error in the *csh INFOPATH setting.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

I've not touched fish, because (if I understand it correctly) it auto-constructs colon-delimited values from the lists contained in all variables whose names end in PATH.
Also need help fixing the PowerShell code, which I have no experience with.

@jpawlowski, as the original author of the PowerShell shellenv code, can you help with the necessary changes (do nothing if MANPATH not set, add colon at start if it is set)? Thanks much!

When MANPATH is not set, this now triggers an unbound variable error in Bash shells with set -eu:
bash -eu -c 'unset MANPATH; eval "$(/opt/homebrew/bin/brew shellenv)"'
bash: line 5: MANPATH: unbound variable

Could use e.g.
echo "export MANPATH=\${MANPATH+:}:${MANPATH#:}${HOMEBREW_PREFIX}/share/man;"


Bump gateway-api

Validation bits are removed from upstream (replaced by CEL), so we remove them here too.

@jwendell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
6bef7a5738821289ffc0f0db0c3e1d1dcc7b11bd
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LGTM, opened https://github.com/istio/istio/pull/48480 as well. Thanks for finding this!

/retest

@jwendell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
6bef7a5738821289ffc0f0db0c3e1d1dcc7b11bd
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

error is legit, I'll fix it in upstream

@jwendell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
c739f05b35b94c724225d2bcaed1bc8b75dbd56d
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


'Attempted to perform an unauthorized operation'

When using:
 .\Set-Privacy.ps1 -Strong -Admin

I get:
 HKLM:\SOFTWARE\Policies\Microsoft\Windows\DataCollection\AllowTelemetry changed to 0
 Set-ItemProperty : Attempted to perform an unauthorized operation.
 At E:\news\Set-Privacy.ps1:157 char:13
 +             Set-ItemProperty -Path $Path -Name $Name -Value $value
 +             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     + CategoryInfo          : PermissionDenied: (SpyNetReporting:String) [Set-ItemProperty], UnauthorizedAccessExcepti
    on
     + FullyQualifiedErrorId : System.UnauthorizedAccessException,Microsoft.PowerShell.Commands.SetItemPropertyCommand

 HKLM:\SOFTWARE\Microsoft\Windows Defender\Spynet\SpyNetReporting changed to 0

this may be due to tightened security on a registry key.
This happened in 10.0.10586.218

removed this feature in the latest version. To script disabling SpyNet, we have have to run the script as local system.


Feat/foundry exit helper

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 89.328%

Files with Coverage Reduction
New Missed Lines
%

contracts/child/ChildValidatorSet.sol
1
98.9%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
858

Relevant Lines:
933

💛  - Coveralls


Corrected formatting issues on Docs contrib guide

There are a few formatting problems in the Contributing to EKS Anywhere documentation guide that this seeks to address.

/cherrypick release-0.8

/lgtm

/approve


OSOE-689: update-github-issue-and-pull-request action shouldn't fail when issues are disabled in Lombiq.GitHub.Actions

OSOE-689
Fixes #256

Also remove whatever we added in the previous PR and don't need anymore, since the "issues enabled" check happens only in Update-GitHubIssueAndPullRequest.ps1.

Reverting the dev merge by Zoltán removed most of the remains of the last state of the PR so as far as I can tell there is nothing remaining of the action check-issues-are-enabled


Remove unused and never to be used classes from Map.h.

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1190/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1083/ for details.

@SolidWallOfCode You have to fix the unit tests too, in lib/ts/test_Map.cc.

@SolidWallOfCode Did you make the fixes to the unit tests ?

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1361/ for details.

[approve ci]

Intel CC build failed! See https://ci.trafficserver.apache.org/job/icc-github/45/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/linux-github/1507/ for details.

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/freebsd-github/1612/ for details.

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/177/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/linux-github/1516/ for details.

Intel CC build failed! See https://ci.trafficserver.apache.org/job/icc-github/54/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1621/ for details.

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/186/ for details.

Time to land this yet?


should em-calc() for media queries should ignore $rem-base?

I may be totally off track on this but the new method for specifying breakpoints in 5.2.2 75a2271b3af9d6062df2150f3f905df2feb7848d uses em-calc() which is sensitive to $rem-base. Since browsers don't use font-size when calculating ems for media queries (https://css-tricks.com/em-based-media-queries-are-based-on/), shouldn't it ignore $rem-base and just use the browser default (16px)?
Otherwise, if I set $rem-base to 20px:
$medium-breakpoint: em-calc(1024) = 51.2em as you would expect
But:
$large-up: "#{$screen} and (min-width:#{lower-bound($large-range)})";
media query kicks in at 820px (16*51.25)

I'm currently having the same problem - I set $rem-base and $base-font-size to 14px and the function does calculate the wrong em-values for this base values. Also em-calc(640, 16px) doesn't seem to solve it.

+1 same issue

I think the point of using a rem-base is that changing it will affect the layout and breakpoints as well. You can define your breakpoints in px if you want it to be a definitive value.

Use rem please :D

@rafibomb I agree. However I guess that’s my point: it doesn’t appear to affect breakpoints (at least not in the way you’d expect) because we can't control the em base used by media queries in the browser. Also, if the purpose of the em-calc() is to convert a pixel value to an em value, then I don't believe it's doing that correctly in this context. I tend to think by default when defining breakpoints in settings, we should pass a $base-value of 16.

I would have to agree with the assessment of others here. It does seem like the em-calcs should be based off of the expected default browser font size of 16px.
In any event, it's easy enough to work around. However, there appears to be a bug in the em-calc function in 5.5.3. Specifically:
@function em-calc($values, $base-value: $rem-base) {
  $remValues: rem-calc($values, $base-value: $rem-base);
...

It seems pointless to have a second argument on the em-calc function if it's not being used, isn't it? I believe that above line should change to:
@function em-calc($values, $base-value: $rem-base) {
  $remValues: rem-calc($values, $base-value);
...

so that the second argument in em-calc gets properly passed through correctly to rem-calc. As it stands now, we are having to redefine the em-calc function to fix this issue so that we can set the breakpoint and range variables based off of a 16px rem baseline in all cases (independent of $rem-base).

We aren't going to introduce any more breaking changes to Foundation 5, so we're going to close this.
In Foundation 6.1, we simplified how the base font size interacts with rem calculation. $rem-base is gone, and $base-font-size is used in rem-calc(). We also fixed font sizing affecting the grid size and breakpoint widths.

Which use then instead rem-base?


update to unicode 9 / emoji 4

i now have the catalog building from the latest unicode data, along with working shortcodes.
next step is to merge emoji like "woman-bouncing-ball:skin-2" as a skin variation of "woman-bouncing-ball" (and make sure skin variations are correctly sorted).
after that, i can start updating images

Remaining issues:

Missing the category ordering information; i need to pull this from Mac OS
Previously U+1F373 COOKING was defined as :egg:, but now we have U+1F95A EGG. The former is a fried egg. Considering changing the old one to :fried_egg:

After that I'll merge so that the data is current, before I start working on updating all the image sets.

anxiously awaiting!

i'm mostly happy with the data now, though still missing some categories which should be easy to pull; copying them from their equivalent codepoints (e.g. the non-gendered version).
i've updated the images for google, twitter, emojione and fb/messenger. apple is the main one remaining

all emoji now have category info. i've also added source unicode version (new added_in field). the bulk os the remaining work is apple images (updating the extraction tool to support ttc files)

google images have been updated - latest master rev of the noto repo fixed flag images, so they're all working again.


AttributeError: 'NoneType' object has no attribute 'ensure'

The second call of send_task fails with AttributeError

from celery.execute import send_task
send_task('tasks.add', args=[1,2])
<AsyncResult: 1b5ce124-c3cb-45a3-8318-6fcdfb4ff875>
send_task('tasks.add', args=[1,2])
Traceback (most recent call last):
File "", line 1, in
File "/Users/mher/Projects/ask/celery/celery/app/base.py", line 178, in send_task
expires=expires, **options)
File "/Users/mher/Projects/ask/celery/celery/app/amqp.py", line 236, in delay_task
send = connection.ensure(self, self.send, **_retry_policy)
AttributeError: 'NoneType' object has no attribute 'ensure'
import celery
celery.version
'2.5.0rc1'

What version of Kombu is this?  (is it using master branch, or 1.0 branch?)

2.0.0a2

Have you tried with 2.0 final? It's on PyPI now. I think this was a bug in the master branch for a while, that I fixed.


[core] DO NOT MERGE - Lazy import of PEFT

What does this PR do?
As per title, however this seems to not lead to any speedup when it comes to import, according to the profiling of import, it seems that the PEFT-related imports are all bounded by accelerate's imports. Let's wait and see if things will get improved once https://github.com/huggingface/accelerate/issues/1952 gets addressed
Before:

After:

cc @BenjaminBossan @pacman100

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Fixing incremental build after modifying a XAML file

Description
The FileWrites item group is a bit misnamed: it's meant to capture every file theoretically written by any build, not just the files that were actually written by the current build.  Currently, we're only calling CompileXaml on XAML files we actually need to build, which is causing the files produced by those builds to be added to FileWrites only if we actually compiled those files.  As a result, the more aggressive cleaning done by VS 16.8 broke our incremental build because it started to purge $(IntDir) of any file not in the FileWrites item group after a build, which included the XBF files that we need to binplace to the AppX directory when F5ing to build and run.
The fix is pretty simple: we just need to add all of our XBF files to FileWrites, regardless of whether we actually wrote them during the build.  This prevents VS from deleting them during its incremental clean phase.
Motivation and Context
Allows for F5 build-and-run after modifying a XAML file without needing to rebuild the entire project.
How Has This Been Tested?
Built and run the project multiple times in a row, making XAML changes each time.  Verified that the test app successfully launched each time.

Also, while I was at it, there were places where we were indirectly constructing the path to GeneratedFilesDir rather than just using that MSBuild property.  I switched over to just explicitly using that property.

@LUke can you merge in master to pull in a pipeline fix that went in just now ?

/azp run


scripts: Update pyocd version to 0.16.1

Update the pyocd version to pick up a fix for the command 'pyocd erase',
which was broken in 0.15.0 and fixed in 0.16.0. Although we don't have
any in-tree uses of this command in zephyr, there will soon be in-tree
uses in mcuboot when the deprecated 'pyocd-flashtool' and 'pyocd-tool'
commands are replaced with the new unified pyocd commands.
Signed-off-by: Maureen Helm<EMAIL_ADDRESS>

Codecov Report

Merging #13500 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13500   +/-   ##
=======================================
  Coverage    52.5%    52.5%
=======================================
  Files         318      318
  Lines       46529    46529
  Branches    10755    10755
=======================================
  Hits        24431    24431
  Misses      17199    17199
  Partials     4899     4899

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c21bab...8dc74dc. Read the comment docs.


Download button links to wrong language

This is a small thing, but when I click the download link for .NET Core from the en-us page, it links to the es-es version of the page.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 07a5fade-535f-2fad-c7b0-77bf9e28773e
Version Independent ID: 68d524f7-6cf1-2caa-56d5-f243952d1526
Content: Install .NET on macOS - .NET
Content Source: docs/core/install/macos.md
Product: .net
Technology: dotnet-installation
GitHub Login: @adegeo
Microsoft Alias: adegeo

Hi @anishprasad01
The links we use don't have a language slugs in them. The website itself usually detects your language in the browser and sends you to the appropriate language version of the page.
@gewarren do you know where the anishprasad01 can file a problem with the site? I can't seem to find a link.

I don't think it's a problem with dotnet.microsoft.com - I think it's more about the browser, as you noted. For me, the link ends up on the en-US site. But if you think there's a problem with dotnet.microsoft.com, let me know and I'll get this issue transferred.

Just me then. Sorry for the alarm.


Set css class for checkbox

Currently, the checkboxes are the one of the OS, not kresus. It would be nice if the checkboxes are alined with the restm of the teme.

Thanks for opening an issue about this. I'm fine with the current look, but if somebody wanted to make them look better, feel free ;)

I'm already working on this :)


Feature/hotovo kong dev

Updated swaggerUi use

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: pk-hotovo:x: JulianEstefanHotovoYou have signed the CLA already but the status is still pending? Let us recheck it.


Xamarin.iOS Entitlements

I've followed your steps to setup FCM on iOS and it's all working well for Debug Mode. But when I build it in release mode and generate .ipa file, it does not install on any iPhone.
Actually it installs until 100% and then just disappears. This is what is shown on Device logs:
Jun 13 17:13:28 iPhone-de-Tatiane atc(Apps)[31] : |com.personaliza.sage-clube-do-contador install failed unrecoverably: Error Domain=MIInstallerErrorDomain Code=13 "Failed to verify code signature of /private/var/installd/Library/Caches/com.apple.mobile.installd.staging/temp.6eaBvR/extracted/Payload/SageAppPCLiOS.app : 0xe8008016 (The executable was signed with invalid entitlements.)" UserInfo={LibMISErrorNumber=-402620394, LegacyErrorString=ApplicationVerificationFailed, FunctionName=+[MICodeSigningVerifier _validateSignatureAndCopyInfoForURL:withOptions:error:], NSLocalizedDescription=Failed to verify code signature of /private/var/installd/Library/Caches/com.apple.mobile.installd.staging/temp.6eaBvR/extracted/Payload/SageAppPCLiOS.app : 0xe8008016 (The executable was signed with invalid entitlements.), SourceFileLine=147}
Do you have any idea about this problem?

This is related to your code signing
What you can do is open Xcode and open any sample application and try the same bundle identifier and certificate and try installing it on your iPhone. It will tell you the problem regarding code signing and will also guide how to resolve it

Oh, I fixed it! I just changed my aps-environment string from "development" to "production". Thanks!


Is there a way to access MongoDB instance in cloud code.

I wondering is it possible to get a mongodb collection instance in cloud code? On my particular case I would like to run db.collection.aggregate(); It would be nice to be able to have something like
new Parse.Object("SomeClass").getCollection().aggregate();

Before moving to open source we used deployd which had similar functionality;

Cloud Code can execute any javascript, so you can just use the mongo client directly.

Yes, I know that. But I thought about way of getting already created instance so I don't have to create new inside cloud code with database credentials. But yes, that's an option.

No, thats currently not possible. We are working on making Parse be able to use other databases, and some of those changes will make it easier to share connections between Parse Server and Cloud Code, but that also means that we can't ensure there is always a mongo collection available. You can create a global connection for your cloud code, and use env vars for your DB credentials, then the only issue will be that you have 2 connections instead of 1.

Is there now a way to access the mongo connection from Cloud Code? Right now I need to open a new connection and closing it on every requests when doing a native query. How would I go about to keep a persistent mongo connection in Cloud Code?

your cloud code is required only once, so you can easily maintain your connection.

 Thanks for the help @flovilmart, works like a charm! :)

Awesome!

Hello @flovilmart ,
I want a MongoDB instance which is already created by Parse Server, is there any way to get that instance?
I tried debugging in Parse Instance on cloud code, but no luck.
Thanks.

there is no trivial way to access the parse-server instance from cloud code nor its internals. Perhaps @Tom-Fox1 or @acinader or @dplewis would like to make it easier.

Hi,
What I usually do is:
	const Config = require('../node_modules/parse-server/lib/Config');

	const config = Config.get(Parse.applicationId);
	const mongoAdapter = config.database.adapter;
	await mongoAdapter.connect();
	const collection = await mongoAdapter.database.collection(className);

@flovilmart Thanks for the explanation.
@oallouch, yes, I guess it will for the cloud code, thanks. :)

Hi,
What I usually do is:
	const Config = require('../node_modules/parse-server/lib/Config');

	const config = Config.get(Parse.applicationId);
	const mongoAdapter = config.database.adapter;
	await mongoAdapter.connect();
	const collection = await mongoAdapter.database.collection(className);

Hi there. This is working great.
I'm not really sure if I understand this correctly - line await mongoAdapter.connect(); is creating new connection to mongoDb?
How can I close this connection, can't manage to close it..?
Thanks!
Nejc

Is somebody using this approach? Is new connection to mongoDb being created in this case?
How can I close this connection, can't manage to close it..?
thx

In MongoStorageAdapter :
connect() {
    if (this.connectionPromise) {
      return this.connectionPromise;
    }
    ...
    ...

So, it looks like it doesn't do anything if it's already connected.
And you don't have to manage its closing.


CREATING NEW POSTCARD (#3091)

Part of the dojo
Signed-off-by: nilmeier<EMAIL_ADDRESS>

Looks like a zero length file?

Hi @nilmeier if you ping me (@planetf1) on odpi.slack.org I'd be happy to help you through making the change and explain why we use DCO.
Unfortunately without the DCO we can't integrate any change so I'll close this for now -- but we can reopen with a single click when you are ready.


RSS Feed Should Show The Real Feed Title

Right now our RSS Feed is showing "My Awesome Blog" for the blog title.
This can be edited in the feedOptions property inside of the gridsome.config.js file.
The title sub property is what will change this.

Docs: https://github.com/dylang/node-rss#feedoptions


LCD library clean-ups

Rename DEV_DMA_Done to DEV_DMA_Active.
Rename DEV_SPI_Write_DMA to DEV_SPI_Start_DMA_Write.
Moved SPI busy loop into DEV_DMA_IRQ_Handler(), looks more at home there.
Set pixel format in every function that sents pixels, so the sequence is always: set Pixel Format - call SetWindows() - send pixels.
Remove "Display On", this is done by LCD_1IN14_V2_InitReg(), and nothing does a "Display Off".
Small story:
While writing the DMA code, by taking hints from pico-examples, and after I thought "looks good, let's test this", the display showed the "Waiting for terminal" and then went blank... Sprinkling some "puts()" into the code, to see whats going on, and it works! WTF? I think everybody hates it when that happens. After some mumbling and thinking, I came up with the "SPI FIFO not empty, when DMA write finished interrupt triggers".

I had a similar problem with the WS2812 RGB LED's. One has to a wait a bit before changing color, so that the bit pattern is clocked out completely. Overwriting the bits while it's still clocking out results in funny colors ;-)


Simple delegator

Hello!
I am using decorators to wrap country object
@countries  = Country.page().per()
@countries = CountryDecorator.wrap(@countries)

in a view I have
paginate @countries

Code in the view fails with `total_pages' for #Array:0x007efef87b5f90
How can I add missing methods to decorator?

What does your CountryDecorator look like?

it is a class which extends ruby's SimpleDelegator

@gogainda Where does the .wrap method comes from?
I tried this, using SimpleDelegator and it seems to work.
class CountryDecorator < SimpleDelegator
end

countries = Country.page(1).per(5)
@countries = CountryDecorator.new(countries)

@countries.total_pages #=>  4

def self.wrap(collection)
collection.map do |obj|
new obj
end
end

@gogainda See my updated answer above.

But I already did it on Country class or what did you mean?

@gogainda Yes but your decorator returns a new object. Let me clarify.
@countries1  = Country.page().per()
@countries2 = CountryDecorator.wrap(@countries2)

@countries1 has the #total_pages method since you ran .page().run() on it.
Do you understand? :)

got it, will try

@gogainda Cool. Please close the issue if it solves your problem.

I wouldn't recommend to implement a decorator pattern by yourself. I would rather use Rails' helpers instead.
Since this is not a kaminari issue, I'll close this issue. Thanks!


Need a ToDateTimeOffset function

We have no direct function to convert datetime or datetime2 values to datetimeoffset with the correct offset for a particular time zone.
It can be done with two functions, as in:
Tzdb.SwitchZone(Tzdb.LocalToUtc(@local, @tz, 1, 1), @tz)

But this should be wrapped in a single function.

And while wrapping the above will work, it could probably be written better as a single lookup against the Interval table.


State transition handler

partially handled in #93.

partially handled in #93.

closing in lieu of #96


Cleanup test code.

Signed-off-by: Doychin Bondzhev<EMAIL_ADDRESS>

+1

Changes are of cosmetic nature assertTrue(...) => assertEquals(...), Typo Fixes.


python-eve: init at 0.6.1

I suggest you split the commit up in several, with one for each package. This makes it a lot easier for those in the future searching for these packages in say the git log.

@FRidh I'll fix these mistakes and some more I just detected and reopen this PR later.


Should Range Card Toolbox include Data Driven Pages Script?

@mfunk, since Data Driven Pages will not be implemented in ArcGIS Pro for a while, the script the Pro team created will need to be included for full functionality. Should we include that script in the Range Card Toolbox for ArcGIS Pro until that happens? I think so.

After discussing it w/ @mfunk, we should include it in the toolbox until a repo is created for it, and then add it as a submodule.


fix: typo donet -> dotnet

PR Summary

PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

@adityapatwardhan can you please review the environment variable names?

I will double check the variable names and confirm if the infrastructure pipelines have the same typo.. I can update them their too.

this change should not cause any breaks in the release pipeline.


Can we get a populate function

I really liked the mongoose populate feature for fetching related documents from another collection. Do you think it's possible for us to have a similar feature in v2.0?
Or perhaps there is already an easy way to do this which i am not familiar with.

Yes it's quite nice feature. I was thinking about similar feature that would be integrated into relations module. For now there is no such feature in Astronomy. Probably I will add such feature into relations module or integrate it into the core in 2.1 or something like this. I would definitely want to have something similar in Astronomy 2.0

Yes having a simple helper like that in relations module would be really handy.
I am guessing relations module is going into the core starting 2.0?

I wanted it to be in the core of 2.0 but we will see. I have many things right now on my head (You know private stuff). I wanted to release RC version before end of the year, but it won't happen so fast. It will be probably beginning of the 2016. I would like to include in this version as many features as possible.

That'd be awesome.
I was actually kind of waiting the 2.0 launch to try and code something like this.

Do you guys have a common pattern you use for this at the moment?

You just have to get related records using methods. You can create method like for example getAuthor() that will take the authorId field's value and fetch document from the Meteor.users collection and put it into the original document under author field.
Doc = Astro.Class({
  name: 'Doc',
  collection: Docs,
  fields: {
    authorId: 'string',
    author: 'null' /* or 'object' */
  },
  methods: {
    getAuthor: function() {
      this.author = Meteor.users.findOne(this.authorId);
    }
  }
});

var doc = Docs.findOne();
doc.getAuthor(); // equivalent to 'doc.populate("author");
doc.author;

+1

Hi, do this feature already in v2?

@nizulzaim no this feature is not yet implemented


feat: add DoubleClick variant for TrayIconEvent

should a double click event be emitted after two Click events? or should those be suppressed if it's a double click?

it is not suppressed, both are emitted


[GAIA-IR] support more patterns of aggregate functions, i.e min/max/toList/toSet/avg/countDistinct

What do these changes do?

Related issue number
as titled

#1802

There remains some bugs of group to be fixed:

g.V().group().by(values("name").as("a")).select("a")

it seems that values("name") is aliased as "0" in the query  g.V().group().by(values("name").as("a"))

g.V().group().by(outE().count()).by("name")

There remains some bugs of group to be fixed:

g.V().group().by(values("name").as("a")).select("a")

it seems that values("name") is aliased as "0" in the query  g.V().group().by(values("name").as("a"))

g.V().group().by(outE().count()).by("name")

These two bugs are addressed in the following issue:

There remains some bugs of group to be fixed:

g.V().group().by(values("name").as("a")).select("a")

it seems that values("name") is aliased as "0" in the query  g.V().group().by(values("name").as("a"))

g.V().group().by(outE().count()).by("name")

Related issue #1851


ROX-25230: update async dep

Description
Updates async to latest patch version.
User-facing documentation

[ ] CHANGELOG is updated OR update is not needed
[ ] documentation PR is created and is linked above OR is not needed

Testing and quality

[ ] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
[ ] CI results are inspected

Automated testing

[ ] added unit tests
[ ] added e2e tests
[ ] added regression tests
[ ] added compatibility tests
[ ] modified existing tests

How I validated my change
devDependency - validate CI run

ocp-4-12 and ocp-4-16 are new, persistent Network Graph failures that are not related to this change.
https://redhat-internal.slack.com/archives/CLUNQEEMA/p1725871475873159


wpewebkit: Make gnutls a packageconfig knob

Disable it by default, since it depends on nettle which is LGPL-3
Signed-off-by: Khem Raj<EMAIL_ADDRESS>

Can you update this also for webkitgtk recipe?

Thanks!


Missing files

Hello,
We can't find some of the files mentioned in the ReadMe document. These are the following files:

t_question.csv
t_response.csv
Q&A_EN.xlsx
The Teams Odyssey - Game Master Guide.pdf

Could you add them? Or if they are present, please specify in which folder?
Thank you in advance,
Sincerely

Hi,
In addition, the data.sql script calls public.i_process_backlog_question(); function wich references a file that is also missing, and is a unix path so I guess it won't work on Windows :(
COPY public.i_question FROM '/var/lib/postgresql/data/backlog_question.csv' DELIMITER ';' CSV HEADER;

Hello,
As KBObsidienne, I am blocked to import CSV files, because it doesn't exist.
And the other files too.
It's just a little problematic. :p
They are not in the folders. Could you add them, please ?
Thank you in advance,

Any feedback on this? Facing the same issue

Hi everyone,
Thank you very much for your interest in Teams Odysee. I am working internally to bring missing questions and answers files to the repository.
I will bring communication assets as soon as possible in english, but for now french assets for Q&A and master guide are accessible in PACKAGE_ODYSSEE_FR folder.

@matthieugi  thank you for getting back to us.
The issue is not really FR or EN but missing files altogther. As you can see in the documentation provided (Readme) step 29, we have to use t_question.csv and t_response.csv but these files are absent from all files.

Unless you show us how to use the file here "PACKAGE_ODYSSEE_FR/Q&A_FR.xlsx " and make it t_questions.csv and t_response.csv
thanks

I just added the missing files to the repo.
t_question.csv & t_response.csv are available in the postgres folder
Q&A_EN.xlsx & Game Master Guide.pdf are available to the english communication assets folder
@Tinathnath we have removed the old dependencies to i_question table and the associated unix link.

Thanks ! I'll try that :)


fsl_parser.rs:127-129: Prohibit usage of upper-case...

The puzzle 5-b25e45d9 from #5 has to be resolved:
https://github.com/h1alexbel/fsl/blob/38637168f985ab99f6ab667624c627f854eab5e2/src/parser/fsl_parser.rs#L127-L129
The puzzle was created by @h1alexbel on 24-Sep-24.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd Quality problem: Lack of clear bug description. Suggestion: Provide a concise summary ...

I see you're talking to me, but I can't reply since I'm not a chat bot.

The puzzle 5-b25e45d9 has disappeared from the source code, that's why I closed this issue.


Python process dies when calling get_radians()

Atom : v2.4
pymycobot : v.2.1.2
Python process dies when calling get_radians(). For example, when I run test.py in your repository, the process dies.
::get_radians()
Traceback (most recent call last):
  File "./test.py", line 115, in <module>
    test(mycobot)
  File "./test.py", line 70, in test
    print('==> radians: {}\n'.format(mycobot.get_radians()))
  File "/home/nish/.local/lib/python2.7/site-packages/pymycobot/mycobot.py", line 163, in get_radians
    angles = self.__mesg(Command.GET_ANGLES, has_reply=True)
  File "/home/nish/.local/lib/python2.7/site-packages/pymycobot/mycobot.py", line 94, in __mesg
    res = self._process_recived(data, genre)
  File "/home/nish/.local/lib/python2.7/site-packages/pymycobot/common.py", line 135, in _process_recived
    res.append(self._decode_int16(a))
  File "/home/nish/.local/lib/python2.7/site-packages/pymycobot/common.py", line 63, in _decode_int16
    return struct.unpack('>h', data)[0]
struct.error: unpack requires a string argument of length 2

Today I tested it. It's OK. Can you provide more detailed information?

Today I tested it. It's OK. Can you provide more detailed information?

What info do you need? So far, info in my first comment is everything what I can give.

What info do you need? So far, info in my first comment is everything what I can give.

Is it still wrong now? How about get_angles()?
Through the information you give, the place where the error happened is incredible. If it's wrong, it should be wrong at a higher level, not here.

Is it still wrong now? How about get_angles()?
Through the information you give, the place where the error happened is incredible. If it's wrong, it should be wrong at a higher level, not here.

Ok, I will check get_angles() and give feedback to you. Hold on a moment.

Ok, I will check get_angles() and give feedback to you. Hold on a moment.

Both get_radians() and get_angles() work well! I guess root cause might be instability of USB connection. The issue is solved.
Thank you!

Both get_radians() and get_angles() work well! I guess root cause might be instability of USB connection. The issue is solved.
Thank you!

That's OK.

That's OK.


tour: [REPLACE WITH SHORT DESCRIPTION]

Context: https://tour.golang.org/concurrency/1
Change the title above to describe your issue and add your feedback here, including code if necessary

Empty issue, closing.


Added mdns resolution via zeroconf.

Description:
Using the zeroconf module, this uses the .local address of EAGLE devices to make the IP address field optional.  Using zeroconf is necessary for systems that can't resolve mDNS naturally, as in the Docker version of home-assistant.
N.B. I don't have this hardware.  I'm writing this PR alongside another which adds support for an older version, the Legacy Eagle, so I can't test this against the Eagle-200.
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: rainforest_eagle
    cloud_id: 012abc
    install_code:<PHONE_NUMBER>0abcde

## Checklist:
  - [ ] The code change is tested and works locally.
  - [ ] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**
  - [*] There is no commented out code in this PR.
  - [ ] I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:
  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)

If the code communicates with devices, web services, or third-party tools:
  - [*] [_The manifest file_][manifest-docs] has all fields filled out correctly. Update and include derived files by running `python3 -m script.hassfest`.
  - [*] New or updated dependencies have been added to `requirements_all.txt` by running `python3 -m script.gen_requirements_all`.
  - [*] Untested files have been added to `.coveragerc`.

If the code does not interact with devices:
  - [ ] Tests have been added to verify that the new code works.

[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html

Hi @jcalbert,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


fix(reactions): Add necessary node information for PDVN

This PR is based on Austin's previous commit and adds necessary node information for PDVN.

These changes seem like a reasonable addition to the PDVN PR, but shouldn't we maybe merge this into my PDVN PR branch rather than into main directly? This PR doesn't really make much sense on its own...

Hi, Austin, Yes, this PR is based on your previous one; however, I'm only covering the necessary node information in this small PR. We have successfully reimplemented PDVN based on your early PDVN PR and are currently verifying its performance. Once the performance is as good as the paper indicates, we will upload all of them in an organized manner. This PR is just to ensure the internal experiments run smoothly :)


Query multiple applications

This is a copy of this article http://apmtips.com/blog/2017/09/19/query-multiple-applications/ from @SergeyKanzhelev . He agreed to have this posted.

@anjaziegler @bwren @mrbullwinkle Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you review staging and fix all validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
We'll close this PR. Thank you.

@anjaziegler apologies for the lack of response on this. We generally triage public PRs daily by service label rather than assignee and since this was a new article idea rather than an improvement to an existing doc it didn't get an automatic label of "application-insights' and thus it doesn't show up in our morning triage.
I will ping you over e-mail to get this resolved, we can definitely get an article that leverages @SergeyKanzhelev's content published in the official docs.

@mrbullwinkle it will be great if you can walk @anjaziegler thru the process. This contribution is a part of Open Source Fridays initiative that promotes contributions like this and learning.

@SergeyKanzhelev, awesome thank you for the context. I reached out to @anjaziegler over e-mail I am happy to take care of the PR, or setup a call and walk her through the internal contribution process, whichever she prefers. Thank you as always for encouraging improvement/contribution to the docs.


ZEPPELIN-3344. Revert comments in queries in JDBC interpreter

What is this PR for?
The original purpose of https://github.com/apache/zeppelin/pull/2158 was correct processing of ';'. This was done via full removing comments from code.
Unfortunately Apache Phoenix uses hooks in comments https://forcedotcom.github.io/phoenix/#hintml.
Thus we should not delete comments in scripts.
There was discussion about comment rules for different databases (solr). The right way is keep style. Thus analysts can copy queries to another tool and can get same results and errors.
What type of PR is it?
[Bug Fix]
What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3344

How should this be tested?

Unit tests pass: testSplitSqlQueryWithComments and testSplitSqlQuery

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

ping @mebelousov do you have chance to look at this comment https://github.com/apache/zeppelin/pull/2876#discussion_r175098216

Thanks @mebelousov LGTM


bug: go.mod in subdir presents problems

https://github.com/golang/go/issues/34055
I can't easily refer to k8s.io/clusterproperty from my go-1.17 project because it doesn't resolve; instead, I see 404 errors.

I have the same question, why organize the APIs with sub-module? It might make things complex.

@jdef running into same problem. You said you can't easily refer to k8s.io/clusterproperty, did you find a workaround?

No, I just defined my own CRD in the spirit of this one here. I could have
forked and shuffled the go.mod file around, but that's more work (in my
corporate env) and I need to move quickly. I imagine that some future
version of this project will work as intended, and so I'll migrate then.
On Tue, Jun 28, 2022, 2:17 PM Matthew Goodman @.***>
wrote:

@jdef https://github.com/jdef running into same problem. You said you
can't easily refer to k8s.io/clusterproperty, did you find a workaround?
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/about-api/issues/6#issuecomment-1169066826,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR5KLEYFRQX4YRIIP6WBOLVRM6U7ANCNFSM5YVBTJ6Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

/remove-lifecycle stale
This issue is addressed by #12


RFID Support

Hi @Shashank2406 ,
I have tried your plugin. It works for barcodes. I have a few improvements for your Readme.md-file. I'm using the plugin with ionic 4 beta. So there are slide changes, but in general:
thank you for your work!
Is there a way, to read RFID-data? The Zebra RFD8500 is also capable of reading RFID. In the Events Section there is nothing like rfidData.
I will send you a PullRequest for my Readme changes later this day.
Thanks for support!

I understand. I am new to work with cordova Plugins and external SDKs. Do you think it is straight forward, to add this feature? Then I will do it. I have looked through your Source Code. Do you think it is better to create a fork, or try to implement both in your plugin?
Thanks

I think it's better to create a fork and then integrate it. It is pretty straight if you have prior knowledge of iOS SDK implementation, rest is bridging that native code to cordova for which you can use my code. Let me know if you require any help.
Cheers!

Thanks a lot I will

@Shashank2406 I am new to this how do I use your plugin with the SDK in ionic 4?

@tloomis you can install the plugin using the command  ionic cordova plugin add cordova-plugin-zebra-scanner-ios.

Yes I have done that however when I do the code sample for finding devices it doesn’t find out rfd8500. Do you have other code examples to achieve this?
Sent from my iPhone
On Jun 30, 2019, at 9:37 AM, Shashank Srivastava <notifications<EMAIL_ADDRESS>wrote:
@tloomishttps://github.com/tloomis you can install the plugin using the command ionic cordova plugin add cordova-plugin-zebra-scanner-ios.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ABIXL2ZUTI2XCQ3USYB2IYDP5CZJNA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4MLCI#issuecomment-507037065, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABIXL223WNA7PZKYWWFGTG3P5CZJNANCNFSM4FULRCWQ.

How are you trying to connect the device is the device connected via Bluetooth first? Which device are you using on?

It is connect via Bluetooth on iPhone. When the code to check connected devices runs it returns no device found
Sent from my iPhone
On Jun 30, 2019, at 10:04 AM, Shashank Srivastava <notifications<EMAIL_ADDRESS>wrote:
How are you trying to connect the device is the device connected via Bluetooth first? Which device are you using on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ABIXL2YYNO4LQP3MJMOBUGLP5C4ODA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4M2CY#issuecomment-507038987, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABIXL23W7745YV6BX5IU3QLP5C4ODANCNFSM4FULRCWQ.

The scanner is a zebra rfd8500
Sent from my iPhone
On Jun 30, 2019, at 10:04 AM, Shashank Srivastava <notifications<EMAIL_ADDRESS>wrote:
How are you trying to connect the device is the device connected via Bluetooth first? Which device are you using on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ABIXL2YYNO4LQP3MJMOBUGLP5C4ODA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4M2CY#issuecomment-507038987, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABIXL23W7745YV6BX5IU3QLP5C4ODANCNFSM4FULRCWQ.

Which mode are you connecting it in?

It was in batch and I tired putting into HID
Sent from my iPhone
On Jun 30, 2019, at 11:09 AM, Shashank Srivastava <notifications<EMAIL_ADDRESS>wrote:
Which mode are you connecting it in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ABIXL27PS7PFA43T2P2QYWLP5DEBDA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4OANQ#issuecomment-507043894, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABIXL26JELTC7MJQ5K2L7N3P5DEBDANCNFSM4FULRCWQ.

trying connecting in Bluetooth MFi_SPP/ Bluetooth MFi_SSI Profile

Will give that a try any other suggestions?
Sent from my iPhone
On Jun 30, 2019, at 2:04 PM, Shashank Srivastava <notifications<EMAIL_ADDRESS>wrote:
trying connecting in Bluetooth MFi_SPP/ Bluetooth MFi_SSI Profile
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ABIXL26F4VXROMCFUOQROELP5DYUPA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4Q3DI#issuecomment-507055501, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABIXL26XAZMDL5EPYZ2JWELP5DYUPANCNFSM4FULRCWQ.

no as of now.

Do i need to place the SDK somewhere?

No, SDK is already included.

How i can use the XCode how to integrate

Can you please tell me the issue? Did you follow the steps in README.md?

Hi Shashank,
Good morning.
I am using XCode.
i am create the new cordova project using the terminal.
$cordova create rfid com.example.rfid RfidScanner
$ cd rfid
$ cordova platform add ios –save
$ cordova plugin add cordova-plugin-zebra-scanner-ios
And I buld the project.
$ cordova build ios.
Now i copy the zebrascanner.js to www folder of my xcode project.
how i can call zebrascanner.js  GetActivescanner scanner funtion from my
html file of the xcode project.
Thanks
Regards
Anand
On Fri, 30 Aug 2019 at 15:08, Shashank Srivastava<EMAIL_ADDRESS>wrote:

Can you please tell me the issue? Did you follow the steps in README.md?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ANBBNH5H3CEHTEOXLNUVXBTQHDBOXA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QYWDY#issuecomment-526486287,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANBBNH4KLUWEHVLXQR7WJB3QHDBOXANCNFSM4FULRCWQ
.

Hi Shashank,
I create New Project In Ionic.
$ ionic start rfidtest blank
$ cd rfidtest
$ ionic cordova plugin add cordova-plugin-bluetooth-serial
$ npm install  @ionic-native/bluetooth-serial
$ ionic cordova plugin add cordova-plugin-zebra-scanner-ios
Added in the app.module.ts
import { BluetoothSerial } from '@ionic-native/bluetooth-serial/ngx';
...
providers: [
...,
BluetoothSerial
],
In Home.page.ts
import { Component } from '@angular/core';
import { Injectable } from '@angular/core';
import { BluetoothSerial } from '@ionic-native/bluetooth-serial';
import { Platform } from '@ionic/angular';
declare var window: any;
@Component({
selector: 'app-home',
templateUrl: 'home.page.html',
styleUrls: ['home.page.scss'],
})
@Injectable()
export class HomePage {
scannerName: string = 'RFD8500';
constructor() {
document.addEventListener('zebra.barcodeData',
this.bluetoothDataRead.bind(this), false);
}
CheckDeviceConnected (): void {
alert(this.scannerName);
window.ZebraScanner
   .getAvailableScanners()
   .then((res) => {
      if (res.length) {
         res.filter(item => {
            if (String(item.name).toLowerCase().indexOf(this.scannerName) !== -1) {
               //this.scannerID = item.scannerID;
               window.ZebraScanner.
                  establishCommunicationSession(item.scannerID)
                  .then(data => {
                     console.log("Device Connected")
                     alert("Connected");
                  }, error => {
                     console.log(error)
                  });
            }
         });
      } else {
         console.log("No Device Found")
         alert("Not Found");
      }
   });
 }

 bluetoothDataRead (event?): void {
  console.log("Read Success",event.detail.barcodeData);

}
}
In home.page.html
I Added this
<button ion-button (click)="CheckDeviceConnected ()">Button
I receive the error
Typeerror: cannot read property
'getavailablescanners' of undefined.
Please help on the issue
Thanks
Anand

Hi Anand,
Can you try debugging in the console? And see if you can access window?

I have also tried the above and it seems to be working however it doesn’t find the connected rfd8500 device. Returns Not Found.
Todd Loomis
From: Shashank Srivastava<EMAIL_ADDRESS>Reply-To: Shashank2406/cordova-plugin-zebra-scanner-ios<EMAIL_ADDRESS>Date: Friday, September 6, 2019 at 2:09 AM
To: Shashank2406/cordova-plugin-zebra-scanner-ios<EMAIL_ADDRESS>Cc: Todd Loomis<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Shashank2406/cordova-plugin-zebra-scanner-ios] RFID Support (#2)
Hi Anand,
Can you try debugging in the console? And see if you can access window?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ABIXL24ZZ4TDKY3WM4E7J6TQIHXXLA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6B243I#issuecomment-528723565, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABIXL23MKOWDZ7OI754VWC3QIHXXLANCNFSM4FULRCWQ.

Hi Todd,
I have not tested this plugin with RFD8500. It works well with Zebra CS3070 and CS4070. I will have to check if I can find RFD8500 device to debug the issue.

Thank you

I was just retesting and noticed I am getting this error:
-[mot_LEConnectivityMgr getAvailableScannersList:] Failed to start requested manual discovery

When i click scan button i received this error message.
On Sat, 7 Sep 2019, 3:58 a.m. Todd Loomis<EMAIL_ADDRESS>wrote:

I was just retesting and noticed I am getting this error:
-[mot_LEConnectivityMgr getAvailableScannersList:] Failed to start
requested manual discovery
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ANBBNHY26EAFIS3WFJ2IVPTQIKY4XA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6D42WA#issuecomment-528993624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANBBNH2FLH7NB5UBZSKD77LQIKY4XANCNFSM4FULRCWQ
.

@tloomis, @anandsamy81 - I checked and it turns out this package doesn't support RFD devices. Zebra has a separate SDK for RFD devices. I don't own any RFD device, so I won't be able to integrate it into this package.

hi Shashank,
Please send me your sample POC Code.
Thanks
Anand
On Mon, 9 Sep 2019 at 22:52, Shashank Srivastava<EMAIL_ADDRESS>wrote:

@tloomis https://github.com/tloomis, @anandsamy81
https://github.com/anandsamy81 - I checked and it turns out this
package doesn't support RFD devices. Zebra has a separate SDK for RFD
devices. I don't own any RFD device, so I won't be able to integrate it
into this package.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Shashank2406/cordova-plugin-zebra-scanner-ios/issues/2?email_source=notifications&email_token=ANBBNH6I7CPHZYCZN7IV5CDQIZPKXA5CNFSM4FULRCW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6H35IQ#issuecomment-529514146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANBBNH5YROYW2R5OHS637RTQIZPKXANCNFSM4FULRCWQ
.


Render available space for alternate (switch) zone

E.g. when strafing to the left, draw how much 'angle' remains if player had switched to the right, for current snap zone.

There is kind of a workaround with new accelerometer displaying when alternate zone has better accel. This might be good to close


Fix invalid assumption about routing fees

You can only take fee on outgoing channels

Yeah, I see the reasoning and totally agree it goes only one way. But isn't the fee only charged for incoming payments?
In the following I built a route to pay B by hopping through A.
Let's say, A is the entry point into the ring. B is another ring peer I have no direct channel with. You can see that A charges me 10 sats.
lncli buildroute --amt 100 --hops=A,B
{
    "route": {
        "total_fees": "10",
        "total_amt": "110",
        "hops": [
            {
                "amt_to_forward": "100",
                "fee": "10",
                "amt_to_forward_msat": "100000",
                "fee_msat": "10000",
                "pub_key": "A"
            },
            {
                "chan_capacity": "493100",
                "amt_to_forward": "100",
                "fee": "0",
                "amt_to_forward_msat": "100000",
                "fee_msat": "0",
                "pub_key": "B"
            }
        ],
        "total_fees_msat": "10000",
        "total_amt_msat": "110000"
    }
}

Nope. That's not how LN routing fees work. When routing a payment from A to C in A-B-C the B node charges fee set on the channel to C. So in case of ring and payment A-B1-B2-B3-C B1 charges for routing to B2, B2 for routing to B3 and B3 for routing to C. If fees in the ring are set to 0 only B1 charges anything and B1 just looses some inbound capacity for free.

Yes, sorry confusing it the other way around


Improve handling of disable/enable/ignore directives

Description

The current method, listing codes to disable and a list of exceptions to that list, still has trouble with some cases. For example, disabling a standard, re-enabling a category within that standard, then ignoring or disabling a sniff within that category cannot be handled. We'd need a list of exceptions to the exceptions, and possibly a list of exceptions to that list too, and figuring out how to keep those lists up to date as new directives are encountered could prove to be confusing.
Since the standard→category→sniff→code hierarchy is supposed to be thought of as a tree, let's store the ignore list that way instead. Manipulating the branches of the tree is straightforward no matter what directives are encountered.
In this implementation I've favored speed over space: there are cases where we could prune a subtree that would evaluate to "ignore" or "don't ignore" for any possible input, but detecting that doesn't seem worth the time when it's not likely there will be so many enable or disable directives that the wasted space will be a problem.
Suggested changelog entry

Fixed bug #111: Improve handling of disable/enable/ignore directives
Related issues/external references
Fixes #111
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

[ ] This change is only breaking for integrators, not for external standards or end-users.

[ ] Documentation improvement

Technically this could be considered a breaking change, since PHP_CodeSniffer\Tokenizers\Tokenizer->ignoredLines happens to be public and this changes the values stored there. Is that really a public API though?
PR checklist

[x] I have checked there is no other PR open for the same change.
[x] I have read the Contribution Guidelines.
[x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
[x] I have added tests to cover my changes.
[x] I have verified that the code complies with the projects coding standards.
[ ] [Required for new sniffs] I have added XML documentation for the sniff.

Thanks for porting this over @anomiex ! I will look at this at a later point in time and am tentatively earmarking this PR for the 4.0.0 release as it constitutes a bigger changes than I deem responsible for the 3.x branch.

Since it sounds like 4.0.0 is probably coming fairly soon after 3.8.0 now, that seems fine with me. :+1:
Also, since 4.0.0 is dropping old PHP support, I'm going to ignore the failing PHP 5.4 test. 🙂 Too bad it cancelled the rest of the tests after that one failed.


How to building MacOS,Targeting Android

For questions, please use the forum.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Other

Platform: [e.g. Win32, UWP, HoloLens, Android, iOS]

Please use the forum for questions.


Failure with an alternative package

Summary
When using cra and specifying an "alternative package" (cli-arg --scripts-version) that is a git-url, cra fails, if the package is scoped.
Example
yarn create react-app --scripts-version git+https://example.com/react-scripts.git testproject

package.json of https://example.com/react-scripts:
{
  "name": "@myscope/react-scripts",
  ...
}

Expected result
Successful creation of the new project.
Actual result
Failure with error Unable to find react-scripts in package.json.
Analysis

getPackageInfo() extracts the package name from the git-url, which is not scoped.
setCaretRangeForRuntimeDeps() uses that name to find the package in package.json
Since the name there (in package.json) is scoped, the package is not found, and an error is reported.

would something like https://github.com/facebook/create-react-app/pull/5709 fix this?

Hi @eddiemonge - looks promising. Will try tomorrow and let you know. Thanks for the hint!


Can't run upload example

Describe the bug
When running the upload example I get an exception type 'OSError' is not a subtype of type 'int' and the file received on the server is 0 byte long.
Expected behavior
A successful upload of the choosen file.
Platform:
Dart Native
FTP Server Software

ProFTPd
vsftpd

Log
Enable the debug Flag in the Constructor and paste the Log. Remember to remove sensitive information!
[14.03.2021 23:34:09.719] Connecting...
[14.03.2021 23:34:09.732] < 220 ProFTPD Server (ProFTPD Default Installation) [<IP_ADDRESS>]
[14.03.2021 23:34:09.732] > USER luke
[14.03.2021 23:34:09.838] < 331 Password required for luke
[14.03.2021 23:34:09.838] > PASS *************
[14.03.2021 23:34:09.939] < 230 User luke connected
[14.03.2021 23:34:09.939] Connected!
[14.03.2021 23:34:09.949] Upload File: test.zip
[14.03.2021 23:34:09.950] > TYPE I
[14.03.2021 23:34:10.051] < 200 Type set to I
[14.03.2021 23:34:10.051] > PASV
[14.03.2021 23:34:10.151] < 227 Entering Passive Mode (127,0,0,1,138,203).
[14.03.2021 23:34:10.173] > STOR test.zip
[14.03.2021 23:34:10.176] Opening DataSocket to Port 35531
[14.03.2021 23:34:10.182] Disconnecting...
[14.03.2021 23:34:10.182] > QUIT

I resolved using version 0.6.0 instead of the 0.8.0 which I was previously using.


Notesnook v3.0.8 -> v3.0.13

This is an update only for x86-64 Linux. Version for other platforms (v3.0.8) remains unchanged for other platforms.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hey @cig0 could you please review this?


Preserve expected permissions in atomic open_file

Fixes #1376. Replacement for closed PR #1382.

I'm fine with this in 7.1, but that means you need to rebase this onto the 7.x branch.

Nvm it still stats the old file. Still racy
On September 19, 2019 6:42:47 PM GMT+02:00, David Lord<EMAIL_ADDRESS>wrote:

I'm fine with this in 7.1, but that means you need to rebase this onto
the 7.x branch.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/click/pull/1400#issuecomment-533214247

Nvm it still stats the old file. Still racy

@untitaker This is an atomic write API, not a transaction API. As you know, if you use the file contents (say) to maintain a counter n, and one process increments it by 2 while a concurrent process increments it by 3, you will get one of n + 2, n + 3, n + 5. In other words, we guarantee that at least one of the updates will be applied consistently, but we can’t guarantee that the other update won’t be lost.
The OS’s chmod API is also an atomic write API. If two processes attempt to update the permissions concurrently, say to add independent bits, at least one of the updates will be applied consistently, but the other might be lost.
This PR allows these guarantees to be combined, treating the contents and permissions as a single atomic unit. If one process updates the file contents while a concurrent process updates the permissions, you might get the new contents with the old permissions, or the new contents with the new permissions. At least one of the updates will be applied consistently, but the other might be lost.
What this PR doesn’t provide is the ability to treat the contents and permissions as independent atomic units. I’m not aware of any OS interface short of special transactional filesystems that would allow that to be implemented.
But that’s okay because people don’t want to use permission bits to store concurrently updated mutable state. They just want the existing permissions to be preserved. If an application doing atomic writes needs to be stopped to reliably reconfigure its permissions, that’s fine. It’s certainly better than making no effort to preserve permissions at all.

@davidism Rebased onto 7.x.

From my understanding the content and permissions are not necessarily part of the same atomic unit, because the file content and the permissions might be read independently (i.e. the permissions fetched via stat() might be from a different file than the one that is being read for its contents). In that sense the inconsistent state is created when reading the old one, not when writing.
I'm not implying that your patch is bad (I believe there can't be a better one), but I believe there is an argument for not trying to solve this problem at all such that the user has to think about it explicitly.


Feature request: require_review_approval parameter

What
Implement the require_review_approval parameter, which stops the resource from triggering if the pull request does not have at least 1 approved review.
Why
My team would like to use this resource to only trigger on pull requests that have been reviewed & explicitly approved by a project maintainer using GitHub's existing permissions.  The filtering functionality appears to have existed in jtarchie's previous resource - I did my best to replicate.
Pull Request

[X] Implements a test for this feature
[X] Implements the feature
[X] Updates the documentation in README.md

Other
I thought it was worth calling out using GitHub's protected branch rules (see the Notes section in README) in tandem with this feature if your objective is very tight control on what gets triggered.  If the branch rules are NOT used, the first approved review will cause all subsequent commits to also trigger the resource.
Please let me know if there are any questions or suggestions and I'll be happy to address.  Thank you!

For what it's worth, our original objective was nearly identical to the one described in #58 -- we were thinking a PR comment or label to control resource filtering would be the way to go.  However, letting GitHub's existing permission requirements for who can approve a PR simplified things greatly.

@itsdalmo Would you mind reviewing / letting me know if you'd like any changes?

Hi @m17ch and thank you for the PR! Sorry for the long wait, I'll try to get this reviewed tomorrow/during the weekend and get back to you 🙌

Thank you for reviewing + feedback, @itsdalmo !

Since we are collecting the count of approving reviews, perhaps we should allow users to specify how many approving reviews are required (in Github you can require "at least N" reviews) also?

Sure - we could certainly add another config parameter to do that.  My original intention was simply to replicate the behavior in the previous plugin, which appeared to be  "require at least 1 approval."
Let me know if this aligns with what you were thinking:

add another source config parameter required_approvals -- document that it should be used in conjunction with require_review_approval
if required_approvals not used/set, default of 1 required approval
require sane values for required_approvals (i.e.  1 > X > 100 ) ?

It would be great if we could add e2e tests. Any suggestions for how that could be done?

This PR was modeled from https://github.com/telia-oss/github-pr-resource/pull/66  which explicitly called out the e2e test.  If you're thinking these should still be added, I may just need to do some investigation & hunt down some examples.

I was thinking we could just have a required_review_approvals: 2, required_approving_reviews: 3 or something to that effect, and just specify the number directly instead of adding another variable? Also, we don't need to require sane values I think because it has no bearing on the code - Github just gives us an int64 back and we can happily compare it to any value the user wants?

any news on this? Ive also been waiting for this feature specifically in order to migrate off the legacy pr resource.

Updated parameter name & type from require_review_approval (bool) to required_review_approvals (int) and updated documentation to reflect parameter name change.
Built & functionally validated -- think it's ready for another review @itsdalmo .  Let me know if you'd like any other tweaks!

Is this resource no longer maintained?

Is this resource no longer maintained?

It is, albeit slower than I would have liked in the summer months :)
This feature will now be built and available under the dev tag. Please try it out before I make a release also :)


Zip file entries with backslashes does not get converted to slashes on nix platforms in FastZip.Extract

Steps to reproduce

Create zip on Windows with backslash separators in paths
Extract zip on Linux
new FastZip().ExtractZip(storageZipPath, storageBaseFolder)

Expected behavior
Backslashes should be changed to slashes on Linux
Actual behavior
Backslashes extracted as part of filename
Version of SharpZipLib
1.3.0, 1.3.1
Everything works fine in 1.2.0, maybe the bug relates to #54

Whoa, that sounds odd... How did you create that zip file? Zip files should never contain backslashes in the file names:
https://p1k.se/appnote.md#s<IP_ADDRESS>
What is the output of unzip -Z -l YOUR_FILE.zip?

Yep, confirmed.

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Inconsistent completion, when json cache enabled

Completion without json cache: (expected one)

Completion with json cache enabled: (unexpected one)

@vbauerster ah, it's normal behavior. because Go stdlib have two scanner package.
so, deoplete-go will return the "mixed" two methods.
If parse all of import section, will return the correct method. but I was sloppy implementation.
BTW, gocode already have "no imported package completion". so I consider remove json cache feature on deoplete-go.
Well, sorry for confused you. that's no a bug :(

xref: https://github.com/zchee/deoplete-go/issues/70#issuecomment-260104611

@zchee Thank you, I see now. Yes I've noticed, that gocode has the feature already. Gocode authors were inspired by your plugin, most probably ;)

@vbauerster

Gocode authors were inspired by your plugin, most probably ;)

If so, I am extremely glad :D
I also maintain the gocode that for the go devel version support if possible. Also I will do my best to it :)


How to support the right-to-left or bi-directional text.

Hi,
currently there is no support for this feature.
Does it mean when you use:
lv_label_set_text(label, "ABC")
it should write:
                "CBA"
and also flush text to the right?

yes ,for example :  Arabic scripts are
written from the right to the left and that it does not know uppercase and lowercase
characters. Further the character codes of the text are not identical with the character index in the font file used to render the character, because the notation forms of
the characters depend on the positions in the text。

some language is  right-to-left  ,for example : Arabic scripts are
written from the right to the left and that it does not know uppercase and lowercase
characters. Further the character codes of the text are not identical with the character index in the font file used to render the character, because the notation forms of
the characters depend on the positions in the text。

I can make the library to support drawing the letters in a revers order.

the notation forms of the characters depend on the positions in the text。

Can you, please, show a real life example?

I found this: https://en.wikipedia.org/wiki/Arabic_script_in_Unicode#Contextual_forms
Do you think something like this?
If yes, then this kind of mapping is implementable.
However it means a lot of characters. Is it serious issue in Arabic language if you let the "base" latter when the substitute is not available?

you can download the pdf file from the site:  https://www.segger.com/downloads/emwin/UM03001
and look up the "chapter 32 language support--->32.3 Right to left- and bidirectional text"

Now its clear. Thank you!
We need a function which "translates" the letters according to its position.
Can help with implementing this function? And I will do the rest.

As there was no activity here for a while I close this issue.
If you have remarks about this topic feel free to comment here and reopen the issue.


4D image support in SimpleITK

Dear Bradley and friends,
I have long been impressed by the goal and execution of development of this library and you guys have my utmost respect. It solves an important but often overlooked problem is this field, namely  making the science-y algorithms user-friendly so the (often not so technical) clinical personnel can actually put them to good use.
I have humbly forked this library to integrate the elastix registration library and ease the learning curve for new elastix users. However, SimpleElastix does not support groupwise registration at the moment because of the lack of support for 4D images in SimpleITK. I recall having read it was a deliberate choice not to support 4D images in order to make the interface as simple as possible. I am less inclined to start hacking away at the robust internal API and would like to know what the prospects are for native 4D support before I start implementing it in SimpleElastix myself?

The long compile time and large binary size is a valid concern and a 4D CMake option is a good solution. I would happy to contribute such a feature upstream. Let me know if you prefer a Github pull request or another type of workflow (create branch from your JIRA etc).
To answer your question, I definitely agree that multichannel images cover most people's needs. In this case however, four spatial dimensions are required because of the implementation of groupwise registration in elastix which unfortunately does not take VectorImages but only one big 4D volume.

Great to hear that you would like to take up this issue.
We use JIRA( https://issues.itk.org ) to track, schedule, prioritize and assign issue. Along with breaking larger tasks into smaller ones. Most issues become a branch of master of the format SIMPLEITK-###_DESCIPTION, where there are merged into next for testing until complete then merged into master.
Please create JIRA issue(s) to for this tasks and assign them to yourself. We can continue the discussion there. Then doing a pull request on Github with the topic is fine.


Link from cancermodels.org to pdxfinder.org

Provide a link to PDXFinder from PDCM Finder.

duplicate, closing


Vortex - push changes from staging to main

Context
This ticket is to push all changes from staging to main branch

This ticket can be close as it has been executed.