Question,Help me!!

hi, guys.
My english is poor,but i want you help me !
i want set marin-right for star,like this!

Add the margin-right style to the .rating .star::before selector:
.rating .star::before {
    display: inline-block;
    color: $unfilled-star-color;
    content: '☆';
    width: 1em;
    height: 1em;
    margin-right: 0.5em;
}


Add review address

Thank you for your pull request and for contributing to this project. I noticed that your PR proposes adding the review_address field to the Configuration struct in src/request.rs. Before we proceed, could you please provide some rationale behind this change?
Understanding the context and reasoning for this modification will help us assess its impact on the protocol between REview and its clients. Specifically, we're interested in:

The problem or limitation you encountered that led to proposing this change.
How the addition of review_address improves or affects the functionality or performance of the protocol.
Any potential implications or adjustments that might be required for existing clients using this field.

Your insights on these points would be greatly appreciated and would greatly aid in our review process.

@dayeon5470 Let's discuss the change of Configuration in #58. Please close this issue (I cannot close this issue)


.pep8 file in subdirectories is not respected

In my project, I have an internal Python project for e2e tests. It is not the root directory. It has this layout:
package.json
e2e/.pep8
e2e/file.py

If I open the project directory in VS Code, and format e2e/file.py, it doesn't respect .pep8, and just uses the defaults.
Is it possible to support also sub .pep8 setting files?

Exactly, thanks for clarifying.


[0.7.5+] NS_ERROR_FAILURE on Firefox 47

C3 version: 0.7.5 and 0.7.6
D3 version: 5.10.0
Browser: Firefox 47.0.2
OS: Linux

Updating from 0.7.4 to any of the two new versions causes NS_ERROR_FAILURE Exception, result:<PHONE_NUMBER>. Not sure what that means. This is the stacktrace:
AxisInternal.prototype.updateTickTextCharSize/<@webpack://./node_modules/c3/src/axis-internal.js?:106:15
__webpack_exports__.default@webpack://./node_modules/d3-selection/src/selection/each.js?:5:28
AxisInternal.prototype.updateTickTextCharSize@webpack://./node_modules/c3/src/axis-internal.js?:103:3
axis/<@webpack://./node_modules/c3/src/axis-internal.js?:282:7
__webpack_exports__.default@webpack://./node_modules/d3-selection/src/selection/each.js?:5:28
axis@webpack://./node_modules/c3/src/axis-internal.js?:258:5
__webpack_exports__.default@webpack://./node_modules/d3-selection/src/selection/call.js?:5:3
redraw@webpack://./node_modules/c3/src/axis.js?:480:3
_chart_internal__WEBPACK_IMPORTED_MODULE_0__.ChartInternal.prototype.redraw@webpack://./node_modules/c3/src/core.js?:563:3
_chart_internal__WEBPACK_IMPORTED_MODULE_0__.ChartInternal.prototype.initWithData@webpack://./node_modules/c3/src/core.js?:327:5
_chart_internal__WEBPACK_IMPORTED_MODULE_0__.ChartInternal.prototype.init@webpack://./node_modules/c3/src/core.js?:59:5
Chart@webpack://./node_modules/c3/src/chart.js?:15:3
generate@webpack://./node_modules/c3/src/core.js?:36:12

Using the latest Chrome this doesn't happen so the issue is somewhere with older browsers.

Looks more like something specific to Firefox which raises an NS_ERROR_FAILURE if getBBox is called on an element not displayed (ex: display:none), according to this.
Which is a shame because it was introduced because getBoundingClientRect was returning different values between Chrome & Firefox.
sigh

@boris-petrov Do you have a conf of a graph that triggers the issue ?
I'd like to be sure to have a test case that fails.
Can't seems to reproduce the issue on newer version of Firefox and not sure how I can downgrade to such an old FF version.

@panthony - thanks for the support.
Not sure what you mean by "conf of a graph", could you explain please?
As for using an old Firefox - you can download a distribution from here. Just extract the archive for your OS and run the bin/firefox binary.
Thanks again!

@boris-petrov Not quite sure how to reproduce your issue.
I'm clicking on various samples using firefox 47 and they all seems to show fine.
Can't seems to be able to inspect anything to see if some kind of error shows in a console though...

Not sure what you mean by "conf of a graph", could you explain please?

I'd like to check something that I know for sure trigger the issue. In case this is related to some kind of combinaisons of configurations (ex: legend hidden, missing data point, whatever..).

The charts don't appear in our case at all due to that error - our integration tests caught that. So it is "blocking", yes.
This FF is very old indeed, we use it to test our ES5 build (and, as you can see, it actually does catch some errors that don't appear in the latest Chrome/Firefox builds). There is pretty much no other browser that you can use to test ES5 on Linux.
I'll try to create some reproduction now or at least give you some pointers.

@panthony - I can see that in my case it breaks when I just call:
const options = {
  bindto: '#someId',
  data: {
    type: 'pie',
    columns: []
  }
};
c3.generate(options);

This doesn't happen on your side using FF 47?
If not, could you point me to some standalone example project using c3 which I can just modify to break?

@boris-petrov Unfortunately no...

If there is a different behavior between FF on MacOSX & Linux ...

I'd say you can test the config I used here:
http://jsfiddle.net/xtpcqd30/
But FF47 is able to render jsfiddle apparently.

@panthony - using almost the same code as you, I managed to break it. As you mentioned in your first comment, the div must not be visible:

chart 1

Note the display: none style.

@boris-petrov Ok, then I believe a quick workaround for you would be to either use, in the mean time, something like visibility:hidden or position:absolute;left-99999px;top:-999999px;.

@panthony - yes, thanks. Will you consider fixing this? It's obviously a horrible Firefox bug but I guess it could be a common use case...

@boris-petrov Ideally yes although I'm not quite sure what could be done instead of try/catch and returning a size of 0.
Before it was using getBoundingClientRect I need to check the return of this method.

You could try-catch, yes, and then fall-back to the old code which used getBoundingClientRect I guess. Best of both worlds.

To be noted that:

The error is still thrown with recent versions of FF (yuks)
The getBoundingClientRect was returning everything at 0

A fix could be to wrap getBBox in a try/catch and return an "empty box" in case of an exception.

@boris-petrov Out of curiosity, what do you do once you rendered the chart within a display:none; div ?
Since, as far as I know, the chart can't be rendered properly.
Do you re-call manually redraw or something like this?

@panthony - well, the chart is rendered in a hidden panel, which, when expanded, would make a request and populate the chart with data by calling chart.load(columns: data, unload: true). We could, of course, not call c3.generate(options) at all when not visible. But we wouldn't have caught this bug in that case. :)
Thanks for fixing it so quickly!


Add Signup Form to Enable User Registration

Description
The project currently includes a login form for existing users but lacks a signup form to allow new users to register and create accounts. This limitation restricts user accessibility and prevents potential users from exploring the platform or its features.
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a SWOC'25 contributor.
[ ] I am a KWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Hey @pragna7 , Welcome to 💖TelMedSphere!!!!! Thanks for showing your interest but I think you get this issue in wrong way. There is sigup form in website, you can see it just clicking on "create an account". Feel free to create any other issue, you can take reference of below -
https://medium.com/@pratikmane610/beginner-friendly-issues-for-contributing-to-open-source-062e0f16ceab


Bring in omnibus branch with mysys2 fixes

This is temporary and should be reverted when merged.

Merge at will :D


Is there a firmware update plan?

I think the latest firmware can be found here:
http://dangerousprototypes.com/forum/index.php?topic=7218.msg70644#msg70644

In any case, the original firmware source code is always available in the first post of the thread.

And I think the original firmware is pretty much complete, as long as someone doesn't want to attach an unsupported iron/tip.

我认为可以在这里找到最新的固件：http :
//dangerousprototypes.com/forum/index.php?topic=7218.msg70644#msg70644

It's unknown for what reason! Nothing happens after the firmware is flashed! 1106 1306oled are all the same

Firmware is beeig now updated by the author in the new unisolder repo
Check it out at:
https://github.com/sparkybg/UniSolder-5.2
Closing as this is no longer relevant for this repo


Implement middleware for measuring timing of a request

Middleware should accept callback for writing/sending metrics to the storage
this callback should accept:

Request interface
Measured timing
Error if any assure during request processing.

Implemented in #53


Feature request

Perhaps something for the future is to build in a little "progress indicator" to see how much (%) of th he links in a m3u file are checked when scanning for dead links. (Seems that github doesn't have a portion "feature request", therefore I added it as an issue)

I think this is the right place for requests (?)
I've think about a progress indicator too.  Thats a bigger redesign of the methods. I don't know if I will find the time to do it.
Thanks

Will work in 1.4.1
A counter window with cancel task function to stop link check.

new release v1.4.1


crash on 1.10.2 - ClassNotFoundException: mcjty.lib.compat.CompatItemArmor

crashlog: https://gist.github.com/NikkyAI/66842350c95c889f90a7a252a4e2e3ef
disabling TOP lets minecraft launch, with it enabled it crashes

old compatlayer was the problem and i am blind


witness: pass state root when construct EmptyTx

Description
see https://github.com/bnb-chain/zkbnb/issues/203 for detail
Changes
Notable changes:

change zkbnb-crypto version in go.mod
pass state root when construct empty tx

already fixed in my pr, will close this.


Possible problem with multiple  tsconfig.json files in subdirectories

VSCode Version: 1.4.0-insider
OS Version: Windows 10

Please see the demonstration project on git: https://github.com/a8775/vscode-tsconfig
Setup
Tested with the following versions:

nodejs 6.2.0
typescript 1.8.9
typings 1.3.2

Steps to reproduce the problem:

Clone the project
In project directory execute commands:

npm install - to download  dependencies
typings install - to download required typings files

TypeScript
In working directory run the command: tsc -p .
Should compile correctly.
vscode
Select the right file in a editor window and compile the project:

Select the the file: ./MySubProject/mySubProjectFile.ts
Compile the project: Ctrl-Shift-B

The project should be compiled without errors.
Now press space in any syntactically correct place. You get compilation errors.

I was able to reproduce this.

The problem is that the code inside the mySubProject folder doesn't see the code in the typings folder. The compiler only looks from the tsconfig.json file downwards. If you want to keep your layout you can do the following: add a file typings.d.ts with the following content to the MySubProject folder
/// <reference path="../typings/index.d.ts" />

This makes it work correctly.

Thank you @dbaeumer for that hint.
I have solved the problem by removing/renaming the second tsconfig.json in MySubProject.
My main point was that the VSCode is not consistent and it looks like a bug:

Once I compile the project and VSCode UI shows zero errors,
After that I touch any key eg. space suddenly the errors appears.

What's more, logically when I compile the top project with tsc it's not showing any error and so the VSCode shouldn't as well.
I guess the problem is in the VSCode that it's using both of the tsconfig.json contrary to the tsc -p . that use only one found in the path passed as a parameter. I believe VSCode should do exactly the same.
The more I think about the problem, I am inclined to the opinion that it is a BUG in VSCode.

I do understand that the project has two tsconfig.json files and the problem is a misalignment between the tsc and the tsserver in terms of the project team. I will move the issue to the TS to comment on. For the TS team:

when running tsc -p . it compiles the files in MySubProject using the tsconfig.json from root.
when open a file in the tsserver from MySubProject the tsconfig.json from the MySubProject folde is used.

This results in different project scopes.

This issue was moved to Microsoft/TypeScript#10283

@dbaeumer sorry I was raising the problem again, I would like the tool I use every day was perfect for everyone :)
I appreciate the work of all team, thanks a lot!


catalog: use an Operation to generate the SQL result

right now, we have a SQL query inline in the adapter that we use to generate the catalog. we want this to be a SQL script that's included in the global project and that is executed via a dbt "Operation."
there's an Operation node type in node_types.py -- that is the thing we want to use.
there's no OperationRunner in node_runners.py. we'll need one of those.
an operation is just arbitrary sql that gets run, committed, and has the result optionally returned. operations can be selected from the dbt graph just like any other node. but note that there is no CLI syntax for selecting operations right now. you can use dbt internal code to do that.
so the task flow would be:

generate parsedmanifest
generate schemas list
find this special operation in the graph

this should probably be done inside the adapter function that you added previously so that we can add bigquery support later on. it's a good idea to add a helper function to dbt that allows us to find and call an operation by name very simply, because there could be other places in dbt that we want to create similar behavior

call it and fetch the result
process the result into the catalog

Added in #768 - closing


SFDX installation error on githubaction

Summary
while executing the  following command in the GitHub action
npm install --global sfdx-cli
getting the following message

shell: /usr/bin/bash -e {0}
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
added 1386 packages, and audited 1644 packages in 2m
67 packages are looking for funding
run npm fund for details
70 vulnerabilities (58 moderate, 12 high)
To address issues that do not require attention, run:
npm audit fix
To address all issues possible (including breaking changes), run:
npm audit fix --force
Some issues need review, and may require choosing
a different dependency.
Run npm audit for details.
/home/runner/work/_temp/95d208ad-f094-4288-834d-65a97eda105f.sh: line 2: node_modules/sfdx-cli/bin/run: No such file or directory
Error: Process completed with exit code 127.************************************
Steps To Reproduce:
Repository to reproduce: dreamhouse-lwc
NOTE: If your issue is not reproducable by dreamhouse-lwc, i.e. requires specific metadata or files, we require a link to a simple Salesforce project repository with a script to setup a scratch org that reproduces your problem.

Have node installed in the GitHub action
This is step 2. All steps should start with '1.'
jobs:
build:
runs-on: ubuntu-latest
steps:

uses: actions/checkout@v2
with:
ref: ${{ github.ref }}
fetch-depth: 0
if: github.event.action == 'opened' || github.event.action == 'synchronize' || github.event_name == 'push'

uses: actions/setup-node@v1
with:
node-version: '=16'
check-latest: true

name: Install Salesforce CLI
run: |
npm install --global sfdx-cli
node_modules/sfdx-cli/bin/run --version
node_modules/sfdx-cli/bin/run plugins --core

Expected result
SFDX should be isntalled
Actual result
error as mention above
System Information

If you are using sfdx

Run sfdx version --verbose --json

If you are using sf

Run sf version AND sf plugins --core

Paste the output here

Additional information
Feel free to attach a screenshot.

@gsinha-atrium
Don't do this way. You will spend lots of minutes intalling sfdx over and over again. Build a docker image and use it in your jobs. This will you will reduce the amount of time for your job to run, and you will he sure sfdx is available during your job.
Search for the job.container entry.

I also getting the same issue. I want to know that if this resolve or investigating stage.
error same as above.


[Queue] Added support for receiving one message from queue

Resolves https://github.com/Azure/azure-sdk-for-python/issues/14844 and resolves https://github.com/Azure/azure-sdk-for-python/issues/14762. Many customers have reported confusion around using receive_messages() to pop one item from the queue.
This PR adds a new API that makes it simpler for the user to pop one element.
Related issues:
https://github.com/Azure/azure-sdk-for-python/issues/14665
https://github.com/Azure/azure-sdk-for-python/issues/11784
https://github.com/Azure/azure-sdk-for-python/issues/14762

We should also do similar thing for peek_messages for completeness.

The reason I did not add a peek_message()/peek_one_message() method is because I believe the reason we wanted to create a receieve_one_message is due to the fact that it returns a page iterator which is not very convenient in the case of one message and creates confusion for some customers.
However, in the case of peeking the pre-exisitng peek_messages() is very straight forward and returns a [message(s)] depending on what the user set as max_messages. So if they simply pass max_messages=1 they would get a [message1].

We should also do similar thing for peek_messages for completeness.

The reason I did not add a peek_message()/peek_one_message() method is because I believe the reason we wanted to create a receieve_one_message is due to the fact that it returns a page iterator which is not very convenient in the case of one message and creates confusion for some customers.
However, in the case of peeking, the pre-exisitng peek_messages() is very straight forward and returns a [message(s)] depending on what the user set as max_messages. So if they simply pass max_messages=1 they would get a [message1].

message = client.peek_message()
if message is not None:
    do_something_with(message)
else
   do_something_else()

How would this look like with peek_messages ? What's the simplest way to do this with array as a result?

We should also do similar thing for peek_messages for completeness.

The reason I did not add a peek_message()/peek_one_message() method is because I believe the reason we wanted to create a receieve_one_message is due to the fact that it returns a page iterator which is not very convenient in the case of one message and creates confusion for some customers.
However, in the case of peeking, the pre-exisitng peek_messages() is very straight forward and returns a [message(s)] depending on what the user set as max_messages. So if they simply pass max_messages=1 they would get a [message1].

message = client.peek_message()
if message is not None:
    do_something_with(message)
else
   do_something_else()

How would this look like with peek_messages ? What's the simplest way to do this with array as a result?
In .NET I added both peek and receive after I had to write some array checking logic 10th time and that got me frustrated :)

so for your example, the current peek_messages() would do:
message = client.peek_messages(max_messages=1)
if message != []:
    do_something_with(message[0])
else:
    do_something_else()

We should also do similar thing for peek_messages for completeness.

The reason I did not add a peek_message()/peek_one_message() method is because I believe the reason we wanted to create a receieve_one_message is due to the fact that it returns a page iterator which is not very convenient in the case of one message and creates confusion for some customers.
However, in the case of peeking, the pre-exisitng peek_messages() is very straight forward and returns a [message(s)] depending on what the user set as max_messages. So if they simply pass max_messages=1 they would get a [message1].

message = client.peek_message()
if message is not None:
    do_something_with(message)
else
   do_something_else()

How would this look like with peek_messages ? What's the simplest way to do this with array as a result?
In .NET I added both peek and receive after I had to write some array checking logic 10th time and that got me frustrated :)

so for your example, the current peek_messages() would do:
message = client.peek_messages(max_messages=1)
if message != []:
    do_something_with(message[0])
else:
    do_something_else()

that looks good. let's leave it then until we have signal from users.


Conceal: search in a small window leaves cursor in wrong position

Describe the bug
This is about searching for a string in a window that has less then 11 lines and the line of the match contains characters that are concealed via syntax or via matchadd(). One can hit this issue typically when running vim in a 24x80 terminal and splitting the screen horizontally to have 3 or more normal windows plus a help window and having all windows have the same height. Searches in such a small help window are affected by this.
To Reproduce

vim --clean (or gvim --clean)
:help eval.txt
:10wincmd _
/expr-!=#
Observe: A match is found but the cursor position is wrong: It's not at the beginning of the match (the 'e' char) but 3 chars further (on the 'r of the matched string).
press CTRL-L
Observe: The cursor jumps to the correct position - to the 'e' char.

Expected behavior
The cursor should end up on the 'e' character right after after the search in step 4.
Screenshots
N/A
Environment (please complete the following information):

Vim 8.1.2090
OS: Debian 10
Terminal: gnome-terminal

Additional context

Jumping to the beginning of the line with the match and starting the search again (i.e. /expr-!=# + 0n) leaves the cursor in correct position.
There is no issue if the (help) window has more than 10 lines.
Windows with normal buffer types are affected too - it's not only help windows.
 The dict in the "VerifyScreenDump" line should have columns, not columne. But the test works nevertheless. Should the typo be corrected one would have to do a corresponding correction to the dump file so that it looks like this:

dumps/Test_cole_search.dump

|2+0&#ffffff0| @3
|3| @3
|/>e|x|p|r

I was not able to come up with an automated test without using terminal/screendump feature. The wrong cursor is a "ghost" cursor. Internally it's in the correct position. Vim script functions report correct column and CTRL-L confirms this.

So this issue is broader. The window size limitation is due to 'scrolloff'. The problem is not bound to searching. Generally whenever a cursor jump into a concealed line involves a scroll the symptom appears. To fix the issue I propose the following patch. It contains a test. For convenience, the attachment contains the patch too.
Tom
diff --git a/src/drawscreen.c b/src/drawscreen.c
index 275925727..0e274464d 100644
--- a/src/drawscreen.c
+++ b/src/drawscreen.c
@@ -1398,7 +1398,11 @@ win_update(win_T *wp)
     int		i;
     long	j;
     static int	recursive = FALSE;	// being called recursively
-    int		old_botline = wp->w_botline;
+    linenr_T	old_botline = wp->w_botline;
+#ifdef FEAT_CONCEAL
+    int		old_wrow = wp->w_wrow;
+    int		old_wcol = wp->w_wcol;
+#endif
 #ifdef FEAT_FOLDING
     long	fold_count;
 #endif
@@ -2567,18 +2571,52 @@ win_update(win_T *wp)
 	wp->w_valid |= VALID_BOTLINE;
 	if (wp == curwin && wp->w_botline != old_botline && !recursive)
 	{
+	    win_T	*wwp;
+#if defined(FEAT_CONCEAL)
+	    linenr_T	old_topline = wp->w_topline;
+	    int		new_wcol = wp->w_wcol;
+#endif
 	    recursive = TRUE;
 	    curwin->w_valid &= ~VALID_TOPLINE;
 	    update_topline();	// may invalidate w_botline again
-	    if (must_redraw != 0)
+
+#if defined(FEAT_CONCEAL)
+	    if (old_wcol != new_wcol && (wp->w_valid & (VALID_WCOL|VALID_WROW))
+						    != (VALID_WCOL|VALID_WROW))
+	    {
+		// A win_line() call applied a fix to screen cursor column to
+		// accomodate concealment of cursor line, but in this call to
+		// update_topline() the cursor's row or column got invalidated.
+		// If they are left invalid, setcursor() will recompute them
+		// but there won't be any further win_line() call to re-fix the
+		// column and the cursor will end up misplaced.  So we call
+		// cursor validation now and reapply the fix again (or call
+		// win_line() to do it for us).
+		validate_cursor();
+		if (wp->w_wcol == old_wcol && wp->w_wrow == old_wrow
+			&& old_topline == wp->w_topline)
+		    wp->w_wcol = new_wcol;
+		else
+		    redrawWinline(wp, wp->w_cursor.lnum);
+	    }
+#endif
+	    // New redraw either due to updated topline or due to wcol fix.
+	    if (wp->w_redr_type != 0)
 	    {
 		// Don't update for changes in buffer again.
 		i = curbuf->b_mod_set;
 		curbuf->b_mod_set = FALSE;
+		j = curbuf->b_mod_xlines;
+		curbuf->b_mod_xlines = 0;
 		win_update(curwin);
-		must_redraw = 0;
 		curbuf->b_mod_set = i;
+		curbuf->b_mod_xlines = j;
 	    }
+	    // Other windows might have w_redr_type raised in update_topline().
+	    must_redraw = 0;
+	    FOR_ALL_WINDOWS(wwp)
+		if (wwp->w_redr_type > must_redraw)
+		    must_redraw = wwp->w_redr_type;
 	    recursive = FALSE;
 	}
     }
diff --git a/src/testdir/test_matchadd_conceal.vim b/src/testdir/test_matchadd_conceal.vim
index 6684378f6..83eadce5a 100644
--- a/src/testdir/test_matchadd_conceal.vim
+++ b/src/testdir/test_matchadd_conceal.vim
@@ -8,6 +8,8 @@ if !has('gui_running') && has('unix')
 endif

 source shared.vim
+source term_util.vim
+source view_util.vim

 func Test_simple_matchadd()
   new
@@ -277,3 +279,40 @@ func Test_matchadd_and_syn_conceal()
   call assert_notequal(screenattr(1, 11) , screenattr(1, 12))
   call assert_equal(screenattr(1, 11) , screenattr(1, 32))
 endfunc
+
+func Test_cursor_column_in_concealed_line_after_window_scroll()
+  CheckRunVimInTerminal
+
+  " Test for issue #5012 fix.
+  " For a concealed line with cursor, there should be no window's cursor
+  " position invalidation during win_update() after scrolling attempt that is
+  " not successful and no real topline change happens. The invalidation would
+  " cause a window's cursor position recalc outside of win_line() where it's
+  " not possible to take conceal into account.
+  let lines =<< trim END
+    3split
+    let m = matchadd('Conceal', '=')
+    setl conceallevel=2 concealcursor=nc
+    normal gg
+    "==expr==
+  END
+  call writefile(lines, 'Xcolesearch')
+  let buf = RunVimInTerminal('Xcolesearch', {})
+
+  " Jump to something that is beyond the bottom of the window,
+  " so there's a scroll down.
+  call term_sendkeys(buf, ":so %\<CR>")
+  call term_sendkeys(buf, "/expr\<CR>")
+  call term_wait(buf)
+
+  " Are the concealed parts of the current line really hidden?
+  let cursor_row = term_scrape(buf, '.')->map({_, e -> e.chars})->join('')
+  call assert_equal('"expr', cursor_row)
+
+  " BugFix check: Is the window's cursor column properly updated for hidden
+  " parts of the current line?
+  call assert_equal(2, term_getcursor(buf)[1])
+
+  call StopVimInTerminal(buf)
+  call delete('Xcolesearch')
+endfunc

fix-conceal-cursor-pos.patch.txt

Tom wrote:

So this issue is broader. The window size limitation is due to
'scrolloff'. The problem is not bound to searching. Generally
whenever a cursor jump into a concealed line involves a scroll the
symptom appears. To fix the issue I propose the following patch. It
contains a test. For convenience, the attachment contains the patch
too.

Can you create a pull request, so that it triggers the CI tests?
--
hundred-and-one symptoms of being an internet addict:
71. You wonder how people walk
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Bram Moolenaar wrote:

Can you create a pull request, so that it triggers the CI tests?

Done. Pull Request #5215:
GitHub - "fix cursor column in concealed line after window scroll #5215"
https://github.com/vim/vim/pull/5215
vim_dev - "[vim/vim] fix cursor column in concealed line after window scroll (#5215)"
https://groups.google.com/forum/#!topic/vim_dev/cFeSIxAsnSc
Travis CI - "Build #10297 - vim/vim - Travis CI"
https://travis-ci.org/vim/vim/builds/610985079?utm_source=github_status&utm_medium=notification
Tom


HIVE-27669: Hive Acid CTAS fails incremental if no of rows inserted is > INT_MAX

If a Table is created using CTAS with rows > INT_MAX then beeline eats up the thrown error
As replication also uses the same infra it should also do the same instead of failing with NumberFormatException as CTAS creates the actual table underneath
Analysis:
HMS is not throwing any error and due to a lack of numbering in the error log from the thrift actual root cause of the Error is not known.
So, added code change will prevent it from breaking the replication

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

+1. LGTM.


feat: resizing option in pdf viewer enabled

Description
Added resizing option to the PDF viewer
Motivation and Context
In the PDF viewer, both the code editor and the previewer lie side by side. In some viewports, it is quite difficult to use the editor as both the editor and previewer shrinks due to the viewport.
How Has This Been Tested
Manually
Fixes
PDF Editor UX
Changes
Added custom zoom plugin to the PDF viewer.
Depends on

Tests included/Docs Updated?

[ ] I have added tests to cover my changes.
[ ] All relevant doc has been updated

https://github.com/user-attachments/assets/cd3f6950-6c23-4f44-b4a1-03029f444491


checker govet: use makeprgBuild

The current wiki page states that the govet checker doesn't use the
makeprgBuild function. I couldn't find a documented reason (in wiki,
commit messages, or in #616) that indicates why it must not use
makeprgBuild, so this commit makes it so. It's probably because the
checker was added in April 2013, before makeprgBuild was added in
November 2013.
The specific reason this is desirable is that otherwise go vet is
invoked without any extra arguments, meaning that it runs on the entire
set of files in the current directory. This causes it to output warnings
for files that are not the current file; the current file may be clean
but I may still see warnings for other files.
By using makeprgBuild, in addition to respecting
g:syntastic_go_govet_<option>, it would also only run on the current
file.

I admit maybe "I'm holding it wrong" and the go vet checker is intended to be run on all the files in the current directory, in which case I will gladly hear alternatives on how to suppress warnings that are not for the current file.

Small example of the situation I am trying to deal with: I might have two files:
a.go
package main

import "fmt"

func main() {
	fmt.Printf("Hello, %s\n")
}

b.go
package main

func aaaaaa() {
}

If we run go vet without arguments, it says:
a.go:6: missing argument for Printf("%s"): format reads arg 1, have only 0 args

Thus if I am editing b.go, my status bar displays [Syntax: line:6 (1)] Even though b.go has no line 6. (There is correctly no marker in the gutter though, the marker correctly only shows if I edit a.go). I would like that [Syntax: line:6 (1)] to not show up if I am looking at b.go, so I propose this PR.

I admit maybe "I'm holding it wrong" and the go vet checker is intended to be run on all the files in the current directory,

This is a line of thought worth exploring.

in which case I will gladly hear alternatives on how to suppress warnings that are not for the current file.

This is probably a bad idea in most situations, but if you actually want it, one way to do it might be something like this:
autocmd FileType go
    \ let b:syntastic_go_govet_quiet_messages =
    \     { '!file:p': '\V' . escape(expand('<afile>:p'), '\') }

Believe it or not, this is actually documented (see :h 'syntastic_<filetype>_<checker>_quiet_messages').

Thus if I am editing b.go, my status bar displays [Syntax: line:6 (1)]

This is correct, if you run :Errors you'll see the error in the loclist.

Even though b.go has no line 6.

Syntastic doesn't promise to show you something that makes sense regardless of how you configure it.  If you want syntastic to give you more discriminating information on the status line you might consider investing a minute in reading the relevant part of the manual: :h syntastic-statusline-flag and :h 'syntastic_stl_format'.

thus with this PR

That breaks the far more common case of checking modules.  Sorry, but no.

Thanks for the tips and pointers to manual, I have found the sections you point to and will read and decide how to configure for me.
Reading about go vet I have learned that it is indeed useful to provide it the entire package not single files.
It could be possible to both 1) preserve the entire package checking behavior and 2) use makeprgBuild which will allow the standard g:syntastic_go_govet_<option> to work if using self.makeprgBuild({ 'args_before': 'vet', 'fname': '' }) then. Let me know if that seems suitable as well.


[SNAP-1188] Fix for SNAP-1188 to set batch uuid to previous record if…

Changes proposed in this pull request

Fix for SNAP-1188.This issue was caused because data serializer was getting batchuuid as null.

Patch testing

Manually tested as well as executed unit test multiple time as this is caused intermitently
Also ran precheckin and all test passed

ReleaseNotes changes
(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?) No
Other PRs
… the current batchuuid is null

Ok for release but as discussed we need to understand from Suranjan the role of BatchUUID and how it is supposed to work. Will having two different UUIDs in the same batch cause any problem -- we currently don't know? Please track.

Created a jira to revisit the design of insertion of cached batch: this https://jira.snappydata.io/browse/SNAP-1212


Add a button to zoomToFit the path (as sometimes the zoom is disabled)

This commit adds a button to the web UI, to fit the zoom to the track. This may become useful given that now adding an intermediate point does not automatically rezoom.
This uses the suggestion from https://github.com/graphhopper/graphhopper/issues/775
I was not sure about the icon so I put the same as the fullscreen but with a magnifying glass (character) as overlay.
firefox // chromium
 //

Thanks for this. This is certainly useful, but the aim for GraphHopper Maps is really to provide a simple & clear UI. For that zoom-fit feature I think you can always quickly some out or in.
So I would like to avoid any further space used until we introduce some "expert mode" (that could be interesting for many other features we support like path details, round trips, isochrone, map matching etc). Another possibility is a complete rewrite but this is for another (bigger) issue ;)


Multiple Select - problem with long texts

Hello,
if I use long texts for multiselect, they escape their container:

.ui.multiple.dropdown>.label {
  white-space: normal
}

Adding tomorrow

Great, thank you very much for your advice and your excellent work.


Add simple hie.yaml

Description
This is necessary due to a bug somewhere in HLS 1.7 vs 1.8, which was upgraded in #4078.
Checklist

Branch

[x] Commit sequence broadly makes sense
[x] Commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.

Pull Request

[ ] Self-reviewed the diff
[ ] Useful pull request description at least containing the following information:

What does this PR change?
Why these changes were needed?
How does this affect downstream repositories and/or end-users?
Which ticket does this PR close (if any)? If it does, is it linked?

[ ] Reviewer requested

bors merge

Somehow the windows builder (or ghcup) mutated underneath :(

Somehow the windows builder (or ghcup) mutated underneath :(

Yes, this is horrible, if you have any idea what to try in order to fix this, I would be very thankful. I only tried switching to cabal 3.8 so far, which didn't help.

bors retry


Flyway core library requires version bump

What version of UAA are you running?
75.15.0
How are you deploying the UAA?
I am deploying the UAA
using a bosh release I downloaded from bosh.io
What did you expect to see? What goal are you trying to achieve with the UAA?
Flyway > 8.4.2
What did you see instead?
Flyway = 5.2.4
Notes:
Flyway ≤ 8.4.2 is prone to H2 Console allows remote attackers to execute arbitrary code via a jdbc:h2:mem JDBC URL. [CVE-2022-23221]
https://flywaydb.org/documentation/learnmore/releaseNotes.html#8.4.3

Hi,
UAA uses in-mem DB only for tests but in production we support only maria (mysql) and postgresql.
However if we face issues like https://github.com/cloudfoundry/uaa/issues/1829 I will update this .
Thank you

current flyway version now "7.15.0"


[BUG] RefreshMechanism error: always auto-refresh cards

https://github.com/oflg/Tidme/releases/tag/v1.4.3


The chat doesn't remember the conversation context

Plugin version - 1.10.8
When I ask a question and it returns the response, the next question can't reference the previous response.
I tried GPT-3.5 (turbo) and GPT-4 models.

So, the issue breaks the different chat tabs functionality, it just doesn't make any sense.

Hi,
Seems like JCEF is not supported in your IDE runtime. I have stopped supporting the older UI which might contain several bugs, including how the conversation context is put together.
Please follow these steps provided here.

@carlrobertoh Thank you so much, now it works.
Just some details for others who want to understand how to fix the issue:

JCEF is a feature present in JetBrains IDEs, like IntelliJ IDEA and WebStorm, allowing them to display web content within the IDE using Chromium-based browser components (the answer is from ChatGPT-4).
how to choose JCEF-based Java runtime for the IDE see https://issuetracker.google.com/issues/159933628#comment19

I believe the issue can be closed as solved.

Glad you got it worked out!
Probably should create a FAQ section to readme.


thanks for benchmarks

big thanks for benchmarks!
Didi you mind to update it with latest micro release?

I see the latest version 1.18.0 and may do some testing.
Hope for better performance 😁


1.21 Unable to open GUI

it crashes when I try to input this command（/seedcracker gui）

can you send a screenshot of your mod folder? And also the minecraft crash report when you use the command.

can you send a screenshot of your mod folder? And also the minecraft crash report when you use the command.

I think I have found a solution.When I input/secpacker 1.20 version to change the version, the GUI can open normally, but if I didn't input the command to change the version at the beginning, I couldn't open the GUI directly or even encountered errors

can you send a screenshot of your mod folder? And also the minecraft crash report when you use the command.

I think I have found a solution.When I input/seedcracker 1.20 version to change the version, the GUI can open normally, but if I didn't input the command to change the version at the beginning, I couldn't open the GUI directly or even encountered errors


New JK-BMS JK-PB2A16S20P  Inverter BMS not yet supported?

Is your feature request related to a problem? Please describe.
Analoge to the other issue, the New Inverter BMS from JK-BMS does not seem to be supported.
I can connect it via USB to Rs485 cable and the jk Software, but nö luck with this driver.
This bms is interesting because it Supports active balancing an the "inverter Features" to Limit the current for example while balancing two different Packs.
If i can help, please just let me know.
I can give ssh access if helpful.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

It's a bit tricky with the new JK Inverter BMS, since it's still under development from what I understood. Shouldn't it work out of the box with the Victron system? Or do you want to have more details like all the cell voltages?
I reference also this discussion here. https://github.com/Louisvdw/dbus-serialbattery/discussions/969


It would be useful to run as a Maven plugin or CLI application.

Hi,
It would be useful to run as a Maven plugin or CLI application.
Then it would be very useful for automatically generating documentation.
Regards
Artur

Sorry, I just seen that cli version exists.
Regards
Artur


Fix some style errors in the documentation

All instances of :: for marking code have been replaced with a more relevant .. code-block:: line. The are a few :: instances left in the docs, but only for marking plain text preformatted code.
.. code-block:: console has been used for all shell commands. According to the pygments documentation, this is the correct lexer for interactive shell sessions, as opposed to shell scripts.
All trailing whitespace has been trimmed, and tabs replaced with spaces.
versionadded notes for old versions have been dropped - there was one in the docs from version 0.7! I updated Creating a new Wagtail release to remind the release manager to remove old versionadded notes.
As a side note, should Creating a new Wagtail release be moved in to the repo so that it is version controlled, and can have PRs made against it?

Apparently I accidentally pushed this to torchbox/wagtail not takeflight/wagtail at first. I deleted the branch from torchbox/wagtail but Travis had already started the build, which proceded to fail when trying to clone in subsequent test runs. Sad times.

Thanks! Merged in 16213db0f8c6f9512dd6b9ee5f2234dfea4cb38f.


Use Calamares installer

Calamares is in the code yes but i do not know how to implement and i could try but this should be added in a newer versions


Pin libxml2 to version with fix.

Fixes #1066

@mkurc-ant Workaround in #1066 should not be required after this PR is merged.


An option to allow keywords on new line if there are comments when disallowKeywordsOnNewLine is true

Valid
if (x < 0) {
    x++;
} else {
    x--;
}

if (x < 0) {
    x++;
}
// comments
else {
    x--;
}

Invalid
if (x < 0) {
    x++;
}
else {
    x--;
}

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/19255710-an-option-to-allow-keywords-on-new-line-if-there-are-comments-when-disallowkeywordsonnewline-is-true?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

I think we can make an exception for if/else and I guess do/while as well (without a new option).

@hzoo sounds good

Glad to know that you guys think this is a good idea :smile:

If no one is looking at this, I am taking it up :)

Hey guys, did you treat this as a bug? So we can't enforce
if (x < 0) {
    x++;
}
// comments
else {
    x--;
}

as invalid like the old behaviour?

@stevemao  The PR that was merged included the exception that allows you to place comments between the if closing brace and the else keyword. So the code that you listed is now allowed even if you activated the disallowKeywordsOnNewLine for the "else" keyword

@oredi i know :D But I'm asking if there's a way to enforce
if (x < 0) {
    x++;
}
// comments
else {
    x--;
}

invalid? My original proposal was to add another option.

@stevemao oh sorry I misunderstood your message. The new implementation create an exception on the current option rather create a new one. So there is no way to enforce the code segment you listed as an error now.

If fine if this is by design :)

So the preferred implementation will be a new option and remove the exception on the original implementation? I can work on that if it is preferred

@markelog why is this reopened?

hmm, okay, if everybody is cool with it :-)

I asked because I wan't not sure. I guess it's not hard to implement it if anyone asks for it :)


Conflicting peer dependency when using with Vue 2.7

Describe the bug
The package has @vue-macros/define-props as a direct dependency, which in turn lists "vue": "^3.2.25" as a peerDependency.
This results in a conflict warning when using the package within a Vue 2.7 application.
Reproduction
N/A
System Info
N/A

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

$defineProps now supported Vue 2.


how do I get the latest stable version?

I just downloaded jsor-jcarousel-9aeceed but it breaks my existing page. I need to use setCallback, how do I get the latest stable version that supports that?

The master branch contains the new 0.3 which isn't released yet. You can download stable version from the tags page: https://github.com/jsor/jcarousel/tags


[Bug] Error deleting selected row

Before you submit this issue, have you checked the following

[X] Is this really a problem?
[X] I have searched the Github Issues for similar issues, but did not find anything.

Affected packages and versions
用最新0.5.0版本测试问题仍然存在
Reproduction link
1.创建sheet2

2.在sheet3中引用sheet2的数据，其中最后一行是每行的总计(使用公式SUM)，最后一列是每列的总计(使用公式SUM)

3.删除某选中行
Expected behavior
该选中行被删除
Actual behavior
该选中行未被删除，删除的是除总计行外的最后一行

System information
No response

Can you provide a complete sample?

Since you have not provided a reproduction according to the community guidelines, we will close this issue. Once you have prepared a reproduction, feel free to reopen it at any time.


Correctly parse (local) server name

It's a common practice to work with keyword (local) on "server/data source" name, specially with docker based sql server solutions.
Since it's not directly recognized as server name we can replace it with localhost instead to make it work fine

Oh, yeah we could definitely do this. Thank you.

Sorry for not merging this earlier.  I've been back for a while already, but didn't notice this notification.


Execution issue

Hi,
I found u on Youtube and really amazing presentation that i need to clear Graphql concept.
I've cloned this project and Tried to understand exactly what it is but when i executed this project i stuck for a moment because it is only showing Welcome to graphql-spqr-sample.. so i need ur help for Further Execution..

Hi,
this is the project used for the live demo on the presentations, we didn't really intend it for people to use as an example. However since a lot of people get confused by it I'll set aside some time in the next week to organize it and document it for external use. I'll post here when I do so you can give it a try again and see if you have any remaining questions.
If you don't want to wait here's a short explanation there are two controller classes, GraphQlSampleController exposes two Graph QL endpoints (one exposes the example API mapped by using annotations the other one API generated through domain bean mappings) and GraphiqlController is there to serve the Graphiql tool to try out the queries/mutations.
To try out the queries go to one of the Graphiql urls mapped by GraphiqlController  and execute queries that are in the comments above query methods in io.leangen.spqr.samples.demo.query  package.

Added a brief readme, switched to using spring boot for easier deployment, updated comments, now only /graphql endpoint is exposed.
Bugs in Sangria version of graphiql ui client tool are still there, probably going to revert to the old version, less features but less buggy.

Thx. I was going to redo that PR this week.
-d
On Aug 16, 2017 8:36 AM, "Milos Stojiljkovic"<EMAIL_ADDRESS>wrote:

Added a brief readme, switched to using spring boot for easier deployment,
updated comments, now only /graphql endpoint is exposed.
Bugs in Sangria version of graphiql ui client tool are still there,
probably going to revert to the old version, less features but less buggy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/leangen/graphql-spqr-samples/issues/3#issuecomment-322773167,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANJqv9dHODCdCbhTS-akeVdVh7e2Rzktks5sYvB2gaJpZM4OuZMz
.

No worries, it's been long coming to do it.

thnkx @BaldyLocks


Feature request: Publish as open testing

I would love to see an option to publish a release as open testing.
Right now my solution is to deploy as draft and then manually fill out open testing options:

@cosic Does the API even support setting these fields?
I'm happy to help develop this feature if it's feasble.

@AndrazP Hi. I looked for API methods but have not found. So I asked huawei support and they unfortunately answer

Huawei customer support
2021-12-13 14:14:54 GMT+03:00
Dear developer,
Thank you for your question! Unfortunately, There is no method for Open Testing in Publish API, and we don't have plans about it for now.
Have a nice day.
HUAWEI DTSE

Thanks for asking them.


[ADD]: STOLEN SWORD GAME 👾

PR Description 📜

This PR is about adding Stolen Sword Game

Fixes #1135

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Screenshots 📸

Thank you soo much for contributing to our repository 💗

Thank you @0xabdulkhalid ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @0xabdulkhalid , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Note to the reviewer

This PR is closed and reopened as per PA said in order to be merged

@Arun9739, Please review this PR

Thank you  @0xabdulkhalid , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Always clear hydrated stores inside the server-side rendering worker

This change is

Coverage remained the same at ?% when pulling 564bd205780a1d6fa4faaa1ae8a2ca14aafa233e on squadette:fix-clear-hydrated into<PHONE_NUMBER>eee2a11db7fa6571660932d1f3886d on shakacode:master.


Broken :only and :except options when serialising an object (as_json)

Dynamoid relies on ActiveModel to do the serialisation of Document objects. This should allow us to filter document attributes via a custom as_json method, when a document is serialised to JSON. Eg:
class MyDocument
  include Dynamoid::Document
  ...
  def as_json(options = {})
    super(options.merge(except: [:id]))
  end

Unfortunately, this doesn't work as expected because ActiveModel::Serialization.serializable_hash expects attributes.keys to return an array of strings, not symbols:

https://github.com/rails/rails/blob/v<IP_ADDRESS>/activemodel/lib/active_model/serialization.rb#L133

Good catch. It's definitely should be fixed. Added to the backlog.


JctFileManagerFactoryImpl tests

Adds tests for JctFileManagerFactoryImpl
Adds a @VisibleForTestingOnly annotation internally.

Codecov Report

Merging #296 (9e37811) into main (b5ba122) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   70.69%   70.71%   +0.01%
==========================================
  Files          89       89
  Lines        2744     2745       +1
  Branches      237      237
==========================================
+ Hits         1940     1941       +1
  Misses        725      725
  Partials       79       79

Impacted Files
Coverage Δ

...pes/jct/diagnostics/TracingDiagnosticListener.java
100.00% <ø> (ø)

...t/filemanagers/impl/JctFileManagerFactoryImpl.java
100.00% <ø> (ø)

...thub/ascopes/jct/junit/JavacCompilersProvider.java
100.00% <ø> (ø)

...opes/jct/filemanagers/impl/JctFileManagerImpl.java
43.65% <100.00%> (+0.45%)
:arrow_up:


Permissions for Creating Folders?

Hello,
I'm working on HydroShare export functionality for Model My Watershed. I am now able to successfully create resources and add files to them (for example: 66ce7b01a1e7490383e37a407979631c). So far I am using hs_restclient's createResource and addResourceFile methods, which work very well. However, if I try to create a folder with createResourceFolder, I get a HydroShareNotAuthorized exception:
HydroShareNotAuthorized at /export/hydroshare/
Not authorized to perform PUT on https://beta.hydroshare.org/hsapi/resource/3c741c66702649f689aedcd580e23f9b/folders/area-of-interest.

I am able to create folders using the HydroShare UI, so it seems I just don't have the permission in the REST API, which seems odd.
Here's what my code looks like (messy, early draft):
resource = hs.createResource(
    'CompositeResource',
    params.get('title', project.name),
    abstract=params.get('abstract', ''),
    keywords=('mmw', 'model-my-watershed')
)

aoi_folder = 'area-of-interest'
hs.createResourceFolder(resource, pathname=aoi_folder)

# AoI GeoJSON
aoi_geojson = GEOSGeometry(project.area_of_interest).geojson
aoi_file = StringIO.StringIO()
aoi_file.write(aoi_geojson)
hs.addResourceFile(resource, aoi_file,
                   '{}/{}'.format(aoi_folder, 'shape.geojson'))

# AoI Shapefile
aoi_json = json.loads(aoi_geojson)
crs = {'no_defs': True, 'proj': 'longlat',
       'ellps': 'WGS84', 'datum': 'WGS84'}
schema = {'geometry': aoi_json['type'], 'properties': {}}
with fiona.open('/tmp/{}.shp'.format(resource), 'w',
                driver='ESRI Shapefile',
                crs=crs, schema=schema) as shapefile:
    shapefile.write({'geometry': aoi_json, 'properties': {}})

for ext in SHAPEFILE_EXTENSIONS:
    with open('/tmp/{}.{}'.format(resource, ext)) as shapefile:
        hs.addResourceFile(resource, shapefile,
                           '{}/shape.{}'.format(aoi_folder, ext))

Hi @rajadain thanks for reporting this. I should be able to get to this later this week.


Removed asgiref dependency

Fix for: #337
Replaced WsgiToAsgi (asgiref.wsgi) usage with WSGIMiddleware (starlette.middleware.wsgi) to fix breaking changes with asgiref 3.0.0.
I also ran pipenv update to remove asgiref from Pipfile.lock and it also updated a bunch of the dependencies — is that okay?

@tomchristie I ended up reverting the Pipfile.lock changes with the exception of the asgiref removal and that allowed the tests to pass.

@tomchristie Thanks for reviewing — what's the process for getting this merged in?

Thanks! It's looking good so I've merged it! 🎉

@timofurrer Awesome, thanks!

Thank you for this!!! I have been using @jonbeebe's version all morning (successfully). Very glad to see this go in!


Angular 7

Any plans to upgrade to Angular 7? it has been released over 3 months ago

Can you state where you think Angular7 provides a significant advantage in terms of functionality or performance, over Angular6 ? Do you have any particular use-case where this could be handy ?

@vp93 angular is about to release version 8 and continuously releases updates including performance enhancements and security patches.
In my opinion, seed projects such as this should remain as close as possible to the angular releases, at least the major ones so that minor/patch versions can be updated manually by the users of this seed.

https://blog.angular.io/tagged/release notes


Use Vorpal in place of home grown REPL

I just wanted to let you know about Vorpal. It is a awesome REPL library that looks like it might make this cli a lot simpler. From what I can tell it should support all the features you need, and even make implementing some of your open issues really easy.
Thanks for making this, it has been super useful for debugging a recent project that uses leveldb.

Vorpal looks cool! But it's a large dependency which also has massive dependencies. Everything i need in terms of the REPL is done in about 15 lines of code.


Package $EXERCISM_DIFFERENCE-OF-SQUARES exceeds ABAP 30-characters name limit

What can I do?
local package $exercism already is quite short, isn't it?
What Package names do you use that it works?
Thanks
Enno

there is a discussion in one of the PRs
IMHO, we can provide a different repository for students to easily download the exercises
for authors of new exercises, its not possible to use exclusively abapGit anyho, as there are duplicate filenames to be created, plus markdown/json files to be edited


ElastiCache Redis Cluster access breaks when using TLS?

Bug description
This bug is related to https://github.com/istio/istio/issues/33336 - but not the same. On the heels of us debugging https://github.com/istio/istio/issues/33336, we thought that perhaps we needed to use TLS mode so that Envoy might be able to report some metrics. Also, TLS is good - right? So we thought we would convert our ElastiCache cluster to use encryption for all traffic, and then configure our environment to have Envoy handle the TLS for us.
As we mention in #33336, we need to have Envoy do the backend redirection for us (enable_redirection: true) so that our clients can be dumb and simple, letting Envoy handle all of the "MOVED" calls for example. Just as a reminder, this configuration below works:
Working Configuration to Non-TLS Endpoint:
---
apiVersion: networking.istio.io/v1beta1
kind: Sidecar
metadata:
  name: test
spec:
  workloadSelector:
    labels:
      run: debug-diranged
  outboundTrafficPolicy:
    mode: REGISTRY_ONLY
  egress:
    - bind: <IP_ADDRESS>
      captureMode: NONE
      port:
        number: 6379
        protocol: REDIS
        name: redis
      hosts:
        - ./*
---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: redis-proxy
spec:
  resolution: DNS
  hosts:
    - benchmark.....clustercfg.usw2.cache.amazonaws.com
  endpoints:
    - address: benchmark.....clustercfg.usw2.cache.amazonaws.com
      ports:
        redis: 6379
  exportTo: [.]
  location: MESH_EXTERNAL
  ports:
    - number: 6379
      name: redis
      protocol: REDIS
---
apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
metadata:
  name: redis-proxy
spec:
  host: benchmark.....clustercfg.usw2.cache.amazonaws.com
  exportTo: [.]
  trafficPolicy:
    connectionPool:
      tcp:
        connectTimeout: 500ms
        tcpKeepalive:
          time: 300s
          interval: 60s
          time: 300s
---
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: redis-proxy
spec:
  workloadSelector:
    labels:
      run: debug-diranged
  configPatches:
    - applyTo: NETWORK_FILTER
      match:
        listener:
          name: <IP_ADDRESS>_6379
          filterChain:
            filter:
              name: envoy.filters.network.redis_proxy
      patch:
        operation: REPLACE
        value:
          name: envoy.filters.network.redis_proxy
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.filters.network.redis_proxy.v3.RedisProxy
            latencyInMicros: true
            stat_prefix: outbound|6379||benchmark.....clustercfg.usw2.cache.amazonaws.com
            prefix_routes:
              catch_all_route:
                cluster: outbound|6379||benchmark.....clustercfg.usw2.cache.amazonaws.com
            settings:
              op_timeout: 0.3s
              enable_redirection: true
              enable_command_stats: true
              read_policy: ANY

    - applyTo: CLUSTER
      match:
        context: SIDECAR_OUTBOUND
        cluster:
          port: 6379
          service: benchmark.....clustercfg.usw2.cache.amazonaws.com
      patch:
        operation: MERGE
        value:
          health_checks:
            - custom_health_check:
                name: envoy.health_checkers.redis
                typed_config:
                  "@type": type.googleapis.com/envoy.extensions.health_checkers.redis.v3.Redis
              timeout: 0.5s
              interval: 2s
              unhealthy_threshold: 2
              healthy_threshold: 1

root@debug-diranged:/data# redis-cli mget a b c d e f g
1) (nil)
2) (nil)
3) (nil)
4) (nil)
5) (nil)
6) (nil)
7) (nil)
root@debug-diranged:/data#

Switching the configuration to use a TLS backend (with a modified DestinationRoute) causes the redirection to break:
---
apiVersion: networking.istio.io/v1beta1
kind: Sidecar
metadata:
  name: test
spec:
  workloadSelector:
    labels:
      run: debug-diranged
  outboundTrafficPolicy:
    mode: REGISTRY_ONLY
  egress:
    - bind: <IP_ADDRESS>
      captureMode: NONE
      port:
        number: 6379
        protocol: REDIS
        name: redis
      hosts:
        - ./*
    - hosts:
        - '*/*'

---

apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: redis-proxy
spec:
  resolution: DNS
  hosts:
    - clustercfg.benchmark-tls.....clustercfg.usw2.cache.amazonaws.com
   endpoints:
    - address: clustercfg.benchmark-tls.....clustercfg.usw2.cache.amazonaws.com
      ports:
        redis: 6379
  exportTo: [.]
  location: MESH_EXTERNAL
  ports:
    - number: 6379
      name: redis
      protocol: REDIS

---
apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
metadata:
  name: redis-proxy
spec:
  host: clustercfg.benchmark-tls.....clustercfg.usw2.cache.amazonaws.com
  exportTo: [.]
  trafficPolicy:
    tls:
      mode: SIMPLE
      caCertificates: /etc/ssl/certs/ca-certificates.crt
    connectionPool:
      tcp:
        connectTimeout: 500ms
        tcpKeepalive:
          time: 300s
          interval: 60s
          time: 300s

---

apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: redis-proxy
spec:
  workloadSelector:
    labels:
      run: debug-diranged
  configPatches:
    - applyTo: NETWORK_FILTER
      match:
        listener:
          name: <IP_ADDRESS>_6379
          filterChain:
            filter:
              name: envoy.filters.network.redis_proxy
      patch:
        operation: REPLACE
        value:
          name: envoy.filters.network.redis_proxy
          typed_config:
            '@type': type.googleapis.com/envoy.extensions.filters.network.redis_proxy.v3.RedisProxy
            latencyInMicros: true
            stat_prefix: outbound|6379||clustercfg.benchmark-tls.....clustercfg.usw2.cache.amazonaws.com
            prefix_routes:
              catch_all_route:
                cluster: outbound|6379||clustercfg.benchmark-tls.....clustercfg.usw2.cache.amazonaws.com
            settings:
              op_timeout: 0.3s
              enable_redirection: true
              enable_command_stats: true
              read_policy: ANY

    - applyTo: CLUSTER
      match:
        context: SIDECAR_OUTBOUND
        cluster:
          port: 6379
          service: clustercfg.benchmark-tls.....clustercfg.usw2.cache.amazonaws.com
      patch:
        operation: MERGE
        value:
          health_checks:
            - custom_health_check:
                name: envoy.health_checkers.redis
                typed_config:
                  "@type": type.googleapis.com/envoy.extensions.health_checkers.redis.v3.Redis
              timeout: 0.5s
              interval: 2s
              unhealthy_threshold: 2
              healthy_threshold: 1

root@debug-diranged:/data# redis-cli mget a b c d e f g
1) (error) MOVED 15495 benchmarkt-tls-0003-001.benchmarkt-tls....usw2.cache.amazonaws.com:6379
2) (error) MOVED 3300 benchmarkt-tls-0001-001.benchmarkt-tls....usw2.cache.amazonaws.com:6379
3) (error) MOVED 7365 benchmarkt-tls-0002-001.benchmarkt-tls....usw2.cache.amazonaws.com:6379
4) (nil)
5) (nil)
6) (nil)
7) (error) MOVED 7233 benchmarkt-tls-0002-001.benchmarkt-tls....usw2.cache.amazonaws.com:6379

[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[x] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
I am not expecting that just by switching to a TLS backed Redis cluster, the enable_redirection: true flag seems to no longer work or apply. I am not sure if I have a mistake in my configuration, or if this is a known issue.
Steps to reproduce the bug
Launch an ElastiCache cluster in AWS with a few Node Groups and Replicas and with Transit Encryption turned on.
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
$ istioctl version --remote
client version: 1.10.0
control plane version: 1.10.0
data plane version: 1.9.0 (2 proxies), 1.10.0 (10 proxies)
$ kubectl version --short
Client Version: v1.21.1
Server Version: v1.20.4-eks-6b7464

How was Istio installed?
Via the Istio Operator
Environment where the bug was observed (cloud vendor, OS, etc)
EKS on AWS

Are there any developers who can help troubleshoot or better understand this issue?


fix(tests): cleanup tests to prepare for tokenomics testing

Noticed for Tokenomcis testing I will need to reuse a lit of functionality. Started to cleanup TaikoL1 tests but also moved on to Bridge as they seemed the messiest so far.
Decided to separate integration tests into their own files.

@cyberhorsey is this ready for review? (just in case you forgot to change the status)

@cyberhorsey is this ready for review? (just in case you forgot to change the status)

Nah, finishing up some basic tokenomics scaffolding right now.

There is also a test failure in the checks.


truncated error message: disconnected: ** (DBConnection.ConnectionError) owner #PID<..*> exited

👋
Environment

Elixir version (elixir -v):

Erlang/OTP 24 [erts-12.1.4] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [dtrace]

Elixir 1.12.3 (compiled with Erlang/OTP 24)

Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.):

docker:gangstead/postgis:13-arm (server 13.1 (Debian 13.1-1.pgdg100+1))

Ecto version (mix deps):

3.7.1

Database adapter and version (mix deps):

postgrex 0.15.13

Operating system:

macos 11.6 (20G165)

Current behavior
Repro: https://github.com/ruslandoga/ecto_error
When running mix test with ecto_sql 3.7.1, I'm sometimes getting what seems to be a truncated error message:
17:09:19.897 [error] Postgrex.Protocol (#PID<0.253.0>) disconnected: ** (DBConnection.ConnectionError) owner #PID<0.286.0> exited

for this contrived test:
https://github.com/ruslandoga/ecto_error/blob/120fba5cb603bf543d745fbc6815ea12b2752a31/test/ecto_error_test.exs#L12-L26
And sometimes I'm getting the full error message as shown below.
But in the "real" app where the repo is being used from a phoenix channel after receiving a message at the end of the test I'm only getting the truncated error version. I can update my repro repo to include a phoenix channels test more similar to my actual issue if needed.
# in phoenix channel
def handle_info({:event, id}, socket) do # {:event, id} is a side-effect that gets sent to the channel at the end of the test block
  if event = some_repo_get(id) do # leads to disconnected: ** (DBConnection.ConnectionError) owner #PID<0.286.0> exited
    push(socket, "event", render_event(event)) # and assert_push "event", _payload at the end of test block fixes the error, but that's probably obvious ...
  end

  {:noreply, socket}
end

Expected behavior
I expect the error message to include the helpful Client #PID<0.291.0> is still using a connection from owner at location: part:
[error] Postgrex.Protocol (#PID<0.255.0>) disconnected: ** (DBConnection.ConnectionError) owner #PID<0.286.0> exited

Client #PID<0.291.0> is still using a connection from owner at location:

    :prim_inet.recv0/3
    (postgrex 0.15.13) lib/postgrex/protocol.ex:2996: Postgrex.Protocol.msg_recv/4
    (postgrex 0.15.13) lib/postgrex/protocol.ex:2042: Postgrex.Protocol.recv_bind/3
    (postgrex 0.15.13) lib/postgrex/protocol.ex:1967: Postgrex.Protocol.bind_execute/4
    (ecto_sql 3.6.2) lib/ecto/adapters/sql/sandbox.ex:372: Ecto.Adapters.SQL.Sandbox.Connection.proxy/3
    (db_connection 2.4.1) lib/db_connection/holder.ex:354: DBConnection.Holder.holder_apply/4
    (db_connection 2.4.1) lib/db_connection.ex:1333: DBConnection.run_execute/5
    (db_connection 2.4.1) lib/db_connection.ex:1428: DBConnection.run/6
    (db_connection 2.4.1) lib/db_connection.ex:593: DBConnection.parsed_prepare_execute/5
    (db_connection 2.4.1) lib/db_connection.ex:585: DBConnection.prepare_execute/4
    (postgrex 0.15.13) lib/postgrex.ex:313: Postgrex.query_prepare_execute/4
    (ecto_sql 3.6.2) lib/ecto/adapters/sql.ex:367: Ecto.Adapters.SQL.query!/4

The connection itself was checked out by #PID<0.291.0> at location:

    (postgrex 0.15.13) lib/postgrex.ex:313: Postgrex.query_prepare_execute/4
    (ecto_sql 3.6.2) lib/ecto/adapters/sql.ex:367: Ecto.Adapters.SQL.query!/4

https://gist.github.com/ruslandoga/e8b5d228bc4514b2a206039320744e59 shows a few runs with the following deps
%{
  "connection": {:hex, :connection, "1.1.0", "ff2a49c4b75b6fb3e674bfc5536451607270aac754ffd1bdfe175abe4a6d7a68", [:mix], [], "hexpm", "722c1eb0a418fbe91ba7bd59a47e28008a189d47e37e0e7bb85585a016b2869c"},
  "db_connection": {:hex, :db_connection, "2.4.1", "6411f6e23f1a8b68a82fa3a36366d4881f21f47fc79a9efb8c615e62050219da", [:mix], [{:connection, "~> 1.0", [hex: :connection, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ea36d226ec5999781a9a8ad64e5d8c4454ecedc7a4d643e4832bf08efca01f00"},
  "decimal": {:hex, :decimal, "2.0.0", "a78296e617b0f5dd4c6caf57c714431347912ffb1d0842e998e9792b5642d697", [:mix], [], "hexpm", "34666e9c55dea81013e77d9d87370fe6cb6291d1ef32f46a1600230b1d44f577"},
  "ecto": {:hex, :ecto, "3.7.1", "a20598862351b29f80f285b21ec5297da1181c0442687f9b8329f0445d228892", [:mix], [{:decimal, "~> 1.6 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "d36e5b39fc479e654cffd4dbe1865d9716e4a9b6311faff799b6f90ab81b8638"},
  "ecto_sql": {:hex, :ecto_sql, "3.7.1", "8de624ef50b2a8540252d8c60506379fbbc2707be1606853df371cf53df5d053", [:mix], [{:db_connection, "~> 2.2", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.7.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.4.0 or ~> 0.5.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.15.0 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "2b42a32e2ce92f64aba5c88617891ab3b0ba34f3f3a503fa20009eae1a401c81"},
  "postgrex": {:hex, :postgrex, "0.15.13", "7794e697481799aee8982688c261901de493eb64451feee6ea58207d7266d54a", [:mix], [{:connection, "~> 1.0", [hex: :connection, repo: "hexpm", optional: false]}, {:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}], "hexpm", "3ffb76e1a97cfefe5c6a95632a27ffb67f28871c9741fb585f9d1c3cd2af70f1"},
  "telemetry": {:hex, :telemetry, "1.0.0", "0f453a102cdf13d506b7c0ab158324c337c41f1cc7548f0bc0e130bbf0ae9452", [:rebar3], [], "hexpm", "73bc09fa59b4a0284efb4624335583c528e07ec9ae76aca96ea0673850aec57a"},
}

Hi @ruslandoga 👋
Yes, it is a race condition. We show the stacktrace and related information if the process are available and if the process happens to be using the connection. But you may be either before or after those events, in which case the connection process has "nothing" to show.
If you generate a new app with Phoenix v1.6, check out the new way it starts the owner, it should be more resilient to cases like yours. If the issue still persists, please open up an issue on Phoenix with the channel test example and copy me. I can take a look there, but it isn't an Ecto issue. :)

@ruslandoga I can see that you are already using start_owner and stop_owner, so I think the issue with the channel likely still exists. I am investigating.

Can you please try Phoenix master?

@josevalim
Before using master:
> mix test

...************..............................***.........................................................*.........................14:55:20.124 [error] Postgrex.Protocol (#PID<0.570.0>) disconnected: ** (DBConnection.ConnectionError) client #PID<0.1343.0> exited
..................

  1) test more with active users more than count (TWeb.FeedChannelTest)
     test/t_web/channels/feed_channel_test.exs:231
     Assertion with == failed
     code:  assert feed == [%{"distance" => 9510, "profile" => %{user_id: m1.id, name: "mate-1", gender: "F", story: [%{"background" => %{"proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q", "s3_key" => "test"}, "labels" => []}]}}, %{"distance" => 9510, "profile" => %{user_id: m2.id, name: "mate-2", gender: "N", story: [%{"background" => %{"proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q", "s3_key" => "test"}, "labels" => []}]}}]
     left:  [
              %{"distance" => 9510, "profile" => %{gender: "N", name: "mate-2", story: [%{"background" => %{"proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q", "s3_key" => "test"}, "labels" => []}], user_id: "0000017d-0a58-a2eb-1e00-8a0e24440000"}},
              %{
                "distance" => 9510,
                "profile" => %{
                  gender: "F",
                  name: "mate-1",
                  story: [
                    %{
                      "background" => %{
                        "proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q",
                        "s3_key" => "test"
                      },
                      "labels" => []
                    }
                  ],
                  user_id: "0000017d-0a58-a2e4-1e00-8a0e24440000"
                }
              }
            ]
     right: [
              %{
                "distance" => 9510,
                "profile" => %{
                  gender: "F",
                  name: "mate-1",
                  story: [
                    %{
                      "background" => %{
                        "proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q",
                        "s3_key" => "test"
                      },
                      "labels" => []
                    }
                  ],
                  user_id: "0000017d-0a58-a2e4-1e00-8a0e24440000"
                }
              },
              %{"distance" => 9510, "profile" => %{gender: "N", name: "mate-2", story: [%{"background" => %{"proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q", "s3_key" => "test"}, "labels" => []}], user_id: "0000017d-0a58-a2eb-1e00-8a0e24440000"}}
            ]
     stacktrace:
       test/t_web/channels/feed_channel_test.exs:266: (test)

..

Finished in 2.5 seconds (2.4s async, 0.03s sync)
13 doctests, 139 tests, 1 failure, 16 skipped

Randomized with seed 335055

Using {:phoenix, github: "phoenixframework/phoenix", override: true},:
mix test
...************..................................***.......................................14:56:56.729 [error] Process #PID<0.1076.0> raised an exception
** (ArgumentError) fetch_test_supervisor!/0 can only be invoked from the test process
    (phoenix 1.6.2) lib/phoenix/test/channel_test.ex:413: Phoenix.ChannelTest.fetch_test_supervisor!/0
    (phoenix 1.6.2) lib/phoenix/test/channel_test.ex:388: anonymous fn/4 in Phoenix.ChannelTest.join/4
    (phoenix 1.6.2) lib/phoenix/channel/server.ex:28: Phoenix.Channel.Server.join/4
    (phoenix 1.6.2) lib/phoenix/test/channel_test.ex:391: Phoenix.ChannelTest.join/4
    test/t_web/channels/call_channel_test.exs:254: anonymous fn/4 in TWeb.CallChannelTest."test presence receives presence_state and presence_diff on join/leave"/1
...............*................

  1) test more with active users more than count (TWeb.FeedChannelTest)
     test/t_web/channels/feed_channel_test.exs:231
     Assertion with == failed
     code:  assert feed == [%{"distance" => 9510, "profile" => %{user_id: m1.id, name: "mate-1", gender: "F", story: [%{"background" => %{"proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q", "s3_key" => "test"}, "labels" => []}]}}, %{"distance" => 9510, "profile" => %{user_id: m2.id, name: "mate-2", gender: "N", story: [%{"background" => %{"proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q", "s3_key" => "test"}, "labels" => []}]}}]
     left:  [
              %{"distance" => 9510, "profile" => %{gender: "M", name: "mate-3", story: [%{"background" => %{"proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q", "s3_key" => "test"}, "labels" => []}], user_id: "0000017d-0a5a-1c28-1e00-8a0e24440000"}},
              %{
                "distance" => 9510,
                "profile" => %{
                  gender: "F",
                  name: "mate-1",
                  story: [
                    %{
                      "background" => %{
                        "proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q",
                        "s3_key" => "test"
                      },
                      "labels" => []
                    }
                  ],
                  user_id: "0000017d-0a5a-1c1c-1e00-8a0e24440000"
                }
              }
            ]
     right: [
              %{
                "distance" => 9510,
                "profile" => %{
                  gender: "F",
                  name: "mate-1",
                  story: [
                    %{
                      "background" => %{
                        "proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q",
                        "s3_key" => "test"
                      },
                      "labels" => []
                    }
                  ],
                  user_id: "0000017d-0a5a-1c1c-1e00-8a0e24440000"
                }
              },
              %{"distance" => 9510, "profile" => %{gender: "N", name: "mate-2", story: [%{"background" => %{"proxy" => "https://d1234.cloudfront.net/1hPLj5rf4QOwpxjzZB_S-X9SsrQMj0cayJcOCmnvXz4/fit/1000/0/sm/0/aHR0cHM6Ly9wcmV0ZW5kLXRoaXMtaXMtcmVhbC5zMy5hbWF6b25hd3MuY29tL3Rlc3Q", "s3_key" => "test"}, "labels" => []}], user_id: "0000017d-0a5a-1c22-1e00-8a0e24440000"}}
            ]
     stacktrace:
       test/t_web/channels/feed_channel_test.exs:266: (test)

............

  2) test presence receives presence_state and presence_diff on join/leave (TWeb.CallChannelTest)
     test/t_web/channels/call_channel_test.exs:227
     Assertion failed, no matching message after 1000ms
     The process mailbox is empty.
     code: assert_receive %Phoenix.Socket.Broadcast{event: "presence_diff", payload: %{joins: joins, leaves: leaves}}
     stacktrace:
       test/t_web/channels/call_channel_test.exs:288: (test)

...14:56:57.772 [error] Postgrex.Protocol (#PID<0.574.0>) disconnected: ** (DBConnection.ConnectionError) client #PID<0.1468.0> exited
............

Finished in 2.4 seconds (2.3s async, 0.04s sync)
13 doctests, 139 tests, 2 failures, 16 skipped

Randomized with seed 662000

The failing test seems to only fail when there is 14:55:20.124 [error] Postgrex.Protocol (#PID<0.570.0>) disconnected: ** (DBConnection.ConnectionError) client #PID<0.1343.0> exited as if this failure makes some change in postgres row order (the failing test is not using an explicit order_by to fetch the "profiles")

@ruslandoga so part of the issue seems to be you are joining a channel for tests outside of the test process. If you fix that, master will at least guarantee a proper shutdown ordering (i.e. the channel will be shutdown before the connection owner).

@josevalim only the presence test uses "external" process, I'll fix that. The test causing 14:56:57.772 [error] Postgrex.Protocol (#PID<0.574.0>) disconnected: ** (DBConnection.ConnectionError) client #PID<0.1468.0> exited is using the test process though.

Right, any process that you spawn in your tests that are not under the test supervisor will shutdown after the connection, which will lead to such errors. The commit to latest Phoenix addresses this issue for channels. For presence, you need to ask the presence tasks to terminate: https://hexdocs.pm/phoenix/Phoenix.Presence.html#module-testing-with-presence
and similar to an other process that may be involved. :)

@josevalim I've opened an issue in phx repo https://github.com/phoenixframework/phoenix/issues/4590


Fix Cmd.use_rawinput type in debuggers

Why is this an issue? In the example below:
class Some:
   a = True
   b: bool = True

a and b have different semantics. Since a is initialized in a class body, tools like mypy assume it is a class attribute. Mypy also does inference its type to be bool, no annotation is needed.
But, b is different. It is annotated as an instance-level variable with a class-level default. (yeap, typing is a different world)
The same semantics a = True has can be specified by a: ClassVar[bool] = True, but I don't think it is worth it. Just removing type annotation is good enough.
Found in https://github.com/python/typeshed/pull/8692

Do you have a link to the part of the Python typing docs that describes this behavior?

I think this is now out-of-date due to https://github.com/google/jax/pull/14695.


New version: JetBrains.CLion version 2024.2.3

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run

This package installs and launches normally in a Windows 10 VM.

This package installs and launches normally in a Windows 10 VM.


Document new process for adding new user type

The group is called grads
Just need to look up that group number and create them under that Linux group and SLURM group.

I think I added this but let me know if the new docs are confusing or need more details @andriy-safe-ai


Responsive fixes

Remaining Issues

both API pages
glossary
navigation (this needs to be merged first)

I'm merging this and making new issues about remaining things.

API pages and glossary do not have a toggle to show the table of contents on mobile
Responsive styling can be added to the navigation PR itself


[dv/common] Clean up old makefile flow

Delete unused files
Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

Also clean up existing Makefiles in IP area and references to it:
w/dv/tools/README.md:12:  - hw/dv/tools/Makefile
hw/dv/tools/README.md:32:hw/dv/tools/Makefile
hw/ip/aes/dv/Makefile:55:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/tlul/generic_dv/xbar.mk:126:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/i2c/dv/Makefile:38:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/rv_timer/dv/Makefile:56:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/trial1/dv/Makefile:26:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/spi_device/dv/Makefile:57:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/alert_handler/dv/Makefile:42:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/rv_dm/dv/Makefile:68:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/hmac/dv/Makefile:76:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/uart/dv/Makefile:94:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/gpio/dv/Makefile:107:include ${DV_DIR}/../../../dv/tools/Makefile
hw/top_earlgrey/dv/Makefile:106:include ${DV_DIR}/../../dv/tools/Makefile

Also clean up existing Makefiles in IP area and references to it:
w/dv/tools/README.md:12:  - hw/dv/tools/Makefile
hw/dv/tools/README.md:32:hw/dv/tools/Makefile
hw/ip/aes/dv/Makefile:55:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/tlul/generic_dv/xbar.mk:126:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/i2c/dv/Makefile:38:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/rv_timer/dv/Makefile:56:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/trial1/dv/Makefile:26:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/spi_device/dv/Makefile:57:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/alert_handler/dv/Makefile:42:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/rv_dm/dv/Makefile:68:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/hmac/dv/Makefile:76:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/uart/dv/Makefile:94:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/gpio/dv/Makefile:107:include ${DV_DIR}/../../../dv/tools/Makefile
hw/top_earlgrey/dv/Makefile:106:include ${DV_DIR}/../../dv/tools/Makefile

good catch.
Updated. I also remove 2 README in i2c/dv and top_earlgrey as they are replaced by dv_plan
and add trial1_sim_cfg.hjson for trial1 to run with dvsim. PTAL

Also clean up existing Makefiles in IP area and references to it:
w/dv/tools/README.md:12:  - hw/dv/tools/Makefile
hw/dv/tools/README.md:32:hw/dv/tools/Makefile
hw/ip/aes/dv/Makefile:55:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/tlul/generic_dv/xbar.mk:126:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/i2c/dv/Makefile:38:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/rv_timer/dv/Makefile:56:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/trial1/dv/Makefile:26:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/spi_device/dv/Makefile:57:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/alert_handler/dv/Makefile:42:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/rv_dm/dv/Makefile:68:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/hmac/dv/Makefile:76:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/uart/dv/Makefile:94:include ${DV_DIR}/../../../dv/tools/Makefile
hw/ip/gpio/dv/Makefile:107:include ${DV_DIR}/../../../dv/tools/Makefile
hw/top_earlgrey/dv/Makefile:106:include ${DV_DIR}/../../dv/tools/Makefile

good catch.
Updated. I also remove 2 README in i2c/dv and top_earlgrey as they are replaced by dv_plan
and add trial1_sim_cfg.hjson for trial1 to run with dvsim. PTAL

Nice, thanks!


See the following example: https://try.jsoup.org/~hqqzULvYYckf8ztA-ZohK3Yt3c0
The <template> element is allowed within other elements that accept meta data content (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template).
The <head> element accepts meta data content (in fact it only accepts meta data content): https://developer.mozilla.org/en-US/docs/Web/HTML/Element/head
Therefore <template> elements are valid inside a <head>, and the <head> should not be closed.
This also is like both Firefox and Chrome handle the example code.

There is probably a more general problem with the handling of the <template> element with other issues present (#1409, #1315).

Feature track: #1634


False problem reported: 'js:valuesImpl' tag (or tag before this tag) is unclosed or tag not allowed here.

There is problem reported but there is no problem.
How to reproduce: Using latest VSCode and latest extension (v0.4.2), create sample app with this code:
<?xml version="1.0" encoding="utf-8"?>
<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
	xmlns:js="library://ns.apache.org/flexjs/basic">
	<js:initialView>
		<js:View>
			<js:Label text="Hello World" x="100" y="100"/>
		</js:View>
	</js:initialView>
	<js:valuesImpl>
		<js:SimpleCSSValuesImpl />
	</js:valuesImpl>
</js:Application>

after </js:initialView> press ENTER create new line, and write letter or two to get auto completion and click any of the auto complete suggestions.
do same in next new line.
problem is reported, which is ok, like: 'This text is unexpected. It will be ignored.'
delete created lines (to get original sample code only), two problems appear:
message: 'This text is unexpected. It will be ignored.'
at: '8,19'
message: ''js:valuesImpl' tag (or tag before this tag) is unclosed or tag not allowed here.'
at: '11,2'

Workaround: Restart VSCode, problem is gone.
Comment: There should not be any problems. It looks something is not "refreshed" after deleting new lines. Could be related to https://github.com/BowlerHatLLC/vscode-nextgenas/issues/46#issuecomment-268132244

I'm not able to reproduce this issue with version 0.4.2 of the extension. When I delete the extra lines, the errors go away. I tested with both FlexJS 0.7.0 and 0.8 nightly.
This sounds a bit like an old issue that I fixed in 0.3.1, where certain errors were not cleared out after they were fixed.
Have you ever installed the extension manually from a VSIX file? In some of my test environments, I've tried updating an extension from the VSCode Marketplace after I had an older VSIX version installed. It would appear in VSCode that the newer version was installed, but I would see behavior from an older version instead (old bugs and things). Then, when I uninstalled the extension, the older version from the VSIX file would show up in the Extensions list after restarting. I had to uninstall twice and then reinstall. I wouldn't expect that you would install the extension a VSIX file, but since I upload them in releases here on Github, I guess it's possible. If you have, try uninstalling (as many times as it takes, if the extension keeps showing up again).

Could be that the extension was once installed manually, but anyway, after uninstalling, restart VSCode, installing again, once I got the same issue again. Still not sure how. While testing I noticed this line:
xmlns:js="library://ns.apache.org/flexjs/basi xmlns:ns1="com.adobe.tvsdk.mediacore.*"c">
It looks like, while adding new namespace, existing namespace string is cut by minus one character. Maybe this is another issue. To get this issue just add some non "js" namespace component. For example: press "<", after auto complete dropdown appears, select first suggestion. In my case it was ABRControlParameters.

Does the extension parse MXML tags or VSCode or?

MXML is parsed and checked for errors by the compiler in the FlexJS SDK.

If you can successfully build the same project, and the compiler output doesn't include an error either, then it's a compiler bug. If there is an error, then the extension has a bug and I need to figure out where the error is exposed.

Ok. What is controlling when red marks (for problem code) appear?
Sometimes the issue disappears when close/open file, but always when VSCode is restarted.

The extension tells VSCode which errors to underline. If an error won't go away, then it may be that the extension is failing to clear awayold errors. It's also possible that the compiler has a bug which causes it to get into a bad state.

I think you are on good trail of it. It looks like last error is misreported again as error.

Here is gif with example when problem appears:

Unfortunately, I'm still not able to reproduce either of the issues you reported in this thread.

I randomly gave it a try on Windows today, and I could reproduce both issues. For some reason, they will not reproduce on macOS, though.

So it turns out that the way that I was storing files in memory was changing all line endings to \n, even if the file's line endings where \r\n. This led to some things getting out of sync, and that caused both of these issues.
I will release version 0.4.3 next week with the fix.