modified () operator for sparse matrix to be consistent with dense matrix

not sure anywhere else still using the sparse matrix () operator, but get all the unit test passed. tell me what you think. @iglesias @karlnapf #2769

I am really surprised to see that nothing breaks after this change! Does this mean that SGSparseMatrix is not really used anywhere? I would expect that all around where SGSparseMatrix::operator() is used, the features and vector indices should be swapped. Am I missing something?

Careful!
This is the final patch, see list here: http://permalink.gmane.org/gmane.comp.ai.machine-learning.shogun/5463
We cannot merge this without being absolutely certain that it doesnt break things.
You  basically have to search for all places where SGVSparseMatrix is imported and then check for the () operatior being invoked. A bit messy.

However, after thats done, we can merge. Thanks a lot for your help

I don't think there is any risk as the operator() is used nowhere but the unit test.

In fact, I really wonder whether we need it if it is not used.

It kind of is a dangerous thing for sparse structures as one should always iterate through the list of non-zero elements

@karlnapf I checked before, actually the () operator is not used anywhere except for one unit test (ProbingSample test), where it constructed a symmetric matrix, thus the order actually doesn't matter.

Sorry for the late reply.
I agree if it is not used then the order doesnt matter.
We should probably unify the interface with other langauges as @iglesias suggested.


home_page.dart error at step 12. Sorting and Filtering Data

home_page.dart:90 code:
             data.loadFilteredRestaurants(filter).listen(_updateRestaurants);
(full home_page.dart code at bottom.)
Expected behavior:
The query requires an index. You can create it here: https://console.firebase.google.com/project/.../database/firestore/indexes?create_index=...
Instead Got:
Uncaught (in promise) TypeError: Cannot read property 'listen' of undefined
at home_page.dart:90
at home_page._HomePageState.new.setState (framework.dart:1244)
at home_page._HomePageState.new._onFilterBarPressed (home_page.dart:82)
at _onFilterBarPressed.next ()
at async_patch.dart:45
at _RootZone.runUnary (zone.dart:1450)
at _FutureListener.thenAwait.handleValue (future_impl.dart:143)
at handleValueCallback (future_impl.dart:696)
at Function._propagateToListeners (future_impl.dart:725)
at async._AsyncCallbackEntry.new.callback (future_impl.dart:393)
at Object._microtaskLoop (schedule_microtask.dart:41)
at _startMicrotaskLoop (schedule_microtask.dart:50)
at async_patch.dart:166
xpat@penguin:~/FlutterProjects/codelabs/friendly_flutter$ flutter doctor -v
[✓] Flutter (Channel dev, 1.22.0-9.0.pre, on Linux, locale en_US.UTF-8)
• Flutter version 1.22.0-9.0.pre at /home/xpat/development/flutter
• Framework revision 7a43175198 (3 weeks ago), 2020-08-28 23:18:04 -0400
• Engine revision 07e2520d5d
• Dart version 2.10.0 (build 2.10.0-73.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /home/xpat/Android/Sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /opt/android-studio/jre/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• clang version 7.0.1-8 (tags/RELEASE_701/final)
• cmake version 3.13.4
• ninja version 1.8.2
• pkg-config version 0.29
[✓] Android Studio (version 4.0)
• Android Studio at /opt/android-studio
• Flutter plugin version 47.1.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] VS Code (version 1.46.1)
• VS Code at /usr/share/code
• Flutter extension version 3.12.2
[✓] Connected device (3 available)
• Linux (desktop)  • linux      • linux-x64      • Linux
• Web Server (web) • web-server • web-javascript • Flutter Tools
• Chrome (web)     • chrome     • web-javascript • Google Chrome 83.0.4103.116
• No issues found!
xpat@penguin:~/FlutterProjects/codelabs/friendly_flutter$
Even after deploying the indexes from firestore.indexes.json
xpat@penguin:~/FlutterProjects/codelabs/friendly_flutter$ firebase deploy --only firestore:indexes
=== Deploying to ''...
i  deploying firestore
i  firestore: reading indexes from firestore.indexes.json...
✔  firestore: deployed indexes in firestore.indexes.json successfully
✔  Deploy complete!
xpat@penguin:~/FlutterProjects/codelabs/friendly_flutter$ flutter doctor -v
[✓] Flutter (Channel dev, 1.22.0-9.0.pre, on Linux, locale en_US.UTF-8)
• Flutter version 1.22.0-9.0.pre at /home/xpatdevelopment/flutter
• Framework revision 7a43175198 (3 weeks ago), 2020-08-28 23:18:04 -0400
• Engine revision 07e2520d5d
home_page.dart full code:
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//      http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

import 'dart:async';
import 'dart:math';

import 'package:cloud_firestore/cloud_firestore.dart';
import 'package:firebase_auth/firebase_auth.dart';
import 'package:flutter/material.dart';

import 'restaurant_page.dart';
import 'model/data.dart' as data;
import 'model/filter.dart';
import 'model/restaurant.dart';
import 'widgets/empty_list.dart';
import 'widgets/filter_bar.dart';
import 'widgets/grid.dart';
import 'widgets/dialogs/filter_select.dart';

class HomePage extends StatefulWidget {
  static const route = '/';

  HomePage({Key key}) : super(key: key);

  @override
  _HomePageState createState() => _HomePageState();
}

class _HomePageState extends State<HomePage> {
  _HomePageState() {
    FirebaseAuth.instance
        .signInAnonymously()
        .then((UserCredential userCredential) {
      _currentSubscription =
          data.loadAllRestaurants().listen(_updateRestaurants);
    });
  }

  @override
  void dispose() {
    _currentSubscription?.cancel();
    super.dispose();
  }

  StreamSubscription<QuerySnapshot> _currentSubscription;
  bool _isLoading = true;
  List<Restaurant> _restaurants = <Restaurant>[];
  Filter _filter;

  void _updateRestaurants(QuerySnapshot snapshot) {
    setState(() {
      _isLoading = false;
      _restaurants = data.getRestaurantsFromQuery(snapshot);
    });
  }

  Future<void> _onAddRandomRestaurantsPressed() async {
    final numReviews = Random().nextInt(10) + 20;

    final restaurants = List.generate(numReviews, (_) => Restaurant.random());
    data.addRestaurantsBatch(restaurants);
  }

  Future<void> _onFilterBarPressed() async {
    final filter = await showDialog<Filter>(
      context: context,
      builder: (_) => FilterSelectDialog(filter: _filter),
    );
    if (filter != null) {
      await _currentSubscription?.cancel();
      setState(() {
        _isLoading = true;
        _filter = filter;
        if (filter.isDefault) {
          _currentSubscription =
              data.loadAllRestaurants().listen(_updateRestaurants);
        } else {
          _currentSubscription =
              data.loadFilteredRestaurants(filter).listen(_updateRestaurants);
        }
      });
    }
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        leading: Icon(Icons.restaurant),
        title: Text('FriendlyEats'),
        bottom: PreferredSize(
          preferredSize: Size(320, 48),
          child: Padding(
            padding: EdgeInsets.fromLTRB(6, 0, 6, 4),
            child: FilterBar(
              filter: _filter,
              onPressed: _onFilterBarPressed,
            ),
          ),
        ),
      ),
      body: Center(
        child: Container(
          constraints: BoxConstraints(maxWidth: 1280),
          child: _isLoading
              ? CircularProgressIndicator()
              : _restaurants.isNotEmpty
                  ? RestaurantGrid(
                      restaurants: _restaurants,
                      onRestaurantPressed: (id) {
                        // TODO: Add deep links on web
                        Navigator.pushNamed(context, RestaurantPage.route,
                            arguments: RestaurantPageArguments(id: id));
                      })
                  : EmptyListView(
                      child: Text('FriendlyEats has no restaurants yet!'),
                      onPressed: _onAddRandomRestaurantsPressed,
                    ),
        ),
      ),
    );
  }
}

Thanks for reporting! We recently refactored that part of the codelab, and some typo might have snuck in. I'll take a look!

Thanks, @ditman You may find that your code was fine and free of typos.  I with I could have just deleted this issue.  After posting it, I went back to my the code in lib/src/model.data.  Under the method
Stream<QuerySnapshot> loadFilteredRestuarants
I had one or two too-many closing brackets at the end of the method. (Instead of replacing the block with new code, as instructed, I typed in the code line-by-line.) Once I removed those extra closing brackets and re-ran the program, it worked like a charm.
The odd-thing is that I didn't get any Dart Analysis warnings or errors.  So it wasn't immediately clear to me that it was a Dart error.

Thanks for letting me know @xpat! It's probably hard to reproduce now, but if you're able to reproduce your problem, you might want to submit a bug to the dart-lang analyzer, especially if you get a small repro case that they can take a look at.

@ditman As you suggested, I tried to reproduce and could.  I just compared the code from before and after through Android Studio's VCS, show history command.  There were enough brackets, just not in the right places. If I had simply cut and pasted, as instructed, or typed the code correctly, I wouldn't haven't gotten the Type Error message.  So in this case Dart Analysis worked as expected.

@xpat yes, I'm not sure what you're seeing, but I assume the analyzer worked; if you have an idea on how the output would have been clearer for you in that case, it might be a worthy bug report/feature suggestion.


The '-' is treated as minus when it starts a new line equation

Best regards,
gagmeng

Hi @gagmeng,
That's the default behavior.  Calculations are continued on the next line if the line starts with an operator (+-/*).  However this can be turned off in Settings:


Improve Javadoc of ConfigurableFilePermissions.html#unix(int)

Expected Behavior
Prevent misuse of API.
It is easy to think that unix(755) is rwxr-xr-x.

https://docs.gradle.org/current/javadoc/org/gradle/api/file/ConfigurableFilePermissions.html#unix(int)

Sets Unix style numeric permissions. See unix(String) for details.

https://docs.gradle.org/current/javadoc/org/gradle/api/file/ConfigurableFilePermissions.html#unix(java.lang.String)

The NUMERIC notation consist of 3 digits having values from 0 to 7. 1st digit represents the OWNER, 2nd represents the GROUP while the 3rd represents OTHER users.

Examples:

Numeric
Symbolic
Meaning

000
---------
no permissions

700
rwx------
read, write & execute only for owner

The description and the table suggest using a 3-digit number.
Current Behavior
https://github.com/gradle/gradle/blob/035834c2fa7b88422635cde176fe9c7a6f6b8bc7/platforms/core-configuration/file-collections/src/main/java/org/gradle/api/internal/file/DefaultConfigurableFilePermissions.java#L96-L100
https://github.com/gradle/gradle/blob/035834c2fa7b88422635cde176fe9c7a6f6b8bc7/platforms/core-configuration/file-collections/src/main/java/org/gradle/api/internal/file/AbstractFilePermissions.java#L32-L35
https://github.com/gradle/gradle/blob/035834c2fa7b88422635cde176fe9c7a6f6b8bc7/platforms/core-configuration/file-collections/src/main/java/org/gradle/api/internal/file/DefaultConfigurableUserClassFilePermissions.java#L38-L42
https://github.com/gradle/gradle/blob/035834c2fa7b88422635cde176fe9c7a6f6b8bc7/platforms/core-configuration/file-collections/src/main/java/org/gradle/api/internal/file/AbstractUserClassFilePermissions.java#L33-L35
jshell --feedback=silent - <<< 'System.out.println((((755 & 0_700) >> 6) & 4) >> 2 == 1)'
false
 ~ % jshell --feedback=silent - <<< 'System.out.println((((0755 & 0_700) >> 6) & 4) >> 2 == 1)'
true

Context
https://docs.gradle.org/current/userguide/working_with_files.html#sec:setting_file_permissions

file: read & write for owner, read for group, read for other (0644, rw-r—r--)
directory: read, write & execute for owner, read & execute for group, read & execute for other (0755, rwxr-xr-x)

https://docs.gradle.org/current/javadoc/org/gradle/api/file/FilePermissions.html

FILE: read & write for OWNER, read for GROUP, read for OTHER (0644, rw-r--r--)
DIRECTORY: read, write & execute for OWNER, read & execute for GROUP, read & execute for OTHER (0755, rwxr-xr-x)

Both are OK but could be improved with a WARNING that if using a number it should be in octal format.

unix(755) // not what one expects

unix(0755)
unix("755")
unix("rwxr-xr-x")

https://kotlinlang.org/docs/numbers.html#literal-constants-for-numbers

Octal literals are not supported in Kotlin.

Maybe deprecate unix(int)?

This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

At the minimum, the introduced unix(int) should have javadoc calling out this behaviour.
But we should consider if that method is really needed.

The change is not release notes worthy (in my opinion).

A couple of comments about the PR based on which this issue has been closed.
First of all, the problem/concern is not entirely realistic. Anybody who has to deal with UNIX style file permissions should be aware, to some extent at least, of the fact that the int value only makes sense in octal. So we have decided not to completely remove the method.
But, there is indeed some room for improvement, and that's what we did:

we added validation which should catch many of the completely nonsensical inputs, that can be accidentally used
we improved the JavaDoc to make the meaning of the values even clearer


Error

ERROR: Unable to extract uploader id

Same, cannot extract any video with this issue.

Just downloaded youtube-dl for the first time. Using 2021.12.17 (Windows exe), downloaded from here:-
https://ytdl-org.github.io/youtube-dl/download.html
Placed the file in the folder "C:\PROGRA~1\youtube-dl>", and have ensured that is in the PATH.
First usage attempt produces the following output:-
C:\PROGRA~1\youtube-dl>youtube-dl --verbose https://youtu.be/LVhhdMVvwIk
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://youtu.be/LVhhdMVvwIk']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] LVhhdMVvwIk: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 836, in __extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 534, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\youtube.py", line 1794, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 1012, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
One other thing:- I don't recognise the path in the Traceback section of the above output:-
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
etc.
There IS no user on here called "dst", nor a Users folder named that.
But maybe this is not significant. Not sure.

Same problem on a Mac.
~ youtube-dl https://www.youtube.com/watch\?v\=<id> --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.youtube.com/watch?v=<id>', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.10.10 (CPython) - macOS-13.2.1-x86_64-i386-64bit
[debug] exe versions: ffmpeg 5.1.2, ffprobe 5.1.2, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] nrxG4E9NbI0: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.10/site-packages/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.10/site-packages/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.10/site-packages/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.10/site-packages/youtube_dl/extractor/youtube.py", line 1794, in _real_extract
    'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
  File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.10/site-packages/youtube_dl/extractor/common.py", line 1012, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

It's incomplete because OP did not provide the requested information for a bug report.


Re: 'Threat Modelling'

Problem with 'Threat Modelling' (https://gds-way.cloudapps.digital/standards/threat-modelling.html)
The link to OWASP is broken, I think it should now be https://owasp.org/www-community/Threat_Modeling

Thanks for pointing that out, Greg 👍


Latest version published as 0.0.5 even though it's newer than 0.4.0

Description
The latest release was published as version 0.0.5. The version released before it was 0.4.0. As a user, I'd expect this library to follow a consistent versioning strategy like SemVer or similar.

Sorry typo.


confusing with "RemovePodsViolatingInterPodAntiAffinity" strategy

hi:
Just want to make it work and I found that this strategy is not work as my expect.

descheduler version
Descheduler version {Major:0 Minor:4+ GitCommit:d3c2f256852874fdca4682c3c94bc30624979036 GitVersion:v0.4.0 BuildDate:2018-01-10T13:23:09+0800 GoVersion:go1.8.5 Compiler:gc Platform:linux/amd64}

The origin try is as the following steps:

keep only one node schedulable
create a rc
oc run hello --image=openshift/hello-openshift:latest
Create another rc with antiaffinity

affinity:
   podAntiAffinity:
     requiredDuringSchedulingIgnoredDuringExecution:
     - labelSelector:
         matchExpressions:
         - key: key
           operator: In
           values: [“value”]
       topologyKey: kubernetes.io/hostname

wait all pods of rc is running;
label the pod of first rc with
oc label pod <pod_name>  key=value
Setup descheduler and try to evicted pods

Then I found no one pod has been evicted.
Then I go through all the unit test and try to catch a demo for this strategy.
And try to reproduce the test in https://github.com/kubernetes-incubator/descheduler/blob/master/pkg/descheduler/strategies/pod_antiaffinity_test.go
Then the reproduced steps is:
The origin try is as the following steps:

keep only one node schedulable
Create a rc with antiaffinity

affinity:
   podAntiAffinity:
     requiredDuringSchedulingIgnoredDuringExecution:
     - labelSelector:
         matchExpressions:
         - key: key
           operator: In
           values: [“value”]
       topologyKey: kubernetes.io/hostname

Create a rc with the some antiaffinity as step 2
wait all pods of rc is running;
label the pod of first rc with
oc label pod <pod_name>  key=value
Setup descheduler and try to evicted pods

Then I found there is one pod has been evicted.
So here I want to discuss is if only one scenario(in the unit test) is for the strategy.
And why my origin steps can not work? Is it a bug?
Thanks!

/assign

@wjiangjay Are you still seeing the issue? If yes, can you increase debug level and provide logs?

I'm confused too. Either I did not understand core concept, or I failed with configs.
I expect pods will be rescheduled with following configuration rules, but they are not:
❯ kubectl -n fulldive-staging get pod -l app=fulldive-api -o wide                                                         kubernetes/git/NAME                          READY     STATUS    RESTARTS   AGE       IP          NODE
fulldive-api-c97f775c-lgtrl   2/2       Running   0          2h        <IP_ADDRESS>   gke-staging-default-pool-1ec08eb0-7xkq
fulldive-api-c97f775c-nwrcj   2/2       Running   0          2h        <IP_ADDRESS>   gke-staging-default-pool-1ec08eb0-7xkq
fulldive-api-c97f775c-z6z6n   2/2       Running   0          2h        <IP_ADDRESS>   gke-staging-default-pool-1ec08eb0-7xkq

      affinity:
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - weight: 5
            podAffinityTerm:
              topologyKey: "kubernetes.io/hostname"
              labelSelector:
                matchLabels:
                  app: fulldive-api

    apiVersion: descheduler/v1alpha1
    kind: DeschedulerPolicy
    strategies:
      RemovePodsViolatingInterPodAntiAffinity:
        enabled: true

@wjiangjay Are you still seeing the issue? If yes, can you increase debug level and provide logs?

It's not clear for me how to setup log level:

-v, --v Level                          log level for V logs

Any help on this please ?


Investigate CI e2e test issue

See: https://github.com/api3dao/airseeker-v2/actions/runs/6863104836/job/18662177317
But it has happened a few times as well. Re-running doesn't help (at least from my attempts) but amend + force-pushing does. I was not able to reproduce it locally, nor find any relevant information.
We may also remove/merge/update the test if this keeps happening and we are unable to find the reason.

Interesting, the error message can be reproduced by killing Hardhat while the test is running.

I saw this today: https://github.com/NomicFoundation/hardhat/issues/4601


Δa and iteration count in convergence criterion + make calculate_update! mutating

Adds Δa and iteration number to check_convergence_criterion and calculate_convergence_measure.
Additionally (to support this and because good in general), makes calculate_update!(Δa, problem, nlsolver, iter) mutating

Codecov Report

Merging #12 (4215b29) into main (59e522d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   94.52%   94.52%
=======================================
  Files           8        8
  Lines         146      146
=======================================
  Hits          138      138
  Misses          8        8

Impacted Files
Coverage Δ

src/nlsolvers.jl
97.29% <100.00%> (ø)

src/userfunctions.jl
85.71% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


style: add more descriptive copy to the confirm payment screen

Link this PR to an issue
Fixes https://feedback.getalby.com/feature-requests-/posts/suggestions-improve-payment-dialog-ui
Type of change (Remove other not matching type)

Documentation update

Describe the changes you have made in this PR -
A user requested several improvements to the copy on the Confirm Payment screen, so I did the following:

Add 'Approve payment' header to better describe the purpose of this dialog
Add the 'sat' unit to the amount field
Update the 'Confirm' button to say 'Pay now'
I also noticed that the ConfirmOrCancel component had a prop for label but it wasn't being used in the component. So I updated this and it should fix some other instances where people were trying to use this prop.

Screenshots of the changes (If any) -
Before:

After:

How Has This Been Tested?
Tested locally by sending a payment.
Checklist:

[x] My code follows the style guidelines of this project and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

can you update it for the latest changes in master? and also align the make invoice prompt?
this should also get a different button label and we have to make sure that this heading ("approve payment" here) is styled the same there.

can you update it for the latest changes in master? and also align the make invoice prompt? this should also get a different button label and we have to make sure that this heading ("approve payment" here) is styled the same there.

Merged with latest from master, follow up questions:

What do you mean 'align the make invoice prompt'?
The button label 'Pay now' was suggested by a user, do you want to use something different for it?
How do you want the 'Approve payment' heading styled? I thought it was good it have it a bit bigger because it is a heading.

What do you mean 'align the make invoice prompt'?
You changed this component on one place but it is used elsewhere. If you think "Confirm" is problematic then it also might be problematic on other screens. Like for example the prompt for make invoice

The button label 'Pay now' was suggested by a user, do you want to use something different for it?
Because one user said it it does not mean it is good. When changed we should put some thought in it. For example "pay" might not be perfect for donations, or when you send money to a friend?

How do you want the 'Approve payment' heading styled? I thought it was good to have it a bit bigger because it is the main heading.
The make invoice prompt is pretty much the same screen - and probably also other confirmation screens. So this has to be unified and everywhere the same. We can not simply change it one one screen and ignore the rest, then everything will look different and it will also be hard to maintain.

Ok I think we need to decide on the copy first and then I can update all of the other screens, maybe we should bring this up on the next community call and see what people think the buttons and header should say here.

@secondl1ght can you fix the merge conflict and we merge this one.

@bumi merge conflicts resolved.


Bump version to v0.0.22

#650  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on  Graphite


Broken immutability

🐛 Bug Report
When using produce, the original object gets modified. Also, running isDraft on it returns false.
If it's expected behaviour, it would be good to get an error saying that immutability is not achieved. Personal opinion: I didn't expect that the basic functionality of Immer wouldn't work. It took a long time to  find where the issue was.
Link to repro
https://codesandbox.io/s/immer-sandbox-gkypq?file=/src/index.ts
To Reproduce
See the sandbox
Observed behavior
In console:
isDraft(mutableState): false
old state: {"current":{"foodData":[],"day":{"id":8,"ver":2}}}

Expected behavior
In console:
isDraft(mutableState): true
old state: {"current":{"foodData":[],"day":null}}

Environment

Immer version: 5.3.6, 6.0.5
[ ] Occurs with setUseProxies(true)
[ ] Occurs with setUseProxies(false) (ES5 only)

The class definition is missing [immerable] = true;
This still deserves an error, for example: "The object provided to the 'produce' function cannot be kept immutable. Did you forget to add '[immerable] = true' to the class definition?"
I suspect there are reasons for requiring opt-in. Maybe the documentation could explain the reasons? It would have helped me, certainly.

I agree, this should throw an error. Quietly mutating the original object is one hell of a gotcha when the whole point of using produce() is to avoid mutation.

Will be fixed in Immer 7, closing for now


Request for CoreIR compatible with Windows.

If possible, could you implement CoreIR for Windows please? It could remove the hassle of using a VM.

Unfortunately I do not have the bandwidth to work on Windows compatibility in the near future. I would be happy to review a pull request if you or someone else would like to try it out!
Sorry about that.


fix: process is killed on linter warning

Description
A clear and concise description of what the bug is.
I am getting a warning in the console when running dart_frog dev from some of my generated code.
dart_frog dev --verbose

[meta] dart_frog_cli 0.3.1
[codegen] running pre-gen...
⠙ Serving... (82ms)[codegen] running generate...
[codegen] complete.
[process] dart --enable-vm-service .dart_frog/server.dart
✓ Running on http://localhost:8080 (0.1s)
The Dart VM service is listening on http://<IP_ADDRESS>:8181/LKaUCcJtu-M=/
The Dart DevTools debugger and profiler is available at: http://<IP_ADDRESS>:8181/LKaUCcJtu-M=/devtools/#/?uri=ws%3A%2F%2F<IP_ADDRESS>%3A8181%2FLKaUCcJtu-M%3D%2Fws
packages/domain/lib/models/user.g.dart:70:20: Warning: Operand of null-aware operation '!' has type 'String' which excludes null.
          ? _value.id!
                   ^
[process] killing process...
[process] process.kill()...
[process] killing process complete.
[process] exit(1)

Steps To Reproduce

Add dependencies copy_with_extension, copy_with_extension_gen (dev), build_runner (dev)
Create a basic dart object
a. Add the @CopyWith() annotation
b. Add a field final String id
Run build_runner
Run dart_frog dev

Expected Behavior
A clear and concise description of what you expected to happen.
I'd expect for this warning to be omitted. I've added in the analysis_options to exclude generated files from the linter
Screenshots
# analyis_options.yaml

include: package:very_good_analysis/analysis_options.3.1.0.yaml
analyzer:
  exclude:
    - build/**
    - "**/*.g.dart"
linter:
  rules:
    file_names: false

If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.
# pubspec.yaml in `packages/domain`

name: domain
description: A Very Good Project created by Very Good CLI.
version: 0.1.0+1
publish_to: none

environment:
  sdk: ">=2.18.0 <3.0.0"

dependencies:
  autoequal: ^0.5.1
  copy_with_extension: ^5.0.0
  equatable: ^2.0.5
  json_annotation: ^4.7.0

dev_dependencies:
  autoequal_gen: ^0.5.1
  build_runner: ^2.3.3
  copy_with_extension_gen: ^5.0.0
  json_serializable: ^6.5.4
  mocktail: ^0.3.0
  test: ^1.19.2
  very_good_analysis: ^3.1.0

scripts: ../../derry.yaml

Hi @mrgnhnt96 👋
Thanks for opening an issue!
This doesn’t appear to be an issue with Dart Frog. Based on the warning it looks like the generated code for your user model includes an ! when it is unnecessary because the value is not nullable.

Yeah, the code is being generated by a different package, but because of the warning, the process gets killed, which I don't expect.
Its worth noting, if I comment out the CopyWith() annotation, run build_runner, then run dart_frog dev it spin up the server just fine, because the generated code isn't there any more. After the server is spun up, if I un-comment out the CopyWith() annotation, run build_runner, the process does not get killed even though the warning is present

Yeah, the code is being generated by a different package, but because of the warning, the process gets killed, which I don't expect.
Its worth noting, if I comment out the CopyWith() annotation, run build_runner, then run dart_frog dev it spin up the server just fine, because the generated code isn't there any more. After the server is spun up, if I un-comment out the CopyWith() annotation, run build_runner, the process does not get killed even though the warning is present

Yeah Dart Frog exits if there is anything reported to stderr initially. I can try to improve that 👍

After looking into this problem, here are my description of the current situation:
Fact 1:
The VM (started by dart run) prints dart warnings regardless of "ignore" comments and analyzer configuration.
This is an old known issue that can be seen here: https://github.com/dart-lang/sdk/issues/34137 and here: https://github.com/dart-lang/sdk/issues/46264.
These wearing messages are popped from dart run directly to stderr of the running process.
Fact 2:
dart_frog dev starts the server by running dart run under hotreload. The hot reloader runs the server before popping any message communicating the establishment of hot reload successfully.
The process with hot reload forwards the error messages to the process stderr.
Fact 3:
After calling starting the server, dart_frog dev listens for the given process's stderr. Any messages on stderr before a "successful hot reload" kills the process.
That is our problem.
Proposed solution
Considering that we cannot disable these warnings and that the VM can and should pop messages to stderr for problems with higher severity than WARNING (see this file),
We should filter warning messages from stdrrr as criteria for killing the process. The affected logic is here.

To reproduce this issue locally, one should follow OP's steps but lock copy_with_extension to 5.0.0.

Added a quick proposal for fix here: https://github.com/VeryGoodOpenSource/dart_frog/pull/592


instance is unhealthy behind the load balancer and local vault client is unable to connect to it

I'm running the module using the following arguments:
# project configurations
project_id = "<project_id>"
region = "europe-west1"
# KMS configuration
kms_location = "europe-west1"
# storage location
storage_bucket_class = "REGIONAL"
storage_bucket_location = "europe-west1"
# version
vault_version = "1.2.2"

I find myself in the interesting position where, because the instance is unhealthy behind the load balancer, the steps in the readme:
$ export VAULT_ADDR="$(terraform output vault_addr)"
$ export VAULT_CACERT="$(pwd)/ca.crt"
$ vault operator init \
    -recovery-shares 5 \
    -recovery-threshold 3

cannot be executed, because I do not have access to any of the instances outside of the LB.
No worries, I thought. SSH to the rescue, but using the same credentials, I am unable to even get the vault status without getting a 404 of this form:
Error checking seal status: Error making API request.
URL: GET http://<IP_ADDRESS>/v1/sys/seal-status
Code: 404. Raw Message:

<title>404 Not Found</title>

404 Not Found

nginx/1.10.3

Is there some simple step I am missing to be able to perform the vault operator init .. step?

My mistake, a good old destroy and create solved the issue for me. Apologies!


[BUG] OpenAI token exceeded error

I am using the flowise configuration like the image below

Even after sending 1 line message like "Hello, how are you?" it is giving error like,
[ERROR]: [server]: Error: Request failed with status code 400 and body {"error":{"message":"This model's maximum context length is 4097 tokens. However, your messages resulted in 5029 tokens. Please reduce the length of the messages.","type":"invalid_request_error","param":"messages","code":"context_length_exceeded"}}
I think the conversation chain Is doing some things weird.

Try delete the flow, and use the template "Simple Conversationa Chain" from marketplace.
It works fine:

Hi, same error in here. I Try get a "Simple Conversationa Chain" from marketplace too, but not working for me.
`Request failed with status code 400 and body {"error":{"message":"This model's maximum context length is 4097 tokens. However, your messages resulted in 9663 tokens. Please reduce the length of the messages.","type":"invalid_request_error","param":"messages","code":"context_length_exceeded"}}
`

Hi, I the same problem, it was working for some time after deployment but know I am getting this error.

@matheusfterra @Javokhir-1999 one alternate hack I used here to mitigate this situation is using a random value for memorykey parameter of buffer memory.
this actually solved my issue but this is a HACK

I still get this issue both on Buffer Memory and on Dynamo DB Memory.
Hi @atishamte , can you share how you passed in the custom memory key parameter?

or we can use a higher context model like gpt3.5-16k

@pellicceama I am using API to call these as we are not using flowise UI for the operation. So everytime I call the API, we are using UUID as a random key

Me too! I tried this without much success.
overrideConfig: {..., inputKey: ${randomUUID}}} without
How do you currently pass the UUID as a random key?

yes, but use it for memorykey

Same issue, please fix this. Makes it unusable.


Feature Request: Be able to draw cleaning paths

At the moment the fleet adapters are using a somewhat roundabout strategy to inform the fleet adapter about where and how robots can perform cleaning tasks. It would be nice if we could incorporate that information directly into the nav graph yaml file, drawn and exported using the traffic editor.
I imagine we'd want to add these features:

Create a new type of nav graph entries parallel to lanes and vertices, maybe call it paths
Give each paths element a sequence of vertices that don't (necessarily) exist on the nav graph
Give the paths elements attributes/tags, similar to what we do for vertices

Maybe this could be a format to consider:
paths:
- name: my_clean_path
  enter_from: [3, 7, ... ]
  path: [ [10.12, -17.43], [11.12, -17.43], ... ]
  attributes:
    clean:
      zone: zone_1
      types: ['vacuum', 'mop']

@Yadunund might be interested in this topic.

This would be very useful 😃


Could not find stored procedure 'sp_executesql' for Synapse connections

Issue Type: Bug
I know it is there on Synapse as I have run this in SSMS
So either Data Studio doesn't understand it, or is is a missing plugin.
DECLARE @delete_from_table NVARCHAR(200)
SELECT @delete_from_table= 'sometable'
DECLARE @command NVARCHAR(150)
SET @command = 'DELETE FROM ' + @destinationSchemaTable
IF(@debug = 1) BEGIN
PRINT @command;
END
EXEC sp_executesql @command;
Azure Data Studio version: azuredatastudio 1.29.0 (0f5cfdc2c8c2433028842e16dc5ac1a65da24292, 2021-05-15T01:12:11.112Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.81GB (16.54GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Are you saying that you're getting an actual error message in the results tab when running this query? Or is it just highlighting the procedure with the red squigglies as being invalid? If you could provide a screenshot of the error that'd be great.


recipientCount property has an incorrect definition.

Definitions with an x-ds-definition-name value of "recipients" have an incorrect description for the recipientCount field.
It is currently read
"description": "The list of recipient event statuses that will trigger Connect to send updates to the url. It can be a two-part list with:\n\n* recipientEventStatusCode - The recipient status, this can be Sent, Delivered, Completed, Declined, AuthenticationFailed, and AutoResponded.\n* includeDocuments - When set to **true**, the envelope time zone information is included in the message.",
`
The field appears to be a read-only count of all recipients.

Hi @jfcote87 ,
Sorry for this extremely slow response to your issue. I was not being notified of new issues on this repo. I've fixed that.
Re: recipientCount property -- is this still a current issue? If so, I will submit a ticket to our engineering group.
Thanks,
Larry

This error still exists in the current swagger definition.

Thank you, I have submitted bug report DEVDOCS-1259


pub serve should detect changes to pubspec.yaml

Changing the pubspec should practically trigger a restart of barback and recompute anything that's needed.
See issue #19207 for an example: a user creates a file, creates a transform section in the pubspec, later decides to rename the file and update the corresponding section in the pubspec.

This issue has been moved to dart-lang/pub#1003.


Copy all code feature

Feature
Add the ability to copy all the code in the diffView component. The feature will make reviewing code easier, since running the code locally will be faster.
Example
UI: a button on the opposite side of the diffView title (e.g., js1/4.js)
js1/4.js ---------------------------------------------------------------- [BUTTON]
[------------------------------------- CODE -------------------------------------]
Code
Something like this would work:
const newValue = props.newValue;
//...
<Button
  onClick={() => navigator.clipboard.writeText(newValue)}
>
Copy
</Button>

Solved issues
Besides making it easy for the reviewer to paste the code into the code editor, copying Show Converstation text by accident will also be solved.

Might be closed for https://github.com/garageScript/c0d3-app/issues/1418, but being able to copy each file individually is another nice feature to have.


fix: add back ITS address

looks like this got removed accidentally in the last PR

No additional input is required here. The service automatically fetches the address information from the config.


Bump version, update about section

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Please update conda-smithy to 2.3.3 and then re-render.

The 're-add' already re-rendered it. Re-render with 2.3.3 reported no changes.


Make tox.ini conform to 4.0.0 release requirements

Description
Closes #228
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

Do we need backports?


Updates

greenkeeper updates, changelog fixes, additional dependencies

 All committers of the pull request should sign our Contributor License Agreement in order to get your pull request merged.1 out of 2 committers have signed the CLA.:white_check_mark: victoriafrench:x: greenkeeperio-bot


Several bugs and focus features ...

Hey,
there's no possibility to focus a select2 element. In some usecases we have to be able to do so for example select2 loses focus after selection in internet explorer 11 .. so tabindex is destroyed. Please add this feature. There are several bugs. For example the token separators !always! logs warnings / errors to the browser console. Another problem is that the clearAll action logs errors when no placeholder is defined. Also it would be a nice feature to set a custom message for to much results when a remote service is used. Another bug: You cant set selected values when there is no option for it in the select element. In single select elements the clear all is also buggy. If i use the clear all on single select the value will be cleared. Ok well thats nice but the option for it is still selected in the results and this causes that you cant select that value again! The amd custom translations are badly documentated and cause of that i had to use a own webservice. All in all select2 is unstable. I dont understand how you can release that code with that much bugs. Please test your component before the release next time lost a lot of money and time cause of workarounds :).

Hi, thanks for the bug reports! It's typically recommended to report a single bug in a report, so we can focus on individual tickets and log their status without having to worry about missing reports.

there's no possibility to focus a select2 element

Duplicate of https://github.com/select2/select2/issues/3152 / https://github.com/select2/select2/issues/1908

For example the token separators !always! logs warnings / errors to the browser console.

Probably related to https://github.com/select2/select2/issues/3593

Another problem is that the clearAll action logs errors when no placeholder is defined.

placeholder is required with allowClear, see https://github.com/select2/select2/issues/3016

You cant set selected values when there is no option for it in the select element.

This isn't something we can fix.

Ok well thats nice but the option for it is still selected in the results and this causes that you cant select that value again!

I wasn't able to reproduce this issue, but I suspect it's related to the earlier issue with placeholders.

The amd custom translations are badly documentated and cause of that i had to use a own webservice.

We are looking to improve the documentation here (as well as pretty much everywhere else) in the future.

@kevin-brown

Ok well thats nice but the option for it is still selected in the results and this causes that you cant > > select that value again!

This issue is caused through the value that is still selected in the options. It shouldn't selected anymore after clearing is that right? FYI: This affects only to single selection mode.

It shouldn't selected anymore after clearing is that right?

The option that should be selected after hitting the "clear" (x) icon is the placeholder. The UI should visually update to show the placeholder being selected.
You can see an example of this in the placeholder examples: http://select2.github.io/examples.html#placeholders

@kevin-brown
Yes thats right and it works but if i search for a value again and i want to select the same like before -> it isn't possible because it is still selected in the options from the select element which is hidden.


Ingress gets treated as a router

Do you want to request a feature or report a bug?

Bug

What did you do?
I have a kubernetes cluster on which we are testing the upgrade to Traefik 2.0.
We upgraded the config of Traefik to 2.0, switched the image and the containers start normally.

What did you expect to see?

Upgrade the config
Ingresses work just like before
Profit

What did you see instead?
Somehow in the logs I can see that internally Traefik tries to convert ingress-objects to routers, middlewares and services?
Logentries like this come up:
level=debug msg="No entryPoint defined for this router, using the default one(s) instead: [metrics ping web websecure]" routerName=someingress@kubernetes
Creating middleware" routerName=someingress@kubernetes serviceName=someingresssvc-http middlewareName=pipelining middlewareType=Pipelining entryPointName=websecure

The logs look like ingresses actually are received by Traefik but than handled as routers, which does not work at all, because Traefik does not know which endpoints it should connect the ingresses to.
The question is, why does this happen?
I expected the application traffic to just get routed to the containers like before when using ingress.
Output of traefik version: (What version of Traefik are you using?)

Traefik version 2.0.5

What is your environment & configuration (arguments, toml, provider, platform, ...)?
log:
  level: DEBUG
providers:
  kubernetesIngress: {}
entryPoints:
  ping:
    address: ":9090"
  web:
    address: ":80"
  websecure:
    address: ":443"
  metrics:
    address: ":7070"
ping:
  entryPoint: "ping"
metrics:
  prometheus:
    entryPoint: metrics
api:
  dashboard: true
tls:
  stores:
    default:
      defaultCertificate: (this setting gets ignored by the way)
        certFile: /tls.crt
        keyFile: /tls.key
http:
  routers:
    api:
      rule: Host(`some.host.com`)
      entrypoints:
        - websecure
      service: api@internal
      middlewares:
        - auth
      tls: {}
  middlewares:
    auth:
      basicAuth:
        users:
          - 'foo:bar'

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)

Hi @Furragen , can you check the migration guide at https://docs.traefik.io/v2.0/migration/v1-to-v2/ and switch to the community forum at https://community.containo.us/ where the discussion can take place please?
This issue is not considered as a bug, since Traefik v2.0 supports for Kubernetes Ingress is minimalistic as explained in the documentation: you have to switch to the new CRD IngressRoute instead.
By the way, the "router", "entrypoints" and "service" concepts are Traefik objects, so any "Ingress" or "IngressRoute" Kubernetes Objects is mapped by Traefik to its internal concepts: it is the same as any other Ingress controllers (Nginx converts "Ingress" to "vhosts" and "server" for instance).

Hi @dduportal ,
I checked that guide and while reading the rest of the docs got the impression that ingress is still very much supported and I could just switch over to 2.0 if I updated the config.
And since Traefik is an ingress-controller I very much think that this is a bug if ingress is not really supported anymore. I mean this basically prevents anyone using your ingress-controller from using any 3rd-party helm-chart.
Also, how should I use ingress now if I can't really tell traefik which endpoint should be used for an ingress? Because at the moment it just randomly assigns endpoints to ingress.

Duplicate of #5624

This is not a duplicate.
I just added in my last sentence a point that was made in another issue.

This issue is not considered as a bug, since Traefik v2.0 supports for Kubernetes Ingress is minimalist as explained in the documentation: you have to switch to the new CRD IngressRoute instead.

Traefik v2 support Ingress, but v2 doesn't support any annotations on Ingress.

But only one Ingress works.
And judging by the logs it works only because Traefik randomly decided to give map it to the right entrypoint.
Which leads me to think that ingress is actually not really supported anymore since you do not have control about where the traffic is routed.

Hi @Furragen can you switch the discussion to the community forum to get the most of the community answers and help please? Don't hesitate to mention me in the forum :)


Strange issue with Fish shell and Neovim

Issue occurs on Mac OS.
Issue - Disclaimer : )
I realize this may not be Alacritty's fault, I'm simply trying to narrow down my options. That being said, I'm starting here because I only notice this while using Alacritty.
Issue - You should know...
I have Fish set as shell for Alacritty within alacritty.yml and for Neovim within init.vim:
Issue - What happens...
If I launch neovim from fish, then quit Alacritty, I can no longer open neovim.
Issue - Step by step

I launch Alacritty
I type nvim
I quit Alacritty
I relaunch Alacritty
I type nvim
just hangs... ultimately pressing ctrl-c to kill it

Issue - Additional details
After the above step by step, neovim won't work in iterm or terminal.
Also bash and zsh won't work either.
Issue - Temp solution
I have to restart my machine. : (
I'll be creating an issue on Fish repo as well but, thought to start there.
I'd really appreciate any help, thanks.

I understand that you close Alacritty while nvim is still running?
Can you get a trace of the hanging session using strace -f alacritty -e bash exit 2>alacritty.log ? A new alacritty-windows should pop up briefly and immediately close again, given that it does not in fact hang; kill it with fire if it does.

That is correct.
I'm getting strace command not found.. I'm on mac os, is there a dtrace alternative maybe..?

I think I fixed it...
I did:
$ brew uninstall neovim
$ brew cleanup
$ brew update
$ brew install --verbose --build-from-source neovim

and I'm not seeing the issue anymore... hmmm weird...

nope. Issue still exists upon restart.

As I've continued to test, this occurs in all terminal emulators, creating issue in Neovim issues here: https://github.com/neovim/neovim/issues/7300

Thanks for chasing that down and determining it wasn't an Alacritty issue :D.

Np! : )


prep to use sqlalchemy as a drop-in replacement for pymongo

I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/omegaml/omegaml/pull/231
It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.


Implement shared randomness

What's the best approach to implement shared randomness? It will be used to elect the leader for async fallback, and chained-VABA.

Do you mean the above protocol needs fresh key pairs for every fallback? If yes, I would prefer randomness based on BLS signatures with a trusted setup, since it is not clear to me who should be responsible to generate the fresh key pairs for every fallback.
There are existing lib for threshold sig that we can use: https://github.com/poanetwork/threshold_crypto
Does it look good to you?

Do you mean the above protocol needs fresh key pairs for every fallback?

exactly

There are existing lib for threshold sig that we can use: https://github.com/poanetwork/threshold_crypto
Does it look good to you?

Looks good to me, let's go for it


Optimize  seek_write in prewrite

What have you changed?
I'm try to optimize check conflict of prewrite by ScanMode::Forward. If there are many keys to be inserted, they must not exist in CF_WRITE, so we could seek once , and skip seeking others.
What is the type of the changes?
Pick one of the following and delete the others:

Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect tidb-ansible?
No

/test

/test

/test

@MyonKeminta  PTAL

/bench

@youjiali1995  @MyonKeminta  Any more comments?

/bench

/test

/test

Sorry. I and @MyonKeminta are a little busy.

/bench
workload:
  threads: 1024

how about sysbench prepare?

@siddontang It makes no difference to the performance of sysbench prepare with default config (because it costs too much time to wait for latch), but  reduce 25% CPU (from 880% to 630%).

but reduce 25% CPU (from 880% to 630%).

it is great too @Little-Wallace

/test

/test


feature: Help finding the meaning of life.

I thought I'd add this important feature.

Has this been deployed?
I am such a geek for getting excited about this, towel in hand.

Yes.


Problem

If you remove the prefix, the AI responds itself

@Fesantt Thank you for reaching out. can you describe this issue in detail be provide some screenshots or video that demonstrates the bug


Override Value.splitterator() and Traversable.splitterator()

With #1622 we added Value.toParallelStream(). To get the most out of it, we need to return a splitterator that reflect the characteristics of the underlying Value.
The are these Splitterator characteristics:

CONCURRENT- Characteristic value signifying that the element source may be safely concurrently modified (allowing additions, replacements, and/or removals) by multiple threads without external synchronization.
DISTINCT - Characteristic value signifying that, for each pair of encountered elements x, y, !x.equals(y).
IMMUTABLE - Characteristic value signifying that the element source cannot be structurally modified; that is, elements cannot be added, replaced, or removed, so such changes cannot occur during traversal.
NONNULL - Characteristic value signifying that the source guarantees that encountered elements will not be null.
ORDERED - Characteristic value signifying that an encounter order is defined for elements.
SIZED - Characteristic value signifying that the value returned from estimateSize() prior to traversal or splitting represents a finite size that, in the absence of structural source modification, represents an exact count of the number of elements that would be encountered by a complete traversal.
SORTED - Characteristic value signifying that encounter order follows a defined sort order.
SUBSIZED - Characteristic value signifying that all Spliterators resulting from trySplit() will be both SIZED and SUBSIZED.

We have two cases:
1) Value is single-valued (Option, Try, Lazy, Future, ...)
2) Value is multi-valued (all Traversables ...)

All types can contain null (including Option.Some), so no type has the characteristic:

NONNULL

Because we have persistent types, these characteristics apply to both cases:

CONCURRENT
IMMUTABLE

The single-valued types have these characteristics:

DISTINCT
SIZED
SUBSIZED

The multi-valued types have the following characteristics (in addition to the common as described above):

Array - SIZED, SUBSIZED
BitSet - DISTINCT, ORDERED, SIZED, SORTED, SUBSIZED
CharSeq - ORDERED, SIZED, SUBSIZED
HashMap -

key/values: DISTINCT, SIZED, SUBSIZED
values: SIZED, SUBSIZED

HashMultimap -

key/values: DISTINCT, SIZED, SUBSIZED
values: SIZED, SUBSIZED

HashSet - DISTINCT, SIZED, SUBSIZED
Iterator - (??? none because may be infinite or SIZED/SUBSIZED because when it is infinite program will hang though)
LinkedHashMap -

key/values: DISTINCT, SIZED, SUBSIZED
values: SIZED, SUBSIZED

LinkedHashMultimap -

key/values: DISTINCT, SIZED, SUBSIZED
values: SIZED, SUBSIZED

LinkedHashSet - DISTINCT, SIZED, SUBSIZED
List - SIZED, SUBSIZED
PriorityQueue - ORDERED, SIZED, SORTED, SUBSIZED
Queue - SIZED, SUBSIZED
Stream - (??? none because may be infinite or SIZED/SUBSIZED because when it is infinite program will hang though)
Tree - SIZED, SUBSIZED
TreeMap -

key/values: DISTINCT, ORDERED, SIZED, SORTED, SUBSIZED
values: SIZED, SUBSIZED

TreeMultimap -

key/values: DISTINCT, ORDERED, SIZED, SORTED, SUBSIZED
values: SIZED, SUBSIZED

TreeSet - DISTINCT, ORDERED, SIZED, SORTED, SUBSIZED

We just override Traversable.splitterator(). It will gather all characteristics from the new introspection methods that will be implemented by the Traversable implementations listed above:

isDistinct() - which implies DISTINCT. It reflects the characteristics of the Traversable and has nothing to do with the contained elements, e.g. List(1, 2, 3).isDistinct() returns false.
isOrdered() - which implies ORDERED and SORTED. It means 'has a comparator'

We already have these:

hasDefiniteSize() - which implies SIZED and SUBSIZED
isTraversableAgain() - not needed for characteristics(), yet

Hi! If I understand CONCURRENT description right neither of our cases apply for this characteristics, because we have immutable types. Am I right?

Hi, you are right. I've re-read the specs and CONCURRENT makes no sense when a collection is IMMUTABLE. Thank you!

@danieldietrich Could I also ask you what do you mean by separating characteristics for key/values and values for maps?
How I understand as our Map implement Traversable<Tuple2<K, V>> we will have Splititerator<Tuple<K, V>> and characteristics for this spliterator we could from introspection methods.
Also how I understand if we want to take spliterator for the values, we will do it like that:
map.values().spliterator();

But in this case, unfortunately, we can't have SIZED and SUBSIZED characteristics, because we return Seq from values() and this class doesn't have fixed size.
I've already written some code, and I can create PR to see if I'm going to the right direction.

@v1ctor

How I understand as our Map implement Traversable<Tuple2<K, V>> we will have Splititerator<Tuple<K, V>> and characteristics for this spliterator we could from introspection methods.

Yes, absolutely right!

But in this case, unfortunately, we can't have SIZED and SUBSIZED characteristics, because we return Seq from values() and this class doesn't have fixed size.

We don't have to think about this case. The Spliterator of the returned Seq implementation will manage its own characteristics (by introspection). It is all right.


Fix issue - import non-existent file

Hi :smile: ,
I've remove the code that import non-existent file, please review.

There was a different issue causing this error, see my closing comment in #7040.


Use recommended changes from containing APIs

When looking for recommended changes at the member level, API port should fall back to the recommended changes at the chain of containing types, up to, and including the namespaces.
This makes it a lot easier for us to have a complete list of recommendations without having to add them to each and every member.
So when looking for recommendations of  System.Runtime.Awesome.Type.Subtype.Member, it should probe in the following order:

M:System.Runtime.Awesome.Type.Subtype.Member
T:System.Runtime.Awesome.Type.Subtype
T:System.Runtime.Awesome.Type
N:System.Runtime.Awesome
N:System.Runtime
N:System

Nice idea.

Excellent. Thanks!


 I've installed twinny with VS code and have the chat interface working; however, the code autosuggest (fill in the middle) is not activating.

Describe the bug
Reiterating: This may be my misunderstanding rather than a bug.
I can get twinny to respond to my questions in the chat interface within VSCode; however, nothing triggers via autosuggest as I write code. I verified that I have the two prerequisite models that are supported (screenshot below) but don't know how to ensure both are running -- without collision -- and respond to Twinny at its preconfigured URLs.

Questions:
a) Is it expected for me to have to explicitly run the ollama model(s) before Twinny initializes?
b) How do I spawn Ollama to serve both models at URLs without colliding so that Twinny can reach them both? I've checked the configuration and it appears there is a root url (http://localhost), path (/api/generate) and port (11434) as seen here.

Perhaps expected: after terminating the terminal session that was running $ollama run codellama the Twinny chat stopped responding. I then executed both ollama $run codellama:7b-code as well as $run codellama:7b-instruct concurrently but that did not activate the chat or autosuggest within VS Code. Shutting down VSCode didn't help either.
It appears the only feature I have is chat and will only work if (pre) spawn $ollama run codellama. Do I have it corect that doing so spawns the default codellama (latest) model rather than the fine tuned models for chat and autosuggest. Is this correct?
To Reproduce
Steps to reproduce the behavior:

Spawn VS Code with my sample project; or any for that matter.
Spawn ollama model(s); e.g. 'ollama run codellama'
Click on the Twinny Extension
Type in a question: 'write an email regex matcher function for validation`
Open a typescript file and type in the following `const adder = (op1: number, op2: number): number => op1 + op2;

Expected behavior
Along with the Twinny chat interface, I also expect autosuggest to activate and display code suggestions as I type in code.
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: OSX Sonoma 14.2.1 (23C71)
Browser [e.g. chrome, safari]: chrome but not relevant for this filing.
Version: Twinny version: v3.3.0
VSCode: version 1.85.2

Smartphone (please complete the following information):

Device: N/A
OS: [N/A
Browser N/A
Version N/A

Additional context

Resolving: My mistake.
The TLDR;
My ollama server must have crashed hard and caused the side effects. I rebooted and was able to run ollama $run codellama:7b-code as well as $run codellama:7b-instruct concurrently and saw that Twinny is working great.

Without updating Twinny or its settings, Ollama, or VS Code, my integration for chat and code completion has suddently stoppped working.
I have verified that the robot head icon is visible in the bottom right of the VS Code tray that indicates Twinny is activated. Despite this, Twinny is not responding with any answers in the chat and just animates a spinning cursor. The code completion has stopped suggesting as well.
At one point the Twinny extension seeemed to auto spawn something or to load the models but it doesn't seem to do that anymore.
What are the commands I must run manually in the shell to help Twinny along?

The endpoint is wrong. Please use Ollama OpenAI chat endpoint. /v1/chat/completions

@rjmacarthy: I appreciate the response. Reinstalling and restarting ollama fixed my problems. Thank you & closing issue.


feat: add Menu Icons variation

API Proposal
This API extends the Menu component
icon

  <Menu icon>
      <Menu.Item name='gamepad' active={activeItem === 'gamepad'} onClick={this.handleItemClick}>
          <Icon name='gamepad' />
      </Menu.Item>

      <Menu.Item
          name='video camera'
          active={activeItem === 'video camera'}
          onClick={this.handleItemClick}
      >
          <Icon name='video camera' />
      </Menu.Item>

      <Menu.Item
          name='video play'
          active={activeItem === 'video play'}
          onClick={this.handleItemClick}
      >
          <Icon name='video play' />
      </Menu.Item>
  </Menu>

Note, our use cases for the icon menu should be styled a bit differently.  There is no background, shadows, or borders:

In this case, a background color matching the message is applied to the menu to occlude the timestamp:

Also with a white background:

There was some discussion in the Icon component about adding a background prop to handle these kind of cases.  See #86.  We could either allow the icons in the screenshots above to take on a background color, or pass it through the Menu.

what I do see as a solution here is to allow merged variables to be consumed inside renderComponent() method. Currently we are passing, essentially, only class names there (if we would speak about visual aspects). With that this problem seems to be easily solvable:
class ChatMessage extends UIComponent {
   ...
   // note that 'variables' are merged ones
   renderComponent({ classNames, variables } => (
     <Menu variables={background: variables.background}>
     ...
    </Menu>
  ))
}

This mechanism is explicit, easy to debug and, to my mind, is able to accomplish the tasks you've mentioned. @levithomason, please, let me know what do you think?

Done in stardust-ui/react/pull/73


Fix func tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 63.379%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
9756

Relevant Lines:
15393

💛  - Coveralls


Add condition to AfterBuild target to unbreak nCrunch

NCrunch doesn't run well with the target that is generated with some projects.
Adding a condition to the target disable it when running under ncrunch, avoiding to break compilation.

@thinkbeforecoding could you add a failing (without the change) integration test as well?
Thanks!

there is actually already a broken test. so @thinkbeforecoding can you please try to fix that one?

I'm discovering the IntegrationTests so I'll try to see where it breaks

I'm already on it
On Jun 16, 2016 4:42 PM, "Jérémie Chassaing"<EMAIL_ADDRESS>wrote:

I'm discovering the IntegrationTests so I'll try to see where it breaks
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/1734#issuecomment-226506256,
or mute the thread
https://github.com/notifications/unsubscribe/AADgNAhbIONr1W_4jZ_LOvFe5qsyjiM_ks5qMWDSgaJpZM4I3XZo
.

I think it's in a test where the condition has been added and the test verify equality with exising project. The project should then be updated.


Suggestion for new section in README

To make Vue.js more approachable to a larger number of users—from informed developers to curious passersby and new and interested visitors— and help them decide whether Vue.js will fit their needs more quickly, I have added a new section to the Vue.js README.
The section is entitled What to Use Vue.js for and When to Use It. As the name suggests, the new section, a brief paragraph, explains in plain and straightforward language what Vue.js is used for and when one should consider using Vue.js.

Hi @brentguf , thanks a lot for this PR - please see https://github.com/vuejs/vue/pull/2303#issuecomment-180528160 for an explanation - the README is intentionally kept short.


Compress-Archive creates a strange directory entry for certain file system configurations

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Sometimes, Compress-Archive creates a weird directory-like entry in the produced archive. The details I was able to find:

only in 2nd-level nested directory
if said directory contains no files (i.e. is empty or only nested directories)
Compress-Archive will create a ZIP entry called <yourDirectoryName>/ not marked as directory according to the output of zipinfo

So, exact steps to reproduce:
$ md playground/pt/fspt/d
$ echo xxx >> playground/pt/fspt/d/file.txt
$ Compress-Archive playground/* -DestinationPath 'file.zip' -Force

Now, examine the resulting archive using zipinfo (I wasn't able to quickly find a zipinfo distribution for Windows, so installed sudo apt install unzip on my Ubuntu into WSL):
$ zipinfo file.zip
Archive:  file.zip
Zip file size: 233 bytes, number of entries: 2
-rw----     2.0 fat        0 b- stor 22-Dec-07 20:56 pt/fspt/
-rw----     2.0 fat        5 b- defN 22-Dec-07 20:56 pt/fspt/d/file.txt
2 files, 5 bytes uncompressed, 7 bytes compressed:  -40.0%

The weird path is the first entry:
-rw----     2.0 fat        0 b- stor 22-Dec-07 20:56 pt/fspt/

Notably, the weird entry goes away if I create a file in directory pt/fspt:
$ echo 123 >> playground/pt/fspt/111.txt
$ Compress-Archive playground/* -DestinationPath 'file.zip' -force && wsl -d Ubuntu zipinfo file.zip
Archive:  file.zip
Zip file size: 254 bytes, number of entries: 2
-rw----     2.0 fat        5 b- defN 22-Dec-07 21:15 pt/fspt/111.txt
-rw----     2.0 fat        5 b- defN 22-Dec-07 20:56 pt/fspt/d/file.txt
2 files, 10 bytes uncompressed, 14 bytes compressed:  -40.0%

I've seen two kinds of other archives:

The ones that contain no directory entries at all.
The ones that contain directory entries with drwxr-xr-x flags instead of -rw----.

At the same time, [System.IO.Compression.ZipFile]::CreateFromDirectory works well:
$ [System.IO.Compression.ZipFile]::CreateFromDirectory($(Resolve-Path playground), "$(Resolve-Path '.')/file2.zip")

$ zipinfo file2.zip
Archive:  file2.zip
Zip file size: 141 bytes, number of entries: 1
-rw----     2.0 fat        5 b- defN 22-Dec-07 20:56 pt/fspt/d/file.txt
1 file, 5 bytes uncompressed, 7 bytes compressed:  -40.0%

So, System.IO.Compression.ZipFile]::CreateFromDirectory doesn't have this problem.
For empty directory, it will still create an entry with -rw---- flags, though, so it is not without problems.
Expected behavior
I'd say that Compress-Archive should work the same way as System.IO.Compression.ZipFile]::CreateFromDirectory.
Actual behavior
Compress-Archive behaves differently from System.IO.Compression.ZipFile]::CreateFromDirectory, and in a very strange way that is.
Environment data
The issue reproduces in both Windows PowerShell 5.1 and PowerShell 7.3.
# pwsh 7.3
Name                           Value
----                           -----
PSVersion                      7.3.0
PSEdition                      Core
GitCommitId                    7.3.0
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

# powershell 5
Name                           Value
----                           -----
PSVersion                      5.1.22000.832
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22000.832
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

If your definition of "correct" is "whatever 7zip works with", then yes, it is correct.
It is not correct w.r.t. every interop scenario, though.
In particular, java.util.zip.ZipEntry::isDirectory has problems with such an archive: it reports directory entries to be files, which breaks things.
Though, after taking a closer look, I see that it only has problems with an archive created by Windows PowerShell 5.1, not PowerShell 7.3: it's the kind of the final slash that turns out to be important for it. Not the flags reported by zipinfo.


chore: go-demo-6 to 1.0.374

chore: Promote go-demo-6 to version 1.0.374

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmx-bji: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
7814e9fbd876e62ed93d1dee19561fbca44854bd
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


add: Divanshi Goyal

Description

Related Issues

Changes Proposed

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

Hi @divanshiii09 , thanks for your interest in contributing to DevDisplay!
We noticed you adding your profile on #DevDisplay but forgot to star the repo. It's like making an amazing sandwich and forgetting to take a bite! -- I think our repo's feeling a little lonely without your 🤗 So, be sure to star the DevDisplay GitHub Repository. 🌟
💌 This is a mandatory step for all contributors. & It's is the first priority of contribution in DevDisplay 💌
Thanks 👍🏻


chore(deps): update terraform terraform-ibm-modules/cos/ibm to v8.13.1

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
patch
8.13.0 -> 8.13.1

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.13.1
Compare Source
Bug Fixes

deps: update terraform-module (#739) (b58ba8e)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.28.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Footer position(Top/Bottom/Both) feature

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
There is one PR #751 for this.
Footer(Pagination with summary) display at the end of the table only.
What is the new behavior?
PR #751 will be solved.
Footer(Pagination with summary) display is now configurable with the following options for footerPosition input varaible
1.bottom 2. top 3. both
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

So i grabbed your branch and made a few updates. https://github.com/swimlane/ngx-datatable/tree/madhuinwiter-footer-position-feature
I'm leaning towards going a step further by making the header totally customizable that way you could implement your own header and pager in there in whatever combination you like. Is this something you'd like to take on?

@amcdnl Exactly. Thank you.

Hi.
After all this time this isn't merged and released. Is it ever going to be released?
Thanks.

Hi,
Is this feature already in the current version or is it still not released ?


Conditioning on Segmentation Maps

Hello, great work!
I was wondering whether you thougth about conditioning on the image segmentation maps (generated with some algorithm on NuScenes images).
Because I am not quite sure, I would expect segmentation maps have more information about the shapes of the scene/objects compared to 3d bboxes + class, but maybe it is not the case if you already considering and discraded it.
Thank you!!

It is possible and you can search for many excellent works on that application. Since segmentation maps are 2D, for instance, controlnet can already support this. In this paper, we only consider 3D controls. Thanks.


misc tweaks

Minor improvements to benchmark.py (will need for the upcoming tutorial)
Better core.autotuning
Better configuration system
More env vars supported to drive YASK performance tuning
Less verbose default logger. Now you'll see DSE/DLE output reports only if logging level = DEBUG

Green => merging

Merged.


"Cuza Vodă" is listed in the drop-down menu

Description:
"Cuza Vodă" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Cuza Vodă" in the search bar.

Expected results
The location is listed in the drop-down menu as "Cuza Vodă, Brăila (Stăncuța)".


amplify init: -unauthRole doesn't exist

Describe the bug
Running "amplify init" results in this error:
Template error: IAM role ampstarter-20181025120808-unauthRole doesn't exist.
amplify --version
0.1.29
region
us-east-1
To Reproduce
Steps to reproduce the behaviour:

npx create-react-app ampstarter

cd ampstarter

amplify init
settings:

Choose your default editor: Visual Studio Code
Choose the type of app that you're building javascript
Please tell us about your project
What javascript framework are you using react
Source Directory Path:  src
Distribution Directory Path: build
Build Command:  npm run-script build
Start Command: npm run-script start
Do you want to use an AWS profile? Yes
Please choose the profile you want to use default
Using default provider awscloudformation

see output log below

Desktop:

OS: macOS High Sierra 10.13.6

Log
⠏ Initializing project in the cloud...
CREATE_IN_PROGRESS ampstarter-20181025120808 AWS::CloudFormation::Stack Thu Oct 25 2018 12:08:08 GMT-0400 (Eastern Daylight Time) User Initiated
CREATE_IN_PROGRESS UnauthRole                AWS::IAM::Role             Thu Oct 25 2018 12:08:12 GMT-0400 (Eastern Daylight Time)
CREATE_IN_PROGRESS AuthRole                  AWS::IAM::Role             Thu Oct 25 2018 12:08:12 GMT-0400 (Eastern Daylight Time)
CREATE_IN_PROGRESS UnauthRole                AWS::IAM::Role             Thu Oct 25 2018 12:08:12 GMT-0400 (Eastern Daylight Time) Resource creation Initiated
CREATE_IN_PROGRESS AuthRole                  AWS::IAM::Role             Thu Oct 25 2018 12:08:13 GMT-0400 (Eastern Daylight Time) Resource creation Initiated
CREATE_IN_PROGRESS DeploymentBucket          AWS::S3::Bucket            Thu Oct 25 2018 12:08:13 GMT-0400 (Eastern Daylight Time)
CREATE_IN_PROGRESS DeploymentBucket          AWS::S3::Bucket            Thu Oct 25 2018 12:08:14 GMT-0400 (Eastern Daylight Time) Resource creation Initiated
⠼ Initializing project in the cloud...
CREATE_COMPLETE AuthRole   AWS::IAM::Role Thu Oct 25 2018 12:08:25 GMT-0400 (Eastern Daylight Time)
CREATE_COMPLETE UnauthRole AWS::IAM::Role Thu Oct 25 2018 12:08:26 GMT-0400 (Eastern Daylight Time)
⠦ Initializing project in the cloud...
CREATE_COMPLETE      DeploymentBucket          AWS::S3::Bucket            Thu Oct 25 2018 12:08:34 GMT-0400 (Eastern Daylight Time)
ROLLBACK_IN_PROGRESS ampstarter-20181025120808 AWS::CloudFormation::Stack Thu Oct 25 2018 12:08:36 GMT-0400 (Eastern Daylight Time) Template error: IAM role ampstarter-20181025120808-unauthRole doesn't exist. Rollback requested by user.
⠧ Initializing project in the cloud...
DELETE_IN_PROGRESS UnauthRole       AWS::IAM::Role  Thu Oct 25 2018 12:08:46 GMT-0400 (Eastern Daylight Time)
DELETE_IN_PROGRESS AuthRole         AWS::IAM::Role  Thu Oct 25 2018 12:08:46 GMT-0400 (Eastern Daylight Time)
DELETE_SKIPPED     DeploymentBucket AWS::S3::Bucket Thu Oct 25 2018 12:08:46 GMT-0400 (Eastern Daylight Time)
DELETE_COMPLETE    UnauthRole       AWS::IAM::Role  Thu Oct 25 2018 12:08:47 GMT-0400 (Eastern Daylight Time)
DELETE_COMPLETE    AuthRole         AWS::IAM::Role  Thu Oct 25 2018 12:08:47 GMT-0400 (Eastern Daylight Time)
⠦ Initializing project in the cloud...
ROLLBACK_COMPLETE ampstarter-20181025120808 AWS::CloudFormation::Stack Thu Oct 25 2018 12:08:49 GMT-0400 (Eastern Daylight Time)
⠴ Initializing project in the cloud...An error occurred when  creating the CloudFormation stack
✖ Root stack creation failed
init failed
{ ResourceNotReady: Resource is not in the state stackCreateComplete
at constructor.setError (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/resource_waiter.js:182:47)
at Request.CHECK_ACCEPTORS (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/resource_waiter.js:44:12)
at Request.callListeners (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
at Request.emit (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
at Request.emit (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/request.js:683:14)
at Request.transition (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/request.js:685:12)
message: 'Resource is not in the state stackCreateComplete',
code: 'ResourceNotReady',
retryable: false,
time: 2018-10-25T16:09:11.803Z,
statusCode: 200,
retryDelay: 30000 }

I don't know if this helps, however this issue arose after I "amplify delete"'`d on a react-native project. Although it seems to not be a project specific issue, fresh installs don't seem to work either.

Could you try the the following steps, see if it resolves the issue:

check that no aws services has reached its limit
remove all amplify-cli artifacts on the local project.
execute amplify init again, and when prompted, enter a different project name that's never been used before, the "projectName" is used to prefix resource names, use a different name is to avoid name clash in aws.

I can confirm this same issue. After following those three steps, I'm not prompted to enter a project name.  I don't see any remaining (visible or hidden files) artifacts in the directory.  amplify init still fails

Thanks for all of your replies!
Here is a screenshot from the AWS Console of the Events for the corresponding failed Cloud Formation Stack that amplify init generated:

@UnleashedMind -
My AWS account has not hit any limits. I encountered this issue at least three times this morning while attempting to troubleshoot the issue - each time was with a fresh project with a different name.
Success
Oddly enough, I just tried to reproduce the problem again with another fresh project and this time was successful! I notice the timing of the events in the Cloud Formation Stack are slightly different. Here are the logs for the successful Cloud Formation Stack:

Another Failure
After obtaining success, I tried again with another fresh project -- this time, another failure. Same failure reason. Here is another screenshot:

We weren't able to reproduce this issue in the past couple of days within the team, we've contacted our service team to help investigating into this issue.

I beleive this was a momentory issue with the Cloudformation service and our team wasn't able to reproduce this. Please re-open or comment on this issue if you're still experiencing this.


copy scripts folder

script copies are kept in the workdir

https://github.com/CCBR/CCBR_ATACseq/commit/65c48d8f6e9c4fca3e61aa3966523ef0fe89d116


Application does not function

When using the application, it simply gets stuck on "waiting for client connection."  It never goes to the queue function, even after waiting 30~ minutes for it to work. I've tried turning off my firewall, updating .NET, resetting the program several times, etc. It does not work.
https://pastebin.com/wZzapPG4
Here is the error log

N: Requesting for Stop Network Reading...
This log is only logged when Process "Reset" button is clicked. I ... don't think you're clicking it, but written code says...
I'm not sure but, maybe it is also caused by FFXIV Network state change. Or... are you using private router? I'm suspicious about network setting on router.

보낸 사람: NTStation13Admin<EMAIL_ADDRESS>보낸 날짜: 2018년 10월 13일 토요일 오전 8:30
받는 사람: Jaehyuk-Lee/DFAssist
참조: Subscribed
제목: [Jaehyuk-Lee/DFAssist] Application does not function (#8)
When using the application, it simply gets stuck on "waiting for client connection." It never goes to the queue function, even after waiting 30~ minutes for it to work. I've tried turning off my firewall, updating .NET, resetting the program several times, etc. It does not work.
https://pastebin.com/wZzapPG4https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpastebin.com%2FwZzapPG4&data=02|01||643a2891706d42de470808d6309ab14a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636749838282989265&sdata=MywOf7FVjjRSi7BieTr%2FxzHN4xmpk4E09C24LfnLwWc%3D&reserved=0
Here is the error log
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJaehyuk-Lee%2FDFAssist%2Fissues%2F8&data=02|01||643a2891706d42de470808d6309ab14a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636749838282989265&sdata=UqLGkYEcPp1oZidaAi4Q6yO0kIpCYpWrM6EgX9hKv6k%3D&reserved=0, or mute the threadhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEelS9xx23XHpMZzMH4CjgBHm7Io3USnks5ukSYSgaJpZM4XaVES&data=02|01||643a2891706d42de470808d6309ab14a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636749838282989265&sdata=Wqw7UXI3foTr5pWBUnUjSo1s%2BMhpw1umNY6cLsTN6Pw%3D&reserved=0.

this application sometimes need some time to catch data. Please wait some time about 10minutes.
If you didn't change any router setting, it should not make any problem. So i don't think it's the problem.

From: NTStation13Admin<EMAIL_ADDRESS>Sent: Monday, October 15, 2018 3:23:37 PM
To: Jaehyuk-Lee/DFAssist
Cc: Jaehyuk-Lee; Comment
Subject: Re: [Jaehyuk-Lee/DFAssist] Application does not function (#8)
Yes, I have used the reset button in the application, but this is only after I am already waiting to see if it works. Basically I am just trying what I can.
I do have my own router. I don't know what settings I might have on it that would cause issues. Is there anything I should try to change?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJaehyuk-Lee%2FDFAssist%2Fissues%2F8%23issuecomment-429722325&data=02|01||476e26a9fc09418e3e4c08d63266bf68|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636751814203886033&sdata=bbwr6T23zZN2mZgtEXp%2Fl927q3TN7CAuqW7YiT9xpkE%3D&reserved=0, or mute the threadhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEelS-ZlJ1EYNLmAuYZNX7Kn5ApI0CUhks5ulCnpgaJpZM4XaVES&data=02|01||476e26a9fc09418e3e4c08d63266bf68|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636751814203886033&sdata=2mwK6cpWBUI9YV5KNiJaAmXs7U41Zhj8czNgpbaUW7k%3D&reserved=0.

I have waited over 30 minutes before trying to reset it before. It still does not work..

could you try this versionand send me the logs?
It'll log where network packet came from.

I've changed Debug version's download link. - link


Windows 11 support

Will this ever support Windows 11?

Hi @ChrisM65, thanks for writing into docs! This is a great question for our tech community or support, and unfortunately, we can't answer it in the content team.
Please see https://techcommunity.microsoft.com/t5/microsoft-365/bd-p/microsoft-365 or open a support ticket.
I'm closing this issue for now, but feel free to continue commenting if you have feedback on our docs.
#please-close


New maven profile for docker build

Currently the docker images required to build egeria, configuration tools, atlas & other components needed for our VDC demo, are built manually.
As a first step to improve this I plan to

Add a new profile to enable the following (default is no docker build, since it requires additional tools)
use the dockerfile-maven plugin to manage the execution of docker build (Apache 2.0 licensed)

This is effectively just automating what today is done by following the README instructions for docker build.
I will also add a parameter to define the repository to use, in order to address #739
Some useful notes can be found at https://stackoverflow.com/questions/27767264/how-to-dockerize-maven-project-and-how-many-ways-to-accomplish-it
redhat's 'source-to-image' offers another approach for git-centric building, but this is a more significant change from what we have currently, and also requires more tooling that is not available from maven central,so I will take the maven approach first, for speed and simplicity, and later evaluate s2i

Looks nice and straightforward for Maven stuff -- if it results in super-small images, which presumably it will given the right second base image is chosen, then agreed this looks like the ideal direction over s2i.

As an update ref s2i ... knative build is now the in thing for building containers from source
-> https://blog.openshift.com/knative-building-your-serverless-service
My conclusion -- it's an evolving area, many possibilities, keep it simple and generic for now.

Initial build support added.
To enable
mvn clean install -Pdocker -Ddocker.repo=planetf1
docker.repo is nornally your userid for dockerhub, but actually relates to the namespace within a registry for the image.
This is mandatory, and maven-enforce is used to produce an error if it is not provided when the plugin is in use
-Ddocker.registry
can be used to specify an alternative registry to post images to
Two issues found with the spotify plugin
https://github.com/spotify/dockerfile-maven/issues/272 - attempting to build on a remote docker host fails
https://github.com/spotify/dockerfile-maven/issues/273 - MacOS's default docker configuration using the OSX keychain will prevent image push from working
Both are noted in readme as well as reported on github.
The spotify docker plugin being used is on maven central and Apache 2.0 licensed.
Both it & maven-enforcer (see below) have had their version defined using  rather than properties, as this is a superior model moving forward.
Enabled one image so far.
Next commit will add support for the other docker images

Note this issue is used to enable driving the build from maven only - any changes to the actual images will be covered in other issues.

After some testing, the invocation is now
mvn clean install -Ddocker -Ddocker.repo=planetf1
This has been changed due to the way profiles are activated. Now I use a system property to cause a profile to be activated, since then it will be correctly inherited and picked up whichever level the build is performed from (once under 'docker' it's assumed to be done always .. as why else would you be there). This was tricky using profiles as I wanted to refer to the docker submodule, or subsubmodule, or subsubsubmodule...
Note that ideally it's probably better to build in the 'deploy' phase. This may become relevant if any of the image builds need to make use of build time artifacts (currently they do not). However the deploy phase also currently assumes you are pushing maven artifacts to nexus, and without configuration this fails..... this is why currently the build is bound to the 'install' phase.


md-dialog should block page scroll

Bug, feature request, or proposal:
Bug
What is the expected behavior?
When a dialog is open, the page should not scroll. Only the dialog should be scrollable.
What is the current behavior?
When a dialog is open, the user can still scroll the page.
What are the steps to reproduce?
https://plnkr.co/edit/70UnwmTG2mvLWkhOSU4a?p=preview
What is the use-case or motivation for changing an existing behavior?
When a dialog is open, a scrollable page in the background is confusing for the user.
In Angular Material 1, this is configurable with disableParentScroll https://material.angularjs.org/latest/api/service/$mdDialog . While that would be nice to have, disabling the behavior would work as well.
Which versions of Angular, Material, OS, browsers are affected?
I haven't tested extensively, but this affects at least the latest version of Angular / Material / Chrome that we're using.

dupe of about 10 other issues.. also https://github.com/angular/material2/pull/1971

Now tracking via #4093


Section Set indentation size is duplicated

The section Set indentation size appears twice on the page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 16842b60-b268-a322-8078-c0b27c57fa7d
Version Independent ID: d63c12f3-220e-9067-ead5-90e644c06591
Content: Test web APIs with the HTTP REPL
Content Source: aspnetcore/web-api/http-repl.md
Product: aspnet-core
Technology: aspnetcore-webapi
GitHub Login: @scottaddie
Microsoft Alias: scaddie

Hello @GoHajime ... The examples are correct: The first one shows 2-space indent, and the second example shows the JSON with the 4-space indent after changing formatting.json.indentSize to 4.

Sorry for not being any clearer, but the I see the section "Set indentation size" repeated. I have attached a screenshot.

Oh ... The whole section! Sorry ... Another cup of coffee perhaps would have helped me out there.