Scatter Dot goes outside chart with clipData: FlClipData.all()

I've been developing some charts and used LineChart and ScatterChart along with Gesture Detector to make a horizontal scroll.
The thing is when I scroll, the dots are going outside the chart. I don't have the same issue with the line chart, the lines are clipping as they should.
import 'package:fl_chart/fl_chart.dart';
import 'package:flutter/material.dart';

class TestCharts extends StatefulWidget {
  final List<dynamic> inputData;
  final bool animate;

  TestCharts(this.inputData, {this.animate}) : super();

  @override
  TestChartsState createState() => TestChartsState();
}

class TestChartsState extends State<TestCharts> {
  List<ScatterSpot> scatterChartData = [];

  double minX = 0;
  double maxX = 60;
  double resultsLength = 150;

  @override
  Widget build(BuildContext context) {
    return GestureDetector(
        onHorizontalDragUpdate: (DragUpdateDetails dragUpdDet) {
          setState(() {
            double primDelta = dragUpdDet.primaryDelta ?? 0.0;
            if (primDelta != 0) {
              if (primDelta.isNegative) {
                if (maxX < resultsLength) {
                  minX += maxX * 0.005;
                  maxX += maxX * 0.005;
                }
              } else {
                if (minX > 0) {
                  minX -= maxX * 0.005;
                  maxX -= maxX * 0.005;
                }
              }
            }
          });
        },
        child: Column(
          mainAxisSize: MainAxisSize.max,
          children: [
            Row(children: [
              SizedBox(width: 20),
              Expanded(
                child: SizedBox(
                  height: 15,
                  width: 100,
                  child: ScatterChart(_createFetusActivityDataWidget()),
                ),
              )
            ]),
          ],
        ));
  }

  ScatterChartData _createFetusActivityDataWidget() {
    return ScatterChartData(
      scatterSpots: [
        ScatterSpot(0, 0.5, color: Colors.orange.shade400, radius: 2.5),
        ScatterSpot(10, 0.5, color: Colors.orange.shade400, radius: 2.5),
        ScatterSpot(20, 0.5, color: Colors.orange.shade400, radius: 2.5),
        ScatterSpot(30, 0.5, color: Colors.orange.shade400, radius: 2.5),
        ScatterSpot(40, 0.5, color: Colors.orange.shade400, radius: 2.5),
        ScatterSpot(50, 0.5, color: Colors.orange.shade400, radius: 2.5),
        ScatterSpot(60, 0.5, color: Colors.orange.shade400, radius: 2.5),
        ScatterSpot(70, 0.5, color: Colors.orange.shade400, radius: 2.5),
      ],
      clipData: FlClipData.vertical(),
      titlesData: FlTitlesData(
          bottomTitles: SideTitles(
            showTitles: false,
          ),
          leftTitles: SideTitles(
            showTitles: false,
          )),
      gridData: FlGridData(
          show: true,
          drawHorizontalLine: true,
          getDrawingHorizontalLine: (value) {
            return FlLine(
              color: Colors.green,
              strokeWidth: 1,
            );
          },
          horizontalInterval: 1,
          verticalInterval: 6,
          getDrawingVerticalLine: (value) {
            return FlLine(
              color: Colors.green,
              strokeWidth: 1,
            );
          },
          drawVerticalLine: true),
      borderData: FlBorderData(
          show: true,
          border: Border.all(color: Colors.green, width: 1)),
      minY: 0,
      maxY: 1,
      minX: minX,
      maxX: maxX,
    );
  }
}

Screenshots

Versions
fl_chart: ^0.35.0
Flutter (Channel master, 2.2.0-11.0.pre.242）

Hi man.
First of all, I'm sorry for my late delay.
It's my pleasure you like this library.
BTW let me clarify what is going on.
As maybe you know, I work on this project in my free time.
It's simple because I have no profit from this library and I can not put all my effort. I need to work to make money as we all need money to live.
Then fl_chart is not my top important project as soon as there isn't any profit from it.
I will update the README.md to write this disclaimer.
BTW, unfortunately, I cannot resolve your problem right now. It may take time to be fixed.
It is open-source, and everyone can contribute. I'm not responsible for resolving all issues ASAP.
I just wanted to use some charts in my project; then, I decided to publish my work as an open-source library. We are a community, and we need to help each other.


aks browse fails in azure-cli Docker container on Mac

Describe the bug
I set up a cluster in AKS and executed the commands required to browse to it and they work from my machine. But when I execute them in an Azure CLI Docker container, it hangs and eventually exits with an error.
To Reproduce
Steps to reproduce the behavior.

Create a K8S cluster
Launch an Azure CLI container: docker run -it -p 8001:8001 microsoft/azure-cli:latest
az login
az aks install-cli
az aks get-credentials --resource-group my-resource-group --name my-k8s-name
az aks browse --resource-group my-resource-group --name my-k8s-name --disable-browser
Navigate to http://{container-ip}:8001

Expected behavior
See the Kubernetes dashboard
Environment summary

MacOS Mojave (10.14)
CLI version 2.0.49 (in the Docker container)
Shell: zsh

Additional context
This is what appears eventually after running the aks browse command. It also appears when you cancel the running aks browse command:
HTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fa8bae70860>: Failed to establish a new connection: [Errno 111] Connection refused',))
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 159, in _new_conn
(self._dns_host, self.port), self.timeout, **extra_kw)
File "/usr/local/lib/python3.6/site-packages/urllib3/util/connection.py", line 80, in create_connection
raise err
File "/usr/local/lib/python3.6/site-packages/urllib3/util/connection.py", line 70, in create_connection
sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 600, in urlopen
chunked=chunked)
File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 354, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/local/lib/python3.6/http/client.py", line 1239, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/usr/local/lib/python3.6/http/client.py", line 1285, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/usr/local/lib/python3.6/http/client.py", line 1234, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/usr/local/lib/python3.6/http/client.py", line 1026, in _send_output
self.send(msg)
File "/usr/local/lib/python3.6/http/client.py", line 964, in send
self.connect()
File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 181, in connect
conn = self._new_conn()
File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 168, in _new_conn
self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7fa8bae70860>: Failed to establish a new connection: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 638, in urlopen
_stacktrace=sys.exc_info()[2])
File "/usr/local/lib/python3.6/site-packages/urllib3/util/retry.py", line 398, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fa8bae70860>: Failed to establish a new connection: [Errno 111] Connection refused',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/knack/cli.py", line 197, in invoke
cmd_result = self.invocation.execute(args)
File "/usr/local/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 372, in execute
six.reraise(*sys.exc_info())
File "/usr/local/lib/python3.6/site-packages/six.py", line 693, in reraise
raise value
File "/usr/local/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 346, in execute
result = cmd(params)
File "/usr/local/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 182, in call
return self.handler(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/azure/cli/core/init.py", line 436, in default_command_handler
result = op(**command_args)
File "/usr/local/lib/python3.6/site-packages/azure/cli/command_modules/acs/custom.py", line 1381, in aks_browse
requests.post('http://localhost:8888/closeport/8001')
File "/usr/local/lib/python3.6/site-packages/requests/api.py", line 116, in post
return request('post', url, data=data, json=json, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/api.py", line 60, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 524, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 637, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 516, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fa8bae70860>: Failed to establish a new connection: [Errno 111] Connection refused',))

Something similar happens to me too error: error upgrading connection: error dialing backend: dial tcp: lookup aks-default-34133888-1 on <IP_ADDRESS>:53: server misbehaving
Generally having to use az aks browse is a big pain as it doesn't work as reliably as kubectl proxy and it's also inconvenient when you need to work with clusters in different subscriptions. Is there a way to use kubectl proxy directly?

I'm having this issue now:
HTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10fd414a8>: Failed to establish a new connection: [Errno 61] Connection refused'))
Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connection.py", line 141, in _new_conn
    (self.host, self.port), self.timeout, **extra_kw)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/util/connection.py", line 83, in create_connection
    raise err
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/util/connection.py", line 73, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 61] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connectionpool.py", line 601, in urlopen
    chunked=chunked)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connectionpool.py", line 357, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1229, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1275, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1224, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1016, in _send_output
    self.send(msg)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 956, in send
    self.connect()
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connection.py", line 166, in connect
    conn = self._new_conn()
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connection.py", line 150, in _new_conn
    self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x10fd414a8>: Failed to establish a new connection: [Errno 61] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/adapters.py", line 440, in send
    timeout=timeout
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connectionpool.py", line 639, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/util/retry.py", line 388, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001(Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10fd414a8>: Failed to establish a new connection: [Errno 61] Connection refused'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/knack/cli.py", line 197, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 372, inexecute
    six.reraise(*sys.exc_info())
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/six.py", line 693, in reraise
    raise value
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 346, inexecute
    result = cmd(params)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 182, in__call__
    return self.handler(*args, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/core/__init__.py", line 436, in default_command_handler
    result = op(**command_args)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/command_modules/acs/custom.py", line 1381, in aks_browse
    requests.post('http://localhost:8888/closeport/8001')
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/api.py", line 112, in post
    return request('post', url, data=data, json=json, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/api.py", line 58, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/sessions.py", line 508, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/sessions.py", line 618, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/adapters.py", line 508, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10fd414a8>: Failed to establish a new connection: [Errno 61] Connection refused'))

Unfortunately the workaround suggested by @ilyalukyanov does not work anymore

I think why it worked for me was another reason. Maybe the pod was rescheduled on another node. However, when I tried cordoning the suspected node to force rescheduling on another one, the pod started but proxy was timing out and failing (but failing differently).
Restarting the node didn't help too. The only thing that helped is recreating the node from scratch (by de-scaling the cluster and scaling it back - lucky it was dev environment).

I have the same problem with azure-cli 2.0.49
az aks browse --resource-group AKS-demo --name aks-demo
Merged "aks-demo" as current context in /var/folders/rh/5x2rl5p50hb4cd1zf0s2m46m0000gn/T/tmpx08su8oz
Proxy running on http://<IP_ADDRESS>:8001/
Press CTRL+C to close the tunnel...
Forwarding from <IP_ADDRESS>:8001 -> 9090
Forwarding from [::1]:8001 -> 9090
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
Handling connection for 8001
E1031 09:53:44.482047   42072 portforward.go:303] error copying from remote stream to local connection: readfrom tcp4 <IP_ADDRESS>:8001-><IP_ADDRESS>:57370: write tcp4 <IP_ADDRESS>:8001-><IP_ADDRESS>:57370: write: broken pipe
^CHTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x103da5cf8>: Failed to establish a new connection: [Errno 61] Connection refused'))
Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connection.py", line 141, in _new_conn
    (self.host, self.port), self.timeout, **extra_kw)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/util/connection.py", line 83, in create_connection
    raise err
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/util/connection.py", line 73, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 61] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connectionpool.py", line 601, in urlopen
    chunked=chunked)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connectionpool.py", line 357, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1229, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1275, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1224, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1016, in _send_output
    self.send(msg)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 956, in send
    self.connect()
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connection.py", line 166, in connect
    conn = self._new_conn()
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connection.py", line 150, in _new_conn
    self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x103da5cf8>: Failed to establish a new connection: [Errno 61] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/adapters.py", line 440, in send
    timeout=timeout
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/connectionpool.py", line 639, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/urllib3/util/retry.py", line 388, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x103da5cf8>: Failed to establish a new connection: [Errno 61] Connection refused'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/knack/cli.py", line 197, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 372, in execute
    six.reraise(*sys.exc_info())
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/six.py", line 693, in reraise
    raise value
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 346, in execute
    result = cmd(params)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 182, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/core/__init__.py", line 436, in default_command_handler
    result = op(**command_args)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/azure/cli/command_modules/acs/custom.py", line 1381, in aks_browse
    requests.post('http://localhost:8888/closeport/8001')
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/api.py", line 112, in post
    return request('post', url, data=data, json=json, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/api.py", line 58, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/sessions.py", line 508, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/sessions.py", line 618, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.49/libexec/lib/python3.7/site-packages/requests/adapters.py", line 508, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8888): Max retries exceeded with url: /closeport/8001 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x103da5cf8>: Failed to establish a new connection: [Errno 61] Connection refused'))

+1

I have the same issue azure-cli (2.0.49), macOS High Sierra

Same issue with azure-cli (2.0.49), Windows 10 (version 1803).

Same problem. It worked yesterday and now it's not.

Updating the cluster helped, I'm on 11.5 now.

I investigated this with Azure kubernetes services.
By tracing the logs from kubernetes-dashboard in the kube-system namespace i found that the dashboard was listening on port 9090. Using the following "browse" command did the trick.
az aks browse --resource-group RESOURCE --name NAME --listen-port 9090
Not totally related but might help some folks out.

Can this issue be reopened?
I've tested the fix and it only seems to fix the problem partially.
When I run the fix, it no longer spits out the error, but simply exits the proxy.
You can test it as follows (tested this on a mac running 10.14.5):

Run az aks browse --resource-group  my-resource-group --name my-cluster-name

The proxy will start and will open http://<IP_ADDRESS>:8001

Wait a couple of minutes without doing anything and you'll see that the az command silently exits…

I experience the same thing as Pieter -- I'm on linux pop!_os 19.04. az-cli 2.0.58

Still got this error now. My az --version:
azure-cli                         2.0.60 *

acr                                2.2.2 *
acs                               2.3.19 *
advisor                            2.0.0 *
ams                                0.4.2 *
appservice                        0.2.15 *
backup                             1.2.1 *
batch                              4.0.0 *
batchai                            0.4.7 *
billing                            0.2.0 *
botservice                         0.1.8 *
cdn                                0.2.0 *
cloud                              2.1.0 *
cognitiveservices                  0.2.4 *
command-modules-nspkg               2.0.2 *
configure                         2.0.20 *
consumption                        0.4.2 *
container                         0.3.15 *
core                              2.0.60 *
cosmosdb                           0.2.8 *
dla                                0.2.4 *
dls                                0.1.8 *
dms                                0.1.2 *
eventgrid                          0.2.1 *
eventhubs                          0.3.4 *
extension                          0.2.3 *
feedback                           2.1.4 *
find                               0.3.0 *
hdinsight                          0.3.2 *
interactive                        0.4.1 *
iot                                0.3.6 *
iotcentral                         0.1.6 *
keyvault                          2.2.12 *
kusto                              0.2.0 *
lab                                0.1.5 *
maps                               0.3.3 *
monitor                           0.2.10 *
network                            2.3.4 *
nspkg                              3.0.3 *
policyinsights                     0.1.1 *
profile                            2.1.3 *
rdbms                              0.3.8 *
redis                              0.4.1 *
relay                              0.1.3 *
reservations                       0.4.1 *
resource                          2.1.11 *
role                               2.4.2 *
search                             0.1.1 *
security                           0.1.0 *
servicebus                         0.3.3 *
servicefabric                     0.1.14 *
signalr                            1.0.0 *
sql                                2.1.9 *
sqlvm                              0.1.0 *
storage                            2.3.1 *
telemetry                          1.0.1 *
vm                                2.2.16 *

Python location '/opt/az/bin/python3'
Extensions directory '/home/shenghang/.azure/cliextensions'

Python (Linux) 3.6.5 (default, Mar  7 2019, 19:49:28)
[GCC 5.4.0 20160609]

Legal docs and information: aka.ms/AzureCliLegal

The resolution to this issue was specifically about not spitting out the ugly error shown above when the connection drops. We separately need to handle the connection drops. I've filed issue #11580 for that and PR #10668 is in progress to solve it.


Use lastStep to improve funnel telemetry

Depends on https://github.com/microsoft/vscode-azuretools/pull/956 and https://github.com/microsoft/vscode-azuretools/pull/957

Did you intentionally not add stepNames to any ui calls that were in wizard steps?

Yes because the wizard step names are already pretty accurate

I assume it's probably because it's the one and only step in a command

Nah it's more that it's too annoying to specify a stepName for every single possible warning. And fwiw when there's no step name the fallback behavior is to use a shortened version of the message (see here), so the property is still defined in telemetry, just maybe not as succinctly or accurately as using a stepName.

Would it make any sense to just add the command callbackId as the stepName if it is left undefined and isn't part of a wizard?

As stated, the property should never be left undefined.


Error in husky install

I'm trying to make bullseye version of your latest tag, and can't compile.
I have node 18 installed with nodesource.
This is what I do:
gbp clone https://github.com/dionysius/vaultwarden-web-vault-deb.git
cd vaultwarden-deb
git reset --hard $(git describe --abbrev=0)
gbp buildpackage -d -b --git-export-dir=. --git-ignore-new -us -uc

And this is what I get:
gbp:info: Creating vaultwarden-web-vault_2023.5.0.orig.tar.gz from 'web-v2023.5.0'
gbp:info: Extracting 'vaultwarden-web-vault_2023.5.0.orig.tar.gz' to '/home/noone/vaultwarden/vaultwarden-web-vault-deb/package/vaultwarden-web-vault-tmp'
gbp:info: Exporting 'HEAD' to '/home/noone/vaultwarden/vaultwarden-web-vault-deb/package/vaultwarden-web-vault-tmp'
gbp:info: Moving '/home/noone/vaultwarden/vaultwarden-web-vault-deb/package/vaultwarden-web-vault-tmp' to '/home/noone/vaultwarden/vaultwarden-web-vault-deb/package/vaultwarden-web-vault-2023.5.0'
gbp:info: Performing the build
 dpkg-buildpackage -us -uc -ui -i -I -d -b
dpkg-buildpackage: info: source package vaultwarden-web-vault
dpkg-buildpackage: info: source version 2023.5.0-2
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by dionysius<EMAIL_ADDRESS> dpkg-source -i -I --before-build .
dpkg-buildpackage: info: host architecture amd64
dpkg-source: info: using options from vaultwarden-web-vault-2023.5.0/debian/source/options: --extend-diff-ignore=(^|/)(.github|LICENSE|README|signing-key)
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying web_vault.patch
 debian/rules clean
dh clean
   dh_clean
        rm -f debian/debhelper-build-stamp
        rm -rf debian/.debhelper/
        rm -f -- debian/vaultwarden-web-vault.substvars debian/files
        rm -fr -- debian/vaultwarden-web-vault/ debian/tmp/
        find .  \( \( \
                \( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \
                \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
                 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
                 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
                 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
                \) -exec rm -f {} + \) -o \
                \( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \) \)
 debian/rules binary
dh binary
   dh_update_autotools_config
   dh_autoreconf
   debian/rules override_dh_auto_configure
cp -rf debian/patches/resources/* apps/web/
   debian/rules override_dh_auto_build
npm ci
npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm WARN deprecated<EMAIL_ADDRESS>Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Use String.prototype.trim() instead
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated<EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead
npm WARN deprecated<EMAIL_ADDRESS>some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated<EMAIL_ADDRESS>Please use @electron/asar moving forward.  There is no API change, just a package name change
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please use @electron/osx-sign moving forward. Be aware the API is slightly different
npm WARN deprecated<EMAIL_ADDRESS>dommatrix is no longer maintained. Please use @thednp/dommatrix.
npm WARN deprecated<EMAIL_ADDRESS>You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

><EMAIL_ADDRESS>prepare
> husky install

husky - .git can't be found (see https://typicode.github.io/husky/#/?id=custom-directory)
npm ERR! code 1
npm ERR! path /home/noone/vaultwarden/vaultwarden-web-vault-deb/package/vaultwarden-web-vault-2023.5.0
npm ERR! command failed
npm ERR! command sh -c husky install

npm ERR! A complete log of this run can be found in: /home/noone/.npm/_logs/2023-08-05T18_04_35_497Z-debug-0.log
make[1]: *** [debian/rules:24: override_dh_auto_build] Error 1
make: *** [debian/rules:16: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -i -I -d -b failed
gbp:error: 'debuild -i -I -d -b -us -uc' failed: it exited with 29

Seems that husky must have a .git in the same folder as package.json is or at least have a cd.. and a install in a subfolder (see https://stackoverflow.com/questions/74129312/how-to-configure-husky-when-git-is-in-a-different-folder)

I'm on holiday so lets see when I can look into it. In the meantime you should be able to just use the .deb of the bookworm build as the resulting package is arch independent and technically also debian version independent - it just contains the resulting webpage files

according to CI I'm using node 16.x: https://github.com/dionysius/vaultwarden-web-vault-deb/blob/19adb5c19f3afc78511df5cd7b436683c3a97ebc/.github/workflows/packaging.yml#L22

Also the official patching repo still uses node 16.x: https://github.com/dani-garcia/bw_web_builds/blob/master/Dockerfile#L20

Thanks a lot for answering. The is no rush at all. I have used bookworm deb as you mentioned with any problem. And I have been able to build bullseye version of vaultwarden-deb.
I'll take a look at node16 and I'll come back to tell the result.
Thanks a lot again for your work

I'll look into it as well and probably update the readme a bit. To be fair the nvmrc file on the official upstream source seems to use node 18. I suspect 16 won't help but I hope i find out more

Well looks like I found the cause. I spun up a fresh lxc bullseye container and dug around. It seems it doesn't like it if you tell it to export it to the current folder. I get your error if I use --git-export-dir=., but works fine if I use --git-export-dir=.. (it creates the merged debian source in a folder in the parent).
I still get the following warning, slightly different, but it continues:
><EMAIL_ADDRESS>prepare
> husky install

fatal: not a git repository (or any of the parent directories): .git
husky - git command not found, skipping install

added 3528 packages, and audited 3540 packages in 1m

It kinda makes sense, as gbp has two branches with data that makes the debian source package, the debian branch and the upstream branch. Itneeds to merge the data from both debian branches and thus should do that in a clean folder. Note that commands not referred in build-dependencies are usually also not available during the build, this is probably why git is not available and we got "lucky" the build continues. husky is anyway unneeded for the build
Note to self:

nvm 18 did not work, 16 was fine, so something is off with the workaround
bookworm has 18 already available, could skip installing nodesource during CI
I should update ci to 18, as upstream .nvmrc is suggesting to build with 18


Add warning if sanitize is set to false for tooltips and popovers

Closes #434.

Hi @mhatvan,
Thanks for the PR, unfortunately it's not a good way to check that because:

We have to check for Tooltips and Popovers the internal config to see if sanitize is equal to false

@Johann-S aww, too bad, I must have overread this note in the options when I was reading the documentation.
Where do I find the internal config so that I can implement it?

you should select all the tooltips and popovers by doing that: $('[data-toggle="tooltip"]', [data-toggle="popover"]) and you'll be able to do : $(tooltip).data('bs.tooltip') which will return to you an instance of our Tooltip class a like that you'll find the config attribute 😉

Can't get it working according to your explanation.
$('[data-toggle="tooltip"]').data('bs.tooltip') returns undefined.
In a bootstrap project in the browser I can do $('[data-toggle="tooltip"]').tooltip(), then access the default options set by bootstrap through $('[data-toggle="tooltip"]').data('bs.tooltip').options.
When running bootlint.js with yarn test with the same code, I receive $(...).tooltip is not a function

if you have multiple tooltip triggers this jQuery cal $('[data-toggle="tooltip"]') will return an array, so you have to do:
$.each($('[data-toggle="tooltip"]'), function ($tooltip) {
	$tooltip.data('bs.tooltip') // => return a Tooltip instance
})

Tried again, can't get it to work, maybe someone else wants to take over this PR.

Hi @mhatvan,
You should try that:
$.each($('[data-toggle="tooltip"]', [data-toggle="popover"]'), function ($tooltip) {
	var dataKey = $tooltip.attr('data-toggle') === 'tooltip' ? 'bs.tooltip' : 'bs.popover'
	var obj = $tooltip.data(dataKey)
	if (!obj.config.sanitize) {
	  // warn here
	}
})

Do not hesitate to tell me where you're stuck 😉

Your code snippet looks solid, but doesn't work either -> $.each is not a function

Oh yes you're right @mhatvan, I updated my code, it should be fine now 😄

It's not your job to initialize the popover/tooltip, you have to check if an initialized Popover/Tooltip disabled the sanitize option.

Also, since it is in an .each loop, the reporter would spit out the same error message for every non-passing element, is this correct behavior?

Yup it's seems correct to me 🤔 maybe @Herst have some feedbacks

There should be only a single call to reporter() but with an array of elements as the second argument (one per offence). Your original code was correct in this regard.

I tried again getting this to work, in the browser it works fine, in bootlint.js not.
var obj = $(this).data(dataKey)  doesn't work because there is no bs.tooltip property in $(this).data() that can be accessed, therefore resuting in Cannot read property 'config' of undefined.

Hi @mhatvan if you're unable to retrieve something from .data(dataKey) it means there is no plugin initialized, so you can skip this one

Well, that's what I receive for all tooltips and popovers, so I can't access any options and can't implement the reporter to report on anything.

So you have to initialized some of them before running your tests to simulate a real use case 😉


Create interfaces for generic toastr

[ ] Create generic toaster

[ ] Use users toaster if his browser has already cached it

[ ] Add documentation with on how to use


Add dracula_style to html_styles

This PR should come before: https://github.com/elixir-makeup/makeup_demo/pull/14

I will close this one. Once we release a new makeup this one should be rebuilt here and just works. Thanks :)


Could not resolve all artifacts for configuration ':image_picker_android:debugUnitTestRuntimeClasspath'.

flutter build apk fails on M1 chip mac not even on intel base mac but works fine on windows. Using image_picker: ^0.8.4+4

% flutter build apk

💪 Building with sound null safety 💪

Warning: The plugin google_api_headers requires Android SDK version 32.
One or more plugins require a higher Android SDK version.
Fix this issue by adding the following to /Users/devops2/Downloads/example/android/app/build.gradle:
android {
  compileSdkVersion 32
  ...
}

Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/03 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/03 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/03 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
../../../../../../Desktop/src/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_datetime_picker-1.5.1/lib/flutter_datetime_picker.dart:311:32: Warning: Operand of null-aware operation '??' has type 'Color' which excludes null.
 - 'Color' is from 'dart:ui'.
                  color: theme.backgroundColor ?? Colors.white,
                               ^
Note: /Users/devops2/Desktop/src/flutter/.pub-cache/hosted/pub.dartlang.org/google_maps_flutter_android-2.1.10/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
WARNING: [Processor] Library '/Users/devops2/.gradle/caches/modules-2/files-2.1/org.robolectric/shadows-framework/4.3.1/da048a93951f4d9e46519749c53b0f868dfdf425/shadows-framework-4.3.1.jar' contains references to both AndroidX and old support library. This seems like the library is partially migrated. Jetifier will try to rewrite the library anyway.
 Example of androidX reference: 'androidx/test/runner/lifecycle/Stage'
 Example of support library reference: 'android/support/annotation/NonNull'

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> Could not resolve all artifacts for configuration ':image_picker_android:debugUnitTestRuntimeClasspath'.
   > Failed to transform bcprov-jdk15on-1.68.jar (org.bouncycastle:bcprov-jdk15on:1.68) to match attributes {artifactType=processed-jar, org.gradle.category=library, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime}.
      > Execution failed for JetifyTransform: /Users/devops2/.gradle/caches/modules-2/files-2.1/org.bouncycastle/bcprov-jdk15on/1.68/46a080368d38b428d237a59458f9bc915222894d/bcprov-jdk15on-1.68.jar.
         > Failed to transform '/Users/devops2/.gradle/caches/modules-2/files-2.1/org.bouncycastle/bcprov-jdk15on/1.68/46a080368d38b428d237a59458f9bc915222894d/bcprov-jdk15on-1.68.jar' using Jetifier. Reason: IllegalArgumentException, message: Unsupported class file major version 59. (Run with --stacktrace for more details.)
           Suggestions:
            - Check out existing issues at https://issuetracker.google.com/issues?q=componentid:460323&s=modified_time:desc, it's possible that this issue has already been filed there.
            - If this issue has not been filed, please report it at https://issuetracker.google.com/issues/new?component=460323 (run with --stacktrace and provide a stack trace if possible).

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2m 0s
Running Gradle task 'assembleRelease'...                          121.2s
Gradle task assembleRelease failed with exit code 1

flutter doctor -v result
% flutter doctor -v

[✓] Flutter (Channel stable, 2.10.4, on macOS 12.5 21G72 darwin-arm, locale en-DE)
    • Flutter version 2.10.4 at /Users/devops2/Desktop/src/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (5 months ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /users/devops2/library/android/sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • ANDROID_HOME = /users/devops2/library/android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.46.0

[!] Connected device
    ! No devices available

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

Hi @AzharRaeisi
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @exaby73
Thanks for your reply, this is a bug I think so, if you run the code on debug mode it works fine however the problem is there when I try to do either flutter build apk or flutter build apk --release.
It fails no matter what I do for instance I even changed the image_picker to latest version, but same result
This error is occuring since I upgraded flutter version from 2.5.2 to 2.10.4

I have found a duplicate issue here. Please follow the solution outlined here. Thank you


Regenerate common protos for PHP

Same as https://github.com/googleapis/gapic-generator/issues/2209 and https://github.com/googleapis/gapic-generator/issues/2204, but for PHP.
This blocks new regens for the Logging and Monitoring clients, which depend on the newest common protos.

Marking as P1 in line with the other issues.

PR: https://github.com/googleapis/gax-php/pull/210

@michaelbausor so this is complete?

Yes, closing out


Logicandcompare

This builds up on my previous pull request (https://github.com/neonxp/MathExecutor/pull/49) adding logical and compare operators <, <=, >, >=, ==, !=, ||, &&

While I fundamentally agree with the idea of adding logical operators to the package, there are a couple of issues that we need to resolve before we can merge.  We also need to update the docs.  I can do that before the release, but we need to fix the operator precedence issues and a couple of minor text messages.  Will try to put comments in the correct locations, but still new to github code reviews.
Also, Alex, do you want to weigh in on the idea of adding comparison operators to the package?
Basically conditional operators should return an int of 1 (true) or 0 (false).  But this is only really useful if we have a comparison type function.  I would propose we add a built in if function that would be look like this:
if ($condition, $trueReturnValue, $falseReturnValue)
You would then be able do do something like if ($a >= $b, $b / $a, $a - $b)
Also noticing other packages like this (this one still being the best), and the others implement a much wider variety of built in functions.  Thinking conditionals and expanded function support is version 1.1.
And Franco, thanks for the work on this.

Hi,
The if() function is exactly what I needed and the work in this PR is the preparation for the if() function. I've already implemented it in an extension that I use in my code but I can publish it as a PR. I'll look into the suggested changes as soon as possible.

Yes, please add if function in next commit.  Thanks!  This makes no sense without it actually.
Will be a very nice enhancement to the package.

Hi,
I solved the issues (I hope!) and added the if function. I put some comments in the commit messages that should explain how I worked.
I also solved a small problem with cache key creation.
Hope everything is good now,
Thanks,
Franco

Looks good!  I'll update the readme and issue a release at some point.  Thanks for the PR!

V1.1.0 is released.  I did change the name of TokenUnequal to TokenNotEqual, but should not make a difference to anyone.


Fix ci issue

@apatard
Could you kindly review this PR?
The ansible-galaxy is the worst package management tool. 🤪


python.experiments.optInFrom isn't a recognized configuration

Testing #22287

It doesn't need to know about all experiments, but it should probably be declared as an array

Sorry for the typo. It's optInto instead of optInFrom


Create the ability to manage a group of administrators

Group Admins should support a list of owners and members.

Owners will have the ability to manage the group.
Projects and/or quizzes can be assigned to the group
All group members/owners will be given admin access to all assigned projects and quizzes

PR: #2942

:+1:


[BUG] [Event Request] Codeunit 22 procedure InsertVarValueEntry

Hello,
For one of our customizations we need to update the Variance amount in function InsertVarValueEntry in codeunit 22.
local procedure InsertVarValueEntry(ValueEntry: Record "Value Entry"; VarianceAmount: Decimal; VarianceAmountACY: Decimal)
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeInsertVarValueEntry(ValueEntry, Item, VarianceAmount, VarianceAmountACY, IsHandled);
    if IsHandled then
        exit;

    if (not ValueEntry.Inventoriable) or Item."Inventory Value Zero" then
        exit;
    if (VarianceAmount = 0) and (VarianceAmountACY = 0) then
        exit;

We are using Event OnBeforeInsertVarValueEntry for this.
Note: if the Variance amount is 0 the function will exit.
We noticed this code is not always executed, this is because the if before the function Call:
            if ((GlobalValueEntry."Valued Quantity" > 0) or ("Applies-to Entry" <> 0)) and
               ("Entry Type" = "Entry Type"::Purchase) and
               (Item."Costing Method" = Item."Costing Method"::Standard) and
               **(Round(VarianceAmount, GLSetup."Amount Rounding Precision") <> 0)** or
               VarianceRequired
            then
                InsertVarValueEntry(GlobalValueEntry, VarianceAmount, VarianceAmountACY);

As you can see the function is skipped if VarianceAmount is 0. I think this line should be removed.
if that is not possible, I would like to add the VarianceAmount and the VarianceAmountACY to procedure as var:
OnItemValuePostingOnBeforeInsertOHValueEntry(ItemJnlLine, GlobalValueEntry, GlobalItemLedgEntry, ValueEntryNo, IsHandled);
Can you inform me about the delivery time of this bug ?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add a CONTRIBUTING.md

Adding a CONTRIBUTING.md to this repository as part of an effort to improve our open source documentation. Looking for reviews!
Here's what it looks like:

New CONTRIBUTING.md visual:

Looks good Ingrid!


Upgrading to 0.16.0 breaks column_anomalies tests due to missing metric_type

We are running Elementary Cloud with dbt cloud versionless.
Yesterday we upgraded our dbt-data-reliability version from 0.15.2 to 0.16.0, and today we have found that all our column_anomalies tests have thrown an error with the message Unrecognized name: metric_type; Did you mean metric_name?
We suspect this is related to this change.
Since we have seen no breaking changes being disclaimed on the release notes, nor instructions on how to adapt to the introbuction of  metric_type, we have resolved to roll back to 0.15.2.

Hi @PatFitzner ,
Can you please copy your test settings here?

Hello! No, we did not. Is that something we should be doing after every version upgrade? Because I've checked in both release notes, and in the Elementary: Upgrade dbt package. PR that the elementary-data bot added automatically in our project, and could not find any references to this.

Hi @PatFitzner , Can you please copy your test settings here?

Hey, please excuse my ignorance but I am not sure of what exactly you are requesting. Could you help me understand?

Hey @PatFitzner, the "rule" is to run dbt run -s elementary on every minor version upgrade (so no need to run when upgrading from 0.15.1 to 0.15.2 but do need to run when upgrading to 0.16.0).
We should probably communicate it better in our release notes/cloud pull requests

Hi @ofek1weiss !
Thank you for your comment.
I was checking the link you included, but it is related to Elementary OSS, and we are using Elementary Cloud. The only place where we would be able to run dbt run --select elementary would be in the dbt cloud IDE, which would have no effect in our production environment, if I am not mistaken.
Could you please confirm that this step is still required for Cloud, and how we should go about it?
Thank you.

HI @PatFitzner !
Just to clarify - do your production jobs also run via dbt cloud, or in another manner?
If they run via dbt Cloud, you can create an additional job for running the Elementary models and execute it.

Hey @haritamar !
Indeed, that is the case. I will try that.
Thank you!

I am closing the issue for now.
@PatFitzner I also sent you an invite to our mutual Slack channel with your company.
We have an on-call engineer who provides support in these Slack channels.


[SPARK-27532][Doc] Correct the default value in the Documentation for "spark.redaction.regex"

What changes were proposed in this pull request?
Corrected the default value in the Documentation for "spark.redaction.regex"
How was this patch tested?
NA

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #104781 has started for PR 24428 at commit 97c3fa5.

Merged to master.
since we don't build the docs in PR builders.

Test build #104781 has finished for PR 24428 at commit 97c3fa5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104781/
Test PASSed.


[DRAFT] Feature/merge changes from upstream

In this branch (which is a branch from the current master branch in this fork), I merged changes from the upstream master branch and also incremented the version of the Python bindings to 0.3.42. Check out the 3 commits at the very bottom to see the extra changes I put in. The merged-in changes help with the thread safety issue and I am able to get similar times for each request.
I will make this a draft PR for now until I can do some more testing with a running Sparkle engine. Thus far, I have only been testing this outside the engine using a custom-made script that runs the calculate_feature function concurrently. I can share this code if it will be interesting. With this script, I was able to reproduce the pattern we were seeing in the engine (some requests taking double the time). With my updates, concurrent executions are taking roughly the same time.

Still running some tests with the new package and a running engine, but so far I can see that the running time of concurrent requests is pretty stable. Submitting 4 requests over and over again at the same time leads to total request times averaging about 45 seconds. The important detail here is that I am not seeing any request times taking roughly double that, as I was with the old package.
I also checked to see if the outputs being generated were still different (the non-deterministic issue). It appears that that has not been resolved. But, I wasn't really expecting that to be resolved with these changes, anyway.

@desilinguist Actually, I don't either. I was assuming that certain changes were already merged. Maybe they haven't yet. My first thought was to just merge in all changes since this branched off.
Anyway, I am now seeing a new pattern emerge that was unexpected and I now believe was making it seem as though the issue were resolved when it actually had not been.
Using the original package, I first tried to submit 1 request at a time just to make sure things were working. The requests were taking a stable amount of time and that's all that I noted. Then, when I submitted 3 requests at a time, I noted that certain requests were taking considerably longer than others. It looked like the same pattern from the engine context. However, the single requests were only taking about 30 seconds and the simultaneous requests were ranging from 30 seconds to a minute.
When I made the new package with the changes in this PR, I tried 4 requests simultaneously and noted that they were all taking about 55 seconds. So, I thought this was resolved because the timing was stable. However, I went back and tried with the original 0.3.29 package again to run the same experiment and found the same stability. And I could get the same instability with 3 simultaneous requests with the new package, actually.
Long story short, I don't believe this is resolving anything unfortunately. I will take a look at the PR that I thought was merged that related to thread safety issues. In the meantime, though, it could still be a good idea to update the package. It wouldn't no any harm, at least...

Thanks for the detailed update and for confirming my intuition @mulhod. It definitely makes sense to update the package with the latest upstream code! From what I remember, I think the thread-safety changes might have been in a fork ... may be we can incorporate them in our branch too?

Yeah, I'm going to look into that shortly. I'll just leave this open for now and work on it when I get a chance.


Can I toggle company-tabnine in company mode?

Sometimes, when I use company-mode, but I want to close tabnine, since CPU and memory are high. So how to toggle tabnine in the company-mode? Very thanks.

I wrote two simple functions to manually turn on and off TabNine for the current buffer. It may be helpful for you.
(defun shou/tabnine-off ()
  "turn off TabNine for this buffer"
  (interactive)
  (setq-local company-backends (delete 'company-tabnine company-backends)))

(defun shou/tabnine-on ()
  "turn on TabNine for this buffer"
  (interactive)
  (setq-local company-backends (add-to-list 'company-backends 'company-tabnine)))


Supporting ASP.NET vnext

hi,
i am trying to currently use the library in ASP.Net vnext project, but the problem is the use of System.Drawing, which is not supported in VNext, any advice ?
thanks in advanced.

Is this still working??  I have added a new project and need to reference System.Drawing, so i have this, but it says error
"frameworks": {
        "net50": {
            "dependencies": {
                 "System.Drawing": ""
            }
        }
    }

Hi Gillardo, what do you mean by "Still working"? Did you previously have it working? What was your error message?

No i didnt have it working at all, i couldnt get it to woek by referencing
Syste.Drawing
On 10 Oct 2015 00:24, "James Jackson-South"<EMAIL_ADDRESS>wrote:

Hi Gillardo, what do you mean by "Still working"? Did you previously have
it working? What was your error message?
—
Reply to this email directly or view it on GitHub
https://github.com/JimBobSquarePants/ImageProcessor/issues/100#issuecomment-147009123
.

Do you have an error message. I haven't attempted to get this version working with vNext I've started a v3 branch for that.

I'm closing this for now as I will be supporting net core in the new V3 codebase.


system-tests: Rewrite tests to use Dependency injection

https://junit.org/junit5/docs/current/user-guide/#writing-tests-dependency-injection

https://github.com/EnMasseProject/enmasse/pull/1156


Amplify.Auth.signIn call ends up in "Incorrect username or password"

Hi,
we have created a user pool in our amazon AWS console and we are also able to successfully create user in that pool from an iOS app using the Amplify SDK. We integrated the SDK with SPM and use the version 1.0.28.
We are looking at the documentation from here for signup/signin purpose: https://docs.amplify.aws/lib/auth/signin/q/platform/ios/#sign-in-a-user
Firing Amplify.Auth.signUp like described above works fine. It creates a user in our console and because we have a lambda function in place to skip user sms verification (Amplify.Auth.confirmSignUp), the user appears as verified in our Cognito console.
For the signup, we use the following options:
let userAttributes = [AuthUserAttribute(.phoneNumber, value: phone)]
let options = AuthSignUpRequest.Options(userAttributes: userAttributes)

Amplify.Auth.signUp(username: "+49xxxxxxx", password: "123456", options: options) { signupResponse in
       // success and expected behavior here
       ....
}

After the signup we would expect that we can login with the new created user.
But when we try to login with the user we signup we end up in:
AuthError: Incorrect username or password.
Recovery suggestion: Check whether the given values are correct and the user is authorized to perform the operation.

For the login, we fire Amplify.Auth.signIn with phone and password for an user created, like this:
Amplify.Auth.signIn(username: "+49xxxxxxx", password: "123456") { response in
     // AuthError here
}

We init Cognito sdk in AppDelegate in didFinishLaunchingWithOptions like this:
        do {
            try Amplify.add(plugin: AWSCognitoAuthPlugin())
            try Amplify.configure()
            log.debug("Amplify configured with auth plugin")
        } catch {
            log.error("Failed to initialize Amplify with \(error)")
        }

amplifyconfiguration.json looks like this:
{
    "auth": {
        "plugins": {
            "awsCognitoAuthPlugin": {
                "IdentityManager": {
                    "Default": {}
                },
                "CognitoUserPool": {
                    "Default": {
                        "PoolId": "pool-id-here",
                        "AppClientId": "app-client-id-here",
                        "Region": "eu-central-1"
                    }
                },
                "Auth": {
                    "Default": {
                        "authenticationFlowType": "USER_SRP_AUTH"
                    }
                }
            }
        }
    }
}

The awsconfiguration.json looks like this:
{
    "UserAgent": "aws-amplify/cli",
    "Version": "0.1.0",
    "IdentityManager": {
        "Default": {}
    },
    "CognitoUserPool": {
        "Default": {
            "PoolId": "pool-id-here",
            "AppClientId": "app-client-id-here",
            "Region": "eu-central-1"
        }
    },
    "Auth": {
        "Default": {
            "authenticationFlowType": "USER_SRP_AUTH"
        }
    }
}

Both files are in a subfolder of the project where the Cognito implementation is too - so they are not in the root folder but this probably makes no difference?
Can you please help me here and please let me know what to change to make it work?

Okay I found the issue. I submitted really wrong credentials. So the error was okay. After fixing this, it is working. So for everyone running in this in the future, please also recheck what exactly you submit in Amplify.Auth.signUp and with what exactly you try to Amplify.Auth.signIn


fix: 避免从高版本降级到2.10.0后因provider字段改变导致操作不兼容

这个 PR 实现什么功能/修复什么问题:
fix: 避免从高版本降级到2.10.0后因provider字段改变导致操作不兼容
是否需要 backport 到之前的 release 分支:
None
/area region
/cc @swordqiu @yousong

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@6e65714). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #2122   +/-   ##
================================================
  Coverage                  ?   7.56%
================================================
  Files                     ?     410
  Lines                     ?   63439
  Branches                  ?       0
================================================
  Hits                      ?    4801
  Misses                    ?   58226
  Partials                  ?     412

Flag
Coverage Δ

#aFlag
7.56% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/skus.go
1.47% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e65714...c9d39df. Read the comment docs.

/lgtm

/approve


"Online Docs" button doesn't open current documentation page in the browser

Tested versions
I'm using v4.2.1.stable.official [b09f793f5]
System information
Godot v4.2.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - integrated AMD Radeon(TM) Graphics (Advanced Micro Devices, Inc.; 31.0.21910.5) - AMD Ryzen 5 5500U with Radeon Graphics (12 Threads)
Issue description
"📤Online Docs" button should detect what offline docs page I have active and open it in the browser instead of docs home page
Steps to reproduce
Have script editor open
Within it have documentation page open
Press the "📤Online Docs" button
It just opens Godot Docs home page, and NOT the specific page I have open.
Minimal reproduction project (MRP)
any blank project works

This should be a proposal as this is for reporting bugs 🙂

Related: https://github.com/godotengine/godot-proposals/issues/8989


Support chess ranking according to standard ranking rules

When playing on a ranked table, only complete games get ranked. I don't want to put in time trying to think about how a player might blow up the table to avoid a losing score. Ranking makes you stronger. If you want to be an ass, people won't play with you... if it gets bad, I'll track incomplete games with the option for both players to agree to annul. Keep classy, you chess-playing minecrafters.

https://en.wikipedia.org/wiki/Elo_rating_system


feat: wrap app with logger to duplicate stderr to syslog

This PR experiments the wrapping of the registry-redirect app with the logger (https://man7.org/linux/man-pages/man1/logger.1.html) utility. We just wrap the binary at the publish step, with a debian buster-slim instance (alpine doesn't have all the proper dependencies to make rsyslogd work, or at least, I tried and figured out it would take some time to debug).
As a debug step, I am currently redirecting all the outputs to my ngrok address, linking to a local vector instance. Everything works as expected, even though I am getting errors after some time (we will need to dig into that):

In test prod: https://fly.io/apps/dagger-registry-2023-07-28. To test it out: visit dagger-registry-2023-07-28.fly.dev

Actually, it seems that it fails when rsyslog drops the connection. We might need to extend it's configuration to check that + use the process as gerhard said

Following a verification with Gerhard, this has been deprecated in favor of https://github.com/dagger/registry-redirect/pull/5. Even though this solution is elegant, we had some intermittent disconnect with the remote syslog server. Adding a new layer meant another layer to monitor and no control over the behavior on the server connection.
Moving the logic at the app level is now preferred


Allow run js linter out of widl-nan repo

When add widl-nan as dependencies, the eslint and jshint won't installed
under node_moudles via "npm install". Thus, the js linter will fail.
To allow that case, we need add those js linters as devDependencies and
allow ./tools/lint.py to run them who under same dir level of widl-nan.

@kenny-y PTAL

Done merging & publishing 0.1.7 @halton

Thanks


Standardize on either provision or infra create in VSCode extension

Originally from https://github.com/Azure/azure-dev/pull/853#discussion_r1091213418.
We use provision in some places and infra create in others. Ideally we should use only one of those.

@savannahostrowski Should we prefer keeping azd provision as public and remove/keep internal azd infra create/delete?
cc: @jongio

We have no equivalent for infra delete today, AFAIK. azd down covers the deprovisioning + tearing down deployments.
We should definitely stick with provision because that's what we promote. Perhaps we need a different command that feels more equivalent to provision as opposed to infra delete? deprovision? And then retire 	infra create/delete?

The robot overlords like "deprovision"

We have no equivalent for infra delete today, AFAIK. azd down covers the deprovisioning + tearing down deployments.

Doesn't azd infra delete also behaves like azd down. If we are deleting/de-provisioning the infra aren't we implicitly pulling down deployments too?

I like deprovision

@weikanglim @rajeshkamal5050 This will be taken care of soon, JFYI. We should close this when changes are made.


testcase Fix unintended partition creation when insert overwrite auto detect for auto partition table

add testcase of https://github.com/apache/doris/pull/44449
master code is right, so no change needed.

run buildall


HIVE-25136: Remove MetaExceptions From RawStore First Cut

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@miklosgergely This work regarding MetaExceptions is coming from my emails to dev@hive .  This one is a bit more significant and removes many instances of this Thrift-generated MetaExceptions from the bowels of the Hive Metastore.  Please let me know if you can take a look at this. Thanks!
@nrg4878 too


Hawkeye's Handgun states you can only have one of these

In item inventory it says you can only have 1 of Hawkeye's Handgun it is possible to have at least 2 in game

This event craft is unlimited. I've got 10 copies of it.


Add markdown highlights (heading)

Added heading highlighting, honestly I haven't enough experience with tree-sitter queries, so need to check this PR and maybe improve it (add link highlight for example).

Can you ping me in a few hours? thanks


⚠ Bofrost.at has degraded performance

In eaaa556, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1370 ms

Resolved: Bofrost.at performance has improved in 55fb394 after 13 minutes.


Make exportTable command volume aware

Is your feature request related to a problem? Please describe.
When using exportTable command, it does not take into consideration of multiple volumes and creates a single distcp.txt file. The file does not differentiate between volumes and the file must be post-processed to separate the files by volume(s) for feeding to individual distcp commands for each volume when exporting a table that uses more than one volume.
Describe the solution you'd like
Have the command generate a single file (distcp) list per volume.  The solution should play nice with importTable command.  It may also be useful if the exported metadata and the distcp file lists are preserved after the import table process to allow for post-processing validation.
Additional context
This is a follow on to #2869, #2871 and #2849 (offline option) which implement work-arounds for exportTable and importTable not being volume aware.  Inspired by changes submitted by @drewfarris for importTable to handle multiple directories.

I have logic in place and starting to test the changes now.

In discussions on #3228, I've become aware that the term "Volume aware" isn't quite the right terminology for what is needed. What it needs to be is "FileSystem aware". Files need to be grouped by Hadoop FileSystem instances (not just FileSystem types), regardless of how they map to Accumulo Volume instances. The limitation on distcp is copying across Hadoop FileSystems. DistCp has no knowledge of, or concept of, Accumulo Volumes.


Expose prometheus metrics at ScaledJob like ScaledObject

Provide a description of what has been changed
Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #
https://github.com/kedacore/keda/issues/4798

Relates to #

Hi @JorTurFer
https://github.com/kedacore/keda/pull/4817
The previous PR was broken, so I opened this new PR.
I am sorry but I couldn't roll it back.
Please take a look at this one again.
Thanks.

Could you please add e2e test for this feature? You can see existing tests for Prom metrics for ScaledObjects: https://github.com/kedacore/keda/blob/main/tests/sequential/prometheus_metrics/prometheus_metrics_test.go

Hi @zroubalik I will update it together, once the above discussion is done. Thanks for the suggestion.

@yoongon thanks, just FYI we plan to do release tomorrow (Wednesday)

Hi @zroubalik
I updated patch.
Cause I am not familiar with e2e, It takes time. However, I think we can move in parallel.
Could you please check this change first?
Thanks

Hi All. I guess my own is ready. Please review this one :)
Thanks

@yoongon could you please check static checks? There are some undefined objects in e2e tests

Hi @zroubalik  Thanks for the feedback.

I saw the error messages, but I think those methods are not related with this change.
Am I missing something? Please correct me if I am wrong

Hi @zroubalik Thanks for the feedback.  I saw the error messages, but I think those methods are not related with this change. Am I missing something? Please correct me if I am wrong

@yoongon you updated these files, could you please double check?

/run-e2e

/run-e2e sequential

/run-e2e sequential

/run-e2e sequential

/run-e2e sequential

/run-e2e sequential

Hi @zroubalik

Hi. I think different help string causes error
I uploaded again.

Hi All.
As you can see the above, e2e keeps failing. That is because two same metrics with different labels(so/sj) are not compatible.
Therefore, I am planing to roll it back again to unify the metric with extra label.
I guess all of you already remember our previous discussion.
Unfortunately, the discussion seems to be disappeared after rebasing the change.
If there is no other opinion, I will take the first approach by unifying metrics with extra label!
Thanks all!

https://github.com/kedacore/keda-docs/pull/1263
Updated it!

/run-e2e sequential

prometheus_metrics_test.go:485: metric not available

The same problem for opentelemetry e2e test

Thanks
https://github.com/kedacore/keda/pull/4913/commits/013751c0adc06e070a7955cd0ced26b96bf149c4
I assume that this change will fix the above error.

/run-e2e sequential

/run-e2e sequential

E2E test failed, and I have one question.

I just changed wrongScaledObjectName and didn't touch scaledObject test logic. However, it fails like the above.
I guess scaledJob is failing with the similar reason.
Any idea?
Thanks!

let me trigger them again (I've updated your branch with latest changes). We have fixed some flaky e2e tests

/run-e2e

@yoongon do we have an update here please? So we can finally merge your contribution :)

your

Thanks! I am checking it.
BTW, I am confused for one thing.
Changing to use "assert" will resolve the e2e failure?
If that is it's simple to change, but the comment looks like the metric name should be changed together.
could you check?

your

Thanks! I am checking it. BTW, I am confused for one thing.
Changing to use "assert" will resolve the e2e failure?
If that is it's simple to change, but the comment looks like the metric name should be changed together.
could you check?

Please do both changes, assert improves the test failure propagation in e2e test output. Then there's the incosistency with the metric name.

your

Thanks! I am checking it. BTW, I am confused for one thing.

Changing to use "assert" will resolve the e2e failure?

If that is it's simple to change, but the comment looks like the metric name should be changed together.

could you check?

Please do both changes, assert improves the test failure propagation in e2e test output. Then there's the incosistency with the metric name.

thanks for the quick response.
I am out this week, so I will quickly update it this weekend 😄

@JorTurFer @zroubalik
I updated it. Cause e2e test result is hidden for me, so I couldn't fully know the error message.
However, I think my last commit can solve this issue.
https://github.com/kedacore/keda/pull/4913/commits/6087c8b92d3ff72829ad0fd4ee8079e4864a4ab0
Could you take this look?
I will keep alert to handle your feedback, so please let me know!

/run-e2e

Cause e2e test result is hidden for me, so I couldn't fully know the error message.

You can check them 😄
The result is included in the CI check but the link doesn't work well, but you have a direct link to the check execution in the link that the process adds into the triggering comment:

From the last execution, the results were:

If you scroll up until the test execution log, you will see the error meesage:

You can also get the execution logs as a download in the summary tab:

Thanks. I think I was confused with this one. I guess it takes time to get the full result.

Thanks @JorTurFer I was confused with this one. I guess it takes time to get the full result.

Yes, as the log is huge, it needs some time

/run-e2e sequential

e2e failed at here again.
https://github.com/kedacore/keda/blob/d3751e925e96726c6b1a4152d3f1140e7f8e01a0/tests/sequential/opentelemetry_metrics/opentelemetry_metrics_test.go#L379
Hi @JorTurFer
Like the above code, I guess keda_scaledjob_errors_total  is valid.
BTW, cause I don't know how it is created, I am deeploy diving deep into the detail now.
Do you have any idea on it? It will be a great help for me fix it.
Thanks!

/run-e2e sequential

/run-e2e sequential

@yoongon does it pass for you locally? There are still failures in both prom and otel metrics e2e tests?

@yoongon does it pass for you locally? There are still failures in both prom and otel metrics e2e tests?

Hi @zroubalik
Is there any way to run e2e test on my local?
If you share it, i will really appreciate it.
BTW, the error is from here(only for otel?? even prom test seems fail, there isn't no clearly related error message I guess)

Hi @JorTurFer
I think error is coming from here
https://github.com/kedacore/keda/pull/4913/files#diff-d696b11fc649daa9d9f875b32e54c5766a78622138a6458f9a4b1386501e14d3R477
This is related with our last discussion. Could you check again?

@yoongon sure, there's also problem in prom e2e tests in the same metric, it is not properly wrapped in assert so it is not so visible

To run locally:

You need to build your version of KEDA, it is easy: https://github.com/kedacore/keda/blob/main/BUILD.md#custom-keda-as-an-image
Then setup tests: https://github.com/kedacore/keda/tree/main/tests#running-tests
Run individual tests on your machine against the KEDA & your k8s cluster

@yoongon sure, there's also problem in prom e2e tests in the same metric, it is not properly wrapped in assert so it is not so visible
To run locally:

You need to build your version of KEDA, it is easy: https://github.com/kedacore/keda/blob/main/BUILD.md#custom-keda-as-an-image
Then setup tests: https://github.com/kedacore/keda/tree/main/tests#running-tests
Run individual tests on your machine against the KEDA & your k8s cluster

Thanks for this sharing. I will try and fix!

Hi  I found one thing.
https://github.com/kedacore/keda/blob/531dd6db9b5ce55283dfbba8803a6f3e954c4625/pkg/metricsservice/server.go#L47
https://github.com/kedacore/keda/blob/531dd6db9b5ce55283dfbba8803a6f3e954c4625/pkg/scaling/scale_handler.go#L62
I think I should have change this one together. I guess this was the reason why ScaledJob metrics haven't been captured.
(BTW, I haven't set up e2e on my local, but I strongly guess this is the root cuase)
However, There are some difference between  GetScaledObjectMetrics and getScaledJobMetrics
https://github.com/kedacore/keda/blob/531dd6db9b5ce55283dfbba8803a6f3e954c4625/pkg/scaling/scale_handler.go#L423
https://github.com/kedacore/keda/blob/531dd6db9b5ce55283dfbba8803a6f3e954c4625/pkg/scaling/scale_handler.go#L756
If I updated it together, the change might become huge and take a time.
@JorTurFer @zroubalik
Do you want me to update it here? or separate PR?
Thanks again for all the support

Hi all.
For about the above comment, I've just made this PR(https://github.com/kedacore/keda/pull/5349)
Let's check it first :)

@zroubalik Thanks for checking. I should have known this one. I closed that PR.
BTW, cause e2e build is not working properly on my local machine, it drags me down.
If you see any missing point on this PR, it will really be appreciated.
I am focusing on e2e now for more debugging.

I'm deploying the code into my cluster, I'll give you some feedback about the problem soon

You didn't register the metric in Prometheus server:
https://github.com/kedacore/keda/blob/main/pkg/metricscollector/prommetrics.go#L160-L177
That's why now it's not available

You probably need to add also a metric record for the jobs here:
https://github.com/kedacore/keda/blob/6c1a67d1435e0926280d490e4b2a2bb7b61e534a/pkg/scaling/scale_handler.go#L821-L822
You can do it adding the line metricscollector.RecordScaledJobError(scaledJob.Namespace, scaledJob.Name, err)

/run-e2e sequential

@JorTurFer
Thank you so much for the checking.
TBH, I had registered it but i missed after rolled it back a few times. Eventually I forgot.
Thanks again and I've just updated it

e2e failed here.
I changed metric name to the original one.
We did a discussion a lot, so I might be confusing to you.
BTW, if you have any concern about the metric name, please let me know again.

/run-e2e sequential

Some issue seems related with time.Sleep between creating and deleting wrong scaled resource.
I've just added this commit
https://github.com/kedacore/keda/pull/4913/commits/44ffcae8061de7a47845afadb8de60d856fdf438

/run-e2e sequential

Looks like final error on e2e.
I think the[ last commit ](https://github.com/kedacore/keda/pull/4913/commits/8cc29a94ab10ffd6b18fe677e646f48821af56f7)will fix it.

/run-e2e sequential


Custom CA certs are not activated on the node

How to categorize this issue?

/area ops-productivity
/kind bug
/priority normal
What happened:
The cluster CA certificate is installed in the /etc/ssl/certs/ROOTCerts.pem file but it is not activated and missing in the /etc/ssl/certs/ca-certificates.crt
Looking into the logs of the service
$ journalctl -u updatecacerts
-- Logs begin at Wed 2020-11-04 18:36:59 UTC, end at Wed 2020-11-04 19:01:54 UTC. --
Nov 04 18:37:51 ip-10-222-29-135 systemd[1]: Starting Update CA bundle at /etc/ssl/certs/ca-certificates.crt...
Nov 04 18:37:51 ip-10-222-29-135 update-ca-certificates[1247]: Updating certificates in /etc/ssl/certs...
Nov 04 18:37:52 ip-10-222-29-135 update-ca-certificates[1247]: 0 added, 0 removed; done.
Nov 04 18:37:52 ip-10-222-29-135 update-ca-certificates[1247]: Running hooks in /etc/ca-certificates/update.d...
Nov 04 18:37:52 ip-10-222-29-135 update-ca-certificates[1247]: done.
Nov 04 18:38:01 ip-10-222-29-135 systemd[1]: updatecacerts.service: Succeeded.
Nov 04 18:38:01 ip-10-222-29-135 systemd[1]: Finished Update CA bundle at /etc/ssl/certs/ca-certificates.crt.
Nov 04 18:38:08 ip-10-222-29-135.eu-west-1.compute.internal systemd[1]: Condition check resulted in Update CA bundle at /etc/ssl/certs/ca-certificates.crt being skipped.

It is executed, but no certificates are added.
While I am on the node, running
$ update-ca-certificates
Updating certificates in /etc/ssl/certs...
0 added, 0 removed; done.
Running hooks in /etc/ca-certificates/update.d...
done.

again does not add the custom certificates.
But using the option --fresh it re-adds all certificates including the custom one
$ update-ca-certificates  --fresh
Clearing symlinks in /etc/ssl/certs...
done.
Updating certificates in /etc/ssl/certs...
127 added, 0 removed; done.
Running hooks in /etc/ca-certificates/update.d...
done.

What you expected to happen:
Custom CA certs from the cloudprofile or worker spec and the cluster CA cert to be activated on the nodes.
How to reproduce it (as minimally and precisely as possible):
Create a cluster with Garden Linux or Ubuntu (SuSE nodes are not affected) and curl the cluster API - it should fail to verify the cert issuer
$ curl https://api.foo.bar.shoot.example.com
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

If the certs are properly activated, the curl should succeed
$ curl https://api.foo.bar.shoot.example.com
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {

  },
  "status": "Failure",
  "message": "Unauthorized",
  "reason": "Unauthorized",
  "code": 401
}

Anything else we need to know?:
Environment:

Gardener version: v1.12.4
Kubernetes version (use kubectl version): v1.18.9
Cloud provider or hardware configuration: Seen on AWS and OpenStack, but should be the same on all cloudproviders.
Others:

I don't think that this has fixed the issue.
In order to have running update-ca-certificates (with or without --fresh) any effect (on debian'ish OS such as gardenlinux), at least one of the following conditions would have to be fulfilled:

the certificate is stored in /usr/share/ca-certificates and the according filename is listed in /etc/ca-certificates.conf
the certificate is stored in /usr/local/share/ca-certificates with a file suffix .crt

Just adding it to some file such as ROOTcerts.pem in /etc/ssl/certs is useless.


Initial support for external memory in gradient index.

Add hessian to batch param in preparasion of new approx impl.
Extract a push method for gradient index matrix.
Use span instead of vector ref for hessian in sketching.
Create a binary format for gradient index.

@ShvetsKS Would you like to take a look into this PR?

Codecov Report

Merging #7183 (bde272a) into master (3a4f51f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7183      +/-   ##
==========================================
- Coverage   82.67%   82.63%   -0.05%
==========================================
  Files          13       13
  Lines        4017     4019       +2
==========================================
  Hits         3321     3321
- Misses        696      698       +2

Impacted Files
Coverage Δ

python-package/xgboost/data.py
69.74% <0.00%> (-0.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4f51f...bde272a. Read the comment docs.


Experiment logs

Could you please provide the logs of the full configuration in NuScenes and Argoverse as a reference? Looking forward to your reply. Thanks!

Thanks for your suggestion. We've added logs for all major experiments in this commit. Now you can access them in README.


Add Codesandbox CI

What's the purpose of this pull request?
The goal of this CI is to make it easier for you to test faststore packages without publishing to npm yet.
How it works?
Every push event generates a build in codesandbox. This build will publish a version in codesandbox registry. To acces the published version and use it in your prs:

Wait for the Codesandbox CI to finish its job
Click on the here link. This will take you to codesandbox

On the right hand side, you will find a box called local install instructions.

Copy the install instructions and paste on one of our store's repo.

The changes I had to do to make this CI to work is that I had to remove the prepare script for all packages to avoid building twice and thus breaking concurrent builds. Also, I've removed the github action build step, since we are already doing this on codesandbox.
How to test it?
Go to a store and make sure you can install the built packages
References
Spread the knowledge: is there any content you used to create this PR that is worth sharing?
Extra tip: adding references to related issues or mentioning people important to this PR may be good for the documentation and reviewing process

Nice!!


docs: More March updates

DS-728 Bootstrap button changes
DS-910 Event recurrences

Thanks @podarok but I'm still working 😄

I know, and decided to do an action on the commit message in Jira, that made me smile, instead of just closing the browser's tab


model.cpp:16: fatal error: ggml-cpu.h: No such file or directory

Quite likely I'm doing something wrong in my build but I'm seeing this error:
model.cpp:16: fatal error: ggml-cpu.h: No such file or directory
Is there's a missing file from the repo? I can see the include was added recently
#include "ggml-cpu.h"
commit

Ah - my error - I hadn't updated the ggml sub module!


css fixed

Problem was identified using the scientific method.
Solution was assessed using brute force and a new technique we employed that allow for rapid solution testing. Techique is called Random Class Tweaks.
Please proceed with extensive testing before making it live.

Dear Nikitas ,
Thank you kindly for your contribution. After extensive testing we concluded this mr is suitable for merging.
Thank you for your contribution, we'd love to have you come back and contributing more to our project which we work on with passion.
We're really passionate and I
hope we're gonna have on board again in the future. Thanks for the contribution again!
Kind regards,
Filippos from Fready

This message was written only using recycled materials and green energy with carbon free emissions (by 2050)


feat(query) add $sqs simple_query_string query

Summary
In this pull request I have added the simple_query_string query to the adapter.
Open to suggestions on how to improve it, I tried to leave as much flexibility to the query as possible.

This looks great, thank you! Could you also make a pull request with the documentation you added against https://github.com/feathersjs/feathers-docs/blob/master/api/databases/elasticsearch.md? I'll let @jciolek if he has time otherwise I'll release it tomorrow.

Hey, thanks a lot for your contribution! I know I'm late to the party and I apologise, I just found one tiny snag, do you think you could take care of it?
Also, would be great if you could add a test for $sqs in "should return all types of queries together".
Thanks again,
Jacek

Sure thing, I'll try to get a PR in for those by Monday if I can.
No problem.

Sounds good. I'll make it a new patch release once it is up. Can we merge the docs in https://github.com/feathersjs/feathers-docs/pull/650 already though?

I've just added one more comment, @Mattchewone it would be great if you accommodate that as well. @daffl - then I guess we could merge the docs as well.
How does that sound?

Thank you! Merged the docs and released as v0.3.1.
From the sky somewhere over Greenland ✈


Clear the transaction context in TCC prepare methed

#1194

Codecov Report

Merging #1195 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop    #1195      +/-   ##
=============================================
- Coverage      43.42%   43.39%   -0.04%
  Complexity      1428     1428
=============================================
  Files            250      250
  Lines          10224    10227       +3
  Branches        1333     1333
=============================================
- Hits            4440     4438       -2
- Misses          5202     5205       +3
- Partials         582      584       +2

Impacted Files
Coverage Δ
Complexity Δ

...java/io/seata/spring/tcc/TccActionInterceptor.java
12.82% <0%> (-1.07%)
2 <0> (ø)

...server/store/file/FileTransactionStoreManager.java
45.64% <0%> (-0.7%)
19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee5c32...db3143a. Read the comment docs.


fix(settings): About links

@limpbrains Can you test the mailto link on iPhone please? On the simulator there is no mail app for testing


Add support Laravel 6.0

Add support Laravel 6.0

@khanhvu14 You have to also update orchestra/testbench and other dev dependencies, else the tests aren't actually testing against Laravel 6.0

Version 6.0 of the package has just been released.  Try that and let me know if there are any issues.