Debugging errors in batched updates

When flattenStyle throws here, I get a cryptic stack trace that doesn't let me figure out what's going wrong.
How am I expected to debug this?
Here's the stack trace:
Error: style may be false but not true

    file: /Users/aleclarsoniv/dev/modules/react-native/Libraries/StyleSheet/flattenStyle.js
    method: flattenStyle
    line: 30
    column: 0

    file: /Users/aleclarsoniv/dev/modules/react-native/Libraries/ReactNative/ReactNativeAttributePayload.js
    method: diffNestedProperty
    line: 77
    column: 0

    file: /Users/aleclarsoniv/dev/modules/react-native/Libraries/ReactNative/ReactNativeAttributePayload.js
    method: diffProperties
    line: 210
    column: 0

    file: /Users/aleclarsoniv/dev/modules/react-native/Libraries/ReactNative/ReactNativeAttributePayload.js
    method: addProperties
    line: 270
    column: 0

    file: /Users/aleclarsoniv/dev/modules/react-native/Libraries/ReactNative/ReactNativeAttributePayload.js
    method: Object.ReactNativeAttributePayload.create
    line: 291
    column: 0

    file: /Users/aleclarsoniv/dev/modules/react-native/Libraries/ReactNative/ReactNativeBaseComponent.js
    method: ReactNativeBaseComponent.Mixin.mountComponent
    line: 226
    column: 0

    file: /Users/aleclarsoniv/dev/modules/react-native/node_modules/react-tools/src/renderers/shared/reconciler/ReactReconciler.js
    method: Object.ReactReconciler.mountComponent
    line: 38
    column: 0

    file: /Users/aleclarsoniv/dev/modules/react-native/node_modules/react-tools/src/renderers/shared/reconciler/ReactCompositeComponent.js
    method: ReactCompositeComponentMixin.mountComponent
    line: 241
    column: 0

    file: /Users/aleclarsoniv/dev/modules/react-native/node_modules/react-tools/src/test/ReactPerf.js
    method: wrapper [as mountComponent]
    line: 71
    column: 0

Note: The line numbers are probably fudged due to my debugging calls to console.log.

I'm sure you've figured it out but I had the same issue tonight. In my case it was because I had a 'style' property on a tag but never included a style ie <View style=>

Hi there! This issue is being closed because it has been inactive for a while.
If you'd like you can create an issue on Product Pains.
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix. We rely on the community to provide
bug fixes as the core team is focused on performance. Thanks!


Error on Apple M1 chip

when running python install.py --neurips23track filter    --algorithm faiss and after waiting for 40 minutes, it finally output:
What's Next?
  View summary of image vulnerabilities and recommendations → docker scout quickview
Building algorithm images... with (1) processes
Building neurips23-filter-faiss...
docker build  --rm -t neurips23-filter-faiss -f neurips23/filter/faiss/Dockerfile .
[+] Building 1413.5s (8/15)                                                                                docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 990B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 103B                                                                                0.0s
 => [internal] load metadata for docker.io/library/neurips23:latest                                                                                0.0s
 => [ 1/11] FROM docker.io/library/neurips23                                                                                0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 4.86kB                                                                                0.0s
 => [ 2/11] RUN apt update && apt install -y wget swig                                                                                22.7s
 => [ 3/11] RUN wget https://repo.anaconda.com/archive/Anaconda3-2023.03-0-Linux-x86_64.sh                                                                                1388.3s
 => ERROR [ 4/11] RUN bash Anaconda3-2023.03-0-Linux-x86_64.sh -b                                                                                2.3s
------
 > [ 4/11] RUN bash Anaconda3-2023.03-0-Linux-x86_64.sh -b:
0.163 PREFIX=/root/anaconda3
2.243 Unpacking payload ...
2.246 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory
------
Dockerfile:5
--------------------
   3 |     RUN apt update && apt install -y wget swig
   4 |     RUN wget https://repo.anaconda.com/archive/Anaconda3-2023.03-0-Linux-x86_64.sh
   5 | >>> RUN bash Anaconda3-2023.03-0-Linux-x86_64.sh -b
   6 |
   7 |     ENV PATH /root/anaconda3/bin:$PATH
--------------------
ERROR: failed to solve: process "/bin/sh -c bash Anaconda3-2023.03-0-Linux-x86_64.sh -b" did not complete successfully: exit code: 255

Install Status:
{'neurips23-filter-faiss': 'fail'}

Could you try the suggested solutions here: https://stackoverflow.com/questions/71040681/qemu-x86-64-could-not-open-lib64-ld-linux-x86-64-so-2-no-such-file-or-direc? In particular, try adding --platform=linux/amd64 to our base image.
I'm not sure whether the whole setup will make much sense from a performance point of view, since you will emulate x86 on your ARM-based CPU, but for testing it should probably work.

@LysanderT Confirming that the issue exists on my M1 laptop.
If what @maumueller suggested does not work, please let us know and we will try to come up with a way to run things locally   on an M1 laptop for this track.
Also, I would suggest testing on a linux VM (and an intel CPU).

Hey, just to say that at least for the sparse track --platform=linux/amd64 made it work (even if it is kinda slow). I can make a pull request later showing how I did it.
Also, I expect to send a pull request soon (hopefully tomorrow?) with our entry for the sparse track with 3 measurements to try to give you an idea of the differences (azure, my M1 and our best CPU server)


[Feature/extensions] Renaming to match merge to main branch

Signed-off-by: Ryan Bogan<EMAIL_ADDRESS>Description
Renames classes, methods, and variables to match the merge to main branch
Companion PR on opensearch-sdk-java: https://github.com/opensearch-project/opensearch-sdk-java/pull/276
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks like main needs to be merged into feature/extensions before this can be merged.

Codecov Report

Merging #5362 (f79ac90) into feature/extensions (b49e2af) will increase coverage by 0.05%.
The diff coverage is 85.45%.

@@                   Coverage Diff                    @@
##             feature/extensions    #5362      +/-   ##
========================================================
+ Coverage                 70.97%   71.02%   +0.05%
+ Complexity                58486    58460      -26
========================================================
  Files                      4756     4756
  Lines                    278926   278931       +5
  Branches                  40283    40281       -2
========================================================
+ Hits                     197964   198107     +143
+ Misses                    64810    64609     -201
- Partials                  16152    16215      +63

Impacted Files
Coverage Δ

...nsearch/discovery/InitializeExtensionsRequest.java
0.00% <0.00%> (ø)

.../opensearch/extensions/DiscoveryExtensionNode.java
90.00% <ø> (ø)

...rch/extensions/rest/RestSendToExtensionAction.java
28.37% <ø> (ø)

.../opensearch/extensions/ExtensionsOrchestrator.java
67.02% <84.84%> (+0.36%)
:arrow_up:

...ava/org/opensearch/transport/TransportService.java
82.20% <90.90%> (-0.28%)
:arrow_down:

...h/extensions/AddSettingsUpdateConsumerRequest.java
75.00% <100.00%> (ø)

...sions/AddSettingsUpdateConsumerRequestHandler.java
65.21% <100.00%> (ø)

...ch/extensions/ExtensionNamedWriteableRegistry.java
50.00% <100.00%> (ø)

...sions/action/ExtensionTransportActionsHandler.java
72.58% <100.00%> (ø)

...rch/extensions/rest/RestActionsRequestHandler.java
100.00% <100.00%> (ø)

... and 475 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ryanbogan looks like we did rename quite a few, wouldn't this need a companion PR on SDK ?

@ryanbogan looks like we did rename quite a few, wouldn't this need a companion PR on SDK ?

Right I forgot about that.  I'll start on that now.

@saratvemulapalli LGTM, thank you, I do have few comments but no need to block the merge, could be addressed later


Headers are not in alphabetical order.

Not adhering to own guidelines. 😒

Make everything alphabetical 🤗

Fixed in baa7ae46c3040fe7e9f901c057ae172a839106af


LIVY-547: Livy kills session after livy.server.session.timeout even i…

…f the session is active
Signed-off-by: Shanyu Zhao<EMAIL_ADDRESS>What changes were proposed in this pull request?
To check for session expiration, if session state is busy, always return false.
https://issues.apache.org/jira/browse/LIVY-547
How was this patch tested?
unit tests, integration tests and manual tests in a live cluster.
Please review https://livy.incubator.apache.org/community/ before opening a pull request.

Codecov Report

Merging #146 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
+ Coverage     68.59%   68.66%   +0.06%
- Complexity      904      909       +5
============================================
  Files           100      100
  Lines          5662     5664       +2
  Branches        848      849       +1
============================================
+ Hits           3884     3889       +5
+ Misses         1225     1223       -2
+ Partials        553      552       -1

Impacted Files
Coverage Δ
Complexity Δ

...cala/org/apache/livy/sessions/SessionManager.scala
82.41% <100%> (+0.39%)
25 <0> (+1)
:arrow_up:

.../scala/org/apache/livy/sessions/SessionState.scala
58.33% <0%> (-2.78%)
2% <0%> (ø)

...c/main/scala/org/apache/livy/repl/ReplDriver.scala
30.76% <0%> (-2.57%)
7% <0%> (ø)

...ain/java/org/apache/livy/rsc/driver/RSCDriver.java
80.08% <0%> (+2.11%)
43% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9b453...0005ad6. Read the comment docs.

as mentioned in the other PR for this issue. I think we do need a new config for this: https://github.com/apache/incubator-livy/pull/138#issuecomment-457338491


Order problems with @Mixins, @Parameters and @Command-annotated methods

Using: Java 17, Picocli 4.7.0
If I have this code (inside a class getting passed to CommandLine::execute):
// This will have TWO MANDATORY arguments
@Command public void retrieve(@Mixin SourceParam source, @Parameters File targetFolder) {
    // implementation unimportant...
}

public static class SourceParam implements Supplier<Descriptor> {
    @Parameters(converter = Converter.class)
    private Descriptor source;

    @Override public Descriptor get() {
        return source;
    }

    static class Converter implements ITypeConverter<Descriptor> {
        @Override public Descriptor convert(String filename) throws IOException {
            try (var reader = new FileReader(filename, UTF_8)) {
                return new Descriptor(reader); // Or whatever way you like to parse things...
            }
        }
    }
}

Then the targetFolder positional argument is being presented as part of the command line arguments ahead of the source positional argument. This is highly unexpected! I expected the source to be the first argument and the targetFolder to be the second.
Note that there cannot be ambiguities about the order of @Parameters within the mixed in class (there's only one in there) or about the relative order of them in the command (arguments to method have a definite, fixed order).

I'm using this in a situation where I have many subcommands with quite complicated real @Parameters (to the point where I really want to share them) and the absolute indices of the specific arguments are not constant because they're not all used by all subcommands. I can't convert to using options; this is replacing code that's already in the wild.
I expected the @Mixin-annotated argument to just act as if its provided @Parameters-annotated element was inserted in place. The reordering was not something I expected from the documentation!
@ArgGroup(multiplicity = "1") instead of @Mixin seems to be a workaround for this.

Urgh. Further investigation has indicated that @ArgGroup(multiplicity = "1") doesn't work. The only thing that seems to work is specifying an explicit index in the @Parameters that isn't part of a mixin. That's especially important if the argument is to be positional and optional, because otherwise your PositionalParametersSorter sabotages everything.

@dkfellows You may have run into one of the limitations of the framework.
One idea is to drop the use of Mixins and live with the duplication of the positional parameter declaration.
In terms of improving picocli to handle this, I am currently not in a position to spend much time to work on picocli. So you would need to drive this. I am happy to review quality pull requests that include tests and ideally documentation.

Note to self: as mentioned in https://github.com/SpiNNakerManchester/JavaSpiNNaker/pull/684,
the issue is that under some circumstances positional parameters are sorted by arity.


Create External Table, Error Msg110813 (Unknown type Timestamp at GetSqlTypeId.)

Tutorial: Load Table to Azure SQL Data Warehouse
Trying to run the scripts and when I run the following I got an Error Msg 110813, Level 16, State 1, Line 1
Unknown type Timestamp at GetSqlTypeId.
CREATE EXTERNAL TABLE [dbo].[Appointmentreason]
(
[CUSTOMERID] [decimal](38, 0) NULL,
[APPOINTMENTREASONGUID] nvarchar NULL,
[APPOINTMENTREASONID] [decimal](38, 0) NULL,
[DEFAULTDURATIONMINUTES] [decimal](38, 0) NULL,
[DESCRIPTION] nvarchar NULL,
[MODIFIEDDATE] [datetime2] NULL,
[NAME] nvarchar NULL,
[PRACTICEID] [decimal](38, 0) NULL
)
WITH (DATA_SOURCE = [DS_PMB_SnowFlake],LOCATION = N'APPOINTMENTREASON')
GO
I am using "SnowflakeDSIIDriver"
CREATE EXTERNAL DATA SOURCE [DS_PMB_SnowFlake] WITH (LOCATION = N'odbc://xxx.snowflakecomputing.com')
Kindly request any suggestion

Below is snowflake Structure & issue is in MODIFIEDDATE column:

@devang7273 Thank you for sharing your feedback! Since this channel is for driving improvements towards MS Docs, could you provide us with a specific URL of the MS Doc that your feedback is most applicable to? That way, we're able to connect you with the right team that's best fit to address your feedback.

It is regarding SQL Data Warehouse - Polybase
https://docs.microsoft.com/en-us/azure/sql-data-warehouse/load-data-from-azure-blob-storage-using-polybase#create-external-tables-for-the-sample-data
I hope this will be enough.
Thanks

I think this is wrong place for my query.
Thanks,


How to use totalcontrastiveVI?

Hi, do we have tutorials for totalcontastiveVI? Thanks.

Hi! Currently we don't have a publicly available tutorial, but I can create a notebook based on the ECCITE-seq analysis from our paper- I should have the notebook ready by sometime next week.

Thanks, I actually have successfully reproduced your work for running totalcontrastiveVI and TotalVI, based on your contrastive-vi reproduce folder.
I actually further have a question about running totalvi:
https://github.com/suinleelab/contrastiveVI-reproducibility/blob/43efaab1990410179f0005ba8c6dd411cc8789a4/scripts/run_experiment.py#L356C1-L361C14
It seems that you did not include any observation variables (like replicate as a key in batch) for running totalvi, and I guess it is th reason why totalvi is confounded by replicates or cell cycles. Do you think it is a reasonable inference? Thanks.

Great question! We actually explored this question in depth in Supplementary Note 9 from the contrastiveVI manuscript (https://static-content.springer.com/esm/art%3A10.1038%2Fs41592-023-01955-3/MediaObjects/41592_2023_1955_MOESM1_ESM.pdf).
In short: we found that including these additional covariates did somewhat mitigate the issues with running totalVI naively. However, there was still increased confounding by cell cycle/replicate/etc. compared to totalContrastiveVI, and separation of the perturbation groups was worse than with totalContrastiveVI (see e.g. the IRF1 cells in Supplementary Figure 31). Also, this workflow (i.e., providing totalVI with covariates), assumes that all potential confounders are known a priori, while totalContrastiveVI doesn't have this requirement.


Avro Functionality

Is it possible to add avro functionality via the use of a plugin like Protobuf?

I don't know much about avro, but the protobuf plugin example would be a good template for giving it a shot.  I don't see why not.

By the way, I don't have any plans for providing plugins in this repository.  The intent is that they should be easy enough build yourself given the protobuf example.  If you try and get stuck I'll be happy to help you out.


subctl show cmd: add subctl show all

This is sub-issue of #359
See enhancement: https://github.com/submariner-io/enhancements/blob/master/submariner-operator/issue-359-subctl-info-status.md

Should we move to 0.6.0?

Should we move to 0.6.0?

If it's too late to get in 0.5.0 then yes.
The PR is ready now


How "Build Message" post?

Hi, I'm using ghprb v1.33.1 (Latest Release) with jenkins 2.22.
Build settings are almost finished.

New PR trigger build -> ok
keyword "test this please" trigger build -> ok

But, "Build Message" by Bot does not post to PR, like "SUCCESS", "ERROR", "FAILURE".
What do I need additional settings?
Maybe, my credential settings are correct. Because test post works good.

I don't know what to do 😓
Thank you!!!

Any info from the Jenkins logs?

@benpatterson
Thank you for your response 👍
"Build logs" and "Jenkins logs" are here.
Some values are masked.
Build logs
GitHub pull request #243 of commit 5cd48cdb92de97f9a0a8bb6ef6c1942baaa267e3, no merge conflicts.

[snip]

Setting status of 5cd48cdb92de97f9a0a8bb6ef6c1942baaa267e3 to SUCCESS with url http://example.com/job/xxx/21/ and message: 'Build finished. '
Finished: SUCCESS

Jenkins logs
Many of "WARNING: Skipped parameter" are written.
Sep 30, 2016 10:10:01 AM org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
INFO: Pull request #243 was updated/initialized on org/repo at 9/30/16 10:09 AM by Yoshiaki Yoshida (PR update)

[snip]

Sep 30, 2016 10:11:09 AM hudson.model.Run execute
INFO: xxx #21 main build action completed: SUCCESS
Sep 30, 2016 10:11:09 AM hudson.model.ParametersAction filter
WARNING: Skipped parameter `sha1` as it is undefined on `xxx`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters=true` to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach
Sep 30, 2016 10:11:09 AM hudson.model.ParametersAction filter
WARNING: Skipped parameter `ghprbActualCommit` as it is undefined on `xxx`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters=true` to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach
Sep 30, 2016 10:11:09 AM hudson.model.ParametersAction filter
WARNING: Skipped parameter `ghprbActualCommitAuthor` as it is undefined on `xxx`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters=true` to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach
Sep 30, 2016 10:11:09 AM hudson.model.ParametersAction filter
WARNING: Skipped parameter `ghprbActualCommitAuthorEmail` as it is undefined on `xxx`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters=true` to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach
Sep 30, 2016 10:11:09 AM hudson.model.ParametersAction filter
WARNING: Skipped parameter `ghprbAuthorRepoGitUrl` as it is undefined on `xxx`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters=true` to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach
Sep 30, 2016 10:11:09 AM hudson.model.ParametersAction filter
WARNING: Skipped parameter `ghprbTriggerAuthor` as it is undefined on `xxx`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters=true` to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach
Sep 30, 2016 10:11:09 AM hudson.model.ParametersAction filter

[snip]

Other logs are needed?
Thanks.

Anyone can help?

Hi @kakakakakku
I'd like to help, but think I need more information. Could you give me some steps or configuration settings to use, where I could reproduce the problem on a local instance of Jenkins?

@benpatterson
Thank you for your supports!
I wish my issue solve.

Could you give me some steps or configuration settings to use, where I could reproduce the problem on a local instance of Jenkins?

OK, here are my setup steps.
Is it enough?
There steps can reproduce also on Vagrant.
Provisions
At first, I installed Jenkins using by Chef with community cookbook.

https://github.com/chef-cookbooks/jenkins
https://supermarket.chef.io/cookbooks/jenkins/versions/2.6.0

And I updated /etc/passwd jenkins entry from /bin/false to /bin/bash.
Jenkins Setups
Then, I installed some plugins with "Install suggested plugins" menu.
So, some plugins are automatically installed without ghprb.
Next, I installed "GitHub Pull Request Builder" manually.
Manage Jenkins -> Configure System

GitHub Pull Request Builder

GitHub Auth

Try "Test adding comment to Pull Request", then it's ok!

Jobs
I created Jenkins Job named "ci" with FreeStyle.

General

GitHub project

https://github.com/${org}/${repo}

Source Code

Git

Repositories

git@github.com:#{org}/${repo}.git

Branches

${sha1}

Build Trigger

GitHub Pull Request Builder

It's all!

Thanks !
I tried setting https url, but it does not work for me.
Job is triggered automatically by PR.
But build comment in PR done not posted.

I'm still does not work.
Which version of ghprb is work good?
My server spec is bellow.

Hi, I'm using ghprb v1.33.1 (Latest Release) with jenkins 2.22.

@kakakakakku We solved an issue on the latest release that might have been manifesting itself in this way. Could you take the latest (1.33.2) and see if you are still having problems?

@benpatterson
Hi !
Ohhhh, I updated v1.33.2 and restarted Jenkins, but still does not work for me 💦 💦 💦
Any settings are required ? 😢
Case of "test is ok"
Auto comment by bot does not exist.
This is a part of console_log.

Setting status of 5cd48cdb92de97f9a0a8bb6ef6c1942baaa267e3 to SUCCESS with url http://example.com/job/test/52/ and message: 'Build finished. '
Finished: SUCCESS

Case of "test is ng"
Auto comment by bot does not exist.
This is a part of console_log.

Setting status of 3968a5bcad8c76b8720f63d1d0aa5285b5201fa3 to FAILURE with url http://example.com/job/test/53/ and message: 'Build finished. '
Finished: FAILURE

test post works good
Still, test post works good.

Hi @kakakakakku
When you say:

But, "Build Message" by Bot does not post to PR, like "SUCCESS", "ERROR", "FAILURE".

what do you expect exactly? The plugin will NOT comment by default on the PR.
The status is reported by the messages "All checks have passed" or "All checks have failed", like you are having in your screenshots.

Sorry for late comment.
I understand for feature of this plugin.

The plugin will NOT comment by default on the PR.

Thanks, and close it !


Add pixel mask to ElboDeriv.jl

In order to read real frames which sometimes have bad pixels, we need to be able to assign zero weights to certain pixels in ElboDeriv.

How about storing NaN in the image as the value for corrupted pixels? (The type of NaN is Float64.) That way we don't need a separate data structure to store whether pixels are good or bad.

That's a great idea.  Let's leave this issue open because we'll still need to add the NaN checking to ElboDeriv.


Improved the shield handling (1.9->1.8)

This should fix a problem where the shield appears while players use a bow (switching to a bow quicky while holding a sword), or at least it reduces that possibility.

Looks fine, thanks for your help :)


net: Change the DEBUGASSERT to WARNING log for the tcp_pollsetup.

Summary
Change the DEBUGASSERT to WARNING log for the tcp_pollsetup.
In libuv, if the real_timeout in the uv__io_poll is less than 0, the poll logic will be entered directly by the uv__run_timers, which will trigger the ASSERT. It seems that the situation of first epoll and then poll for the same fd is used in libuv, and the case is allowed in Linux.
Impact
We can perform the epoll and then poll operations on the same tcp fd.
Testing
I just used the app, which accessed an http web page through the fetch interface for testing. In this process, the application established a tcp connection by calling libuv and libcurl.
After the modification, this test can pass.

@anchao Please help to see. After enabling epoll in libuv, this assert problem occurs.


feat: 🎸 indeterminate checkbox

👋 Thanks for creating a pull request! 🚀 Checkout the storybook we've created for it: chlorophyll


[Core] Improve module creation documentation - Issue #509

Description
This PR aims at improving the documentation around modules, the way we use them and some of the conventions/architectural choices.
Issue
Fixes #509
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[x] Documentation
[ ] Other

List of changes

Updated README
Added GoDoc comments

Required Checklist

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[ ] I have tested my changes using the available tooling
[ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@bryanchriswhite, @h5law, @dylanlott : Hey guys!
If you have time, I think it would be very beneficial if you could look at this PR aimed at improving the documentation around our modules.
Any improvement/feedback would speed up the onboarding of new contributors so I'd like this to be a collaborative effort, also my language might not be the clearest, possibly due to the fact that I have spent the first 31 years of my life eating pasta on a daily basis and moving my hands erratically (often at the same time) 🇮🇹 .
Obviously, I am not expecting you to take a look but I would appreciate it a lot if you did 😄
@Olshansk: of course, your feedback is somewhat required, I am ready for the 🍅 harvest

Any improvement/feedback would speed up the onboarding of new contributors so I'd like this to be a collaborative effort, also my language might not be the clearest, possibly due to the fact that I have spent the first 31 years of my life eating pasta on a daily basis and moving my hands erratically (often at the same time) it .

@deblasis 🤌  I will take a  👀 now

@Olshansk I have addressed the comments. PTAL


Published nuget packages are windows only

This is really a dupe of #3417 but I wanted to spell out the exact consequences of this problem  and maybe encourage the team to create unix-compatible nuget packages for the GA 6.0.1 release.
The problem is in the #ifdef UNIX that we have.
The nuget packages published to myget only has windows binaries which are compiled without UNIX define (obviously).
That leads to runtime failures when trying to host powershell inside dotnet core application on linux and mac, such as https://github.com/Jaykul/Jupyter-PowerShell .
Steps to reproduce
Create a simple application that uses InitialSessionState
using System.Management.Automation.Runspaces;

namespace MygetDemo {
    public class ISSDemo {
        public static void Main(string[] args) {
            var iss = InitialSessionState.CreateDefault2();
        }
    }
}

With csproj file to build it
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFrameworks>netcoreapp2.0</TargetFrameworks>
    <OutputType>Exe</OutputType>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="System.Collections.NonGeneric" Version="4.3.0" />
    <PackageReference Include="Microsoft.PowerShell.SDK" Version="6.0.0" />
  </ItemGroup>
</Project>

Run it with
dotnet restore
dotnet run --framework=netcoreapp2.0

Expected behavior
No error
Actual behavior
Microsoft (R) Build Engine version <IP_ADDRESS>473 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 38.48 ms for /Users/vors/dev/powershell-host-demo/Demo.csproj.

Unhandled Exception: System.TypeInitializationException: The type initializer for 'System.Management.Automation.Runspaces.InitialSessionState' threw an exception. ---> System.TypeInitializationException: The type initializer for 'System.Management.Automation.Utils' threw an exception. ---> System.TypeInitializationException: The type initializer for 'Microsoft.Win32.Registry' threw an exception. ---> System.PlatformNotSupportedException: Registry is not supported on this platform.
   at Microsoft.Win32.RegistryKey.OpenBaseKeyCore(RegistryHive hKey, RegistryView view)
   at Microsoft.Win32.Registry..cctor()
   --- End of inner exception stack trace ---
   at System.Management.Automation.Platform.get_IsNanoServer()
   at System.Management.Automation.Platform.get_IsInbox()
   at System.Management.Automation.Utils..cctor()
   --- End of inner exception stack trace ---
   at System.Management.Automation.Runspaces.InitialSessionState..cctor()
   --- End of inner exception stack trace ---
   at System.Management.Automation.Runspaces.InitialSessionState.CreateDefault2()
   at MygetDemo.ISSDemo.Main(String[] args) in /Users/vors/dev/powershell-host-demo/Program.cs:line 6

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0
PSEdition                      Core
GitCommitId                    v6.0.0
OS                             Darwin 17.3.0 Darwin Kernel Version 17.3.0: Thu Nov  9 18:09:22 PST 2017; root:xnu-4570.3...
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

The failure comes from this code
https://github.com/PowerShell/PowerShell/blob/beffdcf94d00b51d9339bb26dbc0e477cd147c92/src/System.Management.Automation/CoreCLR/CorePsPlatform.cs#L68-L93

@adityapatwardhan or is this the bug you fixed in the Myget packages?

This will be fixed when #6167 is merged and the new Nuget Packages are released.


Better support for boolean values with Change matcher

require 'spec_helper'

describe RSpec::Matchers::Change do
  it "passes successfully wrong change" do
    @a = true
    lambda {
      @a = 1
    }.should change { @a }.from(true).to(false)
  end
end

That test should fail, but it passes. This bug was also affecting rspec 2, but was fixed with https://github.com/rspec/rspec-expectations/commit/ecd24f595d7e785dcc9abf60bd0489bb41f5a12d.
This is a backport of that fix.

@dchelimsky Any chance you'd pull this and release? We're still on rails 2.3 and rspec 1 and would be great if we didn't have to monkey patch :-)  Thanks!

As I said in #53, I don't know when I'll have time for this. You don't have to monkey patch if you're using bundler - just point to github.


BlitzApi fails to start on fresh sd card image for Setup

I want to test the blitzapi for setup - so I take a fresh sd card image and run blitz.web.api.sh on ... but the blitzapi service is in constant restart - this is the error:
positories/bitcoin.py:98> exception=ClientConnectorError(ConnectionKey(host='<IP_ADDRESS>', port=8332, is_ssl=False, ssl=None, proxy=None, proxy_auth=None, proxy_headers_hash=-5554264851534051820), ConnectionRefusedError(111, "Connect call failed ('<IP_ADDRESS>', 8332)"))>
Mar 18 10:49:54 raspberrypi sudo[66277]: Traceback (most recent call last):
Mar 18 10:49:54 raspberrypi sudo[66277]:   File "/home/admin/.local/lib/python3.9/site-packages/aiohttp/connector.py", line 986, in _wrap_create_connection
Mar 18 10:49:54 raspberrypi sudo[66277]:     return await self._loop.create_connection(*args, **kwargs)  # type: ignore[return-value]  # noqa
Mar 18 10:49:54 raspberrypi sudo[66277]:   File "/usr/lib/python3.9/asyncio/base_events.py", line 1056, in create_connection
Mar 18 10:49:54 raspberrypi sudo[66277]:     raise exceptions[0]
Mar 18 10:49:54 raspberrypi sudo[66277]:   File "/usr/lib/python3.9/asyncio/base_events.py", line 1041, in create_connection
Mar 18 10:49:54 raspberrypi sudo[66277]:     sock = await self._connect_sock(
Mar 18 10:49:54 raspberrypi sudo[66277]:   File "/usr/lib/python3.9/asyncio/base_events.py", line 955, in _connect_sock
Mar 18 10:49:54 raspberrypi sudo[66277]:     await self.sock_connect(sock, address)
Mar 18 10:49:54 raspberrypi sudo[66277]:   File "/usr/lib/python3.9/asyncio/selector_events.py", line 502, in sock_connect
Mar 18 10:49:54 raspberrypi sudo[66277]:     return await fut
Mar 18 10:49:54 raspberrypi sudo[66277]:   File "/usr/lib/python3.9/asyncio/selector_events.py", line 537, in _sock_connect_cb
Mar 18 10:49:54 raspberrypi sudo[66277]:     raise OSError(err, f'Connect call failed {address}')
Mar 18 10:49:54 raspberrypi sudo[66277]: ConnectionRefusedError: [Errno 111] Connect call failed ('<IP_ADDRESS>', 8332)
Mar 18 10:49:54 raspberrypi sudo[66277]: The above exception was the direct cause of the following exception:
Mar 18 10:49:54 raspberrypi sudo[66277]: Traceback (most recent call last):
Mar 18 10:49:54 raspberrypi sudo[66277]:   File "./app/repositories/bitcoin.py", line 102, in _handle_gather_bitcoin_status

So it seems the blitzapi does not start if there no bitcoind/lnd yet. How can we make the API tolerate a missing bitcoind/lnd until its available?

At which setup step can we assume that Bitcoin Core and a LN node is fully available to connect to?
From Redis:
setupStep="100"
setupPhase="done"
state="ready"

I'd say that I check for the setupStep and turn off all lighting functionality below a certain value.
Then I could listen to changes to setupStep or wait for a reboot when the system is finished setting up lightning.

OK this looks good now. Closing.


New linter rules erase some JSDoc formatting

Problem
A linter rule added in #388 erases valid Markdown.
Italics
This is an italicized word in valid Markdown in a JSDoc.
/**
 * *italic*
 **/

Linted:
/**
 * italic*
 **/

Bulleted lists
This is a bulleted list in valid Markdown in a JSDoc.
/**
 * * list item 1
 * * list item 2
 * * list item 3
 **/

Linted:
/**
 * list item 1
 * list item 2
 * list item 3
 **/

Solution

Change this setting: "jsdoc/no-multi-asterisks": ["error"|"warn", {"allowWhitespace":true}]
Revert the incorrectly linted changes.

See also

https://github.com/gajus/eslint-plugin-jsdoc/issues/773
https://github.com/gajus/eslint-plugin-jsdoc/issues/803

Steps to reproduce

Add this to a Cientos component:

/**
 * * list item 1
 * * list item 2
 * * list item 3
 **/
interface List {}

Save
Run pnpm run lint --fix
The result will be:

/**
 * list item 1
 * list item 2
 * list item 3
 **/
interface List {}

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hi @andretchen0 thanks for raising this, we could change this setting directly on https://github.com/Tresjs/eslint-config wdyt?

Hi @andretchen0 thanks for raising this, we could change this setting directly on https://github.com/Tresjs/eslint-config so the whole ecosystem is protected against the issue, wdyt?

Sounds good.

I'll close this one, feel free to re-open if the problem still persist


Reddit account isn't working, people keep changing the pwd

Compromise: we should redo the reddit, but put the password in an untouchable file, like the github token.

How about that encryption module?

The bot isn't doing anything too awesome with the reddit comments tho, it's just printing them out.


Optimize dateTimeConvert scalar function to only parse the format once

Make dateTimeConvert scalar function stateful so that the format is parsed only once across multiple invocations. The state is persisted within the scope of FunctionInvoker, so multiple functions with the same name won't share the same state.

Codecov Report

Merging #8939 (d11a000) into master (09fcdd5) will decrease coverage by 3.40%.
The diff coverage is 96.42%.

:exclamation: Current head d11a000 differs from pull request most recent head e103485. Consider uploading reports for the commit e103485 to get more accurate results

@@             Coverage Diff              @@
##             master    #8939      +/-   ##
============================================
- Coverage     69.69%   66.29%   -3.41%
- Complexity     4630     4691      +61
============================================
  Files          1813     1361     -452
  Lines         94521    68664   -25857
  Branches      14116    10736    -3380
============================================
- Hits          65879    45521   -20358
+ Misses        24033    19869    -4164
+ Partials       4609     3274    -1335

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
66.29% <96.42%> (+<0.01%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...inot/common/function/scalar/DateTimeFunctions.java
95.00% <ø> (-0.24%)
:arrow_down:

.../pinot/common/function/scalar/DateTimeConvert.java
96.42% <96.42%> (ø)

...va/org/apache/pinot/core/routing/RoutingTable.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/common/config/NettyConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...g/apache/pinot/common/metrics/ControllerMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...apache/pinot/common/helix/ExtraInstanceConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ache/pinot/server/access/AccessControlFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 686 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2b4aa...e103485. Read the comment docs.


Can I create custom html content for the list items in the dropdown?

I want to use the completer on a remote endpoint that returns user info that looks something like:
[
  { username: 'smithj', email<EMAIL_ADDRESS>fullname: 'John Q Smith', type: 1 },
  { username: 'jonesb', email<EMAIL_ADDRESS>fullname: 'Bill Jones', type: 2 },
  ...
]

I see that I can use the titleField and descriptionField to get almost what I want, but I'm not sure how I can get the final step.  I ultimately want each list item to show the "fullname" and the "email" fields, but I want to style them differently based on the "type" value. Is there some way to build up a custom html element for each list item, based on the content of the data?
In my specific case, I want the item to show full name at the top of the list item (titleField does well for this), and the email address just below this (descriptionField does well).  Now I want the type 1 users to appear slightly grayed-out in the text
thanks!

At the moment there is no way to customize the list content.
There is an open issue with a request to add it #79.


[FEATURE REQUEST] Shopping List (for Cross-World)

Firstly, thank you for this wonderful wonderful plugin. Your work to create this is very much appreciated.
As for the feature request, I was wondering if it would be possible to add a shopping list of sorts?
For instance say you just hit 80 and wanted to buy a full set of Exarchic gear; it would be nice if we could right-click items from the Market Data list, then "Add to Shopping List". This would then create a separate window that simply lists [Item Name, Price, and World] for easy reference when world hopping. Please consider it.
Even if this isn't a possibility or you've no interest in implementing it, thank you again for this great utility.

Closed by #37.


Aeotec Firmware Updates: ZW111 Nano Dimmer v2.4, ZW187 Recessed Door Sensor 7 v1.6

ZW111 Nano Dimmer V2.04 Added (EU code Thanks to @larstobi pull request #101  )
ZW187 Recessed Door Sensor 7 V1.06 Added
closes #101

Thanks @Aeotec-ccheng and @larstobi

Thanks @Aeotec-ccheng @larstobi and @AlCalzone - OTA update from v1.2 to v2.4 worked perfectly with my two nano dimmers. :-)


Formatter

This PR introduces JuliaFormatter.jl to automatically format (and enforce formatting) on the codebase (Andrew asked me to do this.)
What does this make me do?
If you want, nothing.  The github will block any PR that isn't formatting, but it will also automatically provide suggested commits that fix it.
If you use VSCode with the normal julia package, the built-in formatting commands will play nicely with JuliaFormatter.jl.  I recommend turning on "format on save" in the settings.
How do I run the formatter locally?
If you have edited the codebase and want to run the formatter manually, rather than having it triggered by your editor, you can do the following:
$ julia
using JuliaFormatter
format(".") # or the path to the code, if it's not the current directory

I have asked for this... and hope it helps with us all contributing together.


can't catch parse error in stream

I'm finding it really useful to run gulp-ngdocs as part of a watch task, so whenever I change the doc comments in my source files, the update takes effect immediately and refreshes my local server. I generally make my gulp tasks handle stream errors gracefully, because I don't want ngdoc syntax errors to crash my watches. This works fine some of the time, but I've found many types of common ngdoc syntax errors that cause gulp-ngdocs to throw exceptions rather than emitting stream errors.
Naturally, I can always fix the syntax error, but since the exception forces the process to exit, I have to restart the gulp watch task every time, and that can become very inconvenient.
Here's a simple example that I constructed:
Contents of src/bad.js:
/**
 * @ngdoc function
 * @name bad
 * @param {Object} record The data stuff
 * @returns {Object}
 */
function bad() {

}

Gulp task:
var gulp = require('gulp');
var gutil = require('gulp-util');
var doc = require('gulp-ngdocs');
gulp.task('bad', [], function () {
    return gulp.src('src/bad.js')
        .pipe(doc.process().on('error', gutil.log))
        .pipe(gulp.dest('dist'))
        .on('error', gutil.log);
});

Result of running gulp bad:
[15:16:28] Starting 'bad'...

C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\src\ngdoc.js:437
            throw new Error("Not a valid 'returns' format: " + text + ' (found
                  ^
Error: Not a valid 'returns' format: {Object} (found in: C:\ProjectCode\node\gulp-ngdocs-error-handler\src\bad.js:1)
    at flush (C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\src\ngdoc.js:437:19)
    at Object.Doc.parse (C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\src\ngdoc.js:394:5)
    at C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\src\reader.js:49:99
    at Array.forEach (native)
    at processJsFile (C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\src\reader.js:34:9)
    at Object.process (C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\src\reader.js:17:5)
    at DestroyableTransform.transformFunction [as _transform] (C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\index.js:204:14)
    at DestroyableTransform.Transform._read (C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\node_modules\through2\node_modules\readable-stream\lib\_stream_transform.js:184:10)
    at DestroyableTransform.Transform._write (C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\node_modules\through2\node_modules\readable-stream\lib\_stream_transform.js:172:12)
    at doWrite (C:\ProjectCode\node\gulp-ngdocs-error-handler\node_modules\gulp-ngdocs\node_modules\through2\node_modules\readable-stream\lib\_stream_writable.js:237:10)

And then the process exits, thus killing my watch. Can this type of error be made to emit a stream event rather than throw an exception?

At the risk of being late to the game: +1

Does anyone know of a workaround here?

So there isn't a workaround for this yet?

Created a PR: #117 - This at least addresses the Errors that come from transformFunction and flushFunction, allowing end users to run gulp-ngdocs in this type of format:
gulp.task('ngDocs', [], function() {
  var self = this;
  var docs = ngDocs.process();
  docs.on('error', function(err) {
    gutil.log(err);
    docs.end();
  });
  return gulp.src('**/*.js')
    .pipe(docs)
    .pipe(gulp.dest('./docs'));
});


[chore]: Added additional SwiftLint configurations

Description
Added a couple of new SwiftLint rules. In particular:

missing_docs
implicit_return
closure_spacing
modifier_order
convenience_type

Missing Docs
Docs are important for maintaining a large codebase. In order to enforce documentation the missing_docs rule was added. This will require documentation comments on public and open declarations.

It would be even better to go further and expand this to internal and private declarations as well. Also inherited types are currently excluded by default.

 Warnings are disabled using // swiftlint:disable missing_docs for these declarations.
They are also marked with a // TODO: DOCS (FILE_OWNER) where FILE_OWNER is the name of the initial file creator. Please have a look at your files and add missing docs in a future PR!
In particular I found missing docs for files created by:

@MarcoCarnevali
@pkasila
Aleksi Puttonen
@RayZhao1998
@nanashili

To find them all just search the project for text containing TODO: DOCS.
Implicit Returns
Swift supports implicit return of values in certain cases where the only statement is a return statement. This rule enforces this behavior.
var someBoolean: Bool {
    return true // ❌ return is not needed
}

var someBoolean: Bool {
    true // ✅ implicit return
}

Closure Spacing
In order to enhance readability closure brackets should have a spacing around its statements.
// ❌ without spacing
someArray.sorted(by: {$0 < $1})
// ✅ with spacing
someArray.sorted(by: { $0 < $1 })

Modifier Order
This is used to have a consistent modifier (private/public, static, override, …) order throughout the project.
Convenience Type
In some cases we need to create types to bundle some static properties into groups. These should always be enums since they cannot be instantiated.
// ❌ only static properties, but structs can be instantiated.
// Instantiating this type makes no sense.
struct APIKeys {
    static let service1 = "SUPER_SECRET_APIKEY"
    static let service2 = "SUPER_SECRET_APIKEY"
    ...
}

// ✅ using a case-less enum which cannot be instantiated.
enum APIKeys {
    static let service1 = "SUPER_SECRET_APIKEY"
    static let service2 = "SUPER_SECRET_APIKEY"
    ...
}

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[x] Review requested

One note: im personally not in favor of the Implicit Returns rule. (Imho it does not make the code more readable).
Also people new to swift (coming or working with other languages) can have a habit of writing return.

One note: im personally not in favor of the Implicit Returns rule. (Imho it does not make the code more readable).
Also people new to swift (coming or working with other languages) can have a habit of writing return.

Any other opinions on this?


The date cannot be changed in the iPhone Safari or Edge browser

Describe the bug
The date cannot be changed in the iPhone Safari or Edge browser,show "invaild date".
Steps to reproduce
1.in Edge open memos
2.edit memo
3.click the date
4.show "invaild date".
The version of Memos you're using.
0.22.4
Screenshots or additional context

Potential duplicate of Allow memo date change Firefox / Safari (https://github.com/usememos/memos/issues/3812)

the same bug in iphone Edge。

@boojack why closed it? if can't edit date in iphone,It will be inconvenient。


fix license

[x] add LICENSE file in the root
[x] modify beginnings of all source code files

fixed in commit 04f184d1ef09cf8c20eb9f79a3dc6dc17013556f


depend on eth-tester and not ethereum-tester

ethereum-tester is an out of date dependency and breaks new builds pulling in microraiden

We've now freezed ethereum-tester to version 0.4.0. The reason is an incompatible web3 which in new version removed some of the function we use in raiden and we need to replace them.


Update sample to include work item form group

Update extension to include work item form group sample which consumes work item form service

Readme.md needs to be updated with information about this sample. If it doesn't "just work", i.e. the work item type needs to be customized in order to see the UI, then those instructions should go into the readme.

Updated Readme. Group extension just works, it doesn't need any configurations.


engine.py: indentation error in line 42 and import * only allowed at module level in line 41

Hi,
I've just updated recurrentshop to work with keras 2 (to  keras-2.0.3 recurrentshop-1.0.0) and now on
import recurrentshop I get an indentation error at line 42 of engine.py.
When I correct the indentation the next error is
 File "/home/key/software/anaconda3/envs/tf3.5/lib/python3.5/site-packages/recurrentshop/engine.py", line 41     def _get_cells():                      ^ SyntaxError: import * only allowed at module level
Could you please have a look?
Thx!

@abhaikollara Can you test on python3?

Yup, getting the same error here

What about now?

Works fine now

Cool, thanks.


Image keeps rotating while i am trying to resize it to smaller

I am using the module to put sticker on image , so user can make it as small as he wants. But the problem is it starts spinning when user tries to make it smaller. any idea to solve  the issue ?

Thanks for using this module! I am also aware of this issue, but currently I am not maintain this module so far. I think we can try some threshold less than a certain point that makes a unexpected rotation. I would really appreciate if you send me a pull request that fixes this problem.


React & Redux JavaScript unit test fails

In both the React and Redux templates the JavaScript test falls with the following error:
 [console.error node_modules\fbjs\lib\warning.js:33
   Warning: Failed context type: The context `router` is marked as required in `Link`, but its value is `undefined`.
       in Link (at NavMenu.js:11)
       in NavbarBrand (at NavMenu.js:10)
       in div (created by NavbarHeader)
       in NavbarHeader (at NavMenu.js:9)
       in div (created by Grid)
       in Grid (created by Navbar)
       in nav (created by Navbar)
       in Navbar (created by Uncontrolled(Navbar))
       in Uncontrolled(Navbar) (at NavMenu.js:8)
       in Unknown (at Layout.js:9)
       in div (created by Col)
       in Col (at Layout.js:8)
       in div (created by Row)
       in Row (at Layout.js:7)
       in div (created by Grid)
       in Grid (at Layout.js:6)
       in Unknown (at App.js:9)
       in Unknown (at App.test.js:7)](url)

This is because the <App /> is trying being rendered outside the context of a Router. Therefore when a <Link /> is being rendered there is no context and the above error is thrown.
This can be resolved by wrapping the <App /> component in the test in a <MemoryRouter /> (and in teh case of the Redux template a mock store as well).
I've submitted a PR that fixes the issue: https://github.com/aspnet/templating/pull/539

Thanks @lancscoder for reporting the issue as well as your effort.
@ryanbrandenburg, can you please look into the #539 PR?

@ryanbrandenburg, seems like the PR has been already merged. Can you please verify that the change is in release/2.2 milestone, as the PR was for aspnet/dev branch.

Yep, this is in release/2.2.


Are more terms needed to describe role of lncRNAs?

In progress - Hi
Figure 2 of this review describes 13 functions of lncRNAs. If the MFs for these RNAs are not available then other terms will be used that are perhaps not appropriate or no MF will be assigned.
Based on figure 2 I have tried to find MF terms that could be used for each description and noted the missing terms below.
Also to work out how many of these different roles would be captured with the same GO terms and which would use different terms and perhaps need NTRs.

b, Xist modulates inactive X chromosome (Xi) architecture during X chromosome inactivation (XCI) by recruiting Xi to associate with the lamin B receptor (LBR) at the nuclear lamina to silence transcription.

As human XIST URS000025784F_9606 had no annotations I have used this review to create some TAS annotations PMID: 32482714 (MF: chromatin-protein adaptor part_of BP: inactivation of X chromosome by heterochromatin assembly, CC dosage compensation complex),
but maybe need NTRs: nuclear matrix binding? Is the MF: chromatin-protein adaptor appropraite or is a more specific term required (Check with transcription working group).

b2 The review also points to nuclear elements (LINEs), may act to decompact chromatin on x-inactivated chromosome suggesting a positive role in chromatin opening[38] seePMID: 34722514 chromatin-associated RNA (caRNA) encompasses a wide variety of specific RNAs such as short nuclear/nucleolar (snRNA/snoRNA) and long non-coding RNA (lncRNA) and newly transcribed mRNA. While their specific action mechanism is mostly unknown, it is now generally believed that they act in combination with RNA-binding proteins (RBP) and histone modifying proteins such as, for example, the Suppressor of Variegation 3–9 (SUV39), Polycomb Repressor complex (PRC1 and 2) and hNRNP-family protein to regulate gene expression and nuclear dynamics - emerging evidence of the role of repetitive RNA and repeat-containing repetitive motifs (i.e., genomic, simple/tandem containing repeats) in the organization of chromatin and the regulation of gene expression.

c, Firre transcripts localize to their transcription site and five additional autosomal chromosomal loci in trans to affect interactions between distant genomic regions.

d, CCAT1-L accumulates in cis to modulate chromatin loops between enhancers and the promoter of MYC.

e, lncRNAs regulate chromatin accessibility. Left, Xist recruits HDAC1-associated repressor protein (SHARP), silencing the mediator for retinoid and thyroid hormone receptor (SMART) and HDAC3 to silence Xi. Right, Mhrt prevents SWI/SNF binding to corresponding DNA loci.

f, Khps1 enhances Pol II transcription by forming an R-loop that anchors Khps1-interacting p300/CBP to the SPHK1 promoter.

g, lncRNAs interfere with Pol II transcription machineries both at the initiation (left) and elongation (right) stages.

h, SLERT promotes Pol I transcription by binding DDX21 to alter its conformation, thereby releasing its inhibitory effect on Pol I. *i, NEAT1 is an architectural lncRNA that nucleates paraspeckles. Upon cellular stress, altered NEAT1 transcription and processing lead to changes of paraspeckles. PSP, paraspeckle proteins.

j, MALAT1 interacts with SR proteins and alters their phosphorylation to impact pre-mRNA splicing in splicing speckles. k, A regulatory network consisting of different types of ncRNAs. Cyrano, harbouring miR-7 binding sites, targets miR-7 for degradation and prevents miR-7 from repressing its target RNAs including the circRNA Cdr1as.

l, lncRNAs modulate mRNA stability by associating with proteins involved in mRNA degradation. Left, double-stranded RNAs formed by Alu-containing lncRNAs with mRNA 3′ UTRs recruit STAU1 to induce STAU1-mediated mRNA decay (SMD). Right, NORAD stabilizes PUMILIO 1/2 (PUM1/2)-targeted mRNAs via sequestering PUM1/2 from mRNAs.

m, lncRNAs regulate translation. Association of lincRNA-p21 (linc-p21) with HuR favours the recruitment of let-7/Ago2, leading to its destabilization. In the absence of HuR, lincRNA-p21 identifies mRNA targets to repress their translation by recruiting the translation repressor Rck129. RISC, RNA-induced silencing complex.

n, lncRNAs modulate post-translational modifications. Lnc-DC directly interacts with STAT3 to prevent its dephosphorylation by SHP1.

I've added this to the next miRNA call

tagging @gantonazzo and @ValWood as well

OK I have only just started trying to look at this and problably many of you have a better idea of what terms are needed, maybe I should stop trying to do the whole list and leave each of you to add a comment for each type. If I create a new conversation section for each set then everyone could edit the actual text? Or would it be better to do this in a google doc?
@colinlog

LncRNAs with a role in Chromatin organisation
b, Xist modulates inactive X chromosome (Xi) architecture during X chromosome inactivation (XCI) by recruiting Xi to associate with the lamin B receptor (LBR) at the nuclear lamina to silence transcription.

As human XIST URS000025784F_9606 had no annotations I have used this review to create some TAS annotations PMID: 32482714 (MF: chromatin-protein adaptor part_of BP: inactivation of X chromosome by heterochromatin assembly, CC dosage compensation complex),
but maybe need NTRs: nuclear matrix binding? Is the MF: chromatin-protein adaptor appropraite or is a more specific term required (Check with transcription working group).

b2 The review also points to nuclear elements (LINEs), may act to decompact chromatin on x-inactivated chromosome suggesting a positive role in chromatin opening[38] seePMID: 34722514 chromatin-associated RNA (caRNA) encompasses a wide variety of specific RNAs such as short nuclear/nucleolar (snRNA/snoRNA) and long non-coding RNA (lncRNA) and newly transcribed mRNA. While their specific action mechanism is mostly unknown, it is now generally believed that they act in combination with RNA-binding proteins (RBP) and histone modifying proteins such as, for example, the Suppressor of Variegation 3–9 (SUV39), Polycomb Repressor complex (PRC1 and 2) and hNRNP-family protein to regulate gene expression and nuclear dynamics - emerging evidence of the role of repetitive RNA and repeat-containing repetitive motifs (i.e., genomic, simple/tandem containing repeats) in the organization of chromatin and the regulation of gene expression.

c, Firre transcripts localize to their transcription site and five additional autosomal chromosomal loci in trans to affect interactions between distant genomic regions.

d, CCAT1-L accumulates in cis to modulate chromatin loops between enhancers and the promoter of MYC.

That sounds like a good idea, then we can collect examples as we go.

LncRNAs with a role in transcription

e, lncRNAs regulate chromatin accessibility. Left, Xist recruits HDAC1-associated repressor protein (SHARP), silencing the mediator for retinoid and thyroid hormone receptor (SMART) and HDAC3 to silence Xi. Right, Mhrt prevents SWI/SNF binding to corresponding DNA loci.

f, Khps1 enhances Pol II transcription by forming an R-loop that anchors Khps1-interacting p300/CBP to the SPHK1 promoter.

g, lncRNAs interfere with Pol II transcription machineries both at the initiation (left) and elongation (right) stages.

h, SLERT promotes Pol I transcription by binding DDX21 to alter its conformation, thereby releasing its inhibitory effect on Pol I. *i, NEAT1 is an architectural lncRNA that nucleates paraspeckles. Upon cellular stress, altered NEAT1 transcription and processing lead to changes of paraspeckles. PSP, paraspeckle proteins.

LncRNAs with a role in post-transcription

i, NEAT1 is an architectural lncRNA that nucleates paraspeckles. Upon cellular stress, altered NEAT1 transcription and processing lead to changes of paraspeckles. PSP, paraspeckle proteins.

j, MALAT1 interacts with SR proteins and alters their phosphorylation to impact pre-mRNA splicing in splicing speckles. k, A regulatory network consisting of different types of ncRNAs. Cyrano, harbouring miR-7 binding sites, targets miR-7 for degradation and prevents miR-7 from repressing its target RNAs including the circRNA Cdr1as.

l, lncRNAs modulate mRNA stability by associating with proteins involved in mRNA degradation. Left, double-stranded RNAs formed by Alu-containing lncRNAs with mRNA 3′ UTRs recruit STAU1 to induce STAU1-mediated mRNA decay (SMD). Right, NORAD stabilizes PUMILIO 1/2 (PUM1/2)-targeted mRNAs via sequestering PUM1/2 from mRNAs.

m, lncRNAs regulate translation. Association of lincRNA-p21 (linc-p21) with HuR favours the recruitment of let-7/Ago2, leading to its destabilization. In the absence of HuR, lincRNA-p21 identifies mRNA targets to repress their translation by recruiting the translation repressor Rck129. RISC, RNA-induced silencing complex.

n, lncRNAs modulate post-translational modifications. Lnc-DC directly interacts with STAT3 to prevent its dephosphorylation by SHP1.

Just trying to list other ways in which we can distinguish activities - not mutually exclusive, but to help thinking about it all as from Ruth's list, their activities seem almost as diverse as protein's are....

Acting in cis (ie when their transcription interferes with a neighboring gene) or in trans (at distance)
Nuclear and cytosolic
Interaction target
Molecular interaction - base pairing, displacement (?), competition, protein recruitment.....etc

Interesting gene regulatory topic these LncRNAs. Glad that S.pombe also has the protein, makes me believe the whole more...
My take has been that each of these LncRNAs has its own story to tell and the whole is rather idiosyncratic.
Xist, Hotair, SRA, etc..  are much studied RNAs, a lot of hot attention has gone to a polycomb H3K27methylation theory, but again, not easy to model or understand...
In addition there is also a ribosomal promoter DNA-RNA basepair phenomenon -- initially by Ingrid GRummt that cannot be dismissed as an artefact.
Still, to my knowledge no-one could biochemically reconstitute what they do, what the molecular activities really are? The sponge activities are perhaps the best documented? Furthermore there are 'regulators of the regulators'. For instance, Xist has an antogonist TSIX...
Ultimately, there are proteins involved, so those may bear the specific biochemical-molecular function (bind RNA and then do ...), whilst the RNAs have more of an adaptor-target specifying role?

OK I have only just started trying to look at this and problably many of you have a better idea of what terms are needed, maybe I should stop trying to do the whole list and leave each of you to add a comment for each type. If I create a new conversation section for each set then everyone could edit the actual text? Or would it be better to do this in a google doc? I think there are 3 main areas covered in Fig 2 LncRNAs with a role in Chromatin organisation, LncRNAs with a role in transcription, LncRNAs with a role post-transcriptionally @colinlog

Yes @RLovering , I see much sense in your proposal for organizing the process regulation aspects by LncRNAs in terms of (i) regulation - induction of chromatin organisation / histone or DNA modification  (ii) regulation of transcription with of course iia initiation, iib elongation iic termination of transcription and (iii) the post-transcriptional pathways, that modulate iiia RNA splicing, iiib RNA stability, iiic RNA nuclear localisation export/re-import or iiid translation by ribosomes.   I think then that the STAT3 example would be a (iia) type regulation. Xist a (i) type, and teh Lnc-p21 example iiid. The trick being to have product oriented definitions and logic for the BPs and RNA molecule or RNA binding protein activity-centered definitions for the MFs, so . Most of this is already in place for proteins, isn't it?
@hattrill  The cell components, are where it happens, rather than activities? "This MF for that BP in this CC" and in GO-CAMS this RNA MF has + or - effect on the next bioentity's MF

+id: GO:0140870
+name: RNA polymerase inhibitor activity
+namespace: molecular_function
+def: "Binds to and stops, prevents or reduces the activity of RNA polymerase." [PMID:15300239, PMID:18313387, PMID:31048766]
+is_a: GO:0004857 ! enzyme inhibitor activity
+property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/23028 xsd:anyURI
+created_by: pg
+creation_date: 2022-07-04T14:26:28Z
+
+[Term]
+id: GO:0140871
+name: repressor of RNA polymerase inhibitor activity
+namespace: molecular_function
+def: "Binds to and stops, prevents or reduces the activity of an RNA polymerase inhibitor." [PMID:28475895, PMID:31048766]
+is_a: GO:0004857 ! enzyme inhibitor activity
+property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/23028 xsd:anyURI
+created_by: pg
+creation_date: 2022-07-04T14:26:28Z

@pgaudet For "repressor of RNA polymerase inhibitor activity", should the parent be changed to "enzyme activator activity", given the activity is repressing an inhibitor of an RNApol?

I would go for a regulator of activity annotation for some Lnc (if convincingly demonstrated) but not inhibitor of enzyme activity when RNA polymerase II is concerned since there are many functions that can lead to less or more transcription of a gene (rate/frequency of intiation, processivity of elongation, etc, etc.) The exception would be if the active site of the polymerase is contacted.   So, global BP annotation to transcription regulator [GO:0006355
regulation of DNA-templated transcription] if that is demonstrated.   Possibly with a DNA cis-acting element binding has_part [GO:0000978] RNA polymerase II cis-regulatory region sequence-specific DNA binding], if that is demonstrated. Often I would imagine that an annotation to an epigenetic process + (positive regulator eg; [GO:0045815	biological_process	epigenetic maintenance of chromatin in transcription-competent conformation] or - (negative regulator eg; [GO:0045814 biological_process negative regulation of gene expression, epigenetic] or its descendant term (eg [GO:0031507	biological_process heterochromatin formation], or one of it's more defined descendant terms if more is known.


contributors.svg seems to miss some contributions

Describe the bug
The svg showing the Contributors for the repository dubzzz/fast-check does not seem to be synchronized with the current state of the project.
To Reproduce
Steps to reproduce the behavior:

Open https://opencollective.com/fast-check/contributors.svg?width=890&button=false
You see 22 contributors while it should be 29 as on GitHub

Expected behavior
The contributors should be the same as the ones reported by GitHub for this project, see Contributors to dubzzz/fast-check at https://github.com/dubzzz/fast-check/graphs/contributors

I just checked and see 22 contributors:

And the count on GitHub:

@znarf Actually We should see 29 contributors not 22. GitHub reports that the repo as 29 contributors, contributors.svg only shows 22 of them

It seems that the problem came back

I just released contributors.svg as a separate Open Source repository. Anyone is welcome to participate.
I also deployed a new version which should normally fix this old issue.
Feel free to open issues and PRs in the new repository!


NIFI-2537: Add custom MIME type configuration support to IdentifyMime…

…Type
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Add two new properties to IdentifyMimeType (Config File and Config Body).
Specifying one of these properties will override the default NiFi MIME
type configuration and use the configured property's MIME config instead.
Add additional runtime documentation for IdentifyMimeType's usage. The
default behavior of IdentifyMimeType is unchanged.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Thanks for the improvement @trucemop - this looks good to me and is now merged into master.


Made Ganglia reporter testable + added tests

I must admit I don't know anything about Ganglia, but doesn't it look strange what the "sanitizeName" does to all field names containing anything else than A-Z, a-z e.g.:

75percentile
95percentile
98percentile
99percentile

will all end up being "sanitized" to "__percentile"
This became very obvious when writing the tests.

Sanitize eating numbers was from copying an upstream bug: https://github.com/ganglia/monitor-core/commit/18791030943292b4cec1a20e89e80565dad68be3#commitcomment-731415

Ok, I will push a commit to fix this in this pr!


Change the channel access type

Also include the content about how to change a private channel to a public channel.


fix(quick-preview): Remove mouse cursor for current assignees on a work item

Mandatory

[ ] Remove mouse cursor for current assignees on a work item in the quick preview and detail page of a work item

[ ] Issue - https://github.com/openshiftio/openshift.io/issues/2287
Fixes the feedback on assignees

[ ] Are the tests Included?
No

@nimishamukherjee Your image is available in the registry. Run docker pull quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2763 && docker run -it -p 5000:8080 quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2763 and visit http://localhost:5000 to access it.

[test]

[test]

[test]

@nimishamukherjee Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2763 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2763 and visit http://localhost:5000 to access it.


custom dataset

Are there procedures/steps/scripts for training the model on a custom dataset?

You can follow the procedures/scripts of Speech2Gesture .

Thanks that was helpful, may I ask How to calculate scaling constants for my dataset like in [speakers_stat.py? @ShenhanQian

The scale_factor is used to resize the keypoints of subjects so that they have equal widths of shoulders.
Therefore, you can first compute the mean shoulder width of your own subject, and obtain its scale_factor by its ratio to the mean shoulder width of either subject in our released data.

I have just uploaded reference scripts for custom data processing.
You can find the mean shoulder width of Oliver here.
https://github.com/ShenhanQian/SpeechDrivesTemplates/blob/1d8182bee7fbb011d6128efc2c0fba1cbc0f27b0/data_preprocess/2_3_rescale_shoulder_width.py#L68
Alternatively, you could simply rescale the keypoints with data_preprocess/2_3_rescale_shoulder_width.py so that the new speaker with have the same shoulder width as Oliver, then you can set the new speaker's scale_factor to Oliver's.

I would like to thank you for the scripts, it's really helpful.
I would like to mention two errors in 2_1_gen_kpts.py :

at line 47 opWrapper.emplaceAndPop takes op.VectorDatum object type so I corrected it to opWrapper.emplaceAndPop(op.VectorDatum([datum]))

at line 82 I think I missed the bracket location I corrected it to len(sys.argv) == 2

I tried the pipeline and it worked perfectly fine except that I got the mean and std values for the key points equal to zeros from the last two scripts.
any thoughts why could that happen?

Thank you for your support!
Could you please share your  ``clips.csv'' (or a segment of it) to help us debug?

sorry for late response,

the data I ran through the pipeline was 6 videos each 10-sec max for the same person.


request body schema doesn't support Array

at openapi.ts  line 542 ~ 545
if (requestSchema.body) {
      const { description, schema, example, modelName } = this.bodyParams(
        requestSchema.body
      );
  // ...
}

it calls function bodyParams
at openapi.ts line 944 ~ 951
    return {
      description:
        query.swagger.properties[key].description ||
        "Body does not have a description.",
      schema: this.objectSchema(parameter),
      ...(parameter.example && { example: parameter.example }),
      modelName: parameter.meta.modelName
    };

it calls function objectSchema.
thus when I use array schema as request body, there throws an error at openapi.ts line 213, since parameter.properties is undefined.
  for (const propertyKey of Object.keys(parameter.properties)) {

It was done on purpose:
https://cheatsheetseries.owasp.org/cheatsheets/AJAX_Security_Cheat_Sheet.html
zed @.***> escreveu no dia segunda, 11/04/2022 à(s)
09:43:

at openapi.ts line 542 ~ 545
if (requestSchema.body) {
const { description, schema, example, modelName } = this.bodyParams(
requestSchema.body
);
// ...
}
it calls function bodyParams
at openapi.ts line 944 ~ 951
return {
  description:
    query.swagger.properties[key].description ||
    "Body does not have a description.",
  schema: this.objectSchema(parameter),
  ...(parameter.example && { example: parameter.example }),
  modelName: parameter.meta.modelName
};

it calls function objectSchema.
thus when I use array schema as request body, there throws an error at
openapi.ts line 213, since parameter.properties is undefined.
for (const propertyKey of Object.keys(parameter.properties)) {
—
Reply to this email directly, view it on GitHub
https://github.com/nelsongomes/ts-openapi/issues/21, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAITSRGCZJ6JMV2KUMC36JLVEPQ3HANCNFSM5TCN4QSA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It is not a good practice to use array directly in the body, but inside an object

thanks for your quick respond, but the doc says
ALWAYS RETURN JSON WITH AN OBJECT ON THE OUTSIDE
Always have the outside primitive be an object for JSON strings¶
but we're talking about request body, is there anything inappropriate to send an array as request body?

https://www.ibm.com/docs/en/urbancode-build/6.1.2?topic=reference-rest-api-conventions

The document states 'JSON Vulnerability Protection - A JSON vulnerability
allows third party website to turn your JSON resource URL into JSONP
(...)' JSON
and JSONP are all body content.
Change your request to return an object, problem solved.
Thx
zed @.***> escreveu no dia segunda, 11/04/2022 à(s)
13:10:

thanks for your quick respond, but the doc says
ALWAYS RETURN JSON WITH AN OBJECT ON THE OUTSIDE
Always have the outside primitive be an object for JSON strings¶
https://cheatsheetseries.owasp.org/cheatsheets/AJAX_Security_Cheat_Sheet.html#always-return-json-with-an-object-on-the-outside
but we're talking about request body, is there anything inappropriate to
send an array as request body?
—
Reply to this email directly, view it on GitHub
https://github.com/nelsongomes/ts-openapi/issues/21#issuecomment-1094972211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAITSRFGBAKXHJ6RP3ORDTTVEQJENANCNFSM5TCN4QSA
.
You are receiving this because you commented.Message ID:
@.***>

I'm afraid we have misunderstanding here. It seems I'm talking about when request body schema is in Array, it has an error, while you're talking about it's not a good idea to send Array back client side. Right?
Sorry about that.
Let me clearify my situation.
I'm working on a tool to work with an internal Koa framwork to generate swagger api doc.
Here -> https://github.com/Zsynuting/ts-swagger-doc
So, I use ts-openapi to generate JSON schema and then use swagger-ui-koa to consume the JSON schema and serve swagger doc.
But when I describe a POST request body an Array, there happened the exception above.
See sample at line 32.
https://github.com/Zsynuting/ts-swagger-doc/blob/main/sample/controller.ts

Ok, give me a couple of days to take a look at it.
zed @.***> escreveu no dia terça, 12/04/2022 à(s) 04:16:

I'm afraid we have misunderstanding here. It seems I'm talking about when
request body schema is in Array, it has an error, while you're talking
about it's not a good idea to send Array back client side. Right?
Sorry about that.
Let me clearify my situation.
I'm working on a tool to work with an internal Koa framwork to generate
swagger api doc.
Here -> https://github.com/Zsynuting/ts-swagger-doc
So, I use ts-openapi to generate JSON schema and then use swagger-ui-koa
to consume the JSON schema and serve swagger doc.
But when I describe a POST request body an Array, there happened the
exception above.
See sample at line 32.
https://github.com/Zsynuting/ts-swagger-doc/blob/main/sample/controller.ts
—
Reply to this email directly, view it on GitHub
https://github.com/nelsongomes/ts-openapi/issues/21#issuecomment-1095911472,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAITSRCRE6NTGVKX5UKKAH3VETTIFANCNFSM5TCN4QSA
.
You are receiving this because you commented.Message ID:
@.***>

Can we have a call today?

Sure, how about 10:00 PM China time, how would you like to have the call?

meet.google.com/jjn-obkr-hpn in around 2h45

got it

what is 2h45? does it mean 2:45 at your time zone? sorry about missing that, please confirm our schedule time again.

https://github.com/Zsynuting/ts-openapi-issue/blob/main/src/index.ts
just find out if according to ts type constraint, I can't replicate the issue. but I still think my case is considerable. please check it out.

working on it, but expect a few days to solve it

FYI finishing my tests, should be ready in a day or two, sorry for the delay, but between work and holidays, haven't had much time available.

cool! No problem, just take your time.

check version 1.1.0 please

it works perfect, thanks man!

Closing issue then. Thanks.


📝 Correction | ETag Stoppa and HTTPS Everywhere may now be redundant, LocalCDN supersedes Decentraleyes, etc.

Description
From my understanding HTTPS Everywhere is now redundant since the inclusion of HTTPS-Only mode in FF83+. Also ClearURLs already includes the capability to remove ETags making ETags Stoppa unnecessary, granted you only recommended it to Android users. But still, a more useful addon would be First Party Isolation to toggle First Party Isolate mode on and off to fix broken logins.
Lastly, the addon LocalCDN supports more site libraries to prevent further tracking than Decentraleyes.
Why I am making the suggestion
I think I explain most of my points in the above, though for me recommending First Party Isolation, let me say that the Container Tabs feature makes First Party Isolate redundant in most cases in addition to it having the advantage to allowing cross domain logins to work too.  It's only major drawback seems to be the lack of availability on Android. First Party Isolation acts as a workaround to allow cross domain logins with FPI by temporarily disabling it.

My connection with the software
I have no connections; I'm merely someone who uses and tried to keep up with 12bytes.org's privacy guides and Arkenfox's wiki.

[x] I will keep the issue up-to-date if something I have said changes or I remember a connection with the software.

HTTPS Everywhere is now redundant since the inclusion of HTTPS-Only mode in FF83+.

HTTPS-Everywhere EASE is spiritual superseded by HOM, that's right. However the large set of upgrade/rewrite is still unique to HTTPS-Everywhere. Nevertheless HOM is actually enough (and preferred), even for less technical users.

to toggle First Party Isolate mode on and off to fix broken logins.

Better: Use TCP/dFPI if you need Xsite loggin that is broken by FPI. It should work with TCP/dFPI.

Lastly, the addon LocalCDN supports more site libraries to prevent further tracking than Decentraleyes.

:+1: :+1: :+1:

See #2081


Update page header guidance images

What is the purpose of the work?
Update the images for the page header guidance to show chips with uppercase text ("BETA") to match usage on site and code examples
Why do we need it?
Following on from #316, an update is required to be consistent

Linked to work being completed in this ticket: https://github.com/mi6/ic-design-system/issues/483


Jpb/support for python 312

Rolling Python support forward one version:

Adding support from python3.12 and dropping for 3.8. i.e. tested against 3.9, 3.10, 3.11, 3.12
Upgrading to numpy 2.x, pandas 2.x, and newer scipy that introduces scipy.signals.windows
Relaxed some regression tests that were failing on the mac due to very small numerical differences

All good. Merged.


No support for horizontal scrolling in a notebook output cell

@randomQQQ commented on Sun May 09 2021
Environment data
Issue Type: Bug
No scrolling in pandas dataframe output
Extension version: 2021.6.819764235
VS Code version: Code - Insiders 1.57.0-insider (a19565da7dfc739fa26e36aae96113e19fe3806f, 2021-05-07T17:19:03.737Z)
OS version: Windows_NT x64 10.0.19042
Actual behaviour

Expected behaviour

@DavidKutu commented on Mon May 10 2021
Thanks for the issue @randomQQQ. As a quick work around, you can use the middle mouse button to scroll.
But we'll take a look with vscode.
@rebornix

+1 customer feedback

+1 customer feedback - Jupyter ext rating on marketplace

Fixed in main.


ESRI / ArcGIS reverse Geocoder location parameters

Thank you for the nice library!
I have been using it with Google and it works well.
When using it with ESRI / ArcGIS, I think I found a bug in the reverse geocoder.
As seen here:
https://developers.arcgis.com/rest/geocode/api-reference/geocoding-reverse-geocode.htm
location is x,y so one should pass location as long,lat.
lib/geocoder/agolgeocoder.js
...
AGOLGeocoder.prototype.reverse = function(query, callback) {
var lat = query.lat;
var long = query.lon;
var _this = this;

var execute = function (lat,long,token,callback) {
    var params = {
        'token':token,
        'f':'pjson',
        'location' : long + ',' + lat,  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<

...
Cheers!

Thanks for using it, Do you have the time to submit a pull request to fix to the bug ?

Thanks for the issue. I fixed it


Allow PyPy3 support to work with PyPy3 5.5

Closes #65.

Thank you for your work on this, @kirbyfan64. I'm doing all this on borrowed computers at the moment, so if you're able to update the pull request that would be very helpful. I think I'll be able to make a release without needing a decent terminal, so I should be good there.

Project coverage is the same, so this already wasn't covered. The build matrix is passing, so technically it is covered in some way, just not a way that's being reported to codecov.

Might be a few days before I release, but thank you very much for your help, @kirbyfan64 !

I'm working on cutting a release now. I didn't realize that this hadn't been released yet. I'm sorry, folks.

0.9 is out!


Cannot Place Blueprints

After hours of testing, nobody can place blueprints as a plan. Only direct placement as an admin works.

Problem was found that the blueprints take invalid objects, then deletes them on placement, but it is deleted before running the place code and thus tries to place a null object resulting in a null exception.

fixed in 0.8.5


Any way to prevent .js file written?

We have a simple scenario where we're using webpack to build out a separate global minified .css file from .less that we're using on a large site.
    entry: {
        main: ['./app/main'],
        style: ['./theme/react.less'],
        common: Object.keys(require("./package.json").dependencies)
    },

..this all works, and we get our .css file created, but in the process it also writes out a style.js file, which we don't seem to need at all.
So two questions, what would  remain in style.js if kept around, and in our case where it doesn't seem to have any value, can we provide an option to ExtractTextPlugin to prevent that style.js from being written at all (along with it's .map file in the event we have source maps enabled?).
We have these loaders...
   module: {
        loaders: [
            {
                test: /\.jsx?$/,
                include: path.join(__dirname, 'app'),
                exclude: /node_modules/,
                loaders: ['react-hot', 'babel']
            },
            {
                test: /\.css$/,
                loader: ExtractTextPlugin.extract("style-loader", 'css-loader?' + css_mode)
            },
            {
                test: /\.less$/,
                loader: ExtractTextPlugin.extract("style-loader", 'css-loader?' + css_mode + '!less-loader')
            },

            {test: /\.woff(2)?/, loader: "url-loader?mimetype=application/font-woff"},
            {test: /\.(ttf|eot|svg)/, loader: "url-loader"},
            {test: /\.(png|jpg|gif)/, loader: "url-loader"}
        ]
    },

Thanks for the insight!

I have the same problem. The only workaround I have found is to not include the *.less entry in the webpack config and import that less file in the main JS entrypoint (in this case that would be the ./app/main.jsx file).

Related issue, https://github.com/webpack/webpack/issues/1967 .

This is a core issue. Not much we can do here.


Property object delimitation in full text

Among the objects that we will need to delimit in full texts are sometimes also properties, which are some kind of metaobjects holding other objects (origin, proptype and propvalue), but they have their ID, right, so it should be possible?
Since you are developping these features, try to already include props there.

Props actually do have ID. So it's technically possible, just the implementation might be complicated.

Let us resolve the discussion if Prop is a new entity class or stays inside the Statement entity as is now first.
Having the Prop as a separate entity class would need quite a lot of work but could simplify a lot of things in the future.

@adammertel You already started devising this, I remember I saw a special icon for this where property was an envelope. Can we analyse the positive and negative implications somehow?
Positive:

We will be able to delimit the whole property in the full text, and thus use thus delimited strings to pre-suggest property type and/or property value (towards machine-generated models - MGSTEMO).
We will be able to store property templates for things that we use often as a whole, not (not possible now, I think?).
It is ontologically correct in the CASTEMO data model: it actually recognizes the well-known fact that property is still a statement, and thus makes it identifiable as a thing, albeit with components (but Statements also have components, and even many, so no problem there).

Negative:

We will need to ensure that editors are not reusing a property thinking that they are using it as template, but actually they are DnDing a specific property which does not belong in the given context.
What else?

@adammertel Not needed for 1.4.0, moving to 1.4.1.

BTW I see this is linked to #1592, #1593 .


Switch to SVG badge

SVG looks better on Retina screen.

Coverage remained the same at 99.298% when pulling b651265a7480084b59ae9fbdf9390653d8605dc0 on franklinyu:patch/readme into d552d66f4353b2db16c8f3ab9a1388b52f1fdb3a on krists:master.


Update/Simplify data submission process

FEATURE DESCRIPTION
Feature Inspiration
The current process to submit data via a Google form is rather cumbersome.

Users are not able to submit the Google Spreadsheet directly, but have to download as Excel and upload to the form
The files end up in different directories for each questions
Only 10 files can be submitted, more than that have to be zipped, etc.

Feature Description
Perhaps a checklist of what what file(s) are needed along with a description of how to create a new "study" folder in a specific place on Google drive could work better. We would need to allow each lab member permission to the folder, but there aren't so many that should be a problem. The basic instructions could be in a Google Doc in that folder along with an example (the obob study perhaps) so people could see a completed example.
Alternatives Considered
None considered, but other ideas welcome.
Comment
Add any other context or screenshots about the feature request here.

ISSUE OWNER SECTION
Assumptions

List of assumptions made WRT the code
E.g. We will assume input is correct (explaining why there is no validation)

Requirements

List of conditions to be met for the feature
E.g. Every column/row must display a value, i.e. cannot be empty

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected/Changed Components

Files
Environment variables
External executables
Database tables
Cron job settings
Etc.

DESIGN
GUI Change description
Describe changes the user will see.
Code Change Description (Pseudocode optional)
Describe code changes planned for the feature.
Tests
A test should be planned for each requirement (above), where possible.

Maybe a google script can be employed to streamline the process. I've created one before to populate a weather tracking spreadsheet to warn me about the possibility of an ice dam forming on my roof in Buffalo (which was possible if the temperature was below freezing for 4 days in a row... Let me take a quick look at whether a google script could be used to simplify the submission...

I like the idea of a script to customize things. Has the potential to be very powerful. Keep in mind:

This process is likely to change, possibly significantly, therefor it should be flexible and easy to change
Other developers should all be able to understand and modify things if need be
We should have some sort of workaround for edge cases (e.g. put files into a specific Google Drive folder, etc.)

I was refreshing my memory on google scripts (now called "Apps Scripts" (or "Google Apps Scripts")).  Luckily, I documented it in a blog post.
The way my ice jam script worked was, I attached a script to the spreadsheet that would run whenever a row was added.  Previously, you accessed it from a google spreadsheet via the Tools->Script Editor menu.  Now it's under Extensions -> Apps Script.  And I had an IFTTT applet that added a row each day with tomorrow's high temperature.  The script would check whether the 4 most recent additions were under 33 degrees, and if so, it would email me an "ICE JAM WARNING".
It's pretty nifty, but thinking about this issue, I'm not clear on how a google script might be employed here...  Perhaps if the script could...

Prompt to select a number of google spreadsheets and/or excel files (allowing more than 10)
Save the submissions in a single directory
Maybe even run the validation code???

That's about all we'd need, right?

This will need some more thought.  I'm going to drop some relevant links and move on while I ruminate on it...

https://stackoverflow.com/questions/50762183/how-can-i-create-a-google-scripts-prompt-that-accepts-multiple-inputs#_=_
https://support.google.com/docs/thread/13371261/how-do-i-use-one-google-apps-script-file-to-be-used-for-multiple-different-google-sheets?hl=en

Here is the proposed TraceBase Study Submission Process proposal so far, in Google Docs format to make commenting/editing simpler. Once it's ready, I'll make a PR to update the upload page on TraceBase.


Login Mocking

Coverage remained the same at 85.279% when pulling 375e2e37664d61fd17e530501d555e3011045875 on dev into 49123255b976e6bddeef3662b72e3c98fd090f2c on master.

Coverage remained the same at 85.279% when pulling 799a5f57d18efdd5c402a4ec2a707c5b003dea19 on dev into 49123255b976e6bddeef3662b72e3c98fd090f2c on master.

Coverage remained the same at 85.279% when pulling 92d841216526a815dd7b0f9ef92e04ad4c6fdbef on dev into 49123255b976e6bddeef3662b72e3c98fd090f2c on master.

Coverage remained the same at 85.279% when pulling 86207367cf95009c9f35d34bf6f7023dbed1a9ea on dev into 49123255b976e6bddeef3662b72e3c98fd090f2c on master.


Include source and non-minified lib

Include src/bodyScrollLock.js, lib/bodyScrollLock.js and lib/bodyScrollLock.min.js

Fixes #37


fix(elbv2/target): Retry registration if target is unused

Description of your changes
Fixes #1458
I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manually

@erickfaustino can you check if this fix solves your issue?

Sure, @MisterMX.
How can I test it? Is there an image built from this branch?

@erickfaustino you can check out the branch and run provider-aws locally with your kube context using make run or a debugger of your choice. It will then reconcile it's resources as if it would have been deployed inside the cluster (doesn't work for IRSA, though).

Ok, I will execute the tests and then I will post it here, thank you very much!

@MisterMX, I have tested it, and it worked! The targets are being registered now! Thank you very much!
I will wait for the merge inside the main branch!
<3


Allow colon after issue ID in Toggl logs

Is your feature request related to a problem? Please describe.
I wish I could use this format for Toggl log entries:
ABCD-1234: Reticulate splines.
The colon means that it gets parsed as ['ABCD', '1234:'], though, and the issue is not found.
Describe alternatives you've considered
I have just been omitting the colon.

I am not currently using/updating this anymore, so feel free to create a PR and fix this issue :)

I have fixed this in v1.1.0, however, this might not work for you since this release might not work with cloud. I have no access to a cloud instance anymore so if you want to try it out, then please do :)


features: show dir and file counts keep in bookmarks on status_win

Like 🔖: 0📂0📃 if the selection list is empty.
Then, it will be more clear.

That seems like a good idea. I'll try to add it as soon as possible

i added selection count in rev. eaa29ac