Audio transcripts with groq

Summary
This pull request introduces enhancements and new features to the Whisper class within the ts.py script. The primary changes include:

integrating support for the Groq API,
refactoring the class initialization process to ensure compatibility with both OpenAI and Groq models,
adding model listing functionality

Files Changed

installer/client/cli/ts.py

Initialization: Updated the Whisper class initialization to accept arguments and handle both OpenAI and Groq API keys.
Model Fetching: Added methods to fetch available models from OpenAI and Groq.
Audio Processing: Refactored the audio processing to use temporary files for better compatibility with API requirements.
Model Listing: Implemented a method to list available models from both APIs.
Argument Parsing: Enhanced argument parsing to include model selection and model listing options.

poetry.lock

Added the groq library dependency version 0.9.0.

pyproject.toml

Updated to include groq version 0.9.0 in the dependencies.

Code Changes
installer/client/cli/ts.py

Initialization Enhancements:
def __init__(self, args, env_file="~/.config/fabric/.env"):
    """
    Initialize the Whisper class with the provided arguments and environment file.
    """
    ...
    self.model = getattr(args, 'model', None)
    if not self.model:
        self.model = os.environ.get('DEFAULT_TS_MODEL', "whisper-1")
    ...

Model Fetching:
def fetch_available_models(self):
    openai_list = []
    groq_list = []

    if self.openai_client:
        try:
            openai_list = [model.id.strip()
                           for model in self.openai_client.models.list().data
                           if 'whisper' in model.id]
        except Exception as e:
            print(f"Error fetching OpenAI models: {e}")

    GROQ_API_URL = "https://api.groq.com/openai/v1/models"
    if self.groq_client:
        try:
            headers = {"Authorization": f"Bearer {self.groq_key}"}
            response = requests.get(GROQ_API_URL, headers=headers)
            if response.status_code == 200:
                groq_list = [model['id'] for model in response.json()['data'] if 'whisper' in model['id']]
        except Exception as e:
            print(f"Error fetching Groq models: {e}")

    return openai_list, groq_list

Audio Processing:
def process_segment(self, segment):
    try:
        with tempfile.NamedTemporaryFile(delete=True, suffix=".wav") as f:
            segment.export(f.name, format="wav")
            with open(f.name, "rb") as audio_file:
                response = self.client.audio.transcriptions.create(
                    model=self.model,
                    file=audio_file
                )
            self.whole_response.append(response.text)
    except Exception as e:
        print(f"Error: {e}")

Model Listing:
def list_models(self):
    print("OpenAI Models:")
    for model in self.openai_models:
        print(f" - {model}")

    print("\nGroq Models:")
    for model in self.groq_models:
        print(f" - {model}")

Argument Parsing:
def main():
    parser = argparse.ArgumentParser(description="Transcribe an audio file.")
    parser.add_argument(
        "audio_file", nargs="?", help="The path to the audio file to be transcribed.")
    parser.add_argument(
        "--model", "-m", help="Select the model to use")
    parser.add_argument(
        "--listmodels", help="List all available models", action="store_true")
    args = parser.parse_args()

    if args.listmodels:
        whisper = Whisper(args)
        whisper.list_models()
    elif args.audio_file:
        whisper = Whisper(args)
        whisper.process_file(args.audio_file)
    else:
        parser.print_help()

poetry.lock

Added the Groq library dependency:+[[package]]
+name = "groq"
+version = "0.9.0"
+description = "The official Python library for the groq API"
+optional = false
+python-versions = ">=3.7"
+files = [
+    {file = "groq-0.9.0-py3-none-any.whl", hash = "sha256:d0e46f4ad645504672bb09c8100af3ced3a7db0d5119dc13e4aca535fc455874"},
+    {file = "groq-0.9.0.tar.gz", hash = "sha256:130ed5e35d3acfaab46b9e7a078eeaebf91052f4a9d71f86f87fb319b5fec332"},
+]

pyproject.toml

Updated to include Groq:+groq = "^0.9.0"

Reason for Changes

Integration with Groq API: To support transcription using the Groq API in addition to OpenAI, providing more flexibility and options for users.
Enhanced Argument Handling: To allow users to specify models and list available models, improving usability.
Temporary File Handling: To avoid undesired leftover local files.

Impact of Changes

Flexibility: Users can now choose between OpenAI and Groq models for transcription, increasing the utility of the tool.
Usability: Improved command-line interface with better argument handling and model listing capabilities.

Test Plan

Model Listing: Run the script with the --listmodels argument to verify that available models from both OpenAI and Groq are listed correctly.
Transcription: Test transcription with both OpenAI and Groq models to ensure that audio files are processed and transcribed accurately.
Error Handling: Verify that appropriate error messages are displayed when API keys are missing or models are unavailable.

Additional Notes

Ensure that environment variables for OpenAI and Groq API keys are set correctly before testing.

Moving to go. Please resubmit if this isn't fixed after the migration.

What happened with this? It would be great to be able to natively support whisper transcription via Groq's whisper-large-v3


update cpm to v0.40.2

Updates CPM to latest version.

This PR seems to break some CI tests.

I don't think that the problem is necessarily with the CPM update. Something might be messed up with the two failing CI components. I can build locally with the alpine distribution.

I am merging this. We'll figure it out.


Minor typo in Sample skill definition 3

At the end of this text "Sample skill definition 3: Merge values from two fields into one
In this example, some sentences have a frenchSentiment property. Whenever the frenchSentiment property is null, we want to use the englishSentiment value. We assign the output to a member that's called sentiment ("/document/sentiment//sentiment")."
in my opinion the correct output should be "/document/sentences//sentiment"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b61fad67-f6ff-58a3-1ed9-317d7b91983c
Version Independent ID: 4c166829-facb-b7c9-8a06-0c6f5b0ef009
Content: Conditional cognitive skill - Azure Cognitive Search
Content Source: articles/search/cognitive-search-skill-conditional.md
Service: cognitive-search
GitHub Login: @LuisCabrer
Microsoft Alias: luisca

@ignaciofls Thank you for reporting this.  We will investigate and update the thread.

ignaciofls, Based on your feedback, we have raised a PR and it's merged. The doc would reflect the changes made shortly. Thanks again for your feedback.


Wrong command line help for -cg

https://github.com/OPCFoundation/UA-ModelCompiler/blob/c57e4580cf961ef8b593b1e6e4c3637441c62804/ModelCompiler/HelpFile.txt#L8
The only difference between -c and -cg is that -c throws an exception if the specified CSV file is not found. -cg reads the specified CSV if exists as well as -c. "instead of reading it" is wrong. Please improve the explanations.

Manually added to:
https://github.com/OPCF-Members/UA-ModelCompiler/commit/a89140db494cd99e1ebe935d6a82d890912f1250
Will merge to public repo in the next week or so.

Old issue.


EvmDatabase spec - test that actual unmocked seed won't throw

This adds a spec that actually runs EvmDatabase.seed, and fails if it throws.
This is to prevent situations where rake db:seed is broken but all tests are green.
It's a bit of a time hog unfortunately:
before:
$ be rspec spec/lib/evm_database_spec.rb
...
Finished in 0.82741 seconds (files took 6.38 seconds to load)
20 examples, 0 failures

now:
Finished in 29.78 seconds (files took 7.59 seconds to load)
21 examples, 0 failures

But, crucially, it does catch problems like the recent db:seed breakage introduced by https://github.com/ManageIQ/manageiq/pull/18778 and fixed in https://github.com/ManageIQ/manageiq-providers-ovirt/pull/370.
Without the fix:
  1) EvmDatabase.seed doesn't fail
     Failure/Error:
       expect do
         described_class.seed
       end.not_to raise_error

       expected no Exception, got #<NoMethodError: undefined method `position' for nil:NilClass> with backtrace:
         # ./lib/services/dialog_import_service.rb:179:in `block in absolute_position'
         # ./lib/services/dialog_import_service.rb:177:in `collect'
         # ./lib/services/dialog_import_service.rb:177:in `absolute_position'
         # ./lib/services/dialog_import_service.rb:164:in `build_old_association_list'
         # ./lib/services/dialog_import_service.rb:154:in `block in import_from_dialogs'
         # ./lib/services/dialog_import_service.rb:143:in `each'
         # ./lib/services/dialog_import_service.rb:143:in `import_from_dialogs'
         # ./lib/services/dialog_import_service.rb:41:in `import_all_service_dialogs_from_yaml_file'
         # ./app/models/dialog.rb:26:in `block (2 levels) in seed'
         # ./app/models/dialog.rb:25:in `each'
         # ./app/models/dialog.rb:25:in `block in seed'
         # ./lib/vmdb/plugins.rb:23:in `each'
         # ./lib/vmdb/plugins.rb:23:in `each'
         # ./lib/vmdb/plugins.rb:11:in `method_missing'
         # ./app/models/dialog.rb:24:in `seed'
         # ./lib/evm_database.rb:94:in `block (4 levels) in seed_classes'
         # ./lib/evm_database.rb:94:in `block (3 levels) in seed_classes'
         # ./lib/evm_database.rb:92:in `each'
         # ./lib/evm_database.rb:92:in `block (2 levels) in seed_classes'
         # ./lib/extensions/ar_table_lock.rb:21:in `block (2 levels) in with_lock'
         # ./lib/extensions/ar_table_lock.rb:21:in `block in with_lock'
         # ./lib/extensions/ar_table_lock.rb:15:in `with_lock'
         # ./lib/evm_database.rb:91:in `block in seed_classes'
         # ./lib/evm_database.rb:89:in `seed_classes'
         # ./lib/evm_database.rb:62:in `seed'
         # ./spec/lib/evm_database_spec.rb:48:in `block (4 levels) in <top (required)>'
         # ./spec/lib/evm_database_spec.rb:47:in `block (3 levels) in <top (required)>'
     # ./spec/lib/evm_database_spec.rb:47:in `block (3 levels) in <top (required)>'

Cc @Fryguy

cc @bdunne ... once you create your "seed before we run tests" PR, then this test won't be needed anymore.


Rasmusgo/hot reload custom shaders

This improves the system for hot reloading by exposing a list of recently updated files and allowing custom shaders to be stored in the engine and updated by the hot reload system. The engine doesn't know how to use the shaders so the app must handle that itself. This is done by the custom rendering example.

Closed in favor of #424.


asks to select kit on every startup, also on non c++ projects

Every time i open a folder it asks me to select a kit. Can this be disabled?

"cmake.configureOnOpen": false,

thank you!


Scaling one dimension doesn't scale the domain box as well

Hi,
actually I don't know if it's a bug or it's me that I'm doing something wrong.
I want to rescale one dimension in a 3D Volume plot. Under "Transformation -> Scale", I rescale Z to be twice the original dimension, but the transformation doesn't apply to the domain frame. So I have a 3D surface plot having one dimension doubled and the reference frame which cannot contain the whole plot.
Hope I sufficiently explained what's my issue.
Thanks in advance.

Yes, that makes sense.  Each renderer has its own transform.  Additionally, each loaded dataset has a transform.  The Z scaling that is applied to your Volume renderer will not be applied to other instances.
The transform for the entire dataset can be found under Scene->Viewpoint->Transform.  Hope that helps.

That's great! Thank you so much.
Regards,


Does StackRox/ACS have plans to support the Harbor image repository and its vulnerability scanning?

Does the official team have such plans?
I plan to integrate a Harbor client, is it acceptable?

There are no plans to support Harbor at this time


cigien: Watch dailyexcel.net

cigien requests the watch of the watch_keyword dailyexcel\.net. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

dailyexcel\.net has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Create new option instead of hardcoding 'pre-appx'

Hello, I'm currently using only few parts of the whole chain to rebuild and sign my app after doing incremental changes rather than having it rebuilt from ground up every time. The source folder in makeappx.js (and in few other places) is currently hardcoded pre-app which forces me to restructure the app's repo around this.
It would be nice if a new options field could be dedicated to that and replace this
let source = path.join(program.outputDirectory, 'pre-appx')

with something like
let source = program.sourceDirectory

and this somewhere in setup
program.sourceDirectory = path.join(program.outputDirectory, 'pre-appx')

Also similarly to this being able to set destination path of the .appx would be awesome.

Sounds good! Would you want to make a PR?

Yes. Though i ended up deep inside the rabbit hole while working on my incremental bundler and I'd like to bring that over to this module as well if you'd be open to it. However that would require a bit more discussion, preferably over instant messenger.
This is what I got so far. Needless to say that the code is ugly :D since i had to customize makeappx() and create the program object from scratch and it was 2am but i wanted to get it to work :D
The code reads publisher and package name from manifest, bumps version number, creates appx and signs it (and creates the certificates if they don't exist yet).
https://github.com/MikeKovarik/anchora-app/blob/master/windows-store-bundler.js
I'm also thinking of how package.json could be supported. I think version number could be bumped in package.json and then patched into the AppxManifest.xml so they both match. Or maybe even generating the AppxManifest.xml from scratch based on package.json and /Assets.
The idea is that app's repo could contain pretty much just the app's source + /Assets and contributors would be able to just clone it and build it with something like gulp transpile and then gulp appx.


Test unit test

Signed-off-by: wanglei01<EMAIL_ADDRESS>Reason for This PR
[Author TODO: add issue # or explain reasoning.]
Description of Changes
[Author TODO: add description of changes.]
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[ ] All commits in this PR are signed (git commit -s).
[ ] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any newly added unsafe code is properly documented.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.

Codecov Report

Merging #20 (bb001cf) into main (ad23886) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   96.37%   96.39%   +0.01%
==========================================
  Files           9        9
  Lines        2596     2608      +12
==========================================
+ Hits         2502     2514      +12
  Misses         94       94

Impacted Files
Coverage Δ

src/server.rs
93.92% <ø> (+0.13%)
:arrow_up:

src/connection.rs
98.41% <0.00%> (+<0.01%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


wrong warning message if using yarn link

If using yarn link and not installing devDependencies the warning message was shown cause VersionChecker(this) checks versions of the addons dependencies not the ones of the consuming application.
This issue was highlighted by undefined in the warning message:

For Bootstrap 4 support this version of ember-bootstrap requires at least Bootstrap 4.0.0-beta, but you have undefined. Please run ember generate ember-bootstrap to update your dependencies!

Rwjblue explained me that difference some time ago: https://github.com/rwjblue/ember-cli-content-security-policy/pull/121#pullrequestreview-335292964

Thanks!
Btw, CI is currently failing on master, as some package seems to have dropped node 8 support without a major version bump. But I am not going to "fix" this, as I would expect that we can merge dev-v4 to master hopefully soon, right?


Update all dependencies to latest and support ESM

It'd be great to support both ESM and CJS here.
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

support both ESM and CJS

I'd like to clarify my interpretation of the intent of the issue. The way I understand it, we'd like to convert the (currently) CommonJS title package into a pure ESM project. That would imply a breaking change for CommonJS consumers of the title package that would force them to pursue one of the 3 options presented at the beginning of the linked gist.
i.e., the "support" for CJS would come from the following point made in the gist:

If the package [e.g., title] is used in an async context, you could use await import(…) from CommonJS instead of require(…).

Would that interpretation be correct?

So that document shows how to make a pure ESM package. There are pros to that. If possible, it would be great to support both CJS and ESM for best backwards compat. I'm not an expert here, but ms recently made this change.
https://github.com/vercel/ms/pull/163


ARC: Fix portability.posix.common.arcmwdtlib test

portability.posix.common.arcmwdtlib test fails with ARCMWDT libc. This path fixes the test.
STDIN_FILENO and others macros  are used in libc-hooks.c only. So they defined locally.
Fixes: #59093

@evgeniy-paltsev could please you take a look at this draft?

Please check that this is compatible with https://github.com/zephyrproject-rtos/zephyr/pull/58924

@kokas-a - can you please rebase / resolve conflicts?


Grouping external IPs in ServiceOptions for v1beta1

Closes #354.

About tenant.spec.serviceOptions.externalIPs. It has been implemented to mitigate CVE-2020-8554 by preventing the tenant owner to use external IPs in services. According to the documentation, an empty list allowed: [] means no IPs are allowed and this makes sense to me.
The kubectl explain says now: An empty list means all the IPs are allowed.
However it looks as is not the observed behaviour:
apiVersion: capsule.clastix.io/v1beta1
kind: Tenant
metadata:
  name: gold
spec:
  owners:
  - kind: User
    name: alice
  ingressClasses:
    allowed: []
  storageClasses:
    allowed: []
  serviceOptions:
    externalIPs:
      allowed: []

As tenant owner
$ kubectl --as alice --as-group capsule.clastix.io create ns gold-mining
$ kubectl --as alice --as-group capsule.clastix.io apply -f - <<EOF
apiVersion: v1
kind: Service
metadata:
  name: example
  namespace: gold-mining
spec:
  selector:
    app: my-evil-dns-server
  ports:
    - name: dns
      protocol: UDP
      port: 53
      targetPort: 9053
  externalIPs:
    - <IP_ADDRESS>
EOF

Error from server (The current Tenant does not allow the use of Service with external IPs): error when creating "STDIN": admission webhook "services.capsule.clastix.io" denied the request: The current Tenant does not allow the use of Service with external IPs

$ kubectl --as alice --as-group capsule.clastix.io apply -f - <<EOF
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: example
  namespace: gold-mining
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 8Gi
  storageClassName: not-allowed
EOF

Error from server (Storage Class not-allowed is forbidden for the current Tenant): error when creating "STDIN": admission webhook "pvc.capsule.clastix.io" denied the request: Storage Class not-allowed is forbidden for the current Tenant

$ kubectl --as alice --as-group capsule.clastix.io apply -f - <<EOF
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: example
  annotations:
    kubernetes.io/ingress.class: example
  namespace: gold-mining
spec:
  rules:
    - host: example.com
      http:
        paths:
          - path: /testpath
            backend:
              serviceName: test
              servicePort: 80
EOF

Error from server (Ingress Class example is forbidden for the current Tenant): error when creating "STDIN": admission webhook "ingress.capsule.clastix.io" denied the request: Ingress Class example is forbidden for the current Tenant

On the other side
apiVersion: capsule.clastix.io/v1beta1
kind: Tenant
metadata:
  name: silver
spec:
  owners:
  - kind: User
    name: alice
  ingressClasses:
    allowed: []
  storageClasses:
    allowed: []
  serviceOptions:
    externalIPs:
      allowed:
      - <IP_ADDRESS>

As tenant owner:
kubectl --as alice --as-group capsule.clastix.io create ns silver-mining
$ kubectl --as alice --as-group capsule.clastix.io apply -f - <<EOF
apiVersion: v1
kind: Service
metadata:
  name: example
  namespace: silver-mining
spec:
  selector:
    app: my-evil-dns-server
  ports:
    - name: dns
      protocol: UDP
      port: 53
      targetPort: 9053
  externalIPs:
    - <IP_ADDRESS>
EOF
service/example created

kubectl --as alice --as-group capsule.clastix.io apply -f - <<EOF
apiVersion: v1
kind: Service
metadata:
  name: example2
  namespace: silver-mining
spec:
  selector:
    app: my-evil-dns-server
  ports:
    - name: dns
      protocol: UDP
      port: 53
      targetPort: 9053
  externalIPs:
    - <IP_ADDRESS>
EOF

Error from server (The selected external IPs for the current Service are violating the following enforced CIDRs: <IP_ADDRESS>): error when creating "STDIN": admission webhook "services.capsule.clastix.io" denied the request: The selected external IPs for the current Service are violating the following enforced CIDRs: <IP_ADDRESS>

Getting confused ...

The issue is that the CRD documentation introduced with changes on #344 is wrong: we should adhere to the docs.
Going to provide a further commit to fix this.


no error for assigning to control flow keyword

Steps to reproduce
Run this shell command:
vim -Nu NONE -S <(tee <<'EOF'
    vim9script
    var endif = 0
EOF
)

No error is given.
Expected behavior
An error is given:
E1234: cannot use reserved keyword endif

Version of Vim
9.0 Included patches: 1-432
Environment
Operating system: Ubuntu 20.04.5 LTS
Terminal: XTerm(353)
Value of $TERM: xterm-256color
Shell: GNU bash, version 5.0.17
Additional context
If we don't give any error right now, then a confusing error will be given later, whenever we try to use an if block:
vim9script
var endif = 0
if true
endif

E1207: Expression without an effect: endif

If we assign to if, no error is given either.  Not even if we use an if block later:
vim9script
var if = 123
if true
    echo if
endif

123

Why is it OK to assign to if but not to endif?  It seems inconsistent, and confusing.  The rules would be easier to understand if it was simply disallowed to assign to any control flow keyword.

Never mind, it's working as intended:
https://github.com/vim/vim/blob/6de2296e5e696b894576d48239aaab0ae84486ff/runtime/doc/vim9.txt#L441

Variables may shadow Ex commands, rename the variable if needed.

Although, I still think it's confusing and should be disallowed for control flow keywords.

Never mind, it's working as intended:
https://github.com/vim/vim/blob/6de2296e5e696b894576d48239aaab0ae84486ff/runtime/doc/vim9.txt#L441

Variables may shadow Ex commands, rename the variable if needed.

Although, I still think it's confusing and should be disallowed for
control flow keywords.

Yes, it can be a bit confusing.  Although, for common command names it
will be obvious that you are shooting yourself in the foot.
The rationale is that we wanted to get rid of "let" for assignments,
just to "varname = expr".  That means we need to recognize "varname" as
a variable name, not a command.  This is tricky.  Many adjustments were
made to the code that figures out the command from the start of the line
until it worked well.
We will always add new commands later.  E.g. we recently added
"horizontal".  It is not unlikely that someone used that for a variable
name.  Then by adding the command we would break someone's script.  Or
when someone updates Vim a year later several things start breaking
because of any new commands.
We could reject some variable names such as "endif", but that quickly
becomes inconsistent and gives the user the idea that if a name is
allowed that it will work.  It's easier and probably better to give the
user the responsibility of using a good name.
--
He who laughs last, thinks slowest.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Yes, it can be a bit confusing.  Although, for common command names it
will be obvious that you are shooting yourself in the foot.

I was thinking about something like this:
vim9script
var x = 'endif'
$'var {x} = 0'->execute()
 # ...
 # much later in the code
 # ...
if true
endif

E1207: Expression without an effect: endif

If the value assigned to x is hard to predict (e.g. it comes from the user), the code might sometimes work, and sometimes fail.  And when it fails, it might be hard to understand why (especially if the error is far away from the real cause).

We will always add new commands later.  E.g. we recently added
"horizontal".  It is not unlikely that someone used that for a variable
name.  Then by adding the command we would break someone's script.  Or
when someone updates Vim a year later several things start breaking
because of any new commands.

I understand, but even though control flow keywords are technically Ex commands, they stil have a special status in other languages.  Which Vim9 recognizes since it does not allow them to be abbreviated.  We already make an exception with regards to abbreviations.  We could have added one more exception with regards to assignments.  BTW, Python does not allow if to be assigned either:
$ python -c 'if = 0'
  File "<string>", line 1
    if = 0
       ^
SyntaxError: invalid syntax

We could reject some variable names such as "endif", but that quickly
becomes inconsistent and gives the user the idea that if a name is
allowed that it will work.

I find the current situation already inconsistent.  I'm still not sure why an endif assignment is able to shadow endif when used to end a block, while at the same time an if assignment does not shadow an if when used to open a block.
Anyway, I was just suggesting that we disallow the same list of Ex commands which cannot be abbreviated.  Because this restriction should already make the user understand that those commands are special.

if
else
elseif
endif
for
endfor
while
endwhile
try
catch
finally
throw
endtry
def
enddef
break
continue
return
finish
var
const
export
import

I'm still not sure why an endif assignment is able to shadow endif when used to end a block, while at the same time an if assignment does not shadow an if when used to open a block.

OK, now I understand.  For some commands, Vim does not allow an unconditinal shadowing.  That is, it lets an expression shadow a command only when it makes sense.  That's why if true works even if we assigned something to if.  Because {expr} true does not make sense (it would if there was a binary operator between the 2 tokens).  So, it falls back on {cmd} true.
That's not so bad.  And that's what the previous adjustments probably referred to.
But then, Vim should do something similar with endif.  {expr} by itself does not make sense if the evaluation of {expr} has no side effect.

But then, Vim should do something similar with endif.  {expr} by
itself does not make sense if the evaluation of {expr} has no side
effect.

It's a bit hard to figure out.  At least "endif->func()" could work.
We also have the warning for a statement with no effect to catch things
like this.  It's not perfect though.
  What have you
lost?  Nothing!
-- Monty Python: The life of Brian
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Yes, it can be a bit confusing.  Although, for common command names it
will be obvious that you are shooting yourself in the foot.

I was thinking about something like this:
vim9script
var x = 'endif'
$'var {x} = 0'->execute()
 # ...
 # much later in the code
 # ...
if true
endif

E1207: Expression without an effect: endif

If the value assigned to x is hard to predict (e.g. it comes from
the user), the code might sometimes work, and sometimes fail.  And
when it fails, it might be hard to understand why (especially if the
error is far away from the real cause).

I don't think this is common enough to worry about.

We will always add new commands later.  E.g. we recently added
"horizontal".  It is not unlikely that someone used that for a variable
name.  Then by adding the command we would break someone's script.  Or
when someone updates Vim a year later several things start breaking
because of any new commands.

I understand, but even though control flow keywords are technically Ex
commands, they stil have a special status in other languages.  Which
Vim9 recognizes since it does not allow them to be abbreviated.  We
already make an exception with regards to abbreviations.  We could
have added one more exception with regards to assignments.  BTW,
Python does not allow if to be assigned either:
$ python -c 'if = 0'
  File "<string>", line 1
    if = 0
       ^
SyntaxError: invalid syntax

That is exactly the problem, Python doesn't mind breaking existing
scripts when adding a new keyword.  I know, because a program I wrote
suddenly failed in mysterious ways.  It took quite a bit of debugging to
discover it started because the version of Python had increased and it
added a keyword that I used in another way.  I don't want that to
happen.

We could reject some variable names such as "endif", but that quickly
becomes inconsistent and gives the user the idea that if a name is
allowed that it will work.

I find the current situation already inconsistent.  I'm still not sure
why an endif assignment is able to shadow endif when used to end a
block, while at the same time an if assignment does not shadow an
if when used to open a block.
Anyway, I was just suggesting that we disallow the same list of Ex
commands which cannot be abbreviated.  Because this restriction should
already make the user understand that those commands are special.

It still looks like a fairly arbitrary list to me.  More importantly, if
we give an error "you can't use 'endif' for a variable name", people
think that if you don't get this error it is fine.  But it isn't, it can
still interfere with a command.  And we would give an error for names
that are obviously commands, and not give an error for commands the user
might not know about.  Thus it's opposite of what would be good.
--
I started out with nothing, and I still have most of it.
-- Michael Davis -- "Tonight Show"
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Basic templating help

Hi, I'm very new to working with Craft and I'm trying to set up a simple anonymous guest comments functionality on a client's blog entry page. Could anyone give me a hand? The code from the included 'standard.html' is in, but when I submit a test comment I get an error:

I'm assuming I'm missing some crucial params and/or reference to the 'element.id' but not clear what this is... The craft handle for the section I want to use this in is 'blog'.
Here's what's in my template:
THANKS!
`{% set params = {
order: 'dateCreated asc',
} %}
	{{ craft.comments.form(blog.id, params) }}

	<script src="https://code.jquery.com/jquery-2.1.3.min.js"></script>
	<script>
	//
	// Below is the most minimal non-ajax JS to get started with. Mainly used to toggle
	// element such as the edit comment form, inline-reply form and showing/hiding replies.
	//
	$(document).ready(function() {
		// Toggle to show/hide replies
		$(document).on('click', 'a.comment-toggle', function(e) {
			e.preventDefault();
			$(this).parents('.comment-single:first').find('.comments-list:first').toggle();
		});
		// Toggle to show/hide reply form
		$(document).on('click', 'a.comment-reply', function(e) {
			e.preventDefault();
			$(this).parents('.comment-single:first').find('.comment-form').toggle();
		});
		// Handle editing
		$(document).on('click', 'a.comment-edit', function(e) {
			e.preventDefault();
			// Simply hides text and shows form
			$(this).parents('.comment-text').find('.comment-content').hide();
			$(this).parents('.comment-text').find('.edit-comment-form').show();
		});
	});
	</script>`

Ah, fixed it! should have been 'entry.id' not 'blog.id'. Works like a charm.

Hey @robinbeatty86 Glad you sorted it - beat me to it!


Error setting serial port latency, unable to reset UART afterwards, Jetson TX2

When running the router on a NVIDIA Jetson TX2 dev kit running stock jetpack, the router throws an error stating:
"Error while trying to write serial port latency: Unknown error -1"
the command is:
mavlink-routerd /dev/ttyTHS2 -e <IP_ADDRESS>:49411
The port does appear to be set correctly, as the router works as intended after this. I can confirm with stty; the port is at 9600 at boot, and after running mavlinkrouter the port is now at 115200
That said, if I stop and restart the router, it fails to start, saying "could not reset uart"
in this state, stty says "input/output error" when I query the port.
It does it same behavior on all the ttyTHS# ports, even if no serial device is attached to them.
I am able to configure and view the serial data using screen as many times as desired.
I am attaching straces from the initial run, and the second failed run.
strace_second.5557.txt
strace_first.5543.txt
Any help would be greatly appreciated, and am happy to run any troubleshooting tests as might be required.

ioctl(4, TCGETS, 0x7fe6d94620)          = -1 EIO (Input/output error)

Humn... since we are trying to reset the uart, maybe we could just write instead of querying the previous state.

I have found the problem seems related to the fact that ioctl TIOCSSERIAL may not be supported by newer kernels.

I think that rather than "new kernels", the problem is more that not every serial is behind a USB bus, not every tty driver in the Linux kernel are forced to implement this method (see drivers/tty/tty_io.c:tty_tiocsserial) and that you may be hitting a bug on a particular driver.

Is this the same issue?
Ubuntu 18.04.5 LTS Kernal 5.4.0-51
Could not reset uart
mavlink-routerd -e <IP_ADDRESS>:14550 -e <IP_ADDRESS>:14550 /dev/ttyACM0:115200

Quuite probably it seems the authors expect a usb serial reguardless of the device used. I suggest a switch on device name
ttySnn vs ttyUSBnn to enable the code

@GerardHale / @ACPAviation it gives you a warning if it can't set it. But it should continue to work regardless of that. I checked the code and it seems to be the case.

I faced the same issue
It seems that the reset_uart is doing something wrong when closing the connection
I fixed it by commenting this line in UartEndpoint destructor : https://github.com/mavlink-router/mavlink-router/blob/51c72ffdce5ffb9d3f07010cd00de9dca4f8af4c/src/mavlink-router/endpoint.cpp#L491

I faced the same issue
It seems that the reset_uart is doing something wrong when closing the connection
I fixed it by commenting this line in UartEndpoint destructor : https://github.com/mavlink-router/mavlink-router/blob/51c72ffdce5ffb9d3f07010cd00de9dca4f8af4c/src/mavlink-router/endpoint.cpp#L491


Unable to build Andorid Project

Steps to reproduce
Application fails to build when using Patrol CLI on Andorid.
My project uses kotlin_version 1.7.10 and gradle distribution 7.5. I'm unable to migrate to Kotlin version 1.9.20 and distribution 8.4 due to a number of dependencies still needing to migrate to the latest build tools. However, these versions are in alignment when creating a new Flutter project.
Actual results
Patrol version 3.0.2+ returns the following error:
patrol test --target integration_test/example_test.dart --flavor staging --verbose

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

Patrol version 3.0.1 or earlier returns the following error:
patrol test --target integration_test/example_test.dart --flavor staging --verbose

    > Could not open proj generic class cache for build file '/Users/jonathantrowbridge/.pub-cache/hosted/pub.dev/patrol-3.0.1/android/build.gradle' (/Users/jonathantrowbridge/.gradle/caches/7.5/scripts/d9gnyoqxmzlxg89jpeucpxvkl).
           > BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 64

Downgrading Java to 17.0.9 results in the following error:
export JAVA_HOME=`/usr/libexec/java_home -v 17.0.9`
patrol test --target integration_test/example_test.dart --flavor staging --verbose

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

Logs

Logs
        BUILD FAILED in 25s
        :
        : Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
        :
        : You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
        :
        : See https://docs.gradle.org/7.5/userguide/command_line_interface.html#sec:command_line_warnings
        : 628 actionable tasks: 12 executed, 616 up-to-date
✗ Failed to execute tests of apk with entrypoint test_bundle.dart on emulator-5554 (Gradle test execution failed with code 1) (26.1s)
Exception: Gradle test execution failed with code 1
#0      AndroidTestBackend.execute.<anonymous closure> (package:patrol_cli/src/android/android_test_backend.dart:140:9)
<asynchronous suspension>
#1      DisposeScope.run (package:dispose_scope/src/dispose_scope.dart:46:7)
<asynchronous suspension>
#2      AndroidTestBackend.execute (package:patrol_cli/src/android/android_test_backend.dart:106:5)
<asynchronous suspension>
#3      TestCommand._execute (package:patrol_cli/src/commands/test.dart:272:7)
<asynchronous suspension>
#4      TestCommand.run (package:patrol_cli/src/commands/test.dart:169:23)
<asynchronous suspension>
#5      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#6      PatrolCommandRunner.runCommand (package:patrol_cli/src/runner/patrol_command_runner.dart:318:18)
<asynchronous suspension>
#7      PatrolCommandRunner.run (package:patrol_cli/src/runner/patrol_command_runner.dart:262:18)
<asynchronous suspension>
#8      patrolCommandRunner (package:patrol_cli/src/runner/patrol_command_runner.dart:68:20)
<asynchronous suspension>
#9      main (file:///Users/jonathantrowbridge/.pub-cache/hosted/pub.dev/patrol_cli-2.3.1+1/bin/main.dart:6:20)
<asynchronous suspension>

See the logs above to learn what happened. Also consider running with --verbose. If the logs still aren't useful, then it's a bug - please report it.
Uninstalling com.coinme.coinme from sdk gphone64 arm64
Uninstalling com.coinme.coinme.test from sdk gphone64 arm64

Patrol version
3.0.1 as well as 3.0.2+
Patrol Doctor output

Patrol Doctor output
Patrol CLI version: 2.3.1+1
Program adb found in /Users/jonathantrowbridge/Library/Android/sdk/platform-tools/adb
Env var $ANDROID_HOME set to /Users/jonathantrowbridge/Library/Android/sdk
Program xcodebuild found in /usr/bin/xcodebuild
Program ideviceinstaller found in /opt/homebrew/bin/ideviceinstaller

Flutter Doctor output

Flutter Doctor output
[✓] Flutter (Channel stable, 3.16.2, on macOS 14.1 23B74 darwin-arm64, locale en-US)
    • Flutter version 3.16.2 on channel stable at /Users/jonathantrowbridge/Library/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9e1c857886 (5 days ago), 2023-11-30 11:51:18 -0600
    • Engine revision cf7a9d0800
    • Dart version 3.2.2
    • DevTools version 2.28.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/jonathantrowbridge/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/jonathantrowbridge/Library/Android/sdk
    • Java binary at: /Users/jonathantrowbridge/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/jonathantrowbridge/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.1)
    • IntelliJ at /Users/jonathantrowbridge/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.5)
    • IntelliJ at /Users/jonathantrowbridge/Applications/IntelliJ IDEA Ultimate 2023.1.5.app
    • Flutter plugin version 75.1.3
    • Dart plugin version 231.9392.3

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 13 (API 33) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS 14.1 23B74 darwin-arm64
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 119.0.6045.199

[✓] Network resources
    • All expected network resources are available.

• No issues found!
 jonathantrowbridge@JonathansLaptop  ~  flutter doctor -v
[✓] Flutter (Channel stable, 3.16.2, on macOS 14.1 23B74 darwin-arm64, locale en-US)
    • Flutter version 3.16.2 on channel stable at /Users/jonathantrowbridge/Library/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9e1c857886 (5 days ago), 2023-11-30 11:51:18 -0600
    • Engine revision cf7a9d0800
    • Dart version 3.2.2
    • DevTools version 2.28.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/jonathantrowbridge/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/jonathantrowbridge/Library/Android/sdk
    • Java binary at: /Users/jonathantrowbridge/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/jonathantrowbridge/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.1)
    • IntelliJ at /Users/jonathantrowbridge/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.5)
    • IntelliJ at /Users/jonathantrowbridge/Applications/IntelliJ IDEA Ultimate 2023.1.5.app
    • Flutter plugin version 76.3.3
    • Dart plugin version 231.9409

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.1 23B74 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 119.0.6045.199

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Same issue for me. Already working on jdk 17 even after changing to jdk 11 it's showing an error. It's better that the patrol developers should suggest the dependencies version in order to get rid of these kind of issues

Same issue for me.


bal test --native fails in ubuntu without test report for ballerinax/persist.googlesheets

Description:
Ballerina graalvm check workflow fails for the PR#14 with the error error: there are test failures without generating any reports.
Running Tests

	persist.googlesheets
ballerina: HTTP trace log enabled
error: there are test failures

> Task :persist.googlesheets-ballerina:build FAILED

Until the issue is fixed, we will disabled the test cases for graalvm build and merge the PR


(PUP-11895) ssl application's clean shouldn't allow extra args

If a user attempts to get rid of some certs and confuses puppetserver ca clean with puppet ssl clean, there is a chance it will wipe out keys/certs that were not intended. This commit adds some safeguards to the ssl clean subcommand to try to avoid that scenario.

Sorry forgot to mention, could you rebase on 7.x?


Bank account - Blank validation page displayed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue was found when executing #5251
Action Performed:

Create a new user
Create workspace via the global create menu
Select 'Get Started' after the workspace is created
Go through VBA setup using the test credentials in , and arrive at Validate step

Expected Result:
There should be no animated image
There should be a button at the bottom marked 'Got it'
Actual Result:
Blank validation page displayed
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:  1.0.99-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/133539471-7a813821-3f3c-409c-a798-417ba9c452b5.mp4
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

We are not able to test in production due to credentials

cc: @Julesssss I think this may be related to https://github.com/Expensify/App/pull/5251

Thanks, I think you're right -- but have no idea why this wasn't seen during development 😕

I will deal with this after I resolve this other deployBlocker: https://github.com/Expensify/App/issues/5291

I was blocked for a while by Onfido, but managed to pass the check using an iPhone. Unable to reproduce this bg on staging, version v1.0.99-1:
https://user-images.githubusercontent.com/10736861/133642715-742ba781-dcc9-4013-8d81-b95ad7cb119f.mov

Mabe it's unique to safari

I was able to reproduce on staging on Safari by following #1 inthe SO except I copied @Julesssss and did not use REAL credentials in the personal info step:

Interestingly, when I exited the flow I saw the expected Concierge message and when I re-entered the add bank account flow I saw the expected Validate screen message:

Separately, I was unable to reproduce on production. Using the same creds, I reached the expected Validate screen here:

Thanks, @MitchExpensify! I suggest we revert this PR while I figure out how to reproduce on dev.

Raised a revert PR here, I'll try to reproduce this and fix locally tomorrow.

Hmm, this might actually be a duplicate of this issue. Trying to verify.

Struggling to verify this locally. Even though I think the UI changes have not triggered this regression I think to help with debugging we should merge the revert. This will mean that we can test this issue repeatedly on staging.

Closing this issue as we are fairly certain that the issue was already occurring here. Slack discussion.


Add At The Speed of Light (Soullspa Cover) by Dimrain47

Song Name
At The Speed of Light (Soullspa Cover)
Artist Name
Dimrain47
Source
Youtube
Youtube Link
rqfTO2vaKaM
Direct File Link
No response
Song ID
467339
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 3979721

reject


[Bug] c2cpg: check if we can improve ambiguous template calls

kind of related to #2558 because it's also about ambiguity:
joern> importCode.cpp.fromString("""
       #include <array>

       // struct bar {};

       void a() {
           std::array<bar, 64> foobar{};
       }
       """) ; cpg.call.methodFullName.p
res127_0: Cpg = Cpg (Graph [68 nodes])
res127_1: List[String] = List(
  "<operator>.expressionList",
  "<operator>.lessThan",
  "<operator>.fieldAccess",
  "<operator>.greaterThan",
  "foobar",
  "<operator>.arrayInitializer"
)

Uncommenting the struct bar {}; things are parsed "correctly", but without it we get these less than / greater than calls.
Again, I don't know how rich the CDT parse tree is here. If possible, erring on the side of "probably a templated call" seems like it would usually give better results.

Yes, same issue as in https://github.com/joernio/joern/issues/2558.
Will check later.


Add StreamMgr client and MetricsMgr client for python topology

They are used to communicate with stream managers and metrics managers for Python heron instance.
Related PR: #1196
Note that st_stmgr_client.py provides StreamMgr client for single-thread heron instance.

👍

@objmagic - do you have any comments on this?

Other than some place which use string concatenation instead of formatter, this PR looks fine.

@taishi8117 - can you please take care of @objmagic feedback and we should be good to merge it.

@kramasamy They should have been fixed in https://github.com/twitter/heron/pull/1197/commits/4ab7e4f586e05cb8925e7c9cd2f00d8b005df11c and https://github.com/twitter/heron/pull/1197/commits/e0ecb77124984d9f5c908c8536a574c7c31a75f2.


Fill store/fetch data on route prefetch

What problem does this feature solve?
Routes are now able to be prefetched similair to quicklink. The problem is that there still needs to be  data fetched for some routes which implement asyncData and/or fetch. This can be solved by enabling the page to prefetch data or fill the store before the route is being requested.
Prefetching can be done before the actual route transition. That means, that it's possible that the data is fetched while the route transition will never happen. Some Nuxt.js project might have implemented fetch and asyncData in a way that it requires the route transition to happen.
What does the proposed changes look like?
There could either be a new method being introduced called prefetch on page components or there could be a flag which enables prefetching on fetch and/or asyncData. This way, this feature is backwardscompatible.

This feature request is available on Nuxt community (#c8571)

We are approaching the Nuxt 2 EOL date (June 30, 2024) - see this article for more information. I'm closing this issue as it's marked as a Nuxt 2 related enhancement and it's not a critical issue.
That doesn't mean it might not be relevant for Nuxt 3. If it is, please feel free to open a new issue (or just comment, and I can reopen it). 🙏
Thank you for your understanding and for your contribution to Nuxt! 🎉


Meshlet single pass depth downsampling (SPD)

Objective

Using multiple raster passes to generate the depth pyramid is extremely slow
Pulling data from the source image is the largest bottleneck, it's important to sample in a cache-aware pattern
Barriers and pipeline drain between the raster passes is the second largest bottleneck
Each separate RenderPass on the CPU is really expensive

Solution

Port FidelityFX SPD to WGSL, replacing meshlet's existing multiple raster passes with a single two compute dispatches. Lack of coherent buffers means we have to do the the last 64x64 tile from mip 7+ in a separate dispatch to ensure the mip 6 writes were flushed :(
Workgroup shared memory version only at the moment, as the subgroup operation is blocked by our upgrade to wgpu 0.20 #13186
Don't enforce a power-of-2 depth pyramid texture size, simply scaling by 0.5 is fine

Which parts do you want me to review? Presumably downsample_depth.wgsl? Anything else?

The downsample shader, yeah. I can't post a link ATM, but you can find the full PR diff by changing the GitHub diff to compare against my meshlet-previous-frame-depth-pyramid branch.

Downscale is broken, will need to debug. Might be the barrier issue.

I believe that there might be an improvement that can be made here:
fn reduce_load_mip_0(tex: vec2u) -> f32 {
    let uv = (vec2f(tex) + 0.5) / vec2f(textureDimensions(mip_0));
    return reduce_4(textureGather(mip_0, samplr, uv));
}

From what I understand from the spec, textureGather already computes the four component minimum and stores it in the w channel. So there is no need to reduce, just do the following:
fn reduce_load_mip_0(tex: vec2u) -> f32 {
    let uv = (vec2f(tex) + 0.5) / vec2f(textureDimensions(mip_0));
    return textureGather(mip_0, samplr, uv).w;
}

It is very possible that the compiler spots this optimization already.
Frankly I'm not sure how textureGather works exactly, in Vulkan you needed a VK_SAMPLER_REDUCTION_MODE_MIN sampler and corresponding extension to do this.

textureGather does not return the minimum of the 4 values. The w component is the (u_min, v_min) value of the sample footprint. I.e. given 4 texels (the sample footprint) arranged in a 2x2 quad, the w component is the value at location (u_min, v_min).
Yes, ideally I would be able to use VK_SAMPLER_REDUCTION_MODE_MIN, but unfortunately wgpu does not support it.


fix: Rename bundle to kong-gateway-operator

What this PR does / why we need it:
Update operator name to match what's going to be shipped to the Red Hat catalog and operator hub.
Which issue this PR fixes
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect significant changes

Do not merge until Patryk take a closer look. He already walked this path and probably have some meaningful input.


forward_scale_rot ?

if 'scale_rot' in quantized_params:
                kmeans_scrot_q.forward_scale_rot(gaussians, assign=assign)

def forward_scale_rot(self, gaussian, assign=False):
    """Combine both scaling and rotation for a single k-Means"""
    if self.vec_dim == 0:
        self.vec_dim = gaussian._rotation.shape[1] + gaussian._scaling.shape[1]
    feat_scaled = torch.cat([self.rescale(gaussian._scaling), self.rescale(gaussian._rotation)], 1)
    feat = torch.cat([gaussian._scaling, gaussian._rotation], 1)
    if assign:
        self.cluster_assign(feat, feat_scaled)
    else:
        self.update_centers(feat)
    sampled_centers = torch.gather(self.centers, 0, self.nn_index.unsqueeze(-1).repeat(1, self.vec_dim))
    gaussian._scaling_q = gaussian._scaling - gaussian._scaling.detach() + sampled_centers[:, :3]
    gaussian._rotation_q = gaussian._rotation - gaussian._rotation.detach() + sampled_centers[:, 3:]

This configuration exists in the code. What is the effect?
I think it may difficult to quant??

Hi. In this configuration, we have a single codebook (i.e. shared centers in KNN) for both scale and rotation parameters. We find that this setting does not work as well since the scales and ranges of the two parameters are quite different.


Instantiating record entries with a generic key is not possible when this key extends string. It is when the key extends number.

Bug Report
🔎 Search Terms
record key generic  2322 string
homomorphic mapped string number
🕗 Version & Regression Information
This changed between versions 3.3.1 and 3.5.1
⏯ Playground Link
https://www.typescriptlang.org/play?ts=3.5.1#code/MYewdgzgLgBFCm0DCAneBDBA5ArgWwCN4UYBeAHgBUZ4APBMAEwhjHyJQBoA1APgAoA1vACeALkqcAbugA2OeGO4BKMQCgYmmAAV0KKAEs55AErxQKRlR69epXgG8NWl6Eix4YKChFkYDgG1hEQBdMRl5eABfZxdNNCgcFDAaLx81GLU3aDhEKFQMBABlbwMwAHMyKhp6T2YYaBQy8pshUQlpOQUlVVidPUNjMwsrST47Rz7XcBzPb19SfyDRMIiFGLitBKSUufSYoA
💻 Code
const testCreateNumber =<T extends number,V>(key:T,value:V):
    Partial<Record<T,V>>=>{
        const entry = {[key]:value}
        return entry
}

const testCreateString =<T extends string,V>(key:T,value:V):
    Partial<Record<T,V>>=>{
        const entry = {[key]:value}
        return entry
}

🙁 Actual behavior

{[key]:value} is inferred to its primitive type , ex :{ [x: number]: V; } (Sounds similar toBugs that are not bugs , however here i am not using a mapped type ? )
Starting between 3.3.3 and 3.5.1, it is possible to assign a Partial<Record<T extends number,V>> from a Record<number,V>, while it is not possible to do the same thing for strings.

🙂 Expected behavior

The behaviour should be the same for number and string ( it was the case in version 3.3.3 but not in 3.5.1)
It should be easy to create an entry of a record without having to do as Partial<Record<T,V>>

This is an intended divergence. A value with a numeric index signature is interpreted to be implicitly bounded (e.g. usually by a .length property), but a string index signature is not.

Can you confirm that

{[key]:value} is inferred to its primitive type , ex :{ [x: number]: V; }
is an intended behavior also M
Thank you


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4245

Questions ?
Please refer to the Backport tool documentation


vimcomplete does not allow tab completion

Hi, I am using latest Gvim with patch 1677. Plugin vimcomplete is installed using K-takata minipac.
For completion I prefer to use Tab instead C-n.
If I add g:vimcomplete_tab_enable = 1 to my vimrc Gvim/vim throws following error:
Error detected while processing C:\Users\bozid\vimfiles\pack\minpac\start
\vimcomplete\plugin\plugins.vim[18]..function completor#Enable[17]..util
#TabEnable:
line    4:
E31: No such mapping
E31: No such mapping
Am I doing something wrong?
Best,
boput

I fixed the issue.  Upgrade to new version and try again.
https://github.com/girishji/vimcomplete/commit/2950eee33379585ee1f05ab0cfb9b8a538ce32f7


Implement Experiment finalization after it status changed to Finished

Finalization == calling "finalize" of the deployer connector

Duplication of #46


Error 404 - ws://npmsearch.com/skateboard

Connection to resource ws://npmsearch.com/skateboard ends with http status 404

looks like you have some firewall blocking websockets - this is a skateboard issue tmpvar/skateboard#1


Rixs Jupyter notebook example

@newville here a summary of what done in this pull request:

examples/Jupyter: added a notebook showing a simple reading and visualization of RIXS data
larch.io.rixs_esrf_id26 to read RIXS data from ESRF/ID26 beamline (old Spec format)
larch.plot.plot_rixsdata to visualize RIXS planes and cuts in pure Matplotlib
improved larch.io.rixsdata.RixsData for taking line cuts and crop the RIXS plane

I have introduced the module larch.plot with the idea of migrating there those standard plots for Larch (currently based on the Wx GUI at larch.wxlib.xafsplots), using pure Matplotlib or Plotly. This will permit having plots in Larch scripts or Jupyter notebooks.

@maurov Sorry for the delay on this.  Overall, I'm in favor.  I like the idea of a "plot" folder that allows separate backends.  And, migrating/copying code to have "standard XAFS/XES/RIXS plots" with several backends (plain matplotlib especially for Jupyter-on-the-desktop, plotly, and wxmplot for larch wxPython apps) is a great goal.  I would say that I'm eager to help get that started....
My thought is just merge this as is.  Is that OK with you or are you still working on this?
I have a couple of XAS_Viewer fixes in the works before 0.9.66 but hope that will be in a week or two.

@maurov Sorry for the delay on this. Overall, I'm in favor. I like the idea of a "plot" folder that allows separate backends. And, migrating/copying code to have "standard XAFS/XES/RIXS plots" with several backends (plain matplotlib especially for Jupyter-on-the-desktop, plotly, and wxmplot for larch wxPython apps) is a great goal. I would say that I'm eager to help get that started....

@newville great to see that you are in favor of larch.plot with multiple backends. In my opinion the next step could be to disentangle the plotting functions in larch.wxlib.xafsplots from the Wx plotting backend in order that we could have common plotting functions in larc.plot accepting a backend keyword argument. Unfortunately, I do not have a clear idea who to proceed doing this. If you have time for it, it would be great!

My thought is just merge this as is. Is that OK with you or are you still working on this?

Yes, you can simply merge as is. The Jupyter example is fully working and I do not plan to add more features soon.

I have a couple of XAS_Viewer fixes in the works before 0.9.66 but hope that will be in a week or two.

Great! If you think there are some issues to address before next release, please, let me know. I could eventually help.
From my side, I worked on #358 and it is promising, but I think it is better to wait for 0.9.67 or later.

@maurov OK, great, I'll merge this.  Thanks!
For larch.plot, I think that making some of the plot labels and so on generic would be a good start, and making "matplotlib for Jupyter" equivalents of many of the plot types would not be too difficult.  I'm less certain about plotly, but well, maybe....
For #358, I was sort of hoping conda would just fix this themselves, and it has seemed less incredibly slow to me.


[Relay][Frontend][TFlite] Add parses support for SLICE

TFlite 1.13: convertor gives nonsense output when size[i]==-1
TF parser: SLICE needs fixing for size[i]==-1 -> the formula for calculating the end indices needs to be changed to
if size[i] == -1:
end[i] = data_shape[i] - begin[i] + 1

@kevinthesun @FrozenGene can you please review this patch


Add GitHub action to automatically tag a new version

Related to https://github.com/stripe/vscode-stripe/issues/123.
After changing version in the package.json, this action automatically detects the new version and creates a tag for it with a changelog.
Inspired by https://github.com/auchenberg/vscode-browser-preview/blob/master/.github/workflows/auto_tags.yml.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing; superseded by #130


Error in windows detected by the functional test suite

The test suite fails in my windows 10 msys2 console with those errors:
Failures:

  test/functional\\FunctionalCodeActionsSpec.hs:110:16:
  1) FunctionalCodeActions, code actions, rename suggestions, works
       expected: "main = putStrLn \"hello\""
        but got: "main =  \"hello\""

  To rerun use: --match "/FunctionalCodeActions/code actions/rename suggestions/works/"

  test/functional\\FunctionalCodeActionsSpec.hs:127:18:
  2) FunctionalCodeActions, code actions, rename suggestions, doesn't give both documentChanges and changes
       expected: "foo = putStrLn \"world\""
        but got: "foo =  \"world\""

  To rerun use: --match "/FunctionalCodeActions/code actions/rename suggestions/doesn't give both documentChanges and changes/"

  test/functional\\FunctionalCodeActionsSpec.hs:729:11:
  3) FunctionalCodeActions, code actions, import suggestions, formats with brittany, Execute HsImport with formatter brittany, multiple import-list formats
       uncaught exception: ErrorCall
       No action found to be executed!
        Actual actions titles: ["Replace with "]
        Expected actions titles: ["Import module System.IO (hPutStrLn)","Import module System.IO (stdout)","Import module Control.Monad (when)","Import module Data.Maybe (fromMaybe)"]
       CallStack (from HasCallStack):
         error, called at test/functional\\FunctionalCodeActionsSpec.hs:729:11 in main:FunctionalCodeActionsSpec

  To rerun use: --match "/FunctionalCodeActions/code actions/import suggestions/formats with brittany/Execute HsImport with formatter brittany/multiple import-list formats/"

  test/functional\\FunctionalCodeActionsSpec.hs:729:11:
  4) FunctionalCodeActions, code actions, import suggestions, formats with brittany, Execute HsImport with formatter brittany, respects format config, multiple import-list
       uncaught exception: ErrorCall
       No action found to be executed!
        Actual actions titles: ["Replace with "]
        Expected actions titles: ["Import module System.IO (hPutStrLn)","Import module System.IO (stdout)","Import module Control.Monad (when)","Import module Data.Maybe (fromMaybe)"]
       CallStack (from HasCallStack):
         error, called at test/functional\\FunctionalCodeActionsSpec.hs:729:11 in main:FunctionalCodeActionsSpec

  To rerun use: --match "/FunctionalCodeActions/code actions/import suggestions/formats with brittany/Execute HsImport with formatter brittany/respects format config, multiple import-list/"

  test/functional\\FunctionalCodeActionsSpec.hs:729:11:
  5) FunctionalCodeActions, code actions, import suggestions, formats with brittany, Execute HsImport with formatter brittany, complex import-list
       uncaught exception: ErrorCall
       No action found to be executed!
        Actual actions titles: []
        Expected actions titles: ["Import module System.IO (hPutStrLn)","Import module Control.Monad (when)","Import module Data.Maybe (fromMaybe)","Import module Data.Function (($))","Import module Data.Maybe (Maybe (Just))","Import module Prelude (Bool (..))","Import module System.IO (stderr)"]
       CallStack (from HasCallStack):
         error, called at test/functional\\FunctionalCodeActionsSpec.hs:729:11 in main:FunctionalCodeActionsSpec

  To rerun use: --match "/FunctionalCodeActions/code actions/import suggestions/formats with brittany/Execute HsImport with formatter brittany/complex import-list/"

  test/functional\\FunctionalCodeActionsSpec.hs:729:11:
  6) FunctionalCodeActions, code actions, import suggestions, formats with brittany, Execute HsImport with formatter brittany, complex import-list respects format config
       uncaught exception: ErrorCall
       No action found to be executed!
        Actual actions titles: []
        Expected actions titles: ["Import module System.IO (hPutStrLn)","Import module Control.Monad (when)","Import module Data.Maybe (fromMaybe)","Import module Data.Function (($))","Import module Data.Maybe (Maybe (Just))","Import module Prelude (Bool (..))","Import module System.IO (stderr)"]
       CallStack (from HasCallStack):
         error, called at test/functional\\FunctionalCodeActionsSpec.hs:729:11 in main:FunctionalCodeActionsSpec

  To rerun use: --match "/FunctionalCodeActions/code actions/import suggestions/formats with brittany/Execute HsImport with formatter brittany/complex import-list respects format config/"

  test/functional\\FunctionalCodeActionsSpec.hs:729:11:
  7) FunctionalCodeActions, code actions, import suggestions, formats with floskell, Execute HsImport with formatter floskell, multiple import-list formats
       uncaught exception: ErrorCall
       No action found to be executed!
        Actual actions titles: ["Replace with "]
        Expected actions titles: ["Import module System.IO (hPutStrLn)","Import module System.IO (stdout)","Import module Control.Monad (when)","Import module Data.Maybe (fromMaybe)"]
       CallStack (from HasCallStack):
         error, called at test/functional\\FunctionalCodeActionsSpec.hs:729:11 in main:FunctionalCodeActionsSpec

  To rerun use: --match "/FunctionalCodeActions/code actions/import suggestions/formats with floskell/Execute HsImport with formatter floskell/multiple import-list formats/"

  test/functional\\FunctionalCodeActionsSpec.hs:729:11:
  8) FunctionalCodeActions, code actions, import suggestions, formats with floskell, Execute HsImport with formatter floskell, respects format config, multiple import-list
       uncaught exception: ErrorCall
       No action found to be executed!
        Actual actions titles: ["Replace with "]
        Expected actions titles: ["Import module System.IO (hPutStrLn)","Import module System.IO (stdout)","Import module Control.Monad (when)","Import module Data.Maybe (fromMaybe)"]
       CallStack (from HasCallStack):
         error, called at test/functional\\FunctionalCodeActionsSpec.hs:729:11 in main:FunctionalCodeActionsSpec

  To rerun use: --match "/FunctionalCodeActions/code actions/import suggestions/formats with floskell/Execute HsImport with formatter floskell/respects format config, multiple import-list/"

  test/functional\\FunctionalCodeActionsSpec.hs:729:11:
  9) FunctionalCodeActions, code actions, import suggestions, formats with floskell, Execute HsImport with formatter floskell, complex import-list
       uncaught exception: ErrorCall
       No action found to be executed!
        Actual actions titles: []
        Expected actions titles: ["Import module System.IO (hPutStrLn)","Import module Control.Monad (when)","Import module Data.Maybe (fromMaybe)","Import module Data.Function (($))","Import module Data.Maybe (Maybe (Just))","Import module Prelude (Bool (..))","Import module System.IO (stderr)"]
       CallStack (from HasCallStack):
         error, called at test/functional\\FunctionalCodeActionsSpec.hs:729:11 in main:FunctionalCodeActionsSpec

  To rerun use: --match "/FunctionalCodeActions/code actions/import suggestions/formats with floskell/Execute HsImport with formatter floskell/complex import-list/"

  test/functional\\FunctionalCodeActionsSpec.hs:729:11:
  10) FunctionalCodeActions, code actions, import suggestions, formats with floskell, Execute HsImport with formatter floskell, complex import-list respects format config
       uncaught exception: ErrorCall
       No action found to be executed!
        Actual actions titles: []
        Expected actions titles: ["Import module System.IO (hPutStrLn)","Import module Control.Monad (when)","Import module Data.Maybe (fromMaybe)","Import module Data.Function (($))","Import module Data.Maybe (Maybe (Just))","Import module Prelude (Bool (..))","Import module System.IO (stderr)"]
       CallStack (from HasCallStack):
         error, called at test/functional\\FunctionalCodeActionsSpec.hs:729:11 in main:FunctionalCodeActionsSpec

  To rerun use: --match "/FunctionalCodeActions/code actions/import suggestions/formats with floskell/Execute HsImport with formatter floskell/complex import-list respects format config/"

  test/functional\\FunctionalCodeActionsSpec.hs:226:20:
  11) FunctionalCodeActions, code actions, add package suggestions, adds to .cabal files
       predicate failed on: "Could not load module `Data.Text'\nIt is a member of the hidden package `text-<IP_ADDRESS>'.\nPerhaps you need to add `text' to the build-depends in your .cabal file.\nUse -v to see a list of the files searched for."

  To rerun use: --match "/FunctionalCodeActions/code actions/add package suggestions/adds to .cabal files/"

  test/functional\\FunctionalCodeActionsSpec.hs:253:23:
  12) FunctionalCodeActions, code actions, add package suggestions, adds to hpack package.yaml files
       predicate failed on: "Could not find module `Codec.Compression.GZip'\nUse -v to see a list of the files searched for."

  To rerun use: --match "/FunctionalCodeActions/code actions/add package suggestions/adds to hpack package.yaml files/"

  test/functional\\FunctionalCodeActionsSpec.hs:282:18:
  13) FunctionalCodeActions, code actions, redundant import code actions, remove solitary redundant imports
       predicate failed on: "The import of `Data.List' is redundant\n  except perhaps to import instances from `Data.List'\nTo import instances alone, use: import Data.List()"

  To rerun use: --match "/FunctionalCodeActions/code actions/redundant import code actions/remove solitary redundant imports/"

  test/functional\\FunctionalCodeActionsSpec.hs:302:5:
  14) FunctionalCodeActions, code actions, redundant import code actions, doesn't touch other imports
       uncaught exception: SessionException
       Language server unexpectedly terminated

  To rerun use: --match "/FunctionalCodeActions/code actions/redundant import code actions/doesn't touch other imports/"

  test/functional\\FunctionalCodeActionsSpec.hs:332:26:
  15) FunctionalCodeActions, code actions, typed hole code actions, works
       Actual list is not a permutation of expected list!
         expected list contains:   ["Substitute hole (Int) with x ([Int])", "Substitute hole (Int) with foo ([Int] -> Int Valid hole fits include)", "Substitute hole (Int) with maxBound (forall a. Bounded a => a with maxBound @Int)", "Substitute hole (Int) with minBound (forall a.  Bounded a => a with maxBound @Int)", "Substitute hole (Int) with minBound (forall a. Bounded a => a with minBound @Int)"]
         the missing elements are: ["Substitute hole (Int) with foo ([Int] -> Int Valid hole fits include)"]
         the extra elements are:   ["Substitute hole (Int) with foo ([Int] -> Int)"]

  To rerun use: --match "/FunctionalCodeActions/code actions/typed hole code actions/works/"

  test/functional\\FunctionalCodeActionsSpec.hs:480:18:
  16) FunctionalCodeActions, code actions, unused term code actions, Prefixes with '_'
       ["Prefix  with _","Lift imUnused one level","Lift imUnused to top level","Demote imUnused one level","Delete definition of imUnused","Duplicate definition of imUnused"] does not contain ["Prefix imUnused with _"]

  To rerun use: --match "/FunctionalCodeActions/code actions/unused term code actions/Prefixes with '_'/"

I opened this to track them and hopefully help to fix them!

After merging #1399 the remaining failed tes would be:
 test/functional\\FunctionalCodeActionsSpec.hs:226:20:
  1) FunctionalCodeActions, code actions, add package suggestions, adds to .cabal files
       predicate failed on: "Could not load module `Data.Text'\nIt is a member of the hidden package `text-<IP_ADDRESS>'.\nPerhaps you need to add `text' to the build-depends in your .cabal file.\nUse -v to see a list of the files searched for."

  To rerun use: --match "/FunctionalCodeActions/code actions/add package suggestions/adds to .cabal files/"

  test/functional\\FunctionalCodeActionsSpec.hs:253:23:
  2) FunctionalCodeActions, code actions, add package suggestions, adds to hpack package.yaml files
       predicate failed on: "Could not find module `Codec.Compression.GZip'\nUse -v to see a list of the files searched for."

  To rerun use: --match "/FunctionalCodeActions/code actions/add package suggestions/adds to hpack package.yaml files/"

  test/functional\\FunctionalCodeActionsSpec.hs:282:18:
  3) FunctionalCodeActions, code actions, redundant import code actions, remove solitary redundant imports
       predicate failed on: "The import of `Data.List' is redundant\n  except perhaps to import instances from `Data.List'\nTo import instances alone, use: import Data.List()"

  To rerun use: --match "/FunctionalCodeActions/code actions/redundant import code actions/remove solitary redundant imports/"

  test/functional\FunctionalLiquidSpec.hs:67:5:

all of these look suspicious to have the same problem as  #1399

@fendor yeah, this time in the tests themselves, fixing...


invisible text -  same color as background command palette search

Picture says it all (this is for v2 -  electric boogaloo):

I'm having the same issue.


matrix.org home page has broken link to Try Matrix page

under the 'Show me  the code' section, it has a link that says 'https://matrix.org/blog/try-matrix-now' and links to 'https://matrix.org/try-matrix-now'.  Even though 'https://matrix.org/blog/try-matrix-now' redirects to the correct page, the href=https://matrix.org/try-matrix-now is broken.

fixed, thanks.


Port completness react query

Also action column is sortable and sometimes looks useless

Rebased on master, added back test that was removed by error.
Modified to use useSnackMutation (and move it from polio to iaso), added a useSnackQuery. Both of theses function are just like the regulard useMutation and useQuery but handle the snackbar directly for us. which make the code a bit more readable


Unity Crashes

When i play OSVR-Unity-Palace-Demo-master i can see vision on HDK2 for 1-2 secs and Unity crashes. i have windows 10. Render manager examples in c:\Program Files\OSVR\Runtime\bin\ works fine.
Unity Editor [version: Unity 5.4.1p1_b9eb0361f989]
osvrUnityRenderingPlugin.dll caused an Access Violation (0xc0000005)
in module osvrUnityRenderingPlugin.dll at 0033:745566c1.
Error occurred at 2016-09-24_233316.
C:\Program Files\Unity\Editor\Unity.exe, run by atmuc.
56% memory in use.
16286 MB physical memory [7030 MB free].
25502 MB paging file [12902 MB free].
134217728 MB user address space [134214628 MB free].
Read from location 000000c8 caused an access violation.
Context:
RDI:    0x2234eac0  RSI: 0x007f67e0  RAX:   0x00000000
RBX:    0x217e2f40  RCX: 0x005fb660  RDX:   0x00000098
RIP:    0x745566c1  RBP: 0x005fb740  SegCs: 0x00000033
EFlags: 0x00010202  RSP: 0x005fb5d8  SegSs: 0x0000002b
R8:    0x00000038  R9: 0x031cbfb0  R10:   0x423da898
R11:    0x745512d0  R12: 0x005fbcd0  R13:   0x0aa467f8
R14:    0x005fbda0  R15: 0x00000000

i think tracker cause this crash. when i unplug tracker it works fine.

Hi @atmuc, can you try the updated build of Palace to see if this is still an issue? https://github.com/OSVR/OSVR-Unity-Palace-Demo/releases/tag/v<IP_ADDRESS>
I could reproduce this in the older version, but not the latest build. Thanks.

Hey Duff,
I am seeing the same issue as above in our project and if I run the Palace Demo. Any solutions yet?
Cheers,
Colton

@colton-vitruviusvr try these steps: https://github.com/OSVR/OSVR-Unity/blob/master/GettingStarted.md#troubleshooting-rendermanager-in-unity

@DuFF14 I previously configured most of these options yesterday as I followed your post here https://github.com/OSVR/OSVR-Unity-Rendering/issues/29 which got me up and running originally. I have retried all of the steps in the link you suggested and now I cannot start the server.. It crashes after "Added device: com_osvr_Multiserver/OSVRHackerDevKitPrediction0"

Looks like running the add_sdk_to_registry.cmd that I downloaded in the updated SDK version from yesterday did the trick. I can now run direct mode from Unity as well as from steam.

Interesting... thanks for the updates. I'm wondering if add_sdk_to_registry.cmd is what fixed it, or if that was a coincidence? Did you also power cycle? Which version of OSVR SDK/Runtime are you working with, and what bitness?

Here are the exact steps I took:

Server didn't work, installed latest runtime and run server through OSVR central
RenderManager exe didn't work, run add_sdk cmd in the SDK directory
RenderManager exe worked but didn't show anything, power cycle HMD
Everything now working in direct mode

Running 64-bit everything, not sure about the versions, 1341?

FYI looks like I have to repeat these steps everytime I restart my comp

Hi,
I have the same issue. Unity crashes after I start my project. Currently I am using Unity 5.5.0b9. My crash log looks like this:
Unity Editor [version: Unity 5.5.0b9_d73e98081237]
osvrUnityRenderingPlugin.dll caused an Access Violation (0xc0000005)
in module osvrUnityRenderingPlugin.dll at 0033:a1e466c1.
Error occurred at 2016-10-26_160004.
C:\Program Files\Unity 5.5.0b9\Editor\Unity.exe, run by Marcin.
21% memory in use.
24526 MB physical memory [19226 MB free].
28110 MB paging file [20890 MB free].
134217728 MB user address space [134213773 MB free].
Read from location 000000c8 caused an access violation.

I am runing on Windows 10. My GPU: GeForce 980m, Nvidia driver v. 365.19.
Cheers,
Marcin

Hi @MarcinRNowak,
Do the steps at https://github.com/OSVR/OSVR-Unity/blob/master/GettingStarted.md#troubleshooting-rendermanager-in-unity not fix the issue for you?
I haven't done any testing with Unity 5.5b, but I would still expect these steps to work.

@MarcinRNowak ah, just noticed the 980m. I don't know if it will still work in direct mode if you update the drivers. Direct mode on the mobile GPUs might require a driver version pre-367.

Correct, reliable direct mode (as of this writing, for the hdk 2 as well as 1.x) requires a pre 367 driver on any mobile NVIDIA GPU, due to a policy implemented by NVIDIA in later drivers.

Hi,
thank you for suggestions. I have tried mentioned steps, but it didn't help. My game works in extended mode with no issues, but I can see quite a noticable lag.
I have also tried it on my friends computer with GeForce 970 and my own gaming rig with GF 1080, but I am keep getting the same errors/crash in direct mode. On all configuration I have been using newst runtime, drivers and plugin.

@colton-vitruviusvr I just had the exact same issue/resolution. Very weird that add_sdk_to_registry.cmd is making direct mode work.

RenderManager exe didn't work, run add_sdk cmd in the SDK directory
RenderManager exe worked but didn't show anything, power cycle HMD
Everything now working in direct mode
@MarcinRNowak have you tried the add_sdk_to_registry.cmd step?

Hi,
I have tried running add_sdk_to_registry.cmd, but it doesn't work for me. I have also tried downloading newest build of unity plugin (OSVR-Unity-v0.6.15-4-gd36f7fb-with-core-v0.6-1343-gcb295fe-build573.7z), but also I have the same result.
@DuFF14 I can't find RenderManagerPresentExample3D.exe. Where can I find it?

@MarcinRNowak I haven't used the OSVR since the last time I posted about a month ago but I started it up  today and was seeing the same problem as you. Here are the steps I took to get the HDK to work again :

Updated nvidia drivers to latest release
Restarted comp
Ran OSVR Control as admin
Enabled direct mode (updating the nvidia drivers seemed to change it to be extended mode)
Ran server
Tried RenderManagerD3DExample which yielded same error
Ran the add_sdk_to_registry
Ran RenderManagerD3D again, this time it worked but no image
Power cycled HMD - Blue screen comp
Restart comp, ran OSVR control as admin, ran add_sdk_to_registry as admin and ran RenderManagerD3D as admin, everything worked (I noticed if I do not run RenderMangerD3D as admin it still fails)

Cheers,
Colton

@MarcinRNowak The RenderManager examples are in: C:\Program Files\OSVR\Runtime\bin
which can be installed from:
http://access.osvr.com/binary/osvr-sdk-installer
@colton-vitruviusvr I also see this issue. There are multiple seemingly random options for the "add_sdk_to_registry" step. You could run other programs or scripts instead and it will have the same effect. It works for me if I just run RenderManagerD3DExample three times, without power cycling or running add_sdk.

going to close this issue. The original issue:
"osvrUnityRenderingPlugin.dll caused an Access Violation (0xc0000005)"
is believed to be fixed. Other issues were firmware related.


python311Packages.base2048: init at 0.1.3, python311Packages.frelatage: init at 0.1.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 273301 run on x86_64-linux 1

4 packages failed to build:

python310Packages.base2048
python310Packages.base2048.dist
python311Packages.base2048
python311Packages.base2048.dist

4 packages built:

python310Packages.frelatage
python310Packages.frelatage.dist
python311Packages.frelatage
python311Packages.frelatage.dist

Result of nixpkgs-review pr 273301 run on x86_64-linux 1

8 packages built:

python310Packages.base2048
python310Packages.base2048.dist
python310Packages.frelatage
python310Packages.frelatage.dist
python311Packages.base2048
python311Packages.base2048.dist
python311Packages.frelatage
python311Packages.frelatage.dist


regression: invalid values due to fields now missing in schema

Describe the bug: (a clear and concise description of what the bug is)
In the console, when submitting a service form after choosing to use an existing TLS secret we now get a 422: invalid values detected error, due to the following fields missing now in values-schema.yaml. These were there before and should be put back:
definitions:
  service:
    certArn
    certName
    hasCert

Please use the git log to check when those values existed and in what commit those got removed.
For up to date details please use the entries from the otomi-api repo's schema!
Expected behavior: (a clear and concise description of what you expected to happen)
Values created by api to be valid.

This is a bug reported by our customer, so please give it prio @dominikatrela

I think you are mistakenly assuming, I can't find any trace of this in our git history.
Let's make a task to put it in the schema, but I expect you take some responsibility for putting go templating variables in the schema.

I understand that we should cross check otomi-core/values-schema.yaml against otomi-api/openapi schema. The difference shall be a guide about what is missing in values-schema.yaml

I think you are mistakenly assuming, I can't find any trace of this in our git history.
Let's make a task to put it in the schema, but I expect you take some responsibility for putting go templating variables in the schema.
Proof:
git grep hasCert $(git rev-list --all) | grep values-schema.yaml
git grep certName $(git rev-list --all) | grep values-schema.yaml
git grep hasCert $(git rev-list --all) | grep values-schema.yaml

indeed it seems these values were only living in code, and this was never caught...

@Dunky13 I believe you were ready with coding and testing? Is this ready?


Remove profiles directory

Change the way we do template config files for the api

Completed as part of etl branch - Fixed in c43af93a31825ba09ac26092559a440cc8d8a208


[GSSoC] Add Sorting  in Python

[GSSoC 2021] I would like to add sorting programs in Python like Linear sort, Bubble sort etc. Please assign this to me.
@tarun26091999  @shreyanspoddar @nakul-19 @OjusWiZard  @raksha009 @rudrakshi99  please mentors assign this to me.

you can add one algorithm in one issue.


Clone is not implemented for sea_orm::DatabaseConnection in rocket_example

I tried the rocket_example and I'm getting an error in pool.rs.
https://github.com/SeaQL/sea-orm/blob/82bad4a376efb875ac32ab601ac2cd9cce191e3f/examples/rocket_example/src/pool.rs#L12
the trait bound `sea_orm::DatabaseConnection: std::clone::Clone` is not satisfied

the trait `std::clone::Clone` is not implemented for `sea_orm::DatabaseConnection`rustc(E0277)
pool.rs(12, 5): the trait `std::clone::Clone` is not implemented for `sea_orm::DatabaseConnection`

Removing #[derive(Clone)] from SeaOrmPool fixes the error, but is it intended to have the Clone trait?
Features I was using:
sea-orm = { version = "0.5.0", features = ["sqlx-postgres", "macros", "runtime-tokio-rustls"]}
sea-orm-rocket = { git = "https://github.com/SeaQL/sea-orm" }

Hi @Rudi3, I believe you can safely remove the derive Clone here.
https://github.com/SeaQL/sea-orm/blob/82bad4a376efb875ac32ab601ac2cd9cce191e3f/examples/rocket_example/src/pool.rs#L10-L13

You missed the default-features = false
sea-orm = { version = "0.5.0", default-features = false, features = ["sqlx-postgres", "macros", "runtime-tokio-rustls"]}


Skip interceptor for methods that are not registered in the server

Thanks for fixing this @anuraaga ! It’s much appreciated!
One more small thing, could you bump the version please? It’s needed for a new release.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (af11a9b) 94.68% compared to head (c98b0c7) 94.70%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   94.68%   94.70%   +0.02%
==========================================
  Files           7        7
  Lines         376      378       +2
  Branches       55       56       +1
==========================================
+ Hits          356      358       +2
  Misses         15       15
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix duplicating cues in TextEngine

Resolves: https://github.com/google/shaka-player/issues/2497

I'm not convinced this is correct.
It is intentional that append windows apply to text streams just as they do to other types.  This represents the period boundary in DASH.
Can you explain why it is more correct to restrict cues to the idealized segment times?  In many cases in HLS, those segment times are an estimate only, so I'm especially suspicious of this change.

I'm not pretty sure that the change will be the correct. But in my case, it resolves the issue related to duplicates cues, you can see the info in https://github.com/google/shaka-player/issues/2497

#2497 is caused by duplicate cues coming into the buffer to be appended. I am looking into the root cause of that.

When a VTT cue spans a segment boundary, the cue is duplicated into two segments, and that results in the cue being displayed twice. So the best way to fix this might be to detect and skip the duplicate cues in TextDisplayer, instead of filtering the cues by start/end time.
We'll have a fix for #2497 soon.

@michellezhuogg , Thanks for the update!


[Feature]: Sensible to perform integration/unit tests using PowerShell's Pester (with psake)?

Module Name
N/A
Description
Just a question here -- I was wondering if the testing code documentation restricts testing of terraform module's to just the terratest golang framework.
I have been using a combination of the following PowerShell (Core) modules lately with my Terraform projects and find it to be very fluent:

Az: Azure Suite of PowerShell Modules
Pester: Tests
psake: Task Runner
Plaster: Module templating and best practices
PSDepend: Dependency Management and Versioning
Crescendo: (Optional) Could be used to create custom wrapper utilities for classic terraform-cli commands/scenarios (for example converting terraform plan to JSON or setting up the remote-backend / service principal, etc.)
CredentialManager: Manage credentials and authentication
platyPS: Generate documentation similar to terraform-docs does (although I still prefer terraform-docs here).

Similar to how PSRule (see Validate infrastructure as code (IaC) and objects using PowerShell rules) works nicely with Bicep or ARM Templates; I feel like these PowerShell tools really integrate nicely with the Terraform infrastructure as code ecosystem, specifically for Azure infrastructural deployments.
It also is a more friendly interface to use for a typical Azure developer that is more likely used to PowerShell syntax and development over Go, especially if having to write complex tests (notice the similarities between Pester/psake/DSC syntax and Terraform configuration syntax?).
Just wanted to see if anyone had any food for thoughts on this subject - any criticism or feedback would be much appreciated.
Thanks!

Jimmy

Example usage
No response
Other information
No response

Hi @jimbrig
Go is idiomatic of Terraform, historically. Due to this, I have created a fluent testing module in go, it allows code that is much more easy to read. It is built atop terratest.
See here: https://github.com/Azure/terratest-terraform-fluent
That's not to say we can't investigate other testing frameworks, but this might be worth considering.

@matt-FFFFFF - Awesome, thanks for that - will check it out. I'm starting to try and learn Go regardless due to the fact it teaches design patterns and best practices relevant across any language/framework.

Thanks @jimbrig for the suggestions! I'll take a look at the tools that you recommended.

CredentialManager: Manage credentials and authentication

We're using MSI as the authentication method, we're also considering OIDC/).


Update package.json

Upgrade peerDependencies pg to 5.1.0 version

Duplicate with https://github.com/theoephraim/node-pg-migrate/pull/48