Modified Magic Number function to library function

Related Issue

Info about Issue or bug

fix #[issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.

Screenshots

Original
Updated

original screenshot
updated screenshot

@jasminekaur-prog please resolve this merge conflicts by updating your branch
have a look on this video  https://drive.google.com/file/d/1cRSx6LZ9EoC65xkfnoUpNBLtEVGYE8PT/view?usp=sharing

@jasminekaur-prog just for information
must mention the issue no for which you make PR like  #5290 in this case


IPRO+LFF: no etag

In the same circumstances as https://github.com/pagespeed/mod_pagespeed/issues/1381 (ipro resource with load from file that either isn't optimized yet or that we can't optimize further) we don't add an etag.  We should hash the file contents and generate one.

(And when we generate it we should also accept it back and return 304s appropriately)

We should also remove the Last-Modified header, since we don't understand If-Modified-Since requests


[18.03] quassel: 0.12.4 fix RCE & DOS

Motivation for this change
It was found that Quassel could be remotely crashed and had an
unauthenticated RCE vulnerability. The public annoucement can be found
on the oss-sec archive [1]. The added patches are supposed fix both issues.
[1] http://seclists.org/oss-sec/2018/q2/77
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: quassel
Partial log (click to expand)
Cannot nix-instantiate `quassel' because:
error: while evaluating 'callPackageWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:17317:13:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/networking/irc/quassel/default.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
assertion failed at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/networking/irc/quassel/default.nix:27:1

Success on x86_64-linux (full log)
Attempted: quassel
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hjgs11kk0xssqwavqgs8isskyysw3ldb-quassel-kf5-0.12.4
shrinking /nix/store/hjgs11kk0xssqwavqgs8isskyysw3ldb-quassel-kf5-0.12.4/bin/.quassel-wrapped
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hjgs11kk0xssqwavqgs8isskyysw3ldb-quassel-kf5-0.12.4/bin
patching script interpreter paths in /nix/store/hjgs11kk0xssqwavqgs8isskyysw3ldb-quassel-kf5-0.12.4
/nix/store/hjgs11kk0xssqwavqgs8isskyysw3ldb-quassel-kf5-0.12.4/share/quassel/scripts/inxi: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/hjgs11kk0xssqwavqgs8isskyysw3ldb-quassel-kf5-0.12.4...
postPatchMkspecs
/nix/store/hjgs11kk0xssqwavqgs8isskyysw3ldb-quassel-kf5-0.12.4

Success on aarch64-linux (full log)
Attempted: quassel
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mw9mc1sl33ryjn9dhlfs7q72fvk1anjx-quassel-kf5-0.12.4
shrinking /nix/store/mw9mc1sl33ryjn9dhlfs7q72fvk1anjx-quassel-kf5-0.12.4/bin/.quassel-wrapped
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mw9mc1sl33ryjn9dhlfs7q72fvk1anjx-quassel-kf5-0.12.4/bin
patching script interpreter paths in /nix/store/mw9mc1sl33ryjn9dhlfs7q72fvk1anjx-quassel-kf5-0.12.4
/nix/store/mw9mc1sl33ryjn9dhlfs7q72fvk1anjx-quassel-kf5-0.12.4/share/quassel/scripts/inxi: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/mw9mc1sl33ryjn9dhlfs7q72fvk1anjx-quassel-kf5-0.12.4...
postPatchMkspecs
/nix/store/mw9mc1sl33ryjn9dhlfs7q72fvk1anjx-quassel-kf5-0.12.4


Coverage isn't reported correctly for Mongoid backed rails project

I've got a rails project that's using Mongoid as the "database" and I'm getting odd coverage results.  Here's a snippet of a good example of the behavior I'm seeing:
Class:
 class Source::TwitterFeed < Source
  field :hash_tags, :type => Array, :default => []
  field :users, :type => Array, :default => []
  attr_accessible :users, :hash_tags

  validate :validate_empty_feed

  def validate_empty_feed
    if (self.users.empty? && self.hash_tags.empty?)
      errors.add(:users, "must have at least one username or hash_tag")
    end
  end

Test
context "twitter feed with empty hash_tags and users validation" do
  setup do
    Source::TwitterFeed.delete_all
    @twitter_feed = Source::TwitterFeed.create(:users => [], :hash_tags => [])
  end

  should "be invalid" do
    assert(@twitter_feed.invalid?, "twitter_feed was not invalid")
  end
end

The test passes.  Yet, only the def line of validate_empty_feed is considered covered.  For reference, this is with cover_me 1.0.0, rails 3.0.7 and a cover_me config (That's really just empty) after a require in the test helper.  I see this behavior all over the coverage report, where I have tests that I'm sure execute lines but are not considered covered.  I looked around at the other issues and googled around but was unable to find anything on cover_me and mongoid.

I have noticed the same problem as well.  For example, for a particular method that I'm sure is being run, but does not show as covered, I'll throw a raise statement somewhere in that method and get errors all over the place when I run my tests.  When I remove it, though, it still shows as not being covered.


Setting yaxis min breaks in radar chart

Description

Steps to Reproduce

Set chart to type 'radar'
Set config.yaxis.min value to 1
Add a series with values from 1 to 5

Expected Behavior
Value of 1 will be found at the center of the radar, at 1.
Actual Behavior
1 is found at 3, while 4 and 5 are outside the radar
Screenshots

Reproduction Link
https://codepen.io/robertandreigit/pen/rNbYePp

It seems to have broken going from version 3.11.2 to 3.11.3.

On 3.11.2 the behaviour is still different than I'd expect. When yaxis min is set to 1, having a value of 0 in the series is displayed in the center, and a value of 1 is somewhere between 1 and 2. Although 5 is displayed where it should be if that helps.


Failed building wheel for annoy In scikit-llm[gpt4all]

Building wheels for collected packages: annoy
Building wheel for annoy (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [19 lines of output]
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-3.10
creating build\lib.win-amd64-3.10\annoy
copying annoy_init_.py -> build\lib.win-amd64-3.10\annoy
copying annoy_init_.pyi -> build\lib.win-amd64-3.10\annoy
copying annoy\py.typed -> build\lib.win-amd64-3.10\annoy
running build_ext
building 'annoy.annoylib' extension
creating build\temp.win-amd64-3.10
creating build\temp.win-amd64-3.10\Release
creating build\temp.win-amd64-3.10\Release\src
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\bin\HostX86\x64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -IC:\Users\sumeruinfra\AppData\Local\Programs\Python\Python310\include -IC:\Users\sumeruinfra\AppData\Local\Programs\Python\Python310\Include -IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\include -IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\ATLMFC\include -IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\VS\include /EHsc /Tpsrc/annoymodule.cc /Fobuild\temp.win-amd64-3.10\Release\src/annoymodule.obj -D_CRT_SECURE_NO_WARNINGS -fpermissive -DANNOYLIB_MULTITHREADED_BUILD
cl : Command line warning D9002 : ignoring unknown option '-fpermissive'
annoymodule.cc
C:\Users\sumeruinfra\AppData\Local\Temp\pip-install-risjy5ab\annoy_0f7489caf9de4e62a7376c32e7609982\src\annoylib.h(19): fatal error C1083: Cannot open include file: 'stdio.h': No such file or directory
error: command 'C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\bin\HostX86\x64\cl.exe' failed with exit code 2
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for annoy
Running setup.py clean for annoy
Failed to build annoy
ERROR: Could not build wheels for annoy, which is required to install pyproject.toml-based projects

Seems like there is an issue with the CPP compiler in your environment. Can you try to pip install annoy directly just in case (I assume you will get the same error). If so, it is better to open an issue with annoy devs as it doesn't seem to be directly related to scikit-llm. https://github.com/spotify/annoy

annoy can not be installed due to gcc version. For me, It's hard and unrobust to change the gcc version for system. Is annoy a necessary and irreplaceable  package for scikit-llm?

@Prayforhanluo at the moment annoy is the only index that can be used by DynamicFewShot estimator. However, we probably could make it an optional dependency and go with something like sklearn KNN by default. We will consider this for the next release.

Seems like there is an issue with the CPP compiler in your environment. Can you try to pip install annoy directly just in case (I assume you will get the same error). If so, it is better to open an issue with annoy devs as it doesn't seem to be directly related to scikit-llm. https://github.com/spotify/annoy

Same Issues If we Install Dependence Packages

pip install annoy
WARNING: Ignoring invalid distribution -rotobuf (c:\users\sumeruinfra\appdata\local\programs\python\python310\lib\site-packages)
WARNING: Ignoring invalid distribution -ymongo (c:\users\sumeruinfra\appdata\local\programs\python\python310\lib\site-packages)
Collecting annoy
Using cached annoy-1.17.3.tar.gz (647 kB)
Preparing metadata (setup.py) ... done
Building wheels for collected packages: annoy
Building wheel for annoy (setup.py) ... error
error: subprocess-exited-with-error

× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [19 lines of output]
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-3.10
creating build\lib.win-amd64-3.10\annoy
copying annoy_init_.py -> build\lib.win-amd64-3.10\annoy
copying annoy_init_.pyi -> build\lib.win-amd64-3.10\annoy
copying annoy\py.typed -> build\lib.win-amd64-3.10\annoy
running build_ext
building 'annoy.annoylib' extension
creating build\temp.win-amd64-3.10
creating build\temp.win-amd64-3.10\Release
creating build\temp.win-amd64-3.10\Release\src
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\bin\HostX86\x64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -IC:\Users\sumeruinfra\AppData\Local\Programs\Python\Python310\include -IC:\Users\sumeruinfra\AppData\Local\Programs\Python\Python310\Include -IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\include -IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\ATLMFC\include -IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\VS\include /EHsc /Tpsrc/annoymodule.cc /Fobuild\temp.win-amd64-3.10\Release\src/annoymodule.obj -D_CRT_SECURE_NO_WARNINGS -fpermissive -DANNOYLIB_MULTITHREADED_BUILD
cl : Command line warning D9002 : ignoring unknown option '-fpermissive'
annoymodule.cc
C:\Users\sumeruinfra\AppData\Local\Temp\pip-install-_z1x63lg\annoy_7c08e48d9418499c876cb0133458a99b\src\annoylib.h(19): fatal error C1083: Cannot open include file: 'stdio.h': No such file or directory
error: command 'C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\bin\HostX86\x64\cl.exe' failed with exit code 2
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for annoy
Running setup.py clean for annoy
Failed to build annoy
ERROR: Could not build wheels for annoy, which is required to install pyproject.toml-based projects
[notice] A new release of pip is available: 23.1.2 -> 23.2
[notice] To update, run: python.exe -m pip install --upgrade pip


When type very fast in filter on Firefox, some characters missing

I tried to type google in the filter, but end up with "gogle" or even "goge".

Can't replicate any more, appears to be fixed in newer versions of Firefox.

Yeah, it's fixed here too. Thanks.


Requirejs optimizer error: Mismatched anonymous define() module

The current AMD implementation cause issues with the requirejs optimizer. The culprit appears to be the lack of a module name resulting in the common Mismatched anonymous define() module error after optimization.
Currently, I'm reverting to v1.4.12 which resolves this issue since the AMD implementation was slightly different prior to the change at 45e3ea2e7d3e3edda6e079b21cbff60cdf40f0b0
Is there a way to switch back to the AMD format used in v1.4.12 and still incorporate the changes implemented in v1.4.13?

Thanks @gpgekko I faced same issue when using optimizer and it saved me.

Hi, I changed the initialization code, now the warning should be gone. I like it better now too.
I pushed to master but haven't releases or published to NPM, can you test 2.1.1 and see that it works correctly with AMD and that the warning is gone? remember to test the minified version as well where the warning arises.
Thanks

I ran into this issue today and confirmed that 2.1.1 fixes the problem. Thank you!

Thanks for confirming

When will this be pushed to NPM?

I forgot to release it (or thought the change was too small, I don't remember), I just did.
Thanks


Add ability to add options to --static

Do you think this is a good option to add?
I think the help could be better? 🤔

Thank you for the effort you've put into this, @albinekb! But we had a long discussion about this internally and came to the conclusion that we need stop stop extending the functionality of a the CLI and rather tell people to change their way of handling their projects to the good.
Why?
Just like mentioned here, the "static" deployment type is only meant to be used for uploading files and static websites/apps. If you're building an app that requires any special options for serve (and in turn a package.json file inside the build directory), you should not be using the "static" deployment type.
Instead, you should take advantage of a CLI (like ember-cli, create-react-app, next.js) which handles the building and serving for you on the server.

Yeah, I think that's best too :) added this because @littlestudent wanted it, so for discussion, didn't put more than a minute into this so no time wasted 🤘

@leo I see your point. I am still wondering how we should handle static SPAs?
If I have my built dist/ folder that i want to deploy with serve dist/ --single. How would I achieve this without having now go through npm install?

@littleStudent The platform should handle all of this.  Our goal is to be faster than localhost, and we are already (dependency caching, very fast builds). In turn, I don't see a reason for building locally.

The problem is that I have no control (except if I use Docker) over the machine. So e.g. my elm projects will not work because the build step will fail. So I have to build them locally / on a CI of my choosing and serve the resulting dist/ folder directly.

@littleStudent In that case, you'll have to add a custom package.json with serve in the "start" script, which serves your files.

@leo the downside I see here is that I would like to deploy a site as a SPA, and doing so with serve will run an instance of serve, which (1) takes up one of my 10 instances I get on the premium now plan, (2) can be frozen if there isn't enough traffic, (3) is slower than deploying over CDN. I personally would rather deploy my CRA app as a static site over CDN with a --single command.

@leo the downside I see here is that I would like to deploy a site as a SPA, and doing so with serve will run an instance of serve, which (1) takes up one of my 10 instances I get on the premium now plan, (2) can be frozen if there isn't enough traffic. I personally would rather deploy my CRA app as a static site with a --single command.

In this case, you would need a an app that exports it properly (like next export - more).


fix: fixes a regression that requires a log file in multi-tenant mode

This fixes a regression introduced by #2870 that required a log file to be present on file when using the default config setup for multi-tenant mode. The log file is only required if the user specifically sets the --log-file startup param.

I don't see anything wrong with the changes made, but several integration tests are failing related to the logging config.

@amanji — are you on this?

@swcurran Yes. Just running local tests

It has been just as perplexing to me having gone through the code a few times. There are likely some historical design decisions that I'm not aware of. I do think this can be distilled further down but probably best left for another refactor.


Nested arrow functions.

Say I have:
export default (fn) => () => {
  console.log(arguments);
};

Transpliation results in:
"use strict";
var _arguments = arguments;
module.exports = function (fn) {
  return function () {
    console.log(_arguments);
  };
};

Now, the arguments would the global, rather than the inner function.
//cc @sebmck

This is spec behaviour. arguments is aliased the same way as this in arrow functions.

@sebmck Yikes, I was under the notion, it's only related to lexical context and it's scope, interesting, now how could we even emulate this with fat arrows? (guess it's not possible)
Do you remember the spec section by chance?

@hemanth
9.2.13

17.a NOTE Arrow functions never have an arguments objects.

14.2.17

Any reference to arguments, super, or this within an ArrowFunction are resolved to their bindings in the lexically enclosing function.

Only way to get the arguments object inside an arrow function is with rest parameters. var foo = (...args) => args;

Rest params++ true arrays ;)
I also fooled around with:
export default (fn) => function() {
  console.log(arguments);
};

Thanks for the spec links, that was fast.


[BEAM-8615 BEAM-8569 BEAM-7937] Add hadoop 3 compatibility tests

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PostCommit

Run Spark ValidatesRunner

Run SQL PostCommit

LGTM
Fantastic! I am really happy to see this one in. Gives me so much more confidence on future changes compatibility!

Glad to hear that! :)

This deserves a mention in the CHANGES.md release notes, so don't hesitate to open a PR for this too.

Thanks @piotr-szuberski!
Big +1 to putting this prominently in CHANGES.md so it'll get noticed in the 2.27.0 announcement blog post/release notes


getting current spawns only during log-in

Hi, first of all this is amazing, however is it just me or do I need to log-off and re-login every time from the software in order to reload/refresh new spawns? I ran it on my pc and went out with my mobile but after 15min I would only get expired pokemons and not new ones. I tried to refresh the page on my mobile but it does not work. Thank you

This is related to this issue #72 and has already been addressed (changes have been committed).  Fix should be present in release 0.0.8 (not released yet, hopefully soon?).

Yes it should be soon I think.  0.0.8 was actually released for a few minutes yesterday but there was a java error in the code so it was taken down again quickly. That being said, the aforementioned fixes should already be ready to go as soon as the bug is found fixed.

This should be fixed in the latest release.


Problem with encoding dates in serialization.py

I think the accepted standard of OrientDB is to write and read dates in POSIX/Unix time which means they should be encoded and decoded as if they occurred at UTC midnight. If you use the OrientDB console:
CREATE CLASS Event EXTENDS V
CREATE VERTEX Event SET name='Example', date=Date('1970-01-01 00:00:00')
SELECT @RID, name, date.asLong() FROM Event

You get as expected 0L for the long value stored.
In serializations.py dates are encoded and decoded using local time. This means if the client using pyorient reading a date field is in a more western timezone than who wrote the value using pyorient, they get a different date. (i.e. If you encode 1970-01-01 with current serialization.py in New York it actually writes, 18000000 to the DB. If you then decode that with pyorient in California as a date, you get 1969-12-31). Note in the process pyorient discards the time portion of the timestamp, meaning the dates are truly different.
I can see why this may evade tests, as if the test process that is writing data and the test process reading the data are in the same timezone they will return the same value. (even if still the value stored in the DB is technically wrong). Any tests on dates should be updated to check what the long value stored in the DB is, i.e. Writing 1970-01-01 should store 0L.
Both the encoding and the decoding need to be fixed:
Decoding (lines 322:324 of serializations.py) should change from:
        if c == 'a':
            collected = date.fromtimestamp(float(collected) / 1000)
            content = content[1:]

to
        if c == 'a':
            collected = datetime.utcfromtimestamp(float(collected) / 1000).date()
            content = content[1:]

and encoding (lines 131:132 of serializations.py) should change from:
        elif isinstance(value, date):
            ret = str(int(time.mktime(value.timetuple())) * 1000) + 'a'

to
        elif isinstance(value, date):
            ret = str(int(calendar.timegm(value.timetuple())) * 1000) + 'a'

For the later change, you'll also need to import calendar. calendar.timegm() assumes the date is UTC, time.mktime() assumes its local time. They return 0 (correct) and 18000000 (incorrect for Orient) respectively.

I had the same problem with datetime. I followed your instructions also for 't' (datetime) and not only for 'a' (date):
after
def _encode_value(self, value):
add
from calendar import timegm
and then change
ret = str(int(time.mktime(value.timetuple())) * 1000) + 't'
to
ret = str(int(timegm(value.timetuple())) * 1000) + 't'
and change
collected = datetime.fromtimestamp(float(collected) / 1000)
to
collected = datetime.utcfromtimestamp(float(collected) / 1000)

Hi, i studied your suggestions and i found that these fix doesn't works in all cases.
For example, when a sql string is used instead of an Date object:
CREATE CLASS dt EXTENDS V
CREATE PROPERTY dt.name String
CREATE PROPERTY dt.at Date
CREATE VERTEX dt SET name="today",at="2016-04-10"

The date is stored in Long format inside OrientDB as Date representation, but when it is decoded with this patch by the client it becomes "2016-04-09". Both forms ( String with property Date and the Date Object ) are sent to the client in UnixTime format so is not possible to distinguish between them.
So, i think that the responsibility of writing and decoding the dates in the right Timezone and format, must be delegated to the applications .
In the same manner, if i think to other famous relational databases ( MySQL/Oracle ) i see that they are not aware of the data they store.
Sorry, i mark this as won't fix.

"i think that the responsibility of writing and decoding the dates in the right Timezone and format, must be delegated to the applications ." I 100% agree, but pyorient doesn't let you do that. It forces both the read and write client to write and decode using the local timezone.(by using time.mktime and date.fromtimestamp )  And currently that means it is impossible to use pyorient to store dates if you might have clients reading that are west of you. All dates will be wrong. Or do you have a suggestion on how to use pyorient to do this? The only way I can think of is very hacky, give every date  a separate timezone property for where it was written that also has to be read and if you are reading it further west you increment the date returned by pyorient by one.

Also quick question, did you try your test without my patch (i.e. normal pyorient). I think it also fails.

Surely the datetime management could be improved, but the fix is not so simple because of different date handling between strings and date objects.
I think that your results are not good because the date=Date('1970-01-01 00:00:00') is evaluated at server side and calculated in the timezone of the server. When you retrieve it, the offset changed at your side because of the pyorient.
I suggest you to encode the dates at client side and insert them as string.
As response to your question, yes i tried with your patch and this test fails:
https://github.com/mogui/pyorient/blob/master/tests/test_ogm.py#L418
Any suggestion is welcome

I'm having a problem with this too, and I have to say that the pyorient behavior is incorrect. First, OrientDB can be schemaless or only have partial schema. Considering that dates are commonly found in various types of data, and those types of data may not have schema in your database, this creates a vast difference in handling (more than just the obvious difference of converting a string to a datetime object). In my case, I have a schema with a datetime field, and a data field containing additional JSON. The datetime field is converted to local time, while the nested field remains UTC.
Second, OrientDB's own Studio client does not have this problem. If I run a query in OrientDB Studio, I'll get:
{'start_time': '2016-08-12 21:16:54',
 'data': {'STD': '2016-08-12T21:18:29',
          'STA': '2016-08-12T21:33:29'}}

..while with pyorient I get:
{'start_time': '2016-08-12T14:16:54',
 'data': {'STD': '2016-08-12T21:18:29',
          'STA': '2016-08-12T21:33:29'}}

FYI - as a workaround, since my application is an API and all datetimes returned to the client should be UTC anyway, I just set that as the default at the top of my database Python file:
from os import environ
from time import tzset

environ['TZ'] = 'UTC'
tzset()

This works on OS X, and should work on Linux (or any *nix). Might not work on Windows. Has other effects, of course - like logging timestamps are in UTC - but should be tolerable.

There are two issues here:

Round-trip of Python date(time) objects
String-encoded date(time)s

The CSV serializer can handle round-trips of date(time) objects, so long as encode and decode assume the same time zone. Whether this timezone is local or UTC doesn't matter, no matter what the server timezone is.
pyorient_native wasn't handling round-trips (https://github.com/nikulukani/pyorient_native/issues/3), as encode and decode assumed different time zones (local and UTC, respectively).
With string-encoded date(time)s, the server timezone matters. OrientDB's default server timezone is the local time-zone.
We could run into problems with string-encoded date-times in a few ways. Two that are relevant here:

The client is in a different time-zone from the server
The serializers use UTC, and the server time-zone is not GMT/UTC/Zulu

The first cause is inevitable with multiple clients in varied time zones. Using UTC for encode/decode, the second cause, was proposed as a solution for the first.
Ideally, we want to allow a scenario where pyorient clients and an OrientDB server can happily coexist in multiple time-zones. To support this scenario with both Python date(time) objects and string-encoded date(time)s, two conditions must be met:

The serializers use UTC
The server time-zone is GMT/UTC/Zulu

That the CSV serializer uses the local time zone is a nice default, since it will get by with OrientDB's default. But this is not tenable with real-world scenarios.
The server time zone is configurable (ALTER DATABASE TIMEZONE ""). The pyorient serializer(s) assumed time-zones should also be configurable (I suggest defaulting to local, for both CSV and binary serializers). I think I'll work on this for the CSV serializer, so long as @Ostico is happy with this. Otherwise we're left with the messy choice this issue highlights:

Using the local time-zone: works on a small scale but inevitably broken for likely real-world use
Using UTC: unlikely to work out-of-the-box, but at least any problems can be avoided through server config.

By having this be configurable, we also get away from encouraging workarounds like that proposed by @kived. It generally being good practice to avoid unpredictable global state.

The CSV serializer seems to fail with the roundtrip encoding of dates (atleast with OrientDB 2.2.5). I will write a script that tests both roundtrip (with possibly different timezones)  and string encoded dates to get a better idea of the behavior.

It seems using the using UTC for serializing/deserializing seems to work for all scenarios. Check the output https://goo.gl/c1LuzG generated by the script https://goo.gl/ViLtk8
The script was ran against pyorient and pyorient_native develop branches. The OrientDB server had a UTC+4 timezone setting.

@nikulukani datetime.date.today() is not sufficient for testing round trips, since it doesn't include time.

I am just testing the encoding and decoding of dates with that script. Datetimes are considered a different data type by OrientDB and they are handled correctly by both CSV and Binary serializers, in my opinion.

Just went through some code on the OrientDB side to see how they handle dates and realized that the serialization/deserialization behavior for Binary and CSV is different on the server side. The server behavior for date objects when using binary serialization essentially resolves this issue  (lines 426, 717 and 998-1012 from
https://github.com/orientechnologies/orientdb/blob/2.2.x/core/src/main/java/com/orientechnologies/orient/core/serialization/serializer/record/binary/ORecordSerializerBinaryV0.java#L426)
For CSV serialization/deserialization, the OrientDB server does not perform the conversion from/to  00:00:00 local time to/from  00:00:00 UTC. (lines 638-645 and 474 from https://github.com/orientechnologies/orientdb/blob/7850712aafb3cb7c61a5c2865710019df0a7e8c9/core/src/main/java/com/orientechnologies/orient/core/serialization/serializer/record/string/ORecordSerializerStringAbstract.java#L638).
The latter is what's causing the issue originally reported by OP and reflected in the results I posted. Moreover, the server sets the time to 00:00:00 during deserialization after converting the UNIX time sent over to the database time zone. This behavior is honestly baffling to me and very problematic. This essentially can result in +/- 1 or 2 days difference in encoded/decoded values when the server is not in the same time zone as the client. If clients (applications) do know the database timezone, the best way to avoid problems is to send over the date as UNIX time corresponding to  00:00:00  and decode it using the same scheme when using CSV serialization.
Given the above, I agree with the proposal to have the option of specifying a non-default encoding and decoding time zone for Dates to mitigate this issue. For DateTime, I cannot foresee a situation where it would be useful, but having the option can't hurt!
Finally, on a related but unrelated note, it seems that OrientDB stores dates as UNIX time corresponding to  00:00:00 . I am not sure if they process all dates in the database if the database timezone is changed (ALTER database ), but I would venture that they do not. This means that the date values stored in the DB (or at least their interpretation) will change if the database timezone is changed after a record was created. As such, I would suggest caution with using ALTER database  command if you have records with date fields already in OrientDB.


Compression method not supported - 11gb file

I am trying to extract the file from 1gb .zip(Actual file size is 11gb). In both .TAR.gz and .zip is getting this error. TarEntry entry = tarInStream.GetNextEntry(); this line getting this error.
FileStream fileStreamIn = new FileStream
(SrcFile, FileMode.Open, FileAccess.Read);
TarInputStream tarInStream = new TarInputStream(fileStreamIn);
        TarEntry entry = tarInStream.GetNextEntry();
        FileStream fileStreamOut = new FileStream
            (WorkingFile + @"\" + entry.Name, FileMode.Create, FileAccess.Write);
        int size;
        byte[] buffer = new byte[BufferSize];
        do
        {
            size = tarInStream.Read(buffer, 0, buffer.Length);
            fileStreamOut.Write(buffer, 0, size);
        } while (size > 0);
        tarInStream.Close();
        fileStreamOut.Close();
        fileStreamIn.Close();

@euginesm
You have not submitted enough information to determine if this is a problem with SharpZipLib, or a problem with your code. When you are able to generate more specific information, please open another issue.
-Neil


Automatic classification of expense category

Feature

Automatically classify expenses into categories, based on store_name text

Implementation

Prepare a user-defined CSV which includes store_name, category_large, and category_middle
Create function to obtain categories from store_name
Create function to obtain ID of categories from MoneyForward

IDs can be obtained from ul.dropdown-menu.main_menu.minus

Include ID of categories when submitting form

Created branch https://github.com/mu373/paypaycard-fetcher/tree/feature/automatic-category-classification

Created template file for user-defined category list: https://github.com/mu373/paypaycard-fetcher/commit/83835a51debd8c8b69b7261af9fac9c5a7473fc6


fix: avoid doubly-bundling runtime types

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
At the moment we are bundling two copies of various runtime types, one in the main nitropack index.d.ts and another in the runtime directory. The danger with this is that types can get out of sync when extending one of those two.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

previewing this and https://github.com/unjs/nitro/pull/1333 in https://github.com/nuxt/nuxt/pull/21683.
we can confirm everything is passing before merging/releasing


jak1: use 'base for water volumes and use enum when setting task-status on save load

115 FeelsBadMan


ghpages OR/AND exaples AND component aframe-registry

It`s only my point of view
what I`m talking about?
    "preghpages": "npm run build && shx rm -rf gh-pages && shx mkdir gh-pages && shx cp -r examples/* gh-pages",
    "ghpages": "npm run preghpages && ghpages -p gh-pages",

it`s bad practice: no sources
it is good for commercial usage, just show example
ghpages aka source code

I thought we should upload full component repository with source (like polymer web-components)
add license (done)
add readme (done)
git init && git add -A && git commit -m 'git aframe-COMPONENT_NAME-component' (it`s not neccasary)
git remote add origin https://github.com/USERNAME/aframe-COMPONENT_NAME-component.git (it`s not neccasary too)

Usage
  $ ghpages

Options
  -p, --path    Path (directory to push; defaults to current directory)
  -r, --repo    Repository (GitHub username, GitHub username/repo, full repo URL)
  -d, --domain  Domain name (for `CNAME` to create in GitHub Pages branch)
  -p, --path    Path or directory to publish. Defaults to root directory of project.
  -h, --help    Show help

Examples
  $ ghpages
  $ ghpages cvan
  $ ghpages cvan/blog
  $ ghpages cvan/blog -p dist
  $ ghpages git@github.com:cvan/blog.git
  $ ghpages -r cvan/blog -d blog.cvan.io

Deploy
I surpose just add now
   "deploy": "ghpages -r {{ repo }}",

A-Frame Registry
It would be great to add only good component
Web-components Registry have bad practice allow everyone to publish component, then it look like
scrap-heap :-)
I don`t know how A-Frame team add component to Registry
Manualy?

Oh, sorry!
ghpages did not create repo for U
I don`t like it (ghpages) or just want to sleep )))
Question about publish still open

GitHub Pages is the component's homepage.
Registry submission is curated. All Registry submissions usually have a GitHub Pages.

https://github.com/node-gh/gh
this will create repo
$ npm i gh -g
$ gh re --new aframe-foo-component --gitignore Node
First we need authorization to use GitHub\'s API. Login with your GitHub account.
? Enter your GitHub user 7dir
? Enter your GitHub password ************
Writing GH config data: C:\Users\Administrator\.gh.json
Authentication succeed.
Creating a new repo on 7dir/aframe-foo-component
https://github.com/7dir/aframe-foo-component
[hook] gh re --browser  --user 7dir --repo aframe-foo-component

@ngokevin what about add this features?

@ngokevin
could add this component/packages.json?
  "mkrepo": "gh re --new {{ npmName }} --gitignore Node",

or U should add it to README.md
To publish the component to the ecosystem:
make sure github repo exist

Yeah I think that's a good idea. A command to create a GitHub repo.


Update 2020-07-31-kubeflow-1.1-blog-post.md

3 updates, added section for KF Serving, updated Ant Financial to Ant Technology Group and added Dan Sun as contributor.

Thanks. I updated it to "Ant Group" since that's the official name.

The conflict is due to the markdown being removed in https://github.com/kubeflow/blog/pull/22.

I can help resolve this conflict since it appears to be straight forward

@jbottum I went ahead and resolved conflicts in favor of everything in this branch and merged it for you 🙇  Great post!


Controlling services in bulk or better/flexible --all behavior

The discussion started here.
Currently, you can only start|stop|reload services one by one or all of them at once with --all flag. However, in some cases, you need finer control.
For example, now PHP migrated to homebrew/core and comes with Apache as a dependency. I'm using Nginx instead of Apache, and have a lot of other related services. Here's the list:

dnsmasq
mailhog
nginx
memcached
redis
mariadb
blackfire-agent
php
httpd (the Apache service I don't need)

Basically, it's a local web development environment. Prior to this PHP migration, I could brew services start --all to bring it up, and brew services stop --all when done. Now I can't – it starts Apache as well.
Also, redis/memcached substitute each other in many cases, it makes sense to run only one of them at a time. Same applies to a different database engine, for example, MySQL and PostgreSQL, MongoDB etc. Also, Nginx, H2O. In most cases, you don't need them all to be running at the same time and running them one by one is annoying.
Of course, you can write a simple shell command to run required services in bulk, but wouldn't it be convenient to have a built-in command to handle some kind of "presets"?

This may not be helpful at all but inspired by this discussion, I’ve hacked together a really crude one-off prototype for a lightweight implementation of presets.
It uses one custom formula per preset, runs with homebrew-services as-is, and requires nothing else. Because it’s just a formula, it also auto-detects the dependencies.
Usage:
brew tap claui/services-bulk

brew install myservers

[sudo] brew services list

[sudo] brew services [start | restart | stop] myservers

To customize, just change this array:
  DEPENDENT_SERVICES = [
    "mariadb",
    "nginx",
    "php",
  ]

I’m surprised to see this actually works for me. Feel free to use it as a stop-gap until someone builds something more maintainable. (Or maybe in case the presets feature turns out too narrow to be added to homebrew-services proper.)

Thank you @claui, I'll give it a shot soon. Looks promising!

This is a good idea, thanks for the detailed write up @ihorvorotnov!

Do not make any sense to me too keep Apache as a dependency. As mention above. People might run Nginx, no use for a web server OR they use PHP built in web server. Do not forget that MacOS already ship with Apache installed that work flawlessly with homebrew php-versions.

@steinmb Your comment was completely unrelated to this repository. The other thread was locked for a reason.

@MikeMcQuaid Thank you for getting back to me, though deleting comments is to me a unusual way of treating other developers. Ended up there because other issues got closed and linked in here. Should I create a separate issue regarding the dependency issue?

@steinmb No, we are not interested in more discussion of that issue or of Homebrew's moderation policy with non-maintainers or non-contributors (particularly when Homebrew's maintainers are currently being barraged with personal abuse).

httpd will not be installed any more if you use the bottle: https://github.com/Homebrew/homebrew-core/pull/24907


Made changes to CONTRIBUTING.md file

Issue Number
fixes #191

Describe the changes you've made

In  CONTRIBUTING.md file , in the section of using Yarn as a package manager  :
1 .I added the guideline to install the package using Yarn  which was  was not present previously in the documentation
2. I changes the heading  " Running in Deployment Mode " to " Running in Development Mode "  for Yarn Section Heading
Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)
NA , there was only a lil correction in the documentation

Additional context (OPTIONAL)

Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

@rajatgupta24 Made the changes successfully
Thanks for the opportunity


Typescript missing ErrorEvent type

In the index.d.ts file, the ErrorEvent type is missing, and it's giving me this error.

I have lib: ["ES2021"]

try with lib: ["ES2021", "DOM"]

It worked, thank you.


Login error

What is the output link of /viaversion dump?
http://hastebin.com/waxotikuxa.json
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
BungeeCord
How does this error happen? login? Using an item?
Login
Is there an error in the console? Use pastebin.com. Is there a kick message?
[10:45:02 INFO]: alvo lost connection: Internal Exception: us.myles.ViaVersion.exception.InformativeException: Please post this error to http://github.com/MylesIsCool/ViaVersion/issues
{Type: String, Source #0: us.myles.ViaVersion.protocols.protocol1_9to1_9_1.Protocol1_9TO1_9_1$1 (Anonymous), Data: [Pair{Type|Integer, 19553}, Pair{Type|Unsigned Byte, 0}, Pair{Type|Byte, 4}, Pair{Type|Unsigned Byte, 102}, Pair{Type|Unsigned Byte, 108}], Packet ID: 35}
Actual Error:

Could you change debug=true in server.properties and provide us with the full error?

Provide more info if you want this solved and request reopen.


Stricter data type for dask keys

Follow up to dask/distributed#8083
Blocks https://github.com/dask/distributed/issues/8130

dask/distributed#8083 recently redefined dask keys from any hashable to bytes, float, int, str, or tuples thereof.
While it is possible to run dask/dask on schedulers other than distributed, I don't think it's a healthy idea to have stricter restrictions in dask/distributed than in dask/dask.
Actions

Create a new type alias,

DaskKey: TypeAlias = Union[str, bytes, int, float, tuple["DaskKey", ...]]

Search the dask/dask codebase for all instances of Hashable and replace wherever applicable with DaskKey
Update documentation, e.g. https://docs.dask.org/en/stable/spec.html#definitions
Move the new function validate_key from dask/distributed to dask/dask; add unit tests

CC @fjetter @jrbourbeau @hendrikmakait @jacobtomlinson


Switch to avian2.0

Avian2.0 was finally released with bevy 0.15 support

I published it yesterday to crates.io, but forgot to create a release on GitHub.
Done now: https://github.com/vleue/vleue_navigator/releases/tag/v0.11.1


.env and http init

creates a .env and docker-compose.yml for better maintenance
proposes an untested solution for https://github.com/epoz/shmarql/issues/9 https://github.com/epoz/shmarql/issues/10 https://github.com/epoz/shmarql/issues/11

instead of updating the Store on the fly the loading of the Store can now be called via endpoint /init/graph. Similar for fts and RDF2Vec
the /init route is behind HTTPBasicCredentials, User and PW defined in .env (resp. config.py)

Issue

[ ] unsure how the global variables loaded/initialized in main.py can be updated in the best way if changed at runtime. Maybe a better way would be Dependency Injection in FastAPI with Depends for all depending endpoints

The main stuff has been tested briefly

/init/graph route works with HTTPBasicCredentials defined in .env
query params in https://github.com/epoz/shmarql/pull/17/commits/3e3ddf7910f0b809a3b3ecb48a12aaba522d32c1 have not fully been tested, only use_default_graph_as_union for https://github.com/epoz/shmarql/issues/13#issuecomment-2307225004


[BUG] Failed to start a server — UnicodeDecodeError

Using v2024.1.10961014, the extension crashes immediately on start up due to server initialization failure.
[info] [Error - 1:34:18 PM] Restarting server failed
[info]   Message: Pending response rejected since connection got disposed
  Code: -32097
[info] Fatal Python error: init_import_site: Failed to import the site module
Python runtime state: initialized
Traceback (most recent call last):
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\site.py", line 617, in <module>
    main()
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\site.py", line 604, in main

[info]     known_paths = addsitepackages(known_paths)
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\site.py", line 387, in addsitepackages
    addsitedir(sitedir, known_paths)
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\site.py", line 226, in addsitedir
    addpackage(sitedir, name, known_paths)
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\site.py", line 179, in addpackage
    for n, line in enumerate(f):
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\codecs.py", line 322, in decode

[info]     (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe7 in position 3: invalid continuation byte

I suppose it's due to some non latin characters in somewhere in the path, however the encoding is utf-8

@antshar this seems like an issue with python itself. I don't see any of the extension python code on stack at all.
Try this in a terminal and see if that runs for you. We set PYTHONUTF8=1 before starting the server script, so you might have to do the same.
> cd <dir with non-latin char>
> set PYTHONUTF8=1
> <python3.10 path> <some_script.py>

I tried the proposed steps and yes, set PYTHONUTF8=1 reproduces the very same error indeed. Moreover, even if a path doesn't contain non-latin character, the error still shows up. I tried C:\test\foo.py.
Can it be related to the fact, my window's language is cyrillc based? Is there any way I can fix the issue (I'm ok with any possible workaround)?

@antshar Does it run fine without the PYTHONUTF8=1? You can unset it by using this command set PYTHONUTF8=. Can you share your environment variables? I would particularly like to see the language env variables.

Unsetting PYTHONUTF8 makes C:\test\foo.py to run perfectly, but I don't know how to unset it for autopep8.
Here are all env variables I get https://pastebin.com/y2g9HEzg (I don't see any language variables here, though)

I've just noticed that the following
> cd C:\test
> set PYTHONUTF8=1
> python foo.py

leads to an error only when running from cmd.exe while in powershell and git bash set PYTHONUTF8=1 doesn't cause and exception.

@antshar Can you share the version of python you are using? also can you launch the python in PowerShell (where it works) and run the following commands:

I'm pretty sure I installed python from python.org

I have asked someone with more experience in this area for input on this issue. Meanwhile I think you need to ask this on python.org. Since this is related to running Python itself and not really limited to the extension.

Yes yes, I think the issue can be closed as not related to extension. Thank you for helping me find the cause in the first place, I appreciate that.
While I'll be finding a solution to this, I removed "PYTHONUTF8": "1" everywhere in sources HOME\.vscode\extensions\ms-python.autopep8-2024.0.0 as a dirty fix, so I can use the extension.

@antshar i heard back from someone. You might have a .pth file somewhere that I has the character that might be causing this.

I made a search with Everything which found ten-ish .pth files, mostly in %PYTHONPATH%. I checked each of them and yes, there was a single one that contained non-latin characters. It was easy-install.pth with a single line — path to jupyterlab_sublime-master.
Once I removed it, everything started to work with PYTHONUTF8=1. That's an impressive guess with .pth files! I must admit I spent a couple of hours trying to find a solution, but I found nothing even close to this.
I'm really grateful for your help, especially because it went far beyond autopep8 scope, so you could just say "unrelated".

That's an impressive guess with .pth files!

Allow me to spoil the magic 😄 Open the file from the second last line of your traceback and look around the for loop that broke:
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\site.py", line 387, in addsitepackages
    addsitedir(sitedir, known_paths)
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\site.py", line 226, in addsitedir
    addpackage(sitedir, name, known_paths)
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\site.py", line 179, in addpackage
    for n, line in enumerate(f):
  File "c:\Users\antshar\AppData\Local\Programs\Python\Python310\lib\codecs.py", line 322, in decode


fix(overlay): content not becoming scrollable inside flexible overlay on IE11

Fixes flexible overlays not becoming scrollable when they hit the edge of the viewport on IE11.

On IE11, do the overlays extend outside the bounding box, or do they get cut off?

The overlay goes beyond the bounding box on IE @jelbourn:

Could we work around it by setting measuring and setting a fixed px height on IE11 only?

We already know the height so we don't have to measure, but the issue is knowing what to set it on. It has to be on whatever element has the overflow: auto, but figuring it out is expensive and not super reliable since there could be multiple elements.

Wouldn't setting it on the overlay panel let the content just be max-height: 100% overflow: auto?

Actually we don't even need to set the exact height on it, just doing height: 100% works, because the bounding box has a defined height. That being said, I don't think we can go with this approach, because it'll end up throwing off our measurements. Since we use the overlay pane to determine the height of the content, making it match the bounding box height will make it go to the fallback positions when it doesn't have to on small overlays.

Wouldn't we just set the explicit height after we've done the position selection? IIRC, that's why it calls the _resetOverlayElementStyles method at the beginning of apply.

Closing since we're dropping support for IE.


Unable to drain endpoints before removal

Title: Unable to drain endpoints before removal
Description:
I'm trying to implement endpoint connection draining (and not draining envoy itself) with sticky sessions configured.
At t=0, there are 5 endpoints configured in my envoy cluster with cookie based sticky sessions configured.
At t=10, I wish to drain 1 out of the 5 endpoints I have i.e. I do not want any new connections to be routed to that endpoint, but I want the current sessions to persist before I remove the endpoint from the list.
In order to drain an endpoint, I've tried 2 approaches -

Set 'health_status': 'DRAINING' in the endpoint  (See https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/health_check.proto#envoy-api-enum-core-healthstatus)
This takes care of not sending any new connections to the endpoint, but does not allow older sticky sessions to persist and they're broken off.
I got leads for this from https://github.com/envoyproxy/envoy/issues/2920#issuecomment-388123100, but doesn't seem to work :man_shrugging:

Set load_balancing_weight: 1 in the endpoint in the hope that a lower weight will not route any new requests to the endpoint but the sticky sessions will persist, but that didn't happen.

So, what am I missing here? Any pointers are appreciated! Thanks :)
Config:
This is how the endpoint configuration looks when I'm trying to drain it -
                                {
                                    "endpoint": {
                                        "address": {
                                            "socket_address": {
                                                "address": "<IP_ADDRESS>",
                                                "port_value": 8080
                                            }
                                        }
                                    }
                                },
                                {
                                    "endpoint": {
                                        "address": {
                                            "socket_address": {
                                                "address": "<IP_ADDRESS>",
                                                "port_value": 8080
                                            }
                                        }
                                    },
                                    "health_status": "DRAINING"
                                },

I think I understand what you are after, but I'm not sure how it can be implemented cleanly. How would Envoy know that a session is OK to keep sending to an endpoint? Do you expect this to be somehow encoded in the cookie?

@mattklein123 thanks for the prompt reply ;)
I think the best I can explain this is the way is quoting how Nginx drains sticky sessions (more at https://www.nginx.com/blog/nginx-plus-backend-upgrades-individual-servers#server-api-persistence)

Session persistence is required for any application that keeps state information for users (such as a shopping cart), but it complicates upgrades because now it is not enough just to wait until there are no active connections to our server before taking it offline. There might be clients that aren’t sending requests right now but haven’t ended their session with the server. For the best user experience, we want to keep the active sessions open – the amount of time depends on the application – but don’t want any new sessions to start.

In this case, before taking the server offline we don’t only want the number of active connections to be zero, but also for all sessions to end. That translates to the server being idle for some amount of time, which depends on the application. We can periodically check the dashboard or use the status API to determine that the server is idle, but we can also automate the process of marking a server drain and verifying it is idle before marking it down.

So, from what I understand, Envoy could do this 2 ways -

Allow the application to specify the drain time - during which no new connections are sent but older ones persist - and after which the endpoint is removed from the configuration
Allow an endpoint to be marked as draining (which is more like 'unhealthy soon' than 'unhealthy now') - and when marked no new connections are sent but older ones persist.

More reading

haproxy-ingress implements this by setting 0 weight to the endpoint which translates to no new connections but continue older ones - the implementation is at https://github.com/jcmoraisjr/haproxy-ingress/pull/95 which is well explained
An outstanding feature request on Nginx's Kubernetes' ingress at https://github.com/nginxinc/kubernetes-ingress/issues/267 - some pointers in the discussion there
Feature request on Ambassador (on which I am working on) - https://github.com/datawire/ambassador/issues/1473

I just tried separating the draining endpoints and healthy endpoints into 2 different clusters, and then pointed the route to both of them via weighted_clusters (draining cluster with weight 0, and healthy cluster with weight 100), but no luck. Sticky sessions do not persist -
                                                            "weighted_clusters": {
                                                                "clusters": [
                                                                    {
                                                                        "name": "cluster_qotm_er_ring_hash_cookie_sticky_cookie",
                                                                        "weight": 100
                                                                    },
                                                                    {
                                                                        "name": "draining_cluster",
                                                                        "weight": 0
                                                                    }
                                                                ]
                                                            }

I'm sorry I don't fully understand what you are after. Session stickiness is supported effectively via hashing of an incoming request cookie. How can Envoy understand whether to continue to route existing sessions without some state in the cookie itself?
Do you mean that you want users with existing cookies to keep routing, but no new cookies to be issued that target that upstream?

Do you mean that you want users with existing cookies to keep routing, but no new cookies to be issued that target that upstream?

@mattklein123 Yep, exactly :+1:
I want to drain an endpoint/upstream and I want to give it 1 hour to drain. In that one hour, I want already existing sticky sessions to keep routing to that very upstream, but I don't want any newer sticky sessions to be issued to that upstream.

OK I think I understand what you are after. Right now the cookie hashing policies just effectively store a hash value in the cookie and are meant for use with a consistent hashing load balancer. When a host is failed, the rest of the hosts will rehash. There is no actual state stored in the cookie itself.
I think we could support something like this but it would take a bunch of thinking on how to do it. @alyssawilk any thoughts on this one given the existing cookie support?

I'm not terribly familiar with Envoy upstream selection.    I also kind of see how this would work for H2, where you can check connection lifetime vs drain time if we move a bunch of APIs around but I'm less convinced it works well for HTTP/1 given that you may have a preexisting pipeline connection and then prefetch more, and have inconsistent state?
I think rather than base this on connection lifetime it might make sense to do some logic around cookie max-age, where if the client connection were in continued use Envoy could continue extending the max-age and if the client went idle the cookie would expire.  Then it's just a question of having a state where your backend selection always uses the hash when the cookie is present, and only selects from non-draining backend when the cookie is not present?

After kicking this around at Datawire for a bit, we think that it would work to add a way to mark a given upstream as "blacklisted for new hashes only":

if a request comes in with a valid (non-expired) cookie directing it to the blacklisted upstream, fine, go ahead and route.
if a request comes in with no cookie, or with an invalid or expired cookie, never allow the hash to select any blacklisted upstream.

Does that sound like a reasonable approach?

Does that sound like a reasonable approach?

Conceptually it would work, but I think the implementation will be complex, as then we need a per-host draining concept (which I guess we have today but I would need to refresh the details). Worse, and this is where I would really have to think it through, I'm not convinced this works well at all if the upstream hosts are stable and things rehash. Are we assuming upstream stability? Even if we assume upstream stability, once a host drains and then goes away, 1/N approximately are going to rehash again anyway so don't you still need to support migration?

@mattklein123 @alyssawilk can we mark this as 'help wanted'?

OK I think I understand what you are after. Right now the cookie hashing policies just effectively store a hash value in the cookie and are meant for use with a consistent hashing load balancer. When a host is failed, the rest of the hosts will rehash. There is no actual state stored in the cookie itself.
I think we could support something like this but it would take a bunch of thinking on how to do it. @alyssawilk any thoughts on this one given the existing cookie support?

@mattklein123 this isn't a concern now with sessionFilter
Since podIP is used directly.


[Workers - Durable Objects] Add Troubleshooting section

Added a Troubleshooting section to "Using Durable Objects", to help users debug more easily
Changed "actor" to "Durable Object" in Durable Objects API

@greg-mckeon


[Feature Request] add a lang translate

Is your feature request related to a problem? Please describe.
No just suggestion
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe the basic flow/steps of using this feature
How this feature would be used:
maybe add a lang.txt for translate bot
Additional context
Add any other context or screenshots about the feature request here.
Have you confirmed that this idea is not already described here?
https://github.com/jagrosh/MusicBot/projects/1

Duplicate of an existing planned feature


Remote-Write fails with import on k6

root@bastion:~# go version
go version go1.18 linux/amd64
root@bastion:~# cat k.js
import remote from 'k6/x/remotewrite';
root@bastion:~# k6 run k.js
      /\      |‾‾| /‾‾/   /‾‾/
 /\  /  \     |  |/  /   /  /
/  \/    \    |     (   /   ‾‾\

/          \   |  |\  \ |  (‾)  |
/ __________ \  |__| _\ ____/ .io
ERRO[0000] unknown module: k6/x/remotewrite
at go.k6.io/k6/js.(*InitContext).Require-fm (native)
at file:///root/k.js:1:0(6)  hint="script exception"

Hi @sharathfeb12 , sorry for the slow reply.
xk6 builds a new binary called k6 in the local directory when you run xk6 build ..... To run it you need to use ./k6 run  ... isntead of k6 run which will run whatever k6 is in your $PATH


Avalonia Linux Support

Is there any plans for Linux  support with Avalonia？

Linux support is not in the near future plans.


filter tags can not be done in differnet language

after tested, it is found that the tag wirten in language other than English can not be well supported, (for example ,in chinese)

At last, this is fixed in the latest 2.1.x release.


no element "omxh264dec"

Good day! I am trying to build and use your project. I am getting the following message.
[gstreamer] gstDecoder -- failed to create pipeline
[gstreamer]    (no element "omxh264dec")
[gstreamer] gstDecoder -- failed to create decoder for file:///home/smalashenko/My_projects/C++/jetson-inference/build/x86_64/bin/./e36-test-29294ba2ae_1602173004_587.mp4
detectnet:  failed to create input stream

Hi @SergeyMalashenko , it appears you are building this on x86_64, so the jetson-utils video decoding won't work there (as those hardware-accelerated gstreamer elements are for Jetson only)
You can try changing the GStreamer element here:
https://github.com/dusty-nv/jetson-utils/blob/833fc7998e34d852672277730a11aeed90024959/codec/gstDecoder.cpp#L554
You would want to change it from omxh264dec to a h264 decoding plugin for GStreamer that you have on x86 (see here)

Hardware: Jetson Nano 4GB
video-viewer --input-codec=h265 rtsp://admin:rgbsi123@<IP_ADDRESS>:554/Streaming/channels/101
[gstreamer] initialized gstreamer, version <IP_ADDRESS>
[gstreamer] gstDecoder -- creating decoder for<EMAIL_ADDRESS>Opening in BLOCKING MODE
Opening in BLOCKING MODE
NvMMLiteOpen : Block : BlockType = 279
NVMEDIA: Reading vendor.tegra.display-size : status: 6
NvMMLiteBlockCreate : Block : BlockType = 279
[gstreamer] gstDecoder -- discovered video resolution: 1280x720  (framerate 0.000000 Hz)
[gstreamer] gstDecoder -- discovered video caps:  video/x-h265, stream-format=(string)byte-stream, alignment=(string)au, width=(int)1280, height=(int)720, chroma-format=(string)4:2:0, bit-depth-luma=(uint)8, bit-depth-chroma=(uint)8, parsed=(boolean)true, profile=(string)main, tier=(string)main, level=(string)3.1
[gstreamer] gstDecoder -- pipeline string:
[gstreamer] rtspsrc location=rtsp://@<IP_ADDRESS>:554/Streaming/channels/101 latency=2000 ! queue ! rtph265depay ! h265parse ! omxh265dec ! video/x-raw ! appsink name=mysink
[gstreamer] gstDecoder -- failed to create pipeline
[gstreamer]    (no element "omxh265dec")
[gstreamer] gstDecoder -- failed to create decoder for rtsp://@<IP_ADDRESS>:554/Streaming/channels/101
video-viewer:  failed to create input stream
omxh264dec and omxh265dec not found on jetson nano

Can you run gst-inspect-1.0 | grep omx ?   Are there any listed?
These should be automatically installed when you use the Nano SD card image.

gst-inspect-1.0 | grep omx
libav:  avenc_h264_omx: libav OpenMAX IL H.264 video encoder encoder
I downloaded the image from this link:
https://developer.nvidia.com/jetson-nano-sd-card-image

This is the expected output:
gst-inspect-1.0 | grep omx

libav:  avenc_h264_omx: libav OpenMAX IL H.264 video encoder encoder
omx:  omxmpeg4videodec: OpenMAX MPEG4 Video Decoder
omx:  omxh264dec: OpenMAX H.264 Video Decoder
omx:  omxh265dec: OpenMAX H.265 Video Decoder
omx:  omxvp8dec: OpenMAX VP8 Video Decoder
omx:  omxvp9dec: OpenMAX VP9 Video Decoder
omx:  omxmpeg2videodec: OpenMAX MPEG2 Video Decoder
omx:  omxwmvdec: OpenMAX WMV Video Decoder
omx:  omxh264enc: OpenMAX H.264 Video Encoder
omx:  omxh265enc: OpenMAX H.265 Video Encoder
omx:  omxvp8enc: OpenMAX VP8 Video Encoder
omx:  omxvp9enc: OpenMAX VP9 Video Encoder
omx:  nvoverlaysink: OpenMax Video Sink

You may want to try re-flashing your SD card and confirm what this outputs with a fresh image.


Add support for Google Cloud Storage

Add support for Google Cloud Storage

Possible method on how to obtain storages used per blob.
https://stackoverflow.com/questions/39784244/google-cloud-storage-python-list-blob-not-printing-object-list
def list_blobs(bucket_name):
    """Lists all the blobs in the bucket."""
    storage_client = storage.Client()
    bucket = storage_client.get_bucket(bucket_name)

    blobs = bucket.list_blobs()

    for blob in blobs:
        print(blob.name)

The blob object should have size attribute somewhere


feat(vector): replace image of vector from official to product-image

close #156

@CodiumAI-Agent /review

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review
Code ClarityThe new implementation of VectorCommandArgs in lines 204-221 introduces a complex bash script. This script is crucial for the operation of the vector container but is hard to read and maintain. Consider simplifying or documenting key parts of the script for better maintainability.
Possible BugThe new VectorDecorator struct in lines 42-51 includes a new optional field LogProviderContainerName. However, there is no initialization or usage of this field in the provided methods which might indicate incomplete implementation or a design oversight.

@CodiumAI-Agent /improve

PR Code Suggestions ✨

CategorySuggestion                                                                                ScorePossible issue

Add error handling to ensure the vector process is terminated on script error

Ensure that the vector_pid is correctly handled in case of an error during the command execution. Use a trap to catch errors and ensure the process is killed if an error occurs.
pkg/builder/vector.go [212-218]
 vector --config ${CONFIG_DIR}${VECTOR_CONFIG_FILE} & vector_pid=$!
+trap "kill $vector_pid 2>/dev/null" ERR
 if [ ! -f "${LOG_DIR}${VECTOR_LOG_DIR}$/${VECTOR_SHUTDOWN_FILE}" ]; then
   mkdir -p ${LOG_DIR}${VECTOR_LOG_DIR} && \
   inotifywait -qq --event create ${LOG_DIR}${VECTOR_LOG_DIR}; \
 fi
 sleep 1
 kill $vector_pid

Suggestion importance[1-10]: 8
Why: The suggestion correctly adds error handling to ensure the vector process is terminated if an error occurs, which is crucial for preventing orphan processes and ensuring system stability.
8

Ensure directory and file creation commands do not fail silently

Add error handling for the mkdir and touch commands to ensure directory and file creation is successful.
pkg/builder/vector.go [408]
-mkdir -p {{ .LogDir }}{{.VectorLogDir}} && touch {{ .LogDir }}{{.VectorLogDir}}/{{ .VectorShutdownFile }}
+mkdir -p {{ .LogDir }}{{.VectorLogDir}} || { echo "Failed to create directory"; exit 1; }
+touch {{ .LogDir }}{{.VectorLogDir}}/{{ .VectorShutdownFile }} || { echo "Failed to create file"; exit 1; }

Suggestion importance[1-10]: 7
Why: Adding error handling for directory and file creation is important to prevent silent failures, which can lead to unexpected behavior or errors later in the execution.
7
Enhancement

Improve reliability of file creation monitoring

Consider using a more robust method for monitoring file creation than inotifywait to avoid potential issues with missed events or scalability in large systems.
pkg/builder/vector.go [215]
-inotifywait -qq --event create ${LOG_DIR}${VECTOR_LOG_DIR}
+while ! [ -f "${LOG_DIR}${VECTOR_LOG_DIR}/${VECTOR_SHUTDOWN_FILE}" ]; do
+  sleep 1
+done

Suggestion importance[1-10]: 6
Why: The suggestion offers a more reliable method for monitoring file creation, which can be beneficial in environments where inotifywait might miss events, though it may not be necessary in all cases.
6
Performance

Simplify string assignment for better performance and clarity

Replace the use of fmt.Sprintf with direct string assignment for static values to avoid unnecessary overhead and improve code clarity.
pkg/builder/vector.go [205-219]
-arg := fmt.Sprintf(`
-CONFIG_DIR=%s
-LOG_DIR=%s
-VECTOR_LOG_DIR=%s
-VECTOR_SHUTDOWN_FILE=%s
-VECTOR_CONFIG_FILE=%s
+arg := `
+CONFIG_DIR=/kubedoop/config
+LOG_DIR=/kubedoop/log
+VECTOR_LOG_DIR=_vector
+VECTOR_SHUTDOWN_FILE=shutdown
+VECTOR_CONFIG_FILE=vector.yaml
 vector --config ${CONFIG_DIR}${VECTOR_CONFIG_FILE} & vector_pid=$!
 if [ ! -f "${LOG_DIR}${VECTOR_LOG_DIR}$/${VECTOR_SHUTDOWN_FILE}" ]; then
   mkdir -p ${LOG_DIR}${VECTOR_LOG_DIR} && \
   inotifywait -qq --event create ${LOG_DIR}${VECTOR_LOG_DIR}; \
 fi
 sleep 1
 kill $vector_pid
-`, constants.KubedoopConfigDir, constants.KubedoopLogDir, productlogging.VectorLogDir, productlogging.VectorShutdownFile, VectorConfigFile)
+`

Suggestion importance[1-10]: 4
Why: While replacing fmt.Sprintf with direct string assignment can improve performance slightly, the change is minor and does not significantly impact the overall functionality or readability of the code.
4


Stereo labels appears on not stereo structure after 'Aromatize' action.

Affected Versions: Standalone
Steps to Reproduce:

Open 'non-aromatic-structures.mol' file.
Click 'Aromatize' button.

Expected Result:
Nothing should be changed on canvas when the non-aromatic structures are present on the canvas.
Actual Result:
Z labels appears on cyclooctane structure.

Issue doesn't repeat anymore

Issue doesn't repeat anymore

Bug was fixed in another issue.
Closed as not reproduces.

Bug was fixed in another issue.
Closed as not reproduces.


Documentation for indeterminate state

There is a one part on the demo page for checkbox with indeteminate state (or partially checked, that is instead of a checked, a minus signed is placed instead), although there is no documentation on how to implement this. I wonder if you really left that out because of that No Javascript! tag line.
Will you not add that changeState() function in the document?

+1


Fix some minor AMG and const issues

This fixes some minor correctness issues for using BoomerAMG with non-elasticity problems as well as adds a non-const version of the FilterViewIterator.

LGTM

LGTM

LGTM

LGTM


The Crate Does not Compile when the defmt-03 Feature is Enabled

Problem
Currently (on master commit 1c585d4), the crate embedded-hal and embedded-io does not compile when enabling the defmt-03 feature. The following command is run :
[./embedded-hal] $ cargo build --features defmt-03;

And these errors are returned :

Errors
error[E0433]: failed to resolve: could not find `defmt` in the list of imported crates
   --> embedded-hal/src/i2c.rs:192:41
    |
192 | #[cfg_attr(feature = "defmt-03", derive(defmt::Format))]
    |                                         ^^^^^^^^^^^^^ could not find `defmt` in the list of imported crates
    |
    = note: this error originates in the derive macro `defmt::Format` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing this crate through its public re-export
    |
164 + use crate::defmt;
    |

error[E0433]: failed to resolve: could not find `defmt` in the list of imported crates
   --> embedded-hal/src/i2c.rs:192:41
    |
192 | #[cfg_attr(feature = "defmt-03", derive(defmt::Format))]
    |                                         ^^^^^^^^^^^^^ could not find `defmt` in the list of imported crates
    |
    = note: this error originates in the derive macro `defmt::Format` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0433]: failed to resolve: could not find `defmt` in the list of imported crates
   --> embedded-hal/src/i2c.rs:304:41
    |
304 | #[cfg_attr(feature = "defmt-03", derive(defmt::Format))]
    |                                         ^^^^^^^^^^^^^ could not find `defmt` in the list of imported crates
    |
    = note: this error originates in the derive macro `defmt::Format` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing this crate through its public re-export
    |
164 + use crate::defmt;
    |

error[E0433]: failed to resolve: could not find `defmt` in the list of imported crates
   --> embedded-hal/src/i2c.rs:304:41
    |
304 | #[cfg_attr(feature = "defmt-03", derive(defmt::Format))]
    |                                         ^^^^^^^^^^^^^ could not find `defmt` in the list of imported crates
    |
    = note: this error originates in the derive macro `defmt::Format` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0433]: failed to resolve: could not find `defmt` in the list of imported crates
   --> embedded-hal/src/spi.rs:201:41
    |
201 | #[cfg_attr(feature = "defmt-03", derive(defmt::Format))]
    |                                         ^^^^^^^^^^^^^ could not find `defmt` in the list of imported crates
    |
    = note: this error originates in the derive macro `defmt::Format` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing this crate through its public re-export
    |
174 + use crate::defmt;
    |

error[E0433]: failed to resolve: could not find `defmt` in the list of imported crates
   --> embedded-hal/src/spi.rs:201:41
    |
201 | #[cfg_attr(feature = "defmt-03", derive(defmt::Format))]
    |                                         ^^^^^^^^^^^^^ could not find `defmt` in the list of imported crates
    |
    = note: this error originates in the derive macro `defmt::Format` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0433]: failed to resolve: could not find `defmt` in the list of imported crates
   --> embedded-hal/src/spi.rs:319:41
    |
319 | #[cfg_attr(feature = "defmt-03", derive(defmt::Format))]
    |                                         ^^^^^^^^^^^^^ could not find `defmt` in the list of imported crates
    |
    = note: this error originates in the derive macro `defmt::Format` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing this crate through its public re-export
    |
174 + use crate::defmt;
    |

error[E0433]: failed to resolve: could not find `defmt` in the list of imported crates
   --> embedded-hal/src/spi.rs:319:41
    |
319 | #[cfg_attr(feature = "defmt-03", derive(defmt::Format))]
    |                                         ^^^^^^^^^^^^^ could not find `defmt` in the list of imported crates
    |
    = note: this error originates in the derive macro `defmt::Format` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0433`.
error: could not compile `embedded-hal` (lib) due to 8 previous errors

This is run by the following Rust version :
cargo 1.79.0 (ffa9cf99a 2024-06-03)
release: 1.79.0
commit-hash: ffa9cf99a594e59032757403d4c780b46dc2c43a
commit-date: 2024-06-03
host: x86_64-unknown-linux-gnu
libgit2: 1.7.2 (sys:0.18.3 vendored)
libcurl: 8.6.0-DEV (sys:0.4.72+curl-8.6.0 vendored ssl:OpenSSL/1.1.1w)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: Arch Linux [64-bit]

Solution
I forked the repository and pushed a branch that successfully compiles embedded-hal and embedded-io in a standalone fashion. It is confirmed to work for our needs.
However, I know this could conflict with a previous discussion on PR https://github.com/rust-embedded/embedded-hal/pull/481.
What is happening in this case ?
Thanks for your help.

I cannot reproduce this
git[dirbaio@mercury ~]$ git clone https://github.com/rust-embedded/embedded-hal
Cloning into 'embedded-hal'...
remote: Enumerating objects: 4476, done.
remote: Counting objects: 100% (946/946), done.
remote: Compressing objects: 100% (221/221), done.
remote: Total 4476 (delta 781), reused 781 (delta 725), pack-reused 3530
Receiving objects: 100% (4476/4476), 1.49 MiB | 6.91 MiB/s, done.
Resolving deltas: 100% (2898/2898), done.
[dirbaio@mercury ~]$ cd embedded-hal
[dirbaio@mercury embedded-hal]$ cargo build --features defmt-03
(...)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.05s
[dirbaio@mercury embedded-hal]$ cd embedded-hal
[dirbaio@mercury embedded-hal]$ cargo build --features defmt-03
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.02s
[dirbaio@mercury embedded-hal]$
[dirbaio@mercury embedded-hal]$ cargo --version -v
cargo 1.79.0 (ffa9cf99a 2024-06-03)
release: 1.79.0
commit-hash: ffa9cf99a594e59032757403d4c780b46dc2c43a
commit-date: 2024-06-03
host: x86_64-unknown-linux-gnu
libgit2: 1.7.2 (sys:0.18.3 vendored)
libcurl: 8.6.0-DEV (sys:0.4.72+curl-8.6.0 vendored ssl:OpenSSL/1.1.1w)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: Arch Linux [64-bit]
[dirbaio@mercury embedded-hal]$ rustc --version -v
rustc 1.79.0 (129f3b996 2024-06-10)
binary: rustc
commit-hash: 129f3b9964af4d4a709d1383930ade12dfe7c081
commit-date: 2024-06-10
host: x86_64-unknown-linux-gnu
release: 1.79.0
LLVM version: 18.1.7

Perhaps you have an old Cargo.lock file somewhere, perhaps there's something wrong with your Rust installation so it's actually using an older rustc or something.

Same, it build fine for me. Both with and without the [patch.crates-io].

Ok, then I will create a clean Docker container and try reproducing it there. Thanks for your time.


Fix all dataflow tests and make them mandatory.

From @lbergelson on July 24, 2015 20:32
A number of the cloud and bucket tests are failing on google dataflow.  These need to be fixed.
#750 is a pre-requisite.
Once the tests are fixed we should make these tests mandatory.
Copied from original issue: broadinstitute/hellbender#751

From @jean-philippe-martin on August 6, 2015 22:27
As @droazen was saying in #656 16 days ago, this is becoming urgent.
It appears this problem has prevented us from noticing a big regression in the Hellbender code that broke  BaseRecalibratorDataflow (possibly because it broke the BAM reader)

From @jean-philippe-martin on August 13, 2015 23:37
I just tried gradle testAll on the master branch and I see RefAPISourceUnitTest failing.
These regressions make progress a lot harder, and unfairly shift effort from those not writing cloud code to those who are.
What I suggest we do is that instead of having just "bucket" and "cloud" groups, we split into "bucket", "cloud", "bucket_todo" and "cloud_todo".
We make "bucket" and "cloud" mandatory right now.
The tests that don't pass, we move to the "_todo" categories. This way the tests that work now will keep on working - otherwise we'll never get out of this mess. Then we can track the number of _todo tests left and make sure they go down.

From @jean-philippe-martin on August 17, 2015 17:31
#823 is making good progress in this direction.

From @jean-philippe-martin on August 17, 2015 17:33
With #825 we're now at 12 passing cloud tests (mandatory), and 7 todos.


The market view seems to count liquidity providers as traders

After creating a market, the trader count is 1, which seems wrong. No big deal, but now that we also have a list of trades happening on the market, I think it a bit confusing: The market shows two traders, but only one trade.

Querying traders instead of participants should resolve this @Robiquet @robhyrk


Wrong view height or position when sharing internet connection

Selection count view bottom is not on window bottom when sharing internet connection.

@tomoyuki28jp Thanks for reporting.

@chiunam Confirmed this issue has been fixed. Thanks!


[Not a Bug] A good library, but can it be combined with the Alfred library?

Your library is good because it uses the flutter style, but can it be combined with the ALFRED library?

Thanks. Can you clarify what you mean by "combine"?
As far as I know, you can connect your Navand frontend app to any backend framework, just like a create-react-app.

Closing the issue since it has been inactive. Feel free to reopen it.


fix the scrolling problem

fix the scrolling problem in IOS13.4 webview
added default description of better-scroll parameter
better-scroll #978

Codecov Report

Merging #695 into dev will decrease coverage by 0.45%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##              dev     #695      +/-   ##
==========================================
- Coverage   92.79%   92.34%   -0.46%
==========================================
  Files         141      141
  Lines        3083     3110      +27
  Branches      501      510       +9
==========================================
+ Hits         2861     2872      +11
- Misses        116      129      +13
- Partials      106      109       +3

Impacted Files
Coverage Δ

src/components/picker/picker.vue
76.86% <38.88%> (-6.05%)
:arrow_down:

src/components/scroll/scroll.vue
90.00% <58.33%> (-1.91%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada7650...bfcc367. Read the comment docs.


Allow GDS Editors to see and edit other organisations' manuals

Access is normally limited to Manuals owned by the current user's organisation. So that GDS Editors can support other departmental content editors, without having to change their own organisation temporarily in Signon, we treat a GDS Editor as a special case with access to all Manuals.
These changes do not allow a GDS Editor to create a Manual on behalf of another organisation, only to access existing Manuals and to create GDS Manuals.
It might make more sense to abstract the explicit use of current_user_is_gds_editor? here into a new or existing dedicated object/config for permissions logic. Suggestions would be very welcome.
I think the changes made to the various ServiceRegistries here really draw attention to the increasing duplication and need for refactoring. Again, suggestions would be excellent there as well.

Maybe I'm picking nits, but the PR title keeps confusing me - would you mind rewording it to be proper English and stuff?

@jennyd and @issyl0, I've made the changes you suggested, thanks.
I've also refactored the Manual and ManualDocument service registries to remove the duplication that was upsetting everyone. (And tried to explain my design decisions in those commit messages.)

Thanks for dealing with those comments and other things we discussed.


plansys2_tools is not in CI && does not compile in Foxy

As stated in the title, tests for plansys2_tools are currently not run by CI and should be added to the GitHub workflows.
rclcpp::Logger::set_level (on line 57 of LoggerNode.cpp) was added in Galactic and is thus unavailable in Foxy.  Also, using std::setprecision without including the <iomanip> header seems to work in Galactic but not in Foxy (due to C++XX version?).
@fmrico would you consider removing/changing these two lines of code since it's they're the only thing keeping the package from building in Foxy?  While I understand if master is supposed to be the latest and greatest, it does seem like a bit of a shame to break compilation for a whole distro based on such a small change (especially given that the foxy-devel branch tends to lag a bit behind).

Hi @sarcasticnature
Since #144, the main branch points to Galactic. Indeed, I am thinking of opening a discussion about point to Rolling instead.
No new features will be available in Foxy. foxy-devel should only receive bug fixes.
Best

Understandable.  The issue regarding CI stands, however

looks like it was fixed in one of your recent PRs, closing

Yes!! After you warn me, I included it in the last PRs. Thanks 😉


doc: Update Try-it page based on the v1beta1 release

Update the Try-it.md to include the changes from release v1beta1.
The session 2.5 Running custom CAPM3 is not finished, since the
make run command is deprecated.

/assign @hardys

Also I would keep code blocks as shell format instead of console. They look a bit different in the preview website: https://deploy-preview-224--metal3.netlify.app/try-it.html

Also I would keep code blocks as shell format instead of console. They look a bit different in the preview website: https://deploy-preview-224--metal3.netlify.app/try-it.html

But shell gives correct syntax highlighting when the prompt is included. Then it knows what is output (no syntax highlighting) and what is the command (with syntax highlighting).
There is one part of the page where console is used wrong though: https://github.com/metal3-io/metal3-io.github.io/blob/f1fcf31f378814901ae622ec829032e31c0d3f23/try-it.md?plain=1#L434-L451
Here the comments (starting with #) are treated as root prompt. ($ is normal user prompt, # is root). If we want these highlighted as comments they should have the prompt in front ($ # Comment here) or we switch that block to shell.
I vote for putting the prompt before the comment. Then it is obvious what part is output and what is input. :slightly_smiling_face:

I updated the code blocks part using console, and improved the comments lines in the block, please check whether that looks better or not.
Also I added a brief introduction part for Tilt, please check that all the information is correct or not.

/hold
@ren-yifei can you please squash commits before we merge it?

/retitle 📖 Update Try-it page based on the v1beta1 API

/lgtm

/assign @hroyrh

/hold cancel
/assign @knowncitizen @hroyrh @hardys


Add Rust Binding

As a user of this library i would like to consume it from rust

This will need to be reviewed with the spec for 2.0 to make sure what bindings are needed.

Possible alternative approach: rewrite the core in Rust (on top of HACL), and export C++ bindings.


When you add words. They don't update on the screen.

This screenie should tell the whole story:

I've had this problem since months ago. So I thought why not mentioning it

Thank you.  It is clearly not working as you would expect.
Can you give me a bit more information about your setup?
Which version of VS Code are you running?
Which version of the cSpell plugin are you using?
Which OS version are you on?
Do you have a single file open or a folder?

Okay this is my full settings:
{
	"editor.fontSize": 				13,
	"editor.lineHeight":            26,
	"editor.fontFamily":            "Hasklig-Medium",
	"editor.tabSize": 				4,
	"editor.wrappingColumn": 		90,
	"editor.wrappingIndent":        "same",
	"editor.quickSuggestionsDelay": 0,
	"editor.renderWhitespace": 		false,
	"editor.insertSpaces": 			true,
	"cSpell.enabledLanguageIds": [
		"csharp",
		"javascript",
		"javascriptreact",
		"markdown",
		"plaintext",
		"text",
		"typescript",
		"yml",
		"ruby",
		"pageman",
		"html"
	],
	"cSpell.userWords": [
		"Pouya",
		"Kary",
		"karyfoundation",
		"Arendelle",
		"arendelle",
		"pouya",
		"kary",
		"intactus",
		"calculat",
		"hedron",
		"gerda",
		"levitator",
		"Pageman"
	]
}

And well I use macOS El Capitan with the latest version of both vscode and cSpell. Most of the projects are on github. you may check kf's org. all of the TypeScript, JavaScript projects are done with cSpell

Have you tried closing all your VS Code windows and checking the Activity Monitor to make sure all VS  Code instances have stopped?

Please try updating the spell checker to the latest version.

Oh thank you! It's fixed and very cool now!
Thanks a lot for the great tool! Having a spell checker for me is something really really cool!!


Enhancement in mlkit face detection sample app for drawing bitmaps over landmarks

Enhancement for reported issue: #800
New clown nose resource used from here:
http://quidditch.wikia.com/wiki/File:500px-Red_sphere_shaded_lightsource_top_right.svg.png
... please let me know if this could have copyright issues and I will use a different one.
Result of new implementation:

@samtstern please take a look over this when you have some time ;)
Cheers,
Marian.

Added fixes for CLA

@MarianIacob thanks for this!  Just a few small comments.

@MarianIacob thank you!

@samtstern you are very welcome! Glad I could contribute ;)

landmark is too slow


Can multiple formulas be specified

Are you allowed to test multiple formulas? or what is a way to do so without rerunning everything?

Nevermind, I just found run_corncob.nf which appears to do just that.


Gssoc2024|contributor

Assign me this project

Thank you for your response.
On Tue, May 14, 2024, 23:15 github-actions[bot] @.***>
wrote:

Hey @Curleysherl https://github.com/Curleysherl, Welcome to the project
Beautiify! 🎊
Thanks for opening an issue! 🙌 Please wait for the issue to be assigned.
Happy Coding!! ✨
—
Reply to this email directly, view it on GitHub
https://github.com/Rakesh9100/Beautiify/issues/732#issuecomment-2110790519,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGS4UCL7GG2RNADUOPZK7C3ZCJEUHAVCNFSM6AAAAABHWUK5MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQG44TANJRHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


[freetype] Disabled Harfbuzz check for non-Windows platforms

What does your PR fix?
Fixes issue #10041
Resolves linking errors when building on Linux-based platforms

Which triplets are supported/not supported? Have you updated the CI baseline?
No change.

Does your PR follow the maintainer guide?
I think so.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: capnkenny sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

The failures doesn't related to this changes, I will help  rerun after the baseline issue fixed.

/azp run

Cool, thanks @capnkenny :)


Trunk Based Development ci-cd.yml

Context and Justification 🌍

Modifications 🔧

Contribution Checklist 📋

[x] Have you used this PR template?   +2 pts
[x] Is this PR focused on a single, clearly defined change?   +5 pts
[ ] Have you linked the issue(s) this PR resolves?   +5 pts
[x] Are your changes well-documented and easy to follow?   +5 pts
[ ] Have you introduced a new feature?   -4 pts

[x] Have you updated/added relevant documentation for it?   +4 pts
[x] Have you included tests to ensure it works as expected?   +5 pts

[ ] Did you alter any core behavior of data-river?   -5 pts

[ ] Have you tested the changes thoroughly, ensuring no regressions?   +10 pts

Can you add into the description what is the justification for these changes ?
We already yaml files for the master branch, so i dont understand why we need an extra one ◡̈

PR Should point to development ◡̈ Only once merged and deployment on development tag works + tests etc, it should be merged to master

Hi @mmonteiroc @BryanSky thanks for the review

Feature branches run tests and checks but don’t deploy.
Main branch merges trigger Docker builds and push to Docker Hub.

Let me know if any other improvements are needed

@DhanushNehru
I think we are still talking a bit in circles 😄  there is multiple docker files for multiple packages. Given this is a monorepo.
client:
https://github.com/softflow24/data-river/blob/main/packages/client/Dockerfile
landing-page:
https://github.com/softflow24/data-river/blob/main/packages/www/Dockerfile
mapping to
data-river.app/
and
data-river.dev/

Hi @mmonteiroc @BryanSky thanks for the review

Feature branches run tests and checks but don’t deploy.
Main branch merges trigger Docker builds and push to Docker Hub.

Let me know if any other improvements are needed

I would propose that for easieness of maintenance, we have you yml files
prod.yml which contians the logic of master branch
feature.yml which contains the logic of feature branches
For tasks re-used, I would propose you re-use them in templates yml files as we already have (check the .github/actions folder)

Hi @mmonteiroc @BryanSky thanks for the review

Feature branches run tests and checks but don’t deploy.
Main branch merges trigger Docker builds and push to Docker Hub.

Let me know if any other improvements are needed

I would propose that for easieness of maintenance, we have you yml files
prod.yml which contians the logic of master branch feature.yml which contains the logic of feature branches
For tasks re-used, I would propose you re-use them in templates yml files as we already have (check the .github/actions folder)

Let's do that next pr :)


Use dep as the dependency manager

Makefile is a convenience feature - you can run commands like make docker/build after writing them once inside the Makefile. It's also very useful for new users who don't quite know where to begin.

This is great!
I tried using dep for managing Go packages. However, it seemed to me that Heroku doesn't yet support it. Hence, I reverted to godep.

@kshitij10496 Oh! Didn't know that. Feel free to just reject this PR in that case (been developing with Docker and Kubernetes lately, so I didn't consider Heroku support.
A cursory look at the Heroku page for support seems to show that dep is supported through the community. here. Since this is a basic setup in this application, we shouldn't run into any problems. You can consider using it. 🙂

A cursory look at the Heroku page for support seems to show that dep is supported through the community. here. Since this is a basic setup in this application, we shouldn't run into any problems. You can consider using it.

Awesome! Let's give dep a try. 🎉
Let me know if this branch is ready for testing and deployment. 😄

@kshitij10496 Cool! I will update my branch to the latest master and put these changes in and ping again. 🙂

@kshitij10496 It's fine to merge now. I just did dep ensure -v after rebasing to the latest master.

dep is live! 🕶 :party_parrot:
I just had to add some metadata in Gopkg.toml in order to get it working.
Refer: Build Configuration


Creating launch for web or console.

It is a web application if it has any dependencies on microsoft.aspnetcore.server.*

@DustinCampbell @gregg-miskelly @chuckries @caslan

👍

:+1:

Merged into dev.
https://github.com/OmniSharp/omnisharp-vscode/pull/360