[docs] PropTypes.oneOf properties don't render correctly

Problem description
PropTypes.oneOf properties seem to break the template in the documentation for version v.0.17.4
Image

Link that reproduces the issue
http://www.material-ui.com/v0.17.4/#/components/menu
http://www.material-ui.com/v0.17.4/#/components/chip
http://www.material-ui.com/v0.17.4/#/components/drawer
...etc
Versions

Material-UI: v0.17.4

The regression was introduced by #6577.

Upgrading react-docgen to 2.13.0 should be enough.

@oliviertassinari I'm running 2.13.0 but I still see the error on my local installation.
$ npm ls react-docgen
├──<EMAIL_ADDRESS>

Upgrading to 2.14.0 did solve the issue for me.

I would have pushed an update for the docs site, but we have a blocking issue building with npm run browser:build - webpack.optimize.UglifyJsPlugin doesn't like something about the updated react-docgen...

I will give a shoot at publishing the new version

Done

This appears to be broken again in the v4.12.1 docs. For example, the now deprecated collapsedHeight is rendered as oneOfType([PropTypes.number

@LiteracyFanatic See #27191


#646 Kultiras quest refactor and rework

Removed second chance for Kul'Tiras in QuestUnlockShip.
Removed Kul'Tiras related code in Zandalar Quests.
Removed QuestJoinCrusade
Changed Kul Tiras QuestUnlockShip to now require capturing control points on Kul Tiras.  The flavour is to renuite the kingdom and get rid of all the threats on the islands.
Adjusted Kul'Tiras intro text to accomodate these changes.

Note that Daelin Proudmoore still has the Join the Crusade ability.
This should be removed.


Not able to add new movie or tv show

Bot is running and it is able to access sonarr and radarr instance but I'm not able to add new movie or tv shows.  Bot is sending Successfully added moviename! but nothing in client.
I enabled debug logging in docker container but nothing in log I'm checking using docker logs <container_id>
I tried to run without docker and still same issue.

Working now. I had url base setting enabled in sonarr and radarr.
just had to include /sonarr and /radarr in settings.py
cant believe I spent last few hours fixing this.


Anticipating message from a Stream

I have a suggestion for the library, to ease reading from streams with a timeout. A Timer::anticipate method will take a Stream and a Duration, returning a future.

Ok: If a stream item arrives within the timeout it will emit the item and the stream for later use.
Err: If the timeout passes without a message it will return a TimeoutError and the stream for later use.

StreamFuture::Error = (S::Error, S) does return the stream if there's an error. Wrapping this with Timer::timeout requires conversion of TimeoutError into (S::Error, S). That's not natural and forces discarding the stream if the timeout passes. In this usecase a timeout shouldn't be an error: we may want to still use the stream later.
I'm not entirely sure what to do about a stream closing (Async::Ready(None)). StreamFuture does Ok(Async::Ready(None, stream)) but this would make the stream closing and the timeout being reached indistinguishable. My implementation converts stream closed into a TimeoutError::StreamClosed for now.
Given the ephemerality of the chatroom I wasn't sure where best to discuss this besides a full issue.

Hey, I made a bunch of changes. Does Timer::timeout_stream satisfy your needs?
I also changed TimeoutError to include the underlying future / stream, so you shouldn't be forced to lose it if the timeout is hit.

That looks lovely. I considered such a timeouting stream but was concerned it would be implementing a stream which gets one message each duration rather than something more flexible. But it looks like I can into_inner when no longer anticipating a message then reconstruct a TimeoutStream when I am again? I think I've learned something about design here.

Yep, exactly. I'll close this issue for now. Feel free to open another later.


not posting to youtube?

For some reason I get everything from youtube to discord, but nothing comes back to youtube to post into that chat. Any idea why? I'm thinking it might be the servername in the config maybe?

Ya I never got to implementing that. I will look into it more when I get time. Life got in the way. I should possibly look into it again shortly. Sorry about that

That would be a problem with the coding on my end. I never learned that part of the api. Well never successfully learned it anyways. It was something due to when i get the access key portion i didnt get read write access i only got read so it wouldn't let me add messages.

#1 Duplicate of that issue there.

I'm going to close the issue as i had one there from the beginning.


Complementary Filter Rework, TransferFunction and frequency_series upgrade

Make kontrol.core.transfer_function.TransferFunction a base class of kontrol.core.complementary_filter.complementary_filter.ComplementaryFilter so complementary objects are systems with two inputs and one output.
This means TransferFunction should add support for MIMO systems.
Original noise fitting functions have all been migrated to kontrol.core.frequency_series.
FrequencySeries should support transfer function identification as well.

kontrol.frequency_series is deprecated.
kontrol.ComplementaryFilter is now a child of kontrol.TransferFunction.
But kontrol.TransferFunction still doesn't support MIMO, but that's fine for now.


Added HtmlReporting

I thought this could use an HTML Reporting object. This is a first pass based completely off of the CSV Reporting

Following the same example as the CSV:
[Test]
public void CsvReportTest()
{
	string expected = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "movie.csv");

	if (File.Exists(expected))
		File.Delete(expected);

	Movie movie1 = new Movie();
	movie1.Name = "Oblivion";
	movie1.PaymentForTomCruise = 2000000M;

	Movie movie2 = new Movie();
	movie2.Name = "Edge of Tomorrow";
	movie2.PaymentForTomCruise = 3000000M;

	CompareLogic compareLogic = new CompareLogic();
	compareLogic.Config.MaxDifferences = Int32.MaxValue;
	ComparisonResult result = compareLogic.Compare(movie1, movie2);

	HtmlReport htmlReport = new HtmlReport();
        // The config object is to overwrite the defaults
        htmlReport.Config.GenerateFullHtml = true; // if false, it will only generate an html table
        htmlReport.Config.HtmlTitle = "My Cool Report";
        htmlReport.Config.BreadCrumbColumName = "Field Name"; // name things as you want
        htmlReport.Config.ExpectedColumnName = "Existing";
        htmlReport.Config.ActualColumnName = "Replacing";
        html.Config.IncludeCustomCSS(".diff-crumb {background: gray;}"); // add some custom css
	htmlReport.OutputFile(result.Differences, expected);

	Assert.IsTrue(File.Exists(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, expected)));

	csvReport.LaunchApplication(expected);
}

CSS Class Names:
diff-table - the table object
diff-crumb - the bread crumb column
diff-expected - the expected column
diff-actual - the actual column

Thanks so much @kenwilcox !


[Toothpick] Device support form

Extension – Toothpick
Device brand and model
Sony WH-1000XM4 Wireless Noise Canceling Over-the-Ear Headphone
Device data
{"WH-1000XM4":{"device_address":"F8:4E:17:44:7E:39","device_batteryLevelMain":"100%","device_firmwareVersion":"2.5.0","device_minorType":"Headset","device_productID":"0x0D58","device_services":"0x800019 < HFP AVRCP A2DP ACL >","device_vendorID":"0x054C","device_connected":"true"}}

Hey! Thanks for this submission. So, this device is mapped in the latest version but to explain the current situation a bit...
The BlueTooth api we have access to is kinda limited.
Some devices share battery levels along with the rest of the device's metadata, in which case we display them.
Otherwise, if the device sends the battery level via other methods, we have no current way to fetch them.
Sadly, for WH-1000XM4, the case is the latter.
I have a companion app planned, kind of like a bridge that would give this extension access to more functionalities, like fetching battery levels, toggling ANC, etc. But for now it's just that. A plan.
Either way, any submission is helpful and appreciated. Have a nice day! 🌻

@raycastbot close this issue


fix(audit-ci): Remove redundant -c flag

The -h flag ensures that any high or critical CVEs exit with code >=1.

Note: this is one of two concurrent pull requests for audit-ci. Only one should be accepted depending on the desired behaviour of the dependency since the solutions are mutually exclusive.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: quinnturner sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Cleanup domains after integration test

At the end of an integration test, soft-delete the domain and the corresponding Trillian trees.
TODO:

Run doman and tree garbage collection.

Can we downgrade code coverage severity so it doesn't look like the build has failed?

The code coverage warning is just making sure that code coverage doesn't diminish. So while I agree that it is annoying, I like having it to motivate more code coverage :-)

The code coverage thing is going to delay reviews because people will assume the build isn't working. I think it's a bad idea to make it fail the overall status.


Cache migration

Rebased on top of both https://github.com/tarides/ocaml-platform-installer/pull/135 and https://github.com/tarides/ocaml-platform-installer/pull/136 (must be rebased and merged last)
Fix https://github.com/tarides/ocaml-platform-installer/issues/131
This adds a mechanism to migrate the cache after the tool is upgraded. The cache has an incrementing version number written to it, which is checked before doing anything with it.
TODO:

[x] Test. I'm considering adding cram tests, which need some work to run quickly.
[x] Migration for https://github.com/tarides/ocaml-platform-installer/pull/134
[x] Rebase

I added a test, which will normally fail until we rebase on #134 (currently we do the migration but do not know how to use the new repo structure...)

It is rebased and CI is green: ready for review!

I think that while this cache migration is not the most important, later cache migration will be required.
Since it is only for few users, it hopefully won't require that much maintenance, will avoid losing users out of frustration, and be a good practice for later migration function.
(Note that I know we might lose users with frustration if the migration cache does not work as well)

I agree that migration is something we should have. I'm considering whether this specific migration is useful.
Is it enough to rename the packages after https://github.com/tarides/ocaml-platform-installer/pull/134 ?

I don't remember if it is important to replace all occurrences of the old string.

This is a sign that we are writing bugs. I'm not confident in writing such code without better, faster tests (https://github.com/tarides/ocaml-platform-installer/issues/143), which are also not something we can do before the planned release.

I added a missing migration. I'll merge when the CI is green.


Fix PowerMock related tests due to version bump

Description
2.2 core added new dependencies of ClusterSettings like TaskResourceTrackingService. It is possible that the classloader that loads TaskResourceTrackingService is different from the classloader that loads PowerMock and related dependencies. PowerMock reports java.lang.NoClassDefFoundError when initializing ClusterSettings. Since we are not actually using the value of ClusterSettings in the tests, we make it null to avoid initializing it. The change fixed failed tests.
This PR also fixed spotless errors in FakeNode due to recent changes.
Testing done:

gradle build

Signed-off-by: Kaituo Li<EMAIL_ADDRESS>Issues Resolved
https://github.com/opensearch-project/anomaly-detection/issues/630
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #637 (1aa3c79) into main (f630c8f) will decrease coverage by 0.22%.
The diff coverage is 82.35%.

@@             Coverage Diff              @@
##               main     #637      +/-   ##
============================================
- Coverage     79.07%   78.85%   -0.23%
- Complexity     4213     4228      +15
============================================
  Files           296      301       +5
  Lines         17686    17871     +185
  Branches       1880     1897      +17
============================================
+ Hits          13986    14092     +106
- Misses         2805     2875      +70
- Partials        895      904       +9

Flag
Coverage Δ

plugin
78.85% <82.35%> (-0.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...opensearch/ad/ratelimit/CheckpointWriteWorker.java
91.25% <0.00%> (-2.58%)
:arrow_down:

...nsearch/ad/ratelimit/RateLimitedRequestWorker.java
71.22% <0.00%> (-0.34%)
:arrow_down:

...search/ad/cluster/ClusterManagerEventListener.java
78.72% <20.00%> (-15.88%)
:arrow_down:

.../org/opensearch/ad/feature/CompositeRetriever.java
81.45% <41.66%> (-3.04%)
:arrow_down:

...nsearch/ad/transport/RCFResultTransportAction.java
85.18% <61.53%> (-0.87%)
:arrow_down:

.../java/org/opensearch/ad/caching/PriorityCache.java
69.38% <65.71%> (-0.87%)
:arrow_down:

...rch/ad/transport/AnomalyResultTransportAction.java
79.95% <66.66%> (-0.87%)
:arrow_down:

...in/java/org/opensearch/ad/caching/CacheBuffer.java
77.69% <75.00%> (-1.17%)
:arrow_down:

.../org/opensearch/ad/ratelimit/ColdEntityWorker.java
90.90% <80.00%> (-4.55%)
:arrow_down:

...rc/main/java/org/opensearch/ad/util/DateUtils.java
80.00% <80.00%> (ø)

... and 28 more


WMStats wrong columns-percentages (progress view)

While validating cmsweb-testbed (1.0.5.pre7 services), I notice WMStats is mistakenly calculating a few of those columns, like:

queue injection
event progress
lumi progress
Estimated Completion

One can see it does not happen only to TaskChain, which is quite hard to calculate these stuff. But also ReDigi and ReReco.
Attaching a picture since it's worth 1000 words :-)

Of course this is not a big deal since nobody is looking at these numbers at the moment, AFAIK :-)
So low prio

It seems the reason for these crazy numbers were coming from this issue #5723 , which seems to have been solved now. Closing this one


Download GIFs with Glide and Set Download Location

Allow Glide to handle GIF downloading instead of using URLConnection. Allow the user to set a download location instead of defaulting to app internal file directory.

The ReadMe should probably be updated to mention that it is up to the developer to manage downloaded GIFs. In the current implementation, GIFs are downloaded and then stored FOREVER which is probably not the desired result. The developer needs to take care of managing storage as this library only downloads and returns the GIF URI.

Feature added in PR #1


Vulnerability roundup 93: php-7.2.32: 1 advisory [3.6]

search, files

[ ] CVE-2020-7068 CVSSv3=3.6 (nixos-20.03)

Scanned versions: nixos-20.03: 0d0660fde3b.
Cc @etu
Cc @globin

See also: #93253

20.03 is Frozen and EOL.
As such, issue is closed.


run examples/httpPlusdb, but did not grab sql statement

Describe the bug
A clear and concise description of what the bug is.
Environment

OS: Linux hecs-402688 5.10.0-<IP_ADDRESS>.r865_35.hce2.x86_64 #1 SMP Sun Mar 26 18:01:01 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Go Version: v1.21.3
Version: main

To Reproduce
Steps to reproduce the behavior:

run jaeger v1.35.0
run opentelemetry-collector v0.42
run opentelemetry-go-instrumentation-main main
run examples/httpPlusdb

Expected behavior
From examples/httpPlusdb/http_Db_traces.jpg, it will grab sql statement. But I did not get sql statement. Can you help me?
Additional context

Can you please double check that you have OTEL_GO_AUTO_INCLUDE_DB_STATEMENT=true in the docker compose file?
If it is set correctly and you still can't see the query, please send the logs of the go-auto-instrumentation image.

@RonFed thanks for the clue. I had to dive into code so as to find it. This collector seems to be scarcely documented

It looks like https://github.com/open-telemetry/opentelemetry-go-instrumentation/issues/521#issuecomment-1822428522 resolves this. Closing.


Simplify header handling

Not a problem to remove the String stuff, but the strlcpy() calls are very important.  if we merged this, it would cause the same bug as before when the headers were cleared prematurely.
esp-idf does not store a copy of the headers when you call the function to add a header, instead it just stores the pointer.  you have to ensure that the header string sticks around until after the header is sent.

but the strlcpy() calls are very important

That's exactly the point of using String ;-) It does not store a pointer to the passed char* but copies the string in a new object held into the struct. in a list. So the structure with the allocated memory for the String object content stays in the list and won't go away.


Reorder final save items to fix olmo saving

I did a little messing around and this seemed to make olmo saving work. Not sure why because I was unable to trace the processes to see the locations of hangs (this is a beaker issue, see https://github.com/allenai/reconfig/issues/2337).
I tested and this didn't break llama 2 7b saving.
Should fix #123.

I'll try running a job now and see if it works.

OK, it works.
Does it need someone to give an official review before you can merge (I can do this) or can you just merge it in?

If you could review and then I can merge that'd be great 🙏


.Net Core Console App

This is a change to the start-migrations script so it will run the "dotnet" command on the dll output that you get when DBUP is hosted in a .Net Core Console App.

Thanks!

Release as 1.5.0 on NuGet: https://www.nuget.org/packages/dbup-consolescripts/1.5.0


Create appiuminspector.sh

Apium Desktop is unsecure and should not be included.

@Theile This label is not working because the downloaded .app is not notarized. Please reach out to the developer, and/or close this PR.


API keys page going to error page

Rancher versions: 2.0 master 1/21
Steps to Reproduce:

Create a cluster
Go to Project/Resources/API keys

Results: Error page comes up - Unable to find schema for "apikey"

Version - 2.0 master 2/21
Verified fixed


remove undefined exports from exportExecution result

How to categorize this PR?

/kind bug
/priority 3
What this PR does / why we need it:
Exports that are not defined by the blueprint are now removed from the templating result.
Special notes for your reviewer:
Release note:

Exports that are not defined by the blueprint are now removed from the templating result.
Be aware that this might break blueprint that export data which is not defined.

/invite @reshnm

/test


[osgearth] Add draco feature

Describe the pull request

What does your PR fix? Fixes #13381

Add draco for osgearth. Since gdal is required dependency of osgearth 3.1, which has been included in osg[plugins].
So, it's unnecessary to add gdal as a feature.
Note: Feature has passed with x64-windows.
osgearth only supports dynamic build.

Closing this PR Temporarily.


[Feature Request] More in-depth custom dimension configuration/customization

Currently, custom dimensions are just copies of existing dimensions. You can change a bit using the json, but nothing much significant. If possible, more in-depth configurations for things such as skylight, mob spawning, fog, even skyboxes, would be helpful. I'm unsure of how much of this is actually possible or even within the scope of the mod, though.

The skylight and mob spawning is determined by dimension type. You can add new dimension types via datapack.
The fog is determined by biome. You can add new biomes via datapack.
About skybox, as far as I know vanilla does not allow customizing skybox via datapacks, but you can search for other mods that customizes skybox.


(dataset): change opensource dataset

Description
change opensource datasets according to refactor(dataset): take equal treatment to dataset data and annotation
Modules

[ ] UI
[ ] Controller
[ ] Agent
[ ] Client
[ ] Python-SDK
[ ] Others

Checklist

[ ] run code format and lint check
[ ] add unit test
[ ] add necessary doc

all dataset tested


deps: regenerating with new Protobuf (v2.6.x)

To merge into v2.6.x branch. This PR was generated using Protobuf 3.19.6. Source-Link: https://github.com/googleapis/googleapis/commit/6cce671cb21e5ba9ee785dfe50f5a86b87bb5f21

OwlBot is failing trying to create a workflow in my branch.
Step #8: Error: Command failed: git push --no-verify
Step #8: To https://github.com/suztomo/java-bigtable.git
Step #8:  ! [remote rejected] v2.6.x_patch -> v2.6.x_patch (refusing to allow a GitHub App to create or update workflow `.github/workflows/ci.yaml` without `workflows` permission)

@suztomo The GraalVM  tests are failing, is it expected ?

Yes

OwlBot fails becuase it tries to change workflow in my branch. Templated workflow is not needed for v2.6.x branch.
Error: Command failed: git push --no-verify
To https://github.com/suztomo/java-bigtable.git
 ! [remote rejected] v2.6.x_patch -> v2.6.x_patch (refusing to allow a GitHub App to create or update workflow `.github/workflows/ci.yaml` without `workflows` permission)
error: failed to push some refs to 'https://github.com/suztomo/java-bigtable.git'


Parsing compiler flags which takes options in form of list

@jramsay  @zhengbli Let me know if you have any comment :)

looks good to me.

Other than the minor comments, it looks good to me. :+1:


Solution must be simply called Zipkin

Like all other Open Source solutions, the root solution must be simple when encompassing large collection of projects (soon to be big).
Also Tracer, is not a zipkin concept.

Tracer is a type that's used in most zipkin projects, describing the core library used to create instrumentation.
Ex from http://zipkin.io/pages/architecture.html

Tracers live in your applications and record timing and metadata about operations that took place. They often instrument libraries, so that their use is transparent to users. For example, an instrumented web server records when it received a request and when it sent a response. The trace data collected is called a Span.

Not all tracers repositories are multi-module or cover aspects beyond the tracer. The more code added, the more responsibility on the collaborators, as there's more things to break.
That said, both zipkin-js and brave include both core tracer library and also some highly reused instrumentation
https://github.com/openzipkin/zipkin-js
Intro aside, maybe propose what projects you are expecting to be here?
PS very few people are watching this repo, so they won't see your issue. I'm cc'ing folks who last contributed to discussion on the fate of this repository in #11
cc @jcarres-mdsol @haf @bvillanueva-mdsol @johnberzy-bazinga @lschreck-mdsol

also cc @rogeralsing who opened up other issues here

@adriancole This library is not a tracer. It is the core library implementing core concepts. Hence the naming.

closed via 724ce0e


WeBASE-Front.log [main] ERROR SpringApplication() - Application startup failed

fisco-bcos@fiscobcos-VirtualBox:~/webase-deploy$ python deploy.py startAll
check WeBASE-Web port...
check finished sucessfully.
check WeBASE-Node-Manager port...
check finished sucessfully.
check WeBASE-Sign port...
check finished sucessfully.
check WeBASE-Front port...
check finished sucessfully.
==============      FISCO-BCOS      start...  ==============
try to start node_<IP_ADDRESS>_30300
node_<IP_ADDRESS>_30300 start successfully
==============      FISCO-BCOS      end...    ==============
==============      WeBASE-Web      start...  ==============
=======      WeBASE-Web     start success!  =======
==============      WeBASE-Web      end...    ==============
============== WeBASE-Node-Manager  start...  ==============
======= WeBASE-Node-Manager  starting . Please check through the log file (default path:./webase-node-mgr/log/). =======
============== WeBASE-Node-Manager  end...    ==============
============== WeBASE-Sign  start...  ==============
======= WeBASE-Sign starting. Please check through the log file (default path:./webase-sign/log/). =======
============== WeBASE-Sign  end...    ==============
==============     WeBASE-Front     start...  ==============
=======     WeBASE-Front    starting .  Please check through the log file (default path:./webase-front/log/).    =======
==============     WeBASE-Front     end...    ==============
fisco-bcos@fiscobcos-VirtualBox:~/webase-deploy$ cd webase-front/
fisco-bcos@fiscobcos-VirtualBox:~/webase-deploy/webase-front$ grep "ERROR" log/WeBASE-Front.log
2022-10-25 20:08:52.862 [main] ERROR SpringApplication() - Application startup failed
2022-10-25 21:11:35.464 [main] ERROR SpringApplication() - Application startup failed

How can I fix this 'SpringApplication() - Application startup failed' error?
I have tried stopAll and startAll several times.


Unable to execute any commands on MongoDB

Using a MongoDB database created with the Flynn CLI, any operation on the database (via the MongoDB shell or in-app) results in the error "not authorized on admin to execute command". For example:
$ flynn mongodb mongo
MongoDB shell version: 3.2.11

rs0:PRIMARY> show dbs
2018-08-29T12:19:00.491+0000 E QUERY    [thread1] Error: listDatabases failed:{
	"ok" : 0,
	"errmsg" : "not authorized on admin to execute command { listDatabases: 1.0 }",
	"code" : 13
} :

This is using the latest version of Flynn as of 2018-08-28, creating a MongoDB database using the Flynn CLI as per the docs. The stack is running on a 3-node Ubuntu 16.04 cluster, running on DigitalOcean.
The app in question uses PostgreSQL, Redis and MongoDB, so the DATABASE_URL environment variable is now set to PostgreSQL, as MongoDB isn't the primary database for the app. Doubt that makes a difference, but thought I'd mention it. I've not done any kind of provisioning or dump/restore on the database... this is literally the first thing I've tried to do on the db, but not a single action will run.
Looking forward to using Flynn in production as soon as MongoDB is fixed.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


ghc-mod not currently compatible with Cabal 1.22

https://github.com/kazu-yamamoto/ghc-mod/issues/417
Currently in haskellng cabal-install is v1.22 , this means if a project folder has the files created by cabal configure, ghc-mod will not work due to a bug. Perhaps the default version of cabal-install should be 1.20  until this is fixed ? I didn't find a way to specify a previous version of cabal-install in the shell.nix using the new haskellng syntax without camel case.

My understanding is that ghc-mod doesn't care what version of cabal-install is used; what matters is the version of Cabal. IMHO, a simple fix should be to run cabal configure --cabal-lib-version=<IP_ADDRESS> to force use of the native version.

if I do that, then when I do 'cabal build' I get
cabal build
cabal: You need to re-run the 'configure' command. The version of Cabal being used has changed (was Cabal-<IP_ADDRESS>, now Cabal-<IP_ADDRESS>)

although ghc-mod then works...

haskellngPackages is now set at GHC 7.10.x, so this particular issue should be fixed. If in doubt, it's also possible to downgrade to cabal-install_1_18_0_8 for GHC 7.8.x support.

Sorry to comment on a closed ticket but I am facing this exact problem and I am somewhat lost. I am using haskellng with ghc7.8.4 which per se seems to work but I would like to install cabal 1.20. How is that currently possible ?

@peti @miguel-negaro so what is the solution/fix here? Tried for a good while to find some solution yesterday and asked on nix-dev with no solution in sight.

I'm also clueless, I just stopped using cabal altogether and compile with GHC at the moment...

We just need ghc-mod update like
https://github.com/jagajaga/my_configs/blob/master/.nixpkgs/common.nix#L7

@gilligan, install cabal-install like so:
$ nix-env -iA haskell-ng.packages.ghc784.cabal-install_1_18_0_8

You can see the list of available packages by running
$ nix-env -qaP -A haskell.packages.ghc784

@peti thanks


How to display 2 or more lines in a row and dropdown text

I've been wondering the same thing

I can handle this by using renderCustomizedRowChild prop.
create my own renderItem, since I like the style of the library just copy the renderFlatlistItem element into the main library file and remove the numberOfLines property from it.
Here is an example of how it would look:
  const RenderItem = (item) => {
      return (
        <Text
          allowFontScaling={false}
          style={{
            fontSize: 18,
            textAlign: "center",
            marginHorizontal: 8,
            color: "#000",
          }}
        >
          {
             /* Something to consider here, if you have something assigned to `rowTextForSelection`, you should pass that same function here, otherwise just pass the `item` variable like so `item.toString()` */
             customRowTextForSelection(item)
           }
        </Text>
      );
    };

Now, so that it can be seen correctly, you also have to edit the styles of the rowStyle parameter.
the SelectDropdown component would look something like this:
<SelectDropdown
         // ...
          rowStyle={{
            minHeight: 50,
            height: undefined,
            // I added a vertical padding of 4 points because long texts are very close to the top and bottom of the row
            paddingVertical: 4,
          }}
          renderCustomizedRowChild={RenderItem}
         // ...

that's what worked for me.
Now my question is, does the numberOfLines parameter make any difference beyond aesthetics?
In this case, I think that another parameter could be added to the component to allow the value of the numberOfLines of the element to be rendered in the row to be edited.

The problem is that the height of each row should be known to calculate the possible height of the dropdown for the basic dropdown, you can use renderCustomizedRowChild to customize each row in the dropdown


serving on localhost:5000 not working

Windows system running Docker isn't serving on localhost:5000 as commited here 4a600f68c3b994a6ab6855c68e0abbc05f9dccd3 - not sure if this is actively in development or not

Running docker-compose up --build should serve:

the user-facing website at http://localhost/
the server REST API at http://localhost:5000

this should display a Not Found page if you go to this url in a browser
but e.g. http://localhost:5000/remaining should return the remaining samples this week
and http://localhost:5000/admin/allsamples should return an authorization error

If this isn't the case would you mind pasting the output of running the above docker-compose command here? (I haven't tried using this on windows)

thanks for the clarification, this works


NameError: name 'transformer_layer' is not defined

I have got the following error:

I thought it is because the input 'transformer_layer' here is not define.
May I ask how to solve the problem?

@seollyul
Sorry for the trouble,
add these few lines under strategy.scope,
with strategy.scope():
    transformer_layer = transformers.TFDistilBertModel.\
    from_pretrained('distilbert-base-multilingual-cased')
    # Rest of the code

@TashinAhmed
I added the code and it worked.
Thank you very much.╰(°▽°)╯

@seollyul
You are welcome. Can you please mark my previous reply as the correct answer so that a new visitor can directly find the solution instead of other comments!


webview-sample

Console error during debugging, i"m node version v14.18.1
error messages :
(node:41673) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Electron --trace-deprecation ...` to show where the warning was created)

launch.json :

{
	"version": "0.2.0",
	"configurations": [
		{
			"name": "Run Extension",
			"type": "extensionHost",
			"request": "launch",
			"runtimeExecutable": "${execPath}",
			"args": ["--extensionDevelopmentPath=${workspaceRoot}"],
			"outFiles": ["${workspaceFolder}/out/**/*.js"],
			"preLaunchTask": "npm: watch"
		}
	]
}

pictuire:

This is not related to this sample. See https://github.com/microsoft/vscode/issues/82524


ledger-web: use bundlerApp

Motivation for this change
Exposed more executables than needed and was outdated.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Looks good - haven't had the time to test it out though.

@GrahamcOfBorg build ledger-web


Bug with recovery actions Reboot Message and Run A Program Command

Both the Reboot Message and run a program Command properties get corrupted (show random characters).
This appears to be  due to incorrect memory/pointer allocation of ServiceFailureActionsInfo ( SERVICE_FAILURE_ACTIONS and SC_ACTION[] ).

FYI: I've created my own recovery actions code and have found it works if I use the below code to convert the SC_ACTION list to a pointer.
Hopefully this will help you identify the issue.
`
private static SafeMemoryHandle StructureArrayToPtr<SC_ACTION>(IList<SC_ACTION> structureArray)
{
if (structureArray == null || !structureArray.Any())
return new SafeMemoryHandle();
var elementSize = Marshal.SizeOf(typeof(T));
var arrayLength = structureArray.Count;

// Allocate enough unmanaged memory to hold the struct array and collect a pointer to it.
var totalArraySize = elementSize * arrayLength;
var pointerToStruct = new SafeMemoryHandle(Marshal.AllocHGlobal(totalArraySize));

// Populate the allocated memory with each structure.
for (var i = 0; i < arrayLength; i++)
{
    var offset = elementSize * i;
    var elementPointer = IntPtr.Add(pointerToStruct, offset);
    Marshal.StructureToPtr(structureArray[i], elementPointer, false);
}

return pointerToStruct;

}
`


undefined method `location' for nil:NilClass @ cop.rb:176

Be clear, concise and precise in your description of the problem.
Open an issue with a descriptive title and a summary in grammatically correct,
complete sentences.
Use the template below when reporting bugs. Please, make sure that
you're running the latest stable RuboCop and that the problem you're reporting
hasn't been reported (and potentially fixed) already.
Before filing the ticket you should replace all text above the horizontal
rule with your own words.

Expected behavior
Describe here how you expected RuboCop to behave in this particular situation
To do the "rubocop --auto-correct --disable-uncorrectable" command and finish the analysis and correction properly
Actual behavior
Describe here what actually happened.
An error is prompted
106 files inspected, 9554 offenses detected, 9526 offenses corrected undefined method location' for nil:NilClass
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cop/cop.rb:176:in disable_uncorrectable' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cop/cop.rb:161:in correct'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cop/cop.rb:134:in add_offense' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cop/lint/syntax.rb:35:in add_offense_from_diagnostic'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cop/lint/syntax.rb:24:in block in offenses_from_processed_source' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cop/lint/syntax.rb:23:in each'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cop/lint/syntax.rb:23:in offenses_from_processed_source' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cop/team.rb:39:in inspect_file'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:290:in inspect_file' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:238:in block in do_inspection_loop'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:270:in block in iterate_until_no_changes' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:263:in loop'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:263:in iterate_until_no_changes' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:234:in do_inspection_loop'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:119:in block in file_offenses' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:137:in file_offense_cache'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:117:in file_offenses' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:108:in process_file'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:87:in block in each_inspected_file' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:86:in each'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:86:in reduce' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:86:in each_inspected_file'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:73:in inspect_files' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/runner.rb:39:in run'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cli.rb:213:in execute_runner' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cli.rb:80:in execute_runners'
/home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/lib/rubocop/cli.rb:51:in run' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/exe/rubocop:13:in block in <top (required)>'
/home/djigo/.rvm/rubies/ruby-2.5.5/lib/ruby/2.5.0/benchmark.rb:308:in realtime' /home/djigo/.rvm/gems/ruby-2.5.5/gems/rubocop-0.76.0/exe/rubocop:12:in <top (required)>'
/home/djigo/.rvm/gems/ruby-2.5.5/bin/rubocop:23:in load' /home/djigo/.rvm/gems/ruby-2.5.5/bin/rubocop:23:in '
/home/djigo/.rvm/gems/ruby-2.5.5/bin/ruby_executable_hooks:24:in eval' /home/djigo/.rvm/gems/ruby-2.5.5/bin/ruby_executable_hooks:24:in '`
Steps to reproduce the problem
This is extremely important! Providing us with a reliable way to reproduce
a problem will expedite its solution.
Run "rubocop --auto-correct --disable-uncorrectable"
RuboCop version
Include the output of rubocop -V or bundle exec rubocop -V if using Bundler. Here's an example:
0.76.0 (using Parser <IP_ADDRESS>, running on ruby 2.5.5 x86_64-linux)
$ [bundle exec] rubocop -V
0.76.0 (using Parser <IP_ADDRESS>, running on ruby 2.5.1 x86_64-linux)

Use a file with a syntax error to reproduce this:
$ echo \" > 7513.rb
$ rubocop --auto-correct --disable-uncorrectable 7513.rb
Inspecting 1 file
.

0 files inspected, no offenses detected
undefined method `location' for nil:NilClass
/Users/buehmann/dev/rubocop/lib/rubocop/cop/cop.rb:176:in `disable_uncorrectable'
/Users/buehmann/dev/rubocop/lib/rubocop/cop/cop.rb:161:in `correct'
/Users/buehmann/dev/rubocop/lib/rubocop/cop/cop.rb:134:in `add_offense'
/Users/buehmann/dev/rubocop/lib/rubocop/cop/lint/syntax.rb:35:in `add_offense_from_diagnostic'
/Users/buehmann/dev/rubocop/lib/rubocop/cop/lint/syntax.rb:24:in `block in offenses_from_processed_source'
/Users/buehmann/dev/rubocop/lib/rubocop/cop/lint/syntax.rb:23:in `each'
/Users/buehmann/dev/rubocop/lib/rubocop/cop/lint/syntax.rb:23:in `offenses_from_processed_source'


Cards

Added the two cards for a team and a community.

@Shadab06 it's good to see you have mentioned the description of your task  but please mention the route where you have randered the component (Don't use the landing page route) and make sure you attach the screenshot of the component you have built..!! We appreciate your efforts but these requirements should be achieved inorder to merge your PR..!!


Update create-dns-records-at-cloudflare.md

Added the sixth Cname record for MSOID

Issue # https://github.com/MicrosoftDocs/OfficeDocs-O365ITPro/issues/929


Multiple Queries: SELECT followed by UPDATE

I'm attempting to implement an atomic read followed by an update (basically read old value and set new value) by issuing the following two queries in the same .QueryRow() call:
SELECT is_locked AS was_locked FROM migrations_lock WHERE "index" = 1;
UPDATE migrations_lock SET is_locked = 0 WHERE "index" = 1;

When the method runs I get the error no rows in result set. However, I noticed that the UPDATE query does succeed as the data has changed on disk. From what I can tell both queries are executing however it seems that data is only returned if the final query is a SELECT. To confirm this, I reversed the order of the two queries (UPDATE first SELECT second). Of course by reversing the queries I no longer receive the old version of the data.
For what its worth the equivalent query works for MySQL:
SELECT is_locked AS was_locked FROM migrations_lock WHERE `index` = 1;
UPDATE migrations_lock SET is_locked = 0 WHERE `index` = 1;

I'm curious if this is unintentional? From what I can gather SQLite returns a portion of the query that is un-executed and it's' up to the driver to keep executing the remaining queries. Perhaps .QueryRow() only considers the final query?

For added context, here's some related code  and a stack overflow question.

From what I can tell of this library's implementation, it will completely ignore all but the last query.

From what I can gather SQLite returns a portion of the query that is un-executed and it's' up to the driver to keep executing the remaining queries.

While this is true of the underlying C library, this concept does not translate well into Go's database/sql API. Consequently, I would not recommend combining multiple queries in a single call like that. You should use QueryRow for the first one and Exec for the second one. You also may want to combine the two into a proper transaction via Begin and Commit.

it will completely ignore all but the last query

I guess I'm trying to figure out if it's an unintentional bug or intentional limitation of the library. For my project I'm trying to build a migration runner that works with multiple DBMS and simply swaps out queries depending on the database. This concept worked great with MySQL and Postgres:
	LOCK = database.QueryBox{
		Postgres: `UPDATE migrations_lock SET is_locked = 1 WHERE index = 1 RETURNING ( SELECT is_locked AS was_locked FROM migrations_lock WHERE index = 1);`,
		Mysql: `START TRANSACTION;
	SELECT is_locked AS was_locked FROM migrations_lock WHERE ` + "`index`" + ` = 1;
	UPDATE migrations_lock SET is_locked = 1 WHERE ` + "`index`" + ` = 1;
COMMIT;`,
		Sqlite: `BEGIN TRANSACTION;
	SELECT is_locked AS was_locked FROM migrations_lock WHERE "index" = 1;
	UPDATE migrations_lock SET is_locked = 1 WHERE "index" = 1;
COMMIT TRANSACTION;`
	}
// ...
	var was_locked int
	err = dbox.QueryRow(LOCK).Scan(&was_locked) // runs appropriate query depending on DBMS

I might have just reached the point in my project where I cannot simply swap queries from one driver to the next and need to complicate things a bit further. Like, if sqlite, then run two individual queries.

this concept does not translate well into Go's database/sql API

I was thinking that as well. With the standard Go API there's certainly no exposed way to iterate over unexecuted results. But, based on the Postgres and MySQL behavior, I would hope that internally the library would execute each query and gather results from any that returned rows.

You also may want to combine the two into a proper transaction via Begin and Commit.

Funny you mention that! The first approach I took did wrap the two queries in a transaction. The error I get when doing that is:
cannot commit - no transaction is active

I'm still figuring this one out but it seems like SQlite has some sort of implicit transaction which implicitly closes after certain queries are executed? Like maybe upon encountering the SELECT query the transaction self-commits and then that final COMMIT is now outside of a transaction?
In this specific scenario the easiest approach is to split these two queries made in a single call into two sets of single queries made in individual calls. That wouldn't be atomic in a network based DBMS but maybe it's fine with sqlite?

I guess I'm trying to figure out if it's an unintentional bug or intentional limitation of the library.

It's probably a bug. I think it would be possible to model multiple statements to Query as multiple result sets (as database/sql calls them), but it would take some time to implement this properly, and it could cause issues for anyone currently using the broken behavior.
Again, I would highly discourage doing this even if the bug is fixed, especially if you ever start using bound parameters.

This concept worked great with MySQL and Postgres

I would recommend against exec'ing BEGIN TRANSACTION like that for any DBMS. If you forget to commit/rollback at the end, then because the database/sql package does not know this happened, it will freely reuse the connection in the future, potentially resulting in confusing bugs.

I'm still figuring this one out but it seems like SQlite has some sort of implicit transaction which implicitly closes after certain queries are executed? Like maybe upon encountering the SELECT query the transaction self-commits and then that final COMMIT is now outside of a transaction?

SQLite will never auto-commit an explicit transaction. (It may auto-rollback in some cases, but you would have already received an error in that situation.) I would need to see the code sample for a deeper analysis.

In this specific scenario the easiest approach is to split these two queries made in a single call into two sets of single queries made in individual calls. That wouldn't be atomic in a network based DBMS but maybe it's fine with sqlite?

In general, that will not be atomic in any DBMS, including SQLite. Whether that is fine is contingent upon your application design and requirements.

Here's a repro:
package main

import (
	"database/sql"
	"fmt"

	_ "github.com/mattn/go-sqlite3"
)

func main() {
	db, err := sql.Open("sqlite3", ":memory:")

	if err != nil {
		panic("this should not fail")
	}

	_, err = db.Exec(`CREATE TABLE migrations_lock (
	"index" serial NOT NULL,
	is_locked int4 NULL,
	CONSTRAINT migrations_lock_pkey PRIMARY KEY ("index")
);
INSERT INTO migrations_lock ("index", is_locked) VALUES(1, 1);`)

	if err != nil {
		fmt.Println(err)
		panic("this should not fail")
	}

	var was_locked int

	err = db.QueryRow(`BEGIN TRANSACTION;
		SELECT is_locked AS was_locked FROM migrations_lock WHERE "index" = 1;
		UPDATE migrations_lock SET is_locked = 1 WHERE "index" = 1;
	COMMIT TRANSACTION;`).Scan(&was_locked)

	if err != nil {
		fmt.Println(err) // cannot commit - no transaction is active
	}

	err = db.QueryRow(`
		SELECT is_locked AS was_locked FROM migrations_lock WHERE "index" = 1;
		UPDATE migrations_lock SET is_locked = 1 WHERE "index" = 1;
	`).Scan(&was_locked)

	if err != nil {
		fmt.Println(err) // sql: no rows in result set
	}

	fmt.Println(was_locked) // prints 0
}

As I mentioned, Query (and QueryRow) only execute the last statement. In this case, that is COMMIT, which results in the error you are seeing, since BEGIN was not executed.
Also, as I mentioned, executing BEGIN and COMMIT like that behind database/sql's back is not recommended.
You should do it like this:
tx, err := db.Begin()
if err != nil {
    ...
}
defer tx.Rollback()

var wasLocked bool
if err := tx.QueryRow(`SELECT is_locked AS was_locked FROM migrations_lock WHERE index = 1`).Scan(&wasLocked); err != nil {
    ...
}

if err := tx.Exec(`UPDATE migrations_lock SET is_locked = 1 WHERE index = 1`); err != nil {
    ...
}

if err := tx.Commit(); err != nil {
    ...
}

Can confirm that fixes it:
package main

import (
	"database/sql"
	"fmt"

	_ "github.com/mattn/go-sqlite3"
)

func main() {
	db, err := sql.Open("sqlite3", ":memory:")

	if err != nil {
		panic("this should not fail")
	}

	_, err = db.Exec(`CREATE TABLE migrations_lock (
	"index" serial NOT NULL,
	is_locked int4 NULL,
	CONSTRAINT migrations_lock_pkey PRIMARY KEY ("index")
);
INSERT INTO migrations_lock ("index", is_locked) VALUES(1, 1);`)

	if err != nil {
		fmt.Println(err)
		panic("this should not fail")
	}

	tx, err := db.Begin()
	if err != nil {
		panic(err)
	}
	defer tx.Rollback()

	var wasLocked int
	if err := tx.QueryRow(`SELECT is_locked FROM migrations_lock WHERE "index" = 1;`).Scan(&wasLocked); err != nil {
		panic(err)
	}

	if _, err := tx.Exec(`UPDATE migrations_lock SET is_locked = 0 WHERE "index" = 1;`); err != nil {
		panic(err)
	}

	if err := tx.Commit(); err != nil {
		panic(err)
	}

	fmt.Println(wasLocked)
}


Not Getting Scroll Positions From ReactRootView In Android

Description
Getting Scroll X And Y positions 0 after scrolling up and down from ReactRootView In Android. For instance, ReactRootView inside FrameLayout gets scrolled down or up. ReactRootView returning Scroll Y 0.
Steps to reproduce

Integrate ReactRootView Inside FrameLayout In Android
Scroll Up Or Down
Observe Scroll Y In ReactRootView

React Native Version
0.73.2
Affected Platforms
Runtime - Android
Output of npx react-native info
Device
Name - Samsung
Model - M31
RAM - 8GB

Stacktrace or Logs
-

Reproducer

Screenshots and Videos
No response

Please fill the issue template correctly

Hi @cortinico Thanks for your reply! What details you require? It would be happy to share the details.

Definitely the npx react-native info + a reproducer using the linked tempalte


Feature gate deprecation

What this PR does / why we need it:
The PR introduces a generic mechanism to deprecate a feature gate.
There are 3 possible states of a feature where the feature gate may be deprecated.

GA
The feature is GAed, the feature gate is not needed anymore, therefore, it is always enabled. A user trying to add the fg to the kubevirt CR should get a warning.

Deprecated
The feature is going to be discontinued on the next release. The user should get a warning if the fg or the feature API are used.

Discontinued
The feature is discontinued, the fg should be always disabled and usage of the API should lead to no-op.

Existing GAed features were add to the new mechanism.
passt that is going to be Discontinued on the next release (1.3) was added as an example to
PreDiscontinued state.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

Raise an error in case passt feature gate or API are used.

I really like the minimal framework you are proposing here. Please consider keeping deprecated-feature-gates.go in its own package and adding a short markdown file describing its purpose and how it should and should not be used. Thanks!

/test pull-kubevirt-build
/test pull-kubevirt-build-arm64
/test pull-kubevirt-generate
/test pull-kubevirt-manifests
/test pull-kubevirt-unit-test
/test pull-kubevirt-e2e-k8s-1.27-sig-network

/test pull-kubevirt-build
/test pull-kubevirt-build-arm64
/test pull-kubevirt-generate
/test pull-kubevirt-manifests
/test pull-kubevirt-unit-test
/test pull-kubevirt-e2e-k8s-1.27-sig-network

/cc @xpivarc

/test pull-kubevirt-build
/test pull-kubevirt-build-arm64
/test pull-kubevirt-generate
/test pull-kubevirt-manifests
/test pull-kubevirt-unit-test
/test pull-kubevirt-e2e-k8s-1.27-sig-network

Thanks @AlonaKaplan
/lgtm
/retest-required

/approve
Raising two lgtms to approve


feat(settings): add users management settings

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Tried to initialize from a previous compilation, but couldn't.

Thank you for taking the time to file an issue!
In order to route, prioritize, and act on this, please include:

Dart SDK Version (dart --version)
Whether you are using Windows, MacOSX, or Linux (if applicable)
Whether you are using Chrome, Safari, Firefox, Edge (if applicable)

Missing some or all of the above might make the issue take longer or be
impossible to act on.

Is it really an issue? For general questions consider starting with Stack
Overflow:
https://stackoverflow.com/questions/tagged/dart
Also consider our Gitter channel for light-weight/quick discussions:
https://gitter.im/dart-lang/sdk

@jensjoha @aam
Maybe we should either a) include a lot of actionable information into the error report for this error or b) suppress this error entirely?

There actually is a lot of actionable information in the warning these days. It contains both a stacktrace and asks the user to upload the dill file it tries to initialize from.
In my opinion we should not suppress it --- it was added because we got into a situation that in flutter - without anyone noticing - loading from a dill file didn't work at all.
The hope is that by issuing warnings when it fails (except for in a few cases where it is "ok") we'll stop that from happening again.

@IrshadS please provide full information from the error report. As it is now - this report is non actionable.


mxv, vxm, vxv

These are required for SSSP.
There is also initial scaffolding for vector_accumulate and vector_equals, but they are not implemented yet.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.605%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1947

Relevant Lines:
2357

💛  - Coveralls

OK, going to merge this in, and then I will rebase #93 on new main.


Updates for Python scripts

This pull request introduces 5 alerts and fixes 3 when merging 57d0ae06c09c6cfdcd3ed75588e369a843cb6d21 into d7cee03a94656878e6e0a8377f548e8ed1f90ca3 - view on LGTM.com
new alerts:

1 for __eq__ not overridden when adding attributes
1 for Unused local variable
1 for Missing call to __init__ during object initialization
1 for Implicit string concatenation in a list
1 for Module is imported with 'import' and 'import from'

fixed alerts:

2 for Syntax error
1 for Encoding error

Comment posted by LGTM.com

This pull request introduces 4 alerts and fixes 3 when merging c59c45fb3ebcb9fc444493817088293ec1b3e9ec into d7cee03a94656878e6e0a8377f548e8ed1f90ca3 - view on LGTM.com
new alerts:

1 for __eq__ not overridden when adding attributes
1 for Unused local variable
1 for Missing call to __init__ during object initialization
1 for Module is imported with 'import' and 'import from'

fixed alerts:

2 for Syntax error
1 for Encoding error

Comment posted by LGTM.com


Add proof verification into the tests.

#474

@mitschabaude @MartinMinkov
Weird that tests still fail by:
Cannot read properties of undefined (reading 'proof')

Am I missing something?

You are storing the result of Mina.transaction into deploymentTransaction but then calling transaction.prove and transaction.send(). Maybe it should be deploymentTransaction instead?

Not sure what causes the error you mention @shimkiv! Another thing: To make verification work in the browser, you probably have to merge releases since that is where I pushed the fix

@shimkiv I think you're signing the tx, that's why no proof is created, so proofs[0] is undefined`


changes for loading brand

changes for loading branding ,
add scan text on scan button,
fixed warning issue,

Hi @dileep-gadiraju  I have tested above pr . issues realted to
lagging issue for loading branding ,
add scan text on scan button,
fixed warning issue
has been fixed and it is working properly


Issue with Curve Function

Hello, I'm new using Curve Finance API and also in JS. I'm trying to the replicate the same code that has been given in the example - https://github.com/curvefi/curve-js#general-methods
I'm getting this error in my console:
TypeError: curve.getTVL is not a function
    at file:///Users/new.ts:4:17
    at Generator.next (<anonymous>)
    at file:///Users/new.ts:7:71
    at new Promise (<anonymous>)
    at __awaiter (file:///Users/new.ts:3:12)
    at file:///Users/new.ts:3:13
    at file:///Users/new.ts:33:3
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)

Does anyone know why is it showing this error?

GM sir. I had the same issue with the current release (2.26.3) on Windows.
I was able to solve it by replacing curve.init(parameters) with curve.default.init(parameters) .
You basically need to replace every "curve" call by a curve.default .
Hope it'll works for you

There is no curve.init in that example. It works like this:
(async () => {
    await curve.init('JsonRpc', { url: ETH_RPC }, { gasPrice: 0 });

    console.log(await curve.getTVL());
}()


Make consistent storage plugins. Fixes #6011

Looks good to me.
It seems none of these plugins are actually using 'checksum'. Anyways, we can remove it later on..

According to Dirk, sites use Backend instead of Plugins directory.

except Andrew :smile:  @PerilousApricot


expose stdout to subprocess provider [APE-1385]

i'm working on an update to ape-foundry where it binds to a free port suggested by the system instead of trying random ports from ephemeral port range and hoping they are free.
it does so by connecting to <IP_ADDRESS>:0 and watching stdout for when it says on which port foundry is listening. i got blocked by stdout only being available when -v DEBUG is passed.
https://github.com/ApeWorX/ape/blob/73f981fe01d4a3d59504a78b4890ece257c88cc1/src/ape/api/providers.py#L1757
exposing stdout/stderr to a subprocess provider also has other benefits, namely better error reporting and faster start because we can just wait for a "ready" output instead of hammering it with requests.
i suggest we always capture stdout/stderr and add optional hooks that receive lines of output for subclasses to override.

Looking through history, it seems the captured subprocess logs that appear in caplog during ape test runs was really annoying and that is why we only made that happen during -v debug when one needed it.
I think possibly we could have the OS pick a random port using the socket library and such and use that as port without needing the "listening" part. Maybe we could slow down the rate of checking if the RPC is available? I don't think making requests to a local server during start-up is a big deal though.
We could research into ignoring these logs from pytest's caplog (and maybe all Ape loggers?). But also, I am not sure we typically need to capture all these logs for most use-cases unless using verbose logging, so using a PIPE fail may be a bloat of memory that is unneeded?

Perhaps we could write a tempfile so long as we properly manage it and figure out a way to ignore from pytest caplog. That would work.


New-ish to this, so probably my fault...

Hello! First of all -- THANK YOU for making this! The issue this addresses drives me absolutely insane. I close my laptop for a few minutes, open it back up, and I've lost my connection. Stupidly, all other devices except my own MBP will auto-connect to my hotspot.. Even other peoples' Macs...
Anyway, my issue is shown below. I've successfully followed all install steps up to actually running install.sh. I'm pretty new to all of this, so I'd bet I'm doing something wrong, but I can't find the answer on Google.
Given the syntax error at the bottom, I tried commenting out the last few lines (having no clue what I was doing) -- "main() {...}." I can get rid of that syntax error, but I still get the "No such file or directory" errors. (I have restored the install.sh code since trying this.)
Thinking I'm straight up doing something wrong, I feel terrible taking up this real estate with such a dumb question, but maybe someone can help?
Thanks again!
FROM TERMINAL:
(base) Putor:~ usr$ sudo -s /Users/ian/Documents/CODE/GitHub/auto-hotspot/install.sh
Password:
cp: ./auto-connect-hotspot.sh: No such file or directory
chmod: /Library/Scripts/auto-connect-hotspot.sh: No such file or directory
cp: ./com.nick.auto-connect-hotspot.plist: No such file or directory
chmod: /Library/LaunchAgents/com.nick.auto-connect-hotspot.plist: No such file or directory
/Library/LaunchAgents/com.nick.auto-connect-hotspot.plist: No such file or directory
/Users/ian/Documents/CODE/GitHub/auto-hotspot/install.sh: line 51: syntax error near unexpected token }' /Users/ian/Documents/CODE/GitHub/auto-hotspot/install.sh: line 51: }'

Just noticed the filename discrepancies and corrected to the new names in install.sh. Same issue...

I then manually placed the auto-hotspot.sh and .plist files into the directories given in the failed install. Then did my own chmod 755 [file] on each -- returned no errors. I finally tried to run auto-hotspot.sh, which returned this:
(base) Putor:LaunchAgents usr$ sudo /Library/Scripts/auto-hotspot.sh
ifconfig: interface en6 does not exist
I am quite lost.

Hey thanks for your interest. I was refactoring a bit and soon the readme page will be updated as well. I'll keep you posted with new instruction.
Glad you find it useful!

@bboysnick5 hi Nick, any updates on this script? Thanks


[bug] Iframe is not able to receive invoke callbacks

Describe the bug
I am mounting an iframe ("child") within a Tauri app. I control both the parent and child and they both are rendered via tauri's vite build. Both the parent and the child have access to window.__TAURI__ and related methods.
The problem is that I'm not able to invoke handlers from the iframe. Using invoke from the ifram produces the following warning in the developer console:
[TAURI] Couldn't find callback id 90962087 in window. This happens when the app is reloaded while Rust is running an asynchronous operation.

It seems that iframe invoke successfully registers callbacks and calls the rust handlers, which are successfully run. However, when rust tries to return the response, the callback is caught by the parent window instead of the iframe. The parent does not have the callbacks registered, hence the warning.
Is there some way to get Tauri to work with this setup? One way to go about this would be to prefix the callback handlers by frame or window?
Reproduction
Repro:

Clone repo at https://github.com/gamgi/repro-tauri and enter its root.
Install prerequisites npm install
Start the tauri app cargo tauri dev
In parent greet box, type name and press greet (it works)
In child greet box, type name and press greet (it does not work)
Open console, see error [TAURI] Couldn't find callback id 90962087 in window. This happens when the app is reloaded while Rust is running an asynchronous operation.

Additional verifications:

The iframe does have tauri IPC defined, this can be verified by document.querySelector("#root > div > iframe").contentWindow.__TAURI__.
The iframe is able to call tauri, which can be verified by the "Rust backend called with ..." log from rust

Expected behavior
I expect the child window to be able to invoke tauri handlers from the iframe and to get a response.
Platform and versions
Environment
› OS: Mac OS 10.15.7 X64
› Node.js: 18.12.1
› npm: 8.19.2
› pnpm: Not installed!
› yarn: Not installed!
› rustup: 1.25.1
› rustc: 1.66.1
› cargo: 1.66.1
› Rust toolchain: 1.66.1-x86_64-apple-darwin
Packages
› @tauri-apps/cli [NPM]: 1.2.3
› @tauri-apps/api [NPM]: 1.2.0
› tauri [RUST]: 1.2.4,
› tauri-build [RUST]: 1.2.1,
› tao [RUST]: 0.15.8,
› wry [RUST]: 0.23.4,
App
› build-type: bundle
› CSP: unset
› distDir: ../dist
› devPath: http://localhost:1420/
› framework: React
› bundler: Vite
App directory structure
├─ node_modules
├─ public
├─ src-tauri
├─ .git
├─ .vscode
└─ src
Stack trace
`[TAURI] Couldn't find callback id 90962087 in window. This happens when the app is reloaded while Rust is running an asynchronous operation.`

Additional context
No response

Indeed, the child iframe is able to invoke tauri commands, but the callbacks are fired on root window instead of the iframe, resulting in Couldn't find callback id ... in window. This seems like a bug.
The workaround is to use a custom invoke initialization script using tauri::Builder::invoke_system(invoke_initialization_script, ...) which adds proxies from the parent window to the iframe.
I have a working implementation outlined in this commit.

Hi, just leaving more information here because I'm familiar with the topic. WebKit (macOS and Linux) actually supports an option that makes all invoking be able to happen on a parent or a child, separately. It allows you to create and use callbacks solely on the child frame. Unfortunately Webview2 (Windows) does not support something like this (at the last time I checked which is around Tauri 1.0) and all callbacks get received by the parent. Because of this, the feature is not enabled on WebKit to ensure the same behavior across platforms.
Your solution probably works just fine if the iframe is not sandboxed (I didn't run your repro but that commit diff makes sense) but might break if the sandbox is activated for the iframe. An alternative solution that works with the sandbox is to use postMessage to communicate between the parent and child. This is actually how the Isolation Pattern is implemented, where the parent IPC potentially sets up communication with the child frame. The key generation and encryption stuff is specific to the Isolation Pattern, but you can see how they are using postMessage to communicate between them.

any update on this? We have a scenario with a site with an iFrame. and we need to communicate from child iFrame to the rust layer. Can someone please help with how I can setup Tauri to have the child iFrame-rust communication.
I am only building child iFrame code with Tauri/api. The host site doesn't know anything about tauri

Same here

If your iframe and main window have the same domain name, then this may be a good method(Add the following code to the very top of js initialization):
// Override the __TAURI_IPC__ function
window.__TAURI_IPC__ = (args) => {
  //The parent window callback points to the child window
  window.parent[`_${args.callback}`] = window[`_${args.callback}`];

  // Call the function of the parent window
  window.parent.__TAURI_IPC__(args);
};


Cannot make install on mac m1

Terminal is checked with 'Open with Rosetta'
Cannot 'make install' with any branches
This is the error.
# github.com/zondax/hid In file included from ../go/pkg/mod/github.com/zondax/hid@v0.9.0/hid_enabled.go:38: ../go/pkg/mod/github.com/zondax/hid@v0.9.0/hidapi/mac/hid.c:693:34: warning: 'kIOMasterPortDefault' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:133:19: note: 'kIOMasterPortDefault' has been explicitly marked deprecated here

This is fixed now, thanks!

Make install still returns same issue on M1, tried almost all the release

I resolve the above issue by updating the package dependency from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>go get<EMAIL_ADDRESS>Then, I run make install and it is shown
go install -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sei -X github.com/cosmos/cosmos-sdk/version.ServerName=seid -X github.com/cosmos/cosmos-sdk/version.Version=3.0.1-113-g1eb2485d -X github.com/cosmos/cosmos-sdk/version.Commit=1eb2485da967f1d26f0f81f442094da3b7ed5dd4 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo ledger,"' ./cmd/seid
However, Make install still not work.


[SPARK-38709][SQL] Remove trailing $ from function class name in sql-expression-schema.md

What changes were proposed in this pull request?

It's a bit weird to see class names like CeilExpressionBuilder$ in sql-expression-schema.md. This PR removes the trailing $.
Why are the changes needed?

code cleanup
Does this PR introduce any user-facing change?

No
How was this patch tested?

existing tests

cc @beliefer @MaxGekk

Merged to master/3.3.

Oh.. After merging, I noticed that SPARK-38709 is filed as an improvement for 3.4.0.
Do you want me to revert it from branch-3.3, @cloud-fan ? Or, are we good?

@dongjoon-hyun we are good. This is kind of test only change so OK to backport.


Milestones history

Created, updated or deleted Milestones should display on the history page
Private Zenhub Image
Icon is https://fontawesome.com/icons/signs-post?f=classic&s=solid colour: 1A5A96

Hey team! Please add your planning poker estimate with Zenhub @rafasdc @AntBush


Test

@VoTuan1988, could you please add your mane to https://github.com/Roshanjossey/first-contributions/blob/master/Contributors.md rather than CONTRIBUTING.md ?

@VoTuan1988, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Icons Not Displaying and Checkbox Not Functioning Correctly in Semantic UI

I want to use Semantic UI for UI development only. I included the following CSS link:

I encountered several issues:

Icons are not displaying at all.
The checkbox does not show the checked state, even after adding the checked class.

It doesn't work in Chrome browser, but it works in Safari


pydantic should be able to distinguish missing key and value properly

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
Supposed there are schemas defined like below:
from pydantic import BaseModel

class QueueSystemConfig(BaseModel):
    class Slurm(BaseModel):
        sbatch_bin: str = 'sbatch'
        squeue_bin: str = 'squeue'

    class Lsf(BaseModel):
        bsub_bin: str = 'bsub'
        bjobs_bin: str = 'bjobs'

    slurm: Optional[Slurm]
    lsf: Optional[Lsf]

class Config(BaseModel):
    queue_system: QueueSystemConfig

And if user provide a configuration file like below
queue_system:
  slurm:

I expect Config.parse_object(data) will yeild something like
queue_system:
  slurm:
     sbatch_bin = 'sbatch'
     squeue_bin = 'squeue'

But in facts it yields
queue_system:
  slurm: null
  lsf: null

Well, there is a workaround to make it right by providing an empty object
queue_system:
  slurm: {}

But I would like pydantic to be able to handle missing key and missing value with different method. Acutally it is common in docker-compose to provide a key without value and default configuration will be applyed, for example:
volumes:
  mysql-data:

I hope that there is a way for pydantic to do the same thing to treat missing key and missing value differently:

when a key is missing, then it is supposed to be just None
when a key is provided but its value is missing,  then it is supposed to fill it with the default value

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Hi @link89, how are you loading your configuration file?
If it is a yml fiile, there is a good chance it gets loaded as
{'queue_system': {'slurm': None}}
for which the current behavior seems fine.

I just load yaml file with raml and send the dict to pydantic to parse. It is equvilent to the following code
from pydantic import BaseModel
from typing import Optional

class QueueSystemConfig(BaseModel):
    class Slurm(BaseModel):
        sbatch_bin: str = 'sbatch'
        squeue_bin: str = 'squeue'

    class Lsf(BaseModel):
        bsub_bin: str = 'bsub'
        bjobs_bin: str = 'bjobs'

    slurm: Optional[Slurm]
    lsf: Optional[Lsf]

class Config(BaseModel):
    queue_system: QueueSystemConfig

parsed = Config.parse_obj({
  'queue_system': {
    'slurm': None,
  }
})
print(parsed)

The output is
queue_system=QueueSystemConfig(slurm=None, lsf=None)

But I expect it to be
queue_system=QueueSystemConfig(slurm=Slurm(sbatch_bin='sbatch', squeue_bin='squeue'), lsf=None)

If your suggestion is implemented and
'queue_system': {     'slurm': None,   }
initiates
queue_system=QueueSystemConfig(slurm=Slurm(sbatch_bin='sbatch', squeue_bin='squeue'), lsf=None)
what would one have to pass to get
queue_system=QueueSystemConfig(slurm=None, lsf=None)


Consider using thread pool for async methods

Rather than delegating to the base ADO "async" methods.

Triage We're not going to do this as it is not consistent with how async is implemented in other framework components.


Check Comparison in filter with proper tests

Currently the orignal comparing code is commented out:
# This code is untested and not documented. It also does not call the super method
But still the test do not fail.
We should check if filter like this
less_than_a_tonne = HayBale.objects.filter(weight__lt=Quantity(2000 * ureg.pound))

really work properly by adding some more test.
I.e. use HayBale.weight (base unit is gram) and add an elements "100g". Compare it mit _eq to 0.1kg and 100000mg.
After that do Test with weigh_lt 0.99kg and 99 000mg as well as smaller 101g with units again.
If the function needs to be used, don't forget to call the super method.
@cornelv This would be an issue worth spending time on.

I just saw that Ben already added test similar my proposed.
They aren't failing, so I assume that django is calling get_prep_value for test.
But this needs to be verified.
Some more in depth testing would be great.

So far I understand my tests, it works as it should


Added a python script that uploads an image to imgur via keyboard shortcut.

Implement Imgur Image Upload via Clipboard with Keyboard Shortcut
Summary
This pull request introduces a feature that allows users to upload images directly from their clipboard to Imgur using a keyboard shortcut. The script captures the image from the clipboard, converts it to base64, and uploads it to Imgur via their API, this script handles exceptions and has environment variable support for security reasons.
Description
This Python script enables users to easily upload images from their clipboard to Imgur by pressing a keyboard shortcut (Ctrl + Alt + S).
Key Features:

Clipboard Capture: Automatically grabs images currently in your clipboard.
Imgur Integration: Uploads the captured image to Imgur with a simple API call.
Keyboard Shortcut: Use Ctrl + Alt + S to quickly upload images without any hassle.
Secure Credentials: Manages the Imgur Client ID using environment variables for added security.

This tool simplifies the process of sharing images online, making it fast and convenient.
Please go through the README for more details and also screenshots of woking of the project.
This pull request solves issue #280.

Thank You,
Rohit Sharma.

Please rename the folder to match the format of the other names. Additionally, please add this script to the table of the main README file.

On it..

Hi @hasan-py I have completed the said changes kindly review.

solved issue #313 with latest commit.


openssl_1_1: 1.1.1u -> 1.1.1v

Description of changes
https://github.com/openssl/openssl/blob/OpenSSL_1_1_1v/NEWS
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 246581 run on x86_64-linux 1

1 package failed to build:

osquery

osquery 🤯
CMake Error at openssl-stamp/verify-openssl.cmake:29 (message):
  error: SHA256 hash of

    /nix/store/j45xbcpgj0i8xssp2hdbm0qd0wmc2h3p-openssl-1.1.1v.tar.gz

  does not match expected value

    expected: 'e2f8d84b523eecd06c7be7626830370300fbcc15386bf5142d72758f6963ebc6'
      actual: 'd6697e2871e77238460402e9362d47d18382b15ef9f246aba6c7bd780d38a6b0'

The hash is valid here:

This is about something else.  Testing a less hacky fix than we have now.

https://github.com/NixOS/nixpkgs/pull/246828


What the diff between OTP otp.bin (0x100) and otp.bin (0x108)

0x108 includes the TWL ID, which isn't currently used for anything but may be in the future


Move Checker common state so the cache can be hit

Many commits ago the field VCGen.CheckerCommonState was introduced (ref). At that time a single VCGen was used for an entire Boogie program (ref), so the CheckerCommonState could be shared between implementations. The current master branch creates a VCGen per Implementation so it seems the cache in CheckerCommonState never hits.
Changes
Move the CheckerCommonState there to enable the cache to function.

@keyboardDrummer : Should this PR be abaondoned?


Is NSwag officially dead?

Sorry if it sounds a little bit sad, but can we now assume that project is officially dead?
There were breaking changes in v14 so half of generation schemas not working:
typesToOpenApi
webApiToOpenApi
https://github.com/RicoSuter/NSwag/issues/4524
So there are several issues like https://github.com/RicoSuter/NSwag/issues/4731 or https://github.com/RicoSuter/NSwag/issues/4659 where users trying to migrate and get huge problems ike PC hanging since the start of the year.
There is issue https://github.com/RicoSuter/NSwag/issues/4404 from that but there is no responce from March.
In my company we had pipeline with typesToOpenApi because we have shared models in separate solution and right now I don't see any  easy solutions to migrate to .Net 8.
For me now I'm going to write my own generator because there is no even timeline to fix those problems.

It looks like it. And the list of open issues keeps on growing. The generator is filled with hundreds of options which amazingly don't solve basic problems (e.g. #3851). We've been running serialization workarounds for years. V13 already had plenty of issues before V14 came along to add even more salt to the wounds. Casing is now all over the place, unwanted or improper validations are still here to stay, it's all a big mess. In my opinion, a reboot of this project, definitely with better stewards, is  definitely needed at this point.

I would say that Nswag is a little bit too complex.
But I am also tired about the complains in Open Source all the time. Rico has probably generated Millions in value already and there are very little commits from other developers and large Organizations.

Latest release is from March so I wouldn't jump to conclusions about project being dead. I think it's lovely that both @euroUK and @MoonStorm are complaining about issues and I fail to see any actual contributions from you.

Latest release is from March so I wouldn't jump to conclusions about project being dead. I think it's lovely that both @euroUK and @MoonStorm are complaining about issues and I fail to see any actual contributions from you.

I'm sorry I couldn't find the time to understand and contribute to the project, but there are close to 100 PRs waiting to be triaged and integrated into the code base. Many of them are years old already and the older they get, the more difficult it is to integrate them.

Please also consider the burden from the PRs. They are made with best intentions, but they require review (time away from your life) and also they come with a risk. There have been some regressions recently based on improvements that have had ill-effects on other areas - the possible combinations of usage scenarios is mind-blowing.
So when you ask to merge/propose a PR to close an issue the end result might be 10 more issues being opened because something else is now broken. By merging a well-intentioned PR you might spent time trying to fix and release a new version (hopefully) fixing regressions and not breaking anything more.
Of course there are "easy" ones that (at least) seem like no-brainers, but they take effort.

That's very true. You do need time to approve/reject/adjust PRs. Many of them might target a very specific case that might not be in line with the path the project is supposed to be on. Reason why for example we have a million different options in the code generation, many of them overlapping on not solving basic issues.
But here lies the problem as well. You can't ask for contributions if you don't even have the people or the time to get them sorted. A project where you have the volunteers who offer their work but you don't have time to manage them is pretty much a dead project.

That's very true. You do need time to approve/reject/adjust PRs. Many of them might target a very specific case that might not be in line with the path the project is supposed to be on. Reason why for example we have a million different options in the code generation, many of them overlapping on not solving basic issues.
But here lies the problem as well. You can't ask for contributions if you don't even have the people or the time to get them sorted. A project where you have the volunteers who offer their work but you don't have time to manage them is pretty much a dead project.

Do you have plans on starting a similar project with management that fills your expectations? I think there would be plentiful of people consuming it and creating a backlog for you to work on (please make it free).

No. But I hope somebody will soon. Even now I'm starring at a freshly new generated set of DTOs, where several of them were generated with a small case name, in C#, with the compiler obviously blowing up on such a simple coding style violation.
Lack of proper tests, lack of a solid foundation, where the quantity of features prevailed over quality. A project that was caught off guard by its popularity.

No. But I hope somebody will soon. Even now I'm staring at a freshly new generated set of DTOs, where several of them were generated with a small case name, in C#, with the compiler obviously blowing up on such a simple coding style violation.
Lack of proper tests, lack of a solid foundation, where the quantity of features prevailed over quality. A project that was caught off guard by its popularity.

Now I believe the audience would love to see how proper software should be built. Can you share some of your work?

The audience is busy logging issues.

Ummm, I think we all know by now how "proper software" should be built. Or don't we? A quick google search: SOLID Principles, Design Patterns, TDD, Coding Styles, etc.

I don't even see an editorconfig file in this project with the code rules properly defined!

Oh I see, now you're.... "minimizing" my comments 🤣
Isn't it sad when even such a small amount of power get to people's head?
Yup, these are definitely the right people in charge of this project. Good luck over there!

Oh I see, now you're.... "minimizing" my comments 🤣 Isn't it sad when even such a small amount of power get to people's head? Yup, these are definitely the right people in charge of this project. Good luck over there!

Just because your condescending attitude is not welcome here.

Ah don't worry about that, don't really wanna be here. I wish this is gonna be restarted by more talented people who do have more time to care for it. The idea behind this project is brilliant, the implementation is simply sub-par for its popularity, as I said, reason for the neverending list of unsolved issues that keep on piling up.

Thank you for your input. Like you've discovered, it's hard to find the needed talented people. Me and you wouldn't clearly make the cut.

@lahma
Why so toxic?
I just wanted to decide to remove NSwag from toolchain completly or wait a little bit and may be things will be fixed.
The reasons I'm not contributing to Open Source are obvious - I'm working full time as software developer and I don't have enough free time to properly manage open source solutions. My code is enough for our company needs but you need to invest 3x more time to properly release it for everyone. I don't blame if Rico has no time, It would not take too much time to generate typesToOpenApi for our toolchain. I just don't want to reinvent the weel.
Moreover, the open source initiative appears to be dead because the only alive solutions are those supported or developed by large corporations.

I think yes, unfortunately. NSwag was good but it's reached it's internal complexity limit and the open-to-closed issue count is not promising.
Nowadays Microsoft's Koita is an option.
https://github.com/microsoft/kiota

New commits were made 2 weeks ago and version bumped to 14.0.8. Can we close this issue now or is there still a reason to believe the project is basically dead?

I would say it's still a problem because of the 1.8k open issues.
4 commits per month not going to solve the problem. (Even if each commit were to clear 10 issues.)
It looks like with current velocity it would require years of effort just to go through the current backlog.
It seems to be the sad reality of many a popular OSS project lately, without financial backing.
Also, it's not fair to expect Rico to work through 1.8 issues (even paid, let alone free).
I would agree, Rico has generated millions in value, but here we are.
Code frequency

https://github.com/RicoSuter/NSwag/graphs/commit-activity

With only a few months before .Net 6 goes end-of-life, I have to wonder if it is time to move on from NSwag.
I've spent several hours today, trying to understand why NSwag is unrolling DTO classes that were not being unrolled under .net 6, and have gotten nowhere.
An issue I created back in February (https://github.com/RicoSuter/NSwag/issues/4791) has no responses, other than my own and one other asking if I found a work-around.
I know we can't be the only ones encountering this with Typescript....
I have experimented a bit with OpenAPITools/openapi-generator-cli, in a smaller project, and while it isn't perfect, it doesn't do this class unrolling from REST APIs that is our biggest issue with NSwag.

With only a few months before .Net 6 goes end-of-life, I have to wonder if it is time to move on from NSwag. I've spent several hours today, trying to understand why NSwag is unrolling DTO classes that were not being unrolled under .net 6, and have gotten nowhere. An issue I created back in February (#4791) has no responses, other than my own and one other asking if I found a work-around. I know we can't be the only ones encountering this with Typescript....
I have experimented a bit with OpenAPITools/openapi-generator-cli, in a smaller project, and while it isn't perfect, it doesn't do this class unrolling from REST APIs that is our biggest issue with NSwag.

We also made the switch to OpenAPITools/openapi-generator-cli, keeping the old working generated NSwag API in its current state while we transition over. It's too bad but at this point I think it's the best option. So far everything works as expected.


Automatically update dependencies

Description of changes

Code Checklist

[ ] I have added tests
[ ] I have provided documentation

Visual changes

Before

After

@dependabot badge me


Update ru.yml

add missing quote symbol in russian locale file

Travis is crush with message
"NoMethodError: undefined method `spec' for nil:NilClass
An error occurred while installing kaminari-i18n (0.3.2), and Bundler cannot
continue."
but, i change file right. Add leading quote to yml.


[ACC] Revocation fails for ES

Description
We have revoked sample codes from DE and from ES.
DE QR codes are correctly displayed as revoked when scanned.
ES QR codes are shown as valid although revocation batch exists on ACC
Expected behaviour
Revoked QR codes should appear as revoked
Steps to reproduce the issue
Go to https://github.com/eu-digital-green-certificates/dcc-quality-assurance/pull/289/files
Scan the QR codes.
They will appear as "revoked"
Go to https://github.com/eu-digital-green-certificates/dcc-quality-assurance/pull/291/files
Scan the QR codes.
They appear as valid
Additional context
The ES revocation was uploaded for all 3 possible hash types.
We have successfully downloaded the ES revocation batches and have calculated the hashes again with the same tool that we had used for the creation of the DE batches

HashType
downloaded from Gateway
calculated with our tool

UCI
dNImhq2X3oucVgB/BFzWqQ==
dNImhq2X3oucVgB/BFzWqQ==

UCI
P4nd4fPW4wjQOqv8VWdxBw==
P4nd4fPW4wjQOqv8VWdxBw==

COUNTRYCODEUCI
1mezczKV+kEAWCO/OvGCIQ==
1mezczKV+kEAWCO/OvGCIQ==

COUNTRYCODEUCI
8UkOPm68IaJFL7Bmk+VULw==
8UkOPm68IaJFL7Bmk+VULw==

SIGNATURE
Iv6IF+ZY4jHSKJGoJTGtZw==
Iv6IF+ZY4jHSKJGoJTGtZw==

SIGNATURE
1Zb/UkR8IxVakSB/NoZS/A==
1Zb/UkR8IxVakSB/NoZS/A==

Batches on ACC:

ID
Country
timestamp
deleted

d9e1b534-3f66-44d1-9776-18ca9ba8b0ef
ES
2022-03-01T18:59:14+01:00
False

793ca1ac-f79f-4194-b1de-a7f63cc307b1
ES
2022-03-02T00:59:22+01:00
False

b4ef3aca-5446-420e-8764-4a2635f51e9b
ES
2022-03-02T06:59:28+01:00
False

58fdc85a-d95e-411b-8c83-5ea8e4da56ce
ES
2022-03-02T10:35:42+01:00
False

175cc1f5-f938-41d0-a151-a0004ddfc39c
ES
2022-03-02T10:46:20+01:00
False

Hi @chrloch
For DE certificate. Signature type hash was found in one slice. So result is certificate revoked. Logs:
Revocation check start
SIGNATURE Hash: ef476f527e985c204e7e170eb892f375
Slice found: DccRevocationSlice(sid=3a87462201e5c634a8da31ebbddd48e703fd65e3119f9466a5c07c2b5ef40b34, kid=9cWXDDA52FQ=, x=null, y=null, cid=e, type=BLOOMFILTER, version=1.0, expires=2023-03-01T11:00Z, content=[0, 1, 67, 0, 43, -116, -68, -52, 0, 0, 0, 2, 0, 0, 0, 2, 0, 0, 0, 6, 89, 8, 71, -108, 85, 61, -43, -43, -121, 49, 64, 41, -68, -77, -111, -72, -42, 51, -90, 69, -90, 42, -126, 126])
dcc revoked bloomfilter: ef476f527e985c204e7e170eb892f375
Revocation check end. uci:false, co+uci:false, signature:true

And for ES certificate revocation flow fails on first step where we check KID metadata: B4BbJQx1lYQ= no such KID in database.
Available KIDs from backend:
[
   {
      "kid":"9cWXDDA52FQ=",
      "mode":"POINT",
      "hashTypes":[
         "SIGNATURE"
      ],
      "expires":"2023-03-01T11:00:00Z",
      "lastUpdated":"2022-03-04T16:08:49Z"
   },
   {
      "kid":"zMq8VEXlueo=",
      "mode":"POINT",
      "hashTypes":[
         "SIGNATURE"
      ],
      "expires":"2022-07-28T21:00:00Z",
      "lastUpdated":"2022-03-04T16:08:45Z"
   },
   {
      "kid":"iWk60lLc9eY=",
      "mode":"POINT",
      "hashTypes":[
         "SIGNATURE"
      ],
      "expires":"2022-03-10T12:00:00Z",
      "lastUpdated":"2022-03-06T16:28:57Z"
   },
   {
      "kid":"/JdNkm+G0Fg=",
      "mode":"POINT",
      "hashTypes":[
         "COUNTRYCODEUCI",
         "SIGNATURE",
         "UCI"
      ],
      "expires":"2023-02-18T15:00:00Z",
      "lastUpdated":"2022-03-04T16:08:38Z"
   },
   {
      "kid":"VpHthrJRPZU=",
      "mode":"POINT",
      "hashTypes":[
         "COUNTRYCODEUCI",
         "SIGNATURE",
         "UCI"
      ],
      "expires":"2023-03-07T19:00:00Z",
      "lastUpdated":"2022-03-08T08:59:22Z"
   },
   {
      "kid":"GSXuNoyWGYo=",
      "mode":"POINT",
      "hashTypes":[
         "UCI"
      ],
      "expires":"2023-11-27T10:15:14Z",
      "lastUpdated":"2022-03-04T16:08:55Z"
   }
]

Hi @MykhailoNester
do you use a different database in the revocation service than for the verification?
The KID B4BbJQx1lYQ= is on the gateway and the Verifier App can get it from its backend because it validates the DCCs as green which are signed with it.

The Batches seem to be missing in the validation service


Handle directory permission error

:Release Notes:
Handle directory permission error
:Detailed Notes:

Mac(M1) shows "EROFS" error when ares-device negative case executed
with read-only files system path so that CLI Unit test failed.
Change the TC to get the same error text on Windows, Linux and Mac
Add "EROFS" CLI tips message
Fix "ares-device -c /" error message

:Testing Performed:

Passed CLI Unit test
Passed ESlint
Give ares-device -c with the read-only file system path on Mac(M1)

$ ./ares-device.js -c /
$ ./ares-device.js -c /rootDir
[Info] Set target device : rpi4
ares-device ERR! [syscall failure]: EROFS: read-only file system, [open/make] 'FILEPATH'
ares-device ERR! [Tips]: Please check if the path is writable <FILEPATH>

Give ares-device -c with the "root(/)" path on Linux

$ ./ares-device.js -c /
$ ./ares-device.js -c /rootDir
[Info] Set target device : rpi4
ares-device ERR! [syscall failure]: EACCES: permission denied, [open/make] 'FILEPATH'
ares-device ERR! [Tips]: No permission to execute. Please check the directory permission <FILEPATH>

:Issues Addressed:
[WRN-2744] Handle directory permission error

Code :+1:
Verified :+1:

Code :+1:
Verified :+1:


Send X-Hubmap-Application header to entity-api

All POST and PUT to entity-api from the ingest-api will need to send this X-Hubmap-Application header with the value ingest-api to entity-api on creating new Dataset and Submission (before the renaming) via POST, also updating the Dataset.status via PUT. (edited)

Addressed via PR #34


qqqq

Precondition
Primal precondition
Steps to Reproduce:
Step 1  [Pass]
and 4 now
Expected Result
With expected
Step 2  [Pass]
nr foour
Step 3  [Pass]
brand new onw
Expected Result
Is here
Step 4  [Pass]
Thirrrr
Expected Result
styy

Open Defect in TestQuality

Test Testing steps and more in Run Run 597 (linked to Cycle All tests).


Re-ask of log into my tenant again

I still have the bug that every time I am opening up the API Center extension it wants me to log into my tenant again. And then I always get this error message:

https://github.com/microsoft/vscode-azureapicenter/pull/265

Hi @juliajuju93 now you may access the latest API Center preview to try, and this preview resolved this error


.gitignore

Should we mention ignoring bundled/minified assets from source control?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f55e9a-cd3f-83a0-f142-969dc10d3ceb
Version Independent ID: f6845f70-1ac6-2036-f213-a3b665b3d8bf
Content: Bundle and minifiy static assets in ASP.NET Core
Content Source: aspnetcore/client-side/bundling-and-minification.md
Service: unspecified
Product: aspnet-core
GitHub Login: @scottaddie
Microsoft Alias: scaddie

Was bundling and minification removed or replaced from ASP.NET Core MVC 2.1 RC1? When you create a new project it now longer creates a bundleconfig.json file.

That's a decision the repo owner makes.