jemalloc failure on raspberry pi 5

Describe the bug
Running on a raspberry pi 5, there are 16KB page sizes which breaks the jemalloc configuration on quickwit
It won't run, here is the output;
./quickwit-v0.8.0/quickwit --help
<jemalloc>: Unsupported system page size
<jemalloc>: Unsupported system page size
memory allocation of 5 bytes failed
Aborted

confirmation of the page size;
$ getconf PAGE_SIZE
16384

Steps to reproduce (if applicable)
Steps to reproduce the behavior:

follow the installation instructions on a raspberry pi 5
watch it crash

Expected behavior
It should run as per the instructions
Configuration:
Please provide:

Output of quickwit --version

n/a because this crashes but the version i was running is 0.8.0 on aarch64-unknown-linux-gnu (7afa596)

The index_config.yaml

n/a

note there is a temporary workaround which is adding the line kernel=kernel8.img to /boot/firmware/config.txt and rebooting.
you can confirm the fix has applied by
$ getconf PAGE_SIZE
4096

and then
./quickwit --version
Quickwit 0.8.0 (aarch64-unknown-linux-gnu 2024-03-18T15:20:23Z 7af4596)

dumping some observations:

cross-compiling with JEMALLOC_SYS_WITH_LG_PAGE=16 should make things work on a 16k page system, and not break on 4k according to https://github.com/home-assistant/docker-base/pull/248. (we probably want 16 and not 14 because BCM2712 reportedly default to 64k pages). I don't know the exact tradeoff, but i guess this would cause jemalloc to allocate slightly more than required
cross-compiling without --features jemalloc (which is implied by --features release-feature-set) would use system allocator and not cause issue. In my experience, GNU allocator tend to bloat a lot with rust, so targetting musl instead of gnu might be a decent idea too.
compiling directly on a system with PAGE_SIZE=16384 should also work as jemalloc auto-detect host's configuration.

A simpler alternative would be to compile without jemalloc. It is an optional  feature of quickwit.


Update snippet

#431

@KamilSzostak,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Add more test cases for GET requests

Adds test cases for a GET requests, checking 200, 400, 401 and 403 responses.

also moves some of the logging into helper functions

I have made the changes

Ok. Can you reply to my question about getLogger, and also explain the changes to the CloudRecordSummaryView  in PR description please?

updated


Lazy import dask libraries.

Close https://github.com/dmlc/xgboost/issues/6282 .

One downside is type annotation on function is not possible now.


handleSummary() failed with error "TypeError: Not a function: [object Object]"

Hi Bro,  I am running with --compatibility-mode=base, got below error
handleSummary() failed with error "TypeError: Not a function: [object Object]", falling back to the default summary  source=console
here is my code quiet simple just follow the demo
const htmlReport = require("https://raw.githubusercontent.com/benc-uk/k6-reporter/main/dist/bundle.js");
exports.handleSummary =  function (data) {
    return {
        "summary.html": htmlReport(data),
    };
}

k6 v0.36.0 ((devel), go1.17.6, darwin/arm64)

any update on this?

Not touched k6 or this code in a few years, what is --compatibility-mode=base ?

what does  --compatibility-mode=base  mean?

tried with both - K6_COMPATIBILITY_MODE=base and K6_COMPATIBILITY_MODE=extended.
its same error.


Invalid CSS in grid-overlay

The files lib/plugins/remote-debug/overlay-grid/css/grid-overlay-horizontal.css and lib/plugins/remote-debug/overlay-grid/css/grid-overlay-vertical.css contain invalid CSS. It seems like they're meant to be parsed at some point, but at the moment they are distributed out to NPM unparsed.
How to reproduce
$ npm install browser-sync
$ cat node_modules/browser-sync-ui/lib/plugins/remote-debug/overlay-grid/css/grid-overlay-*.css

Apparently they're parsed dynamically during execution: https://github.com/BrowserSync/UI/blob/d96e96f0e8785762a030d796846c19b7324bfa9d/lib/plugins/remote-debug/overlay-grid/overlay-grid.js#L9


Clearer hvac_action

(My deduction is as follow.. )
Expected Behaviour:
When hvac_mode changes, hvac_action value should be checked against the hub and updated accordingly.  (As per Wunda app behaviour)
E.g.
When hvac_mode changes from Auto to Off where the hvac_mode was 'heat', then the hvac_mode when checked should now be reporting as 'off'.
When hvac_mode changes from Off to Heat, then hvac_action should also be reporting as 'heat'.
When hvac_mode changes from Off to Auto (where schedule requires heat), then hvac_action should be reporting 'heat'.
Current Behaviour:
When hvac_mode changes, hvac_action doesn't appear to be be checked/updated. hvac_action appears to update a number of minutes later.
This causes confusion as it's reporting incorrect status, whereas the Wunda app reports this instantly.

Do you have pump delay enabled? I think the default is 2 minutes. What I'm wondering is if the flag that I assumed meant heat demand actually means 'pump on', which would explain why you're seeing the two go out of sync for a couple of minutes.

Yep I have a 3 min pump delay on my connection box.

Ok that makes sense then :) I kinda like this behavior more than the wundasmart app as it's giving you a bit more information about what's actually going on. The heating isn't really heating until the pump comes on, so having the hvac_action lag until the pump comes on makes sense to me.
I'm not sure what the wundasmart app is doing, but I suspect it's something simple like saying it's on if the temp is below the set temp - I seem to remember reading that what's displayed in the app doesn't take the switching differential into account either, whereas this should.
What do you think? Maybe you could just change your card to display exactly what you want using a combination of both the mode and the action? FWIW I'm using the mini-climate-card (https://github.com/artem-sedykh/mini-climate-card) which lets you do all sorts of custom logic to show different icons etc based on different states.

My findings above were for TRV controlled rooms rather than UFH ones (didn't test on UFH). I assumed that TRV controlled rooms would have no delay, hence my assumption that the library wasn't checking the heat status at the right time - my bad. But it makes sense for there to be a delay to allow for the valve to open etc.
I understood the pump delay to be set per smart connection box to control the pump relay at that manifold. I wonder if the TRV delay is hardcoded in... but either way doesn't matter for the scope of this issue.
I agree that accurate representation of whether heat is being outputted is best. Would be great to know if heat is being requested but not yet delivered (e.g. pump delay). It looks like there are 'preheating' & 'idle' states available for hvac_action in HASS - do you think one of these are appropriate?

Yes I think using the idle state is probably the right thing to do :) preheating is already used for the adaptive start feature, but using idle to mean 'not off but not currently heating' seems good to me. I'll go ahead and make that change 👍

Just tested this & it works as per the commit description.
I was actually envisaging different behaviour - let me know what you think..
HVAC action to give as much context to whether heat is being demanded or not. So:
heat: 4 = hvac action - off
heat: 7 = hvac action - on
heat: 6 = hvac action -  idle
My thinking is - whether the heating is off via auto/schedule or off via manual it's then the same hvac action state, as the outcome for the user is the same (same behaviour before the commit).
However - idle is then used to give immediate feedback that the system is in-between off & heating states (e.g. for switching differential & pump/TRV delay). This addresses the lack of feedback observed in the initial issue and gives clearer context that something is in fact happening. The Hass iconography for idle state seems to work well for this use case - i.e. idle waiting for next state:

What do states 7 and 6 mean? I've not seen those before.
7 = 00000111
6 = 00000110
# tp appears to be the following flags:
# - 00000001 (0x01) indicates a manual override is set until the next manual override
# - 00000100 (0x04) indicates the set point temperature has been set to 'off'
# - 00010000 (0x10) indicates a manual override has been set
# - 00100000 (0x20) indicates heating demand
# - 10000000 (0x80) indicates the adaptive start mode is active

So 7 is 0x1 | 0x2 | 0x4, set point = 0, ???, manual override until next manual override
and 6 is 0x2 | 0x4, set point = 0, ???
Looks like the only difference between 6 and 7 is whether you've set the manual override to be until the next manual override or until the next scheduled change, so I don't think that should result in a different hvac action (and according to my current understanding of the flags, both should show as off)

Prior to your library I used to poll for the 'heat' value of a room:
syncvalues.cgi:
121;1699974009;t_lo:16.00;t_norm:18.00;t_hi:19.00;heat:4;temp_pre:0;prg:2;lock:0;temp:18.00;ntemp:19.00;ntime:1699997400;es_avgtime:0;zone:2;relays:0;hb0:0;hb1:0;enable:121;tmax:27;tmaxh:5;settime:7200;pic:1;loc_in:1;loc_out:3;alarm:0;name:Bedroom;tbl:ffffffffafaaaaaaaaaaeaffffffffffafaaaaaaaaaaeaffffffffffafaaaaaaaaaaeaffffffffffafaaaaaaaaaaeaffffffffffafaaaaaaaaaaeaffffffffffafaaaaaaaaaaeaffffffffffafaaaaaaaaaaeaff;
or via
/getregister.cgi?121@heat
<cmd status="ok"> <device id="0"> <reg vid="121" tid="heat" v="4" min="0" max="65535"/> </device> </cmd>
My observations from deduction were as follows:
4 corresponds to off
7 corresponds to heat is being delivered
6 corresponds to heat not yet delivered (pump delay & I believe switching dif)

Ok thanks, when I get time I'll fiddle around and see what other values heat can be set to, but seems like that might be a better field to use for the hvac action 👍

@mutasim seems to work ok, let me know how you get on

Nice one - seems to do as expected. Will keep an eye on it over the week and report back if I spot any quirks


cmd/compile: debugger support for range-over-func

Range-over-func (https://github.com/golang/go/issues/61405) statements are going to be compiled into closures passed to the iterator function. I.e. the following code:
for range f {
    body
}

becomes:
f(func() {
    body
})

Delve (and potentially other debuggers) needs a way to correlate the stack frame where the body's closure is executing with the stack frame that it logically belongs to (the "parent" frame), for two reasons:

to display variables from the parent frame while the the program is stopped inside the loop's body
to make stepping work seamlessly (i.e. step-over from the header line of the loop will move to the first line of the loop's body)

We have discussed during the go team/delve meetings possible solutions for this and the current plan is to keep the closure struct alive and make it accessible through a specially named variable DIE.
This issue is to track this problem (and also for cases where the binary is optimized and a lot of inlining happens to the range-over-func statement).
cc @derekparker @dr2chase

Thanks for filing this tracking issue.

Discussed with @aarzilli , @derekparker , and other Delve contributors, we think that there are two parts:

Give special name for the range body closure, so the debugger can identify which functions are range body closures. This is addressed in CL https://go.dev/cl/584596 , which gives range body closure name (say) F-range1, instead of the regular closure name F.func1.
Keep the closure pointer live on stack with a special name, so the debugger can find it, and from there find the outer function. This is done in CL https://go.dev/cl/586975 , which keeps the closure pointer live on stack with the name .closureptr.

These two should have addressed the issue. If it turns out that this is not sufficient, feel free to reopen. Thanks!


update copyright in 2022.x

update copyright

There are some files missing to modify? There are some time of files is 2013-2019, such as module of spring-cloud-alibaba-commons. Please check again carefully!

There are some files missing to modify? There are some time of files is 2013-2019, such as module of spring-cloud-alibaba-commons. Please check again carefully!

ok!

There are some files missing to modify? There are some time of files is 2013-2019, such as module of spring-cloud-alibaba-commons. Please check again carefully!

ok!

There are still same problem mentioned above. Please check carefully, such as rocketmq-examples.

/**
* Delete configuration.
*
* @param dataId dataId
* @param group group
* @return boolean
*/
@RequestMapping("/remoteConfig")
public boolean remoteConfig(@RequestParam("dataId") String dataId,
@RequestParam(value = "group", required = false) String group)
throws NacosException {
if (StringUtils.isEmpty(group)) {
group = DEFAULT_GROUP;
}
ConfigService configService = nacosConfigManager.getConfigService();
return configService.removeConfig(dataId, group);
}
The function name cannot express the intention of deleting the configuration. "Did you misspell 'remove' as 'remote'?"

/** * Delete configuration. * * @param dataId dataId * @param group group * @return boolean */ @RequestMapping("/remoteConfig") public boolean remoteConfig(@RequestParam("dataId") String dataId, @RequestParam(value = "group", required = false) String group) throws NacosException { if (StringUtils.isEmpty(group)) { group = DEFAULT_GROUP; } ConfigService configService = nacosConfigManager.getConfigService(); return configService.removeConfig(dataId, group); }
The function name cannot express the intention of deleting the configuration. "Did you misspell 'remove' as 'remote'?"

Yes, welcome to create relevant PR to fix them.


Standalone dependent resource of type CRUDNoGCKubernetesDependentResource not deleted after removal of primary custom resource

Hello,
We're writing an Operator and so far we've chosen to use the standalone dependent resources option in our Reconciler implementation. We were initially using the CRUDKubernetesDependentResource as the main class, that we extend in our dependent resources, but we've decided to switch to CRUDNoGCKubernetesDependentResource, in order to avoid the inability to have cross-namespace owner references, because we have cases, where we have dependent resources outside of the namespace of the primary custom resource and cluster-scoped resources, like ClusterRole, which also can't have an owner reference to a namespaced custom resource.
However, the issue we're facing now is when deleting the primary custom resource, the respective dependent resources aren't removed from the cluster. As far as I understood from the docs and observed in the cluster, when using CRUDNoGCKubernetesDependentResource, the mapping between the primary and dependent resources is achieved through a couple of annotations, that are inserted into the metadata of every dependent resource. Having said that I'd like to ask you the following questions:

What is the best approach to properly cleanup the standalone dependent resources when their primary resource is deleted? Is it a valid case, if we implement the Cleaner interface in our reconciler and we manually delete each dependent resource by calling it's delete(P primary, Context<P> context) method, which is defined in AbstractDependentResource? Will the the framework have any troubles figuring out exactly what dependent resource to delete, in the case we have more that one primary custom resource in the cluster?
Is there any way to customize the keys of the annotation, that are inserted into the dependent resources, when they're of type CRUDNoGCKubernetesDependentResource or they must be hard-coded to io.javaoperatorsdk/primary-name and io.javaoperatorsdk/primary-namespace?

Environment
Kubernetes cluster type: Kubernetes v1.25.3 on Minikube v1.28.0
$ Mention java-operator-sdk version from pom.xml file
4.4.2
$ java -version
openjdk version "17.0.8" 2023-07-18 LTS
$ kubectl version
1.25.0

Hi @ivanchuchulski

yes, in this case the cleaner should be implemented and explicitly called on the workflow / dependent resources. Framework should figure out the rest.

As far I can see now, it is not trivial to configure the names of the annotations now. It should be, will create an issue for that and imlpement it for the next minor release.

see: https://github.com/operator-framework/java-operator-sdk/issues/2074

Prepated the PR with a sample: https://github.com/operator-framework/java-operator-sdk/pull/2075


simplify

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

23 of 23 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.777%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1066

Relevant Lines:
1113

💛  - Coveralls


Don't allow rollover that is too close to expiry

When writing tests we noticed, that we will have unpredictable behaviour allowing rollover that is too close to the expiry time.
@thomaseizinger we discussed hat earlier and I implemented it, but then came to the conclusion that we should not use it.
I still add it as a draft up for discussion.
Here's my reasoning:
The taker should be able to propose a rollover until the very last second. If the maker already committed, the maker already committed. The rollover should be rejected then (rollovers should only be accepted if we are in an open state, once committed we can't roll over anymore).
I think that behaviour is resilient enough and we don't have to introduce a too_late_to_rollover - I don't think it would add value. From a taker-UX point of view: We need feedback from maker->taker upon rejection. If there is no feedback then the UX will suffer. But I would solve that by sending proper errors over rather than introducing this interval.
If I am missing something please let me know.

closing because I don't think we need it


How Many Days Between Two Dates

Before jumping into Pr first comment for assign.
Problem statement :Create a function that takes two dates and returns the number of days between the first and second date.
Probelm Link : https://edabit.com/challenge/3hdXjfJozQySRC3gE
Choose one Cateorgy - Very Easy, Easy, Medium, Hard, Very Hard, Expert
question category : Hard

Before submitting a PR please Check some details.

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Choose label for Problem , example- "good first issue", "hard"
[ ]  In file there should be problem statement and link to problem

/* Problem-Task : This program will give the days between two dates
 * Problem Link : https://edabit.com/challenge/3hdXjfJozQySRC3gE
*/
int main() {
    int bla;
    return 0;
}

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

Can I work on this issue.

Can I get this task?

i can give it a shot

I would like to give the c++ approach to this question.


A question about Shannon entropy

Why should minimize Shannon entropy？The performance is better, the Shannon entropy is bigger?

Why should minimize Shannon entropy ?

Shannon Entropy is used in applications where you have access to unlabelled data. Assuming the classifier you have is already good enough, mininmizing the entropy on unlabelled predictions helps the classifier "refine" its boundaries (by forcing him to have low-entropy, i.e. high confidence predictions on unlabelled data). Please refer to our full explanation in the paper https://arxiv.org/abs/2012.06166.

The performance is better, the Shannon entropy is bigger ?

Not necessarily, Shannon Entropy does not tell you if your classifier is good or bad, it simply tells you if it's predictions are confident or not. In the case where the initial classifier is good already, minimizing the entropy will generally improve perfs, but that's not a golden rule. If the initial classifier is bad, chances are that minimizing the entropy will just make things worse in terms of performances.

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

Thanks!

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


feat: add proof predicate evaluation

Summary of Changes
Evaluates if proof predicates are satisfied. If not satisfied, displays an error message.

Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[X] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[X] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[X] Updated documentation as needed for changed code and new or modified features;
[X] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Is it possible to change the wording so it's more plain language? for example: The content above from "you do not have data that satisfies the predicate" to: "You do not meet the requirements of this proof request from [verifier name]" and the message below the attribute from "Predicate not satisfied" to "Requirement not met"?


Скласти таймлайн

Скласти список всіх (важливих) життєвих подій, визначних дат, досягнень, періодів, що дали приємний і неприємний досвід, тощо. В цьому конкретному випадку довгих списків не буває, натомість бувають погано згорнуті, тому пакуємо сюди все підряд, а про "лишні" події можна буде промовчати пізніше. Список повинен бути систематизованим і посортованим в такий спосіб, щоб читач швидко зрозумів "паттерн" і міг легко орієнтуватись в просторі і часі цього резюме.

CAREER
2003–2006
I got my first stint in show-business as friend and stylist of Paris Hilton, appearing as guest on various episodes of the Hilton-starring reality television series The Simple Life.
2006–2007
Entered the business world with my two sisters and opened the boutique shop D-A-S-H in Calabasas, California. In October 2007 in addition to my mother Kris Jenner, my step-parent Caitlyn Jenner, my siblings Kourtney, Khloé, and Rob Kardashian, and half-sisters Kendall and Kylie Jenner, I began to appear in the reality television series Keeping Up with the Kardashians. The series proved successful for E!
That December, posed in a nude pictorial for Playboy.
2008
Made my feature film debut in the disaster film spoof Disaster Movie, in which I appeared as a character named Lisa. That same year, I was a participant on season seven of Dancing with the Stars.
2009
In January I made a cameo appearance during an episode of the sitcom How I Met Your Mother, in the episode "Benefits".
In April, I released a workout DVD series through my television production company Kimsaprincess Productions, LLC which has seen the release of three successful workout videos, Fit in Your Jeans by Friday, with trainers Jennifer Galardi and Patrick Goudeau. Played Elle in four episodes of the television series Beyond the Break.
In August I became a guest host of WrestleMania XXIV and guest judge on America's Next Top Model.
In September, Fusion Beauty and Seven Bar Foundation launched "Kiss Away Poverty", with me as the face of the campaign.
In October I released my first fragrance self-titled "Kim Kardashian".
In December I made a guest star appearance on CBS's CSI: NY with Vanessa Minnillo.
2010
In January 2010, I starred as Summa Eve in the film Deep in the Valley.
In April, sparked controversy over the way I held a kitten for a photograph, holding it by the scruff of its neck.
June saw me guest star with Khloé and Kourtney as themselves on the season three premiere episode of the series 90210.
On July 1, the New York City branch of Madame Tussauds revealed a wax figure of me.
In November, I served as producer for The Spin Crowd, a reality television show about Command PR, a New York City public relations firm, run by Jonathan Cheban and Simon Huck.
In December, filmed a music video for a song titled "Jam (Turn It Up)".
2011
Released my third fragrance "Gold"
2012
Debuted my fourth fragrance, titled "True Reflection", which I worked with the company Dress for Success to promote.
In April, E! renewed Keeping Up with the Kardashians for two additional seasons, in a deal reported to be worth $50 million.
In October, I released my fifth fragrance, "Glam", which "draws on the glamour of my Hollywood lifestyle", and was made available through Debenhams.
In summer, my family and I filmed a music video in the Dominican Republic to Notorious B.I.G's song "Hypnotize".
2014
I appeared on the cover, and in a pictorial in Paper's winter issue in 2014 photographed by Jean-Paul Goude. On the cover, my nude buttocks are featured above the caption: "Break the Internet", which generated considerable comment in both social and traditional media.
In June, released a mobile game for iPhone and Android called Kim Kardashian: Hollywood. The objective of the game is to become a Hollywood star or starlet.
2015
I was the cover model for Vogue Spain.
2016
I was paid between $75,000 and $300,000 for each post that I made on Instagram, Facebook and Twitter endorsing beauty products like waist trainers, teeth whiteners as well as Coca-Cola and well known charities.
2017
Launched my own beauty line, KKW Beauty and in November I launched my own fragrance line, KKW Fragrance.
2018
Made a cameo appearance in the heist film Ocean's 8.
2019
Made waves at the Met Gala with her figure hugging corset-induced Thierry Mugler dress.
Personal life
2000
Eloped with music producer Damon Thomas.
2011
On August 20, I married NBA player Kris Humphries, only to file for divorce within 72 days of the wedding. The divorce was granted in 2013.
2012
Announced that I was pregnant with rapper Kanye West’s baby. We had been dating for a while.
2013
Gave birth to daughter North West at the Cedars-Sinai Medical Center in Los Angeles. The same year, I became engaged to Kanye on my 33rd birthday.
2014
Kanye West and I got married formally in Florence, Italy, on May 24.
2015
My second child, son Saint West, was born on December 5. After my second child, I was advised against becoming pregnant again.
2018
My third child, daughter Chicago West, was born via surrogate on January 15.
2019
In January, I announced that a second boy is on the way via surrogate.


NO-JIRA: test/e2e: move pre-removal metrics validation out teardown path

Currently, failures in e2e test cluster infra creation generate a red herring error on Teardown/ValidateMetricsAreExposed
    util.go:1453: Expected results for metric "hypershift_cluster_silence_alerts", found none
    util.go:1466: Failed to validate all metrics
        --- FAIL: TestCreateCluster/Teardown/ValidateMetricsAreExposed (300.06s)

Examples:
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn/1864279699434246144
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn/1864006972760657920
https://github.com/openshift/hypershift/pull/4143 attempted to fix this but didn't work but t in this context is the Teardown subtest, which hasn't failed, not the main test, which has failed.
This PR moves the ValidateMetricsAreExposed check into the normal EnsureHostedCluster assertion path.
There is a second check here that is done post teardown to make sure the metrics go away, but it is not problematic as it does probably failure checking before executing.
https://github.com/openshift/hypershift/blob/857ccab4fd7c0118eca829f81f110bb76204a392/test/e2e/util/hypershift_framework.go#L185-L200

/lgtm
I think that's a good improvement, but just for the record, I believe the cleanup and teardown code in this file needs an overhaul. It's complicated and full of special conditions, which makes the reasoning of the code difficult.

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

/retest-required

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

/test e2e-aws-4-18

/lgtm

/retest


New Resource for Audit Rules (Issue #11)

I recently raised https://github.com/SNikalaichyk/cNtfsAccessControl/issues/11 and it turns out this was surprisingly easy. The new resource is basically a copy of cNtfsPermissionEntry but with all the relevant references updated for Audit rules.
There are some things that can be done better here such as moving Resolve-IdentityReference and Set-FileSystemAccessControl into a shared location for both resources to avoid code duplication but i thought it best to start this PR with this so far and get some feedback before altering the code already in place.
Let me know what you think. I have done some testing and all seems to work well.

Hi @mrhockeymonkey,
Thanks for the contribution! I am going to review it on the weekend.

Hello @mrhockeymonkey, unfortunately I haven't found enough time to properly test this PR. Can you please also try to add tests?

Hey @SNikalaichyk  sorry I haven't found time to do these tests just yet but I will do so.

Hey @SNikalaichyk , I finally found some time to do those tests. Again - not very inspired they are just re workings of your tests which were very thorough so all credit to you.

@mrhockeymonkey Merged, thanks for your contribution! This will soon be released to the PSGallery.

Appreciate both of your effort! Any idea when this will make it to PSGallery?

Hi @dave-pollock, I will release it this month.

@SNikalaichyk is there any way we can help get this released? Cheers!

Thanks @SNikalaichyk !!

@mrhockeymonkey @SNikalaichyk
I hit the error described here when NoPropagateInherit is set to true in cNtfsAuditRuleInformation: https://github.com/SNikalaichyk/cNtfsAccessControl/issues/5
I've created this PR to apply the same fix: https://github.com/SNikalaichyk/cNtfsAccessControl/pull/14


Service Matrix - S3: Added DigitalOcean Spaces and Minio

Digital Ocean Spaces
Minio

Thanks-- sounds good to me. Merging in.


Initial implementation for supporting user supplied authorizers

Decouples the SDK from the CLI via kwargs and callbacks
create_*_client helper functions are removed from the SDK layer
Added new_client classmethod to Client classes

@jimPruyne - still have some documentation/cleanup to do but this is what the implementation looks like. Each flow-action method now supports getting an authorizer via a kwarg but I also wanted to support the use case where there's a default way of looking up an authorizer via a callback. The CLI layer should function the same, SDK users may need to update their scripts depending on where they're importing things from/if they're fine using CLI level functions in their scripts.

@jimPruyne I made some updates based on comments, you're welcome to take another pass when you can.

I'm good with the info the NativeClient ID makes sense to me so adding it to the helpers is good. A couple of action items to keep track of:

make action provider toolkit tools not care about endpoints with trailing "/"
make flows endpoints not care about trailing "/"
potentially set "visible_to" on flows to be public


Seek uploaded file-like object to original position before retry (Fix for issue #459)

Fix candidate for #459. @sigmavirus24 can you check if this is good enough?
It doesn't attempt to do anything for non-seekable files. I'm not sure how to properly deal with those.

I'd still love to get this merged, any idea on what's outstanding?

It looks like this issue has been sitting for a while. I just did some work similar to this in Requests, and I'd be happy to try and replicate some of that over here.
Since this is a much more contained use case (single method) than Requests, would something like this work? It still needs a little more error handling and some of the logic would probably be nicer somewhere like util/request.py.
def urlopen(self, ... body_pos=None, **response_kw):

[...]

is_rewindable = (
    getattr(body, 'tell', None) is not None  and
    getattr(body, 'seek', None) is not None
)

# Make note of current file pointer position if available and
# not previously noted. If it's noted, set body to that position.
if is_rewindable and body_pos is None:
        body_pos = body.tell()
elif is_rewindable:
        body.seek(body_pos)

I know this is yet another parameter into an already crammed method, but the alternative solution of a BodyWrapper seems a bit over-engineered for a smaller edge case.

If we wrap any body then we're creating a new object for every request, when we'll only need it for a fraction of those.
If we create the object conditionally (has read, seek, tell? file-like superclass?) we're still adding the same logic as above and probably more to avoid the body_pos param.

Are there are other use cases that would benefit from extracting a generalized body object out? If so, I may be being a bit hasty. It just seems like a generic body object will either be incredibly overloaded or unpredictable (e.g. sometimes it has attr_x, other times it won't)

@nateprewitt This should also be integrated into #1030

@SethMichaelLarson sure, I think we could get that worked out. What were you thinking is the best way to make that happen? Is there a need for recreating the generator in filepost, or is it because these are both related to streaming content?

@nateprewitt Just linking these two PRs as they're working on the same theme but different areas.  If this PR is merged in first then there may be change that I need to accommodate for in my PR and I want to be able to find it quickly. :)  Maybe it would be nice to integrate changes here into #1030 but I don't think that's necessary.

@SethMichaelLarson Alright :) Let me put together a few more commits on this to get things working I'll open a PR. Either way, there isn't much file overlap so I think the conflicts would be minimal, if they even exist. @Lukasa can I get a quick confirmation that the above approach is one we'd be willing to consider?

It seems reasonable to me. =)

For the record, you may consider this PR abandoned from my end, sorry. Absolutely amazing that @nateprewitt picked this up! I'll be really happy if a fix lands to urllib3. 🎉

Always happy to lend a hand, @joneskoo 😊 Glad we can finally get your work into urllib3, thanks for providing these tests!

This can be closed since it was superseded by #1039.


Class to enable a custom image similarity metric defined in Python

Description
Enable creation of a custom similarity metric in Python. See the discussion here:
https://discourse.itk.org/t/is-there-a-way-to-set-custom-metric-in-itk-registration-in-python/705/7
Expected behavior
A convenient way to define an image similarity metric in Python that re-uses the ITK image registration frame, i.e. optimizers, transformations, multi-resolution capabilities, regularization.
Actual behavior
The registration metric must be implemented in C++.
Additional Information
Possible implementation:
An itk.PythonImageRegistrationMetricv4 class would be similar to itk.ImageToImageMetricv4, but it would have additional methods,

GetValuePythonCallback
GetDerivativePythonCallback
GetValueAndDerivativePythonCallback

These methods would be passed Python functions that accept the ImageToImageMetricv4 as an argument and would need to return required value and derivative values.
See also the class for defining a custom ITK filter in Python:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Wrapping/Generators/Python/PyUtils/itkPyImageFilter.h

Hi developers, for my thesis I would like to perform registration with my own custom metric (Frechet distance function). I have looked around online and this issue seems to be the only place that really mentions anything close to what I want. I see that this has been on the backlog for some years, do you think that this will by any chance be finished soon? Or if not, does anyone have a suggestion on an alternative method I could use?

Hello @JaroKuiken,
This discussion describes how to add a metric to ITK and then to SimpleITK. Unfortunately, it requires implementation in C++ and you appear to be looking for a path forward in Python. If you are able to implement it in C++ then you have an immediate path forward. If not, I don't think the timeline for this feature will be short enough so that you can use it in your work. I may be wrong here, @thewtex will have a better idea with respect to timeline for ITK 6.0.0.


Individual files can't be changed from LGPL to dual license with BSD

Since you don't fully own the copyrights to the original work there are licensing restrictions on the files and the combined work.
LGPL does allow the linking of LGPL files with more files that use lax licenses such as BSD; however, there are some incompatibilities so you can't use a dual license of LGPL and BSD on a single file.
i.e. LGPL is not as permissive as BSD and you can't convert LGPL licensed s/w to BSD even if you modify it into a derivative work.
Read section 2 of the LGPL license specifically 2c
i.e. the code started as LGPL 2.1+ , any modifications and updates to that code must be licensed LGPL 2.1+
Also, when you link BSD and LGPL licensed works together, the combined work inherits the requirements of LGPL so the more relaxed licensing of BSD is lost.
i.e. if you have a work that contains separate modules some BSD and some LGPL any work that uses them both would be subject to LGPL.
This library started with LGPL 2.1+ code so it isn't possible to modify the code to make it BSD.

The licensing is still an issue.
You have violated the original code's copyright and the LGPL license it was released under.

Hi @mathertel,
as @bperrybap suggested, being a derivative of a LGPL code base done from Arduino you are not entitled to enforce a different licensing, not even on a piece of a file.
I kindly urge you to modify the licensing or we'll be forced to delist your library and take further actions to take down this repository.
thank you in advance for your prompt reply.

Hi,
LGPL is problematic for many of us.
I just take into account to remove all LGPL lines and stay to the more open BSD license completely.
Give me 2-3 days to look into this.
/Matthias Hertel/
Von: Dario Pennisi
Gesendet: Montag, 3. Juni, 14:16
Betreff: Re: [mathertel/LiquidCrystal_PCF8574] Individual files can't be changed from LGPL to dual license with BSD (#4)
An: mathertel/LiquidCrystal_PCF8574
Cc: Matthias Hertel, Mention
Hi @mathertelhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmathertel&data=02|01||48b5faaef07c4f059b3608d6e81d4fff|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636951609922651262&sdata=xBEOG12R7GYce%2FTOcb%2FQArql57YLeX%2BBi5hUqN2er7w%3D&reserved=0,
as @bperrybaphttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbperrybap&data=02|01||48b5faaef07c4f059b3608d6e81d4fff|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636951609922661267&sdata=z6B71JVq%2F6%2FeMSyiYV%2FJn8sRvk47VOKiJb49ntarWcE%3D&reserved=0 suggested, being a derivative of a LGPL code base done from Arduino you are not entitled to enforce a different licensing, not even on a piece of a file.
I kindly urge you to modify the licensing or we'll be forced to delist your library and take further actions to take down this repository.
thank you in advance for your prompt reply.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmathertel%2FLiquidCrystal_PCF8574%2Fissues%2F4%3Femail_source%3Dnotifications%26email_token%3DAAIJTF43OHUEFBOTHHSAOJ3PYUDR5A5CNFSM4EEN6QQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZGXKA%23issuecomment-498232232&data=02|01||48b5faaef07c4f059b3608d6e81d4fff|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636951609922671272&sdata=qoKAXL6IuzM4PVfKF8BDL2cB%2BsRHIH2dwWvgMnrK4ls%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAIJTFZ5DE42ERAURP4ZTKLPYUDR5ANCNFSM4EEN6QQA&data=02|01||48b5faaef07c4f059b3608d6e81d4fff|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636951609922681283&sdata=4CFps0bZfyPOEzA3888XJ04zuL6M4UdSu0jfdJXEHac%3D&reserved=0.

hi @mathertel,
before you refactor Arduino code to look less like the original one (which honestly would not really make sense), i would like you to consider the following:

Arduino is releasing libraries with LGPL license in order to keep the ecosystem open. if you do something with Arduino you should share it with the same terms.
if your concern is on using your library on a commercial product for which you don't want to release code you have to know that Arduino is also proposing dual licensing. this means that if you want to keep your project closed source we can license you the file(s) with a different agreement. this would pay back our efforts in developing the ecosystem and allow us to develop more open source stuff everyone else will benefit from.

basically, long story short, even if you refactor the code, you should still consider where it comes from and why it was licensed that way; failure to restore original license will result in delisting of your library.

Hi,
thanks for the explanation.
I definitively do open source so your thoughts about my commercial closed source interests do not apply here.
I do not want any restrictions what people can do with it. I just want to license as is so nobody can  demand any recourse.
LGPL is more restrictive than BSD.
I know from my professional background from the nodejs environment that big companies are not allowed to use GPL or LGPL code for intern and external projects because of consequences that apply and cannot be fulfilled.
I don't care regarding my own work but people that use my library may.
My plan:
I do not want to reformat or do some refactoring that sounds like cheating.
I will take off all code that comes from the Arduino library. That is essentially the interface definition that I like to keep compatible. I will remove this and any other code and just keep the i2c and pcf specific code that is already isolated well in the source. This is the core of what is missing in the Original Library.
Then I will apply the interface given from the Arduino reference using the cc. That license is not restrictive at all I use it for my blogs and my web site as well. I will mention this in the sources.
If you like I can contribute this as well to the Arduino community as I do today to offer a robust library implementation to all boards that use I2c bus for io.
I hope you can see that this approach will keep the library available in the community.
/Matthias Hertel/
Von: Dario Pennisi
Gesendet: Montag, 3. Juni, 17:48
Betreff: Re: [mathertel/LiquidCrystal_PCF8574] Individual files can't be changed from LGPL to dual license with BSD (#4)
An: mathertel/LiquidCrystal_PCF8574
Cc: Matthias Hertel, Mention
hi @mathertelhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmathertel&data=02|01||af0a82a820f5469a5d5808d6e83af94d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636951737313895579&sdata=aO11wdJB4n8%2FtzeFkZQb%2FLlYGs9ydcZS3YnRrXwxWt4%3D&reserved=0,
before you refactor Arduino code to look less like the original one (which honestly would not really make sense), i would like you to consider the following:
Arduino is releasing libraries with LGPL license in order to keep the ecosystem open. if you do something with Arduino you should share it with the same terms.if your concern is on using your library on a commercial product for which you don't want to release code you have to know that Arduino is also proposing dual licensing. this means that if you want to keep your project closed source we can license you the file(s) with a different agreement. this would pay back our efforts in developing the ecosystem and allow us to develop more open source stuff everyone else will benefit from.
basically, long story short, even if you refactor the code, you should still consider where it comes from and why it was licensed that way; failure to restore original license will result in delisting of your library.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmathertel%2FLiquidCrystal_PCF8574%2Fissues%2F4%3Femail_source%3Dnotifications%26email_token%3DAAIJTF5IISX64WEV3AOI27LPYU4ODA5CNFSM4EEN6QQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZ2YWQ%23issuecomment-498314330&data=02|01||af0a82a820f5469a5d5808d6e83af94d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636951737313915595&sdata=%2BQEsAIsPn5AoanKm94n8EoHVwTyd4IpxOD2qkh5mLIw%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAIJTF3XZQVXJG4GWM5TKTDPYU4ODANCNFSM4EEN6QQA&data=02|01||af0a82a820f5469a5d5808d6e83af94d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636951737313925600&sdata=DAUAEoiPqRbHhS6stYD7RSg8Pg8i%2Fv%2FzN9hjaxhrgDw%3D&reserved=0.

Hi, LGPL is problematic for many of us. I just take into account to remove all LGPL lines and stay to the more open BSD license completely. Give me 2-3 days to look into this.

I would say the first thing you need to do, would be to immediately correct the license on the current code to be LGPL and re-release it ASAP to get back into compliance and to get the correct license into the library code being provided by the Arduino library manager.
Then figure out what you may want to do for other libraries.
LGPL licensing is not any less open than the BSD licensing. From a source code perspective, both are fully open source. BSD is definitely more liberal in terms of compatibility with certain closed source use cases and also offers authors the ability to not share modifications or improvements made to the original BSD licensed work.
If anything, BSD, given its less restrictive closed source compatibility, is actually less open which is why commercial entities like and prefer it over LGPL and particularly GPL.
While I understand your desire to want a more liberal  less restrictive license, there is no way to do what you wanting and trying to do for this library. You started with LGPL code and no matter how much you change and modify it, it is and will always be a derivative subject to the original licensing terms and must remain LGPL 2.0 or moved to a newer LGPL or GPL license.
And the current code, even though it says BSD, is actually licensed LGPL since it can not be changed to BSD.
Bottom line is that if LGPL really is problematic for you, then you probably should not be using any gnu build tools much less Arduino.
Keep in mind that a fully linked work, like an Arduino firmware image, must be compatible with all the licenses of the individual components and the overall linked work will be subject to the most restrictive license.
i.e. while it is possible to create a work that uses both BSD and LGPL licensed sources, the linked together work will still be subject to the LGPL licensing terms for the LGPL sources.
Arduino libraries like the core libraries, which are necessary when creating an Arduino f/w image, are licensed as LGPL. The LGPL license mandates that a user be able to update/modify/change the LGPL code. (see LGPL 2.0 license section 6a).
Currently, the Arduino way of handling that is to use the IDE to re-compile all the source code and link a new image.
While the license of the BSD component may allow certain use cases, those use cases might not be allowed in the final work once it is linked with code using other licensing terms and/or the build tools being used.
So while you may want to offer a BSD license for this library (which you can't given the code you started with), even if you could, it would effectively loose certain capabilities once it is linked with other LGPL modules and used to build an Arduino f/w image.
i.e. there is currently no way to create a completely closed source product/project using Arduino build tools since LGPL 2.0 mandates that users have the ability to update/modify/change any LGPL 2.0 code in the f/w image and currently the only way to do that is to recompile and re-link everything.
More recent IDEs do offer the capability to use a pre-compiled library, but it appears that is for an entire library not individual components within a library so I don't believe at this time that there is a way to fully satisfy LGPL 2.0 section 6a for closed source products when mixed licenses are used for a single library.
Given that the only real advantage of using BSD over LGPL is the ability to create a fully closed source product, and that can't be done with this library,  and you are intending to provide the library code as open source on github,  it seems strange to even pursue this.
And even if you were to completely re-write it all from scratch and license it as BSD, any Arduino project (f/w image) that uses it would still be subject to LGPL licensing terms for the other LGPL code used so it would still not offer users of the BSD licensed library the ability to create a completely closed source product without having to provide the user the ability to rebuild the f/w image with updated LGPL sources.
For closed source products/projects, Section 6a is often difficult and a pain to comply with, and with f/w it is even more difficult since the user must have a way to modify the sources, rebuild the image, and update the device with the rebuilt f/w. This is why commercial entities try very hard avoid LGPL and GPL code.

Then I will apply the interface given from the Arduino reference using the cc. That license is not restrictive at all I use it for my blogs and my web site as well. I will mention this in the sources

by cc are you meaning Creative Commons?
IMO, Creative commons is not a license that is suitable for library source code that is linked with other code.
CC licensing was originally intended for standalone works like published documentation, web pages, etc...
I have seen people use CC BY-SA  for source code, including Arduino libraries, but  that license is not compatible with anything other than itself.
IMO, it doesn't make sense since it is not compatible with LGPL or GPL unless you go to CC BY-SA 4.0 which has a one time convert clause that allows the user to convert the license to GPL 3.0 whenever it is used with or  linked with LGPL or GPL sources.
After the convert, it can never be converted back, so once converted, any future updates made to the code cannot go back as CC BY-SA 4.0 since the work was converted to  GPL 3.0 licensing.
It effectively means that the author is releasing the code as GPL 3.0 since anybody using the code must use the convert clause to convert to GPL 3.0  to be able to legally link it in with the other LGPL and potentially GPL code being used in the final linked image. (which will always be the case when using gnu compiler tools and Arduino)
This is more restrictive than LGPL 2.0 as GPL 3.0 brings on some additional restrictions than LGPL 2.0
IMO, of all the licenses for open source code, the CC licensing is one that should really be avoided, especially since there are several other alternatives of varying degrees of strictness that don't have the issue of the CC licenses.

re-implementation done.
Not based on prior work from LiquidChrystal.

Keep in mind that even though the library is now licensed as BSD, the users of this library will still have to conform to all the LGPL requirements for the other gnu and Arduino LGPL modules that are linked into the f/w image, most notably 6a which requires the ability for a user to be able update LGPL code in the f/w image.

Keep in mind that even though the library is now licensed as BSD, the users of this library will still have to conform to all the LGPL requirements for the other gnu and Arduino LGPL modules that are linked into the f/w image

Yes, but that is the problem of those users, iff they use other LGPL code. Correct?

Yes, but that is the problem of those users, iff they use other LGPL code. Correct?
Correct.
But there is no way to use this library without using and linking against any other LGPL code.
This library depends on other LGPL code (Arduino code) to work. The Arduino Print class to name just one. And then there is the Arduino core code, and various AVR gcc runtime library code and AVR libC code that ends up being used/link-in when building any/every Arduino sketch as well.

And contrary what the arduino.cc developers have said in the past about doing dual licensing, that really is not possible at this point in time as all sketches that are built for Arduino will end up using and linking against some amount of LGPL code and there is no way to provide a mechanism for users to be able to update the LGPL open source code portions of the f/w image, as required by LGPL 6a,  without providing the source code to everything.
In other words, currently there is no way to create a closed source Arduino based project/product and so releasing an Arduino library under BSD licensing terms, doesn't enable creating a project that uses it to be a closed source product/project.


update color vars for inputs

remove success, warning styles
add disabled color var, update input-border var
see https://github.com/cfpb/cf-forms/pull/37 for details

remove success, warning styles

Why?

Because they've been removed from the standard input styles in Design Manual, and removed from cf-forms in PR 37. cc @sonnakim

Per changes to teh cf-forms PR, those success/warning vars need to be restored here.


Remove rules_docker from project

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Nice improvement 👍
/approve


Fixed Code

updaed project to use TokenValidationParameters.ValidAudience instead of
Audience

Thanks. The code is taken into account.


Update @uirouter/core

This is a (check one box):

[ ] Bug Report
[x] Feature Request
[ ] General Query

My version of UI-Router is: 1.0.22
Feature Request
Could @uirouter/core dependency please be updated, so we get https://github.com/ui-router/core/pull/430 ?

https://github.com/angular-ui/ui-router/releases/tag/1.0.23


Incorrect information regarding VolumeSnapshot API in v1.24 upcoming removals article

This is a Bug Report

Problem:
Information regarding volume snapshot API in the following blog is not accurate.
https://kubernetes.io/blog/2022/04/07/upcoming-changes-in-kubernetes-1-24/#api-removals-deprecations-and-other-changes-for-kubernetes-1-24
Volume snapshot API moved to GA in 1.20, so volume snapshot v1beta1 was deprecated in 1.20.
Proposed Solution:
Information regarding volume snapshot API in this blog is correct:
https://kubernetes.io/blog/2022/05/03/kubernetes-1-24-release-announcement/#csi-snapshot
Please update the API Removals Deprecations blog accordingly.
Page to Update:
https://kubernetes.io/...

/retitle Incorrect information regarding VolumeSnapshot API in v1.24 upcoming removals article
/area blog
/language en
What is the correct statement about the fate of the v1beta1 API for VolumeSnapshot @xing-yang? When did (or will) that API version transition from deprecated to unsupported?

I suspect the fix is to edit:

VolumeSnapshot v1beta1 was deprecated in v1.21 and is now unsupported

to:

VolumeSnapshot v1beta1 was deprecated in v1.20 and will become unsupported once Kubernetes v1.24 is released.

Does that sound right?
/triage needs-information

@sftim
Change 1:

which provides standardized APIs design (CRDs) and adds PV snapshot/restore support for CSI volume drivers, entered beta in v1.20

Above has to be : [diff: beta to GA]
which provides standardized APIs design (CRDs) and adds PV snapshot/restore support for CSI volume drivers, entered GA in v1.20.
Change 2:

VolumeSnapshot v1beta1 was deprecated in v1.21 and is now unsupported.

Above has to be: [diff  v1.21 to v1.20]
VolumeSnapshot v1beta1 was deprecated in v1.20 ..

/assign

@sftim  I completely agree with the contexts that @xing-yang has shared.

New PR https://github.com/kubernetes/website/pull/34173 has been raised for this issue.


Arrays or Slices of Public structs not supported when tag is faker:"len=?"

Adding the tag faker:"len=1" on a slice of a Public struct returns the error "Unknown Type". Without tag, faker generates the slice perfectly fine.

I get the same problem

Hey guys, I will look into this soon, so busy lately 🙏
But if you have time, mind submitting the PR?

Hey @bxcodec thanks for responding!
So when I look back at this issue, I think I was looking for the wrong feature. It looks like the "len" tag establishes a desired length for strings in the tagged field (the field types that are currently effected by this tag are string, []string, and map[string]string).
I didn't realize this at the time of writing this issue. My desired result was to control the length of the array, and it looks like the "boundary" tag has that purpose.
It is interesting to note that this throws the exact same error as the issue discussed currently, so I'll go ahead and try to put together a PR that will fix this error for the "boundary" tag.
As a side question, are there any tags that establish a desired exact length for an array instead of a boundary? This would be a neat feature to have :)

I needed the feature and didn't see a pr, so added the tag.
slice_len=5 should do the trick


Status of of xiao-berylline branch?

Also just a question, not an issue:
I noticed the branch name here https://github.com/jcmkk3/trochilidae/tree/xiao-berylline and I am assuming that you plan to have a xiao BLE version of berylline at some point in the future - based off of the fact that I imported the berylline/berylline.kicad_pcb file into my own kicad and did not see the xiao footprint yet.
Do you have any estimate on when/how this will be done, or info on if you will add printable files to the releases page when finished? I'm quite interested in printing this board myself and would like to do so with xiao controllers instead of nice!nanos if possible.
I'm also quite interested in the design differences between the berylline v1 and the min-spaced version. Looking at the product page for the CS keycaps used in the original photos, they are said to be made for 17x18mm spacing, so the minimum spaced version would not fit those (and I was really hoping to get to try out those keycaps). Also curious on the reasoning for not keeping the tenting puck holes and adding a new splay angle between the index and middle columns - do you find the splay layout is more comfortable?

Hi @pupto-bismol,
I've toyed with the idea of a xiao based berylline before, but I don't know if I'll ever do it. The reason is that the xiao doesn't have a convenient built-in place for a battery like a nice!nano does. It also would make the build more complicated because it would require diodes.
I think that I originally made that repo with the intention of experimenting, but the real experiments were in a case design. I never changed anything with the pcb to support a xiao, but knew that if I was going to do that, I'd need a case to hold a battery. I kept it around as an example for myself on a simple case design.
The choc min-spaced version is meant for pseudoku's Philadelphia Minimalist (PM) keycaps instead of Chicago Steno (CS). There aren't any cast versions that you can buy from asymplex, unfortunately. You can only print them. The source files can be found in this repo: https://github.com/pseudoku/PseudoMakeMeKeyCapProfiles
Pseudoku did an export for me of 14.5 x 14.5 sized keycaps that are the perfect size for chocs. You can find those in the low profile keyboard discord https://discord.gg/xmQtdVRBKg
A direct link to the post: https://discord.com/channels/669011382284451861/831948386198093834/970866610095157309
The reason that the tenting puck holes went away is because there wasn't a good place to put the mounting holes for the puck that didn't interfere with the switches in the condensed spacing. The splay angles were tweaked to compensate for the overall key spacing being more narrow.
I'm going to close this issue, but feel free to ask more questions here if you'd like. You can also ask questions in my channel on the absolem keyboard server https://discord.gg/PaCpa2uX8B

Thanks for the feedback! Right now I'm working in a local repo adding some of the modifications I want, including adapting berylline for a xiao BLE, adding two extra pinky keys, putting the spacing at standard choc 17x18, and possibly adding an encoder. When I'm done with everything would you want me to open a PR? I could open one with or without the extra pinky keys - stuff like the precise spacing of the splayed columns may not be the same still, though I kept the angles the same, and the edge cuts will probably not be the same as they were. But I would be happy to contribute if you'd like

It’s great to hear that you’re making it your own. No need to contribute back. One of my goals with these designs was to give a starting point that others could remix and extend to their own needs. It would be great if you published it to your own repo so that others could use/remix your design as well. I’d be happy to see the final result.


Import Bugsnag headers before reading preprocessor defines

Summary:

This change is a little different than https://github.com/bugsnag/bugsnag-react-native/pull/455 in that it just has .m files import their header files first thing.
Also do not query TARGET_OS_MAC first as that is true for TARGET_IOS_SIMULATOR.

Test Plan:

Debugging in Bugsnag for this code.
I added a compiler error in every TARGET_OS_IPHONE conditional and ensured that they all worked. This is how I found the ones found in this diff.

Goal
Fix building Bugsnag via Bazel
Design
Ensure class headers are imported first, which brings in Foundation, which brings in TargetConditionals.h. This is typical code structure.
Changeset
Change the imports of files so that preprocessor macros are defined when read.
Tests
I added nonsense characters, to ensure that before the change would show that code wrapped in macro was not compiling, and that after the change it was. At runtime I was able to step into the BSGOutOfMemoryWatchdog which is usually preprocessor wrapped with BSGOOMAvailable, and it wasn't compiling for us.
Review
Outstanding Questions

This pull request is ready for:

[ ] Initial review of the intended approach, not yet feature complete
[ ] Structural review of the classes, functions, and properties modified
[x] Final review
[ ] Release

[x] The correct target branch has been selected (master for fixes, next for
features)
[ ] If this is intended for release have all of the pre-release checks been considered?
[ ] Consistency across platforms for structures or concepts added or modified
[ ] Consistency between the changeset and the goal stated above
[ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
[ ] Usage friction - is the proposed change in usage cumbersome or complicated?
[ ] Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
[ ] Concurrency concerns - if components are accessed asynchronously, what issues will arise
[ ] Thoroughness of added tests and any missing edge cases
[ ] Idiomatic use of the language

@bolsinga  I didn't see how this code would work in Xcode but not Bazel. As far as I can tell, this is broken for all bugsnag users. Would you mind clarifying so we can make sure to isolate any other issues related to this? We should 100% support building bugsnag with PodToBUILD and Bazel.
Anyhow, I submitted bugsnag/bugsnag-react-native#455 I don't have a strong preference on how what the actual fix is.

AFAIK it works because somehow the code must be seeing the macros defined when it has been tested and used by others. We know others successfully see OOM reports from Bugsnag. Our build system exposed this issue. However I do not think it is solely a build system issue nor a code issue. I think the combination of the two shows these files are not importing their own headers first. When they do this they automatically get Foundation and TargetConditionals.
I think this fix is simple and it is atypical to manually import TargetConditionals.

@jerrymarino @bolsinga
I can see you've both been discussing these build problems, both on this PR and on https://github.com/bugsnag/bugsnag-react-native/pull/455.
Are these both aiming to solve the same problem or are both required? What ultimately are these issues blocking you from achieving and is this an issue for bugsnag-cocoa or bugsnag-react-native or both?

@jerrymarino @bolsinga
I can see you've both been discussing these build problems, both on this PR and on bugsnag/bugsnag-react-native#455.
Are these both aiming to solve the same problem or are both required? What ultimately are these issues blocking you from achieving and is this an issue for bugsnag-cocoa or bugsnag-react-native or both?

We are both aiming to solve the same problem.
We import bugsnag-react-native into our application. As you know, bugsnag-cocoa is a dependency. So we need the fix in both, but it probably ought to apply here.
We use https://github.com/pinterest/PodToBUILD to bring Bugsnag-React-Native into our application which builds with Bazel. Under these circumstances, it is true that the TARGET_OS_IPHONE macro is not defined when the OOM watchdog is going to define BSGOOMAvailable macro. This fix just has the .m files import their .h files first thing, and everything works out. Thanks.

@bolsinga - thanks! We're taking a look at both PRs and will decide on the best way forward.

Ah ok cool, I just wanted to confirm that this bug wasn't related to PodToBUILD or using Bazel 👍

Hi @jerrymarino @bolsinga
Yes, the macros we're using look to be incorrect in some cases and we'd like to investigate fully.
We're just working towards a new major release of bugsnag-cocoa in the coming weeks, so will be looking to resolve this as part of that work. If you need the fix in the short term I'd suggest using a fork with this PR.

Thanks for the update. We currently have a local workaround and look forward to the real fix.
Would you be able to verify if the oom watchdog builds for other iOS clients?

Hi @bolsinga,
Im not sure I understand what you mean by your question

Would you be able to verify if the oom watchdog builds for other iOS clients?
Could you explain further on this please?

Sure. For the way we build this code, the OOM watch dog code wasn’t compiling due to it referencing the OS macros prior to the source importing a header that defines these macros first.
I assume that this code builds and works for other iOS clients. I haven’t personally confirmed this. My question was basically to confirm that bugsnag does get oom reports from other client code, and thus we’d know that the build issue we see here is unique to our situation.

Thanks for clarifying that. Yes you assume correctly, it builds and works fine for other iOS clients.

Thanks! Our current workaround in our build system is to explicitly import TargetConditionals.h for every BugSnag file.
That workaround is not necessary with this PR applied.
I think this PR is a simple logical cleanup, but our workaround will hold up until this PR lands.
Thanks again for your time and understanding.

We believe this issue has now been fixed in https://github.com/bugsnag/bugsnag-cocoa/pull/654, released in v6.0.0.
Note: There are a number of breaking changes in v6.0.0 as part of an effort to improve the interface and make it more consistent across our error reporting libraries, so please refer to the upgrade guide:
https://github.com/bugsnag/bugsnag-cocoa/blob/master/UPGRADING.md


Limit on processing the notification queue

https://github.com/Adyen/adyen-magento/blob/develop/app/code/community/Adyen/Payment/Model/ProcessNotification.php#L1521
Whys is there a date limit on this collection?
We had issues this weekend where the cronjob didn't run for about 20 hours leaving some notifications to never be processed. Curious what the thought behind the limit it.

Hi @sandermangel,
We add a limit that the notification needs to be older then 1 minute because some merchants see that order saving cost a bit more time. We put it on one day because we presume the notification cronjob is  always running could scale this up to more days if needed. Was the one day the issue ?
Regards,

Hi @rikterbeek
That seems to be the issue indeed

Hi @sandermangel,
Closing this issue right now. Let me know if you want it to be delayed to more days.
Regards,
Rik
Adyen


[ISSUE #5829] fix codecov url in README

Make sure set the target branch to develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #5833 (393e8fb) into develop (9b3b551) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5833      +/-   ##
=============================================
- Coverage      42.45%   42.45%   -0.01%
- Complexity      8230     8238       +8
=============================================
  Files           1060     1060
  Lines          73414    73414
  Branches        9606     9606
=============================================
- Hits           31171    31167       -4
- Misses         38319    38322       +3
- Partials        3924     3925       +1

Impacted Files
Coverage Δ

...tmq/remoting/protocol/body/ConsumerConnection.java
95.83% <0.00%> (-4.17%)
:arrow_down:

...controller/impl/DefaultBrokerHeartbeatManager.java
82.27% <0.00%> (-3.80%)
:arrow_down:

...a/org/apache/rocketmq/broker/BrokerController.java
43.29% <0.00%> (-3.43%)
:arrow_down:

...ache/rocketmq/proxy/common/ReceiptHandleGroup.java
65.30% <0.00%> (-2.05%)
:arrow_down:

...he/rocketmq/broker/processor/PopReviveService.java
39.62% <0.00%> (-1.35%)
:arrow_down:

...apache/rocketmq/store/ha/GroupTransferService.java
92.30% <0.00%> (-1.29%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
83.65% <0.00%> (-0.97%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
34.53% <0.00%> (-0.56%)
:arrow_down:

...ava/org/apache/rocketmq/store/MappedFileQueue.java
62.25% <0.00%> (-0.50%)
:arrow_down:

...mq/client/impl/producer/DefaultMQProducerImpl.java
46.17% <0.00%> (-0.25%)
:arrow_down:

... and 20 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Feature Request - Transform to Titlecase Option

While working with blog posts and in general text heavy stuff, I really miss this option being there. So I thought I would make a request and eventually found out that I could myself send a PR.

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


Replace node server.js with the command to start the reload server

It seems this change is already in #81 so this is a duplicate PR? Going to close

sorry about that


feat: restrict service when using CAS protocol

#2099

https://github.com/casdoor/casdoor/assets/54203997/4a044f20-3634-485f-8341-2c09bd008bad


Cherry Pick fix for SeccompProfileBinding test

What type of PR is this?
/kind bug
Optionally add one or more of the following kinds if applicable:
/kind failing-test
/kind flake
What this PR does / why we need it:
Cheery pick fix for SeccompProfileBinding e2e test, this will sync openshift downstream fix to the upstream branch
Which issue(s) this PR fixes:
None
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
None

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.30%. Comparing base (11d77f4) to head (2f161f8).
Report is 453 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2513      +/-   ##
==========================================
- Coverage   45.50%   41.30%   -4.20%
==========================================
  Files          79      109      +30
  Lines        7782    18220   +10438
==========================================
+ Hits         3541     7526    +3985
- Misses       4099    10198    +6099
- Partials      142      496     +354

/retest


what is gen_rnn_ops in tensorflow/python/ops

Hi, I am trying to create my own linear tanh&sigmoid activation functions for lstmblockfusedcell (in lstm_ops.py), thus I directly create my own activation functions in rnn_cell_impl.py file and import this file in my own lstm_ops.py file.
Then I got an error msg as follows:
File "/home/git/DeepSpeech/lstm_ops_dpsp.py", line 29, in <module>     from tensorflow.python.ops import gen_rnn_ops ImportError: cannot import name 'gen_rnn_ops'
But there is no much useful information about this gen_rnn_ops, and also I want to know whether my way to change the activation function is okay.
By the way, I'm using
Ubuntu 16.04
python 3.5
tensorflow-estimator 1.13.0
tensorflow-gpu       1.13.1
Thank you

@Vampsj
In order to expedite the trouble-shooting process, please provide a minimal standalone code to reproduce the issue reported here. Thanks!

@ravikyram Sorry for the lack of codes!
I am working on Deepspeech(Mozilla) but trying to replace the activation functions with linear approximated functions in the LSTM. Here is a piece of the code, they used LSTMBlockFusedCell here. Thus I copied the lstm_ops.py, rnn.py, rnn_cell_impl.py files and changed activation functions in rnn_cell_impl.py, and import my changed rnn_cell_impl.py into the rest two files.
Code in Deepspeech:
import Tensorflow as tf
import rnn_dpsp as td_rnn # a copy of Tensorflow/python/ops/rnn.py
import lstm_ops_dpsp as td_lstm_ops # Tensorflow/python/ops/lstm_ops.py
import rnn_cell_impl_dpsp as td_rnn_cell # which is a copy of Tensorflow/python/ops/rnn_cell_impl.py
def rnn_impl_lstmblockfusedcell(x, seq_length, previous_state, reuse):
     # Forward direction cell:
     # Original code: fw_cell = tf.contrib.rnn.LSTMBlockFusedCell(Config.n_cell_dim, reuse=reuse)
    fw_cell = td_lstm_ops.LSTMBlockFusedCell(Config.n_cell_dim, reuse=reuse)
    output, output_state = fw_cell(inputs=x,
                                   dtype=tf.float32,
                                   sequence_length=seq_length,
                                   initial_state=previous_state)
    return output, output_state

where, in my own rnn_cell_impl_dpsp.py file, I added two linear approximated sigmoid&tanh functions:
def tf_tanh_poly(x, name=None):
    with tf.name_scope(name, "tanh_poly", [x]) as name:
        y = py_func(np_tanh_poly_32,
                    [x],
                    [tf.float32],
                    name=name,
                    grad=tanhpgrad)  # <-- here's the call to the gradient
        return y[0]

def tf_sigmoid_poly(x, name=None):
    with tf.name_scope(name, "sigmoid_poly", [x]) as name:
        y = py_func(np_sigmoid_poly_32,
                    [x],
                    [tf.float32],
                    name=name,
                    grad=sigmoidgrad)  # <-- here's the call to the gradient
        return y[0]

....

@tf_export(v1=["nn.rnn_cell.BasicLSTMCell"])
class BasicLSTMCell(LayerRNNCell):
  @deprecated(None, "This class is equivalent as tf.keras.layers.LSTMCell,"
              " and will be replaced by that in Tensorflow 2.0.")
  def __init__(self, num_units, forget_bias=1.0,  state_is_tuple=True, activation=None, reuse=None,        name=None,  dtype=None,  **kwargs):

    self._num_units = num_units
    self._forget_bias = forget_bias
    self._state_is_tuple = state_is_tuple

    if activation:
      self._activation = math_ops.tanh
    else:
      self._activation = tf_tanh_poly     # HERE

and in the rest of two files, I only comment out the original import and changed to my own file :
"""LSTM Block Cell ops."""
from __future__ import absolute_import
from __future__ import division
from __future__ import print_function

import abc

import six

from tensorflow.python.framework import dtypes
from tensorflow.python.framework import ops
from tensorflow.python.keras.engine import input_spec
from tensorflow.python.layers import base as base_layer
from tensorflow.python.ops import array_ops
from tensorflow.python.ops import gen_rnn_ops
from tensorflow.python.ops import init_ops
from tensorflow.python.ops import math_ops
from tensorflow.python.ops import nn_ops
# from tensorflow.python.ops import rnn_cell_impl
import rnn_cell_impl_dpsp as rnn_cell_impl

LayerRNNCell = rnn_cell_impl.LayerRNNCell  # pylint: disable=invalid-name

Then I put these files in one folder, but I faced the
ImportError:in <module> from tensorflow.python.ops import gen_rnn_ops ImportError: cannot import name 'gen_rnn_ops'.
For more detail, I used pip3 to install TensorFlow-gpu 1.13 rather than build from the source.
I am new to Tensorflow, if there is a better way to change the activation function, please tell me! Thank you!

@Vampsj, It is working with Tf 1.15.0.
Please see the gist here. Thanks!

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

I  am closing the issue as it was resolved with TF 1.15. Please, feel free to reopen the issue if you feel issue still persists. Thanks!


fix: encode queryParam value and fix parsing logic for queryParams

Description

Add encoding for Api key secret value before storing it as query param to avoid incorrect parsing.
Remove hardcoded "api_key" check to mask headers.
Used standard URL parsing APIs instead of custom
Added unit test to cover the case

Fixes https://github.com/appsmithorg/appsmith/issues/33742
flaws in the implementation here
Automation
/test datasource
:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9229420798
Commit: 7a952ee07978b932eaa3824e1f3295990c27edc7
Cypress dashboard url: Click here!

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

@rishabhrathod01 do you want to create a separate issue for this so that we can track it?

Yes. Added the issue to the board.


Add support for Github Enterprise

Fixes #28
Depends on https://github.com/fregante/list-github-dir-content/pull/16

The token also depends on the domain, as suggested in the issue

Thank you for sending these PRs 🤗

I'll continue to work on this in few hours. Already added a per-instance token store.

This part looks good to me. Can you have a look @fregante?

I'll check if it works for my GHE instance tomorrow and let you know.

Can you test the latest deployment with your GHE?

Did you test with GHE?

Unfortunatly, now.sh is blocked in my company network. Can you drop me a copy of the released files?

Archive.zip

There's one bug. Download doesn't work immediately after filling token. It needs a page refresh before starting downloading. Looks like isGHE has a incorrect value at this step.  I need to do extended tests at home, let me know if you have an idea.
Other than that, it works perfectly!

Any progress?


Questions about M5.BtnA.releasedFor and M5.BtnA.wasReleaseFor

Hi there, I'm using an M5AtomS3. I need to execute some code only once, about 1500ms after BtnA has been released after being held for some time. When I use if (M5.BtnA.releasedFor(1500)), it does become true 1500ms after being released, but then remains true forever so the code is also executed forever.
Is there a way to reset this button status, or do I need to add my own boolean flag to keep track of when the code has been executed so that it only happens once?
Also if I try  if (M5.BtnA.wasReleaseFor(1500)) it never seems to be true.
Here is my code:
  // Display the LED brightness while the user adjusts it (or finishes adjusting) in the main loop
  if (M5.BtnA.isHolding() || M5.BtnA.wasReleasedAfterHold()) {
    // Label
    M5.Display.setTextPadding(0);
    M5.Display.setTextColor(TFT_WHITE, TFT_BLACK);
    M5.Display.setTextDatum(top_left);
    M5.Display.drawString("LED Brt:", 0, y_pos);

    // Value
    M5.Display.setTextPadding(40);
    M5.Display.setTextColor(TFT_GREEN, TFT_DARKGREY);
    M5.Display.setTextDatum(top_right);
    M5.Display.drawNumber(led_bright, wd - 5, y_pos);
  }
  else if (M5.BtnA.releasedFor(1500)) {
    M5.Display.clear(); // <== Keeps executing over and over 1500ms after user releases button
  }

The following code works but is not as neat as using built in M5 functions
  if (M5.BtnA.isHolding() || M5.BtnA.wasReleasedAfterHold()) {
    relased_ms = millis();
    bright_txt_cleared = false;
    // Label
    ...
    // Value
    ...
  }
  else if (!bright_txt_cleared && millis() - relased_ms > 1500) {
    bright_txt_cleared = true;
    M5.Display.clear(); // <== Executes only once 1500ms after user releases button
  }

thanks for any suggestions!

Hello, @patfelst
Sorry for the late reply.
Are you running the M5.update(); function properly?
Calling this function will update the state of all buttons, so you must call it once before reading the button state. If you do not call it or call it more than once, the state will not be updated correctly.

thanks, I will check this soon!

apologies for the long delay in getting back to you.
You are correct, I wasn't calling M5.update() properly, I had to insert another M5.update() before checking the button state, and now the M5.BtnA.releasedFor(1500)) works ok.
Thanks very much.


Listener Pointer Up and Pointer Alternate Suggestion

onPointerDown: (details) {
// if(mounted){
// writeRespiratoryPauseData(2);
// _buttonPressed = true;
// _increaseCounterWhilePressed();
// }
// },
// onPointerUp: (details) {
// writeRespiratoryPauseData(0);
// if(mounted){
// setState(() {
// timerCounter = 0;
// _buttonPressed = false;
// });
// }
// },

//==========

void _increaseCounterWhilePressed() async {
// writeRespiratoryPauseData();
// make sure that only one loop is active
if (_loopActive) return;

_loopActive = true;

while (_buttonPressed) {
  // do your thing

  if(mounted){
    setState(() {
    if (timerCounter <= 29) {
      timerCounter++;
    }
    if (timerCounter == 30) {
      writeRespiratoryPauseData(0);
      if(mounted){
        setState(() {
        //  sleep(Duration(seconds: 2));
        _buttonPressed = false;
        _loopActive = true;
      });
      }
    }
  });
  }

  // Fluttertoast.showToast(msg: timerCounter.toString());

  // wait a bit
  await Future.delayed(Duration(seconds: 1));
}

_loopActive = false;
}

//===========
I am running timer for 30sec

if it reaches 30sec the pressed button will be auto released
power down will start count and power up stop count
but the issue what I am facing is when I pressed button it is auto releasing and again it is pressing I mean both instances power down and power up continuously its going in loop

Hi @eswarvarma-dev
This platform is not meant for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Doubt in the implementation of gan's training critera

I read the code of gan implementation in tf.contrib.gan, but I'm not quite sure whether the generator_train_op and discriminator_train_op use the same batch of data.
Here is the code in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/gan/python/train.py
class RunTrainOpsHook(session_run_hook.SessionRunHook):
  """A hook to run train ops a fixed number of times."""

  def __init__(self, train_ops, train_steps):
    """Run train ops a certain number of times.
    Args:
      train_ops: A train op or iterable of train ops to run.
      train_steps: The number of times to run the op(s).
    """
    if not isinstance(train_ops, (list, tuple)):
      train_ops = [train_ops]
    self._train_ops = train_ops
    self._train_steps = train_steps

  def before_run(self, run_context):
    for _ in range(self._train_steps):
      run_context.session.run(self._train_ops)

def get_sequential_train_hooks(train_steps=namedtuples.GANTrainSteps(1, 1)):
  """Returns a hooks function for sequential GAN training.
  Args:
    train_steps: A `GANTrainSteps` tuple that determines how many generator
      and discriminator training steps to take.
  Returns:
    A function that takes a GANTrainOps tuple and returns a list of hooks.
  """
  def get_hooks(train_ops):
    generator_hook = RunTrainOpsHook(train_ops.generator_train_op,
                                     train_steps.generator_train_steps)
    discriminator_hook = RunTrainOpsHook(train_ops.discriminator_train_op,
                                         train_steps.discriminator_train_steps)
    return [generator_hook, discriminator_hook]
  return get_hooks

Can we guarantee that both hooks run the optimizer on the same batch, along with that each hook run the respective optimizer several times on the same batch? I think that's needed for gan training, and consistent with relative papers.

I'm not that familiar with the code, but looking at the comment
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/gan/python/train.py#L618
seems like get_joint_train_hooks solves this problem that you're mentioning.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue? Please update the label and/or status accordingly.


UF testing tools project. First tool: a way to mock Event in cdi beans

It'll be interesting to see how the Observer methods can be implemented without CDI. Arguably testing the Observers of Events is more important (OK, OK, as important!) than checking the firing of Events.

I agree, but we are talking here about unit testing. So in that case if you are testing class X and want to verify how it reacts by a event, just call the observer method in X.
But for integration tests is another topic ;)

https://github.com/uberfire/uberfire/commit/af077fcadd6f3bacd4fd0e636cae20309931429f


Subatomic Particle and structure ontology not disjoint

The structural ontology, of which chemical entity (CHEBI:24431) is the root, was supposed to be disjoint from the subatomic particle ontology (root CHEBI:36342). I found a hand full of examples where it is possible to reach both roots via is_a relations (example and full list below). Is there a wrong connection in the graph?
CHEBI:30220
CHEBI:30216
CHEBI:24636
CHEBI:29233
CHEBI:29234

I don't think that we specify the structural and subatomic particle ontologies are disjoint? While it is generally true that  monoatomic monocations such as sodium(1+), copper(1+), etc., are not subatomic particles,  the generalization breaks down with monoatomic hydrogen and its isotopes. Removing an electron from a hydrogen atom, H, gives a proton, H(+) - which is a subatomic particle.


Feature request: support custom OpenAI API endpoints

A CLI parameter like --openai-api-endpoint="http://localhost:11434/v1" would enable the use of local or self-hosted FOSS tools like ollama and others that serve an OpenAI compatible API.
Thank you,
Piero

Oh, that is an excellent idea :+1:


docs: explain how to write unit tests and integration tests

Description
Add a page that explains how to write unit tests using fakes, and integration tests.
Related Issues
As per https://github.com/FirebaseExtended/flutterfire/discussions/5550#discussioncomment-557644, I am adding a page about testing.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] I signed the [CLA].
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Hi @Salakar, would you mind taking a look?


Warning: Exception thrown by hook while handling onSetChildren: Invariant Violation: Item must have been set Invariant Violation: Item must have been set

Hey there, I was playing with these components and when I upload multiple files using dropzone and global progress bar it throws this warning:
Warning: Exception thrown by hook while handling onSetChildren: Invariant Violation: Item must have been set Invariant Violation: Item must have been set
React version: 15.5.4. Also tested with 15.4.2 and same warning.
Here is my example code:
import Dropzone from "react-fine-uploader/dropzone"
import ProgressBar from "react-fine-uploader/progress-bar"
import FineUploaderTraditional from "fine-uploader-wrappers"

let defaultUploaderProps = {
   chunking: {
        enabled: true
    },
    deleteFile: {
        enabled: false,
    },
    retry: {
        enableAuto: true
    },
    validation: {
        sizeLimit: 30000,
        itemLimit: 50
    }
}

class MyDropzone extends React.Component {
    constructor(props) {
        super(props);

        let _uploaderProps = Object.assign({}, defaultUploaderProps, props.uploaderProps);
        this.uploader = props.uploader || this.getUploader(_uploaderProps);
    }

    static get defaultProps() {
        return {
            dropActiveClassName: "well-dropzone-active",
            multiple: true,
            uploaderProps: {}
        }
    }

    getUploader(uploaderProps) {
        return new FineUploaderTraditional({
            options: uploaderProps
        });
    }

    render() {
        let zoneProps = Object.assign({}, this.props);
        delete zoneProps['uploaderProps'];

        return (

                <ProgressBar uploader={this.uploader} className="progress-bar-uploader" />

                <Dropzone className="well well-form-dotted"
                    uploader={this.uploader} {...zoneProps}>

                            Choose your files or drag them here

                </Dropzone>

        )
    }
}

export { MyDropzone }

And here are couple of screenshots just in case they are helpful
http://prntscr.com/fdlss2
http://prntscr.com/fdlt76
These are really nice components! Thanks for this :)

React isn't very good a providing consistently readable error messages. This is one of those. Research indicates this is a bug in React 15 that may be patched in 16.

Haven't heard anything further on this in a while. Perhaps a react issue since fixed? If anyone is still seeing this with a current react version and can identify where react fine uploader is at fault, I can reopen

In the company I work for, we're using React 15.6.1 altogether with ExtJS (ExtReact). This bug is popping up all the time :/

Also, due to the fact that we're using (and bound to use) ExtReact for our current project, we can't upgrade to 16.X either.

i haven't seen this issue myself. if you are still seeing it an figure out how to best address it, please post here

I'll do if I can. We need to get this error out of the way in order to continue advancing, so I hope today or tomorrow we can come up with a fix or some explanation about the error, at least.

Anyone had any luck with this? I got this error after making one simple change to the already working app and even if I backtrack the change it still shows that error.


[Bug] Step 0 fails, Node.js 12 actions are deprecated.

Describe the bug
Step 0 initial commit fails with exit code 129, with warning "Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2". This means further sections do not automatically open after tasks are completed.
To Reproduce
Steps to reproduce the behavior:

Fork repo
Step 0 fails with exit code 129
Complete section 1 tasks
Wait 20 seconds and refresh README.md
Section 2 does not automatically open

Expected behavior

Fork repo
Step 0 completes with no error
Complete section 1 tasks
Wait 20 seconds and refresh README.md
Section 2 automatically opens

Screenshots

Device information

Type: [Laptop]
OS: [Ubuntu 20.04.5 Budgie]
Browser [Hardened Firefox]
Version [Browser version 107.0]

Additional context
Add any other context about the problem here.

Thanks for the report!  If you or anyone is interested in opening a PR def. feel free (would be basically the same as https://github.com/skills/continuous-integration/pull/19)!  Otherwise I'll update this week...


[Question]: Differences between Solo and HB3-connected devices

Ask your question
Hello @bropat,
today I have been run into the problem, that a device that can run as solo device or can be connected to the HB3 can have different properties. In my case, I have the T8416 (IndoorCam S350) here and when it is operated as solo device, the Property DeviceMotionDetection must be [PropertyName.DeviceMotionDetection]: DeviceMotionDetectionIndoorSoloFloodProperty and when connected to HB3, it must be [PropertyName.DeviceMotionDetection]: DeviceMotionDetectionProperty. The problem is, that we not allowed to use the names multiple times.
As a possible solution, we might can create a solo device with the DeviceType as the negative number (e.g. for T8416 DeviceType is 104, so we use -104. Or have you something "smoother" in mind?
The check before creating the device:
if(resDevices[deviceSerial].device_sn === resDevices[deviceSerial].station_sn) {
    rootAddonLogger.info("We have found a solo device...", resDevices[deviceSerial].device_sn);
    if (Object.values(DeviceType).includes(resDevices[deviceSerial].device_type*-1)) {
        rootAddonLogger.info("... and the device has different values for solo and HB3 connected devices.");
        resDevices[deviceSerial].device_type = resDevices[deviceSerial].device_type*-1;
        rootAddonLogger.info(resDevices[deviceSerial].device_type.toString());
    } else {
        rootAddonLogger.info("... and the device has NO different values for solo and HB3 connected devices.");
    }
}

The changed types:
export enum DeviceType {
    //...
    INDOOR_PT_CAMERA_S350 = 104,
    INDOOR_PT_CAMERA_S350_SOLO = -104,
    //...
}

export const IndoorPanAndTiltCameraS350DefaultDeviceProperties: IndexedProperty = {
    ...GenericDeviceProperties,
    //ALL THE OTHER PROPERTIES FROM THE INDOOR_PT_CAMERA_S350
};

...

export const DeviceProperties: Properties = {
    //...
    [DeviceType.INDOOR_PT_CAMERA_S350]: {
        ...IndoorPanAndTiltCameraS350DefaultDeviceProperties,
        [PropertyName.DeviceMotionDetection]: DeviceMotionDetectionProperty,
    },
    [DeviceType.INDOOR_PT_CAMERA_S350_SOLO]: {
        ...IndoorPanAndTiltCameraS350DefaultDeviceProperties,
        [PropertyName.DeviceMotionDetection]: DeviceMotionDetectionIndoorSoloFloodProperty,
    },
    //...
}

Sorry for bother you with that.
Best, Philipp

A possible complete implementation you can find here: 7605b4b

Hi @PhilippEngler,
What you describe here should already work.
Look here: https://github.com/bropat/eufy-security-client/blob/2c376bc8889b1f92961289b96a7bc667deda8609/src/http/device.ts#L846-L894
If it still did not work in this case, it is a bug and the cause must be found.

Hello bropat,
thank you for your answer. I haven't found this part. Then I will implement it for the IndoorCam S350 in this way.
Best, Philipp

Finished. Optionally see #535.