Read of closed file when a test fails and Report Portal is active

I am trying Pylenium with pytest-bdd and Report Portal, it's really nice.
However, when I launch a test that fails with pytest --reportportal I have this error:

Traceback (most recent call last):
File "PROJECT/venv/bin/pytest", line 8, in
sys.exit(console_main())
File "PROJECT/venv/lib/python3.9/site-packages/_pytest/config/init.py", line 185, in console_main
code = main()
File "PROJECT/venv/lib/python3.9/site-packages/_pytest/config/init.py", line 162, in main
ret: Union[ExitCode, int] = config.hook.pytest_cmdline_main(
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/hooks.py", line 286, in call
return self._hookexec(self, self.get_hookimpls(), kwargs)
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/manager.py", line 93, in _hookexec
return self._inner_hookexec(hook, methods, kwargs)
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/manager.py", line 84, in
self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/callers.py", line 208, in _multicall
return outcome.get_result()
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/callers.py", line 80, in get_result
raise ex[1].with_traceback(ex[2])
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/callers.py", line 187, in _multicall
res = hook_impl.function(*args)
File "PROJECT/venv/lib/python3.9/site-packages/_pytest/main.py", line 316, in pytest_cmdline_main
return wrap_session(config, _main)
File "PROJECT/venv/lib/python3.9/site-packages/_pytest/main.py", line 304, in wrap_session
config.hook.pytest_sessionfinish(
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/hooks.py", line 286, in call
return self._hookexec(self, self.get_hookimpls(), kwargs)
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/manager.py", line 93, in _hookexec
return self._inner_hookexec(hook, methods, kwargs)
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/manager.py", line 84, in
self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/callers.py", line 203, in _multicall
gen.send(outcome)
File "PROJECT/venv/lib/python3.9/site-packages/_pytest/terminal.py", line 803, in pytest_sessionfinish
outcome.get_result()
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/callers.py", line 80, in get_result
raise ex[1].with_traceback(ex[2])
File "PROJECT/venv/lib/python3.9/site-packages/pluggy/callers.py", line 187, in _multicall
res = hook_impl.function(*args)
File "PROJECT/venv/lib/python3.9/site-packages/pytest_reportportal/plugin.py", line 149, in pytest_sessionfinish
session.config.py_test_service.finish_launch()
File "PROJECT/venv/lib/python3.9/site-packages/pytest_reportportal/service.py", line 403, in finish_launch
self.rp.finish_launch(**fl_rq)
File "PROJECT/venv/lib/python3.9/site-packages/reportportal_client/service.py", line 249, in finish_launch
self.log_batch([], force=True)
File "PROJECT/venv/lib/python3.9/site-packages/reportportal_client/service.py", line 526, in log_batch
r = self.session.post(
File "PROJECT/venv/lib/python3.9/site-packages/requests/sessions.py", line 590, in post
return self.request('POST', url, data=data, json=json, **kwargs)
File "PROJECT/venv/lib/python3.9/site-packages/requests/sessions.py", line 528, in request
prep = self.prepare_request(req)
File "PROJECT/venv/lib/python3.9/site-packages/requests/sessions.py", line 456, in prepare_request
p.prepare(
File "PROJECT/venv/lib/python3.9/site-packages/requests/models.py", line 319, in prepare
self.prepare_body(data, files, json)
File "PROJECT/venv/lib/python3.9/site-packages/requests/models.py", line 507, in prepare_body
(body, content_type) = self._encode_files(files, data)
File "PROJECT/venv/lib/python3.9/site-packages/requests/models.py", line 159, in _encode_files
fdata = fp.read()
ValueError: read of closed file

And the test still runs in Report Portal.
Do you have any idea on how to solve this ?
Thanks 😁

@rafutek This looks like a problem with Report Portal (RP). I haven't tried using pytest-bdd with RP yet, but this wouldn't be a Pylenium issue.
Sorry, I know that's not a very helpful answer, but I'd post the issue on their Slack or repo :(

@ElSnoMan No problem, now I know it's not a Pylenium issue ;) Thanks !


Downgrade thiserror

bcs requires thiserror 1.0.31.
This is blocking from upgrading narwhal in sui

Looks like I don't need this


Update portuguese language

Add missing entries and improve old translation
This PR aims to fix some missing translations on the original file, creating unpleasing results like the one below

All while improving current translations to be more natural.

lgtm. Thanks for the patch! 👍


types: rewrite inference API to use a slab allocator for type bounds

Our existing type inference engine assumes a "global" set of type bounds, which has two bad consequences: one is that if you are constructing multiple programs, there is no way to "firewall" their type bounds so that you cannot accidentally combine type variables from one program with type variables from another. You just need to be careful. The other consequence is that if you construct infinitely sized types, which are represented as a reference cycle, the existing inference engine will leak memory.
A third issue, though I am unsure whether it leads to actual bugs, is that the type inference engine can only lock data at the granularity of individual type bounds, meaning that multi-step parts of type inference are not done atomically, and if you try to construct a program in a multithreaded context, it is possible that strange/unexpected things will happen.
To avoid this, it is better that each program under construction has an independent "type inference context" which holds a slab allocator. When the context is dropped, which happens when the initial constructed context and all the program nodes that reference it are dropped, it deallocates all the type bounds in one shot, rather than chasing Arcs and failing to notice cycles.
This is a 2000-line diff but the vast majority of the changes are "API-only" stuff where I was moving types around and threading new parameters through dozens or hundreds of call sites. I did my best to break everything up into commits such that the big-diff commits don't do much of anything and the real changes happen in the small-diff ones to make review easier.
Builds on #227.
This does not fix #226 although it sets the stage for "checkpointing" the type inference context, which should allow a reasonably-efficient way to undo changes when things go wrong.

I will probably break this into more than 2 PRs, but I'll leave this open for now as the "source of truth" for the whole project.


Fix session tally count

Fixes #672
Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

This is a very minor fix, merging.


gocheck's basic example does not work with vscode-go-test-suite

Hi! gocheck's "hello world" example:
package hello_test

import (
    "testing"
    "io"

    . "gopkg.in/check.v1"
)

// Hook up gocheck into the "go test" runner.
func Test(t *testing.T) { TestingT(t) }

type MySuite struct{}

var _ = Suite(&MySuite{})

func (s *MySuite) TestHelloWorld(c *C) {
    c.Assert(42, Equals, "42")
    c.Assert(io.ErrClosedPipe, ErrorMatches, "io: .*on closed pipe")
    c.Check(42, Equals, 42)
}

... does not show the run/debug lens on TestHelloWorld. I believe this is because of the "dot-import" ( . "gopkg.in/check.v1"), because if I change the code to explicitly use the check package everywhere, like this:
package hello_test

import (
	"io"
	"testing"

	"gopkg.in/check.v1"
)

// Hook up gocheck into the "go test" runner.
func Test(t *testing.T) { check.TestingT(t) }

type MySuite struct{}

var _ = check.Suite(&MySuite{})

func (s *MySuite) TestHelloWorld(c *check.C) {
	c.Assert(42, check.Equals, "42")
	c.Assert(io.ErrClosedPipe, check.ErrorMatches, "io: .*on closed pipe")
	c.Check(42, check.Equals, 42)
}

... then the lens show up as expected. Do you think it would be possible/reasonable to take import statements like  . "gopkg.in/check.v1" into account when parsing the test file?

Thanks for reporting this @tigarmo.
I just pushed a fix for this and it is now available in the new version v0.0.16. Please upgrade your extension and let me know if it didn't work as expected.

😮 that was super fast! I can confirm that with version 0.0.16 all my gocheck tests have the expected lens
thanks a lot!

Great. I'm happy to hear that. ❤


What initial positions did you use for your clusters?

I really just estimated it, and seems to be... working out? I am getting energies at about 28 eV.

same here.

initial coordinates for  the cube I got them using the equilibrium distance
either the theoretical one 2.312 A or the empirical one 2.36 A
I used the empirical value 0.236 nm


question about test_kuka_pick.py

I build pybullet and pybullet_plan on my Windows system. but when I run the 'test_kuka_pick.py' ,I got an error in 'utils.py' ,'No module named 'motion_planners'. I want to know how to deal with this error.

motion-planners is actually already included as a submodule.


Getting double extension importing via jspm

It seems that loading the module with jspm, generates an exception due to the extension being added twice; server responds with Cannot GET<EMAIL_ADDRESS>Removing a .js in index.js#L4 actually solves the problem for jspm, but I do not know if it brakes Browserify support.

I think this has been fixed now.

This has been fixed in 0.9.x


feat: simplify signing experience

This PR introduces a new option for users to sign using an on-demand key. Users are able to sign without needing to add a key first
This PR intends to address the following issue: #537
Based on spec changes in #553

Successful sign/verify:
c889f3b9d811:notation kodysk$ ./bin/notation sign --plugin com.example.plugin --id example:test-id $IMAGE
Warning: Always sign the artifact using digest(@sha256:...) rather than a tag(:v1) because tags are mutable and a tag reference can point to a different artifact than the one signed.
Successfully signed localhost:5000/net-monitor@sha256:07c30edca95116e23f6a150ba3f7ed296eca71021dba9d9569eb07820f8c0e7d

c889f3b9d811:notation kodysk$ ./bin/notation verify $IMAGE
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:v1) because resolved digest may not point to the same signed artifact, as tags are mutable.
Successfully verified signature for localhost:5000/net-monitor@sha256:07c30edca95116e23f6a150ba3f7ed296eca71021dba9d9569eb07820f8c0e7d

Error when providing only one of the options
c889f3b9d811:notation kodysk$ ./bin/notation sign --plugin com.example.plugin $IMAGE
Error: incompatible options, both a key ID and plugin name are required when not using an existing key

c889f3b9d811:notation kodysk$ ./bin/notation sign --id example:test-id $IMAGE
Error: incompatible options, both a key ID and plugin name are required when not using an existing key

Error when providing key with both plugin and id:
c889f3b9d811:notation kodysk$ ./bin/notation sign --plugin com.example.plugin --id example:test-id --key my-key $IMAGE
Error: incompatible options, do not provide a key name when providing a key ID and plugin name

Error when providing key with one of the other options
c889f3b9d811:notation kodysk$ ./bin/notation sign --plugin com.example.plugin --key my-key $IMAGE
Error: incompatible options, do not provide a key ID or plugin name when providing a key name

c889f3b9d811:notation kodysk$ ./bin/notation sign --id example:test-id --key my-key $IMAGE
Error: incompatible options, do not provide a key ID or plugin name when providing a key name

Signed-off-by: Kody Kimberl<EMAIL_ADDRESS>

Codecov Report

Merging #579 (495a872) into main (55f0764) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   34.36%   34.03%   -0.34%
==========================================
  Files          32       32
  Lines        1848     1866      +18
==========================================
  Hits          635      635
- Misses       1192     1210      +18
  Partials       21       21

Impacted Files
Coverage Δ

cmd/notation/sign.go
34.40% <0.00%> (-5.79%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi @kody-kimberl @priteshbandi @JeyJeyGao @patrickzheng200  ,
It seems the CLI example was not added to the CLI help info. Just a kindly reminder, when we change CLI commands and flags, we need to add or update the CLI examples in [notation/cmd]((https://github.com/notaryproject/notation/blob/main/cmd/notation/) accordingly.
I will raise another PR to add it.


Memory leak fixes for node [Part 2]

Cleanup Node's disconnect methods.
Rename NodeConnection.CleanUp() > EndListen()
This relates to #569.

This are changes in the core of the code we need to review them very carefully.


Add some common github workflows

I noticed that github orgs can share workflows between them. Though I originally intended this to be the start of a gnar-cli script, I now wonder if we can just share these scripts from this repo directly. Investigating further.

Ignoring these checks-  i just set it so that no actions run from this repo, testing to see if these actions can then be shared after a merge.


Ball Fall Game

Describe the project
"The ball is lost in the extremeties of space while exploring.If its touches the extreme of space,it will lose it life.Manage to save the ball's life by drawing it towards the bottom and extending its life time....Lets Start!! "
Issue Type:

[x] New Project

kindly assign me this issue @TusharKesarwani @Vanshiii203


Idea/Fix - Avoid grabbing zip files unless it's a last resort

For this example here:
https://jimaku.cc/entry/589
When downloading the subs for Air episode 1, the add-on went for:
AIR 2005 [01-06].SUP.7z
instead of finding the individual files here.
It would be good if this test case could be used to improve the effectiveness of this great add-on.
🥰

Hi, I'm glad you like the extension.
The extension should avoid grabbing zip, rar and 7z files now with b6460784fb6438492b1de4d84a20f56d8105e490.
It's in the latest release, so you can go ahead and try it


fix return from direnv--export

After e1f45aa (#34) direnv--export returns (delete-file stderr-tempfile) (i.e. nil) instead of (json-read-object), so changes aren't picked up.
This just wraps with unwind-protect so that correct value is returned and temp file is deleted even if something throws an error.
prog1 would also work.

oops, thanks!


Update couchdb to latest version

Codecov Report

Merging #175 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   34.68%   34.65%   -0.04%
==========================================
  Files         185      185
  Lines        2978     2981       +3
  Branches      222      222
==========================================
  Hits         1033     1033
- Misses       1834     1837       +3
  Partials      111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...7a42f48. Read the comment docs.

Codecov Report

Merging #175 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   34.68%   34.75%   +0.06%
==========================================
  Files         185      185
  Lines        2978     2981       +3
  Branches      222      222
==========================================
+ Hits         1033     1036       +3
- Misses       1834     1835       +1
+ Partials      111      110       -1

Impacted Files
Coverage Δ

...lib/src/adapters/database/ElementCouchDBAdapter.js
87.17% <100%> (+3.84%)
:arrow_up:

packages/element-lib/src/__tests__/test-utils.js
94.44% <100%> (ø)
:arrow_up:

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
60.86% <0%> (-2.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...5c5ba89. Read the comment docs.

Codecov Report

Merging #175 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   34.68%   34.75%   +0.06%
==========================================
  Files         185      185
  Lines        2978     2981       +3
  Branches      222      222
==========================================
+ Hits         1033     1036       +3
- Misses       1834     1835       +1
+ Partials      111      110       -1

Impacted Files
Coverage Δ

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
60.86% <0.00%> (-2.18%)
:arrow_down:

...lib/src/adapters/database/ElementCouchDBAdapter.js
87.17% <0.00%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...5c5ba89. Read the comment docs.

Codecov Report

Merging #175 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #175     +/-   ##
=========================================
+ Coverage   34.68%   34.79%   +0.1%
=========================================
  Files         185      185
  Lines        2978     2983      +5
  Branches      222      222
=========================================
+ Hits         1033     1038      +5
- Misses       1834     1835      +1
+ Partials      111      110      -1

Impacted Files
Coverage Δ

...lib/src/adapters/database/ElementCouchDBAdapter.js
87.8% <100%> (+4.47%)
:arrow_up:

packages/element-lib/src/__tests__/test-utils.js
94.44% <100%> (ø)
:arrow_up:

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
60.86% <0%> (-2.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...1775e7c. Read the comment docs.

Codecov Report

Merging #175 into master will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   34.68%   34.79%   +0.10%
==========================================
  Files         185      185
  Lines        2978     2983       +5
  Branches      222      222
==========================================
+ Hits         1033     1038       +5
- Misses       1834     1835       +1
+ Partials      111      110       -1

Impacted Files
Coverage Δ

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
60.86% <0.00%> (-2.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...e36f3c5. Read the comment docs.

Codecov Report

Merging #175 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #175     +/-   ##
=========================================
+ Coverage   34.68%   34.79%   +0.1%
=========================================
  Files         185      185
  Lines        2978     2983      +5
  Branches      222      222
=========================================
+ Hits         1033     1038      +5
- Misses       1834     1835      +1
+ Partials      111      110      -1

Impacted Files
Coverage Δ

...lib/src/adapters/database/ElementCouchDBAdapter.js
87.8% <100%> (+4.47%)
:arrow_up:

packages/element-lib/src/__tests__/test-utils.js
94.44% <100%> (ø)
:arrow_up:

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
60.86% <0%> (-2.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...e36f3c5. Read the comment docs.

Codecov Report

Merging #175 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   34.68%   34.75%   +0.06%
==========================================
  Files         185      185
  Lines        2978     2981       +3
  Branches      222      222
==========================================
+ Hits         1033     1036       +3
- Misses       1834     1835       +1
+ Partials      111      110       -1

Impacted Files
Coverage Δ

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
60.86% <0.00%> (-2.18%)
:arrow_down:

...lib/src/adapters/database/ElementCouchDBAdapter.js
87.17% <0.00%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...b970d70. Read the comment docs.

Codecov Report

Merging #175 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   34.68%   34.75%   +0.06%
==========================================
  Files         185      185
  Lines        2978     2981       +3
  Branches      222      222
==========================================
+ Hits         1033     1036       +3
- Misses       1834     1835       +1
+ Partials      111      110       -1

Impacted Files
Coverage Δ

...lib/src/adapters/database/ElementCouchDBAdapter.js
87.17% <100%> (+3.84%)
:arrow_up:

packages/element-lib/src/__tests__/test-utils.js
94.44% <100%> (ø)
:arrow_up:

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
60.86% <0%> (-2.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...2a5b500. Read the comment docs.

Codecov Report

Merging #175 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   34.68%   34.75%   +0.06%
==========================================
  Files         185      185
  Lines        2978     2981       +3
  Branches      222      222
==========================================
+ Hits         1033     1036       +3
- Misses       1834     1835       +1
+ Partials      111      110       -1

Impacted Files
Coverage Δ

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
60.86% <0.00%> (-2.18%)
:arrow_down:

...lib/src/adapters/database/ElementCouchDBAdapter.js
87.17% <0.00%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb67c1...2a5b500. Read the comment docs.


Create README.md

Added README for UFW plugin issue: [Good first PR] Add READMEs to undocumented plugins #7175

Thanks!


Fix "testinfra --help" not showing usage

Note: this is an ugly hack, because py.test currently does not allow
display of plugin usage

Hi, thanks for your contribution !
However I'm not gonna merge this because I just fixed it in 493dd0af5729aadb5007b2b021a6da34b040c11f
Now testinfra --help display py.test help (with testinfra specific options)

Glad to help, thank you for testinfra.
To note, the difference in the fix I have is that it displays only help for the testinfra rather then all the py.test plugins which is a bit more confusing since it is so large. If that changes your mind about the PR, I am happy to update it to the easily merge with the existing code.
usage: testinfra [-h] [--connection CONNECTION] [--hosts HOSTS]
                 [--ssh-config SSH_CONFIG] [--sudo] [--nagios]

optional arguments:
  -h, --help            show this help message and exit
  --connection CONNECTION
                        Remote connection backend paramiko|ssh|safe_ssh|salt
  --hosts HOSTS         Hosts list (comma separated)
  --ssh-config SSH_CONFIG
                        SSH config file
  --sudo                Use sudo
  --nagios              Nagios plugin

Yep py.test help is large and maybe confusing, but I prefer to keep a complete help because most of py.test options are useful with testinfra (-v, -k, --fixtures etc).


refactor!: unify loggers

General
This PR starts the work of replacing loggerv and the the passed output writers with a unified and internal logger.
relates to #379
TODO

[x] Replace loggerv in binary
[x] ~Implement similar formatting as loggerv~
[ ] Replace output logging targets with a correct, likely info log-level

[x] Remove output param
[ ] Ensure napi is compatible with logger

Initial state without loggerv
$ ../../target/debug/semantic-release-cargo --log-level=trace prepare 0.2.0
DEBUG: semantic_release_cargo Building package graph
DEBUG: semantic_release_cargo manifest_path: None
DEBUG: semantic_release_cargo Setting version information for packages in the workspace.
DEBUG: semantic_release_cargo reading /workspaces/semantic-release-cargo/test_data/cycle/Cargo.toml
INFO: semantic_release_cargo Setting the version of cycle to 0.2.0
INFO: semantic_release_cargo Upgrading dependency of dep1 to<EMAIL_ADDRESS>DEBUG: semantic_release_cargo writing /workspaces/semantic-release-cargo/test_data/cycle/Cargo.toml
DEBUG: semantic_release_cargo reading /workspaces/semantic-release-cargo/test_data/cycle/Cargo.lock
DEBUG: semantic_release_cargo writing /workspaces/semantic-release-cargo/test_data/cycle/Cargo.lock
DEBUG: semantic_release_cargo reading /workspaces/semantic-release-cargo/test_data/cycle/dep1/Cargo.toml
INFO: semantic_release_cargo Setting the version of dep1 to 0.2.0
DEBUG: semantic_release_cargo writing /workspaces/semantic-release-cargo/test_data/cycle/dep1/Cargo.toml

and with the level and target removed:
$ ../../target/debug/semantic-release-cargo --log-level=trace prepare 0.2.0
Building package graph
manifest_path: None
Setting version information for packages in the workspace.
reading /workspaces/semantic-release-cargo/test_data/cycle/Cargo.toml
Setting the version of cycle to 0.2.0
Upgrading dependency of dep1 to<EMAIL_ADDRESS>writing /workspaces/semantic-release-cargo/test_data/cycle/Cargo.toml
reading /workspaces/semantic-release-cargo/test_data/cycle/Cargo.lock
writing /workspaces/semantic-release-cargo/test_data/cycle/Cargo.lock
reading /workspaces/semantic-release-cargo/test_data/cycle/dep1/Cargo.toml
Setting the version of dep1 to 0.2.0
writing /workspaces/semantic-release-cargo/test_data/cycle/dep1/Cargo.toml

This is probably a better format since it will be used across targets. I'll probably rework the log levels for everything and standardize the capitalization.

I think this is mostly there but definitely needs some testing and tweaking. I marked it ready for review just to start getting eyes/opinions on it.

I still have yet to test this against the napi api and to clean up those redundant functions. I think that's all that's left before a final pass for merging.

Seems like this PR has a simplifying effect on the main code -- I'm all for it!
What kind of testing and tweaking are you looking for before merging? We have the option to publish this as a beta release, so we can test it in a controlled environment before merging it into master. I'm happy to help set that up, if you're interested.

Yeah I think aiming for a beta for the initial release isn't a terrible idea. I have a feeling we will want to revisit a lot of log levels and formats and it might be better to let those bake in a beta for a bit.

Seems like this PR has a simplifying effect on the main code -- I'm all for it!
What kind of testing and tweaking are you looking for before merging? We have the option to publish this as a beta release, so we can test it in a controlled environment before merging it into master. I'm happy to help set that up, if you're interested.

Yeah I think aiming for a beta for the initial release isn't a terrible idea. I have a feeling we will want to revisit a lot of log levels and formats and it might be better to let those bake in a beta for a bit.

All right, just let me know when you're ready and I'll push this as the beta branch, which will trigger a release from CI

If it's landing on a beta branch, I'm probably satisfied with enough of it to land it and start getting feedback.
Largest ask is to just complain loudly about log levels and change sin that space.

Here's the pre-release: https://github.com/semantic-release-cargo/semantic-release-cargo/releases/tag/v2.4.0-beta.1
To contribute more changes, please propose them in a PR against the beta branch.

How's the beta working out for you, @ncatelli?
Do you think it's ready to merge into master?

Sorry about that @EricCrosson, I've been experimenting with independently-versioned workspace packages and haven't gotten the chance to run this through the paces over the last few weeks. I'll give this the time it deserves over the next week.

All good! Just checking in :)

I had completely forgotten about this, I think it's mostly gtg. I'll get it caught up with the target branch shortly and will leave merging it at your discretion.


nixos/cockroachdb: create new service

This adds a module to fully configure CockroachDB. This also includes a full end-to-end CockroachDB clustering test to ensure everything basically works.
This subsumes #38665, and was based off it with several amendments (including most of the changes I requested in #38665).
/cc @jbboehr
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test cockroachdb

@GrahamcOfBorg test cockroachdb

@GrahamcOfBorg build nixosTests.cockroachdb

See also https://github.com/NixOS/nixpkgs/pull/51338 in my never-ending quest to fix problems.


enable error log when istio-validation exits with a non-zero code

Please provide a description of what this PR is for.
Currently, we are unable to ascertain the exact root cause of an istio-validation container failure. It would be helpful to log the error message before exiting
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@tariq1890: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
426984539ede94078cb65bd20cb2c3caecf78f79
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@tariq1890: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
426984539ede94078cb65bd20cb2c3caecf78f79
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


CCXT: unable to fetch ticker bitfinex : bitfinex {"error":"ERR_RATE_LIMIT"}

Hi,
I'm getting the above error when trying to fetch data.  It really seems like it is quite random among the symbols, and in any case, I never really make more than few requests per minute per symbols.
I've seen this issue being reported before, but still couldn't figure out how should this situation be handle...
Thanks

Hi @kooomix ,
There are indeed some similar issues (as #196, #258) concerning Bitfinex which has a low rate limit and there are some planned improvements to catalyst to help dealing with it.
In the meantime, if you could be more specific in regards to what your algorithm is doing causing these errors, we could try to see if something can be done to bypass it.
Lena

Hi,
My algorithm make the following requests to bitfinex every 1 hour:

current volume for all symbols in one request data.current.
current price for all symbols in one request data.current.
data.can_trade for all symbols in one request.
historical volume for all symbols in one request data.history.
historical price for all symbols in one request data.history.

Notes:
*No problem with candles 1000 limitation.
*Not sure how many requests and of which type are being done by catalyst.
*Using dozens of symbols.
After additional tests I've conducted, I suspect the problem occurs only when using more than 5 symbols, regardless of the number of requests..
I hope this information is helpful, let me know how can I further help with the investigation.
Thanks

Thanks for the information @kooomix .
As mentioned also at #196, when trying to assess the number of requests performed, you should take into consideration the following:

A different request is sent per each asset
At the current implementation: a different request is sent per each field - we plan to fix it ASAP.

Probably due to the low rate limit of Bitfinex, this exchange seems to be more vulnerable to these limitations.
Hope things are more clear now.
We understand the improtance of fixing 2, but had to prioritize other things before, hope we could solve it in the coming releases.
I am closing this issue as a duplicate of #196 to prevent confusion, feel free to continue this discussion there.
Thanks,
Lena


Chicken

Closes #39
Testing Instructions:

Play the "Main" scene
Walk towards a collectible. The Chicken should be moving towards the collectible and stops when next to it
Pickup the collectible. The collectible should appear in your inventory and chicken should follow
Walk towards the other collectible. Chicken should move towards the other collectible and stops when next to it

While moving it should play a walking animation and stopped it should play a different animation

merging it in, but the chicken is bugged and will run into the items and zoom off into the distance


Bug #205573: On Prod- Inability to Check 'Consent to Share Details' Popup Checkbox After Login. (User has been created from FE -admin portal)

As we are not getting consent popup for self registered user. We are removingit for admin create user also.


FileSystemException: readSync failed, path = ‘/Users/abcc/StudioProjects/projectname/build/app/outputs/flutter-apk/app-debug.apk’ (OS Error: Invalid argument, errno = 22)

I have an application which generate around 2GB apk, now I am having run time error
FileSystemException: readSync failed, path = ‘/Users/abcc/StudioProjects/projectname/build/app/outputs/flutter-apk/app-debug.apk’ (OS Error: Invalid argument, errno = 22)
Most of the data in application is videos , it has 2.18 GB size of assets folder. I think its size issue. I cannot put data on cloud, it is necessary to put data locally, so what are the limitation , how much I can put data into assets folder , I think my assets will increate to 3GB in future.
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.5.1, on macOS 11.3 20E232 darwin-x64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
[✓] VS Code (version 1.61.2)
[✓] Connected device (2 available)

• No issues found!

Note: let me know how to tell reproduce because it will only be reproduced if you have that much data in your assets.

Hi @MuhammamdArslanKhan can you please run flutter clean and then upgrade to the latest stable channel flutter upgrade to see if the issue persists?
If the issue persists, please provide your updated flutter doctor -v.


check for broken links, esp w/ new OCNMS website

With @mspector13:

Create a 404 page

How to Find and Fix Broken Links on Your Website

Find and Replace URLs in Master_OCNMS_infographic_content - Google Sheets. Could put new URLs in new column, then switch it out when ready

This is great, thanks @bbest.
As a first stop gap, I'm going to see if I can get the pre-generated URLs for the new ocnms website and pre-populate a new column in the OCNMS master spreadsheet. If I can get those URLs, I'll rename the new column once the new site goes live. Hopefully that will reduce any hiccups


Add "Updated At" to every core widget (with toggle)

I was speaking with @davejlong on Gitter and we chatted about a suggestion I had that we add an "Updated At" line to the bottom of each core widget.
The functionality to get the updated at datetime is already in the js helper library, so it would just be a case of making the line and class appear in the JSX and SCSS (respectively) for a widget.
Also, I would like to make it a flag, on by default. Most times you would want to see how fresh the data is, but sometimes not. Like if you had static text in a text widget, you wouldn't bother probably.
If this is an acceptable plan, I am happy to submit a PR for it. I have already started but wanted to socialize the idea in an issue before a PR out of the blue ;)

Currently Kitto ships with:

list ✔
meter ✔
number ✔
text ✔
clock (does not apply)
graph (see: #86)
image (it might look ugly to display updated-at over an image)

A use case I can think of for adding updated-at to the image widget is for graph images retrieved from a service like Graphite but such services tend to have a way to embed update frequency info in the image (for example Graphite render API accepts title).

agreed with the above. I think it makes sense for it to be toggle-able (not a real word...lol), though. Do you agree?

Let's try to add it as an opt in field.

before I submit a PR, let me run the code I am considering by you:
In dashboard:

In the widget code:
showUpdated() {
    if (!this.props.showupdated) { return ""; }

    return updatedAt(this.state.updated_at);
  }

  render() {
    return (
      <div className={`${this.props.className} ${this.status()}`}>

{this.state.title || this.props.title}

{this.state.text || this.props.text}

{this.state.moreinfo || this.props.moreinfo}

{this.showUpdated()}

    );

So it's off by default. Possible values for data-showupdated are:

don't include the element in the dashboard at all - Updated At: will be not shown
data-showupdated="" - Updated At: will not be shown
'data-showupdated="<any non-empty string even 'false'"` - Updated At: will be shown

I suggest in the sample dashboard we would set at least one widget with the showupdated as shown in order to demonstrate the feature.
I would add this functionality to all the current widgets that have updated-at shown.

changes can be viewed and tested using https://github.com/mackenza/devdash_kitto/tree/optional-updated-at if you want

updated-at will be visible by default, to hide it an updatedAt property can be used.
Have a look at https://github.com/kittoframework/kitto/blob/master/installer/templates/new/widgets/number/number.js#L39
We should use "off" to disable it for consistency.
When the user has decided not to show the updated-at I don't see a reason to include the
 element.
We could have an helper function returning the updated-at element.
Function should be placed in:
https://github.com/kittoframework/kitto/blob/master/installer/templates/new/assets/javascripts/helpers.js
I'm thinking of something like the snippets below:
// In file: helpers.js
export const Components {
  UpdatedAt: function() {
    if (this.props.updatedAt == "off") { return; }

{updatedAt(this.state.updated_at)}

  }
}

// In file: widgets/text/text.js
import {Components} from 'helpers.js';

class Text extends Widget {
  render() {
    return (
      <div className={`${this.props.className} ${this.status()}`}>

{this.state.title || this.props.title}

{this.state.text || this.props.text}

{this.state.moreinfo || this.props.moreinfo}

        <Components.UpdatedAt updatedAt={this.props.updatedAt} />

    );
   }
}

After the implementation is merged, we should as you say change the demo dashboard to contain an example of this.

thx for reviewing
I had proposed updated-at being on by default, but I thought you had decided otherwise by your comment

Let's try to add it as an opt in field.

which I took as meaning you wanted it off by default and the author would need to opt in to have it shown. If I misread that, great, I thought it should be on anyway ;)
as for the returning of the whole  line from the helper (nice catch on the fact it should be in the helpers.js file, I forgot about that), I thought I had tried that and got some strange results... but I may have been returning "" rather than nothing like you are. I will test this out.

In my https://github.com/kittoframework/kitto/issues/84#issuecomment-272554132 comment I was referring to the updated-at field in the image widget, there it made sense to me to have it opt in.
In order not to have conflicting conventions, I think it's better to have have it opt out everywhere using a common UpdatedAt component (even though I still feel most people will have to disable it in the image widget).
Keep in mind that I didn't try any of the snippets I shared for the component and they are mere samples of how I imagine the feature to be implemented. If you get more strange results or need any aid on this we should discuss it on Gitter.


Request: Add the ability to support wildcard in paths, such as RunDACPAC

It would be very helpful if RunDACPAC supported wildcards for paths.  We maintain our DACPAC's in nuget packages and do not want to have to statically set the path to the nuget package (which includes the version #).
Thanks!!

I don't know how easy that would be to implement but I'll have a look. Maybe an existing copy task would work?

I'm testing a couple things now. If we come up with an elegant solution, I'll submit a PR
Sent from my iPhone

On May 24, 2017, at 7:55 AM, Andrew Lackenby<EMAIL_ADDRESS>wrote:
I don't know how easy that would be to implement but I'll have a look. Maybe an existing copy task would work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Copy files task did the trick!  Thanks for the idea!!


Do not use system node by error

If system's node is overriden by something in PATH, having NODE_DIR
empty will cause the script to still use node found in /bin/.
Only consider the first case if NODE_DIR is not empty.

Thanks!


Failed to marshal the object to TFJob; the spec is invalid: Failed to marshal the object to TFJob

Hello
I have the following tfjob yaml:
apiVersion: "kubeflow.org/v1alpha2"
kind: "TFJob"
metadata:
  name: "kubeflow_testing"
  namespace: kubeflow
spec:
  cleanPodPolicy: None
  tfReplicaSpecs:
    Worker:
      replicas: 1
      restartPolicy: Never
      template:
        spec:
          containers:
            - name: kubeflow_testing
              image: docker-registry.default.svc:5000/myproject/kubeflow_testing
              command:
                - "python3"
                - "kubeflow_run_train.py"
                - "--mode=train"
                - "--processes=1"
                - "--folder=34"

I'm using oc create -f tf_job_pgp.yaml to send this to my OpenShift cluster.
Then using oc describe tfjob kubeflow_testing -n kubeflow to inspect it. And when I run this command, I see:
Status:
  Conditions:
    Last Transition Time:  2019-02-02T00:12:03Z
    Last Update Time:      2019-02-02T00:12:03Z
    Message:               Failed to marshal the object to TFJob; the spec is invalid: Failed to marshal the object to TFJob
    Reason:                FailedInvalidTFJobSpec
    Status:                True
    Type:                  Failed
  Tf Replica Statuses:     <nil>
Events:
  Type     Reason                  Age   From         Message
  ----     ------                  ----  ----         -------
  Warning  FailedInvalidTFJobSpec  8s    tf-operator  Failed to marshal the object to TFJob; the spec is invalid: Failed to marshal the object to TFJob

I'm not sure where I'm going wrong. Can anyone please offer some guidance?

One of the containers must be 'tensorflow'. Change the container name to 'tensorflow'

Thanks


chore: enables the customization of leaseDuration and renewDeadline in the controller manager

This patch makes it possible to customize leaseDuration and renewDeadline in the controller manager.
Closes #758
Signed-off-by: Armando Ruocco<EMAIL_ADDRESS>

This is fine with me. I'm waiting for the CI to complete and for a clean e2e run

/ready-to-test

The E2e were running fine, I'm rebasing it and merging it

/ok-to-merge


Test not in line with actual implementation of DateAndTime.past()

Describe the bug
An unreleated test failed for #358 :
Error: 8.168 [ERROR] Tests run: 40, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.29 s <<< FAILURE! - in net.datafaker.service.FakeValuesServiceTest
Error: 8.169 [ERROR] net.datafaker.service.FakeValuesServiceTest.pastDateExpression  Time elapsed: 0.012 s  <<< FAILURE!
java.lang.AssertionError:

Expecting actual:
<PHONE_NUMBER>147L
to be between:
  ]1663204568040L,<PHONE_NUMBER>040L[

The value is out of bounds by 893 millis.
To Reproduce
Run net.datafaker.service.FakeValuesServiceTest.pastDateExpression multiple times until it produces a really low value.
Expected behavior
The test passes.
Additional context
A little investigation shows that the expression in the test resolves to the DateAndTime.past(int, TimeUnit) method. When looking at the implementation (and Javadoc) it shows that it takes a 1000 millisecond offset form now. The test does not. Hence this test will be flaky. Given the large range it will fail very sparsely.
I'm not sure what the thought is behind the 1 second offset / slack of the implementation. Should the test be fixed to match the implementation, or should the implementation be fixed to match the test?
And as a side-note: this kind of flaky behavior is obviously a risk that's in the nature of this library. Can we think of a way to more reliably test randomly generated values?

Fixed in https://github.com/datafaker-net/datafaker/pull/361.

an we think of a way to more reliably test randomly generated values?

This used a be quite a big issue in the past, but as long as we use things like @RepeatedTest(100) or something like that, it will catch ~99% of the issues. There's maybe other ways how to fix it, happy to hear, but for now, this works reasonably well.


master fails to build because of missing transformer_inference dir

building master with:
DS_BUILD_OPS=1 pip install -e . --global-option="build_ext" --global-option="-j8" --no-cache -v --disable-pip-version-check

    copying build/lib.linux-x86_64-3.8/deepspeed/ops/transformer_inference/transformer_inference_op.cpython-38-x86_64-linux-gnu.so -> deepspeed/ops/transformer_inference
    error: could not create 'deepspeed/ops/transformer_inference/transformer_inference_op.cpython-38-x86_64-linux-gnu.so': No such file or directory
ERROR: Command errored out with exit status 1: /home/stas/anaconda3/envs/py38-pt18/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/mnt/nvme1/code/github/00optimize/deepspeed/setup.py'"'"'; __file__='"'"'/mnt/nvme1/code/github/00optimize/deepspeed/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' build_ext -j8 develop --no-deps Check the logs for full command output.

I fixed it by doing:
mkdir deepspeed/ops/transformer_inference

As you can see this dir is missing from: https://github.com/microsoft/DeepSpeed/tree/master/deepspeed/ops
So you probably need to either create it during build or commit some dummy file into the source so that dir will be there.

This has been updated to this directory: https://github.com/microsoft/DeepSpeed/tree/master/deepspeed/ops/transformer/inference
This issue should be stale, so closing it.


Fixed URL Patterns

Currently if we want to access any of the URLs it can start with any random string as long as it ends with one of the URL patterns.
For example, example.com/api/login and example.com/api/randomstringlogin both works and gets directed to the same view.
Adding a ^ to the URL patterns fixes that.

@PotatoDrug Hi, sorry for the delay. I reproduced the issue. Could you rebase your code w.r.t. current master branch?

How do i do that?

If you have problem with that, I can cherry-pick your commit and apply it on current master. This way I could preserve the original author of the commit. However, I will need to close this PR. How about that?

I cherry-picked the commit with the actual change, so I'm closing this PR. Thanks!


BUG: No JSON object could be decoded

I'm getting these error for lots of pools not only itzod
[04:42:58] DEBUG: Error in Long Poll itzod
Traceback (most recent call last):
File "/home/alex/bitHopper/lp.py", line 162, in receive
response = json.loads(body)
File "/usr/lib/python2.6/json/init.py", line 307, in loads
return _default_decoder.decode(s)
File "/usr/lib/python2.6/json/decoder.py", line 319, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.6/json/decoder.py", line 338, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
http://pastebin.com/8ugpEcyJ
I'm not getting LP's from 5-6 pools that give this error anymore

I'm going to close this as its a non issue currently. Some pools just send out garbage and we can't do anything about it.

ack c00w


Name threads for rayon thread pool

Motivation
The code
https://github.com/libra/libra/blob/344391b12250d4c49cf31c71d70cf3b64050d38f/language/vm/vm_runtime/src/block_processor.rs#L64
uses rayon's parallel iterator, which initializes the rayon global thread pool the first time it runs. Since the parent thread is the block_processor thread in executor, all these rayon threads also have the name block_processor, which causes some confusion. We name these threads explicitly.
Have you read the Contributing Guidelines on pull requests?
Y.
Test Plan
Run nodes locally and print out all thread names.
Related PRs
None.

@bors-libra r+

:pushpin: Commit ddc0c6c has been approved by lightmark

:hourglass: Testing commit ddc0c6c2b21d00007d930996756dba8eca269ec3 with merge 21c9a9c774c18ed8958884f0342272e58877f7ca...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:hourglass: Testing commit ddc0c6c2b21d00007d930996756dba8eca269ec3 with merge ed1a01213ab0927f84b81ba4be604d866143e120...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: lightmark
Pushing ed1a01213ab0927f84b81ba4be604d866143e120 to master...


Deprecate support for Xing replication

A few bits of legacy code are lingering in the public API; these can be deprecated as we don't plan to support actual execution of the Xing replication because it doesn't follow the MORF workflow.

complete; see upcoming commit!


sync lockfile

it's just dev deps - doesn't matter

Yeah lerna always does this after a release and I also do that manual fix lock commit. Forgot this time.


SineWave has growing levels of distortion over time because of float round off errors

This is one of the two issues found in https://github.com/tomaka/rodio/issues/201.
There's random noise that creeps in as the float32 shifts exponent sizes as shown in the image below. The image below is a constant 3000 hz sine wave. In the top part of the image is a waterfall plot showing the growing frequency distortion spread as the float errors increase.

Note: still an issue with new SignalGenerator however #202 no longer works.
@iluvcapra as this is your baby :) do you have time and if so would you like to address this? No issues if you can not we can take care of it. For context see the last few messages in #202.

Yeah I can take a look this week, it should be possible to just modulo t by the wavelength and that should resolve this I think.

Check this out ☝ I need to actually run it through an RTA to see if this is well and truly done but I think I've addressed the theoretical problem.

Check this out ☝ I need to actually run it through an RTA to see if this is well and truly done but I think I've addressed the theoretical problem.

very nice thanks for working on it :+1:, I left some feedback but I am no audio expert so I may very well be wrong!


[BUG] Glob not matching changed files

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
I'm attempting to detect changed files in a directory like files: dir1/**. The changed files are not matched. any_changed is false and the changed files are only listed under other_changed_files. I think this means they were detected as changed but didn't match the glob as expected.
I've reproduced the issue with v32.0.0, v32, v33, and v34.
It works as intended on v31.0.3.
To Reproduce
Action:
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
      - name: Get new and changed files in the schema directory
        id: schema-files
        uses: tj-actions/changed-files@v34
        with:
          files: |
            dir1/**
      - run: echo '${{ toJSON(steps.schema-files.outputs) }}'
      - name: Schema file added, copied, modified, or renamed
        if: steps.schema-files.outputs.any_changed == 'true'
        run: |
          gh pr review "$PR_URL" --comment --body "Please do not edit files in dir1."
        env:
          PR_URL: ${{github.event.pull_request.html_url}}
          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

Change a file at path dir1/foo/file.txt and push.
What OS are you seeing the problem on?
ubuntu-latest or ubuntu-20.04
Expected behavior?
Expected any change in the directory to match.
Relevant log output
Run tj-actions/changed-files@v33
  with:
    files: dir1/**

    separator:
    include_all_old_new_renamed_files: false
    old_new_separator: ,
    old_new_files_separator:
    files_separator:

    files_ignore_separator:

    sha: be5f2cdccb27eccdc6988f2e7a56a8e208da230d
    path: .
    quotepath: true
    dir_names: false
    json: false
    target_branch_fetch_depth: 20
Run # "Calculating the previous and current SHA..."
changed-files-diff-sha
Run tj-actions/glob@v15
...

Sounds kind of similar to #450, but seems distinct.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Ah ha! I narrowed it down further. dir1 from my example is in the repo's .gitignore. .gitignore behavior changed here:

https://github.com/tj-actions/glob/pull/434
https://github.com/tj-actions/changed-files/pull/670

In this case I'll recommend using https://github.com/tj-actions/verify-changed-files which tracks changes to unstaged files.


Code example from "Implicit Instantiation from "Main" Storyboard" section doesn't compile

When I try to implement extension for SwinjectStoryboard (with my own types of course), I get a compilation error "Value of type 'Container' has no member 'storyboardInitCompleted' "

Thanks for pointing out this problem! 👍
storyboardInitCompleted is new name for method registerForStoryboard (see #22). However, this change has not yet been released, but is already reflected in documentation on master branch.
You can view documentation in line with latest release here.

Thanks for the so quick answer! :)
You do a great job, guys!


Fix paths

What changed? Why?
Update paths of some redirects to absolute paths.
Notes to reviewers
N/A
How has it been tested?
Manually
Does this PR add a new token to the bridge?
Are you adding an entry to assets.ts?

[x] No, this PR does not add a new token to the bridge
[ ] Yes, and I've confirmed this token doesn't use a bridge override
[ ] Yes, and I've confirmed this token is an OptimismMintableERC20

If you are adding a token to the bridge, please include evidence of both confirmations above for your reviewers.

Review Error for zencephalon @ 2024-04-07 12:44:13 UTC
User failed mfa authentication, see go/mfa-help


[suggestion] WHEN CAN WE ADD ICON?

Well, I wanted to add icons. But there seem to be no options.

You can right now. Press the "Change Icon/Assembly" button and select an Icon.

oh ok I had the older version.


#8: Updating version of terraform-instances used

Fixes https://github.com/skyscrapers/terraform-neo4j/issues/8

@leonyork thanks for your contribution. I've created a new release (0.10.0) with your changes.


Notebook/IW language client middleware as separate module

While working on interactive window and notebook language support / bug fixes, we found that the scope of the notebook/iw support for intellisense is in an isolated scope (a client middleware), which doesn't rely on other components of the Python extension (there is one actually, logger). The idea behind this PR is moving the code into its own module, with which we can:

maintain the middleware in its own repo, with its own integration and unit tests (and CI as well)
rapid development on the repo at our own pace
publish/update the module in Python extension when all necessary changes are in, well-tested, and pass the CI of the Python extension

This change should not be part of the coming stable release, to ensure us we have enough testing and usage from Insider users.

Do you have a link to the npm module? Or the repo that sets it up?

@rchiodo this is the repo https://github.com/microsoft/vscode-jupyter-lsp-middleware, I have added all jupyter members to the repo.


feature: add systemd notify

For the case that systemctl start pouch, we need to make sure that the
pouchd has been started successfully. We cannot rely on the exit code
of systemctl only, we need to use NOTIFY_SOCKET to send the state to
the systemd.

Ⅰ. Describe what this PR did
For the case that systemctl start pouch, we need to make sure that the pouchd has been started successfully. We cannot rely on the exit code of systemctl only, we need to use NOTIFY_SOCKET to send the state to the systemd.
So when the pouchd has set up , it will send the state to systemd
Ⅱ. Does this pull request fix one issue?

fixes #1568
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews

Codecov Report

Merging #1577 into master will decrease coverage by 0.85%.
The diff coverage is 48.57%.

Since we don't have the adaptor to handle different servers, next step we can make it elegant.

But I need to confirm the version of dependency because it is different from https://github.com/alibaba/pouch/pull/1431/files

Confirm. We can merge it


Moving the Nav Bar Leaves Black Bar in its Place

Version
Tell us which versions you are using:

react-native-router-flux v^4.0.0-beta.23
react-native ^0.50.3

Expected behaviour
I can move the nav bar from its original position (at the top) to somewhere of my choosing, like at the bottom of the screen, a common iOS UX pattern.
Actual behaviour
Using a navigationBarStyle like navigationBarStyle={{ backgroundColor: '#26a69a', top: 300 }} effectively moves the nav bar from its original position, but leaves a black view of its same dimensions in its place (it actually takes up that space). See screenshot: https://www.dropbox.com/s/yjmxozsd5fyl5aj/Screenshot 2017-12-01 09.26.27.png?dl=0
Steps to reproduce

Define some boilerplate for a router and a scene
Set the navigationBarStyle to something like navigationBarStyle={{ backgroundColor: '#26a69a', top: 300 }}to move the nav bar from its original position
Inspect the black bar at the top of the screen and notice it comes from createAnimatedComponent.js

Conclusion
My team and I made an iOS app using RNRF v3 and did manage to put the nav bar on the bottom of the screen by passing a navigationBarStyle. Is this not intended in v4?
Is moving the nav bar to the bottom of the screen something people do? Is it valid? Is there some other way to achieve a similar function, like a tab bar?
This issue is similar to https://github.com/aksonov/react-native-router-flux/issues/1218.

@aksonov is this intended?


gcc-arm-embedded: 9-2020-q2-update -> 10-2020-q4-major

Motivation for this change
New major version of embedded GCC
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 107802 run on x86_64-linux 1

4 packages built:

blackmagic
gcc-arm-embedded (gcc-arm-embedded-10)
opentx
tinygo

Result of nixpkgs-review pr 107802 run on x86_64-darwin 1

1 package failed to build:

tinygo

1 package built:

gcc-arm-embedded (gcc-arm-embedded-10)


Update FileTransferBackground.java

On upgrade event of old upload (failed) are broadcasted twice on android

@azharbeebeejaun pour info je merge cette PR !


mWeb - Copilot - On refreshing copilot magic code page, user directed to previous page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: V9. 0.75-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: User Settings
Action Performed:

Go to https://staging.new.expensify.com/home
Go to settings - security - copilot
Select a user - full access
Tap add copilot
Enter a incorrect magic code
Refresh the page

Expected Result:
On refreshing copilot magic code page, user must not be directed to previous page.
Actual Result:
On refreshing copilot magic code page, user directed to previous page.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/b193a2b4-cdbb-482c-b5cb-1d7807460048
View all open jobs on GitHub

cc @dangrous @rushatgabhane can you guys take a look at this one please?

^ above proposal looks good

Proposal
Please re-state the problem that we are trying to solve in this issue.

On refreshing copilot magic code page, user directed to previous page.

What is the root cause of that problem?

The magic code page is just a modal, and it is displayed if isValidateCodeActionModalVisible is true. But the default value of isValidateCodeActionModalVisible is false unless we use showValidateActionModal in screen param:

https://github.com/Expensify/App/blob/10bfe9ab2895923c3f985d6529f6ff25809053e4/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx#L35

So once we refresh the page, the isValidateCodeActionModalVisible is false.

What changes do you think we should make in order to solve the problem?

As mentioned in the RCA section, we can leverage the showValidateActionModal screen parameter to ensure the modal is displayed after a page refresh if it's set to true. The key point is to keep the showValidateActionModal parameter synchronized with the isValidateCodeActionModalVisible state. For example, when the modal is opened, set showValidateActionModal to true; when it’s closed, set it to false. Specifically, we can add a useEffect to this section:

    const navigation = useNavigation();
    useEffect(() => {
        navigation.setParams({showValidateActionModal: isValidateCodeActionModalVisible});
    }, [isValidateCodeActionModalVisible]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Adding external to get this prioritised.

Waiting for updates still.

@allgandalf thanks! looking forward to your comments :)


React 16 Portals support

Hi there!
What needs to happen for React 16 Portals to be supported? Is that something someone could take on and submit a PR for? The portal-progress branch seems to be behind master, but might be what is shipped on NPM?

Hi! Yeah, I’d gotten started on a Portals implementation in the portal-progress branch, but haven’t really had the time to continue it lately. It’s certainly something someone could take on and submit a PR for!

On Oct 9, 2018, at 6:19 PM, Daniel Bergey<EMAIL_ADDRESS>wrote:
Hi there!
What needs to happen for React 16 Portals to be supported? Is that something someone could take on and submit a PR for? The portal-progress branch seems to be behind master, but might be what is shipped on NPM?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/alexkatz/react-tiny-popover/issues/18, or mute the thread https://github.com/notifications/unsubscribe-auth/AEB2GvLuaR8ByMk94i8RH_lGFWV2cbaHks5ujSDjgaJpZM4XUPMz.

I know this is a late reply but would love to see portals used (esp in place unstable_renderSubtreeIntoContainer). I may be able to work on this a bit, but just wanted to know what the status of the portal-progress branch was?


Deploy to the public Cloud

https://devops-orders.us-south.cf.appdomain.cloud/

Since this deployment is performed in the cloud. There's no PR for this.


GA fix

current:
Conversion click
updated:
Conversion Swap Click
(FYI it used to be Conversion Swap Click before)

hotfix to main in commit https://github.com/bancorprotocol/webapp-v2/commit/32467ccefc5c6f71e7013960c9ab2c60bb8c5161


DB refactoring

Coverage decreased (-0.2%) to 14.162% when pulling b1a0822dc1e2fb9f1423d6f1f814fbede7166155 on corny:db_refactoring into 2a73171bb9e85d9f47d9c77b5e8a2a00af40ae0d on taktv6:master.

Coverage decreased (-0.2%) to 14.162% when pulling 83bb3109ff2499cd8061a1bab6db7dc2fe0ba400 on corny:db_refactoring into 2a73171bb9e85d9f47d9c77b5e8a2a00af40ae0d on taktv6:master.


race condition with limit

bus = mesh.limit(1, bus);

// fallback is async - second arg gets hit first
bus = mesh.accept("load", mesh.fallback(bus), bus);
bus(mesh.op("load"));
bus(mesh.op("insert")); // this gets executed first

Fix is to put limit at the end. This is a bit awkward though.

also this

  bus = mem = mesh.limit(1, bus);
  bus = mesh.reject("load", mesh.tailable(bus), bus);

bus(mesh.op("insert"));
bus(mesh.op("load")); // executed first - shouldn't happen

This will be fixed with 5.x.


Ipython notebook support

I'm sorry for making a mess of the conversation (this being the 3rd PR for the same feature)
I was more careful merging with newer stuff in the develop branch, I think I have done it right this time. Please let me know if anything is still off.

https://github.com/gogits/gogs/pull/4068
https://github.com/gogits/gogs/pull/4067

The .less looks good now!

Good, that leaves a go file and two templates :)

Just noticed the PR include everything of marked, shouldn't we only need JS, CSS and some images? Tests, for example, are useless as dependency here.

I simply added the whole 'release' of marked as provided on github, I would not know whether it's a good idea to delete parts.

You only need to as result of build or dist, like the this. Not everything.

Ping?

@Unknwon I admire your commitment to this PR-request, but please don't talk to me like I'm a networking interface.
Anyhow, I removed a significant amount of (superfluous) javascript and repulled the develop branch.

but please don't talk to me like I'm a networking interface.

Sorry for any uncomfortable, it's a quick and common way on GitHub to verify if a thread still active.
New changes look good, merging. Thanks again!

OK, finally on demo! https://try.gogs.io/unknwon/ipython-notebooks
The only small problem is this file: https://try.gogs.io/unknwon/ipython-notebooks/src/master/nmf_topics.ipynb
The JS error seems notebook.js couldn't render it.

@Unknwon No worries, I assumed no bad intend.
I think the nmf_topics-bug might be a notebook.min.js. A solution from our side might be to have graceful-degradation to the plain json-file if the notebook does not render. (Although I would guess nobody is really interested in the JSON in practice).

@prinsherbert roughly next Tuesday (2/14/2017).

Cool, thanks!


Fix handling of Chunked requests

Add fix for handling chunk encoding requests.
If ENABLE_CHUNK_ENCODING is set to true, for requests with transfer
encoding set to true. It will set wsgi.input_terminated to true which
tells werkzeug to ignore content-length and read the stream till the
end.
Fixes https://github.com/airbnb/superset/issues/1720

@xrmx Any more comments ?

@xrmx: Any more comments on this ?

@nishantmonu51 nope, looks fine to me

@xrmx: can this be merged then ? do i need to contact someone else for getting this in ?

@mistercrunch: please review.

LGTM
@nishantmonu51 I granted you write rights on the repo, please confirm by merging the PR!


ReaderWriterLockSlim reports inncorrect RecursiveReadCount in debugger.

I'm creating a transaction.  At the end of the transaction, I release any locks on the object.  Based on the data encountered, the application may have taken an Upgradable Read Lock and promoted it to a Write Lock, so I'm never guaranteed to know what state the lock is in at the end of the transaction.  I have the following logic to deal with this scenario:
        public ReaderWriterLockSlim Lock { get; } = new ReaderWriterLockSlim();

        private void OnTransactionCompleted(object sender, TransactionEventArgs transactionEventArgs)
        {
            if (this.Lock.IsReadLockHeld)
            {
                this.Lock.ExitReadLock();
            }
            if (this.Lock.IsWriteLockHeld)
            {
                this.Lock.ExitWriteLock();
            }
            if (this.Lock.IsUpgradeableReadLockHeld)
            {
                this.Lock.ExitUpgradeableReadLock();
            }
        }

Using this outline, I've noticed that the debugger is giving me false indications that a Read lock is active on this object after running this code.  I've placed Assert statements (asserting that there's no reader lock), and they haven't been tripped, but the debugger is adamant that the RecursiveReadCount is 1 and a Read lock is held.
In researching this, I came across several old articles claiming that we shouldn't use the IsReadLockHeld property except in Asserts and debugging.  So I have two issues: #1, the debugger is clearly giving me a false indication and #2, is this pattern valid?  If not, how are we supposed to release the locks when we don't have a guarantee that they've been locked (like with an Upgraded Read lock in a transaction)?

This repository is not the right place to report issues or ask questions about .Net Framework.
If you want to report an issue, the right place is the .Net Developer Community.
If you want to ask a question, I think the best place is Stack Overflow.

This repo only tracks infrastructure issues regarding the following items:

Missing or outdated source in this repository
Reference Source Browser (http://referencesource.microsoft.com/)
Debugging the .NET Framework using Reference Source

For issues regarding functionality, please use the following resources:

BCL. https://github.com/dotnet/corefx
ASP.NET. https://github.com/aspnet/home
Everything else. https://connect.microsoft.com/VisualStudio/feedback/LoadSubmitFeedbackForm


Add auto generated API docs using apigen with twitter-bootstrap template

Hi,
currently there is no further documentation besides the User Guide to get some insights into the framework so generated an API documentation with apigen using the twitter-bootstrap template.
apigen generate --source Slim --destination docs --template-theme bootstrap

Coverage remained the same at 98.149% when pulling b2de65715f386b488cc9726e345dbefc4df0d290 on crtl:auto-generated-api-docs into 91afa6050372a3888fc4464cfc997473dd3f9377 on slimphp:3.x.

I will review this later on today :)
On Thu, Mar 16, 2017 at 8:28 AM Coveralls<EMAIL_ADDRESS>wrote:

[image: Coverage Status] https://coveralls.io/builds/10624444
Coverage remained the same at 98.149% when pulling b2de657
https://github.com/slimphp/Slim/commit/b2de65715f386b488cc9726e345dbefc4df0d290
on crtl:auto-generated-api-docs into 91afa60
https://github.com/slimphp/Slim/commit/91afa6050372a3888fc4464cfc997473dd3f9377
on slimphp:3.x.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/slimphp/Slim/pull/2171#issuecomment-287042257, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD100lY7KIfNAVpsG_KYJZBUuRkhsq-tks5rmSsHgaJpZM4MfOqk
.

@crtl have you seen https://github.com/slimphp/Slim/issues/1617 ?

@akrabat @codeguy @silentworks thought's on merging this into this repo?
I was thinking about how it might be nice to have this on the website too.

The only thing I care about is that it's automated

I took a quick look, it does not appear to be automated. It would need to be run after we tag a new version.

@akrabat its not, you would have to generate them manually. But its only one command "the one in my post"

As per other issue: https://github.com/ApiGen/ApiGen/wiki/Generate-API-to-Github-pages-via-Travis

Generally, I think the odds of remembering to do it manually are low

Another thought.  This needs to be on the Slim-Website repository as we're going to need this for 3.x and 4.x.
Maybe this needs to be a bash/php script that is on Slim-Website that checks out the Slim repo, creates the api docs in the right place on the website and then deletes the Slim repo?


Roll Flutter Engine from 85f3f02e5c37 to e8f7af5fddda (1 revision)

https://github.com/flutter/engine/compare/85f3f02e5c37...e8f7af5fddda
2023-09-12<EMAIL_ADDRESS>Roll Skia from 72e5b5c8d5f0 to 5b94fc73a36e (1 revision) (flutter/engine#45701)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Dexie Syncable with Dexie 3.0.0

Am i correct to assume the current version of Dexie syncable will not work with Dexie 3.0.0?
I get a lot of namespace errors, and import errors such as
cannot augment module 'Dexie' with value exports because it resolves to a non-module entity.

Hi! They are runtime compatible but there might be typing issues.

Okay. Thank you very much

Hello, Sorry for re-opening this one. Do you have any suggestions for fixing the typing issues for this? Although the package is working, we're unable to run any build pipelines due to the typing issues.
Thank you

Any contribution of the typings are welcome. If someone could provide me with a PR with the changes needed in Dexie.Syncable.d.ts and api.d.ts, I can release a new version of the addon.

I'm working on this now

Awesome. Thank you very much

I've published new versions of dexie-observable and dexie-syncable on npm that should be type-wise compatible with Dexie 3.0. Any feedback on these would be much apprechiated:
npm i dexie-observable@next dexie-syncable@next

Anyone who have tested the addons?
npm i dexie-observable@next dexie-syncable@next


Add Flyway file for lastUpdateTimeViaEpp

See b/248035435 for more details / reasoning, but basically this will make it easier if we ever need to restore user actions in the future (or figure out which user actions went wrong)

This change is

last_epp_update_time reflects the last update of basically any of the EPP-related fields. As commented on the bug, it can be updated in situations like autorenews or removal of grace periods (things that happen during projection) meaning that it does not actually reflect the last time an EPP request was sent that updates this field.
i'm not necessarily 100% convinced that we need to do this, but this helps protect against the type of situation where the Domain and DomainHistory objects get out of sync (what happened last September). last_epp_update_time wasn't usable / valid then because of the aforementioned other ways in which it could be changed.
update_timestamp is just the basic field that gets updated any time anything happens


Packager cannot start on new window on Windows

See comment referring this issue on private-cli/src/runAndroid/runAndroid.js.
To workaround this issue you can simply open another console and launch packager.sh from there.

Will document this in log message.


Revert "upgrade the go version to 1.18 (#2454)"

This reverts commit 089ee12419b331fe4f63ec6316e7f0b375cd7e9a.

Codecov Report

Merging #2455 (089ee12) into main (089ee12) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 089ee12 differs from pull request most recent head d79e994. Consider uploading reports for the commit d79e994 to get more accurate results

@@           Coverage Diff           @@
##             main    #2455   +/-   ##
=======================================
  Coverage   61.70%   61.70%
=======================================
  Files         137      137
  Lines       25563    25563
=======================================
  Hits        15773    15773
  Misses       7949     7949
  Partials     1841     1841

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


bundle should ignore GIT_DIR and GIT_WORK_TREE

Following problem:
When I export GIT_DIR or GIT_WORK_TREE before I install some git-gems with bundler it fails.
Example:
[hag@hannes bundler-nuke]$ export GIT_DIR=bla
[hag@hannes bundler-nuke]$ export GIT_WORK_TREE=bla
[hag@hannes bundler-nuke]$ env | grep GIT
GIT_DIR=bla
GIT_WORK_TREE=bla
[hag@hannes bundler-nuke]$ bundle
Fetching<EMAIL_ADDRESS>Password:
remote: Counting objects: 24, done.
remote: Compressing objects: 100% (14/14), done.
remote: Total 24 (delta 6), reused 24 (delta 6)
Unpacking objects: 100% (24/24), done.
fatal: Not a git repository: 'bla'
Git error: command `git rev-parse master` in directory /usr/local/rvm/gems/ruby-1.9.2-p290/cache/bundler/git/cautious-fbb660f0d922632431a445e4b9a93fac438a29e0 has failed.
If this error persists you could try removing the cache directory '/usr/local/rvm/gems/ruby-1.9.2-p290/cache/bundler/git/cautious-fbb660f0d922632431a445e4b9a93fac438a29e0'

However I think, this behavior is not wanted since these variables may be used for something else.
I think bundler should set the --work-tree and --git-dir options to their default values when interacting with its git repos.

Unfortunately, last time we tried to switch to --work-tree and --git-dir, submodules stopped working. There's a pull request you can check to see the issues that came up. It honestly seems like it might just be easier to explicitly clear GIT_DIR and GIT_WORK_TREE when Bundler invokes git in a subshell.


[Bug] directories containing only source .yml files are reported as lacking configuration paths and config directives not applied

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
We are using the helpful dbt-meta-testing package (https://github.com/tnightengale/dbt-meta-testing) to validate that certain kinds of tests exist for all sources and models in our dbt project.
One of the directories in our project is used only for source definitions. E.g. we have a structure like this:

models

source_yml

source_1

source_2

We want to use dbt_meta_testing to enforce that sources also have certain kinds of tests. We define a separate .yml file for each incoming table, so, if source_1 has two tables, we will have two .yml files, e.g. table_1.yml and table_2.yml. Then the contents of table_1.yml would look like this:
version: 2

sources:
  - name: source_1
    database: fivetran-dev
    tables:
    - name: bench_cost_report

      freshness:
        error_after: {count: 2, period: hour}

      loaded_at_field: _fivetran_synced

      columns:
        - name: created
          tests:
            - not_null

        - name: report_date
          tests:
            - not_null

        - name: last_updated
          tests:
            - not_null

        - name: created_by
          tests:
            - not_null

        - name: bench_cost_report_id
          tests:
            - not_null
            - unique
            - dbt_utils.at_least_one

Then we want to use dbt_project.yml with dbt_meta_testing to validate that every source in each of these directories has a unique test, a not_null test, and an at_least_one test. So we do this in our dbt_project.yml:
    source_yml:
      source_1:
        +required_tests:
          "^unique$": 1
          "^not_null$": 1
          "at_least_one$": 1
      source_2:
        +required_tests:
          "^unique$": 1
          "^not_null$": 1
          "at_least_one$": 1

However, what happens right now when we do this is dbt gives us this warning:
15:33:06  [WARNING]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.
There are 2 unused configuration paths:
- models.project.source_yml.source_1
- models.project.source_yml.source_2

But that's not true - there are resources defined there - it's just that they are not models, they are sources. Can dbt be made more robust in validating cases like this where other objects like sources exist in a directory even if models don't? Also, it looks like dbt_meta_testing isn't able to validate missing tests in these directories - I tried "testing for failure" to see if it would catch a missing test, and it doesn't. That may be a bug with dbt_meta_testing but I wonder if it's actually an underlying issue with dbt core because core isn't somehow detecting or parsing the sources in these directories in the same way as it is for other models.
Expected Behavior
I would expect dbt core to detect a case where a directory has only sources, or any other type of non-model resources defined in a directory, appropriately apply configuration directives defined in dbt_project.yml, and then also not give a warning that paths are defined in dbt_project.yml which do not apply to any resources.
Steps To Reproduce

Create a directory in the dbt project and then add only one file in it with a source definition
Create a configuration directive in dbt_project.yml which applies to this directory.
Run a dbt command and see output warning and also how config directive is ignored.

Relevant log output
15:33:06  [WARNING]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.
There are 2 unused configuration paths:
- models.project.source_yml.source_1
- models.project.source_yml.source_2

Environment
- OS:MacOS Ventura 13.3.1
- Python:3.9.6
- dbt: 1.5.0

Which database adapter are you using with dbt?
bigquery
Additional Context
No response

Thanks for reaching out @codigo-ergo-sum !
Does your dbt_project.yml look like this, by any chance?
models:
  my_project:
    source_yml:
      source_1:
        +required_tests:
          "^unique$": 1

If so, could you try replacing models: with sources: instead?
sources:
  my_project:
    source_yml:
      source_1:
        +required_tests:
          "^unique$": 1

When I do the former and execute dbt ls, I get the same warning as you. When I do the latter, the warning goes away.

Thanks @dbeatty10. So you are right, I should have thought of that, that "works" in the sense that dbt is no longer complaining about unused configuration paths.
Unfortunately, it looks like dbt_meta_testing doesn't support validating required tests for sources nor for seeds, only for models. I filed a ticket asking about that: https://github.com/tnightengale/dbt-meta-testing/issues/26
As a larger question though, why have separate hierarchies like this for models versus sources in the dbt_project.yml file? Sources and models both occupy the same directory hierarchy under models in the directory structure and it can result in code duplication and confusion having to look in two different places. I can sort of see it for seeds as they have a separate directory hierarchy structure.

Glad that this "works" for you now in the sense that dbt is no longer complaining about unused configuration paths.
I trust and hope that the issue you've opened in dbt_meta_testing will be able to get you the rest of the way there. 😎
Question

why have separate hierarchies like this for models versus sources in the dbt_project.yml file?

Good question! Those hierarchies within dbt_project.yml are separated by resource type since they have different expected key structures:

source
model
seed
snapshot
test

e.g., sources has this hierarchy:

project name > source name > table name

whereas models has this hierarchy:

project name > directory

Also each resource type has different configurations that are available to it and you may want configure each differently.
Next steps
It seems like dbt-core is working as intended here, and I'd like to close this unless we have something outstanding left to cover. What do you think @codigo-ergo-sum ?

Hi @dbeatty10. Is it not possible to specify a setting that applies across all tables for a given source? I'm running into issues referring to this by the actual source names, from our dbt_project.yml file:
sources:

  oba_postgres_public:
    +required_tests:
      "^unique$": 1
      "^not_null$": 1
      "at_least_one$": 1
  oba_postgres_secure_db:
    +required_tests:
      "^unique$": 1
      "^not_null$": 1
      "at_least_one$": 1

Which gives me this message:
23:00:22  [WARNING]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.
There are 2 unused configuration paths:
- sources.oba_postgres_secure_db
- sources.oba_postgres_public

Also including our project name doesn't work either:
sources:

  op_analytics:

    oba_postgres_public:
      +required_tests:
        "^unique$": 1
        "^not_null$": 1
        "at_least_one$": 1
    oba_postgres_secure_db:
      +required_tests:
        "^unique$": 1
        "^not_null$": 1
        "at_least_one$": 1

Output:
23:03:02  [WARNING]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.
There are 2 unused configuration paths:
- sources.op_analytics.oba_postgres_secure_db
- sources.op_analytics.oba_postgres_public

Is it not possible to specify a setting that applies across all tables for a given source?

It is possible to specify a setting that applies across all tables for a given source within dbt_project.yml, but you'll need to get the folder structure just right.
@codigo-ergo-sum could you give the following a try and let me know if it works for you or not?
Example
Folder structure:
models
└── some
    └── very
        └── deeply
            └── nested
                └── folder
                    └── _sources.yml

models/some/very/deeply/nested/folder/_sources.yml
version: 2

sources:
  - name: oba_postgres_public
    tables:
    - name: some_table_1
  - name: oba_postgres_secure_db
    tables:
    - name: some_table_2

dbt_project.yml
name: "my_project_name"
version: "1.0.0"
config-version: 2
profile: "sandcastle"

sources:
    some:
      very:
        deeply:
          nested:
            folder:
              oba_postgres_public:
                +required_tests:
                  "^unique$": 1
                  "^not_null$": 1
                  "at_least_one$": 1
              oba_postgres_secure_db:
                +required_tests:
                  "^unique$": 1
                  "^not_null$": 1
                  "at_least_one$": 1

Finding the full path for all your sources:
dbt -q ls --output json -s 'source:*' | python -m json.tool --json-lines
dbt -q ls --output json --resource-type source | python -m json.tool --json-lines

Or for one particular source:
dbt -q ls --output json -s source:my_project_name.oba_postgres_public.some_table_1 | python -m json.tool --json-lines

{
    "name": "some_table_1",
    "resource_type": "source",
    "package_name": "my_project_name",
    "original_file_path": "models/some/very/deeply/nested/folder/_sources.yml",
    "unique_id": "source.my_project_name.oba_postgres_public.some_table_1",
    "source_name": "oba_postgres_public",
    "tags": [],
    "config": {
        "enabled": true
    }
}


Add require-trusted-types-for 'script'; in CSP header

https://stackoverflow.com/questions/62081028/this-document-requires-trustedscripturl-assignment

Close as the header currently is in very early stage.


a kind documentation/errata of celluloid-related memory leaks

@niamster ready to merge this into the prerelease? It looks complete?

Is there actually a reason to have this test skippable?

@digitalextremist yes, it looks complete for me. If I remove 'include Celluloid' from the target class the test is passed with 90% probability.
@e2 it's skipped by default but put into 'allowed failures' for Travis. The reason is that there are still leaks that are linked to ruby itself rather than Celluloid and there's no clean solution to avoid them(see #463)

@niamster - if I understand correctly, this spec should be enabled on jruby and rbx (because it's expected to pass) and it should be always disabled on MRI (until there's a workaround).
Either a test can pass 100% of the time - and should be enabled (on whatever platforms support it), or disabled completely (until it works 100% of the time on MRI as well).
I think of this as a test protecting against introducing certain memory leaks - and so it should enabled everywhere it can.
Also, think of JRuby (and RBX) as the main interpreters for Celluloid. MRI is the one that should have special patches to match the behavior of the other two.

I'm a bit off radar today but just wanted to say: I believe it's the opposite @e2. MRI isn't leaking and jRuby / rbx are. So those will fail unless @niamster figured out how to work around this. I saw Fiber.yield come in, so maybe he did!
On April 9, 2015 3:18:29 AM PDT, Cezary Baginski<EMAIL_ADDRESS>wrote:

@niamster - if I understand correctly, this spec should be enabled on
jruby and rbx (because it's expected to pass) and it should be always
disabled on MRI (until there's a workaround).
Either a test can pass 100% of the time - and should be enabled (on
whatever platforms support it), or disabled completely (until it works
100% of the time on MRI as well).
I think of this as a test protecting against introducing certain
memory leaks - and so it should enabled everywhere it can.
Also, think of JRuby (and RBX) as the main interpreters for
Celluloid. MRI is the one that should have special patches to match the
behavior of the other two.

Reply to this email directly or view it on GitHub:
https://github.com/celluloid/celluloid/pull/561#issuecomment-91184053

@digitalextremist I didn't try these tests with rbx and jruby.

Going to push new one with a changeset which fixes one of the leaks in MRI.


IT-3317: Update Notebook product to use v1.3.3 of service-catalog-library

Update Notebook product to use v1.3.3 of service-catalog-library

Do you keep v1.3.2?

Sorry, I don't understand the question.


What do you think about Serialize and Default impls?

I was wondering if this would be a good crate for automatically generating workflow files. But the types only implement Deserialize. What do you think about Serialize and Default too?

I took a brief stab at it, but it's not clear what the Default impl for some of the types should be.

Serialize makes sense, but Default is harder, yeah. I'd be happy to review PRs that add/propose either, however!

NB: The latest release (v0.4.0) includes Step: Serialize (and similarly for a few types within Step).

Thank you!


Image-to-Video Model?

Where is the image-to-video model? I can only find generating a small series of images.

The dev said it's only for comic generation for now. There is no code related to the video generation that I see either, all looks pretty comic to me.


Using values for TP.1 version

/retest

Waiting for https://github.com/openshift-service-mesh/sail-operator/pull/17 which should resolve the e2e test failures

/retest

/retest


Support for flag to disable clear screen on return

Feature request
Thanks for developing and maintaining this library. Would you be open to adding a flag to disable the restart on return behavior when running in watch mode ?
Why?
When server generates a lot of logs, I often use returns to create a visual gap between  past output and next output before performing some action so that it is easier to see eg. what all db queries were executed as part of a specific request handling.
I don't mind manually restarting through Ctrl+c ctrl+p enter  but every now and then I find myself accidentally restarting server when trying to add some vertical space in console output out of muscle memory.

Does tsx watch --clear-screen=false work for you? (from https://github.com/esbuild-kit/tsx/pull/23)

This is not quite what I wanted though - it prevents the screen from clearing up which is good, which it still restarts the server which I don't want to happen.
I am proposing a similar flag which prevents the restart as well.

I also find this behavior non intuitive. I have attempted to address this in https://github.com/esbuild-kit/tsx/pull/220.

Instead of disabling it completely, I prefer to change it so there's a better way to trigger a reload manually.
Do you know what nodemon does?

nodemon supports rs<enter>  for restarting the server.

Typing in multiple characters as a command seems confusing to me and would interfere with stdin (https://github.com/esbuild-kit/tsx/issues/163).
Ctrl+R is generally used for reverse search outside of a process, but I wonder if we can leverage it to trigger a reload inside of tsx.
@nirajsavaika Would you mind experimenting in your PR?

While I'm sure a better solution will be available at some point, for other who reach here looking for a solution to disable restart-on-enter conveniently, here is a simple alternative:
echo "" | npx tsx watch some-script.ts

What about little restarting delay with signals counter? Like two or more 'enter' signals per 500ms shouln't cause restart.

Ideal solution
Manually reload watch via Ctrl+r
Problems

Listening to Ctrl+r seems to require putting stdin in "raw mode" (process.stdin.setRawMode(true)), which disables all native shortcuts like Ctrl+c. Without raw mode, detecting any input requires the user "send" the input by pressing Enter. Perhaps this is why Nodemon's manual reload also requires Enter at the end (rs<Enter>).

When also tackling https://github.com/esbuild-kit/tsx/issues/163, seems like listening to stdin at all (process.stdin.on()) could block or interfere with the child process correctly receiving stdin. And there's no way to passively listen to the stdin (even with a sibling process).

This may explain why Node.js hasn't implemented a manual way to reload watch (https://github.com/nodejs/node/issues/50212). Perhaps it's also worth considering to remove the manual reload feature or watch feature completely as Node.js already has it and it's not really related to TypeScript.
Any help & input would be appreciated!

I found another workaround to disable restart-on-enter, just by pressing Ctrl + d, which will close the stdin.
It's an alternative to @lorefnon solution

It's way too easy to accidentally reload dev servers right now.

Hi, is there any update on this?
@privatenumber