feat: qna recognizer

Description
qna & custom recognizer

[x] New recognizer drop down : Default recognizer , Regex recognizer, Custom recognizer
[x] QnA in all up view (basic) : support editing in manaco-editor, list view and syntax diagnostic
[x] Refactor publisher and support QnA build
[x] start bot with publish page
[x] ux for form editor
[x] Legacy bot migration to new recognizer hierarchy（Need to discuss, It's expensive to migration）
[x] Refactor lu & qna publish logic
[x] QnA in all up view (advanced) : advanced editing in list view
[x] Popup window for publishing
[x] Custom recognizer : trigger wizard for OnIntent and OnQnaMatch
[x] New trigger wizard : OnQnAMatch
[x] New trigger wizard : OnChooseIntent
[x] New trigger wizard : OnIntent(AdaptiveCard)
[x] Validation check and warning for recognizer switching

Task Item
https://github.com/microsoft/BotFramework-Composer/issues/2394
#3463

Screenshots

issues may need to fix:
Legacy bot migration

legacy bot should be open and matched into luis+qna (if there is no .qna or .lu file exists)

OnQnAMatch trigger and Inline-QnA editing:

resizing the inline editor (need bigger editor for editing)
may add default action for OnQnAMatch trigger

Drop down list switching

Switch from regex into luis+qna, regex intent should be convert into luis hoisting
Switch from luis+qna to regex, if onQnAMatch trigger exist, it will pop up warning

Need more discussion for customized recognizer/trigger wizard & value recognizer

more comments from today's discussion:

no mater what recognizer type is defined , trigger wizard drop down list should be consist (eg. OnQnAMatch will be showed)
switching from default to regex need to pop up warning if OnQnAMatch or OnChooseIntent exist
add OnQnAMatch will pop up warning as well if it is regex recognizer
IntentRecognized trigger only hook with intent name if it is custom recognizer. No inline hook up for OnIntent and OnQnAMatch trigger either from trigger wizard or property view.

Attached the figma design https://www.figma.com/file/LlTlh5vXwq91zjGnFtrUUR6l/Composer-master-design-spec-%2F-UI-library?node-id=2392%3A20262

[Design Spec] https://microsoft.sharepoint.com/:w:/t/ConversationalAI785/EWSmZ6UhsMlKnpbc1lKhhbEB0GZdoLCAtMf8rlHdHDZHvg?e=AXzdQq

close in favor of  https://github.com/microsoft/BotFramework-Composer/pull/3704


Split into multiple backends and add support for hid/libinput recording parsing

This is a bit messy and there's more future cleanup possible but meanwhile this is it:

add a Backend trait that handles the actual parsing and reading of data
move the hidraw bits into its own backend
add backends for libinput recordings and hid recorder recordings
move the cprintln bits into functions on the Outfile so the backends don't need to care about individual line formatting

The latter is a bit unrelated but copy/pasting the same printf statements was getting annoying.
The goal eventually is to make the Outfile functions color-support-aware so we can fix #39

I'm going to merge this because it works even though it's not yet as pretty as it can be. In particular, it'd be nice to have the markers only in non-colour output and rely on the color output only otherwise but that requires a bit more rework (and probably ditching owo_colors). Anyway, it does the job for now.


Events you've attended shouldn't disappear after ending

Subject: Events you've attended shouldn't disappear after ending
Description:
Attend an event that ended. I wanted to add some people I met in the event as friends, who would have been very easy to find on the event attendee list.
Results:
The event disappeared after its end time along with all the information. I think that having an archive of events (especially those you attended) would be useful, both for connecting with people you met, and for organizers to re-use text from past event descriptions.
Backend version: develop-2fe0b565
Frontend version: develop-2fe0b565
User Agent: Mozilla/5.0 (Linux; Android 11; SM-G981U1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Mobile Safari/537.36
Page: https://app.couchers.org/community/16/new-york-city-area
User: natalia (198)

I think this is due to how the backend determines what event to return at the moment (and not returning the event at all if trying to get it directly?), so will need to change that to implement this.
Individual event page should work just like now once that's done. As for showing archived events... that might need some UX input.


Make sure changes to DeploymentConfig and BuildConfig are not trigger…

…ing constant rolling updates to KAfka Connect S2I deployment
Type of change

Bugfix
Enhancement / new feature
Refactoring

Description
After #346 we are not patching the resources anymore when updating them. That seems to be wrong - at least for the BuildConfig and DeploymentConfig resources used by Kafka Connect S2I deployment. Since we always overwrite the complete object, we delete the changes which were done by the S2I system. As a result, the Kafka Connect S2I deployment is constantly updating in a loop - CC updates it to wrong state, OpenShift fixes that back to normal etc.
This PR includes a hack which will block this by reusing some values from the current state. However, this seems more like hack to get 0.3.0 out. The proper solutions should be probably in properly patching the objects in the Model.

TODO: Code works but tests need to be fixed.

The proper solutions should be probably in properly patching the objects in the Model.

Looking at the KafkaConnectS2IAssemblyOperator and thinking this through... The AbstractResourceOperator.reconcile() makes an implicit assumption that the desired state does not depend on the current state. This is indeed the case for most of the other resources, where the desired state depends only on the Cluster CM.
It seems that for both the BuildConfig and DeploymentConfig (and also the StatefulSets with storage, per #372), this isn't in factthe case. Maybe for these resources we should use a different operation than reconcile(), which passes the cluster CM instead of a desired resource directly. That would allow patchInternal() to construct whatever model was necessary using both the current state and the cluster CM. This is the same as what you're suggesting, but the point is that the building of the model would happen in the resource operator, rather than the assembly operator.
It's annoying that I didn't realise this before.

@tombentley Well ... the cases are slightly different ... here we really need back the patch* methods. Also in this case we know fairly well what to keep, so the fixing in internalPatch is a bit cleaner (should be less exposed to changes we will do later as it doesn't rely on any indexes in lists etc.).
But yes, basically they need a bit more sophisticated version of the reconcile method.


:bug: error prepaid gas on chapter 6 near101 - add --gas command

Add --gas command inside the CLI commande example

for more context why this is very important to merge in:
please merge this is, it's been open for over a month!
https://github.com/NEAR-Edu/near.academy/issues/11


Update docfx.json

Docs Build status updates of commit f074fbb:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 218: [Error] Invalid syntax in W:\vqxl-s\docset\docfx.json. Please validate your syntax with a JSON validator like http://jsonlint.com/ and update the JSON file in the repo with correct syntax.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 16ba202:
:clock10: Full build: the average full build time is 15 min(s) 56 sec(s), this is based on the last 1 build(s) for this repository.
:warning: This is a FULL build due to a configuration change (usually in .openpublishing.publish.config.json and/or docfx.json). It is strongly suggested to merge this configuration change after the business hours, as it could impact the overall build performance of other PRs on the 'master' branch. For more detailed info, please click here.

Docs Build status updates of commit 16ba202:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Hello @Banani-Rath Thank you for your contributions to make the PowerShell documentation.
Would you be able to describe the rationale behind the PR and resolve conflicts? We would like to proceed with PR peer review. Thanks.

stale PR. Changes were implemented through another one.


Improve the third party packages management for xSDK policies M12 and M16

Improve the third party package management inside Ginkgo.
This PR is required to comply with xSDK policies M12 and M16.
M12. If a package imports software that is externally developed and maintained,
then it must allow installing, building, and linking against an outside copy of that
software. Acceptable ways to accomplish this include (1) forsaking the internal
copied version and using an externally provided implementation or (2) changing
the file names and namespaces of all global symbols to allow the internal copy
and the external copy to coexist in the same downstream libraries and programs.

M16. The package must support production-quality installation compatible with
the xSDK install tool and xSDK metapackage.

After this MR, these policies should be satisfied for everything except the git-cmake-format tool, which is required for developer usage only. It should be acceptable to not provide a development ready version through Spack.
This is satisfied thanks to using the cmake find_library function before trying to add our own subdirectory version of the packages. This allows specifying which package to use thanks to the standard -DCMAKE_PREFIX_PATH option if the package is not installed globally, or by using the relevant package finder options, or by using the CMake package registry.
For the CudaArchitectureSelector tool, it is tentatively included before adding the relevant subdirectory. That means changing the CMAKE_MODULE_PATH allows finding it.
To also ensure that there are no weird interaction problems with other important packages such as googletest, gflags or rapidjson, the packages are linked against through the use of external targets instead of using the add_subdirectory command.
Changes summary

Add a new section to the README describing how third party packages are used in Ginkgo
Add a new third party package model with the following priorities:

Try to locate the package through find_package
If the package is not found or the user requests it, use our version of the package
This relies on the new helper macros ginkgo_add_subdirectory and ginkgo_find_package

Instead of including the packages in our project through add_subdirectory,
prefere using targets. A macro ginkgo_add_external_target was created for
this purpose.
Ensure the CMake version requirements is 3.9 for the better FindGTest
Always use modern CMake by declaring targets, either IMPORTED or INTERFACE
Replace the Benchmark setup of RapidJSON to use a target instead of header paths
Move the package helper files to the cmake/ subdirectory to better represent its new
central functionalities

Things to discuss
Edit this if you find another point.
There are a couple of important points I would like everyone to give a thought of:

Is this the correct model?
What should be the defaults, using the external package or using the internal package?
Is it worth it to allow in subdirectory mode linking as SHARED library? All subdirectory libraries seem   to prefer STATIC by default so kept this model.
Is it necessary to restrict the external packages we search for through versions? The ginkgo_find_package should support all standard find_package options including specific versions.
Is there a simple way to deal with git-cmake-format?

Requirements

[x] Merge #214
[x] Merge #216
[x] Merge #217
[x] Rebase, check new changes and retest this MR

This MR is on top of #217. To get a clean view of the changes, look at the latest commit only.
TODO

[x] Make -DCMAKE_BUILD_TYPE=Debug mode work.

This PR can now be reviewed.

Moreover, our third party packages are not that heavy, so if we are downloading them anyway at a certain commit, it should be okay to use the internal ones by default.
With the current setup, they are downloaded only if they are not found in the user's system/installed pacakages.

@ginkgo-project/developers what do you think we should use as default mode:

using external/user provided packages if they exist (current)
using internal packages

I vote for 2, as it will always work. With option 1, there might be some issues with the versions of the packages that may require a more experienced user to be resolved correctly.

Is this the correct model?

I can't tell if it complies with M16 (since I have no idea what their tools are), but we should satisfy M12 (through the use of targets, we don't have a problem with coexisting external / internal packages, correct?), so I would say yes.

What should be the defaults, using the external package or using the internal package?

I agree with @gflegar and @pratikvn, using internal packages as default should be less error prone because we know for a fact that it works. If the user wants to use external packages, he should explicitly state it, so any problems (e.g. no backwards compatibility in newer versions) might be found faster because it deviates from the default case.

Is it worth it to allow in subdirectory mode linking as SHARED library? All subdirectory libraries seem   to prefer STATIC by default so kept this model.

This only affects us when using internal packages, correct? In that case, it should not matter at all, and it should be perfectly fine using STATIC linking.

Is it necessary to restrict the external packages we search for through versions? The ginkgo_find_package should support all standard find_package options including specific versions.

We might need to search for for a specific version, so we don't use an external one which is very old (and lacks features we need). If they don't support versioning, I think it is even more important to use internal packages as default, because it is by far less error prone in that case.

Is there a simple way to deal with git-cmake-format?

No idea, sorry.

Thanks for your feedback. I made the internal packages as default ones and added the option for overriding this.
For the package versions, I should be able to limit the version to only one higher or equal to our internal packages, but I will be doing this as part of the release process rather than this MR (all packages need to be updated).


provisioining - volumes mount

/var/lib/volumes is now mounted to root 8GB disc, it should be mouted to tmp EBS.

fixnuto zvetsenim root volume https://github.com/keboola/syrup-router/commit/fa17736d8e306032a4dbbc902b740d2c19ce25fa
Zatim neni v produkci, mergne se s upravama pro multi-region.


Resource builder for gcloud deployment-manager.

:+1:

:+1:

The last error is too-many-lines but I am unable to turn it off.  This is required to be on the first line of the file.  I attmepted this but it will not execute if that's the case.


FIrebase not working at all

We have created signup and login components, but we're still unable to link it to firebase because of api issues.

Still WIP but its atleast working some what now


Discv5 Open Questions

Hi everyone,
I thought I'd compile this issue with a couple of notes regarding discv5. Inputs for these consist of research I've done into discv5 and other discovery protocols, and the discussion I had with @fjl about two weeks ago. The goal here is to kick off a discussion around discv5, and make a decision around its adoption.
Implementation Notes
discv5 uses a different transport mechanism and DHT than libp2p. As such, it cannot easily be assembled from libp2p components. That said, discv5 is an upgrade over discv4, which already sports a number of existing implementations.
Questions: How hard is it to interoperate between peers discovered via discv5 and peers communicating via libp2p? It looks possible to wrap ENRs with the appropriate multiaddr metadata for use within the libp2p peer book.
Topic Subsets
discv5 was invented in order to add support for the advertisement of topic subsets. This works well for ETH2, as we'll likely want to advertise topics for the following things:

Chain ID
Node type (i.e., light/full node)

Note that discv5 is a poor choice for ephemeral topics (such as shard information) because topic advertisements are long-lived.
Questions: Are there any other long-lived topic types that we will need?
Transport Mechanism
The discv5 transport mechanism consists of RLP-encoded UDP packets (see the wire protocol for the full spec). Obviously, this is different from the SSZ encodings we've been using elsewhere.
Questions: Is the encoding/transport mechanism something that we will want to change for the sake of consistency?
Encryption
discv5 generates an ephemeral key during the handshake phase of the protocol. This same key could be used to encrypt traffic between ETH2.0 nodes elsewhere in the network stack.
Question: What is the relative priority of encrypting network traffic at this time? IMO, we should punt on this until later. If it's high enough to warrant inclusion in Phase 0, are there any objections to using the ephemeral key to encrypt non-discv5 network traffic?

As I understand there has been a lot of recent progress on discv5. @mslipper have you been able to answer all your questions?

link https://github.com/ethereum/devp2p/issues/107

This can be closed.


fixed bug with initialization of queueconfig

QueueConfigs would only ever initialize to the default settings, and would not pick up their respective values from YAML.

@tomwilkie

Whoops!  LGTM, wonder if we should update some of the QueueManagerTests to use Storage instead, as that would have caught this?

Should I do that as part of this PR, or is this fine as-is?

If you have time to update some of the tests, that would be great.  If you don't, let me know and I'll do it in a separate PR.

Looks like I'm not going to have time anytime soon to go after this; sorry. Can we still merge in this change?


Fix check for agressive connectionlimit

In https://github.com/dotnet/runtime/issues/22366 we found that if
HttpClient is using the curl handler it will lead to TCP connections
bleeding. Our DefaultConnectionLimit is very restrictive if this is
true. Our check however is too lenient and will default to true always
on .NET core since netcoreapp still ships with CurlHandler as recent as
3.1.x

I've added a commit of a slightly updated implementation based on PR comment

1 failing test

CSV should be fixed with #4666

Flipping the check was a good call, thanks @russcam 👍

Opened #4669 as manual backport to 6.x


Remove wl_shm_format

The use of this enum was replaced with a uint32_t upstream for 0.13.0

Good catch, interesting that this still compiles.


NFC tags don't open in duckduckgo

1. What I do:
Scan an NFC tag that holds web url
2. What happens:
Google Chrome opens the url
3. What should happen:
Duckduckgo opens the url
After some investigation it seems that duckduckgo is missing the intent-filter.
a quick search for 'nfc' in the google chrome app manifest reveals two entries.
I don't know if nfc permissions are needed to.

https://chromium.googlesource.com/chromium/src/+/b71e98cdf14f18cb967a73857826f6e8c568cea0/chrome/android/java/AndroidManifest.xml#245

Hi @cmonfortep, can I work on this?

@ashwinpilgaonkar sure!

Hi @cmonfortep,
Since I dont have any physical NFC tags to test out my changes with, I'm trying to emulate it using another test application that I'm building.
I just have one question - when the NFC tag is detected, does it broadcast an intent in a similar manner as the code snippet given below?
                Intent intent = new Intent("android.nfc.action.NDEF_DISCOVERED");
                intent.setType("text/plain");
                intent.putExtra(NfcAdapter.EXTRA_NDEF_MESSAGES, "Test text");
                sendBroadcast(intent);

According to the docs, yes, it does -> https://developer.android.com/guide/topics/connectivity/nfc/nfc#filter-intents
There's more information about the nfc tags also there https://developer.android.com/guide/topics/connectivity/nfc/nfc#dispatching

According to the docs, yes, it does -> https://developer.android.com/guide/topics/connectivity/nfc/nfc#filter-intents
There's more information about the nfc tags also there https://developer.android.com/guide/topics/connectivity/nfc/nfc#dispatching

Yes, I had gone through these docs earlier but could only find info pertaining to filtering an NFC intent. Whereas, I was more interested in finding out how to mock a physical NFC tag.
Anyway, I've made a PR with the changes, which I was able to test successfully using the following code snippet -
                Intent intent = new Intent();
                intent.setAction("android.nfc.action.NDEF_DISCOVERED");
                intent.setData(Uri.parse("https://www.example.com"));
                startActivity(intent);

IMO it should work the same way with a physical NFC tag as well. Perhaps if someone else has access to one, they can help us out by testing it.

Thanks, I will review the PR this week and will do the testing part too.

PR has been merged and this feature will be available in our next release.
Shout out to @ashwinpilgaonkar @JeffAment and @andreaskern!


Commit works smooth even if there are errors in issues.md

I'm trying to integrate LAMS with Looker using Gitlab. Created 'Gitlab-ci.yml' file and pipeline is running. Can see 'issues.md' file in pipeline job artifacts.
My concern is even if I have errors in my issues.md file, 'commit changes' from Looker works smooth. Shouldn't the commit fail since there are errors in issues.md file?
Objective : Developer shouldn't be able to commit their changes if there are errors in issues.md file. (Issues.md file is available in job artifacts)

Hi @shreyabnsl09
It depends on which version of LAMS you are using, and how you have configured your CI process.
Note that between v1 and v2, the default output mode of LAMS changed, from the issues.md file to stdout/command-line output. However, the deployment example for Gitlab CI is still for v1, as I don't use Gitlab and depend on the community to help maintain that deployment example (see https://github.com/looker-open-source/look-at-me-sideways/issues/91 )
Can you confirm what version of LAMS you are running and what your CI configuration looks like?

@fabio-looker Thanks for your response.
This is my gitlab-ci.yml file. I am using docker image from docker hub.

@PieterjanCriel
Any suggestions on this?

@fabio-looker Any suggestions on this?
I tried with LAMS V2 as well. Still experiencing the same behavior.

From the contributed example, it's not clear to me whether its intended effect is to prevent some action entirely, or to merely provide the findings in an artifacts for a reviewer's use. Other than that possibly incorrect observation, I really don't know how Gitlab CI expects things to be configured.
Also, if the linter is running in CI (which is a separate machine from the developer), that kind of implies the code has already been committed. You could prevent the code from being merged, but it's too late to prevent it from being committed. For that, you would probably need something like https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks , however that is for situations where developers are writing the LookML on their own computers and willing to setup a dev environment with Node.js and the linter

Closing as duplicate of #91


improve GET /system API performance with many integrations

Is your feature request related to a specific problem?
@Roger-Ethyca has noticed that the "view systems" admin UI tab is slower to load as he adds more integrations to his local fides instance.
Following up on this observation, i noticed that the response time for theGET /system endpoint seems to increase linearly with the # of integrations configured on the server, with ~500ms of response time added per configured integration (i tested up to 8 integrations): https://docs.google.com/spreadsheets/d/1mDo7XDRmB4xUYWZXAaeWeLU0oEjeFHJIcg6ou_NfSm4/edit#gid=0. this isn't really a sustainable trend - it's not inconceivable that a fides user would have ~100 integrations configured on their server!
I'm pretty sure that our lazy loading of the connection_config relationship on a System is effectively causing an n+1 query problem when it's applied to the GET /system endpoint that lists all System records, since the connection_config population requires an additional query for each System.
Describe the solution you'd like
I don't think we need the connection_configs relationship/object field populated on the GET /system endpoint response at all, since we're just trying to get the basic system records for all systems - so the simplest approach would probably be just to ensure the response schema for that endpoint doesn't include the connection_config field.
I quickly POC'd locally this quick and dirty fix by swapping out the endpoint's response_model reference to fides.api.schemas.system.SystemResponse with fides.api.schemas.system.System (which does not have the connection_configs field defined) and it reduced the 8-integration response time from ~4s to ~200ms so it seems effective!
Describe alternatives you've considered, if any
Slightly more complex solutions that i can think of, but i'm not sure are worth the added complexity:

provide a query param/option for returning the embedded connection_config relationships on the response records of this endpoint
improving the connection_config SQLAlchemy relationship so that it generates a more performant query pattern

Additional context
See slack thread for some more context!

@adamsachs Can you investigate if there might be anything similar happening related to the number of datasets? I just filed this earlier because I noticed the /filter/dataset call taking a very long time when there are a lot of datasets. It might be separate, but thought it seemed similar enough to warrant a quick look.

@adamsachs Can you investigate if there might be anything similar happening related to the number of datasets? I just filed this earlier because I noticed the /filter/dataset call taking a very long time when there are a lot of datasets. It might be separate, but thought it seemed similar enough to warrant a quick look.

@mfbrown thanks for calling that out! happy to investigate, but i've got a couple of other things at the top of my queue so it may take a bit till i get to this investigation, so if anyone else is free and willing, please take on that investigation 👍

@adamsachs The integrations tab in the system portal is currently using the connection_configs relationship so the single, get by id, response will still need a model that includes it.

@TheAndrewJackson - for sure, good call out. i'm not proposing we remove that model, just that we specifically update the endpoint that lists all systems to use a model without that property/relationship, since i don't think it should be needed on that endpoint!

moving to done (this is soooooo much better)

nice, glad to hear it @Roger-Ethyca! thank you for reporting this one early on, getting an early lead on this was so helpful 👍


Remove Hack (Performance Issue)

Hi Peter,
Please find this pull request that remove the hack you made for angular support.
For me, the hack in not usefull anymore and the timeout brings performance issue with android old devices (when you are typing very fast).
I have seen your Pro plugin initiative, which is a great idea and for sure I will subscribe, but if you can publish this last fix because it is pretty urgent for me and it will take me some time to migrate to proplugins.
Thanks a lot,
Nicolas

Hey @nickykln , this has been changed from quite some time in the ProPlugins version 😉 Thanks for your contribution and the new version has been pushed to npm.


Save result locally

The predict function call returns the resulting images as URL, and if I want to store them locally, I still have to fetch that. But a simple
urllib.request.urlretrieve(output[0], filename)

will fail with 403 because of lack of authentication; I have to include the authentication header in that request.
It would be convenient if the replicate library would assist with that, so that the user does not have to know how to include the token in the request.

Just in case anyone hits the same issue: This is the code I’m using now:
opener = urllib.request.build_opener()
opener.addheaders = [('Authentication', 'Token ' + os.environ.get("REPLICATE_API_TOKEN"))]
urllib.request.install_opener(opener)
urllib.request.urlretrieve(output[0], filename)

Thank you!

This is now fixed by having a short-lived hard-to-guess URL.


Android Bundle and APK crash in some devices

Description
Hi guys! first of all thanks for this amazing library! We really appreciate your work!
We encounter a strange error in some Android devices and ONLY in app downloaded from Play Store (for now it appears only on arm64, but we are investigating it). It works as excepcted if I run in Debug on a real device and also if I create an apk in release and install it on a real device.
The error generate an exception which lead to a crash as soon as I load the interface which use react-native-skia.
For what we can see the error is that:
dlopen failed: cannot locate symbol “__emutls_get_address” lib/arm64-v8a/libreactskia.so
We are using the following packages versions:
"react": "17.0.1"
"react-native": "0.66.2"
"@shopify/react-native-skia": "0.1.156"
Other info:
ndkVersion = "20.1.5948944"
enableHermes = true
Has anyone ever had this problem?
Version
0.1.156
Steps to reproduce
We are not yet sure about steps to reproduce this issue cause the problem appear only when downloaded from Play Store.
Snack, code example, screenshot, or link to a repository
This is a sample of the code

import React, {useState, useEffect, useRef, useImperativeHandle} from 'react';
import {View} from 'react-native';
import {Skia, Circle, Path, Canvas, useTouchHandler, useValue} from '@shopify/react-native-skia';

const SkiaExample = React.forwardRef((props, ref) => {
  const pathEmpty = Skia.Path.Make();

  return (
    <View
      style={{flex: 1}}>
      <Canvas style={{flex: 1}} onTouch={touchHandler}>
        {pathEmpty !== undefined && (
          <Path
            path={pathEmpty}
            color={minimumTrackColor}
            antiAlias={false}
            style="stroke"
            strokeWidth={strokeWidth}
            strokeCap="round"
          />
        )}
      </Canvas>
    </View>
  );
});

Hi, @LSLeaff - could it be related to this issue? https://github.com/android/ndk/issues/1639

Closing due to inactivity

Hi @quicksilverr, the problem has been solved by upgrading to the last version of React Native but I'm not 100% sure cause another developer does it. By the way, after that, the crash disappears.


Deploy staging version of the solver-service

@tmcgilchrist what's the next step for getting this deployed?
I suggest:

Merge this PR, allowing the new version to build.
Configure the solver on arm64-jade-1 to use the production pool rather than the staging one.
Run the new service alongside the old one (on jade-2) for a bit. If the new one crashes, the old solver will take over. If the new version produces wrong results, stop it and let the old one handle all requests.
Assuming it works, merge https://github.com/ocurrent/solver-service/pull/71 and shut down the old solver.

The /etc/systemd/system/solver-worker.service  file I'm using with it is:
[Unit]
Description=Solver Worker
After=network.target

[Service]
ExecStart=/usr/local/bin/solver-service run-cluster -c /etc/ocluster/solver.cap --name='arm64-jade-1.equinix.ci.dev' --cache-dir=/var/cache/solver --capacity=8 --internal-workers=4 --verbosity=info
Restart=always

[Install]
WantedBy=multi-user.target

Note that the old service accidentally cloned Git repositories to the root. You can delete /github_com after switching to the new service.

@mtelvers sounds good! I've updated the deployer and installed the binary that it produced on arm64-jade-1.


How to access iterator in range

I have a data structure like this:
{
someNumber: 5,
someStuff:[ ... ... ]
}

I can create a row of items conditionally based on the value of someNumber by repeating the below snippet 5x (and manually setting i from 1 to 5)
     {{ if someNumber >= i }}
           true
     {{ else }}
           false
      {{ /if }}

Ideally I would like to use range for simplicity. Something like:
{{ range start=1 end=5 }}
     {{ if someNumber >= [iterator] }}
           true
     {{ else }}
           false
      {{ /if }}
{{ /range }}

I can't find the in loop variable to expose the iterator/index of the current iteration. I have tried #index and #data but both resolve as null/undefined in the loop. I also noticed that someNumber is less than 0 when using the construct.
Can you point me at some documentation that explains how to do this (jsviews.com isn't quite clear nor does it explain validating in loop), or offer some advice.
Thanks.

You can access the iterator from within nested blocks using #getIndex(). See also http://jsviews.com/#views@itemview (and the rest of that documentation topic).
In the next update you will be able to do
{{for someStuff start=1 end=5}}
   true
{{/for}}

but it looks as if you need something like:
{{for someStuff}}
  {{if #getIndex() < 6}}
    true
  {else}}
    false
  {{/if}}
{{/for}}

Thanks, Boris. Below works for me to get the iterator in the range/for loop
{{range start=1 end=5}}
  {{if #getIndex() < 4 }}
    true
  {{/if}}
{{/range}}

but what I wanted was to be able to validate the iterator against someNumber. In this loop my data value someNumber equates to null, or is inaccessible.
Ideally I was hoping to achieve something like:
for (i = 1; i < 6; i++) {
  if(someNumber > i){
     //true
  }
}

Not sure why you put ~Average - (with a ~). Is it in the data or is it a helper? You don't show your  data or JSON so I have no idea where Average is defined. I suppose it is higher up in the data object graph, in which case you need to read this:  Accessing parent data


Update MendixSSO

Updated MendixSSO example with new MxId3 endpoint.

Needs internal review first.

@Luyao-Zhang-1 Can be merged.


require('sass.js') Thrown: 6439624

sass.js npm package throws error on require.
How to reproduce:
$ node -v
v8.12.0
$ npm i sass.js
+<EMAIL_ADDRESS>added 1 package from 3 contributors and audited 1 package in 1.089s
found 0 vulnerabilities
$ node
> try { require('sass.js') } catch (err) { console.log('sass.js: ' + err);}
sass.js: 6439624

Expected:
Not to throw exception

I don't quite understand what's going on in the REPL. Things work fine when executed from file:
➜  echo "require('sass.js'); console.log('hello');" > index.js && node index.js
hello

I'm a bit lost why in the REPL the error 6439624 (type Number) is being thrown. The only reference google yields is this comment - so I suspect that somehow crypto isn't available in a way emscripten expects.
Since you're bringing the REPL into the mix… any idea what might be going wrong here?


Meltano CLI should load the Meltano project preemptively

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/384
Originally created by @mbergeron on 2019-02-13 21:11:42

Meltano CLI is currently loading the Meltano project in the commands that needs it, but in reality, we need to preemptively load it so the .env is loaded before the CLI commands are parsed (some commands use environment variables as default)
/cc @jschatz1

View 2 previous comments from the original issue on GitLab


Performance issue: Imported SQL Stored procedure parameters of type CHAR(x) translate into 8000 characters at run-time

If a SQL Stored procedure is added into the EDMX model (aka Function import) and it contains one or more parameters of CHAR type, the EDMX model will not record any parameter size info.
This causes EF6 to generate 8000-character space padded parameters at run-time ignoring the actual CHAR size. For instance, a CHAR(3) value of 'ABC' will be sent to SQL server as a string starting with ABC right-padded with 7997 spaces. This has negative impact on performance due to the increased query size and network traffic. Multiple CHAR parameters in an SP worsen the impact.
Steps to reproduce
Create a stored procedure similar to below:
CREATE PROCEDURE TestSP(@Param1 CHAR(3))
AS SELECT @Param1

Add this stored procedure to your EDMX model.
Confirm no size attribute is recorded for parameter Param1:

<Function Name="TestSP" Aggregate="false" BuiltIn="false" NiladicFunction="false" IsComposable="false" ParameterTypeSemantics="AllowImplicitConversion" Schema="dbo">
          <Parameter Name="Param1" Type="char" Mode="In" />
</Function>

Generate corresponding C# code
Create a test application to call generated SP code.
Run the test application and monitor the SP call using SQL Profiler.
Notice the 8000-character string representing Param1 (instead of 3 characters expected by the SP).

Suggested resolution
Capture and store the MaxLength attribute (faucet) as part of the model for corresponding CHAR parameters. For instance, adding the MaxLength attribute to the model by hand resolves the issue:
<Parameter Name="Param1" Type="char" Mode="In" MaxLength="3"  />
Further technical details
EF version: 6.2.0
Database Provider: EntityFramework.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2017 15.9.6

EF Team Triage: This issue is not something that our team is planning to address in the EF6.x code base.  This does not mean that we would not consider a community contribution to address this issue.
Moving forwards, our team will be fixing bugs, implementing small improvements, and accepting community contributions to the EF6.x code base. Larger feature work and innovation will happen in the EF Core code base (https://github.com/aspnet/EntityFramework).
Closing an issue in the EF6.x project does not exclude us addressing it in EF Core. In fact, a number of popular feature requests for EF have already been implemented in EF Core (alternate keys, batching in SaveChanges, etc.).
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


IconStyle hotspot

Hi and thank you so much for the great library!  I've been using it quite a bit, but found that I needed support for the hotSpot element that can be present on the IconStyle tag.  I have a this working on a private fork and would like to contribute upstream if you are interested.  My current implementation took the naive approach of making a tuple to represent the element and updating the necessary reader/writer logic:
#[derive(Clone, Debug, PartialEq)]
pub struct IconStyle {
    pub id: String,
    pub scale: f64,
    pub heading: f64,
    pub hot_spot: Option<(f64, f64, String, String)>,
    pub icon: Icon,
    pub color: String,
    pub color_mode: ColorMode,
}

While this does work, I suspect a better API would be to create the underlying structure and units enum for the kml:vec2Type.
<complexType name="vec2Type" abstract="false">
    <attribute name="x" type="double" default="1.0"/>
    <attribute name="y" type="double" default="1.0"/>
    <attribute name="xunits" type="kml:unitsEnumType" use="optional"
      default="fraction"/>
    <attribute name="yunits" type="kml:unitsEnumType" use="optional"
      default="fraction"/>
  </complexType>

If you're interested I'd be glad to take this on myself.  Thanks!

Thanks for posting this! This definitely sounds interesting, so any contribution would be welcome.
I think you're probably right about creating a new struct for vec2Type so if you have the time that would be great as well

I have started an implementation here: rough draft.  I wanted to check with you before proceeding to docs and tests to see if I am following the right path?  I'm thinking you might prefer different naming or package layout conventions from what I've chosen.  Thanks again!

@ardouglas this looks great! Feel free to keep going and open a PR when you're ready

Closed by #13, thanks again @ardouglas !


Are 2-hop and 3-hop triple needed to be trained during KGE phrase?

@apoorvumang
hi, I have a question about the knowledge embedding training:
Are 2-hop and 3-hop triples needed to be trained during KGE phrase? That is triples in fbwq_full datasert likes (m.0rh6k location.location.people_born_here	m.02qd3hj) (3-hop triple) and (m.010bss7d film.genre	m.03k9fj) (2-hop triple) and (m.0gkt5x0	country	m.06qd3) (1-hop triple) are put together to get knowledge embedding by KGE?
Any reply would be appreciated.

I'm not sure I understand what you mean by 2/3 hop triples. location.location.people_born_here is a single relation in Freebase, not a 3-hop relation path. The reason it looks like 3 relations concatenated together is due to the schema used by freebase , but in reality it is a single relation.

@apoorvumang
Thanks for your reply.

location.location.people_born_here is a single relation in Freebase, not a 3-hop relation path
So how do you define a 3-hop relation in fbwq_full dataset? And did you regard  (m.0rh6k location.location.people_born_here m.02qd3hj)  as training data during KGE training?

Furthermore,  as the published MetaQA dataset shows that there are 1-hop, 2-hop, 3-hop train dataset, dev dataset and test dataset respectively. Did you gather all training data to train one model and test the performance by the one model for these three hops test questions separately?

So how do you define a 3-hop relation in fbwq_full dataset?

We don't define relations to be 1,2 or 3-hop, we define questions as 1,2, or 3-hops, depending on how many hops of reasoning are required to answer them. Relations are considered atomic.

And did you regard (m.0rh6k location.location.people_born_here m.02qd3hj) as training data during KGE training?

Not sure about this particular triple, but yes similar looking relations would have been used in KGE training
For MetaQA, we trained KG embeddings once. Then for each QA dataset (1,2 and 3-hop) we train and evaluate the QA model separately

For MetaQA, we trained KG embeddings once. Then for each QA dataset (1,2 and 3-hop) we train and evaluate the QA model separately

So in EmbedKGQA stage, you have three trained models?

Yes 3 different models for MetaQA

Thanks very much for your reply and patience!!


Final version

:tada: This PR is included in version 1.2.0-hotfix-fix-final-version.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


message_actions_popover: Hide extra separator in spectator view.

In the spectator view, we are only left with the last few options belonging to the same group, and the separator is not needed.

Screenshots and screen captures:

Before
After

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Looks great, merged, thanks @sayamsamal!


Adding cryptoplus.be into blacklist

See link, https://urlscan.io/result/3c86facf-d9ee-4293-b7ab-150b31015e71#summary.

address: 0x8D551F2a2d0908854e0E030564261c9Ff2E8dd56


Trouble sending back PDF data

I have an endpoint that creates a PDF based on data I send it. I'm trying to use mox to:

return whatever the endpoint returns if the call returns a non-500 response, and
return a static PDF file on my file system instead if the call returns 500.

However, I've only managed to do one or the other. I managed to get the static PDF going back (although I had to use express middleware to do it). However, once I've made the mutate call, the request call has already incorrectly parsed my PDF as a UTF-8 string, and so if I try to pass it through on a success it comes back corrupted. Any ideas, or possibility binary data could become better supported?
Thanks!

@awesomeunleashed Thanks for opening an issue. Mox is currently going to have trouble parsing content-types that are not text/plain or application/json. Better support for arbitrary content-types is something I'd like to add in the near future.


Show builds rate limit message correctly

Currently it always shows: You have been creating deployments at a very fast pace.. An user may not be able to solve the issue on their own in case it's a builds rate limit.

Codecov Report

Merging #1866 into canary will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           canary   #1866      +/-   ##
=========================================
- Coverage    6.35%   6.31%   -0.05%
=========================================
  Files          93      93
  Lines        4057    4069      +12
=========================================
- Hits          258     257       -1
- Misses       3799    3812      +13

Impacted Files
Coverage Δ

src/util/index.js
0% <0%> (ø)
:arrow_up:

src/util/get-project-name.js
90.9% <0%> (-9.1%)
:arrow_down:

src/util/get-files.js
91.53% <0%> (-5.37%)
:arrow_down:

src/util/read-metadata.js
100% <0%> (ø)
:arrow_up:

src/util/hash.js
100% <0%> (ø)
:arrow_up:

src/util/error.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baadff1...9947b97. Read the comment docs.

Merging #1866 into canary will decrease coverage by 0.04%.

Can we bring it up again?

Well not easily because it seems to me that the test coverage of this file is 0


InfluxDB-Client-for-Arduino doesn't work on wired Ethernet.

Proposal:
InfluxDB-Client-for-Arduino works well on Wifi. but it didn't work on wired Ethernet.
Current behavior:
I tried to connect InfluxDb on wired Ethernet, but failed. Ethernet chip is W5500.
Desired behavior:
I want to connect InfluxDb on wired Ethernet.
Alternatives considered:
but, I'm not good enough to do it.
Use case:
Wired Ethernet is more reliable.

@ykpark1126, thanks for trying this client. Only connection over internal WiFi is supported now. Please follow issue #127 about Ethernet support.

HI @vlastahajek, I'm sorry to revive this old issue, but I feel my question relates a bit to your answer. What does internal Wifi mean, can you please elaborate here? If I have an InfluxDB on a remote server on Azure/AWS, will my board connect successfully? I assume I cannot, because internal means the InfluxDB has to be in the same network...?
Many thanks.

@nguyenlamlll, by internal WiFi I meant WiFi capability of ESP chip. Not an external peripheral


UI: Notify users when upgrades are available or restart is required

Description
This PR adds a feature in UI to notify admins when a new version of CloudStack is available
and users when a restart is required for networks or VPCs.
This PR also adds a small UI improvement in the UI to show which network/UI requires restart and filtering networks/VPCs which require restart.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
New release available for cloudstack

Restart required notification

Show in UI that a restart is required

Add filter on restart required

How Has This Been Tested?

Replaced notification with an alert component.

@vishesh92 I suppose this a screenshot for admin; a user I would prefer a single alert (too many makes the UI look poor). Click that could open a form with more details. Also, can we merge notification for both guest networks and VPCs? (for the end user these are just networks.
Alternatively; you can display as part of the dashboard (perhaps not top of the UI) - let's discuss. Let me try if the demo env can be used to test changes for further feedback.
@blueorangutan ui

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@rohityadavcloud I manually changed the value of restartrequired in database to true to test this. Version check should work with 4.19-SNAPSHOT.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7610 (QA-JID-121)

@vishesh92 can you please look into merge conflicts and outstanding comments? SHould this be considered for 4.19?

@vishesh92 Is this PR targeted for 4.19.1? If so, please rebase and update target branch.

@vishesh92 Please resolve the conflicts, & check/address the comments. Thanks.

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10590

@blueorangutan ui

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan ui

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7610 (QA-JID-417)

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan ui

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7610 (QA-JID-418)

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10605

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10609

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10622

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10629

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10682

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10824

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 10881

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10883

@blueorangutan package

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10903

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10909

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10922

@blueorangutan ui

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7610 (QA-JID-438)


[New Amplify Console UI] Missing branches and access for Team Members

Environment information
We are missing branches in the the new UI.
Also only the account admin can access the the console at the moment.
The other team member getting a loader...

Description
All Branches are there and team member should have access

Hey @biller-aivy, do you observe any notable errors in the browser debug console or the network tab ?

@biller-aivy can you also share your Amplify app id?

Such changes overnight should be illegal. Please give the possibility to rollback to the old UI. The new UI looks horrible, buggy and this is inadmissible for a team which run production apps.

Hey @biller-aivy, do you observe any notable errors in the browser debug console or the network tab ?

@biller-aivy can you also share your Amplify app id?

d2v6n1oht50tox
d33b18ppqinomp

all my apps are not working correct in the UI.
when I change the URL by myself, I can access the branches.

This is also missing when I create a new connection to a branch. We need this, because otherwise an old branch would be deploy also an old backend.

@biller-aivy to expedite the troubleshooting process we would like to jump on a call with you. Can you please share your email and availability privately via a DM on our community discord server? My username is Jay Raval.

I've run into a similar issue, especially when trying to pick a branch from the dropdown for custom domains. It only shows some of the branches, and there doesn't seem to be any pattern to which ones are visible. Even if the branch is already set up there is a chance that it will show an empty dropdown
Also, I didn't spot any errors in the console related to this.

@ChengS-U can you please send me your account ID on our community discord server? My username is swaminator

Closing the issue. Please feel free to open a new issue if you encounter problems


Dts bugfix #267

closes #267 #185

generate d.ts for x
add dts command before ./build
convert monad/Instance.js to class, fix this problem:

➜  rubico git:(dts-bugfix) ✗ nr dts

><EMAIL_ADDRESS>dts
> del *.d.ts _internal/*.d.ts x/*.d.ts && tsc

monad/Instance.js:7:1 - error TS9005: Declaration emit for this file requires using private name 'Instance'. An explicit type annotation may unblock declaration emit.

7 'use strict'
  ~~~~~~~~~~~~

Found 1 error in monad/Instance.js:7

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (ce3dbbd) 99.60% compared to head (870bf65) 99.60%.

:exclamation: Current head 870bf65 differs from pull request most recent head ab58518. Consider uploading reports for the commit ab58518 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%
==========================================
  Files         226      226
  Lines        3323     3315       -8
==========================================
- Hits         3310     3302       -8
  Misses         13       13

Impacted Files
Coverage Δ

monad/Instance.js
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@richytong please check monad/Instance.js - convert from function style class to es6 class is legal?

@kalagin yes that should be fine

I've refactored instance to use es6 class @kalagin. The changes are on master branch.

@richytong done

@kalagin the files should be fixed already, I should have included the ts files

ready to prod


Verify certificate fields during integration tests

@lookuptable: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auth-presubmit.sh
6301f5e2adf2aa6633414e12937b6ebd908b5335
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lookuptable: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auth-presubmit.sh
2f3cc0a770a4705ebd9be4f841d6bc6e4f98ae4b
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@lookuptable: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auth-presubmit.sh
2f3cc0a770a4705ebd9be4f841d6bc6e4f98ae4b
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lookuptable: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auth-presubmit.sh
c3ff620fbdc27bac9ad92dd9de5888484a9a1bf2
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lookuptable: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auth-presubmit.sh
1a6667314cf966b590be4e3eca6769b47a631aea
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Moved resnet_50 to networks.

Created stub files in old locations.
Updated Readme and Makefile with networks descs.
Added OpenVINO env checks.
Added NETWORK_NAME and implemented easier make run parameters.
Moved the network desc in caffe/README to networks/README
Signed-off-by: tomepetty<EMAIL_ADDRESS>

networks/README.md might need to be recommitted after the changes made from the ssd_mobilenet from pr #306

Resolved the Readme conflicts.


Reuse ParagraphBuilders in text_painter.dart

If we could do something like https://github.com/flutter/flutter/compare/master..dnfield:paragraph_builder_cache, we could save significant amounts of time when rendering multiple strings that are using common text styles, as is common in a ListView of ListTiles that each have a few pieces of text.
See some more context in https://github.com/flutter/flutter/issues/96235#issuecomment-1013542565
This will require some new features on the engine APIs, particularly something to make ParagraphBuilder.build reset the object to an initial state in the least expensive way possible. I've got a WIP patch for the engine and for SkParagraph that should make this possible.
In local testing on a low end Android device, this approach can take off several milliseconds of time on the initial build of a ListView that shows 7 ListTile's which each have three pieces of text to show using 3 different text styles.
@goderbauer @jason-simmons @rusino for input

https://skia-review.googlesource.com/c/skia/+/499236 makes this possible on the SkParagraph end

If we could do something like https://github.com/flutter/flutter/compare/master..dnfield:paragraph_builder_cache,

Easier to read diff of the changes required to flutter: https://github.com/dnfield/flutter/commit/08623768c37911cdda405646c22f0c3273d0e3f9

this approach can take off several milliseconds of time on the initial build of a ListView

Do you have some more precise numbers for this? Looks promising, though.

I took a couple traces last night and forgot to save them. I'll try to re-run them today

https://skia-review.googlesource.com/c/skia/+/499877 exposes CanvasKit bindings for web.

I'm having trouble consistently showing any improvement from this. I'm going to keep examining.

From new feature request triage: This should be re-evaluated after the migration to FFI.

FFI probably isn't helping enough to obsolete this. In experiments with Paint, using the FFI primitives is slower than shunting over typed data. In any case, we could still have some benefits here from avoiding the re-creation/copying of this data every time we paint/repaint text.

From new feature request scan: @dnfield Is this still worth investigating? If so, any thoughts on how it should be prioritized against adding a new lower-level text API?


Resource & Device notifications  on plgd Dashboard

Feature Request
What is the purpose of the feature?
Being notified about changes using toasts directly in the plgd Dashboard.
What specific challenge does this feature solve?
Easy to use.
What alternatives did I consider?
None

https://www.figma.com/proto/jEnR4aeRcEDtNriJo5y4y4/PLGD-Design?node-id=243%3A0&scaling=min-zoom


Include a Failed condition in Workloads

What type of PR is this?
/kind feature

What this PR does / why we need it:
Replaces workload finished reason with succeeded and failed reasons
Which issue(s) this PR fixes:

Fixes #1982
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Workload finished reason replaced with succeeded and failed reasons

/ok-to-test
/assign

You also need to adapt the MK tests, other than that LGTM. Thanks!

/lgtm
/approve


Favorite Repeat Bug

I have seen this happen in previous releases and it is still happening.
I have seen the tweets in the favorites tab being repeated... here is an example.
http://twitpic.com/1nh3cl

I am still getting this error. Here is an updated screenshot http://cl.ly/3k0C1R2A0v040f3r0l2U
I am using the latest version of <IP_ADDRESS> but this has been happening to me for a very long time.
Have you been able to recreate this? This would be great to resolve. Thanks


Add Otto/Underscore to the imports

This allows extended functionality in the JavaScript scripting engine used here.
Read http://underscorejs.org/ for more details.

Seems good


Button Size Limited to 264px

Limited button width to 264px
#18

Thanks for working on this but @roygrv21 volunteered for it before you did! Please keep an eye out and volunteer for upcoming issues, or look into one of the unassigned ones already up!


Cannot open pybullet

Hey guys, it seems that I have downloaded pybullet but is unable to run it on my computer. Do you guys know why it goes "not responding"?

No idea but this seems to be a purely a question about pybullet, not iGibson, right?
Some things:

you seem to pip install without virtual environment. Taht is usually not recommended
we have our own version of pybullet to be used with iGibson. if you are trying to use iGibson, you'll need that

Good luck!


Error: Cannot find module 'node_modules/iohook/builds/electron-v76-darwin-x64/build/Release/iohook.node'

Expected Behavior
Error: Cannot find module 'node_modules/iohook/builds/electron-v76-darwin-x64/build/Release/iohook.node'
at webpackEmptyContext (webpack:///./node_modules/iohook_sync?:2:10)
at Object.eval (webpack:///./node_modules/iohook/index.js?:10:80)
Context
I added all file to builds but  it not work
Your Environment

Version used<EMAIL_ADDRESS>Environment name and version (e.g. Chrome 39, node.js 5.4):
node: '12.13.0',
v8: '8.0.426.30-electron.0',
uv: '1.32.0',
zlib: '1.2.11',
brotli: '1.0.7',
ares: '1.15.0',
modules: '76',
nghttp2: '1.41.0',
napi: '5',
llhttp: '1.1.4',
http_parser: '2.8.0',
openssl: '1.1.0',
icu: '65.1',
unicode: '12.1',
electron: '8.5.5',
chrome: '80.0.3987.163'
Operating System and version (desktop or mobile): mac
Link to your project:

我弄错了


Feature request: Allow timeToRead to include extra fields

Allow including additional fields in the timeToRead calculation to factor in additional fields, as sometimes there is content used outside of the content field.
Maybe it should have an include: ["description"] argument which would let you include field values in the calculation.

To get this now, you can do something like this in your gridsome.server.js, it will add a timeToRead object to your posts. This also works using vue-remark (which I found some other complatins about not working, like https://github.com/gridsome/gridsome/issues/902)..
const readingTime = require('reading-time');

module.exports = function (api, options) {

    api.loadSource(({
        addSchemaTypes
    }) => {
        addSchemaTypes(`
    type ReadTime {
      id: ID!
      text: String
      minutes: Float
      time: Float
      words: Int
    }
  `)
    })

    api.loadSource(({
        addSchemaResolvers
    }) => {
        addSchemaResolvers({
            Post: {
                timeToRead: {
                    type: 'ReadTime',
                    resolve(obj) {
                        return readingTime(obj.content)
                    }
                }
            }
        })
    })
}

You will also need to install https://www.npmjs.com/package/reading-time

To get this now, you can do something like this in your gridsome.server.js, it will add a timeToRead object to your posts. This also works using vue-remark (which I found some other complatins about not working, like https://github.com/gridsome/gridsome/issues/902)..
const readingTime = require('reading-time');

module.exports = function (api, options) {

    api.loadSource(({
        addSchemaTypes
    }) => {
        addSchemaTypes(`
    type ReadTime {
      id: ID!
      text: String
      minutes: Float
      time: Float
      words: Int
    }
  `)
    })

    api.loadSource(({
        addSchemaResolvers
    }) => {
        addSchemaResolvers({
            Post: {
                timeToRead: {
                    type: 'ReadTime',
                    resolve(obj) {
                        return readingTime(obj.content)
                    }
                }
            }
        })
    })
}

You will also need to install https://www.npmjs.com/package/reading-time


How can I deal with absolute path in websocket handshake

the package seems like this:
GET ws://<IP_ADDRESS>:8000/websocket http/1.1
WebSocketServerProtocolHandshakeHandler.isWebSocketPath(HttpRequest)
this method need req.uri() start with "/"

Sorry I dont understand your problem... Can you give some more details ?

see


Linux realm join

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Enable the playbook to automatically realm join any of the Linux based machines.

Support for CentOS 7 added in v1.2.0, Working on Ubuntu 18.04, 20.04, and 22.04

Support for Ubuntu 18.04, 20.04 and 22.04 added in v1.2.0.


As a librarian or researcher I can see more details about a topic in a card without having to go to the detail page

Story

As a librarian or researcher, when I for example, see a list of for example publications, projects or datasets, I can see the most important information first. When I want a bit more information without going into the detailed view, I can do so without leaving the screen.

Success Criteria

[ ] I can see the most important information without clicking, only scrolling
[ ] I can see more information without going to the detailed view
[ ] This is an pattern we can reuse for different types of cards and information.

Context
Right now we are forcing a lot of information in a small card. This information is sometimes is not needed on first glance, but should not force someone to go to a detail page if they are in an explorative modus.
Example: record

Example: projects
In the future, more information could be useful here that you d

on't need to see on first sight.
Example of collapsable information in the old interface

Example of way too many authors:

Design proposal
The designs for this issue can be found here
Still giving the layout/visual hierarchy of the list item a bit more thought, but this is where I've landed so far:
Overview with all items collapsed:

Overview with some items expanded:

Since the list of authors can be very long, I've placed them in a column grid to add some structure.
Since reviewers mostly want to check the UGent authors I was wondering if it could make sense to add a filter at the top to show

All authors
UGent authors only
External authors only

Buttons at the bottom
While taking a look at this issue I also experimented with placing all controls at the bottom of a list item:

My concern is how to consistently apply this pattern with buttons at the bottom of list items throughout the entire application (publication detail headers, etc.)
Alternatives
An alternative to show more information from the overview page could be a popover with more details, similar to what Github does when hovering over an issue  (but then maybe by clicking on a trigger like the show more button above).
The benefit here could be that the list items don't change height/the content doesn't jump when expanding the more info panel, but then it wouldn't be possible to view more details of multiple items at the same time

Questions

What is your overall feedback on the proposal above?
What do you think about the filter to view UGent authors only?
What do you think about the layout with the buttons at the bottom of a list item?
Would you like me to explore the alternative solution? Would it be helpful to view more details of multiple items at the same time?

Thank you for these thorough explorations. I think the “show more” at the bottom, with the other buttons consistent at the top will be clear and feasible.
The grid of 3
Seems great, I want to test it with actual data (long names), but it seems like a good solution.
Show UGent only
I’ll suggest this one, but they usually want to check if all of them are in there too to have a correct bibliography. But I’ll need to check if my assumption is correct!
Buttons at the bottom
To me putting all the actions at the bottom is a bit busier overall when you look at the overall design. Good experiment, but the list items seem to be less of a unit (perhaps it’s the line above the actions?). I haven’t looked at it for a while so I think it’s not just the “being used to the previous design”.
The popover
I like the idea of information not hopping around. The popover would be good if you click it and it does not disappear if you navigate away or click on it. The librarians often copy information. We can look into this in the next round, interesting!

Thanks a lot for the feedback!
I've added a generic example of a list item with expandable content in the documentation and have also applied it to the publication overview screens
Toggle to show more details:
<button class="btn btn-link btn-link-p-0 btn-sm mt-4" type="button" data-toggle="collapse" data-target="#moreDetails-0" aria-expanded="false" aria-controls="null">

More details

</button>

Card with more details in a definition list

Label

Value


Add missing package-info file in jqassistant package

fix #10432

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Congratulations for your first contribution @NolwennD ! 😁


descriptor.pb.swift not included when installed by cocoapods

In my case, i need to use google.protobuf.EnumValueOptions, which is defined in descriptor.pb.
Shouldn't we put descriptor.pb.swift into cocoapods's Source directory?

SwiftProtobuf doesn't currently use the descriptors, so we don't bundle the files.  You are free to generate and include that yourself if you'd like.
Note, we don't use the descriptors because we don't currently provide any descriptor objects for the compiled in protos (or proto style reflection).  It is something we may provide in the future, but did not want to commit to for version 1 of the library.

Also note the collection of types included in the SwiftProtobuf library is not arbitrary.  The types we include today are part of the protobuf spec; they are the "well-known types" that must be directly supported by any conforming protobuf implementation.  As it happens, descriptor.proto is not one of the official "well-known types," so I don't think we should include it without a very good reason.  As @thomasvl pointed out, were we to embed descriptors into the generated source code, that would constitute such a reason.

Thank you guys for your convincing explanations.
I just add it to my project manually to handle my case and everything is ok.


Cannot set shortcut key

There is no mouse cursor here, and the selected button cannot be switched between left and right buttons. I hope that if the mouse is not available, at least you need to use the keyboard to set these.

I cant reproduce this. It seems to affect some users, cause is unknown... Doesnt seem to relate to Windows version, Steam/GOG/EGS, fullscreen/borderless... Kind of out of ideas what may be the cause...
Something is blocking things for you, cannot tell what...
Try launching Cyberpunk2077.exe directly, without any params etc.
Also, if you have any other mods, would try with just CP77 and CET. There is a possibility of some mod interference we did not detected yet...

Note that any mods that are not archive mods may potentially be the cause so remove redmods and redscripts if direct launch from exe does not work.
If something helps you from this, good. If not, honestly a mistery for now unless someone manages to find the cause.

Note that any mods that are not archive mods may potentially be the cause so remove redmods and redscripts if direct launch from exe does not work.
If something helps you from this, good. If not, honestly a mistery for now unless someone manages to find the cause.

I don't use any mods, and the game folder is very clean. I'm not sure what blocks the ui, but when I configure a value, it will work. For example,~represents "54043195528445952"

Yeah that is known that it works if you set it manually. Something is messing with early toggle or how to call it. I cant figure out what :(

Had the same issue while running the game via Lutris. I had to click onto the bind button while tabbed out for it to work. I have a fresh installation with only CET and Native Settings UI. Same issue and solution inside the tweaks menu.

Fixed by https://github.com/yamashi/CyberEngineTweaks/commit/81852491baff76ed2bc731a16e307f468566d3ce
Hotfix should get released soon hopefully.


Add can_have_content getter for Element

Here's an example implementation of item 3 from #160.

Needs to land after https://github.com/cloudflare/lol-html/pull/165 since it fixes some warnings.

Just landed #165 which should fix the warnings.  Can you rebase on master and squash your commits into a single one please?

Merged.  Thank you!


Peer to peer code review

Hello
The project looks good.
The project readme is professional.✔✔
Good GitHub flow.✔

Thank you @MPDADDY for your review 🙌


Fix for PHP 8.1

Sorry @M3sca but the 2.x branch is in maintenance mode only. We are not doing any more releases.
If you want PHP 8 support you need to migrate to Slim 4.


not able to transform arrow functions while bundling js

Bug report
What is the current behavior?
I can see a new feature called dependOn is added to webpack which fits in rightly for my requirement. As I moved my webpack version from 4.43.0 to 5.0.0-beta.16, for some reasons the transformation of arrow function in bundle.js is not happening.
If the current behavior is a bug, please provide the steps to reproduce.
Let me share my configurations.
Package.json
`
{
  "name": "root",
  "private": true,
  "workspaces": [
    "compositions/*"
  ],
  "dependencies": {
    "classnames": "^2.2.6",
    "core-js": "3",
    "react": "^16.10.2",
    "react-dom": "^16.10.2"
  },
  "devDependencies": {
    "@babel/cli": "^7.8.4",
    "@babel/core": "^7.9.6",
    "@babel/plugin-proposal-class-properties": "^7.8.3",
    "@babel/plugin-transform-runtime": "^7.9.6",
    "@babel/polyfill": "^7.8.7",
    "@babel/preset-env": "^7.9.6",
    "@babel/preset-react": "^7.9.4",
    "@emcm-ui/stylelint-config": "^1.2.2",
    "@storybook/react": "^5.3.18",
    "babel-core": "7.0.0-bridge.0",
    "babel-loader": "^8.1.0",
    "babel-plugin-styled-components": "^1.10.7",
    "babel-polyfill": "^6.26.0",
    "compression-webpack-plugin": "^3.1.0",
    "css-loader": "^3.5.3",
    "duplicate-package-checker-webpack-plugin": "^3.0.0",
    "es6-promise": "^4.2.8",
    "eslint": "^6.8.0",
    "fs-extra": "^9.0.0",
    "isomorphic-fetch": "^2.2.1",
    "lerna": "^3.20.2",
    "mini-css-extract-plugin": "^0.9.0",
    "module": "^1.2.5",
    "npm-run-all": "^4.1.5",
    "postcss": "^7.0.27",
    "postcss-calc": "^7.0.2",
    "postcss-css-variables": "^0.17.0",
    "prettier": "^1.19.1",
    "reduce-css-calc": "^2.1.7",
    "regenerator-runtime": "^0.13.5",
    "style-loader": "^1.2.1",
    "uglifyjs-webpack-plugin": "^2.2.0",
    "webpack": "5.0.0-beta.16",
    "webpack-bundle-analyzer": "^3.6.0",
    "webpack-cli": "^3.3.11"
  },
  "scripts": {
    "build": "yarn format && webpack --mode production",
    "start": "start-storybook -p 5555",
    "npmScript": "webpack --mode production",
    "postcss": "node scripts/buildVars.js",
    "cleanup": "./cleanup.sh",
    "format": "yarn internal:prettier \"./*.{js,jsx,json,md}\" \"./**/*.{js,jsx,json,md}\" --write",
    "internal:lint:js": "eslint --ext .js,.jsx --ignore-path .eslintignore",
    "internal:prettier": "prettier",
    "lint": "npm-run-all lint:*",
    "lint:format": "yarn internal:prettier --list-different \"./*.{js,jsx,json,md}\" \"./**/*.{js,jsx,json,md}\"",
    "lint:js": "yarn internal:lint:js .",
    "lint:js:fix": "yarn internal:lint:js . --fix"
  }
}

`
webpack.config.js
`
const path = require("path");
const BundleAnalyzerPlugin = require("webpack-bundle-analyzer")
  .BundleAnalyzerPlugin;
const DuplicatePackageCheckerPlugin = require("duplicate-package-checker-webpack-plugin");
const webpack = require("webpack");
const getPackages = require("./scripts/getPackages");
const localPackage = require("./package.json");
const MiniCssExtractPlugin = require("mini-css-extract-plugin");
const UglifyJsPlugin = require("uglifyjs-webpack-plugin");

module.exports = {
  entry: {
    icons: path.resolve(__dirname, "node_modules", "@emcm-ui/icons")
  },
  output: {
    filename: "[name].js"
  },
  devServer: {
    inline: true,
    port: 3002
  },
  module: {
    rules: [
      {
        test: /\.(js|jsx)$/,
        exclude: /(node_modules|bower_components)/,
        use: {
          loader: "babel-loader",
          options: {
            presets: [
              [
                "@babel/preset-env",
                {
                  useBuiltIns: "entry",
                  corejs: { version: 3, proposals: true }
                }
              ],
              "@babel/preset-react"
            ],
            plugins: [
              "@babel/plugin-proposal-class-properties",
              "@babel/plugin-transform-arrow-functions",
              "@babel/plugin-transform-runtime"
            ]
          }
        }
      },
      {
        test: /\.css$/,
        use: [
          // This is executed in reverse order #important
          MiniCssExtractPlugin.loader,
          // "style-loader",
          "css-loader" // this is used to understand the import statement in js for css
        ]
      }
    ]
  },
  plugins: [
    new BundleAnalyzerPlugin({
      analyzerMode: "static",
      generateStatsFile: true,
      openAnalyzer: false,
      statsOptions: {
        source: false
      }
    }),
    new MiniCssExtractPlugin({
      // Options similar to the same options in webpackOptions.output
      // both options are optional
      filename: "[name].css"
    }),
    new DuplicatePackageCheckerPlugin()
  ]
};
`

**polyfill.js**

`
import "regenerator-runtime/runtime";
import "core-js/es";
import "isomorphic-fetch";
import es6Promise from "es6-promise";

es6Promise.polyfill();

`
What is the expected behavior?
I should see my bundle.js transformed into without arrow function in them as most of the browsers cannot read them. The same works when I downgrade my webpack version to 4.43.0
Other relevant information:
webpack version:  5.0.0-beta.16
Node.js version: v12.16.2
Operating System: Windows 32
Additional tools: VSCode
Any help would be appreciated

Thanks for your report. It would be great if you reduce your issue to a small reproducible example. Best put this example into a github repository together with instructions how to get to the problem.

@montogeek : Please find below git repo for the same
https://github.com/anooj-curator/arrow-function-webapck

@montogeek
Find the below steps to reproduce the issue.

Please checkout below project from GIT
https://github.com/anooj-curator/arrow-function-webapck
then do the following
run npm install
then run npm build
it will create a bundle.js file inside its folder
Ideally, the bundle should be a transformed bundle without any arrow function
but if you notice the bundle has got some arrow functions that many legacy browsers cannot access.

Please let me know if I am missing anything here.

Any Update on this. Please let me know in case you need any further information.

@anooj-curator probably you need to decrease ecmaVersion, take a look https://github.com/webpack/changelog-v5#improved-code-generation

This worked thanks a lot @vankop

Putting output.ecmaVersion: 2009 seems to work.


[FLINK-33076][network] Reduce serialization overhead of broadcast emit from ChannelSelectorRecordWriter.

What is the purpose of the change
ChannelSelectorRecordWriter#broadcastEmit serialize the record to ByteBuffer but didn't use it. It will re-serialize this record per-channel. We should allows all channels to reuse the serialized buffer.
Brief change log

Reduce serialization overhead of broadcast emit from ChannelSelectorRecordWriter.

Verifying this change
This change is already covered by existing tests, such as RecordWriterTest*.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

Thanks @reswqa for fixing the bug. LGTM now.


Add documentation for supporting flavors

https://flutter.dev/docs/deployment/flavors currently links to some community articles, but it would be better if there were official documentation.
For example, https://github.com/flutter/flutter/issues/56507 is due to confusion about flavors and build configurations in Xcode.  However there's no place to update and emphasize the correct fix for this issue, or even any documentation to link to.  There have been some attempts to make flavors easier to use in iOS and those community articles can get out of date.  There's a lot of bad advice on Stack Overflow that get people in a corrupted state.

Also include instructions for different signing details per flavor, see https://github.com/flutter/flutter/issues/46879.


error when starting goldstone, even after deleting and reimporting docker images.

Current Behavior
jaldaz [11:49 AM]
after build finish I get these errors

gstask_1   | [2016-05-19 19:48:00,162: ERROR/MainProcess] Task
goldstone.core.tasks.service_status_check[626ba0dc-322f-4768-aa37-fcef5e3b5264] raised
unexpected: KeyError('aggregations',)
gstask_1   | Traceback (most recent call last):
gstask_1   |   File "/venv/local/lib/python2.7/site-packages/celery/app/trace.py", line 240, in trace_task
gstask_1   |     R = retval = fun(*args, **kwargs)
gstask_1   |   File "/venv/local/lib/python2.7/site-packages/celery/app/trace.py", line 438, in __protected_call__
gstask_1   |     return self.run(*args, **kwargs)
gstask_1   |   File "/home/app/goldstone/core/tasks.py", line 190, in service_status_check
gstask_1   |     found_services_by_host = result['aggregations']['per_host']['buckets']
gstask_1   | KeyError: 'aggregations'

alex.jacobs [11:49 AM]
if you let it continue to run does it eventually clear up?

[11:49]
or does the server stop?

jaldaz [11:49 AM]
nope, over and over again the same issues

jaldaz [11:50 AM]
and dashboard doesnt work at all

@vichargrave wondering if you have any insight into the error above?

jxstanford [4:52 PM]
That message indicates that the query that is looking for services in API calls is not finding any, so
either the query is broken or logs aren't flowing.  Get Vic involved to debug that if necessary.

If it helps, I wouldnt have any issue in give you ssh access by a public ip and debug it on my enviroment.

jor@jor-laptop ~/devel/goldstone-server $ docker images -a REPOSITORY                 TAG                                   IMAGE ID            CREATED             SIZE <none>                     <none>                                8218f5818838        3 days ago          687.6 MB <none>                     <none>                                9aabce5bb7be        3 days ago          687.6 MB goldstoneserver_gstask     latest                                ae9039f9066a        3 days ago          687.6 MB <none>                     <none>                                56551e28f246        3 days ago          687.6 MB <none>                     <none><PHONE_NUMBER>a5        3 days ago          687.6 MB <none>                     <none>                                5e9024adf429        3 days ago          457.8 MB <none>                     <none>                                686a56843bfe        3 days ago          457.8 MB goldstoneserver_gslog      latest                                4dd9971509d4        3 days ago          457.8 MB <none>                     <none>                                300887b68ee3        3 days ago          454.5 MB <none>                     <none>                                5769a3ce5213        3 days ago          451.2 MB <none>                     <none>                                e7da966b70c1        3 days ago          451.3 MB goldstoneserver_gstaskq    latest                                bb844ee589d7        3 days ago          148.6 MB goldstoneserver_gssearch   latest                                ed8ad6d8ad38        3 days ago          318.9 MB <none>                     <none>                                32a9ed7c5867        3 days ago          318.9 MB <none>                     <none>                                17f27018a57f        3 days ago          318.8 MB <none>                     <none><PHONE_NUMBER>6f        3 days ago          318.8 MB <none>                     <none>                                0b5474f15cdb        3 days ago          318.8 MB <none>                     <none>                                922b92b14095        3 days ago          282.1 MB <none>                     <none>                                aee410dbeccc        3 days ago          274.6 MB goldstoneserver_gsdb       latest                                4c379cdfa87a        3 days ago          274.6 MB <none>                     <none>                                100493ae4c48        3 days ago          274.6 MB <none>                     <none>                                c1811aac301b        3 days ago          274.6 MB <none>                     <none>                                6e2e4b945599        3 days ago          274.6 MB kibana                     4.1                                   a08f390218fe        4 days ago          234.8 MB solinea/goldstone-base     1.1.1-SNAPSHOT.256.g792adab.develop   15403f6e137c        11 days ago         687.6 MB logstash                   2.1                                   51a7a86bcc90        2 weeks ago         451.2 MB solinea/postgres           9.4                                   52fa257a912f        4 weeks ago         274.6 MB solinea/elasticsearch      1.7.1                                 821f45c9a0be        9 weeks ago         282.1 MB solinea/redis              3.0.4                                 20fbe8b51989        7 months ago        148.6 MB

per @joraldaz
bin/configure_vbox.sh didnt work
jor@jor-laptop ~/devel/goldstone-server $ bin/configure_vbox.sh

***********************************************************************
    A host network with address <IP_ADDRESS> already exists.
    You can find it using 'VBoxManage list --long hostonlyifs'.
    After you find the name, adjust your development OpenStack instance
    network settings for interface 2 accordingly.
***********************************************************************

***********************************************************************
    A NAT network with name GoldstoneDevNAT already exists.
    You can inspect it using 'VBoxManage list --long natnetworks'.
    Adjust your development OpenStack instance network settings
    for interface 1 accordingly.
***********************************************************************
Finished configuring VM network interfaces
Host does not exist: "default"
processing rule: es_9200_local,tcp,,9200,,9200
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: es_9300_local,tcp,,9300,,9300
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: logstash_syslog_local,tcp,,5514,,5514
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: logstash_metrics_local,udp,,5516,,5516
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: logstash_agent_local,tcp,,5516,,5516
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: logstash_internal_local,tcp,,5517,,5517
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: postgres_local,tcp,,5432,,5432
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: redis_local,tcp,,6379,,6379
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: kibana_local,tcp,,5601,,5601
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: gs_8000_local,tcp,,8000,,8000
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: gs_8443_local,tcp,,8443,,8443
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
processing rule: flower_local,tcp,,5555,,5555
VBoxManage: error: Could not find a registered machine named 'default'
VBoxManage: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "FindMachine(Bstr(a->argv[0]).raw(), machine.asOutParam())" at line 486 of file VBoxManageModifyVM.cpp
Encountered errors setting up NAT rules for default

This is what after many tries, worked for me.

Clean Enviroment if neeed and leave it ready

$ docker rm -f $(docker ps -qa)
$ docker rmi -f $(docker images  | grep a | awk '{print $3}')
Delete RDO from virtual boc
$ pkill -f VirtualBox
import RDO on VirtualBox
Start RDO, I needed to allow promiscuous mode for RDO networks otherwise it wont start
$ workon goldstone-server
$ pip install -r docker/goldstone-base/config/requirements.txt
$ pip install -r docker/goldstone-base/config/test-requirements.txt

$ bin/start_dev_env.sh --app-edition=oss --docker-vm=none
(wait for build arround 5 minutes)

$ docker exec -it goldstoneserver_gsapp_1 bash
(venv) $ fab -f post_install.py -H <IP_ADDRESS> configure_stack:<IP_ADDRESS>,True,True
(venv) $ exit

Stop build process, Ctrl+C

docker rm -f $(docker ps -qa)
pkill -f VirtualBox

bin/start_dev_env.sh --app-edition=oss --docker-vm=none --app-location=local

closing.  I think this was a combo of issues including replacing RDO image, but not running configure_stack.


onRequestPermissionsResult not called in non-activity class

Device type: Redmi note 8 pro
OS version: Android 11
EasyPermissions version: com.vmadalin:easypermissions-ktx:1.0.0_
I am making a helper class for EasyPermissions. The request dialog is being shown but the onRequestPermissionsResult is not being called inside the helper class. Its working fine if its inside an activity. Is there anyway in which onRequestPermissionsResult can be called from a non-activity class?
Code

   fun requestPermission(
        rationale: String,
        REQUEST_CODE: Int,
        permissions: String,
    ) {
        EasyPermissions.requestPermissions(
            mActivity,
            rationale,
            REQUEST_CODE,
            permissions
        )
    }

   override fun onRequestPermissionsResult(
        requestCode: Int,
        permissions: Array<out String>,
        grantResults: IntArray
    ) {
        EasyPermissions.onRequestPermissionsResult(requestCode, permissions, grantResults, mContext)
    }

I can confirm this. Annotating a method with @AfterPermissionGranted that is not inside an Activity does not seem to trigger a callback and the function is not called after the permission dialog.