useFetch triggers a request on the client side in nested components (using resolveComponent)

Environment

Operating System: Linux
Node Version:  v18.12.1
Nuxt Version: 3.4.2
Nitro Version: 2.3.3
Package Manager<EMAIL_ADDRESS>Builder:  vite
User Config:  components
Runtime Modules:  -
Build Modules: -

Reproduction
https://stackblitz.com/edit/nuxt-starter-38tkoc
Describe the bug
This issue happens when you use nested <component :is="component" />
If you resolve the parent component with the string - useFetch triggers a request only on the server side and the data is transferred to the client, which is fine.
const component = resolveComponent('Main');

If you resolve the parent component with the variable, everything renders well, but useFech triggers a request both on the server side and the client side
const name = 'Main';
const component = resolveComponent(name);

Components are registered as global components as it was mentioned here.
Additional context
There is an index.vue page in the stackblitz example where everything works fine, and variable.vue which is "broken".
Logs
No response

As I understand, "behind the scenes" you use defineAsyncComponent to register the component as an async component and it gets separated into its own chunk (here is an example replacing resolveComponent with defineAsyncComponent in the previous example).
When the chunk is loaded on the client, data from the useFetch somehow doesn't get transferred although it exists in the payload, and a new request is then triggered.
Here's a workaround, which doesn't seem right 😄
Do you have any other ideas or workarounds on how to achieve this without triggering the request on the client?

With further "investigation", I concluded that the inner/nested component somehow doesn't hydrate.
I've changed the asyncData.ts and removed nuxt.isHydrating just to return the payload and everything works as it should, but of course that's not a great idea to do.
const getCachedData = () => nuxt.payload.data[key] || nuxt.static.data[key]

Next, I've tried useHydration composable, and for some reason it's not auto-imported so you need to import it
import { useHydration } from '#app';

But useHydration doesn't work either because the app:created hook from the hydrate.ts never gets triggered, and that's the place where the set function is called on the client. I've tested it with app:mounted instead and it worked, strangely without hydration node mismatch.
Example for useHydration: https://stackblitz.com/edit/nuxt-starter-zqpoed?file=app.vue
Besides that, app:created (and many more hooks) doesn't work in any custom composable (just like in hydrate.ts), but the documentation says that the runtime hooks should work within the composables.
@danielroe can you please tell me if these are the Nuxt bugs so I can create a new issue or open a PR, or am I just doing something wrong?
Thanks!

The root issue here is an upstream Vue bug with hydrating async components: https://github.com/vuejs/core/issues/6638.
We can track within the Nuxt repository via https://github.com/nuxt/nuxt/issues/18405.


how to create new corpus

how to create new corpus from binaries or other files?

Hello! It was documented, but not well documented...
I just have added a section in "How to use the tool" in the README.

Thanks, I will try it!

If it is not secret, can you tell which architecture you want to add to the corpus?

I just want to make a experiment, if I create a larger corpus,dose the accuracy can be improved?

The results of your experiment will be interesting.
My experiments showed me that it is very difficult to improve the accuracy of architecture detection when there are a lot of architectures in the corpus, especially because for many of them I had only very small samples. The easiest way to improve the accuracy of the tool is to remove the architectures that are unlikely to be used by the binary you are looking at.
I think that to improve the accuracy of the tool, one needs to use another technique than the one I have implemented. The problem is that if we want to use standard supervised machine learning techniques, we need a bigger corpus than what I have been able to collect.

Closing this issue.
If you have some feedback on your experiment to share, please open a new issue!


Nuget restore is failed in Windows build.

Description

Sometimes dotnet build command is failed on Nuget restore step. The error:

error NU1101: Unable to find package <package name>. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages

repro: https://github.com/vsafonkin/ualbion/runs/1726489951?check_suite_focus=true

Configuration

Which version of .NET is the code running on? 5.0.101
What OS and version, and for Linux, what distro? Windows
What is the architecture (x64, x86, ARM, ARM64)? x64

It can be fixed either with creation nuget.config file with nuget sources list or running dotnet nuget locals all --clear before build.

Are you using Visual Studio? If yes, do you see nuget sources when you go to Tools -> Options -> NuGet Package Manager -> Package sources? I ask because your error message says Microsoft Visual Studio Offline Packages
@dagood is this something in your area?

@carlossanlop this happened in a couple of my repos as well. It only happens when building on github actions with a windows vm while using the setup-dotnet action. I fixed it by adding a nuget.config even though I don't need one.
The issue popped up out of no where for me, and by the sound of it the same is true most of the people reporting the issue (and linking to it) in https://github.com/actions/setup-dotnet/issues/155.

I don't know what could cause this, especially with dotnet nuget locals all --clear being a way to fix it. That makes me think it can't be something as simple as a machine misconfiguration (a bad global or user-level NuGet.config file). However, it isn't my area.
I think https://github.com/NuGet/Home/issues would be the right place to get help debugging this.

@aortiz-msft  could you transfer to https://github.com/NuGet/Home/issues?

This issue was moved to NuGet/Home#10586


Add, remove, reorder, and group by metadata tracks on the heatmap

Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-417
https://biomage.atlassian.net/browse/BIOMAGE-419
Link to staging deployment URL
https://ui-ui-track.scp-staging.biomage.net/
Links to any Pull Requests related to this
N/A
Anything else the reviewers should know about the changes here
N/A
Changes
Code changes
Added a transfer-style component to the heatmap settings menu to be able to quickly add, remove, reorder, and group by metadata tracks.
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[x] Tested locally with Inframock
[ ] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[x] Relevant Github READMEs updated
[x] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by @vickymorrison

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[x] Photo of a cute animal attached to this PR

Staging deployed at https://ui-ui-track.scp-staging.biomage.net/ @ivababukova @vickymorrison

Staging deployed at https://ui-ui-track.scp-staging.biomage.net/ @ivababukova @vickymorrison


Issues installing on Ubuntu 14.04

User reported an issue installing the agent on 14.04, will try to get more details.

@zsherman I'm closing this as there are no more details provided


Javazon gg gloves shopper script

Draft of javazon gg gloves shopper script.
Looks for and buys +20 ias +3 java skill gloves at Anya.
Usage:

Have enough gold in inventory or private stash ~100k or more
Start bot with python src/javashopper.py
Go to act 5 Hell and have red portal in screen. (Optimal char level according to this post is 75 but anything above works)
Press your start button
Profit!

Exit button can be pressed at any time to stop.

Hey! Nice work! It can also be a good idea to check for warcry weapons in a5 town

@aeon0 Do you want me to update release.py with another binary and update README, or should we wait and just keep it a run-from-source script for now?

@aeon0 Do you want me to update release.py with another binary and update README, or should we wait and just keep it a run-from-source script for now?

We keep the shopping stuff out of the release exe for now.

@aeon0 I noticed that lowering the time in the wait() calls in npc_manager.py speeds up the shopping quite significantly, especially in the long run.
However I didn't commit those changes since I didn't know how it'd effect the other script. Maybe I should copy/inherit that functionality and make it specific for my shopping script?

@aeon0 I noticed that lowering the time in the wait() calls in npc_manager.py speeds up the shopping quite significantly, especially in the long run.
However I didn't commit those changes since I didn't know how it'd effect the other script. Maybe I should copy/inherit that functionality and make it specific for my shopping script?

If it works and is quicker I have no issue with adapting the npc_manager.py itself.

Merged it now, we can change the npc speed in a separate PR. Many thx!


Expectation tests

I wanted to hack on some coreutils to teach myself Zig.
I was going to start by pulling in the Rust MIT license coreutils shell expectation tests and GNU shell expectation tests to run the Zig binaries under.
Any particular way you wanted this organized?

I've been busy with other things recently, so haven't been about to give this project any love.
Any improvements you can make go right ahead, i'll help in anyway I can :+1:


Fixed the behavior of scrollsToTop that owned by a original window.

+1, scrollsTopTop doesn't work anymore when DCIntrospect is activated.

Aha, that makes sense.  My bad myell0w, I owe you an hour!

well you saved my more than an hour by writing this awesome library, so we are good I guess ;)
Am 11.10.2011 um 23:05 schrieb Patrick Richards:

Aha, that makes sense.  My bad myell0w, I owe you an hour!
--
Reply to this email directly or view it on GitHub:
https://github.com/domesticcatsoftware/DCIntrospect/pull/28#issuecomment-2371180


Single threaded tracer

The goal of this PR is to provide a tracer that does no internal threading and allows a customizable transport while not exposing internal data structures used by the library.
I put together an example that shows how the tracer could be integrated into an application using libevent.
There are still quite a few pieces to fill in for the library. Some of the design points I've been thinking about are

How should you opt in to use the single threaded tracer? Currently I have it set up to use a separate options structure, but not sure that's the best way.
Do we want to provide a default transporter for the single threaded tracer? I wrote out what the API might look like and showed how you could use it in the example, but didn't provide an implementation. GRPC's async api doesn't let you work at the socket level, so you would need to use a lower level library like nghttp2 if you wanted to make a default transporter that's usable in applications built on top of epoll or equivalent. This version of the tracer seems pretty specialized, so I'm not sure who would use such a default transporter.
I image you'd only want to be recording spans on a single thread for this tracer, but do we want to still make the recorder thread-safe in case it is called concurrently for some reason?

This looks good. To the questions (1) and (3) above re: options struct and synchronization, one solution I would favor is to force the user to subclass their instance, then (1) make abstract virtual getters for the things you need and the user provide those options in code, (3) let the user provide locking if they need it for some reason. Unless this solution is much worse, that is.
For (2) I think you've done enough, and in any case I would be most interested in what Lyft needs to upgrade to this version immediately for Envoy. As we have customers that want to use this arrive, we may know more about examples that would be useful to have.
This is definitely on a good track.


python3-ha-av_10.0.0.bb:do_compile  Failure

Hello,
I am building homeassistant with Yocto and everything compiles successfully apart from the python3-ha-av_10.0.0.
This appears to be an issue even for those installing the package manually as discussed and solved here: https://community.home-assistant.io/t/unable-to-install-package-ha-av/466286/31
I am using the Mickledore branch.
Has anyone successfully built this recently? and how can I solve this issue? The rest of the build has completed successfully.
Thanks

Hi,
Yeah I built it recently and I haven't had any problems with building or running it.
Could you tell me a bit more, what error message are you exactly seeing?
One thing to note is that this package depends on ffmpeg which does complain about having to accept licenses depending on how this is build exactly.

Thanks for the response @ Gerry546. I did not get any warnings or errors regarding ffmpeg.
Below is the error log with regard to the python3-ha-av:
Initialising tasks: 100% |#####################################################################################################| Time: 0:00:10
Sstate summary: Wanted 354 Local 341 Mirrors 0 Missed 13 Current 4371 (96% match, 99% complete)
NOTE: Executing Tasks
ERROR: python3-ha-av-10.0.0-r0 do_compile: ExecutionError('/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/temp/run.do_compile.32763', 1, None, None)
ERROR: Logfile of failure stored in: /home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/temp/log.do_compile.32763
Log data follows:
| DEBUG: Executing shell function do_compile
| * Getting build dependencies for wheel...
| running egg_info
| writing ha_av.egg-info/PKG-INFO
| writing dependency_links to ha_av.egg-info/dependency_links.txt
| writing entry points to ha_av.egg-info/entry_points.txt
| writing top-level names to ha_av.egg-info/top_level.txt
| reading manifest file 'ha_av.egg-info/SOURCES.txt'
| reading manifest template 'MANIFEST.in'
| warning: no files found matching '*.h' under directory 'include'
| adding license file 'LICENSE.txt'
| writing manifest file 'ha_av.egg-info/SOURCES.txt'
| * Building wheel...
| running bdist_wheel
| running build
| running build_py
| running build_ext
| building 'av.codec.codec' extension
| x86_64-poky-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot -Wsign-compare -DNDEBUG -g -O3 -Wall -O2 -pipe -g -feliminate-unused-debug-types -fcanon-prefix-map -fmacro-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3/3.11.4/Python-3.11.4=/usr/src/debug/python3/3.11.4-r0 -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3/3.11.4/Python-3.11.4=/usr/src/debug/python3/3.11.4-r0 -fmacro-prefix-map=/build/path/unavailable/=/usr/src/debug/python3/3.11.4-r0 -fdebug-prefix-map=/build/path/unavailable/=/usr/src/debug/python3/3.11.4-r0 -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot= -fmacro-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot= -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot-native= -O2 -pipe -g -feliminate-unused-debug-types -fcanon-prefix-map -fmacro-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3/3.11.4/Python-3.11.4=/usr/src/debug/python3/3.11.4-r0 -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3/3.11.4/Python-3.11.4=/usr/src/debug/python3/3.11.4-r0 -fmacro-prefix-map=/build/path/unavailable/=/usr/src/debug/python3/3.11.4-r0 -fdebug-prefix-map=/build/path/unavailable/=/usr/src/debug/python3/3.11.4-r0 -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot= -fmacro-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot= -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot-native= -O2 -pipe -g -feliminate-unused-debug-types -fcanon-prefix-map -fmacro-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/ha-av-10.0.0=/usr/src/debug/python3-ha-av/10.0.0-r0 -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/ha-av-10.0.0=/usr/src/debug/python3-ha-av/10.0.0-r0 -fmacro-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/ha-av-10.0.0=/usr/src/debug/python3-ha-av/10.0.0-r0 -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/ha-av-10.0.0=/usr/src/debug/python3-ha-av/10.0.0-r0 -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot= -fmacro-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot= -fdebug-prefix-map=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot-native= -fPIC -I/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot/usr/include/python3.11 -c src/av/codec/codec.c -o build/temp.linux-x86_64-cpython-311/src/av/codec/codec.o
| src/av/codec/codec.c: In function '__pyx_pymod_exec_codec':
| src/av/codec/codec.c:5977:36: error: 'AV_CODEC_CAP_TRUNCATED' undeclared (first use in this function); did you mean 'AV_CODEC_CAP_HARDWARE'?
|  5977 |   __pyx_t_7 = __Pyx_PyInt_From_int(AV_CODEC_CAP_TRUNCATED); if (unlikely(!__pyx_t_7)) __PYX_ERR(0, 55, __pyx_L1_error)
|       |                                    ^~~~~~~~~~~~~~~~~~~~~~
|       |                                    AV_CODEC_CAP_HARDWARE
| src/av/codec/codec.c:5977:36: note: each undeclared identifier is reported only once for each function it appears in
| src/av/codec/codec.c:6163:36: error: 'AV_CODEC_CAP_AUTO_THREADS' undeclared (first use in this function); did you mean 'AV_CODEC_CAP_SLICE_THREADS'?
|  6163 |   __pyx_t_7 = __Pyx_PyInt_From_int(AV_CODEC_CAP_AUTO_THREADS); if (unlikely(!__pyx_t_7)) __PYX_ERR(0, 105, __pyx_L1_error)
|       |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~
|       |                                    AV_CODEC_CAP_SLICE_THREADS
| src/av/codec/codec.c:6226:36: error: 'AV_CODEC_CAP_INTRA_ONLY' undeclared (first use in this function); did you mean 'AV_CODEC_PROP_INTRA_ONLY'?
|  6226 |   __pyx_t_7 = __Pyx_PyInt_From_int(AV_CODEC_CAP_INTRA_ONLY); if (unlikely(!__pyx_t_7)) __PYX_ERR(0, 117, __pyx_L1_error)
|       |                                    ^~~~~~~~~~~~~~~~~~~~~~~
|       |                                    AV_CODEC_PROP_INTRA_ONLY
| src/av/codec/codec.c:6247:36: error: 'AV_CODEC_CAP_LOSSLESS' undeclared (first use in this function); did you mean 'AV_CODEC_PROP_LOSSLESS'?
|  6247 |   __pyx_t_7 = __Pyx_PyInt_From_int(AV_CODEC_CAP_LOSSLESS); if (unlikely(!__pyx_t_7)) __PYX_ERR(0, 119, __pyx_L1_error)
|       |                                    ^~~~~~~~~~~~~~~~~~~~~
|       |                                    AV_CODEC_PROP_LOSSLESS
| error: command '/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/core2-64-poky-linux/python3-ha-av/10.0.0/recipe-sysroot-native/usr/bin/x86_64-poky-linux/x86_64-poky-linux-gcc' failed with exit code 1
|
| ERROR Backend subprocess exited when trying to invoke build_wheel
| WARNING: exit code 1 from a shell command.
ERROR: Task (/home/tower1/yocto/mickledore/poky/meta-homeassistant/recipes-homeassistant/homeassistant-component-deps/python3-ha-av_10.0.0.bb:do_compile) failed with exit code '1'
NOTE: Tasks Summary: Attempted 10019 tasks of which 10016 didn't need to be rerun and 1 failed.

Summary: 1 task failed:
  /home/tower1/yocto/mickledore/poky/meta-homeassistant/recipes-homeassistant/homeassistant-component-deps/python3-ha-av_10.0.0.bb:do_compile
Summary: There was 1 ERROR message, returning a non-zero exit code.

Hmm at first I though it might have something to do with the machine you are building for since I build mostly arm images and not for x86-64. But I cannot seem to reproduce the problem, neither with cleaning my downloads and sstate, or building the same machine.
So this also happens when you clean out all cache information about the recipe and just build this one?

It's failing even after cleaning all the cache using cleanall both for the recipe and the entire image.
I have so far tried to compile for the following machines, but the recipe is failing with the same error(s):
qemux86-64
qemux86
qemuarm
The ffmpeg recipe being built is ffmpeg_6.0.bb.
I hope I can get some solution to this.

I have tried building for raspberrypi-cm3 and I now get the following error. I am not sure if it is related to the above recipe but so far I have not managed to build the homeassistant regardless of the target machine. Could it be an issue with my host machine?
Initialising tasks: 100% |#####################################################################################################| Time: 0:00:56
Sstate summary: Wanted 362 Local 346 Mirrors 0 Missed 16 Current 4244 (95% match, 99% complete)
NOTE: Executing Tasks
ERROR: core-image-homeassistant-1.0-r0 do_rootfs: Could not invoke dnf. Command '/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/recipe-sysroot-native/usr/bin/dnf -v --rpmverbosity=info -y -c /home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/rootfs/etc/dnf/dnf.conf --setopt=reposdir=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/rootfs/etc/yum.repos.d --installroot=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/rootfs --setopt=logdir=/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/temp --repofrompath=oe-repo,/home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/oe-rootfs-repo --nogpgcheck install packagegroup-core-boot python3-homeassistant run-postinsts' returned 1:
DNF version: 4.16.1
cachedir: /home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/rootfs/var/cache/dnf
Added oe-repo repo from /home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/oe-rootfs-repo
User-Agent: falling back to 'libdnf': could not detect OS or basearch
repo: using cache for: oe-repo
oe-repo: using metadata from Fri 01 Sep 2023 04:17:50 AM UTC.
Last metadata expiration check: 0:00:02 ago on Fri 01 Sep 2023 04:17:53 AM UTC.
--> Starting dependency resolution
--> Finished dependency resolution
Error:
 Problem: conflicting requests
  - nothing provides python3-async-timeout = 4.0.2 needed by python3-homeassistant-2023.5.0-r0.cortexa7t2hf_neon_vfpv4 from oe-repo
  - nothing provides python3-attrs = 22.2.0 needed by python3-homeassistant-2023.5.0-r0.cortexa7t2hf_neon_vfpv4 from oe-repo
  - nothing provides python3-pyyaml = 6.0 needed by python3-homeassistant-2023.5.0-r0.cortexa7t2hf_neon_vfpv4 from oe-repo
  - nothing provides python3-aiohttp = 3.8.4 needed by python3-homeassistant-2023.5.0-r0.cortexa7t2hf_neon_vfpv4 from oe-repo
  - nothing provides python3-awesomeversion = 22.9.0 needed by python3-homeassistant-2023.5.0-r0.cortexa7t2hf_neon_vfpv4 from oe-repo
  - nothing provides python3-lru-dict = 1.1.8 needed by python3-homeassistant-2023.5.0-r0.cortexa7t2hf_neon_vfpv4 from oe-repo
  - nothing provides python3-requests = 2.28.2 needed by python3-homeassistant-2023.5.0-r0.cortexa7t2hf_neon_vfpv4 from oe-repo
  - nothing provides python3-typing-extensions = 4.5.0 needed by python3-homeassistant-2023.5.0-r0.cortexa7t2hf_neon_vfpv4 from oe-repo
(try to add '--skip-broken' to skip uninstallable packages)

ERROR: Logfile of failure stored in: /home/tower1/yocto/mickledore/projects/homeAssistant/build/tmp/work/raspberrypi_cm3-poky-linux-gnueabi/core-image-homeassistant/1.0/temp/log.do_rootfs.5893
ERROR: Task (/home/tower1/yocto/mickledore/poky/meta-homeassistant/recipes-homeassistant/images/core-image-homeassistant.bb:do_rootfs) failed with exit code '1'
NOTE: Tasks Summary: Attempted 9673 tasks of which 9646 didn't need to be rerun and 1 failed.

Summary: 1 task failed:
  /home/tower1/yocto/mickledore/poky/meta-homeassistant/recipes-homeassistant/images/core-image-homeassistant.bb:do_rootfs
Summary: There was 1 ERROR message, returning a non-zero exit code.

Are you building a specific tag of this layer? Or is this an intermediate commit you are trying? I recommend at least to build the tags.
The last error seems strange, and possibly unrelated, For instance, it cannot seem to find python3-pyyaml. But that recipe is provided by poky/meta/recipes-devtools/python itself in the mickledore branc, so that would mean your bblayers.conf might be misconfigured?

Is this issue still occuring with the latest version?

Current main needs support from a newer version 10.1.1. So I would say no.


Build Ruleset 4: LIT Holder

Build Ruleset 4: LIT Holder which will generate a Verifiable Credential (VC) if the following validates:

Check the IDHub controller (user) holds LIT tokens

Important: A specific address must be provided and passed to the Parachain from the F/E using the params extrinsic param to verify this

If the ruleset validates then a VC should be generated and returned to the F/E.

Correct: this ruleset should test if “any of the linked accounts holds any LIT”. Not just the main address.

This makes less sense though, as the main address has to hold some LIT to be able to send extrinsics at all. That's why I consider this rule a bit vague.
I suggest that we double-check it with Kayla or Rodrigo

The actual workflow is:

user calls the parachain extrinsic
parachain&TEE knows this user’s main address (Litentry parachain address)
because any active Litentry address needs to hold more than zero LIT tokens
TEE queries user’s any other linked and verified address(e.g, ETH address, BSC address)
and calculate ‘if they hold any LIT’, if true, TEE will generate a LIT Holder VC

Reply from Rodrigo:
For the user the Quest would be:

- Connect any account that holds LIT (if you don’t have any already connected)
- Generate a VC to show that you are a LIT Holder

so in the VC generation we could check all

so in the VC generation we could check all

So it actually means we want to check if any linked account (so main account excluded) holds any LIT

Tim gave the demo interface:
https://graph.tdf-labs.io/latest/graphql?query=query{VerifiedCredentialsIsHodler(%0A%[…]%22%0A%20%20minimumBalance%3A%200.00000056%0A){isHodler}}%0A
https://graph.tdf-labs.io/latest/graphql?query=query%7BVerifiedCredentialsIsHodler(%0[…]%20%20minimumBalance%3A%200.00000057%0A)%7BisHodler%7D%7D%0A


Followup on EDS

reduce logging (use env variable until someone finds out how to configure modules in the new logger)
add a fail-safe env variable, in case we need to turn it off. Needs to be set in the injector template if needed.
add the TLS option for grpc port (first attempt - will replace with proper grpc listener in followup).
Shriram: yes, I still agree we should load the certs in pilot, but can be done later.
starting to add some structs for debug and push - in progress, will keep adding while the rest is reviewed. Main question is how to name the clients for the debug - based on POD ID (IP) and watched resource, pod name and resource, or  group by remote pod. A http handler listing all connected endpoints and the watched resources in followup.
finish the move of all eds-related functions to eds.go (from mesh_discovery)

Also this changes the 2 'istio-on-istio' pilot configs to v2.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
64ec2a13eff97220ae3ddecf1eedf87e9eaeb625
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
64ec2a13eff97220ae3ddecf1eedf87e9eaeb625
link
/test istio-unit-tests

prow/istio-presubmit.sh
64ec2a13eff97220ae3ddecf1eedf87e9eaeb625
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
64ec2a13eff97220ae3ddecf1eedf87e9eaeb625
link
/test istio-presubmit

prow/istio-unit-tests.sh
6c5a90f8a919e443e94a0d29946384ca5b773339
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6c5a90f8a919e443e94a0d29946384ca5b773339
link
/test istio-unit-tests

prow/istio-presubmit.sh
6c5a90f8a919e443e94a0d29946384ca5b773339
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
6c5a90f8a919e443e94a0d29946384ca5b773339
link
/test istio-presubmit

prow/istio-unit-tests.sh
176e227d69311e59a39b1a41f0e399d61e6d08ba
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
176e227d69311e59a39b1a41f0e399d61e6d08ba
link
/test istio-unit-tests

prow/istio-presubmit.sh
176e227d69311e59a39b1a41f0e399d61e6d08ba
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
176e227d69311e59a39b1a41f0e399d61e6d08ba
link
/test istio-presubmit

prow/istio-unit-tests.sh
69146835ec6739c3d392274dfd9c2d22a7f4165e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69146835ec6739c3d392274dfd9c2d22a7f4165e
link
/test istio-unit-tests

prow/istio-presubmit.sh
69146835ec6739c3d392274dfd9c2d22a7f4165e
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
69146835ec6739c3d392274dfd9c2d22a7f4165e
link
/test istio-presubmit

prow/istio-unit-tests.sh
d752547355b95a92b556254e498b0fd56b7f319f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d752547355b95a92b556254e498b0fd56b7f319f
link
/test istio-unit-tests

prow/istio-presubmit.sh
d752547355b95a92b556254e498b0fd56b7f319f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d752547355b95a92b556254e498b0fd56b7f319f
link
/test istio-presubmit

prow/istio-unit-tests.sh
4031ee1363646499959a8e9651d19236a5a234c6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4031ee1363646499959a8e9651d19236a5a234c6
link
/test istio-unit-tests

prow/istio-presubmit.sh
4031ee1363646499959a8e9651d19236a5a234c6
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
4031ee1363646499959a8e9651d19236a5a234c6
link
/test istio-presubmit

prow/istio-unit-tests.sh
ff74f00ac7b9475c3607ce9aea1675177ad30b81
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ff74f00ac7b9475c3607ce9aea1675177ad30b81
link
/test istio-unit-tests

prow/istio-presubmit.sh
ff74f00ac7b9475c3607ce9aea1675177ad30b81
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
ff74f00ac7b9475c3607ce9aea1675177ad30b81
link
/test istio-presubmit

prow/istio-unit-tests.sh
56faadac568885f09aa7efb40c305277c864f66b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
56faadac568885f09aa7efb40c305277c864f66b
link
/test istio-unit-tests

prow/istio-presubmit.sh
56faadac568885f09aa7efb40c305277c864f66b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
56faadac568885f09aa7efb40c305277c864f66b
link
/test istio-unit-tests

prow/istio-presubmit.sh
a29d463a295916f0bd5cde699e8b5fa29553f074
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
a29d463a295916f0bd5cde699e8b5fa29553f074
link
/test istio-presubmit

prow/istio-unit-tests.sh
a29d463a295916f0bd5cde699e8b5fa29553f074
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Please split the PR into manageable chunks. It's not a good practice to tie a bunch of things together into a broad PR. It makes it hard to revert the change if the need arises, and it's difficult to provide reasonable reviews. You've already identifier 4-5 chunks for 4-5 PRs that could be derived from this.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a29d463a295916f0bd5cde699e8b5fa29553f074
link
/test istio-unit-tests

prow/istio-presubmit.sh
e4d02a0258bacf8d0c2a02e11b125777b0730287
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
e4d02a0258bacf8d0c2a02e11b125777b0730287
link
/test istio-presubmit

prow/istio-unit-tests.sh
e4d02a0258bacf8d0c2a02e11b125777b0730287
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
91664f4b98a5f4cc27dd37f8a6b405deb3ecd462
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
91664f4b98a5f4cc27dd37f8a6b405deb3ecd462
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
91664f4b98a5f4cc27dd37f8a6b405deb3ecd462
link
/test e2e-simple

prow/istio-presubmit.sh
7d2d7b02c88dd9b251350dc7da0a94ec800dd432
link
/test istio-presubmit

prow/istio-unit-tests.sh
7d2d7b02c88dd9b251350dc7da0a94ec800dd432
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
91664f4b98a5f4cc27dd37f8a6b405deb3ecd462
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
91664f4b98a5f4cc27dd37f8a6b405deb3ecd462
link
/test e2e-simple

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
91664f4b98a5f4cc27dd37f8a6b405deb3ecd462
link
/test e2e-simple

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-simple

prow/istio-presubmit.sh
76282055d519bf88b65bdbf6711a84c2f8d3104c
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-simple

prow/istio-presubmit.sh
76282055d519bf88b65bdbf6711a84c2f8d3104c
link
/test istio-presubmit

prow/istio-unit-tests.sh
76282055d519bf88b65bdbf6711a84c2f8d3104c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-simple

prow/istio-unit-tests.sh
76282055d519bf88b65bdbf6711a84c2f8d3104c
link
/test istio-unit-tests

prow/istio-presubmit.sh
6035849665f8ccb0885aaa38e75c480374972e10
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-simple

prow/istio-presubmit.sh
6035849665f8ccb0885aaa38e75c480374972e10
link
/test istio-presubmit

prow/istio-unit-tests.sh
6035849665f8ccb0885aaa38e75c480374972e10
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-simple

prow/istio-presubmit.sh
6035849665f8ccb0885aaa38e75c480374972e10
link
/test istio-presubmit

prow/istio-unit-tests.sh
be9aec903b700bf91855b090a1f27c16d37466e9
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-simple

prow/istio-unit-tests.sh
be9aec903b700bf91855b090a1f27c16d37466e9
link
/test istio-unit-tests

prow/istio-presubmit.sh
be9aec903b700bf91855b090a1f27c16d37466e9
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-simple

prow/istio-presubmit.sh
be9aec903b700bf91855b090a1f27c16d37466e9
link
/test istio-presubmit

prow/istio-unit-tests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
517267d4d06781874a2da3b58859e957243ab62c
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
d885a0f0759492202207012e87d655815cb3ad11
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
330981aea07cd359234c0ae08e9512fa1e130a59
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test e2e-simple

prow/istio-pilot-e2e.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test e2e-simple

prow/istio-pilot-e2e.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
2bb9fd12277115868cb1c9cf50990f41eca0d5cd
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
2bb9fd12277115868cb1c9cf50990f41eca0d5cd
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
2bb9fd12277115868cb1c9cf50990f41eca0d5cd
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
2bb9fd12277115868cb1c9cf50990f41eca0d5cd
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
2bb9fd12277115868cb1c9cf50990f41eca0d5cd
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
2bb9fd12277115868cb1c9cf50990f41eca0d5cd
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a69ebd9f611dc074e3b06c9340f14f9388516cca
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
96a10f6e5e4f7e936d9327c82021d261b6cb25f7
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

moved the build to separate PR
moved the change of pilot config to v2 to separate PR ( certificates don't seem to work ?)

Thanks to simple found another bug that I need to fix - I had the same bug 3 times already
in the last 10 years, I guess it's hard to learn :-) - closing a connection will cleanup, but may
delete another connection from same endpoint. Working on a fix.

Thanks to simple found another bug

🎉
btw simple was just a start and example I wrote to show how we can write a lot more simple tests to test basic features... yet beside #1081 I don't think we wrote any new tests in that file since (oct, when some folks didn't want to add it as a new test)

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
296e32b0035661c01f45a60d796581ff452cde94
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
1bf203225ac8a8e0b518e3be7390ab2091c70fac
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
1bf203225ac8a8e0b518e3be7390ab2091c70fac
link
/test istio-unit-tests

prow/istio-presubmit.sh
1bf203225ac8a8e0b518e3be7390ab2091c70fac
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-bookInfo

prow/istio-presubmit.sh
1bf203225ac8a8e0b518e3be7390ab2091c70fac
link
/test istio-presubmit

prow/istio-unit-tests.sh
0f1038854846a343bab99cfee96a629336de4283
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
0f1038854846a343bab99cfee96a629336de4283
link
/test istio-unit-tests

prow/istio-presubmit.sh
0f1038854846a343bab99cfee96a629336de4283
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
0f1038854846a343bab99cfee96a629336de4283
link
/test istio-unit-tests

prow/istio-presubmit.sh
b3642320391f308e81b3ae79b53c79bf4ae16d08
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-bookInfo

prow/istio-presubmit.sh
b3642320391f308e81b3ae79b53c79bf4ae16d08
link
/test istio-presubmit

prow/istio-unit-tests.sh
b3642320391f308e81b3ae79b53c79bf4ae16d08
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-simple

prow/istio-pilot-e2e.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8b6a19982717cc493aeac99427f4781babe8d704
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
b3642320391f308e81b3ae79b53c79bf4ae16d08
link
/test istio-unit-tests

prow/istio-presubmit.sh
7a570bba8a0504a4c3b66a8cd2f2e6d8f359182b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The v2 fetch is not implemented - it had a stub, but was not tested and didn't really work with envoy.
Envoy expects json response for REST - it won't make a grpc Fetch request. We can add it at some point, but we did GRPC streaming first. Separate PR if we find a need for having both.

Regarding logs - agreed, will make a follow up to default the logs to off, but for next few days I would rather have more logs related to EDSv2, in case any problem is found ( in particular on prow or real testing ).
We have an env variable that will turn off most of the EDSv2 logs.
It is very helpful in finding a lot of ordering issues.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
d50e98afe7fa57df57ecdf884a52f41b8a82d238
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2ad748d8429d6986f7ebb880db701cb71728b757
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2ad748d8429d6986f7ebb880db701cb71728b757
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
c26f045f28bf2831b131b0099b09bed17010efc3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4d2e58c9f528a990cbfb84b5d7bd5e51fc120a82
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4d2e58c9f528a990cbfb84b5d7bd5e51fc120a82
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
4d2e58c9f528a990cbfb84b5d7bd5e51fc120a82
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4d2e58c9f528a990cbfb84b5d7bd5e51fc120a82
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
cfb851319d1615c9966b16f6e3f4d36526b4e0df
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
cfb851319d1615c9966b16f6e3f4d36526b4e0df
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
cfb851319d1615c9966b16f6e3f4d36526b4e0df
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
cfb851319d1615c9966b16f6e3f4d36526b4e0df
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
24fd7ee051c54d21e6dc0ab47e1fe719edf0a11d
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
24fd7ee051c54d21e6dc0ab47e1fe719edf0a11d
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
24fd7ee051c54d21e6dc0ab47e1fe719edf0a11d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
45d68d383aead9629fab7e7b6d93a440543a4721
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
45d68d383aead9629fab7e7b6d93a440543a4721
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
efca02cc9df481c9ea0b03713b5da4de4d9f98a3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
efca02cc9df481c9ea0b03713b5da4de4d9f98a3
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
efca02cc9df481c9ea0b03713b5da4de4d9f98a3
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
1b7f5895bf54245309e3a26d5ed4b2ae3202e8f1
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
1b7f5895bf54245309e3a26d5ed4b2ae3202e8f1
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Simplify token example removing authorization and clawback

What
Remove authoriation and clawback from the token example.
Why
Clawback is not a feature of the standard token. It's a little odd in a lightweight token example to include functionality that isn't part of the standard token interface. It is part of the Stellar Asset contract, but other tokens do not need to provide clawback functionality. So it muddies the water on what is or isn't part of the standard token interface to provide it.
Likewise, I don't think authorization should be part of the standard token interface and I've opened a PR proposing its removal in https://github.com/stellar/rs-soroban-sdk/pull/1079. Authorization logic could be so varied, and many contracts are unlikely to have it. For the moment I've simplified the authorization logic in the example contract to simply say that all addresses are authorized.
As a side-effect these changes simplify the token example, which is helpful. The standard token has enough functions as it is for folks to wrap their minds arounds. Everything we can do to help them step into building their own token with reduced complexity and concerns lowers the barrier.

Similar to #275, I was going to merge this to a branch for the next release. But the changes in this PR doesn't meaningful manifest themselves into the docs for this example. Because the example is so large only a small subset of its code is actually embedded in the docs. So I think this change won't present a significant inconsistency.


"Thanks" tab duplicates on the About page

I had an issue with the “Thanks to” tab. All tabs look fine when you open them but if you click on the "thanks to" one and then go to any other tab, the text of the “Thanks” tab is duplicated on the bottom of the other tabs you open. It only happens with this one as far as I have noticed, the others go away just fine.

This is weird. I have no idea why it is doing this.
Everything seems to check out, code-wise. Can someone else take a look as well? Maybe I am missing something.

Seems to be fixed.


[CdapIO] Complete examples for CDAP Hubspot plugins

Added examples for the following CDAP Hubspot plugins:

Batch Source
Batch Sink
Streaming Source

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java_Clickhouse_IO_Direct PreCommit

Run Java_Kafka_IO_Direct PreCommit

Run Java_Pulsar_IO_Direct PreCommit

Run Java PreCommit

Run Java_Pulsar_IO_Direct PreCommit

R: @johnjcasey
R: @chamikaramj
We divided our https://github.com/apache/beam/pull/23501 by example (service). This one is for the Hubspot examples.
Could you please take the time to review it?
Thank you for your attention to it!

Run Java_HCatalog_IO_Direct PreCommit

Run Python PreCommit

Run Java PreCommit

@johnjcasey
We would really appreciate it if you would take the time to review the PR with the Hubspot example.
Thank you for your time and consideration!


Is there a textFieldDidChange delegate method?

Is there a delegate method for textFieldDidChange, which is called whenever the text field in the AnimatedField changes? The documentation mentions func animatedField(_ animatedField: AnimatedField, shouldChangeCharactersIn range: NSRange, replacementString string: String) -> Bool? which seems to work very similarly, but I was curious if there is a separate didChange method.
func textFieldDidChange(textField: UITextField) {
    //your code
}

Hi @sergiogcharles !!
No, there's no textFieldChange. As you mention, you can use the other method that is very similar. Anyway, I will add it in next update.
Thank you!


Update .spi.yml

I noticed we hadn't updated our Linux images with the name change from val → hylo and so the builds (including doc generation) were failing.
This should fix everything up and also move doc gen to be run with 5.10.

Thanks a lot!


Signin only works locally, not production

I'm using next-auth-sanity 1.4.8 and everything works great locally, but when deployed to Vercel, the signin doesn't work.
My logic suggests that when a user signs up, he/she should be logged in after the user is created (the code is posted below).
The user get's created and can be found in the sanity data lake, but when it's time to sign in, the user get's redirected to https://www.domain-name.com/api/auth/error
I've been suggested to set both NEXTAUTH_URL and NEXTAUTH_SECRET in Vercel, but they already exist and didn't do any difference to the outcome.
From the network tab:

package.json:
"dependencies": {
    "@babel/core": "^7.17.0",
    "@headlessui/react": "^1.7.4",
    "@sanity/block-content-to-react": "^3.0.0",
    "@sanity/client": "^2.23.2",
    "axios": "^1.2.0",
    "classnames": "^2.3.2",
    "current-week-number": "^1.0.7",
    "dotenv": "^16.0.1",
    "formidable": "^2.1.1",
    "groq": "^2.15.0",
    "next": "^13.2.4",
    **"next-auth": "^4.17.0",**
    **"next-auth-sanity": "^1.4.8",**
    "next-pwa": "^5.5.2",
    "next-sanity": "^0.5.2",
    "next-sanity-image": "^4.1.0",
    "nprogress": "^0.2.0",
    "react": "^18.2.0",
    "react-content-loader": "^6.2.0",
    "react-dom": "^18.2.0",
    "react-hook-form": "^7.43.0",
    "react-icons": "^4.4.0",
    "react-modal": "^3.16.1",
    "react-modal-image": "^2.6.0",
    "react-player": "^2.11.0",
    "react-portable-text": "^0.4.3",
    "react-social-icons": "^5.15.0",
    "react-tooltip": "^5.10.0"
  },
  "devDependencies": {
    "@babel/preset-react": "^7.18.6",
    "autoprefixer": "^10.4.7",
    "eslint": "^8.34.0",
    "eslint-config-next": "^13.2.4",
    "husky": "^8.0.3",
    "next-sitemap": "^2.5.28",
    "postcss": "^8.4.14",
    "tailwindcss": "^3.0.24"
  },

signup/signin module
import { signIn } from "next-auth/react";
import { signUp } from "next-auth-sanity/client";
// [...]
const Signup = () => {
  const [modalIsOpen, setIsOpen] = useState(false);
  const [sanityError, setSanityError] = useState("");

  const router = useRouter();

  const {
    handleSubmit,
    formState: { errors },
    register,
    setValue,
    getValues,
    watch,
  } = useForm();

  useEffect(() => {
    watch();
  }, [watch]);

  const errorHandler = (error) => {
    console.error(error);
    setSanityError(error);
    setTimeout(() => {
      setSanityError("");
    }, 10_000);
  };

sanityClient.js
import { createClient } from "next-sanity";

const config = {
  dataset: process.env.NEXT_PUBLIC_SANITY_DATASET,
  projectId: process.env.NEXT_PUBLIC_SANITY_PROJECT_ID,
  token: process.env.SANITY_API_TOKEN,
  apiVersion: "2023-02-01",
  useCdn: true,
  withCredentials: true,
};

export const client = createClient(config);

[...nextauth].js
import NextAuth from "next-auth";
import { SanityAdapter, SanityCredentials } from "next-auth-sanity";
import { client } from "../../../lib/sanityClient";

const options = {
  providers: [SanityCredentials(client)],
  session: {
    strategy: "jwt",
  },

  secret: process.env.JWT_SECRET_WORD,
  adapter: SanityAdapter(client),
  callbacks: {
    async jwt({ token }) {
      return token;
    },
    async session({ session, token }) {
      session.accessToken = token.accessToken;
      session.user.id = token.sub;
      return session;
    },
  },
};

export default NextAuth(options);

Hi! @Ojself thanks, i'll take a look

Update: I tried to deploy the whole project to Netlify with success. The signup and signin works as expected over there.
So this issue is Vercel specific.

@Ojself maybe it can be the next-auth version? i deployed the full example to vercel and the credentials works fine
here you can take a look:
App Dir: https://next-auth-sanity-example.vercel.app/app/credentials
Pages: https://next-auth-sanity-example.vercel.app/credentials
the example is using the latest next-auth version (4.20.1)

I tried upgrading the next-auth version and copy-paste the code from the snippets you posted above. The same issue occur, it works locally, but not in production.
I'm to suspect it must be something with my code. As a last effort, I posted my env variables. Is the examples you posted above using the same variables, or am I missing something?

Sorry I didn't respond to this sooner.
Yes I am exposing System Environment Variables automatically. I tried to redeploy after changing them as well. The preview and deployed version is the same.
I ended up moving the whole project from Vercel to Netlify with success. I'm sure there's just a small config at Vercel in order to fix it, but I couldn't figure it out.


[Bug] Check-sa policy false positive on deployments with Service Account

Kyverno Version
1.9.x
Kubernetes Version
1.24.x
Kubernetes Platform
EKS
Description
I have check-sa applied on my cluster. When adding a deployment that uses a service account, there is a policy violation reported. (Visible in Policy Reporter UI).
Steps to reproduce

Install check-sa
Apply a Deployment that uses a Service Account

apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    env: dev
  name: dev-echo-server
  namespace: gjktest
spec:
  replicas: 2
  selector:
    matchLabels:
      app: echo-server
      env: dev
  template:
    metadata:
      labels:
        app: echo-server
        env: dev
    spec:
      containers:
        image: jmalloc/echo-server:0.3.3
        imagePullPolicy: Always
        …
        securityContext:
          capabilities:
            drop:
            - NET_RAW
            - ALL
          readOnlyRootFilesystem: true
      serviceAccountName: build-robot

Same happens when killing a previously installed pod (e.g. restart).
Expected behavior
No violation of the policy. The deployment/pod is created by me, not by a service Account. If I understand the description correctly, it should only fail when pods are created by a SA.
Screenshots
No response
Kyverno logs
No relevant logs

Slack discussion
No response
Troubleshooting

[X] I have read and followed the documentation AND the troubleshooting guide.
[X] I have searched other issues in this repository and mine is not recorded.

I tested this on Kyverno 1.9.2 and K3d. When I'm just the "normal" user (i.e., no ServiceAccount in use), your Deployment skips the policy. Please add the -v=4 flag and --dumpPayload=true flag to the main Kyverno container and run your test again with the policy in Enforce mode. Check the Kyverno logs and look at the AdmissionReview that gets dumped. What is shown for request.userInfo?

Any follow up or close?

No response, closing.


Default shared/anonymous configuration without using own Google account

Currently using this tool require to supply email&password for google account, this issue is about avoiding it by supporting Anonymous mode that use shared account, see for example other projects that implement this:
gplaycli: https://github.com/matlink/gplaycli

By default, gplaycli fetches a token from a token dispenser server located at https://matlink.fr/token/ to login in Google Play.

AuroraStore app: https://gitlab.com/AuroraOSS/AuroraStore

Anonymous accounts — You can log in and download with anonymous accounts so you don't have to use your own account

YalpStore app: https://github.com/yeriomin/YalpStore

By default Yalp Store connects to Google services using a built-in account, so you do not have to own a Google account to use it

Hello @emanuelb At the moment, I am somehow busy and I don't have time in order to maintain a token dispenser server. If you can send in a pull request by implementing an existing token dispenser server, that'd be awesome. Otherwise I'll consider this feature in the upcoming days.


Merged WG Repo: new.nodejs.org

For the post-merge team we may need a central repo for coordination (or choose one repo as the primary.)
Related question: will all the repos take issues?

For #359

Can we please add a nodejs.org or new.nodejs.org repo to this org, so we can setup tasks and discuss ideas for the website after the merge? Right now, some ideas/todos end up here, some in joyent/node-website.
It would be good to have one dedicated space to start collecting/organizing topics.

@fhemberger I'll make a comment on the issue for tomorrow's meeting. Thanks for bringing it up again.

@Fishrock123 @rvagg I'm not able to create a new repo in the Nodejs organization, but can we have this new repo (nodejs/new.nodejs.org) created with the same group permissions as the other website project? We want to get the ball rolling :)
(Interesting discovery: I am able to make repos on the joyent organization. Who knew!)

:+1: done

Thanks. I'll get the bare minimum project stuff (aka a README) going there, thanks for the speedy response!


Cookbook: histogram

tableset = table.group_by('factor')
tableset.aggregate([
   ('some_column', agate.Count(), 'count')
])

See #267

This doesn't work because if a value has zero instances, it will have no group and thus won't exist in the aggregated table.

Table.bins('column_name').print_bars('bin', 'count')


REALMC-8257 Add templates fetching for export / pull

one nit that i've noticed is that the templates format seems to be a bit different between pull and create:
realm-cli pull

VS
realm-cli app create

Let's try to align with the create command where we add the template id to the selection

bump


Create HacktoberFest23.md

📝 Description
An app that allows users to check their badges status in Holopin. Users should be able to enter their GitHub username, and the app will fetch their badges information.
💣 Is this a breaking change (Yes/No):

[ ] Yes
[x] No

🚧 How to migrate?
Don't need.
📝 Additional Information
lol

Thank you for your help! @holopin-bot @thanmaisai

Dear @thanmaisai ,
Thank you very much for your contribution. Our holopin-bot has sent your 4 badges, you can claim the badges separately for each comment by using the links sent by holopin-bot.


Did you use hard attention using keras in your code before?

If yes, How did you use it in keras?
Thank you!

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[x] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[x] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

Yes but it's not pretty.
I implemented a (currently proprietary) framework on top of Keras to do some reinforcement learning.
I had to write some custom theano op (or you can use pyfunc if you use tensorflow) which will do the sampling and call the non differentiable functor which update the state and return a reward and action likelyhood, then wrap this op into a keras layer. Then another custom layer which collects the rewards, action likelihoods and value functions, and add the generalized advantage calculations necessary to the loss.
It works end to end and converge successfully on easy problems, (it doesn't have replay memory as it process a full episode at a time, and exploration is not yet good, but on the good side I can have hidden cells which keeps a memory between successive actions like a recursive network).
Though I do not recommend doing it keras because it is quite hard to take advantage of multiple machine parallelism and you definitely want this because it will otherwise be quite slow. So you are probably better using a a3s tensorflow implementation and eventually use some keras model for syntactic sugar.
Alternatively you may want to use evolution strategy and just throw enough machines at it to get result a faster but at greater computational cost.


Add pageview tracking

@paulproteus Care to review/merge/deploy this?

Thanks all for your patience here; I didn't realize this was 6 weeks old, and I misread the URL and thought it was against the Sandstorm website. Reviewing now.


Remove primary navigation component

Remove primary navigation component
Remove documentation for primary navigation component, but keep page with a link to Service navigation on GOV.UK Design System website
Remove examples for the primary navigation component
Update remaining documentation and examples to use Service navigation component, where relevant
Bump package to v4.0.0, a breaking MAJOR release

Looks like around 20 public repos have used this component! https://github.com/search?q=xGovukPrimaryNavigation&type=code

Why do you spoil all my fun @frankieroberto 🥹
So maybe we do a MINOR release, and add deprecation notices where we can. Am thinking:

On the docs, add the above banner
In SCSS, output deprecation warning to the console
In the Prototype Kit templates, includes a deprecation message in the meta data somewhere
Possibly in the Nunjucks somehow, include a filter that outputs a deprecation message to the console

Then, in version 4, remove the component as shown in this PR. I might try and achieve the above in a separate PR.

@paulrobertlloyd that sounds reasonable to me!
We could also do a bit of proactive outreach to the repos who’re using the component to warn them about the deprecation.


Speech commands v1

The preprocessing for speech commands v1 is at /s3prl/downstream/speech_commands/expert.py, right?

I assume that "preprocessing for speech commands" means preparing the dataset and dataloader for the downstream task.
If this is the case, then that's true. You may take a look at expert.py and then you can find out that there are several functions related to preparing the data for the speech commands task, such as a function called split_dataset which helps us split the dataset into training set and validation set.
@dlion168


The page mentions the policy "Allow sites to be reloaded in Internet Explorer mode", while in the latest ADMX file the policy is named "Allow UNCONFIGURED sites to be reloaded in Internet Explorer mode"

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 459e4d0d-27b0-753e-3a60-b8ec6b2092b5
Version Independent ID: 05413a17-f068-8429-af7f-77665f321bbb
Content: Local site list for Internet Explorer (IE) mode
Content Source: edgeenterprise/edge-ie-mode-local-site-list.md
Product: microsoft-edge
GitHub Login: @dan-wesley
Microsoft Alias: shisub

@johanVAva3 Just to confirm, I believe "Allow sites to be reloaded in Internet Explorer mode" is referring to the setting in Microsoft Edge not the policy description.

Hi Kelly, yes it seems to be correct then. Issue may be closed.
Anyway, it would have added value for the article to mention the policy correct with its name ('....unconfigured sites...'), value 'InternetExplorerIntegrationReloadInIEModeAllowed' and data.
Mentioning it like 'policy: InternetExplorerIntegrationReloadInIEModeAllowed' does not give the full info for IT admins, if that is the target audience for the article.

@johanVAva3 Thanks!


Operation progress

What feature or improvement do you think would benefit Files?
Progress when moving/deleting/copying items, pretty self-explanatory.
Requirements
Let's you know where the operation is so far.
Files Version
<IP_ADDRESS>
Windows Version
Windows 10 Pro 21H2 19044.2486
Comments
No response

@yaira2 this one is actually a duplicate of #10755