Qwen2VL FP8_DYNAMIC Failed

When I use the example code to quant Qwen2VL. It can run successfully, but the number of safetensors for the generated model parameters remains the same, and the size of each safetensor does not change. It also fails to load successfully using vllm.
vllm:
[rank0]: Traceback (most recent call last):
[rank0]:   File "/mnt/bn/vllmlfdata/deploymultitokens_place_TEST/handlerfp8.py", line 125, in
[rank0]:     handler = EndpointHandler()
[rank0]:               ^^^^^^^^^^^^^^^^^
[rank0]:   File "/mnt/bn/vllmlfdata/deploymultitokens_place_TEST/handlerfp8.py", line 42, in init
[rank0]:     self.llm = LLM(MODEL_PATH,
[rank0]:                ^^^^^^^^^^^^^^^
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/entrypoints/llm.py", line 178, in init
[rank0]:     self.llm_engine = LLMEngine.from_engine_args(
[rank0]:                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/engine/llm_engine.py", line 550, in from_engine_args
[rank0]:     engine = cls(
[rank0]:              ^^^^
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/engine/llm_engine.py", line 317, in init
[rank0]:     self.model_executor = executor_class(
[rank0]:                           ^^^^^^^^^^^^^^^
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/executor/distributed_gpu_executor.py", line 26, in init
[rank0]:     super().init(*args, **kwargs)
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/executor/executor_base.py", line 47, in init
[rank0]:     self._init_executor()
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/executor/multiproc_gpu_executor.py", line 125, in _init_executor
[rank0]:     self._run_workers("load_model",
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/executor/multiproc_gpu_executor.py", line 199, in _run_workers
[rank0]:     driver_worker_output = driver_worker_method(*args, **kwargs)
[rank0]:                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/worker/worker.py", line 183, in load_model
[rank0]:     self.model_runner.load_model()
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/worker/model_runner.py", line 999, in load_model
[rank0]:     self.model = get_model(model_config=self.model_config,
[rank0]:                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/model_executor/model_loader/init.py", line 19, in get_model
[rank0]:     return loader.load_model(model_config=model_config,
[rank0]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/model_executor/model_loader/loader.py", line 361, in load_model
[rank0]:     model.load_weights(
[rank0]:   File "/home/tiger/.local/lib/python3.11/site-packages/vllm/model_executor/models/qwen2_vl.py", line 1061, in load_weights
[rank0]:     param = params_dict[name]
[rank0]:             ~~~~~~~~~~~^^^^^^
[rank0]: KeyError: 'model.layers.0.mlp.gate_up_proj.weight_scale'

Example output:
Loading checkpoint shards: 100%|█████████████████████████████████████████████████████████████████████| 31/31 [12:25<00:00, 24.05s/it]
2024-12-04T14:25:06.922124+0800 | main | WARNING - Process rank: 0, device: cuda:0, n_gpu: 4, distributed training: True, 16-bits training: False
2024-12-04T14:25:06.922714+0800 | main | INFO - Training/evaluation parameters TrainingArguments(
n_gpu=4,
accelerator_config={'split_batches': False, 'dispatch_batches': None, 'even_batches': True, 'use_seedable_sampler': True, 'non_blocking': False, 'gradient_accumulation_kwargs': None, 'use_configured_state': False},
adafactor=False,
adam_beta1=0.9,
adam_beta2=0.999,
adam_epsilon=1e-08,
auto_find_batch_size=False,
batch_eval_metrics=False,
bf16=False,
bf16_full_eval=False,
clear_sparse_session=False,
data_seed=None,
dataloader_drop_last=False,
dataloader_num_workers=0,
dataloader_persistent_workers=False,
dataloader_pin_memory=True,
dataloader_prefetch_factor=None,
ddp_backend=None,
ddp_broadcast_buffers=None,
ddp_bucket_cap_mb=None,
ddp_find_unused_parameters=None,
ddp_timeout=1800,
debug=[],
deepspeed=None,
disable_tqdm=False,
dispatch_batches=None,
do_eval=False,
do_oneshot=True,
do_predict=False,
do_train=False,
eval_accumulation_steps=None,
eval_delay=0,
eval_do_concat_batches=True,
eval_on_start=False,
eval_steps=None,
eval_strategy=IntervalStrategy.NO,
eval_use_gather_object=False,
evaluation_strategy=None,
fp16=False,
fp16_backend=auto,
fp16_full_eval=False,
fp16_opt_level=O1,
fsdp=[],
fsdp_config={'min_num_params': 0, 'xla': False, 'xla_fsdp_v2': False, 'xla_fsdp_grad_ckpt': False},
fsdp_min_num_params=0,
fsdp_transformer_layer_cls_to_wrap=None,
full_determinism=False,
gradient_accumulation_steps=1,
gradient_checkpointing=False,
gradient_checkpointing_kwargs=None,
greater_is_better=None,
group_by_length=False,
half_precision_backend=auto,
hub_always_push=False,
hub_model_id=None,
hub_private_repo=False,
hub_strategy=HubStrategy.EVERY_SAVE,
hub_token=<HUB_TOKEN>,
ignore_data_skip=False,
include_inputs_for_metrics=False,
include_num_input_tokens_seen=False,
include_tokens_per_second=False,
jit_mode_eval=False,
label_names=None,
label_smoothing_factor=0.0,
learning_rate=5e-05,
length_column_name=length,
load_best_model_at_end=False,
local_rank=0,
log_level=passive,
log_level_replica=warning,
log_on_each_node=True,
logging_dir=/mnt/bn/vllmlfdata/models/Valley-Qwen2-VL-72B-Instruct-1t2k-FP8-Dynamic-llmcompressor/runs/Dec04_14-25-06_g340-cd51-4600-a41e-2b58-ce90-fa00,
logging_first_step=False,
logging_nan_inf_filter=True,
logging_steps=500,
logging_strategy=IntervalStrategy.STEPS,
lr_scheduler_kwargs={},
lr_scheduler_type=SchedulerType.LINEAR,
max_grad_norm=1.0,
max_steps=-1,
metric_for_best_model=None,
mp_parameters=,
neftune_noise_alpha=None,
no_cuda=False,
num_train_epochs=3.0,
oneshot_device=cuda:0,
optim=OptimizerNames.ADAMW_TORCH,
optim_args=None,
optim_target_modules=None,
output_dir=/mnt/bn/vllmlfdata/models/Valley-Qwen2-VL-72B-Instruct-1t2k-FP8-Dynamic-llmcompressor,
overwrite_output_dir=False,
past_index=-1,
per_device_eval_batch_size=8,
per_device_train_batch_size=8,
prediction_loss_only=False,
push_to_hub=False,
push_to_hub_model_id=None,
push_to_hub_organization=None,
push_to_hub_token=<PUSH_TO_HUB_TOKEN>,
ray_scope=last,
recipe=index=None group=None start=None end=None update=None initialized_structure=False initialized_=False finalized_=False started_=False ended_=False config_groups=None ignore=['re:.lm_head', 're:visual.'] targets='Linear' scheme='FP8_DYNAMIC' kv_cache_scheme=None disable_quantization_observer_epoch=None num_calibration_steps=None calibration_dataloader_=None calibration_function_=None calibration_hooks_=None,
recipe_args=None,
remove_unused_columns=True,
report_to=['wandb'],
restore_callback_states_from_checkpoint=False,
resume_from_checkpoint=None,
run_name=/mnt/bn/vllmlfdata/models/Valley-Qwen2-VL-72B-Instruct-1t2k-FP8-Dynamic-llmcompressor,
run_stages=False,
save_compressed=True,
save_on_each_node=False,
save_only_model=False,
save_safetensors=True,
save_steps=500,
save_strategy=IntervalStrategy.STEPS,
save_total_limit=None,
seed=42,
skip_memory_metrics=True,
split_batches=None,
tf32=None,
torch_compile=False,
torch_compile_backend=None,
torch_compile_mode=None,
torch_empty_cache_steps=None,
torchdynamo=None,
tpu_metrics_debug=False,
tpu_num_cores=None,
use_cpu=False,
use_ipex=False,
use_legacy_prediction_loop=False,
use_liger_kernel=False,
use_mps_device=False,
warmup_ratio=0.0,
warmup_steps=0,
weight_decay=0.0,
)
2024-12-04T14:25:07.151883+0800 | _check_create_state | INFO - State created for compression lifecycle
2024-12-04T14:25:07.153866+0800 | pre_initialize_structure | INFO - Compression lifecycle structure pre-initialized for 0 modifiers
2024-12-04T14:25:07.153991+0800 | pre_initialize_structure | INFO - Compression lifecycle structure pre-initialized for 0 modifiers
2024-12-04T14:25:07.154055+0800 | populate_datasets | INFO - Running oneshot without calibration data. This is expected for weight-only and dynamic quantization
Detected kernel version 5.4.143, which is below the recommended minimum of 5.5.0; this can cause the process to hang. It is recommended to upgrade the kernel to the minimum version or higher.
/home/tiger/.local/lib/python3.11/site-packages/bytedmetrics/init.py:10: UserWarning: bytedmetrics is renamed to bytedance.metrics, please using bytedance.metrics instead of bytedmetrics
warnings.warn("bytedmetrics is renamed to bytedance.metrics, please using bytedance.metrics instead of bytedmetrics")
2024-12-04T14:25:07.386838+0800 | one_shot | INFO - *** One Shot ***
2024-12-04T14:25:07.387237+0800 | from_modifiers | INFO - Creating recipe from modifiers
2024-12-04T14:25:07.416408+0800 | _check_compile_recipe | INFO - Recipe compiled and 1 modifiers created
manager stage: Modifiers initialized
2024-12-04T14:25:08.068029+0800 | initialize | INFO - Compression lifecycle initialized for 1 modifiers
manager stage: Modifiers finalized
2024-12-04T14:25:08.068266+0800 | finalize | INFO - Compression lifecycle finalized for 1 modifiers
2024-12-04T14:32:02.322802+0800 | save_model_and_recipe | INFO - Saving output to /mnt/bn/vllmlfdata/models/Valley-Qwen2-VL-72B-Instruct-1t2k-FP8-Dynamic-llmcompressor
========== SAMPLE GENERATION ==============
The attention mask is not set and cannot be inferred from input because pad token is same as eos token. As a consequence, you may observe unexpected behavior. Please pass your input's attention_mask to obtain reliable results.
Hello my name is Kaitlyn and I am a 20 year old female. I have been babysitting for

we met the same issue for Meta-Llama-3-8B-Instruct
GPU: A100-40G, llm-compressor: 0.3.0, vllm: 0.6.4.post1

Hi @LugerW-A it looks like the model isn't compressing after being quantized. Can you share what version of llm-compressor and compressed-tensors you're using?

Hi @LugerW-A it looks like the model isn't compressing after being quantized. Can you share what version of llm-compressor and compressed-tensors you're using?

Thank you.
GPU: L20 llm-compressor: 0.3.0 compressed-tensors:0.8.0

we met the same issue for Meta-Llama-3-8B-Instruct / Meta-Llama-3.1-8B-Instruct GPU: A100-40G, llm-compressor: 0.3.0, vllm: 0.6.4.post1

Hi Did you solve it?

Did anyone solved this issue?

Hi all, you can quantize vision models reliably using the kylesayrs/gptq-partition and running python3 examples/multimodal_vision/qwen.py. Please modify the scheme to reflect FP8 quantization. This pathway is untested for FP8, but it may prove to be more reliable.

we met the same issue for Meta-Llama-3-8B-Instruct / Meta-Llama-3.1-8B-Instruct GPU: A100-40G, llm-compressor: 0.3.0, vllm: 0.6.4.post1

Hi Did you solve it?

No, currently we load it by using vllm with --quantization=fp8 as a workaround

we met the same issue for Meta-Llama-3-8B-Instruct / Meta-Llama-3.1-8B-Instruct GPU: A100-40G, llm-compressor: 0.3.0, vllm: 0.6.4.post1

Hi Did you solve it?

No, currently we load it by using vllm with --quantization=fp8 as a workaround

Hi.Is there any difference between these two? How is the performance?


How can I use knex.raw in transaction?

I try to update multiple rows in a transaction. I need to update some data base on its' original value. Like
update aTable set something = something + 1 where id = '1'

or a function:
update aTable set something = concat_ws('|', title, otherField) where id = '1'

I cannot do that with .update() and I have to use knex.raw(). How can I use it within the transaction? or How can I do that within .update() method?

yes you can and also you can also do:
  knex('aTable').update({
    something: knex.raw('?? +1', ['something'])
  }).where('id', 1)

to create the first query. You can check examples of all the places where you can use knex.raw in http://knexjs.org/


Update add_purchase_order operation

This updates the add_purchase_order operation to properly add/update POs, versions, and revisions while avoiding unnecessary db updates.

depends on PR #932


Small fixes to workbox-navigation-preload page

What's changed, or what was fixed?
In the workbox-navigation-preload module page

Changed "white/blacklist" to "whitelist/blacklist" and "RegExps" to "RegExp's" so it's clearer
Added missing "is"

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


License issue in version 1.3.0

Bug report
Hi,
we have tried to update swr to the latest version (1.3.0) and got a new error during the build:
 WebpackLicensePlugin: Could not find license info for<EMAIL_ADDRESS>We are using WebpackLicensePlugin and it seems the repo changed to a mono-repo causing an issue to access the license for the internal packages (since he is only in the root).

Thanks for reporting, TIL that's affecting license plugin. I think in short term you can only try to manually give a license for it, we're planning to remove those subpath package.json in v2 and respect to the license in root package.json

@huozhi Hi, author of webpack-license-plugin here 👋
With every published version of a package on npm (or any other package registry for that matter), you should either include a LICENSE file that includes the license text and copyright   for this version of the package or have a license key in your package.json, set to the SPDX identifier of the open source license that this version of your package is published as.
It is always preferable to do both - but if you do neither, you’re just making the life of your users harder for no good reason.

hi @codepunkt , those are not separate published packages, the package.json under those sub folders are indent to help bundler to resolve the cjs/esm assets previously. The swr itself does have a MIT license field for it here
The idea is too remove the duplicated package.json which were just designed for module resolving, not to ignore any license we had already. Thanks

@huozhi Understood, thanks for explaining. Do these package.json have any other distinguishing feature that could be used to distinguish them from relevant package.json files and search the parent folder hierarchy for the "correct" one - besides being private: true?

@codepunkt Does the package.json with "name" and marked as "private: true" but without "version" field can be ignored? We're using turbo repo now which requires the package name. But I feel a private package without a version can also be treated as a dummy package? If it's not a case license plugin has that would be perfect to support it 🙏


fixes GRPC constant exception and adds test

LGTM

[Current coverage][cc-pull] is 89.22%

Merging [#30][cc-pull] into [master][cc-base-branch] will increase coverage by 0.09%

@@             master        #30   diff @@
==========================================
  Files            14         14
  Lines          1012       1012
  Methods         107        107
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            902        903     +1
+ Misses          110        109     -1
  Partials          0          0

Powered by Codecov. Last updated by [632c01e...f279e68][cc-compare]
[cc-base-branch]: https://codecov.io/gh/googleapis/gax-php/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/googleapis/gax-php/compare/632c01e3d9e6cb963a572859423a7a6b77a25f17...f279e68d924b3e8bd6bdd5dc00c0893a7fc2536b?src=pr
[cc-pull]: https://codecov.io/gh/googleapis/gax-php/pull/30?src=pr


GraphQL queries return empty although there are matches in DyanamoDB

As you can see from the screenshots when searching for Sets that are מםא active, I get the correct answer, however when active is true, the query returns empty.
After some testing, I realized that it has nothing to do with the active column rather this row simply does not return in the query.
This is new, since yesterday everything worked fine. I don't understand those random AppSync failures.

Hi Ilyador, I answered some of the question on twitter, but you can try adding a limit in the listSets argument, next to filter:
limit: 1000

This should fix the issue, or like I mentioned you can change the operation to a query and query on a secondary index.

The problem is inconsistency. Sometimes the issue happens and most of the time it does not.

@dabit3 I think I understand what you meant: the list query scans the db and the filter applied only afterward. Correct?

If it is so, what happens if I don't define a limit at all? Is there a default limit? Is it random?

In case my db grows big, and I want to avoid querying all and filtering, this is when I should use the secondary index, correct? And if so, how big is "big"?

Pleeeeeease document this somewhere!

Yes, this is correct.

Check out the resolver for the list operation. There will be something there like this:

#set( $limit = $util.defaultIfNull($context.args.limit, 10) )

In the above case, the limit is set as ten if there is no limit passed in. Therefore you would get a nextToken if there were more than 10 items in the DB to continue the scan for the next 10 items.

Yes, I would use the Query operation vs the Scan for anything non trivial. Yes, you would use the key directive to accomplish this. We are about to push some updates to the documentation to explain this in much more detail.

Yes! Agreed, we have this in the works and will be publishing some updates soon. When the new docs come out, we'd appreciate any feedback around this that you might think would be helpful to others.

Thanx @dabit3

I was trying to figure out how to read and edit the resolvers, but the documentation there is also... sub-optimal... to say politely. I couldn't, even with the help of google, to figure out what language are they written in.

It would be nice to be able to see a roadmap, and a clear indication which features are bulletproof production-reaady.


Doctrine Second Level Cache

As always, I must complement the devs on a fantastic bundle, will never get tired of saying it.
Question :
If possible, how can we use this bundle to activate and store doctrine second level cache? Tried many configuration guesses but none have worked e.g this link http://www.ekreative.com/blog/three-symfony2-database-optimisation-tips-to-implement-today/468-three-symfony2-database-optimisation-tips-to-implement-today

Does anyone know whether this bundle is compatible with doctrine second level cache? Activating it with redis results in no cache hit put logs does show cache puts. Switching to memcache or apc works but wouldn't it be great to keep everything in redis:)
Ping @nrk

Sorry @The-Don-Himself but I'm not familiar with the combination of this bundle with Doctrine, I'm just the maintaner of one of the underlying libraries (Predis) used by SncRedisBunlde. You should wait for @snc to give you a better insight of how things work in your use case.

@nrk Apologies for the confusion but thanks for responding, fyi Predis rocks!

I'm also struggling with the second_level_cache, however I managed to get it working. The results are stored in Redis and after they are expired they are retrieved from the database again.
However, I'm using multiple Redis DB's, in this case one specific for Doctrine (And for e.g. sessions in another Redis DB). The problem is that the result cache is written to the default Redis DB and not (in this case DB 11)
How can I configure SncRedis / Doctrine to use a separate DSN for this?
config.yml:
orm:
    entity_managers:
        default:
            second_level_cache:
                region_cache_driver:
                    type: redis
                enabled: true

snc_redis:
    clients:
        default:
            type: phpredis
            alias: default
            dsn: redis://localhost
        doctrine_redis:
            type: phpredis
            alias: doctrine_redis
            dsn: redis://localhost/11
    doctrine:
        metadata_cache:
            client: doctrine_redis
            entity_manager: default
            document_manager: default
            namespace: "%kernel.root_dir%"
        result_cache:
            client: doctrine_redis
            entity_manager: default
            namespace: "%kernel.root_dir%"
        query_cache:
            client: doctrine_redis
            entity_manager: default
            namespace: "%kernel.root_dir%"

Entity.php
* @ORM\Cache(usage="READ_ONLY", region="region_entity")

EntityRepository.php
->getQuery()
->setCacheable(true)
->setLifetime(60)
->useResultCache(true, 60)
->getResult();

I've never used this doctrine feature, but with your config above, doctrine does not use anything from the redis bundle. Is it possible to pass a service there?

@PouleR trust me, I have tried for over a month and this is just not possible currently with SncRedisBundle.
I also tried your config above and it works but not using the redis bundle so it is deceiving you just as @snc has stated it goes to redis directly which is probably not what you want for a distributed cache system.

@The-Don-Himself @PouleR You can create a Redis driver service the same way SncRedisBundle:
services.yml
services:
    snc_second_level_cache:
        class: %snc_redis.doctrine_cache.class%
        calls:
            - ["setRedis"<EMAIL_ADDRESS>            - ["setNamespace", ["DoctrineSecondLevelCache"]]

config.yml
orm:
    entity_managers:
        default:
            second_level_cache:
                region_cache_driver:
                    type: service
                    id: snc_second_level_cache
                enabled: true

snc_redis:
    clients:
        default:
            type: phpredis
            alias: default
            dsn: redis://localhost
        doctrine_redis:
            type: phpredis
            alias: doctrine_redis
            dsn: redis://localhost/11
    doctrine:
        metadata_cache:
            client: doctrine_redis
            entity_manager: default
            document_manager: default
            namespace: "%kernel.root_dir%"
        result_cache:
            client: doctrine_redis
            entity_manager: default
            namespace: "%kernel.root_dir%"
        query_cache:
            client: doctrine_redis
            entity_manager: default
            namespace: "%kernel.root_dir%"

@Pouix Thank you, it looks like this is a good solution for me

@Pouix Brilliant, your solution and generous code solves this. Now we can use SncRedisBundle for Doctrine's second level cache, thanks a bunch and happy holidays!
@snc I think you should consider supporting this feature natively like other doctrine caches. Before, you would have to write a ton of code to first activate result cache and harder than that track db edits and update the cache. Now doctrine is aware of updates and automatically does this for you :)

This is now supported by #230.


Fix broken link syntax in oracles.md

What changed? Why?
Fixes the broken build.
Notes to reviewers
How has it been tested?

Review Error for taycaldwell @ 2023-10-24 00:07:51 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Review Error for taycaldwell @ 2023-10-24 00:12:08 UTC
User failed mfa authentication, see go/mfa-help


Added esp32-2432S028R support

Added support for a new board

Nice, this looks easy after someone figures out the right libraries etc. :)
Couple things:

any ideas for an easier name than esp32-2432S028R? The installs and releases are all driven off this name, so having something a bit friendlier but still specific enough might be nice. Are there any markings on the board that might be useful in that respect?
have you tried plugging a battery into it and seeing how it acts? I'm really curious to know whether it can run off a battery and survive power being lost on the micro-usb. If so, this board would get my vote as the go-to for a touch board for GNAT

Woot, thanks!


Connection briefly reported as none when moving out of WIFI range

Environment
React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: (8) x64 Intel(R) Core(TM) i7-3840QM CPU @ 2.80GHz
Memory: 28.86 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 11.9.0 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.8.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
API Levels: 23, 26, 27, 28
Build Tools: 23.0.1, 26.0.1, 26.0.2, 27.0.3, 28.0.1, 28.0.3
System Images: android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-27 | Google APIs Intel x86 Atom, android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: ^16.8.6 => 16.8.6
react-native: 0.59.9 => 0.59.9
npmGlobalPackages:
react-native-cli: 2.0.1
Platforms
Android only
Versions

Android: Galaxy S6, Android 7.0
iOS: n/a
react-native-netinfo: 3.2.1
react-native: 0.59.9
react: 16.8.6

Description
When the phone has a valid wifi and cell connection, the plugin briefly reports as being disconnected when it loses wifi instead of simply changing to cellular without a brief and incorrect disconnected state. Testing on iOS this works as expected.
Reproducible Demo
Simply register for and log every network change update. Then turn wifi off with a valid cell signal. View the disconnected state reported for a second before being reported as connected again with a cellular signal.

:wave: Thanks for sending this over.
You are seeing those events because that's exactly what the system is reporting to us. The device does briefly loose connection in the changeover between the two states. We just pass this status on to you for you to use as you wish.
If you want to ignore this, you can add a "tailing-edge debounce" to the event listener. This will delay calling your listener for a short amount of time and only deliver the latest status, which will mask over these changes that you don't care about. There are many libraries to do this, or you can write the debounce yourself using timeouts.
This library won't be changed to include this feature as it's up to you to use the events as you need them.


Add OpenGLParametricSurface, Improve OpenGL play logic and Allow user to change OpenGL background color

Motivation

Config arguments for from_animation_number and upto_animation_number don't work with OpenGL. The OpenGL play logic doesn't support caching nor manim output format. Also, the OpenGL window background color is hard coded. Finally, ParametricSurface wasn't provided for OpenGL.
Overview / Explanation for Changes

OpenGL play logic has been improved to support caching and skipping with -n argument ( it is now similar to Cairo play logic). OpenGLParametricSurface was borrowed from 3b1b/manim repo and a random bug was fixed in OpenGLSurface. Finally, OpenGL background color can now be changed via background_color argument.
Testing Status

I tested all changes locally, and everything seems fine.
Further Comments
I think there should be a parent class for all renderers since there are a few shared functions.
Acknowledgements

[ ] I have read the Contributing Guidelines
[ ] I have chosen a descriptive PR title (see top of PR template for examples)

Reviewer Checklist

[ ] Newly added functions/classes are either private or have a docstring
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
[ ] The PR title is descriptive enough

These changes should be spit up to prevent problems with any one affecting the others. Additionally, the uv_func parameter should just be accepted by OpenGLSurface rather than making a subclass for it.

I totally agree. I reverted the OpenGLParametricSurface class and I will make a separate PR later taking your feedback into consideration. Now, this PR only improves the OpenGL play logic with a minor change to the window background color variable.

All your comments have been addressed, can you check now?

@TRoboto, there is a minor merge conflict now. Could you please resolve it? We can merge this PR then.

@TRoboto, there is a minor merge conflict now. Could you please resolve it? We can merge this PR then.

@behackl conflicts are resolved. all is good now.

@TRoboto, there is a minor merge conflict now. Could you please resolve it? We can merge this PR then.

@behackl conflicts are resolved. all is good now.

Thank you! The code looks good to me, and I've also just tested your changes locally. Skipping seems to work properly, but I am not sure about caching: rendering the example scene multiple times still renders each animation (but it is possible that the problem is with the existing scene caching code).
Could you please clarify? (It's not a problem if it doesn't work yet, this PR can and should still be merged nonetheless.)

@behackl For some reason @eulertour disabled caching for OpenGL here and here. I tried removing the two if statements and everything seems fine. Is it okay if I pushed the changes?

@behackl For some reason @eulertour disabled caching for OpenGL here and here. I tried removing the two if statements and everything seems fine. Is it okay if I pushed the changes?

I see. I've just tested removing the line for the opengl renderer, that seems to work fine. For the webgl renderer it would make sense to hear back from @eulertour -- so I'd suggest to just remove the switch for the opengl renderer, and leave scene caching disabled for the webgl renderer (for now).

@behackl For some reason @eulertour disabled caching for OpenGL here and here. I tried removing the two if statements and everything seems fine. Is it okay if I pushed the changes?

I see. I've just tested removing the line for the opengl renderer, that seems to work fine. For the webgl renderer it would make sense to hear back from @eulertour -- so I'd suggest to just remove the switch for the opengl renderer, and leave scene caching disabled for the webgl renderer (for now).

I noticed that I pointed for the WebGL version so I edited my comment to include the one for OpenGL only. Anyway, everything should be good now. Thanks for pointing this issue out.

Excellent! Thank you for the lightning-fast responses and your effort; I'll merge this PR as soon as the pipeline is done. :-)


Update documentation for chainer.backends.cuda

Chainer introduced backends subpackage. chainer/chainer#3974
Due to this change, chainer.cuda moved to chainer.backends.cuda.
I fix broken links to Chainer's to_cpu and to_gpu.

Jenkins, test this please.

LGTM!


Duplicate of (VSCode Won't Quit - Icon is Gone, Application Still Open)

The other two related issues were closed citing that a version upgrade was requested or that crash logs were requested. I am submitting both.
I also noticed that Github attempted to show me related issues around vs code and offline bugs. The vs code application was frozen with the mac spinning beach ball upon opening the laptop without a wifi connection present.

VSCode Version: 1.33.1 (1.33.1)
OS Version: Mac OS X 10.12.6
Crash report: Code Helper_2019-04-28-025827_Chriss-MacBook-Pro.log

[DUPLICATE]
Steps to Reproduce:

Open VS Code and leave open for a few days....
VS Code crashes, right-click force-quit the application
The black VS Code Window is still open on desktop, with the menu, but the icon is gone
The menu cannot be clicked into

Does this issue occur when all extensions are disabled?: Yes/No
Unsure, still trying to figure out how to shut it down so I can re-start it for the VSCode version. I also don't know how to test this again.
Related
https://github.com/Microsoft/vscode/issues/46255
https://github.com/Microsoft/vscode/issues/62674

We are building exploration builds that use a much newer version of our UI framework (Electron version 4.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux: Download
Windows: Download


How to log the full URL in NLog 4 with NLog.Web

Hello, How can I log the full URL including the querystring in NLog v4 using NLog.Web in a simple way?
If I use ${aspnet-request:serverVariable=HTTP_URL} it logs only the page without the querystring.
If the is the URL of the page http://localhost:62417/?id=512 then logs like:
${aspnet-request:serverVariable=HTTP_URL} logs /default.aspx

Hi,
What do you mean with the full URL?

http://localhost:62417/default.aspx?id=512
http://localhost:62417/default.aspx
default.aspx?id=512

Has your question being answered?

Yes, Thanks.

Thanks for the confirmation!


Need Nuget package for new 1.2 release

The last published package is from Sunday, October 9, 2016 (v1.8.0)

@EBMike What do you mean with new 1.2 release ? I think you mean to say NETStandard 1.3 ? --> See also https://github.com/rexm/Handlebars.Net/issues/175

@StefH I'm not sure what exactly you mean by Net Standard 1.3 ... all I know is the nuget package published (1.8.0) seems to be seriously out of date. Now, if what your saying is I need to use another nuget package than I would be happy to use that.

We are not using Github release tags. The latest version 1.8.0 published to NuGet in October is lacking a couple of minor bug fixes/enhancements and better compatibility with the current state of Net Standard / Net Core which will come when I have some time to fix the build.

I'd be happy to lend a hand re-build issues.  Which build is having issues?

Building a nuget package is easy : https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/src/System.Linq.Dynamic.Core/_build nuget.cmd

Hasn't the build already been fixed? (#182)

Maybe moving to the new "Microsoft.NET.Sdk" cleans up the build (#196)

Can we get the releases section updated, I was looking at the repo and it looked kinda dead, but then I looked at nuget and saw it pretty active.

Frankly I just don't always put a lot of effort into the releases section of this repo. The commit activity and the Nuget feed are the best representations of the state of the project.

Generating a new NuGet is automatically done in the new vs2017 csproj format. So can you please release a new package on nuget.org ?

Hi, can we get a new release onto nuget please, do you need some help to get this done?

I've had to fork and publish to a private feed but would like to get this repo out onto nuget if you need help

1.9.0 is now out, this can be closed

@rexm how did you make the package? The version (prefix) is 1.8.1 as is the file version of the released package; which doesn't hurt, but doesn't make much sense?

@axelheer can you clarify what you mean "the version (prefix) is 1.8.1"?

In the file Handlebars.csproj you define a versionprefix element.

Are you simply saying the master branch doesn't reflect what is in NuGet?

I just looked and the 1.9.0 dll has a version of 1.8.1 :)
On 19 May 2017 at 19:36, Rex Morgan<EMAIL_ADDRESS>wrote:

Are you simply saying the master branch doesn't reflect what is in NuGet?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rexm/Handlebars.Net/issues/190#issuecomment-302779461,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGapuza4irmqD95-ZJnh8VPviI0I9N2ks5r7eFFgaJpZM4MSxPE
.

Best is just delete this line:
https://github.com/rexm/Handlebars.Net/blob/master/source/Handlebars/Handlebars.csproj#L7

I am not sure how this happened... my local version is 1.9.0 which is what created the build & pack. Need to figure out where the 1.8.1 came from before trying to update.


multiple distinct python interpreters are found by CMake

When configuring AthenaPK on my macOS laptop, it shows that it detects the Python interpreter multiple times and finds a different interpreter each time.
The first time, it finds:
-- Found Python3: /opt/homebrew/Caskroom/miniconda/base/bin/python3.11 (found version "3.11.7") found components: Interpreter

The second time, it finds:
-- Found Python3: /opt/homebrew/Frameworks/Python.framework/Versions/3.12/bin/python3.12 (found version "3.12.2") found components: Interpreter

Does one of these come from Parthenon or Kokkos?
The full output is:
cmake .. -DCMAKE_BUILD_TYPE=Release

CMake Warning at external/parthenon/cmake/MachineCfg.cmake:61 (message):
  Not using any machine configuration.  Consider creating a configuration
  file following the examples in /cmake/machine_cfgs/ and then point the
  MACHINE_CFG cmake or environment variable to your custom file.Note, that
  the machine file can be placed in any directory (also outside the repo).
Call Stack (most recent call first):
  CMakeLists.txt:9 (include)

-- The CXX compiler identification is AppleClang <IP_ADDRESS>00100
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- clang-format --version: 17.0.6
-- Found MPI_CXX: /opt/homebrew/Cellar/open-mpi/5.0.2/lib/libmpi.dylib (found version "3.1")
-- Found MPI: TRUE (found version "3.1") found components: CXX
CMake Warning at external/parthenon/cmake/MachineCfg.cmake:61 (message):
  Not using any machine configuration.  Consider creating a configuration
  file following the examples in
  /Users/benwibking/athenapk/cmake/machine_cfgs/ and then point the
  MACHINE_CFG cmake or environment variable to your custom file.Note, that
  the machine file can be placed in any directory (also outside the repo).
Call Stack (most recent call first):
  external/parthenon/CMakeLists.txt:21 (include)

-- The C compiler identification is AppleClang <IP_ADDRESS>00100
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for C++ include filesystem
-- Looking for C++ include filesystem - found
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED - Success
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- HDF5 C compiler wrapper is unable to compile a minimal HDF5 program.
-- Found HDF5: /opt/homebrew/lib/libhdf5.dylib (found version "1.14.3") found components: C
-- Setting default Kokkos CXX standard to 17
-- The project name is: Kokkos
-- Using internal gtest for testing
-- Configured git information in /Users/benwibking/athenapk/build/generated/Kokkos_Version_Info.cpp
-- SERIAL backend is being turned on to ensure there is at least one Host space. To change this, you must enable another host execution space and configure with -DKokkos_ENABLE_SERIAL=OFF or change CMakeCache.txt
-- Using -std=c++17 for C++17 standard as feature
-- Built-in Execution Spaces:
--     Device Parallel: NoTypeDefined
--     Host Parallel: NoTypeDefined
--       Host Serial: SERIAL
--
-- Architectures:
-- Found TPLLIBDL: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include
-- Using internal desul_atomics copy
-- Kokkos Devices: SERIAL, Kokkos Backends: SERIAL
-- Using Kokkos source from Kokkos_ROOT=/Users/benwibking/athenapk/external/Kokkos
-- PAR_LOOP_LAYOUT='SIMDFOR_LOOP' (default par_for wrapper layout)
-- PAR_LOOP_INNER_LAYOUT='SIMDFOR_INNER_LOOP' (default par_for_inner wrapper layout)
-- Found Python3: /opt/homebrew/Caskroom/miniconda/base/bin/python3.11 (found version "3.11.7") found components: Interpreter
-- Found Git: /opt/homebrew/bin/git (found version "2.43.2")
-- Checking for Python modules (numpy;unyt;matplotlib;h5py;scipy) required for regression tests.
   Check can be disabled by setting PARTHENON_ENABLE_PYTHON_MODULE_CHECK=OFF but then
   tests are not guaranteed to work anymore.
-- Found Python3: /opt/homebrew/Frameworks/Python.framework/Versions/3.12/bin/python3.12 (found version "3.12.2") found components: Interpreter
CMake Error at external/parthenon/cmake/PythonModuleCheck.cmake:44 (message):
  Required python module(s) unyt;matplotlib;h5py;scipy not found.
Call Stack (most recent call first):
  external/parthenon/cmake/TestSetup.cmake:32 (python_modules_found)
  tst/regression/CMakeLists.txt:14 (include)

-- Configuring incomplete, errors occurred!

Ok, this can actually be fixed by adding -DPython3_FIND_STRATEGY=LOCATION to the CMake arguments.


Duplicated PR #139, #142 from develop to release/rocm-rel-6.0. Cherry-pick commit [abda22bfcec, ab3fb1fa, 34dc87265].

Duplicated PR #139, #142 from develop to release/rocm-rel-6.0. Cherry-pick commit [abda22bfcec, ab3fb1fa, 34dc87265].
Update for language and formatting.

We might have a few more additions to the PR. Let's hold on this until PR #146  and PR #143 are finalized.


Navigation cross remotes get 404

Describe the bug
When navigation on pages that belong to the same remote, it works properly, but when I try to navigate from one remote1 page to remote2 page, I get a 404 from remote1.
Reproduction
https://github.com/jucian0/rs-build-module-federation-2/tree/main/react-bridge
Used Package Manager
pnpm
System Info
No errors displayed, just redirected to 404

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

@zhoushaw can you validate the sample when you have a moment

Working on a solution https://github.com/jucian0/module-federation-react-bridge


BlazorWebView bridge

hi jspuij,
Thank you for this control.
Is it possible to have a bridge which transmits messages/data between Blazor and the native code of the platform?
Blazor <-> WPF
Blazor <-> Xamarin
Thank you for your help.

I would think that would not be necessary.  Because the razor class library can access the file system like normal.  They can actually write to sql server.  However, another choice can be to also use event aggregation.  That would probably be the best way.  So in the blazor, you can send a message and the wpf can pick it up and do things with it.

There indeed is no bridge necessary. You're just running a full framework. So you can immediately access the WPF and Xamarin parts. The only thing that you have to be careful about is that Blazor is running on it's own thread that is NOT the desktop UI thread. (this is because there already is so much happening on the UI thread and there is a Javascript interop boundary anyway, so it was easier to just have a dedicated thread for the Blazor rendering).
So if you want to do something on the WPF or Xamarin UI, use the WPF or Xamarin dispatcher to schedule the operation. If you want to do something on the Blazor UI, use the Blazor Dispatcher to schedule the operation.


kotlinx - UUID Serializer - String

When I'm trying to encode a data class to a string with an UUID inside I get...
Serializer for class 'UUID' is not found.
Is there a way to use the internal serializer for uuid to get the object as a string and decode the string back to it? Or any other way I can still use the UuidRepresentation

Does this unit test fill your needs ? https://github.com/Litote/kmongo/blob/master/kmongo-core-tests/src/main/kotlin/org/litote/kmongo/issues/Issue245UuidRepresentation.kt#L44

Not really. Currently I use MongoDB as my main database to store user data. I need to retrieve the data very often and on multiple servers, so I thought I just use a cache like redis since it is much faster.
In redis you can just insert strings or byte data, so I need to be able to encode and decode the data class to/from a string.
I found this but I found no way to decode the string back to the data class object

This is more a serialization issue then.
You can use CodecRegistry:

val registry = KMongoClient.createClient().getDatabase("test").codecRegistry
val codec = registry.getCodec(MyClass::class.java)
val myClass  = codec.decode(BsonDocument.parse(json), DecoderContext.builder().build())

HTH


Update getter.js

Changed the getter to a Getter

I am surprised how I let it go unnoticed for so long. Merged.


DRTV not working

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

[~] # youtube-dl --version
2021.12.17
[~] # youtube-dl --verbose https://www.dr.dk/drtv/episode/hitlers-danske-soldater_208769
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://www.dr.dk/drtv/episode/hitlers-danske-soldater_208769']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 2.7.13 (CPython) - Linux-5.10.60-qnap-x86_64-with-glibc2.2.5
[debug] exe versions: ffmpeg 3.3.6, ffprobe 3.4.2-static
[debug] Proxy map: {}
[drtv] hitlers-danske-soldater_208769: Downloading webpage
[drtv]<PHONE_NUMBER>0: Downloading video JSON
[drtv]<PHONE_NUMBER>0: Downloading m3u8 information
[drtv]<PHONE_NUMBER>0: Downloading m3u8 information
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on u'https://drod05t-vh.akamaihd.net/p/all/token/download/3d/5fe9c10eaa5a612714959f3d/Hitlers-danske-soldate_d196482fdd2b432da4deb5862dd037bc_4300.mp4'
ERROR: unable to download video data: HTTP Error 403: Forbidden
Traceback (most recent call last):
  File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1976, in process_info
    success = dl(filename, info_dict)
  File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1915, in dl
    return fd.download(name, info)
  File "/usr/bin/youtube-dl/youtube_dl/downloader/common.py", line 366, in download
    return self.real_download(filename, info_dict)
  File "/usr/bin/youtube-dl/youtube_dl/downloader/http.py", line 351, in real_download
    establish_connection()
  File "/usr/bin/youtube-dl/youtube_dl/downloader/http.py", line 116, in establish_connection
    raise err
HTTPError: HTTP Error 403: Forbidden

Description

WRITE DESCRIPTION HERE
Has been working excellent for DRTV untill now.  Hope that it is a simple issue to solve.

The page offers formats like Download-n, which give the above result for me, and also HLS-n, which can be downloaded successfully (also -SpokenSubtitles- versions of both).
Possibly DRTV wants you to have logged in for the first type: more research needed from DRTV users.
You can select only HLS formats using -f '(bestvideo+bestaudio/best)[format_id^=?HLS]', although for this page only combined formats are offered so -f 'best[format_id^=HLS]' would do. (Windows: '' -> "")

I am confirming this bug.  This site - dr.dk - does not require login.  However, some videos cannot be downloaded.
ERROR: Unsupported URL: https://www.dr.dk/drtv/saeson/pigerne-fra-berlin_258101
Commend line used to reproduce error:
youtube-dl --verbose -f 'best[format_id^=HLS]' https://www.dr.dk/drtv/saeson/pigerne-fra-berlin_258101
Would appreciate any help.

That URL format isn't known to the extractor, though. You're asking for the series page (saeson) instead of the show page(se), although the series page also contains a player for the active episode (S1E1 when I looked). Either https://www.dr.dk/drtv/se/pigerne-fra-berlin_258107 or https://www.dr.dk/drtv/episode/pigerne-fra-berlin_258107 are valid URLs for S1E1. But those Berlin gals are only for Denmark (and Greenland).
The extractor could be extended to get a playlist from the series page, or the active video if --no-playlist is given.
For OP's page, possibly DRTV is geo-restricting the full downloads but not the adaptive streaming media? That would explain why I see the same from UK.

@dirkf Thank you for the quick response.  I am not so familiar with how youtube-dl works technically so I am not sure what you are saying exactly.
Does it mean that youtube-dl will never be able to download this show (and many others from dr.dk since this was just one example), or did I do anything wrong?
Thanks for your help.

As long as you're in the DRTV area, just use the individual episode (/episode/) or player (/se/) pages, as in the examples I quoted for S1E1. There are only 9 for Pigerne.
Eventually I may be able to roll out my modified DRTV extractor that understands /saeson/ pages.

I have looked a little into this using  Fiddler & Chrome:
The main url
https://www.dr.dk/drtv/episode/hitlers-danske-soldater_208769 ==> causes an getting an url to a master playlist
https://drod05t-vh.akamaihd.net/i/all/clear/download/3d/5fe9c10eaa5a612714959f3d/Hitlers-danske-soldate_d196482fdd2b432da4deb5862dd037bc_,300,512,1000,2200,3000,4300,.mp4.csmil/master.m3u8?cc1=name=Fremmedsprogstekster~default=yes~forced=no~lang=da~uri=https://drod05t-vh.akamaihd.net/p/allx/clear/download/3d/5fe9c10eaa5a612714959f3d/subtitles/Foreign-17913845-20c1094f-1cdb-4f61-8208-155e9c768888/playlist.m3u8&cc2=name=Dansk~default=no~forced=no~lang=da~uri=https://drod05t-vh.akamaihd.net/p/allx/clear/download/3d/5fe9c10eaa5a612714959f3d/subtitles/Foreign_HardOfHearing-17913845-20c1094f-1cdb-4f61-8208-155e9c768888/playlist.m3u8
==> download of a master.m3u8 playlist
This url can be truncated and still download the master.m3u8:
https://drod05t-vh.akamaihd.net/i/all/clear/download/3d/5fe9c10eaa5a612714959f3d/Hitlers-danske-soldate_d196482fdd2b432da4deb5862dd037bc_,300,512,1000,2200,3000,4300,.mp4.csmil/master.m3u8
and can be truncated even further:
https://drod05t-vh.akamaihd.net/i/all/clear/download/3d/5fe9c10eaa5a612714959f3d/Hitlers-danske-soldate_d196482fdd2b432da4deb5862dd037bc_4300.mp4.csmil/master.m3u8
master.m3u8 appear to be a list of bandwidth dependant url's to different index_X_av.m3u8 playlists which can be played in vlc player
In conclusion i guess the ".csmil/master.m3u8" should be appended to the download url and the resulting master.m3u8 used for the download of the .ts files.
Hope this helps in resolving the issue
Nils

Your issue was that download URLs like this, whose id is Download-4300,
https://drod05t-vh.akamaihd.net/p/all/token/download/3d/5fe9c10eaa5a612714959f3d/Hitlers-danske-soldate_d196482fdd2b432da4deb5862dd037bc_4300.mp4

gave 403.
The M3U8 playlists can be extracted OK and give the HLS streams, which can be downloaded.

The Download-... formats give me 403 all the time. If that also happens in-region, we must be missing some additional header, cookie, or similar that's required to use them.
If these formats never work, we should strip them out.
If they sometimes work, we can check them when extracting, but it adds some time to each extraction.

It seems to be able to download from dr.dk now, but it only downloads partial episodes in some cases:
https://www.dr.dk/drtv/episode/dolph-and-wulff_150435 (20 sec long clip and not the full length episode)


Updated UserCredentials Dialog to deal with QuickControls2

With the turning on of High-DPI mode, the user credentials dialog showed heavily inflated text.
This change has removed the scale-factor calculations, and upgraded the dialog to QuickControls 2.
References to explicit widths/heights have been removed in favour of resizing to contents.

Looks good on Android and Mac. Happy to test on iOS/Windows!

Looks good on Android and Mac. Happy to test on iOS/Windows!

@anmacdonald yes, please if you have time.

Hi @JamesMBallard, I think these are acceptable!
Android

iOS

MacOS

Windows

I think it would be worth putting a newline in before the URL so that (at least in the general arcgis.com case it is not split over 2 lines). So something like:
You need to sign in to access the
resource at:
'https://www.arcgis.com'

Also, any reason that we ha v e the URL in single quotes?
@ldanzinger, @JamesMBallard - any thoughts?

Testing is good. Code changes look good but it would be good to see if we can prevent the url from wrapping across lines as @lsmallwood mentioned. If that gets too hairy we can put that into a new issue to work on.

If there is a consensus then shall add. Will add as a new Text { } to the layout rows. I don't trust newline characters in QML rendering based on how I've seen the callouts behave.

New look authentication view:


Question: transfer repo to tree-sitter-grammars org

Hi @MunifTanjim!
Thanks for all your work on this parser; it's rock solid and part of Neovim core now (even enabled by default on master). But big changes are coming to the tree-sitter ecosystem (including upstream version support, publishing parsers as artefacts, new ABI for scanners), and as part of it and to help grammars deal with it, we have created a https://github.com/tree-sitter-grammars org for parsers to live under and get a consistent set of workflows and updates.
So my question: would you be interested in transferring your parser to the org? You'd retain write (but not admin) access to it, but you'd have more people able to help out with (routine) maintenance and get a shiny set of workflows. As one of the independent flagship parsers, it would be great to have you on board ;)

So my question: would you be interested in transferring your parser to the org? You'd retain write (but not admin) access to it, but you'd have more people able to help out with (routine) maintenance and get a shiny set of workflows. As one of the independent flagship parsers, it would be great to have you on board ;)

Yep, of course. Sounds good.

Easiest is to add me as an owner to this repo, or transfer it to my personal account (I can then transfer to the org.)

(I really need owner privileges to access the settings and initiate the transfer. Maybe transferring the repo to my account is easier?)

What about now?

That worked, transfer complete! Thank you, and welcome to the family ;)


Modify data coordinator to allow passing in the whole secondary config.

NOTE: Don't merge, just let me know if it looks good.  Need to coordinate
with marathon config changes.
Related: https://github.com/socrata/apps-marathon/pull/23

data-coordinator #258 SUCCESS
This pull request looks good

LGTM.


Hide sidenav links if section will also be hidden

If the user won't see Recent Cohorts on their dashboard, hide the Recent Cohorts link in the sidenav.
If they won't see Recent Scenarios, hide the Recent Scenarios link
If both sections will be hidden (meaning the user is a participant who isn't a part of any cohorts), hide the whole "Your Tools" section of the sidenav

https://app.asana.com/0/1199528021095056/1202331221957780

Needs conflict resolve before it can be merged


Add 3D view

Several options:

procedural-gl.js
Cesium
Mapbox GL
d3-geo https://github.com/kjellmf/d3-milmap-playground

I've done some experiments with procedural-gl.js. It works, but it has some rough edges and missing functionality. Cesium is used by map.army and has a nice integration library with openlayers (https://github.com/openlayers/ol-cesium).
Looks like Mapbox GL requires a mapbox account and is no longer open source. Maybe maplibre will get a 3D mode some day? (https://github.com/maplibre/maplibre-gl-js/issues/307)

ORBAT-mapper now supports KML-export for use with Google Earth. Works quite well.


Removed scope wide @trusted use in std.typecons

@klickverbot thanks a lot for opening the issue about this!
AFAICT the idea behind this is/was to remove all @trusted scopes, s.t. DScanner will prevent new ones from being added.
Of course, this doesn't change the numerous @trusted holes in Phobos, but makes it easier to follow-up on this and remove @trusted on a per-function basis.


move fatalErrorHandler to userspace

this should not be in the framework space. It has to be moved to separate the framework as a package.

done PR #406


CSS Exercises

Because

This PR

Issue

Closes #XXXXX
Additional Information

Pull Request Requirements

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check
[x] The Because section summarizes the reason for this PR
[x] The This PR section has a bullet point list describing the changes in this PR
[x] If this PR addresses an open issue, it is linked in the Issue section
[x] If applicable, I have ensured that the TOP solution files match the Desired Outcome image

Just a reminder to not submit PRs to this repo with your own solutions. You can of course clone your fork and push your commits there, just don't open a PR from your fork to this repo.


Cannot disable entity's MenuView

I need to disable MenuView for some entity.
This is the only solution I found, but it doesnt work.
My ng-adimin version is installed via bower using "master" as version.
I've looked at the sources, and it seems to me that this line is the reason of my problem. It looks like you erroneously used disjunction instead on conjunction in this line. But maybe there was a worthy reason to use disjunction there?
Please, take a look at this problem -  it shouln't take too much time to fix it, imho.

Looking at the referenced line, I guess you still have an enabled list view. What is your use case for not displaying the menu item in this case?
The logic behind this OR operator is to always display the menu if the list view is enabled. Otherwise, how would you reach it? But I wonder if the enabled method of MenuView makes sense in this case.

Yes, I still have enabled list view. My case is that I want to reference this entity (let's say images) from other entity (let's say posts) and view it via "referenced_list" type of field. One posts may have many images. The only action I need for this images is delete (you can either upload or delete image, no other actions involved). So I don't need no other view than ListView (where I define the only "delete" action) for this entity. And I don't want to see it in menu because it may be confusing for end user.
Anyways, if you think that ListView should be the only thing that defines visibility of entity in meenu, so why would you need MenuView._enabled property and MenuView.disable() method then?

Normally, you don't need an enabled list view to use a referenced_list. Can you try to disable your image list view and check if it works?
I agree with you about the MenuView._enabled property. We got an inconsistency here. I would suggest to remove the enabled property of the menu view to use only the listView.enabled property. @fzaninotto, what do you think about it?

Oh, sorry, I've misunderstood that. You're absolutely right. listView doesn't have any relation to the referenced_list view, so I can just disable it and it solves my problem.
But I see nothing wrong in changing disjunction to conjunction here.
The only case you should avoid is to leave broken menu link for end user (when menuView is enabled and listView is disabled) - and your current code still makes this case possible. While in my situation (where I can have working listView with no entry in menu for it) end user unlikely will notice it.
It seems to be more logical for me to just replace disjunction with conjunction, than break generic View properties and methods for listView.

By the way, can you tell me how can I add "Delete" button to the the each entry of refernced_list view? Why does field of type refernced_list have no .listActions() mehod?
I've tried to add field of template type to the referencing entity, and paste <ma-delete-button entry="::entry" entity="::entity" size="xs"></ma-delete-button> directive as template, but it doesn't work because entity is not visible in field's scope.

The proposed fix for the menu has just been merged. Closing.

#23 has been reverted. The right solution for your problem is to use the new Menu configuration. MenuView is deprecated and will be removed soon.


fix(test): replay SET statements after recovery

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR fixes the session context loss problem in recovery test.
It will record all SET statements and replay them on reconnection.
resolve #8285
Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[x] My PR DOES NOT contain user-facing changes.

The recovery test was timeout due to hang by a slow query after recovery, the execution seems to be blocked in frontend?
2022-09-12T12:42:49.817072Z  WARN node{id=7 name="frontend-1"}:task{id=499613}: risingwave_frontend::session: slow query has been running for another 60s sql_str="SELECT 1 UNION SELECT 1"
2022-09-12T12:42:54.250396Z  INFO node{id=8 name="frontend-2"}:task{id=524286}: risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch<PHONE_NUMBER>170368 with RPC
2022-09-12T12:43:04.127906Z  INFO node{id=7 name="frontend-1"}:task{id=524916}: risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch<PHONE_NUMBER>066368 with RPC
2022-09-12T12:43:04.250396Z  INFO node{id=8 name="frontend-2"}:task{id=524943}: risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch<PHONE_NUMBER>066368 with RPC
2022-09-12T12:43:14.250396Z  INFO node{id=8 name="frontend-2"}:task{id=525593}: risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch<PHONE_NUMBER>962368 with RPC
2022-09-12T12:43:24.127906Z  INFO node{id=7 name="frontend-1"}:task{id=526229}: risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch<PHONE_NUMBER>858368 with RPC
2022-09-12T12:43:24.250396Z  INFO node{id=8 name="frontend-2"}:task{id=526258}: risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch<PHONE_NUMBER>858368 with RPC
2022-09-12T12:43:34.127906Z  INFO node{id=7 name="frontend-1"}:task{id=526888}: risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch<PHONE_NUMBER>754368 with RPC
2022-09-12T12:43:44.250396Z  INFO node{id=8 name="frontend-2"}:task{id=527557}: risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch<PHONE_NUMBER>650368 with RPC
2022-09-12T12:43:49.817072Z  WARN node{id=7 name="frontend-1"}:task{id=499613}: risingwave_frontend::session: slow query has been running for another 60s sql_str="SELECT 1 UNION SELECT 1"

The recovery test was timeout and the scaling test failed 🥵 . Cc  @BugenZhao

Will investigate it tomorrow. 🥵

The recovery test was timeout

As SET VISIBILITY_MODE TO checkpoint;  has been removed in this PR, Cannot read when cluster is under recovery error is expected behavior, and is fine as long as the batch query eventually succeeds before reaching the max retry in the test.

Cannot read when cluster is under recovery error is expected behavior

There's no recovery in scaling test but this error still happens. 🤔

I think we can also remove session_timezone.slt from KILL_IGNORE_FILES now.

Cannot read when cluster is under recovery error is expected behavior

There's no recovery in scaling test but this error still happens. 🤔

Despite the poor/inaccurate message, it reflects the fact that when a compute node is with no actor, barrier won't be sent to it and consequently hummock's seal epoch never increase. But I expect the batch query shouldn't visit that compute node either. I'll confirm tomorrow.


Twistor\FlysystemStreamWrapper::stream_stat() sets size to 0 for at least some remote files, can result in empty files being written

I encountered this issue with https://github.com/thephpleague/flysystem-azure-blob-storage/issues/22 but I believe it could occur for other remote filesystems.
When I attempt copy with a remote file backed by flysystem-azure-blob-storage as the source it always writes 0 byte files at the destination. The culprit seems to be Twistor\FlysystemStreamWrapper::stream_stat() which sets the size of the returned $stat array to zero. This is because it calls Twistor\StreamUtil::getSize() which uses https://www.php.net/manual/en/function.fstat.php. There's a note on the documentation page:

Note: This function will not work on remote files as the file to be examined must be accessible via the server's filesystem.

I'm guessing that's why, though it fails in a much less obvious way than I'd expect from the note.
I'll attach a pull request shortly with a crude fix which ignores the fstat() filesize if it is zero and just uses the original file size from url_stat. I'm not sure if this is the best solution but it seems to work for me.

I faced similar issue, what i did was just to put default stat
        // Use the size of our handle, since it could have been written to or
        // truncated.
        $stream_util_size = StreamUtil::getSize($this->handle);
        if (!empty($stream_util_size)) {
            // Only set size if stream_util_size is available or
            // just send original file metadata.
            $stat['size'] = $stat[7] = $stream_util_size;
        }


Confusing type inference

Dart version: 2.8.4
OS: Linux
I've noticed that the dart analyzer is inferring incorrect argument types in closure scope when inferring from named arguments. I'm using VS Code but I also
tested on Android Studio and the problem still happens.

cc @jwren @bwilkerson

@scheglov Is this a bug in type inference, a bug in the way server is displaying information, or the correct behavior?

https://github.com/dart-lang/language/issues/731 describes the issue about not transferring information between arguments during type inference.

Yeah, sorry, the style of inference we use doesn't do a good job of moving information between arguments.  There are some heuristics I'd like to implement which would improve examples like this a lot, but it's a breaking change so we need to pick the right time to roll them out.  Closing in favor of the existing tracking issue.


Stack overflow when hot reloading reducer in RN

Hi,
I'm using Redux with React Native and HMR. When I change a reducer, the accept bubbles up to my configureStore.js file which calls this:
if (module.hot) {
    module.hot.accept(() => {
        const nextRootReducer = require('../reducers/index').default;
        store.replaceReducer(nextRootReducer);
     });
}

But then HMR keeps on searching in a loop until the stack overflow.
Could it be that there's a circular reference somewhere? If so, any tips for tracking it down? I've tried stepping through the require.js code but the 'references' are kept just as numbers making it hard to track down the right file.

This is an issue with Webpack, not with Redux. I’m afraid there is no way we can help you in this repository because we don’t have the experience with Webpack internals. Maybe updating Webpack version could help but I can’t guarantee it.
I’m closing because this is not actionable for us here.

Sorry, I just realized you said “RN” and not “Webpack”.
In this case please file this issue with React Native.


iso squashfs unpack.

From scratch
some url .... rootfs.squashfile  /
(at tar.gz , tar.xz , etc unpacks)  however no dice on squashfiles, on dockerhub;  for the moment requires conversion.
then dropbox or etc, then dockerhub.
unsquashfs -f -d *.squashfs | tar -cvpJf backup.tar.xz --exclude=~/rootfs.tar.xz --one-file-system ~/
Not sure it'd work but point made.  normally I dump to/tmp/isoname/  and repack ,
unpack a squashfile to / insted of the bother of converting.
however I'll suffer the conversion .. for now...   drop to dropbox /dockerhub  , just would be a plus
Option for Squashfs files to be treated like tarballs would be a plus.
other future state possible ?
From ISOFILE
ISOURL=""
squashfs="my.squashfile  @ > /
Unpack squashfs from iso to root discard rest.
also might be a plus. for rebaking iso's .. custom respins etc.

Is this a question? feature request? issue report?

it would be a plus to use a squashfs file as a supported  archive , it would be a future  feature enhancement request.
just was noting I tested on dockerhub , still have to convert to standard tar.xz , gz etc ...

Really 👎 Adding adding support for another compression format. Supporting xz is already really bad since we have to exec out to do it.

I have to agree with @cpuguy83 here; we can't support every compression format that exists
I'll go ahead and close this issue, but feel free to discuss


change: Replace u64 for usize for lenght vars

As @s1fr0 correctly stated in https://github.com/vacp2p/zerokit/issues/39#issuecomment-1235441945, usize is the rust canonnical way to express lengths for data serialization.
Resolves: #39
Please, let me know if I missed any serialization fn or similar where the same change logic should be applied!

It's true @s1fr0 .
The only changes that can cause an issue are the ones in rln/src/protocol.rs.
The rest is just test modules. Is there any way to run integration tests through the C API so that we can see whether this causes incompatibilities with the previous API version? As I think going from u64 to usize should not cause issues if we pass a &[u8] as we just take the bytes needed and ignore the ones of the u64 that have 0's in it.

Currently nwaku uses a fixed rev of zerokit, we can include this change

Hey @CPerezz would you mind rebasing this PR upon master, if not, no worries, I can do it :)

@rymnc It's weird as a gigantic amount of testing code just disappeared in master.
In any case, I removed it as well here.
Review it JIC! :sweat_smile:


"ERROR Unresolved reference" using cpo-console

Running into problems when going through https://github.com/Fraunhofer-AISEC/cpg/blob/main/tutorial.md
Preparation:

fresh checkout
run configure_frontends.sh (Java, C/C++, Go enabled)
compiled via ./gradlew :cpg-console:installDist (run into https://github.com/Fraunhofer-AISEC/cpg/issues/1272 but was able to fix it according to the given instructions)
started via cpo-console via cpg-console/build/install/cpg-console/bin/cpg-console

Specs:

used kotlin compiler 1.9.0 and 1.7.10 => no difference
sdk 17

Tutorial:
[1] :tr src/test/resources
=> basically runs through, but shows 3 errors:
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - JavaExternalTypeHierarchyResolver: Executing Pass
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.passes.Pass - Source file root used for type solver: /Users/matthiasstumpp/Workspace/Repositories/secguro/cpg/cpg-console/src/test/resources
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - JavaExternalTypeHierarchyResolver: Executing Pass done in 30 ms
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - ImportResolver: Executing Pass
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - ImportResolver: Executing Pass done in 1 ms
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - SymbolResolver: Executing Pass
[ForkJoinPool.commonPool-worker-1] ERROR de.fraunhofer.aisec.cpg.passes.inference.Inference - /Users/matthiasstumpp/Workspace/Repositories/secguro/cpg/cpg-console/src/test/resources/nullptr.cpp:3:5: Trying to infer a record declaration of a non-object type. Not sure what to do? Should we change the type?
[ForkJoinPool.commonPool-worker-1] ERROR de.fraunhofer.aisec.cpg.passes.inference.Inference - /Users/matthiasstumpp/Workspace/Repositories/secguro/cpg/cpg-console/src/test/resources/nullptr.cpp:7:5: Trying to infer a record declaration of a non-object type. Not sure what to do? Should we change the type?
[ForkJoinPool.commonPool-worker-1] ERROR de.fraunhofer.aisec.cpg.ScopeManager - /Users/matthiasstumpp/Workspace/Repositories/secguro/cpg/cpg-console/src/test/resources/Array.java:23:9: Could not find the scope AnotherObject needed to resolve the call AnotherObject.doSomething
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - SymbolResolver: Executing Pass done in 17 ms
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - DFGPass: Executing Pass
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - DFGPass: Executing Pass done in 3 ms
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - DynamicInvokeResolver: Executing Pass
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - DynamicInvokeResolver: Executing Pass done in 1 ms
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - ControlFlowSensitiveDFGPass: Executing Pass
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - ControlFlowSensitiveDFGPass: Executing Pass done in 7 ms
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - FilenameMapper: Executing Pass
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - FilenameMapper: Executing Pass done in 0 ms
[ForkJoinPool.commonPool-worker-1] INFO de.fraunhofer.aisec.cpg.helpers.MeasurementHolder - TranslationManager: Translation into full graph done in 259 ms

Hint :tr src/test/resources/array.go
=> no errors
[2] :ls
val config: de.fraunhofer.aisec.cpg.TranslationConfiguration
val analyzer: de.fraunhofer.aisec.cpg.TranslationManager
val result: de.fraunhofer.aisec.cpg.TranslationResult!
val tu: de.fraunhofer.aisec.cpg.graph.declarations.TranslationUnitDeclaration

=> ok
[3] result.all()
ERROR Unresolved reference. None of the following candidates is applicable because of receiver type mismatch:
public inline fun <T> Array<out TypeVariable(T)>.all(predicate: (TypeVariable(T)) -> Boolean): Boolean defined in kotlin.collections
public inline fun BooleanArray.all(predicate: (Boolean) -> Boolean): Boolean defined in kotlin.collections
public inline fun ByteArray.all(predicate: (Byte) -> Boolean): Boolean defined in kotlin.collections
public inline fun CharArray.all(predicate: (Char) -> Boolean): Boolean defined in kotlin.collections
public inline fun CharSequence.all(predicate: (Char) -> Boolean): Boolean defined in kotlin.text
public inline fun DoubleArray.all(predicate: (Double) -> Boolean): Boolean defined in kotlin.collections
public inline fun FloatArray.all(predicate: (Float) -> Boolean): Boolean defined in kotlin.collections
public inline fun IntArray.all(predicate: (Int) -> Boolean): Boolean defined in kotlin.collections
public inline fun LongArray.all(predicate: (Long) -> Boolean): Boolean defined in kotlin.collections
public inline fun ShortArray.all(predicate: (Short) -> Boolean): Boolean defined in kotlin.collections
public inline fun UByteArray.all(predicate: (UByte) -> Boolean): Boolean defined in kotlin.collections
public inline fun UIntArray.all(predicate: (UInt) -> Boolean): Boolean defined in kotlin.collections
public inline fun ULongArray.all(predicate: (ULong) -> Boolean): Boolean defined in kotlin.collections
public inline fun UShortArray.all(predicate: (UShort) -> Boolean): Boolean defined in kotlin.collections
public inline fun <T> Iterable<TypeVariable(T)>.all(predicate: (TypeVariable(T)) -> Boolean): Boolean defined in kotlin.collections
public inline fun <K, V> Map<out TypeVariable(K), TypeVariable(V)>.all(predicate: (Map.Entry<TypeVariable(K), TypeVariable(V)>) -> Boolean): Boolean defined in kotlin.collections
public inline fun <T> Sequence<TypeVariable(T)>.all(predicate: (TypeVariable(T)) -> Boolean): Boolean defined in kotlin.sequences (Line_79.kts:1:8)

=> something wrong here
Any help appreciated

all() is not a valid part of our shortcut API, but rather a Kotlin builtin filtering function. You can use result.functions to for example retrieve all functions. That should work.

Starting from https://github.com/Fraunhofer-AISEC/cpg/pull/1448 you can also use result.nodes to retrieve all nodes.


Cookiecutter

Originating Project/Creator

Affected Component
fprime-util new

Affected Architectures(s)

Related Issue(s)

Has Unit Tests (y/n)

Builds Without Errors (y/n)

Unit Tests Pass (y/n)

Documentation Included (y/n)

Change Description
Allows the user the option to set the cookiecutter template. By default, a local template is used.
Rationale
This gives the users flexibility in using a cookiecutter of their choice
Testing/Review Recommendations
To test this feature, you can run:
fprime-util new

with a settings.ini file and without a settings.ini file.
Future Work
In the future, the local cookiecutter will be refined and improved to work better with the recent changes to F'.

@aidan-wagner can you clean up the new lgtm warnings?

@aidan-wagner, you should run the formatter:
pip install black
cd fprime-tools
black .
git add/commit

It looks like the F' and Cookiecutter are fighting.
If I remember correctly, we decided that component filenames should be MyExample.cpp. The problem is that the autocoder generates includes that expect the old naming style (MyExampleComponentImpl.hpp). Because we want to support a wide variety of versions of F', we can't just fix this in the F' framework autocoder. The best solution I can think of is slightly ugly... detect if there's any incorrect filenames in the include path and re-write them. I.E. replace #include <Ref/MyExample/MyExampleComponentImpl.hpp> with  #include <Ref/MyExample/MyExample.hpp>
The alternative would be to revert to the old naming convention of  MyExampleComponentImpl
[ 96%] Building CXX object Ref/MyExample/CMakeFiles/Ref_MyExample.dir/MyExample.cpp.o
/Users/joshuaa/p/fprime-oss/Ref/MyExample/MyExample.cpp:7:10: fatal error: 'Ref/MyExample/MyExampleComponentImpl.hpp' file not found
#include <Ref/MyExample/MyExampleComponentImpl.hpp>

@LeStarch I ran black . before I pushed the code, and when running it again, it doesn't change the code. Is there another way to fix this line? Or are the format rules somewhere so I could fix it by hand?

@Joshua-Anderson Yeah, this is something that @LeStarch and I realized. I thought I remembered him saying that we would make this change in fprime itself, but if not then I can make a change to the cookiecutter

@aidan-wagner Are you running a newer version of black than CI? We may need to update our black formatter version in CI

...yes we should fix this in F´.  Is this fix a blocker for this code?

@LeStarch Are we okay with fprime-util new not working with older versions of F' (like 2.0)? It seems like it's easy enough (if a it bit ugly) to support backwards compatibility for now.

@Joshua-Anderson @aidan-wagner I'd phrase it this way: it isn't worth losing backward compatibility over this.   I think this should be a fairly straight-forward fix, yes?

open file and read bytes
bytes.replace("ComponentImpl.hpp" ".hpp")
write bytes out.

Thoughts?

Yeah, that would be my recommendation too. A find and replace is a bit ugly but I think backwards compatibility is worth it. We should definitely fix it in the autocoder though.

@Joshua-Anderson @LeStarch Ok, that makes sense. I can add that in. For the formatting, I tried installing with the same command( so the same version) that the format check on github uses and still no luck.

It looks like there's still a comment that redirect to sterling's cookiecutter template. I think we can remove the link to documentation for now.

[INFO] Cookiecutter source: /Users/joshuaa/p/fprime-tools/src/fprime/fbuild/../cookiecutter_templates/cookiecutter-fprime-component
This doesn't seem super user friendly. What if we say Cookiecutter source: using builtin if the user doesn't override the cookiecutter source?

Add component MyExample to /Users/joshuaa/p/fprime-oss/Ref/CMakeLists.txt at end of file??Are the double ? marks a typo?

Add component MyExample to /Users/joshuaa/p/fprime-oss/Ref/CMakeLists.txt at end of file? we don't actually add the component to the end of the file. Maybe we should just ask Add component MyExample to /Users/joshuaa/p/fprime-oss/Ref/CMakeLists.txt?

🎉


check create corner case

Describe the feature you would like

init code empty (done for test_create_empty_init_code in create gadget tests)
init code itself not empty, but return empty , no code store eventually.
in init code call other contract (successful and error cases)

Additional context
No response

done


Proguard Enabled - Google Speech-to-Text API stopped working

Hi,
Google Speech-to-Text API stopped working when progurard is enabled in Android app.
release {
minifyEnabled true
shrinkResources true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
I am using Speech-to-Text Client Libraries. App's Gradle file dependencies are below;
// Dependencies for the speech client
implementation 'io.grpc:grpc-okhttp:1.27.0'
implementation 'com.google.cloud:google-cloud-speech:1.22.3'

Ran into the same problem.
For
implementation io.grpc:grpc-okhttp:1.32.1
implementation com.google.cloud:google-cloud-speech:1.24.0

The following configuration works:
-keep class com.google.api.** { *; }
-keep class io.grpc.** { *; }
-keep class com.google.rpc.** { *; }
-keep class com.google.auth.oauth2.** { *; }
-keep class com.google.protobuf.** { *; }
-keep class com.google.cloud.speech.** { *; }

It would be awesome if the samples would include the most optimal Proguard configuration.

Another issue wi proguard is with Text-to-speech library. Issue was due to Java Gax which is used to get library version. Done in Speech and TextToSpeech as well. It uses package information but since proguard strips the package it will return null and gax will not be able to figure out library version.
Call site gets package (will be null) and it calls getImplementationVersion on it which results in NPE:
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Package.getImplementationVersion()' on a null object reference
	at com.google.api.gax.core.GaxProperties.getLibraryVersion(SourceFile:1)
	at m27.invoke(SourceFile:10)

Adding this line to proguard configuration solves the issue:
-keep public class com.google.cloud.texttospeech.v1.stub.TextToSpeechStubSettings {public *; protected *;}

Or you can just keep the whole text to speach package to be sure.
-keep class com.google.cloud.texttospeech.** { *; }

First option solves Gax issue and second keeps it not obfuscated as a whole which makes them both not optimal solutions since there might be more issues than just the one with Gax and it is also not optimal to keep the whole package un-obfuscated.
Bottom line is: as @dejandobnikar said it would be awesome if each library would contain optimal Proguard configuration.


Additional unit tests + EventQueue simplification

Adds tests for:

Key provider
Event queue
Event factory

Simplifies the EventQueue code

Codecov Report

Merging #255 into e2e will increase coverage by 0.07%.
The diff coverage is 99.71%.

@@            Coverage Diff             @@
##              e2e     #255      +/-   ##
==========================================
+ Coverage   88.65%   88.73%   +0.07%
==========================================
  Files          36       39       +3
  Lines        2988     3150     +162
==========================================
+ Hits         2649     2795     +146
- Misses        339      355      +16

Impacted Files
Coverage Δ

Sources/PusherConnection.swift
72.58% <0.00%> (-4.17%)
:arrow_down:

...wift-Only/PusherEventFactory+DecryptionTests.swift
100.00% <ø> (ø)

Sources/PusherEventQueue.swift
100.00% <100.00%> (+3.70%)
:arrow_up:

Sources/PusherWebsocketDelegate.swift
35.29% <100.00%> (ø)

Tests/PusherEventFactoryTests.swift
100.00% <100.00%> (ø)

Tests/PusherEventQueueTests.swift
100.00% <100.00%> (ø)

Tests/PusherKeyProviderTests.swift
100.00% <100.00%> (ø)

...rSwift-Only/PusherEventQueue+DecryptionTests.swift
100.00% <100.00%> (ø)

...tion-Only/PusherEventFactory+DecryptionTests.swift
100.00% <100.00%> (ø)

...yption-Only/PusherEventQueue+DecryptionTests.swift
100.00% <100.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31506e8...787aeea. Read the comment docs.


XE4 - E2506 Method of parameterized type declared in interface section must not use local symbol 'TThreadHelper'

Thanks for developing this event bus library, it looks very useful while being lightweight.
I'm trying to compile the tests with XE4, and got the following error, any idea as to how to solve it? Thanks.
[dcc32 Error] NX.Horizon.pas(484): E2506 Method of parameterized type declared in interface section must not use local symbol 'TThreadHelper'

Fixed. TThreadHelper must be declared in interface section.

Thanks! Compiled and passed all tests.


Fix/ogmios dockerfile

Context
#924 is a long story PR.
Proposed Solution
Some minor fixes.

Superseded by https://github.com/input-output-hk/cardano-js-sdk/pull/935


packchk : remove WARNING M379 ?

With our current pdsc file describing B-U585I-IOT02A board, we got a M379 warning:
*** WARNING M379: xxx/STMicroelectronics.board_resources_B-U585I-IOT02A.pdsc (Line 52)
No example(s) found for Board '[STMicroelectronics] B-U585I-IOT02A'.
We don't plan to provide an example list for each board pdsc.
So proposition is to remove this warning in packchk and in
https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/main/html/packChk.html
@fred-r

Hi @jeromecoutant, @LMESTM, @fred-r,
I think this warning can be discussed. Board specifications are typically provided as part of Board Support Packages (BSPs). And a BSP is expected to ship at least one example per board to give the user some sort of starting point.
You can supress this warning if required but I'd leave it in the tool.
Cheers,
Jonatan

@JonatanAntoni  how would we supress the warning ?
We may want to decouple the projects deliveries from the board description part. Providing a single example might actually be a disappointment to the user who wants to get access to the full list of examples that can run on this board, better to be able to provide pointers to available examples maybe rather than one actual project (and for which IDE anyway should the project be delivered ? and which IDE version ?)

 -x Mxxx              : Suppress Messages

@JonatanAntoni  thanks for the command.
I still think this should be left optional to the provider of the BSP pack to deliver a project or not.
I guess that we can live with the -x option. @jeromecoutant  ?

Does this option solve the ticket? Or do we need further discussion.

I suggest to close this specific issue. Conceptually we may want to think about a separate execution mode, where packchk provides feedback about the 'quality' / 'completeness' / 'use of features' of a Pack to cleanly separate between validation and enhancements.


use BMI2 cpuid instead for _mulx_u32

Issue #, if available:
https://github.com/awslabs/aws-c-common/issues/968
Description of changes:

Instead of using build-time check, use runtime check with CPUID.
According to here CPUID Flags for _mulx_u32 is BMI2
According to here BMI2 CPUID.(EAX=07H, ECX=0H):EBX.BMI2[bit 8]==1
According to here, use __emulu instead when _mulx_u32 is unavailable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Base: 80.81% // Head: 80.81% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (a0a683b) compared to base (8020239).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #974   +/-   ##
=======================================
  Coverage   80.81%   80.81%
=======================================
  Files          53       53
  Lines        5656     5662    +6
=======================================
+ Hits         4571     4576    +5
- Misses       1085     1086    +1

Impacted Files
Coverage Δ

source/arch/intel/cpuid.c
82.97% <83.33%> (+0.05%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


"Beceni", "Arbănași" and "Cărpiniștea" are listed in the drop-down menu

Description:
"Beceni", "Arbănași" and "Cărpiniștea" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Arbănași" in the search bar.

Expected results
The location is listed in the drop-down menu as "Arbănași, Buzău(Beceni)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.


Network giving ambiguous results.

I am doing 2 class classification using BLVNET-TAM.
When i had given data for validation the accuracy is coming good but on testing same data accuracy is bad.
for instance ,
validation probabilities are somewhat like [0.2 , 0.8]
while during testing probabilities are like [0.5.. , 0.499..]  on same data.

do you mean that when giving the same data, the output prob is different?
if so, do you mind providing the scripts you are using for both validation and test?
thanks


achive better parallelism when building deps

Note: this is an oversimplified example.
Lets say my crate dependencies are like this:
A -requires-> B , C
B -requires-> D , E

A
├── B
C   ├── D
    E

I noticed that cargo would build C and D or E in parallel and then build B in the end and then A.
It would be smarter to realize that we can build D and E in parallel and then B and C in parallel.
before:

core1
core2

C
E

D

B

A

suggested:

core1
core2

E
D

C
B

A

The current behaviour also happens when forcing code gen units to 1.

Indeed! Right now there's no heuristics for "what crate to schedule next", and this sounds like an excellent heuristic to me. The logic would go around here

We can do that using Hu's scheduling algorithm. This assumes that all packages take an equal amount of time to compile; that is never true, yet the best bet we can make. We'd be required to compute the path length from the top package to the ready-to-be-scheduled packages, which in turn we can do using a simple topological sort.
As far as I can see we would currently need to recompute that for every call of dequeue because DependencyQueue is designed to be mutable while jobs are being dequeued (that is, we currently do not pre-compute a definite job schedule ahead of time).
I'm wondering if the added complexity in dequeue() were to be considered worth it. The runtime-cost of doing a topological sort of the dependency-queue for every call to dequeue() is probably very small.

@lukaslueg sounds plausible to me! We could actually estimate the cost of a crate via the size of all its input files probably as well if we wanted to go a bit further. In any case the DependencyQueue basically hasn't changed since it was first added to Cargo, and IIRC it's not optimized at all and is already doing a bunch of liner things on each call to dequeue already, so adding more probably can't hurt!
And yeah AFAIK there are no cycles there.


Versioning for AbsTasks

Currently, AbsTasks only differ by name.
Whenever we want to update an abstask there are two things we have to make sure:

Most people and new tasks use the new version.
Results on older tasks should preferably not change, especially after we start running the models.

Our solution for this with clustering was to introduce a completely new task, and then create an issue for converting all tasks to the new version.
Currently, there is a similar problem with PairClassification #756.
Again the new version is no longer backwards compatible and would produce different results from the previous one.
@KennethEnevoldsen brought it up that we could have a test to see whether someone was using an old version in a new task, this would have to be hard-coded though, which is not too nice in my view.
@Muennighoff also suggested that we rename the outdated abstask, but then we need to rewrite every old file in order to adhere to this principle every time we update an AbsTask.
I have multiple suggestions for what we could do here:
a) We could do the thing we already do with concrete tasks, and go down the superseeded_by road.
b) We could introduce some versioning system for abstasks.
It has been suggested that we could add V1, V2, etc. to task names. I'm not sure, I like this because then we would have to rename every currently existing abstask.
It would be really nice to have a version attribute on AbsTasks, and then an abstask_version attribute on particular tasks, this would however, be incredibly hacky to do with the current way we manage these things (inheritence).
Do you guys have any good ideas on how to solve this? I'm currently trying to write a new AbsTask for PairClassification, and it would be really nice if we could figure some system out.

I would just add a failing test stating "Please don't use AbstaskClustering but instead use AbstaskClusteringFast" with an exception list of all old tasks of the type.

@isaac-chung would love a second opinion here
Another option (which have been used for SummarizationEvaluator) is to use:
DeprecatedSummarizationEvaluator (this also comes with a deprecation warning) and SummarizationEvaluator - this are maintained to ensure backward compatibility but make it clear that you would not use it.
The warning might be too much for AbstaskClustering, but we could still do:
AbstaskClustering -> DeprecatedAbstaskClustering
AbstaskClusteringFast -> AbstaskClustering
Alternative we could do:
AbstaskClustering -> AbstaskClusteringV1
AbstaskClusteringFast -> AbstaskClusteringV2
It might also be reasonable to not do anything and leave it as is (https://github.com/embeddings-benchmark/mteb/pull/756 is closed so it isn't pressing)

1), 2), 3) completely agree.

For PairClassification, since the current tasks are binary and "new" tasks would have 3 classes, maybe we could use PairClassificationV2? That way we can avoid renaming everything, and still allow users to run "old" tasks.

if we go this route we could also simply change:
AbstaskClusteringFast -> AbstaskClusteringV2
There is also the option of leaving it as is for now (PairClassificationV2 isn't planned)

Oh right. Leaving as is works for me. I think we can use V2 + superseded by once there's a need for new Pair Classification tasks.

Perfect I am totally fine with this - will close this for now then


Optional Box

I have an situation where my app runs in 2 modes based on a cli flag. In one mode I want to use a box, in the other i do not. Currently, if I build when the path doesn't exist on disk (using the packr command), it aborts.
It would be great if there's a way of indicating to the cli that i'm cool with it not existing.

What version of Packr are you using?
Can you provide an example of what you're doing?

Working with non-existent folders on disk is supported in v2, so I can't reproduce without further information. If you aren't using v2, please upgrade.

Ah, i was actually holding off from upgrading to v2 but great that it's
supported.
Will upgrade. Sorry for the noise.
On Sat., 16 Feb. 2019, 07:05 Mark Bates<EMAIL_ADDRESS>wrote:

Working with non-existent folders on disk is supported in v2, so I can't
reproduce without further information. If you aren't using v2, please
upgrade.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gobuffalo/packr/issues/160#issuecomment-464181943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2pYHrQ_4mNNF3Sql04DeMtnqOSClrTks5vNxLxgaJpZM4a-U6B
.

Looks like v2 doesn't support modules. Any plans for that?

Both v1 and v2 support modules. There are go.mod files in both.

Mark Bates
On Feb 16, 2019, 3:57 PM -0500, Lea Anthony<EMAIL_ADDRESS>wrote:

Looks like v2 doesn't support modules. Any plans for that?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

https://github.com/gobuffalo/packr/blob/master/v2/go.mod


Chanaged Units for Character Weight and Height

New units:

Closed this for now just going to change the default 6.2cm / 180kg to something that makes sense.


Dependency error

Getting this error, any idea?

Can we relax the dependency to commintilnt 11 ?

maybe you can try with the latest version of commitlint-config-gitmoji ?

didn't work.
but switched to commit zen, removed your pkg and it's a neat alternative.