Clear kernel information from notebooke metadata when a non Jupyter kernel is selected

For https://github.com/microsoft/vscode-jupyter/issues/4423#issuecomment-763903125
This way we don't set the kernel metadata when a non-jupyter kernel is selected.
Allowing others to update the notebook metadata without us blowing it away.

I'm confused. This looks like it's clearing the metadata? Don't we want to just not set it?

I'm confused. This looks like it's clearing the metadata? Don't we want to just not set it?

I'm confused. This looks like it's clearing the metadata? Don't we want to just not set it?
If  you select a Jupyter kernel then we set it.
If you then select a non-jupyter kenrel we need to unset it, i.e. clear it.
This way, if users change kernels to a non-jupyter kernel (not ours), & save, then there's no custom metadata that will be set, apart from what ever is already in there.

If you check the method, we use call the same function to save the kernel information (but only if its our kernel).

I'm confused. This looks like it's clearing the metadata? Don't we want to just not set it?
If  you select a Jupyter kernel then we set it.
If you then select a non-jupyter kenrel we need to unset it, i.e. clear it.
This way, if users change kernels to a non-jupyter kernel (not ours), & save, then there's no custom metadata that will be set, apart from what ever is already in there.

If you check the method, we use call the same function to save the kernel information (but only if its our kernel).

If you then select a non-jupyter kenrel we need to unset it, i.e. clear it.
This way, if users change kernels to a non-jupyter kernel (not ours), & save, then there's no custom metadata that will be set, apart from what ever is already in there.

Why wouldn't this clear the metadata set by the .NET kernel provider? Sure it won't overwrite something that's already on disk, but won't it overwrite a value in memory?

If you then select a non-jupyter kenrel we need to unset it, i.e. clear it.
This way, if users change kernels to a non-jupyter kernel (not ours), & save, then there's no custom metadata that will be set, apart from what ever is already in there.

Why wouldn't this clear the metadata set by the .NET kernel provider? Sure it won't overwrite something that's already on disk, but won't it overwrite a value in memory?

Codecov Report

Merging #4504 (727e091) into main (cd3bdd3) will decrease coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff          @@
##            main   #4504   +/-   ##
=====================================
- Coverage     75%     75%   -1%
=====================================
  Files        398     398
  Lines      26063   26071    +8
  Branches    3726    3729    +3
=====================================
- Hits       19568   19555   -13
- Misses      4978    4994   +16
- Partials    1517    1522    +5

Impacted Files
Coverage Δ

src/client/datascience/notebook/kernelProvider.ts
70% <0%> (-1%)
:arrow_down:

src/client/common/application/debugService.ts
46% <0%> (-7%)
:arrow_down:

src/client/common/process/pythonDaemonPool.ts
78% <0%> (-7%)
:arrow_down:

...datascience/interactive-common/notebookProvider.ts
80% <0%> (-6%)
:arrow_down:

...science/jupyter/kernels/kernelDependencyService.ts
80% <0%> (-5%)
:arrow_down:

src/client/common/cancellation.ts
79% <0%> (-5%)
:arrow_down:

src/client/datascience/jupyter/jupyterServer.ts
78% <0%> (-4%)
:arrow_down:

...datascience/editor-integration/codelensprovider.ts
84% <0%> (-3%)
:arrow_down:

src/client/datascience/jupyter/kernels/kernel.ts
69% <0%> (-3%)
:arrow_down:

src/client/datascience/jupyter/jupyterExecution.ts
72% <0%> (-3%)
:arrow_down:

... and 21 more

Codecov Report

Merging #4504 (727e091) into main (cd3bdd3) will decrease coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff          @@
##            main   #4504   +/-   ##
=====================================
- Coverage     75%     75%   -1%
=====================================
  Files        398     398
  Lines      26063   26071    +8
  Branches    3726    3729    +3
=====================================
- Hits       19568   19555   -13
- Misses      4978    4994   +16
- Partials    1517    1522    +5

Impacted Files
Coverage Δ

src/client/datascience/notebook/kernelProvider.ts
70% <0%> (-1%)
:arrow_down:

src/client/common/application/debugService.ts
46% <0%> (-7%)
:arrow_down:

src/client/common/process/pythonDaemonPool.ts
78% <0%> (-7%)
:arrow_down:

...datascience/interactive-common/notebookProvider.ts
80% <0%> (-6%)
:arrow_down:

...science/jupyter/kernels/kernelDependencyService.ts
80% <0%> (-5%)
:arrow_down:

src/client/common/cancellation.ts
79% <0%> (-5%)
:arrow_down:

src/client/datascience/jupyter/jupyterServer.ts
78% <0%> (-4%)
:arrow_down:

...datascience/editor-integration/codelensprovider.ts
84% <0%> (-3%)
:arrow_down:

src/client/datascience/jupyter/kernels/kernel.ts
69% <0%> (-3%)
:arrow_down:

src/client/datascience/jupyter/jupyterExecution.ts
72% <0%> (-3%)
:arrow_down:

... and 21 more

As much as I'm following this looks right to me, though I'm not 100% sure on the scenario that the C# folks are after. Is it ok that it's setting metadata to undefined as opposed to {}?

As much as I'm following this looks right to me, though I'm not 100% sure on the scenario that the C# folks are after. Is it ok that it's setting metadata to undefined as opposed to {}?


Bug: Fuel Flowmeter Accuracy Historical Data Import not working

Issue:
Fuel Flowmeter Accuracy historical data import is not working
Steps to reproduce:

Navigate to and check out Hamilton Liberty Generation Plant (ORIS Code 58420)
Import from historical data
Set year to 2014 and quarter to Q2
Select any of the two FFACC records to import
Observe that the import has failed with the error "fuelFlowmeterAccuracyData.0.You reported [reinstallationDate] which must be a valid ISO date format of YYYY-MM-DD for [Fuel Flowmeter Accuracy]."

Bug fixed


Use AI to render a background context

Currently
There is a possibility to use a {{BACKGROUND}} placeholder which will render a text such as

If there is no ticket link found: Provide some context to the reviewer before jumping in the code.
If there is a ticket link found: Details in the ticket.

The original idea with this was that the developer would write some context about the ticket itself, so the reviewer doesn't have to read the original ticket back-and-forth but having the whole context of those changes in the same place.
Expected
However, it would be even better to have access to the content of the ticket itself and get a summary of the task itself based on its original description and render a one or two lines with a basic context by default.

Of course this can be edited later on by the author of the PR, but it might be very handy especially if the ticket descriptions are well define.

As first iteration, instead of aiming to use AI here, we could focus on having access to the original text and copy-paste it here. An "AI-summary" could be in a follow up if needed.

Too much fantasy


removeUnknownsAndDefaults breaks image

No other overrides specified, calling through via gulp-svgmin. The end result is a completely blank (no visible strokes / fills) output image.
Disabling the removeUnknownsAndDefaults plugin fixes the issue. Presumable there's an "unknown unknown" in there somewhere.  =]
Here's a gist with the source image data - https://gist.github.com/booleanbetrayal/fa7b19ed5c4bfc39cb36
Hope this helps!

v0.5.1 with the fix has been just published.

just verified! thanks @GreLI !


Run custom task on build

This package absolutely need ability to run custom gulp task, not necessarily 'default'.

It should extract all tasks available in the gulpfile and list those as targets, like so:

Does this not work for you?

Closing due to no response. Please re-open if the issue persists.


The desired archetype does not exist (com.adobe.cq.spa.archetypes:aem-spa-project-archetype:1.0.5-SNAPSHOT)

Bug Report
Current Behavior
I have been following the instructions in the readme, cloned this repo, ran mvn clean install archetype:update-local-catalog and then mvn archetype:crawl, then created a new folder and ran
mvn archetype:generate \
 -DarchetypeCatalog=internal \
 -DarchetypeGroupId=com.adobe.cq.spa.archetypes  \
 -DarchetypeArtifactId=aem-spa-project-archetype  \
 -DarchetypeVersion=1.0.5-SNAPSHOT

and it failed with
[INFO] Generating project in Interactive mode
[WARNING] Archetype not found in any catalog. Falling back to central repository.
[WARNING] Add a repository with id 'archetype' in your settings.xml if archetype's repository is elsewhere.
[WARNING] The POM for com.adobe.cq.spa.archetypes:aem-spa-project-archetype:jar:1.0.5-SNAPSHOT is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18.945 s
[INFO] Finished at: 2019-10-15T09:53:36+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-archetype-plugin:3.1.2:generate (default-cli) on project standalone-pom: The desired archetype does not exist (com.adobe.cq.spa.archetypes:aem-spa-project-archetype:1.0.5-SNAPSHOT) -> [Help 1]

Expected behavior/code
I expected a new project to be successfully generated
Environment

AEM version and patch level (e.g. AEM 6.5 installed via docker - see https://github.com/pawangonnakuti/aem-author/blob/master/Dockerfile)
AEM SPA Archetype 1.1.0
JRE version Java(TM) SE Runtime Environment (build 1.8.0_92-b14)

Possible Solution
No idea
Additional context / Screenshots
None

I got this to work by using the following command
mvn archetype:generate \
 -DarchetypeCatalog=local \
 -DarchetypeGroupId=com.adobe.cq.spa.archetypes  \
 -DarchetypeArtifactId=aem-spa-project-archetype  \
 -DarchetypeVersion=1.1.0

I recommend the README be updated to reflect this

Thanks for reporting! This will be resolved with 82e3a6b5fcd5e65ec0d6511379c3bdec3811117c.


New Feature: Add MYSQL

Countries in all partitions can be united in bc subservers!
Hope to add this feature

This was suggested a lot before, it's just not that easy. I might add it to the next feature update poll. I haven't decided yet.


Incorrect proof of work

Setting up a local network of two nodes, I had two nodes both mining, the first node was online first and mined 2 blocks, then I turned on the second node and it mined 1 block before it synced up with the other node. Then after a short while, the second node started complaining about "incorrect proof of work" (the node finds a new block).
Consensus error exception occurred in miner loop: Stratis.Bitcoin.Consensus.ConsensusErrorException: incorrect proof of work

at Stratis.Bitcoin.Consensus.ConsensusError.Throw() in C:\...\src\Stratis.Bitcoin\Consensus\ConsensusErrorException.cs:line 44

at Stratis.Bitcoin.Features.Consensus.Rules.CommonRules.BlockHeaderPowContextualRule.RunAsync(RuleContext context) in C:\...\src\Stratis.Bitcoin.Features.Consensus\Rules\CommonRules\BlockHeaderPowContextualRule.cs:line 33

The code at the line:
// Check proof of work.
if (header.Bits != context.NextWorkRequired)

Here is a zip of the data folder. This is built using the "main" Stratis network, but I have modified the node to not use checkpoints, no DNS seed and only my LAN nodes. The only modification to stratis.conf, is mine=1 and the address.
StratisMain.zip
I have attempted a few times to use this data folder when running StratisD from Visual Studio (Debugging), but then the problem does not occur. Only when I run from cmd, with "dotnet stratis.stratisd.dll".
I did a run with debug level on trace, and here is the log output from a quick startup and close. Search for "Validating new block" to find the interesting parts.
node.zip

I am aware what the problem is and will work with @fassadlr to fix it.
Basically we need another BlockDefinition for a POS network that is mining POW blocks.

Hi @sondreb this issue has now been fixed. A PR will be sumbitted today. Thanks!


example: conversation turn limit filter

Description:
Conversations in our can get expensive quickly due to paid API costs. To mitigate this, I propose adding a filter plugin that limits the number of turns in a conversation.
Problem:
Long conversations = exponential API cost increases
Solution:
A "Turn Limiter" plugin that:

Sets a max number of turns (e.g., 10, 20)
Closes or archives conversations when the limit is reached?
Notifies users to start a new convo

Benefits:

Reduced API costs

Implemented!


Update packages to rc1

:white_check_mark: Build TheIdServer 1.0.0 -user-ole0092 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/39d0ad9abf by @aguacongas)

:white_check_mark: Build TheIdServer 1.0.0 -user-ole0093 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/213b0bb1bf by @aguacongas)

:x: Build TheIdServer 1.0.0 -user-ole0094 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/9566249744 by @aguacongas)

:white_check_mark: Build TheIdServer 1.0.0 -user-ole0095 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/6b6fdda936 by @aguacongas)


DateTime value example incorrect format

OpenApiDateTime parameter example is being written without parentheses, which should be mandatory in a json file

I saw that they corrected this in commit e28c438a with pull request # 312, but this change is not yet available in the version available in nuget (1.1.0)

Fixed non pull request #322, awaiting release


fix slice/Hashable overlap.  Update mypy and pyright

[x] Closes #1017(Replace xxxx with the Github issue number)
[ ] Tests added:  None

Also makes stubs compliant with mypy 1.13.0 and pyright 1.1.387 .

@twoertwein updates based on your comments for you to review

Thank you, looks good to me! Just need to rebase

done in commit https://github.com/pandas-dev/pandas-stubs/pull/1021/commits/b5ba2eda6f6c3efb2371ad97910ee832213afd39

Thank you @Dr-Irv !


Facing error in connecting database fetch values. giving below error unable to open page

Dear Team,
please help me out to install cocorico-master project into my local system.
SQLSTATE[42000]: Syntax error or access violation: 1055 Expression #7 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'cocorico_dev.l1_.title' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by   +
i am new to symfony.
Thanks
shivukumar

its got solved


Cybersecurity: 2.9.2 HUBs

Description
What is HUB?
Note:

If interested, mention in which format you want to contribute: Documentation or Video
Please avoid copy/paste, BE YOURSELF
Try to explain with Diagrams
Changes should be made inside the Cyber_Security/ directory & Cyber_Security branch.
Task will be assigned on first come first serve
Check it out Contribution Guidelines

assign me to these @Anant1711

assign me to these @Anant1711

One Task at a Time!

i can do it in documentation

Can I contribute in this, for documentation part!?

Can I contribute in this, for documentation part!?

Okay! Go for Documentation

@Anant1711 Please assign me this issue, I want to make video for the issue.
Nikita Agrawal (Batch-1, Cybersecurity)

/assign


[BUG] System.UnauthorizedAccessException: Access to the path 'face.png' is denied.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[X] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.8.1
What problem did you encounter?
[BUG] System.UnauthorizedAccessException: Access to the path 'face.png' is denied.
I change the textures to make players head the color red
Bloxstrap Log
2024-12-11T23:17:02Z [App::OnStartup] Starting Bloxstrap v2.8.1
2024-12-11T23:17:02Z [App::OnStartup] Compiled Tuesday, 29 October 2024 at 5:35:23 PM from commit 2be2f4d0d275e60eabf2f63ecbbe4e38b2aa0773 (tag/v2.8.1)
2024-12-11T23:17:02Z [App::OnStartup] Loaded from %UserProfile%\AppData\Local\Bloxstrap\Bloxstrap.exe
2024-12-11T23:17:02Z [App::OnStartup] Temp path is %UserProfile%\AppData\Local\Temp\Bloxstrap
2024-12-11T23:17:02Z [App::OnStartup] WindowsStartMenu path is %UserProfile%\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
2024-12-11T23:17:02Z [LaunchSettings] Identifier 'player' is active
2024-12-11T23:17:02Z [Logger::Initialize] Initializing at %UserProfile%\AppData\Local\Bloxstrap\Logs\Bloxstrap_20241211T231702Z.log
2024-12-11T23:17:02Z [Logger::Initialize] Finished initializing!
2024-12-11T23:17:02Z [JsonManager<Settings>::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\Settings.json...
2024-12-11T23:17:02Z [JsonManager<Settings>::Load] Loaded successfully!
2024-12-11T23:17:02Z [JsonManager<State>::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\State.json...
2024-12-11T23:17:02Z [JsonManager<State>::Load] Loaded successfully!
2024-12-11T23:17:02Z [FastFlagManager::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\Modifications\ClientSettings\ClientAppSettings.json...
2024-12-11T23:17:02Z [FastFlagManager::Load] Loaded successfully!
2024-12-11T23:17:02Z [LaunchHandler::LaunchRoblox] Initializing bootstrapper
2024-12-11T23:17:02Z [LaunchHandler::LaunchRoblox] Initializing bootstrapper dialog
2024-12-11T23:17:03Z [Bootstrapper::Run] Running bootstrapper
2024-12-11T23:17:03Z [Bootstrapper::SetStatus] Connecting to Roblox...
2024-12-11T23:17:03Z [Deployment::TestConnection<https://setup.rbxcdn.com>] Connecting...
2024-12-11T23:17:03Z [HttpClientLoggingHandler::ProcessRequest] GET https://setup.rbxcdn.com/versionStudio
2024-12-11T23:17:03Z [Deployment::InitializeConnectivity] Testing connectivity...
2024-12-11T23:17:03Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://setup.rbxcdn.com/versionStudio
2024-12-11T23:17:03Z [Deployment::InitializeConnectivity] Got https://setup.rbxcdn.com as the optimal base URL
2024-12-11T23:17:03Z [Bootstrapper::Run] Connectivity check finished
2024-12-11T23:17:03Z [Bootstrapper::CheckForUpdates] More than one Bloxstrap instance running, aborting update check
2024-12-11T23:17:03Z [Bootstrapper::GetLatestVersionInfo] Got channel as production
2024-12-11T23:17:03Z [Deployment::GetInfo] Getting deploy info for channel production
2024-12-11T23:17:03Z [HttpClientLoggingHandler::ProcessRequest] GET https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer
2024-12-11T23:17:03Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer
2024-12-11T23:17:03Z [RegistryKeyEx::SetValueSafe] Writing '' to HKEY_CURRENT_USER\SOFTWARE\ROBLOX Corporation\Environments\RobloxPlayer\Channel\www.roblox.com
2024-12-11T23:17:03Z [HttpClientLoggingHandler::ProcessRequest] GET https://setup.rbxcdn.com/version-b71c150c7c1f40de-rbxPkgManifest.txt
2024-12-11T23:17:03Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://setup.rbxcdn.com/version-b71c150c7c1f40de-rbxPkgManifest.txt
2024-12-11T23:17:03Z [Bootstrapper::SetStatus] Upgrading {product}...
2024-12-11T23:17:03Z [LaunchHandler::LaunchRoblox] Bootstrapper task has finished
2024-12-11T23:17:03Z [LaunchHandler::LaunchRoblox] An exception occurred when running the bootstrapper
2024-12-11T23:17:03Z [App::FinalizeExceptionHandling] (0x80070005) System.UnauthorizedAccessException: Access to the path 'face.png' is denied.
   at System.IO.FileSystem.RemoveDirectoryRecursive(String fullPath, WIN32_FIND_DATA& findData, Boolean topLevel)
   at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
   at Bloxstrap.Bootstrapper.UpgradeRoblox()
   at Bloxstrap.Bootstrapper.Run()
   at Bloxstrap.Bootstrapper.Run()
2024-12-11T23:17:03Z [HttpClientLoggingHandler::ProcessRequest] POST https://bloxstraplabs.com/metrics/post-exception
2024-12-11T23:17:03Z [HttpClientLoggingHandler::ProcessResponse] 429 Too Many Requests https://bloxstraplabs.com/metrics/post-exception

first of all changing the face.png only applies to people that doesnt have any faces and uses the default second at all why. just fucking force reinstall roblox


according to pwsh "SnipeitPS does not have a valid module manifest file"

Does this module work with powershell 7? I cannot import it because "it does not have a valid module manifest file."
PS /home/me> Install-Module SnipeitPS
PS /home/me> Get-Command -Module SnipeitPS -Verbose
PS /home/me>
PS /home/me> Import-Module SnipeitPS -Verbose
VERBOSE: Skipping the Version folder 1.5.131 under Module /home/msf/.local/share/powershell/Modules/SnipeitPS as it does not have a valid module manifest file.
Import-Module: The specified module 'SnipeitPS' was not loaded because no valid module file was found in any module directory.

PS /home/me> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Linux 3.10.0-1127.el7.x86_64 #1 SMP Tue Mar 31 23:36:51 UTC 2020
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I have run it with pwsh core on windows. It should work on Linux too.
Couple of months ago there I saw some issues when I tested it on Linux, it
was case sensitivity issue on module folder and manifestfile. I fixed it by
hand and forgot to push changes back.
ti 8. kesäk. 2021 klo 17.48 maxferrario-msf @.***>
kirjoitti:

Does this module work with powershell 7? I cannot import it because "it
does not have a valid module manifest file."
PS /home/me> Install-Module SnipeitPS
PS /home/me> Get-Command -Module SnipeitPS -Verbose
PS /home/me>
PS /home/me> Import-Module SnipeitPS -Verbose
VERBOSE: Skipping the Version folder 1.5.131 under Module /home/msf/.local/share/powershell/Modules/SnipeitPS as it does not have a valid module manifest file.
Import-Module: The specified module 'SnipeitPS' was not loaded because no valid module file was found in any module directory.
PS /home/me> $PSVersionTable
Name                           Value

PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Linux 3.10.0-1127.el7.x86_64 #1 SMP Tue Mar 31 23:36:51 UTC 2020
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/snazy2000/SnipeitPS/issues/142, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCUTLFOFP325YK6GTMOT7LTRYUSXANCNFSM46KD4AIQ
.


fix(zitadel): dependencies

do we still need this?

Nope dependencies are outdated

I thought so 😁


Excessive resource usage on arch

I'm not sure what the problem is exactly, but:
./mwaa-local-env build-image
./mwaa-local-env start

On Arch, this takes 100% of my 5900HX processing power and all 16 gigs of RAM. Completely freezes the system, and I've left it on for 12 hours -- so it's not like it's some build task that it's completing.

This is a wider issue than just this repository. Here is a discussion with solutions from the Airflow repo:
https://github.com/apache/airflow/discussions/29731#discussioncomment-5162421


chrome-extension: Kogito icon is not working correctly after using the browser "back"

The Kogito icon becomes inaccessible after using the browser "back" in a bpmn/dmn file in the bpmn/dmn chrome-extension. Also, opening a bpmn/dmn file after the browser "back" a second Kogito icon will appear.
https://user-images.githubusercontent.com/24302289/222573699-7e2eaf56-f487-4e6b-9127-515b8139f32d.mp4

https://user-images.githubusercontent.com/24302289/222573716-a0864b7d-f438-4c00-8067-40495bb4e139.mp4

As detailed above, the problem was two-fold:
Problem 1) The kogito icon was being rendered multiple times when the back button was pressed. This was happening because GitHub caches DOM structures between changes of history.
Solution 1) This has been addressed by adding a cleanup function in the utils.ts (which was already used elsewhere in the application to address this problem happening with other components).
Problem 2) The kogito icon was being rendered, but was un-interactable. This was happening due to an error where we were trying to "insertAdjacentHtml" to elements that hadn't been rendered yet.
Solution 2) Fixed by making the affected function async, and only attempt to render once the element was available. (Similar to the SingleEditorView.ts)
During testing found 2 bugs:
https://github.com/bamoe/private-bamoe-issues/issues/1410
https://github.com/bamoe/private-bamoe-issues/issues/1411


Added TypeScript Typings

Not sure if you are interested in supporting Typescript users, but I did this while using your library for myself and thought I would share. Thanks!

Thanks @ttdung11t2!


Fix: dtdl 'extends' is a list

There are few tests not passing : https://github.com/Cosmo-Tech/azure-digital-twins-simulator-connector/pull/27/checks


Add hpio.

Seems stack downloads on Travis-CI are failing. I'm having the same problem with my Travis-CI stack builds.


Error: While trying to resolve module react-native-fbads from file

I can not show the fbads . PLease help me
Metro show Error:
Error: While trying to resolve module react-native-fbads from file D:\Reactnative\Test20230105\App.js, the package D:\Reactnative\Test20230105\node_modules\react-native-fbads\package.json was successfully found. However, this package itself specifies a main module field that could not be resolved (D:\Reactnative\Test20230105\node_modules\react-native-fbads\dist\lib\index.js. Indeed, none of these files exist:

Wrong project, this is react-native-fbsdk-next and your issue is with react-native-fbads
Report here: https://github.com/callstack/react-native-fbads

I am also facing same issues.


Update Password

Hi,
I lost my password and I needed to change it on the Ecowater website to gain access again. This worked but now the integration is showing unavailable values which makes sense as the password has been changed.
How do I change the password of the integration? Altering the password in the core.config_entries doesn't seem to work. Or is there a may to re-launch the setup and then overwriting the existing credentials?

Have you tried removing the integration and re-adding it with the correct password?

Your suggestion is the obvious way but I want to keep the sensors so I don't have to change automations, graphs and all of that. Will that not create new sensors?

If you remove and re-add it then it will create sensors with the same Entity IDs (unless you changed them from the default ones) so the graphs and automations should remain.


Panic with "no current timer"

I get a panic when I try to set a timeout for the connection.
Reproducible on the following code:
    let pool = Arc::new(ThreadPool::new().expect("Failed to build pool"));
    let client = reqwest::Client::builder().connect_timeout(Duration::from_millis(300)).build().unwrap();
    pool.spawn_ok(async move {
        if let Ok(resp) = client.get("https://google.com").send().await {
            let headers = resp.headers();
            println!("{:?}", headers);
        }
    });
  ...

You need to use reqwest on a Tokio runtime.

I also get panic with code below, could you please give explanation @seanmonstar ?
    let mut rt = Builder::new()
        .threaded_scheduler()
        .thread_name("async_worker")
        .thread_stack_size(1024 * 512)
        .build()
        .unwrap();

    rt.block_on( async {
                    let client = reqwest::Client::builder().connect_timeout(Duration::from_millis(300)).build().unwrap();
                    if let Ok(resp) = client.get("https://google.com").send().await {
                        let headers = resp.headers();
                        println!("{:?}", headers);
                    }
                });

You need to enable_time and enable_io if customizing a builder.

@seanmonstar Thanks!
I think it would be nice to update the documentation on this subject, right?

It's there in the docs: https://docs.rs/reqwest/0.10.1/reqwest/struct.ClientBuilder.html#method.connect_timeout

I mean in case someone will use reqwest with custom tokio runtime. I can do PR if necessary.

The Tokio docs also describe this: https://docs.rs/tokio/0.2.9/tokio/runtime/index.html#resource-drivers
I think the best thing to do is to improve the panic messages in Tokio: https://github.com/tokio-rs/tokio/issues/1713


Adding CI for build testing

How about adding a CI configuration (e.g. https://github.com/ros-industrial/industrial_ci) to check if catkin_make can be done without errors?
I think you'll notice bugs like #20 right away.
I can send a PR if you wish.

Of course

OK! I'll send a PR.

@zlj-zz Which branch should I send the request to?
What is the difference between noetic, master and dev?

master

why the env is melodic? It's same with kinetic?

ROS Kinetic and Ubuntu 16.04 has been EOL (End of Life).
It's not exactly the same, but it can be used in much the same way, so I'll check if I can add Kinetic.
It could be difficult because it is not supported officially anymore...

All features are OK？

I haven't tested all, but it seems OK. I don't have a camera for myCobot.

The PR has been merged and the issue will be closed. Notice here.


Wrong resizing of boxes?

Hi @lufficc,
I have the feeling that the resizing of the (ground truth) boxes is wrong. The resizing is "bypassed" by taking the relative values of x1,y1,x2,y2 with regards to the original image shape. However, this leads to wrong results, as the images are resized to the squared shape = size x size (i.e. 512 x 512 or 300 x 300), thus, discarding the original aspect ration.
A possible solution would be to change the Resize class in the following way:
`class Resize(object):
def init(self, size=300):
self.size = size
def __call__(self, image, boxes=None, labels=None):

    old_size = image.shape[:2]
    ratio = float(self.size) / max(old_size)
    new_size = tuple([int(x * ratio) for x in old_size])

    image = cv2.resize(image, (new_size[1], new_size[0]))

    delta_w = self.size - new_size[1]
    delta_h = self.size - new_size[0]
    top, bottom = delta_h // 2, delta_h - (delta_h // 2)
    left, right = delta_w // 2, delta_w - (delta_w // 2)

    color = [0, 0, 0]
    image = cv2.copyMakeBorder(image, top, bottom, left, right, cv2.BORDER_CONSTANT,
                               value=color)

    return image, boxes, labels

`
This pads the shorter images size, such that the original aspect ration is kept.
Please let me know your thoughts about this.

SSD is trained without considering image aspect ration. So there is no need to pad image like in Faster R-CNN.
ToPercentCoords is called before Resize, so it's OK for Resize to discard the original aspect ration.
https://github.com/lufficc/SSD/blob/50373c79b861d5d239be4206fafc6661cea040b4/ssd/data/transforms/__init__.py#L14-L15

SSD is trained without considering image aspect ration. So there is no need to pad image like in Faster R-CNN.
ToPercentCoords is called before Resize, so it's OK for Resize to discard the original aspect ration.
https://github.com/lufficc/SSD/blob/50373c79b861d5d239be4206fafc6661cea040b4/ssd/data/transforms/__init__.py#L14-L15


fix dependencies

package needs acdh-id-reconciler -> add to requirered packages but remove arche assets instead

this issues makes no sense ...


Google Cloud Vision API returns "Bad image data" when images is uploaded in Node

Hi all,
I was trying to implement an image application using google cloud vision API. The initial step in the application allows users to upload images to the application. When I use the command "gsutil" Vision API works fine without any issues. To make the process easier for the users I have created a  node.js server to upload the images to the application, But when I upload my images through the node.js server it gives me the following error. (Note: application is deployed in Kubernetes cluster)

This error occurs when I upload the images through the node.js server, If I use the gsutil command it works fine.!
This the Nodejs server that I have created
Link to code:= https://github.com/Uvindu96/apollo-server-react-file-upload/blob/master/server/src/index.js
const nodejsBucket = gc.bucket('stone-semiotics-297911-images-input');

const resolvers = {
  Query: {
    files: () => files
  },
  Mutation: {
    uploadFile: async (_, { file }) => {
      const { createReadStream, filename } = await file;

      await new Promise(res =>
        createReadStream()
          .pipe(
            nodejsBucket.file(filename).createWriteStream({
              resumable: false,
              gzip: true
            })
          )
          .on("finish", res)
      );

      files.push(filename);

      return true;
    }
  }
};

Environment details

OS: Ubuntu 20.04
.NET version: mcr.microsoft.com/dotnet/core/aspnet:3.1 AS runtime
Package name and version: Google.Cloud.Vision.V1

I really appreciate your help, Thanks!

@jskeet Thanks for the guidelines, I have updated the git issue. I checked the uploaded image by downloading it again, there was no issue with the image file it was fine.

Okay, that's interesting that after downloading it the image was okay.
I'd suggest comparing the metadata for an image uploaded via gsutil and one uploaded via your node code, both from the same original file. Check that they have the same Content-Encoding, for example. You can check some of this in the Storage console - or you could use the API to get more details, including the hash of the data. Fundamentally the next step should be to work out the difference between uploading via gsutil and uploading via your Node code.

@jskeet I was able to find out what causing this error, Its encoding that set from node server (gzip: true) when the value is true it set the gzip type encoding, after I set the value to false it worked fine. Thank you for all the support you gave me, appreciate it !

Very glad it worked out :)


Allow removal of links

In the Twixt rules, player are allowed to remove their own links before playing a peg. This is necessary in rare cases to allow a new link, crossing a previously created link.

right, link removal is not supported. twixtbot was trained without link-removal so like "self-crossing-links=false" this would be another "asymmetric" feature.   Little tricky to implement as well, not the UI part, but carrying link removal info in history; saving and loading; undoing , moves etc.

Ok. Agree and understand.


bash script not working on windows machine

while setting up a local test environment on a windows machine, the shell script located at https://github.com/KomMonitor/docker/blob/master/config/config.sh  is not working.
I got error messages like
2024-02-13 09:40:14 /code/config.sh: line 34: syntax error: unexpected end of file (expecting "then")
: not found09:41:15 /code/config.sh: line 2:
2024-02-13 09:41:15 /code/config.sh: line 33: syntax error: unexpected "fi" (expecting "then")

solution is described here: https://stackoverflow.com/questions/20368781/anything-like-dos2unix-for-windows
the porblem basically is, that the shell script is donwloaded and interpreted using a windows EOL/EOF way. Should make sure to be formatted using  UNIX EOF/EOL way.
I.e. the Notepad++ way was the golden solution:
Solved it trough Notepad++.

Go to: Edit -> EOL Conversion -> Unix.

we might want to edit the description or is there even an automatic way to deal with it?

Well, actually the file is UNIX EOF/EOL formatted. You may want to check your local git settings regarding the end-of-line conversion. Git clients on Windows machines tend to automatically convert LF to CRLF when cloning a remote repository.

good advice, thankx

To prevent the shell script from being converted on WIndows machines I added a .gitattributes file to the repo with one rule:
*.sh text eol=lf

Please, try to clone the project, again, and check if the shell script has LF line ending.

Seems to work as expected.


clairvoyant: init at 3.1.2

Description of changes
Adds clairvoyant, a magic 8-ball like fortune teller.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks good and it appears to work correctly.
@michaelgrahamevans Could you please update this PR to use the new by-name structure? See https://github.com/NixOS/nixpkgs/blob/c818613d0c826e83153937b93691174f8763979f/pkgs/by-name/README.md
@ofborg build clairvoyant


Are you open to suggestions about the GUI and features?

Hi,
I love this Q-Translate alternative and I am starting to get used to it... I think this can be much better than Q-Translate which seems more like abandonware at this stage...
I would like to compile some ideas about how I think this can borrow some of the great features and what could increase productivity and user-friendliness, but I don't know if you guys are open to suggestions...

I'm always open to suggestions!
I try to keep GitHub pretty on topic, so only content directly related to features, bugs, and development. I also have a forum for the project where posts of many kinds are encouraged:
https://community.libretranslate.com/c/argos-translate/5


Lots of new Layer features;

Add Layer:setCurve for curved layers.  Curved.  Layers.
Add new sphere and cube layer types (existing layers are quad layers now).  cube layers are cubemap textures, and sphere layers are equirectangular images.  These are mainly intended to be used for backgrounds that have higher sampling quality, more stable tracking, and don't need to be re-rendered every frame.  Currently sphere/cube layers always render underneath the main layer.
Remove Layer:get/setViewMask.  Instead, there's a stereo flag in newLayer, which will create an array texture and put each layer in the corresponding eye, just like how the main layer works.  This works for all layer types, so you can have stereo cubemaps and stuff.
lovr.headset.setLayers takes a main key that can be used to disable the main layer, which can be useful for overlay apps that don't need to render any 3D content.
There is a new static flag in newLayer which can be used for static content.  The layer can only be changed once, but it uses a lot less VRAM.
There is a new transparent flag in newLayer.  Disabling transparency may improve performance slightly.
Add Layer:get/setColor, so you can change a layer's color or fade it in/out without rerendering it.
You can initialize a layer from an Image/Texture/filename, or a table of images/filenames.
New HeadsetFeatures: layerCube, layerSphere, layerCurve.
Default errhand disables layers now.

Should cube/sphere layers be named cubemap and equirect instead?  It's more clear but less cute.
Should transparent default to true or false?
Premultiplied alpha is not working right.  Also, does it need to be configurable?

Could add Layer:get/setColor via XR_KHR_composition_layer_color_scale_bias.
Could expose sampler settings for layers via XR_FB_swapchain_update_state_vulkan, but it's kinda niche, may want to wait until someone needs it.  Same for mipmaps I guess.

Why differentiate between cube and sphere layer type in API, is there anything user-facing that makes it worth to expose it? I imagine I would expect to pass in the equirect or cubemap texture and the layer would internally figure it out.
Would it be possible to fetch the underlying Layer texture after the init? Not really that important but nice to have.

LayerType needs to be exposed because if you create a Layer from a 2D texture, lovr doesn't know if you want that to be a quad or a sphere.  And if you create an empty layer with a width/height, it isn't clear what type of layer that should be.  There's already some auto-detect logic for textures to make it easier, though.  For example, you can do lovr.headset.newLayer(cubemapTexture) and it will make a cube layer.
Regarding the texture: Yes, you can call Layer:getTexture to get the texture, but note that it's backed by a swapchain (ringbuffer of textures) so it returns a new (blank) texture each frame, expecting you to render to it.  Layer:getPass is also a convenience function that will return a Pass that renders to the Layer.

I'm actually trying out a simpler API on the background-layers branch where there is just a lovr.headset.setBackground(Image|Texture) function used to set a single cube/sphere background layer, and the Layer object is just used for quad panels now.  It means that background layers are a little bit less flexible, but it simplifies the Layer object immensely.


Fixed systemctl command name typo

System testing team will find this bug and report it. I think we should create rc2 with this fix in it. @theotherjimmy what say?

I think we should include this change in RC2, and we should wait a bit to see if they find anything else. That way we don't make a ton of release candidates.


Uncaught SyntaxError: await is only valid in async functions, async generators and modules

(Firefox)

Have the same problem. Also on Firefox
Uncaught SyntaxError: await is only valid in async functions, async generators and modules
But additionally there are hundreds of warnings saying fetch failed:
Source map error: NetworkError when attempting to fetch resource. Resource URL: https://abs.twimg.com/responsive-web/client-web/shared~loader.DMDrawer~bundle.ReaderMode~bundle.DirectMessages~bundle.DMRichTextCompose~bundle.TweetMediaDeta.26b9201a.js Source Map URL: https://ton.local.twitter.com/responsive-web-internal/sourcemaps/client-web/shared~loader.DMDrawer~bundle.ReaderMode~bundle.DirectMessages~bundle.DMRichTextCompose~bundle.TweetMediaDeta.26b9201a.js.map
OS: MacOS
CPU: ARM64 / aarch64
Browser: Firefox-Developer-Edition

Same error as well but am running via Node.js

In order for this to work on firefox besides wrapping it on an async function like @azrogers points out is necessary to replace navigator.userAgentData (which it's not supported) with something like navigator.userAgent but for those who just want to run the script you can replace the line that starts with var ua = with:
var ua = "Mozilla/5.0 (X11; Linux x86_64; rv:121.1) Gecko/20100101 Firefox/121.1"; or whatever user-agent your browser has.

In order for this to work on firefox besides wrapping it on an async function like @azrogers points out is necessary to replace navigator.userAgentData (which it's not supported) with something like navigator.userAgent but for those who just want to run the script you can replace the line that starts with var ua = with: var ua = "Mozilla/5.0 (X11; Linux x86_64; rv:121.1) Gecko/20100101 Firefox/121.1"; or whatever user-agent your browser has.

Unfortunately this doesn't fix it in FireFox 123.0.1 x64 Windows 10

In order for this to work on firefox besides wrapping it on an async function like @azrogers points out is necessary to replace navigator.userAgentData (which it's not supported) with something like navigator.userAgent but for those who just want to run the script you can replace the line that starts with var ua = with: var ua = "Mozilla/5.0 (X11; Linux x86_64; rv:121.1) Gecko/20100101 Firefox/121.1"; or whatever user-agent your browser has.

Unfortunately this doesn't fix it in FireFox 123.0.1 x64 Windows 10

Are you sure the problem is the user-agent string? Try changing the same line to: var ua = navigator.userAgent; it should work.

For me it worked using an IIFE, see here.
(async function main () {
    // Paste the entire code here
})();

I tried the user agent thing and it still broke, but wrapping it as described in LoLei's post seems to have done it

Ok let me tell you with node it just didn't work.
If you want it to work

wrap it in async like both azrogers Pull request and LoLei said
not sure if necessary but you can find your useragent and just paste it in the variable like schdie said (it should be the user agent of the browser you used to connect to your twitter account)
open the developer console on your browser and drag/drop the main.js file there (you will see all the code). I've never done it in years since I usually don't use js standalone applications so I was really confused when it didn't work on node but it make sense since it need the cookies too to work and I think this was not made to read a cookie file.

I'm deleting all my tweets right now (I had to request an archive like 2 days ago, I hope I did it right since tweets.js files was the only one requested from the archive... I will update this answer when it finish.
Still a great free tool so I cannot really complain, redact only work if you got under 2-3000 tweets for free... Anything else just ask for money. I just want to quit twitter because after musk got it, he turned it into garbage and I have to delete my tweets now because they want to use data for their AI. I don't need a really complex tool like redact, just a one time use... that's why I like that there is this tool that does the same things... it is just not updated to work but like you can see there is ways to solve it.


NuGet Package should include PerceptionDevice.dll

The NuGet package here should include PerceptionDevice.dll:
https://www.nuget.org/packages/Microsoft.Azure.ObjectAnchors.Runtime.WinRT/
Microsoft.Azure.ObjectAnchors.dll depends on PerceptionDevice.dll:

dumpbin /dependents Microsoft.Azure.ObjectAnchors.dll
PerceptionDevice.dll
(among other dependencies)

When building an Azure Object Anchor project on a build server, the remote machine does not have PerceptionDevice in any binary search path, so Microsoft.Azure.ObjectAnchors.dll will fail to load and the build fails.
I can workaround this by manually copying PerceptionDevice.dll from the Holographic Remoting NuGet package:
https://www.nuget.org/packages/Microsoft.Holographic.Remoting.OpenXr/

@dfields-msft

PerceptionDevice.dll is part of the Windows OS. Can you elaborate on the failures you're encountering? Redistributing the Remoting version is not an appropriate solution since that version is specifically tailored for Remoting purposes.

@fieldsJacksonG what specific Windows OS is the "build server" running? Why does the build process involve loading Microsoft.Azure.ObjectAnchors.dll and its dependencies?

Closing - this is more of a quirk in the build process for the engine building the project.


Fix/actionmenu css prop type error

resolves #1789
Notes: https://docs.google.com/document/d/19FQJzP9QaHDRXYbjkhL0lR60sK5TGPAc4_f7DcEpmUo
Last two WIP commits are for components that use old Polymorphism approach and VerticalTabs and ActionMenu and If you look at the ActionMenu stories you'll see new polymorphic type error.

@jaketrent please re-review this and the linked doc that has more notes.


Overriding decimalfield_kwargs on BaseOrder model has no effect

Changing the decimalfield_kwargs in subclass has no effect after the model has been materialized. I had this issue before and till django 1.7 was easy to override the field attributes of the superclass with a decorator or other python appropriate methods.
There is also this django ticket opened for the very same issue.
I'm stumbled into this issue and the only good exit I'm seeing now is to remove the decimal fields from superclass and add them into subclass.
Any other approaches?

oh, haven't been aware of this. Well then we should move the decimalfield_kwargs into shop/settings.py, so that it becomes overridable.
Do you have a better name for it?

That will not solve the issue, because once the model becomes concrete, the field descriptors are not being overwritten even the arguments are changed.
What if we remove the decimal fields from shop models and explicitly ask to be added on subclassed models with desired properties?

but if we can override those decimalfield_kwargs  through settings.py, what's the point of making them overridable?


check if target command handling can resolve target

This pull request resolves  #2093 which will allow several AggregateMember collections of the same type. I check if CommandHandlingMember can resolve target and also which exception should be thrown.

Hi there, @srmppn. I am assuming something went wrong with your PR here.
Hence I'll mark the issue as a "won't fix."
Be sure to come back if you still feel there is merit in these changes.

Sorry I though it was going to create pull request on my forked repository. A few days ago, I did ask the question on the AxonForum and I found the solution that you suggest on #2093 . So I though it was really interesting to implement this feature. I'm not sure if there're still a bug so I closed this pr at first. I will try write more tests and pr again.

So I found that AnnotatedAggregate only check if CommandMessageHandling can handle incoming command. Since abstract aggregate member may have the same type of CommandHandler thus I check if its childEntity can resolve the command target or not.

Thanks for this, @srmppn!
I want to ask you to add a description to this issue.
That'll prove helpful for any reviewers on the ticket.
Added, it will provide the right level of documentation for future reference.

Hi @srmppn ,
there was something bugging me about the approach, but I couldn't really point at the real issue. I think I have now found it.
You have added a method "canResolve" to the CommandMessageHandlingMember. It felt a little bit out of place there, since the member itself doesn't "resolve" anything. It either has a definition that can handle the given message or it doesn't.
The ChildForwardingCommandMessageHandlingMember is actually one that should be able to resolve the child entity state for any command handler.
My suggestion: instead of adding this method to the CommandMessageHandlingMember, we could create a new interface StatefulCommandMessageHandlingMember which has a canResolve method that indicates whether the handler is in a state where it can currently accept the command. Then, the unwrap method can check for that interface and call the method. If that interface is not implemented, it should accept the handler as a suitable candidate.
What do you think?

Ok fixed following your suggestion, ready for the next review 👍

@srmppn, don't forget to sign the CLA. It's in place to protect both you and us from potential misdoings. Should be an easy click and verify with your GitHub account.

Fixed the date and signed the CLA, ready for the next review 👍

I signed the CLA already, but it's still pending not sure why. I will find a way to fix it soon.

This might occur if the email you've used to sign of the commits isn't present in your GitHub account, actually.

You're right, my previous commit uses different email address. how should I fix this? I searched on google they recommend me to create a new branch, should I go that way?

You might be able to just add the email in your Github profile? Not sure that works, but you can easily link multiple email addresses to one Github account.

My previous email that I used on those commits is already expired (it's a student account that I got from my university and they removed it after I graduated) so I'm not be able to verified that email so unlucky.

I suggest you change the author of the commits, in that case. The CLA is a legal document used to protect both you and us, but we need to be able to verify that you made these commits and intended to contribute them to Axon Framework under the Apache 2 license. It also guarantees that we won't hold you liable for any bugs. So I guess it's a win-win.
I found this page that described how that can be done:
https://www.deployhq.com/git/faqs/update-author-committer-multiple-git-commits#:~:text=Update the author details of historical commits&text=You'll then be presented,commits you want to change.&text=Check through the commits in,enter to apply the changes.
You will have to force-push the changes to your repository and maybe open a new PR. Not sure, actually....

Ok the CLA has been fixed 👍 . Thank you for the help and review.


Should this work with Cake 1.0.0 (RC1) yet?

I've added this module to our build at https://github.com/dnnsoftware/Dnn.Platform/pull/4439, but didn't see any changes in the build output.  I'm assuming it's because of the Cake version we're using, or I could just be missing what I should be seeing.  Is there a way to verify whether the tool is being applied?

Sorry to say, it is currently not supposed to work with Cake 1.x, as modules are for the most part bound to the version they were compiled against.
You can add --verbosity=diagnostic to the run, to see detailed information including loaded modules.
For a run using Cake 0.34.x it looks like:

For a run using Cake 1.0.0-rc0002 it looks like:

Sorry to say, it is currently not supposed to work with Cake 1.x, as modules are for the most part bound to the version they were compiled against.
You can add --verbosity=diagnostic to the run, to see detailed information including loaded modules.
For a run using Cake 0.34.x it looks like:

For a run using Cake 1.0.0-rc0002 it looks like:


feat(TCOMP-594):add serialize web APIs

What is the current behavior? (You can also link to an open issue here)
the web service was missing a route for encrypting data before persistance and could not handle properties migration (see https://jira.talendforge.org/browse/TCOMP-594)
What is the new behavior?
one route was added to set of existing apis, a version prefix in the url too and new content types.
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features) ?
[x] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
All urls have been prefixed with v0 and all API having a {definitionName} parameter and that take json properties as input have had this parameter removed cause the properties is enough to find definition from.
Other information:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:
Sonar results

Pull request test result: success :star:
Sonar results

Pull request test result: success :star:
Sonar results

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:
Sonar results

Hello!  I'm taking a look at the impact this PR would have on the data-stream product, and came up with a couple of comments.
Thanks for the clean up around the HTTP API.
Was the debate for making json-io mandatory closed?  I'm afraid that this PR is steam-rolling downstream products into compliance where we are not really convinced of the benefits!

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

@RyanSkraba  @sgandon  I did think the debate was pretty closed on this matter, but I'm open to alternatives that are better in the name of compactness of the serialization format. I think Seb is looking at ways to make the json io more compact. And I think we could also consider an alternative that might work with Java object graphs that have no cycles. My main interest is that no special annotations or anything else is made on the Java side and the serialization is completely automatic. If we can accomplish this with alternate technologies, I'm good with that. Does this sound reasonable?

Pull request test result: failure :x:


Move configs into pyproject.toml or setup.cfg(flake8)

This PR moves a few configs over to either pyproject.toml or setup.cfg in the case of flake8. Summary below:

isort config moved from .isort.cfg to pyproject.toml (also added recommended multi line output setting for black compatibility see here)
coverage config moved from .coveragerc to pyproject.toml (the nox cover session now installs coverage[toml] over just coverage to achieve this)
flake8 config moved from .flake8 to setup.cfg. I'm hoping they support pyproject.toml soon!

This is mainly me being a bit OCD and it doesn't actually alter any functionality so please feel free to reject if we want to keep separate files for clarity etc. 🙂

LGTM
Is the multiline setting actually necessary? I understood the isort config example as saying "use black profile for compatibility, and you can apply other options like multiline on top of that".

I'm actually not too sure it's just a habit for me at this point. It didn't seem to change anything, perhaps in some edge cases it would behave differently.
Happy to take it out if we don't want that setting?

I was curious and checked. isort has this definition for the black profile:
black = {
    "multi_line_output": 3,
    "include_trailing_comma": True,
    "force_grid_wrap": 0,
    "use_parentheses": True,
    "ensure_newline_before_comments": True,
    "line_length": 88,
}

So the multiline setting actually duplicates the profile settings.

I was curious and checked. isort has this definition for the black profile:
black = {
    "multi_line_output": 3,
    "include_trailing_comma": True,
    "force_grid_wrap": 0,
    "use_parentheses": True,
    "ensure_newline_before_comments": True,
    "line_length": 88,
}

So the multiline setting actually duplicates the profile settings.

Well TIL! Thanks for that! Guess I'd best go and drop that from all my other projects then 👀


Map query result to another query's cache

I'm using Apollo to build a production React Native app and I'm super grateful for all the great work you guys have done. Kudos!
There are a couple of things that I think could improve and I know many of them are already in the works (e.g., reimplementing loading logic in react-apollo and restructuring the design around fragments in apollo-client). It's super annoying that loading can be undefined sometimes and it's impossible to work with fragments so I'm looking forward to those changes!
There is another improvement that I wanted to mention because I'm not sure if it is in the works and I would love apollo-client to have something like it.
Imagine you have the following 2 queries:
query ($userId: ID!) {
  user(id: $userId) {
    name
    email
    posts {
      edges {
        node {
          title
          createdAt
        }
      }
    }
  }
}

query ($postId: ID!) {
  post(id: $postId) {
    title
    createdAt
  }
}

If the second query returns a post that would've been included in the users's post from the first query, there should be no network request. Currently with apollo-client, because they're different queries, the cache doesn't know any better.
I propose that we add an option to ApolloClient, similar to dataIdFromObject, called queryIdFromObject (this name is probably a bad one) that will let you map the result of a query to another query's key in the internal Redux store, with the purpose of improving the cache.
Here's how the option would be used for the example above:
const client = new ApolloClient({
  queryIdFromObject: ({ __typename, id }) => `$ROOT_QUERY.${__typename}:${id}`,
});

Potentially, this option could only be allowed for the root query (I don't see it being beneficial elsewhere) and dataIdFromObject could be used internally so that the code above could be simplified to:
const client = new ApolloClient({
  // maybe this name is better?
  rootQueryNameFromObject: ({ __typename }) => singularize(__typename.toLowerCase()),
});

Regardless, this would greatly reduce the number of trips to the API that the app needs to make.
Thoughts?
EDIT: If the server is Relay compatible, then it would be even simpler because the relevant root query would be node and/or nodes

This is an interesting idea; maybe instead of mapping a query to a part of another query, instead we should have a mechanism to a id -- so dataIdFromField or something like that.
So in this case, we'd say "the root field post with variable id=X should map to the object with id='post:X'". I'm not sure what the API for that should look like.

@tmeasday,
Yes, that would be a nice way to go about it. Here are 2 possible APIs that we could think about:

Add updateQueries to the options in client.query

This is mentioned briefly in apollostack/react-apollo#233
The API would work the exact same as updateQueries from client.mutate, except that one would be able to update queries from other query results (and not just mutation results)

Define a map in the client constructor that will map some result object (internally it will probably use its data id) to some query (most likely the root query) or some variation of this

This is what we've been discussing so far
The API could look similar to the 2 examples I have above.

Which of the 2 seems more natural? Should we expand on one over the other or should we expand on both and see which API makes the most sense?

@stubailo,
Thanks so much for implementing this! Would you mind posting a quick snippet of how the new API could be used to solve the issue mentioned above?

Great! Having this issue as well, the PR would reduce my app's network traffic dramatically. 👍

Hoping to get this done and documented before the end of the week! Things have been very busy around here because of the GraphQL Summit.

It looks like this is now documented here. Thanks for all the hard work!

Implemented in #921

Looking again at the original use case presented in the originating issue description, it doesn't look like result reducers solve this problem because the post query has a changing variable (id) and result reducers don't have a way to map the post(id: $postId) back to the internal dataId that the store uses.

@migueloller I'm not sure I understand what result reducers have to do with cache redirects?

@helfer, originally I believed that result reducers would solve the issue I mentioned above in https://github.com/apollostack/apollo-client/issues/706#issue-179112870. It looks like it's more of a cache redirect issue (as you say). Should a separate issue be opened or this same on reopened (and maybe the title changed)?

@migueloller Have you looked at #921? I think that should do what you need.

@helfer, ahh yes... Just read the docs. I initially thought #921 was for result reducers. Sorry about that! 😅


Footer bugs

FIRST:
Describe the bug
White space to the left and right of footer section of the website.
To Reproduce
Steps to reproduce the behavior:

Go to https://faceaseb.com/ACMW
Scroll down to Contact
See error

Expected behavior
A white space to the left and right of the footer section.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: Lenovo Legion Laptop
OS: Windows 10 1903
Browser Google Chrome
SECOND:
Describe the bug
A unnecessary contact us in the footer section.

To Reproduce
Steps to reproduce the behavior:

Go to https://faceaseb.com/ACMW
Scroll down to Contact Us section
See error

Expected behavior
An unexpected contact us line above the contact number.
Screenshot

Desktop (please complete the following information):
Lenovo Legion Laptop
Windows 10 1903
Google Chrome

Merged #139 with #138

Issue fixed. Will be resolved once new code is updated

Issue fixed. Will be resolved once new code is updated

@PriyaaIyer The white space to the left and right of the footer section continues to exist.


Faild to resolve import "vertx"

Is this problem caused by the nodejs version? The nodejs version of my project is v20.14.0

I also have the same issue. Is there any fix for this ?


Jobs: DNC UI

Combo Timer
Feather Guage
Esprit Guage(change color above 80, for avoiding filled while dancing)
Standard Step Cooldown
Technical Step Cooldown & Duration
Flourish Cooldown & Duration(remain time of procs, for avoiding too many insert makes proc fade.)

Sorry, I promise I haven't forgotten about this, but I am a little distracted trying to look into some of these TEA bugs I created with the output strings change.  I will try to get to this in the next few days.

Thanks for all the changes!


consensus events

"round event" doesn't have "consensus" field, if we want to know consensus state we can check which events are contained in round.receivedEvents in the "assign round" func.

Hey,
Sorry but I don't understand what the issue is about.
Is this a question about the consensus algorithm?

maybe I have a mistake but for my opinion, we cant know if event reaches consensus by field:roundEvent.Consensus because in babble round event contains just "witness,famous".I  suggested new way to check if event is contained in consensus events.

Thanks.
Yes you are right.
That line can be deleted, and replace with a check in ReceivedEvents.
Feel free to create a PR :)


labhub.py: Add eligibility condition

Add eligibility condition where in a newcomer
can not be assigned to an un-labelled issue
Closes https://github.com/coala/corobo/issues/232
Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for
botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

ack 7c32609

@rultor merge

@rultor merge

@meetmangukiya Done! FYI, the full log is here (took me 2min)


Thermometer

I have the govee_lan API setup and I am able to control my lights and plugs.  But I would like to see the govee thermometers I have installed as well.

Just installed the pool thermometer, same issue... Every help is welcome!


trace-cmd: Fix build by adding docbook_xsl dependency

Gets rid of this build error:
make -C /tmp/nix-build-trace-cmd-2.5.3.drv-0/trace-cmd/Documentation all
      ASCIIDOC            trace-cmd-hist.1.xsl
*********************************
** No docbook.xsl is installed **
** Can't make man pages        **
*********************************
Makefile:59: recipe for target '/tmp/nix-build-trace-cmd-2.5.3.drv-0/trace-cmd/Documentation/trace-cmd-hist.1' failed

Thank you!


ImportError: cannot import name 'NewsApiClient'

Unresolved reference 'NewsApiClient' when attempting to import the client

I m also facing the same error on Ubuntu 16.04 pip3!

Installation error occurred while installing with anaconda prompt.
command::"conda install -c kvedala newsapi-python" gives an error

from newsapi.newsapi_client import NewsApiClient

This worked for me. Thanks, man!

brij1823's method worked for me!

You have to install from newsapi-python not newsapi

I just had this error too.
ModuleNotFoundError: No module named 'newsapi'
I managed to get it working by running this command in my main django folder.
pip install newsapi-python

You have to install from newsapi-python not newsapi

thanks , it work for me

brij1823's suggestion worked, awesome thank you!
cli install:  pip3 install newsapi
notebook command: from newsapi.newsapi_client import NewsApiClient

Use this ,it may work:
from newsapi.newsapi_client import NewsApiClient

It worked thank you.

if you ever get this error try: from newsapi import *
it will import everything.
just make sure right pip: pip install newsapi-python


[Errno 2] No such file or directory: '/tmp/Payload/whiteoutsurvivalcn.app/SharedFrameworks/libloader.dylib'


validator/test: restore nimbus interop configs

fix #4454

@q9f What's the purpose of this nimbus interop test and why is it relevant for v1.0.0?

I disabled it on Friday in #4451 because it was based on Kiln and just want to reenable it to ensure we have it in place. It's now based on Ropsten.


fix: meltano install --parallelism error

The update to the tests should prevent another regression like this.
Closes #7370

@WillDaSilva - Thanks so much for tackling this!
Much appreciated. 🙏


puppet: Document that upgrades from Git require 4GB.

The step of rebuilding static assets using webpack requires more than
2G of RAM.

For the thread, this is being discussed here: https://chat.zulip.org/#narrow/stream/3-backend/topic/webpack.20memory.20usage/near/1311605

Merged, thanks @alexmv!  Can you also backport to the 4.x branch?

Backported.


Studio fails to generate for Async API version 3.0.0

Describe the bug
Studio web page offers option to generate code or documentation. Generation fails for async.api: 3.0.0 versioned specification
How to Reproduce

Open https://studio.asyncapi.com
work with default document or pick one of standard templates
Open the menu options for active a2s document
select option to generate code or documentation and indicate you want html website (as easy as it gets)
this results in error that 3.0.0 is not supported

Screenshots

Link to GitHub repository with project that has issues

https://github.com/asyncapi/studio master

Expected behavior
A zip package that brings same content as in right-hand side of studio page (as produced from a v 2.6.0 example)

Investigating, looks like https://github.com/asyncapi/server-api is not fully supporting V3
cc @smoya

@smoya I see many pending PRs https://github.com/asyncapi/server-api/pulls/asyncapi-bot?page=1&q=is%3Aopen+is%3Apr+author%3Aasyncapi-bot
I think merging the PR could fix this.

@Amzani There is an issue opened for giving full support to v3 in server-api https://github.com/asyncapi/server-api/issues/294

Still Relevant.


Bruno CLI returning unsupported when running a request with a specified client certificate

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
I found 2730, which says it should be possible to provide the CLI with certificates. But for me it is not working at all. When I make the request (or try to) the cli shows me
> bru run --env mycollection
Running Folder Recursively

GetBearerToken (unsupported)

The moment I take out the clientCertificate from bruno.json, the request is executed
GetBearerToken (403 Forbidden) - 591 ms
   ✕ assert: res.status: eq 200
      expected 403 to equal 200
   ✕ assert: res.body.token_type: eq Bearer
      expected undefined to equal 'Bearer'

Is there any plan to support this? What is missing for this to work in the CLI? I would think everything is there, maybe my configuration files are wrong?
Thanks for all the awesome work, Bruno is an amazing tool and the more I work with it, the more I like it!
.bru file to reproduce the bug
{
  "version": "1",
  "name": "mycollection",
  "type": "collection",
  "ignore": [
    "node_modules",
    ".git"
  ],
  "clientCertificates": {
    "enabled": true,
    "certs": [
      {
        "domain": "ssobroker.domain.com",
        "type": "pfx",
        "pfxFilePath": "path/to/cert.p12",
        "passphrase": "***"
      }
    ]
  }
}

Screenshots/Live demo link
My GetBearerToken request:
meta {
  name: GetBearerToken
  type: http
  seq: 1
}

post {
  url: https://ssobroker.domain.com:10443/as/token.oauth2
  body: formUrlEncoded
  auth: none
}

body:form-urlencoded {
  grant_type: client_credentials
  client_id: {{ssoClientId}}
  scope: {{ssoScope}}
}

vars:post-response {
  token: res.body.access_token
}

assert {
  res.status: eq 200
  res.body.token_type: eq Bearer
}

Using key and certificate on its own fixed it, so I guess only keystores currently are not supported in CLI


fix(ekf_localizer): update predict frequency with measured timer rate

Related Issue(required)

fix https://github.com/autowarefoundation/autoware.universe/issues/398
Description(required)

ekf_localizer fails when the tiemrCallback is not triggered at a proper frequency due to the following reasons.

high CPU utilization.
low clock rate #398

Imporove performance in these conditions by updating ekf_rate with the measured tiemrCallback rate.
Review Procedure(required)

Check that localization does not fail at low clock rate.

I confirmed it with the same param to https://github.com/autowarefoundation/autoware.universe/issues/398 predict_frequency:50 , clock_rate:20
https://user-images.githubusercontent.com/39142679/154258185-9f6a7a85-f9b4-4cee-8f97-ab5a25706074.mp4

Check that localization does not fail  at a sufficiently large clock rate

I confirmed it with predict_frequency:50 , clock_rate:100

Check if the code is ok.

Related PR(optional)

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read commit-guidelines
[x] Assign PR to reviewer

If you are adding new package following items are required:

[ ] Documentation with description of the package is available
[ ] A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@kosuke55  I'm going through in detail, but let me make sure. I've tried rosbag testing many times with several clock speeds but never faced this issue. Is the cause a specific PR recently merged?

@yukkysaito @YamatoAndo  This issue is caused by a very low Hz of the /clock topic. In my feeling, this is just a clock topic hz issue, and we don't have to fix the applications. If we should fix this, we need to fix all modules triggered by the clock topic. What do you think? (Correct me if I'm misunderstood.)

@TakaHoribe
Even if the clock topic is normal, the ekf timer does not always run at exactly 50Hz due to high CPU utilization.
So I think that ekf_dt_ should not have a fixed value.

@YamatoAndo Ahh, that makes sense to me.

Then it'd be better to change the description of this PR. The purpose of this fix is to improve the performance when the tiemrCallback is not triggered at a proper frequency, not for the clock_rate problem. Actually the issue https://github.com/autowarefoundation/autoware.universe/issues/398 is not an issue to me.

@kosuke55 Thank you for your work. The code looks good to me. Please go ahead if it is ok for @YamatoAndo


Added [Modded] to game name

[Modded] is visible to vanilla clients only, it is replaced with [M] for modded clients

We should add user control over the tag getting added to the name, otherwise look good.


Quality of score / suggestions / warnings

Hi,
I was testing my implementation and found out something strange.
Password: johnwick1233
Score: 4 / 4
guess times (10  / second): centuries
match sequence: [passwords, lastname, date]
Suggestions: no suggestions
Warning: no warnings
Same password reduced by last character is pwned as well (johnwick123)
Password: johnwick2022
Score: 3 / 4
guess times (10  / second): 1 year
match sequence: [passwords, lastname, recentYear]
Suggestions: no suggestions
Warning: no warnings
Password: johnwick2030
Score: 4 / 4
guess times (10  / second): centuries
match sequence: [passwords, bruteforce]
Suggestions: no suggestions
Warning: no warnings
Password: fuckputin2022
Score: 3 / 4
guess times (10  / second): 10 months
match sequence: [passwords, wikipedia, recentYear]
Suggestions: no suggestions
Warning: no warnings
Password: johndoe1233
Score: 3 / 4
guess times (10  / second): 4 months
match sequence: [passwords, date]
Suggestions: no suggestions
Warning: no warnings
Password: sunnyflower12
Score: 3 / 4
guess times (10  / second): 4 months
match sequence: [passwords, passwords]
Suggestions: no suggestions
Warning: no warnings
Password: sunnyflower12
Score: 3 / 4
guess times (10  / second): 4 months
match sequence: [passwords, passwords]
Suggestions: no suggestions
Warning: no warnings
Password: sun.flower123
Score: 3 / 4
guess times (10  / second): 2 years
match sequence: [bruteforce, passwords, sequence]
Suggestions: no suggestions
Warning: no warnings
Password<EMAIL_ADDRESS>Score: 4 / 4
guess times (10  / second): centuries
match sequence: [bruteforce, passwords]
Suggestions: no suggestions
Warning: no warnings
Password: john@netflix
Score: 3 / 4
guess times (10  / second): 4 months
match sequence: [firstnames, wikipedia]
Suggestions: no suggestions
Warning: no warnings
Password: example@gmail
Score: 3 / 4
guess times (10  / second): 1 year
match sequence: [bruteforce, wikipedia, commonWords]
Suggestions: no suggestions
Warning: no warnings
Password: mark&olivia
Score: 3 / 4
guess times (10  / second): 5 months
match sequence: [passwords, bruteforce, passwords]
Suggestions: no suggestions
Warning: no warnings
I think all of above passwords are weak, if not very weak.
I think the score is much too high for that kind of passwords.
I think that warnings and/or suggestions should show up for all of them.
The most important here is scoring, score 4/4 suggesting that password is at least great.
"johnwick2030" got 4/4, but max score should get password like "f6376c03-4#0D78-11c7@35d94-79a3df2#314Fd63@s73GgM!!"
I guessing that most of developers using zxcvbn-ts in their software are using scoring to give feedback to users how strong or weak are they passwords. If they give the same feedback for both above passwords, that is nearly clear that user will think that passwords are both great. But they are not strong on the same level, not even close for first one to second one.
Im thinking that score scale should be 0/10. All of the above password should left at 3/10 or 4/10.
Additional password score should be based on length, number of special characters, number of numbers, number of sequences (and avg length of sequences).
I think that scoring 7/10 and above should be impossible for passwords which can be remembered by human. That will show to users that they no need a great password to be secure, but if they use a best password managers to generate 10/10 password for them, they can be sure that they do everything what they can do if is about of creating passwords.
I guessing that changing scale of score, and adding additional points for passwords based on their length, used special characters, numbers etc should be not that hard to do (but I just guessing) and after that library will benefit a lot.
@MrWook What do you think? Is that even possible?

Hey thanks for the comment!
i see why you think that a pwned password with only one more character is weird to jump from 0 to a 4 but the problem is you can't use the levenstein distance with the Have I Been Pwned api because the passwords are encrypted and you only check against this encryption and not the real password.
I get why you think those passwords seem to be "weak" but a password isn't strong just because they have a special character, a number, an uppercase letter etc. For example P4$$w0rd has everything it needs but its worthless
This library takes some attack pattern from hackers and formed it into a scoring.
One could change the scoring to 1-10 instead of 0-4 but it wouldn't change the outcome because johnwick2030 would still have the same guess count which is the base of the scoring.
From the code:
    const DELTA = 5
    if (guesses < 1e3 + DELTA) {
      // risky password: "too guessable"
      return 0
    }
    if (guesses < 1e6 + DELTA) {
      // modest protection from throttled online attacks: "very guessable"
      return 1
    }
    if (guesses < 1e8 + DELTA) {
      // modest protection from unthrottled online attacks: "somewhat guessable"
      return 2
    }
    if (guesses < 1e10 + DELTA) {
      // modest protection from offline attacks: "safely unguessable"
      // assuming a salted, slow hash function like bcrypt, scrypt, PBKDF2, argon, etc
      return 3
    }
    // strong protection from offline attacks under same scenario: "very unguessable"
    return 4

This means if we would change the scoring we would add more if statements between and at the beginning. Of course one could say that the hardware is getting better and better which means 1e10 isn't nearly as good as 2012 when the code was written but that is something else.
Every password can be cracked over time so the only scoreable value is the guess count. Just because a human can remember the password doesn't mean its a bad one. For example if you use a whole sentence its a good password too.
Feel free to checkout the talk from Daniel Lowe Wheeler the original author of zxcvbn https://www.usenix.org/conference/usenixsecurity16/technical-sessions/presentation/wheeler it has a good explanation about this topic.
So i think the scoring change wouldn't change a thing so thats a no on my site.
Adding matchers for "passwords based on their length, used special characters, numbers etc" it's a no from my site too because that is a very old paradigm that doesn't really fit in our time as you can see in the presentation.
BUT that just means that i won't add them to the core library. Feel free to create you own custom matcher and score it as you seem to be right.
We already had a discussion for it in here https://github.com/zxcvbn-ts/zxcvbn/discussions/15
So i added custom matcher. In the documentation is an example for a minLength matcher https://zxcvbn-ts.github.io/zxcvbn/guide/matcher/#custom

I will close this issue for now because of inactivity. If there are other question please open a discussion


Example advanced forms

HI,
I set up an example for advanced forms. This is not working yet, the custom controls don't show up for obscure reasons, but the codebase is there.
I also provided some very basic controls for objects and database item selection. If we manage to write cleaner version, I think including them into the core libs would be cool, as they would allow to handle Objects, Arrays and foreign keys out of the box in the SmartForm.
This example is related to this issue:
https://github.com/VulcanJS/Vulcan/issues/1863

Interesting to see, and to be able to compare a more holistic solution to how I myself also set up ArrayFields =)

Oh nice. Could we also find a way to fit in field-specific data loading? Maybe for the customerId field?
http://docs.vulcanjs.org/forms.html#Field-Specific-Data-Loading

Hi,
You can pass a fragmentName if you rather need a custom fragment to fill the DataSelectForm, does it match your need ?
I fixed the schemas but when trying to send the form I got an error {"id":"app.operation_not_allowed","value":"check"}, I am not logged in but the guests group is allowed to create objects.
Also, as I pointed out on Slack I can't load the components using Components.ObjectForm in the schema, Components === {} on the server though the components are correctly imported.
Thanks for the feedback, I'll try to improve the example when I have a bit more spare times, I may have another project with Vulcan in the weeks to come that is mostly enhanced forms.

Now that I've had a better look at the code, we can drastically simplify DataSelectForm using field-level data loading since we're loading all customers anyway.
On the other hand, doing selective loading of customers based on the user's input would be a great feature to have. But it might make the example a bit too complex…?

Hi,
I think this commit will allow document creation in the example. Guests were not allowed to create new document using the default mutations, even with the correct permissions, this commit fixes it.
To my mind the DataSelectForm is indeed meant for lazy loading, because you can't tell the collection size at first, I just did not set up because well, I am the lazy one. React-select seems to have some features to make this easier.
I think it's okay even if it makes the example a bit complex, as long as improvements concern best practices or issues that you encounter as soon as you're coding a real life app like loading data only on demand.


fix: change position of scrollbar

References DM-1993
Motivation and context
Prevent overlapping scrollbar and facets when user is scrolling.
Before
[Describe the current behavior and / or add a screenshot of the current state]
After
[Describe the new behavior and / or add a screenshot of the new state]
How to test
[Add a deep link and instructions how to verify the new behavior]

I have created new one with valid branch name for release


Add test stage

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Adds a test stage to the pipeline that lets the user execute tests using VI Tester and the VeriStand Custom Device Test Tools
It does not accomplish

Documenting how to use the test stage
Using any other test tools besides the VI Tester

Why should this Pull Request be merged?
With this, users can add testing to their pipeline which will allow for higher quality custom devices to enter the VeriStand open source ecosystem.
What testing has been done?
The test stage has been implemented and tested using a mock custom device. It has executed a test that launches VeriStand and deploys a system definition and has a dependency on the VeriStandTestCase.lvclass as well as one that does not  have a dependency on this class.
It has only been tested with a deployment of VeriStand on the local host.

@SimonRPSM, FYI

Related to this issue

Check list from @buckd review

[ ] Remove UTF Test capabilities
[ ] Change toml test path variable to test_path
[ ] Change groovy test path variable to testPath
[ ] When performing VI Test, add a -LogFilePath to somewhere in $WORKSPACE like what exists for other lvBuild scripts.
[ ] Delete src/ni/vsbuild/steps/PlaceholderStep.groovy
[ ] Re-add this.vi = mapStep.get('vi') line to src/ni/vsbuild/steps/LvRunViStep.groovy
[ ] docs/buildTOML.md should be updated with the information for running the tests added by this pull request.

[ ] Add changes from buildToml.md to Toml Help.md and delete buildToml.md
[ ] Remove white space
[ ] Update cloneRepo.groovy to accept a directory path


Load Rampup

Is your feature request related to a problem? Please describe.
Most load tests utilize some kind of rampup/sustained load technique to accurately model user behavior so your service is not being blasted from the start of the test.
Describe the solution you'd like
Would it be possible to have a ghz test with stages so I could rampup up from 0 to x concurrency for y duration, then sustain x concurrency for z duration?

Hello thanks for the feature.I agree it would be useful feature. This has been somewhat inquired about before (#111), however it is not an insignificant amount of work. I will try and get to it at some point in the future.

Hello, I think what's requested here should be available in 0.70.0.


Addition of Score Keeper

This is a small JavaScript-based scorekeeper project simulating a ping pong game.

hi @ghostmkg can u please assign this task to me under hacktoberfest label


Add support for cluster icons for drivers that are not built in

For external drivers, the Ember UI injects a stylesheet from the driver which contains a class to change the icon to a custom one, e.g.
.machine-driver.aliyun {
  background-image: url('aliyunkcs.svg');
  background-size: 60px 60px;
}

this is loaded thus in the Ember UI:
        const driverSchema = get(this, 'globalStore').getById('schema', configName.toLowerCase());

        if ( uiUrl ) {
          const cssUrl = proxifyUrl(uiUrl.replace(/\.js$/, '.css'), get(this, 'app.proxyEndpoint'));

          loadStylesheet(cssUrl, `driver-ui-css-${ name }`);
        }

Can we just bundle in the images for all the drivers that exist in a default install, and not have dynamic loading for now?  The mechanism for loading external plugins is going to be very different when we get them in Vue.  And loading arbitrary CSS meant for Ember into sounds error-prone.

Yeah we can.

Internal reference: SURE-4065. We are getting reports now from people upgrading from 2.5.x to 2.6.x running into this.

On 2.6.3
Using details mentioned here

On 2.6-head commit id: d4089da


Swagger API is now OpenAPI

Looks like specification has gone through re-branding recently, and now it is OpenAPI. It also has a new web-site now: https://openapis.org/
The link to https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md and naming "Swagger API", etc. should be updated in README

@darklynx Thank you.
Took so long, because I totally missed email notification :(

:+1:


Changed codestyle to standard 🔥

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1255988...413a333. Read the comment docs.