TF v2 support for Recurrent/Bidirectional

@DronistB posted an issue on #413 showing that the new TensorFlow V2 API for Keras does not work with the existing conversion code for Bidirectional RNN layers. This occurs because TensorFlow's new RNN layers are in a different module (tensorflow.python.keras.layers.recurrent_v2). At a minimum, the following code will need to change to support the TensorFlow versions as well as the conventional Keras classes.
https://github.com/onnx/keras-onnx/blob/ff17787c393e2ce34d43185447d7354525f3ba87/keras2onnx/ke2onnx/bidirectional.py#L25-L37
Happy to take a look at resolving this when I have bandwidth.

@cjermain , thank you for raising this 👍

Thanks @cjermain,
So as I understood the problem is with my tensorflow and keras versions?
With which versions will it work?

Based on the GRU import path (tensorflow.python.keras.layers.recurrent_v2.GRU) it looks like you are actually using a TF 2.0 compatible version of the GRU -- this was not actually present in TF 1.13.1 (looking at the source code).
https://github.com/tensorflow/tensorflow/blob/v1.14.0/tensorflow/python/keras/layers/recurrent_v2.py
I'm looking into the changes needed to support these classes -- recurrent_v2.GRU breaks tests for me on 1.15.
Have you checked over your model with Netron? It is worth verifying that both the original model and the ONNX model look right.

For me, using TF 2.2.0 resolves the issues with recurrent_v2.GRU -- it seems they are handled correctly for TF > 2.0. @DronistB , are you able to convert the model using a newer version of TF?

@DronistB, I made changes in #610 which will allow TF 1.14 and 1.15 to handle the v2 capability. I would suggest upgrading TensorFlow past 2.0 if possible, since that is likely faster -- otherwise let me know if the fix works for you on the TF versions mentioned.

Thanks @cjermain,

Tried again, now performed training using:

Tensorflow: 2.3.0
Keras. 2.4.3
Python: 2.3.6

Then:
git clone https://github.com/cjermain/keras-onnx.git
cd keras-onnx
git checkout recurrent_v2_compatibility
sudo python setup.py install

Then used this script:
import os
os.environ['TF_KERAS'] = '2'
import keras2onnx
from keras.models import load_model
import tensorflow as tf
import argparse

print("Tensorflow version:" + str(tf.__version__))
# arguments
parser = argparse.ArgumentParser()
parser.add_argument('input_file', help='Input file path')
args = parser.parse_args()

# load keras model
from tensorflow.keras.models import load_model
tf.keras.backend.set_learning_phase(0)
tf.keras.backend.clear_session()
model = load_model(args.input_file)

# convert to onnx model
onnx_model = keras2onnx.convert_keras(model, model.name, target_opset=10)

temp_model_file = os.path.splitext(args.input_file)[0] + '_converted.onnx'
keras2onnx.save_model(onnx_model, temp_model_file)

to convert the hdf5 file I got
But got this error:
  File "/usr/local/lib/python3.6/dist-packages/keras2onnx/ke2onnx/bidirectional.py", line 37, in convert_bidirectional
    raise ValueError('Unsupported class for Bidirectional layer: {}'.format(op_type))
ValueError: Unsupported class for Bidirectional layer: <class 'tensorflow.python.keras.layers.recurrent_v2.LSTM'>

Thanks

Thanks @cjermain,

Tried again, now performed training using:

Tensorflow: 2.3.0
Keras. 2.4.3
Python: 3.6

Then:
git clone https://github.com/cjermain/keras-onnx.git
cd keras-onnx
git checkout recurrent_v2_compatibility
sudo python setup.py install

Then used this script to convert the hdf5 file I got from the training:
import os
os.environ['TF_KERAS'] = '2'
import keras2onnx
from keras.models import load_model
import tensorflow as tf
import argparse

print("Tensorflow version:" + str(tf.__version__))
# arguments
parser = argparse.ArgumentParser()
parser.add_argument('input_file', help='Input file path')
args = parser.parse_args()

# load keras model
from tensorflow.keras.models import load_model
tf.keras.backend.set_learning_phase(0)
tf.keras.backend.clear_session()
model = load_model(args.input_file)

# convert to onnx model
onnx_model = keras2onnx.convert_keras(model, model.name, target_opset=10)

temp_model_file = os.path.splitext(args.input_file)[0] + '_converted.onnx'
keras2onnx.save_model(onnx_model, temp_model_file)

But got this error:
  File "/usr/local/lib/python3.6/dist-packages/keras2onnx/ke2onnx/bidirectional.py", line 37, in convert_bidirectional
    raise ValueError('Unsupported class for Bidirectional layer: {}'.format(op_type))
ValueError: Unsupported class for Bidirectional layer: <class 'tensorflow.python.keras.layers.recurrent_v2.LSTM'>

Similar  error when I changed the from "Bidirectional(LSTM" to "Bidirectional(GRU"

(Same versions as above)
  File "/usr/local/lib/python3.6/dist-packages/keras2onnx/ke2onnx/bidirectional.py", line 37, in convert_bidirectional
    raise ValueError('Unsupported class for Bidirectional layer: {}'.format(op_type))
ValueError: Unsupported class for Bidirectional layer: <class 'tensorflow.python.keras.layers.recurrent_v2.GRU'>

Tried training using:

Tensorflow: 1.13.1
Keras. 2.2.4
Python: 2.3.6

And converting using:
Tensorflow: 2.3.0
Keras. 2.4.3
Python: 3.6

But again:
  File "/usr/local/lib/python3.6/dist-packages/keras2onnx/ke2onnx/bidirectional.py", line 37, in convert_bidirectional
    raise ValueError('Unsupported class for Bidirectional layer: {}'.format(op_type))
ValueError: Unsupported class for Bidirectional layer: <class 'tensorflow.python.keras.layers.recurrent_v2.GRU'>

Tried also to convert with
Tensorflow: 1.13.1
Keras. 2.2.0
Python: 3.6.9

But got this error:
site-packages/tensorflow/python/keras/utils/generic_utils.py", line 166, in class_and_config_for_serialized_keras_object
raise ValueError('Unknown ' + printable_module_name + ': ' + class_name)
ValueError: Unknown layer: Functional
Thanks

Hi @cjermain, any updates for the above comment?

Hello,
I am running into this very issue, it seems. I am trying to export a BiLSTM model to onnx, but I get the following error:
~\Anaconda3\envs\py3.7\lib\site-packages\keras2onnx\ke2onnx\bidirectional.py in convert_bidirectional(scope, operator, container)
     35         simplernn.convert_keras_simple_rnn(scope, operator, container, bidirectional)
     36     else:
---> 37         raise ValueError('Unsupported class for Bidirectional layer: {}'.format(op_type))

ValueError: Unsupported class for Bidirectional layer: <class 'tensorflow.python.keras.layers.recurrent_v2.LSTM'>

I have attached the model which I am trying to load:
bilstm.zip
And here's the code I am using:
import onnx
import keras2onnx
from keras.models import load_model
from tensorflow.keras.models import load_model

in_model = "../../data/models/master/bilstm.h5"
out_model = "../../data/models/master/bilstm.onnx"

model = load_model(in_model)
onnx_model = keras2onnx.convert_keras(model, model.name)
onnx.save_model(onnx_model, out_model)

I would really appreciate any help. Happy to help test pull requests!
Thanks

Hi,
Any updates on this issue? I've the same error.
Thanks

File "/usr/local/lib/python3.6/dist-packages/keras2onnx/ke2onnx/bidirectional.py", line 37, in convert_bidirectional
raise ValueError('Unsupported class for Bidirectional layer: {}'.format(op_type))
ValueError: Unsupported class for Bidirectional layer: <class 'tensorflow.python.keras.layers.recurrent_v2.LSTM'>

@DronistB: With my changes, the ValueError exception should occur on line 46 -- line 37 indicates you are not actually running with those changes. Make sure to install the package in a virtual or conda environment, and avoid using sudo to install Python packages. For example, here is one strategy that might help:
$ conda create --name recurrent-v2 python=3.6 tensorflow
$ conda activate recurrent-v2
(recurrent-v2)$ pip install -U onnxruntime
(recurrent-v2)$ pip install -U git+https://github.com/microsoft/onnxconverter-common
(recurrent-v2)$ pip install -U git+https://github.com/cjermain/keras-onnx@recurrent_v2_compatibility

The last line will give you my recurrent_v2_compatability branch of keras-onnx for #610, which has the fix. The main package does not have the fix yet.
@volgaone: I have run the above and successfully converted your model. I attached the original and ONNX files in the following ZIP: bilstm.zip
@davidnarganes: Once I get the builds passing for #610, we should be able to get this into the official package. Until then, you can use the above instructions to use the PR branch to bypass the issue.


always use V2 version of iiif auth services for the external service

What does this change?
Moves the getAuthService function so it can be shared and updates it to:

return both the external and active services rather than just one. (We could get away with that until now, but we are going to have to use both now in order to make restricted things available to staff https://github.com/wellcomecollection/platform/issues/5761)
~only~ prefer to return v2 external services, as these are the only ones that work (v1 external service ids return a 404). We still need to fallback to the v1 service as the presence of the service helps us determine whether to show the viewer or not.

How to test
No behaviour should change.
How can we measure success?
Gets us closer to making restricted items available
Have we considered potential risks?
No behaviour should change, so as long as e2e tests pass we should be good.

Code looks good and understood, I couldn't reaaally test as I don't know which works are restricted (is there a list?)


Added Roots-Equation-Calculator

Fixes Issue🛠

Closes #1072
Description👨💻

add an equation generator calculator for given roots. First, it will ask for the number of roots and then the user has to enter the roots, after that, the equation would be generated.
Type of Change📄

[x] New feature (non-breaking change which adds functionality)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

@sharmi4590 Just remove hyphens from title of the calculator in listing.

@Nihal4777 done with the changes

Hey @Nihal4777 Could u please look into my PR

@Rakesh9100 This PR is reviewed and can be merged.

@Rakesh9100 Could you please look into it

Hey, @Rakesh9100 Please merge the PR, as after the 31st No PR will be counted.

Hii @sharmi4590, Thank you so much for your contribution.
We really apologise for the delay caused. Don't worry your PR will get reviewed very soon within GSSoC period.

Hey, @Rakesh9100 Please merge the PR, as after the 31st No PR will be counted.


Feature/cancel forms

Thanks for the feedback @JessicaLoers ! I implemented it. Please take a look if everything is correct.


Fix Source files in localization document.

Fix Source files section in localization document, and remove {{< release-branch >}} variable due to release-1.20 branch does not exist.

/cc @seokho-son

Pinging some localization teams
/cc @kubernetes/sig-docs-fr-reviews @kubernetes/sig-docs-ja-reviews @kubernetes/sig-docs-zh-reviews @kubernetes/sig-docs-es-reviews

Thank you @shu-mutou .
LGTM :)

LGTM ✨

Page preview:
https://deploy-preview-25795--kubernetes-io-master-staging.netlify.app/docs/contribute/localization/

Thanks @shu-mutou .
/approve

@kbhawkey Thank you for your review and approve. Please take a look again. Thanks!

Thanks for your contribution @shu-mutou !
/lgtm


docs: Update docs for OVMS and model formats

Signed-off-by: Angel Luu<EMAIL_ADDRESS>
"Fixes #issue-number" or "Add description of the problem this PR solves"
Update docs to reflect the new support for Open VINO model server and its model type OpenVINO IR
Proposed Changes

/lgtm
/approve


[Bug] All Input fields are highlighed in red when selected

Description
With the latest release, 1.25, I think there's been a change to how the selected field, i.e. the field you're currently editing, in a widget is highlighted. I don't remember exactly how it was shown before, but now the highlight border box is red, making it look like there's an error, since that is how fields with errors are indicated. There is possibly a small difference in the actual colors, but it's too small to be discernible, at least to me...
This is quite annoying :wink: and thus I am reporting this as a UI bug.
The highlighting as such is thus not the issue, but rather the color. I'd suggest using a dark grey or similar, but it really doesn't matter as long as it doesn't look like the error highlight!
Steps to reproduce the behaviour:

Open an app in edit mode.
Open a widget
Select a field by clicking it.
The border box around the field is highligted. In red.

Important Details

Version: [Cloud / Self-Hosted vx.x]
OS: [e.g.MacOSX]
Browser [e.g. chrome, safari]
Environment [production, release, deploy preview]

The fields are now black :)


For Review | Too many request error - Ticket 51627

For Review
Added change to fix too many request error.
Ticket: https://www.websitetoolbox.com/tool/ticket/view/51627/qP1tTkiMA7Fp50td5eYw

Then I don't understand why you approved the pull request and asked for my
review.
Thank you,
Sandeep Sondhi
Chief Executive Officer
Website Toolbox
www.WebsiteToolbox.com https://www.websitetoolbox.com
On Mon, Aug 21, 2023 at 10:49 PM masihur @.***> wrote:

@masihur https://github.com/masihur requested your review on: #9
https://github.com/webtoolbox/craftcms-plugin/pull/9 For Review | Too
many request error - Ticket 51627.
—
Reply to this email directly, view it on GitHub
https://github.com/webtoolbox/craftcms-plugin/pull/9#event-10145785978,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOSYEWOT2PWJQSX5XFROE3XWNRO3ANCNFSM6AAAAAA3YIPRHQ
.
You are receiving this because your review was requested.Message ID:
@.***>


dep-vendored type mismatch "does not implement"

I'm starting to think this bug belongs elsewhere. If that's the case, any suggestions where I ought to file it?
What version of dep are you using (dep version)?
dep:
 version     : v0.4.1
 build date  : 2018-01-27
 git hash    : 37d9ea0
 go version  : go1.9.3
 go compiler : gc
 platform    : darwin/amd64

What dep command did you run?
So, running dep itself didn't cause this. I ran go build -ldflags='-s -w'.
-CONSTRAINTS-
github.com/aws/aws-sdk-go
svc-^1.13.50
golang.org/x/crypto
b-master
-IMPORTS/REQS-
github.com/aws/aws-sdk-go/aws
github.com/aws/aws-sdk-go/aws/session
github.com/aws/aws-sdk-go/service/s3
github.com/aws/aws-sdk-go/service/s3/s3iface
github.com/aws/aws-sdk-go/service/secretsmanager
github.com/aws/aws-sdk-go/service/secretsmanager/secretsmanageriface
github.com/pkg/sftp
golang.org/x/crypto/ssh
-IGNORES-
-OVERRIDES-
-ANALYZER-
dep
1

What did you expect to see?
Clean compilation.
What did you see instead?
$ go build -ldflags='-s -w'
# synchronizer
./main.go:118:47: cannot use s.s3 (type "synchronizer/vendor/github.com/aws/aws-sdk-go/service/s3/s3iface".S3API) as type "github.com/aws/aws-sdk-go/service/$3/s3iface".S3API in argument to s3manager.NewUploaderWithClient:
        "synchronizer/vendor/github.com/aws/aws-sdk-go/service/s3/s3iface".S3API does not implement "github.com/aws/aws-sdk-go/service/s3/s3iface".S3API (wrong type for AbortMultipartUpload method)
                have AbortMultipartUpload(*"synchronizer/vendor/github.com/aws/aws-sdk-go/service/s3".AbortMultipartUploadInput) (*"synchronizer/vendor/github.com/aws/aws-sdk-go/service/s3".AbortMultipartUploadOutput, error)
                want AbortMultipartUpload(*"github.com/aws/aws-sdk-go/service/s3".AbortMultipartUploadInput) (*"github.com/aws/aws-sdk-go/service/s3".AbortMultipartUploadOutput, error)

So I added the new dependency and didn't then run dep ensure, which is what caused the type mismatch. Sorry for the hassle.


Repeated API calls orchestration results in error response

Calling API endpoint immediately after first call results in SQLAlchemy session error response
Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:
Error response
What you expected to happen:
We should be able to call API endpoint immediately

@kumarashit and @joseph-v can we close this?

Issue analysis:
This issue is very limited to Service definition being creation. In the call to create service definition, we are updating table out of session scope. The sessionmaker for DB has autocommit=false. So there need to be explicit commit. There is another call to add service_definition and commit which will eventually commit. So we may land into this issue.
Ideal fix will be to use all update/add in session scope.
As this call is done by installer only as of now and the changes are involved too. So IMO, these changes can be done later.
@skdwriting @joseph-v @wisererik please suggest

Please mark this as a known issue and also provide the workaround for custom service definition through scripts
This needs to be handled later. Moving to backlog.

No impact on the current service definition and testing from dashboard


Clarify trip parameters non-cars

In particular time between  legs

And see leg repeats can overlap or not (especially for charging).

The approach leasing to location split might be the right one (at least reconcile that one with the one in charge/travel space occupation)


Deadlinks in Hosted runner in Actions

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
Some links are dead in https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software
What changes are you suggesting?
All links should be valid in https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software
Additional information
actions/virtual-environments#4794

PR https://github.com/github/docs-internal/pull/23973


Tasks 469-472: from MRQA and hasPart KB datasets

@swarooprm Please refer to the tasks from NLP course assignments.

Reviews: https://github.com/swarooprm/CSE576HW/pull/10

@jayavardhan3112 wondering if you can review this PR (in addition to the referenced reviews).

In task469_mrqa_answer_generation, The output for some instances is a list with duplicate values, rather than only single value,
In task470_mrqa_question_generation, please elaborate the definition
Please add the research paper link for all the tasks in the source.
Other than that I think it looks good.
Thanks

@jayavardhan3112 Thanks for the suggestions. I have updated the files as you requested.
Please review them once again. And let me know your thoughts.

@jayavardhan3112 Thanks for the suggestions. I have updated the files as you requested.
Please review them once again. And let me know your thoughts.

Looks good to me @Maitreyapatel , we can move ahead with the merge @swarooprm

Looks good, thanks!


Stop testing against HMMBase

This forces StatsBase v0.33 in the test environment, which is lower than the latest version v0.34, so we might get a different behavior of Distributions

Solved by #111


ember 2.3.0 and ember-cli-fastboot raise document is not defined error

when trying to launch ember fastboot I've got:
DEBUG=ember-cli-fastboot:* ember fastboot --serve-assets
version: 2.2.0-beta.6
Built project successfully. Stored in "fastboot-dist".
DEPRECATION: `ember-cli/lib/errors/silent.js` is deprecated, use `silent-error` instead.
DEPRECATION: `ember-cli/lib/errors/silent.js` is deprecated, use `silent-error` instead.
DEPRECATION: `ember-cli/lib/errors/silent.js` is deprecated, use `silent-error` instead.
  ember-cli-fastboot:ember-app app created; app=fastboot-dist/assets/chirper.js; vendor=fastboot-dist/assets/vendor.js +0ms
WARNING: FEATURE["ember-application-visit"] is set as enabled, but FEATURE flags are only available in canary builds.
document is not defined
ReferenceError: document is not defined
    at <anonymous>:110604:16969

and here is my env:
ember-cli: 2.2.0-beta.6
ember: 2.3.0
ember-cli-fastboot:  0.1.0
ember-data: 2.3.1
node: 5.4.0

--- update  18/01/16 13:40 ---
I've updated to 059c0adb98c5928111cdb2b63afaf1373dc6e742 (master), by ember install https://github.com/tildeio/ember-cli-fastboot.git unfortunately still the same issue.
DEBUG=ember-cli-fastboot:* ember fastboot --serve-assets
version: 2.2.0-beta.6
Built project successfully. Stored in "fastboot-dist".
  ember-cli-fastboot:ember-app app created; app=fastboot-dist/assets/chirper.js; vendor=fastboot-dist/assets/vendor.js +0ms
document is not defined
ReferenceError: document is not defined
    at <anonymous>:110604:16969

--- update  18/01/16 13:40 ---
I've no idea where / how should I start debugging it?

@cs3b Check your vendor file at line 110604 in fastboot-dist

@danmcclain thanks for pointing me in that direction.
So far I get that
First I've issue with one library that wasn't ember add-on (sweetAlert.js) and depend on document object
after removing that lib from ember-cli-build.js things move further. Next I've encounter another problem with pretender library (similar problem with document object missing):
https://github.com/pretenderjs/pretender/blob/32607c5cec7329a5eab1f91335ebb62089b96e42/pretender.js#L29
So I switch to production environment ... and now the server is starting, but I've got another error:
#...
Error while processing route: index t.default.$ is not a function TypeError: t.default.$ is not a function
# ...
  ember-cli-fastboot:server finished handling; url=/ +52ms

As it's hard to track minified js, i've got back to development mode (this time without ember-cli-mirage)
Error while processing route: index _ember.default.$ is not a function TypeError: _ember.default.$ is not a function

So it looks for me like there is no JQuery ?
In the end this lead me to package ember-body-class that was using something like this:
// ...
      const $body = Ember.$('body');
// ...

So I've also disabled this package, and run it again this time the issue was:
undefined:54304
      _emberViewsSystemJquery.default(rootElement).off('.ember', '**').removeClass(ROOT_ELEMENT_CLASS);
                                     ^
TypeError: _emberViewsSystemJquery.default is not a function
    at exports.default._emberRuntimeSystemObject.default.extend.destroy (<anonymous>:54304:38)
    at superWrapper [as destroy] (<anonymous>:33142:22)
    at <anonymous>:11902:16
    at eachDestroyable (<anonymous>:12155:9)
    at Object.Container.destroy (<anonymous>:11900:7)
    at Object.Backburner.run (<anonymous>:11275:25)
    at Object.run [as default] (<anonymous>:31176:27)
    at exports.default._emberMetalMixin.Mixin.create.willDestroy (<anonymous>:43210:36)
    at superWrapper (<anonymous>:33142:22)
    at _emberRuntimeSystemObject.default.extend.willDestroy (<anonymous>:14474:19)

and this lead me to the (bugfix made recently, available only in canary revision)
https://github.com/emberjs/ember.js/pull/12829
I will try the canary version of ember ...

after updating to
Ember      : 2.5.0-canary+551a2312
It start working well :-)
Still without ember-body-class addon, as it still raise an error:
Error while processing route: index _ember.default.$ is not a function TypeError: _ember.default.$ is not a function
    at null.addClasses (<anonymous>:67470:39)

I've assume that this is an addon issue, and I'm closing this ticket.
Of course I would be very glad if anyone could explain that to me :-) in details (why I came across so many errors).

emberjs/ember.js#12829 was cherry-picked into release and beta branches as well.  You can use any of the available branches at this point to get that fix.


Custom ColorChooserDialog not scrollable

Layout in md_stub_colorchooser_custom.xml has LinearLayout as root, thus is not scrollable.
Simple solution would be to wrap it in ScrollView.
Cheers!

It's intended to not be scrollable, I don't think it would look too good if it was.
Is there a device it gets cut off on?

Yep, on devices with small screen, and what's more important on larger ones in landscape mode.
md_stub_colorchooser_grid.xml is scrollable and looks good in both orientations.
Maybe another layout for landscape with vertical bars to the right of current color and EditText would be more appealing, but AFAIK vertical seekbars are kind of a pain to implement.

It turns out it's not as simple as just wrapping it in a ScrollView. Since it's in a dialog, measuring is a bit different. I'll keep trying different ways.

Fixed

https://github.com/afollestad/material-dialogs/releases/tag/<IP_ADDRESS>


feat: example walletconnect login flow

This demonstrates the WalletConnect login flow in the example app.
It also simplifies the wallet creation interface.

Just wanted to add that I pulled this down and tested it and everything worked as expected from JS to Android Flutter connected via a rainbow wallet.


Lower sleep times for rollinglog -f

Make it faster

why spam it?

Before it was slower than just using tail -f, this matches that speed

1000 times / s is still too much IMO. Maybe 50ms?

8ms is the fastest I could go without increasing CPU too much.

well then 50ms is a good compromise, no? 20 times / s

@phonetic112 probably the best way is to make it configurable with slow default settings?

how bout this

yes.

What is the advantages of this? It just makes the compositor laggier? No? Why make this faster. Unnecessary imo


2024-12-31_01-35-06_master-next_aws-sdk-cpp

Automatically created.

Successfully created backport PR for kirkstone-next:

#10969

Successfully created backport PR for scarthgap-next:

#10970

Successfully created backport PR for styhead-next:

#10971


2017 references instead of 2019

Windows-universal-samples/SharedContent/Templates/InstallSDKTemplates.cmd uses 2017 Visual Studio reference instead of 2019

I haven't upgraded the repo to VS 2019 yet. Note that the main readme still says 2017.

Managed to solve it quickly by changing the paths in CMD.


Index trait for HashCell

Implement the Index and IndexMut traits for the HashCell struct. The index should return the elements registered in the given cell.

With this issue, the methods try_allocate' and reallocatewill be included for the traitWriteHashGrid`.
try_allocate() takes a vector of elements with the Cardinality trait. It will try to register them to a bounding cell and will apply the periodic bounding box when it is the case. It returns a Result enum with empty Ok() or a HashGridError in case of failure.
reallocate() will visit all elements of the grid and reallocate them according to their coordinates. It returns a Result enum with Ok() or a HashGridError in case of failure.


inner_hits

Use inner_hits to only retrieve required NestedEdges

@rmagen https://github.com/elastic/elasticsearch/issues/14229


Picture is enlarged

loading picture after the picture is enlarged, size beyond the screen width

https://github.com/wasabeef/richeditor-android/issues/97


Added Supp. Figure Captions

I'm not quite sure where the text explanation that was previously in the caption section should go. I added it above the figure though.

@JC Lagarde I have seen many papers without explaining their supplementary figures, and only providing a caption. Besides, we have mentioned these figures in the main results where it was relevant. @aarmey Do we want a paragraph explaining each supplementary figure?

Codecov Report

Merging #646 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   88.50%   88.50%
=======================================
  Files          21       21
  Lines        1505     1505
=======================================
  Hits         1332     1332
  Misses        173      173

Flag
Coverage Δ

#unittests
88.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d25984...0f9f558. Read the comment docs.

@Farnazmdi you're right that the captions likely should do this. Optionally, we could include a supplementary methods section with a more detailed description.


Crashes with 44342 illegal hardware instruction

on macOS 10.15.4 (19E287)
and Maccy 0.10.0 and also 0.11.0
defaults delete org.p0deje.Maccy
brew cask reinstall maccy

Open Maccy in Finder to approve unsigned application
In terminal:
/Applications/Maccy.app/Contents/MacOS/Maccy

click the try icon. Then the terminal prints and quits Maccy with exit code 132:
[1]    44342 illegal hardware instruction  /Applications/Maccy.app/Contents/MacOS/Maccy

❯ defaults read org.p0deje.Maccy
{
    SUHasLaunchedBefore = 1;
    history = {length = 42, bytes = 0x62706c69 73743030 a0080000 00000000 ... 00000000 00000009 };
    ignoredPasteboardTypes =     (
        "de.petermaurer.TransientPasteboardType",
        "com.agilebits.onepassword",
        "com.typeit4me.clipping",
        "Pasteboard generator type"
    );
    migrations =     {
        "2020-02-22-history-item-add-copied-at" = 1;
        "2020-02-22-history-item-add-number-of-copies" = 1;
        "2020-04-18-switch-storage-to-core-data" = 1;
        "2020-04-25-allow-custom-ignored-types" = 1;
    };
    showInStatusBar = 1;
}

All binaries crashed. Removing the Library folders worked.

Please upgrade to 0.12. In order to upgrade, either install from Github if you can't start Maccy or cleanup the history by removing ~/Library/Application Support/Maccy/Storage.sqlite file - that should allow Maccy to start so you could upgrade.


use identity file for ssh connection

Hi,
I've used your hawesome docker-compose to play with kubernetes on my local machine.
I decided to share with you my little change.
I updated the way it connects to the boot2docker instance by using the machine identity file.
So we don't need to type the ssh password anymore.
Rgds,

Thanks for the PR :) Good idea, using the Machine's identity file. Makes the whole thing more convenient.
I had a couple of comments.

No problem for your comments, here's the new commit.


Add CAPI status/conditions to deployment status

Resolves #219. This PR adds a new function that fetches the CAPI status / conditions of the cluster and places them in the deployment status/conditions. To ensure the conditions are updated the controller now requeues until the CAPI cluster conditions are all true.

@kylewuolle just need to rebase to get rid of this merge commit: https://github.com/Mirantis/hmc/pull/230/commits/0635d504fd94874418e1cf426e00c9e425a0dae3 and it lgtm


2020 Q3 OKRs

The plan for 2020 Q3 can be tracked here.
At a glance, we aim to:

Keep search page drop-off rate at 25% or lower.
Reach 1500 Twitter followers.
Increase monthly Google CTR from ~2% to 2.5%.
Increase monthly users to 7k.
Increase snippet collection to 920 snippets.
Have a total of 45 blog posts published.
Have a 15% recommendation CR from snippet pages.
Move the entirety of the asset pipeline to custom tooling.
Research and prototype part of a CMS to speed up content creation.

Monthly traffic for July, 2020. Monthly users have just passed 10k!

Alexa ranking seems to have climbed up quite a bit:

SimilarWeb tells a similar story:

Search performance data for the past 28 days:

We have reached 1500 followers on Twitter. Here are some stats:

30 seconds of code was recently featured in 8 places to find helpful JavaScript Snippets. Here's an excerpt:

Due to this week's focused effort, we have reached 45 blog posts and it seems like I have a few more to write in the following weeks. We might overshoot this KR by a little bit, but that's for the best.

I'm very happy to announce that starting today, Jooble will be displaying a banner to 30secondsofcode.org completely for free (except for a backlink on one of our blog posts):

We just reached 920 snippets, 46 of which are blog posts. The only KRs left for this Q are platform-related and on track.

Recent dev.to post about 30 seconds of code:

Move the entirety of the asset pipeline to custom tooling.
Research and prototype part of a CMS to speed up content creation.

After two months of development, #135 is finally nearing release (ETA: 2-3 hours). In this PR, we decoupled the asset pipeline from Gatsby and started work on the 30s CMS infrastructure to improve content creation experience. As the changes are quite extensive, we will be releasing this feature under the v3.0.0 tag to mark the beginning of the new era of our platform infrastructure.

More than 70% of our traffic is on JavaScript blog posts, so we should keep up with that trend and add more JavaScript blog content in the coming weeks.

New Medium post

We are trending on GitHub:

Some traffic data compared to same range last week, clearly we are doing very well due to the extra publicity:

As Q3 is coming to a close and we have already hit our targets, I am going to close this issue. Q4 is already in the works and we're hoping to achieve all of our goals by the end of the year. Cheers!


TypeError: Cannot read property 'apply' of undefined

hello!  something goes awry when i run my tests using trace.  i have a branch that is runnable/testable to reproduce the problem here, using good old node test/.
this file is where it's all wired up!
ok 118 run started from new db document event
/long/path/node_modules/trace/node_modules/async-hook/patches/timers.js:50
      callback.apply(this, arguments);
              ^

TypeError: Cannot read property 'apply' of undefined

It looks like you forgot to give an function to setTimout or another timer function. Your testsuite is rather big and I have exams these weeks, so I don't have time to debug it right now, I'm very sorry.
I will get back to you after my exams on May 28.

I have debugged the problem. As suspected you are passing undefined to setTimeout, the bug in your code is here: https://github.com/MRN-Code/coinstac-common/blob/bug/trace-crash/test/models/pipeline/runner/pool/local-pipeline-runner-pool.js#L71 you write
    local: { fn: (opts, cb) => setTimeout(cb(null, compId), 1), type: 'function' },

but I suspect you mean
    local: { fn: (opts, cb) => setTimeout(cb.bind(null, compId), 1), type: 'function' },

However there is also a bug in trace as the behaviour of passing undefined shouldn't change because of trace. In node v6 setTimeout throws a meaningful error if a non-function was passed to a timer function. In node v5 it didn't throw, which is the version I suspect you are using.
I have decided to go with the node v6 behaviour, as it is the one I find most useful. However it will technically be a side effect of using trace if one uses node v5.

Fixed in async-hook v1.5.0 https://github.com/AndreasMadsen/async-hook/commit/b0f67365973a2ad6534611511446e6b4d2c4e5fe

yea you're right.  i fixed that recently, but had hence dropped trace.
thanks so much for lookin' into it.  appreciate your time.


Talented photographer section

as a customer i cant see talented photographer section on the home page based on homepage design.

@aghpr please specify what is exactly missing. I can see the talented photographers below 'shop by price'


pull request for e2e test at 11/15/2016 17:45:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


symbolic functions and no semantic interposition

What does this PR do?:

Motivation:

Additional Notes:

How to test the change?:

For Datadog employees:

[ ] If this PR touches code that signs or publishes builds or packages, or handles
credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
[ ] This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: The PR seems to be about modifying linker flags, possibly to symbolize functions and prevent semantic interposition.
📝 PR summary: This PR appears to be making changes to linker flags, presumably to symbolize functions and prevent semantic interposition. However, without any code diff or further context, it's hard to provide a more accurate summary.
📌 Type of PR: Enhancement
🧪 Relevant tests added: Not applicable
⏱ Estimated effort to review [1-5]: 1, because there is no code diff provided in the PR, hence no code to review.
🔒 Security concerns: Not applicable, as there is no code diff provided in the PR.

PR Feedback
💡 General suggestions: It would be helpful if the PR description provided more context about the changes being made. This could include the motivation behind the changes, what the changes are expected to achieve, and how they can be tested. It's also recommended to include a code diff in the PR so that the changes can be reviewed.

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


Fix: update fastapi

@akashg3627 , i test the feature on my local, and from the test case also passed
is there another way to test the feature?


Custom data set

I'm trying to train the model with a completely different dataset. I'm struggling to set the values in the config file, is there some documentation about setting them correctly or their meaning/influence?

Please check here for the config explanation.

I only have two classes, with unbalance proportion of points, and independently of how I set the config parameters after 1 or 2 epochs of training the semantic part predicts zero points for the second class. Do you know why this could be?

I'm also facing a similar issue with unbalanced points, I have 4 classes and only 1 of them is being classified.
I even tried using the WeightedRandomSampler rather than the DistrubutedSampler but I'm still having the same issue

I am also having same kind of issue. I also have unbalanced proportion of points in my datasets. I have 3 classes Leaf, stem and node. For instance, in one of my 3D model(16th model) the no .of points are as following:

Leaf = 3,77,131
Stem = 17,811
Node = 4667

I also tried changing many parameters in config file, updated weights according to class distribution ratio
def point_wise_loss(self, semantic_scores, pt_offsets, semantic_labels, instance_labels,
                        pt_offset_labels):
        losses = {}
        semantic_loss = F.cross_entropy(
            semantic_scores, semantic_labels, weights= torch.tensor([1,17,75]), ignore_index=self.ignore_label)
        losses['semantic_loss'] = semantic_loss

to model/softgroup.py (on line 144) to balance the class imbalance but still the semantic part predicts to zero for the second and third class.

@IgnacioSan22 @theshapguy  did you guys manage to solve these issues?If yes, please help me as well. Thanks in advance.

@thangvubk can you please maybe suggest us something regarding this issue? It would be immense help. Thank you in advance.

On dataset with imbalanced point per class i have two suggestions.

Using weighted semantic loss. Follow this.
Train longer. Ussually, class with more points will converge first, then class with less points.

@thangvubk Thank you for your quick reply. How did you calculated those semantic weights for stpls3d? How can I do that for my custom dataset?

Please check here for the config explanation.

Great work!
I have some questions;
How can I organize my own my dataset ? is these any guideline for more detail?(such as how to organize my own .tsv(scannetv2-labels.combined.tsv), .aggregation.json,.segs.json) is there any codes for detail ?

Please check here for the config explanation.

Great work! I have some questions; How can I organize my own my dataset ? is these any guideline for more detail?(such as how to organize my own .tsv(scannetv2-labels.combined.tsv), .aggregation.json,.segs.json) is there any codes for detail ?

Hi! Have you done this? And I also have the same question as you do.


Call DefDatabase.Add() directly

Right now we were using reflection to do this. The method itself is public. Was there a reason we used to do it like this?

Have you tested it? I remember stuffed floors breaking hard when using DefDatabase

I tested all the mods by placing all objects they add into the game. It might have not been the most thorough testing, but I did test it.

Let's try it then


embeds_many - changes are saved in the wrong document

# The models

class VProduct
  include Mongoid::Document
  include Mongoid::Timestamps
  include Tire::Model::Search
  include Tire::Model::Callbacks

  field :name                   # name -        Bezeichnung

  belongs_to :v_group
  embeds_many :p_images

  #elastic search
  index_name 'v-products'
  def to_indexed_json
    self.to_json
  end
end

class SubCalculation
  include Mongoid::Document
  # Timestamps sind im Objekt Berechnung

  ###############    RELATIONS   #################
  embedded_in :calculation
  embeds_many :left_products, class_name: "VProduct"
  embeds_many :right_products, class_name: "VProduct"
end

# The Problem
a = Calculation.last
a.name
=>"test"
a.subcalculation.left_products.first.name
=>"hugo"
a.subcalculation.left_products.first.name="test123"
a.save
=>true
a = Calculation.last
a.name
=>"test123"
a.subcalculation.left_products.first.name
=>"hugo"

VProduct needs to know what it's embedded in... You'll need to add something like:
class VProduct
  include Mongoid::Document
  include Mongoid::Timestamps
  include Tire::Model::Search
  include Tire::Model::Callbacks

  field :name                   # name -        Bezeichnung

  belongs_to :v_group
  embeds_many :p_images
  embedded_in :left_calculation, class_name: "SubCalculation", inverse_of: :left_products
  embedded_in :right_calculation, class_name: "SubCalculation", inverse_of: :right_products

  #elastic search
  index_name 'v-products'
  def to_indexed_json
    self.to_json
  end
end

class SubCalculation
  include Mongoid::Document
  # Timestamps sind im Objekt Berechnung

  ###############    RELATIONS   #################
  embedded_in :calculation
  embeds_many :left_products, class_name: "VProduct", inverse_of: :left_calculation
  embeds_many :right_products, class_name: "VProduct", inverse_of: :right_calculation
end


MIPS RSA pk encryption produces invalid result

May be related to #1093 and seen impacting big and little endian MIPS
Description

Type: Bug
Priority: Major | Minor
Mitigated by following suggestion to remove embedded assembly in bn_mul.h based on https://github.com/ARMmbed/mbedtls/issues/755#issuecomment-275922927

Bug
OS
Mbed OS linux MIPS and MIPSEL
mbed TLS build:
Version: 2.6.0 and still present in 2.9.0
OS version: reproduced in qemu-mips and Openwrt 15.05 (Broadcom BCM5300)
Configuration: attached config.h
config.h.txt
Compiler and options (if you used a pre-built binary, please indicate how you obtained it):
https://bitbucket.org/GregorR/musl-cross
Peer device TLS stack and version
N/A failure can be reproduced in sample code, although this was identified by encrypting data with an RSA public key on MIPS and attempting to decrypt in Ruby 2.5.1 on x86_64.
RSA key was generated with OpenSSL 1.0.2j
openssl req -new -newkey rsa:2048 -nodes -x509 -subj '/CN=localhost' -days 365 -keyout server.key -out server.crt && cat server.key server.crt > server.pem
openssl rsa -in server.pem -pubout > server.pub

Expected behavior
Sample code should report success on decrypt of public key encrypted data.
qemu-mips ./test
loaded public key
ALL IS WELL IN LOCAL DECRYPT

Actual behavior
Decryption fails with error code
qemu-mips ./test
loaded public key
FAILED TO DECRYPT mbedtls_pk_decrypt RETURNED -16640

Steps to reproduce
Sample failing code on MIPS, this code reports success on ARM & x86_64
#include <stdlib.h>
#include <mbedtls/aes.h>
#include <mbedtls/entropy.h>
#include <mbedtls/ctr_drbg.h>
#include <mbedtls/pk.h>

int main (argv)
{
	size_t olen = 0;
	size_t data_len = 16;
	unsigned char data[16] = "ABCDEFGHIJKLMNO";
	mbedtls_pk_context pk;
	mbedtls_ctr_drbg_context ctr_drbg;
	mbedtls_entropy_context entropy;

	mbedtls_entropy_init(&entropy);
	mbedtls_ctr_drbg_init(&ctr_drbg);

	mbedtls_pk_init(&pk);
	if (!(mbedtls_pk_parse_public_keyfile( &pk, "server.pub" ))) {
		printf("loaded public key\n");
		if (!(mbedtls_ctr_drbg_seed(&ctr_drbg, mbedtls_entropy_func, &entropy, NULL, 0))) {
			mbedtls_pk_context priv_k;
			mbedtls_pk_init(&priv_k);
			unsigned char buf[MBEDTLS_MPI_MAX_SIZE] = {'\0'};
			if (!(mbedtls_pk_encrypt(&pk, data, data_len, buf, &olen, sizeof(buf), mbedtls_ctr_drbg_random, &ctr_drbg))) {
				// now try to decrypt
				if (!(mbedtls_pk_parse_keyfile( &priv_k, "server.key", "" ))) {
					size_t dec_len = 0;
					unsigned char result[MBEDTLS_MPI_MAX_SIZE] = {'\0'};
					int ret = 0;
					if(!(ret = mbedtls_pk_decrypt( &priv_k, buf, olen, result, &dec_len, sizeof(result),
										mbedtls_ctr_drbg_random, &ctr_drbg)))
					{
						printf("ALL IS WELL IN LOCAL DECRYPT\n");
					}
					else
					{
						printf("FAILED TO DECRYPT mbedtls_pk_decrypt RETURNED %d\n", ret);
					}
				}
				else
				{
					printf("FAILED TO PARSE THE PRIVATE KEY\n");
				}
 			} else {
				printf("FAILED TO ENCRYPT DATA\n");
			}
		}

	} else
	{
		printf("FAILED TO PARSE THE PUBLIC KEY\n");
	}
	mbedtls_ctr_drbg_free(&ctr_drbg);
	mbedtls_entropy_free(&entropy);
        return 0;
}

compiled with sample mips-linux-gnu-gcc -static main.c -o test -I"../mbedtls/include/" -L"../lib" -lmbedtls -lmbedcrypto using https://hub.docker.com/r/asmimproved/qemu-mips/

Thanks for the feedback! MIPS isn't a platform we have in our CI nor one we have tools or boards for, so we'd very much welcome a fix for this one.

ARM Internal Ref: IOTSSL-2364

@jmartin-r7, if the issue is in the bn_mul.h code as suggested by the fact that the disabling the corresponding assembly code workarounds the issue, you might want to try the following patch:
diff --git a/include/mbedtls/bn_mul.h b/include/mbedtls/bn_mul.h
index f4b2b56..5ed46d9 100644
--- a/include/mbedtls/bn_mul.h
+++ b/include/mbedtls/bn_mul.h
@@ -727,7 +727,7 @@
         "sw     $10, %2         \n\t"   \
         : "=m" (c), "=m" (d), "=m" (s)                      \
         : "m" (s), "m" (d), "m" (c), "m" (b)                \
-        : "$9", "$10", "$11", "$12", "$13", "$14", "$15"    \
+        : "$9", "$10", "$11", "$12", "$13", "$14", "$15", "$lo", "$hi" \
     );

 #endif /* MIPS */

@aurel32 that does look to address the specific issue in my test, I will do more testing and see about opening a PR.  I need to understand the possible impacts before accepting this as a long term solution.

@aurel32 thanks, that looks good to me (though as a side note, it wasn't obvious to me what sets $hi - doesn't multu just store in $lo ?)

Ah, nevermind, my reference was incomplete.

Hi @jmartin-r7,
I got aware of this issue and the subsequent PR only now: Many thanks for reporting this and for providing a thorough description of how to reproduce the issue (for the record: I had to set CFLAGS="-O3 -march=mips32" when compiling to be able to observe the issue)! As you have seen, I looked into this issue some time ago and failed to reproduce it, so your input is very valuable.
Regards,
Hanno

Hi @aurel32,
thank you very much for finding and reporting the cause for the issue. I confirm that the clobber list is broken, and that changing it per your suggestion at least fixes the issue at hand in the setup @jmartin-r7 describes. Further review and discussion will be done in PR #1949.
Regards,
Hanno


Prototype using lo-res county boundaries in mobile

Related to #188, which is to "only load hi-res county boundaries in mobile": What if we actually didn't even do that, but only ever loaded and used the LOW-res county boundaries in mobile, even on zoom? Maybe they'd be high enough resolution to pass even when zoomed in?
I think this idea is worth prototyping before we commit. On the one hand, it would be great if we could save some mobile users some data transfer by sticking to the low-res boundaries. On the other hand, I worry that the low-res boundaries will look too coarse even on mobile. Some screenshots (or better, people trying this out on mobile) would help us determine whether the low-res boundaries are passable on small screens.
Jordan notes that tablets are a weird intermediate space - might or might not count as mobile, but definitely show big enough screens that the low-res boundaries are a style risk. Keep these in mind.

Some low res vs high res contrasts:
Virgin Islands
low:

high:

Texas
low:

high:

Massachusetts
low:

high:

Wisconsin
low:

high:

These are documented in commit bd1083b and then undone by the following commit 0ed88bc.
My take is that we could get away with low-res for many states, but small ones like MA and VI look a lot better at high resolution. We could conceivably customize the resolution if we switched to loading the county borders state by state, but that would require choosing to resolve the backlogged issue #237.

Options from here:

send this issue to the backlog to sit behind #237, maybe resolve them both some day; keep the high-res data in use
bring #237 into the main queue and plan to resolve them both soon
decide that the low-res data is actually fine for all states and reapply bd1083b

Excellent overview. I don't know that I am caught up on the other issues, can you let me know how much (in % data volume?) that we save mobile users by sticking w/ the low res?
It sure looks good for mobile in all of the screenshots except VI...

I think my knee-jerk vote is to backlog this for now, but knowing we'd like to be able to do low-res on mobile in the future for re-use of this mapping concept. One potential solution in the future (unless I am misunderstanding it) is to do the GIS simplification after scaling up/down the geometry to the viewing area. So this would mean PR/VI would look higher res but AK would look lower res.

I think low-res looks kind of strange for really any small state, so the entire Northeast. It would be nice to test out what kind of performance gains we get from low-res only on mobile. I tried loading beta on my device this morning on data and it was pretty slow.

It looks a little strange, but I think it is a tradeoff in the future that we should likely take. IMO, the only unacceptable part about this lower res version for mobile is that one of the Virgin Islands disappears.

Thanks for the thoughts. I agree that most of the states look pretty good. The low-res county boundaries are 848 Kb and the hi-res county boundaries are 1.8 MB. We've just saved ourselves the 848 by only loading one version of the boundaries ever for mobile (open PR #236), not yet visible in beta, but we're still talking about 1 MB of flex room.
A third option is to create a medium-resolution version that shows the Virgin Islands but is coarser than our desktop hi-res version. Maybe we could get something that's more like 1.3 MB rather than 1.8?
Re: "do the GIS simplification after scaling up/down the geometry to the viewing area" - yes, I'd love to figure this out someday. As noted in https://github.com/USGS-VIZLAB/water-use-15/issues/237#issuecomment-384321384, one challenge we'll face there (probably overcomable, but will take some extra coding/thinking time) is that the state boundaries need to match the county boundaries, so simplifying each state's counties differently means we might need to package different versions of the state boundaries for various county resolutions.

I am playing around with this on beta, and wonder if performance is maybe the bigger issue than data volume (but the two are related). My phone seems to suffer with the current zoom/pan functionality, but I am not sure how much of this is a result of higher res paths vs a more general snappiness issue on slower phones (I am using an older slower iPhone)

I share your suspicion that processing time is a big chunk of it now - larger file size leads to greater processing demands just because there's more to process, but even on desktop, even just transitioning between colors in the same map can be slowish, and #163 notes that firefox is extra painful. We're still asking a lot of the browser on every device, even after all we've done to try to ask less.

Next step: test performance differences between using low-res and high-res. If there are noticeable gains, then we proceed to #255.

Marty has compared performance and reports that low-res is noticeably faster to load, though not really faster on transitions.


Handle ClassLoaders better

Overall druid tasks have various issues related to classloaders.
See https://github.com/druid-io/druid/pull/2500 for some information
Part of the problem is that certain library jars (like hadoop or spark) need to be resolvable on the ClassLoader for various things, such as HDFS storage functionality or HadoopTask's runTask items.
But you in general don't want these jars or their dependencies interfering with other extensions, or even with the framework itself. For example, HDFS deep storage extension requires hadoop jars, but if those jars are of a different version than the jars specified by the hadoop coordinates for a task, then the resulting behavior of the job might be fine, or it might crash and burn.
Additionally, there are various ways of packaging jars which are hard to predict from a "search based on jar name" kind of qualification.
Additionally, there may be private extensions in use which depend on various druid or non-druid jars and are not discoverable by any currently predictable mechanism.
To get around this, the current HadoopTask isolating classloader uses a single URLClassloader for the runTask portion locally, and simply puts all the jars not related to the hadoop coordinates in the job jars.

One problem we have here is the extreme difficulty in testing for ClassLoader problems.


Add contents of ISO image to METS transformFile element

From the METS documentation:

The transform file  element provides a means to access any subsidiary files listed below a  element by indicating the steps required to "unpack" or transform the subsidiary files.  This element is repeatable and might provide a link to a  in the  that performs the transformation.

For identifying subsidiary files it might be possible to use something like Fiwalk.
BUT: fiwalk appears to be unable to process hybrid ISOs that contain ApplePartitions (tested with SleuthKit Version: 4.2.0). Example:
fiwalk ik_zie_spookhuis.iso -X ik_zie_spookhuis.xml

Resulting output file lists following error:
<!-- TSK_Error 'Cannot determine file system type' at sector 1 offset 512 sector_size=512 -->
<!-- TSK_Error 'Cannot determine file system type' at sector 27531 offset 14095872 sector_size=512 -->
<!-- Retrying with 512 byte sector size. -->
<!-- TSK_Error 'Cannot determine file system type' at sector 1 offset 512 sector_size=512 -->
<!-- TSK_Error 'Cannot determine file system type' at sector 27531 offset 14095872 sector_size=512 -->
<!-- clock: 0.014510 -->

(Apart from that the output file contains no file listing at all, not even for the ISO9660 file system!)
Possibly of use:
https://github.com/cul-it/hfs2dfxml
and:
https://github.com/timothyryanwalsh/cca-diskimageprocessor

Possible alternative to fiwalk: use libcdio's cd-info with -f option.

Changed to WONTFIX & closing b/c of issues listed above.

Other option: use 7-zip:
https://gist.github.com/bitsgalore/9eac23e44d6d99b3caa6#list-contents-of-iso-image-with-7-zip
The result could be transformed to eg DFXML.

Closing issue in favor of https://github.com/KBNLresearch/omSipCreator/issues/47


Development: Use default value if exercise has no plagiarism checks config

Checklist
General

[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.

Motivation and Context
Importing programming exercises from files created before merging of the continuous plagiarism control was not possible, because such files didn't contain plagiarism checks config. This caused the client to load the exercise creation form incorrectly.
Detected during tests of: #7624
Server part fixed in: #7640
Description
This PR adds a nullability check for exercise's plagiarism detection config before the exercise form is initialised. If exercise does not contain plagiarism detection config, the component inserts a default value into it.
Steps for Testing
Prerequisites:

1 Instructor
1 zip file with Programming Exercise without plagiarism detection config. You can use this one: Material-cr1-Sorting_Algorithms_Implementation-52-20231125-105137.zip

Go to course -> exercises.
Start programming exercise from the file provided.
Verify that the form displays correctly (including default plagiarism detection config).
Import the exercise.
Verify that the exercise was imported correctly.

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress
Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Line Coverage
Confirmation (assert/expect)

exercise-update-plagiarism-component.ts
63% (testing just the new method)
✅

Thanks for fixing this, but I already implemented #7657 with the same fix.

Thanks for fixing this, but I already implemented #7657 with the same fix.

This is continuation of work started in #7640


Error messages when building

Hi,
Could you help me to solve the following problems?

The message says: The system can not find the specified file.
This errors messages suddenly come up since an hour ago.

I sometimes get that too, happens particularly when saving a .scss file. I think there’s a race condition somewhere (probably between Webpack and Filesystem?).

Just remember this: do you have the watch command configured to exclude _tmp directories?
Take a look at the Webpack config for reference:
https://github.com/tightenco/jigsaw/blob/eb20254b75e4eb72d5d6d9a7b1010ecf0dfaa88e/stubs/mix/webpack.mix.js#L10


handle cleanup for signals we can catch

For example, currently if a directory has to be created for a bind mount and then the process is sent a signal such as TERM or INT, we don't currently clean up the directory on exit.

Cleanup handled for SIGINT/SIGTERM via https://github.com/pkgcore/snakeoil/commit/f042a8c3a9c6908d24b45785362969be1037edd1. Next up is resending the signals to the child namespace if the parent process exits due to receiving these signals.


Provide a 'Changelog' link on rubygems.org/gems/abbrev

By providing a 'changelog_uri' in the metadata of the gemspec a 'Changelog' link will be shown on https://rubygems.org/gems/abbrev which makes it quick and easy for someone to check on the changes introduced with a new version.
Details of this functionality can be found on https://guides.rubygems.org/specification-reference/

@mark-young-atg Thank you!


How can I make the SDK use std::string on Android?

How can I make the SDK use std::string on Android? It is my understanding from the comments in AWSString.h that all I should have to do is build with libc++. I have tried specifying libc++ in the cmake arguments as well as explicitly setting CUSTOM_MEMORY_MANAGEMENT=0, but I still get build errors when I try to mix std::string with Aws::String without resorting to calls to c_str(). This is my build script:
#!/usr/bin/env bash

set -e

ABIS=("x86" "armeabi-v7a")
WORKING_DIR=$(git rev-parse --show-toplevel)/client
BUILD_DIR=$WORKING_DIR/build-aws-cpp-sdk

$WORKING_DIR/helpers/GenerateVitalClient.sh

mkdir -p $BUILD_DIR
cd $BUILD_DIR
for ABI in "${ABIS[@]}"
do
    mkdir -p $ABI
    pushd .
    cd $ABI
    cmake -DTARGET_ARCH=ANDROID \
          -DNDK_DIR="${ANDROID_NDK_HOME}" \
          -DNDK_RELEASE=r13b \
          -DANDROID_NATIVE_API_LEVEL=21 \
          -DBUILD_ONLY="cognito-identity;access-management;vitalservices" \
          -DADD_CUSTOM_CLIENTS="serviceName=vitalservices,version=2016-11-23" \
          -DANDROID_STL=libc++_static \
          -DANDROID_ABI=$ABI \
          -DCUSTOM_MEMORY_MANAGEMENT=0 \
          -DCMAKE_BUILD_TYPE=Debug \
          -DCPP_STANDARD=14 \
          -Wno-dev \
          $WORKING_DIR/deps/aws-sdk-cpp/

    make -j3
    popd
done

In android.cmake we force CUSTOM_MEMORY_MANAGEMENT to true unconditionally.  We could relax this and instead default it to 1 if not set.

Ok. This sounds like a change I may be able to implement myself.

See pull request #497.


[New Feature]:Adding a hint button

Feature:
Adding a hint button at the right corner.
purpose:
It would help  keep the player engaged if the player is a newbee he/she might need some help to solve the cube.
I am a gssoc contributor and would love to add this feature kindly assign

hey @Dev-tanay. I would like to add the required feature. Please assign this issue to me


User roles getting overwritten

I installed Bookstack and I implemented SSO using saml2. I have configured the Bookstack to let user register himself and by default I am giving Viewer role to users. I want few users to have admin roles. So I modified the roles of those usres in settings and gave them admin role. However when they sign again, the role is overwritten to "Viewer" role again. Is there any option/ setting that the registration should happen only once.
Also I am unable to log in to Admin account if I enable saml2. I have to change it to standard to get into admin access. Can't we keep both active.

Hi @sharma-akshay,
Can you confirm the exact version of BookStack you are using (Shown in the top-right of the settings) and also confirm if you are using any of the below options in your .env file:
SAML2_USER_TO_GROUPS=
SAML2_GROUP_ATTRIBUTE=
SAML2_REMOVE_FROM_GROUPS=

Hi,
Following are the details:
BookStack v0.29.2
SAML2_USER_TO_GROUPS=true
SAML2_GROUP_ATTRIBUTE=groups
SAML2_REMOVE_FROM_GROUPS=true

Hi @sharma-akshay,
User group syncing, which you have enabled via SAML2_USER_TO_GROUPS=true will run on each login. Since you have SAML2_REMOVE_FROM_GROUPS=true enabled, they will be removed from non-matching groups on each login. There is no option to only have this run once. You could alternatively not use SAML2_REMOVE_FROM_GROUPS=true if you want the admins to keep those roles but you'll need to manually apply any role-removals in the future.

Also I am unable to log in to Admin account if I enable saml2. I have to change it to standard to get into admin access. Can't we keep both active.

This is because the admin account is not synced with a SAML user. You can either sign-in with SAML to create a user, then, using the admin account, give that user admin privileges; Or you can set the "External Authentication ID" input value for an existing user/admin to match them up for a future SAML login.
You should be able to login via standard login as an admin, change back to SAML2, and you'll remain logged in as the admin for that session, if you need to be logged in as an admin while SAML2 is active.

Since there has been no further follow up on this I'll close it off.


How to do predict_proba in catboost classifier?

Confused that the example does not show  how to do predict_proba clearly.
And how to get the predict results?

Thanks for raising this! predict_proba definitely needs to be better documented and described in more examples.
You can control whether to invoke predict_proba by Environment's do_predict_proba kwarg. do_predict_proba can be a boolean (default=False) or an int. The int form is used to specify the column index of the class probabilities you want to use. So if you're doing binary classification and want the probabilities for the "1" class, you would use do_predict_proba=1.
At the moment, this is the only example that uses do_predict_proba (line 215).
Sorry this was so hard to find. Please let me know if this is what you're looking for, and if you have any suggestions for making this easier!

Not clear yet.
In the src, hard to find where the prediction results return.
Examples are all about training only.
An example about do test_dataset(without labels) predictions would be much appreciated.

Ah I could definitely document that better. Thanks for bringing that up. Would it help to add an "Attributes" section to the docstring of experiments.BaseExperiment in which I list the different dataset attributes?
In your case, you probably want your Experiment's data_test.predictions attribute. This contains several other attributes for different views of the data at different time divisions. The internals of data_test and the other BaseExperiment.data... attributes are documented in the module docstring of data.data_core. So I'd recommend reading that to better understand what you can access.
However, the easiest way to get the full test predictions at the end of an Experiment would be through the "HyperparameterHunterAssets" directory built by your Environment.results_path. All of your Experiments' test predictions can be found in csv files inside "HyperparameterHunterAssets/Experiments/PredictionsTest" unless you're black-listing them or something.
Are your Experiments' results not being automatically saved? If you do think that something is misbehaving, would you mind sharing some minimal code so I can reproduce the problem?


Added how to obtain information from the report

Updated nav in pages.yml
Updated response in report_tracker - it was not correct with double report and success
Added information about connecting to the console.

Added spoilers


Advance to "Rename models.exs to schemas.exs" commit.

Coverage remained the same at 83.657% when pulling 28683abf1dd1bc5c2f7893ee8aa0d18378975a4f on rename-models-to-schemas into 02218367d4acb2d0794117491449f8c9dc6af33e on master.


Fish shell "." is deprecated in favor of "source"

Per the fish documentation for "source":
(a single period) is an alias for the source command. The use of . is deprecated in favour of source, and . will be removed in a future version of fish."

Thanks for letting us know! Can you update the related test as well? See failure in Travis CI output.


Remove Coordination Fee Rate concept

Remove the coordination fee concept in a backward compatible way.

So what happens when this is merged and user connects to a non-free coordinator? Coordinator rejects the inputs as they aren't paying any fee?

So what happens when this is merged and user connects to a non-free coordinator? Coordinator rejects the inputs as they aren't paying any fee?

Given that the client doesn't know anything about the coordination fee  (CF) concept, it will request credentials for the value (CV) of the registered input amount (RIA) minus the mining fee (MF). This is: $CV = RIA - MF$. However, the non-free coordinator will expect $CV = RIA - MF - CF$ and then it will fail with a IncorrectRequestedAmountCredentials error during connection confirmation.
This won't attack the non-free coordinator. Notice that non-free coordinators don't need to upgrade in order to become free coordinators, they just need to set CF = 0.

So what happens when this is merged and user connects to a non-free coordinator? Coordinator rejects the inputs as they aren't paying any fee?

Given that the client doesn't know anything about the coordination fee  (CF) concept, it will request credentials for the value (CV) of the registered input amount (RIA) minus the mining fee (MF). This is: $CV = RIA - MF$. However, the non-free coordinator will expect $CV = RIA - MF - CF$ and then it will fail with a IncorrectRequestedAmountCredentials error during connection confirmation.
This won't attack the non-free coordinator. Notice that non-free coordinators don't need to upgrade in order to become free coordinators, they just need to set CF = 0.

Wasabi clients are not working with non-fee coordinators since the last release. The reason is the removal of free remix and friends don't pay feature from Wasabi.
Before we started Gingerwallet we had a meeting - you clarified that you will remove features those are fundamental for business purposes, like the coinverifier or termandconditions, coinjoin fees and that was the reason we needed to go with the fork of the client software. My disapointment is the lack of communication toward the coordinatorts like us or other non-free coordinators about that you will break compatibility.

Wasabi clients are not working with non-fee coordinators since the last release. The reason is the removal of free remix and friends don't pay feature from Wasabi.

If you encounter a problem in the software, please kindly open an issue and explain it. If the issue involves security risks, please contact us privately.

Before we started Gingerwallet we had a meeting [...]

A lot has changed since then, including incidents that have cost users real funds. You cannot use past decisions or discussions, made without a full understanding of the situation and risks, as a justification to prevent changes in the software.

My disapointment is the lack of communication toward the coordinatorts like us or other non-free coordinators about that you will break compatibility.

We hold a weekly public meeting, which we use as our primary source of communication with the community, along with GitHub, of course. You cannot ignore our means of communication and then claim that we don’t communicate. However, if you believe these methods are inadequate, please contact us, and we will do our best to improve.
While we strive to respect and do our best for the services built on top of Wasabi, our priority is and will always be the users of the WalletWasabi software. For example, if an exploit was to be found in the WabiSabi protocol, we would immediately ship an update that disables the coinjoin feature of Wasabi’s client, pending further investigation and a fix, regardless of which services are built on top of it.
This pull request follows the same logic; it's intended as a preventive measure to avoid potential new exploits. It makes sense to remove the feature, as it introduces an hard to estimate risk, even if I personally believe the risk is limited enough to merge this PR as part of the first hard fork that we will implement (hence I did not approve this PR).
I hope that this message sufficiently explains why, if a security risk is significant enough, it must be addressed without regard for the services built on top of Wasabi.

This is not an issue to fix, it was "hopefully" a conscious decision. Breaking changes are always announced in advance by the party making the change, allowing others to prepare and avoid service disruptions. The only exception is when someone unknowingly introduces a breaking change, is that the case?


New logger trunk

Description of the Change
This trunk contains the new logger implementation fully integrated into the project. Additionally, the configuration file parsing was rewritten and related libraries (fmt & spdlog) were updated.

Benefits
New logger features, hidden libs & better config parser.

Commits 2f09018, 4241a1e, e940c49 and d1f2be94e were accidentally merged from #2072 without being squashed.

Can you please also write some docs about verbosity level here?..

Looks good but please fix mst_fuzz and status_fuzzing and torii_fuzzing targets.

These targets are outdated due to missing CI checks for them, and it has nothing to do with the new logger. So I tried to fix them in a separate PR: please see #2136.


Patch log

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 81.625%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/cron/init.go
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
231

Relevant Lines:
283

💛  - Coveralls


nekvm: workaround for LSO failures on HCK 1903

HCT OffloadLso test fails when runs after Mini6Performance.
This change may improve the test behavior.
Signed-off-by: Yuri Benditovich<EMAIL_ADDRESS>

!!! Please do not merge this PR regardless status of the tests till special notice !!!

OK

On Aug 20, 2020, at 19:34, Yuri Benditovich<EMAIL_ADDRESS>wrote:

!!! Please do not merge this PR regardless status of the tests till special notice !!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@Basils Note that in this run the LSO test was after LinkCheck, where it does not present a problem

I ran another run that tests the problem specifically and it passed.
Test result can be viewed here

Closing, as @ybendito  is going to implement another solution.


add assertion/test for 1d tensor transpose

don't you already get IndexError from a line below? how useful is this?


⚠ Bofrost.de has degraded performance

In 230f406, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 992 ms

Resolved: Bofrost.de performance has improved in 46aec07 after 9 minutes.


Remove duplicated message about unknown versions

[X] Have you signed the Contributor License Agreement?
[ ] Are you working against an Issue?

It turns out that this message is displayed twice, without a reason. Example:
$ winget upgrade --all
Name  Id             Version Available Source
---------------------------------------------
gsudo gerardog.gsudo <IP_ADDRESS> 1.1.0     winget
1 upgrades available.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

(1/1) Found gsudo [gerardog.gsudo] Version 1.1.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/gerardog/gsudo/releases/download/v1.1.0/gsudoSetup.msi
  ██████████████████████████████   364 KB /  364 KB
Successfully verified installer hash
Starting package install...
Successfully installed

10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

$ winget upgrade --all
No installed package found matching input criteria.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.
No applicable update found.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

This PR removes the latter duplicated message.
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run


Improving definition of AxiomRequest type

Currently, the AxiomRequest type is defined as follows:
export type AxiomRequest = (NextRequest | Request) & { log: Logger };

However, this definition poses difficulties when trying to use Next.js-specific APIs like req.nextUrl, which are not available in the Request type.
I propose updating the AxiomRequest type to the following:
export type AxiomRequest = NextRequest & { log: Logger };

This change will ensure that the AxiomRequest type aligns with Next.js APIs.
Please let me know if I'm missing any important considerations or if you have any suggestions for alternative solutions.
Thank you

hey @francofantini, lets give it a shot. I am not sure though when does Next.js passes NextRequest and when does it pass a normal Request.

Thanks @schehata! When can we expect the next npm release?

hi @francofantini will check on Monday, if there is any other open issues or features we would like to implement, and I will get back to you. will try to release this week.


fix(@angular/cli): adjust blueprint tslint.json in compliance with tslint 5.3.x

Just wondering if there's any reasoning for the orders picked. Was looking at the recommended ordering and it's a little different: https://github.com/palantir/tslint/blob/dc0bdf1883db599fb4a59b8724df1679ab97bc49/src/configs/recommended.ts#L67

@intellix Commit c4d1b39 does not substantially change the previously defined order; but replaces the outdated rules static-before-instance and variables-before-functions with the current idiom of https://palantir.github.io/tslint/rules/member-ordering/.
The precedence of variables-before-functions over static-before-instance was implicitly defined by the internals of previous implementations of TSLint. The new property order allows explicit control of the applied precedence.
I do not know, why the actual member ordering was initially chosen. However, in many languages, it is common practice to group fields before methods and order these two groups by certain modifiers.
Personally, I prefer an even stricter order, which does not leave room for discussions :wink:
"member-ordering": [
  true,
  {
    "alphabetize": true,
    "order": [
      "public-static-field",
      "protected-static-field",
      "private-static-field",
      "public-instance-field",
      "protected-instance-field",
      "private-instance-field",
      "public-constructor",
      "protected-constructor",
      "private-constructor",
      "public-static-method",
      "protected-static-method",
      "private-static-method",
      "public-instance-method",
      "protected-instance-method",
      "private-instance-method"
    ]
  }
]


Fixed reported bugs, updated docs and added custom config option

Initial PR to build docker container. I cant remember whether the latest tagged docker build will be updated with the environment in this PR, or whether it will just be dev.
See CHANGELOG.md for more details about changes.

@ewels Ive just seen this PR:
https://github.com/nf-core/chipseq/pull/55
Made those changes here too.


Add citation to package

Add citation method to package other option is to add to readme.

Added to readme


overscroll-behavior is missing from properties order

Original report by sobral (Bitbucket: sobral, GitHub: robsonsobral).

https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior

We moved to use Recess.


Adopt ResizeObserver API

Describe the bug
Currently iframe-resizer relies on a lot of hard work to ensure that it works in every single browser. Like it says in the readme, it even works with IE11, which is a rather impressive feat.
Recently I've noticed that the ResizeObserver API appears to be an API that was created to simplify much of the code required to watch an element's size. Would it be worthwhile to adopt this?
Furthermore, if adopting the ResizeObserver API does indeed seem like a good idea, I personally would love seeing some of the legacy code eventually being deprecated. This part is purely a personal opinion, but it might have some advantages
a) lower bundle size, which is amazing for consumers
b) less code to maintain
c) just a general feeling of being "modern"

I just had a look at this. I think it might make sense to replace MutationObserver with ResizeObserver so that resizing only gets triggered by element mutations that change an element's size. I would welcome a PR if you would like to give it a go. It would need some further investigation to see if it also covered other use cases.
At some point in the future, I will drop support for IE11, but not sure we are quite at that point yet.

I'd provide an exam using ResizeObserver https://stackoverflow.com/a/70334190/1485853

I’m adding this to V5, and also dumping IE11 support. Will have to keep a lot of the other detection code, as so that we can still detect resizing of items outside the main document flow.


[DO NOT MERGE] CI-CD debug

[DO NOT MERGE] CI-CD debug
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

DOne debugging!


CB-18277 configure Java services to use PKCS11 with NSS DB in non-FIPS environments

This PR depends on hortonworks/cloudbreak-deployer#803 and thunderhead/dps-k8s#412

retest this please

retest this please


Encryption Key support

Feature request
When entering the embed text in the database like pgvector, I would like to encrypt the raw text with KMS Key or any such encryption and use raw text for generating embedding
Motivation
Security
Your contribution
N/A

+1 Nowadays, saving data without any type of encrpyton is a no-go for many type of projects. This feature should be a must.

I'm interested in this feature as well, due data security policies it is important that in case of a database dump the documents content is encrypted.
If anybody guides me a bit on implementation details I can give it a go


workflow example management missing components folder

Components folder is missing from the Example in workflow/management
Also I find it difficult to undestand how can I call the sequence example in authoring from the management example.
Any help is much appreciated.
Thanks

Thanks @sce9sc for finding this issue, we can reuse the same components from https://github.com/dapr/js-sdk/tree/main/examples/workflow/authoring/components (an actor state store is all that's required). Please feel free to send in a PR to fix it!

I will be very happy to contribute and fix any issues as well as creating more examples . Can you also explain to me why I cannot call the sequence workflow by changing the name like so
  const instanceId = await client.workflow.start("sequence");

What is the diffenece between DaprWorkflowClient and client.workflow ?

Can you also explain to me why I cannot call the sequence workflow by changing the name like so

What error message do you get?

What is the diffenece between DaprWorkflowClient and client.workflow ?

In management code client.workflow, points to the IClientWorkflow in DaprClient. This can be used for management purpose, as defined by  https://github.com/dapr/js-sdk/blob/main/src/interfaces/Client/IClientWorkflow.ts#L16. If you look at the implementation, it does so by making HTTP calls to the Dapr sidecar https://github.com/dapr/js-sdk/blob/main/src/implementation/Client/HTTPClient/workflow.ts.
DaprWorkflowClient does something similar, using gRPC https://github.com/dapr/js-sdk/blob/main/src/workflow/client/DaprWorkflowClient.ts#L27, by talking to the underlying TaskHub client.
Now that I think more about it, I think we should converge these to avoid confusion. What are your thoughts @DeepanshuA?

I get
Error starting workflow instance: {"error":"Bad Request","error_msg":"{\"errorCode\":\"ERR_WORKFLOW_COMPONENT_NOT_FOUND\",\"message\":\"workflow component 'dapr' does not exist\"}","status":400}```

I am not sure that I have configured it correctly though .

I managed to call the workflow using Post
POST http://localhost:50080/v1.0-beta1/workflows/dapr/sequence/start HTTP/1.1
content-type: application/json
apr-app-id: "activity-sequence-workflow"

That should translate to the same call being made here https://github.com/dapr/js-sdk/blob/5c2b40ac94b50f6a5bdb32008f6a47da69946d95/src/implementation/Client/HTTPClient/workflow.ts#L99

Yes you are correct . Calling directly the dapr instance is working using the above Post request . Spiining app a new instance with only the client and sending the same request using :
  const instanceId = await client.workflow.start("sequence");

does not . and I get
  "errorCode": "ERR_WORKFLOW_COMPONENT_NOT_FOUND",
  "message": "workflow component 'dapr' does not exist"

I 've even started the dapr sidecar with no client and send the same POST request to the new DAps instance and it did not work. Should it ?? I think I am missing something but I cant figure it out yet.
Should the 2 dapr instance be able to communicate with each other ? And by making a post to one it will call ther other that has the workflow?

Both the applications (1) where you register the workflow and (2) where you manage the workflow with commands like start, purge, terminate, etc., should be talking to the same Dapr sidecar. This is an example where it is happening in the same application with .NET https://github.com/dapr/quickstarts/blob/master/workflows/csharp/sdk/order-processor/Program.cs#L54, you can also do it with multiple applications with a single Dapr instance.

From what you mentioned, in order to run a workflow we need to:
(1)  having a Pod (or multi) with a dapr instance + app for registering a workflow together with the invocation capability that will trigger the workflow.
2) In order to run a workflow a different Pod will receive a request and make an invocation to the other Pod.
This means that Pod (1) will have an application that will have DaprServer instantiated together with DaprWorkflowClient and WorkflowRuntime and DaprClient if you want to have management also.
Or on the same pod run
One Dapr instance with 2 Apps  ->

with invocation( DaprServer, DaprWorkflowClient ) + workflow registration (WorkflowRuntime)
with invocation( DaprServer, DaprClient ) for management

The examples are showing how a single Dapr instance together with an application that registers the flows and at the same time the same app runs the flows.
The net example is also showing that is using a single client to start and wait for the flow to finish, whereas the js-sdk there are 2 options .
    const id = await workflowClient.scheduleNewWorkflow(sequence);
  OR
    const id = await client.workflow.start("sequence");

Also as it shown the scheduleNewWorkflow needs TWorkflow and workflow.start needs only the name of the workflow.

Can you also explain to me why I cannot call the sequence workflow by changing the name like so

What error message do you get?

What is the diffenece between DaprWorkflowClient and client.workflow ?

In management code client.workflow, points to the IClientWorkflow in DaprClient. This can be used for management purpose, as defined by https://github.com/dapr/js-sdk/blob/main/src/interfaces/Client/IClientWorkflow.ts#L16. If you look at the implementation, it does so by making HTTP calls to the Dapr sidecar https://github.com/dapr/js-sdk/blob/main/src/implementation/Client/HTTPClient/workflow.ts.
DaprWorkflowClient does something similar, using gRPC https://github.com/dapr/js-sdk/blob/main/src/workflow/client/DaprWorkflowClient.ts#L27, by talking to the underlying TaskHub client.
Now that I think more about it, I think we should converge these to avoid confusion. What are your thoughts @DeepanshuA?

We can keep the components folderinsideworkflow, parallel to authoringandmanagement`.
Yeah, we can think to converge the two as well.
Or may be create a better documentation, where-in we explicitly specify what is needed for what and which one to use in which scenario.
We can


Auto-migrate old keystores on startup

On startup then agents should be checked for needing migrations. When an old keystore is detected, as in the stts. database is a dict rather than a KeyStateRecord, then KERIA should automatically update the agent's database.

I do not believe this to be wise.  Migrating production systems without intentionally doing so is a mistake.


Handle submission of SBJ01666

Handle error where submission kept on lims was not the last submission.

Also note that lims duplicate columns are created in the merge that are dropped later.

Use lims columns when handling duplicate columnsin lims.

Also raise value error if lambas dont awake for processing df before submitting processing dataframe

Converted to draft, adding in changes to fix #47 and #49 first