Roots v3.2.x breaks browserify v0.3.2

It seems breaks the roots-browserify (v0.3.2) extension. I can't give an error log because nothing is presented in the terminal as an error. It says it compiles correctly but when the build.js is loaded by the browser, the script seems to only load partially and is inconsistent on where it cuts off each time. Reverting to roots v3.1.x solves the problem; wish I could give more details but there aren't anymore to give :disappointed:

Hi, new roots user, I was looking for something very specific and roots answered to every single part of it so thanks very much.
I'm getting this error too and I thought I would describe my experience in case it helps (although I have no idea how to debug it usefully). I've managed to narrow it down to one very specific group of lines that break browserify when included in one of my modules. Take them out, it works fine, leave them in, the last 30ish lines of build.js are transposed to the top of the file. I can paste the lines if you think it might help but there is absolutely nothing special about them. But I guess there must be some combination of characters that is creating a problem somewhere in the process chain.
However, this only happens during roots watch, not roots compile, so I think it must have to do with #655
I'd love to help out if you can explain some way I might be able to debug this more usefully. Adding debug: true to app.coffee doesn't change the output of roots watch at all.
Thanks!

Hi @Leeds-eBooks -- which version of roots are you using right now? If you are on 3.2.x, try downgrading to 3.1.0 (npm i<EMAIL_ADDRESS>-g), there have been some strange issues with the latest version. If this does not fix the problem, could you drop a little more detail on which lines, or a minimal sample project that can be used to reproduce the problem?
Thanks so much for the thorough report, and looking forward to helping you figure this one out!

Thanks for the quick response! It fills me with confidence. Been getting to grips with multipass compilation and it's really fantastic – I thought I would have a nightmare trying to get scss to play nicely with postcss but it works perfectly. And roots-records is brilliant.
Anyway yep, this bug was with 3.2.x, and rolling back to 3.1.0 fixed it. In terms of supplying a sample reproduction of the problem I actually don't think I would be able to because it's so weirdly specific. My project was working completely fine on 3.2.x, until I introduced these lines:
.then(userRes => {
    const user = userRes.info || userRes,
          dropin = [];

    if (!user.dob) {
      dropin.push({
        key: "dob",
        placeholder: "date of birth",
        type: "date"
      });
    }
    if (!user.address) {
      dropin.push(...[{
        key: 'address',
        placeholder: 'address',
        type: 'textarea',
        attributes: {
          rows: '2',
          autocapitalize: 'words'
        }
      }, {
        key: 'city',
        placeholder: 'city',
        type: 'text',
        attributes: {
          autocapitalize: 'words'
        }
      }, {
        key: 'postcode',
        placeholder: 'postcode',
        type: 'text',
        attributes: {
          autocapitalize: 'characters'
        }
      }]);
    }

    if (dropin.length) {
      return A.dropin(
        'We need some extra information from you before you can accept the quote:',
        dropin
      ).then(data => ajax.post('url', data, A.getRestid()));
    } else return Promise.resolve();
  })
  .then(() => ajax.get('url', A.getRestid(), cid + '/' + tid))
  .catch(
    message => message && message.toLowerCase().includes('add a credit card'),
    () => ajax.customer.addCard().then(() => ajax.customer.pay(cid, tid))
  )
  .catch(
    errors => errors && errors.toLowerCase().includes('string'),
    errors => supersonic.ui.dialog.confirm(errors, {
      message: 'String?',
      buttonLabels: ['Yes', 'No']
    }).then(i => i === 0 ?
      ajax.customer.addCard().then(() => ajax.customer.pay(cid, tid)) :
      Promise.reject(errors)
    )
  )
  .then(res =>
    res.redirect ? supersonic.app.openURL(res.redirect) : Promise.reject(res)
  ),

preAuth: (from, to, amount, offerId, preAuthorizationId) =>
  ajax.get(
    `url/${from}/${to}/${amount}/${offerId}?${
      _.toQuery({preAuthorizationId})
    }`, A.getRestid()
  )

I was able to narrow it down to these exact lines (pasted here with some urls and strings renamed for legal reasons). If I left the preAuth method in, the bug happened, if I left the .then() function and its contents (which follow on from another method that didn't cause the bug) in, the bug happened. This is obviously es6 code, run through browserify with a babelify transform. I'm sure this won't be helpful as it seems completely arbitrary to me. There are no syntax errors in this chunk. My app.coffee browserify settings are:
browserify(
  files: 'assets/js/main.js'
  out: 'js/build.js'
  transforms: 'babelify'
)

Again, this bug only happens with watch, not compile, so I think it must have to do with the server or related libraries. Any way I can debug the server processes?

Great, glad this worked. Yeah the bug in 3.2.x is with the server. As you probably saw here, it's a very confusing bug, I don't entirely understand why or how it's happening. I'm not on a full-time schedule at the moment so I have much less time to work on this, but I will be taking a look today and tomorrow and trying to work this out.
Sorry for the issues, and I'll let you know as soon as we have rolled out a fix to the latest version!

Thanks man. Like I said if there's any way I can help out I'd be more than happy to spend some time on this.

should be fixed in v4


Whitelist new user model properties.

Problem: New user model properties added in MRN-Code/quarterback#127 et. al. and in the future MRN-Code/quarterback#58 break COINSTAC login requests due to strict model property validation.
Solution: Whitelist new properties
Testing:

npm run lint && npm test on this branch
Log in on an API server with and without the new user model properties

Looks like Codeship’s python env’s all screwy: https://gist.github.com/swashcap/13f8f839c69340c48352ea821dc1dad6. Gross.


Give col_per_thread an initial value to make the compiler happy

@ptillet This PR is only for col_per_thread initialization. However, I don't know why [01c98bd] still comes in. But from the file changed, I only modified one line of code.


Automatically casts numeric strings to integer even if spec says it's a string

This issue is closely related to #58 .
I have a path parameter that is a string. Though, if I pass a string that is numeric such as "123" you automatically cast it to an integer:
https://github.com/lezhnev74/openapi-psr7-validator/blob/master/src/PSR7/OperationAddress.php#L98
This leads to the validation failing because the parameter is expected to be a string but it isn't because you cast it to an integer.
You should probably check if the specification says that the parameter is a string and if so don't cast it to an integer.

Good catch!
Yeah, URLs serialize anything as a string, deserialization is not so straightforward. Probably optimistic casting to int is not the perfect solution.

Well, I've prepared a small patch which removes the casting feature (which is "too smart").
I can't remember why it was introduced in the first place though.

Great! I think this resolves my problem. Thanks for the quick solution.
When do you think this will be merged/released?

I am expecting some extra feedback from @scaytrase If nothing pops up today, I think I'll tag 0.16

Tagged. Did it help?

Yep. It solved my problem. Thank you :+1:


gguf

how convert microsoft/Phi-3.5-MoE-instruct to gguf?

Hi @ayttop! As of writing, llama.cpp does not support Phi 3.5 MoE.
I assume that you would want a GGUF file for the purpose of running inference of quantized models. Mistral.rs can load GGUF/GPTQ model files, but when those are not available (like in this case), you can use our ISQ feature.
ISQ enables you to quantize the model quickly, locally, and in-place. For Phi 3.5 MoE, this may look like
./mistralrs-server --isq Q4K -i plain -m microsoft/Phi-3.5-MoE-instruct -a phi3.5moe
Because llama.cpp doesn't support Phi 3.5 MoE, converting to GGUF would not really make sense as
a) You would only be able to run it with Mistral.rs, after exporting from ISQ
b) If you already ran ISQ, you might as well just use the quantized model
I have been considering a method for saving ISQed models, though. However, in the meantime, I would reccomend to use ISQ. Does this answer your question?

I wanted to run a small version on my computer but thank you

@ayttop what is your hardware (RAM, GPU RAM, etc)? You should be able to ISQ the Phi 3.5 MoE model and then run it!

i3
16ram
1g amd

@ayttop closing as there has been no activity, unfortunately the Phi 3.5 MoE model is quite large memory-wise.


7.2.0rc1

Fix problem with cross-fetch on deno
Stop depending on urlpattern-polyfill for running on deno/bun
Replace URLPattern syntax with regular RegExp

Coverage remained the same at 100.0% when pulling 78774d19d9de539d8fc95a5c863ce260fb7c366a on 7.2.0rc1 into 2ab8a99ee06d4391b05af60d665641edc5cc9204 on main.


Hide Serf and Raft from Broker

Issue: Broker struct is over-burdened.
Proposal: Hide details of serf and raft from Broker behind interfaces
Potential benefits?:

Responsibility of broker package becomes leaner, making it easier to navigate
Easier to write fine-grained tests of functionalities by mocking out serf and raft interfaces, and separate testing for serf and raft functionalities

Code changes proposal: Feature branch
This change set moves serf/raft code from broker to outside. All tests pass.
Next steps (todo):

write tests by mocking out serf and raft

Hey, thanks for the PR it looks pretty good. I thought about doing this before, but I was/am a bit hesitant since Raft's FSM and the broker have such similar roles. Turning the broker into the FSM might be one idea. I like what you've done thus far and am warming up to. Could you make a PR for it and rebase the latest command arg changes I merged?

Will do. Will make a PR once done.

Gonna close this issue. Make another issue/PR when you've got some more stuff to look at. Thanks.


NetPrintsEditor.Exe not Opening

Hi RobinKa, fantastic addition to the .NET space. I'm going to try to interop this with F# somehow possibly. I was really enthusiastic to try out your project so I downloaded the standalone release but, unfortunately, the executable did not execute properly I think and thus did not open any window. I do have .NET core 3 (3.0.100-preview6-012264, to be specific) on my machine.
I tried looking at Event Viewer to see if there was any reason for the silent failure...this is not the first time I have had executables just not open on my computer so it very well could just be my machine.
In any event thanks!

me too

Not sure honestly, I tried downloading and running both the standalone and framework-independent one and they worked for me. Your best bet is probably cloning the repository and compiling it yourself (also the new version targets .NET Framework instead of Core because the VS extension wouldn't work otherwise, so if you want to run on Core you can just change that and it should just work hopefully).
Since I don't have a better place to post this right now: I still intend to keep working on this, I just haven't found the right combination of time and motivation yet :)

Ah okay, no problem, thanks for getting back to me @RobinKa . Provided dependencies are in order, one fix I found was to just open up a powershell in that directory then hit the executable that way...then it would open that way for whatever reason!..


Fix plotting uncertainties and layout

Uses sig-figs from error to display digits
Includes the (1, 0) lines for the off-resonant point Rearranges figures to be more legible
Changes x-axis of mag/phase to f-fc for easier viewing

@scottito, let me know if you have any thoughts on these changes. I wanted to clean up the figures to include in my SQMS poster.

Fit line and off-resonance star color change can be tackled separately as a simple enhancement. I like the plot changes, especially the sig-figs from error, which makes parameters much nicer to read. I do think we should put the (1,0) lines behind the data, but that also should be a quick adjustment.


[suggestion] Convert account credentials to constructor parameters

How about moving api_key and shared_secret from class variables in FlickRaw to instance variables in FlickRaw::Flickr, then it will be possible to run multiple connections easily?
If you're interested in this idea, I can submit another PR.

It is a good idea.

PR #104 created


enable unix mod for android

Have you verified this works on Android?

with https://github.com/rust-lang-nursery/net2-rs/pull/59 merged, this PR should be closed.


Break out editing split redux into hooks that can be reused

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2156

PR #2169

PR #2170

PR #2171

PR #2172

PR #2181

PR #2182

PR #2183

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: kRykM3jQ6n0MkVnYZETw

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: arvMYClIbaPLJj0BeNOg


New version: Mega.MEGASync version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Closes #98873

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


No need for -i for BSP

Is this covered by any test?

@lefou I have a test ready but we need evaluator.outPath instead of os.pwd / "out" from https://github.com/lihaoyi/mill/pull/897 merged and rebase on it first

Arf I tried to implement a similar test as https://github.com/lihaoyi/mill/blob/master/scalalib/test/src/GenIdeaExtendedTests.scala#L16
But I have 2 issues:

It's still going to general the .bsp at the top of the mill project instead of the test target directory.
It's running with -i anyway.

Any better idea here?

Arf, I tried to implement a similar test as https://github.com/lihaoyi/mill/blob/master/scalalib/test/src/GenIdeaExtendedTests.scala#L16
But I have 2 issues with this approach:
* It's still going to general the `.bsp` at the top of the `mill` project instead of the test target directory.

Why is that? Do we use the process current working directory instead of some better source for the project directory?

* It's running with `-i` anyway.

I guess, this one will be hard to test from inside of mill. At least not with an in-process test setup. We probably need to spawn a sub-process and check its generated outcome afterwards. But I leave it to you to say that this is to much for this PR.
But having some test suite for checking the generated BSP files similar to the GenIdea tests is definitively desirable. :-)

We are using evaluator.outPath do you have a better option?

I think Evaluator.outPath is cortect, but under test it should hold a different location to start with.

Actually we don't need the out folder but the one above so evaluator.rootModule.millSourcePath made it.
I put an initial test that we should extend in the future.
We can go ahead with this PR for now.
Thanks


[Bug] the tooltip not point the same x value, but use the data index to link on line chart and scatter chart in connected echarts

Version
5.4.3 、 4.9.0
Link to Minimal Reproduction
https://jsfiddle.net/m8pu493e/1/
Steps to Reproduce

the tooltip show with different x index
Current Behavior
when the mouse point to the second line value, the scatter value  is still point the first
Expected Behavior
hope the point link with the same x index not the series's data index.
Environment
- OS: windows11
- Browser: chrome
- Framework: commonjs/vue@2

Any additional comments?
No response

not-a-bug
set trigger: 'axis' in the line chart
📌 please close issue if problem solved.

not-a-bug set trigger: 'axis' in the line chart 📌 please close issue if problem solved.

I use the trigger with axis value already, but it's unuseful. @helgasoft

I use the trigger with axis value already

You are using it in the scatter series, but not in the line series.

My requirement is to link a scatter chart and a line chart @helgasoft


Annotated callback parameters are not prioritized above un-annotated ones

🔎 Search Terms
"callback inference", "method inference"
🕗 Version & Regression Information
Testing this in the playground it seems to be an issue all the way back to 3.3.3
⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.5.4#code/GYVwdgxgLglg9mABFApgZygHgCoD4AUcADrAmgFyIDeAUIosGAIyX5SXYCUiAvLogDc4MACYBuOgzAAmVu0Rde-IaIkBfTpRUjqamjQD0BxADFw0eEiIAnYmkQBaRAHc41gNZoaqDPlr1GFmQlXQAaSUZZRDZKDGsYMABzbj4wmg0JQ2MAWRQoAAs4EXtnGALEAEMwMDgoCtIkYBhrDEcXN09vdCg-COYYxDiE5LSAmTZuKjVwjP0jRFyCopKy-Mrq2vrLRAAbCtanETh0MAByKHaPLt9-KSYJ0alpAaGkyen0zjEgA
💻 Code
function test<T>(options: {
  fn1: (t: T) => void;
  fn2: (t: T) => void;
}): void {}

// Function props - works
test({
  fn1: t => {},
  fn2: (t: string) => {},
});

// Methods with annotation first - works
test({
  fn1(t: string) {},
  fn2(t) {},
});

// Methods with annotation last - doesn't work
test({
  fn1(t) {},
  fn2(t: string) {},
});

🙁 Actual behavior
When providing multiple function properties with the same type parameter as a function parameter, the type parameter will always be inferred from the first function property.
🙂 Expected behavior
I'm expecting the explicitly annotated function callbacks to have higher inference priority than the ones without annotations.
Additional information about the issue
Not sure whether this is a bug or intended behavior, but though I'd report it to check. It seems related to #18654, although turning off strict function types doesn't change the behavior, it just removes the type error where the unknown param is not assignable to string.
It also looks like it's related to for example #58746, but slightly different.

This one boils down to https://github.com/microsoft/TypeScript/issues/47599
Contextual parameters are assigned in source order and it isn't a unique limitation for callbacks contained in objects. The same happens for arguments lists: TS playground

@Andarist yep I noticed that too, just found the object form to be a simpler thing to report really 😅
Closing this and adding a 👍 to #47599 instead


problems when importint semantic.less

When I import the semantic.less, the output css grows very large (~6mb) and some parts are repeated. I am using default configurations.

There's currently an issue with imports it appears.
As a quick remedy swap semantic.less for
& { @import "definitions/globals/reset"; }
& { @import "definitions/globals/site"; }

/* Elements */
& { @import "definitions/elements/button"; }
& { @import "definitions/elements/divider"; }
& { @import "definitions/elements/flag"; }
& { @import "definitions/elements/header"; }
& { @import "definitions/elements/icon"; }
& { @import "definitions/elements/image"; }
& { @import "definitions/elements/input"; }
& { @import "definitions/elements/label"; }
& { @import "definitions/elements/list"; }
& { @import "definitions/elements/loader"; }
& { @import "definitions/elements/rail"; }
& { @import "definitions/elements/reveal"; }
& { @import "definitions/elements/segment"; }
& { @import "definitions/elements/step"; }

/* Collections */
& { @import "definitions/collections/breadcrumb"; }
& { @import "definitions/collections/form"; }
& { @import "definitions/collections/grid"; }
& { @import "definitions/collections/menu"; }
& { @import "definitions/collections/message"; }
& { @import "definitions/collections/table"; }

/* Views */
& { @import "definitions/views/ad"; }
& { @import "definitions/views/card"; }
& { @import "definitions/views/comment"; }
& { @import "definitions/views/feed"; }
& { @import "definitions/views/item"; }
& { @import "definitions/views/statistic"; }

/* Modules */
& { @import "definitions/modules/accordion"; }
& { @import "definitions/modules/checkbox"; }
& { @import "definitions/modules/dimmer"; }
& { @import "definitions/modules/dropdown"; }
& { @import "definitions/modules/modal"; }
& { @import "definitions/modules/nag"; }
& { @import "definitions/modules/popup"; }
& { @import "definitions/modules/progress"; }
& { @import "definitions/modules/rating"; }
& { @import "definitions/modules/search"; }
& { @import "definitions/modules/shape"; }
& { @import "definitions/modules/sidebar"; }
& { @import "definitions/modules/sticky"; }
& { @import "definitions/modules/tab"; }
& { @import "definitions/modules/transition"; }
& { @import "definitions/modules/video"; }

I'm looking for a better way to solve that creates variable scoping inside each element, so imports dont require special syntax

Patching in 1.9.1
There's probably a better solve but this will work for now.

Great job! Almost ok, but still there is an import for /site/ directory in semantic.less. The actual folder name is /_site/.

Yes rename _site to site this is so these files aren't overwritten on upgrade. These are your site's theme files. Read more about it on learnsemantic


Unable to move arguments in Rust

Here’s the error message I get when saying move arg harp after yank.

Huh. Does this work in other languages? I wonder if we broke this while fixing "bring after" indentation. Tbh I'm not seeing any tests for "move arg"
Cc/ @AndreasArvidsson

I just tried it in typescript and it works fine.

I just tested in Rust on main and it works fine for me.  @purpleP can you give an example where it fails?

@purpleP was this not reproducible?

@purpleP was this not reproducible?

Yep, I probably just did something wrong.


Export attributes of mesos agents as mesos_slave_attributes

A comma-separated list of attribute keys can be supplied via the configuration variable exportedSlaveAttributes.
The key value pairs are exported as labels of the metric mesos_slave_attributes.

Turns out I had reason to need this just this last week!

Thank you for the feedback. I added a corresponding commit.
There is currently no simple way to join mesos_slave_task_labels with any information originating from a master. This may be an interesting change, but you make a very good point, that invalidating an already existing metric is very bad practice.
Exporting the slave field when monitoring an agent/slave follows the same logic of joining master and agent information. But you're right, that in this case the information can indeed be easily obtained from doing everything either on the master side or the agent side.

Looks good to me. Thanks!


0.2.0 Seems broken after upgrade from 0.1.1

Yesterday I upgraded to 0.2.0 and HA started telling me the 'Telenet Telemeter' entity is unavailable.
I just downgraded to 0.1.1 and now it works again.
The only thing I could see in the logs after running 0.2.0 with debug logging:
2023-01-18 21:54:40.259 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Telenet Telemeter for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 573, in async_setup_entry
    return await component.async_setup_entry(entry)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 166, in async_setup_entry
    raise ValueError("Config entry has already been setup!")
ValueError: Config entry has already been setup!

As a test I just upgraded again from 0.1.1 to 0.2.0 and the entity is again showing up as Unavailable

Could you remove it and set it up again? Re-entering your credentials.
As since r0.2.0 extra sensor is created

That didn't solve it. I removed the integration (settings > integrations > telenet telemeter > delete). Then added it again. First I tried with only selecting internet (no mobile as I don't use Telenet Mobile). The integration was added again but completely empty (no entities or devices at all).
Then I removed the integration again and added it again with both internet and mobile checked, but that had the same result.
From the logs:
2023-01-19 23:00:03.813 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up telenet_telemeter platform for sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 289, in _async_setup_platform
await asyncio.shield(task)
File "/config/custom_components/telenet_telemeter/sensor.py", line 85, in async_setup_entry
await dry_setup(hass, config, async_add_devices)
File "/config/custom_components/telenet_telemeter/sensor.py", line 65, in dry_setup
await data_mobile._init()
File "/config/custom_components/telenet_telemeter/sensor.py", line 126, in _init
self._mobilemeter = await self._hass.async_add_executor_job(lambda: self._session.mobile())
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/telenet_telemeter/sensor.py", line 126, in <lambda>
self._mobilemeter = await self._hass.async_add_executor_job(lambda: self._session.mobile())
File "/config/custom_components/telenet_telemeter/utils.py", line 117, in mobile
assert response.status_code == 200
AssertionError

hmmm I just tested it one more time: I removed the integration again and created it again with only 'internet' checked. Now it seems to have been created correctly. The integration again shows 1 device with 1 entity. And i see the percentage gauge agan :)

I guess when a person does not have a mobile subscription (which is way to expensive and beyond terrible signal strength in Antwerp-North), Telenet does not return a http 200 when requesting the data, thus causing the assertion to fail.

I guess when a person does not have a mobile subscription (which is way to expensive and beyond terrible signal strength in Antwerp-North), Telenet does not return a http 200 when requesting the data, thus causing the assertion to fail.

I noticed yesterday the Telenet servers did had some hickups. After retrying myself too, it didn't work at first but later yesterday evening it worked again without any code changes.
I don't have Telenet mobile neither (I have just created another custom integration to get Youfone.be mobile data into HA, which is way more cheaper and using Proximus network).
I checked the code again and I can confirm, if mobile is not enabled, no mobile specific requests will be executed.
So for now I will close this ticket, probably bad luck on timing with unstability at Teletnet backend servers.

It is working without problems now. Thank you for this very useful integration!


support adjustment of timestamps for part of logfile

some logfiles show an invalid timestamp at the beginning until a valid time is available on the device that logs. (e.g. on android adb logs the logs at startup do not have a valid timestamp)
there should be an option for the indexer to correct the times

I would close it as soon as we have already implementation of timestamp detecting


Fix autocompletion of half-completed import item

When completing behind a half-started identifier in an import list:
#import "path.typ": thi|",, the parent should be and ImportItemPath, which parent is ImportItems.
This bug make completion behind a half-started identifier in an import list NEVER possible.

Could you add tests for the half-started & unstarted cases?

There was a small bug in your fix: You used ctx.leaf.parent() in both cases, effectively requiring SyntaxKind::ImportItemPath == parent.kind() == SyntaxKind::ImportItems, which can never be true. I fixed it and added tests.

Thanks!


Odd behavior when running multiple test files.

I'm finding that all my tests within a single test_ file runs successfully when run with pytest pointing at the single file. But, if I run pytest with no arguments, so that it runs all my tests in all test_ files, they all fail. I'm sure I've done something incorrect in my setup, just unsure what.
My structure is that I create mock class in the global scope, then start and stop them within pytest's start and teardown functions. At the moment, I need to monkeypatch a few functions to some of the classes in moto to add/extend missing functionality, like VPC Endpoints create/modify/describe. So I need to inject those new functions into the classes before moto initiates them within moto_*().start(). Otherwise they don't seem to be available to moto if I attempt to patch them after the call to start().
from moto import mock_s3
import boto3
import pytest
from moto.ec2.responses import VPCs

MOCK_S3 = mock_s3()

def setup_function(function):
    # Patch before we start
    VPCs.create_vpc_endpoint = clnt_create_vpc_endpoint
    VPCs.describe_vpc_endpoints = clnt_describe_vpc_endpoints
    VPCs.modify_vpc_endpoint = clnt_modify_vpc_endpoint

    MOCK_S3.start()

def teardown_function(function):
    MOCK_S3.stop()

def test_one():
    <run boto calls>

def test_two():
    <run boto calls>

These all run fine at once, when just this test file is ran, but not when a set of files are ran.

When you say it doesn't work, can you clarify what that means? Is it that the modified VPC functions aren't there when running multiple files?
My first guess is that the VPC response has already been instantiated by the time it is getting to this file so the patching of the class happening here is too late.

The mocks are not in place, I get aws access key errors.

Two thoughts:

Instead of having MOCK_S3 be at the module-level, can you instantiate it in the setup and attach it to function for use in teardown_function?
The docs say: It is possible for setup/teardown pairs to be invoked multiple times per testing process. I am wondering if that might be part of the issue. Can you add some prints/pdbs to confirm if the setup/teardown are being called the appropriate number of times?

Sorry, this was actualy coming from another test file that another developer introduced. He put the boto3.client calls in the global scope of the file, instead of within the functions. This caused the boto module classes to be imported prior to the mock_*() calls in my test files, which kept moto from doing it's magic first.
Maybe there needs to be a check done in the sys.modules space within the mock_*() calls. If it finds that the boto modules that are to be mocked, it throws an error or warning.
import sys
if 'boto3' in sys.modules:
    raise Exception('boto3 was already imported, boto imports need to be done after calls to mock_ec2()')


[dv/otp_ctrl] Support lc_escalate_en

This PR adds a sequence to support lc_esc_en.
This PR has basic sequence and scb support.
The following TODOs will be implemented in coming PRs:

Add assertions when lc_esc_en is On.
Add random input to lc_esc_en, not just On and Off
Support key request and lc_esc_en happened in parallel

Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

actually i think it is clearer if I just use a separate sequence for lc_escalate_en. I will make the change soon.


[GLUTEN-7647][CH] Lazy expand for aggregation

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #7647
Reduce the size of data explosion of expand.

Move the expand after the aggregate which is in stage initial to intermedate.

Add a aggregate step after the expand for aggregating low cardinality grouping keys.

How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Run Gluten Clickhouse CI

improvement on ds q67
before

after


[Feature][WIP] support spillable hybrid hash join

What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

For #17541
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 5 / 7 (71.43%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
5
7
71.43%
[1262, 1901]

[FE PR Coverage Check]
:disappointed: fail : 5 / 7 (71.43%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
5
7
71.43%
[1262, 1901]

[FE PR Coverage Check]
:disappointed: fail : 3 / 5 (60.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
3
5
60.00%
[1261, 1262]

[FE PR Coverage Check]
:disappointed: fail : 3 / 5 (60.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
3
5
60.00%
[1261, 1262]


Useful configuration vars are not documented

There are some useful configuration variables that are not present in README.md or Vim docs. They should be added.
Maybe I'll do a pull request in later time but if you or anyone is willing to do so feel free.

Yes @oblitum, a PR would be greatly appreciated :) 💟

Ping @oblitum?

I don't recall which vars I was referring to and revising it now, it seems all that should be documented is already. Other vars left undocumented are just for internal use as far as I see. At the time I used then I guess, but then noticed that I should be using lengthmatters#highlight, etc, instead, for example.


TEBw9oVgu1GTmdq4WT3bhU5nagGg9Lwrey

https://github.com/justswaporg/justlists/issues/3326#issue-1514262665

No description provided.


Expose walker publicly on Designer

The only way i see to easily query a Definition is to manually create an instance of DefinitionWalker to use.  It seems like it would be more appropriate to use the walker property of Designer,  but it is private.
https://github.com/nocode-js/sequential-workflow-designer/blob/41549b6a009f0e38dc0f572c5aff9556da32586f/designer/src/designer.ts#L81-L87
This instance seems to be the source of "truth" for the rules to visiting/querying a definition. Would you consider changing walker to be a public property?

Hello @goldsam! Thanks for reporting. Basically you can use the DefinitionWalker class by creating an own instance.
import { DefinitionWalker } from 'sequential-workflow-model';
const walker = new DefinitionWalker();

Check this article.
But your idea I think may be helpfull for vanilla JavaScript applications, so please check the 0.18.1 version.
designer.getWalker();

@b4rtaz Thank you so much for the quick response! That change was very helpful!


Check security issues and library dependencies and lifecycle

e.g. in our Globits implementation we use an older version of log4j that does not have the the latest security issues.
However, that version is obsolete, EoL and should be upgraded.
We should also establish the github dependabots and surrounding procedures (i.e. who has the role of security manager, etc.)

More specifically the following references to log4j 1.2.x (1.2.16)
As 1.2 is end of life (EoL) and subject to several Common Vulnerabilities and Exposures


Extensibility Request: Integration of Third-Party Scripts in Obsidian Web Clipper

Hello, I want to contribute an idea, is it possible that within this plugin you can download scripts that plugin developers can create to explore more possibilities?
Let me explain, although I am not a programmer, suppose that the developer of plugin A, creates a function which can be downloaded from the configuration of Obsidian Web Clipper, which allows the content to be processed, grouped, classified, etc, I can not imagine the possibilities because they must be as many as creativity.
Greetings.

Great point @LeonelRFF.
It would be great to enable some pre-processing in Obsidian Web Clibber with LLMs before saving to Obsidian. Considering that the clipper gets the text and all available metadata from the page, it would be feasible to pass this data to an LLM to generate for example a summary, tags, ...
I'm not a coder, but, for example, danielmiessler/fabric gives many good prompts that could be applied to the text and the page metadata to automate and greatly improve the collecting process.
@kepano , do you think it could be done starting from your code? Is it an interesting and practical idea?
For sure, if feasible, it would be a really innovative idea capable of enabling fantastic new workflows .....

@fabioscarsi prompt variables are already supported, but not yet documented. You need to enable the feature by going to settings.html?section=interpreter

WOW!

it seems like we OpenAI key is mandatory and its not working with 3P models with OpenAI compatible API provider

The feature is not complete that's why it is not enabled yet.

@kepano, can we help you and start at least with some beta testing? Or is it too early? This feature seems to have really impressive potential ....

This works great with an OpenAI API key 👏 Thank you for sharing this beta feature 🫶

It works great with an OpenAI key but fails when using my local Ollama, saying it needs an OpenAI key.

I'm closing this since we've strayed off topic and the Interpreter feature is not yet live.


Errors

i get A error :

@Napoleon-x @lnxcz

Realshit is a value placeholder its empty because the data parsed from the returned json is not found.  I could fix it but im lazy your welcome to learn python and fix it yourself tho.


Does importing a structure require that "Entries in this section have their own URLs" be checked?

Whenever I use this plugin to import into a Structure and want the Ancestors to be correct, I always have to enable "Entries in this section have their own URLs".
Is this a limitation in Craft? Or am I not setting up my CSVs to import Ancestors properly?
Many times in my projects I don't want my structures to use templates or have unique URLs.
Love the plugin! Thanks

Hi, yes this has been a limitation I haven't been able to work around any other way.


Handling of allotments=plot

The editor currently doesn't seem to handle allotments=plot correctly (or I'm misunderstanding something, as usual).
According to the wiki allotment=plot is applied to an area.  Which I did.  But it seems that id is not treating it as a way with an implicit area=yes tag.
Why do I think that?  Because when I give the plot a name=* it is shown in the editor as a label on a way, not a label within an area.  This can be very confusing as allotments often have shared borders, so it's hard to determine which one the name applies to.  I kluge around this by adding an explicit area=yes just to get the name to show sensibly.  If tagging for the renderer is a venial sin then tagging for the editor is probably a mortal sin. :)
Should I be using name=* on a plot?  There's nothing to say I shouldn't and name applies to all objects.  True, the wiki on allotments=plot suggests using ref=whatever, but that doesn't get rendered.  Also, the original proposal gives this example by the proposal's author where the plot in question has a name=* not a ref=*.
Is it worth bothering since it doesn't get rendered anyway?  In this github issue, kocio-pl appears, in Oct 2017, to have taken cognizance of a desire to display plots, so it might appear in the near future.  Even if it never makes it into OSM's renderer, it's still useful to have such detail in the db and therefore it's nice if the editor handles it well.
If you want to check this on an allotment with more plots and the area=yes kluge, look here

The editor currently doesn't seem to handle allotments=plot correctly (or I'm misunderstanding something, as usual).  According to the wiki allotment=plot is applied to an area. Which I did. But it seems that id is not treating it as a way with an implicit area=yes tag.

You're correct, we don't have a preset for allotment=plot yet.  We can add one for it.  After we add the preset, iD will know that it can be an area feature, and won't require the area=yes tag.

Should I be using name=* on a plot? There's nothing to say I shouldn't and name applies to all objects. True, the wiki on allotments=plot suggests using ref=whatever, but that doesn't get rendered.

We can add fields for both name and ref.

Is it worth bothering since it doesn't get rendered anyway?

Yes - if people are mapping it, we add a preset for it.  Taginfo shows over 9000 instances of allotment=plot, so that's good enough for me.  We don't care in this project whether it gets rendered or not.

Thanks. :)

This is already been done in #4920. @bhousel do you think we can close this issue now? or is there anything that is to be done?

Oh yeah, thanks for the reminder @vershwal - I did forget to close it.
A useful tip:  if your commit message contains special language, GitHub will automatically close the issue.  See here for more info.
The first line in a commit message is special, so I usually put the magic comment on a separate line.  For example:
Added Preset for allotments=plot
(closes #4917)

A useful tip: if your commit message contains special language, GitHub will automatically close the issue. See here for more info.

Thank you @bhousel. I'll be using this from the next time.


Etda 1734

Axed bootstrap3.  Using Bootstrap 4.

Before this can be merged we need to move off of phantomjs/poltergeist


Device has no device or entity

I have a number of Meross Lan devices on the go set up through the HACS Meross LAN integration. We recently had an outage on the WIFI and I have managed to get everything working again apart from 1 310 smart socket attached to the kettle. It have installed it the same way as all the other and cross referenced the IP from the router which is also set to static on all my LAN devices on the router setting. I have also redone the device on the meross app directly but still doesn't recognise it in HA. It works perfectly in the app directly so the socket seems to be in working order and is set up exactly the same way as 8 other Meross LAN devices so not sure what needs to be tweaked.
Has anyone come across this issue or have any other way of getting a reliable feed to HA? I have the IOT for Meross too which does work but it is temperamental at times.

y first guess is the initialization code fails to manage the device setup but there should be a log for this

Thanks for getting back to me, it does not produce an entity so it doesn't show on the log book. Do you know where I can find a log for the action when I try to set it up?

I'll have to check this with latest HA core 2023.6.x since the newer UI might behave differently from the legacy one...
Itcould even be a bug in core itself or sometimes I've seen this happening when the meross_lan component files were corrupted somehow.
Even if maybe useless, a re-download of the meross_lan integration from HACS could fix the issue

I'll have to check this with latest HA core 2023.6.x since the newer UI might behave differently from the legacy one...
Itcould even be a bug in core itself or sometimes I've seen this happening when the meross_lan component files were corrupted somehow. Even if maybe useless, a re-download of the meross_lan integration from HACS could fix the issue

I redownload the HACS, restarted HA and it appeared perfectly, thanks for the tip.


Clock icons are referenced incorecctly

Package

[ ] lucide
[ ] lucide-angular
[ ] lucide-flutter
[ ] lucide-preact
[X] lucide-react
[ ] lucide-react-native
[ ] lucide-solid
[ ] lucide-svelte
[ ] lucide-vue
[ ] lucide-vue-next
[ ] Figma plugin
[ ] source/main
[ ] other/not relevant

Version
0.451.0
Can you reproduce this in the latest version?

[X] Yes
[ ] No

Browser

[X] Chrome/Chromium
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] iOS Safari
[ ] Opera
[ ] Other/not relevant

Operating system

[ ] Windows
[X] Linux
[ ] macOS
[ ] ChromeOS
[ ] iOS
[ ] Android
[ ] Other/not relevant

Description
'ClockArrowDownIcon' renders 'Clock'
'ClockArrowUpIcon' renders 'ArrowUp'
Steps to reproduce

Import ClockArrowDownIcon icon
Add to a React component/view
Run the react app
Notice that the ClockArrowDownIcon is rendering the 'Clock' icon

Same goes for 'ClockArrowUpIcon', but it's rendering the 'ArrowUp' icon.
Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)

I cannot reproduce this error:
https://codesandbox.io/p/sandbox/hardcore-wave-8wsdkj?workspaceId=4ddbaddd-ab88-4029-91a2-e5be8ed85e45
Can you share more of your code? (Maybe your imports, or any import overrides you might have)

I cannot reproduce this error too.
Check again your code.

Closing since no response was given.


Docker image not building on branch 0.5.0-rc on arm64

Building the docker image for branch 0.5.0-rc fails on arm64 because of the absence of gcc.
Switching to python:3.11 (not slim) seems to solve the problem.
Here the log:
  Building wheel for bitstruct (pyproject.toml): started
  Building wheel for bitstruct (pyproject.toml): finished with status 'error'
  error: subprocess-exited-with-error

  × Building wheel for bitstruct (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.linux-aarch64-cpython-311
      creating build/lib.linux-aarch64-cpython-311/bitstruct
      copying src/bitstruct/__init__.py -> build/lib.linux-aarch64-cpython-311/bitstruct
      running egg_info
      writing src/bitstruct.egg-info/PKG-INFO
      writing dependency_links to src/bitstruct.egg-info/dependency_links.txt
      writing top-level names to src/bitstruct.egg-info/top_level.txt
      reading manifest file 'src/bitstruct.egg-info/SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      adding license file 'LICENSE'
      writing manifest file 'src/bitstruct.egg-info/SOURCES.txt'
      copying src/bitstruct/bitstream.c -> build/lib.linux-aarch64-cpython-311/bitstruct
      copying src/bitstruct/bitstream.h -> build/lib.linux-aarch64-cpython-311/bitstruct
      copying src/bitstruct/c.c -> build/lib.linux-aarch64-cpython-311/bitstruct
      running build_ext
      building 'bitstruct.c' extension
      creating build/temp.linux-aarch64-cpython-311
      creating build/temp.linux-aarch64-cpython-311/src
      creating build/temp.linux-aarch64-cpython-311/src/bitstruct
      gcc -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.11 -c src/bitstruct/bitstream.c -o build/temp.linux-aarch64-cpython-311/src/bitstruct/bitstream.o
      error: command 'gcc' failed: No such file or directory
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for bitstruct
Successfully built paho-mqtt asn1tools
Failed to build bitstruct
ERROR: Could not build wheels for bitstruct, which is required to install pyproject.toml-based projects

[notice] A new release of pip is available: 23.2.1 -> 23.3.1
[notice] To update, run: pip install --upgrade pip
The command '/bin/sh -c pip install --no-cache-dir -r requirements.txt' returned a non-zero code: 1

Can you please try again with the updated Dockerfile?

Yes, the updated Dockerfile solves it.


RStudio and VSCode try to connect to HTTP

In the connection flow, there is a redirect to an http session (before being sent back to https) that makes thing impossible to work on networks filtering http traffic (the first call, normally answered with a redirect, never makes it to OpenShift).
Investigate NGINX configuration.
Original Issue: https://github.com/opendatahub-io-contrib/workbench-images/issues/34
Related conv:  https://odh-io.slack.com/archives/C0330L52N22/p1694538000643369

Related-to: https://github.com/opendatahub-io/opendatahub-community/issues/72

solved, tested in our corporate environment. Scheme is now based on original request, so that when we start with https, it is https all the way, and when we start with http, more for dev purposes, it is http all the way.


compose (io.reactivex.ObservableTransformer) in observable cannot be applied to  (com.trello.rxlifecycle2.LifecycleTransformer)

The code is as follows:
Observable.just(1)                         .compose(RxLifecycle.bindUntilEvent(context.lifecycle(), ActivityEvent.DESTROY));
Tips are as follows:
compose (io.reactivex.ObservableTransformer<Object>) in observable cannot be applied to  (com.trello.rxlifecycle2.LifecycleTransformer<Object>)
If I use the Flowable,Tips are as follows:
compose (io.reactivex.FlowableTransformer<Object>) in observable cannot be applied to  (com.trello.rxlifecycle2.LifecycleTransformer<Object>)
In fact, I want to a custom FlowableTransformer,the code is as follows:
`
public FlowableTransformer<T, T> io_main(final RxAppCompatActivity context) {
return new FlowableTransformer<T, T>() {
        @Override
        public Publisher<T> apply(Flowable<T> flowable) {

            return  flowable
                    .subscribeOn(Schedulers.io())
                    .doOnSubscribe(new Consumer<Subscription>() {
                        @Override
                        public void accept(Subscription subscription) throws Exception {
                            DialogHelper.showProgressDlg(context, mMessage);
                        }
                    })
                    .subscribeOn(AndroidSchedulers.mainThread())
                    .observeOn(AndroidSchedulers.mainThread())
                    .compose(RxLifecycle.bindUntilEvent(context.lifecycle(), ActivityEvent.DESTROY));
        }
    };
}

`
compose(RxLifecycle.bindUntilEvent(context.lifecycle(), ActivityEvent.DESTROY)) prompt error
Looking forward to your help, thank you

If you're using Java 7 for compilation then you may need to include hints for the generics, like so:
Observable.just(1).
  compose(RxLifecycle.<Integer, ActivityEvent>bindUntilEvent(lifecycle(), ActivityEvent.DESTROY))

I try according to your proposal,but there is a problem, prompt is as follows

Looking forward to your help, thank you

It works，thank you


Do not capture E_ERROR type as fatal error

This should fix #408, can you guys please test it and and let me know if this is the way we should handle this or an alternative.
IMO this gist is that we should ignore E_ERROR exceptions as fatal in PHP 7.0+ since they can be captured by userland and are thus going through the regular exception handler before entering the fatal error handler thus creating duplicated exceptions.

I'll test this ASAP!
Maybe we can add a thing to this PR: update the PHPDoc of the Client::captureException() method to accept \Throwable|\Exception $exception here: https://github.com/getsentry/sentry-php/blob/0baca06aa08bb622338deb000cad7ffa2a258e29/lib/Raven/Client.php#L561-L570
What do you think?

I think that's a good idea.
For reference: why not remove \Throwable (this was my first thought)? This is because \Throwable was introduced in PHP 7.0 so \Exception remains for PHP < 7.0.

Also: maybe we should add a (unit) test?

@Jean85 I changed the test to check if the output of the shouldCaptureFatalError is correct. But not actually checking if this works correctly, any idea on how to test this? Cannot just call an undefined method since that does not seem to trigger this (tried adding a failing test before).

Sorry, I missed the changed test, I think it's enough for now!

What are you all doing to capture fatal PHP errors, such as allowed memory size exhausted?  To capture this fatal error successfully, I had to comment out the return FALSE; in shouldCaptureFatalError():
if (PHP_VERSION_ID >= 70000 && $type === E_ERROR) {
  // return false;
}

sample code:
<?php
include '../vendor/autoload.php';
$client = new Raven_Client('...');
$client->install();
while (TRUE) {
  $a[] =<PHONE_NUMBER>1;
}


build failing for service.go

$ go build
github.com/vfarcic/docker-flow-swarm-listener
./service.go:40: unknown types.ServiceListOptions field 'Filter' in struct literal

That's strange. I just deleted all the dependencies and built the binary without changing anything. Can you paste the output with the error?

This are the steps I use to reproduce:
$ which go
/usr/local/bin/go
$ go version
go version go1.7.4 darwin/amd64
$ go get -u github.com/vfarcic/docker-flow-swarm-listener
github.com/vfarcic/docker-flow-swarm-listener
vfarcic/docker-flow-swarm-listener/service.go:40: unknown types.ServiceListOptions field 'Filter' in struct literal
...
The above also downloads github.com/docker/docker with the docker/docker/api/types/client.go with the following struct:
// ServiceListOptions holds parameters to list  services with.
type ServiceListOptions struct {
Filters filters.Args
}
Hope this helps.

You're right. I'm not sure what happened (whether one of the libraries changed in the meantime or...). Anyways, it's fixed. Thanks for letting me know.


Create Krishnangshu Paul

C++ program to create numbers pyramid

@Krish-Paul thanks for contributing.
and also star this repo

Thank you for your response. I've received a mail for the merge (PR#38) but
in the hacktoberfest profile it is showing NOT ACCEPTED
Could you kindly guide me through this?
Thanking you,
Krishnangshu Paul.
On Wed, 12 Oct, 2022, 6:45 pm Pavan Kamthane, @.***>
wrote:

Merged #38 https://github.com/Pavan-Kamthane/Cpp_Lang/pull/38 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/Pavan-Kamthane/Cpp_Lang/pull/38#event-7571785864, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A3RCDATCG6G7OXWQJVBNLELWC22XFANCNFSM6AAAAAARDITVJY
.
You are receiving this because you were mentioned.Message ID:
@.***>

It will update after 15min I think


proxy: stats proxybe to show bad backends

stats command intended for backend state information.
so far just outputs "bad_label" [count] for each backend currently marked bad. The count is the number of backend objects marked bad.
If in "per worker thread mode" (default) if all workers recognize the backend as down, the count will be the same as the number of worker threads. If the IO thread is in use it would be 1.
If a backend has normal status, it is not included in the output.
TODO:

[ ] was hand testing.. need a specific unit test.

sharedvm thing is pretty convenient for doing this, but isn't the fastest and is globally locked either way. Thus trying to only poke it when things go into and out of bad status. Counting "alive" backends would hit the shared state a lot harder.
Other things could be added in the future, like a failure count if it is marked bad, retries since marked bad, etc.
I know there's been a request to see all of the configured backends but I'm not completely convinced this is a good idea - they wouldn't be organized into pools or anything, but a randomly ordered list of backends. Printing all of the pools and their backends would require querying the configure thread instead and having it iterate things... so a different problem.

In writing the unit test I ran into a bug I'd seen before: if a backend connection fails after the TCP connection is established it will never be marked bad. The bad status and failure count were being reset after the TCP connection was established, but it should have been after the full validation stage.
So this fixes that too, or else tests couldn't run. I was going to try to upstream the fix first but this whole change is trivial so it can go together.

merged up, whoop.


Create a project vault

Enhance the current solution, so the project will have an own credentials/key/token vault. This will enable to store credentials for team to access own systems, customer systems or to store credentials compromised during the pentest. The latter will help the team to report such cases to the customer.

Added in https://github.com/reconmap/reconmap/blob/master/CHANGELOG.md#110


Include a mechanism to indicate that titers that are estimated to be out of bounds in summary plots

In summary plots, currently, we do not show titers for strains where the NT50 is estimated to be out of bounds of the assay if the curve does not contain a max infectivity value of at least a certain value (as designated in config). This is because these values are filtered prior to plotting. However, we also do not show titers for strains where the NT50 was unable to be calculated from the barcode counts data. As these are different results, I think it would be useful to be able to visually distinguish between these scenarios. In addition, it would be beneficial when a titer is out of bounds to indicate on the aggregate titers plot that the titer is at the upper or lower bound.

I should be able to add reporting of this when I add the reporting of the rmsd in this issue as I have to update that part of the code anyway to add rmsd.


Feature Request: additional logic for error checking during attribute collection.

PJ: DLA-X30
Version: v2.0.0a2 installed from HACS
When there is no signal to the pj the script seems to fail when attempting to determine the picture mode attribute . This also impacts the ability to capture attribute states until the pj has HDMI signal again or when the next scan interval occurs AND there is HDMI signal. Example: switched to HDMI 2 w/ no signal and script repeated the error.  However when there is a signal on the active hdmi input the script completes.
Providing both sets of logs (with and w/o errors). Having some additional logic may help remedy this. Thanks for the great work!
Logs for no signal on the active HDMI input
2022-08-20 13:10:00.193 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:00.204 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:00.204 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] sending write_only operation: n͟u͟l͟l͟c͟m͟d
2022-08-20 13:10:00.314 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:03.406 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:03.443 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:03.443 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 13:10:03.566 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:03.568 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 13:10:07.675 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:07.686 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:07.687 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 13:10:07.813 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:07.813 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 13:10:10.900 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:10.910 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:10.910 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: s͟i͟g͟n͟a͟l
2022-08-20 13:10:11.013 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:11.013 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] the state of command group: s͟i͟g͟n͟a͟l is: n͟o͟_͟s͟i͟g͟n͟a͟l
2022-08-20 13:10:14.129 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:14.144 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:14.145 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 13:10:14.264 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:14.264 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 13:10:17.361 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:17.370 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:17.371 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: i͟n͟p͟u͟t
2022-08-20 13:10:17.463 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:17.464 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] the state of command group: i͟n͟p͟u͟t is: h͟d͟m͟i͟1
2022-08-20 13:10:20.576 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:20.585 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:20.585 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 13:10:20.715 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:20.716 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 13:10:23.804 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:23.817 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:23.817 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: l͟a͟m͟p
2022-08-20 13:10:23.914 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:23.915 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] the state of command group: l͟a͟m͟p is: l͟o͟w
2022-08-20 13:10:27.009 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:27.026 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:27.026 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 13:10:27.116 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 13:10:27.116 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 13:10:30.203 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 13:10:30.215 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 13:10:30.215 DEBUG (SyncWorker_4) [jvc_projector_remote.jvcprojector] reading from command group: p͟i͟c͟t͟u͟r͟e͟_͟m͟o͟d͟e2022-08-20 12:46:30.018 ERROR (MainThread) [homeassistant.components.remote] Error while setting up jvcprojector platform for remote
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvccommands.py", line 107, in __verify_ack
ACK = sock.recv(COM_ACK_LENGTH)
TimeoutError: timed out
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 281, in _async_setup_platform
await asyncio.shield(task)
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/jvcprojector/remote.py", line 36, in setup_platform
JVCRemote(name, host, password, port, delay, timeout, retries),
File "/config/custom_components/jvcprojector/remote.py", line 71, in init
"unknown" if not self._state else self._jvc.command("picture_mode")
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 202, in command
return self._send_command(getattr(Commands, commandl[0]))
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 167, in _send_command
result = command.read(jvc_sock)
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvccommands.py", line 184, in read
self.__verify_ack(sock, command)
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvccommands.py", line 125, in __verify_ack
raise JVCCommunicationError(
jvc_projector_remote.jvccommands.JVCCommunicationError: Timeout when waiting for the specified ACK: b'\x06\x89\x01PM\n' for command: picture_mode with bytes: b'?\x89\x01PMPM\n'
Logs when there is a signal on the active HDMI input
2022-08-20 14:14:08.514 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] initialising JVCProjector with host=XXXXXXX, password=, port=20554, delay=600.0, connect_timeout=10, max_retries=10
2022-08-20 14:14:08.514 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Sending nullcmd to XXXXX:͟2͟0͟5͟5͟4 to verify connection
2022-08-20 14:14:08.524 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:08.553 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:08.553 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] sending write_only operation: n͟u͟l͟l͟c͟m͟d
2022-08-20 14:14:08.674 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:09.347 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:09.358 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:09.358 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 14:14:09.644 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:09.644 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 14:14:10.314 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:10.328 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:10.328 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 14:14:10.438 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:10.439 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 14:14:11.114 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:11.129 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:11.129 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: s͟i͟g͟n͟a͟l
2022-08-20 14:14:11.224 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:11.224 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: s͟i͟g͟n͟a͟l is: a͟c͟t͟i͟v͟e͟_͟s͟i͟g͟n͟a͟l
2022-08-20 14:14:11.908 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:11.924 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:11.924 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 14:14:12.030 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:12.031 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 14:14:12.746 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:12.774 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:12.775 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: i͟n͟p͟u͟t
2022-08-20 14:14:12.939 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:12.939 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: i͟n͟p͟u͟t is: h͟d͟m͟i͟1
2022-08-20 14:14:13.611 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:13.618 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:13.618 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 14:14:13.729 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:13.729 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 14:14:14.533 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:14.562 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:14.562 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: l͟a͟m͟p
2022-08-20 14:14:14.692 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:14.692 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: l͟a͟m͟p is: l͟o͟w
2022-08-20 14:14:15.371 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:15.383 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:15.383 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: p͟o͟w͟e͟r
2022-08-20 14:14:15.543 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:15.543 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: p͟o͟w͟e͟r is: l͟a͟m͟p͟_͟o͟n
2022-08-20 14:14:16.218 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Attempting handshake
2022-08-20 14:14:16.227 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] Handshake successful
2022-08-20 14:14:16.227 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] reading from command group: p͟i͟c͟t͟u͟r͟e͟_͟m͟o͟d͟e
2022-08-20 14:14:16.375 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] command sent successfully
2022-08-20 14:14:16.376 DEBUG (SyncWorker_3) [jvc_projector_remote.jvcprojector] the state of command group: p͟i͟c͟t͟u͟r͟e͟_͟m͟o͟d͟e is: u͟s͟e͟r͟1

Thanks, good catch. I already handle the error in the python library, so a small change to this component should be able to catch the JVCCommunicationError and output a nice message.

This should be implemented in the commit referenced above. If needed ASAP, then install the 'master' branch instead of a specific version. Otherwise, it will be included in the next release for v2.0.0.


feat(shell): revert from naked shell to pkgs.mkShell + unsetting irrelevant env vars

closes https://github.com/cachix/devenv/pull/498
fixes https://github.com/cachix/devenv/issues/497

Also fixes https://github.com/cachix/devenv/issues/486.

Ok I tested this against the flake in rules_ll and things seem to work fine. This change of course leads to more environment variables being set than before, but at least we know that it won't break existing more "exotic" C++ toolchains 😊

It seems that Nim is broken in nixpkgs, not here: https://hydra.nixos.org/build/213226629

It seems that Nim is broken in nixpkgs, not here: https://hydra.nixos.org/build/213226629
Possible fix NixOS/nixpkgs#222285

Thanks, I removed irrelevant change.

Also my neovim could not find tsserver installed by languages.typescript.enable = true;. It was working when I use the standard mkShell.

Although this patch addresses a lot of issues I am still seeing some issues on nix-darwin, specifically with CoreFoundation.

Hi, sorry may I ask is there any update on this PR?

I mainly would like people to test it thoroughly before it's merged.

I think it will be easier for people to test if we merge after all the CI check passed. If there is any issue, we can create a PR to fix. WDYT?

I was actually wondering: What are the benefits of unsetting all those environment variables? I didn't really get the "keep it lean" comment.

Hi, how long do we expect people to test this out before merging?

I've updated this branch in my fork: https://github.com/bobvanderlinden/devenv/tree/feat/stripped-shell
There will be some regressions when merging this. Question is whether that is a good thing (honestly do not know).
With mkNamedShell, LD_LIBRARY_PATH was set based on packages. This is not the case anymore. This is partly a good thing, as I think setting potentially 'injecting' many libraries using LD_LIBRARY_PATH will cause problems like https://github.com/cachix/devenv/issues/555.
This is why the python-poetry example needed a change:
https://github.com/bobvanderlinden/devenv/commit/b669f22a471e06fd356e04b5b63cbb2da5fe5e2e#diff-3ea46e5d7bf8933097511b155be31bf25b2c6e01081c6d9a6dfe61624717082aR4
Question is whether setting LD_LIBRARY_PATH inside mkShell should now be added again.
Maybe as an alternative we should introduce a different option. Something like runtimeLibraries = [ pkgs.zlib ] instead of packages = [ pkgs.zlib ], which is meant to solely set LD_LIBRARY_PATH and DYLD_LIBRARY_PATH. People can still use it, but need to do so more explicitly.
The real solution is for people to not rely on pre-built binaries, but I think that's the world we live in right now. devenv is a good middleground for that.

LD_LIBRARY_PATH should not be set at all if possible. I think the linked python-poetry change is desirable.

Maybe as an alternative we should introduce a different option. Something like runtimeLibraries = [ pkgs.zlib ] instead of packages = [ pkgs.zlib ], which is meant to solely set LD_LIBRARY_PATH and DYLD_LIBRARY_PATH. People can still use it, but need to do so more explicitly.

IMO it's risky to let users unknowningly manipulate these variables, but if it's explicit it could be a viable option. Though I wonder whether such an option is actually necessary. Personally, I think I'd prefer explicitly setting LD_LIBRARY_PATH="${somepackage}/lib/" manually or do something similar to what you did in python-poetry.

is it possible now to add openssl dev deps?

Yes, the packages are added as nativeBuildInputs.
See https://github.com/NixOS/nixpkgs/blob/3ed18a352739221ebaba0d11c38a2158faa29887/pkgs/build-support/mkshell/default.nix#L37

Personally, I think I'd prefer explicitly setting LD_LIBRARY_PATH="${somepackage}/lib/" manually or do something similar to what you did in python-poetry.

There are people already relying on just adding runtime libraries as packages. Having a separate option for runtimeLibraries will make it a bit clearer how to migrate. It also allows to document what it does and why it is a bad idea to use it. The specific use-cases where it's the only option is also good to mention in the docs.
I agree it's a bad idea in general, but shipping binaries is the underlying problem. That's sometimes quite hard to get around when using ruby/python/node package managers.

This seems like the right thing to do. Setting LD_LIBRARY_PATH comes with troubling consequences, which are additionally quite hard to debug unless one knows already what's going on.

I've done testing today on examples on top of #745 and python-poetry example fails with
+ poetry run python -c 'import numpy'
Traceback (most recent call last):
  File "/tmp/python-poetry_nj6_mkml/.venv/lib/python3.10/site-packages/numpy/core/__init__.py", line 23, in <module>
    from . import multiarray
  File "/tmp/python-poetry_nj6_mkml/.venv/lib/python3.10/site-packages/numpy/core/multiarray.py", line 10, in <module>
    from . import overrides
  File "/tmp/python-poetry_nj6_mkml/.venv/lib/python3.10/site-packages/numpy/core/overrides.py", line 6, in <module>
    from numpy.core._multiarray_umath import (
ImportError: libz.so.1: cannot open shared object file: No such file or directory

We'll need to fix this one, any ideas? I tried adding pkgconfig to the deps and explicilty setting zlib.dev as a package.

Great, thanks for bringing this forward. Closing this PR.

Thank you for making this happen :heart:

I imagine
this instance of zlib.h not found

creating build/temp.linux-x86_64-cpython-310/pybedtools/include
gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -I/nix/store/ixvka49i2mjnxzk8l8anykc1idilws1r-libxcrypt-4.4.36/include -fPIC -Ipybedtools/include/ -I/tmp/tmpd_84vc8x/.venv/include -I/nix/store/50kabpj0s79040a42b7jj2dxn85wmbfd-python3-3.10.13/include/python3.10 -c pybedtools/cbedtools.cpp -o build/temp.linux-x86_64-cpython-310/pybedtools/cbedtools.o
In file included from pybedtools/include/bedFile.h:16,
from pybedtools/cbedtools.cpp:802:
pybedtools/include/gzstream.h:35:10: fatal error: zlib.h: No such file or directory
35 | #include <zlib.h>
|          ^~~~~~~~
compilation terminated.
error: command '/nix/store/6jnx2r93796cnqr5dznrgc1bwgyl488b-devenv-profile/bin/gcc' failed with exit code 1
at /nix/store/1hhzpyy8rvjavf894qy0r98hq8ah59qb-python3.11-poetry-1.7.1/lib/python3.11/site-packages/poetry/installation/chef.py:164 in _prepare
160│
161│                 error = ChefBuildError("\n\n".join(message_parts))
162│
163│             if error is not None:
→ 164│                 raise error from None
165│
166│             return path
167│
168│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:
Note: This error originates from the build backend, and is likely not a problem with poetry but with pybedtools (0.9.1) not supporting PEP 517 builds. You can verify this by running 'pip wheel --no-cache-dir --use-pep517 "pybedtools (==0.9.1)"'.

is another of https://github.com/cachix/devenv/pull/507#issuecomment-1660105656,
in this case, from
devenv devshell in flake.nix + pyproject.toml.

    devShells =
      forEachSystem
      (system: let
        pkgs = nixpkgs.legacyPackages.${system};
      in {
        default = devenv.lib.mkShell {
          inherit inputs pkgs;
          modules = [
            {
              packages = with pkgs; [
                atuin
                bat
                bedtools
                gcc
                gh
                git
                gnumake
                htslib
                lazygit
                poethepoet
                ripgrep
                starship
                tree
                zlib
                zlib.dev
                zsh
              ];

              dotenv = {
                enable = true;
                filename = ".env";
                # disableHint = true;
              };

              pre-commit.hooks = {
                alejandra.enable = true;
                ruff.enable = true;
                pyright.enable = true;
              };

              difftastic.enable = true;

              languages.python = {
                enable = true;
                package = pkgs.python310;
                poetry = {
                  enable = true;
                  activate.enable = true;
                  install = {
                    enable = true;
                    installRootPackage = true;
                    groups = [
                      "lint"
                      "test"
                      "docs"
                      "workflows"
                    ];
                  };
                };
              };
            }
          ];
        };
      });

with
[tool.poetry.dependencies]
pybedtools = "0.9.1"

If this isn't a mistake, is there a recommended workaround?


Speed up top-k retrieval on filtered conjunctions.

A while back we added an optimized bulk scorer that implements block-max AND, this yielded a good speedup on nightly benchmarks, see annotation FP at https://benchmarks.mikemccandless.com/AndHighHigh.html. With this PR, filtered conjunctions now also run through this optimized bulk scorer by doing two things:

It flattens inner conjunctions. This makes queries initially written as something like +(+term1 +term2) #filter rewritten to +term1 +term2 #filter.
It evaluates queries that have a mix of MUST and FILTER clauses evaluated through BlockMaxConjunctionBulkScorer by treating FILTER clauses as scoring clauses that produce a score of 0.

Thanks @benwtrent !


day 17

fix: day 16 part 1 wip
feat: day 16 done
chore: day 17 part 1 wip

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

423 of 427 (99.06%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.6%) to 96.779%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main.rs
0
1
0.0%

src/shared/mod.rs
0
1
0.0%

src/day_16/mod.rs
255
257
99.22%

Files with Coverage Reduction
New Missed Lines
%

src/main.rs
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.6%

Covered Lines:
1923

Relevant Lines:
1987

💛  - Coveralls


Class names...

https://github.com/Jeffchiucp/Weather-Forecast_React_Redux/blob/2003cfb39f490f97fe15b6e44310c7a96c612c24/src/containers/SearchBar/index.js#L35
You're using class names here. Might as well use these everywhere instead of using inline styles.

update the class name


Carla: properly wrap plugin programs

Motivation for this change
Fixes #67923. @suhr could you test that it works for you?
Also enabled parallel building because it's way faster.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
I'm not sure that is necessary

Now it indeed works, though carla-patchbay vst seem to load carla-rack instead.

Bumped into the pyQt5 problem with Carla VST today.
I am going to try this. If this works, it would be nice to see this merged asap :D

@minijackson did you make any unpublished progress since september?

@jpotier no, I think this is all I have

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/96

@suhr

Now it indeed works, though carla-patchbay vst seem to load carla-rack instead.

Is this a problem with nixpkgs/this patch or with Carla?

I have no idea.

Hmm.
At least:

It is definitely an improvement over the current version, and this could be merged now.


The reporter doesn't work properly for Playwright with TypeScript

I was looking for a simple terminal-reporter in order to improve my Playwright test results when I saw indent-list-reporter. The functionality is all I need, but unfortunately I cannot make the reporter run with my project. The reporter is failing to import my playwright.config.ts file.
I tried to debug, and it seems like the import for the playwright.config.ts is failing. The first reason was an external package for managing env vars that I use - https://www.npmjs.com/package/envconfig  and then it reverts to playwright.config.js
Did you mean to import dotenv-defaults/config.js?
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/playwright-e2e-testing/playwright.config.js' imported from /playwright-e2e-testing/node_modules/indent-list-reporter/dist/src/loggin-tests-data.js

I also tried removing the problematic package completely which triggered the indent-list-reporter, but it failed right after because of:
Error in reporter TypeError: Cannot read properties of undefined (reading 'file')

Which fails here:
const fileLocationStyle = styleErrorFileLocation(error.location);
Am I doing something wrong, or just there is no proper support for TypeScript yet? :)
On another note: I think it is not great to hardcode the playwright config file as there are a lot of examples where the name could be different or there might be even multiple config files where we would like to use the reporter.

Hi @vgagaleski. Thank you for opening the issue. Hm yes the TS config is tricky, I tried to solve it before, I tried a different solution which I thought fixed the problem but look like that's not the case. I tested with the npm link feature to import the package. I will try to debug again and release a in the next two weeks. About the config naming, thank you that is a really good idea, I have not thought about that before. I will include this with the fix too.
Thank you!!

The same issue:
SyntaxError: Cannot use import statement outside a module
Error in reporter TypeError: Cannot read properties of undefined (reading 'file')
Any updates?


revert to last good version of notebook #126

This reverts the broken notebook. In the process, the additions for S3 buckets have been removed. This is a temporary measure - we need to further develop all of the content so it can be run on both cloud and local platforms, probably with sections like
if you are on AWS do this:
if you are local do this:
which would be deleted as appropriate for a given training course

closes #126


AMD Encoding does not work with default configuration settings

It seems even with default AMD encoding settings, the stream does not play correctly on Glimesh. The thumbnail generation also fails so we'll need some help figuring out why.
Here's an example configuration with the Advanced settings shown:

I also tested saving some raw H264 packets to a file, and VLC will play them successfully if encoded with x264 but not with the AMD encoder.

Here's a screenshot of a non-working nvidia config:


[Docs] Add documentation for selectable

selectable is an alias for fillable, but that's not mentioned on the docs site.

Can we use the @alias tag? http://usejsdoc.org/tags-alias.html

That's what I was thinking. Don't know what Markdown that results in, but it should be a starting point.

@san650: @alias doesn't work, because it overwrites the original name. I found a workaround though. Creating a PR.

@san650: See https://github.com/san650/ember-cli-page-object/pull/146. I'd be happy to hear your feedback.


[SPARK-23932][SQL][FOLLOW-UP] Fix an example of zip_with function.

What changes were proposed in this pull request?
This is a follow-up pr of #22031 which added zip_with function to fix an example.
How was this patch tested?
Existing tests.

Test build #95133 has started for PR 22194 at commit 967360a.

cc @techaddict

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2469/
Test PASSed.

@ueshin LGTM

Merged to master.

Test build #95133 has finished for PR 22194 at commit 967360a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95133/
Test PASSed.

Merged to master.


Parallelize tests and implement CmdArgument for TempDir

I did this because I thought the tests were slow because of --test-threads=1, but it turns out it's because doctests are just inherently slow, so this doesn't actually improve the speed.
It does allow tests to be run with cargo test (at least if the test helper binaries are built), which is nice.
I also changed it to avoid creating tempfiles in the project root, and removed the corresponding entries in .gitignore.
To do this, I added a CmdArgument for TempDir, which I think is super useful, so I made it an optional feature.
You can enable the tepdir feature to enable the CmdArgument for TempDir, which enables the optional dependency on tempfile.

Hmm, I think I'd prefer not making this change. For the doctests: I think that the main concern should be what would be the best documentation for users. And introducing a tempdir is not really useful and might even be confusing. And by default it doesn't even work for users, since the tempdir feature is not enabled. And for the unit tests: I think introducing a tempdir as an argument to cmd! is not really nice, because it moves the tests slightly further away from the real use-cases that are tested. And personally I have nothing against how in_temporary_directory works.
I do agree that it'd be nice to solve the problems this PR solves: Allowing cargo test to work out of the box and avoiding to write test files into the root directory of the repo. But I think there are different solutions for these problems, that don't come with the above-mentioned drawbacks. For example we could wrap the doctests in in_temporary_directory and comment the lines where that happens, so that they don't show up in the docs. And to allow cargo test, we could have a test wrapper (similar to in_temporary_directory) that acquires a global lock.
But yeah, you also wrote that the initial intention for this PR was to make the tests faster. I agree that that would be great! At the same time I also think that the two solvable problems from above don't have a really high priority. So I would propose to close this PR unmerged. If you feel that either of the two problems are really important, of course feel free to open issues or PRs for them.
What do you think?

I definitely agree with a lot of your points. The doctests should be as good as possible, and definitely shouldn't rely on an optional feature. That could be done with, instead of having a CmdArgument implementation for &Tempdir, just using CurrentDir:
let tmpdir = Tempdir::new().unwrap();

cmd_unit!(%"touch foo", CurrentDir(tmpdir.path()));

I think that I find in_temporary_directory to just be "weird", and removing it would make the tests clearer to me, and closer to how tests in usually work. I kind of suspect that other rust developers might feel similarly, i.e. they expect tests to just run concurrently, and not modify the global current dir.
One non-aesthetic downside of in_temporary_directory is that if we made it take a lock, then it would be a bug to call the std::env functions without acquiring that lock, since a concurrent in_temporary_directory call might be munging them.

Closing in favor of solving these problems (parallelize tests, get rid of weird in_temporary_directory, not writing test files into the repo root) in subsequent PRs individually. (If we care enough.)


Setting the default editor font size to be smaller on mobile devices.

Mobile default:

Desktop default:

Reducing the line number column to reserve for 3 digits wide. (most kids aren't going to have more than 999 lines of code).


let expiry recover from subprocess errors

Codecov Report

Merging #630 (c67d481) into master (7ee475a) will increase coverage by 0.00%.
The diff coverage is 26.08%.

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   44.21%   44.22%
=======================================
  Files          45       45
  Lines        6877     6881    +4
=======================================
+ Hits         3041     3043    +2
- Misses       3836     3838    +2

Impacted Files
Coverage Δ

assemblyline_core/expiry/run_expiry.py
61.45% <5.55%> (-0.81%)
:arrow_down:

assemblyline_core/server_base.py
82.02% <100.00%> (-0.11%)
:arrow_down:

assemblyline_core/dispatching/dispatcher.py
75.27% <0.00%> (+0.21%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix bug coercing arguments that are lists

This would previously result in an empty list or error. This looks like it was just missed when converting from a for loop into using util.map.

Thanks!


refactor(v2): use ejs for SSR HTML template

Motivation
Use ejs templates for SSR. This makes the template a bit easier to read and comes with some utilities like trimming and escaping. I decided to make it a JS file so that I don't have to add an EJS webpack loader just for the template file. Not the prettiest, but I don't expect that we change this file often.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Netlify.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Is there a way we can suppress this 😢

Is there a way we can suppress this 😢

I'll look into it. It's a webpack warning I think. Quite annoying.