Fixed styling bug in the spectrogram canvas height

Short description of changes:
There was a bug in the spectrogram canvas height displayed. Somehow this was more evident in retina displays, but affected all nonetheless.
Breaking in the external API:
None
Breaking changes in the internal API:
None
Todos/Notes:
None
Related Issues and other PRs:
N/A

@zlapper can you provide a screenshot of the height issue?

@entonbiba sure thing!
Before fix:

Notice how, altough the canvas element has the height="256" property, it is being rendered as 128px. Notice also that there is a (css) style for the width, but not for the height.

After fix:

Here you can see the element being rendered correctly, just by adding the height value to the element styles.
Regarding @katspaugh's comment, I have the same impression, but it is not necessary according to my tests (i.e. the height style value ends up being 128px, not 256px, as the element height property). I might be confused, tho :)

@zlapper  I noticed the sample you used is old and using an outdated version of the library. can you confirm the same issue is happening with this sample?
http://codepen.io/entonbiba/pen/Bpmqrq

any feedback @zlapper?

I suggest we close this if there is no more feedback.

@zlapper please refer to the following sample which uses an updated version for testing. If issue persists you can reopen this pr.
http://codepen.io/entonbiba/pen/Bpmqrq
closing for now.


Not able to install quantum-grove in Windows 10

I am trying to install quantum-grove through Anaconda and also using "pip install -e " after downloading the grove-master zip file. But there is error every time. I have attached the screenshot what it is saying every time. I have already installed pyquil-master using "pip install -e", no issue occurred at that time.

Thanks for reporting this @riyasett . We'll have a look and update you if we find out what happened.
@mpharrigan would you mind taking a stab at this?

Hello,
Finally, it worked. I don't know how. I was just kept trying to install it in the same way and it is finally installed. Thank you all...

@riyasett Glad to hear it finally worked. I will close this ticket now. Feel free to re-open if you run into any new troubles


Using redis-commander in docker-compose returns error

I'd like to use redis-commander to view contents in a web gui using the following docker-compose file:
version: "3"
services:
  tile38:
    image: tile38/tile38:latest
    ports:
      - 9851:9851
  redis-commander:
    image: rediscommander/redis-commander:latest
    environment:
      - REDIS_HOST=tile38
      - REDIS_PORT=9851
    ports:
      - "8081:8081"
    depends_on:
      - tile38

I get the following logs / error:
tile38_1           |
tile38_1           |    _______ _______
tile38_1           |   |       |       |
tile38_1           |   |____   |   _   |   Tile38 1.16.4 (96dc1d4) 64 bit (amd64/linux)
tile38_1           |   |       |       |   Port: 9851, PID: 1
tile38_1           |   |____   |   _   |
tile38_1           |   |       |       |   tile38.com
tile38_1           |   |_______|_______|
tile38_1           |
tile38_1           | 2019/03/22 18:19:45 [INFO] Server started, Tile38 version 1.16.4, git 96dc1d4
tile38_1           | 2019/03/22 18:19:45 [INFO] AOF loaded 151 commands: 0.02s, 6939/s, 488 KB/s
tile38_1           | 2019/03/22 18:19:45 [INFO] Ready to accept connections at [::]:9851
redis-commander_1  | Creating custom redis-commander config '/redis-commander/config/local-production.json'.
redis-commander_1  | node ./bin/redis-commander --redis-port 9851 --redis-host tile38
redis-commander_1  | No Save: false
redis-commander_1  | listening on  <IP_ADDRESS> : 8081
redis-commander_1  | redis command "command" not supported, cannot build dynamic command list
redis-commander_1  | { ReplyError: ERR unknown command 'select'
redis-commander_1  |     at parseError (/redis-commander/node_modules/redis-parser/lib/parser.js:179:12)
redis-commander_1  |     at parseType (/redis-commander/node_modules/redis-parser/lib/parser.js:302:14) command: { name: 'select', args: [ '0' ] } }
redis-commander_1 exited with code 0
...

You have a few issues going on here, they are not related to you using docker compose.
To debug, install and run redis-commander with the port 9851. It will give you the same error as the redis-commander is running the redis command select in a non-redis environment.
redis command "command" not supported, cannot build dynamic command list

Hi all!!
I've got the same error, someone find a solution ?
Thanks

@ElRochito Please provide details regarding your error. I highly doubt you have the same error as the original poster as that was specific to a third party module not supporting the command.

If I run redis-commander --redis-port 9851 --redis-host <IP_ADDRESS> with tile38 running on this port number.
I've received this error : redis command "command" not supported, cannot build dynamic command list

@ElRochito Tile38 does not have the command command which redis-commander first issues on connect: https://github.com/joeferner/redis-commander/blob/7f4521d10e563f9bd83572e37ca1113ed5e538fa/lib/app.js#L370


Re-enable check-readme disabled on #3978

Check to disabled in https://github.com/ChainSafe/lodestar/pull/3978, this issue is a reminder to fix when possible.
https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/.github/workflows/test.yml#L56-L58

This is likely blocked by https://github.com/bbc/typescript-docs-verifier/issues/17


add ref count to alts shared resource.

This PR adds a ref count to ALTS shared resources, and ref (unref) it whenever creating (destroying) alts server/channel credentials. It will resolve ALTS (and google default creds) test flakiness.
I will prepare another PR later on that removes the TSI thread from gRPC use cases.

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.0%    +332 [None]                                  +9.19Ki  +0.1%
      +0.1%    +364 [Unmapped]                              +9.19Ki  +0.1%
      +6.2%      +8 g_alts_resource                               0  [ = ]
   +48%    +268 src/core/tsi/alts_transport_security.cc    +268   +48%
      [NEW]    +215 grpc_tsi_alts_shared_resource_unref        +215  [NEW]
      [NEW]     +85 grpc_tsi_alts_wait_for_cq_drain             +85  [NEW]
      +108%     +26 [Unmapped]                                  +26  +108%
       +23%     +14 grpc_tsi_alts_init                          +14   +23%
      [NEW]     +12 grpc_tsi_alts_shared_resource_ref           +12  [NEW]

  +0.0%    +600 TOTAL                                   +9.45Ki  +0.1%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,151      Total (>)      1,961,099

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,175      Total (>)     10,883,611

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.0%    +332 [None]                                  +9.19Ki  +0.1%
      +0.1%    +364 [Unmapped]                              +9.19Ki  +0.1%
      +6.2%      +8 g_alts_resource                               0  [ = ]
   +48%    +268 src/core/tsi/alts_transport_security.cc    +268   +48%
      [NEW]    +215 grpc_tsi_alts_shared_resource_unref        +215  [NEW]
      [NEW]     +85 grpc_tsi_alts_wait_for_cq_drain             +85  [NEW]
      +108%     +26 [Unmapped]                                  +26  +108%
       +23%     +14 grpc_tsi_alts_init                          +14   +23%
      [NEW]     +12 grpc_tsi_alts_shared_resource_ref           +12  [NEW]

  +0.0%    +600 TOTAL                                   +9.45Ki  +0.1%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE                                                                           FILE SIZE
 ++++++++++++++ GROWING                                                             ++++++++++++++
  +0.0%    +177 [None]                                                              +19.3Ki  +0.2%
      +0.0%    +209 [Unmapped]                                                          +19.3Ki  +0.2%
      +6.2%      +8 g_alts_resource                                                           0  [ = ]
  +2.0%     +91 src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc                     +91  +2.0%
      [NEW]    +848 alts_tsi_handshaker_create                                             +848  [NEW]
  +6.5%     +36 src/core/tsi/alts_transport_security.cc                                 +36  +6.5%
      [NEW]    +271 grpc_tsi_alts_shared_resource_unref                                    +271  [NEW]
      [NEW]     +28 grpc_tsi_alts_shared_resource_ref                                       +28  [NEW]
       +23%     +14 grpc_tsi_alts_init                                                      +14   +23%
  +7.7%     +32 src/core/lib/security/credentials/alts/alts_credentials.cc              +32  +7.7%
       +11%     +16 grpc_alts_credentials_create_customized                                 +16   +11%
       +11%     +16 grpc_alts_server_credentials_create_customized                          +16   +11%
       +39%      +9 alts_credentials_destruct                                                +9   +39%
       +39%      +9 alts_server_credentials_destruct                                         +9   +39%
  +0.7%     +16 src/core/lib/security/security_connector/alts_security_connector.cc     +16  +0.7%
      +5.0%      +8 alts_server_add_handshakers                                              +8  +5.0%
      +4.8%      +8 alts_channel_add_handshakers                                             +8  +4.8%

  +0.0%    +352 TOTAL                                                               +19.4Ki  +0.2%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                                           FILE SIZE
 ++++++++++++++ GROWING                                                             ++++++++++++++
  +0.0%    +177 [None]                                                              +19.3Ki  +0.2%
      +0.0%    +209 [Unmapped]                                                          +19.3Ki  +0.2%
      +6.2%      +8 g_alts_resource                                                           0  [ = ]
  +2.0%     +91 src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc                     +91  +2.0%
      [NEW]    +848 alts_tsi_handshaker_create                                             +848  [NEW]
  +6.5%     +36 src/core/tsi/alts_transport_security.cc                                 +36  +6.5%
      [NEW]    +271 grpc_tsi_alts_shared_resource_unref                                    +271  [NEW]
      [NEW]     +28 grpc_tsi_alts_shared_resource_ref                                       +28  [NEW]
       +23%     +14 grpc_tsi_alts_init                                                      +14   +23%
  +0.7%     +16 src/core/lib/security/security_connector/alts_security_connector.cc     +16  +0.7%
      +5.0%      +8 alts_server_add_handshakers                                              +8  +5.0%
      +4.8%      +8 alts_channel_add_handshakers                                             +8  +4.8%

  +0.0%    +320 TOTAL                                                               +19.4Ki  +0.2%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE                                                                           FILE SIZE
 ++++++++++++++ GROWING                                                             ++++++++++++++
  +0.0%    +273 [None]                                                              +19.3Ki  +0.2%
      +0.0%    +305 [Unmapped]                                                          +19.3Ki  +0.2%
      +6.2%      +8 g_alts_resource                                                           0  [ = ]
   +20%    +108 src/core/tsi/alts_transport_security.cc                                +108   +20%
      [NEW]    +279 grpc_tsi_alts_shared_resource_unref                                    +279  [NEW]
      [NEW]     +28 grpc_tsi_alts_shared_resource_ref                                       +28  [NEW]
       +23%     +14 grpc_tsi_alts_init                                                      +14   +23%
       +12%      +3 [Unmapped]                                                               +3   +12%
  +2.0%     +91 src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc                     +91  +2.0%
      [NEW]    +848 alts_tsi_handshaker_create                                             +848  [NEW]
  +0.7%     +16 src/core/lib/security/security_connector/alts_security_connector.cc     +16  +0.7%
      +5.0%      +8 alts_server_add_handshakers                                              +8  +5.0%
      +4.8%      +8 alts_channel_add_handshakers                                             +8  +4.8%

  +0.0%    +488 TOTAL                                                               +19.5Ki  +0.2%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,023      Total (<)      1,961,099

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,883,813      Total (>)     10,883,607

 No significant differences in binary sizes

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,194      Total (>)      1,961,099

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,883,815      Total (>)     10,883,611

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,194      Total (>)      1,961,099

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,883,812      Total (>)     10,883,607

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                                           FILE SIZE
 ++++++++++++++ GROWING                                                             ++++++++++++++
  +0.1%    +385 [None]                                                              +19.3Ki  +0.2%
      +0.1%    +417 [Unmapped]                                                          +19.3Ki  +0.2%
      +6.2%      +8 g_alts_resource                                                           0  [ = ]
   +30%    +164 src/core/tsi/alts_transport_security.cc                                +164   +30%
      [NEW]    +287 grpc_tsi_alts_shared_resource_unref                                    +287  [NEW]
      [NEW]     +52 grpc_tsi_alts_shared_resource_ref                                       +52  [NEW]
       +79%     +19 [Unmapped]                                                              +19   +79%
       +23%     +14 grpc_tsi_alts_init                                                      +14   +23%
      [NEW]      +8 grpc_tsi_alts_shared_resource_get_mu                                     +8  [NEW]
  +0.6%     +27 src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc                     +27  +0.6%
      [NEW]    +782 alts_tsi_handshaker_create                                             +782  [NEW]
  +0.7%     +16 src/core/lib/security/security_connector/alts_security_connector.cc     +16  +0.7%
      +5.0%      +8 alts_server_add_handshakers                                              +8  +5.0%
      +4.8%      +8 alts_channel_add_handshakers                                             +8  +4.8%

  +0.0%    +592 TOTAL                                                               +19.5Ki  +0.2%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE                                                                           FILE SIZE
 ++++++++++++++ GROWING                                                             ++++++++++++++
  +0.1%    +393 [None]                                                              +19.4Ki  +0.2%
      +0.1%    +425 [Unmapped]                                                          +19.4Ki  +0.2%
      +6.2%      +8 g_alts_resource                                                           0  [ = ]
   +28%    +156 src/core/tsi/alts_transport_security.cc                                +156   +28%
      [NEW]    +279 grpc_tsi_alts_shared_resource_unref                                    +279  [NEW]
      [NEW]     +52 grpc_tsi_alts_shared_resource_ref                                       +52  [NEW]
       +79%     +19 [Unmapped]                                                              +19   +79%
       +23%     +14 grpc_tsi_alts_init                                                      +14   +23%
      [NEW]      +8 grpc_tsi_alts_shared_resource_get_mu                                     +8  [NEW]
  +1.3%     +59 src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc                     +59  +1.3%
      [NEW]    +805 alts_tsi_handshaker_create                                             +805  [NEW]
      +9.2%      +8 [Unmapped]                                                               +8  +9.2%
  +0.7%     +16 src/core/lib/security/security_connector/alts_security_connector.cc     +16  +0.7%
      +5.0%      +8 alts_server_add_handshakers                                              +8  +5.0%
      +4.8%      +8 alts_channel_add_handshakers                                             +8  +4.8%

  +0.0%    +624 TOTAL                                                               +19.6Ki  +0.2%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,194      Total (>)      1,961,099

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,026      Total (>)     10,883,607

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,194      Total (>)      1,961,099

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,028      Total (>)     10,883,617

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                                           FILE SIZE
 ++++++++++++++ GROWING                                                             ++++++++++++++
  +0.0%     +33 [None]                                                              +18.7Ki  +0.2%
      +0.0%     +33 [Unmapped]                                                          +18.7Ki  +0.2%
      +6.2%      +8 g_alts_resource                                                           0  [ = ]
   +20%    +108 src/core/tsi/alts_transport_security.cc                                +108   +20%
      [NEW]    +231 grpc_tsi_alts_shared_resource_destroy                                  +231  [NEW]
      [NEW]     +52 grpc_tsi_alts_shared_resource_create                                    +52  [NEW]
       +23%     +14 grpc_tsi_alts_init                                                      +14   +23%
       +29%      +7 [Unmapped]                                                               +7   +29%
  +0.7%     +16 src/core/lib/security/security_connector/alts_security_connector.cc     +16  +0.7%
      +5.0%      +8 alts_server_add_handshakers                                              +8  +5.0%
      +4.8%      +8 alts_channel_add_handshakers                                             +8  +4.8%

 -------------- SHRINKING                                                           --------------
  -0.1%      -5 src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc                      -5  -0.1%
      [DEL]    -733 alts_tsi_handshaker_create                                             -733  [DEL]
      -3.5%     -48 alts_tsi_handshaker_handle_response                                     -48  -3.5%
      [DEL]     -21 _GLOBAL__sub_I_alts_tsi_handshaker.cc                                   -21  [DEL]
      -3.0%      -4 thread_worker                                                            -4  -3.0%

  +0.0%    +152 TOTAL                                                               +18.9Ki  +0.2%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

All comments are addressed. Besides, I further made the following changes.

In transport_security.cc, I moved self->handshake_shutdown = true to a correct position. Without this change, handshaker_shutdown() in alts_tsi_handshaker.cc will not be correctly executed.
I also added a wait/signal mechanism in alts_transport_security.cc to make sure grpc_tsi_alts_shutdown() will not be triggered before grpc_tsi_alts_shared_resource_destroy correctly returns. It is necessary because when security_handshaker_shutdown() is triggered, It is the TSI thread that will execute grpc_tsi_alts_shared_resource_destroy API, and since gRPC does not have know about the thread, it may go ahead proceed with grpc_tsi_alts_shutdown() while the shared resource has not been destroyed yet.

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,424      Total (>)      1,961,233

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,250      Total (>)     10,884,243

 No significant differences in binary sizes

Please hold on reviewing. The test failure still occurs.

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                                           FILE SIZE
 ++++++++++++++ GROWING                                                             ++++++++++++++
  +0.0%     +33 [None]                                                              +18.8Ki  +0.2%
      +0.0%     +33 [Unmapped]                                                          +18.8Ki  +0.2%
      +6.2%      +8 g_alts_resource                                                           0  [ = ]
   +14%     +76 src/core/tsi/alts_transport_security.cc                                 +76   +14%
      [NEW]    +231 grpc_tsi_alts_shared_resource_destroy                                  +231  [NEW]
      [NEW]     +59 grpc_tsi_alts_shared_resource_create                                    +59  [NEW]
       +23%     +14 grpc_tsi_alts_init                                                      +14   +23%
  +0.7%     +16 src/core/lib/security/security_connector/alts_security_connector.cc     +16  +0.7%
      +5.0%      +8 alts_server_add_handshakers                                              +8  +5.0%
      +4.8%      +8 alts_channel_add_handshakers                                             +8  +4.8%

 -------------- SHRINKING                                                           --------------
  -0.1%      -5 src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc                      -5  -0.1%
      [DEL]    -733 alts_tsi_handshaker_create                                             -733  [DEL]
      -3.5%     -48 alts_tsi_handshaker_handle_response                                     -48  -3.5%
      [DEL]     -21 _GLOBAL__sub_I_alts_tsi_handshaker.cc                                   -21  [DEL]
      -3.0%      -4 thread_worker                                                            -4  -3.0%

  +0.0%    +120 TOTAL                                                               +18.8Ki  +0.2%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,528      Total (>)      1,961,353

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,254      Total (>)     10,884,241

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                    FILE SIZE
 ++++++++++++++ GROWING                                      ++++++++++++++
  +0.0%    +352 [None]                                       +9.02Ki  +0.1%
      +0.0%    +288 [Unmapped]                                   +9.02Ki  +0.1%
       +44%     +56 g_alts_resource                                    0  [ = ]
      +0.8%      +8 [None]                                             0  [ = ]
   +48%    +264 src/core/tsi/alts_transport_security.cc         +264   +48%
       +30%     +91 grpc_tsi_alts_shutdown                           +91   +30%
      [NEW]     +67 grpc_tsi_alts_shared_resource_remove_ref         +67  [NEW]
      [NEW]     +51 grpc_tsi_alts_shared_resource_add_ref            +51  [NEW]
      +121%     +29 [Unmapped]                                       +29  +121%
       +43%     +26 grpc_tsi_alts_init                               +26   +43%

  +0.0%    +616 TOTAL                                        +9.28Ki  +0.1%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,538      Total (>)      1,961,358

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,726      Total (>)     10,884,296

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                    FILE SIZE
 ++++++++++++++ GROWING                                      ++++++++++++++
  +0.0%    +352 [None]                                       +9.02Ki  +0.1%
      +0.0%    +288 [Unmapped]                                   +9.02Ki  +0.1%
       +44%     +56 g_alts_resource                                    0  [ = ]
      +0.8%      +8 [None]                                             0  [ = ]
   +48%    +264 src/core/tsi/alts_transport_security.cc         +264   +48%
       +30%     +91 grpc_tsi_alts_shutdown                           +91   +30%
      [NEW]     +67 grpc_tsi_alts_shared_resource_remove_ref         +67  [NEW]
      [NEW]     +51 grpc_tsi_alts_shared_resource_add_ref            +51  [NEW]
      +121%     +29 [Unmapped]                                       +29  +121%
       +43%     +26 grpc_tsi_alts_init                               +26   +43%

  +0.0%    +616 TOTAL                                        +9.28Ki  +0.1%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,538      Total (>)      1,961,358

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,730      Total (>)     10,884,299

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,961,473      Total (>)      1,961,325

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,084      Total (>)     10,883,702

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.1%    +416 [None]                                  +8.99Ki  +0.1%
      +0.0%    +320 [Unmapped]                              +8.99Ki  +0.1%
       +44%     +56 g_alts_resource                               0  [ = ]
      +3.9%     +40 [None]                                        0  [ = ]
   +48%    +264 src/core/tsi/alts_transport_security.cc    +264   +48%
       +30%     +91 grpc_tsi_alts_shutdown                      +91   +30%
      [NEW]     +67 grpc_tsi_g_alts_resource_unref              +67  [NEW]
      [NEW]     +51 grpc_tsi_g_alts_resource_ref                +51  [NEW]
       +54%     +33 grpc_tsi_alts_init                          +33   +54%
       +92%     +22 [Unmapped]                                  +22   +92%

  +0.0%    +680 TOTAL                                   +9.25Ki  +0.1%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,962,848      Total (>)      1,962,660

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,083      Total (>)     10,883,696

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.1%    +476 [None]                                  +9.00Ki  +0.1%
      +0.1%    +380 [Unmapped]                              +9.00Ki  +0.1%
       +44%     +56 g_alts_resource                               0  [ = ]
      +3.9%     +40 [None]                                        0  [ = ]
   +46%    +252 src/core/tsi/alts_transport_security.cc    +252   +46%
      [NEW]    +279 grpc_tsi_g_alts_resource_unref             +279  [NEW]
      [NEW]     +51 grpc_tsi_g_alts_resource_ref                +51  [NEW]
       +54%     +33 grpc_tsi_alts_init                          +33   +54%
       +58%     +14 [Unmapped]                                  +14   +58%

  +0.0%    +728 TOTAL                                   +9.25Ki  +0.1%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,962,923      Total (>)      1,962,660

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,884,088      Total (>)     10,883,701

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

Since we decided to directly apply gRPC thread model (#16773) to resolve the issue, the PR is no longer relevant any more. Thanks Mark for the detailed review.


Landing Zone Failure

Hello Team,
I hope you are doing well. I am testing AWS Landing Zone Accelerator and actually faced a lot of issues (Using AWS Organization instead of Control Tower) but I was able to fix it all. However, I am currently stuck with the Bootstrap Phase of CodePipeline. The build stage is returning:
Cannot assume role for 3600 seconds: AccessDenied: User: arn:aws:sts::ManagementAccountID:assumed-role/AWSAccelerator-PipelineSt-AdminCdkToolkitRole292E1-LNLW330962BO/AWSCodeBuild-afe03dcb-5634-43cf-852f-8d5e1e7fbf79 is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::SecurityAccountID:role/AWSControlTowerExecution
Although I have disabled Control Tower in the global-config file, "controlTower: enable: false"
the Bootstrap is still assuming that the Control Tower IAM Role "AWSControlTowerExecution" is created but this is not the case for me.
The Landing Zone Accelerator documentation stated that if Control Tower is not enabled, the default Role "OrganizationAccountAccessRole" would do the job. This role is present in all my org accounts and the master account can assume these roles but still, the bootstrap is expecting the "AWSControlTowerExecution" role.
Apologies for any inconvenience and thank you so much for your support on this.
Thanks,

You may update the role used for cross account access in the global-config file.  The property is named managementAccountAccessRole.

Thank you so much @crissupb. It worked just fine! Now I am getting another error related to the Amazon Detective: Message returned: ServiceQuotaExceededException: ACCOUNT_VOLUME_UNKNOWN. I have searched online to figure out how this can be solved but couldn't find much info. Can you also help me with this, please? Detective is enabled by default in the security-config file.
Will we face all these issues if we use Control Tower in our future deployments?
Thank you!

Hello Team,
Any update on my recent inquiry? Can you please help me fix this so that we can complete our PoC?
Thanks,

Do you have GuardDuty enabled?  Amazon Detective cannot be enabled until GuardDuty had been enabled and running for at least 48 hours.
https://docs.aws.amazon.com/detective/latest/adminguide/detective-prerequisites.html

Thank you so much @crissupb . I will enable GuardDuty and try after 48 hours. Will keep you posted.

Hello @crissupb, I am now getting a new error related to enabling AWS Budgets on the linked Accounts such as (Security, Network, and Logging). I have manually enabled Cost Explorer and waiting 24 hours to set up the budgets. But this shouldn't be part of the solution. I can see that LZA created the "accel-budget" on the master account AWS Budget ($2,000). Can't we give this solution a role to enable it on the linked accounts without having to do that by ourselves manually? I am thinking of managing 100s of accounts. Apologies for the inconvenience but we are really excited to complete this setup manually without using Control Tower to help our clients build their Landing Zones in un-supported regions.
Thanks,

@balannan - just to keep the sanity and relevance original issue. Could you please close the issue and open new one if needed. Looks like this is a thread of multiple questions. As for your last comment, it would be more of a feature request than a bug.

Closing as the original issue was resolved.


Fix-81877 Image preview should not zoom on first click if unfocused

@mjbvz , Here is the fix for #81877 .
I am not sure if this is the solution you wanted but just wanted to know if this is towards the right direction. ( Because you have mentioned about focus , I am not quite sure how to get that info here )
Thanks :)

I opened a PR yesterday for this but forgot to link the issue, #81933 to my PR. I took a similar approach. It doesn't appear to be possible to query for whether the current view is active -- vscode.window is undefined and even if it were available, by the time the 'click' handler executes, the window is already active.

@mjbvz , Any updates on this ?

Hey sorry for the delay. A few other people also jumped on the issue before I could unmark it as help wanted and those PRs also handled a few important additional cases, such as when the preview is unfocused an refocused after the initial load
I'm close this PR in favor of #82074  but the feature will be making it into the next release


Kong-Cassandra in OSE v3

We are trying to run the YAML files (community shared) in Redhat OpenShift Environment(OSE) V3.  The OSE is not in AWS and hosted inside our datacenters. All the Services, ReplicationControllers are successfully created but ‘Deployment’ failed with the highlighted errors below: Can you please provide your inputs ?
All the Services, ReplicationControllers are successfully created but ‘Deployment’ failed with the highlighted errors below: Shall we get some inputs from your team to resolve this?
$ ls
cassandra-controller.yaml  kong-app.yaml  kong-rc.yaml  README.md

skumar58@LH7U0CNU425CK6D MINGW64 /c/senthil/hbs/Layer 7/OSE/kong/kong-cassandra-ose/kong-cassandra-openshift-master ((66b4a72...))
$ oc create -f cassandra-controller.yaml
service "cassandra" created
replicationcontroller "cassandra" created

skumar58@LH7U0CNU425CK6D MINGW64 /c/senthil/hbs/Layer 7/OSE/kong/kong-cassandra-ose/kong-cassandra-openshift-master ((66b4a72...))
$ oc create -f kong-app.yaml
service "kong-app" created
Error from server: error when creating "kong-app.yaml": User "skumar58" cannot create extensions.deployments in project "kong-cassandra-ose-poc"

skumar58@LH7U0CNU425CK6D MINGW64 /c/senthil/hbs/Layer 7/OSE/kong/kong-cassandra-ose/kong-cassandra-openshift-master ((66b4a72...))
$ oc create -f kong-rc.yaml
service "kong-proxy" created
service "kong-admin" created
Error from server: error when creating "kong-rc.yaml": User "skumar58" cannot create extensions.deployments in project "kong-cassandra-ose-poc"

User "skumar58" cannot create extensions.deployments in project "kong-cassandra-ose-poc"

That seems like a permissions error to me...

Hi Thijs
Thanks for the immediate response.
Attached is the 3 yam files (received from Kong team) that we trying to run in OSE v3. It seems that there is an issue in the image repo.
We are seeing the below image repository information in the 3 Yaml files:
image: kong:0.9.9
image: kong:verbose
image: cassandra-cluster:latest
Can you please provide exact full repository name: tag information for all the 3 yaml files?
Thanks
senthil
From: Thijs Schreijer<EMAIL_ADDRESS>Sent: Monday, April 03, 2017 10:43 AM
To: Mashape/kong
Cc: Sundaramurthy, Senthil Kumar; Author
Subject: Re: [Mashape/kong] Kong-Cassandra in OSE v3 (#2322)
User "skumar58" cannot create extensions.deployments in project "kong-cassandra-ose-poc"
That seems like a permissions error to me...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Mashape/kong/issues/2322#issuecomment-291183091, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQyMqqqXP9dIAPA8fxIo8b3xwNTohGynks5rsROegaJpZM4Mxsbu.
This e-mail, including attachments, may include confidential and/or
proprietary information, and may be used only by the person or entity
to which it is addressed. If the reader of this e-mail is not the intended
recipient or his or her authorized agent, the reader is hereby notified
that any dissemination, distribution or copying of this e-mail is
prohibited. If you have received this e-mail in error, please notify the
sender by replying to this message and delete this e-mail immediately.

@optumses @Tieske @jerodsanto @nikz check this out, I managed to run kong on openshift origin https://github.com/john-deng/kong-openshift


"View Deployment" links points to wrong place.

If you deploy any app by argo. There are couple ways to navigate to deployed app.
The links points to timeline screen instead to corresponding app details screen.

Closing V1 issues


Revert "React to aspnet/EntityFramework#2613"

This reverts commit 83925fee30a52e6c600a663f49ba24b043b645a5.

Hi @bricelam, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

:shipit:


problem in specifying snow model timestep

Bug Reports

VIC version 5.0.1 - Classic driver
Name and version of the C compiler: gcc version 5.4.0
Linux (Ubuntu 16.04)
A description of relevant model settings: See attached global parameter file: global.param.mekong5.0.1.txt
Summary of error: While setting up VIC v5.0.1 for my project, I am facing a problem in specifying parameters in the global parameter file. I need to run the VIC at daily time step (at which I have prepared my forcing data). Now, I get an error saying " minimum number of subdaily steps per day = 4" when I give the following options:
MODEL_STEPS_PER_DAY 	1
SNOW_STEPS_PER_DAY	1
RUNOFF_STEPS_PER_DAY	1
...
FORCE_STEPS_PER_DAY	1

So when I set SNOW_STEPS_PER_DAY = 4, I then get an error saying "FORCE_STEPS_PER_DAY must match SNOW_STEPS_PER_DAY". However, I have prepared my forcing files at daily time step.
How can I make the VIC model run at daily time step?

Hey @shahryaramd I don't think that VIC can be run at a daily time step.  One way to accomplish what you're trying to do would be to use MetSim to disaggregate your data to sub-daily values and then feed those through VIC.  If you need any help getting MetSim up and running open an issue on it's repo and I'll help you out.

Thanks @arbennett, has this change occurred starting VIC v5, because v4.x allowed running at the daily step?
I will try setting up MetSim and open an issue if in case of any problem.

Yes, this was a change with VIC 5 (I went back and edited my comment to make things clearer for others).

Thanks for the clarification.

@shahryaramd you are likely to encounter problems with MetSim.  The latest version on the develop branch doesn't output all the variables that VIC will need - in particular it is missing wind and pressure.  In addition, it only runs on one input file at a time.  Unless you have an input file containing the entire time series that you need, all in one file, you will have to run MetSim manually or write a script to loop over all the input files and concatenate the results.
Kristen Whitney has been developing solutions to both of these problems.  Her code is basically usable at this point, although we are still putting the finishing touches on it.  Take a look at @kwhitney727's feature/time_wrap branch of MetSim.

Note that this isn't to disparage @arbennett's work in creating MetSim (it's a great product!).  Just pointing out a practical problem (for which a solution is nearly complete).

thanks for letting me know, will try that out.

@tbohn @shahryaramd this isn't really the place to discuss MetSim, but I don't want to spread misinformation.  MetSim can output wind and pressure.  All of this information can be found in the documentation.

Sorry @arbennett - perhaps I misunderstood.

Okay, it sounds like we've moved on from the original issue. I'm going to close this now and further discussion can be had over on the MetSim Github Issues.
@shahryaramd - VIC 5 removed the METSIM disaggregattor (#288) so you need to generate these subdaily forcings as a preprocessing step. It's worth noting that VIC always ran at a subdaily time, users just had the option of letting VIC do the disaggregation on the fly with METSIM. Your misunderstanding of VIC's capabilities is exactly why we removed the tool from VIC.


Support for animated gifs

Ideally resize, but if that's not possible, just return the original.

The underlying Vips library doesn't support animated gifs (see: https://github.com/jcupitt/libvips/issues/235) but perhaps gifsicle could be used for resizing animated gifs once they've been detected? It's also possible to resize animated GIFs using ImageMagick's coalesce feature but I don't think it's as performant as gifsicle, which is optimized specifically for gifs.

Doesn't appear that gifsicle has native Node support; there's a npm module but that just finds the executable.
Are there any Node libraries that do support GIFs?

I've not yet found one that does gif support natively, so maybe going the ImageMagick/GM route is best until something better is found, since those libraries are available on Lamda.

Yeah I had looked into this for a bit, but never found anything. I'd be open to doing it if we had a good node library, right now we just have animated gif detection to not resize animated gifs as that by default will just take the first frame,

Might be able to help out here: we ran into a similar problem with a 10up client who wanted to be able to resize gifs while preserving animation. Since Gifsicle doesn't have native PHP bindings, we ended up running Gifsicle on the web server via passthru().
I wrote about the math behind it last summer, which was as much of the code that I could share without stepping on work-for-hire issues. Hopefully that'll help :)
(Thanks to @bswatson for bringing this to my attention)

@stevegrunwell Thanks for the info, super useful! I looked into Gifsicle previously as well, but there's no native Node bindings, and we can't run arbitrary executables on Lambda. :(
That said, maybe it's worth us building those bindings out. Given that most of the complexity is on the Gifsicle side, I imagine the Node connection would be quite simple.

From the libvips author:

libvips supports loading whole GIF images since 8.5, though not GIF save unfortunately

See https://github.com/jcupitt/libvips/issues/620
I'm not super concerned about it tbh, I think it's a lot more effort than it's worth, however it's a nice-to-have if it ever does happen. Leaving the ticket open for #thefuture.

It appears it's in development! https://github.com/libvips/libvips/issues/839#issuecomment-375806193
At the end of the ticket is a user who is able to copy a jpeg to a gif, so maybe worth looking into again?

Looking further, it appears Sharp has an issue tracking support: https://github.com/lovell/sharp/issues/1372.

The prebuilt libvips binaries provided by sharp do not include *magick. To take advantage, you will need to compile your own libvips with support for *magick and install it globally before installing sharp.

If I'm reading this right, we just need to compile our own copy of libvips before installing sharp to get this support?

Looks like there has been some movement on the feature request upstream with a feature PR at https://github.com/lovell/sharp/pull/2012. What's interesting is that the team with the PR is running this on production, so I suspect it's much closer to being added upstream.
I recall seeing support for this on a recent VIP project as well - so maybe VIP did something custom for their support.


Setting initial time

Hi there,
Thank you for developing this library. Just wondering if there are any options to set the default time? For example I would like like to set the default time as today's date.
Thanks for the help.

No option needed, just set the date in your model and the calendar will use it.


Light miner: Region detection and support

Originally: https://github.com/nebraltd/light-hotspot-software/issues/42
Relevant code: https://github.com/NebraLtd/hm-miner/blob/master/gen-region.sh
Acceptance criteria

Miner container must be using hm-gatewayrs
On Diagnostics page, Region plan displays correctly for onboarded and not-onboarded hotspots.
Packet forwarder should not start unless a region is selected

Closed by merge of #321


Run tests ignoring [patch] entries as part of release process

We discovered during our first release that while cargo publish will build the crates as they will be released, it will not run the tests. This is not ideal as we have [patch] entries in the crates which means when releasing we are not currently running the tests with the dependency configuration that will be in use when actually released.

I opened issue https://github.com/rust-lang/cargo/issues/10932

There are other solutions to this:

We can manually edit the TOML and run cargo test.
We can use a tool to temporarily edit the TOML, run cargo test, and then undo the edit.

cc @graydon

Duplicate of https://github.com/stellar/rs-soroban-env/issues/401


[TA] upgrade to 3.1-Preview.2 and fixes the tests

Upgrade service version to 3.1-preview.2. fixes: #14541
fixes: #13960

None of this affects public API, right?

@maririos Yes. There is no changes affect public APIs. this PR is mainly focus on to regenerate the codegenerated code.


React.Component error

Can you please update description? It's hard to understand when and why you have this error

Not actionable

Sorry, the comment was a mistake, my bad!


Use setGlobalSettings to store token

It would be nice to use setGlobalSettings to store the token, so that we wouldn't need to copy the token to each button (in my case I have 8 button instances).

This was disabled due to people wanting to use multiple account. The rewrite I'm currently working on will feature multi-accounting with global settings.


Cannot compress objects containing undefined values

Thanks for great lib!
I just found out that compress-json throws an Error TypeError: unsupported data type: [object Undefined] if compressed object contains fields with undefined value.
Example:
const data = [{a: 'b'}, {a: 'c', b: undefined}]
const compressed = compress(data)

I suppose it'd be possible to extend the lib to support also undefined values. Or, if it is not possible or works as defined, then a short notice to README would be great! ☀

This is intentional, json doesn't support undefined value. You may replace it with null for array element, or remove the property for object entry.

If you really need to represent a key value pair with undefined value, you may need to escape when encoding, and unescape when decoding.

Would you share about your use case?

Okay, I see! Here's our use case in more detail:
Our code is run inside AWS lambda. Inside the logic we construct a very large payload (sometimes exceeding the 6MB Lambda payload limit). We use a shorthand to set some conditional fields to the response object:
const payload = {
  optionalField: someCondition ? 'some-value' : undefined,
  //  ...
}

and stringify the payload in lambda handler response:
return {
  statusCode: 200,
  body: JSON.stringify(payload)
}

As our payload may sometimes exceed the Lambda response 6MB size limit, I decided to compress it using compress-json, but the undefined values in payload caused the error as descibed in this issue.
Now I see that my initial issue description was a bit off. Actually we don't actually want to preserve the undefined fields, but to have similar behavior what JSON.stringify() does, ie. strip undefined values silently off. I fully agree that only standard JSON data types should be preserved in compression :)
I finally decided to just clean up the undefined values from payload using JSON.parse(JSON.stringify(payload)) before passing it to compress-json and it works well.
So - after all there's no problem at all in your lib. I just incorrectly expected JSON.stringify like behavior. I'm closing this issue.
Thanks for your time for answering and developing this lib 🙏

I see, your use case maybe not rare.
It may be handy to also silently skip undefined field when compressing for better efficiency 🤔

I'd suggest another approach to handle undefined fields for better efficiency.
You can manually call helper function to delete undefined object fields. Doing that in application instead of internal encoding loop during compress will cause less performance overhead.
This is example, I'm calling trimUndefined() on ast object after creation to remove optional fields: https://github.com/beenotung/better-sql/blob/master/src/parse.ts#L376
In the current design of compress-json, it stores all object keys before the values. Therefore it will require additional scanning on all object entries to finalize the list of keys to be encoded. That is less efficient then calling trimUndefined only on objects with potential optional fields.
I may include the trimUndefined as helper function in this library in next release, and make it optionally recursive :)

Ok, sounds feasible and nice to hear about  the internals 👍 Performance is not high priority in my use case but I understand well that in some other cases it's important. So it seems to be the traditional performance vs. usability trade-off 🙂

Nice solution!

I'm closing this issue for now, feel free to re-open it or submit another issue when new ideas comes up :)


@notoriousFF high CPU use after some time

VSCode Version: 1.2.1
OS Version: 10.11.5

Steps to Reproduce:

Two monitors;
VSCode open in one of them full screen;
After some hours the computer slows down and after checking Activity Monitor I get these:
With VSCode Opened: https://gyazo.com/450ede25910e78895f60983ac7edd260
After Closing VSCode: https://gyazo.com/55d576e7d75363dbe77c813e4dd286e7

@notoriousFF could you provide me with the command line of the ElectronHelper executable. This would help understanding what is causing this.
@bpasero does this ring a bell?

The "ElectronHelper" only show up when VSCode does this. I will post here once it happens again.

@notoriousFF ping any update?

A number of days has past without answer on the questions asked. I am thereby going to close this issue to clean up our backlog of issues. Once you can answer on the questions, the issue can be reopened again. Thanks for understanding this process!


Request to join Org

CS Employee in EPP-P @Schmitt on slack.

Closing due to change in procedures


Hardcoded pingdom ips

Hi we noticed hardcoded pingdom ips in a whitelist.
https://github.com/ministryofjustice/make-recall-decision-ui/blob/2e2d3448e68b3ae5a006165f7e1009a9b34e085b/helm_deploy/values-prod.yaml#L23
We were thinking of implementing something similar in our team but were recommended to use the health-kick proxy
Slack thread here:
https://mojdt.slack.com/archives/C06MWP0UKDE/p1729676703293929
Maybe you'd find this helpful 🤞🏾

Hey Abdi (@Obsiye), nice one, thanks , I'll take a look
R


Replace our own end-to-end benchmark with Apache wrk

I'm all for using JMH for micro-benchmarking (endpoints, outputs, etc), but I think it would be a good idea to replace out end-to-end benchmark with wrk results. Reasons are following:

It's just less code we need to maintain
wrk is a world-known and -recognized way to do that

Fixed in #563.


fix: integration tests running on PRs from forks

Description

Allows integration tests to run via repository_dispatch events when PRs are opened from forks

Credit: https://github.com/imjohnbo/ok-to-test
Type of change

[ ] :sunflower: Feature
[ ] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Test
[X] :computer: CI/Deployment
[ ] :hamster: Trivial/Minor

Issue(s)

ALC-635

Test Plan

[X] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Will need to merge and create a dummy PR to verify things are setup correctly.

We should discuss security implications of running CI for forks. There's a chance external users could try to leak secrets or other sensitive info if we always enable CI when a PR from a fork is made with no extra intervention/checks
@vkamra

@uncledru You can add mergequeue label if you think this is good to go.

@meain it seems the Test-Suite job won't run on these changes which prevents me from merging 🤔

I think we will have to remove Test-Sute job and instead add the new jobs to "require" check on GH. Just notify folks on Slack about rebasing the changes from main.


Norminette false positive TOO_MANY_TAB

Describe the bug
The norminette tells me that my code is not at the norm.
Erroneous code
while (tmp[++i])
	if (isredirection(tmp[i]) == 0)
		add_value(&redict[j]->value, tmp[i]);
	else
	{
		j++
		redict[j] = ft_calloc(sizeof(t_redirection), 1);
		redict[j]->type = isredirection(tmp[i]);
	}

TOO_MANY_TAB 71 - 76

Additional infos

OS: Linux PC-Gamer 5.4.72-microsoft-standard-WSL2 #1 SMP Wed Oct 28 23:40:43 UTC 2020 x86_64 GNU/Linux
python --version: Python 3.7.3
norminette -v: norminette 3.3.1

Additional context

Hi, in the while loop you will need to include curly braces as the lines below it are more than 2 lines.
Fix:
while (tmp[++i])\t
{
    if (isredirection(tmp[i]) == 0)
add_value(&redict[j]->value, tmp[i]);
}

Hi, in the while loop you will need to include curly braces as the lines below it are more than 2 lines.
Fix:
while (tmp[++i])\t
{
 if (isredirection(tmp[i]) == 0)
add_value(&redict[j]->value, tmp[i]);
}
The braces must be inserted in the case where there is more than one instruction, except in my case there is only one instruction because an else can only be after an if, so my if else and an instruction.

Hello,
For now, multi-line conditions must be bracketed (as expected by C language) and control structure that include multi-line control structures must be bracketed as well, which is why the second code is valid while the first isn't.
Thank you for you report.


:sparkle: Removed thanks for 3,000 followers on tomorrows scheduled tweet

What

:sparkle: Removed thanks for 3,000 followers on tomorrows scheduled tweet

🛑 Don't merge until after 2020-07-31 🛑


feat: add Copy method to context

Codecov Report

Merging #18 (103a302) into master (2cc7879) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   96.48%   96.52%   +0.04%
==========================================
  Files          11       11
  Lines         398      403       +5
==========================================
+ Hits          384      389       +5
  Misses          7        7
  Partials        7        7

Impacted Files
Coverage Δ

router_context.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc7879...103a302. Read the comment docs.


Build ZIP package for deployment

Lab 13
Task: Prepare the bot code for deployment
Step: 2
Description of issue
package for deployment should be prepared by command detent publish and zipping output folder.
it is different from python.
https://docs.microsoft.com/en-us/azure/app-service/deploy-zip#create-a-project-zip-file
"For dotnet projects, this folder is the output folder of the dotnet publish command."

The product documentation is to zip the root folder containing the .csproj file

The product documentation is to zip the root folder containing the .csproj file


Questions about validating the dataset

I see the location of the validation data set is DATAROOT=/data/data/faces，Is it OK to put data sets directly under this directory? For example, I downloaded LFW from the Internet, can I directly put it under this path?

Can you provide a directory navigation to validate the dataset?

Can you provide the directory structure about validation dataset

@acerhp
I am also curious about the protocol for validation, and I feel a little bit weird, too.
It seems that the training pipeline will pick up the model to test based on the best validation score(it seems 5 Val set avg if I don't misunderstand anything)
But I thought that the validation set and the final test set are the same based on the default configuration file, they both are the LFW and etc. Does it OK to do this? Or @mk-minchul , your guys always pick the final epoch model to test. In this way, I think everything is legal.


Not an issue , just an argument

As you implemented the clean code architecture along with MVVM,
Android architecture pattern which is based on repository classes is similar to the clean code interactors or use case classes. Because the repository implementation classes contains all the remote or local database handling, why we can't just call the repository classes in the view model instead of creating an extra layer of use cases and just calling those repository functions from use cases and putting that use cases into the view model.
If we worry about the separation of concerns then we can make separate repositories for one view model if a different data model is needed for a single UI.
A repo. instance deals with single source of data as per google recommendation so I assume that creating use cases is an extra layer. Please share your thoughts on it.

Thank @shehramjamil  for bringing up this, I got the same thought while implementing this architecture. and as you already explained that repository is only responsible for data.
More Specific

Repositories are the data layer in which you store and access data.
UseCases handles your business logic who decides how your data should be manipulated for a specific scenario or for a use case. it simply holds dataflow logic.

UseCases can be a more complicated business logic or you want to use this logic in other view models/presenters. So with Use-Cases, you make your business code re-usable and avoid code duplication in your view models/presenters. Later, if you want to decide to change your business logic you only change your use-case, not all the view models.
In our current App requirements, we only need to show a list of data to screen, so our UseCases are not having much business logic in them, they are only calling repository functions nothing else. but things got complicated when you have more conditions and dataflow in your requirements.
For more details and real examples, you can refer to this blog.

Thank @shehramjamil  for bringing up this, I got the same thought while implementing this architecture. and as you already explained that repository is only responsible for data.
More Specific

Repositories are the data layer in which you store and access data.
UseCases handles your business logic who decides how your data should be manipulated for a specific scenario or for a use case. it simply holds dataflow logic.

UseCases can be a more complicated business logic or you want to use this logic in other view models/presenters. So with Use-Cases, you make your business code re-usable and avoid code duplication in your view models/presenters. Later, if you want to decide to change your business logic you only change your use-case, not all the view models.
In our current App requirements, we only need to show a list of data to screen, so our UseCases are not having much business logic in them, they are only calling repository functions nothing else. but things got complicated when you have more conditions and dataflow in your requirements.
For more details and real examples, you can refer to this blog.

Well Understood.
Thanks for referring to the blog and if we combine co routines with it instead of RxJava/kotlin then many lines of code and callbacks can be avoided.
Re-usability is the biggest flex of use cases  :100:

Well Understood.
Thanks for referring to the blog and if we combine co routines with it instead of RxJava/kotlin then many lines of code and callbacks can be avoided.
Re-usability is the biggest flex of use cases  :100:

Yes, using co-routines will reduce the code, will try to update the code. Thanks :+1:

Yes, using co-routines will reduce the code, will try to update the code. Thanks :+1:


Add model Sequence

Coverage increased (+0.4%) to 86.288% when pulling b0696f469fe5e90ae0d0089411e38bf6efec7c91 on sequence into 528361a0e716c22aaa0e3e93cd6863a6871b33c2 on dev.


add upload documents GET POST API

From my side all fine. @fatihayyildiz  anything you like to get changed?


[EBPF-492] Show register state in complexity information

What does this PR do?
Adds register state information to the ebpf.annotate-complexity output. It also adds a task that shows the lines with the highest complexity.
Motivation
Surfacing the register values the verifier has can help understanding its behavior.
Additional Notes
Example output:

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge