429 when uploading many files

Describe the bug
Hi,
I'm using the experimental upload-large-folder feature. I'm trying to upload ~2000 files, but I'm running into a 429 error. Would it be possible to increase the rate limit when using the upload-large-folder feature?
Thanks!
Reproduction
No response
Logs
No response
System info
- huggingface_hub version: 0.25.1
- Python version: 3.12.5
- Running in iPython ?: No
- Running in notebook ?: No
- Running in Google Colab ?: No
- Running in Google Colab Enterprise ?: No
- Has saved token ?: True
- Configured git credential helpers: store
- FastAI: N/A
- Tensorflow: N/A
- Torch: 2.4.1
- Jinja2: 3.1.4
- Graphviz: N/A
- keras: N/A
- Pydot: N/A
- Pillow: 10.4.0
- hf_transfer: 0.1.8
- gradio: N/A
- tensorboard: N/A
- numpy: 1.26.4
- pydantic: N/A
- aiohttp: 3.10.8
- ENDPOINT: https://huggingface.co
- HF_HUB_OFFLINE: False
- HF_HUB_DISABLE_TELEMETRY: False
- HF_HUB_DISABLE_PROGRESS_BARS: None
- HF_HUB_DISABLE_SYMLINKS_WARNING: False
- HF_HUB_DISABLE_EXPERIMENTAL_WARNING: False
- HF_HUB_DISABLE_IMPLICIT_TOKEN: False
- HF_HUB_ENABLE_HF_TRANSFER: False
- HF_HUB_ETAG_TIMEOUT: 10
- HF_HUB_DOWNLOAD_TIMEOUT: 10

Hi @fakerybakery! sorry you ran into this issue. to help us better understand the problem, could you please provide the traceback of the error and the printed report of upload_large_folder as well to have more details about the number of files uploaded before hitting the 429 error, their sizes and the number of commits generated. thanks!

Hi,
I'm getting this error:
Failed to commit: 429 Client Error: Too Many Requests for url: https://huggingface.co/api/datasets/username/repo/commit/main (Request ID: Root=...)

You have been rate-limited; you can retry this action in about 1 hour. If you're a new user, your limits will raise progressively over time. Get in touch with us at<EMAIL_ADDRESS>if you need access now.

Hi @fakerybakery, we had an incident yesterday on our side that required temporarily reducing our rate limits. However, it has been fixed since then and rate limits have been restored to normal.
I'm closing this issue but don't hesitate to comment if you're still encountering this problem 🙂

Hi,
Thanks for the information. I've been getting this issue for a while, was this incident just yesterday or for the past couple weeks?
Thanks!

Hi,
I was trying to upload a large folder (~150k files) again and got the same error.

Hi @fakerybakery, you've hit the hard limit of numbers of files per repo. In the repo size recommendations,(https://huggingface.co/docs/hub/repositories-recommendations) we set the limit to 100k files per repo.
What is the file format you're working with? It would help to know if you can group these files together to reduce the total count.


Set FailurePolicy to Ignore for settings validator

Issue:

https://github.com/rancher/rancher/issues/45841
Problem

We have a "catch 22" situation with the settings validator as rancher may update some settings on startup while the webhook is starting up.
Solution

Change the FailurePolicy to Ignore on settings' validator to avoid timeouts.
CheckList

[ ] Test

[ ] Docs

Adding @maxsokolovsky to know his thoughts since this can affect the newest agent-tls-mode settings. From my POV it seems fine.

@ericpromislow

Where is .FailurePolicy used as an r-value?
Handled by k8s. https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#failure-policy

How would I test this?
E.g. as shown in the integration test included in this PR:

Scale webhook to 0
Try to create or update a setting.
With the FailurePolicy set to Ignore it will succeed whereas with Fail it will reject the request


haskellPackages.purescript_0_10_1 build breaks at the test stage

Issue description
When i try to install purescript-0.10.1,
it wants to build it and falls (in the end)
with an error message —
tests: npm: callProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
Test suite tests: FAIL
Test suite logged to: dist/test/purescript-0.10.1-tests.log
0 of 1 test suites (0 of 1 test cases) passed.
builder for ‘/nix/store/psa[...]r5kj-purescript-0.10.1.drv’ failed with exit code 1
I also tried to install nodejs before purescript as in
https://pr06lefs.wordpress.com/2015/01/11/get-started-with-purescript-on-nixos/
with approximately the same result.
Switched to unstable (17.03pre94694.fa4167c). Result is the same.
Steps to reproduce
Just try to install haskellPackages.purescript_0_10_1
Technical details

System: (NixOS: nixos-version)
16.09.824.e4fb65a (Flounder)
17.03pre94694.fa4167c (Gorilla)

Nix version: (run nix-env --version)
nix-env (Nix) 1.11.4
nix-env (Nix) 1.11.4

Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)
"16.09.940.8a5c376"
"17.03pre94694.fa4167c"

Solution (i'm not sure)?...
Do we need something like
purescript_0_10_1 = dontCheck super.purescript_0_10_1;
in pkgs/development/haskell-modules/configuration-common.nix
to disable tests?

+1

That exact change fixed it for me.

You can get purescript 0.10.1 up and running by cloning the repo with the fix in, then sudo nixos-rebuild switch -I nixpkgs=/path/to/repo

Thank you for testing!
May be we should wait for nixos-unstable builds to close this ticket?...
(Certainly i can use master branch. But most people do not want it?)

Upgraded to 17.03pre96298.b09435e (Gorilla) where we have purescript-0.10.2
At the first sight, all works fine.


Investigate manual plugin installation

We're using Antibody, but this plugin mentions a manual option.

Another mention of manual installation.

This one lists Homebrew first, and doesn't explicitly show a manual variation.

This one dissuades us from using a plugin manager.

The zsh-syntax-highlighting authors recommend manual installation over the use of a framework or plugin manager.

And another, though this one isn't under the zsh-users organization.

The plugin is "standalone", which means that only sourcing it is needed. So to install, unpack history-search-multi-word somewhere and add
source {where-hsmw-is}/history-search-multi-word.plugin.zsh

to zshrc.

Let's explore zinit.

Spaceship Prompt has longer manual instructions than other plugins.
It can also be installed with npm, so we could put it in setup-node.zsh with other global installs.

While not technically a plugin, Improved Nano Syntax Highlighting Files could be installed in similar fashion.
Look into this instead of, or in addition to, c107ed4a6ce8e852aba65d0465bd7b960ac814bf.


Change default activation string

The default activation string should be <Ctrl-space> instead of <Cmd-space>, because the latter conflicts with the SpotLight hotkey and having Cmd is weird on some platforms, according to customer.
Acceptance criteria

[ ] activation string changed
[ ] possible conflicts with other hotkeys investigated

I think that <Ctrl-space> is a bad idea, since that's already the shortcut for code completion

Soooo, we decided that we don't want Alt or Cmd, we don't want Ctrl+Shift so only Ctrl+<some letter> remains. The only letter on the left half of my quertz keyboard that I don't already associate with another action is Ctrl-r (seems to do nothing right now :bangbang: ). On the right hand, there are some options, maybe Ctrl-o(opens a new workspace, some other meaning in world context), Ctrl-u (sets alignment), Ctrl-h (does something in world, nothing happens though), Ctrl-j (seems to reload workspace window), Ctrl-k (opens some prompt about font or so), Ctrl-l (discards changes in workspace).
I guess Ctrl-r is fine, can any of you verify that ctrl-r is not important?

Alt + r/Ctrl + r on Windows is used to restore the display which removes all drawing invalidations. You can see it in effect by doing the following:
'foo' displayAt: 0 @ 100.
"Now press alt + r"

I can speak for the SWA group and say that some people including myself actually use this shortcut quite frequently. :-)
Just another idea, did you consider a keyboard sequence such as Ctrl, Ctrl (i.e. press the key twice in a certain interval)? For such a meta action like invoking Algernon I think this might actually be a more catchy shortcut than a random letter. Just my 2 cents, though. :-)


Add flexible cuda memtest

Quoting from Nick:

I use
cuda_memtest --disable_test 6 --num_passes 1
This is public domain code, so google cuda_memtest should give you a description of everything.
You can see all the possible options with:
cuda_memtest --help
Here is a list of tests:
cuda_memtest --list_tests
[06/23/2018 11:25:13][nid03508][0]:Running cuda memtest, version 1.2.2
Test0 [Walking 1 bit]
Test1 [Own address test]
Test2 [Moving inversions, ones&zeros]
Test3 [Moving inversions, 8 bit pat]
Test4 [Moving inversions, random pattern]
Test5 [Block move, 64 moves]
Test6 [Moving inversions, 32 bit pat]
Test7 [Random number sequence]
Test8 [Modulo 20, random pattern]
Test9 [Bit fade test]  ==disabled by default==
Test10 [Memory stress test]
The README file contains a description of each test.
One thing to keep in mind is that if your run this, even to just list the tests, on a node that does not have a gpu, you will gget some strange errors.


Copying the wins.exe to the location expected by monitoring chart.

This just copies the wins.exe as part of the instal.ps1 to guarantee that Wins in the location expected in the charts. This was handled by the Rancher-agent prior to RKE2.

https://github.com/rancher/rancher/issues/35851

Signed-off-by: Jamie Phillips<EMAIL_ADDRESS>

This passed deployment checks and the Wins exporter issue was addressed

.


updated details for Azure Singapore event

Added folder for Global Azure Bootcamp Singapore event

Pleaes advise @NileshGule!

I’ll update the PR soon with suggested changes
Get Outlook for iOShttps://aka.ms/o0ukef

From: Magnus Mårtensson @.>
Sent: Tuesday, February 7, 2023 3:11:22 PM
To: globalazure/communities @.>
Cc: Nilesh Gule @.>; Mention @.>
Subject: Re: [globalazure/communities] updated details for Azure Singapore event (PR #118)
Pleaese advise @NileshGulehttps://github.com/NileshGule!
—
Reply to this email directly, view it on GitHubhttps://github.com/globalazure/communities/pull/118#issuecomment-1420297608, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJ47RWTU5OTE4GBJCZDLH3WWHYRVANCNFSM6AAAAAAUS7ABGY.
You are receiving this because you were mentioned.Message ID: @.***>

@noopman I have made the requested updates. Pls review and let me know if any other changes are required


Value of $KUBECONFIG is ignored

What happened:
While testing with KIND, I noticed that kubectl kudo commands insisted on using configuration values for my cluster from ~/.kube/config instead of the value set via the KUBECONFIG environment variable (~/.kube/kind-config-kind in this case):
$kubectl kudo install pkg/kudoctl/util/repo/testdata/zk
Error: could not install operator(s): creating kudo client: operators: Get https://<IP_ADDRESS>:8443/apis/kudo.k8s.io/v1alpha1/namespaces/default/operators: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

What you expected to happen:
If $KUBECONFIG is set, the value for that should be used.
How to reproduce it (as minimally and precisely as possible):
Set the KUBECONFIG environment variable to something other than the default and then run a KUDO command such as install.
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): 1.14
Kudo version (use kubectl kudo version):  KUDO Version: version.Info{GitVersion:"v0.2.0", GitCommit:"57e1ea96821d228eb33d58861b33955ce8f4d143", BuildDate:"2019-06-28T15:14:44Z", GoVersion:"go1.12.6", Compiler:"gc", Platform:"darwin/amd64"}
Operator:
operatorVersion:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): macOS 10.14.5
Kernel (e.g. uname -a):
Install tools:
Others:

I would recommend that we switch our usage of clientcmd.BuildConfigFromFlags to the controller-runtime's GetConfig method which does the right thing: https://github.com/kudobuilder/kudo/blob/master/pkg/kudoctl/cmd/install/install.go#L77


cmd/internal/obj/x86: improve asm error messages

Some assembler error messages are misleading and miss context info.
99% of errors programmer get is invalid instruction which does not help that much.
Go (or plan9) asm has its peculiar points that make initial experience, coupled with such error messages,
very unpleasant.
There are multiple aspects of error messages that can be improved, but for the very start,
some obviously horrible things can be changed.
I present some cases where error message could be more precise/informative.
If applicable, clang asm error message for the same case is provided.
This is a proposal to start a discussion regarding this topic.
Maybe someone will point important pitfalls, or provide more cases
that worth a fix.
Scope of this one restricted to x86 assembler backend.
TEXT main·asmErrors(SB),$0
        // 1
        // Case: immediate operand overflow.
        // Note: base16->base10 constant conversion in error message
        //       is annoying too, but it is separate issue.
        //
        // Have: "invalid instruction: ADDQ $-2415919103, AX"
        // Want: "ADDQ(imm32,r): constant -2415919103 overflows imm32"
        ADDQ $-0x8FFFFFFF, AX
        // 2
        // Case: invalid operand types combination.
        //
        // Have: "invalid instruction: MOVL (R8), (R9)"
        // Want: "MOVL with (mem,mem) operands combination does not exist"
        //
        // Clang:
        // > invalid operand for instruction
        // >   movl (%R8), (%R9)
        // >               ^~~~~
        MOVL (R8), (R9)
        // 3
        // Case: negative immediate for unsigned operand.
        //
        // Have: "invalid instruction: PSHUFL: $-10, X0, X1"
        // Want: "PSHUFL(uint8,xmm,xmm): invalid negative immediate value -10"
        PSHUFL $-10, X0, X1
        // 4
        // Case: using "SP" register as "index" in SIB addressing.
        // Note: same goes for XMM and other non-suitable for index registers.
        //
        // Have: "invalid instruction: MOVL (AX)(SP*2), AX"
        // Want: "SP register can't be used as index in SIB addressing"
        MOVL (AX)(SP*2), AX
        // 5
        // Case: SIB without explicit "scale".
        // See:  #13282.
        //
        // Have[1]: "invalid instruction: MOVL foo<>(SB)(AX), AX"
        // Have[2]: "asmidx: bad address 0/2064/2064"
        // Want:    "SIB addressing without explicit scale is forbidden"
        MOVL foo<>(SB)(AX), AX // [1]
        MOVL (AX)(AX), AX      // [2]

        RET

The error messages in Want section provided for demonstration purposes.
I think it is more important to collect as many weird cases as possible, to evaluate how much improvement can be brought there.
This investigation lead me to 2 distantly related issues.

BYTE accepts uint64 argument, but always writes only single byte. Silently.
Errors like asmidx: blah-blah do not provide error location (source file + line).

The "illegal instruction" error message is quite fabulous:
https://blog.sgmansfield.com/2017/04/a-foray-into-go-assembly-programming/
I've almost prepared a CL that fixes most of "invalid instruction" error messages to more precise and descriptive strings.

I think it is more important to collect as many weird cases as possible, to evaluate how much improvement can be brought there.

I came across the following case:
TEXT ·test(SB), NOSPLIT, $0
    // valid: LEAQ 0(CX)(R14*1), R15
    LEAQ 0(CX)(R14), R15
    RET

The message is:
asm: asmidx: bad address 0/2078/2065
asm: assembly failed


Laravel 11

Based on Shift's PR, Corrected passports version

Thanks for your PR. I ended up just fixing it myself. Some minor changes were necessary to the testing setup as you can see from the failed builds. 6.0.0 should now support laravel 11, but please let me know if you have any issues.


South Pole Observatory data

lots of stuff there: http://www.esrl.noaa.gov/gmd/dv/data/index.php?site=spo

Here's one: description of data / data for 2015. There is a standard directory structure so when the year rolls over the url could change.
The way this data is aggregated yearly means that this might depend on #104. And also, we may need a more complex way to generate the source URLs. Currently, they can be hard-coded in the config or the river initializer function can return them, but that only gets called on River View startup.


[WIP] Added filter field to the right column for FilteredSelectMultiple wid…

…get. Refs #24179.
I have added the new feature. It's currently for 1.8 version. Please see if the functionality is correct and I will update it for the master branch.  Please don't review the code itself. It will need refactoring after the functionality is confirmed.

Functionality looks like what I would expect. Still, I think it should be more obvious that the non-filtered list will be submitted. Perhaps you could look into how other widgets handle this.
I wonder if we even might find an existing jQuery plugin or similar that could replace our homegrown solution (https://code.djangoproject.com/ticket/15220).


Support for Backpack\Crud 4.1

this PR should be fixed this issue?
Problem 1
    - backpack/generators v2.0.7 requires backpack/crud 4.0.* -> satisfiable by backpack/crud[4.0.x-dev].
    - backpack/generators 2.0.0 requires backpack/crud 4.0.*|v4.x-dev -> satisfiable by backpack/crud[4.0.x-dev].
    - backpack/generators 2.0.1 requires backpack/crud 4.0.*|v4.x-dev -> satisfiable by backpack/crud[4.0.x-dev].
    - backpack/generators 2.0.2 requires backpack/crud 4.0.*|v4.x-dev -> satisfiable by backpack/crud[4.0.x-dev].
    - backpack/generators 2.0.3 requires backpack/crud 4.0.*|v4.x-dev -> satisfiable by backpack/crud[4.0.x-dev].
    - backpack/generators 2.0.4 requires backpack/crud 4.0.*|v4.x-dev -> satisfiable by backpack/crud[4.0.x-dev].
    - backpack/generators 2.0.5 requires backpack/crud 4.0.*|v4.x-dev -> satisfiable by backpack/crud[4.0.x-dev].
    - backpack/generators 2.0.6 requires backpack/crud 4.0.*|v4.x-dev -> satisfiable by backpack/crud[4.0.x-dev].
    - backpack/generators v2.0.7 requires backpack/crud 4.0.* -> satisfiable by backpack/crud[4.0.x-dev].
    - Can only install one of: backpack/crud[4.0.x-dev, 4.1.x-dev].
    - Installation request for backpack/crud ^4.1@dev -> satisfiable by backpack/crud[4.1.x-dev].
    - Installation request for backpack/generators ^2.0 -> satisfiable by backpack/generators[2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, v2.0.7].

Indeed - though I think it'll be more useful to install backpack/crud using 4.1.x-dev as 4.0.99 for now.

Thank you for taking the time to submit the PR @vonsogt , but let's close this in favour of https://github.com/Laravel-Backpack/Generators/pull/68 - which has a better fix for this, and a few new commands.


Resolve Installation Ordering Issues Preventing PR Checks of dependent packages

@xiangyan99 @iscai-msft
The issue was introduced when I implemented the addition of some additional restrictions when pulling from PyPI.
Nightly builds would still be pulling the latest version of azure-core, but PR builds wouldn't be getting the checks properly as @xiangyan99 and @iscai-msft identified to me this morning.
I believe this should be the only fix, but I'm running some additional verification jobs to be certain of that.
The cause of this bug is that when we are installing a target package, we evaluate it's dependencies for azure specific packages. We go and grab those from a our single dev feed. The problem is that we always do this, meaning that we replace the relative dependency version already installed with dev_requirements.txt.
The bugfix checks the already installed packages and takes no action if an already installed version matches a version spec from install_requires.

This looks g2g afaict. I'll take look at all the daily builds tomorrow.


multiline annotation only storage last line

Attach (recommended) or Link to PDF file here:
https://mozilla.github.io/pdf.js/web/viewer.html
Configuration:

Web browser and its version: Chrome 117.0.5938.150 (Official Build) (64-bit) (cohort: Control)
Operating system and its version: Windows 11 Version 22H2 (Build 22621.2283)
PDF.js version: PDF.js: 4.0.40 [d64f223d0]
Is a browser extension: No

Steps to reproduce the problem:

Add annotation 111111 and line break and 222222
Print or Save the PDF

What is the expected behavior? (add screenshot)
What went wrong? (add screenshot)
The first line is missing, only second line 222222

Duplicate of #17079


 When I apply the proposed model for multi-gpu training, it got unrecognized error: --local-rank. It seems that the linux system defaultly transmit the config "local-rank" instead of "local_rank" (see the different between '-' and '_'). As soon as i add
parser.add_argument("--local_rank", "--local-rank", default=0, type=int) to parser the two arguments into one.
it went well.

Actually, this is due to different pytorch versions. After PyTorch 2.0, pytorch recommends to use "local-rank". Please see [https://pytorch.org/docs/stable/elastic/run.html#transitioning-from-torch-distributed-launch-to-torchrun] 2.


Add new getOriginLocation and getContextualLocation methods to the Problems

This change retains backward compatibility towards older TAPI clients. The behavior will be that older TAPI users will get origin+attributed locations
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle merge

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.


BLANK PAGE

This is what I get, recently, when I open desktop Tusk!!! What is the problem?!?

Please look at issue #308
You will find workarounds there :)
The official solution probably will arrive on the next release.

For some reason Ubuntu doesn't recognize "sudo" anymore! Note, I'm new at
Ubuntu
E: Type 'sudo' is not known on line 2 in source list
/etc/apt/sources.list.d/signal-xenial.list
E: The list of sources could not be read.
On Sat, Feb 13, 2021 at 3:20 PM Allan Freitas<EMAIL_ADDRESS>wrote:

Please look at issue #308 https://github.com/klaussinani/tusk/issues/308
You will find workarounds there :)
The official solution probably will arrive on the next release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/klaussinani/tusk/issues/323#issuecomment-778626040,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ7AYVWHK6WH2DG36OGGSQ3S62DB7ANCNFSM4XSBDEPA
.

--
Dejan


Regarding UI/UX

Can you make UI of bard-rs looks like as above, because It looks more clean and readable also taking notes is easier.
It would great if you add that arrow.

would this be good?

Yooooooooo ❤❤❤❤❤❤❤❤
You're my bro!
Thanks Thankyou so much.Awesome
On Fri, 19 May, 2023, 1:44 pm seok, @.***> wrote:

[image: image]
https://user-images.githubusercontent.com/2356749/239478559-c4c78187-299f-4ba2-8ed4-bb857713de50.png
would this be good?
—
Reply to this email directly, view it on GitHub
https://github.com/Alfex4936/Bard-rs/issues/3#issuecomment-1554211620,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUKZUKM7RLW2ONLKVDNOBQLXG4TXFANCNFSM6AAAAAAYGS5YOM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Please tell how to update with cargo install not git pull

Just updated through cargo so let me know if it works well :)

How to update with cargo I don't want to use git
On Fri, 19 May, 2023, 1:56 pm seok, @.***> wrote:

Just updated through cargo so let me know if it works well :)
—
Reply to this email directly, view it on GitHub
https://github.com/Alfex4936/Bard-rs/issues/3#issuecomment-1554224802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUKZUKLIUMKQVDVTG5NHBUTXG4VB5ANCNFSM6AAAAAAYGS5YOM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Awesome, thanks!
On Fri, 19 May, 2023, 2:02 pm seok, @.***> wrote:

cargo install bard-rs will update to latestest version automatically
—
Reply to this email directly, view it on GitHub
https://github.com/Alfex4936/Bard-rs/issues/3#issuecomment-1554231956,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUKZUKKUYE2YVUX3HP7CYMLXG4V3FANCNFSM6AAAAAAYGS5YOM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Works like a charm, Thanks ^_^!

Can you add following gif animation to "bard: thinking...." ---> bard:thinking  instead of static dots add colourfull dots that jumps as in gif. If gif not possible atleat add colourfull dots or any other loading animation.

hmm adding a loading animation would be indeed difficult task but I have an idea so will try to work on it in next weekdays :)

I am still figuring out the most appropriate way to update progress bar for POST function.

this would be enough I think

Also for code it would be nice to print it in a way where there is syntax highlighting!

@inquire I'm considering implementing it with syntect, although I'm hesitant because bard-rs supports real-time saving to a markdown file so idk yet
@Code-acious hasn't been released yet. I've encountered a bug in most terminal apps where the progress bar gets left behind when changing the terminal size, particularly when using the indicatif crate. However, I plan to release it soon, featuring a loading bar style inspired by Google, which I showcased in my previous comment.

Yo the Google inspired loading animation is gr8. That's what I was telling you. Please implement that only, can't wait to try it. 🏅🏅🏅🏅

I fell betrayed where are my dots u showed me 🥺🥺🥺🥺. I got circling bar animation. Anyways good effort 🤧🤧🤧🤧.

Haha thanks but I had to choose most compatible characters (just / ) for common terminals.
But you can change it by changing LOADING_CHARS with your custom chars or tick_chars I left in my code such as  // let tick_chars = "○○◔◔◑◑◕◕●●◕◕◑◑◔◔ ";
Then you can cargo install --path . to install globally.

Yeah 😀 I know, I myself was concerned about will the characters support
for my terminal.
Anyways are you testing tgpt (Bai Chat terminal client)? If not you should
because in recent update it added a really cool feature where you can type
long prompts and if u have done spelling error or want to add something to
your prompt you can do it on the go which is was possible earlier and not
supported in bard-rs. It adds a little text editor. Basically u can now
move cursor with arrow keys.
You can find tgpt-bin in AUR or on GitHub author is andrew-me. Thanks.
On Fri, 26 May, 2023, 5:07 am seok, @.***> wrote:

Haha thanks but I had to choose most compatible characters (just / ) for
common terminals.
But you can change it by changing LOADING_CHARS with your custom chars or
tick_chars I left in my code such as // let tick_chars =
"○○◔◔◑◑◕◕●●◕◕◑◑◔◔ ";
Then you can cargo install --path . to install globally.
—
Reply to this email directly, view it on GitHub
https://github.com/Alfex4936/Bard-rs/issues/3#issuecomment-1563632518,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUKZUKPEPHTUXZU4RF6SBV3XH7UKDANCNFSM6AAAAAAYGS5YOM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
🎉 Congratulations! You've won a share of the $1.500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. But that's not all—connect now, and you'll instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1.500k in BNB! Plus, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, seize the chance to win up to $20,000—it's your golden opportunity!
Winners: @

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
🎉 Congratulations! You've won a share of the $1.500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. But that's not all—connect now, and you'll instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1.500k in BNB! Plus, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, seize the chance to win up to $20,000—it's your golden opportunity!
Winners: @

Exciting Job Opportunity at Microsoft!
Congratulations! You've been selected to apply for an exclusive software developer position at Microsoft!
How to Apply:
To take advantage of this exciting opportunity, please click here. Hurry, applications close on March 1, 2024.
Job Description:

Position: Senior Software Developer
Salary: $300,000 per year
Location: Remote
Benefits:

Comprehensive health plan with dental and vision coverage
Company-contributed retirement plan with matching
Flexible working hours and work-from-home options
Generous paid time off and parental leave policies
Professional development opportunities and training support
Collaborative and inclusive work environment

Requirements:

Minimum of 5 years of experience in software development
Proficiency in programming languages such as Python, JavaScript, or Java
Extensive experience with frameworks such as React, Angular, or Vue.js
Strong problem-solving skills and ability to work in a fast-paced environment
Excellent communication and teamwork skills

Note: This position is open to candidates from anywhere in the world. Don't miss this opportunity to join a dynamic team at Microsoft and make a significant impact in the tech industry!
kirtangajjar, @caentzminger, @krisjpi, @afewnotes, @atlasstrategic, @ThalKod, @udit-gulati, @AgusVargas, @dwojcik92, @DuncanBetts, @nanspro, @mschwers, @21998524, @ytfei, @basgir, @gwthompson, @keeganskeate, @Cj-bc, @blocksherpa, @vinayakathavale

Thanks for all your support 💓.


Deal with unmapped items in Korea inventory 2022

The reading function of the South Korean 2022 inventory leaves some categories untranslated and unmapped.

습지에서 배수로 인한 Non-CH4 배출
초지에서 농업용 석회시용으로 인한 CH4 배출
산림지에서 배수로 인한 Non-CH4 배출
농경지에서 농업용 석회시용으로 인한 CH4 배출

find mapping for them or ignore them explicitly. All of these categories contain zero only time-series.

Translations:

Non-CH4 emissions due to drainage from wetlands
CH4 emissions from agricultural lime application on grassland
Non-CH4 emissions from drainage from forest land
CH4 emissions from agricultural lime application in agricultural fields

done for 2023 inventory


Fix NPE in destroyKeys()

destroyKeys() in SharedPrefsBackedKeyChain currently assumes that both getMacKey() and getCipherKey() had been called before. This is not always the case, e.g., when not having used crypto after starting the app or when either using enc/dec or integration checking.

Great catch. Thanks for the fix.


Cody chat hanging

Installation Information:

I'm on the nightly build (5.2.11078-nightly) and Cody hangs when I enter a question into the chat input.
(optional) Error message or idea.log output:

Steps to reproduce:

I could repro logged into both my dotcom account and sourcegraph.sourcegraph. Loom.
Expected Behaviour:

Cody should generate a response :)

https://github.com/sourcegraph/jetbrains/pull/163
☝ this one should fix it.

Hello @taylorsperry 👋 a lot happened since this issue was raised. I believe that it's fixed by https://github.com/sourcegraph/jetbrains/pull/172.
Can you confirm that you do not experience this issue anymore? 🙏

Not seeing this behavior anymore, thank you, @mkondratek !


Add optimizer to pushdown writes through UNION ALL

When processing queries that created tables from UNION ALLs of other tables, Presto would collect all results from the UNION ALL into a single node prior to writing. Added an optimizer that pushes the TableWriter nodes through the union. This will improve performance by allowing workers to write to the new table in parallel.
Fixes #3965.

Seems good to me except minor comments.
@erichwang Are you available to take a look at TableWritePushdownThroughUnionAll.java?

looks good


Show quick-add dialog when dragging wire to empty space

[x] New feature (non-breaking change which adds functionality)

This is a rework of #3858 that had the right idea, but removed support for detaching wires. Thanks to @dreamair for proposing this feature.
When dragging a wire from a node and releasing the mouse in empty space on the canvas, it will now show the quick-add dialog.
Previously we'd only do that if you held ctrl/cmd when dragging.
This also fixes an issue where, following a quick-add of a node in a group, we were selecting the group. This was appropriate behaviour before #4079, but not now.

Coverage: 68.627% (+0.08%) from 68.546% when pulling 37524e05bb5fb3ebdd02366e4011703507898f2f on quick-add-wiring into d1094da6c74c39d5a7c2944520f27015c74de3ca on dev.

Rather than replace #3858, I've taken that branch, restored the 'detach wires' function and merge it.


rework navigation component to reposition the name-box and save status

comments welcome

The design looks way better than before! Thanks. However, there are some issues that I identified when testing:

When the focus goes onto the workflow name input box, it shrinks the size to be too small:

When typing in the input box, you can see the cursor is out of the input box:

When resizing the window, the control buttons and the operator menu are starting to disappear. I don't like this, @zuozhiw @avinash0161 what do you think?
 (See that the Run button and operators penal are disappearing.

@MysteriousChallenger #924 changed version number component already. Let's sync with that.

In reply to review https://github.com/Texera/texera/pull/923#issuecomment-739616366

added a minimum width to the name input
save status smaller and grey (the save message itself is pretty long, but that can be changed later)
removed extra version number in the navigator


Don't call flushStreams() from Logger::logMessage() for Errors and Warnings

The Logger::logMessage() method calls flushStreams() for ERROR and WARNING messages. In the context of MPI applications, that use MPI-aware LogStream  instances, e.g., SynchronizedStream or LumberjackStream, the call to flushStreams() is a collective operation.  This makes logging of all ERROR and WARNING messages  a collective operation. However, this behavior is opaque to the application developer, making it easy to write erroneous code that hangs.
For example, the following will always hang:
SLIC_ERROR_IF( rank==0, "error from rank 0" );

Instead of hiding the call to flushStreams() inside the Logger::logMessage(), flushStreams() must be placed within application-level macros that better indicate that the call is collective.
For example:
SLIC_ALL_ERROR()
SLIC_ALL_WARNING()

Need some sort of asynchronous coordination across all MPI ranks

Bump. I just ran into this.
SLIC_ASSERT is also not safe in an MPI context unless all threads are calling it.

@kennyweiss any thought on how best to handle this sort of thing?

@kennyweiss any thought on how best to handle this sort of thing?

I just ran into this again last week.
The problem is actually more serious than we originally thought. I.e. the problem is not that is "[makes] it easy to write erroneous code that hangs", as in the description above. Rather, it is flawed by when calling SLIC_ASSERT as designed.
If you call SLIC_ASSERT in an mpi run with an MPI-based LogStream, with a condition that is true on some ranks, but not others, it will cause a hang in the application since some ranks will call logMessage (with an internal flush) and others will not.
Specifically, calling SLIC_ASSERT:
https://github.com/LLNL/axom/blob/6cbb6a1000cbd55711611fe4e6024f5c97ffaa55/src/axom/slic/interface/slic_macros.hpp#L169-L178
Will eventually invoke flushStreams on a subset of the ranks
https://github.com/LLNL/axom/blob/0fbe605937207e4c60f427423fcdad59246fc828/src/axom/slic/core/Logger.cpp#L196-L225

 #define SLIC_ASSERT(EXP)                                            \
   do                                                                \
   {                                                                 \
    // check EXP \
     if(! < this rank failed>)                                                      \
     {                                                               \
       std::ostringstream __oss;                                     \
       __oss << "Failed Assert: " << #EXP << std::ends;              \
       axom::slic::logErrorMessage(__oss.str(), __FILE__, __LINE__); \
      // Remove flush and exit from above log message
     }                                                               \
    // Gather if any ranks failed
    // if ANY ranks then flush and exit all ranks
   } while(axom::slic::detail::false_value)

Resolved in #868


Glibc 2.17 on python3.7 image. Should be Glibc 2.26.

I encountered this error running TF 1.14.0 on amazon/aws-lambda-python:3.7 :
ImportError: /lib64/libm.so.6: version `GLIBC_2.23' not found (required by /var/task/tensorflow/python/_pywrap_tensorflow_internal.so)

Inspecting the Glibc version in this running container with docker exec -it <container> ldd --version ldd shows ldd (GNU libc) 2.17
Per the resource, AWS Lambda > Developer Guide > Working with Python > Deploy container images , the image is using the Amazon Linux 2 operating system which is supposed to come with Glibc 2.26.

Thanks @patrickodpt for reporting this! The Lambda python3.7 runtime & base image use the Amazon Linux 2018.03 base OS and the documentation was inaccurately suggesting Amazon Linux 2 instead.
This has since been updated to list the base OS for Python 3.7 as Amazon Linux 2018.03 (link here)
Apologies for the inconvenience this has caused and thanks again for highlighting the issue :)


Fix/1975 azurerm logic app standard subnet

1975
But also contains fixes for:
https://github.com/aztfmod/terraform-azurerm-caf/issues/1977
https://github.com/aztfmod/terraform-azurerm-caf/issues/1973
because those are required for this to work.
PR Checklist

[x] I have added example(s) inside the [./examples/] folder
[x] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
[x] I have checked the coding conventions as per the wiki
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

[x] YES
[ ] NO

As described in my issue 1975, the proposed change will lead to a short downtime for existing deployments.
Testing

Hey @arne21a, I've tried your fix(we are using the logic app in our caf deployment), however, the Vnet integration still doesn't work.
Using both subnet_id or lz_key,vnet_key and subnet_key.
Private endpoint and identity works : -)

hi @JoDexsph thanks for your feedback! Would you be able to provide your configuration and your error messages?
One general consideration: Many CAF modules struggle with subnets created in an other state then the vnet. This might also be the issue here.

Sure thing @arne21a , kindly check the following gist : https://gist.github.com/JoDexsph/6804a46d6702007d92eaffa5a842689b
Not sure if it my place to ask, but can you please add the "public_network_access_enabled" and "https_only" terms to the azurerm block?
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/logic_app_standard#public_network_access_enabled
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/logic_app_standard#https_only
Thanks.

Hi @JoDexsph
The posted configuration looks good to me at first glance. Unfortunately i do not have a test environment where i can test the upstream version of this repo, as my project uses a slightly diverged version which is not fully compatible.
The error message you get could give use a hint where to start troubleshooting.
About your other requests:
https_only is already merged: public_network_access_enabled
public_network_access_enabled is also something i would like to add, but it is not supported in the used provider version https://registry.terraform.io/providers/hashicorp/azurerm/3.75.0/docs/resources/logic_app_standard

Hello @arne21a , I am trying to run it via the rover and get Debug / Trace logs to have more information.
with Error log level, the deployment is completed successfully, but in the plan I cant find anything related to the vnet integration.

Hi @JoDexsph The posted configuration looks good to me at first glance. Unfortunately i do not have a test environment where i can test the upstream version of this repo, as my project uses a slightly diverged version which is not fully compatible. The error message you get could give us a hint where to start troubleshooting.
About your other requests: https_only is already merged: public_network_access_enabled
public_network_access_enabled is also something i would like to add, but it is not supported in the used provider version https://registry.terraform.io/providers/hashicorp/azurerm/3.75.0/docs/resources/logic_app_standard

Anyway regarding the azurerm, today CAF/Rover are using azurerm v3.105.0.
https://registry.terraform.io/providers/hashicorp/azurerm/3.105.0/docs/resources/logic_app_standard

@JoDexsph As i said, i am working with a diverged version of this project which does not include that provider version update as of right now. Thats the reason why i can not test it.
I will not propose features i was not able to verify.
Feel free to implement, test and propose this feature. It is on my wishlist too.

Hey @arne21a,
I've tried various ways to get the output, couldn't get it to give any data.
I will try to create a lab with Terraform and not CAF to run the module as a standalone to see the behavior.


Side panel element alignment

All side panels should use 16px as it's internal padding. This means unless items in the properties panel are nested, they should have a natural resting space 16px from the left side of the side panel.
Nested properties would be indented by 16px from the left of the last one. The lines have varying colors to differentiate the nest levels - parent is dark ($ui-04), all children are lighter ($ui-03).

Summary of CSS changes for this issue. Sharing "before" and "after" screenshots for comparison -

Adjusted padding for properties-ctrl-wrapper. This change affects ALL properties.

All side panels are using 16px padding

Wide flyout panels are using 16px padding

Added left borders for nested properties. Indentation increased to 16px.

Summary panel changes

Twisty panel changes

Tab changes


can you help me ,error: integer divide by zero

Traceback (most recent call last):
File "C:/Users/FireJohnny/Desktop/PHOW/sift.py", line 22, in
vlfeat.vl_phow(img)
File "C:\Python27\lib\site-packages\vlfeat_init_.py", line 25, in vl_phow
return f(*args, **kwargs)
File "C:\Python27\lib\site-packages\vlfeat\phow.py", line 109, in vl_phow
smoothed = vl_imsmooth(image, sigma)
File "C:\Python27\lib\site-packages\vlfeat\imsmooth.py", line 97, in vl_imsmooth
filter, -W, W, step, flags)
WindowsError: exception: integer divide by zero
I have this error ,i don't know how to fix it.

You need to provide the code you used to get this error for anyone to be able to help you, not just the traceback.

This division by zero is apparently happening inside the vlfeat library. I'm not sure what to do about that, though I could try updating the vlfeat binary since I haven't changed it in this package for a while... but as george said, it would be much more helpful if you could provide a minimal piece of code to replicate the error.

here is my code :
`#coding:utf-8
author = 'FireJohnny'
from PIL import Image
from matplotlib import image
import matplotlib.pyplot as plt
import vlfeat
import numpy as np
from numpy.random import shuffle
img = Image.open("timg.jpg")
_image = np.array(image.imread("timg.jpg"))
#img.show()
#plt.imshow(_image)
#plt.show()
img = img.convert("L")
img = np.array(img)
#img.show()
f,d = vlfeat.vl_dsift(img)
kmean = vlfeat.vl_kmeans(f,1000)
#sel = np.arange(f.shape(1))
#shuffle(sel)
f1 = vlfeat.vl_phow(img)`
I have read your source code, but my knowledge is not enough to fully understand it。

 It worked fine.
Can you provide the image you are working on to see if we can recreate the error?

This picture is what I uesed for my code.

I've tried your code with that image and it runs with no errors.
I can only suggest overwriting the vl.dll file in the "C:\Python27\lib\site-packages\vlfeat" directory with a fresh copy contained in http://www.vlfeat.org/download/vlfeat-0.9.16-bin.tar.gz , in the bin/your_os directory.


Memory interferences are back

With latest stabi branch the issue https://github.com/test-fullautomation/python-jsonpreprocessor/issues/98 is back.
Affected: JPP_0504 and JPP_0505
If JPP_0504 is commented out, JPP_0505 is passed.
If JPP_0504 is executed (currently failing), JPP_0505 also fails.

Hello Holger,
Thank you for your finding, I added some exception but forgot execute __reset(), that the reason Memory interferences are back.
I will push new commit to fix it.
Thank you,
Son

Hello Holger,
I pushed the commit to fix this issue on stabi branch.
Thank you,
Son

Retest successful. Issue can be closed.
(JPP_0504 still fails; but this is not a topic of this issue.)

Merged to develop branch

solved with version 0.10.0


Addition of Tilt Button Add-on for Enhanced Gameplay

Hello,
As a Smash Bros player, I recognize the importance of nuanced gameplay, especially how the angle of the joystick controls character movement. This led me to propose the addition of a Tilt button for the GP2040-CE controller. The Tilt button is a feature implemented in other controllers like the SmashBox and is crucial for replicating different joystick angles in leverless controllers.
My fascination with the GP2040-CE controller comes from its rapid development pace and its extensive capabilities. Beyond Smash Bros, I desired to use it for other games and was intrigued by the possibility of constructing a controller with the RP2040 chip implemented on the PCBA board.
I've added an add-on named 'tilt' which includes Tilt1 and Tilt2 buttons to control the values of the left and right analog sticks. By pressing the Tilt button simultaneously with the left and right analog sticks, it creates a state of slightly tilting the stick. I decided to incorporate the analog sticks into this add-on because it impacts the operation, and I felt it was safer to encapsulate this within the add-on code. However, I am open to suggestions if there's a better way of combining this with the main direction control and DualDirection.
I have also added a feature called 'Function button'. This, combined with pressing each direction of the right analog stick, enables pressing buttons like Home, Plus, Minus, Capture, etc. on the Nintendo Switch that you wouldn't want to press during a game. If deemed unnecessary, this feature can be removed.
I am open to feedback on this proposed change, and I am eager to refine this addition based on suggestions and critiques.
Thank you.

I'm noticing some indentation issues that may need to be resolved overall. While we don't necessarily have a well-defined code style guide, try to keep your indentation in line with the rest of the codebase.  Makes it easier to read.
A minor change would be to move the analog percentage values to #defines.  This will help make adjustments easier rather than changing the same value in multiple places.

The issues I pointed out are fixed @smashBrosKanu. You are lightning fast.

I have also added a feature called 'Function button'. This, combined with pressing each direction of the right analog stick, enables pressing buttons like Home, Plus, Minus, Capture, etc. on the Nintendo Switch that you wouldn't want to press during a game. If deemed unnecessary, this feature can be removed.

I don't know what the others think, but I think it might make sense to pull this out into a separate change, perhaps after or in anticipation of some other stuff we've been talking about that's in the works.
I have a "Function button" work in progress that is intended for use on hotkeys, e.g. Fn + Start + Down = DP Mode rather than Select + Start + Down = DP Mode. I'm not attached to the name, so I don't really care if a different feature takes the Function name, but I think, also, that what you've described could one day be solved as a Fn + Down = Capture hotkey, combining our works into one.
This also seems adjacent to a request bouncing around to have a software Tournament Lockout Mode, in which case maybe that could get implemented in a way where you choose which buttons (in your case, Home, Plus, Minus, Capture) are behind the lockout, and then a Fn hotkey to toggle lockout mode.
Just some context to consider, but in my opinion this feature is good but could probably be made general purpose, with a bit of coordination.

I have also added a feature called 'Function button'. This, combined with pressing each direction of the right analog stick, enables pressing buttons like Home, Plus, Minus, Capture, etc. on the Nintendo Switch that you wouldn't want to press during a game. If deemed unnecessary, this feature can be removed.

I don't know what the others think, but I think it might make sense to pull this out into a separate change, perhaps after or in anticipation of some other stuff we've been talking about that's in the works.
I have a "Function button" work in progress that is intended for use on hotkeys, e.g. Fn + Start + Down = DP Mode rather than Select + Start + Down = DP Mode. I'm not attached to the name, so I don't really care if a different feature takes the Function name, but I think, also, that what you've described could one day be solved as a Fn + Down = Capture hotkey, combining our works into one.
This also seems adjacent to a request bouncing around to have a software Tournament Lockout Mode, in which case maybe that could get implemented in a way where you choose which buttons (in your case, Home, Plus, Minus, Capture) are behind the lockout, and then a Fn hotkey to toggle lockout mode.
Just some context to consider, but in my opinion this feature is good but could probably be made general purpose, with a bit of coordination.

Thank you for your message and the innovative ideas.
I'm in agreement with the concept of the "Function button". It indeed offers a flexible and intuitive way to manage hotkeys.
I also concur with the suggestion of pulling out this feature from the tilt addon. In our addon, we need to adjust the values of the L stick and R stick, so we have set up our own stick settings. I do have a slight concern that these unique settings might prevent the stick inputs from being used in the separate implementation of the "Function button". However, I believe this is not a major issue, so please don't worry too much about it.
As a first step, I've commented out the Function button in the Tilt addon. I'm looking forward to further discussions and collaborations to make this feature more general-purpose.

@smashBrosKanu just a heads up that the Function button and assignable hotkeys have been merged to main.

@smashBrosKanu Once you can pull out the function bits and make this a pure tilt add-on, we'll get it in! You'll want to rebase as well, we have lots of changes coming in.

@arntsonl  Thank you for your feedback. As instructed, I have removed the feature-related parts to make this a pure tilt add-on. I have also performed the rebase, so it is up to date with the latest changes. If there's anything else that needs to be improved or added, please feel free to let me know. Thank you.

@smashBrosKanu Once you can pull out the function bits and make this a pure tilt add-on, we'll get it in! You'll want to rebase as well, we have lots of changes coming in.

Thank you for your feedback. As instructed, I have removed the feature-related parts to make this a pure tilt add-on. I have also performed the rebase, so it is up to date with the latest changes. If there's anything else that needs to be improved or added, please feel free to let me know. Thank you.

Hmm looks like the Cmake failed? Can you see if those errors make sense from our action cmake?

@smashBrosKanu For some reason you add a bunch of code to GamepadOptions.h. On the main branch this file is completely empty and should probably removed. This causes a clash of two different GamepadOptions structs.
I can only speculate why this is the case, it was probably a merge gone wrong.

@arntsonl @mthiesen
Thank you for your feedback. I've made the necessary corrections and removed the additional code from GamepadOptions.h. Could you please review the changes?

I've created a batch process to run CMake for each configuration and have successfully tested it in the local environment. I kindly ask you to review the workflow again. Your further confirmation will greatly assist in ensuring everything is in order.
Thank you for your time and cooperation.

@arntsonl  @SavageCore  @mthiesen
I've created a batch process to run CMake for each configuration and have successfully tested it in the local environment. I kindly ask you to review the workflow again. Your further confirmation will greatly assist in ensuring everything is in order.
Thank you for your time and cooperation.

Hi @smashBrosKanu looks like things are building now!!
But it looks like you've added and changed several files as well as added a new board config? I'll add comments to these, but please remove the board config you've added and make that a separate PR.

@smashBrosKanu is this ready to go or do you have more commits?

@arntsonl Thank you for your guidance. I've successfully isolated the new KanuCon board as a separate PR and also made the minor formatting and spacing adjustments you pointed out. I'm eager to learn more about Git merging and diff functionality. Could you kindly point me to some good tutorials? Your help is much appreciated.

Here are 3 good articles on branching, merging, and PR requests as well as a cheat sheet:
https://git-scm.com/book/en/v2/Git-Branching-Basic-Branching-and-Merging
https://www.atlassian.com/git/tutorials/making-a-pull-request
https://www.atlassian.com/git/tutorials/atlassian-git-cheatsheet
If you are in Windows, I would suggest using TortoiseGit or some other visual Git tool. I've used "SmartGit" in my professional life in Linux, they have a free one for projects like these.

I would also suggest getting a good merging/diff tool for handling conflicts. I use WinMerge on Windows, and DiffMerge works well in Linux.

@arntsonl I greatly appreciate your advice and the resources you've shared. I'll make sure to read through the articles and experiment with the suggested applications. Your guidance is invaluable to me.


Bug: KeysByType includes undefined

Looks like for some reason undefined is getting included in the result for KeysByType
interface Obj { a: string; b?: number; }

type StringPropertyKeys = KeysByType<Obj, string>; // "a" | undefined
const x: StringPropertyKeys = undefined; // no error

type CorrectStringPropertyKeys = Exclude<KeysByType<Obj, string>, undefined>; // "a"
const y: CorrectStringPropertyKeys = undefined; // error

Thanks for pointing this out! I've added a PR (#108) that should fix this issue. It also alerted me to another issue with KeysByType that I wasn't able to fix yet:
interface Obj { a: string; b?: number; }

// should be `b`, but is `never`
type got = KeysByType<Obj, undefined>;

:tada: This issue has been resolved in version 3.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


There should be a whitespace token which is ignored except within \text{...}

It turns out that any whitespace (e.g., 7 spaces, 2 tabs, etc.) in \text{...} is just rendered as a single whitespace. This actually makes it a lot easier.

See also #62 which would be solved if the argument for \text would be constructed on the Node level.


Ho ho ho

Merry Christmas
Now all new code must comply with default rust format.
i.e.:
rustup component add rustfmt-preview
cargo fmt
cargo fmt -- --check

Obviously it is the day we push new coding style the CI is having a problem with nightly....

probably best to avoid these code formatters, as they hide code smell.

Understood, it doesn't bother me it's just I argue that code formatters put santa's face back on, hiding the octopus faced monster. So when sane people come along they won't get alerted to potentially bad code which sticks out like a sore thumb exhibited by dodgy indentation or weird case statement formatting etc. I'm trying to say it's good for sherlock holmes to investigate a pristine crime scene where the evidence hasn't been formatted away. :-)


Lost progress when stopping the docker container

I ran a simple "docker stop valheim" and "docker start valheim" and it stopped the container within maybe 5 seconds which should indicate it was done cleanly, but when it was started again the server had rolled back 30 minutes or so. I'm sure you need more information to debug this so let me know what that would be. This was a pretty serious bug that made me a bit scared.
Edit: It's possible this problem has to do with the actual server software not anything to do with the docker container. It seems it commits changes to the world to disk very infrequently, and when you shut down the server software it doesnt force a save.

I actually think you are supposed to exec odin stop inside the container before stopping the container itself.

I haven't tried that, but I guess it would make sense! If that is the solution then I guess the docker container should run that command automatically when shutting down? Because it's easy to forget if you need to reboot the server or whatever else it may be.

Normally it should do an graceful exit, aka ctrl + c, to the running stuff. But there was also a patch for the server in 0.143.1 of the server files, maybe that helps.

If you must stop the server for now, I suggest you use htop to send SIGINT to the server process while I work on a fix

Fix for this is live on :latest and working on my production servers. Would someone mind giving it a whirl to confirm?

Suhhhweeeeeeet! Confirmed on my kubernetes cluster. Closing this issue, thank you @spion06 for the help <3

I just had this issue when I ran docker-compose down. Progress seems to be saved reliably when I trigger a save via console commands.


pull request for e2e test at 11/06/2016 23:56:08

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


MouseWheelZoom

With openlayers 6.2.0 mouseWheelZoom and dragPan are no longer able.
I have  interactions: defaultInteractions({dragPan: true, mouseWheelZoom: true}),
in my map, but no chance to drag or zoom

You need to update (or start using) css/ol.css to the one of v6.2.0.

Many thanks!!


Wheel for configuration is not opening when clicked

Just installed everything, when trying to config nothings pops up :/ . Other plugins working fine

Just installed everything, when trying to config nothings pops up :/ . Other plugins working fine

Hello friend. Unfortunately this is a known issue. I'm working on a fix for this right now. I'll close this issue as it is the same as #23


try use project classpath for enrichers when enabled...  for https://…

…github.com/fabric8io/fabric8-maven-plugin/issues/269
interested in a review from @rhuss and @jstrachan
still WIP

Still need to update docs. Should probably add this functionality for the Generators too, yah?

k.. added the code for generators. will do the docs in a different PR; will try fill in the section about developing enrichers and the enricher API (5.2)
@rhuss thoughts?

bump @rhuss

@christian-posta  ;-) will have a look early tomorrow.

@christian-posta Thanks a lot !
I wonder a bit though, how this interferes with building the real application as the custom plugin configurations are then also visible on the application classpath.
Maybe its better to add the enricher / generator dependencies directly to the plugin configuration as described in http://maven.apache.org/guides/mini/guide-maven-classloading.html ? (tbh, I didn't know that its possible to add dependencies to a plugin config). I think, that's the most elegant solution (if it works).

E.g.
 <plugin>
       <groupId>io.fabric8</groupId>
       <artifactId>fabric8-maven-plugin</artifactId>
       <version>3.1-SNAPSHOT</version>
       <dependencies>
            <dependency>
                <groupId>myorg</groupId>
                <artifactId>my-custom-enricher</artifactId>
                <version>1.7.1</version>
            </dependency>
       </dependencies>
       ...
</plugin>

Agree. We shouldn't have build dependencies on project classpath - they can be specified as plugin dependencies.

@christian-posta is the solution to add the dependency to the plugin configuration acceptable for you ? If so, I would close this PR.

@rhuss @jimmidyson no, not really.
What i'd like is to be able to include 3rd party dependencies for my project that implicitly know how to add kubernetes-specipic metadata if needed via enrichers and have the f-m-p automatically pick that up. For example, I want to include "spring-cloud-kubernetes-hystrix" for my project to provide hysteria functionality. But as part of that, a k8s service needs to be labeled with "hsytrix.enabled=true" for it to work properly and be picked up by the turbine dashboard. I already include the spring-cloud-kubernetes-hystrix artifact, i'd rather the f-m-p automatically adapt based on what enrichers it finds? Obviously I could add the labels manually myself, or explicitly add the dependency to the build plugin class path, but it just feels weird and is brittle; i originally brought the spring-cloud-kuberentes-hystrix dependency as a compile-time dependency for my project. Would be nice if f-m-p scanned that class path too.

@christian-posta I see your point, we should support both. So having a config option to switch this on and off makes sense then. A developer then can the declare that he want his code to be inspected, too.
The question is whether we want to enable by default or not. Probably false is good default value in order to avoid unexpected surprises.
Just thought also whether it makes sense to only inspected the classes of the current project, and not its dependencies by adding only target/classes to the classloader ?

@christian-posta ok, just re-read your use case, for which it makes sense to add the whole dependency.

@christian-posta if you don't mind I would merge the PR now and then fix my comments (if there are no objections from your side).

rebased this and merged with a different PR


[animations] Code sample improvements

Created off of https://github.com/flutter/flutter/issues/51300#issuecomment-590468967

Add code samples to animations that make sense. For example, using the PageTransitionsBuilders and describing how to handle hit testing for FadeScaleTransition.
Link Material motion system article in the API documentation.

Any updates on this @shihaohong 😄 ?

I have not had the chance to get to this yet, so I'll un-assign myself so that it's not misleading


[Fix] Tests

Ticket
https://openscience.atlassian.net/browse/EOSF-
Purpose

Changes

Side effects

Looks good 👍


Skip tests instead of passing them when we can't connect to the API.

@abellotti @chessbyte Please review.  This one is easier to review with https://github.com/ManageIQ/manageiq/pull/6712/files?w=1

The changes here are good :+1:
These were written before the full spec/requests/api that we have now with the REST API, so we could eliminate these here (small subset anyways) and morph into spec testing the CLI itself maybe (or OO/object stuff) once we get there.  Thanks.


Initialize Project

Initialize project with proper architecture &  package name

I am thinking of using Android Starter for the initial boilerplate setup.


iPadOS 14: Mattermost notification badge shows non-existent unread messages

Summary
The Mattermost app reports unread messages in the app overview (notification badge) even though there are none.
Environment Information

Device Name: iPad
OS Version: iPadOS 14.4.2
Mattermost App Version: 1.42.1
Mattermost Server Version: 5.31.4

Steps to reproduce
It's hard to reproduce. It happens one some devices and on some it doesn't. Event though they use the same device model, OS version and app version.
Observed behavior (that appears unintentional)
All messages are marked as read inside the app, but the app overview still shows unread messages:

Will add an additional screen recording as soon as the user confirms that we can use it in regards of privacy reasons.

@adf-patrickha Does re-installing the app help? Or logging out and back in?
Does this also repro on the latest v1.43 app version?

@adf-patrickha Does re-installing the app help? Or logging out and back in?

A reinstallation and logging out/in did both not solve the issue.

Does this also repro on the latest v1.43 app version?

We only deploy version 1.42 yet (MDM). I don't know if the newer version will be deployed in the near future. Is something issue-related mentioned in the changelog of v1.43?

@josephbaylon Does this repro for you?

@amyblais @adf-patrickha I'm unable to reproduce the issue on v1.43. Maybe try upgrading to 1.43 and see if you still encounter the issue. Thanks

Screen recording by the user (you can ignore the audio):
https://user-images.githubusercontent.com/84573341/119513126-3c45de80-bd74-11eb-8aa1-09cf1ecb82c6.mp4
AFAIK the user does nothing wrong and the issue is iPadOS or app related.

@enahum Would you have any additional tips for this?

Video is not playing for me.

Video is not playing for me.

@enahum This is a GitHub issue. Just get the video via wget or copy the URL to VLC for example.

The video does not show, but is there a notification present in the iPad notification center, that could be why the badge does not clear.
Even thought the above is true, this is still a bug.
cc: @amyblais

Opened a ticket: https://mattermost.atlassian.net/browse/MM-36046.

Closing, this was fixed in v1.44 release,


module 'twirl' has no attribute 'find_peaks'

Bug Report
I am getting this error

module 'twirl' has no attribute 'find_peaks'

that is not present with an earlier version of the code.
How To Reproduce
pip install twirl
python
import twirl
twirl.[TAB]
Code sample
Environment

OS: macOS

Screenshots
Expected behavior
Additional context

Hi @mrobberto, thanks for reporting this issue.
As @michealroberts explains, the function has been dropped from the last version. The main reason was that I found the function simple enough to remove it it from twirl and omit the photutils dependency. Despite the <v1, I reckon the versioning wasn't perfectly rigorous.
Looking back at the readme (that contains the only reference to this function), I think it is still nice to have such a function available. I propose to make a 0.3.3 patch that will include the following function:
# not tested - need docs
# -----------------------

from astropy.stats import sigma_clipped_stats
from photutils.segmentation import SourceFinder, SourceCatalog

def find_peaks(data, sigma=6):
  mean, median, std = sigma_clipped_stats(data, sigma=3.0)
  segmented = SourceFinder(5)(data - median, sigma * std)
  cat = SourceCatalog(data, segmented)
  return (
      cat.to_table()
      .to_pandas()
      .sort_values("area", ascending=False)[["xcentroid", "ycentroid"]]
      .values
  )

and bring the photutils dependency back. Since it fixes a bug and brings back an omitted function, I think a patch is appropriate.
What do you think?

hi Lionel,
thank you for your prompt feedback! I think reinstating the function would be very nice to keep code already developed, and in my experience find_peaks works pretty nicely. Note that is used in the notebooks/demos. This is typically what people like me uses to get quickly out of the woods...
Thank you again
Massimo

Thanks for the feedback. find_peaks is back in 0.3.3!
You mentioned notebooks/demos which seems to reference an outdated version of the repository. Is this something you found on an old clone or something that is still online?
The documentation should be hosted on twirl.readthedocs.io so I prefer to check we don't have alternative docs out there.


Should cargo-careful set a --cfg flag?

Should cargo-careful set a --cfg careful in rustflags? IMO yes, so that extra checking can be enabled. Here are some use cases:

When building vendored C code in FFI crates, it's hard[^1] to know if you should turn on assertions, so I usually don't. If the library has extra levels of stronger/slower assertions, I never turn those on (and generally consider it bad for FFI crates to do so without opt-in from the user).
However, if I can tell a user is using cargo-careful, I can assume they are willing to pay for extra checking, and so I should turn on all the assertions, even if they're slow and/or verify things which would be redundant with safety provided by e.g. Rust's typesystem or something.

Even for pure rust, sometimes I have checks only under #[cfg(test)] rather than debug_assertions. This is usually because they're too costly to consider making a user pay for it for their own debugging (perhaps they increase the time complexity of an algorithm, or whatever). Depending on the case (for example, if safety depends on the correctness I very likely would), I may enable this under cargo-careful as well.

I can think of some other use cases as well, of similar reasoning.
[^1]: Sadly, there's no way to reliably detect if the user has debug_assertions enabled in a build script. Ideally cargo would pass CARGO_CFG_DEBUG_ASSERTIONS to build scripts but because of the way it discovers cfgs, it cannot, and IIUC this is unlikely to change. So the closest you get is checking PROFILE for being "debug" or not, which is... not quite right. (Note that the DEBUG env var is for debuginfo, not assertions).

Yeah, similar to how Miri has cfg(miri), something like that would probably also make sense here.


fixed queued issues

Resolves two issues—

A queued job would show a crazy high "run time" since it was calculating the modification_time - exec_start_time. Since it was queued, it has no start time. Now only calculates run time if it has exec_start_time.
The results were changed - previously a job which was queued would have an undefined exec_start_time, now it's null. Handles both cases.

And patched the second issue - the modification_time from the service is the same as exec_start_time for running jobs, so instead it calculates runtime in that case based off of the current time.


Fix ec2 instance creation error with default create template

Back to the default ec2_instance filter handling

Fix #61

Due to the lack of tests this needs to get a review from another ec2 contributor as we don't want to break it.


New Task Type: File Upload

Create a new type of task called "File Upload". When a user is assigned to this task, they must upload a file. Uploading the file marks the assignment as completed.  It is then up to an instructor or similar person to look at the file and make any necessary judgments.

What is the status of progress on this issue?

I think this one is finished... take a look and let me know if it needs any additional updates.


FEAT-#7102: Deprecate enable_api_only mode in modin logging

What do these changes do?

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[ ] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] signed commit with git commit -s
[ ] Resolves #7102?
[ ] tests added and passing
[ ] module layout described at docs/development/architecture.rst is up-to-date

@arunjose696, please rebase on current master to fix CI.

@arunjose696, please rebase on current master to fix CI.

I have rebased on master, and have updated code just to add a deprecation message instead of removing the option.


this is just a question

Dear Purveyors of Backbone:
Just a question for y'all. Why don't Backbone Views have the same defaults/attributes/options relationships that Backbone Models have? And, after checking the source, Collections and Routers don't either, why don't all Backbone components follow the same pattern? I am aware that the functionality of automatically assigning this.options was taken out of a newer version of Backbone, but the question I am asking is about a decision that was made long before that one.
Just curious, thanks

This type of question is better suited to one of the other channels (try the mailing list or the gitter board).
The short answer is because they don't need to. Models are supposed to be where you care about stateful attributes that don't live on the object itself. In most cases just setting a property on your instance should be good enough.
That said, if you really need this in your app, I've written a plugin that allows you to borrow Backbone.Model's getter and setter functions for any object (including the rest of Backbone's classes). Check it out and see if that works for you.

thanks will check it out


Update tests?

@rth : test_basis_set.py does not really do anything since the relevant basis sets are no longer included. Should we update the tests so that they are actually a meaningful test of BASEX?
Two tests we could use:

Include the transformed image with the pyBASEX and compare the user-generated image with the image that we generated.

Compare the BASEX transform with the analytical inverse abel of a gaussian (within the scaling factor at this point).

I agree that  updating tests would be a good idea, including both tests proposed above. I will add the second one. As to the first one, could you look into it (I'm not sure which user-generated image you have in mind) ? The only thing, I suppose, would be to take a low resolution test image, so  a) it does not take too much space in the repo b) tests run sufficiently fast.
As to testing the basis set generation, I would still keep it, as this allows to test this functionality independently of the rest (particularly checking compatibility of different python versions etc).  Are you sure about "the relevant basis sets are no longer included. " ? I still see basis sets under BASEX/data/ascii/.  Do we need those? As far as I am concerned I would just remove them and,

let the basis be generated the first time the user runs the calculation (this way it is resolution independent).
I can also add a small (e.g. 10x10)  sample basis file under BASEX/tests/data for unit tests

What do you think?

Oh, I didn't see that we still had those basis sets there. I believe that those basis sets are identical, so it would make sense to get rid of one set. And I suppose that the users are not going to care if this implementation of BASEX matches some old matlab version. If anything, they will care if it matches the C implementation of BASEX. That version only runs on Windows so I can't do it right now, but perhaps I should prepare a sample image and transform it using the Basex.exe and we can use this for one of our tests, since it is considered to be the gold standard. (Also, I'm curious if they worked out the issue with the scaling factor.)
Also, I like your idea of saving a small 'reference' basis set in the tests folder for comparison purposes.
I think that we should include a basis basis set or two with the program. If someone is on an older computer, the generation can take a while, and I want to give the impression that this implementation is fast (it is!). So, perhaps we should include a 500x500 or 1000x1000 basis set with the example files.

So just to sum up the previous conversation and commits:

Was added: unit tests for BASEX with a symmetric step
Addressed in a separate issue #19 : adding unit tests for a gaussian function (this therefore can be ignored here)
remains to do to close this issue:
" Include the transformed image with the pyBASEX and compare the user-generated image with the image that we generated. "

I think that the tests that we have should be sufficient to ensure that the code is doing the right thing. I'm going to close this, but you can re-open if you think the image comparison is really important.


Skipped listener due to function not having a matching signature.

I'm emitting an event in c++ +with:
FGESEmitContext GEContext;
GEContext.Event = TEXT("TurnBegin");
GEContext.WorldContext = this;
FGESHandler::DefaultHandler()->EmitEvent(GEContext, Actor);

Actor is a UObject* (AActor*).
Binding an event with UObject as input to TurnBegin in blueprint with the GESBindEvent node.
I get the warning "Skipped listener due to function not having a matching NumericProperty signature" and the event doesn't trigger.
When I change the input from UObject to integer the event triggers and the input is a random integer.

What does the bound receiver event look like?

Attaching screenshots.

In FGESHandler::EmitEvent(const FGESEmitContext& EmitData, UObject* ParamData)
When checking for valid params:
if (FunctionHasValidParams(Listener.Function, FNumericProperty::StaticClass(), PropData, Listener))
{
Listener.ReceiverWCO->ProcessEvent(Listener.Function, (void*)&ParamWrapper);// PropData.PropertyPtr);
}
I think FNumericProperty::StaticClass() should instead be FObjectProperty::StaticClass()? Seems to work as expected with this change.

Yep, looks like a copy paste error, good catch. Make a pull request with change and I'll merge it

Seems it's already correct in the master. Now I'm confused how I got the old version : ).

Hah it did seem familiar, likely an older engine plugin release. Not sure if latest release had the patch or if I fixed it post.


"Submit all parts" not working as expected with coding extension

If a student puts their code in to each part, doesn't submit individually, but then clicks "Submit all parts", only the final question is marked correctly, the rest are marked incorrectly (even though they are correct). This is with questions using the programming extension. Tested on this question.

I think this might only be a problem with R: the blocks of code from each part are interleaved, so when you do .Last.value to get the student's result, it always gets the result from the last part.
I'll look at fixing the WebRRunner tomorrow to avoid this.


Convert windows path in lb_realpath()

Convert windows path like C:\Users to /cygdrive/c/Users in lb_realpath()

Done, need to add unit tests


Update profile pic if changed from anywhere

Fixes MA-2201
Previously if the profile pic was updated from the web, the changes didn't had their affect on the drawer that was displayed on MyCourses screen.
This PR fixes the issue by sending a broadcast whenever we load a user's profile pic from any screen.
@1zaman @BenjiLee plz review

2 files (not in diff) in ...rg/edx/mobile/module were modified. more

Misses -9
Hits +9

@@             master       #704   diff @@
==========================================
  Files           477        477
  Lines         20909      20914     +5
  Methods           0          0
  Messages          0          0
  Branches       2942       2943     +1
==========================================
+ Hits           6220       6230    +10
+ Misses        14689      14684     -5
  Partials          0          0

Review [#704][cc-pull] on Codecov

Powered by Codecov. Last updated by [7938aaf...bebc225][cc-compare]
[cc-base-branch]: https://codecov.io/gh/edx/edx-app-android/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/edx/edx-app-android/compare/7938aafd5115edf2cdceaff624a95e4ea96dec41...bebc225f4143a6de04be863aed3c3d4050ce9573
[cc-pull]: https://codecov.io/gh/edx/edx-app-android/pull/704?src=pr

@mdinino Please review

👍  Everything looks good to me

need another review on this guys @aleffert @1zaman @BenjiLee

LGTM 👍

@aleffert another pass ?

Change looks good. Seems like something we should be adding a test for?

Hmm ... not sure what kind of test should we write and what should be
tested xactly ?
On May 18, 2016 8:39 PM, "Akiva Leffert"<EMAIL_ADDRESS>wrote:

Change looks good. Seems like something we should be adding a test for?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-app-android/pull/704#issuecomment-220066968

@miankhalid Well, what does the bug say? Profile changes cause pic to update. Change the profile in one place, make sure the other place attempts to load the pic.

@aleffert I've added the test for this PR. @1zaman made the changes u mentioned.
Ready for another pass.

:+1:


Add default URL to the Client class (http://localhost:8080)

This does not seem like a good idea anymore. This could lead to user errors.


[stdlib] String initializers

Reming the unnecessary initializer form the StringProtocol
Moving things around to make String("") return a non-optional String by default, while keeping conformance toLosslessStringConvertible with it's failing initializer from String.

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - d5aef5224d73b1570d24f601812ef80684cacf0c
Test requested by - @moiseev

@swift-ci Please test macOS platform


 fails

Because of the space before the last >

I'm on this

That was fast!

submitted in #2021 🙃


scheduleBuildFor exception in Pesto Favorites

Run Gallery, select Pesto, and select the Favorites option in the menu
Results in this exception:
07-21 16:05:33.426 26529 26559 I flutter : ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
07-21 16:05:33.449 26529 26559 I flutter : The following assertion was thrown building Theme(ThemeData(Brightness.light Color(0xff009688)
07-21 16:05:33.449 26529 26559 I flutter : etc...)):
07-21 16:05:33.469 26529 26559 I flutter : scheduleBuildFor() called for a widget for which a build was already scheduled.

Wow we need to make that error message clearer.

(just leave the bug open, I'll get to it eventually if nobody else does)


adding file upload support for create_pin

This change is backwards compatible, only adds functionality to upload a file directly from the server when creating a new pin.

Hi @kukosk thanks for the contribution. I apologize for seeing this so late, I didn't check my Github notifications for a while.
The code changes look good. I'll go ahead and merge it now.


TYPO in C++ client producer method for processing failure case

Describe the bug
Inside file pulsar/pulsar-client-cpp/lib/ProducerImpl.cc, the method:
void ProducerImpl::failPendingMessages(Result result)
is designed for processing all the failure cases on publishing messages. As the exact result is given by parameter, so every registered message callback should be invoked with exactly the same result. But actually, In the final line of this method, the given code like this:
   BatchMessageContainer::batchMessageCallBack(ResultTimeout, messageContainerListPtr, NULL);
Definitely, this a typo, as the method should report the callback with the GIVEN result stat, but not a CERTAIN result stat.

I may submit my PR later if no any doubt.

This has been fixed by 4873


BaseDiagrams for form and force diagram initial point

The graph representing the base diagram is under implementation in PR #54.
Maybe it also makes sense to store the initial version of the force diagram... and display it if desirable in the display settings.

@ricardoavelino why would you need to store/show the initial force diagram?

Mostly for 2 reasons:
1 - Allow comparison of form and force from the end of the process to the start, thinking that the user may move vertices from form/force and can compare it with the original input
2 - Allow a reset button that start everything back, I think this could help students to come back after some modifications.
3 - To keep track of the input of the user, sometimes I imagine that an user unfamiliar with Rhino may have troubles since the original input lines get hidden
...
For both points we could also workout a different solution but I think storing this information on the scene would not be a big problem.


Update _settings.scss

Thanks, @aqeelfikree! Merged as https://github.com/thoughtbot/neat/commit/5077b4b24fa24c4ce2cb05d841823a8ab9d43c36.


(Team 1) Design a Dictionary class for the DictionaryMatcher

@sandeepreddy602 @inkudo @rajesh9625
We need this class to capture the concept of a dictionary.  Please talk to me to do a discussion.  Add @JavierJia as a reviewer.

To increase the quality of the codebase, it will be good to add necessary high-level comments to the code (in addition to our documentation on wiki).  For your next PR about adding spans to test cases of scan-based keyword search operator, please also take the chance to add high-level comments to some of the test cases and operators.

These changes are part of the pull request #61


[R-package] Introduce R-specific control of lib_lightgbm

I've been working on #1440 / #1909 (as part of  #629 ), and am still struggling with it.  But I think that a  small part of what I've done can be introduced right now, and that it actually might be easier to discuss it as its own thing.
I'm currently working on this NOTE from R CMD CHECK:
Note: information on .o files is not available
File ‘/Users/jlamb/repos/lgb-logging-thing/LightGBM/lightgbm.Rcheck/lightgbm/libs/lib_lightgbm.so’:
  Found ‘___assert_rtn’, possibly from ‘assert’ (C)
  Found ‘___stderrp’, possibly from ‘stderr’ (C)
  Found ‘___stdoutp’, possibly from ‘stdout’ (C)
  Found ‘_printf’, possibly from ‘printf’ (C)
  Found ‘_putchar’, possibly from ‘putchar’ (C)
  Found ‘_vprintf’, possibly from ‘vprintf’ (C)

Compiled code should not call entry points which might terminate R nor
write to stdout/stderr instead of to the console, nor use Fortran I/O
nor system RNGs. The detected symbols are linked into the code but
might come from libraries and not actually be called.

Similar to the way XGBoost solved this, I'd like to introduce a new define that tells the compiler "hey lib_lightgbm is being compiled for use with the R package".
I first tried to do this to introduce Rprintf(), the R equivalent to printf(), in log.h. I've been running into some complications there that will take some more time to address, so for this PR I'd like to focus on one isolated case not related to logging.

Found ‘___assert_rtn’, possibly from ‘assert’ (C)

This comes from src/io/json11.cpp. This PR uses -DLGB_R_BUILD to say "exclude cassert if you're building the R package"...and I can confirm it works! After running the code below:
export CXX=/usr/local/bin/g++-8
export CC=/usr/local/bin/gcc-8
Rscript build_r.R
R CMD CHECK lightgbm_2.3.2.tar.gz --as-cran --no-manual

I get the following output (notice that assert is no longer mentioned!):
Note: information on .o files is not available
File ‘/Users/jlamb/repos/lgb-logging-thing/LightGBM/lightgbm.Rcheck/lightgbm/libs/lib_lightgbm.so’:
  Found ‘___stderrp’, possibly from ‘stderr’ (C)
  Found ‘___stdoutp’, possibly from ‘stdout’ (C)
  Found ‘_printf’, possibly from ‘printf’ (C)
  Found ‘_putchar’, possibly from ‘putchar’ (C)
  Found ‘_vprintf’, possibly from ‘vprintf’ (C)

That command also runs all the R tests, so this should pass CI and doesn't seem to be affecting the R package's functionality.
If this PR is approved and merged, then the next thing I'll work on is log.h, where for example I'll try to make something like this work:
#include <R.h>

static void Write(LogLevel level, const char* level_str, const char *format, va_list val) {
    if (level <= GetLevel()) {  // omit the message with low level
      // write to STDOUT
      #ifndef LGB_R_BUILD
        printf("[LightGBM] [%s] ", level_str);
        vprintf(format, val);
        printf("\n");
      #else
        Rprintf("[LightGBM] [%s] ", level_str);
        Rvprintf(format, val);
        Rprintf("\n");
      #endif
      fflush(stdout);
    }
}

Thanks for your time!

thanks @jameslamb !
BTW, should we add something for pre-compiled dll?

Just want to say that I'm really excited to see we have some progress on #629! Thank you James!

Can't we achieve the same goal via CMake options to not play around with export? I'm asking because afraid that export inside the system call introduce side effects for user's environment, doesn't it? Or it only affects one particular R session?
https://github.com/microsoft/LightGBM/blob/53137e2541691fa8bcae2917eb75b7ddf0ec98c8/R-package/src/install.libs.R#L43-L45

Can't we achieve the same goal via CMake options to not play around with export? I'm asking because afraid that export inside the system call introduce side effects for user's environment, doesn't it? Or it only affects one particular R session?
https://github.com/microsoft/LightGBM/blob/53137e2541691fa8bcae2917eb75b7ddf0ec98c8/R-package/src/install.libs.R#L43-L45

system()  spins off an isolated shell session that doesn't impact the calling environment:

BUT you're right, passing the argument to cmake  directly would be cleaner, and would be portable to Windows. Let me try that!

thanks @jameslamb !
BTW, should we add something for pre-compiled dll?
I mean, the build flag, and related documentation for the pre-compiled dll for R package.

Can you point me to the code where we build the dll / so files that we include with each release? I'd be happy to update that code / documentation  to show how to build a version of the library specifically for R (with this flag).
But I don't think we need to do anything in install.libs.R...by the time you reach that script, you have to already have the pre-compiled dll in hand. Also I'll add a note on #629 to this effect, but I think our first priority should be getting R source installs working in a CRAN-compliant way, and then work back to pre-compiled.

@guolinke

BTW, should we add something for pre-compiled dll?
I mean, the build flag, and related documentation for the pre-compiled dll for R package.

I think we will publish a separate artifacts in our Releases which will be sent to CRAN. But I guess it should be done after closing #629. Or am I misunderstand something and you are speaking about different things?

I mean, sometimes user will build the dll first, then install python /R packages. After this PR, I think python/R will not share the same dll. So we need the build options to build R dll, maybe including msvc project file.

I mean, sometimes user will build the dll first, then install python /R packages. After this PR, I think python/R will not share the same dll. So we need the build options to build R dll, maybe including msvc project file.

yep, makes sense! I agree, from this point we should have a different lib_lightgbm.so / lib_lightgbm.dll based on whether or not you are using the R package.
Another option we could give is an R package .tar.gz that just has  that library in it.
@StrikerRUS to answer your question...yes CRAN allows for precompiled packages, but you cannot publish them yourself. That is done for security reasons, so that CRAN tightly controls what software people can get into your environment via CRAN.
We have to have a working source distribution (one that gets compiled when users download and install it) first, which means yes we have to close #629 first.
From the CRAN policies:

Binary packages are not accepted from maintainers: CRAN will only host binary packages prepared by those responsible for the binary areas. Their packages are made automatically by batch jobs and can take a day or two to appear on the CRAN master site (maybe longer to reach CRAN mirrors).

@jameslamb According to my lgbdl package, the precompiled library should be at the root of the LightGBM folder.
The file is then checked by install.libs.R if use_precompile is TRUE.

@jameslamb According to my lgbdl package, the precompiled library should be at the root of the LightGBM folder.
The file is then checked by install.libs.R if use_precompile is TRUE.

perfect, thanks

I'm going to rebase to master and rebuild just to be sure, then I'll merge this. Thanks for the reviews!


Observatory: better error reporting when connecting remotely

I used Observatory > Connect to a VM and made a connection to localhost:12345 (where no service is running), I don't see any errors in the Observatory UI, but clicking on the connection shows a page with no data (name, address, version are blank and there are no isolates). But if I click again on Observatory > Connect to a VM it lists the connection, and shows it's connected.
If I open the web debugger I see error message on the console:
WebSocket connection to 'ws://localhost:12345/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
Uncaught NetworkRpcException(Canceling request: WebSocket closed due to error)
If I have the DevTools console open while doing this, it drops me into the debugger.
I would expect that when the Observatory UI attempts to make a network connection and it fails, some kind of error dialog pops up immediately with a message about the connection failure, and it shouldn't be listed as "connected" in the UI.

https://codereview.chromium.org/2340973002/

Thanks!


Issue with installation of EasyMail on Docker

There is an issue with the installation of EasyMail on Docker. Check this:
https://travis-ci.org/runeasymail/easymail/jobs/188934580

https://github.com/runeasymail/easymail/commit/86189d5b3baf91ab097d5556b524173e64798e00


Increase compatibility for  building of Windows images

What this PR does / why we need it:
Currently in a beta state, we are experimenting with building
Windows images so that Sonobuoy can be run on Windows nodes.
This change stops short of adding the Windows build to CI
while we figure out some of the last technical problems there.
Changes include:

Utilizing circleci workspaces to load/store docker images across stages
Adds a Windows sample plugin
Updates the makefile to support building windows images and cleans up some of the makefile structure to build the binaries as appropriate
Updates the makefile to build/push images for windows only if PUSH_WINDOWS=true
Updates the way the manifest-tool is invoked to use a template instead of the command line options (which provides more flexibility)
Adds a flag aggregator-node-selector to gen/run commands in order to help direct where to place the aggregator in mixed-node clusters
Modify which command is used to grab the tarball of results from the aggregator depending on whether or not it is a Windows system or not (therefore if bash or powershell should be used)

Which issue(s) this PR fixes

Related #732

Special notes for your reviewer:
The hardest parts of this are:

gettings a Windows cluster
getting a Windows docker context

Once those are handled the rest isn't so bad.
Release note:
Several changes related to supporting running on a Windows machine including building Windows compatible images.

Need to manually check this again on windows and probably update the manual steps in the release.md; however I think otherwise the code is good. Had manually run it all but that was a few weeks ago. Will post back results when done.

Based on @zubron 's last comment I'm going to merge once CI goes green. I fixed up some problems I found in the makefile, added 2 more tests (and removed one), and made some doc tweaks.


[Event Request] Table 27 Item - OnValidate "Producation BOM No."  - OnValidateProductionBOMNoOnAfterProcessStatusCertified

Please add the following Event/-s OnValidateProductionBOMNoOnAfterProcessStatusCertified to OnValidate "Producation BOM No." in Table 27 Item
[Event Request] Table 27 Item - OnValidate "Producation BOM No."
trigger OnValidate()
var
    MfgSetup: Record "Manufacturing Setup";
    ProdBOMHeader: Record "Production BOM Header";
    ItemUnitOfMeasure: Record "Item Unit of Measure";
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeValidateProductionBOMNo(Rec, xRec, IsHandled);
    If not IsHandled then begin
        if "Production BOM No." <> '' then
            TestField(Type, Type::Inventory);

        PlanningAssignment.BomReplace(Rec, xRec."Production BOM No.");

        if "Production BOM No." <> xRec."Production BOM No." then
            ItemCostMgt.UpdateUnitCost(Rec, '', '', 0, 0, false, false, true, FieldNo("Production BOM No."));

        if ("Production BOM No." <> '') and ("Production BOM No." <> xRec."Production BOM No.") then begin
            ProdBOMHeader.Get("Production BOM No.");
            ItemUnitOfMeasure.Get("No.", ProdBOMHeader."Unit of Measure Code");
            if ProdBOMHeader.Status = ProdBOMHeader.Status::Certified then begin
                MfgSetup.Get();
                if MfgSetup."Dynamic Low-Level Code" then begin
                    CODEUNIT.Run(CODEUNIT::"Calculate Low-Level Code", Rec);
                    OnValidateProductionBOMNoOnAfterCodeunitRun(ProdBOMHeader, Rec);
                end;

                OnValidateProductionBOMNoOnAfterProcessStatusCertified(ProdBOMHeader, Rec); // <-- NEW EVENT

            end;
        end;
    end;
end;

[IntegrationEvent(false,false)]
local procedure OnValidateProductionBOMNoOnAfterProcessStatusCertified(ProdBOMHeader: Record "Production BOM Header"; var Item: Record Item)
begin
end;

Hi, can't you use event OnValidateProductionBOMNoOnAfterCodeunitRun(ProdBOMHeader, Rec); for your scenario?

You did set the publisher we requested inside the condition 'if MfgSetup."Dynamic Low-Level Code"'; we probably misnamed the publisher (...OnAfterCodeunitRun); we need the publisher to be called unconditionally respectively only inside the condition 'Status::Certified".

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11255.