Response to naming email

Very simple feature.  Just makes it so users who have proposed names but not bothered to comment will also get "comment response" emails when someone comments on the observation.  (I personally will find this invaluable!!)

Oops, but need to adjust a few tests apparently, one moment...

Coverage increased (+0.03%) to 86.284% when pulling c985f6a01b733bc7315953b10d2208a189d861ed on response-to-naming-email into 3d636cd23adf0d87b3f68517c549bbea49b5609c on master.

Coverage increased (+0.03%) to 86.284% when pulling 0c7937cd1c35a490c8ba51b4251a67f5390e1814 on response-to-naming-email into 3d636cd23adf0d87b3f68517c549bbea49b5609c on master.

rubocop report 51 offenses in the files that were touched:
% git diff --name-only master | xargs rubocop
...
3 files inspected, 51 offenses detected
At lot of those would be really easy to clean up (lines too long, indents etc.).  The hard ones include the "Assignment Branch Condition size" and "Class has too many lines" offenses.  It would be great if the easy ones could get cleaned up and we can worry about the hard ones later.

BTW, I merged with master and pushed those changes so I could see more clearly what the new stuff is.

Hmm, got a failing test:
 FAIL["test_comment_notification", CommentTest,<PHONE_NUMBER>2600647]
 test_comment_notification#CommentTest (156.52s)
        Expected: 89
          Actual: 90
        test/models/comment_test.rb:79:in `test_comment_notification'

Coverage increased (+0.003%) to 86.286% when pulling 8bbaf4098df8ac385fad905b6b110d7b250658a6 on response-to-naming-email into 96abec03234b05b142a0b3a34f1c6a0cdbdada45 on master.

This has to be wrong, I couldn't possibly have caused 51 new offences, I
only added one method that's 3 lines long!  And I should point out that
app/models/comment.rb is one of the only files that actually passes without
any warnings.  (After several hours of work the other day.)
[Yes, just checked, there are no new rubocop warnings in either comment.rb
or comment/callbacks.rb -- the only files in the code I might have touched
-- except for a request for comments which already exist in the main
Comment class which I don't know how to silence because it's clearly a
bogus warning, and it's complaining about a blank line I just added for
readability, but which I'd be happy to remove, didn't occur to me that
might be a problem.]
Your diff method didn't work for me at all.  If you add a line of comments
at the top of the file it claims all the offences in that file are new even
if you didn't touch any of the rest of the file.
I am happy to ensure that my new code follows rubocops dubious protocols
but I can't be responsible for cleaning up all the warnings in any file I
touch -- I would never get anything done and there would be a huge
activation energy to making even the tiniest contribution to the site.
-Jason
On Sat, Dec 24, 2016 at 9:22 AM, Nathan Wilson<EMAIL_ADDRESS>wrote:

rubocop report 51 offenses in the files that were touched:
% git diff --name-only master | xargs rubocop
...
3 files inspected, 51 offenses detected
At lot of those would be really easy to clean up (lines too long, indents
etc.). The hard ones include the "Assignment Branch Condition size" and
"Class has too many lines" offenses. It would be great if the easy ones
could get cleaned up and we can worry about the hard ones later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/251#issuecomment-269092945,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tWaddkxD2gTDLlPLmjlQ56dzbX-7ks5rLVTngaJpZM4LVBJN
.

Something must be off.  Both my tests and the automated tests (coveralls?
travis? whatever that service is called) passed fine.
On Sat, Dec 24, 2016 at 9:30 AM, Nathan Wilson<EMAIL_ADDRESS>wrote:

Hmm, got a failing test:
FAIL["test_comment_notification", CommentTest,<PHONE_NUMBER>2600647]
test_comment_notification#CommentTest (156.52s)
Expected: 89
Actual: 90
test/models/comment_test.rb:79:in `test_comment_notification'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/251#issuecomment-269093209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tVeApXBxnWWQs-wKhyaOCH0thwiFks5rLVa8gaJpZM4LVBJN
.

I'm not particularly worried about the rubocop offenses.  I was just hoping to leave the campsite a bit cleaner.  I'll dig into the test failure.  It's probably my fault.

Looks like the test failure is order dependent.  If I run the file by itself I get no errors.  However, if I use either the seed 36259 or 38763 I get the failure.  For example,
$ rake TESTOPTS="--seed=38763"
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
Started with run options --seed=38763

 FAIL["test_comment_notification", CommentTest,<PHONE_NUMBER>9001326]
 test_comment_notification#CommentTest (145.36s)
        Expected: 29
          Actual: 30
        test/models/comment_test.rb:79:in `test_comment_notification'

  1316/1316: [===============================================================] 100% Time: 00:02:40, Time: 00:02:40

Finished in 160.22179s
1316 tests, 17896 assertions, 1 failures, 0 errors, 0 skips
[Coveralls] Outside the CI environment, not sending data.

I can't dig into this tonight and tomorrow may be tricky.  After that I'll dig into it if you haven't already found the problem.

Thanks for that, hopefully I can reproduce it with your seeds.  It's mine,
I'll take care of it.
On Sat, Dec 24, 2016 at 6:32 PM, Nathan Wilson<EMAIL_ADDRESS>wrote:

Looks like the test failure is order dependent. If I run the file by
itself I get no errors. However, if I use either the seed 36259 or 38763 I
get the failure. For example,
$ rake TESTOPTS="--seed=38763"
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
Started with run options --seed=38763
FAIL["test_comment_notification", CommentTest,<PHONE_NUMBER>9001326]
test_comment_notification#CommentTest (145.36s)
Expected: 29
Actual: 30
test/models/comment_test.rb:79:in `test_comment_notification'
1316/1316: [===============================================================] 100% Time: 00:02:40, Time: 00:02:40
Finished in 160.22179s
1316 tests, 17896 assertions, 1 failures, 0 errors, 0 skips
[Coveralls] Outside the CI environment, not sending data.
I can't dig into this tonight and tomorrow may be tricky. After that I'll
dig into it if you haven't already found the problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/251#issuecomment-269107735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tUnct8d2iHgSYL827juEXi7xG2pGks5rLdWjgaJpZM4LVBJN
.

Coverage remained the same at 0.0% when pulling 84fba63db1d72e8d0fe66cb29400365f182a1525 on response-to-naming-email into c030ce5eeedfc0198a55de4e2b2f0c77dcc5fcc3 on master.


[Bug][Manager] OOM when submitting hive sink sort job

What happened
Choose file source and hive sink, manager OOM when submit sort job:

What you expected to happen
no oom
How to reproduce
Choose file source and hive sink when creating group.
Environment
No response
InLong version
master
InLong Component
InLong Manager
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This error disappears after update to the newest version.


Aws s3

Why?

Whoops sorry, was merging in my fork.
But if you are interested, can probably pull it as a branch as just like how your repo solves the git lfs bandwidth problem, the s3 cache solves github's obscure 10GB cache limit problem by storing all the cache (and the lfs cache from your addon) to aws s3


Bootstrap Waypoint Completion

Challenge http://www.freecodecamp.com/challenges/waypoint-create-a-bootstrap-headline has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
Despite having entered an incorrect solution during the Waypoint lesson I am still able to click the "Go to my next challenge button" which then takes me to the next challenge and shows the correct code for the previous lesson. This was repeatable for as many Waypoints as I tried.

@smarshy thanks for posting this issue!
Try to Refresh Your Browser Cache and Clear Your Browser's Local Storage.
Please review the Guidelines for Contributing, thank you!.

Closing as stale, please reopen if this is still an issue for you.


Made https redirecting

Redirected the traffic to the HTTPS version of the website.

@IvanObreshkov you may merge now


构建失败, 看不出什么问题啊!

bogon:admin silver$ npm start

@ start /Users/silver/program/grandhope/admin
dora --plugins "proxy,webpack,webpack-hmr"

      proxy: load rule from proxy.config.js

(node:43886) DeprecationWarning: 'GLOBAL' is deprecated, use 'global'
proxy: listened on 8989
📦  2/3 build modulesYou are using prebuilt antd,
please use https://www.npmjs.com/package/babel-plugin-import to reduce app bundle size.
📦  15/16 build modules
webpack: bundle build is now finished.
Hash: 7c803b01a360be7eb727
Version: webpack 1.12.15
Time: 1469ms
Asset     Size  Chunks             Chunk Names
common.js  24.3 kB       0  [emitted]  common
index.js  84.2 kB    1, 0  [emitted]  index
chunk    {0} common.js (common) 0 bytes [rendered]
chunk    {1} index.js (index) 78.4 kB {0} [rendered]
[0] multi index 40 bytes {1} [built] [1 error]
[1]<EMAIL_ADDRESS>49 kB {1} [built]
[2]<EMAIL_ADDRESS>4.26 kB {1} [built]
[3]<EMAIL_ADDRESS>2.4 kB {1} [built]
[4]<EMAIL_ADDRESS>2.09 kB {1} [built]
[5]<EMAIL_ADDRESS>127 bytes {1} [built]
[6] (webpack)/buildin/module.js 251 bytes {1} [built]
[7]<EMAIL_ADDRESS>231 bytes {1} [built]
[8]<EMAIL_ADDRESS>6.57 kB {1} [built]
[9]<EMAIL_ADDRESS>2.98 kB {1} [built]
[10]<EMAIL_ADDRESS>135 bytes {1} [built]
[11]<EMAIL_ADDRESS>1.74 kB {1} [built]
[12] ./~/.2.13.2@webpack-hot-middleware/client.js?path=http%3A%2F%2F<IP_ADDRESS>%3A8000%2F__webpack_hmr&reload=true 4.6 kB {1} [built]
[13]<EMAIL_ADDRESS>3.88 kB {1} [built]
[14]<EMAIL_ADDRESS>161 bytes {1} [built]
ERROR in ./src/index.js
Module build failed: TypeError: Plugin 3 specified in "base" was expected to return a function but returned "undefined"
at Function.normalisePlugin (/Users/silver/program/grandhope/admin/node_modules/.6.20.0@babel-core/lib/transformation/file/options/option-manager.js:144:15)
at /Users/silver/program/grandhope/admin/node_modules/.6.20.0@babel-core/lib/transformation/file/options/option-manager.js:180:30
at Array.map (native)
at Function.normalisePlugins (/Users/silver/program/grandhope/admin/node_modules/.6.20.0@babel-core/lib/transformation/file/options/option-manager.js:154:20)
at OptionManager.mergeOptions (/Users/silver/program/grandhope/admin/node_modules/.6.20.0@babel-core/lib/transformation/file/options/option-manager.js:229:36)
at OptionManager.init (/Users/silver/program/grandhope/admin/node_modules/.6.20.0@babel-core/lib/transformation/file/options/option-manager.js:374:12)
at File.initOptions (/Users/silver/program/grandhope/admin/node_modules/.6.20.0@babel-core/lib/transformation/file/index.js:216:65)
at new File (/Users/silver/program/grandhope/admin/node_modules/.6.20.0@babel-core/lib/transformation/file/index.js:139:24)
at Pipeline.transform (/Users/silver/program/grandhope/admin/node_modules/.6.20.0@babel-core/lib/transformation/pipeline.js:46:16)
at transpile (/Users/silver/program/grandhope/admin/node_modules/.6.2.9@babel-loader/lib/index.js:41:20)
@ multi index

把webpack.config.js里面的
//webpackConfig.babel.plugins.push(['antd', {style: 'css'}]);
注释掉就好了, 可出现了奇怪的warning
(node:44911) DeprecationWarning: Calling an asynchronous function without callback is deprecated.

npm 啥版本?

bogon:admin silver$ node -v
v7.2.1
bogon:admin silver$ npm -v
3.10.10

babel-plugin-antd 已改名为 babel-plugin-import，如果你用 antd，换下试试。https://ant.design/docs/react/practical-projects-cn#使用-antd


Add install template and new project commands to VS Code extension.

This PR adds two new commands to the VS Code extension:

Still TODO:

[x] Prompt user what kind of Q# project they want to make.

Is there a way to only show "Create new project" if the project templates have actually been installed first? Or at least give more concrete instructions to install the templates first instead of .NET Core SDK exited with code ${code} when creating a new project.?

Is there a way to only show "Create new project" if the project templates have actually been installed first? Or at least give more concrete instructions to install the templates first instead of .NET Core SDK exited with code ${code} when creating a new project.?

That's a good idea, I agree, but I don't know of a good programmatic way of detecting whether the templates have been installed already...

OK, 7f3682b should do it.

Looks awesome!
It would be great if the error message when creating a project before installing project templates could be a little more descriptive. Currently it is this:

Thanks for the feedback, @bettinaheim! I've modified so it now tries to give a better error message if the project templates are missing. The new message offers the user to install the project templates and then retry.


Ensure SLSA Lvl 3

Description

Fix https://github.com/kubewarden/kwctl/issues/933

Test

Tested by running it from my fork, with a drop commit to be able to create a tagged release.
See:
https://github.com/viccuad/kwctl/actions/runs/11407858585 (the error is only in triggering the bot PR)
https://github.com/viccuad/kwctl/releases/tag/v1.18.0-viccuad
https://github.com/viccuad/kwctl/attestations

Additional Information
Tradeoff

Potential improvement

Rebased onto main to fix conflicts.


create a generalised & reusable component for accordions

create a reusable component that can work for both:

multiple open accordions (at once) &
single open accordion (at once)

provide all possible reusability features via props.

Hi @vkushal28, I would love to give this a try. Could you please assign it to me?

@mismathh sure, done


refactor(interface): remove redundant member variables

Description

🤖 Generated by Copilot at 0d1d34a
Refactor the scene module interface to support different parameter types for different scene modules. Move the registered_modules_ member variable from the scene module manager classes to the base SceneModuleManagerInterface class. Update the updateModuleParams methods of the scene module classes to use std::any_cast and std::dynamic_pointer_cast as needed. Improve the code style of some scene module classes.

Tests performed

[x] PASS TIER IV INTERNAL SCENARIOS

Effects on system behavior

Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rej55 Thanks :+1:


Not working with hikari 2.0.0.dev113

Steps to reproduce

Upgrade hikari to 2.0.0.dev113
Import lightbulb in your bot
Experience an ImportError being raised

Expected result
It should have imported correctly.
Actual result
It throwed this traceback:
Traceback (most recent call last):
  File "D:\Coding\Iodine\main.py", line 7, in <module>
    import lightbulb
  File "D:\Coding\Iodine\venv\lib\site-packages\lightbulb\__init__.py", line 156, in <module>
    from lightbulb import app
  File "D:\Coding\Iodine\venv\lib\site-packages\lightbulb\app.py", line 39, in <module>
    from lightbulb import checks
  File "D:\Coding\Iodine\venv\lib\site-packages\lightbulb\checks.py", line 49, in <module>
    from lightbulb.utils import permissions
  File "D:\Coding\Iodine\venv\lib\site-packages\lightbulb\utils\__init__.py", line 49, in <module>
    from lightbulb.utils import nav
  File "D:\Coding\Iodine\venv\lib\site-packages\lightbulb\utils\nav.py", line 36, in <module>
    from hikari.api.special_endpoints import ActionRowBuilder
ImportError: cannot import name 'ActionRowBuilder' from 'hikari.api.special_endpoints' (D:\Coding\Iodine\venv\lib\site-packages\hikari\api\special_endpoints.py)

System info
hikari-lightbulb (2.2.5)
hikari (2.0.0.dev112) [a02498e1] (since the package does not import on dev113, i have to show the info from dev112)
located at D:\Coding\Iodine\venv\lib\site-packages\hikari
CPython 3.10.8 MSC v.1933 64 bit (AMD64)
Windows DESKTOP-QK8EQRT 10 10.0.22621 AMD64 AMD64 Family 23 Model 113 Stepping 0, AuthenticAMD

Further info
No response
Checklist

[X] I have made sure to remove ANY sensitive information (bot token, passwords, credentials, personal details, etc.).
[X] I have searched the issue tracker and have made sure it's not a duplicate. If it is a follow up of another issue, I have specified it.

This is already known and fixed in #290.
You will have to wait for the next lightbulb release or install from the development branch

This is already known and fixed in #290.
You will have to wait for the next lightbulb release or install from the development branch

It doesn't install from dev branch, it just says the requirements are satisfied and it's not installing.

Force a reinstall from the development branch (pip install git+https://github.com/tandemdude/hikari-lightbulb --force-reinstall) and it should work


config: hopefully fixing C++ config default for apple

Signed-off-by: Alyssa Wilk<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Can you also remove this line? https://github.com/envoyproxy/envoy-mobile/blob/2ea19b7f8862f8d102750b1e9b95350969eb8c2e/library/objective-c/EnvoyConfiguration.m#L157

Good call, thanks!


Reset the session before logging

Issue #161 The session needs to be reset in case role, database, or warehouse were set within the migration script.

This PR fixes a bug that was introduced in one of the recent versions. I recently attempted to upgrade to the newest version (current = 3.4.1) and had to roll back because of this bug. If a role is assumed in a script that does not have access to modify the change history table, then you get an error.

Any update on this?
This caused a breaking change preventing upgrade from a previous version.

Bump! We're having the same issue and a merge of this fix would be highly appreciated.
Thanks for a great tool.

These changes were deployed in v3.6.0, PR #195. Thanks everyone.


Insync fix

Some bugs came in with switching from str() to .decode()
These changes should fix them

Sorry, I have created a new PR on tobes:insync-updates


[CPU Inference Only] Basic implementation of Face_Detector

Basic Implementation
This PR adds a basic implementation of the Face_Detector using only CPU inference.
Functionality
The functionality added by this PR is;

Detection of a single face by choosing the best classification score from the model output classifiers
Calculating a face ROI (Region Of Interest) by creating a grid of anchors, mapping these to the model output regressors and scaling it to our input image (see anchor calculation heading)
Basic cross-platform example code (Yes, I have tested it on Windows as well ;) )

ROI Calculation
The BlazeFace model, which is based on the SSD (Single Shot MultiBox Detector) framework, makes extensive use of anchoring. The model outputs 896 boxes, which represent potential locations where faces might be detected. By evaluating classifier scores, we can determine which box has the highest likelihood of containing a face.
Faces are detected in one or multiple boxes that fall within a grid composed of multiple layers. In this implementation, two grids of sizes 16x16 and 8x8 are used. When overlapped, they look something like this:

The green grid represents the 8x8 grid.
The blue grid represents the 16x16 grid.
But you might ask, 16x16 + 8x8 = 320, which is not equal to 896, right? Yes, you're correct! To account for this, we add layers. Layers allow us to add more grid boxes at the same location, which helps increase detection accuracy by providing multiple scales and aspect ratios of anchors at each grid cell. By adding 2 layers to the 16x16 grid we get more accuracy for smaller faces and by adding 6 layers to the 8x8 grid we get more accuracy for larger faces. Which fortunately for us is the exact 896 boxes which comes out of this model ;)
To make things easier this implementation generates these anchors before inference and saves them into an array that directly maps to the model output, besides this it gives the boxes a size of 1x1 which helps with scaling it to our input image.
Face Landmarking
I found out that it might be possible to do head pose estimation using the 6-landmarks this model outputs; See source code and model card. Might be interesting to implement this functionality as well.
TPU Compatibility and Performance
In the future I want to add compatibility for the Coral Edge TPU as this will further decrease computational load. I did my best to write the code as performant as possible without relying on SIMD or anyother platform specific functionality. It got to a point where I have <1.5% CPU load (Ryzen 5 7600) and 38MB of memory usage on my Linux machine. But this can be further decreased by relying on SIMD, Edge TPU (or maybe GPU offloading, but needs more research).
Example code
I did include some example code which builds by default when generating with CMake (only when generating in the root of this project folder, not when used as library). This demo runs on Linux, Mac and Windows and demonstrates the usage by drawing a ROI square around the face and with text in top left corner indicating whether a face has been detected.

Wow interesting, it looks clean! I also see nice things in the to-do list. And I appreciate that it should be compilable on windows ;)

Oh and another note; Increasing camera resolution does not give you more accurate results! The model needs a 128x128 pixels frame as input. This means that your high-res image gets downscaled to 128x128 pixels to get processed by the model.
Then the model outputs these 896 boxes which have to be scaled over your high-res image. Meaning that when you are using a high res input image the detection steps get rougher and you will certainly notice it.
Keeping your image to something lower then 1024x768 certainly helps and gives more accurate results. (640x480 is perfectly fine as well btw)

This is VSCode trying to run from a sandboxed environment (snap). I see you have installed it using snap, try to uninstall vscode and install it using the .deb installer

I Have now tested it on my laptop running Ubuntu 24.04, it runs fine. Though I have vscode natively installed using the .deb installer instead of snap. When previously using the snap version, I ran into multiple issues related to path variables and other stupid things.

I Have now tested it on my laptop running Ubuntu 24.04, it runs fine. Though I have vscode natively installed using the .deb installer instead of snap. When previously using the snap version, I ran into multiple issues related to path variables and other stupid things.

yes, me too, and I wasted a good part of the morning on this :-)
Thanks for the tip

I think we could merge .
Later on I could see how to do head-pose estimation (using the landmarks).
Should I press "Merge pull request"?

Can you first click review -> Approve

Regarding head-pose estimation: Blazeface outputs 6 approximate 2D keypoint coordinates. I have been trying to estimate head orientation from this information, but was not successful. You can have a look at the branch dedicated to this. Probably, the very crude estimator of depth is the main reason for failure.
Since we will need the face and iris landmarks anyhow (e.g. for gaze estimation and smile detection), I propose to also infer these models and compute head pose from 3D landmarks, like we did before.


When Game not recognized, VPXMonitoringService loops infinitely

To reproduce : start a table from VPX directly or by double clicking a VPX file, for a table that is not registered in the frontend
VPXMonitor will then detect a Game is started, and will try to notify GameStart.
As Game is not recognized, the GameStatus never enters in Active mode, which does not stop the VPX Monitoring
Then as the monitor still detects the window, he continues infinitely to try to notify GameStart

I'll correct by adding a forceActive status in GameStatusService to tell the system a Game is running, but GameStatus will be null as the Game is not recognized

Fixed with 3.2.0


Use @aptos-labs/ts-sdk instead of surf for dapp-boilerplate

this it is time to introduce a CHANGELOG file


Plugins and packages should not have test or flutter_test in dependencies

This leads to issues like this https://github.com/nt4f04uNd/genius_api_unofficial/issues/2#issuecomment-885100418
And there really seems to be no reason to have them as not dev_dependencies

Another ticket that is specific for video_player_platform_interface: #83562

Closing as duplicate of it


allow full recalculates to be scheduled nightly

This code is a fully functional start point for the discussion in #142 based on @wes1278 's comment on scheduling a full recalculate.
My use case for this is to allow relative date literals to be used in roll up criteria.

This looks great thank you!
Could please attach some Apex tests and also update the Permission Set files as well?
As there is a limit on scheduled jobs in the platform, it might be good to be able to group via List View rollups and schedule those, so maybe another idea is to have a List View Button to do the same? Not as part of this PR, but just sharing a thought generated from your work here.
Thanks again! :+1:

I've updated the PR with a test for the controller to ensure that a cronjob gets scheduled, and that scheduling the same calculate job twice fails.
Let me know if this meets expectations.


@Suite test_class not picking up matching selected classes.

I have the following UnitTestSuite.java file
@Suite
@IncludeClassNamePatterns("^(Test.*|.+[.$]Test.*|.*Tests?)$")
public class UnitTestSuite {}

And following macro
load("@contrib_rules_jvm//java:defs.bzl", "java_junit5_test")

def java_unit_test(name, srcs, deps, **kwargs):
    java_junit5_test(
        name = name,
        test_class = "com.foo.testsuite.UnitTestSuite",
        srcs = srcs + ["//tools/test/java/testsuite:src/main/java/com/foo/testsuite/UnitTestSuite.java"],
        runtime_deps = [
            "@maven//:org_junit_platform_junit_platform_runner",
            "@maven//:org_junit_platform_junit_platform_reporting",
        ],
        deps = deps + ["@maven//:org_junit_platform_junit_platform_suite_api"],
        **kwargs
    )

called with
java_unit_test(
    name = "unit_test",
    srcs = glob(["src/test/java/com/foo/**/*UnitTest.java"]),
    deps = [
        ":base_gateway",
        "@maven//:org_junit_jupiter_junit_jupiter_api",
        "@maven//:org_junit_jupiter_junit_jupiter_engine",
    ],
)

and
public class FooUnitTest {
  @Test
  public void test() {
    Assertions.assertEquals(0, 2);
  }

  @Test
  public void test3() {
    Assertions.assertEquals(0, 2);
  }
}

When I run bazel test //foo:unit_test it seems that it is only running the actual UnitTestSuite without executing the other suite classes matching the pattern and provided in srcs.
Is there something wrong?
I used to be able to do that using native.java_test and previous @Suite() / @SuiteClasses.
If I add a test in UnitTestSuite:
@Suite
@IncludeClassNamePatterns("^(Test.*|.+[.$]Test.*|.*Tests?)$")
public class UnitTestSuite {
  @Test
  public void test() {
    Assertions.assertEquals(0, 2);
  }
}

then test is correctly run and fails:
INFO: Analyzed target //foo/base:unit_test (0 packages loaded, 0 targets configured).
INFO: Found 1 test target...
...
INFO: Elapsed time: 1.034s, Critical Path: 0.95s
INFO: 3 processes: 1 internal, 1 darwin-sandbox, 1 worker.
INFO: Build completed, 1 test FAILED, 3 total actions
//foo/base:unit_test                                       FAILED in 0.8s
...
expected: <0> but was: <2>
Expected :<0>
Actual   :<2>
Executed 1 out of 1 test: 1 fails locally.

Thanks for your help

Closing the issue as I found the error myself. Nothing to do with this library.
Just adding
@Suite
@SelectPackages("com.foo")
@IncludeClassNamePatterns(".*UnitTest.*")
public class UnitTestSuite {}

worked. Didn't know we had to select things.


hotfix destats -> stats deprecation

The proper fix #1372 requires updates of upstream dependencies. This just silences the deprecation warning for now.

Superseded by #1372


chore: switched lockfile to use official yarn repo

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Experimental logic for handling parenthesized comments

Summary
This PR adds support for parenthesized comments. A parenthesized comment is a comment that appears within a parenthesis, but not within the range of the expression enclosed by the parenthesis. For example, the comment here is a parenthesized comment:
if (
    # comment
    True
):
    ...

The parentheses enclose the True, but the range of True doesn’t include the # comment.
There are at least two problems associated with parenthesized comments: (1) associating the comment with the correct (i.e., enclosed) node; and (2) formatting the comment correctly, once it has been associated with the enclosed node.
The solution proposed here for (1) is to search for parentheses between preceding and following node, and use open and close parentheses to break ties, rather than always assigning to the preceding node.
For (2), we handle these special parenthesized comments in FormatExpr. The biggest risk with this approach is that we forget some codepath that force-disables parenthesization (by passing in Parentheses::Never). I've audited all usages of that enum and added additional handling + test coverage for such cases.
Test Plan
cargo test with new cases.
Before:

project
similarity index

build
0.75623

cpython
0.75472

django
0.99804

transformers
0.99618

typeshed
0.74233

warehouse
0.99601

zulip
0.99727

After:

project
similarity index

build
0.75623

cpython
0.75472

django
0.99804

transformers
0.99618

typeshed
0.74237

warehouse
0.99601

zulip
0.99727

(Pushing for CI purposes; not ready for review.)

(Please don't re-review for now. I'm breaking this into some smaller PRs that can be merged separately ahead of this larger change.)

Okay, I believe this is ready for review.


UAHF: Adjust block size DoS limit

DoS limits for block size was adjusted for BIP100, but not a sudden jump to 8MB.

This solves issue reported here https://github.com/bitcoinxt/bitcoinxt/issues/235

ACK


Static parameter warning

I have added the logic to produce log warning if static command line parameters are specified in 'execute-command' (issue #151):
"execute-command": "/bin/echo test"
will produce:
[webhook] 2017/08/25 23:31:55 unable to locate command: '/bin/echo test'
[webhook] 2017/08/25 23:31:55 use 'pass-arguments-to-command' to specify args for '/bin/echo'

Let me know if you want me to do it in a different way.

Looks great! If you could add some tests for this feature, I would be more than glad to merge it in! Thanks.

@adnanh I've added a test for this feature -- let me know if they look fine.
Thanks.

It's not documented anywhere how to use "pass-arguments-to-command"

@simplenotezy,
In the future, please don't comment on issues that were closed years ago.  Open a new issue.
To answer your question, see the Github example at https://github.com/adnanh/webhook/blob/master/docs/Hook-Examples.md#incoming-github-webhook


Refresh the database view after migration

When a migration is applied or rolled back in the backend, the list of tables in the Database tab is not updated in real time. A manual refresh needs to be performed to view any changes. I suggest automatically refreshing the view any time a migration is applied or rolled back.

@multiwebinc I've taken a look at this, and I think this has highlighted a workflow flaw with the Builder plugin more than anything.
If you rollback a migration, the database is automatically updated based on the migrations and reflects the state of the database at that version. However, the database editor - when saving changes - is set to create a new version at the end of the upgrade path. For example, if I have a plugin at 1.0.5, and roll it back to 1.0.4 and then make an edit to the database tables, it will create a migration to run at 1.0.6 (ie. after the latest version), which may result in issues if were to make an edit to a table that is dropped in 1.0.5.
The main issue is that the database table list reads the database tables direct from the database, so it doesn't consider that there may be some migrations that are not yet applied.
The way I see it, we have two options - we either update the database editor to always reflect the latest version, which may mean parsing through the migrations and generating the list from that data, or alternatively, we change the database editor so that if you rollback to a previous version and make edits, it creates a new version history from that point and deletes any future migrations.

@LukeTowers any thoughts on the above comment?

I don't think this plugin should be actively deleting any files or code if it can help it.

Well that's gonna make my latest branch stick out like a sore thumb... 😅

@bennothommo 😂 I meant moreso that we shouldn't be deleting files automatically without even allowing the user to make the decision. Explicitly triggered deletion is fine.

What about disabling the database tab if there are pending migrations?


test(version): Fix test version reading it dynamically

Fix unit tests

:tada: This PR is included in version 1.3.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Get segmentation for a moving link

I try to move a link by adjusting the joints, and I wish to get the segmentation mask for that specific moving link.
Is there any way to map an adjusted joint to a moving link, and then map the moving link's name to a specific label in the result of camera.get_uint32_texture('Segmentation') ?
Or is there's another way to reaching the goal?
When I do:
camera.get_uint32_texture('Segmentation') seg_array = np.array(seg_labels) print(np.unique(seg_array[:,:,0]))
The output is a bit hard to understand how it is related to different links:
[0 1 12 18 19 20 21 31]
Also, sorry that I don't understand how the render of segmentation works in the source code.
I would be really appreciate if you can help. Thank you!

link.id will correspond to seg_array[:,:,1] while visual id corresponds to seg_array[:,:,0]. So you should have a correct mapping when using channel 1 of the segmentation texture.

Thank you!


Changing option and then adding the same previous option merges the products

Let's say I have a product with option large. When I change it to small and everything works. Now I changed my mind and i want the product with option large again. There should now be one product with option large and one product with option small, right? Nope, for some reason it merges into one product with option small but with quantity 2. That should be the case if i wanted the same product, but I'm checking for duplicates and I'm getting none, tried dumping and everything is correct. That's quite a bug...
It should be noted that i changed the line 216 in src/CartItem.php to
$this->rowId = array_get($attributes, 'rowId', $this->rowId);
since I see no reason to change the whole rowId when trying to update just an option, when i can check for duplicates manually and it completely destroys any ajax related work with the item.
EDIT
I changed the code back to original and now it works as it should, i really don't know what to do since it destroys the whole site since the old rowId now doesn't exist. Plus it messes with the order and it's really annoying

Well the row id is the id + options. If you dont update the row id while updating to small it is the same row id as large and therefore will merge.

Wrong approach used in this....as in codeigniter Cart class automatically creates new row id if same product with diffrent options are inserted.


Leading comment (#92)_47

Motivation
Support leading comments at the beginning of the test file
Helpful for copyright information and test descriptions
Add optional default value for named addresses on miss
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI/CD tests are covered.

/canary

:sunny: Canary successful

/land


Is it needed to add 'O_APPEND' flag here?

https://github.com/natefinch/lumberjack/blob/47ffae23317c5951a2a6267a069cf676edf53eb6/lumberjack.go#L235
My scene(kube-apiserver audit.log):

use logrotate at my workplace to handle log rotation (size > 50M then rotate, copyrtuncate) and make audit-log-maxsize very large (--audit-log-maxsize=100000) so native rotation will not start.
if there is no audit.log file before, it will be open by flag 'os.O_CREATE|os.O_WRONLY|os.O_TRUNC'，so when logrotate to rotate the log file,  i'm getting binary thrash in log file, and audit.log keeping growing.
if there is an exsiting audit.log file before, it will be open by flag 'os.O_APPEND|os.O_WRONLY', so when logrotate to rotate the log file, copytruncate works well, and audit.log is truncated as we hope.

In my test:
I add O_APPEND flag here, everthing work well, and audit.log is truncated as we hope. so is it needed to add 'O_APPEND' flag here?

Truncate and append don't make any sense together. Truncate truncates, there's nothing to append to.
You said "when logrotate to rotate the log file" ... if lumberjack is writing to the file, you can't have logrotate rotating the file.  Lumberjack won't know the file has changed, and will continue writing at the place on disk it last knew to be the end of the file.  That's probably the problem.  You can't have any other application changing the log file. Only lumberjack can change it.

I agree that "You can't have any other application changing the log file" .But in my opinion, with O_APPEND flag, "The file is opened in append mode.  Before each write(2), the file offset is positioned at the end of the file, as if with lseek(2)", so Lumberjack  can know when the file is truncated.


logging.shutdown() fails to close logging handler when executed in Spyder

import logging

FLAG_SHUTDOWN = False

def init():
    logobj = logging.getLogger(__name__)
    logobj.setLevel(logging.DEBUG)
    hconsole = logging.StreamHandler()
    logobj.addHandler(hconsole)
    return logobj

def closer(arg_logger):
    if FLAG_SHUTDOWN:
        logging.shutdown()
    else:
        handlers = arg_logger.handlers[:]
        for handler in handlers:
            handler.close()
            arg_logger.removeHandler(handler)

def speak(arg_logger):
    logger.info("------------------------------------------------")
    logger.info("Line 1")
    logger.info("Line 2")
    logger.info("Line 3")

logger = init()
speak(logger)
speak(logger)
closer(logger)

The attached Python script runs without anomalies.  It closes every handler one at a time.  It can be run in the Spyder environment repeatedly without causing duplicated logging records.
However, changing
FLAG_SHUTDOWN = True
will cause the closer() subroutine to use logging.shutdown() which should force the "logging system to perform an orderly shutdown by flushing and closing all handlers" according to Python 3 documentation.  It doesn't seem to do anything in the Spyder environment (conflict?).
When I rerun the same script a second time, I see duplicated messages, probably from the old handler and the new handler.  A 3rd time, triplicated messages, etc.
Not asking for any extraordinary effort here.  Just a resolution of some sort.  Maybe, Spyder should trap the logging.shutdown() call (happening already?) and throw an Exception (Don't do that).  I'd rather be punished for having a misunderstanding that is causing a conflict. (:

Anaconda environment, up-to-date.
spyder                    3.3.4                    py36_0
spyder-kernels            0.4.4                    py36_0

You omitted from your quoting of the logging.shutdown docs some important stuff. This is the full text:
logging.shutdown()

    Informs the logging system to perform an orderly shutdown by flushing and closing all handlers. This should be called at application exit and no further use of the logging system should be made after this call.

The critical part is:

This should be called at application exit and no further use of the logging system should be made after this call.

In our case, application exit means a kernel restart because it is not possible to evaluate more code after it.
So this means that you can't call logging.shutdown in an interactive session (like the one provided by our IPython consoles) and expect to keep working with logging in the next evaluation.
A possible workaround would be to turn on
Remove all variables before execution

in the menu
Run > Configuration per file

and see if that helps.

@ccordoba12 I did consider what you felt was critical in the documentation but

I was focused on the fact that the old handlers were not being closed during shutdown() as documented.  Something seems to be going wrong but no Exceptions were thrown.
My Python program, in fact, follows the documentation advise i.e. makes no further use of  logging and exits.  However, I realise that Spyder and my Python programs viewed monolithically by the Python kernel are what the advise is referring to.
My Python program does successfully use logging in subsequent executions but new handlers were added to the old handlers.

Thanks for the work-around.  My code includes manually walking the list of handlers already so I'll just keep using that unconditionally since it works in Spyder and at the bash shell prompt.
So, I have to say that this is a logging.shutdown() oddity and I would not expect Spyder to do anything about it.  I'll bet that I am not the only one who has run into this.

@ccordoba12 I'll assume that you read my previous comment.

Sorry, we can't really help you with this in our end.

Agreed. Its a logging.shutdown() anomaly that I can easily avoid using my sample closer() without the boolean switch.


All versions after v1.23 immediately crash

All versions of Conty after v1.23 immediately crash and just print the message
Killed

v1.23 works as expected though. What can I do to debug the issue?

You can try tro enable USE_SYS_UTILS and see if this helps. Also, what Linux distro are you using?
$ USE_SYS_UTILS=1 ./conty.sh ...


Fixing CentOS References / Removed Name from Module

facter saw as CentOS (at least in CentOS 6.4) but was looking for centos. Also definition of name in the class was throwing duplicate errors.

Thanks for the PR, could you please flatten your commits.

Once #9 is resolved this should be pulled in


_chromecastService.StartLocatingDevices() returns 0 devices

Hi
Am trying to locate my Panasonic Viera Smart TV which is connected to my Wifi, however the _chromecastService.StartLocatingDevices() API always returns 0 devices. I have even tried with my phone IP address, still the same result.
Am using it in my Xamarin Forms App.
Xamarin Forms Version <IP_ADDRESS>1731
Android SDK version Minimum (4.4) and Target (8.1).
Pls let me know if you need any more details

The code is filtering the results to only return chromecast devices. You would need to change the filtering logic to get back your Viera Smart TV

Sorry i couldn't get that. Can you please elaborate it a bit more?
Following is the snippet of the code that am using.  <IP_ADDRESS> is my
Phone's IP Address. Are you indicating that i should be using some other
API? if so then which one?
Appreciate you support.
private async void LoadChromecasts()
{
var foundChromecasts = await
_chromecastService.StartLocatingDevices("<IP_ADDRESS>");
foreach (var foundChromecast in foundChromecasts)
{
Chromecasts.Add(foundChromecast);
}
}
On Wed, Aug 1, 2018 at 3:15 PM, Teemu Tapanila<EMAIL_ADDRESS>wrote:

The code is filtering the results to only return chromecast devices. You
would need to change the filtering logic to get back your Viera Smart TV
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Tapanila/SharpCaster/issues/140#issuecomment-409517819,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB9hNGsFV4LAdnFsypz7xN7yqvFsuIhAks5uMXjEgaJpZM4Vp49d
.


Move all devicelab_benchmarks back to prod

AFAICT these have all been almost completely green for the past 500+ hundred runs: https://ci.chromium.org/p/flutter/g/devicelab_benchmark/console?limit=500
cc @keyonghan

This is being tracked at https://github.com/flutter/flutter/issues/105468. Marking as dup.


Keyboard / Touchbar media keys not working

This app is great, but one final piece is missing, ability to pause/resume or switch radio staton with media keys on keyboard or touchbar. Also in Big Sur currently playing has been introduced to menubar and radiobar is not present there with it's playback. Finally bluetooth headphones have media controls and they are not working with radiobar.

You can send commands through a TCP connection on port 65432 on localhost. E.g. you can use the commands 'on' 'off' or any number that corresponds with your radio presets. Below is an example script to issue the commands:
import socket
import sys
import time
import subprocess
import errno
from socket import error as socket_error

HOST = '<IP_ADDRESS>'  # The server's hostname or IP address
PORT = 65432        # The port used by the server

def connect():
    try:
        s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
        s.connect((HOST, PORT))
        return s
    except socket_error as serr:
        if serr.errno != errno.ECONNREFUSED:
            raise serr
        subprocess.Popen(["open","/Applications/RadioBar.app"])
        time.sleep(5)
        return connect()

try:
    s = connect()
    s.sendall(sys.argv[1])
    data = s.recv(1024)
    print(data)
except socket_error as serr:
    print(serr)
    sys.exit(1)

Thank you for reply. How are you plugging such script to keys? Are you able to control other media apps once they are playing after assigning these keys to radiobar?

Take a look at apps like Alfred, Keyboard Maestro or Fastscripts.


Fix spaceauth YAML spaceship cookie loading

introduced by:

https://github.com/fastlane/fastlane/pull/7883 (rubocop rules update)

issues:

https://github.com/fastlane/fastlane/issues/8011

When testing spaceauth from the command line, I was not able to reproduce the problem. I had to start an irb session and effectively run the SpaceauthRunner code in order to see it.
$ irb
>> require 'spaceship'
=> true
>> require 'spaceship/spaceauth_runner'
=> true
>> Spaceship::SpaceauthRunner.new(username: 'your@email.address').run
Logging into to iTunes Connect (michael.furtak@gmail.com)...
Successfully logged in to iTunes Connect

I added a commit that adjusts the safe_load call to account for all of the settings needed to make the call work for me.

I should say that the account that I used has two-step auth turned on, but I don't think that's a requirement for testing this?

Code-wise this looks fine to me, however I'll have to have a way to reproduce the issue to say for sure that's a valid fix. Seems like @dimmdesign mentioned it didn't work for him?

i am pretty sure the fix is ok - here is stripped down sample to reproduce.
require 'http-cookie'

stored = "1.cookie"

# try to redo the things going on in client.rb
jar = HTTP::CookieJar.new
cookie = HTTP::Cookie.new("uid", "u12345", domain: 'example.org',
                                            for_domain: true,
                                            path: '/',
                                            max_age: 7*86400)

jar.add(cookie)
jar.save(stored, :yaml, session: true)

cookie_content = File.read(stored)

# load it -> redo things going on in spaceauth_runner
begin
  deserialized = YAML.safe_load(cookie_content)
  puts "Non whitelist works (UNEXPECTED)"
  puts deserialized.inpsect
rescue => ex
  puts "Non Whitelist does not work (EXPECTED)"
end

deserialized = YAML.safe_load(
         cookie_content,
        [HTTP::Cookie, Time], # classes whitelist
        [],                   # symbols whitelist
        true                  # allow YAML aliases
       )

puts deserialized.inspect
puts "with whitelist it works"

@KrauseFx @mfurtak @hjanuschka —
I tried this again and it seems to be working with this fix. I didn't use the local version of fastlane correctly before, my bad. Confirming that master branch (since this PR merged) can create a session.

Cool, thanks for confirming @dimmdesign, we're about to ship a new release for this fix 👍


Provide ARM64 images

Currently it's a pain to use make preview in the docs repos on an Apple Silicon Mac.
Although docker can be run through rosetta, it's very unstable and unreliable. The only option is to use qemu emulation which is slow. Most docs take over 1minute to build this way.

I added multi-arch builds and on my Apple M1 Mac the "platform mismatch" error message is gone. The time from file save to browser refresh is now ~45s:
19:03:29 - INFO - Got change for: ...
19:04:15 - INFO - Reloading browser: ...


How to fetch event codes of PERF_METRICS.FRONTEND_BOUND from icelakex_metrics.json file

Hello,
TL;DR; I need event codes for PERF_METRICS.FRONTEND_BOUND, PERF_METRICS.BAD_SPECULATION etc. how to obtain them is there a script or a place to look at?
I would like to implement some portion of the TMAM analysis for educational purposes, although I have all the event codes for my architecture (ICL) I cannot find the corresponding events for FrontendBound although I've the formula regarding how it is calculated
From the file /ICL/metrics/icelakex_metrics.json I've the following description, Althoguh 1 of them has direct event code INT_MISC.UOP_DROPPING, others are unclear.
I'd be glad if you help me,
Best.
Here's the json element
{
"MetricName": "Frontend_Bound",
"LegacyName": "metric_TMA_Frontend_Bound(%)",
"Level": 1,
"BriefDescription": "This category represents fraction of slots where the processor's Frontend undersupplies its Backend. Frontend denotes the first part of the processor core responsible to fetch operations that are executed later on by the Backend part. Within the Frontend; a branch predictor predicts the next address to fetch; cache-lines are fetched from the memory subsystem; parsed into instructions; and lastly decoded into micro-operations (uops). Ideally the Frontend can issue Pipeline_Width uops every cycle to the Backend. Frontend Bound denotes unutilized issue-slots when there is no Backend stall; i.e. bubbles where Frontend delivered no uops while Backend could have accepted them. For example; stalls due to instruction-cache misses would be categorized under Frontend Bound.",
"UnitOfMeasure": "percent",
"Events": [
{
"Name": "PERF_METRICS.FRONTEND_BOUND",
"Alias": "a"
},
{
"Name": "PERF_METRICS.BAD_SPECULATION",
"Alias": "b"
},
{
"Name": "PERF_METRICS.RETIRING",
"Alias": "c"
},
{
"Name": "PERF_METRICS.BACKEND_BOUND",
"Alias": "d"
},
{
"Name": "INT_MISC.UOP_DROPPING",
"Alias": "e"
},
{
"Name": "TOPDOWN.SLOTS:perf_metrics",
"Alias": "f"
}
],
"Constants": [],
"Formula": "100 * ( a / ( a + b + c + d ) - e / ( f ) )",
"BaseFormula": " perf_metrics.frontend_bound / ( perf_metrics.frontend_bound + perf_metrics.bad_speculation + perf_metrics.retiring + perf_metrics.backend_bound ) - int_misc.uop_dropping / tma_info_thread_slots",
"Category": "TMA",
"CountDomain": "Slots",
"Threshold": {
"ThresholdMetrics": [
{
"Alias": "a",
"Value": "metric_TMA_Frontend_Bound(%)"
}
],
"Formula": "a > 15",
"BaseFormula": "metric_TMA_Frontend_Bound(%) > 15",
"ThresholdIssues": ""
},
"ResolutionLevels": "THREAD, CORE, SOCKET, SYSTEM",
"MetricGroup": "BvFB;BvIO;TmaL1;PGO",
"LocateWith": " FRONTEND_RETIRED.LATENCY_GE_4"
}

Hi @Osmanyasal thanks for creating a ticket. Please refer to https://github.com/intel/perfmon/issues/225#issuecomment-2423192806 and https://github.com/intel/perfmon/issues/225#issuecomment-2423216781 . Feel free to re-open if you additional questions.

Hello @edwarddavidbaker, thank you for the response, I indeed have brief questions.
I checked the original paper "A Top-Down method for performance analysis and counters architecture" by Ahmed Yasin.
--> In his implementations, there are many operations to obtain "front-end bound, be-bound" etc. however the link only monitors a few "direct" event codes like;
#define SLOTS               0x0400ull
#define RETIRING_SLOTS      0x8000ull
#define BAD_SPEC_SLOTS      0x8100ull
#define FE_BOUND_SLOTS      0x8200ull
#define BE_BOUND_SLOTS      0x8300ull
I also use perf_event_open and what he did is to create a group-leader with slots and group all these. when reading, it divides all other metrics to slots, which is different from what Ahmet suggests, how does this work?
// original implementation

--> I know pmu events are different per u-arhitecture, are these event codes (0x0400, 0x8000 etc) fix for each new-gen intel processor? I skimmed through the manual, I believe intel reserved some pre-defined event codes for TMA analysis.
Looking forward the answer
Best wishes,
Osman.

Hi Osman,
If you are wanting to use Linux then perf has topdown analysis built in:
https://perfwiki.github.io/main/top-down-analysis/
You can also use perf list -j to dump out event encodings and metrics. If you get topdown data with something like perf stat -M TopdownL1 <benchmark> then there are verbose options (-v, -vv, -vvv) used like perf stat -vv -M TopdownL1 <benchmark> which will dump out the perf_event_open options used.
Thanks,
Ian

Hello @captain5050, thank you for the response. I am actually building a library for energy optimisation in mind but also one that supports performance analysis.
Now it is time for me to implement TMA to increase use-cases. However I need to know whether the above events are definite among intel processors (which pmu events often are not) and whether the measurement is correct compared to the paper
Best
Osman.

Thanks Osman. A few thoughts:

for C/C++ code perf's been trying to do this libperf separation, it should really have things like event parsing in it.
there's a python API for perf that has been traditionally used to process events for things like flame graphs and the firefox profiler. This patch series that just landed in the development tree makes it so that you write python scripts doing perf like things using things like regular event names. I've not yet extended it to handle metrics, but there is already a bunch of python metric code.
in the next linux release hwmon will be exposing new events for things like energy, power, .. Here is the patch series.
I'm aware of things like DRAM power consumption being something we should expose as perf events when the hardware supports it. There's work on other platforms to do things like per-core power analysis too.


Generate enum for all events

Problem
I'm trying to make a custom Unity component that allows me to pick from a generated AudioEvent in a dropdown and have that save & serialized.
Possible solution
It'd be helpful if this plugin could also generate an enum of all the Events too. e.g.
public enum AudioEventType {
 MyEvent1,
 MyEvent2
}

and then there could be an enum lookup function like
public sealed partial class AudioEvents
{
   // ...
   public static Find(AudioEveneType eventType) {
       switch (eventType) {
            case AudioEventType.MyEvent1:
               return AudioEvents.MyEvent1;
            case AudioEventType.MyEvent2:
               return AudioEvents.MyEvent2;
              // ... etc
       }
   }
}

Or maybe you have a suggested alternative approach. thanks!

nvm im a dummy and just saw this:
[SerializeField] private AudioConfigReference parameterlessAudio;

LOL it's okay, it's a big package, easy to miss stuff.
I appreciate that your first reaction to missing a feature was to try and add it yourself 🙂

Haha, thanks. However, in a turn of events it doesnt solve my specific use case entirely. Maybe you can lend some advice?
I'm using another 3rd party plugin, NodeCanvas, which has its own editor renderer for variables. It only supports standard C# types and adding support for something custom like AudioReference is too much work... but if there was an alternative generated enum approach that seems like it'd be slightly more flexible of a system. Thoughts?

Haha, thanks. However, in a turn of events it doesnt solve my specific use case entirely. Maybe you can lend some advice?
I'm using another 3rd party plugin, NodeCanvas, which has its own editor renderer for variables. It only supports standard C# types and adding support for something custom like AudioReference is too much work... but if there was an alternative generated enum approach that seems like it'd be slightly more flexible of a system. Thoughts?
This is probably more of a NodeCanvas issue than yours so feel free to tell me "not my problem" :)

Hmm, disappointing to hear that it doesn't "just work" in NodeCanvas. I don't know NodeCanvas but given that AudioReference uses a property drawer, it shouldn't be too much work to make it work. You should be able to just draw the property using EditorGUI.PropertyField and then it should be displayed exactly the same as in an inspector.
This sounds like less work than making a whole new system just because it's not displayed correctly in NodeCanvas. Also, there's drawbacks to the idea of generating some kind of enum, like it will not handle event renames as gracefully as the current solution, not does it support subfolders.
If you like the idea of the enum approach you can try it out of course, but I personally wouldn't go for it.

Thanks for the reply! I ended up building a custom editor tool for NodeCanvas. So, all is well.
I did however have to make my own custom AudioReference class that mimics yours but needed to make the the guid public so that it could be serialized by their property drawers.

Thanks for the reply! I ended up building a custom editor tool for NodeCanvas. So, all is well.
I did however have to make my own custom AudioReference class that mimics yours but needed to make the the guid public so that it could be serialized by their property drawers.

Glad to hear!
You can also open a PR where AudioReference's guid is public if that saves you a lot of hassle. It seems like a lot of work to have a whole copy of AudioReference 😅


Content Writing for Frictionless Data Guide

Overview
Work out content for the guide on next.frictionless.io
Tasks
Write out content for the sections outlined below:

[x] Table Schema

[x] Table
[x] Table Schema
[ ] Validation
[ ] Tabulator

[ ] Data Resource

[ ] CSV Dialect
[ ] (Pre)view
[ ] CSV to Excel (with Correct types)

[ ] Data Package

[ ] Load to SQLite
[ ] Table References and Foreign Keys
[ ] Load to Postgres
[ ] Publishing Data(sets)

[ ] Flows

[ ] Flow Concept

Here's the FD draft content
See #430 for more context.

I'm currently working on Validation section of the Guide.
Task

Write out content on validation table data
Show examples using Goodtables Python and JavaScript Libraries.

Blockers:

Running examples with the JavaScript library. From the documentation I need to pass an API URL, API TOKEN, API Source ID as seen below.

const source = '<SOURCE_URL>'
const options = {
  apiUrl: 'https://goodtables.io/api',
  apiToken: '<API_TOKEN>',
  apiSourceId: '<API_SOURCE_ID>',
}
const report = await goodtables.validate(source, options)

I'm blocked because I don't know where to get these values from to run the example. cc @rufuspollock

@julietezekwe here's the issue I mentioned you can take a look at the repo to figure out the problem. https://github.com/frictionlessdata/goodtables-js

Ok, I will take a look at it and revert

This is a duplicate of #430. so I'm closing to avoid confusion.


Consider adding docs for Web Api compat shim

I had a customer today that wanted to take existing Web API 2 code and move to ASP.NET Core with minimal changes. They were looking for docs on how to use the Web API compat shim, but apparently there are none: https://twitter.com/RickAndMSFT/status/878033598367932416 // @Rick-Anderson

@danroth27  do we have anything to start with?

No, we need to create a new doc from scratch.

Dup of #1811


:honeybee: Docs for Updating data

Update documentation for section "Updating data" that doesn't use reference branch and recommends using etl d draft-pr --step-update for creating PR.
Check out new docs on staging server.
@pabloarosado I'm the only one who is using the new workflow. It'd make sense to first try it out a few times and only then overwrite the existing docs.

I've added etl pr support, while leaving etl d draft-pr still active.


Remove node-sass

node-sass has been deprecated and should be replaced by sass. This fixes build issues during yarn install from node-gyp errors.
Testing
yarn install && yarn build:all

Preview is available here:http://stellar-anchor-tests-pr121.previews.kube001.services.stellar-ops.com/


ICCM and DCCM instantiation to External SRAM

Hi,
As far as understand the ICCM and DCCM as described in modules:  el2_lsu_dccm_mem & el2_ifu_iccm_mem are implemented with FF.
I wants to replace the ICCM and DCCM with SRAM implementation.

Is any reason or restriction which prevent such change?
Do we have any guide for such change?
What are the files which need to be changed?

I search if there is any issue like this and I found  one issue similar issue #155  [https://github.com/chipsalliance/caliptra-rtl/issues/155].
But this issue doesn't describe what files need to changed.
Please advice

So, If I understand all Caliptra files (except calipta_top) are remains as is without any changes?
If this is true, than as I understand file el2_mem_if.sv which has a modport called 'top' , is the link to the external ICCM & DCCM SRAMs.
So all I need to do is adding the DCCM and ICCM in caliptra_top (instantiate) , In similar way as described in issue https://github.com/chipsalliance/caliptra-rtl/issues/155 ?

Your SRAM must operate with the same timing as shown in the integration spec. Given this requirement, no Caliptra RTL files should be modified while you are swapping in your SRAM module. You're correct that el2_mem_if.sv is used to connect the external SRAM to ICCM/DCCM interfaces in the RISC-V core.
Also, the modports in el2_mem_if.sv have been renamed. If you still see a modport named top in your code, you probably want to update to the latest code.

Many Thanks calebofearth for this reply!
I think I know what to do.


tests: rename addFilter() to prependFilter()

To avoid confusion when writing integration tests, make it clear
that filters are prepended.
Signed-off-by: Raul Gutierrez Segales<EMAIL_ADDRESS>

/assign-from @envoyproxy/envoy-maintainers

Counterpart:
https://github.com/envoyproxy/envoy-filter-example/pull/151


I want to know how to bind him to the outside network, because I really like this design and project, but I can't do anything, there is no good advice?

Closing as spam; reopen with more details if its not


Yosys emits assigns with a concatenated expression on the LHS

Yosys can emit verilog that has a concatenated signal as the recipient of an assign statement.
I.e something like:
assign {a,b} = {c,d};
The problem is that this causes problems for other tools; in this case OpenSTA [*], which means I can't properly verify my design.
I did not see this issue until recently, and it occurred after I introduced a hilomap stage, possibly because that reduces the fanin of constant buses. It's difficult to provide an example because it only seems to happen under certain circumstances.
I did try adding some opt_clean and clean stages after the hilomap, but that didn't seem to help.
I think I saw a previous issue/communication about this somewhere (but can't find it anymore ..), where it was stated that this was legal verilog, and therefore should be OK. Well, I can see that point of view, but it just seems it would cause less trouble if such assigns were split into multiple assigns with only one signal as their recipient.
[*] OpenSTA is really great, by the way.

I'll just add that the Gowin tools also don't like post-synthesis Verilog with this style of assignment.

It occurred to me that Yosys already has a pass that can avoid having such assignments be emitted: simply run splitnets -driver before write_verilog. Can you confirm this works (or does not) for you?

It seems that this would reduce the number of splits that are done. Post-synthesis verilog in Gowin is very limited and I'm already using plain splitnets to make it happy. I can try this when I look at the other Gowin changes Eddie suggested. (might be a while) What I think needs to be done is slightly different, which does split all the nets, but assigns individual bits to the output port. The -port option might actually be a workaround for Gowin, as top-level output ports are single pins anyway, but this might require adjusting pin mapping to some Yosys-generated name, which is not ideal.

Actually, I think this was suggested when I first raised the issue. Unfortunately, it doesn't work.
Using splitnets -driver does not make any difference to my output netlist - I get the same errors.
Using splitnets by itself makes the issue worse - I get more occurrences of the problem.
I think the point is that it's not a driver issue - splitnets is probably doing its job quite happily.

Oh, you're right, and I misunderstood this issue.

Awesome!


modbus: serial: Fix incomplete transmission issue

This patch is to fix an issue where the transceiver chip is
disabled before it has transmitted all data. This causes the
message to be corrupted because the last few bytes are missing.
The fix adds a check to make sure the transmission is completed
before disabling the transceiver.
Signed-off-by: Marius Scholtz<EMAIL_ADDRESS>Note: This problem was observed on the atmel sam chips and there will be a separate PR later to fix hardware specific issue that also causes modbus to fail.

@mcscholtz Is this fixing #40578?

@mcscholtz Is this fixing #40578?

Oh interesting. I was unaware of that issue, but it does appear to be the same thing. Along with this PR, there is a fix in the atmel sam usart driver PR to fix it for the sam x70x devices.

@mcscholtz Is this fixing #40578?

Hi @stephanosio , #40578 is related to SAM0 not SAM.

@jfischer-no The other way to fix this is to wait till the transfer is complete before disabling the transceiver. This is better, it is much more clear what is going on. See the updated PR

@jfischer-no I am going to close this. I found a solution making changes only to the uart driver.
FYI these atmel chips have a TX_RDY and TX_EMPTY irq. I am adding an option "rs485 mode" to the driver which will use TX_EMPTY instead of TX_RDY. This ensure everything is transmitted so this will not happen.

@jfischer-no I am going to close this. I found a solution making changes only to the uart driver.

@mcscholtz I am on it now, can you please open it again in the original state (e5878f4d491c095444a53da2215df5f8bf0e4399) ?


Refactoring and testing

Refactoring is needed in order to simplify main file and split functions on different modules.

Take out functions for reading configuration files into classes:
--  LocalConfigReader for reading configs in local environment. Initialized by local path to user configurations.
-- RemoteConfigReader for reading configs in Kubernetes namespaces. Initialized by Kubernetes cluster configuration.
Take out functions for generating configurations via jinja templates into special class Renderer
Test created entities.

#17 merged

Test description:
Test data added in project for tests below. This data includes two valid and one invalid user configuration.

Test for LocalConfigReader:
Read test data and check if only two configurations passes validation.
Test for RemoteConfigReader:
Test data is added in mock object to make it configmap-like. Then mock object is provided to RemoteConfigParser. Test checks if only two configurations passes validation.
Test for generators:
As soon as there is no need to check generation itself I decided to check if generated configurations can be parsed as yaml file. Test data described before is provided to LocalConfigReader and then to generator. Generator results are parsed with yaml.safe_load. Test fails if any exception occures during parsing generated files.


Directly reference upstream CS workflow

Codecov Report

Merging #5 (0c2ed4d) into 2.10.x (3eaf76e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           2.10.x       #5   +/-   ##
=======================================
  Coverage   87.62%   87.62%
=======================================
  Files         363      363
  Lines       19048    19048
=======================================
  Hits        16691    16691
  Misses       2357     2357

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eaf76e...0c2ed4d. Read the comment docs.


Implement checks for traits and trait impls

This is also slightly tricky, as different traits are considered fundamental (or not), which affects the kind of changes.

Some basic structural checks for traits are implemented.

The next step is checking impls of all kinds, including inherent impls.


⚠ BCR Bot has degraded performance

In 57616e7, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1096 ms

Resolved: BCR Bot performance has improved in 52d7f96.


GPU_CopyImage creates a target and delays freeing it, which causes problems

I had to spend a couple hours today debugging my application because nothing was drawing from my own OpenGL code suddenly. It appears that GPU_CopyImage creates an OpenGL target that is only free'd when the image is free'd. This is implicit, and it messes up my rendering code. I can't use my OpenGL rendering code if the most recently used target isn't the screen and hasn't been free'd. So, I have to call GPU_FreeTarget(image.target) after my call to GPU_CopyImage to fix my problem. The worst part is I think it might be related to #171 because the problem does not always happen; I can sometimes use GPU_CopyImage without freeing the target.

I keep running into this issue in different ways. I'm always able to fix it by calling FreeTarget to switch the OpenGL target back to the screen. However, I wish there was a way to make the context target the current target.

I'm able to avoid this issue with gpu.SetActiveTarget being called in spots where SDL_gpu fails to set it to null.


Rebinding of DOM structures

When a alight app is started, is there a best practice to "rebind" DOM structures when they changed?
E.g. when i have to do some jQuery code to inject DOM structures with alight directives, will these alight directives automatically detected or have i to do it manually?

AL doesn't observe DOM changes, so you should bind it manually (you can  make an observer for self).
Basically, you can call alight.bootstrap(element), then the element will be bound to a new root-scope (example http://plnkr.co/edit/KjcuZp?p=preview ).
If you have a scope you need to bind to an element, you can call alight.bind(scope, element)
docs "a few ways to bind" http://angular-light.readthedocs.org/en/latest/binding_to_dom.html
I can give you an example if you want.

Yeah, i knew the binding function, just wanted to know if the DOM will be observed for changes.
Thank you. :-)


Documentation regarding Spring Boot AutoConfiguration for Dead-Letter Processors does not work

Hi,
The code snippet in the documentation does not work. The example regarding the DeadLetterQueueExampleConfig assumes that a bean of type String is injected into the configureDeadLetterQueueFor method. This is probably not correct.  One would assume something like
@Autowired
void configure( final EventProcessingConfigurer configurer ) {
	configurer.registerDeadLetterQueue( "MyProcessingGroup", configuration -> JpaSequencedDeadLetterQueue
			.builder( )
			.processingGroup( "MyProcessingGroup" )
			.maxSequences( 256 )
			.maxSequenceSize( 256 )
			.entityManagerProvider( configuration.getComponent( EntityManagerProvider.class ) )
			.transactionManager( configuration.getComponent( TransactionManager.class ) )
			.serializer( configuration.serializer( ) )
			.build( ) );
}

The current example just leads to an exception:

Parameter 0 of method configureDeadLetterQueueFor in com.example.demo.DemoApplication required a bean of type 'java.lang.String' that could not be found.

Best regards
Nils

Hi,
The same is true for the code snippet for the EnqueuePolicyConfigurer.

Just an FYI, @nils-christian, but documentation issues within the Reference Guide would be better suited under the Reference Guide GitHub instead of the Framework's GitHub page.
Hence why I've added the "incorrect repository" label to this issue.


(semi-)supervised + densmap

Is there a theoretical reason why densmap is not allowed for supervised or sem-supervised mapping?

Yeah, uncommenting those lines worked just fine.


Update index.yml

This is to add links of 3 new articles into the landing page.
Now you also can use Ansible create storage account, disk and DB. So I changed the description from compute and networking to compute, networking and storage infrastructure.

@kyliel : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@TomArcher , this is a small change. So I directly create a PR for your review. Could you please take a look? Thank you for your effort to create 3 new articles for Ansible on Azure. This is to add their links into the landing page for following promotion. Thanks.

Thanks @kyliel. Small changes to implement parallelism and use a serial comma:
Learn how to use Ansible to create and manage Azure compute, networking and storage infrastructure.
-->
Learn how to use Ansible to create and manage Azure compute, network, and storage infrastructure.

@kyliel : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@kyliel : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@TomArcher , Thank you for your feedback. Updated the link of "learn how to use Ansible to …". Please have a review. Thank you.

Close this one since Tom already helped make those changes and get them live. Thank you Tom.


HBAT has different element offsets in DE601

See https://git.astron.nl/ro/lofar/-/blob/6715ee4113d3237fb8fab2be939a76863e74d6ce/MAC/Deployment/data/Coordinates/calc_hba_deltas.py#L148
I do not know the historical reasons for this, except that DE601 was the first non-Dutch station and has more minor oddities.

This does look like its a 90 degree error in rotation of the DE601 that is being corrected here, maybe we could solve this in the hba rotations csv file instead? Although doing so would diverge that file from LOFAR.


feat(generator): set required properties to non-nullable

Hi @zorji
Thanks for contribution and for using our generator!
Our idea was to implement Models with not nullable fields only for Responses. So for responses we should generate separate models and ONLY they should contain not nullable fields. If you want to implement nut nullable fields feature - > please follow this way.

I follow the same approach as @zorji in following the spec exactly.
@zorji  Thanks for providing the first pointers to the changes. I also changed the generateConstructorPropertiesContent function to mark constructor parameters as required if not nullable. I will test this further and contribute changes back.

Update
The initial implementation is completed. I haven't made any changes to the tests yet. I am running the compiled code in my own project to see if it works as expected.

Hi @zorji
Thanks for contribution and for using our generator!
Our idea was to implement Models with not nullable fields only for Responses. So for responses we should generate separate models and ONLY they should contain not nullable fields. If you want to implement nut nullable fields feature - > please follow this way.

@Vovanella95 do you mind provide an example of your swagger so I can ensure the final implementation meet your requirement?
I am not sure what's the best solution as this is the first time I am trying Flutter/Dart. I am thinking to have a new option, when it's enabled/disabled, it will create different type for all object used in a Request and mark them as nullable.

Hi @zorji , sure! We should generate response duplicates. For example if we have next
@Get(path: '/pet/findByStatus')
  Future<chopper.Response<List<Pet>>> _petFindByStatusGet(
      {@Query('status') required Pet? pet});

We have Pet in response and in parameters. So we should generate 2 Pet classes: Pet and Pet$Response. Result will be
@Get(path: '/pet/findByStatus')
  Future<chopper.Response<List<Pet>>> _petFindByStatusGet(
      {@Query('status') required Pet? pet});

class Pet // with nullable fields

class Pet$Response with not nullable fields

This will be universal solution. Thanks a lot for contributing. I wanted to implement this feature long time ago but can't find time for it

Great that work is put into aligning this library to the Swagger/OpenApi specification standard when it comes to nullable types. 🙌
This PR seems to create a mapping between the required attribute and nullable types.
However to my knowledge the required attribute only reflects if the API expects a property to be present in an object, regardless of its value.
A required property can therefore also be nullable.
According to the OpenApi specification V3 null is declared like
type: integer
nullable: true

Would it not be better to align with the OpenApi specification instead of using a interpretation of when something is nullable?

Great that work is put into aligning this library to the Swagger/OpenApi specification standard when it comes to nullable types. 🙌
This PR seems to create a mapping between the required attribute and nullable types. However to my knowledge the required attribute only reflects if the API expects a property to be present in an object, regardless of its value. A required property can therefore also be nullable.
According to the OpenApi specification V3 null is declared like
type: integer
nullable: true

Would it not be better to align with the OpenApi specification instead of using another interpretation of when something is nullable?

I do agree with you but I am quite new to the Dart land so I need some help here. (I work more in JavaScript/TypeScript)
What would be the right type in Dart to represent the following 2 types?
{
 "fieldA": string
  "fieldB": string | null (required = true, nullable = true)
}

{
  "fieldA": string
  "fieldB": string? (required = false, nullable = false)
}

I am not sure whether it's possible to represent so I kinda merge nullable and required into one when working with Dart. But if there is a better way, please let me know.

Hi @zorji
I've re-implemented this feature here
I will decline your PR. Anyway thanks for contributing and sorry for long answer.

Thanks for the efforts @Vovanella95
very appreicated


Labs production refactor

Description
Refactoring in prep for production launch

This looks awesome @berniedurfee! 😍 I'll definitely be digging into this soon to give it a second set of eyes.
Without having gone through it line-by-line, it seems like a lot of these are breaking changes that we'll need to push back to the student repo. Is that what you're thinking?

 In fact, lots of the functionality is still broken and needs to be updated. I'm going to push more stuff into this PR to get all the functionality working, but with an updated data model and logic.


verify aodh

After verify aodh related alarming function in net-mitaka env, I found
some ceilometer and aodh configuration should be changed to support heat
autoscaling and auto recovery:

aodh lack of cafile for https
aodh's keystone_authtoken conf parameter is not correct
aodh need disable the rest_notifier_ssl_verify for notify heat. (same as old version of ursula)
ceilometer.conf's keystone-authtoken conf parameter is not correct
add Lbaas's meter for autorecovery
aodh's haproxy httpchk path is incorrect

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Does python-memcached still need to be installed in the aodh venv?

ok to test

ok to test

retest


docs!: nuking private token

Fixes #2350
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 5585075f and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,864
868,064
3,449,576

l1_rollup_execution_gas
841,951
3,595,172
22,204,945

l2_block_processing_time_in_ms
1,029
3,888 (-1%)
15,243

note_successful_decrypting_time_in_ms
325
995
3,627 (+2%)

note_trial_decrypting_time_in_ms
28.0 (+8%)
103 (+4%)
138

l2_block_building_time_in_ms
8,952
35,859
150,446 (+1%)

l2_block_rollup_simulation_time_in_ms
6,636
26,602
105,599 (+1%)

l2_block_public_tx_process_time_in_ms
2,272
9,133 (+1%)
44,379 (+2%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
14,438 (+3%)
31,276 (+2%)

note_history_successful_decrypting_time_in_ms
2,364 (+4%)
4,804 (+8%)

note_history_trial_decrypting_time_in_ms
122 (+1%)
:warning: 148 (-29%)

node_database_size_in_bytes
1,649,622
1,195,176

pxe_database_size_in_bytes
27,188
54,187

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
43.7 (+1%)
56,577
14,745

private-kernel-ordering
21.2 (-1%)
20,137
8,089

base-rollup
851
631,605
811

root-rollup
38.2 (-1%)
4,072
1,097

private-kernel-inner
35.8 (+1%)
72,288
14,745

public-kernel-private-input
46.8
37,359
14,745

public-kernel-non-first-iteration
27.8 (-1%)
37,401
14,745

merge-rollup
0.833 (-4%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,723
27,094


[Bug]: GST calculator (SGST and CGST addition)

Describe the bug
Under GSSOC'23
The GST calculator doesn't display the SGST and CGST percent. And also the UI doesn't look too promising, so I request you to assign me this issue!
Steps to reproduce the behavior
No response
Expected behavior

It doesn't give the SGST and CGST part in it.
UI doesn't look good

Screenshots
No response
Device?
Desktop
Which OS are affected?
No response
Enter the version of your web browser
Google Chrome- Version 115.0.5790.110 (Official Build) (64-bit)
Which browsers are affected?
No response
Additional context
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Hey @avinashkranjan can you assign  me this issue!


feat: introduce firezone-connection with basic test suite

Initial version of the firezone-connection crate. To begin with, we only establish a connection in a LAN, i.e. no hole-punching, no STUN or TURN servers, just host candidates. As such, a lot of this PR is just scaffolding for setting up the test environment and the actual ConnectionPool implementation.
For the curious, I've left some TODOs where I am going to attempt extending the implementation once we start dealing with STUN and TURN servers.
I also extended CI to run these tests.

@conectado I recorded both of your comments as items in the tracking issue: https://github.com/firezone/firezone/issues/2966.

@conectado I recorded both of your comments as items in the tracking issue: #2966.

With these issues being recorded, I am merging this :tada:


"The entity name/path contains an invalid character '/'" Exception Upon Receive Endpoint Creation

Is this a bug report?
Yes
Can you also reproduce the problem with the latest version?
Yes, reproduced in 5.3.0
Environment

Operating system: Operating system: Windows 10 (16299)
Visual Studio version: VS 2017
Dotnet version: 2.2.100
MT with ASB Provider

Steps to Reproduce

In host config create receive endpoint with '/' in the path, like: cfg.ReceiveEndpoint(host, "testproject/createusercommand", configurator => ...
MT throws Argument exception

Expected Behavior
Correct work of MT as in previous versions (5.1.5). We use folder structure in Azure Service Bus to categorize command source, now it's no longer possible.

Actual Behavior
MT doesn't support this syntax any longer

Reproducible Demo
This demo crashes if you run MT.Scheduling.Subscriber console app. However if you downgrade MT to 5.1.5, everything works as expected.

I tried to compare 5.1.5 and 5.3.0 and debugged the code a to the place where the exception occurs.
Here's evaluated code in SubscribtionConfigurator.cs in 5.1.5:

And here's the same but in 5.3.0:

Why does it even try to create Subscription on topic if I'm just trying to read message from the Queue Sample_Messages/CreateUserCommand? Or am I doing something wrong?

Because message types consumed by the consumer and forwarded from topics to the queues using a subscription. I'll have to look and see what changed.


SearchAutocomplete

Closes #2084
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[x] Filled out test instructions.
[x] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:
Check SearchWithin sections of Docs and Storybook, along with tests and chromatic stories.
🧢 Your Project:

Still working on:

[ ] Tests
[ ] Chromatic stories
[ ] Selection from listbox should trigger onSubmit with new value and key
[ ] Fix style for quiet on mobile when input has value
[ ] Deduplicate focus/blur events
[ ] 'Esc' key while typing on mobile closes and re-opens tray

@reidbarber Mind getting rid of the yarn error file 😄. Also looks like you have some package json conflicts

Superseded by #2371.


feat: use Polymer for UI

Until Angular Material will be ported to Angular 2, use Polymer (Material Design Lite does not work well with dynamic websites).

I tried using Polymer with A2, but there are too many areas of conflict between the two to make it work at the moment.


Ability for superadmin to download all info

In recent past

example of downloading a CSV from an HTML table: https://github.com/HackTJ/live/blob/ed18d6a583f95574002b59f42d883d7244413bde/judge/templates/judge/scoreboard.html#L504-L574


Basic Auth

I didn't see anything in the docs or code on how to setup basic auth, do you know if this is supported?

Not sure how this issue slipped through the cracks but if y'all can get a good PR together for this, I can see about merging it.

Hey guys.  Sorry for not seeing this sooner.  I am working on this project once again.  I will see about adding basic auth.


SAK-47235 Show student answer date when grading lessons questions

In lessons tool, when an instructor goes to grade students submissions on a lessons question, it would be nice to add the student answer date.

@josecebe I have apply the changes.

Good job @PabloArrz , LGTM!


style(numericinput.tsx): fixed color problem since rebranding

Proposed Changes
fixed too dark +-sign colors and :focus background-color
Potential Breaking Changes
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

I wonder, would it be better that the background-color of the button gets a little bit darker when we hover it (like a primary or a danger button) , instead of changing the border color? Maybe my eyes are getting bad, but I feel the change is pretty subtle.


Minimum password size warning do not contains ${min_chars} insted of the value

Describe the bug
The add user form in the Volto frontend when given a password of small length shows the warning where the minimum no. of letter number is mentioned as ${min_chars} insted of the number.
To Reproduce
Steps to reproduce the behavior:

Go to volto fronend
Click on 'user icon on the bottom left corner after loging in
In the users section click on users and then click on the add user icon in the left panel.
Fill the details for the new user with a small password size let be of 3 letters
The application gives an error "Your password must contain at least ${min_chars} characters. "

Expected behaviour
There should be a number let 8 insted of the  value ${min_chars} .
Screenshots

Duplicate of #4395. This issue has now been fixed.


Old @PDF links used a key instead of name broken.

Overall this module is a live saver. Unfortunately, my old @PDF links are broken. They used an abbreviation that you were able to set in PDFoundry, instead of the full name of the PDFs journal document. Here is an example:
@PDF[HRE1|page=4]{Hellfrost Rassilon Expansion 1}
@PDF[Hellfrost Rassilon Expansion 1|page=4]{Hellfrost Rassilon Expansion 1}

The first link is how it was placed earlier by PDFoundry, the second one in as it is expected now by PDF Pager. The abbreviation is ofc something that isn't used in PDF Pager but the journals still contain the flags from PDFoundry:

Thus the data is still there. I don't know whether or not the link updater takes this into account but if not I suggest that it should. It would also be nice if PDF Pager could take the abbreviation into account.

Ah, I wasn't sure if anybody was using that particular syntax.
I will incorporate it into the next release.

Version 0.31.0 adds support for:
@PDF[pdfcode]{label}
@PDF[pdfcode|page=xx]{label}

Note that PDF Pager already supported the use of "PDF Code", but this was previously only used in PDF Pager with the ui.pdfpager.openPDFByCode function


When using inherited scenes, renaming nodes in the super scene leads to data loss in sub scene

Tested versions

Reproducible in: 4.3, 4.4dev5 (other versions weren't tested)

System information
Godot v4.4.dev5 - macOS 15.0.1 - Multi-window, 1 monitor - Metal (Forward+) - integrated Apple M1 Pro (Apple7) - Apple M1 Pro (8 threads)
Issue description
When you rename a node in a super scene, all changes to that node are lost in the sub scenes. I'd expect the changed values to be preserved. This makes inherited scenes a rather risky choice.
Steps to reproduce

Create a super scene with a child node
Create a sub scene from that super scene
Change some properties of the child node in the sub scene
Rename the child node in the  super scene

Now, all changes you have made to the child node in the sub scene are lost.
Minimal reproduction project (MRP)
inherited-scenes-test.zip

This would be solved nicely by https://github.com/godotengine/godot/pull/86960
I believe there's no check when renaming because that may be very expensive on large projects. It is indeed very annoying but I'm not sure it's a bug, or has been reported already.


Bug: Cloudflare default account ID

I was following the cloudflare custom domain setup and ran into an issue when i just had
CLOUDFLARE_API_TOKEN set i was constantly getting an error saying no account found. Did some digging and i believe there seems to be a hard requirement on having CLOUDFLARE_DEFAULT_ACCOUNT_ID set in your environment.  Not 100% sure if this is a bug or something that should be added to the docs.
Here is the code i believe responsible for this error:
https://github.com/sst/ion/blob/3fe54db05d67e486dcecff4b57d8d4854433b2f3/pkg/project/provider/cloudflare.go#L56-L66

we had an issue printing descriptive errors - fixed in v3.1.38


Remove dead links from ontology

As far as I can tell, this is just the flybrain links - http://flybrain.neurobio.arizona.edu/...
These need removing and replacing with (ideally) appropriate FBrf references if not in place already

FBrf0240283 is a PC for the flybrain expression data, you could always cite this It will be in the next FB release.

Ref is currently been used for anatomy info - cell types, neuropil details etc.
Would this be covered by the PC?

@gm119 would know

The FlyBrain site dates from the 90s (I believe Douglas wrote some of the original in emacs!).  It seems that it is no longer live and there's no obvious ref to replace. I'd just delete.

Yeah, if there are alternate refs in place, that is fine, but some terms would be left without a reference.

We should probably look for alternate refs for these.

Also http://www.neuro.uoregon.edu/doelab/neuro/... links


Solves Bug #101

:recycle: Current situation
Curtains with firmware 3.9 are not being detected anymore (#101). While analyzing the advertisement the buffer size has to be a length of 5 otherwise the curtain is not being detected. Unfortunately, the new length of the buffer size is 6.
:bulb: Proposed solution
Check for a length of 5 or 6. Some users might not be using the newest firmware yet.
:gear: Release Notes
Curtains support firmware 3.9
:heavy_plus_sign: Additional Information
Added logging capabilities during the advertisement. They can be accessed by assigning a function to onlog. Might be useful for the developers who implement this module.
Testing
Tested the curtains with firmware 3.9 by using the iobroker.switchbot-ble adapter.

@patrickbs96 Thanks so much!

This has been merged into the latest beta.


[Chore] (Portal) - GitHub login fails - redirect is empty

On portal, select GitHub auth (with dev tools open)
View URL as https://victorious-river-03cbdf403.3.azurestaticapps.net/.auth/login/github?post_login_redirect_uri=undefined
Is this an issue with SWA build or AZD deploy?
If I go back to root, I am logged in so not blocking but generally annoying.

Har attached (remove .txt extension to use)
20230925-github-social-login-victorious-river-03cbdf403.3.azurestaticapps.net.har.txt

I suspect this issue was introduced by this commit. It needs more investigations.


CSUB-25: Unit tests

Description of proposed changes:
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

Merging #306 (b622902) into dev (abd52e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #306   +/-   ##
=======================================
  Coverage   69.58%   69.58%
=======================================
  Files          37       37
  Lines        7441     7441
=======================================
  Hits         5178     5178
  Misses       2263     2263

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Fix Bootstrap UI warnings, using uib-* directives

While navigating the page, multiple warnings are visible in the browser console due to using old style directives (not namespaced with uib-), this fixes it.
@objectiser please have a look at the whole page, and see if everything is working properly and no warnings are shown. I've done it myself, but better double check.

@ammendonca Thanks!


Update signature processor to persist repository signature information into DB

Add repository signature record
Add timestamp associated with repository signature
Persist repository certificate chain in storage

The only thing we are missing on https://github.com/NuGet/NuGet.Jobs/pull/401 is the real signing certificate information to include in the example.
This essentially depends on the same data as https://github.com/nuget/engineering/issues/1189 to finish.

work left: verify in PROD

This was disabled and will be redeployed to PROD on Monday. I will verify then.


feat: ➕ add union support for Mark* methods

What
Add union support to all Mark* methods: MarkRequired, MarkOptional, MarkReadonly and MarkWritable
Why
Fix introduced bug – https://github.com/ts-essentials/ts-essentials/issues/323
Codesandbox fix – https://codesandbox.io/s/type-guard-error-forked-dyllt8?file=/src/App.tsx

@Beraliv one question on what T extends T does, isn't it will be always true?

It's a way to use distributive conditional type – https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#distributive-conditional-types
You can write it different ways, that's just a short one – https://tsplay.dev/NV4vvW