How DefaultTokenProviders Work?

Hello everyone. I'm new to Identity, I have created a new application and now I'm testing with some users.
I have found that my confirmation emails does not last more than 24 hours.
My question is: Is this the expected behavior or it is because i have a bug in my code?.
And if that is the expected behavior how can i change the token expire time.
Thank you!

Take a look at https://github.com/aspnet/Identity/issues/859, that's basically the same issue


[Spark-14314][SparkR] Add model persistence to KMeans

What changes were proposed in this pull request?
Add model persistence to KMeans SparkR
How was this patch tested?
Unit tests

Can one of the admins verify this patch?

ok to test

Test build #57176 has started for PR 12680 at commit 616a485.

@yanboliang Please LGTM if the changes look good to you:)

Test build #57176 has finished for PR 12680 at commit 616a485.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57176/
Test FAILed.

@GayathriMurali Since the feature freeze deadline is coming and there are some follow-up tasks blocked by this PR and #12683, do you mind @yanboliang sending out new PRs based on yours? Thanks!

I'm glad to help.

@GayathriMurali I sent #12778 for glm and kmeans persistence, please feel free to review and comments. Thanks!


Semver Dependency - CVE-2022-25883 Vulnerability

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
Semver, the dependent of the node-abi package has CVE-2022-25883 vulnerability. After carefully comparing 7.3.5 and 7.5.3 versions of the semver, concluded on there is no code updates needed but only version of semver need to be updated for node-abi.
NPM Audit: https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
Here is the diff that solved my problem:
diff --git a/node_modules/node-abi/package.json b/node_modules/node-abi/package.json
index 1f462bf..1bc9e4e 100644
--- a/node_modules/node-abi/package.json
+++ b/node_modules/node-abi/package.json
@@ -32,7 +32,7 @@
     "tape": "^5.3.1"
   },
   "dependencies": {
-    "semver": "^7.3.5"
+    "semver": "^7.5.3"
   },
   "engines": {
     "node": ">=10"

This issue body was partially generated by patch-package.

You don't need to use patch-package for this, those semver ranges are compatible and result in the same version being installed


Tests about support of HTML tags in translations keys with GetText

Using this library, we have noticed translation keys including HTML tags were splited into multiple translation keys in .po files.
After writing a few tests about HTML tags and the PoCompiler, we identified the problem came from an old version of gettext-parser included in our project. So, if you want to include these test in your codebase, here are them.
Pay attention we've added a dirty fix in tsconfig.json to support the use of gettext-parser import with mocha: "noImplicitAny": true

Thanks! I'm not crazy about changing noImplicitAny to true. Any way to avoid this, you think?

Actually, I believe declaration.d.ts should do the trick. I have no idea why mocha -r does not take it into account.
I think the best way to handle this is to augment gettext-parser with definition types. I've created a PR here: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43325
Once it is accepted, I will push a new version of this PR to support these types.

Now gettext-parser has a @types package (https://www.npmjs.com/package/@types/gettext-parser), here is an implementation without any declaration.d.ts.

I've already removed declaration.d.ts in my previous commit, do you prefer to keep it empty?
The double quotes have been changed.

Thanks!

Hello, I have a text with some HTML inside but it always ends up split in multiple keys.
I'm using the last version (7.0.0), extracting to json (but I tried with pot output too).
My text is looking something like that :
`
I'm so happy, Woot,
I jump around
`
Is there a limitation on which HTML tags are included or a configuration to do in order to active it  ?
The version of gettext-parser is 4.0.3 in my yarn.lock.
Could you please help me ?


Multilayer graphing attributes 0.0 explained and 0.0 unexplained to some earlier layers

It's a vanishing grads issue, I'm fairly sure. Like, the autoencoders are thinning out the grads excessively when far enough back? And zero grad tensors at any point will totally wipe out reasonable acts values, of course.

I am torn on whether this is actually a vanishing grads issue or a true observation in the data. A couple of fixing that should have worked for vanishing grads--moving everything to float 64s, loss scaling--didn't change results. But there may be an implementation level thing in autograd that I'm not fully understanding. For now, I have a quick patch to prevent fatal crashes in this case, working on the assumption that this is observation and not a bug.


Node 10.2.0 error

In Node 10.2.0 sleep is erroring out as:
/Users/jdalton/.node-gyp/10.2.0/include/node/node.h:53:10: fatal error: 'core.h' file not found
#include "core.h"  // NOLINT(build/include_order)
         ^~~~~~~~
1 error generated.

Update:
This appears to be a node-gyp bug: https://github.com/nodejs/node/issues/20921

Node v10.2.1 has been released.


Error when starting the bot

🔍 Is there an existing issue for this?

[X] I have searched the existing issues

📚 Did you install according to the wiki?
Yes
🔧 Have you made any custom changes to the software?
Yes
📦 Is this issue about a module?
Yes
🚀 How did you run the software?
start_linux.sh
🖥 Operating System
Windows
📝 OS Version
latest
🐍 Python Version
latest
🐍 Do you have multiple Python versions installed on your system?
Yes
🌐 Is this issue related to an HTTP error?
Yes
📡 Is this issue related to Pyrogram or Telethon?
Yes
🐛 Describe the bug

The bot is not working, ive install all the libraries
🎯 Expected Behavior
No response
🔄 Steps To Reproduce
No response
💬 Anything else?
No response
📜 Installed Modules (comma-separated)
MCF

Use Docker

Read WIKI:
https://github.com/masterking32/MasterCryptoFarmBot/wiki/Installation-Guide


Moving concave polygons doesn't work

The position of the decomposed convex polygons are only set in the updateConvexPolygons() method, but not when updating the position of the body.
#43

merged your MR, rebuilt, and published new version as v6.6.8 with it
thank you

Thank you for your work!

no problem thanks for contributing!
closing as resolved


feat!: progress bar theme => variant

Overview
Updated ProgressBar to use gamut-system variants + added a new "bordered" variant for le_ui_upgrades. This is a breaking change + PR to update
Check out the changes here

PR Checklist

[x] Related to designs: LE Nav Upgrades
[x] Related to JIRA ticket: GM-147
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.18f4e3.0@codecademy/gamut-labs@9.2.7-alpha.18f4e3.0@codecademy/gamut@21.3.3-alpha.18f4e3.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60240328c2b7b75b6f04919f--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.8e07d6.0@codecademy/gamut-labs@9.2.7-alpha.8e07d6.0@codecademy/gamut@21.3.3-alpha.8e07d6.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://602405c05f22ff66e1021506--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.f90932.0@codecademy/gamut-labs@9.2.7-alpha.f90932.0@codecademy/gamut@21.3.3-alpha.f90932.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60246d0b31b3406426ba67b8--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.f39715.0@codecademy/gamut-labs@9.2.7-alpha.f39715.0@codecademy/gamut@21.3.3-alpha.f39715.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6024720c99a13560ca1af8e4--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.0b0836.0@codecademy/gamut-labs@9.2.7-alpha.0b0836.0@codecademy/gamut@21.3.3-alpha.0b0836.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6025b7176ec5850d63cc0c42--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.e3a9e9.0@codecademy/gamut-labs@9.2.7-alpha.e3a9e9.0@codecademy/gamut@21.3.3-alpha.e3a9e9.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60269b15727e8d02d15c5497--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.a4162a.0@codecademy/gamut-labs@9.2.7-alpha.a4162a.0@codecademy/gamut@21.3.3-alpha.a4162a.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6026b4efc5287617c02c5b46--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.7183be.0@codecademy/gamut-labs@9.2.7-alpha.7183be.0@codecademy/gamut@21.3.3-alpha.7183be.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6026e796b8429442681c567f--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.30-alpha.b10a47.0@codecademy/gamut-labs@9.2.7-alpha.b10a47.0@codecademy/gamut@21.3.3-alpha.b10a47.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://602be888e592844a2ba813c2--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.43-alpha.30892f.0@codecademy/gamut-labs@10.0.10-alpha.30892f.0@codecademy/gamut@23.1.1-alpha.30892f.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://602d3c19bf1ccc092557218b--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.43-alpha.d12a46.0@codecademy/gamut-labs@10.0.10-alpha.d12a46.0@codecademy/gamut@23.1.1-alpha.d12a46.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.45-alpha.6a0e17.0@codecademy/gamut-labs@10.0.12-alpha.6a0e17.0@codecademy/gamut@23.2.2-alpha.6a0e17.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://602d94c306370a67525c51ba--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.45-alpha.1dfa05.0@codecademy/gamut-labs@10.0.12-alpha.1dfa05.0@codecademy/gamut@23.2.2-alpha.1dfa05.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://602d978ab686c9604fad21e0--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.45-alpha.77bde1.0@codecademy/gamut-labs@10.0.12-alpha.77bde1.0@codecademy/gamut@23.2.2-alpha.77bde1.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://602d9b794a429067cccc8493--gamut-preview.netlify.appDeploy Logs


Fix the Doc Site's broken off-canvas nav panel

Jira
N/A
Summary
Fixes the docs site's off-canvas navigation to not be 100% broken on smaller screens + adds E2E integration test to make sure this type of thing doesn't happen again.
Details
Off-canvas nav broke when the new SVG icon system started to include an element with the same #menu ID 🤦♂
How to test

Confirm doc site's off-canvas nav panel now works (opens and closes) on smaller screen sizes
Confirm that the new E2E integration test added here passes

PR was released with v2.20.0


New cop idea: Use Comparable#clamp, Array#{min,max} instead of comparison operators

Is your feature request related to a problem? Please describe.
Today I suggested using Comparable#clamp instead of comparison operators in a private project, like the following.
# bad - I feel it's not readable...
user_input > threshold ? threshold : user_input

# good - I can imagine the intention of this code easily!
user_input.clamp(..threshold)

I think RuboCop can aid with this problem, but there is no cop to detect this problem.
Describe the solution you'd like
Add a cop to detect the comparison operators' usage. The cop suggests user_input.clamp(..threshold) instead of comparison operators.
Array#min
The following code has the same meaning as the above example also.
[user_input, threshold].min

Which of these is appropriate depends on the situation. If one of the values is a threshold, clamp clarifies the intention. But if both values are user inputs, min is better than clamp.
# It's good
[user_input_a, user_input_b].min

# It's strange...
user_input_a.clamp(..user_input_b)

Therefore I think the cop should suggest both min and clamp.
Array#max and a.clamp(x..y)
By the way, the cop can detect cases for Array#max and clamp(lower_threshold..upper_threhold) (or clamp(lower_threshold, upper_threhold)).
Describe alternatives you've considered
nothing
Additional context
There are performance differences between comparison operators, clamp, and min.
require 'benchmark/ips'

require 'benchmark'
Benchmark.ips do |x|
  a = 42
  b = 43

  x.report('ops') { a > b ? b : a }
  x.report('min') { [a, b].min }
  x.report('clamp') { a.clamp(..b) }

  x.compare!
end

$ ruby -v rubocop-clamp-min-performance.rb
ruby 3.2.0 (2022-12-25 revision a528908271) [arm64-darwin21]
Warming up --------------------------------------
                 ops     2.035M i/100ms
                 min     2.203M i/100ms
               clamp   879.718k i/100ms
Calculating -------------------------------------
                 ops     20.230M (± 1.4%) i/s -    101.765M in   5.031438s
                 min     21.694M (± 1.5%) i/s -    110.157M in   5.078819s
               clamp      8.694M (± 1.9%) i/s -     43.986M in   5.060963s

Comparison:
                 min: 21694180.2 i/s
                 ops: 20229721.8 i/s - 1.07x  (± 0.00) slower
               clamp:  8694430.4 i/s - 2.50x  (± 0.00) slower

Operators and min have almost the same speed because the VM executes min with an Array literal as an optimized instruction (opt_newarray_min).
$ ruby --dump=insns -e '[a,b].min'
== disasm: #<ISeq:<main>@-e:1 (1,0)-(1,9)> (catch: false)
0000 putself                                                          (   1)[Li]
0001 opt_send_without_block                 <calldata!mid:a, argc:0, FCALL|VCALL|ARGS_SIMPLE>
0003 putself
0004 opt_send_without_block                 <calldata!mid:b, argc:0, FCALL|VCALL|ARGS_SIMPLE>
0006 opt_newarray_min                       2
0008 leave

I think this difference does not affect the entire application's performance. Probably it's a good idea that the document mention the performance.

Is the readability of Comparable#clamp better in this case? So I wonder about the replacement to Comparable#clamp.
Background:

RuboCop can parse Ruby 2.0 and above
Comparable#clamp was introduced in Ruby 2.4
Comparable#clamp introduced accepting Range as an argument in Ruby 2.7
Beginless range was introduced in Ruby 2.7

So, in terms of readability, replacing the > and < operators with min and max seems more appropriate than clamp.
Comparable#clamp is may useful for comparisons in nested arrays:
https://andycroll.com/ruby/clamp-for-min-max-values/
What do you think?

my 2¢ -- #clamp() seems more natural when it has two limits. A substitution strategy like this would make sense to me:

original
replacement

a > b ? a : b
[a, b].max

a < b ? a : b
[a, b].min

[[x, low].max, high].min
x.clamp(low, high)

Thanks for your comments, @koic and @vlad-pisanov!
Personally I like clamp to round a value with a max or min limit, even if it takes only either max or min. But I can easily imagine your opinion, min or max are preferred for this purpose.
I prefer the following replacements.

original
replacement

a > b ? a : b
[a, b].max or a.clamp(b..) (depend on context)

a < b ? a : b
[a, b].min or a.clamp(..b) (depend on context)

[[x, low].max, high].min
x.clamp(low, high)

I guess we have three options for a > b ? a : b and a < b ? a : b.

Suggest Array#max or Array#min always

@koic and @vlad-pisanov perfer

Suggest (Array#max or Array#min) and Comparable#clamp

@pocke prefer
Because I'd like to use both depending on the context

Suggest Comparable#clamp always

I'm not sure anyone prefers it...

By the way, this cop should be marked as Safe: false. Because even if a value has < method, it's not necessarily Comparable.

Because I'd like to use both depending on the context

Hm, are there any use cases where you prefer a.clamp(b..)  over [a, b].max?

There is still consider about Comparable#clamp. On the other hand, it seems common to prefer [a, b].max to a > b ? a : b.
First, I opened PR #11341 to create a cop that enforces [a, b].max. Because I think it's better to have a separate cop for Comparable#clamp. This is because the different Ruby versions that can be targeted.

Because I'd like to use both depending on the context

Hm, are there any use cases where you prefer a.clamp(b..) over [a, b].max?

Ah, sorry, I forgot to describe the context. I think clamp is more appropriate if one of the values is a limit or threshold.
For example: Limit per page on pagination
MAX_ITEMS_PER_PAGE = 100

def index
  raw_per_page = params[:per_page].to_i

  # With `clamp`
  per_page = raw_per_page.clamp(..MAX_ITEMS_PER_PAGE)

  # With `min`
  per_page = [raw_per_page, MAX_ITEMS_PER_PAGE].min

  @items = Item.all.per_page(per_page)
end

min means "Pick out minimum count from raw_per_page and MAX_ITEMS_PER_PAGE".
clamp means "Limit raw_per_page to MAX_ITEMS_PER_PAGE".
In this case, I prefer clamp to min because I feel clamp is more intentional. min just means minimum value, but clamp expresses that the argument is a limit value.

Because I think it's better to have a separate cop for Comparable#clamp. This is because the different Ruby versions that can be targeted.

Well, if a.clamp(..b) case is also acceptable, two cops warn the same code with different messages, right?
For example, for per_page = per_page > MAX_ITEMS_PER_PAGE ? MAX_ITEMS_PER_PAGE : per_page, Style/MinMaxComparison cop suggests using min, but Style/ClampComparison cop suggests using clamp.
It may be confusing.

Thanks for explaining your use case.
I wonder if it may be a bit difficult for user to choose whether to use {min, max} or clamp. So, I think it would be clear to user to provide autocorrection for {min, max}. {min, max} are traditional simple methods.
And I'm also concerned about the slowness of clamp. Maybe only documented for clamp against # good case and text in #11341.
So the next steps are:

Add documentation about clamp to #11343
Provides a new cop proposing x.clamp(low, high) instead of [[x, low].max, high].min. It's a different police than #11341

It may be confusing.

This probably won't cause that confusion. OTOH, the only my concern is that {min, max} is chosen for use cases where clamp is preferable, but user can refactor it to clamp userself.
What do you think of this design, which is different from the original intention of the issue?

So the next steps are:

It looks good, thanks for your suggestion!

OTOH, the only my concern is that {min, max} is chosen for use cases where clamp is preferable, but user can refactor it to clamp userself.

I think so too. The user maybe doesn't notice the existence of clamp. I think your suggestion is a good compromise 👍

And I'm also concerned about the slowness of clamp.

min and max are also slower than the operators on old Rubies.
$ docker run --rm -it rubylang/all-ruby env ALL_RUBY_BINS='ruby-2.0.0-p648 ruby-2.1.10 ruby-2.2.10 ruby-2.3.8 ruby-2.4.10 ruby-2.5.9 ruby-2.6.10 ruby-2.7.7 ruby-3.0.5 ruby-3.1.3 ruby-3.2.0' ./all-ruby -rbenchmark -we 'a=42;b=43;p Benchmark.realtime{100000.times{[a,b].min}}; p Benchmark.realtime{100000.times{a > b ? b : a}}'
ruby-2.0.0-p648 0.195302542
                0.035441417
ruby-2.1.10     0.175730625
                0.035914958
ruby-2.2.10     0.194358040811494
                0.04013233305886388
ruby-2.3.8      0.18656654190272093
                0.035134333884343505
ruby-2.4.10     0.03193425014615059
                0.03173887496814132
ruby-2.5.9      0.03606400010176003
                0.03370579099282622
ruby-2.6.10     0.03306250018067658
                0.028806084068492055
ruby-2.7.7      0.030842124950140715
                0.02505087503232062
ruby-3.0.5      0.03810958401300013
                0.02866741712205112
ruby-3.1.3      0.04034850001335144
                0.03262170893140137
ruby-3.2.0      0.028015041025355458
                0.027625084156170487

min is slower than the operators on Ruby 2.3 or older. Should we treat this difference on the cop's implementation?
I guess it does not affect the performance of an entire application in most cases. It's enough that the documentation mentions the performance.

min and max are also slower than the operators on old Rubies.

Hm, I think it depends on the operands. For example, a > b ? a : b evaluates to either a or b twice. So if a or b is a slow method call, I think max is better. In other words, the results may change depending on the benchmark data or usage context, right?

min and max are also slower than the operators on old Rubies.

Hm, I think it depends on the operands. For example, a > b ? a : b evaluates to either a or b twice. So if a or b is a slow method call, I think max is better. In other words, the results may change depending on the benchmark data or usage context, right?

True. The summary is the following:

Replacing min has a performance risk until Ruby 2.4 because it doesn't have the optimized instruction.

OTOH, it may improve the performance as you said.

Replacing min has no performance risk since Ruby 2.4 because it has the optimized instruction.

It also may improve the performance as you said.

I'm not sure the document should describe the performance. It will be helpful to decide to follow the cop. But it may too detailed.

JFYI, this issue is solved by #11341, #11364, and #11365.


Conversion of an initial plan-generator-test test to cgtest format.

I've also played around with pre-extraction of interesting symbols in
the test-runner, I think this is worthwhile as it leads to more readable
require statements but I'm happy to hear alternative opinions :)

We're breaking abstractions a bit by putting test specific regexes in codegen-unit-tests-runner-test.ts , but it's ok, we can generalize if it ever become unmanageable.

\gcbrun


fix(share/eds): use cached accessors in GetCAR and GetDAH

Closes #1514 . This PR enables accessor cache usage for GetCAR and GetDAH. This will allow shrexeds and shrexnd servers to only require opening the underlying file once (until removed from cache). If many peers request the EDS at once, the server previously needed to open the file each time.
Will still require a dependency bump of our dagstore fork for the new test to not fail - so draft until then. Related: https://github.com/celestiaorg/dagstore/pull/2

Codecov Report

Merging #2000 (896702f) into main (f18b1ab) will decrease coverage by 0.24%.
The diff coverage is 20.28%.

@@            Coverage Diff             @@
##             main    #2000      +/-   ##
==========================================
- Coverage   54.95%   54.72%   -0.24%
==========================================
  Files         216      217       +1
  Lines       13925    14027     +102
==========================================
+ Hits         7653     7676      +23
- Misses       5460     5531      +71
- Partials      812      820       +8

Impacted Files
Coverage Δ

cmd/celestia/main.go
47.05% <ø> (ø)

nodebuilder/node/admin.go
26.66% <0.00%> (ø)

nodebuilder/settings.go
75.00% <0.00%> (-7.36%)
:arrow_down:

cmd/celestia/rpc.go
7.03% <7.03%> (ø)

nodebuilder/p2p/metrics.go
8.82% <8.82%> (ø)

share/eds/accessor_cache.go
49.09% <25.00%> (-7.78%)
:arrow_down:

share/eds/eds.go
67.19% <40.00%> (-1.87%)
:arrow_down:

cmd/flags_misc.go
48.40% <46.66%> (-0.19%)
:arrow_down:

libs/utils/readerat.go
62.50% <62.50%> (ø)

api/rpc/client/client.go
72.72% <100.00%> (-9.63%)
:arrow_down:

... and 5 more

... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Was trying to find a quick way to solve the access of internal fields but nothing obvious there

@renaynay , it closes both the underlying reader (the mount), as well as the mmap reader


HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId

HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
322
master passed

+1
compile
26
master passed

+1
checkstyle
33
master passed

+1
shadedjars
271
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
24
master passed

0
spotbugs
70
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
67
master passed

_ Patch Compile Tests _

+1
mvninstall
299
the patch passed

+1
compile
26
the patch passed

+1
javac
26
the patch passed

+1
checkstyle
32
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
295
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
924
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
24
the patch passed

+1
findbugs
82
the patch passed

_ Other Tests _

+1
unit
116
hbase-client in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

2990

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 72f80246dcb0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 1ea5d8be9e

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/1/testReport/

Max. process+thread count
293 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
322
master passed

+1
compile
25
master passed

+1
checkstyle
33
master passed

+1
shadedjars
270
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
24
master passed

0
spotbugs
71
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
68
master passed

_ Patch Compile Tests _

+1
mvninstall
293
the patch passed

+1
compile
26
the patch passed

+1
javac
26
the patch passed

+1
checkstyle
32
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
302
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
965
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
22
the patch passed

+1
findbugs
71
the patch passed

_ Other Tests _

+1
unit
109
hbase-client in the patch passed.

+1
asflicense
14
The patch does not generate ASF License warnings.

2980

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d63915a20824 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 0438fdc0f6

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/2/testReport/

Max. process+thread count
291 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
54
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
353
master passed

+1
compile
28
master passed

+1
checkstyle
34
master passed

+1
shadedjars
279
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
24
master passed

0
spotbugs
74
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
73
master passed

_ Patch Compile Tests _

+1
mvninstall
302
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

+1
checkstyle
31
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
272
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
994
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
24
the patch passed

+1
findbugs
84
the patch passed

_ Other Tests _

+1
unit
118
hbase-client in the patch passed.

+1
asflicense
12
The patch does not generate ASF License warnings.

3087

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f0afccca517c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / ec68bf30ba

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/3/testReport/

Max. process+thread count
291 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
36
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
325
master passed

+1
compile
26
master passed

+1
checkstyle
31
master passed

+1
shadedjars
274
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
26
master passed

0
spotbugs
71
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
70
master passed

_ Patch Compile Tests _

+1
mvninstall
295
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

+1
checkstyle
32
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
270
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
918
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
23
the patch passed

+1
findbugs
70
the patch passed

_ Other Tests _

+1
unit
109
hbase-client in the patch passed.

+1
asflicense
14
The patch does not generate ASF License warnings.

2919

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 663d2516a891 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 5106f2826e

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/4/testReport/

Max. process+thread count
295 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
50
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
1
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
420
master passed

+1
compile
29
master passed

+1
checkstyle
38
master passed

+1
shadedjars
351
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
27
master passed

0
spotbugs
86
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
84
master passed

_ Patch Compile Tests _

+1
mvninstall
380
the patch passed

+1
compile
28
the patch passed

+1
javac
28
the patch passed

+1
checkstyle
35
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
351
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1185
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
24
the patch passed

+1
findbugs
90
the patch passed

_ Other Tests _

+1
unit
122
hbase-client in the patch passed.

+1
asflicense
15
The patch does not generate ASF License warnings.

3707

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 798262e8c916 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/5/testReport/

Max. process+thread count
289 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
343
master passed

+1
compile
26
master passed

+1
checkstyle
33
master passed

+1
shadedjars
288
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
25
master passed

0
spotbugs
71
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
69
master passed

_ Patch Compile Tests _

+1
mvninstall
298
the patch passed

+1
compile
27
the patch passed

+1
javac
27
the patch passed

+1
checkstyle
30
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
273
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
986
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
24
the patch passed

+1
findbugs
76
the patch passed

_ Other Tests _

+1
unit
116
hbase-client in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

3033

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ba45ba6e9136 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/6/testReport/

Max. process+thread count
291 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
373
master passed

+1
compile
25
master passed

+1
checkstyle
34
master passed

+1
shadedjars
300
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
24
master passed

0
spotbugs
78
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
76
master passed

_ Patch Compile Tests _

+1
mvninstall
341
the patch passed

+1
compile
26
the patch passed

+1
javac
26
the patch passed

+1
checkstyle
33
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
304
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1038
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
22
the patch passed

+1
findbugs
83
the patch passed

_ Other Tests _

+1
unit
104
hbase-client in the patch passed.

+1
asflicense
12
The patch does not generate ASF License warnings.

3296

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 8c762a06e6e2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 83e77940c5

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/testReport/

Max. process+thread count
262 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
357
master passed

+1
compile
25
master passed

+1
checkstyle
33
master passed

+1
shadedjars
305
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
23
master passed

0
spotbugs
76
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
74
master passed

_ Patch Compile Tests _

+1
mvninstall
337
the patch passed

+1
compile
28
the patch passed

+1
javac
28
the patch passed

+1
checkstyle
34
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
303
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1249
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
21
the patch passed

+1
findbugs
78
the patch passed

_ Other Tests _

+1
unit
112
hbase-client in the patch passed.

+1
asflicense
12
The patch does not generate ASF License warnings.

3421

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e30f2ddeb9f8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / f6a4c66d13

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/testReport/

Max. process+thread count
263 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
339
master passed

+1
compile
27
master passed

+1
checkstyle
32
master passed

+1
shadedjars
281
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
25
master passed

0
spotbugs
71
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
68
master passed

_ Patch Compile Tests _

+1
mvninstall
301
the patch passed

+1
compile
27
the patch passed

+1
javac
27
the patch passed

+1
checkstyle
31
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
289
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
941
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
23
the patch passed

+1
findbugs
74
the patch passed

_ Other Tests _

+1
unit
108
hbase-client in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

2992

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 6357471d1a2f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 090c55f3ff

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/9/testReport/

Max. process+thread count
295 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/9/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
53
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
427
master passed

+1
compile
29
master passed

+1
checkstyle
39
master passed

+1
shadedjars
342
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
27
master passed

0
spotbugs
85
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
83
master passed

_ Patch Compile Tests _

+1
mvninstall
329
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

+1
checkstyle
30
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
282
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
967
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
22
the patch passed

+1
findbugs
75
the patch passed

_ Other Tests _

+1
unit
111
hbase-client in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

3252

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux be9af7fd2ba4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / ee5cf0d209

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/10/testReport/

Max. process+thread count
289 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/10/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
38
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
416
master passed

+1
compile
29
master passed

+1
checkstyle
42
master passed

+1
shadedjars
350
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
31
master passed

0
spotbugs
96
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
93
master passed

_ Patch Compile Tests _

+1
mvninstall
387
the patch passed

+1
compile
30
the patch passed

+1
javac
30
the patch passed

+1
checkstyle
40
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
365
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1238
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
28
the patch passed

+1
findbugs
98
the patch passed

_ Other Tests _

+1
unit
128
hbase-client in the patch passed.

+1
asflicense
14
The patch does not generate ASF License warnings.

3787

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 6ad5c16089f5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / b642ee0418

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/11/testReport/

Max. process+thread count
263 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/11/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
76
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
364
master passed

+1
compile
25
master passed

+1
checkstyle
36
master passed

+1
shadedjars
313
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
29
master passed

0
spotbugs
90
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
87
master passed

_ Patch Compile Tests _

+1
mvninstall
344
the patch passed

+1
compile
29
the patch passed

+1
javac
29
the patch passed

+1
checkstyle
36
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
306
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1067
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
21
the patch passed

+1
findbugs
83
the patch passed

_ Other Tests _

+1
unit
117
hbase-client in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

3355

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f1e94474c174 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 97fbaa658e

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/12/testReport/

Max. process+thread count
257 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/12/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
370
master passed

+1
compile
29
master passed

+1
checkstyle
39
master passed

+1
shadedjars
308
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
25
master passed

0
spotbugs
77
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
74
master passed

_ Patch Compile Tests _

+1
mvninstall
334
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

+1
checkstyle
33
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
304
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1048
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
28
the patch passed

+1
findbugs
97
the patch passed

_ Other Tests _

+1
unit
125
hbase-client in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

3306

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 3677b57afea5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 345c21dbe7

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/13/testReport/

Max. process+thread count
262 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/13/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
38
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
405
master passed

+1
compile
30
master passed

+1
checkstyle
43
master passed

+1
shadedjars
365
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
29
master passed

0
spotbugs
98
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
95
master passed

_ Patch Compile Tests _

+1
mvninstall
402
the patch passed

+1
compile
38
the patch passed

+1
javac
38
the patch passed

+1
checkstyle
47
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
311
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1053
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
21
the patch passed

+1
findbugs
80
the patch passed

_ Other Tests _

+1
unit
107
hbase-client in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

3502

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 909b404469ce 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / a5ef6b287c

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/14/testReport/

Max. process+thread count
263 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/14/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
411
master passed

+1
compile
28
master passed

+1
checkstyle
39
master passed

+1
shadedjars
336
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
26
master passed

0
spotbugs
85
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
82
master passed

_ Patch Compile Tests _

+1
mvninstall
415
the patch passed

+1
compile
28
the patch passed

+1
javac
28
the patch passed

+1
checkstyle
37
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
347
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1210
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
25
the patch passed

+1
findbugs
86
the patch passed

_ Other Tests _

+1
unit
128
hbase-client in the patch passed.

+1
asflicense
15
The patch does not generate ASF License warnings.

3728

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 551a230f13cb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / d32bf8daed

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/15/testReport/

Max. process+thread count
292 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/15/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
59
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
413
master passed

+1
compile
29
master passed

+1
checkstyle
38
master passed

+1
shadedjars
349
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
27
master passed

0
spotbugs
89
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
86
master passed

_ Patch Compile Tests _

+1
mvninstall
385
the patch passed

+1
compile
28
the patch passed

+1
javac
28
the patch passed

+1
checkstyle
37
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
334
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1154
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
24
the patch passed

+1
findbugs
75
the patch passed

_ Other Tests _

+1
unit
111
hbase-client in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

3544

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/541

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 3b50c8ee4ad5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh

git revision
master / 8e8bd8b254

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/16/testReport/

Max. process+thread count
286 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/16/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet Thankyou for the suggestions. I have made the necessary changes.


Fixed bugs. Yes and no both restarted the game and zero didn't skip bet

In trying as keep as close to the spirit of the original game as possible, there is no handling for an invalidly low number.
A zero input prints "chicken" and skips the third card and starts over with 2 new initial cards.
After the wad is blown, anything but a yes answer  to the "Try again" question ends the game

I think it's OK to add better error handling.. we don't need to copy the bad behaviors of the old code!


Setup GitHub Actions for CI

Setup GitHub Actions to Trigger build for PR and when pushed to master.
At this moment this PR sets up:

Necessary packages
Makes a docker build
Tags the docker build
And pushes to a private docker repository

Further work is still remaining to host te docker build once this PR is merged.

Build fails as the secrets are not passed to PRs created from a fork.
Successful build can be found here: https://github.com/subhransu/jobsgowhere/runs/571512423

https://stackoverflow.com/questions/30970591/automatic-docker-login-within-a-bash-script/30971862 <-- this might help to fix docker login issue @subhransu

@kajalsinha I am using the same here
but the secrets won't be passed if it is a PR from a forked repo.
This workflow is working properly so we just need to merge the PR and then it will work once it's merged.

Closing this PR as created a branch on this repo and sent #48
This addresses the changes requested on this PR as well.


Updated spelling errors

Project-Guidance! 🎊🎈
Welcome! 🎉
Thank you for visiting our repository! We're excited to have you here. If you find this project useful, please consider giving it a star! ⭐
🎉 Have you reviewed the Contributing Guidelines? 🤔 (Required)

[x] YES
[ ] NO

📝 Description
 changed the spelling errors in desktop applications file
🔧 Fixes #1590  (Required)

🏷 Initiative Participation (Required)
This pull request is associated with the following initiative. Please choose the one you are contributing to:

[ ] 🌸 GSSoC (Girl Script Summer of Code)
[x] 🌼 GSSoC 2024 Extd.
[x] 🍂 Hacktoberfest 2024
[ ] ❄ Script Winter of Code (SWoC)
[ ] ⛄ Winter of Blockchain (WoB)
[x] 🙋♂ Personal
[ ] 📌 Other (please specify): _______________

please review it this request.


Allow overriding Fargate Profile name and Fargate Role name. Update Fargate Profile naming

what

Allow overriding Fargate Profile name and Fargate Role name
Add the provide Kubernetes namespace to the Fargate Profile name when it's derived from the context

why

Allow the caller of the module to specify the names of the Fargate Profile and Fargate IAM Role (instead of deriving them from the context)
Allow provisioning multiple Fargate Profiles into the same account (using the same context values) but for different Kubernetes namespaces

/test all


WIP: added retry parameter

launch implementation for https://github.com/fabric8-launcher/ngx-launcher/pull/277


Revamp tile palette

It'd be nice if the tile palette used the same sort of view as the editor.
It'd also be nice to add some other features like wrapping, easier zooming, etc

Related issue: #75


Develop an abstract rate_constant_t type for rate constant calculations

My thought is that the core is already present in src/rate_constant_functions.F90. If we combined the rate constant parameters and the rate constant functions so that the json could be used to construct rate constant function pointers, we'd have what we need for the abstract type.  But I'm not sure as to how the json file is read and the factory built to construct the runtime pointers to functions.

I will set up a driver that passes the json config data to a simplified kinetics_t type constructor. the simple kinetics_t type will only have data members and functions that are related to the rate constants (the other functions and data can remain the same as they currently are). and the kinetics_t constructor will use the rate_constant_factory to build the set of rate_constant_t objects.

The photodecomposition rate constants have significantly different sources of data and dependencies than the rate constants for chemical reactions.  This will be interesting.

Hi @AndrewJConley - I think the code is roughed in. It's in etc/rate_constant_demo/. (I already merged it into micm/master because I needed to fix a problem with the musica-core library in micm). Let me know if you have any questions about the setup and if this is what you were expecting. You should be able to build and run the code with:
cd micm/etc/rate_constant_demo
mkdir build
cd build
ccmake ..
make
./rate_constant_demo ../config.json

Stacy is working to bring the rate constants for photolysis into the form described here: https://docs.google.com/document/d/14vnBbO2_gBaKVMbymh2e0DwCHGas_zSZ0U9DB3nQnc0/edit?usp=sharing

draft rate constant type was created and used as a template in the photolysis code refactor. closing issue


Stack overflow while generating client from large schema

Hi,
I tried to generate a client for the vSphere Web Services API and I got a stack overflow error:
❯ libninja gen -l rust -g sportfloh/vsphere -o vsphere vsphere ../vi_json_openapi_specification_v8_0_1_0.yaml
...
thread 'main' has overflowed its stack
fatal runtime error: stack overflow
[1]    240 abort      libninja gen -l rust -g sportfloh/vsphere -o vsphere vsphere

vSphere Web Services API OpenAPI Schema
Cheers

Thank you! Can you share the exact link to the yaml? The link points to a huge documentation site, and I can't find the YAML document therein.

Sorry, yes ofcorse:
https://vdc-download.vmware.com/vmwb-repository/dcr-public/f6932c47-5212-4866-b3e7-e29d81a68e51/9b5473f2-3c7f-4ab8-b374-827c8c89388e/vi_json_openapi_spec_v8_0_1_0.zip

Realistically not sure when I'll have time to prioritize this. Happy to answer Qs if you investigate the problem.

I got this when the the schema was potentially recursive, e.g with a parameter like
struct Item{
   name: String
   related_item: Option<Item>
}```

And it was when generating the example that it overflowed (you can kinda see why ;)

Anyway I have a PR with a fix that WorksForMe(tm) or you might find that disabling examples does it for you


feat!: atomic memory opcodes

Description
Problem*
Add new ACIR opcodes doing atomic memory operation. They allow ACVM to perform stepwise solving for dynamic memory.
Resolves
Summary*

Additional Context

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Marking this breaking as it will change the ACIR serialisation


Add pyup config

Let's add # pyup: ignore to itsdangerous in requirements-app.txt (and re-freeze).


Remote Citrus test report contains double entries

Hi Christoph,
during remote test execution (Citrus tests inside a .war) with the new citrus-remote-maven-plugin I have noticed that the Citrus test report contains double entries.
INFO  | CITRUS TEST RESULTS
INFO  |
INFO  |  UserManagementServiceIT.createUser .......................... SUCCESS
INFO  |  UserManagementServiceIT.createUser .......................... SUCCESS
INFO  |  UserManagementServiceIT.createUserConflict .................. SUCCESS
INFO  |  UserManagementServiceIT.createUserConflict .................. SUCCESS
INFO  |  UserManagementServiceIT.deleteUser .......................... SUCCESS
INFO  |  UserManagementServiceIT.deleteUser .......................... SUCCESS
INFO  |  UserManagementServiceIT.deleteUserNotFound .................. SUCCESS
INFO  |  UserManagementServiceIT.deleteUserNotFound .................. SUCCESS
INFO  |  UserManagementServiceIT.editUser ............................ SUCCESS
INFO  |  UserManagementServiceIT.editUser ............................ SUCCESS
INFO  |  UserManagementServiceIT.getAllUsers ......................... SUCCESS
INFO  |  UserManagementServiceIT.getAllUsers ......................... SUCCESS
INFO  |
INFO  | TOTAL: 12
INFO  | FAILED:   0 (0.0%)
INFO  | SUCCESS:  12 (100.0%)

I have only 6 tests but the report contains 12.
I have used a port listener and checked the HTTP requests. The tests do not appear to be executed twice. It seems that only the report itself is buggy.
Also, if I leave the app running and execute the tests with the plugin again, the report will contain 24 test results.

This is because you executed tests two times at the same remote server instance without redeployment. The remote server caches old results and does not clear test results for each test run.

The output is from the very first run. If I execute the tests again on the same remote server without redeployment, the output will show me 24 tests. If I do that a third time, 36 tests, and so on.

Must have been a duplicate add of the reporter in test suite listeners. I changed the logic in test suite listeners in order to prevent this duplicates when adding new reporters


move swift:4 to swift:4.0 add swift:4.1

With the recent release of swift 4.1 in Xcode Beta.
I think is close to done, having swift:4 it would be vague which version of swift is the runtime referring.
This issue to track the work to change the kind to swift:4.0 and the image name to action-swfit-v4.0

We can try add swift:4.1 as experimental which is still to be release, and create our image base on ubuntu until an official version of docker image with swift 4.1 is available.
This way we try to find any issues with swift 4.1 very early.


Module resolution: Module resolved to indirect dependency rather than direct local one when versions are the same

🔎 Search Terms
"local module resolution", "module resolution same version"
🕗 Version & Regression Information

Noticed in 5.6.3, also reproduced with next, 4.6, 4.8, 5.0.
I reviewed the FAQ for entries including "resol".

⏯ Playground Link
https://github.com/grigasp/ts-deps-issue
💻 Code
Package<EMAIL_ADDRESS>is released with the following:
export type A1 = number;

Locally we have this package at the same version, but with an additional type:
export type A1 = number;
export type A2 = string;

Locally we also have a package b, that has a dependency on a released version of<EMAIL_ADDRESS>and exports the following type:
import { A1 } from "a";
export type B = A1;

Finally, locally we also have a package c, that has dependencies on local workspace versions of packages b and a and imports types from them both:
// Switching order of these import fixes the build
import { B } from "b";
import { A2 } from "a";

const b: B = 1;
const a2: A2 = "a2";

🙁 Actual behavior
When building package c, the build fails with error:
><EMAIL_ADDRESS>build
> tsc

src/index.ts:3:10 - error TS2305: Module '"a"' has no exported member 'A2'.

3 import { A2 } from "a";

🙂 Expected behavior
When building package c, TypeScript resolves package a to our local version which does have the A2 type, and the build succeeds.
Additional information about the issue
I tried running tsc -traceResolution for package c and it seems that both - released package and the local one - are assigned the same Package ID:
...
======== Resolving module 'a' from 'E:/temp/ts-deps-issue/packages/c/src/index.ts'. ========
...
======== Module name 'a' was successfully resolved to 'E:/temp/ts-deps-issue/packages/a/lib/index.d.ts' with Package ID<EMAIL_ADDRESS>========

======== Resolving module 'a' from 'E:/temp/ts-deps-issue/packages/b/lib/index.d.ts'. ========
...
======== Module name 'a' was successfully resolved to<EMAIL_ADDRESS>with Package ID<EMAIL_ADDRESS>========
...

I suppose that could cause a cache collision or something like that.

I suppose that could cause a cache collision or something like that.

Exactly; we deduplicate packages by name and version; a different symptom of the same cause was closed as a design limitation here: https://github.com/microsoft/TypeScript/issues/51976. I’m not sure what we could do about this.

I suppose that could cause a cache collision or something like that.

Exactly; we deduplicate packages by name and version; a different symptom of the same cause was closed as a design limitation here: #51976. I’m not sure what we could do about this.

Just throwing out a couple of ideas...

Could you use full path to the module for package id? So instead of<EMAIL_ADDRESS>it would be E:/temp/ts-deps-issue/packages/a/lib/index.d.ts or<EMAIL_ADDRESS>

Could you detect that the module is from a workspace package and for such packages use a special version identifier, e.g. a/lib/index.d.ts@workspace?

We deduplicate packages for a reason, so defeating the deduplication is just trading one problem for another. Including the same code multiple times can cause bogus errors. While it would fix your specific use case here, it could just as easily create duplicate declaration errors for someone else.

Isn't it the job of package manager to do that?

This hasn't always been the case; older versions of npm would not deduplicate when sub-dependencies needed to be nested, but it's a huge performance problem for TS if we need to e.g. resolve 30 copies of<EMAIL_ADDRESS>in different subfolders.
You can argue that an ideally set-up package manager wouldn't do this, but I'd also argue that a correctly set-up package manager can't produce two packages with the same version and the same name but with different contents, which is the setup your repro depends on. It doesn't really fly to say we should rely on one invariant while ignoring the other.


Avoid installing Python build dependencies into a non-virtual environment

In eng/psakefile.ps1, we install tox using python -m pip install tox. We run this command without creating a virtual environment ourselves, so it installs into whatever environment the build script is run from. We should avoid automatically installing things into the user's environment, e.g. by creating our own virtual environment first, or by requiring tox to already be installed.

Fixed in #119


FAQ where can I find information about versions of external components of PomBase

FAQ where can I find information about versions of external components of PomBase
(or similar)
Some blurb
Link to https://www.pombase.org/internal-details
Also
Where can I find information about PomBase data versions?
Preview site link is non-functional

when #1573 done

fixed link; not much enthusiasm to change much else


Roll Packages from 4926c0f8bd99 to 54dd8883c5cf (2 revisions)

https://github.com/flutter/packages/compare/4926c0f8bd99...54dd8883c5cf
2024-09-25<EMAIL_ADDRESS>[flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688)
2024-09-24<EMAIL_ADDRESS>[go_router] Fixed TabView swiping in custom stateful shell route example  (flutter/packages#7583)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Use one sampler for split preprocessing pipeline

In the split preprocessing pipelines introduced by #2986 each preprocessing chain contains a sampler as each chain is generated by make_pipeline() and currently the y output to the final estimator is taken from the categorical chain's sampler. This might be an issue as oversampling is handled differently for categorical and numeric data as detailed in this conversation. This issue tracks investigating the effects of choosing the categorical sampler and ensuring there is no performance lost from doing so.

@freddyaboulton this tracked the double sampler issue but not sure why I closed this. I can open this up to track double sampler but a more generalized issue might be better as its touching multiple projects.

@jeremyliweishih Thank you for reopening ! I've renamed it to be more general and also linking with #2997 which I think is the root cause of these kinds of issues.

We should prioritize this as I think there may be some performance implications to this.
Repro

Comment out this line in _create_fast_fina

    def _create_fast_final(self):
        estimators = [
            estimator
            for estimator in get_estimators(self.problem_type)
            #if estimator not in self._naive_estimators()
        ]

Run Automl search on the fraud dataset

from evalml.automl import AutoMLSearch
from evalml.preprocessing import split_data
import pytest
from evalml.demos import load_fraud

X, y = load_fraud(1000)

X_train, _, y_train, _ = split_data(X, y, "binary", test_size=.5)

automl = AutoMLSearch(X, y, "binary", verbose=True, automl_algorithm="default")
automl.search()

You'll notice that the non-split RF pipeline does better than the split RF pipeline
Non split
Random Forest Classifier w/ Label Encoder + DateTime Featurizer + Imputer + One Hot Encoder + Oversampler + RF Classifier Select From Model:
	Starting cross validation
	Finished cross validation - mean Log Loss Binary: 0.253

Split
Random Forest Classifier w/ Label Encoder + Select Columns By Type Transformer + Label Encoder + DateTime Featurizer + Imputer + Oversampler + Select Columns Transformer + Select Columns Transformer + Label Encoder + Imputer + One Hot Encoder + Oversampler:
	Starting cross validation
	Finished cross validation - mean Log Loss Binary: 0.277

These two pipelines should perform the same right? One difference that comes to mind is that the non-split pipeline only has one oversampler. It could also be that the feature selector in the non-split case is selecting predictive features for every fold. In the split case, we select the ones for the third fold.
AC:

Why do these pipelines score differently?
Have one sampler for split pipelines. Even if there isn't a score impact of having two samplers, I think we should only have one sampler. However, I can be convinced otherwise if someone can show there isn't a score impact or search time impact to having two samplers.


Update copy and blit methods

For # https://github.com/uber/luma.gl/issues/815

Background
NOTE: requires https://github.com/uber/luma.gl/pull/829
Update to use new copy/blit API

Change List

How much does this affect the bundle size? Can you try bundle the website?

We may need to fix tree shaking in luma.gl (Turn on "sideEffects": false in package.json and fix the bug) to see a difference.


Do you have a plan to simplify code use async/await + class as node v7.6.0 has supported it natively

I use pomelo (https://github.com/NetEase/pomelo) before. But they still use es5.

Hey @SteveCruise, there are a few places we use classes in the server, however we don't have plans to introduce promises.
In the client we've had a few different ideas such as:

returning promises when no callback is given
providing a wrapper module that "promisifies" the api

Interested to get the communities opinion on these.


Only cut working, doesnt paste anything

Hi. I managed to get this app working on my iPhone XS and Windows PC. It cuts the image and i can see the output png and jpg files on server. But it doesnt continue on paste command and i cant see it on my phone to paste on photoshop. it just gets stuck on cut and i have to restart the app for a new cut.  Also it throws an 'atob' error which i said on another issue post.

make sure you run basnet-http and server in localhost

#24
hope this will help you
scroll down

Hi. I managed to get this app working on my iPhone XS and Windows PC. It cuts the image and i can see the output png and jpg files on server. But it doesnt continue on paste command and i cant see it on my phone to paste on photoshop. it just gets stuck on cut and i have to restart the app for a new cut. Also it throws an 'atob' error which i said on another issue post.

Got exactly the same error, i have no error at all, it's cut, i can find : cut_received.png, cut_mask.png, cut_current.png in server file but nothing appear on my phone and i can't past anything

@CalyphoZz
I experienced the same thing and found out there's a timing issue.
You have to take a picture and keep your finger on the screen until you see the cropped image appear. Then point the camera at your computer and release to paste.
If you lift your finger before the server responds, the phone will try to paste an empty image.https://github.com/cyrildiagne/ar-cutpaste/blob/f556698d1566443b6fc78651440a415e63b63187/app/App.tsx#L146-L155


Feature/global queue args

Closes #49
I'm think we could do this instead of #48 for our Heroku Review App use case.

What exactly would this do as an alternative to #48? Does it just not hardcode the queue durability, and let us send that, as well as any other configuration manually?

See https://github.com/giftcardzen/la_gear/issues/49#issuecomment-143495439 and https://github.com/jondot/sneakers/issues/165

This can be merged if approved even if #51 isn't merged yet.


Update version and Changelog

          2 Warnings

:warning:
This PR contains release modification. Please remember to check if the version in Info.plist has been updated.

:warning:
This PR contains release modification. Please remember to check if CHANGELOG.md has been updated.

          2 Messages

:book:
Executed 4 tests, with 0 failures (0 unexpected) in 0.473 (0.477) seconds

:book:
What a good PR :white_flower:

Develop PR Check Result

Item
Result

Head Branch check
:o:

Base Branch check
:o:

Info.plist modification check
:heavy_exclamation_mark:

CHANGELOG.md modification check
:heavy_exclamation_mark:

Merge Commits check
:o:

Modification Volumn check
:o:

  Generated by :no_entry_sign: Danger


Unified way of accessing response body in case of failure.

It would be nice if there was a unified way of getting body out of Response[Either[ResponseError[E], T]], especially in case of failure.
Possible solutions:

Add body: String to ResponseError which would translate to HttpError#body and DeserializationError#original
Add rawErrorBody: String to Response - this probably have some far going implications, especially when request is consumed as stream

The first is easy - done :)
The second is not possible. If you always need the body as string, create a response specification which will read the result as a e.g. (String, T)
For example: asStringAlways.map(s => (s, ResponseAs.deserializeWithError(deserializeJson)(s)))

(1) released in 2.0.0-RC8

Awesome, thank you!


FormLayout: Prevent crash when a widget is added directly

-> #101
In demo.cpp:
//!!How TF is this auto-converted to Widget*?! :-o
    form->Layout::add("This is just some text on its own.");

Out of desperation I've made the Button(string) and Label(string) ctors explicit, but they could have anyway only create Widget, not Widget* in that context! :-o
-> Well... add() is now an unconstrained template<W>! :-o So it can do whatever... ;)
This is the fix (thanks to c++20 constraints):
template <class W> W* add(W* widget) requires (std::is_base_of_v<Widget, W>)
    { return (W*) (Widget*) add((Widget*)widget); }

Also added the same constraint to Widget::setCallback, although that would be very unlikely to accidentally misuse. :) But for the same of completeness and practice... ;)


Command not found: compdef

/Users/stevenjlho/.zplug/repos/robbyrussell/oh-my-zsh/plugins/brew-cask/brew-cask.plugin.zsh:8: command not found: compdef
/Users/stevenjlho/.zplug/repos/robbyrussell/oh-my-zsh/plugins/composer/composer.plugin.zsh:34: command not found: compdef
/Users/stevenjlho/.zplug/repos/robbyrussell/oh-my-zsh/plugins/git/git.plugin.zsh:74: command not found: compdef

After i update the v2 version, these error message show in my terminal.

Sounds like problem caused by not setting the nice value.

@NigoroJr I think so. These plugins works right after i set the nice value.

Hmm, please tell us your zshrc?

source ~/.zplug/zplug

zplug "plugins/brew", from:oh-my-zsh
zplug "plugins/brew-cask", from:oh-my-zsh
zplug "plugins/composer", from:oh-my-zsh
zplug "plugins/gem", from:oh-my-zsh
zplug "plugins/git", from:oh-my-zsh
zplug "plugins/node", from:oh-my-zsh
zplug "plugins/npm", from:oh-my-zsh
zplug "plugins/osx", from:oh-my-zsh, if:"[[ $OSTYPE == *darwin* ]]"
zplug "plugins/vagrant", from:oh-my-zsh
zplug "plugins/sudo", from:oh-my-zsh
zplug "plugins/zsh_reload", from:oh-my-zsh
zplug "themes/agnoster", from:oh-my-zsh
zplug "lib/clipboard", from:oh-my-zsh, if:"[[ $OSTYPE == *darwin* ]]"
zplug "seebi/dircolors-solarized"
zplug "b4b4r07/enhancd", use:enhancd.sh

zplug "zsh-users/zsh-syntax-highlighting", nice:15

if ! zplug check --verbose; then
    printf "Install? [y/N]: "
    if read -q; then
        echo; zplug install
    fi
fi

zplug load --verbose

@stevenjlho Yes, you need to use nice:val where val is a number larger than 9. In the packages that you get errors from, compdef is called to register the completions. This needs to be done after compinit, but at the time of sourcing those packages it's not run yet. Just add nice:10 to the packages that you get errors from.
ProTip: Use zstyle ':zplug:tag' from oh-my-zsh to set from:oh-my-zsh as the default value (rather than from:github), and specify from:github where necessary.


Update News Snippets design

updated visual style for news snippets
use this section design for an updated H1 and section divider line style


AttributeError: 'str' object has no attribute 'first_spid'

When updating Nixpkgs recently, some CI caught this issue with one of our resholved scripts:
    Traceback (most recent call last):
      File "/nix/store/33xkmpzvw86kyv564lp0xinjjxnn471m-resholve-0.6.6/bin/.resholve-wrapped", line 4478, in <module>
        sys.exit(punshow())
      File "/nix/store/33xkmpzvw86kyv564lp0xinjjxnn471m-resholve-0.6.6/bin/.resholve-wrapped", line 903, in punshow
        resolve_cmdlikes()
      File "/nix/store/33xkmpzvw86kyv564lp0xinjjxnn471m-resholve-0.6.6/bin/.resholve-wrapped", line 2902, in resolve_cmdlikes
        cmdlike.resolve()
      File "/nix/store/33xkmpzvw86kyv564lp0xinjjxnn471m-resholve-0.6.6/bin/.resholve-wrapped", line 2874, in resolve
        self._resolve_invocations(solution)
      File "/nix/store/33xkmpzvw86kyv564lp0xinjjxnn471m-resholve-0.6.6/bin/.resholve-wrapped", line 2840, in _resolve_invocations
        source.look_for_external_sub_execution(self.name, invocation)
      File "/nix/store/33xkmpzvw86kyv564lp0xinjjxnn471m-resholve-0.6.6/bin/.resholve-wrapped", line 3775, in look_for_external_sub_execution
        parsed = parser.parse_known_args(invocation.args)
      File "/nix/store/w05yrq8d41vbd7cz3gyq3ysidz2qyfdp-python-2.7.18/lib/python2.7/argparse.py", line 1737, in parse_known_args
        namespace, args = self._parse_known_args(args, namespace)
      File "/nix/store/w05yrq8d41vbd7cz3gyq3ysidz2qyfdp-python-2.7.18/lib/python2.7/argparse.py", line 1943, in _parse_known_args
        start_index = consume_optional(start_index)
      File "/nix/store/w05yrq8d41vbd7cz3gyq3ysidz2qyfdp-python-2.7.18/lib/python2.7/argparse.py", line 1883, in consume_optional
        take_action(action, args, option_string)
      File "/nix/store/w05yrq8d41vbd7cz3gyq3ysidz2qyfdp-python-2.7.18/lib/python2.7/argparse.py", line 1811, in take_action
        action(self, namespace, argument_values, option_string)
      File "/nix/store/33xkmpzvw86kyv564lp0xinjjxnn471m-resholve-0.6.6/bin/.resholve-wrapped", line 339, in __call__
        Invocation(words=values),
      File "/nix/store/33xkmpzvw86kyv564lp0xinjjxnn471m-resholve-0.6.6/bin/.resholve-wrapped", line 3131, in __new__
        self.first_spid = firstword.first_spid
    AttributeError: 'str' object has no attribute 'first_spid'

It only appeared for this one script. I'll gladly send you said script (and the Nix expression), just reach out to me on Matrix when you have time.

I think I have had a fix for this, but I got distracted by some documentation work and didn't cut a release.
I've now released v0.6.7 and opened NixOS/nixpkgs#145577 if you can confirm either of those work :)

Sadly, that didn't appear to work. Same trace, different version :(
Traceback (most recent call last):
  File "/nix/store/lv77mh62aqm82g1k78gc4wvzy4bbx6wy-resholve-0.6.7/bin/.resholve-wrapped", line 4515, in <module>
    sys.exit(punshow())
  File "/nix/store/lv77mh62aqm82g1k78gc4wvzy4bbx6wy-resholve-0.6.7/bin/.resholve-wrapped", line 903, in punshow
    resolve_cmdlikes()
  File "/nix/store/lv77mh62aqm82g1k78gc4wvzy4bbx6wy-resholve-0.6.7/bin/.resholve-wrapped", line 2921, in resolve_cmdlikes
    cmdlike.resolve()
  File "/nix/store/lv77mh62aqm82g1k78gc4wvzy4bbx6wy-resholve-0.6.7/bin/.resholve-wrapped", line 2893, in resolve
    self._resolve_invocations(solution)
  File "/nix/store/lv77mh62aqm82g1k78gc4wvzy4bbx6wy-resholve-0.6.7/bin/.resholve-wrapped", line 2859, in _resolve_invocations
    source.look_for_external_sub_execution(self.name, invocation)
  File "/nix/store/lv77mh62aqm82g1k78gc4wvzy4bbx6wy-resholve-0.6.7/bin/.resholve-wrapped", line 3812, in look_for_external_sub_execution
    parsed = parser.parse_known_args(invocation.args)
  File "/nix/store/w05yrq8d41vbd7cz3gyq3ysidz2qyfdp-python-2.7.18/lib/python2.7/argparse.py", line 1737, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/nix/store/w05yrq8d41vbd7cz3gyq3ysidz2qyfdp-python-2.7.18/lib/python2.7/argparse.py", line 1943, in _parse_known_args
    start_index = consume_optional(start_index)
  File "/nix/store/w05yrq8d41vbd7cz3gyq3ysidz2qyfdp-python-2.7.18/lib/python2.7/argparse.py", line 1883, in consume_optional
    take_action(action, args, option_string)
  File "/nix/store/w05yrq8d41vbd7cz3gyq3ysidz2qyfdp-python-2.7.18/lib/python2.7/argparse.py", line 1811, in take_action
    action(self, namespace, argument_values, option_string)
  File "/nix/store/lv77mh62aqm82g1k78gc4wvzy4bbx6wy-resholve-0.6.7/bin/.resholve-wrapped", line 339, in __call__
    Invocation(words=values),
  File "/nix/store/lv77mh62aqm82g1k78gc4wvzy4bbx6wy-resholve-0.6.7/bin/.resholve-wrapped", line 3150, in __new__
    self.first_spid = firstword.first_spid
AttributeError: 'str' object has no attribute 'first_spid'

v0.6.8 here and nixos/nixpgks#145586 will hopefully actually have this, now :)

Confirmed fixed! Thanks!


Add persistent index

Great tool! Makes my life easier :)
Have an issue when trying to create my first index for vertex collection 'students':
index = students.add_persistent_index(fields=['grades'], unique=False, sparse=False, in_background=True, name='studentsgrades')
On execution I get the following error for the background and the same for the name attribute:
TypeError: add_persistent_index() got an unexpected keyword argument 'in_background'
Any idea how to start it in the background and how to assign a name?
Thank you!

Hi @gitman23,
Which version of python-arango are you using? Thanks

Closing due to inactivity.


Make: cmctl and kubectl-cert_manager are using two -ldflags, the second -ldflags is cancelling the first one

I also took the opportunity to document the three most important "build" variables in "make help".
Fixes #5020
/kind bug
`cmctl` and `kubectl cert-manager` now show the actual version instead of "canary".

/lgtm
/retest

/lgtm cancel

@SgtCoDFish I realize that I did not do a good job at following through with this PR. Feel free to force-push, you can also remove the unnecessary changes to the "help" (e.g. the @category Build annotation) if that unblocks this PR.

/cherry-pick release-1.9

I am guessing if previously the ldflags were actually not set, we should see a difference in binary size post this PR?

I think so yeah! Tried very quickly locally and saw a ~20MB drop in size of cmctl on linux/amd64!


[mediasite] new extractor

A new extractor for sites based on the Sonic Foundry Mediasite player. This extractor subsumes Sandia and CollegeRama extractors. This PR may at least partially resolve #5428.
Some SmoothStreaming manifests referenced by Mediasite players don't specify the FourCC of the audio codec, making _parse_ism_formats skip them when enumerating streams in the manifest. Microsoft's documentation says this is not a violation; FourCC is indeed optional in <QualityLevel> elements corresponding to audio streams. This PR sets AACL as the default FourCC in SmoothStreaming audio streams. I'm not sure if this is valid, but it seems to work... smoothly.
Downloading slides is still not supported; but I think it should be possible to create a synthetic Matroska/MP4 stream from the individual slide images and timing information in the JSON data, by feeding them to FFmpeg's concat demuxer (see ffmpeg-formats(1)). I did some preliminary testing and it appears to be feasible. When the -vcodec copy option is used, FFmpeg will construct losslessly encoded files (MJPEG, that is), which appear to be playable in GStreamer-based and FFmpeg-based applications (although it requires putting a dummy zero-duration frame at the end, so that the stream has the right duration; also, seeking doesn't seem to work very well). A custom downloader will have to be written, should you choose to pursue this approach.

Microsoft's documentation says this is not a violation; FourCC is indeed optional in  elements corresponding to audio streams.

from TrackAttributes in <IP_ADDRESS> of revision 7:

If the track is contained in a stream whose Type is audio, the following additional fields are also required and MUST be present in TrackAttributes: MaxWidthAttribute, MaxHeightAttribute, CodecPrivateDataAttribute, SamplingRateAttribute, ChannelsAttribute, BitsPerSampleAttribute, PacketSizeAttribute, AudioTagAttribute, and FourCCAttribute.

Some SmoothStreaming manifests referenced by Mediasite players don't specify the FourCC of the audio codec, making _parse_ism_formats skip them when enumerating streams in the manifest.

in this case i think it would be more safe to check for AudioTag value to be equal to 255, instead of defaulting to AACL.

The MSDN page says otherwise. Perhaps an older version of SSTR did things differently.

in this case i think it would be more safe to check for AudioTag value to be equal to 255, instead of defaulting to AACL.

I agree. Care to write it? I'm not sure where I should put it.

Care to write it?

My netbook is broken, so I can't contribute to the project now.

I'm not sure where I should put it.

I think that the check for AudioTag can be added after FourCC extraction and before the check for supported values.

The downloader itself also looks at the FourCC.

Yes I mean there no FourCC and AudioTag equal to 255 than set FourCC to AACL.

Anything else?

Bump and +1 for this to be merged. I have tried the pull request locally and it worked perfectly for my needs.  I would also need slide extraction, but that is a separate story.

Cherry-picked. Thanks.


Adding machine-readable tags to the repo

It would make repo navigation slightly easier to have tags available as both "r70" and "r70-bornean-green-magpie". I use this command to do this locally:
for t in $(git tag | grep '^r'); do
  git tag $(echo $t | sed 's/-.*//g') $t;
done;

This makes comparing different releases faster.

closing


Fix some commands

This fixes a couple of commands in the documentation:

listing models from a repo appears appears to either need an explicit --rev specified or it should have the /tree/simple appended. Not sure which version is preferred.
My best attempt at this was using the simple branch from the repository. However, that contains different data.
The source project is specified by --sp rather than --sr.

I wasn't sure about another issue: None of the commands seem to work with tags.

Thanks @igordertigor for noticing. Please find some comments below:

--rev simple is the ideal way.
The simple branch indeed contains different data. Thanks again for fixing the outputs.
Thanks for fixing --sp flag as well.

The commands will work with tags using the --rev flag, but it seems like the tags have been changed in the example repository. Please find a list of them here: https://github.com/iterative/example-mlem-get-started/tags
I have suggested some changes to the PR. Would you like to submit the changes so we can merge this?

Thank you @madhur-tandon  for your comments. I would be happy to submit the changes, but it looks as if you already addressed them yourself. It appears as if the only thing that's missing is the linting.

@madhur-tandon, regarding linting, you could run yarn run check-format-and-lint locally which will fix all linting issues.

Thanks a lot @igordertigor for the feedback and PR!


Reverse engineering in Linux and MacOS

I am a ubuntu user and trying to reverse engineer a database but because I do not have visual studio I can not run Scaffold-DbContext command. Please update this guide to cover other OS.

dotnet ef dbcontext scaffold

Make sure that the docs make it clear what works in VS only and what works everywhere.

Closing as duplicate of the main reverse engineering topic, which should cover non-Windows platforms anyway: #508.