Multiple tags filter option not working on localhost

Environment:
MacBook Pro 16 - macOS Big Sur
Wordpress local website using "Local" application for macOS
Base URL: http://ecommercestore.local
When I call a request to getProducts with multiple tags like tags: '55,56' I get the following logs:
flutter: WOOCOMMERCE LOG : Parameters: {page: 1, per_page: 20, tag: 55,56}
flutter: WOOCOMMERCE LOG : Query : products?page=1&per_page=20&tag=55%2C56
flutter: WOOCOMMERCE LOG : oauth token = :
flutter: WOOCOMMERCE LOG : this is the bearer token : Bearer 0
flutter:   ERROR
flutter:   ERROR │ ⛔ Exception: WooCommerce Error!
flutter:   ERROR │ ⛔ code: woocommerce_rest_authentication_error
flutter:   ERROR │ ⛔ message: Invalid signature - provided signature does not match.
flutter:   ERROR │ ⛔ status: 401
Is there any way to resolve this issue ?

@AniketMalik  did you fix it ?


true/false inlining can waste chars

semi-related to #38
These are both longer (in char-count) than the input:
> echo 'a=0<1' | shrinko8 - - -m --focus-chars -f lua
r=true
> echo 'a=1<0' | shrinko8 - - -m --focus-chars -f lua
f=false

workaround: compare a builtin symbol instead, since shrinko8 isn't sure whether its a constant or not:
> echo 'a=◆<0' | shrinko8 - - -m --focus-chars -f lua
a=◆<0

Veering out of bug-report territory and into feature-request territory: shrinko8 could automatically replace "true" and "false" with "0<1" and "1<0", which saves about 2~3 chars each time (since the trailing space can often be removed when merging statements together). I don't know if this idea is in-scope for the tool or not, but it's an interesting idea

About the bug - yeah, it's the same issue as in #38 - I'll probably fix it by avoiding doing const replacement in focus-chars mode if the result is longer than the original tokens (though there are edge cases relating to const vars and to the possibility that even though parts of an expression are longer in constant form, the whole expression is shorter in constant form)
About the feature - hmm... So far I never adding tokens as part of minification, and I'm not sure that would be expected, even though --focus-tokens isn't provided. Maybe under some kind of --ignore-tokens option?
Do you know other such save-chars-at-the-cost-of-tokens tricks?

avoiding doing const replacement in focus-chars mode if the result is longer than the original tokens

Perfect, focus-chars-only is exactly what I would expect here
Oh, true=>0<1 adds extra tokens! very true and not good; I didn't even think about that haha (I've been in character-counting mode for the last few weeks). maybe only do this replacement iff the user asked for --focus-chars but did not ask for --focus-tokens? bah, it feels like a gross mess that users wouldn't be able to predict.
An alternate idea might be a new pause/unpause directive; something like: a=--[[shrinko8-pause]]0<1--[[shrinko8-unpause]]. Some sort of fined-grain control like this, although this exact suggestion feels a bit lacking, since it would only(?) work to prevent constant inlining...
> Do you know other such save-chars-at-the-cost-of-tokens tricks?
Not really, no. Fun exercise! Here's a few:
1
if(not x) => if(x==a) saves one character, if a is unassigned/nil and the programmer is intending to only check for nil (i.e. they know x won't be false)
2
any output of my constant companion tool, e.g. replacing 0x6000 with ◆-♥, or replacing 0x7fff.ffff with 1/0. Or replacing 0xffff.ffff with ~0
3
I just thought up this toy example, probably not useful to you tho:
--28 tokens, 55 chars
function f(x) return x*2*3*4*5*6*7 end
a=f(10)
b=f(20)

--30 tokens, 33 chars
a=10*2*3*4*5*6*7
b=20*2*3*4*5*6*7

4
I suppose the tweetcart standard of using ::_::cls() flip()goto _ instead of using function _draw() end is another example (even when using the p8scii version of flip()cls())
5
similar to 3 but maybe more useful for shrinko8: creating an alias for an often-used variable or constant: u=unpack ... x=u(c) ... y=u(c) or e=128 .... rect(0,0,e,e) ...

Fixed (under --focus-chars only, of course) - LMK if you see any issues.
Thanks for the suggestions, though none of them are particularly low hanging fruit, though I'll consider 2. for the future.

some more cases to consider: replacing powers-of-2 arithmetic with bitops to reduce parens, reducing chars and tokens:
$ echo 'x=(x+2)*4' | shrinko8 -m -c - - -f lua
tokens: 8 0%
chars: 9 0%
compressed: 18 0%
a=(a+2)*4

$ echo 'x=x+2<<2' | shrinko8 -m -c - - -f lua
tokens: 7 0%
chars: 8 0%
compressed: 17 0%
a=a+2<<2

$ echo 'x=(x+y)%8' | shrinko8 -m -c - - -f lua
tokens: 8 0%
chars: 9 0%
compressed: 18 0%
a=(a+b)%8

$ echo 'x=x+y&7' | shrinko8 -m -c - - -f lua
tokens: 7 0%
chars: 7 0%
compressed: 16 0%
a=a+b&7

I suppose this could become hairy, b/c you can't just apply these transformations greedily. counterexample:
$ echo 'x=(x+y)%128 + (a+b)%.5' | shrinko8 -m -c - - -f lua
tokens: 15 0%
chars: 20 0%
compressed: 29 0
a=(a+b)%128+(c+d)%.5

$ echo 'x=(x+y&127) + (a+b&-.5)' | shrinko8 -m -c - - -f lua
tokens: 15 0%
chars: 21 0%
compressed: 31 0%
a=(a+b&127)+(c+d&-.5)

(this isn't the best counterexample, but it seems like applying greedily could fall apart in some situations; I haven't fully thought it through)

is this a good place to leave this? I could make a new issue or something. I don't particularly need or expect these features, but they're similar enough to the ones I suggested earlier in this thread so it seems nice to add them here so they're all in one place


Cross platform usage

Hey this is a really cool project! I have been wanting for ages to develop OpenGL application with a bit more higher lever control like C# offers. I would love to contribute by the way, so let me know if there are any specific things I can help out with.
I did have one question though, I noticed that you maintain a package for windows and linux separately and I was wondering if it is still possible to create a cross platform application using both. Either by compile time or runtime logic that decides which of the two packages is used.
Once again, great work!

Hi @HugoPeters1024
Thanks a lot for your kind words! It is definitely possible to create cross-platform applications. I recommend using the Condition attribute in the  elements in yours csproj files, like I did with Arqan actually to determine package id's. Like this:
<ItemGroup Condition="'$(OS)' == 'UNIX'">
    <PackageReference Include="Arqan.Linux" Version="1.0.1" />
</ItemGroup>
<ItemGroup Condition="'$(OS)' == 'Windows_NT'">
    <PackageReference Include="Arqan.Windows.x64" Version="1.0.1" Condition="'$(Configuration)' == 'x64'" />
    <PackageReference Include="Arqan.Windows.x86" Version="1.0.1" Condition="'$(Configuration)' == 'x86'" />
</ItemGroup>

I need to add though that my main operating system is Linux Mint and that I use Visual Studio code to build my applications. And with code I can easily modify the command line arguments for dotnet build. So I could just run "dotnet build -c x64". On Windows however I use Visual Studio 2019 and there I noticed that it is not only a configuration but a platform as well. So instead of the itemgroup above you could use this:
<ItemGroup Condition="'$(OS)' == 'Windows_NT'">
    <PackageReference Include="Arqan.Windows.x64" Version="1.0.1" Condition="'$(Configuration)|$(Platform)' == 'Debug|x64'" />
    <PackageReference Include="Arqan.Windows.x86" Version="1.0.1" Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'" />
<PackageReference Include="Arqan.Windows.x64" Version="1.0.1" Condition="'$(Configuration)|$(Platform)' == 'Release|x64'" />
    <PackageReference Include="Arqan.Windows.x86" Version="1.0.1" Condition="'$(Configuration)|$(Platform)' == 'Release|x86'" />
</ItemGroup>

But I gotta admit it is a bit tricky to get Visual Studio budge along with it. Also, it sucks having to need multiple packagereference lines because of the double parameters (platform and configuration). The dotnet build command equivalent for the above would be:
dotnet build -c Debug -p:Platform="x64"
dotnet build -c Debug -p:Platform="x86"
dotnet build -c Release -p:Platform="x64"
dotnet build -c Release -p:Platform="x86"

Hence I prefer using the Configuration parameter only as that needs less arguments on the command line. But of course you are free to setup it any way you want. I'll admit, it is a shame NuGet does not have some filter where you can upload a package with the same id and version but for different processor architectures and operating systems. If such a thing was possible there would be no need to tweak around like this. D:
That being said, I talked about Configuration and Platform so far but there are many more project properties like that. I recommend peeking at https://docs.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2019 for a bigger list.
I hope this answers your question. As for contribution, I am always happy if you can get it to work on your machine to start with. I tested Arqan on the few machines I have but obviously everyone has a different cpu and graphics card so other issues may occur on other machines.
With kind regards,
TheBoneJarmer

Oh nice! I didn't knew that was possible. I honestly thought that dotnet no longer had any secrets for me :).
I'll try to create an actual application soon but for now I can confirm that ubuntu 20.04 with a GTX 680m worked out of the box with just a black window loop.

To be honest, it was not that long ago that I discovered this myself. Up until that point I always maintained two code sources using two branches. I was really amazed to learn how flexible csproj files actually are.  That really is a relief. I am curious how well it will work on your Windows machine.


Warning:The following options were not recognized by any processor: '[android.databinding.minApi, android.databinding.enableDebugLogs, android.databinding.sdkDir, android.databinding.bindingBuildFolder, android.databinding.enableForTests, android.databinding.modulePackage, android.databinding.generationalFileOutDir, android.databinding.xmlOutDir, android.databinding.artifactType, android.databinding.printEncodedErrors, android.databinding.isTestVariant]'

I have used dagger too as a dependency and when i added this as an library project it build successfully, But at the time of application running i got the errror for the import statement in activity that
Warning:The following options were not recognized by any processor: '[android.databinding.minApi, android.databinding.enableDebugLogs, android.databinding.sdkDir, android.databinding.bindingBuildFolder, android.databinding.enableForTests, android.databinding.modulePackage, android.databinding.generationalFileOutDir, android.databinding.xmlOutDir, android.databinding.artifactType, android.databinding.printEncodedErrors, android.databinding.isTestVariant]'
Any Help is appreciated.

i have the same error and it hasn't been fixed

where you able to fix yours?


ESPTouch is sending infinity number one

i'm trying the example code in the package on pub dev and when i press execute and receive the data on UDP SEND/RECEIVE
i receiving infinity of number one

Are you testing it with a Device that is supporting ESPTouch?


'AttributeError: 'PCA' object has no attribute 'n_oversamples'

Describe the bug
Attempting to run the code below results in an error when sklearnex is combined with PCA. This line produces the error shown below

python -m sklearnex PCA_test.py

this line does not

python PCA_test.py

To Reproduce
Store this code in a PCA_test.py file and call using the commands above
import numpy as np
from sklearn.decomposition import PCA

data = np.random.uniform(-10, 10, (1000, 3))
pca = PCA(n_components=3)
data_pca = pca.fit(data).transform(data)

Expected behavior
No error
Output/Screenshots

Intel(R) Extension for Scikit-learn* enabled (https://github.com/intel/scikit-learn-intelex)
Traceback (most recent call last):
  File "/home/gperren/miniconda3/envs/pyupmask/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/gperren/miniconda3/envs/pyupmask/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/gperren/miniconda3/envs/pyupmask/lib/python3.8/site-packages/sklearnex/__main__.py", line 55, in <module>
    sys.exit(_main())
  File "/home/gperren/miniconda3/envs/pyupmask/lib/python3.8/site-packages/sklearnex/__main__.py", line 52, in _main
    runf(args.name, run_name='__main__')
  File "/home/gperren/miniconda3/envs/pyupmask/lib/python3.8/runpy.py", line 265, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "/home/gperren/miniconda3/envs/pyupmask/lib/python3.8/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/home/gperren/miniconda3/envs/pyupmask/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "PCA_test.py", line 9, in <module>
    data_pca = pca.fit(data).transform(data)
  File "/home/gperren/miniconda3/envs/pyupmask/lib/python3.8/site-packages/sklearn/decomposition/_pca.py", line 402, in fit
    self.n_oversamples,
AttributeError: 'PCA' object has no attribute 'n_oversamples'

Environment:
System:
    python: 3.8.13 (default, Mar 28 2022, 11:38:47)  [GCC 7.5.0]
executable: /home/gperren/miniconda3/envs/pyupmask/bin/python
   machine: Linux-5.0.16-100.fc28.x86_64-x86_64-with-glibc2.17

Python dependencies:
      sklearn: 1.1.1
          pip: 21.2.4
   setuptools: 61.2.0
        numpy: 1.22.3
        scipy: 1.7.3
       Cython: None
       pandas: None
   matplotlib: None
       joblib: 1.1.0
threadpoolctl: 2.2.0

Built with OpenMP: True

threadpoolctl info:
       filepath: /home/gperren/miniconda3/envs/pyupmask/lib/python3.8/site-packages/scikit_learn.libs/libgomp-a34b3233.so.1.0.0
         prefix: libgomp
       user_api: openmp
   internal_api: openmp
        version: None
    num_threads: 48

       filepath: /home/gperren/miniconda3/envs/pyupmask/lib/libmkl_rt.so.1
         prefix: libmkl_rt
       user_api: blas
   internal_api: mkl
        version: 2021.4-Product
    num_threads: 24
threading_layer: intel

       filepath: /home/gperren/miniconda3/envs/pyupmask/lib/libiomp5.so
         prefix: libiomp
       user_api: openmp
   internal_api: openmp
        version: None
    num_threads: 48

Seems only reproduce at MacOS
CI - Test
------------------------------- Captured stdout --------------------------------
Command '['/usr/local/miniconda/envs/CB/bin/python', '/Users/runner/work/1/s/daal4py/sklearn/monkeypatch/tests/utils/_launch_algorithms.py']' returned non-zero exit status 1.
------------------------------- Captured stderr --------------------------------
dispatcher.py:151: FutureWarning:
Scikit-learn patching with daal4py is deprecated and will be removed in the future.
Use Intel(R) Extension for Scikit-learn* module instead (pip install scikit-learn-intelex).
To enable patching, please use one of the following options:
1) From the command line:
    python -m sklearnex <your_script>
2) From your script:
    from sklearnex import patch_sklearn
    patch_sklearn()
Intel(R) oneAPI Data Analytics Library solvers for sklearn enabled: https://intelpython.github.io/daal4py/sklearn.html
Traceback (most recent call last):
  File "/Users/runner/work/1/s/daal4py/sklearn/monkeypatch/tests/utils/_launch_algorithms.py", line 117, in <module>
    run_algotithms()
  File "/Users/runner/work/1/s/daal4py/sklearn/monkeypatch/tests/utils/_launch_algorithms.py", line 93, in run_algotithms
    run_patch(info, t)
  File "/Users/runner/work/1/s/daal4py/sklearn/monkeypatch/tests/utils/_launch_algorithms.py", line 61, in run_patch
    model.fit(X, y)
  File "/usr/local/miniconda/envs/CB/lib/python3.9/site-packages/sklearn/decomposition/_pca.py", line 402, in fit
    self.n_oversamples,
AttributeError: 'PCA' object has no attribute 'n_oversamples'
=========================== short test summary info ============================
ERROR s/daal4py/sklearn/monkeypatch/tests/test_patching.py - SystemExit: 1
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!

Hi @Gabriel-p @FavorMylikes Thank your for your detailed reports. It seems due to new sklearn version 1.1.1, where we have some new parameters for PCA such as n_oversamples. So it is sklearex bug.

Running into the same issue, how do we solve it?

Running into the same issue, how do we solve it?

@mjoy296 Downgrade sklearn to 1.0.2

@mjoy296, I'm running into the same issue as well.
@FavorMylikes, I appreciate your solution but unfortunately I can't downgrade sklearn to 1.0.2 as I have dependencies on 1.1.
As seen in latest sklearn (1.1.2) docs there are new PCA() parameters since 1.1:
n_oversamples : int, default=10
power_iteration_normalizer : {‘auto’, ‘QR’, ‘LU’, ‘none’}, default=’auto’

Here are evidences:
>>> from sklearnex import patch_sklearn
>>> patch_sklearn()
Intel(R) Extension for Scikit-learn* enabled (https://github.com/intel/scikit-learn-intelex)
>>> from sklearn.decomposition import PCA
>>> p = PCA()
>>> p.get_params()
{'copy': True, 'iterated_power': 'auto', 'n_components': None, 'random_state': None, 'svd_solver': 'auto', 'tol': 0.0, 'whiten': False}
>>> from sklearnex import unpatch_sklearn
>>> unpatch_sklearn()
>>> from sklearn.decomposition import PCA
>>> p = PCA()
>>> p.get_params()
{'copy': True, 'iterated_power': 'auto', 'n_components': None, 'n_oversamples': 10, 'power_iteration_normalizer': 'auto', 'random_state': None, 'svd_solver': 'auto', 'tol': 0.0, 'whiten': False}

I wonder if sklearnex could support new default PCA() parameters "from the future" or at least ignore their existence, otherwise I'd prefer to sklearnex.unpatch_sklearn() just for PCA() as its performance seems acceptable without sklearnex for now.
Eventually I would seek for more PCA performance by other means like using GPUs with the PCA from RAPIDS/cuml.


Validation can block $unset of path

I recently discovered that you can assign a value of undefined to a path to perform an $unset operation. However, if the path has validation, the validation tests the undefined value during a call to save which is not necessarily desired. For instance,
var mongoose = require('mongoose');
mongoose.connect('mongodb://localhost:27017/mongoose_test');

var personSchema = new mongoose.Schema({
  name: String,
  age: {type: Number, min:0}
});

Person = mongoose.model('Person', personSchema);

// Database contains single person:
// {name:'Phil', age:30}

Person.findOne({name:'Phil'}, function (err, doc) {
  doc.age = undefined; // $unset the age path
  doc.save( function (err) {
    if (err) { console.log(err); }
    mongoose.disconnect();
  });
});

fails with the error
{ [ValidationError: Validation failed]
  message: 'Validation failed',
  name: 'ValidationError',
  errors:
   { age:
      { [ValidatorError: Path `age` () is less than minimum allowed value (0).]
        message: 'Path `age` () is less than minimum allowed value (0).',
        name: 'ValidatorError',
        path: 'age',
        type: 'min',
        value: undefined } } }

This doesn't seem like the right behavior, since it is valid under the schema to save a Person with no age value specified. Note, that it also fails for max validators; I haven't played with other validation types.

This was fixed in the unstable branches, see #1594. Fix will be released soon :)


Protease Configuration w/ Multiple Cleavage Restrictions

Hi all,
I have samples that are digested with both Hydroxylamine (HA) and Trypsin and am trying to set up a user defined protease to search these samples but am having some trouble with the notation. While hydroxylamine canonically cleaves at N|G sites, we also see cleavage between N and a number of other residues. I would like to define the protease as cleaving C-terminal of K and R (for Trypsin) as well as C-terminal of N, except when the following residue is C, F, H, or M. I am able to successfully search the desired raw file using the same FASTA database with trypsin as the enzyme, so I am sure the problem lies in the protease configuration. Additionally, I am finding conflicting reports of how the syntax should be structured from different posts on the Github forum. Some posts describe the syntax using only the "Sequences Inducing Cleavage" column with additional brackets for excluding residues, while other posts appear to also use the "Sequences Preventing Cleavage" and "Cleavage Terminus" columns with residues separated by | characters. I have tried the following syntax with no success (for the ones using 3 columns, columns are separated by a single space):
K|,R|,N|[CFHM]
K|,R|,N[CFHM]|
K|,R|,N|[C][F][H][M]
K|,R|,N[C][F][H][M]|
K|,R|,N|[C],N|[F],N|[H],N|[M]
K|,R|,N|G
K|R|N P|P|CFHM C|C|C
K|R|N P|P|C C|C|C
as well as a few others. All of these return a runtime error that says the index is out of bound of the array. I'm unsure were to go from here after reading all related posts I can find, any help would be much appreciated!

This is fixed in the latest version (0.0.297) which I just released. If you get another error please let us know!


Revamp/997 example of iterative upgrade

The example uses sbm-support-rewrite parser and sequentially upgrades a given repo.

A given repo gets cloned
The version from the <parent> section of the pom.xml is extracted
A matching upgrade recipe is looked up and applied
The result is committed on a new branch and the changes get pushed
A new PR with the changes of the upgrade is created
The process stops until the PR is merged
Go to 1

The upgrade fails from 2.5 to 2.6
org.openrewrite.maven.MavenDownloadingException: mysql:mysql-connector-java failed. Unable to download dependency mysql:mysql-connector-java:8.0.33. Response was 404

mysql:mysql-connector-java:8.0.33 is a relocation release and the MavenArtifactDownloader fails to download it.
The pom
MySQL Connector Metadata

[ ] Spike: MavenArtifactDownloader should interpretate relocations

MavenArtifactDownloader should interpret relocations
The upgrade in #1001 fails from 2.5 to 2.6
org.openrewrite.maven.MavenDownloadingException: mysql:mysql-connector-java failed. Unable to download dependency mysql:mysql-connector-java:8.0.33. Response was 404

mysql:mysql-connector-java:8.0.33 is a relocation release and the MavenArtifactDownloader fails to download it.
The pom
MySQL Connector Metadata


Gets deployed but not shown in keycloak

Hey!
I got the following issue: KeyCloak deploys it just fine (v16) according to the logs. I also restarted it but I cant find it in the Provider Drop Down Menu,

Am I missing something?
Thank you.

You need to add an execution on the registration flow :

First Copy the existing registratuion workflow

On this new auth flow, add an execution to the parent :

The new execution should appear :

Ah, okay! I didnt look there, thank you!


Feature request: "Match making"

Feature request from @CTNicholas
https://discord.com/channels/913109211746009108/913157273046646795/938057663055560764

Another handy feature would be a room that automatically generates its own ID, and autofills up to a certain capacity. Once the current room is full, users start filling up a new room. This would be great for public facing pages; Next.js Conf had this feature, with random people's live cursors appearing on screen. It would also be handy for any games built on Liveblocks, as a matchmaking mechanic. Quick example:
<RoomProvider
  matchmaking="busiest"
  prefix="live-cursors-"
  maxUsers={20}
  onCreate={id => {
    // 'live-cursors-cwg3h46shkd4h4hjshs'
    console.log(id)
  }
/>

I've written matchmaking="busiest" because there could be multiple algorithms for filling the rooms.
Examples:
busiest: When all rooms are full, create a new room. The busiest room is then filled first.
emptiest: When all rooms are full, create a new room. The emptiest room is then filled first.

It would definitely be cool to get some proper examples/functionality down for how to handle this sort of thing when using Liveblocks to create web games.


Provide steps to create an AKS from Azure Portal/PS Scripts

I tried to create an AKS from Azure Portal or PS Scripts but I don't manage to use it from AML worskpace:

portal, when attaching the workspace: "Retries exceeded in deploy scoring FE"
PS script (az aks create --name aksps2 --resource-group aksps2 --generate-ssh-keys --kubernetes-version 1.11.2) "Operation returned an invalid status code 'Forbidden'"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc87eb58-5bdf-15d3-1a52-ca9d0706726f
Version Independent ID: 460fb6ba-ca28-2505-b4d9-1dec3972d968
Content: Deploy models to Kubernetes from Azure Machine Learning service
Content Source: articles/machine-learning/service/how-to-deploy-to-aks.md
Service: machine-learning
GitHub Login: @raymondlaghaeian
Microsoft Alias: raymondl

@salperwy Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate. In this forum we take care of documentation improvements  to get you unblock you might want to post a question in the forums like StackOverflow or MSDN.

By the way the AKS version (1.11.2) is not anymore available to be deployed.

@Alberto-Vega-MSFT - please assign to @aashishb

@YutongTie-MSFT - #please-assign to aashishb

@salperwy and @csalperwyck thanks for the feedback and I apologize for the long delay in resolving this. The documentation has been updated to state that we require AKS 1.11.##, and that the cluster also requires at least 12 virtual cores. I've verified with the engineering team that Azure Machine Learning service supports AKS 1.11 versions. If you receive errors using this version still, please contact Microsoft support for assistance.
#please-close


Allow specifying additional ON criteria for joins

This could be a documentation problem, and I'm missing things in the code, but I don't currently think so.
I need to be able to specify additional criteria within a JOIN command; right now the many_to_many command only appears to link by matching ids.  In addition to matching IDs, I need to be able to specify additional column restrictions.  (think:  state column, or "type" for dealing with a polymorphic association)
This is not the same thing as adding a where clause to the end of the query, at least in the case of a left join.  While I can drop down to raw Sequel to get the effect, the query ends up breaking because all the table aliases and other logic from the association_join are lost.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12387828-allow-specifying-additional-on-criteria-for-joins?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github).

@cflipse I ran into the same thing literally minutes ago. The :conditions option on the association class methods does not seem to have any effect.

For now you can user sequel's graph directly. We're missing support for many extra options that Sequel API has.

I'm not sure how to add additional ON criteria but I added support for :conditions and setting custom association name. See referenced commit.

OK now I know how to do it I just need to know what the interface should be. Any ideas?

Unfortunately, where isn't the same as join ... on for outer join scenarios; there really does need to be a way of handling the on conditions specifically.
select * from users left join tasks on tasks.user_id = user.id and tasks.state = 'active' is different than
select * from users left join tasks on tasks.user_id = user.id where tasks.state = 'active' ... the former gives back all users, with their active tasks.  The latter gives back only users with active tasks.
From what I can make out, additional join conditions could just  get added to the graph call here:
https://github.com/rom-rb/rom-sql/blob/4a16c3c0553c1205c515f8a7f3f427236ad31660/lib/rom/sql/relation/associations.rb#L100 by having the join_keys include the additional criteria  (well, there and the other spots that graph is called)

I know how to do it. It's gonna be messy for many-to-many probably. Any idea how the interface should look like?
one_to_many :tasks, on: { title: 'Blah' }

??

That works for me.
We may or may not want to just let that completely subsume all of the FK/join key specification that exists currently; I'm not sure how nice it looks with both:
one_to_many :tasks, key: :user_id, on: { state: 'active' }

vs
one_to_many  :tasks, on: { user_id: :id, state: 'active }

I think I'm okay with either.  Maybe the mental gymnastics required to figure out which direction the keys go in one_to_many vs many_to_one argue for keeping the key paramter.  I wouldn't eliminate the on nest though, I think that clarity level is needed.

Done here


Port USV Gazebo Wind Plugin

Previously, we calculated wind velocity/direction and the wind forces applied to the WAMV as described in sections 2B and 3C (respectively) of our paper: Toward Maritime Robotic Simulation in Gazebo.
Instead of porting this model, we used the  gz-sim Wind Effects plugin for convenience, but it is less user-friendly, requires a revision to our theory of operations, and lacks any known scientific basis.
The near term solution is to port our previous plugin. A longer term solution is to improve the gz-sim Wind Effects plugin to support our use case.

Previous Wind Effects
This section will summarize the highlights of how the wind was modeled and how the resulting forces used to be calculated.
Wind Model
The user specified the following:

A wind mean velocity in m/s.
A wind direction in degrees relative to the world origin.
A wind gain constant.
A wind time constant in seconds.
We use these to calculate variable wind velocity based on the Harris spectrum, described in: R.  I.  Harris,  “The  nature  of  the  wind,  the  modern  design  of wind-sensitive structures,” in Construction Industry Research and Information Association, 1971, pp. 29–55

Wind Forces

For each object affected by the wind, the user specifies coefficients that weight the impact the wind should have on surge, sway and yaw of the object.
We use these and the current variable wind velocity to calculate the force to be applied in surge, sway and yaw.
We ignore the  effect of the wind on pitch, roll and heave.
Our coefficients for the wamv are taken from: I.  Sarda,  H.  Qu,  I.  R.  Bertaska,  and  K.  D.  von  Ellenrieder, "Station-keeping control of an unmanned surface vehicle exposed to current and wind disturbances," Ocean Engineering, vol. 127,pp. 305 – 324, 2016.

Resolved with #637 #642 and #649 .


_ in headers

Hi!
Many of my claims (and some of the headers this code generates) have _ in them. Apache strips those out so they are unavailable to my application. For instance:
OIDC_id_token
Is unavailable to the application because Apache strips it out. Do you have a way of making "_" into "-" or a different accepted character?

You can use OIDCClaimPrefix as documented in https://github.com/pingidentity/mod_auth_openidc/blob/master/auth_openidc.conf#L473
FWIW: it is not Apache that strips out these headers but apparently something else in your environment. E.g. mod_wsgi < v4.3.0 is known to do that.

OIDCClaimPrefix only handles the prefix. Many claims/headers have _ in them (id_token, first_name, etc). But I hear what you're saying. I'll look elsewhere down the chain to see where they're being stripped.

ouch, you're right: only the actual claims in the id_token and those returned from the user info endpoint will use the configured prefix; that needs a patch indeed

I'm going to leave this as a "wontfix" for the time being: the OIDCClaimPrefix is for the claims specifically (by default OIDC_CLAIM_) and I wanted to put the non-claims info (i.e. id_token, access_token, access_token_expiry in a different namespace which is OIDC_ right now. In due time I could make this configurable through a separate configuration primitive but only when there's substantial demand for it and it is reopened (you would not be helped anyway because the id_token etc. would still have the underscores)

Yeah just as an FYI for my very specific world I modified the code manually myself in a really hacky way (after a fork) and I'm good enough for our use case.
Sent from a tiny keyboard

On Jun 7, 2015, at 3:23 AM, Hans Zandbelt<EMAIL_ADDRESS>wrote:
I'm going to leave this as a "wontfix" for the time being: the OIDCClaimPrefix is for the claims specifically (by default OIDC_CLAIM_) and I wanted to put the non-claims info (i.e. id_token, access_token, access_token_expiry in a different namespace which is OIDC_ right now. In due time I could make this configurable through a separate configuration primitive but only when there's substantial demand for it and it is reopened (you would not be helped anyway because the id_token etc. would still have the underscores)
—
Reply to this email directly or view it on GitHub.


Improve error message on save when not authorized

Hello  and thank you for open sourcing your project. It's really an awesome idea !
I keep however getting the following sqlite (?) error whenever I try to save an edit:
Server side:
SELECT session_id, expires FROM sessions WHERE session_id = NULL AND expires > '2023-07-02T19:06:35.601Z' Error: Not authorized     at Module.createOrUpdatePage (/home/marouane/webDev/site-editable/src/lib/api.js:255:27)     at POST (/home/marouane/webDev/site-editable/src/routes/api/save-page/+server.js:11:31)     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)     at async Module.render_endpoint (/home/marouane/webDev/site-editable/node_modules/@sveltejs/kit/src/runtime/server/endpoint.js:47:18)     at async resolve (/home/marouane/webDev/site-editable/node_modules/@sveltejs/kit/src/runtime/server/respond.js:403:17)     at async Object.handle (/home/marouane/webDev/site-editable/src/hooks.server.js:8:20)     at async Module.respond (/home/marouane/webDev/site-editable/node_modules/@sveltejs/kit/src/runtime/server/respond.js:274:20)     at async file:///home/marouane/webDev/site-editable/node_modules/@sveltejs/kit/src/exports/vite/dev/index.js:505:22
Client side
A 500 error response on the path /api/save-page.
I face the same 500 error on https://editable.website/ whenever I try to save an edit.
I use chrome on an ubuntu if this can help.

Thank you, I need to improve the error message in the demo, but the behavior is expected. Without being authorized (signed in as an admin) you can't save change to a page.
To authorize (e.g. on your local installation) navigate to /login and enter the ADMIN_PASSWORD set in .env.

Thank you for your quick reply :)

Should be fixed.


Feature/update events

Add function of event update + tests
for issue  #35

due to some mistakes on hendling git, I am gonna rewrite the it

due to some mistakes on hendling git, I am gonna rewrite the it


Report Generation + minor bug fixes

PR Checklist

[ ] This comment contains a description of changes (with reason)
[ ] Referenced issue is linked
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated
[ ] CHANGELOG.rst is updated

Description of changes

Technical details

Additional context

Could you also please add the PR to the Changelog with a description of what has been added/changed/fixed, etc.?

Please make sure, that the tests are passing before merging.


'Posted by' blurb

[x] create an insert for the blurb. Format as desired. YYYY-MM-DD or January 15, 2021 format? Time is overkill.
[x] Finalize placement (near header, most likely.
[x] put the insert into the templates

Done. Finalized position at top of post, with a float:right.


feat: add a parameter for reordering genotype samples directly after reading them

marking this as a draft PR because I still need to handle situations where there are duplicate samples or nonexistent samples passed via the samples parameter. We didn't have to worry about this before because cyvcf2 would handle it for us, but it's probably a good idea to think about now that we are actually treating the samples parameter as a list instead of a set

this PR was overriden by #230


Rev0: CSV Creation & Appending

Fixes: #223
Creates a CSV file and appends the searched data to it
CSV file is named nutrition_log.csv and is located in the utrition-backend folder.
Note: the CSV file was added to .gitignore so any changes to it will not be included in git tracking

CSV has the newest entry at the bottom, it makes more sense to sort the list in reverse order when processing it, not when saving it.
something like
Image
can be used


add publish CD job and allow for prerelease versions

Changes

The real version string is now represented by a variable called version_string, this allows for __version__ to contain prerelease information. Note that version_string and version_info will never contain build metadata or prerelease information.
Adds a CD job to publish to PyPI and also Github Releases. In the future we may want to require a CHANGELOG.md file be maintained, and we can create release information from that.

Awesome! I guess do we test this via a pre-release?

We can, if you want. I think that would require me changing the version in the source code temporarily, then changing it back to a "release" version. I'll go ahead and merge this since it should only apply to tags.


v4 PostGraphile Support

Thanks for making this repo. We're evaluating postgraphql on lambda and this has been super helpful. I have been looking at targeting v4 (aka PostGraphile). It looks like there's introspection caching built in (with "plugin support" that I need to learn more about).
Do you still have energy for this project? Would you be keen to see a PR for v4 support?

For anyone else looking for a solution, I have a repo for this here:
https://github.com/ryanwestby/serverless-postgraphile


[THREESCALE-2340] Make response codes compatible with reporting threads

Fixes THREESCALE-2340
This PR makes response codes compatible with reporting threads.
The only problem was that the status code (ngx.var.status) was checked in a timer and timers do not have access to ngx.var.*.

Is the outcome of this change @davidor that enabling response-codes would NOT disable the async reporting, hence avoiding the thruput impact of that?

Yes. Just to be clear, the current code allows async reporting with response codes but only with 1 thread.
The env APICAST_REPORTING_THREADS is used to report using a pool of several threads. However, the current code ignores it when response codes are enabled. This PR changes that, now it's possible to have both APICAST_REPORTING_THREADS > 1 and response codes.

OK. So it sounds like no changes in the docs (on ENV vars and behaviour are needed).


[PathPattern] Record and use PathPattern in response

...so metrics correctly report the innermost PathPattern.
https://github.com/poem-web/poem/issues/461

This is a quality PR, thanks a lot! 🙂


Tweak admin permissions for ProjectPreferences update_settings

Tweaking https://github.com/zooniverse/panoptes/pull/4218 -- run is_admin? check on api_user instead of user so that an admin flag is required in the request, not just that the user has admin privlidges.  This allows for non-admin use of API endpoint by Zoo team members.
My initial commit is going to break the spec, and I could use assistance in correcting the test.  Not sure if there's a standard case / method of testing for admin flag use.

Closing in favor of #4257


Question: is there a method that exists to create a random offset from a point?

I imagine geolib has capabilities to do this:

create a circle of specific radius, the center of which is a provided point.
randomly generate another point within that radius (somehow).

My use case was an application where easiest intake was for users to input an address.  Assuming they put in their home address, the resulting data visualization displayed exactly on their house.
For privacy reasons, I was thinking of simply randomizing my geopoints within a certain radius (let's say 100-300 feet).
Again, I am sure I can find a way to do this geometrically, but wanted to get some feedback here.  If this proves valuable, I'd be happy to contribute as well.
Thanks in advance.

There's no such method yet and while reading the first few sentences of your issue I thought that this should probably not be done on library level but your usecase made me curious.
There is: #computeDestinationPoint
computeDestinationPoint(point, distance, bearing, radius = earthRadius)

You could pretty easily build such a function by randomizing the distance and the bearing parameters.


Streamline settings

Closes #15

Here I'm removing a few redundant settings. I also added an identity-token setting since users might not want to use the GitHub Actions credential.

Sorry, the testing PR was actually pointing at this one. I did that because the tests relied on the new identity-token setting.

Sorry, the testing PR was actually pointing at this one. I did that because the tests relied on the new identity-token setting.

No problem, it was my mistake. Do you want to roll that other PR back?

Sorry, the testing PR was actually pointing at this one. I did that because the tests relied on the new identity-token setting.

No problem, it was my mistake. Do you want to roll that other PR back?

I'm not too worried about it. I'm happy to just merge this if you agree.

I'm not too worried about it. I'm happy to just merge this if you agree.

Yep, go for it.


RCON kick fails on reserved servers

Have a user reserve a server, and use >rcon kick. It fails to listen to the kick ID. To be safe, test all use cases which are >pc kick, >rcon kick, and >p kick

Resolved in commit 123ba2d


mne.SourceEstimate.plot() Graph Unresponsive

I followed the installation and setup tutorial given at:
https://www.martinos.org/mne/stable/getting_started.html
Then I downloaded and tried to run this full example script given at:
https://martinos.org/mne/stable/_downloads/plot_mne_dspm_source_localization.py
It runs to the end, but the five brain plots that pop up are instantly unresponsive.
Here is my sys_info() output:
Platform:      Darwin-17.7.0-x86_64-i386-64bit
Python:        3.6.6 |Anaconda, Inc.| (default, Jun 28 2018, 11:07:29)  [GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)]
Executable:    /anaconda3/envs/mne/bin/python
CPU:           i386: 8 cores
Memory:        16.0 GB

mne:           0.16.2
numpy:         1.14.5 {blas=mkl_rt, lapack=mkl_rt}
scipy:         1.1.0
matplotlib:    2.2.2 {backend=module://ipykernel.pylab.backend_inline}

sklearn:       0.19.1
nibabel:       2.3.0
mayavi:        4.6.1 {qt_api=pyqt5}
pycuda:        Not found
skcuda:        Not found
pandas:        0.23.1

There are no error messages given, which makes this much more difficult to debug. Any help would be much appreciated!

Can you try using %matplotlib qt and/or %gui qt? It starts up an event loop that should also process the Mayavi events

Hi @larsoner
Running %matplotlib qt from the Ipython console prevents the freeze.  I also noticed that changing Spyder settings for IPython console Graphics backend from Inline to Qt5 has the same effect as running %matplotlib qt but it's persistent.
The buttons at the top of the plot window don't respond or do anything, but even so, at least the plot isn't unresponsive and I can drag the 3D image around and have a good look at it. Much appreciated!

Reopening as we should update our install docs to make a (better) note of these sorts of tweaks

Thanks @larsoner for your efforts and replies. My colleague @deepagupta would be happy to reply here in the event of further questions or discussion regarding documentation or related MNE functions or structures we are using.

It looks like we already have the suggestion of using %gui qt in the dev docs so this can be closed


Text styles

Hi there, I was wondering if there was any plans to expand the plugin features to allow for the creation of text style references?

Yes, absolutely! I will also need them. I for now only did work with rectangles and its styles... that's why I focused these styles first.

Oh nice!! Was just curious since I'm super interested in this — thanks for the reply 😄

We'll keep it open, so its fingerpointing at me now ;) I'll close it once you are able to use it. I like that more :)

With the latest release (and rename to "Theemo"), text styles are finally supported. When a reference is happening, internally these styles are copied over. I did copy over everything the figma API is offering here. Hope that catches all, anyway please feel free to open another ticket if something is missing.
Happily close this one.

🙌 Wooooot, awesome! Thanks for adding this!


PyFX does not work with overrides==6.1.0

Describe the bug
Running PyFX with the latest overrides version (which is 6.1.0 currently) throws an error:
TypeError: `ArrayNode.prev_child: key overriding must be a supertype of `<class 'inspect._empty'>` but is `<class 'str'>`

The reason is that ArrayNode's prev_child method overrides the parent class' prev_child method, which have a different type hint, and overrides now check the type hints starting from some version later than 4.1.2.
To Reproduce

Install PyFX from pip from a clean environment, which by default installs the latest overrides package as dependency.
Open any json file.

Expected behavior
It should not throw an error.
Additional context
Downgrading overrides to 4.1.2 solves the problem.  Did not test other versions.

Thanks for digging into the issue!
I thought I have fixed a similar issue in commit 4913ecd7bc6abc3ee05d1ff9f41c656bfb449fe1.
Maybe I overlooked one and did not fix it then.
May I know which version you're using? I'll take a look to fix it

Just released 0.1.0-beta.2, in which I fixed the dependency version in the latest version. When you got a chance, can you help me test it?
Thanks again for using the tool!

I was using the latest release from PyPI.  I think your mentioned commit fixed it.
Thanks!


Predictions Based on Survey Data

Adds flask service in python for running regression analysis on survey data stored in data store
Decision tree considers four dimensions (direct experience with police, gender of the user, age of the user, and their respective
sentiment score)
Adds a prediction panel on the statistics page to show prediction scores for each type of user

This branch was merged prior to Jin's comments. I will address the comments in the next PR


Server crash, "Unable to construct this menu by type"

Hunts version: 3.2.1 (currently latest)
Crash log: https://pastebin.com/paEYkALT
I've only had this crash twice, but they were both within the last 2 days, on the same version. It appears both crashes happened when a player did /hunt. In one case, I was able to see in the logs that a player successfully ran /hunt, then the server crashed when they ran in again 2 minutes later. The hunts were not re-rolled during this time, so the crash is seemingly unrelated to the specific Pokemon sprites in the GUI

Fixed in upcoming version


Ensure that curl is set up before calling the command

Fixes #529

@ColinHebert thanks for the catch and fix. Appreciated.


Fix types in accelerator spawner submit

https://issues.redhat.com/browse/RHOAIENG-15330
Description

update logic for submitting of a juypyter notebook
How Has This Been Tested?

try to submit a jupyter notebook with accelerator profile and make sure resulting notebook resource gets the accelerator details added
Test Impact

added test
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/approve


Add Polconeth

Polconeth is state channel for EVM and Substrate based balance transfer
Grant Application Checklist

[ ] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[ ] A BTC or Ethereum (DAI) address for the payment of the milestones is provided inside the application.
[ ] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[ ] The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants.
[ ] The initial PR contains only one commit (squash if needed before submitting your PR).
[ ] The grant will only be announced once we've successfully delivered the first milestone.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Noc2 Thank you for your comment.

Could you share potentially any previous projects/work? Are you directly involved in connext?

I'm not in Connext but I've been long after XUD, which is a Lay2 DEX integrating Context for EVM balance swaps.

What are the benefits of connext compared to celers implementation?

I don't know Celer much. Afaik, Celer is more targeting to gaming while Connext is focused on cross chain transfers and micropayments. Furthermore, Connext is production ready while I haven't seen any major product/app using Celer so far.

Could you provide more technical details regarding the implementation?

We want to integrate Connext API with Substarte off-chain Worker. Through the configuration, it can call methods from a node either maintained by Connext team remotely or installed locally by docker.

Sorry for the late reply. Could still please integrate more technical information into the application? Also a comparison with existing solutions provided by celer would help. For example currently your delivery only says “We will create a pallet to enable state channel transfer on Substrate chain”. Theoretically you could just deliver celers solution and you would fullfill the current requirements. What are the functions?

On functionality side, Vector of Connect is very similar with cChannel of Celer. If it's just to fulfill layer-2 channel transfer requirement, yes - we could use Celer solution as well.
However, Connext is more production ready on cross-chain transfer and micro-payments while Celer is focusing more on gaming. Besides, Connext has more implementations.
Server-node, which uses docker to package up core logic and exposes http and gRPC interfaces.
Browser-node, which is distributed via npm and exposes a typescript/javascript interface.
Routing node, where you forward transfers between different channels. This way, peers can transfer to each other without needing channels directly to one other, but instead by "hopping" value across many different channels through the network. Routing nodes run server-node with an automated module - a router - to forward transfers.

Do you need to adapt the off-chain part or will it be completely integrated as off-chain workers? Etc.

In the 1st milestone, we'd like to package the server-node in the image and integrate APIs into off-chain workers. Namely, completely integrated as off-chain workers.
If the delivery of 1st milestone is workable and adoptable, we're going to convert Connext smart contract logic into substrate modules in the 2nd milestone.

Thanks. Could you update the application accordingly? You haven’t updated the PR, since the original pull request.

@Noc2 Thanks. Updated the application according to the conversation.

Added Connext contract link to the delivery item 2 of MileStone 2 - 'Polconeth Module'.
And we want to implement the rest-api-client into the off-chain worker in milestone 1.

Could you clarify what you mean by "I've been long after XUD"? The repo you link to doesn't contain any commits made by yourself and there are no repositories on either your or your organisation's account. I'd need to see some of your prior work to approve this.

I'm not core dev of this project. However, I was involved from day 1 - like I participated in the design and feasibility analysis of this project. Also, I translated white paper and tech white paper for XUD and published some tech articles.
So I'm very clear why XUD switched from Raiden to Connext as their state channel an how Connext works with and benefit this project.

At the current state of the project, I would be wary about supporting a Connext integration. A couple of reasons for this:

Their audit is missing. This is a red flag to me
They claim to work in a trust-less manner, yet the Protocol Primer section has zero information about how that is achieved. To me, this is a key question that should be asked about such a cross-chain protocol.

Now, I'm not sure whether or how your team is affiliated with Connext, but regardless of it - I wouldn't be comfortable supporting an integration to, what seems, a shady project (see above points).

Thanks @MotoYS. I hope you understand that given the technical nature of the project, I'd prefer to see some code produced by you and your colleague. I also agree that @mmagician's concerns are worrying so all in all, at this point I would rather not give my OK.

Since your application has been open for a month and failed to raise interest from our side, we will now consider it final in its current state and will give it two more weeks to gather the necessary approval. If no 3 members of the committee approve it within this time, the pull request will be permanently closed. Thank you for your understanding.


size/count and is steps

Triggered https://github.com/ShiftLeftSecurity/codescience/issues/2995 it
became obvious that we're missing a few basic wrapper steps. These are easy
to add though.
is(P) is a bit of a leaky abstraction, but not too bad IMO.
n.b. independent of this we can still rename filter ->
filterOnTrav and filterOnEnd -> filter. Downside would be that we
have to teach customers. Upside is that we'll have to do that eventually
anyway, with the new collection-based traversal.

based on https://github.com/ShiftLeftSecurity/codepropertygraph/pull/452, review/merge that one first

Closing for now in favor of extending nodes.$Foo types and renaming filterOnEnd to where.


upgrade ray version for ray server and ray train examples

The current Ray version used in Ray train and Ray serve example is 2.9.0, which is staled. Updating to 2.36.1

@andrewsykim PTAL


New release with go modules

This tool is installable via go modules and there is no release once the repo was switched to go modules. Adding this will make sure the tool is installable via brew when go1.17 is out.
TL:DR; please make a new release

Hey @roopakv, I've pushed a new tag v0.9.1, I'm assuming you don't need any release artifacts but please reopen if you do.


Settings Sync won't turn on

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.2 (user setup)
OS Version: Windows_NT x64 10.0.19042

Steps to Reproduce:

Accounts > Turn on Settings Sync... > Sign in & Turn on > TurnipGuy30 (GitHub)
Notification: Error while turning on Settings Sync. Please check [logs](command:workbench.userDataSync.actions.showLog) for more details.
Log (Settings Sync) returns the following:

[2021-12-22 06:20:28.049] [settingssync] [info] Using settings sync service https://vscode-sync.trafficmanager.net/
[2021-12-22 06:20:28.049] [settingssync] [info] Auto Sync is disabled.
[2021-12-22 06:46:15.511] [settingssync] [info] Request failed https://vscode-sync.trafficmanager.net/v1/manifest

It seems the request Request failed https://vscode-sync.trafficmanager.net/v1/manifest has failed. Can you please do following to get more Information about the error:

Open Shared Process (F1 > Toggle Shared Process) and let us know the error for above request

I believe this is what you're talking about:
request.ts:42 GET https://vscode-sync.trafficmanager.net/v1/manifest net::ERR_CERT_WEAK_SIGNATURE_ALGORITHM

Yes, it seems you have network connection issues, please fix them and try again.

It's probably related to me using a school computer. Thanks for the help.


[micro-dash] Feature request: improve omit() typing

The return type of omit() could be better than just Partial<T> in some cases. E.g.:
export function omit<T, K1 extends keyof T>(object: T, k1: K1): Omit<T, K1>;
export function omit<T extends object | Nil>(
  object: T,
  ...paths: Array<keyof T>
): Partial<T>;

Done


Remove version: SmartSoft.SmartFTP version 10.0.3129.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://static.smartftp.com/static/Products/Client/10.0.3129.0/x64/SmartFTP.msi
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 911)


Frame Type from 8 to 6 bits to increase Flags

Move 2 bits from Frame Type to Flags.
Discussions have led to the conclusion that we don't need more that 2^6 (64) frame types, but want to grant more room for future additions of flags.

EXT should be 0x3F (all 1s).

Right you are.

@NiteshKant and @stevegury Are you okay with this change?

Thanks for the review and "heart" @robertroeser Will merge since we have approval from @tmontgomery @robertroeser and Vijayan and myself.


Fixes integration test for mariadb 1.6.0 to 1.8.0

Wrong dependency version range specified.

Codecov Report

Merging #5226 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5226      +/-   ##
==========================================
- Coverage   40.51%   40.48%   -0.03%
==========================================
  Files        2671     2671
  Lines       80303    80303
  Branches    10700    10700
==========================================
- Hits        32533    32512      -21
- Misses      44877    44897      +20
- Partials     2893     2894       +1

Impacted Files
Coverage Δ

...rp/pinpoint/rpc/packet/ControlHandshakePacket.java
51.51% <0%> (-24.25%)
:arrow_down:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...nitor/DefaultDataSourceMonitorRegistryService.java
77.77% <0%> (-11.12%)
:arrow_down:

.../profiler/sender/StandbySpanStreamDataStorage.java
72.88% <0%> (-3.39%)
:arrow_down:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
82.92% <0%> (-2.44%)
:arrow_down:

...vercorp/pinpoint/common/server/bo/SpanFactory.java
75.59% <0%> (-1.2%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
78.81% <0%> (-1.05%)
:arrow_down:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
74.16% <0%> (+1.66%)
:arrow_up:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (+3.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af84eb9...72fff6a. Read the comment docs.


Impossible to use the dev server/preview functionality within an existing project

Describe the Bug
All the documentation recommends installing react-email into a new, fresh package – why is that?
Presumably the workflow a lot of people would want is to be able to build emails with react-email, and then send them with existing logic they have in their code base. We're using nodemailer and some frankenstein HTML generation code right now and would like to replace it. But if all the react-email stuff is in its own package (package A), how would one use the render() functionality to generate a templatized email from within an existing codebase (package B)?
Despite the docs' recommendation, I tried to get this working within our existing package, but since it's trying to copy over dependencies from my existing package.json and also merge them with requirements from the react-email template side of things, we get stuck in dependency hell.
Which package is affected (leave empty if unsure)
No response
Link to the code that reproduces this issue
can't share
To Reproduce

add react-email and @react-email/components dependencies to an existing NextJS project package.json
add a script entry to package.json: "email": "email dev",
npm run email

Since we're using next 12 and react-email stubs in several next 13 dependencies, we get a ton of warnings like the following:

I tried to edit the .react-email/package.json to more closely match the minimal one when doing npx create-email - but it just overwrites my changes and uses what it wants.
Expected Behavior
🤷🏻♂ I think the existing preview dev server infrastructure needs reworked because this is pretty painful. Rather than creating an entire subproject with its own set of dependencies, react-email should be able to compile and serve the preview server with a single command
What's your node version? (if relevant)
No response

But if all the react-email stuff is in its own package (package A), how would one use the render() functionality to generate a templatized email from within an existing codebase (package B)?

Here's an example with React Email + Next.js + Resend where you put all your emails in a folder (transactional) and still be able to import that email in your server.
And here if you don't want to use the react, you switch to html: render(MyEmail())

But if all the react-email stuff is in its own package (package A), how would one use the render() functionality to generate a templatized email from within an existing codebase (package B)?

Here's an example with React Email + Next.js + Resend where you put all your emails in a folder (transactional) and still be able to import that email in your server.
And here if you don't want to use the react, you switch to html: render(MyEmail())

Can we use with react for sengrid or it's resend specific?

Thanks @bukinoshita, that's a reasonable workaround for now.
I think it'd still be worth the investment to create a self-contained preview server script within react-email so that it's not necessary to create a new (hidden) subpackage every time.
Mailing has a similar offering that can do this in one command (npx mailing) – Prisma Studio also offers a similar database preview option (npx prisma studio).

But if all the react-email stuff is in its own package (package A), how would one use the render() functionality to generate a templatized email from within an existing codebase (package B)?

Here's an example with React Email + Next.js + Resend where you put all your emails in a folder (transactional) and still be able to import that email in your server.
And here if you don't want to use the react, you switch to html: render(MyEmail())

Can we use with react for sengrid or it's resend specific?

I don't think Sendgrid support react, but you can use the render method to convert to HTML which is supported.

Thanks @bukinoshita, that's a reasonable workaround for now.
I think it'd still be worth the investment to create a self-contained preview server script within react-email so that it's not necessary to create a new (hidden) subpackage every time.
Mailing has a similar offering that can do this in one command (npx mailing) – Prisma Studio also offers a similar database preview option (npx prisma studio).

Not really sure if I understood correctly, doesn't the npx mailing or npx prisma studio the same as npx react-email dev?


Feature: detect mixups between two single-byte encodings

There is apparently a fair amount of Spanish text out there that contains a mix-up between Windows-1252 and MacRoman before being encoded in UTF-8.
Because Latin-1 for Windows-1252 is the only single-byte mixup we detect, we assume that's what happened, and get text that looks like: "PrevŽn diputados inaugurar periodo de sesiones con c—digo penal".
This is not a false positive, because the encoding is in fact incorrect (it's actually got the UTF-8 encoding of the wrong characters in it), and ftfy is trying to fix it. It's in fact using the same fix that any web browser would use. However, the resulting text makes no sense, because it's not the correct fix.
This mixup is apparently common enough that it would be worth fixing as another special case.

Related: the mixup of "v3/43/4r" (ASCII-printed high-byte characters) coming from "v¾¾r" (CP850) coming from "vóór" (Windows-1252). See http://stackoverflow.com/questions/17654898/which-encoding-failure-did-encode-vóór-into-v3-43-4r

Man. That's an unfortunate mix-up. But it's not one ftfy should fix, because pure ASCII is not something to be messed with.
I should, however, look into "the infamous CP850" and whether ftfy should consider it as a possibility, so that for example it could decode UTF-8 re-interpreted as CP850.

What about this:
a = '''LiĂ¨ge Avenue de l'HĂ´pital'''  # french sentence
print(ftfy.fix_text(a.decode('utf8')))

# Out: LiĂ¨ge Avenue de l'HĂ´pital, no change from input, where it should be: Liège Avenue de l'Hôpital

Does this fit into this issue? I could not find any way to correct this (using ftfy or any other method).

It's been encoded in UTF-8 and decoded in Windows-1250. Here's the code that specifically fixes it (written in a way that should work in Python 2 or 3):
>>> text = u"LiĂ¨ge Avenue de l'HĂ´pital"
>>> print(text.encode('windows-1250').decode('utf-8'))
Liège Avenue de l'Hôpital

So this is within the scope of ftfy, it's just not a possibility that it currently checks for. I'm aware that Windows-1250 is used somewhat frequently in Eastern Europe, and it's probably a bias in my data collection that I haven't seen many examples of it.
I will open a new issue for this.

If we have something like this that's not problem
>>> print(ftfy.fix_text('uÌˆnicode')) ünicode
But if we use mixed encoding types something like this i.e
>>> print(ftfy.fix_text('Hi to ℙℽ☂ℌϕℿ uÌˆnicode')) ℙℽ☂ℌϕℿ uÌˆnicode
Expected to be(ℙℽ☂ℌϕℿ ünicode)
Why is this happening? Is this something that this library cannot handle?

ftfy makes kind of arbitrary decisions about how to handle mixed encodings: it allows the encoding to change at line breaks, and it also decodes the most common mojibake sequences like â€¢ even when they're inconsistent with the surrounding line.
Encoding a combining umlaut as Ìˆ isn't common enough to fall into that second case.

Man. That's an unfortunate mix-up. But it's not one ftfy should fix, because pure ASCII is not something to be messed with.
I should, however, look into "the infamous CP850" and whether ftfy should consider it as a possibility, so that for example it could decode UTF-8 re-interpreted as CP850.

Do you want me to make a separate issue out of https://github.com/LuminosoInsight/python-ftfy/issues/18#issuecomment-126046344 and point back to https://github.com/LuminosoInsight/python-ftfy/issues/18 ?

@rspeer I found back an offending document for "v3/43/4r" at Wayback] g428-1.pdf
Do you want me to make a separate issue out of it?

@jpluimers I can't tell what the Unicode issue you're linking is -- what's the mojibaked text, and can you tell which encodings were mixed up?

trying to follow this: do you have a place where it says "v¾¾r" and hasn't been flattened into "v3/43/4r"?

trying to follow this: do you have a place where it says "v¾¾r" and hasn't been flattened into "v3/43/4r"?

Didn't have time to dig for this earlier, as there were too many "5-minute" things that ended up taking loads more time.
I should have rescheduled, as https://www.google.com/search?q="v¾¾r" was indeed less than a "5 minute thing". A few of the results:

https://commons.wikimedia.org/wiki/File:Overdracht_van_goederen_voor_Griekenland._Het_verhuisbedrijf_Beck_v¾¾r_het_stadhuis_jan._1951_GN15237.jpeg (in the title)
https://disco.datawonen.nl/variable?versieid=WOON15V2&variablecode=ZelfdeHH (in one of the first headings)
https://www.kroonint.nl/bakta-tabletten-6x250-stuks (in the body text)

Then came the hard part, trying to make sense of what ftfy can do (:
For all the above texts, https://ftfy.vercel.app/ wrongly comes up with something like this (note I pasted v¾Â¾r)
s = 'vÂ¾Â¾r'
s = s.encode('latin-1')
s = s.decode('utf-8')
print(s)

You can very the wrong handling using for instance https://ftfy.vercel.app/?s=v¾¾r
I verified this at https://www.python.org/shell/:
Python 3.9.5 (default, May 27 2021, 19:45:35)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.system('sh')
$ pip3 install ftfy
Defaulting to user installation because normal site-packages is not writeable
Looking in links: /usr/share/pip-wheels
Collecting ftfy
  Downloading ftfy-6.1.1-py3-none-any.whl (53 kB)
     |████████████████████████████████| 53 kB 2.8 MB/s
Requirement already satisfied: wcwidth>=0.2.5 in /usr/local/lib/python3.9/site-packages (from ftfy) (0.2.5)
Installing collected packages: ftfy
Successfully installed ftfy-6.1.1
$ python
Python 3.9.5 (default, May 27 2021, 19:45:35)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import ftfy
>>> s = 'v¾¾r'
>>> s = s.encode('latin-1')
>>> s = s.decode('utf-8')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xbe in position 1: invalid start byte
>>> print(s)
b'v\xbe\xber'
>>>

On the console, it does not get recognised either in the same Python session:
>>> ftfy.fix_and_explain("v¾¾r")
ExplainedText(text='v¾¾r', explanation=[])
>>>

But it is indeed "the infamous CP850", as when I continue this in the same Python session:
>>> s = 'v¾¾r'
>>> s = s.encode('cp850')
>>> s = s.decode('latin-1')
>>> print (s)
vóór
>>>

If you could have ftfy search for 3/43/4 then treat it like ¾¾ and recognise it as a potential CP3850 problem, especially in Dutch texts.
Even for non-Dutch texts, ¾¾ is often an encoding problem. I browsed through the first 10 pages of results for https://www.google.com/search?q="¾¾" and most of them were encoding problems. One English example is https://steffenthomas.org/about/about-the-museum/grant-to-green/ where the ¾¾ seem to be bullet points. This might even be a missing font or melon emoji used as bullet point.
Hope this clears a few things up.


fix cross compilation error in 32 bit architecture

@ProgramCpp This is the fix for the following error when we build the binaries for 32 bit architectures.
x/gitopia/keeper/msg_server_exercise.go:40:18: TEAM_VESTING_AMOUNT / VESTING_PERIOD (untyped int constant<PHONE_NUMBER>333) overflows int
make: *** [build/gitopiad_2.0.0-rc.1_windows_386.zip] Error 2

lgtm


Improved lqe calling functionality

This PR updates the lqe() function to allow it to be called with a StateSpace system as the first argument rather than the matrices that define the system.  This matches the functionality of the lqr command.  Docstrings have been updated to reflect the new functionality and to match the notation used for lqr a bit better.  Unit tests added to cover the new code.
This PR has some overlap with #670, so depending on which gets merged first it may be necessary to rebase.

Coverage decreased (-0.04%) to 90.042% when pulling 06aa0d8b64753261101b9a1ee33581c62620eddd on murrayrm:enh-lqe into 56cecc03eea276cb21265552846bffbc3cc709e3 on python-control:master.


Class 'Codeception\Module\Module' not found in vendor/whatdafox/codeception-mailtrap/src/Mailtrap.php on line 33

I've just checked this module with codeception v2.4.1, but i get an error Class 'Codeception\Module\Module' not found in vendor/whatdafox/codeception-mailtrap/src/Mailtrap.php on line 33 when running 'codecept build'
The Mailtrap class uses the namespace Codeception\Module, so the extended codeception abstract Module class without full namespace resolves to Codeception\Module\Module, which does not exist.
Solution
class Mailtrap extends \Codeception\Module
{

Also causing me issues :+1:

I am also getting the same error. Looks like Mailtrap changed their site structure since https://mailtrap.io/api/v1/ now goes to a 404 page.


Fix scrolling emoji picker with arrows

Details

Use scrollIntoView for scrolling emoji list instead of manually scrolling to prevent bugs caused by wrong calculation of the scroll offset.
Fixed Issues

$ https://github.com/Expensify/App/issues/24471
PROPOSAL: https://github.com/Expensify/App/issues/24471#issuecomment-1675806768
Tests

Open any chat/conversation
Open the emoji picker
Press the down arrow to scroll downwards
Check whether the selected emoji is focused and the blue outline is visible

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Open any chat/conversation
Open the emoji picker
Press the down arrow to scroll downwards
Check whether the selected emoji is focused and the blue outline is visible

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/120749263/34788c9c-2c82-43f0-a8cc-3c2e23ef9482

Mobile Web - Chrome
N/A

Mobile Web - Safari
N/A

Desktop

https://github.com/Expensify/App/assets/120749263/4c43017f-5981-4171-8d39-0b31c6c856ef

iOS
N/A

Android
N/A

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/24796318/bb100629-d2b3-4a05-a875-86377b367516

Mobile Web - Chrome

https://github.com/Expensify/App/assets/24796318/652ea2d9-4167-4cd9-a9d4-13ca48af49ae

Mobile Web - Safari

https://github.com/Expensify/App/assets/24796318/939621b3-e6b7-4373-9aad-5a0786f1bc97

Desktop

https://github.com/Expensify/App/assets/24796318/cb97e40d-8e83-4f7b-87f6-01319bebaeb8

iOS
https://github.com/Expensify/App/assets/24796318/227cb0f2-23d3-428e-b12d-bc9e64d721db

Android

https://github.com/Expensify/App/assets/24796318/8d8a2855-06d0-4cbe-b6db-91325becb667

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.64-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.65-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.65-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Automate collection of GitHub id by name from CI workflows

The current manual process for finding the workflow ID is cumbersome.
Make it so you just need the name or something easier.
See also @basiliskus comment in #134

This may be good news.  We currently call gh.get_workflow(id) but it the docs suggest we can also pass in a filename instead of the integer id.
If the deployment action under stud is in .github/workflows/ci-cd-workflow.yaml we should be able to replace the numberic value with the string ci-cd-workflow.yaml.
Testing TBD

Validated that passing the workflow filename instead of the numeric id does yield the same results for a CDC TI workflow.

What I discovered is that there is a solution without a code change if the id value in the config file is given the name of the workflow file, e.g. cicd.yaml , instead of the numeric ID value.
So the first refactor would just change the docs and maybe some comments to tell the user to put the filename of the workflow in the id value in the config file.
But now we have a sloppy configuration variable, which should have a name like workflow_filename or filename , and refactoring by renaming the variable name throughout. Refactor 2.
Go with refactor 2 after discussion with CDC team

Implemented in #508


enable users to speficy where they want to install cosign

Description
By default cosign will be installed into the directory $HOME/.cosign, maybe we can accept a variable from users to let them specify where they want to install cosign binary.
WDYT @dentrax @cpanato?

would you mind assigning this to me 🙋🏻♂

sounds good to me


Support Ruby 3.1's anonymous block argument syntax

Follow up to https://github.com/rubocop/rubocop-ast/pull/218.
This PR supports Ruby 3.1's anonymous block argument syntax and fixes the following error.
% ruby -v
ruby 3.1.0dev (2021-12-01T02:00:10Z master 0b53a8895f) [x86_64-darwin19]

% echo 'def foo(&) = bar(&)' | be rubocop --enable-pending-cops --stdin example.rb
Inspecting 1 file
.

0 files inspected, no offenses detected
undefined method `type' for nil:NilClass
/Users/koic/.rbenv/versions/3.1.0-dev/lib/ruby/gems/3.1.0/gems/rubocop-ast-1.13.0/lib/rubocop/ast/traversal.rb:131:in
`on_block_pass'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/commissioner.rb:71:in
`on_block_pass'
/Users/koic/.rbenv/versions/3.1.0-dev/lib/ruby/gems/3.1.0/gems/rubocop-ast-1.13.0/lib/rubocop/ast/traversal.rb:159:in
`block in on_send'
/Users/koic/.rbenv/versions/3.1.0-dev/lib/ruby/gems/3.1.0/gems/rubocop-ast-1.13.0/lib/rubocop/ast/traversal.rb:156:in
`each'
/Users/koic/.rbenv/versions/3.1.0-dev/lib/ruby/gems/3.1.0/gems/rubocop-ast-1.13.0/lib/rubocop/ast/traversal.rb:156:in
`each_with_index'
/Users/koic/.rbenv/versions/3.1.0-dev/lib/ruby/gems/3.1.0/gems/rubocop-ast-1.13.0/lib/rubocop/ast/traversal.rb:156:in
`on_send'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/commissioner.rb:71:in `on_send'

This PR makes RuboCop require Parser 1.14 or higher Because this error resolved by https://github.com/rubocop/rubocop-ast/pull/218.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR makes RuboCop require Parser 1.14

It does?
I'm not against the PR, but I'm not sure that we should (on principle) bump dependencies when we don't have to. RuboCop will continue to be compatible with the older rubocop-ast / parser.
May be related, but I probably should have done a patch release of rubocop-ast, as it's API has not changed.

Since the next RuboCop release, I think it's worth that it will ensurelly prevent the above NoMethodError when using anonymous block forwarding syntax :-)


WARN: Side effects in initialization of unused variable _error when trying to build on Ubuntu

When running npm run build on Ubuntu the build freezes with a warning saying WARN: Side effects in initialization of unused variable _error [-:621,1418]

leoalves@ubuntu:~/graphiql$ npm run build
<EMAIL_ADDRESS>build /home/leoalves/graphiql
. ./resources/build.sh
src/codemirror/lint/json-lint.js -> dist/codemirror/lint/json-lint.js
src/codemirror/lint/jsonLint.js -> dist/codemirror/lint/jsonLint.js
src/components/DocExplorer.js -> dist/components/DocExplorer.js
src/components/ExecuteButton.js -> dist/components/ExecuteButton.js
src/components/GraphiQL.js -> dist/components/GraphiQL.js
src/components/QueryEditor.js -> dist/components/QueryEditor.js
src/components/ResultViewer.js -> dist/components/ResultViewer.js
src/components/ToolbarButton.js -> dist/components/ToolbarButton.js
src/components/VariableEditor.js -> dist/components/VariableEditor.js
src/index.js -> dist/index.js
src/utility/elementPosition.js -> dist/utility/elementPosition.js
src/utility/fillLeafs.js -> dist/utility/fillLeafs.js
src/utility/find.js -> dist/utility/find.js
src/utility/introspectionQueries.js -> dist/utility/introspectionQueries.js
WARN: Side effects in initialization of unused variable _error [-:621,1418]

tried in two different machines and both happened the same issue.
Node v 5.7.0
npm v 3.6.0
ran npm install before running the build command

Does it completely freeze? For me it just takes a little more time (maybe ~45 seconds, which I just let it run and do other stuff meanwhile) until it finishes building.
That warning message seemed to come from uglify catching unused variables/functions in other modules in node_modules dir. The message could be suppressed by having an option to disable warning while running uglify (-c warnings=false).


Key bindings ignore additional modifiers

The commands cmd + C and cmd + F are invoked even when any combination of shift, ctrl and alt is pressed at the same time.

We should change the key bindings to alt + C / alt + F or cmd + shift + C / cmd + shift + F. The current ones are already standard bindings for copy and find.


trunk build/serve fail at fetching cargo artifacts when internet access is via an http proxy

Hi there,
I have searched to see if anyone else has reported a similar problem - so forgive me if I've still somehow managed to miss a related case.
I've been trying to use trunk on my work machine, a Windows 10 box - and I've tried both via WSL2 (my preferred dev environment) and native windows builds - and both seem to be failing during the attempt to pull down the cargo artifacts to build the project. Note that running cargo build works fine - so it would seem cargo itself is happy with my HTTP proxy configuration.
What I see is this (in both environments, either WSL2, or native windows) :

source/rust/rust-frontend-example-yew on  master ? is 📦 v0.1.0 via 🦀 v1.54.0 🕙[ 08:14:18 ]✗ trunk -v build
Sep 07 08:14:26.644  INFO 📦 starting build
Sep 07 08:14:26.645  INFO spawning asset pipelines
Sep 07 08:14:26.762  INFO building rust-frontend-example-yew
Finished dev [unoptimized + debuginfo] target(s) in 0.03s
Sep 07 08:14:26.880  INFO fetching cargo artifacts
Sep 07 08:14:27.004 ERROR ❌ error
error from HTML pipeline

Caused by:
0: error from asset pipeline
1: could not find WASM output after cargo build
Error: error from HTML pipeline

Caused by:
0: error from asset pipeline
1: could not find WASM output after cargo build

Have I done something obviously stupid here? On inspecting the documentation around the proxy support in Trunk itself, I think I'm right in thinking this is to proxy requests coming through trunk itself to some backend system, and isn't anything to do with the build pipeline? Or am I wrong there?

About two and half year later:  @godeater for which reason should this issue be left open?

I gave up with it, so I guess you can close it.


Problem: We need a way to update cell outputs

Solution: Create an action and reducer for updating cell outputs

Yay!  This is awesome, now we just need to enchannel -> dispatch this on display data


Spring Cloud Bus broken with Camden.SR5 and spring boot 1.5.1

I had a project with Camden.SR4 and spring boot 1.4.3. Spring Cloud Bus worked fine, however after incrementing version to Camden.SR5 and spring boot 1.5.1 POSTing to /bus/refresh will not refresh other services (only the service on which /bus/refresh is called is refreshed).

Duplicate of #55?

Hi Spencer,
Thank you for the hint on #55
However, I've retested everything. The issue is that Cloud Bus always works on MacOS X. With both 1.5.1 + Camden.SR5 and 1.4.3 + Camden.SR4. The issue is that it does not work on Windows 7. May be it is related to my particular Windows, I am not sure though. Do not have a second Windows PC to check :)
On Windows both 1.5.1 + Camden.SR5 and 1.4.3 + Camden.SR4 Clid Bus does not propagate refresh events to services.

By the way, Cloud Stream works fine. The issue is related to Cloud Bus

There was an issue upstream in spring cloud stream which caused a problem in bus (but not generic stream). Can you try with snapshots?

I have retested everything with latest releases of Boot - 1.5.2 and Cloud - Camden.SR6.
Everything works fine now. Bugs are fixed with these releases.
Thank you!


Gallery changes

working on styles
adding title bar for gallery and gallery overlay

Fix #239
Test URLs:

Before: https://main--hubblehomes-com--aemsites.hlx.page/new-homes/idaho/boise-metro/caldwell/brittany-heights-at-windsor-creek
After: https://issue-239--hubblehomes-com--aemsites.hlx.page/new-homes/idaho/boise-metro/caldwell/brittany-heights-at-windsor-creek

•	The navigation arrows appear in the middle of the images. Shouldn’t they be more at the edges, similar to Woodside’s design where the arrows are outside the images?

•	The banner is smaller in length compared to the images. It might look better if it matched the length of the images.
•	The padding between the header and the image looks a bit strange, as there seems to be too much of a gap.

•	Woodside’s gallery takes up more screen space compared to ours.

What do you think about the width of the gallery header? Should it match the width of the images?
Let's limit the size of the images to a maximum width for a better viewing experience.