DSP 13: Add dOrg Code of Ethics

Closes #9

Looks great! Also, what's the rational behind slashing REP of inactive members? I kind of like the idea of keeping people's REP assigned to their accounts, and in the event of airdrops anything they don't claim will go to the other members who have claimed.

Looks great! Also, what's the rational behind slashing REP of inactive members? I kind of like the idea of keeping people's REP assigned to their accounts, and in the event of airdrops anything they don't claim will go to the other members who have claimed.

That's an excellent counterpoint and I plan on scheduling a meeting to review these proposed changes when they're near final. The challenge with having inactive members with Rep is that (as you will see in my coming changes) passing a proposal to suspend or expel a member will likely have to be done through absolute majority. This is because I anticipate malicious down-staking of those proposals to occur by the supendee/expellee which would necessitate a staking bidding war to pass these proposals via relative majority (boosting). There's also a risk of a aggrieved supendee/expellee retaliating by attempting to halt dOrg operations by downstaking all proposals. Obtaining absolute majorities to counter this could be challenging or even impossible if some large Rep holders are inactive. I'm open to other alternatives though--perhaps there's some way to reconfigure our DAOStack DAO to address these issues?

I have a few questions. Sometimes, the corrective/restauratory measures require measurement of the severity of the offense. Sometimes, to even select a measure there is some judgement required (expulsion, for instance, requires us to deem the offender's attiude incorregible).

So, who are the ones who would take these decisions and how?:

Should there be a proposal and the whole DAO vote?
Should it be handled privately but asking all repholders for opinion, if so, does rep make the opinion's wieght vary?
Should it be reserved for dOrg admins (51% rep treshold)?
Should we come up with a different treshold for these kinds of decisions?
Should we take in the opinions of all members but if the offender has endorsed others, should the endorsed be left out to avoid bias? Just brainstorming.

Who should/will conduct mediations?

Really great questions all around, Nestor! I confess that there are some questions that I have shied away from answering within the code of conduct to avoid centralization of power or limiting adaptability within dOrg.

I have a few questions. Sometimes, the corrective/restauratory measures require measurement of the severity of the offense. Sometimes, to even select a measure there is some judgement required (expulsion, for instance, requires us to deem the offender's attiude incorregible).
* So, who are the ones who would take these decisions and how?:

-Should there be a proposal and the whole DAO vote?
Any builder could choose to make a proposal based on this but their proposal should be evaluated by the DAO based on whether the enforcement processes outlines in the Code of Ethics were followed and whether the enforcement option selected is proportionate on a case-by-case basis.
-Should it be handled privately but asking all repholders for opinion, if so, does rep make the opinion's wieght vary?
I think pre-mediation, it can be handled privately, if need be. But if mediation occurs, I think a 'censure' proposal is important as record of a sort of a formal written warning to the offenders (think of it as a comparable warning step to more traditional companies). In the proposal case, Rep would vary opinion weight as it traditionally does. I think it's okay to have opinion weight vary according to Rep as Rep should ideally represent investment & contribution in dOrg: someone who is more invested in dOrg's success should have more Rep, someone who is less should have less (this is also part of the reason I propose removing Rep on deactivation).
-Should it be reserved for dOrg admins (51% rep treshold)?
The dOrg moderators are admins in this case so I see them as responsible for deciding whether an individual should retain access to internal spaces during this process and to what extent.
-Should we come up with a different treshold for these kinds of decisions?
This is the best that I've been able to come up with so far but I'd be open to other suggestions.
-Should we take in the opinions of all members but if the offender has endorsed others, should the endorsed be left out to avoid bias? Just brainstorming.
I think that should certainly be taken into account by the builders and be noted in the record of any disciplinary proposal.
* Who should/will conduct mediations?

I think a mutually agreeable mediator could be selected with consensus of the victim(s) and the offender(s) (any builder within dOrg). If there is no consensus, it should be one of the dOrg admins.
Let me know if any of these thoughts should result in revisions/clarifications to the code.

Looks great! Also, what's the rational behind slashing REP of inactive members? I kind of like the idea of keeping people's REP assigned to their accounts, and in the event of airdrops anything they don't claim will go to the other members who have claimed.

I wish there was a way to remove people's REP from the total voting pool when they are inactive, but keep it intact for things like airdrops.
If someone has 10% of the total REP and is inactive, that's 10% of the votes that will never be cast.

I think this is well put together. I'll give it another read tomorrow, but for now some things that stick out to me:

How do we keep documents private and/or only visible for dOrg members? Are they just on Google Drive shared only with the organization?
What is extent of "Accepting work from dOrg clients/partners independently without paying a referral fee (20%) to dOrg for sourcing said work"; If i'm not mistaken, there are some dOrg members who have gone on to work for dOrg clients independently and I don't think they have been paying the referral fee. There might need to be some more clear guidelines, or expirations around this

Looks great! Also, what's the rational behind slashing REP of inactive members? I kind of like the idea of keeping people's REP assigned to their accounts, and in the event of airdrops anything they don't claim will go to the other members who have claimed.

I wish there was a way to remove people's REP from the total voting pool when they are inactive, but keep it intact for things like airdrops.
If someone has 10% of the total REP and is inactive, that's 10% of the votes that will never be cast.

I think this is fine as long as we treat everything as just requiring relative majority. needing absolute majority will never be scalable (even at our current size)

I think this is well put together. I'll give it another read tomorrow, but for now some things that stick out to me:
* How do we keep documents private and/or only visible for dOrg members? Are they just on Google Drive shared only with the organization?

I think Google Drive is the only method we have currently and I believe it's a reasonable one in the short term.

* What is extent of "Accepting work from dOrg clients/partners independently without paying a referral fee (20%) to dOrg for sourcing said work"; If i'm not mistaken, there are some dOrg members who have gone on to work for dOrg clients independently and I don't think they have been paying the referral fee. There might need to be some more clear guidelines, or expirations around this

Many of the existing rules in the code of ethics are related to things that have actually occurred. I don't think it makes sense to go months back to enforce this provisional code retroactively. But going forward, we should be on the look out for this and raise the issue if this behavior is observed. It shouldn't be an incredibly controversial topic if a builder is freelancing with one of our clients/partners, they'd just have to add 20% to their fee. If they are becoming employed, then the logistics are more difficult and may require some changes to our contractor term sheet.

* Who is a moderator? Are they voted on? A formal process may need to be mentioned, even if it's just a something we vote on and then they become a moderator.

There used to be documentation about this but I don't know where it went. @orishim may know. Essentially, we once had an admin threshold based on Rep but I'm not sure if that's changed. We probably should have processes around this but I'm not sure what the current state is and why it changed.

Questions still to answer:

[ ] Should suspension include Rep slashing? Should there be a suspension option without Rep slashing or is the risk of retaliation too high?
[ ] Should deactivation from inactivity include Rep slashing? Or do the builder experience benefits (indefinite Airdrops proportionate to Rep) outweigh the potentially lost voting power and its accompanying risks?

[ ]  Should suspension include Rep slashing? Should there be a suspension option without Rep slashing or is the risk of retaliation too high?

I think we could keep it simple by having a default penalty like "10 day suspension with 10% Rep slash"

[ ]  Should deactivation from inactivity include Rep slashing? Or do the builder experience benefits (indefinite Airdrops proportionate to Rep) outweigh the potentially lost voting power and its accompanying risks?

I do not think that inactivity should be accompanied by rep slashing.

I think this entire code of ethics is a huge game changer for operations and community practice in dOrg. It should be reviewed by every member and comments provided over a reasonable timeframe - this went up for a vote at the start of the holiday weekend and it may pass before people get back to work on Tuesday. They may feel excluded from having their voices heard

@orishim @dOrgJelli @namesty
Specific feedback - I think the line about stalking and harassment (which I have experienced at dOrg) is not clearly worded in this document. I don’t know how understandable it will be to people who pursue unwanted contact with members.
Hard to understand >> Engagement in abuse, discrimination, disrespect, harassment, or promotion of said or otherwise offensive content against/to any prospective/past/current dOrg client/partner/builder

@namesty @orishim @dOrgJelli
Given that dOrg’s first ever attempt at a mediation process yesterday was ineffective - It doesn't seem like that particular process is fit to be ratified here.

TO-DO (takeaways from Discord discussion):

[ ] Add "Encouraged Behaviors" of positive things that should be done at dOrg
[ ] Add consult with author(s) before sharing documents whose permissions are not set to public

Specific feedback - I think the line about stalking and harassment (which I have experienced at dOrg) is not clearly worded in this document. I don’t know how understandable it will be to people who pursue unwanted contact with members.

Please feel free to propose a better phrasing of this line.

Hard to understand >> Engagement in abuse, discrimination, disrespect, harassment, or promotion of said or otherwise offensive content against/to any prospective/past/current dOrg client/partner/builder

In my opinion this is what we have group consensus for. Feel something has broken this rule? Create a vote. This is the only concrete way we have to poll the collective's sensibilities (IMO).

https://alchemy.daostack.io/dao/0x94a587478c83491b13291265581cb983e7feb540/proposal/0x61d420be1c718590c1faf18e4d39f8d32e0a62451f00a8bcefa8ba6fa0d7aee2


Updated RSS feed icon shape

Short description

Reshape rss feed icon
Proposed changes

Added rounded corners and increased icon size.

Resolved issues

Fixes: #724
Proposed icon shape

Yes, we can discuss it later. My reference for that PR is the screenshot from #5, there you can check out my "role model" for the RSS feed layout. But #5 is from 2018 and I have no access to the current wordpress cms, that might be the cause for the deviation to your posted screenshot.


What does autoregressive mean?

What does autoregressive mean in this context? Is the causal flag related to the autoregressive wrapper?

@matthew-jurewicz yup! causal means autoregressive! it's a big fancy word for saying predicting (a future token) based on the past (past tokens) You do this in an attention network by preventing the past from seeing the future using a mask. All modern text generators (GPT family) are autoregressive flavors of attention networks.

Awesome! Quick question, the Transformer should work with time series data and I can skip the embedding layer since time series aren't sparse?

Yes, absolutely. Not well explored, but I'm sure it will work. Look at what I came across today https://twitter.com/St4ck_Overflow/status/1283782615011663875?s=20

Brainwaves are time series data

You can also replace the embedding layer with a linear projection from your scalar values into the embedding space of the model, this has worked well for me. If you do this, you'll also need to replace the last layer of the model with a regression head. A single hidden layer with Relu or Gelu followed by a linear projection has worked for me.

I haven't seen much on the application of Transformers to time series data either. Strange, seems obvious.

yes, you should try it and report the results, if they are positive! the machine learning community will thank you!


Peer-to-peer Morning

Good job so far!
Please here's a few recommendations I would love you to consider:
In order to collect each input the user types, I will recommend you use the input event instead of keypress.


Remove default http timeout limit

When the single-layer image is too large or the network bandwidth is poor, it is easy to reach this timeout period. The default resolver of docker has no timeout limit, so this timeout limit is removed here, and the timeout is controlled by upper-layer tools such as nerdctl/ctr/crictl.
Signed-off-by: zyfjeff<EMAIL_ADDRESS>

Codecov Report
Base: 29.80% // Head: 30.00% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (455c472) compared to base (8cc0c23).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   29.80%   30.00%   +0.19%
==========================================
  Files          20       20
  Lines        1651     1650       -1
==========================================
+ Hits          492      495       +3
+ Misses       1094     1090       -4
  Partials       65       65

Impacted Files
Coverage Δ

pkg/filesystem/fs/resolver.go
0.00% <ø> (ø)

pkg/filesystem/fs/blob_manager.go
55.55% <0.00%> (+11.11%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

How can the upper layer tool you metioned handle timeout? Is there a CLI parameter?

How can the upper layer tool you metioned handle timeout? Is there a CLI parameter?

sure, ctr has timeout parameter,
--timeout value              total timeout for ctr commands (default: 0s)
and, nerdctl、circtl also has timeout parameter


Scan on Flutter Web (iOS, macOS only) not working

Error message:
mobile_scanner: MobileScannerException: code permissionDenied, message: NoSuchMethodError: method not found: 'BrowserMultiFormatReader' on null
This happens using mobile scanner version 3.3.0 (newest at this point in time)
This error does not occur:

on Android native
on Android web

This error occurs:

on iOS web
on macOS web

This happens although camera permissions were granted to the flutter web app
Any idea?

Same with me

When we will resolve this ?? stuck in the same issue.

any update on this issue?

This seems to be an issue after upgrading the flutter version:
For now, I was able to resolve it with this added to the head in my index.html:
`
`


Remove invalid await

There is no async function to use await correctly

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @iamphduc!

  Generated by :no_entry_sign: dangerJS against 96018f770278c67c85778a233a3f932bec5d6406

Thanks for your reviewing! Silly me that I didn't know top-level await existed.
I've learned a new thing today xD

No worries!


#104 Cannot start SonarQube because of duplicated rule

Fixes #104

Coverage remained the same at 96.418% when pulling d374afde64ae9915ad7d6777a1fd98c757ea27ce on issue-104 into 3173f50367ca99d624124a83cb55f78bcfe2dae5 on master.


gh-1928 Refactored AddElementsFromRDD in Parquet store

Codecov Report

Merging #1931 into develop will decrease coverage by 0.08%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop    #1931      +/-   ##
=============================================
- Coverage       64.8%   64.71%   -0.09%
- Complexity      2227     2228       +1
=============================================
  Files            882      882
  Lines          28911    28954      +43
  Branches        3618     3616       -2
=============================================
+ Hits           18737    18739       +2
- Misses          8701     8743      +42
+ Partials        1473     1472       -1

Impacted Files
Coverage Δ
Complexity Δ

...tion/handler/spark/ImportRDDOfElementsHandler.java
33.33% <0%> (ø)
0 <0> (ø)
:arrow_down:

...re/operation/handler/spark/AddElementsFromRDD.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../handler/spark/ImportJavaRDDOfElementsHandler.java
33.33% <0%> (ø)
0 <0> (ø)
:arrow_down:

...onutil/iterable/LimitedInMemorySortedIterable.java
50% <0%> (+2.77%)
16% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b7d34...f92e841. Read the comment docs.


Add Map to source language, lift common variant fields in Scala, ...

Scala generator creates correct package names.
Add Map to source language, very basic handling in generators for Python, Scala, Swagger.
Define Circe KeyEncoder and KeyDecoder instances for newtypes of [some] base types.

Any reason why KeyEncodes are generated using the instances of their wrapped types, while KeyDecoders contain their own parsing code?
Also if those two generating function return a maybe (which Nothing instead of mempty) we won't have dangling lines with trailing whitespace at the end of the companion objects).

Updated to resolve most recent comments.


Add icon to LIMO token

My logo is according to requirements.
The trustwallet app is not showing the new logo

Please upload the file to your master branch \blockchains\ethereum\assets\0xc7ac23aa559e975548ac959e4d1c926830093554


SnapshotAsync should return an object not a string

https://github.com/microsoft/playwright-sharp/pull/1113/files?file-filters[]=.cs&file-filters[]=.csproj&file-filters[]=.xml#diff-a6945f2731fe711ebb9a0ad88372efe18ed6a706d9401a180811a4e0c4e83d1aR89

Actually, this is intentional. It was decided that the Accessibility object provides no added value to the caller so we'd rather return a string.


Add uploaded files to ServerRequest

A uploaded file should be added to the ServerRequest object. To check for an uploaded file in the body, the body must be parsed, which is similar to #105. How this should be handled is defined in the docblock of the method in the PSR-7 ServerRequestInterface
The roadmap shows that this feature is targeted for version v0.8.0.

Closed via #226


Improve editor toolbar design

Instead of this:

We could have like this:

The editor menu should use sliding on small screen, similar than #1464


SSL requests are failing in 2.0

I'm getting the following error for every single HTTPS request I send:
Error Domain=NSURLErrorDomain Code=-1012 "The operation couldn’t be completed.
I've traced down the issue to AFURLConnectionOperation's - (void)connection:(NSURLConnection *)connection willSendRequestForAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge method.
The securityPolicy (which is not the same as the AFHTTPRequestOperationManager's - separate issue [will file separately]) is failing the evaluateServerTrust.
We're using a valid SSL cert and this worked perfectly in 1.x releases.
Any ideas?

I have solved the same issue even with latest version of AFNetworking and AFSSLPinningModeNone.
I have wildcard self-signed certificate (*.mydomain.com) for test deployments and for some self-hosted web app. But api.mydomain.com In y case I was sending requests to the api.mydomain.com`

Ran into same issue even using
let manager = AFHTTPRequestOperationManager()
manager.securityPolicy.allowInvalidCertificates = true;
Any mistake ?

Creating security policy as following and updating AFNetworking to v2.6.0 fixed all my issues with error code=-1012
 AFSecurityPolicy *securityPolicy = [AFSecurityPolicy policyWithPinningMode:AFSSLPinningModeNone];
    [securityPolicy setValidatesDomainName:NO];
    [securityPolicy setAllowInvalidCertificates:YES];

Related to this issue http://stackoverflow.com/questions/27808249/problems-with-ssl-pinning-and-afnetworking-2-5-0-nsurlerrordomain-error-1012


Updated the Vignettes Page to reflect new and contributed vignettes

LGTM, note that I approve the new structure of the readme. Note also that there is still a lot of work that needs to be done to bring these vignettes up to date.


SAMZA-1638: Recreate SystemProducer on KafkaCheckpointManager.writeCheckpoint failures.

Retry loop in the existing KafkaCheckpointManager implementation retries using the same SystemProducer instance on exception and does not recreate it.
When some irrecoverable exceptions occur within the SystemProducer, all the subsequent produce message invocations on the SystemProducer instance will fail. This had made the entire retry loop on KafkaCheckpointManager pointless.
This patch consists of the following changes:

This patch addresses the above problem by recreating the SystemProducer instance on failure and adds a unit test to verify the functionality.
Minor code cleanup in classes: TestKafkaCheckpointManager and KafkaCheckpointManager.

@xinyuiscool @prateekm
Please take a look when you get a chance.

@dnishimura Can you please review this patch when you have some time.

@lindong28, can you take a look at this?

@shanthoosh and I discussed with Radai and Sean offline. It is not clear that this patch can will fix the issue described in LIKAFKA-20228 because we don't know the root cause of that issue yet. It also seems hacky to reinstantiate kafka producer to address issue -- if this can fix anything then kafka producer should reinitialize something internally and retry without exposing failure to the user.
I will help look into the kafka producer issue. Let's try to figure out the root cause of that issue before having any hotfix in Samza to reinstantiate producer upon exception.

@lindong28 @shanthoosh, regardless of the cause for that specific exception, I think it's still possible that a KafkaProducer fails due to a temporary broker-side issue (e.g. message send timeout due to temporary broker availability). IIRC, timeouts are considered fatal for the producer and are not recoverable. In this case, we still want to recreate the producer and retry the send instead of failing the container. Please correct me if I'm misunderstanding Kafka behavior.

@prateekm @shanthoosh The temporarily broker side (or network-related) issue should not cause persistent failure on producer side. It may cause failure for a given request but KafkaProducer is expected to still function correctly for the future request after the broker side issue goes away.
After going through the code in org.apache.samza.checkpoint.kafka.KafkaCheckpointManager.java and com.linkedin.samza.system.kafka.SamzaLiKafkaSystemProducer, it appears that SamzaLiKafkaSystemProducer will record the first produce failure exception in fatalException which causes all future calls of send() to fail with this exception. It does not make sense to make all send() to fail after one send() failure. Maybe we should fix this behavior by e.g. sending fatalException = null after this exception has been exposed to caller (e.g. KafkaCheckpointManager ).

@lindong28 's suggestion might require exposing the async callback in the KafkaSystemProducer: https://issues.apache.org/jira/browse/SAMZA-1393
@jmakes @prateekm is what I said correct?

@lindong28 Thanks for sharing your feedback. The ratoinale behind recreating KafkaSystemProducer was based upon the recommendation I received from few members of kafka team. It was claimed that there was SSL excpetions in producer  are irrecoverable and it will be better to retry  by recreating the producer instance from samza side.
Now if that is unnecessary and existing SamzaLiKafkaSystemProducer implementation throws up on the first occurrence of any kafka exceptions. Do you think it will be useful to add configurable, fixed retries on kafka exceptions in SamzaLiKafkaSystemProducer implementation. By this we can get the following benefits:

First occurrence of exception in the SamzaLiKafkaSystemProducer wouldn't make the SamzaLiKafkaSystemProducer instance unusable.
Retries would be closer to the kafka i/o layer where we can decide whether to retry on specific retriable exceptions thrown by kafka.

What do you think?

@shanthoosh @lindong28 @dnishimura Let's discuss offline, this discussion is getting too long for a PR.

@prateekm and I discussed offline. Here is the summary:

There is no irrecoverable in KafkaProducer.

SamzaLiKafkaSystemProducer.send(String source, OutgoingMessageEnvelope envelope) sends message asynchronously and it does not provide way to tell caller whether a given message has been sent successfully. Thus we are using the fatalException to tell whether there has been any message send() failure. As long term solution, we need to improve this API design, probably similar to KafkaProducer's API, so that caller can tell whether any given message has been sent successfully. T

Due to the issue explained above, SamzaLiKafkaSystemProducer will fail persistently after one send() failure. Thus we need to re-instantiate producer after each failure. This is the approach adopted in this PR.

Another issue is that, currently KafkaCheckpointManager will retry using exponential backoff starting from 100 ms up to 10 sec per back-off. This means that up to 4 attempts can be made in the first second which seems too much. In general it seems simpler to just use the constant retry backoff similar to what KafkaProducer already does.

@shanthoosh Given the summary above, I would prefer that we go directly to implement the long term solution. But the short term solution as implemented in the current PR also seems OK. Due to the issue in 2) above, I don't think we should add retry logic in SamzaLiKafkaSystemProducer -- if we do so, caller may think the send() has succeeded even if the send() has failed.

@shanthoosh Is there an open source JIRA ticket to track progress ofSystemProducer API improvement? It probably makes sense to add Java comment with reference to that JIRA ticket and say that the hotfix added in this PR can be removed after that JIRA is completed.


CLN: Generalized PEP8 Enforcement

Per @jorisvandenbossche (https://github.com/pydata/pandas/pull/8286#issuecomment-56043336), we need to discuss a generalized way of enforcing PEP8 on the entire pandas code base.
Matplotlib has something similar here: https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_coding_standards.py, and here's the PR discussion: https://github.com/matplotlib/matplotlib/pull/1945
Some discussion is probably needed on the PEP8 rules we're alright with ignoring as well as whether or not we want to use 80 or 100 lines for max-line-length (http://legacy.python.org/dev/peps/pep-0008/#maximum-line-length).

Perhaps a tool such as yapf could be of use this area also?
https://github.com/google/yapf

closing in favor of #11928


Simplify tests

could you elaborate whats on your mind with this issue?

This is only for simplification of the unit tests. So while not having any influence on the functionality of the plugin, it will influence the speed of future development.

I understand. My question was more with regards what those kind of simplifications would be. looking at how you structured your jest tests I felt they already look pretty decent.

Oh I see. The main thing would be to get away from the intensive use of stubs. Of course they have their place and should not be abandoned at all but the style in the unit test so far has been to stub anything besides the class under test.
That lead to some problems and I wanted to replace the stubs in many places where they only stub classes that also belong to GridEngine.
There are different opinions about that out there. Here are some nice resources about that in case you are interested:
https://martinfowler.com/articles/mocksArentStubs.html
https://www.thoughtworks.com/insights/blog/mockists-are-dead-long-live-classicists

yep thats what I've assumed you were after. looking at e.g the GridEngine tests there is a bunch of stubbing + mocked modules going on. the lack of an IoC container for sure promotes the use of stubs vs manually crafted class fakes.
if its solely due to LOC used for mocking/stubbing you could perhaps go down jests automock route where every import/dep gets as the name suggests automatically mocked.
anyways, let me just say the level of coverage and test dedication you already have is super refreshing to see.

LoC was not the main thing I had in mind. I think that many tests in the case of this plugin would actually profit from the more integrative testing that would follow from replacing the stubs not only by fakes but by the real implementation. For example the tight interaction between GridTilemap and GridCharacter would profit from that. Using only stubs binds the test strongly to the concrete implementation. I just felt that every time I made small changes I had to touch so many tests... But yes, LoC is also an issue. Both the code and especially the test files are too long. So that should be improved as well. But one at a time 😅

anyways, let me just say the level of coverage and test dedication you already have is super refreshing to see.

Thanks :) I try to stick to TDD as much as I can.

having written the test for the steppedOn feature I kind of start to get the feeling what you're saying. Having to mock an observable with a Subject vs simply calling moveTo and letting the actual positionChangeFinished fire is a bit tedious.
An integration test feels hard to create whereas an E2E test might actually be easier. So my thoughts for my specific test would be:

create a demo game (like your docs samples)
start up a dev server per test via jest
start an E2E test with Puppeteer or Playwright
expose gridEngine via window global
do the test logic
assert result via gridEngine getters

wdyt?

I think having some central e2e tests can be quite useful. I thought about E2E tests for some important activities like those in the examples.
I see E2E tests as something to have additionally to the unit tests.
So what I was thinking when opening this issue was to simply reduce the mocking/stubbing to external components. So as an example: to make the unit test that you wrote more simple and robust against implementation changes we could not mock the GridCharacter (like it was done in basically all the unit tests in the code base) but use a real instance only mocking external stuff like Phaser sprites. Then we don't need to mock the positionChangeFinished() observable.
But this is not always easy. One thing a have thought about (but not thought through yet) is writing something that is comparable to a test harness for a character. You might know test harnesses for UI components (in Angular for example). These abstract the interaction with UI objects for the test. If we had such an abstraction for say GridCharacter, then it might be much easier to trigger and check certain behavior of it in surrounding tests.

I'm not 100% sure I follow your idea of the test harness (guess you meant Material Components Harness). If I understand properly it's merely a test adapter/shim which delegates UI interactions to it's host. So in your example the GridCharacterHarness would do exactly what? Use a GridEngine Mock as Host and delegate/rewrite direct interactions (Move, Stop, Animate ...) to the GridEngine? Perhaps I'm also struggling to see the point as typically a harness isn't written for your own library to use (well that happens over time) but primarily for consumers of your libraries components so that they can improve their own apps tests stability. So e.g. myself, if I'd ever to go and unit test my own game :rofl:
What I see as the fundamental part of the gridEngine's dependency is the update hook. So since you brought up Angular, as far as I see, offering a convenience wrapper like fakeAsync to create a scoped phaser-zone (handling sprite mocks etc.) and a tick helper to simulate game loop progression (time, delta) could create the necessary environment to run integration tests on a full GridEngine instance.
it('should move character to position', fakePhaser(() => {
  const grid = new GridEngine(mockedPhaserScene);
  let arrived = false;

  grid.moveTo(...)
  grid.steppedOn(...).subscribe( () => arrived = true)

  tick(10);

  expect(arrived).toBeTrue();
}));

But then again, I don't know your code-base nor Phaser good enough to really form a proper opinion. And it seems you've already put quite some thinking into this topic so I'll be looking forward to see what you'll come up with. Keep up the good work :+1:

No worries. I did not understand it 100% either 😄
I have to think about it and play around with some code to see whether it is really feasible or a dead end.
You are right, I meant Material Component Harnesses. They are actually based on the page object pattern. It means that you encapsulate the behavior of the UI in the harness (the page object) in order to abstract interactions from the implementation details. For example if you would like to select an item of a <select> element, you can use something like harness.selectItem(...). This abstracts from the concrete implementation of the <select> component.
The reason is that you often need to write boilerplate code like document.querySelector('select.some-class option'); and then trigger a click event or whatever. And then the CSS class names change or not a native <select> is used anymore and you have to change all your tests. I hope you see the point.
However, it is work to create and maintain such a harness and therefore you might not want to write one for each component in your application. But I think it has value even for components that are not exposed by your library. Say you have a component that is used in 20 other components in your app. You could either stub it away or you leave it and change 20 tests every time you change something in your component.
But back to topic: I could't say how such an abstraction for the GridCharacter might look like exactly, yet. It is just a rough idea. So for now it is not an option.
The phaser-zone sounds like an interesting idea... 🤔  It could make things easier for integrative testing.

Some tests are already simplified. There is no need anymore to track this in an issue, as this is an ongoing thing.


example: improve captions experience w/ CSS snippet

TEST URL: https://media-chrome-git-fork-luwes-improve-cc-example-mux.vercel.app/examples/vanilla/advanced.html

this makes the native captions look better and make them less intrusive on Chrome. More uniform w/ Safari.
moves the captions up when the control bar is visible for Chrome and Safari.

this seemed like a nice quick thing to do to improve the experience and covers +85% of browser usage!
this could also be a guide in the docs maybe.

Nice solve. 👍
There's a bit of an aesthetic disconnect between the controls fading and the captions movement. I think it'd ultimately look best if they were moving up and down together, but that'd be a bigger change. Second best would be to wait until the controls were fully faded out before moving the captions down. If we bake the translateY part in to media-container could we use the autohide setting to do that?

could also be a guide in the docs maybe

Yeah, I don't love this in the advanced example. i.e. I want to try to get rid of the needed CSS in the examples rather than add more to it.  I feel like this would be ok to add in the media-container CSS and bake in by default. At least the translateY part.


create a config feature in kube

We currently have a "private" __config feature in kube to track the config related dependencies.
I would like to expose this properly so that people can use kube with only the config feature to deal with kubeconfig related parsing.
This would require:

having checks for #[cfg(feature = "config") for the config module
having config feature depend on internal __non_core feature
having checks for #[cfg(feature = "config") or #[cfg(feature = "client") (or possibly feature = __non_core?) for overlapping deps
having the error enum be more feature flagged (currently entire module is gated on client feature)
a small test example that parser kubeconfig without features (needs some feature-re-export hackery in examples/Cargo.toml, plus a circleci test line)

You should not be able to get the client feature without the config feature (already ensured by having __config feature listed as a dependency of the client feature), but the other way around should work.

released in 0.56


GPU plugin README installation section mixes too many things

Current GPU plugin README installation section: https://github.com/intel/intel-device-plugins-for-kubernetes/tree/main/cmd/gpu_plugin
Is a bit of mess because it mixes many different things, in odd order, which makes installation look a more complicated than it actually is.
IMHO all of these 4 topics should be in separate (high-level) sections:

Installing GPU plugin (from pre-built images)

Including fractionalization support (with link to [1])

Verifying/testing GPU plugin installation
[1] Explanation of fractionalization support
Building the images from sources (@mythi)

This section could be actually be in separate DEVEL.md document, along with "Deploy by hand" instructions
E.g. under new "Features" section, or also in separate doc

Additional confusions is source building instructions currently being under weirdly named "Deploying as a DaemonSet" subsection that comes after "Getting the source code" subsection.  This is especially confusing as pre-built images also use DaemonSet, it's not something specific to source builds...
Top-3 issues:

[x] 1. Move local build instructions to DEVEL.md (@mythi)
[ ] 2. Update/move GPU plugin pre-requisities section (@eero-t)
[x] 3. Harmonize installation instructions (TBD)

@eero-t thanks, these are good suggestions. one thing we need to keep in mind is that all our cmd/*_plugin/READMEs try to follow the same structure so we'd need to come up with improvements that all the plugins could follow

One more issue with the GPU plugin installation section is that it mentions nothing about using operator for installing it (e.g. link to further documentation elsewhere in the project).

@eero-t thanks, these are good suggestions. one thing we need to keep in mind is that all our cmd/*_plugin/READMEs try to follow the same structure so we'd need to come up with improvements that all the plugins could follow

@mythi I see, all of them list building the image under "Deploying as DaemonSet" section.  IMHO there's nothing really connecting those two specifically, deployments that requiring building (modified sources) should go to documentation that is separate from the end user deployment documentation (or at least in separate top level section).  It's bad that there's so prominent documentation on how to install things so that they miss e.g. using NFD annotations.
Main divergence between different plugin READMEs seems to be in how per-requisites are handled.  E.g. QAT mentions them in first sub-section under "Installation", but GPU README mentions fractional resource reqs only under "Deploying as DaemonSet".

One more thing to add to README / requirements is a note about underlying host kernel needing to support given HW (+ that support being enable), and some note of how to install suitable driver packages to the WL containers (see #1109).
When given plugin feature, or NFD label is specific to given HW feature (SR-IOV, tiles...), it would be good to mention required HW series also in the README (and drop HW mentions from root level README, so that they're maintained in a single place).

@eero-t you added the prerequisites some time ago. Do you think this is still a valid issue? Or can we close this?

I'll need to update the docs a bit as upstream kernel has progressed further, but this ticket can be closed.


Separate code and styles

try this
https://cdn.discordapp.com/attachments/1277836331501883449/1280291965879193731/fix.zip?ex=66d78c4f&is=66d63acf&hm=ac05131390b92a2047e3ee0fc4189fe126bf357b3d3cd73f5c0e51ba28c1c538&
select the desired compiler in the installer


[2.1.x] Upgrade to Log4j2 2.19.0

<EMAIL_ADDRESS>

Closing. 2.1.x is deprecated in favor of 2.2.x (OSGi CMPN Log Service 1.5 is compatible with 1.4 used in 2.1.x).


compare.py has a bug! AttributeError: 'list' object has no attribute 'copy'

Python version: 2.7.12
CMD: python compare.py models/facenet/20170512-110547 fanwei-1.jpg fanwei-2.jpg
ERROR:
Traceback (most recent call last):
File "compare.py", line 129, in
main(parse_arguments(sys.argv[1:]))
File "compare.py", line 40, in main
images = load_and_align_data(args.image_files, args.image_size, args.margin, args.gpu_memory_fraction)
File "compare.py", line 91, in load_and_align_data
tmp_image_paths = image_paths.copy()
AttributeError: 'list' object has no attribute 'copy'
Then I modify the code of the line 91 of  compare.py:  tmp_image_paths = copy.deepcopy(image_paths), the error above disappear.
Is this project support python 2.7?

I have the same issue on python 2.7

Solved by adding import copy to compare.py. Then change "tmp_image_paths = image_paths.copy()" to
"tmp_image_paths=copy.copy(image_paths)"


Update libraries for Rust 1.61 + Cargo 2021 edition

Updated libraries to rust 1.61 and Cargo 2021. Updated to use main as default branch, and updated GitHub actions appropriately. Removed redundant/non-compiling tests.
Note that the tests weren't truly unit tests, they only tested the failure case and they depended on network configuration.

Hi Marvin,
I'm no longer involved with this fork/codebase/organisation - so this PR can probably be closed, I'm not going to progress on it further. The team is working on the fork here: https://github.com/WORK180/auth0-management/tree/main


Add support for fetcher.abort()

Remix sibling for https://github.com/remix-run/react-router/pull/11985

This may also fix #9438 #8461

This may also fix #9438 #8461

The vite dev signal fix is pulled to it's own PR in #9976


Add "exec --last" to README.md

There is no hint about this feature beside the CHANGELOG and the commit.

Thank you!
Hm, every command has parameters, plus the section where you added the line was generated by qc itself.
I guess it would make more sense to just add a new paragraph Example calls with a bash code block with the full command with parameter and a comment what it does...


Active and Power switch by "FAN" type ("Question/HelpNeeded")

After installing the plug in I see 2 switches in "Eve" and in the "Home+" App:

Active -> can be "on" and "off"
Power -> can be "on" and "off"

(the Active doesn't show in HomeKit App...  but we know that Eve and Home+ have access to more fields..
My Question: what does Active really controls in the plug-in? Can I "hide it"?
thanks
Luis

+1


Add a resample_to_uniform_in_velocity method

Here we implement a "resample_to_uniform_in_velocity" method, necessary for many convolution operations.
We may want to rethink the verbose name...
Also adds a useful .velocity_spacing attribute.
Closes #35.

BTW, a better design may be to make resample_to_uniform_in_velocity a hidden method, and stick only with .resample(), which can accept either a Spectrum1D-like object, or a speed resolution.  If the latter, it will call _resample_to_uniform_in_velocity.
Thoughts?


hishtory: 0.298 -> 0.302

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ddworken/hishtory/releases.
meta.description for hishtory is: Your shell history: synced, queryable, and in context
meta.homepage for hishtory is: https://github.com/ddworken/hishtory
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.302 with grep in /nix/store/ny99vjvw94163shxcq35szjza0kqfgzh-hishtory-0.302
found 0.302 in filename of file in /nix/store/ny99vjvw94163shxcq35szjza0kqfgzh-hishtory-0.302

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

hishtory

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ny99vjvw94163shxcq35szjza0kqfgzh-hishtory-0.302 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A hishtory https://github.com/r-ryantm/nixpkgs/archive/6bc2df8a130e9274b9375bc7380e67f28766c3c0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6bc2df8a130e9274b9375bc7380e67f28766c3c0#hishtory

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ny99vjvw94163shxcq35szjza0kqfgzh-hishtory-0.302
ls -la /nix/store/ny99vjvw94163shxcq35szjza0kqfgzh-hishtory-0.302/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.


[FLINK-3580] [table] Add current time point functions

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[x] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

This PR implements the SQL scalar functions CURRENT_DATE, CURRENT_TIME, CURRENT_TIMESTAMP LOCALTIME, LOCALTIMESTAMP for obtaining current time points.
@fhueske would be great if you can review this.

I thought about it again. Maybe I will rework it a little bit.

Merging this...


Fix metatheory/test2

The tests in plutus-metatheory:test2 are broken (and turned off in CI) because they're comparing a Named AST with a de Bruijn-indexed one.  This should be easy to fix.

In fact part of the problem seems to be that some tests are attempting to use the Haskell parser to read de Bruijn terms.

Done in #6414.


"td_json_client_create " how it's work?

when i build and try to run the example i just see this

so...
what is this?!
i know these json stuff that printed out here is in python code,
but i can't understand how it authenticated and big question is
"why it's just not to try connect to actual telegram user?"

No, it isn't Python code. It is incoming updates from the TDLib. td_json_client documentation can be found here: https://core.telegram.org/tdlib/docs/td__json__client_8h.html.

I read the docs in telegram website and even
struggled with c++ codes,
but i coudn't figured it out the authentication flow.
actually libraries like Telethon  is so easy to use and it's straight forward.

Alright, i read the documentation but there isn't a single clue or a simple hint to build a client with api_id and api_hash.
is that like developers have to make authentication and signing an logging in from scratch?

You can see example of authorization flow in the С++ or Java example:
https://github.com/tdlib/td/blob/master/example/java/org/drinkless/tdlib/example/Example.java.
Unlike Telethon login examples it provides handling for all possible errors and allows everything that is allowed by Core Telegram API. Nobody forbids to write a simple wrapper around raw TDLib methods, which will simplify logging, but these methods can't be at the core of the library.
api_id and api_hash are not specific to JSON interface, they should be specified in the setTdlibParameters request.

Thanks for explanation.
let me try more :-D

Authorization as everything else is update driven, so to properly authorize you need to handle UpdateAuthorizationState. For example, you have received authorizationStateWaitTdParameters which means that you should call setTdlibParameters to proceed.

Hi again,
I was trying to send a request with {'@type': 'setTdlibParameters '}
however i got this every time:
{u'message': u'Valid api_id must be provided. Can be obtained at https://my.telegram.org', u'code': 400, u'@extra': None, u'@type': u'error'}.
I use something like this:
{'use_test_dc_': False,
'database_directory_': '',
'files_directory_': '',
'use_file_database_': False,
'use_chat_info_database_': False,
'use_message_database_': False,
'use_secret_chats_': False,
'api_id_': 18**, #myAppIdFromTelegram
'api_hash_': 'myAppHashFromTelegram',
'system_language_code_': 'en',
'device_model_': 'DESKTOP',
'system_version_': '',
'application_version_': '1.0',
'enable_storage_optimizer_': False,
'ignore_file_names_': False}
I was struggling with that request until now, i don't know where i did it worng.


ng-click on x-axis label formatter is  not working

Hi am trying to call a function on label click on a bar chart using ng-click when i use onclick='window.scrollTo(0, document.body.scrollHeight);' it's working but if i use ng-click='xLabelClick1()' it's not working can any one help me please.. below is sample of my chart config
$scope.xLabelCick1 = function () {
alert("OK");
$rootScope.$broadcast('xLabelClick');
};
$scope.chartConfig = {
options: {
chart: {
type: 'bar'
},
legend: {
enabled: legend
}
},
title: {
text: null
},
xAxis: {
categories: [jan.feb,march,apr],
labels: {
formatter: function () {
return "" + this.value + "";
},
useHTML: true
}
},
$timeout(function () {
var element = $(".highcharts-container");
$compile(element)($scope);
});

I've done something similar by defining a legendItemClick in the series.  Like:
series:
[
{
events: {
legendItemClick: xLabelClick1
}

I would use the approach @sadlerw  suggested


how much is your token gen?

gimme ur dc

Nobody has a working token generator for one reason: every publicly available captcha solver is flagged for hCaptcha Enterprise, which Discord uses. You need to make your own solver, sadly.


Download link not working

The onedrive keeps interrupting halfway through the download, and the ZJU's netdisk (alternate link) doesn't work either!

Hello, the onedrive link is indeed very unstable. I made a lot of efforts to download the dataset, so I suggest using the alternative link I provided.
I've just checked the alternate link in a public network environment (not in our group's local network) and I can successfully download the dataset.  You can try to copy the download link to Thunder or  IDM download manager.

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

非常感谢及时的回复，网络已经恢复！


ImportError (numpy.core.multiarray failed to import)

I updated cvxpy to 1.0.1 on Windows 10 using Anaconda. When I run nosetests cvxpy I get an error: RuntimeError: module compiled against API version 0xc but this version of numpy is 0xa
E
ERROR: Failure: ImportError (numpy.core.multiarray failed to import)
Traceback (most recent call last):
File "C:\Users\Peter\Anaconda\lib\site-packages\nose\loader.py", line 407, in loadTestsFromName
module = resolve_name(addr.module)
File "C:\Users\Peter\Anaconda\lib\site-packages\nose\util.py", line 312, in resolve_name
module = import('.'.join(parts_copy))
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy_init_.py", line 21, in
from cvxpy.atoms import *
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy\atoms_init_.py", line 20, in
from cvxpy.atoms.geo_mean import geo_mean
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy\atoms\geo_mean.py", line 23, in
from cvxpy.utilities.power_tools import (fracify, decompose, approx_error, lower_bound,
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy\utilities\power_tools.py", line 21, in
from cvxpy.atoms.affine.reshape import reshape
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy\atoms\affine\reshape.py", line 20, in
from cvxpy.atoms.affine.affine_atom import AffAtom
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy\atoms\affine\affine_atom.py", line 25, in
from cvxpy.cvxcore.python import canonInterface
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy\cvxcore\python\canonInterface.py", line 32, in
import cvxpy.cvxcore.python.cvxcore as cvxcore
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy\cvxcore\python\cvxcore.py", line 28, in
_cvxcore = swig_import_helper()
File "C:\Users\Peter\Anaconda\lib\site-packages\cvxpy\cvxcore\python\cvxcore.py", line 20, in swig_import_helper
import _cvxcore
ImportError: numpy.core.multiarray failed to import

Ran 1 test in 0.000s
FAILED (errors=1)
Any ideas for how I can get cvxpy working again? Import CVXcanon doesn't give an error and I have numpy 1.12.1 installed.

Seems to work now that I upgraded numpy to 1.14.3. Conda install wouldn't upgrade numpy because scs depends on numpy 1.12, so I had to force the upgrade using pip install.

Ok that's odd. Are you saying that it is impossible with conda on Windows to install SCS and any version of NumPy higher than 1.12?

Yes, I had to force it with pip install, but then SCS didn't work. So I ended up doing a handful of uninstall/reinstalls before getting it to work with a 32-bit version of Conda and doing pip install cvxpy.

@rileyjmurray this might be the key to getting conda working on Windows. It could just be a mistake in the SCS package dependencies (something like NumPy == 1.12).

It works fine with pip install, but not with conda install.

This should be fixed, as much as possible.


Implement an exception to wrap storage::Status.

This will be used by StatusOr<T>::value() when the value is not set.
Part of the work for #1686.

This change is

PTAL.


How to represent generic relationship?

How to represent generic relationship as in sqlalchemy_utils?
import sqlalchemy as sa
from pydantic import BaseModel
from sqlalchemy.ext.declarative import declarative_base
from sqlalchemy_utils import generic_relationship

Base = declarative_base()

class User(Base):
    __tablename__ = 'user'
    id = sa.Column(sa.Integer, primary_key=True)
    name = sa.Column(sa.String)
    gender = sa.column(sa.Integer)

class Customer(Base):
    __tablename__ = 'customer'
    id = sa.Column(sa.Integer, primary_key=True)
    name = sa.Column(sa.String)
    country = sa.Column(sa.String)

class Event(Base):
    __tablename__ = 'event'
    id = sa.Column(sa.Integer, primary_key=True)

    # This is used to discriminate between the linked tables.
    object_type = sa.Column(sa.Unicode(255))

    # This is used to point to the primary key of the linked row.
    object_id = sa.Column(sa.Integer)

    object = generic_relationship(object_type, object_id)

class UserSchema(BaseModel):
    id: int

class CustomerSchema(BaseModel):
    id: int

class EventSchema(BaseModel):
    id: int
    object_type: str
    object_id: id
    object: ?

I don't know what generic_relationship returns.
If it can be anything, use Any. If it's a recursive representation of other pydantic models, either use them, or see #659.


Warning: "substract" is a misspelling of "subtract" (misspell)

Describe Request
Warning: "substract" is a misspelling of "subtract" (misspell)
Fixed #93
Change Type
Bug fix.

Codecov Report

Merging #94 (7b8fd39) into main (76f548a) will not change coverage.
The diff coverage is 83.01%.

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   62.49%   62.49%
=======================================
  Files          91       91
  Lines        1501     1501
  Branches      180      180
=======================================
  Hits          938      938
  Misses        550      550
  Partials       13       13

Impacted Files
Coverage Δ

src/indicator/volatility/accelerationBands.ts
30.00% <0.00%> (ø)

src/indicator/volatility/projectionOscillator.ts
35.00% <ø> (ø)

src/indicator/volatility/ulcerIndex.ts
100.00% <ø> (ø)

src/indicator/volume/volumePriceTrend.ts
100.00% <ø> (ø)

src/indicator/momentum/awesomeOscillator.ts
37.50% <50.00%> (ø)

src/indicator/trend/chandeForecastOscillator.ts
61.53% <50.00%> (ø)

src/indicator/trend/dema.ts
42.85% <50.00%> (ø)

src/indicator/trend/macd.ts
37.50% <50.00%> (ø)

src/indicator/trend/qstick.ts
60.00% <50.00%> (ø)

src/indicator/volatility/bollingerBands.ts
50.00% <50.00%> (ø)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f548a...7b8fd39. Read the comment docs.


Add TypeScript client to README

Hi,
I've created a TypeScript client for this API. Would be great if it could be included in the README. The client is a promise-based client, covered 100% with unit tests, runs a Travis build which runs the tests, audit and linting as well as runs a Sonar code analysis.
https://travis-ci.org/ToeFungi/exchange-rates-as-promised/branches
https://sonarcloud.io/dashboard?id=exchange-rates-as-promised
https://www.npmjs.com/package/exchange-rates-as-promised

Bump
@mandarvaze  @jmrossy @madisvain @acs-ferreira

LGTM

LGTM

Do you have merge permissions?

We can't merge till @madisvain and @julian-zehetmayr approve this PR - since they are listed as reviewers.

@madisvain @julian-zehetmayr ?

Bump @madisvain @julian-zehetmayr


[List] support vertical align

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
[List] support vertical align
Examples 🌈
		<ListItem
			disablePadding
			sx={{}}
		>
			<ListItemButton sx={{
				px: 1,
				alignItems: 'flex-start',
			}}>
				<ListItemIcon
					sx={{
						pt: 0.5,
					}}
				>
					無紀錄
				</ListItemIcon>
				<ListItemText>
					{dayOff.list.map(i => (<>
						<Typography>{dayOff.startOfRange.date(i).format(REVENUE_LABEL_DATE_FORMAT2)}</Typography>
					</>))}
				</ListItemText>
			</ListItemButton>
		</ListItem>

Motivation 🔦
.

@bluelovers I’m afraid I don’t understand exactly the layout you are trying to achieve, but you should be able to vertically/horizontally align things using sx and flexbox properties like in your snippet – could you provide a bit more detail?

i want it can be prop option , without adjust padding by self

@bluelovers The ListItemButton component already has a direct alignItems prop, but I think padding is too general to be part of the interface.
You could make a custom component wrapping the material UI ListItemIcon that applies the padding adjustments and/or adds a custom padding prop and use that throughout your project – would that work for you?

@bluelovers is it about the disablePadding prop? You can still use it in the wrapping ListItem component, for e.g. https://codesandbox.io/s/lucid-engelbart-5chxih?file=/demo.tsx


easy::to_string_pretty doesn't produce pretty results

I propose that Document, Table,, etc have fmt functions that take a format configuration.  to_string_pretty and other serializer options are implemented in terms of this.
This function will be the public facing one.  An internal one will be used when recursing so we can pass in the relevant information from the caller, in addition to the format config.

We should port the following tests when we do this

https://github.com/alexcrichton/toml-rs/blob/master/test-suite/tests/formatting.rs
https://github.com/alexcrichton/toml-rs/blob/master/test-suite/tests/pretty.rs

Hello, I've just touched this. Let me state my understanding of the question and see if my understanding is correct.
It seems that you don't think the printout of the current structure, such as Table and document, is perfect. Therefore, the function easy::to_string_pretty needs to be optimized, right?
If my understanding is correct, what is the perfect output format you want?
Please give me a detailed description. Thank you.

I'd say we start with mimicing toml-rs, ie able to pass their tests

https://github.com/alexcrichton/toml-rs/blob/master/test-suite/tests/formatting.rs
https://github.com/alexcrichton/toml-rs/blob/master/test-suite/tests/pretty.rs

We can look to their serde implementation for a starting point for the algorithm: https://github.com/alexcrichton/toml-rs/blob/master/src/ser.rs
Without looking to closely

We should always create valid toml
We should prefer array of tables over inline arrays
If a table has too many elements, we should prefer standard tables over inline tables.

Example failure from cargo's test suite
---- features_namespaced::publish stdout ----
running `/home/epage/src/personal/cargo/target/debug/cargo publish --token sekrit -Z namespaced-features`
thread 'features_namespaced::publish' panicked at '

error:  did not match:
1   1     # THIS FILE IS AUTOMATICALLY GENERATED BY CARGO
2   2     #
3   3     # When uploading crates to the registry Cargo will automatically
4   4     # "normalize" Cargo.toml files for maximal compatibility
5   5     # with all versions of Cargo and also rewrite `path` dependencies
6   6     # to registry (e.g., crates.io) dependencies.
7   7     #
8   8     # If you are reading this file be aware that the original Cargo.toml
9   9     # will likely look very different (and much more reasonable).
10  10    # See Cargo.toml.orig for the original contents.
11  11
12       -[package]
13       -name = "foo"
14       -version = "0.1.0"
15       -description = "foo"
16       -homepage = "https://example.com/"
17       -license = "MIT"
18       -[dependencies.bar]
19       -version = "1.0"
20       -optional = true
21       -
22       -[features]
23       -feat1 = []
24       -feat2 = ["dep:bar"]
25       -feat3 = ["feat2"]
    12   +package = { name = "foo", version = "0.1.0", description = "foo", homepage = "https://example.com/", license = "MIT"}
    13   +dependencies = { bar = { version = "1.0", optional = true}}
    14   +features = { feat1 = [], feat2 = ["dep:bar"], feat3 = ["feat2"]}

Thanks! I ran across this while trying to see if I can switch my code to using toml_edit (which looks fantastic btw!)
I'm wondering if at some point, finer-grained control might be desirable -- perhaps some sort of trait that can control whether a particular table is serialized as inline or standard. e.g. for a Cargo.toml, I'd like to see dependencies.bar be an inline table but features be a standard table.

I'm wondering if at some point, finer-grained control might be desirable -- perhaps some sort of trait that can control whether a particular table is serialized as inline or standard. e.g. for a Cargo.toml, I'd like to see dependencies.bar be an inline table but features be a standard table.

That makes sense.  A similar thought i had was a way to control sort order (e.g. [package], [features], [dependencies], [target]).
The main thing is balancing the complexity, whether thats in a user finding what they want and understanding how to use it, implementing the users code on top of the API, or the implementation within the library.   At a certain point of proliferation of customization, it seems like it'd be better for someone to walk the data structure and format it manually. I guess another aspect of all of this is finding the answer to what can we do to support people writing that custom formatting.
btw guppy looks interesting! In particular, I find the idea of determinator interesting from two angles

For build/test avoidance in open source.  For example, clap's CI takes over an hour (they did switch to a two-tier CI using bors so that cost is only paid on merge and not each PR update, instead its only a half hour or so which is still bad). I would love to also have coverage-driven test case avoidance but thats its own separate thing.
As a maintainer of one of the release automation tools (cargo-release).  We've all been implementing our own bespoke implementations of release-avoidance.  These have their own needs.  For a release, all you care about is included/excluded files.  You also only need to release all packages with a [[bin]] if the lock file changed.  I wish there was a way to know if a dependency showed up in a public API.

That makes sense. A similar thought i had was a way to control sort order (e.g. [package], [features], [dependencies], [target]).

The main thing is balancing the complexity, whether thats in a user finding what they want and understanding how to use it, implementing the users code on top of the API, or the implementation within the library. At a certain point of proliferation of customization, it seems like it'd be better for someone to walk the data structure and format it manually. I guess another aspect of all of this is finding the answer to what can we do to support people writing that custom formatting.

Oh that's a super interesting idea. I wonder what an API based on syn::visit_mut would feel like. Going to try playing with it a bit over the next few days.

btw guppy looks interesting! In particular, I find the idea of determinator interesting from two angles

Thank you! Yeah, the determinator is really cool and has proven to work quite well in a large workspace. I think both of the use cases you described make a lot of sense.
I haven't seen much demand for it in open source yet but now that you've asked for it, I now have a reason to clean it up and put it out there :) Happy to chat about this in more detail on Discord or some other medium.


PreceduralSkyMaterial uses all DirectionalLight3D in the scene as suns

Godot version
4.0.dev (483df71120)
System information
Linux
Issue description
In my scenes I use a WorldEnvironment node with ProceduralSkyMaterial to generate the sky and I have one DirectionalLight3D for the sun, as a child of the WorldEnvironment. But I also have another DirectionalLight3D, inside a different Viewport, somewhere deep in the hierarchy.
The problem is that this second light seems to also used by ProceduralSkyMaterial to generate a second sun, which also affect the lighting of the scene.
With the second light enabled:

With the second light disabled:

To me it would make sense to only consider the DirectionalLight3D ligts that are below the WorldEnvironment node and not all the ones in the scene. If you think that's the way to go, I'm willing to try to make a PR for this.
Steps to reproduce
Add a WorldEnvironment to a scene with a ProceduralSkyMaterial sky and two DirectionalLight3D.
Minimal reproduction project
DoubleSun.zip

I propose replacing use_in_sky_only with a usage enum with options [Sky and lighting, Sky only, Lighting only].

I started working on this in a branch: https://github.com/Calinou/godot/tree/directional-light-add-sky-mode


CNV-37480: "auto updates for RHEL VirtualMachines" is enabled by default but does not work

📝 Description
On a fresh cluster, the switch to allow RHEL auto updates was on by default, even if the key and id are missing, that caused the mechanism to not get the default unless you toggle it off and back on.
Allowing to set the switch on just if both id and key values are not empty after applying them is solving the issue
🎥 Demo
Before:
https://github.com/kubevirt-ui/kubevirt-plugin/assets/67270715/47c00d8a-201a-4959-bc8d-f92bd2d76fc7
After:
https://github.com/kubevirt-ui/kubevirt-plugin/assets/67270715/380be26d-48ae-4b9e-9b24-cfbf6f875bfb

/lgtm

/cherry-pick release-4.15


Unnested callbacks and assignment

<- z =
x + y

is invalid LS code. There's any way to use unnested callbacks with assignments?
May like something like that?:
module.exports = (x, y) <-
x + y

(x, y) <- (!-> module.exports = it)
x + y

Any other solutions?

I don't think callbacks should be used in this case (assignment), as the code becomes confusing.


tryLoadImage callback is invoked eagerly

When evaluated, tryLoadImage will invoke its callback with Nothing immediately, then attempt to load the image, then invoke its callback again once the correct value has been determined.

Thanks for the bug report. Are you able to see if the error callback is being run?

Of course, we should only call the callback once in any case.

Hello! Sorry. My Github notifications got out of hand last week and I didn't see this.
In the case where the image load succeeds, the callback is invoked once eagerly with Nothing (not in response to an "error" event) and once again with Just image.
In the case where the load errors, the callback is invoked once eagerly with Nothing and never invoked again.
That seemed weird at first, but it's not really.
      return $foreign.tryLoadImageImpl(path)(k(Data_Maybe.Nothing.value))(function ($28) {
          return k(Data_Maybe.Just.create($28));
      });

e is the result of invoking k, when I expected it to be the result of partially applying k.
But also, like, morally this is sort of... correct? It's just eagerly evaluating the Eff value to use in the error case, even though it might not need it. After all, determination of the effect is pure, so "predictive evaluation" isn't... wrong here. But I expected a degree of laziness that was not present.
So it's only really a performance bug, and then only barely. Just surprising to me. I only noticed this because I was unsafely insisting the value was there so I didn't have to branch -- which it was, sort of. I'm still getting used to strict evaluation.
In my app I switched over to this instead:
foreign import loadImage :: forall e. String -> Aff (| e) CanvasImageSource

exports.loadImage = function(src) {
    return function (onSuccess, onError) {
        var img = new Image();
        img.src = src;
        img.addEventListener("load", function() {
            onSuccess(img);
        }, false);
        img.addEventListener("error", onError, false);
    }
}

But adding a dependency to Aff feels weird for this project, so I don't know if there's much to do.

The function should not be called eagerly as you describe. It's a bug if that's happening :)

Also, adding an aff dependency should not be necessary.

Without having run it yet, the code does look correct. How are you calling tryLoadImageImpl?

It's not that the Eff function is being called eagerly -- it's that this line:
tryLoadImage path k = tryLoadImageImpl path (k Nothing) (k <<< Just)

is calling k Nothing eagerly. This is not a problem if you are using Eff properly. I ran into this issue because I had this (poorly written) part to emulate the old withImage:
withImage path f = tryLoadImage path $ \mimg -> case mimg of
  Just img -> f img
  Nothing  -> unsafeThrow $ "panic! could not load image from path: " <> path

The fix was of course replacing the unsafeThrow with throwException and adding the EXCEPTION effect where needed. So this isn't a bug; the evaluation is just unexpected if you are cheating with error handling like I was :)

Closing as @mtolly's analysis seems to be the most likely explanation as to what's going on here. Please reopen if I'm missing something.


Intel BTS mmap error

Hi,
while running the fuzzer with BTS feedback enabled I get the following error:
arch_perfCreate():213 mmap(mmapAuxBuf) failed, try increasing the kernel.perf_event_mlock_kb sysctl (up to even 300000000): Cannot allocate memory

I obviously tried increasing the perf_event_mlock_kb to the suggested value. The error happens quite sparsely (I've been able to run the fuzzer even for 24 hours but the error can pop up after 1, 2, 5 or 8 hours in) and I cannot reproduce it at will.
Another detail is that if I run the fuzzer as a normal user after a previous run failed due to mmap error, I get another mmap error but this time on mmapBuf: Operation not permitted. If I retry as root, it runs fine until the next mmapAuxBuf: Cannot allocate memory error. To make it run as normal user again I have to reboot my machine.
OS details:
$ uname -a
Linux acidghost-MS-7816 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Thanks for your help.

Hi,
In short, Intel BTS/PT implementation was quite unstable in kernels around version ~4.4 (early implementation of the AUXTRACE feature). There were some problems with mutexes being left locked in the kernel.
I'm using personally 4.13 to test it, but IIRC it works kind-a stable since ~4.9

Thanks for the info. I'm trying with 4.13 as suggested and I'll report here.
One more thing: would you suggest running as root or not? Does it affect the kernel implementation of BTS?

It does, but also in its ability to track kernel addresses. With root you can trace kernel, which might be helpful for more advanced setups.
In any case, you can control access to kernel-level addresses with
$ sysctl kernel.perf_event_paranoid
kernel.perf_event_paranoid = 1
If it's set to 3, then you can get EPERM errors when accessing BTS/PT

Please re-open if you bump into new problems with BTS


metadata not populated for both fat0 and fat1 transactions

$ ./fat-cli --version
fat-cli:  v0.4.2.r38.ge5c9222
fatd:     v0.4.2.r38.ge5c9222
fatd API: 1

Adding -m '"coinbase TX"' to a transact command doesn't result in the transaction having this meta data attached. I can tell the value of the metadata flag is parsed because I can get an "invalid JSON error" if the value is wrong. But if correct, it seems to simply never make it to the actual transaction.

Looking from far away, I'd say the metadata variable is never used to populate the metadata of the transaction structure: https://github.com/Factom-Asset-Tokens/fatd/blob/develop/cli/cmd/transact.go#L34

Ah. Thank you. I think you are right in your diagnosis of the bug. Will fix very soon.


feat: add Arc Dark theme

Pull Request Template
Discord username (optional)
進藤ヒカル#6894
Name of theme
Arc Dark
How Has This Been Tested?
I ran python3 ./scripts/gen_theme_previews.py standard to generate the preview.
Notes
Colours pulled from JetBrains Material UI plugin theme and this Gnome Terminal theme (https://gist.github.com/Kanon/99840108309ee3d2b995a0e5714f73ad)

Thanks for opening this @hikaru-shindo


additional helpers

Implement the following helpers:

[x] http
[ ] better http with more options and features for fetch api
[ ] route not sure if it's needed, but always useful in AngularJs
[ ] defer deferred promise helper

Regarding better http, will also need to add support for buffers as request body and response.

Added safeGet() and safeSet() to features list, until optionals are added to Javascript I guess this is the best alternative.

closing this for now due to being bloaty


Async fixes

Makes async parts a little safer, proper deinit on observers and weak capture of self in the load method of the AVPlayerWrapper.
Was sometimes receiving INVOPs in the tests because of deallocated objects, but it seems to be more solid now.

Codecov Report

Merging #67 into master will decrease coverage by 0.88%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   78.13%   77.24%   -0.89%
==========================================
  Files          17       17
  Lines         974      980       +6
==========================================
- Hits          761      757       -4
- Misses        213      223      +10

Impacted Files
Coverage Δ

...tAudio/Classes/Observer/AVPlayerTimeObserver.swift
94.44% <100%> (+0.5%)
:arrow_up:

SwiftAudio/Classes/Observer/AVPlayerObserver.swift
88.88% <100%> (-0.48%)
:arrow_down:

...tAudio/Classes/Observer/AVPlayerItemObserver.swift
93.33% <100%> (+3.01%)
:arrow_up:

...es/Observer/AVPlayerItemNotificationObserver.swift
86.66% <100%> (+6.66%)
:arrow_up:

...udio/Classes/AVPlayerWrapper/AVPlayerWrapper.swift
79.88% <100%> (-0.45%)
:arrow_down:

SwiftAudio/Classes/AudioItem.swift
54.28% <0%> (-14.29%)
:arrow_down:

SwiftAudio/Classes/AudioPlayer.swift
76.69% <0%> (-3.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965f7db...4241b48. Read the comment docs.


PEP8

Code and example should respect PEP8
flake8 might help

Fixed via https://github.com/python-constraint/python-constraint/commit/ffa1a8836485e6db59e13019b14a88c197829d4a


Inlined function causes "FS0078: Unable to find the file" error in F# Interactive with .NET Core library

Hi, I'm working on porting my DiffSharp (http://diffsharp.github.io/DiffSharp/) library to .NET Core. I can compile it successfully with .NET Core CLI, targeting .netstandard1.6 and net45.
However, when I try to work with the compiled .netstandard1.6 dll in F# interactive, I encounter a bug.
I isolated the problem to the following minimal example that reproduces it:
Repro steps
My project.json file:
{
  "version": "1.0.0-*",
  "buildOptions": {
    "compilerName": "fsc",
    "compile": {
      "includeFiles": [
        "Lib.fs"
      ]
    }
  },
  "tools": {
    "dotnet-compile-fsc":"1.0.0-preview2-*"
  },
  "frameworks": {
    "netstandard1.6": {
      "dependencies": {
        "NETStandard.Library":"1.6.0",
        "Microsoft.FSharp.Core.netcore": "1.0.0-alpha-160629"
      }
    }
  }
}

The Lib.fs file:
module Test

let inline test (a:float[]) =
    Array.map sin a

Compile with .NET Core:
dotnet build
Project lib (.NETStandard,Version=v1.6) will be compiled because inputs were modified
Compiling lib for .NETStandard,Version=v1.6

Compilation succeeded.
    0 Warning(s)
    0 Error(s)

Time elapsed 00:00:03.7319805

Failure
Load resulting dll in F# Interactive:
F# Interactive for F# 4.0 (Open Source Edition)
Freely distributed under the Apache 2.0 Open Source License

For help type #help;;

> #r "lib.dll";;

  #r "lib.dll";;
  ^^^^^^^^^^^^

/home/gunes/bugs/lib/bin/Debug/netstandard1.6/stdin(1,1): error FS0078: Unable to find the file 'System.Runtime.dll' in any of
 /usr/lib/mono/4.5
 /home/gunes/bugs/lib/bin/Debug/netstandard1.6
 /usr/lib/cli/fsharp/
>

Non-failure
When you don't "inline" the function, there is no problem.
Modified Lib.fs:

module Test

let test (a:float[]) =
    Array.map sin a

Successfully load in F# Interactive (after successfully compiling again):

F# Interactive for F# 4.0 (Open Source Edition)
Freely distributed under the Apache 2.0 Open Source License

For help type #help;;

> #r "lib.dll";;

--> Referenced '/home/gunes/bugs/lib/bin/Debug/netstandard1.6/lib.dll' (file may be locked by F# Interactive process)

>

Related information

Operating system: Ubuntu 16.04
dotnet --version:

1.0.0-preview2-003121

mono --version:

Mono JIT compiler version 4.2.1 (Debian <IP_ADDRESS>+dfsg2-7ubuntu4)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
	TLS:           __thread
	SIGSEGV:       altstack
	Notifications: epoll
	Architecture:  amd64
	Disabled:      none
	Misc:          softdebug
	LLVM:          supported, not enabled.
	GC:            sgen

There's a tentative fix for this in https://github.com/fsharp/fsharp/pull/585

@gbaydin I believe this is fixed in tag <IP_ADDRESS>.  If you could try the ZIP of tools from https://ci.appveyor.com/api/buildjobs/j4aar9dehl76umw9/artifacts/lib/release.zip that would be great

@dsyme, I tried the tools inside the zip file.
The problem is indeed fixed.
:)

Thank you for confirming this, that is very helpful


Add term.forms()

#180

hey, wanna put this on the other classes too? LIke, term.forms() does:
{text:this.text, normal:this.normal}

and then value.forms() maybe returns something like,
{text:this.text, normal:this.normal, ordinal:this.to_ordinal() ....}

etc? I dunno, up to you if you like it.

i tried overloading .root() for the first time, and it's kinda cool. That way people don't need to type-check each term before firing their method. Try it out, if you want. I'm happy to just merge this, if you're not hot on the idea

I don't quite follow: you can apply .forms() for any term, and depending on the tag it will either conjugate (verbs, adjectives) or return singular/plural for nouns – no type-checking from users. I thought of it exclusively within issue #180. But you would like this operator to basically return everything there is for a term/value?

yeah, i was thinking we could have .forms() as a method for every class of Term, like:

Noun.forms() - returns singular/plural forms
Verb.forms() - conjugate, etc
Person.forms() - pronoun, firstname, lastname
to sorta universalize it, in the api - like 'blow-out all derivations' or whatever.  Like, t.show_me_everything()

or how about term.all_forms() ?

I created one overloaded method in Term which is inherited by all classes like Noun, Verb, etc (who inherit Term) – I thought it would be easier to manage. Noun.forms() and Verb.forms() hence works exactly as you described above - the "if" statement makes sure the right method (conjugate(), pluralize(), etc.) is called.

The thing is, for Verb and Adjective forms() basically duplicates conjugate(). But I can definitely implement this method separately in every class with appropriate fields we want to display – although again, my intention was to fix an issue, not to create something new.

ah, yeah i see. I can merge this now if you want.
I may rename it and kick it a bit further, to Person, Date ... and maybe Sentence??
unless you wanted to give it a go

Go ahead and make appropriate changes – and merge when you feel it's ready!


Update to newest modulesync_configs [3610af2]

This requires a successful merge of https://github.com/puppetlabs/puppetlabs-xinetd/pull/72 before it can pass travis

+1 I'll speak to you tomorrow about the location_for


Sorry to bother you again

Sorry to bother you again, my pretext is always around 77%, the ntu60_xview_joint.pt in the released_model used, the data is action_dataset/ntu60_frame50/xview/train_position.npy,the environment is installed according to the required content， please where do I need to change to improve

I see that the efficiency in your log.txt can reach 79%

This is correct  because the pre-trained model reaches 79% of the optimum at 300 epoch and then drops to 77%. The weights we put out are for 350 epoch, at which point the knn accuracy is 77%. But this sometimes improves in downstream linear evaluation, and we think this may be caused by mitigating overfitting.

Your pre-training results are:
300-10: cur-79.34%, best-79.43%
250-40: cur-76.48%, best-77.04%
300-20: cur-78.88%, best-79.07%
300-10: cur-79.34%, best-79.43%
300-40: cur-78.19%, best-78.36%
300-20: cur-78.88%, best-79.07%
300-40: cur-78.19%, best-78.36%
I train for:
250-10: cur-76.66%, best-76.66%
250-20: cur-76.43%, best-76.43%
250-40: cur-75.44%, best-75.44%
300-10: cur-77.86%, best-77.98%
300-20: cur-77.73%, best-77.73%
300-40: cur-76.88%, best-77.02%
Do I have any hope of running your results?

Are you using linear_evaluation.py in skeleton_recognition? The error could be because our pre-trained st-gcn outputs multiple features, but the downstream recognition only needs global features, so we need to use the  st-gcn in skeleton_recognition.

Regarding the KNN performance degradation, I'll give the AimCLR weights I used for initialisation for reference.

Hello, I copied the linear_eval in the skeleton folder to the config of the whole folder, and the other required py files were also copied out, do you have to use linear_evaluation.py in skeleton

The code of AIMCL running in Skeleton, ST-GCN is also the original GCN, so how does the evaluation of ACTCL run?

Hello, I'm in linear_eval.._joint.yaml file: Set
model: net.actclr.actclr
model_args: base_encoder: net.st_gcn. model
where the st_gcn is the original gcn, which runs your results epoch100_acc87.14.pt in the work_dir
Is this the result of the NTU 60 xview (%) of ActCLR-joint?

yes


Feature/bidirectionality

Changes proposed in this Pull Request:

Update components to support bidirectionality.
Add rtl-addon to storybook demo
Add options to toggle theme and directionality to showcase demo

Each component that needs some conditional styles based on the directionality of the app will have a RTL scss snippet at the top of their sass file that contains support for RTL languages.

Screenshots:

I also did not check multi-level drawer indentations, are they good?

To keep the scope of this PR down, I've moved the Drawer border style and InfoListItem color issue to a separate feature request found here:
https://github.com/pxblue/angular-component-library/issues/120

I also did not check multi-level drawer indentations, are they good?

They were not good! But now they are.

Partial dividers still not working in the Showcase:

Partial dividers still not working in the Showcase:

Looks like the subtitles also need to be updated to the newer syntax, but that might be outside the scope here (could add it ot that other enhancement you created)

Geez, I tested out the fix in storybook, but the issue is coming from a style precedence issue.  Placing a mat-divider in a mat-card adds some additional styles onto it.  I've fixed the issue by increasing the specificity of our mat-divider rules so that our styles apply.

DrawerLayout bidi story is working in a separate branch that uses our own storybook-rtl addon.  It won't be fixed as part of this PR.

@huayunh  Can you re-review this PR?

@emclaug2 I temporarily lost my ability to spin it locally (that I lose my access to the Eaton MBP), unless you deploy it over Firebase.

This is latest storybook, with the new rtl addon: http://pxblue-angular-library.web.app/

This is the latest showcase: https://pxblue-temp.web.app/

Showcase looks good to me!
Storybook:

Typo in the drawer, Calender -> Calendar

Drawer menu icons are not flipped

Interestingly, drawer with full config story has half of the icons flipped

Technically, the home page should not be influenced by i18n flipping... not a big trouble.
You will get this if you flip the direction in another story then go back to the home page

The following icons should not be flipped: icons with text (e.g., English letters) and with a particular symbol that crooks a widely recognized symbol when flipped (e.g., earth globe)

ScoreCard with actions not flipped

ScoreCard with score badge, card body list is not flipped and misaligned

these two points also apply to scorecards with full config story

The drawer icons look fine to me, which ones are wrong?

Something must have slipped in my mind... Ignore the comments about drawers :P

Something must have slipped in my mind... Ignore the comments about drawers :P

Everything else makes sense and is being worked on 👍

#6 is something that will be easier to fix when our custom storybook RTL addon is integrated.
Turns out we cannot do attribute-based css inside of our storybook custom styles per story.
We will require an inline fix & an easily accessible getDirection function to adjust these scorecard margins.
I think we should also revisit #3 after our own RTL addon is integrated, same reason as above.

Typo in the Drawer menu items is fixed, scorecard action items are inverted now, and the B hero icon won't be inverted anymore.  Changes are used out here: https://pxblue-angular-library.web.app


SATELLITES: Create the tools for querying SatelliteCreate events

Closing this issue as everything is going to be implemented with this observe task: https://github.com/Synthetixio/synthetix-v3/issues/713


Cleanup includes and defines

Move ibex_tracer_defines.sv and ibex_defines.sv out of the 'include'
directory, since these files are not actually included.
Remove ibex_config.sv, it's mostly unused code. The remaining defines,
SYNTHESIS, ASIC_SYNTHESIS, TRACE_EXECUTION, and CHECK_MISALIGNED should
be set through command-line flags to the simulation/synthesis tools.

Initial version by @NilsGraf.

Awesome!


Upgrade maven-dependency-plugin 3.6.1 -> 3.7.0

This PR contains the following updates:

Package
Type
Update
Change

maven-dependency-plugin
build
minor
3.6.1 -> 3.7.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade maven-dependency-plugin 3.6.1 -> 3.7.0

See:
- https://github.com/apache/maven-dependency-plugin/releases/tag/maven-dependency-plugin-3.7.0
- https://github.com/apache/maven-dependency-plugin/compare/maven-dependency-plugin-3.6.1...maven-dependency-plugin-3.7.0


Fix broken link

Fix the broken link to "Map your non Azure AD Identities (preview)"

This was already fixed under a different PR


New Feature diode with required changes

Fixes #
Describe the changes you have made in this PR -
Created a new feature of diode .
Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage remained the same at 84.66% when pulling 8a5fdbc3aa0a78afe77c6cfe55267a9df1caaa90 on mayank-kabra2001:feature-diode into 129182c0f422c9482abe149f730e03292ec1a7ef on CircuitVerse:master.


Fix: wrong keys after migration 🔥

What it solves
After the localStorage refactoring and removal of ImmortalDB, the L2-UX migration became broken.

How this PR fixes it

Renames the v2_ keys to _immortal|v2_ to fix existing broken data
Adds the correct prefix so that new migrations are correct

How to test it
Case 1 (no prior migration):

Run app on localhost:3001 and open some L2 chain on there
Run another version of the app on localhost:3000, open mainnet
Clear localStorage and refresh
It should migrate data from localhost:3001

Case 2 (with prior broken migration):

Run app on localhost:3001
Run another version of the app on localhost:3000 on commit before this fix, open mainnet
Clear localStorage and refresh
Migration should happen but keys will be broken (v2_)
After this commit, these keys should be renamed to _immortal|v2_

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 8 (0.0%)  changed or added relevant lines in 1 file are covered.
406 unchanged lines in 37 files lost coverage.
Overall coverage decreased (-0.2%) to 32.22%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/StoreMigrator/index.tsx
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/routes/safe/components/Settings/SpendingLimit/InfoDisplay/AddressInfo.tsx
1
11.11%

src/routes/safe/components/Transactions/TxList/hooks/useActionButtonsHandlers.ts
1
1.92%

src/routes/safe/components/Transactions/TxList/TxDetails.tsx
1
6.25%

src/utils/constants.ts
1
91.18%

src/logic/safe/store/actions/fetchSafe.ts
2
80.7%

src/logic/safe/utils/safeStorage.ts
2
70.0%

src/routes/CreateSafePage/CreateSafePage.tsx
2
85.14%

src/routes/safe/components/Apps/hooks/useLegalConsent.ts
2
0%

src/routes/safe/components/Transactions/TxList/TxInfoCreation.tsx
2
4.35%

src/utils/storage/index.ts
2
88.24%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
3095

Relevant Lines:
8521

💛  - Coveralls

Case 1 - verified. Checked on staging with clean localstorage


Fix remix depreciation warnings

Resolves #320
Fixed our remix depreciation warnings following their guide
Changes made

Updated remix config to use v2 route layout
Rearranged the entire routes folder to use the new v2 route convention. This moves routes out of folders into just files which are easier to see
Renamed the layout file _index.tsx to _auth.tsx. This was needed because now the index routes are specified by _index.tsx, and it was not possible to specify the index route's layout as _index.tsx
Updated remix config to use v2 formMethod. I found no instance of formMethod anywhere so nothing else was changed for this
(Summary of v1 vs v2: navigation.formMethod === "post"; should now be navigation.formMethod === "POST"; etc)
Updated remix config to use v2 ErrorBoundry API
Merged all existing CatchBoundry and ErrorBoundy into one ErrorBoundry for each file with checks to render different error layouts. CatchBoundry no longer exists in v2
Updated remix config to use v2 meta
Updated root meta function to return array of objects for meta tags instead of a single object with key value pairs

Discussion on Slack: based on https://remix.run/docs/en/main/file-conventions/route-files-v2#nested-layouts-without-nested-urls, we think we should use _auth.* as our pathless, layout route prefix.

Updated to fix the rest of the depreciation warnings + rebased with main


When "forceFallback" is set to true, the element doesn't really follow the cursor.

So, when the "forceFallback" option is turned off, the browser uses the standard Drag 'n Drop API which follows the cursor but I honestly find it quite limiting. I need "forceFallback" turned on so I can scale the element with the CSS transform property when dragged. The problem is that it doesn't really follow the cursor and can lead to confusion. Is there any fix or workaround about it?

I have the same issue for this I have to hide the fallback with css.

+1 Having the same issue

+1 I have the same issue.
when I scroll down more, the offset between the ghost image and the cursor is larger.
so the forceFallback is not usable.

I had some issue with using forceFallback, and I solved it by matching version.
react-sortablejs: "6.0.0"
sortablejs: "1.10.0"

When I used sortablejs over 1.10.0 version, the forceFallback didn`t work properly.

I have the same problem, I still want to use forceFallback, is there any solution?

is there any solution?

https://github.com/SortableJS/Sortable/blob/master/src/Sortable.js#L798
If fallback element inherited style: transform: scale(0.5);, then change the source code variable scaleX and scaleY to 0.5.
It a very dirty workaround.
I am not sure whether it is a good solution to fix it.
https://github.com/SortableJS/Sortable/compare/master...kamilic:patch-1
I add options fallbackOverridedScaleX / fallbackOverridedScaleY to solve this.

This issue is still not fixed.

This issue is still not fixed.

Same here with "sortablejs": "^1.15.2". This issue is still not fixed.

This issue is still not fixed.

Having the same issue with 1.15.3, cannot use the native dragged element because of scale and opacity which I need to customize, but the fallback element doesn't follow the mouse position it's sort of drifting. This makes the whole lib unusable, what temporary fixes are you people using?


In Addition to #227 do the same with components

I think the title says it.

Could you also please change the commit message to be more descriptive? Rather than referencing another commit in the past.

Will do that when I'm at work. Sry for the unneeded Import, overlooked that probably

fixed all the issues

Could you please write a unit test where the component class you want to instantiate is private or something? This way we can test we're actually catching the exception properly.
Thanks!

Did you run your own test @laubed? It broke the build. I will submit a fix now.


Remove buffers noAssert argument

Support for the noAssert argument dropped in the upcoming Node.js
v.10. This removes the argument to make sure everything works as it
should.
Refs: https://github.com/nodejs/node/pull/18395

Ping @mikolalysenko

Ping @mikolalysenko again

PTAL


Change text color to orange when block should be wikified but is not wikified (yet)

Check for type==Country (used to be wikibase item)

Change wikibaseItem label in the types dropdown menu to Country

This will not happen in the causx version because when the type is wikibase-item (country), the system will automatically run the country wikifier and create q-nodes for the cells that don't get wikified, so the user will never see non-wikified cells.

Gotcha, I've changed the label of Wikidata Item in the annotation types menu to Country.
Closing this for now as the changing colors are not relevant (out-of-scope) for CausX.