Added Underline tag

Hey there thanks for the contribution. Would be great if you could star the repo so that it will be helpful for future contributors also. Thanks!

Thank you for merging the Pull request.
I have one request  please add label to it "hacktoberfest accepted" or "hacktoberfest"
So that It will added to my hacktoberfest profile

The repo already have the necessary tags and is already a part of hacktoberfest from last year so it will automatically get accepted.


[BUG] LH fails silently when node has attached volumes

Describe the bug

https://github.com/harvester/harvester/issues/6264
To Reproduce
https://github.com/harvester/harvester/issues/6264

Expected behavior

Print helpful logs
LH uses pdb to protect instance-manager, but canDeleteInstanceManagerPDB doesn't print log when there are volumes attached
https://github.com/longhorn/longhorn-manager/blob/1286504e6f61b6ad0122aaf817ba5952debbb6d6/controller/instance_manager_controller.go#L1021
https://github.com/longhorn/longhorn-manager/blob/1286504e6f61b6ad0122aaf817ba5952debbb6d6/controller/instance_manager_controller.go#L947
Support bundle for troubleshooting

Environment

Longhorn version:
Impacted volume (PV):
Installation method (e.g. Rancher Catalog App/Helm/Kubectl):
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:

Number of control plane nodes in the cluster:
Number of worker nodes in the cluster:

Node config

OS type and version:
Kernel version:
CPU per node:
Memory per node:
Disk type (e.g. SSD/NVMe/HDD):
Network bandwidth between the nodes (Gbps):

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:

Additional context

also refer https://github.com/longhorn/longhorn/issues/5910

Tested on master-head (longhorn-manager eddb7e9) following the test plan.
In scenario 1 To test drain behavior, after detaching the manually attached volume, the drain process still fails to complete. The longhorn-manager log shows replica test-1-r-28486904 has no pdb on another node:
$ kubectl logs longhorn-manager-92zm9 -n longhorn-system -c longhorn-manager
time="2024-09-06T03:41:52Z" level=info msg="Node instance-manager-1c5fea66b35b9b7431bc97d8ac03207a is marked unschedulable but removing ip-10-0-1-7 PDB is blocked: replica test-1-r-28486904 has no pdb on another node " func="controller.(*InstanceManagerController).syncInstanceManagerPDB" file="instance_manager_controller.go:850" controller=longhorn-instance-manager node=ip-10-0-1-7

Here are the detailed test steps:

Create a volume with 1 replica through Longhorn UI
Create PV/PVC for it through Longhorn UI
Create a pod to use the volume:

apiVersion: v1
kind: Pod
metadata:
  name: test-pod-1
spec:
  containers:
    - name: sleep
      image: busybox
      imagePullPolicy: IfNotPresent
      args: ["/bin/sh", "-c", "while true;do date;sleep 5; done"]
      volumeMounts:
        - name: pod-data
          mountPath: /data
  volumes:
    - name: pod-data
      persistentVolumeClaim:
        claimName: test-1

Create another volume and manually attach it to the same node where the pod is running
Drain the node:

$ kubectl drain ip-10-0-1-7 --ignore-daemonsets --delete-emptydir-data --force

The drain will not complete, and longhorn-manager log shows:

$ kubectl logs longhorn-manager-92zm9 -n longhorn-system -c longhorn-manager
time="2024-09-06T03:36:13Z" level=info msg="Node instance-manager-1c5fea66b35b9b7431bc97d8ac03207a is marked unschedulable but removing ip-10-0-1-7 PDB is blocked: some volumes are still attached InstanceEngines count 1 test-2-e-0 " func="controller.(*InstanceManagerController).syncInstanceManagerPDB" file="instance_manager_controller.go:850" controller=longhorn-instance-manager node=ip-10-0-1-7

Detach the manually attached volume
The drain still won't complete, and longhorn-manager log shows:

$ kubectl logs longhorn-manager-92zm9 -n longhorn-system -c longhorn-manager
time="2024-09-06T03:41:52Z" level=info msg="Node instance-manager-1c5fea66b35b9b7431bc97d8ac03207a is marked unschedulable but removing ip-10-0-1-7 PDB is blocked: replica test-1-r-28486904 has no pdb on another node " func="controller.(*InstanceManagerController).syncInstanceManagerPDB" file="instance_manager_controller.go:850" controller=longhorn-instance-manager node=ip-10-0-1-7

supportbundle_33f2628d-398e-4940-bd64-1e2c74144c35_2024-09-06T03-41-02Z.zip
@ejweber Could you help check if there's anything wrong with the test steps? Thank you!


showsUserLocation icon square white

Hello.
I am running app in IOS with google maps provider, but my location icon is a square white. why? or how disable this?

in simulator, on device is perfect


ja: Make docs/concepts/extend-kubernetes/_index.md follow v1.18 of the original text

This is a Feature Request

What would you like to be added
Update docs/concepts/extend-kubernetes/_index.md to follow v1.18 of the original (English) text.
Why is this needed
content/ja/docs/concepts/extend-kubernetes/_index.md is outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/blob/dev-1.18-ja.1/content/ja/docs/concepts/extend-kubernetes/_index.md
Original
https://github.com/kubernetes/website/blob/fb6364d/content/en/docs/concepts/extend-kubernetes/_index.md
diff between translated and v1.18
https://gist.github.com/e2cccf2343a2e13049c5f4255989a482
Note
Currently, we use dev-1.18-ja.1 branch. Please open a PR targeting the branch.
ref
https://kubernetes.io/ja/docs/contribute/localization/
If you have a question, feel free to ask us at slack.k8s.io #kubernetes-docs-ja channel.

/milestone 1.18-ja.1

/assign

/close


Added build-deps.sh

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

NB: I based the connect-races branch off this one and ended up pushing build-deps.sh there, though not the correct one that is in this branch. This branch contains a fix I needed to make after the PR feedback.


Adding attributes is broken

If I add an attribute, no matter what name I give, it adds an attribute with the classname. Because of this, I can't test most other functionality with attributes

Resolved with #39


passing multiple recordids

[Enter feedback here]
Hi,
Is it possible to pass multiple recordids selected from a grid to the custom page?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d5076fa-40a8-fbef-e5a9-1ba9db2ad4e6
Version Independent ID: f7fb3acd-e8f3-27e8-456e-5a5c79d38997
Content: Navigating to and from a custom page in your model-driven app using client API (preview) - Power Apps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/navigate-to-custom-page-examples.md
Service: powerapps
Sub-service: mda-developer
GitHub Login: @aorth
Microsoft Alias: nabuthuk

@malkhwaja Thanks for reaching to us. There is no supported way to pass multiple record IDs. We have this feature in backlog and will update the docs when the feature is ready. Closing the issue. If you need further help, please reopen or create a new issue.

Easy, just use .map to get all the ID in the object and pass it to the recordId field.
function run(selectedItems) {
let itemIds = selectedItems.map(({ Id }) => Id)   // new code here
let selectedItem = selectedItems[0];
if (selectedItem) {
let pageInput = {
pageType: "custom",
name: "",
entityName: selectedItem.TypeName,
recordId: itemIds,  // new code here
};
let navigationOptions = {
target: 2,
position: 1,
width: {
value: 50,
unit: "%"
},
title: "Compare"
};
Xrm.Navigation.navigateTo(pageInput, navigationOptions)
.then(
function () {
// Handle success
}
).catch(
function (error) {
// Handle error
}
);
}
}


KEP-753: Descheduling framework: update diagram

Update the profiles to reflect only Deschedule and Balance plugins are run and the order of first Deschedule of all profiles then Balance of all profiles.

/lgtm


Treating "!" in if-statement as beginning of line comment in line

I think since v1.10 there is apparently a parsing bug. Maybe this was introduces when fixing #118 ? I'm not sure, but this is what happens:
When having a simple if-statement, there is a parsing error when a "!" is part of the if () clause:
if (string == "test") then
  call message("This works fine!")
end if

if (string == "#test") then
  call message("This works fine!")
end if

if (string == ".test") then
  call message("This works fine!")
end if

if (string == "test") then
  call some_routine("!",testing_parameter)
  call message("This also works fine, because the ! is not inside the if() clause!")
end if

if (string == "!test") then
  call message("This breaks fortls, because of a ! in the if() clause!")
  call message("Warnings are primary 'unexpected end of scope' which, I guess, come  from treating the ! as the start of a comment?")
  call message("The rest of the warnings are follow-ups.")
end if

Nice, thanks!


auto format js. spacing is wrong

starting in v.1.7.1 auto format is going crazy. This happens after the editor has been open for some time.
With the settings as spaces,2 it always formats as spaces,4. Restarting fixes the issue and code identifies that file as spaces,4 (which was never manually set) and changing it back now works again.

VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:46:46.244Z)
OS Version: Linux x64 4.4.0-38-generic
Extensions:

Extension
Author
Version

beautify
HookyQR
0.5.4

githistory
donjayamanne
0.1.0

tslint
eg2
0.5.40

Steps to Reproduce:

@relvao 'needs more info' Like, what file does this occur with?

I think this is describing the same issue as #15316

ok - closing as dupe


Removed placeholder sample files.

Deleted sample.py and test_sample.py

Coverage decreased (-0.2%) to 97.143% when pulling 49ebf8b896dbed2cc2c700dcda8908dd4294afa2 on hsim13372:delete_sample into efd56246ffc64239ef6ea4682e2f8f40b380468f on cs207-group11:master.


change "hotkey" for dragging the drawing using mouse

Currently, it is not possible to drag the visible drawing without using both hands:

<SPACE> +  + <MOUSE-MOVE> will grab the canvas and move it where ever the mouse wishes.

Now, when using other drawing or mapping applications, the common "hotkeys" often look like this (or at least they can be configured accordingly):

<LCLICK> + <MOUSE-MOVE> will span an area for selecting inbound elements
<RCLICK> + <MOUSE-MOVE> will pan (move around) the visible area

In order to avoid frustration when having to jump from one application to another, it would be nice to be able to configure these basic mouse movements to the commonly used scheme.
Is there a place within the codebase predestined to accomplish this? At least for a test before creating a PR?

no chance / possibility of realizing a bit of custoomization here?


fix(protocol-parser): properly decode empty records

Pulled out of https://github.com/latticexyz/mud/pull/1113

do you know why this is happening: https://github.com/latticexyz/mud/actions/runs/5589818122/jobs/10218669708?pr=1177#step:5:427 ?

oh i guess it's because of https://github.com/latticexyz/mud/pull/1175 ?

oh yep! there's a test in here that should have been with #1175


Add deprecation tag in API docs for source annotation, function param, and object field

Purpose

Deprecation tag added in the API docs for

source annotation
function parameter
object field.

Fixes https://github.com/ballerina-platform/ballerina-lang/issues/22709
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #22879 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22879   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fa21c...6357ce6. Read the comment docs.


求助

No such file or directory: '15minute_data_california/metadata.csv'

请您帮帮忙

Hello,
This file is not needed to run the optimization. It was used to grab and clean the residential load data in resi_load.csv, which is already uploaded.
Thanks!
Best,
Kevin


Registering specific subnet and release unused addresses

Hi Everyone,
The original flow looks like:

Adding address space
Registering address
Update address

ad. 1
I do not really know if it follows the Azure Network concept:
address space > subnet
I imagine that I can add entire address space for whole Azure setup (HUB + Landing Zones).
ad.2
When I have the address space for the Azure setup then I can register address space for new VNET (from the range added on step 1) and assign smaller chunk to the specific subnets.
ad.3
I can update the range from step 1 or release unused address range (added in step 2).
Does anyone considered it?

Hi KniewkoZ 🙂
Thanks for taking the time to share your thoughts about AIPAS. Maybe it helps to also have a look at the blog post from me on how AIPAS could be used in scenario where a central platform (connectivity) team can manage the IP address ranges.
Check the blog post here
Does this help answer your questions?
Regards,
Stefan Stranger


Invalid Date Exception In active_buses Method

Looks like there is a typo in bus.rb on line 66
time = HrtBus::Parse.time([time, date].join(""))
Resulting data looks like this: 01:35:2603/03
The Parse function is expecting a space in there: DateTime.strptime(data, '%H:%M:%S %m/%d')
Amazingly, this bug didn't break everything all the time. Just didn't work for some data. Adding a space to the join fixes it.

I didn't realize that creating a pull request would create an issue too. Github is awesome. Closing this because its a duplicate of #2.


Closing the body of Response{protocol=http/1.1, code=302, message=Found, url=http://weixin.qh.chinamobile.com/imss/app?service=page/GreenPaymentChannel&listener=initPage&oriurl=http://dapis.mting.info/yyting/gateway/entityPath.action?entityId=29284&entityType=3&opType=1&sections=%5B661%5D&type=0&token=2Jdt4wLs} didn't close its backing stream. Bad interceptor?  okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:178)

OkHttp Dispatcher(673)
java.lang.IllegalStateException
Closing the body of Response{protocol=http/1.1, code=302, message=Found, url=http://weixin.qh.chinamobile.com/imss/app?service=page/GreenPaymentChannel&listener=initPage&oriurl=http://dapis.mting.info/yyting/gateway/entityPath.action?entityId=29284&entityType=3&opType=1&sections=%5B661%5D&type=0&token=2Jdt4wLs} didn't close its backing stream. Bad interceptor?

okhttp3.6.0

RetryAndFollowUpInterceptor

Executable test case?

sorry,i have no test case and cause of the problem seem is the public wifi.


Add container build options

Codecov Report

Merging #368 (6ca2f18) into master (2b6b7e2) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   67.26%   67.20%   -0.07%
==========================================
  Files         120      120
  Lines       10583    10583
==========================================
- Hits         7119     7112       -7
- Misses       3464     3471       +7

Impacted Files
Coverage Δ

assemblyline/datasource/alert.py
88.46% <0.00%> (-3.85%)
:arrow_down:

assemblyline/odm/randomizer.py
93.42% <0.00%> (-2.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6b7e2...6ca2f18. Read the comment docs.


doing some refactoring before adding v3 id schema. merge disk_id vm_id logic together.

--------------------MESSAGE FROM ADMIN, DELETE BEFORE SUBMITTING----------------------
Thanks for submitting a pull request!
All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).
When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.
If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.
--------------------MESSAGE FROM ADMIN, DELETE BEFORE SUBMITTING----------------------

[x] Please check this box and fill the data as below once you have run the unit tests.
Code coverage before your change: 98.51%
Code coverage with your change:   98.56%
pushd src/bosh_azure_cpi
  ./bin/test-unit
popd

NOTE: Please see how to setup dev environment and run unit tests in docs/development.md.

Changelog

this is yet another simple refactoring, please help review. @bingosummer @gossion :)

@gossion please help do a review when you have time.

A lot of code change in disk_id, instance_id. Please run the the migration tests before merge. This script is for your reference, which has several cases for instance_id and disk_id: https://github.com/cloudfoundry-incubator/bosh-azure-cpi-release/blob/master/src/bosh_azure_cpi/spec/manual_tests/resource_group_name/migrate_to_new_rg.rb


New BLAST XML format

The NCBI is now making a new version of the BLAST XML available for
testing.  Read about the changes and how to access BLAST results using
the new XML at ftp://ftp.ncbi.nlm.nih.gov/blast/documents/NEWXML/xml2.pdf

Anyone an interest in this?

Yes for sure, I'm interested— especially for the use of taxids within the more-easily parsable XML format.  Is it already implemented anywhere?  Thanks

@n8upham send me an E-mail and we can discuss. Taxids were sorely missing, indeed.

Hi there
Yes, do you know if the new XML format is (a) up and running, and (b) use-able from the UNIX executable (2.2.31+ now)?  My aim for the XML output is to be able to use biopython’s blast-based tools for parsing.  But right now the option “5” seems to still output regular XML (i.e., without the taxis, which I am keen to use)
Thanks much
—nate

On Jun 24, 2015, at 3:18 AM, Pjotr Prins<EMAIL_ADDRESS>wrote:
@n8upham https://github.com/n8upham send me an E-mail and we can discuss. Taxids were sorely missing, indeed.
—
Reply to this email directly or view it on GitHub https://github.com/pjotrp/blastxmlparser/issues/4#issuecomment-114758991.


Fix: log_stderr didn't work anymore

What's up with these unit tests?

There are two sets of tests now: unit tests which run outside of sublime, and functional tests using UnitTesting.
You cannot import modules using the sublime API (eg settings) in unit-tested code. It needs to be passed in instead if we want to keep the option configurable. I’ve also been tempted to remove settings if the default is likely to suit everyone

Coverage increased (+5.4%) to 27.612% when pulling 70de9b08a67f75e2b316f3b9672365f6afa0b74b on rwols:bugfix/log-stderr into b3bdd43689430882bab5061695b2f09dce79b243 on tomv564:master.

Thanks, please ignore my earlier comment about the unit tests. Had I looked at the failure in travis, I could have helped you with the simple fix.

Thanks for the fix! I don't have much time during regular weekdays, but wanted to dig into the unit test stuff this weekend.


use_ssl parameter is not applied

use_ssl parameter is not applied and SSL is always enabled.
SSL should be optional not mandatory.
I can try and push the changes, but I have never contributed to a random project before on GitHub, so I need to first learn this :)

That's true, thanks for noticing it. I will solve it and publish an updated version


Restructure documentation for website

Details
Huge rewrite of documentation to put into mdbook format.  Working towards deploying to a website for a more official and easy to search structure.
Adding new details, such as testing.

New version of docs are currently being built from this branch to https://rustprooflabs.github.io/pgosm-flex/index.html
Will setup a custom domain soon, that link will either break or redirect in the future.

Now deployed to https://pgosm-flex.com. Might take 24 hours to be available everywhere.

It was working, then I broke it, and I think I fixed it again.  Lots of improvements regardless of the deployment piece...


32-bit marktype

Codecov Report
Patch coverage has no change and project coverage change: -4.80 :warning:

Comparison is base (5eedae9) 77.42% compared to head (9f082d3) 72.62%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   77.42%   72.62%   -4.80%
==========================================
  Files          18       18
  Lines        7396     7289     -107
==========================================
- Hits         5726     5294     -432
- Misses       1670     1995     +325

Impacted Files
Coverage Δ

src/Enzyme.jl
86.95% <0.00%> (-0.55%)
:arrow_down:

... and 11 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[FIX] make sure running tsvread then tsvwrite does not change the file content

fixes #156

[ ] run test on some data from bids example and not an extra tsv file
[ ] support saving row wise structure? This could be pushed to later.

The classic structure tends to not work where mixing types.
  logFile.onset = [2; NaN];
  logFile.trial_type = {'motion_up'; 'static'};
  logFile.duration = [1; 4];
  logFile.speed = [NaN; 4];
  logFile.is_fixation = {'true'; '3'};

  % Leads to trouble
  %   logFile.is_fixation = {'true';3};
  %   logFile.is_fixation = {true;3};

For example mixing logical and numeric does not work in a cell: it prints to the file but the test fails afterwards.
But the previous structure format could allow mixing the format of elements that would end up in the same column of the tsv.
  logFile(1, 1).onset = 2;
  logFile(1, 1).trial_type = 'motion_up';
  logFile(1, 1).duration = 1;
  logFile(1, 1).speed = [];
  logFile(1, 1).is_fixation = true;

  logFile(2, 1).onset = NaN;
  logFile(2, 1).trial_type = 'static';
  logFile(2, 1).duration = 4;
  logFile(2, 1).speed = 4;
  logFile(2, 1).is_fixation = 3;

So we could support this too.

No rush to make a decision on this. If I don't hear back I will silence the test and we can revisit the issue later. :-)


Update tip link

The following tip refers to a YouTube video which refers to a GitHub link which doesn't exist anymore.

In this video, Using Power BI Desktop in government clouds, Technical Specialist Steve Winward shows how you can apply a registry setting to go directly to the right cloud endpoint for your environment. The registry key settings to bypass the global discovery endpoint are shared on GitHub.

I recommend updating the link to the updated GitHub link:
https://github.com/microsoft/Federal-Business-Applications/tree/main/whitepapers/power-bi-registry-settings#dod

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d017bc96-49d4-7b63-9394-1739cdf7528d
Version Independent ID: 1e70d724-121d-feea-471e-307c2f27dd24
Content: Power BI for US government customers - Overview - Power BI
Content Source: powerbi-docs/admin/service-govus-overview.md
Service: powerbi
Sub-service: powerbi-admin
GitHub Login: @kfollis
Microsoft Alias: kfollis

@randomnote1 - thanks for flagging that for us! I appreciate your contribution. I corrected the link and the change will publish within the next 24 hours.


Better Bib(La)TeX export: square brackets

I have problems with the export of square brackets. It seems to be a bit like this one: https://github.com/ZotPlus/zotero-better-bibtex/issues/85 – but it doesn't solve my problem.
As historian, I sometimes have books without a mentioned date and/or location of the publication. In this case, I put the historically derived year and location in square brackets. My citation should then look like this:
Andreas Riem: Behemoth. Der Roman über alle Romane, [Hamburg] [1796].
If I put the year and the location in square brackets in Zotero, Better BibTeX and Better BibLaTeX exports it this way:
@book{riem_behemoth_1796,
location = {{[}Hamburg{]}},
title = {Behemoth. Der Roman über alle Romane},
author = {Riem, Andreas},
date = {1796}
}
– The square brackets of the location now are in curly brackets and the square brackets of the year are gone. This causes my footnote (after running LaTeX) to look like this:
Andreas Riem: Behemoth. Der Roman über alle Romane, [ 1796.
Now, I could work with a script which replaces every "{[}" and "{]}" with "[" and "]", but it would have to run after every new (automatic) export. But this only solves the problem with the location and for the year I would have to add all the missing brackets by hand.
Is it possible to export the data in the regarding fields of Zotero just as they are entered? With all the square brackets I add?
Besides that, Better BibTeX is a great plugin that helps a lot connecting Zotero and LaTeX!

Alright, these are two separate issues (no worries, just making sure I'm addressing them both).
the year field strips brackets
I'm a little surprised the year is stripped from its braces; can you right-click on that reference and select submit zotplus error? That should get me going on fixing the year.
biber doesn't like closing brackets being escaped
The location might look a little gnarly but it should be correct LaTeX; the following MWE:
\RequirePackage{filecontents}
\begin{filecontents*}{\jobname.bib}
@book{riem_behemoth_1796,
location = {{[}Hamburg{]}},
title = {Behemoth. Der Roman über alle Romane},
author = {Riem, Andreas},
date = {1796}
}
\end{filecontents*}

\documentclass{article}
\usepackage[%
  backend=bibtex   % use BibTeX
% backend=biber    % Use biber
]{biblatex}
\addbibresource{\jobname.bib}
\begin{document}
Hello \cite{riem_behemoth_1796}. How are you?
\printbibliography
\end{document}

compiles to
Andreas Riem.Behemoth. Der Roman über alle Romane. [Hamburg], 1796

The biber backend however doesn't like the above at all, and that results in pretty much what you describe. I escape [ and] to prevent LaTeX from treating literal square brackets as parameters, but my preliminary tests show that if I only escape [ stuff looks OK. I'll get to work on that too.

Can you test whether zotero-better-bibtex-1.0.5-2015-07-14@16:20:55.xpi at https://zotplus.github.io/better-bibtex/#debug addresses the second problem?

okay, the second problem seems to be my fault. I added "backend=bibtex" to my file and the square brackets are there as they should be. Thank you!
For the first problem I submitted the error. the code is 4RCU2UNQ-TXFDRJDT (if you need this).

without "backend=bibtex" and with the version you posted above, it works perfect, too. it exports "{{[}Hamburg]}"

Nono, not your fault, I want it to work with biber too; the debug version I
posted above should work with biber as you had it before.
I'll look into the first problem when I get home.

Thank you.
I just remembered another problem, I had recently with a customized export: I wanted to define a xref entry and put
bibtex[xref=welker_andreas_1999]
into the extra field of Zotero. The output is translated into correct LaTeX with a backslash before each underscore.
xref = {welker_andreas_1999}
Is there a way to prevent the LaTeX translation of the underscores?

Sure; could you file a separate issue for that?
On Jul 14, 2015 5:18 PM, "Wekhrlin"<EMAIL_ADDRESS>wrote:

Thank you.
I just remembered another problem, I had recently with a customized
export: I wanted to define a xref entry and put
bibtex[xref=welker_andreas_1999]
into the extra field of Zotero. The output is translated into correct
LaTeX with a backslash before each underscore.
xref = {welker_andreas_1999}
Is there a way to prevent the LaTeX translation of the underscores?
—
Reply to this email directly or view it on GitHub
https://github.com/ZotPlus/zotero-better-bibtex/issues/245#issuecomment-121279702
.

Could you try to generate another debug log by right-clicking on the entry that has the [1796] and selecting Report Zotplus Error from that menu (so not from the gear menu - -that doesn't send me the sample)

Never mind, I see it now.

it was the report from right-clicking – but I see the same report text when I access it via the gear menu...

It is indeed broken -- I've filed a separate bug for that, but I have a handle on things for this bug

1.0.6 is out, and fixes both #245 and #246

you are going to hate me, but it seems that the export is broken, now. I get a JavaScript Application-warning that an error occurred while exporting:

It's the same on my girlfriend's computer with a whole different library... shall I report a new issue?

Yes please! Inclusing a debug log

no. doesn't work. HIM54E48-XSGUUNT9


[OPENJDK-59] s390x imagestreams

First cut, needs another eyeball

Hi @yselkowitz , could you take a look at this, please? These are the OpenJ9/s390x image names/versions that we plan to ship. I wanted to merge this prior to writing Errata text, as the errata text will refer to the URI for this file. But not knowing how your import process to Openshift/library works for the architecture-specific stuff, I hoped you could give it a quick eyeball to be sure it was ok. Thanks!

(note to self: once this is merged, raise a develop→release merge-down PR)


Room chat – Task in a room appears with a delay for user B

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.61-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal team
Action Performed:

Go to https://staging.new.expensify.com/
Log in.
Go to any room chat as user A
In incognito tab log in as user B (group member)
As user A create a task
As user B observe the room chat

Expected Result:
Task in a room appears immediately for user B
Actual Result:
Task in a room appears with a delay for user B
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/b1d281e9-9c14-490f-a170-5afb6d99d9f1
View all open jobs on GitHub

We think that this bug might be related to #vip-vsb

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Hmm, interesting. So maybe we aren't sending a pusher event for this. I'll try to reproduce.

I'm going to close this for now. Doesn't seem worth prioritizing.


Improve regex validator error message to be descriptive

Fixes #760

Thanks!  🙂

@sunli829 do you think it would be ok to include regex inside message?

Sounds good!👍

Thanks! 🙂


Not all supported operators are included in the grammar

The grammar omits the operands listed under the "Comparison Operators" heading.
operator = '&&'
         | '||' ;

Could perhaps become:
operator = '&&'
         | '||'
         | '<='
         | '<'
         | '>'
         | '=='
         | '!=' ;

Added the comparison operators in 8c0c409. See #53 for && and ||. See #56 for in.


🚀 Feature: Installation Optimization

🔖 Feature description
The current installation process for DocsGPT is taking too long, and we need to optimize it. The goal is to streamline dependency management, improve Dockerfile performance, and explore lazy loading techniques for specific components like vector DBs, LLMs, parsers, and retrievers.
Additionally, we want to investigate transitioning away from LangChain in the future to reduce dependency load and improve flexibility.
🎤 Why is this feature needed ?
Long installation times and heavy dependencies impact the user experience, especially for contributors and developers working with DocsGPT. Optimizing the setup will lead to faster installation, fewer dependency issues, and better resource management.
✌ How do you aim to achieve this?

Thorough Dependency Checks:

Review and audit all Python dependencies to identify unnecessary or outdated packages.
Perform a similar review for NPM dependencies to ensure no excessive or redundant libraries are being used.

Dockerfile Optimization:

Check the current Dockerfile setup for inefficiencies, reduce build layers.

Explore UV (https://github.com/astral-sh/uv):

Investigate the possibility of implementing UV. Test the difference in performance and installation times.

Lazy Loading:

Implement lazy loading for components that are not immediately needed during the initial setup, such as vector databases, LLMs, parsers, and retrievers, reducing the initial installation footprint.

Move Away from LangChain:

This will improve DocsGPT’s flexibility and reduce unnecessary dependencies in the future.

This task involves multiple areas of optimization, so collaboration is highly encouraged. Feel free to contribute directly to this issue or join the discussion in our Discord (collaborative-issues).
If necessary, this issue can be split into smaller, focused tasks. Please ensure all related issues are linked back to this original for tracking purposes.
🔄 Additional Information
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

Are you willing to submit PR?
None

@pabik I have some experience with these type of Fullstack Application with  Node.js and Flask, It seems like there are some redundant dependencies and your requirements.txt and Package-lock.json Files. Please assign me the issue and I'll make a pull request


Packaging Updates and Documentation

Pull Request To-Do List
Description of the changes

Mostly added automatic documentation with Sphinx, which will generate documentation from the readme.rst, contributin.rst, and all of the python modules' method, classes, etc.
I have done the following to make this PR ready for review:

[x] I have updated the requirements.txt file (if appropriate)
[x] I have re-based my branch on the latest master branch
[x] I have added necessary documentation (if appropriate)
[x] I have commented my code, particularly in hard-to-understand areas

For the reviewer, make sure this PR meets these criteria before merging:

[ ] New code has comments
[ ] New code has tests (if appropriate)
[ ] New code has documentation (if appropriate)
[ ] New code has been reviewed by at least one other person

The chekcs are going to fail because there are a bunch of issues on the GMLV part of the package


Examples don't work

There are (currently) three examples:

hello_world.osc

This works fine.

write_file_stuff.osc

This fails because it tries to call the built-in function fclose which isn't setup in src_defaultlib.c.
Commenting out the calls to fclose() allows it to run.

color_circles.osc

This tries to call the function rand() which isn't defined in src_defaultlib.c.
Changing the calls to rand() to read randomint() allos it to get further.
But even with that  we see failures:

deagol ~/cidscropt $ ./bin/cidscropt examples/color_circles.osc
variable 'vid_width' does not exist!
BLOCK=1,curpos=832,at=895

Shuffling the variables around so each is defined in the functions eventually allows it to run, but nothing useful happens:
  deagol ~/cidscropt $ ./bin/cidscropt examples/color_circles.osc
  built-in function 'set_pixel' does not exist! (0)
  Segmentation fault

It looks like variables defined inside functions aren't accessible outside that function, which is is what you'd expect from a C-like function.  This is demonstrated by this example:
 function bar()
 {
    global = 3
    print("Global set to " + global + "\n" );
 }

 main() {
    bar()
     //   print("Global is now dead: " + global + "\n")
 }

Uncomment the second print and you see a failure - and this is exactly how the code in the color_circles example is setup  - specifically you'll see the function rand_col() defined variables, and the vid_size, etc, variables in main aren't available in clear_screen().
In short it would be nice if the examples all worked :)

The hello world I quickly made just to show an up-to-date example, the other examples e.g the color one is from a old interpreter version which is on my github aswell but I still had them, the fclose I changed later to automatically close but I forgot to update the example. I will try to add more examples and fix the old ones that don't apply anymore.
As for globals, there are none except level for now. (In the old interpreter everything was a global)
level is a global object which you can assign fields to.
I also temporarily removed some windows dependent code e.g set_pixel and will readd them later again.

I will try to add more examples and fix the old ones that don't apply anymore.

Great, thanks.
Having examples (&documentation!) makes the project use more obvious, and shows what it can do, but even without things being current I found out how it worked well enough with a bit of trial and error.  Good project :)


Retain filename casing

I see you convert the filename to cameCase so that webpack.config.js and data-dump.json converts to feasible names, but this ignores the files title casing. If the file is named Direct-Open.js it should be import DirectOpen from ..., not import directOpen....

Very relevant for those using React which demands component names start with uppercase.
import MyButton from './MyButton'
<MyButton />

Hey @einarlove , I had noticed this issue as well. Would it be enough to camelCase the name no matter what, and then, if if the name was upper case originally, upper case the first letter?

@einarlove I implemented what I said above. Try it out on v0.1.8 :)

Been using it all day and can't find a issue with your fix. Great job @tnrich!

Glad to hear it.


RuntimeError: Cannot launch Triton kernel since n = 102400 exceeds the maximum CUDA blocksize = 65536.

Env:

base model: deepseek-llm-7b-base
Code: Unsloth - Alpaca.ipynb
GPU = NVIDIA GeForce RTX 3090. Max memory = 23.689 GB.
5.176 GB of memory reserved.

Traceback:
RuntimeError                              Traceback (most recent call last)
/workspaces/unsloth-train-playground/train.ipynb Cell 6 line 1
----> 1 trainer_stats = trainer.train()

File /workspaces/unsloth-train-playground/.venv/lib/python3.11/site-packages/trl/trainer/sft_trainer.py:280, in SFTTrainer.train(self, *args, **kwargs)
    277 if self.neftune_noise_alpha is not None and not self._trainer_supports_neftune:
    278     self.model = self._trl_activate_neftune(self.model)
--> 280 output = super().train(*args, **kwargs)
    282 # After training we make sure to retrieve back the original forward pass method
    283 # for the embedding layer by removing the forward post hook.
    284 if self.neftune_noise_alpha is not None and not self._trainer_supports_neftune:

File /workspaces/unsloth-train-playground/.venv/lib/python3.11/site-packages/transformers/trainer.py:1555, in Trainer.train(self, resume_from_checkpoint, trial, ignore_keys_for_eval, **kwargs)
   1553         hf_hub_utils.enable_progress_bars()
   1554 else:
-> 1555     return inner_training_loop(
   1556         args=args,
   1557         resume_from_checkpoint=resume_from_checkpoint,
   1558         trial=trial,
   1559         ignore_keys_for_eval=ignore_keys_for_eval,
   1560     )

File /workspaces/unsloth-train-playground/.venv/lib/python3.11/site-packages/transformers/trainer.py:1860, in Trainer._inner_training_loop(self, batch_size, args, resume_from_checkpoint, trial, ignore_keys_for_eval)
   1857     self.control = self.callback_handler.on_step_begin(args, self.state, self.control)
...
     24                        f"the maximum CUDA blocksize = {MAX_FUSED_SIZE}.")
     25 num_warps = 4
     26 if   BLOCK_SIZE >= 32768: num_warps = 32

RuntimeError: Cannot launch Triton kernel since n = 102400 exceeds the maximum CUDA blocksize = 65536.

@FlatMapIO Sadly known limitation - I forgot to write it as a limitation and I'm working on it.
The issue is the max CUDA threads is 2^16 or 65536, so the vocab_size for Deepseek is a bit larger (ie 102400) 102400's next power of 2 will become 2^17, which is 131072, and will not work on the current Unsloth implementation.
I'll have to rewrite the cross_entropy_loss code to support splitting the calculation into multiple grids, then do a final reduction step for logsumexp.
If this is a more popular request - I will implement it!! So more likes and stars would be helpful!!

@danielhanchen 100% worth the effort! Deepseek-Coder-33B is an amazing coder. And then there is Deepseek-LLM-67B, which is even much better (although twice as big) than that. NO OTHER open model comes close to these two at coding tasks. In fact maybe only GPT-4 is better at such tasks, but it's knowledge cut off is from some time ago so it's less useful with some newer APIs.
So fine-tuning those two Deepseek models on one's code base would be a game changer. Another game changer would be even faster inference than what exllamaV2 can achieve, but that's another topic :))

I use 3090. This seems to be the case again in 2024.1

@AIlaowong I haven't gotten around to supporting larger vocab sizes - 2024.1 still only supports 2^16 (65536) max. I'll probably work on it until I get DPO and other stuff resolved first.

So what I can do temporarily since I can see Qwen specifically (and that means Deepseek) is to temporarily use Pytorch's CrossEntropyLoss if the vocab size exceeds 2^16, and for a future release I'll implement larger vocab sizes. What do you all think?

That's up to you! I'm genuinely excited to see the results of your updates. It's truly uplifting to know that the training speed of LLMs is being improved.

Added prelim support for ALL kernel sizes!

Closing now since it's supported for now!


"Trim" frame property not properly applied when cropping Sprite that's using an Atlas

Version

Phaser Version: 3.60

Operating system: Window 11

Browser: Chrome

Description
Cropping a trimmed sprite seems to not work appropriately. The frame I'm using belongs to an atlas, in case that matters.
Without crop:

With  sprite.setCrop(0, 0, sprite.width, sprite.height)

Example Test Code
this is wat happen if I use the following codes:
sprite.setCrop(0, 0, 100, 100)

sprite.setCrop(0, 0, sprite.width, sprite.height)
or sprite.setCrop(0, 0, 100000, 100000); (to make sure I'm not being short with w and h)

A noteworthy thing is that, in this case, the trim is a 11 and the crop changes only below width - trim*2, meaning that with
sprite.setCrop(0, 0, sprite.width, sprite.height) and sprite.setCrop(0, 0, sprite.width-22, sprite.height-22) I don't se changes, but below sprite.setCrop(0, 0, sprite.width-23, sprite.height-23) I start to see changes in the trimming.
These are this partucalr trim values if i do sprite.setCrop(0, 0, sprite.width, sprite.height)

This is the frame config in the atlas.json

Additional Information

This is the correct behaviour, although it's probably worth adding to the docs. Cropping just lets you set the UV coordinates of the texture. So if the texture has been trimmed, you're working from those coordinates, not the sprite size, as that's outside of the UV coords. All it really lets you do is make the UV coords smaller than the defaults.


Fix configuration documentation

Uncomment ingress/egress filter parameter and quote their value. Also modify pflang expression to show something more illustrative.

LGTM, with the caveat that none of these lines are , terminated, in line with the rest of the file and at odds with actual configuration files. Thanks.

Closing. Fixed in #340


Captured_run_id is incorrect if run has been inserted

Currently a new run gets a captured_run_id inserted based on the following logic
    if captured_run_id is None:
        with atomic(conn) as conn:
            query = """
            SELECT
                max(captured_run_id)
            FROM
                runs"""
            curr = transaction(conn, query)
            existing_captured_run_id = one(curr, 0)
        if existing_captured_run_id is not None:
            captured_run_id = existing_captured_run_id + 1
        else:
            captured_run_id = 1

Consider a database with 10 runs where a dataset is added via ds = load_from_netcdf(...) and ds.write_metadata_to_db()
If that dataset has captured_run_id==100 the next dataset created as part of a measurement would have
run_id ==12 and captured_run_id==101 breaking the expectation that the run_id == captured_run_id for any new dataset.
Suggested fix replace max(captured_run_id) with max(run_id) in the above code and check once the row has been written that run_id == captured_run_id for new  runs.

Suggested fix replace max(captured_run_id) with max(run_id) in the above code

oh totally! Good catch!


feat: change from build on action to pre build image

I need to create an org on docker hub p1nkun1c0rns first ... 😞


[Feature] Make GraphRandomErrorPlugin wait time configurable

When returning throttling (429) responses currently always 5 seconds are returned.
https://github.com/microsoft/dev-proxy/blob/e439251642afb3ceafaaf24456a22dfb7365e219/dev-proxy-plugins/RandomErrors/GraphRandomErrorPlugin.cs#L37C23-L37C43
I'd like to configure this value to be e.g. 5 minutes, to simulate the more extreme cases.

As far as I know, the retry-after value is always 5 seconds. The extreme case which you're referring to, would be simulated by your app being throttled for a total of several minutes, but each time with 5 seconds intervals.

@waldekmastykarz I did not know this (implementation?) detail about MS Graph. Fair enough. What about the SharePoint API? The plugin also handles those endpoints and I suspect the rules might be different there. When CSOM calls get throttled, is the wait also always 5 seconds?

As far as I know, also in SharePoint the wait time is always 5 seconds. I'll double check with the respective PGs to confirm that nothing has changed.

@waldekmastykarz If that would be the case that the wait time is always 5 seconds, and my assumption that my app handles those waits properly holds true, then my assumption of >40 seconds waits due to throttling is probably wrong.
Thanks for checking. In the meantime I'm falling back to the more generic GenericRandomErrorPlugin as shown here: https://learn.microsoft.com/en-us/microsoft-cloud/dev/dev-proxy/how-to/test-that-my-application-handles-throttling-properly

@waldekmastykarz If that would be the case that the wait time is always 5 seconds, and assuming my app handles those waits properly, then my assumption of >40s waits due to throttling is probably wrong. But I'm pretty sure I saw wait times up to several minutes happening. Might be as penalty when not adhering to the 5s? Not sure.

My understanding was, that when throttled, you should wait for the specified period of time. If you keep sending requests, throttling will be prolonged, basically resetting the timer after each call. Let me double check if that's still the case, as our services keep evolving.

It seems like the retry-after value in SPO is variable. We'll update the plugin to make it configurable. Thank you for bringing it up.

This is well-aligned with my observations and interpretations :D

We've just released a new beta version with the retry-after value in the GraphRandomErrorPlugin being configurable:
{
  "graphRandomErrorsPlugin": {
    "retryAfterInSeconds": 10
  }
}

You can grab it using our beta setup script.
Thanks again for bringing it up!


Fix write from array that is not row or column order

Issue and/or context: #2537
Changes:
When writing a dense array, this change will check if the data is neither row major nor column major and explicitly set it to be row-major before writing.

Closes #2537


Request: Join open network

Would like to have fall through option where failing to join a saved network then autoconnect will attempt to join open networks.

cool idea.


Error Uploading PCG_cpp on visual studio 2015

Hello,
I have attempted to use the pcg number generator on visual studio but constantly faced with this error in this part of code.
#ifndef PCG_LITTLE_ENDIAN
#if defined(BYTE_ORDER)
#if BYTE_ORDER == ORDER_LITTLE_ENDIAN
#define PCG_LITTLE_ENDIAN 1
#elif BYTE_ORDER == ORDER_BIG_ENDIAN
#define PCG_LITTLE_ENDIAN 0
#else
#error BYTE_ORDER does not match a standard endian, pick a side
#endif
#elif LITTLE_ENDIAN || _LITTLE_ENDIAN
#define PCG_LITTLE_ENDIAN 1
#elif BIG_ENDIAN || _BIG_ENDIAN
#define PCG_LITTLE_ENDIAN 0
#elif __x86_64 || x86_64 || __i386 || i386
#define PCG_LITTLE_ENDIAN 1
#elif powerpc || POWERPC || ppc || PPC
|| m68k || mc68000
#define PCG_LITTLE_ENDIAN 0
#else
#error Unable to determine target endianness  // error in this directive
#endif
#endif
The error is shown in this directive  comment.

It could be because VC uses _M_X64 macro to identify x64 architecture. Could you please try adding _M_X64 macro to this line #elif __x86_64 || x86_64 || __i386 || i386 .
It should look like #elif __x86_64 || x86_64 || __i386 || i386 || _M_X64

Modify that line to the below to also include 32 bit as well as 64 bit on MSVC
#elif __x86_64 || x86_64 || __i386 || i386 || _M_IX86 || _M_X64

I am still getting this error on msvc 2019 and the solution works


[FEATURE] Support creating alert in the chat window

Is your feature request related to a problem?
Support creating alert in the chat window as a follow-up question of alert analysis, as shown in this mock up figma workflow
What solution would you like?
What alternatives have you considered?
Do you have any additional context?

[Catch All Triage - 1, 2, 3]


Add new chaos test suite.

Scope & Purpose
Backport of #14406
Add a chaos test suite with a cluster-chaos-load test which revealed several issues in the replication system.

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Backports:

[x] Backports required for: 3.8, 3.7

Testing & Verification

[ ] This change is a trivial rework / code cleanup without any test coverage.
[ ] The behavior in this PR was manually tested
[ ] This change is already covered by existing tests, such as (please describe tests).
[ ] This PR adds tests that were used to verify all changes:

[ ] Added new C++ Unit tests
[ ] Added new integration tests (e.g. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

[ ] There are tests in an external testing repository:
[ ] I ensured this code runs with ASan / TSan or other static verification tools

http://jenkins01.arangodb.biz:8080/job/arangodb-ANY-matrix/43/

Obsolete as this test is now part of https://github.com/arangodb/arangodb/pull/14398


CLOUD-45516: server side security rule validation

@doktoric pls review

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1897/


Set from and to dates before opening calendar

Hey! Thank you so much for opening this component. It looks really amazing!
I was wondering if it's possible to leave the from and to dates set, so if the user selects two dates and wants to change, he could then open the calendar up and see the selected dates there, then change.
Thanks once again!

Remember the last result？

Exactly. The dates would already be selected.

Is that so?

Perfect! but I can one set the dates when loading the calendar? For instance, I get from and to dates from the server, and if I open the calendar, those dates would be set?


Fix lifetime issue of mutable morphs #161

mut::Morphology dtor no longer calls mut::Section dtors. Instead it unlinks them
so they become flagged as unusable. Any attempt to use them will result in an
RuntimeError exception.
The python garbage collector becomes the guarantor of the sections deletion.

@mgeplf This is an attempt at fixing the issue. The main drawback I see is that this also makes the C++ users directly responsible for deleting the mutable sections. However, right now it is not really an issue since there are no mutable C++ API users.
This is just a draft, let me know what do you think and if you think it's worth continuing in this direction (updating the README and such)

I put a comment here :
https://github.com/BlueBrain/MorphIO/issues/161#issuecomment-780583576

The PR is ready for review. I can't currently fix the CI since ./ci/check_clang_format.sh currently gives
ERROR: Could not find a version that satisfies the requirement clang-format==9.0.0

on my mac but I'll fix this tomorrow on my linux machine.

The PR is ready for review. I can't currently fix the CI since ./ci/check_clang_format.sh currently gives

Can you explain the methodology a bit?

Preface: Since the immutable API is left untouched and is not part of the discussion, the variable and class names used in the following will refer to the ones in the mutable namespace.
API change
As before, the morphology object is a container of shared_ptr<Section> however the big change is that Section objects no longer own a raw pointer Morphology* but a weak_ptr<Morphology>.
This weak pointer is only used when trying to retrieve topological information like Section::parent or Section::children. Before each use of this pointer, a check is made on its ref count. If the ref count is 0, an exception will be thrown. The take away point is that if the parent morphology is deleted, a section can still be used but attempts to access any topological information will result in an exception.
Implementation change
Implementation wise, the big changes are:

On the c++ side, a Morphology object must no longer be created on the stack, it must be created with std::make_shared<Morphology>. This is because in order to pass the morphology weak pointer to the Section ctor, Morphology::shared_from_this() is used and requires an existing shared pointer.
A corollary is that the registration of the Section objects can no longer be done in the Morphology ctor because the shared pointer has not yet been created. Hence, on the c++ sides instantiating an Morphology object from a file on disk or another morphology must be done in 2 steps: an invocation of the ctor followed by an initialization:

auto morph = std::make_shared<Morphology>();
morph->init(filename)

ℹ  On the python side, no changes are required since these two steps have been wrapped in the pybind ctor of the Morphology class. To be clear, the user can keep using the following like in the past:
morph = Morphology(filename)

ℹ  Since the class GlialCell derives from Morphology it is subject to the same changes (can no longer be created without std::make_shared and requires a 2-step initialization).

Sorry I forgot to do the review today. I will do it tomorrow.

Thanks for the description, makes a huge difference for understanding.  I still have to review though, but I have good context.

I think I am good with the changes.
I will do a second path on this just to be sure I am not missing something.

IMO, the C++ current memory model in MorphIO is fine and decorrelating the liveness of C++ Section and Morphology:

does not intrinsically address #234 (despite it fix it) because IMO #234 is liveness problem in Python because C++ and Python memory models are different.
introduce complexity in the API in the sense that C++ code using a Section must now ask itself if the associated Morphology instance is still here.

from morphio.mut import Morphology
m = Morphology('simple.swc')
s = m.root_sections[0]
del m # ~mut.Morphology() called
print(s.children) # use after free

The issue here is that Python should know that s depends on m. This is a Python reference counting issue to me. s  (the Python object) should have a reference to the Morphology Python object so that del m does not really destroy m.

@tristan0x Thanks very much for looking at this; it's very helpful.

IMO, the C++ current memory model in MorphIO is fine and decorrelating the liveness of C++ Section and Morphology:

To confirm, you mean what exists in currently in master, not what is in this PR?

introduce complexity in the API in the sense that C++ code using a Section must now ask itself if the associated Morphology instance is still here.

This is the crux of it, in my opinion; I don't think this is just a mismatch of C++/python memory models.  The current mut::Section has a backpointer to its Morphology (https://github.com/BlueBrain/MorphIO/blob/master/include/morphio/mut/section.h#L109); if that Morphology gets deallocated, the mut::Section then has a dangling pointer, which has ended up in hard to debug problems.
On the C++ side, I could imagine the same issue being triggered by something like (excuse my bad code):
using Sections = std::vector<std::shared_ptr<morphio::mut::Section>>;
Sections get_first_sections(std::vector<std::string> paths)
{
  Sections ret;
  for(auto path : paths){
    auto s = morphio::mut::Morphology(path).sections();
    ret.push_back(s[0]);
  }
  return ret;
}

morphio::mut::Morphology make_franken_morph(){
   Sections secs = get_first_sections({"data/simple.swc", "data/simple.swc"});

   auto new_m = morphio::mut::Morphology("data/simple.swc");
   for(auto sec: secs){
     new_m.appendRootSection(sec, true);
   }
   return new_m;
}

In this case, it's only the std::shared_ptr<mut::Sections> that are passed between functions, and the morphs get dtor'd.  This causes a failure when appendRootSection tries to access the dangling Section::morphology pointer; this is a slightly contrived example, but I don't think it's out of the ordinary to expect shared_ptr wrapped object to act like a value type, and not require other objects to be kept alive - however, I'm not up to date on C++, so maybe it's expected that this would work?

The issue here is that Python should know that s depends on m. This is a Python reference counting issue to me. s (the Python object) should have a reference to the Morphology Python object so that del m does not really destroy m.

That's true, and that would be my preferred fix; then the behavior is pythonic; however, it should also still be C++ithic, so that we aren't just targetting python.

Thoughts on the above @wizmer / @tomdele / @tristan0x ?
Setting mut::Section::_morphology to nullptr in the Morphology dtor would, I think, make the errors to detect, along w/ adding the throwing of exceptions where that pointer is used.

Replaced by #253


Error in collect() breaks Pathway2Targets

I have posted this in my other issue, but I think it's probably unrelated so I'm posting it here as a separate issue.
I am using Pathway2Targets with R 3.6.3 , but I am getting this error:
[1] "Working...Pathway 1 of 18 : Cell Cycle"
Error in `collect()`:
! Failed to collect lazy table.
Caused by error in `db_collect()`:
! Arguments in `...` must be used.
✖ Problematic argument:
• ..1 = Inf
ℹ Did you misspell an argument name?
Backtrace:
     ▆
  1. ├─biomaRt::getBM(...)
  2. │ └─BiocFileCache::BiocFileCache(cache, ask = FALSE)
  3. │   └─BiocFileCache:::.sql_create_db(bfc)
  4. │     └─BiocFileCache:::.sql_validate_version(bfc)
  5. │       └─BiocFileCache:::.sql_schema_version(bfc)
  6. │         ├─base::tryCatch(...)
  7. │         │ └─base (local) tryCatchList(expr, classes, parentenv, handlers)
  8. │         └─tbl(src, "metadata") %>% collect(Inf)
  9. ├─dplyr::collect(., Inf)
 10. └─dbplyr:::collect.tbl_sql(., Inf)
 11.   ├─base::tryCatch(...)
 12.   │ └─base (local) tryCatchList(expr, classes, parentenv, handlers)
 13.   │   └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
 14.   │     └─base (local) doTryCatch(return(expr), name, parentenv, handler)
 15.   └─dbplyr::db_collect(x$src$con, sql, n = n, warn_incomplete = warn_incomplete, ...)
 16.     └─rlang (local) `<fn>`()
 17.       └─rlang:::check_dots(env, error, action, call)
 18.         └─rlang:::action_dots(...)
 19.           ├─base (local) try_dots(...)
 20.           └─rlang (local) action(...)
Execution halted
The command '/bin/sh -c Rscript --vanilla "/Pathway2Targets/Pathways2Targets2.R" "/Pathway2Targets/Example_enrichr_Input.csv"' returned a non-zero code: 1

This is using the enrichr example file in your repository.
It looks like there is an Inf being passed to dplyrs collect(), but I cannot figure out why?
Thanks in advance!

the collect() function has a bug in one of the BioConductor packages that this software uses, and isn't an issue with Pathway2Targets itself. A patch was recently released that fixes the bug. There are a few options to fix it described here:
https://stackoverflow.com/questions/77370659/error-failed-to-collect-lazy-table-caused-by-error-in-db-collect-using


Activating Open Collective

Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/esp-rfid❤
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. more info. See how it looks on this repo.
You can also add a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). More info
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets
P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).
Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

Thanks for your time arranging this. Can you please change your request to dev branch. There is already unmerged commit about open collective campaing then i can easily cherry-pick the commits.

@monkeywithacupcake Thank you, I did manual merge on dev branch. Closing this PR.


vscode: add telemetry v2 SDK

This PR attempts to add integrations with the new telemetry SDK at https://github.com/sourcegraph/telemetry to the VSCode Cody client. Overall gist:

lib/shared/src/telemetry-v2: predefined allowed event features, actions, and metadata keys, and a constructor for a TelemetryRecorderProvider
lib/shared/src/sourcegraph-api: new method for the new telemetry { recordEvents } mutation, and a exporter implementation to plug into https://github.com/sourcegraph/telemetry. This exporter makes a best-effort attempt at sending things to the old API if the Sourcegraph server is outdated. I've also added support for https://github.com/sourcegraph/sourcegraph/pull/57056 - the only way to add an actor to an event now is to make the record request as an actor. The default implementation also attaches metadata we already include today about the configuration
vscode/src/services/telemetryV2.ts: partial clone of vscode/src/services/telemetry.ts using the new APIs
vscode/src/main.ts: hook in init/update of the new APIs and one example usage at the fixup callsite

More details in https://docs.sourcegraph.com/dev/background-information/telemetry and #wg-event-logging-everywhere
Closes https://github.com/sourcegraph/sourcegraph/issues/56919
Test plan

[ ] Automated tests
[ ] Manual testing with extension in dev mode

I think I have this mostly working - I see things working in test output mode, but can't seem to get the events to export to Sourcegraph.com when I use pnpm run dev:

The response seems to contain nothing, and when I take the exact data to the GraphQL console, I can record the event:
mutation RecordTelemetryEvents($events: [TelemetryEventInput!]!) {
	telemetry {
		recordEvents(events: $events) {
			alwaysNil
		}
	}
}

Variables:
{
  "events": [
    {
      "feature": "cody.savedLogin",
      "action": "executed",
      "source": {
        "client": "VSCode.Cody",
        "clientVersion": "0.14.1"
      },
      "parameters": {
        "version": 0,
        "metadata": [
          {
            "key": "contextSelection",
            "value": 1
          },
          {
            "key": "chatPredictions",
            "value": 0
          },
          {
            "key": "inline",
            "value": 1
          },
          {
            "key": "nonStop",
            "value": 0
          },
          {
            "key": "guardrails",
            "value": 0
          }
        ]
      }
    }
  ]
}

https://sourcegraph.com/api/console#{"query"%3A"mutation RecordTelemetryEvents(%24events%3A [TelemetryEventInput!]!) {\n\ttelemetry {\n\t\trecordEvents(events%3A %24events) {\n\t\t\talwaysNil\n\t\t}\n\t}\n}"%2C"operationName"%3A"RecordTelemetryEvents"%2C"variables"%3A"{\n  \"events\"%3A [\n    {\n      \"feature\"%3A \"cody.savedLogin\"%2C\n      \"action\"%3A \"executed\"%2C\n      \"source\"%3A {\n        \"client\"%3A \"VSCode.Cody\"%2C\n        \"clientVersion\"%3A \"0.14.1\"\n      }%2C\n      \"parameters\"%3A {\n        \"version\"%3A 0%2C\n        \"metadata\"%3A [\n          {\n            \"key\"%3A \"contextSelection\"%2C\n            \"value\"%3A 1\n          }%2C\n          {\n            \"key\"%3A \"chatPredictions\"%2C\n            \"value\"%3A 0\n          }%2C\n          {\n            \"key\"%3A \"inline\"%2C\n            \"value\"%3A 1\n          }%2C\n          {\n            \"key\"%3A \"nonStop\"%2C\n            \"value\"%3A 0\n          }%2C\n          {\n            \"key\"%3A \"guardrails\"%2C\n            \"value\"%3A 0\n          }\n        ]\n      }\n    }\n  ]\n}"}

CI checks green, tidied up the last bits, did manual testing - I think this is good for a real review now :)


mWeb - Emoji - Flag emojis have a weird behavior after trying to delete it

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com
Log in with any account
Select any conversation
Inset any flag in composed box
Then click on delete it

Expected Result:
Flag emojis have been deleted and no any issue displayed in composed box
Actual Result:
Flag emojis have a weird behavior after trying to delete it
Workaround:
Unknown
Platform:

Where is this issue occurring?

Mobile Web

Version Number: 1.0.85-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/44479856/129262296-ebe6cd73-4462-4cb1-8ddb-4cbd6cdbe0cf.mp4
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I think this is due to the recent addition of Unicode to Keep the larger version. cc: @rdjuric

This seems like an external, @bfitzexpensify not sure if you followed the other Issue, but since you seems to be the go to person about Emojis I CCing you 😄

@isagoico is this a blocker issue or just a regression? Just wandering what is the priority?

It's a regression. Issue is reproducible in the prod build.

Issue reproducible during KI retests

Thanks, I'll set this as weekly, something we should definetly fix, but it's not holding anything.

Also this seems like an external

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Bump @michaelhaxhiu

Issue reproducible during KI retests

I was swamped with internal priorities last week, will fast track this in a few minutes  (sorry!)

I've found the root issue and I've added a fix in PR #4456 as I thought the issue was due to my changes in skintone. You can check https://github.com/Expensify/App/pull/4456#issuecomment-903328156 and commits https://github.com/Expensify/App/pull/4456/commits/4fcc4ec365a2c06f9588b2ffbf12e926900ca4de onward as proposal.

@michaelhaxhiu can we just hire @mananjadhav since he fixed this in another issue?

Yup :) https://www.upwork.com/jobs/~01ca8df11240eda9f2

Hired.

Triggered auto assignment to @timszot (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@timszot you'll notice @mananjadhav's already has a fix in the works via this PR https://github.com/Expensify/App/pull/4456

Issue reproducible during KI retests

Issue reproducible during KI retests

Quick summary:

This GH will be resolved via https://github.com/Expensify/App/pull/4456#issuecomment-903328156, which is assigned to @mananjadhav.
Right now we are awaiting Brandon Stites to review the PR (above), so the updates can be deployed.
Once that PR is closed, we can test to make sure flag emojis are working properly. At that point, we start the 7 day countdown for payment.

If any issues arise, @timszot will work with Manan on fixing them.

Update:
Earlier today, @mananjadhav updated the PR to address the Skintone picker not being visible https://github.com/Expensify/App/pull/4456#issuecomment-915743892.

Deployed to production on Sept 10. Payout due on Sept 17 if no more regressions.

Paid 🎬


[Bug]: json encoded Headers not parsed in infolist

What happened?
When receiving a webhook that has an incoming email payload from Sendgrid, the headers have a json encoded structured liek this:
{"accept-encoding":["gzip"],"content-type":["multipart\/form-data; boundary=xYzZY"],"content-length":["11087"],"user-agent":["Sendlib\/1.0"],"host":["example.com"]}
When trying to "view" the webhook, I'm getting the following error:
htmlspecialchars(): Argument #1 ($string) must be of type string, array given
In:
\vendor\filament\infolists\resources\views\components\key-value-entry.blade.php :42
How to reproduce the bug
Replace the content of any record in the webhook_calls table by:
{"accept-encoding":["gzip"],"content-type":["multipart\/form-data; boundary=xYzZY"],"content-length":["11087"],"user-agent":["Sendlib\/1.0"],"host":["example.com"]}
... and click on that record in the List Record page of the resource.
Package Version
Latest
PHP Version
8.2
Laravel Version
11
Which operating systems does with happen with?
No response
Notes
No response

@willcastillo Thank you for reporting!
Added this PR https://github.com/TappNetwork/filament-webhook-client/pull/6 to fix it.


When I Check The Downloaded Tracks Using This Program

Hi,
I used this command tidal-wave https://tidal.com/browse/track/330931239 --audio-format hires to download the tracks in hi-res, as the track is availabe from tidal in 24bit / 96 khz. And it got download fine.

But when I check the downloaded file in spectrum analyzer it shows nothing above 20 khz

& when I check it with tool from this website https://losslessaudiochecker.com/ it shows the file is upsampled

Any views on this

& when I check it with tool from this website https://losslessaudiochecker.com/ it shows the file is upsampled

As per this checking tool, it should show clean instead of upsampled. If the file is proper 24 bit / 96 khz as per this tool.

@Rajeshsahoo12 I don't have experience with either of the tools that you have mentioned here, unfortunately. When I downloaded the Lossless Audio Checker tool you link to, it doesn't seem to be GNU/Linux friendly:
c@darter-pro:~/projects/tidal-wave$ ~/tools/LAC '/home/c/Music/Anuv Jain/Husn [330931238] [2023]/01 - Husn [HiRes].flac'
Lossless Audio Checker 2.0.5
Copyright (c) 2012-2016 Julien Lacroix & Yann Prime
http://losslessaudiochecker.com
==================================================
File:   /home/c/Music/Anuv Jain/Husn [330931238] [2023]/01 - Husn [HiRes].flac
Result: WAVE header RIFF chunk: bad ID

Separately, I have no knowledge of how audio spectra and frequencies are calibrated or dissected: I only know to trust FFmpeg: if its ffprobe tool tells me that a track is 24-bit, 96 kHz, then I trust it :man_shrugging:
Input #0, flac, from '/home/c/Music/Anuv Jain/Husn [330931238] [2023]/01 - Husn [HiRes].flac':
  Metadata:
    ALBUM           : Husn
    album_artist    : Anuv Jain
    REPLAYGAIN_ALBUM_PEAK: 0.997684
    REPLAYGAIN_ALBUM_GAIN: -6.88
    ARTIST          : Anuv Jain
    ARTISTS         : Anuv Jain
    BARCODE         :<PHONE_NUMBER>7443
    COMMENT         : http://www.tidal.com/track/330931239
    COPYRIGHT       : ℗ 2023 Anuv Jain
    DATE            : 2023-12-01
    ISRC            : INUM72303081
    TITLE           : Husn
    REPLAYGAIN_TRACK_PEAK: 0.997684
    REPLAYGAIN_TRACK_GAIN: -6.88
    ENGINEER        : Angad Bahra
    PRODUCER        : Anuv Jain;Angad Bahra;Puna
    MIXER           : Angad Bahra
    COMPOSER        : Anuv Jain
    LYRICS          : [00:13.65] देखो-देखो, कैसी बातें यहाँ की, हैं साथ पर हैं साथ ना भी
                    : [00:20.08] क्या इतनी आसान हैं?
                    : [00:23.57]
                    : [00:26.37] देखो-देखो, जैसे मेरे इरादे, वैसे कहाँ तेरे यहाँ थे
                    : [00:32.64] हाँ, कितनी नादान मैं
                    : [00:38.17] मेरे हुस्न के इलावा कभी दिल भी माँग लो ना
                    : [00:44.57] हाय, पल में मैं पिघल जाऊँ, हाँ
                    : [00:48.94]
                    : [00:50.98] अब ऐसा ना करो कि दिल जुड़ ना पाए वापिस
                    : [00:57.13] तेरी बातों से बिख़र जाऊँ, हाँ
                    : [01:01.96]
                    : [01:04.23] माना, ज़माना है दीवाना, इसीलिए तूने ना जाना
                    : [01:10.58] तेरे लिए मैं काफ़ी हूँ
                    : [01:14.76]
                    : [01:16.87] देखो-देखो, ये ज़माने से थक कर, आते हो क्यूँ मासूम बन कर?
                    : [01:23.02] तेरे लिए मैं क्या ही हूँ?
                    : [01:26.65]
                    : [01:28.77] फ़िर आते क्यूँ यहाँ करने आँखों में हो बारिश?
                    : [01:35.12] अब आए तो ठहर जाओ ना
                    : [01:41.36] और पूछो ना ज़रा मेरे दिन के बारे में भी
                    : [01:47.50] बस इतने में सँभल जाऊँ, हाँ
                    : [01:53.57] हाँ, एक दिन कभी कोई
                    : [01:59.83] जब भी पढ़े कहानी तेरी
                    : [02:06.26] लगता मुझे, मेरे नाम का
                    : [02:12.56] ज़िक्र कहीं भी होगा नहीं
                    : [02:19.62] हाँ, मैं यहीं
                    : [02:25.19] मेरी ये आँखो में, आँखों में तो देखो
                    : [02:31.33] देखो, ये दिल का हाल क्या, होंठों से होता ना बयाँ
                    : [02:37.82] मेरी ये आँखो में, आँखों में तो देखो
                    : [02:44.17] कैसा नसीब है मेरा, मिलके भी ना मुझे मिला
                    : [02:50.42] मेरी ये आँखो में, आँखों में तो देखो
                    : [02:56.73] तेरी अधूरी सी वफ़ा, माँगूँ, मैं माँगूँ और ना
                    : [03:02.94] मेरी ये आँखो में, आँखों में तो देखो
                    : [03:08.24]
                    : [03:10.63] देखो-देखो, कैसी खींची लकीरें, चाहे भी दिल तो भी ना जीते
                    : [03:16.89] मैं इस दौड़ में नहीं
                    : [03:20.66]
                    : [03:23.09] देखो-देखो, कैसी बातें यहाँ की, बातें यही देखूँ जहाँ भी
                    : [03:29.59] मैं इस दौर से नहीं
                    : [03:31.77]
    DISCTOTAL       : 1
    DISC            : 1
    TRACKTOTAL      : 1
    track           : 1
  Duration: 00:03:37.89, start: 0.000000, bitrate: 2119 kb/s
  Stream #0:0: Audio: flac, 96000 Hz, stereo, s32 (24 bit)
    Side data:
      replaygain: track gain - -6.880000, track peak - 0.000023, album gain - -6.880000, album peak - 0.000023,
  Stream #0:1: Video: mjpeg (Progressive), yuvj444p(pc, bt470bg/unknown/unknown), 1280x1280 [SAR 72:72 DAR 1:1], 90k tbr, 90k tbn (attached pic)
    Metadata:
      comment         : Cover (front)
      title           : Album Cover

Perhaps this has to do with the change that occurred in TIDAL's service in June 2023? Before that, they used MQA exclusively for the highest-quality "HiRes" audio, but changed to fLaC for the HiRes audio offering. This might be where the "upsampling" came in?

Perhaps this has to do with the change that occurred in TIDAL's service in June 2023? Before that, they used MQA exclusively for the highest-quality "HiRes" audio, but changed to fLaC for the HiRes audio offering. This might be where the "upsampling" came in?

Okay. But this track was release in after that TIDAL service changes. As this track is in MAX quality. As per tidal what I understand is that MAX = MQA (anything above 16 bit 44.1 khz) & HI-RES FLAC (anything above 16 bit 44.1 khz)
But there are many tracks which I have downloaded using this program that lossless audio checker program has flagged as "CLEAN"
But this tracks many tracks of this artists behaves same way marked as "UPSAMPLED". Let it be anyway leave it. Your program is really good. Thanks for making such a good program.
A suggestion how to get rid of always getting new access token..? As, what I do now is to get fresh access token is clear android app info & data. Then re-login to get the fresh access token.
But can't we get refresh token anyhow..?

A suggestion how to get rid of always getting new access token..? As, what I do now is to get fresh access token is clear android app info & data. Then re-login to get the fresh access token.
But can't we get refresh token anyhow..?

To download hi-res & 360 reality audio we need access token from android device. As windows device access token does not work.
But this token expires in one day I think. Just need any way to refresh access token automatically.

A suggestion how to get rid of always getting new access token..? As, what I do now is to get fresh access token is clear android app info & data. Then re-login to get the fresh access token.
But can't we get refresh token anyhow..?

To download hi-res & 360 reality audio we need access token from android device. As windows device access token does not work.
But this token expires in one day I think. Just need any way to refresh access token automatically.

That's right, TIDAL doesn't provide HiRes or Atmos or 360 Reality Audio to desktop clients.
You don't have to log in or log out of the TIDAL app on Android for a new token; you just have to delete the okhttp directory in your Android file manager app, then start playing back whatever song or video in the app, and a new access token will have been written.
At the moment, I have no automated way to refresh the Android token, and this is out of my control. The reason that the Fire TV and Android Auto options have automated refresh tokens is that they are "appliance" devices; i.e., they don't have a standard input mechanism like a keyboard/mouse or a touchscreen and aren't meant to be interacted with like a desktop or a mobile device. Thus, for customer appeal, they need to be a "hands-off" device once logged in, or the users wouldn't put up with it.
Conversely, Android does have a username/password and software users on mobile phones are more forgiving when it comes to having to re-authenticate. You can read more about the OAuth 2.0 specification, and indeed I will add some information to the wiki about this, but short of finding a way to de-compile the Android APK and read through some Java, I don't believe there is a way to hijack the Android authentication system. I will post updates as I investigate, however!

That's right, TIDAL doesn't provide HiRes or Atmos or 360 Reality Audio to desktop clients.

Okay, that's may be the reason when I use access token from windows 10 PC in which I have installed TIDAL application from website manually. But when I search for tidal application on MS store, it is not available. And when I use access token from this PC, it does not get success.

You don't have to log in or log out of the TIDAL app on Android for a new token; you just have to delete the okhttp directory in your Android file manager app, then start playing back whatever song or video in the app, and a new access token will have been written.

Okay understood the procedure. Was doing very long steps. Thanks for the trick.

At the moment, I have no automated way to refresh the Android token, and this is out of my control. The reason that the Fire TV and Android Auto options have automated refresh tokens is that they are "appliance" devices; i.e., they don't have a standard input mechanism like a keyboard/mouse or a touchscreen and aren't meant to be interacted with like a desktop or a mobile device. Thus, for customer appeal, they need to be a "hands-off" device once logged in, or the users wouldn't put up with it.

Ohhhh okay. Can't we use android SDK & make a virtual device of any android device which will run in virtualization whenever we want. Which will give us the access token for android device but no need to for refresh. Basically it will act as a duplicate device such as android appliances devices.

At the moment, I have no automated way to refresh the Android token, and this is out of my control. The reason that the Fire TV and Android Auto options have automated refresh tokens is that they are "appliance" devices; i.e., they don't have a standard input mechanism like a keyboard/mouse or a touchscreen and aren't meant to be interacted with like a desktop or a mobile device. Thus, for customer appeal, they need to be a "hands-off" device once logged in, or the users wouldn't put up with it.

Ohhhh okay. Can't we use android SDK & make a virtual device of any android device which will run in virtualization whenever we want. Which will give us the access token for android device but no need to for refresh. Basically it will act as a duplicate device such as android appliances devices.

I am referring as this

At the moment, I have no automated way to refresh the Android token, and this is out of my control. The reason that the Fire TV and Android Auto options have automated refresh tokens is that they are "appliance" devices; i.e., they don't have a standard input mechanism like a keyboard/mouse or a touchscreen and aren't meant to be interacted with like a desktop or a mobile device. Thus, for customer appeal, they need to be a "hands-off" device once logged in, or the users wouldn't put up with it.

Ohhhh okay. Can't we use android SDK & make a virtual device of any android device which will run in virtualization whenever we want. Which will give us the access token for android device but no need to for refresh. Basically it will act as a duplicate device such as android appliances devices.

I am referring as this

Interesting, I had not seen something like this before. In terms of this project, I don't believe that integrating a virtual Android device in scope: I don't have experience with this kind of development, and so there is an entire class of bugs that would result...
Even in this situation, the virtual Android device would still need to run the TIDAL application, which means that you would still need to interact with it manually in order for it to produce logs, particularly the okhttp package logs which contain the bearer token. This is fundamentally the security model for TIDAL on mobile: requiring manual interaction (as far as I have discovered up to this point!).

At the moment, I have no automated way to refresh the Android token, and this is out of my control. The reason that the Fire TV and Android Auto options have automated refresh tokens is that they are "appliance" devices; i.e., they don't have a standard input mechanism like a keyboard/mouse or a touchscreen and aren't meant to be interacted with like a desktop or a mobile device. Thus, for customer appeal, they need to be a "hands-off" device once logged in, or the users wouldn't put up with it.

Ohhhh okay. Can't we use android SDK & make a virtual device of any android device which will run in virtualization whenever we want. Which will give us the access token for android device but no need to for refresh. Basically it will act as a duplicate device such as android appliances devices.

I am referring as this

Interesting, I had not seen something like this before. In terms of this project, I don't believe that integrating a virtual Android device in scope: I don't have experience with this kind of development, and so there is an entire class of bugs that would result...
Even in this situation, the virtual Android device would still need to run the TIDAL application, which means that you would still need to interact with it manually in order for it to produce logs, particularly the okhttp package logs which contain the bearer token. This is fundamentally the security model for TIDAL on mobile: requiring manual interaction (as far as I have discovered up to this point!).

Yeah I too have thought about it. But was thinking if it is possible at all to replicate the android device which is keyboard less.
If any how we replicate the android appliance for testing, but we need a device which is android running but not considered as fire tv coz fire tv access token will not work to extract HI-RES & 360 REALITY AUDIO.
Will ANDROID TV access token will auto refresh...?

At the moment, I have no automated way to refresh the Android token, and this is out of my control. The reason that the Fire TV and Android Auto options have automated refresh tokens is that they are "appliance" devices; i.e., they don't have a standard input mechanism like a keyboard/mouse or a touchscreen and aren't meant to be interacted with like a desktop or a mobile device. Thus, for customer appeal, they need to be a "hands-off" device once logged in, or the users wouldn't put up with it.

Ohhhh okay. Can't we use android SDK & make a virtual device of any android device which will run in virtualization whenever we want. Which will give us the access token for android device but no need to for refresh. Basically it will act as a duplicate device such as android appliances devices.

I am referring as this

Interesting, I had not seen something like this before. In terms of this project, I don't believe that integrating a virtual Android device in scope: I don't have experience with this kind of development, and so there is an entire class of bugs that would result...
Even in this situation, the virtual Android device would still need to run the TIDAL application, which means that you would still need to interact with it manually in order for it to produce logs, particularly the okhttp package logs which contain the bearer token. This is fundamentally the security model for TIDAL on mobile: requiring manual interaction (as far as I have discovered up to this point!).

Yeah I too have thought about it. But was thinking if it is possible at all to replicate the android device which is keyboard less.
If any how we replicate the android appliance for testing, but we need a device which is android running but not considered as fire tv coz fire tv access token will not work to extract HI-RES & 360 REALITY AUDIO.
Will ANDROID TV access token will auto refresh...?

Yes, the Fire TV client (which is Android) does have a mechanism to auto-refresh its access token when it has expired, because it uses OAuth 2.0.
In any situation with an Android device (emulated, physical, rooted appliance, etc.), there will still need to be manual input from the user. As far as I can figure from the logs and from other projects, it's not possible to automate interaction with TIDAL on Android, and this is done intentionally by the TIDAL developers.

Yes, the Fire TV client (which is Android) does have a mechanism to auto-refresh its access token when it has expired, because it uses OAuth 2.0.

Okay. If fire-tv access token can get refresh automatically. But then will have problem of not able to download HIRES & 360 REALITY AUDIO. As, it requires android / windows access token.

At the moment, I have no automated way to refresh the Android token, and this is out of my control. The reason that the Fire TV and Android Auto options have automated refresh tokens is that they are "appliance" devices; i.e., they don't have a standard input mechanism like a keyboard/mouse or a touchscreen and aren't meant to be interacted with like a desktop or a mobile device. Thus, for customer appeal, they need to be a "hands-off" device once logged in, or the users wouldn't put up with it.

Ohhhh okay. Can't we use android SDK & make a virtual device of any android device which will run in virtualization whenever we want. Which will give us the access token for android device but no need to for refresh. Basically it will act as a duplicate device such as android appliances devices.

I am referring as this

Interesting, I had not seen something like this before. In terms of this project, I don't believe that integrating a virtual Android device in scope: I don't have experience with this kind of development, and so there is an entire class of bugs that would result...
Even in this situation, the virtual Android device would still need to run the TIDAL application, which means that you would still need to interact with it manually in order for it to produce logs, particularly the okhttp package logs which contain the bearer token. This is fundamentally the security model for TIDAL on mobile: requiring manual interaction (as far as I have discovered up to this point!).

Yeah I too have thought about it. But was thinking if it is possible at all to replicate the android device which is keyboard less.
If any how we replicate the android appliance for testing, but we need a device which is android running but not considered as fire tv coz fire tv access token will not work to extract HI-RES & 360 REALITY AUDIO.
Will ANDROID TV access token will auto refresh...?

Yes, the Fire TV client (which is Android) does have a mechanism to auto-refresh its access token when it has expired, because it uses OAuth 2.0.
In any situation with an Android device (emulated, physical, rooted appliance, etc.), there will still need to be manual input from the user. As far as I can figure from the logs and from other projects, it's not possible to automate interaction with TIDAL on Android, and this is done intentionally by the TIDAL developers.

Ohhhh okay


when do you have plan to release v4 stable?

hi i'm wondering v4
i'm developing by v3 and it is good.
but i heard many issue is better than v3 , speically on mobile
so i'm very expecting..
but porting  need much time because our not small
and it's using many middleware
so i wanna know when will v4 stable release...?
thx  a lot..

http://www.html5gamedevs.com/topic/24525-big-pixijs-news-wonder-what-is-it/

very soon :)

done!


New Extension: InfoRenderer

A basic component that renders info descriptions at various widgets and does know a bit about the context they are used in.

different root strategies, e.g. inline-text below label or dialog info with icon button.
composable out of multiple special widgets, e.g. text, embed, image

Released with 0.3.0-alpha.5


Add ON UPDATE CASCADE to the sample ids FK

This adds the ON UPDATE CASCADE to the FK that points to the sample ids.
While developing the patch I noticed that the dynamic tables did not had the Foreign Key referencing the sample ids. The first part of the patch is adding that FK, while the second one is adding the ON UPDATE CASCADE to everything that references to sample id.
I've also updated the code so when the dynamic tables are created, the FK with ON UPDATE CASCADE constraint is also added to them.
@ElDeveloper @adamrp @wasade @squirrelo I would appreciate a review on this since this is blocking the update of an EMP study, and there is some people waiting on this to be able to update the study to EBI.

@antgonza this will need top be deployed in the live system. Do you have any notes on what are you doing to update the system, so I can do it once this is merged?
Thanks!

So if I'm reading this right, the FK will be tested by the create tests that currently exist, correct? Other than that question, :+1:

I do not have notes but I should be able to update the system once this is merged and create some ...

Coverage remained the same at 79.29% when pulling c75614f7c1b5e1c36a1e3e0e16cf60450e2c603e on josenavas:on-update-cascade-sid into 5ff115e2f2fd44b42449fa27b71a58cfe59afa9c on biocore:master.

@squirrelo I'm not understanding your question...

Are there tests that make sure the foreign key is created and valid?

There is a test that checks that the SQL contains the creation of the FK.

This looks good to me :+1:

:+1:


Use parameter for involved_obj["apiVersion"]

I noticed that the apiVersion for the involved object had been hard coded to v1; I found that for CR's where the ApiVersion was different I would get an error thrown on line 282 as 281 returned true but there was no .get attribute on the resource list.
My python skills aren't that great, so I'm not sure how 280 needs to be modified to fix the test though; testing the attribute exists seems a bit clunky though.

@MrBasset actually involved_obj.get("apiVersion", "v1") means get involved_obj["apiVersion"] and fallback to "v1" if it's not defined. See the .get() function of python dicts.


Add new matplotlib notebook

Another section of matplotlib content, originally put together by @anissa111, with some additional narration/theme matching.
Towards #167

@michaelavs could you take a look at this soon?

Hi @mgrover1 , I added a bunch of comments on reviewnb.
I'm glad I read through this because I learned about subplot_mosaic for the first time! That's a feature I've been waiting for.

Hi @mgrover,
Sorry for any delays caused by me, I didn't realize I was listed as a reviewer on this PR!
I went through on reviewnb and added a couple comments, but I think things look good overall!

@mgrover1 I can't find my comments anywhere, nor those from @michaelavs. Seems that ReviewNB may have eaten them for breakfast. I will just start over and do a new review.

@mgrover1 I can't find my comments anywhere, nor those from @michaelavs. Seems that ReviewNB may have eaten them for breakfast. I will just start over and do a new review.

Actually now I CAN see our comments at https://app.reviewnb.com/ProjectPythia/pythia-foundations/blob/advanced_matplotlib/core/matplotlib/additional-topics2.ipynb/
I'm not sure what's going on, or why the comments never migrated over to this GitHub discussion.

I'm gonna see what I can do to get this content merge-able


How to link to an existing workspace during create log analytics workspace?

When I create an log an log analytics workspace, I select Link existing instead of create new, but there is a message occurs: It looks like you have no workspaces to link.
I already have a workspace, I don't know how to link to it. Could you please provide some details how to do it? thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03fd0e0e-c5d8-b6d0-bd7b-07539a5bd31f
Version Independent ID: b323a14a-c502-8b32-c261-fb433ac75a05
Content: Create a Log Analytics workspace in the Azure Portal
Content Source: articles/azure-monitor/learn/quick-create-workspace.md
Service: log-analytics
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@imeya Thank you for your feedback . We will investigate and update further.

@MGoedtel Any insights on this please ?

@imeya & @shashishailaj & @KrishnaG-MSFT - This doesn't make sense.  The purpose of the create workspace function is to create a new workspace, not link to one that already exists.  If you already have a workspace that you intend on using, then there is no need to perform this action unless you want to create a new workspace intended to support another purpose.  #please-close.

@mgblythe, if you're correct, then it's a bug on the ui(on the ui, when create a workspace, there is an option for linking to an existing workspace)? please help confirm, thanks.

@imeya - I assume your last comment was for @MGoedtel

@mgblythe , ah , thank you. I made a mistake.

Currently all workspaces are associated to subscriptions already and you shouldn’t be required to link it. The only function ‘Linked Existing’ radio performs now is in workspace recovery. When workspace is accidentally deleted and customer approaches Microsoft support to recover it. Once recovered by support, customer needs to select ‘Linked Existing’ and select the recovered workspace that shows up in that list and link it back to its original subscription. This is an intermediate solution which would be replaced by self-service recovery solution in future.
Closing this issue for now. If there are further questions regarding this matter or feedback on the documentation, please reply and we will gladly continue the discussion.

Hello. It deserves to be documented as this option is not mentioned anywhere in official documentation, and as a user I was looking for the description of this option


Fix path for Windows use

Coverage remained the same at 52.381% when pulling a572513c1588ea8af6bb3374af9ff866c259587d on develop into 436c2a5b0219969da03b10901c0a999d51cb96a2 on master.