[Bug]: Sidebar injection error

Reproduction
in description
Describe the bug
Injection error on initializing Sidebar component, wrapped in my own component.
A component looks like this
<script setup lang="ts">
import { Button } from '@/components/ui/button'
import { Sidebar, SidebarContent, SidebarTrigger } from '@/components/ui/sidebar'
import { SidebarIcon } from 'lucide-vue-next'
</script>
<template>
    <div>
        <Sidebar>
            <SidebarTrigger>
                <Button variant="outline" size="icon"><SidebarIcon class="w-4 h-4" /></Button>
            </SidebarTrigger>
            <SidebarContent></SidebarContent>
        </Sidebar>
    </div>
</template>

<style scoped></style>

System Info
System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M2
    Memory: 684.06 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 8.15.5 - ~/.nvm/versions/node/v20.11.1/bin/pnpm
    bun: 1.1.27 - ~/.bun/bin/bun
  Browsers:
    Chrome: 130.0.6723.70
    Safari: 17.5
  npmPackages:
    @vueuse/core: ^10.11.1 => 10.11.1
    radix-vue: ^1.9.8 => 1.9.8
    vue: ^3.3.4 => 3.5.12

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

wrong implementation by me

@evgeshaDoc  Can you please tell me what you changed ?
I am facing the same issue and I can't find what I'm doing wrong...

same here

@evgeshaDoc Can you please tell me what you changed ?
I am facing the same issue and I can't find what I'm doing wrong...

But now I am facing the style issues,
it seems all the text-sidebar-foreground css class not working.
I've tried add sidebar css variables to index.css
but not working,
any clues?

@LuckyStar04 @Mirinael
try to use it like it is used here basically all you need is wrap your sidebar component with SidebarProvider

Thanks a lot! But now I am facing the style issues, it seems all the text-sidebar-foreground css class not working. I've tried add sidebar css variables to index.css but not working, any clues?

I had the same issue.
Add this to your tailwind.config.js sidebar: {           'DEFAULT': 'hsl(var(--sidebar-background))',           'foreground': 'hsl(var(--sidebar-foreground))',           'primary': 'hsl(var(--sidebar-primary))',           'primary-foreground': 'hsl(var(--sidebar-primary-foreground))',           'accent': 'hsl(var(--sidebar-accent))',           'accent-foreground': 'hsl(var(--sidebar-accent-foreground))',           'border': 'hsl(var(--sidebar-border))',           'ring': 'hsl(var(--sidebar-ring))',         },.
Also check this: https://github.com/unovue/shadcn-vue/blob/e0d4980e31161482e94852ddc2a1277c68a86555/apps/www/tailwind.config.js


[modify] installer compatibility

Coverage remained the same at 82.936% when pulling 2ea4cdee9297f6914d61a6afca010c47f252b212 on sunny4381:unicorn-centos7 into 560247e273765395f8c7f9eb842c8bbe4c1c216d on shirasagi:master.


feat(yard): add input

Hm, there is some bug when you first change any knob (value disappears), works afterwards. Will look into that.

looks great! the only thing I couldn't make work is the clearable prop - if I click it, it does not clear the input

Yea, it's because the component is stateless with a set value (you can't change the input value directly either). Not sure what to do about it.
In a theory, we could add some state handling into the code snippet but then it would be competing with the yard's state and that needs to be somehow reconciled. This could get pretty complex. We can think about it more.


Use accelerometer crate's Accelerometer trait and I16x3/F32x3

Impls the accelerometer crate's Accelerometer trait for reading accelerometer data, and imports the I16x3 and F32x3 types from it as well (vicariously from micromath):
https://github.com/NeoBirth/accelerometer.rs
This allows for generic reuse of accelerometer data consuming crates which work across various accelerometer drivers.

Hmm, a strange build failure on 1.31.0:
https://travis-ci.com/tarcieri/kxcj9-rs/jobs/199430392
I'll take a look...

Thank you for this proposal @tarcieri. However, at the moment I would not like to add more dependencies to the driver. This can change in the future of course.

Ok, thanks for looking!


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.103

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.103


Fixes the paginator display of blogs

Pages update auto built from graphscope/web, commit graphscope/web@1b2f390

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


UUID needed?

Why do we have UUID in openapi-common?
Why isn't it configured as type: string / format: uuid ?
Is this really needed for standardizing on exclusively lowercase UUID values?
The annoyance is that it generates java.lang.String instead of java.util.UUID unless you configure an import mapper.

I guess we'd have to balance between ease of use, varied support of the format and risk of logic errors.
Support of uuid format varies
format: uuid isn't a standard OpenAPI 3.0 format:
https://spec.openapis.org/oas/v3.0.3#data-types
Formats such as "email", "uuid", and so on, MAY be used even though undefined by this specification.
But support has been added to OpenAPI 3.1 (via newer JSON Schema version), though it makes the whole format validation optional.
At the time when we defined UUID in openapi-common, versions of openapi-generator or swagger-codegen didn't map it to java.util.UUID. The javascript or typescript generators don't have a mapping for it either.
swagger-request-validator does seem to support it.
risk on logic errors
e.g. DB lookup in a varchar column may fail inadvertedly due to casing mismatch, or by java/javascript string comparison (already encountered this in the wild).
https://www.belgif.be/specification/rest/api-guide/#rule-id-design
Each identifier MUST be represented by only one single string value, so that a string equality check can be used to test if two identifiers are identical. This means that capitalization, whitespace or leading zeroes are significant.
ISO/RFC Standard
https://datatracker.ietf.org/doc/html/rfc4122#section-3
The hexadecimal values "a" through "f" are output as
lower case characters and are case insensitive on input.
https://www.iso.org/obp/ui/fr/#iso:std:iso-iec:9834:-8:ed-3:v1:en
6.5.4 Software generating the hexadecimal representation of a UUID shall not use upper case letters. NOTE – It is recommended that the hexadecimal representation used in all human-readable formats be restricted to lower-case letters. Software processing this representation is, however, required to accept both upper and lower case letters as specified in 6.5.2.
For Java, the UUID::toString() javadoc  allows both upper- and lowercase so its not fully compliant with the ISO/RFC.
We could add format: uuid to the existing UUID type of openapi-common, combined with the pattern enforcing lowercase, if we could trust UUID implementations to generate lowercase (compliant with ISO, stricter then javadoc UUID).


How to implement endless scrolling?

Firstly, awesome library! Made standard pagination trivial - great docs too. Much easier to use than Backbone.Paginate.
At the moment I am using setPageSize on a scroll event. This requires a re-render of the entire collection which is sub-optimal.
Is there a way I can call getNextPage() and have the results trigger add events on my Collection to make the endless scrolling experience (a la Facebook news feed) better?
So far I have:
    # Scrolling.
    @isLoading = false
    buffer = 200
    $window = $(window)
    $window.scroll =>
      console.log 'offset', @$el, @$el.offset()

      # Before the bottom of the viewport...
      bottomOfViewport = $window.scrollTop() + $window.height()
      # passes the bottom of the list of elements minus a buffer...
      bottomOfCollectionView = @$el.offset().top + @$el.height() - buffer
      # we should re-render.

      if not @isLoading and bottomOfViewport > bottomOfCollectionView
        console.log 'loading more!!!!'
        currentPageSize = app.collections.props.state.pageSize
        @isLoading = true
        app.collections.props.setPageSize(currentPageSize + 10).done =>
          @isLoading = false

@josx what mode did you use: server, client or infinite? I have just used

collection.getNextPage({remove: false});

in the infinite mode I did not get the expected behavior.


ci(brigade.js): run test GH Checks for master branch

This removes the if not master check in runSuite so that Brigade runs the same test checks on master (and, thus, updates this branch's status at https://github.com/deislabs/duffle/branches properly).

@glyn agreed.  This is mostly cosmetic.


feat: port Archive.Wiedijk100Theorems.BallotProblem

todo:

[x] counted_succ_succ ran into errors with List

I did a quick fix for the list stuff in counted_succ_succ, now not using any deprecated theorems, but it is slightly verbose, so could need some golf.

bors merge


Send error message response on invalid ph num

Currently you'll receive a 500 error on the client if you use a fake phone number. The server logs look like this:
problem signing user up: task failed: "twilio service": addNumberToConversation: createServiceConversationParticipant: Status: 400 - ApiError 50407: Invalid messaging binding address (null) More info: https://www.twilio.com/docs/errors/50407
Signup:
"Peter"
"Barnum"
<EMAIL_ADDRESS>"303-123-9876"
"05 Dec 22 12:00 CST"
"ia6cThnvPZ6MygTgf"

"303-123-9876" is a made up number. Let's show a useful error to the end user.

We could possibly return a specific error type here, then look for it here and send a 400 code back.

https://greenlight.operationspark.org/admin/tools/signups?sessionId=5SXB9h6sfaR4asmXh


A new implementation of Piranha that eases onboarding of new languages and APIs

This PR implements a generic Piranha that makes it easy to onboard new feature flag systems and new languages. It leverages tree-sitter infrastructure to abstract away language and API specific transformations to rules composed Tree-sitter queries.
This PR contains

Logic for applying chains of rules
rules for cleaning up java programs.
Two sample feature flag systems - in test-resources/java.
Demo
Please refer to Readme.md for more details.

Addressed the comments. Merging into main.


Failed to connect Puppeteer to existing Firefox instance run by web-ext

Hi,
At @treosh we are working on analyzing extensions (ext) impact on real user performance.
We try to install extensions for Firefox (FF) and handle browser with Puppeteer (PP) to do measurements and other stuff, but struggling with some sort of issues.
Tell us about your environment:

Puppeteer version: "puppeteer-firefox": "^0.5.0"

Platform / OS version: macOS Mojave 10.14.3

Node.js version: v11.1.0

What steps will reproduce the problem?
There are several cases we tried and all of them based on using web-ext library for installing ext for FF.

Case 1: Connect FF instance run by webExt to PP
Code simple:
    webExt.util.logger.consoleStream.makeVerbose();

    extensionRunners = await webExt.cmd.run({
      sourceDir: extPath,
      // comment if connect to default FF
      firefox: PP_FF.executablePath(),
    }, {
      // These are non CLI related options for each function.
      // You need to specify this one so that your NodeJS application
      // can continue running after web-ext is finished.
      shouldExitProgram: false,
    })

    const extensionRunner = extensionRunners.extensionRunners[0]

    const browserWSEndpoint = `ws://<IP_ADDRESS>:${extensionRunner.remoteFirefox.client.client.client.remotePort}`
    browser = await PP_FF.connect({
      browserWSEndpoint,
    })

Error:
Error: Parse Error
  at Socket.socketOnData (_http_client.js:449:20)
  at Socket.emit (events.js:182:13)
  at addChunk (_stream_readable.js:283:12)
  at readableAddChunk (_stream_readable.js:264:11)
  at Socket.Readable.push (_stream_readable.js:219:10)
  at TCP.onStreamRead (internal/stream_base_commons.js:122:17) bytesParsed: 0, code: 'HPE_INVALID_CONSTANT' }

Fairly saing it crashes in PP helper line 112, but after commenting it - error HPE_INVALID_CONSTANT can be seen.

Case 2: Connect webExt to FF instance run by PP

install web ext from built fork https://github.com/denar90/web-ext-firefox-port instead of web-ext original

Code simple:
    browser = await PP_FF.launch({
      headless: false,
    })

    const wsEndpoint = new URL(browser.wsEndpoint())

    webExt.util.logger.consoleStream.makeVerbose();

    extensionRunners = await webExt.cmd.run({
      sourceDir: extPath,
      firefoxPort: wsEndpoint.port,
    }, {
      // These are non CLI related options for each function.
      // You need to specify this one so that your NodeJS application
      // can continue running after web-ext is finished.
      shouldExitProgram: false,
    })

Error:
Browser is connected but never install extension
Log from console:
[firefox/remote.js][debug] Connecting to the remote Firefox debugger
[firefox/remote.js][debug] Connecting to Firefox on port 8000
[firefox/remote.js][debug] Connected to the remote Firefox debugger on port 8000
...nothing happens...

Case 3 (dummy one):  Connect FF instance run by webExt to PP FF instance via webExt connect
    browser = await PP_FF.launch({
      headless: false,
    })

    webExt.util.logger.consoleStream.makeVerbose();

    extensionRunners = await webExt.cmd.run({
      sourceDir: extPath,
      firefox: PP_FF.executablePath(),
    }, {
      // These are non CLI related options for each function.
      // You need to specify this one so that your NodeJS application
      // can continue running after web-ext is finished.
      shouldExitProgram: false,
    })

    const extensionRunner = extensionRunners.extensionRunners[0]
    const connect = (port, host) => {
      return new Promise(resolve => {
        extensionRunner.remoteFirefox.client.connect(port, host, resolve);
      });
    }

    const wsEndpoint = new URL(browser.wsEndpoint())

    await connect(wsEndpoint.port, wsEndpoint.hostname)

Error:
Extension doesn't have influence on perf of page run in PP_FF browser because it's installed in FF run by web-ext.

Will be super cool if folks from @googlechrome and @mozilla can find some time and help us with solving this problem, hence we will be able to audit impact of Firefox extensions on UX.
Thanks)

@denar90 ok I see what's going on. There's some confusion related to remote protocols and what tool uses what when connects.

IIRC the web-ext uses firefox's RDP protocol that has a hook to install an extension
puppeteer-firefox uses a "juggler" - a new CDP-like protocol that currently exists only in our fork

So what you want is:

use web-ext to launch the firefox bundled with puppeteer-firefox
when launching the firefox, pass a -juggler 1234 flag to open juggler websocket on port 1234
once the browser is launched, connect pptr-firefox to it:

puppeteerFirefox.connect({
  browserWSEndpoint: 'ws://localhost:1234',
})

One issue I got stuck with is that web-ext run doesn't let me specify cli flags for the firefox. It shouldn't be hard to modify it though.
Let me know how it goes.

@aslushnikov thank you very much! It works like a charm 💃
I opened PR to add browser flags support for web-ext :)


Gitleaks scan does not report basic keys i have added to test the scan

hi all, i am trying to test basic gitleaks function , so i hardcoded some keys in a .tfvar file, but it does not show that in the report at all.
what I am doing,

I am using the gitleaks on Azure devops , so I installed the plugin and I am running on self hosted agents.

task: Gitleaks@1
inputs:
scanfolder: '$(Agent.BuildDirectory)/adle-ado-pipeline-iac/'
arguments: '--debug --verbose'

I have hardcoded some dummy keys in a .tfvar file and I was expecting the scan to report them but it doesn't, please see the attached files, please let me know what am I doing wrong. i want to setup Gitleaks as a standard in my organization.

@am251224 Gitleaks works by detecting secrets based off regular expressions so if the secrets don't match they won't be picked up. The regex can be found here
You could try using AKIAIO5FODNN7EXAMPL2 as your fake aws key as this fits the regex.

@asaini11  - you are right , now it shows as an issue in the report.
i have on more question though, is there a way to exempt something from the report. what I mean is lets say i have to keep some key value in my file and i don't want it to be reported, like false positive or something and then it should not be picked again in future scans.

@am251224 you may specify your own config. Please see the examples here. Example 4 will probably be what you are looking for which can be found here

This is great, Thanks


Installing plugins not initialises composer correctly, so that dev st…

…ability plugins can be installed by default

This addresses https://github.com/garethmidwood/cdev/issues/54


Add wheel in dependencies

Required for building paho-mqtt:
Using legacy 'setup.py install' for paho-mqtt, since package 'wheel' is not installed.

Merged commit that fixes this from devel into master


Fail to set Session Parameter Container fails with ORA-65015: missing or invalid container name

I am trying to set container using "AddSessionParam" and it fails with message below

ORA-65015: missing or invalid container name

"AddSessionParam" code is using single quotes around the value but for containers this doesn't work.
SQL> alter session set CONTAINER='PDBTEST';
alter session set CONTAINER='PDB10'
                            *
ERROR at line 1:
ORA-65015: missing or invalid container name

This works
SQL> alter session set CONTAINER=PDBTEST;

Session altered.

Can you please provide a fix for this?

which version are you using?


Contributor self-nomination for maass-hamburg

Background
The TSC Project Roles defines the main roles for the Zephyr Project, including
Maintainer, Collaborator, and Contributor.
By default anyone that contributes code or documentation is a Contributor, but
with the lowest GitHub Permission Level of Read. For example, Contributors
with Read permission do not have the permission to add reviewers to a pull
request.
Use this template to nominate a GitHub user for the Contributor role with
Triage permission level, which allows the user to add reviewers to a pull
request and be added as a reviewer by other users.
Nomination
GitHub User
Provide the following information about the GitHub user:

Full Name: Fin Maaß
GitHub username: maass-hamburg
Organization (optional): Vogl Electronic GmbH

Supporting Documents
Add links to 3-5 GitHub pull requests, in the Zephyr project, authored or
reviewed by the GitHub user that demonstrate the user's dedication to the
Zephyr project.
#68767
#69036
#69328
#69476

Hi @maass-hamburg, it is not clear from the description, but what networking area you would like to be a contributor, DHCPv4 or something else?

@jukkar dhcpv4 sound goog

https://github.com/zephyrproject-rtos/zephyr/invitations


Don't verify that forcing and routing files exist during initialization

Changes

Dont check that files exist during initialization of Forcing and Routing objects. This is consistent with how formulations handle files.

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[ ] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

ngen.config's patch version should be bumped before we merge this. Depending on the merge order of this and #75, I may need to rebase, bump the patch version, and force push.


Moved the default local and global store to new root

This is required in order to provide a clean switchover.
Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

LGTM


Unable to get the NPC Cars get spawned.

I want to create a scenario where there is only one NPC car in the entire MAP and the Player CAR spawns just behind it. Later I plant to write a code for making the Player CAR follow the NPC.
For doing this I duplicated the Town01 Map of Carla in UE4 Editor and Removed all the PlayerStarts except 1. Then I duplicated the PlayerStart and placed it in front of the current one. This is all the change I did in the Town01 Map. Now I start the simulator by hitting the play button, but only the player car gets spawned and no NPC cars get spawned.
Later I put 6 more PlayerStarts but still NPC Cars won't spawn. Am I doing something wrong? Do I understand correctly that the NPC Cars also spawn in the PlayerStart locations?

Also I notice that the Player vehicle always spawns in the Latest PlayerStart Location. Why is that?

Hi @YashBansod,
Yes, the NPC vehicles also spawn on PlayerStarts, but if there is not enough PlayerStarts to spawn the requested amount of NPC vehicles, none is spawned. I see this is not indeed the most intuitive.
You should change you CarlaSettings NumberOfVehicles=2. Also make sure that there is enough space between PlayerStarts to spawn the vehicle.
Sorry, the vehicle spawner is a bit buggy right now, I'm going to add an issue on this to our backlog.

@nsubiron thanks for the reply. I am unable to find where I should set the NumberOfVehicles. I am not running a Server Client Session, I am just running the simulator from the UE4 Editor.
Also, Is there a reason that the player always spawns at the latest created PlayerStart?

Thanks a lot @nsubiron. This worked. I know that you guys are working on developing the documentation for Carla and in fact, if I were to use just the precompiled version of Carla, the documentation is more than enough to help you get started. But really the documentation related to modifying or even understanding Carla in the UE4 Editor is scarce. It would be a great help if you could create a small documentation explaining the basic structure of Carla in UE4 Editor and some basic overview. This can just be a video that you guys can make of a screen capture while explaining the structure of Carla and how to make minor modifications.


engine: more gracefully handle equal time values

Hello @landism, @jazzdan,
Please review the following commits I made in branch nicks/ch4893/windows:
264039ba50f6cbe66765efcdd5d0e25b605df70a (2020-05-04 23:28:46 -0400)
engine: more gracefully handle equal time values
Fixes issues on Windows, where the clocks are not strictly monotonic,
and two consecutive time.Now() calls might return the same value
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

(though this PR is also a really a big shout-out to how good the time library is in Go, and how well it hooks into Unix time primitives ... as well as how good our tests are at catching these subtle timing issues)


Bluetooth Classic

Hi,
Is there any ETA for Bluetooth Classic? There's no way to use it, since we don't even have the closed-source lib for the RF module.
Would it be possible to get an estimate, or maybe the closed source lib and it's headers in order to develop a solution ourselves?
Thanks,
Iscle

@Iscle I asked this question in this issue: https://github.com/bouffalolab/bouffalo_sdk/issues/148#issuecomment-1560992303
it seems that it will be added someday, but no ETA. If you plan to use this chip for business, you might rather try to reach out Bouffalo officially.


Reorganizing project

Hey!
I was thinking about taking wottactics back into alive mode. Would you like to merge this stuff into my fork?

Hey Niko9911,
where do I find your fork?
Please note: My updated are mostly Mechwarrior Online related. Adding the Docker stuff was simple and integrating it in your fork might be a walk in the park.
Cheers, Ralph

Well, the thing little escalated and the work decided to put down before it even started...
We have new project to replace current wottactic. If you are interested, check out https://gametactic.eu


feat: allow custom method names

This PR allows users to pass custom method names to be invoked, e.g. TestJob::class@customMethod.

Could you expand the PR desc to include a full example?

The idea was to pass "TestJob@run" but I noted that I can also pass an array using the same.


Tailwind

Please add TailwindCss to the list.
https://tailwindcss.com/

I think this feel more suitable to be added to awesome-css. What do you think?


Add Concepts Underlying the Cloud Controller Manager translation

Add Concepts Underlying the Cloud Controller Manager translation. (https://kubernetes.io/docs/concepts/architecture/cloud-controller/).
Fix some small translation.

This change is

Please assign it to Chinese maintainers, thank you.

@zhangxiaoyu-zidif
@markthink


Cannot connect to WIFI if I first enter wrong password and after that try with correct one

I use next code to connect to WIFI
wifi.findAndConnect(ssid, password, (found) => {
  if (found) {
    console.log("wifi is in range");
  } else {
    console.log("wifi is not in range");
  }
});

First i tried with wrong password and I see message "wifi is in range"
But I never connected of course and this is expected result.
After that i tried to enter correct password and I see same message but i never connected to wifi which is unexpected result.
If I enter correct password in the very beginning when i open my app it works correctly.
Do you have any idea why I cannot connect to wifi after first try with wrong password and after that with correct one

@anton-shumanski
This is expected behavior I think. First time when you connect to some network with the wrong password this module create a native config with your wrong password then second connection this module uses already created the config. "wi-fi in range" been called due to this function (findAndConnect) return just simple result is there such wi-fi network or not, independently of your password. If there is such network then ok, will be returned TRUE.

Ok so in that case how I can set right password and connect to wifi?

@anton-shumanski
Just use wifi.isRemoveWifiNetwork() as it described in readme

@gigby I already tested even before I open the issue. It does not work.
I do not know how to detect that the password is wrong and just after 30 sec I check if I am connected to wifi and if I am not I just execute isRemoveWifiNetwork and after that in the callback I try to connect again with the correct password. Even using that approach I cannot connect successfully.


Migrate to tsup, Fix Types Exports

Description
Reports of builds failing due to the package not exporting type files.
This migrates to tsup to make building the package easier (i hope).
It also tries to provide more TS coverage as well as export types for easier usage.
Issue Ticket Number
Fixes #130

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Fix or improve the documentation
[ ] This change requires a documentation update

Checklist

[ ] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[ ] I have created an issue ticket for this PR
[ ] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] I have performed a self-review of my own code
[ ] I have run tests locally to ensure they all pass
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes needed to the documentation

not totally sure how to publish a beta branch or something with this, but testing locally seems like it works as expected

It looks great, awesome!


[Bug] Kong failures when Ingress has no Path

Summary
If your Ingress resources do not specify an explicit Path under spec.rules.http.paths the Kong configuration call from the Kubernetes Ingress Controller fails.
This is something I encountered when installing Jenkins X as their Ingress generating controller (https://github.com/jenkins-x/exposecontroller) does not add path: / by default.
Kong Ingress controller version
0.4.0
Kong or Kong Enterprise version
1.1.2
Kubernetes version
1.10.11
Environment
Kops on AWS
What happened
Getting the following error message spammed for multiple Ingress and non-ingress resources in my cluster:
E0528 21:44:53.194218       5 controller.go:117] unexpected failure updating Kong configuration:
1 errors occured:
    while processing event: {Create} failed: 400 Bad Request {"message":"schema violation (paths.1: length must be at least 1)","name":"schema violation","fields":{"paths":["length must be at least 1"]},"code":2}

Expected behvaior
The Ingress Controller should configure my Ingress in Kong. According to K8s spec the Ingress resource doesn't require an explicit Path, see example: https://kubernetes.io/docs/concepts/services-networking/ingress/#name-based-virtual-hosting
Steps To Reproduce

Install Kong ingress controller 0.4.0 with Kong 1.1.2
Create an example ingress resource with no explicit Path configured (for example:

apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: name-virtual-host-ingress
spec:
  rules:
  - host: foo.bar.com
    http:
      paths:
      - backend:
          serviceName: service1
          servicePort: 80

Lots of errors in the Ingress controller and no services registered in Kong

I am experiencing the same thing on k8s 1.11.6

I can confirm this bug. Expect it to be fixed with the upcoming 0.5.0 version.


[CUR-301] Added Avo tracking to curric pages

Description

Added the following tracking events:

Unit Tab

Curriculum Thread Highlighted
Year Group Selected

Unit Modal

Unit modal is opened

Subject Phase Picker

Curriculum Visualiser is accessed through subject phase picker

How to test

Go to https://deploy-preview-2039--oak-web-application.netlify.thenational.academy
Click on the curriculum visualiser
You should see no change in behaviour to any of the above events
If using the console, you should be able to see events sent through like below

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.290.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Helium wallet option removed from Kamino finance link.

I was able to connect my Helium wallet to kamino finance through the Helium black app(IOS 2.0.6) After I upgraded the Helium app(IOS 2.0.7) the Helium wallet option is no longer there. I am not able to connect through the app to be able to see what I deposited.All my other links still have option to connect to Helium wallet such as sol-incinerator.

This can be closed. The issue was fixed


Parens in Logical Rules

We fixed Arithmetic rules (#56), but not logical ones!

Fixed in 77c749d7514c4f0be07a3dc11a9676a0a8858a93.


ST

Do you have this theme for sublime?

No sorry I don't but the Facebook theme is available online for Sublime anyhow, this is where I got the idea from for this.


Force onchange to trigger when a color picker is changed.

In item-color added .change() to trigger an onchange event when a new color is chosen for a color picker.  This allows an event to fire on a color picker change, such as calling a re-draw canvas function for live color theme previews.

Please make changes to the source files, not the generated dist/ files.

Slate has been superseded by Clay.


Don't replace characters invalid on Windows when --windows-filenames is not specified

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

Currently, yt-dlp replaces characters that are invalid on Windows with Unicode alternatives (e.g., : to ：, " to ＂), even on non-Windows operating systems, and, specifically, when --no-windows-filenames is passed, despite the option implying the opposite.
This fixes it by only performing those replacements if --windows-filenames is explicitly specified.
Fixes #4547
Template

Before submitting a pull request make sure you have:

[X] At least skimmed through contributing guidelines including yt-dlp coding conventions
[X] Searched the bugtracker for similar pull requests
[X] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[X] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[X] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at 5982686
Summary
🧪🐞📥

This pull request adds a new option windowsfilenames to control whether to use Windows filename restrictions or not when sanitizing filenames for output templates and request dumps. It modifies the sanitize_filename function and its callers to accept and pass this option. It also updates the tests for the sanitize_filename function to cover both cases.

We are the masters of our files
We choose the rules that we apply
sanitize_filename gives us power
To defy the Windows empire

Walkthrough

Add use_win_filenames parameter to sanitize_filename function to control Windows filename restrictions (link, link, link)
Pass windowsfilenames parameter from YoutubeDL class to sanitize_filename function in prepare_outtmpl method to allow user specification of filename restrictions (link)
Pass windowsfilenames parameter from InfoExtractor class to sanitize_filename function in _request_dump_filename method to enable filename restrictions for HTTP request dumps (link)
Update test cases for sanitize_filename function in test/test_utils.py to check both cases of use_win_filenames parameter (link)

Seeing as the the failing tests (the ones mentioning ab:cd) in test_YoutubeDL.py assume replacement behavior that would occur if --windows-filenames was specified, is it okay if I modify those tests as well?
A few other tests are erroring with ab#cd and ab\u441acd, though, so I still have to fix those as well.

I see now that not replacing unless an option is explicitly specified, even on the operating system that requires it - Windows - is a rather bad idea. Until I switch this to not replace only if --no-windows-filenames is specified, I'll be closing this pull request.

Superseeded by https://github.com/yt-dlp/yt-dlp/pull/9591


setPins() for rx/tx and cs/irq?

I am using an MCP2515 on an ESP32 and writing code in PlatformIO/VSCode with the Arduino framework.   I need to set both rx/tx and cs/irq  from the defaults.  I see in the API.md that there are two calls to setPins() for both pairs of pins.  How does the library know which set of pins I am defining?

That depends on whether you're targetting ESP32 or AVR architecture.

I also didn't quite understand the function:
void MCP2515Class::setPins(int cs, int irq)
{
_csPin = cs;
_intPin = irq;
}

https://github.com/sandeepmistry/arduino-CAN/blob/b514e6b8596126a8f94f226b9906455393efd3a2/src/MCP2515.cpp#L396

According to the code CAN.setPins(PA4, -1); there is an explicit installation of the pin of the CS and INT and nothing else, the platform has nothing to do with it.

I also didn't quite understand the function:
void MCP2515Class::setPins(int cs, int irq)
{
_csPin = cs;
_intPin = irq;
}

https://github.com/sandeepmistry/arduino-CAN/blob/b514e6b8596126a8f94f226b9906455393efd3a2/src/MCP2515.cpp#L396

According to the code CAN.setPins(PA4, -1); there is an explicit installation of the pin of the CS and INT and nothing else, the platform has nothing to do with it.

Look at the top of the header file... the MCP2515 class can't be used on ESP32: https://github.com/sandeepmistry/arduino-CAN/blob/b514e6b8596126a8f94f226b9906455393efd3a2/src/MCP2515.h#L4
And the SJA1000 can only be used on ESP32 hardware: https://github.com/sandeepmistry/arduino-CAN/blob/b514e6b8596126a8f94f226b9906455393efd3a2/src/ESP32SJA1000.h#L4
In other words, platform has everything to do with it ;)


Refresh page on change location hash in faq-results

Due to issue #2981 I'm creating this PR. The problem is that on faq-results page we don't navigate, content is hidden or showed depend on the location hash.
So, when a user go back on his browser history the content doesn't change, because the content is manipulated by our script. To get this functionality, we need refreshing on hash change.
Pros:

We can navigate like in a normal web using back and forward buttons

Cons:

Every time we browse we will consume more resources, because before the web was only refreshed when searching or selecting a topic, now it will refresh every time we change the hash (which are many).
Visually it is easier to get dizzy because when you refresh the web, all the content loads again and the script have to hide again the content that we do not want to show, creating jumps on the screen.

I will leave this PR open for a time to give you the opportunity to test it and receive feedback from the community, as well as to receive suggestions for other ways to solve the problem.

Internal Tracking ID: EXPOSUREAPP-13506)

Although this PR fixes the issue, it introduces graphic glitches caused by the reloading mentioned in the OP all over the FAQ page, so I would vote to not merge this in the current state.

@brifemu

Thank you for making an attempt to fix issue #2981!
I had only noted this problem in the Glossary section, not in other parts of the FAQ. In the rest of the FAQ links in the body of the articles are generally set up to open in a new frame target='_blank' in which case the back arrow has no effect in any case.
There is however an example https://www.coronawarn.app/en/faq/results/#who_can_help which links to https://www.coronawarn.app/en/faq/results/#qr_test without  target='_blank' and in this case the back arrow works (without this PR), so this shows that the issue is only in the Glossary.
In the Glossary the links (href) are set up without any target defined.
It has been noted that the refresh has undesirable side-effects.

Conclusion
Since the problem only affects the Glossary and if the solution produces side-effects which negatively affect the rest of the FAQ then it would be better not to implement this solution.

Agreed, so would it be better to have target="_blank" in the glossary so it's the same as in faq?

@svengabr

... so would it be better to have target="_blank" in the glossary so it's the same as in faq?

That would work around the back-arrow issue and provide a more consistent user experience.
If this is changed for the Glossary, then it would be good to also make sure all the corresponding links in the top part of the FAQs also use  target="_blank" as currently there are a few internal links which don't have this attribute set.


titan: Fix possible panic of generating snap when doing UnsafeDestroyRange

Signed-off-by: Connor<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close https://github.com/tikv/tikv/issues/8661
What is changed and how it works?
Call DeleteBlobFiles after scan-delete
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test

Side effects

None

Release note

Fix possible missing blob file error of generating snap when doing UnsafeDestroyRange

/run-all-tests

/run-all-tests

/merge

Upgrade rust-rocksdb so close https://github.com/tikv/tikv/pull/8694 by the way

/test

/run-test

/test


Add Lost x IshowSpeed

Song Name
Lost x IShowSpeed
Artist Name
Crim3s
Source
Direct file download
Youtube Link
945695.mp3
Direct File Link
https://download2290.mediafire.com/te2ht0j9sdcgM9URpauZwg5SevaQNo0ILa9ObRp4TXCOLWxazqQ-0hz-7vpuVrwiPUUqdVdCuQXPTOq-ltjKuf0B2ZMvoHItjy-u0eCujRZEehOu-1nI6j4dvCBhWQQ-NnjS6LVCoPjP1fBIq6UkzAH5HsCmLx96bmz2XeZV5yQtC0uf/7x3slatwtxjfgs2/945695.mp3
Song ID
945695
Extra
Created from Auto Nong.
Created for level: 27690100

mediafile links are not supported. I suggest uploading to YouTube or using an existing video from YouTube.


fix: we were in a reconcile loop because we misunderstood how ctrl.result{} worked

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 23 (52.17%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 37.546%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

controllers/builders/pod_access_builder.go
0
1
0.0%

controllers/exec_access_request_controller.go
0
1
0.0%

controllers/exec_access_template_controller.go
0
3
0.0%

controllers/pod_access_request_controller.go
12
15
80.0%

controllers/pod_access_template_controller.go
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
618

Relevant Lines:
1646

💛  - Coveralls


"What to expect" guide for Pima MVP

Write a little bit of documentation to help guide Pima through the first iteration of the download site. To be completed before 1/28 meeting.
Should include

[x] Recommended browsers
[x] OKTA URL

[x] General OKTA password reset etc options
[x] 2FA / Do we recommend a particular method? Authenticator?
[x] What is OKTA, why am I using this?

[x] Temporary download site URL
[x] Temporary Process for logging into OKTA then going to the temp URL
[x] CSV downloads
[x] Support email/contact options

Draft copy available here: https://docs.google.com/document/d/1Ea3pFIoGtnXxJkloRZwvBK0E1Ky3QAzwiJKWNeGNWDg/edit?usp=sharing

Draft copy available here: https://docs.google.com/document/d/1Ea3pFIoGtnXxJkloRZwvBK0E1Ky3QAzwiJKWNeGNWDg/edit?usp=sharing


Add mcfunction topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

mcfunction has become a fairly known language since it was created back in 2018. There are currently 150 repositories with this topic, alongside 169 repositories using the language.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Unsubscribe
Get Outlook for iOShttps://aka.ms/o0ukef

From: Ash Wilson @.>
Sent: Thursday, June 30, 2022 6:09:13 PM
To: github/explore @.>
Cc: Subscribed @.***>
Subject: Re: [github/explore] Add mcfunction topic (PR #3145)
Merged #3145https://github.com/github/explore/pull/3145 into main.
—
Reply to this email directly, view it on GitHubhttps://github.com/github/explore/pull/3145#event-6914309674, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANPM43Z3S2CEHLZSALI7JDTVRYLITANCNFSM5ZZFVNRA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Can someone spam-hide that?
(hide this too once done)


[BUG] Default config doesn't load.

In Osiris.cpp, a config object is initiated with the value of "Osiris".
This implies that any config named "Osiris" will be loaded by default.
However, the config is not loaded at injection.

Doesn't that mean that configs are stored in a folder called "Osiris"?

I checked the source and it does refer to the folder instead of a config.


[Feature Request] RpgDifficulty compat (show mob level prefix in display name)

Hey! I really love the mod!
Is it possible to add a way to display mob levels from RpgDifficulty's system? Kinda like a prefix before the mob's name.
Mob levels are stored in the mob's data (/data get)

I don't know if this kind of compatibility is something you can ask for and even if "compatibility" is the right word to describe it.
Servers running server-side mods would really appreciate this feature though.
Thanks!

This is a neat suggestion.
@Globox1997 is there any APIs to get mob level with code?


chore(deps): update dependency storybook-readme to v4

This PR contains the following updates:

Package
Type
Update
Change
References

storybook-readme
devDependencies
major
3.3.0 -> 4.0.0
source

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Enabled.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.15.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Mm 13107 Add backwards compatibility for post-metadata

Summary
Reverts some changes from https://github.com/mattermost/mattermost-webapp/pull/1686/files with a check for metadata obj
Ticket Link
MM-13107
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Has UI changes

Spintmint test server creation failed. See the logs for more information.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-03e1c5186238f12b5.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-03e1c5186238f12b5

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0a53283fd0793859f.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0a53283fd0793859f

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0a6e77c9f042e47bc.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0a6e77c9f042e47bc

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0c94732bade5f37be.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0c94732bade5f37be

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0d06dd4600b18a549.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0d06dd4600b18a549

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-09bfd845abb900a45.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-09bfd845abb900a45


ssh_keys: stop using sed, use saved backup of authorized_keys instead

Signed-off-by: Dan Mick<EMAIL_ADDRESS>

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1383/
Tests passed for this pull request.


Sample 5 without managedResources: does not use credentials from Vault

Bug Report
Describe the Bug
Sample 5 without managedResources: does not use credentials from Vault
Expected Behavior
Use credentials from Vault
Observed Behavior
The EDC searches for the credentials in the Vault by keyName. If the credentials are not in the Vault an error is logged at the consumer. If available, no error is logged but the credentials do not seem to get used. The provider will complain in both cases about missing accessKeyId and secretAccessKey.
Steps to Reproduce
See detailed description
Context Information
See detailed description
Detailed Description
I’m running sample 5 in a slightly different way as I have not full access to an AWS account. Without full access I cannot create a new bucket for each transfer as is done in the example5 instructions (with "managedResources": true). One of our customers has provided me access to an existing bucket and provided me with read/write access to that bucket.
I changed the API call to look like this:
{
    "protocol": "ids-multipart",
    "assetId": "1",
    "contractId": "{{contract_agreement_id}}",
    "dataDestination": {
        "properties": {
            "type": "AmazonS3",
            "region": "eu-central-1",
            "bucketName": "poc-dsh-tno-edc-example5",
            "keyName": "document.txt"
        },
        "type": "AmazonS3"
    },
    "transferType": {
        "contentType": "application/octet-stream",
        "isFinite": true
    },
    "managedResources": false,
    "connectorAddress": "{{url_provider_ids}}/api/v1/ids/data",
    "connectorId": "consumer"
}

I get this error at the consumer when the secret document-txt is not in the Vault:
SEVERE 2022-07-11T13:42:17.114302 Secret not found!
com.azure.core.exception.ResourceNotFoundException: Status code 404, "{"error":{"code":"SecretNotFound","message":"A secret with (name/id) document-txt was not found in this key vault. If you recently deleted this secret you may be able to recover it using the correct recovery command. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125182"}}"

Provider complains:
SEVERE 2022-07-11T13:42:20.639791 Fatal error processing transfer request: 0721cb6d-9a13-4639-b094-8a05e2955b14. Error details: Failed to delegate data transfer to Data Plane: Missing or invalid value for key accessKeyId, Missing or invalid value for key secretAccessKey

Adding secret document-txt to the Vault as {"accessKeyId":"***","secretAccessKey":"***"} removes the error at the connector.
But the provider still gives same error. So the credentials do not seem to be get used.
SEVERE 2022-07-11T13:50:27.698615 Fatal error processing transfer request: 56076f4f-3e30-4060-b4bd-abf6036b6a29. Error details: Failed to delegate data transfer to Data Plane: Missing or invalid value for key accessKeyId, Missing or invalid value for key secretAccessKey

Adding accessKeyId and secretAccessKey to the API call works.
BTW: I would expect credentials to be stored at a bucketName level rather than keyName

Is this still an issue? I'd remove the bug label as it seems more related to the sample than the EDC extension itself.


Optional pipeline steps: enabled=false boolean

I want to be able to ship kpt packages with optional features, but kpt doesn't have any conditional code blocks.
One way to satisfy this requirement would be to add an enabled boolean to the pipeline step syntax in kpt v1. This would allow kptfiles to include steps that are disabled by default, allowing users to enable them with a one-line change.
An optional additional enhancement would be a CLI command for toggling steps by name:
kpt pipeline step enable "step-name"

Sounds useful.
I wanted something similar for kustomize at some point.

Hypothetical example:
Kptfile:
pipeline:
  mutators:
  - image: gke-security-group
    configMap:
      domain: environblueprint.joonix.net
      parent: gke-security-groups
      create: true
      groups:
      - group1
      - group2
    enabled: false

This example would call a function to set the spec.authenticatorGroupsConfig.securityGroup on any ContainerCluster in the package, and make the group in Google Workspaces if it didn't already exist, but would be disabled by default, because not all users of the GKE clusters have a Google Workspace or Cloud Identity subscription.
This would allow reducing the dependencies of the package by default and making groups an optional dependency.

The use case makes sense to me.  This will be a post-v1 additive change. Exact schema and CLI porcelain (if any) design TBD.

@droot mentioned a use case for this in #2284


How I use functional components

1. First I created a state to store the values total, next, and operation.
2. After that I created a function clickFunction2 to handle the click event, inside this function I used the setState to change the state when a button is pressed.
3. The setState function uses the calculate function to change the state according to the key that is clicked.
4. Finally I created a function display to show appropriately the values on the screen.

Hi @dfsalam ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
Great effort so far :+1:
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Automigration not creating all tables (just some)

Go version 1.10
Postgresql 10 (with timescaledb extension)
I've got two different go programs using similar schemes. Migrating the first works fine, but when I migrate my second program, only some tables are copied.
program A:
type ACustomerstruct {
	ID uint 			`gorm:"primary_key"`
	MarketID uint 		`gorm:"index"`
	Time time.Time	`gorm:"primary_key"`
}

type AInvoice struct {
	ID uint 			`gorm:"primary_key"`
	OrderbookID uint 	`gorm:"index"`
	Rate float64
	//bitfinex supports giving the total number of sell/buyorders.
	//however we should skimp on memory and not add those
	//count int64
	Quantity float64
	Time time.Time	`gorm:"primary_key"`
	}

type APrice struct {
	ID uint 			`gorm:"primary_key"`
	Ticker string		`gorm:"unique_index:idx_market"`
	Quote string		`gorm:"unique_index:idx_market"`
}

type AValue struct {
	ID  uint 			`gorm:"primary_key"`
	MarketID uint		`gorm:"index"`
	Price float64
	Volume float64
	Time time.Time	`gorm:"primary_key"`

program B
type BCustomerstruct {
	ID uint 			`gorm:"primary_key"`
	MarketID uint 		`gorm:"index"`
	Time time.Time		`gorm:"primary_key"`
}

type BInvoice struct {
	ID uint 			`gorm:"primary_key"`
	OrderbookID uint 	`gorm:"index"`
	Rate float64
	//bitfinex supports giving the total number of sell/buyorders.
	//however we should skimp on memory and not add those
	//count int64
	Quantity float64
	Time time.Time	`gorm:"primary_key"`
	}

type BPrice struct {
	ID uint 			`gorm:"primary_key"`
	Ticker string		`gorm:"unique_index:idx_market"`
	Quote string		`gorm:"unique_index:idx_market"`
}

type BValue struct {
	ID  uint 			`gorm:"primary_key"`
	MarketID uint		`gorm:"index"`
	Price float64
	Volume float64
	Time time.Time	`gorm:"primary_key"`

The migrations are identically performed:
err = gormdb.AutoMigrate(&db.BCustomerstruct{}, &db.BInvoice{}, &db.BPrice{}, &db.BValue{}).Error
	if err != nil{
		panic(err)
	}

No errors are thrown while migrating.

which one of them is not created ?
did you try delete the database when using the second program ?

I general, when I automigrate program A first, the following models are not created when migrating B:
type BInvoice struct {
	ID uint 			`gorm:"primary_key"`
	OrderbookID uint 	`gorm:"index"`
	Rate float64
	//bitfinex supports giving the total number of sell/buyorders.
	//however we should skimp on memory and not add those
	//count int64
	Quantity float64
	Time time.Time	`gorm:"primary_key"`
	}

type BPrice struct {
	ID uint 			`gorm:"primary_key"`
	Ticker string		`gorm:"unique_index:idx_market"`
	Quote string		`gorm:"unique_index:idx_market"`
}

type BValue struct {
	ID  uint 			`gorm:"primary_key"`
	MarketID uint		`gorm:"index"`
	Price float64
	Volume float64
	Time time.Time	`gorm:"primary_key"`

Dropping and recreating the DB does solve the problem, however it seems to me that the other tables should be migrated as well. There are no conflicting names .

then try to remove the index maybe they are the cause of the conflict .

@KaiserKarel any luck with this?


How to perform IOT ES512 ES256 encryption? (IDFGH-9690)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Hello everyone, I need to link to the IOT cloud and require ES512 and ES256 verification.
I use ESP-IDF 4.4 and ESP32-WROVER-B(8 MB).
The esp-idf/components/mbedtls/mbedtls/programs/pkey/ecdsa.c example is incorrect and cannot be passed https://jwt.io/ verification,  The parameter specified as #define ECPARAMS    MBEDTLS_ECP_DP_SECP256R1.
How can I get the correct results if I use the following information .
JWT header
{"alg":"ES256","typ":"JWT"}
JWT header base64
eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9
data
{"iat":51,"exp":3651,"iss":"esp32"}
data base64
eyJpYXQiOjUxLCJleHAiOjM2NTEsImlzcyI6ImVzcDMyIn0
JWT signed
eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjUxLCJleHAiOjM2NTEsImlzcyI6ImVzcDMyIn0.JAWJQ17Vaa5RQ62Lli1WkrKDu95sbwkI1NuL7EE3MphQmZ5BwhbIw2xbiSSjOIfHHP-Oer4SzvrpvHziN1SFxw
-----BEGIN PUBLIC KEY-----
MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAErbJbQ9/uCBv+76EkuxzvzSHRNrV+
EM+xpJQXT3eI/d2ilvFM/OvTgWPU3UotDA63Snt+uZaow3YQcihzDhgsRw==
-----END PUBLIC KEY-----
-----BEGIN EC PRIVATE KEY-----
MHcCAQEEIHGydA+QgPlivuLor6T+6oJs+Wf3thxgeegVF/IWqnQsoAoGCCqGSM49 AwEHoUQDQgAErbJbQ9
/uCBv+76EkuxzvzSHRNrV+EM+xpJQXT3eI/d2ilvFM/OvT
gWPU3UotDA63Snt+uZaow3YQcihzDhgsRw==
-----END EC PRIVATE KEY-----
thank you

@mahavirj  Thank you. I'm going to test this library

@mahavirj
have you got the sketch esp_18w8jwt for arduino on .ino? or do you know to do it in? 'Cause that sketch is .c, thanks

Please refer to Arduino documentation for this, it should be fairly straight-forward to create a small wrapper that is Arduino compatible on top of this component.
I am closing this issue as its scope is outside of IDF. Please feel free to raise any issues on the repository pointer shared above...


needs more instructions

needs fused multiply-add insn and a dedicated instruction to cause a triple fault

This project will have no further updates.


Add missing string functions to docs

The docs command is missing the pack, unpack, and packsize for Lua 5.3
https://i.skystuff.cc/PEUlSF5te0AR.png

Thank you for the PR. It looks like there were several more missing (some I'd forgotten to add, some apparently lost in the rewrite), so I've committed 6473af87dfc390dcf7d426c256a6fb1904ba1899 instead.


[SPARK-25884][SQL][FOLLOW-UP] Add sample.json back.

What changes were proposed in this pull request?
This is a follow-up pr of #22892 which moved sample.json from hive module to sql module, but we still need the file in hive module.
How was this patch tested?
Existing tests.

cc @srowen @cloud-fan

Test build #98458 has started for PR 22942 at commit 18ccff1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4758/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98458/
Test PASSed.

thanks, merging to master!


Stage auth - obada

you pull requested to the master branch i created another pull request to the stage branch and merge it.


terminate line 19 : csd_webapp_config.xqm

Line 19 not terminated, got an error on linking openinforman libraries to basex repository

Which version do you have installed?  There was an issue I thought was
fixed.
Cheers,
-carl
On Jan 22, 2016 15:02, "dannkhoma"<EMAIL_ADDRESS>wrote:

Line 19 not terminated, got an error on linking openinforman libraries to
basex repository
—
Reply to this email directly or view it on GitHub
https://github.com/openhie/openinfoman/issues/26.

Pulled latest version, file csd_webapp_config.xqm, updated four days ago. Im using the basex snapshot version 8.3

I (think I) have fixed it with the following commit:
https://github.com/openhie/openinfoman/commit/58b81ca64adee592121f97745c535113b3deed8d
If you can confirm that it fixes the issue, then please feel free to close the issue.
I would also recommend you try the new Ubuntu packaging.  It generates the needed config during install.

Yes this has fixed the issue, let me also try the Ubuntu packaging. Thanks
Cheers


Add Redis Cache, Make Cache interface async, cache clean up

Here's a PR for a Redis cache. It includes a few small change to the BaseCache and InMemory cache as well.
One thing to note: In Python LangChain, the cache is set on the global langchain object like:
import langchain
from langchain.cache import InMemoryCache
langchain.llm_cache = InMemoryCache()

This doesn't translate well to TypeScript. It's worth discussing how this should be handled. IMHO, it would be best to optionally pass the cache to the LLM class upon instantiation with an in-memory cache as a fallback.

Thanks a lot for this @samheutmaker


fix(docs): jsdoc strings were malformed

Several jsdoc strings were malformed.
Before

After

Looks like this was broken in https://github.com/googleapis/nodejs-logging/pull/252, "chore: run gts fix". Do you know if we still have any of that auto-formatting from that PR that caused this, that could try to do it again?

Great detective work :) Chances are, back in 2018 gts was using clang-format for prettifying JavaScript, which was, well, not very good.  We're on prettier now, which has far better community support and didn't appear to cause the same break here.

@JustinBeckwith @stephenplusplus 👍 I re-ran fix to make sure this didn't break anything. I also re-ran synthtool to make sure it didn't clobber anything.


Adding a new rebus: coronavirus

Associated Issue: #121
Summary of Changes

Add just one new rebus about coronavirus. My second contribution in open source 😄.

Pull Request Test Coverage Report for Build 924

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.143%

Totals

Change from base Build 514:
0.0%

Covered Lines:
158

Relevant Lines:
180

💛  - Coveralls


Unlink temp file only when we are done with it

Windows doesn't like attempting to unlink a file when it is in use.
This change ensures we only attempt to unlink once we are done. I've tested it on a project that was consistently having the issue and it fixed it.
This change removes the need for a possible infinitely looping setTimeout as suggested in the other pull request for this issue.

This change removes the need for a possible infinitely looping setTimeout as suggested in the other pull request for this issue.

If you're talking about #85 there isn't any infinite loop there.
Also, this won't fix the issue. The unlink only might work immediately after the kill. It may require at least one setTimeout(0, ...) for the OS to finish cleanup.

I've tested it with a project that was consistently having the unlink error. This change has removed the issue for me. In what situation do you think the setTimeout will be required? I'm happy to try and reproduce it with the proposed change.
To be honest, at the moment I'd be happy with any change that fixes this because I have a few CI builds that are consistently failing because of this issue

I have no idea what causes it, but I copied your change into my local repo and can still reproduce.
The project I'm reproducing with is TSWCalc for reference.
Otherwise I'm not really sure what's required for Windows to behave like this:
Windows 10
SSD
Intel processor

I've just cloned that project and you're right. It's not fixed.
My projects are using grunt-contrib-jasmineto run tests which seems to work with my change. Maybe it's something to do with how these two different testing modules interact with phantom.js.
Curses!


Error on startup

My setup is similar to this gist. However, I am getting following error on startup.
Error in packer_compiled: ...pack/packer/start/cmp-tabnine/lua/cmp_tabnine/source.lua:53: attempt to index local 'latest' (a nil value)
Please check your config for correctness
Error detected while processing /home/mayank/.local/share/nvim/site/pack/packer/start/cmp-tabnine/after/plugin/cmp-tabnine.lua:
E5113: Error while calling lua chunk: ...pack/packer/start/cmp-tabnine/lua/cmp_tabnine/source.lua:53: attempt to index local 'latest' (a nil value
)

It looks like you do not have the TabNine binary installed.
I've added a proper error message in c3a168e.
Please verify your installation by running install.sh

I forgot to mention in the issue description. Actually, I have TabNine binary (which I checked in the file explorer). However, still this issue comes.
Screenshot of vim startup (after updating and running install.sh). I have TabNine 3.6.8 binaries.

Are you using WSL, or is this native windows?

No, I am not using WSL. My setup is
OS: Debian GNU/Linux bookworm/sid x86_64
Kernel: 5.10.0-8-amd64
DE: GNOME 3.38.6
Shell: zsh 5.8

Ok, can you do a find . in the binaries dir?

The result for find .
.
./3.6.8
./3.6.8/x86_64-unknown-linux-musl
./3.6.8/x86_64-unknown-linux-musl/TabNine
./3.6.8/x86_64-unknown-linux-musl/TabNine-deep-cloud
./3.6.8/x86_64-unknown-linux-musl/TabNine-deep-local
./3.6.8/x86_64-unknown-linux-musl/WD-TabNine

Can you try this patch, and show me the output?
diff --git a/lua/cmp_tabnine/source.lua b/lua/cmp_tabnine/source.lua
index 6f3cd80..733b1cf 100644
--- a/lua/cmp_tabnine/source.lua
+++ b/lua/cmp_tabnine/source.lua
@@ -25,14 +25,18 @@ local binaries_folder = fn.expand('<sfile>:p:h:h:h') .. '/binaries'
 local function binary()
        local versions_folders = fn.globpath(binaries_folder, '*', false, true)
        local versions = {}
+ dump(versions_folders)
        for _, path in ipairs(versions_folders) do
+         dump(path)
                for version in string.gmatch(path, '/([0-9.]+)$') do
+                 dump('version:', version)
                        if version then
                                table.insert(versions, {path=path, version=version})
                        end
                end
        end
        table.sort(versions, function (a, b) return a.version < b.version end)
+ dump(versions)
        local latest = versions[#versions]
        if not latest then
                vim.notify('cmp-tabnine: Cannot find installed TabNine. Please run install.sh')

The version_folder in my case is empty. Got following dump
{}
{}
cmp-tabnine: Cannot find installed TabNine. Please run install.sh
{}
{}
cmp-tabnine: Cannot find installed TabNine. Please run install.sh

I then printed out binaries_folder and I got "~/.dotfile/nvim/.config/binaries", which is wrong.

I am also using packer, and do not have this issue.
Can you try doing require('cmp_tabnine.config').setup() before loading any cmp code?
A different option would be to allow users to override the automatic detection of the binaries directory.

can you also try this?
diff --git a/lua/cmp_tabnine/source.lua b/lua/cmp_tabnine/source.lua
index 6f3cd80..98b69ab 100644
--- a/lua/cmp_tabnine/source.lua
+++ b/lua/cmp_tabnine/source.lua
@@ -21,9 +21,14 @@ end
 -- do this once on init, otherwise on restart this dows not work
 local binaries_folder = fn.expand('<sfile>:p:h:h:h') .. '/binaries'

+function script_path()
+   local str = debug.getinfo(2, "S").source:sub(2)
+   return str:match("(.*/)")
+end
+
 -- locate the binary here, as expand is relative to the calling script name
 local function binary()
-   local versions_folders = fn.globpath(binaries_folder, '*', false, true)
+ local versions_folders = fn.globpath(script_path() .. '../../binaries', '*', false, true)
        local versions = {}
        for _, path in ipairs(versions_folders) do
                for version in string.gmatch(path, '/([0-9.]+)$') do

I was able to solve the issue with following diff.
diff --git c/lua/cmp_tabnine/source.lua w/lua/cmp_tabnine/source.lua
index 6f3cd80e7e17..3de28fd6fd4b 100644
--- c/lua/cmp_tabnine/source.lua
+++ w/lua/cmp_tabnine/source.lua
@@ -17,9 +17,29 @@ local function json_decode(data)
 	end
 end

+function script_path()
+   local str = debug.getinfo(2, "S").source:sub(2)
+   return str:match("(.*[/\\])")
+end
+
+local function get_path_separator()
+  if ((fn.has('win64') == 1) or (fn.has('win32') == 1)) then return '\\' end
+  return '/'
+end
+
+local function get_parent_dir(path)
+    local separator = get_path_separator()
+    local pattern = "^(.+)" .. separator
+    local parent_dir = string.match(path, pattern)
+    -- if path was having separator at end then run match again to get parent_dir
+    if (string.len(parent_dir) == string.len(path) - string.len(separator)) then
+        parent_dir = string.match(parent_dir, pattern)
+    end
+    return parent_dir .. separator
+end

 -- do this once on init, otherwise on restart this dows not work
-local binaries_folder = fn.expand('<sfile>:p:h:h:h') .. '/binaries'
+local binaries_folder = get_parent_dir(get_parent_dir(script_path())) .. 'binaries'

 -- locate the binary here, as expand is relative to the calling script name
 local function binary()

closing

Are you using WSL, or is this native windows?

I'm using wsl and got this error, how I can fix that?

idk, please provide more info in a new issue.


Inconsistent response code on wallet update pass (403 and 404)

Release
Operating System
Cause

next
Linux
Code

Context
https://github.com/input-output-hk/cardano-wallet/pull/261#discussion_r283760753
Steps to Reproduce

curl  -vX PUT http://localhost:8090/v2/wallets/617963656a409b8a6828dc3a09001de22af90400/passphrase \
  -H "Accept: application/json; charset=utf-8" \
  -H "Content-Type: application/json; charset=utf-8" \
  -d '{
"old_passphrase": "Secure Passphrase",
"new_passphrase": "Secure Passphradddse"
}' |  jq

Expected behavior
should be probably 404 for all cases
Actual behavior
when the wallet ID is valid 40 hex but non-existing -> 403
when the wallet ID is not valid hex or valid hex but non-40 char long -> 404

Resolution Plan

It seems like the errors from the wallet layer are not mapped correctly in the Api.Server. Mapping should be fixed.

PR

Number
Base

#267
master

QA

Test have been adjusted to remove the special handling logic and checks that the API now always return 404 for the case described above (see also #267)

:+1:


Amplify Pull with a profile specificed in --awsInfo fails to find app

Describe the bug
When I perform the following command, I'm able to pull my environment correctly:
amplify pull --appId XXXXXXXX --envName dev

For more information on AWS Profiles, see:
https://docs.aws.amazon.com/cli/latest/userguide/cli-multiple-profiles.html

? Do you want to use an AWS profile? Yes
? Please choose the profile you want to use personaleast1
Amplify AppID found: XXXXXXXX. Amplify App name is: MyAppName

When I specify the --awsInfo argument with the following:
amplify pull --appId XXXXXXXX --envName dev --yes --awsInfo {"configLevel":"project","useProfile":true,"profileName":"amplifyrole"}

or if I just specifying the --yes argument, anticipating it will pull the AWS CLI profile from my shell session, the following error results:
amplify pull --appId XXXXXXXX --envName dev --yes

Amplify AppID: XXXXXXXX not found. Please ensure your local profile matches the AWS account or region in which the Amplify app exists.
NotFoundException: App XXXXXXXX not found.
    at Object.extractError (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/protocol/json.js:51:27)
    at Request.extractError (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/protocol/rest_json.js:55:8)
    at Request.callListeners (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
    at Request.emit (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:685:12) {
  message: 'App XXXXXXXX not found.',
  code: 'NotFoundException',
  time: 2020-02-12T19:16:41.355Z,
  requestId: '940de103-82ba-42ab-addd-d2400ab49083',
  statusCode: 404,
  retryable: false,
  retryDelay: 45.92666615486441
}
Failed to pull the backend.
NotFoundException: App XXXXXXXX not found.
    at Object.extractError (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/protocol/json.js:51:27)
    at Request.extractError (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/protocol/rest_json.js:55:8)
    at Request.callListeners (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
    at Request.emit (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/Users/dhagen/.nvm/versions/node/v13.6.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:685:12) {
  message: 'App XXXXXXXX not found.',
  code: 'NotFoundException',
  time: 2020-02-12T19:16:41.355Z,
  requestId: '940de103-82ba-42ab-addd-d2400ab49083',
  statusCode: 404,
  retryable: false,
  retryDelay: 45.92666615486441
}

Amplify CLI Version
$ amplify -v
4.13.1

To Reproduce
Specified above in the description.
Expected behavior
Also basically described in the first section.
Screenshots
The terminal output provided above.
Desktop (please complete the following information):

OS: MacOS
Node Version: v13.6.0

Additional context
Trying to set up a command for amplify.yaml to perform to pull the Amplify environment into the cloned codebase during the build.

amplify pull does not  take the --awsInfo input parameter, so the profile specification is not taken in by the CLI. The --yes flag will suppress command line prompt, The CLI will just rely on the aws-sdk to resolve the credentials, very likely using the default profile, which is different than the original account when the Amplify Console Project is created. that's why you got the error.
It's very difficult to pass in stringified JSON object on command line, you can instead run a headless script, like the following:
#!/bin/bash
set -e
IFS='|'

AWSCLOUDFORMATIONCONFIG="{\
\"configLevel\":\"project\",\
\"useProfile\":true,\
\"profileName\":\"default\"\
}"
AMPLIFY="{\
\"appId\":\"yourAppid\",\
\"envName\":\"yourEnvName\"\
}"
PROVIDERS="{\
\"awscloudformation\":$AWSCLOUDFORMATIONCONFIG\
}"

amplify pull \
--amplify $AMPLIFY \
--providers $PROVIDERS \
--yes

Hello @UnleashedMind,
I've been trying the headless script like you sent. I probably just mixed up the push vs. pull scripts with the --awsInfo flag.
So using the script you gave, the following command is formed and included is it's result.
amplify pull --amplify {"appId":"XXXXXXXX","envName":"localdev"} --providers {"awscloudformation":{"configLevel":"project","useProfile":true,"profileName":"default"}}
Scanning for plugins...
Plugin scan successful
Cannot create property 'providers' on string 'appId:XXXXXXXX'
TypeError: Cannot create property 'providers' on string 'appId:XXXXXXXX'
    at transform (/Users/dhagen/.nvm/versions/node/v13.2.0/lib/node_modules/@aws-amplify/cli/src/input-params-manager.js:43:32)
    at normalizeInputParams (/Users/dhagen/.nvm/versions/node/v13.2.0/lib/node_modules/@aws-amplify/cli/src/input-params-manager.js:8:3)
    at constructInputParams (/Users/dhagen/.nvm/versions/node/v13.2.0/lib/node_modules/@aws-amplify/cli/src/amplify-service-helper.js:4:23)
    at Object.run (/Users/dhagen/.nvm/versions/node/v13.2.0/lib/node_modules/@aws-amplify/cli/src/commands/pull.js:11:25)
    at Object.executeAmplifyCommand (/Users/dhagen/.nvm/versions/node/v13.2.0/lib/node_modules/@aws-amplify/cli/src/index.ts:96:23)
    at executePluginModuleCommand (/Users/dhagen/.nvm/versions/node/v13.2.0/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:56:26)
    at Object.executeCommand (/Users/dhagen/.nvm/versions/node/v13.2.0/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:21:5)
    at Object.run (/Users/dhagen/.nvm/versions/node/v13.2.0/lib/node_modules/@aws-amplify/cli/src/index.ts:40:5)

➜ amplify -v
4.13.3

Ok, just a quick follow up. I'm running in a ZSH shell, and it's behaving the same as I mentioned in the BASH based build container in the build pipeline. By adding single quotes around the JSON, the error above goes away. Copying the code here:
#!/bin/bash
set -e
IFS='|'

AWSCLOUDFORMATIONCONFIG="{\
\"configLevel\":\"project\",\
\"useProfile\":true,\
\"profileName\":\"default\"\
}"
AMPLIFY="'{\
\"appId\":\"yourAppid\",\
\"envName\":\"yourEnvName\"\
}'"
PROVIDERS="'{\
\"awscloudformation\":$AWSCLOUDFORMATIONCONFIG\
}'"

amplify pull \
--amplify $AMPLIFY \
--providers $PROVIDERS \
--yes

Actually, if anyone wants my script code, this is what I'm doing to produce the same idea, just with passable flags:
#!/bin/bash
set -e
IFS='|'
args=("$@")

appId=""
envName=""
useProfile="false"
profileName="default"
for ((argPos=0; argPos <= ${#args}; argPos++))
do
  if [ "${args[$argPos]}" == "--appid" ]; then
    appId="${args[(($argPos+1))]}"
    argPos=$((argPos+1))
  elif [ "${args[$argPos]}" == "--envName" ]; then
    envName="${args[(($argPos+1))]}"
    argPos=$((argPos+1))
  elif [ "${args[$argPos]}" == "--useProfile" ]; then
    useProfile="true"
  elif [ "${args[$argPos]}" == "--profileName" ]; then
    profileName="${args[(($argPos+1))]}"
    argPos=$((argPos+1))
  fi
done

AWSCLOUDFORMATIONCONFIG="{\
\"configLevel\":\"project\",\
\"useProfile\":${useProfile},\
\"profileName\":\"${profileName}\"\
}"
AMPLIFY="'{\
\"appId\":\"${appId}\",\
\"envName\":\"${envName}\"\
}'"
PROVIDERS="'{\
\"awscloudformation\":$AWSCLOUDFORMATIONCONFIG\
}'"

cmd="amplify pull --providers ${PROVIDERS} --amplify ${AMPLIFY} --yes"
echo $cmd
eval $cmd

That was it! Amplify Build pipeline was able to pull in the project without any aws-exports.js being committed, just the way I wanted it!
Any objection to me submitting a PR for the script above? I need to put some error checking in to make me happy, though.


Token become immutable, performance optimizations

TODO:

[x] rebase on master

Executing on Symfony 2.7 with 45files that reports violations

before
> Checked all files in 77.743 seconds, 20.000 MB memory used
> Checked all files in 78.761 seconds, 20.000 MB memory used

after improvement
> Checked all files in 70.417 seconds, 20.000 MB memory used
> Checked all files in 71.144 seconds, 20.000 MB memory used

About 10% improvement

Deps:

[x] #2819
[x] #2816
[x] #2817
[x] #2823

Please add tests that cover Tokens changes regarding "immutable mode".

https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2818/commits/9b63057380de9a557b7bbc8affcca64a8bc1b92e


style(tslint): ban PascalCase variables from the code

It is very easy to confuse PascalCase variables in JS/TS with classes.
We would much rather keep
lowerCamelCase for variables and PascalCase for classes
to make it easier to read the code.
fix #197
Signed-off-by: Peter Somogyvari<EMAIL_ADDRESS>

I understand your intention, but I prefer to suspending this strict rule for a while since we are still under refactoring.

Works for me. Happy to keep this open until we are all ready to pull the plug.

LGTM


Variation of reso energy % for days remaining

A simple adaption of reso-energy-pct-in-portal-details.user.js where instead of displaying the remaining percentage, it calculates the decay rate (15% of max per day) and displays the (pessimistic) number of days remaining based on the remaining energy. Screenshot:

Issues: If both days and % scripts are enabled, they will both display and look garbled. There are plenty of ways to work around this but as this is my first contribution to IITC and UI dev is not generally my area of expertise, I'm happy to take suggestions, or for someone else to roll it in to the pct script. Screenshot:

@ravendarque I left a comment on your commit with a suggestion on how to fix the garbling of data.


Project alive?

Is this project alive?  Does not seem like it... do not want to start a new project based on this if dead.  Thanks

Yes alive


feat: semi-uniqueness of limits in seminormed spaces

Zulip thread

Thanks! Once CI is happy, please merge this PR using bors r+
bors d+

bors merge


Reloading comments after network issue

Hi! I've been running into this issue a lot, due to my bad network connection.
Here is how to reproduce it:

Open Slide
Enable airplane mode (to simulate network problem)
Open a post -> Blue box says "No cached comments found"
Disable airplane mode (to simulate network recovering)
Refresh post

Instead of reloading, Slide is still going to try to find cached comments.
The same blue error box reappears.
Even when leaving the post and going back into it, this issue persists.
This looks like the app automatically goes into an offline mode for the post when loading fails. IMO it should also automatically leave that mode, or offer a way to actually try to reload comments.

The issue with this is actually a lot more complicated. When Slide loads the last loaded content (offline data), and I try to access the variables inside the offline objects, the app will crash because of some threading issues with the offline library I'm using. This becomes an issue when I try to access the post ID in order to load comments, as it cannot access the ID without crashing. If I can find a way to access this without a crash, it would be able to load comments even if it is displaying offline data but as a temporary band-aid I have just made it have that popup

Sorry to hear that. Wish I could help, but I don't even have a mac to play around with.
Best of luck with finding a solution and thanks so much for your hard work!


[stable/prometheus-pushgateway] configureable deployment strategy

What this PR does / why we need it:
When the pushgateway is configured to use a PV for storage and the PV does not allow multi attach, updates can't be applied because the newly created pod can never attach the storage volume and thus never starts. The old pod never gets deleted (and manually deleting the old pod also doesn't work in all cases). I changed the default behavior because I don't consider this a relevant change in behavior for the pushgateway.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/lgtm

Same error as in: https://github.com/helm/charts/issues/20639
/retest

@cstaud I get "Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message." plz trigger retest

Experiencing the same build error in another chart's PR. Seems to be more generic and affect many charts.

/ok-to-test


build: simplify versioning and update version to 1

Instead of adoptiong the semantic version for
Major.Minor.Release just increment version
for each release.
Signed-off-by: Bruno Dilly<EMAIL_ADDRESS>

bumping the major of soname for every release will not be that good in practice, if we do another release with just additions and no breaks, we'd be backwards compatible but the soname would not work.

As @lucasdemarchi pointed on IRC: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

closed since we have a new version #2222


Change analysis_cache to cater for new analysis results path

See https://github.com/QutBioacoustics/baw-server/issues/207#issuecomment-109172937
path:

analysis_results
job_id integer (for custom jobs) or special case job id system (for system analyses)
first two chars from audio recording guid
full audio recording guid
generic subfolder(s)
file name

Where the folders and files could potentially repeat (i.e. mirror the filesystem, just like a static file web server)

Don't collapse underscores, as double underscores have special meaning.


SAK-45116 Create a new Meetings tool in Sakai, based on the bbb-tool.

https://jira.sakaiproject.org/browse/SAK-45116

The bbb-tool won't be removed from sakaicontrib, this is a reworking of that code. If anybody still wants to work on bib-tool, they're fine to do so. You can actually run bbd-tool and this new code in the same Sakai without issue. Different tables, different bundles, the works.

Sounds good, thanks for clarifying.


[FLINK-7803][Documentation] Add missing savepoint information

This fixes FLINK-7803 by emphasizing the savepoint save location should be on a distributed file-system.

@aljoscha Hi, do you know if it's possible to retrigger the build? Don't believe it fails because of my change. Also, how can I add reviewers? Thanks!

@razvan100 You can re-trigger the build by adding a new commit (even en empty one). However, please don't do this for the sake of achieving a picture perfect build (in particular for documentation changes which can't affect the build anyway); we are aware of certain test instabilities and account for those in the review.
As for reviewers, you cannot explicitly request a review. You can mention committers if (as you did with aljoscha) but I would ask you to refrain from doing so unless absolutely necessary.

Okay, so if you account for it in the review then I don't need to make another empty commit. Thanks!

will merge this while addressing the comments

Thank you @zentol

@razvan100 I've merged the PR, could you close it?


feat(types): read ELEMENT_TYPE_VAR signature type

Codecov Report

Merging #41 (dbaaefd) into master (d92f9ee) will increase coverage by 0.53%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   20.32%   20.86%   +0.53%
==========================================
  Files          19       19
  Lines        3163     3182      +19
==========================================
+ Hits          643      664      +21
+ Misses       2439     2435       -4
- Partials       81       83       +2

Impacted Files
Coverage Δ

cmd/printsig/find.go
0.00% <ø> (ø)

cmd/printsig/main.go
0.00% <0.00%> (ø)

types/element_type.go
25.00% <ø> (ø)

types/signature.go
53.48% <54.83%> (+4.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92f9ee...dbaaefd. Read the comment docs.


Mat token

Project background:
Official announcement: http://trimaxprime.com/
Project basic information: MAT is a flexible token that exchanges among our other project tokens such as RUBY
Recommended Gas Limit (For ERC-20 project teams) for transaction: 60,000

the problems have been figured out in the label, please refer to the tutorial to check and solve these problems.
https://github.com/consenlabs/token-profile#token-profile-guideline


Error issue

We are pleased to inform you that the issue has been resolved. You can now continue to use our application as usual. Thank you for bringing this to our attention


Added Has WorldQuery type

Objective

Fixes #7811

Solution

I added Has<T> (and HasFetch<T> ) and implemented WorldQuery, ReadonlyWorldQuery, and ArchetypeFilter it
I also added documentation with an example and a unit test

I believe I've done everything right but this is my first contribution and I'm not an ECS expert so someone who is should probably check my implementation. I based it on what Or<With<T>,>,  would do. The only difference is that Has does not update component access - adding Has to a query should never affect whether or not it is disjoint with another query I think.

Changelog
Added

Added Has<T>  WorldQuery to find out whether or not an entity has a particular component.

@wainwrightmark can you try out the suggestion from James and report back? Once that's done (success or failure), I'm happy to merge this and ship it for 0.11 :)

Replacing HasFetch<T> with bool worked great!

I realize I have made a mistake in making Has<T> and ArcheTypeFilter - it's technically true in a sense but completely unhelpful as you should never be using it in a filter position. I've reverted this.


JBDS-4330 PGP ASCII armored clearsighn signature verification

Codecov Report

Merging #802 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
- Coverage   98.28%   98.24%   -0.05%
==========================================
  Files          33       34       +1
  Lines        3032     3241     +209
  Branches      254      453     +199
==========================================
+ Hits         2980     3184     +204
+ Misses         52       51       -1
- Partials        0        6       +6

Impacted Files
Coverage Δ

browser/services/openpgp.js
100% <100%> (ø)

browser/model/helpers/downloader.js
96.94% <0%> (-1.52%)
:arrow_down:

browser/model/jbosseap.js
98.8% <0%> (-1.2%)
:arrow_down:

browser/model/cdk.js
99.22% <0%> (-0.78%)
:arrow_down:

browser/services/data.js
97.26% <0%> (-0.56%)
:arrow_down:

browser/model/jdk-install.js
97.29% <0%> (-0.45%)
:arrow_down:

browser/model/devstudio.js
89.13% <0%> (-0.41%)
:arrow_down:

browser/model/cygwin.js
100% <0%> (ø)
:arrow_up:

browser/services/request.js
100% <0%> (ø)
:arrow_up:

browser/model/helpers/hash.js
100% <0%> (ø)
:arrow_up:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27efa49...f3077b5. Read the comment docs.