Revert "Merge pull request #1399 from aweary/use-react-reconciler-rea…

This reverts commit d60360c77410eb5290e3209baa3b3dc339f99ef9, reversing
changes made to bbf39e0c09ea0234e923dcdf01ba9eed218ce490.

cc @gaearon

Looks like findCurrentFiberUsingSlowPath has been updated since we made this change, so I'll have to investigate integrating those updates for all supported versions that use this.

Thanks! Do you mind verifying algorithm against the current one? I don’t think it changed but worth checking. It’s okay if invariants are missing (better than depending on constants).

I'm all for making changes to make things easier for the react team; but copy-pasting code doesn't seem like a good approach for anyone.

@gaearon it looks like the algorithm hasn't changed, with the exception (heh) of the invariants. See the diff below.
@ljharb I'll let @gaearon answer that, I'm not totally familiar with what problems this is causing for us at Facebook.

diff

1,2c1,2
< function findCurrentFiberUsingSlowPath(fiber) {
<   const { alternate } = fiber;
---
> export function findCurrentFiberUsingSlowPath(fiber: Fiber): Fiber | null {
>   let alternate = fiber.alternate;
3a4,12
>     // If there is no alternate, then we only need to check if it is mounted.
>     const state = isFiberMountedImpl(fiber);
>     invariant(
>       state !== UNMOUNTED,
>       'Unable to find node on an unmounted component.',
>     );
>     if (state === MOUNTING) {
>       return null;
>     }
11,13c20,22
<   while (true) { // eslint-disable-line
<     const parentA = a.return;
<     const parentB = parentA ? parentA.alternate : null;
---
>   while (true) {
>     let parentA = a.return;
>     let parentB = parentA ? parentA.alternate : null;
18c27,28
<      // If both copies of the parent fiber point to the same child, we can
---
>
>     // If both copies of the parent fiber point to the same child, we can
22c32
<       let { child } = parentA;
---
>       let child = parentA.child;
25a36
>           assertIsMounted(parentA);
29a41
>           assertIsMounted(parentA);
36c48
<       throw new Error('Unable to find node on an unmounted component.');
---
>       invariant(false, 'Unable to find node on an unmounted component.');
38c50,51
<      if (a.return !== b.return) {
---
>
>     if (a.return !== b.return) {
52c65
<       let { child } = parentA;
---
>       let child = parentA.child;
70c83
<         ({ child } = parentB);
---
>         child = parentB.child;
86,89c99,103
<         if (!didFindChild) {
<           throw new Error('Child was not found in either parent set. This indicates a bug ' +
<             'in React related to the return pointer. Please file an issue.');
<         }
---
>         invariant(
>           didFindChild,
>           'Child was not found in either parent set. This indicates a bug ' +
>             'in React related to the return pointer. Please file an issue.',
>         );
91a106,111
>
>     invariant(
>       a.alternate === b,
>       "Return fibers should always be each others' alternates. " +
>         'This error is likely caused by a bug in React. Please file an issue.',
>     );
92a113,118
>   // If the root is not a host container, we're in a disconnected tree. I.e.
>   // unmounted.
>   invariant(
>     a.tag === HostRoot,
>     'Unable to find node on an unmounted component.',
>   );

I think that we'd need more than a vague "it's causing problems" to justify inlining any dependency.

I also see that react-reconciler is at v0.12.0 - could we update to that?

Different adapters (even within 16) would need to depend on different versions.

That's fine, we already have 16.1, 16.2, and 16.3 adapters, and soon i'll do a breaking change on the 16 adapter to require ^16.4.

(it'd be great if those requirements were documented in the range for react in peerDependencies in react-reconciler; v0.12.0 claims "^16.0.0"

Hmm. I see. If you don’t mind bumping majors when there are incompatible internal changes then you could make it work.
That said, we still don’t provide guarantees about this package working as intended here. The fact that constants match between react-dom and react-reconciler is somewhat accidental. This is a bit like using a utility from React Native and hoping it would work on React DOM.

it'd be great if those requirements were documented in the range for react in peerDependencies in react-reconciler; v0.12.0 claims "^16.0.0"

I think I already tried to explain this. There’s no relationship meant between them at all. The fact that this works is an accident. They happen to be released at the same time as an artefact of release cycle. That may change. There was no intentional compatibility between these packages. It may break in the future when our build optimisations become more aggressive.

I understand that; but I'd still expect the peerDep range to match what it's already compatible with, even if it won't be compatible with newer things - ie, 16.0.x - 16.4.x, or =16.4.1, etc. It doesn't have to provide future guarantees to provide correct current info.

@gaearon i don't actually care about using react-reconciler specifically, ftr - i just don't want to have to inline code unnecessarily. It'd be great if react exposed a "toTree" implementation of some kind though - then we'd be able to rely on that for any given future react version.

The react-reconciler package is compatible with any 16.x version of the react package. That’s what the peer dependency expresses.
There are no guarantees around compatibility between react-dom and react-reconciler packages. Just like there isn’t any between React DOM and React Native. This is why they don’t have peer dependencies on each other.

got it, that makes sense.

So whatever problem this PR is attempting to fix - could we add a test that would fail without this PR?


Use Collection on API Paginator presenter

This allows to decorate all model's attributes inside the Collection

Thanks. :)

:+1:


Provide IO implementation based on the Monad type class in Cyclops Pure

A Higher Kinded IO implementation based around the Monad type class and reactive-streams

Merged.


vertical scroll with ScrollView

Doesn't work vertical scroll if layout contains ScrollView. If exist some solutions could you tell me please?

Hi @kolandrey
The problem is not about the TableView, This is about the behaviour of the RecyclerView.
use NestedScrollView instead of ScrollView
Please go through NestedScrollView reference document for more information.

I tried to use NesstedScrollView but result is the same.
Any other suggestions? )


sails-postgresql  "AdapterError: Invalid connection name specified"

Node version: 6.9.0
Sails version (sails): 0.12.14
ORM hook version (sails-hook-orm): 1.0.9
DB adapter & version (e.g. sails-postgresql@5.55.5<EMAIL_ADDRESS>Their is an error getting populated while running database query in any API. This error is happening occasionally to all database queries if I restart the server this error will not appear, if I reload the server this error is most likely to appear 5-10 seconds.

Hey @deepthiv029, Do you think you would be able to reproduce this in an empty Sails v1 app and share it with us?


No export conditions for svelte in package.json

The package.json file of this library doesn't define any export condition for svelte, due to which this warning is shown.
[vite-plugin-svelte] WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte.

See https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition for details.

Should be fixed.


I'm using this

Your README says to let you know if I'm using it.  I'm letting you know.
Thanks!

Haha, thanks @devluxg :)


[STORM-2367] Documentation for streams API

+1 Nice explanation.
Since it's documentation you don't need to get +1 and even don't need to wait for 24hr. Or we can wait for more eyes. It's up to you.

@HeartSaVioR better to wait for 1-2 days to give a chance for others to review as this is not really urgent to push in short time to be part of some release. :)
I will review this PR by today.

Sure. :) Just would like to remind the bylaw for documentation.

+1, Nice summary of streams API. Thanks @arunmahadevan


ordering of autocompletion in gene search

In GitLab by @marcrr on Mar 2, 2016, 20:49
When you type a gene name in the gene search (e.g., myod), it completes to different species. It would be nice that the species appear in the same order as the pictures on the download page, i.e. starting with the important ones. For myod, I had to scroll down to find mouse, a less experienced user might have thought there isn't mouse at all.

In GitLab by @fbastian on Mar 2, 2016, 23:56
mentioned in commit<PHONE_NUMBER>598ab40ca5fc962b34967c2067ecf6

In GitLab by @fbastian on Mar 3, 2016, 24:00
mentioned in commit 20a29581daa83dbb679291ccd266d4f35458036c

In GitLab by @fbastian on Mar 3, 2016, 24:01
Done (you can try on devbgee). It will require an update of the database on the server bioinfo, when doing the release, so I keep this issue opened for now.

In GitLab by @fbastian on Mar 9, 2016, 15:09
Bioinfo database updated.

In GitLab by @fbastian on Mar 22, 2017, 18:58
Mentioned in commit 20a29581daa83dbb679291ccd266d4f35458036c


Suggestions for improving app-service-dotnet-create-api-app.md

I would like to suggest that the title of this article be changed, since I never actually published this API onto azure.  I would feel that this would be more of an overview on how to create a Web API project in Visual Studio and configure the ASP.NET project to be an Azure app.
The API app metadata section is not very clear since we don't actually publish this API to Azure.  I do understand that the settings in the JSON file relate to parts of an API app on Azure.
Based on the article of this title, I would of expected to create a Web API.  Publish this API to Azure and test that it worked from the new API app on azure.
Chad

The comments above no longer apply to this article.


Cannot read from private field in Svelte 5 component in Astro.

Epic package by the way!
I have been using this in my svelte components in my Asto site but one has started throwing an error since update to Astro 5, Svelte 5 & Vite 6.
    at __typeError (chunk-E2JEHENU.js?v=c02cd754:6:9)
    at __accessCheck (chunk-E2JEHENU.js?v=c02cd754:19:62)
    at __privateGet (chunk-E2JEHENU.js?v=c02cd754:20:46)
    at Object.get [as open] (chunk-B7RU2S4X.js?v=c02cd754:714:18)
    at HTMLAnchorElement.openGallery (BiggerPicture.svelte:87:7)

I'm not exactly sure whether this is an Astro error or an issue with BiggerPicture, to trouble shoot this? Any chance you have an idea to send me in the right direction?
Minimum example here https://stackblitz.com/edit/withastro-astro-fio3qbsq
npm run dev the lightbox should appear on the masonary on click, error in console.

I think it may be a conflict with Svelte 5 generally.
Please import bigger-picture or bigger-picture/vanilla for now if one of those works.
I removed the Svelte instructions from the readme and will investigate further when I have time. Thanks.


targetNamespace should be immutable in the webhook

It is my feeling that we shouldn't allow the targetNamespace to be changed for a package. The customer should uninstall and create a new package custom resource

[x] Change CRD to add status to PBC and Package
[x] Do deep copy for PBC and Package on reconciliation so we record previous state
[x] Add webhook check to validate targetNamespace value and reject modifications

This may only be broken if the install succeeds. I installed two hello eks apps in default and the second failed. I edited the package config to install the failed app in another namespace and the installation succeeded

Done


Symbol and Symbol.* polyfills are not provided for ie_mob/11.0.0

It seems that none of the recently added polyfills have been configured with support for IE mobile, even though they are needed also for the desktop counterparts?

Sorry about that. I don't have IE mobile available for testing.  If you do, can you try it and add the appropriate configuration?
https://cdn.polyfill.io/v2/docs/contributing/common-scenarios#adding-browsers

Also @nolanlawson may have devices / support data to hand?

Hm yeah, I see SauceLabs doesn't have any Windows Phone or Windows 10 Mobile devices; that's too bad.
In general I can say that you can typically match the mobile version to its desktop counterpart (e.g. IE11 mobile ~= IE11 desktop, Edge 12 mobile ~= Edge 12 desktop), but of course it's always better to test these things.
@triblondon If you can point me to a live site or something where I can just open a URL on the phone and then give you the result afterwards, then I'd be happy to grab a few phones and do that for you. :)

https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.iterator
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.search
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.toPrimitive
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.match
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.species
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.toStringTag
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.hasInstance
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.split
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.unscopables
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.isConcatSpreadable
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol.replace
https://cdn.polyfill.io/test/tests?mode=all&feature=Symbol

@JakeChampion Is there some way I can send you the data after running the tests? (E.g. a global JS object or something?) Looks like I'd need to screenshot the whole page, which could take awhile.

Yes, globalresults is the global results object.

Even better if you can run the director without a feature filter (to test all features) with mode=all and mode=control.  This gives us results for native implementations and results after polyfilling.
The work that then needs to happen is to diff the two resultsets, compare to the existing config.json files and PR the necessary changes.

Unfortunately it’s difficult for me to grab the globalresults object from a phone (haven’t figured out remote debugging yet), also at my immediate disposal I only have Insider builds… ^_^;;
Luckily I got approval to send y’all some phones, so hopefully those will be useful for you. If there are any versions that are still missing or you need more help, please get back to me and I’ll see if I can find the phone you need.

I suspect if that's the case we'd have similar problems to you trying to programmatically extract results from the phone.  But I certainly won't say no to test devices.  I'm in Tokyo and my colleagues are in London, but probably best to send them to London.  I'll send you the details by email.
Meanwhile if you know the rough support data for those devices feel free to just send us a PR.  Over-polyfilling is not normally a problem and helps people out quickly.


I'd like to join

Name:
Tomas Herceg
Projects:
https://github.com/riganti/dotvvm

Thanks Tomas. I've added you to this repo and to the #maintainers-committee in the Foundation Slack. Our first meeting is at 21:00 UTC tomorrow, info is in Slack.


VGG_ILSVRC_19_layers.caffemodel unreachable

Is there a mirror for VGG_ILSVRC_19_layers.caffemodel?
As for step 3 in the installation process, sh models/download_models.sh freezes at "http://www.robots.ox.ac.uk/~vgg/software/very_deep/caffe/VGG_ILSVRC_19_layers.caffemodel"
Same as in my browser...
Thanks! :smiley:

This address isn't responding for me at all right now. A mirror would be good.

Yeah, I just reformatted / reinstalled on my neural net machine, and it seems the entire robots.ox.ac.uk website is down. Hopefully it's just temporary wonkiness?

I have the same problem,Is there a mirror for the model?

Same for me, I have searched for VGG_ILSVRC_19_layers.caffemodel, but couldn't find any mirror copy.
Please advise.

The same here. Host is completely unreachable. Hope it will be fixed soon.

See https://github.com/jcjohnson/neural-style/issues/202

Great thanks!


jquery integration

Hi,
it would be really great if there was a jQuery integration.
Thanks,

How could this possibly be improved with jQuery?

It's not a matter of being improved, but more convenient. "formatMoney", for instance, could be applied on a number of fields that would be obtained by a jQuery selector and in addition it would be used in chaining.. FYI, I did see jQuery implementation as one of the roadmap points.

Ahh I see


Google_Http_MediaFileUpload::nextChunk fails for resumable upload if filesize is greater than chunksize

While uploading a large file (10 - 100MB) from GCS to Google Drive in a Google APP Engine application, the call "$status = $media->nextChunk($chunk);" fails and throws the following error:
HTTP Error: Unable to connect: 'fopen(): Unknown status code.'
Chunk size is set to 1MB. If the filesize is less than chunk size, it gets uploaded without any issues but if greater than chunk size, the above mentioned error is throw.
I am using PHP client library ver 1.0.6-beta. I tried upgrading the client library to 1.1.6. It doesn't help.
For more information on the issue please refer
https://code.google.com/p/googleappengine/issues/detail?id=12584

Do you have a stack trace for the error?

You can see the stack trace here:
http://jensen-education-system.appspot.com/test/test-upload-resumable

I'm still running into this issue.


MINOR: [CI] Fix ubuntu-lint to not install into system Python

Rationale for this change
Currently, the ubuntu-lint Docker build would install its Python dependencies directly into the system Python, which can fail depending on existing system Python packages.
See example here:
https://github.com/apache/arrow/actions/runs/10400929007/job/28802420047?pr=43539 where pip's dependency resolution fails with the following error message:
packaging.version.InvalidVersion: Invalid version: '2013-02-16'

What changes are included in this PR?
This PR switches to use a virtual environment, guaranteeing that we're not interfering with the system Python and that we're not bound by already installed Python packages.
Are these changes tested?
By CI.
Are there any user-facing changes?
No.

@kou I would like to merge this quickly so that we can get lint checks on https://github.com/apache/arrow/pull/43539


Add not found support for collection method

Currently Cards.collection (...collection: CardIdentifier[]): MagicEmitter<Card> ignores the not_found field returned by Scryfall API, so there is no way to give a feedback to the user about the identifiers for which a result has not been found.
I changed the processCollection to read that field to and use a new MagicBiEmitter<T, Q> class which works like MagicEmitter<T> except that:

it also emits not_found events for Q values, to be used for each value of the not_found array of the API response
the waitForAll method returns a { data: T[], not_found: Q[]} object (which is a breaking change)

This new emitter is used only by collection method to leave other methods unchanged since its waitForAll returns a different type.
I also created an AbstractMagicEmitter with the code shared by MagicEmitter and MagicBiEmitter to avoid code duplication (I'm open to suggestions about better names 😅).

@Yuudaari
🚧 not completed:  the new MagicBiEmitter class is missing a *[Symbol.asyncIterator] function, which causes the following error when there are multiple entries in not_found (just try to run the tests)
(node:13851) UnhandledPromiseRejectionWarning: TypeError: not_found is not iterable
    at Cards.<anonymous> (.../scryfall-sdk/out/api/Cards.js:274:42)
    at Generator.next (<anonymous>)
    at fulfilled (.../scryfall-sdk/out/api/Cards.js:5:58)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

How that function works is not completely clear to me since there are two different sets of objects now, and unfortunately I have no more time to work on this at the moment.

If you want to make large, complex changes, make an issue before creating a PR. If I disagree with the changes you want to make, and you've already made them all in a PR, it'll feel a lot worse than being shot down in an issue, before you've written it all.

As much as I hate to say it, this implementation kinda overcomplicated things a bit. It would have been better to discuss it first in an issue.
Using a bit of what you seemed to need as the base, I've committed an implementation  of vague "not found" support into the existing MagicEmitter, which is only used for the collection endpoint currently. It adds the not_found stuff to the array in waitForAll and it adds a separate notFound generator. (I also cleaned a couple things up in that commit, btw 😛)
I intend to publish this as 1.6.4 since it's nonbreaking, but I'm checking with you first — does it satisfy what you needed it for?

As much as I hate to say it, this implementation kinda overcomplicated things a bit. It would have been better to discuss it first in an issue.

No problem at all. I started to tinker with the code just to understand if the feature was already available and I found myself writing this even before thinking to open an issue.

I intend to publish this as 1.6.4 since it's nonbreaking, but I'm checking with you first — does it satisfy what you needed it for?

Yes I did some test and it works good. The only thing that doesn't completely convince me is the Promise<T[] & { not_found: NOT_FOUND[] }> type returned by waitForAll because you can't have a valid JSON representation of it (if you try to JSON.stringify() it the not_found is omitted of course).
I understand that it's the only way to make the change not-breaking, but I think it's worth to be highlighted at least in the documentation.
Anyway, it does exactly what i need 👍

Yeah, will do. I'll mention it in the docs.
As for it not being JSONifiable, I had a few reasons:

Wanting to JSONify it is probably(needs citation) going to be a bit of an uncommon use
You can always just extract the not_found property ie const jsonifiable = { data, not_found: data.not_found }
When printing out the data in the node console and browsers' developer tools, it shows the not_found property (so doing this shouldn't make it harder to debug)

Besides that I also had these two reasons:
4. It keeps the way to extract the main output of waitForAll simpler
5. Non-breaking (as mentioned previously)


Ignore nil REQUEST_URI

Finally merged in #22, which does the same thing. Apologies for letting this project sit untended for so long.


Add support for WebP decoding in tf.io.decode_image

System information

TensorFlow version (you are using): 2.5.0
Are you willing to contribute it (Yes/No): yes

Describe the feature and the current behavior/state.
tf.io.decode_image does not support WebP decoding. This makes using tfds and loading lsun/car impossible to use due to the fact that all images are encoded in WebP.
I'm somewhat surprised that DecodeImageV2Op doesn't support this relatively popular file format.
Will this change the current api? How?
No
Who will benefit with this feature?
All researchers trying to move away from using JPEG
Any Other info.
The code needed to decode WebP already exists in Tensorflow in:
https://www.tensorflow.org/io/api_docs/python/tfio/image/decode_webp

I think it is a dup of https://github.com/tensorflow/io/issues/930

It is a dupe indeed.


Notifications

Description of the new feature / enhancement
The freedom to move the notifications pop up to the top corner or wherever you would like to move it
Scenario when this would be used?
I am playing a game and a notification pops up and I accidentally click it,
I could be doing work and I accidentally click the notification pop up. It can get annoying if  this happens multiple times and can be hard to navigate back to where I was
Supporting information
No response

Sounds like the Do Not Disturb function would be a solution for this? It's in the Windows Settings.

/needinfo


Make compression encoding configuration more malleable

Motivation
Alternative approach to #1727, enable callers to influence compression encoding priority. Also changes the default order so that Zstd comes before Gzip if enabled (which happens when the zstd Cargo feature is explicitly enabled).
Solution
Implement an internal array while avoiding making changes to existing public API.
cc @CapCap

Not completely sure whether this actually solves the original issue described in #1727. IMO it would be better if the config wrapper allowed overwriting the EnabledCompressionEncodings instead of appending to it.


salmon quant and samtools errors

Hello
First let me say that, I am able to successfully run the test profile (with docker) on my system:
nextflow run nf-core/rnaseq -profile test,docker --aligner hisat2 -r 1.4.2 --pseudo_aligner salmon
However, when trying to align reads to the BK virus genome and associated GTF file, I got the following salmon quant error:
https://gist.github.com/pcantalupo/76ecb97aa18f026d9d080f7e72a1f9d8
I removed salmon from the command line and now I have a samtools error:
https://gist.github.com/pcantalupo/86240abed67313bb1354e063c5d70d05
Please advise...thank you

First Gist:
salmon was only able to assign 5 fragments to transcripts in the index, but the minimum number of required assigned fragments (--minAssignedFrags) was 10. This could be indicative of a mismatch between the reference and sample, or a very bad sample.  You can change the --minAssignedFrags parameter to force salmon to quantify with fewer

That looks like a Salmon error:

is the data fine?
is the GTF file appropriate, does it have gene_idand other identifiers?

  samtools sort: couldn't allocate memory for bam_mem

Not enough memory - how much did you specify exactly?

For the first Gist error, I incorrectly used a subsample of reads that only had a few reads that could align to my virus of interest, BK virus. So, this issue is resolved. I am now using 10K reads from SRR11074360 of which over 1K will align to BKV.
But as for the second Gist error (the Samtools sort error), I tried to fix this by correctly specifying how many cpus and memory I have in my Docker installation (same as https://github.com/nf-core/rnaseq/issues/410#issuecomment-617270032). I changed command line to:
nextflow run nf-core/rnaseq -profile docker --aligner hisat2 -r 1.4.2 --reads 'data/SRR11074360_{1,2}_10k.fastq' --reverseStranded --max_cpus 3 --max_memory 12 -c config_bkv.txt
But am getting a similar error to #410
Caused by:
  Process `hisat2_sortOutput (SRR11074360_1_10k)` terminated with an error exit status (1)

Command executed:
  samtools sort \
      SRR11074360_1_10k.bam \
      -@ 3 -m-1999999996 \
      -o SRR11074360_1_10k.sorted.bam
  samtools index SRR11074360_1_10k.sorted.bam

Command exit status:  1
Command output:  (empty)
Command error:  samtools sort: couldn't allocate memory for bam_mem

How do I set the amount of memory that samtools sort will use?  Thank you

This issue is resolved based on https://github.com/nf-core/rnaseq/issues/410#issuecomment-658151566


[Feature Request] Cron-style scheduling

Request to support cron-style scheduling. For example:
import schedules, times, asyncdispatch

schedules:
  cron(expr="0 0 * * *", id="tick"):
    echo("tick", now())

  cron(expr="@every 1m", id="atick", async=true):
    echo("tick", now())
    await sleepAsync(3000)

Update: I'm working on this issue at the moment. It's a shame nim-lang doesn't have cron expression parser library so I have to write one first.

Close this issue since this feature has been released in v0.2.0.
Will keep improving it and ensuring it's stable.


Apache access.log format - help with right settings

Hello guys,
Please i have access.log in following format:
adsl-dyn252.78-98-241.t-com.sk - - [16/Feb/2023:00:00:10 +0100] "GET /sexi-zona HTTP/2.0" 200 24661 "https://www.google.com/" "Mozilla/5.0 (Linux; Android 10; Lenovo TB-X606F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"
adsl-dyn252.78-98-241.t-com.sk - - [16/Feb/2023:00:00:11 +0100] "GET /themes/mydomain/cache/v_8656_251cd6b5ab564d56b7f67578f71cd521_all.css HTTP/2.0" 200 70938 "https://mydomain.sk/sexi-zona" "Mozilla/5.0 (Linux; Android 10; Lenovo TB-X606F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"
adsl-dyn252.78-98-241.t-com.sk - - [16/Feb/2023:00:00:11 +0100] "GET /img/mydomainsk-logo_mobile-1621751882.jpg?1651930482 HTTP/2.0" 200 15200 "https://mydomain.sk/sexi-zona" "Mozilla/5.0 (Linux; Android 10; Lenovo TB-X606F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"
<IP_ADDRESS> - - [16/Feb/2023:00:00:11 +0100] "GET /img/cms/kategorie/sexi_zona_zlava.png HTTP/2.0" 200 57357 "https://mydomain.sk/sexi-zona" "Mozilla/5.0 (Linux; Android 10; Lenovo TB-X606F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"
This is my apache config file - /etc/apache2/apache2.conf
LogFormat "%v:%p %h %l %u %t \"%r\" %>s %O \"%{Referer}i\" \"%{User-Agent}i\"" vhost_combined
LogFormat "%h %l %u %t \"%r\" %>s %O \"%{Referer}i\" \"%{User-Agent}i\"" combined
LogFormat "%h %l %u %t \"%r\" %>s %O" common
LogFormat "%{Referer}i -> %U" referer
LogFormat "%{User-agent}i" agent
Please what would be the right settings?
I have tried:
goaccess /var/www/html/access.log --log-format='%h %^[%x] "%r" %s %b %^: %D %^"%R" "%u"' --datetime-format='%d/%b/%Y:%H:%M:%S %z' --tz=Europe/Berlin --date-spec=min
Got error:
==356713== Format Errors - Verify your log/date/time format
Thanks , and i would like also to see only valid/unique visitors without crawlers / bots.

I have solved it by adding:
--no-ip-validation

After many tried, i have found that with following additional parse option command i can show the log
--no-ip-validation
But is there any way, how to show only unique visitors (Exclude crawlers / bots) like with this command? Because in my case it's not working :( ...
--ignore-crawlers
If i parse the output to show only bots/crawlers, it shows 0 VISITORS: (For example)
goaccess /var/www/html/access.log --log-format=COMMON --no-ip-validation --crawlers-only -o /var/www/html/admin/report/report.html

Okay, i will answer myself.
I have installed remoteip mod in apache, and now it seems it works. The problem was the hostname instead of IP.

Sounds like a format issue. This should work for the lines you posted above:
goaccess access.log --log-format='%h %^[%x] "%r" %s %b "%R" "%u"' --datetime-format='%d/%b/%Y:%H:%M:%S %z' --no-ip-validation

Closing this. Feel free to reopen it if needed.


factoring zoom in graphedit port size

Tested a bit and seems to mitigate the issue of the ports not snapping? Id ask to merge to test on a larger scale.
EDIT: Works for snapping connections but not for dragging them out

Can this be for 4.0 since in my view it is a bug?
However, you mentioned it fails for dragging out, so the fix is incomplete.

Nevermind, doesn't address the issue.


allow for empty callback URL path

Summary
When configuring an empty path for the OIDC callback URL the used http MUX panics with "http: invalid pattern".
This fix uses the MUX only for non-empty callback paths. If the path is empty the handler is directly used
for the local http server without any MUX.
Release Note

Support for OIDC callback URLs without path for usage of interactive mode
Documentation

Fixes: #1048

In what case is the callback URL empty?

I wanted to use with a local OIDC provider which was already configured with fixed callback URL for online scenario,

@bobcallaway What do you think about this? I’m not sure the use case, but it does clean up an error condition

@bobcallaway What do you think about this? I’m not sure the use case, but it does clean up an error condition

I'd prefer something like this (mostly b/c it has a test, and it will only listen on / instead of any URL endpoint like the code in this PR):
diff --git a/pkg/oauthflow/interactive.go b/pkg/oauthflow/interactive.go
index dfc1f0c..eee7bad 100644
--- a/pkg/oauthflow/interactive.go
+++ b/pkg/oauthflow/interactive.go
@@ -184,6 +184,9 @@ func startRedirectListener(state, htmlPage, redirectURL string, doneCh chan stri
                if err != nil {
                        return nil, nil, err
                }
+               if urlListener.Path == "" {
+                       urlListener.Path = "/"
+               }

                listener, err = net.Listen("tcp", urlListener.Host)
                if err != nil {
diff --git a/pkg/oauthflow/interactive_test.go b/pkg/oauthflow/interactive_test.go
index 78591bc..3c55811 100644
--- a/pkg/oauthflow/interactive_test.go
+++ b/pkg/oauthflow/interactive_test.go
@@ -16,10 +16,27 @@ package oauthflow

 import (
        "bytes"
+       "net/http"
+       "net/http/httptest"
        "os"
        "testing"
 )

+// TestIssue1048 ensures that startRedirectListener does not panic due to the lack of a specified path in the redirectURL
+func TestIssue1048(t *testing.T) {
+       doneCh := make(chan string)
+       doneErr := make(chan error)
+       // this tests calling startRedirectListener with a redirectURL without a trailing slash
+       s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }))
+       t.Log(s.URL)
+       defer func() {
+               close(doneCh)
+               close(doneErr)
+               s.Close()
+       }()
+       startRedirectListener("something", "something", s.URL, doneCh, doneErr)
+}
+
 func TestInteractiveFlow_IO(t *testing.T) {
        t.Run("default", func(t *testing.T) {
                f := &InteractiveIDTokenGetter{}

@mandelsoft Would you like to update this PR to what Bob posted?

Closing due to no activity, feel free to reopen


Cow: Watch pg4y.com

Cow requests the watch of the watch_keyword pg4y\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

pg4y\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


tensorflow installation windows 10 python idle 3.6

C:\WINDOWS\system32>python
Python 3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 08:06:12) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

import tensorflow
Traceback (most recent call last):
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python\pywrap_tensorflow.py", line 18, in swig_import_helper
fp, pathname, description = imp.find_module('_pywrap_tensorflow', [dirname(file)])
File "C:\Users\RAHUL\AppData\Local\Programs\Python\Python36\lib\imp.py", line 296, in find_module
raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named '_pywrap_tensorflow'

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python_init_.py", line 54, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python\pywrap_tensorflow.py", line 28, in
_pywrap_tensorflow = swig_import_helper()
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python\pywrap_tensorflow.py", line 20, in swig_import_helper
import _pywrap_tensorflow
ModuleNotFoundError: No module named '_pywrap_tensorflow'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow_init_.py", line 24, in
from tensorflow.python import *
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python_init_.py", line 60, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python\pywrap_tensorflow.py", line 18, in swig_import_helper
fp, pathname, description = imp.find_module('_pywrap_tensorflow', [dirname(file)])
File "C:\Users\RAHUL\AppData\Local\Programs\Python\Python36\lib\imp.py", line 296, in find_module
raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named '_pywrap_tensorflow'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python_init_.py", line 54, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python\pywrap_tensorflow.py", line 28, in
_pywrap_tensorflow = swig_import_helper()
File "C:\Users\RAHUL\AppData\Roaming\Python\Python36\site-packages\tensorflow\python\pywrap_tensorflow.py", line 20, in swig_import_helper
import _pywrap_tensorflow
ModuleNotFoundError: No module named '_pywrap_tensorflow'
Error importing tensorflow.  Unless you are using bazel,
you should not try to import tensorflow from its source directory;
please exit the tensorflow source tree, and relaunch your python interpreter
from there.

exit()

C:\WINDOWS\system32>rm -rf
'rm' is not recognized as an internal or external command,
operable program or batch file.

@rahul21rajendran ,
Looks like there is some issue with installation of python and tensorflow, can you uninstall and try reinstalling the both?

Hi guys,
I am having a similar issue on Mac while using a virtualenv. Any help would be greatly appreaciated:

(mlocad) (base) youssouf-traores-macbook-pro:retraining Youssoufj$ python retrain.py --image_dir ~/flower_photos
Traceback (most recent call last):
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow.py", line 58, in <module>
    from tensorflow.python.pywrap_tensorflow_internal import *
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in <module>
    _pywrap_tensorflow_internal = swig_import_helper()
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
    _mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/imp.py", line 242, in load_module
    return load_dynamic(name, filename, file)
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/imp.py", line 342, in load_dynamic
    return _load(spec)
ImportError: dlopen(/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so, 6): Symbol not found: _SecKeyCopyExternalRepresentation
  Referenced from: /Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.1.dylib
  Expected in: /System/Library/Frameworks/Security.framework/Versions/A/Security
 in /Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.1.dylib

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "retrain.py", line 131, in <module>
    import tensorflow as tf
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/__init__.py", line 28, in <module>
    from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/__init__.py", line 49, in <module>
    from tensorflow.python import pywrap_tensorflow
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow.py", line 74, in <module>
    raise ImportError(msg)
ImportError: Traceback (most recent call last):
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow.py", line 58, in <module>
    from tensorflow.python.pywrap_tensorflow_internal import *
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in <module>
    _pywrap_tensorflow_internal = swig_import_helper()
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
    _mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/imp.py", line 242, in load_module
    return load_dynamic(name, filename, file)
  File "/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/imp.py", line 342, in load_dynamic
    return _load(spec)
ImportError: dlopen(/Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so, 6): Symbol not found: _SecKeyCopyExternalRepresentation
  Referenced from: /Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.1.dylib
  Expected in: /System/Library/Frameworks/Security.framework/Versions/A/Security
 in /Users/Youssoufj/Projects/tensorf/retrain/september/retraining/mlocad/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.1.dylib

Failed to load the native TensorFlow runtime.

See https://www.tensorflow.org/install/errors

for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

Thank you for your support
On Wed, 11 Sep 2019, 11:48 am oanush<EMAIL_ADDRESS>wrote:

@rahul21rajendran https://github.com/rahul21rajendran ,
Looks like there is some issue with installation of python and tensorflow,
can you uninstall and try reinstalling the both?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/32388?email_source=notifications&email_token=AM4GRDSWBQZ7YCOYTOXLJA3QJCESZA5CNFSM4IVLMVY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6NL6SI#issuecomment-530235209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM4GRDWWK7JRCHW2PX6JXU3QJCESZANCNFSM4IVLMVYQ
.

@rahul21rajendran,
Can you please let us know if the issue was resolved so that we can proceed for closure.Thanks!

my issue is solved

https://github.com/tensorflow/tensorflow/issues/32627


[language] Make the e2e tests faster, especially max key rotations test

Makes the e2e tests faster by:

Reducing the number of proptest examples generated in one test
Batching the transactions in max_child_accounts_for_vasp_recovery_address and not applying the final transaction results, but making sure that they're all executed.

This PR drops the time taken by a full language/e2e-testsuite test from ~353 seconds to 30-45 seconds.

/land


Default project builds itself in the dist folder instead of the root

When I create a project with vue init webpack, I npm install then I build the project with npm run build, the project is built in a dist folder, instead of at the root of my project.

I'm using vue-cli 2.5.1 and macOS 10.12.1. I was able to reproduce the bug twice.
Here's the configuration I'm using :
? Generate project in current directory? Yes
? Vue build standalone
? Use ESLint to lint your code? Yes
? Pick an ESLint preset AirBNB
? Setup unit tests with Karma + Mocha? No
? Setup e2e tests with Nightwatch? No

That's how it is supposed to work. The /dist folder is supposed to be deployed. This is practically "default" behaviour for frondend builds in the industry right now.
I don't see any issue with that. Do you have a specific problem with it?

OK, now I understand. I was confused because the docs are not very clear (the dist/ folder is not mentioned in the project structure : http://vuejs-templates.github.io/webpack/structure.html).
I would like to compile the assets directly in the project root (because I'm using GitHub Pages). How could I modify the config files to do so ?

I would rather change this line:
  assetsRoot: path.resolve(__dirname, '../dist'),
//to:
  assetsRoot: path.resolve(__dirname, '../docs'),

and then use this option for github pages:

I'll use Surge, it will be a lot easier ! 😄
I think it would be worth mentioning the dist/ folder in the documentation.


Add deprecation notice for old_style error capturing.

Addressing #8564.

i’m still fine-tuning details for the deprecating old_style error. How “loud”/“annoying” should it be for 0.58?
For anyone NOT extending Numba, they probably never set NUMBA_CAPTURED_ERRORS thus I don’t think we should annoy them.  But, that also means it is hard to reach extension writers who are probably unknowingly relying on old_style.
Maybe we can make the old-style capturing logic warn at this release? (I have not-yet-pushed code for this)

I think making it warn in this release (and calling it deprecated) is worth doing - since the documentation is unlikely to be noticed otherwise, only adding the documentation and not warnings in this release is almost effectively a "no-op" if many will not notice until 0.59.

post #9127 this has conflicts.

Merged main and resolved conflicts related to importing at: https://github.com/numba/numba/pull/9090/commits/58d6e9a07b6517236c350e20c43c3d905f4c1a27

@gmarkall this needs re-approval post merge of main, please.

Re-approving following the merge from main.

Excellent, thank you.


NIFI-1213 (branch 0.x) Added the possibility to register FlowFile ass…

…ertions in mock framework

@pvillard31 all merged, but it seems like the auto-close hook didn't work. Could you please close this PR?


Generate attribute methods once instead of on each object creation

I was investigating memory usage in my app and I found that jc-validates_timeliness created a lot of strings on each request.
It turns out that the attribute methods for timeliness are generated at each object creation instead of once, at first creation like AR attribute methods. Since creating those methods uses module_eval it's quite slow when it's done each Model.new!
This PR prevents the duplication by following the same pattern as ActiveRecord.
Benchmark for speed improvement:
# rails console
require 'benchmark/ips'
Benchmark.ips do |x|
  x.report("timeliness generated attributes speed") {
    Rental.new # a class in my app that has 3 timeliness validations
  }
end

Without patch
Calculating -------------------------------------
timeliness generated attributes speed
                       264.000  i/100ms
-------------------------------------------------
timeliness generated attributes speed
                          2.777k (± 5.1%) i/s -     13.992k

With patch
Calculating -------------------------------------
timeliness generated attributes speed
                       988.000  i/100ms
-------------------------------------------------
timeliness generated attributes speed
                         12.068k (± 4.6%) i/s -     60.268k

That's a 4X speed improvement in creating AR objects in my application.
Additionally it names the module to make it easier to see in the ancestor chain.
Rental.ancestors
=> [Rental(id: integer, ...),
 Rental::GeneratedValidatesTimelinessMethods, <== instead of #<Module:0x007fc165522078>
 PaperTrail::Model::InstanceMethods,
...

FYI, the failed tests failed before my patch too. I looks like it has to do with daylight saving time.

:clap:
I was just doing the same thing, using derailed_benchmarks, and saw a large amount of memory required by jc-validates_timeliness. Not seeing any difference after your patch though, and the memory is anyway used by timeliness dependency.
Also, it seems this fork is no longer maintained. I just switched to https://github.com/appfolio/validates_timeliness, which is currently supporting Rails 4.2 and seems to be quite active. You might send your PR there.

Thanks for the note @dgilperez. The patch doesn't reduce total allocations, but makes sure that methods are allocated only once instead of on every object creation.
I've been trying to become maintainer of the original gem validates_timeliness in order to pull the different branches back together.

Great! Please leave a comment here if you manage to merge all those things together.

Should this be closed since the PR was merged?

I don't follow the status of this fork right now so go ahead and close this PR if you think it's right.

Thanks @monkbroc, unfortunately I'm not a maintainer :)
In the process of updating my app to Rails 4.2 yesterday I had to take another look at validates_timeliness and I've gotta say, I'm confused about which version to use. There seems to be at least three actively developed versions! Do you have any clues?

This fork worked ok for me, but I'm sure there are more up to date ones.

Thanks @monkbroc. I guess the way forward would be to get an agreement from all existing fork maintainers to redirect all issues and PR's to a new repo. And for that repo to contain a merging of the best bits of each fork. I'm sure it'll happen one day :)


CacheEntryEvent  getOldValue()

The Spec says at isOldValueAvailable()
Whether the old value is available.
Should be precise about the fact, when the cache implementation sends an old value.
In case of a remove event this is not totally obvious.
TODO
The Spec needs to be updated at the following places:

CacheEntryEvent.getOldValue()
CacheEntryEvent.isOldValueAvailable()
CacheEntryListenerConfiguration.isOldValueRequired()
CacheEntryUpdatedListener

Enhancements to the TCK
Enhancements to the RI

Thought it is an easy clarification, but it isn't. I'll just
Sending on a remove the value as null and oldValue as the removed one, does not work with the TCK. So it is evident that the oldValue is not to be used for the remove event.
The TCK has no tests at all for CacheEntryEvent.getOldValue() and CacheEntryEvent.isOldValueAvailable().
The RI implementation thorws UnsuppportedOperationException, which is not in the Spec.
  @Override
  public V getOldValue() throws UnsupportedOperationException {
    if (isOldValueAvailable()) {
      return oldValue;
    } else {
      throw new UnsupportedOperationException("Old value is not available for key");
    }
  }

Test with TCK git master.
Used EHCache coordinates:
            <properties>
                <!--################################################################################################################-->

                <!-- Implementation coordinates -->
                <implementation-groupId>org.ehcache</implementation-groupId>
                <implementation-artifactId>ehcache</implementation-artifactId>
                <implementation-version>3.0.1</implementation-version>

                <!-- CacheManager and Cache implementation. Used by the unwrap tests. -->
                <CacheManagerImpl>org.ehcache.CacheManager</CacheManagerImpl>
                <CacheImpl>org.ehcache.Cache</CacheImpl>
                <CacheEntryImpl>org.ehcache.Cache$Entry</CacheEntryImpl>

                <!--The MBeanServer, so that the TCK can resolve it. -->
                <javax.management.builder.initial>org.ehcache.jsr107.internal.tck.Eh107MBeanServerBuilder
                </javax.management.builder.initial>
                <org.jsr107.tck.management.agentId>anyvalue</org.jsr107.tck.management.agentId>

                <!--################################################################################################################-->

            </properties>

I am running the TCK with:
mvn -fn clean install

The -fn was added since two tests are failing, so the build continuous.
Result:
[INFO] Reactor Summary:
[INFO]
[INFO] TCK Parent ......................................... SUCCESS [  1.468 s]
[INFO] App Domain ......................................... SUCCESS [  3.436 s]
[INFO] Test Domain ........................................ SUCCESS [  3.181 s]
[INFO] Cache Tests ........................................ SUCCESS [  6.177 s]
[INFO] Implementation Tester .............................. SUCCESS [  0.018 s]
[INFO] Implementation Tester - Specific Implementation .... FAILURE [ 34.007 s]
[INFO] CDI/Weld Annotations Test Harness .................. FAILURE [  0.045 s]
[INFO] Implementation Tester - CDI Annotations ............ FAILURE [  0.013 s]
[INFO] Spring Annotations Test Harness .................... FAILURE [  0.005 s]
[INFO] Implementation Tester - Spring Annotations ......... FAILURE [  0.006 s]
[INFO] Guice Annotations Test Harness ..................... FAILURE [  0.004 s]
[INFO] Implementation Tester - Guice Annotations .......... FAILURE [  0.007 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48.583 s
[INFO] Finished at: 2016-06-16T10:15:23+02:00
[INFO] Final Memory: 49M/548M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.9:test (default-test) on project specific-implementation-tester: There are test failures.
[ERROR]
[ERROR] Please refer to /home/jeans/ideaWork/jsr107-maintenance/jsr107tck/implementation-tester/specific-implementation-tester/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal on project cdi-weld-annotations-test-harness: Could not resolve dependencies for project javax.cache:cdi-weld-annotations-test-harness:jar:1.1.0-SNAPSHOT: Failure to find org.jsr107.ri:cache-annotations-ri-cdi:jar:3.0.1 in http://repository.jboss.org/nexus/content/groups/public-jboss/ was cached in the local repository, resolution will not be reattempted until the update interval of jboss.maven.repo has elapsed or updates are forced -> [Help 2]
[ERROR] Failed to execute goal on project cdi-annotations-tester: Could not resolve dependencies for project javax.cache:cdi-annotations-tester:jar:1.1.0-SNAPSHOT: Failure to find org.jsr107.ri:cache-annotations-ri-cdi:jar:3.0.1 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 2]
[ERROR] Failed to execute goal on project spring-annotations-test-harness: Could not resolve dependencies for project javax.cache:spring-annotations-test-harness:jar:1.1.0-SNAPSHOT: Failure to find org.jsr107.ri:cache-annotations-ri-spring:jar:3.0.1 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 2]
[ERROR] Failed to execute goal on project spring-annotations-tester: Could not resolve dependencies for project javax.cache:spring-annotations-tester:jar:1.1.0-SNAPSHOT: Failure to find org.jsr107.ri:cache-annotations-ri-spring:jar:3.0.1 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 2]
[ERROR] Failed to execute goal on project guice-annotations-test-harness: Could not resolve dependencies for project javax.cache:guice-annotations-test-harness:jar:1.1.0-SNAPSHOT: Failure to find org.jsr107.ri:cache-annotations-ri-guice:jar:3.0.1 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 2]
[ERROR] Failed to execute goal on project guice-annotations-tester: Could not resolve dependencies for project javax.cache:guice-annotations-tester:jar:1.1.0-SNAPSHOT: Failure to find org.jsr107.ri:cache-annotations-ri-guice:jar:3.0.1 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :specific-implementation-tester
[INFO] Build failures were ignored.

The hopping point is:
[ERROR] Failed to execute goal on project cdi-weld-annotations-test-harness: Could not resolve dependencies for project javax.cache:cdi-weld-annotations-test-harness:jar:1.1.0-SNAPSHOT: Failure to find org.jsr107.ri:cache-annotations-ri-cdi:jar:3.0.1

Here is the full log of the build.
build-log.txt

Whether the old value is available is set in the CacheEntryListenerConfiguration interface.
/**

Determines if the old value should be provided to the
{@link CacheEntryListener}.

@return true if the old value is required by the

    {@link CacheEntryListener}

*/
boolean isOldValueRequired();
There is a MutableCacheEntryListenerConfiguration class which allows it to be passed in. A user defined CacheEntryListener is allowed to implement as many of the sub-interfaces as it wants.
The usual thing is that the old value is always known to remove, expire and update, but not to created. However the spec does not say instead making it user selectable at time of creating the MutableCacheEntryListenerConfiguration.
Because a user can set this to true for any type of listener an implementation must be able to supply the old value if required. Of course the value will always be null for create.
Added a test to check that the old value is returned when set to true.
The RI always sets the old value for update.
//created
dispatcher.addEvent(CacheEntryCreatedListener.class, new RICacheEntryEvent<K, V>(this, key, value, EventType.CREATED));
//updated
dispatcher.addEvent(CacheEntryUpdatedListener.class,
new RICacheEntryEvent<K, V>(this, key, value, oldValue,
EventType.UPDATED));
//expired
dispatcher.addEvent(CacheEntryExpiredListener.class,
new RICacheEntryEvent<K, V>(this, key, expiredValue, EXPIRED));
//removed
dispatcher.addEvent(CacheEntryRemovedListener.class,
new RICacheEntryEvent<K, V>(this, key, value, REMOVED));
Updated CacheEntryEvent to implement getValue from Cache.Entry so that behaviour can be specified and added JavaDoc as follows:
/**

Returns the value stored in the cache when this entry was created.

The value will be available
for {@link CacheEntryCreatedListener}, {@link CacheEntryExpiredListener}
and {@link CacheEntryRemovedListener}
if {@link CacheEntryListenerConfiguration#isOldValueRequired()} is true.

@return the value corresponding to this entry
*/
public abstract V getValue();

/**

Returns the previous value, that existed prior to the
modification of the Entry value. The old value will be available
for {@link CacheEntryUpdatedListener}
if {@link CacheEntryListenerConfiguration#isOldValueRequired()} is true.

@return the previous value or null if there was no previous value
*/
public abstract V getOldValue();

/**

Whether the old value is available. The old value will be available
for {@link CacheEntryUpdatedListener}
if {@link CacheEntryListenerConfiguration#isOldValueRequired()} is true.

@return true if the old value is populated
*/
public abstract boolean isOldValueAvailable();


Provide graphviz + Dependencies

Please consider adding the graphviz package plus its dependencies to the stack. https://packages.ubuntu.com/bionic/graphviz
It would be nice to have it, so PlantUML can be executed in Cloud Foundry.
We´ve done this with cflinuxfs2, but cflinuxfs3 is missing several dependencies for graphwiz, so plantuml can not be used to its full potential.

Sorry for the delay @escar42, we're planning to evaluate the impact of adding graphviz soon.

@escar42 We created an investigative story regarding this issue; we will play that one first:
https://www.pivotaltracker.com/n/projects/1042066/stories/165449211

This will be included when our next release is out. Should be 9/3 @slevine


Benchmarking and testing Python bindings

:tada: This PR is included in version 0.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature new bayes

This changes the interface to the bayesian sampling and adds two new samplers. Now the interface is similar to the MLE part. I have also updated the docs for the new interface.

Codecov Report

Merging #349 into master will decrease coverage by 0.37%.
The diff coverage is 62.26%.

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   71.36%   70.99%   -0.38%
==========================================
  Files          96      101       +5
  Lines       11907    12118     +211
==========================================
+ Hits         8498     8603     +105
- Misses       3409     3515     +106


Error in SSR if server build with bundleDependencies=all

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [x] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
Angular CLI: 6.2.1
Node: 8.11.2
OS: darwin x64
Angular: 6.1.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker
Package                            Version
@angular-devkit/architect          0.8.1
@angular-devkit/build-angular      0.8.1
@angular-devkit/build-ng-packagr   0.8.1
@angular-devkit/build-optimizer    0.8.1
@angular-devkit/build-webpack      0.8.1
@angular-devkit/core               0.8.1
@angular-devkit/schematics         0.8.1
@angular/cdk                       6.4.7
@angular/cli                       6.2.1
@angular/flex-layout               6.0.0-beta.18
@angular/material                  6.4.7
@angular/pwa                       0.8.1
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.2.1
@schematics/angular                0.8.1
@schematics/update                 0.8.1
ng-packagr                         4.1.1
rxjs                               6.3.2
typescript                         2.9.2
webpack                            4.18.0
Repro steps
I use universal-starter, only change one line in angular.json:
"server": {
  "configurations": {
    "production": {
      "bundleDependencies": "all", <= added
      ...

$ git clone -b issue-error-with-bundleDependencies  git@github.com:clarkorz/universal-starter.git
$ cd universal-starter
$ yarn install
$ yarn build:ssr
$ yarn serve:ssr

Access http://localhost:4000 in browser.
The log given by the failure
Error: No NgModule metadata found for '[object Object]'.
    at NgModuleResolver.resolve (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:11962:27)
    at CompileMetadataResolver.getNgModuleMetadata (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:10604:47)
    at JitCompiler._loadModules (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:23914:55)
    at JitCompiler._compileModuleAndComponents (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:23895:40)
    at JitCompiler.compileModuleAsync (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:23855:41)
    at CompilerImpl.compileModuleAsync (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/platform-browser-dynamic/bundles/platform-browser-dynamic.umd.js:195:35)
    at /Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@nguniversal/express-engine/bundles/express-engine.umd.js:95:25
    at new ZoneAwarePromise (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/zone.js/dist/zone-node.js:891:29)
    at getFactory (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@nguniversal/express-engine/bundles/express-engine.umd.js:81:12)
    at View.engine (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@nguniversal/express-engine/bundles/express-engine.umd.js:60:13)

Desired functionality
bundleDependencies=all should work as same as bundleDependencies=none.
Mention any other details that might be useful
No.

I think what's happening here, is that you have 2 instances of Angular providers running in parallel.
One in the server.bundle javascript files since it's being bundled and another which is being required from the server.js
//cc @vikerman

Is it related to https://github.com/angular/angular-cli/issues/8616 ?

It seems it is a duplicate of #8616.

Have a repro. First need to figure out why JitCompiler is getting involved at all sine we pass in the NgFactory to the express engine.

@vikerman Any update on this issue or workaround? I'm running into it with latest Angular CLI and this seems to be a hard blocker atm.

@vikerman
Hello,
I don't want to be annoying but did you make any progress?
I'm at a point where we really need it. So my plan was to bundle it myself with webpack.
So I could avoid the bundleDependencies=all. But ofcourse this also causes the same problem.
No NgModule metadata found for '[object Object]'.
I tried to debug it a bit, but I'm not knowable of the internal workings of Angular itself.

@vikerman
I tried to debug some stuff.
And I'm probably already going to say stuff you already know.
https://github.com/angular/universal/blob/83f659777a1f7914c357d5c0eb72705b04dc94ea/modules/express-engine/src/main.ts#L118
When using bundleDependencies=all this check returns false.
I have no idea why. When enabling or disabling bundleDependencies the result of
Object.getPrototypeOf(moduleOrFactory) seemed to be the 'same'.
I removed the check locally to see if it would magically work. But it seems we then have a whole bunch of other errors. So I assume the generated webpack bundle is 'wrong'. My knowledge of webpack is also to limited to say something useful (I tried to compare the bundles, but I couldn't really make much of it)

We were ending up with two copies of Angular due to the bundling setup we have for express-engine. We think we finally have a solution(See PR above) and turning on bundleDependencies on by default for version 8.0 of @nguniversal/express-engine. Still end up with a dist/server.js and dist/server/main.js - But that's still lot better than shipping entire node_modules.

@ErazerBrecht - We think we have a solution for version 8.0.

@vikerman
I saw the PR ;)
I'm very exited to test it out.
Thx for update!
Enjoy your weekend!

Was this fixed with 8.2 ?

The new 8.x versions of @nguniversal/express-engine schematics creates a setup which avoid this issue.
If you are upgrading to 8.x version please follow https://github.com/angular/universal/blob/master/docs/v8-upgrade-guide.md

Would it work with ASP. Net/.Net Core? Can you please add instructions for that in readme docs?

@naveedahmed1, yeah this should also work for the .net implementation. You’d need to export ngAspnetCoreEngine from main.server.ts.
Closing this issue as it should be solved as per @vikerman’s comment.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.


Fix issues with using BigQuery Connection created from UI

This PR creates a constant for CONN_TYPE_TO_DATABASE and adds gcpbigquery to it. It then uses this for other places .
closes https://github.com/astro-projects/astro/issues/252

Would love reviews on this @utkarsharma2 @tatiana


use CDP screencast API to record mp4 videos - extremely useful for headless mode

The problem
Currently, there is no real option without complex scripts to record in headless mode
CDP provides screencast API selenium already implemented but does not use it (and no guides on using it)
frameworks like cypress puppeteer and playwright use it already.
start screen cast
devTools.send(Page.startScreencast(Optional.of(Page.StartScreencastFormat.JPEG), Optional.of(100), Optional.of(1920), Optional.of(1080), Optional.of(1)));
stop screencast
devTools.send(Page.stopScreencast())
and an event listener which receives the raw data (which are the frames)
https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-startScreencast
https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-stopScreencast
we need to compose from all the frames an mp4 video on the finish.
@asolntsev suggested opening this issue.

we need this feature!
thanks!!!

@nir-tal-talkspace Nice idea. Would be great to have such a feature.
Now somebody should implement it and submit a pull request. any help is welcome.

Hopefully is implemented in https://github.com/selenide/selenide/pull/2768


Parcel question

Unsure what to think about this, and doing other work right now. Just wondering if this raises any concern?

(Screenshot of web-browser console log)

I've been keeping an eye on this thread https://github.com/parcel-bundler/parcel/issues/6685
If we continue to experience this after we remove Chakra, I'll investigate.

@WinstonHall Now that Chakra is gone from the codebase, report any further issues you experience that you believe may be related to Parcel here.


Question about Port

What is your question?
when 0.7.1h or 0.7.3 port if Jordan wants it

What is your question?
when 0.7.1h or 0.7.3 port if Jordan wants it

idk when that'll be, that's up to him when he wants to do it

honestly i still don't want to port to the newer versions because theres just too much stuff to port over


az deployment group doesn't support passing location "-l"

module 3,4,5 and 6 uses "az deployment group create -l " command to deploy the resources. this command does not accept location as parameter natively like az deployment sub. the readme for those modules should be updated to reflect that and the location should be passed instead using -p

thanks a lot, fixed


Missing images on Mobile Dapp Browsers

Context
A previous issue (#12) was open to solve the issue with missing images that weren't bundled with Webpack. This was successful and you can know see on the live demo at web3connect.netlify.com that the images are present on the modal when you click the button.
However this issue still remains for a very specific use-case. It works on Mobile browsers but not a Mobile Dapp Browser. For example:  open the same live demo on Trust Wallet's Dapp Browser (only tested on iOS) and you will see that the image is not loaded.
Goal
Find a solution that will display bundled images on Trust Wallet's Dapp Browser for both Android and iOS

This is how it looks like currently on the iOS Trust Wallet's Dapp Browser

Is your file path static?

@pedrouid
How is this issue going? Have you being able to test it on Android ?

Not sure, @surajkelhe and @chiradeep7 could you provide an update if you are have a PR ready to go soon. Otherwise, feel free to jump on it as well @janus.

@pedrouid any update? still need some help? lemme know and I'll participate on gitcoin bounty

Hi @gutsal-arsen, this bounty is still live. Feel free to jump on it!

@pedrouid Expressed my interest on Gitcoin.

@agutsal Just extended the bounty and approved your application.

Awesome! Just tested it and works perfectly! Thanks @agutsal! 👍

@pedrouid thanks for Kudos ;)


Datashader image not rendering when zoom in bokeh plots

Here is my code:
x_range = (0, len(df))
y_range = (df['EuPrice'].min(), df['EuPrice'].max())
def create_image(x_range, y_range, w, h):
    cvs = ds.Canvas(plot_width=w, plot_height=w//1.2)
    agg = cvs.line(df, 'fakedata', 'EuPrice')
    img = tf.shade(agg)
    return img

def base_plot(tools='pan,wheel_zoom,box_zoom,resize,reset'):
    p = bp.figure(tools=tools, plot_width=600, plot_height=300,
        x_range=x_range, y_range=y_range, outline_line_color=None,
        min_border=0, min_border_left=0, min_border_right=0,
        min_border_top=0, min_border_bottom=0)
    p.xgrid.grid_line_color = None
    p.ygrid.grid_line_color = None
    return p

p = base_plot()
InteractiveImage(p, create_image)

Problem is that it loads the plot from datashader into bokeh plot interface. But when I zoom the image, only axis values change, but the plot image returns to the same point when I try to zoom the data. Zooms in a bit but then back to full stack of data view.
[Needless to say I am quite new in learning these libraries]

There's a small issue in your create_image callback, you need to set the x_range and y_range on the datashader Canvas otherwise it will never update the plotted ranges.
def create_image(x_range, y_range, w, h):
    cvs = ds.Canvas(plot_width=w, plot_height=w//1.2, x_range=x_range, y_range=y_range)
    agg = cvs.line(df, 'fakedata', 'EuPrice')
    img = tf.shade(agg)
    return img

Try that and let us know if that works for you. If not please reopen the issue.

It worked perfectly! Thank you


suggestion: disable reporting issues on this project

The README mentions that issues should not be logged on this project. GitHub allows you to disable the issue tab on a repository (but not pull requests ... hmmm). Doing so would make it clear that issues should not be logged here.

Oh, maybe I should fix the README--I'm OK with issues here as long as they're actually about the client.


Update active-directory-accessmanagement-groups-with-advanced-rules.md

@RobdeJong,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@RobdeJong : Thanks for your contribution to the Azure documentation! The author, @curtand, has been notified to review your proposed change.

#sign-off


Add pt-BR brazilian portuguese translation

Something I did when integrating the brazilian portuguese translation PR from @raphaelpe caused it to disappear, so this is a new one. It contains his translation file plus some fixes and integration with the app.

Thanks again all the great work, @raphaelpe! This will be in the next release.

Good morning Nrotstan, on behalf of the entire Brazilian community, I thank you for updating the maproulette for Brazilian Portuguese.


Delay in removing 'New' marker After deleting newly sent message

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/31714
PROPOSAL: -
No formal proposal tho
Tests

Open a chat
Send a message 1
send a message 2
send a message 3
Click on “Mark as unread” on message 2
Now delete the message
2
Notice new marker is moved to message 3

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open a chat
Send a message 1
send a message 2
send a message 3
Click on “Mark as unread” on message 2
Now delete the message
2
Notice new marker is moved to message 3

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@allroundexperts  PR updated
Screenshots/Videos

Web

https://github.com/Expensify/App/assets/1676818/3785ffa7-8174-4d09-82a8-afb885a753d3
https://github.com/Expensify/App/assets/1676818/57cca881-df98-4e57-9604-2ee4036de234

Mobile Web - Chrome

https://github.com/Expensify/App/assets/1676818/33d9098d-fb1e-4aa1-8830-4cf395db45e6

Mobile Web - Safari

https://github.com/Expensify/App/assets/1676818/f108b061-5849-4f09-b1b4-9b8d4c6adef3

Desktop

https://github.com/Expensify/App/assets/1676818/922c741b-28ed-4f07-b48e-74161206eb76

iOS

https://github.com/Expensify/App/assets/1676818/961faaa7-5dee-4ed6-8a7f-7738c7f5496c

Android

https://github.com/Expensify/App/assets/1676818/39c2168f-2a90-4f2d-b34c-ac55074e001d

I will be OOO until Wednesday

This does not need to be on HOLD, right?

Reassigning C+ as per new issue

@gedu Can you please sync the latest main and resolve conflicts.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/7818c851-17bb-45ce-89d3-1f47c2d1e767

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/2d9313aa-2fda-4d5d-ab6f-3021f4bdf0c9

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/7ee74569-633f-4492-a5ba-b7495f11b1d9

Waiting on getting the conflicts resolved.

@mananjadhav I have resolved a conflict. Please take a look

Thanks @MonilBhavsar I did a quick test on Web and iOS after the main branch. LGTM.

Thank you! 🙇 Let's ship it 🚀

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


WIP: Storage pool

Description

It is now possible to manage the storage pools of an host
Motivation and Context

closes #194
How Has This Been Tested?

Some entity unit tests.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style and structure of this project.
[X] I have updated the documentation accordingly.

Number for substring should be 19.

:tada: This PR is included in version 0.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Improve error handling

See https://shiny.posit.co/r/articles/improve/sanitize-errors/index.html
As an example, this is not ideal:

Ideally we'd have this error show once on the page rather than everywhere it occurs.
In the above screenshot, this thing about proof_authenticate helps us, but the user of the app has no idea about that. Not sure what best approach is: either use the shiny sanitize errors thing so every error is generic, or give the actual error?

(handled in getwilds/shiny-cromwell@dev)

Note that some errors will still be verbatim output, e.g.,

But most should be all the same
By the way there's no way to set the default error message that comes with the global error sanitization of options(shiny.sanitize.errors = TRUE)

I've changed to NOT sanitizing errors for now. I have seen a few errors that would be not helpful to users at all - BUT the bigger issue is that we do not have access to app logs so the only way to debug is through the errors the user sees. So done for now


Add len method for UnboundedSender

Add len method to inspect how many messages are enqueued in the message queue.

Thanks for the PR. Could you fix a clippy warning? (Other CI failures should be fixed by rebase)

Fixed.


Fragments related to supporting WPF Designer

I just removed some very old snippets of code from the Visual F# Tools code base that were related to project system support for the WPF designer (and perhaps some other VS functionality).  This code was never actually used in practice and relates to the original sample we translated this from.
However it occured to me that it might be possible to add WPF Designer support to VFPT.  If so, this code might give a starting guide for how to do it:
https://github.com/Microsoft/visualfsharp/pull/1048/files
The code does use CodeDOM in some way, either to look for event handlers in the code, or to inject them.  Since VFPT is already doing some code generation there are likely to be better ways to do this.  If it was need the existing F# CodeDom implementation is here . There is a "CleanCodeDomGenerator" that tries to generate cleaner code.

Somewhat related: xaml formatting is a solved problem.


onKeyDown is not handled in the (Android) Modal component.  At all.

Description
If you add Java code to your application's ReactActivity like this:
public class MainActivity extends ReactActivity {

    @Override
    public boolean onKeyDown(int keyCode, KeyEvent event) {
        if (keyCode == KEYCODE_BUTTON_16) {
            rfidScanning.startScanning();
            return true;
        } else {
            return super.onKeyDown(keyCode, event);
        }
    }

It won't fire if you have a Modal open.  However onKeyUp will.  It's easy to see the bug in the code here:
https://github.com/facebook/react-native/blob/b531612b2c917e1f2bd6bb37bf854fe51e658b36/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostView.java#L220-L247
There's a handler for KeyEvent.ACTION_UP, passing it back into the activity, but not one for KeyEvent.ACTION_DOWN.  It's just swallowed.
Version
0.66.0
Output of npx react-native info
System:
OS: Windows 10 10.0.19042
CPU: (16) x64 Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
Memory: 11.97 GB / 31.92 GB
Binaries:
Node: 16.6.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 7.19.1 - C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: Not Found
Visual Studio: Not Found
Languages:
Java: Not Found
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: 0.64.2 => 0.64.2
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
You can probably just see the bug in the code I referenced above without having to reproduce.  It's super obvious.  But if you need a reproduction, just create an onKeyUp and onKeyDown handler in your 'MainActivity" ReactActivity in your Java.  Then add a visible modal to your app with a TextInput.
Put breakpoints in both, run the app and type anything into the TextInput.  You'll see the bug.
Snack, code example, screenshot, or link to a repository
No response

bump

up

Facing the same issue... onKeyDown events are swallowed by Modal.


Recent legacy checkpoints are not tested in CI

:bug: Bug
Currently, only legacy checkpoints generated with versions from v1.0.0 to v1.4.1 are tested in CI, which are the versions listed in legacy/back-compatible-versions.txt.
For example, see this run on 1.6.0rc1: https://github.com/PyTorchLightning/pytorch-lightning/runs/5695770164?check_suite_focus=true#step:17:584
tests/checkpointing/test_legacy_checkpoints.py::test_load_legacy_checkpoints[1.0.0] PASSED [ 18%]
tests/checkpointing/test_legacy_checkpoints.py::test_load_legacy_checkpoints[1.0.1] PASSED [ 18%]
tests/checkpointing/test_legacy_checkpoints.py::test_load_legacy_checkpoints[1.0.2] PASSED [ 18%]
...
tests/checkpointing/test_legacy_checkpoints.py::test_load_legacy_checkpoints[1.3.8] PASSED [ 19%]
tests/checkpointing/test_legacy_checkpoints.py::test_load_legacy_checkpoints[1.4.0] PASSED [ 19%]
tests/checkpointing/test_legacy_checkpoints.py::test_load_legacy_checkpoints[1.4.1] PASSED [ 19%]
tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.0.0] PASSED [ 19%]
tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.0.1] PASSED [ 19%]
tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.0.2] PASSED [ 19%]
...
tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.3.8] PASSED [ 20%]
tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.4.0] PASSED [ 21%]
tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.4.1] PASSED [ 21%]

The file was introduced in #8535 and it hasn't been updated at all since then.
Expected behavior
Run tests on legacy checkpoints generated with versions from v1.0.0 to the latest version in CI.
Environment
n/a
Additional context
Found this issue while reviewing/documenting our CI/CD.
cc @tchaton @rohitgr7 @akihironitta @carmocca @borda @awaelchli @ananthsub @ninginthecloud

Duplicate of https://github.com/Lightning-AI/lightning/issues/11403


[feature request?] Set a date without retrieving the flatpickr instance

Hello,
I think at the moment you cannot set a date via javascript or jquery using something like:
$("[name='.......']").val('2020-05-30');
am I right?
You have to retrieve the flatpickr instance and use the setDate() method.
Is there any workaround? The reason I am asking this is because I want to provide a smooth transition to the users of an application that at the moment uses the old jquery date picker and will use flatpickr in the future.
Users might have written custom javascript / jquery code for setting dates and this code will stop working.
Thanks.

Have you find any work around this issue?