Add more docs on reallyUnsafeUnliftIO

Please provide more documentation on reallyUnsafeUnliftIO. It used in Effectful.Concurrent.MVar, however in Effectful.FileSystem.IO.File used unsafeSeqUnliftIO. The current description looks scarry - it is quite difficult to cause a segmentation fault in Haskell, even using unsafePerformIO, but the description states that this can happen if computation run "in a thread distinct from the caller of reallyUnsafeUnliftIO".
I think there needs to be more clarity at this point. It would be nice to have an example of incorrect use, an example of safe use and some guidelines when which of these two functions should be used.

Yeah, will do. FWIW I was thinking recently of removing the "segmentation fault" bits from the docs as was unable to think of scenarios in which it would happen. It might've been possible pre <IP_ADDRESS>, but I don't really remember, maybe I just imagined things.

the description states that this can happen if computation run "in a thread distinct from the caller of reallyUnsafeUnliftIO".

Yeah, it amounts to more than one thread using the same Env at the same time. If you do this, you will get data races, weird bugs (like local in one thread affecting the return value of ask in the other thread) and possible internal consistency check fails. I don't think getting a segfault is currently possible, even if you put some random functions from Effectful.Internal.Env together in a way that doesn't make sense.

Apart from the segmentation fault bit, is there anything in the docs that's unclear? Specifically, in this bit:

Unlifted 'Eff' computations must be run in a way that's perceived as sequential to the outside observer, e.g. in the same thread as the caller of 'reallyUnsafeUnliftIO' or in a worker thread that finishes before another unlifted computation is run.

I think the best way would be to give an example of correct and incorrect usage. If I understand correctly, the root of the problem is that unlift functions ((forall a. m a -> IO a) -> IO b) -> m b may capture m-s underlying state and this can lead to various errors in case of using mutable state. That is why such libraries as unliftio limit m to reader-like things and it's pretty safe regardless of what we do in the unlifted computation.
However, if I understand correctly, this is not generally true for effectful. We can end up with incorrect behavior even all effects are reader-like, so additional measures should be taken. Moreover, effectful libraries trend to reexport functions with callbacks that use unlifting under the hood (e.g. withMVar :: Concurrent :> es => MVar a -> (a -> Eff es b) -> Eff es b allows to pass callback of type (a -> Eff es b)). I'm wondering what the requirements for such callback function are to guarantee correct behavior if any.

I think you're approaching it from a weird angle. First, forget about constraints of unliftio, they aren't relevant here.

I'm wondering what the requirements for such callback function are to guarantee correct behavior if any.

There aren't any.
The public API, unless described otherwise (Effectful.Dispatch.Static.Primitive and Effectful.Dispatch.Static.Unsafe) is safe to use and there are no hidden gotchas (if there are, it's most likely a bug).
For higher order effects (i.e. the ones that execute callbacks), if you use the sequential unlift where the concurrent one is expected, you'll get a descriptive runtime error and can then switch to appropriate concurrent strategy or modify the handler so it works with sequential unlifts.
FWIW, lifted MVar functions use the unsafe variants because realistically the callback will never be executed in a different thread as this would made MVar unusably slow. File operations use the safe variant because while these functions will most likely never use a different thread to run a callback, in principle they could and the safety check is irrelevant anyway when compared to the cost of opening a file.


Add one extra byte to return value of compressBound and deflateBound …

…for small lengths due to shift returning 0.

Treat 0 byte input as 1 byte input when calculating compressBound and deflateBound

Fixes:  #1391
(cherry picked from commit 4fadf3c49e3dc98c5e1c0b86401324061d951d9f)

@Dead2

This is included in #1393


Left right iterator

Perform integration based on an iterator that is initialized with a curve object and two bounds:
for (xi, yi) in (curve, left_bound, right_bound)
    ... # do something with data points
end

The key is that data points at the left and right boundaries will be interpolated linearly if they happen to fall
between the x-values (just like it was previously done in the trapz function).
This PR also fixes tests and deprecation warnings and prepares for a version 1.0.
Tested Julia version is now 1.10.

still needs fixing the doctests ...


updating frontmatter not working

With 0.4.11 and 0.4.12 clicking on the icon in the tab, for updating frontmatter no longer works when I update the field: values. Rolling back to v0.4.10 restores this function.
I realise this is not very clear, so here is a pic, that might help clarify what I am talking about...

good catch. should be fixed in 0.4.13

Working as expected with 0.4.13. Many thanks


Python 3

ProtoActor in Python 3 with typings.
Need to fix the tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Lucas Ventura seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.


BLE and IP transports at the same time

What is the expected behavior of a controller when an accessory is available over both IP and BLE?
I kind of expected it to prefer IP and fall back to BLE but this is not what I see happening - I see controllers always using BLE.
Is this how it's supposed to work?

This is not really an officially supported configuration as far as I know. If an accessory is advertising on both BLE and IP,  then the controllers will pick one or the other. Seems like your experiment says that the controller picked up BLE.

worse, if an accessory was set up as BLE but is advertising on IP (e.g. when user configures wifi and that becomes available), controllers don't recognize it.


Add keeping track of slot numbers for vtable entries and emit placeholders when they're removed

Right now it isn't possible to safely remove a vtable entry in a transformation because vtables are emitted as sequential structs. We should keep track of slot numbers and ensure we emit a padding field when one is missing.

Instead of keeping track of slot numbers, let's change TranslatedVTableEntry to refer to the TranslatedFunction it corresponds to using https://github.com/InfectedLibraries/Biohazrd/issues/150 instead.

Note: This is not what PathogenVTableEntry.Offset provides. That's specifically only relevant for VCallOffset, VBaseOffset, and OffsetToTop entries.

We can fudge this without it, but it'd be a good idea to do this at the same time as https://github.com/InfectedLibraries/Biohazrd/issues/49


Is there any way to send colored output to stderr?

Is there any way to send colored output to stderr?
Could that be added easily?

Call disableConsoleColors() at the start of your application.

[ ] Document this

Yes, send output to stderr. There's no reason it should always send output to stdout?!

D allows you to do stderr.writeln("foo"); so I suppose with this lib, stderr.cwriteln("bar") should work too.
Also, why are color names not documented? And background colors? Do you support italics/bold/flashing/etc?

Also, why are color names not documented? And background colors?
You were supposed to run the example, but now there is:

a cheat sheet in README to avoid that. in v1.1.2
you can also run the unittest in console-colors

Do you support italics/bold/flashing/etc?

No, but this is open-source contributions welcome. It should work on Windows, macOS and Linux though else won't be merged.
As for your initial request, I'm not sure how possible it is yet, since you would need state machine for each possible console output.

Oh thanks :)
I will give it a try.

I ran the example on Mac M1 with the Kitty terminal:

I then changed the example to use stderr.cwriteln everywhere cwriteln was being used, and it worked as expected.
Confirmed that it's sending output to stderr by doing dub run 2> /dev/null which does not output anything.
I can do the same on Linux later on if you want.

Thanks! It probably works then on POSIX. I don't think it would be different in Linux, thanks.

Yeah, Mac is nt to Linux/POSIX... anyway, I tried the same thing on Kubuntu (Ubuntu with KDE) and it worked as expected.


Errors running dataPrepare (Missing reference picture, default is 0)

I ran
python3 dataPrepare.py --start_id 2000 --duration 120 --REMOVE --disk_path ./TrainingData
Things went well until:
64 @ 0x38cf500] Missing reference picture, default is 65548
[h264 @ 0x38cf500] Missing reference picture, default is 65548
[h264 @ 0x3ceaa40] reference picture missing during reorder
[h264 @ 0x3ceaa40] Missing reference picture, default is 65550
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] Missing reference picture, default is 65550
[h264 @ 0x3c61dc0] co located POCs unavailable
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 2
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x3c61dc0] decode_slice_header error
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] Missing reference picture, default is 65580
[h264 @ 0x38cf500] Missing reference picture, default is 65580
[h264 @ 0x3ceaa40] reference picture missing during reorder
[h264 @ 0x3ceaa40] Missing reference picture, default is 65582
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] Missing reference picture, default is 65582
[h264 @ 0x3c61dc0] co located POCs unavailable
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x3c61dc0] decode_slice_header error
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] Missing reference picture, default is 65580
[h264 @ 0x38cf500] Missing reference picture, default is 65580
[h264 @ 0x3ceaa40] reference picture missing during reorder
[h264 @ 0x3ceaa40] Missing reference picture, default is 65582
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 2
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] Missing reference picture, default is 65582
[h264 @ 0x3c61dc0] co located POCs unavailable
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 2
[h264 @ 0x3c61dc0] co located POCs unavailable
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] Missing reference picture, default is 0
[h264 @ 0x3c61dc0] decode_slice_header error
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] reference picture missing during reorder
[h264 @ 0x38cf500] Missing reference picture, default is 65576
[h264 @ 0x38cf500] Missing reference picture, default is 65576
[h264 @ 0x3ceaa40] reference picture missing during reorder
[h264 @ 0x3ceaa40] Missing reference picture, default is 65578
[h264 @ 0x3c61dc0] co located POCs unavailable
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3c61dc0] reference picture missing during reorder
[h264 @ 0x3d3f200] mmco: unref short failure

Not sure if it can't deal with downloading files into the docker container or if they need to be downloaded to some file system location outside the container or what.

My guess would be that the data is not available anymore online and therefore not everything got downloaded.

That was basically just a small fraction of the amount of errors I was getting like that, I know plenty of them got downloaded. Are you not seeing this?

Don't remember if I saw this the last time I ran it. What happens when you try to start the training?

This is actually happening to me.
Did you find the solution? Thanks!


mrcli add company wizard crashes on gathering firmographics getLatLong()

? Your company's name is? ProductPlan
? What type of company is this? Private
Set the company's type to [Private]
? What role should we assign to this company? Competitor
Set the company's role to [Competitor]
? What region is this company in? North, Meso and South America (AMER)
Set the company's region to [AMER]
Attempting to automatically discover company firmographics.
? No company matching [ProductPlan] found, try again? Yes
? Your company's name is? ProductPlan
? No company matching [ProductPlan] found, try again? No
No matching company found, starting manual company definition...
? What's the description? ProductPlan is a platform for product managers to align their teams, collaborate on their roadmaps, and measure the
impact of their work.
? What's the website? https://www.productplan.com/
? What's the street address? 836 Anacapa Street Suite 944
? What's the city? Santa Barbara
? What's the state or province? CA
? What's the country? USA
? What's the zip or postal code? 93101
? What's the phone number?<PHONE_NUMBER>
? What's the wikipedia url? Unknown
? What's your industry search string? computer
? Please choose the most appropriate industry Computers and Computer Peripheral Equipment and Software
file:///usr/local/lib/node_modules/mediumroast_js/src/cli/companyWizard.js:576
const [status, msg, [lat, long]] = await this.getLatLong(fullAddress)
^
TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
at AddCompany.doAutomatic (file:///usr/local/lib/node_modules/mediumroast_js/src/cli/companyWizard.js:576:33)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async AddCompany.wizard (file:///usr/local/lib/node_modules/mediumroast_js/src/cli/companyWizard.js:755:21)
at async file:///usr/local/lib/node_modules/mediumroast_js/cli/mrcli-company.js:230:19

@jgoodie fixed by changing the geocoding module, closing


[BEAM-2753] Fixes translation of WriteFiles side inputs

JIRA: https://issues.apache.org/jira/browse/BEAM-2753
R: @kennknowles
CC: @reuvenlax @mairbek

retest this please

retest this please

Changes Unknown when pulling bd1ae5fc000332b3113096a9d6b58194924e60cc on jkff:file-destinations into ** on apache:master**.

Kenn is OOO but we should get this in 2.2.0.
R: @lukecwik could you take a look? (this is just a new test + doing exact same thing as for ParDoTranslation but for WriteFilesTranslation; and extracting it into a utility function)

All done and merged, thanks.


improve benchmarks

use Vec to make comparisions easier
use pool.get to actually compare creation

@dignifiedquire sorry, you'll need to rebase against master. 🙁


App::St: 1.1.2 -> 1.1.4

Noticed update was available, minor cleanup while at it.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build perlPackages.AppSt

Success on aarch64-linux (full log)
Attempted: perlPackages.AppSt
Partial log (click to expand)
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8gi7srz2q6hi1qasgsqjmwd6afpfyhpa-perl-App-St-1.1.4/lib  /nix/store/8gi7srz2q6hi1qasgsqjmwd6afpfyhpa-perl-App-St-1.1.4/bin
patching script interpreter paths in /nix/store/8gi7srz2q6hi1qasgsqjmwd6afpfyhpa-perl-App-St-1.1.4
checking for references to /build in /nix/store/8gi7srz2q6hi1qasgsqjmwd6afpfyhpa-perl-App-St-1.1.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/7m41hhy9j1mdbn8n6jazi1fj8v034p3z-perl-App-St-1.1.4-devdoc
gzipping man pages under /nix/store/7m41hhy9j1mdbn8n6jazi1fj8v034p3z-perl-App-St-1.1.4-devdoc/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/7m41hhy9j1mdbn8n6jazi1fj8v034p3z-perl-App-St-1.1.4-devdoc
checking for references to /build in /nix/store/7m41hhy9j1mdbn8n6jazi1fj8v034p3z-perl-App-St-1.1.4-devdoc...
/nix/store/8gi7srz2q6hi1qasgsqjmwd6afpfyhpa-perl-App-St-1.1.4

Success on x86_64-linux (full log)
Attempted: perlPackages.AppSt
Partial log (click to expand)
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/djqpvclcj643fp11mk7ya1dwx62nfpfk-perl-App-St-1.1.4/lib  /nix/store/djqpvclcj643fp11mk7ya1dwx62nfpfk-perl-App-St-1.1.4/bin
patching script interpreter paths in /nix/store/djqpvclcj643fp11mk7ya1dwx62nfpfk-perl-App-St-1.1.4
checking for references to /build in /nix/store/djqpvclcj643fp11mk7ya1dwx62nfpfk-perl-App-St-1.1.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/06s45xzxidwv7cshczfkiq09xj9m99qi-perl-App-St-1.1.4-devdoc
gzipping man pages under /nix/store/06s45xzxidwv7cshczfkiq09xj9m99qi-perl-App-St-1.1.4-devdoc/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/06s45xzxidwv7cshczfkiq09xj9m99qi-perl-App-St-1.1.4-devdoc
checking for references to /build in /nix/store/06s45xzxidwv7cshczfkiq09xj9m99qi-perl-App-St-1.1.4-devdoc...
/nix/store/djqpvclcj643fp11mk7ya1dwx62nfpfk-perl-App-St-1.1.4

Success on x86_64-darwin (full log)
Attempted: perlPackages.AppSt
Partial log (click to expand)
Moving /nix/store/ki8fc9z784fb8m0m1aw373pkqj82m8m9-perl-App-St-1.1.4/share/man/man3 to /nix/store/21k2b5q5mv30q7g761g6dpyxgx324clf-perl-App-St-1.1.4-devdoc/share/man/man3
rmdir: failed to remove '/nix/store/ki8fc9z784fb8m0m1aw373pkqj82m8m9-perl-App-St-1.1.4/share/man': Directory not empty
gzipping man pages under /nix/store/ki8fc9z784fb8m0m1aw373pkqj82m8m9-perl-App-St-1.1.4/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ki8fc9z784fb8m0m1aw373pkqj82m8m9-perl-App-St-1.1.4/lib  /nix/store/ki8fc9z784fb8m0m1aw373pkqj82m8m9-perl-App-St-1.1.4/bin
patching script interpreter paths in /nix/store/ki8fc9z784fb8m0m1aw373pkqj82m8m9-perl-App-St-1.1.4
gzipping man pages under /nix/store/21k2b5q5mv30q7g761g6dpyxgx324clf-perl-App-St-1.1.4-devdoc/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/21k2b5q5mv30q7g761g6dpyxgx324clf-perl-App-St-1.1.4-devdoc
/nix/store/ki8fc9z784fb8m0m1aw373pkqj82m8m9-perl-App-St-1.1.4


[docs] add more PR types to PR template & uncomment related issues

Description
Add PR types:

refactoring
docs
ci
...

would be perfect if PR types match conventional commits. refer to:

#370

Good idea 👍


Allow GH actions on PRs from forked repos

Make "docker login" in spec execution optional. Note that it has anyway limited (if any) effect as docker registry mirror cache is used and docker login does not really have expected affect. The registry mirror cache itself needs to be configured with respective credentials.
Issues:
Refs: #2066
How has this been tested:

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Verified all A/C passes

[ ] develop
[ ] master
[ ] tag/other branch

[ ] Test environment

[ ] Shared Packet K8s cluster
[ ] New Packet K8s cluster
[ ] Kind cluster

[ ] Have not tested

Types of changes:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:
Documentation

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] No updates required.

Code Review

[ ] Does the test handle fatal exceptions, ie. rescue block

Issue

[ ] Tasks in issue are checked off

What about registry_spec.cr where docker login is mandatory? There is code like:
_ if ENV["DOCKERHUB_USERNAME"]? && ENV["DOCKERHUB_PASSWORD"]?
result = Dockerd.exec("docker login -u $DOCKERHUB_USERNAME -p $DOCKERHUB_PASSWORD", force_output: true)
Log.info { "Docker Login output: #{result[:output]}" }
else
puts "DOCKERHUB_USERNAME & DOCKERHUB_PASSWORD Must be set.".colorize(:red)
exit 1
end_

What about registry_spec.cr where docker login is mandatory? There is code like:
if ENV["DOCKERHUB_USERNAME"]? && ENV["DOCKERHUB_PASSWORD"]? result = Dockerd.exec("docker login -u $DOCKERHUB_USERNAME -p $DOCKERHUB_PASSWORD", force_output: true) Log.info { "Docker Login output: #{result[:output]}" } else puts "DOCKERHUB_USERNAME & DOCKERHUB_PASSWORD Must be set.".colorize(:red) exit 1 end

Good point. Currently it passes because DOCKERHUB_USERNAME are set (but empty string) co the condition is true. Docker login fails but is ignored. At the end the test passes, despite not being logged in to dockerhub.


Add post install script to auto install poly fill dependencies

Currently, the npm run build command requires the polyfill package to be installed, but this is not installed by default. This PR adds a postinstall script to automatically install these dependencies.

Changes look good!

Merged! Thanks again @HexaField


Task stuck in 100% CPU loop within FinalizerGroup/DefaultExecutionPlan.finalizePlan  on Gradle 7.6+

Expected Behavior
./gradlew server:fastUnitTest of https://github.com/gocd/gocd should execute fine for Gradle 7.6+, as it does on Gradle 7.5.1.
This task is defined here, and I cannot identify anything special about it to guess at the root cause or find a workaround.
Current Behavior
On Gradle 7.6, 7.6.1, 8.1.1 and possibly other versions running this task just gets stuck CONFIGURING and never terminates.
 I have not found a workaround for this.
Steps to Reproduce
Requires JDK 17 on path or locatable via Gradle toolchain
git clone https://github.com/gocd/gocd
git checkout 23d5610cee3682e8e6e3375b58a6f240416954ec
./gradlew server:fastUnitTest --tests GoConfigDaoBasicTest
# See that it is stuck

Downgrade and see that it gets past configuring
./gradlew wrapper --gradle-version=7.5.1 --gradle-distribution-sha256-sum=db9c8211ed63f61f60292c69e80d89196f9eb36665e369e7f00ac4cc841c2219 --distribution-type=ALL
./gradlew server:fastUnitTest --tests GoConfigDaoBasicTest
# See that configuring completes and thinks start compiling/executing

Gradle version
8.1.1
Gradle version that used to work
7.5.1
Build scan URL (optional)
No response
Your Environment (optional)

Apple MacBook M1 Pro
MacOS Ventura 13.4
Java 17.0.7

I note various work in this broad area, e.g in #21116 #21997 #21542 #21975
It has the broad same observable behaviour (livelock) as #20455 but understand that ticket is a generic issue and not really resolvable.

I've taken a look at this and, in fact, this it not a hang, but just some really inefficient code.  It will actually finish calculating the task graph after about an hour and a half (depending on the horsepower of your machine).  There are about 1400 tasks that get executed with fastUnitTest and it appears that we have some logic that runs in at least O(n^2) time (maybe even O(n^3) time, I'm not sure) relative to the number of tasks.
In any event, we need to optimize this.  In the meantime, the following workaround will get you around the problem (i.e. the issue is related to the fact that the test tasks are both dependencies of and finalized by the report task):
@@ -679,7 +679,7 @@ task allTestsJunitHtmlReport(type: TestReport) { TestReport thisTask ->
   description = "Run all api tests"

   forAllTask { Test eachTestTask ->
-    testResults.from(eachTestTask)
+    testResults.from { eachTestTask.binaryResultsDirectory.get().asFile }
     eachTestTask.finalizedBy(thisTask)
   }
   destinationDirectory = file("${project.buildDir}/reports/tests/allTests")

Thank you very much! Will give that a go.
Do you think this might bes something to do with the changes for finalizedBy and mustRunAfter in Gradle 7.6 or so? https://github.com/gradle/gradle/issues/10549 (we have some mustRunAfters I don't quite understand)
I don't quite understand why the same behavior isn't observed when running ./gradlew allTests, or other individual test tasks, i.e what is special about trying to run this one single task that triggers the O(n^2+) processing.
Perhaps I could consider removing allTestsJunitHtmlReport as relevant when running an individual test task; i.e make it only apply when running allTests. I think it was changed to finalize all tasks always for some reason. Perhaps the issue is triggered by the weird afterEvaluate stuff?
I do note however that we have a

whole lot of warnings about needing to use tasks.register and tasks.withType(..).configureEach to defer configuration which may relate to why this is painful.
some hacks in there still lingering around that seemed to be due to long-removed use of gradle-testsets-plugin including the forAllTasks afterEvaluate
we also have other problems with some of the custom stuff being done here, like filtering test tasks with --tests not working properly and running tests for dependent tasks (!!), so probably I need to review/simplify everything in this "test task" area.

There was definitely a change in 7.6 that attempted to more properly handle finalizer tasks and introduces the problem you've found.  In the task graph, mustRunAfter relationships and dependsOn relationships are extremely similar, so it's likely the same problem as discussed in the issue you linked.
The reason it's not an issue with allTests is because allTests pulls all of the finalized Test tasks into the graph.  The problematic code comes into play when we are looking at the finalizer task and searching for un-scheduled dependencies that might also need to be pulled into the graph.  Since allTests causes all of the finalizer's dependencies to be scheduled, we never actually descend into the problematic logic - it's only when you request some subset of those tasks that we trigger the problem.  By removing the task dependency between the finalizer and the test tasks, we also avoid it as we just rely on the finalization relationship to ensure that the test tasks run first.  It does mean that running allTestsJunitHtmlReport by itself will not cause any of the test tasks to execute, but I don't get the impression that's something that you would need.
One option to think about with respect to test report aggregation might be to use the test report aggregation plugin introduced in Gradle 7.4.  It's a little bit different than your current configuration in that it uses test suites and aggregates by test type (which can be any arbitrary string).  You'd have to convert your tests to use test suites, but your use case is pretty much what test suites were designed to address.  It would likely simplify the configuration a good bit, I think, but not without some effort during conversion.


[Event Request] Codeunit 7000 Sales Price Calc. Mgt. – FindJobPlanningLinePrice

Could we please have a Supplement in publisher OnBeforeFindJobPlanningLinePrice in function FindJobPlanningLinePrice Codeunit 7000 Sales Price Calc. Mgt.?
[External] FindJobPlanningLinePrice(VAR JobPlanningLine : Record "Job Planning Line";CalledByFieldNo : Integer)

// >>>>>>>>
OnBeforeFindJobPlanningLinePrice(Var JobPlanningLine, CalledByFieldNo, Var Handled);
IF Handled THEN
  EXIT;
// <<<<<<<<

WITH JobPlanningLine DO BEGIN

We are currently looking into a larger refactoring effort of the Sales Price module and hence cannot accept event requests for this module right now. We will keep you posted.


Capes do not properly render on AS2 playercard

Describe the bug
When equipping one of the capes, only the top portion of the cape shows on the playercard whereas the bottom part does not render.
Client Type:
Legacy only, properly renders on the vanilla client
To Reproduce
Equip a cape (red cape, blue cape, etc.)
Open your playercard
Install Method
Wand
Expected behavior
The cape should also appear on the bottom towards the penguin's feet
Screenshots
How it appears on AS2

How it appears on AS3

Server Info:
Linux

This is most likely a client side bug, and this issue should not be opened on this repo.

This is a client issue so you should be opening the issue on https://git.solero.me/solero/legacy-media


The connection to the terminals pty host process is unresponsive, the terminal may stop working.

Issue Type: Bug
the terminal very often stops working.
it wont start often

VS Code version: Code - Insiders 1.56.0-insider (01466cf692c3e54f0eeb82ef0539a42391f185de, 2021-04-12T05:17:32.143Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz (8 x 1800)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.87GB (5.01GB free)

Process Argv
--crash-reporter-id 340e0eb9-5b34-4206-9e2e-bd86fc3b2cf3

Screen Reader
no

VM
0%

Extensions (25)

Extension
Author (truncated)
Version

gitlens
eam
11.4.0

EditorConfig
Edi
0.16.4

prettier-vscode
esb
6.3.2

vscode-pull-request-github
Git
0.25.0

output-colorizer
IBM
0.1.2

vscode-dotnet-runtime
ms-
1.0.0

github-issues-prs
ms-
0.9.3

vscode-js-profile-flame
ms-
0.0.14

fabric8-analytics
red
0.3.2

java
red
0.76.0

vscode-commons
red
0.0.4

vscode-xml
red
0.15.0

vscode-yaml
red
0.17.0

vscode-checkstyle
she
1.4.0

swdc-vscode
sof
2.5.11

sonarlint-vscode
Son
1.21.0

code-spell-checker
str
1.10.2

rest-book
tan
0.3.2

vscodeintellicode
Vis
1.2.12

vscodeintellicode-insiders
Vis
1.0.6

vscode-java-debug
vsc
0.32.1

vscode-java-dependency
vsc
0.18.2

vscode-java-pack
vsc
0.13.0

vscode-java-test
vsc
0.28.1

vscode-maven
vsc
0.28.0

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvsnew554:30265444
pythontb:30258533
wslfolderdoc:30278405
vspre833cf:30267465
pythonptprofiler:30281269
vscnewfilebutton:30280634
vshan820cf:30276953
pythondataviewer:30285072
vscus158cf:30286554
vscgsv2ct:30286873

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

@meganrogge yes i can reproduce it in the insiders build.
i have the latest update for insiders. i however don't have a reliable way to reproduce it every time.
details for insiders
Version: 1.56.0-insider (user setup)
Commit: 94d369e27d19f598228961e9feb0413f2edabe5d
Date: 2021-04-14T12:07:54.328Z
Electron: 11.4.2
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

can you please help me with this statement as i m facing same issue "I believe this is already fixed, can you see if you can reproduce in the [Insiders build]"
my vscode details ::
Version: 1.55.2 (user setup)
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:35:57.887Z
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042


Google Authenticator: Anyone using this with the changes to the Google API (from October/November 2018)

I have been using the Google Authenticator to download Gmail Contacts.   I recently learned of changes to the Google APIs from October/November 2018.   I believe these changes are impacting the Google Authenticator Access Tokens, but have not been able to resolve.   Any insight into modifications needed to be made to the Google Authenticator Class Module to support the Google API changes would be greatly appreciated!

I am having the same issue , any help would be greatly appreciated

I proposed a #382 branch merge that solved the issue of the new OAuth API on my side
Happy new year !
Alamaz

In Function  auth_LoginExtractCode (GoogleAuthenticator.cls) should be made a small change.
Change Line 414  from
If VBA.UCase(auth_Element.NodeName) = "INPUT" Then
in
If VBA.UCase(auth_Element.NodeName) = "TEXTAREA" Then
After this change all is running perfect. It seems that Google had redesigned the Website.
Greetings


[Feature Request] Reminder Tags or Grouping

This is awesome and what I've been looking for!
Would it be possible to please add tags to reminders? I'd like to group them by service interval (Inspection I, Inspection II, Standard Oil Change). Not sure if there's a better way to accomplish this.

Sorry to keep opening and closing this. I wasn't sure this would accomplish what I want, but I think it's worth a try.

Released in 1.2.9


Appenv projects: support tools like renovate and dependabot

Ultimately, deployments using e.g. batou, which use appenv as it's installation mechanism, save their requirements in the repository where appenv is used.
Since the requirements are locked by appenv, only the specified versions are used. Usage may run outdated and vulnerable dependency versions.
Tools like renovate and dependabot can update locked dependencies and warn if dependency requirements exclude known safe versions.

Both renovate and dependabot only support a variety of pre-defined project package managers:
renovate manager support
Dependabot Supported ecosystems and repositories
While renovate supports some sort of mechanism that allows us to use custom files (fileMatch), dependabot does not.
Ultimately though, both support pip-compile
The pip-compile dependency locking format works (in the most basic way) by consuming a recuirements.in file and producing a requirements.txt file with locked dependencies.
This is similiar to appenvs locking format that consumes a requirements.txt and produces a requirements.lock.

How to implement:
New Appenv Project format: Follow pip-compile's format and read a requirements.in and produce a requirements.txt
Add #1 together with a versioning scheme for appenv repositories that allows for executing migrations when upgrading in between versions.

https://pypi.org/project/appenv/#description
releases gehören hierzu


WIP – Improve loading and parsing of district config YAML

Who is this PR for?
Developers who need to read districtwide configuration from YAML.
What problem does this PR fix?
A couple of inconsistent methods and code style practices. After I merged in #1322 I realized I was unsatisfied with a couple of things:

The method School.seed_somerville_schools was a lie. This method read from ENV to determine district, so if ENV told it to seed New Bedford schools, it would do that.
The School class used an ENV variable to read a path in the filesystem, which isn't a good practice.
The YAML config files I wrote had an unnecessary "config" key at the top level which added extra lines of code to unwrap.

What does this PR do?

Fixes the School.seed_somerville_schools method by making it pass in a fixed string as district key, so that it always does what it says it will.
Creates two separate classes, LoadDistrictConfig and DistrictConfig. LoadDistrictConfig uses district keys to select the right config files from the filesystem and parses them from YAML;  DistrictConfig applies validation and other logic.

I separated them out because searching for YAML on the filesystem seemed a like a very different concern from exposing validated config information to the rest of the app.
School also asks for a consistent way to find school config, but doesn't need any validation or other logic once it gets the config it needs.

Removes the unnecessary top-level key from the district config YAML files.

Checklist

[x] Test data import process locally before deploying

[x] Verify school seeding process by re-creating a demo site on this branch

Did some manual command line testing of school seeding on this branch:
School.seed_schools_for_district('new_bedford') ; School.count
=> 25

School.destroy_all ; nil
=> nil

School.seed_schools_for_district('somerville') ; School.count
=> 13

@kevinrobinson I'm going to merge this in as a selfie for two reasons:

I think making School.seed_somerville_schools a truthfully named method is an important improvement.
I'm excited to rebase #1321 on top of this to more consistently access school config data during the import process.

But I'm super open to any feedback or suggestions on these changes! What do you think? What am I missing here?
I'm especially curious for feedback on splitting LoadDistrictConfig from DistrictConfig. This seems like a good step to me because the two classes do very different things. Sometimes a dev will just want to read in YAML config, and she should have a pre-built API for doing that. Sometimes a dev will want to add validation or logic on top of the config, and she should have a class to put that in too.
Is this a good pattern? How can it be improved on? How about the naming of these classes? As a first step I added code comments that make the purpose of each class explicit, which I think is a good start.

@kevinrobinson Also, obviously we're in holidays mode so you should answer in a super super async way, these questions don't seem urgent to me at all. 😎 🎄 ☃


[Question] > Could not read script ... rubyUtils.gradle as it does not exist.

I just got the err when i run
gradlew.bat assemble

And https://www.elastic.co/guide/en/logstash/6.6/java-filter-plugin.html#_set_up_your_environment_2  No declaration of rubyUtils.gradle ,
so, what can i do for it?
thank any help!!

The rubyUtils.gradle file is in the Logstash repository. If you follow the instructions in the "Set up your environment" section, it tells you how to obtain a local copy of the Logstash repo and how to edit your gradle.properties file to specify the location of your local copy of the Logstash repo. Once you've done that, the rubyUtils.gradle file will be found and all the Gradle build targets should function properly.
On an related note, I would encourage you to upgrade from Logstash 6.6 if that's what you're currently using because Java plugin support was only experimental in that release and many improvements were made to it in later releases.


Why is there an express server in static?

I am pretty new to javascript but am I wrong that server.js is an express server?
Why is it there when you have a flask server?

There are indeed 2 seperate servers here -
The flask server is the backend. It handler interaction with the database and everything else that goes on in server-land.
The front-end server handles watching your front-end code for file changes and transpiling and  proxying requests from localhost:3000 (the port the front-end server is running on) to localhost:8080 (the back-end flask server) among other things.
Hope that answers your question.

Assuming you compile all the javascript, could it run fine with just the flask server?

Yes exactly.
On Monday, August 29, 2016, Declan Kelly<EMAIL_ADDRESS>wrote:

Assuming you compile all the javascript, could it run fine with just the
flask server?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dternyak/React-Redux-Flask/issues/5#issuecomment-243032423,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf02eWUMhRnIvYuGgKW0mFLHpAuuG74ks5qkmeFgaJpZM4JvIvX
.

Thanks for the explanation.


Added content-type constant to class ApiProblem

Added a content-type constant to the class ApiProblem and used it inside the ApiProblemResponse class. It will make it much easier to refer to the correct content type without having to retype/hardcode the application/problem+json string everywhere we need it.

Merged to develop for release with 1.2.0; thanks, @Wilt !


A module of examples of working with ImagePlus

A new set of tutorials designed to help plugin developers transition from IJ1 to IJ2. Another goal is to show how to create plugins that can only work with certain kinds of Datasets / ImgPlus.

Sorry for the delay. I see it uses Java 8 stuff, but at this point I think it's fine.
There is some cleanup we'll need to do to the code (if you try autoformatting it in Eclipse you'll see some stuff, particularly javadoc, get mangled) but for the moment it is OK!
THANK YOU!


stm32h5: samples/net/gptp doesn't work at all

Describe the bug
gptp doesn't appear to work at all on stm32h5. Peer delay always returns nonsensical value<PHONE_NUMBER>ns).
I get exactly the same output whether testing with two identically configured nucleo_h563zi boards connected directly to each other, or with one board connected directly to a Linux machine runnning ptp4l v4.1 with the following configuration:
https://github.com/richardcochran/linuxptp/blob/master/configs/gPTP.cfg
To Reproduce
Steps to reproduce the behavior:
On the board:

cd samples/net/gptp
west build -b nucleo_h563zi
west flash

On the Linux system:

apk add linuxptp
wget https://github.com/richardcochran/linuxptp/blob/master/configs/gPTP.cfg
ptp4l -i eth1 -f gPTP.cfg -l 7 -m

Expected behavior

Linux box assumes GM role, board syncs to the GM.
One Nucleo board assumes the GM role, and the other board syncs to the GM.

Impact
Showstopper; the application is GPS-disciplined NTP/gPTP reference.
Logs and console output
UART output:
*** Booting Zephyr OS build zephyr-v3.4.0-3440-g66bf33f09008 ***
[00:00:00.002,000] <inf> net_config: Initializing network
[00:00:00.002,000] <inf> net_config: Waiting interface 1 (0x20001390) to be up...
[00:00:00.004,000] <wrn> net_if: iface 0x20001390 is down
[00:00:01.006,000] <wrn> net_gptp: Reset Pdelay requests
[00:00:01.008,000] <wrn> net_if: iface 0x20001390 is down
[00:00:01.673,000] <inf> net_config: Interface 1 (0x20001390) coming up
[00:00:01.673,000] <inf> net_config: IPv4 address: <IP_ADDRESS>
[00:00:01.773,000] <inf> net_config: IPv6 address: 2001:db8::1
[00:00:01.773,000] <inf> net_config: IPv6 address: 2001:db8::1
[00:00:02.010,000] <wrn> net_gptp: Reset Pdelay requests
[00:00:03.015,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:04.016,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:05.018,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:06.019,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:07.020,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:08.022,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:09.023,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:10.025,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:11.026,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
uart:~$ net gptp
Port Interface          Role
 1   0x20001390 [1]     DISABLED

SiteSyncSync state machine variables:
        Current state                  : INITIALIZING
        A PortSyncSync struct is ready : no
ClockSlaveSync state machine variables:
        Current state                  : SEND_SYNC_IND
        A PortSyncSync struct is ready : no
        The local clock has expired    : no
PortRoleSelection state machine variables:
        Current state                  : ROLE_SELECTION
ClockMasterSyncReceive state machine variables:
        Current state                  : WAITING
        A ClockSourceTime              : yes
        The local clock has expired    : no

Environment (please complete the following information):
PTP server OS: Alpine Linux 3.18.3, ptp4l v4.1
Zephyr build platform: macOS 13.5.2, SDK v0.16.1, commit 66bf33f0900854a3df968e8a93a8dba4bd676c3f
Additional context

Looking at a packet capture of traffic between the board and the Linux box, it looks like the PTP peripheral clock isn't being initialised properly; it's running extremely fast.
In packet captures I can see the board putting Peer_Delay_Resp and Peer_Delay_Resp_Follow_Up onto the wire about 47µs apart, but with a delta of around 113ms in the PTP timestamps.
gptp.pcap.zip

@blackhelicoptersdotnet
can you check if it works on a Nucleo_H7xx and on Nucleo_F7xx please
That can help me to find the issue.

@blackhelicoptersdotnet
I am not able to test gPtp on my laptop ( sorry)
can you please  try on your side the following modifications ( #62632 )
Ethernet: gptp doesn't work at all on STM32H5 #62632
can you test it  with only the fist commit alone please

@Desvauxm-st Justed tested with first commit a23aab only, same result.
[00:12:03.531,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
I've gotten my hands on a nucleo_f767zi board, I can do some testing with that tomorrow also.

@blackhelicoptersdotnet
Thanks you very much for the test
The most important for us is to compare with the nucleo_H7xx ( normaly very similar as nucleo_H5xx ).

Looking much better on h5!
uart:~$ net gptp
Port Interface          Role
 1   0x20001390 [1]     SLAVE

SiteSyncSync state machine variables:
        Current state                  : RECEIVING_SYNC
        A PortSyncSync struct is ready : no
ClockSlaveSync state machine variables:
        Current state                  : SEND_SYNC_IND
        A PortSyncSync struct is ready : no
        The local clock has expired    : no
PortRoleSelection state machine variables:
        Current state                  : ROLE_SELECTION
ClockMasterSyncReceive state machine variables:
        Current state                  : SOURCE_TIME
        A ClockSourceTime              : yes
        The local clock has expired    : no
uart:~$ net gptp port 1
Port id    : 1 (SLAVE)
Interface  : 0x20001390 [1]
Clock id   : 00:80:e1:ff:fe:b7:12:f2
Version    : 2
AS capable : yes

Configuration:
Time synchronization and Best Master Selection enabled        : yes
The port is measuring the path delay                          : yes
One way propagation time on the link attached to this port    : 2149 ns
Propagation time threshold for the link attached to this port : 100000 ns
Estimate of the ratio of the frequency with the peer          : 1
Asymmetry on the link relative to the grand master time base  : 0
Maximum interval between sync messages                        : 375000000
Maximum number of Path Delay Requests without a response      : 3
Current Sync sequence id for this port                        : 64112
Current Path Delay Request sequence id for this port          : 38200
Current Announce sequence id for this port                    : 22341
Current Signaling sequence id for this port                   : 8303
Whether neighborRateRatio needs to be computed for this port  : yes
Whether neighborPropDelay needs to be computed for this port  : yes
Initial Announce Interval as a Logarithm to base 2            : 0
Current Announce Interval as a Logarithm to base 2            : 0
Initial Sync Interval as a Logarithm to base 2                : -4
Current Sync Interval as a Logarithm to base 2                : -4
Initial Path Delay Request Interval as a Logarithm to base 2  : 0
Current Path Delay Request Interval as a Logarithm to base 2  : 0
Time without receiving announce messages before running BMCA  : 3000 ms (3)
Time without receiving sync messages before running BMCA      : 0 ms (3)
Sync event transmission interval for the port                 : 62 ms
Path Delay Request transmission interval for the port         : 1000 ms
BMCA default priority1                                        : 248
BMCA default priority2                                        : 248

Runtime status:
Current global port state                                : SLAVE
Path Delay Request state machine variables:
        Current state                                    : WAIT_ITV_TIMER
        Initial Path Delay Response Peer Timestamp       :<PHONE_NUMBER>249939576
        Initial Path Delay Response Ingress Timestamp    :<PHONE_NUMBER>249941463
        Path Delay Response messages received            : 1
        Path Delay Follow Up messages received           : 1
        Number of lost Path Delay Responses              : 0
        Timer expired send a new Path Delay Request      : 0
        NeighborRateRatio has been computed successfully : 1
        Path Delay has already been computed after init  : 0
        Count consecutive reqs with multiple responses   : 0
Path Delay Response state machine variables:
        Current state                                    : INITIAL_WAIT_REQ
SyncReceive state machine variables:
        Current state                                    : WAIT_SYNC
        A Sync Message has been received                 : no
        A Follow Up Message has been received            : no
        A Follow Up Message timeout                      : no
        Time at which a Sync Message without Follow Up
                                     will be discarded   : 0
SyncSend state machine variables:
        Current state                                    : SEND_SYNC
        A MDSyncSend structure has been received         : no
        The timestamp for the sync msg has been received : no
PortSyncSyncReceive state machine variables:
        Current state                                    : RECEIVED_SYNC
        Grand Master / Local Clock frequency ratio       : 1.000000
        A MDSyncReceive struct is ready to be processed  : no
        Expiry of SyncReceiptTimeoutTimer                : no
PortSyncSyncSend state machine variables:
        Current state                                    : SYNC_RECEIPT_TIMEOUT
        Follow Up Correction Field of last recv PSS      : 0
        Upstream Tx Time of the last recv PortSyncSync   :<PHONE_NUMBER>
        Rate Ratio of the last received PortSyncSync     : 0.000000
        GM Freq Change of the last received PortSyncSync : 0.000000
        GM Time Base Indicator of last recv PortSyncSync : 0
        Received Port Number of last recv PortSyncSync   : 0
        PortSyncSync structure is ready to be processed  : yes
        Flag when the half_sync_itv_timer has expired    : yes
        Has half_sync_itv_timer expired twice            : no
        Has syncReceiptTimeoutTime expired               : yes
PortAnnounceReceive state machine variables:
        Current state                                    : RECEIVE
        An announce message is ready to be processed     : no
PortAnnounceInformation state machine variables:
        Current state                                    : CURRENT
        Expired announce information                     : no
PortAnnounceTransmit state machine variables:
        Current state                                    : POST_IDLE
        Trigger announce information                     : no

Statistics:
Sync messages received                 : 763
Follow Up messages received            : 862
Path Delay Request messages received   : 98
Path Delay Response messages received  : 99
Path Delay messages threshold exceeded : 0
Path Delay Follow Up messages received : 99
Announce messages received             : 96
ptp messages discarded                 : 0
Sync reception timeout                 : 16
Announce reception timeout             : 0
Path Delay Requests without a response : 3
Sync messages sent                     : 17
Follow Up messages sent                : 17
Path Delay Request messages sent       : 102
Path Delay Response messages sent      : 98
Path Delay Response FUP messages sent  : 98
Announce messages sent                 : 2
uart:~$

@blackhelicoptersdotnet
good
I will push another PR in HAL to fix this issue
Thanks you for your help

@blackhelicoptersdotnet
To push my new PR in our HAL branch i want associate your name so can you give me your git  signature
for exemple for me it is that  : Signed-off-by: Marc Desvaux<EMAIL_ADDRESS>thanks you

@Desvauxm-st certainly! Thanks for all your work on this.
Signed-off-by: Mathew Meins<EMAIL_ADDRESS>

@Desvauxm-st Definitely fixed for h5 but nucelo_f767zi is exhibiting the same same symptoms.
[00:00:49.144,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:50.145,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:51.147,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
[00:00:52.148,000] <wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
uart:~$ net gptp port 1
Port id    : 1 (DISABLED)
Interface  : 0x20021420 [1]
Clock id   : 00:80:e1:ff:fe:e8:3d:b6
Version    : 2
AS capable : no

Configuration:
Time synchronization and Best Master Selection enabled        : yes
The port is measuring the path delay                          : yes
One way propagation time on the link attached to this port    :<PHONE_NUMBER> ns
Propagation time threshold for the link attached to this port : 100000 ns
Estimate of the ratio of the frequency with the peer          : 0
Asymmetry on the link relative to the grand master time base  : 0
Maximum interval between sync messages                        : 10000000
Maximum number of Path Delay Requests without a response      : 3
Current Sync sequence id for this port                        : 9791
Current Path Delay Request sequence id for this port          : 30448
Current Announce sequence id for this port                    : 19677
Current Signaling sequence id for this port                   : 28908
Whether neighborRateRatio needs to be computed for this port  : yes
Whether neighborPropDelay needs to be computed for this port  : yes
Initial Announce Interval as a Logarithm to base 2            : 0
Current Announce Interval as a Logarithm to base 2            : 0
Initial Sync Interval as a Logarithm to base 2                : -4
Current Sync Interval as a Logarithm to base 2                : -4
Initial Path Delay Request Interval as a Logarithm to base 2  : 0
Current Path Delay Request Interval as a Logarithm to base 2  : 0
Time without receiving announce messages before running BMCA  : 1 ms (3)
Time without receiving sync messages before running BMCA      : 0 ms (3)
Sync event transmission interval for the port                 : 62 ms
Path Delay Request transmission interval for the port         : 1000 ms
BMCA default priority1                                        : 255
BMCA default priority2                                        : 248

Runtime status:
Current global port state                                : DISABLED
Path Delay Request state machine variables:
        Current state                                    : WAIT_ITV_TIMER
        Initial Path Delay Response Peer Timestamp       :<PHONE_NUMBER>855572216
        Initial Path Delay Response Ingress Timestamp    :<PHONE_NUMBER>00000053
        Path Delay Response messages received            : 1
        Path Delay Follow Up messages received           : 1
        Number of lost Path Delay Responses              : 0
        Timer expired send a new Path Delay Request      : 0
        NeighborRateRatio has been computed successfully : 1
        Path Delay has already been computed after init  : 0
        Count consecutive reqs with multiple responses   : 0
Path Delay Response state machine variables:
        Current state                                    : INITIAL_WAIT_REQ
SyncReceive state machine variables:
        Current state                                    : DISCARD
        A Sync Message has been received                 : no
        A Follow Up Message has been received            : no
        A Follow Up Message timeout                      : no
        Time at which a Sync Message without Follow Up
                                     will be discarded   : 0
SyncSend state machine variables:
        Current state                                    : INITIALIZING
        A MDSyncSend structure has been received         : no
        The timestamp for the sync msg has been received : no
PortSyncSyncReceive state machine variables:
        Current state                                    : DISCARD
        Grand Master / Local Clock frequency ratio       : 0.000000
        A MDSyncReceive struct is ready to be processed  : no
        Expiry of SyncReceiptTimeoutTimer                : no
PortSyncSyncSend state machine variables:
        Current state                                    : TRANSMIT_INIT
        Follow Up Correction Field of last recv PSS      : 0
        Upstream Tx Time of the last recv PortSyncSync   : 0
        Rate Ratio of the last received PortSyncSync     : 0.000000
        GM Freq Change of the last received PortSyncSync : 0.000000
        GM Time Base Indicator of last recv PortSyncSync : 0
        Received Port Number of last recv PortSyncSync   : 0
        PortSyncSync structure is ready to be processed  : no
        Flag when the half_sync_itv_timer has expired    : no
        Has half_sync_itv_timer expired twice            : no
        Has syncReceiptTimeoutTime expired               : no
PortAnnounceReceive state machine variables:
        Current state                                    : RECEIVE
        An announce message is ready to be processed     : no
PortAnnounceInformation state machine variables:
        Current state                                    : POST_DISABLED
        Expired announce information                     : yes
PortAnnounceTransmit state machine variables:
        Current state                                    : POST_IDLE
        Trigger announce information                     : no

Statistics:
Sync messages received                 : 243
Follow Up messages received            : 34
Path Delay Request messages received   : 34
Path Delay Response messages received  : 34
Path Delay messages threshold exceeded : 33
Path Delay Follow Up messages received : 34
Announce messages received             : 31
ptp messages discarded                 : 0
Sync reception timeout                 : 0
Announce reception timeout             : 0
Path Delay Requests without a response : 20
Sync messages sent                     : 0
Follow Up messages sent                : 0
Path Delay Request messages sent       : 54
Path Delay Response messages sent      : 34
Path Delay Response FUP messages sent  : 34
Announce messages sent                 : 0

Fixed by https://github.com/zephyrproject-rtos/zephyr/pull/62800