Cursor briefly jumps to the start of the line (Windows only)

Cursor  sways with this plugin,
I currently using MSYS2 in windows 10 with oh-my-zsh.
However, the Cursor will automatically change to the head of the line and then run back where it should be every time I tap the first few letters.
Such thing only happens with this plugin opened, and when I using windows terminal, If I use MSYS2 directly, it does not occur or I haven't noticed.

Seems like it's related to ConPTY
winpty/mintty are not affected
I faced same issue in any terminal with conpty backend (WIndows terminal/Alacritty/VS Code terminal)

There's related issue in conpty itself
https://github.com/microsoft/terminal/issues/364
But seems like it's dead

@wight554 Thanks!
@HernandoR Does the referenced issue describe your setup too?
If so, we should probably close this ticket as an upstream bug?

Uh that's an actual nightmare
MS guys lost that ticket perhaps, it's been 2 years since the last update
If nothing can be don't from plugin side, then there's no choice other than closing ticket

zsh-syntax-highlighting doesn't do anything related to positioning the cursor. zle (part of zsh) might, so you might try asking zsh-users@ with a minimal reproducer (one that's written in zsh -f and doesn't source anything).

Well it happens only with this (or fsyh) plugin enabled
Issue I linked higher has repro steps

Well it happens only with this (or fsyh) plugin enabled
Issue I linked higher has repro steps

I've seen that, but I stand by my recommendation to come up with a minimal reproducer, as outlined above — or, at least, as minimal as practicable.

I'm having this same issue, but I thought I would contribute with gif demonstrations, since this problem is kind of hard to describe.
Mintty:  with z-s-h, no z-s-h
WinTerm: with z-s-h, no z-s-h
I can confirm that the WinTerm behavior is identical in VS Code's integrated terminal.
This is an extremely niche use case (how many people are using zsh-syntax-highlighting on Windows?), so it's probably not a very high priority, and it's just barely noticeable enough to be distracting, but I thought I'd try to document the behavior, in case that's at all helpful.
Version Information
z-s-h: 0.8.0-alpha2-dev
zsh: 5.8 (x86_64-pc-cygwin)
Cygwin: 3.3.4
WinTerm: 1.11.3471.0
Mintty: 3.6.0
VS Code: 1.66.0

@chrstophr-wltrs Thanks, that's very helpful.  Could you upload the gifs as attachments to your next comment, please?  See instructions at the bottom of the textarea comments are entered in.

Yes, absolutely! Sorry about that, I've updated the links in my first post to point to images hosted on Github instead of gfycat.


Fixed error on Rust master - no drop flag requires feature

Note: it builds buf for test pass it also requires https://github.com/cgaebel/iobuf/pull/8 to land


Request for adding support for commonJS' module.exports

Hello,
I would like to kindly request for adding support for handling scripts which use commonJS modules.
I like the current module API with the asynchronous callback when the module is ready, it would be great if this will be extended with commonJS syntax.
Some background: currently I'm trying to use JS script, which uses commonJS modules, from the native application (written in C++) with bundled ChakraCore library in version 1.8.1 (I'm using the official nuget).
My goal is to call specific functions from the script. As module.exports is not supported in the ChakraCore I've tried to access the global object, get its parameters (in this case the function which I'm interested in). Then prepare arguments and use function reference to execute it.
Unfortunately, during invoking JsCallFunction I'm receiving an exception with a well-known access violation (0xC0000005).
The question is: does usage of a script with module.exports can cause undefined behavior? Is working on a solution with global object worth trying?
The code is simple, I'm inserting a PoC function, result checks are removed for readability purposes but all functions are returning JsNoError (0).
Code snippet:

void jsTest(const std::string & defJson, const std::string & fsItem)
{
	JsRuntimeHandle runtime;
        JsContextRef context;
        unsigned currentSourceContext = 0;
        JsValueRef scriptResult;

	JsCreateRuntime(JsRuntimeAttributeNone, nullptr, &runtime);

	JsCreateContext(runtime, &context);

	JsSetCurrentContext(context);

	JsRunScript(script.c_str(), currentSourceContext++, L"", &scriptResult);
	// script is saved in string variable, JsRunScript doesn't return error code

	JsValueRef uicObject;
	JsGetGlobalObject(&uicObject);

	JsPropertyIdRef propId;
	JsGetPropertyIdFromName(L"ScriptObj", &propId);

	JsValueRef objRef;
	JsGetProperty(uicObject, propId, &objRef);

	bool hasProperty = false;
	jsErr = JsHasProperty(uicObject, propId, &hasProperty); // property is found

	// Internal property of property got above:
	JsPropertyIdRef propInside;
	jsErr = JsGetPropertyIdFromName(L"ObjectsFunctionName", &propInside); // name of the function to execute

	JsValueRef functionRef;
	jsErr = JsGetProperty(objRef, propInside, &functionRef);

	JsHasProperty(uicObject, propId, &hasProperty); // function ref found

	JsValueRef defJsStr;
	jsErr = JsCreateString(defJson.c_str(), defJson.length(), &defJsStr); // string length: 10897 B

	JsValueRef fsItemJsStr;
	jsErr = JsCreateString(fsItem.c_str(), fsItem.length(), &fsItemJsStr); // string length: 128 B

	JsValueRef argsArray;
	unsigned short argCount = 3;
	jsErr = JsCreateArray(argCount, &argsArray);
	if (jsErr == JsNoError) {
		JsValueRef valueHolder;

		for (int argIndex = 0; argIndex < argCount; ++argIndex) {
			switch (argIndex) {
				case 0:
					valueHolder = objRef;
					break;

				case 1:
					valueHolder = defJsStr;
					break;

				case 2:
					valueHolder = fsItemJsStr;
					break;

				default:
					break;
			}

			JsValueRef jsIndex;
			JsDoubleToNumber(argIndex, &jsIndex);

			JsSetIndexedProperty(argsArray, jsIndex, valueHolder);
		}
	}

	JsValueRef functionResult;
	jsErr = JsCallFunction(functionRef, &argsArray, argCount, &functionResult);
	// during this call exception occurs - access violation

	JsSetCurrentContext(JS_INVALID_REFERENCE);
	JsDisposeRuntime(runtime);
}

Disassembled view:
Address:  Unhandled exception at 0x52AA94BE.
ContextAPIWrapper_Core<0,<lambda_1384bd1e534aad1012a12767fca3a5e8> >(ContextAPIWrapper::__l2::<lambda_1384bd1e534aad1012a12767fca3a5e8>)
ASM:
      }
       END_ENTER_SCRIPT
512071B8  lea         ecx,[__enterScriptObject]  ; this line throws
       }
       END_ENTER_SCRIPT
512071BB  mov         dword ptr [errCode],eax

What's interesting: when I replace argsArray initialization done via JsCreateArray with just simple:
JsValueRef argsArray[] = {objRef, defJsStr, fsItemJsStr}; I'm receiving:

Unable to get property 'indexOf' of undefined or null reference

as expected, so is my use of JsCreateArray invalid?
I would appreciate any other ideas on how to access the desired function.
Thanks,
Piotr

I believe that the main error in your code at the moment is how you invoke JsCallFunction. Right now you are effectively passing it a C-style array with one entry (that entry being the javascript array argsArray, but telling it that it has argCount entries in it. The other gotcha here is that the first argument to a function is the this parameter, so your code is somewhat similar to theFunction.call(argsArray) which probably isn't what you want to do.
I suspect that this is closer to your intention:
// Assuming objRef is supposed to be the `this` argument
JsValueRef args[3] = { objRef, defJsStr, fsItemJsStr };
jsErr = JsCallFunction(functionRef, args, 3, &functionResult);

Ah, just saw your bit at the end where you mention you do that. What are you actually trying to achieve with the javascript array then? Does your script function expect to be given a single argument which is the javascript array? If so, then you want something more like
JsValueRef args[2] = { thisArg, argsArray }; // thisArg could be the javascript `undefined` if you don't have a better candidate
JsCallFunction(functionRef, args, 2, &functionResult)

Hi @MSLaguana,
The JS function requires two arguments, I thought that I need to pass them in the array but this seems to be wrong.
The declarations is like:
function foo (firstParam, secondParam) {//...}
Hi @fatcerberus,
Thanks for the background! I haven't known that as I'm kinda new to JS.
I had a conversation with @MSLaguana about CommonJS and that it's all about host implementing appropriate actions. As I don't know how to deal with it and the global object is available I'm trying the current approach. Still handling this by a host seems interesting. Do you recommend further reading to get some knowledge?
A little bit of background - the java-script that I'm using is an output from browserify tool as the code itself is mainly executed by browsers.

@piotr-walczak If it helps, you can think of JsCallFunction(func, args, argLength, &result) as being similar to the javascript code result = func.apply(args), if args has argLength elements in it. In your case, to call foo(arg1,arg2) from javascript, you would need to call foo.apply([thisArg, arg1, arg2]) since the first parameter is the this parameter. The difference with using JsCallFunction is that we use a c-style array, rather than a javascript array, for the arguments, so that corresponds with
JsValueRef args[3] = {thisArg, arg1, arg2};
JsCallFunction(foo, args, 3, &result);

Does that help?

@piotr-walczak You don't necessarily have to implement it in the host - you can actually do it directly in JS (like I said there's no real magic here).  Here's some pseudocode:
let source = readFileAsString(moduleFileName);
let wrappedSource = `(function(exports, require, module) { ${source}\n})`;
let wrapper = eval(wrappedSource);

let exports = {};
let module = { exports, fileName: moduleFileName, id: moduleFileName };  // etc.

// get a new require() that works relative to moduleFileName, maybe use a closure for this
let require = newRequireFunction(moduleFileName);

// execute the module
wrapper(exports, require, module);

/* read back `module.exports` here to find out what was exported */

@MSLaguana,
Yup, not it's clear, thanks for providing an example!
The JsCallFunction now return JsNoError. There is an exception but it comes straight from the JS code, so I need to talk with devs to work it out.
Thanks!
@fatcerberus,
Thanks, this is another approach, in this case adding separate support for CommonJS syntax seems to be worthless.

The pseudocode I posted above is pretty much exactly what Node.js does... well, minus some extra bells and whistles. :smile:

@MSLaguana,
I have some additional questions. ;)
You wrote that using JsCallFunction is similar to calling result = func.apply(args).
In JS *.apply() requires: fun.apply(thisArg, [argsArray]), so thisArg is seperated from the fun arguments which are passed as array. It's visible that JsCallFunction is different, because thisArg is passed in array. This is only syntax difference or there is something behind this decision?
Currently, when I'm invoking JsCallFunction, the script is returning an exception, I've used JsGetAndClearExceptionWithMetadata to get more details.
Here comes the interesting part: my friend is using the same script in swift code @ macOS. He is using JavaScriptCore library. He was able to reproduce the same exception as I'm facing when he used func.apply(thisArg, [args]) call. What's really strange, the script works as expected when he's using call() method.
Suddenly there is no exception.
As far as I was able to find, JavaScriptCore is using WebKit, so when he's using call() the JSObjectMakeFunction() is invoked.
Currently, I have no idea why there is an exception when calling apply() but there is none when using call(). The question I've got: is it possible to use ChakraCore and execute JS' call() instead of apply()? I'm curious if this gonna work also for me. I would like to get something similar to this notation: var res = objRef.functionRef.call(thisArg, first, second) which corresponds to:
function foo(first, second) {} from the object that I've under ObjRef (as JsValueRef).

.call() and .apply() do exactly the same thing.  The only difference is the API surface: .call() takes a list of arguments (like a normal function call) while the other takes the argument list as an array.  To illustrate:
function fun(x, y)
{
    print(`x: ${x}`);
    print(`y: ${y}`);
}

fun.call(undefined, 812, 1208);
/* ...does exactly the same thing as... */
fun.apply(undefined, [ 812, 1208 ]);

It would be highly irregular to get an exception in one circumstance but not the other.  Are you sure you're using .apply() correctly?

@fatcerberus,
It turned out that this problem is caused by input arguments. The strings representing JSON objects have unwanted escape characters, so the script doesn't recognize them as valid JSON.
eg.: {\"id\":\"msId3\",\"text\":\"void\"}.


Improve tpm2.verify_ek to speed up cert matching

Currently we are brute forcing the entire list of signing certs by TPM manufacturers:
see https://github.com/mit-ll/python-keylime/blob/master/keylime/tpm2.py#L625
for signer in trusted_certs:
   signcert = M2Crypto.X509.load_cert_string(trusted_certs[signer])
   signkey = signcert.get_pubkey()
   if ek509.verify(signkey) == 1:
       logger.debug("EK cert matched signer %s"%signer)
       return True

This can be improved by determining the correct CA to check against based on info from the EK certificate, saving the trouble of a brute force.

keep this one

keep alive

keep

Hi, I would like to work on this issue

hi @donky106 , sure  - thanks.
Are you familiar with what needs doing?
One note, the code has changed a little since the issue was raised, mainly instead of having the certs in one big python file they are now pem files resident here

Thanks for assigning. I appreciate that.
currently you extract the CA=certificate authority, i.e. the signer from each certificate in the array [trusted_certs].
With a public key of that CA you verify the X.509 certificate.
To avoid a brute force trying each trusted certificate you would like to determine the correct CA first. And verify with the correct CA.
The X.509 certificates are PEM-encoded.
Am I right?

Thanks @donky106 , you can ping @jetwhiz if you need to clarify anymore in the gitter channel

@donky106 you will need a HW tpm to test this (the emulator has no EK). I can do this for you on a machine I have here (unless you have one yourself). Just add me to the PR review. Thanks again!

I have no HW tpm to test. Could you please do this for me on your machine? Thanks.
Also I have got this error:
Adding message: Thanks for your PR. Please check the CI travis job to make sure the build passes and fix any failures. Many thanks for your contribution! to pull request 286
##[error]Resource not accessible by integration
But the CI travis job seems to be ok


MySQL generateChangeLog generates ENUM types incorrectly as ENUM with a numerical precision

Search first

[X] I searched and no similar issues were found

Description
I found this bug in the liquibase forms 10 years ago and was said to be resolved so this is possibly a regression: https://forum.liquibase.org/t/generatechangelog-does-not-work-with-enum/2772
When using generateChangelog for a MySQL database the MySQL enum datatype is incorrectly generated as enum(7) or other precision this causes an error if you try to update with that value as it is invalid for MySQL.
mysql server version 5.7.41
liquibase version: 4.20.0
This is a follow on from a forum post I created: https://forum.liquibase.org/t/liquibase-generate-changelog-doesnt-work-with-mysql/8059
This also occurs with a mariadb configured liquibase client on a MySQL server.
Steps To Reproduce
Create the following table
CREATE TABLE `liquibase_example_table` (
    id INT(11) NOT NULL AUTO_INCREMENT,
    enum_column ENUM('option1', 'option2', 'option3') NOT NULL,
    json_column JSON NOT NULL,
    text_column TEXT NOT NULL,
    INDEX text_column_idx (text_column(100)),
    PRIMARY KEY (id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;

Run create changelog and the output will have the incorrect datatype.
-- liquibase formatted sql

-- changeset root:1681305995631-1
CREATE TABLE liquibase_example_table (id INT AUTO_INCREMENT NOT NULL, enum_column ENUM(7) NOT NULL, json_column JSON(1073741824) NOT NULL, text_column TEXT NOT NULL, CONSTRAINT PK_LIQUIBASE_EXAMPLE_TABLE PRIMARY KEY (id));

-- changeset root:1681305995631-2
CREATE INDEX text_column_idx ON liquibase_example_table(text_column);

Expected/Desired Behavior
The generatedChangelog should be similar to the original create statement so:
-- liquibase formatted sql

-- changeset root:1681305995631-1
CREATE TABLE liquibase_example_table (id INT AUTO_INCREMENT NOT NULL, enum_column ENUM('option1', 'option2', 'option3') NOT NULL, json_column JSON NOT NULL, text_column TEXT NOT NULL, CONSTRAINT PK_LIQUIBASE_EXAMPLE_TABLE PRIMARY KEY (id));

-- changeset root:1681305995631-2
CREATE INDEX text_column_idx ON liquibase_example_table(text_column(100));

Liquibase Version
liquibase version: 4.20.0
Database Vendor & Version
MySQL server version 5.7.41
Liquibase Integration
CLI
Liquibase Extensions
none
OS and/or Infrastructure Type/Provider
Ubuntu 20.04
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

I found this problem occurs when using a SQL changelog. It does not occur with xml changelog.

@OisinWard this should be resolved as per https://github.com/liquibase/liquibase/pull/3842

This is not fixed when using generate changelog for a sql type changelog. It is fixed for an xml type changelog. Still an issue.


Include sign in with apple variables in the default supported environment variables

**Is your feature request related to a problem?
Recently sign in with apple option is added to the supported options in the CLI (5.1.2).  However, the console environment variables page does not specify the default variables for sign in with apple . Please update it.
https://docs.aws.amazon.com/amplify/latest/userguide/environment-variables.html
Describe the solution you'd like
Some thing like this

You can add sign in with apple env variables through SSM parameter store. Docs are currently being updated.
https://github.com/awsdocs/aws-amplify-console-user-guide/pull/50


Feature set sql and defaultDb fields in show-load-profile.

Proposed changes
When execute show load profile '/', the value of SQL and DefaultDb columns are all 'N/A', but we can fill these fields，the result of this pr is as follows:
Execute show load profile '/'\G:
MySQL [test_d]> show load profile '/'\G
*************************** 1. row ***************************
   QueryId: 652326
      User: N/A
 DefaultDb: default_cluster:test_d
       SQL: LOAD LABEL `default_cluster:test_d`.`xxx`  (APPEND DATA INFILE ('hdfs://xxx/user/hive/warehouse/xxx.db/xxx/*')  INTO TABLE xxx FORMAT AS 'ORC' (c1, c2, c3) SET (`c1` = `c1`, `c2` = `c2`, `c3` = `c3`))  WITH BROKER broker_xxx (xxx)  PROPERTIES ("max_filter_ratio" = "0", "timeout" = "30000")
 QueryType: Load
 StartTime: 2023-01-12 18:33:34
   EndTime: 2023-01-12 18:33:46
 TotalTime: 11s613ms
QueryState: N/A
1 row in set (0.01 sec)

Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.04 seconds
load time: 492 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112150638_clickbench_pr_78899.html


fix(combineLatest): emit unique arrays from the default projection

Description:
Fixes combineLatest to emit unique array instances when using the default projection. Without this fix, the default projection emits a shared array (which causes all sorts of problems).
The included test fails against the un-patched combineLatest thusly:
combineLatest should emit unique array instances with the default projection
(expected c === 3, actual c === 1)

Related issue:
#1686

Chang looks ok to me. Will leave opened for other reviewer's approval.

Coverage remained the same at 96.701% when pulling 63ae506a7ded2bf295bb4a5a0369be27a557f85f on mark-buer:combine-latest-fix into 5760d5a7913143a36013e4fbbc0f39fbe1d31248 on ReactiveX:master.

Hmm, I'm not so welcoming to this change, we should see what impact it has on performance. I suppose it will have a meaningful negative impact. Also, I wouldn't recommend using plain distinct when the values are arrays or objects, I would use the keySelector parameter to calculate a hash of the array, in order to compare by contents, not by reference/pointer.

we should see what impact it has on performance. I suppose it will have a meaningful negative impact

Yes, there should be perf impact but I'm leaning on behavior first. but that seems very valid concern.
@mark-buer , would you mind to post micro-bench before vs. after to see how much new change loses?

RxJS v4 doesn't clone the array. https://github.com/Reactive-Extensions/RxJS/blob/master/src/modular/observable/combinelatest.js#L49
Neither does xstream nor most.js.
Should we wait for more people to give their opinions?

Discussions at https://github.com/ReactiveX/rxjs/issues/1686, we could use those issue to continue discussion.

RxJS v4 doesn't clone the array

it's interesting, I thought issue was created by different behavior between v4 to v5. I just didn't try it myself.

distinctUntilChanged comparing references of arrays is almost always a bad idea:

a === b may return true even though the content of those two are different if they point to the same array instance.
a === b may return false even though the content of those two are the same if they point to different array instances.

Looking at the source Rxjs4 does clone the array, hence the comments in #1686.
see: https://github.com/Reactive-Extensions/RxJS/blob/29f85627e4ab71b050480f26dcc5d737f1b840f4/src/modular/observable/combinelatest.js#L23-L27

@staltz This bug fix has no connection with distinct or distinctUntilChanged.
I'm of the opinion that performance should always take second place to correct operation.
If people prefer to have broken but fast behaviour, in this case, they can "opt-in" by supplying their own broken projection function.
I'll repeat my comment from #1686 here:
No additional operators are required to illustrate the incorrect and thus surprising behaviour of combineLatest.
This code:
var as = new Rx.Subject();
var bs = new Rx.Subject();

// Default projection
Rx.Observable.combineLatest(as, bs)
    .observeOn(Rx.Scheduler.asap)
    .subscribe(function(c) { console.log('default projection [' + c[0] + ', ' + c[1] + ']') });

// Custom projection
Rx.Observable.combineLatest(as, bs, function(a, b) { return [a, b] })
    .observeOn(Rx.Scheduler.asap)
    .subscribe(function(c) { console.log(' custom projection [' + c[0] + ', ' + c[1] + ']') });

as.next(0);
bs.next('x');
as.next(1);
bs.next('y');
as.next(2);

Produces the output:
default projection [2, y]
 custom projection [0, x]

default projection [2, y]
 custom projection [1, x]

default projection [2, y]
 custom projection [1, y]

default projection [2, y]
 custom projection [2, y]

(note the different results between the default projection function and the custom projection function, crazy!)
The lack of array copy within the operator implementation causes incorrect asynchronous results for the default projection.
To fix this:

for the case where a custom projection function is provided, no array copy is required,
for the case of the default projection function, array copy is required to produce correct results.

Thus, only the default projection code path will be affected.
If one values (GC) performance above and beyond "correct" behaviour, one could supply a suitably broken projection function. i.e. a projection function that returns a cached array/object.

@mark-buer unfortunately not, since the array of combined values is applied to the projection function. I'm not against this change, but one could argue combineLatest shouldn't copy the Array (for performance) and if required, a unique Array could be created with a custom projection function.

@trxcllnt Sorry, I wasn't meaning to imply that one could supply a projection function that returns the exact (private) array instance internal to the operator. What I meant was a projection function something like this:
let scaryReusedArray = [0, 0];
Rx.Observable.combineLatest(as, bs, function(a, b) {
    scaryReusedArray[0] = a;
    scaryReusedArray[1] = b;
    return scaryReusedArray;
})

i.e. the user takes on the responsibility for emitting this cached array that is acting as shared mutable state.
Yes, there is a obviously a performance hit with the apply and the extra redirection. And yes, that array is more reused than the internal one. But I hope that conveys the gist of the idea.
With this bug, we are talking about default operators with perfectly normal input data producing wrong results.
Is anyone arguing that adding .observeOn(Rx.Scheduler.asap) (or other operators as in #1686) to combineLatest should result in nonsensical output data?
I stumbled onto this "WTF" by sheer accident while tinkering with the API (assessing the suitability of rxjs for our new MVVM-based thick client). I lost an hour or so of my life getting to the bottom of this problem. Judging by #1686, I'm not the only one, and I doubt we will be the last.
If the broken behaviour is working as intended, it needs to be documented by someone who can justify and explain why it is so. i.e. don't make developers find this surprising behaviour by themselves. The full impact and ramifications of emitting this cached mutable array are widespread, it is a gift that just keeps on surprising as one chains more and more operators and adds asynchronicity into the mix.
Suggestions (for those who value performance over correctness):
Add a new operator which replicates the existing cached-array behaviour. This new operator will not allow the use of a custom projection function. Ideas for names are:
combineLatestCached, combineLatestShared or combineLatestFast (or tongue in cheek, combineLatestSurprise or combineLatestPleaseDontUseForAsync).
Or, add an overload for the existing operator. One could pass in boolean false as the projection function parameter to get slice behaviour (the new default), boolean true as the projection function parameter to get cached array behaviour (the current surprising default), or pass in a custom projection function as usual.
I'd like this PR be approved to fix what is currently broken, and that a follow up PR addresses potential performance concerns. Or it could be values of this framework don't align with what our team is looking for... no probs, sorry to waste everyones time. We'll seek out an alternative that values correctness and then performance, in that order.

LGTM

I'm with @mark-buer on this, correct behavior first, then optimize performance as necessary. There are a number of options if this is a performance bottleneck for some use-cases, but honestly if that's the case, there are many other places we should look to optimize before this.

For context, this is how RxJS v4 behaves
https://jsbin.com/juyurikofo/1/edit?js,console
because
https://github.com/Reactive-Extensions/RxJS/blob/master/src/modular/observable/combinelatest.js#L104

And adding in rxjs5 behavior things break down.
https://jsbin.com/nunejirubi/1/edit?js,console

Coverage remained the same at 96.707% when pulling 070a2ae49c97fa15ac0273aceba1d75f538327f9 on mark-buer:combine-latest-fix into 5a895e87a670ed2af9435e97c9aca927cb1d492f on ReactiveX:master.

hey @mark-buer we absolutely value correctness over performance as a general guideline. It just sounds like some of us don't believe this is truly "correct".
I'm in the camp of believing it could go either way as far as "correct", but would rather error on the side of copying because it appears to me it's more likely to reduce potential bugs than create them.
@blesh make the call please.

This PR LGTM. I think we should add a perf test around shared default array use cases. But regardless, I like this PR.
:shipit:

@mark-buer rebase plz :shipit:

Coverage remained the same at 96.723% when pulling 2e30fd11efe42a4668e24548cd9474d568871a77 on mark-buer:combine-latest-fix into 897fe3b16a957b8808089379dfabdfd80b00509a on ReactiveX:master.

Thanks @mark-buer and everyone else for chiming in!


Rev version in 'package.json' to 1.0.3

This commit revs the version in 'package.json' to 1.0.3 in preparation
for publishing an updated package/module.
modified:   package.json

should hook this up to travis and use semantic release

Ill file a task to do so.
You are referring to https://github.com/semantic-release/semantic-release, right?


Rebuilding native code doesn't work

When I try to rebuild native code as described in Readme, I get the following error:
cp: .../rive-android/cpp/../submodules/rive-cpp/build/bin/debug/librive.a: No such file or directory
Not sure, what's wrong, maybe something's wrong with my setup:
MacOS 10.15.7,
NDK version 22.0.7026061

Yes, I did, maybe I need to install something else? C/C++ is not what I usually do, so It's very likely that I'm missing something basic.

Managed to build eventually, just needed to properly configure premake


Fix condition to make revision test skip on k8s <1.16

Fixes #30572, conditional skip got flipped
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

/retest

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
ebd1a6c6a33185ded85da344147a4109fe79dede
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest


No documentation for image/layer size limitations

The size of the docker aufs filesystem does not appear to be documented or configurable. I currently have an 6 GB image that fails to deploy:
InnerException: Docker.DotNet.DockerApiException, Docker API responded with status code=InternalServerError, response={"message":"OCI runtime create failed: container_linux.go:345: starting container process caused "process_linux.go:424: container init caused \"rootfs_linux.go:58: mounting \\\"/var/LWASFiles/Sites/large-test-image_Common/appsvctmp\\\" to rootfs \\\"/mnt/data/docker/images/231072.231072/aufs/mnt/748b8b348d14ab59cfaad214c94ca5e0785eb3d28d2f46aa4b2b42f233422f78\\\" at \\\"/mnt/data/docker/images/231072.231072/aufs/mnt/748b8b348d14ab59cfaad214c94ca5e0785eb3d28d2f46aa4b2b42f233422f78/appsvctmp\\\" caused \\\"mkdir /mnt/data/docker/images/231072.231072/aufs/mnt/748b8b348d14ab59cfaad214c94ca5e0785eb3d28d2f46aa4b2b42f233422f78/appsvctmp: no space left on device\\\"\"": unknown"}
however it's not clear if this is simply an App Service bug or /tmp (or some other filesystem) is full. Does it depend on the instance type of the App Service plan?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6489b871-9cf8-7c99-9834-076ec646d0e6
Version Independent ID: fa5d2995-5833-c04b-2530-c100bcd1e76b
Content: Configure custom container - Azure App Service
Content Source: articles/app-service/containers/configure-custom-container.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@tedgoddard Thanks for your question. We are checking on this and will respond to you soon.

@tedgoddard, Apologies for the delay! Yes. Your app can ran out of space on the Docker images drive. Deployments with newer and bigger docker images that have a little in common with previous images, would result in running out of space on the docker image folder on the instance. That’s why we recommend using Medium or Large instances in such cases, which have more space for the docker images folder. Checkout the doc Azure App Service on Linux FAQ for the configuration details. Also, kindly refer this document for the information on the Disk space across the App Service plan.
Thanks again for your feedback! We will close this out, but if you feel you need more information please just let us know.

I ran into this issue and this document helped more than any of the ones linked to above (specifically, the Disk size in GB line in the VM disk types table). They also explain what the temporary disk is in that article.


[feature request]: Add Temporal polyfill

What
Any plans to support Temporal (Stage 3)?

Otherwise this is to link to an existing issue on one of the Temporal polyfill's repositories for when its ready for production.

Details
Temporal API Proposal: https://tc39.es/proposal-temporal/docs/index.html
Polyfill Question: https://github.com/js-temporal/temporal-polyfill/issues/15

Hi @IgnusG, this project aims to only implement stage 4 features as stage 3 is still experimental, if the feature makes it to stage 4 then we will look into adding a polyfill into polyfill-library (which powers polyfill.io)


feat: add attribute to a65

Added this and more missing attributes via https://github.com/copystring/ioBroker.roborock/commit/a55bd267b99cd16d91fb8b1ba619f93e932f322f


Needed documentation for version 0.3

Hello - i'm working with 0.3 version and have a problem with deleting github repo, more precisely with error
< ./drone delete github.com/foo/bar Unauthorized
Please provide docs or help with Authorization.
Thank you.

0.3 alpha is no longer supported and is end of life. If you need to delete a repository I recommend logging into the database to do so. delete from repos where repo_name=?


hide recording overlay when ingame Hud is Off

The recording overlay was still visible when Hud was toggle Off ingame
Not anymore

Do we still want to do it this way? Knowing that there are some issues still with detecting HUD off on servers.


mix run takes file arguments

Fixes #5672
Allow file completion when using the mix run command

:+1:
Source: https://hexdocs.pm/mix/Mix.Tasks.Run.html


Run futurize to make code-base python 3 compatible.

CC @richafrank

@twiecki Based upon the travis build matrix, I had thought pyfolio is already py3 compatible. Does this mean that there's just not test coverage for these changed functions?

I was surprised too, so yes, seems like that's not tested.

This introduces a few problems.


Upgrade Jetty to latest version

We should update Jetty, as the version we are using has some security advisories against it.

LGTM.
Any issues with updating it, i.e. test failures? (we should setup a Jenkins build for PRs, I think @bdemers already did it for SCIMple)


Fix Linux and Windows CI build

Last commit pointed to local copy of MFEKmath. This points back at the git repository and updates the Cargo.lock to use the latest version

Closing since at this point, this PR isn't actually productive on its own, can be rolled into a different PR entirely


ProjectFactory + API Route - Add User to Project (by email address if they're not signed up or userID if they are)

deleteProject - delete a project by id
getProjectsByOrganizationId - get all projects based on organizationId
addUserToProject - add a userId to a project's userlist


Updating readme from branch example

Updates
I updated the readme file. Please review and accept.

emote test :1st_place_medal:


Create color json

Hi there! I'm sorry I just saw this, but I was wondering if you could provide some context to this PR, as to what it does/addresses? Thanks! :)


Feature/cls2 703 use status instead of archive on task complete api call

Description of change

Checklist

[ ] Has this branch been rebased on top of the current main branch?

Explanation
The branch should not be stale or have conflicts at the time reviews are requested.

[ ] Is the CircleCI build passing?

General points

Other things to check

Make sure fixtures/test_data.yaml is maintained when updating models
Consider the admin site when making changes to models
Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Moved to other PR


Enviromental Controller No Teleport Effect remains

Noticed this bug while using this in a enderman farm.
Setup is: Ender IO Spawner/killer joe with vacuum chest in a enderman setup.
I have a enviromental controller setup with a 20 yard range, +-10 range height and only effect in it is the no teleport effect.
If you turn on the machine, it will apply the effect to you and if you try to use the porter (or advanced) it will just ... say its starting and then end it there. I believe all RF is deducted but the move is not performed. If you try to teleport to a receiver in this 'area' it will also say your teleporting but never move you (Even if your long ways away).
If the controller runs out of mana or is redstone deactivated and if you even wait... say 1 minute so the effect should be fully removed, you still cannot teleport. If you go into the machine and remove the effect then place it back in, you can teleport just fine.
I recommend you add teleport messages (to and from) incase they are blocked so the user knows why. (I spent a good 10 mins figuring this out LOL) and of course address the bug nature of it if at all possible.
Using 1.10, RFTools 5.11, Dim 4.30 beta46 (pretty much all rftools as a week ago or so).

That bug has been fixed. RFTools 5.11 is pretty old (we're at 5.15 now)
Note also that you should set the environmental controller to affect mobs only so that you as a player are not affected


Add support for Permanent Lights Pro [H706C]

Which model is this? Need the Hxxxx number.

H706C

Which type of device is this? Light, heater, leak sensor, etc.

Light - permanent outdoor

Which connection methods does this device have? Wifi? Bluetooth? LAN mode? All?

WiFi. BLE. LAN.

Anything else?

A copy of the output from HomeBridge
{"ip":"<IP_ADDRESS>","device":"1E:D2:FD:1E:17:A2:16:57","sku":"H706C","bleVersionHard":"3.04.01","bleVersionSoft":"1.00.14","wifiVersionHard":"1.04.01","wifiVersionSoft":"1.01.11","httpInfo":{"groupId":0,"device":"1E:D2:FD:1E:17:A2:16:57","sku":"H706C","spec":"","versionHard":"3.04.01","versionSoft":"1.00.14","deviceName":"Lower Pro String","deviceExt":{"deviceSettings":"{"wifiName":"CB23","address":"FD:1E:17:A2:16:57","bleName":"Govee_H706C_1657","topic":"GD/0c52436ad840108b0475c1024fbc5565","wifiMac":"60:74:F4:8C:FC:A6","pactType":1,"pactCode":1,"wifiSoftVersion":"1.01.11","wifiHardVersion":"1.04.01","ic":30,"secretCode":"dMb9HheiFlc=","boilWaterCompletedNotiOnOff":1,"completionNotiOnOff":1,"autoShutDownOnOff":1,"dspVersionSoft":"13","segmentCount":24,"sku":"H706C","device":"1E:D2:FD:1E:17:A2:16:57","deviceName":"Lower Pro String","versionHard":"3.04.01","versionSoft":"1.00.14","playState":false}","lastDeviceData":"{"online":false}","extResources":"{"skuUrl":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/798230d5d5982ba58b8c796c523c3ecd-add_list_type_device_706c.png\",\"headOnImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/dc58b1f4592275085d753a11342f7748-706c_light_title_on.png\",\"headOffImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/2f2589a1d94d8d0c369c8d360384b859-706c_light_title_off.png\",\"ext\":\"\",\"ic\":120}"},"pactType":1,"pactCode":1,"share":0,"goodsType":180,"attributesId":49,"supportScene":0},"model":"H706C","deviceName":"Lower Pro String","isLANDevice":true}

Can you add support for the H706A too
[Front LED Lights] is not currently supported, do create a Github issue with the following info:
{"ip":"<IP_ADDRESS>","device":"36:99:F1:F1:A7:4B:D6:80","sku":"H706A","bleVersionHard":"3.04.01","bleVersionSoft":"1.00.14","wifiVersionHard":"1.04.01","wifiVersionSoft":"1.01.17","httpInfo":{"groupId":0,"device":"36:99:F1:F1:A7:4B:D6:80","sku":"H706A","spec":"","versionHard":"3.04.01","versionSoft":"1.00.14","deviceName":"Front LED Lights","deviceExt":{"deviceSettings":"{"wifiName":"DMB #41 (2G)","address":"F1:F1:A7:4B:D6:80","bleName":"Govee_H706A_D680","topic":"GD/8d0e8155b27869a8bb1c047b29c69a5b","wifiMac":"60:74:F4:7D:72:CD","pactType":1,"pactCode":1,"wifiSoftVersion":"1.01.17","wifiHardVersion":"1.04.01","ic":60,"secretCode":"f2Hx8adL1oA=","boilWaterCompletedNotiOnOff":1,"completionNotiOnOff":1,"autoShutDownOnOff":1,"dspVersionSoft":"13","segmentCount":9,"sku":"H706A","device":"36:99:F1:F1:A7:4B:D6:80","deviceName":"Front LED Lights","versionHard":"3.04.01","versionSoft":"1.00.14","playState":false}","lastDeviceData":"{"online":false}","extResources":"{"skuUrl":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/110c816f749f75640260511c333a1065-add_list_type_device_706a.png\",\"headOnImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/8e57eab8d1c8c6d9f280be7e4460b0d2-706a_light_title_on.png\",\"headOffImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/a4e9d925c3c788fc25adde52e44349a8-706a_light_title_off.png\",\"ext\":\"\",\"ic\":120}"},"pactType":1,"pactCode":1,"share":0,"goodsType":180,"attributesId":49,"supportScene":0},"model":"H706A","deviceName":"Front LED Lights","isLANDevice":true}

Thank you for adding support in 10.2.0


->select not returning connections to the Hikari pool.

Description:
failed to execute select query: error while getting the connection for ClientConnector. HikariPool-1 - Connection is not available, request timed out after 30013ms.
My select call against a database table was working recently, now it returns nothing, an object that is of the right table type but nothing in it and no error.
->update functions working for insert, update and delete
address.zip
behaves the same regardless if running from ballerina run command or java -jar
Change pool size from 5 to 10 connections, no data returned, ran out of connections when I reached 10 requests - same Hikari error. Evidence suggests that connections not being returned to the pool, am I missing some new pool config parameters ?
jdbc:Client dbClient = new({
url: dbUrl, username: username, password: password,
poolOptions: { maximumPoolSize: poolsize }
});
Steps to reproduce:
This function fails to return any data, does not return an error, it essentially returns nothing.
function selectAddressRecord(int id)  returns  @tainted  json {
table|error addrtn = dbClient->select("select * from address ", addressRecord);
if (addrtn is table) {
io:println("Returning  data: ");
}else {
io:println("Not Returning  data rtn was not a table ");
}
}
The log output shows "Returning data:" - but nothing is returned.
Seems to be pool related: I have 5 connections configured in the pool and after 5 requests have been made to select from the table I receive the following error:
error {ballerinax/java.jdbc}DatabaseError sqlState= message=failed to execute select query: error while getting the connection for ClientConnector. HikariPool-1 - Connection is not available, request timed out after 30013ms.. sqlErrorCode=0
Not Returning  data rtn was not a table
Select failed: failed to execute select query: error while getting the connection for ClientConnector. HikariPool-1 - Connection is not available, request timed out after 30013ms..
2019-11-12 17:59:51,187 INFO  [address] - failed to execute select query: error while getting the connection for ClientConnector. HikariPool-1 - Connection is not available, request timed out after 30013ms
I ran the POST operation and inserted records 20 times in a row.
Affected Versions:
Ballerina 1.0.3
java -version
openjdk version "1.8.0_222"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode)
OS, DB, other environment details and versions:
Mac OS 10.15
Postgres DB running in docker
postgresql-<IP_ADDRESS>.jar driver
Suggested Labels (optional):
Hikari Pool,. ballerinax/java.jdbc,  HikariPool-1, select query

In ballerina, the tables returned from the database will have a physical DB connection associated with that.  That connection will get released only after the table data is fully used or table is closed.
In ballerina, the tables returned from the database will get closed automatically only if you have consumed the data.  That means either you have to

iterate the table fully using foreach or while loop
convert to json or xml and consume that payload in client-side

If none of the above is doing (i.e. if you are partially iterating the table or not using the table at all) , you have to close it explicitly using the close function as follows.
tableValue.close() ;

By looking at your code it seems following code is doing the data select from db.
function selectaddressRecord(int id)  returns  @tainted  json{
string querystr = "SELECT  id, street1, street2, unitnumber, city, state, postal, country  FROM address  WHERE id = ?";
          json rtnStr = {};
        io:println(querystr.toString());
        table<addressRecord>|error rtn = dbClient->select("select * from address ;", addressRecord);
        io:println(rtn.toString());

        if (rtn is table<addressRecord>) {
           rtnStr = rtn.toString();
                    io:println(rtn);
            io:println("Returning  data: ");
            io:println(rtnStr);
         }else {
             io:println("Not Returning  data rtn was not a table ");
         }

        if(rtn is jdbc:ApplicationError || rtn is jdbc:DatabaseError){
            error err = rtn;
            io:println("Insert failed: ", <string> err.detail()["message"]);
          rtnStr = <string> err.detail()["message"];
           }
     return rtnStr;
}

It seems your json conversion is incorrect in this case. That’s why the table is not fully consumed and the associated db connection remains as it has not closed in any of the above-mentioned ways.
So can you please change the code within the if block as follows by importing ballerina/jsonutils; and check.
if (rtn is table<addressRecord>) {
    rtnStr = jsonutils:fromTable(rtn);
}
``

Thank you for the quick response, of course this solved my issue, I do like the type conversion when inside a test block patter, just taking a little practice to get good with it. Once again the ballerina team responding quickly and professionally - your team is great.
Working perfectly now.


Re-add test coverage for the following:

menu_launcher:

[x] 387-403 (test type == INFO)
[x] 543-551 (test title == Show Installed Plugins and title == Update Plugins)
[ ] 558-561 (test title == Containers)

tests currently have too many containers which can't be removed from circleci, closing for now.


[ABW-2504] Fix crash when opening account settings

added IconButton with throttle click capability until we update Compose/Navigation

@jakub-rdx is this still a thing after updating the compose dependencies?

No, it seem to work fine on the compose branch. Probably will close that one after library updates will get merged

@giannis-rdx unfortunately we will need this fix for the time being, until compose get updated


wip: new: falcoctl driver loader

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR drops old falco-driver-loader script in favor of new falcoctl driver command.
Which issue(s) this PR fixes:
Fixes #2675
Special notes for your reviewer:
This is wip because falcoctl's PR (https://github.com/falcosecurity/falcoctl/pull/343) is still to be merged and this will need some more work.
I opened this one to give an idea of the final look.
Does this PR introduce a user-facing change?:

new!: dropped falco-driver-loader script in favor of new falcoctl driver command

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Note: once https://github.com/falcosecurity/falco/pull/2413 gets merged, this should be at least ready for local testing with the CI produced packages.

build-packages is failing with:
CMake Error at /__w/falco/falco/build/cmake_install.cmake:294 (file):
  file INSTALL cannot find
  "/__w/falco/falco/build/falcoctl-prefix/src/falcoctl/falcoctl": No such
  file or directory.

that is because our falcoctl.cmake file expects falcoctl releases (and is not able to build falcoctl from sources since it would add the huge dep on go), but is now pointing to a falcoctl commit hash zip file.
I would love to fix the CI to be able to test; perhaps we will need to tag a falcoctl alpha release once https://github.com/falcosecurity/falcoctl/pull/343 is merged.

TODO: once https://github.com/falcosecurity/falco/pull/2413 is merged, update deb/rpm scripts using new chosen_driver names (ie: "kmod", "ebpf" and "modern-ebpf").

also, are per-driver systemd units still needed? Btw they should enforce a driver.kind, like -o driver.kind=kmod
-> we might want to deprecate current units and add a new<EMAIL_ADDRESS>templated unit that enables the requested driver.

Done.
About the single unit (deprecating existing ones), i haven't got strong opinions.

We just need an alpha tag of falcoctl 0.7.0 to be tested within this PR.

https://github.com/falcosecurity/testing/pull/34 + https://github.com/falcosecurity/testing/pull/33 should allow test-dev-packages checks to pass fine.

The only failing test left is

TestFalcoLegacyBPF

that will be fixed by https://github.com/falcosecurity/testing/pull/34

Bumped falcosecurity-testing to latest dev to (hopefully) fixup dev test-packages ci.

Also need https://github.com/falcosecurity/falcoctl/pull/369 because compiled eBPF probe is expected to be symlinked to /root/.falco/falco-bpf.o : https://github.com/falcosecurity/falco/blob/master/scripts/falco-driver-loader#L662 and https://github.com/falcosecurity/falco/blob/master/falco.yaml#L321

Tests are finally passing! 🚀

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add index wrapper

Description
Add index wrapper  o avoid manual memory management and re-creationf space object on all queries, and simplify error handling logic a bit
Note that I think that it also makes sense to declare a "throws IOException" in KnnIndex.java but haven't gotten around to it, posting this now to hopefully unblock you guys a bit

New PR branched off of new master here: https://github.com/opendistro-for-elasticsearch/k-NN/pull/39


chore: update bootc extension to 1.6.0

chore: update bootc extension to 1.6.0
Updates bootc extension to 1.6.0
Signed-off-by: Charlie Drage<EMAIL_ADDRESS>

DO NOT MERGE UNTIL QE APPROVAL

yes it'll still be ok

@benoitf Approved by QE from Slack, merging!


feat: Support explicitly defined validators at argument level

descriptor.Field<ExampleResolvers>(r => r.Example(default!))
  .Type<ExampleType>()
  .Argument<ExampleInput, ExampleInputValidator>("input", arg => arg.Type<ExampleInputType>());

Out of interest, do you really need the manual control when FairyBread will just find that validator automatically for you?
As long as you define your validator as public class ExampleInputValidator : AbstractValidator<ExampleInput>, right now it'll find it execute it.
The exception being though that query field arg validation is off by default. But you can adjust that. I'm planning on having a [Validate] and .Validate() descriptor that'll allow you to not turn on query field arg validation globally, but opt-in as/when needed.

It is useful when input class shared across multiple mutations/has multiple input types or input is omitted and generic types(ID. String, etc.) is used:

send(input: EmailTemplateType!, ...) and render(input: EmailTemplateType!)
ExampleInput -> ExampleInputType : InputObjectType<ExampleInput> + ExtendedExampleType  : InputObjectType<ExampleInput>
search(query: String!) { ... } and comment(message: String!) { ... }

Hey @sergeyshaykhullin, I've added a new .UseValidation() extension off IArgumentDescriptor, so you can now do:
.Argument<ExampleInput>("input", argDef => argDef....UseValidation());

This was mostly to allow people to opt-in to argument validation on query fields as needed, but it actually would be a stepping stone to this.
Would you be happy if the api for this looked like so?
.Argument<ExampleInput>("input", argDef => argDef....UseValidation<TValidator>());

I probably won't have time to get to this for a little while longer, but I agree it's useful if you are sharing types and need that extra control of what to validate. I'm just not quite sure how I'd get it to work yet. I guess I'd need to add meta here on the argument to basically say "Don't go looking for AbstractValidator<T> but instead go looking for TValidator that was explicitly asked for". Shouldn't be too bad!

I've renamed the ticket, as we should also cover argument-level in pure code first, e.g.
public string SomeFieldResolver(..., [Validate(typeof(TValidator))] ExampleInput input) => { };

I tested new extensions
.UseValidation<TValidator>() is ok, but we are loosing generic validator model type checks:
descriptor.Field<ExampleResolvers>(r => r.Example(default!))
  .Type<ExampleType>()
  .Argument<ExampleInput>(
    "input",
    arg => arg.Type<ExampleInputType>())
      // Here
      .UseValidation<NotAnExampleInputValidator>();

Maybe it can be UseValidation<TArgument, TValidator> where TValidator : AbstractValidator<TArgument> or as my approach - .Argument<TArgument, TValidator> overload which covers HC .Argument<TArgument> with validator constraint

I'am ok with any implementation

@AradAral Do you mean you need argument level overrides? You can check the docs here

Ahh... It is a wrong repo...
FairyBread now has nothing to separate primitive inputs and specify concrete validator for each argument/field
I can suggest you to use input pattern for each operation
mutation {
  createExample(exampleInt: 10) { ... }
}

Migrate to
mutation {
  createExample(input: { exampleInt: 10 }) { ... }
}

Then you can setup validator for input type and validate nested exampleInt

Thanks @sergeyshaykhullin for answering this one :P
The input pattern is the way to go in most cases, but I do see a gap in Query fields where arguments are typically specified top-level without a wrapping input object type.
I think I'm going to re-open this and tackle it soon.


Reimplement some functions in a more concise way

For your consideration...
I saw a few opportunities to write things a bit more concisely, and without using andThen which is more powerful a function than necessary for these cases. I structured the commits so that you should be able to easily cherry-pick what you like and leave what you don't like. I'm also happy to make modifications based on feedback.
I recognize that the point-free style that I used for hardcoded and custom is perhaps a bit extreme and not to everyone's taste. They could be rewritten in various ways such as making the arguments explicit, and/or using local definitions like map2 = object2 or andMap = object2 (<|). Of course you may still like the original andThen versions better. I think that the implementation I've provided for resolveResult is a more clear improvement with less potential for controversy :)
If you don't want to merge any of these rewritten functions, I would suggest that the tests I added for resolveResult are probably still a good addition. The Err test assumes the latest customDecode error message format, as in #11.
Cheers,
James

These look good to me! Thanks @jamesmacaulay!


RFC: $state.go('^') should go to the next - non abstract - Parent-State

$state.go('^') should not go to the parent Element, without checking, if this state is an abstract state (Currently, it tries to transition to the state and throws an error, when the target state is abstract).
go() should check, if the parent state is abstract. When it is, it should go to the parent of the parent and check, if this state is abstract.
This should be done until the first non-abstract state is found.
Here is some Code, to show what i mean:
function goToNonAbstractParentState() {
    var states = $state.current.name.split('.');
    for (var i = states.length - 1; i > 0; i--) {
        var stateName = '';
        for (var j = 0; j < i; j++) {
            stateName += states[j] + (((j + 1) < i) ? '.' : '');
        }
        if (!$state.get(stateName).abstract) {
            $state.go(stateName);
            break;
        }
    }
}

We've been discussing having default children (or what-have-you) for abstract states. Potentially one solution would be that you could pass a callback function which would be executed when you land on an abstract state to decide where to bounce you to. This seems like it would be covered by such a feature, and the behavior you described I don't think is ubiquitous enough to make the standard behavior.

What reason is for going to abstract state if this  throw error? I think like @jannickfahlbusch it should go to first non abstract parent in tree.

https://gist.github.com/christopherthielen/b3fc0304b737a4bf8ec9

So, any hopes of us seeing these default states of abstract parent states in the near future?
Also, I am really disappointed that you do not allow us to retrieve information about that registered states.
E.g., I want a generic piece of code to know if a state is abstract or not without me repeating that information somewhere. But I cannot even retrieve a list of the available states out of the router, let alone check their type and other properties...
Anyways...

redirectTo
StateRegistry.get

Oh...!
Thanks.
I didn't know about that!
I am using an older version than that, but maybe I can upgrade sometime. :)


Make a "built with grpc" badge

Because who wouldn't want to display that on their project page

Templates / designs: https://github.com/pixel-cookers/built-with-badges

Accepted, but I do not think this is P0!

Closing this issue - not important.


CollectDumpOnTestSessionHang doesn't save dump file to TestResults directory when Azure DevOps pipeline job was canceled due to the timeout

Description

For a defect reproducable from the vstest command line, describe the issue you've observed.

We NuGet.Client team are working on running tests in blame mode to collect dumps when tests hang on the CI pipeline.
Linux tests job on the CI pipeline is configured to timeout after 45 mins. We publish build artifacts such as dump,sequence.xml and test results.xml from TestResultsDirectory for trouble shooting purposes only if job status is either failed or canceled for troubleshooting.
Tests are executed in parallel. one of the PR builds yesterday, blame detector identified a hang, collected the dump, and test framework started executing other test assemblies. In the mean-time Azure DevOps pipeline cancelled this job due to 45 min timeout. Unfortunately, only sequence.xml was uploaded to build artifacts but not dump file. As per below log dump of the hang was collected but not sure why the dump was not saved to TestResultsDirectory. Hence it was not published to the artifacts (see image below).
[Long Running Test] 'NuGet.Commands.Test.FallbackFolderRestoreTests.FallbackFolderRestore_AllPackagesFoundInFallback_NuspecModeAsync', Elapsed: 00:14:02
[Long Running Test] 'NuGet.Commands.Test.RuntimeTargetsTests.RestoreTargets_RestoreWithRuntimesAsync', Elapsed: 00:14:03
[Long Running Test] 'NuGet.Commands.Test.NETCoreProject2ProjectTests.NETCoreProject2Project_VerifyCompileForTransitiveSettings(expected: "BDXY", ab: True, bc: False, cd: True, ax: True, xy: True, yd: True)', Elapsed: 00:14:02
  Blame: Creating hang dump of process dotnet (5225).
  The active test run was aborted. Reason: Test host process crashed
  Data collector 'Blame' message: The specified inactivity time of 15 minute/s has elapsed. Collecting a dump and killing the test host process.

Here is the .runsettings file set to 15 mins test timeout to collect hang dump.
<RunSettings>
    <LoggerRunSettings>
        <Loggers>
            <Logger friendlyName="blame" enabled="True" />
        </Loggers>
    </LoggerRunSettings>
    <DataCollectionRunSettings>
        <DataCollectors>
            <DataCollector friendlyName="blame" enabled="True">
                <Configuration>
                    <CollectDumpOnTestSessionHang TestTimeout="15min" HangDumpType="full" />
                    <ResultsDirectory>%AGENT_TEMPDIRECTORY%</ResultsDirectory>
                </Configuration>
            </DataCollector>
        </DataCollectors>
    </DataCollectionRunSettings>
</RunSettings>

Expected behavior
Dump that was collected due to test hang saved to the TestResults Directory so that next steps in the pipeline could have published it to artifacts for troubleshooting.
Actual behavior
CollectDumpOnTestSessionHang doesn't save dump file to TestResults directory when Azure DevOps pipeline job was canceled due to the timeout
Environment

Tests are executed using .NET 5 Preview 7 SDK
As per this PR description, no additional tools are to collect hang dumps on Windows and Linux. Hence added only DataCollector > CollectDumpOnTestSessionHang in .runsettings file.
xUnit.net VSTest Adapter v2.4.1 for running tests

I appreciate any work around or additional guidance on this issue. Thanks.

I am unable to reproduce it locally on Windows. Here are the steps I followed.

Execute dotnet test "a.dll" "b.dll" --settings "path to .runsettings file"

<RunSettings>
    <DataCollectionRunSettings>
        <DataCollectors>
            <DataCollector friendlyName="blame" enabled="True">
                <Configuration>
                    <CollectDumpOnTestSessionHang TestTimeout="1min" HangDumpType="full" />
                    <ResultsDirectory>%AGENT_TEMPDIRECTORY%</ResultsDirectory>
                </Configuration>
            </DataCollector>
        </DataCollectors>
    </DataCollectionRunSettings>
</RunSettings>

dotnet test started executing tests 'a.dll` in parallel. The process encountered a test which ran more than 1 min. A dump was collected.

The active test run was aborted. Reason: Test host process crashed
Data collector 'Blame' message: The specified inactivity time of 60 seconds has elapsed. Collecting hang dumps from testhost and its child processes.
Data collector 'Blame' message: Dumping 13360 - dotnet.

I pressed Ctrl + c to exit the test execution immediately. Hence dotnet test stopped executing after dump was collected and did not get a chance to run tests in b.dll
I found hang dump and sequence file in the local test results folder.

I am not sure why the dump was not saved to the TestsResultsDirectory on CI on Linux machine when the job timed out after 45 mins.

The ResultsDirectory option under DataCollector  > Configuration does not work, and never worked in this way. It specified a folder that was used as temporary location to store the dumps, before they were picked up by the attachments subsystem and moved to the "TestResults" folder where you have your xml reports, trx etc.
The folder specified in ResultsDirectory had to exist, but always ended up empty. With the new changes in Blame, the normal %TEMP% is used instead.
If you are interesting in saving the dumps into a specific location and not uploading them as attachments of the run then you can set VSTEST_DUMP_PATH to a directory that will be used to store the dump files.
I also might be misreading your issue, is it happening only in some cases, when you cancel the build? There should be a lot of info in the diagnostic logs, https://github.com/microsoft/vstest-docs/blob/master/docs/diagnose.md could you provide them if the stuff above does not solve your issue?

I found ResultsDirectory option in this doc. I thought it make sense to configure ResultsDirectory option to AGENT_TEMPDIRECTORY because the folder is cleaned after each pipeline job even if attachments subsystem fails to pick the dump files in the worst case.
If ResultsDirectory option under DataCollector > Configuration does not work, then we will consider removing it.

It specified a folder that was used as temporary location to store the dumps, before they were picked up by the attachments subsystem

We want these dump files in the Test Results directory. We have a downstream job that publishes these dump files from Test Results directory to artifacts for trouble shooting.
Do we know at what point attachments subsystem picks up dump files?

I also might be misreading your issue, is it happening only in some cases, when you cancel the build?
Yes, that is correct. The CI log shows that dotnet test blame hang collected a dump after set timeout of 15 min. However, that job did not complete as it was cancelled by CI after job timeout. The downstream job failed to publish collected dumps because they were not present in Test Results directory.

I found ResultsDirectory option in this doc. I thought it make sense to configure ResultsDirectory option to AGENT_TEMPDIRECTORY because the folder is cleaned after each pipeline job even if attachments subsystem fails to pick the dump files in the worst case.

I thought that is done automatically, by setting the TEMP for the agent, at least it seemed to work that way when I tried it, but now I don't see it happen.

If ResultsDirectory option under DataCollector > Configuration does not work, then we will consider removing it.

Yeah that slipped during review.

We want these dump files in the Test Results directory. We have a downstream job that publishes these dump files from Test Results directory to artifacts for trouble shooting.

You can do that using the variable mentioned above.

Yes, that is correct. Do we know at what point attachments subsystem picks up dump files and places them under TestResults directory? If this happens after all the test assemblies were executed, then it explains why dump files were not present in the expected location because the pipeline job was cancelled after timeout

I thought it handles cancelling correctly. But might re-visit it and fix it. If it does not happen it would be a bug.

I thought it handles cancelling correctly. But might re-visit it and fix it. If it does not happen it would be a bug.

I even tried to mimic cancellation by manually cancelling the CI build after the dump was collected when a test timed out. I didn't see dump file published to TestResults directory. It looks like a bug to me unless I am missing something.

We want these dump files in the Test Results directory. We have a downstream job that publishes these dump files from Test Results directory to artifacts for trouble shooting.

You can do that using the variable mentioned above.

If VSTEST_DUMP_PATH  setting causes dotnet test to create dumps directly in this folder instead of creating in %TEMP% and moving them later to desired location, then we can consider this option.

A work-around for this issue to increase the CI job timeout so that that dotnet test is not interrupted by a cancellation request and has sufficient time to publish dumps to Test Results directory even if there is a hang.

#2641 Added the fix to pickup the agent temp folder here. This fix will get also into 16.9

Thanks for the update. Looking at the PR, I think <ResultsDirectory>%AGENT_TEMPDIRECTORY%</ResultsDirectory> setting in .runsettings file is not required because temporary directory is chosen from environment variables with a fall back option on current user's temporary folder.

I thought it handles cancelling correctly. But might re-visit it and fix it. If it does not happen it would be a bug.

Is there any update on the issue discussed above to ensure that collected dump will always be moved from TEMP directory to TEST RESULTS directory even after azure pipeline sends a cancellation request?

@nohwnd What's the status of this issue? Is there anything else to do on our side?

I've setup two dlls both waiting for significant time, and setup hang dump. Then I tried cancelling the execution request after the first dll was dumped, and also killing the process tree after the first dll was dumped. In both cases I've got the resulting dump in the test results folder.
So to me this looks like it is working.


remove slow decorator

Description
this PR removes pytest-timeout from our test dependencies.  I think it's caused more trouble than it's worth... even the readme states:

This is not the timeout you are looking for!
Warning
Please read this README carefully and only use this plugin if you understand the consequences.

Given how many threading-sensitive things we have going on here, i think adding this one should be a last resort, most likely used locally for debugging, but not as a routine component of our CI.

ok, added back the original ones


HHH-15778 Fetching an Entity with a lazily loaded Embeddable with more fields than the parent results in an ArrayIndexOutOfBoundsException

https://hibernate.atlassian.net/browse/HHH-15778
I made an attempt at fixing the bug, but I don't know enough about Hibernate internals to be sure about these changes.

Thaks @GeorgEchterling your fix LGTM, i have rebased it on main and created https://github.com/hibernate/hibernate-orm/pull/5809, if it passes all the test I'm going to merge it.


Space.wizard.to.select.space

WIP waiting for https://github.com/almighty/almighty-core/pull/1148 to be merged fix

There were the following issues with your Pull Request

Commit: f4a35eafc7464be18fbbb1827f2ff447782ef16d
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: f4a35eafc7464be18fbbb1827f2ff447782ef16d
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 71a7f162ccab604696c3ee72c69a4c30414aa301
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com

[test]

@joshuawilson unit test is failing because we need the ngx-fabric8-wit from this PR https://github.com/fabric8-ui/ngx-fabric8-wit/pull/101
I've tested it locally with "npm link"

[test]

This PR CI build is failing with this error also it needs conflicts resolving.
Error in bail mode: [at-loader] ./src/app/app.module.ts:125:3
    TS2305: Module '"/home/jenkins/workspace/auto_fabric8-ui_PR-1424-Y6PRCEK6XSAHBW4ES26AAZZCZ5S7OEN62KSJ4YFYBGCRDGLBJ2NA@2/node_modules/ngx-fabric8-wit/index"' has no exported member 'SpaceTemplateService'.

I think the work was done in #2664, closing. Reopen if this is still need.


[Bug]: DNS-Setting invalid

Is there an existing issue for this?

[X] I have searched the existing issues

Description
when i try to set the FQDN i think i have a problem with letsencrypt, the DNS is pointing to the server but i only get a selfsigned cert when i turn off the DNS check in the settings.

the request causes a 500 error

are there any special DNS settings that need to be done? in my case for a subdomain?
is there a way to have logs to see what happens with the LE cert?
Steps To Reproduce
freshly installed coolify on hetzner cloud.
when i have installed the 3.10.15 version and set up the FQDN and save with DNS-Check and SSL-Cert on.
used
wget -q https://get.coollabs.io/coolify/install.sh -O install.sh; sudo bash ./install.sh
Version
3.10.15

Did you added the A record pointing to this IP in your provider (CloudFlare/goDaddy/Namecheap) ?

@vasani-arpit yes, it's setup normaly. like i've setup all the other Domains in the DNS with the DNS A-Record pointing to the coolify Server.
btw. i've setup a service with a subdomain, with this service the LE Cert is working but not with the mail Coolify FQDN, but i need this to get it connected to my gitlab server.

I don't have a much experience with custom Certs. @andrasbacsai Can you take a look?

@vasani-arpit yes, it's setup normaly. like i've setup all the other Domains in the DNS with the DNS A-Record pointing to the coolify Server.
btw. i've setup a service with a subdomain, with this service the LE Cert is working but not with the mail Coolify FQDN, but i need this to get it connected to my gitlab server.

I have the same issue here. We are trying to use coolify as a deployment plattform for experimental software at our faculty and the DNS gets properly resolved to our machine's IP. I also added our University's DNS server to the custom DNS servers list, but whenever I try to set then FQDN I also only get the error "DNS settings for <out_domain> is invalid, click to recheck.". Is there new info on what might be the issue?

any solution for this problem? i'd like to use coolify but i'm not able to get the Domain with LE Cert.

I'm trying to reproduce it, but on a newly installed server + a new top-level domain, it works.
To check the logs of LE, you can check coolify-proxy container with docker logs -n 100 -f coolify-proxy command and see what's going on.

@andrasbacsai i've executed the command on the coolify host and got the following result
time="2022-10-27T15:13:15Z" level=error msg="Unable to obtain ACME certificate for domains \"coolify.xxxxxxx.de,www.coolify.xxxxxxx.de\": unable to generate a
certificate for the domains [coolify.xxxxxxx.de www.coolify.xxxxxxx.de]: error: one or more domains had a problem:\n[www.coolify.xxxxxxx.de] acme: error: 400
:: urn:ietf:params:acme:error:dns :: DNS problem: NXDOMAIN looking up A for www.coolify.xxxxxxx.de - check that a DNS record exists for this domain; DNS problem: NXDOMAIN looking up AAAA for www.coolify.xxxxxxx.de - check that a DNS record exists for this domain\n" rule="(Host(`coolify.xxxxxxx.de`) || Host(`www.coolify.xxxxxxx.de`)) && PathPrefix(`/`)" providerName=letsencrypt.acme ACME CA="https://acme-v02.api.letsencrypt.org/directory" routerName=coolify-secure@http
time="2022-10-27T15:13:17Z" level=error msg="Provider connection error cannot fetch configuration data: Get \"http://coolify:3000/webhooks/traefik/main.json\": dial tcp: lookup coolify on <IP_ADDRESS>:53: no such host, retrying in 634.469623ms" providerName=http
time="2022-10-27T15:13:23Z" level=error msg="Provider connection error cannot fetch configuration data: Get \"http://coolify:3000/webhooks/traefik/main.json\": dial tcp <IP_ADDRESS>:3000: connect: connection refused, retrying in 1.034253849s" providerName=http
time="2022-10-27T15:13:29Z" level=error msg="Provider connection error cannot fetch configuration data: Get \"http://coolify:3000/webhooks/traefik/main.json\": dial tcp <IP_ADDRESS>:3000: connect: connection refused, retrying in 809.323285ms" providerName=http
time="2022-11-02T21:31:38Z" level=error msg="Error while Peeking first byte: read tcp <IP_ADDRESS>:80-><IP_ADDRESS>:1425: read: connection timed out"

It looks like the www.coolify.xxxxxx.de is not set in DNS. Could you please double check?

@andrasbacsai ok, i've added the www. to the DNS,
now i don't get an Error when adding the Domain but when i try to open the domain via https://coolify.xxxx.de:3000 i get an Error in the Browser SSL_ERROR_RX_RECORD_TOO_LONG

any solution for this problem? i'd like to use coolify but i'm not able to get the Domain with LE Cert.

I'm having a similar issue with a fresh install

I had the exact same issue, and I suspect that this isn't a bug with coolify at all.
My suspected reason for these errors is, that the Let's Encrypt server has a "slow" DNS server. If you create a new record, it might work instantly for you because you are using a good DNS server locally. But the Let's Encrypt API seems to use a DNS server with heavy caching and therefore doesn't pickup the new A records instantly.
I would recommend to everyone to wait a couple of hours until the A records have fully propagated to all DNS Servers before, adding the domain to coolify.


Chart labels, annotations, and priority class config

Kyma project currently uses fork of BTP Operator helm chart with few custom changes. We would like to upstream all configuration knobs and eventually deprecate the https://github.com/kyma-incubator/sap-btp-service-operator.
This is a first PR containing mainly just configurability for deployment annotations and priority class.
Previous PR https://github.com/SAP/sap-btp-service-operator/pull/201 has been closed without any review or comment and I am unable to reopen it.

ptal @kerenlahav @pavelmaliy


index file in server+signin route (backend)

Is your feature request related to a problem? Please describe.

currently, there is no index.js file in the server directory
no route for signing in

Describe the solution you'd like

create an index.js file in the server directory
move the config folder and bring it inside the root directory
create a post req for sign in

Describe alternatives you've considered
creation of an index.js file in the server directory, changing the location of the config folder and bring it inside the root directory, create a post req for signin

@mitalirs Assigned :)
Extremely sorry for the late response. You can add whatever backend as well as stuff left. Will get back to in few hours with update from my side.

@yash982000 already done this.


Default concurrency value

Affects Version(s): 2.2
🎁 Enhancement ->  default concurrency:
Isn't better if the default concurrency value were an calculated parameter? Example:
If I have 1 topic with 8 partitions and two containers, concurrency automatically will be set to 4 per container.
I think that is "more correct/adherent"  in the actual usage of springboot and kafka (microservices).
Thanks !

We can't do that - we don't know how many instances of your application you might run.
We can't assume there is only one instance.
We would end up with idle consumer threads.
It's not clear what you mean by "two containers" in this context; each @KafkaListener gets its own concurrent container; the framework doesn't look to see if you have 2 listeners in the same group listening to the same topic(s). I really don't see why you would do that anyway.

Sorry, may be I'm not cleary..
When I said "two containers" I mean two instances. Imagine a springboot microservice running in an Kubernetes cluster, scale up and scale down many times of day. Now, imagine that:
-> I have two instances (2 kubernetes pods) that consumes topic with 8 partitions;
-> If I set concurrency = 8 and I'll normally stay with 2 instances untill normally days;
-> In normal days, I'm aways will be 4 iddle kafka threads.
But you're right, how can KafkaListener know about active instances to that topic? :(

It's generally best to over-provision the partitions; and adjust the concurrency to make good use of the resources on each instance (CPU, memory, I/O).
If you start with two instances, concurrency 4 and only 8 partitions, you can't scale out any more without adding partitions.
If you provision, say, 32 partitions; you can scale out to 8 instances without making any changes.
Initially, each instance (of 2) will get 16 partitions and end up with 4 when you have 8 instances.


Where do call-to-action links go?

@AlisonCSmith : Where do the call-to-action links go? ie,

License Footage from WGBH Programs
Search WGBH Interviews and more from WGBH Archives “Open Vault”

I think the first will go to one of the About pages, and the second to the OV Collection page, but I'm not sure.

OV is handled, only "License Footage from WGBH Programs" remains TBD.

both are done.


"enable_segmentation" is always true on transit

In 6.8 dev controller, I created transit network with default segmentation setting, but noticed all transits have segmentation enabled. I explicitly disabled it with "transit_enable_segmentation = false", but terraform will ignore it. Let me know if you need further information of the setup. Thanks.

Try:
transit_segmentation = false
I think I may have documented this incorrectly. (name of argument as well as default value)

Bingo! That works. Much appreciated.

Great, I will leave this issue open until I address the documentation.

Addressed in docs


Audio object type 42 is not implemented

Describe the bug
It seems a codec missing (USAC) or something...
To Reproduce
Steps to reproduce the behavior:
ffmpeg -i test.mkv
Expected behavior
Show info without error.
Desktop (please complete the following information):

Windows 11 24H2

Additional context
ffmpeg version git-2024-10-27-f4c2b49a05-VVCEasy Copyright (c) 2000-2024 the FFmpeg developers
[aac @ 000002087e265b00] Audio object type 42 is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it means that your file has a feature which has not been implemented.
[matroska,webm @ 000002087e25e180] Failed to open codec in avformat_find_stream_info
[aac @ 000002087e265b00] Audio object type 42 is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it means that your file has a feature which has not been implemented.
[matroska,webm @ 000002087e25e180] Could not find codec parameters for stream 1 (Audio: aac, 48000 Hz, 0 channels, fltp): unspecified number of channels
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
Input #0, matroska,webm, from 'test.mkv':
Metadata:
title           : [S01.E01] Força, Irmão! - Episódio 1
EPISODE_ID      : 1/1
DESCRIPTION     : Após sofrer um ataque de pânico que comprometeu a sua equipa, Oskar vê-se forçado a recomeçar do zero.
ENCODER         : Lavf58.20.100
Duration: 01:02:51.24, start: 0.000000, bitrate: 819 kb/s
Stream #0:0: Video: h264 (Main), yuv420p(tv, bt709, progressive), 608x342 [SAR 1:1 DAR 16:9], 25 fps, 25 tbr, 1k tbn (default)
Metadata:
DURATION        : 01:02:51.240000000
Stream #0:1(spa): Audio: aac, 48000 Hz, 0 channels, fltp (default)
Metadata:
DURATION        : 01:02:51.243000000
Stream #0:2: Video: mjpeg (Baseline), yuvj420p(pc, bt470bg/unknown/unknown), 350x197, 90k tbr, 90k tbn (attached pic)
Metadata:
filename        : cover.jpg
mimetype        : image/jpeg
At least one output file must be specified
Note: I can provide mkv file if needed just ask since i cant upload here.

Hi, @extream87. Please note you need to force it using argument audio codec before input file.
Only works for FFmpeg, which FFplay can't force audio codec after deprecated option is removed.
ffmpeg_vvceasy -c:a libfdk_aac -i test.mkv

I might have to figure out if libfdk_aac is compiled with my custom build to appoint USAC audio, I disabled native xHE-AAC decoder due some missing features.
You can try playback using my custom build MPV.
Feel free to reply me

@MartinEesmaa worked great :D
Thanks


SortDescriptors on transient(readonly) properties?

Goals
Sort my results by a transient/ignored/readonly property using a RLMSortDescriptor
Expected Results
My results to be sorted by that property.
Actual Results
*** Terminating app due to uncaught exception 'Invalid sort property', reason: 'Cannot sort on property 'lastUpdated' on object of type RLMChat': property not found.'

Code Sample
I was using this with RBQFetchedResultsController, not sure if it's related.
    RLMRealm *realm               = [RLMRealm defaultRealm];
    RBQFetchRequest *fetchRequest = [RBQFetchRequest fetchRequestWithEntityName:NSStringFromClass([RLMChat class])
                                                                        inRealm:realm
                                                                      predicate:nil];
    fetchRequest.sortDescriptors = @[
        [RLMSortDescriptor sortDescriptorWithProperty:NSStringFromSelector(@selector(lastUpdated))
                                            ascending:NO]
    ];

    self.fetchedResultsController = [[RBQFetchedResultsController alloc] initWithFetchRequest:fetchRequest
                                                                           sectionNameKeyPath:nil
                                                                                cacheName:kChatInboxCacheName];

    self.frcDelegate                       =
        [[CYChatInboxFetchedResultsControllerDelegator alloc] initWithTableView:self.chatInboxTableView];
    self.fetchedResultsController.delegate = self.frcDelegate;
    [self.fetchedResultsController performFetch];

Version of Realm and Tooling
Realm version: 0.98.6
Xcode version: 7.3
iOS/OSX version: 8.4.1
Dependency manager + version: CocoaPods 0.39.0

I think this is not supported yet. See related issue #1265

I guess they are related, I thought ignored properties could be sorted without using comparison blocks

You can use Realm sort only with properties that stored in database. Else you can do it manually (iterate RLMResults and save order you want in NSArray), but this will not work good if you have large dataset (and I do not think that RBQFetchedResultsController will allow you to do this)

I can confirm what @Kirow stated here before. You will need to pull all relevant objects into an NSArray and can sort this by Foundation's APIs instead.


TOC show html tag like raw text on website but localhost does not

🐛 Bug Report
When I write this on docs markdown
## Referencing Site Documents

It always shows Referencing Site Documents in h2 tag in the main text.
But it has some problem with TOC(table of Content) on a real website.
On the preview (run on http://localhost:3000 or http://<IP_ADDRESS>:3000), it just shows Referencing Site Documents Table of Content.
but when it runs on a real website, the Table of Content just show  like raw text:
Referencing Site Documents

Have you read the Contributing Guidelines on issues?
Yes
To Reproduce
(Write your steps here:)

write ### Referencing Site Documents
build and run on the website
see the category

macOS Chrome and Safari both have this problem.
Expected behavior

just show Referencing Site Documents

and not show  part when on real website.
Actual Behavior

Referencing Site Documents

Reproducible Demo
(Paste the link to an example repo, including a siteConfig.js, and exact instructions to reproduce the issue.)

fork demo
I didn't have a real website domain to show this. But you can just see the fork demo what I changed.
I think it maybe some js works differently when it on reviews?

Sorry but using your fork demo, Any docs change is reflected on next version of docs if you have versioned docs enabled.
http://localhost:3000/docs/en/next/navigation

http://localhost:3000/docs/en/navigation

I didn't create multiple version.
And My issue is when docusaurus runs on localhost, it didn't show  but when on the real website show .
I think maybe when http://localhost:3000/docs/en/navigation run on the real website. It will also show .
I feel weird that preview is not the same as it shows on real website ……
And could I make TOC show subtitle as it shows on the preview, hiding the HTML tag?

Its most likely i18n caching issue on dev.
Delete any i18n/**! files
Its hard for us to debug if you didn't have a real website domain to show this. But using the fork demo you mentioned, everything seems to be working fine

It seems to delete all files in i18n doesn't help.
But I create a totally new docusaurus project, it actually reflects as next version shows on dev.
But it still weird the TOC doesn't show the text as same as it looks like on the h2 tag.

I found how to make TOC content the same as HTML tag.
just change this code
from
<Link hashLink={heading.hashLink} content={heading.content} />
to
<Link hashLink={heading.hashLink} content={heading.rawContent} />
It will be nice and intuitive that Docusaurus show TOC content as it shows on HMTL H2, H3 tags.


Latent Space Projection and Interpolation Code

Hi.
Thanks for releasing the code for your interesting paper.
I looked into the repo, but couldn't find the latent space projection and interpolation code for Figure 10 results.
Can you please provide the code?
Thanks.

def slerp_theta(z1, z2, theta):     return math.cos(theta) * z1 + math.sin(theta) * z2

def slerp_theta(z1, z2, theta): return math.cos(theta) * z1 + math.sin(theta) * z2
Hi, this code simply defines the interpolation of the latent space. How did you continue sampling to obtain the final image, and were z1 and z2 obtained from the real image though q_sample? Would you like to have further communication, or could you please release the complete code snippet? Thank you!


Documentation is misleading (does not match release)

Very annoying: the documentation states that config files should go into raspberrypi-ua-netinst/config, but the installer loads (or tries to load) the installer-config.txt/post-install.txt from /bootfs (aka root of sd-card as in previous versions). This has cost me a few hours of work to figure that out.
The best way to work around this issue: keep the master in sync with the latest release and use a git branch for new developments. Or at least document which part of the documentation is valid for existing releases.
Thanks, Bernhard

Thanks for the advice!
I will implement the proposal right after the version 1.5 is released today or tomorrow.


assert response.status in [http.client.NO_CONTENT, http.client.OK] AssertionError

I am pretty sure I did all steps right
still i am getting this error
Traceback (most recent call last):
File "alexa.py", line 8, in
client.connect()  # authenticate and other handshaking steps
File "C:\Users\Harshit.dell-PC\AppData\Local\Programs\Python\Python36\lib\site-packages\alexa_client\alexa_client\client.py", line 33, in connect
self.synchronise_device_state()
File "C:\Users\Harshit.dell-PC\AppData\Local\Programs\Python\Python36\lib\site-packages\alexa_client\alexa_client\client.py", line 49, in synchronise_device_state
device_state=self.device_manager.get_device_state(),
File "C:\Users\Harshit.dell-PC\AppData\Local\Programs\Python\Python36\lib\site-packages\alexa_client\alexa_client\connection.py", line 74, in synchronise_device_state
assert response.status in [http.client.NO_CONTENT, http.client.OK]
AssertionError

Hi guys,
I have the exact same problem.
It used to work fine a few weeks ago, and now it doesn't. I suspect something has changed at Alexa.
Any solution?
Thanks!
Fred

Same Issue i m getting with AlexaClient, pretty sure about the whole procedure
Sometimes i even get the run time error but due to the access_token used in place of refresh_token

I also get the same error. It semms like the library is broken.

Same problem!
The response is 405: METHOD_NOT_ALLOWED
However, I haven't found any change in Alexa Voice Service https://developer.amazon.com/docs/alexa-voice-service/system.html#synchronizestate .
Any solution right now?
Thanks!
Fix it! I add 'http.client.METHOD_NOT_ALLOWED', it works.

I think this does not fix the problem at all.
I think it is because the library tries to GET the syncronizestate, whereas it should POST it. Just exchange GET with POST and it works.

Same problem!
The response is 405: METHOD_NOT_ALLOWED
However, I haven't found any change in Alexa Voice Service https://developer.amazon.com/docs/alexa-voice-service/system.html#synchronizestate .
Any solution right now?
Thanks!
Fix it! I add 'http.client.METHOD_NOT_ALLOWED', it works.

I think this does not fix the problem at all.
I think it is because the library tries to GET the syncronizestate, whereas it should POST it. Just exchange GET with POST and it works.

I see. Thank you!

This has now been fixed
Please install alexa_client==1.4.1


test: [M3-6428] - Migrate from Jest to Vitest

Description 📝
Replaces Jest with Vitest and attempts to get all of our tests passing. See also PR #8951 -- a lot of the test changes in this PR stem from that.
Trouble tests and other things to call attention to:

Made a change to confirmObjectStorage() in ObjectStorage/utilities.ts to convert the function to async/await syntax, but have not tested the change in Cloud

I think this is only called when enabling Object Storage by creating an access key

RescueDialog.test.tsx, SearchLanding.test.tsx, CreateAPITokenDrawer.test.tsx are each failing intermittently, but seem to pass when run by themselves
We get a lot of failures when running single threaded

I've kept pretty good documentation on each of the significant changes made to the tests, and plan to follow up with a self review that describes each significant change.
Changes  🔄
(WIP...)
Preview 📷
(WIP...)
How to test 🧪
yarn test
As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

Commit message and pull request title format standards

Note: Remove this section before opening the pull request
Make sure your PR title and commit message on squash and merge are as shown below

<commit type>: [JIRA-ticket-number] - <description>
Commit Types:

feat: New feature for the user (not a part of the code, or ci, ...).
fix: Bugfix for the user (not a fix to build something, ...).
change: Modifying an existing visual UI instance. Such as a component or a feature.
refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.
test: New tests or changes to existing tests. Does not change the production code.
upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.

Example: feat: [M3-1234] - Allow user to view their login history

I know this is marked as a work in progress but I'm leaving my approval now.
I think this change is the right direction for us and has an overwhelming number of advantages over our jest setup

Thanks, @bnussman-akamai! Another advantage I discovered earlier today is memory usage is dramatically improved with Vitest.
Try running yarn test --logHeapUsage on develop and you'll see the memory usage slowly creep up for each test until it's well over a gig. Running the same command on the Vitest branch shows each test hovering around ~50-150MB (minus a few exceptions) with no apparent upward creep.

Coming over from frontend cafe 😆 -- will take a look tomorrow! 👀


sphinx-argparse: WARNING: Failed to import "func" from "module.submodule"

Details

Read the Docs project URL: https://readthedocs.org/projects/nanite/
Build URL: https://readthedocs.org/projects/nanite/builds/8043996/
Read the Docs username: paulmueller

Expected Result
sphinx-argparse correctly documents my CLI.
Actual Result
I get errors like
/home/docs/checkouts/readthedocs.org/user_builds/nanite/checkouts/latest/docs/sec_cli.rst:19: WARNING: Failed to import "fit_parser" from "nanite.cli.rating"

without any explanation why the import failed.
This might be related to one of these things:

I am using Python 3.6 on readthedocs
#3032
sphinx-argparse itself

In any case, a more detailed error message would be helpful.

Did you try this locally? It works? Maybe you need to install using pip? (I think I saw something similar in another issue)

Yes, locally it works (using pip with --no-site-packages) on Ubuntu 17.10. Not sure what you meant by "installing using pip", but doing this:
https://github.com/AFM-analysis/nanite/commit/3ac1eb9dda8aeb8cebbeabe441a3df0f1b965f0a
does not help:
https://readthedocs.org/projects/nanite/builds/8045730/

It turns out that I had to mock tkinter and the matplotlib backend in conf.py:
for mod in ["tkinter",
            "matplotlib.backends.backend_tkagg"]:
    sys.modules[mod] = mock.Mock()

For some reason, sphinxarg.ext is not very verbose when it comes to failed imports...
I tracked down the error by writing my own argparse extension (https://github.com/AFM-analysis/nanite/commit/7a00bdd8bb0371be89a74fc3862f4690d37491a3) which then gave me detailed error messages on rtd:

https://readthedocs.org/projects/nanite/builds/8092723/
https://readthedocs.org/projects/nanite/builds/8092689/

@paulmueller thanks for posting the solution!


update placement concept

Signed-off-by: Zhiwei Yin<EMAIL_ADDRESS>

/assign @haoqing0110

@haoqing0110 the Prioritizers part is not easy to understand, so I think more examples/scenarios could help user learn how to configure Prioritizers in placement.

@zhiweiyin318 yes, thanks for the suggestion, the prioritizers have complex explanation now and not easy to understand. Let me log an issue to polish that part.

/lgtm
/approved


Duplicate attribute: class in edge and IE

Vue.js version
2.0.2
Reproduction Link
http://codepen.io/anon/pen/WGyrdz
Steps to reproduce
Just load up the page in edge or internet explorer (11) with your console open. Vue will display the warning "duplicate attribute: class".
When removing the class attribute, the warning goes away.
What is Expected?
No warnings :). I expect vue to use both the regular class attribute and the :class attribute and merge them together into the class attribute.

Actually it's IE that messed up outerHTML by duplicating the attribute :(
I've just disabled this warning for IE.

Thanks!

I'm not able to repro this. In the simplified test case :class shows up in the attributes list in IE11 and Edge 14.

As @jdalton said, this is still an issue in Edge 14.

@Kcharle Could you open a new issue with a repro, please?  I'm not sure to understand. Does this mean we can remove the check?

I‘m meeting this too