settings:Change dropdown option label & position,label of input field.

Changes made

Changed label of "Up to N minutes after posting" option in "Allow message editing" dropdown menu to "Custom".
Upon selection of "Custom" option, now the input field opens below dropdown, with label "Duration editing is allowed after posting (minutes)".

GIF

Fixes #20177

@archithadge thanks for working on this!  A few requests:

Can you squash your commits and write a proper commit message?  Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
Can you add a second commit executing this change in the other similar widget?  https://github.com/zulip/zulip/pull/19944#issuecomment-962271205

@archithadge thanks for working on this! A few requests:

Can you squash your commits and write a proper commit message?  Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
Can you add a second commit executing this change in the other similar widget?  Add a UI option for entering a custom notification batching period #19944 (comment)

Sure, working on it.

@archithadge thanks for working on this! A few requests:

Can you squash your commits and write a proper commit message?  Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
Can you add a second commit executing this change in the other similar widget?  Add a UI option for entering a custom notification batching period #19944 (comment)

Sure, working on it.

Changes made

Changed label of "N minutes" option in "Delay before sending message notification emails" dropdown menu to "Custom".
Upon selection of "Custom" option, now the input field opens below dropdown, with label "Delay period (minutes)".

GIF

@timabbott since in this PR, I have made 2 commits adressing 2 different issues, what could be appropriate prefix for this PR, instead of organization permissions, should I use settings as prefix.

Yes, settings would be appropriate.  You can use git log to see what's normal.

@timabbott can this PR be merged, or any more changes required?

@archithadge it looks like you didn't apply my feedback on the commit message in the last comment.  Also, you seem to have created a merge commit, which you ~never want to do; git pull --rebase should remove those for you.
Check out our GitHub guide and commit guidelines for more details on Git workflow -- generally our git clone instructions pass the option to configure Git to never make merge commits.

@archithadge it looks like you didn't apply my feedback on the commit message in the last comment. Also, you seem to have created a merge commit, which you ~never want to do; git pull --rebase should remove those for you.
Check out our GitHub guide and commit guidelines for more details on Git workflow -- generally our git clone instructions pass the option to configure Git to never make merge commits.

Yes Tim, I'll fix that merge commit, also I intentionally kept 2 commits, since both changes belong to different areas in settings, I'll merge them into one.

@timabbott,I've made changes in commit messages.

@timabbott  can you review this PR once?

Merged, after several changes:

Squashed the commits, since conceptually this is a single change being made to a few similar elements.
Fixed the "Delete time limit" not having been updated.
Used the dependent-block CSS class, which we use elsewhere, rather than manual
 and   style spacing, which don't work well.
Moved the HTML elements outside of the containing input-group.
Wrote a commit message focused on the why of the change, instead of things that are easily determined when looking at the diff.

Thanks for working on this @archithadge!  Hopefully you can learn from my comments for your next PR :)
Actually, a great next PR is that we missed a couple more instances of this pattern:
$ git grep dependent-inline-block
static/styles/settings.css:.dependent-inline-block {
static/templates/settings/organization_settings_admin.hbs:

static/templates/stream_settings/stream_types.hbs:

Can you do a PR in the style of what I merged migrating them as well? Thanks!  We can also delete the dependent-inline-block CSS definition once we've done this migration.

Merged, after several changes:

Squashed the commits, since conceptually this is a single change being made to a few similar elements.
Fixed the "Delete time limit" not having been updated.
Used the dependent-block CSS class, which we use elsewhere, rather than manual
 and   style spacing, which don't work well.
Moved the HTML elements outside of the containing input-group.
Wrote a commit message focused on the why of the change, instead of things that are easily determined when looking at the diff.

Thanks for working on this @archithadge! Hopefully you can learn from my comments for your next PR :)
Actually, a great next PR is that we missed a couple more instances of this pattern:
$ git grep dependent-inline-block
static/styles/settings.css:.dependent-inline-block {
static/templates/settings/organization_settings_admin.hbs:

static/templates/stream_settings/stream_types.hbs:

Can you do a PR in the style of what I merged migrating them as well? Thanks! We can also delete the dependent-inline-block CSS definition once we've done this migration.

Yeah Tim, will take care of these things in upcoming PRs. Thank you.!


vspreview/main.py: fix sys.argv[0] passed to the vpy

We used to pass outside sys.argv[1], which might be '-a', as sys.argv[0] for
the vpy. Instead, we pass the base name of the script_path as sys.argv[0]. As
we chdir to the parent of the script, this represents the correct path of the
vpy.
Signed-off-by: akarin<EMAIL_ADDRESS>

Thank you.


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-sql-instancepool
Module Details
AVM Resource Module for SQL Instance Pools
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hey, I would like to be this module's owner.

I am happy to be the owner of this @PmeshramPM

Hi @yashints ,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

@PmeshramPM do we have a repo for the Bicep version? Would I be the owner of that too?

@PmeshramPM do we have a repo for the Bicep version? Would I be the owner of that too?

Thanks @yashints, This Issue only captures the Terraform development. If you are looking to develop a Bicep equivalent, please raise another issue with Bicep naming conventions.

@PmeshramPM seems like there is no terraform provider for the instance pool, what's the approach for this situation?

@yashints - We have checked internally and you could use AzAPI provider - https://learn.microsoft.com/en-us/azure/templates/microsoft.sql/instancepools?pivots=deployment-language-terraform

@PmeshramPM I've raised a PR, however, there seems to be an issue with the script which checks the linting for terraform which is also discussed on the AVM terraform teams channel

@PmeshramPM this is blocked as I cannot proceed without the core team letting me know how to fix the e2e tests when a resource takes more than an hour to get created and also destroying the resources won't happen immediately

e AVM terraform Teams channel

@yashints - I am following up on this one and will confirm

this is still blocked...

This is still in blocked state, waiting for the AVM team to come back with what's next

@yashints lets sync offline to see how we can unblock this.

@yashints, as the @Azure/avm-core-team-technical-terraform team stated in our internal discussions:
After consideration we have decided that this resource is not suitable for use as a terraform module due to the deletion issues.
We therefore have decided this is blocked until either:

the RP rectifies the soft deletion issue
the resource is implemented in AzureRM where the delete can be tracked and polled

I'm marking this issue as long term and will disassociate it from the current owner.


Update MD file on new branch 2017-12-14_07-41-35

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


waymo convert about CALIB file in kitti format！

the parameters in camera.intrinsic [0:4] is the projection parameters toward to the waymo camera coordinate, and the tr_velo_to_cam(after transform) contains the transform from waymo camera coor to kitti's (T_front_cam_to_ref),but the projection parameter didnt,you just saved the 4 parameter without any transformation, i wonder if its a issue or some transformation i dont understand?

Could you please describe this issue more clearly with some references to specific codes?

I wonder in save_calib() in tools/dataset_converters/waymo_converter.py, why T_vehicle_to_cam is renamed as Tr_velo_to_cam? I think the vehicle frame and the LiDAR frame are not the same thing in Waymo. T_vehicle_to_cam is derived from camera.extrinsic, which is indeed the transformation from vehicle frame to camera frame. But how can it be renamed and used as the transformation from LiDAR to camera? Do I misunderstand anything?

I wonder in save_calib() in tools/dataset_converters/waymo_converter.py, why T_vehicle_to_cam is renamed as Tr_velo_to_cam? I think the vehicle frame and the LiDAR frame are not the same thing in Waymo. T_vehicle_to_cam is derived from camera.extrinsic, which is indeed the transformation from vehicle frame to camera frame. But how can it be renamed and used as the transformation from LiDAR to camera? Do I misunderstand anything?

point_in_cam = point_in_velo@Tr_velo_to_cam, i think the "cam" in Tr_velo_to_cam is just a virtual coordinate in kitti, it is just a bridge, as long as i can get the right point in camera coordinate, and it can be project to the ref image,it works.
no 1 to 1 definition in this process, just pay attention to the results of transformation.


Copy phase is acquiring a lock on my original table I don't know why

It's mostly happening for update queries. I don't know why. I thought it will release the lock. But the curve kept going up. I had to manually intervene and stop the process. It instantly came down to normal as soon as I stopped this.

BTW, it might also be helpful to see the queries section of Performance insights from the same time period you posted the screenshot. Again, remember to blur any sensitive info if you post that.

Yeah, the output of the above query will def be useful.
Thinking out loud - I wonder if its a by product of using TRANSACTION ISOLATION LEVEL SERIALIZABLE until we add the triggers (during initial copy), this can be prohibitive on large DBs 🤔
https://github.com/shayonj/pg-osc/blob/9cbe45e0bbb4a5e0ba17a000c71a7c01ea07f68b/lib/pg_online_schema_change/orchestrate.rb#L163

@shayonj , I also think that it's the byproduct of TRANSACTION ISOLATION LEVEL SERIALIZABLE. Because the transaction carries from setup_shadow_table to copy_data functions. What if we don't do copy_data in the same transaction?
@jfrost  Also here are the screenshots of queries section of performance insights. Largely the updates query on the original tables are stuck. Here INSERT INTO is happening to the shadow table, and update is happening on the original table.

@shayonj I am not finding locks per say with the query @jfrost shared but this is the behavior while trying to replicate the same on local. You can see how queries goes from taking < 10ms to like 400ms and more.
clip of what's happening while trying to replicate it on local: https://imgur.com/M5h5ZPm

If the query I sent over returned zero results while the issue is happening and you can see the lock waits in Performance Insights, then it's possible you are running the query as a user which doesn't have the appropriate permissions. You can do a simple SELECT * FROM pg_stat_activity; to see if you user can see queries or not.

Yeah, thats interesting. If you have any reproducible script or similar, that could be super useful. I also see that in the video, the latency spikes for a handful of queries but most are <100ms (?).
I will take a deeper look and get back. I have been meaning to refactor parts of this code and introduce concept of two connections to setup copy and trigger, like pg_repack, which I think would allow us to also drop the SET TRANSACTION ISOLATION LEVEL SERIALIZABLE. In the meantime, any more info like @jfrost mentioned or reproducible script would be super useful. Thanks!!

@shayonj as of now we have only been able to replicate the locking behaviour on our Amazon's RDS instances (it doesn't happen on local environment). And also copying data in batches instead of a single query solves. So I don't think serialised transaction is the issue.

@yash-toddleapp Any chance you are running those UPDATE queries on your RDS instance with serializable isolation or something other than read committed?

@shayonj @jfrost Nah  I don't think so. I found something more weird. The table only locks while INSERT INTO #{shadow_table}(#{insert_into_columns.join(", ")})           SELECT #{select_columns.join(", ")}           FROM ONLY #{client.table_name}
when ran from the pg-osc.
What I did was make the list of all the queries that were being executed with the help of --verbose flag. And ran them using psql. And it does not lock the table. So there's something in the tool itself I don't know what that is causing the lock.

Interesting! I will look a bit more deeply in the next few days and get back

So, i am unable to replicate this in our smoke spec env and not seeing any consistent locking the on the parent table. I am curious

How did you pin it down to the issue being at INSERT INTO #{shadow_table}(#{insert_into_columns.join(", ")}) SELECT #{select_columns.join(", ")}
Also, what version of PG you are on?
Lastly, do you have any custom setting set on your RDS instances?

Thanks

*also how big the table is roughly how many writes/updates it gets. Thanks!

@shayonj  Apparently the issue is the audit table is getting locked because of the ALTER TABLE #{audit_table} SET (autovacuum_enabled = false, toast.autovacuum_enabled = false); query run in transaction which commits after data is copied.
So it gets stuck on the trigger that wants to acquire row level lock but can't acquire on audit table to insert the log of insert/update. And yes this behavior is only on RDS, we still haven't figured out why.
Running the disable vacuum query before the serializable transaction starts fixes the issue. I have this fork https://github.dev/yash-toddleapp/pg-osc which has this fix with some other fixes as well. I'll make a PR once I get time.
We have tables as big as 50-100 million rows

That’s a good find! And makes sense. Since serializable transaction shouldn’t be causing issues. I will get in my refactor after your patch. Let me know if I can help with the patch or anything. Thanks!
curious why it’s only happening on RDS. Will try to look into it later, but I can see how the alter can cause an access exclusive lock and a lock queue.

I proposed a simplified change here: https://github.com/shayonj/pg-osc/pull/97
Feel free to add to it, also if you are able to test/verify, then that'd be great too. Thanks!

v.0.9.2 is now out with the fix: https://github.com/shayonj/pg-osc/releases/tag/v0.9.2

Closing this, thanks for the report and brainstorming! please feel free to open reports or suggest PRs too. Thanks again!


Parallel parsing of Turtle

Added heuristic parallel parsing of the Turtle format based on finding splits of the NTriples file on every period.
Still missing comments and tests, will fix after feedback on API changes.

Thank you! May you resolve the merge conflicts :pray:

Thank you! Sadly it needs a rebase before merging :(

Thank you! Sadly it needs a rebase before merging :(

Made into a single commit as agreed:
git checkout 00c95cb4a2db7a0ef88c2273185e073eeeac41b5 -- lib/oxttl/
also added rayon and fixed rayon core version for test.


Like searchFor hints, add configurable regex to allow PASSTHROUGH to console.

For example the last line from a script may say something like
spilnu-dev environment: { name: spilnu.dk-dev, url: https://gamesearch-lejo.lupinsdev.dk }
I suggest having a config along the lines of:
stdoutPassthrough:
  - regex: "spilnu-dev environment: { name: spilnu\.dk-dev, url: (https:\/\/gamesearch-[a-z]{4}\.lupinsdev\.dk?) }"
    hint: "Gamesearch service has started sucessfully, go visit it on {1}"

From which, if the regex matches any stdout output from that action, it should print
  INFO  Gamesearch service has started sucessfully, go visit it on https://gamesearch-lejo.lupinsdev.dk

I think this config should sit on the action itself OR global.

In fact, this may just be adding searchFor as optional property on actions, and making the hints able to have templates.


Swift 3.0

Would love to see this working with Swift 3/Xcode 8! Happen to have a rough idea of if/when that might happen?

I think we summed up our Swift 3 migration strategy in #84!

Reopening this issue as the GM was released yesterday! 🎉
One thing I would like to support, moving forward, is still maintaining a version with Swift 2.3 support, theoretically v1.2.0. Then, we should be able to migrate to Swift 3 and name the version v2.0.0.
I think libraries like thoughtbot/Argo do an awesome job of this using a "Version Compatibility" table to show all of this off.
What do y'all think, @soffes, @hyperspacemark, @chrismanderson?

Additionally, the swift-23 branch needs no changes to run on Xcode 8 GM with Swift 2.3.

@eliperkins I have full Swift 3 support in my fork. Happy to PR.
If it were solely up to me, I'd skip 2.3 and just do 3.0 with a minor (or major?) version bump.

Yeah, I don't mind going right to Swift 3.0 moving forward, but it'd be nice to point to a tag for Swift 2.3 people (us included 😬 ) in the meantime. I think the intention of the major bump was due to  binary incompatibility if you were consuming it with Carthage and resolving to ~> 1.0. By bumping right to v2.0.0 with Swift 3, we can kinda get around it.
I don't feel too passionately about what version numbers we pick in the end, but I'd like to tag a version specifically for Swift 2.3.

I'm in favor of a major version bump for Swift 3 because we're not where ready to upgrade and still selfishly need a tag for Swift 2.3

Swift 3 has landed on master! Version 2.0 bump incoming, next.


Transforms for small_city

Hi, thanks so much for providing this great dataset!
Would it be possible to provide the transforms.json for the entire small city as download along with the images? This would be super helpful to us.
Best,
Bernhard

We have released all the json files for small city. What do you means the transforms.json for the entire small city?

Thanks for the reply! Going through the huggingface data, i can find transforms for block_a and block_small of small city. But they only seem to contain a fraction of the shots in small city (the biggest, block_a has ~6000 images). It's possible I don't understand the structure well?

You are correct! Sorry, i confused myself with the directory structure. Thanks a lot!

Please note that the files in the "pose" folder represent the splits of our dataset, with coordinate units in hectometers. Each file is associated with a "transforms.json" file, which contains the original pose exported from Unreal Engine. The rotation matrices in these JSON files should be multiplied by 100 for normalization, and the position units are in meters.


Get the favicon working

(intermittent right now: just figure out the right way for it to work.)

closed by #338


Incorrect ROCm 5.5 install instructions

Following the ROCm 5.5 install instructions will result in installing ROCm 5.6.
For example:
sudo apt update
wget https://repo.radeon.com/amdgpu-install/5.6/ubuntu/focal/amdgpu-install_5.6.50600-1_all.deb
sudo apt install ./amdgpu-install_5.6.50600-1_all.deb

So it should be this?
sudo apt update
wget https://repo.radeon.com/amdgpu-install/5.5.1/ubuntu/focal/amdgpu-install_5.5.50501-1_all.deb
sudo apt install ./amdgpu-install_5.5.50501-1_all.deb

A lot of mistakes. RHEL and SUSE.

I incorrectly edited it on develop branch. It should be docs/5.5.1.

Thanks @Promesis!


Enable grabbing translations from an alternate location for server distro/serverful scenarios

Server distro
enables server distro to use the new baseUrl configuration of the nlsLoader so that if nlsBaseUrl is defined in a product.json, you can get translations for core strings similar to how insiders.vscode.dev works today.
https://user-images.githubusercontent.com/2644648/170383888-c6efc558-9ef8-4fa4-802b-592653990349.mp4
after this goes in I will update the product.json

I'll close this since I reviewed #150418 feel free to let me know if you would prefer I review the two separate PRs instead

With all that said, given this solution works and a similar solution is already in place in vscode.dev, I will merge this in and discuss with folks out of band.

:+1: for adding this as a build-time loader configuration for our CDN / web bits.

I'm not sure if it's truly free because CSP would need to be updated to reflect the nlsBasePath that has been added.

Why was this change necessary? Normally the loader uses <script> tags to load code (not fetch), so I would have thought that touching the CSP would not be necessary.

@alexdima coming back to your question... it looks like it is needed. I wonder how I can apply this at build time... if at all...

:+1: You're right! I got confused and mixed things up, you're right the CSP change is necessary to use vscode-unpkg.net as a script source!


No datapoints for queries with a window smaller than 105h with auto-downsampling selected

Thanos, Prometheus and Golang version used
thanos, version 0.3.2 (branch: master, revision: 8e53a42515c591bb5fb58fa38d795f146704034d)
  build user:       root@packages-build-f2e9be33-d451-4201-a013-97a6f0686e26-l995n
  build date:       20190430-09:03:56
  go version:       go1.10.1

This is a custom version, patched with https://github.com/improbable-eng/thanos/pull/1094
Prometheus 2.9.2

What happened
We've configured the compactor to keep raw data for 14 days and delete it afterwards, and the query component to auto-downsample data. For queries that span over a week the results look like the ones we expected when compared with another setup in which we have kept raw data. Now, when the query window is smaller than 105h we are not getting any results back, unless we specifically force it in the UI to use 5m downsampled.
What you expected to happen
That the data that does exist would be returned, even though it has a lower resolution.
How to reproduce it (as minimally and precisely as possible):

Duplicate a bucket.
Compact the new bucket with a configuration that removes raw data after 14 days and keeps the rest.
Have another environment use the new bucket.
Query both environments to see the difference.

Full logs to relevant components
The logs don't show anything odd, at least with the info level. I'm going to restart the store with debug and will add whatever is interesting here, if there's anything.

Anything else we need to know
Nothing I can think of right now.

Having read a few issues in this repo about downsampling, I think this is expected behavior and would like to ask for a confirmation. I'm opening this issue in case someone else is experiencing the same (now, or in the future!).
I wouldn't be surprised if the resolution is that I'm not understanding something correctly and/or doing something wrong though! :smile:

Thanks for report. I think similar issue was reported somewhere but would be nice to narrow it down.
I think it must be something wrong with logic that chooses which blocks to use (falling back to 5m and then to raw): https://github.com/improbable-eng/thanos/blob/3b6a73bebd200d81a386d3b7cc4a0b2d0ce66abc/pkg/store/bucket.go#L1000
Does it makes sense?
Marking us bug.

Also be aware of this: https://github.com/improbable-eng/thanos/pull/1104 which will help to debug this I guess

Fixes ahead:

https://github.com/improbable-eng/thanos/pull/1146/files/9c9491843a1a335d18c4ed33fee5291ef5cfcc28..cd3363cfca26a9db80aceeecad57182e60b8557a
https://github.com/improbable-eng/thanos/pull/1144

Should be fixed by https://github.com/improbable-eng/thanos/pull/1146


Number of Environments is limited to 30

Describe the bug
When you check the Environments list in the SETTINGS tab, you can only see at most 30 environments. This affects the validation of the file as it will highlight a valid environment when it is not in the first 30 environments.
To Reproduce

With a repository that has over 30 environments
Go to SETTINGS --> Environments

Expected behavior
It should show all the environments.
Screenshots

Extension Version
v0.26.2
Additional context
This should be fixed by the paginate method as used in this #110.

This should be fixed by the paginate method as used in this #110.

Unfortunately not.
https://github.com/github/vscode-github-actions/blob/02a4f12047a38409abce525e45650235499db371/src/treeViews/settings/environmentsNode.ts#L12-L16
octokit.rest.repos.getAllEnvironments() (provided by @octokit/plugin-rest-endpoint-methods npm package, v7.0.1) accepts an optional per_page parameter as well, see https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/v7.0.1/docs/repos/getAllEnvironments.md.
I'm afraid there are more places need max per_page: 100 and pagination.

This should be fixed by the paginate method as used in this #110.

Unfortunately not.
https://github.com/github/vscode-github-actions/blob/02a4f12047a38409abce525e45650235499db371/src/treeViews/settings/environmentsNode.ts#L12-L16
octokit.rest.repos.getAllEnvironments() (provided by @octokit/plugin-rest-endpoint-methods npm package, v7.0.1) accepts an optional per_page parameter as well, see https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/v7.0.1/docs/repos/getAllEnvironments.md.
I'm afraid there are more places need max per_page: 100 and pagination.

I don't fully understand why not 😓. Yes, it accepts the optional per_page. But surely, you can combine the paginate method and getAllEnvironments to really get all the environments, right? Just like how it was used with listJobsForWorkflowRun.
https://github.com/github/vscode-github-actions/blob/695cfb9a9100ac0273a656c0efb566c38069ceb5/src/store/workflowRun.ts#L82C1-L94

This should be fixed by the paginate method as used in this #110.

Unfortunately not.
[...]

I don't fully understand why not 😓.

I meant, unfortunately list of environments and perhaps some more lists that need an improvement on pagenating are not covered by #110.


Fix spelling mistakes in the docs

Fix a few misspells in the Discovery Settings, Shared Memory Transport, and Typical Use Cases sections.

Please, rebase this branch against master too


Partitioning representative periods

Description
So currently we assume that the input data for clustering is a table with the following header:
|   |  | p.u.
-- | --|--|--
profile_name | year |  timestep | value
or:
|  |   |  | p.u.
-- | --|--|--|--
profile_name | year | period | timestep | value
If period is not provided, the data first needs to be split into periods. Currently this is done using TulipaClustering.split_into_periods!(df; period_duration), splitting the datafrae into periods of equal length.
At the same time, TulipaEnergyModels supports splitting splitting the year into unequal periods via partition specification, see for example assets-timeframe-partitions.csv.
I think that TulipaClustering should also utilize the partitioning approach, e.g., instead of calling TulipaClustering.split_into_periods!(df; period_duration) we should be able to call TulipaClustering.partition!(df; partition_string) to split the base data into periods.
Example:
Your data frame df is:
|   |  | p.u.
-- | --|--|--
profile_name | year |  timestep | value
profile_1 | 2030 | 1 | 1
profile_1 | 2030 | 2 | 2
profile_1 | 2030 | 3 | 3
profile_1 | 2030 | 4 | 4
... | ... | ... | ...
profile_1 | 2030 | 8760 | 8760
I can call TulipaClustering.split_into_periods!(df; period_duration=24) which will change the data frame into periods of length 24 each (365 periods in total):
|   |  | | p.u.
-- | --|--|--|--
profile_name | year | period | timestep | value
profile_1 | 2030 | 1 | 1 | 1
profile_1 | 2030 | 1 | 2 | 2
profile_1 | 2030 | 1 |3 | 3
profile_1 | 2030 | 1 |4 | 4
... | ... | ... | ...
profile_1 | 2030 | 365 | 24 | 8760
Instead, we might want to partition the first week as a period of length 168, and then have 358 periods of length 24. I would be able to do this by calling TulipaClustering.partition!(df; partition_string="1x168+358x24"). The example above can be done with TulipaClustering.partition!(df; partition_string="365x24").
The questions regarding this:

Is this string-based partitioning useful and worth implementing?
Should it be implemented in TulipaClustering or elsewhere, since partitioning is used outside of clustering as well.

@abelsiqueira @datejada @g-moralesespana @gnawin
What do you guys think?

Another question is how do we cluster periods of different length, but this should be a separate issue I think


Requests to stream assets from S3 can result in an empty 200 response

I found it confusing that a request to serve an asset from S3 results in an empty 200 response if the AWS_S3_BUCKET_NAME environment variable isn't set. I think I'd prefer it to fail fast if I'm requesting a file from S3 when the app doesn't have enough information to be able to satisfy that request.

This has been addressed in #84.


chore: release 1.1.2

:robot: I have created a release beep boop
1.1.2 (2024-04-09)
Bug Fixes

snowflake: audiences stopped supporting views (#43) (3c5b7e5)

Miscellaneous

deps: bump github.com/aws/aws-sdk-go-v2/credentials from 1.16.2 to 1.17.10 (#37) (19f7873)
deps: bump github.com/aws/aws-sdk-go-v2/credentials from 1.17.10 to 1.17.11 (#42) (f84cb71)
deps: bump github.com/aws/aws-sdk-go-v2/service/redshiftdata from 1.25.2 to 1.25.4 (#36) (2fe4a4d)
deps: bump github.com/rudderlabs/rudder-go-kit from 0.23.3 to 0.24.0 (#40) (cc02180)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/rudderlabs/sqlconnect-go/releases/tag/v1.1.2 :sunflower:


x/tools/gopls: make a decision about the CLI

gopls has a command-line interface that exposes many useful pieces of server functionality (e.g. show analysis diagnostics, rename an identifier) in a form that can be easily invoked from a shell script or other program. Since we no longer support the older separate CLI tools (e.g. gorename), there is a case to be made that this is a first-class interface. However, it is currently nominally "experimental".
The task of this issue is to:
(a) figure out roughly how many people use the CLI tool in its current form. Telemetry should make this easy.
(b) decide whether to publish a stable, coherent, and well-documented set of command-line operations, and, if so,
(c) built it and document it.
Another possibility we should consider is whether to provide a pure LSP client (I am guessing such a thing exists) that knows nothing of gopls. This may be less work overall and may align better with standard client-side ways of doing things, though it's also possible that it's more verbose, or clunky, or just can't easily express all the things we would like it to do.

We already have a headless LSP client for our regression tests (and, indeed, another slightly less robust headless client for the current command line interface).
IMO it would be more generally useful to extract this as a general purpose command-line interface for LSP servers. If we maintain the current CLI and regression tests we are effectively maintaining a headless client anyway, so why not share it in a more useful way?

IMO it would be more generally useful to extract this as a general purpose command-line interface for LSP servers. If we maintain the current CLI and regression tests we are effectively maintaining a headless client anyway, so why not share it in a more useful way?

It would certainly be more useful, but I wonder who would actually use it, and how much additional burden it would impose to attempt to remain strictly server-agnostic or to deal with the quirks of more than one actual server.  It might also make it harder to use with gopls, and, by being in a separate executable, might introduce IPC or version skew issues that we can ignore in the current approach. I'm not opposed, but we should go into it with a clear understanding of the costs and benefits.

I imagine custom features of the CLI would also be useful Go specific editor modes wanting tight integration. Maybe custom behavior could be kept organized as LSP actions (or whatever they are called) which could be presented on the gopls CLI as "native" operations, but still accessible from generic LSP clients. If you tried to use one of these custom operations against a non-goals server, you would get a " action not supported" error.

For the record, I wanted to try out gopls but my IDE of choice (JetBrains GoLand) doesn't seem to implement it.  I'm trying it out from the CLI and would be happy to hear you made a decision in favor of keeping a CLI.


updating trigger request body

add properties attribute to request body.
This fix  18905 issue

Can't accept PR: https://github.com/Azure/azure-sdk-for-python/issues/18905#issuecomment-918339819


offset should be a number: https://jsfiddle.net/leopoldthecuber/cqd8yy9w/4/

offset should be a number: https://jsfiddle.net/leopoldthecuber/cqd8yy9w/4/
Originally posted by @Leopoldthecoder in https://github.com/ElemeFE/element/issues/10587#issuecomment-379435538

Offset still stop working when there is no place in requested palcement
https://jsfiddle.net/hqe0d28v/4/


Typo in the error message in Email OTP flow

Describe the issue:
[2023-11-16 12:06:35,661] [4031d821-033f-4868-8bef-d953a3a6cddd] ERROR {org.wso2.carbon.identity.application.authentication.framework.handler.step.impl.DefaultStepHandler} - Authentication failed exception! Invalid coded provided by user: xxxx
How to reproduce:
Setup Email OTP as first factor and try incorrect OTP
Expected behavior:
Improve error code Invalid **code** provided by user: xxxx
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

This is completed. Hence, closing the issue.


[github] add command to comment on an issue (or pr)

The current command-set provides a way to create, close, and reopen an issue. Also allowing commenting on the issues would be great!

This CR has been included via the linked PR. The current convention to invoke the command is this.
/nc comments (add|update|delete|get|list) [-c <comment_id>] [-i <issue_number|pr_number>] [-b <body>] [-r <repo>] [-h <host>]


python3Packages.adafruit-platformdetect: 3.0.0 -> 3.1.0

Motivation for this change
Update to latest upstream release 3.1.0
Change log: https://github.com/adafruit/Adafruit_Python_PlatformDetect/releases/tag/3.1.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112486 at 526740b6 run on aarch64-linux 1

3 packages built:

python37Packages.adafruit-platformdetect
python38Packages.adafruit-platformdetect
python39Packages.adafruit-platformdetect

Result of nixpkgs-review pr 112486 at 526740b6 run on x86_64-linux 1

3 packages built:

python37Packages.adafruit-platformdetect
python38Packages.adafruit-platformdetect
python39Packages.adafruit-platformdetect


Program not downloading anything

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[06/23/22 12:08:36] ERROR: unable to download video data: HTTP Error 403: Forbidden
[06/25/22 07:38:02] WARNING: Unable to download webpage: HTTP Error 429: Too Many Requests
[06/25/22 14:59:23] WARNING: Unable to download webpage: HTTP Error 429: Too Many Requests
[06/25/22 15:02:38] WARNING: Unable to download webpage: HTTP Error 429: Too Many Requests
[07/02/22 12:07:44] ERROR: unable to download video data: HTTP Error 403: Forbidden
[07/06/22 16:25:35] ERROR: unable to download video data: HTTP Error 403: Forbidden
[09/21/22 17:55:45] ERROR: unable to download video data: HTTP Error 403: Forbidden
[09/21/22 17:55:45] ERROR: unable to download video data: HTTP Error 403: Forbidden
[09/21/22 17:55:45] ERROR: unable to download video data: HTTP Error 403: Forbidden
[10/10/22 17:27:38] ERROR: unable to download video data: HTTP Error 403: Forbidden
[10/27/22 16:59:48] ERROR: unable to download video data: HTTP Error 403: Forbidden
[02/17/23 08:08:54] ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[02/17/23 08:10:30] ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[02/17/23 08:12:26] ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[02/17/23 08:15:30] ERROR: Incomplete YouTube ID lX44CAzJhU. URL https://www.youtube.com/watch?v=lX44CAzJhU looks truncated.
[02/17/23 08:16:11] ERROR: Incomplete YouTube ID mYRn7ACITo. URL https://www.youtube.com/watch?v=mYRn7ACITo looks truncated.
[02/17/23 08:20:42] ERROR: 'youtube-dl "https://www.youtube.com/watch?v=mYRn7ACI_To"' is not a valid URL. Set --default-search "ytsearch" (or run  youtube-dl "ytsearch:youtube-dl "https://www.youtube.com/watch?v=mYRn7ACI_To"" ) to search YouTube
[02/17/23 08:21:21] ERROR: '"https://www.youtube.com/watch?v=mYRn7ACI_To"' is not a valid URL. Set --default-search "ytsearch" (or run  youtube-dl "ytsearch:"https://www.youtube.com/watch?v=mYRn7ACI_To"" ) to search YouTube
[02/17/23 08:25:42] ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[02/17/23 08:26:09] ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

I'm trying to download this video: https://youtu.be/lX44CAz-JhU to use its music in a rhythm game, but it wouldn't work. I originally thought that the program couldn't download URLs with - and _, but when I tried a random video URL without those symbols, it also didn't work. I have also tried different videos of the same song, but those don't work either.

Your log shows a whole lot of errors but no verbose log that could help to diagnose them. Open a new issue, following the issue template fully, to report a specific error.
If your specific concern is this ERROR: Unable to extract uploader id, then you should have found the existing issue for this problem when you did this:

[x] I've searched the bugtracker for similar bug reports including closed ones


fixing variable name missmatch (identityName)

fixing identityName variable name mismatch. There was a typo - idenity instead of identity. Although further in the script a correct name "identity" was referenced.
Also fixing issue with the custom role name in the role assigment create. As the role name contains spaces, it must be enclosed in quotes.

@astaykov : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"


Behind Proxy?

I am getting a 407 error behind my corporate proxy when I use this library. Where do I pass in the proxy settings?

@SteveScott, Thank you for reaching out. May I kindly know in which section of the code did you encounter this issue? Your issue seems to be due to authentication. For example, if you are attempting to obtain the latest chromedriver version endpoint using the requests module, you may define your proxy details and pass them as arguments:
    proxy = {
        'https': 'https://your_username:your_password@your_proxy_server:your_proxy_port'
    }
    requests.get(LAST_KNOWN_GOOD_VERSIONS_URL, proxies=proxy)

Hopefully this suggestion may assist you.

I am calling WebdriverAutoUpdate(CHROMEDRIVER_PATH)
Digging into the code it appears to be using wget. WGet pulls proxy settings from the HTTP_PROXY and HTTPS_PROXY environment variables. So I am working with my IT team to add googlechromelabs.github.io to the allow list.

I have access. Just needed to allow it. You may close the ticket.


Git Bot

Feature request:
A clear and concise description of the feature.
Is your feature request related to a problem? Please describe. (optional):
Add GitHub action to auto label issues with gssoc21 label when contributor asks to work under gssoc21. As it takes time for the maintainer to add labels, I can add a script that can auto-label issues with the GSSOC21 label whenever contributors ask to work under that label.
Describe the solution you'd like:
I can add a script that can auto-label issues with the GSSOC21 label whenever contributors ask to work under that label.
Describe alternatives you've considered:
none
Additional context:
Please assign me this issue with a GSSOC tag and a level tag.

@aishux This issue is a duplicate of #137. So I'm closing this issue. You can take up that issue if the assigned person is unable to complete it.


Use protocol package

This PR adapts the Language Server to use the extracted php language server protocol package.
Change summary:

[x] Removed the Protocol namespace.
[x] Introduced a Factory namespace containing the static factory methods removed from the extracted packages.
[x] Moved the Protocol/Message class to the root namespace (it doesn't seem tobe part of the protocol).

Not too sure how well the Factory namespace fits into the architecture. As all the factories produce Protocol objects, might make more sense to put them in Protocol or Protocol\Factory.
TODO:

[ ] ...

I like the LanguageServer\ProtocolBridge namespace, I think that would be a good place to put all the factories.
The Message class should be in the protocol package because it is specced as part of the protocol: https://github.com/Microsoft/language-server-protocol/blob/gh-pages/specification.md#base-protocol

The Message class should be in the protocol package because it is specced as part of the protocol

It is, but it does not conform to the type according to the protocol (which only has a $jsonrpc property).
I thought it would be better to keep this an implementation detail and implement the version indicated in the spec in the protocol (even if it's not used here). Does that make sense?

I think you are misunderstanding the class - the LSP Message class represents an LSP message consisting of headers and a body as defined by the LSP spec, saved in $headers and $body. $body then is the JSON RPC Message object, which has the $jsonrpc property.

@felixfbecker what do you think re. Message? having another look it also seems to sit uncomfortably in the same namespace as f.e. MessageActionItem and MessageType - which have nothing to do with our Message here.
Thanks for your time by the way :)

Maybe have sub-namespaces Types and Transport?

So:
Types\
    ClientCapabilities
    CodeActionContext
    CodeLens
    CodeLensOptions
    ...
Transport\
   Message

Although putting Message in Transport and leaving the others where they are also makes sense to me.

Yes, looks good to me

@dantleech do you plan to bring this over the finish line?

@felixfbecker yeah, sorry have been working on other things, but it's still on my roadmap, hopefully this coming weekend.

hmm, looking at this again, the Message class really is quite coupled to AdvancedJsonRpc.
For example:
// ClientHandlerTest.php
$reader->write(new Message(new AdvancedJsonRpc\SuccessResponse($msg->body->id, 'pong')));

(it is above expected that the body property is an AdvancedRPC object)
I don't know if we want to create Request, Response, etc DTOs mirroring the data structures in AdvancedJsonRpc? I still would vote for leaving the Message here where it can be coupled to that library though.

I've updated to the latest version of the protocol PR, which includes the namespace-renaming BC break.

Published the protocol package. Should I release a 1.0.0?

Should I release a 1.0.0?

I've pushed an update to use the published package, if the builds pass then 1.0.0 sounds good to me.

Released v1.0.0

Updated

:tada: This PR is included in version 5.4.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Is the AWS route53:GetChange example overly-specific in resource limitation?

While setting up cert-manager for AWS Route 53, I noticed the policy includes route53:GetChange limited to resource arn:aws:route53:::change/*. The Route53 API documentation lists no such resource, giving only * instead.
This is confusing. As it happens, the resources that GetChange works on are all arn:aws:route53:::change/* (checked with the IAMs policy simulator), so the permission in the docs is currently-correct, but not a documented public API.
It looks like this permission was part of the original IAMs permission write-up in jetstack/cert-manager#359 but was either never checked against the AWS documentation, or the API on the AWS side has changed.
The actual change ID can never be explicitly specified in the permissions statement, in contrast to the * in arn:aws:route53:::hostedzone/*, as the change ID is returned by the ChangeResourceRecordSets call.
So the permission should probably be against Resource * and could then be merged into the same block as the route53:ListHostedZonesByName statement.
I also noticed that eksctl has picked up this same resource in their instance addon policy.

I'm not well versed in the AWS IAM API, so any assistance/suggestions would be greatly appreciated.
The current source code for that documentation page can be found here: https://github.com/cert-manager/website/blob/master/content/en/docs/configuration/acme/dns01/route53.md
/help
/area acme/dns01
/priority important-soon
/milestone Next
/kind documentation

Oops, I probably should have filed this issue over there. Since I filed it, I noticed https://github.com/cert-manager/website/pull/185, so might want to let that land first to not conflict over that file.
For the record, I set up my IAMS Policy as I described here, and it worked fine (which makes sense, since it's technically wider than currently documented).

/close
Feel free to re-open if this is still an issue


How to align subfigures without \newline despite different number of lines captions?

See internship report PRNU estimation with different number of images having Gaussian noise and Gaussian noised PRNU figure.
Brief outline of the enhancement
LaTeX2e generally cannot add new features without an extreme amount of care to accommodate backwards compatibility. Please do not be offended if your request is closed for being infeasible.
Minimal example showing the current behaviour
\RequirePackage{latexbug}       % <--should be always the first line (see CONTRIBUTING)!
\documentclass{article}

  % Any preamble code goes here

\begin{document}

  % Demonstration of issue here

\end{document}

Minimal example showing the desired new behaviour
\RequirePackage{latexbug}       % <--should be always the first line (see CONTRIBUTING)!
\documentclass{article}

  % Any preamble code goes here

\begin{document}

  % Demonstration of issue here

\end{document}

Can manually use \newlines.

\begin{subfigure}[t]{0.25\textwidth} instead of \begin{subfigure}[b]{0.25\textwidth} solves this issue, source: the Tex Stack Exchange answer 65391.
Note that just removing [b] does not seem to solve the issue.


Biomodels update

Very cool feature! Mostly good for me as well. I tried this on BIOMD0000000930 which has both the url in a comment at the top,

as well as with the model_entity_is format

Finding the url from the comment at the beginning of the file worked perfectly! However I noticed a couple things:

If the top comment is removed, the url fround from parsing the model_entity_is  section is the entire string following the keyword model_entity_is until the end of the file, which takes me to:

-I'm not sure if this was intentional, but Open Biomodels doesn't seem to account for modifications to the file until a page refresh. For instance, if I delete the top comment as well as the model_entity_is at the bottom, Open Biomodels still takes me to the URL that no longer exists in the document.


examples: captcha on every request to g2

summary
Seems like the examples are outdated... Every example with g2.com lead to a captcha:

code used
from botasaurus.browser import browser, Driver

@browser
def scrape_heading_task(driver: Driver, data):
    driver.google_get("https://www.g2.com/products/github/reviews.html?page=5&product_id=github", bypass_cloudflare=True)
    driver.prompt()
    heading = driver.get_text('.product-head__title [itemprop="name"]')
    return heading

scrape_heading_task()

versions
At the time of writing, I'm on latest revision of the library and Chrome on Debian Linux (Python 3.11).
addition information
IP is not blocked. "Normal" browsers (Firefox, LibreWolf, Chrome directly started) work.

Same issue for me


Add anchor offset for  anchor links

This fixes https://github.com/pandas-dev/pydata-sphinx-theme/issues/267

I think you might have a merge resolution leftover in your code :-)

though I think the fix does work!
https://pydata-sphinx-theme--280.org.readthedocs.build/en/280/demo/api.html#numpy.linalg.matrix_power

@hoetmaaiers thanks for looking into this!
Checking the demo docs, the link is now working correctly, but it seems to have some undesired side effects on the rest of the layout ..
This PR: https://pydata-sphinx-theme--280.org.readthedocs.build/en/280/demo/generated/pandas.DataFrame.drop.html#pandas.DataFrame.drop

Master: https://pydata-sphinx-theme.readthedocs.io/en/latest/demo/generated/pandas.DataFrame.drop.html#pandas.DataFrame.drop

It seems that the background-color: white; is the problem, but when removing that, the yellow box gets expanded ..

This is indeed a strong issue. I assume we want to keep the highlighted box since this adds some good user experience.
Would it be possible to extend the
 element output?
By wrapping the dt content in an extra div, I think the problem could be addressed:

    numpy.linalg.matrix_power(a, n)¶

This is indeed a strong issue. I assume we want to keep the highlighted box since this adds some good user experience.

Hmm, actually I am not sure it is that important. At least for doc sites like pandas, where each docstring gets its own page, I don't think it adds much value. But indeed, for pages with many docstrings under each other on a single page, highlighting the linked one can be useful.

Would it be possible to extend the  element output?

Unfortunately, I don't think this is that easy to modify the generated html (I would need to look into sphinx' autodoc extension and the directive it uses). We might be able to add a class if we override that similarly as we do for table: https://github.com/pandas-dev/pydata-sphinx-theme/blob/edc2a0bdee1411ac9f7d5950fcacb4720a7134e0/pydata_sphinx_theme/bootstrap_html_translator.py#L23, but would need to look into it to know.

After some more thinking (and after a good nights rest), I solved the problem by being more specific in the css selector for . The undesired side effects should be solved with this.

Cool, that's an easier solution, thanks!
One other question, but can be as a follow-up if needed: now we have two places in the scss code that defines very similar styling for a &::before element. Would it be possible to somehow combine those two? With a combined / generic selector (or maybe using :target, cfr https://stackoverflow.com/a/28824157/653364 / https://developer.mozilla.org/en-US/docs/Web/CSS/:target).
That might also solve anchors that are not atached to a specific header or definition list or table, see my comment about that on the issue: https://github.com/pandas-dev/pydata-sphinx-theme/issues/267#issuecomment-716851241

Cool, now I learned about :target. This could indeed be an even better and more generic solution!


Notes from infrastructure handoff meeting

@lgierth is going on vacation so I will be taking over as the primary person in charge of the ipfs infrastructure with @Kubuxu acting as a backup in the cases where I might be unavailable.
Here are the notes from the meeting we had:
IPFS Infrastructure Management
Setup

clone infra repo (https://github.com/ipfs/infrastructure)
install dependencies (comment at the top of ./provsn)

gnu parallel, bash, jq, git, etc.

need secrets

currently this process is manual
switch to secrets manager in future (hashicorp vault?)
put them in ./secrets

ansible

cd ansible && make deps

Deploying New Changes

provsn deploy [optional array of node names]

build and deploy current configuration to nodes
[ ] should report success (currently doesnt)
[ ] add verbose flag
troubleshooting:

set PROVSN_TRACE=1 (causes LOTS of noise)

[ ] fix ansible-playbook gateway.yml without secrets
[ ] XXX rekey cjdns
[ ] put listen fc00 back into place

provsn build

just does the build but doesnt push changes live

DMCA Blocking

open ansible/roles/ipfs_gateway/templates/nginx_ipfs_gateway.conf.j2
add rule for hash in question like:

    location ~ "^/ipfs/QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n" {
        return 451;
    }

source venv/bin/activate
ansible-playbook gateway.yml

Deploying dnslink websites

use meldium to get acccess to digitalOcean
change relevant TXT record dnslink value
example: TXT _dnslink dnslink=/ipfs/QmUskK3M9ANENsAb5YVC3Lc2TiUBcLqL8KpKUsRHKFGqKz
for foo.ipfs.io, TXT record is _dnslink.foo.ipfs.io
If its a new record, add CNAME to gateway.ipfs.io

ssh access to gateways

add new key in base/env.sh to all_ssh_keys array
provsn deploy

running a migration
NOTE: daemon will be offline during migration
direct access to container logs
1. grab container-id
root@earth:~# docker ps
CONTAINER ID        IMAGE                                            COMMAND                  CREATED             STATUS              PORTS                      NAMES
eae427ee13bf        mtail:a54f860fe8b14440320014ed608e438a790f19ac   "/usr/local/bin/mtail"   4 minutes ago       Up 4 minutes        <IP_ADDRESS>:3903->3903/tcp   mtail
c0846895f92c        ipfs:566c08e                                     "/usr/local/bin/start"   6 days ago          Up 3 hours                                     ipfs
619bc76884dc        nginx:1.10.1                                     "nginx -g 'daemon off"   7 weeks ago         Up 8 hours                                     nginx
2. grab log from /var/lib/docker/containers/$containerID/$containerID-json.log
root@earth:~# tail -f /var/lib/docker/containers/c0846895f92c3a39d6ced41329ff58e1b7e80e56d9254d4a392603fc759138ad/c0846895f92c3a39d6ced41329ff58e1b7e80e56d9254d4a392603fc759138ad-json.log
General Gateway IPFS Info

ipfs daemon is run in a docker container with the repo mounted from /ipfs/ipfs_master/repo
docker will automatically restart the ipfs daemon if it crashes or stops for any reason

Is this actionable? Could probably be closed, now that it is logged here. Or we could turn this into a README.


[Android] Fixed visual artifacts at startup in shared mode

Displaying dialog causes irregular visual artifacts in background if the
default window background is null. For this case, set the background to
screen_background_dark temporarily during the initialization of shared
mode.
BUG=XWALK-4155

@halton @fujunwei @axinging Please help to review

LGTM, i'm holding to merging until @rakuco is okay with the message/comment.

lgtm


Warn when pypi queries fail

Currently, pipreqs silently ignores pypi errors unless --debug is
supplied. In particular, when a name needs to be in the mapping file but
isn't, pipreqs will look for it on pypi, fail to find it, and skip it
without comment. requirements.txt still gets built, but is likely to be
wrong.
This PR makes it treat pypi errors as warning-worthy, and adds some
debugging lines around mapping lookups.

Coverage increased (+0.5%) to 72.266% when pulling 2971861bacb3f2212ed5e85eba4b526051eefb03 on andrew-vant:missingmappings into 15208540da03fdacf48fcb0a8b88b26da76b64f3 on bndr:master.

I was cleaning up some of my stale PRs and noticed this was still open with no commits to the repo for a year. Is pipreqs not maintained anymore? Has development moved elsewhere?


Add ranger documentation to dired README

I added a small ranger section to "/modules/emacs/dired/README.org". This section simply explains that if the +ranger flag for dired is set in init.el often a "deer-mode" or minimal ranger buffer will be opened, and that "Z p" can be used to toggle between this minimal mode and the full ranger mode. I added this because I think deer-mode looks deceptively similar to standard dired-mode and it may not be obvious what is occurring and how to switch to full ranger if the +ranger flag was set without reading the ranger.el docs.

Thanks!


AVRO-3826: Common tests for C++ module

What is the purpose of the change
this ticket AVRO-3591 aims to have common test suite for differents modules.
This PR complete it with task AVRO-3826 for C++ module (currently, it exists for Java, Rust and C).
Verifying this change
As this PR only add a unit test to C++ module, the only thing to do is "./build.sh test" command at this module.
Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@clesaec @martin-g Was it an intentional change that this introduced the use of #include <filesystem>, which is C++17 only, so it is no longer possible to compile Avro (or at least the tests) with C++14?
There is a fair amount of code in Avro which is written in a way that's obviously pre-C++17. If it is official policy that C++14 is no longer supported, there are quite a few cleanup things I'd like to do, and if that's not the case, it needs to be documented somewhere, and some pipeline added to make sure it doesn't get broken again.

@Gerrit0 I am not aware of any restrictions about the C++ standard that is (not) allowed to be used in Avro.
If C++-14 is the recommended maximum then maybe -std=c++14 should be added to the compilation settings ?!

Personally, I'd be happy to see Avro move to a C++17 minimum, so long as it was actually documented somewhere! The last time I updated my Avro dependency, it was on C++11, https://github.com/apache/avro/pull/960 changed the default compiler flags to 17, but didn't actually introduce any code that required it...

IMO the best documentation would be a build flag / linter that will complain when a newer feature is used.
I do not use the C++ SDK but I think it is OK to use C++17 for Avro 12.x.


Improve pt-BR i18n

I don't understand all the changes but I'm sure they are well done. Thanks!

Not that it was needed, but i just checked and it's fine :)


Add support for parallel fetching of Git submodules

Git v2.8 introduced support for parallel fetching of submodules. This can result in a substantial performance boost when performing a git submodule update in a repository with many submodules, potentially further magnified when updating submodules recursively.
This commit introduces a check on the Git version to see if it supports parallel submodule fetching. If it does, we add the --jobs=N argument to our call to git submodule update, where N is g:plug_threads or the vim-plug default of 16.
On my vim-plug configuration this more than halves the initial clone time of Vim plug-ins from ~70 seconds to ~30 seconds. The python-mode plugin makes a particularly good test case here as it includes a whopping 11 submodules.

Merged, thanks!


dinv.physics.PoissonNoise incompatible with dinv.physics.BlurFFT

After the latest updates to the library, when dinv.physics.PoissonNoise is used as the noise model in dinv.physics.BlurFFT, we get the following error: " TypeError: PoissonNoise.update_parameters() missing 1 required positional argument: 'gain' ".
It can be solved by modifying self.noise_model.update_parameters(**kwargs) in the update_parameters function of the BlurFFT class to self.noise_model.update_parameters(self.noise_model.gain, **kwargs). But it may cause errors with other noise models.

@samuro95 did you manage to look at this?


Revert "Add notice to README to make users aware of the docker hub issues"

This reverts commit 3b973395d2781f68683f0686e9c03c914c5b502c.
READMEs on docker hub for images with nested Docker files were fixed!
https://hub.docker.com/r/cantino/huginn/
https://hub.docker.com/r/cantino/huginn-single-process/

Nice!


ci: We are using the deprecated action for release-please

see for example the warning here: https://github.com/CQCL/guppylang/actions/runs/9299098100

I believe this has already been fixed: the current code mentions the new CI/CD action, as part of https://github.com/CQCL/guppylang/commit/c7ef1849da1ab69a76a5ada90f68aeff1e001fc9


Embeds often inherit page styles unintentionally

One side effect of embedding directly on page (instead of in an iframe) is that we pick up parent page styles. This is fine when intentional, but occasionally picks up things accidentally, like in this clearly oversized example:

We can't guarantee this, and we don't want to bloat our CSS with too long a selector chain, but I'm going to increase it just a bit to better isolate us from the scary world outside.

Yeah i've tried to do this with the viewer as well, and unfortunately there's no way we can fix the specificity issue since targeting with class selectors will always be weaker than element selectors or id selectors:

Unless we iframe we will always be at risk of weird markup.  That said, it really is nice when any of our embeds pick up nice styling.

Yup, I don't want to get into an escalating selector arm's race (HOW MANY METAPHORS CAN WE MARSHALL?), just wanting to hit that balance. I think I was being too ginger before. .DC-title as the uppermost selector for our H1 title when H1 styling like .entry-content h1 is suuuper common really needed big brother selector to go to bat for him.


Wapor doc

WaPOR documentation for inclusion once notebooks are ready

Hi @mickwelli , the content is not able to generate. I would continue to work on it to get it generated.

Thanks @nanaboamah89 looks good, I've checked the build: https://digital-earth-africa--149.org.readthedocs.build/en/149/data_specs/WaPOR_specs.html
The index location will have to be reorganised under the broader re-categorisation, but I think it's good to get WaPOR onto the docs with this PR.


HDDS-7873. [Snapshot] Prune backup SST files that can be expanded periodically

What changes were proposed in this pull request?
This change is to proactively remove the unnecessary SST files from the backup directory which are not needed to generate diff using compaction DAG.
These files are the one which get compacted to new files at each level. For example in the below graph, "000015", "000013", "000011", "000009" get compacted to "000018",  "000016", "000017".
We don't need "000018",  "000016", "000017" to generate diff because these are compaction of previous level .

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7873
How was this patch tested?

Unit tests

Oh wait the target branch is not master. I will cherry-pick this to master branch manually.

Done: https://github.com/apache/ozone/commit/9fba172b3f20987dbe5c7cf0bc3c712549b171d5


Line height is 23px on anchors in dropdowns

[x] bug
[ ] feature request
[ ] enhancement

Expected behavior
Line height should be 24px on dropdown list items
Actual behavior
Line height is 23px in the generated CSS
Reproduction of behavior

Environment details

Angular version: 2.0.X

Clarity version:  0.7.4

OS and version: OSX 10.12.1

Browser: [Chrome 54.0.2840.98]

@adityarb88 could you confirm and have a chat with @reddolan to get this fixed?

@reddolan: I see the height as 24px on the website and on my demo app. Is there any particular example that this is failing on? We did set the line-height to 23px because the text didn't appear vertically centered otherwise on Edge. @mathisscott could you please confirm this?

In the screenshot above, you can see that the CSS is showing 23px for line-height. This is directly from the website: https://vmware.github.io/clarity/documentation/dropdowns
It is coming from clarity-ui-min for .dropdown .dropdown-menu .dropdown-item

@reddolan. I know the line-height is set to 23px but that was done to vertically align the text on certain browsers. Along with the 23px line-height, we have also added a padding-top of 1px to make sure that the height remains 24px. I am not able to replicate the issue on my end :(

@reddolan @adityarb88 I am unable to replicate the issue on my end either. I see it at 24px.

Even though line-height is at 23px, we're still following our vertical rhythm and the overall is still at 24px. I am closing based on this and the comment before it.


UserWarning: The initializer GlorotNormal is unseeded and being called multiple times

using your examples of ktrain usage, e.g., imdb movie reviews I am getting:
model = text.text_classifier('bert', train_data=(x_train, y_train), preproc=preproc)
/usr/local/lib/python3.9/dist-packages/keras/initializers/initializers.py:120: UserWarning: The initializer GlorotNormal is unseeded and being called multiple times, which will return identical values each time (even if the initializer is unseeded). Please update your code to provide a seed to the initializer, or avoid using the same initalizer instance more than once.
warnings.warn(
done.
where do I add this seed within ktrain context, not separately during model building stage (e.g. in keras sequential)

I wasn't able to reproduce this in TensorFlow 2.9.1.  What version of TensorFlow are you using?

2.12.0
using colab

All transformer-based models in ktrain use HuggingFace Transformers except when you when you create a BERT model with text.text_classifier('bert', train_data=(x_train, y_train), preproc=preproc).  When you create a BERT model like this,  ktrain currently uses the keras_bert package.  (The only reason for this is that this function was added before Hugging Face Transformers supported TensorFlow.)   In the future, we may replace the implementation so that transformers is used instead of keras_bert. This is what happens when you replace 'bert' with 'distilbert' in the text_classifier function - i.e., HuggingFace Transformers is used under the hood.  It doesn't look like the warning is being generated from the ktrain codebase (the warning seems like it's coming from keras_bert).  So, if you want to avoid the warning, you can use the Transformer class in ktrain or you can just call the text_classifier method with distilbert instead of bert which should yield similar performance:
# load text data
categories = ['alt.atheism', 'soc.religion.christian','comp.graphics', 'sci.med']
from sklearn.datasets import fetch_20newsgroups
train_b = fetch_20newsgroups(subset='train', categories=categories, shuffle=True)
test_b = fetch_20newsgroups(subset='test',categories=categories, shuffle=True)
(x_train, y_train) = (train_b.data, train_b.target)
(x_test, y_test) = (test_b.data, test_b.target)

# train model
import ktrain
from ktrain import text
trn, val, preproc = text.texts_from_array(x_train=x_train, y_train=y_train,
                                          x_test=x_test, y_test=y_test,
                                          class_names=train_b.target_names,
                                          preprocess_mode='distilbert',
                                          maxlen=350)
model = text.text_classifier('distilbert', train_data=trn, preproc=preproc)
learner = ktrain.get_learner(model, train_data=trn, val_data=val, batch_size=6)
learner.fit_onecycle(3e-5, 1)

Thanks for letting us know about the warning.

you welcome, nest regards


Add link to github solidcommunity.net, gitter channel, forum on solidcommunity page?

Would it be a good idea to add a link to github projec/gitter/forum on the https://solidcommunity.net page?
I got myself locked out of my own pod and didn't find any information on the solidcommunity server pages itself where I could find a contact for help.
At the end I found my way, because I am long enough in the community to find the right channels (but I didn't know there was a dedicated gitter channel also)
E.g. a "Do you have any question? Please find us on Github , Gitter and Solid Community Forum" would be enough
See also: https://forum.solidproject.org/t/locked-out-a-pod-and-what-next/5813/4

Done. Thanks for the suggestion


Live CPU and MEMORY resize

Enhancement Request
Description
CPU resize should be supported in both KVM and vCenter VMs.
Needs to take into account VCPU and CPU. Only allow VCPU definition in cloud view, and create a VCPU/CPU ratio that can be defined in the VM Template by the admin
Needs to take into account quotas (need to figure out a way to present the CPU quotas to users)
Use case
Increase the amount of VCPU available for the guestOS.
Interface Changes
Changes in Sunstone and in CLI to allow for live CPU resize. Also changes in sunstone to reflect quotas
Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

I would say this is a duplicate of https://github.com/OpenNebula/one/issues/949

Also memory should be dynamically resized.

Needs Sunstone support

@tinova PR to be approved:

one: https://github.com/OpenNebula/one-ee/pull/575

@tinova PR to be approved:

Tests: https://github.com/OpenNebula/development/pull/1246

@tinova PR to be approved:

Tests: https://github.com/OpenNebula/development/pull/1246

ok, we just need this in the What's New. Assigning it to @paczerny as he did the documentation.

ok, we just need this in the What's New. Assigning it to @paczerny as he did the documentation.


example supply-chain does not work running or debugging locally

Describe the bug
When you are running or debugging supply-chain-app locally, http://localhost:3200/bamboo-harvest-list cannot be accessed
To Reproduce

Run or debug supply-chain-app as described in readme file.
Try to access http://localhost:3200/bamboo-harvest-list from browser
Localhost rejects the connection

Expected behavior
supply-chain application should be displayed in the browser

Yes, I faced the same error.


Problem with Universal Rendering

Hi. I encounter an issue with window in universal rendering.
FAILED: window is not defined ReferenceError: window is not defined
at Object.<anonymous> (xxxxx/node_modules/js-data-http/dist/webpack:/~/axios/lib/adapters/xhr.js:16:1)
at __webpack_require__ (xxxxx/node_modules/js-data-http/dist/js-data-http.js:38:30)
at executor (xxxxx/node_modules/js-data-http/dist/webpack:/~/axios/lib/core/dispatchRequest.js:31:1)
at dispatchRequest (xxxxx/node_modules/js-data-http/dist/webpack:/~/axios/lib/core/dispatchRequest.js:19:1)
at process._tickCallback (internal/process/next_tick.js:103:7)
(node:25772) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 4): ReferenceError: window is not defined

I don't know but maybe it will help to that regarding this function, different modules should be required for browser or node, but in the dist file, it's not. The module required contains call to window but it's not defined on server side.

The UMD build is only for browsers. Please use the npm package in Node.js.

I'm not import it directly, I'm using js-data, but I go check with them. Tanks a lot


node-debug.1.10.1 error

(node:7972) [DEP0062] DeprecationWarning: node --debug and node --debug-brk are invalid. Please use node --inspect or node --inspect-brk instead.
I just want to use any debug on atom for node.js
when i try to use node-debug, it made error message.
so what can i do for fix trouble?
it is possible that i adjust setting?

duplicate of #234


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_8d4f8152-9616-43dd-8495-44d0ea543cef/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_8d4f8152-9616-43dd-8495-44d0ea543cef.git

Docs Build status updates of commit 3dad129:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-01-14-09-26-43 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-01-14-09-26-43

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Plasticity example should be improved

Either use FerriteProblems as an example, or make example more complete wrt e.g. dt?

#17


Change XP levels

Good Day
As the Title states, can we change the XP amount for the random enchants >?
So that it could be say 10 levels ?
Thanks

Hello @Beez3-A,
The reason why the current cost is set to 3 levels is due to the Enchantment table already having textures for XP level costs 1-3. I could add a gamerule that lets the player change the cost in between 1 through 3, but no more since there are no textures for 4+

Hello @Ramixin
okay cool 3 levels is good then I see what you mean
Thanks for the cool Mod


improve coverage of with_options_sink.yaml

          I just realized that with options for cassandra sink are not included in this yaml. Let's revisit other sinks as well to ensure all sinks are covered.

Originally posted by @hzxa21 in https://github.com/risingwavelabs/risingwave/pull/15516#discussion_r1517132044

Here it's because we only support similar logic for rust's sinks, and given that we have fewer and fewer java implementations of sinks, it's not clear if we'll still have to implement this check for java_sink

Fair enough. I will close this issue for now.


Generate periodic vanishing polynomial values

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.05%. Comparing base (86ddb92) to head (3346d6d).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #745   +/-   ##
=======================================
  Coverage   93.05%   93.05%
=======================================
  Files          86       86
  Lines       11209    11209
  Branches    11209    11209
=======================================
  Hits        10431    10431
  Misses        685      685
  Partials       93       93

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


acc/f1 calculation

Hi, thank you for your great work! However, there seems to be a little mistake. accuracy_score, f1_score imported from sklearn.metrics should be:
f1_score / accuracy_score(y_true, y_pred)

which is from
https://github.com/declare-lab/Multimodal-Infomax/tree/main/src/utils/eval_metrics.py#L47
you can check it in https://scikit-learn.org/0.21/modules/classes.html#sklearn-metrics-metrics

Thanks for your pointing out. We have rerun the experiments and found f1_score is even higher. Therefore we preserve the previous results.


Windows defender flagged it Win32/Znyonm

No matter how many times i scan and remove or quarantine this detection it always show up again and again XD what is this? and its always Active even i already deleted all the components of R3nzskin

it has a file named drRLpoN8.exe, but i cant see it in my folder even i enable the hidden files? please explain it to me before closing this!

Anti-virus software falsely reports R3nzSkin as malicious because it uses specific Win32 APIs required for DLL injection or game memory scanning, which are features not commonly found in programs.


MailLink - remove Changes in 7.1 FAQ

Remove https://docs.superoffice.com/email/maillink/changes-in-7-1.html and its references
Confirmed with Vilnius, content will be partially moved to FAQ.

Better for FAQ's to link to the docs, rather than maintaining the material on two different sites.


ADC memory leak (IDFGH-14005)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.1.4-991-g725e8d6392 (latest v5.1)
Espressif SoC revision.
ESP32-D0WDQ6-V3
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
Development Kit.
TTGO T8
Power Supply used.
USB
What is the expected behavior?
No memory leaks when an ADC is created and destroyed.
What is the actual behavior?
Memory leak of 44 bytes when an ADC is created and destroyed.
Steps to reproduce.

#define BATTERY_ADC_UNIT       ADC_UNIT_1
#define BATTERY_ADC_CHANNEL    ADC_CHANNEL_7
#define BATTERY_ADC_BITWIDTH   ADC_BITWIDTH_12

/*---------------------------------------------------------------
        ADC Calibration
---------------------------------------------------------------*/
static void battery_adc_calibration_init(adc_unit_t unit, adc_atten_t atten, adc_cali_handle_t *out_handle)
{
	static bool calibration_printed = false;
    esp_err_t ret = ESP_FAIL;
    bool calibrated = false;

#if ADC_CALI_SCHEME_CURVE_FITTING_SUPPORTED
    if (!calibrated) {
        adc_cali_curve_fitting_config_t cali_config = {
            .unit_id = unit,
            .atten = atten,
            .bitwidth = BATTERY_ADC_BITWIDTH,
        };
        ret = adc_cali_create_scheme_curve_fitting(&cali_config, out_handle);
        if (ret == ESP_OK) {
			if (!calibration_printed) {
            	ESP_LOGI(TAG, "ADC calibrated mode Curve Fitting");
            	calibration_printed = true;
			}
            calibrated = true;
        }
    }
#endif

#if ADC_CALI_SCHEME_LINE_FITTING_SUPPORTED
    if (!calibrated) {
        adc_cali_line_fitting_config_t cali_config = {
            .unit_id = unit,
            .atten = atten,
            .bitwidth = BATTERY_ADC_BITWIDTH,
        };
        ret = adc_cali_create_scheme_line_fitting(&cali_config, out_handle);
        if (ret == ESP_OK) {
			if (!calibration_printed) {
            	ESP_LOGI(TAG, "ADC calibrated mode Line Fitting");
            	calibration_printed = true;
			}
            calibrated = true;
        }
    }
#endif

    if (ret != ESP_OK) {
        ESP_LOGW(TAG, "ADC not calibrated");
    }
}

/**
 * Initialize an analog SDP sensor with ADC
 *
 * @param sensor  sensor handle
 * @return        err code
 */
esp_err_t battery_init() {
    adc_oneshot_unit_init_cfg_t adc_init_cfg = {
        .unit_id = BATTERY_ADC_UNIT,
        .ulp_mode = false
    };
    BSP_SOFTCHECK(adc_oneshot_new_unit(&adc_init_cfg, &m_adc_handle));

    adc_oneshot_chan_cfg_t adc_chan_cfg = {
        .bitwidth = BATTERY_ADC_BITWIDTH,
        .atten = ADC_ATTEN_DB_12,
    };
    BSP_SOFTCHECK(adc_oneshot_config_channel(m_adc_handle, BATTERY_ADC_CHANNEL, &adc_chan_cfg));

    battery_adc_calibration_init(BATTERY_ADC_UNIT, ADC_ATTEN_DB_12, &m_adc_cali_handle);

    return ESP_OK;
}

void battery_deinit() {
	if (m_adc_handle) {
		adc_oneshot_del_unit(m_adc_handle);
		m_adc_handle = NULL;
	}
}

void esp_dump_per_task_heap_info(const char *name)
{
	static size_t s_prepopulated_num = 0;
	static heap_task_totals_t s_totals_arr[MAX_TASK_NUM];
	static heap_task_block_t s_block_arr[MAX_BLOCK_NUM];

	TaskHandle_t tasks[] = {xTaskGetCurrentTaskHandle()};

    heap_task_info_params_t heap_info = {0};
    heap_info.caps[0] = MALLOC_CAP_8BIT;        // Gets heap with CAP_8BIT capabilities
    heap_info.mask[0] = MALLOC_CAP_8BIT;
    heap_info.tasks = tasks;                     // Passing NULL captures heap info for all tasks
    heap_info.num_tasks = 1;
    heap_info.totals = s_totals_arr;            // Gets task wise allocation details
    heap_info.num_totals = &s_prepopulated_num;
    heap_info.max_totals = MAX_TASK_NUM;        // Maximum length of "s_totals_arr"
    heap_info.blocks = s_block_arr;             // Gets block wise allocation details. For each block, gets owner task, address and size
    heap_info.max_blocks = MAX_BLOCK_NUM;       // Maximum length of "s_block_arr"

    heap_caps_get_per_task_info(&heap_info);
    ESP_LOGI(TAG, "%s %zu", name, heap_info.totals[0].size[0]);
}

        ...
	esp_dump_per_task_heap_info("before");
	battery_init();
    	battery_deinit();
    	esp_dump_per_task_heap_info("after");

Let me know if I can examine the heap size of the current task other than with heap_caps_get_per_task_info.
Debug Logs.
I (09:57:33.737) bsp: before 873560
I (09:57:33.746) bsp: after 873604
I (09:57:33.768) bsp: before 873604
I (09:57:33.777) bsp: after 873648
I (09:57:33.788) bsp: before 873648
I (09:57:33.796) bsp: after 873692

More Information.
No response

adc_cali_create_scheme_line_fitting is used here.

Question: does it make sense to init and deinit an ADC to measure once per minute? Or, from the power perspective, we can init the ADC only once and read measurements once per minute: does ADC consume power when it's inactive and not destroyed?

@dizcza  If you use adc_cali_create_scheme_curve_fitting, you have to use adc_cali_delete_scheme_curve_fitting to free up the memory allocation.

@rosmianto didn't know that! thanks

I'd like to know though, does ADC consume power when it's inactive and not destroyed?


Code grouping on functions with multiple bodies

When it finds a function declaration, the output format ensures there's white space around it and it expands ,do: ... constructs into do ... end. This is fine to ensure there is white space between functions. However, when a function has several bodies that use pattern matching to choose the correct implementation, it would be useful to ensure that those different bodies are grouped together to indicate that they are parts of the same function.
Examples from code
Several bodies of equivalent complexity
  def etag(data) when is_bitstring(data) or is_binary(data) do
    Crypto.hash(:sha256, data) |> Base.encode64
  end
  def etag(data) do
    Crypto.hash(:sha256, Poison.encode!(data)) |> Base.encode64
  end

In this example, I have no space between the two definitions because both define the etag function with different conditions on the attributes. Those two blocks belong together. Separating them as if they implemented different functions renders the code less readable.
First body for trivial or nil case, main body below
  def key(nil), do: nil
  def key(%Guide{key: key}) do
    something more complicated
  end

In this example, the first definition deals with a trivial case to catch a possible nil while the meat of the function is in the second definition. Separating them would make it less obvious that the nil case is dealt with.
Implementations where most of the work is done in pattern matching
  def handle_result({:atomic, []}, _spec, {:one, _}), do: {:ok, nil}
  def handle_result({:atomic, [r]}, spec, {:one, fmt}), do: {:ok, format_record(r, spec, fmt)}
  def handle_result({:atomic, l}, _spec, {:one, _}), do: {:error, {:too_may, Enum.count(l)}}
  def handle_result({:atomic, l}, spec, {:many, fmt}), do: {:ok, Enum.map(l, &(format_record(&1, spec, fmt)))}
  def handle_result({:atomic, _}, _spec, {:static, v}), do: {:ok, v}
  def handle_result({:atomic, r}, _spec, _mode), do: {:ok, r}
  def handle_result({:aborted, error}, _spec, _mode), do: {:error, error}
  def handle_result(error, _spec, _mode), do: {:error, error}

In this case, most of the work is done by the pattern matching, the bodies are (mostly) trivial so the benefit of this presentation is that it clearly shows the different patterns against each other. That said, I end up with individual lines that are slightly too long so maybe a better presentation for this code would be to expand the non-trivial bodies:
  def handle_result({:atomic, []}, _spec, {:one, _}), do: {:ok, nil}
  def handle_result({:atomic, [r]}, spec, {:one, fmt}) do
    {:ok, format_record(r, spec, fmt)}
  end
  def handle_result({:atomic, l}, _spec, {:one, _}) do
    {:error, {:too_may, Enum.count(l)}}
  end
  def handle_result({:atomic, l}, spec, {:many, fmt}) do
    {:ok, Enum.map(l, &(format_record(&1, spec, fmt)))}
  end
  def handle_result({:atomic, _}, _spec, {:static, v}), do: {:ok, v}
  def handle_result({:atomic, r}, _spec, _mode), do: {:ok, r}
  def handle_result({:aborted, error}, _spec, _mode), do: {:error, error}
  def handle_result(error, _spec, _mode), do: {:error, error}

Suggestions

Have different spacing between genuinely different functions than between different bodies of the same function so that the grouping is clear.
Only expand the ,do: ... construct into do ... end if the full line is longer than 80 characters.

Have different spacing between genuinely different functions than between different bodies of the same function so that the grouping is clear.

This is the current behavior. :)

Only expand the ,do: ... construct into do ... end if the full line is longer than 80 characters.

Some form of sugarless do block preservation may be implemented at a later date, but not any time soon I'm afraid.

Going to close this, please open a new issue for any additions you'd like to request :)


Protocol Download

Protocol Download
THIS ENDPOINT IS HTTP ONLY.
HTTP endpoint: GET /federated/get-protocol
Query string: ?worker_id=ID OF THE WORKER&request_key=LONG HASH VALUE&protocol_id=ID OF THE PROTOCOL
This method will allow a worker that has been accepted into a cycle to request the download of a protocol from PyGrid. They need to submit their request_key provided in the cycle request call above. This provides an extra means of authentication for PyGrid to ensure it's sending data to the right worker.
Response: This downloads the protocol to the worker.
Refers : #445

Can i get this one?

It's yours!


Typeo in method description

There's a typeo on this line - https://github.com/VerifyTests/Verify/blob/837ebedcb32b1b21118d22ecb40b056650775b0f/src/Verify/SettingsTask.cs#L227
I think it should read: "Automatically accept the results of the current test.

@Bencargs thanks. this is fixed now.
as an aside what are you using verify for? and are you using diffenginetray https://github.com/VerifyTests/DiffEngine/blob/master/docs/tray.md


Add items at runtime

There should be a way for gamemodes to add new items to the game. This will be tricky as this should include building. How this should be done it TBD. Definitely a post 0.1.2 thing.

The new building system coming in 0.1.3 will help to allow this by having all building calculations being done by delegates stored in a dictionary which are looked up by item ID. We are no where near ready to have full custom item support but this is a good step.

Builtin mod support has been removed. Closing due to now being irrelevant


Implement help similar to how makext handles it.

Instead of one big help string, help text is built by reading comments on the targets. That's much more maintainable, IMO.

I've added a simple usage target and set it as the default. The help target is retained, now to be treated as a help doc.
I don't know how I really feel about that though. I'd prefer to have all help text for each command in one place. That's easier to maintain.

I'm satisfied with this change, actually.

I'm not the only one. Heh. https://tech.target.com/blog/make-python-devex
I wonder if I can do usage in a better way following their usage example.


fix the early 2013, 2013, 2014, 2015, 2016, 2017 watch page if you can do all that

thats all (i think)

nvm it was just a setting that made it glitched


As an administrator, I can add other global user to my account

I will need to enter the Email and the role for the user
If email does not belong to any registered global user, a email will be sent to the target email to prompt the user to sign up as a global user, once the user signup they will be added to the account automatically.
If email belongs to a registered global user, a email will be sent to the target email to notify the user has been added to the account

Will not be implemented for now, we are going towards a more AWS model, where we standard user cannot join other account, they must join as a managed user.


Create Discord Multi Notifications

This Plugin Provides the ability to parse multiple Discord server webhooks to simultaneously send multiple notifications at a time.
Features include: multiple webhooks for death screenshots and multiple webhooks for Collection log slots and Loot!
This is intended to provide an All-in-One experience for the user that would want their notifications posted across multiple servers they are apart of.
This eliminates the need for any redundancy as many users use multiple plugins with the same features to have the ability to post to multiple servers.

Is there any feature your plugin adds that Dink does not already have?
We've been trying to truly make a centralized notification plugin, and we already support your main feature of sending notifications to multiple webhooks, for all of our notification types.

Ah yes i see , currently the plugin does not add anything unique to set it apart from Dink at this current stage. Thank you for the comment!


purgeSingleUrl gives "malformed purge request" error

Version
3.0.0
What happened
I followed the example and the function doesn't form the request correctly. Thecached_url is encoded by buildUrl() inside ApiClient.js.
This is how the URL is formed and sent by the API
https://api.fastly.com/purge/www.example.com%2Fpath%2Fto%2Fpurge

It supposed to be
https://api.fastly.com/purge/www.example.com/path/to/purge

👋🏻
I believe this has been resolved in the v3.3.0 release.


$cordovaMedia recording doesn't work

Hi, I've been working with $cordovaMedia for about 10 hours, and it appears to be broken.
Here's a git repo with my test project.  I'm pushing it to an Android 4.4 device to test.
git@github.com:MichaelJCole/ngCordovaAudioTest.git
view, controller
Is my app broken, or is $cordovaMedia?
I haven't found an example or tutorial of this functionality working.  Is there something I'm missing?
Thanks!
Mike

Thanks for this reproduction. I'll take a look and let you know.

@MichaelJCole I've checked your code and I see where's the problem. It's in your $scope.openMedia function.
$scope.openMedia = function(filePath) {
$scope.filePath = $scope.fileName($scope.fileTitle)

return $cordovaMedia.newMedia($scope.filePath)
.then(function (success) {
  console.log('success openMedia');
  console.log(success);
}, function (error) {
  console.log('error openMedia');
  console.log(error);
});

};
If you use the .then functions when using $cordovaMedia.newMedia(src) you won't get anything in your variable. Turn your function to this and I think that'll solve your problem.
$scope.openMedia = function(filePath) {
$scope.filePath = $scope.fileName($scope.fileTitle)
return $cordovaMedia.newMedia($scope.filePath);
};

@Kurtz1993 Thanks for following up!  I'll check it out.