[FEATURE REQUEST] A screen with an icon and data displayed on it.

Feature Request
Describe the solution / feature you'd like
I've already displayed the concept in another Issue, but I'll move it here.
Add a family of screens that could display some limited data like day of the week, day of the month, on an icon that works as a carpet pad.
For example:

icon_time - display: icon and time, like weather and time
icon_time_data - display: icon and time, like calendar icon, day or weekday on icon and time
icon_date - display: icon and date, like weather and time
icon_date_data - display: icon and date, like calendar icon, day or weekday on icon and time

Generate a window identifier for each screen, then you can have identical sets displaying different information, like:

weather - time
day - time
weekday - data
weather - temperature

Also add the ability to specify a starting set of screens), e.g. icon_time with day icon_date_with_weekday`
Additional context
Сoncept:
https://github.com/lubeda/EspHoMaTriXv2/issues/85#issuecomment-1738627157

@andrewjswan Thanks! I tested the display with this icon, and it seems that it would be better to omit a number or a word, since it is strongly pressed to the top. There are also doubts about the gaps in both days and days of the week. maybe in the config it is possible to specify which format to show? Since opinions may be divided. Options on the screenshots

since it is strongly pressed to the top

The baseline specified in the config for the selected font is used for output, i.e. the information on the icon is on the same bottom line as the font displayed on the right. The easiest solution is to specify 7(8) as the baseline, then the information on the icon will be displayed starting from the second bottom line, the way is more complicated is to get the font metric, get its width and height, and according to it output the text.
I will try both options, see how it will be better and easier.

There are also doubts about the gaps in both days and days of the week. maybe in the config it is possible to specify which format to show?

Well, the usual, simple, crutchy way I can do it. The smart way is to pass the display format and store it, I don't know what is better, but let's start with crutches. :) Let's use a pipe | :)

Mode added ...

icon|day#mode
icon|weekday#mode
mode:
0 - default - left and right - baseline from font
1 - center - baseline from font
2 - center - right - baseline from font
3 - left and right - baseline 7
4 - center - baseline 7
5 - center - right - baseline 7
https://github.com/andrewjswan/EspHoMaTriXv2/commit/4949ceeb58535b004ef2fe4272191ed1c2d9e5b6

@malinovsku @lubeda
I think this is the best option.
I just need to add the ability to set 2 colors, or separately for days and days of the week, i.e. 4.

set_infotext_color added ...

Tested it yesterday, not all bad but not all good either.
Different fonts bring a lot of variety, especially letters, each font has its own base line, width, height, and it is difficult to calculate and correctly fit into a matrix 8x8, I added info_text_yoffset to specify the base line for displaying information on the icon. I also redid the display modes.
I'll check how it works and make a PR.

For now, the current display modes:
Default:

Mode 1:

Mode 2:

Mode 3:

Mode 4:

Although, I see Igor did it through functions, maybe that's more correct, I'll follow that way. I will make changes in my new code and check it.
https://github.com/lubeda/EspHoMaTriXv2/commit/fbdb8feb0d8f1a5d93076d10e959141ca658b441

Look like all work fine...

Test scrypt:
script:
  pixel_clock_test:
    alias: "Pixel Clock - Test"
    sequence:
      - service: esphome.pixel_clock_set_infotext_color
        data:
          left_r: 50
          left_g: 50
          left_b: 50
          right_r: 50
          right_g: 50
          right_b: 240
          default_font: true
          y_offset: 1

      - service: esphome.pixel_clock_icon_date
        data:
          icon_name: calendar|day
          lifetime: 1
          screen_time: 5
          default_font: true
          r: 240
          g: 0
          b: 0
      - service: esphome.pixel_clock_icon_date
        data:
          icon_name: calendar|day#1
          lifetime: 1
          screen_time: 5
          default_font: true
          r: 0
          g: 240
          b: 0
      - service: esphome.pixel_clock_icon_date
        data:
          icon_name: calendar|day#2
          lifetime: 1
          screen_time: 5
          default_font: true
          r: 0
          g: 0
          b: 240
      - service: esphome.pixel_clock_icon_date
        data:
          icon_name: calendar|day#3
          lifetime: 1
          screen_time: 5
          default_font: true
          r: 240
          g: 240
          b: 240
      - service: esphome.pixel_clock_icon_date
        data:
          icon_name: calendar|day#4
          lifetime: 1
          screen_time: 5
          default_font: true
          r: 240
          g: 240
          b: 240

      - service: esphome.pixel_clock_icon_date
        data:
          icon_name: calendar|weekday
          lifetime: 1
          screen_time: 5
          default_font: true
          r: 240
          g: 0
          b: 240

Look like All worked ...

There was an error in set_infotext_color which is fixed now.

Request down in 2023.9.1

thank you, you do cool things!


#151 make minter optional

PR for #151
Rather prefer having minter: Option<String>:
https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/contracts/cw721-base/src/msg.rs#L8-L18
In case of none, info.sender should be minter. Makes it easier for other contracts (e.g. minter) re-using this msg.
In most cases creator of contract is also minter. Rn creator (=sender) instantiates contract AND need to provides its own address in minter prop. You can see this in unit tests:
Before: duplicate, since creator is in info.sender and minter.prop
        let info = mock_info(CREATOR, &[]);
        let init_msg = InstantiateMsg {
            name: "SpaceShips".to_string(),
            symbol: "SPACE".to_string(),
            minter: CREATOR.to_string(),
            withdraw_address: None,
        };
        entry::instantiate(deps.as_mut(), mock_env(), info.clone(), init_msg).unwrap();

After: no need to provider minter prop, since creator is sender:
        let info = mock_info(CREATOR, &[]);
        let init_msg = InstantiateMsg {
            name: "SpaceShips".to_string(),
            symbol: "SPACE".to_string(),
            minter: None,
            withdraw_address: None,
        };
        entry::instantiate(deps.as_mut(), mock_env(), info.clone(), init_msg).unwrap();

Instantiation is like this then:
like before, in case caller should NOT be minter/owner (edge case):
{"name": "foo", "symbol": "bar", "minter": "other_than_caller"}

for creator (standard, 99.99% case):
{"name": "foo", "symbol": "bar"}

@shanev @JakeHartnell

You can also see from adjusted tests - it looks more convenient and natural.

Reason, why I came to this conclusion is this here: https://github.com/public-awesome/launchpad/blob/main/contracts/collections/sg721-base/src/contract.rs#L53-L58
All this logic can completely be removed, by calling parent.instantiate. Also these 3 props can be replaced by cw721_base::msg::InstantiateMsg: https://github.com/public-awesome/launchpad/blob/main/packages/sg721/src/lib.rs#L118-L120
@jhernandezb

@shanev need one more approval, then we can merge and release 0.19.0 (#150)


Windows input: Modifier keys get stuck after alt+tab

Tested versions

Reproducible in 4.3.beta bd2300d
Not reproducible in 4.2.1
Not reproducible in 4.3 2efbc6bf

System information
Godot v4.3.beta (bd2300d77) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; <IP_ADDRESS>13) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)
Issue description
When alt-tabbing into godot (or sometimes when alt-tabbing out of godot), the alt key seems to remain stuck. Weird things start happening such as multiple carets in the text editor or keys cause bottom panels to pop up.
The user must recognize the alt key is stuck and press all the modifier keys once to clear.
This issue does not reproduce every time.
Steps to reproduce

it helps to be doing something at the time, such as camera orbit (see the other related issues)
Alt-tab out of Godot
Alt-tab into Godot
Press the d key. If the issue has reproduced, the debugger window will pop up.
Any key pressed will act as if alt is held.
Press the alt key to clear.
Repeat.

Minimal reproduction project (MRP)
Reproduces on an empty new project

12fda2fc13426799bd4376c1fbd99b179c685559 may have caused the regression.

can confirm/reproduce this consistently as well (windows 10, godot 4.3-beta1)
pretty much every time I press "alt", it goes into sticky keys mode

This was already solved in latest master 96a386f by #92415 (see https://github.com/godotengine/godot/issues/92759#issuecomment-2148797918)

I have I think a duplicate issue #81211 and I just confirmed it's not fixed on master.


Problem with network IPv4 address carry-over

Thank you for the watchtower alternative!
I have a container that has a statically set IPv4 address, <IP_ADDRESS>, and uses a custom network, pub_net (using the macvlan driver).
When the image is updated for the container the IPv4 address does not carry over.
JSON snippet before update:
"Networks":{"pub_net":{"IPAMConfig":{"IPv4Address":"<IP_ADDRESS>"},
"Links":null,
"Aliases":["3cae90f8d084"],
"NetworkID":"5e9c23c1a6132f507d2233e866aa2d49cae21f2579fb7e0d9feab354483d2aca",
"EndpointID":"a7ca96c18fe54a0991099bf2cc55b63c50d1515aefe3bf0a1001130d7f0f77d0",
"Gateway":"<IP_ADDRESS>",
"IPAddress":"<IP_ADDRESS>",
"IPPrefixLen":24,
"IPv6Gateway":"",
"GlobalIPv6Address":"",
"GlobalIPv6PrefixLen":0,
"MacAddress":"02:02:02:a8:6e:bd",
"DriverOpts":null,
"IPAMOperational":false}},
After:
"Networks":{"pub_net":{"IPAMConfig":null,
"Links":null,
"Aliases":["d0272f83f199"],
"NetworkID":"5e9c23c1a6132f507d2233e866aa2d49cae21f2579fb7e0d9feab354483d2aca",
"EndpointID":"c9b0d6e89241340be094ee8786d21a82257cbfc342d80f00373a87270e2a1a38",
"Gateway":"<IP_ADDRESS>",
"IPAddress":"<IP_ADDRESS>",
"IPPrefixLen":24,
"IPv6Gateway":"",
"GlobalIPv6Address":"",
"GlobalIPv6PrefixLen":0,
"MacAddress":"02:02:02:a8:6e:02",
"DriverOpts":null,
"IPAMOperational":false}},
The main difference appears to be the IPAMConfig information does not carry over, and then doesn't reflect in IPAddress.

well thats less than ideal. I dont have statically assigned IPs so i never caught that! Ill dig into the code today and see why the structure is ignoring it.
Out of curiosity, what is your use case for static in docker? (Havent had any glaring reasons myself yet)

Plex and pihole are a couple.

Ah. so personal preference. ( I dont need static for those). I will update in a bit when i have a change to dig in.

So, yes, personal preference. Thanks again for looking into it.

This is also a problem for network aliases (such as created by docker-compose)
I suspect set_properties in helpers.py needs to be updated to handle networking

+1 my updated containers are not resolvable on in the network which just straight-up breaks connectivity :(

I also have kind of the same problem. I have some containers that are attached to more than one network, after the update they are no longer connected to the second network.
After having a short look at the code, this (and the issue of @noskcajn) might be due currently ouroboros does not carry over any networking config at all (correct me if I'm wrong): ouroboros/pyouroboros/helpers.py

I just tried to reproduce this issue:
docker network create test --subnet=<IP_ADDRESS>/24 --gateway=<IP_ADDRESS>
docker run -d --name=test --network=test --ip=<IP_ADDRESS> fedora:28 sleep 999999
docker inspect test > /tmp/before
docker run -it --rm --name=ouroboros --hostname=ouroboros -v /var/run/docker.sock:/var/run/docker.sock pyouroboros/ouroboros --run-once --latest
docker inspect test > /tmp/after
diff -u /tmp/before /tmp/after

And here is the diff between before the ouroboros run and after (I stripped not relevant lines):
--- /tmp/before 2019-02-09 14:07:15.910396995 +0100
+++ /tmp/after  2019-02-09 14:07:46.925436479 +0100
@@ -133,8 +133,8 @@
             "Domainname": "",
             "User": "",
             "AttachStdin": false,
-            "AttachStdout": false,
-            "AttachStderr": false,
+            "AttachStdout": true,
+            "AttachStderr": true,
             "Tty": false,
             "OpenStdin": false,
             "StdinOnce": false,
@@ -177,15 +177,13 @@
             "MacAddress": "",
             "Networks": {
                 "test": {
-                    "IPAMConfig": {
-                        "IPv4Address": "<IP_ADDRESS>"
-                    },
+                    "IPAMConfig": null,
                     "Links": null,
                     "Aliases": [
                         "f0b013fcc760"
                     ],
                     "NetworkID": "717de8744adee3253bb915dff0ba0dd6997351d8bf56ffd3ea81f710161fdbf3",
                     "EndpointID": "f94821ae24454b46378e8f2b6fbe060baad1884362aea761eaa118fdd7b53778",
                     "Gateway": "<IP_ADDRESS>",
                     "IPAddress": "<IP_ADDRESS>",
                     "IPPrefixLen": 24,

This diff reveals the issue of @noskcajn (and also possible another bug regarding AttachStdout and AttachStderr).

And here is a diff when updating a container with multiple networks attached (again I stripped non relevant lines, including the AttachStderr/out thing):
--- /tmp/before 2019-02-09 14:19:51.312223134 +0100
+++ /tmp/after  2019-02-09 14:20:19.046256642 +0100
@@ -159,46 +159,31 @@
         },
         "NetworkSettings": {
             "Bridge": "",
             "SandboxID": "fae8f68bb085bcd6b11c7e5410e0f269912eca3b8dbafadc1d7f329e6087540f",
             "HairpinMode": false,
             "LinkLocalIPv6Address": "",
             "LinkLocalIPv6PrefixLen": 0,
             "Ports": {},
             "SandboxKey": "/var/run/docker/netns/fae8f68bb085",
             "SecondaryIPAddresses": null,
             "SecondaryIPv6Addresses": null,
              "EndpointID": "",
-            "Gateway": "<IP_ADDRESS>",
-            "GlobalIPv6Address": "fd4c:5f97:84be:b89e:0:242:c0a8:a902",
-            "GlobalIPv6PrefixLen": 64,
-            "IPAddress": "<IP_ADDRESS>",
-            "IPPrefixLen": 24,
-            "IPv6Gateway": "fd4c:5f97:84be:b89e::1",
-            "MacAddress": "02:42:c0:a8:a9:02",
+            "Gateway": "",
+            "GlobalIPv6Address": "",
+            "GlobalIPv6PrefixLen": 0,
+            "IPAddress": "",
+            "IPPrefixLen": 0,
+            "IPv6Gateway": "",
+            "MacAddress": "",
             "Networks": {
-                "bridge": {
-                    "IPAMConfig": {},
-                    "Links": null,
-                    "Aliases": [],
-                    "NetworkID": "dff833bfdf56f2f3926a61564ea94f09df0afe4a8b157a51188d978be063f9f8",
-                    "EndpointID": "2b7669211dafb598725fa21bb37cda8eb3e1104cfb37bd4ba050baf6baa3590d",
-                    "Gateway": "<IP_ADDRESS>",
-                    "IPAddress": "<IP_ADDRESS>",
-                    "IPPrefixLen": 24,
-                    "IPv6Gateway": "fd4c:5f97:84be:b89e::1",
-                    "GlobalIPv6Address": "fd4c:5f97:84be:b89e:0:242:c0a8:a902",
-                    "GlobalIPv6PrefixLen": 64,
-                    "MacAddress": "02:42:c0:a8:a9:02",
-                    "DriverOpts": null
-                },
                 "test": {
                     "IPAMConfig": null,
                     "Links": null,
                     "Aliases": [
                         "e8dc1e1e01d8"
                     ],
                     "NetworkID": "717de8744adee3253bb915dff0ba0dd6997351d8bf56ffd3ea81f710161fdbf3",
                     "EndpointID": "2c36dbcbcbe8b956bec809cb0e43633b8d5c137c629b9378512e7836cf538779",
                     "Gateway": "<IP_ADDRESS>",
                     "IPAddress": "<IP_ADDRESS>",
                     "IPPrefixLen": 24,

Apparently only one network is carried over (test), but both should be.

@noskcajn I implemented a fix in #195. If you would like to test if that fixes your issue you can build an updated image with the following command:
docker build -t ouroboros:local-build https://github.com/pyouroboros/ouroboros.git#pull/195/head

This can be tested using our -develop tag now.

Appears to work!
The new container gets both the new and old containers hostname as alias however, but I dont' think that'll cause any issues.
                   "Aliases": [
                        "xxxxxx",
                        "99598a0c9ce6",
                        "1acdbc70ee05"
                    ],

That's intended, because otherwise we would need to classify labels and decide for each one whether to carry it over or not.. As these IDs are sha256 hashes a collision should be very unlikely.

@nightvisi0n did you get a chance to push the bugfix for the last push with ipv6?

@DirtyCajunRice I wait for @frebib to verify that it's fixing his issue.. but I can also create a PR right now if you want

@nightvisi0n Yeah make the pr so it can be commented on and adjusted if needed :)

There it is: #200

@nightvisi0n I've not hand chance yet. Hopefully I'll get time tonight when I get home from work.
At the moment, #197 is more of a breaking issue right now

@nightvisi0n As for removing the old hostname from the label-set, it would probably be a good idea to at the very least, add an opt-in option to remove the old hostname from the labels just so that list doesn't grow over time.

they ARE just sha. The numerical chances of it being an issue are quite small. I dont know if the list growing is even a real concern. It is a thought. Just dont know if it has any concerning weight

Initial testing using the develop tag appears to keep IP information as expected. I will try further testing as I can. So far it looks good.

Ok. This is working in develop going to close this one out.


ci: run manifest command to update extra files on release

Putting this back as draft, as we might not want to update the Version.sol for the next release, since it will apply only to the tokens and not the other contracts that inherit Version.sol


Fix broken light_compute in mobile renderer

Fix https://github.com/godotengine/godot/issues/54938

Thanks!


[Frontend] Fix Button Issues

Deliverable:

[ ] Currently, the button's of different form has deformed. Fix it so that it remains consistent through-out
Join Us Form
Contact Us Form
Admin Form
Resource Sharing form

Make sure to make the buttons consistent for all the form on all screens

@Kajol-Kumari can I work on this issue?

@Kajol-Kumari can I work on this issue?

sure @vedikaag99 Please go ahead :)


Virtual-Scroll with very big data.

I am using Ionic2 (beta.11) Virtual-Scroll component to scroll big lists of data. For relatively small amounts (2000 items in array) it works fine. With big amounts of data (50.000 items in array) the scroll works fine in the browser, but get's stuck and works very buggy on the Ionic View Iphone testing.
The way the component works I have to load in all data initially. There is no way to load more data after a certain amount has been scrolled (as in infinite-scroll). As well the component docs say changing the dataset leads to a "reset" of the scroller.
How should this scenario be handled properly ? Anybody has experienced/solutions to handling huge amounts of list data in Ionic2 ?

I'd recommend not using Ionic View at all in your testing. It's too finicky regarding too many issues to be very useful. It's too limiting, and puts an extraneous layer between your code and your device which creates more opportunities for failure.
You'll waste time hunting down bugs (related to keyboard, local storage, status bar, plugins, etc.) only to find out they weren't bugs to begin with, because your app works as expected when running on a device.
tldr; develop in your browser, skip Ionic View, and go directly to testing on a device.
P.S. Use WKWebView. I've had a couple issues magically disappear by dropping UIWebView.

Hello @lujakob do you get the same issue when running the app installed on your device? Thanks for using Ionic!

Try it out on android, virtual scroll on iOS at the moment is in need of some love in my experience.  You could always load the initial data into one array in your JavaScript and then move smaller chunks of data progressively into a second array, implementing in essence your own very simple paging support and then you use infinite scroll on that second array to display with a method that simple copies in the next 500 results or something when you hit the end of the current data

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

Hi,
In my opinion the design of how Virtual Scroll works should be improved.
It should be possible to get the prev/next pages lazily, i.e. with Ajax calls.
If you have a lot of data then the user most probably will never scroll down to the bottom, so there is no need to download everything on the device.
One would suggest to use Infinite-Scroll for this use case, but it doesn't unload the previous items.
The best would be something like Infinite-Scroll component that unloads invisible elements in both directions and has (ionInfinite) for both prev and next.

Hi @jgw96 ,
we still need a solution for combining the features of virtual scroll with infinite scroll to be able to load data dynamically into virtual scroll as described by margin-g in his comment. On scrolling to the bottom (last elements of virtual scroll), more data should be loaded via ajax request. On scrolling to the top, previous data should be requested via ajax. I think it's not too much work to rework the infiniteScroll to be able to call (ionInfinite) in both directions. In this case a combination of both components could do the job. (this might be a good workaround for now).
I am willing to spend some time on this issue and hopefully find a solution that works well and might be of use for other people. Any contribution appreciated here ? Do you know who I could talk to about my ideas about changing the infiniteScroll/virtualScroll ?

I have my solution posted on a github repo. Also see here: https://github.com/driftyco/ionic/issues/8037
https://github.com/lujakob/ionic-infinite-scroll-example


APK available?

I see a release, but no way for a non-dev to "get the app". Could you make the (signed) APK available – eg. by attaching it to the release? Thanks in advance!

@IzzySoft The app is currently submitted at GPlay and FDroid. I didn't plan on giving out a signed apk.
Once one or both of the store entries are ready, I will reply here.

@leonlatsch thanks! Of course, if you already submitted it to F-Droid (and our packagers manage to get it into the index in timely manner), there's no need to attach the APK here. I see you submitted it directly via MR (which is why I missed it; I'm rather responsible for RFP, where the Requests For Packaging usually start), and one of our packagers already chimed in – so that shouldn't take too long then.
Thanks again – and sorry for the noise!

@IzzySoft GPlay is now online

Thanks for the pointer! Added to my app list :smiley:

@IzzySoft Thank you, thats nice :)

Guess I'll have to add a new group for gallery apps with a vault (or vaults which act as gallery, depending on the point-of-view). If I do, I'll move your app into that group so it stands out a bit better.

PS: it might take a little longer until your app will be included at F-Droid (not enough packagers to manage the backlog). My offer with the APK in my repo still stands, should you want it there meanwhile :wink:

Thank you, but I can wait. I think its not good to have versions out there, that dont get updated over a standard channel.
Btw: I updated my mr cause for new versions. Is this the right way, or do I have to wait, till 1.0.0 gets packaged, before I can add version 1.0.1 and 1.0.2

Thank you, but I can wait.

OK, your choice of course :wink: And "standard" is a question of definition :smile:

I updated my mr cause for new versions. Is this the right way

Sorry, but I'm lacking context – so I have to guess what you are referring to. Yes, of course you can make new releases without having to wait your RFPs are processed. Metadata set up there are cross-checked by the packager who picks them up – and especially version info is then set to the latest one available. That will be the first packaged. And later on, should your pace of releasing be faster than F-Droid's packaging (happens with some apps, like FairEmail) – well, some interim versions might be skipped then, which should be no problem. Should you need a faster update pace than F-Droid offers (like FairEmail does with its daily releases), my offer stands: this is eg the reason why FairEmail is in both repos.

So the packagers will take care of updating the version, in my case?
Skipping imterim versions is not a problem for me. I just wondered, if the took version 1.0.0 even if 1.0.2 is alrealy released, so I added 1.0.1 and 1.0.2 to the mr.

How would the update process work with your repository. I just dont want old versions of the app laying around without any "standard" way of updating.

so I added 1.0.1 and 1.0.2 to the mr.

Eh, that they will complain about. If it's an MR already, simply adjust it to only have the latest release referenced (avoiding unnecessary builds).

How would the update process work with your repository?

My updater checks for new tags once a day. If found, and there's an APK attached meeting configured criteria¹, it is pulled and placed into my repo. On index build, if the number of available APKs exceeds the configured threshhold (usually 3 APKs – or as many as fit into the limit of 30M, whichever is lower), the oldest APK gets removed. So there are never more than 3 APKs per app. I can limit that further for your app if you want: given the current size of <5M it would be 3 APKs here, but I'd recommend leaving it at the described default.²
¹ some repos have multiple APKs attached; so I can eg configure here to only pick the *-noanalytics.apk – or ignore all (amd64|intel|mips) files.
² given how F-Droid works: users have the index of all apps on their device. So if they choose to install your app shortly after it was updated on the server, they might refer to the "previous version" – so it's a good idea to keep at least one.

I just don't want old versions of the app laying around without any "standard" way of updating.

Nope, neither do I. My repo runs on personal space, not covered by "big fundings". So I have an interest in keeping it "slim" :wink:

Okay, I will change my mr to only have the newest version.
And I will add APK to the releases, so you can add them to your repository.

Thanks!
Depending on your release frequency (and maybe other arguments): Shall I keep it in my repo (daily updates) once it made it to F-Droid.org (approx. weekly updates)? In ~80% of all comparable cases, I remove the app about a week after it got established there. Unless there's demand to keep it. I'm fine with both.

I don't really have a release "schedule". The last 2 updates were hotfixes, for critical bugs and came out the same day. Could take a month till a new release or 2 weeks, so lets see :)

@IzzySoft apks attacked.

I don't really have a release "schedule" …

Yes, of course – no need to make the decision know. We can see to that once your app got published at "F-Droid proper". And you might have your own reasons (unrelated to the release cycle) for keeping the app in my repo or not. As I wrote, I'm fine with either.

apks attached.

Thanks! Processing them now – will be listed with the next sync in about 4 hours; then you can find it here.
Btw: Please check your Fastlane. short_description.txt from de belongs to en-US and vice versa :smile: If you wish, I could also offer you a PR with slightly reformatted fulldesc (optimized to look good on all 3 places: F-Droid, my repo and Play, see here for some explanation; if you want to see results before deciding, check above link in about 4 hours).
Further: No need to duplicate the screenshots from en-US to other languages – en-US is always used as fallback for things not present in other languages. Oh, and you might wish to add that green banner from the readme as fastlane/metadata/android/en-US/featureGraphic.jpg – it even has the exactly right size (1024x500 is what is suggested for featureGraphic).


Code wont run in Python/Console switches to 'Code' instead of 'Python'

When I try to run anything in VSCode, the console immediately switches to 'code' mode and just doesn't look right (it used to work perfectly fine):
[Running] python -u "/Users/hello/Desktop/Python/practice.py"
Hello
[Done] exited with code=0 in 0.045 seconds
I debugged it and it says there was an internal error and to post the traceback here.
I probably pasted too much of the debug code but I wasn't sure where the traceback ends or begins.
import os
import os.path
import sys
import traceback
useCustomPtvsd = sys.argv[1] == '--custom'
ptvsdArgs = sys.argv[:]
ptvsdArgs.pop(1)
Load the debugger package
try:
ptvsd_lib_path = os.path.join(os.path.dirname(file), 'lib', 'python', 'old_ptvsd')
if useCustomPtvsd:
sys.path.append(ptvsd_lib_path)
else:
sys.path.insert(0, ptvsd_lib_path)
try:
import ptvsd
from ptvsd.main import main
ptvsd_loaded = True
except ImportError:
ptvsd_loaded = False
raise
except:
traceback.print_exc()
print('''
Internal error detected. Please copy the above traceback and report at
https://github.com/Microsoft/vscode-python/issues/new
Press Enter to close. . .''')
try:
raw_input()
except NameError:
input()
sys.exit(1)
finally:
if ptvsd_lib_path:
sys.path.remove(ptvsd_lib_path)
main(ptvsdArgs)

It looks like you have the Code Runner extension installed and that's what you're using to execute your Python code. You will either need to report this to Code Runner or disable it so that the Python extension is used instead (you can which you're using as Code Runner's play icon is white while ours is green).

Thank you! I actually figured it out by uninstalling VSCode completely and
reinstalling the extensions one by one to find the problem child. It was
just so odd because I used to be able to run code just fine with it but for
whatever reason it was taking over even when I disabled it. No more Code
runner for me!
On Mon, Nov 4, 2019 at 9:59 AM Brett Cannon<EMAIL_ADDRESS>wrote:

Closed #8351 https://github.com/microsoft/vscode-python/issues/8351.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-python/issues/8351?email_source=notifications&email_token=ANS7HQPEKZQZNYHOVRBLTJTQSBPJRA5CNFSM4JIIGKR2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUUDIDCI#event-2768667017,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANS7HQOGLZ6E4N4H7TQ6FC3QSBPJRANCNFSM4JIIGKRQ
.


Error on linux when running script

Hi,
When I'm running make_account.sh on my centos 7, I receive this error :
/home/creator/ptc-acc-gen/node_modules/nightmare/lib/nightmare.js:106
this.queue((done) => {
^
SyntaxError: Unexpected token >
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/home/creator/ptc-acc-gen/index.js:2:17)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
/home/creator/ptc-acc-gen/PogoPlayer/pogo.js:3
const pogobuf = require("pogobuf");
^^^^^
SyntaxError: Use of const in strict mode.
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:906:3
Find the generated accounts in PogoPlayer/accounts.csv
What should I do ?

Well, I changed my nodejs version to latest. Now i get this :
nightmare queuing process start +0ms
nightmare queueing action "useragent" +4ms
Creating account 5001 of 6000
nightmare queueing action "goto" for https://club.pokemon.com/us/pokemon-trainer-club/sign-up/ +5ms
nightmare queueing action "evaluate" +0ms
nightmare running +1ms
nightmare electron child process exited with code 127: command not found - you may not have electron installed correctly +19ms
nightmare electron child process not started yet, skipping kill. +1ms
I ran npm install again to be sure...

sounds like some of the issues i ran into, you might want to edit makeaccounts.sh and change the DEBUG= to DEBUG=nightmare,electron:* it will give you the reason why it wont run (it needs gtk and a bunch of other packages installed)

Try running the npm install as root user:
sudo npm install
If that fails, try installing that package specifically:
sudo npm install electron

Since this has become an electron problem. please use #24 for further discussion.

@johnkernke running it with DEBUG=nightmare,electron:* made it work in VPS


Live Share very slow; lag time on typing

Issue Type: Bug
This has been replicated with four different people all over the country, and installing the latest VS Code and Live Share extension doesn't help (on both of our ends). It started about 5 days ago.
Steps are (1) someone else creates a live share session and sends me the link, (2) I join.
At first the moving dot (left to right) scrolls for an unusually long time, then when it finally connects to the session I can type but the other person sees it about a minute later. All typing by me either doesn't show up or shows up a minute or more later. I also don't see typing by them.
Extension version: 1.0.3303
VS Code version: Code 1.52.0 (940b5f4bb5fa47866a54529ed759d95d09ee80be, 2020-12-10T22:46:53.673Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
16.00GB (2.33GB free)

Process Argv
-psn_0_1827262 --crash-reporter-id 43abe92c-7633-4a98-bac5-a440c7358e00

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221877
python763:30178808
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30211401
wsl2promptcf:30224613
pythonvsdeb440cf:30233464
unusedprompt:30224610
folderexplorercf:30224615
openfilemenucf:30224648
pythonvsded773cf:30233462
pythonvspyt600cf:30228412

We have the same issue with that version. We workaround this issue downgrading to the previous version.

@xobtoor  Do you mean the version of VS Code or the version of Live Share?

@xobtoor the version of live share sorry for the confusion could be more clear..
Not working Version of Live Share: 1.0.3303
working Version of Live Share: 1.0.3206
Version: 1.52.0
Commit: 940b5f4bb5fa47866a54529ed759d95d09ee80be
Date: 2020-12-10T22:43:50.597Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.9.13-200.fc33.x86_64

Looking into this now... So you're seeing a long time for the file tree to initially load? Followed by edits taking a long time to make it between participants?

Yes, you are describing it accurately. The behavior is a little uneven, so in some cases the file tree loads at normal rate and occasionally edits can be seen right away. I haven't been able to verify that it's not a problem in 1.0.3206 - I tried but it seemed to update itself before I could use it. I would be interested in how to prevent if from updating itself.

Instructions for disabling extension auto-update.
Could you do me a favor and try the following to help isolate where the problem is when you notice that the edits are slow to propagate:
Enable the liveshare.diagnosticMode setting. Then open the Output view (ctrl+shift+u) and select "Visual Studio Live Share Coediting" from the dropdown. Type a character. On the sending end, you should see output like:
[2020-12-10 23:51:25.351 ] Post message: {"messageType":"textChange","changes":[{"length":0,"newText":"a","start":400}],"changeServerVersion":12,"clientId":24,"fileName":"/src/foo.txt","time":1607644285349,"sendId":16}

On the receiving end, you should see output like:
[2020-12-10 23:51:27.713 ] Receive message: {"context":{"GuestSessionId":"31","IsOwner":"False"},"sourceId":"Coauthoring","eventId":45,"jsonContent":"{"messageType":"textChange","changes":[{"length":0,"newText":"a","start":400}],"changeServerVersion":12,"clientId":24,"fileName":"/src/foo.txt","time":1607644427514,"sendId":25}","time":1607644427713}

If there's a big lag between the sending end sending and the receiving end receiving, then it's some issue in our connectivity layer. If that part is happening quickly, it's an issue in how we process the edits and forward them to VS Code.

I attempted this experiment today but the file tree never finished loading, in either the current or previous versions of Live Share. It hasn't actually failed completely like this before. I'll keep experimenting.

@dgh1000 I'm sorry to hear that! That's awful. Could you try sharing with different folders to see if it's potentially related to the folder structure?
The logs (from both host and guest) may also tell us if some exception happened when attempting to load the file tree. You can access your logs via the Live Share: Export Logs command in the command palette (ctrl+shift+p). You can either look through them yourself to see if you spot an exception message or attach them to this issue.

Here are the logs. There seem to be a lot of files, perhaps because I attempted a lot of Live Share sessions over the past few days. I would focus on the Dec 16 files if you want to start somewhere. I looked through them but didn't see anything that looked like a fatal error.
The experiments are a bit slow because I'm depending on other people to be available to live share with me, but I'm going to try this again between two computers at home to see if I can replicate the issue. Then I can do a lot more experimenting.
live-share-2020-12-17.zip

Thank you so much!
By the way, you can also Live Share between two instances of VS Code on the same computer. If this is working fine, it might hint to an issue with the network. Do you and your collaborators generally have a good internet connection?

Live Share works fine between two instances of VS Code on the same computer. It still doesn't work remotely. I verified that on two different networks, a home ISP and a WIFI hotspot on a cellular network- same problem remotely. I'm about to try the experiment to get the logged information from two remote computers.

Okay I had two VS Code windows open on opposite sides of the U.S. with the output window showing Live Share Coediting. When I type on the guest computer no message in the output window shows immediately. About a minute later a message appears in the guest output window and roughly simultaneously a message appears in the host output window.

Thanks so much for gathering that info @dgh1000 ! The messages being delayed showing in the output window on the side that's typing is certainly an issue (and one of the last things I would have expected). I don't have any guesses about what could be causing this... but I can dig around and see if I can come up with anything.
In this case, was the guest the only person to type in the session? Or did the host type something prior?

Hi @daytonellwanger , I don't remember what happened when the guest computer typed.
I tried a clean install of VS Code following the instructions here
https://stackoverflow.com/questions/42603103/how-to-completely-uninstall-vscode-on-mac
And the problem seems to have gone away although I have only tested with one collaborator so far. So I may not be able to help debug this now if the problem is really gone.


Optimize the performance for DictBase #10

#10

1、GetReadOnlyStaticMetadataScript 等逻辑重新遍历了字典，可以放到初始化函数内构建。
2、可以使用 private readonly  static 进行构建，使用 "str".ReadonlyScript() = "xx";
3、CallMangement 目前暂无使用；
4、List 如果没有特殊情况可以使用 HashSet 代替，以便 Continas 操作;

We can analyze the performance improvement of RuntimeProxyType cache in CallerManagement. What needs attention here is the consumption of concurrent dictionary in retrieval.

It seems that the closed PR cannot be traced to subsequent cimmit records. Is is a pity.

It seems that the closed PR cannot be traced to subsequent cimmit records. Is is a pity.

I found that the closed PR can still be traced to subsequent cimmits records. I'll reopen this PR...

[x] 1、GetReadOnlyStaticMetadataScript 等逻辑重新遍历了字典，可以放到初始化函数内构建。
[x] 2、可以使用 private readonly static 进行构建，使用 "str".ReadonlyScript() = "xx";
[ ] 3、CallMangement 目前暂无使用；
[x]  4、List 如果没有特殊情况可以使用 HashSet 代替，以便 Continas 操作;

About the 3rd point. What is the purpose of CallMangement? If the RuntimeProxyType is cached in it, will the performance consumption of TryGetRuntimeType be greater than rebuilding a new RuntimeProxyType?


Announcement:  RealSense 400 Series firmware 5.12.5 now available for download

Hi everyone,
RealSense 400 Series firmware 5.12.5 is now available as an individual download on the firmware release page.
https://dev.intelrealsense.com/docs/firmware-releases
FIXES

10 FPS not supported on Depth / IR 848x480 when connected through USB2
Frames stop arriving after few frames in Color / Depth stream due to unexpected halt on Windows 10 RS4
Sending HW_reset immediately after stop streaming causes the camera to boot into invalid state
Fails USB enumeration during PC restart
IR Frames stop arriving after several camera start / stop

SPECIFICATION CHANGES
Development Firmware <IP_ADDRESS> provides single frame triggering feature called External Synchronization (GenLock) for D43x global shutter only cameras.
The release also includes support for 256x144 @ 300FPS and 848x100 @ 300FPS formats for D43x cameras.

This release appears to have bugs that affect at least the D415 cameras. Since the Sunday release my camera has been taken out. I can no longer reflash, hardware reset or any other remediation to make the camera functional again. Errors include:
/dev/video5 is no device Last Error: Resource temporarily unavailable
xioctl(UVCIOC_CTRL_QUERY) failed Last Error: Invalid or incomplete multibyte or wide character
uvcvideo: Failed to query (GET_CUR) UVC control 1 on unit 3: -32 (exp. 1024)
I am running in Ubuntu 18.04. Also tried a brand new D415 and it's useless with the new drivers or flash image. I have tried every remediation ever mentioned in github issue history, mailing lists, etc but no success.

Hi @enclarify   I sincerely apologise for all the trouble that you have had and have referred your problem to a RealSense team member with knowledge of this situation so that they can provide a response.

Hi @enclarify Could you please send an email to<EMAIL_ADDRESS>about this case? Let's resolve this through email. Sorry for the inconvenience! And appreciate your cooperation!

Hi @enclarify Could you please send an email to<EMAIL_ADDRESS>about this case? Let's resolve this through email. Sorry for the inconvenience! And appreciate your cooperation!

Hi, I did sent a message to that support address but haven't gotten a response. I used the email address I purchased with, not the one I use on GitHub.
Even switching to the USB backend doesn't solve my issues. I have been able to flash the camera (with lots of errors) and any time I try to change a settings I get errors.

I will highlight your message about not receiving a response to the appropriate Intel staff.

Nothing in spam

@enclarify   Okay, thank you very much for checking.  Your message has been passed on.   Your patience is appreciated!

Hello,
I double checked the email box; I did find the email you mentioned. Anyway, I got this email now, let’s go from here.
I apologize for the inconvenience!
At first 15 minutes of v2.35.0 was posted, the FW was a wrong version. So I believed you downloaded it during this time.
15 minutes later, our development team pulled it back and uploaded a correct version.
Unfortunately, the camera cannot be recovered at your side. Please provide your shipping address, I will send a new D435i to you.
Please provide the following info. These are required by Intel shipping department.
Name
Address
Email
Phone number
I will also provide our FedEx account to you. Please ship the bricked camera back to me using this account.
Sorry again for the trouble!
Thank you very much for using RealSense camera!
Appreciate your understanding!
Thanks,
Intel Corporation
Kevin Zhao
From: enclarify<EMAIL_ADDRESS>Sent: Tuesday, June 9, 2020 12:45 AM
To: IntelRealSense/librealsense<EMAIL_ADDRESS>Cc: sys_support<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [IntelRealSense/librealsense] Announcement: RealSense 400 Series firmware 5.12.5 now available for download (#6505)
Hi, I did sent a message to that support address but haven't gotten a response. I used the email address I purchased with, not the one I use on GitHub.
Even switching to the USB backend doesn't solve my issues. I have been able to flash the camera (with lots of errors) and any time I try to change a settings I get errors.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/IntelRealSense/librealsense/issues/6505#issuecomment-641098692, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APG5O3376U53HOQQWUEWTKLRVXSA3ANCNFSM4NRKQFXQ.

@MartyG-RealSense I am still having issues and it's been about a week since I have gotten a response from sys_support. Any chance you can see if they can check their support queue?

@RealSenseSupport will have seen your new comment now that you have posted it.


Correction to section title.

Update
FROM
"To create a Scale-Out File Server role by using Server Manager"
TO
"To create a Scale-Out File Server role by using Failover Cluster Manager"

@robinharwood, @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

If this is for deploy S2D, the S2D team would be the right people to notify.
From: Courtney Wales @.>
Sent: Tuesday, January 16, 2024 7:13 AM
To: MicrosoftDocs/windowsserverdocs @.>
Cc: Steven Ekren @.>; Assign @.>
Subject: Re: [MicrosoftDocs/windowsserverdocs] Correction to section title. (PR #7678)
@robinharwoodhttps://github.com/robinharwood, @Xelu86https://github.com/Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-teamhttps://github.com/orgs/MicrosoftDocs/teams/public-repo-pr-review-team

Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windowsserverdocs/pull/7678#issuecomment-1893946350, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFM6TS7G2ATFMWQFO726K4LYO2KHVAVCNFSM6AAAAABB33FATCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTHE2DMMZVGA.
You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>

Looks good to me, merging now.


Unable to create a new session on a new Docker version (API 1.39)

Version <IP_ADDRESS>-beta1-mac75 (27117)
Docker API: 1.39
Engine: 18.09.0-ce-beta1
Compose: 1.22.0
Channel: edge
OS: Mac OS High Sierra 10.13.5
Selenoid: 1.7.2
browsers.json
{
	"chrome": {
		"default": "68.0",
		"versions": {
			"68.0": {
				"image": "selenoid/vnc:chrome_68.0",
				"port": "4444"
			}
		}
	}
}

docker-compose.yml
version: '3.6'
services:
  selenoid:
    image: "aerokube/selenoid:latest-release"
    ports:
      - "4444:4444"
    volumes:
      - "$PWD:/etc/selenoid"
      - "//var/run/docker.sock:/var/run/docker.sock"
    command: ["-conf", "/etc/selenoid/browsers.json", "-container-network", "docker_automation"]
    networks:
      - automation
  selenoid-ui:
    image: "aerokube/selenoid-ui:latest-release"
    depends_on:
      - selenoid
    ports:
      - "8080:8080"
    command: ["--selenoid-uri", "http://selenoid:4444"]
    networks:
      - automation
networks:
  automation:
    driver: bridge

Step: navigate to any URL via Selenium API
Expected: browser is opened and redirected to specified URL.


Problem: build with cython < 0.29 fails

Solution: add backward compatibility for language_level and set it to 2
if cython doesn't support 3str

@minrk ping

For better consistency of installation, can we make the minimum Cython 0.29 instead?

There are LTS platforms supported for years to come with older versions, which is how I found out - Debian 8, Debian 9, CentOS 7, Fedora 29, SUSE 42, Ubuntu 16.04, Ubuntu 18.04. Upping the requirement would mean cutting them all off.

Those platforms wouldn't expect new feature releases of pyzmq, would they? Shouldn't their package lists be frozen long ago?
Note that pyzmq releases include Cython-generated sources, so installing a release of pyzmq on all those platforms will work fine without Cython at all. Cython is only a development requirement.

Up to you - given those are LTSes I thought users could be trying to build from sources. I'll disable the builds we do on OBS for those releases.

Updated to require 0.29 on Python >= 3.7 and set 3str if possible, leaving the fallback on Cython's default behavior for old versions of Cython, which is what we were doing before.
Building from official releases doesn't require Cython at all, so I'm not worried about folks having issues installing pyzmq on LTS.

Thanks!


Add Conventional Commits check to GitHub Actions

As a developer I want to check that contributors follows convention of commits naming in the repository. We should add Conventional Commits check to the CI. Here is a good linter for this purpose written in python which supports pre-commit integration as well: commitizen
DOD:

[ ] Added commit messages check step in CI

It seems to be easier to install this free app
https://github.com/marketplace/semantic-pull-requests

@thinklab it's not maintained anymore, I would be against using it. Let's take a look at some of the alternatives like this Action - https://github.com/amannn/action-semantic-pull-request ?

@MysterionRise
Amazing, would you prepare PR?


feat(ci): add earthfile for voices fronted

Prepare Catalyst Voices Web for deployment.
Unblocks https://github.com/input-output-hk/catalyst-world/issues/183

FYI @jmgilman we will extract flutter install and config into catalyst-ci in another task.


EP-251 : Page Viewed (manage_pledge)

📲 What
Android: Page Viewed (manage_pledge)
🤔 Why
Segment Implementation
🛠 How

Created new method trackManagePledgePageViewed in AnalyticEvents class

 /**
     * Sends data associated with page view event to the client.
     *
     * @param pledgeData: The selected pledge data.
     */
    fun trackManagePledgePageViewed(pledgeData: PledgeData) {
        val props: HashMap<String, Any> = hashMapOf(CONTEXT_PAGE.contextName to MANAGE_PLEDGE.contextName)
        props.putAll(AnalyticEventsUtils.pledgeDataProperties(pledgeData, client.loggedInUser()))
        client.track(PAGE_VIEWED.eventName, props)
    }

Called method on BackingFragment page expanded

  projectDataAndBackedReward
                    .compose(takeWhen<Pair<ProjectData, Reward>, Void>(this.nativeProjectActionButtonClicked))
                    .filter { ObjectUtils.isNotNull(it) }
                    .filter { it.first.project().isLive && it.first.project().isBacking }
                    .map { pledgeData(it.second, it.first, PledgeFlowContext.MANAGE_REWARD) }
                    .compose(bindToLifecycle())
                    .subscribe(this.lake::trackManagePledgePageViewed)

👀 See

Before 🐛
After 🦋

📋 QA

On the profile page, select from the list of backed projects.
Click on the manage button. You should see the new event registered on the segment console

Story 📖
https://kickstarter.atlassian.net/browse/EP-251

Add tests to check the analytic event has been triggered, ProjectViewModelTest holds all the unit tests for this ViewModel

Done

This has been closed and the ticket moved to TO-DO until further information is provided


gffread command line error

The gffread command line in process convertGFFtoGTF is not correct
gffread $gff -T -o > ${gff.baseName}.gtf
should be
gffread $gff -T -o ${gff.baseName}.gtf

Fixed in #136, will be in the next stable release


RPC call on client hangs even with deadline when the service is not reachable or not running

What version of gRPC and what language are you using?
C++, gRPC version: commit 5d57a8d (tag: v1.13.0)
What operating system (Linux, Windows,...) and version?
Linux, Ubuntu 16.04.6 LTS
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc version: 7.3.0
What did you do?
Simple test to see if set_deadline() is working fine for gRPC clients when a gRPC service is NOT reachable or when the service is not running at all. See the code below.
#include <grpc++/grpc++.h>
#include <gtest/gtest.h>
#include "foo.grpc.pb.h"

/**
// foo.proto
syntax = "proto3";
package foo;

message HelloReply { string message = 1; }
message HelloRequest { string name = 1; }
service Greeter {
  rpc SayHello(HelloRequest) returns (HelloReply) {}
}
*/
TEST(GrpcTest, DeadLine) {
  // no service is running at this address
  auto greeter_stub = foo::Greeter::NewStub(CreateChannel("bogus.com:12121",
                                  grpc::InsecureChannelCredentials()));
  grpc::ClientContext hello_ctxt;
  // set a deadline of 1 second
  hello_ctxt.set_deadline(std::chrono::system_clock::now() + std::chrono::seconds(1));
  foo::HelloRequest hello_req;
  hello_req.set_name("Foo");
  foo::HelloReply hello_rep;
  auto  start = std::chrono::system_clock::now();
  greeter_stub->SayHello(&hello_ctxt, hello_req, &hello_rep);
  // should not this return in about 1 second?
  auto dur = std::chrono::duration_cast<std::chrono::seconds>
                    (std::chrono::system_clock::now() - start);
  EXPECT_LT(dur.count(), 2);
}

GTEST_API_ int main(int argc, char** argv) {
  testing::InitGoogleTest(&argc, argv);
  return RUN_ALL_TESTS();
}

What did you expect to see?
The RPC should return after the deadline expires, if the service is not reachable or not running.
What did you see instead?
The RPC hangs, making the above test timed out.
Anything else we should know about your project / environment?
We use bazel to build our c++ code inside a docker instance running Linux (Ubuntu 16.04.6 LTS)

Interestingly the RPC returns after the deadline expires if the service endpoint address is a unix domain socket. Replace the following line in the above code sample
auto greeter_stub =
      foo::Greeter::NewStub(CreateChannel("bogus.com:12121",
      grpc::InsecureChannelCredentials()));

with
auto greeter_stub = // this address too does not exist
      foo::Greeter::NewStub(CreateChannel("unix:/bogus_addr",
      grpc::InsecureChannelCredentials()));

and the RPC returns immediately after the deadline of 1 seconds expires.

I'll try to take a look at this next week.

@markdroth did you get a chance to look at this? Thanks!

can @markdroth or someone look at this once place? Thank you!

I'm fairly sure this has been fixed.  Please try with a recent version and gRPC.  If you're still having a problem, let us know, and we can reopen this.

https://groups.google.com/g/grpc-io/c/ly-JwdzS1EM Kindly see this discussion, don't think it is fixed in recent versions.

That discussion thread does not seem to be talking about the same thing as this issue.  This issue was about a client RPC not terminating at its deadline, whereas the discussion thread is talking about a problem with shutting down gRPC globally.

If you have code that can reproduce the problem being discussed in this thread with a recent version of gRPC, please post the code, and I will reopen the issue.


[tailwind] How do we have to manage colors, radius, etc.

Related to discussion

https://github.com/locokit/locokit/pull/222#discussion_r1157320361
https://github.com/locokit/locokit/pull/222#discussion_r1157321894

And according to https://tailwindcss.com/docs/customizing-colors#using-custom-colors
I think we should name our colors not as a "locokit" (lck) one, but with a "functional" look.
As primary, secondary seems ok, we should use an object notation to have light and dark shades.
  primary: {
    DEFAULT: 'var(--primary-color)',
    lighten: 'var(--primary-color-lighten)',
    light: 'var(--primary-color-light)',
    dark: 'var(--primary-color-dark)',
    darken: ...
  }

For the lck color, I don't know exactly how to handle it, but the lck word doesn't seem (to me) the best way to describe the color.
We use the CSS var text-color, so for me, this is the default text color.
Maybe default means something better than lck. Or main. Beware, DEFAULT can be a key used in an object notation for colors, but means nothing (as far as I know) for a default text color.
For border radius, as we only have one for now, I think I prefer name the radius DEFAULT, overriding the default border radius value when using the rounded css class.
borderRadius: {
  DEFAULT: 'var(--border-radius)',
},

[ ] use object notation for light, dark, ... shades
[ ] rename lck color as default or main
[ ] use DEFAULT for border radius default value through rounded css class

@Alketta , your thoughts are welcome.


update Readme file

add the instructions for setting up the env file

Can you assign this issue to me?

I understand that this issue was already resolved but I have elaborated on how to setup the .env file much better, could you just check it once?

I understand that this issue was already resolved but I have elaborated on how to setup the .env file much better, could you just check it once?

Yeah but that is not needed for contributors they just need to copy paste the template that's enough and all the libraries are already imported in settings.py so there is no work for contributors

okay got it.


GSE128243 - nktpbmcZhou

Primary Wrangler:
Enrique
Secondary Wrangler:
Marion

Associated files:
Google Drive: https://drive.google.com/drive/folders/14-OUakV7yCQExJAtNn9VN7u-xazWOoEz
Published study links
Paper: https://www.frontiersin.org/articles/10.3389/fcell.2020.00384/full#F1
Accessioned data: https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GSE128243
Key Events

[x] convert published metadata to HCA spreadsheet
[x] manually curate dataset to meet HCA metadata standard
[x] Upload sheet to validate metadata
[x] Check linking using ingest graph validator
[x] Transfer files to ingest to validate data files
[x] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[x] Submit dataset to Production

Metadata is in the google drive folder and s3 bucket is indicated in a google document in the same folder

Ingest-graph-validator tool tests were run successfully

Did some extra research and the graph seems valid: 3 donors, each 2 specimens, each specimen a cell suspension and each cell suspension links to 3 files

Data files are valid in ingest: https://ui.ingest.archive.data.humancellatlas.org/submissions/detail?uuid=8d045afd-cebf-4b3f-80df-a06d751a3413&project=2a32d3e2-1cfb-4c15-90bc-689102b1b638

@mshadbolt has agreed to be the secondary wrangler

UPDATE:

I just noticed the cell suspension is missing the selected_cell_types (Natural killer cells), will add them after the review

Ami Secondary review:
Edited version: https://docs.google.com/spreadsheets/d/1VovZyygCNPI87doP3G0GgcZPdxI_B4Ix/edit#gid=1885177057
Project

The insdc project and study accessions need to be swapped

Contributors

The primary wrangler name is surname,,firstname (Sapena Ventura,,Enrique). It should be firstname,,surname
There is no primary contact email address. I suggest we search for  the first author's email when this happens.
The address was given in full in the department column, it needs to be split into the multiple columns.

Collection protocol

I changed the description to "A blood draw was performed on the donors at Henry Ford hospital" as the wording was not quite right.

Specimen from organism

Some of the "specimen_from_organism.biomaterial_core.biomaterial_name" values were switched around (some say "stimulated" as opposed to "unstimulated" according to the 'specimen_from_organism.biomaterial_core.biomaterial_id" and "specimen_from_organism.biomaterial_core.description"
The first "specimen_from_organism.biomaterial_core.ncbi_taxon_id" says '9605' instead of '9606'

Cell suspension

Compared to the 'specimen from organism' tab, the "unstimulated" samples are listed before the "stimulated" samples. This is not a problem, but it might be worth double checking that associated sample information was not accidentally swapped (e.g. if you pasted any information from the 'specimen from organism' tab.
I suggest copying the "cell_suspension.biomaterial_core.biomaterial_name" values to the "cell_suspension.biomaterial_core.description" column too

Other than that, looks good!

Thanks for the review Ami!

I have added the email that appears in GEO and added that as a corresponding contributor
I have looked at your corrections and applied them!

I think it's good to go!

Dataset is ready for export. Closing the ticket!

@ESapenaVentura I have moved this to Finished on the Wrangling board as I believe the DCP journey is complete. Please, feel free to amend if I did not get it right. Thanks!


fix: don't attempt to determine if a typedef is referenced locally

The isTypedef check was added to resolve errors with local @typedef's that are only referenced in JSDoc comments. While it's simple to check if the var has a @typedef annotation, determining if the type is referenced in the file is much more involved than the current regex can handle. We could simply check for the variable name in comments, but that would likely lead to false positives (matching names containing the var name, matching outside of a @type or @param, etc).
It seems acceptable to simply ignore if the var is a @typedef and leave the usage on the developer. That will avoid unwanted errors, with the small cost of allowing extraneous typedef's in a file.

:tada: This PR is included in version 2.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Upgrade pnpm to 9

upgrade pnpm 9 in:

in dockerfile instead of 8.5.1
set package.json engines >= 9

look into .npmrc if that can be used to set pnpm version in project?

https://github.com/pnpm/pnpm/issues/7934
tried using packageManager, corepack with pnpm but did not succeed.


Reloading libs loaded using {'serie': true} "consumes" files list

Check this plnkr: http://plnkr.co/edit/oRj4EggNZLgfOQxASawi?p=preview
Look at the console output when navigating via "go to other" and "go to index". After the first navigation, you will notice that module.files has become empty. It appears that ocLazyLoad when used with the serie:true config option consumes the file list instead of cloning it for internal use.
This has created issues for us with ocLazyLoad trying to reload empty/undefined files.

Oh you're right, thanks for the debug!

Happy to help! It's a great library!
On Wed, Apr 8, 2015 at 11:18 PM, Olivier Combe<EMAIL_ADDRESS>wrote:

Oh you're right, thanks for the debug!
—
Reply to this email directly or view it on GitHub
https://github.com/ocombe/ocLazyLoad/issues/160#issuecomment-91039784.

Fixed! :)

Thanks, will check it out :+1:

There is no new release yet since I'll be making more commits tonight

This bug is still present. I get 'File type could not be determined. undefined' when accessing UI state that is previously loaded.

Are you sure it's the same problem ?

When I load UI router state first time, everything is ok, but when I access it second time it throws 'File type could not be determined. undefined'. This is probably because all required files are loaded and ocLazyLoad tries to load empty list. Everything works, it just throws error in console (when debug: true) is set.

How is this closed??


enhance the Testing chart by split into 2 charts

ryan in this diff change the chart from line chart to area chart
https://github.com/xunhuang/covid-19/commit/b7605e098bccf17558725f0c6cc3c6fe0a64b7fa#diff-45d3a396111b8926a195807e0451c2a4
User feedback is mixed as the testing chart is trying answer two questions:

Are states doing enough testing  (The previous line chart)
How are the testing results  ( this current stacked area graph).

Let restore the old chart and keep the new one. So when people click Testing,

there will be a switch (AntSwitch) it will show chart #1
when you check on the switch,  it will show chart 2.

this way user can toggle between the charts.

@lym953 can you please help with this one? Thanks!


enhancement = add option to save/record  http errors.

  I'm using this library in conjunction with ohttpstubs

Was using the SWHttpTrafficRecorder recorder to audit the traffic - while it may seem not worthwhile - I've since added a new stub to reflect error codes returned from server.
let notConnectedError = NSError(domain:NSURLErrorDomain, code:62), userInfo:["NSLocalizedDescription":"Error getting Trip"] )
return OHHTTPStubsResponse(error:notConnectedError)

maybe  something like this
struct APIError {
private static let domain = "com.yourdomain.app"
static let BadRequest = NSError(domain: domain, code: 400, userInfo: ["NSLocalizedDescription":"Bad Request"])
static let Unauthorized = NSError(domain: domain, code: 401, userInfo: ["NSLocalizedDescription":"Unauthorized Request"])
static let NotFound = NSError(domain: domain, code: 404, userInfo: ["NSLocalizedDescription":"Data Not Found"])
static let RateLimitExceeded = NSError(domain: domain, code: 429, userInfo: ["NSLocalizedDescription":"Rate Limit Exceeded"])
static let NoResponse = NSError(domain: domain, code: 444, userInfo: ["NSLocalizedDescription":"No Response"])
static let InternalServerError = NSError(domain: domain, code: 500, userInfo: ["NSLocalizedDescription":"Internal Server Error"])
static let ServiceUnavailable = NSError(domain: domain, code: 503, userInfo: ["NSLocalizedDescription":"Service Unavailable"])
static let Unknown = NSError(domain: domain, code: 520, userInfo: ["NSLocalizedDescription":"Unknown Error"])
static let ErrorGettingTrip = NSError(domain: domain, code: 62, userInfo: ["NSLocalizedDescription":"Error getting Trip"])
static func FromCode(code: Int) -> NSError {
    switch(code) {
    case 400:
        return BadRequest
    case 401:
        return Unauthorized
    case 404:
        return NotFound
    case 429:
        return RateLimitExceeded
    case 444:
        return NoResponse
    case 500:
        return InternalServerError
    case 503:
        return ServiceUnavailable
    default:
        return Unknown
    }
}

}


Theme appears to be broken on latest Insiders build

On the latest Insiders build (1.11.0-insider, commit 01091bb), the theme seems to only change some colors. I've been using it successfully for several weeks up until it broke a few (?) days ago.
For reference, here are two screenshots comparing the default theme and Nord:

Thanks for your report 👍
Well, since the Insiders version is a development build things may break everytime 😉
There are issues like Microsoft/vscode #22463 and Microsoft/vscode #22361 about this behavior which are already fiexed in 56bbea94 and 0e5b61e8.
I've done a small research through the commits and it seems like they are implementing a whole new theming API which uses JSON as theme format instead of tmTheme (color scheme validation).
I think this is the preparation to provide a way to style the whole VS Code UI like the workbench sidebar, status bar and other UI elements which are currently not styleable via themes.

This appears to be fixed in latest Insiders commits.


Flag expanded variants containing ambiguous calls.

Also optionally filter out particular calls sets.
For more background on the purpose of this pipeline, see https://github.com/googlegenomics/codelabs/tree/master/Java/PlatinumGenomes-variant-transformation

Looks good and useful! I have a few minor comments. Once you feel you addressed them, feel free to merge (or we can go for another round if you prefer).

Thanks @jean-philippe-martin for the good feedback.  All those items are fixed now.


Temporary rake task to remove invalid country codes

https://trello.com/c/qe4L5zdM/262-fix-the-underlying-data-problem-for-50-dfid-documents-small
Dfid transition data contains a number of country codes which are prohibited by
the document schema, so remove the offending codes and update the documents.
This task can be removed once it has been run in production, the admin UI will prevent further updates
from adding invalid codes.
Run it like:
bundle exec rake dfid_research_outputs:cleanup_country_codes INVALID_COUNTRY_CODES_FILEPATH=tmp/invalid_country_codes.csv

Produces output like:
ContentItem 'df2ca14d-8a4c-46ce-89f1-03f2c7e6a64e' updated with countries: ["BD", "GH"]
ContentItem 'cf78b2f1-9c3e-4f88-adfd-09e235a900d5' updated with countries: ["IN", "KE", "TZ", "GA"]
ContentItem 'af82e0ed-be9d-45c0-b3c3-cad9bbc226a2' updated with countries: ["AU"]
ContentItem '5cfe113f-9d29-48a3-a1a7-501712fc46d6' updated with countries: []
ContentItem '54921d4f-9494-4b86-8c28-1a99678be7e0' updated with countries: ["TZ", "SC", "FJ", "VU", "MU", "KM"]

This problem is thought to affect 47 documents so it's not gonna choke the publishing api, the trello card contains a CSV file of invalid data and information on how this CSV was generated.

Tested locally. Merging.


feat: convert to ts

Hey @krishguptadev there is some issue while deployment-
Failed to compile.
10:35:32 | ./src/pages/api/create-checkout-session.ts:5:16
10:35:32 | Type error: Value of type 'typeof Stripe' is not callable. Did you mean to include 'new'?
10:35:32 | 3 | import stripelib from "stripe";
10:35:32 | 4 |
10:35:32 | > 5 | const stripe = stripelib(process.env.STRIPE_SECRET_KEY)
10:35:32 | |                ^
10:35:32 | 6 |
10:35:32 | 7 | const handler = async (req, res) => {
10:35:32 | 8 |   const { items, email, name } = req.body;
10:35:32 | error Command failed with exit code 1.
10:35:32 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hey @krishguptadev the build is failing because of this-

@avneesh0612 There are some errors in the index.tsx file. I don't know react much. Can you help?

@krishguptadev can u delete the worker folder?


[@radix-ui/react-dropdown-menu] lack of "dir" prop in Content

[X] Use a meaningful title for the pull request. Include the name of the package modified.
[X] Test the change in your own code.
[ ] Include the URL where we can test the change in the body of your PR.

This pull request:

[ ] Fixes a bug
[ ] Adds additional features/functionality
[X] Updates documentation or example code
[ ] Other

@Luccasoli Thanks for contributing. The dir "prop" is a HTML attribute though.
We only document custom props because all of our components support applicable HTML attributes which would be a lot to document as individual line items. I've been meaning to update the docs to clear this up as it isn't obvious that we support these (or all of React's built in Synthetic Events) unless using TypeScript.
I'll close this for now and create a Github Issue to remind us to make this all a bit clearer because the solution described above would require some design input.


revert: Set domain firmware UUID based on namespace & name

What this PR does
The original change may break users when starting an old VM. When starting with the new generated UUID, most likely the machine UUID will change which in turn may place the guest in an unexpected state.
There is a need to distinguish old and new VMs in order to provide a backward compatible fix.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
A new fix should be posted that considers old stopped VMs.
For now, it would be safer to revert the fix changes and re-open the issue.

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note
NONE

@brianmcarey regarding pull-kubevirt-build - IIRC error 125 is related to failing spawning new processes.
I've seen that a bit more recently: https://search.ci.kubevirt.io/?search=Error+125&maxAge=336h&context=1&type=build-log&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

Also I've observed this timeout on waiting for Podman socket a bit more recently: https://search.ci.kubevirt.io/?search=Reached+maximum+attempts%2C+not+waiting+any+longer&maxAge=336h&context=1&type=build-log&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

Was this bug ever addressed in a different way?


No binaries created

After running the make file I don't see any binaries in the client folder or an .lv2 plugin.

Ah ok I just realised some stuff in the config failed.
-- Looking for C++ include pthread.h -- Looking for C++ include pthread.h - found -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE   -- The C compiler identification is GNU 7.4.0 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Looking for include file x86intrin.h -- Looking for include file x86intrin.h - found -- Looking for include file intrin.h -- Looking for include file intrin.h - not found
Any suggestions?

Your building on Windows I'm guessing?

Linux Mint 19.3

Have you built other repositories? This seems like a GCC error, not Sfizz.
(There is nothing specific to Sfizz in the log)

Hi!
The build and documentation is still a bit in flux, so sorry for the rough edges. In order to check what is happening could you first check that you are on the develop branch and post the full cmake output? You could do something like
mkdir build && cd build
../scripts/release_gcc.sh

I am doing this blind as I have no computer at hand though so check the syntax for the scripts 😅

intrin.h is indeed the win equivalent of x86intrin.h and it should not stop the build. If none of them are found you will just not have the hand-optimized SSE routines but they are not needed.

The output from release_gcc.sh is below. I'm not on the develop branch though, I just cloned the master. I'll try the develop branch now.
sfizz/build$ ../scripts/release_gcc.sh
Cmake flags:
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- Failed to find LLVM FileCheck
-- Found Git: /usr/bin/git (found version "2.17.1")
-- git Version: v1.5.0
-- Version: 1.5.0
-- Performing Test HAVE_CXX_FLAG_STD_CXX11
-- Performing Test HAVE_CXX_FLAG_STD_CXX11 - Success
-- Performing Test HAVE_CXX_FLAG_WALL
-- Performing Test HAVE_CXX_FLAG_WALL - Success
-- Performing Test HAVE_CXX_FLAG_WEXTRA
-- Performing Test HAVE_CXX_FLAG_WEXTRA - Success
-- Performing Test HAVE_CXX_FLAG_WSHADOW
-- Performing Test HAVE_CXX_FLAG_WSHADOW - Success
-- Performing Test HAVE_CXX_FLAG_WERROR
-- Performing Test HAVE_CXX_FLAG_WERROR - Success
-- Performing Test HAVE_CXX_FLAG_PEDANTIC
-- Performing Test HAVE_CXX_FLAG_PEDANTIC - Success
-- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS
-- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS - Success
-- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32
-- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32 - Failed
-- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING
-- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING - Success
-- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS
-- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS - Success
-- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED
-- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED - Success
-- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING
-- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING - Success
-- Performing Test HAVE_CXX_FLAG_WD654
-- Performing Test HAVE_CXX_FLAG_WD654 - Failed
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY - Failed
-- Performing Test HAVE_CXX_FLAG_COVERAGE
-- Performing Test HAVE_CXX_FLAG_COVERAGE - Success
-- Performing Test HAVE_STD_REGEX
-- Performing Test HAVE_STD_REGEX
-- Performing Test HAVE_STD_REGEX -- success
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Performing Test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- success
-- Performing Test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Looking for include file arm_neon.h
-- Looking for include file arm_neon.h - not found
-- Configuring done
You have changed variables that require your cache to be deleted.
Configure will be re-run and you may have to reset some variables.
The following variables have changed:
CMAKE_CXX_COMPILER= g++
CMAKE_CXX_COMPILER= g++
CMAKE_C_COMPILER= gcc
CMAKE_CXX_COMPILER= g++
CMAKE_C_COMPILER= gcc
CMAKE_CXX_COMPILER= g++
CMAKE_C_COMPILER= gcc
CMAKE_CXX_COMPILER= g++
CMAKE_CXX_COMPILER= g++
CMAKE_C_COMPILER= gcc
CMAKE_CXX_COMPILER= g++

-- The CXX compiler identification is GNU 7.4.0
-- Check for working CXX compiler: /usr/bin/g++
-- Check for working CXX compiler: /usr/bin/g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Cmake flags:
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- The C compiler identification is GNU 7.4.0
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for include file x86intrin.h
-- Looking for include file x86intrin.h - found
-- Looking for include file intrin.h
-- Looking for include file intrin.h - not found
-- Configuring done
-- Generating done
-- Build files have been written to: /home/dave/Downloads/sfizz/build

Ok I built the develop branch and now I get the binaries. The LV2 plugin uses a generic GUI, when I load it in Carla I don't see anywhere to select the SFZ file, in Ardour it works fine. Is this an issue I should direct to the Carla developer?

Carla has this ability but only on the develop branch last time I tried. If you build carla-develop you should have access to the file parameter by clicking on the gear icon on the plugin UI in the rack. You can also use jalv.gtk3 to create a UI with the file chooser.

Thanks I'll check it out

@davidhealey if this has been resolved, please close the issue.


Integrate EPA Crosswalk into PUDL

Context:
We did an initial integration with a WIP version of the EPA crosswalk in issue #822. Now that the full version has been released, we can fully integrate it into PUDL.
Current integration is in:

src/pudl/glue/eia_epacems.py
bypassed in src/pudl/output/epacems.py
run in src/pudl/etl.py:_add_eia_epacems_crosswalk

Steps:

[ ] Include raw source download in pudl-scrapers, including checking for new releases
[ ] Include in Zenodo archive / Docker images, remove from package resources csv
[ ] Update processing currently in pudl/glue/eia_epacems.py, paying particular attention to which columns should be used as IDs (see next item)
[ ] Implement pudl/transform/epacems.py:harmonize_eia_epa_orispl. This may have been done by the EPA already, see EPA docs, particularly the column MOD_EIA_PLANT_ID
[ ] Add crosswalk to PUDL db and CEMS output table

Questions:

Should these glue files live in their own glue directory (as they currently do) or should they get extracted and transformed like the rest of the data that gets integrated into the PUDL db?

Should probably consolidate with #843

@TrentonBush was far more involved in this original work than I was, so for technical questions as to how to use this crosswalk information and integrate it with other data I think he's the main resource.
This is somewhere between being a new dataset, and being "glue" but I think we want to treat it more like a dataset -- there's a raw input from the EPA repo (that will be available in the datastore) and we need to perform some operations on it before it's ready to be loaded into the PUDL DB. We'll have FK relationships between that new table and the EPA CEMS / EIA tables.
However, because the EPA CEMS doesn't get loaded into the DB, those FK relationships won't be checked automatically. Somehow we need to ensure that they're all valid. I imagine this will happen somewhere in the crosswalk ETL process, but I don't know what the direction of the dependencies is.
In the fullness of time, I could see it making sense to defer the crosswalk ETL until after the main DB and the EPA CEMS data have been processed, and then with access to both of those (interim) outputs, generate and load our version of the crosswalk into the DB. But that's something that won't happen until we've got the DAG set up.


release: 4.0.0

This PR is to generate a new release of code-server at 4.0.0.
Screenshot
TODO @jsjoeio
TODOs
Since this is a major release with breaking changes, we need to take extra steps to test it.
How to Test

Wait for CI to finish.
Download artifcat: release-packages
Untar locally:

# Linux
cd release-packages && tar -xzf code-server*-linux-amd64.tar.gz
# macOS
cd release-packages && tar -xzf code-server*-macos-amd64.tar.gz

Run locally:

# Linux
./code-server*-linux-amd64.tar.gz./code-server
#macOS
./code-server*-macos-amd64.tar.gz/code-server

Before Release

[ ] prep release notes @jsjoeio
[x] attach artifacts to release @jsjoeio
[x] built-in extensions @jsjoeio
[x] install extension @jsjoeio
[x] terminal @bpmct
[x] display language @jsjoeio
[x] debugging @code-asher
[x] pwa @bpmct
[x] make sure all the various routes all work (/, /vscode, /vscode/) @code-asher
[x] heartbeat @code-asher
[x] double-check reverse proxy (although this should be good) @jsjoeio
[x] double-check assets are properly cached @code-asher
[x] vs code cli commands like install-extension work @bpmct
[x] double-check the web sockets are including the type query param @code-asher
[x] github auth (actually did we ever add this back?) @jsjoeio
[x] fix plugin tests @code-asher

After Release

[ ] publish release and merge PR
[ ] update the AUR package

Fixes #4176

It appears we have lost our patch for changing the display language. Opened an issue to track: https://github.com/cdr/code-server/issues/4598

GitHub Auth works!
How I tested:

Install GitHub Pull Requests and Issues Extension
Sign in using PAT
Create PR

bugs found:

code-server [foldername] or code-server -r [foldername] does not work to open a folder. strangely, it works fine with files
popular extensions are not recommended if user has 0 extensions installed (3.12.0 seemed to unfold this tab)

Everything else works great. Tested on OSX

code-server [foldername] or code-server -r [foldername] does not work to open a folder. strangely, it works fine with files

Great catch by @bpmct! @code-asher fixed this in https://github.com/cdr/code-server/pull/4599

popular extensions are not recommended if user has 0 extensions installed (3.12.0 seemed to unfold this tab)

Tracking here: https://github.com/cdr/code-server/issues/4600


Upgrade grommet-site dependencies

[] yarn upgrade --latest
[] upgrade corresponding code for breaking changes
[] Ensure https://github.com/grommet/grommet-site/security/dependabot is clear

offline-plugin isn't working with webpack 5 and offline-plugin dev has been stale for at least 2 years.
The issue is basically this
So should we replace offline-plugin with something being maintained and newer like https://developers.google.com/web/tools/workbox/modules/workbox-webpack-plugin?
Migration info seems to be here
Or another option might be to use a fork that fixes offline-plugin but it seems like migrating to workbox-webpack-plugin might be a better path forward.

I lean towards moving towards the future.


Can't run single test file with spring: true set

For some reason extra tests are being run whenever spring: true is set.
With guard:

12:42:49 - INFO - Running: test/models/user_test.rb
Run options: --seed 25521

# Running:

.....................................................................................................

Finished in 8.738868s, 11.5576 runs/s, 23.6873 assertions/s.

101 runs, 207 assertions, 0 failures, 0 errors, 0 skips

Directly:
bin/rake test TEST=test/models/user_test.rb
Run options: --seed 21314

# Running:

................................

Finished in 2.014514s, 15.8847 runs/s, 27.7983 assertions/s.

32 runs, 56 assertions, 0 failures, 0 errors, 0 skips

Sorry some digging has traced this back to some local changes to the rake test task.

@chrisnicola I haven't made any local changes to the test rake task but I do have the same issue. Could you please share what you've done to make it work as expected?

I can't recall, but I believe we had customized the task to run some extra test folders and there was a mistake.

@richardvenneman did you ever resolve your problem?  I'm having the same issue as well.

@gshaw - run guard with the -d option: bundle exec guard -d. Guard should intercept the Kernel.system command and show what exactly it's running.
Then, the next step would be to run that exact command outside Guard.

@e2, I did.  When you run with spring: true guard is running with bin/rails rake and passing all the test paths separated only by whitespace.  E.g,
When spring: true
bin/rake test test/models/setting_test.rb test/models/user_test.rb

When spring: false it uses a completely different command line:
bundle exec ruby -I"test" -I"spec" -r bundler/setup -r minitest/autorun -r ./test/models/setting_test.rb -r ./test/models/user_test.rb -e "" --

If only one file is passed when spring: true it actually works but if multiple files are passed all the tests are executed.  You can duplicate both scenarios on the command line outside of Guard.
The problem is that I'm not sure how to pass multiple tests to bin/rake test to take advantage of running them under spring.

@gshaw - I'm not a minitest user (too frustrating in my experience), but I might have a few hints:

You can duplicate both scenarios on the command line outside of Guard.

Then it isn't a Guard::Minitest issue. Not until the problem is understood in a way where Guard::Minitest can help.

bin/rake test test/models/setting_test.rb test/models/user_test.rb

I believe it should go something like this: bin/rake test TEST='test/models/setting_test.rb test/models/user_test.rb' as suggested here:
https://github.com/rails/rails/blob/4-2-stable/railties/lib/rails/test_unit/sub_test_task.rb#L20
(Though I'm not sure how minitest handles ENV['TEST'] with multiple files).
So it's running all the tests because you're not setting the TEST environment variable.
It's just that minitest expects environment variables, not arguments, e.g. TESTOPTS= should be recognized as well.
I'm also not sure about how forking plays here. With forking environment variables are usually that of the original process (e.g. spring in this case), unless they're set manually somewhere.
Add some puts statements in the railties sources files to see what's being passed and how it's handled.

If it's a bug in how bin/rake is called, I can make a quick fix-and-release if I know what to change.

OK, it took a bit of looking but the problem I believe is how Rails 5 is favoring bin/rails test instead of bin/rake test.  I can solve the problem with the current version of guard-mintiest by using this in my Guardfile.
guard "minitest", spring: "bin/rails test" do
  ...
end

It might be a good idea to check for Rails 5 and use by default bin/rails test instead of bin/rake test but I'm not sure of a good way to do that inside the guard-mintiest gem.

@gshaw - that makes sense, since Rake uses/handles arguments differently.
Rails should already be activated as a gem, so detection is possible - Guard pretty much tries to use bundler if possible. Though minitest autoloads plugins through rubygems - so that would take testing.
So testing for Rails in activated gems could be enough. Another idea is the new Rails 5 API - lots has changed on the testing side, so it's possible to just reference classes/methods new in Rails 5 (e.g. railties related to testing).
Does the TEST= variable work for multiple files? If so, then maybe just the command-line can be changed, so that spring+rake to compose the TEST= parameter?

The TEST= variable does work for multiple files.  I have everything working well with Rails 5 and latest guard and spring after I explicitly passed in the command to use spring: "bin/rails test".
At least for now adding a conditional to https://github.com/guard/guard-minitest/blob/master/lib/guard/minitest/runner.rb#L166 to check if Rails 5 is activated and if so use bin/rails test instead of bin/rake test would be enough.
I'd save the deeper integration with the Rails 5 API at least until the final version is out and then only if there is a real need for the extra coupling.

I think a better patch is to not be Rails-5 "aware", but to actually compose the TEST= parameter, e.g. replacing: https://github.com/guard/guard-minitest/blob/2db91fb/lib/guard/minitest/runner.rb#L173
with:
cmd_parts + "TEST='#{paths.join(' ')}'"

though I'm not sure if that will be passed down properly.

Just want to second @e2's suggestion. I'm stuck on an older version of Rails and having this exact problem, with spring turned on it's not possible to run only one test.