[Bug] DNS does not work on non-Clash networks.

Verify Steps

[X] Tracker 我已经在 Issue Tracker 中找过我要提出的问题
[X] Latest 我已经使用最新 Dev 版本测试过，问题依旧存在
[X] Core 这是 OpenClash 存在的问题，并非我所使用的 Clash 或 Meta 等内核的特定问题
[X] Meaningful 我提交的不是无意义的 催促更新或修复 请求

OpenClash Version
v0.45.119-beta
Bug on Environment
Official OpenWrt
Bug on Platform
Linux-arm64
To Reproduce
Two LANs on one device
One proxied, one not (via white/black lists)
OpenClash installed (doesn't matter if running or not)
Describe the Bug
The proxied network works fine with OpenClash
The non-proxied network cannot use DNS, even with Clash disabled.
This issue was worse in v112, it was partially resolved and now dnsmasq runs, but DNS still doesn't work
OpenClash Log
No log issues
OpenClash Config
No response
Expected Behavior
DNS works
Screenshots
No response

Check the dnsmasq option, and show me the contents of the file

Check the dnsmasq option, and show me the contents of the file

这个忽略解析文件应不应该勾选呢？

Check the dnsmasq option, and show me the contents of the file

`# Interface proxy
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
Interface wan
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
Interface wan_6
nameserver 2409:801e:2000::1
nameserver 2409:801e:2000::2`
There is another interface called 'lan' which isn't here.


Handle multiple inputs with the same label

When I upgraded from lettuce-webdriver to aloe-webdriver, some of my tests which use the Django admin started failing because there were multiple fields with the same label. Normally that would be fine, but it was a little hard to debug because the offending extra form is not visible.
It just so happened that I only hit the error on pages with inline forms where more than one related model could be created. In this case, Django hides an extra form in the page HTML so that it can create new forms on the fly for adding extra related models. These (hidden) forms have fields with the same label as the (only) visible form, and so the tests started failing because aloe-webdriver was finding multiple fields with the same label.
I'm not sure this is exactly a bug, but maybe aloe-webdriver could emulate lettuce-webdriver here and pick the first matching item (I'm assuming that's the lettuce-webdriver behaviour), or maybe find_field could ignore non-visible elements by default.

Does #12 solve your problem?

Fixed in #12, please comment if this is still an issue.


Implement the control panel buttons and switches into the nodelink

The control panel currently has no utility currently. It need to allow users to show/hide whatever they want, resize elements, etc.

Add a switch for link forces


Upgraded mongodb to 2.2.25

Upgraded to the latest mongodb since the currently used one is deprecated.

npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to 2.2.19 or higher

@rainy-kpe tnx for the submit, did you manage to test if it works ok?

We're using the document versions feature in a project and at least it seems to be working with the new mongodb version. Unfortunately I'm not able to verify if the other features work too.

@rainy-kpe ok thank you, it helps :-)


Add Leetcode Solutions of Linked List Problems.

Under the Linked List Folder create a folder named "LeetCode_Problems" and for each question, there will be different folders with questions in the  README file.
Add important questions that are asked by FAANG and other startup companies.
comment under this issue to get assigned.

I would like to work on this issue! @aritra-tech


Vid 122 add meta data to bids

Type of change

[ ] Bugfix
[x] Feature
[ ] New bidder adapter
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?
[ ] Other

Description of change
Update Yieldmo bid adapter to add meta data to bids

LGTM


Client Allocation Request for: monkdharma

Client Allocation Questions
Core Information

Name: monkdharma
Website / Social Media:
Region: Greater China
DataCap Requested: 50TiB
Addresses to be Notarized: f1oi265jelqmmzvku6g2po2yl6lsauyyorciqahei
Notary Requested: Joss-Hua

@monkdharma Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hi @monkdharma, different from 1TiB request, please leave more information here.

Company Duration of establishment, Number of employees, Business scope and products or services.

Social media link (Weibo, WeChat, Douyin, Zhihu, Facebook, Twitter, Linkedin, e.g.).

Data size to be stored.

Have you already applied for DataCap to another notary, and whether it is accepted or rejected? Is there any reliable DataCap left.

Would you like to accept our face-to-face visit.

Hello friend, I would like to know about your question, whether I can apply for datacap quota personally

yeap, Filecoin Plus also welcomes individual applications, but you need to explain the source and type of data, and which SPs are your choice. It needs rationality for individuals.
Since you sent all the 1TiB datacap to the same SP last time, you need to pay more attention to the rules of Filecoin Plus.

README.md

My name is: Monk Dharma
My position is: Linux system engineer
My side job is as a training instructor, and the type of data I want to store is the teaching videos I record when I teach online.
Example:
https://youtu.be/DpjTPxE21b0
https://youtu.be/N1rSAhplnIU
Videos are mine and mostly private
It's stored on external hard drives, servers, and it's scheduled to be uploaded to YouTube.
I plan to find 4 SPs to trade in Europe and US

Could you adjust the request volume to 10TiB? so that I can process this application. If everything complies with the rules, I will be happy to support the next request.
Remind again, please understand the rules of FIL+, including the basic requirements for client and sp. Good Luck.

ok how do i adjust and should i re-launch the application

I modified this application to be 10TiB

hello, is there anything else i can do? When will the new quota be allocated to me?

I can't find it in the to-sign list. Maybe there are some problems with the notary dapp. I'm waiting for a reply from the governance team.

OK, thanks


LIME-1055 adding mockTxmaResources value as true to deploy script

Proposed changes
What changed
Setting the value to true.
Why did it change
So that we see the TXMA events in sqs.
Issue tracking

LIME-1055

I have raised an almost identical PR here https://github.com/govuk-one-login/ipv-cri-common-lambdas/pull/299/files we chose to only add to the deploy-branch workflow because we only needed the stacks for pre-marge checks.
Do Lime need them for post merge too?

I have raised an almost identical PR here https://github.com/govuk-one-login/ipv-cri-common-lambdas/pull/299/files we chose to only add to the deploy-branch workflow because we only needed the stacks for pre-marge checks.
Do Lime need them for post merge too?

Just spotted this PR sitting here, this change to the deploy.sh would be needed for deploying dev stacks of the common-cri-api with the mocks in place. We then manually configure the template to redirect to a local stub for testing.


petfinderAPI4everybody is not defined

I'm stymied on this one - this is on localhost, so I can't show you the code, but this is basically it:
I'm including the .js file in the :

And I've tried two different ways to init the code. First way:
jQuery(document).ready(function(){

petfinderAPI4everybody.init({
		key: 'MYAPICODEHERE', // Your API key with Petfinder
		shelterID: 'CA764', // Your Petfinder shelter ID
		templates: {
			// The layout for the page that displays all pets
			allPets:
				'
' +
					'
' +
						'' +
					'
' +
					'
{{name}}
' +
					'
View Full Profile
' +
					'
' +
				'
',
			onePet: null, // The layout for individual pet profiles [optional]
			asideAllPets: null, // The layout for secondary content on the "All Pets" page [optional]
			asideOnePet: null, // The layout for secondary content on individual pet pages [optional]
		}
	});

});

And the second way, which was the petfinderAPI4everybody.init just down in the footer, right before the closing  tag.
Either way I do it, I'm still getting 'petfinderAPI4everybody is not defined'. I've confirmed that the .JS file is loading and that the contents are there. Any ideas what is up?

The global object you want to use for init() and all the other functions is petfinderAPI:
petfinderAPI.init({
		key: 'MYAPICODEHERE', // Your API key with Petfinder
		shelterID: 'CA764', // Your Petfinder shelter ID
		templates: {
			// The layout for the page that displays all pets
			allPets:
				'
' +
					'
' +
						'' +
					'
' +
					'
{{name}}
' +
					'
View Full Profile
' +
					'
' +
				'
',
			onePet: null, // The layout for individual pet profiles [optional]
			asideAllPets: null, // The layout for secondary content on the "All Pets" page [optional]
			asideOnePet: null, // The layout for secondary content on individual pet pages [optional]
		}
	});

});

You need to update your documentation on this site, then, because all I did was literally copy+paste what was on this page: https://github.com/cferdinandi/petfinderAPI4everybody

Doh, good catch!

Updated docs


[Bug]: v4.27.0 fails to deploy to netlify with non-zero exit code 3

Summary
When deploying to Netlify on the recently updated version of this plugin, I encounter the following error:
Deploy failed due to an error in @netlify/plugin-nextjs plugin.
Plugin "@netlify/plugin-nextjs" internal error
Could not import plugin:
Error: Cannot find module 'next/dist/build/analysis/extract-const-value'
Require stack:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>While loading "@netlify/plugin-nextjs" from Netlify app at Function.Module._resolveFilename (node:internal/modules/cjs/loader:985:15) at Function.Module._load (node:internal/modules/cjs/loader:833:27) at Module.require (node:internal/modules/cjs/loader:1057:19) at require (node:internal/modules/cjs/helpers:103:18) at Object. (/opt/build/repo/.netlify/plugins/node_modules/@netlify/plugin-nextjs/lib/helpers/analysis.js:28:31) at Module._compile (node:internal/modules/cjs/loader:1155:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10) at Module.load (node:internal/modules/cjs/loader:1033:32) at Function.Module._load (node:internal/modules/cjs/loader:868:12) at Module.require (node:internal/modules/cjs/loader:1057:19)
Error properties: { code: 'MODULE_NOT_FOUND' }

I had deployed the same commit only 30 minutes prior (before this version was updated), so I am assuming it is related to the new version 4.27.0.
Steps to reproduce

Open a pull request on github (this was already open as a draft and was already deployed to a deploy preview branch).
Push a new commit to this branch.
The automatic deploy fails due to the above error.

A link to a reproduction repository
No response
Next Runtime version
4.27.0
More information about your build

[ ] I am building using the CLI
[ ] I am building using file-based configuration (netlify.toml)

What OS are you using?
No response
Your netlify.toml file

`netlify.toml`
# Paste content of your `netlify.toml` file here

Your public/_redirects file

`_redirects`
# Paste content of your `_redirects` file here

Your next.config.js file

`next.config.js`
# Paste content of your `next.config.js` file here. Check there is no private info in there.

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
# Paste logs here

.next JSON files

generated .next JSON files
# Paste file contents here. Please check there isn't any private info in them
# You can either build locally, or download the deploy from Netlify by clicking the arrow next to the deploy time.

I think this is related to https://github.com/netlify/next-runtime/issues/1690


Check fluency of all Predicates

This particular issue has been fixed, but there may be others. See #175
langzhaozhi commented on Mar 27 ->
Hi, ask you a simple question. In Idea IDE the code :
ReactiveSeq.of(1,2,3).filter(anyOf(not(in(2,3,4)),in(1,10,20)));
same can be compiled and there are no errors report, but when i build code in gradle, it can not be compiled! The compile error message is it can not infer type. It is very strange.
In order to compile code, I have to write code like following:
Predicate<? super Integer> inOne = in(2,3,4);
Predicate<? super Integer> inTwo = in(1,10,20);
ReactiveSeq.of(1,2,3).filter(anyOf(not(inOne),inTwo));
The above code is not fluent.

Merged - https://github.com/aol/cyclops-react/pull/248


Added a proper cheat menu

Previously, pressing Ctrl + Shift + F10 would add 1K of each mined resource.
Now, it brings up a simple window with a text box. You can type various codes for various effects.

Cheat Code
Effect

"goldrush"
Add 1000 of each resource

"orderpizza"
Fill your colony's food storage

"waveofbabies"
Add ten children to the population

"savedbythebell"
Add ten students to the population

"gettowork"
Add ten workers to the population

"smartypants"
Add ten scientists to the population

"electronicoldmen"
Add ten retired colonists to the population

"beepboop"
Add a RoboDigger, RoboMiner, and RoboDozer to the robot pool

Note that this PR was branched off of #1224 to allow it to actually build. Please merge #1224 before merging this!

One issue I'm seeing is that if I press the WASD keys when entering cheat codes, the main window camera moves.

One issue I'm seeing is that if I press the WASD keys when entering cheat codes, the main window camera moves.

This can be addressed by using a bit of a kludge in the onKeyDown() handler starting on line 377: https://github.com/Inglonias/OPHD/blob/hackerman/OPHD/States/MapViewState.cpp#L377
Can add a check via Control::hasFocus(). Since you'd probably just want to filter by the movement keys vs other keys, you could add something along the lines of:
if(mCheatWindow.visible() && mCheatWindow.hasFocus()) { break; }

Not the greatest code ever but does the job

So I looked closer into this and the problem is actually in the way the textfield's and MapViewState interact with each other and how textinput mode is being set. I'm working on a separate fix that will address this. I would disregard the suggestion of the hacky method mentioned above.
I'm going to implement that as a different change set so that this will just work without needing additional change. Will be reviewing this changeset shortlyl

Okay, so far this looks pretty good. A few minor changes requested:

There should be two lines between function/class/namespace blocks vs one.
I'd suggest putting the CheatMenu enum class into the unnamed namespace in the source file unless you think future plans would have this be used elsewhere in the code
The window should be centered when it's shown

After these changes I think this will be good to merge

The enum is used elsewhere in the code - In the MapViewStateUi.cpp file. I can't move it to the source file without breaking things. Or if I can, I don't have enough knowledge of C++ to do it "correctly", whatever that means.

I have made all other suggested changes.

Looks good to me! Going to go ahead and merge this into main.


chore: improve workspace clean

Description

Problem*

Resolves
Summary*

Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

In what situation are the nodejs and web directories not writable by the user?

when copied over from nix build which was running in isolation


[composer] ability to select editor section of stack

[x] ENTER should focus the text editor text.
[x] Pressing DOWN at the end of the document should NOT navigate to the next section (similar for UP).
[ ] Need more x padding inside of blue selection box. (better to highlight entire section box, not just editor)?

Pressing DOWN at the end of the document should NOT navigate to the next section (similar for UP).

why not? doesn't that seem counter to what we're trying to do with collections?

too hard to deal with x-padding for now, given that you can navigate to-from the rail as well


Support cross compilation with ARM

I recently tried to install gatewayd on a raspberry pi and realized that our packages don't currently support compilation to ARM. Hopefully isn't too hard to get working since we already support Android which is ARM.

In particular, this was regarding the debian packaging correct @m1sterc001guy?

I tried and failed to build https://github.com/fedimint/fedimint/pull/2110 on m1:
justin@justins-laptop fedimint % nix bundle --bundler github:NixOS/bundlers#toDEB .#gatewayd

warning: Using saved setting for 'extra-substituters = https://fedimint.cachix.org' from ~/.local/share/nix/trusted-settings.json.
warning: Using saved setting for 'extra-trusted-public-keys = fedimint.cachix.org-1:FpJJjy1iPVlvyv4OMiN5y9+/arFLPcnZhZVVCHCDYTs=' from ~/.local/share/nix/trusted-settings.json.
error: builder for '/nix/store/maqq77bl9ich1wni8nkvr57ig6nlq9kj-deb-single-gatewayd-bin-gatewayd.drv' failed with exit code 1;
       last 10 log lines:
       > Alas, could not find an ar that can handle -D option. Try installing recent gnu binutils. Aborting. {:level=>:error}
       > Traceback (most recent call last):
       > 	7: from /nix/store/jha3x9769rqy3xmz1q9h7prg79fd97mb-fpm-1.13.1/bin/fpm:20:in `<main>'
       > 	6: from /nix/store/jha3x9769rqy3xmz1q9h7prg79fd97mb-fpm-1.13.1/bin/fpm:20:in `load'
       > 	5: from /nix/store/fzdw68dhpgnv7b4kxigksbrmp8afy5gn-fpm-1.13.1/lib/ruby/gems/2.7.0/gems/fpm-1.13.1/bin/fpm:7:in `<top (required)>'
       > 	4: from /nix/store/psv0v0cdzn5hgkdi1khl7nz5za5v7lnf-ruby2.7.4-clamp-1.0.1/lib/ruby/gems/2.7.0/gems/clamp-1.0.1/lib/clamp/command.rb:133:in `run'
       > 	3: from /nix/store/fqkfy12q45nimxiw6mipidi89axvvm7h-ruby2.7.4-fpm-1.13.1/lib/ruby/gems/2.7.0/gems/fpm-1.13.1/lib/fpm/command.rb:574:in `run'
       > 	2: from /nix/store/psv0v0cdzn5hgkdi1khl7nz5za5v7lnf-ruby2.7.4-clamp-1.0.1/lib/ruby/gems/2.7.0/gems/clamp-1.0.1/lib/clamp/command.rb:68:in `run'
       > 	1: from /nix/store/fqkfy12q45nimxiw6mipidi89axvvm7h-ruby2.7.4-fpm-1.13.1/lib/ruby/gems/2.7.0/gems/fpm-1.13.1/lib/fpm/command.rb:487:in `execute'
       > /nix/store/fqkfy12q45nimxiw6mipidi89axvvm7h-ruby2.7.4-fpm-1.13.1/lib/ruby/gems/2.7.0/gems/fpm-1.13.1/lib/fpm/package/deb.rb:462:in `output': gatewayd-bin-gatewayd: ar is insufficient to support source_date_epoch. (RuntimeError)
       For full logs, run 'nix log /nix/store/maqq77bl9ich1wni8nkvr57ig6nlq9kj-deb-single-gatewayd-bin-gatewayd.drv'

Tried running it again on m1, and still getting the Try installing recent gnu binutils warning. Tried replacing pkgs.llvmPackages.bintools with binutils in the flake buildInputs but same error.
The ar is insufficient to support source_date_epoch part of the error in particular might be a clue.

What exactly did you run? I thought cross-compilation to different targets was working on your machine already?

nix bundle --bundler github:NixOS/bundlers#toDEB .#gatewayd

Probably not worth a trouble right now to investigate, but just leaving some context.
.#gatewayd is a native output, so this would need to go through a remote builder or something. But with a remote builder I think it should work on macos (because it actually builds on remote Linux)
Only the .#cross.<target>.<name> outputs use a (our custom) cross-compilation system, so these might work now.
O wonder if nix bundle --bundler github:NixOS/bundlers#toDEB .#cross.<target>.<name>, but I'm not even sure what it would mean. It would probably package cross-compiled binaries in a deb that is meant to be installed on Linux ...

There seems to be a hacky solution: https://github.com/NixOS/bundlers/issues/8#issuecomment-1512638576
But currently we only have cross targets for client packages (whatever that means exactly), so we'd need to first cross-compile all FM binaries to the targets we want to package for (I guess mostly armhf for Raspberry Pis).

Would be nice, but doesn't seem like a priority and it's been in a backlog for more than a year.


[MPLUGIN-525] Remove ant and beanshell support

[MPLUGIN-523] Switch to version 4.0.0-SNAPSHOT
[MPLUGIN-525] Remove ant and beanshell support

Is this Maven 4 only?

Is this Maven 4 only?

Yes, I've created a 3.x branch to support Maven 3 plugins and master will support Maven 4 plugins. The goal is to split the plugins to ease maintenance, as the code will ultimately be quite different.  See https://issues.apache.org/jira/browse/MPLUGIN-523. We should also drop the Maven 4.x support from the 3.x branch.

Is this Maven 4 only?

Yes, I've created a 3.x branch to support Maven 3 plugins and master will support Maven 4 plugins. The goal is to split the plugins to ease maintenance, as the code will ultimately be quite different. See https://issues.apache.org/jira/browse/MPLUGIN-523. We should also drop the Maven 4.x support from the 3.x branch.

I see. There is no way to have this in one branch with common modules and module per Maven version?


Bot doesn't rejoin channels upon disconnecting and reconnecting

It only rejoins the active/home channels.

Fixed in 83ec26d60e56f62bb7fe379d22914f0e6ac97e23.


ENH: stats: add nan_policy' argument for stats.rankdata`

Reference issue
fix #11790
What does this implement/fix?
I added nan_policy' argument for stats.rankdata` based on A Design Specification for nan_policy and its test.

I addressed your comments. PTAL.

@AtsushiSakai would you be interested in reviving this? I don't think the decorator will work here because rankdata is not a reduction operation.

OK. I will try it again.

I would benefit a lot from adding this feature to handle nan - thank you!!


Fix error message:

Overview

Adds missing space
Refactor for clarity

See: https://jira.bf.local/browse/ECR-XYZ
Definition of Done

[x] There are no TODOs left in the code
[x] Changelog is updated if needed (in case of notable or breaking changes)
[x] The continuous integration build passes

Coverage decreased (-0.02%) to 85.684% when pulling 0f3e48f68dacd6d69621972eee2a367e8fd31f33 on dmitry-timofeev:fix-time-service-2 into b1bedb7b2319a5e97af28f30b6903fca24653bbf on exonum:master.


Add support for AWS Redshift

Fixed by https://github.com/infracost/infracost/pull/587

I'm going to take a crack at this.

Thanks @tim775!

Looking at the aws pricing page and the terraform registry it seems like I can add pricing for aws_redshift_cluster resource.  There are also prices for 'spectrum', 'concurrency scaling', 'managed storage', and 'ML' but I don't see any way to map those to a terraform resource.

@tim775 aws_redshift_cluster would be great, "Backup storage" also seems hard to include given that it talks about anything above the cluster size is charged S3 rates (which we have as a supported resource).
I know it's too late for this ticket but we've started putting more details in tickets to make it easier for contributors, e.g. https://github.com/infracost/infracost/issues/574.

Here's what I've found from a quick look:

Spectrum - the AWS calculator allows this to be calculated by entering "Data scanned", so I think we can add a usage-based cost component with name Spectrum data scanned and key monthly_spectrum_data_scanned_gb.
Concurrency scaling - from what I can tell this is enabled by default, but looks difficult to model. The AWS calculator doesn't include this so I would leave it out.
Managed storage - Seems like this is charged if node_type ~= ra3.*.
ML - doesn't seem to be supported by Terraform.

Ok I think that makes sense to me (for now anyway :)).
So the "main" cost component would look something like:
		{ 			Name:           fmt.Sprintf("Redshift Cluster (%s)", nodeType), 			Unit:           "hours", 			UnitMultiplier: 1, 			HourlyQuantity: decimalPtr(decimal.NewFromInt(numberOfNodes)), 			ProductFilter: &schema.ProductFilter{ 				VendorName:    strPtr("aws"), 				Region:        strPtr(region), 				... 				AttributeFilters: []*schema.AttributeFilter{ 					{Key: "nodeType", Value: strPtr(nodeType)}, 				}, 			}, 			PriceFilter: &schema.PriceFilter{ 				PurchaseOption: strPtr("on_demand"), 			}, 		},
then there would be an additional use cost component for spectrum like:
			{ 				Name:            "Spectrum data scanned", 				Unit:            "terabytes scanned", 				UnitMultiplier:  1, 				MonthlyQuantity: <from u.Get("monthly_spectrum_data_scanned_gb")>                                  ... 			}
then conditionaly another cost component for managed storage when nodeType is ra3.*
			{ 				Name:            "Managed storage", 				Unit:            "GB-month", 				UnitMultiplier:  1, 				MonthlyQuantity: <from u.Get("monthly_storage_gb")> // I haven't looked for naming convetions yet                                  ... 			}

So for "Concurrency scaling" it looks like the cost is equal to the hourly rate of the cluster billed at 1 second granularity (after you go over some limit).  Assuming there's no explicit price for concurrency scaling in the json, we could make a usage cost component based on the cluster price:
	Name:            "Excess concurrency scaling",
	Unit:            "seconds",
	UnitMultiplier:  1/3600,
	MonthlyQuantity: <from u.Get("monthly_excess_concurrency_scaling_seconds")>,
	ProductFilter: <same as nodeType>
	PriceFilter: <same as nodeType>
        ...
}```

But i'm not sure if deriving an price from another price is a sound thing to do.  Would that be ok or is the rule "If aws doesn't publish a price in the json, we don't put it in infracost"?

But i'm not sure if deriving an price from another price is a sound thing to do.  Would that be ok or is the rule "If aws doesn't publish a price in the json, we don't put it in infracost"?

We don't have a hard rule on this, not sure it has come up before. Just had a quick look at this and I see there are specific listed prices for the Concurrency Scaling in the Pricing API, using the following MongoDB query:
db.products.find({ vendorName: 'aws', service: 'AmazonRedshift', productFamily: 'Redshift Concurrency Scaling' }).pretty()

Released in v0.8.5


Fix issue with install and upgrade running all hooks

When #8156 was merged it had the side effect that all hooks were
run all the time. All the hooks were put in the flow of the
content rendered and sent to Kubernetes on every command.
For example, if you ran the following 2 commands the test hooks
would run:
helm create foo
helm install foo ./foo

This should not run any hooks. But, the generated test hook is run.
The change in this commit moves the writing of the hooks to output
or disk back into the template command rather than in a private
function within the actions. This is where it was for v3.2.
One side effect is that post renderers will not work on hooks. This
was the case in v3.2. Since this bug is blocking the release of v3.3.0
it is being rolled back. A refactor effort is underway for this section
of code. post renderer for hooks should be added back as part of that
work. Since post renderer hooks did not make it into a release it
is ok to roll it back for now.
There is code in the cmd/helm package that has been duplicated from
pkg/action. This is a temporary measure to fix the immediate bug
with plans to correct the situation as part of a refactor
of renderResources.
What this PR does / why we need it:
It fixes a release blocking bug to v3.3.0. v3.3.0-rc.1 currently runs all hooks on all commands (e.g., helm install).
Special notes for your reviewer:
@technosophos and I discussed this. He's volunteered to refactor this section of code for v3.4. If he doesn't, I will. There are mixes of concerns and some other bugs (e.g., post renderers don't work when helm template writes to an output directory). The other bugs are not regressions and were there in v3.2 so they are not release blockers.

I have started on a refactor of the renderResources function, but it is probably weeks out at least (given our PR velocity).

I have started on a refactor of the renderResources function, but it is probably weeks out at least (given our PR velocity).

Let me know when you have something ready. renderResources is an absolute mess and I'd love to see any effort to clean up that part of the codebase.


Update formplayer load balancing config for enikshay and cas endpoints

We had noticed this during the enikshay migration.
The endpoint this PR updates for enikshay is enikshay.commcarehq.org, and for icds is cas.commcarehq.org, and it only affects formplayer's use of these endpoints. I'm not sure what formplayer hits these endpoints for, but previously the load balancing it was using on softlayer was just a simple least connection load balancing. Is that a problem for formplayer? Wasn't sure if formplayer requests should consistently go to one machine because of the restore db. Note that this does not affect the normal site (enikshay.in / icds-cas.gov.in)
If so, then this PR will update it so that it uses a hash of the session id for load balancing rather than the least connection method, consistent with what we do for the main formplayer endpoint for enikshay.in / icds-cas.gov.in here
Or, should we remove the formplayer site config for the enikshay.commcarehq.org and cas.commcarehq.org endpoints entirely if it's not used at all? Admitting I don't know enough about formplayer to say what's right here and just raising this as an inconsistency we should figure out.
@dannyroberts @wspride @emord @snopoke @ctsims

See also 864c584c8e37b9dec17a47c128b6109e065c73ce in PR #935

ah, yeah looks like the same exact change is in #935. closing this pr.
i think it's still work thinking through:

if we need these endpoints for formplayer, and if not we should remove them
if we do need these endpoints for formplayer, based on how formplayer uses these endpoints, is there a session id available for hashing to make this work?

@gcapalbo we do need these for formplayer. The loadbalancer is using a cookie value for the routing which is the django session ID.


Upgrade to Karma 6

Codecov Report

Merging #228 (a013f6d) into master (2e2b822) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   90.98%   90.97%   -0.01%
==========================================
  Files         117      117
  Lines        2517     2515       -2
  Branches      468      469       +1
==========================================
- Hits         2290     2288       -2
  Misses        225      225
  Partials        2        2

Impacted Files
Coverage Δ

src/pages/PolicyDetail/IsEnabled.tsx
100.00% <0.00%> (ø)

src/components/Policy/AddTriggersDropdown.tsx
100.00% <0.00%> (ø)

Codecov Report

Merging #228 (a013f6d) into master (2e2b822) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   90.98%   90.97%   -0.01%
==========================================
  Files         117      117
  Lines        2517     2515       -2
  Branches      468      469       +1
==========================================
- Hits         2290     2288       -2
  Misses        225      225
  Partials        2        2

Impacted Files
Coverage Δ

src/pages/PolicyDetail/IsEnabled.tsx
100.00% <0.00%> (ø)

src/components/Policy/AddTriggersDropdown.tsx
100.00% <0.00%> (ø)


Fix M0 e2e tests failure

Proposed changes

atlas_clusters_m0_e2e is failing on evergreen. This PR fixes the issue.
Checklist

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[x] I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
[x] I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
[x] I have run make fmt and formatted my code

Further comments

this may require a better fix than anew env

@gssbzn I have initially tried to set --mdbVersion in the create command but it is not available for M0.
We could updatee2eMDBVer to 5.0 instead of creating a new env. I don't see other options. Am I missing something? Thanks!

the best thing to do would be to use default version endpoint so we don't need to manually update this all the time
https://github.com/mongodb/go-client-mongodb-atlas/blob/master/mongodbatlas/default_mongodb_major_version.go

@gssbzn Are we okay with adding a new hidden command to call this private endpoint? os should I call the endpoint with server request in the helper_test.go?

are we okay with adding a new hidden command to call this private endpoint? os should I call the endpoint with a server request in the helper_test.go?

Which ever approach you think is the best


Update a11y language

Tiny update to improve this article so it doesn't seem like we're giving legal advice.

I'm not sure what a wf_blink_components field would be for?


BUG: modin numpy errors in a weird corner case of eq and ne

Modin version checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest released version of Modin.

[X] I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example
import modin.numpy as np
import numpy
a = numpy.zeros(shape=(2, 2))
b = numpy.zeros(shape=(3, 2))
a == b # False, with DeprecationWarning: elementwise comparison failed; this will raise an error in the future.
a != b # True
np.array(a) == np.array(b) # ValueError: operands could not be broadcast together with shapes (2, 2) (3, 2)
np.array(a) != np.array(b) # ValueError: operands could not be broadcast together with shapes (2, 2) (3, 2)

Issue Description
In the above example, the arrays passed to == and != cannot be broadcast together. In numpy, this will return False for equality and True for inequality (a well-formed comparison would return a boolean array of elementwise comparisons), but our current implementation chooses to error out instead.
Notably, the same behavior is not present in other binary operators (>=, <=, etc.). It is unlikely that we need to fix this bug; I'm filing it mostly to give a tracking issue for an xfailed error case test.
Expected Behavior
Modin should match numpy's behavior, though in this case the behavior of numpy is somewhat counterintuitive.
Error Logs

Replace this line with the error backtrace (if applicable).


Fix grammar

Fixed a broken sentence

Thank you for your contribution!  It's a good way to contribute to Hacktoberfest 😎


Fmri hot fix

I add a simple fix. I replaced np.float by float.
I did not run the notebooks so diff should only display that change.

I have included the changes except for the np.float ones in the allen-hot-fix PR. Are those necessary?

Hi @iamzoltan, It is a minor bug that students could figure out, but I think it's best to have the notebooks fully working. If it's not too much work, yes could you include it?


can you add method to get selected index please,

can you add method to get selected index please,

Your request is available in the latest version. please update the package.

thank you for your response


Bump version to 4.1.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

This is competing with #4. I think the latter one will be merged automatically on successful CI completion.


[Feature] .gitignore plus code refactoring

Coverage remained the same at 100.0% when pulling 0ea9bba494c9e20954ad9a85c2d58bfac0954469 on modules into 1195fa13d7e6295c8600b57f157551251e66bf54 on master.


feat: add implementation to support safari web push

Added support for safari web push.

https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/NotificationProgrammingGuideForWebsites/PushNotifications/PushNotifications.html
{
 "aps": {
    "alert": {
        "title": "Flight A998 Now Boarding",
        "body": "Boarding has begun for Flight A998.",
        "action": "View"
    },
 "url-args": ["arg1", "arg2"]
 }
}

Cool. Is this something that also could be done with https://github.com/pimeys/rust-web-push
I will merge this if you feel it's important to have here, but I have no means to test any of the code...

Cool. Is this something that also could be done with https://github.com/pimeys/rust-web-push

Safari's web push is not based on web push protocol (with web workers, etc) so it doesn't work with regular web pushes as everything needs to go through Apple's apns.
I think this could potentially be implemented as a dependency within pimeys/rust-web-push so that we have support across the board.


[FEATURE] Please enable github discussions

Is your feature request related to a problem
Using the issue tracking for support is less than ideal and scales really badly once a projects gets more attention.
Another problem with that is that due to its nature, old questions are easily to miss as being closed tickets and search tools do not count them based on popularity.
The solution you would like
Just go to "Settings" tab and enable discussions. Optionally you can update the https://github.com/tiangolo/typer/tree/master/.github/ISSUE_TEMPLATE and update the question template to recommend opening a discussion. Example https://github.com/ansible-community/ansible-lint/blob/master/.github/ISSUE_TEMPLATE/config.yml#L7-L9
Describe alternatives you've considered
N/A
Additional context

Thanks, but it's intentional, discussions don't allow creating a template, and when people come to ask questions there's a lot of back and forth just trying to understand the original intention, question, and problem. But if they follow the template properly, that guides people to provide all the information necessary.
Once they add support for templates in discussions I'll move questions in my repos to them. https://github.com/community/community/discussions/2838
But before that, it's just a lot of extra effort from me or anyone that comes to help just to try to understand what was the question, even before trying to answer it.
For example, I enabled discussions in FastAPI, and it's never as good as questions in issues for that same problem, it's normally difficult to help people there.
So, for now, I'll pass on this request, but thanks for the interest! ☕


Add 'umount()' function

Eventually one wants to unmount a filesystem. Besides manual unmounting by the user, a programm may decide to unmount the filesystem reacting to some event or signal. This can be done by
            std::process::Command::new("fusermount")
                .arg("-u")
                .arg(&umountpoint)
                .status()
                .expect("umount");

But this can be inconsistent/fallible depending on where the fuse 'fusermount' tool is installed. This Library already does some detection thereof and it would be more ergonomic to have a 'umount' as API.

On 2021-09-21 18:25, Christopher Berner wrote:

Have you tried using spawn_mount? I believe it provides this
functionality if you drop the BackgroundSession object that it
returns

having the main thread just linger for closing/unmounting the
filesystem thread looked a bit unelegant to me. I am calling
process::Command("fusermount -u ...") so far. That the filesystem
unmounts itself is only a rare case anyway (ctrl-c handler in
foreground/debug mode)

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/cberner/fuser/issues/179#issuecomment-924507459

Just some thinking: since fuser implements the event loop this could use some (atomic) bool or enum for the loop condition to be shutting down in a controlled way. I may implement such an event loop for my own filesystem, ping me when you are interested in merging such an facility.

Just some thinking: since fuser implements the event loop this could use some (atomic) bool or enum for the loop condition to be shutting down in a controlled way. I may implement such an event loop for my own filesystem, ping me when you are interested in merging such an facility.

.. which is not as trivial as I thought because the Request api's are not public, one can't write his own event loop. I am postponing this now but will revisit it in future.

I've got some plans in this area.  Roughly:

Separate out mounting the filesystem and running init from actually running the main loop. This would be a natural place to return errors, and would solve #175 as well. This would involve the typestate pattern to distinguish mounts that have been inited from ones that haven't.  It would be separate from session as it would not need to be generic over FS type.
Have a separate function for running the main loop. We'd pass a token into the main loop function to allow interrupting the main loop. This would be implemented in terms of a UNIX pipe, then in the main loop instead of read()ing from the FUSE fd we'd poll() the FUSE fd and the interrupt FD exiting the main loop when the write end of the pipe is closed.  This would still be generic over FS type.  We could then also implement different mainloop function implementations for different requirements - multi-threaded, async, etc.

This was going to be a part of #136, but I haven't had time to work on fuse-rs for quite some time.

1. Separate out mounting the filesystem and running init from actually running the main loop. This would be a natural place to return errors, and would solve [RFC: Callback before entering the event loop #175](https://github.com/cberner/fuser/issues/175) as well. This would involve the typestate pattern to distinguish mounts that have been inited from ones that haven't.  It would be separate from session as it would not need to be generic over FS type.

Sounds good to me, i'd like when the mainloop body would be exposed too, then one could write a custom main loop as well.

2. Have a separate function for running the main loop. We'd pass a token into the main loop function to allow interrupting the main loop. This would be implemented in terms of a UNIX pipe, then in the main loop instead of `read()`ing from the FUSE fd we'd `poll()` the FUSE fd and the interrupt FD exiting the main loop when the write end of the pipe is closed.  This would still be generic over FS type.  We could then also implement different mainloop function implementations for different requirements - multi-threaded, async, etc.

Ideally one could opt out from the pipe, because these take resources (fd) while being only used very rarely. For in-process communication an atomic bool (plus perhaps caching an result/error within the session) to abort the mainloop could be enough. Maybe a signal to abort the wait for the kernel request.

I want to add that currently there’s no way to install a race-free signal handler that will always unmount the fuse filesystem, as far as I can see:
let _guard = fuser::mount2(…)
… install signal handler here using the guard …

this pseudo-code has a toctou issue between getting the guard and installing the signal handler. But until you have the guard, you can’t install the signal handler.
You could pass auto_unmount to the mount2 call, but then you run into https://github.com/cberner/fuser/issues/167 :(

I kinda worked around it now by using this:
use url::Url;

fn main() {
  let (send, recv) = std::sync::mpsc::channel();
  ctrlc::set_handler(move || {
    println!("ctrl+c handler running");
    send.send(()).unwrap();
  })
  .unwrap();
  let guard = fuser::spawn_mount(
    fuse_client(),
    &"/home/philip/tmp/fuse",
    &vec![],
  )
  .unwrap();
  let () = recv.recv().unwrap();
  drop(guard)
}

but no idea how racy it is in practice. It seems to work for ctrl+c.

That looks race free to me, and is how I would recommend doing it

@Profpatsch
This works well for Ctrl+C, but how do you handle the case where the filesystem is unmounted and the background thread finishes? Ideally one would like the program to quit, but here the main thread will hang on recv.recv() because it never receives a signal.
I've worked around this by patching fuser::spawn_mount() to accept a Option<std::sync::mpsc::Sender<()>>, so that a message also gets sent to the channel when the thread quits. See https://github.com/abspoel/fuser
fn main() {
  let (send, recv) = std::sync::mpsc::channel();
  let send_ctrlc = send.clone();
  ctrlc::set_handler(move || {
    println!("ctrl+c handler running");
    send_ctrlc.send(()).unwrap();
  })
  .unwrap();
  let send_finished = send.clone();
  let guard = fuser::spawn_mount(
    fuse_client(),
    &"/home/philip/tmp/fuse",
    &vec![],
    Some(send_finished),
  )
  .unwrap();
  let () = recv.recv().unwrap();
  drop(guard)
}

Is this the most straightforward way or is there a better alternative? (Maybe one that does not involve modifying the spawn_mount function.)

@abspoel I think you can pass the Sender object into your Filesystem and call it in Filesystem::destroy(), without patching spawn_mount. That's called when the Session is dropped

@cberner Thanks, that works!

I'm going to close this, since all the use cases so far can be supported with the existing spawn_mount function. Feel free to re-open if there's a use case that it does not support


Initial esc test bed

Adds an initial ESC test bed
This PR aims to add a simple yet functional way of driving our ESCs.
It uses 3 different PWM generators to drive the motors at a pre-determined utilization. This needs to be tuned before merging.
Depends on
Before we merge this we should include the final pwm driver.
#2
Closes
#5
#12

Closed in favour of #27


fix issue #58

YANG model like this
module status{
namespace "urn:ccn:params:xml:ns:yang:hw:status";
prefix "status";
container status{
leaf dataAid{
description "the value of this leaf will plus 1 every time that configuration data is modified.";
type uint32;
config false;
default 1;
}
}
}
when get --filter-xpath=/status:status,it responsed 1,but get-config --source running ,error occurred.
This code fix the problem.

Hi,
there is no need to filter out state data, sysrepo session can do it for us.
Regards,
Michal


pre-flight check for checking NAT gateways is missing

rosa version 1.2.8
For private clusters with private-link, rosa accepts private subnet IDs, results in cluster creation error (after 30 minutes into the cluster creation) and an email to the customer if NAT gateways are missing from the public subnets of the respective VPC.

This problem is reproducible on public ROSA clusters as well.

/assign @oriAdler

Hey @spaparaju, can you please share the cluster ID?
The cluster spec with more details? and the error message from the email.
That seems to be a problem with the AWS network configuration.
Thanks


Infinite waiting when performing TouchActions.flick()

With SelendroidDriver 0.17, I found on my Nexus 7 2013, Android 4.4 now will have infinite waiting when performing a TouchActions.flick().
Below is my code and please kindly let me know if you need more information from my side.
// drv is my SelendroidDriver instance
WebElement seekbar = getFontSizeSeekbarVw(drv, timeout);

// Initialize TouchActions for flick
TouchActions flick = new TouchActions(drv);

// Debug purpose to ensure the seekbar exists.
System.out.println(seekbar.getLocation().getX());

// What I wanna do is to swipe the seekbar to the right end
// And here is the problem, I have tried many times no matter variables or constants, the thread never exits from perform()
flick.flick(seekbar, seekbar.getSize().width, 0, FlickAction.SPEED_NORMAL);
flick.perform();

// Debug purpose, I never saw it is printed out on my console.
System.out.println("Finished.");

After waiting 30 minutes it responded that it was hung at below line
at io.selendroid.server.model.DefaultSelendroidDriver.getTouch(DefaultSelendroidDriver.java:392)
I'll try to get another full trace and reply later

After retest, I found my code will be ended up without doing anything after 30 minutes.
Since there is no any log, please kindly instruct me what I shall do with this problem.


Crashed when using FrameLayout with fragment have SwipeRefreshLayout

When application initializes and you quickly swipe or touch the screen it will crash.
Error Log:
E/InputEventReceiver: Exception dispatching input event.
E/MessageQueue-JNI: Exception in MessageQueue callback: handleReceiveCallback
E/MessageQueue-JNI: java.lang.ArrayIndexOutOfBoundsException: length=12; index=-1
        at android.view.ViewGroup.getAndVerifyPreorderedView(ViewGroup.java:3061)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2234)
        at carbon.widget.FrameLayout.dispatchTouchEvent(FrameLayout.java:462)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2632)

Main Activity:
<layout xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools"
        xmlns:app="http://schemas.android.com/apk/res-auto">
    <data>

    </data>
    <FrameLayout
            android:layout_width="match_parent"
            android:layout_height="match_parent" android:id="@+id/fragment_container"/>
</layout>

and Fragment has:
<androidx.swiperefreshlayout.widget.SwipeRefreshLayout
                android:id="@+id/swipe_refresh_container"
                android:layout_width="0dp"
                android:layout_height="0dp"
                app:layout_constraintTop_toBottomOf="@+id/line"
                app:layout_constraintEnd_toEndOf="parent"
                app:layout_constraintStart_toStartOf="parent"
                app:layout_constraintBottom_toBottomOf="parent"
                android:layout_marginTop="8dp">

            <androidx.recyclerview.widget.RecyclerView
                    android:id="@+id/product_recycler_view"
                    android:layout_width="match_parent"
                    android:layout_height="wrap_content"
                    tools:listitem="@layout/row_campaign" />

        </androidx.swiperefreshlayout.widget.SwipeRefreshLayout>

It does not happen when I use androidx...FrameLayout

This may be related to child drawing order. I'll try to reproduce your issue. Can you share your device's model and Android version?

Android 7.1.2
Device: SM-T561
it happens when I use carbon.widget.FrameLayout in main activity instead of FrameLayout

I tried to reproduce your issue, but with no luck. I don't know what do you mean by "fragment not fully display yet". I created an Activity and a Fragment with the layouts you provided, but the Fragment instantiates and works correctly.
Could you prepare a minimal reproducible sample of your issue for me? A project on GitHub would be perfect. An app demonstrating your issue (crashing for you), that I could download and debug.

@ZieIony I mean when fragment is onCreateView stage that not displaying anything yet but a white screen, then I try to swipe on the screen ( on the part that should be displayed FrameLayout )
NOTE: I'm not tested with the new version of Carbon yet ( i just updated it after use androidx.FrameLayout ). I will test again and inform you about it.

When fragment is in 'onCreateView', its view is not yet available for the container, so the code should behave like it was empty. Adding a fragment is very fast and stable operation, so I believe that there's more than just adding a fragment to cause this issue. That's why I asked about a an example project showing your issue.

I'm unable to reproduce and fix this crash without additional help. I'm closing the issue. Please reopen if needed.


[service-bus] Remove dead code in MessageSender.sendMessages

We always send messages via the 'batch' version of the method now, so the original array-based version with sendMessages is no longer used.

/azp run js - service-bus - tests


Function App (Flex Cosumption) ZipDeploy publish support

Issue describing the changes in this PR
resolves (TBD)
In this PR:

Add new UseBlobContainerDeploy (bool) property to the ZipDeploy target/task to identify when to use the OneDeploy URL
"<publishUrl>/api/publish" endpoint to publish a Flex Consumption function app
When polling for the ZipDeploy pubish status, append the status_text message (if defined) along with the status itself. E.g.: "Deployment status is Failed: App setting WEBSITE_RUN_FROM_PACKAGE is not supported...".
Add UTs for ZipDeployTask and ZipDeploymentStatus

Pull request checklist

[ ] My changes do not require documentation changes

[ ] Otherwise: Documentation issue linked to PR

[ ] My changes should not be added to the release notes for the next release

[x] Otherwise: I've added my notes to release_notes.md

[ ] My changes do not need to be backported to a previous version

[ ] Otherwise: Backport tracked by issue/PR #issue_or_pr

[x] I have added all required tests (Unit tests, E2E tests)

Additional information
This is a copy of https://github.com/Azure/azure-functions-dotnet-worker/pull/2688, created to be able to pass required checks failing due to lack of permission(s).

@kshyju @fabiocav @nzthiago
Please let me know if anything else is required so this PR is approved, and it merges.


cache strategy: stale-while-revalidate as an option to replace/complement no-cache

Clear and concise description of the problem
My project has too many files. Even if the page is hosted locally, it still takes some time to load. But the setup is that I have to load the page from a remote dev-box (with HTTP 1.1), and it takes 20 seconds to load all files. With the option to have stale-while-revalidate, the load time is down to 4 seconds.
I'm happy to submit PR
Suggested solution
Have the option, to turn use stale-while-revalidate instead of no-cache

Sounds like a good improvement in general - I'd be open to a PR.

@yyx990803 if using vitepress you can see @vueuse and how it is configured with vite-plugin-pwa...

I notice that the current codebase now has a caching strategy. Do we still need the ability to customize caching strategy?
https://github.com/vitejs/vite/blob/8048f900908009757bd20d13ee4af90ce15cd32c/packages/vite/src/node/server/middlewares/transform.ts#L178-L180

@iheyunfei that strategy is for dependencies, that are cached by the browser while they are not invalidated by a new version (there is a hash added so the caching can work with immutable and no-cache)
This enhancement refers to user sources, and it is about optionally implementing this strategy for them: https://web.dev/stale-while-revalidate/


Development environment

I can't setup development environment, pandoc requirements cannot be satisfied :
ERROR: Could not find a version that satisfies the requirement pandoc>=2.7 (from -r requirements.txt (line 3)) (from versions: 1.0.0a0, 1.0.0a3, 1.0.0a6, 1.0.0a7, 1.0.0a8, 1.0.0a12, 1.0.0a13, 1.0.0a14, 1.0.0a16, 1.0.0a17, 1.0.0a18, 1.0.0a19, 1.0.0b1, 1.0.0b2, 1.0.0b3, 1.0.0, 1.0.1, 1.0.2, 2.0a1, 2.0a2, 2.0a3, 2.0a4)
ERROR: No matching distribution found for pandoc>=2.7 (from -r requirements.txt (line 3))

I was trying to install with pip, and figured out that some requirements are conda-forge requirements. Just modified requirements files to allow pip installation. Tests are ok. Separating conda and python dependencies could be interesting if not installed with conda.

That's right the README does not contain the steps to setup a development environment, just for testing it in a conda-installation, thanks for that hint! The requirement are internally used just for the GitHub-CI.
I will try to edit the README with the necessary steps later today, I just quickly tested a pip only development install, please follow these steps:

Make sure you have Pandoc installed, see installing-pandoc for instructions.
Execute pip install -e . This command should install all necessary requirements using pip and install jupyter-docx-bundler in editable-mode
Execute jupyter bundlerextension enable --py jupyter_docx_bundler --sys-prefix


feat: name details hints

Description
Resolves #51
Implements name details hints
Demo
https://github.com/aeternity/aescan/assets/46789227/46e2ea3f-3f25-4b9d-8087-f38a46282599
Checklist:

[x] I have read and followed the Contributing Guide
[x] My change does not require a change to the documentation.

To be merged after #277

@lukeromanowicz  One more thing - the hints in the mobile table view should be 'hidden'. Please reuse the previous PR's solution

@janmichek right! I forgot about this! Thanks, fixed:

I would resolve https://github.com/aeternity/aescan/pull/277 first. There are a lot of common hints.

@michele-franchi sure thing, fixed!

Thanks @michele-franchi, gerat suggestions. I've implemented all of them

@lukeromanowicz Charis has not been invited here?

@janmichek I forgot to invite him, my bad


GetMedias isn't working properly

Hello Everybody,
When I execute the following within my app:
			try { 			    $medias = $instagram->getMedias($target, 10); 			} catch (\Exception $ex) { 				error($ex); 			} 			print_r($medias);
I get the following response:
 InstagramScraper\Exception\InstagramException: Response code is 404. Body:

[instagram 404-page]

 Something went wrong. Please report issue. in /srv/users/websites/apps/XXXXXXXXXX/vendor/raiym/instagram-php-scraper/src/InstagramScraper/Instagram.php:72
Stack trace:
#0 /srv/users/websites/apps/XXXXXXXXXX/public/pages/confirm.php(68): InstagramScraper\Instagram::getMedias('XXXXXXXXXX', 10)
#1 /srv/users/websites/apps/XXXXXXXXXX/public/index.php(25): include('/srv/users/webs...')
#2 {main}

Any suggestions? I believe I'm properly using the library but there is something wrong or new on Instagram's end.

You are correct. Its on Instagram's side. They changed the endpoint.
See #205


Incoming call not working in Android 10

Please include the following information for better support
The more context you provide around this issue the faster the community can help you
Did you follow all the instructions as specified in the Twilio Quickstart repositories? Yes
What version of React Native are you running? 0.61.5
What version of react-native-twilio-programmable-voice are you running? 4.1.0
What device are you using? (e.g iOS10 simulator, Android 7 device)? Android 10 and android 7
Is your app running in foreground, background or not running? background and app closed
Is there any relevant message in the log? No error
If using iOS, which pod version are you using?
Step to reproduce
Advanced:
Have you tried adding break point using AndroidStudio or XCode and analyse the logs? No
can share a project with issue?
Did you try to reinstall the pods completely?

Incoming call not working when app is in background and closed (Android)

Any solution ? Please let me know

this is a know issue.
Currently development of a fix is happening in this PR: https://github.com/hoxfon/react-native-twilio-programmable-voice/pull/164
this aligns Android sdk to v5

Any update for incoming call in Android 10 ?

Same issue In Android 11 also.. Incoming call screen is not invoking when app is in background and closed

@Samsritha1596 please test #164

i found android 10 restrict startActivity from background, as your code in firebase class here
 // app is not in foreground
                                if (appImportance != ActivityManager.RunningAppProcessInfo.IMPORTANCE_FOREGROUND) {
                                    context.startActivity(launchIntent);
                                }

So u can not start incoming call screen from background, android suggest use fullscreen intent instead, please give feedback soon, thanks

Hello Team,
I am having the same issue. I am using Android 10.
And we are using below plugin version below -
"react-native-twilio-programmable-voice": "git+https://github.com/hoxfon/react-native-twilio-programmable-voice.git#feat/twilio-android-sdk-5",

We a not able to receive call when app is in foreground and background also.

Hello Team ,
Any update?


Add create-namespace to Helm installation docs.

Description
The helm install command has a --create-namespace option. Remove additional step to create the tigera-operator namespace, and add the --create-namespace to the Calico installation with Helm docs.

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@dimitri-nicolo @doublek is there a motivation for changing this or is it personal preference?

@caseydavenport The motivation is to align the Calico and what will go in CE documentation. Motivation for CE, is to simplify the installation instructions.


Update StateContainer Documentation

Same change as #181 but let's wait until this feature is released this time...

@jfversluis When you get a chance - let's merge this Docs PR now that v4.0.0 is live!


closeOnBackdropClick works on backdrop to the left and right of image, but not above and below image

Not sure if #313 would fix this—I'm not able to look closely at it right now.
Steps to reproduce the behavior:
Tested on Chrome with npm versions 1.1.0-beta.3, 1.1.0-beta.2, and 1.0.0. Also tested 1.1.0-beta.3 on Firefox and Safari. Here's my JSX:
{/* Lightbox gallery */}
<ModalGateway>
  {lightboxOpen && (
    <Modal
      onClose={toggleLightbox}
      allowFullscreen={false}
      closeOnBackdropClick={true}
    >
      <Carousel
        currentIndex={lightboxIndex}
        views={photoSources}
      />
    </Modal>
  )}
</ModalGateway>

My state and toggle function:
// Lightbox gallery
const [lightboxIndex, setLightboxIndex] = useState(0);
const [lightboxOpen, setLightboxOpen] = useState(false);
const toggleLightbox = index => {
  setLightboxIndex(index);
  setLightboxOpen(!lightboxOpen);
};

Expected behavior:
Clicks on the backdrop on all sides of the image ought to close the modal.
Actual behavior:
Only backdrop clicks to the right and left of the image close the modal, not backdrop clicks above and below the image.

This worked for me as a temporary fix:
.react-images__view {
    display: flex;
    height: 100vh;
    align-items: center;
    justify-content: center;
}

That did it—thanks, @lsnryszardb!

I'm running version 1.1.3 and the opposite is happening for me.
Clicking above and below the image will dismiss the modal while clicking to the left or right of the image does nothing.

I fixed this in the latest version, I believe.

@davwheat I updated to 1.1.3 and the issue still sort of exists.
What I see here is that dismiss only happens when you click on the red areas(react-images__header, react-images__footer and react-images__pager) but not on the green area (react-images__positioner).
Maybe you have another approach how to do it, but I believe this causes the issue right now.
Screenshot:

This should be a fairly easy fix... (that's what they all say...!)

@durdevic Can you check if this is still present in 1.1.4?

@davwheat Haha, sorry to break it to you mate for the "easy to fix" comment, but after the update it broke and I got this:
index.js:1 The above error occurred in the <FooterCaption> component:
    in FooterCaption (created by Footer)
    in div (created by css)
    in css (created by Base)
    in Base (created by Div)
    in Div (created by css)
    in css (created by Footer)
    in Footer (created by Carousel)
    in div (created by css)
    in css (created by Base)
    in Base (created by Div)
    in Div (created by css)
    in css (created by Container)
    in Container (created by Carousel)
    in Carousel (at CarouselModal.js:27)
    in div (created by css)
    in css (created by Base)
    in Base (created by Div)
    in Div (created by css)
    in css (created by Dialog)
    in div (created by ForwardRef)
    in ForwardRef (created by ForwardRef)
    in ForwardRef (created by ForwardRef)
    in ForwardRef (created by ForwardRef)
    in ForwardRef (created by Dialog)
    in Dialog (created by Modal)
    in div (created by css)
    in css (created by Base)
    in Base (created by Div)
    in Div (created by css)
    in css (created by Positioner)
    in Positioner (created by Transition)
    in Transition (created by SlideUp)
    in SlideUp (created by Modal)
    in div (created by FullScreen)
    in FullScreen (created by Modal)
    in Modal (at CarouselModal.js:10)
    in FirstChild (created by TransitionGroup)
    in TransitionGroup (created by ModalGateway)
    in ModalGateway (at CarouselModal.js:8)
    in CarouselModal (at URLPreviewSection.js:55)
    in URLPreviewSection (at DefaultMessage.js:90)
    in div (created by styled.div)
    in styled.div (at DefaultMessage.js:175)
    in div (created by styled.div)
    in styled.div (at DefaultMessage.js:166)
    in div (created by styled.div)
    in styled.div (at DefaultMessage.js:164)
    in DefaultMessage (at FolderContainer.js:747)
    in div (created by styled.div)
    in styled.div (at FolderContainer.js:732)
    in div (at FolderContainer.js:730)
    in div (created by styled.div)
    in styled.div (at FolderContainer.js:723)
    in section (at MyDropzone.js:34)
    in MyDropzone (at FolderContainer.js:843)
    in div (created by styled.div)
    in styled.div (at FolderContainer.js:799)
    in FolderContainer (at DnDComponent.js:269)
    in div (created by styled.div)
    in styled.div (at DnDComponent.js:314)
    in section (created by styled.section)
    in styled.section (at DnDComponent.js:313)
    in Unknown (at DnDComponent.js:312)
    in ReactHotkeys (at DnDComponent.js:293)
    in DnDComponent (at Home.js:29)
    in div (created by styled.div)
    in styled.div (at Home.js:28)
    in Home (created by Context.Consumer)
    in Route (at Routes.js:19)
    in Switch (at Routes.js:15)
    in Router (created by BrowserRouter)
    in BrowserRouter (at Routes.js:14)
    in Routes (at App.js:129)
    in GraphqlErrorBoundary (at App.js:128)
    in ApolloProvider (at App.js:127)
    in App (created by HotExportedApp)
    in AppContainer (created by HotExportedApp)
    in HotExportedApp (at src/index.js:16)

React will try to recreate this component tree from scratch using the error boundary you provided, Home.
console.<computed> @ index.js:1
r @ react_devtools_backend.js:6
logCapturedError @ react-dom.development.js:19561
logError @ react-dom.development.js:19598
callback @ react-dom.development.js:20778
callCallback @ react-dom.development.js:12513
commitUpdateQueue @ react-dom.development.js:12534
commitLifeCycles @ react-dom.development.js:19892
commitLayoutEffects @ react-dom.development.js:22835
callCallback @ react-dom.development.js:189
invokeGuardedCallbackDev @ react-dom.development.js:238
invokeGuardedCallback @ react-dom.development.js:293
commitRootImpl @ react-dom.development.js:22573
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11062
commitRoot @ react-dom.development.js:22413
finishSyncRender @ react-dom.development.js:21839
performSyncWorkOnRoot @ react-dom.development.js:21825
(anonymous) @ react-dom.development.js:11112
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11062
flushSyncCallbackQueueImpl @ react-dom.development.js:11107
flushSyncCallbackQueue @ react-dom.development.js:11095
discreteUpdates$1 @ react-dom.development.js:21925
discreteUpdates @ react-dom.development.js:1072
dispatchDiscreteEvent @ react-dom.development.js:4169
Home.js:12 componentDidCatch ReferenceError: string is not defined
    at FooterCaption (react-images.es.js:306)
    at renderWithHooks (react-dom.development.js:14826)
    at mountIndeterminateComponent (react-dom.development.js:17506)
    at beginWork (react-dom.development.js:18630)
    at HTMLUnknownElement.callCallback (react-dom.development.js:189)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:238)
    at invokeGuardedCallback (react-dom.development.js:293)
    at beginWork$1 (react-dom.development.js:23235)
    at performUnitOfWork (react-dom.development.js:22186)
    at workLoopSync (react-dom.development.js:22162)
    at performSyncWorkOnRoot (react-dom.development.js:21788)
    at react-dom.development.js:11112
    at unstable_runWithPriority (scheduler.development.js:653)
    at runWithPriority$1 (react-dom.development.js:11062)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11107)
    at flushSyncCallbackQueue (react-dom.development.js:11095)
    at discreteUpdates$1 (react-dom.development.js:21925)
    at discreteUpdates (react-dom.development.js:1072)
    at dispatchDiscreteEvent (react-dom.development.js:4169)
Home.js:22 Just a normal error ReferenceError: string is not defined
    at FooterCaption (react-images.es.js:306)
    at renderWithHooks (react-dom.development.js:14826)
    at mountIndeterminateComponent (react-dom.development.js:17506)
    at beginWork (react-dom.development.js:18630)
    at HTMLUnknownElement.callCallback (react-dom.development.js:189)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:238)
    at invokeGuardedCallback (react-dom.development.js:293)
    at beginWork$1 (react-dom.development.js:23235)
    at performUnitOfWork (react-dom.development.js:22186)
    at workLoopSync (react-dom.development.js:22162)
    at performSyncWorkOnRoot (react-dom.development.js:21788)
    at react-dom.development.js:11112
    at unstable_runWithPriority (scheduler.development.js:653)
    at runWithPriority$1 (react-dom.development.js:11062)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11107)
    at flushSyncCallbackQueue (react-dom.development.js:11095)
    at discreteUpdates$1 (react-dom.development.js:21925)
    at discreteUpdates (react-dom.development.js:1072)
    at dispatchDiscreteEvent (react-dom.development.js:4169)

Fantastic.

Okay, so following the "Can you check if this is still present in 1.1.4?" comment I updated to 1.1.4, and it was breaking, but now I saw that the latest version is 1.1.6. There it works perfectly! 😁
Awesome job mate! Super quick fixing 💪

Wow! It worked? That was surprising. I'm about to push out 1.1.7 😂
I just found another issue which doesn't affect the use of the library's modals, but does affect you if you only use the carousel component.

I updated to 1.1.7, everything still works! I am ok if you close this issue 😁
P.S. Do you accept feature requests, and if yes, how can I let you know?

Nice! Just create an issue and I'll see what I can do.
I don't usually get round to updating this package much, but these were pretty critical bugs, and lockdown is lockdown, after all.


provide a better error message for missing json libraries

Btw, these json libraries have slightly different apis e.g. on invalid json:

cjson throws an error
dkjson returns nil, position, error_message

Is this something we need to handle?

Btw, these json libraries have slightly different apis e.g. on invalid json:

Not until it proves a problem imo

LGTM


Updated .gitignore to not ignore nextdnsapi package files: nextdnsapi…

Latest version 1.7.0 has a regression causing ModuleNotFoundError on nextdnsapi because the entire module package files are missing from the pypi package. I believe this is due to the updated .gitignore file but it's hard to tell because the entire source code of the pypi package is not present.
Feel free to make any adjustments as necessary.
Also, would you be willing to publish the entire pypi package source codes? It would make it easier for Contributors to test changes before submitting the PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Of course I could. I'll see that the issue is fixed right away.

Honestly no idea what broke, any clue @jinkang23?


Show protocol extensions (e.g. model repository) in Swagger docs

First of all: Thank you for all the work that went into version 1.3.x.
With version 1.2.4, I used to navigate to http://localhost:8080/docs and check which models were loaded, see screenshot below. With the new docs endpoints in 1.3.x, the root /docs route no longer exists. Was this intentional? From the release notes, it sounded to me that the new endpoints were added additionally.
I understand that each model now has a more detailed swagger endpoint, but the repository endpoints are gone. Is there another way to query the list of loaded models?

Hi @adriangonz !
Thank you for the workaround to reach the /repository/index endpoint, but are you sure this endpoint still works for MLFlow models ? Because I just tested it for MLFlow models and I got:
➜  curl -X POST localhost:8080/v2/repository/index -d '{"ready": "true"}'
{"detail":[{"loc":["body"],"msg":"value is not a valid dict","type":"type_error.dict"}]}%

MLServer logs:
...
[2023-05-24 12:14:37,716] INFO /root/.mlflow/envs/mlflow-d22cad4ea97c93fd582713c6d2427716a751e0c0/lib/python3.9/site-packages/mlserver/registry.py:167 - Loaded model 'mlflow-model' succesfully.
2023-05-24 12:14:37,719 [mlserver] INFO - Loaded model 'mlflow-model' succesfully.
INFO:     <IP_ADDRESS>:50418 - "POST /v2/repository/index HTTP/1.1" 422 Unprocessable Entity

MLServer version: 1.3.2
MLFlow version: 2.3.2

The workaround above was just provided as guidance. All you need to do is send a POST request (which is all that Swagger UI does). You can use any HTTP client for this.
In this case though, you probably are just missing the right Content-Type:
curl -X POST -H 'Content-Type: application/json' localhost:8080/v2/repository/index -d '{}'

My bad, Thank you, it works perfectly !


Supports Pi Zero?

Will this work on a Pi Zero with Jessie or Jessie Lite?

Yes, this will work with Pi Zero. Hang on for a few days until we release a specific Pi Zero + Cellular GSM + GPS tutorial. I think you will really like this tutorial.

@jrbail01 thanks for the heads-up and fast reply! That sounds awesome and exactly like what I need. Much appreciated!

Check out the new Pi Zero tutorial at https://github.com/InitialState/fona-pi-zero/wiki


Is there a good reason for gist:name to be a data property rather than an annotation property?

Attn: @sa-bpelakh
We are representing regions for one of our clients, and they are paying particular attention to prefLabels and altLabels, as well as creating a way to resolve  ambiguous labels like "New York" that could refer to a port, a city or a state.   Often a country has a common name that is used for most purposes and is the prefLabel, but also has an official name which is often longer, but not used very often.
The question arises: why are names not labels?  We have a property for hasOfficialName that is a subproperty of gist:name. The question arose as to whether any kind of name should also be an altLabel. It stands to reason to do so.  That could be accomplished by having gist:name be a subproperty of skos:altLabel.
Is there a good reason to not do this?

Interesting that I have the opposite take on this in #427. In addition, our decision to make gist:description a datatype rather than annotation property has relevance here.

@rjyounes
I now think this is not worth worrying about.  Even if we found a coherent argument that it might have made more sense back in the day, I cannot think of any advantages of making the change at the moment. I recommend we close this issue.


Issues Running TAP/PAIR

First of all, thanks for the amazing codebase. I was able to run step 1 on most of the attacks except TAP/PAIR where I this warning and the code seems to hang:
(autoscaler +2m0s) Warning: The following resource request cannot be scheduled right now: {'CPU': 1.0, 'GPU': 1.0}. This is likely due to all cluster resources being claimed by actors. Consider creating fewer actors or adding more nodes to this Ray cluster
Do you have any suggestions on how to resolve this? P/S: I requested an interactive job using Slurm with 2 A100 and 16 CPUs to run the script.

Hi @mnpham0417 , The PAIR and TAP by default use Mixtral as a judge model (more details can be found PAIR_config.yaml. So by default the judge model itself already consume 2 GPUS, you will need to allocated 2+N GPUS for your target model GPU. You can change this to GPT-4 judge models tho it will be very expensive for TAP as it query judge models a lot.

Thanks for the quick response! I've managed to run the pipeline using more than 2 GPUs.


Strict validation of input samplesheet.csv

Following feature would be beneficial in the future:

The headers of the samplesheet should be able to be validated in strict mode, meaning if they are misspelled or missing the pipelines should throw an error instead of a warning
This behavior should be able to be turned on or off

The same feature would be nice for entries in the samplesheet, where required fields are missing.
e.g. if following samplesheet would be present
sample,short_reads_fastq_1,short_reads_fastq_2,long_reads_fastq_2
test,,path/to/first_fastq.gz,

and should be formatted like this
sample,short_reads_fastq_1,short_reads_fastq_2,long_reads_fastq_1
test,path/to/first_fastq.gz,,

and either short_reads_fastq_1 or long_reads_fastq_1are required fields
The pipeline should fail and not run empty with warnings. Also a meaningful error should be thrown in such a scenario.
It would be best this could be turned on or off in a schema_input.json.

The best solution for this is to create a new configuration option (validation.strictHeaders for example). This can then be turned on to throw errors instead of warnings for unknown headers.


Replace inline styles with classes and

See, e.g., this comment.

See, e.g., this comment.

@jtomeck, I'm going to close this issue, assuming that your work on the frontend has been doing this as you go along. Feel free to re-open if you think it ought to be.


Update ktlint to 0.39

Task/Issue URL: https://app.asana.com/0/414730916066338/1199145345336726/f
Tech Design URL:
CC:
Description:
We updated kotlin to 1.4 version however ktlint is still in 0.36, which does not support the new features in kotlin 1.4. This means that if we try to use any of the new features in 1.4, ktlint will complain.
(Support for 1.4 was added in ktlint in 0.38)
Steps to test this PR:

fresh install the app

check core funcionality works

update an already install app

check core functionality works

Internal references:
Software Engineering Expectations
Technical Design Template

FYI: The changes in the kt files are caused by the update of ktlint itself


PartitionWriter Initialisation against kafka start offset

In PartitonWriter constructor I can see the following:
 currentSegment = new SegmentWriter(topic, partition, 0, topicDir);   // do not forget to add the current segment to the partition index. Even if it is empty  partitionIndex.appendSegment(currentSegment.filePrefix(), 0);
You hard-code startOffset to 0, ideally  for topics that have a ttl so don't start at 0 anymore we would like to see the startoffset being another number.
What would be according to you the best way to handle this ?
Also when a set of file have been created with 0 as starting point when the earliest offset if for example 1234. Can the partition cli restore task use the content of the file first index rather than the name regex of the file ?

This should not be an issue at all. This piece of code just checks whether there is already a Segment for the backup data and if not creates a new with a start offset of 0 – This influences only the name of the file – the first record in that file will have the original offset.
During restore the names of the files are ignored too – just the content matters. The files just need some names and using the start offset is a reasonable choice since Kafka is also doing the same ;)
The only thing to note here is that if you are backing up a topic and you write old segments to another storage system – always keep at least the latest one in the directory where kafka-backup is writing its data to.
Hope that this helps ;)


std::any and GNU stdc++ bug for RTTI and dynamic loading

Just wanted to document this.
In versions of GCC below 7.5 and 8.4 there is a bug whereby std::any_cast fails in the presence of dynamic library loading. This affects our HeterogeneousMap data structure.
Here's a reference to the bug fix https://github.com/gcc-mirror/gcc/commit/683f9728e8f54bff4b798dead54c5c4275079158#diff-1d4ec2cbbc8c2e33d4a80c2bc5554db6R438
This leaves GCC version 7.5, 8.4, 9.3, 10.1, 10.2 as valid versions.

One question - did we only see this bug for the case of passing a void* to the HetMap in the HPC Virt plugin?

The deuteronH2.py example in the current Gitpod image failed b/c of this bug as well. It is using GCC version 8.3.

Was just trying to test it, can confirm that.

with 8.2.0, the c++ tests all seem to pass.

https://github.com/tnguyen-ornl/xacc/blob/efa12a271cac722c970b4fb9ec82077d3b100507/xacc/utils/heterogeneous.hpp

fyi, seems like the std::any fix was backported to minor versions also.
e.g. on Redhat with gcc version 8.3.1 20191121 (Red Hat 8.3.1-5) (GCC), <any> header does contain the fix.
So we may need to check on the GCC release date when debugging this issue.


Fix JS parsing for StudentSolutionsView

Apparently, previously esper was in the global namespace. No longer, so parsing JS solutions in the StudentSolutionsView has stopped working. This moves esper loading and parser creation to initialize.

Coverage decreased (-0.007%) to 56.339% when pulling 18759f400bb079f891711c3c1d622c4348096254 on fix-js-solutions-view into 3a9de47413c92a78897a97c702f53cea527876a9 on master.

Coverage remained the same at 56.344% when pulling 1649ef9fe5ca1c7b253de179b8b8be414f0a3cd2 on fix-js-solutions-view into bcd62fae8da314bb4ef687cdb4251974dcef02bc on master.


No getting Contact list

Hello I am using this sample and i have create project with this package and enable email and password login in firebase dashboard and after that i am login with ids but i cant see any contact list data in my both device although there number are save in my phone.So from where i will get contact list and go further?

The application don't use phone numbers from phone book. The contact list only displays contacts registered in app.


Add history table of room issues to the room issue screen

Waiting on mockups and more details on this from Cole

We're going to do mockups on this for the Support team first.

Mockups are done, waiting to hear back on final requirements.
@smitheyco Did we ever clarify with Anthony about the mockups we sent?


Add updating homebrew instruction

Adding instructions for homebrew updates for maintainers

@vors A gentle reminder :) are you able to address the comments?


Tunnel can still block vscode setup

Testing #183698

This was a mistake on my side in the test plan item.
The dialog is the expected behavior when running the setup wizard. Closing the tunnel automatically only happens for the background update,


[New game]: Highway Race

🎮 Game Request
This is Highway Race Game with basic graphics
Point down the features
Game points +1 when Cross the vehicle
No Negative Points
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Kalivarapubindusree , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#1679

Hey @Kalivarapubindusree ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @Kalivarapubindusree !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

@kunjgit  But this High way game was different one with good graphics and marks and good game!


capi: Actually mark rav1e_twopass_unref as a C function

Coverage remained the same at 80.57% when pulling 91fd6beeebf8dadc4486a3a66fcee44c786ada84 on dwbuiten:woops into f9ad26f55ebd5e3a827213b18f5b2534550ead39 on xiph:master.


Add more options for Hosts to charge Collectives their Host Fee

With the new paid host plans going into effect, I think it's time we add more options for the fees Hosts can charge their Collectives. I just upgraded my own Host to the small plan and immediately wanted the choice to pass on the fees to the Collectives, but our current system does not make this easy.
I think the options should be:

A % of all incoming funds (the option we have now)
A monthly set fee (e.g. $10/month)
No fee

I thought about setting up monthly contributions from each Collective to the host for "admin fee" as a hack, but there's no way to contribute directly to a host so it's not possible. With the new payment structure, it's especially unfair to force hosts to create a Collective to receive fees as they will have to pay for it.
We either need to transform hosts into an entity that can have its own budget, or give hosts a default Collective for free to send the Collective fees to. See #1723 and #1985.
Also see #2821 for the ability to charge different fees to different Collectives.

A couple more ideas:

Charge a Collective a one-time fee
An option to simply pass on whatever fees the host is paying Open Collective to their Collectives automatically

There's also the added issue of monthly fees to hosted orgs who are only intermittently active - when they are not active, a base fee feels like a needless charge, and when they are active and generating work for their host, a baseline fee would not be fair either.
We are working around this currently by charging a fix per-transaction fee (1 EUR) that covers or at least contributes to the variable cost of the activity (basically forwarding the cost we pay to our accountant to account for these costs), but we would like to charge our active collectives a "support contribution" that helps us cover the underlying foundation's fixed costs. The way we figured this could work is we have created a separate collective for the foundation (so we have both a host  AND a collective for the underlying foundation), and we just present our budget and running costs openly in this collective. This also allows our hosted collectives to contribute on a "pay-what-you-can-spare" basis for all the non-accounting-related services they are using (e.g. our hosted Matrix installation for chat, or our Zoom subscription for video that all these collectives have access to).
One drawback of this approach is that managing the foundation's collective adds an extra collective to our host and managing its budget quickly puts us past the limits of free collectives, so even as a host just starting out and few active collectives we are forced to paying the monthly fee. While we are glad to be supporting development (as we see it going really well), this might be an issue and a barrier of entry for other bottom-up bootstrapped hosts like us.

@flaki - Thanks for the feedback. I totally agree. We are aware of the problems with making hosts also create a Collective for their own budget. We are planning to integrate Collective budget features into host pages soon so this won't be needed.

Closing in favor of #3362 because the rest is done with the new pricing model

Closing in favor of #3362 because the rest is done with the new pricing model


ipam/multipool: Fix comment for removeExpiration

The comment for removeExpiration is still using startExpiration.
Looks like it's just a copy-paste error.

thanks!

/test

Thank you for your review @tommyp1ckles . Some checks did not pass, and I have examined the details of these failed checks. It seems they are not related to my submission. Could you please provide me with some suggestions? Your assistance is greatly appreciated.


fix(integrations): add wandb.run check to Gym integration to prevent errors from patching

Fixes WB-12041
Fixes #4685
Description
The PR adds a single line to the gym integration to only log upon gym monitor close if there is an existing wandb.run to log to.
Add a check for a running wandb run after latching to a gym monitor during the patched close. This prevents an issue with tracking after wandb has latched onto the gym monitor, but there is no underlying wandb.run (such as in the case of monitoring gym after a finished tracked experiment)
Testing
Tested against the colab within the ticket. Can add a functional test if that makes sense.
Checklist

[ X] Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
[X ] Ensure PR title compliance with the conventional commits standards

@ash0ts would mind adding a test for this fix.

@raubitsj the issue seems to be that once we finish a run we don't "un-patch" the gym patch. What would be the desired behavior:

Just ignore the log if we don't have a run as in this fix (I think it is a safe fix)
Unpatch all the things we patch once the run is finished? <- This one seems like the most desired approach, since the flag is on the runs level, it might be the case (like the original issue that we would want to run the relevant library without wand)


add Triple events, multiples strategy and changed CoincidenceEvent

Adding triple coincidences. We're now using arrays of length 2 for CoincidenceEvents, such that it is the same for triples.
Also added a field for how multiples are handled by the scanner.
Also added documentation clarifying TOF conventions.
BREAKS BACKWARDS COMPATIBILITY

[x] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in the ETSI software (the Work) under the terms and conditions of the Apache-2.0 License.

@johnstairs how do we document enums in yardl? My current strategy for the MultipleCoincidenceStrategy doesn't seem to work.

My knowledge about triple events is limited, so take the following with a grain of salt.
The only potential problem I have found with the proposed modifications is the definition of MultipleCoincidenceStrategy.

Currently, it only defines rejection or conversion into coincidence pair. In other word, it does not have a value associated with the fact that the format also supports tripleEvents, where they are stored as triple. The intent might be to that one can easily check for the existence of tripleEvents but it feels prone to error.
Also, it feels like MultipleCoincidenceStrategy should refer to how multiple events are dealt with and not how they are represented/stored. If I use GATE as a reference, this name feels more appropriate for what GATE calls Policy name for multiple coincidences. Thus, my neophyte view on the matter would be to have MultipleCoincidenceStrategy defines two parameters: something akin to GATE's Policy name and something like TripletContainer or TripletStructure.
Lastly, my understanding of triplet events recovery is that you only want to work with triplets that has at least one of the three events with an energy of around 511 keV while also allowing small energy window for the other two. Thus, it feels like one would have two energy windows in that case? Unsure if it is possible in practice, however. If it is, we should be able to store that information in Protocol or something.

We have discussed this more in a previous meeting, after referring to table 8.2 of the Gate-UsersGuideV7.2.
We agree that "policy" is a better name than "strategy" and have adjusted it accordingly. Also added a little bit more clarification.
The topic of how scanners handle multiple single events is very complicated. For this PR, we just list 2 simple policies and an "other". We will aim to get information on common policies to be able to encode those.
@MaxTousss hopefully the new wording makes it clear that this only discusses how prompts are recorded. Similar issues with triples will be left for later. As an example, if the stream stores "triple coincidences", than it is expected that the "prompt coincidences" will be recorded with a policy of rejectMultiples. It is unclear to me if that is necessary to enforce this (so I wouldn't).

3. Lastly, my understanding of triplet events recovery is that you only want to work with triplets that has at least one of the three events with an energy of around 511 keV while also allowing small energy window for the other two. Thus, it feels like one would have two energy windows in that case? Unsure if it is possible in practice, however. If it is, we should be able to store that information in Protocol or something.

At present, (double) coincidences and triples store energy window information for every single (so, 2 energy windows for a double coincidence, etc). We believe this will address your concern.

The intent might be to that one can easily check for the existence of tripleEvents but it feels prone to error.

That was indeed the intention, but we agree that this is difficult in practice. We might need to have booleans in the header delayedsAreRecorded, triplesAreRecorded etc.

This PR could easily be extended to quadruples, but we will leave that for later as well.


Marking a feed as read, then quickly tapping a different feed navigates to the wrong feed

Seems like an issue with updating the index paths of the table before it gets updated in the UI, then quickly selecting a new item in the list navigates to the one underneath.
Here's an example screenshot of my feeds:

If I were to go into Dev for example, then mark all as read, when the navigation stack is popped, Dev remains visible, but quickly disappears because I have it filtered to unread items. If I select a different row before it disappears, it navigates to the wrong row.
I will try to catch it through a screen recording to attach to this issue

@Mackarous I've desk checked this and it looks ok to me.  Since this will be for the 5.0.2 release, could you make your pull request against the ios-release branch?  That will save me from having to cherry pick it off of master.


Document artifact download behaviours and add tests for the variants

In #1438 @yonran highlighted a surprising agent download behaviour where path/pattern and destination match.
Single deep these would collapse as expected and the file would be downloaded to the expected location. Appending a trailing slash would nest the path/pattern in the destination regardless of matching name. The surprising case is when path/pattern and destination are more than single depth and equal, as the first part of path didn’t match the last part of destination they would be nested.
I discussed this with a couple of folks internally and several of us have run into this gotcha. I think that’s a good sign that this isn’t a "least surprise" behaviour, and it isn’t aping a particular implementation that I can find. I traced this behaviour back to 2014 in First cut at downloading.
However, this change is not backwards compatible. The specific change is highlighted in the tests diff in https://github.com/buildkite/agent/commit/5565d2100d2a64518682d2b1745b38f06e68edb3. Currently, buildkite-agent artifact download foo/bar foo/bar will create a file $PWD/foo/bar/foo/bar. With this change those arguments would instead create a file $PWD/foo/bar (indeed as this change intends, though not without potential consequences).
The more I’ve noodled on this the more I’ve started to renege on my own change 🙈 perhaps a tar style --strip-components  argument would be easier for folks to adopt, allowing you to select across the whole set of artifacts, then drop some number of leading path components, and write the remaining set to a given destination directory.
--
Edit: I’ve dropped the behaviour change and have gone back to just docs + tests.

The more I’ve noodled on this the more I’ve started to renege on my own change see_no_evil perhaps a tar style --strip-components argument would be easier for folks to adopt, allowing you to select across the whole set of artifacts, then drop some number of leading path components, and write the remaining set to a given destination directory.

I agree that a breaking change in the behaviour is risky - it's bound to bite someone.
I don't think we have an official list of breaking changes we'd like to make in a 4.x release - maybe we could start one and add this? We could potentially make the breaking change behind an --experiment flag in the meantime and folks can opt-in that way? --strip-components or similar could be fine too.
I guess the other thing we can do that isn't a breaking change is expand the cli docs for the subcommand. It seems like explaining the complexities clearly might be a challenge though :grimacing:

I’ve removed the behaviour change and gone with documenting the existing behaviour along with adding the tests from #1438, this is ready for a final review

oh no, looks like the new tests fail on windows?

All working! I just excluded the test file because the paths are all hard coded unix style.