Pumba Stress is not working as expected

Hello Team ,
I was using pumba to inject cpu stress in docker containers and it was working perfectly fine.
curl --unix-socket /var/run/docker.sock -H "Content-Type: application/json"
-d '{"Image": "gaiaadm/pumba","HostConfig": {
"Binds": [
"/var/run/docker.sock:/var/run/docker.sock"
]
}, "Cmd": ["--log-level=info", "stress" ,"--duration=1m", "re2:^pg_"]}'
-X POST http://localhost/v1.37/containers/create
However when I use the above command now to stress the docker container getting below error :
docker logs -f 5ffef0aa421354a5c94f375c90da8fcb1fff33355277ad1dbd409429fe77bbae
time="2022-12-02T08:31:07Z" level=info msg="stress testing container" dryrun=false duration=1m0s id=e49e026eb5512be937945800216403d185bf2756c9f7e8dcc8ccab21961aaa75 image="alexeiled/stress-ng:latest-ubuntu" name=/pg_container pull=true stressors="[--cpu 4 --timeout 60s]"
time="2022-12-02T08:31:11Z" level=fatal msg="error running stress command: error running chaos command: one or more stress test failed: stress-ng failed with error: stress-ng exited with error: \x02\x00\x00\x00\x00\x00\x00/cgroups can't be listed: Cgroup is not mounted\n\x02\x00\x00\x00\x00\x00\x00)cgroup controller and pathparsing failed\n"

@rantidev please provide more details about your runtime environment: OS, docker host, version, where you run pumba and target containers, etc. - everything that will help to reproduce the issue.
Please also add commands you are using to run the target container and the pumba container (docker commands and not curl)

Hi,
Running into the same issue.
OS: Linux docker 5.10.0-20-amd64 #1 SMP Debian 5.10.158-2 (2022-12-13) x86_64 GNU/Linux
Docker Version: 20.10.23
Docker Compose v2.15.1
Docker compose file:
services:
   redis:
     image: redis:6-alpine
     restart: unless-stopped

Debug output:
root@docker:/home/hyperglass/prometheus# pumba --log-level=debug stress -d 1m redis
DEBU[0000] using names                                   names="[redis]"
DEBU[0000] stress testing all matching containers
DEBU[0000] listing matching containers                   duration=1m0s labels="[]" limit=0 names="[redis]" pattern= random=false stressors="[--cpu 4 --timeout 60s]"
DEBU[0000] listing containers
DEBU[0000] found container                               id=f481bc6bd9bc369c9911a9a9f3e3xxxxxxxxx name=/redacted1
DEBU[0000] found container                               id=21f8d632502e09e459e4d19dfa13cb2ayyyy name=/redacted2
DEBU[0000] found container                               id=914608923f3e8211cd2d2c7e94e4705b23z name=/redacted3
DEBU[0000] found container                               id=baf4f8d39ee1d3e82234a5153cd1067a15db name=/redis
DEBU[0000] found container                               id=d121419b5b43e7dfe8515f47a44d40b8faaa name=/redacted4
DEBU[0000] stress testing container for duration         container= baf4f8d39ee1d3e82234a5153cd1067a15db duration=1m0s pull image=true stress-ng image="alexeiled/stress-ng:latest-ubuntu" stressors="[--cpu 4 --timeout 60s]"
INFO[0000] stress testing container                      dryrun=false duration=1m0s id=baf4f8d39ee1d3e82234a5153cd1067a15db image="alexeiled/stress-ng:latest-ubuntu" name=/redis pull=true stressors="[--cpu 4 --timeout 60s]"
DEBU[0000] executing stress-ng command                   image="alexeiled/stress-ng:latest-ubuntu" pull=true stressors="[--cpu 4 --timeout 60s]" target=baf4f8d39ee1d3e82234a5153cd1067a15db
DEBU[0000] pulling stress-ng image                       image="alexeiled/stress-ng:latest-ubuntu"
DEBU[0001] &{Pulling from alexeiled/stress-ng   {0 0}}
DEBU[0001] &{Digest: sha256:6c2f6a6997aeb0dc7f7299e556f67cbb7ca1b40398ef32bbeea50b90fc020ae3   {0 0}}
DEBU[0001] &{Status: Image is up to date for alexeiled/stress-ng:latest-ubuntu   {0 0}}
DEBU[0001] creating stress-ng container                  image="alexeiled/stress-ng:latest-ubuntu"
DEBU[0001] stress-ng container created, starting it      id=103c4a9221ee57ee59dba0de6ea6aa6fd65bf2f9efdf3ab577892d459c4f7e5d
FATA[0002] error running stress command: error running chaos command: one or more stress test failed: stress-ng failed with error: stress-ng exited with error: /cgroups can't be listed: Cgroup is not mounted
)cgroup controller and pathparsing failed

@toky0 thank you. I will try to reproduce in a similar environment

Any update in this error?

Not yet. I think it's related to Linux distribution you are using and the cgroups package.
Can you try to run it on Ubuntu or Redhat LTS version?

having the same issue. The container I am trying to attack is a mongo:6.0 image with a couple tc and ping utils package installed.
uname -a -> Linux bdab893f99b2 6.11.6-orbstack-00279-g28c6c77332e6 #57 SMP Mon Nov  4 08:11:30 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux
docker -v -> Docker version 27.3.1, build ce12230
docker-compose -v -> Docker Compose version 2.26.1
pumba stress --duration 100s mongo2
DEBU[0000] using names                                   names="[mongo2]"
DEBU[0000] stress testing all matching containers
DEBU[0000] listing matching containers                   duration=1m40s labels="[]" limit=0 names="[mongo2]" pattern= random=false stressors="[--cpu 4 --timeout 60s]"
DEBU[0000] listing containers
DEBU[0000] found container                               id=f54882f0956ea3370fb6354a209958f2de24bc34ad50c5b0857f8fb9bf2dd9d1 name=/determined_matsumoto
DEBU[0000] found container                               id=8ebc9117123c826d16fd7da93a9321adbb1208b7ce61e8da6605fe96ed5cd952 name=/mongo1
DEBU[0000] found container                               id=bdab893f99b2fa035ee875507b7f29f2c388c6d89fc955d0c435b00ed3d914b1 name=/mongo2
DEBU[0000] found container                               id=245f6cfedc64ca6246f1ca2df8d3d6864a65cb8295d88f082e0af4374c506200 name=/databases-redis-1
DEBU[0000] found container                               id=dd144691c31f263d47bd16419b7423621e189f0da5cd3e87a4589623198e7322 name=/databases-rabbitmq-1
DEBU[0000] found container                               id=2089d2846ba5ca090b4797e6f386ac38262b3601841daa64dc49b439d70860b4 name=/databases-nginx-1
DEBU[0000] stress testing container for duration         container=bdab893f99b2fa035ee875507b7f29f2c388c6d89fc955d0c435b00ed3d914b1 duration=1m40s pull image=true stress-ng image="alexeiled/stress-ng:latest-ubuntu" stressors="[--cpu 4 --timeout 60s]"
INFO[0000] stress testing container                      dryrun=false duration=1m40s id=bdab893f99b2fa035ee875507b7f29f2c388c6d89fc955d0c435b00ed3d914b1 image="alexeiled/stress-ng:latest-ubuntu" name=/mongo2 pull=true stressors="[--cpu 4 --timeout 60s]"
DEBU[0000] executing stress-ng command                   image="alexeiled/stress-ng:latest-ubuntu" pull=true stressors="[--cpu 4 --timeout 60s]" target=bdab893f99b2fa035ee875507b7f29f2c388c6d89fc955d0c435b00ed3d914b1
DEBU[0000] pulling stress-ng image                       image="alexeiled/stress-ng:latest-ubuntu"
DEBU[0002] &{Pulling from alexeiled/stress-ng   {0 0}}
DEBU[0002] &{Digest: sha256:6c2f6a6997aeb0dc7f7299e556f67cbb7ca1b40398ef32bbeea50b90fc020ae3   {0 0}}
DEBU[0002] &{Status: Image is up to date for alexeiled/stress-ng:latest-ubuntu   {0 0}}
DEBU[0002] creating stress-ng container                  image="alexeiled/stress-ng:latest-ubuntu"
DEBU[0002] stress-ng container created, starting it      id=ee20b6df8d73267ad46d7bd25d1d23cdf72c5d90415e9080865185c98f656be1
FATA[0003] error running stress command: error running chaos command: one or more stress test failed: stress-ng failed with error: stress-ng exited with error: /cgroups can't be listed: Cgroup is not mounted
)cgroup controller and pathparsing failed
```bash


fix: [OCI8] Bug: Argument #1 ($value) must be of type ?int, string given

cast $this->port to string on ctype_digit of OCI8 Connection
Checklist:

[ ] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

Thank you for sending this PR.
First of all, you must sign all your git commits. We never accept PRs without GPG signing.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/signing.md
Next, please fix failed checks in GitHub Actions.

I don't think this is the fix for the referenced issue. The issue is on BaseBuilder::limit() called on Model which complains of string value. Then, this fix forces a string port. So I think this is a fix to a different issue.

I do not see why this PR should be merged.
If you send PRs, please describe why.


error - ./node_modules/@terra-money/webapp-provider/contexts/bank.js:35:0

Getting this error from webapp-provider:
error - ./node_modules/@terra-money/webapp-provider/contexts/bank.js:35:0
Module not found: Can't resolve '@terra-dev/use-browser-inactive'
Here is the version I'm using
"dependencies": {
"@material-ui/core": "^4.11.4",
"@material-ui/icons": "^4.11.2",
"@terra-money/wallet-provider": "^0.14.0",
"@terra-money/webapp-provider": "^0.15.0",
"@types/react": "^17.0.9",
"next": "^10.0.0",
"react": "17.0.1",
"react-dom": "17.0.1",
"react-use-clipboard": "^1.0.7",
"typescript": "^4.3.2"
}

@moconno 😅 Webapp-provider is an internally used API for Anchor WebApp and is not a topic for this Repo (as SemVer 0.x shows, I do not recommend using it because it can cause a lot of API changes, and I have not yet created a document available to external developers).
If you are interested in this hidden API, you can refer to the source code in the Anchor WebApp Project, and if you write questions in the Anchor WebApp Issue, I will answer them.
https://github.com/Anchor-Protocol/anchor-web-app/blob/master/base/src/base/AppProviders.tsx#L85
https://github.com/Anchor-Protocol/anchor-web-app/issues
Thanks!


drivers: serial: nrfx_uarte: Add support to DMM  and data cache and other minor tweaks

Add support for DMM and cache.
Add configurable magic word used for RX flush workaround.
Add workaround for lack of retention of the BAUDRATE register in UARTE120.
Add lock to uart_rx_disable.
Fixes #77060.

@anangl your comments applied.
@nika-nordic some comments applied. Due to resources usage I would stay with what we got regarding use of dmm where it is not needed.

After including dmm.h unconditionally nrf52_bsim target compilation started to fail due to lack of soc/nordic/common include path. I've added it to bsim boards. @aescolar can you take a look if that is ok?

I've added it to bsim boards. @aescolar can you take a look if that is ok?

@nordic-krch I think that is fine


Support multiple versions in Go

Follow up https://github.com/bytecodealliance/wit-bindgen/pull/695

wit-bindgen-go supports emitting multiple versions of a package if more than one version is included: https://github.com/ydnar/wasm-tools-go/commit/90a9cb58bdaf31673ea39a6097028d2e4b4f9509


feat(api): add register static method #44

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #44
Summary:
AuroLoader.register is to easily register the element without extra importing
import "@aurodesignsystem/auro-loader" will still register this element to
import { AuroLoader } from '../src/auro-loader.js wont register this element until AuroLoader.register gets called
Fixed the typo on Recommended Use and Version Control. clement -> element
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add a static method AuroLoader.register to facilitate custom element registration and update the build configuration to include demo scripts. Correct documentation typos and update examples to use the new registration method.
New Features:

Introduce a static method AuroLoader.register to allow easy registration of the element with a custom name.

Enhancements:

Remove the default internal definition of the auro-loader element to rely on the new register method for registration.

Build:

Update the Rollup configuration to include a new build target for demo scripts.

Documentation:

Correct a typo in the documentation from 'clement' to 'element'.
Update documentation to reflect the new AuroLoader.register method for registering components.

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


No ad to show

Hello, it's me again...
I keep getting "no ad to show" error on iOS simulator. Actually it doesn't happen all the time but when I refresh the simulator, error shows up sometimes and it takes 10-20 refreshes to disappear. It happens with both admob test id and my own ad unit id. Android emulator just works fine btw. I am about to publish my app end of this week so is there any chance to solve that? Or is it just problem with simulator?

It can always happen that there’s no ad to show. But the error is actually caused by the console.error in the onAdFailedToLoad prop. If you remove that you should be safe.

How can this happen with the admob test id? isn't supposed to serve a video for the purpose of the test?

I have the same issue with @rafWork , as @koenpunt advise i remove onAdFailedToLoad but my admob screen still doesn't show admob. Should i ignore it or try to fix it ?

@motogod when did you setup your AdMob account? it takes up to 24h to activate sometime, you'll receive an email when activated. Also I think you need to setup AdSense:
https://www.google.com/adsense
Also I found that the test_ids are only working in the simulators, if you test your app on a physical device it's not working

@Maxwell2022 Thanks for your information, i just created the Admob id several hours ago for IOS project. I know what happen now, thank you.

I am also getting this error.
Is there anyone who has solution?

I am also getting this error.
Is there anyone who has solution?

The same error on iOS, any solution???

SoMe PrObLem

I have followed all the steps and set up everything but no matter what ad is not showing on the physical iOS device.I m getting ad in iOS simulator and everything working fine on the android physical device too.
In iOS side getting error [Error: Request Error: No ad to show.]
Is there anyone who has solution?


tests cannot be run if matplotlib and pytest-mpl are not installed

I've encountered an issue that I think is caused by pytest-mpl, which it looks to me was integrated into astroplan in #13 (@cdeil ?): if I try to run the tests for astroplan on a machine where matplotlib is installed but pytest-mpl is not, I see the following error before the tests even start:
% python setup.py test
running test
running build
running build_py
usage: -c [options] [file_or_dir] [file_or_dir] [...]
-c: error: unrecognized arguments: --mpl --mpl-baseline-path=astroplan/plots/tests/baseline_images

I think this is due to the line in the pytest section of setup.cfg which says addopts = --mpl --mpl-baseline-path=astroplan/plots/tests/baseline_images.  Presumably that fails if pytest-mpl is absent.  Is there a way to still use pytest-mpl when present but just skip the tests (and not have the command line failure) if it's absent?
cc @astrofrog as I imagine this might show up in other pytest-mpl situations

@eteq – I noticed the same issue on travis-ci and already asked @astrofrog for help at https://github.com/astropy/astroplan/pull/83#issuecomment-135899418 and https://github.com/astropy/astroplan/pull/83#issuecomment-135904296 .
At the moment pytest-mpl is a required dependency to be able to run the astroplan tests.
I think this is acceptable, but I'd also prefer to have it optional as you describe.
But I don't know how to implement it that way.
@bsipocz – you mentioned that you're implementing image comparison tests for photutils. Have you found a solution for this issue?

@cdeil - Nope, I stuck at an earlier point with decorating a decorator https://github.com/astropy/photutils/issues/271#issuecomment-135878383.

btw I don't see any problems with having a requirement of pytest-mpl for tests, there are extra requirements there already for tests an docs builds.

@bsipocz – Actually, at the moment, it's not just pytest-mpl that's a required dependency.
It's also matplotlib and nose ... if matplotlib is not present, pytest errors out like this:
https://travis-ci.org/astropy/astroplan/jobs/77760727#L512
There must be a better way!

Ohh, that's not good. Isn't there a way to force a preference order on decorators? So the top one will override, as well as being applied to the decorators below?
I guess my problem in https://github.com/astropy/photutils/issues/271#issuecomment-135878383 can be routed back there, too.

Basically everything in pytest can be configured (see here or here here), so I'm sure it's possible to set this up.
But I'm hoping @astrofrog will tell us how to set this up, so for now I won't spend time on this, trying to implement a solution ...

Good idea. I'll do that, too.

Moving this to 0.2 ... it shouldn't block the 0.1 release which is long overdue.

@cdeil - I disagree that this is acceptable.  In the current state, users and most devs cannot run the test suite, because pytest-mpl is pretty niche. That's a big problem for an early release like this because I strongly suspect the tests will fail for some people and that will give us useful feedback on how to fix things.  So I would instead advocate either trying to get it to work or just turning this off for the release (it looks to me like adding a # to the correct line in setup.cfg does the trick).

(I'll spend a little time shortly on trying to get this to actually work using the programmatic configuration, though)

@eteq – Agree to turn this off, because it might be annoying to users or potential new devs.
Thanks for having a look!

In #90 I think I figured out how to get it to happen programatically.


 If you edit the created filter, you were able to save an empty filter

dir exclude filter support:

"*/cache/*" matches "/master/cache" or "/master/test/cache" (any /cache/ folder)
"/cache/"=="cache/" matches "/master/cache/" (in root of master only)

file exclude: previously excludes all specified file names

support select specific file by path: /master/path/to/file/filename
/filename matches filename only in root
"*/filename" == "filename" matches filename anywhere
"/te*/ca*/New*" matches specific path up to file New*, excluding New* named folders

bug:

Translation not pushed in xml because of merge issues with my previous pull requests
Hope you can merge previous pull requests for easier pulling by me :-)
Filters

File Exclude filter works properly
Dir exclude filter:  still some testing needed for some exceptions, but the most important is working like exclude /cache/ and wildcards
I did not alter wholeDirExcludeFilterPatternList as I am not sure why it is there (undocumented)
File and folder include
It will be hard for me to fix theme like exclude filters because:

the need of specific includes is questionable (we can create sync tasks for different included folders)
I have to recode around the Arrays and manage the isSyncOptionUseExtendedDirectoryFilter1(): hard and long for me to follow the code I did not write

If you're ok for exclude filters, I can clean the code and we can let include as it is
I will then write the help file translations to document the filter patterns
Many thanks and best regards

Thank you for your suggestion.
The directory filter has a similar functionality, please check it out.

"\cache"  matches "/master/cache" or "/master/test/cache" (any /cache/ folder)
"cache*"  matches "/master/cache" or "/master/cache_test"(Directory starting with cache )
"/cache"  matches "/master/any/cache" or "/master/any/cache_test"(Directory starting with cache )

I disagree with the inclusion of paths in the file filter, as I don't see any benefit to the user.
Best regards.

Thank you, I tested your filters properly
The below filters work actually ok in your code to achieve the desired result:
SMBSync2 filter    ==> linux/windows console equivalent
cache      ==> /cache* folders (folder in root root but also matches /master/cache_root)
cache/     ==> /cache/* (starts from root, exact dir name match)
test/*ca*/ ==> /test/*ca*/ (starts from root and perfectly matches /test/cache or /test/cache_no/ and /test/no_cache/
\\cache    ==> */cache/* (matches exact directory name anywhere in path)
\\*cache*  ==> *cache* (matches any *cache* folder anywhere in path)

Current exceptions:
Below are the 4 cases failing in your filters
The worst is number (1) and number (2), optionally (4)

no way to exclude a */cache/thumbnails/* to match anywhere in path (leading slash not supported and WholeDirectoryName mode doesn't accept paths)
Mirror mode: delete non matching occurrences in target to have a real mirror (example when I want to delete previously copied */thumbnails/* and */cache/* folders already mirrored once on target). Add a warning to user if selecting mirror + filters
filter "/cache" doesn't work at all and never matches if we add a leading "/": not a problem if we accept it as a relative path and it is replaced by filter "cache/", except for case 1 not supported
File filter by path: useful to exclude a 1Gb /folder/thumbdata file and keep smaller thumbdata files + it is more friendly

My preview code:
Same as yours but no special \\ chars and mainly adds support for leading "/" and case (1) + File path includes (excludes can be added if you think it is a good idea to implement it.
Dir excludes supported in my commit:
/cache  ==> /cache* (folder starts in root of master, includes /master/cachemir/)
cache   ==> /cache* (same as above)
/cache/ ==> /cache/* (folder starts in root of master, exact match folder name)
cache/  ==> /cache/* (same as precedent)
/cache/thumbnails/   ==> /cache/thumbnails/* (folder starts in root of master)
*/cache/thumbnails/* ==> path sequence anywhere in path

- File path excludes: perfectly supported as simple file name or paths like above
- File path includes: can be easily added via same code

Missing:
- Mirror delete of target files excluded by filters + added warning to user
- Dir includes same filters support as excludes
- cleaner code using arrays of original filters rather than analyzing pattern compiled filter

Maybe just add support of cases (1) and (2) for Mirror mode
Optionally file path is really easy to implement with the arrays instead of inspecting compiled filters like I did in my preview code. But it is your app, and I don't need that part as much as (1) and (2)
My preview code is rather dirty but it checks for all occurrences and can be improved with using filter arrays before pattern compiling the user entered filters. Or using a ready third party lib...
Hope you can give me a feedback with your position about these. I also understand your time is limited, like mine :-)

"*/cache/*" is currently available to the user, so the meaning cannot be changed.
Master directory="/master"

"*/cache" matches "/master/test/cache"
"/cache/" matches "/master/test/cache/any"

1.no way to exclude a /cache/thumbnails/ to match anywhere in path ....

Please use "cache/thumbnails"

2.Mirror mode: delete non matching occurrences in target to have a real mirror.....

I will merge your changes.

3.filter "/cache" doesn't work at all and never matches if we add a leading "/": n.............

If the beginning and the end of the filter is "/", error messages will be output.

4.File filter by path: useful to exclude a 1Gb /folder/thumbdata file and keep small.........

I think we're going to have to think about it in the future.
Best regards.

"/cache/" is currently available to the user, so the meaning cannot be changed.

Yes, agree, it is ok with:
filter = \\cache

1.no way to exclude a /cache/thumbnails/ to match anywhere in path....

Please use "cache/thumbnails"

Doesn't work because current code works as this:
- filter = "cache/thumbnails": forces pattern "^cache/thumbnails", so MUST BEGIN with pattern
  matches: cache/thumbnails
  not matched: test/cache/thumbnails
- current code supports */dir/* through filter = \\dir
- current code doesn't support */dir/subdir/* equivalent filters at all
- we can use 2 filters:  \\cache and \\thumbnails but it is not */cache/thumbnails/*

reproduce:
master = internal/temp
target = sdcard/temp
filter = cache/thumbnails

2.Mirror mode: delete non matching occurrences in target to have a real mirror.....

Outputs a warning message.

No warning is displayed and old files are kept in target, so target is not a real MIRROR of master
Other PC and android sync programs don't work like this in MIRROR mode
Acceptable in copy/move modes but not in MIRROR
reproduce:
Mode= MIRROR
master=sdcard
target=smb_host://sdcard

- sync before filter: Target is filled with */cache/* files
- I add filter = \\cache
- sync in MIRROR: target is not real Mirror because target */cache/* are not removed !

4.File filter by path: useful to exclude a 1Gb /folder/thumbdata file and keep small.........

I think we're going to have to think about it in the future.

Not really needed for me, but I think it is a good idea

Another issue by following the code:
in isDirectoryToBeProcessed() and isDirectorySelectedByDirectoryName():

we can use both simple include dir filter + include whole directory filter \\dir_name
however, in exclude, if exclude simple filter is entered by user, the  whole directory filter is ignored !
https://github.com/Sentaroh/SMBSync2/blob/b28c66bfed652e77b4a6758103d808f8d0c1c525/SMBSync2/src/main/java/com/sentaroh/android/SMBSync2/SyncThread.java#L3071

and
https://github.com/Sentaroh/SMBSync2/blob/b28c66bfed652e77b4a6758103d808f8d0c1c525/SMBSync2/src/main/java/com/sentaroh/android/SMBSync2/SyncThread.java#L2967
change else {...} by if (!filtered) {...}

I got your way to use filters, but I took time to test Include filters just for the feedback.
It has same erratic behavior as exclude filter because it doesn't support leading /
Either block user from entering leading / in filters or, better, add support to universal filters
.
examples

include filter */cache/*:

includes all */cache/* folders (expected), but not the cache folder in root
includes all files in root of master (not expected)
misses /cache in root

include filter /cache/

includes only /cache/* in root of master (expected ?)
doesn't include any file in all /cache/ subfolders (not expected)
includes files in root of master (not expected)

include filter */cache/thumbnails/

includes files in root of master (not expected)
includes all */cache/thumbnails/*
doesn't include /cache/thumbnails in root

will open an issue as it is a complex issue any my code is not complete (include filters not working)


fit_summary Error KeyError: 'trial_info'

I'm trying autogluon for the first time with a dataset of 75,000 data points and labels.
autogluon version 0.0.13
OS:
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.4 LTS
Release:        18.04
Codename:       bionic
Here is my predictor, it is a TabularPrediction with hyperparameter_tune turned on:
predictor = task.fit(train_data=train_data, label=label_column, output_directory=savedir, problem_type='binary', eval_metric='accuracy', hyperparameter_tune=True )
I tried with hyperparameter_tune  off and the task finished with no problem. Once I turned on hyperparameter_tune, it errored with the following error:
*** Details of Hyperparameter optimization ***
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-2-1b709fc952c0> in <module>
     11 predictor = task.fit(train_data=train_data, label=label_column, output_directory=savedir, problem_type='binary', eval_metric='accuracy', hyperparameter_tune=True )
---> 13 results = predictor.fit_summary()
     14
     15 # Inference time:

/usr/local/lib/python3.6/dist-packages/autogluon/task/tabular_prediction/predictor.py in fit_summary(self, verbosity)
    414                     hpo_model = hpo_results[model_type]
    415                     print("HPO for %s model:  Num. configurations tried = %s, Time spent = %s, Search strategy = %s"
--> 416                           % (model_type, len(hpo_model['trial_info']), hpo_model['total_time'], hpo_model['search_strategy']))
    417                     print("Best hyperparameter-configuration (validation-performance: %s = %s):"
    418                           % (self.eval_metric, hpo_model['validation_performance']))

KeyError: 'trial_info'

Thanks for pointing out this bug. I believe it should be fixed in this PR:  https://github.com/awslabs/autogluon/pull/678
if you'd like to install that version of autogluon locally and try it out.
Also just FYI:  hyperparameter_tune is currently not typically the best way to maximize accuracy in TabularPrediction. Instead consider specifying: task.fit(..., presets='best_quality') which utilizes stack-ensembling instead of HPO.
https://autogluon.mxnet.io/tutorials/tabular_prediction/tabular-quickstart.html#maximizing-predictive-performance

Thanks for pointing out this bug. I believe it should be fixed in this PR: #678
if you'd like to install that version of autogluon locally and try it out.
Also just FYI: hyperparameter_tune is currently not typically the best way to maximize accuracy in TabularPrediction. Instead consider specifying: task.fit(..., presets='best_quality') which utilizes stack-ensembling instead of HPO.
https://autogluon.mxnet.io/tutorials/tabular_prediction/tabular-quickstart.html#maximizing-predictive-performance

Thanks for the tip @jwmueller ! I will try that out!


[PowerApps-TestEngine - Feature]: Authenticode Certificate Validation

Is your feature request related to a problem? Please describe.
Provide a means of ensuring that MEF plugins for the Power Apps Test Engine are verified and only load plugins from trusted provides
Describe the solution you'd like
When loading MEF plugins:

Verify that the certificate and the certificate chain is valid
Validate that the root certificate provider is from a known allow list of providers

Describe alternatives you've considered
No response
Additional context?
No response

Consider the following code as a starting point for validation
using System.Security.Cryptography.X509Certificates;
var cert = X509Certificate.CreateFromSignedFile(@"C:\Users\grarchib\AppData\Local\Microsoft\PowerAppsCLI\Microsoft.PowerApps.CLI.1.31.6\tools\bolt.module.cli.dll");
var cert2 = new X509Certificate2(cert.GetRawCertData());
Console.WriteLine(cert2.Issuer.ToString());
cert2.Verify();
X509Chain chain = new X509Chain();
chain.ChainPolicy.RevocationMode = X509RevocationMode.Online;
chain.Build(cert2);
Console.WriteLine("Chain Information");
Console.WriteLine($"Chain revocation flag: {chain.ChainPolicy.RevocationFlag}");
Console.WriteLine($"Chain revocation mode: {chain.ChainPolicy.RevocationMode}");
Console.WriteLine($"Chain verification flag: {chain.ChainPolicy.VerificationFlags}");
Console.WriteLine($"Chain verification time: {chain.ChainPolicy.VerificationTime}");
Console.WriteLine($"Chain status length: {chain.ChainStatus.Length}");
Console.WriteLine($"Chain application policy count: {chain.ChainPolicy.ApplicationPolicy.Count}");
Console.WriteLine($"Chain certificate policy count: {chain.ChainPolicy.CertificatePolicy.Count}{Environment.NewLine}");
// Output chain element information.
Console.WriteLine("Chain Element Information");
Console.WriteLine($"Number of chain elements: {chain.ChainElements.Count}");
foreach ( var elem in chain.ChainElements ) {
Console.WriteLine($"{elem.Certificate.IssuerName.Name}");
Console.WriteLine($"{elem.Certificate.Thumbprint}");
}


feat(v2): Add edit url in post page

Motivation
Fix #2501
Add label option to edit page in blog as in  doc
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
go to a post page

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@yangshun I didn't found the part on the doc, that we mention about the blog config, to update. Do you think that would it be nice add? Only for the docs

Hi @lex111. Do I need to implement jest tests?

See test below as an example.
https://github.com/facebook/docusaurus/blob/32c1a92b17bdc347add828be97a49991c0611146/packages/docusaurus-plugin-content-docs/src/__tests__/metadata.test.ts#L63-L89


Update morale.py

Codecov Report

Merging #87 (95a2150) into master (a500089) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   84.29%   84.27%   -0.02%
==========================================
  Files          69       69
  Lines        5023     5023
==========================================
- Hits         4234     4233       -1
- Misses        789      790       +1

Flag
Coverage Δ

unittests
84.27% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

utils/basic/morale.py
93.54% <ø> (ø)

base/forms.py
67.33% <0.00%> (-0.26%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a500089...95a2150. Read the comment docs.


Zoom UI customizations - Android

Designs are here:
https://app.zenhub.com/workspaces/gooddollar-5d50833888a83c6880d3e345/issues/gooddollar/gooddapp/1861
adjust org.gooddollar.util.Customization class
commit directly to https://github.com/GoodDollar/ReactNativeFaceTec (master)
[x] add color constants
[x] customize according to the desIgns (could look UICustomization.web.js as an example)
[x] override i18n strings
[ ] make sure customization works and applies correctly (i18n should be apploed after SDK initialize)

@serdiukov-o-nordwhale isn't this task already implemented in #1861?

@iLystopad please do not add separate bugs related to the Android FV. Put all them here

Description: The user is logged in. The user is on the Face verification screen. The design of Zoom popup mismatch with the design on the web version
Steps to reproduce:

Tap on the "Ok, verify me" button
Tap on the "Got it" button
Pay attention to the "I'm ready" button
Tap on the "I'm ready" button
Pay attention to the "Frame your face" message

Actual result: The design of the Zoom popup mismatch with the design on the web version
Expected result: The design of the Zoom popup matches with the design on the web version
Environment: Android App [staging] Version 1.22.13-3 (1260)
Devices list: Device: Google Pixel 3a XL // Android 11
Attachment:

@Zhigamovsky there's a quick way to test FV on native:

checkout git@github.com:GoodDollar/ReactNativeFaceTec.git
go to example subdir and do npm i
copy .env.example to .env and fill with the following creds from GoodDollar QA :

REACT_APP_SERVER_URL, REACT_APP_ZOOM_ENCRYPTION_KEY, REACT_APP_ZOOM_LICENSE_KEY are defined in the Netlify's env
leave REACT_APP_ZOOM_LICENSE_TEXT empty
REACT_APP_SERVER_TOKEN is the GD_jwt local storage entry value (you have to be logged in)
REACT_APP_ENROLLMENT_IDENTIFIER could be found on https://goodqa.netlify.app/AppNavigation/Profile/ProfilePrivacy (labeled as "My Face Record ID"). You should be logged in as the same account from where you took GD_jwt

npm run android (from example subdir)

@Zhigamovsky
Any native design issues should be fixed in ReactNativeFaceTec package. The flow is the following - create branch, then PR
You'd need to update android/src/main/java/org/gooddollar/facetec/util/Customization.java. In this file we just assigning custom fonts/colors/etc to some props of the overlay, feedback and other customisation section.
To see the whole list of customization options per each section, please sign up on the dev.facetec.com and download Android SDK: https://dev.facetec.com/downloads
The docs you need are in facetec-sdk-javadoc-9.x.x subfolder
For this particular task you'd need to adjust feedback (for "Frame your face") and guidance (for the button) objects.
There're some differences in the options for web, ios and Android so not everything is possible to make the same exactly (for example there're no box shadows in Android you have to use elevation instead).
If you'll met with that issue - just describe here what you wasn't able to do and why.
Each npm run android from the example subdir also recompiles the root package

@Zhigamovsky

The "You need to stay on this screen..." message is not displayed on the FV uploading screen on the Native

Environment: Android App [staging] Version 1.22.13-3 (1260)
Devices list: Device: Google Pixel 3a XL // Android 11
Attachment:

The Animation of the FV uploading screen is a mismatch with the web version

Attachment:
Animation on the Web version -
https://www.dropbox.com/s/c7abv68b7602i71/Animation of uploading screen on web.mp4?dl=0
Animation on the Native -
https://www.dropbox.com/s/a8mx0ayfutsvv39/Animation of uploading screen on Native.mp4?dl=0

@serdiukov-o-nordwhale  @iLystopad regarding "you need to stay..."
Can you check what happens if user goes to his mobile home screen/switch to another app while in this screen?
this text might not be relevant for mobile. on desktop it stops the process, need to find out if that happens on mobile

@Zhigamovsky

The "You need to stay on this screen..." message is not displayed on the FV uploading screen on the Native

Environment: Android App [staging] Version 1.22.13-3 (1260)
Devices list: Device: Google Pixel 3a XL // Android 11
Attachment:

The Animation of the FV uploading screen is a mismatch with the web version

Attachment:
Animation on the Web version -
https://www.dropbox.com/s/c7abv68b7602i71/Animation of uploading screen on web.mp4?dl=0
Animation on the Native -
https://www.dropbox.com/s/a8mx0ayfutsvv39/Animation of uploading screen on Native.mp4?dl=0

@iLystopad

There's no options to add this text in the Zoom customization. For the web app we used CSS hacks with :before / :after pseudo elements to add it. This won't work on native. So on native we couldn't add this texts
Also, on native we couldn't use animated gif for uploading progress image. Also we couldn't disable default spinning animations. So we couldn't display Earth rotating in 3D. We could display some image with spinning 2D animation. I chose Earth icon looks like the gif from web version but from its pole view. It looks the much better with the limitations we have. Probably @Esfir-E would replace this image

@sirpy will be the same thing like on the web - session ends with context switch error.
This session return code defined on both IOS and Anrdoid SDKs:
CONTEXT_SWITCH
The Session was cancelled due to the app being terminated, put to sleep, an OS notification, or the app was placed in the background.

/** Represents the various end states of a Session */
typedef NS_ENUM(NSInteger, FaceTecSessionStatus) {
   // ..
    /**
     The Session was cancelled due to the app being terminated, put to sleep, an OS notification, or the app was placed in the background.
     */
    FaceTecSessionStatusContextSwitch,

@serdiukov-o-nordwhale  I can't see any options about height or size of buttons to match with web version buttons in FaceTec docs. So I just changed the background of feedback and upscaled font size for buttons.

@serdiukov-o-nordwhale @sirpy @Zhigamovsky The design of the Zoom popup matches with the design on the web version.
Environment: Android App [staging] Version 1.24.1-1 (1356)
Devices list: Device: Google Pixel 3a XL // Android 11
Attachment:


[Question] Is there a priority list of pending and enhancement features for those who would like to contribute?

Hello!
I would love to contribute to the project, I am wondering where @altmann you think time should be spent.  Do you have a list of priorities for features? Such as:

1.)  Is there a ToDo list of features which need to be implemented
2.) is there a Wishlist of Enhancements which would be nice to have added to the library?

Thanks for the awesome library!

Cool, thats great. I organise the open todos/enhancements in the issue list. Currently no open issues are ready to implement.
Signing the nuget package is a topic but for this topic I have to make a research whats the best way to do it because it's a big change for the lib.
Another topic is c# record support. This is also a big breaking change for the public api in the lib. Therefore its on hold in my head.

Another topic is c# record support. This is also a big breaking change for the public api in the lib. Therefore its on hold in my head.

I also think about it and can participate in the implementation, if necessary)


chore: bump kcl-lib version to v0.9.0-alpha.2

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[ ] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.252%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3328

Relevant Lines:
5346

💛  - Coveralls


bug: get more information on starknet_calls that take ~10s

Currently, there are some starknet_call queries that take a lot of time to run on Juno. Is it possible that we log the exact starknet_call the Kakarot RPC is making so that we can use these for benchmarking and testing.

@apoorvsadana can we close this?


Add view details for the product

📘 Issue Description
Add a Detailed Product View Modal
We want to provide users with a way to view more in-depth details about a product directly from the product card. This feature will enhance the browsing experience by displaying additional product information in a modal. For now, placeholder data will be used.
Task Details:

Button Design:

Add a "View Details" button to each product card.
Place the button in a prominent but non-intrusive location within the card.

Modal Design:

Clicking the button should open a modal displaying detailed product information.
Include placeholder sections in the modal for:

Product Title
Description
Price
Ratings/Reviews (optional)
Larger product images or image carousel.

Styling and Responsiveness:

Ensure the modal design aligns with the marketplace’s overall theme.
Make the modal responsive for different devices and screen sizes.

User Experience:

Add a clear "Close" button or icon to dismiss the modal.
Ensure the modal opens smoothly and does not disrupt the user experience.

Hello @danielcdz,
I’m a full-stack developer with experience working with Next.js and TailwindCSS. The to-do task seems clear to me, and I’d love to contribute to the project, hope to be assigned

I'm a fullstack engineer with years of experience. I can get this done in less than 3 days if assigned to me.

Background and Relevant Experience
I have experience building intuitive and responsive UIs with TypeScript and Next.js. I’ve worked on enhancing user interactions through modals and detailed product views, ensuring a smooth browsing experience.
Plan for Tackling the Issue

Add a "View Details" button to each product card.
On click, open a modal with placeholders for product title, description, price, ratings, and images.
Ensure the modal matches the existing theme and is responsive.

GM GM!  I’m a frontend developer excited to join in as a new contributor—looking forward to collaborating!
Adding a Detailed Product View Modal
Button Design
I’ll add a "View Details" button to each product card, ensuring it’s easy to spot but doesn’t clutter the design.
Modal Design
Clicking the button will open a modal. The modal will include placeholder sections for:
Product Title
Description
Price
Ratings/Reviews (optional)
Larger product images or an image carousel
Styling & Responsiveness
The modal will match the current theme and be fully responsive for both desktop and mobile.
User Experience
I’ll include a clear "Close" button and ensure smooth transitions to make it feel natural.

Hello @danielcdz! My name is Kevin Latino, and I'm a frontend developer and active open-source contributor. I'm a member of Dojo Coding, a thriving Web3 community in Costa Rica. I have experience with React, Next.js, and TypeScript, also I have experience in data fetching and API integrations and I recently won the LATAM Hackathon hosted by Base.  I've also contributed to projects in ecosystems like Starknet and Stellar.
I will add a "View Details" button to each product card. Clicking the button will open a modal displaying product details such as title, description, price, ratings/reviews, and a larger image or carousel. I’ll probably implement this using useParams to filter by the product ID, ensuring the correct details are shown for each product. I will be careful with the responsive design
I think I can finish this in 5 hours

I would like to work on this issue

May I handle this issue?I can comfortably handle this issues

Hi, I'm Josué Brenes and I'll be working on issue.
I'm Dojo Coding member.⛩
I estimate this will take 1 day to complete.
How I Would Resolve This
To implement the feature of a detailed product view modal, I would follow these steps:

1. Button Design

Add a "View Details" button to each product card.
Placement:

Place the button at the bottom or near the center of the card, ensuring it is visible but does not overwhelm the design.

Styling:

Use a subtle yet clickable style with hover effects to make it interactive..view-details-btn {
  background-color: #007bff; /* Example primary color */
  color: white;
  border: none;
  padding: 10px 15px;
  border-radius: 5px;
  cursor: pointer;
}
.view-details-btn:hover {
  background-color: #0056b3;
}

2. Modal Design

Use a library (e.g., React Modal, Bootstrap Modal) or custom HTML/CSS to create the modal.
Structure:

Title: Display the product name prominently.
Description: Include placeholder text for the product description.
Price: Show the product price in bold.
Ratings/Reviews (Optional): Add placeholder stars or text.
Larger Product Images/Image Carousel:

Add a single large image or integrate a carousel for multiple images.

Example JSX for the Modal (React):
import React, { useState } from "react";

function ProductCard({ product }) {
  const [showModal, setShowModal] = useState(false);

  const toggleModal = () => setShowModal(!showModal);

  return (

{product.title}

      <button className="view-details-btn" onClick={toggleModal}>
        View Details
      </button>

      {showModal && (

            <button className="close-btn" onClick={toggleModal}>
              ×
            </button>

{product.title}

{product.description}

Price: ${product.price}

              ★★★★☆

      )}

  );
}

3. Styling and Responsiveness

Ensure the modal aligns with the marketplace's theme..modal-overlay {
  position: fixed;
  top: 0;
  left: 0;
  width: 100%;
  height: 100%;
  background-color: rgba(0, 0, 0, 0.5);
  display: flex;
  justify-content: center;
  align-items: center;
  z-index: 1000;
}
.modal-content {
  background: white;
  padding: 20px;
  border-radius: 10px;
  max-width: 500px;
  width: 90%;
  box-shadow: 0 4px 10px rgba(0, 0, 0, 0.1);
}
.close-btn {
  background: transparent;
  border: none;
  font-size: 20px;
  position: absolute;
  top: 10px;
  right: 10px;
  cursor: pointer;
}

Add media queries for responsiveness:@media (max-width: 768px) {
  .modal-content {
    width: 95%;
    padding: 15px;
  }
}

4. User Experience

Add a clear "Close" button or icon for dismissing the modal.
Ensure the modal opens with a smooth animation..modal-content {
  transform: scale(0.9);
  transition: transform 0.3s ease-in-out;
}
.modal-overlay.show .modal-content {
  transform: scale(1);
}

Ensure accessibility (e.g., focus trapping within the modal, keyboard navigation support).

5. Testing

Test the button's functionality:

Ensure the "View Details" button triggers the modal correctly.

Validate modal content rendering:

Confirm all placeholder sections (title, description, price, etc.) display as intended.

Test responsiveness across devices:

Ensure the modal adapts to various screen sizes.

Verify smooth animations and transitions for a polished user experience.

Deliverables:

Updated product card with "View Details" button.
A fully functional modal displaying placeholder product details.
Styled and responsive modal design.
Code tested for usability and cross-device compatibility.

My Background and How It Can Be Leveraged
Hello, my name is Derian Rodríguez. I am a passionate software engineer with over one year of experience. I am part of the Dojo Coding Community and have been actively contributing to open-source projects through OnlyDust. I have experience in frontend development using JavaScript/TypeScript, React, and Next.js. I would love to contribute and support the development of this project.
How I Plan on Tackling This Issue
I will add a "View Details" button on each product card.
I will implement a modal that activates when the button is clicked.
The modal will display placeholder data with all the mentioned fields.
I will ensure the modal's design is consistent with the marketplace theme.
I will make it responsive for mobile devices and different screen sizes.
I will include a clear button or icon to close the modal.

Hello, I am Ngoo a frontend developer with 2+ years of experience, I love to contribute to safeswap and solve this issue.
i would be:
1. adding a "View Details" button to each product card and also clicking the card should open the modal.
2. creating a modal displaying detailed product information.
3. including placeholder sections in the modal for:
- Product Title
- Description
- Price
- Ratings/Reviews (optional)
- Larger product images or image carousel.
4. ensuring the modal design aligns with the marketplace's overall theme and is responsive.
5. adding a clear "Close" button or icon to dismiss the modal.
6. ensuring the modal opens smoothly and does not disrupt the user experience.
EDT: 24 hours

I'd like to handle this task.
I am a Full Stack Developer with a strong background in blockchain and extensive experience in Next.js/React, TypeScript, and Rust. I’ve made over 45 contributions to over 15 projects in the OnlyDust ecosystem, solving complex issues and delivering efficient, scalable solutions.
MY ETA is 48hrs. Thanks

Can I take care of this issue?
i'm a frontend dev and a blockchain dev kindly assign :)

Can I work on this, please?

I am applying to this issue via OnlyDust platform.
Hi, I'm Qudus Adeyemi, a front-end developer with 2 years of experience. I had the opportunity to contribute to the previous OD Hackathon, where I improved the Starknet React documentation and developed a useWatchAssets hook to enhance wallet tracking functionalities and I have also contributed to Starknet Quest. I enjoy learning and tackling new challenges, and I see tackling this issue as a great way to deepen my understanding of dApps while contributing to the project.
For issue #78, I estimate it will take around max 24hrs to complete, and I'm excited to dive into the task and collaborate with the team!
To tackle this issue, I will be doing the following:
Pay attention to responsiveness and interactivity and other specs
Utilize the Dialog component from Radix UI to implement the modal design
Based on my experience, I will be implementing a design suited to the feature and fully  user friendly as required

Hi, I'm Juan Pablo Villaplana from Dojo Coding, I'd like to contribute to that SafeSwap issue from the Cachorro leader XD
Broski, I'd like to help you with this issue, let's see if we can get something together this end of the year on Only Dust hahaha

Can I tackle this one?

Mind if I try this one?

May I pick this up?
I would add a button on the product card and when the user clicks, a popup will emerge containing more details about the product and use the placeholder sections mentioned in the issue description. I would also add a close icon that closes the popup when clicked. I will ensure to make this fully responsive and make sure the design aligns with the theme of the marketplace before making a PR
ETA - 2 days

Let me try this one!

@danielcdz Thanks Buddy 🚀

Can I be assigned to this?  I am an experienced frontend developer with 3 years of experience.

How I Plan To Tackle This Issue
I’ll start by adding a “View Details” button to each product card in a spot that’s visible but not intrusive. When users click it, a modal will pop up showing more detailed product information, like the Title, Description, Price, Ratings/Reviews, and a larger image or image carousel (using placeholder data for now).
The modal will be styled using tailwind css to fit the overall theme of the marketplace and will work smoothly on all screen sizes. I’ll also make sure there’s a clear “Close” button so users can easily exit the modal without any hassle.
ETA: 24 hours.


Bug: Including another header with REG_CLASS may cause compilation failure

This bug is caused by a generated header applying its #define REG_CLASS in the wrong header.
Suppose we have two headers (A, B), each containing a registered class ClassA and ClassB. Suppose that ClassB inherits from ClassA, so header B includes header A.
If the generated reg_incl.generated.h includes header B's generated header first, which then includes header B with its REG_CLASS defined specifically for header B, during preprocessing header A's REG_CLASS will be expanded and filled with header B's REG_CLASS definition, resulting in mismatched functions.
The easiest way to reproduce this bug now is by adding a .Reverse() to DB.Types in Pattern_Class.GetIncl().

To solve this problem, we would need to compute the correct sequence of includes by always starting from "leaves" in the include dependency graph (e.g., headers that don't include other untraversed REG_CLASS headers). Note that this is impossible if there are cyclic header includes (if header A includes header B as well in this case, for example), but C++ cyclic header includes usually leads to cryptic compilation errors and is not a good idea to begin with anyway, so it might be reasonable to impose this limit on developers.

Addressed by the pull requests https://github.com/haraldwer/GDExtensionTemplate/pull/15 and tested by https://github.com/haraldwer/GDExtensionTemplate/pull/18.


Add additional FAQ to nuget-authenticate.md

I ran into this problem, so figured I'd add something to help others.

@vslee : Thanks for your contribution! The author(s) have been notified to review your proposed change.

IMPORTANT: When this content is ready to merge, the reviewer must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"

#sign-off


[Feature/multi_tenancy] Restore original exception handling expectations

Description
Restores the original exception handling behavior for connector transport actions
Issues Resolved
Resolves TODO from #2459
Open question: should the non-runtime exceptions be wrapped in an UndeclaredThrowableException rather than an OpenSearchStatusException?  I'm thinking probably.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

closing this PR in favor of https://github.com/opensearch-project/ml-commons/pull/2520


Connecting to IBM i system disables "workbench.editor.enablePreview" setting

Describe the bug
After installing the extension and connecting to a system I am missing the previewing of files, I'll try to explain.
Previously when left-clicking on a Python (.py)-File in the VSCode Explorer, VSCode would open the file in a "temporary tab",
meaning if you left-clicked on a different file, the tab from the one before would vanish.
This was indicated by the font of the tab-title being in italic.
To make an opened tab stay, you would have to double-left-click on the desired file.
This is great if you have lots of files in your projects and have to browse through them, trying to find the right one.
If every file I browse through remains in an opened tab, I have to manually close all the ones I didn't need, which can be quite a lot.
This here seems to be the setting in question. If I re-enable this, it works as before. "Code for i" seems to overwrite this somehow or something?

To Reproduce

Install "Code for i" Extension
In the VSCode menu select "File -> Preferences -> Settings"
Search for the setting "workbench.editor.enablePreview"
If not already enabled, enable it
Keep settings window tab open, connect to any IBM i system
Watch how setting gets disabled

Expected behavior
Don't automatically disable the preview-feature when installing the extension.
Screenshots
See above
Environment (please complete the following information):
VSCode 1.89.1
Other installed extensions:

kelvin.vscode-sshfs-1.26.1
mkloubert.vscode-deploy-reloaded-0.89.0
ms-python.debugpy-2024.6.0-win32-x64
ms-python.python-2024.4.1
ms-python.python-2024.6.0
ms-python.vscode-pylance-2024.5.1
ms-toolsai.jupyter-2024.4.0-win32-x64
ms-toolsai.jupyter-keymap-1.1.2
ms-toolsai.jupyter-renderers-1.0.17
ms-toolsai.vscode-jupyter-cell-tags-0.1.9
ms-toolsai.vscode-jupyter-slideshow-0.1.6
visualstudioexptteam.intellicode-api-usage-examples-0.2.8
visualstudioexptteam.vscodeintellicode-1.3.1

After some further testing, the above mentioned setting seems to get disabled every time you connect to any IBM i system.
For further visualization I could provide a video of the effect, unfortunately I cannot blur out sensitive data like system and user names with my capture software so I can't post this here, but I could DM this to you.

Hi @Max-E-Million ,
according to the code, this preference is indeed explicitly disabled when connecting 😐
https://github.com/codefori/vscode-ibmi/blob/88681a637b13a765bdad56762d2b8534420bee96/src/api/IBMi.ts#L901
And the reason why seems to be here: https://github.com/codefori/vscode-ibmi/issues/928#issuecomment-1295444916
@worksofliam can we assume the bug you mentioned in VSCode has been fixed and it's now safe to leave previews enabled? 😅

@sebjulliand I doubt it has changed since that is really how preview mode works.
I can play around with it in the coming days and see if anything has changed.


Update knife-block.gemspec

Opscode is now known as Chef :+1:

Closed with https://github.com/knife-block/knife-block/pull/40


Update test to compensate for datatype change in jwt sub (owner_id) claim.

owner_id in jwt has string datatype because ngx-http-auth-jwt-module only works with string datatypes (not int).
convert owner_id to int before testing equality against user_id field in the User model which is of type int.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (83e6a52) 89.69% compared to head (015d65c) 89.71%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   89.69%   89.71%   +0.01%
==========================================
  Files          26       26
  Lines         524      525       +1
==========================================
+ Hits          470      471       +1
  Misses         54       54

Impacted Files
Coverage Δ

user_service/tests/test_auth.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adding node status from new control index in control List API

:nut_and_bolt: Description: What code changed, and why?
Added the node status to point it to the new control index. Node status in the control items API is from new control index now.

:chains: Related Resources
https://chefio.atlassian.net/browse/STALWART-171
:+1: Definition of Done
The new control index structure now can handle the filters at the node level to support the filtering from the UI side.
:athletic_shoe: How to Build and Test the Change

Rebuild compliance service using rebuild components/compliance-service
Add some data from hab using chef_load_compliance_scans -D1 -N20 -M20 -T20
The API can used to fetch the data

curl --location --request POST 'https://a2-dev.test/api/v0/compliance/reporting/controls' \
--header 'api-token: ${get_admin_token}' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--header 'Content-Type: application/json' \
--data-raw '{
    "filters": [
        {
            "type": "start_time",
            "values": [
                "2022-07-06T00:00:00Z"
            ]
        },
        {
            "type": "end_time",
            "values": [
                "2022-07-11T23:59:59Z"
            ]
        }
    ]
}'

:white_check_mark: Checklist
All PRs must tick these:

[X] I have read the CONTRIBUTING document.
[X] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[X] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[X] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[X] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[X] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[X] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[X] Tests added/updated? (all new code needs new tests)
[X] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

Are string_tags the control tags?

@kalroy Yes string tags are control tags

please add one or two lines of descriptions to the new methods/functions created about what that method is doing.

Added comments.


Built the app but nothing happened

Hi,
I was attempting to build the facial recognition app but I couldn't get the app to work. Just to be sure if the build steps are correct, this is what I did:

I've replaced the API keys just like you've suggested
Git cloned your project and load it into Unity
Opened the 'Main' scene
Changed the build settings: SDK--> windows 10, UWP build type --> D3D, Debugging -- >Unity c# project
Build it
Open up the sln file
Edited the package.appxmanifest, basically changing the TargetDeviceFamily and MaxVersionTested entries
Changed the deployment target entries
Build the project, deployed,
Hololens shows the unity splash screen, point my hololens toward a picture of someone's face on my monitor screen but nothing happened.

My question is what went wrong?
-Ken

It should take a photo the first time it runs, and you should see red floating text saying "photo captured, processing". After that, air tap or click with the clicker to take another photo. If that doesn't work, check that you've granted the camera permission - see https://developer.microsoft.com/en-us/windows/holographic/holograms_101e#chapter_1_-_.22holo.22_world
Additionally, there's a section for Capabilities in Package.appxmanifest - I had to enable Internet (Client), Microphone and Webcam. Not sure why Microphone is necessary.
Also, if there were some error while you're in an attached debugging session in visual studio you should see the error messages in the Output tab
Thanks for being the first (that I know of) to test this!

k3nnywilliam,
Did you have to run your own version of https://github.com/UoA-eResearch/openface_mass_compare/blob/master/compare.py?

@LukeStephen - because https://github.com/UoA-eResearch/hololens_facial_recognition/blob/master/Assets/Scripts/GazeGestureManager.cs#L126 is wrapped in a try block, if the OpenFaceUrl isn't set to something valid or if the server is down, the app will still work fine for gender/age detection, just not individual recognition. OpenFaceUrl is optional.

@k3nnywilliam @neon-ninja enabling Microphone in VS capabilities fixed the issue, it then worked, very cool demo!!

@neon-ninja , sorry for the late reply. It works, awesome stuff! I'm wondering if you have any plans for real-time facial recognition?

@k3nnywilliam I hadn't planned on it, but it wouldn't be hard to do. Just add a coroutine that calls PhotoCapture.CreateAsync(false, OnPhotoCaptureCreated); every second or so. Feel free to submit a PR with that (configurable ideally).


Configure export classes

Fix mypy warning
client/cache/memory.py:4: error: Module "theine" does not explicitly export attribute "Cache"  [attr-defined]

@Yiling-J bwt thank for the library, great job.

@k0t3n
I conducted a simple test by creating a file and running mypy:
from theine import *
from theine import Cache

It didn't report any issues. Since I haven't used Python recently and I'm not familiar with mypy, could you please share how to reproduce the warning?

@Yiling-J
from theine import Cache

mypy example.py --strict

@k0t3n v0.4.2 released

Thank you, that was fast 🚀


What is the status of alternative persistence layers for RackHD

Has there been any progress on the alternative persistence layers for RackHD?  Specifically MariaDB/MySQL or Casandra?
Steve

Add @RackHD/corecommitters @brianparry @amymullins answer this question.

@wrestle1 We have partial support for Postgres but it is not actively tested so I'm not sure what its current state is.  At one time, there was an effort to support Cassanda but that is not actively maintained.


Fix: ASB-485 Pin Examination library document

Task
ASB-485 Pin Examination library document

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Issue with input: issue with input KeychainPassword: parameter not specified

Hi all,
I have exectued 13 builds without any problem. Suddendly without having change anything on the build nor the IOS porject file I'm getting this error message:
Issue with input: issue with input KeychainPassword: parameter not specified
This is what I have on the log:
+------------------------------------------------------------------------------+

| (4<EMAIL_ADDRESS>                               |
+------------------------------------------------------------------------------+
| id: certificate-and-profile-installer                                        |
| version: 1.10.1                                                              |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: go                                                                  |
| time: 2018-10-23T16:36:58Z                                                   |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[16:36:58] Start installing (golang) with apt-get
INFO[16:36:58]  * [OK] Step dependency (go) installed, available.
Configs:
 - CertificateURL: https://con***46a
 - CertificatePassphrase: ***
 - ProvisioningProfileURL: https://con***bcc
 - InstallDefaults: yes
 - DefaultCertificateURL: https://s3-***p12
 - DefaultCertificatePassphrase: ***
 - DefaultProvisioningProfileURL: https://s3-***ion
 - KeychainPath: /root/Library/Keychains/login.keychain
 - KeychainPassword:
Issue with input: issue with input KeychainPassword: parameter not specified
|                                                                              |
+---+---------------------------------------------------------------+----------+
| x |<EMAIL_ADDRESS>(exit code: 1)       | 5.56 sec |
+---+---------------------------------------------------------------+----------+
| Issue tracker: .../bitrise-io/steps-certificate-and-profile-installer/issues |
| Source: ...s://github.com/bitrise-io/steps-certificate-and-profile-installer |
+---+---------------------------------------------------------------+----------+

Any idea where this is coming from?

Hi @AlexandreRoba, could you please send us a build URL where you encounter this?

Hi the issue can be closed. The error happen because the Project type was set to android by mistake… this is a flutter project… Thank you for your quick reply
On 24 Oct 2018, 09:10 +0200, Bence Kubik<EMAIL_ADDRESS>wrote:

Hi @AlexandreRoba, could you please send us a build URL where you encounter this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Provide a way for href's to redirect to models within the trestle workspace

The href's in OSCAL files should correspond to where the files will ultimately be placed - but at the same time it would be useful for trestle to follow href's if files within the workspace are being worked on.
A simple approach would be to create a lookup table mapping href values to model types/names in the trestle workspace.  Perhaps a command like:
trestle href add catalog '../../../nist_catalog.json' nist_catalog
Then if trestle attempts to follow an href link it would first check if it is in the lut.
This may need to be linked to assemble if a certain directory structure is expected in the assembled models.

This is handled by ignoring the path entirely and just using the file name - and requiring that the file has been imported with the expected filename.  It works that way for ssp authoring and I think the same would apply for other commands - although this assumes the file is local and a url shouldn't actually be followed to a remote file.  But perhaps if the file is not found locally the url could be followed.

Appending a slack conversation (slightly redacted) below with this issue. This relates to the caching functionality #170 #372 That was partially implemented but never adopted.
My proposal would be we revisit and revise the paths document and make a decision from there.

Christopher Butler  12:46
How am I mean to structure the href in your profile?
12:47
for ssp-generate (doing some testing)
12:47
json
"imports": [
{
"href": "../../catalogs/800-53/catalog.json",
12:47
does not seem to work.
Frank Suits  12:47
it can be a uri or url and only the last bit is ignored
Christopher Butler  12:47
what do you mean the last bit is ignored.
Frank Suits  12:48
this is the way i decided to make them usable without changing them
12:48
http://nist/blah/blah/nist-800-profile.json
12:48
it knows it is a profile so it will only use the name of it in the href - i.e. nist-800-profile
12:49
i think that makes sense and work ok
Christopher Butler  12:49
So I have this
trestle author ssp-generate -p 800-53-high -o test_ssp
12:50
and in the profile (aka profiles/800-53-high/profile.json)
12:50
I’m refering to a catalog
Frank Suits  12:50
wait... one sec
Christopher Butler  12:50
and I get this:
trestle author ssp-generate -p 800-53-high -o test_ssp
WARNING:root:File /Users/chris/Desktop/trestle_test/catalogs/catalog/catalog not found for load.
Frank Suits  12:51
sorry - the catalog comes from href in the profile.
Christopher Butler  12:51
yes
Frank Suits  12:52
i'm looking
Christopher Butler  12:52
But something is going funny
12:52
Okay let me know.
Frank Suits  12:54
so you import the profile with name my_prof - and with ssp-generate you use -p my_prof
Christopher Butler  12:54
It’s finding the profile fine
12:54
it’s the catalog resolution that is failing.
Frank Suits  12:54
and what is your href in the profile?
12:55
ok i see it
Christopher Butler  12:55
../../catalogs/800-53/catalog.json”
Frank Suits  12:55
don't use catalog.json - use my_cat.json
Christopher Butler  12:55
but it’s called catalog.json?
Frank Suits  12:56
in other words - the .json is assumed to be something like nist-foo.json
Christopher Butler  12:56
That is super confusing to me.
Frank Suits  12:56
it is weird to have catalogs/catalog/catalog.json
Christopher Butler  12:56
But it’s not
Frank Suits  12:56
did you impmort the catalog as 'catalog'?
Christopher Butler  12:57
it’s ./catalogs/800-53/catalog.json
Frank Suits  12:57
oh i see
Christopher Butler  12:57
which is the path I put it (plus the relative path that needs to change)
12:57
let me zip it up
Frank Suits  12:57
that is a proxy for .../800-53.json
12:57
in a real app you would have 800-53.json
Christopher Butler  12:58
But That’s not the file I am operating on.
Frank Suits  12:58
and in trestle it becomes catalogs/800-53/catalog.json
Christopher Butler  12:58
So I think if we are operating on files in the trestle workspace.. the paths need to make sense w.r.t that trestle workspace.
12:59
otherwise .. I can refer to a file OUTSIDE the trestle workspace.
12:59
if we give imaginary aliases.. that’s a problem in my mind.
Frank Suits  12:59
well - i made an issue for this and i think it's a reasonable compromise.  it avoids having to change the href
13:00
it is just a simple mapping of mycat.json to catalogs/mycat/catalog.json
13:00
that is in effect what trestle does anyway
13:00
so i propose href's get interpreted as such
Christopher Butler  13:01
I don’t think anyone will understand that.
13:01
I’ve got a variant I could propose.
Frank Suits  13:01
well - they already have to understand that mycat.json becomes catalogs/mycat/catalog.json
Christopher Butler  13:01
but that’s an import
Frank Suits  13:01
but it is referred to by name as mycat
13:02
so in the href - only the name matters
Christopher Butler  13:02
Wait one second - hear me out.
13:02
So my issue is you are parsing a relative path that does not exist.
13:03
So a user needs to know how to translate that relative path.
Frank Suits  13:03
i'm completely ignoring the path in the href
13:03
i only extract the name
Christopher Butler  13:03
But what I showed you was a relative path.. . hence the confusion.
Frank Suits  13:03
normally that name would match the external name and the internal name
Christopher Butler  13:03
So here is my proposal on what we should plan for:
13:05
User has a few choices:

Provide a URI for an external document which is assumed to be a fully qualified path which works (aka you can just download it).
13:05
We can explore building a better loading capability. The caching capability we should revive and use.
13:06
We support an href: ‘trestle://model_type/model_name’ for these relative references. That way we know it’s for trestle. User can understand it is for trestle.
13:07
or 3) user provides the full relative path for trestle to the root folder.
13:08
the reason why I like this is for version (2) - we can add to ‘assemble’ a piece to decode those into proper URIs.
13:08
I’m happy to drop 3 btw.
13:09
But the magic assuming different paths becomes really confusing to me if we are not explicit about what it is.
13:09
We can test with a few foks.

Frank Suits  13:09
I think there is a disconnect somehow.  please find the issue where I diiscuss it and enter your suggestions.
13:10
it may be in review - but you can find it as authored by me
13:11
in my view the href is the same one used when importing the catalog.  And ssp-gen is the only thing that needs to know this internal mapping.
13:11
but yes it can be made explicit
13:11
trestle:// was my first thought
Christopher Butler  13:12
Okay I’ll comment there so we can let you rest.. My view of that is .. I don’t think we might know all of the possible combinations and that might cause us pain.
13:12
I’ll add it to the issue.
Frank Suits  13:13
well the downside is the user will need to change href or something
13:13
we could also not have the user import the catalog - and do it in ssp-gen via the href
13:14
or look locally and if not found go to the url.  many ways to do it.

Usecase

SSP is to be created
They create their own profile in trestle (or it is derived from a 3rd party generic one by importing it)
The catalog which is external reference data (such as NIST 800-53) remains external

High level design options

External references are not allowed, users must import into trestle.

PRO:

Users understand whenever changes are introduced from the catalog
Easier for trestle to manage

CON:

Decouples from a 'single source of truth' model
Users are required manually update - e.g. if upstream document changes adversely they will not automatically be made aware.

Challenge

The presumption is that for the exported file via 'trestle assemble' the user will then be making that directory tree available on a server somewhere

As part of the assemble process hrefs will need to be rewritten to be 'externally' valid.

Users get to provide a 'dist_root' (name tbd option) that can be added to the directory tree

NOTE: Should we flatten the 'dist' output to be one directory.

"href"= "trestle://catalogs/800-53" -> file path in trestle project dist/catalogs/800-53.json
trestle assemble --all --dist-root 'https://ibm.com/oscal'

https://ibm.com/oscal/catalogs/800-53.json

Current 'dist' presumption
trestle directory
/catalogs/foo/catalog.json
/profiles/bar/profile.json
/profiles/foo/profile.json
/dist/catalogs/foo.json
/dist/profiles/foo.json
/dist/profiles/bar.json
Revised 'dist' model ->CHANGE REQUIRED TO TRESTLE ASSEMBLE.
Model A - no contention - CHOSEN MODEL
/dist/foo-catalog.json
/dist/foo-profile.json
/dist/bar-profile.json
Model B - we could get in some trouble
/dist/foo.json
/dist/bar.json
trestle://catalogs/800-53 -> 800-53-catalog.json
#Document references inside of trestle directory
Option 1: UUID refs
"href" : "#uuid"

Bad as we would need to load every file (potentially inducing failure)

Or we could store a map

Project name style refs (as today)
catalogs/800-53/catalog.json
profiles/800-53/profile.json
"href" : "800-53.json"

To chris confusing
Treats the trestle project as flat, which it is not.
Can not infer which file type which is required for profile resolution (as profile hrefs can be catalogs or profiles).

'Trestle' path (preferred option)
trestle://catalogs/800-53

This is only valid within the current trestle project
All external references (even if it is within a 3rd party trestle project) are presumed to be single file object referred to by an absolute href.

Scenarios for hrefs inside of trestle projects

It's a file in the current trestle project which is referred to by 'trestle://' (OKAY and can be distributed)
It's a relative path (NOT OKAY)
It's an absolute href using https://, file://, sftp:// (OKAY but must never be a single file)


Microsoft.AspNet.Razor.Runtime.TagHelpers.RuntimeTypeInfoTest.Properties_ReturnsPublicPropertiesOfAdaptingType hangs on CoreCLR on Mac

Seeing hang on CI agent.

This is in Razor actually - https://github.com/aspnet/Razor/issues/638.


\r doesn't increase line number

The carriage return (aka CR, 13, or \r) is a line terminator but should not increment the line number.

Carriage return without following line feed is still a line terminator and should increment the line number.

I don't see line numbers specified in the ES6 spec. Why do you say CR should increment line numbers? This is not what I observe in the wild. For example
[glevi@dev1475 esprima{terminator}]$ node -e "console.log('/*\r*/]')" > foo.js; node foo.js

/data/users/glevi/esprima-glevi/foo.js:1
*/]nction (exports, require, module, __filename, __dirname) { /*
                                                                   ^
SyntaxError: Unexpected token ]
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:906:3
[glevi@dev1475 esprima{terminator}]$ node -e "console.log('/*\n*/]')" > foo.js; node foo.js

/data/users/glevi/esprima-glevi/foo.js:2
*/]
  ^
SyntaxError: Unexpected token ]
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:906:3

In this example \n increments the line number while \r does not.

As I understand it, it's not uncommon for text files to end with \r\n because most text editors deal only with \r, \n, or \r\n as a newline character (but not both at the same time).
I don't think we want \r\n to count as two increments to the line number from the parser as this is almost never the intention nor is it the behavior of most other things that deal with line breaks.

The spec doesn't say anything about line numbers, but it does specify line terminators, which I use to imply separation of lines (aka increased line numbers).

(Specifically: Many windows systems use \r\n to indicate a single line break)

Carriage return without following line feed is still a line terminator and should increment the line number.

Yep, the spec clearly lists a \r as a line terminator.

I don't think we want \r\n to count as two increments to the line number from the parser as this is almost never the intention nor is it the behavior of most other things that deal with line breaks.

That is true as well and also specified in the spec:

The sequence <CR><LF> is commonly used as a line terminator. It should be considered a single SourceCharacter for the purpose of reporting line numbers.

https://people.mozilla.org/~jorendorff/es6-draft.html#sec-line-terminators

To be 100% clear, we're all agreed that <CR> is a line terminator. Indeed, the first thing I said was

The carriage return (aka CR, 13, or \r) is a line terminator

The thing I'm arguing is that CR by itself shouldn't increment the line number (<CR><LF> clearly should). This is consistent with V8 and Unix and modern MacOS. Yeah, MacOS before OSX treated <CR> as a newline, but I don't see why we'd follow an old OS. Historically, esprima has tried to follow V8 for error messages.
@jeffmo mentioned that my node example might be demonstrating Unix's bias rather than V8. However if in your chrome browser console you do eval("\r]"), chrome will report the line number of the error as 1, while it will say 2 if you use \n.

Historically, esprima has tried to follow V8 for error messages.
Can't argue against that.

FWIW, Firefox reports the error in line 2.

I've signed the CLA 3 times...hopefully one of them will work.

Sounds like a V8 bug to me. No reason to copy it. Esprima follows the messaging, not necessarily the position of errors.

Can someone file a ticket for this? I feel that the conversation (e.g. ref to spec, V8 behavior, etc) is better handled in the ticket.

@gabelevi: I don't think github knows to re-run the CLA check unless you "touch" the diff somehow -- so if you've signed it, you're probably fine.
(If you really want the red stuff to go away, maybe add some whitespace to your diff, send it, delete the whitespace, then re-send just to probe things)

@ariya : Seems a little easier to keep the discussion all in one place if possible -- especially since there's already ongoing discussion.
There's definitely room for discussion here since it seems v8/chrome and ff/spidermonkey do different things here... I guess we just have to pick which one we want to follow. At this point I think @gabelevi makes a fair point that almost no systems (based on some quick googling) actually seem to break the line on  these days -- clearly with Firefox as one exception.
@michaelficarra: It sounds like you use CR -- can you talk more about some of the systems you use that follow this? It would be good to understand who we'd be misaligned with if we decided to take this.

@jeffmo In general or for this one in particular? In all cases, it diverges from the project practices so far and hence I propose it as an agenda item for the next meeting.

@ariya: At least this one -- although it'd be a shame to dissuade people from writing code for proposals up front even if the proposal might not go through. In this case the doability is obvious, but in many cases there's doubt or wonder about what it would look like if done. Having the change right in front of you often makes it much easier to decide if it's worth moving forward (code wins arguments, etc). I don't want to hijack this thread about processes, but I also don't want us to become slaves to them.
On waiting until the meeting next week -- it'd also be a shame to make @gabelevi have to wait a whole week for such a minor change. Can't we just work this through and get consensus from everyone here?

@jeffmo, @ariya is saying make the concept of "is a ticket required" an agenda item.... not discussing this.

Ahh ok, that makes sense -- sorry for the misunderstanding

https://people.mozilla.org/~jorendorff/es6-draft.html#sec-line-terminators

The sequence  is commonly used as a line terminator. It should be considered a single SourceCharacter for the purpose of reporting line numbers.

Thus :-1:.

In the traditional sense, it seems  returns the cursor back to the start of the line (but does not feed to the next line). This is useful for things like clearing a line on the console without scrolling existing output. LF is what actually moves to the next line.
The spec only talks about line terminators, but it says nothing about line numbers -- so I think that's where Gabe is coming from here.

@ikarienator: I think that line is just noting that <CR><LF> is a single line terminator sequence, as expressed in the grammar below.
How should we make a decision here? I think the order of precedence should be

Follow the ECMA spec
Follow other implementations
Follow common sense.

The spec
My impression is that the ES6 spec doesn't specify line numbering. I think consensus is that line numbering is unspecified, but if some people disagree (sounds like @ikarienator disagrees) we could reach out to TC39 to clarify. If they choose to specify it we'll just do whatever they say. Otherwise, we have to move on to...
Other implementations
I believe that historically esprima follows V8 on unspecified things (like error messages), though I believe this policy is changing. We do see Chrome and Firefox showing different behaviors here, so there definitely isn't consensus in other implementations on the right behavior. I would argue that we could also look at Windows, Unix, and OSX for support of a <CR> that is only a carriage return without a line feed, but OS's aren't what we normally look to when making these decisions.
Common sense
If the spec leaves it unspecified and if other implementations conflict, then I think we just need to use common sense. I think common sense is strongly in favor of a <CR> that doesn't increment the line number. The carriage return is the mechanism that moves the cursor to the beginning of the line. Some old operating systems (like MacOS before OSX) treat <CR> as a carriage return AND line feed, but modern OS's are pretty consistent at treating <CR> as a just a carriage return.
I should mention that this isn't the most important issue to me. This issue doesn't block me on anything.

The carriage return is the mechanism that moves the cursor to the beginning of the line. Some old operating systems (like MacOS before OSX) treat  as a carriage return AND line feed, but modern OS's are pretty consistent at treating  as a just a carriage return.

Forgive my ignorance, honest question here. Wouldn't <CR> as just carriage return imply that a<CR>b means both a and b exist in column 1 of line 1?

From http://stackoverflow.com/questions/12747722/what-is-the-difference-between-a-line-feed-and-a-carriage-return:

A line feed means moving one line forward. The code is \n.
A carriage return means moving the cursor to the beginning of the line. The code is \r.

Wouldn't <CR> as just carriage return imply that a<CR>b means both a and b exist in column 1 of line 1?

Yes, but "a" is overwritten (check for yourself in a terminal with echo -e 'abc\r-').
The character's mechanics and history are not relevant here, however, because the ECMAScript lexical grammar dictates both of the following:

<CR> code points are line terminators (thereby preventing potential collisions like the above)
<CR><LF> terminates only one line, in contrast to every other pair of consecutive line terminators (which terminate two lines, the second of length 0).

The character's mechanics and history are not relevant here

Agreed. This is what I've been trying to say.

I think the point has been made many times already that specifying "line termination" in the spec doesn't say much about "line numbering" -- especially if real-world mechanics prove disagreement on this kind of interpretation (chrome vs ff).
If we choose not to take \r as a line incrementor, that's fine -- but I still think pervasive real-world mechanics should dictate what we do here. What systems (editors, OSes, etc) other than Firefox treat \r as a signal to increment line numbers or move the cursor to a new line?

there are 3 choices:

CR increments line number.
CR does not increment line number AND cursor is set back to column 1.
CR does not increment line number ANS cursor is not set back to column 1.

Systems like consoles and editors implement choice 2. Javascript seems to imply choice 1. This PR seems to follow choice 3.
I'm not sure how you can read the specs language on line termination and not come to the conclusion of choice 1, but i don't personally see how choice 3 can be thought of as anything but a bug.
What advantage do you gain by not incrementing line number after every line terminator other than confusion?

Please note that V8 changed its behavior a few weeks ago, see https://github.com/v8/v8-git-mirror/commit/2050994d80:

Correctly parse line ends for debugging.
Instead of using only \n as line terminator, we now use the definition
in http://www.ecma-international.org/ecma-262/5.1/#sec-7.3

Chrome 41 (stable) is still using V8 4.1 and hence it doesn't get the above changeset yet. Only V8 >= 4.2 will have the new behavior.

there are 3 choices:

CR increments line number.
CR does not increment line number AND cursor is set back to column 1.
CR does not increment line number ANS cursor is not set back to column 1.

So how are line numbers used?  There are a bunch of ways to look up code.
node -e 'console.log("a\rb")' > foo.js

cat foo.js - This uses (3) and looks like b
vim foo.js - For me, this uses (2) and looks like a^Mb
emacs foo.js - For me, this uses (2) and looks like a^Mb
textedit & textmate - On my Mac, these both use (1)

How are line & column numbers used by non-humans? I'm not too sure. I bet @benjamn uses this stuff in recast and would probably prefer one of these behaviors.

Please read this again:

The sequence  is commonly used as a line terminator. It should be considered a single SourceCharacter for the purpose of reporting line numbers.

It basically implies that <CR> is  indeed a line terminator that increases line number, because otherwise this sentence doesn't need to be here. If you still think that is not clear enough, I filed a bug for ES6 spec here: https://bugs.ecmascript.org/show_bug.cgi?id=4141

The argument about how terminal show them is not relevant because cat doesn't specially process line terminators at all, its imply put it to the tty file. And different tty treats special control characters differently. The behavior that \n create a new line is basically incidental and this should not be an evidence on how you manage line number. For example, we have no reason to move column number when we see a \b; nor would we change the line number when we see a \v.
The argument about how editors show them is not too much relevant either because the editors you listed are all general purpose text editors. They have no reason to treat line terminators exactly like what a single language treats them, although ES5 does trying to comply to common usage of line terminators. Besides, vim and emacs show the \r as exactly a caret (^) and an M, which means they are none of (1), (2) or (3). Both emacs and vim will treat the \r to be two columns wide in their location indicators as well (for example, the [ in ^M[will be on col 3). I'm glad to see that modern GUI editors TextEdit and TextMate use (1). But to me it's still incidental. You may also find CodeMirror and Ace both use (1) as well.
It is wrong to use node to test this because the language node supports is too different from ES5/ES6. And since other implementations all move to recognize \r to be an actual "line terminator" as the spec implies, I think it's clear that we should comply to that as well.

I think the most recent change in V8 should settle this. If I have a test file test.js containing \r\r\r], then the most recent V8 shell (tested with 4.3.0) will give the following output:
test.js:4: SyntaxError: Unexpected token ]
]
^
SyntaxError: Unexpected token ]

@gabelevi, thanks for sticking with us as we sorted out this issue. I agree with @ariya that the recent change in v8 puts this matter to bed. I suggest submitting a bug to TC39 if we want to disambiguate further.
As far as this PR goes, I'm going to close for now. Feel free to reply further if you think this is the wrong course of action.
Thanks again!


Vendor updates for the Go codegen for KFservice

What this PR does / why we need it:
This PR pertains to the vendor updates for the go-client apis to be created for KFservice CRD using the kubernetes code-generator project.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #161
Related to PR https://github.com/kubeflow/kfserving/pull/177
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

This change is

Thanks @SachinVarghese !
/lgtm
/approve

/ok-to-test


Doc enhancement: provide comparison with py2neo ogm

I think it would be useful to include a comparison of neomodel with py2neo's OGM in the docs. It might help new users and possibly lead to more Neomodel users. Especially since Neomodel does not use Py2neo anymore (right?)

Yes, perhaps you could come up with a short paragraph? I am not familiar
with it.
On 19 Jan 2017 08:40, "mjmare"<EMAIL_ADDRESS>wrote:

I think it would be useful to include a comparison of neomodel with
py2neo's OGM in the docs. It might help new users and possibly lead to more
Neomodel users. Especially since Neomodel does not use Py2neo anymore
(right?)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/robinedwards/neomodel/issues/228, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ0YQ2fllL8Gp9EDikrNmXFJx8bzHOmks5rTxN5gaJpZM4LnyoK
.

Closing this, if you wish to contribute one I am happy to include it but they are apples and oranges


Spanish Bugs!

More tk
sometimes the locale is lost on login and logout?
Cancel/Ok buttons
Cancel/Next/Complete on Pledge gen
Error on log out: translation missing: es.devise.failure.user.unauthenticated (fixed in #1652)
User Page needs translated! (fixed in #1650 )
Weird behavior:
Insurance options - No se reset to Don't Know, both options in list. ( fixed in #1651  )
Database options not routing back to Spanish "Seguro Médico del Paciente"
Does not affect language pref.

What do you think about opening up longer term tickets for the cancel/ok buttons, and sometimes the locale being lost?
The cancel/ok button is a particularly hard one since we've rarely touched the multimodal since setting it up, and I don't think the text on a few buttons should hold up a more general launch. (though maybe @montanezp would disagree.)
The language not sticking on logout is a weird bug but not one that hits us hard, since at that point they aren't really interacting with patients I think?

I'll break this out into real tickets tonight at the hacknight!

All issues addressed or broken out into distinct issues.


chore: promote first beta version

Proposed changes
Quite stable for now after receiving some feedback around
Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#452  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Add notification message as env var

Adds this thing to show up when the env var NEXT_PUBLIC_NOTIFICATION_MESSAGE is set in the vercel config.

Also my vscode auto modified the CSS file based on the prettier config. We should modify the prettier config if this is not desired behavior.

@TvrtkoM @Robiquet Any idea how to solve this error in pre-rendering markets during the deployment process?

@TvrtkoM @Robiquet Any idea how to solve this error in pre-rendering markets during the deployment process?

You might need to pull latest staging into your branch as there have been some recent changes related to the market end