Support function invocations of the gql tag

Hi there 👋
When trying to use codegen on our app that uses graphql-request, I've tried the latest preset described here with the gql tag exported from graphql-request. Typings are all OK, but the app crashes at runtime:
index.js:514 Uncaught TypeError: chunks.reduce is not a function
    at gql (index.js:514:1)

Sorry about the useless stacktrace, I'm pretty sure it comes from here: https://github.com/prisma-labs/graphql-request/blob/6246ffe47d3a4f849e43a36d4bbfda7518571ebe/src/index.ts#L717
I believe that's because your gql tag only works when called as a tagged template literal, but not as a function, which seems to be the only way to benefit from TS module augmentation and to avoid manually importing TypedDocumentNodes spun by codegen. Do you think supporting both invocation kinds would be possible and something you might want to add to the lib? 🙏

I'm not using this tag function anymore, but instead importing the function generated by the new client preset. I'll keep this issue open nonetheless if other people stumble upon this.

@acidoxee , thanks for this thread and leaving it open.  You are correct, invoking as a tagged template literal, not function, worked for me.  🙏

Can you share a usage example of it being used as a function instead template tag.

Yeah that would be it, or more precisely the same with a magic comment, so that codegen can spot the presence of a document:
const query = gql(/* GraphQL */ `
  {
    company {
      ceo
    }
    roadster {
      apoapsis_au
    }
  }
`)

I believe the reason this codegen preset needs a "classic" function invocation is because TS doesn't enable properly typing tagged templates, or at least doesn't enable overloading its definition multiple times, which is exactly what the codegen preset does.

What is the benefit for you of using gql as a function like that? I get it circumvents the error. But what else?

I'm not sure I understand what you mean, so my apologies if I'm circling around.
I've just followed the guide from GraphQL Code Generator, and since I was already using graphql-request in my app, I thought it could be useful to reuse the already-present gql tag. You don't necessarily have to generate and use the gql function of the preset from the codegen, you can also be lighter and just generate type overrides for an existing gql function that's coming from another lib. You just have to indicate which lib it comes from.
But this doesn't work with graphql-request, at least at runtime, since it's a tag. Using it as a function invocation breaks. I totally get if you don't want to support such a function, I was just asking whether you had any intention of doing so. This doesn't matter to me anymore since I've moved to using the gql function that's generated by the preset's codegen.
I see that your README advises using graphql(gql`...`), where graphql is the function generated by codegen and gql is the tag from graphql-request, but the link to the example in GraphQL Code Generator seems broken. The latest example I could find from their side is this one, which doesn't use the gql tag from graphql-request anymore, which is exactly what I'm doing.
I hope that makes it clear for you, and sorry again if my feature proposition doesn't make sense or if it's moot 😉

Thanks, I still don't understand 😅 . I'm not sure about all those docs links (or ours). IIUC gal\...`` is to provide syntax highlighting and auto formatting. If you use it as a function, don't you lose those benefits, and if so, what's the point?

If that's the only benefit of using the tag, then indeed you're right. That's why we add the /* GraphQL */ magic comment. My bad for suggesting this, I'll close the issue. Thanks for your explanations and patience!

@acidoxee if there is anything that can be made more clear in the docs a PR is more than welcome!


"SyntaxError: unexpected token: identifier" with filenames with apostrophes

Details

Read the Docs project URL: https://readthedocs.org/projects/poliastro/
Build URL (if applicable): https://readthedocs.org/projects/poliastro/builds/9072047/
Read the Docs username (if applicable): Juanlu001

Expected Result
No JS syntax errors.
Actual Result

SyntaxError: unexpected token: identifier

Thanks for reporting this!
We inject these values from our sphinx extension, PR at https://github.com/rtfd/readthedocs-sphinx-ext/pull/66


Support configuration changes via redis.conf

Right now if someone needs a paticular thing configured for redis via redis.conf file it can only be done through a code change + image rebuild since we store the redis config in the code. We should add the possibility of changing the config at runtime.
Ideas:

could provide a file path through a flag on the operator - to change the the config a manual rolling restart would be needed on the redis cluster
could make the operator monitor changes to the ConfigMap and start a rolling restart of the redis nodes with the new config, the users would have to create/edit the configmap

We need to discuss it further. support configuration change will be very helpful but we cannot support all configuration changes. currently, some of the configurations are there to support our architecture of the operator . we need to think of a way to pass only some of the configuration that we are willing to change and document that

The point is to let users change the redis.conf without having to recompile and deploy the code.
We can make a list of supported configurations.

I came across this doc from kustomize what describes how changes in a ConfigMap are handled for a deployment. So when a ConfigMap used by a pod is changed, the pod is recreated as well. It does this by creating a hash of the ConfigMap and storing it as an annotation in the pod template of the deployment:
https://github.com/kubernetes-sigs/kustomize/blob/master/examples/configGeneration.md
I think we can to the same with the operator - after we store the redis.conf in a ConfigMap, we hash the CM and add it to the pod template on the RedisCliuster object.
The operator will have to monitor the ConfigMap resource for changes the same way it does with pods and RDCs.


esp32s2 programmer failed after second run on j4m6

I got some error message at try to program ch32v003's 8-pin package. It works on fresh chip but crashes when i try to upload new code.
Found ESP32S2 Programmer
Error: Setup chip failed. Got code ffffffff
Could not setup interface.

I also tried minichlink -u mode.
Found ESP32S2 Programmer
Entering Unbrick Mode
Connection starting
/0/ffffffff
/0/ffffffff
...
lots of ffffffff
...
ioctl (GFEATURE): Connection timed out
Error: Got error -1 when sending hid feature report.
Error: Flash is not unlocked (CTLR = ffeffdff)

Have you tried using the "-u" option of minichlink?  You need to let the programmer control power to the target if you aren't already.

I added power control circuit with pair of mosfets to GPIO11 and tried minichlink -u again.
Found ESP32S2 Programmer
Entering Unbrick Mode
Connection starting
/0/ffffffff
/0/ffffffff
/0/ffffffff
/0/ffffffff
/0/ffffffff
/0/ffffffff
/0/004c0c82
Flash unlocked
Whole-chip erase
Whole Chip Erase Code: 0

Seems to work. But when i try to program not working.
Found ESP32S2 Programmer
Error: Setup chip failed. Got code ffffffff
Could not setup interface.

Two thoughts:
I have seen situations where the whole-chip erase was unsuccessful - can you try minichlink -ua  If that works, let me know and I can make that default behavior.

minichlink -ua worked! I can reprogram chip without any issues now.


pdf2txt.py output getting a lot of (cid:#)

I run the pdf2txt.py tool to parse a pdf file and write the output to a text file. I am getting a lot of output like (cid:13), (cid:36), (cid:51) etc.
I wonder what are they? Is any way to remove them?

Hi @sean2176, thanks for raising the issue. Could you attach the PDF you are using to  your post. And also the script/command that you use. This helps us to debug the issue.
About cid: this is a font type that is often used to Chinese, Japanese or Korean characters. To convert these characters to text pdfminer.six needs a mapping: from each of the cid drawings to a corresponding unicode value. I expect that the mapping is not specified for the cid codes in your document. But I cannot test that without having access to it.

@sean2176 Just a quick bump as we're trying to sort through all the open issues. Are you able to provide the PDF in question so that we can look into this?

I get a (cid:1) on the second line of this pdf. It is a '+' character from a math font.
0chxb1dv.pdf

Same issue here. Here's the pdffonts output.
name                                 type              encoding         emb sub uni object ID
------------------------------------ ----------------- ---------------- --- --- --- ---------
FKSYYD+DFLiSong-W7-WIN-BF            CID Type 0C       Identity-H       yes yes yes    118  0
OWNXIQ+GraphSwift-Bold               Type 1C           MacRoman         yes yes no      17  0
RUJBWP+GraphSwift-Light              Type 1C           MacRoman         yes yes no      18  0
SDJKSN+GraphSwift-LightDCbook        Type 1C           MacRoman         yes yes no      51  0
SBSXZQ+DFSong-XB-80-Win-GB           CID Type 0C       Identity-H       yes yes yes    117  0
OJPEDQ+GraphSwift-LightItalic        Type 1C           MacRoman         yes yes no      19  0
OSLMVM+SimSun                        CID Type 0C       Identity-H       yes yes yes     50  0

I get a (cid:1) on the second line of this pdf. It is a '+' character from a math font.
0chxb1dv.pdf

If I copy the "+" character to somewhere else I get a different character. That means that the math font does not have a proper translation to unicode character. Thus I doubt if pdfminer.six (or any other tool) can recognize that the character is a + (by inspecting the content of the pdf) (not 100% sure about this)
@sean2176 can you provide the pdf you are having troubles with?

I had similar problem in my PDF, I could solve it by normalizing the PDF using mutools :
sudo apt install mupdf-tools

mutool clean mypdf.pdf out.pdf

I think it's also possible to normalize it with ghostscript :
gs -o out.pdf -sDEVICE=pdfwrite -dPDFSETTINGS=/prepress mypdf.pdf

@Colanim that's very interesting! Up until now I assumed that these kind of problems cannot be fixed, because the unicode translation is simply not stored in the pdf. But this assumes that in your case it was stored, and mutools was able to recover/repair it. Do you by any chance still have the pdf?

I do have the PDF but unfortunately this is confidential, I can't share it...

Mine was solved by neither mutool nor gs.
On Wed, Sep 9, 2020 at 1:26 AM Cola<EMAIL_ADDRESS>wrote:

I do have the PDF but unfortunately this is confidential, I can't share
it...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pdfminer/pdfminer.six/issues/368#issuecomment-689411090,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEEAGGO46JFN7Q64D5V5JCTSE432NANCNFSM4KP6ITRQ
.

Closing this because:

@sean2176 issue is not reproducible because no example pdf
@matthewmcintire 's pdf has does not have a correct unicode mapping, thus it cannot be fixed
@Colanim example is not reproducible because pdf cannot be shared

I'm most interested in PDF's where pdfminer.six extracts the wrong character, but some other tool/process extracts the correct character. Please create a new issue if you have an example like this.


Non-english hashtags not downloading

Hashtags with non-english characters are not downloading anymore with the latest version of Instaloader.
For example, this hashtag https://www.instagram.com/explore/tags/кошка/
instaloader "#кошка"
gives an error:
Errors occurred:
#кошка: Invalid hashtag #кошка

Downloading hashtags with foreign letters worked before the latest update (with both Windows and Linux versions).

Thanks for reporting! We released Instaloader 4.4.1 where this is fixed.


Reposition nodes in the graph

Is your feature request related to a problem? Please describe.
Hey! We would like to implement the feature of repositioning the nodes by dragging them, just as in this example: https://vasturiano.github.io/3d-force-graph/example/fix-dragged-nodes/
We are using the library with R3F so it is not possible for us to use 3d-force-graph as they use their own renderer and scene.
How hard would be to implement this feature? Is there an easy way on doing so or any guidance you could provide 🙏 ?
Really appreciate the work you have done with this library, is very valuable.
Thank you in advance 🚀

Hi @jesus4497, you should look into Three's DragControls object.
This is how the feature is implemented in the 3d-force-graph package. You can look at the implementation code for reference:
https://github.com/vasturiano/3d-force-graph/blob/284e837d4e61095b01a12f93d1508d971263e6c4/src/3d-force-graph.js#L244-L248

Hi @vasturiano ! I'm using resetCountdown method in order to keep the engine running while dragging the nodes as you implemented in your example, I'm also using nodePositionUpdate method to update the object positions manually. The thing is, when I update the nodes coordinates manually, the coords param inside nodePositionUpdate are not quite the same as the ones I specified.
For example, in this line of code: https://github.com/rebeckerspecialties/threejs-tests/blob/11cb1f83db1146554dc581e7505bd3bf8f30c074/src/drawables/NodeGraph/useDrag.tsx#L283,
I'm doing a foreach for every node that I want to change its position (my goal is to move multiple nodes at once) and updating its coords.
Lets say I want to drag the node down, so I change node.y coords to 4.292676329612732, the value that I get inside the nodePositionUpdate is 4.353615558547489, and the larger the loop is (the array is) the wider the difference is. Even if it is just one element dragging, the values are not quite the same, there's always a small difference.
Here is the nodePositionUpdate method: https://github.com/rebeckerspecialties/threejs-tests/blob/11cb1f83db1146554dc581e7505bd3bf8f30c074/src/drawables/NodeGraph/NodeGraph.tsx#L122
Is there something that I'm missing in order to make this 1:1? Thank you for your support as always 🙏


Playing stops when app goes to lock screen

Playing ogg file continues when app is in background . but when you push the lock button of device and device shows black screen the sound stops.
Can you help me solve this problem?
i'm not streaming. I play file from local path and Audio,Air Play and picture in picture capability is selected in my app capabilities section
when device is locked and i'm in lock screen file is playing. but when device is locked and device is showing black screen playing is stopped.

@hoomansanatkar any progress fixing this issue? I'm currently trying to fix it, but no progress so far.  I'm using OGVPlayerState and I found out that the Audio is being decoded when the phone is locked, however it does not seem to play any sound. Any idea @brion? Is this kit supposed to play audios in background?

I haven't tested background audio at this point, but it ought to work as long as the app's Info.plist declares the proper backgrounding mode for audio. The larger buffer size might be needed if the app's only being woken at intervals by the system (which is very possible! iOS is pretty aggressive about throttling background apps IIRC)

I have set proper background mode. Playing stops when phone is locked or user pressed home button.


Design issues related to superblock switching

Hi @geky
We know that when the super block is written more than block_cycles times now, it will trigger the process of switching super blocks. However, from the current observation, after switching blocks, will the two previously used super blocks be discarded. From a user's perspective, this will result in losing space for two blocks. May I ask why this design was considered at that time?

Hi @MBronsom, it's a good question.
Technically, the previous superblocks aren't discarded, they are just relegated to containing a single pointer to the active superblocks.
When this happens, the previous superblocks will be written to much less frequently, but will still be updated when the active superblock is moved as a part of wear leveling.
The problem is that we want to be able to move our root block so it can participate in wear leveling, but we also want something at a known location  (blocks {0,1}) so we can find our filesystem quickly during mount. Most logging filesystems scan the entire disk to find the most recently written block, but this does not scale well when the disk gets large.
The solution here is to start with the root at blocks {0,1}, but if we noticed a significant amount of writes to blocks {0,1}, we convert the root into a linked-list with the head residing at blocks {0,1} and the tail being the active root in the filesystem. Exactly when we expand the superblocks is a bit arbitrary, so we use block_cycles for this.
In practice, the number of writes needed to update the superblock at {0,1} grows extremely quickly. $c^n$ where $c$ is block_cycles and $n$ is the number of superblocks. So it's unlikely most filesystems end up with more than one or two superblocks.
SPEC.md has a bit more documentation on this: here, though I realize it's not documented well in DESIGN.md...

@geky , Thank you for your reply!
Does that mean, as long as the subsequent application of superblocks is not on 0/1, when balancing the wear of superblocks again in the future (for example, using 2/3 currently and applying for 4/5 later), will lfs recycle the 2/3 block?

Understood, thank you for your response.😊


Turn Wiki for Repo into User Guide

Andromeda needs a User Guide!
We should describe the project:

[ ] What Andromeda is compared to the data fetching.
[ ] Data limitations (starts getting crowded as data point numbers increase, especially with images).
[ ] What is QUEST?
[x] Different versions/releases of Andromeda (eg., QUEST 2023, latlonCover, Quest 2024) with descriptions and links to that particular version.
[x] Why some columns might be dropped and what to do about it (eg., #68)
[ ] Fetch data information:

[ ]  latlonCover info (including eg., #71)
[ ] SatRGB and general extra info (upcoming).

Once this is properly set up, we'll want to add links to the documentation from the README in the repo and in the HF repo:

[ ] Link to Docs in GH README
[ ] Link to Docs in HF README

Let's add a link from the App to the documentation too.

Let's add a link from the App to the documentation too.

As in this note on the GH README?

For instructions on building and running the Docker container see Developing with Docker.

No. Right now this is the main Andromeda screen running on huggingface:

My thought is users might visit the page and not realize we have a user guide. So my suggestion is to add a link to this page that opens the User Guide.

Ah, like with the data dashboard link to documentation. That seems like a good idea, though we still need to write most of the user guide.

Thoughts on organization of our user/admin guide:

Home page can give overview of Andromeda
QUEST page to discuss what QUEST is (sections for 2023, 2024, and on to the future). This could focus on descriptions, then point to appropriate Prior Configurations for more information on the technical details.
GUI-type page? Something to cover the limitations of space and similar.
Page with more details on Andromeda and the implementation:

Cover things like why some columns might be dropped, general column requirements.

Fetch data page:

Options for getting data
Tools that can be/are applied (latlonCover & SatRGB)

@johnbradley, think we should establish MkDocs documentation instead of keeping it in the wiki?

Since Andromeda is pretty mature I would just keep it in the wiki.


ddev auth ssh - Status: pull access denied for 984, repository does not exist or may require

Describe the bug
I'm typing ddev auth ssh or ddev start and getting this error:
1 error occurred:
        * Status: pull access denied for 984, repository does not exist or may require 'docker login': denied: requested access to the resource is denied, Code: 1

Failed to start ddev-ssh-agent container: failed to start ddev-ssh-agent: ComposeCmd failed to run 'COMPOSE_PROJECT_NAME=ddev- docker-compose -f /home/ar/.ddev/.ssh-auth-compose-full.yaml -p ddev-ssh-agent up --build --force-recreate -d', action='[-p ddev-ssh-agent up --build --force-recreate -d]', err='exit status 1', stdout='Sending build context to Docker daemon     258B
Step 1/6 : ARG BASE_IMAGE
Step 2/6 : FROM $BASE_IMAGE
', stderr='1 error occurred:
        * Status: pull access denied for 984, repository does not exist or may require 'docker login': denied: requested access to the resource is denied, Code: 1

'

what is going on?
To Reproduce

Expected behavior

Screenshots

Version and configuration information (please complete the following information):

Host computer OS and Version: Linux, Arch
Docker Desktop version: cli
ddev version information (use ddev version)

ITEM            VALUE
 DDEV version    v1.18.0
 architecture    amd64
 db              drud/ddev-dbserver-mariadb-10.3:v1.18.0
 dba             phpmyadmin:5
 ddev-ssh-agent  drud/ddev-ssh-agent:v1.18.0
 docker          20.10.10
 docker-compose  2.1.0
 mutagen         0.12.0-beta7
 os              linux
 router          drud/ddev-router:v1.18.0
 web             drud/ddev-webserver:v1.18.0

config.yaml contents for the misbehaving project (the part before the comments)
default config - first time use
Do you have any custom configuration (nginx, php, mysql) in the .ddev folder? If so, have you tried without them?
no

ok, it update to docker-compose v2.1.1 solved the problem.
sudo curl -L "https://github.com/docker/compose/releases/download/v2.1.1/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
sudo chmod +x /usr/local/bin/docker-compose
sudo ln -s /usr/local/bin/docker-compose /usr/bin/docker-compose


yarn start worked first time , but fails  with " error: Auth failed."  on subsequent tries

This is for  a tesco account

No changes have been made to config.ini

Works fine for  Asda credentials.

Ian - I'm getting this error too just now.  Did you resolve it?

no ,   been trying different accounts  with no luck.
Either tesco is blocking  or  the code needs changing
On Wed, Apr 22, 2020 at 4:39 PM FlyFoxUK<EMAIL_ADDRESS>wrote:

Ian - I'm getting this error too just now. Did you resolve it?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/paulmaunders/delivery-slot-bot/issues/55#issuecomment-617856564,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK2FCVNAFPBIV5QUJGQOBETRN4FTLANCNFSM4MOGFQJA
.

glad it's not just me  , appreciate the email
On Wed, Apr 22, 2020 at 4:39 PM FlyFoxUK<EMAIL_ADDRESS>wrote:

Ian - I'm getting this error too just now. Did you resolve it?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/paulmaunders/delivery-slot-bot/issues/55#issuecomment-617856564,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK2FCVNAFPBIV5QUJGQOBETRN4FTLANCNFSM4MOGFQJA
.


Update featured collection stats

Fixes https://issues.redhat.com/browse/SSP-2293.

Codecov Report

Merging #50 (708257a) into main (a8a2f56) will not change coverage.
The diff coverage is 0.00%.

:exclamation: Current head 708257a differs from pull request most recent head b527f32. Consider uploading reports for the commit b527f32 to get more accurate results

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   26.47%   26.47%
=======================================
  Files          55       55
  Lines         642      642
  Branches      136      136
=======================================
  Hits          170      170
  Misses        420      420
  Partials       52       52

Impacted Files
Coverage Δ

src/components/automation-hub/hub-card.js
5.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a2f56...b527f32. Read the comment docs.


Work Package wp-hx.csv

I would like to work on this please!

Results of Phase 1
wp-hx-results.csv

Results of Phase 1:
wp-hx-results.csv

I would like to work on this please!

Results of Phase 2:
wp-hx-results.csv

I would like to work on this please!

Results of Phase 2
wp-hx-results.csv
:

Results of Phase 2:
wp-hx-results.csv

I would like to work on this please!


Update RichSuggestBox.md

This URL https://unicode-table.com/ has changed to https://symbl.cc/

This repo is for the 7.x version of the toolkit, this document can be found in the source code for the RichTextBlock samples.


Tuna - Code Coverage

coverage_percentage.txt , to reflect the code coverage

unwanted files recorded in this PR. Will create a new PR with correct files to review


License

Excuse me, I wonder to know what is this project's license? Thanks a lot.

I added the MIT license to the repo.


fix: Amazon EC2 ID getting matched a lot

⚠ Pull Requests not made with this template will be automatically closed 🔥
Prerequisites

[x] Have you read the documentation on contributing? https://github.com/bee-san/pyWhat/wiki/Adding-your-own-Regex

Why do we need this pull request?
The EC2 regex was getting matched to almost everything that had hyphen in-between. Even bee-san was EC2 ID. :)
I have made it more specific. According to Amazon they all start with i-. Until 2016 there were 8 characters after the hyphen and since 2016 there are 17 characters.
Source: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/resource-ids.html
I also think characters are a-f but I am not 100% sure about it.
What GitHub issues does this fix?

Fixes #200

Copy / paste of output
Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below:
$ poetry run pywhat i-1234567890abcdef0

Matched on: -1234567890
Name: Phone Number

Matched on: 123456789
Name: American Social Security Number
Description: An American Identification Number

Matched on: i-12345678
Name: Amazon Web Services EC2 Instance ID

Codecov Report

Merging #229 (f1ed9d4) into main (6162ace) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   92.60%   92.60%
=======================================
  Files          15       15
  Lines        1217     1217
=======================================
  Hits         1127     1127
  Misses         90       90

Impacted Files
Coverage Δ

pywhat/what.py
81.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6162ace...f1ed9d4. Read the comment docs.

Matched on: -1234567890
Name: Phone Number

false positive ⏰


Player adaptation

Can you add support for potplayer? It's really easy to use

As per https://github.com/Syncplay/syncplay/issues/218 our understanding is that PotPlayer does not support being controlled by Syncplay so this is not a feature which we can offer. We recommend people use mpv or mpv.net.


added support for rp235x, fix for dht11, porting to embedded-hal 1.0.0

Misc:

porting to embedded-hal 1.0.0
added support to Raspberry PI Pico2 (rp235x). You can select the MCU by cargo build --feature rp2040 or cargo build --feature rp235x with target MCU thumbv6m-none-eabi (pico), thumbv8m.main-none-eabihf (pico2 arm mode) and riscv32imac-unknown-none-elf (pico2 riscv mode)
support (fix) and testing for DHT11 on pico and pico2 arm
test for DHT22 on pico and pico2 arm

note: I think we need rust 1.82 for supporing #[unsafe(link_section)]

Hi !
Nice PR thank you !
Indeed this code is a bit old and I was very young in Rust dev ^^.
Can you update the README, to explain the "build features" ?

Hi !
Nice PR thank you ! Indeed this code is a bit old and I was very young in Rust dev ^^.
Can you update the README, to explain the "build features" ?
Thanks for the positive review!

My english is very bad, please check if is ok.

Any news?

Sorry for the delay ^^

Version 0.6.1 is published on crates.io (due to an old error version 0.6.0 already exists on crates.io....but yanked)


Visualize results of simulation run on original NC9 and NC9rev with water levels offset by 0.5 ft (0.15 m)

Motivation for using 0.5 ft instead of 0.7 ft. Deriving offset from NOAA verified - predicted is more defensible (does not hide model errors) compared to NOAA verified - modeled
Comparisons of NOAA predicted vs verified (observed) water levels are done. For the month of October 2021, NOAA verified water levels were an average of 0.51 ft higher than predicted values.

I was also curious how the NOAA predicted versus verified stacked up against the ADCIRC modeled vs NOAA verified over the Nov 9-14 timeframe that we used to come up with the 0.7 ft=0.21 m WL offset. That comparison is shown in the tables below.

I still have questions about why we would use the predicted NOAA water levels to determine the ADCIRC offset instead of the modeled results. I understand that the NOAA 'Actual' water levels are influenced long term effects that both ADCIRC and the NOAA 'Predicted' water levels do not capture. However, 'Predicted' water levels do not capture what I will call medium-term effects, like wind setup for example, that would be captured by modeled water levels. To me, it makes sense to parse out the long-term effects that ADCIRC cannot simulate by comparing it to model results that include medium-term effects, not just precited tidal harmonics. It seems to me like we would want to address biases in the model through the WL offset by comparing modeled results to actual results.
Originally posted by @ththelen in https://github.com/NCSU-CHAZ/Sunny-Day-Flooding/issues/9#issuecomment-1208502743

@ththelen These simulations are finished and posted on the cluster here:
/share/jcdietri/For/Thomas/220819-NC9+0.15m-Nov2021
/share/jcdietri/For/Thomas/220820-NC9rev+0.15m-Nov2021

Hi @caseydietrich and @anardek, I finished calculations and visualization for the latest set of ADCIRC model results, and the results are very encouraging! In the attached PowerPoint you will find plots comparing the CB NC9rev+0.15m with FIMAN gauge data and results from all of our other runs. I have also included results comparing Wilmington and Wrightsville NC9rev+0.15m time series with the original NC9 results at these locations. Finally, I have calculated the RMSE between model results and NOAA/FIMAN gauge data at all locations to quantify the improvement we have seen in our model results. Takeaways from the plots and RMSE results are below.

Adding the +0.15m offset and refining bathymetries around Carolina Beach both reduced RMSE compared to FIMAN gauge data.
Carolina Beach RMSE compared to FIMAN is lower than Wilmington and Wrightsville RMSE compared to NOAA. If this is a reflection of the mesh improvements that we have made around CB, this is noteworthy give the complexity of the hydraulic connections around CB compared to the open ocean gauge at Wrightsville and Cape Fear gauge at Wilmington. Note that the RMSE of the original NC9 mesh at CB was about 0.2 ft higher than at Wilmington and Wrightsville.
I think we are close to having our ADCIRC mesh substantially complete. The only lever I can think of tweaking at this point is refining the stair stepped Snows Cut mesh bathy adjacent to the Cape Fear.

20220825-NC9(rev)+0.15m.pptx

Look at inlet resolution, and how it is reflected in ADCIRC model


Clean up child processes on SIGINT (CTRL-C)

The current behavior when we CTRL-C seems to be that the 'exit' event is not dispatched on the parent process until all spawned processes exit, resulting in orphaned processes when a spawned process doesn't handle SIGINT correctly. Cleaning up child processes on SIGINT handles this scenario.

This resolves Issue #71


Fix kind load command for kfp image.

Why are these changes needed?
In recent transform refactoring PRs, such as those for  ededup and tokenization, the kind load command is executed twice for the transform image in the kfp tests. This happens instead of executing it once for the kfp-data-processing image and once for the transform image. This issue can be observed in the logs of KFP runs in these PRs by searching for the kind load string.
This PR aims to address this issue.
Explanation of the Error:
To understand why kfp-data-processing:latest quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest is not loaded as expected in kfp-load-kind target let's look at the Makefile in kfp/kfp_ray_components:
in its first line it includes .make.defaults which defines DOCKER_REMOTE_IMAGE:
DOCKER_REMOTE_IMAGE=$(DOCKER_REGISTRY_ENDPOINT)/$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)

This is a recursively expanded variable, meaning its value is dynamically recalculated each time it is referenced, using the current values of any variables it depends on.
The recent transform refactoring PRs define the DOCKER_IMAGE_NAME variable in kfp_ray/Makefile as follows:
DOCKER_IMAGE_NAME = $(TRANSFORM_NAME)-$(TRANSFORM_RUNTIME)

Which is also recursively expanded variable, causing DOCKER_REMOTE_IMAGE to be as follows:
DOCKER_REMOTE_IMAGE=$(DOCKER_REGISTRY_ENDPOINT)/$(TRANSFORM_NAME)-$(TRANSFORM_RUNTIME):$(DOCKER_IMAGE_VERSION)

This explains why when executing kind-load-image target DOCKER_REMOTE_IMAGE equals to  quay.io/dataprep1/data-prep-kit/ededup-ray:latest.

Addressed in #890


Feat: add affinity trait to merge node and pod affinity

Signed-off-by: ZhongsJie<EMAIL_ADDRESS>Description of your changes

Fixes #3972
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

let's create a new trait affinity, merge them with https://github.com/kubevela/kubevela/blob/master/vela-templates/definitions/internal/trait/node-affinity.cue into the new one and deprecate the olds.

ok

LGTM, please also update the docs: https://kubevela.io/docs/end-user/traits/references

OK, I'll update it


Bold online users in Roomauth

This allows people who want to appeal their roomban to be able to identify the users that are online in that room.   I hope this is the most efficient way of doing it.

Pretty sure that won't work, considering Users.users is now a map.
I'm also not sure if Showdown needs a feature to display which staff members are online. I for instance don't want to be bothered by random PMs from some random guy who realized that I was online, despite not being in any of public rooms.

Would using u in targetRoom.users be better as it checks the rooms userlist rather than the all the users on the server?   Also sorry about the Users.users thing; I forgot it changed.

Always test against the latest master branch of the server. (e.g., git rebase to it)
Also, since this is a small minor commit, keep it as a single commit by squashing it

@sparkychild, we're still waiting for you to squash and fix the issues @kotarou3 commented about.

I'll get this done as quickly as i can. Having trouble trying to squash/rebase on a mac

I helped squash heh
(Praise Cloud9 /o/)

This breaks the alphabetical sorting.


Remove old contributor guide link

Just removing this for now, as we've done w/other EM repos, until the revised version is complete.

Hi @BryanLa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Bryan Lamos). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

#sign-off


AutoML for instruction generation

https://github.com/nlpxucan/WizardLM uses "Evol-Instruct" , better results than alpaca and vicuna.
https://arxiv.org/abs/2304.12244 (edited)

https://github.com/h2oai/h2o-wizardlm


Is there any way to truncate string?

https://github.com/lunet-io/scriban/blob/master/doc/builtins.md#stringtruncate ?


Fix failing tests

This is still a WIP, but want to see if travis likes it or not

Alright - there are still other tests that are failing from time to time, but this fixes at least three of them. @dergraf take a look when you have time for it.


Update testing-android.md

Added link to directly download the apk of the app center app

@ahdbilal : Thanks for your contribution! The author(s) have been notified to review your proposed change. @Zakeelm

@ahdbilal since you're a team member changes should be opened in our private mirror: https://github.com/MicrosoftDocs/appcenter-docs-pr/pull/1861
For this small of a change, you can target the master branch and our system will run automated checks. Once completed, you can comment #sign-off to auto merge it, no reviews required.

@King-of-Spades this never got fixed. Should I make a new PR or can this one be revived?

@lacostej Sorry about the oversight and thanks for reaching out.
At the time I closed this, I was closing all public PRs by our internal team members. For several reasons, but essentially for the purposes of long-term maintainability, consistency & efficiency (thanks to docs QA tooling.)
It wasn't my intention to block valid changes, in hindsight I should've immediately opened a private PR and just asked the author if they could confirm (and it would've been visible in my inbox if it still got forgotten).
I can't reopen this PR because the source branch was deleted, but I've created a new internal PR, and assuming no other urgent issues come up I expect it to be live by EOD.


[SPARK-25044][SQL][followup] add back UserDefinedFunction.inputTypes

What changes were proposed in this pull request?
This is a followup of https://github.com/apache/spark/pull/22259 .
Scala case class has a wide surface: apply, accessors, copy, etc.
In https://github.com/apache/spark/pull/22259 , we change the type of UserDefinedFunction.inputTypes from Option[Seq[DataType]] to Option[Seq[Schema]]. This breaks backward compatibility.
This PR adds back UserDefinedFunctions.inputTypes: Option[Seq[DataType]], but does not add back the apply and copy methods, for 2 reasons.

the apply and copy methods in UserDefinedFunction are not meant to be public to end users.
Users can't call apply and copy with input types anymore. They must provide the nullability information to get corrected result.

How was this patch tested?
N/A

cc @srowen @gatorsmile

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2774/
Test PASSed.

Merged build finished. Test PASSed.

Test build #95598 has started for PR 22319 at commit e9c6fbc.

Test build #95598 has finished for PR 22319 at commit e9c6fbc.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95598/
Test FAILed.

Test build #95599 has started for PR 22319 at commit 5acb1df.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2775/
Test PASSed.

Test build #95600 has started for PR 22319 at commit 2245395.

Test build #95599 has finished for PR 22319 at commit 5acb1df.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95599/
Test FAILed.

Test build #95600 has finished for PR 22319 at commit 2245395.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95600/
Test FAILed.

Test build #95611 has started for PR 22319 at commit 01a51ca.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2786/
Test PASSed.

Test build #95611 has finished for PR 22319 at commit 01a51ca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95611/
Test PASSed.

Test build #95626 has started for PR 22319 at commit c77db87.

It's too hard to work around the case class compatibility issue. I'm leaving it unchanged, and add private mutable variables to store the nullable info.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2795/
Test PASSed.

Test build #95626 has finished for PR 22319 at commit c77db87.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95626/
Test FAILed.

I prefer the current way as well.

Test build #95630 has finished for PR 22319 at commit d290fec.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95630/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2811/
Test PASSed.

Test build #95644 has started for PR 22319 at commit 4791240.

Test build #95644 has finished for PR 22319 at commit 4791240.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95644/
Test PASSed.

Test build #95660 has finished for PR 22319 at commit 2b2c894.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95660/
Test FAILed.

Hm, still need one MiMa exclusion:
[error]  * the type hierarchy of object org.apache.spark.sql.expressions.UserDefinedFunction is different in current version. Missing types {scala.runtime.AbstractFunction3}
[error]    filter with: ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.sql.expressions.UserDefinedFunction$")

Shall we update migration guide about the compatibility?

I've fixed all the compatibility issues. Is there something else we want to let users know?

Test build #95691 has finished for PR 22319 at commit 9e060a4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95691/
Test FAILed.

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2857/
Test PASSed.

Merged build finished. Test PASSed.

Test build #95696 has started for PR 22319 at commit 9e060a4.

LGTM

Test build #95696 has finished for PR 22319 at commit 9e060a4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95696/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2860/
Test PASSed.

Test build #95700 has started for PR 22319 at commit 9e060a4.

Test build #95700 has finished for PR 22319 at commit 9e060a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95700/
Test PASSed.

thanks, merging to master!


Lua Error pop up in version 7.18

Description
When i get a pop up to delete or make sure i want to sell something i get an error
Version Number
7.18
Steps to Reproduce

open a vendor / right click on an item to bind it to me
immediate error pops up

Expected Behavior
should not get a Lua Error pop up
Actual Behavior

Only KkthnxUI Enabled
this happens when KkthnkxUI is the only addon enabled
Additional Information

Error Log
Message: Interface\AddOns\KkthnxUI\Core\StaticPopups.lua:249: attempt to call method 'SetPoint' (a nil value)
Time: 04/30/18 07:23:39
Count: 1
Stack: Interface\AddOns\KkthnxUI\Core\StaticPopups.lua:249: attempt to call method 'SetPoint' (a nil value)
Interface\SharedXML\SharedBasicControls.lua:208: in function <Interface\SharedXML\SharedBasicControls.lua:207>
[C]: in function SetPoint' Interface\AddOns\KkthnxUI\Core\StaticPopups.lua:249: in function <Interface\AddOns\KkthnxUI\Core\StaticPopups.lua:243> (tail call): ? [C]: in function StaticPopup_SetUpPosition'
Interface\FrameXML\StaticPopup.lua:4378: in function <Interface\FrameXML\StaticPopup.lua:4023>
[C]: ?
[C]: in function StaticPopup_Show' Interface\FrameXML\UIParent.lua:1218: in function <Interface\FrameXML\UIParent.lua:1011> [C]: in function UseContainerItem'
Interface\FrameXML\ContainerFrame.lua:1247: in function `ContainerFrameItemButton_OnClick'
[string ":OnClick"]:12: in function <[string ":OnClick"]:1>
Locals: errorMessage = "Interface\AddOns\KkthnxUI\Core\StaticPopups.lua:249: attempt to call method 'SetPoint' (a nil value)"
DisplayMessageInternal =  defined @Interface\SharedXML\SharedBasicControls.lua:191
MESSAGE_TYPE_ERROR = 0

Already fixed and updated here on github. It just hasn't hit Curse yet since there hasn't been a new tag yet. The version here should be updated, though.
Also a duplicate of the closed issue #95 :)

Fixed in https://github.com/Kkthnx-WoW/KkthnxUI/commit/b9419559784fb0ffbc3b8d2dd72ae3ed0fab7e23


ollama create can't access local files

ollama create -f some_file_path some_name should be able to access some_file_path, in order to import the files.  However, since it's a client to the docker instance, that doesn't work.
This is far from perfect, but I wrote this little script a while ago, before switching to harbor from my own setup.  It works by mapping the current folder to its equivalent that is mounted inside the ollama docker instance, and then dumping the appropriate ollama command to run:
#!/usr/bin/env python3

import os
import os.path
import sys
from pathlib import Path
import re

def main():
    this_dir = Path(sys.argv[0]).parent.absolute()

    try:
        gguf_path = Path(sys.argv[1]).absolute()
    except IndexError:
        print("No gguf file given to import!", file=sys.stderr)
        return 20

    if not gguf_path.exists():
        print(f"ERROR: expected {gguf_path!r} to be a valid, existing gguf file", file=sys.stderr)
        return 20

    if Path(os.path.commonpath((gguf_path, this_dir))) != this_dir:
        print(f"ERROR: expected {gguf_path!r} to be under {this_dir!r}", file=sys.stderr)
        return 20

    model_name = gguf_path.stem

    if "-of-0" in model_name:
        model_name = re.sub(r'-\d+-of-\d+', '', model_name)

    rel_gguf_path = Path(gguf_path.relative_to(this_dir))
    rel_model_path = rel_gguf_path.parent / f"{model_name}.model"

    container_root = "/data/llms/"

    container_gguf_path = container_root / rel_gguf_path
    container_model_path = container_root / rel_model_path

    with open(rel_model_path, 'w') as model_fp:
        model_fp.write(f"""FROM {container_gguf_path}\n""")

    print(f"Model file created/updated. To import, run:\n\nollama create -f '{container_model_path}' '{model_name}'\n")

    return 0

if __name__ == "__main__":
    sys.exit(main())

I think harbor does some similar llm folder mapping to share llm files with as many services as possible.  Perhaps not for ollama since it stores models in its own custom format for most files, but if mapping that llm folder in a standard way, then harbor ollama create could map the create file, if it's in that shared folder, at least.
NOTE: being able to create ollama models from modelfiles is very important, to be able to tune models with large contexts so that they use less context and therefore fit into VRAM.

Hi, ollama is one of the older services so it lacks the feature you're describing, many of the CLI services, however, do have it, I agree that allowing ollama CLI access to PWD is a good enhancement for usability when working with modelfiles

This was added in the v0.2.1, let me know if you'll manage to try it out!

Closing this for now, please feel free to follow-up or open a new issue if needed.


Update README.md

Summary

### Changes

Closes:
Task list

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

Global Creative Minds Architectural Group
We are pleased to introduce the Global Creative Minds Architectural Group, a dedicated team of architects, designers, and 3D visualization specialists committed to delivering exceptional architectural solutions across a wide range of projects. Our group combines creative innovation with technical expertise to meet the unique needs of our clients, whether they require residential, commercial, or institutional designs. With an in-depth understanding of design principles and industry standards, we consistently strive to create spaces that are both aesthetically captivating and functionally robust.
Our group is driven by a passion for creativity, which we cultivate through a collaborative work environment where ideas flow freely. We believe that every project offers an opportunity to explore fresh perspectives and push the boundaries of design. We engage in continuous brainstorming sessions, adopt the latest technology in 3D rendering and animation, and stay abreast of current architectural trends, allowing us to deliver visually stunning, cutting-edge solutions tailored to our clients' vision.
We have developed a comprehensive suite of services, encompassing the entire design process from concept to completion. Our offerings include detailed architectural drafting, realistic 3D modeling, and immersive walkthrough animations that bring our clients’ visions to life. These visual tools not only enhance our ability to communicate complex ideas but also empower clients to make informed decisions by providing a clear and tangible view of the final product.
At Global Creative Minds, consistency and quality are foundational to our work. Our structured design framework ensures every project maintains a high standard of precision and excellence. This approach enables us to balance creative exploration with practical constraints, meeting project deadlines and staying within budget. We understand that each project has unique goals, and we tailor our processes to align with our clients' business objectives while delivering innovative and enduring design solutions.
In addition to our technical expertise, we take pride in building meaningful relationships with our clients. We engage in open and frequent communication throughout each phase of a project, ensuring that we remain responsive to their needs and adaptable to any changes that may arise. Our commitment to transparency and collaboration fosters a trust-based relationship that enhances the overall project experience.
In summary, the Global Creative Minds Architectural Group brings a wealth of knowledge, creativity, and dedication to each project we undertake. We are excited about the opportunity to collaborate with organizations that value high-quality design and innovative solutions. Thank you for considering us as a potential partner, and we look forward to the possibility of working together to bring your architectural vision to life.
Warm regards,
Global Creative Minds Architectural Group

Gracia agradeciendo omar


Second screen infinite loading

Godot version:
3.2.2
OS/device including version:
Gtx 1080 nvidia drivers 452.06
Issue description:
If I try to start the main scene while the godot instance is in the secondary screen (which is a 4k screen and is not set as the main screen on windows) the scene loads indefinitely and remains blank (I attach screenshot) .
I have tried changing the primary display and it only ever works in the primary monitor regardless of which one it is

Steps to reproduce:
Play godot in a non primary screen
Minimal reproduction project:
Corso FPS.zip

Duplicate of #41907.


Example with clicking as opposed to dragging for entering moves

I guess by now I could probably do it myself, but it would be nice to have an example like 'Allow only Legal Moves' that instead of dragging uses clicking on starting and end squares.
I suppose combining 'Allow only Legal Moves' with 'Click to Create Arrows' would do the trick, but of course it would be nice if it was 'officially done' . Otherwise, I guess I will put it on my 'to do list'
Many thanks on a magnificent project. I have now Chessboard and Chessboard2 working very well. And eliminating jQuery also an added bonus...

Many thanks on a magnificent project. I have now Chessboard and Chessboard2 working very well. And eliminating jQuery also an added bonus...

Thank you! 🎉 🙏

This already works. Including the call to chess to validate moves....
let startingSquare = null
const game = new Chess()
const board = window.Chessboard2('myBoard', {
onMousedownSquare,position:game.fen()
})
const statusEl = byId('gameStatus')
const fenEl = byId('gameFEN')
const pgnEl = byId('gamePGN')
function onMousedownSquare (evt, domEvt) {
// clear any circles that may be on the board
board.clearCircles()
// do we have a starting square ?
if (startingSquare) {
// Input the move. We could validate with chess...
var mousemove = startingSquare+'-'+evt.square
console.log(mousemove)
board.move(mousemove)
// clear the startingSquare
startingSquare = null
} else {
// store the pending arrow info
startingSquare = evt.square
// put a circle on the starting square
board.addCircle(evt.square)

}
}
function byId (id) {
return document.getElementById(id)
}

And this is already a full working example !! What a versatile program!! (I know zero about programming )
/* Attempting to input moves with clicks, as opposed to dragging
Will validate moves with chess...  Fernando Semprun , February 2024 */
let startingSquare = null
const game = new Chess()
const board = window.Chessboard2('myBoard', {
onMousedownSquare,position:game.fen()
})
const statusEl = byId('gameStatus')
const fenEl = byId('gameFEN')
const pgnEl = byId('gamePGN')
updateStatus()
function onMousedownSquare (evt, domEvt) {
// clear any circles that may be on the board
board.clearCircles()
// do we have a starting square ?
if (startingSquare) {
// check move validity first
const move = game.move({
    from: startingSquare,
    to: evt.square,
    promotion: 'q' // NOTE: always promote to a queen for example simplicity
  })
  if (move) {
    // update the board position with the new game position, then update status DOM elements
    board.fen(game.fen(), () => {
      updateStatus()
    })
  } else {
    return 'snapback'
  }
// clear the startingSquare
startingSquare = null

} else {
// store the starting squaure
startingSquare = evt.square
// put a circle on the starting square
board.addCircle(evt.square)

}
}
function updateStatus () {
let statusHTML = ''
const whosTurn = game.turn() === 'w' ? 'White' : 'Black'
if (!game.game_over()) {
  if (game.in_check()) statusHTML = whosTurn + ' is in check! '
  statusHTML = statusHTML + whosTurn + ' to move.'
} else if (game.in_checkmate() && game.turn() === 'w') {
  statusHTML = 'Game over: white is in checkmate. Black wins!'
} else if (game.in_checkmate() && game.turn() === 'b') {
  statusHTML = 'Game over: black is in checkmate. White wins!'
} else if (game.in_stalemate() && game.turn() === 'w') {
  statusHTML = 'Game is drawn. White is stalemated.'
} else if (game.in_stalemate() && game.turn() === 'b') {
  statusHTML = 'Game is drawn. Black is stalemated.'
} else if (game.in_threefold_repetition()) {
  statusHTML = 'Game is drawn by threefold repetition rule.'
} else if (game.insufficient_material()) {
  statusHTML = 'Game is drawn by insufficient material.'
} else if (game.in_draw()) {
  statusHTML = 'Game is drawn by fifty-move rule.'
}

statusEl.innerHTML = statusHTML
fenEl.innerHTML = game.fen()
pgnEl.innerHTML = game.pgn()

}
function byId (id) {
return document.getElementById(id)
}


Document how to configure meilisearch

How do we change the payload size limit?  How do we add our options?

For incrasing payload size:

Change the payload size in Nginx:

Modify  the client_max_body_size in /etc/nginx/nginx.conf to the value you want.

Change the payload size in Meilisearch:

In the file /etc/systemd/system/meilisearch.service add --http-payload-size-limit at the end of the command in ExecStart= see the documentation

Then restart:

systemctl restart meilisearch

Should be in the docs, I move this issue :)


Implemented drag and drop by JS  (issue 1110)

Proposed changes
Implemented issue 1110
Tested both on chrome and firefox, works fine
Checklist

[x] Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

@dbudim Thank you for the PR! People do need a working Drag'n'Drop. :)

Current implementation only works on pages with JQuery. But nowdays JQuery is not so popular anymore. Can't we rewrite the JS code to work without JQuery? Probably http://youmightnotneedjquery.com/ can help.
Instead of having two methods $.dragAndDrop() and $.dragAndDropByJs(), it's probably better to have one method $.dragAndDrop() with parameters.

Then it would look like $.dragAndDrop(usingJavaScript()). See for example similar api for clicks: https://ru.selenide.org/2020/09/26/selenide-5.15.0/

@asolntsev done)
I found implementation on JS and used it, works fine)
Also moved solution to existed drag and drop command.
As for drag function there are no many arguments as for ClickOptions, i've just added overloaded version with boolean param:
dragAndDropTo(String targetCssSelector, boolean useJavaScript);
So we have regular$("#drag1").dragAndDropTo("#div2"); and JS $("#drag1").dragAndDropTo("#div2", true);
If it's ok, all is done, if need to make same as ClickOptions please tell, i'll do)

i've just added overloaded version with boolean param

it isn't smell good. I think FooBarOptions will be better.

i've just added overloaded version with boolean param

it isn't smell good. I think FooBarOptions will be better.

@BorisOsipov I've made this because i don't imagine what other options could be added to DragAndDrop command. So i thought that creating DragAndDropOptions for only one option is not needed) But if need make it for consistency with other commands I'll make it)
Should i move from boolean param to DragAndDropOptions ?)

@dbudim I can imagine quite many options: speed of moving the cursor, pause before, pause after, shift from the center of the element etc.

@dbudim I can imagine quite many options: speed of moving the cursor, pause before, pause after, shift from the center of the element etc.

@dbudim I can imagine quite many options: speed of moving the cursor, pause before, pause after, shift from the center of the element etc.

@asolntsev
Wow it's a great field for customisation) For me there was sufficient standart implementation )
Done)
Added dragAndDropTo(String targetCssSelector, DragAndDropOptions options);

@dbudim Wow, it's pure JS and it works in all browsers! Bravo!

@dbudim I think I will even enable JS mode by default. Because "actions" mode doesn't really work in any browsers.

@dbudim I think I will even enable JS mode by default. Because "actions" mode doesn't really work in any browsers.

Great)
Also I checked logs, even with spending time for reading js from file it works faster than regular actions)

Hi, when it will be possible to use this feature?

I am going to release Selenide 5.19.0 soon. Tonight or tomorrow.

Sorry for disturbing you, but I really need this feature about drag&drop, when will it be possible to update?

Tonight or tomorrow.

@vprystash Well, will release it today. For sure. :)


test: add regression test/fix for gh748 swap space creation

This commit adds a regression test for the manifest creation when custom disk are used. When just adding a swap device the rootlv size is not set/updated correctly which leads to a manifest like:
...
        {
          "type": "org.osbuild.lvm2.create",
          "options": {
            "volumes": [
              {
                "name": "swaplv",
                "size": "2147483648B"
              },
              {
                "name": "rootlv",
                "size": "0B"
              }
            ]
          },
...

for a config like:
"customizations": {
            "disk": {
                "partitions": [
                    {
                        "type": "lvm",
                        "minsize": "10 GiB",
                        "logical_volumes": [
                            {
                                "minsize": "2 GiB",
                                "fs_type": "swap",
                            }
                        ]
                    }
                ]
            }

and indeed, we test that config in our unit tests (test_manifest_disk_customization_lvm_swa) but we do not run the full osbuild validation on it :(
Closes: https://github.com/osbuild/bootc-image-builder/issues/748

This is partly my fault. @achilleas-k originally enforced the disk size everywhere, but I told him that I would like if the disk library is stayed with as few hardcoded values as possible, so he extracted it outside.
Maybe the custom pt generation code in images should check this case?

I think from an API PoV this is sensible, however ideally we would error in the partitioning if we encounter a zero size partition (IMHO).

Additionally, should we still enforce the min size of / of 2x the container image size as we do with the old partitioning? On the other hand, I can totally see cases when people don't want it. I actually fully expect some people not to ever run bootc upgrade because they will spin new instances and terminate the old ones. So they might not like the doubling...

This is a good point, we should probably fix that too, I think the issue is that for LVM the rules are different. IIRC when we create a disk with a minsize we will up the not-used space for "/". However with LVM we expect that (some) people will want to create  LVM partitions that have intentional space left so we do not auto-fill. So maybe this fix is actually wrong^Wnot ideal and indead it should put RootfsMinsize here instead of the hardcoded values. But then we have "/" and /"usr" and if we set both to rootfsMinsize (2x container size) we get a disk that is too big for cases where "/" and "/usr" are defined afaict.

#748
Same question.

Addressed by #750


metrics "certmanager_certificate_expiration_timestamp_seconds" confusions and questions

Hi, we are facing some issue with a custom alarm created in Prometheus:
certificate_expires_within_7_days.json
{
"alert": "CertificateExpiresWithin7Days",
"expr": "((certmanager_certificate_expiration_timestamp_seconds - time()) / 60 / 60 / 24) <= 7",
"for": "5m",
"labels": {
"severity": "CRITICAL"
},
"annotations": {
"summary": "Certificate expires within 7 days (name {{ $labels.name }})",
"description": "Certificate expires within 7 days.\n  VALUE = {{ $value }}\n  LABELS: {{ $labels }}"
}
}
As you can see, alarm is based on a query to certmanager_certificate_expiration_timestamp_seconds. It should be triggered EVERY TIME any cert managed by cert manager is about to expire in 7 days or less.
During tests I've created a service with certificate duration set to 10 minutes and renewal time set to 5 minutes.
kubectl get certificate -n netguard-smc nsmc-connector-was-was-check-cert3-crt -o yaml
apiVersion: cert-manager.io/v1alpha2
kind: Certificate
metadata:
creationTimestamp: "2020-08-18T12:41:19Z"
generation: 1
name: nsmc-connector-was-was-check-cert3-crt
namespace: netguard-smc
resourceVersion: "2813223"
selfLink: /apis/cert-manager.io/v1alpha2/namespaces/netguard-smc/certificates/nsmc-connector-was-was-check-cert3-crt
uid: fcabde86-4949-49d5-b772-352e948fa69d
spec:
commonName: nsmc-connector-was-was-check-cert3.netguard-smc.svc.cluster.local
dnsNames:

nsmc-connector-was-was-check-cert3.netguard-smc.svc.cluster.local
duration: 10m0s
issuerRef:
kind: ClusterIssuer
name: ncms-ca-issuer
keySize: 2048
organization:
Nokia
renewBefore: 5m0s
secretName: nsmc-connector-was-was-check-cert3-tls
status:
conditions:
lastTransitionTime: "2020-08-18T12:41:20Z"
message: Certificate is up to date and has not expired
reason: Ready
status: "True"
type: Ready
notAfter: "2020-08-19T10:56:20Z"

Cert manager is still sending metrics to Prometheus for the service:
certmanager_certificate_expiration_timestamp_seconds {
app = "cert-manager",
app_kubernetes_io_instance = "cert-manager",
app_kubernetes_io_managed_by = "Tiller",
app_kubernetes_io_name = "cert-manager",
exported_namespace = "netguard-smc",
helm_sh_chart = "cert-manager-v0.13.1",
instance = "wroclaw-farm-2003-18-auto-sec0423-1987-worker-01",
job = "kubernetes-pods",
kubernetes_pod_name = "cert-manager-676784f654-nwlfl",
name = "nsmc-connector-was-was-check-cert3-crt",
namespace = "ncms",
pod_template_hash = "676784f654"
}
value:<PHONE_NUMBER>
The cert has been renewed many times until now, but only one alarm has been created for this service based on values from the metric. From my point of view it seems that cert is renewed internally but for Kubernetes it is still the same instance of certificate/ secret that has been created on the service initialization a few hours ago, so any new alarm will not be created.
kubectl get certificate -n netguard-smc nsmc-connector-was-was-check-cert3-crt
NAME                                     READY   SECRET                                   AGE
nsmc-connector-was-was-check-cert3-crt   True    nsmc-connector-was-was-check-cert3-tls   22h
kubectl get secrets -n netguard-smc nsmc-connector-was-was-check-cert3-secrets
NAME                                         TYPE     DATA   AGE
nsmc-connector-was-was-check-cert3-secrets   Opaque   4      22h
kubectl get secrets -n netguard-smc nsmc-connector-was-was-check-cert3-tls
NAME                                     TYPE                DATA   AGE
nsmc-connector-was-was-check-cert3-tls   kubernetes.io/tls   3      22h
Questions:
Is the metric data from cert manager proper? It seems that the "Value" field for the metric is related with "notAfter" (expiration) field from the certificate, but sometimes it shows time value that should pass until cert is renewed (not expired).
If the expression from the alert (above) seems to be OK, why the alert is triggered only once event though the metrics are being sent be cert-manager

Does anyone can give some response for this issue please?

no response here so duplicate this issue to kubernetes community:
https://github.com/kubernetes/community/issues/5093

I reccomend upgrading from 0.13 as we improved the prometheus metrics a lot in https://github.com/jetstack/cert-manager/pull/2923

Looks like a duplicate of https://github.com/jetstack/cert-manager/issues/2248

Going to close this in that case, feel free to /reopen if needed
/close


Renaming mac addresses?

Is there a way to rename the mac addresses it finds? I know from most of them which they are. but i cannot find a way to rename them as i can in Unifi Network. Maybe it can be scraped by Unpoller from the UDM-SE?

MAC addresses get displayed when the devices have no names. Giving them names in the interface should change them to names instead of MACs. The only way to remove the old label values is to drop measurements though.


File Encoding should be given in command line

If I use !TOC and non-ascii chracters. I get following error.
  File "/home/atilla/anaconda/bin/markdown-pp", line 42, in <module>
    MarkdownPP.MarkdownPP(input=mdpp, output=md, modules=modules)
  File "/home/atilla/anaconda/lib/python2.7/site-packages/MarkdownPP/MarkdownPP.py", line 30, in __init__
    pp.process()
  File "/home/atilla/anaconda/lib/python2.7/site-packages/MarkdownPP/Processor.py", line 49, in process
    transforms = module.transform(self.data)
  File "/home/atilla/anaconda/lib/python2.7/site-packages/MarkdownPP/Modules/TableOfContents.py", line 119, in transform
    TableOfContents.clean_title(title)).lower()
  File "/home/atilla/anaconda/lib/python2.7/re.py", line 155, in sub
    return _compile(pattern, flags).sub(repl, string, count)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc4 in position 3: ordinal not in range(128)

I just came across about the same issue. Any suggestions how to resolve this?
Kind regards,
Peter

This is a bug due to the (poor) way that Python 2 deals with unicode strings.  If you can run this with Python 3.2 or newer, then it should work as expected.  If someone wants to improve the unicode handling to work with Python 2, I'd be happy to review a diff.


John conroy/transformation errors

Adds transformation_errors so we can easily determine for which datasets empty json was returned by the soft assay endpoint.

@john-conroy @lchoy do we need a full reindex on DEV for this PR?

@john-conroy @lchoy do we need a full reindex on DEV for this PR?

@yuanzhou No, not for this one. We have another PR coming soon to add new fields. A full reindex would be needed then.


multiple tag options

Hi. Hope that great project is still maintained...
I was hopping to add a support for multiple tag options, specifically for img ALT text in format of:
[img alt="text" width="100" height="200"]url[/img]
Defined CodeDefinition class and start playing with the code.
Unfortunately the parser didn't get to my code since the tag name is assumed to be up to the "]" character or the "=" where the assumption is that the format will always be [tag=option].
/* There could be an attribute. */
$tagPieces = explode('=', $tagContent);
$tmpTagName = $tagPieces[0];
Before I deep dive into the parser code...
Is there anything that was already done in that direction?
Thanks.

Support for multiple tag parameters was added years ago. We'd have to see your CodeDefinition implementation to be of any help.

Hmmm... Looks like I'm using a very old code...
Thanks.


Local test build doesn't easily allow for changing the  IMAGE_REGISTRY_ORG on all artefacts

When testing the build of Kabanero artefacts, there is no easy process to update the artefacts (ie the templates) to utilise an updated IMAGE_REGISTRY_ORG environment variable.
Currently the name of the IMAGE_REGISTRY_ORG is hardcoded within the images/image element in the collection.yaml file. If there is a need to test using a different value for the IMAGE_REGISTRY_ORG, then the collections.yaml file in each of the collections needs to be modified.
We need a method for being able to pickup the value of the IMAGE_REGISTRY_ORG environment variable when we update the templates for each collection with the image name defined in the collection.yaml.

A method of doing this is to have a variable within the collection.yaml that will be replaced when we update the templates.
Currently the collection .yaml has info like:
default-image: java-microprofile
default-pipeline: default
images:
- id: java-microprofile
  image: kabanero/java-microprofile:0.2

which has the image hard coded as kabanero/java-microprofile:0.2.
The suggestion is to have something like:
default-pipeline: default
images:
- id: java-microprofile
  image: $IMAGE_REGISTRY_ORG/java-microprofile:0.2

with the image as $IMAGE_REGISTRY_ORG/java-microprofile:0.2 so that the $IMAGE_REGISTRY_ORG portion will get substituted with the value of the IMAGE_REGISTRY_ORG environment variable (which will always default to kabanero)


[Bug]: kubectx/kubens Installing Old Versions

Feature id and version
ghcr.io/devcontainers-contrib/features/kubectx-kubens:1.0.2
Devcontainer base Image
No response
What happened?
Hello! So I'm not sure if this is technically a bug or just your intended behavior, but, due to a peculiarity in how kubectx/kubens does releases, this isn't actually installing the latest version of the programs that are written in Go, but the older, bash script versions.
Took me a while to figure out, but if you ACTUALLY want a version of kubectx/kubens newer than 0.8.0, you need to pull down the binaries from the releases, not the files names kubectx/kubens on the releases.
Are you intending to only offer the bash-based versions of these utilities, or would you be open to a PR to add support for the Go versions?
Relevant log output
No response

thanks @natescherer ! this is actually a bug and not my intended behavior, looking into it

I created #499 to fix this bug.


Did you compare the zero-shot segmentation performance between initial clip and your proposed image tokens decompositions ?

You can see the results here:
https://openreview.net/forum?id=5Ca9sSzuDp&referrer=[Author Console](%2Fgroup%3Fid%3DICLR.cc%2F2024%2FConference%2FAuthors%23your-submissions)


Added MathJax integration

Wanted to render Latex equations on myblog, integrated MathJax borrowing from this blog here.
If there were any mistakes please do tell me, this is my first Pull request.

I tested this on my own blog here : http://voletibhargav.me/simple-sorting-algorithms-insertion-sort/

Hi @bIgBV, unfortunately your fix works whenever the page is rendered as a whole (like the one you have in your blog), however ghostium uses https://github.com/defunkt/jquery-pjax to load a page without doing a browser reload so it'll only work if there's a post opened and only for the first time

To fix the problem you have to actually tell MathJax to re-render any latex like syntax every time a page is rendered, the hook needs to be in src/scripts
function _mathJaxSupport() {
  MathJax.Hub.Queue(['Typeset', MathJax.Hub]);
}

// PJax bindings
// =================
if ($.support.pjax && GHOSTIUM.enablePjax) {
  $document.on('pjax:start', function() {
    $surface.scrollTop(0);
  });

  $document.on('pjax:end', function() {
    _disqusHandler();
    _gaHandler();
    _disqusCounterHandler();
    _prismHandler();
    _mathJaxSupport();

    $('[data-load-image]', $content).each(function() {
      ImageLoader.load($(this));
    });
  });

  var _pjaxOptions = {
    container: '[data-pjax-container]',
    fragment: '[data-pjax-container]'
  };

  $document.pjax('a[data-pjax]', _pjaxOptions);

  $document.on('submit', 'form[data-pjax]', function(e) {
    $.pjax.submit(e, _pjaxOptions);
  });
}

Note that I'm invoking _mathJaxSupport() every time the plugin fires the pjax:end event
The fix doesn't end here since the production files need to be updated, I did the following:
(:warning:  WARNING: doing so will replace the contents of most of the generated stuff, make a backup of the local copy of the theme you have)

first of all run npm install on the theme
edit the contents of the src folder (don't edit assets/ or partials/ directly since they're likely to be overwritten)
run grunt dryrun
commit and push the newly generated production files to your server

Proof:

I dont think is a good ideia to have MathJax included OOTB.
Maybe we can add a "how to" page to explain how to add mathajx.

@maurizzzio thanks for that, I wasn't actually very sure of how to fix that :+1: .
PS: Sorry for the extremely late reply.


nomination-pools: Add extrinsic to start destroying a invalid pool

A pool can become "invalid" if the ratio of points to balance becomes too high. (This is because it increases the risk of saturating arithmetic - more details in the pallet docs.)
There should be a permissionless extrinsic that allows the destroy process to start (stop nominating and block any new joiners, etc) if the points to balance ratio becomes too high. In the future there may be other things we need to check as well.

Thinking about this more, we could just have a set_state_other that can be permissionlessly called when the pool is a. cannot be joined due to bad points:balance ratio and b. the state being set is destroying

This was implemented as the set_state_other extrinsic


Pull cluster addon images from gcr.io

Will do the same for e2e test images for #5007 after I finish uploading them.
cc @satnam6502, @zmerlynn

I can change the Makefiles for the Fluentd->ES, Fluentd->GCP, Elasticsearch and Kibana images in a different PR.

Oh, and I will also make gcr.io images for the node level images for Fluentd->ES and Fluentd->GCP

/cc @mattmoor

Awesome, thanks for the heads up.

LGTM except the quay/etcd question.

LGTM


Text overlaps when it naturally wraps to the next line

When text automatically line breaks and the next line starts with some specific characters like one of / [ ] -, subsequent text will overlap.
I realize there are other similar open issues but either fixes suggested don't solve the problem (eg. css from #1755), or are not quite the same thing. Definitely related to others though.
Pen:
https://codepen.io/mdbollman/pen/YzyNqzz
Specifications:

html2canvas version tested with: 1.0.0-rc.5
Browser & version: Mac Safari, iOS Safari, Mac Chrome, Mac Firefox, Mac Edge, Windows Chrome, Windows Old Edge
Operating system: Mac, iOS, Windows

Any good news here? I got the same problem: https://github.com/niklasvh/html2canvas/issues/2231

Hi folks. Any update on this? We keep on coming across issues on our website because of this.
Thanks!

Unfortunately this issue still exists. We haven't had enough time to look into fixing it ourselves either.

Hello everyone! Is there any update on this issue? Thanks!

Discovered the exact same problem.  Still no help?

Same problem here. A fix would be very much appreciated.

This should be fixed

the problem still exists in the latest version , so any resolution for this?

the problem still exists, and ios13 appears more frequently.

Any update on this yet? The text are not wrapping correctly even on the latest version. This is happening only on safari


How we can add current choose to open FMPhotoPicker viewcontroller again?

Step

We open and select multiple photos
After  done
We want to add current photo to see select inside pick photo again , disselect  and select other photo
how we can do it?
thanks

@peterkuch I don't think currently it's available. You probably need to fork it and adjust it accordingly


Key error with silicon molecule Coulomb Matrix

Hello,
I am having an issue transforming silicon, and I get a key error that does not happen with other molecules.  Example:
feat = CoulombMatrix()
CoulombMatrix(input_type='list', n_jobs=1, sort=False, eigen=False, drop_values=False, only_lower_triangle=False)

molecule = (['C', 'Si', 'C', 'C', 'C', 'C', 'C', 'C', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H', 'H'], [['-0.0826', '10.0417', '-0.0377'], ['1.6128', '10.8918', '-0.0081'], ['1.3492', '12.7774', '-0.0026'], ['2.5530', '10.3596', '1.5512'], ['2.5981', '10.3748', '-1.5446'], ['2.6254', '13.6396', '0.0079'], ['2.3479', '15.1502', '0.0131'], ['3.6226', '16.0004', '0.0206'], ['0.0178', '8.9494', '-0.0394'], ['-0.6547', '10.3212', '-0.9310'], ['-0.6841', '10.3156', '0.8378'], ['0.7395', '13.0408', '-0.8808'], ['0.7291', '13.0346', '0.8701'], ['3.5444', '10.8252', '1.6057'], ['2.6993', '9.2727', '1.5738'], ['2.0075', '10.6369', '2.4617'], ['2.7430', '9.2879', '-1.5742'], ['2.0803', '10.6627', '-2.4678'], ['3.5914', '10.8388', '-1.5650'], ['3.2366', '13.3895', '0.8874'], ['3.2452', '13.3971', '-0.8676'], ['1.7396', '15.4068', '-0.8659'], ['1.7339', '15.3998', '0.8902'], ['3.3907', '17.0717', '0.0241'], ['4.2347', '15.7895', '0.9063'], ['4.2401', '15.7966', '-0.8630']])

feat.fit([molecule])
feat.transform([molecule])

The error I get is
  File "C:...\molml\base.py", line 371, in transform
    results = self.map(self._para_transform, X)

  File "C:...base.py", line 280, in map
    return list(map(f, seq))

  File "...\molml\molecule.py", line 1126, in _para_transform
    if len(data.numbers) > self._max_size:

  File "C:...\molml\utils.py", line 379, in numbers
    temp = [ELE_TO_NUM[x] for x in self._elements]

  File "C:\...\molml\utils.py", line 379, in <listcomp>
    temp = [ELE_TO_NUM[x] for x in self._elements]

  File "C:\U...bidict\_base.py", line 374, in __getitem__
    return self._fwdm[key]

KeyError: 'Si'

Thanks for your help!  The error occurs at the transform but the fit works fine

I was also reading some of the closed issues and it looks like Si might be in the same category as Br?


Update 1_0_1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

I am fixing this in https://github.com/conda-forge/libblitz-feedstock/pull/11

Ah sorry. I am closing this one then

Could you see if you can fix the Windows build in #11 ? Otherwise we can disable the Windows builds.


Add support for graphql-core 3.2.0

Bump graphene minimum pin to 3.1
Only run push trigger on master branch
Remove poetry.lock ref https://stackoverflow.com/a/61076546/5511061
Fixes #26
$ pipgrip --tree starlette-graphene3@git+https://github.com/ddelange/starlette-graphene3.git@patch-1
starlette-graphene3@ git+https://github.com/ddelange/starlette-graphene3.git@patch-1 (git+https://github.com/ddelange/starlette-graphene3.git@patch-1)
├── graphene<4.0,>=3.1 (3.1)
│   ├── aniso8601<10,>=8 (9.0.1)
│   ├── graphql-core<3.3,>=3.1 (3.2.1)
│   └── graphql-relay<3.3,>=3.1 (3.2.0)
│       └── graphql-core<3.3,>=3.2 (3.2.1)
└── starlette>=0.14.1 (0.20.1)
    ├── anyio<5,>=3.4.0 (3.6.1)
    │   ├── idna>=2.8 (3.3)
    │   └── sniffio>=1.1 (1.2.0)
    └── typing-extensions>=3.10.0 (4.2.0)

@erikwrede if there's more you spotted, plz let me know :) CI is passing on my fork


Update Tests

Update PHP Unit tests to get to at least 90%.

I'd love to work on this, I'll start adding some tests and submit a PR :)

👍  That was quick!

I did notice you just opened this, that was just lucky timing! I happened to open the Hacktoberfest search just at the right time :-)

@skybluesofa you don't have phpunit in your composer - what version are you using?

I'm running 4.8 on my machine. I'm new to testing and didn't know any better. Suggestions?

Yeah definitely want to upgrade to 5, and 5.6 just got marked stable :) I'll add it into composer.json in my PR. Typically you want to commit the composer.lock as well so everyone is on the same exact versions. (https://blog.engineyard.com/2014/composer-its-all-about-the-lock-file).
You run the project specific version by using vendor/bin/phpunit instead of just phpunit. (This will need to be updated in the travis.yml as well) - this prevents issues with differing versions between individuals and CI.

So, upon actually looking at the code that is missing coverage, some of it is unreachable, and some of it is unnecessary.
It's all part of methodCallable which is a private method. In Unit Testing, you don't need to test private methods directly, you should only ever test your public API. So looking at the two public methods which use that private method, they're both magic methods. The uncovered blocks are testing for a null object, testing for a non object, and testing for a null method name.
To my knowledge, there's no way that either __call or __callStatic could be called with the method name being null. This block will never be reached. By changing the signature of the private method to:
private function methodCallable($object, string $method) you can remove the need for the check within this method. Because the method is private, it can't be used by any other class, and you have the security that anyone using it basically knows how to use it. (This applies to the check for a null object as well).
The final check is the is_object check, that one I think you can remove the need for that logic by typehinting private function methodCallable(Chainable $object, string $method) but I can't recall if you can typehint on a trait and I haven't tried it yet. Probably not with my luck :) If not, the way to test this involves actually using the private method incorrectly, and I'll work on a test for that.
I'll submit a PR that reflects these changes - obviously feel free to ignore any of this, just offering up my advice :)

Oh also, is there a reason the methods in your test class do not have public visibility explicitly written? Since the trait uses public I was confused why you didn't apply that to your test as well.

Just an oversight on adding public to the tests. I've updated visibility.
Thanks again for your help.

It looks like Code Climate's tool handles the difference, because it shows the same report as phpdbg, so you're now at 100! ⭐
Was happy to help, I look forward to seeing your progress on this repo in the future!


Text composables: Android Basics with Compose

https://developer.android.com/codelabs/basic-android-kotlin-compose-text-composables?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-3%3Fhl%3Des-419#8
In which task and step of the codelab can this issue be found?
Build a simple app with text composables, step 9, add greeting to the app
Describe the problem
In Adopt good practice, missing the modifier = Modifier.padding(8.dp) on the call to the GreetingText
onCreate()

Surface(
   //...
) {
    GreetingText( message = "Happy Birthday Sam!", from = "From Emma")
}
GreetingText()

@Composable
fun GreetingText(message: String, from: String, modifier: Modifier = Modifier) {
   Column(
       verticalArrangement = Arrangement.Center,
       modifier = modifier
   ) {
       //...
   }
}

Possible correction
Surface(
    modifier = Modifier.fillMaxSize(),
    color = MaterialTheme.colors.background
) {
    GreetingText(
        message = "Happy Birthday Sam!",
        from = "From Emma",
        modifier = Modifier
            .padding(8.dp)
    )
}
@Composable
fun GreetingText(message: String, from: String, modifier: Modifier = Modifier) {
    Column(
        verticalArrangement = Arrangement.Center,
        modifier = modifier
    ) {
        // ...
    }
}

I got a little confused in that part, but I get it, but it would be ideal that in the onCreate() you pass a Modifier to the GreetingText() function so that it is better understood.

Hi @joserossodeveloper
Thank you for writing in and bringing this issue to our attention.
The lesson has been updated to address it and the revised lesson will be republished again in the near future.
Hope you are enjoying the course!
Regards.


GH-2154: Fix Tombstones with Delegating Seriali...

Resolves https://github.com/spring-projects/spring-kafka/issues/2154
Check for null and return.
cherry-pick to 2.8.x, 2.7.x (partial)

... and cherry-picked to 2.8.x & 2.7.x after fixing conflicts.


Troops GUI value does not update.

Expected Results
Update the GUI value with the actual value after an attack.
Actual Results

Steps to Reproduce
Attack a NPC and then check back with values of your troops in this GUI.

App Version
0.1
Error Logs
No response
Is there an existing issue for this?

[X] I have searched the existing issues before opening this issue.
[X] I have provided all relevant details regarding this issue.
[X] I have removed my API Key from display, if visible.

Additional Context
No response

The screenshots you displayed display an error

This is still a bug, the error message should be handled accordingly. @Owen-Griffin


Support downloading images from remote sources

I have been playing a bit with the Drupal source plugin and can't get images working for my setup. I saw that #459 added such support for the Wordpress source plugin. So wanted to put out the idea of improving the image handling experience by allowing to download images from remote URLs also for the Drupal source plugin or in general.

+1 for remote image download

+1

+1 for sure

Hey guys,
I have created two plugins to download images from a remote url. Maybe this helps you to solve your problem:
https://github.com/noxify/gridsome-plugin-remark-image-download
https://github.com/noxify/gridsome-plugin-image-download


Recognize patterns where better solutions exist

The documentation for https://github.com/ankane/strong_migrations is awesome and it might be possible to recognize a bunch of the same things, either by parsing the sql with a proper parser, or by inspecting the locks and potentially generate some recommendations or "fixing up" the migration programmatically.

It seems like the easiest way to do this is to snapshot queries against pg_attribute and pg_constraint, similarly to how we snapshot pg_class. We'd want to track:

CHECK-constraint and whether they are VALID
FOREIGN KEY-contraints and whether they are VALID
The type, name and nullability of every column in non-system tables.
All columns that take part in an index
All columns that take part in a unique-index

This should let us match against these patterns from the strong migrations documentation:

Changing the type of a column (causing table rewrite)
Adding serial/bigserial column (causing table rewrite)
Adding a stored generated column (causing table rewrite)
Adding a VALID check constraint
Adding a VALID foreign key
Adding a unique constraint
Adding a json column
Changing a column to NOT NULL

type_change_requires_table_rewrite needs to be fixed to actually understand what type changes that forces a rewrite.

We should definitely make it possible to "fail the trace" if we find some of these patterns, because at that point, we know of better ways to do the migration.

We need to track indexes too, so we can recommend to add them concurrently. There's also a nice hint we could give if people add a unique constraint, where it's safer if they create a unique index concurrently.

Altering a check constraint body is probably often not safe. 🤔

#32 brings us up to 8 patterns/rules, which is enough for me to close this one.


HDR doesn't work properly with ZetaLoader.

Title. It doesn't look this dim when launched through the regular Halo Infinite launcher. But with ZetaLoader it looks like as if it's outputting the game in SDR mode even when HDR is toggled.

Hello, thank you for the prompt response. Tho I think this was due on my end. I hadn't opened Halo Infinite in a long time and it seems their HDR implementation has changed a bit so I had to alter my monitors brightness and now it looks as it did back then (or close enough). If anyone else reports on it then feel free to keep bug testing, but at least for now issue should be closed on my end. Thanks again.

Thank you!


Horizontal collapse

It would be nice with a horizontal collapse feature.
This would be very handy for collapsing sidebars.

Offset Canvas already do it!?

one would also like the option to have a slide-(left|right) nav on tablet and mobile, that overlays the content rather than pushing it aside.

What is the status of this?
I am waiting for the option to slide a nav menu from the sides, which appears to be the standard today on mobile apps.

https://github.com/bootstrapstudio/bootstrap-better-nav  so this is a thing that exists and which I've used successfully in a redesign.

https://github.com/twbs/bootstrap/pull/31285 is planned for off canvas, and https://github.com/twbs/bootstrap/pull/31681 is stubbed out but troublesome for horizontal collapse.

@mdo, it looks really good! 👍

This is a really good example of left nav/sidebar that hides on smaller screens and has an icon only collapse option on larger screens.
https://coreui.io/demo/3.1.0/#main.html

https://coreui.io/demo/3.1.0/#main.html

@mrlife's example of a sidebar that collapses to an icon bar is exactly why I came looking for a horizontal collapse 😄

Tried in #31681 but couldn't make it work with just CSS. Would love if someone could give it a go!

Thanks for trying! Unfortunately I'm pretty rusty on CSS; more of a back-ender now.

I thought this would be just as the existing vertical collapse but horizontal and hence be a minor change that was easy.

I have a use case for this functionality that I just finished implementing and I thought I'd circle back to see what value I can bring to this issue!
The Problem
From what I understand, during the expanding of the collapse element, the height is set to 0, overflow is set to hidden, the scrollHeight of the element is calculated, and then set on the element. This causes the transition to happen. The key is that the child element is hidden by the overflow, but still visible, which allows the scrollHeight calculation to capture it's height. Here is a screenshot of the height that is being captured -

The JavaScript already has support for adding a width class to the collapse element. This switches the JavaScript calculation from scrollHeight to scrollWidth. However, there is no support for the width class in the CSS so some small finagling needs to happen to the styles of the .collapsing class. This is not enough however, because the child element doesn't expand horizontally the same way it did vertically (I believe this is just because of how the DOM is rendered?) and the scrollWidth calculation doesn't capture the full element width. Here is the hidden overflow that scrollWidth captures. Not having the proper width means that the transition doesn't properly go from 0 to full width and ends up jumping around.

Solution
To solve this problem while still using the collapse functionality, I set a fixed width on the child element. This way, the scrollWidth calculation captures the proper width of the visible collapse element and the transition happens smoothly. I created a pen -
https://codepen.io/SpaceJam/pen/wvJQBPB
The pros here are that I could use the existing JS, and only need to make a few small styling changes to support the functionality I needed. The con is that this isn't responsive. It would be simple enough to add some responsive variables to change the collapse width at different screen sizes -
$collapse-horizontal-width-sm: ...
$collapse-horizontal-width-md: ...
...

In my mind, this is still less than a perfect option. From what I can see above, others have settled on this same fixed-width solution, but that didn't give traction to getting this issue resolved. I'm happy to open a PR (it would probably look similar to https://github.com/twbs/bootstrap/pull/31681) to support this solution if you all feel this adequately fulfills the issue request.