Codestyle environment

This pull-request adds a separate environ for codestyle testing.
Currently ignores E241 and E501 errors.
I also fixed some code style errors.

I did not include travis changes as I'm afraid I'll mess up the file.

Coverage increased (+0.04%) to 93.578% when pulling 8f6bee9196f2cacee9cc94de537c63ca15bd75dd on medecau:codestyle_environment into 6238b59e72caceda31578213073fa5c4dc0774f3 on jkbrzt:master.

Coverage remained the same at 93.541% when pulling c7d1bf98fc4454fcd465caa76bcdf79d1e763f84 on medecau:codestyle_environment into 6238b59e72caceda31578213073fa5c4dc0774f3 on jkbrzt:master.

Coverage increased (+0.04%) to 93.578% when pulling 444c56d20d1844f0e9b2f78adff77cae076b5a77 on medecau:codestyle_environment into 6238b59e72caceda31578213073fa5c4dc0774f3 on jkbrzt:master.

Coverage increased (+0.04%) to 93.578% when pulling e11cc312b8037890af21d3361760783d4c02ba67 on medecau:codestyle_environment into 6238b59e72caceda31578213073fa5c4dc0774f3 on jkbrzt:master.

Coverage remained the same at 93.541% when pulling 86c8abc4859eda944b351347ff704186f1ac3755 on medecau:codestyle_environment into 6238b59e72caceda31578213073fa5c4dc0774f3 on jkbrzt:master.

It took me a few tries but I was able to config travis to run an independent environment for pycodestyle.
I wanted to point the python version to the value in NEWEST_PYTHON but gave up on that.
https://github.com/medecau/httpie/blob/e11cc312b8037890af21d3361760783d4c02ba67/.travis.yml#L50
pinging @jkbrzt @msabramo for review

Coverage remained the same at 93.541% when pulling becb63de9a0c0ccedd5c2e1073045b088cd76f98 on medecau:codestyle_environment into 6238b59e72caceda31578213073fa5c4dc0774f3 on jkbrzt:master.

👍
Nice work, @medecau!

Obrigado, @medecau!

-.-'
De nada!


feat(generators): add Sass import reminder to page generator

Addresses https://github.com/driftyco/ionic/issues/5467
https://github.com/driftyco/ionic-cli/issues/773.
Adds the message:
conference$ ionic g page test
√ Create app/pages/test/test.html
√ Create app/pages/test/test.js
√ Create app/pages/test/test.scss

Don't forget to add an import for test.scss in app/themes/app.core.scss:

  @import ../pages/test/test.scss

Yes, we're assuming that app/themes/app.core.scss is where their styles are located, but I think it's fair to assume conventions when using generators.
@leonsas @adamdbradley look ok?

:+1: Let's run with it and see how it works.


add rust-toolchain.toml file to auto select right rustc version

I personally don't use this, I use nightly by default with nightly rustflags; this forces stable, which makes me usually just remove the file so it actually even compiles

yeah same, don't think we won't this then


[improve][ci] Add pulsar-client test group

Motivation
pulsar-client test group is not in CI, but this module is important and we need to make sure of its quality.
Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/yaalsn/pulsar/pull/15

@lhotari  Could you please take a look at this PR?

Codecov Report

Merging #18298 (ed66cc8) into master (0866c3a) will decrease coverage by 4.45%.
The diff coverage is 48.43%.

@@             Coverage Diff              @@
##             master   #18298      +/-   ##
============================================
- Coverage     38.97%   34.51%   -4.46%
+ Complexity     8311     6493    -1818
============================================
  Files           683      608      -75
  Lines         67325    58071    -9254
  Branches       7217     6054    -1163
============================================
- Hits          26239    20043    -6196
+ Misses        38079    35387    -2692
+ Partials       3007     2641     -366

Flag
Coverage Δ

unittests
34.51% <48.43%> (-4.46%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../main/java/org/apache/pulsar/PulsarStandalone.java
0.00% <ø> (ø)

...che/pulsar/broker/BookKeeperClientFactoryImpl.java
0.00% <0.00%> (ø)

.../org/apache/pulsar/broker/admin/AdminResource.java
32.02% <0.00%> (-34.49%)
:arrow_down:

...pulsar/broker/admin/impl/PersistentTopicsBase.java
11.96% <0.00%> (-40.34%)
:arrow_down:

...pache/pulsar/broker/admin/v2/PersistentTopics.java
6.63% <0.00%> (-64.17%)
:arrow_down:

...pulsar/broker/service/PulsarCommandSenderImpl.java
70.68% <ø> (-3.68%)
:arrow_down:

...ersistentStreamingDispatcherMultipleConsumers.java
0.00% <0.00%> (ø)

...sar/broker/service/persistent/PersistentTopic.java
44.51% <0.00%> (-12.47%)
:arrow_down:

...ransaction/buffer/impl/InMemTransactionBuffer.java
0.00% <ø> (ø)

...nsaction/buffer/impl/TransactionBufferDisable.java
52.63% <ø> (ø)

... and 394 more

/pulsarbot rerun-failure-checks

@lhotari Could you please take a look at this PR?

@mattisonchao I didn't have time to review before this was merged.  /cc @codelipenghui

pulsar-client test group is not in CI, but this module is important and we need to make sure of its quality.

@yaalsn The pulsar-client module tests were run as part of the OTHER test group and continue to run as part of that group. I created PR #18339 to address that.

I hope Pulsar CI changes like this could be reviewed carefully before merging so that we don't needlessly make changes. If gaps are detected, it's worth bringing up to discussion on dev mailing list or on Pulsar slack on the #testing channel.


Firefox addon's file size limit

File is too large to parse.
Error: This file is not binary and is too large to parse. Files larger than 4MB will not be parsed. Consider moving large lists of data out of JavaScript files and into JSON files, or splitting very large files into smaller ones.
assets/ts.worker-Brk6wN3W.js

https://github.com/ergofriend/Quiqsearch/blob/d9cd5967ec4985d5d256b144d7d814c2095a7fcf/components/molecules/custom-editor.tsx#L10
Related links

Bug with uploading "large" files in addon - Add-ons / addons.mozilla.org - Mozilla Discourse
https://github.com/mozilla/addons-linter/issues/4942
https://github.com/microsoft/monaco-editor/issues/4184

Unlike Chrome, Firefox(MV2) has room to loosen CSP, so there is a possibility that it might be possible to solve it with esm.sh?
content_security_policy - Mozilla | MDN


immer patch support for thorough logging

Patches should be able to be turned on or should be automatically turned on in response to adding middleware. Oh, and "middleware" should be able to be registered to get a copy of each patch to do with what they please.

Could either be a globally registered function required in setup, or could be a hook called like useSubstatePatches(), which could even optionally take a substate key to only receive patches for that particular substate.

food for thought:
Substate.createPatchPipe(...)


Show a notification when new files were uploaded

Will most likely require a general purpose notify service/api/solution.
Show the amount of newly uploaded files like for chats.

A notification and dashboard system will be created in the near future. First steps done during dev-meeting in january 2023. Currently this issue will be closed, because it's purpose is included in concept process of the notification and dashboard system.


Syntax Error: Unexpected

Hello. I am testing this package out with the following config and schema file:
introspection:
  schemaFile: ./sdl.gpl

type Query {
  staff(staffId: Int!): Staff
}

"""
Our fearless staff
"""
type Staff {
  """
  Staff ID
  """
  staffId: Int

  """
  Staff first name
  """
  firstName: String

  """
  Staff last name
  """
  lastName: String
  email: String
  fightsBearsAndWins: Boolean
}

When running npx spectaql config.yml I get the following error:
Syntax Error: Unexpected <EOF>.

Even when the schema file is empty the error occurs.
On version 0.12.0 on Ubuntu. npm version is 6.14.6.

It seems that spectaql does not recognise the .gpl file extension (might be a typo anyways?). This config works on my end:
introspection:
  schemaFile:
    - sdl.gql
info:
  x-swaggerUrl: https://www.foo.bar

Thank you @pylipp, I think the typo was the issue. Working now.  Working now.  It's a pretty worthless/unhelpful error message. I'll see if I can't detect this scenario and provide a more useful error message. Re-opening for now.

Thank you @pylipp for your help on this one!

Thank you @newhouse !

Will be supported in 1.0.0 when it comes out.

This is now out in 1.0.0


Remove uuid gem in favor of SecureRandom

Recent update of ruby-saml dropped the dependency of uuid.

Support for Ruby version 1.9.3 ended on Feb 2015: https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/


Add Windows 7 and 8.1 testing on Helix

Resolves https://github.com/aspnet/AspNetCore-Internal/issues/1942

Add new test queues for Win 7 and Win 8.1
Install SQL Server Local DB in Helix VMs when needed

/azp run

On Windows 7 and 8.1, these test projects completely fail due to lack of SQL Server, as predicted.

@HaoK @ajcvickers I know you were having conversations with the dnceng team about SQL Server in Helix. What was the outcome of that thread? It appears we also need SQL Server to run these unit tests for AspNetCore on Helix.
Error Message:
 Assert.Contains() Failure
Not found: In Visual Studio, use the Package Manager Console to scaffold a new migration and apply it to the database:
In value:  System.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The

LocalDb was what was missing for these (and why we switched to the VS queue), maybe in the short term we just skip these tests on these new queues?

switched to the VS queue

Is that the dnceng team recommendation? "Just use VS images"? If so, we'll have to ask them to provision VS images for Win 7 and Win 8.

I think that was just the easiest option since they already had a a pool setup with VS, I found the thread from last time, https://github.com/dotnet/core-eng/issues/5032

@natemcmaster can you try adding these windows queues for IIS tests too? See https://github.com/aspnet/AspNetCore/blob/783131a7501a1ba5865838e9c4a8d2d5b2f4238d/src/Servers/IIS/IIS/test/FunctionalTest.props.
Ideally, controlling the machines IIS tests run on should be next to the helix props files.

Re: SQL Server
@HaoK we talked about this requirement in build team sync up yesterday. Sounds like the dnceng team really doesn't want to pre-install LocalDB SQL Server into Helix machines for us. We came up with some alternatives:

Only run SQL Server tests on Linux and use Docker to start a mssql DB server
Switch Identity tests to use the SQLite provider
Install SQL Server LocalDB on-demand in the helix VM using a script

Thoughts? I'm tempted to start with option 3, install sql server on-demand.

Yeah installing it on demand seems reasonable, option 2 wouldn't likely be too bad either, as it would just be tweaking the connection string in one place I think. @ajcvickers any thoughts on this, is there a long term benefit between testing localdb vs sqlite for our identity efprovider tests?

It appears option 3 - install mssql on-demand - works well enough for the tests in this repo.

Bleh all IIS tests were skipped... I should have kept better track of these machines as it look likes IIS isn't installed on them.

I think something in Helix test reporting is still busted. I'm adding two new queues, but the # of test results didn't increase by much.
Should I be seeing something in the logs about collection of test results from a .trx file? See https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190508.9/workItem/AuthSamples.FunctionalTests-netcoreapp3.0/wilogs for instance
cc @JunTaoLuo @alexperovich

Bleh all IIS tests were skipped...

How did you figure that out? I'm assuming you saw this in logs because I don't see any tests reported as 'skipped'.

Yeah went into the logs: https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190508.9/workItem/IISExpress.FunctionalTests-netcoreapp3.0/wilogs

I think the exit 0 at the end of your runtests.cmd is causing an issue.
From this log: https://helix.dot.net/api/2018-03-14/jobs/c3451e6a-3bf5-4337-974e-6c854d9e706d/workitems/AuthSamples.FunctionalTests-netcoreapp3.0/console
The last line executed is the exit 0. I think it needs to be exit /b 0, the test reporter is never called because IIRC exit without /b exits out of every called thing.

Thanks! I'll give that a try.

I think the max retries being set to '4' is causing timeouts on Helix testing. I'd like to set this back to 2.
@jkotalik @Tratcher - I'm seeing a few hundred HttpSys and IIS test failures on all versions of Windows (both the new ones I'm adding and queues that have been enabled for a while) https://dev.azure.com/dnceng/public/_build/results?buildId=183898&view=ms.vss-test-web.build-test-results-tab. Are these test failures a known issue?

The HttpSys test failures are all HTTPS tests. It relies on the IIS Express certificate and bindings to be set up, it re-uses them. Is IIS Express not installed?

Apparently not. Is there a way we can script the installation of IIS Express? The dnceng team is pushing us to install test dependencies on our own and on-demand if possible.

Digging through this, we found a few things that require followup

Cert generation is busted on test runs. Likely due to old versions of PowerShell which don't support the -notafter parameter - @jkotalik
Running the InstallIISFeatures.ps1 script can probably be removed - @jkotalik
We need to add 'SkipOnHelix' attribute to IIS tests that consistently fail on Helix @jkotalik
Windows7 does not have IIS features ( https://github.com/dotnet/core-eng/issues/5506) - @natemcmaster  to follow-up with dnceng team
Apparently MaxRetryCount = 2 means only run tests once? Seems like a bug in Helix - @natemcmaster to followup

I'll file a follow up issue for some HttpSys/IIS tests that will be disabled due to cert issues on helix. Things look good on helix besides that!

@natemcmaster we should either remove running UpdateIISExpressCertificate on Windows 7 or ignore the exit code. Right now the IISExpress tests are failing.

:up: :date:

Added a pre-generated TestCert.pfx file and updated the UpdateIISExpressCertificate.ps1 script to install that instead of generating a cert on the fly.
Disabled Windows 7 tests for IIS. (Once https://github.com/dotnet/core-eng/issues/5506 is complete, we can re-enable)

Ok, this is mostly working now. There were a few flaky tests in Kestrel, but I think we should merge.
Biggest improvement here is that we're actually getting test results from Windows now. About 400k test results per build :)


RM3 / Branding refresh / Slider / Dark background

Purpose: Update the styling of Slider for the new branding.
inVision: https://cengage.invisionapp.com/share/M912EDCFJ6PU
Prerequisites:

Color palette in place
Typography updated
Progress Bars updated
Work Sans available

AC

If still necessary, change font from Open Sans to Work Sans

1.0 Track

1.1 Background: neutral-900, opacity 0.25
1.2 Border: 1px solid neutral-100, opacity 0.50
1.3 Height: 8px

2.0 Handle

2.1 Background: neutral-100
2.2 No border
2.3 No drop shadow

3.0 Filled portion of track

3.1 Background: tertiary-500

Closing as these styles have been applied to the WIP PR (#360), and the issue will be completed as part of #64


Dynamically generate item textures in jars

Related to #15
When storing non-block items in a jar, I have to manually create the textures. This makes it difficult to add support for foods and items from other mods, which I definitely want to do.
Figure this out...

https://fabricmc.net/wiki/tutorial:blockentityrenderers


Better Rolls 2 Support: Rolling From the Token's Actions

Is your feature request related to a problem? Please describe.
When using the Better Rolls 2 integration for Token Action HUD, the cards that are pulled up are from the token's Actor sheet, instead of the token's sheet itself. This makes keeping track of effects and ammo per token (especially for enemy tokens that are dragged out multiple times per Actor sheet) difficult, since the modifiers like Distracted or ammo spent from RoF weapons aren't applied.
Describe the solution you'd like
If possible, I'd like there to be a setting in the module settings where we can choose whether a token's sheet or the token's Actor sheet is used when using Better Rolls 2 support for SWADE.
Describe alternatives you've considered
Currently, I've migrated back to Token Action HUD Classic to resolve this temporarily. Opening the sheets manually while using the new Token Action HUD SWADE defeated the purpose of using the module.
Additional context
Add any other context or screenshots about the feature request here.

Hi @LeBonkerson ,
I didn't understand the issue correctly. Tokens doesn't have items, to access them we need to use token.actor.items. However, tokens have effects. The behaviour we will have for a token is related to which option we make when configuring the prototype token of an actor.
Can you confirm the desired behaviour please?
If you link the actor data to the token (image below), and drag multiple tokens to the scene, all effects and damage applied to one token will be replicated to the other ones.

If you don't link the actor to the sheet, all effects will be applied to that specifict token and will not be replicated across all tokens within the scene.
is that the desired behaviour?

Apologies for not explaining it well enough. As an example, in the Token Action HUD Classic version, I was able to select a token on the map and choose a piece of its gear to have it do an attack and negatives from effects like Distracted and Wounds would show up. Ammo would also automatically subtract.
Using the new Token Action HUD Core and Token Action HUD SWADE, those negatives do not apply since the HUD pulls from the Actor sheet instead of from each individualized token sheet.
I was able to determine this because after dragging out three enemies, I attempted to set one to Distracted and run an attack, but it didn't have the negative applied using Better Rolls 2. When I applied the Distracted debuff to the Actor sheet, it applied correctly to that Token, but also to every other token. This wasn't the case with the old Token Action HUD Classic, which pulled the Gear from the individual Token and not the referenced Actor.
I may just be confused on the functionality of the new module, so please let me know if I'm mistaken. Thanks so much for all your help!

Thank you @LeBonkerson for the details.
Version 0.7.6 should address this issue. If issue persists feel free to comment here please.


New technique - Multilinear regression

related to #202

I change the name to "multiple linear regression" according to the other changes that you made. Definition and rest is fine. Ready to merge from my side.


Validate scope when deploying a bicpe file with Azure CLI / Azure Powershell

We should check if targetScope matches the deployment scope when deploying a bicep file with the Azure CLI / Azure PowerShell deployment commands.

One way to achieve this is to let the Bicep CLI take a new parameter (something like --deploymentScope) and let it output error if it doesn't match targetScope. However, the parameter will be useless if people invoke the bicep build command directly, and I feel like the Bicep CLI should be deployment agnosticand. An alternative approach is to read targetScope of a bicep in Azure CLI / Azure PowerShell and then do the scope validation, but since we cannot access the AST in CLI and PowerShell, this may require us to implement a new Bicep CLI command which can output the value of targetScope upon invoking. I would like to hear people's thoughts on this.

Yeah given that this needs to work in Python and .net core, our options are limited. I see the following:

Port just enough of the parser to parse the targetScope in Python. Pull in the real parser for PowerShell as a nuget.
Hack "parse" it with regular expressions.
Implement a special command to return this information like @shenglol suggests above.

1 and 2 will likely cause maintenance issues and deviations between Bicep in the real parser vs. the ported/hacked versions. So we definitely shouldn't do those options unless we don't have a choice.
Feels like option 3 is the best option. My suggestion on this one is to name it something more generic than bicep getTargetScope. Maybe something like bicep diagnostics or bicep info? We should have a contract for the output of the command and we should make sure we keep backwards-compatibility in mind when extending it. Perhaps simply a JSON file that we add new properties to?


Interpretation of L1 and L2 values in GLM options

Hi,
What exactly do the L1 and L2 values refer to in the GLM model? Is it the lambda value or the lambda value multiplied by the alpha (or 1-alpha)? I got a result where the elastic net model selected zero variables, which was a very unexpected result. Consequently, I am suspecting that I am misinterpreting what the L1 and L2 values are referring to in PiML.
Thank you

Hi @xloffree ,
With different L1 and L2, the GLM model will changed.

{l1_regularzation=0 & l2_regularzation=0}: Ordinary least squares Linear Regression.
{l1_regularzation>0 & l2_regularzation=0}: Lasso Regression.
{l1_regularzation=0 & l2_regularzation>0}: Ridge Regression.
{l1_regularzation>0 & l2_regularzation>0}: Elasticnet Regression.

For Lasso, alpha= l1,
For Ridge, alpha=l2,
For Elasticnet, alpha=l1+l2; l1_ratio= l1/ alpha

Hi,
Thank you for the response.
When using PiML, if I have a lambda value of 0.1 and an alpha value of 0.5, what value should I enter in for L1 and L2 when using elastic net? Would it be 0.05?
Thank you


feat(proxy): fetch venue details with fallback languages

LIIKUNTA-547.
If the locale that is set in header does not return any results,
use the configured fallback languages.
NOTE: The work is done to the venue proxy -- not in the client.

Instead of trying to fix this on the client side, the resolver in the Venue-graphql-proxy could be modified so that it uses a fallback language instead of undefined

The problem is that the Sport app venue search uses the Unified-Search, but the Venue details page uses the Venue proxy, which fetches directly from the TPREK / Servicemap. The Venue-proxy returns the details in only 1 language (unlike e.g the LinkedEvents) which is defined in the request header.

To test with the Sport app in a local env

start the venue proxy locally with yarn build and yarn start.
change the monorepo's root package json so that a local router would use the venue-proxy:    "docker:graphql-router:sports:serve": "cross-env FEDERATION_CMS_ROUTING_URL=https://liikunta.hkih.stage.geniem.io/graphql FEDERATION_EVENTS_ROUTING_URL=https://events-graphql-proxy.test.hel.ninja/proxy/graphql FEDERATION_UNIFIED_SEARCH_ROUTING_URL=https://kuva-unified-search.api.test.hel.ninja/search FEDERATION_VENUES_ROUTING_URL=http://docker.for.mac.localhost:4200/proxy/graphql docker-compose -f docker-compose.router.yml up".
set the .env.local to use the local router FEDERATION_ROUTER_ENDPOINT="http://localhost:4000"
run the sports app and test

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr420.dev.hel.ninja :rocket::rocket::rocket:

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr420.dev.hel.ninja :rocket::rocket::rocket:

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr420.dev.hel.ninja :rocket::rocket::rocket:

Sports-Helsinki branch is deployed to platta: https://liikunta-pr420.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is failed for https://harrastukset-pr420.dev.hel.ninja :crying_cat_face::anger::boom::boom:

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr420.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is failed for https://tapahtumat-pr420.dev.hel.ninja :crying_cat_face::anger::boom::boom:

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr420.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is failed for https://liikunta-pr420.dev.hel.ninja :crying_cat_face::anger::boom::boom:


Add chelpg charges in qmmm folder.

Can you please move the example to /gpu4pyscf/examples?
And add unit case to the module


warning: Capturing the given block using Proc.new is deprecated; use &block instead

What I did
Upgraded ruby to 2.7.0
What happened
I got a lot of warnings saying

gems/phony-2.12.14/lib/phony/dsl.rb:17: warning: Capturing the given block using Proc.new is deprecated; use &block instead

When I start the server.
What I expected to happen and why
Warnings shouldn't appear as they affect performance and flood the log files.

@MohammedAbuissa Thanks for the issue! I notice you're using a version of the gem that is from May 09, 2015. Is it possible for you to upgrade to a later version? Cheers! 😊

@floere works like charm, thanks!


Import into eclipse workspace

Description
djl.ai did not compile after importing the gradle project into eclipse.
reasons are 2 issues which per default are flagged by eclipse as errors cause this can be seen as bad smells/bad coding practise.

cycle dependencies in the compile-classpath.
package-info.java files exists in src/main/java and in src/test/java in the same package. same file getting compiled to same package in the classpath is a bad smell and get flagged.

Both issue can be configured in eclipse workspace so that eclipse ignore this, but we have to do this after every new import - for example when clean checkout a new version of djl (like version 0.9.0 yesterday)
this can get automated through gradle -> this change set the settings for eclipse workspace and can be execute via "gradlew eclipse" before importing

package-info.java files exists in src/main/java and in src/test/java in the same package. same file getting compiled to same package in the classpath is a bad smell and get flagged.

We enabled checkstyle, if we remove those package-info.java, checkstyle will fail. I didn't find a way to workaround this issue.

package-info.java files exists in src/main/java and in src/test/java in the same package. same file getting compiled to same package in the classpath is a bad smell and get flagged.

We enabled checkstyle, if we remove those package-info.java, checkstyle will fail. I didn't find a way to workaround this issue.

package-info.java files exists in src/main/java and in src/test/java in the same package. same file getting compiled to same package in the classpath is a bad smell and get flagged.

We enabled checkstyle, if we remove those package-info.java, checkstyle will fail. I didn't find a way to workaround this issue.

this lines in the gradle, will advise eclipse to ignore the package-info files in src/test during building, so its fine for eclipse users
	sourceSets.test.java {
			srcDirs = ["src/test/java"]
			exclude "**/package-info.java"
		}

package-info.java files exists in src/main/java and in src/test/java in the same package. same file getting compiled to same package in the classpath is a bad smell and get flagged.

We enabled checkstyle, if we remove those package-info.java, checkstyle will fail. I didn't find a way to workaround this issue.

this lines in the gradle, will advise eclipse to ignore the package-info files in src/test during building, so its fine for eclipse users
	sourceSets.test.java {
			srcDirs = ["src/test/java"]
			exclude "**/package-info.java"
		}


Add test for _run_hook_from_repo_dir

Resolve #579

cc @eliasdorneles :wave:

Current coverage is 99.20%

Merging #580 into master will increase coverage by +0.80% as of 47181f3

@@            master   #580   diff @@
=====================================
  Files           12     12
  Stmts          501    501
  Branches         0      0
  Methods          0      0
=====================================
+ Hit            493    497     +4
  Partial          0      0
+ Missed           8      4     -4

Review entire Coverage Diff as of 47181f3

Uncovered Suggestions

+0.40% via ...okiecutter/config.py#19...20
+0.40% via ...ookiecutter/utils.py#27...28

Powered by Codecov. Updated on successful CI builds.

Looks good to me, +1.
Nice testing skillz, btz! =)