NOt Fetching When Ingame

when i am in game its not showing
its shows i am in queue

Did you enter your correct region?

Navigate to %APPDATA%\valorant-rpc and open config.json with your favorite text editor

press WIN+R, type %APPDATA%\valorant-rpc then press enter
change this to your client's region, can be found in settings -> about -> game shard

e.g. "EU", default is "NA"

@Lakhwinder123 If you mean India by 'ind', then your region should be set to 'ap' (for Asia Pacific), not 'ind'


[BUG] Azure AD Authentication Failed During MFA Challenge - Rename userPrincipalName field

Describe the bug
In the SC "ESCU - Azure AD Authentication Failed During MFA Challenge - Rule" the field "values(userPrincipalName)" needs to be rename to match the field names use in "Identity Extraction" and "Risk Object Field".

Thank you @cp-sn : we have updated search to output userPrincipalName


Added GETDEL command to KeyPrefixProcessor

Closes #1305

@tillkruss Most of this changes is related to code style library update, only KeyPrefixProcessor and KeyPrefixProcessorTest makes sense here

Coverage: 77.575% (+0.004%) from 77.571% when pulling 45b4204aaf08cdffd29a68aaa01033d53aa7e219 on vladvildanov:vv-1305-getdel-keyprefix into 95c23fb94d5cac0e8ca71f6f888f1b5c74bfbf61 on predis:v2.x.


✨ (keyring-eth) [DSDK-521]: Adapt SignTransactionCommand + new StoreTransactionCommand

📝 Description
Add support to SignTransaction for the incoming version of Ethereum app 1.13
The tests files have not changed, they have been update to comply with the current tests (legacy mode of SignTransaction). More tests to come in subsequent PRs.

❓ Context

JIRA or GitHub link: DSDK-521

Feature:

✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

[x] Covered by automatic tests
[x] Changeset is provided
[x] Impact of the changes:

Adapt SignTransactionCommand
Add StoreTransactionCommand
Update SendSignTransactionTask to use legacy mode by default

🧐 Checklist for the PR Reviewers

[ ] The code aligns with the requirements described in the linked JIRA or GitHub issue.
[ ] The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
[ ] There are no undocumented trade-offs, technical debt, or maintainability issues.
[ ] The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
[ ] Any new dependencies have been justified and documented.

I will look back in the feedback with @aussedatlo tomorrow and will update everything accordingly. Thank you for the feedback 🙏


Removing nm, now it's in binutils port for Harvey.

This solves issue #521
Signed-off-by: Álvaro Jurado<EMAIL_ADDRESS>

It's making me crazy me everytime I do a bind testing case when I'm working on native toolchain. It should be moved to legacy repo, but who cares. If anyone wants to copy it there, ok, if not is here in history.

I wanna do it! I wanna do it!


Add explicit beta tags for Flink and ClickHouse

This is a request from support to make it
more visible that those products are on beta
stage. Helps to manage expectations between
our clients and our support team about those
two products.
Fixes: https://github.com/aiven/devportal/issues/1512

Hi @laysauchoa, I saw that you added the beta flag in a couple more pages, is the extent enough to cover the requirements of the support team?

They said it would be nice to have in the Getting started pages. So it should be fine. I can add also to more pages if you think it makes sense, let me know :)


Propagates the red note about CRDs

Description

Adds red note about migration from TPR to CRD to k8s upgrade and hosted install

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

@ozdanborne I think maybe we can merge it?

Let us wait until https://github.com/projectcalico/calico/pull/1072 is merged.

@ozdanborne Let me work on this PR, need to clean it up a bit because of the other PR.


Instructions to use sdm inside a Docker container

Thank you🙏Will have a look!

If you are new to docker, https://docs.docker.com/engine/install/debian/ has the instructions to get the 'hello-world' example running.

 I set up a new system, installed docker, set up the working directory, and ran the file:
sudo docker run --privileged --network host --rm \
  -v "$(pwd)/myscript.sh:/myscript.sh" \
  -v "$(pwd)/working_dir:/root/sdm_working_dir" \
  --device=/dev/loop-control \
  --device=/dev/loop0 \
   debian:latest bash /myscript.sh

which gave the following output:
pit~# ./dodocker
Unable to find image 'debian:latest' locally
latest: Pulling from library/debian
82312fccb35f: Pull complete
Digest: sha256:17122fe3d66916e55c0cbd5bbf54bb3f87b3582f4d86a755a0fd3498d360f91b
Status: Downloaded newer image for debian:latest
/myscript.sh: /myscript.sh: Is a directory

My questions:

Why is myscript.sh a directory?
If it's supposed to be a file, which it looks like it should be, what should be in it?
What does  -v "$(pwd)/working_dir:/root/sdm_working_dir" do? Looks like it creates a bind mount?
According to man docker run the --device switch args are onhost:incontainer. The example you provided only has a single value. What does it do? (Can't try it yet due to what is myscript.sh)

Thx!

Why is myscript.sh a directory?
If it's supposed to be a file, which it looks like it should be, what should be in it?

Indeed, myscript.sh should be a file, not a directory. See lines 13 to 38 of the as to what could/should be in that file.

What does  -v "$(pwd)/working_dir:/root/sdm_working_dir" do? Looks like it creates a bind mount?

Yes. It takes a directory from the host, and makes its content (here: the to be customized image) available to the docker container. Also, when the container writes into this directory (here: the burned image file), the content becomes available on the host.
$(pwd)/working_dir is the path on the host. /root/sdm_working_dir is the path inside of the container.

According to man docker run the --device switch args are onhost:incontainer. The example you provided only has a single value. What does it do? (Can't try it yet due to what is myscript.sh)

It makes a device from the host (here: the loop device and its control) available to the container. So when the container calls losetup, actually a loop device on the host is created.
--device foo is just short for --device foo:foo

Indeed, when everything is set up properly (which I would have done first go if I had read your notes a bit more carefully 🫤) it works.
So far, the only thing I see that I don't care for is that each time I do the docker run it downloads all the apt packages and reclones sdm. Is it possible to configure the container separately and only once?
Thx!

Indeed, when everything is set up properly (which I would have done first go if I had read your notes a bit more carefully 🫤) it works.

Let me know where the language or format could be clearer.

So far, the only thing I see that I don't care for is that each time I do the docker run it downloads all the apt packages and reclones sdm. Is it possible to configure the container separately and only once?

Yes, that is possible. However (a) the majority of the runtime is spent in qemu doing an apt distupgrade inside of the new image, i.e. the container creation and setup takes only a fraction (for me <10s) of the total runtime (>10min) and (b) if the container is persisted, I would have to worry about when and how to manage that state and (c) one would likely create a Dockerfile to make it nice, which would make the instructions even longer.
Therefore I didn't bother. If you care strongly about this, I'll add the instructions, but I think it is not worth it.

Yes, that is possible. However (a) the majority of the runtime is spent in qemu doing an apt distupgrade inside of the new image, i.e. the container creation and setup takes only a fraction (for me <10s) of the total runtime (>10min) and (b) if the container is persisted, I would have to worry about when and how to manage that state and (c) one would likely create a Dockerfile to make it nice, which would make the instructions even longer.
Therefore I didn't bother. If you care strongly about this, I'll add the instructions, but I think it is not worth it.

If anyone tries to use this at the far end of a slow internet connection, they will be unhappy. I would like to see how to do it statefully as well, as an alternative. Thx!


JetBrains IDEs are altered to load with JDKs > 1.6

The JetBrains IDEs (WebStorm, IntelliJ, etc.) have their plists changed to allow them to run with JDKs > 1.6. That has the side-effect of having them to run with a newer JDK if one is installed. JetBrains doesn't recommend running their IDEs with newer JDKs due to very old and still outstanding defects with newer JDKs running GUI apps on OS/X. Here is an old link to defects noted by JetBrains. Many of them are still outstanding.
https://intellij-support.jetbrains.com/entries/27854363

@ctwise Thanks for the helpful link to JetBrains site. That's something I did not know when putting in the hack for IntelliJ IDEs.
I'll prepare a patch.

Fixed via #9943


Binary files problem

Hi @npruehs
Thank you for still solving problems for this code and thank you for remaking the AI code!
I hope you don't mind it...but is it possible to get some screenshots from inside the blueprints? I can't open these binary files. The engine version (4.25) doesn't read them. 4.26 can read only the BTService file, but doesn't want to open it, it says it's invalid.
I've been trying to open the files with 4.25, 4.26, 4.27, but I couldn't find a way of making the project fully work... I've even installed the 4.25 source engine version, but with no use...

 I saved these assets with UE5, which apparently isn't backwards-compatible. I'm gonna re-save them with UE 4.27, but I don't have time for that today.

Thank you! I really appreciate it!

Fixed in commit fca758365c05b0165d2f9ef28ffecad947a5f95c.


adds support for effect attribute

I have a need to support other effects than the default "slide".
This PR implements basic support for the effect attribute (see Swiper API for details) and adds a basic component test to cover this change.

Thanks!


Report delivery to Slack channel fails with not_in_channel error: docs not up-to-date?

I configured email alerts and those work fine; I'm now trying to setup Slack alerts for superset, following the instructions in the docs, trying to send an alert to a Slack channel superset-stage-alerts.
How to reproduce the bug
Here's the Alert configuration:

And here's where I added the App to the channel:

The scopes of the app were set to the required values (incoming-webhook, files:write, chat:write), and the SLACK_API_TOKEN in the config.py file was set.
The rest of the Superset config (browser installed for screenshots by using the -dev image, worker enabled, etc) should be ok, since I can receive alerts via email just fine.
Expected results
Receive message on slack.
Actual results
No message was received.
Here are the logs of superset-worker when the alert is triggered:

superset-worker logs
Scheduling alert Alberto test slack eta: 2023-08-18 10:30:00
[2023-08-18 10:30:00,206: INFO/ForkPoolWorker-1] Scheduling alert Alberto test slack eta: 2023-08-18 10:30:00
Executing alert/report, task id: 7a20c198-5aff-42e5-a6de-a3bee731da7e, scheduled_dttm: 2023-08-18T10:30:00
[2023-08-18 10:30:00,226: INFO/ForkPoolWorker-1] Executing alert/report, task id: 7a20c198-5aff-42e5-a6de-a3bee731da7e, scheduled_dttm: 2023-08-18T10:30:00
session is validated: id 4, executionid: 7a20c198-5aff-42e5-a6de-a3bee731da7e
[2023-08-18 10:30:00,227: INFO/ForkPoolWorker-1] session is validated: id 4, executionid: 7a20c198-5aff-42e5-a6de-a3bee731da7e
Running report schedule 7a20c198-5aff-42e5-a6de-a3bee731da7e as user admin
[2023-08-18 10:30:00,296: INFO/ForkPoolWorker-1] Running report schedule 7a20c198-5aff-42e5-a6de-a3bee731da7e as user admin
Query for Alberto test slack took 981.35 ms
[2023-08-18 10:30:01,555: INFO/ForkPoolWorker-1] Query for Alberto test slack took 981.35 ms
Init selenium driver
[2023-08-18 10:30:01,725: INFO/ForkPoolWorker-1] Init selenium driver
Taking a PNG screenshot of url http://superset:80/superset/dashboard/3/?force=false&standalone=3 as user admin
[2023-08-18 10:30:21,098: INFO/ForkPoolWorker-1] Taking a PNG screenshot of url http://superset:80/superset/dashboard/3/?force=false&standalone=3 as user admin

SupersetError(message="The request to the Slack API failed. (url: https://www.slack.com/api/files.upload)\nThe server responded with: {'ok': False, 'error': 'not_in_channel'}", error_type=<SupersetErrorType.REPORT_NOTIFICATION_ERROR: 'REPORT_NOTIFICATION_ERROR'>, level=<ErrorLevel.WARNING: 'warning'>, extra=None)
[2023-08-18 10:30:22,537: WARNING/ForkPoolWorker-1] SupersetError(message="The request to the Slack API failed. (url: https://www.slack.com/api/files.upload)\nThe server responded with: {'ok': False, 'error': 'not_in_channel'}", error_type=<SupersetErrorType.REPORT_NOTIFICATION_ERROR: 'REPORT_NOTIFICATION_ERROR'>, level=<ErrorLevel.WARNING: 'warning'>, extra=None)
header_data in notifications for alerts and reports {'notification_type': 'Alert', 'notification_source': <ReportSourceFormat.DASHBOARD: 'dashboard'>, 'notification_format': 'PNG', 'chart_id': None, 'dashboard_id': 3, 'owners': [Alberto Chiusole]}, taskid, 7a20c198-5aff-42e5-a6de-a3bee731da7e
[2023-08-18 10:30:22,665: INFO/ForkPoolWorker-1] header_data in notifications for alerts and reports {'notification_type': 'Alert', 'notification_source': <ReportSourceFormat.DASHBOARD: 'dashboard'>, 'notification_format': 'PNG', 'chart_id': None, 'dashboard_id': 3, 'owners': [Alberto Chiusole]}, taskid, 7a20c198-5aff-42e5-a6de-a3bee731da7e
Report sent to email, notification content is None
[2023-08-18 10:30:23,188: INFO/ForkPoolWorker-1] Report sent to email, notification content is None
A downstream warning occurred while generating a report: 7a20c198-5aff-42e5-a6de-a3bee731da7e. [SupersetError(message="The request to the Slack API failed. (url: https://www.slack.com/api/files.upload)\nThe server responded with: {'ok': False, 'error': 'not_in_channel'}", error_type=<SupersetErrorType.REPORT_NOTIFICATION_ERROR: 'REPORT_NOTIFICATION_ERROR'>, level=<ErrorLevel.WARNING: 'warning'>, extra=None)]
Traceback (most recent call last):
  File "/app/superset/tasks/scheduler.py", line 87, in execute
    AsyncExecuteReportScheduleCommand(
  File "/app/superset/reports/commands/execute.py", line 719, in run
    raise ex
  File "/app/superset/reports/commands/execute.py", line 715, in run
    ReportScheduleStateMachine(
  File "/app/superset/reports/commands/execute.py", line 673, in run
    state_cls(
  File "/app/superset/reports/commands/execute.py", line 574, in next
    raise first_ex
  File "/app/superset/reports/commands/execute.py", line 543, in next
    self.send()
  File "/app/superset/reports/commands/execute.py", line 441, in send
    self._send(notification_content, self._report_schedule.recipients)
  File "/app/superset/reports/commands/execute.py", line 432, in _send
    raise ReportScheduleClientErrorsException(errors=notification_errors)
superset.reports.commands.exceptions.ReportScheduleClientErrorsException: [SupersetError(message="The request to the Slack API failed. (url: https://www.slack.com/api/files.upload)\nThe server responded with: {'ok': False, 'error': 'not_in_channel'}", error_type=<SupersetErrorType.REPORT_NOTIFICATION_ERROR: 'REPORT_NOTIFICATION_ERROR'>, level=<ErrorLevel.WARNING: 'warning'>, extra=None)]
[2023-08-18 10:30:23,265: WARNING/ForkPoolWorker-1] A downstream warning occurred while generating a report: 7a20c198-5aff-42e5-a6de-a3bee731da7e. [SupersetError(message="The request to the Slack API failed. (url: https://www.slack.com/api/files.upload)\nThe server responded with: {'ok': False, 'error': 'not_in_channel'}", error_type=<SupersetErrorType.REPORT_NOTIFICATION_ERROR: 'REPORT_NOTIFICATION_ERROR'>, level=<ErrorLevel.WARNING: 'warning'>, extra=None)]
Traceback (most recent call last):
  File "/app/superset/tasks/scheduler.py", line 87, in execute
    AsyncExecuteReportScheduleCommand(
  File "/app/superset/reports/commands/execute.py", line 719, in run
    raise ex
  File "/app/superset/reports/commands/execute.py", line 715, in run
    ReportScheduleStateMachine(
  File "/app/superset/reports/commands/execute.py", line 673, in run
    state_cls(
  File "/app/superset/reports/commands/execute.py", line 574, in next
    raise first_ex
  File "/app/superset/reports/commands/execute.py", line 543, in next
    self.send()
  File "/app/superset/reports/commands/execute.py", line 441, in send
    self._send(notification_content, self._report_schedule.recipients)
  File "/app/superset/reports/commands/execute.py", line 432, in _send
    raise ReportScheduleClientErrorsException(errors=notification_errors)
superset.reports.commands.exceptions.ReportScheduleClientErrorsException: [SupersetError(message="The request to the Slack API failed. (url: https://www.slack.com/api/files.upload)\nThe server responded with: {'ok': False, 'error': 'not_in_channel'}", error_type=<SupersetErrorType.REPORT_NOTIFICATION_ERROR: 'REPORT_NOTIFICATION_ERROR'>, level=<ErrorLevel.WARNING: 'warning'>, extra=None)]

I was able to reproduce the problem with a curl:
$ curl -X POST -H 'Authorization: Bearer xoxb-12345-asdfasdfasdf' \
      -H 'Content-type: application/json' \
      --data '{"channel":"C04ASDF","text":"This is a test sending a message via curl"}' \
          https://slack.com/api/chat.postMessage

{"ok":false,"error":"not_in_channel","warning":"missing_charset","response_metadata":{"warnings":["missing_charset"]}}

Environment

standard 2.1.0-dev image on k8s

Checklist

[X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Solution
This SO question provided the correct solution: https://stackoverflow.com/questions/60198159/
It's not enough to "install" the bot in the channel as said in the docs (or rather, there's no point doing that it seems), you need to invite the bot to the channel (either with /invite @botnamehere in a message or by visiting the settings of your channel > Integrations > Add app), then everything works, both with curl and in superset.
Before inviting the bot, I also tried granting the chat:write.public permission as suggested in one of the answers, but that failed with the same error as above.
Let me know if this is expected, otherwise I can create a PR to fix this in the docs.

Hi there, and sorry this has gone quiet for so long. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale. If it is still an issue in Superset 3.x, we can re-open this, or feel free to open a new issue with updated context.


[googletest][rocm-cmake] multiple ROCMChecks WARNING messages

Issues may be observed when users are building MIOpen
*******************************************************************************
*------------------------------- ROCMChecks WARNING --------------------------*
  Options and properties should be set on a cmake target where possible. The
  variable 'CMAKE_CXX_FLAGS' may be set by the cmake toolchain, either by
  calling 'cmake -DCMAKE_CXX_FLAGS=""'
  or set in a toolchain file and added with
  'cmake -DCMAKE_TOOLCHAIN_FILE=<toolchain-file>'. ROCMChecks now calling:
CMake Warning at /opt/rocm/share/rocm/cmake/ROCMChecks.cmake:46 (message):
  'CMAKE_CXX_FLAGS' is set at
  /home/junliu/MIOpen/build/_deps/googletest-src/googletest/CMakeLists.txt:<line#>
  shown below:
Call Stack (most recent call first):
  build/_deps/googletest-src/googletest/cmake/internal_utils.cmake:9223372036854775807 (rocm_check_toolchain_var)
  build/_deps/googletest-src/googletest/cmake/internal_utils.cmake:42 (string)
  build/_deps/googletest-src/googletest/cmake/internal_utils.cmake:72 (fix_default_compiler_settings_)
  build/_deps/googletest-src/googletest/CMakeLists.txt:83 (config_compiler_and_linker)

*-----------------------------------------------------------------------------*
*******************************************************************************

*******************************************************************************
*------------------------------- ROCMChecks WARNING --------------------------*
  Options and properties should be set on a cmake target where possible. The
  variable 'CMAKE_CXX_FLAGS' may be set by the cmake toolchain, either by
  calling 'cmake -DCMAKE_CXX_FLAGS=""'
  or set in a toolchain file and added with
  'cmake -DCMAKE_TOOLCHAIN_FILE=<toolchain-file>'. ROCMChecks now calling:
CMake Warning at /opt/rocm/share/rocm/cmake/ROCMChecks.cmake:46 (message):
  'CMAKE_CXX_FLAGS' is set at
  /home/junliu/MIOpen/build/_deps/googletest-src/googletest/CMakeLists.txt:<line#>
  shown below:
Call Stack (most recent call first):
  build/_deps/googletest-src/googletest/cmake/internal_utils.cmake:9223372036854775807 (rocm_check_toolchain_var)
  build/_deps/googletest-src/googletest/cmake/internal_utils.cmake:47 (string)
  build/_deps/googletest-src/googletest/cmake/internal_utils.cmake:72 (fix_default_compiler_settings_)
  build/_deps/googletest-src/googletest/CMakeLists.txt:83 (config_compiler_and_linker)

*-----------------------------------------------------------------------------*
*******************************************************************************

[Actual Issue Tracked Here]:
https://github.com/RadeonOpenCompute/rocm-cmake/issues/154

Credit to @lawruble13

You can totally suppress the warning by setting the CMake cache variable ROCM_WARN_TOOLCHAIN_VAR to OFF prior to including rocm-cmake, but note that this also suppresses the warning for your own CMake as well (i.e. suppresses any true positives). At present, there is no way to temporarily/partially disable the toolchain variable warnings

Ideally, we shouldn't be building googletest in our cmake. It should be listed under requirements.txt(just add<EMAIL_ADDRESS>so rbuild/cget can build it once in the dockerfile instead of downloading and rebuilding this everytime.
This also avoids other issues in the cmake such as FORCE overwriting BUILD_SHARED_LIBS to Off, which can make a different ordering of includes in cmake always build miopen as static.
My original review feedback for this was ignored, but is still relevant:
https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1611/files#r912193677

@pfultz2 thanks! The original comment was not ignored, while we thought this is rather standard and officially recommended way of including gooletest, e.g. also in Triton: https://github.com/ROCmSoftwarePlatform/triton/blob/9517d4c2566cd2763d038b95b79713a04a36eac6/unittest/googletest.cmake#L10
I agree that it is not ideal that we rebuild this everytime.
Maybe ROCm should also have included googletest as a dependency to avoid too many different versions among different components.

@xinlipn could you follow up with the above comment, and next time discuss how the way googletest should be installed?

According to CMake Dependency Guide the primary methods of bringing dependencies into the build are the [find_package()](https://cmake.org/cmake/help/latest/command/find_package.html#command:find_package) command and the FetchContent module. The ROCm-CMake ROCMCheck is too restrictive on third-party projects. However, that can resolved by using the SYSTEM attribute for FetchContent_Declare().


io_uring fixes and new syscalls

There are 3 commits here:

fixes io_uring_setup on latest kernels, otherwise the tests segfault
makes the API simpler which seems to encourage coverage
adds some newer io_uring API's

Running locally with only these I seem to get semi-decent io_uring coverage even on my 8 core system. Certainly more than on the syzkaller homepage
One thing to note: I think it would be useful to have a function syz_io_uring_submit_enter. I can fold that into this PR if you like (https://github.com/DylanZA/syzkaller/commit/7db7451074437099e8390dcbb6cfbc98632530cc)
It seems that most inputs don't actually submit to io_uring, since syz_io_uring_submit does nothing by itself. I guess there is an argument that the fuzzer should find the submit() call itself, so I wasnt sure if you would like to stick that in

one other thought is that the submit could emit a "resource" which is consumed by a syz_io_uring_enter, that might encourage chaining and then entering

That's an interesting idea. A potential issue (hard to say how big without running) is that syzkaller will start wasting time mutating that resource parameter, whose exact value is actually of no importance.

Overall, there indeed exists some problem with io_uring fuzzing. I've just looked into the corpus of one of the syzbot instances. It did not have a big uptime, so not all corpus programs were re-triaged, but still: 809 io-uring calls in total, while only 20 of them are io_uring_submit.
If we follow the https://github.com/DylanZA/syzkaller/commit/7db7451074437099e8390dcbb6cfbc98632530cc approach, we should also let the fuzzer set all arguments of __NR_io_uring_enter, otherwise we unnecessarily limit it. Also, to cover the case of several SQEs, we should pass not just one SQE, but an array of them, so it's also +1 more parameter (array length). That's quite a few.. But we can still do it and see in small experiment whether it improves the situation. If it does, that'd be the easiest solution.
The best way would be to take a look at why exactly syzkaller is ignoring those io_uring_submit calls -- they should make io_uring_enter return more coverage, so it must be of interest to a coverage-guided fuzzer. Or is io_uring processing those SQEs not in the io_uring_enter syscall context, but rather in some background thread?
Given that I'll be only able to look closer at the problem in no less than 1-2 weeks from now, I wonder whether we should just merge the current PR as is. It's already greatly improving the io_uring fuzzing in syzkaller. The io_uring_submit problem could be dealt with separately.

Given that I'll be only able to look closer at the problem in no less than 1-2 weeks from now, I wonder whether we should just merge the current PR as is. It's already greatly improving the io_uring fuzzing in syzkaller. The io_uring_submit problem could be dealt with separately.

I think thats a good idea.
It's possible that with a big enough cloud pool, and with my fixes in this PR - there will not be a need for the extra complexity.


Fix failing test on develop

com.faforever.client.chat.ChatChannelUserItemControllerTest > testSetChatUser FAILED
    org.mockito.exceptions.verification.WantedButNotInvoked at ChatChannelUserItemControllerTest.java:130

After this test failing on develop several times I added @Ignore Annotation but it needs to be fixed in the future.

Also all other test from PircBotXChatServiceTest.class do fail randomly. It seems to be the connect method that has issues.

Addes @Ignore for the whole class

Funny because all of those tests probably need to be rewritten anyway for my ChatService refactor^^

Yes I hope u are gonna refactor them for good


Enhance support for CAST and/or CONVERT functions for more data types

Is your feature request related to a problem? Please describe.
Functions CAST and CONVERT are not fully supported. A user should be able to convert data between the following types: integer, double, [var]char, date, datetime, time.
Describe the solution you'd like
Support them according to the standard: cast, convert.
Describe alternatives you've considered
STR function could be used to convert data into strings, but it also not supported.
Additional context
String to float CAST works:
curl -XPOST http://localhost:9200/_plugins/_sql -H 'Content-Type: application/json' -
d '{"query": "SELECT cast(\"25.5\" as float)"}'
{
  "schema": [
    {
      "name": "cast(\"25.5\" as float)",
      "type": "float"
    }
  ],
  "datarows": [
    [
      25.0
    ]
  ],
  "total": 1,
  "size": 1,
  "status": 200
}

But not in vice-versa:
curl -XPOST http://localhost:9200/_plugins/_sql -H 'Content-Type: application/json' -d '{"query": "SELECT cast(25.5 as varchar)"}'
{
  "error": {
    "reason": "There was internal problem at backend",
    "details": "class com.alibaba.druid.sql.ast.expr.SQLNumberExpr cannot be cast to class com.alibaba.druid.sql.ast.expr.SQLIdentifierExpr (com.alibaba.druid.sql.ast.expr.SQLNumberExpr and com.alibaba.druid.sql.ast.expr.SQLIdentifierExpr are in unnamed module of loader java.net.FactoryURLClassLoader @1a01d7f0)",
    "type": "ClassCastException"
  },
  "status": 503
}

CONVERT:
curl -XPOST http://localhost:9200/_plugins/_sql -H 'Content-Type: application/json' -d '{"query": "SELECT convert(varchar, 25.5)"}'
{
  "error": {
    "reason": "Invalid SQL query",
    "details": "Cannot invoke \"com.alibaba.druid.sql.ast.statement.SQLTableSource.getAlias()\" because the return value of \"com.alibaba.druid.sql.dialect.mysql.ast.statement.MySqlSelectQueryBlock.getFrom()\" is null",
    "type": "NullPointerException"
  },
  "status": 400
}

curl -XPOST http://localhost:9200/_plugins/_sql -H 'Content-Type: application/json' -d '{"query": "SELECT convert(double, \"25.5\")"}'
{
  "error": {
    "reason": "Invalid SQL query",
    "details": "Cannot invoke \"com.alibaba.druid.sql.ast.statement.SQLTableSource.getAlias()\" because the return value of \"com.alibaba.druid.sql.dialect.mysql.ast.statement.MySqlSelectQueryBlock.getFrom()\" is null",
    "type": "NullPointerException"
  },
  "status": 400
}

This issue affects TDVT tests:

exprtests/standard\setup.cast.str.txt
exprtests/standard\setup.cast.int.nulls.txt

The initial efforts were put on conversion from string to date/bool types:

https://github.com/opensearch-project/sql/pull/166
https://github.com/opensearch-project/sql/pull/171

More support are needed and thus use this issue to track all further requirements:

https://github.com/opensearch-project/sql/issues/571


[WIP]Fix header comment & declare strict integration

This is a failing test case which 'proves' the bug in #3467

I think the solution proposed by @BackEndTea is the way to go. The fixer should check all possible positions of the header (after_open and after_declare_strict for now) and remove it from positions that are not the expected one.
This should prevent conflicts with declare_strict_types and fix an edge case: if one changes the configured position of the header, the fixer will duplicate the header even if the declare statement is already there, because currently the fixer only checks the configured position, not the other ones.


Tech: Keep MavenCentral badge up-to-date automatically.

This PR replaces the static badge displayed in the Readme page, automatically generating one with the current version found on Maven Central, and providing a link for download.

Many thanks @darvld !


Error in reporting line

Infer reports a Null Dereference error for the the following code snippet.
@Override public String getSelectedProtocol(SSLSocket socket) {
      if (getAlpnSelectedProtocol == null) return null;
      if (!getAlpnSelectedProtocol.isSupported(socket)) return null;

      byte[] alpnResult = (byte[]) getAlpnSelectedProtocol.invokeWithoutCheckedException(socket);
      return alpnResult != null ? new String(alpnResult, Util.UTF_8) : null;
    }

Infer message:

object context last assigned on line 261 could be null and is dereferenced by call to readFieldOrNull(...) at line 267

267 is the method header line.

Hi @achilleasxy. I don't see either readFieldOrNull or an object named context in the code snippet. Does it exits somewhere else in the project ? In which case it could be an issue about reporting the errors in the right place.

Definitely a reporting error then. readFieldOrNull and context appear in the following methods which start on line 85 and 224 respectively:
public X509TrustManager trustManager(SSLSocketFactory sslSocketFactory) {
    // Attempt to get the trust manager from an OpenJDK socket factory. We attempt this on all
    // platforms in order to support Robolectric, which mixes classes from both Android and the
    // Oracle JDK. Note that we don't support HTTP/2 or other nice features on Robolectric.
    try {
      Class<?> sslContextClass = Class.forName("sun.security.ssl.SSLContextImpl");
      Object context = readFieldOrNull(sslSocketFactory, sslContextClass, "context");
      if (context == null) return null;
      return readFieldOrNull(context, X509TrustManager.class, "trustManager");
    } catch (ClassNotFoundException e) {
      return null;
    }
  }

    @Override public X509TrustManager trustManager(SSLSocketFactory sslSocketFactory) {
      Object context = readFieldOrNull(sslSocketFactory, sslParametersClass, "sslParameters");
      if (context == null) {
        // If that didn't work, try the Google Play Services SSL provider before giving up. This
        // must be loaded by the SSLSocketFactory's class loader.
        try {
          Class<?> gmsSslParametersClass = Class.forName(
              "com.google.android.gms.org.conscrypt.SSLParametersImpl", false,
              sslSocketFactory.getClass().getClassLoader());
          context = readFieldOrNull(sslSocketFactory, gmsSslParametersClass, "sslParameters");
        } catch (ClassNotFoundException e) {
          return super.trustManager(sslSocketFactory);
        }
      }

      X509TrustManager x509TrustManager = readFieldOrNull(
          context, X509TrustManager.class, "x509TrustManager");
      if (x509TrustManager != null) return x509TrustManager;

      return readFieldOrNull(context, X509TrustManager.class, "trustManager");
    }

Are the two definitions of trustManager in two different inner classes ?

Sorry for late response. Yes the first is in the public outer class and the second is in the static inner class that extends the outer class. It is from Okhttp version 3.2.0 in the Platform.java file.

Hi,
Is there any update on this issue?
I am not sure whether it is actually a true or false positive, but in any case it is incorrectly reported on a different line.

I cannot reproduce infer finding the bug mentioned originally using the latest infer and okhttp from today or from 25 Sep 2016, so cannot check if it's reported at the right line. Closing optimistically, please re-open with a concrete example.


419 status

I tried to post form data from shopify to my laravel app using jquery ajax. but it is showing 419 status.

Don't think this is an issue with the package.
Its probably from CRSF token missing when you do the post request. Google "419 AJAX Laravel" for more information.
Essentially, you'll need that route run through the api group instead of the standard web group.

I excluded the path from the csrf validation and it worked fine.

@nithinnitzarya instead of excluding it from the csrf validation you should add the csrf token to your requests.
It's as simple as adding the @csrf tag in your form on the blaze template.


Please publish pre-release versions to NPM so we can npm i them.

Foundry VTT Version
v12
Related Problem
It is complicated (or adds a lot of files to your project) when loading the prerelease version of the files from GitHub releases manually (or using a git module).
Desired Solution
It would be great if you could publish the prerelease packages on npm so we can npm i them. NPM should understand that 12.331.0-beta and 11.315.0-beta are pre-release.
Alternative
No response
Additional Context
No matter the outcome of this issue, the work you guys are doing is great! Having d.ts files is so helpful! Thanks.

Hi, I've gone ahead and published 12.331.1-beta for you! I haven't published a 11.315.1-beta because I am currently unaware of any devs that are building on v11 with types but if that meets your description I'd be happy to release that to.
However I will note that my current recommendation is to periodically run npm add --include=dev github:League-of-Foundry-Developers/foundry-vtt-types#main. You have to rerun it because it doubles as both adding the first time and updating later. Your package-lock.json file will store the commit hash and so it won't get updated. My main rationale for this recommendation now is that the branch is constantly getting new PRs merged which would likely warrant a release every couple days or at most every week if I wanted people to stay on top of things.
The main reason why I hadn't made a release on npm before is that I used to consider the branch so unstable that it really warranted having a direct line of communication with me to make sure you understood the issues the project has been grappling with and what's an avoidable (if sometimes cryptic) error in your system and what I need to intervene to help you with. Opening the 'flood gates' so to say would be hard to do with proper expectation management and support.
Things are better now but there's still noticeable areas of work. I would still recommend joining the "League of Extraordinary FoundryVTT Developers" at https://discord.gg/73HTMuK7dT in order to make sure we can prioritize the parts of Foundry you'll be working as well as to help you sort out issues. It's not mandatory or anything but documentation for many of the new features are a WIP and you're extremely likely to run into rough edges. Plus I always try to put whatever people actively need at the present moment as my first priority.
The branch is down to what I'd consider 1 critical error and I do have a known fix for it, it just requires a somewhat large refactor. Only one large error is great but there are plenty of tests failing with patterns that someone should be able to do but currently can't. As an example of something like that something.update({ "some.dot.path": 1 }) doesn't function at this current moment simply because I haven't been prioritizing making sure that dot key paths work again (you can do nested objects though). They had a historical implementation of course but turns out we can't just lug it into the present.

Thanks a lot; I understand your concern about releasing a package too early.
I did not know about the npm add --include=dev github:League-of-Foundry-Developers/foundry-vtt-types#main command. This is very useful. I can see myself using this command for other projects now.
Also, it sounds like a good line to add to your docs/README file. If you don't mind me revisiting the README, I'll try to find a few minutes to open a PR for it (in the upcoming week or so.

I decided I should just update the README myself, thanks for reminder! I suppose in more technological terms it's been in a pre-alpha for so long that I'm only now transitioning to the message of it being a beta.
The docs will come later, I have someone who's committed to doing an entire revamp in the near but not immediate future.

Ok, well, the case is closed then. Thanks again, I'll close this issue.


FIND-88 add tag to Find View

I think we also need a Scalar view here, that is a view where the keys are UFIX64, the reason is that we want them represented as numbers in typesense so that we can do less then/greater then operations on them.
Can you also add the same view called Scalar where the only difference is that the value is UFix64. And add a method to Scalar to be able to add a UINT64 key and convert it to UFix64?


An idea about "track"

Hello, i have an idea about "track". When track shows us items, he signs them with numbers with "K", is that the price, right?
Is it possible to add the ability to filter items by price like in "tracks/sr" with rarity?
Is it also possible to track multiple items in one command? Ex: track kek, ledx, card;
Best regards :)

Hello. Thank you very much for the trainer, all functions work. But I can't enable tracker functions. When I turn them on in the GUI, nothing changes in the game. I can't figure out what I'm doing wrong. Can you tell me what exactly and where to include, or can I write it in the ini? Or give me an ini file with the function enabled and working so that I can replace mine?

you have to user the track <item> command to add an item to the tracklist.
This way you can keep your tracklist and choose in the GUI to display tracked items or not. Have a look at the main readme. Everything is explained.


RSDK-2016 - Add module

Ticket: https://viam.atlassian.net/browse/RSDK-2016

Implements module

Tested on:

MacOS Intel
RPI

I think it makes sense to setup an example config and switch to TransformMapAttributes...  in this PR (similar to orb). Happy to approve if you want to split though


Add segment to instrumentation, fixes #1640, fixes #1344

The Problem/Issue/Bug:
#1640 requests adding instrumentation pointed at Segment.
This adds it, with a starting set of attributes/properties and a hashed hostID as the user id.
How this PR Solves The Problem:
Here's what's currently being delivered to Segment:
client.Track(&analytics.Track{
  UserId: "ccb22589fa984b1772a5bccd8972bb19e267337f175178566339258146433942",
  Event: "start",
  Properties: map[string]interface{}{
    "bgsyncimg": "drud/ddev-bgsync:v1.9.0",
    "dbaimg": "drud/phpmyadmin:v1.9.0",
    "dbimg": "drud/ddev-webserver:20190703_klonos_backdrop",
    "dockerComposeVersion": "1.24.0",
    "dockerVersion": "19.03.0-rc2",
    "isDockerToolbox": false,
    "php_version": "7.2",
    "router_http_port": "80",
    "router_https_port": "443",
    "router_status": "healthy",
    "ssh_agent_status": "healthy",
    "status": "running",
    "type": "drupal8",
    "version": "v1.9.1-8-g4cabde3c",
    "webimg": "drud/ddev-webserver:20190703_klonos_backdrop",
    "webserver_type": "nginx-fpm",
  },
})

Manual Testing Instructions:
Download one or more of the build artifacts and experiment with various ddev commands.

You should see the user and the event represented in Segment (debug tab)
The event should have what you want in it.
Sentry should also show the same event (and it has ServerHash in it to correlate the two services)

Automated Testing Overview:
No testing was added here.
Related Issue Link(s):
#1344 requested removing some sensitive data from Sentry, this removes at least some. I couldn't figure out how to get rid of server_name with the current API, maybe in the future with https://github.com/drud/ddev/issues/1703
#1640 "Replace sentry with segment"
Release/Deployment notes:

We need to set the Sentry key to what it will be before release. It's currently pointing to the ddev-loal-dev. All we have to do is change it in CircleCI

@unn current artifacts are at https://circleci.com/gh/drud/ddev/15433#artifacts/containers/0 - I'd love to have you take this for a spin and look at the resulting data.

Latest artifacts are at https://circleci.com/gh/drud/ddev/15534#artifacts/containers/0


Fixinglinks to MAST example notebooks

The links to the MAST example notebooks were broken, this just fixes them.

👍 thanks!


Check IP addresses assignment in code against CONTRIBUTING.md

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.592%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
594

Relevant Lines:
892

💛  - Coveralls


Missing init function completion inside object constructor expression

Description:

Steps to reproduce:
Affected Versions:
2201.2.0

@gayalkuruppu Is this a valid requirement?

@gayalkuruppu Is this a valid requirement?

We can have init() method inside object constructor expression to initialize object fields. https://ballerina.io/spec/lang/master/#object-field


[FLINK-12823][datastream] PartitionTransformation supports DataExchan…

…geMode property
What is the purpose of the change

Since StreamTransformation would also support batch runner in 1.9, the result partition type of StreamTransformation should not be hard-coded with PIPELINED_BOUNDED
We need to provide a way for upper level API upon StreamTransformation to configure the result partition type of edge

Brief change log

Expose a property DataExchangeMode of PartitionTransformation as an internal API of StreamTransformation
Pass the DataExchangeMode to StreamEdge
StreamingJobGraphGenerator chooses the appropriate result partition type based on DataExchangeMode of StreamEdge

Verifying this change

Add an unit test of StreamingJobGraphGeneratorTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

I think we should not reuse the existing DataExchangeMode because it is a runtime class in the flink-runtime package. At some point we want to decouple the StreamTransformations and the DataStream API from runtime so we should not introduce more dependencies. I would suggest to add a new enum next to PartitionTransformation (in the same package) for this purpose, it should probably also be declared @PublicEvolving.

Hi @aljoscha

Hi @aljoscha
I have rebased master and addressed comments.

Thanks! I think I can merge once Travis is green. 👌

Travis failed, there is am importing error in python module. I don't think it is caused by this PR. I will try to rebase master and trigger travis checking again.

Python module is fine but connectors module failed this time on Travis checking. It seems a travis relevant issue. I have filed a JIRA issue for this, https://issues.apache.org/jira/browse/FLINK-12866
Will trigger checking again through close and reopening, hope it works.

I merged this. Thanks for working on this with me! 👍


Preserve newlines to be able to support line comments properly

Removing newlines has some unwanted side effects like line comments not
terminating at the end of the line anymore.

CC @emilywoods


Added FP precision test

This both mismatches with Dromajo and prints FAIL upon mismatch for when not cosimulating with Dromajo

Thanks!


@pipe decorator

See https://github.com/DAGWorks-Inc/hamilton/issues/65
Changes

[ ] Add pipe decorator

How I tested this

[ ] Lots of testing, end-to-end included

Notes
Checklist

[x] PR has an informative and human-readable title (this will be pulled into the release notes)
[ ] Changes are limited to a single goal (no scope creep)
[x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future TODOs are captured in comments
[x] Project documentation has been updated if adding/changing functionality.

in person conversation notes:

apply --> step
stick with named
get example added


Add dedicated routes for storing/fetching partial uploads in/from bus

This is an alternative implementation of https://github.com/SiaFoundation/renterd/pull/562

@alexfreska we ended up going the 2 route way. So the partialSlabs field changed a bit.

should we wait for UI changes or how are we going to go about this cc @ChrisSchinnerl ?


[Question] Disable sway window resizing

Hello! Thanks to all developers and maintainers for waybar, i switched from xorg to wayland and am loving the experience.
I'm not sure if this has been asked before, but is there any configuration for disabling the behaviour that resizes sway windows when waybar is launched?
I think it may happen on waybar side. ~I suspect it happens in this code~ Nope, that's just the sway module.
I know this is kinda specific to my workflow, but i wanted to disable this behaviour for two reasons:

Toggling the bar without resizing the entire desktop
Reloading the bar (i use flavours to quickly change desktop color schemes) without windows jumping around

Is this currently configurable? If not, i can try and write a PR for it, if the maintainers think it fits the project and would be useful.
Thanks <3

Hi, check the layer option from config file :)

Hey, that behaviour seems to occur with layer set to both bottom or top:

Sorry for bothering, but i'm still facing this issue. Waybar still makes windows jump when restarted or reloaded, this occurs with both bottom and top.

+1, having that issue on the latest v.0.9.7 too, despite whichever layer option I choose


Unifying bootstrap scripts in single bootstrap file

This commit combines all the bootstrap files in a single bootstrap, configurations can be passed in at the runtime.
This allows us to manage a single bootstrap file, rather then multiple files per OS and per Cloud provider.
Tested this all on DO, needs to be tested on AWS, and GCE.

Thanks for the PR - this is an interesting approach and I haven't thought about doing this before.. let me think on it for a few hours today and I will follow up.
Also I am wondering how this will play with #183

It's a great idea, but I don't like that things can get very messy.
In the proposed state, script can is very hard to follow.
What's gonna be on cloud provider, where you will continue... This makes editing script by contributors and users who will use their scripts much harder. We will probably add ArchLinux, CoreOS and other OSes as well. There's plans for Heptio and Ark. Script will get few thousands of lines and probably nobody will want to read that.
Also, we will get at the point when scripts could differ a lot. For example, we can implement #276, which could change DO script a lot compared to other providers. Probably it will not, but we never know with what we will come up.
I think it's best to leave it as it is, but just split scripts by directories. Create directory for each provider. Maybe we can use this approach to use one script for multiple OSes (e.g. Ubuntu and CentOS), but still only under single provider. That will make maintaining scripts easier and it should not be messy.
/cc @prateekgogia @kris-nova

Problem with having individuals files is maintenance, right now its just 3 Cloud providers and 2 OS. Here, we are talking about m X n number of files to manage. In which all the configurations are same except few variables to be configured, like ubuntu in DO, AWS, GCE only differs in how they compute public and private address. Now, computing public and private address is same for all cloud provider specific files. Lets say, tomorrow if we find a better approach to getting Ip address for a cloud provider, we need to change all the files for that cloud providers.

In the proposed state, script can be very hard to follow.

These are just few if / else checks, I don't think it's that hard for any newcomer even, given my existing bash skills :). Do you have any suggestions to make it easier, in a single file.
My only concern is to stay DRY.

So here are my thoughts.. (Forgive me as this might be a bit of a brain
dump, but I will try to stay focused)
1. The bootstrap scripts are temporary
According to our last maintainer call with @prateekgogia , and a
discussion I had with @roberthbailey and @pipejakob.. we want to start
looking at a hardened bootstrap utility anyway
https://github.com/kris-nova/kubicorn/issues/289
2. I think repeating yourself is okay
In the name of sticking with operational empathy AND developer
empathy we are at a bit of a conflict here. Operators want to have
single, easy to grok, easy to change bootstrap scripts (as we have
today) while developers would prefer a single easily testable script to
rule them all (as is in this PR)..
My prescription here would be that it is fine to repeat yourself so
long as you explicitly call it out, and you do it tastefully.
For instance if we are having shared logic for  computing public IP
addresses I would rather see that in a function file as a library such
as..
#!/bin/bash
set -e

. functionfile.sh

$PUBLIC_IP=getPublicIp

But at the end of the day, I am completely okay with our bootstrap
script count growing. The whole point of kubicorn is to introduce an
un-opinionated framework for users wanting to use kubernetes.
3. My attempt at a win-win solution
So sorry this took longer than expected for me to process, but I need to
do that sometimes. Anyway here is what my processing came up with.. So I
wanted to see what everyone else thinks..

Merge in the new all-on-one bootstrap script
Do NOT delete the old bootstrap scripts
Focus on coding the --set option as defined in #324 so that we can easily switch between the two avenues of bootstrapping for the time being. (Note: I would still prefer to keep the bootstrap scripts as they are today as the profile defaults, but am open to changing that)

@prateekgogia what are your thoughts here?
Also a reminder that with new features like this we probably should open up an issue first, so that we can have these types of discussions before anyone starts investing time into code. Yeah?
Anyway happy to hear reasons to do it otherwise, you guys rule.

@kris-nova Yes, I am ok to keep the existing structure and files. I would not prefer keeping both the approaches, as it might be confusing for people to start looking with. I am ok to not merge this for now.
Yes, I wanted to open an issue first, but just kept on testing these changes and forgot to open an issue. Will do next time onwards.

Closing this for now.


FEATURE REQUEST

A toggle feature for the floating reading/editing action button on the new Sanctum update. I will say it's growing on me... But my preference is for it to remain in the header.
Thanks so much!

Just writing a reply to tell you that I've added this to the Roadmap.

As this was added in the latest release, I'll go ahead and close the issue.


Inconsistent Indentation

The code has inconsistent indentation. Here is one example.
Indentation should only be used when it has meaning; this looks random to me.
Running your entire code through ClangFormat is one way of fixing this and a number of other stylistic problems, such as using tabs instead of spaces, not alphabetizing includes, &c. If you are using VS Code this is easy to do by using the clang-format plugin.
Reading the Google C++ Style Guide or a number of other style guides will explain the pros and cons of a number of stylistic choices along with providing an authoritative reference source.
If the plugin produces dissatisfactory results, this page links to a number of style guides that clang-format knows about and can use.

Thanks for your suggestion, we have addressed this issue.


Update CODING_STANDARDS.md

Fixed a typo.
Issue #, if available:
Description of changes: Fixed a typo - the word UpperCamelCase had an extra 'm'
Check all that applies:

[X ] Did a review by yourself.
[ ] Added proper tests to cover this PR. (If tests are not applicable, explain.)
[ ] Checked if this PR is a breaking (APIs have been changed) change.
[ ] Checked if this PR will not introduce cross-platform inconsistent behavior.
[ ] Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

[ ] Linux
[ ] Windows
[ ] Android
[ ] MacOS
[ ] IOS
[ ] Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This change has been implemented, thanks for the PR and sorry for the lack of response


Enable Override of $fpm_service_name in case of using php7.0

Added possibility to override fpm service name in case of using php7.0

Checked on my own project, works fine.
Ability to set fpm_service_name to main php class works fine.

$name is reserved, please see https://docs.puppetlabs.com/puppet/latest/reference/lang_reserved.html#reserved-variable-names
by reverting the service_name -> name change back, the build should get green

@mmoll Thanks, I didn't know about it.
Fixed this as fast as I could.

please squash your commits together into one and add closes GH-161 to the commit message, looking good otherwise :+1:

@mmoll, all done. Thanks a lot for helping.

merged, дякуємо / спасибо @okolesnyk!


StyleCop settings

Apologies - I know this has been asked before but I'm still unclear on where the settings come from (admittedly I've never got my head around R# layers). I'm using VS2013 with R# 9.2 and the "StyleCop by JetBrains" extension.
If I go into R# -> Manage Options, I see a list of various layers. Starting from the bottom:

"Extensions", with a child "StyleCop.StyleCop >> StyleCop"
"Resharper 8 global settings"
"This Computer". Editing this, all StyleCop code inspection rules are set to "Warning".
A child under "This Computer", which is our dev team's ".DotSettings" file. Editing this, I can see a couple of dozen rules that we set to "Do not show" a long time ago.
"Solution xxx personal " and "Solution xxx team-shared". Editing these, all StyleCop code inspection rules are set to "Warning".

Here's my first source of confusion (and I realise this is a probably R# thing rather than StyleCop): I thought the upper layers were meant to override the lower layers, but this can't be the case as I would expect to see warnings for every StyleCop rule, which doesn't happen. (On a side note, I find the R# UI confusing as it doesn't tell you whether an individual setting is set in that layer, or inherited from a lower layer. Or am I missing something?).
My main issue is that changing a rule in the above .DotSettings file/layer (under "My Computer") seems to have no effect, especially having always assumed this was our "definitive" rule set. In fact, just trying it right now, changing a rule in the top "Solution xxx personal" layer has no effect either. Do I have all this wrong, and is your extension getting its rules from elsewhere? We have a .stylecop settings file in a "root" folder to where all our solutions are located, but changing a rule in here has no effect either.
(For the most part, our editor warning squiggles do match the SAxxxx warnings that we have turned on, so we never had any reason to think there was an issue with how the layers work or where the StyleCop rules are coming from).

Layers are very powerful, but also subtle. Three things:

Upper layers do override lower layers
Values are only written to a layer if it's different to layer(s) below it
Editing a layer in isolation shows you what's different between that layer and the hardcoded defaults. It does not include any layers that would normally be lower than it

So, editing the shared solution settings layer means you don't see the "Do not show" settings from your team's .dotSettings file. Changing the values to "Warning" when editing just that layer does nothing, because the hardcoded defaults are "Warning".
Basically, you should always edit with ReSharper → Options and use the Save To button to write the values to the correct layers. You should now see the team .dotSettings file "Do not show" settings.
If you reset these values and hit save, ReSharper will save to the lowest possible layer, in this case, the team .dotSettings file. It will compare the new value with the layer(s) below, realise that they are the same as the hardcoded defaults and simply remove them from the team .dotSettings file.
If you reset the values and hit Save To and save to the shared team settings layer, ReSharper will want to write there. It will compare with the layer(s) below. It sees a different value in the team .dotSettings file and so writes the new values to the shared team settings layer. If you were trying to set it to "Do not show", it would see that the same value is in the team .dotSettings file and not write anything to the team shared settings layer.
Does that make sense?
As for how this interacts with StyleCop settings, if a rule is disabled in settings.stylecop, then it doesn't get run, even if the ReSharper setting is set to "Warning" or "Error". If the rule is enabled, it gets run, and any squigglies are then evaluated against the ReSharper setting, and shown as a warning or suggestion, or even not shown at all. It's really a way to set the severity of a rule, rather than disable it - StyleCop should be in charge of that.
I'm going to close the issue, feel free to reopen if you need to.


[Bug]: Leading zeros are stripped from values in plain text columns containing numeric data in Google Sheets

Is there an existing issue for this?

[X] I have searched the existing issues

Description
A user has a sheet in Google Sheets with a column formatted as plain text, but it contains all numeric values. Many of the entries in this column have a leading zero. The values in this column are interpreted as numbers, so we treat it as a number column. Since it is a number column, we parse all values as integers, which strips the leading zero from columns containing it.
The expectation is that Appsmith will respect the column format settings and treat values in the column as strings.
Steps To Reproduce

Create a new sheet in Google Sheets with a single column.
Copy the following table into column A.

data

100

099

098

Select column A and format it as plain text.
Create a new Google Sheets query in Appsmith.
Query the sheet you just made.
Run the query.
Observe that the leading zeros have been removed from rows two and three.

Public Sample App
https://app.appsmith.com/app/stripped-leading-zeros/example-647ff2cf8def701da13da1d8
Environment
Production
Issue video log
No response
Version
Cloud v<IP_ADDRESS>-SNAPSHOT

Related: https://github.com/appsmithorg/appsmith/issues/24304

Related: https://github.com/appsmithorg/appsmith/issues/23148


case sensitivity

If there's an uppercase name it's confusing.  Make it not suck.
The client:

toLowerCase() the pkg.name whenever a package.json is read (and print a warning)
toLowerCase() any names of packages anywhere whenever hitting the registry

On the server:

toLowerCase() the name in the registry's _updates/package and _views/package functions
Manually update the registry's contents to be lowercased

I was about to post an issue for that.
I think it's not good to allow different packages with same name but different case.
There's already some packages like that, it's confusing, and it can be in some way used to undermine original package.


Research ways to implement polymorphic functions in Ui

Currently Ui contains functions that differ in parameter types. For example, there are four push_id functions:
    pub fn push_id_str(&self, s: &str) {
            let start = mem::transmute::<*const u8, *const i8>(s.as_ptr());
            let end = start.offset(self.len() as isize);
            ((*ui.api).push_id_str_range)(start, end);
    }

    pub fn push_id_usize(&self, id: usize) {
        unsafe { ((*self.api).push_id_ptr)(mem::transmute(id)) }
    }

    pub fn push_id_ptr<T>(&self, id: &T) {
        unsafe { ((*self.api).push_id_ptr)(mem::transmute(id)) }
    }

    pub fn push_id_int(&self, id: i32) {
        unsafe { ((*self.api).push_id_int)(id) }
    }

Is there a way to have single statically-dispatched method for this?
Without strings it could be done pretty easily:
pub trait UiId {
    fn push(&self, ui: &Ui);
}

impl UiId for i32 {
    fn push(&self, ui: &Ui) {
        unsafe {
            ((*ui.api).push_id_int)(*self)
        }
    }
}

impl<'a, T> UiId for &'a T {
    fn push(&self, ui: &Ui) {
        unsafe {
            ((*ui.api).push_id_ptr)(mem::transmute(&self))
        }
    }
}

impl Ui {
    ...
    pub fn push_id<T: UiId>(id: T) {
        id.push(self);
    }
    ...
}

This works pretty well and api behaviour is expected. However &str implementation can behave not as expected:
impl<'a> UiId for &'a str {
    fn push(&self, ui: &Ui) {
        unsafe {
            ...
        }
    }
}

If we call this with anything &str-like, reference-type will be used:
let x = "abc".to_string();
ui.push(&x);

This code will execute reference-type push_id which is unexpected behaviour. We could implement a broader version like this:
impl<'a, T: Into<&'a str>> UiId for T {
    fn push(&self, ui: &Ui) {
        unsafe {
            ...
        }
    }
}

But such an implementation forbids any other. So there is either one broad implementation or several implementations for concrete types.

I haven't used generic enough to know how to implement this. Maybe you could post this on the users.rust-lang.org forum and ask?


normalize new lines for Vision test

After this, all Windows tests (unit and system) pass!

Coverage remained the same at 100.0% when pulling 84c72164eec291596eac02b37eb6761c0abd036e on stephenplusplus:spp--windows-clrf-tests into 55aeb1fb2d2c40703dfe77d8976094c1ba6118cd on GoogleCloudPlatform:master.

💃


Add channels support to the Habitat type

Habitat applications can exist in the different "channels" -
like "staging", "production", "unstable" etc. Those names
can be configured by the user.
Those channels will be expressed as labels in Kubernetes.
There is also a possibiity of promoting Habitat applications.
This action is expressed by HabitatPromote object, which needs
to be created in order to perform it.
To test that functionality, you can use the example yml files:
kubectl create -f examples/standalone/habitat.yml
kubectl create -f examples/standalone/habitat-promote.yml

Fixes #126
Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

All newly built packages are automatically put on unstable to indicate there is a new build. A user then must do a promotion command (e.g. hab pkg promote foo) to promote a package to a different channel.
You can attach a label to a group of services, Application.Environment, with the idea being you can use this as an organizational principle to do group promotion of various tiers of your application. This is a capability we haven't fully fleshed out/made available yet.
For now, you should have the ability to promote a package from unstable to foo to stable. All packages by default will have at least an unstable and stable channel. Additional channels are user defined and added, and there can be as many as you want to power the promotion experience you want.

PTALA

@nhlfr it seems your tests failed, I re-trigged the build. Will have a look once they pass. :)

@asymmetric ptala

Also, tests are failing.

Needs to be re-designed and re-implemented

I'm not deleting the branch just to keep the code visible

What's the discussion that led to this decision?

we talked about it offline but the basic outcome was that a promotion should just be another
kubectl apply -f manifest.yml
For that the channel probably has to be part of the object name:
hab pkg ident: origin/pkg/ver/release, in channel unstable
becomes
origin-pkg-ver-release-unstable object (no need for random strings)
We don't have to remove the old deployment since that can be easily scripted if labels are set properly...


draft: Improve internal documentation and code style

The purpose of this PR is to improve readability of the source code by:

Reformatting it with ocamlformat
Updating the comment style
Introducing the MIT license header
Move the opam generation into the dune-project file (WIP)

I think this is a work we have to do before keep going on the development of the other issues.

@xavitator, do you agree to let me introduce your mail into the header file? I didn't want to do it without your agreement.
I still need to update the dune-project file to remove boilerplate code and get a cleaner opam file before requesting your review.

Codecov Report

Merging #56 (72d4863) into dev (0082840) will decrease coverage by 0.92%.
The diff coverage is 71.79%.

@@            Coverage Diff             @@
##              dev      #56      +/-   ##
==========================================
- Coverage   75.31%   74.38%   -0.93%
==========================================
  Files           9        9
  Lines         239      203      -36
==========================================
- Hits          180      151      -29
+ Misses         59       52       -7

Impacted Files
Coverage Δ

src/core/conf.ml
71.87% <55.55%> (+1.14%)
:arrow_up:

src/core/comparator.ml
50.00% <57.14%> (ø)

src/core/formatter.ml
73.52% <61.90%> (-2.23%)
:arrow_down:

src/core/monad.ml
62.50% <62.50%> (+16.34%)
:arrow_up:

src/core/finder.ml
70.37% <71.42%> (-6.78%)
:arrow_down:

src/core/reader.ml
76.92% <71.42%> (-7.70%)
:arrow_down:

src/core/writer.ml
88.88% <80.00%> (+1.38%)
:arrow_up:

src/core/comment.ml
78.84% <81.25%> (-2.83%)
:arrow_down:

src/core/FString.ml
83.33% <100.00%> (-3.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0082840...72d4863. Read the comment docs.

@xavitator, the CI is considered as a fail because the code coverage is less than the old one as I've rearranged the code.
You can overcome this and tell me if it's good for you. Once you approve, I'll merge it and consider the refractor work done.
As a consequence, I will focus on adding new features and write a readable documentation.


javascript style info?

You seem to have settled on certain formatting conventions and such.
Are they written down anywhere? I looked in the caja repo but didn't see anything.
Cite them from a CONTRIBUTING.md please?

I suspect https://github.com/airbnb/javascript is best as well as most representative of our style.

Thanks.


Migrate Xamarin.Forms Effect docs

MAUI now includes support for effects, but there are some small changes from Xamarin.Forms: https://github.com/dotnet/maui/pull/1574

This doesn't need adding to the MAUI docs, as there are better approaches using handlers.


Migration to Gutenberg: Remove references to react

Due to how the JS code is compiled, Gutenberg React code does not start with the standard import React from 'react';.
Hooks and utils that come from the react package would instead come from @wordpress/element.
For example, we'll need to refactor code from this:
import React, { useRef }  from 'react'

to:
import { useRef } from '@wordpress/element';

This is something we'll either do as a final step within this @itsjonq/g2 repo before migration.
Or, this is something we'll refactor when the code lands within Gutenberg.

We'll do this when we copy/paste the files into Gutenberg.
Moving this to Phase 2.


When using AnimationTree, AnimationStateMachines inside BlendSpace2D don't always auto start

Tested versions

Reproducible in: 4.2 stable, 4.1 stable

System information
Godot v4.2.1.stable - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 2060 (NVIDIA; <IP_ADDRESS>98) - AMD Ryzen 7 4800H with Radeon Graphics (16 Threads)
Issue description
If you use a BlendSpace2D with AnimationStateMachine blend points, specific blend points won't start on their own when in contiguous blend mode. This can be fixed by going into the state machine and pressing the start button or starting them in code, but this won't always work/persist or can be tedious depending on how many blend points there are. This issue does also carry over into builds and doesn't get fixed by pressing the start button in the state machines.

The depth of the BlendSpace2D doesn't seem to matter, it can be the root, a node in an AnimationStateMachine, or a node in a BlendTree in an AnimationStateMachine.

It seems to affect the blend points that aren't "in range" of the default blend value when started, so having the blend position start in one triangle would make that triangle work, and any other blend point won't. Haven't rigorously tested this though, but it seems consistent in a few different configurations.

Probably related to: #88262
Yes this can be worked around by starting each AnimationStateMachine in script, but this can be very tedious, and won't work in editor without converting your script into a tool script, which can be problematic.
Steps to reproduce

Create an animation Player with a few AnimationClips that are looping moving a sprite in different directions
Create an AnimationTree with a BlendSpace2D
In the BlendSpace2D, add at least 5 AnimationStateMachines points
In each AnimationStateMachine, add one animation that transitions from start and press play so it's active
If you pressed play in each state machine, the editor preview will work
Write a simple script to control the blend position and then run the scene, some of the points won't work anymore
Reload the project, now the editor preview should have some non-functioning blend points

Minimal reproduction project (MRP)
AnimationTreeBug.zip

Just turn on Sync.

Ah didn't know that's what sync does. It's not mentioned in the docs and it didn't work when I first tried it, though I realized that I had to reload the project for it to take effect in the editor.
Could I change this into a suggestion for "promp to reload blendspace when sync is enabled" since this might not be an obvious fix for those who don't know what sync does?

Just turn on Sync. Never related to #88262.


fix(deps): pin @keplr-wallet/cosmos dependency

This dep changed the use of starknet, causing breaking changes when uploading with kyve. Pinning to a working version until we resolve.
Reference: https://github.com/chainapsis/keplr-wallet/commit/2a8ca006f1992de94c509bb5220b0d65ced927f5

:tada: This PR is included in version 1.19.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixes import of watchjs module

Electron fails with Error: Cannot find module 'melanke-watchjs'
The docs for Watch.JS show require("watchjs") rather than require("melanke-watchjs"). https://github.com/melanke/Watch.JS/blob/master/README.md#nodejs-require

No, see the module no package:
  "dependencies": {
    ...
    "melanke-watchjs": "^1.3.0"
    ...
  }

require is right, this problem is in the published version on npm, and therefore does not match the issue #37

Sorry, I'm still confused. https://www.npmjs.com/package/melanke-watchjs shows 1.3.1 is the latest release. Which fits with the requirement of ^1.3.0 doesn't it?

I'm not talking about "melanke-watchjs", I'm talking about the versions of "electron-window-manager".
The files here are not the same here.


Export all environment variables from Guix not working

This tries to solved an issue in a generalized version, all the description can be found here: https://github.com/metacall/distributable/issues/4#issuecomment-820432394
The idea is to provide a standard way of defining all the environment variables for the CLI instead of defining them in a dirty manner.

This has been solved.


Sometimes terasology crashes with ClosedWatchServiceException while loading

@immortius  can you have a look at this one:
23:17:07.573 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: CoreSampleGameplay:0.54.0-SNAPSHOT
23:17:08.797 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception, attempting clean game shutdown
java.nio.file.ClosedWatchServiceException: null
	at sun.nio.fs.AbstractWatchService.checkOpen(AbstractWatchService.java:80) ~[na:1.8.0_40]
	at sun.nio.fs.AbstractWatchService.poll(AbstractWatchService.java:97) ~[na:1.8.0_40]
	at org.terasology.module.filesystem.ModuleWatchService.poll(ModuleWatchService.java:61) ~[gestalt-module-4.0.3.jar:4.0.3]
	at org.terasology.assets.module.ModuleWatcher.checkForChanges(ModuleWatcher.java:132) ~[gestalt-asset-core-4.0.3.jar:4.0.3]
	at org.terasology.assets.module.ModuleAwareAssetTypeManager.reloadChangedOnDisk(ModuleAwareAssetTypeManager.java:164) ~[gestalt-asset-core-4.0.3.jar:4.0.3]
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:410) ~[classes/:na]
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:358) ~[classes/:na]
	at org.terasology.engine.Terasology.main(Terasology.java:158) [classes/:na]
23:17:08.799 [main] INFO  o.terasology.engine.TerasologyEngine - Shutting down Terasology...
java.nio.file.ClosedWatchServiceException
	at sun.nio.fs.AbstractWatchService.checkOpen(AbstractWatchService.java:80)
	at sun.nio.fs.AbstractWatchService.poll(AbstractWatchService.java:97)
	at org.terasology.module.filesystem.ModuleWatchService.poll(ModuleWatchService.java:61)
	at org.terasology.assets.module.ModuleWatcher.checkForChanges(ModuleWatcher.java:132)
	at org.terasology.assets.module.ModuleAwareAssetTypeManager.reloadChangedOnDisk(ModuleAwareAssetTypeManager.java:164)
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:410)
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:358)
	at org.terasology.engine.Terasology.main(Terasology.java:158)
For more details, see the log files in /home/flo/programs/Terasology/logs/2015-07-18_23-15-55

I also get this one a lot.  In fact most every time I run headless. If I put a breakpoint and rerun the code after this error, it always works.
Will post my logs later today.  It kind of feels like its a file system asynchrony thing as I also get odd out of turn things happen when doing game saves.

It is some sort of race condition, I haven't been able to work out exactly where yet. In theory the engine must be holding an old reference to a closed module environment after it has been closed.

Oh, please also ensure your workspace is up to date and using the correct version of gestalt (4.0.3, probably could update terasology to use 4.1.0), older version may have some threading issues.
I haven't had this issue in a while, so I thought it was fixed.

In the stacktrace you can see that the bug occured with gestalt-module-4.0.3

I tried a headless + client connecting real quick using Gestalt 4.1.0, but crashed immediately on trying to join with the client :-(
Also, what's with the weird delta? We've gotten reports about that occasionally.
21:26:52.570 [main] INFO  o.terasology.engine.TerasologyEngine - Initialization completed in 9.39sec.
21:26:53.965 [main] WARN  o.t.engine.internal.TimeBase - Delta too great (34473803), capping to 1000
21:27:12.219 [Parallel Operation] INFO  o.t.n.internal.NetworkSystemImpl - Connected to server
21:27:12.465 [New I/O worker #3] INFO  o.t.n.i.ClientHandshakeHandler - Received Server Hello
21:27:12.471 [New I/O worker #3] INFO  o.t.n.i.ClientHandshakeHandler - No existing identity, requesting one
21:27:13.201 [New I/O worker #3] INFO  o.t.n.i.ClientHandshakeHandler - Received identity from server
21:27:13.291 [New I/O worker #3] INFO  o.t.n.i.ClientConnectionHandler - Received server info
21:27:13.326 [New I/O worker #3] INFO  o.t.n.i.ClientConnectionHandler - Join complete received
21:27:13.331 [main] INFO  o.t.e.modes.loadProcesses.JoinServer - Activating module: CoreSampleGameplay:0.54.0-SNAPSHOT
21:27:13.334 [main] INFO  o.t.e.modes.loadProcesses.JoinServer - Activating module: Core:0.54.0-SNAPSHOT
21:27:13.334 [main] INFO  o.t.e.modes.loadProcesses.JoinServer - Activating module: engine:0.54.0-SNAPSHOT
21:27:13.335 [main] WARN  org.reflections.Reflections - given scan urls are empty. set urls in the configuration
21:27:13.481 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception, attempting clean game shutdown
java.nio.file.ClosedWatchServiceException: null
	at sun.nio.fs.AbstractWatchService.checkOpen(AbstractWatchService.java:80) ~[na:1.8.0_45]
	at sun.nio.fs.AbstractWatchService.poll(AbstractWatchService.java:97) ~[na:1.8.0_45]
	at org.terasology.module.filesystem.ModuleWatchService.poll(ModuleWatchService.java:61) ~[gestalt-module-4.1.0.jar:4.1.0]
	at org.terasology.assets.module.ModuleWatcher.checkForChanges(ModuleWatcher.java:132) ~[gestalt-asset-core-4.1.0.jar:4.1.0]
	at org.terasology.assets.module.ModuleAwareAssetTypeManager.reloadChangedOnDisk(ModuleAwareAssetTypeManager.java:164) ~[gestalt-asset-core-4.1.0.jar:4.1.0]
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:410) ~[classes/:na]
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:358) ~[classes/:na]
	at org.terasology.engine.Terasology.main(Terasology.java:158) [classes/:na]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_45]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_45]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_45]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_45]
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140) [idea_rt.jar:na]
21:27:13.481 [main] INFO  o.terasology.engine.TerasologyEngine - Shutting down Terasology...

Oh, so it happens when a client joins? Ok, will see if I can reproduce.
Not sure exactly what is going on with the time, but something to do with how time is managed during loading I would guess. Probably doesn't affect much, may be losing a second of time at the start of the game.

Ok, should be fixed now. I stepped through the background thread that does the asset manger environment switch and could see where the crash was happening.

Awesome! Thanks :-)


Bug in request function when working with multipart/form-data

I found a bug with the request function when working with multipart/form-data. The second and following pairs of form variables require an extra space at the beginning!
Here is the problem: GitHub Issue #28
Thanks,
Ali

Thanks, Ali. Do you know why is the extra space needed for the 2nd and following form pairs? I suppose the change is needed here:
https://github.com/fortran-lang/http-client/blob/d65b4b1eb96ec9a4ddbb98252335aa37ad24ace0/src/http/http_client.f90#L250-L262
I wonder if this has to do with how curl_easy_escape works.

Thank you for your prompt response.
My test shows that the function prepare_form_encoded_str isn't being called. I think this function should be called within the client_get_response function.

Hello Ali, as you are utilizing both the file and form concurrently, this code is currently operational. I will proceed to test this code:
https://github.com/fortran-lang/http-client/blob/d65b4b1eb96ec9a4ddbb98252335aa37ad24ace0/src/http/http_client.f90#L440-L459

Thank you for your response.
This solution may not be ideal:
! if both file and form are passed
if(allocated(request%form)) then
    part_ptr = curl_mime_addpart(mime_ptr)
    status = curl_mime_data(part_ptr, request%form(1)%value, CURL_ZERO_TERMINATED)
    status = curl_mime_name(part_ptr, request%form(1)%name)
    if (size(request%form) > 1) then
        do i=2,size(request%form)
            part_ptr = curl_mime_addpart(mime_ptr)
            status = curl_mime_data(part_ptr, request%form(i)%value, CURL_ZERO_TERMINATED)
            status = curl_mime_name(part_ptr, " "//request%form(i)%name)
        end do
    end if
end if


Feature: Support pydantic v2

Related Issues

Fixes https://github.com/yanyongyu/githubkit/issues/38

Description

Migrate pydantic v1 to v2

Updated pyproject.toml, poetry.lock
Updated deprecated functions/methods into v2 functions/methods (codegen, githubkit)
Actually I wanted to make githubkit support both pydantic v1 and v2, but it was too complex  and required so many changes

Added SetSchema, because List with unique_items was deprecated, and recommended to use Set
Updated to use Annotated for pydantic models

I only checked Missing, but there is a need to check if the same applies to Union required.

I'm not sure that set is a good way to replace the unique list since the set type does not contain order information. But i find an other way to impl this in the pydantic issue https://github.com/pydantic/pydantic-core/pull/820#issuecomment-1670475909. If we don't need to keep the order information, the set type is recommended.

Thank you for the feedback. I applied your comment :D
GitHub's OpenAPI does not yet have a schema with uniqueItems=True, but if one exists in the future, it will be safer to keep the order.

Thanks foryour great help with this feature. I still need to investigate how to make it compatible with pydantic v1 and v2 after this pr is merged. The codegen part should be rewrited to support features including compatibility layer, lazy loading logic and api versioning. This may take a long time before release since i do not have too much free time.


German (de) translation update

Hello everyone,
I have just re-discovered this wonderful project and wanted to bring its German translation up to date. I have completed and removed the TODO notes and also replaced the straight single quotes (') with correct German typographical quotes („“).

Thanks for your work on this! I've accepted the changes and added you to the credits, so it should show up in the next release of Syncplay (and for those following GIT HEAD).


Define googletest API as a git submodule.

Define googletest as a submodule will prevent the appveyor installer from downloading the repository manually.

Submodule is a pain in the *** to work with. The scripts will be converted to be more verbose and allow execution on a windows machine to properly 'install' googletest repository.


Example for Commando.js Framework [discord.js]

I would be helpful if you tell me more about how to make it work in commando framework. I got the !hr play , I will just check if the user accepts or not in the play command file, but what is !pan ?

Ok, so I'll explain!

To start a game, you'd need to use the command !hr [user].
To accept the duel, the user should type !yes
Each turn, to shoot, the user needs to write !pan("pan" is the onomatopoeia of the noise of a gun shooting in French).

To use it with Commando.js, you might need to create an empty file with an empty class for both !yes and !pan command with only the constructor filled.
I am working on bringing an update to the game to improve the user experience. It will normally be added the first half of May ☺ !
If you have any questions or if something I wrote is not clear, do not hesitate to ask anything and I will try my best to answer !


Java6 support

Changes for Java 6.
Please have a look, I'm aware that Java 6 support is probably a bit backward, but I need it so I thought I'd make the commits (since it seems like Java 6 support is not too hard for the 2.0 release) and you might keep it as a branch?

Hi,
this PR does not only change the codebase to support Java 6, it also changes the Exception Handling and the way retrofit creates a client connection.
I dont plan to support Java 6 because this is EOL anyway, and i dont see why someone needs to stay with it especially in new projects.
PR in general should solve one single problem which was described in an issue. They also should not modify formatting of surrounding code.
So i will close this PR.


atomic PrewriteMaxBackoff

Signed-off-by: Weizhen Wang<EMAIL_ADDRESS>close #487

LGTM. Please also update the client-go in TiDB asap to resolve the API breakage.

OK, I will.


Add support for .pug templates

Added support for .pug files (Jade was renamed to Pug).
Added a corresponding test too.
Since Pug has breaking changes and still in beta, I kept both of them around.
P.S. Can I submit a PR rewriting this in ES6 ? Mostly for aesthetics but there might be code which can be written better with ES6.

Thanks for the pull request! Sorry for the way late look at this. Code looks great.
Re: ES6. I'm definitely open to a PR that uses the latest Node standard ES6 features, but I would prefer to keep anything that requires Babel/transpiling out to keep it simple.


replaced the print statements with logging (issue #59)

Did a find all for print statements in the code and replaced them with python's logging module instead and added a constants file to store the common logging format.
This is related to issue #59

@lymereJ My apologies for all the extra commits. I got turned around on what branch I was on and kept going back and forth.
I changed the format of the logging string and moved the basicconfig to the init. I also added a test for logging. I didn't see anything great (other than mocks or additional libraries) for testing the literal string being printed to the screen.

Thanks a lot for this effort, great addition to the code!


Website rely reorg

I created an advanced section for the Rely docs, added documentation for option matchers, updated the getting started guide to reflect the README, and updated the custom matchers example to be simpler/include usage of expected.
Feedback on what can be clarified/split out further would be appreciated!

Cool, land it. You want to mention the minimum version required for various features?


Symbols are not recreated if the type library info changes when opening an existing BNDB

This is part of the reason of https://github.com/Vector35/binaryninja-api/issues/4883. The issue brings up a case like this:

A file is analyzed, and a function has no matching type library entry
The analysis is saved to a BNDB
There is a newer version of BN, and it has a new type library that has the function in the type library
The user re-opens the BNDB with the newer version of BN

In the above case, the code here will try to register the symbol with the new type library: https://github.com/Vector35/view-pe/blob/6e4448fbe2ad88121db79ce36ac07c994d1184cd/peview.cpp#L1540-L1541. However, the code in PEView::AddPESymbol will reject the operation: https://github.com/Vector35/view-pe/blob/6e4448fbe2ad88121db79ce36ac07c994d1184cd/peview.cpp#L2704-L2709. Since the symbol already exists in the snapshot, causing the type library cache to use the old symbol without the new type library info.
I am not sure what is the motivation behind the action of not registering symbols that already exist, probably for a good reason. So I am unable to resolve it myself, probably need someone with more knowledge on this to look into it.

Weird enough, even if this is fixed, the original issue #4883 is still NOT fixed. The type library info from the snapshot overwrites the (correct) type library info provided by the binary view.

This is working as designed -- when types/objects are observed from a typelibrary they are duplicated fully into the BinaryView. Subsequent loads of a database will never replace data that may have since been marked up and due to how the BinaryView init and load paths work it is not possible to differentiate at present.


Unclear how to define  instant recovery resource group name

Type of issue
Missing information
Feedback
It is unclear how to define the instant recovery resource group name through CLI.
Page URL
https://learn.microsoft.com/en-us/cli/azure/backup/policy?view=azure-cli-latest
Content source URL
https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/backup/policy.yml
Author
@dbradish-microsoft
Document Id
8b695b10-a26d-caac-5206-38edeb1859c1

@V4A001
Thanks for your feedback! We will investigate and update as appropriate.

@V4A001, can you please provide more information about your reference to "instant recovery resource group name"? The link in your feedback takes me to az backup policy create which has a --resource-group parameter.

This GitHub issues is being closed as there have been no further conversation since November 7th. Please reopen a new issue in Azure/azure-cli if you feel there is an error in the product source code.


Driver: normalise linker triple on all android targets

Currently we only support building for android armv7, arm64, x86,
x86_64.  In the future, if support for MIPS and MIPS64 is added, we
should normalise those as well.  This is needed to support compilation
against modern NDKs.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@buttaface - oh wow, didn't know that.  Awesome!

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 6cf269d73a03c066ccef497c4327b0d064cb3bfa

Build failed
Swift Test Linux Platform
Git Sha - 6cf269d73a03c066ccef497c4327b0d064cb3bfa

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 90ec81ba274969ff25a0aa3307af87aa0681848c

@swift-ci please test


net/http: http2 client return EOF

I'm trying to connect to https://dav.box.com/ with golang. It seems that box.com provide http2 protocol. But go's http2 client retrun EOF always. I debugged little and I make sure this occur on h2 protocol in TLSNextProto. So currently I'm disabling h2 like below.
http.DefaultTransport.(*http.Transport).TLSNextProto = make(map[string]func(string, *tls.Conn) http.RoundTripper)

/cc @bradfitz

Can you show sample code to reproduce?
Or do you literally mean just:
     res, err := http.Get("https://dav.box.com/")

?

Indeed!

I found the problem. https://dav.box.com does not speak HTTP/2. But we advertise in our TLS connection that we speak "h2" but we never mention that we also speak "http/1.1", and Box's frontend recognizes ALPN or NPN enough to know that they can't handle "h2", so they hang up on us.
The fix is to declare that we also speak "http/1.1" as a fallback.
Easy fix.

thank you


[Bug] Deprecations

This should be updated or the action will stop working
node12
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: Azure/pipelines

set-output
The `set-output` command is deprecated
and will be disabled soon. Please upgrade to using Environment Files.
For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@tjcorr, @keifgwinn, @Josh-01 - is there any idea when this will be resolved as node 12 is deprecated?

It would be really helpful to get this resolved @tjcorr, @keifgwinn, @Josh-01.
The fix is merged, just needs a new patch tag if that's at-all possible.
it's been two years since the last release and Node 12 is deprecated now.


Extend py_run! to take locals dict and refactor tests using it

Currently, our tests have many lines like:
    let run = |code| py.run(code, None, Some(d)).unwrap();
    let err = |code| py.run(code, None, Some(d)).unwrap_err();
    run("...");

I felt this redundant.
So I prepared this PR.
py_run! now can take locals dict by py_run!(py, *locals, "some_python_code()") syntax.
This odd * is to distinguish dict with normal py_run usage with variables (e.g., py_run!(py, obj1 obj2, "code") and inspired by * syntax in Python. I believe this is not very confusing, but please propose alternatives if you have.

Support returning a value from py_run! (if it's possible? - maybe would need to be py_eval! macro for returning values)

We need to use py.eval for returning a value.

We need to use py.eval for returning a value.

👍. It would be awesome to have a py_eval! macro in that case, however I guess that's a separate PR.


Forward android toolchain path linker path to LLVMAOT backend

When building android cross compilation with cmake we can forward the linker path instead of setting up a standalone toolchain.

@asaadaldien here's a good bug to close as part of your ANDROID_NDK work.


Feature voronoi 2 d pr

Hi Dr. Najian,
I modified the Voronoi control class and added a corresponding example and a test script.
Kind regards,
Kianoosh

this PR is addressed in PR #16.