unable to resolve module<EMAIL_ADDRESS>

When importing ExNavigator with in app fails with below error message
This apps is built with React Native dependencies 0.19.0
This can be resolved by importing the React Native module using import instead require.
i.e., import React from 'react-native' instead  let React = require('react'); with in @exponent/react-native-navigator/node_modules/react-clone-referenced-element/cloneReferencedElement.js

same issue while trying out https://github.com/Thorbenandresen/ExNavigatorExample with react-native:0.19.0

Replace<EMAIL_ADDRESS>line 3 to
let React = require('react-native/node_modules/react');

Also having this issue

Also had this issue. It's related to https://github.com/ide/react-clone-referenced-element/issues/3.


JUnit testing Message flows

Hi Artem,
first of all I would like to thank you for the DSL and all the work you did.
I'm quite new to spring-integration and I had (and still havíng) a hard time in creating JUnit integration tests for message flows.
My flows are a little bit complex, several services are called, data is put into message headers, splitters and aggregators are used and so on.
I would like to test logical flow blocks instead of the complete flow. Having a complete flow I'm able to put a message into a specific message channel but I did not manage to stop the message flow programatically after the logical block was passed.
I ended up in splitting the complete message flow up into the logical blocks residing in separate configuration files which seems not to be optimal but testable.
Can you please provide some testing best practices in your DSL documentation?
Thank you in advance,
Christoph

I'll let @artembilan comment further, but programming in the DSL is like programming in any other language. You really don't want a long monolithic flow (method). Splitting a flow in to multiple smaller flows is generally a good idea - for readability aside from testability. They don't have to be in separate files, though, you can wire together multiple IntegrationFlow beans in the same configuration file.

Hi Gary,
thanks for your reply. I'm really looking forward to having some best practice code examples in your documentation.
Regards
Christoph

Hello @flexguse !
Thank you for the feedback, but there is really no a comprehensive answer to your request.
I have been not one time in front of the something like MockIntegration framework, similar to MockMvc or @WithMockUser from Spring Security, but it is really isn't simple task for such a high-level solutions like integration flows.
I most cases our flows are based on the interaction with external systems, like get files from the FTP and send them to the AMQP, or process user requests through the @MessagingGateway and store data to DB with some RetryAdvice and return response with some other data  correlated in the aggregator for this user from from TCP adapter stream, etc.
But anyway we always have there MessageChannels to send/receive/handle messages in some part of the flow. So, I guess we really can provide some hooks from our unit tests to do some work.
Take a look please, to some last feature - IntegrationFlowAdapter with which you really can divide you complex flow to the discrete pieces and test input/output of the IntegrationFlow from that IntegrationFlowAdapter implementation.
Yes, we really may introduce something like:
@Autowired
private IntegrationFlow myFlow;
.....
MockIntegrationFlow mock = mockIntegrationFlow(this.myFlow);
mock.send(...);
mock.sendAndReceive(...);
mock.reeceive(...);
mock.verify(...);

etc.
Need to think more, of course...
Will be glad to see any mindstorm on the matter!
Cheers!

@flexguse I used 2 approaches for the flow testing

test subflows on the real data. Pros: it's simple Cons: you force to prepare real data which in case of messages with 20+ fields may be not simple. Without real data in the messages, unfortunately, you can't test subflows at all cause of NPEs and other exceptions inside transformers etc.

mock transformers, filters etc. via injecting them into Spring context (I used Mockito framework for this). Pros: you can concentrate really on subflow testing with minimal real data in messages and headers. Cons: you need to create mocks manually.

So I can't see the silver bullet in integration flow testing :(

We can borrow some ideas from Spring Boot 1.4: https://spring.io/blog/2016/04/15/testing-improvements-in-spring-boot-1-4.
In general I mean @MockBean and @SpyBean.

One more use-case.

Should be useful: https://spring.io/blog/2016/08/30/custom-test-slice-with-spring-boot-1-4

Hello,
I am also new to Spring Integration, and trying to wrap my head around what the best strategy would be in order to write tests for IntegrationFlow objects.
Although the documentation is top-notch (like all Spring projects), I didn't see much in there regarding testing.
It would be great if there where some general guidelines in order for Integration newbies such as myself to be able to get a bearing of what is possible and how to accomplish it.
Thanks!

@geoand
You should start with the testing-samples and advanced-testing-samples sample projects.
Another good source for inspiration are the test cases in the framework itself.
We usually prefer Stack Overflow (spring-integration tag) for questions like this because it has a wider audience and people generally search for answers there first.
If you have a specific use case you need help with, let us know via a question there (and add a link here).
Thanks

@garyrussell Thanks for the help! I am starting to get the hang of it :).
I'll post to SO if needed.
Thanks again!

FYI: https://github.com/spring-projects/spring-integration/pull/2053

Thanks!
Will check it out


#29: Added a precommit and prepush git hook

Thanks, Will test this out. I have avoided adding things like this in the path because they don't always give good feedback in the ui

Thanks, Will test this out. I have avoided adding things like this in the path because they don't always give good feedback in the ui

I agree. I think we need this, if not, then we should at least update snapshots before running tests. That was pretty the primary reason I thought we need a hook to take care of these things before pushing code.


innertube php version

Hi !
Thank you so much for you work !
can you port this one into php
https://github.com/tombulled/innertube

I don't have time right now to port it. Looks like a project you or someone else could take on!


Support different package managers (npm/pnpm/cnpm)

Dear @beeman ,
thank you very much for this awesome (!) boiler plate code for webbased applications. I really like it - been following you for some time and just stumbled upon these generators.
Expected Behavior
I noticed, that the commands within the executors require yarn. Same with the inserted scripts in the package.json file.
Can we make yarn optional? i.e., if i would like to use npm, scripts need to be rewritten (i.e., npm run x instead of yarn x)
Thank you very much for your time & help

Hi @johannesschobel, thanks for kind words, and for taking the time to check out @nxpm/stack.
I'd love to give you a little context about the status of the project and it's future.
The state of this project is currently more or less proof of concept (which I think totally validated itself!). With this in mind, I took quite a few shortcuts to make that happen, picking yarn as the package manager of choice is one of them.
I'll be rebuilding @nxpm/stack using Nx 11 and in that new structure it should be much easier to add new features and options. However, for moving to Nx 11 I'm currently blocked on this issue, once that's fixed I can start migrating my stack.
Now with regards to this specific question: I'm definitely open to support other package managers, and if this change is added I want to make sure to not only support npm, but also make sure pnpm and cnpm work.
I'm happy to help you land a PR that adds this, but it might be smart to wait a little bit until it's running on Nx 11. Because whatever gets added to @nxpm/stack now, also needs to be migrated.
I hope this answers your question.

Hi @johannesschobel, thanks for kind words, and for taking the time to check out @nxpm/stack.
I'd love to give you a little context about the status of the project and it's future.
The state of this project is currently more or less proof of concept (which I think totally validated itself!). With this in mind, I took quite a few shortcuts to make that happen, picking yarn as the package manager of choice is one of them.
I'll be rebuilding @nxpm/stack using Nx 11 and in that new structure it should be much easier to add new features and options. However, for moving to Nx 11 I'm currently blocked on this issue, once that's fixed I can start migrating my stack.
Now with regards to this specific question: I'm definitely open to support other package managers, and if this change is added I want to make sure to not only support npm, but also make sure pnpm and cnpm work.
I'm happy to help you land a PR that adds this, but it might be smart to wait a little bit until it's running on Nx 11. Because whatever gets added to @nxpm/stack now, also needs to be migrated.
I hope this answers your question.

Dear @beeman ,
thank you very much for your very fast answer on this issue.
Good to hear, that you are planning to support other package manager as well. Maybe you could use the default package manager that is specified in the workspace.json (i believe!). Nrwl already has such a configuration flag - maybe there is an API for that as well?
Regarding the migration process:
Do you have an estimated timeframe for the migration? I know, that you are currently blocked by a nrwl issue, however, as far as i have seen, this only affects tests, right?
All the best and thanks for your time / effort on this

Dear @beeman ,
thank you very much for your very fast answer on this issue.
Good to hear, that you are planning to support other package manager as well. Maybe you could use the default package manager that is specified in the workspace.json (i believe!). Nrwl already has such a configuration flag - maybe there is an API for that as well?
Regarding the migration process:
Do you have an estimated timeframe for the migration? I know, that you are currently blocked by a nrwl issue, however, as far as i have seen, this only affects tests, right?
All the best and thanks for your time / effort on this


Force initial loading when not at distance

I have a page such as the distance from the bottom is too high by default to trigger the infinite scrolling. Is there a way to force initial loading of elements independent from the distance?
Imagine the following layout where column 2 can be very tall and column 1 has the scrolling list:
*****************************************************
*                column 1                * column 2 *
*****************************************************
*                                        *    xxx   *
*                                        *    xxx   *
*                                        *    xxx   *
*                                        *    xxx   *
*                                        *    xxx   *
*                                        *    xxx   *
*                                        *    xxx   *
*                                        *    xxx   *
*                                        *    xxx   *
*                                        *    xxx   *
*****************************************************

The only way I see to load the list is to go to the bottom of the page (the scroll parent). It will then fill the page if it is very tall, no problem. The issue is the first (initial) loading.
The solution would be the option to fill the page on load without relying on the distance parameter. Something akin to "Always fill the page on load, whatever the distance".
Another (better?) solution would be to rely on the viewport. If the viewport is empty, fill it. Not sure this is possible though.
Am I missing something obvious here to trigger onInfinite() on page load? Firing onInfinite() on Vue instantiation mounted event won't work well as the spinner won't show and in some cases (short page) onInfinite() will be called twice.

Is this the same issue #21 ?

Kind of, it's what I meant in my comment of that issue.
The issue you are referring to dealt with filling up a full page (load until page is full).
But what is missing is the ability to auto fire the first load even if the distance from bottom has not been reached. I think that it has not been implemented in issue #21. Or did I miss a property?

Mine does automatically fill-up on page load, despite not even being anywhere close to the spinner.. Already tried purging node_modules and reinstalling the whole shebang, but sadly.. Nothing. Although it could be that it's not meant to work with tables.

I guess you need a spinner as the loading animation, is that right?
If so you're right, this component does not has this feature. But I cannot imagine the application scenario you said, is it out of the category of infinite scroll?

Non that's not what I need. I need a function or a way to manually start loading the first batch of items. Currently the first batch of items is triggered in the same way as when we scroll: distance from bottom is less than a given value. In a desktop application, there may be situations where that condition cannot be met on page load.
Take your hacker news example: Translate it to a desktop app. Add an aside column that has a 5000px height. Now your items won't load in your main column unless you scroll to the bottom of the page to trigger it.
Other example: imagine you do not want to load your items unless you ask for it. How would you 1/ prevent loading on page load and 2/ trigger loading with a "load results" button?
I'm going to try and take some time to code an example so you understand my issue.

I have already understood, thanks a lot!
There has two columns in the page, and you want to load more data for the left page, but due to the right page is too high lead to the distance lager than the edge value, but the component cannot resolve it, I wrote a demo on JSFiddle, is that your meaning?

Yes that's it.
I tried to add:
        mounted: function() {
            this.onInfinite();
        },

But there are two issues. First, when called this way, the function does not trigger the loading animation. Second, if my right column is empty (not 5000px), the function gets called twice, once on mounted, once by default.
Plus it doesn't answer the case where I need to manage loading items manually.
What I think could make sense is the following:

a property autoLoadFirst=true
// is loading the first batch of results automatic or triggered via a "load" button
// this loading mechanism MUST NOT be based on the distance parameter
a property autoLoadMore=true
// is loading more results automatic or triggered via a "load more" button
a property autoFillPage=true
// load more results automatically until the page height is full

What do you think?

Okay, I need time to think about it.

Sure do not hesitate to share your reflexions!

Hi @JeanLucEsser, sorry to late, I have been improved the way to calculate distance and released v1.3.2(Vue.js1) and v2.0.3(Vue.js2) to fix this issue, you can try it now. Please tell me if it still has problem :P

@JeanLucEsser is your problem solved?

@PeachScript yes after a few tests, the problem appears to be fixed, thank you very much. I still think some options to manually trigger loading should be nice but the main issue is now fixed so that's a good thing. ;)

That's good, thanks for your idea, and I also believe my own ideas like you. :P
Best regards.


Convert Points to Numpy Array

Required Info

Camera Model
D400

Firmware Version
2.39

Operating System & Version
Linux, Arch

Kernel Version (Linux Only)

Platform
PC

SDK Version
2.39

Language
python

Segment
Robot

Issue Description
Hi, I am am trying to convert a realsense pointcloud to a numpy array:
 **frame_points = rs_ptcloud.calculate(frame_depth)

    # Convert the frame of points to a point cloud stored in a numpy array
    points = np.asanyarray(frame_points.get_vertices())
    print(frame_points.get_data_size(), frame_depth.get_data_size())
    print(points, points.shape)

With get_vertices(), the numpy array contains data. When I substitute get_data(), however, the array is empty. Thanks in advance!

I could be wrong, but it seems that the get_data() method traces back to this definition for get_frame_data(). This function appears to return a void BufData type if the frame is not a video frame (<frame>.is_video_frame == False):
if (auto vf = self.as<rs2::video_frame>()) {

...

}
else
    return BufData(const_cast<void*>(self.get_data()), 1, std::string("@B"), 0); };

A point frame is not a video frame, so this could be the reason that the buffer contains no data when .get_data() is called on a point frame.
It could also be an issue with my usage of np.asanyarray(), but this doesn't seem likely since this method of converting pyrealsense2 frames into numpy arrays works for color and depth frames.

Hi @collinbrake   Others have explored the subject of converting frame data to Python numpy array and vice versa, and it is an ongoing area of study for RealSense users.  The link below may provide you with some research leads.
https://support.intelrealsense.com/hc/en-us/community/posts/360047819294/comments/360011874874

@MartyG-RealSense Thanks for the links! I will keep digging. It looks like both of these issues are related to saving point clouds as .ply files and then reading them back in and trying to convert from a numpy array to a realsense frame. I am trying to do just the opposite, but without saving the point cloud to a '.ply' file first.

@collinbrake Open3D has a pretty efficient way of converting depth maps into point clouds:
http://www.open3d.org/docs/release/tutorial/Basic/rgbd_image.html
and then getting numpy arrays from that pointcloud.
http://www.open3d.org/docs/release/tutorial/Basic/working_with_numpy.html#From-open3d.PointCloud-to-NumPy

Hi @collinbrake   Do you require further assistance with this case, please?   Thanks!

@MartyG-RealSense Thanks for asking - the get_vertices() function actually does exactly what I need. I should have experimented with it more in the first place - I was just expecting the 'get_data()` method to work like it does for other frames, and went down a rabbit trail.

@sam598 Thanks for your suggestions on this!

Great news @collinbrake  - thanks very much for the update!
Yes, thanks too @sam598 for your assistance    :)


Feat/triple aim

Adding a custom block for Triple Aim.  I'm not sure if a custom block is the way to go, and if it's not, I'm not sure that overloading a lists component is the way to go either as this block has a column and list component, but shouldn't really be blocked with both.  I am open to feedback to say the least.  I should also rename the gdoc after getting feedback on this PR to something more appropriate.
I have 2 branches to choose from.  This branch does not have the red bars on the left as we discussed in Slack.  Adding them was super easy to do, so I made another branch with the small change in case we changed our minds due to the minimal effort.  See screenshots below for both.
I did notice that there is a breakpoint at 740px instead of the usual 900px.  As we have used the 740px breakpoint in other blocks, if we should use this breakpoint instead of the 900px breakpoint, I'm open to that change also.  It makes a lot of sense with the hero blocks, and we could probably get away without honoring the 740px in other places, but I don't have a strong opinion either way.
Usage of 740 breakpoint, it is isolated

default-hero
product-hero
card-hero

Live site: https://ihsvirtualexperience.com/population-health/
Fix #12
Test URLs:

Before: https://main--takeda-ihs--hlxsites.hlx.page/drafts/triple-aim-exploration
After: https://feat-triple-aim--takeda-ihs--hlxsites.hlx.page/drafts/triple-aim-exploration
After: https://feat-triple-aim-bars--takeda-ihs--hlxsites.hlx.page/drafts/triple-aim-exploration

No Bars
300px

600px

900px

1200px

Bars
300px

600px

900px

1200px

Closing, for PR #58


Retries to work around flaky builds

Sometimes when building on Windows in Github Actions, the build fails due to a problem with the Github Windows runner rather than a problem with the code.  Attempting retries, because sometimes that helps.

See for example: https://github.com/input-output-hk/iohk-monitoring-framework/pull/611/checks?check_run_id=1485350036

bors merge

bors merge


LICENSE is missing

Could you please add a LICENSE file to the root of repo?

Fixed. Thank you for reminding me!


add filename under video player

Like this:

Go to frontend/src/components/gallery/VideoPlayer.tsx and add this:
<p className="text-white text-center">
    {file.name}
</p>

under video player


Release azure-cli-storage 2.0.8

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Started releasing azure-cli-storage 2.0.8...

Release of 'azure-cli-storage' with version '2.0.8' successful. View at https://pypi.python.org/pypi/azure-cli-storage/2.0.8.

GitHub release created. https://github.com/Azure/azure-cli/releases.

Codecov Report

Merging #3702 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3702   +/-   ##
=======================================
  Coverage   72.23%   72.23%
=======================================
  Files         422      422
  Lines       26357    26357
  Branches     3991     3991
=======================================
  Hits        19040    19040
  Misses       6089     6089
  Partials     1228     1228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4233fbc...14dcc7e. Read the comment docs.


Fix/nx workspace angular

Hello,
I tried to run the command ng add @angular-architects/module-federation against nx angular workspace and after the prompts for the project name and port, the command failed with options of undefined. After some debugging I found that in the generateRemoteConfig function when projects are iterated in the array are also the e2e project. They don't have the serve property in the architect and so the build fails. I have added a check for there properties. Also fix the e2e test, it was missing the main.ts and add e2e test for angular.json from nx workspace. Hope this pr helps.

After further investigation if  i run add @angular-architects/module-federation with nx instead of ng everything is generated correctly. So i guess i my bad :). Closing the PR cause I think is not anymore relevant.


Allows Hotkey Picker to not necessarily need a "Combo Key"

Summary of the Pull Request
This PR allows Hotkey Picker to not necessarily have a combo key and removes this requisite from the PowerToys Run. (Closes #4203)
The user must still choose one of the keys present on the Keys attribute, so, for example, the Color Picker PowerToy Hotkey Chooser will not be affected by these changes.
This PR also removes the tooltip informing the user of the required keys when they are not present.
PR Checklist

[x] Applies to #xxx
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
The option for people creating new toys that have the Hotkey Component to not force users to have at least one "Combo Key" present, and removes the "Combo Key" obligation from the PowerToys Run. So a user can now use, for example, just the Caps Lock key to activate the Launcher.
Validation Steps Performed
1 - Verify that there were no changes on the Color Picker Hotkey component.
2 - Verify that the tooltip on the PowerToys Run does not exist and does not pop-up after mousing over.
3 - Verify that after choosing a key (for example Caps Lock) and focusing out, the key chosen persists.
4 - Verify that after pressing the chosen key, the Launcher opens.

O

O

@thiagopromano is this in a state you want me to test / rereview?

I think this will have issues when setting them the hotkey as a single modifier key (such as Win/Alt/Ctrl/Shift). Since this PR doesn't change any of the actual hotkey logic, when using one of these modifiers as a hotkey, they will get invoked on key press rather than key release, resulting in all shortcuts with that key getting orphaned. For example setting it to Win, will not only prevent access to Start Menu, but all win key shortcuts such as Win+A, Win+V, etc will get orphaned. The correct way would be to detect if the key is pressed and released (like Start Menu behaves, it appears only when Win key is released).

@thiagopromano is this in a state you want me to test / rereview?

Yes, it is in a state that could be rereviewed/tested.

I think this will have issues when setting them the hotkey as a single modifier key (such as Win/Alt/Ctrl/Shift). Since this PR doesn't change any of the actual hotkey logic, when using one of these modifiers as a hotkey, they will get invoked on key press rather than key release, resulting in all shortcuts with that key getting orphaned. For example setting it to Win, will not only prevent access to Start Menu, but all win key shortcuts such as Win+A, Win+V, etc will get orphaned. The correct way would be to detect if the key is pressed and released (like Start Menu behaves, it appears only when Win key is released).

Yes @arjunbalgovind, this PR does not change the logic of the Combo Keys, but nor does it allow a Hotkey that consists only of a Combo Key (For example, it does allow setting only Scroll Lock as a hotkey, but not only Win or only Ctrl.
I pretend to make another PR that allows a single Combo Key to be assigned as a hotkey after this one gets merged. I have seen a lot of people asking to be able to override the Win key to launch PowerToys Run instead of the common Start Menu.
Then I will need to implement that logic that you said. 😉

What is the current status here? Do we intend to merge it or not?
We might hit a lot of issues later if we allow only one key to activate some module - for example enabling users to set "Win" key only to activate launcher is not really doable (might be a case for other keys) - this will cause a lot of issues to be opened. If we want to enable something like that, we should do it from the other side - ensure that one key activation will work for any module and then enable to set it in settings (before that you can manually change settings.json to test it)

What is the current status here? Do we intend to merge it or not?
We might hit a lot of issues later if we allow only one key to activate some module - for example enabling users to set "Win" key only to activate launcher is not really doable (might be a case for other keys) - this will cause a lot of issues to be opened. If we want to enable something like that, we should do it from the other side - ensure that one key activation will work for any module and then enable to set it in settings (before that you can manually change settings.json to test it)

@martinchrzan, as I said above, this PR does only enable setting keys that are not "Combo Keys" (Alt, Ctrl, Shift, Win) as single key activators. And this PR is only enabling this function on the PowerToys Run module.
I have been using PowerToys built from this branch since I opened the PR and with the hotkey as Caps Lock and had no problems whatsoever.
I am more than glad to rebase the PR on master and retest the build. Just give me the word.

We fear this PR will cause some quirks based on what @arjunbalgovind stated above.  Also this needs to be refactored to address the work done for #6060.


Trying to force content mode LTR to RTL

I'm trying to make the app support more than one language and regarding this, I want to make my app support (Rtl) specific languages

Work in progress.


Support all cosign signing integrations

Cosign supports a number of cryptographic signers that witness currently does not. Some examples include Azure Key Vault, PKCS#11, and some hardware tokens. Instead of trying to keep in sync with every signer that cosign supports, is it possible to give the option for witness to make a command line call to cosign for signing with the parameters specified in a configuration file? This way users could configure the cosign call as they desire without witness having to explicitly support each parameter. If this is not possible (or desirable), can support for PKCS#11 be added since it is a generic cryptographic interface (albeit a not-so-modern one)?

I think we would accept PRs for any of these Key Providers, however we are unlikely to shell out to cosign to support additional providers.  The community has been working to a unified signer library that multiple projects could use, including cosign and witness.  Is there a specific use case you have?  I'd like to hear more about your need for PKCS#11.

Hey @garantir-km, coming here to echo much of what @colek42 said. For the purpose of compatibility/UX/security, we are unlikely to add support for shelling out to other tools as you describe.

Instead of trying to keep in sync with every signer that cosign supports
Given that signing attestations is a key part of our projects functionality, we do indeed aspire to provide all the signing mechanisms that cosign does, which is why as @colek42 specified we are trying to work in the community to create a shared Go library (cosign is also written in Go) for signing logic so that we can all share a well implemented and fully featured signer / verifier interface.

Thanks for opening the issue 😊

Thank you @colek42 and @ChaosInTheCRD for the quick responses and @shenke-adsk for the support on PKCS#11. I understand that shelling out to cosign is kind of a hacked approach so I see why you would want to avoid it.
What we want to accomplish is similar to what @shenke-adsk described - we want to support generic cryptographic backends without needing custom code. Lots of cryptographic tokens and services (e.g., cloud ones like AWS CloudHSM, Azure Managed and Dedicated HSM, IBM HPCS, etc. and on-premise ones like Luna, nShield, Utimaco, Futurex, etc.) have their own PKCS#11 libraries so being able to use these directly would be great. While a unified signing library sounds interesting, I imagine we would still need to custom code the last mile to plug it to a cryptographic backend, right? Since cosign already supports PKCS#11 would it be a relatively small effort to plug that into witness?

Would it be an idea to rename the issue and focus on PKCS#11 support as a feature request?

@matglas Yes, that certainly works for us as all we need is PKCS#11 to have generic support.

We have initial pkcs#11 support in our enterprise version of Witness, but it requires CGO.  I think we want to keep upstream pure go right now.  We would probably accept a PR that supported PKCS#11 that did not rely on CGO.


Update notifier for critical security/bug fixes

Hello, right now there isn't any kind of update checking functionality in codeigniter.
There could at least be a notifier for critical security/bug fixes, e.g mysql injection,xss,csrf,etc...
Right now you're supposed to wait until the next build of codeigniter comes out, and as a result a lot of apps using ci can be hacked within the timespan it takes to the next build...
Also, you'd have to regularly check the ci website for a new build, and some people don't do that so a notifier would be useful.
Also @narfbg could you address the issue #4876 that you closed without explanation?
Thanks

@JoonasC Check this. You should post helpful information about an issue, such as steps to reproduce, what happened/what did you expect to happen, error messages etc. Sharing a Stackoverflow entry won't help detecting and fixing the issue. Do it on your own. :)
Also, this one, #4880, is not addressing any issue...

@gxgpet yes, this is an improvement request. #4876 is an issue i ran into.

@JoonasC #4876 is a link to a Stackoverflow post, not an issue report. :P

Sorry, but we can't make announcements for anything but new releases (or what you call "builds").


Nuget Package Update ?

Hello.
I would like to test your project.
I realized that in December 2020 a commit was made, however the nuget is still with a September 2020 version.
Do you have plans to update the package?

Hey Victor, if you check the commits the just recent updates just roll back some changes so get back to the September state. I just didn't want to lose the history so the commits remain.
Let me know if you have any questions or comments, I myself haven't found the time to even consume it for my side project so it is definitely in alpha state.


it's its not it's

Codecov Report

Merging #474 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   46.89%   46.89%
=======================================
  Files          70       70
  Lines        1898     1898
  Branches      306      306
=======================================
  Hits          890      890
  Misses        930      930
  Partials       78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5814e...c378544. Read the comment docs.

Thanks! I’m always screwing that one up!


[Bug Report/Build Failure/Feature Request] Upgrade to newer crystal version

Describe the bug
A clear and concise description of what the bug is.
The app doesn't compile on newer crystal versions.
It might even make it hard to maintain the app in the future if stuck on crystal 1.0.0.
Additional context
I can't integrate mango into nixpkgs because crystal 1.0.0 is not available as a compile toolchain.
If there is a specific question that needs to be answered, you can ask me.

This looks dead hasn't had a commit since Apr 2022 according to Github insights.

I have upgraded the project to use latest crystal. Once the maintainer of this project is back, a PR can be raised to merge the changes here: https://github.com/vrsandeep/Mango/releases/tag/v0.29.0


Context Class Loader should be used to locate and load mp-meta-config.yaml

Environment Details

Helidon Version: 3.x
Helidon SE or Helidon MP : Helidon MP
JDK version: 17
OS: mac
Docker version (if applicable): NA

Problem Description
In an MP application, I am trying to use the mp-meta-config.yaml file. It looks like the Helidon code uses the Application Class Loader to locate the mp-meta-config.yaml file. but, when the config file is changed to meta-config.yaml, Helidon uses the Thread Context Class Loader to locate the meta-config.yaml file..
Expectation is that the Context Class Loader should be used to locate and load mp-meta-config.yaml as well as meta-config.yaml

Hi,
Is there a release number where this fix is targetted  to be delivered to ?

Thanks


PUT call for creation / updation of availability set is not  synonymous

PUT call :
https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/availabilitySets/{availabilitySetName}?api-version=2019-07-01
Accepts payload while creating Availability set with proximity placement groups.
{   "location": "westus",   "properties": {     "platformFaultDomainCount": 2,     "platformUpdateDomainCount": 20,     "proximityPlacementGroup": {          "id":"< ppgResourceID >"       }   } }
To remove availability set from PPG, following payload is accepted. But AVA set without PPG cannot be created with this same payload.
{   "location": "westus",   "properties": {     "platformFaultDomainCount": 2,     "platformUpdateDomainCount": 20,     "proximityPlacementGroup": {          "id":""       }   } }
Accepts payload while creating Availability set without proximity placement groups.
{   "location": "westus",   "properties": {     "platformFaultDomainCount": 2,     "platformUpdateDomainCount": 20,     "proximityPlacementGroup": null   } }
To remove availability set from PPG, following payload does not work. Deployment does not fail, but there is not affect on the PPG.
{   "location": "westus",   "properties": {     "platformFaultDomainCount": 2,     "platformUpdateDomainCount": 20,     "proximityPlacementGroup": null   } }
The properties accepted should be synonymous while create and edit. The same behaviour is observed with Azure ARM templates as well.

@avirishuv, could you please look into the AvailabilitySet APIs to resolve this issue?

#assign: @mimckitt

@OmkarHirve thank you for bringing this up. The behavior outlined is exactly how the API calls are expected to work.
For updating the availability sets using PUT call, a "null" value of a property (in this case PPG) means that there is no change to be made to that property.
We are updating the API documentation and adding these details to clarify the expected behavior.
cc @mimckitt

I currently have a PR in progress for a new document explaining this behavior. Hoping to have it complete and published in the next week or so. Once it is live, we can link from the reference pages to that document to avoid further confusion.

quick update: the document is still in PR, tagging @mimckitt who is working on it.

Thanks @avirishuv. Been working on this with our engineering teams to ensure technical accuracy. I pushed a new version today and am waiting to hear back from a few people that are out until mid next week. Hoping to have this buttoned up and live in the next weeks. Apologies for the delay.

The new document will be live tomorrow by end of day.

Doc is now live: https://docs.microsoft.com/en-us/azure/virtual-machines/put-calls-create-or-update

Thanks @mimckitt . Given doc is updated, closing the issue now, but @OmkarHirve please feel free to reopen if you have any other question on this topic.


feat: Split evaluation and linting

Description
Architectural Diagram
Improvements
Case study: Loading of App stated here .
View Mode Timings

Edit Mode Timings

Fixes #16259
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Jest & Manual
Issues found:
https://github.com/appsmithorg/appsmith/pull/17287#issuecomment-1280230429
https://github.com/appsmithorg/appsmith/pull/17287#issuecomment-1283474865
https://github.com/appsmithorg/appsmith/pull/17287#issuecomment-1284909002
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=871cf7a

Can we move test files to tests subfolder of evaluations and linting ?

Done

/ok-to-test sha=620aebe

/ok-to-test sha=df2cc46

/ok-to-test sha=e8a49db

/ok-to-test sha=7aa0714

/ok-to-test sha=a35a7a5

Issues seen on this DP and not on release:

app save state takes goes into an infinite saving state and all edits made on the canvas is lost, editor changes are saved though
When such an error state widget is loaded on page load then related errors are not displayed on the debugger and all widgets on the canvas fail to load
New function created on the editor is not parsed so it does not appear on the dropdown and the run button does not show up on the editor gutter. Refresh the page and the function gets parsed and appears on settings

https://www.loom.com/share/22bfd27aa2b140d09a14cef9ca54e973
Sample app - https://appsmith-git-feat-split-evaluation-and-linting-get-appsmith.vercel.app/applications/6253f53e20a66f0a70f8[…]ges/633fb536bab79849bfde6f25/edit

/ok-to-test sha=9fe5329

/ok-to-test sha=08b1eed

/ok-to-test sha=7c2ca73

/ok-to-test sha=abee45e

/ok-to-test sha=8876b5b

/ok-to-test sha=ac68629

/ok-to-test sha=b4445ce

[ ] generate a CRUD page and create an error on any number of widget's property fields like visible, animate loading etc such that these properties are loaded when page loads and refresh the page a couple of times - observe an error appear on page load
Sample app

Continuing to drop issues found on the DP here:

[ ] Store value does not show up in widget binding
Sample app: Text1 on this app
CC: @ohansFavour

/ok-to-test sha=7f672e9

/ok-to-test sha=5a065e8

/ok-to-test sha=aa45fe2

/ok-to-test sha=beb6888

/ok-to-test sha=0baca05

/ok-to-test sha=51ea064

/ok-to-test sha=6875ecd

/ok-to-test sha=31b90aa

/ok-to-test sha=5bf3ccb

/ok-to-test sha=80af7ae

/ok-to-test sha=2f9a172

/ok-to-test sha=2b0855b

/ok-to-test sha=8e7fb09

/ok-to-test sha=5ea0bd4

/perf-test

/perf-test

/perf-test

/perf-test

/perf-test

/perf-test

/perf-test

/perf-test

/ok-to-test sha=400eea1

/perf-test

/perf-test

/perf-test

/perf-test


Gradient Tests with Rates

Summary:
So far gradient tests have focused on three arguments: pMatrix, biovar, and tlag, and have tested the so-called vdd, dvd, and ddv regime. This needs to be expanded to test combinations of regimes.
Furthermore, we want to test event arguments, which might be pass as parameters, in particular amt and rate. These seem to be causing errors.
Description:
The unit tests handle the case where amt and rate are modified well. I implemented a test for rates, and got errors. In generalOdeModel, all the gradients w.r.t rates went to 0.
In the case of PKModelOneCpt, the gradients were properly evaluated -- and at times non-zero--, except at one event.
Reproducible Steps:
See unit tests on branch issue-51-SS-rate.
Current Output:
Gradients are NOT properly evaluated at all events.
Expected Output:
Autodiff agrees with finite diff, at least in the case where rate != 0 (else, we run into a deeper problem which involves conditional statements, and which certainly needs to be fixed at some point).
Current Version:
Torsten v0.83
Stan v2.16

I've dug further into the gradient test for PKModelOneCpt. The error occurs at events that coincide with the end of an infusion time. I believe finite diff is at fault here.
This has to do with the MakeRates() function in the RateHistory class. Recall the RateHistory object contains one Rate object for each unique time of the event schedule. Consider a dosing event, which corresponds to an infusion with rate R, ending after delta units of time. At the end of an infusion time, either a new Rate is created or the Rate occurring at the end of that infusion time gets updated. All rates in RateHistory get updated, by adding R to the right compartment at times t0 < t < t0 + delta. The rate at the end of the infusion time stays at 0.
If no event coincides with the end of the infusion time, no problem.
If such an event already exists, then, with autodiff, the rate t0 + delta is 0. With finite diff, we have for the lower bound rate:
R' = R - d
=> delta' = amt / (R - d)
=> delta' > delta
=> the rate at the end of the infusion time is augmented with R, instead of staying at 0. Hence the difference.

Done in 0.87.


Location key not available when uploading a drawing package

While following the tutorial to upload a drawing package for Azure Map, step 5 was not working - there was no Location key under "header" after posting the HTTP. Please note that the Location key was working after posting on March 30 that I tried, but for some reason it was not there when I tried today.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa6d4f33-0311-2315-edef-b81c06fb3e0d
Version Independent ID: f7cc6c67-470f-e3f2-1a5c-d71487a85034
Content: Tutorial: Use Microsoft Azure Maps Creator (Preview) to create indoor maps
Content Source: articles/azure-maps/tutorial-creator-indoor-maps.md
Service: azure-maps
GitHub Login: @anastasia-ms
Microsoft Alias: v-stharr

@Karenzhang7717 Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Hi, I checked the header but the Location key is still not accessible

Hi, sorry that I messed up the correct tab for viewing the results - the issue is now solved.


Incorrect render result. Maybe because of FaceVarying normals?

I'm not entirely sure if this should be an issue. I'm getting a warning...
WARNING : MeshAlgo : Variable "N" has unsupported interpolation type - not generating normals.
when rendering with cycles. Unfortunately, the render result is also incorrect.
I've seen in other threads that this is because cycles doesn't support FaceVarying Normals. I've also seen a mention of using a MeshType node to get the correct results. I have been unable to find a combination of options in that node to get correct sharp normals.
I've included a simplified gaffer file along with some cache files (just a cube) from blender, maya and gaffer (in case it had to do with where the alembic came from). The gaffer file has a cycles set up and an appleseed set up for comparison. I've also included a cycles render from blender to show what the expected render would look like.
Is this a bug? If not, is there a way to get the cycles result in gaffer to look like the result from blender?
Thank you so much for working on GafferCycles!
example of the issue from gaffer cycles...

example of expected result from blender cycles...

gaffer appleseed render for comparison...

example gaffer scene and supporting alembic caches...
example_files.zip

Hi @evantryan
Yep Cycles doesn't support FaceVarying out of the box and Blender/Cycles is really tagging at a per-face level whether or not to 'smooth' it which doesn't convert very well to how Cortex/Gaffer conveys the data. It's a fairly non-trivial thing to solve other than patching Cycles itself to support 'Corner' normals ('FaceVarying' is 'Corner' in Cycles-speak) or splitting the vertices so that they can have unique normals, but this would require some complex conversion code.

Semi-fixed here:
https://github.com/boberfly/GafferCycles/commit/891da2438ad5626933588b27d08e134b2713ad2b
This should match the Blender way of setting hard/smooth normals. What you'll need to do is create a PrimitiveVariables node and make a constant boolean named "_smooth" to set what you want.
Next build should have this. Cheers!

@boberfly That is awesome! Thank you! Should this be a checkbox in the CyclesAttribute node? Thanks again!

Due to how it could be constant or uniform it is a primitive variable rather than an attribute, but perhaps for the constant case it could also be set as an attribute as an alternative way...


[Bug]<EMAIL_ADDRESS>is failing during install

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name
meshroom
Expected/Current Behaviour
Installation is failing while creating a shim for 'meshroom'. Error: "Can't shim 'meshroom.exe': File doesn't exist."
Installation should be successful.
Steps to Reproduce
PS> scoop update meshroom
meshroom: 2021.1.0 -> 2023.1.0
Updating one outdated app:
Updating 'meshroom' (2021.1.0 -> 2023.1.0)
Downloading new version
Loading Meshroom-2023.1.0-win64.zip from cache
Checking hash of Meshroom-2023.1.0-win64.zip ... ok.
Uninstalling 'meshroom' (2021.1.0)
Unlinking ~\scoop\apps\meshroom\current
Installing 'meshroom' (2023.1.0) [64bit] from extras bucket
Loading Meshroom-2023.1.0-win64.zip from cache
Linking ~\scoop\apps\meshroom\current => ~\scoop\apps\meshroom\2023.1.0
Creating shim for 'meshroom'.
Can't shim 'meshroom.exe': File doesn't exist.

Possible Solution
no idea
Scoop and Buckets Version
PS> scoop --version

Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
53ebd6cfd (HEAD -> master, origin/master, origin/HEAD<EMAIL_ADDRESS>Fix hash (Closes #11026)

'games' bucket:
0414fca5 (HEAD -> master, origin/master, origin/HEAD) snes9x-dev: Update to version 1.62.3-1266

'goreleaser' bucket:
d17b92b (HEAD -> master, origin/master, origin/HEAD) Scoop update for goreleaser version v1.17.0

'java' bucket:
0e347830 (HEAD -> master, origin/master, origin/HEAD) temurin11-nightly-jre: Update to version 11.0.19-6.0.202304061901

'main' bucket:
706ea7507 (HEAD -> master, origin/master, origin/HEAD) vector: Update to version 0.29.0

'nirsoft' bucket:
28db834 (HEAD -> master, origin/master, origin/HEAD) Excluded two pad files that require a password. They need to be updated manually.

'nonportable' bucket:
791672a (HEAD -> master, origin/master, origin/HEAD) powertoys-np: Update to version 0.69.1

Scoop Config
PS> scoop config

last_update         scoop_branch scoop_repo
-----------         ------------ ----------
12.04.2023 23:15:18 master       https://github.com/lukesampson/scoop

PowerShell Version
PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.3.3
PSEdition                      Core
GitCommitId                    7.3.3
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Additional Softwares
No response

https://github.com/ScoopInstaller/Extras/commit/458fb67245e812f7c46fcac9a144dbded036c845
If you do not want to redo the download, rename the file meshroom#2023.1.0#https_www.fosshub.com_Meshroom.html_dwl_Meshroom-2023.1.0-win64.zip to meshroom#2023.1.0#https_www.fosshub.com_Meshroom.html_Meshroom-2023.1.0-win64.zip (in Scoop\cache directory)


Adding a Dockerfile to build a hellbender container

Creating a basic dockerfile so we can build containers of hellbender.

Coverage remained the same at 71.65% when pulling 5692347d94393ca951a6b92580d4017cf45c1d62 on lb_dockerizing_for_execution_service into af16a71d2c76c57d00112da3694f8e5fcd0e1b73 on master.

:+1: go ahead


ESM Build Target Using Rollup

Closes #58
Details

Uses rollup along with rollup-plugin-typescript2 to build to two target files (index.es.js and index.cjs.js). This means that there is only a single file now for each target rather than 4 files (ie. index.js, chain.js, etc.).
Rollup has their own official @rollup/plugin-typescript plugin but it does not have the best TS declarations support atm (see https://github.com/rollup/plugins/issues/394, https://github.com/rollup/plugins/issues/254, https://github.com/rollup/plugins/issues/243). Until these are resolved, I choose to just use rollup-plugin-typescript2.
rollup-plugin-typescript2 generates index.d.ts, chain.d.ts, result.d.ts and result-async.d.ts but this is inconsistent with the generated JavaScript files. This isn't a huge issues unless someone tries to import neverthrow/dist/chain which would error because the underlying .js doesn't exist. To remedy this issue, I used rollup-plugin-dts to merge *.d.ts files into a single index.d.ts.
Because the build process is kinda two steps (first using rollup-plugin-typescript2 and then using rollup-plugin-dts), I first write to tmp/, then write the merged index.d.ts to dist/ and then moved index.es.js and index.cjs.js to dist/.
I'm a bit sad that it's this complicated to generate two build outputs but once some of the issues I've linked to above are resolved this process will become much easier :)

Publish Dry Run
➜ npm publish --dry-run
npm notice
npm notice 📦<EMAIL_ADDRESS>npm notice === Tarball Contents ===
npm notice 1.1kB  LICENSE
npm notice 14.5kB dist/index.cjs.js
npm notice 14.2kB dist/index.es.js
npm notice 1.5kB  package.json
npm notice 25.3kB README.md
npm notice 4.3kB  dist/index.d.ts
npm notice === Tarball Details ===
npm notice name:          neverthrow
npm notice version:       2.3.2
npm notice package size:  12.2 kB
npm notice unpacked size: 60.8 kB
npm notice shasum:        e90c96355a65c7e6bfa6664fa9e3a12e02693424
npm notice integrity:     sha512-8m34VsIllfdFN[...]E60K4SZJQLueg==
npm notice total files:   6
npm notice
+<EMAIL_ADDRESS>

Hey @jsmith thank you for opening this PR!
A few thoughts before merging.

Looks like typechecking is failing. Do you have any idea why that may be?
RE: Your detailed context & explanations on usage of various packages: Could you add this to the top of the rollup.config.js file as a module comment?

/**
 * info info info info
  */

Ok just added the module comment. Also the type issues stemmed from changing target from CommonJS to ES2015. This comment explains it well but apparently changing the target also changed the module resolution algorithm. rollup requires a target >= ES2015 btw which is why I made that change.


TODO list after normalize pdclient to client-java

com.pingcap.tikv.util.ConvertUpstreamUtils.isTiKVVersionGreatEqualThanVersion method: If the upstream changes the method name from StoreVersion.minTiKVVersion to StoreVersion.isTiKVVersionGreatEqualThanVersion, remove this method and use the upstream method directly. tikv/client-java#647

TiDBOptions txnPrewriteBatchSize,txnCommitBatchSize,writeBufferSize,writeThreadPerTask,retryCommitSecondaryKey,prewriteMaxRetryTimes are deleted, because these configuration items involve the private constructor of TwoPhaseCommitter. Upstream does not provide a public constructor for use. Temporarily disable the settings of several configuration items to restore the upstream updated configuration. (recovery of documents involved).

TiFlash cache missing need to fix. #1380 Temporarily fixed in TiSpark.

If the retry logic of batchGet is added upstream. Re-check the test result of batchGetRetryTest. Restore the test or modify/delete the test tikv/client-java#645

According to the removed class by https://github.com/pingcap/tispark/pull/2491, the following prs need to be paid attention to. we need to judge if they are needed to port to upstream.

Retry

Fix txnHeartBeat retry: https://github.com/pingcap/tispark/pull/2304
retry enhancement: https://github.com/pingcap/tispark/pull/1768 https://github.com/pingcap/tispark/pull/2279

Region manager

Fix region manager race: https://github.com/pingcap/tispark/pull/1987

Optimize region cache miss：https://github.com/pingcap/tispark/pull/2106 + fix not leader error due to region not invalidatedhttps://github.com/pingcap/tispark/pull/2135

fix region may be missed: https://github.com/pingcap/tispark/pull/2433

support log desensitization： https://github.com/pingcap/tispark/pull/1798

Fix ResolveLock not called in Scan API https://github.com/pingcap/tispark/pull/2089

fix region may be missed https://github.com/pingcap/tispark/pull/2433 （done）

Make TiSpark's Explain clearer and easier to read: https://github.com/pingcap/tispark/pull/2439

support clustered index https://github.com/pingcap/tispark/pull/1915 ( maintain CoprocessorIterator in TiSpark or upstream ?)

[ ] TiFlash cache missing need to fix. [TISPARK-488] Fix TiFlash region cache  #1380 Temporarily fixed in TiSpark.
[ ] If the retry logic of batchGet is added upstream. Re-check the test result of batchGetRetryTest. Restore the test or modify/delete the test https://github.com/tikv/client-java/pull/645
[ ] Fix txnHeartBeat retry: https://github.com/pingcap/tispark/pull/2304
[ ] retry enhancement: https://github.com/pingcap/tispark/pull/1768 https://github.com/pingcap/tispark/pull/2279
[ ] Fix region manager race: https://github.com/pingcap/tispark/pull/1987
[ ] Optimize region cache miss：https://github.com/pingcap/tispark/pull/2106 + fix not leader error due to region not invalidatedhttps://github.com/https://github.com/pingcap/tispark/pull/2135
[ ] fix region may be missed: https://github.com/pingcap/tispark/pull/2433
[ ] support log desensitization： https://github.com/pingcap/tispark/pull/1798
[ ] Fix ResolveLock not called in Scan API https://github.com/pingcap/tispark/pull/2089
[ ] Make TiSpark's Explain clearer and easier to read: https://github.com/pingcap/tispark/pull/2439
[ ] support clustered index https://github.com/pingcap/tispark/pull/1915 ( maintain CoprocessorIterator in TiSpark or upstream ?)

Sometimes, it is difficult to judge which is better (TiSpark or client-java).
In such case, here is two suggestions:

follow the behavior of TiDB
reference client-go

有时候，很难判断哪个更好（TiSpark或者client-java），比如返回null或者抛出异常；是否为某个错误重试 这种情况，这里有两个建议：

随行 TiDB 的行为
参考客户端

The previous integration test table was not found whether it was caused by a cache miss
I found that the integration test on jenkins seems to be refactored once? (curious)

table not found may not result from the cache miss. it supposed to be fixed in this pr https://github.com/tikv/client-java/pull/670.
integration test should not be refactored.

All things have been done.


Math.lgamma returns [infinity, -1] on -0.0

The test does not pass on ruby 2.2.4p230 (2015-12-16 revision 53155) [i386-mingw32], is it expected? Should I make it so it's only tested on Windows for ruby >= 2.4 for now?

I made it 2.4+ only until the fix is backported.
Thank you for the new test!


No sleep function ?

I've been browsing through the documentation and source code, and I've been unable to find any function that would allow me to put the LoRa module to sleep when not in use for a long period of time, to save energy. Is this function implemented, or will it be implemented ?

The armapi give a armSleep() function.
To use this function on Arduino, you will need to uncomment the ARMPORT_WITH_nSLEEP define in armconfig.h file in directory of library of your Arduino IDE.


No files listed when selecting "Manage Files"

Running the latest 2.14.0 and noticed that when I clicked on Manage Files to add/remove files/folders to the backup set, only two folders are displayed, when there were dozens of folders that were selected to be backed up.  When I try to Restore Files, it looks like there is nothing to restore until I get to 4/24, which was the date I believe I updated to the newest version.  So, it looks like the files exist both physically in my NAS folders as well as on the Crashplan destination site, but not in the Crashplan docker app.  No settings had been changed at all, just a simple upgrade.  Am I missing something?  CP seems to think there are no folders to backup.

Hi, any news on this ?
I am experiencing the exact same thing. I have updated my docker image from 7.7.0 to 10.0.0 on June 20th (I am using the docker image on my Synology NAS, which is now under DSM 7.1)
When I open Crashplan docker interface, and:

go to Manage Files, I can see my selected folders to backup, but when I click on those folders, they are empty.
go to Restore Files -> No files nor folders here anymore. I have to select the date before the day I updated Crashplan to see the usually backup folders OR I have to select the 'Include deleted files' option under the three-dots menu.

It looks like all my folders that I've backup since ~6 years this way are now considered as deleted files for Crashplan, and this is terrifying me actually ...
Would you please help me on this, this is the first time I am experiencing such a thing with the CrashPlan docker image.
Thank you

Can you share the config of the container ?
Looks like a permission issue, where CrashPlan has no read permissions on the files.

Sure, would you mind just letting me know how to share it (screenshot ? command to type?) ? Sorry about that.

OK maybe this ?
   "CapAdd" : null,
   "CapDrop" : null,
   "cmd" : "/init",
   "cpu_priority" : 50,
   "enable_publish_all_ports" : false,
   "enable_restart_policy" : true,
   "enable_service_portal" : null,
   "enabled" : true,
   "env_variables" : [
      {
         "key" : "PATH",
         "value" : "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
      },
      {
         "key" : "LANG",
         "value" : "en_US.UTF-8"
      },
      {
         "key" : "S6_BEHAVIOUR_IF_STAGE2_FAILS",
         "value" : "3"
      },
      {
         "key" : "S6_SERVICE_DEPS",
         "value" : "1"
      },
      {
         "key" : "USER_ID",
         "value" : "0"
      },
      {
         "key" : "GROUP_ID",
         "value" : "0"
      },
      {
         "key" : "APP_NAME",
         "value" : "CrashPlan for Small Business"
      },
      {
         "key" : "APP_USER",
         "value" : "app"
      },
      {
         "key" : "XDG_DATA_HOME",
         "value" : "/config/xdg/data"
      },
      {
         "key" : "XDG_CONFIG_HOME",
         "value" : "/config/xdg/config"
      },
      {
         "key" : "XDG_CACHE_HOME",
         "value" : "/config/xdg/cache"
      },
      {
         "key" : "XDG_RUNTIME_DIR",
         "value" : "/tmp/run/user/app"
      },
      {
         "key" : "DISPLAY",
         "value" : ":0"
      },
      {
         "key" : "DISPLAY_WIDTH",
         "value" : "1280"
      },
      {
         "key" : "DISPLAY_HEIGHT",
         "value" : "768"
      },
      {
         "key" : "S6_WAIT_FOR_SERVICE_MAXTIME",
         "value" : "10000"
      },
      {
         "key" : "KEEP_APP_RUNNING",
         "value" : "1"
      },
      {
         "key" : "CRASHPLAN_SRV_MAX_MEM",
         "value" : "1600M"
      }
   ],
   "exporting" : false,
   "id" : "691dadc13147e34ad400995d92e6d92da361927857fd6237cd034b4bff34e19f",
   "image" : "jlesage/crashplan-pro",
   "is_ddsm" : false,
   "is_package" : false,
   "links" : [],
   "memory_limit" : 0,
   "name" : "crashplan-pro",
   "network" : [
      {
         "driver" : "bridge",
         "name" : "bridge"
      }
   ],
   "network_mode" : "default",
   "port_bindings" : [
      {
         "container_port" : 5800,
         "host_port" : 5800,
         "type" : "tcp"
      }
   ],
   "privileged" : false,
   "shortcut" : {
      "enable_shortcut" : false,
      "enable_status_page" : false,
      "enable_web_page" : false,
      "web_page_url" : ""
   },
   "use_host_network" : false,
   "volume_bindings" : [
      {
         "host_volume_file" : "/docker/appdata/crashplan-pro",
         "mount_point" : "/config",
         "type" : "rw"
      }
   ]
}

Well that is exactly what I was thinking when looking at the config, but since I was not sure how it was before, I wasn't able to compare it, thus wasn't able to troubleshoot this.
I just wonder why this has changed since I updated the docker image as I have always done for years (following your instructions on the wiki here : https://github.com/jlesage/docker-crashplan-pro#synology), and I have never experienced such a problem.
When I first created the container a few years ago (I kept a note with the command lines I used), I know that I used those tags regarding the volume :
	-v /volume1/docker/appdata/crashplan-pro:/config:rw \
	-v /volume1/:/volume1:ro \

Is it possible to fix it, mapping it again, and so the folders won't be marked as deleted on crasphlan, or do I have to re-upload everything (I am terrified writing this since we are talking about 4TB of data)

You can use the Synology UI (Container Station) to add back the mappings.
However, note that the mapping /volume1/:/volume1:ro no longer works with recent Synology versions.  You need instead to map folders under it.  For example, you can map /volume1/Movies from the NAS to /volume1/Movies in container.

By chance, do you have an idea what could have caused this ? I mean again, everything was working fine until I update the image from 7.7.0 to 10.0.0 two days ago...
As for the change of mapping support by Synology, I didn't know. Since I'm using Crashplan, I've been  backuping to Crashplan 4 folders :

volume1/ BACKUPS
volume1/DATA
volume1/git
volume1/web

That means I now have to add these 4 mappings instead of the volume1/ I used to map, is that correct ?
And what about Crashplan? Will that fix the problem automatically so I won't need any re-upload ?
(Thanks a lot Jocelyn!)

By chance, do you have any idea what could have caused this ? I mean again, everything was working fine until I update the image from 7.7.0 to 10.0.0 two days ago...

I don't know... seems to be a glitch in the Synology upgrade procedure?  To automatically upgrade the containers, you may want to check Watchtower: https://github.com/containrrr/watchtower

That means I now have to add these 4 mappings instead of the volume1/ I used to map, is that correct ?

Correct.

And what about Crashplan? Will that fix the problem automatically so I won't need any re-upload ?

Yes, this should fix the issue.

Well, here is what I see now, what terrified me seems to happen.... is it going to upload everything again ??

This part is confusing.  That doesn't mean that everything is re-uploaded.
Look at Tools->History, you should see very high "effective" rates, meaning that data has been found in cloud and no re-upload occurred.

Everything is okay now, thank you so much Jocelyn ! It took 2 days to scan and upload every not-already-backuped files but everything's back to normal now.
Thank you!

Great, happy to hear that everything works fine!


Clarify whether an http redirect is conditional or unconditional

What would you like to be added:
In the redirect examples here https://gateway-api.sigs.k8s.io/guides/http-redirect-rewrite/#redirects the backendRefs are always configured. Like below:
. . .
  rules:
    - filters:
      - type: RequestRedirect
        requestRedirect:
          scheme: https
          statusCode: 301
      backendRefs:
      - name: example-svc
        weight: 1
        port: 80

If the redirect is unconditional (always fires), then the backendRefs are unnecessary, because the proxy will never proxy to the backends.
However, if the redirect is conditional, then the backendRefs are OK. However, I think it make sense to clarify in the examples when the redirect will not fire and why the backendRefs are needed. Also, I think it makes sense to clarify that in the docs https://github.com/kubernetes-sigs/gateway-api/blob/a7a465ababc8b7c2cd9eaa1ab769496704fee92a/apis/v1beta1/httproute_types.go#L819
Why this is needed:

to ensure consistent behavior across implementations
to make the documentation clearer.

See also:

loop protection proposal -- https://github.com/kubernetes-sigs/gateway-api/issues/1185
a related discussion about redirect behavior -- https://github.com/kubernetes-sigs/gateway-api/discussions/1360

I think it makes sense +1.


MarkdownMessage

Now responses support markdown and UI access is handled in a way that is in theory betterer 🤓

Manually merged


unable to start project locally

Hello,
when I wanted to deploy new project with deployctl There was an error that says:
 $ ~/mySrc/myproject deployctl run --watch --no-check **main.ts**
Download<EMAIL_ADDRESS>error: error sending request for url (https://x.lcas.dev/preact@10.5.12/hooks.js): error trying to connect: tls handshake eof
    at https://raw.githubusercontent.com/lucacasonato/fresh/main/src/runtime/deps.ts:2:0

versions:
deno: deno 1.11.4+ed16f43
deployctl: deployctl 0.3.0
fresh: deployctl 0.1.0
Update:
I don't know why this problem fixed after running deno run main.ts (this command downloaded (https://x.lcas.dev/preact@10.5.12/hooks.js))
then I am able to run deployctl.
but this time after opening the site in browser, deno throws error and 500 response...
Listening on http://<IP_ADDRESS>:8080
 > deno:https://raw.githubusercontent.com/lucacasonato/fresh/main/src/runtime/deps.ts:1:14: error: [plugin: deno] error sending request for url (https://x.lcas.dev/preact@10.5.12/mod.js): error trying to connect: tls handshake eof
    1 │ export * from<EMAIL_ADDRESS>      ╵               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

 > deno:https://raw.githubusercontent.com/lucacasonato/fresh/main/src/runtime/deps.ts:23:7: error: [plugin: deno] error sending request for url (https://x.lcas.dev/preact@10.5.12/hooks.js): error trying to connect: tls handshake eof
    23 │ } from<EMAIL_ADDRESS>       ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: Build failed with 2 errors:
deno:https://raw.githubusercontent.com/lucacasonato/fresh/main/src/runtime/deps.ts:1:14: error: [plugin: deno] error sending request for url (https://x.lcas.dev/preact@10.5.12/mod.js): error trying to connect: tls handshake eof
deno:https://raw.githubusercontent.com/lucacasonato/fresh/main/src/runtime/deps.ts:23:7: error: [plugin: deno] error sending request for url (https://x.lcas.dev/preact@10.5.12/hooks.js): error trying to connect: tls handshake eof
    at failureErrorWithLog (https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:3052:19)
    at https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:2734:32
    at runOnEndCallbacks (https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:2532:51)
    at buildResponseToResult (https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:2732:11)
    at https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:2839:18
    at https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:2223:13
    at handleIncomingPacket (https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:2320:13)
    at readFromStdout (https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:2190:11)
    at Object.worker.onmessage (https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:3906:38)
    at https://gist.githubusercontent.com/lucacasonato/358c6b7e8198bfb2cf3d220e49fdcf5f/raw/3714cb0f59606eefc29ed0fea36d4cd93549938b/esbuild-wasm.js:3897:45

@Hadi374 The latest main imports preact from a different CDN. That should fix the issue. If you still encounter this, please re-open the issue.


Any plan to support dart 2?

This issue was originally created by @willladislaw here, before being automatically moved:
https://github.com/angel-dart-archive/poll/issues/1

@thosakwe commented:
Consider sending a PR; pkg:angel_client has been updated, and this package relies on it.
The code itself will probably not require a change; it’ll probably just need a change to the pubspec (which to be honest, has annoyed me beyond end since Dart 2 came out).


Suggestion

This mod is cool, however, will the price and health of the intern be customizable in the future? By the way, can you add an option that allows interns to spawn on moons as well?
Anyways, great mod!

Hi !

Sorry I don't understand your second question, what do you mean by spawn on moons ? not by dropship ?

Yes, not by dropship


[Google Maps] On hover tooltip doesn't appear for the feature if click popup was opened and closed

Testing new changes with Leaflet provider.
STR

Create a map (with Leaflet) of polygons, for example.
Enable click popups with all attributes selected, for example.
Check that it is working 👌 .
Enable on hover popups with all attributes selected, for example.
Check that it is working 👌 .
Now, click over one feature, click popup will appear (on hover one should disappear).
Now close the previous click popup and make over that feature in order to see the on hover tooltip.
It doesn't appear.

Looks like the "unbind" when the click popup is closed is not working properly.

In production is working properly.


Fix: Broken Link Fixes in main Readme.md (tasks/ -> release/tasks/)

What this PR does / why we need it:
The tasks sub-directory was moved under the release directory from v0.18. Consequently, the links in the main README.md are broken.
Which issue(s) this PR fixes :
Fixes # (Issue doesn't exist: fixing directly)
Special notes for your reviewer:
Release note:

NONE

needed to force push as had to amend the commit locally for the DCO signoff

Hi, thank you for your PR :+1:
/ok-to-test

/ok-to-test


Support for Foundry Core v12

Is your feature request related to a problem? Please describe.
Foundry v12 just released a stable version, so it's that time again...
Describe the solution you'd like
Support v12.
Additional context
Nothing appears broken, only deprecation warnings in logs.  Technically speaking, this system (at least at first glance) seems to work in v12 just fine.  But there might be issues I'm not aware of because I don't fully utilize the complete feature set of this system.
Blockers
I found nothing found to prevent use of this System in v12.
Tested the character sheet by performing tasks, modifying attributes/disciplines, adding items to inventory.
I have not necessarily tested ALL functionality, just randomly tried things to look for broken behavior in the features I am familiar with.
Non-Blocking
API deprecation warnings
There are a few warnings that will become errors in Version 14.  So, they are cans that could be kicked down the road another year (or two?).  I don't think there's any security, stability, or performance reasons to consider these blockers.
This is triggered pretty much every character change.
foundry-esm.js:4610 Error: You are accessing globalThis.mergeObject which must now be accessed via foundry.utils.mergeObject
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4598:19)
    at get (foundry-esm.js:65057:25)
    at get defaultOptions (character-sheet.js:6:5)

This warning was triggered when rendering a talent sheet, or other sheets that include a select/dropdown (I see no line for the offending code in this stack).
foundry-esm.js:4610 Error: The {{select}} handlebars helper is deprecated in favor of using the {{selectOptions}} helper or the foundry.applications.fields.createSelectInput, foundry.applications.fields.createMultiSelectElement, or foundry.applications.fields.prepareSelectOptionGroups methods.
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4598:19)
    at Item.select (foundry.js:8257:19)
    at Item.c (handlebars.min.js:27:27865)
    at Object.eval [as main] (eval at createFunctionContext (handlebars.min.js:29:10011), <anonymous>:23:129)
    at c (handlebars.min.js:27:23534)
    at d (handlebars.min.js:27:23849)
    at e (handlebars.min.js:28:30886)
    at renderTemplate (foundry.js:7821:10)
    at async STACharacterWeaponSheet._renderInner (foundry.js:5989:16)
    at async STACharacterWeaponSheet._renderInner (foundry.js:6559:18)
    at async STACharacterWeaponSheet._render (foundry.js:5820:19)
    at async STACharacterWeaponSheet._render (foundry.js:6548:5)
    at async STACharacterWeaponSheet._render (foundry.js:7134:5)

This warning was triggered while modifying belongings of a character.
Error: You are accessing globalThis.isNewerVersion which must now be accessed via foundry.utils.isNewerVersion
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4598:19)
    at get (foundry-esm.js:65057:25)
    at activeDialog.staActor.deleteConfirmDialog.activeDialog (character-sheet.js:281:11)

All error stacks are snipped at the first plugin code line to keep them succinct.

There is definitely no functional issue introduced with v12.
Addressing these deprecation notices prior to v14 is probably ill-advised, as I think this would require dropping support for v10 and v11 of core.

These have been addressed in PR #109 they were tested backwards with v11 successfully.

This has been achieved in release 1.2.1


White screen with 0 configuration webpack plugin

Describe the bug
Nothing is visible on the screen and errors in the console
To Reproduce
Steps to reproduce the behavior: idk, I just install webpack plugin w/o configuration :)
Expected behavior
Stats on the screen
Screenshots

Versions:

Node (for non-browser bug):  12
Browser (for browser-bug): 92.0.4515.1716
Statoscope: "@statoscope/webpack-plugin": "5.8.0"

@pivaszbs please, provide some additional info:
webpack version
stats field from your webpack config
seems like you have webpack 5 and all: true in your stats config )

@smelukov webpack: 5
zero config as I said :)

Please, try to use plugin with this configuration:
new StatoscopeWebpackPlugin({
  statsOptions: {
    all: false, // disable all the stats
    hash: true, // add compilation hash
    entrypoints: true, // add entrypoints stats
    chunks: true, // add chunks stats
    chunkModules: true, // add modules stats
    reasons: true, // add modules reasons stats

    assets: true, // add assets stats
    chunkOrigins: true, // add chunks origins stats (to find out which modules require a chunk)
    version: true, // add webpack version
    builtAt: true, // add build at time
    timings: true, // add build at time
    performance: true, // add info about oversized assets
    source: true, // add module sources (uses to find modules duplicates)
  },
  open: 'file',
});

Is it fix your problem?

Actually crashed with
TypeError: resolvedModule.chunks is not iterable at handleModule (<project_path>/node_modules/@statoscope/webpack-model/dist/normalizeCompilation.js:12:64) at handleChunk (<project_path>/node_modules/@statoscope/webpack-model/dist/normalizeCompilation.js:19:29) at handleCompilation (<project_path>/node_modules/@statoscope/webpack-model/dist/normalizeCompilation.js:36:9) at Object.normalizeCompilation [as default] (<project_path>/node_modules/@statoscope/webpack-model/dist/normalizeCompilation.js:44:9) at <project_path>/node_modules/@statoscope/webpack-plugin/dist/index.js:73:43
Attempt to remove chunks option not crash build and lead to this behavior

@pivaszbs thanks for the issue 🙏
It will be fixed in the near release

Fixed in v5.9


Cannot change profile picture

1.Go to profile settings
2. Press on current placeholder
3. pick photo
4. It shows the photo correctly in the preview
5. Hit save
6. Photo is not changed, instead it becomes some different placeholder (grey colored)

tested more:
this is how it is saved in firebase:
"/data/user/0/PACKAGE_NAME/cache:Compressor:p2l7u538b5ikcp3bdroo7sug37.jpeg"
the image is not uploaded to server, just an Uri is saved, which at least explains why image would not change for others, but locally I still get error trying to load this image.
not sure why, maybe it is not saved/cached correctly. But I think image should be uploaded to firebase storage so everybody could see changes


Automatically initialize table when trying to index it

I know this would break Lua a bit, but imagine all the characters we could save if we wouldn't have to call somearray={} before we access it for the first time.
In short, I propose changing Lua interpreter a bit so instead of throwing attempt to index a nil value error it would silently initialize the table when it's first indexed (unless it's already a "normal" variable).

There are a lot of possibilities how to reduce size of code by changing a lua interpreter. But then It could not be called Lua no longer. TIC is about learning a programming and these little modifications in language will make it hard for those who already know Lua or for those who will want to use Lua in other projects than TIC. Modifing a Lua language in TIC could have negative impact on popularity of this fantasy console compared to others because of the need to learn and remember these differences in the language. I know you suggest only one little change but if one change will be made then it will not remain only with this one.
There are a lot of others possibilities how to reduce size of code and still preserve the Lua language standard.

Well, Pico-8's lua diverges in places pretty wildly form "regular" lua and any programmer worth his/her salt would be able to get the differences once he/she moves to other Lua environments. Additionally, as long as what the differences are is well documented, I don't see a problem.
Keep in mind that Lua wasn't created with limits of fantasy consoles such as Pico-8 or TIC-80 in mind so some sacrifices have to be made.

Not all what is in Pico-8 is the best. Because of TIC is inspired by Pico, It haven't to be its copy. TIC has its own path.
If I should choose between studying a documentation of modified version of lua and then standard lua which I can use immidiately in an others applications so I choose second option.
Keep in mind that TIC isn't intended just for advanced programmers but also for beginners.
My opinion is that If some language modifications should be made, only in a way that does not affect the standard. One option is to implement macros which will allow to optionally change syntax of lua but don't mess up the lua standard if none would be defined. But It would be big deal to implement it to TIC.

I'm negative about any LUA hacks and want to leave it clean, so, beginners can use any Lua documentation found on the Internet to learn how to program. Also, I want to be able to update LUA lib at any time without patching a new version.
I think we can close the issue


Remove double dispatching from some analyzers

Current coverage is 80.88% (diff: 100%)

Merging #4194 into master will decrease coverage by 0.16%

@@             master      #4194   diff @@
==========================================
  Files          1300       1299     -1
  Lines         44294      44290     -4
  Methods           0          0
  Messages          0          0
  Branches       7056       7056
==========================================
- Hits          35901      35825    -76
- Misses         5747       5810    +63
- Partials       2646       2655     +9

Powered by Codecov. Last update 7370954...16fb308


"join our mailing list" link target incorrect

On https://lib.reviews/?uselang=en, the link "join our mailing list" leads to https://freeculture.org/Mailman/listinfo/lib.reviews. There is no way to join the mailing list from there.

We moved the freeculture.org wiki to a new server; haven't reinstalled mailman yet. Added a maintenance notice for now.

This was fixed a while ago; closing


Fetch vs built-in DownloadManager

Hi all! I'm (very) new to Android development, and need to build background downloads into my app. Basically, all I need is to

enqueue download jobs
make sure downloads continue if the user leaves/kills the app
have downloads resume in case of connectivity issues
know once they have completed or failed

I really care mostly about stability across a wide range of devices rather than more specific features. Are there any reasons I should use a proprietary library like Fetch for this over the built-in DownloadManager? Thanks!

@hardcodet It depends on what you need. The build in download manages does not give you access to pause or resume through your app. That is handled by the system. If that works for you then use it. If your app requires you to pause and resume within the app, you will need to use another library to handle that. Fetch is not proprietary. It is open source. You are allows to copy the source code and use it how you want. Hope this helps.

It does - thanks for the response @tonyofrancis . And thanks for putting all the effort into the library! 👍 👍 👍


Utility functions and breaking change to compression options

Replace compression_method=ZipArchives.Deflate  with compress=true when calling zip_newfile

Codecov Report
Patch coverage: 96.15% and project coverage change: -0.09 :warning:

Comparison is base (9bde534) 97.11% compared to head (6fe12b5) 97.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   97.11%   97.03%   -0.09%
==========================================
  Files           6        6
  Lines         729      742      +13
==========================================
+ Hits          708      720      +12
- Misses         21       22       +1

Impacted Files
Coverage Δ

src/ZipArchives.jl
0.00% <ø> (ø)

src/reader.jl
96.22% <95.00%> (-0.16%)
:arrow_down:

src/writer.jl
99.09% <100.00%> (+<0.01%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CONDA_PREFIX overriding JULIA_DEPOT_PATH

Currently, $CONDA_PREFIX (and $VIRTUAL_ENV) overrides ignores $JULIA_DEPOT_PATH. This is a problem in scenarios where (Ana)conda is installed in a read-only location, like an Apptainer/Shifter container or a shared storage location on a larger multi-user compute system/cluster. Since $JULIA_DEPOT_PATH gets ignored, the user runs into trouble like this
[...]
[juliapkg] Using Julia project at /opt/anaconda3/julia_env
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/user/.local/lib/python3.9/site-packages/juliapkg/deps.py", line 278, in project
    resolve()
  File "/user/.local/lib/python3.9/site-packages/juliapkg/deps.py", line 233, in resolve
    os.makedirs(project, exist_ok=True)
  File "/opt/anaconda3/lib/python3.9/os.py", line 225, in makedirs
    mkdir(name, mode)
OSError: [Errno 30] Read-only file system: '/opt/anaconda3/julia_env'

Could we change the resolution mechanism so that $JULIA_DEPOT_PATH takes priority over $CONDA_PREFIX (and ideally $VIRTUAL_ENV as well)?

Your issue is nothing to do with JULIA_DEPOT_PATH, which is not modified by this package. The location of Julia projects is unrelated to the depot unless you are using a default/shared/temporary project, but this package explicitly sets the project to be inside your Python environment.
So your issue really is that this package assumes your Python environment is writeable, which it is not in your case. A couple of workarounds are (a) don't use the root conda environment (which is generally a good idea anyway) or (b) set PYTHON_JULIAPKG_PROJECT to some writable directory or (c) get the user with write permission in the root environment to also initialise JuliaPkg.

Sorry, yes, I should have put that better, JULIA_DEPOT_PATH itself is not changed, of course. But setting PYTHON_JULIAPKG_PROJECT doesn't seem to help:
$ export PYTHON_JULIAPKG_PROJECT=/tmp/pyjlprj
$ python

>>> import juliacall
[juliapkg] ...
...
OSError: [Errno 30] Read-only file system: '/opt/anaconda3/julia_env'

That shouldn't happen, I think you must be on an old version of JuliaPkg - can you update and try again please.

I think you must be on an old version of JuliaPkg

Oh, you're right - I'm sorry, I thought I was on juliapkg v0.1.7, but something must have been mixed up with my Python paths. That why I tried the JULIA_DEPOT_PATH route in the first place, because PYTHON_JULIAPKG_PROJECT didn't seem to have any effect.
Sorry again!


Fix typo

IPSec -> IPsec

@duongau
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Enable interpreter properties edit

This PR enables you to edit interpreter setting properties.

Great job!
BTW, it will create big conflict with my PR.
https://github.com/NFLabs/zeppelin/pull/321
I'll need to manually merge it.
T_T

Tested, works great!
Also manually merged into #321

Thanks for taking care of the conflict!

@minahlee This is really useful improvements. Great work.
But it still have conflict. Can you resolve it?

Tested and Looks good to me!


performance improvement

redesign the logic of fetching data

@710leo Please review this PR when you are free.


[form-select] Updating Placeholder color to pass accessibility tests

Summary
Temporarily fix for https://github.com/cerner/terra-core/issues/2708
Change to placeholder color to pass accessibility
Please add your name to the CONTRIBUTORS.md file. Adding your name to the CONTRIBUTORS.md file signifies agreement to all rights and reservations provided by the License.
Thanks for contributing to Terra.
@cerner/terra

Add a test for this please.

@mjhenkes screenshots were updated?  Did you want another test?

@mjhenkes Added accessibility test here https://github.com/cerner/terra-core/pull/2713/commits/a903e121d0b691d6ff9998a4038044ac20c87404#diff-f04231d8324451e8ad9fbf444bafd88fR1
Confirmed it failed with old placeholder values locally


Faile to find partition column: n

What type of bug is this?
Unexpected error
What subsystems are affected?
Frontend
What happened?
commit: c5f507c20e69b28dd2291c2e5649d05fe4fe67cb
Distributed mode.
In the case where the table doesn't have a primary key set, I successfully created a partitioned table. However, after I inserted data, when I tried to delete the existing data from the table based on the partition key, I encountered an error: Failed to find partition column: n. Similarly, if I set a primary key but the partition key is not the primary key, I get the same error.

The issue arises from the fact that after performing a scan, only data from the primary key and ts column are returned, and the partition column is not returned.
https://github.com/GreptimeTeam/greptimedb/blob/c5f507c20e69b28dd2291c2e5649d05fe4fe67cb/src/query/src/datafusion.rs#L153-L175
As a result, during the split_delete() process, the corresponding data cannot be found.
https://github.com/GreptimeTeam/greptimedb/blob/c5f507c20e69b28dd2291c2e5649d05fe4fe67cb/src/partition/src/splitter.rs#L96-L103
Maybe we need to return the partition column data in the scan.
What operating system did you use?
6.1.41-1-MANJARO
Relevant log output and stack trace
No response
How can we reproduce the bug?
CREATE TABLE dist_table(
    ts TIMESTAMP DEFAULT current_timestamp(),
    n INT,
    row_id INT,
    TIME INDEX (ts)
)
PARTITION BY RANGE COLUMNS (n) (
    PARTITION r0 VALUES LESS THAN (5),
    PARTITION r1 VALUES LESS THAN (9),
    PARTITION r2 VALUES LESS THAN (MAXVALUE),
)
engine=mito;

INSERT INTO dist_table(n, row_id) VALUES (1, 1);
INSERT INTO dist_table(n, row_id) VALUES (2, 2);
INSERT INTO dist_table(n, row_id) VALUES (3, 3);
INSERT INTO dist_table(n, row_id) VALUES (4, 4);
INSERT INTO dist_table(n, row_id) VALUES (5, 5);

delete from dist_table where n in (1, 2);

Now partition columns have to be primary keys, this issue can be resolved. See my test:


update the start page text

Story: https://mojdigital.teamwork.com/#/files/4650265
Before

After

Hold on, received some more changes

Content updated as of last request.


Hash HostName value on DownwardMetrics

What this PR does
A concern was raised about the possibility of exposing the host name to an untrusted VM via downward metrics. Let's return a hashed HostName value to avoid exposing the real host name to the VM.
The HostName value is used by SAP as an uuid of the node (to detect changes), and is not used to do dns queries.
Release note

The DonwardMetrics returns a hashed HostName value to avoid exposing the real host name to an untrusted VM

/retest-required

Tihs is about detecting changes - what kind of changes?
Did you then consider to use metadata.uid ? this is the POD UUID and is changing when the node changes, and in some other cases.

Tihs is about detecting changes - what kind of changes? Did you then consider to use metadata.uid ? this is the POD UUID and is changing when the node changes, and in some other cases.

Yes, (assuming you mean sending the uuid instead of the hostname). I think a host name hash it's better, because it keeps some of the "semantics" of a real host name, like it will be the same for two different executions of the same VM, or for two VMs on the same node. So, I think, sending a hash it's not really breaking the API, as you mention before, since it's a string value(*) with the same "semantics", but it's just useless for doing DNS queries/gather information.
(*) There is only one change with respect to a "real" host name, that is that the hash's length is 64 and the maximum for a label is 63, but that's easy to fix.

So, I think, sending a hash it's not really breaking the API, as you mention before, since it's a string value(*) with the same "semantics", but it's just useless for doing DNS queries/gather information.

Unconditionally sending a hash IS breaking the API, because the purpose of the HostName field is - no surprise - to provide the HostName to the workload (VM and pod alike) for use-cases which are different than the one pointed out here.
To me the pod.uid approach seems to be most reasonable for this problem - also because I have not seen any public statement that this workload is expected on KubeVirt or friends. AKa we are optimizing for a case where we are not sure if this will arrive.
Also: In the current (non-virtiofs) case, the downwars API stuff is pushed into an image once and not updated durin migrations. Thus you will anyhow not be able to identify a node change, because the image does not change.
Alternative could be node-local Services with internalTrafficPolicy.
Alterantive could also be a DevicePlugin to provide node specific pseudo-identifier.

So, I think, sending a hash it's not really breaking the API, as you mention before, since it's a string value(*) with the same "semantics", but it's just useless for doing DNS queries/gather information.

Unconditionally sending a hash IS breaking the API, because the purpose of the HostName field is - no surprise - to provide the HostName to the workload (VM and pod alike) for use-cases which are different than the one pointed out here.

AFAIK both the virtio-serial and disk downwardMetrics (a rebranded Virtual Host Metrics) is only for VMs not for containers, and it's only used by SAP. In the old RHV the admin can select which metrics wants to expose (per VM)

To me the pod.uid approach seems to be most reasonable for this problem - also because I have not seen any public statement that this workload is expected on KubeVirt or friends. AKa we are optimizing for a case where we are not sure if this will arrive.
Also: In the current (non-virtiofs) case, the downwars API stuff is pushed into an image once and not updated durin migrations. Thus you will anyhow not be able to identify a node change, because the image does not change.
Alternative could be node-local Services with internalTrafficPolicy. Alterantive could also be a DevicePlugin to provide node specific pseudo-identifier.

I think I was (am) confused, so you are not suggesting sending in the Downward Metrics HostName file the pod.uid instead of a has, in other words doing this (in pseudo go):
	return &DownwardMetricsReporter{
		staticHostInfo: &StaticHostMetrics{
			HostName:             nodeName,
			HostName:             pod.id,
...

So, if I understand what you are suggesting is to leave the HostName file as it is and the application uses the pod.idvia Downward API instead of the hostname, is this correct?

fwiw - There was a miscommunication: I was speaking about Kubernetes Downwards API, assuming that the Downwards Metrics were simply a different delivery of this API.But this was a wrong assumption. The term similarity (downwards vs downwards) was stronger than my memories of the downwards metrics' use-case
Downwards Metrics are totally different from Downwards API, thus there is obviously no need for alignment.


swiping between artworks feels buggy

see video
http://cl.ly/image/213W4016382L

Hah, I had taken screenshots for this exact thing.

update: @broskoski is checkin this out

hard to estimate this, i think it's tricky. 1 day to a couple days.

Chiming in that this is probably a lack of initial constraints at what size the work should be while we wait for the artwork.
In older releases it would default to fit a square if there is no image aspect ratio data, but these examples should have enough information to know the aspect ratio before grabbing the image.

I agree that this is probably the root of the cause. You think the aspect ratio is already available? Will look for it

yeah, should be accessible on the artwork's main image


Update docker documentation

This small PR adds a line about pointing towards local extensions, for rapid development.


Fix build failure caused by opensearch core refactor

Description
Fix build failure caused by opensearch core refactor
Issues Resolved
NA
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This PR should fix the build issue for k-nn. https://github.com/opensearch-project/k-NN/pull/955

Closing this PR since duplication.


Implement mass-concentrations from Ishiyama et al. (c500)

Addresses #892 .
Checklist:

[x] mass-concentration relation
[x] M500 mass definition
[x] unit tests
[x] benchmarks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 126 (11.11%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.7%) to 94.11%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyccl/halos/massdef.py
2
3
66.67%

pyccl/halos/concentration.py
12
123
9.76%

Totals

Change from base Build<PHONE_NUMBER>:
-2.7%

Covered Lines:
3803

Relevant Lines:
4041

💛  - Coveralls

Just a quick note: I just checked and I don't think the computational bottleneck comes from the calculation of dlnsigma/dlnR. If anything it may be dominated by the root finding, but that it's quite fast in itself, so I don't think we should worry.
In summary: ready to go as soon as the previous comments are addressed.

You are right, the bottleneck is the computation of sigmaM, in case these haven't already been computed. Then, root finding also takes time but I can't think of any other way. I profiled this one and Duffy08, and this one is an order of magnitude slower. Have a look at the attached images.
Ishiyama21

Duffy08

@damonge ready to be looked at again.

@damonge ready to be looked at again.

OK, you'll have to teach me how to  generate those timing diagrams ;-)
Just one comment above, and we can merge as soon as that's done.