TypeError: accuracy() missing 1 required positional argument: 'task'

Bug description
old code does not work anymore
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
[<ipython-input-24-0de98dbbb444>](https://localhost:8080/#) in <cell line: 4>()
      2
      3 trainer = pl.Trainer(fast_dev_run=True, devices=1, accelerator="gpu")
----> 4 trainer.fit(model)

25 frames
[<ipython-input-23-ce55fa773c61>](https://localhost:8080/#) in training_step(self, batch, batch_idx)
     77       outputs = self(encode_id, mask)
     78       preds = torch.argmax(outputs, dim=1)
---> 79       train_accuracy = accuracy(preds, targets)
     80       loss = self.loss(outputs, targets)
     81       self.log('train_accuracy', train_accuracy, prog_bar=True, on_step=False, on_epoch=True)

TypeError: accuracy() missing 1 required positional argument: 'task'

What version are you seeing the problem on?
v1.6, v1.9
How to reproduce the bug
"""
IMPORTANT NOTE
Any input text data that is less than the max_seq_len value will be padded,
and anything bigger will be trimmed down.
"""
class HealthClaimClassifier(pl.LightningModule):

    def __init__(self, max_seq_len=512, batch_size=128, learning_rate = 0.001):
        super().__init__()
        self.learning_rate = learning_rate
        self.max_seq_len = max_seq_len
        self.batch_size = batch_size
        self.loss = nn.CrossEntropyLoss()

        self.pretrain_model  = AutoModel.from_pretrained('bert-base-uncased')
        self.pretrain_model.eval()
        for param in self.pretrain_model.parameters():
            param.requires_grad = False

        self.new_layers = nn.Sequential(
            nn.Linear(768, 512),
            nn.ReLU(),
            nn.Dropout(0.2),
            nn.Linear(512,4),
            nn.LogSoftmax(dim=1)
        )

    def prepare_data(self):
      tokenizer = BertTokenizerFast.from_pretrained('bert-base-uncased')

      tokens_train = tokenizer.batch_encode_plus(
          pub_health_train["main_text"].tolist(),
          max_length = self.max_seq_len,
          pad_to_max_length=True,
          truncation=True,
          return_token_type_ids=False
      )

      tokens_test = tokenizer.batch_encode_plus(
          pub_health_test["main_text"].tolist(),
          max_length = self.max_seq_len,
          pad_to_max_length=True,
          truncation=True,
          return_token_type_ids=False
      )

      '''
      Now we need to create features and extract the target variable from the dataset.
      '''
      self.train_seq = torch.tensor(tokens_train['input_ids'])
      self.train_mask = torch.tensor(tokens_train['attention_mask'])
      self.train_y = torch.tensor(pub_health_train["label"].tolist())

      self.test_seq = torch.tensor(tokens_test['input_ids'])
      self.test_mask = torch.tensor(tokens_test['attention_mask'])
      self.test_y = torch.tensor(pub_health_test["label"].tolist())

    def forward(self, encode_id, mask):
        _, output= self.pretrain_model(encode_id, attention_mask=mask,return_dict=False)
        output = self.new_layers(output)
        return output

    def train_dataloader(self):
      train_dataset = TensorDataset(self.train_seq, self.train_mask, self.train_y)
      self.train_dataloader_obj = DataLoader(train_dataset, batch_size=self.batch_size)
      return self.train_dataloader_obj

    def test_dataloader(self):
      test_dataset = TensorDataset(self.test_seq, self.test_mask, self.test_y)
      self.test_dataloader_obj = DataLoader(test_dataset, batch_size=self.batch_size)
      return self.test_dataloader_obj

    def training_step(self, batch, batch_idx):
      encode_id, mask, targets = batch
      outputs = self(encode_id, mask)
      preds = torch.argmax(outputs, dim=1)
      train_accuracy = accuracy(preds, targets)
      loss = self.loss(outputs, targets)
      self.log('train_accuracy', train_accuracy, prog_bar=True, on_step=False, on_epoch=True)
      self.log('train_loss', loss, on_step=False, on_epoch=True)
      return {"loss":loss, 'train_accuracy': train_accuracy}

    def test_step(self, batch, batch_idx):
      encode_id, mask, targets = batch
      outputs = self.forward(encode_id, mask)
      preds = torch.argmax(outputs, dim=1)
      test_accuracy = accuracy(preds, targets,task="multiclass")
      loss = self.loss(outputs, targets)
      return {"test_loss":loss, "test_accuracy":test_accuracy}

    def test_epoch_end(self, outputs):
      test_outs = []
      for test_out in outputs:
          out = test_out['test_accuracy']
          test_outs.append(out)
      total_test_accuracy = torch.stack(test_outs).mean()
      self.log('total_test_accuracy', total_test_accuracy, on_step=False, on_epoch=True)
      return total_test_accuracy

    def configure_optimizers(self):
      params = self.parameters()
      optimizer = optim.Adam(params=params, lr = self.learning_rate)
      return optimizer

### Error messages and logs

Error messages and logs here please

### Environment

<details>
  <summary>Current environment</summary>

#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(conda, pip, source):
#- Running environment of LightningApp (e.g. local, cloud):

</details>

### More info

same as above

@andysingal  The task parameter has been introduced in the newer versions which needs to be passed to the metrics. For example if it is a binary classification task, pass task="binary".
You can check an example in my colab notebook - link

Thanks @ishandutta0098 for answering this. Yes I confirm the task argument is new in torchmetrics and required. If you don't want to add the task, you can also explicitly use the binary_accuracy or multiclass_accuracy functions directly.
Let us know if that works for you @andysingal 😃

Thanks @ishandutta0098 for answering this. Yes I confirm the task argument is new in torchmetrics and required. If you don't want to add the task, you can also explicitly use the binary_accuracy or multiclass_accuracy functions directly.
Let us know if that works for you @andysingal 😃

Thank you @awaelchli @ishandutta0098 , still new to pytorch lightning and it is great learning experience for me. Here is link to my notebook(https://colab.research.google.com/drive/1a5Q_CgyvkI-Vva44snMvi4uaS3k03p2J?usp=sharing) and would love to know where i can improve in my PyTorch lightning journey

Glad to hear that @andysingal, thanks!
If you ever have more questions about Lightning, we also have
A discord chat: https://discord.com/invite/XncpTy7DSt
and a forum: https://lightning.ai/forums/

Thanks Adrian, I joined the discord channel. Again, thanks for all your
help.
On Wed, Aug 9, 2023 at 16:18 Adrian Wälchli @.***>
wrote:

Glad to hear that @andysingal https://github.com/andysingal, thanks!
If you ever have more questions about Lightning, we also have
A discord chat: https://discord.com/invite/XncpTy7DSt
and a forum: https://lightning.ai/forums/
—
Reply to this email directly, view it on GitHub
https://github.com/Lightning-AI/lightning/issues/18256#issuecomment-1671095106,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4LJNMZXD7ECFBRNAVAYNDXUNTGZANCNFSM6AAAAAA3IKMS6Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Why the test fail for macro?

Hi there, have you notice that there is a space at the bottom of the “Actual expanded source:” line? Is it the space you added in test code or the Xcode generated? If it is added by you please remove it.Sent from my iPhoneOn Oct 8, 2023, at 16:27, Md. Shamiul Islam @.***> wrote:
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Now I have added new line after variable declaration then write the init method. Now test passed.
Thanks


[WIP] fix/env loader script

this is an approach to solve #461
(it includes #459)
Solution is still not ideal and needs more discussion
@ipa-nhg @ipa-fmw

Not required because cob4-2-h1 PC will be 64 bits soon.


Tidy up backporting documentation

Give the backports / release management process and documentation a bit more love, specifically:

Split the release process into organization, backports, stable release, and feature release sections.
Add a new script contrib/backporting/start-backport which automates the git pull, git branching, check-stable run. Add documentation for this.
Restructure the backporting docs to delineate one-time setup, PR checks, branch preparation, PR preparation, final merge steps
Misc pep8 / style fixes

This change is

test-docs-please

Coverage increased (+0.01%) to 45.367% when pulling d13bef59c30e63fc2131b42c11f7a87e31ac912e on joestringer:submit/backport-docs into 94d62d66c925abd82a47bd3a6df46d5341529173 on cilium:master.

For v1.6 backport above, only commit 48c69b247ad6 backported.


Add segment replace api failure metrics.

Add following controller table metrics:
NUMBER_START_REPLACE_FAILURE
NUMBER_END_REPLACE_FAILURE
NUMBER_REVERT_REPLACE_FAILURE

Codecov Report

Merging #8784 (165e686) into master (73316a6) will decrease coverage by 5.69%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master    #8784      +/-   ##
============================================
- Coverage     68.51%   62.82%   -5.70%
+ Complexity     4601     4600       -1
============================================
  Files          1736     1690      -46
  Lines         91196    89224    -1972
  Branches      13633    13414     -219
============================================
- Hits          62480    56051    -6429
- Misses        24330    29125    +4795
+ Partials       4386     4048     -338

Flag
Coverage Δ

integration1
?

unittests1
66.15% <0.00%> (+<0.01%)
:arrow_up:

unittests2
14.15% <72.72%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...g/apache/pinot/common/metrics/ControllerMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...apache/pinot/controller/BaseControllerStarter.java
78.61% <100.00%> (-2.52%)
:arrow_down:

...ntroller/helix/core/PinotHelixResourceManager.java
63.19% <100.00%> (-2.62%)
:arrow_down:

...va/org/apache/pinot/core/routing/RoutingTable.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/common/config/NettyConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ache/pinot/server/access/AccessControlFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 351 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73316a6...165e686. Read the comment docs.


Support "static" getitem on Numba types in @njit code.

This adds support for the __getitem__ operation on Numba types within @njit compiled regions. i.e. it makes this sort of thing possible:
from numba import njit, types, typed

@njit
def foo():
    return typed.List.empty_list(types.float64[:, ::1])

foo()

The logic in the Type metaclass is relatively relaxed over what's acceptable in a __getitem__, this patch is necessarily more restrictive and the compilable __getitem__ is implemented only for types that are practical for this sort of use i.e. those in the numerical type system.
Tests are added and docs are updated to note that this is now supported.
Closes #8808
Closes #7683
Closes #5748

@gmarkall many thanks for the review. RE: "other minor stuff", I agree with and have implemented the suggestions in 3c5da76.


Randomly unable to log in

At random times, I am unable to log in until manually deleting the user's last session record from the database.
While I do not know what is causing this issue, I'll do my best to provide context so hopefully someone can advise.
This is the error I'm getting:

initializeSession.js
const express = require('express');
const session = require('express-session');
const { PrismaSessionStore } = require('@quixo3/prisma-session-store');
const prisma = require('../prisma/client');

const app = express();

module.exports = app.use(
  session({
    cookie: {
      maxAge: 1440 * 60 * 1000,
    },
    resave: false,
    saveUninitialized: false,
    secret: 'a very secretive secret',
    store: new PrismaSessionStore(prisma, {
        checkPeriod: 60 * 60 * 1000,
        dbRecordIdIsSessionId: false,
      },
    ),
  }),
);

Prisma schema:
model Session {
  id        String   @id
  sid       String   @unique
  data      String
  expiresAt DateTime @map("expires_at")

  @@map("sessions")
}

The data column content what is seemingly causing the issue.
This is the content in the data column when logging in for the first time:
{"cookie":{"originalMaxAge":86400000,"expires":"2022-01-06T21:15:15.744Z","httpOnly":true,"path":"/"},"passport":{"user":1}}
Once the issue occurs, the content in the data column looks like this:
{"cookie":{"originalMaxAge":86400000,"expires":"2022-01-06T21:17:41.768Z","httpOnly":true,"path":"/"},"passport":{},"OIDC: 2fa02a06-56bd-4978-9a7d-60869b77c0c3":{"content":[{"state":"JtIlEc4fsMmNXpSNlEN5k5zO1Uiy5Jy-","nonce":"X1EcNC00MOz3HqVZYsDliNoc-oR3vVyD","timeStamp":1641417461767}]}}
Once in this state, the data continues to add another context item on each subsequent login attempt until it exceeds the max size allowed by the database :
{"cookie":{"originalMaxAge":86400000,"expires":"2022-01-06T21:19:06.824Z","httpOnly":true,"path":"/"},"passport":{},"OIDC: 2fa02a06-56bd-4978-9a7d-60869b77c0c3":{"content":[{"state":"JtIlEc4fsMmNXpSNlEN5k5zO1Uiy5Jy-","nonce":"X1EcNC00MOz3HqVZYsDliNoc-oR3vVyD","timeStamp":1641417461767},{"state":"myq0iWOcczpLgk4paRDjHCrASzBjO1zS","nonce":"SBoY5gffW5bCW0Iz_V8DBOGkz4harFk_","timeStamp":1641417531785},{"state":"IOp48R8-k2ZkCRM7eD5cMRzQAatM6y_7","nonce":"4E8HbnFUR0jqEWAcXOSr2ruicnteU13o","timeStamp":1641417540355},{"state":"vkTKQcRQGQTtCVTY_nqI71VthTxihDS9","nonce":"0P7dfnRTYGxpv5ockqJO9oCv-OxCykxu","timeStamp":1641417542968},{"state":"paunuwJ2vSQhMbzlT0xt7Xv0a2ezBbrB","nonce":"TqFfoXI1g64_ouwkPDnlZaWxeazCSLHA","timeStamp":1641417544087},{"state":"YxUxCoSLzVTChdh3pEhD1QLCl_sFJyxS","nonce":"s4MXNgX_dkuIXfYUzjhLHnLP3KAcEuRU","timeStamp":1641417545192},{"state":"V-5ENeBUzDNp8V-raypK-qf8YtzmprWt","nonce":"l1Nac8uZYQgD1wMCtmR-B1LMpuqZn_8U","timeStamp":1641417546360}]}}
Any help will be appreciated!

Hi @YaakovR,
Strange; not sure what is going on.
A couple of random ideas:

Perhaps the key "OIDC: 2fa02a06-56bd-4978-9a7d-60869b77c0c3" is meant to be a key / value pair and formatting is getting garbled somewhere along the line?
Perhaps somewhere along the line a conversion from string to object (or back) isn't happening as expected? Maybe due to an implicit conversion, or some escaped character issue?
Is the behavior any different if the resave and saveUninitialized options are set to true?

Hope this suggests something to try; curious what's going on here...

This is the issue I was experiencing https://github.com/AzureAD/passport-azure-ad/issues/515.

@YaakovR great to hear you found a fix - and thanks for posting it.
(Bugs with intermittent behavior can be a lot harder to track down!)


⚠ ClamAV has degraded performance

In 5ddd06e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 86 ms

Resolved: ClamAV performance has improved in 41ab030.


Add a trait SignWith for signing HTTP requests

Motivation and Context
https://github.com/smithy-lang/smithy-rs/pull/3388#discussion_r1480722375
Description
This PR attempts to provide more ergonomic API for request signing. As documented in aws_sigv4, customers need to follow these steps after creating an Identity and a SigningParams:
// Convert the HTTP request into a signable request
let signable_request = SignableRequest::new(
    "GET",
    "https://some-endpoint.some-region.amazonaws.com",
    std::iter::empty(),
    SignableBody::Bytes(&[])
).expect("signable request");

let mut my_req = http::Request::new("...");
// Sign and then apply the signature to the request
let (signing_instructions, _signature) = sign(signable_request, &signing_params)?.into_parts();
signing_instructions.apply_to_request_http1x(&mut my_req);

This PR allows them to call SignWith::sign_with trait method with SigningPackage instead:
let signing_package = SigningPackage::builder()
    .signing_params(&signing_params)
    .build()
    .expect("required fields have been set");
my_req.sign_with(&signing_package);

Testing
Relied on existing tests in CI
Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Overall I think that a better API for signing is truly needed and this is directionally good. However, I think we need to work backwards from customer use cases. For example: We should work backwards from a customer who wants to sign an API Gateway request (and write the example!) and handle this that way.
If this code is needed urgently for S3 Express, we could consider putting it in inlineable to iterate on it.
I'm not totally sure about the trait API either. On the surface, it seems like it allows for an implementation on foreign types but I don't think it does in practice due to orphan trait rules. At the very least we should compare with other API designs.

As Russell commented, we need more iterations at a design level, and this PR will most likely be irrelevant when that design is settled. So closing this.
For S3 Express, there is a PR created to inline SigV4Signer::sign_http_request into S3ExpressSigner::sign_http_request.


Extension installation faied

I was installing the extension from the following link [Link to package]
(https://github.com/thehogfather/brackets-code-folding)
but it gave following error

where will i find dissabled extension folder or uninstall it

Hi @mandar262,
the code folding extension is now in the Brackets core, so the extension isn't needed anymore.
The disabled folder is under

Mac: ~/Library/Application Support/Brackets/extensions
Win XP: C:\Documents and Settings<username>\Application Data\Brackets\cef_data -- (aka %appdata%\Brackets)
Win Vista/7/8/10: C:\Users<username>\AppData\Roaming\Brackets-- (aka %appdata%\Brackets)
Linux: ~/.config/brackets/-- (aka $XDG_CONFIG_HOME/brackets/cef_data)

You can safely remove the extension.


Support passing allowableTags as an array

Requiring the user to specify their allowableTags as a string was unexpected/bizarre when I first encountered it, since the argument's plural name seems to imply that I should provide a list.
That is, I expected to be able to do striptags(myString, ["p", "li", "ul"]) rather than needing to do striptags(mystring, "

") which, again, is just bizarre.
Also, having to look up the format for the string was a bit annoying.
So I propose allowing the user to specify an array instead, while still supporting the current format. The code change would be really simple—I'd be happy to submit a PR!—and would make things a bit more convenient.

@ethanresnick thanks for using my npm library! I wrote this as a straight up port of PHP's strip_tags into JS, so the allowable_tags parameter is an artifact of that transformation.
I could see how this could be confusing to someone who has not used the PHP version of strip_tags though, so I think allowing an array parameter is not a bad idea.
I'll likely have time to change this myself soon, so a PR isn't needed - but thank you for the offer!


Reconcile apiservice

What this PR does / why we need it:
Reconcile APIService resources
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Reconcile APIService resources

/test pull-kubevirt-e2e-k8s-1.19-operator

There's an interesting failure involving the kubevirt CR's generation not remaining stable https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/5471/pull-kubevirt-e2e-k8s-1.19-operator/1384042886915428353
not sure if that's related to this pr or not.

@davidvossel yeah I think it's been flakey for a while now, there is a PR https://github.com/kubevirt/kubevirt/pull/5510 to add this test to quarantine. I think it's the issue with the reconciliation happening to quickly which I'm hoping/thinking https://github.com/kubevirt/kubevirt/pull/5470 will fix. From what I can tell from the logs when this test fails this should be a fix.


change the forkme to svg

change the forkme to svg

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)

Awesome, thanks!


Fix url protocol detection for non-http urls

Fixed url protocol detection for non-http urls.
Now file://path/to/file, ftp://... and similar is correct fo Puppeteer, Nightmare and Protractor helpers.
Before https and https have worked only.

Fixed test for page slider in Puppeteer_test.js
It could not load w3c site and test fails last 2 days.
Now this test use local sandbox html.

Thanks!
Not sure who will need that but ok :)

For serverless testing of libraries on local files, for example


Example of ChangeLexerState usage

Hello,
I'm creating lexer and I need to highlight block comments (/* */ in C#). If I'm correct, that's where ChangeLexerState API comes handy. But are there any specific rules for using that?

Change lexer state is actually much more simplistic than that. According to the Scintilla documentation, ChangeLexerState is used to:

Indicate that the internal state of a lexer has changed over a range and therefore there may be a need to redraw.

This excerpt about custom lexers also adds a little insight:

Scintilla tries to minimize the consequences of modifying text to only relex and redraw the line of the change where possible. Lexer objects contain their own private extra state which can affect later lines. For example, if the C++ lexer is greying out inactive code segments then changing the statement #define BEOS 0 to #define BEOS 1 may require restyling and redisplaying later parts of the document. The lexer can call ChangeLexerState to signal to the document that it should relex and display more.

That can be somewhat vague, but my understanding is that it is essentially the same thing as Colorize but where Colorize is called by the application to restyle a portion of the document, ChangeLexerState is called by the lexer to do the same.
That being said, is there a reason you are creating a lexer for C# when Scintilla already has one built in?

I want to highlight $some_variable$ C# code. The regex to match it would be:\$[a-zA-Z_][a-zA-Z0-9_]*\$

Going back to the original question, I don't think you'll need to utilize ChangeLexerState for what you're doing. To lex a multi-line, arbitrarily long token such as a block comment or multi-line string literal, you will indeed likely want to change some internal state in your lexer, but I don't see that being related to ChangeLexerState which is more or less a way of letting Scintilla know that some external entity has made a change to the meaning of a token in the document and it requires restyling. The example in the Scintilla documentation is perfect. Say for example, your C# code has:
#if DEBUG
// ...
#endif

You want to style that block differently depending on whether DEBUG is defined or not. Say you also had a project properties window in your application where users could define compiler flags and the user has changed DEBUG=0 to DEBUG=1. You would then utilize ChangeLexerState to let Scintilla know that it may need to restyle a range of text because the meaning of the tokens may have changed.
Should you write your own lexer? Perhaps. That would give you ultimate control. One of our users wanted to do something similar and didn't want to write a new lexer and was able to get what he needed working using the UpdateUI event after the lexer had made its pass. Read over issue #165 and check the code posted by @JohnyMac at the end and see if this would help save you some time.

Hello,
My problem was just wanting to have more wordsets, nothing else, I tried to write my own lexer but in fact, The problem was not being able to colorize multiline stuff like comments.. I spent like 20 days trying continuously but never got it right, Until I just gave up and found this better alternative (for my case) and did it.

If you don't know how to make a lexer and all that (Like me), I'd recommend that you just use the Cpp Lexer and do your other small additions in the UpdateUI using some regex searches.

Did something similar to that, works like charm. Thanks for help!


Show only functions in 'Go To Symbol In File'

Are there any plans to provide filtering options for the Go To Symbol In File panel? For me personally, I would like to hide all variables/constants etc from the list and just show functions, as this is what I'm usually after in this context.
Looking at the file I'm currently working on, this would cut down the number of symbols displayed from 1536, to 190, which would help me hugely.
Keep up the good work, I think this is easily the best PHP parser extension for VS Code.

It's a good idea, perhaps one that is best implemented in vscode itself. There's a ticket open in the vscode repo that requests something similar https://github.com/Microsoft/vscode/issues/5605. For now you can type : and group the symbols by kind, though that still leaves all the symbols visible.

Ahh fair point. Thanks for the : tip, I didn't know about that one and as it turns out it displays methods above variables, so that's a good workaround.


Diagrams for policy development guide.

Coverage decreased (-0.2%) to 76.563% when pulling 32e2a83dd55c8bbff41bf429dbb8a9b9834298a3 on milanlenco:master into aa81acfcad4a79242912c78be8a3e599cb82935b on contiv:master.


Export typings

At the moment none of the types in the index.d.ts are exported. Thus nobody can use them. They should be exported

Feel free to create a Pull Request to fix this. We would really appreciate it.

Hey @janpio
I didn't provide a PR because it seems that nobody will merge it anyway based on the open PR's of this repository :/

The export is not really needed, you can use the plugin using triple slash directive like this
/// <reference types="cordova-plugin-file" />

@jcesarmobile I think that is not a viable solution since (as far as I know) developers using a typescript definition shouldn't need to add a reference in their TS files. They should be able to import them normally.
The reference is specifically for publishing dependencies in a own @types/ library.
At least this is the best practice I've come around...

I’m not a typescript expert, but you said nobody can use the types bescause they are not exported. I told you a way you can use them. As I said, I’m no expert and I don’t know if it’s a good practice or not, but it’s a viable solution.
If you don’t like to use the triple slash directive, as janpio said, you can send a PR with the exports.

@jcesarmobile added PR https://github.com/apache/cordova-plugin-file/pull/285

Thanks for your PR, but IHMO this is not needed. The types property is defined in the package.json and pointing to the correct d.ts file. You should only need to specify this plugin under your types array, see: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types
Could you elaborate why these typings are otherwise not usable or share your tsconfig.json file?


[fix #289] Check if a file contains a file:// link

Implemented a fix for issue #289.
This fix includes some extra code to validate info messages in tests.
It also abstracts some code from EntitySearch and implements a new FileLinkSearch.
The solution works but I'm open to discussion.

Thanks for the fix @kalaspuffar! 👍
One comment however: we should ideally keep changes to the com.adobe.epubcheck.ctc minimal, as in the longer term this more recent package should be fully reviewed and possibly integrated at other place in EpubCheck (as hinted in the work plan in the wiki).
There's no way you could have known this, so it's absolutely fine! but for future changes it's always better to try and see if it can be done in other packages first 😄


Add background-geopoint question type which exposes xforms-value-changed event with odk:setgeopoint action

Closes https://github.com/XLSForm/pyxform/issues/716
Why is this the best possible solution? Were any other approaches considered?
This solution introduces a new background-geopoint question type that triggers the odk:setgeopoint action when the xforms-value-changed event occurs. The design and implementation were based on discussions from this forum post. The solution followed the proposal and was straightforward to implement based on the details in the issue.
What are the regression risks?
Because this introduces a new question type and modifies how setvalue triggers are handled, there is a risk of breaking existing workflows that rely on the current setvalue behavior. I refactored some functions to handle both setvalue and the new setgeopoint triggers, however, this needs to be tested thoroughly to ensure that the changes don’t break any of the existing setvalue functionality.
Does this change require updates to documentation?
Yes: https://github.com/XLSForm/xlsform.github.io/issues/277
Before submitting this PR, please make sure you have:

[X] included test cases for core behavior and edge cases in tests
[X] run python -m unittest and verified all tests pass
[X] run ruff format pyxform tests and ruff check pyxform tests to lint code
[X] verified that any code or assets from external sources are properly credited in comments

Thanks for this PR - looks like it will do what was agreed earlier. My comments are mainly to polish it: increase test coverage, optimise error messages, try to avoid performance regressions / tech debt.

Thanks and welcome, @RuthShryock!

@lindsay-stevens I've only taken a quick look and it's looking good. Could you please do a final review, especially looking at the perf concerns you had brought up?
Maybe if there are smaller things pending we can file an follow-on issue as we sometimes do. Thanks!

@lognaturel I added a commit to address the remaining review feedback. Could you please take a look and merge/rebase if it looks good to you? Thanks

Thanks, everyone!


Delete .github/ISSUE_TEMPLATE directory

:x: Build bitcointrade-sdk-dotnet 1.0.372 failed (commit https://github.com/guibranco/bitcointrade-sdk-dotnet/commit/0042e8bf13 by @guibranco)

@gstraccini review

:white_check_mark: Build bitcointrade-sdk-dotnet 1.0.377 completed (commit https://github.com/guibranco/bitcointrade-sdk-dotnet/commit/f8eda96bdc by @guibranco)


[Bug]: Update the dependency on the same version of the chart breaking existing installation

Is there an existing issue for this?

[X] I have searched the existing issues

Description
This commit https://github.com/appsmithorg/appsmith/commit/c93ed4f54cad1978e383cdff5fd192238d0fd308 is breaking our existing appsmith installation, our MongoDB crashed with the error below :
 "ctx":"initandlisten","msg":"Wrong mongod version","attr":{"error":"UPGRADE PROBLEM: Found an invalid featureCompatibilityVersion document (ERROR: Location4926900:
Invalid featureCompatibilityVersion document in admin.system.version: { _id: \"featureCompatibilityVersion\", version: \"4.4\" }.
See https://docs.mongodb.com/master/release-notes/5.0-compatibility/#feature-compatibility. :: caused by :: Invalid feature compatibility version value, expected '5.0' or '5.3' or '6.0.
See https://docs.mongodb.com/master/release-notes/5.0-compatibility/#feature-compatibility.).
If the current featureCompatibilityVersion is below 5.0, see the documentation on upgrading at https://docs.mongodb.com/master/release-notes/5.0/#upgrade-procedures."}}

Steps To Reproduce

Deploy the appsmith without this commit https://github.com/appsmithorg/appsmith/commit/c93ed4f54cad1978e383cdff5fd192238d0fd308
Update the installation and include this commit https://github.com/appsmithorg/appsmith/commit/c93ed4f54cad1978e383cdff5fd192238d0fd308
Rollout restart the MongoDB cluster deployment

Public Sample App
No response
Issue video log
No response
Version
Helm Chart 2.0.0

@WillyRL this is a duplicate issue. Take a look - https://github.com/appsmithorg/appsmith/issues/19542#issuecomment-1401658198

@WillyRL this is a duplicate issue. Take a look - #19542 (comment)

I think it's quite different @pranavkanade, my concern is regarding the helm update chart strategy that updates the same version of the helm chart, it should publish under another version especially if the changes have breaking changes with the previous version.

Hey @WillyRL, sorry just coming to this. Were you unblocked? This was a miss from our side. We now have a workflow that does the Helm chart deployment, and it checks if a version of Helm chart is already published, and if yes, it'll refuse to publish and fail. So this shouldn't happen again.
Sorry for the inconvenience this has caused. I'm closing this, but if you're still blocked, let me know and I'll reopen. Thank you! 🙏


Added TLS for mail delivery

Explicitly switch on TLS for mail delivery when possible with "smtpd_tls_security_level = may".

Thank you very much - good Idea!


Luke NER Fine Tuning on Custom Entities.

Hi, I am trying to fine tune luke base model and prepared conll like dataset with two columns (one for tokens and other for labels). The training runs smoothly but asserts no entity label when trying to make predictions.
Can I really know what changes in the code are supposed to be making luke ner solution useful for custom ner with different number of classes.

That's how my dataset looks like;

I have made one change in the code according to my entity numbers:

So can I get what I have to do additionally? Is my dataset structure CORRECT?

Hi @ahmadaii,
If I correctly remember, the assertion (assert not entity_labels) aims to confirm that all gold entity spans in the dataset are detected after preprocessing (i.e., sentence and subword tokenization). if all gold entity spans are detected, entity_labels should be empty.
Also, there is another implementation of our NER model based on AllenNLP, which may be easier to work with.

Alright. Is there any separate script for converting luke ner model to transformers or I have to use same script provided for converting re model??

Actually, LUKE was added to the Transformers library after the experiments conducted in our paper. Therefore, the examples available in this repository do not support the Transformers library.

@ikuyamada I am referring to this script that was provided to convert luke re model to be used in transformers. Now I have fine tuned luke large model for NER task on my custom data. Is there any similar script for ner?

@elonmusk-01 Check out the this script, although you need to modify few things to make it work

@binhna Were you able to run that script on custom dataset?
I tried but I am getting this error:
TypeError: forward() got an unexpected keyword argument 'ner_tags'
Any idea on how to fix it?

@NiteshMethani I managed to get it running, but not this script though. You could try this one, but you still need to edit some code to get it running.
The result in my language is quite bad though 😕

@NiteshMethani I managed to get it running, but not this script though. You could try this one, but you still need to edit some code to get it running.
The result in my language is quite bad though 😕

@binhna Thanks for sharing the script. I too was able to run it but with no luck. My performance even on conll2003 is:
{'precision': 0.8916275430359938, 'recall': 0.4036486007793128, 'f1': 0.5557181175323092, 'accuracy': 0.8966561566544972}
These were my hyperparameters for training:
python run_luke_ner_no_trainer.py
--model_name_or_path studio-ousia/luke-base
--dataset_name conll2003
--task_name $TASK_NAME
--max_length 128
--per_device_train_batch_size 32
--learning_rate 2e-5
--num_train_epochs 3
--output_dir /tmp/$TASK_NAME/
I wonder what's the reason for such poor F1 score on conll.
Would appreciate any suggestions @Ryou0634 @binhna @ikuyamada


Add ability to save to file in code generation

[ ] Save to a file
[ ] Remember location so it can easily be overwritten
[ ] Add real-time sync functionality so you can keep testing it (not sure if actually useful)

I think it would be handy to be able to automatically save a workspace to a external file that can be kept in source control. The file could be watched for changes that get reflected in insomnia. This was I don't have to export/import regularly.


Wildcard support for "mirv_streams edit"

When editing streams, it could be handy to have a way to edit multiple streams at once. For instance, something along the lines of mirv_streams edit \* stickerAction noDraw to hide stickers on all streams would be very convenient. Ideally this would issue a warning to the console if it matches a stream which does not understand a property like stickerAction, e.g., depth streams (I think).

Good suggestion, thanks for writing it down.
What we need to think about is how to handle alphaMatteEntities streams when mixed with normal streams, because those have their own logic and have sub-streams instead of the properties on the main stream and for it to make sense it would have to adjust both sub-streams at the same time with "some" logic applied, as you see things can get tricky very fast for those.
If it is okay, I'd implement it, without caring too much about incompatible streams, meaning if you have baseFx derived streams and alphaMatteEntity streams, then it will just spew some error messages, if you try to adjust them at the same time (because the sub-commands don't match).
(Btw.: Depth streams do have stickerAction since they are derived from "baseFx" streams. I.e. "normal" streams lack most options and for the combined alphaMatteEntity streams they are in the sub-streams as options.)


Provide support for ember data

Maybe something like {{sf-table store=myEmberDataThing}}

[x] Ember data block support (completed #28 )
[ ] Ember data inline support

hey! just tried this out and it looks like there isn't a way to only make tables with a subset of DS.attr properties on a model? Maybe I am using it wrong?
E.g. in your demo code, if model has more properties than the ones specified in sf-heading, they are also included in the table. I can map over my data, but at that point, I don't need to use the Ember data feature.
{{#sf-table as |group|}}

      {{sf-headings
        headings=(array
        (hash key="title" display="Title")
        (hash key="score" display="Score")
        (hash key="publisher" display="Publisher")
        (hash key="short_description" display="Description")
        (hash key="platforms" display="Platforms")
        (hash key="thumb" display="Cover")
        ) group=group}}

{{sf-filter placeholder="Search" withClearField=true group=group}}

    {{sf-em-data store=model group=group}}

{{/sf-table}}

@mehulkar Thanks for pointing this out. I did discover this over the weekend. I'm working out a solution whereas sf-headings will define the subset to display. Also, we I want to make sure that the private properties can also be defined in sf-headings for filtering only (just like the pojo implementation). Would you mind opening an issue including your description and assign to me?

filed #29! thanks :)


[stable/prometheus-couchdb-exporter] Changed initialDelaySeconds to be a configuration of livenessProbe/readinessProbe

According to this doc: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/ initialDelaySeconds is a configuration of livenessProbe/readinessProbe and not httpGet
The helm charts returns the following error:
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(Deployment.spec.template.spec.containers[0].livenessProbe.httpGet): unknown field "initialDelaySeconds" in io.k8s.api.core.v1.HTTPGetAction, ValidationError(Deployment.spec.template.spec.containers[0].readinessProbe.httpGet): unknown field "initialDelaySeconds" in io.k8s.api.core.v1.HTTPGetAction]
For K8s version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:56:40Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.9-gke.24", GitCommit:"39e41a8d6b7221b901a95d3af358dea6994b4a40", GitTreeState:"clean", BuildDate:"2020-02-29T01:24:35Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}

And helm version:
version.BuildInfo{Version:"v3.2.0", GitCommit:"e11b7ce3b12db2941e90399e874513fbd24bcb71", GitTreeState:"clean", GoVersion:"go1.13.10"}

/assign @maorfr

@maorfr Please merge this

Not stale...still waiting for the fix!

/hold
Let’s hold PRs to stable prometheus charts for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great!

🚧 This chart is now deprecated.
Further development has moved to prometheus-community/helm-charts.
If applicable, please re-open this PR there. Thanks!


Error thrown when .env.example contains a variable not set in .env

When building your fresh website if you have any variable defined in .env.example and it's not defined in .env (ie it's an optional env) the build fails with the following error:

It seems like this is a config option in dotenv so it should be a simple fix (maybe make it an opt in/out inside of the fresh config in case people like the errors?)

This is for Deno's standard library, and is not Fresh specific.
https://github.com/denoland/deno_std
Docs for how to use it:
https://deno.land/std@0.212.0/dotenv/mod.ts?s=load

The issue here is correct, I asked them to open one here. The default Fresh template could configure dotenv in a way that doesn't throw.


Come up with strategy for upgrading Is Part Of field values

One of the main incompatibilities between Metadata 1.0 and Aardvark is the Is Part Of field.  In the 1.0, this was a string value. In Aardvark, this is an ID that is read by the GeoBlacklight application to link records together.
To upgrade, users would need to create new collection records for each unique value and replace the strings with the new IDs.
Pros:

collections can be fully described with their own metadata record
provides more stability by using nonliteral URIs instead of strings (if a name changed, only the collection record would need to be updated)

Cons:

The way GBL is set up, a user would have to make more "clicks" to get to other items in the same collection.
Since it is not a direct crosswalk, there is labor involved in creating new collection records and updating existing ones.

The metadata converter at https://kgjenkins.github.io/gbl2aardvark/ will now automatically create new "Collections" records, using information from all the existing child records.  Some of the fields (subject, keyword, etc.) aggregate all the unique values found in the child records, and the bbox (dcat_bbox, locn_geometry) is automatically expanded to include all the child record bboxes.
I've documented the process a bit in the README
I think this could be a viable approach, although one would certainly want to review the new collection records -- the descriptions will certainly need editing to better reflect the whole collection.  And you may not really want every placename from all the child records to be listed in the collection record.
Date values may require clean-up -- the script keeps every unique value (which works well for single years in gbl_indexYear_im) but dct_temporal_sm may have things like this:
   "dct_temporal_sm": [
      "1998-2013",
      "1998-2014",
      "1998-2015",
      "1998-2016",
      "1999-2013",
      "1999-2014", etc.

The collection records may also reveal spelling or capitalization inconsistencies in the child records.  For example:
   "dct_subject_sm": [
      "Land Cover",
      "Land Use",
      "Land cover",
      "Land use",
      "Tree canopy", etc.

Of course, it could be nice to retain a "simple" collection field that just contains a string (similar to subject or keyword), but also have the option of the new relations-based dct_isPartOf_sm field.

In this case, dct_isPartOf_sm probably maps better to pcdm_memberOf_sm.
From the OGM documentation:
Is Part Of: To link items that are a subset of another item (e.g. a page in a book)
Member Of: To link items that are part of a collection

Do some research on a new field for this that would be a plain text value.


Fix pip index URL.

ROOT_DIR wasn't set so the URL was empty.
For CI there is no difference because the official one is already fast enough. But docker build would be slow if we run it elsewhere.

Why?

Asking because it requires extra repo.
Also I'm not gonna refresh the docker after this PR because it has no runtime benefit.

Why?

Then we may be able to do some GH-related issue in Docker container. (Creating releases, etc.)
Also, do you think we should upgrade to Bazel 6.1? It stops downloading the JDK stuff that we do not want. See here.

I'm OK with that


Override org.jboss.xnio deps to fix deployment on WildFly 8

Needed after the upgrade to IP BOM 6.0.0.CR31

+1 as this fixed the issue

https://github.com/uberfire/uberfire/commit/446a732d2c31eda200a2d255153120c8e0bc2448


MAP type is not comparable

MapType is not comparable even though there is an = and != operator defined

@cberner @martint do we have a description like:
https://github.com/facebook/presto/issues/1816

Maps are almost comparable (they implement the = and != operator), but the isComparable method in MapType is currently implemented incorrectly. It should do something like ArrayType's isComparable, and return true if the value type is comparable.

@martint thank you, get it. Let me take a try.


Support for include

I saw that moxy is based on scriban (https://github.com/scriban/scriban)
I tried to use the include function to be able to factorize stuff between my templates.
Unfortunately this isnt working:
2>Grp1.mixin(8,4): Error MOXY0003 : /home/kevin/dev/Spice86/src/Spice86.Core/Emulator/CPU/CfgCpu/ParsedInstruction/Instructions/Mixins/Grp1.mixin(1,4) : error : Unable to include <Test.mixin>. No TemplateLoader registered in TemplateContext.TemplateLoader

I'm not sure how it would be achieved unless there is a hook I can use for resolving.

Maybe that's not what you meant but it looks like you need to hook an TemplateLoader that provides the include text
https://github.com/scriban/scriban/blob/38df14946721238d2f4badc7c0b6e8a1c594e23c/doc/runtime.md#include-and-itemplateloader
I can see from my limited understanding of your code that you create a TemplateContext here https://github.com/mrpmorris/Morris.Moxy/blob/c75846112f83b2d8b5335fb25d9163d9153984ba/Source/Lib/Morris.Moxy/SourceGenerators/ClassSourceGenerator.cs#L125
Maybe a custom loader that would try to find the include file from the current directory of the compiledTemplate object would work for most cases?


[Bug] Syntax error using logical operator OR

Bug Type (问题类型)
other exception / error (其他异常报错)
Before submit

[X] 我已经确认现有的 Issues 与 FAQ 中没有相同 / 重复问题 (I have confirmed and searched that there are no similar problems in the historical issue and documents)

Environment (环境信息)

HugeGraph Version: 0.12.0
Storage Backend: inmemory
Mixed Index Backend: none
Link to discussed bug: none
Operating system: macOS 13.2.1
API/Driver: Java

Expected & Actual behavior (期望与实际表现)
We want to use logical operator OR to merge two individual queries, but it trigger a syntax exception which I think the query it's actually correct. And I keep triggering this kind of problem.
Here is one of our examples that triggered the bug.

g.V().bothE('el0').bothV() is a correct query.
g.V().in('el0') is a correct query.
g.V().or(bothE('el0').bothV(),in('el0')) is supposed to be a correct query but trigger a crash.

Expected behavior:
No exception should be expected to throw.

Actual behavior:
A exception is thrown. And I'm not really sure whether this problem should happen so I report this. And I think if I replace the in into inE here, the bug may not be triggered, but I read the Gremlin manual carefully, this query syntax is correct and should be supported.

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
Script17.groovy: 1: unexpected token: in @ line 1, column 31.
   g.V().or(bothE('el0').bothV(),in('el0'))
                                 ^

1 error

Vertex/Edge example (问题点 / 边数据举例)
No response
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
No response

use __.in() instead due to in is a keyword in groovy


Update the base image to ubuntu:22.04

The base ubuntu image needs to be updated to version 22.04 for security fixes.

https://github.com/pravega/gstreamer-pravega/pull/154


Fixing build on php 7.2 env

Following travis error build on php nightly at #632 . When it get green, we can remove from allow_failures

On php nightly env, now get error:
1) CodeIgniter\Cache\Handlers\RedisHandlerTest::testGet

Failed asserting that null is identical to 'value'.

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/Cache/Handlers/RedisHandlerTest.php:91

2) CodeIgniter\Cache\Handlers\RedisHandlerTest::testGetMetaData

Failed asserting that Array &0 (

    'expire' =><PHONE_NUMBER>

    'mtime' =><PHONE_NUMBER>

    'data' => null

) is false.

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/Cache/Handlers/RedisHandlerTest.php:140

We may need to skip tests for it.

modified RedisHandler::getMetaData() with false and null comparison for RedisHandlerTest::testGetMetaData error.

Now got different error:
1) CodeIgniter\Cache\Handlers\RedisHandlerTest::testGet

Failed asserting that null is identical to 'value'.

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/Cache/Handlers/RedisHandlerTest.php:91

2) CodeIgniter\Cache\Handlers\RedisHandlerTest::testGetMetaData

Failed asserting that null is identical to 'value'.

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/Cache/Handlers/RedisHandlerTest.php:145

It seems something different behaviour in php nightly env for $this->redis->hMSet() process.

still got error in RedisHandlerTest::testGet(), probably add version_compare() in RedisHandler::isSupported() ?
	public function isSupported(): bool
	{
		return extension_loaded('redis') && PHP_VERSION <= '7.2.0';
	}

I've just applied php 7.2 check in RedisHandler::isSupported(), and now got error in routing part:
1) CodeIgniter\CodeIgniterTest::testRunDefaultRoute

Failed asserting that '' contains "
Welcome to CodeIgniter
".

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/CodeIgniterTest.php:43

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

2) CodeIgniter\CodeIgniterTest::testRunEmptyDefaultRoute

Failed asserting that '' contains "
Welcome to CodeIgniter
".

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/CodeIgniterTest.php:59

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

3) CodeIgniter\CodeIgniterTest::testRun404Override

Failed asserting that '' contains "
Welcome to CodeIgniter
".

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/CodeIgniterTest.php:135

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

4) CodeIgniter\CodeIgniterTest::testRoutesIsEmpty

Failed asserting that '' contains "
Welcome to CodeIgniter
".

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/CodeIgniterTest.php:247

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

5) CommomFunctionsTest::testRedirectReturnsNamedRouteFirst

Failed asserting that null matches expected '/home/base'.

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/CommonFunctionsTest.php:82

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

6) CommomFunctionsTest::testRedirectReverseRouting

Failed asserting that null matches expected '/home/base'.

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/CommonFunctionsTest.php:99

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

7) CommomFunctionsTest::testRedirectNormalRouting

Failed asserting that null matches expected '/home/base'.

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/CommonFunctionsTest.php:114

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

8) CodeIgniter\Router\RouteCollectionTest::testAddRecognizesCustomNamespaces

Failed asserting that two arrays are equal.

--- Expected

+++ Actual

@@ @@

 Array (

-    'home' => '\CodeIgniter\controller'

+    'home' => '\controller'

 )

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/Router/RouteCollectionTest.php:210

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

9) CodeIgniter\Router\RouteCollectionTest::testSetDefaultControllerStoresIt

Failed asserting that two strings are equal.

--- Expected

+++ Actual

@@ @@

-'godzilla'

+''

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/Router/RouteCollectionTest.php:220

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

10) CodeIgniter\Router\RouteCollectionTest::testSetDefaultMethodStoresIt

Failed asserting that two strings are equal.

--- Expected

+++ Actual

@@ @@

-'biggerBox'

+''

/home/travis/build/bcit-ci/CodeIgniter4/tests/system/Router/RouteCollectionTest.php:230

/home/travis/build/bcit-ci/CodeIgniter4/vendor/phpunit/phpunit/phpunit:53

--

@lonnieezell I can only patch  tests/_support/Database/MockConnection::query() signature right now , probably needs different PR for other errors due to other errors complexities.

Ok, well, it's a start, thanks! Merging.


[Mitaka] MaaS: Remove excluded checks from tasks

Checks are now excluded using the disabled attribute in the YAML
file for the check (see #1691). The original conditionals in each
MaaS task is no longer needed.
Connects rcbops/u-suk-dev#1224
(cherry picked from commit d89652448e134d0f627829180f57b5106cf27273)

recheck_ceph
recheck_upgrade


w3wp iiswsock.dll crash Exception code: 0xc0000005

Describe the bug
Faulting application name: w3wp.exe, version: 10.0.14393.0, time stamp: 0x57899b8a
Faulting module name: iiswsock.dll, version: 10.0.14393.0, time stamp: 0x57899be0
Exception code: 0xc0000005
Fault offset: 0x0000000000004402
Faulting process id: 0x13ac0
Faulting application start time: 0x01d4ce964fa2faf3
Faulting application path: c:\windows\system32\inetsrv\w3wp.exe
Faulting module path: C:\Windows\System32\inetsrv\iiswsock.dll
Report Id: e138ade8-f1aa-4435-bb7c-0de680099032
Faulting package full name:
Faulting package-relative application ID:

Fault bucket , type 0
Event Name: APPCRASH
Response: Not available
Cab Id: 0

Problem signature:
P1: w3wp.exe
P2: 10.0.14393.0
P3: 57899b8a
P4: iiswsock.dll
P5: 10.0.14393.0
P6: 57899be0
P7: c0000005
P8:<PHONE_NUMBER>004402
P9:
P10:

Attached files:

These files may be available here:
C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_w3wp.exe_125078fdc0c665693f85e782acb4dfca5593f2e_ed19be39_3b457a28

Analysis symbol:
Rechecking for solution: 0
Report Id: e138ade8-f1aa-4435-bb7c-0de680099032
Report Status: 4
Hashed bucket:

To Reproduce
Occurs randomly in production environment every other day or so.
Additional context
Host (useful for support):
  Version: 2.2.2
  Commit:  a4fd7b2c84

.NET Core SDKs installed:
  No SDKs were found.

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 1.0.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

Can you capture a crash dump and send it to me on the email listed on my github profile? Thanks!

@sepehr1014 we are going to close this for now. Feel free to still email me the dump if you are able to.


Question: spdm-emu build failing

Hi Team,
I am facing this issue while building spdm-emu on windows. Can someone please point out the mistake I m doing here ?
Issue 1:
CMake Error at CMakeLists.txt:613 (ADD_SUBDIRECTORY):
ADD_SUBDIRECTORY given source
"/spdm-emu/libspdm/library/spdm_transport_pcidoe_lib" which is
not an existing directory.
Issue 2:
CMake Deprecation Warning at spdm_emu/spdm_responder_emu/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

sorry got the fix to this issue
for future if someone is facing this please do checked out submodule recursively
closing this issue


Create a relative symlink, not absolute

Before:
$ php artisan storage:link
The [public/storage] directory has been linked.

$ ll public/storage
public/storage -> /Users/philiptang/Documents/Code/github.com/philiptang/api.machine/storage/app/public

After:
$ php artisan storage:link
The [public/storage] directory has been linked.

$ ll public/storage
public/storage -> ../storage/app/public

I can't see the benefit of having a relative symlink instead of an absolute one

@PhilipTang Application has a useStoragePath method which you can use to overwrite the base storage path.


Optimise CI workflow and reorganise the content accordingly

The CI workflow in this repo takes ~10h to run. On the one hand, that's because running some of the tasks on the largest architectures (xc7200t) takes 5h. On the other hand, job install is executed after all the previous tasks are finished, and it takes 5h as well. This is partially due to some tasks being executed twice (i.e. job install is bootstraped instead of reusing artifacts from previous jobs). We should store some of the packages (arch.xml, rr graph, etc.) as artifacts (apart from pushing them to GCP), so we can reuse them in job install.
Moreover, the structure of the repo is misleading for newcomers. There are multiple locations for tests (tests, testarch, xc/xc7/tests, quicklogic/pp3/tests) and subdirs for architectures are located in the root along with subdirs for tools. Having subdirs archs and tools, along with reorganising the tests, would be helpful to reduce the maintenance burden and make contributions easier. See https://github.com/SymbiFlow/f4pga-arch-defs/pull/2647.

It is important from a visibility to have the support architecture directories at the top level.


application/json;charset=utf-8 doesn't match expected text content type regex

Bug Report
Description
When an HTTP request comes back with a Content-Type header value of "application/json;charset=utf-8", logging the response Body#representationOfBytes fails to match with this content type because of the missing space.
https://www.rfc-editor.org/rfc/rfc2045#section-5.1 : The original spec outlining Content-Type header formatting doesn't explicitly declare whitespaces to be present before a parameter.
https://tools.ietf.org/html/rfc7231#section-<IP_ADDRESS> : Updates to the spec do explicitly declare an optional whitespace be present before a parameter.
To Reproduce
Steps to reproduce the behavior:

Write a client with:
FuelManager.instance.addResponseInterceptor { LogResponseInterceptor.invoke(it) }
Make a request to a server that responds with application/json;charset=utf-8 as the content type and a proper JSON body.
Observe when logging the Body:... the actual body is not represented, instead it say (for example): Body: (1024 bytes of application/json;charset=utf-8)

I've copied the regex to a regex tester tool like https://regex101.com/ and tried to match with "application/json;charset=utf-8" but failed. Of course, testing with "application/json; charset=utf-8" passed. A quick modification to the regex allows for both: ^(?:text/.*|application/(?:csv|javascript|json|typescript|xml|x-yaml|x-www-form-urlencoded|vnd\.coffeescript)|.*\+(?:xml|json))(;(?: |)charset=.+)*$
Additionally, application/json media types are generally assumed to be encoded in utf-8 and often times, servers respond with Content-Type simply application/json.
Expected behavior
Logging the response Body should properly log the body opposed to "($lengthLabel of $actualContentType)"
Environment
Development Machine

Fuel version: 2.1.0
Kotlin version: 1.3.41

Additional Context
I'm writing an Android client which makes REST requests to a Spring Boot server. The MediaType enum: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/MediaType.html#APPLICATION_JSON_UTF8 does not include a space.

Can you open a PR to change the regex? It is correct that the space is not required per the spec.


Concatenate valid cuts, reduce chance of OOM

This prevents a problem where the training would work OK but there would be OOM while getting the valid prob (even though the validation should use less memory since it doesn't have to do backprop).
Caution: the valid objf values are slightly worse (by 0.01 or 0.02) so you shouldn't compare them before/after this change.

Another option is to set a different (lower) max duration for the dev set (and maybe bucketing to make the computation less wasteful), which would keep the same loss values.

I think I'd rather keep the train and valid process similar.
Will merge this; I'm assuming Fangjun has no objection..

That's interesting.
I'm skeptical that this would make a difference to the perormance though.
On Thu, May 20, 2021 at 11:07 PM Piotr Żelasko @.***>
wrote:

I was doing sth and remembered that you mentioned the valid loss is larger
-- it's interesting to see the model "hallucinates" posteriors for the
padding regions. Maybe it makes sense to add a loss component for the
non-supervised regions to penalize this.
[image: image]
https://user-images.githubusercontent.com/15930688/119003026-643fd700-b95b-11eb-81c5-1cfd81253437.png
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/k2-fsa/snowfall/pull/197#issuecomment-845204027, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZFLO7L32E6CGIZX2ZGA23TOUQR5ANCNFSM446RKS6A
.


Only starports are loaded from inara

Describe the bug
Currently only stations in orbit without fleet carriers are loaded when requesting data for a specific commodity from inara.
Expected behavior
The tool should load also carriers and surface-stations from inara when searching for commodity markets
Screenshots

Additional context
This might require multiple requests from the tool when initializing and updating commodity data

Won't do


generate column doesn't show in DML event

What did you do?

create a changefeed with Canal-JSON protocol
run sql

CREATE TABLE GENERATED_TABLE (
  id int PRIMARY KEY,
  A SMALLINT UNSIGNED,
  B SMALLINT UNSIGNED AS (2 * A),
  C SMALLINT UNSIGNED AS (3 * A) NOT NULL
);
INSERT INTO GENERATED_TABLE VALUES (1, 15, DEFAULT, DEFAULT);

decode messages from Kafka

What did you expect to see?
All column data
What did you see instead?
Column B and C are missing.
{
    "id": 0,
    "database": "test",
    "table": "GENERATED_TABLE",
    "pkNames": [
        "id"
    ],
    "isDdl": false,
    "type": "INSERT",
    "es":<PHONE_NUMBER>223,
    "ts":<PHONE_NUMBER>205,
    "sql": "",
    "sqlType": {
        "A": 5,
        "id": 4
    },
    "mysqlType": {
        "A": "smallint unsigned",
        "id": "int"
    },
    "data": [
        {
            "A": "15",
            "id": "1"
        }
    ],
    "old": null,
    "_tidb": {
        "commitTs":<PHONE_NUMBER>56634119
    }
}

Versions of the cluster
TiCDC version (execute cdc version):
master

@BenMeadowcroft PTAL

The root reason is that the message doesn't include the generated flag. If the generated column is sent downstream, the consumer can't distinguish generated columns, and raises an error like [CDC:ErrMySQLTxnError]MySQL txn error: Error 3105 (HY000): The value specified for generated column 'B' in table 'GENERATED_TABLE' is not allowed.

/severity major


Use relative paths on jsonnet imports

Currently absolute paths are being used for jsonnet imports. This makes
it difficult to share the files across different systems.
Fixes #149

Agree @hausdorff, but I think it's an enhancement that we can address after the release. Prefer to get this simple fix checked in so it doesn't block file portability issues between machines.


Allow for ParserLogic.parse to skip a page instead of just parsing

Since deliberate skipping is not an error

Should probably do it before the stats tracking, to do the tracking based on the new interface already.


[Question] Override sort() (or similar) for custom columns

Currently, sort isn't working on  OneToOneField() . If I could just override the sort functionality in some way by creating a custom column, I could get the unrestricted lookup that I need, which inevitably leads to my question:
Would it be possible to override sort() functionality for columns? (something similar to the search() override as mentioned in #7 )

Since there are no Column types for relationship fields of any kind (you have to use a concrete type, like IntegerColumn for a numerical pk, etc), I can't say for sure if there is a bug or configuration problem.  Any column correctly declaring a source or sources should be able to resolve the ORM field(s) and columninstance.get_sort_fields(model) should return database-sortable fields that are safe for sending to a queryset order_by.
If you've still got an example you can show me, I'd be happy to look!


[DOC] Add PyPI description

PR Description
Please describe the changes proposed in the pull request:

Copy relevant sections from README.rst for PyPI project description

This PR resolves #495.

PR Checklist

Please ensure that you have done the following:

[X] PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.

[X] If you're not on the contributors list, add yourself to AUTHORS.rst.

[X] Add a line to CHANGELOG.rst under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Quick Check
To do a very quick check that everything is correct, follow these steps below:

[X] Run the command make check from pyjanitor's top-level directory. This will automatically run:

black formatting
pycodestyle checking
running the test suite
docs build

Once done, please check off the check-box above.
If make check does not work for you, you can execute the commands listed in the Makefile individually.
Documentation Changes

If you are adding documentation changes, please ensure the following:

[ ] Build the docs locally.
[ ] View the docs to check that it renders correctly.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

@ericmjl Seems there is an issue finding the conda environment.
In this change, I considering making a test, but was unsure how to test something in setup.py, so I added the assert.

@hectormz, it's only failing on black at this point, I think! :smile: Could you black the entire codebase and push?

Hi @ericmjl, black and pycodestyle were in disagreement about a line in setup.py. Maybe this fix will do the job

All good! Thanks @hectormz!


[MXAPPS-581] Fixes for broken Straight Dope tests.

This change fixes a few broken notebooks in the Straight Dope tests. It's a follow up to https://github.com/apache/incubator-mxnet/pull/11814.

Update relative paths pointing to the data directory to point to the
correct place in the testing temporary folder.

Enable the notebooks that were previously broken because of relative
file paths not pointing to the correct place.

Move some notebooks we do not plan to test to the whitelist. These
notebooks are not published in the Straight Dope book.

Clean-up: Convert print statements to info/warn/error logging
statements. Add some logging statements for better status.

Hasan089


Tweak type alias logics

Change Summary
Put type alias logic after from_property and fix the type hint of _type_alias_schema.

Related issue number

Checklist

[ ] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos, could you take a look at this one?


THANK YOU!

3 teams on my project spend 2 days to find out why CORS on AWS lambda did work incorrectly
I hope fastAPI will take your patch and you became a contributor.
We fixed manually updating routes. But with your module, we would not even know that this problem exists.

Glad it helped you out!


Facing error while installing burrow module hashicorp/hcl/hcl/printer not found

go get github.com/linkedin/Burrow

Error while installing
package github.com/hashicorp/hcl/hcl/printer: cannot find package "github.com/hashicorp/hcl/hcl/printer" in any of: 	/usr/lib/golang/src/github.com/hashicorp/hcl/hcl/printer (from $GOROOT) 	/home/ec2-user/go/src/github.com/hashicorp/hcl/hcl/printer (from $GOPATH)
Confirmed from https://github.com/hashicorp/hcl
There is no module hcl/printer there

I am running into the same issue trying to build v1.3.6. Doubt it matters but using go 1.15.8.

it worked for me by setting
export GO111MODULE=on


Is there an API to know which accounts were created by a block?

Right now the number created by block is fixed to 5 if I understood correctly, so block 0 created account 0-4, block 1 created 5-9, etc. (correct me if I am wrong).
But is that number subject to future revisions? If so would an API returning the first & last account created by a block be appropriate?
Finally, if that API could also list the account(s) that received the block reward, that could also be more future-proof.

Accounts will be 5 per block, no plans for change it, no need to add this API method.

Could you reconsider? I am also thinking of possible clones/altcoins of Pascalcoin, for which the number of created accounts per block would be one of the parameters that could be adjusted by the alt (or even made dynamic).
Having a standard API for that would ease the pain of supporting these alts.


build: link Yams privately

Because Yams is used with @_implementationOnly, the clients of
SwiftDriver do not need to link against Yams or CYaml.  This was
uncovered when building SourceKit-LSP.

@swift-ci please test


init ck5 integration, based on old ck4 addon

Initial CK5 integration with DjangoCMS

@ns11 would be great if we could revive ckeditor 5 integration. We're about ready to move to v5 of the app following other changes so it would be idea to bump the editor also


Update outdated custom_plugins.rst

Plugin admin form sits in admin/cms/page/change_form.html and not in admin/cms/page/plugin_change_form.html
I hope I created a PR for the right branch. Let me know if I should change anything

Actually the correct path for the plugin change form template is  admin/cms/page/plugin/change_form.html, could you change that?

@yakky oh wow, completely missed that. Thank you. Will fix it a bit later

@zanderle thanks!


read op can't reply with fuse_reply_iov

rust-fuse forces the read op implementation to use ReplyData type as the reply object which is equivalent to fuse_reply_data or fuse_reply_buf because it returns a single buffer.
But, returning by scatter-gather is better for performance. If I understand correctly, that's because read op allows the user to reply with fuse_reply_iov.
This isn't a bug but I think rust-fuse has a reason to rethink its design.
        /**
         * Read data
         *
         * Read should send exactly the number of bytes requested except
         * on EOF or error, otherwise the rest of the data will be
         * substituted with zeroes.  An exception to this is when the file
         * has been opened in 'direct_io' mode, in which case the return
         * value of the read system call will reflect the return value of
         * this operation.
         *
         * fi->fh will contain the value set by the open method, or will
         * be undefined if the open method didn't set any value.
         *
         * Valid replies:
         *   fuse_reply_buf
         *   fuse_reply_iov
         *   fuse_reply_data
         *   fuse_reply_err
         *
         * @param req request handle
         * @param ino the inode number
         * @param size number of bytes to read
         * @param off offset to read from
         * @param fi file information
         */
        void (*read) (fuse_req_t req, fuse_ino_t ino, size_t size, off_t off,
                      struct fuse_file_info *fi);

You're right, scatter-gather-I/O is more performant if data isn't stored in a single linear buffer. Internally, all reply types already use &[&[u8]] (which is similar to an iovec) to pass around data for replying. If we could enhance ReplyData's interface to work with multiple slices, it would allow a more performant reply of data blocks.
The easiest way would be to simply add a method like
    /// Reply to a request with data from the given slices
    pub fn data_slices (mut self, data: &[&[u8]]) {
        self.reply.send(0, data);
    }

Another, more Rust-like approach would be to pass an iterator or a reader that ReplyData uses to gather data and use it for the reply. But maybe this would be more appropriate for a higher level abstraction (where pathnames are used instead of inode numbers like mentioned in README.md)

Sorry to start from my misunderstanding of the protocol. fuse 2.9.3 (protocol 7.19) has reply four methods for read but fuse 2.7.2 (protocol 7.8) has only two. So rust-fuse's implementation is conformant to protocol 7.8.
        /**
         * Read data
         *
         * Read should send exactly the number of bytes requested except
         * on EOF or error, otherwise the rest of the data will be
         * substituted with zeroes.  An exception to this is when the file
         * has been opened in 'direct_io' mode, in which case the return
         * value of the read system call will reflect the return value of
         * this operation.
         *
         * fi->fh will contain the value set by the open method, or will
         * be undefined if the open method didn't set any value.
         *
         * Valid replies:
         *   fuse_reply_buf
         *   fuse_reply_err
         *
         * @param req request handle
         * @param ino the inode number
         * @param size number of bytes to read
         * @param off offset to read from
         * @param fi file information
         */
        void (*read) (fuse_req_t req, fuse_ino_t ino, size_t size, off_t off,
                      struct fuse_file_info *fi);

So, extending the design so that read op can reply with iov is kind of back-porting.
By the way, do you know what version fuse started to support iov reply for read op? And, why fuse_reply_iov isn't used at all in fuse 2.7.2 (this is really weird)?

The reply methods actually don't support different protocol versions, they just provide different ways to specify the data that should be sent with a reply (i.e. reply methods are part of the library, not the protocol). Afaik fuse used fuse_reply_iov internally for a long time already. In theory you should be able to use fuse_reply_iov with protocol 7.8 with no problems (if the older libfuse exports this function).
So no matter what protocol version, it would be nice to have a reply method in rust-fuse that sends data by scatter-gather, like the data_slices method I suggested above (we're bound to talk a specific protocol version, but we define our own (Rust-like) interface and do not depend on wether fuse_reply_iov exists or not)


Tab Layoutproblem on iPhones (without home button)

Problem description
Setup: Main page has one widget: TabFolder with 'strech' layoutdata.
On iOS devices without a home button (i.E. iPhone 11), the layout of Tab eleemts is 'squashed':

Expected behavior
On older iOS devices with Home Button, the example looks like that:

Environment

Tabris.js version: 3.5
Device: iPhone 11
OS: iOS 13.51

Code snippet
https://playground.tabris.com/?gitref=v3.5.0&snippet=tabfolder.jsx

Same problem - screenshot from a customer project:

Note:
in this app, the initial layout is korrekt. If the user clicks on a textInput field, the layout is brocken after the focus of the TextInput is lost - the keyboard disappears and the layout is recalculated.

Looks like #2067

@cookieguru  well spotted - thank you
I will check with the Tabris team tomorrow if we should then close this as duplciate :)

Issue was fixed today. Change will be visible in tomorrows nightly.


Proposal: Addressing closures

Example, in AsyncImage a content closure can be passed to inspect the phase state to render out if the images loads or there is some type of failure:
AsyncImage(url: URL(string: "https://example.com/icon.png")) { phase in
    if let image = phase.image {
        image // Displays the loaded image.
    } else if phase.error != nil {
        Color.red // Indicates an error.
    } else {
        Color.blue // Acts as a placeholder.
    }
}

we currently don't have a convention to manage this in LVN. Our own AsyncImage implementation hard codes these phases:
https://github.com/liveview-native/liveview-client-swiftui/blob/main/Sources/LiveViewNative/Views/Images/AsyncImage.swift#L49-L60
But we have a way to pass templates off to a closure. If phase is the conventional term used in these cases I'd like to propose the following:
<AsyncImage url={@url} >
  <Image class="foo-bar" phase="image" />
  <Text phase="error">Error!</Text>
</AsyncImage>

this convention should carry across all views

Any child elements with the attr phase should be lifted out same as with template

@carson-katri I realize phase isn't a standard variable on all views, that wasn't what I was suggesting. Considering we are the ones implementing the views we have control over what that variable is.
I'm opposed to using template as it is polluting the utility of the that attribute. For example, could we run into an issue where both a content in the closure and a content view for a modifier would be necessary now we only have a single attribute to do that in? Having to share responsibility I believe is bad API design.
We can simply just define what the closure name is for the given view.

I went back and looked over a few examples. I am convinced that we need a way to represent this in markup. But I don't yet have a clean way to do this.
For the AsyncImage example or any closure that takes arguments, I don't think we should deviate from the current API on what template means. What we do need though is a way to inform a view outside of the modifier system which templates are used for which named closure:
AsyncImage(url: URL(string: "...")) { phase

}

this particular form of AsyncImage is the one we should use I believe because it has more nuanced control over the phases. Why the other form doesn't have a named closure beyond the success and placeholder is beyond me but here we are. In this case we could represent it like so:
<AsyncImage content={:phase} url={@url}>
  <Group template={:phase}>
    <Image class="resizable phase={:success}/>
    <Text phase={:error}>Error!</Text>
    <ProgressView phase={:placeholder}/>
  </Group>
</AsyncImage>

or a form that coalesces a the template name:
<AsyncImage content={:phase} url={@url}>
  <Image template={:phase} class="resizable enum={:success}/>
  <Text template={:phase} enum={:error}>Error!</Text>
  <ProgressView template={:phase} enum={:placeholder}/>
</AsyncImage>

This becomes more tricky when it comes to views like GeometryReader. I do not think at this time we want to expand the scope of this prorposal for the full surface area of closures. But for cases of enum states it may be valid.
What we want to avoid is a specific DSL just for AsyncImage, we need to find a solution that is going to not just work for the SwiftUI views but any view of any complexity that others may write in the future.

@carson-katri something that would really open up some possibilties for us is if we accepted some encoding within the attributes. We could easily do a simple version of the modifier parser to produce an AST node for runtime parsinga and use. As long as it doesn't significantly affect the render performance.

Here's a possible solution:

Use argument[value] to specify a template for a given value of the closure argument. This would typically be an enum case, such as empty, success, or failure.
Use the element name with some boolean attribute (image or error in this case) to render an associated value from the enum case. You can put any additional attributes on this element, such as class="resizable".

<AsyncImage url="...">
    <Group template="phase[empty]">
        <ProgressView />
    </Group>
    <Group template="phase[success]">
        <AsyncImage image class="resizable" /> <!-- reference to evaluated image element -->
    </Group>
    <Group template="phase[failure]">
        <AsyncImage error /> <!-- reference to plain-text error description -->
    </Group>
</AsyncImage>

This can also be converted into a component for more natural use:
<AsyncImage.async_image url="...">
    <:empty>Loading</:empty>
    <:success :let={image}>
        <%= image %>
    </:success>
    <:failure :let={error}>
        <%= error %>
    </:failure>
</AsyncImage.async_image>

defmodule AsyncImage do
  use Phoenix.Component
  use LiveViewNative.Component,
    format: :swiftui,
    as: :render

  attr :rest, :global
  slot :empty
  slot :success
  slot :failure
  def async_image(assigns) do
    ~LVN"""
    <AsyncImage {@rest}>
      <Group template="phase[empty]">
        <%= render_slot(@empty) %>
      </Group>
      <Group template="phase[success]">
        <%= render_slot(@success, ~LVN"<AsyncImage image />") %>
      </Group>
      <Group template="phase[failure]">
        <%= render_slot(@failure, ~LVN"<AsyncImage error />") %>
      </Group>
    </AsyncImage>
    """
  end
end

That's what I was picturing, a library that adds additional function components on top of the raw markup syntax.
I'm not sure about the template syntax myself.
argument[case] looks like a subscript, argument.case looks like a member access. Maybe argument:case for more of a key-value look? Or move the argument segment into the attribute, template:argument="case"
I have a prototype implementation of this syntax for AsyncImage and the template format is extracted so we can experiment with it.

I don't think the current API would be able to extend beyond enum cases. AsyncImage is the only example I can think of in SwiftUI. RealityKit has Model3D which uses a similar API to AsyncImage.
Here a few more complex cases, but I don't think it would be practical to implement these for SSR:

KeyframeAnimator

KeyframeAnimator(initialValue: 0.0) { value in
    Text("Hello, world!")
        .offset(y: value)
} keyframes: { value in
    LinearKeyframe(20, duration: 3)
    SpringKeyframe(0, duration: 1)
    CubicKeyframe(-20, duration: 2)
    LinearKeyframe(0, duration: 0.5)
}

The value is updated based on the specified keyframes. This value can then be used within the content. In this example, the value is used as an offset for the text.

Canvas

Canvas { context, size in
    context.fill(Circle().path(in: .init(x: 0, y: 0, width: 20, height: 20)), with: .color(.red))
    context.rotate(by: .degrees(45))
    context.stroke(Rectangle().path(in: .init(x: 10, y: 10, width: 40, height: 40)), with: .color(.red))
}

Canvas does not have a declarative API. To implement something like Canvas we would likely need a way to represent the commands as elements. Possibly something like <svg>. But in general, this would be better to implement as a custom View on the client side.

TimelineView

TimelineView(.periodic(from: startDate, by: 1)) { context in
    AnalogTimerView(date: context.date)
}

In this example, the AnalogTimerView is updated every 1 second with a new context.date value.

I think this keeps coming back to that we need a way to represent attribute values in a more complex fashion that simply key/value. I've been punting on this for a while but we may need to support deserialization of attributes from complex objects.

Even for more basic Views this will be helpful. For example, LazyVGrid needs to pass a list of GridItem to the columns attribute to configure the number/layout of the columns. If the template automatically encoded the attribute from a list, the API would be much simpler.

@carson-katri is there an easy way for the client to determine if a value should be de-serialized? What I'd like to avoid is having to declare each attribute that should be deserialized in a specific manner. Or, would that actually be more performant?

I assume it would just be the attributes that take complex values. Such as the columns attribute in the LazyVGrid example.

Right but would that mean you'd have to go back to every single view in the SwiftUI and declare how each attribute should be deserialized? Or is there a single choke point to do this?

what I'll look into today is enabling auto-serialization for Map within the template:
<FooBar baz={%{a: 1}} />

evals as
<FooBar baz="{a: 1}" />

@carson-katri do you see us needing anything more than Map?

List values will be needed.

Went down the rabbit hole a bit here. I think this is going to be a deeper fix than I originally anticipated. I can easily expand Phoenix.HTML.Safe to give us what we want but that would impact the HTML rendering as well and we don't want to contaminate that. Instead I'll probably have to implement our own LiveViewNative.Template.Safe for rendering and this may require a bunch more changes to delegate to that function. Or, if I could advocate for the Safe handler to be part of the template compiler upstream in Phoenix itself. Either way this isn't a quick fix to do correctly. I'm going to try and grab Jose's time to discuss the best approach here this week after I dig a bit deeper, probably just make a PR upstream to get that conversation started.

Json encoded literals are now enabled: https://github.com/liveview-native/live_view_native/pull/132


[WIP]enable screenshots in Chrome for multiple browser windows

Purpose
Describe the problem you want to address or the feature you want to implement.
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
Provide a link to the existing issue(s), if any.
Pre-Merge TODO

[ ] Write tests for your proposed changes
[ ] Make sure that existing tests do not fail

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest

@testcafe-build-bot retest


Add dropdown item alignment

[x] Changes have been thoroughly tested to not break existing functionality.
[x] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Allow for text alignment to be changed.
Allow for icon/badge position to be changed.

Useful if you have a dropdown opened with placement at the end of the window.

@howdu, could you share some design systems that do this?
Personally I've never seen right-aligned text like that and design-wise (UX/accessibility) I think it's better to keep it aligned to the start regardless of the dropdown panel placement. I want to prevent introducing APIs that result in bad interfaces.
If you can back these changes up with research findings or other big projects using this approach, I'm happy to discuss these though. 🙂

Thanks for looking into this @zepfietje.
I think it makes more sense when your eyes are pointed towards the right side of the screen for the icon/text to be as close as possible without the white gap. this but for when you have lots of dropdown opening  makes more sense to me when the menu it opened from the right of the UI.
Telerik editor does this when you have a multi-level dropdown.

This PR also lets you move the icon to the right to create more of a separation.

Honestly, Telerik has a bad and inaccessible design then. Don't mean to be rude, but I've had a look at how Apple handles this in macOS and found some more cases and research to back it up:

https://tailwindui.com/components/application-ui/elements/dropdowns
https://www.nngroup.com/articles/drop-down-menus/
https://www.nngroup.com/articles/right-justified-navigation-menus/

I'm sorry, but I'm going to have to close this PR, @howdu.
Thanks for discussing though! 🙂


SUBMARINE-305. Rename test classes in submitter-yarnservice to conform Code style

What is this PR for?
Renaming test classes in submitter-yarnservice submodule to conform code style.
What type of PR is it?
Refactoring
Todos

[ ] - The unit tests should pass as before the patch.

What is the Jira issue?

SUBMARINE-305

How should this be tested?

No further testing is needed besides Travis.

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Thanks for the review and merge!


RootChain contract cleanup

Closes #138 and adds more comments for clarity.
Main style changes:

Switch to /** */ style natspec strings.
Add some extra comments.
Add a BlockSubmitted event.
Function parameters now start with an underscore for clarity.

@boolafish the underscore prefix is pretty standard for most solidity work (check out OpenZeppelin's work). I find it helps quickly distinguish between function parameters (should treat as immutable) and everything else. Some other arguments here: https://ethereum.stackexchange.com/q/1351/22130


writeconcern option for mongodb

Problem
There are times where writeconcern needs to be set(to optimize reads/writes on a certain set of queries). Currently this is only possible via raw mongodb access.
Suggested solution
An option to pass writeconcern into generic queries would be great. Currently there's no way of setting a writeconcern elegantly.
Alternatives
Currently, you can use raw mongodb access to set writeconcerns.

#10899

Context: https://docs.mongodb.com/manual/reference/write-concern/

This is also extremely important for Postgres, for example when writing a user session to the database we need to make sure the login operation flushes that insert of the session record to all nodes. If there is a DB partition, we want logging in to fail, rather than the subsequent requests racing against the replication delay and erroring out because a session wasn't propagated to all the nodes


PyPDF2 Not Found

After installing python3 and pypdf2, i keep getting this error. I know that pypdf2 is installed and working based upon their test from the repo. Any suggestions?
Random, but you know if that url set in that screenshot will work? This is a last ditch attempt, as it seems the book in this setup is some sorta weird  iframed CSS/HTML5 and not pdfs like in your case.
Cheers

When you installed PyPDF2, did you use the pip3 command to install it? Python 2 and 3 can have different modules installed. Also, that URL doesn't seem like it would work with this downloader, since at the moment, it only works with urls that start with https://etext.pearson.com/eplayer/pdfbook

Closed for inactivity. Feel free to re-open if the issue is still relevant, but the script works fine on multiple machines I've tested with, including different operating systems


cache and merge in new annotations with already loaded data

This PR makes it so when annotation data is requested, it keeps, merges in, and removes duplicates with any existing data instead of just overwriting with new data.  This means that a user, if they panned back to an area of the map they have already visited, should not see a few ms of no data while data is being requested and should see the previous style.

I think if we are going to do this, then we also need to have a way to remove annotations from memory that are outside the current view.  Otherwise as the user pans around, memory usage could grow without bound, right?

Yeah, memory would grow as they pan around. We'd have to figure out how many objects a normal browser could handle. Some older ones would struggle more.
I imagine it would be possible to resize the annotation array to a set size, so that it keeps the most recently pushed objects (assumption is that they are geographically close to each other) and that resizing would work wrt memory, garbage collect etc.
Another way could be to only update the id array for the map and leave the annotations to be replaced as it is.  If the user clicks on a polygon and the annotations hadn't been loaded yet, they wouldn't see any detail, so maybe there could be a new check for new info and re-populate the side panel, or just show a loading indicator until?  The id array could be much larger but still wouldn't be able to have everything in it, I guess.  Perhaps a loading indicator or refresh mechanism could be used for both approaches?


ci: Use Docker Compose v2

Fixes https://github.com/atsign-foundation/operations/issues/134 for this repo
- What I did
Modified scripts to use Docker Compose v2
- How I did it
s/docker-compose/docker compose/
- How to verify it
Functional tests
- Description for the changelog
ci: Use Docker Compose v2

More joy - it seems that test_virtualenv_1 has been automangled to test-virtualenv-1

@cpswan  I see Container test-virtualenv-1  Started in the "Start docker instance" job and No such container: test_virtualenv_1 in the "Run PKAM" job of the "functional_tests" workflow (link to action run)
Perhaps a backwards compatibility issue where previously underscores and hyphens were somehow treated the same way?

@cpswan I see Container test-virtualenv-1 Started in the "Start docker instance" job and No such container: test_virtualenv_1 in the "Run PKAM" job of the "functional_tests" workflow (link to action run)
Perhaps a backwards compatibility issue where previously underscores and hyphens were somehow treated the same way?

( I see you've already fixed it )

functional test run (beta) is good but the (stable) run looks like it's going to fail for an unrelated flakiness issue. Will re-run when it does

functional test run (beta) is good but the (stable) run looks like it's going to fail for an unrelated flakiness issue. Will re-run when it does

Didn't fail but took twice as long as the (beta) run. I'll copy the test run logs to take a look later if I have time.


Placeholder pages for modules and clients

Is your feature request related to a problem? Please describe.
Our docs markdown pages (topics and commands) contain links to ../clients/ and ../modules/ for the lists of such resources. Currently they are broken or redirected to some other page.
Describe the solution you'd like
Let's add placeholder pages with some "under construction" or "coming soon" text. It's not ideal, but IMO it's better than incorrect or broken links.
Page URLs that would match the links in the current docs markdown would be
https://valkey.io/clients/
https://valkey.io/modules/

#166 will add the clients page but it may take some time before it's ready.

I agree with not having 404s but at the same time "under construction" pages are not ideal (despite having some.. I'd rather not add more).
Would it make sense to have a minimal interim page or forward?
/modules/ forward to valkey.io/topics/modules-intro
/clients/ forward to valkey.io/topics/protocol

I'd rather have a "Coming soon" stub page than a redirect to some different content which is not what the visitor was looking for. Ideally, it the stub page shouldn't be completely empty. For clients, we could link to our few clients github repos, e.g.?

Clients
Coming soon. In the meantime, find out more about our official clients under each client's repository.

valkey-py
valkey-glide
valkey-go
iovalkey
valkey-java
libvalkey

And for modules, I don't have a good suggestion...