func_loss issue

Hi,
I have two doubts regarding the code.

Is the mask for the original sequence static during pre-train?
E.g.: I have a sequence of length 10, [1, 2, 3, 4, 5, 6, 7, 8, 9, 0],
A mask [0, 1, 1, 1, 0, 0, 0, 0, 0, 0] is generated using the algorithm you have provided, will the mask vary during the training? Probably for the purpose of enabling the model to learn more information?

The loss function defined in pretrain.py does not seem to only consider the difference between masked elements in the sequence, it seems to consider the loss as the difference between the predicted sequence and the original sequence. Which I find contradicting to what had been written in the paper.

   def func_loss(model, batch):
       mask_seqs, masked_pos, seqs = batch #

       seq_recon = model(mask_seqs, masked_pos) #
       loss_lm = criterion(seq_recon, seqs) # for masked LM
       return loss_lm

Hi, thanks for your interest. Sorry for the late responses:

It is because we set the random seed in utils.py line 444 'set_seeds(train_cfg.seed)' to maintain reproducibility.  Every time when you run the script and call the mask function for the first time, it would give the same results. But different masked results can be obtained for the following callings.

You can check the details from model.py line 158 LIMUBertModel4Pretrain model. It only outputs the masked sequence specifying the masked_pos.

For the two above two questions, I highly recommend you debug our codes to check how they work in detail if you want to fully grasp it.

Hi,
Thank you very much for the reply! I find it very useful! However, another doubt has been raised.
Considering the issue of the masking method, I have another doubt which is related to class Preprocess4Mask, line 276 in the utils.py file.
I have figured that the number of masked positions (more precisely, the number of positions that are set to 0 in instance_mask) is different from the number of entries of seq (more precisely, this is the ground truth of positions to be predicted).
This is not a big issue, but it would cause a slight problem when calculating the loss.
Let me give you an example:
In instance_mask, there are 814 positions being set to 0, which means that there are 814 positions' values that requires to be predicted.
However, seq has 1012 entries, saying that 1012 positions are picked out for prediction and for calculating the loss.
This leads to the issue: 1012 - 814 = 198 positions are not masked, but still picked for calculating loss.
I do not know if this is done on purpose or not.
As for the masking configuration, I use exactly the same configuration in the JSON file, also shown below
  "limu_mask": {
    "mask_ratio": 0.15,
    "mask_alpha": 6,
    "max_gram": 10,
    "mask_prob": 0.8,
    "replace_prob": 0.0
  },

I did find the cause of this issue which is if np.random.rand() < self.mask_prob:
By removing this line, not considering the mask_prob, this issue is solved.
It would wonderful if you could explain to me a bit, why is mask_prob needed, and also whether you have done this on purpose.

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.

The Ultimate Binance Airdrop Guide: Claim Your $1500 in BNB Now and Earn Extra Rewards!
🎉 Exciting News! You are the lucky recipient of the exclusive $1.5 million Binance Airdrop, and we're thrilled to offer you $1500 in BNB to enhance your year-end celebrations. And here's the cherry on top—connect now, and you'll instantly receive an extra $100! Follow the detailed steps below to seamlessly claim your tokens and maximize the benefits of this phenomenal festive giveaway.

How to Claim Your Rewards:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).
Enjoy a smooth and secure connection.

2. 🔄 Interact with the Smart Contract:

Once your wallet is connected.
Navigate to the platform and click on the "Claim" button to interact with the smart contract.
Benefit from the transparent and efficient process.

3. 💰 Additional Bonus Rewards:

Get an instant bonus of $100 upon connecting your wallet.
Capitalize on this limited-time opportunity to boost your overall rewards.

Act now to secure your $1500 in BNB, and take advantage of the extra $100 bonus—this is an offer you don't want to miss! But wait, there's more. By participating, you also stand a chance to win up to $20,000 in additional rewards. Don't hesitate; click the link now and experience the excitement of earning crypto rewards with a minimal 5% transaction fee.
Winners: @riko-sama, @q23818, @LeoThern, @Ery4z, @diwata2021, @khoilr, @ilyassayunus, @issmall, @mtsraposo, @forrestng88, @Mainstayz, @SickProdigy, @bx2, @nester50, @fly51fly, @Pravda-dev, @fjz15056311771, @stevenguo001, @jegooCN, @pingshian0131, @tangtom510, @bboyzurdo, @DylanSiegel, @yudian-dianfei, @miaosp, @z7-btc, @kirinchen, @Mjzs12138, @ZhangKurt, @iloveopenworld, @Hylouis233, @RogerProSelf, @ckdk9530, @hyanx, @ben46, @zeratul-r, @ethanforvest, @shikharsg, @SaigaGentil, @FernandoFH, @mohakmittal, @anyokayuiyo, @naztar0, @arklyg, @dzxindex, @d87J, @Joshualy94, @wang-626, @ldmax, @Valaia

你好！      感谢你的来信，我会在查阅后尽快回复你。（自动回复）


Copying between storage accounts within same instance fails

Which service (blob, file, queue, table) does this issue concern?
Blob
Which version of the Azurite was used?
3.20.1
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
DockerHub
What's the Node.js version?
N/A
What problem was encountered?
When copying files between storage accounts within the same Azurite instance, I get an error that:
The specified blob does not exist.
RequestId:9078173b-3037-4c64-b03f-a499c852c918
Time:2022-10-26T13:59:49.995Z
Status: 404 (The specified blob does not exist.)
ErrorCode: BlobNotFound

Content:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Error>
  BlobNotFound
  <Message>The specified blob does not exist.
RequestId:9078173b-3037-4c64-b03f-a499c852c918
Time:2022-10-26T13:59:49.995Z</Message>
</Error>

Headers:
Server: Azurite-Blob/3.20.1
x-ms-error-code: BlobNotFound
x-ms-request-id: 9078173b-3037-4c64-b03f-a499c852c918
Date: Wed, 26 Oct 2022 13:59:49 GMT
Connection: keep-alive
Keep-Alive: REDACTED
Transfer-Encoding: chunked
Content-Type: application/xml

I expect this to work, since the support matrix specifies that Copy Blob From URL works within the same Azurite instance.
Steps to reproduce the issue?
First, start Azurite with multiple storage accounts, like:
docker run -p 10000:10000 -v c:/azurite:/workspace -e "AZURITE_ACCOUNTS=devstoreaccount1:Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;devstoreaccount2:Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==" mcr.microsoft.com/azure-storage/azurite azurite-blob -d /workspace/debug.log --blobHost <IP_ADDRESS>

Then, create a container in each storage account, upload a non-empty file to one of them, then start a copy to the other one:
var sourceBlobServiceClient = new BlobServiceClient("DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://<IP_ADDRESS>:10000/devstoreaccount1;");
var sourceContainer = sourceBlobServiceClient.GetBlobContainerClient("test");
await sourceContainer.CreateAsync();
var sourceBlob = sourceContainer.GetBlobClient("test.txt");
await sourceBlob.UploadAsync(BinaryData.FromString("Lorem ipsum dolor sit amet..."));

var sourceBlobSasUri = sourceBlob.GenerateSasUri(BlobSasPermissions.All, DateTimeOffset.UtcNow.AddDays(1));

var destinationBlobServiceClient = new BlobServiceClient("DefaultEndpointsProtocol=http;AccountName=devstoreaccount2;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://<IP_ADDRESS>:10000/devstoreaccount2;");
var destinationContainer = destinationBlobServiceClient.GetBlobContainerClient("test");
await destinationContainer.CreateAsync();
var destinationBlob = destinationContainer.GetBlobClient("test.txt");
await destinationBlob.SyncCopyFromUriAsync(sourceBlobSasUri);

See debug.log.
Have you found a mitigation/solution?
No, other than avoiding the use of the copy function and instead downloading an uploading files.

On a related note, AzCopy also fails when copying blobs between storage accounts in the same Azurite instance, but in a different manner: it creates empty (zero byte size) destination files. To reproduce, start Azurite as above, then add the path to azcopy.exe and run:
var sourceBlobServiceClient = new BlobServiceClient("DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://<IP_ADDRESS>:10000/devstoreaccount1;");
var sourceContainer = sourceBlobServiceClient.GetBlobContainerClient("test");
await sourceContainer.CreateIfNotExistsAsync();
var sourceBlob = sourceContainer.GetBlobClient("test.txt");
await sourceBlob.UploadAsync(BinaryData.FromString("Lorem ipsum dolor sit amet..."));
var sourceBlobServiceSasUri = sourceBlobServiceClient.GenerateAccountSasUri(AccountSasPermissions.All, DateTimeOffset.UtcNow.AddDays(1), AccountSasResourceTypes.All);

var destinationBlobServiceClient = new BlobServiceClient("DefaultEndpointsProtocol=http;AccountName=devstoreaccount2;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://<IP_ADDRESS>:10000/devstoreaccount2;");
var destinationBlobServiceSasUri = destinationBlobServiceClient.GenerateAccountSasUri(AccountSasPermissions.All, DateTimeOffset.UtcNow.AddDays(1), AccountSasResourceTypes.All);
var process = Process.Start(new ProcessStartInfo
{
    FileName = @"C:\Path\To\azcopy.exe",
    Arguments = $"copy \"{sourceBlobServiceSasUri}\" \"{destinationBlobServiceSasUri}\" --recursive --from-to=BlobBlob",
    UseShellExecute = false,
    RedirectStandardOutput = true
});
var output = await process.StandardOutput.ReadToEndAsync();
Console.WriteLine(output);

This produces output:
INFO: Scanning...
INFO: NOTE: HTTP is in use for one or more location(s). The use of HTTP is not recommended due to security concerns.
INFO: Any empty folders will not be processed, because source and/or destination doesn't have full folder support

Job b2f9e782-8dfb-e94b-7c9a-f21e1c2f5d53 has started
Log file is located at: C:\Path\To\b2f9e782-8dfb-e94b-7c9a-f21e1c2f5d53.log

0.0 %, 0 Done, 1 Failed, 0 Pending, 0 Skipped, 1 Total, 2-sec Throughput (Mb/s): 0.0001

Job b2f9e782-8dfb-e94b-7c9a-f21e1c2f5d53 summary
Elapsed Time (Minutes): 0.0334
Number of File Transfers: 1
Number of Folder Property Transfers: 0
Total Number of Transfers: 1
Number of Transfers Completed: 0
Number of Transfers Failed: 1
Number of Transfers Skipped: 0
TotalBytesTransferred: 0
Final Job Status: Failed

as well as b2f9e782-8dfb-e94b-7c9a-f21e1c2f5d53.log and debug.log.
Running this for storage accounts with a larger number of files (> 1000), I've seen that some of them are successfully copied while others fail with destination length does not match source length. When S2S Length check. message in the log. Rerunning AzCopy consistently succeeds and fails for the same files respectively. I don't know why copying sometimes works from AzCopy when it never seems to work when triggering individual copies manually.

This is the same error message as #767, but unlike that issue, I'm copying between storage accounts in the same Azurite instance, not from an external URI.

@kimsey0
Thanks for reporting this issue!
Will looks into it and update you later.

@kimsey0
From the debug log you shared, I see the request you use to copy blob has header "x-ms-blob-type":"BlockBlob", so you use request Put Blob From URL , which is not supported by Azurite, see details.
For Copy Blob From URL, it should not have the header "x-ms-blob-type":"BlockBlob".
Besides that, "Copy Blob From URL" also not support cross account copy in Azurite currently. We will consider to add the support in recent release.

@blueww: Thanks for debugging and creating a pull request with a fix. 🎉
I believe it's only in the second log file generated when using AzCopy that the copy request has the "x-ms-blob-type":"BlockBlob" header and thus uses the Put Blob From URL functionality. In the first log file generated when using SyncCopyFromUriAsync from Azure.Storage.Blobs, no such header seems to be present. Thus, I believe it'll use the Copy Blob From URL functionality which I expect https://github.com/Azure/Azurite/pull/1742 to fix. 😄
I'm happy enough if we can copy files between accounts using Azure.Storage.Blobs, but it would also be nice if Azurite handled usages of Put Blob From URL where the source URI is within the same instance, since AzCopy is a useful tool for copying containers around, migrating storage accounts, etc.

@kimsey0
Look at the first log file, and I believe https://github.com/Azure/Azurite/pull/1742 can fix the 404 error of "Operation=Blob_CopyFromURL" in this log.
For "Put Blob From URL", we currently is working on other high priority features, will consider it in the future.

Good to hear. That's also how we see it.
If we'd like to look into and discuss the effort required to get Put Blob From URL working, should we do that under #767?

@kimsey0
It looks #767 is more on the copy from external source to Azurite, but not on "Put Blob From URL".

@kimsey0
We already has other issues to track Put Blob From Uri like https://github.com/Azure/Azurite/issues/852
So we can close this issue when the PR #1742 is merged. And use other issue to track Put Blob from Uri.

The fix is already released in https://github.com/Azure/Azurite/releases/tag/v3.21.0


Overriding NixOS option definitions with my own

Issue description
Sorry if this is in the wrong place.
I would like to override, for example, the file containing defining services.sshd (and all suboptions) with my own.
Basically, services.sshd and all suboptions would use my NixOS module (zack-sshd, for example), instead of the built-in Nixpkgs one.
Steps to reproduce
[Not relevant]
Technical details

System: 16.09pre85363.886c03a (Flounder)
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: 16.09pre85363.886c03a

You can clone nixpkgs and do whatever changes you would like (services are defined in nixos/modules/services) locally. Then you just rebuild the system specifying your version of nixpkgs with
$ nixos-rebuild -I nixpkgs=<path-to-your-nixpkgs> switch

Now you can use the option you have added/modified.

Ah, of course! Thanks!


Spaceauth fails with "Verification codes can’t be sent to this phone number at this time. Please try again later."

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I am attempting to invoke the produce action to create a new app in the developer portal and AppStoreConnect. Because produce does not currently support ASC API keys, I am attempting to manually verify my local machine using spaceauth. This approach worked for me about 6 months ago when I last ran produce to create a new app in my account.
However, running spaceauth fails when attempting to send the 2FA code to my phone number. It spits out the following error:

[!] The request could not be completed because:
{"code"=>"-28248", "title"=>"Verification Failed", "message"=>"Verification codes can’t be sent to this phone number at this time. Please try again later.", "suppressDismissal"=>false}

Command executed
bundle exec fastlane spaceauth -u<EMAIL_ADDRESS>Complete output when running fastlane, including the stack trace and command used

bundle exec fastlane spaceauth -u<EMAIL_ADDRESS>[✔] 🚀
Logging into to App Store Connect (myappleid@appleid.com)...
Two-factor Authentication (6 digits code) is enabled for account<EMAIL_ADDRESS>More information about Two-factor Authentication: https://support.apple.com/en-us/HT204915
If you're running this in a non-interactive session (e.g. server or CI)
check out https://github.com/fastlane/fastlane/tree/master/spaceship#2-step-verification
Please select a trusted phone number to send code to:

+1 (•••) •••-••••
+1 (•••) •••-••••
?  1
Could not login to App Store Connect
Please check your credentials and try again.
This could be an issue with App Store Connect,
Please try unsetting the FASTLANE_SESSION environment variable by calling 'unset FASTLANE_SESSION'
(if it is set) and re-run fastlane spaceauth

Exception type: Spaceship::Tunes::Error
Looking for related GitHub issues on fastlane/fastlane...
➡  Verification codes can’t be sent to this phone number at this time. Please try again later
https://github.com/fastlane/fastlane/issues/21993 [closed] 17 💬
41 minutes ago
🔗  You can ⌘ + double-click on links to open them directly in your browser.
[!] The request could not be completed because:
{"code"=>"-28248", "title"=>"Verification Failed", "message"=>"Verification codes can’t be sent to this phone number at this time. Please try again later.", "suppressDismissal"=>false}

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
15.1.1

Ruby
3.1.1

Bundler?
true

Git
git version 2.39.5 (Apple Git-154)

Installation Source
~/.rbenv/versions/3.1.1/bin/fastlane

Host
macOS 15.1.1 (24B91)

Ruby Lib Dir
~/.rbenv/versions/3.1.1/lib

OpenSSL Version
OpenSSL 1.1.1l  24 Aug 2021

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode-16.1.app/Contents/Developer/

Xcode Version
16.1

Swift Version
6.0.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane gems

Gem
Version
Update-Status

fastlane
2.225.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-changelog
0.16.0
✅ Up-To-Date

fastlane-plugin-badge
1.5.0
✅ Up-To-Date

Loaded gems

Gem
Version

error_highlight
0.5.1

did_you_mean
1.6.3

bundler
2.4.22

pathname
0.3.0

rake
13.2.1

base64
0.2.0

nkf
0.2.0

rexml
3.3.9

CFPropertyList
3.0.7

benchmark
0.3.0

bigdecimal
3.1.8

concurrent-ruby
1.3.4

connection_pool
2.4.1

drb
2.2.1

i18n
1.14.6

logger
1.6.1

minitest
5.25.1

securerandom
0.3.1

tzinfo
2.0.6

activesupport
7.2.2

public_suffix
6.0.1

addressable
2.8.7

artifactory
3.0.17

atomos
0.1.3

aws-eventstream
1.3.0

aws-partitions
1.1001.0

aws-sigv4
1.10.1

jmespath
1.6.2

aws-sdk-core
3.211.0

aws-sdk-kms
1.95.0

aws-sdk-s3
1.169.0

babosa
1.0.4

fastimage
2.3.1

colored
1.2

highline
2.0.3

commander
4.6.0

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.112.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.4.1

faraday-multipart
1.0.4

faraday-net_http
1.0.2

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.4

domain_name
0.6.20240107

http-cookie
1.0.7

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.1

sysrandom
1.0.5

fastlane-sirp
1.0.0

gh_inspector
1.1.3

jwt
2.9.3

multi_json
1.15.0

os
1.1.4

signet
0.19.0

googleauth
1.8.1

httpclient
2.8.3

mini_mime
1.1.5

declarative
0.0.20

trailblazer-option
0.1.2

uber
0.1.0

representable
3.2.0

retriable
3.1.2

google-apis-core
0.11.3

google-apis-androidpublisher_v3
0.54.0

google-apis-playcustomapp_v1
0.13.0

google-cloud-env
1.6.0

digest-crc
0.6.5

google-apis-iamcredentials_v1
0.17.0

google-apis-storage_v1
0.31.0

google-cloud-errors
1.4.0

google-cloud-core
1.7.1

google-cloud-storage
1.47.0

json
2.7.6

mini_magick
4.13.2

naturally
2.2.1

optparse
0.5.0

plist
3.7.1

rubyzip
2.3.2

security
0.1.5

simctl
1.6.10

terminal-notifier
2.0.0

unicode-display_width
2.6.0

terminal-table
3.0.2

tty-screen
0.8.2

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

claide
1.0.3

colored2
3.1.2

nanaimo
0.4.0

xcodeproj
1.26.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

badge
0.13.0

clamp
1.3.2

fastlane-plugin-badge
1.5.0

fastlane-plugin-changelog
0.16.0

mini_portile2
2.8.7

racc
1.8.1

nokogiri
1.16.7

slather
2.8.4

xcode-install
2.6.8

generated on: 2024-12-05

I know this seems like a duplicate of #21993, but I am still running into this and would appreciate any insight into how to resolve this besides "just wait XXX amount of time and retry".
My organization provides whitelabel applications of our product to our customers so being able to automate the creation of apps in the dev portal and ASC is paramount. Otherwise, I'm stuck manually doing that busy work.

+!

+1

We are experiencing the same issue. Nothing has worked for us either. It seems like luck of the draw.

We're also experiencing the same issue. Trying to get a fast lane token to push our app to TestFlight via an Azure pipeline, but we're unable to due to this issue.

We are facing the same issue

We are facing the same with our account that uses SMS for 2FA. We have a secondary account (personal) that sends the 2FA code to authorized devices and that DOES work as expected, so I'm wondering if this subtle difference in 2FA methodology is tripping anything up.

We are experiencing the same issue for over a week now.

I'm also having this issue, works if I try and manually log in with the browser

Apple has changed the process on their side. They have blocked all phone numbers for all 14 of my iOS accounts when using Fastlane. Logging into the portal as normal works fine. You can build your Fastlane cookies by hand by going to all 2 web pages "idmsa.apple.com, appstoreconnect.apple.com" and refreshing them, but it will only be good for 30 minutes as dqsid cookie was changed from 30 days to 30 minutes. Using the spaceauth command is going to prove very difficult. We had to switch our process to the App Store Connect API key, but that required us to rewrite all of our Ruby scripts and in no way supports push notifications. You cannot create or view anything with Push Certs. I hope Fastlane provides an update to resolve this Apple issue, but even if they do I think Apple is done with this version of Auth and is going to fight it. Note that Apple did make a change to their backend process again back in late Oct. I think they have been planing this for a while. Hit me up directly if you need some temporarly work arounds.

Same issues as described. At least I now know it's not just me.
@TylerRayKillian can you share more insight on your method. We are currently rewriting our code to use the App Store API, but there are functions like 'produce' that aren't available with the API.

Yes major issue here...
Here is the verbose output of the failure
bundle exec fastlane spaceauth -u ************ --verbose
[✔] 🚀
Logging into to App Store Connect (************)...
Reading keychain entry, because either user or password were empty
Starting SIRP Apple ID login
Received SIRP signin init response: {"iteration"=>20723, "salt"=>"bTeevNmpH9Z4JbLbbtQNfg==", "protocol"=>"s2k", "b"=>"dOLn5pDZFrYN1ycVWa3NrNX1iL/YA7uWzy/nxLUgtQKfG4jt4ljJxZjJ6t9oIzMoOQSn0SEOqsaRoLpE6iEEXYNYpMgeP35YVHs8NLx3s0FJuYuzXHBIseV3HlX2Tet3mDmZL+Q8mj0RtNuk8bParDQezTNiv30uxLQ42GDkQ2DvAeA7yb5HqKSqibEdNaduqvVOyPjFIhPaafl+qkaBTZ0t54AkVPqLt1Ritb2NY6+K3St34l7P/nCDRTSuYtu2R/5oHocaB+XmocddIiyBTePb+avrvQAaNLW7CCr7SWzd674U9PhIK7nQcMllplC1rLwB4s8nd+gURrNZUe7Bkw==", "c"=>"d-7b-f9885f6d-b644-11ef-bb73-e5a54a6b1326:PRN"}
Completed SIRP authentication with status of 409
Could not login to App Store Connect
Please check your credentials and try again.
This could be an issue with App Store Connect,
Please try unsetting the FASTLANE_SESSION environment variable by calling 'unset FASTLANE_SESSION'
(if it is set) and re-run `fastlane spaceauth`

Exception type: RuntimeError

Looking for related GitHub issues on fastlane/fastlane...
Search query: Although response from Apple indicated activated Two-step Verification or Two-factor Authentication, spaceship didn't know how to handle this response: {"phoneNumber"=>{"numberWithDialCode"=>"+1 (•••) •••-••08", "nonFTEU"=>true, "pushMode"=>"voice", "obfuscatedNumber"=>"(•••) •••-••08", "lastTwoDigits"=>"08", "id"=>2}, "securityCode"=>{"length"=>6, "tooManyCodesSent"=>false, "tooManyCodesValidated"=>false, "securityCodeLocked"=>false, "securityCodeCooldown"=>false}, "mode"=>"voice", "type"=>"verification", "authenticationType"=>"hsa2", "noTrustedDevices"=>true, "autoVerified"=>false, "showAutoVerificationUI"=>false, "hideSendSMSCodeOption"=>false, "supervisedChangePasswordFlow"=>false, "enableNonFTEU"=>false, "hsa2Account"=>true, "restrictedAccount"=>false, "supportsRecovery"=>true, "managedAccount"=>false, "serviceErrors"=>[{"code"=>"-28248", "title"=>"Verification Failed", "message"=>"Verification codes can’t be sent to this phone number at this time. Please try again later.", "suppressDismissal"=>false}]}

URL: https://api.github.com/search/issues?q=Although%20response%20from%20Apple%20indicated%20activated%20Two-step%20Verification%20or%20Two-factor%20Authentication%2C%20spaceship%20didn%27t%20know%20how%20to%20handle%20this%20response%3A%20%7B%22phoneNumber%22%3D%3E%7B%22numberWithDialCode%22%3D%3E%22%2B1%20%28%E2%80%A2%E2%80%A2%E2%80%A2%29%20%E2%80%A2%E2%80%A2%E2%80%A2-%E2%80%A2%E2%80%A208%22%2C%20%22nonFTEU%22%3D%3Etrue%2C%20%22pushMode%22%3D%3E%22voice%22%2C%20%22obfuscatedNumber%22%3D%3E%22%28%E2%80%A2%E2%80%A2%E2%80%A2%29%20%E2%80%A2%E2%80%A2%E2%80%A2-%E2%80%A2%E2%80%A208%22%2C%20%22lastTwoDigits%22%3D%3E%2208%22%2C%20%22id%22%3D%3E2%7D%2C%20%22securityCode%22%3D%3E%7B%22length%22%3D%3E6%2C%20%22tooManyCodesSent%22%3D%3Efalse%2C%20%22tooManyCodesValidated%22%3D%3Efalse%2C%20%22securityCodeLocked%22%3D%3Efalse%2C%20%22securityCodeCooldown%22%3D%3Efalse%7D%2C%20%22mode%22%3D%3E%22voice%22%2C%20%22type%22%3D%3E%22verification%22%2C%20%22authenticationType%22%3D%3E%22hsa2%22%2C%20%22noTrustedDevices%22%3D%3Etrue%2C%20%22autoVerified%22%3D%3Efalse%2C%20%22showAutoVerificationUI%22%3D%3Efalse%2C%20%22hideSendSMSCodeOption%22%3D%3Efalse%2C%20%22supervisedChangePasswordFlow%22%3D%3Efalse%2C%20%22enableNonFTEU%22%3D%3Efalse%2C%20%22hsa2Account%22%3D%3Etrue%2C%20%22restrictedAccount%22%3D%3Efalse%2C%20%22supportsRecovery%22%3D%3Etrue%2C%20%22managedAccount%22%3D%3Efalse%2C%20%22serviceErrors%22%3D%3E%5B%7B%22code%22%3D%3E%22-28248%22%2C%20%22title%22%3D%3E%22Verification%20Failed%22%2C%20%22message%22%3D%3E%22Verification%20codes%20can%E2%80%99t%20be%20sent%20to%20this%20phone%20number%20at%20this%20time.%20Please%20try%20again%20later.%22%2C%20%22suppressDismissal%22%3D%3Efalse%7D%5D%7D+repo:fastlane/fastlane
ERROR [2024-12-09 07:48:06.04]: Error finding relevant GitHub issues: undefined method `map' for nil
bundler: failed to load command: fastlane (/opt/homebrew/lib/ruby/gems/3.3.0/bin/fastlane)
/opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/two_step_or_factor_client.rb:23:in `handle_two_step_or_factor': [!] Although response from Apple indicated activated Two-step Verification or Two-factor Authentication, spaceship didn't know how to handle this response: {"phoneNumber"=>{"numberWithDialCode"=>"+1 (•••) •••-••08", "nonFTEU"=>true, "pushMode"=>"voice", "obfuscatedNumber"=>"(•••) •••-••08", "lastTwoDigits"=>"08", "id"=>2}, "securityCode"=>{"length"=>6, "tooManyCodesSent"=>false, "tooManyCodesValidated"=>false, "securityCodeLocked"=>false, "securityCodeCooldown"=>false}, "mode"=>"voice", "type"=>"verification", "authenticationType"=>"hsa2", "noTrustedDevices"=>true, "autoVerified"=>false, "showAutoVerificationUI"=>false, "hideSendSMSCodeOption"=>false, "supervisedChangePasswordFlow"=>false, "enableNonFTEU"=>false, "hsa2Account"=>true, "restrictedAccount"=>false, "supportsRecovery"=>true, "managedAccount"=>false, "serviceErrors"=>[{"code"=>"-28248", "title"=>"Verification Failed", "message"=>"Verification codes can’t be sent to this phone number at this time. Please try again later.", "suppressDismissal"=>false}]} (RuntimeError)
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/client.rb:591:in `send_shared_login_request'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/tunes/tunes_client.rb:130:in `send_login_request'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/client.rb:955:in `do_login'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/client.rb:394:in `login'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/client.rb:355:in `login'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/tunes/spaceship.rb:24:in `login'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/spaceauth_runner.rb:20:in `run'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/commands_generator.rb:46:in `block (2 levels) in run'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:124:in `run!'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/commands_generator.rb:52:in `run'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/spaceship/lib/spaceship/commands_generator.rb:15:in `start'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/fastlane/lib/fastlane/cli_tools_distributor.rb:115:in `take_off'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bundler/gems/fastlane-1efc83769499/bin/fastlane:23:in `<top (required)>'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bin/fastlane:25:in `load'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bin/fastlane:25:in `<top (required)>'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/cli/exec.rb:58:in `load'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/cli/exec.rb:58:in `kernel_load'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/cli/exec.rb:23:in `run'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/cli.rb:484:in `exec'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/cli.rb:31:in `dispatch'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/cli.rb:25:in `start'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/exe/bundle:48:in `block in <top (required)>'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/lib/bundler/friendly_errors.rb:103:in `with_friendly_errors'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/bundler-2.3.7/exe/bundle:36:in `<top (required)>'
	from /opt/homebrew/lib/ruby/gems/3.2.0/bin/bundle:25:in `load'
	from /opt/homebrew/lib/ruby/gems/3.2.0/bin/bundle:25:in `<main>'

Not sure if there's any expo/eas users here, but I'm running into the same issue when trying to sign in to my Apple account using any eas services like build, credentials, etc. I'm guessing it uses fastlane under the hood?

@joshdholtz or @snatchev Any insights here? Since you had most experience on this with the latest PR

response from https://idmsa.apple.com/appleauth/auth/verify/phone
now contains this
  "trustedPhoneNumber": {
    "numberWithDialCode": "+1 (•••) •••-••20",
    "nonFTEU": false,
    "pushMode": "sms",
    "obfuscatedNumber": "(•••) •••-••20",
    "lastTwoDigits": "20",
    "id": 1
  }

in fastlane i see a sample of
    "trustedPhoneNumber": {
        "numberWithDialCode": "+49 •••• •••••85",
        "pushMode": "voice",
        "obfuscatedNumber": "•••• •••••85",
        "id": 1
    }

which doesnt match entirely

Expo/EAS maintainer here 👋
Use device instead of sms for 2fa as a temporary workaround. The new breaking Apple server changes only seem to apply to the /appleauth/auth/verify/phone endpoint. This is the endpoint that sends an SMS to a phone.
You can only send four codes every one hour before getting rate limited, making this particularly challenging to decipher. It also appears to be geotagged, and primarily targeting US-based phone numbers.

response from https://idmsa.apple.com/appleauth/auth/verify/phone
now contains this
  "trustedPhoneNumber": {
    "numberWithDialCode": "+1 (•••) •••-••20",
    "nonFTEU": false,
    "pushMode": "sms",
    "obfuscatedNumber": "(•••) •••-••20",
    "lastTwoDigits": "20",
    "id": 1
  }

in fastlane i see a sample of
    "trustedPhoneNumber": {
        "numberWithDialCode": "+49 •••• •••••85",
        "pushMode": "voice",
        "obfuscatedNumber": "•••• •••••85",
        "id": 1
    }

which doesnt match entirely

NVM This is because we are hitting apple's error state...
{
  "phoneNumber": {
    "numberWithDialCode": "+1 (•••) •••-••08",
    "nonFTEU": true,
    "pushMode": "voice",
    "obfuscatedNumber": "(•••) •••-••08",
    "lastTwoDigits": "08",
    "id": 2
  },
  "securityCode": {
    "length": 6,
    "tooManyCodesSent": false,
    "tooManyCodesValidated": false,
    "securityCodeLocked": false,
    "securityCodeCooldown": false
  },
  "mode": "voice",
  "type": "verification",
  "authenticationType": "hsa2",
  "autoVerified": false,
  "showAutoVerificationUI": false,
  "hideSendSMSCodeOption": false,
  "supervisedChangePasswordFlow": false,
  "enableNonFTEU": false,
  "hsa2Account": true,
  "restrictedAccount": false,
  "supportsRecovery": true,
  "managedAccount": false,
  "serviceErrors": [
    {
      "code": "-28248",
      "title": "Verification Failed",
      "message": "Verification codes can’t be sent to this phone number at this time. Please try again later.",
      "suppressDismissal": false
    }
  ]
}

Hopefully there is a new path to trigger the 2FA from or a new header or cookie to add... but I haven't found anything yet
GET /appleauth/auth HTTP/1.1
User-Agent: Spaceship 2.225.0
X-Csrf-Itc: itc
X-Apple-Id-Session-Id: 90FA52C5AA3CA6C3E317FB842AA751D0B8409CD6E107ADC2FE749404C8ECACDA82F3C3D3B2AF34F7381A5C551EBF81A109236EB9CD045355E1F37BE115CF64D267D9329B1A26C1867B16EED1A69473EC4C6959F22BC8E622F98CD43F26163EEE8D81C9899BC59142CCD51FAEAE74D3FC29BF5D3E18A13BBF
X-Apple-Widget-Key: e0b80c3bf78523bfe80974d320935bfa30add02e1bff88ec2166c6bd5a706c42
Accept: application/json
Scnt: AAAA-jkwRkE1MkM1QUEzQ0E2QzNFMzE3RkI4NDJBQTc1MUQwQjg0MDlDRDZFMTA3QURDMkZFNzQ5NDA0QzhFQ0FDREE4MkYzQzNEM0IyQUYzNEY3MzgxQTVDNTUxRUJGODFBMTA5MjM2RUI5Q0QwNDUzNTVFMUYzN0JFMTE1Q0Y2NEQyNjdEOTMyOUIxQTI2QzE4NjdCMTZFRUQxQTY5NDczRUM0QzY5NTlGMjJCQzhFNjIyRjk4Q0Q0M0YyNjE2M0VFRThEODFDOTg5OUJDNTkxNDJDQ0Q1MUZBRUFFNzREM0ZDMjlCRjVEM0UxOEExM0JCRnwxAAABk60GkO95UCpp77Plba7xVX4itqHSsvH8nIITGx_3bVuxkHIE0zZPewNJG0JBABCZBqoZcg_qyQ_9_gCH57G8ifBtP8Wi7NDgsqvfpJauWwvL5UJjTA
Cookie: aasp=90FA52C5AA3CA6C3E317FB842AA751D0B8409CD6E107ADC2FE749404C8ECACDA82F3C3D3B2AF34F7381A5C551EBF81A109236EB9CD045355E1F37BE115CF64D267D9329B1A26C1867B16EED1A69473EC4C6959F22BC8E622F98CD43F26163EEE8D81C9899BC59142CCD51FAEAE74D3FC29BF5D3E18A13BBF; dslang=US-EN; site=USA
Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3
Host: idmsa.apple.com

I am able to rebuild the fastlane cookies by hand by scraping it from the websites. Put now they  expire after 30 minutes due to a change to cookie dqsid. I don't know why the fastlane process always fails the 2FA portion. They might be using new keys for security reason to generate the 2FA request, looking for new headers, etc.

For all those looking for an emergency work around.
When you use Spaceauth to get your 2FA it generates this text.
'---\n- !ruby/object:HTTP::Cookie\n  name: myacinfo\n  value: DAWTKNV3\n  domain: apple.com\n  for_domain: true\n  path: "/"\n  secure: true\n  httponly: true\n  expires:\n  max_age:\n  created_at: 2024-10-30 14:48:33.618229000 -04:00\n  accessed_at: 2024-10-30 14:48:33.623605000 -04:00\n- !ruby/object:HTTP::Cookie\n  name: DES5ff962cf2f2890a9eec8ede27c03c67fb\n  value: HSARMTKNSRVXWFla3/d\n  domain: idmsa.apple.com\n  for_domain: true\n  path: "/"\n  secure: true\n  httponly: true\n  expires:\n  max_age: 2592000\n  created_at: &1 2024-10-30 14:48:33.618063000 -04:00\n  accessed_at: *1\n- !ruby/object:HTTP::Cookie\n  name: dqsid\n  value: eyJ0eXAiOiJKV1Q\n  domain: appstoreconnect.apple.com\n  for_domain: false\n  path: "/"\n  secure: true\n  httponly: true\n  expires:\n  max_age: 1800\n  created_at: &2 2024-10-30 14:48:34.267396000 -04:00\n  accessed_at: *2\n'
You use this for all your automation systems.
Well you can go into your Chrome Browser, log into apple at appstoreconnect.apple.com and then inspect your cookies. You will find these 3 keys and you can build this by hand. If done correctly your tokens will last 30 minute. The key for the idmsa.apple.com will require you to go to that website and stop the page before it redirects you. The cookie name on that one might change, grab the one that expires in 1 month, starts with DES5 and the value starts with HSAR.
I removed most of the data from my keys up top but it should give you a pretty decent idea of what you need to do.

@TylerRayKillian that makes sense and I was hoping that such a workaround was possible. I'd love to use this workaround as i only need to be able to run produce from time to time. However, I'm a bit confused on how exactly to build the Fastlane session by hand. I was able to find the name: DES5 and name: dqsid cookies but wasn't seeing one for name: myacinfo. Additionally, I'm unsure as to what other keys within each cookie need to be manually updated in order for this to work, specifically keys such as created_at and accessed_at.
Could you provide any more details on this workaround? Happy to contact you elsewhere for more assistance!

I have a very similar situation as @im-jersh:

My organization provides whitelabel applications of our product to our customers so being able to automate the creation of apps in the dev portal and ASC is paramount.

And for legality concerns, we do not have login access for each Account Holder for each Apple Developer Account. So each of these approaches are off the table:
❌ API Key-based approach
❌ Apple Business Manager
❌ Manually generated 30-minute key/token
If anyone knows of a different workaround, I'm all ears. Right now, it's looking like a Jelly of the Month club kind of Christmas.

If it can help, it doesn't affect all accounts. The vast majority of accounts continue to be ok but some return this error.

I ran into this issue using SMS for 2FA. The fix for me was to log into the Apple account on any iOS device (I used an old iPad) and then the verification code was sent to that device. Once I input that code, everything worked as normal. And I've been logged in using the new token for several days.

I'm experiencing this same issue. I need to add Siri capabilities to the Signing & Capabilities of our app and upon running fastlane match we are hitting this error.

I just pass this issue 😭
In my case, the error detail contains "noTrustedDevices"=>true. If you have too, hear is what I do

Note: You can check trusted status by Login account.apple.com if you can. Select your device in Devices menu. Check the Trusted device status.

Go to /System Settings.../Internet Accounts
Add your account here. This step will add your device to Trusted Device, you can check again at account.apple.com
Clear Fastlane account and run your lane again

It allow you receive code on your Mac instead of your phone number.

+1
Although is anybody using a service provider phone number and facing the same issue? (Azure or any other cloud SP)

Having a trusted device to get the code is a workaround but it's not the main issue, on my comment above there is no trusted devices but one is working.

I also encountered this issue when logging in with my registered Apple ID, whether manually or through network protocols or mobile login. Some people have already solved this problem and seem to be using third-party web login. Apple ID only requires a 6-digit verification code to log in to any device or webpage, but at least I haven't found it yet. I don't know who solved this problem, but if someone solves it, I can purchase this method

My issue was fixed after deleting the ~/.app-store folder. For me, on Windows, C:/Users/[me]/.app-store/.

I just solved this issue 😭 In my case, the error detail contains "noTrustedDevices" => true. If you have the same issue, here is what I did:

Note: You can check the trusted status by logging in to account.apple.com if possible. Select your device in the Devices menu and check the trusted device status.

Go to /System Settings.../Internet Accounts
Add your account here. This step will add your device to Trusted Device, you can check again at account.apple.com
Clear Fastlane account and run your lane again

It allow you receive code on your Mac instead of your phone number.

What do you mean by “clear fastlane account”? How is that performed?

My colleagues and I ran into this issue around 2024-12-27. On 2024-12-30 2FA started working again, but it's unclear why. Some things I tried before 2FA started working again:

Try using app_store_connect_api_key for auth (this isn't supported by get_push_certificate though, which is where 2FA was failing)
Add another Trusted Phone Number on account.apple.com. This added another step during Fastlane to choose the phone number for 2FA. Initially both the original, and newly added phone numbers still failed. After a couple hours, fastlane stopped asking for me to choose the number and authentication started succeeding
Sign into account.apple.com using both the original and new trusted phone numbers.

I'm not sure why any of these steps would have "fixed" 2FA for get_push_certificate; just trying to catalogue what I did before the build started working again.


Chapter4/homework/3

https://leetcode.com/problems/max-increase-to-keep-city-skyline/
So I picked this problem to solve sounded fun and proved fun.
TDD is very hard for me, my thinking automatically goes the other way around.
I don't have a problem making tests, but test first and then make something harder.
I tried to make use of SOLID as much as possible. If you could give some hints where to improve on this that would be great.
probably made some naming mistakes. should have used more interfaces. because right now its tightly coupled. But I think with such a small project its hard to see where to use it and where not.

Also please describe what you did.

I know my Way of thinking is not TDD and its hard for me to think that way. Here is how i went through it:
I started off thinking i need a Object to hold Buildings and a SkyLine.
so i started creating a City and a SkyLine Model.
Then i finished the SkyLine model and following tests to see if it works.
Then the Calculation for Maximum a city can grow without changing the SkyLine followed by the tests.
Finally added the last class to calculate the maximum amount a city could grow followed by the tests.
So no TDD used TBH. I should have Created the tests sooner and i do see that now. I should have created the tests as soon as I knew what I was going to return. that's what I'll do next time.
Any comments on SOLID ?

I know my Way of thinking is not TDD and its hard for me to think that way. Here is how i went through it:
I started off thinking i need a Object to hold Buildings and a SkyLine.
so i started creating a City and a SkyLine Model.
Then i finished the SkyLine model and following tests to see if it works.
Then the Calculation for Maximum a city can grow without changing the SkyLine followed by the tests.
Finally added the last class to calculate the maximum amount a city could grow followed by the tests.
So no TDD used TBH. I should have Created the tests sooner and i do see that now. I should have created the tests as soon as I knew what I was going to return. that's what I'll do next time.
Any comments on SOLID ?

A better way of thinking would be to pretend you don't know anything and just:
I am required A so I will do write a test that would verify if it is met.
I know that building must be in a range of X and Y. I know that if a city has any invalid building, creating it fails.
What is a city?

It's a collection of buildings
What is a building?
It's just an int.
How do I feed buildings to city?
I pass them via ctor.

Based on those answers:
int[] buildings = ...;

Action action = () => new City(building);

action.Should().Throw...

City does not exist yet. Proceed with creating a class City, a ctor that takes int[].
Run tests.
Test will fail because there is no validation yet. Add validaiton.
Run tests.
Tests will pass.
Think about edge cases. Less than minum, more than minimum.
Two cases, same invocation- means you need to move it to parameters.
Add another case.
Run tests.
Fix or be done.
Refactor.
Run tests.
Fix or be done.

Thanks for explaining! seems doable.

Done 👍


don't try to use ~/Downloads if it doesn't exist

ATM things like model help fail if ~/Downloads doesn't exist, so this fixes things to just use /tmp if ~/Downloads doesn't exist. For snaps, which I don't use, I'm not sure how they deal with that folder not existing. Perhaps they use /etc/xdg/user-dirs.defaults, but not worth getting too fancy until it's needed.

Ok this looks good thanks! :+1: Yeah unfortunately not really sure the best way to deal with the snap issue without doing some subprocess hack.


data-scroll-header doesn't work as expected

Me again :P
I'm using smoothScroll with Gumshoe like this:
smoothScroll.init({
	offset: 40,
	updateURL: false
});

gumshoe.init({
	offset: 41
});

And in my fixed header I put both data-gumshoe-header and data-scroll-header.
Am I doing something wrong?
The offset seems to work just fine. What it doesn't seem to work is the data-scroll-header. It doesn't seem to apply the proper offset from the fixed header's height.

@hiulit Do you mind sharing a demo link?

Oh, shoot! I'm sorry, I'm not using that header anymore...
I guess it was something I did wrong if no one has complained about it


React18 compatibility

Hey, all! I'm opening this PR because I came across the errors reported on #153 and the changes on this PR made it work on my React18 + NextJS project. I have no idea why it worked, but I have patched these changes in my application and nothing broke.
All I know is that I am using it correctly (per docs), along with React 18 + NextJS:
<Truncate lines={width < breakpoints.md ? 4 : 2}>
    A text as string, as you can see, no text formatting, no html, markdown or any formatting language here.
</Truncate>

In case anyone is interested in moving this piece of code forward in this library, go ahead! cc @pablosichert

@marcelovicentegc  Should the reference to node in package.json be bumped as well?


fix Remove improper check for journalId

Introduced by  https://github.com/apache/doris/pull/24259

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Migrate vapor pressure batch9

Sir @maneetgoyal  can this be merged?

Sir @maneetgoyal can this be merged?

Yeah go ahead


Update to secp 0.26 and secp-sys 0.8

This PR updates the rust-secp256k1(-sys) dependencies to latest released ones. I tried to mimic what was done upstream. Regarding the trait implementations (Eq, PartialEq,...), since the sys types in this crate don't seem to have serialize functions I felt like it was ok to just derive then but please correct me if that's wrong.

I had to implement the traits to make it work with 1.41.1 but not sure what is causing the CI failures. I'll have a look at it again but if someone has a suggestion let me know.

I'm quite confused, unless I'm missing something it looks like actions on the same commit passed in my forked repo:
https://github.com/p2pderivatives/rust-secp256k1-zkp/actions/runs/3781248443

Investigating the CI failure I found that for some reason it only happens on recent version of OSX (I've updated recently and before the update I could not reproduce the issue, now I can). The issue also seem to happen on master and also on rust-secp256k1, so I'm pretty confident it's not introduced by this PR.

CI failure seems to be same as https://github.com/rust-pcap/pcap/issues/280 (to take an example from a random project). Apparently "rust 1.41 does not work on macos >= 12". So we will just need to adjust CI.
@Tibo-lg could you add a commit which changes CI to not test 1.41 on Mac?

@Tibo-lg could you add a commit which changes CI to not test 1.41 on Mac?

@apoelstra Done! I've modified a bit the git action file removing the target field which seemed unused, making it easier to exclude 1.41 on macos, but I hope that doesn't break anything.
Thanks for checking the PR!

Looks good. I'll ACK and merge this since it fixes CI.
But cc @jonasnick is there any specific reason we had the target field here? Was it to test different endianness or anything?

I don't remember. It seems redundant.


How to bypass recaptcha ?

Hey, can someone help me that how can I bypass Recaptcha or how to perform it manually between automated script ?

Issue #473 might be relevant to you.


ST-3750: Various native hooks that allow us to rebuild the local video track with a different name.  Enhanced logging.

I know this is merged already, but I'm curious to see the app code that calls this to understand how it's being used?
Also, are we planning to submit this upstream? It'd be nice to keep the delta between our fork and upstream as small as possible.

@garyp here is a link: https://github.com/streem/streem-app/pull/13699/files#diff-9aa940034eda3a4f1c69c685f2cbaaa4819ddd0cd5bd9b6f835d1c94fccfccdaR114-R131
Not sure about upstream PR... it doesn't feel like something that the author would want in the general codebase, but if we can optimize it so that it doesn't feel so forced, the API may be cleaner and something we could submit.  As I put in the comment in the link above, this is the first version of getting it working, but it can almost certainly be optimized.

Oh yeah, now that I see the app side, I agree that this seems a bit too ugly to upstream just yet. But I assume the need we have that drove this work is not Streem-specific. So it might be at least worthwhile to open a bug upstream and point at this PR as a proof-of-concept solution. The upstream author might have suggestions for how to do this better, and even this current version could be a useful reference for others experiencing the same problem as us.
Also, it seems like the fix to make stopLocalVideo() async would be a useful contribution upstream even without the other changes in this PR.


Mac 图标异常

Describe the bug
A clear and concise description of what the bug is.

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Mac OS
Version 12.0.1

Additional context
Add any other context about the problem here.

desktop暂时没有投入，后面重点投入Vscode插件


PowerMock is not finding all inherited methods on ArrayList

From<EMAIL_ADDRESS>on August 13, 2014 00:59:20
What steps will reproduce the problem? public static void main(String[] args) {
	List<String> test = new ArrayList<String>();
	Method[] methods = WhiteboxImpl.getAllMethods(ArrayList.class);
	for(int i = 0; i \< methods.length; i++) {

		if(methods[i].getName().equals("stream")) {
			System.out.println("Stream method found with whitebox");
		}
	}

	Class obj = test.getClass();
	Method[] reflectMethods = obj.getMethods();
	for(int i = 0; i \< reflectMethods.length; i++) {

		if(reflectMethods[i].getName().equals("stream")) {
			System.out.println("Stream method found with regular reflect");
		}
	}
} What is the expected output? What do you see instead? I expect both for loops to print their messages. What version of the product are you using? On what operating system? PowerMock 1.5.5 on windows 7 64bit Please provide any additional information below. The code example above is breaking the problem down to where I could see the problem originating. Our code uses the stream() method on an array list to do some filtering, the test is a simple test that doesn't specifically mock the array list, the class is in the prepare for test annotation (to support some of the other tests).

We are trying to update our code from JDK 7 to 8 and can't run our unit tests when we try to use some of the new JDK8 features like streams.
Original issue: http://code.google.com/p/powermock/issues/detail?id=512

From<EMAIL_ADDRESS>on August 12, 2014 16:02:46
I think this is urgent since we can't seem to run any tests that use the new JDK 8 features.
If this isn't an issue please let me know how to fix our test so they will run.

From<EMAIL_ADDRESS>on August 13, 2014 10:16:17
I've submitted a patch/pull request: https://github.com/jayway/powermock/pull/3

From<EMAIL_ADDRESS>on August 28, 2014 04:28:02
Status: Duplicate
Mergedinto: 513


Add versioned tags to docker hub

Hey there, we deployed ClearML with agents running on our GPU machines and we love it, works really well!
Currently there are only :latest images available on docker hub.
https://hub.docker.com/r/allegroai/clearml-agent-services/tags
https://hub.docker.com/r/allegroai/clearml-agent/tags
It would be nice if for each release version a separate tag is pushed with that version (example :1.1.1) so our deployment of ClearML will be more robust.
Thanks!

Hi @nielstenboom,

Hey there, we deployed ClearML with agents running on our GPU machines and we love it, works really well!

Thanks!

It would be nice if for each release version a separate tag is pushed with that version (example :1.1.1) so our deployment of ClearML will be more robust.

While we do our best to make sure the releases are stable, you're absolutely right - we'll update our deployment automation to make sure version tags are pushed as well 🙂
Thanks for the feedback!


TypeError: this.api.isAuthenticated is not a function when opening Media Manager

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!
Hi
After a fresh install on Vercel of the Cloud Starter (via https://app.tina.io/projects/starter) I can edit posts fine. Clicking on the Media Manager results in the attached error.
Auth seems to work fine.
Reproduction
https://tina-cloud-starter-fap3.vercel.app/admin#/~ and click Media Manager in the side panel.
Have tried on Firefox and Chrome
Steps to reproduce

System Info
See attached image.

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

Try updating to the latest tinacms dependency in your project

Hi @kldavis4,
Just a quick FYI, I was trialling the TinaCMS cloud product and deployed from the tina.io website into a repo using the cloud starter template and I have run into this same issue.   I'm not running TinaCMS locally.

Upgrade to latest tinacms and @tinacms/cli


Default impl Deserialize/impl Serialize for time::OffsetDateTime is a footgun

A majority of folks using derives for Serialize/Deserialize are likely trying to write REST APIs for json output. There exists a wonderful set of deserializers for RFC3339, ISO 8601, and RFC2822. They work great! Unfortunately if the serde feature is enabled, time will happily provide a default Serialize/Deserialize pair that doesn't follow any of these standards. I can tweak these formats with serde-human-readable, but not specify one of the standards as a default. There doesn't appear to be a way to turn the default impls off.
To me this is a footgun, because it means that if I forget to annotate an instance with #[serde(with = "time::serde::rfc3339")] the dependent code will compile without errors or warnings, and serialize/deserialize into formats I don't expect or intend. The generated code will choke at runtime trying to parse RFC3339 (what most folks use for interop in json these days).
I've tried adding time::OffsetDateTime::deserialize to disallowed-methods in .clippy.toml but Clippy isn't picking it up. <time::OffsetDateTime as serde::de::Deserialize>::deserialize also does not work, likely because of https://github.com/rust-lang/rust-clippy/issues/8581
It feels like we should feature-flag the "default" serde implementation (and potentially add feature flags to default RFC3339 or each of the others), but that's obviously a breaking change. Thoughts?

As you noted, changing the default would be a breaking change. However, it would be permissible to add support for deserializing additional formats, as that's backward compatible. Ultimately, I think what would best serve your purpose would be ensuring the linked clippy issue is resolved.


Automate the setting up of K8s cluster with OpenEBS on Cloud

This issue is to track the development of an automation script (ansible or terraform) that can provision an k8s cluster on the preferred cloud vendor and enable openebs-operator on that cluster. This would require automating the following:

granting of admin privileges to create openebs user
launch openebs-operator
install iscsi-initiator on minion nodes.

The manual steps are detailed here:
https://github.com/openebs/openebs/blob/master/k8s/hyperconverged/tutorial-configure-openebs-gke.md

This solution will be same as #158


Validate full model name in the deprecate model flow

Earlier, the model name was not being validated for the deprecate model action. It was getting validated for all other actions including the unassign and deregister actions (which are variations of the deprecate action).
Resolves https://github.com/iterative/dvc/issues/9821#issuecomment-1755122434

Thanks @tapadipti ! I left a comment + I think we would need a test for this.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Files
Coverage Δ

gto/constants.py
100.00% <ø> (ø)

gto/registry.py
90.61% <100.00%> (+0.03%)
:arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.

Thanks @shcheklein. I've addressed your comments.
For the test, I ran it locally by calling it from a __main__ block. But I'm not sure how to run it without that.
There are more validations to be added. Eg, currently it accepts // in the name, and this is not allowed in the Git ref. I'll work on fixing this as part of https://github.com/iterative/dvc/issues/9821 but it's not within the scope of this PR.

thanks @tapadipti ! it looks good, but it seems we need to fix the test. Please see the checks above.

it seems we need to fix the test. Please see the checks above.

The error message returned by the name validation functions is quite long. So it looks like a new line character (\n) gets added automatically - see the extra \n between Value  and must below:
❌ Invalid value 'a4!'. Only letters, numbers, '_', '-', '/' are allowed. Value \nmust be of len >= 2 and must start and end with a letter or a number.\n
Is there a way to turn off this automatic addition?
I was not adding this \n to my test (coz I wasn't expecting it to get added when running), and locally I didn't see this issue.
To resolve this, I've now added the \n to the error message and to my test. It's passing now.
However, I'm not sure if some other products with dependencies on GTO could break due to this (if they're expecting a string without this \n). cc @iterative/studio

@tapadipti I think it's better to not alter the behavior, but rather fix test to be more lax on comparison. E.g. remove all \n before comparing the result.

@shcheklein I've done this here. All tests passed, so it should be fine.

@shcheklein I’ve tried 2 ways to remove the \n. But it’s not working, coz it seems the \n is being escaped and so the character is \\n. This does not happen locally, so I don’t know how to resolve this. I even tried substituting \\n - as I expected, that does not help either (I've removed that commit). This is the error which needs to be cleaned of the line breaks:
"\u274c Invalid value 'a4!'. Only letters, numbers, '_', '-', '/' are allowed. Value\\nmust be of len >= 2 and must start and end with a letter or a number.\\n"

@tapadipti do you have sense on why is it escaped? what other symbols are escaped?

@tapadipti do you have sense on why is it escaped? what other symbols are escaped?

@shcheklein No, I couldn't figure this out - for some reason the \ in \n is being escaped, so it becomes \\n. When I try locally, a string with \\n prints just \n. And I don't know how to replicate how the complete test suite is being run - I've run individual tests and it works fine. The only character causing me issue is the line break which is getting added in the middle of a line. Without this extra line break, there's no issue coz all the other line breaks are at the same position in both the actual and expected values.

ideally in the long term all of the tests should be updated to work off of a list of expected lines instead of a single hard coded string, and then the check functions would do something like
assert result.stdout.splitlines() == expected_stdout
assert result.stderr.splitlines() == expected_stderr

which will work regardless of platform/line ending, and it will account for commands where the newlines in output are significant

@pmrowla Yes.

Wrapped lines will also be split using the platform specific line ending (which is CRLF on windows and not just LF)

I wish this comment was here yesterday or earlier today. Figured it out the hard way today. Have fixed it by doing replace differently for Windows. Which I don't like. So I'll revert to what you've suggested - which is pretty much what I had here and here. @shcheklein Can you pls confirm you're ok with this - coz you'd earlier suggested I think it's better to not alter the behavior, but rather fix test to be more lax on comparison. E.g. remove all \n before comparing the result.

I think it's better to not alter the behavior, but rather fix test to be more lax on comparison. E.g. remove all \n before comparing the result.

The problem with this is that this is applied to the tests for every GTO command and it strips the line breaks in places where the test behavior is actually significant, i.e. when the expected output is explicitly
To push the changes upstream, run:
    git push origin<EMAIL_ADDRESS>
Stripping/replacing all the line breaks means the test would now pass if the CLI command outputs
To push the changes upstream, run:     git push origin<EMAIL_ADDRESS>

@pmrowla I tried removing the manual line breaks in the exception message, as you suggested. But it's not working - it looks like the space between Value  and must is getting stripped in Windows. See the assertion errors in the test reports for the latest commits.

Summary of error:

When I use your suggested code for the test (in this commit), I get the following mismatch between the actual and expected values.
"\u274c Invalid value 'a4!'. Only letters, numbers, '_', '-', '/' are allowed. Value\\nmust be of len >= 2 and must start and end with a letter or a number.\\n"
"\u274c Invalid value 'a4!'. Only letters, numbers, '_', '-', '/' are allowed. Value \\r\\nmust be of len >= 2 and must start and end with a letter or a number.\\n"
If I use a \n in the test (see this commit), I get the following mismatch:
"\u274c Invalid value 'a4!'. Only letters, numbers, '_', '-', '/' are allowed. Value\\nmust be of len >= 2 and must start and end with a letter or a number.\\n"
"\u274c Invalid value 'a4!'. Only letters, numbers, '_', '-', '/' are allowed. Value \\nmust be of len >= 2 and must start and end with a letter or a number.\\n"

From what I saw yesterday, this (stripping) does not happen in ubuntu and macos, so I can't just remove the space from the expected value (else the test will fail in ubuntu and macos). I can treat Windows differently (similar to how I did here), but imo that's a terrible idea. So my only option now is to revert to adding the manual line break in the exception message (or to improve how the tests are written, which I don't want to make part/dependency of this PR).

Hope this helps and isn't further derailing here, but can you strip only the \r clrf windows-style line endings from the actual output? I don't think we are ever going to intentionally add those into output.

We should just remove this CLI test entirely and test the underlying behavior in test_api instead like
with pytest.raises(ValidationError):
    api.deregister(...)  # call deregister with an invalid name

For now, I'm removing the test. I've created an issue to improve tests, and we can add a test for the deprecate model action with invalid model name there. cc @pmrowla @shcheklein @dberenbaum

@pmrowla Can you ptal at this comment and re-review this PR. I can't merge the PR without you accepting the change.


Saves the answers to component, pipe, etc questions

The answers to questions for component, pipe, etc should not be saved.

Yeah, I just noticed this myself. We need to make it so that .erector is updated only for init.

@gonzofish  This isn't resolved yet.  Need to publish new version of erector-set and then I can update the dependency and pass true into inquire function when calling during initial

Didn't mean to close it...reopened


[New Feature] Add default retry to every /api/ask endpoint to utilize connection pool.

I think we can add default number of retry to each incoming request to /api/ask endpoint. Instead of returning Content-Type: 'application/json' we could return Content-Type: 'text/event-stream'. With this change it might be slightly slower than the original but we would at least try at least 3 times with different agents from connection pool.
For example, proposed change:
/api/ask endpoint content type would be  text/event-stream instead of application/json:
 curl "http://localhost:8080/api/ask" -X POST --header 'Authorization: <API_KEY>' -d '{"content": "Hello world"}'
default minimum retry # is 3.
In this example /api/ask endpoint failed with first two agent and was successful at the third one.
data: retry #1 failed.

data: retry #2 failed.

data: {"message": { ... }, "conversation_id": " ... "}

data: [DONE]

I believe this would utilize the connection pool even better.

The retry functionality has been added to https://github.com/ChatGPT-Hackers/ChatGPT-API-server/tree/dev

I'm still testing it out

There is a bug I don't know how to fix

IMO, you need to use some sort of blocking mechanism, so you can retrieve quickly websockets, which are available at the moment, or just passively wait for any new one to be available.
One way to do that is to use a sort of priority queue, where you will be grading just based on this parameter.
Also, a good feature to have would be to add a number of request, that was already made to a particular connection. I am not aware of exact number of request per hour, that are permitted, but in my testing I have hit some limits within an hour. In this case we don't really want to navigate our requests to this websocket.

I was gonna write a queue system but I'm not quite sure how to implement it correctly. Gin is inherently multi-threaded and there is already a blocking mechanism in place for the connection pool though.

Also, a good feature to have would be to add a number of request, that was already made to a particular connection. I am not aware of exact number of request per hour, that are permitted, but in my testing I have hit some limits within an hour. In this case we don't really want to navigate our requests to this websocket.

Since it is cycling by oldest connection first, each connection should have a similar number of requests. If limits are hit, all existing connections would also be rate limited in the subsequent request.

The error handling can be done on the client side. If you get a message of "error", let it sleep a second or two and then try again. Doing this from the server could clog up the connection and compete with actual requests, introducing additional downtime and errors

if one account was rate limited, we can redirect request to other accounts

Possible. Will consider it.

How about the other one: regularly send fake request to idle connection?

How about the other one: regularly send fake request to idle connection?

I'm not sure whether regulary send fake request will help keeping the connection alive. Ignore me.


[FEATURE REQUEST] LOD Fade

hello dreadpon, thank you very much for making this free addon, its simple 2 use and very useful!!!!!!!!!!
is it possible to add some sort of fade in/fade out effect to minimize LOD popping?? like with visibility range fade transition margins in Godot
maybe it could be some kind of transparency shader (dithered opacity for maximum fps!!) that gradually fades a new LOD in and then fades old LOD out depending on the distance from player (for example 1m for fade in, then 1m for fadeout - all done in a span of 2 meters)

I had a though of adding LOD hysteresis thresholds (which I believe is what you're referring to) while also maybe adding some sort of optional fade shader (as it usually implies having both LODs active at the same time, increasing the load).
Unsure when though.
Hysteresis seems pretty straightforward but fading not so much
If anyone has good material on existing, optimized implementations - I'd like to take a look


r-modules/generate-shell.nix is missing wget

Issue description
Running nix-shell --pure generate-shell.nix and then Rscript generate-r-packages.R cran  > cran-packages.nix.new
Results in a lot of
sh: wget: command not found
sh: wget: command not found
sh: wget: command not found
sh: wget: command not found
sh: wget: command not found

The solution is to include wget in the nativeBuildInputs. I'll take care of this soon!
Steps to reproduce
Given above
Technical details

System: 17.03.git.ecb596b (Gorilla)

It would be great if you could send in a PR for this :) Thanks!

@NeQuissimus Already did :smile: It's the PR that references this issue (#19531). I ran into some difficulty using nix-shell --pure and have been waiting for a response from someone more knowledgeable!

It might be a good idea to fix the missing wget dependency regardless of using nix-shell --pure?


Session token cache is invalidated before its due time

Hi, this is the third time I try to report this but my issue keeps getting closed by a bot. So this time I'm tagging the top 10 contributors here for visibility. Please mark this as a Bug so it doesn't get closed. @satbai @aldoms @jmyersmsft @AlexVTor @zarenner @johnterickson @jiadji aw37 @crmann1 @jotaylo @keithrob —sorry for the inbox spam. 😏

There is error handling code in the plugin that invalidates access tokens in the SessionTokenCache.dat file when an error is observed.
https://github.com/microsoft/artifacts-credprovider/blob/cdc427e8236212b33041b4276961855b39bbe98d/CredentialProvider.Microsoft/RequestHandlers/GetAuthenticationCredentialsRequestHandler.cs#L144-L149
This code is problematic because it is executed for any error, not just authorization errors.
An example could be doing dotnet add package Xyz where Xyz doesn't exist. The result is a Not Found error which then invalidates the token cache because of the lines above.

That would be a bug in NuGet, not artifacts-credprovider. The intent of the IsRetry flag is to tell the credential provider that the previously retrieved credential didn't work, so artifacts-credprovider is doing the right thing by discarding the cached credential and fetching a new one.
NuGet takes bugs at https://github.com/NuGet/Home/issues


Adds DirectAdd function to roaring.Bitmap

Overview
Pull request checklist

[ ] I have read the contributing guide.
[ ] I have agreed to the Contributor License Agreement.
[ ] I have updated the documentation.
[ ] I have resolved any merge conflicts.
[x] I have included tests that cover my changes.
[x] All new and existing tests pass.

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.

I think this PR is the place to do it honestly... no point in adding and then removing a new method. Do you have gorename working? I can do it in one command and push if that's easier.


SSL

Hi,
When I change the grafana server protocol of a working setup from http to https I can't load my graphs anymore. Do I have to add a parameter to plugin.json ?
Best regards,
Trois-Six

Do you use chrome?

yes !

Le 29 sept. 2015 à 06:00, Darryn van Tonder<EMAIL_ADDRESS>a écrit :
Do you use chrome?
—
Reply to this email directly or view it on GitHub https://github.com/alexanderzobnin/grafana-zabbix/issues/87#issuecomment-143937750.

@darrynv Is this issue in chrome only?

Would putting Grafana behind a reverse proxy like nginx solve this for you?

Hi,
I didn't find time to try it back with another browser, but I am going to.
@slick666 : yes, it could be a solution.
Trois Six

I have exactly the same but upon further investigation it's the datasource that appears to break rather than just the graphing.  The test connection doesn't even work.

Can anyone provide log of network requests from development tools?

I've just handed my instance over for some other colleagues to trial (using http). I'll try to provide some logs when they've finished but may well be a week or two.

I currently use grafana-zabbix with grafana and zabbix on HTTPS without issue.
I had an issue when I add Elasticsearch as a datasource and this one is not on https for now. I change the connection type to proxy and it works.

On Oct 13, 2015, at 9:07 AM, trevorx<EMAIL_ADDRESS>wrote:
I've just handed my instance over for some other colleagues to trial (using http). I'll try to provide some logs when they've finished but may well be a week or two.
—
Reply to this email directly or view it on GitHub https://github.com/alexanderzobnin/grafana-zabbix/issues/87#issuecomment-147709047.

No issues with graphana 2.6 + zabbix 2.2 over https and grafan connecting to it in proxy mode.


Execute  goal in the corresponding example instead of wrong  goal

Example of use-releases goal in documentation by mistake execute unlock-snapshot goal.
This patch correct the command to execute in documentation.

Unfortunately fixed by #118 many thanks for your help...


site.archives template variable not available in archive layout

I’m attempting to create an archives list in a sidebar. The sidebar should appear on multiple pages, including the archive page itself. Unfortunately, the site.archives template variable doesn’t seem to be available in the archive-specified layout.
Here’s a basic example to reproduce:
_config.yml:
jekyll-archives
  enabled:
    - month
  layout: archive
  permalinks:
    month: "/archives/:year/:month/"

_layouts/archive.html:

---
layout: default

---

Archives

  {% assign months = site.archives | where:"type", "month" %}
  {% for month in months %}

      {{ month.posts[0].date | date:"%b %Y" }}

  {% endfor %}

OS: OS X 10.11.4
Ruby:  2.3.0p0
jekyll: 3.0.5
jekyll-archives: 2.1.0

Should have noted above: months is empty in the above example. Therefore, there are no archive list items are output. I can put together a more detailed example if needed.

Thanks for the code!

I have a similar issue where a site environment variable is specified (in a generator plugin) and available throughout the site, except in the archive templates. Are we able to specify the ordering of he generators invoked by Jekyll, since jekyll-archives is possibly automatically invoked before my other generator plugin as specified a site variable?


Bluetooth: Host: SMP: Verify public key before usage

Add a separate test for public key validity. This needs to be done synchronously so that a command status with a failure code can be emitted.
Fixes #80218

#AutoPTS run zephyr SM/PER/KDU/BI-04-C

AutoPTS Bot results:
Failed tests (1)SM      SM/PER/KDU/BI-04-C              FAIL

#AutoPTS run zephyr SM/PER/KDU/BI-04-C

Scheduled PR https://github.com/zephyrproject-rtos/zephyr/pull/82741#issuecomment-2528532867, board: nrf52, estimated start time: 17:16:14, test case count: 1, estimated duration: 0:00:34Test cases to be runSM/PER/KDU/BI-04-C

AutoPTS Bot results:
No failed test found.
Successful tests (1)SM      SM/PER/KDU/BI-04-C              PASS

@jhedberg haven't looked closely but it looks like this could have been introducing the following test failures in main? https://github.com/zephyrproject-rtos/zephyr/actions/runs/12284474398/job/34280327763#step:11:1
Could you have a look? Thanks!

@kartben if a quick fix is required, the only solution I can offer is to remove this test case, since I'm not familiar with how these unit_testing tests are constructed and how/where the mocks are done. I can se that there's code under tests/bluetooth/host/crypto including psa/crypto.h, and some kind of mocks under tests/bluetooth/host/crypto/mocks, but I'm not sure how to translate this to what's needed under tests/bluetooth/host/ecc (which is where the failing tests are). @ahmedmoheb-nordic since you seem to be the author of these unit tests, could you please look into it? Thanks.

FWIW, I did try this:
diff --git a/tests/bluetooth/host/ecc/CMakeLists.txt b/tests/bluetooth/host/ecc/CMakeLists.txt
index 4f3af9f8160..939ee1b26f4 100644
--- a/tests/bluetooth/host/ecc/CMakeLists.txt
+++ b/tests/bluetooth/host/ecc/CMakeLists.txt
@@ -19,6 +19,7 @@ target_include_directories(mocks PUBLIC
   ${ZEPHYR_BASE}/subsys/bluetooth/host
   ${ZEPHYR_BASE}/tests/bluetooth/host
   ${ZEPHYR_BASE}/tests/bluetooth/host/ecc/mocks
+  ${ZEPHYR_MBEDTLS_MODULE_DIR}/include
 )

 target_link_libraries(mocks PRIVATE test_interface)

However, that still leaves some other build errors.

Short term solution to remove the problematic tests: #82924
FWIW, while the missing include lookup path (mentioned in https://github.com/zephyrproject-rtos/zephyr/pull/82741#issuecomment-2538608571) should fix the issue introduced by this PR, it seems that there was other breakage already there before this PR (related to devicetree includes).


Local URL Image Library

@osrl on Gitter:

Hello everyone. Is there an image library that supports loading local images (which is downloaded on disk)? Something like ImageLoader(NSURL(string: "file://....")) . I've checked all Image Libraries, none of them mentions about local images. So I didn't try them before asking here.

@dkhamsing do you know any lib for that?

hey buddy nope :-(

@goktugyil can we do an extension for that?

https://github.com/goktugyil/EZSwiftExtensions/blob/master/Sources/NSURLExtensions.swift


Distributed Scan implementation

Hello @abhijithneilabraham! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file talos/__init__.py:

Line 12:1: E402 module level import not at top of file
Line 19:1: E402 module level import not at top of file

In the file talos/commands/distribute.py:

Line 8:1: E302 expected 2 blank lines, found 0
Line 14:1: W293 blank line contains whitespace
Line 15:17: E124 closing bracket does not match visual indentation
Line 16:9: E265 block comment should start with '# '
Line 18:25: E225 missing whitespace around operator
Line 19:23: E225 missing whitespace around operator
Line 20:30: E225 missing whitespace around operator
Line 24:20: E225 missing whitespace around operator
Line 26:11: E111 indentation is not a multiple of four
Line 28:5: E301 expected 1 blank line, found 0
Line 28:26: E231 missing whitespace after ','
Line 29:10: E225 missing whitespace around operator
Line 30:14: E225 missing whitespace around operator
Line 31:9: E306 expected 1 blank line before a nested definition, found 0
Line 31:26: E231 missing whitespace after ','
Line 32:11: E111 indentation is not a multiple of four
Line 33:14: E231 missing whitespace after ','
Line 35:28: E225 missing whitespace around operator
Line 39:16: E225 missing whitespace around operator
Line 40:16: E225 missing whitespace around operator
Line 51:5: E301 expected 1 blank line, found 0
Line 51:21: E231 missing whitespace after ','
Line 51:28: E231 missing whitespace after ','
Line 57:14: E231 missing whitespace after ','
Line 57:21: E231 missing whitespace after ','
Line 57:80: E501 line too long (106 > 79 characters)
Line 57:98: E231 missing whitespace after ','
Line 65:5: E301 expected 1 blank line, found 0
Line 65:23: E231 missing whitespace after ','
Line 66:59: E231 missing whitespace after ','
Line 68:29: E231 missing whitespace after ','
Line 69:16: E225 missing whitespace around operator
Line 70:17: E225 missing whitespace around operator
Line 71:16: E225 missing whitespace around operator
Line 72:1: W293 blank line contains whitespace
Line 74:21: E225 missing whitespace around operator
Line 75:24: E225 missing whitespace around operator
Line 76:19: E225 missing whitespace around operator
Line 80:24: E225 missing whitespace around operator
Line 82:24: E225 missing whitespace around operator
Line 83:1: W293 blank line contains whitespace
Line 84:23: E231 missing whitespace after ','
Line 85:67: E231 missing whitespace after ','
Line 85:80: E501 line too long (93 > 79 characters)
Line 88:1: W293 blank line contains whitespace
Line 91:1: W293 blank line contains whitespace
Line 92:1: W293 blank line contains whitespace
Line 93:1: W293 blank line contains whitespace
Line 94:1: W293 blank line contains whitespace
Line 95:1: W293 blank line contains whitespace
Line 95:1: W391 blank line at end of file

In the file talos/database/database.py:

Line 10:1: E303 too many blank lines (3)
Line 12:22: E231 missing whitespace after ','
Line 12:31: E231 missing whitespace after ','
Line 12:40: E231 missing whitespace after ','
Line 12:45: E231 missing whitespace after ','
Line 12:55: E231 missing whitespace after ','
Line 12:74: E231 missing whitespace after ','
Line 12:80: E501 line too long (134 > 79 characters)
Line 12:105: E231 missing whitespace after ','
Line 13:1: W293 blank line contains whitespace
Line 15:9: E303 too many blank lines (2)
Line 15:21: E225 missing whitespace around operator
Line 16:27: E225 missing whitespace around operator
Line 17:24: E225 missing whitespace around operator
Line 18:15: E225 missing whitespace around operator
Line 22:28: E701 multiple statements on one line (colon)
Line 23:80: E501 line too long (116 > 79 characters)
Line 25:28: E701 multiple statements on one line (colon)
Line 26:80: E501 line too long (117 > 79 characters)
Line 27:20: E225 missing whitespace around operator
Line 28:5: E301 expected 1 blank line, found 0
Line 39:80: E501 line too long (109 > 79 characters)
Line 39:110: W291 trailing whitespace
Line 43:80: E501 line too long (83 > 79 characters)
Line 57:1: W293 blank line contains whitespace
Line 61:5: E301 expected 1 blank line, found 0
Line 61:25: E231 missing whitespace after ','
Line 63:12: E225 missing whitespace around operator
Line 65:5: E301 expected 1 blank line, found 0
Line 66:12: E225 missing whitespace around operator
Line 68:1: W293 blank line contains whitespace
Line 69:1: W293 blank line contains whitespace
Line 69:1: W391 blank line at end of file


Solc version update

Hello!
I've updated the version of solc to the latest ^0.4.22. Still, the option to use an external compiler version looks non-automateable to me (or I just don't understand how to properly configure it).
Thank you!

Thanks we are in 23 now :) !. It has been updated already.

Although a good point to order the dependencies.


Spurious test failure: "error: linking with cc failed"

error: compilation failed!

status: exit code: 101

command: target/release/miri tests/run-pass/aux_test.rs -L /tmp --target=x86_64-unknown-linux-gnu -Z dump-mir=all -Z mir-opt-level=3 -Z dump-mir-dir=/tmp/aux_test -L /tmp/aux_test.stage-id.mir-opt.libaux -C prefer-dynamic -o /tmp/aux_test.stage-id -Zmir-opt-level=0 -Zmir-emit-validate=1

stdout:

------------------------------------------

------------------------------------------

stderr:

------------------------------------------

error: linking with `cc` failed: exit code: 1

  |

  = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/travis/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/tmp/aux_test.0.o" "-o" "/tmp/aux_test.stage-id" "/tmp/aux_test.crate.allocator.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/tmp" "-L" "/tmp/aux_test.stage-id.mir-opt.libaux" "-L" "/home/travis/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/tmp/aux_test.stage-id.mir-opt.libaux" "-l" "dep" "-L" "/home/travis/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "std-ab8512bb715ab82f" "-Wl,-Bstatic" "/home/travis/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-53095306c4bf2e4a.rlib" "-Wl,-Bdynamic" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util"

  = note: /usr/bin/ld: cannot find /tmp/aux_test.0.o: No such file or directory

          /usr/bin/ld: cannot find /tmp/aux_test.crate.allocator.o: No such file or directory

          collect2: ld returned 1 exit status

See https://travis-ci.org/solson/miri/builds/265176951 for an example. Re-running the test usually fixes this. I seem to remember I even saw that locally.

Ah dang, it seems restarting the build erases the log.

I've seen it before, too. Might be a race condition on the disk in compiletest

I agree. Maybe it deletes the temp files too early?


FIX: preventing property duplications

If applied the Property-Serializer will throw validation errors when:

A new property is created for a surface that already has a property with the same name.
A property is updated(via PUT), and the new name is equal the a property of the same suface thats not the altered property

Prior to this change it was, possible to create two properties with the same name, for the same surface.
This change prevents this by invalidation in the serialization.
Fixes #1105

I only expect a update via PUT.
Should i also handle the PATCH case?

Unfortunately the diff is quiet messy because of the formatting...
Here is the added code in topobank/manager/serializers.py in the validate funktion of the PropertySerializer:
        method = self.context.get("request").method
        # NOTE: On creation (POST) we need to check if the surface already has a property with the same name
        if method == "POST":
            if attrs.get("surface").properties.filter(name=attrs.get("name")).exists():
                raise serializers.ValidationError(
                    {"message": "Property names have to be unique"}
                )

        # NOTE: On update (PUT) we need to check if the surface already has a property with the same name,
        # that is not the surface we are trying to update
        if method == "PUT":
            match self.instance:
                case None:
                    # NOTE:This code should not be reachable.
                    # On update, the serializer should always hold a instance
                    pass
                case _:
                    if (
                        attrs.get("surface")
                        .properties.filter(name=attrs.get("name"))
                        .exclude(id=self.instance.id)
                        .exists()
                    ):
                        raise serializers.ValidationError(
                            {"message": "Property names have to be unique"}
                        )

Hi @IoannisNezis - Model validation is good, but I think we also need a unique constraint in the database. See here:

https://docs.djangoproject.com/en/5.0/ref/models/constraints/#uniqueconstraint

or here

https://docs.djangoproject.com/en/5.0/ref/models/options/#unique-together

The PR looks like you turned on black (which is fine with me).

I think with the current modeling this would prevent different surfaces to have properties with the same name, right?

This would work if the name is a tagulous tag, or in general, a separate model.
But currently its only a TextField.

You need to set a unique_together constraint, which means the constraint would be on combinations of name and surface fields. If you just put a constraint on the name field then this would prevent different surfaces to have properties of the same name as you say.
Django supports this, I am actually not sure if this also leads to a constraint on the database side or if Django handles this.


Suggestion: downgrade to c++11 anf Qt 5.2

Hi,
First of all, thanks for this very nice piece of software.
I am currently working on Ubuntu 14.04 (I am stacked to that version for several reasons).
I had to do some changes to downgrade the code. Not many indeed.
Would you be interested to "downgrade" your requirements to allow a broader availability of your library?
I can send you a Pull request, if you agree.
Cheers
Davide

Hi David,
thanks for your appreciation. I think there is nothing bad in downgrading the version of Qt.
As I remember, I just put the current version from my machine to the cmake config.
Please, make sure that the code is compilable and all examples work as they should.
Best,
Dmitry

Sorry, just noticed the C++11 -- it will not work right away. I use std::make_unique that came to the standard just with C++14. You would need to instrument the code with some #ifdef conditions and provide the implementation with C++11 (std::unique_ptr<ClassName>(new ClassName(params))).


valueTime allows minutes as 24:99

This resource is created without errors against the Hapi testserver:
{
  "resourceType": "Observation",
   "language": "fi",
    "status": "final",
  "category": [{
    "coding": [
      {
        "system": "http://hl7.org/fhir/observation-category",
   "version": "1",
        "code": "vital-signs",
        "display": "Vital Sign"
      }
    ]
  }],
  "code": {
    "coding": [
      {
        "system": "http://foo.org",
        "code": "8302-2",
        "display": "Body height"
      }
    ]
  },
  "subject": {
    "reference": "Patient/328686"
  },
  "effectiveDateTime": "2017-06-12",
  "issued": "2017-06-12T10:00:00.936+02:00",
  "performer": [{
    "reference": "Patient/328686"
  }],
  "valueTime": "24:99"
}

valueTime should be:
A time during the day, with no date specified (can be converted to a Duration since midnight). Seconds must be provided due to schema type constraints but may be zero-filled and may be ignored. The time "24:00" is not allowed, and neither is a time zone
Regex: ([01][0-9]|2[0-3]):[0-5][0-9]:[0-5]0-9?

Here's the result:
{
  "resourceType": "OperationOutcome",
  "text": {
    "status": "generated",
    "div": "

Operation Outcome

INFORMATION	[]
Successfully created resource "Observation/328690/_history/1" in 62ms
	\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t
\n\t\t\t
\n\t\t\t\tINFORMATION	\n\t\t\t\t[]	\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t
No issues detected during validation
	\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t
\n\t\t
\n\t
"
  },
  "issue": [
    {
      "severity": "information",
      "code": "informational",
      "diagnostics": "Successfully created resource \"Observation/328690/_history/1\" in 62ms"
    },
    {
      "severity": "information",
      "code": "informational",
      "diagnostics": "No issues detected during validation"
    }
  ]
}

This issue has been fixed. Atleast getting error now
{         "severity": "error",         "code": "processing",         "diagnostics": "Not a valid time",         "location


Allow adding arbitrary files to helm chart

What
This is a continuation of https://github.com/abrisco/rules_helm/pull/102 with a bit nicer API
This allows the user to add arbitrary source of generated files to the helm chart at their desired location.
This change also allows the end user to copy files outside of the helm chart directory into the templates/crds. This makes it possible to e.g. create a standard helm chart folder structure but copy generated files into the helm chart as well.

@abrisco This is ready for review when you have the time

Also fixes #106

Also fixes #91


add recipe for Qt 5.9.5 on macOS.

Don't you wanna use this script recipes/install-qt and just add one more parameter that will show target platform (mac)? and left default as linux?


Geometry missing while overpass shows the geometry

Hi I am trying to do this query where I have some admin_level=6 parts and some level=7:
sh_area = Overpass.request(
    area={"name": "Schleswig-Holstein", "admin_level": 4},
    rel=dict(boundary="administrative", admin_level=dict(regex="[6-7]")),
)

However I run into the issue that for some reason the admin_level=6 areas dont have data in the geometry column while on overpass they do get rendered as expected. https://overpass-turbo.eu/s/1pU9

Any ideas why this happens and how I fix this issue?

A little more context: I want to fetch the areas where I have no admin_level=7 areas to fill those gaps. They only exist as admin_level=6. However admin_level=6 has some geometry issues for me

Thank you for your interest in trying the library and for reporting the issue.
Usually, a geometry is None when the code failed to construct a geometry from the info it had (which is not unusual with OpenStreetMap: many geometries there are invalid and I guess there is a lot of code behind to fix many kinds of issues).
I don't know if you saw any warning before seeing the GeoDataFrame? Otherwise, I will try on my side and go step by step to see what happened with those geometries (maybe not right away, bear with me, but I keep the tab open)

Thanks for making the library I had great fun using it yesterday 🤗
I didn't get any warnings on that query.
However while working on this fiether I discovered that changing the regex to be not a range but just one admin level made it work for each of them alone. Just both at the same time seem to cause this.

Indeed, I never tried with the regex, but we should make it work. I will try to have a look and see if it's possible.

It took a while before I took the time, but I think I got it!

Awesome thanks! Now I should get back to doing more with this 😄

I will make a release tomorrow morning so that it's easier to upgrade 💪


JB-481 - NFTs & Rewards card ‘View all’ pill should be bg:smoke-100 text:smoke-700 + icon looks tiny?

What does this PR do and why?
Closes JB-481
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3794

PR #3795

PR #3796

PR #3797

PR #3798

PR #3799

PR #3800

PR #3801

Current dependencies on/for this PR:

main

PR #3794

PR #3795

PR #3796

PR #3797

PR #3798

PR #3799

PR #3800

PR #3801

@wraeth-eth started a stack merge that includes this pull request via Graphite.

Graphite rebased this pull request as part of a merge.

@wraeth-eth merged this pull request with Graphite.