CASMINST-6147 / CASMINST-6151

Description
CASMINST-6147 Add note after Stage 0.4
CASMINST-6151 misc IUF doc updates
Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.4

The release/1.4 version of this is https://github.com/Cray-HPE/docs-csm/pull/3633


API packing to Hololens

Hello together, first of all thank you for your work.
As part of my master thesis I am trying to bring the API to the Hololens, but unfortunately the app crashes as soon as I execute "open aicall gpt3". I am very grateful for any help!

HoloLens is not listed as a supported platform for this plugin.


Add support in the OSM debugger to view this addition certificate fields for Spiffe

s/OMS/OSM?

completed in #5131


Reveal - Callback-Event not working

What should happen?
When calling a Reveal-Modal-Box over ... an event should be fired. So i should be able to do some actions on opening or closing the modal.
What happens instead?
Nothing happens.
Test Case and/or Steps to Reproduce (for bugs)
I have a view Links like ... and the Modal-Sourcecode. The Modal is opening, everything is fine. But when i would bind some actions to the event, nothing happens:
$('[data-reveal]').on('open.zf.reveal', function () {
alert('open');
});
Your Environment
Foundation is compiled with node.js, i'm using the foundation-explicit-pieces.js to select the foundation-modules i need. All needed libraries are included.

Foundation version used: 6.6.3

Hi @mjpr263,
please provide a working codepen so we can reproduce it.

Hi @DanielRuf,
i added a codepen here:
https://codepen.io/mpruy/pen/XWmLLwL
I compiled foundation with node.js.
My app.js for compilement looks like this:
import $ from 'jquery';
import 'what-input';

//window.jQuery = $;
//require('foundation-sites');

import './lib/foundation-explicit-pieces';

$(document).foundation();

In my foundation-explicit-pieces.js are the following lines active:
import $ from 'jquery';
Foundation.addToJquery($);
export { Foundation };

(and of course the plugins etc. between)

Works with the normal Foundation Sites css and js:
https://codepen.io/DanielRuf/pen/PoPrMGQ
Please check if anything is missing like motion-ui, some CSS or component.

@DanielRuf Thats exactly my problem, it works with the precompiled foundation-version but not with the node.js-compiled.
Any needed component is in, the compile-process works fine too:
import $ from 'jquery';

import { Foundation } from 'foundation-sites/js/foundation.core';
import * as CoreUtils from 'foundation-sites/js/foundation.core.utils';
import { Box } from 'foundation-sites/js/foundation.util.box'
import { onImagesLoaded } from 'foundation-sites/js/foundation.util.imageLoader';
import { Keyboard } from 'foundation-sites/js/foundation.util.keyboard';
import { MediaQuery } from 'foundation-sites/js/foundation.util.mediaQuery';
import { Motion, Move } from 'foundation-sites/js/foundation.util.motion';
import { Nest } from 'foundation-sites/js/foundation.util.nest';
import { Timer } from 'foundation-sites/js/foundation.util.timer';
import { Touch } from 'foundation-sites/js/foundation.util.touch';
import { Triggers } from 'foundation-sites/js/foundation.util.triggers';
//import { Abide } from 'foundation-sites/js/foundation.abide';
import { Accordion } from 'foundation-sites/js/foundation.accordion';
import { AccordionMenu } from 'foundation-sites/js/foundation.accordionMenu';
import { Drilldown } from 'foundation-sites/js/foundation.drilldown';
//import { Dropdown } from 'foundation-sites/js/foundation.dropdown';
//import { DropdownMenu } from 'foundation-sites/js/foundation.dropdownMenu';
import { Equalizer } from 'foundation-sites/js/foundation.equalizer';
//import { Interchange } from 'foundation-sites/js/foundation.interchange';
//import { Magellan } from 'foundation-sites/js/foundation.magellan';
//import { OffCanvas } from 'foundation-sites/js/foundation.offcanvas';
import { Orbit } from 'foundation-sites/js/foundation.orbit';
//import { ResponsiveMenu } from 'foundation-sites/js/foundation.responsiveMenu';
//import { ResponsiveToggle } from 'foundation-sites/js/foundation.responsiveToggle';
import { Reveal } from 'foundation-sites/js/foundation.reveal';
//import { Slider } from 'foundation-sites/js/foundation.slider';
import { SmoothScroll } from 'foundation-sites/js/foundation.smoothScroll';
import { Sticky } from 'foundation-sites/js/foundation.sticky';
//import { Tabs } from 'foundation-sites/js/foundation.tabs';
//import { Toggler } from 'foundation-sites/js/foundation.toggler';
//import { Tooltip } from 'foundation-sites/js/foundation.tooltip';
//import { ResponsiveAccordionTabs } from 'foundation-sites/js/foundation.responsiveAccordionTabs';

Foundation.addToJquery($);

// Add Foundation Utils to Foundation global namespace for backwards
// compatibility.
Foundation.rtl = CoreUtils.rtl;
Foundation.GetYoDigits = CoreUtils.GetYoDigits;
Foundation.transitionend = CoreUtils.transitionend;
Foundation.RegExpEscape = CoreUtils.RegExpEscape;
Foundation.onLoad = CoreUtils.onLoad;

Foundation.Box = Box;
Foundation.onImagesLoaded = onImagesLoaded;
Foundation.Keyboard = Keyboard;
Foundation.MediaQuery = MediaQuery;
Foundation.Motion = Motion;
Foundation.Move = Move;
Foundation.Nest = Nest;
Foundation.Timer = Timer;

// Touch and Triggers previously were almost purely sede effect driven,
// so no need to add it to Foundation, just init them.
Touch.init($);
Triggers.init($, Foundation);
MediaQuery._init();

//Foundation.plugin(Abide, 'Abide');
Foundation.plugin(Accordion, 'Accordion');
Foundation.plugin(AccordionMenu, 'AccordionMenu');
Foundation.plugin(Drilldown, 'Drilldown');
//Foundation.plugin(Dropdown, 'Dropdown');
//Foundation.plugin(DropdownMenu, 'DropdownMenu');
Foundation.plugin(Equalizer, 'Equalizer');
//Foundation.plugin(Interchange, 'Interchange');
//Foundation.plugin(Magellan, 'Magellan');
//Foundation.plugin(OffCanvas, 'OffCanvas');
Foundation.plugin(Orbit, 'Orbit');
//Foundation.plugin(ResponsiveMenu, 'ResponsiveMenu');
//Foundation.plugin(ResponsiveToggle, 'ResponsiveToggle');
Foundation.plugin(Reveal, 'Reveal');
//Foundation.plugin(Slider, 'Slider');
Foundation.plugin(SmoothScroll, 'SmoothScroll');
Foundation.plugin(Sticky, 'Sticky');
//Foundation.plugin(Tabs, 'Tabs');
//Foundation.plugin(Toggler, 'Toggler');
//Foundation.plugin(Tooltip, 'Tooltip');
//Foundation.plugin(ResponsiveAccordionTabs, 'ResponsiveAccordionTabs');

export { Foundation };

Did you already try if the unminified version works and if it works when you enable all components?
Testing the unminified version without a sourcemap file is not that helpful.
It seems also that your file contains jQuery too.
I'm not sure what is missing here so this requires some testing. I never had this issue with the ZURB template repo and other setups.

And with the unminified version you might want to throw in some debugger; statements to test.


Fix typo preventing dashboard display

[ ] Redmine Issue: https://redmine.pfsense.org/issues/NNNN
[ ] Ready for review

Displays error at the bottom of the dasboard and prevents accepting license in a popup.

Thanks for pointing this out. Fixed via cherry-pick


AMM Application Contracts Port

Type of change

New feature

Changes
The following changes have been made:

Added SwaySwap contracts and libraries to this repo, with these changes:

Discarded token_contract
Renamed swayswap_contract to AMM, rewrote the functions and added an initialize function
Rewrote exchance_contract functions and added a constructor function
Restructured the project to match external project structure, since scripts that use the interfaces will be added in later PRs
Added events
Added errors
Added / rewrote tests

Modified CI to include these projects

Notes

AMM contract's initialize function has an ignored success case test because bytecode root check is not possible using the SDK for now.
Bytecode root function in contracts/AMM/utils will be removed once the repo is bumped up.

Related Issues
Closes #232

There is a .DS_Store file in the exchange which comes from MAC. That should be removed and added to the gitignore

Done. Not pushing the new .gitignore, seeing that other projects do not have .DS_Store files in their .gitignores.

The AMM and exchange are added to CI but the libraries project is not

The library project does not have a tests module, which fails CI. What do you suggest here?

Note that there is a NameRegistry PR which is also bumping to version 0.29.0 which means features like StorageMap are automatically in the prelude and the comment in utils.sw of AMM may be resolved on top of any other issues

The function that is addressed in the comment in utils.sw is part of v0.27.0, so bumping to v0.29.0 will resolve this. Should this bump be done after this PR is merged and the whole repo is bumped, or are you suggesting something else here?

I have arbitrarily added new lines in places where I think it would make it a little easier to read

Thanks.

This looks outdated and my reply is gone, so I am resurrecting this conversation.
I think your suggestion would not work, given that test functions::add_pool::success::adds_more_than_once passes. Which also means that setting the bytecode root is doing what it is intended to do.

There is a .DS_Store file in the exchange which comes from MAC. That should be removed and added to the gitignore

Done. Not pushing the new .gitignore, seeing that other projects do not have .DS_Store files in their .gitignores.

The AMM and exchange are added to CI but the libraries project is not

The library project does not have a tests module, which fails CI. What do you suggest here?

Note that there is a NameRegistry PR which is also bumping to version 0.29.0 which means features like StorageMap are automatically in the prelude and the comment in utils.sw of AMM may be resolved on top of any other issues

The function that is addressed in the comment in utils.sw is part of v0.27.0, so bumping to v0.29.0 will resolve this. Should this bump be done after this PR is merged and the whole repo is bumped, or are you suggesting something else here?

I have arbitrarily added new lines in places where I think it would make it a little easier to read

Thanks.

Can the library be added to the build script somewhere?
Function can stay but if the repo is bumped before this goes in then we should use it from the library

To the build script, I added forc fmt --check of the libraries project and the contracts/exchange/tests/artifacts/malicious_implementation project. I did not add forc build of the libraries project as per our talk, @Braqzen, since it is built implicitly.


Bugfix and regression test for stderr output

In pull request #33 I wrote the line handling the printing of stderr in the script run function so in the current state it doesn't print stderr.
This is a patch to fix that, it also has a regression test included to
future proof it.

Good catch!


Merge branch & PR workflows

This change merges the workflows that were triggered by branch pushes (to build the Docker images and run unit tests) into the PR deployment workflow.
This ensures that we have a single point to inspect results of changes, and also better aligns our workflows with Dependabot, which does not trigger branch events.

/deploy


type '_InternalLinkedHashMap<dynamic, dynamic>' is not a subtype of type 'Map<String, dynamic>

while I am trying to decode json into a map, it decode it to _InternalLinkedHashMap<dynamic, dynamic> instead... does somebody know about it?

Please ask support questions in one of the support channels https://flutter.io/support/
and please add the code there that allows to reproduce and investigate.


Added Emotion Detector Vite + React App

Closes #212
Description
Added a real-time emotion detector app (using Vite + React)
Screenshots

add readme

add readme

It's already there.

Thanks for your Valuable contribution.
Don't forget to star the repo.


In-progress PR: Adds Renderbuffer support & multisampling for WebGL 2

Description of change
I'm trying to add support multisampling render buffers in pixi.js; in that process, I wanted to demonstrate the change's merit using JSFiddle demos.
This is related to #6288 .

[x] Renderbuffer + RenderbufferSystem: These manage the binding of WebGL render buffers to their contexts.

[x] Add multisampling support

Pre-Merge Checklist

[ ] Tests and/or benchmarks are included
[ ] Documentation is changed or added
[ ] Lint process passed (npm run lint)
[ ] Tests passed (npm run test)

Codecov Report

Merging #6290 into dev will decrease coverage by 0.37%.
The diff coverage is 46.03%.

@@            Coverage Diff             @@
##              dev    #6290      +/-   ##
==========================================
- Coverage   77.57%   77.19%   -0.38%
==========================================
  Files         186      188       +2
  Lines       10083    10197     +114
==========================================
+ Hits         7822     7872      +50
- Misses       2261     2325      +64

Impacted Files
Coverage Δ

packages/core/src/Renderer.js
89.18% <ø> (ø)
:arrow_up:

packages/settings/src/settings.js
100% <ø> (ø)
:arrow_up:

...ckages/core/src/renderbuffer/RenderbufferSystem.js
33.33% <33.33%> (ø)

packages/core/src/framebuffer/FramebufferSystem.js
63.42% <35.71%> (-4.73%)
:arrow_down:

packages/core/src/framebuffer/Framebuffer.js
44% <40%> (-4.08%)
:arrow_down:

packages/core/src/renderbuffer/Renderbuffer.js
88% <88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9ada6...8750927. Read the comment docs.

I got a (partially) working example: https://jsfiddle.net/ShukantPal/3qf6dr7b/.
The problem is some sort of y-flipping because of the blit. If you an idea, please help me figure out why.

Hi, @lekzd. Thank you for reviewing my pull request and pointing out my mistakes. I’ll follow up ASAP.

@GoodBoyDigital This is an example you were asking for: https://jsfiddle.net/ShukantPal/3qf6dr7b/64/. It is a fairly low-level usage of the frame buffer API - nevertheless, it uses multisampling at 4x resolution.
I am thinking about how to integrate a MSAARenderTexture -  a simple replacement for RenderTexture when multisampling is preferred.

Hey @SukantPal, What I would love to see is a few examples added to our examples page to show how this can be used in a few different ways!

@GoodBoyDigital Thanks for reviewing this, I’ll try to get your requests resolved by the end of today (Eastern Time :)


⚠ ClamAV has degraded performance

In d7b5015, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 408 ms

Resolved: ClamAV performance has improved in 2aa0ec7.


tusd log WARN NetworkTimeoutError method=PATCH  error="feature not supported"

Question
When I use go client to upload files to Tusd service, Tusd service will print a large number of the following wanring logs. Do these warnings have any impact on the service? If we don't eliminate these warm logs, how can we.
And, if I use tusd-v1.13, there will be no problem at all.
WARN log print:
2024/09/19 17:27:23 WARN NetworkTimeoutError method=PATCH path=9d45767e50ad476f4bf2d827033dd52a requestId="" id=9d45767e50ad476f4bf2d827033dd52a error="feature not supported"
2024/09/19 17:27:23 WARN NetworkTimeoutError method=PATCH path=9d45767e50ad476f4bf2d827033dd52a requestId="" id=9d45767e50ad476f4bf2d827033dd52a error="feature not supported"
2024/09/19 17:27:23 WARN NetworkTimeoutError method=PATCH path=9d45767e50ad476f4bf2d827033dd52a requestId="" id=9d45767e50ad476f4bf2d827033dd52a error="feature not supported"
2024/09/19 17:27:23 INFO ChunkWriteComplete method=PATCH path=9d45767e50ad476f4bf2d827033dd52a requestId="" id=9d45767e50ad476f4bf2d827033dd52a bytesWritten=2012344
2024/09/19 17:27:23 INFO UploadFinished method=PATCH path=9d45767e50ad476f4bf2d827033dd52a requestId="" id=9d45767e50ad476f4bf2d827033dd52a size=12498104
2024/09/19 17:27:23 INFO ResponseOutgoing method=PATCH path=9d45767e50ad476f4bf2d827033dd52a requestId="" id=9d45767e50ad476f4bf2d827033dd52a status=204 body=""
Setup details

GOVERSION='go1.23.1'
Operating System: linux 3.10.0-514.el7.x86_64
Used tusd version: tusd v2.2.2
Used tusd data storage: disk store
Used tusd configuration: default config
Used tus client library: github.com/eventials/go-tus

Please consult https://tus.github.io/tusd/advanced-topics/usage-package/#i-am-getting-warnings-regarding-networkcontrolerrornetworktimeouterror-and-feature-not-supported-why for information on this topic.

Please consult https://tus.github.io/tusd/advanced-topics/usage-package/#i-am-getting-warnings-regarding-networkcontrolerrornetworktimeouterror-and-feature-not-supported-why for information on this topic.

thank u


Workflows: Reject (request changes) in a second step doesn't send emails to users in previous task

Issue Summary
When in a multistep workflow, after the first step rejecting doesn't produce any emails.
Steps to Reproduce

Create a workflow with at least two steps
Assign a group of users to one step and another different group to the second step.
Start the workflow in a page configured to run the workflow first step using a user in the first group.
Reject requesting changes using a user in the second group, an email stating the rejection is sent.
Resume workflow using a user in the first group, an email is sent about the workflow being resumed.
Do changes and approve workflow step using user in the second group, an email is sent about the step being approved and ready for moderation.
Reject the workflow again using a user in the first group,  no email is sent due to condition requested_by != triggering_user in /wagtail/admin/mail.py:310

Steps 4 and 5 can be skipped to reproduce the issue, they have been included to demonstrate that in a specific case emails are being sent in case of a rejection.
The expected behaviour is that when a workflow step is rejected the users in the previous task get notified, currently the get_recipient_users method in /wagtail/admin/mail.py:306 doesn't seem to support it not even notifying the user that submitted the step for moderation.
This can be somehow alleviated by setting the requested_by user to the user resuming the action on the workflow resume action method in /wagtail/core/models/init.py:3552
But as currently programmed the method get_recipient_users never returns more than one user, so a notification to all users in the group is not possible.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes (Wagtail 4.1.1)

Technical details

Python version: 3.9
Django version: 3.2.18
Wagtail version: 4.1.1
Browser version:  Chrome Version 110.0.5481.177 (Official Build) (x86_64)

@lb- Can you try to reproduce this issue in your end?

Hi @vladox,
Indeed, looking at the get_recipient_users method of WorkflowStateRejectionEmailNotifier:
https://github.com/wagtail/wagtail/blob/dc48dcce8a0480bf09629a16a5a3583d2234788e/wagtail/admin/mail.py#L340-L352
it seems that the intention is to send an email only to the user who triggered the workflow.
Why would you expect that:

when a workflow step is rejected the users in the previous task get notified

?

Hi @floels
Consider the following workflow setup (I imagine it should be a fairly common one), you have a multilanguage site and for the translated branch of your site (Wagtail-Localize) a workflow including two steps is setup:

Submit to translators for translation/correction
Approval by workflow initiator (editor/moderator)

Now as currently coded if the translator rejects a change (maybe the text is missing or something like that) the workflow initiator gets a notification no issues.
Both on the contrary if in the step 2 the moderator rejects changes (much more likely) no email notification is sent to the translator warning them about some issue with the translation.
Do you see the issue? Is not the workflow initiator that needs to be notified but the user that resumed or submited the previous step.
Please let me know your thoughts about this use case.

Yeah, this is not a bug, this is a feature request. Workflow will always notify the submitter to the workflow, but won't notify previous tasks - depending on use case that could cause a huge amount of email spam, since the previous tasks' reviewers will also get emails when the task is resubmitted to them, which to me is closer to when it's actually useful for them to be notified. That said, I see your use case...
For now, I'd suggest you implement this as a customisation using a https://docs.wagtail.org/en/stable/reference/signals.html#workflow-rejected signal handler.
If anyone else would benefit from this or a setting to add this, please let us know. I wouldn't be averse to us adding this, but if we do, I think it would benefit from an off switch - likely a setting.


Update Hatfield Open visit slots

Remove Sunday morning visit slot

Please test on preprod - I'm unable to access Kibana remotely.

Tested on preprod.


az functionapp plan create example need to show premium function plan

az functionapp plan create example need to show premium function plan

@ahmedelnably, this can be closed (I don't have access). This was included in https://github.com/Azure/azure-cli/pull/8947


#2911 cypress e2e

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR partially solves #2911
[ ] Requires deployment <rubick/magick_issue>

What was added:

first E2E test suite which can be run locally by devs against their locally built app at http://localhost:9090/
the way to run the tests is to go to nft-gallery/tests and running cypress run which prompts tests to run in headless mode
new route with /e2e-login was added, which is logging in user with random wallet provided (we want to simulate logged in user experience but we don't have available extension since this is automated test)
tests are checking correct app behavior at landing, explore, gallery, collections, item details and collection details
tests execution can be explored at tests/cypress/e2e/basicE2E.cy.ts
custom commands (functions) can be checked out at tests/cypress/support/commands.ts
cypress config resides at tests/cypress.config.ts
offtopic: added pnpm dev-win to get around weird error I'm facing at my win machine: 'PORT' is not recognized as an internal or external command, operable program or batch file.

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[ ] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

https://user-images.githubusercontent.com/73316633/181489046-f297f0d8-000b-46e3-8d3b-5151feeb215c.mp4

after merging main into this, app is currently unusable for me, needs to resolve this one first:

https://github.com/kodadot/nft-gallery/issues/3594

I see that there's error in some of the GH action tests: ES2015 module syntax is preferred over custom TypeScript modules and namespaces, feel free to suggest solution for that, but I don't think it's going to cause any problems within cypress framework

I see that there's error in some of the GH action tests: ES2015 module syntax is preferred over custom TypeScript modules and namespaces, feel free to suggest solution for that, but I don't think it's going to cause any problems within cypress framework

maybe we can turn off the rule by adding /* eslint-disable @typescript-eslint/no-namespace */ at the top of the file command.ts

I see that there's error in some of the GH action tests: ES2015 module syntax is preferred over custom TypeScript modules and namespaces, feel free to suggest solution for that, but I don't think it's going to cause any problems within cypress framework

maybe we can turn off the rule by adding /* eslint-disable @typescript-eslint/no-namespace */ at the top of the file command.ts

that worked, the problems are gone

  3 failing

  1) exploreBsxGallery
       expandGallerySearch:
     CypressError: Timed out retrying after 4050ms: `cy.click()` failed because this element:

`<a id="GALLERY-label" tabindex="0">...</a>`

is being covered by another element:

`<div class="loading-background"></div>`

Fix this problem, or use {force: true} to disable error checking.

https://on.cypress.io/element-cannot-be-interacted-with
      at $Cy.ensureDescendents (http://localhost:9090/__cypress/runner/cypress_runner.js:162005:78)
      at ensureDescendents (http://localhost:9090/__cypress/runner/cypress_runner.js:147397:8)
      at ensureDescendentsAndScroll (http://localhost:9090/__cypress/runner/cypress_runner.js:147404:14)
      at ensureElIsNotCovered (http://localhost:9090/__cypress/runner/cypress_runner.js:147536:5)
      at runAllChecks (http://localhost:9090/__cypress/runner/cypress_runner.js:147726:52)
      at retryActionability (http://localhost:9090/__cypress/runner/cypress_runner.js:147750:16)
      at tryCatcher (http://localhost:9090/__cypress/runner/cypress_runner.js:13012:23)
      at Function.Promise.attempt.Promise.try (http://localhost:9090/__cypress/runner/cypress_runner.js:10286:29)
      at whenStable (http://localhost:9090/__cypress/runner/cypress_runner.js:166931:65)
      at http://localhost:9090/__cypress/runner/cypress_runner.js:166385:14
      at tryCatcher (http://localhost:9090/__cypress/runner/cypress_runner.js:13012:23)
      at Promise._settlePromiseFromHandler (http://localhost:9090/__cypress/runner/cypress_runner.js:10947:31)
      at Promise._settlePromise (http://localhost:9090/__cypress/runner/cypress_runner.js:11004:18)
      at Promise._settlePromise0 (http://localhost:9090/__cypress/runner/cypress_runner.js:11049:10)
      at Promise._settlePromises (http://localhost:9090/__cypress/runner/cypress_runner.js:11129:18)
      at Promise._fulfill (http://localhost:9090/__cypress/runner/cypress_runner.js:11073:18)
      at http://localhost:9090/__cypress/runner/cypress_runner.js:12687:46
  From Your Spec Code:
      at Context.eval (http://localhost:9090/__cypress/tests?p=cypress/e2e/basicE2E.cy.ts:174:36)

  2) exploreBsxGallery
       galleryInputFields:
     CypressError: Timed out retrying after 4000ms: `cy.type()` failed because this element is not visible:

`<input type="number" autocomplete="on" min="0" step="any" placeholder="MIN PRICE" data-cy="input-min" class="input">`

This element `<input.input>` is not visible because its parent `<div#sortAndFilter.collapse-content>` has CSS property: `display: none`

Fix this problem, or use `{force: true}` to disable error checking.

https://on.cypress.io/element-cannot-be-interacted-with
      at runVisibilityCheck (http://localhost:9090/__cypress/runner/cypress_runner.js:161836:76)
      at $Cy.ensureStrictVisibility (http://localhost:9090/__cypress/runner/cypress_runner.js:161852:12)
      at runAllChecks (http://localhost:9090/__cypress/runner/cypress_runner.js:147695:14)
      at retryActionability (http://localhost:9090/__cypress/runner/cypress_runner.js:147750:16)
      at tryCatcher (http://localhost:9090/__cypress/runner/cypress_runner.js:13012:23)
      at Function.Promise.attempt.Promise.try (http://localhost:9090/__cypress/runner/cypress_runner.js:10286:29)
      at whenStable (http://localhost:9090/__cypress/runner/cypress_runner.js:166931:65)
      at http://localhost:9090/__cypress/runner/cypress_runner.js:166385:14
      at tryCatcher (http://localhost:9090/__cypress/runner/cypress_runner.js:13012:23)
      at Promise._settlePromiseFromHandler (http://localhost:9090/__cypress/runner/cypress_runner.js:10947:31)
      at Promise._settlePromise (http://localhost:9090/__cypress/runner/cypress_runner.js:11004:18)
      at Promise._settlePromise0 (http://localhost:9090/__cypress/runner/cypress_runner.js:11049:10)
      at Promise._settlePromises (http://localhost:9090/__cypress/runner/cypress_runner.js:11129:18)
      at Promise._fulfill (http://localhost:9090/__cypress/runner/cypress_runner.js:11073:18)
      at http://localhost:9090/__cypress/runner/cypress_runner.js:12687:46
  From Your Spec Code:
      at Context.eval (http://localhost:9090/__cypress/tests?p=cypress/support/e2e.ts:235:37)

  3) exploreBsxGallery
       gallerySortBsx:
     CypressError: Timed out retrying after 4050ms: `cy.click()` failed because this element is not visible:

`<button type="button" data-cy="gallery-sort-by" class="button is-primary">...</button>`

This element `<button.button.is-primary>` is not visible because its parent `<div#sortAndFilter.collapse-content>` has CSS property: `display: none`

Fix this problem, or use `{force: true}` to disable error checking.

https://on.cypress.io/element-cannot-be-interacted-with
      at runVisibilityCheck (http://localhost:9090/__cypress/runner/cypress_runner.js:161836:76)
      at $Cy.ensureStrictVisibility (http://localhost:9090/__cypress/runner/cypress_runner.js:161852:12)
      at runAllChecks (http://localhost:9090/__cypress/runner/cypress_runner.js:147695:14)
      at retryActionability (http://localhost:9090/__cypress/runner/cypress_runner.js:147750:16)
      at tryCatcher (http://localhost:9090/__cypress/runner/cypress_runner.js:13012:23)
      at Function.Promise.attempt.Promise.try (http://localhost:9090/__cypress/runner/cypress_runner.js:10286:29)
      at whenStable (http://localhost:9090/__cypress/runner/cypress_runner.js:166931:65)
      at http://localhost:9090/__cypress/runner/cypress_runner.js:166385:14
      at tryCatcher (http://localhost:9090/__cypress/runner/cypress_runner.js:13012:23)
      at Promise._settlePromiseFromHandler (http://localhost:9090/__cypress/runner/cypress_runner.js:10947:31)
      at Promise._settlePromise (http://localhost:9090/__cypress/runner/cypress_runner.js:11004:18)
      at Promise._settlePromise0 (http://localhost:9090/__cypress/runner/cypress_runner.js:11049:10)
      at Promise._settlePromises (http://localhost:9090/__cypress/runner/cypress_runner.js:11129:18)
      at Promise._fulfill (http://localhost:9090/__cypress/runner/cypress_runner.js:11073:18)
      at http://localhost:9090/__cypress/runner/cypress_runner.js:12687:46
  From Your Spec Code:
      at Context.eval (http://localhost:9090/__cypress/tests?p=cypress/support/e2e.ts:146:147)

  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        30                                                                               │
  │ Passing:      27                                                                               │
  │ Failing:      3                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        false                                                                            │
  │ Duration:     1 minute, 1 second                                                               │
  │ Spec Ran:     basicE2E.cy.ts                                                                   │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

==============================================================================

  (Run Finished)

       Spec                                              Tests  Passing  Failing  Pending  Skipped
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✖  basicE2E.cy.ts                           01:01       30       27        3        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✖  1 of 1 failed (100%)                     01:01       30       27        3        -        -

 ELIFECYCLE  Command failed with exit code 3.
 ```

Also as promised:


Fix critical off-by-one error

There can be only one "second" number.

Thanks @getaaron . Mind deploying this too?


Adding Test Coverage to DevTestLab SDK

Add scenario tests for DevTestLabs, that will tests

Operations for devTestLabs
Models for devTestLabs

Test coverage is required prior to release of the SDK.

The Azure Lab Services team is tracking this work internally. We will be adding scenario tests along with our new SDK version once we publish it.

Closing this for now. Feel free to re-open.


[REF-2141] Custom component command improvements

Summary

If enclosing folder already starts with reflex, do not add that prefix into the name parts. corner case, if they name their folder reflex, we can't derive a package name for them, just prompt user to add --library-name
Add a flag to publish command --build/--no-build, defaults to build==True. When publishing, check if build already exists (has to be the same version), if already exists, ask user if they want to build anyway (default is "n")
add package-name to the requirements.txt in the demo app
Add .gitignore in the top directory to include the dist folder and some other generated files during build
polish the summary message for init to make it more clear the next steps. Some of the information needs to be manually updated.

Tests

Tested manually
The console print now looks like this

~/test/ $ reflex component init
────────────────────────────────────────── Initializing reflex-test project ───────────────────────────────────────────
Info: Populating pyproject.toml with package name: reflex-test
Info: Initializing the component directory: custom_components/reflex_test
Info: Creating app for testing: test_demo
─────────────────────────────────────────────── Initializing test_demo ────────────────────────────────────────────────
Warning: Your version (0.4.2) of reflex is out of date. Upgrade to 0.4.3 with 'pip install reflex --upgrade'
[23:50:29] Initializing the app directory.                                                                console.py:85
           Initializing the web directory.                                                                console.py:85
Success: Initialized test_demo
────────────────────────────────────── Installing reflex-test in editable mode. ───────────────────────────────────────
Info: Package reflex-test installed!
Custom component initialized successfully!
─────────────────────────────────────────────────── Project Summary ───────────────────────────────────────────────────
[ README.md ]: Package description. Please add usage examples.
[ pyproject.toml ]: Project configuration file. Please fill in details such as your name, email, homepage URL.
[ custom_components/ ]: Custom component code template. Start by editing it with your component implementation.
[ test_demo/ ]: Demo App. Add more code to this app and test.

@masenf revision uploaded.

In the src.py.jinja2 we import only import reflex as rx I think we need to add a few of the common reflex imports that are used in almost every component such as from reflex.vars import Var I see we have the example Var commented out but if they un comment it would be missing the import
This is all I can think of now we need to add

The template code in the comment already has rx.Var as examples, dont think we need to add just the Var imports here

In the src.py.jinja2 we import only import reflex as rx I think we need to add a few of the common reflex imports that are used in almost every component such as from reflex.vars import Var I see we have the example Var commented out but if they un comment it would be missing the import
This is all I can think of now we need to add

The template code in the comment already has rx.Var as examples, dont think we need to add just the Var imports here

Yeah your right missed totally missed that


Faster XIP Extraction

Tell us how we can improve Xcodes
More of a question, does Xcodes use the command line xip tool? I read this Twitter thread and they describe how .xip can be faster extracted. It seems to relate to not using Archive Utility, which I believe Xcodes uses, unless I'm mistaken?
What would you like to see? How would you like it to work?
I'd love some confirmation on whether or not Xcodes uses the xip tool or Archive Utility?

Hey @WillBishop
Yep Xcodes uses xip command line when extracting. You can see that here: https://github.com/RobotsAndPencils/XcodesApp/blob/83fa00b21fbe54594d5a1a37ef7a4cf830488cee/Xcodes/Backend/Environment.swift#L28
If there is anything that we could ever do to make that process faster we absolutely would add it in.

You could try this https://github.com/saagarjha/unxip

😉
https://github.com/RobotsAndPencils/XcodesApp/pull/179

This is available to test on 1.3.0 (in prerelease) https://github.com/RobotsAndPencils/XcodesApp/releases/tag/v1.3.0b10
Make sure your Include prerelease app versions is checked

@MattKiazyk thanks I'll try it

Closing this ticket as the faster unxip experiment is no in general release as of 1.3.1


Upgrade 0.15

Remove need for yarn (npm 5 seems fine - yarn was nice :wave:)
Change views to components out of popular opinion 👍
Uppercase component filenames 🚀 as mentioned here:

https://github.com/hyperapp/router/pull/23#issuecomment-337989861
https://github.com/hyperapp/router/pull/23#issuecomment-338184058

Ok here we go 🚆


Missing examples for creating containers in the SDK's and how to set properties like TTL and indexing

Hello,
This page: https://docs.microsoft.com/en-us/azure/cosmos-db/table/how-to-create-container is missing examples of how to create containers in the SDK's and how to set properties like TTL and indexing.
The first line lets u to believe that there should be some exampes for supported SDKs but only the portal method is explained here.
I was looking for information on how to do this:  is-there-a-way-to-programmatically-change-ttl-on-a-cosmos-db-table
in the Azure.Data.Table SDK but the workaround mentioned there doesn't work for Azure.Data.Table.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89c0df95-a15b-3765-770d-51595c10e958
Version Independent ID: 97577a07-4c50-7f09-0932-6acedc201207
Content: Create a container in Azure Cosmos DB Table API
Content Source: articles/cosmos-db/table/how-to-create-container.md
Service: cosmos-db
Sub-service: cosmosdb-table
GitHub Login: @seesharprun
Microsoft Alias: sidandrews

Hi, @Phoenix359 Thank you for reaching out. We will look into it and update as appropriate.

Hello @Phoenix359!
We are in the midst of creating new how-to articles that go deeper into developer concepts for the Table API using .NET.
Once that's in the release pipeline, we will close the issue here and it should be live within a couple of days.

Just a quick FYI, when this new developer documentation publishes it won't include guidance on setting the TTL or indexing policy using the Azure.Data.Tables namespace. Unfortunately, this SDK doesn't include that ability as far as I am aware of today.


Target Audience page

The Target Audience page includes this phrase - "review the lab completion difficulty".  I'm not certain what that's supposed to say but it doesn't seem correct as is.

@abidlen thanks so much for highlighting this, I will put it in queue for update and leave this ticket open for tracking until the issue is resolved.


StyleBoxFlat downscaling corner radius causes incorrect rendering with border width set

Godot version
4.0.beta4
System information
macOS 12.6.1
Issue description
A StyleBoxFlat (and possibly other StyleBox types) with corner radius set will downscale the corner radius if they are too large to fit. For example setting a 20px radius on all corners and scaling the box to be just 30px wide will result in 15px radius corners. This is useful since you can then basically make Styleboxes that are round or have rounded ends at any size < 2*the corner radius.
The issue is that as you can see this downscaling doesn't work correctly if you have a border width set for the StyleBox. It seems this messes up the downscaling size calculation somehow, so the middle vertices become misaligned, resulting in graphical artifacts. Especially if you have alpha blending on the BG Color:
https://user-images.githubusercontent.com/17763524/201317258-5d6274e6-8095-4359-97f0-2822f3c34756.mov
Steps to reproduce
Setup:

Create a Panel in a new 2d scene

Set the panel to use a new StyleBoxFlat ThemeOverride style

Set the BG Color to be a semi-transparent color

Set a border width on all sides (larger like 5 for more obvious result)

Set a corner radius on all corners (larger like 20 for more obvious result)

Now, resize the Panel and observe an overlap appear in the middle as described above if the panel is made smaller than 2xCorner radius so downscaling of the radius is applied.

Minimal reproduction project
See steps to reproduce, should work in any project?

Happens also in v3.5.1.stable.official [6fed1ffa3]. Caused by antialiasing (and semi-transparent background color):

Still happens in 4.0.beta10 and just like @kleonc noted it seems like it's related to the anti-aliasing size. If I reduce it to zero the problem goes away in 4.0beta 10 as well. I guess it's just not accounted for when the downscaling of the corner radius is done, so it causes overlapping rendering. I'll update the bug title to make this clear.


fixed issue using paste_preprocess & postprocess in TINYMCE_DEFAULT_CONFIG

Just had to add some required double quotes to fix #166 (minor bug fix building on #3)

This did not fully fix the issue, I'm closing this pull request and will open a new one when I figure out the new piece of the puzzle.


How do i fix this

How to i make the second [*] dissapear?
Plugins that might conflict is the towny plugin.
Anyways please help ;I

First of all, this not the LuckPerms repository. Second LuckPerms is not responsible for displaying your prefixes, etc. That's entirely up to your chat plugin. Check their docs and ask for help on their support channels.


fix lints

Update package cache before apt installs
Use newest versions of workflow actions
Add Dependabot for GitHub Actions

Going to open as a PR against @ripleymj's other fixes in #490


Too many unnecessary_return messages

There are a lot of unnecessary_return messages related to something like this:
  METHOD zif_abapgit_background~get_settings.
    RETURN.
  ENDMETHOD.

  "unnecessary_return": true,
  "method_length": true, //   "errorWhenEmpty": true is the default

It's common also to prevent method_length errors.
Maybe add a parameter to skip these.

@mbtools try again, 2.108.9
https://rules.abaplint.org/unnecessary_return/

👍


refactor(FlowTool.py): update FlowToolComponent class to inherit from LCToolComponent

Updates FlowToolComponent to the new Component architecture.

Not able to use the search option to find flows:

The Dropdown is also allowing the user to select multiple flows (and none of them appears as selected in the field)
https://jam.dev/c/6ad09f07-a670-4471-8b98-c0814f515617
And another bug just ocurred after this.
I switched back to the Langflow tab, got an "Unexpected Error", and the component showed a Warning sign to update it.
After updating it, the dropdown to select flows stopped working.
https://jam.dev/c/161f2b66-80b3-4fab-964b-c1474f39a911
That was wierd bc I didn't touch the backend, so there was no update or pull, between those two videos.


how to modify exoplayer gradle dependency

I am trying to adapt react-native-track-player example for my needs.
I have made modifications to load custom tracks list successfully, however I need to make lower level modification so that playback stops after the audio file is played. I have checked it uses exoplayer gradle dependency for android. (I don't care about iOS).
What would be the steps to follow to download Exoplayer source code and load it from react native?

@jaimecoj the title of this issue doesn't seem to line up with your description. It sounds like you're trying asking how to build your own version of RNTP? If that's the case I'd just recommend forking the project and the underlying KotlinAudio project and modifying it to fit your needs.
I'm going to close this as it doesn't seem there's anything actionable on our side. LMK if you disagree.


pod 'SQLite.swift/standalone' doesn't build any more

Issues are used to track bugs and feature requests.
Need  help or have a general question? Ask on Stack Overflow (tag sqlite.swift).

Build Information

I tried with both 0.12.0 and 0.12.2
Xcode 11.6
How do do you integrate SQLite.swift in your project?

CocoaPods

General guidelines

If I have this line:     pod 'SQLite.swift', '~> 0.12.2' then I can build the project, however, if I use     pod 'SQLite.swift/standalone', '~> 0.12.2' then the project won't build due to errors like: "Ambiguous use of 'SQLITE_DETERMINISTIC'"

Sadly this means I can't use FTS or anything since the non-standalone version isn't compatible.

Provide as much information needed to reliably reproduce the issue.
Create a new xcode project,

Use this podfile:
use_frameworks!
workspace 'targetname'
target 'targetname' do
pod 'SQLite.swift/standalone', '~> 0.12.2'
pod 'sqlite3/fts5', '= 3.15.0'  # SQLite 3.15.0 with FTS5 enabled
platform :ios, '13.0'

end

Just for funsies I hacked in the fix and changed Connection.swift:590 to flags |= sqlite3.SQLITE_DETERMINISTIC,
But then when you add pod 'sqlite3/fts5', '= 3.15.0'  # SQLite 3.15.0 with FTS5 enabled to the Podfile a bunch more issues arise (of the exact same nature)

I have found a temporary solution.
Check https://github.com/stephencelis/SQLite.swift/pull/970
My podfile now:
pod 'SQLite.swift/standalone', :git => 'https://github.com/stephencelis/SQLite.swift', :branch => 'master'
pod 'sqlite3', '3.29.0'

@stephencelis - Hope this message finds you well! You're probably scrambling with supporting the new iOS 14 release and cramped for time. I know I am haha. Anyway, wanted to call your attention to this post where it looks like the fix for supporting Xcode 12 is already in master. Would it be possible to cut a release? Thanks for considering! Maybe #1006 would also fix the root issue?
@Pulichev - Appreciate letting us know of a workaround, this worked for me, thank you!

Closing as it was fixed


urh: 2.1.1 -> 2.2.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/urh/versions.
These checks were done:

built on NixOS
/nix/store/v7164xfx4b3rgbfx064wd3m6dk0fyp8n-urh-2.2.2/bin/.urh-wrapped passed the binary check.
/nix/store/v7164xfx4b3rgbfx064wd3m6dk0fyp8n-urh-2.2.2/bin/urh passed the binary check.
/nix/store/v7164xfx4b3rgbfx064wd3m6dk0fyp8n-urh-2.2.2/bin/.urh_cli-wrapped passed the binary check.
/nix/store/v7164xfx4b3rgbfx064wd3m6dk0fyp8n-urh-2.2.2/bin/urh_cli passed the binary check.
4 of 4 passed binary check by having a zero exit code.
2 of 4 passed binary check by having the new version present in output.
found 2.2.2 with grep in /nix/store/v7164xfx4b3rgbfx064wd3m6dk0fyp8n-urh-2.2.2
directory tree listing: https://gist.github.com/81386656453f8d5f0c949b53d0839bb3
du listing: https://gist.github.com/04e2f4b58a606d8685287a855fe578b5

meta.description for urh is: '"Universal Radio Hacker: investigate wireless protocols like a boss"'.
cc @fpletz for testing.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 271980cec3cbc4c2b951ca2ad22f2676f024e56f && nix-shell --pure -I nixpkgs=. -p urh

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: urh
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Failure on aarch64-linux (full log)
Attempted: urh
Partial log (click to expand)
[4829/16620] CXX obj/third_party/icu/bundled_icui18n/scriptset.o
[4830/16620] CXX obj/third_party/icu/bundled_icui18n/smpdtfst.o
[4831/16620] CXX obj/third_party/icu/bundled_icuuc/uinit.o
[4832/16620] CXX obj/services/service_manager/service_manager/service_manager.o
[4833/16620] CXX obj/third_party/angle/translator/Initialize.o
[4834/16620] CXX obj/third_party/hunspell/hunspell/replist.o
building of '/nix/store/wvq488xi3ynj2yvl9i7r37bp5nylgqg7-qtwebengine-5.11.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/hjl8p6bkwdc6cvzi0qpcjysygj0csagk-python3.6-PyQt-5.10.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/p8f5ca5qh7yik9fs9ia3w9y3xx440sim-urh-2.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/p8f5ca5qh7yik9fs9ia3w9y3xx440sim-urh-2.2.2.drv' failed


Pre-Validate kubeconfig before making available in Lens

Fixes: #843
Signed-off-by: Steve Richards<EMAIL_ADDRESS>

This now just silently excludes bad contexts from the "Select contexts" list. No more notifications?

@jim-docker I know a lot more people were annoyed by the notifications.

@jim-docker I know a lot more people were annoyed by the notifications.

They don't like being told that there are errors in their kubeconfig? This is only when adding clusters, which isn't done that often(?) Anyway, none of my last comments here are blockers, this PR is an improvement.

See the two linked issues.


Add Flag for Initializer Container Entrypoint to Not Exit Upon Completion

Is your feature request related to a problem? Please describe
When I use docker-compose or other AWS ECS Fargate deployments using supplied containers, it would be ideal to perform maintenance operations, scripted or manual, from the preexisting initializer container. Since this containers always exit upon completion, it must be restarted or (more applicable to cloud deployments) recreated.
Describe the solution you'd like
As a DevOps engineer that tests and deploys production workloads using docker, to better facilitate automated and manual maintenance work on the application or database, I would like a flag, using environmental variables, to default to exiting on completion of the initializer container, or optionally allow to leave it running for ongoing use.
Describe alternatives you've considered
Alternatives are manually working around container exits and restart or recreating containers, but for sustained development and production workloads, especially in the cloud, this is irritating.
Additional context
More context in discussion with developers in OWASP #defectodojo-dev thread.

This sounds like a bit of an anti-pattern. The initializer is made to initialize, not perform subsequent maintenance operations.
What operations are you thinking about?

This sounds like a bit of an anti-pattern. The initializer is made to initialize, not perform subsequent maintenance operations.

Hence I do not make it the default behavior? :-P

What operations are you thinking about?

Jokes aside, we often run deployments in ECS, we can set up another task, but it is just more to do so with the existing change for this one minor difference. It just is a dead task because it completes, and keeping it warm would mean less hassle for me, maybe potentially others?
Whether local docker-compose or ECS as described, I then have to build another container with all the proper configuration and secrets in another place, and I'd rather not sprawl it elsewhere (especially the latter), and I'd rather not run administrative operations in the UWSGI app container itself, but maybe that is not worthwhile?
What kind of operations? Essentially anything I would need to do with manage.py. So,

Account resets
Data migrations
Using dbshell
AdHoc data load and data dumping (dumpdata and loaddata)

I could put it elsewhere, but in our cases sometimes it is convenient. How are you and others handling these things? Separate util container or just shelling in?


Add scale option to ToDtype. Remove ConvertDtype.

Closes https://github.com/pytorch/vision/issues/7756
this PR:

adds a scale parameter to ToDtype, which only affects images or videos
removes ConvetDtype to keep ConvertImageDtype. ConvertImageDtype now only supports images, not videos.
removes all  dispatchers / kernels associated with convert_.*  and replace with to_dtype* dispatchers / kernels.
When passing ToDtype(torch.float32) i.e. the dtype parameter is just a dtype, not a dict, we only convert images and videos - this is for BC with ConvertImageDtype and reduces adoption friction

(I may have removed too much stuff on the existing tests, we'll see with the CI)

Tests are green in 92f2588 except for the linter which I just fixed. Merging, thanks for the reviews!


Flyway gradle task cannot open file within custom location (windows)

Which version and edition of Flyway are you using?
6.0.2
If this is not the latest version, can you reproduce the issue with the latest one as well?
(Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Gradle plugin
Which database are you using (type & version)?
Oracle 11.g.
Which operating system are you using?
Windows
What did you do?
(Please include the content causing the issue, any relevant configuration settings, the SQL statement that failed (if relevant) and the command you ran.)
Start gradle build with custom location:
gradle flywayMigrate -i -Pflyway.locations=filesystem:"./src/main/resources/db/seed"
What did you expect to see?
Executed scripts in seed directory.
What did you see instead?

What went wrong:
Execution failed for task ':flywayMigrate'.

Error occurred while executing flywayMigrate
Unable to load filesystem resource: .\src\main\resources\db\seed\V10__AGC_CUSTOM_TABLE_TYPE.sql (encoding: UTF-8)
.\src\main\resources\db\seed\V10__AGC_CUSTOM_TABLE_TYPE.sql

Thanks for the report. I've been able to reproduce and develop a fix for this. It should be available in the next release.


set Cache to Redis

Coverage decreased (-0.2%) to 78.826% when pulling 30b743e13acd418ba9a7d6948411decd8e3824ae on feature/redis into 7e7d5d1ca43441da78c9f148faa41bddf3c1ae2c on develop.


has no attribute dynamic_rnn_decoder

File "xxx/project/PycharmProjects/seq2sql/pointer-network/pointer-network-tensorflow/layers.py", line 22, in
dynamic_rnn_decoder = tf.contrib.seq2seq.dynamic_rnn_decoder
AttributeError: 'module' object has no attribute 'dynamic_rnn_decoder'

print tensorflow.version
1.0.0

Have you solved it? I have the same problem.

Have you solved it? I have the same problem.


Styling

i think responsiveness is still missing @christian-rosner am i right?

i think responsiveness is still missing @christian-rosner am i right?

Yes you're right, this will be the next step ;)


Multiplex extern dir for more versatile/flexible cross-toolkit compiling

(Like "multi-arch" on Linux etc.)
This should in turn finally enable local build (i.e. linking! -- compilation is platform-agnostic already!) with both MSVC and GCC without any additional SFML setup when switching between them.

-> f06e8123a4f62a88a111fcc19cd812943a4e4901


Network filtering

May I ask for two small improvements related to network filtering

make network filter selection persistent across sessions
make network filter input field permanently visible or make filter sliding pane to preserve open state when reopening LTN and also across sessions

The reason is that I have main network #1 and network for excess items #2. I look 99% of time on just main network, so each time I load game I have to reenter 1 in network filter field. And each time I have to check what network is selected, I have to reopen filter pane.

Both of these will be addressed in the GUI redesign:

Great! Any hint on release time?

Not soon. I was almost done with the redesign, but ended up having to scrap the framework that I wrote for it because it was too slow. So basically, I have to start over from scratch again.


Add TravisCI and Credo to the project

Closes #6 and #7.
RTC @ponty96 && @yburyug

This will fail until #10 is merged in and this is rebased 👍


v0.5.0 Preview(mainly for dcd)

Refactor dcd api, only use async functions to match for os.
Refactor dcd out callback from out data irq to out data transfer done irq(like uart recv irq to uart rx dma irq)
Add nbytes para that means number of bytes correctly transferred for ep callback

done


Added recovery rate column and mortality rate column to the table

Description of PR
Type of PR

[ ] Bugfix
[x] New feature

Relevant Issues
Fixes #...
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots

The recovery rate and mortality should be calculated based on the Recovered and Deceased cases only, not the Total Active cases because we don't know the outcome of the Active cases.
The above method is also not completely correct but is the closest to correct.
References:

https://www.worldometers.info/coronavirus/coronavirus-death-rate/#correct
https://academic.oup.com/aje/article/162/5/479/82647

Hey thanks for the PR! As mentioned in the contributing guide, please have an issue filed first, have it accepted, then assigned to you before submitting a PR :)
This will help us discuss any changes/requirements before work is done on it!


add kubejob to upgrade cluster

Updates:

added kubejob to trigger upgrade
monitoring upgrade job upto 60min to be successful else timeout
removing curatorjob,  desiredcuration , all status except clustercurator-job status on successful curation.. keeping clustercurator-job status for UI
removing curatorjob on failed curation
added job_failed condition for clustercurator-job and failed containers

status for failed job will look like
status:
  conditions:
  - lastTransitionTime: "2021-04-27T20:41:43Z"
    message: curator-job-jx6xp failed - Provided version is not valid
    reason: Job_failed
    status: "True"
    type: clustercurator-job
  - lastTransitionTime: "2021-04-27T20:41:32Z"
    message: Completed executing init container
    reason: Job_has_finished
    status: "True"
    type: prehook-ansiblejob
  - lastTransitionTime: "2021-04-27T20:41:42Z"
    message: Provided version is not valid
    reason: Job_failed
    status: "True"
    type: upgrade-cluster

/hold

/cc @jnpacker

/cc @hanqiuzh Since you had done upgrade for UI 😄

/cc @hanqiuzh

/lgtm


check for integer overflow / truncation

if iconData->iconBitsLength is large enough iconData->iconFileSize could be truncated, which would result in an allocation that is way too small. Memory corruption would follow. You probably get lucky on that 2nd part, since  ReadBYTES() probably bails out before any copy occurs. Although MSDN does say: "There is no hard limit on the size of the data that can be sent", so maybe it could corrupt memory if ~4gig of data is send over the channel.

Haven't heard back, opened a new PR to get this in: #562


fix Launch Darkly naming?

Trivial issue, but I noticed that Launch Darkly was referred to as "LaunchDarkley" in the text. Propose #3 to fix.

Thanks. Merged it back.


Update stable version in repo from 0.0.3 to 0.0.5

Think about update stable version to 0.0.5
Version: stable=0.0.3 (268 days old) => latest=0.0.5 (15 days old)
Installs: stable=141 (75.81%), latest=18 (9.68%), total=186
Click to use developer portal
Click to edit
Note: This is an automatically generated message and not personally authored by bluefox!

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 0.0.5 but in the meantime an update to version 0.0.7 is suggested.
So this issue will be closed and replaced by an updated one.
@mcm195 for evidence


Container "Unhealthy" in Portainer

🐛 Bug Report
Portainer labels this container as "unhealthy" with the "Failure count" climbing by one every 30 seconds. When I go into the Portainer event list, it just says "Unsupported event". I don't see anything problems in the actual container logs, and the container otherwise runs well. I am currently running containers on a QNAP NAS via Container Station.
To Reproduce

Install the portainer/portainer-ce:latest container (current version 2.0.0)
Install felddy/foundryvtt:release
In Portainer web interface, go to containers, see the state of FoundryVTT to be "unhealthy" instead of "running."
In Portainer web interface, open FoundryVTT container, see "Container Health Status: unhealthy" and "Failure count" increase by one every 30 seconds
In Portainer web interface, go to Events and see every 30 seconds:

2020-11-27 23:11:29 | container | Unsupported event
2020-11-27 23:11:29 | container | Exec instance started
2020-11-27 23:11:29 | container | Exec instance created

Expected behavior
Healthy container
Any helpful log output
Please run this command:
docker inspect --format='{{range $k, $v := .Config.Labels}}
    {{- printf "%s = \"%s\"\n" $k $v -}} {{end}}' \
    felddy/foundryvtt:latest

Paste the results here:
[~] # docker inspect --format='{{range $k, $v := .Config.Labels}}
    {{- printf "%s = \"%s\"\n" $k $v -}} {{end}}'     felddy/foundryvtt:release
com.foundryvtt.version = "0.7.7"
org.opencontainers.image.authors =<EMAIL_ADDRESS>org.opencontainers.image.created = "2020-11-13T16:03:01Z"
org.opencontainers.image.description = "An easy-to-deploy Dockerized Foundry Virtual Tabletop server."
org.opencontainers.image.licenses = "MIT"
org.opencontainers.image.revision = "acf4d926c2645b9f810a2dff5169580d2354b78b"
org.opencontainers.image.source = "https://github.com/felddy/foundryvtt-docker.git"
org.opencontainers.image.title = "foundryvtt-docker"
org.opencontainers.image.url = "https://github.com/felddy/foundryvtt-docker"
org.opencontainers.image.vendor = "Geekpad"
org.opencontainers.image.version = "0.7.7"

Run the container with CONTAINER_VERBOSE set to true,and paste any useful
log output here:
Entrypoint | 2020-11-28 05:19:06 | [info] Starting felddy/foundryvtt container v0.7.7,
Entrypoint | 2020-11-28 05:19:06 | [info] Foundry Virtual Tabletop 0.7.7 is installed.,
Entrypoint | 2020-11-28 05:19:06 | [info] Not modifying existing installation license key.,
Entrypoint | 2020-11-28 05:19:06 | [info] Setting data directory permissions.,
Entrypoint | 2020-11-28 05:19:10 | [info] Starting launcher with uid:gid as foundry:foundry.,
Launcher | 2020-11-28 05:19:10 | [info] Generating options.json file.,
Launcher | 2020-11-28 05:19:10 | [info] Setting 'Admin Access Key'.,
Launcher | 2020-11-28 05:19:10 | [info] Starting Foundry Virtual Tabletop.,
FoundryVTT | 2020-11-28 05:19:11 | [info] Foundry Virtual Tabletop - Version 0.7.7,
FoundryVTT | 2020-11-28 05:19:11 | [info] Running on Node.js - Version 12.19.0,
FoundryVTT | 2020-11-28 05:19:11 | [info] Loading data from user directory - /data,
FoundryVTT | 2020-11-28 05:19:11 | [info] Application Options:,
{,
  "port": 30000,,
  "upnp": false,,
  "fullscreen": false,,
  "hostname": "(hidden)",,
  "routePrefix": "foundryvtt",,
  "sslCert": null,,
  "sslKey": null,,
  "awsConfig": null,,
  "dataPath": "/data",,
  "proxySSL": true,,
  "proxyPort": 443,,
  "minifyStaticFiles": false,,
  "updateChannel": "release",,
  "language": "en.core",,
  "world": null,,
  "serviceConfig": null,,
  "isElectron": false,,
  "isNode": true,,
  "isSSL": false,,
  "demo": false,,
  "noupdate": false,,
  "adminKey": "****************",
},
FoundryVTT | 2020-11-28 05:19:11 | [info] License verification succeeded,
FoundryVTT | 2020-11-28 05:19:12 | [info] Server started and listening on port 30000

Inspecting container includes this:
    "State": {
        "Dead": false,
        "Error": "",
        "ExitCode": 0,
        "FinishedAt": "2020-11-28T05:18:56.087416684Z",
        "Health": {
            "FailingStreak": 27,
            "Log": [
                {
                    "End": "2020-11-27T23:33:09.088843651-06:00",
                    "ExitCode": 1,
                    "Output": "",
                    "Start": "2020-11-27T23:33:09.001680468-06:00"
                },
                {
                    "End": "2020-11-27T23:33:39.184889219-06:00",
                    "ExitCode": 1,
                    "Output": "",
                    "Start": "2020-11-27T23:33:39.092357315-06:00"
                },
                {
                    "End": "2020-11-27T23:34:09.290409289-06:00",
                    "ExitCode": 1,
                    "Output": "",
                    "Start": "2020-11-27T23:34:09.189952448-06:00"
                },
                {
                    "End": "2020-11-27T23:34:39.393606688-06:00",
                    "ExitCode": 1,
                    "Output": "",
                    "Start": "2020-11-27T23:34:39.297397814-06:00"
                },
                {
                    "End": "2020-11-27T23:35:09.489496139-06:00",
                    "ExitCode": 1,
                    "Output": "",
                    "Start": "2020-11-27T23:35:09.398550595-06:00"
                }
            ],
            "Status": "unhealthy"
        },
        "OOMKilled": false,
        "Paused": false,
        "Pid": 9716,
        "Restarting": false,
        "Running": true,
        "StartedAt": "2020-11-28T05:19:06.401790056Z",
        "Status": "running"
    }

Thanks for the issue, and the great detail.
So I believe the Unsupported event you are seeing in the log is caused by this Portainer issue:
https://github.com/portainer/portainer/issues/2717
I don't think the event is causing the health check to fail.  I'll fire up a Portainer instance and see if I can reproduce it.

i can run the images as healthy. so perhaps a problem with the enviroment/label configuration


vs2019 no context menu options

Extension says it is installed.
vs2019
windows 10
I've tried right clicking on a file called flow.frag, and the containing folder. Are there extra step necessary to recognizing the shader files? Thank you!

No, there are no extra steps required aside from installing the extension. It should detect file extensions and show compile options.

vs professional 2019
windows 11
like

Extension says it is installed. vs2019 windows 10
I've tried right clicking on a file called flow.frag, and the containing folder. Are there extra step necessary to recognizing the shader files? Thank you!

me too， can not show compile options.
vs professional 2019
windows 11

No, there are no extra steps required aside from installing the extension. It should detect file extensions and show compile options.
Extension says it is installed.
vs2019
windows 11

no  compile options. can you help me, Thanks!

installed directly from the IDE.


Support for passing additional args to API server, controller manager, and scheduler

What this PR does / why we need it:
This PR adds support in KubeOne to configure additional flags and feature gates for the following components:

API server
Controller Manager
Scheduler

KubeOne also configures flags and crucial feature gates that are essential for the working of the underlying Kubernetes cluster. Due to this these flags and feature gates are always merged with what KubeOne configures. Since it's easy to misconfigure feature gates, we have prohibited users from specifying them with flags and instead created a dedicated featureGates field.
Which issue(s) this PR fixes:

Fixes #2275 #2431
xref #3143
What type of PR is this?

/kind feature
Special notes for your reviewer:
Resurrection of https://github.com/kubermatic/kubeone/pull/3074
Does this PR introduce a user-facing change? Then add your Release Note here:

Support for passing additional args to the API server, controller manager, and scheduler

Documentation:

TBD

/assign @kron4eg

/assign cnvergence

I have tested it with the AWS cluster, this configuration seems like it covers most of the options and they are being applied properly.
I am not sure how I feel about allowing all of them while enabling support in these components seems to be non-breaking, fiddling with configuration files, for instance providing the wrong path for TLS cert, breaking cluster with manual cluster repair required, if you try to rollback it with KubeOne.

I am not sure how I feel about allowing all of them while enabling support in these components seems to be non-breaking, fiddling with configuration files, for instance providing the wrong path for TLS cert, breaking cluster with manual cluster repair required, if you try to rollback it with KubeOne.

Hey @cnvergence, this has been quite thoroughly discussed internally. We are aware of the risks, as mentioned in the documentation of the structs/fields as well. However, we don't want to block users from overriding these values since some times it's essential for their workflows.

Understood, for that extensibility I am all for it, as it is a strong feature request
Just would love to have this process well explained and easier to mitigate


Support Vite 3

Jetstream and laravel default is vite 3 now

Thanks!

hi, did u tag a new release?

There release has been tagged now. 👍


Tests for utilities/Utilities

Need testing for utilities/Utilities.js module

Also, would recommend splitting RDF utilities into own file.

Will write tests if/when these are touched.


Black square artifacts when using bloom

Description of the bug
Using bloom effect causes artifacts (only at specific camera position). Artifact are more prevalent when using complex geometry (especially smooth normals)
To Reproduce
https://codesandbox.io/s/diamond-refraction-bug-lsmfs8
move around, artifacts will appear at certain position
Screenshots

Artifact size is proportional to bloom levels

Library versions used

Three: 0.158.0
Post Processing: 6.33.3

Desktop

OS: 6.5.9-arch2-1 GNU/Linux
Browser Firefox 119.0 and 118.0.5993.117 (Official Build, ungoogled-chromium) Arch Linux (64-bit)
Graphics hardware: NVIDIA-SMI 535.113.01  (gtx 1050)

Looks like a duplicate of #526.
Please make sure that the model you're using isn't broken. Incorrect textures can cause lighting calculations to produce negative values.

Please make sure that the model you're using isn't broken

Not sure what constitutes as broken model (all models I tried have artifacts). Maybe it's the mix of MeshRefractionMaterial and Bloom pass?  But I just tested reproduction sandbox on Intel Macbook and I don't see any artifacts.

Ok, the issue is division by 0.0 somewhere in MeshRefractionMaterial's frag shader. I tested it by adding following at the end of MeshRefractionMaterial's frag shader:
  if(uv.x < 0.54 && uv.x > 0.5 && uv.y < 0.5 && uv.y > 0.46) {
    gl_FragColor = vec4(1.0 / 0.);
   }

And fixed artifact appears

Closing this since it's not a bug in postprocessing.


data is not required in getRules response

Fix for https://github.com/twitterdev/twitter-api-java-sdk/issues/33
Change data to be a non mandatory field in RulesLookupResponse

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.tmoskovitch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[QNN] Concatenate operator

@FrozenGene @u99127 @jackwish @tqchen
Pinging for review. The code changes will be very small after we have requantize merged in.

Thank you @anijain2305 , please remind me when this PR rebased to a merged requantize head :)

@u99127 @jackwish This is now ready for review.

@u99127 @tqchen Please review as you get time.

@u99127 @ZihengJiang @vinx13 Please review. This (hopefully) should be quick.

It seems this PR has not passed the CI test? The new added test will raise error.
http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3762/5/pipeline
http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/master/1448/pipeline

@ZihengJiang @vinx13 Add the following quick fix for InferType
https://github.com/dmlc/tvm/pull/3779


Can push consumers provide a single message consumption API?

Is Your Feature Request Related to a Problem?
In a batch of messages, if the last few messages fail to consume, other messages that successfully consume must also return a failure result, causing duplicate consumption.
Describe the Solution You'd Like
Consumers provide a single message consumption callback method, which processes one message at a time and returns the consumption result after each message is processed.
 But this approach affects performance and is not very recommended.
Additional Context
None

Actually, you can set the ackIndex  when use DefaultMQPushConsumer. The value can mark the consumed index of a batch msgs.
DefaultMQPushConsumer consumer = new DefaultMQPushConsumer("Test");
consumer.subscribe("TopicTest", "*");
consumer.registerMessageListener((MessageListenerConcurrently) (msgs, context) -> {
    for (int i = 0; i < msgs.size(); i++) {
        // handle msg
        if (!handle(msg)) {
            context.setAckIndex(i - 1);
        }
    }

    // Just return success, more detail can see ConsumeMessageConcurrentlyService#processConsumeResult;
    return ConsumeConcurrentlyStatus.CONSUME_SUCCESS;
});
consumer.start();


Add argument assume_normal and treatment_cost to calculate_prob_uplift_over_zero() and prob_uplift_over_zero_single_metric()

as discussed by #2 and #24

Hey @jbao @mkolarek @elezar, still planning on this?  Want to add a Help Wanted label?

Low priority, close for now.


feat(api): graphql endpoint for querying meeting data

Proof of concept
Must migrate to Django 4 first. Current graphql libraries for django require v3-4+.

Graphene is not really being actively maintained. Strawberry is the suggested alternative.
Closing in favor of the feat/strawberry branch.


New version requires XCB

New version requires XCB which seems to be not available in regular repos. Could you either add required libs into RPM (bundle them under /usr/share/newcompositor/lib) or maybe have a version without this requirement?

It should be installable from my OpenRepos repo, and I've added the build dependencies as well now (libxcb-devel and its requirements). Let me know if there is still interest in a version without the XCB dependency despite this.

I see. Well, it looks like X11 support is important for you. I would have skipped it. But I am not sure it makes sense to have heavy IFDEF sections to get that code out while building newcompositor for Wayland either.
I will be able to get back to chromium building a bit later - want to setup builds for qtwebengine first.

Xwayland support now optional when building with qmake.


[Q] How do I not open Chrome if it is not already open?

chrome-cli info opens Chrome when Chrome is not open. I want it to just return an error.

Until a fix is in place you might be better off counting the number of windows chrome-cli list windows | wc -l and only running chrome-cli info when that value is greater than 0.


I created 4 tasks of the same type Job, but at the same time there were only 3 tasks running

I created 4 tasks of the same type Job, but at the same time there were only 3 tasks running

Hello @ruanzy, that should not happen. Can you please create a Unit test to proof this? It's hard to go on without any tests.

Closing outdated, unresolved issues. Please, reopen if still relevant.


Add new hesa degree type codes for 2023

HESA has added a handful of new codes for degree type at our request. We already have these in our reference data, so this updates with the relevant codes.

👍 LGTM ! Could do with an update of the Ruby version though (And test version), but that's not a part of this PR.
This could be released with a minor version update. (Procedure is in the READ.me).
@duncanjbrown - Could you review please and make sure your happy with this change.


Use native maps when they're available

The summary is that using native maps, the compiler works 5% faster and uses 5% less memory. Using shims, the performance is surprisingly less than 5% worse.
I was able to achieve good baseline performance by disabling Windows Defender in my work directory and using "High Performance" in Control Panel -> Hardware and Sound -> Power Options. There is much less variance this time around.
Benchmark numbers
This is from using our internal ts-perf tool.
map4
Monaco
tsc (x86)

Project
Baseline
Current
Delta
Best
Worst

Parse Time
1.79s (±  0.95%)
1.72s (±  1.10%)
-0.07s (-  4.08%)
1.70s
1.74s

Bind Time
0.69s (±  4.74%)
0.52s (±  3.50%)
-0.17s (- 24.86%)
0.50s
0.54s

Check Time
3.37s (±  1.66%)
2.91s (±  3.16%)
-0.46s (- 13.69%)
2.78s
2.98s

Emit Time
5.01s (±  4.73%)
4.87s (±  1.35%)
-0.14s (-  2.77%)
4.79s
4.94s

Total Time
10.87s (±  2.34%)
10.02s (±  1.18%)
-0.84s (-  7.77%)
9.86s
10.12s

node (v6.7.0, x64)

Project
Baseline
Current
Delta
Best
Worst

Memory used
379,924k (±  0.00%)
356,928k (±  0.01%)
-22,996k (-  6.05%)
356,890k
356,956k

Parse Time
2.40s (±  0.75%)
2.32s (±  2.13%)
-0.08s (-  3.37%)
2.28s
2.39s

Bind Time
0.92s (±  1.79%)
0.71s (±  1.84%)
-0.21s (- 22.52%)
0.70s
0.73s

Check Time
4.26s (±  1.36%)
3.84s (±  6.33%)
-0.42s (-  9.94%)
3.66s
4.18s

Emit Time
1.87s (±  2.44%)
1.82s (±  3.16%)
-0.05s (-  2.80%)
1.77s
1.89s

Total Time
9.46s (±  1.19%)
8.69s (±  3.96%)
-0.77s (-  8.12%)
8.42s
9.16s

node (v6.7.0, x86)

Project
Baseline
Current
Delta
Best
Worst

Memory used
201,971k (±  0.00%)
190,504k (±  0.01%)
-11,467k (-  5.68%)
190,474k
190,538k

Parse Time
2.30s (±  0.89%)
2.20s (±  2.07%)
-0.09s (-  4.09%)
2.17s
2.27s

Bind Time
0.72s (±  0.99%)
0.57s (±  4.73%)
-0.15s (- 21.33%)
0.55s
0.61s

Check Time
3.48s (±  1.73%)
3.27s (±  4.68%)
-0.21s (-  6.08%)
3.08s
3.38s

Emit Time
1.91s (±  3.15%)
1.78s (±  8.00%)
-0.13s (-  6.94%)
1.65s
1.94s

Total Time
8.41s (±  0.61%)
7.82s (±  1.68%)
-0.59s (-  7.03%)
7.71s
7.99s

TFS
tsc (x86)

Project
Baseline
Current
Delta
Best
Worst

Parse Time
1.22s (±  2.62%)
1.15s (±  1.31%)
-0.07s (-  6.06%)
1.13s
1.16s

Bind Time
0.56s (±  2.96%)
0.54s (±  4.08%)
-0.02s (-  3.13%)
0.52s
0.57s

Check Time
2.81s (±  1.48%)
2.46s (±  1.85%)
-0.35s (- 12.34%)
2.43s
2.53s

Emit Time
3.11s (±  0.85%)
3.19s (±  0.91%)
+0.07s (+  2.33%)
3.15s
3.22s

Total Time
7.70s (±  0.84%)
7.34s (±  1.14%)
-0.37s (-  4.78%)
7.28s
7.46s

node (v6.7.0, x64)

Project
Baseline
Current
Delta
Best
Worst

Memory used
328,005k (±  0.00%)
309,449k (±  0.02%)
-18,556k (-  5.66%)
309,386k
309,516k

Parse Time
1.50s (±  1.02%)
1.44s (±  0.88%)
-0.07s (-  4.32%)
1.42s
1.45s

Bind Time
0.73s (±  0.73%)
0.58s (±  1.65%)
-0.14s (- 19.89%)
0.57s
0.59s

Check Time
3.89s (±  0.65%)
3.56s (±  4.42%)
-0.32s (-  8.27%)
3.42s
3.74s

Emit Time
1.54s (±  0.91%)
1.57s (±  4.86%)
+0.03s (+  2.25%)
1.51s
1.67s

Total Time
7.65s (±  0.65%)
7.16s (±  3.13%)
-0.50s (-  6.48%)
6.96s
7.42s

node (v6.7.0, x86)

Project
Baseline
Current
Delta
Best
Worst

Memory used
174,749k (±  0.00%)
165,316k (±  0.01%)
-9,433k (-  5.40%)
165,292k
165,344k

Parse Time
1.41s (±  1.63%)
1.33s (±  0.77%)
-0.08s (-  5.36%)
1.33s
1.35s

Bind Time
0.62s (±  5.95%)
0.50s (±  3.40%)
-0.12s (- 19.68%)
0.48s
0.52s

Check Time
2.98s (±  0.64%)
2.75s (±  0.96%)
-0.23s (-  7.73%)
2.71s
2.77s

Emit Time
1.35s (±  0.83%)
1.35s (±  1.29%)
+0.01s (+  0.45%)
1.33s
1.37s

Total Time
6.36s (±  1.07%)
5.94s (±  0.82%)
-0.42s (-  6.60%)
5.88s
5.98s

map4 with usingNativeMaps = false and usingNativeSets = false
Monaco
tsc (x86)

Project
Baseline
Current
Delta
Best
Worst

Parse Time
1.79s (±  0.95%)
1.80s (±  1.47%)
+0.01s (+  0.73%)
1.77s
1.82s

Bind Time
0.69s (±  4.74%)
0.71s (± 13.45%)
+0.02s (+  3.18%)
0.66s
0.86s

Check Time
3.37s (±  1.66%)
3.43s (±  3.44%)
+0.06s (+  1.68%)
3.29s
3.57s

Emit Time
5.01s (±  4.73%)
5.04s (±  4.80%)
+0.03s (+  0.66%)
4.93s
5.42s

Total Time
10.87s (±  2.34%)
10.98s (±  1.85%)
+0.12s (+  1.09%)
10.83s
11.29s

node (v6.7.0, x64)

Project
Baseline
Current
Delta
Best
Worst

Memory used
379,924k (±  0.00%)
383,279k (±  0.01%)
+3,355k (+  0.88%)
383,241k
383,338k

Parse Time
2.40s (±  0.75%)
2.39s (±  2.42%)
-0.01s (-  0.29%)
2.33s
2.44s

Bind Time
0.92s (±  1.79%)
0.90s (±  4.74%)
-0.02s (-  2.55%)
0.86s
0.96s

Check Time
4.26s (±  1.36%)
4.29s (±  0.29%)
+0.03s (+  0.66%)
4.28s
4.31s

Emit Time
1.87s (±  2.44%)
1.88s (±  1.90%)
+0.01s (+  0.51%)
1.85s
1.92s

Total Time
9.46s (±  1.19%)
9.47s (±  0.86%)
+0.01s (+  0.11%)
9.36s
9.54s

node (v6.7.0, x86)

Project
Baseline
Current
Delta
Best
Worst

Memory used
201,971k (±  0.00%)
203,972k (±  0.01%)
+2,001k (+  0.99%)
203,951k
203,991k

Parse Time
2.30s (±  0.89%)
2.29s (±  0.76%)
-0.01s (-  0.52%)
2.27s
2.31s

Bind Time
0.72s (±  0.99%)
0.68s (±  1.41%)
-0.04s (-  5.87%)
0.67s
0.69s

Check Time
3.48s (±  1.73%)
3.83s (±  1.77%)
+0.35s (+ 10.19%)
3.78s
3.92s

Emit Time
1.91s (±  3.15%)
1.62s (±  3.72%)
-0.29s (- 15.12%)
1.58s
1.71s

Total Time
8.41s (±  0.61%)
8.42s (±  1.66%)
+0.01s (+  0.12%)
8.32s
8.63s

TFS
tsc (x86)

Project
Baseline
Current
Delta
Best
Worst

Parse Time
1.22s (±  2.62%)
1.22s (±  5.54%)
-0.01s (-  0.49%)
1.17s
1.28s

Bind Time
0.56s (±  2.96%)
0.58s (±  5.13%)
+0.02s (+  4.38%)
0.57s
0.63s

Check Time
2.81s (±  1.48%)
2.84s (±  3.00%)
+0.03s (+  1.03%)
2.77s
2.95s

Emit Time
3.11s (±  0.85%)
3.16s (±  1.84%)
+0.05s (+  1.56%)
3.08s
3.21s

Total Time
7.70s (±  0.84%)
7.81s (±  2.01%)
+0.10s (+  1.32%)
7.60s
7.94s

node (v6.7.0, x64)

Project
Baseline
Current
Delta
Best
Worst

Memory used
328,005k (±  0.00%)
329,980k (±  0.02%)
+1,975k (+  0.60%)
329,913k
330,079k

Parse Time
1.50s (±  1.02%)
1.49s (±  0.69%)
-0.02s (-  1.13%)
1.47s
1.49s

Bind Time
0.73s (±  0.73%)
0.71s (±  3.11%)
-0.01s (-  2.00%)
0.68s
0.73s

Check Time
3.89s (±  0.65%)
4.04s (±  1.24%)
+0.15s (+  3.87%)
3.96s
4.06s

Emit Time
1.54s (±  0.91%)
1.64s (±  0.63%)
+0.10s (+  6.55%)
1.63s
1.65s

Total Time
7.65s (±  0.65%)
7.87s (±  0.76%)
+0.21s (+  2.80%)
7.79s
7.92s

node (v6.7.0, x86)

Project
Baseline
Current
Delta
Best
Worst

Memory used
174,749k (±  0.00%)
175,835k (±  0.01%)
+1,086k (+  0.62%)
175,822k
175,855k

Parse Time
1.41s (±  1.63%)
1.39s (±  0.74%)
-0.02s (-  1.10%)
1.39s
1.41s

Bind Time
0.62s (±  5.95%)
0.57s (±  3.30%)
-0.05s (-  8.48%)
0.56s
0.59s

Check Time
2.98s (±  0.64%)
2.99s (±  1.14%)
+0.02s (+  0.60%)
2.96s
3.04s

Emit Time
1.35s (±  0.83%)
1.38s (±  4.53%)
+0.03s (+  2.52%)
1.33s
1.45s

Total Time
6.36s (±  1.07%)
6.34s (±  1.32%)
-0.02s (-  0.25%)
6.25s
6.43s

Heap snapshot numbers
The memory usage tended to be about the same up until the beforeEmit event, AKA after checking.
Master had 365,935 KB total, map4 had 343,774 KB (94% as much), and map4 with shims had 368,978 KB (100% as much as master, 106% as much as map4).
(I added an event heapAfterBind to test the effects of that; map4 used 97% as much memory as master, meaning the real memory savings are during checking.)
For map4, the chrome heap snaprhot viewer shows Maps as accounting for 2% of all objects, with a shallow size equal to their retained size at 1%. However, this is misleading because most of them are mere 32KB wrapper objects which have internal _keys and _values (or table in some cases), which is what really takes up space. I wish there were a way we could include the size of those.

 A similar test can be done for native Maps and shows a similar result.
const Benchmark = require("benchmark");
const suite = new Benchmark.Suite;

const N = 10000;

function createMap() {
    const map = Object.create(null);
    map["__"] = null;
    delete map["__"];
    return map;
}

function initMap() {
    const map = createMap();
    for (let i = 0; i < N; i++) {
        if (i % 2 === 0)
            map[i] = i * 100;
    }
    return map;
}

suite.add("has-then-get", () => {
    const map = initMap();
    let sum = 0;
    for (let i = 0; i < N; i++) {
        if (i in map) {
            const x = map[i];
            sum += x;
        }
    }
    return sum;
});

suite.add("just get", () => {
    const map = initMap();
    let sum = 0;
    for (let i = 0; i < 100; i++) {
        const x = map[i];
        if (x !== undefined) {
            sum += x;
        }
    }
    return sum;
});

suite.on("complete", function() {
    this.forEach(({name, stats}) => {
        console.log(`${name}: ${stats.mean * 1000}ms`);
    });
});

suite.on("error", err => {
    throw err.target.error;
});

suite.run();

has-then-get: 0.75ms
just get: 0.23ms

This would be a breaking change. We have publicly exported maps because we have export type SymbolTable = Map<string, Symbol>;, which is the type of several public properties of Symbol.

@andy-ms  looks good for my end 👍  though it is a big change so I think it may be good idea to have @mhegazy  @vladima @sandersn @rbuckton to check as well

Can you also share the perf numbers once it is in.

@rbuckton any more comments?

Will do a final performance comparison tomorrow.


Use document as the scroll parent if the body is the scroll parent

Fix #116 by using the document instead of the body element as the scroll parent.

Poke!

Apologies @tim-evans, completely forgot about this! I'll do my best to get it tested tonight and merged. Will release a 1.9.1 this weekend :)

Ok - tested this and it works :) thanks for the PR @tim-evans!

👍


Add configuration stability information

Closes #2227
Stability extracted manually from config.rs. If I read #1998 correctly, the third argument to each line in the create_config! is a boolean indicating un/stable, which is what is now represented here as well.
The unstable_features option is not separately documented, only at the top as how to enable unstable configuration options.

Failure doesn't look like it's my fault
/Users/travis/.travis/job_stages: line 57: pip: command not found

I just confirmed that just doing cargo install --path . to install from the current master does not set CFG_RELEASE_CHANNEL to nightly when building (on Windows).
The behavior of 0.2.17 (current version on crates.io) is to check CFG_RELEASE_CHANNEL at runtime.   The behavior of master is to check CFG_RELEASE_CHANNEL at compiletime.
As far as I can tell, installing via cargo does not set CFG_RELEASE_CHANNEL, so if a user installs via cargo they currently cannot access unstable configuration options (on master, available on 0.2.17 via setting the env var at runtime).
As far as I can tell, testing for whether a crate is built with a certain rustc version is bound to run into endless edge cases. rustc_version can be used in a build.rs script to check rustc -vV, but just doing cargo +nightly build while the rustup default is stable means that you'll see stable in the build script but be building on nightly.
Doesn't rustfmt only work on nightlies, though? If my intuition is right and this is prepping for the eventual publishing of rustfmt through rustup, may I suggest flipping the condition to !matches!(env!(CFG_RELEASE_CHANNEL), "stable" | "beta")? This should allow checking CFG_RELEASE_CHANNEL when being built officially while still allowing cargo +nightly install rustfmt-nightly to work. Of course, if we can guarantee that rustfmt is always available through rustup then there would be no need for installing from crates.io, but I don't know how plausible that is.

For the time being I've left the documentation in Configurations.md to be accurate to the version currently on crates.io. @nrc, if we get 0.2.18 published where CFG_RELEASE_CHANNEL was checked at compiletime (to be nightly) instead of it checking at runtime like 0.2.17 does, I'll be happy to update the wordage to reflect usage. But for now I think it's more accurate to explain how to get the published version to work.

Yes, that is accurate to that wall of text I wrote tired. It makes sense to default to allowing unstable options, then disabling them for stable builds. Any build outside the compiler pipeline will be with the nightly toolchain.

@topecongiro @CAD97 yeah, I think it makes sense to assume nightly if CFG_RELEASE_CHANNEL is not set

Filed #2249 which should enable unstable features enabling when built by cargo but not when built with CFG_RELEASE_CHANNEL != "nightly".

Rebased on top of master for CI fix and cleanliness. Also rewords dcd6ed7 slightly to better reflect its new position in history.
If any lints have changed stability since I first issued this PR, ping me and I'll go through and check that the docs are accurate for all of the lints again. Still, it'd be good to see this doc merged.

Looks good, thank you!


⚠ Bofrost.be has degraded performance

In c8fa9f2, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1152 ms

Resolved: Bofrost.be performance has improved in 1eb1b3f.


tailscale: 1.34.1 -> 1.34.2

Description of changes

Diff: https://github.com/tailscale/tailscale/compare/v1.34.1...v1.34.2
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[X] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 209151 run on x86_64-darwin 1

1 package built:

tailscale


Prevent no-op tasks for taxonomy field updates.

Improves, but does not fully resolve, the performance problems described in issue #5663.

The change implies that if all terms have been removed, the count won't be processed. Which is wrong. Is it what you mean by "not fully resolve" ?

Actually, I think that's wrong.  If you look at TermCountProcessor.Process it does nothing if the termPartRecordIds is empty.  So we should lose nothing by not scheduling the task.
This does not fully resolve the issue because it only makes a moderate dent in the number of tasks that get scheduled when importing content items with taxonomy fields.  The performance problem is the result of (1) the overhead of running a single task and (2) the number of tasks that are generated.  I was seeing two tasks for each taxonomy field for each imported content item.  And on quite good hardware it takes about 2 seconds of spin-up/down time (plus the time to execute the task) for each task.

The performance problem is also compounded by the fact that multiple content items may use the same taxonomy terms.  But for each taxonomy field that is updated you get a task scheduled to run on the relevant terms.  You may end up processing the same term many times.
Ideally there would be a single task to run at the end of the request.  Instead of passing the terms as a parameter to the task, the list of terms would have to be queued up somewhere.  The task would eliminate duplicates and process the queue.  An approach like this would cut the content import time by about 80% for my simple example.

@mvarblow yes, a single task. Actually that's what I am doing for blog posts if I remember correctly.
        public void ProcessBlogPostsCount(int blogPartId) {
            if (!_processedBlogParts.Contains(blogPartId)) {
                _processedBlogParts.Add(blogPartId);
                _processingEngine.AddTask(_shellSettings, _shellDescriptorManager.GetShellDescriptor(), "IBlogPostsCountProcessor.Process", new Dictionary<string, object> { { "blogPartId", blogPartId } });
            }
        }

So this method is called every time there is a change, but itself will call the processing task accordingly. This is how we should do it, adding a level of indirection.

I just pushed some changes along those lines.  The TaxonomyService now queues up the updated terms in a HashSet and fires just a single task.  The TermsPartHandler does the same.  In addition, TermCountProcessor now checks to make sure it's not processing the same parent elements multiple times.
(I'd like to consolidate the code in TaxonomyService and TermsPartHandler into a single RecalculateCount method in TaxonomyService.  That would get us down to just a single task.  But then I'd have to change the ITaxonomyService interface.  I'd like to fix this in 1.9.x.  So a change to ITaxonomyService seems out of the question.)

@sebastienros I just pushed some changes along those lines. The TaxonomyService now queues up the updated terms in a HashSet and fires just a single task. The TermsPartHandler does the same. In addition, TermCountProcessor now checks to make sure it's not processing the same parent elements multiple times.
(I'd like to consolidate the code in TaxonomyService and TermsPartHandler into a single RecalculateCount method in TaxonomyService. That would get us down to just a single task. But then I'd have to change the ITaxonomyService interface. I'd like to fix this in 1.9.x. So a change to ITaxonomyService seems out of the question.)

@mvarblow, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


Add simple OpenNebula deprovisioning playbook

Signed-off-by: Nils Philippsen<EMAIL_ADDRESS>

LGTM and already tested in dev/stg env so merging. Thanks !


errors: GRPCStatus

Coverage increased (+0.09%) to 86.023% when pulling 8758dd9ed2bfc4f7bdcbf33501dc25446fc96d5f on dissoupov into 24a2b02188205528e0b1e0daa0acf03bf19f4285 on main.


API: allow no pwd room for admin, add participantName to join and make it uniq

room can be joined with a pwd, or without only for admin
add participantName to joinRoom
if no participantName, pick a random name for LOTR

wow guys, no comment or request for change? I'm getting better 😃 or you are squizzing the review :p

no comment was needed :p


chore: remove year from idea copyright template

Based on our discussion on Discord and the resulting decision to remove the year from our in-file copyright notices (see link).
Summary:
There's unclarity on whether the copyright year refers to the date of file creation, last change, or the current year.
Date of creation is hard to track and loses meaning in the light of code changes, moves, or copies.
Current year introduces maintenance overhead, especially for small maintainer groups such as ours.
Many organizations started removing the year from the in-file copyright notices.
Apache License requires us to include a LICENSE and a NOTICE file and to maintain file-level copyright notices.
It doesn't object to changing file-level copyright notices, for instance, removing the year.

The failing integration test is a known sporadic that is unrelated to the changes in this PR.
Merging despite failing checks.


2FA robustness improvements

@mehtaphysical this works fine with https://github.com/near/near-wallet/pull/1706

@vgrichina I forgot, there was a change so we require 2 approvals now

@vgrichina I forgot, there was a change so we require 2 approvals now

but why?

@mikedotexe can probably add more context about this change.


[tables] Changing column sizing breaks reference columns

I think there's an issue with how the table / column info data is being serialised and re-read.

Duplicate of #6144


Firmware should read EDID of output devices and warn about incompatibilities

So, we tested two resolution modes with Carl's monitor. 800x600 and 1024x768.
Setting video mode to 800x600 @56Hz
Setting video mode to 1024x768 @60Hz

Neither of these resolutions are supported by the EDID dump that Carl provided.
The firmware should warn if;

A monitor is connected which doesn't support the resolution the system is set to.
A resolution is set to a mode the connected monitors don't support.

This is related to #35 and possibly related to #18.

The sequence should be:

Detect Hotplug #33
Dump EDID #35
This issue #37

@fallen


Unable to initialize app with verison 0.59.10

Description
Unable to initialize a new app using the latest 0.59.x version, 0.59.10 as of this report. Initializing any newer version works, e.g., npx react-native init demo --version 0.60.0 does not have this problem.
React Native version:
0.59.10
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

npx react-native init demo --version 0.59.10

✖ Copying template
error Error: Couldn't find the "/var/folders/tb/wx5d6rj53qjdg6sr4bmb1l840000gn/T/rncli-init-template-kgOXPd/node_modules/react-native/template.config.js file inside "react-native" template. Please make sure the template is valid. Read more: https://github.com/react-native-community/cli/blob/master/docs/init.md#creating-custom-template

Expected Results
App is initialized successfully.
Snack, code example, screenshot, or link to a repository:

Tried this as a workaround:
npx<EMAIL_ADDRESS>init demo --version 0.59.10

…but it fails as well:

command not found: react-native

Heya! Good to cross paths again!
You'll probably get more help on the CLI repo over here: https://github.com/react-native-community/cli
It looks like they have documentation for using init that does mention the approach you are taking only works for >60. They have a section for how to init older versions here. It's kinda similar to what you tried last. https://github.com/react-native-community/cli/blob/master/docs/init.md#for-older-react-native-versions

@TheSavior Hi! Thanks for the info and quick response. 🙂

Could that link be added to the environment setup docs as a note? Would have saved us some time and frustration.