pgmq.drop_queue issues when queue doesn't exist

Hello,
We have this code (https://github.com/tembo-io/pgmq/blob/main/pgmq-extension/sql/pgmq.sql#L429) for dropping a queue:
ALTER EXTENSION pgmq DROP TABLE pgmq.q_%s;

ALTER EXTENSION pgmq DROP TABLE pgmq.a_%s;

DROP TABLE IF EXISTS pgmq.q_%s;

DROP TABLE IF EXISTS pgmq.a_%s;

Currently, when I drop a non-existing queue, the first statement fails with an error:
ERROR:  relation "pgmq.q_test" does not exist
CONTEXT:  SQL statement "
        ALTER EXTENSION pgmq DROP TABLE pgmq.q_test
        "

From PostgreSQL docs on DROP member_object:

This form removes a member object from the extension. This is mainly useful in extension update scripts. The object is not dropped, only disassociated from the extension.

We're in a user-called function here, not in an update script. Is there a point of altering the extension itself with queue/archive tables? Please look at 2 other SQL statements: we are careful here not to throw an error using the IF EXISTS. There is no IF EXISTS counterpart for ALTER EXTENSION ... DROP TABLE so maybe we just get rid of that ALTER EXTENSION altogether?
In fact, this causes even more problems. For example:
postgres=# select pgmq.create('test');
 create
--------

(1 row)

postgres=# select pgmq.detach_archive('test');
 detach_archive
----------------

(1 row)

postgres=# select pgmq.drop_queue('test');
ERROR:  table pgmq.a_test is not a member of extension "pgmq"
CONTEXT:  SQL statement "
        ALTER EXTENSION pgmq DROP TABLE pgmq.a_test
        "
PL/pgSQL function pgmq.drop_queue(text,boolean) line 10 at EXECUTE

pgmq is supposed to be used in highly concurrent environments - I think the less exceptions like that are thrown, the easier it is to maintain the software that uses it.

Hi @CGenie, thanks for raising the issue. The API around pgmq.detach_archive() is pretty rough at the moment. The reason it exists is to make it slightly more convenient to implement partitioning on an existing queue archive (creating new partitioned table, renaming old, etc.). The issue you showed above feels like a bug and I will need to think through how we can handle this more gracefully.
There is some ongoing work related to partitioning the archive tables that @shhnwz is handling. I think we can address this during that work.

Well, my overall idea was to get rid of critical errors. I don't use detach_archive, just gave it as an example.
But I think one shouldn't throw errors in drop_queue, at least the IF EXISTS statements give me the clue that this was the initial intention.

I agree. I think the same problem exists on pgmq.create() right now too.


Feature Request: Link to Commit/MR from Notifications

Hello,
Thank you for the excellent application! It has greatly improved my workflow.
I would like to suggest a small but impactful improvement: it would be very useful to have the ability to navigate directly to a commit or Merge Request (MR) when clicking on a notification. This would enhance the user experience by making it easier to review changes associated with specific notifications.
Thank you for considering this enhancement!
Best regards, fixcik

Thank you for the kind words!
Unfortunately, it doesn't seem possible to achieve this with Tauri at the moment: https://github.com/tauri-apps/plugins-workspace/issues/2150
If it becomes feasible in the future, I would definitely add this feature.


fix(VTU): fix issues in import of VTU files

:tada: This PR is included in version 4.6.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Maintenance mode banner now has super tiny text.

Let's revert this. I suppose this was an unintended consequence of the portal down message heading update.

https://prod.data.humancellatlas.org/explore/projects

We can remove the maintenance mode banner now.

aw yea? We will fix then, remove, so its not tiny when you ask us to add it back. ;)


[LANG-1622] - javadoc of some methods incorrectly refers to another method

https://issues.apache.org/jira/browse/LANG-1622


Remove unnecessary stack frame suffix

There's a bug in our current frame emission code where we emit three
Dynamo frames.  Actually, I think this is fixed in PyTorch main but
there's legacy code still running it.  Chop it off.
Signed-off-by: Edward Z. Yang<EMAIL_ADDRESS>

Stack from ghstack (oldest at bottom):

-> #24


12 release action

Add release.yml with workflow actions for building and pushing docker images.
Also needs secrets added with names (DOCKERHUB_USERNAME, DOCKERHUB_TOKEN) @kappsegla
Fixes #12

I can write a step by step guide for releases since i tested the code doing releases about 15 times, but i do not know best practice for naming them so if anyone has suggestions dont be afraid. :)

@kappsegla Do you know why it still complains about the line at the end?

@kappsegla Do you know why it still complains about the line at the end?

Yes, looks like line 45 has some spaces on it and not terminated with newline.

@kappsegla Do you know why it still complains about the line at the end?

Yes, looks like line 45 has some spaces on it and not terminated with newline.

Will fix this in the next commit.


Using multiple Google accounts

Suppose I have 2 Google Accounts and I am logged in on both of them:
Account#1 is default Google Account
Account#2
I log in to draw.io using Account#2 and suggested to load diagram from Account#2's drive.
Later I click to Open From -> Google Drive:
Expected:
I have file to select from Account#2's drive
Actual:
I have files to select from Account#1's drive
Setting authuser = -1 always may be the option, but it will probably damage UX a lot.

I've run in to this as well, a fix would be great.


App fails to auto update latest version

Describe the bug
Users on the earlier version of the app 10.13.3 are experiencing app stuck on starting mode, unable to auto update to latest version 10.14.2 automatically.
To Reproduce
Steps to reproduce the behavior:

Go to 'earlier version of app'
Click on app to launch it
See Download update error

Expected behavior
Update should download automatically as suggested in loading app screen
Logs
Attach logs (app, node, supervisor) to the issue. Where to find the logs: https://github.com/mysteriumnetwork/mysterium-vpn-desktop#logs
Screenshots

Desktop (please complete the following information):

OS: Desktop OSs
App Version: Latest

Additional context
Solution to this issue is to ask users to manually download new version:
"Please download newest app version manually instead, it should work then:https://github.com/mysteriumnetwork/mysterium-vpn-desktop/releases/"

I've been having this issue since yesterday. The Mysterium devs are awful at fixing stuff like this. There was a time where they deployed a build to production that stopped all Windows users from using the VPN and they didn't resolve it for days.
Anyway, what I've been doing since yesterday is just launching the client with -no-update, which I found digging around the source. https://github.com/mysteriumnetwork/mysterium-vpn-desktop/blob/c94ff3692dfd115b131dc74a301d647995949b96/src/main/index.tsx#L249
Once you do that, you can launch the client.

fix is just download the latest from GitHub
this is the issue their having right now

@isaackielma Hi, I'm not a Mysterium developer, but I'm a software developer and know the language it's written in. I attempted to replicate your issue by downloading the 10.13.3, however it worked properly for me. It said there was an update, downloaded it, told me to restart, then after a weird issue where it wasn't letting me restart, it seemed to be working properly (following a successful restart). After that it was asking me for my password to install a helper utility.
I am on MacOS Ventura Version 13.0.1. I have never used the Mysterium VPN before, but downloaded it in order to try and test this.
To help me better diagnose the issue, can you please provide a few more details:

What is your OS? What version of your OS do you have?
Have you updated the VPN before or is this the first time? If you have done it before, did it previously work (give as much detail as you can remember)?
Can you attach some logs? Remember to sanitize sensitive info.
What is the exact error you receive (screenshot if available please)?

Again, I am not a Mysterium developer and I can make no promises, but I will try to help out if I can, thank you.

having the same issue myself! will try github build!


Allow using external gtest with GTest:: qualified names

Thanks for the PR David.
I'll confess that I'm somewhat lacking in C++ and CMake experience, so would you mind explaining briefly how this will help you and others?

explaining briefly how this will help you

Well, I saw the option USE_EXTERNAL_GTEST, so I turned it on and pointed CMake to my own installation of GTest v1.12.1 using the GTest_DIR CMake variable so find_package could find it, and .....
It uses different names for its libraries in the v1.12.1 installation than you have in this CMakeLists.txt file.
So I patched it like this to use either flavor of names for the gtest libraries.
If the option exists to use an external GTest, then it seems to me that it should work after the find_package call successfully finds it.
Once everything was built correctly, all the test passed flawlessly. And all the examples worked great. Kudos on that! Love using a project where everything just works once it's built!

Is there a way not to have google test as a git submodule? because if I already have gtest or if I don't want testing, still git.exe submodule update --init --recursive populates it.


[Bug]: Can't export a generated module from a library package

Description
My requirement is to export a module to a library package. However, this module is not in the normal source directory. It is inside the generated directory.
Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Checked this and I couldn't reproduce this locally. Generated modules specified in the Ballerinatoml are recorded in the package.json in the BALA.
However, I could see that the Module.md file of the generated module is not packaged in the BALA but it only affects if there is an overview to show for the module. API Docs should still be visible in the Central.

This issue can be addressed with https://github.com/ballerina-platform/ballerina-lang/issues/42981


Exception on sound in Firefox / Request permission for media

When you get an invitation, you get the following error message: Uncaught (in promise): NotSupportedError: The media resource indicated by the src attribute or assigned media provider object was not suitable.. This should not be displayed because the browser either does not support this function or the user has rejected the authorization (Thus this error is intentional). Maybe you could add a setting later to activate this function (ask for permission again).
Originally posted by @mxsph in https://github.com/thm-mni-ii/digital-classroom/pull/34#pullrequestreview-759665594

I am not able to reproduce this - even after revoking browser permissions. Would you please describe your environment and other circumstances in #58?
Originally posted by @snicki13  in https://github.com/thm-mni-ii/digital-classroom/pull/34#issuecomment-925269734

I get an error in Firefox when the permission is granted:
Uncaught (in promise): NotSupportedError: The media resource indicated by the src attribute or assigned media provider object was not suitable.

and when I do not allow it
Error: Uncaught (in promise): NotAllowedError: The play method is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.

In Chrome (Chromium) there is a similar error.
I noticed that the request to get the audio file (/assets/classic_phone.mp3) fails (With a 401 Error) which probably leads to the error if the required permission is present. Is it possible that this request works for you because you tested it with the Angular dev server and not with the Docker build?
Why with not given permission you don't get an error I can't say. For me it occurs when I do activate Block media with audio (respectively Set Sound to Automatic in Chrome).
Environment

ManjaroLinux 21.1.3
Firefox 92.0 (64-Bit)
Chromium Version 93.0.4577.82 (Offizieller Build) Arch Linux (64-Bit)
Digital Classroom: Build & Run with Docker-Compose

Reopen if still relevant. Sound handling was changed.


Always run functions given to Go()?

Hi agai!. Sorry to be opening so many issues :-P.
I came across another interesting behaviour difference compared to golang.org/x/sync/errgroup: It's possible for functions given to Go() to never be run.
This can happen, I believe, if a worker goroutine encounters an error (such as a context cancellation) and then returns (in the goroutine in startG()). Then in Wait(), since our only condition to stop is waiting on the waitgroup, we end up setting qCh to nil and returning. This could leave messages in qCh that never get seen.
golang.org/x/sync/errgroup on the other hand will always run a goroutine given to Go().
It would be pretty racey to cause and I haven't reproduced it, but I encountered an issue with a service I have where it assumes a function must be run, even if it's going to error.
I'm not sure what the best thing to do is however. If there's been an error, should we bother trying to run any queued functions? I'm not sure. But perhaps so since it would be a difference compared to what golang.org/x/sync/errgroup does.

@horgh Apologies for the radio silence, it was a summer off open-source work.

I'm not sure what the best thing to do is however.

I'm not quite sure either. Between this and the previous issues you've raised, I wonder if the goal of "identical behavior to sync/errgroup" is achievable. Unfortunately I haven't been able to devote the time to look into those issues in detail (the package has worked well enough for the use cases I had, which are more trivial than yours). But if you've been able to make headway on those topics, I'd love to see a PR (even if partial).
Again, apologies for the delay in responding.


TB Management - Entry

Issue
TB Management will sit alongside other individual encounters:

After the encounter is selected, the CHW will choose a patients, as usual

There is no need to select "First" or "Subsequent" encounters, as a patient without an open TB case will have a "first encounter" and a patient with an active TB case will have a subsequent encounter
Tasks

Create the button and add to the individual encounter screen
choose patient screen
Add logic to determine encounter type

https://nutrition-ihangane.pantheonsite.io/app
QA Review
Checked and approved:

TB Management option is available for CHW workers

After selecting TB Management, a participant can be selected:

After selecting the patient, Tuberculosis encounter type can be selected


Install intero once per ghc version

I've opened a PR for stack adding a proposed --copy-compiler-tool flag.  This flag causes stack to copy executables to a dir for compiler-specific tools, e.g. /home/mgsloan/.stack/compiler-tools/x86_64-linux/ghc-8.0.1/bin.  The intention of this is to allow installation of tools that need to match the ghc version.
In order to use this with intero, it seems like the following will need to happen:

Add checking of stack version - https://github.com/commercialhaskell/intero/issues/127
Pass in this new flag when automatically building intero

Ideally, we'd also check that we are using an intero that matches our GHC - https://github.com/commercialhaskell/intero/issues/161 .  One option here might be to demand that intero be located at stack path --compiler-tools-bin
The way intero is installed could be sensitive to particular choices in the stack.yaml (dependencies, etc).  I think it also makes sense to have configurations like stack-7.8.yaml, stack-7.10.yaml, etc for each compiler version.  Then, these configurations can be used when installing intero.
Thoughts?  Perhaps this isn't worth the effort, maybe the new --copy-compiler-tool flag shouldn't be merged?

Interesting stuff I'll look into it when I get home.
On 28 Nov 2016 02:31, "Michael Sloan"<EMAIL_ADDRESS>wrote:

I've opened a PR for stack adding a proposed --copy-compiler-tool flag.
This flag causes stack to copy executables to a dir for compiler-specific
tools, e.g. /home/mgsloan/.stack/compiler-tools/x86_64-linux/ghc-8.0.1/bin.
The intention of this is to allow installation of tools that need to match
the ghc version.
In order to use this with intero, it seems like the following will need to
happen:

Add checking of stack version - #127
https://github.com/commercialhaskell/intero/issues/127
Pass in this new flag when automatically building intero

Ideally, we'd also check that we are using an intero that matches our GHC

#161 https://github.com/commercialhaskell/intero/issues/161 . One
option here might be to demand that intero be located at stack path
--compiler-tools-bin

The way intero is installed could be sensitive to particular choices in
the stack.yaml (dependencies, etc). I think it also makes sense to have
configurations like stack-7.8.yaml, stack-7.10.yaml, etc for each
compiler version. Then, these configurations can be used when installing
intero.
Thoughts? Perhaps this isn't worth the effort, maybe the new
--copy-compiler-tool flag shouldn't be merged?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/commercialhaskell/intero/issues/324, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAArCwvgXL4yWtGU9TqIpDSUNtZte7Vfks5rCi8IgaJpZM4K9VA1
.

Just worked around a failing project-local intero install by installing globally with --copy-compiler-tool as suggested here:
https://github.com/commercialhaskell/intero/issues/504
If intero installed itself globally in this way, instead of in my project, that would resolve the problem for me automatically.

I need to know the version of stack that introduced that flag, and then
intero can do a version detection to use that flag or not. Otherwise it'll
obviously fail if the stack version is older.
On 9 May 2018 at 02:13, Nathan Collins<EMAIL_ADDRESS>wrote:

Just worked around a failing project-local intero install by installing
globally with --copy-compiler-tool as suggested here:
#504 https://github.com/commercialhaskell/intero/issues/504
If intero installed itself globally in this way, instead of in my project,
that would resolve the problem for me automatically.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/commercialhaskell/intero/issues/324#issuecomment-387589683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAArCz7GDuVDQ2-PbHDct4O3y2hcwhySks5twkK9gaJpZM4K9VA1
.

Looks like --copy-compiler-tool was added in Stack 1.6.1:
https://github.com/commercialhaskell/stack/blob/master/ChangeLog.md#v161 .
On Wed, May 9, 2018 at 2:36 AM, Chris Done<EMAIL_ADDRESS>wrote:

I need to know the version of stack that introduced that flag, and then
intero can do a version detection to use that flag or not. Otherwise it'll
obviously fail if the stack version is older.
On 9 May 2018 at 02:13, Nathan Collins<EMAIL_ADDRESS>wrote:

Just worked around a failing project-local intero install by installing
globally with --copy-compiler-tool as suggested here:
#504 https://github.com/commercialhaskell/intero/issues/504
If intero installed itself globally in this way, instead of in my
project,
that would resolve the problem for me automatically.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/commercialhaskell/intero/issues/324#issuecomment-
387589683>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAArCz7GDuVDQ2-
PbHDct4O3y2hcwhySks5twkK9gaJpZM4K9VA1>

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/commercialhaskell/intero/issues/324#issuecomment-387682352,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABAJen7uR6HBIzTRMfWooYly9KR7seZks5twriwgaJpZM4K9VA1
.

Note that if stack build --copy-compiler-tool is used within a project, then that particular project's settings and dependencies will affect the resulting intero binary.  This is why in the original issue I'm describing having different stack.yaml files for building intero, based on ghc major version.

@mgsloan OK, so it would have to detect the GHC version with
-bash-3.2$ stack ghc -- --version
The Glorious Glasgow Haskell Compilation System, version 8.0.2

then based on that, the Elisp would run in a temporary directory
stack build --copy-compiler-tool --resolver ghc-8.0.2 intero-0.1.31 <other deps for this ghc>

And after that, intero would be in the PATH when I do stack exec intero specific to the GHC currently in use?

To clarify, the way I installed Intero globally after it failed to install in a project was closer to what @mgsloan is suggesting. I did
cd /tmp
stack install intero-0.1.30 --copy-compiler-tool --resolver lts-11.8

where the point is that I don't have any stack.yaml files in /tmp. If I try to install with a generic ghc-<version> resolver, e.g. with
stack install intero-0.1.30 --copy-compiler-tool --resolver ghc-8.2.2

then the install fails because the dependency versions are not specified, but I guess that's what @chrisdone 's "<other deps for this ghc>" is for.

Right, in order to not specify the dependencies we can rely on the lts or nightly resolver. But then if someone is not using one of those resolvers it'll fail.
We could have a mapping in the elisp like:
(defvar intero-deps (list "8.0.2" "lts-x.y"))

So we can lookup the GHC for the current project and then build intero with the right resolver.
What do you think?

Why would it fail if someone is not using one of those resolvers?
But yes, using a mapping from GHC versions to resolvers seems like a nice, simple solution.

Why would it fail if someone is not using one of those resolvers?

For example:
-bash-3.2$ stack install intero --resolver ghc-8.0.2

Error: While constructing the build plan, the following exceptions were encountered:

In the dependencies for intero-0.1.31:
    ghc-paths must match -any, but the stack configuration has no specified version (latest
              matching version is <IP_ADDRESS>)
    mtl must match -any, but the stack configuration has no specified version (latest
        matching version is 2.2.2)
    network must match -any, but the stack configuration has no specified version (latest
            matching version is <IP_ADDRESS>)
    random must match -any, but the stack configuration has no specified version (latest
           matching version is 1.1)
    syb must match -any, but the stack configuration has no specified version (latest
        matching version is 0.7)
needed since intero is a build target.

Some potential ways to resolve this:

  * Recommended action: try adding the following to your extra-deps
    in /Users/chris/.stack/global/stack.yaml:

- ghc-paths-<IP_ADDRESS>
- mtl-2.2.2
- network-<IP_ADDRESS>
- random-1.1
- syb-0.7

Confirming proper behavior of the invocation that Emacs Lisp would run, on my system:
bash-3.2$ stack build --resolver ghc-8.0.2 --copy-compiler-tool intero-0.1.31 ghc-paths-<IP_ADDRESS> mtl-2.2.2 network-<IP_ADDRESS> random-1.1 syb-0.7
...
Completed 6 action(s).
Copying from /Users/chris/.stack/global/.stack-work/install/x86_64-osx/ghc-8.0.2/8.0.2/bin/intero to /Users/chris/.stack/compiler-tools/x86_64-osx/ghc-8.0.2/bin/intero

Copied executables to /Users/chris/.stack/compiler-tools/x86_64-osx/ghc-8.0.2/bin:
- intero
bash-3.2$ rm /Users/chris/.stack/global/.stack-work/install/x86_64-osx/lts-9.18/8.0.2/bin/intero
bash-3.2$ rm /Users/chris/.stack/global/.stack-work/install/x86_64-osx/ghc-8.0.2/8.0.2/bin/intero
bash-3.2$ stack exec which intero
/Users/chris/.stack/compiler-tools/x86_64-osx/ghc-8.0.2/bin/intero

Note that the way the Intero Emacs mode currently invokes intero doesn't necessarily use the compiler-tools version.  E.g. I have a project that uses lts-11.1 and a version of Intero Emacs mode that uses intero 0.1.30. If I do
$ stack --resolver lts-11.1 --copy-compiler-tool build intero-0.1.31
$ stack --resolver lts-11.2 --copy-compiler-tool build intero-0.1.30

to install the wrong version of  intero for lts-11.1 and the right version for lts-11.2, and then load project, Emacs complains
The wrong version of Intero is installed for this Emacs package.
Installing intero-0.1.30 automatically ...

Note that both of these LTSs use GHC 8.2.2:
$ stack --resolver lts-11.2 exec -- intero --version
Intero 0.1.30
$ stack --resolver lts-11.1 exec -- intero --version
Intero 0.1.31
$ stack --resolver lts-11.1 exec -- ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.2.2
$ stack --resolver lts-11.2 exec -- ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.2.2

However, there is only one "compiler tools" version of intero at this point, and it's the correct version 0.1.30, since I installed that one last:
$ `stack --resolver lts-11.1 path --compiler-tools-bin`/intero --version
Intero 0.1.30
$ `stack --resolver lts-11.2 path --compiler-tools-bin`/intero --version
Intero 0.1.30
$ `stack --resolver ghc-8.2.2 path --compiler-tools-bin`/intero --version
Intero 0.1.30

Note that when using the generic ghc-8.2.2 resolver we always get the most recently installed intero:
$ stack --resolver ghc-8.2.2 exec -- intero --version
Intero 0.1.30

Yes, the short version is that the PATH prefers LTS-local binaries over compiler tool ones:
bash-3.2$ stack exec -- env | grep ^PATH
PATH=/Users/chris/.stack/global/.stack-work/install/x86_64-osx/lts-9.18/8.0.2/bin
:/Users/chris/.stack/snapshots/x86_64-osx/lts-9.18/8.0.2/bin
:/Users/chris/.stack/compiler-tools/x86_64-osx/ghc-8.0.2/bin
:/Users/chris/.stack/programs/x86_64-osx/ghc-8.0.2/bin
:/Users/chris/.cargo/bin/
etc...

I think intero's checking and running should check for the path from stack path --compiler-tools-bin:
bash-3.2$ stack path --compiler-tools-bin
/Users/chris/.stack/compiler-tools/x86_64-osx/ghc-8.0.2/bin

So that it always prefers the compiler-tools-bin version of intero.

Implemented and pushed! Please all give it a try.
It should install intero once per GHC version. If it installs on a project that you already built intero for, that will be because it demands that it's in compiler-tools-bin.

Woohoo!

Works for me, thanks! Tested on three projects, two using GHC 8.2.2 and one using GHC 8.0.2.

@ntc2 Thanks for testing!


Pasting text longer than the visible window causes the text and rendering to become offset

The longer you paste, the worst it is. I've seen something similar in a project using EditorConfig where they were missing some calls to refresh the state.

Should be fixed in v2.0.1

Yup, can confirm! Thanks - I'll give daily driving it a go.


Apply relocations when loading executable

Currently, the relocation tables are ignored. The relocation table entries should be applied to the loaded executable as part of the loading process.

Done in v0.1.7!


[1.15.2] This doesn't work on a dedicated server - nothing shows.

Describe the bug
When on single player, I see the box just fine, I log in to the server and nothing.
I tried putting it on the server but then it crashes due to sidedness.
1.15.2 V1.1
Modpack- https://www.curseforge.com/minecraft/modpacks/towncraft  Beta branch for 1.15.2

Is there an chance you could attach the game log/crash report as this would help me to locate the bug. Thanks.

I can when I get home, otherwise you can simply run a dedicated server binary on your local machine with only your mod, then connect to it with a client with only your mod, and get a nice clean log.

Its alright now, I managed to find the bug yesterday and have found another bug while fixing it that would also cause crashing on a dedicated server.

Fixed on 1.15.2 and will upload update to CurseForge soon.


feat: #888 transfer to admin table

refs: #888

add flyway script to migrate user with fam role to fam application admin table
update auth function to add fam application admin to role list when user login through fam itself
update the auth function test to verify the admin role can be added as expected

Hope I am wrong, or maybe I am just confused myself, but would still like to ask this question:
Although if this PR is good, should this PR be pending for merge until either "frontend" or somehow "backend api" starts directing "role assignment" for "xyz_ACCESS_ADMIN" role to the new "fam_application_admin" table first?
If this PR flyway script is promoted to production, but our frontend/api isn't ready to make a switch yet, then will later the records for "xyz_ACCESS_ADMIN" in fam_user_role_xref be out of sync than current state (if, for example, Basil is being added to "SPAR_PROD_ACCESS_ADMIN" in current fam_user_role_xref table then he will not exists in fam_application_admin table.
@MCatherine1994 @basilv

Agree somewhat with Ian that we can't release this functionality until the rest of it is done. We could merge this and deploy to dev, understanding that we will no longer be able to add admins in dev until the rest of the associated changes are done. (we can add admins, but will be in the wrong table and this won't be used to determine authentication).

Verified in AWS tools space
we have these persons have FAM roles:

migrate them into the new fam_application_admin table:


[Flow] Arrow function type parameter declarations

In Flow, you can declare type parameters for arrow functions. The syntax looks like this:
  const arrowFunctionWithoutTypeParams = (x) => x;
  const arrowFunctionWithTypeParams = <T>(x: T): T => x;

This is a little tricky to parse, especially with JSX. This PR attempts to solve the problem as follows

Try to parse the expression as if it were JSX. JSX is probably more common and this will lead to less backtracking. If this fails, save the error. If the JSX plugin isn't in use, then skip this step.
If the next token is <, then parse a type parameter declaration. Then parse an assignment expression. If that expression turns out to an ArrowFunctionExpression, then attach those type params to that expression. Otherwise, fail. On failure throw the JSX error, if it exists, or a new error.
If this is not JSX And doesn't start with < then just parse an assignment expression as usual.

This was further complicated by the need to reinterpret tokens and mess with context. But at least it seems to work :)

This fixes https://phabricator.babeljs.io/T7330

Thanks @gabelevi! I'll publish a new release now.

We aren't running the changes on babel in travis yet right?

@hzoo Nope.

I pushed a new release just now, I'll run make test-babel to ensure that I haven't broken anything...

Ok cool - it does suck that it would make the tests run a lot longer but worth doing.


Add manual test steps for Prometheus Support.

https://github.com/longhorn/longhorn/issues/1180
Doc link will be updated once the doc PR is merged. https://github.com/longhorn/website/pull/195
Signed-off-by: khushboo-rancher<EMAIL_ADDRESS>

LGTM


payment failure issue

Step:
place an sample order, then (Don't do payment) choose return to website from paypal's website, it shows "mw_payment_failure=1", but the label is "successful".

Thanks for reporting this. However, this is a template issue, not a core issue. My guess is you're using the Liteness template. Its source can be found in userfiles/templates. We'll soon separate core code from default modules/templates but for now you can submit a pull request in this repository if you fix it first. We currently have other project priorities so this can take a while to get some attention. It's a matter of simple check to make it work the way it should.


[EV-2594] Upgrade go to v1.18.8 (go-build 0.76). UBI to v8.7

Description

Upgrade go to v1.18.8, go-build v0.76
Upgrade UBI image to v8.7

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

/sem-approve

@caseydavenport it's good to merge. We'll get the latest UBI image (8.7) out of it, but regarding go-build, we'll have to shortly upgrade that to 0.77 - 1.18.9 when that's available


[azappconfig] NewListSettingsPager: Paging to second page fails ("no Host in request URL")

Bug Report
System Info

import path of package in question: "github.com/Azure/azure-sdk-for-go/sdk/data/azappconfig" @ v0.4.2
<EMAIL_ADDRESS>output of go version: go1.18.6 windows/amd64

Report

What happened?
I have an Azure App Configuration instance with 115 values in it. I am trying to get a complete list of these entries by using the NewListSettingsPager and paging through the results.
The first request gets me the first 100 entries without any issues.
When trying to load the second result page of the NewListSettingsPager, an error is thrown: "no Host in request URL"

What did you expect or want to happen?
The next (and last) 15 results are provided in the next page.

How can we reproduce it?

Create an instance of Azure App Configuration and insert 115 configuration items.
Create a Go application, install the azappconfig SDK and try to load the results by using the following method:

func getAllConfigItems(ctx *gin.Context) ([]azappconfig.Setting, error) {
	appConfigTicketStatusConnectionString := "Endpoint=https://<endpoint>.azconfig.io;Id=<id>;Secret=<secret>"
	client, err := azappconfig.NewClientFromConnectionString(appConfigTicketStatusConnectionString, nil)

	if err != nil {
		return nil, errors.New("could not load ticket status app config")
	}

	selector := azappconfig.SettingSelector{}
	options := azappconfig.ListSettingsOptions{}
	pager := client.NewListSettingsPager(selector, &options)

	settings := []azappconfig.Setting{}

	hasMore := true
	for ok := true; ok; ok = hasMore {

		page, err := pager.NextPage(ctx)
		if err != nil {
			return nil, err
		}

		settings = append(settings, page.Settings...)

		hasMore = pager.More()
	}

	return settings, nil
}

I have tracked down the issue to the following method, in which the current page is set after successfully receiving the first 100 results. The response seems to have a NextLink, which indeed does not have a Host name set:

Later, when trying to fetch the second result page, and therefore a new requst is initiated, the request fails here, because of the missing Host:

Am I missing something, or is there even an easier way to get a complete list of (non-paginated) items?
Thanks in advance.

Thanks for the detailed bug report, this is helpful.

According to the docs the nextLink value is a relative URI, so we need to join it with the client's host.
Fix will be in v0.4.3 which will be released first week of November.


support multi-golden tests in a single test

if I run two expectGolden tests I will get this error
Reentrant call to runAsync() denied
can you support multi-golden tests in a single test?

Could you create some example project where I can check it?

@mjablecnik you already have multi-golden testing in the example folder just run flutter test --update-goldens
the example folder is here
https://github.com/StorybookToolkit/adaptive_golden_test/tree/main/example/simple_app

Ok, I see the problem what is there. I fixed and pushed it into repository.
Could you check if simple_app tests work right for you now?

thanks a lot, it works fine now
thanks for your effort


Fix rainloop nginx permissions

I think that the rainloop image needs the same patch than nexcloud for nginx permissions in non root mode (/etc/nginx.conf):
proxy_temp_path /tmp/proxy 1 2;
uwsgi_temp_path /tmp/uwsgi 1 2;
scgi_temp_path /tmp/scgi 1 2;

Thanks for these great images !

https://github.com/Wonderfall/dockerfiles/commit/9c8f89a41e99289ca181c2e236f4532ee6b49195

Thank you for the quick fix !


Example removed + use of the 0.16

The code is modified to use the 0.16 version of pwasm-utils:

The code is changed to use the 0.16 version.
A newly added example is removed, because it is not relevant to an older version.

We may not go back to the 0.16 version. Will be discussed.


"Alias folder SecureMode does not exist at path /SecurityConfiguration" error when discovering domain in WLS 12.1.3 version

Trying to discover WLS 12.1.3 domain of which SOA Studio 12.1.3 integrated WebLogic Server is part of with the command:
./bin/discoverDomain.sh -oracle_home /opt/Applications/Oracle/soa_studio_1213 -skip_archive -model_file ./model.yaml -domain_home /opt/Applications/Oracle/soa_studio_1213/user_projects/domains/base_domain

raises the following error:
./bin/discoverDomain.sh -oracle_home /opt/Applications/Oracle/soa_studio_1213 -skip_archive -model_file ./model.yaml -domain_home /opt/Applications/Oracle/soa_studio_1213/user_projects/domains/base_domain

JDK version is 1.8.0_301-b09
JAVA_HOME = /opt/jdk1.8.0_301.jdk/Contents/Home
WLST_EXT_CLASSPATH = /opt/Applications/Oracle/weblogic-deploy/lib/weblogic-deploy-core.jar
CLASSPATH = /opt/Applications/Oracle/weblogic-deploy/lib/weblogic-deploy-core.jar
WLST_PROPERTIES = -Dcom.oracle.cie.script.throwException=true -Djava.util.logging.config.class=oracle.weblogic.deploy.logging.WLSDeployLoggingConfig
/opt/Applications/Oracle/soa_studio_1213/oracle_common/common/bin/wlst.sh /opt/Applications/Oracle/weblogic-deploy/lib/python/discover.py -oracle_home /opt/Applications/Oracle/soa_studio_1213 -skip_archive -model_file ./model.yaml -domain_home /opt/Applications/Oracle/soa_studio_1213/user_projects/domains/base_domain

Initializing WebLogic Scripting Tool (WLST) ...

Welcome to WebLogic Server Administration Scripting Shell

Type help() for help on available commands

####<Jun 14, 2023 8:27:29 PM> <INFO> <WebLogicDeployToolingVersion> <logVersionInfo> <WLSDPLY-01750> <The WebLogic Deploy Tooling discoverDomain version is 3.2.0:.3f64264:May 11, 2023 00:30 UTC>
####<Jun 14, 2023 8:27:29 PM> <INFO> <WLSDeployLoggingConfig> <logLoggingDirectory> <WLSDPLY-01755> <The discoverDomain program will write its log to directory /opt/Applications/Oracle/weblogic-deploy/logs>
####<Jun 14, 2023 8:27:30 PM> <INFO> <ModelContext> <__copy_from_args> <WLSDPLY-01050> <WebLogic version for aliases is <IP_ADDRESS>.0>
####<Jun 14, 2023 8:27:30 PM> <INFO> <discover> <main> <WLSDPLY-06024> <No variable file provided. Model passwords will contain the token '-- FIX ME --'>
####<Jun 14, 2023 8:27:45 PM> <INFO> <discover> <_get_domain_name> <WLSDPLY-06022> <Discover domain base_domain>
####<Jun 14, 2023 8:27:46 PM> <SEVERE> <discover> <main> <WLSDPLY-06011> <discoverDomain failed to discover domain base_domain at /opt/Applications/Oracle/soa_studio_1213/user_projects/domains/base_domain : Failed to get the WLST list path for location (model_folders = ['SecurityConfiguration', 'SecureMode'],  'name_tokens' = {'SECURITYCONFIGURATION': 'base_domain','DOMAIN': 'base_domain'}): Alias folder SecureMode does not exist at path /SecurityConfiguration>

Issue Log for discoverDomain version 3.2.0 running WebLogic version <IP_ADDRESS>.0 offline mode:

SEVERE Messages:

        1. WLSDPLY-06011: discoverDomain failed to discover domain base_domain at /opt/Applications/Oracle/soa_studio_1213/user_projects/domains/base_domain : Failed to get the WLST list path for location (model_folders = ['SecurityConfiguration', 'SecureMode'],  'name_tokens' = {'SECURITYCONFIGURATION': 'base_domain','DOMAIN': 'base_domain'}): Alias folder SecureMode does not exist at path /SecurityConfiguration

Total:   SEVERE :    1  WARNING :    0

discoverDomain.sh failed (exit code = 2)

The command is run against WLDT vanilla installation where the ${WLDT_HOME}/lib/typedefs/WLS.json is changed to:
{
    "copyright": "Copyright (c) 2017, 2019, Oracle Corporation and/or its affiliates.  All rights reserved.",
    "license": "Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl",
    "name": "WLS",
    "description": "WLS type domain definitions",
    "versions": {
        "10.3.6": "WLS_11G",
        "12.1.1": "WLS_11G",
        "12.1.2": "WLS_12CR1",
        "12.1.3": "WLS_12CR1",
        "12.2.1": "WLS_12CR2",
        "<IP_ADDRESS>": "WLS_12CR2",
        "<IP_ADDRESS>": "WLS_12CR2",
        "14.1":     "WLS_14"
    },
    "definitions": {
        "WLS_11G": {
            "baseTemplate": "@@WL_HOME@@/common/templates/domains/wls.jar",
            "extensionTemplates": [ ],
            "customExtensionTemplates": [ ],
            "serverGroupsToTarget": [ ],
            "rcuSchemas": [ ]
        },
        "WLS_12CR1": {
            "baseTemplate": "Basic WebLogic Server Domain",
            "extensionTemplates": [ ],
            "customExtensionTemplates": [ ],
            "serverGroupsToTarget": [ ],
            "rcuSchemas": [ ]
        },
        "WLS_12CR2": {
            "baseTemplate": "Basic WebLogic Server Domain",
            "extensionTemplates": [ ],
            "customExtensionTemplates": [ ],
            "serverGroupsToTarget": [ ],
            "rcuSchemas": [ ]
        },
        "WLS_14": {
            "baseTemplate": "Basic WebLogic Server Domain",
            "extensionTemplates": [ ],
            "customExtensionTemplates": [ ],
            "serverGroupsToTarget": [ ],
            "rcuSchemas": [ ]
        }
    }
}

I suppose the SecureModeMBean appears in newer version, but I cannot find a way to enforce older version of the config mbeans hierarchy.

@anatoliatanasov Can you please provide the complete log file?

@anatoliatanasov Can you please provide the complete log file?

Please, find the log file attached.
discoverDomain.log

I believe that this is all related to #1466. The SecureMode folder is already filtered out in versions prior to 12.2.1 so clearly, the version is not being set properly during tool initialization. This is just a side effect of the previous problem.

From the analysis and debugging I did yesterday it seems that the version verification for the SecureMode model folder / mbean the version check says that it should not be processed, but the actual processing occurs, i.e. the VersionUtils functions work OK, but the result is not properly treated.
The problematic part is in the discover.py's _establish_secure_mode function.

If interested I managed to work around with this piece of code in discover.py's _establish_secure_mode  function.
I replaced the code in lines 322 - 324, that is:
secure_mode_location.append_location(model_constants.SECURE_MODE)
secure_mode_path = aliases.get_wlst_list_path(secure_mode_location)
secure_mode_token = helper.get_singleton_name(secure_mode_path)

with
# Patched by<EMAIL_ADDRESS># For domains of WLS version 12.1.3 and earlier there is no SecureModeMBean/SecureModeEnabled causing
# runtime errors using the discoverDomain.
# The SecureModeMBean/SecureModeEnabled attribute is examined and if missing, error is suppressed.
try:
    # Tries to get value of SecureModeMBean.isSecureModeEnabled() method
    helper.get(model_constants.SECURE_MODE_ENABLED)
    secure_mode_location.append_location(model_constants.SECURE_MODE)
    secure_mode_path = aliases.get_wlst_list_path(secure_mode_location)
    secure_mode_token = helper.get_singleton_name(secure_mode_path)
except DiscoverException, ex:
    e = ex
    while True:
        if(not e.getCause() and isinstance(e, java.lang.NoSuchMethodException)):
            __logger.warning('#################### PATCHed logic by<EMAIL_ADDRESS>START ####################', class_name='discover-py', method_name=_method_name)
            __logger.warning(str(e.getMessage()), class_name='discover-py', method_name=_method_name)
            __logger.warning('#################### PATCHed logic by<EMAIL_ADDRESS>END ####################', class_name='discover-py', method_name=_method_name)
            secure_mode_token = None
            break

        e = e.getCause()

With this modification the discoverDomain.sh tool completes with a few warnings, but I don't think this is a sustainable solution.

Yeah, that's not the right way to fix this but thanks for your effort.  We will get both issues fixed as soon as possible and will cut a 3.2.1 release that resolves both issues.

Fixed in release 3.2.1


updated sliderule entry in access table; made some minor updates to overview

Quick updates to tutorial with regards to sliderule

@scottyhq two checks on a PR to this branch have failed.

@andypbarrett you're still able to merge this right? The checks are only relevant to merging into the main branch. I'll open an issue to disable them for other branches to avoid future confusion


selected-model issue

I can't dynamically update selected-model with values (setting a new array of objects or pushing to the array). Even preseting the id's is not working. P.s my id's are string based.

Maybe the problem is the use of $$hashkey?

What version are you using?

Release 2.0.0-beta.4

I tried setting let values = [{ id: 'paid' }];, also tried let string = 'paid'; values = string.split(',').map((v) => { return { id: v } });

Watchers fired in the last 5 iterations: [[{"msg":"fn: regularInterceptedExpression","newVal":"...","oldVal":""}],[{"msg":"fn: regularInterceptedExpression","newVal":"","oldVal":"..."}],[{"msg":"fn: regularInterceptedExpression","newVal":"...","oldVal":""}],[{"msg":"fn: regularInterceptedExpression","newVal":"","oldVal":"..."}],[{"msg":"fn: regularInterceptedExpression","newVal":"...","oldVal":""}]]
http://errors.angularjs.org/1.4.14/$rootScope/infdig?p0=10&p1=%5B%5B%7B%22m…dExpression%22%2C%22newVal%22%3A%22...%22%2C%22oldVal%22%3A%22%22%7D%5D%5D```

in v2 object equality is checked by reference -> you should push objects that exist in your options array to your selection array, see #323

Works, thanks.


Kafka heartbeat & rebalancing issue

How can I fix the below errors? However, I tried to put these values in the consumer config but it didn't work for me.
consumer: {           groupId: 'bucket-file-consumer',           sessionTimeout: 30000,           heartbeatInterval: 3000,         },

I thinks i'm facing the same issue due to the default RoundRobin strategy

I am facing the same issue, Anyone have a solution?

Same here

We had the same issue.
The code to reproduce: https://github.com/maksym-opanasenko/kafkajs-constant-rebalancing/blob/main/ingex.js
The workaround: https://github.com/maksym-opanasenko/kafkajs-constant-rebalancing/blob/main/indexPatched.js


New connections: Regen POAPs

https://poap.gallery/event/6736
https://poap.gallery/event/27649
https://poap.gallery/event/30186
https://poap.gallery/event/100689
https://poap.gallery/event/45205
https://poap.gallery/event/45207
https://poap.gallery/event/65866
https://poap.gallery/event/66627
https://poap.gallery/event/127435
https://poap.gallery/event/144936
https://poap.gallery/event/148447
https://poap.gallery/event/74498
https://poap.gallery/event/136490
https://poap.gallery/event/74201
https://poap.gallery/event/109068

https://poap.gallery/event/102147
https://poap.gallery/event/28643
https://poap.gallery/event/39093
https://poap.gallery/event/28576
https://poap.gallery/event/39095
https://poap.gallery/event/39096
https://poap.gallery/event/39097
https://poap.gallery/event/66020
https://poap.gallery/event/28689
https://poap.gallery/event/102289
https://poap.gallery/event/102175


Stopwatch overlay

Idea is simply a stopwatch or countdown timer or simple variations of that that is an overlay (like how kingdom/potions/boosts are currently)
Would be a plugin you can turn off/on on in settings with a thing where you can set what you put the timer too. (eg: 1hr/15mins etc etc)
Can have it briefly flash in w/e color (i assume we can add this in as every other color thing you can change color) for set intervals.
When timer is done/finished it would flash a different color and potential notifications.

Reason for adding this imo is to time how many of w/e u want per hour or per w/e time. or lots of things really. Only thing it really wouldnt help with is xp/hr (since thats kind of naturally included in the tracker)

Not an overlay, but a stopwatch/timer was added with the Time Tracking plugin. Does that fix this issue?

Yes this is great for what I want it for. Would only be better if there was a notification sound for timer. Even like the idle notification sound.

There is a sound if you have notifications set to play a notification sound...

Hmmm wonder why mine is not sounding off. Maybe only sounds when a game related timer ends?

https://github.com/runelite/runelite/wiki/RuneLite#enable-sound-on-notifications

Weird thought I had notifications all set up. Guess not. Thanks!


Weave Net can create looping flow rules when hairpin is turned on on the bridge veth

Analysis from @awh:
Consider the following simple configuration with two containers A and B connected to the weave bridge:
  A                     B
  +                     +
  |                     |
  |                     |
+-+---------------------+-+
| 2                     3 |
|                weave    |
| 1                       |
+-+-----------------------+
  |
  |
  |
  |
+-+-----------------------+
| vport1                  |
|               datapath  |
| vxlan vport             |
+-------------------------+

Furthermore, imagine that there are no flow rules, and that neither the weave bridge nor the fastdp bridge implementation have learnt any MAC addresses yet. Then:

A sends a packet to B
The weave bridge learns A=2, and floods the packet out of 1 & 3
B receives the packet but does not respond
The router miss handler receives the packet on vport1, learns that A=vport1, and floods the packet out of the vxlan vport
The weave bridge A=2 entry expires
B sends a packet to A
The weave bridge learns that B=3, and floods the packet out of 1 & 2
The router miss handler receives the packet on vport1, learns that B=vport1, installs a flow 'B->A in vport1 send to vport1', and sends the packet out of vport1
The weave bridge receives the B->A packet on 1, and learns that B=1. Depending on whether A responded after 7, it may have learnt A=1 or not; it either floods 1 & 3 or sends to 1 (it doesn't actually matter)
A responds to B
The weave bridge learnt in 9 that B=1, so it sends to 1
The router miss handler receives the packet on vport1, installs a flow 'A->B in vport1 send to vport1', and sends the packet out of vport1
The weave bridge receives the A->B packet on 1, and learns that A=1. Forwards packet out of 1
The weave bridge now thinks A and B are associated with port 1, and the router thinks (both in terms of MAC table and installed flow rules) that A and B are associated with vport1. Packets circulate continuously.

Step 13 requires hairpin to be turned on; one possible cause of this is https://github.com/kubernetes/kubernetes/issues/19766

Fixed by https://github.com/weaveworks/weave/pull/2674


Debug: pressing F5 may skip the following breakpoint(s) while using the debug controls does not.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:
1.57.0-insider (Universal)
Commit: 541a5d4fa70ab3095f23b28b88914e1f6a8f65c4
Date: 2021-05-28T10:00:38.762Z
Electron: 12.0.9
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 20.3.0
OS Version: macOS Big Sur 11.2.3 (20D91)

Steps to Reproduce:

Have a project with consecutive breakpoints
Using the debug controls clicking the "pause play" button will go to the next breakpoint but if pressing F5 it may jump over it.

Possible thing that is happening is that pressing F5 may send many signals to the debugger but clicking it just sends one.
I was able once to press F5 quick enough to not jump over it.

What debugger are you using?

Nodejs debugger and using the touchbar, sorry for not mentioning those.

I can not reproduce this. Both F5 and the debug toolbar go to the same command.
@connor4312 also assigning to you since this might be on the js-debug side.
/jsDebugLogs

@isidorn I'm not questioning that they both go to the same command because both go to the next breakpoint (but in the case of pressing F5 with the touch bar you have to press it very quick, if not it skips it)
I've tested it many times to make sure I'm not saying crazy things.
Is it posible that pressing F5 sends many signals and clicking on the debug control just sends one?

@nicoabie that is the reason why I asked you to provide logs. So can you please provide logs when you reproduce the issue and we will see if multiple requests are being sent out (they should not)

Could you provide me the file path where the log location is, because it doesn't appear in the debug tab :(

vscode-debugadapter-ea8697ab.json.gz

I'm not seeing anything weird, there is one stopped event, and then one resume call. I'm not sure how the UI would affect that. It looks like you had a breakpoint in mergeIncludes.test.ts, however, which was never loaded by the program. Since you are attaching to jest rather than launching it directly, make sure to set --runInBand when you start.

Thing that I'm experiencing now with the debugger is that it stops on even runs (or odd) but it works, it doesn't, it works, it doesn't. I swear to god I'm no crazy

that is something that I could expect in attach mode without --runInBand


Error while running less - Potentially unhandled rejection [2] Could not parse call arguments or missing ')' on line 120

I installed the rfs with bower install rfs --save
and run the gulp less to build the project but face the below issue.
Potentially unhandled rejection [2] Could not parse call arguments or missing ')' in file C:\Products\test\dev\bower_components\rfs\less.less line no. 120
My first thought that i might be some issue in my project but than i tested it on https://lesstester.com/ it throws the same error if I comment line no 120 than it goes to no 187 and than 192.
Can you help me with this.

You're using an outdated version of less. If you upgrade to less 3.6 or later (I would recommend the latest version, 3.8), this issue should be fixed. You can also test this with lesstester.com.

Thanks @MartijnCuppens , Yes its not working on lower version. is there any other way for lower version?

We could rewrite the less file, but updating your dependencies would definitely be the best option. npm install<EMAIL_ADDRESS>should do the trick.

Thanks for your help @MartijnCuppens , But I was looking for the global solution as my other components are compatible with my angular 1.2.

less 3.6 is almost 3 years old now, I don't have any plans to support packages that are older than that.


Add Jodo.Numerics

Mathematics/Jodo.Numerics - https://github.com/JosephJShort/Jodo/#numerics
Provides extra number types (such as fixed-point and non-overflowing) with full support for operators, math, conversion, parsing etc. Extensively tested, and cross-platform compatible.
Notes
Hello there, I'm a .NET developer making a few open-source packages. I would love to include Jodo.Numerics on this awesome list so that it can be helpful to others, and so that I can gain feedback for future versions.
I'd be very happy to incorporate any feedback you have on the wording in my description.
Here are some notes regarding the quality standard in the contributions guide:

Actively maintained (even if that just means acknowledging open issues when they arise)

The project has a roadmap and an issues backlog.

Stable

The project has one stable version (1.0.0) released on NuGet.

Documented

The project has a detailed README.md, and partial API documentation.

Tests

The project has an extensive suite of tests (see a recent run) and uses Azure DevOps for continuous integration. SonarCloud and CodeFactor are also used.

Generally useful to the community

Remains to be seen. I'll let the reviewers decide.

Thanks,
Joe

Have been using this package over the past couple of weeks and have been finding it useful. Had a gander at the pipeline after reading "The project has an extensive suite of tests" - 32,210 tests passed and ran! Thanks @JosephJShort

@pleb no problem if this needs to be closed. I wouldn't expect much more community input while the packages are so new. Either way thanks for considering it. 👍


ECDS not displaying UNVERIFIED IDENTITY STRUCTURE group correctly

@jamesrwelch - please see https://www.datadictionary.nhs.uk/data_sets/clinical_data_sets/ecds_v4/emergency_care_data_set_version_4.html
There is a strange section under "UNVERIFIED IDENTITY STRUCTURE"
Can this be fixed for the next release please?

This is the same in CDS, see https://www.datadictionary.nhs.uk/data_sets/cds_v6-3/cds_v6-3_type_020_-_outpatient_cds.html

I have done a search for null and it looks like most of the CDS are affected:

07/08/24 - James will fix for the August 2024 releaes

CDS fixed, there are no longer nulls in the affected data sets.
Issue closed.


Bp 1510 fixing php code mess detected errors

This contains also some additional changes to etc/adminhtml/system/payment_methods/klarnas.xml + js files... The fixes would refer to which requirements/bugs, etc? @armandomeeuwenoord

Solved.


Nuget package Robots

Hi Victor, you can now use this nuget package https://www.nuget.org/packages/Robots.Rhino to make it easier to develop for the Robots plugin. Just add this to your .csproj:
<PackageReference Include="Robots.Rhino" Version="1.1.7" />

and remove any references to local Robots.dll and Robots.gha files.

Thanks! will update accordingly.


All accounts need to login again after reboot the machine or the docker.

Hi, My deployment is on unraid by docker UI. But I have to relogin both GitHub and Microsoft accounts every time after a reboot of the machine or the docker. May I ask if you could just tell me which path I should map out so the account info won't reset every time?

The issue here is that vscode-server is keeping the user session in the browser, so when you reset your browser / reboot your OS those get reset as well ... there is no way to persist it on disk yet.
you can open a ticket (or look for existing tickets on this) on their official github

@ahmadnassri Thanks so much for the reply. And also thanks for making this great app. I've tried like 6 different vscode on docker, and yours is no doubt the best.


Typo in Czech translation of the desktop context menu item

Windows Terminal version
1.20.11781.0
Windows build number
10.0.19045.0
Other Software
No response
Steps to reproduce

Use latest, fully updated Windows 10 system with Czech locale and latest version of Terminal installed.
Open the Start Menu and search for "Terminal" to confirm that the launcher is correctly translated as "Terminál".
Switch to the desktop and right click to open the context menu.

Expected Behavior
"Open in Terminal" in the desktop context menu is translated as "Otevřít v aplikaci Terminál".
Actual Behavior
"Open in Terminal" in the desktop context menu is translated as "Otevřít v aplikaci Terminal" instead of the correct "Otevřít v aplikaci Terminál" one.
Context menu item in File manager (Explorer) has the same typo.
I did not test this on Windows 11, but I suspect that there will be the same typo there too.

String ID
Current
Suggestion
Reason

Profile_TabTitle.HelpText
Otevřít v aplikaci &Terminal
Otevřít v aplikaci &Terminál
a VS á

ShellExtension_OpenInTerminalMenuItem_Preview
Otevřít náhled &aplikace Terminal
Otevřít náhled &aplikace Terminál
a VS á

AppDescription
Nová Terminál Windows
Nový Terminál Windows
"Terminál" has a masculine gender

https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/Resources/cs-CZ/ContextMenu.resw#L167
https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/Resources/cs-CZ/ContextMenu.resw#L171
https://github.com/microsoft/terminal/blob/main/src/cascadia/CascadiaPackage/Resources/cs-CZ/Resources.resw#L167
https://github.com/microsoft/terminal/blob/main/src/cascadia/CascadiaPackage/Resources/cs-CZ/Resources.resw#L171

@zadjii-msft Any news? Did the localization team look at this? Thanks!

Reported internally as GCS-716551.

@lhecker
Thanks! Here's another possibly incorrectly translated string:
https://github.com/microsoft/terminal/pull/17798#issuecomment-2308941406

Can you explain what's wrong with the AppDescription translation?

Sure. It just does not sound correct. :-)
The original string is "The New Windows Terminal". It at least should be translated as "Nový Terminál Windows" (correct grammatical gender because the word "Terminál" has a masculine gender in Czech).

  <data name="ShellExtension_OpenInTerminalMenuItem" xml:space="preserve">
    <value>Otevřít v aplikaci &Terminal</value>
    <comment>This is a menu item that will be displayed in the Windows File Explorer that launches the non-preview version of Windows Terminal. Please mark one of the characters to be an accelerator key.</comment>
  </data>

It is still unfixed! Terminal instead of Terminál.
Only the second problem got fixed.
@DHowett @lhecker Please reopen this ticket.

Any update?

Update: Reopened the localization issue internally because it wasn't fixed. :)

@lhecker Any news about this? It's just one incorrect character in one string (contained in four resw files). It should hopefully be fairly easy to fix. :-)

It should hopefully be fairly easy to fix. :-)

You say that, but you don't know our internal processes. 🥲
They translated it to Otevřít v &Terminálu in this PR: #18031
Does that sound right to you?

Does that sound right to you?

Yes it does! :-)
Thanks!


[tool_crash] StateError: Bad state: No context with the running Dart application.

Command
flutter --no-color run --machine --track-widget-creation --device-id=chrome --start-paused --dart-define=flutter.inspector.structuredErrors=true lib\main.dart

Steps to Reproduce

...
...
...

Logs
StateError: Bad state: No context with the running Dart application.
#0      RemoteDebuggerExecutionContext.id (package:dwds/src/debugging/execution_context.dart:55:7)
<asynchronous suspension>
#1      AppInspector._getExtensionRpcs (package:dwds/src/debugging/inspector.dart:538:20)
<asynchronous suspension>
#2      AppInspector._initialize (package:dwds/src/debugging/inspector.dart:97:34)
<asynchronous suspension>
#3      AppInspector.initialize (package:dwds/src/debugging/inspector.dart:160:5)
<asynchronous suspension>
#4      ChromeProxyService.createIsolate (package:dwds/src/services/chrome_proxy_service.dart:216:18)
<asynchronous suspension>

[✓] Flutter (Channel stable, 3.0.5, on Microsoft Windows [Version 10.0.18363.719], locale en-US)
    • Flutter version 3.0.5 at E:\Mobile\flutter_windows_3.0.5-stable\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (5 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\admin\AppData\Local\Android\sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✗] Visual Studio - develop for Windows
    ✗ Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[✓] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[✓] VS Code (version 1.70.1)
    • VS Code at C:\Users\admin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 104.0.5112.81

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: beta
Creation framework version: 8f89f6505b941329a864fef1527243a72800bf4d
Plugins
audio_session-0.1.6+1
better_player-0.0.82
connectivity_plus-2.3.0
connectivity_plus_linux-1.3.0
connectivity_plus_macos-1.2.2
connectivity_plus_web-1.2.0
connectivity_plus_windows-1.2.0
contacts_service-0.6.3
firebase_analytics-9.1.8
firebase_analytics_web-0.4.0+13
firebase_core-1.17.0
firebase_core_web-1.6.4
firebase_crashlytics-2.8.0
firebase_messaging-11.4.0
firebase_messaging_web-2.4.0
flutter_branch_sdk-5.0.0
flutter_keyboard_visibility-5.2.0
flutter_keyboard_visibility_web-2.0.0
flutter_local_notifications-9.5.3+1
flutter_plugin_android_lifecycle-2.0.6
geolocator-8.2.1
geolocator_android-3.1.8
geolocator_apple-2.1.3
geolocator_web-2.1.5
geolocator_windows-0.1.1
google_sign_in-5.3.1
google_sign_in_android-5.2.8
google_sign_in_ios-5.3.1
google_sign_in_web-0.10.1+2
image_picker-0.8.5+3
image_picker_android-0.8.4+13
image_picker_for_web-2.1.8
image_picker_ios-0.8.5+5
just_audio-0.9.21
just_audio_web-0.4.7
map_launcher-2.2.2
multi_image_picker-4.8.01
package_info-2.0.2
path_provider-2.0.10
path_provider_android-2.0.14
path_provider_ios-2.0.9
path_provider_linux-2.1.6
path_provider_macos-2.0.6
path_provider_windows-2.0.6
permission_handler-9.2.0
permission_handler_android-9.0.2+1
permission_handler_apple-9.0.4
permission_handler_windows-0.1.0
share-2.0.4
shared_preferences-2.0.15
shared_preferences_android-2.0.12
shared_preferences_ios-2.1.1
shared_preferences_linux-2.1.1
shared_preferences_macos-2.0.4
shared_preferences_web-2.0.4
shared_preferences_windows-2.1.1
sign_in_with_apple-3.3.0
sign_in_with_apple_web-1.0.1
social_share-2.2.1
sqflite-2.0.2+1
stripe_android-2.5.0
stripe_ios-2.5.0
toast-0.3.0
url_launcher-6.1.2
url_launcher_android-6.0.17
url_launcher_ios-6.0.17
url_launcher_linux-3.0.1
url_launcher_macos-3.0.1
url_launcher_web-2.0.11
url_launcher_windows-3.0.1
video_player-2.4.2
video_player_android-2.3.4
video_player_avfoundation-2.3.4
video_player_web-2.0.10
wakelock-0.6.1+2
wakelock_macos-0.4.0
wakelock_web-0.4.0
webview_flutter-3.0.4
webview_flutter_android-2.8.8
webview_flutter_wkwebview-2.7.5

Hi @josephjackson0811, please provide a minimal, reproducible example as well as flutter run -v.


General: Deprecate explicitly setting metricName for all scalers

In v2.12 this setting will be internalized and should not be set by users
A log message was added
Checklist

[X] I have verified that my change is according to the deprecations & breaking changes policy
[X] Changelog has been updated and is aligned with our changelog requirements
[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #4220

This is a good idea, but sadly we cannot do it at this level because there are some scalers where metricName is a valid value used in the scaler (like aws cloudwatch). We need to do it one by one

If aws cloudwatch is the only one, then we can probably add the exception to the code added in this PR. Or is there any other scaler where metricName is valid?

I'm not 100% sure, I haven't had time to check it in depth yet

@yardenshoham could you please check the source code of scalers that uses metricName to verify that it is being used only for internal metrics representation?
For example:
https://github.com/kedacore/keda/blob/72defc212aa5ade7e21303d1dc2a00ab84a2803c/pkg/scalers/prometheus_scaler.go#L48
vs
https://github.com/kedacore/keda/blob/72defc212aa5ade7e21303d1dc2a00ab84a2803c/pkg/scalers/aws_cloudwatch_scaler.go#L36

Will do, tonight

Also remember that this doesn't solve all the cases. I mean, this adds  the warning notification (which is nice), but scalers like prometheus requires metricName, they need to be updated to make it optional too

Yes, I didn't claim this would resolve the issue

Yeah, I know it, I said just to share the point. Maybe we can fix them as part of this PR if there are only a few. I mean, if only 1-3 scalers require changes, we could do it in one shoot

I think it's a good idea. For prometheus, how about I normalize the query and set that as queryName?

I think it's a good idea. For prometheus, how about I normalize the query and set that as queryName?

I think it's not necessary, adding a fixed value like 'prometheus' is more than enough as this is an internal value. Something like
If given value, warning and use it
If not given, use something like 'prometheus'
And please, add a comment in scalers where the metricName should be removed or write them somewhere to have them tracked for removing them :pray:

So meta.metricName need not be unique?

So meta.metricName need not be unique?

No, it sin't required since we introduced a dynamic prefix. Each metric has sX- as a prefix where X is the scaler index, so even if you use the same name for all the cases, the metric name will be unique in the scaled object because it's based on the scaler index

Two scalers stand out:

aws-cloudwatch
huawei-cloudeye

How should I handle them?

How should I handle them?

As they are just 2, maybe we can add them in the if to ignore them for the warning. WDYT?

Sounds good, done

/run-e2e

PTAL @zroubalik

Could you update docs as well?

Sure, I'll get started as soon as this PR lands

Should I keep updating this PR?

/run-e2e

Should I keep updating this PR?

It is fine as it now, thanks! :)

Great! Docs PR will be ready tomorrow

Docs PR https://github.com/kedacore/keda-docs/pull/1074

Docs PR kedacore/keda-docs#1074

awesome, could you please track tasks in the issue #4220 ? In the issue describtion there's TODO list

Apart from creating the discussion, what are the other action items? Not sure what needs to be done in "update documentation to specify deprecation notice"

Apart from creating the discussion, what are the other action items? Not sure what needs to be done in "update documentation to specify deprecation notice"

exactly this PR you did: https://github.com/kedacore/keda-docs/pull/1074 :)
Just link it in the tasks in the issue and mark this item as done :)

I commented https://github.com/kedacore/keda/issues/4220#issuecomment-1443528690

I commented #4220 (comment)

I mean the todo list, but I just realized you probably can't modify that, right?

Correct

Is there any more work to get this PR merged? It has 2 approvals


Repalce /nodejs/configuration/ignore-actions.html

Replace
/nodejs/configuration/ignore-actions.html
or
/ruby/configuration/ignore-actions.html
or
/elixir/configuration/ignore-actions.html
With
/guides/filter-data/ignore-actions.html
On all pages

@aksie If I click on all the links here they all redirect to ignore-actions page.
https://docs.appsignal.com/nodejs/configuration/ignore-actions.html
https://docs.appsignal.com/ruby/configuration/ignore-actions.html
https://docs.appsignal.com/elixir/configuration/ignore-actions.html

Could it be that this is already fixed? Or adhref sees this the other way?

The redirect works, but ahrefs.com / google prefers no redirects, so we should replace the links with the correct link of where they end up now AFTER the redirect.

@aksie When I checked the source, I did not find any links. Instead, I have found redirects.
Below all instances of:

/nodejs/configuration/ignore-actions.html
/ruby/configuration/ignore-actions.html
/elixir/configuration/ignore-actions.html

All are found in netlify.toml file.

It is not in the source literally, but there are these lists:

---
title: "Ruby gem configuration options"
---

The following list includes all configuration options with the name of the environment variable and the name of the key in the configuration file.

For more information on how to configure AppSignal with a configuration file or system environment variables, see our <%= link_to "Configuration", "/ruby/configuration" %> topic.

<%= partial "shared/options_list", :locals => { :integration => :ruby } %>

@tombruijn can you point us to where those lists live so we change the link to the right URL without a redirect?

You're looking for this yml file: https://github.com/appsignal/appsignal-docs/blob/a93f97fa89b5ddcffe5f8fd8a0bb4d1d16fcfcb0/data/config_options.yml#L779

@tombruijn thx, fixed it in https://github.com/appsignal/appsignal-docs/pull/605 - please review?


[stable/metabase] Increase livenessProbe timeout from 5 to 30 seconds

What this PR does / why we need it:
Increase livenessProbe.timeoutSeconds from 5 to 30. We give our metabase pod 6 CPU cores but still often the livenessProbe will fail and the pod will be restarted by k8s.
This happens on the hour due to the sync/analyze metadata process.
By setting this value hire the metabase pod completes the sync/analyze process without being restarted.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @unguiculus

/assign @pmint93

@cpanato @unguiculus can I get a require here? Thanks 🙂

Or @pmint93

I'm ok with this PR

/ok-to-test
/lgtm


Support assuming role for route53 in AWS China (and other partitions)

Is your feature request related to a problem? Please describe.

When using an assumed role in AWS China, cert-manager uses the default STS endpoint of https://sts.amazonaws.com, but the correct one should be https://sts.<region-code>.amazonaws.com.cn (ref).
Describe the solution you'd like

Should determine the sts endpoint by region, maybe endpoints api?
Describe alternatives you've considered

Additional context

/kind feature

/reopen


platform: Add comments to example.anchor-config.yaml and simplified test configuration files

… files.

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[x] This PR adds tests for the most critical parts of the new functionality or fixes.

What

Add comments to anchor-config-defaults.yaml.

example.anchor-config.yamlis symbolically linked to anchor-config-defaults.yaml.

Simplify integration-test configuration files

Why
Add comments and simplify platform configurations.
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr241.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr241.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr241.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr241.previews.kube001.services.stellar-ops.com/


docs: Correct EKS Hybrid Nodes execution steps to apply successfully

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 20.31.5 :tada:


Move some modules from Shelley to Core

This PR has been superceded by https://github.com/input-output-hk/cardano-ledger/pull/3109


Minor cleanup

Remove unnecessary folders in .csprojs
Remove PasswordUtil since it is not used by product code.
Delete tests that aren't testing Aspire code

Microsoft Reviewers: Open in CodeFlow

I think we need password util to be used in the password generation but I’m not sure.

I think we need password util to be used in the password generation but I’m not sure.

All it does today is replace " with "", which the password generation never generates " today.
Also, this method/class isn't good enough. Reading https://stackoverflow.com/questions/61486081/password-with-special-characters-in-connectionstring, you need to add single quotes around the password if you are using ;, for SqlServer connection strings. Other string formats have different rules - for example RabbitMQ puts the password in a System.Uri, which needs a lot more escaping.
And as stated above, nothing is actually using it.
These are the reasons I'm deleting it for now. It isn't doing what we think it is.

Good to know, nuke it 😅

For password generation specifically, if we find the need to customize the "special characters", we can add a new option overrideSpecial which allows the resource to specify exactly which special characters can be used. See https://github.com/Azure/azure-dev/issues/3462. (Note we don't have this option today, but we can add it once we find the need.)


HADOOP-19342. SaslRpcServer.AuthMethod print INFO messages in client side

Description of PR
HADOOP-19342
After HADOOP-19306, the following INFO messages are printed in client side. Thanks @steveloughran  for reporting it in https://github.com/apache/hadoop/pull/7140#issuecomment-2483881941 .
We also change SaslMechanismFactory in order to lazily loading the conf.  Otherwise, the conf path may not be set up correctly.
2024-11-18 18:53:37,645 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod SIMPLE: code=80, mechanism=""
2024-11-18 18:53:37,645 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod KERBEROS: code=81, mechanism="GSSAPI"
2024-11-18 18:53:37,646 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod DIGEST: code=82, mechanism="DIGEST-MD5"
2024-11-18 18:53:37,646 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod TOKEN: code=82, mechanism="DIGEST-MD5"
2024-11-18 18:53:37,646 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod PLAIN: code=83, mechanism="PLAIN"

How was this patch tested?
Manual test.
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[NA] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[NA] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 31s

trunk passed

+1 :green_heart:
compile
19m 13s

trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m 30s

trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
1m 52s

trunk passed

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
2m 45s

trunk passed

+1 :green_heart:
shadedclient
39m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
16m 49s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
16m 49s

the patch passed

+1 :green_heart:
compile
16m 13s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
javac
16m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 16s

hadoop-common-project/hadoop-common: The patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49)

+1 :green_heart:
mvnsite
1m 43s

the patch passed

+1 :green_heart:
javadoc
1m 15s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
2m 46s

the patch passed

+1 :green_heart:
shadedclient
37m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 44s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  5s

The patch does not generate ASF License warnings.

235m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7174/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7174

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 563006313dfd 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bf515f96cad0efa0ae366b74b71b8289c64d3e42

Default Java
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7174/1/testReport/

Max. process+thread count
3109 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7174/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

that test is gone?

@steveloughran , yes, removed the test since it affects other tests as you mentioned.  Tried multiple things but not working very well. One problem is that Configuration has addDefaultResource but not removeDefaultResource. Let skip the test.

Tried multiple things but not working very well. One problem is that Configuration has addDefaultResource but not removeDefaultResource. Let skip the test.

ok. something for the future
I'd thought the trick would be to write an empty config file to the destination, but there's still risk

@steveloughran , @stoty, thanks a lot for reviewing this!


ACCESS TOKEN visible when ssh to container

Summary

When you ssh to your pod and run "env" you cannot see the secrets as just path of secrets like op://my-vault/item/username
This is great. But at the same time ACCESS TOKEN is visible as env variable which is a deal breaker. It is like handing over keys to all your secrets. Can this be fixed to hide the ACCESS TOKEN as well?
Use cases

This will help in securing the secrets properly as secrets are hidden but access token to access those secrets is visible
Proposed solution

Add this secret to connect server instead So that we do not need add this secret in every namespace and in every deloyment manifest.
Is there a workaround to accomplish this today?

No workaround
References & Prior Work

Hey 1password team @volodymyrZotov @edif2008
Do you any comments on this?
Thanks

Hi @ld-singh .
I assume you put OP_CONNECT_TOKEN or OP_SERVICE_ACCOUNT_TOKEN into Kubernetes Secret and use it in your manifest, aka
- name: OP_CONNECT_TOKEN
   valueFrom:
       secretKeyRef:
           name: onepassword-token
           key: token

And unfortunately, this is how the Kubernetes Secrets work. After connecting to the pod you can check the env variables values. There is nothing the injector can do with that currently.
Try to follow the steps to secure your Kubernetes Secrets that are listed withing the link I provided above.

Thanks @volodymyrZotov
Thats the very reason I am looking for solutions like 1Password secret injector. So i will probably have to find a workaround to inject this token. I assume this is used by op cli to fetch secrets.

@volodymyrZotov
I have come up with a solution to problem I mentioned.
The solution is to add annotations to application deployment manifest .
Then create a secret for secret injector webhook with that token and make it available as env variable to webhook.
Now webhook will pass token to application based on value in annotation.
The token is now not visible in logs or as env in applications. Also since webhook is missing shell, helps from leaking there as well.
Now you only need to create 1 secret with all tokens and pass to webhook as env. there is no need to create secrets in every namespace.
I have working solution in my fork. I have tested and works really well
Could you please go through this and let me know if are happy to merge? currently I do not have permissions to create PR.
My fork: https://github.com/ld-singh/kubernetes-secrets-injector
I have tested and works for me. I think it will make 1password secret injector more secure. Please do have a look.
Thanks


Added new method to StateContainer that takes a StateSequence instace

Description
I've been using VSM more and more inside of Swift Concurrency code and notice that I keep repeating the same mistake over and over. When ever I write a function on a state model that returns a StateSequence, I mark that function as async even though inside said function I don't call any async functions. I believe it's because current the only way to have StateContainer to observe a StateSequence you need to call the observeAsync method which takes an async closure that returns a StateSequence.
Take this method as an example;
func getFirstPage(using datasource: Datasource) async -> StateSequence<PagedListViewState> {
    .init({ .fetchingFirstPage }, { await fetchingPage(using: datasource) })
}

I wrote it this way because when I call it I typically write it like this:
$state.observeAsync { await viewModel.getFirstPage(using: datasource) }

But this is entirely unnecessary because creating a new instance of StateSequence is not an async options. StateSequence models an array of async closures that return a State. iterating through the sequence is an async operation.
So in this PR I added a new overload to the observe method that I think is a better fit when you need to only observer a StateSequence, but creating that sequence is not asynchronous. Taking the same code as above I would now write the function that returns the StateSequence like this:
func getFirstPage(using datasource: Datasource) -> StateSequence<PagedListViewState> {
    .init({ .fetchingFirstPage }, { await fetchingPage(using: datasource) })
}

And when I go to observe those state changes I would call the new observe method that would look like this:
$state.observe(viewModel.getFirstPage(using: datasource))

I think this should prevent other users from making the same mistake I keep making.
Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[x] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[x] All code style checks pass
[x] New code contribution is covered by automated tests
[x] All new and existing tests pass

Fantastic addition, Bill! Thanks!


Add AWS EKS best practices

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~30 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

I'm still getting "No CII Best Practices"

I did
https://bestpractices.coreinfrastructure.org/en/projects/6109
https://bestpractices.coreinfrastructure.org/en/projects/6111


ERROR: audio conversion failed

I've tried downloading a couple of songs and converting to MP3. It used to work, but now it doesn't, so maybe it's something to do with the new update? (This only started happening after I updated).
root@whisky:~# youtube-dl -x https://www.youtube.com/watch?v=ytQ5CYE1VZw        [youtube] ytQ5CYE1VZw: Downloading webpage
[youtube] ytQ5CYE1VZw: Downloading video info webpage
[youtube] ytQ5CYE1VZw: Extracting video information
[download] Eminem - Till I Collapse [HD]-ytQ5CYE1VZw.webm has already been downloaded
[download] 100% of 5.08MiB
[ffmpeg] Destination: Eminem - Till I Collapse [HD]-ytQ5CYE1VZw.mp3
WARNING: Your copy of avconv is outdated, update avconv to version 10-0 or newer if you encounter any errors.
ERROR: audio conversion failed: Decoder (codec id 0) not found for input stream #0:0

Different song:
root@whisky:~# youtube-dl -x https://www.youtube.com/watch?v=_Yhyp-_hX2s
[youtube] _Yhyp-_hX2s: Downloading webpage
[youtube] _Yhyp-_hX2s: Downloading video info webpage
[youtube] _Yhyp-_hX2s: Extracting video information
[youtube] _Yhyp-_hX2s: Downloading MPD manifest
[download] Destination: Eminem - Lose Yourself [HD]-_Yhyp-_hX2s.webm
[download] 100% of 5.20MiB in 00:00
[ffmpeg] Destination: Eminem - Lose Yourself [HD]-_Yhyp-_hX2s.mp3
WARNING: Your copy of avconv is outdated, update avconv to version 10-0 or newer if you encounter any errors.
ERROR: audio conversion failed: Decoder (codec id 0) not found for input stream #0:0

Debian 7 OS

Post the full output of youtube-dl when run with -v, i.e. add -v flag to your command line, copy the whole output and post it in the issue body wrapped in ``` for better formatting. It should look similar to this:
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2015.12.06
[debug] Git HEAD: 135392e
[debug] Python version 2.6.6 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...

Do not post screenshots of verbose log only plain text is acceptable.
The output (including the first lines) contains important debugging information. Issues without the full output are often not reproducible and therefore do not get solved in short order, if ever.

root@whisky:~# youtube-dl -v -x https://www.youtube.com/watch?v=ytQ5CYE1VZw
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'-x', u'https://www.youtube.com/watch?v=ytQ5                                                                             CYE1VZw']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.02.13
[debug] Python version 2.7.3 - Linux-3.2.0-4-amd64-x86_64-with-debian-7.9
[debug] exe versions: avconv 0.8.17-6, avprobe 0.8.17-6, ffmpeg 0.8.17-6, ffprob                                                                             e 0.8.17-6
[debug] Proxy map: {}
[youtube] ytQ5CYE1VZw: Downloading webpage
[youtube] ytQ5CYE1VZw: Downloading video info webpage
[youtube] ytQ5CYE1VZw: Extracting video information
[youtube] {22} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {43} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {18} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {5} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {36} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {17} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {137} signature length 40.39, html5 player en_US-vfldIygzk
[youtube] ytQ5CYE1VZw: Downloading player https://s.ytimg.com/yts/jsbin/player-e                                                                             n_US-vfldIygzk/base.js
[youtube] {248} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {136} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {247} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {135} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {244} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {134} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {243} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {133} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {242} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {160} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {278} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {140} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {171} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {249} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {250} signature length 40.41, html5 player en_US-vfldIygzk
[youtube] {251} signature length 40.41, html5 player en_US-vfldIygzk
[debug] Invoking downloader on u'https://r16---sn-aiglln7r.googlevideo.com/video                                                                             playback?id=o-AAclxJ_h6tLgdj6Zyvu6yULtehE23ER7HmS80M7abz5j&mv=u&upn=M9olFFwZWwA&                                                                             mt=1455972565&ms=au&mn=sn-aiglln7r&ip=<IP_ADDRESS>&mm=31&itag=251&pl=23&gir=yes&                                                                             key=yt6&mime=audio%2Fwebm&fexp=9405185%2C9410706%2C9416126%2C9418643%2C9420452%2                                                                             C9422596%2C9423661%2C9423662%2C9424489%2C9425396%2C9425549%2C9426651%2C9427126%2                                                                             C9428029%2C9428247%2C9428396%2C9429130%2C9429518&nh=IgpwcjAzLmxocjI2KgkxMjcuMC4w                                                                             LjE&clen=5328709&dur=298.541&sver=3&requiressl=yes&source=youtube&keepalive=yes&                                                                             lmt=1449635269960664&sparams=clen%2Cdur%2Cgcr%2Cgir%2Cid%2Cip%2Cipbits%2Citag%2C                                                                             keepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cnh%2Cpl%2Crequiressl%2Csource%2Cupn                                                                             %2Cexpire&ipbits=0&expire=1455994219&gcr=gb&signature=32BF5084259E24781DAB34C3F0                                                                             590A616C5A4D04.A3A011E84C0F597494D023345C943C4B2370B124&ratebypass=yes'
[download] Destination: Eminem - Till I Collapse [HD]-ytQ5CYE1VZw.webm
[download] 100% of 5.08MiB in 00:00
[debug] avconv command line: avprobe -show_streams 'file:Eminem - Till I Collaps                                                                             e [HD]-ytQ5CYE1VZw.webm'
[ffmpeg] Destination: Eminem - Till I Collapse [HD]-ytQ5CYE1VZw.mp3
WARNING: Your copy of avconv is outdated, update avconv to version 10-0 or newer                                                                              if you encounter any errors.
[debug] ffmpeg command line: avconv -y -i 'file:Eminem - Till I Collapse [HD]-yt                                                                             Q5CYE1VZw.webm' -vn -acodec libmp3lame -q:a 5 'file:Eminem - Till I Collapse [HD                                                                             ]-ytQ5CYE1VZw.mp3'
ERROR: audio conversion failed: Decoder (codec id 0) not found for input stream                                                                              #0:0
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 17                                                                             38, in post_process
    files_to_delete, info = pp.run(info)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/postprocessor/ffmpeg.p                                                                             y", line 280, in run
    'audio conversion failed: ' + e.msg)
PostProcessingError


For archive 2

 Move Archive to S3 and decommission server

Sorry - had to add a commit to make tests pass, can you re-approve?