Show ignoredUnrecoverableEvents on timeout if they occurred

What does this PR do?
If a workspace timeout occurs, the workspace deployment's container statuses & pod events (including events listed in the DWOC's ignoredUnrecoverableEvents) are checked for failures. If a failure occurred, it is reference in the timeout error message.
I had to move deployment_provisioning.go from the metrics package to the workspace package in order to prevent an import cycle that was created by the new CheckForIgnoredWorkspacePodEvents() function that this PR introduces. I also fixed a duplicate import of the controller-runtime client in deployment.go
Some extra notes:

I wanted CheckForIgnoredWorkspacePodEvents() to be in pkg/library/status/check.go but this would create an import cycle that seemed tricky to fix. Though, I'm willing to try again if the decision to move  deployment_provisioning.go from the metrics package to the workspace package isn't satisfactory.

I wanted to write an envtest test to verify this fix, but it seemed to be more tricky than I hoped:

I tried manually creating a FailedSchedling event in the envtest environment, but DWO wouldn't catch it. This seems to be due to the fact that the test environment doesn't have a deployment controller, so the workspace deployment doesn't create pods that the FailedScheduling event can be associated with. Manually creating a pod with the appropriate workspace labels doesn't seem to work either.

Manually creating the event with USE_EXISTING_CLUSTER=true set didn't seem to work either, though this is probably the best approach. In my testing, the workspace pod only had the FailedMount event (due to some PVC provisioning error); the manually created FailedScheduling event wasn't being associated with the workspace pod. Drawbacks of this approach (using an existing cluster) include an increase in the duration of the entire testing suite and additional effort required (e.g. deleting the test namespace on cleanup, potentially waiting longer for PVC cleanup, and setting up Minikube on the CI)

What issues does this PR fix or reference?
#1041
Is it tested? How?

Configure the DWOC so that the FailedScheduling event is ignored, and set the progressTimeout to 1 minute (so that you don't have to wait the default 5 minutes for the timeout to occur): kubectl edit dwoc -n $NAMESPACE

kind: DevWorkspaceOperatorConfig
apiVersion: controller.devfile.io/v1alpha1
config:
  routing:
    clusterHostSuffix: <IP_ADDRESS>.nip.io
    defaultRoutingClass: basic
  workspace:
+    ignoredUnrecoverableEvents:
+    - FailedScheduling
+    progressTimeout: 1m
    imagePullPolicy: Always

Create a workspace that will cause a FailedScheduling event. E.g. a workspace that requests more CPU than the cluster can provide:

kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: theia-next-high-cpu
spec:
  started: true
  template:
    projects:
      - name: web-nodejs-sample
        git:
          remotes:
            origin: "https://github.com/che-samples/web-nodejs-sample.git"
    components:
      - name: theia
        plugin:
          uri: https://che-plugin-registry-main.surge.sh/v3/plugins/eclipse/che-theia/latest/devfile.yaml
          components:
            - name: theia-ide
              container:
                env:
                  - name: THEIA_HOST
                    value: <IP_ADDRESS>
                memoryRequest: 2Gi
                memoryLimit: 16Gi
                cpuRequest: 4000m
                cpuLimit: 8000m
    commands:
      - id: say-hello
        exec:
          component: theia-ide
          commandLine: echo "Hello from $(pwd)"
          workingDir: ${PROJECTS_ROOT}/project/app

Check the workspace deployment status: kubectl get dw -n $NAMESPACE -w

After a minute, the workspace should fail. The error message should detail that a timeout occurred, and that the FailedScheduling event occurred:

NAME                  DEVWORKSPACE ID             PHASE      INFO
theia-next-high-cpu   workspace656dfe6d86764967   Starting   Waiting for workspace deployment
theia-next-high-cpu   workspace656dfe6d86764967   Failing    devworkspace failed to progress past phase 'Starting' for longer than timeout (1m). Reason: Detected unrecoverable event FailedScheduling: 0/1 nodes are available: 1 Insufficient cpu. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod..
theia-next-high-cpu   workspace656dfe6d86764967   Failed     devworkspace failed to progress past phase 'Starting' for longer than timeout (1m). Reason: Detected unrecoverable event FailedScheduling: 0/1 nodes are available: 1 Insufficient cpu. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod..

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

One thing to note: the workspace failure message gets truncated more than if a timeout hadn't occurred, due to some extra characters being used to say devworkspace failed to progress past phase 'Starting' for longer than timeout (1m). Reason:

/retest

/retest

A few structural comments, but a good start :+1:

Thank you for the feedback, will have these issues addressed 😎🙏


Check if viewing experience is similar for iDevices

Currently I have only Linux, Android and Windows devices to test on.
I need to check if Apple devices display app similar to my devices.

One of the users tested it and currently there is no issues for iOS. Everyting looks like on Android.


Sanitization Strategy for Embedded HTML In Translate Filter and Service

If I have a translation string that contains html tags, like so:
    "TERM_DIALOG": {
        "INSTRUCTIONS": "Select a term from the list below and click OK to display the classes, tests and data associated with the specified term."
    },

And I’m using the sanitizeParameters strategy, it seems like the only way to get the string ‘OK’ to display with the required strong styling (instead of displaying the literal  html tags in the page) is to use the directive form of translate, like:

But I cannot do this:
{{‘TERM_DIALOG.INSTRUCTIONS’ | translate }}
Or this:
$translate(‘TERM_DIALOG.INSTRUCTIONS’).then(function (translation) {  // do something with the translated string here });
Can we allow the translate filter and service to perform the translation in the same way the directive does?  I need to have the option to use any of the three translation methods in our app with translation strings that may contain embedded html.
Thanks for any help and for the excellent module!

Hm, if you set your sanitize strategy to
$translateProvider.useSanitizeValueStrategy('sanitized');

it will also parse these basic html tags correctly and even should without any configuration on the strategy if it isn't a parameter (your example isn't).
Please have a look at http://angular-translate.github.io/docs/#/guide/19_security if you haven't done so already.
I've just forked that example on the page and it works to me.
http://plnkr.co/edit/z5vIXNxnHn9Fuk9wyJSa?p=preview

Thorsten,
Thanks for the explanation. Perhaps my issue report was somewhat incomplete, so I apologize.  I have added to the plunkr to demonstrate what I was trying to report.
http://plnkr.co/edit/lHSKRJKxJqlCTnWHxZcL?p=preview
See my Dynamic Text section at the bottom of the updated plunkr.  Basically I have one translation string being used in 3 different ways:

using an interpolation using the translate filter,
using an interpolation where the variable on the scope has been translated using the $translate service's instant method, and
using the translate directive (regardless of whether or not there are translation values)

Notice that the string OK is displayed in bold only using the directive form, not in the other cases.  What I am looking for is a strategy that will display the string OK in bold across all forms.
Also, it would be wonderful if somehow the translate directive didn't overwrite existing inner HTML within the element on which it is used, or if there was an option to preserve vs. overwrite.  See the directive form with inner HTML.
I hope this clarifies my request somewhat.  Thanks for taking the time to reply and assist.
Thanks,
Rich

{{dynamicText}} is a expression which will be escaped (by AJS) automatically (well, except it is a sanitize wrapper value).
Perhaps I'm overseen something.. but it looks everything as expected (in context of AJS bindings).

Thanks for looking into this and for the feedback.  As I understand your explanation, the {{dynamicText}} string is being sanitized by AJS, so that once $translate.instant() is called in the controller function to generate the translated string, AJS will sanitize the string for display.  If this is the case, how would you recommend I display translated strings containing HTML that are created using the $translate service?  I tried wrapping the call to $translate.instant() inside $sce.trustAsHtml(), but it still displayed the tags in the web page instead of the OK I was expecting.
Thanks again.

sidenote: Have a look at my latest reply here https://github.com/angular-translate/angular-translate/issues/1101#issuecomment-140426486
Yeah, I'd accidently thought ng-bind would also look for sanitized values. Well, go for ng-bind-html.http://plnkr.co/edit/hpTjxvgN0qC2ig6sCpC8?p=preview

For @tspaeth answer, the strategy is written 'sanitize' and not 'sanitized' ;)


Add news page?

Should we have a news page to track major updates (e.g., yesterday's release?).
If it could be some sort of wordpress like or SEO optimized, that could be nice – if it's not too disruptive with the current full stack approach for the website.

I am happy to take this issue and create a news page on the github wiki @WrathfulSpatula. We could also add a stub of the roadmap.


Adding missing , to example code

Without the , it is not valid python code

Thanks, +1.  Can you please sign-off your commit so that the DCO test passes?

@albertodonato anything else needed from me to get this merged?

@fliiiix sorry, I had missed the PR update. thanks


multi-node/aws: expose more config options

This allows users to configure the controller and worker instance types.
It also changes the config to use the aws defaults unless defined in the config and updates the supported channels to include beta.
Fixes #150 and possibly #154

LGTM

+1 Perfect.


Awake from injection documentation

Adds a section to the README describing this newly added mechanism. (Issue #22, PR #25)

Awesome; thank you @briancroom !


Support GUI configuration and improve UI response

This original goal of this PR  was to implement a config flow to allow the integration to be configured via the GUI.
When configured via the GUI a new device with a media player entity is now created.
I got a bit out of hand and I overhauled a number of other things

Removed usage of deprecated consts in favor of enums
Fixed an issue with unsubscribing
Preemptively updated local media player state instead of waiting for the topic. I found that shairport sync does not immediately send an "play_end" but instead a "play_flush" when paused and the lag was annoying.

This is awesome, @mill1000!
On the surface, this all looks good and is a nice catch-up on some Python (annotations) and HA updates. I've been thinking about implementing the config flow stuff, but I'm super short on time.
If you could also update the README to state which version you've tested with, I'd be happy to merge this. My own testing has just been against the one version I typically run.
My system using this is currently shut down, but I'll spin it up again soon (and probably upgrade everything on the Pi), which means I'll be in a better position to work on this project again and to test stuff.
For now, if we can just state which is the known version this was tested again, we're good to go (HA and Shairport Sync's versions).

@parautenbach, I think this is good to go know.

Muchas gracias!


Lemur's :Destroy() disconnects all listeners despite that not being a feature of :Destroy()

https://github.com/LPGhatguy/lemur/blob/42e609ea4761f648eb1e556274c0030c2a0f50a4/lib/instances/BaseInstance.lua#L204
I assume this line is to replicate the behavior that disconnects all events when :Destroy() is called, but this (at least from reading the code, I haven't tested it) also breaks GetPropertyChangedSignal connections.
local part = Instance.new("Part")

part:GetPropertyChangedSignal("Name"):connect(function()
	print(part.Name)
end)

part.Changed:connect(print)

part.Name = "A"
part:Destroy()
part.Name = "B"

This code will print A and B. In lemur (again, presumably from reading the code) it'd only print A.

Not sure, maybe you could ask someone?

Strange, while the connections aren't cleared the instances ARE cleared from memory.
local memory = {}

for index=1,3e5 do
	local instance = Instance.new("Model", workspace)
	memory[index] = instance

	--COMMENT THIS PART OUT TO SEE THAT WITHOUT IT, THE MEMORY IS CLEARED
	instance:GetPropertyChangedSignal("Name"):connect(print)

	if index % 3e4 == 0 then
		wait()
	end
end

print("DONE MAKING STUFF IN MEMORY, CHECK DEVELOPER CONSOLE (PhysicsParts)")

workspace.Part.ClickDetector.MouseClick:wait()

print("Clicked")

for index,value in pairs(memory) do
	value:Destroy()

	if index % 3e4 == 0 then
		wait()
	end
end

print("All destroyed, check memory")

--while true do wait() end


[Feature]: Re-Think the Directory of Files Layout

What area(s) will this request affect?
Running your code locally
What type of change do you want to see?
Substantial change to existing feature
Overview
For no apparent reason, we have the root directory where we can run the commands such as
 yarn run dev

Which brings up our App. But what if we want to use a console into our actual App code. If we spawn a new shell and it outputs a new shell for us, our muscle memory instinctively types out something like rails c to bring up a console. But alas, this is not to be, for we are not in the correct directly. We need to move to the /web directory to get things done.
This is painful. Why is this? Who made this abomination? Would it have been too much to ask that we have one root and from there, get most work done without messing about with where we are exactly?
Motivation
I dislike having to cd web every single time I want to run a console on my App in a new shell.

In order to support extensions work, the main app is stored inside the web directory. If you feel like you need to cd into the web directory often you can add your own shortcuts inside your package.json, for example:
  "scripts": {
    "console": "cd web && rails console"
  },


Add odo catalog list components -o json

Adds json output for listing catalog components. For example:
odo catalog list components -o json

{
  "kind": "ComponentList",
  "apiVersion": "odo.openshift.io/v1alpha1",
  "metadata": {
    "creationTimestamp": null
  },
  "items": [
    {
      "name": "dotnet",
      "namespace": "openshift",
      "allTags": [
        "2.0",
        "latest"
      ],
      "nonHiddenTags": [
        "2.0",
        "latest"
      ]
    },
    {
      "name": "httpd",
      "namespace": "openshift",
      "allTags": [
        "2.4",
        "latest"
      ],
      "nonHiddenTags": [
        "2.4",
        "latest"
      ]
    },
  ]
}

This builds commit from this PR: https://github.com/openshift/odo/pull/2066
So https://github.com/openshift/odo/pull/2066 will need to be merged in first :+1:

Thanks for commenting @dharmit I've updated it based upon your suggestions.

/retest

[odo]  ✗  Unable to connect to OpenShift cluster, is it down?

/test integration

Integration test looks good to me, however i seek review from @dharmit too.

Updated this implementation, let me know if this is okay and then I can refactor what I've already done in machineoutput for odo catalog list services...
Also, please check if the Kind is correct. CatalogListServices or if you want me to use CatalogList

/retest

Ready for another review, example ofthe output is below:
{
  "kind": "ComponentTypeList",
  "apiVersion": "odo.openshift.io/v1alpha1",
  "metadata": {
    "creationTimestamp": null
  },
  "items": [
    {
      "kind": "ComponentType",
      "metadata": {
        "name": "dotnet",
        "creationTimestamp": null
      },
      "spec": {
        "namespace": "openshift",
        "allTags": [
          "2.0",
          "latest"
        ],
        "nonHiddenTags": [
          "2.0",
          "latest"
        ],
        "imageStreamRef": {
...

          }
        }
      }
    },
  ],
}

ping @amitkrout @dharmit @kadel

Closing in favour of https://github.com/openshift/odo/pull/2133


Add mention about support

Inspire from this https://github.com/WASdev/ci.docker/blob/master/README.md github.


Allow Extraction of PSBT struct

Expose the entire PSBT in the bindings.
(https://docs.rs/bitcoin/0.29.2/bitcoin/util/psbt/struct.PartiallySignedTransaction.html)
This will allow the tx to be extracted with available data, verification of extracted tx.
This will also be useful and perhaps mandatory for multisig tx creation and signing.

Depends on https://github.com/bitcoindevkit/bdk-ffi/issues/311

@thunderbiscuit This will help in reading data so a step in the right direction.


Beam search adjustment

What does this PR do?

Main change is to move the termination check to the beginning of on device beam search, matching the flow of a while loop. I've numerically compared it against FlaxWhisperForConditionalGeneration and internal state yields identical outputs on CPU. Unfortunately, the flax implementation still appears to have some tiny deviations in logic from eager, so some differences might have to be accepted.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Update Go Version

Travis is failing due to golint as shown below. It appears Go 1.8 is no longer supported (https://github.com/golang/go/issues/28291).
$ go get -u golang.org/x/lint/golint
# golang.org/x/tools/go/internal/gcimporter
../../../golang.org/x/tools/go/internal/gcimporter/bexport.go:212: obj.IsAlias undefined (type *types.TypeName has no field or method IsAlias)
The command "go get -u golang.org/x/lint/golint" failed and exited with 2 during .

@mdeuser, anything else?


Revert "Add support for rich code navigation in GitHub"

Reverts microsoft/terminal#12855

@zadjii-msft i restored your OG branch so you could make another PR from it :)


Cmake update

Merge the cmake updates from ironictoo into the latest Gpufit synced branch

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: jimkring:x: ironictooYou have signed the CLA already but the status is still pending? Let us recheck it.


Rook Ceph with local partition possible?

Hi,
are there any already known reasons, why it should not work to use the post_create_commands and:
shrink the existing partition to some useful value that leaves enough space for rook ceph and provision it on the local empty space?
I personally need readwritemany storage and a soulution for this as high available as possible.
Thoughts welcome. I could try after vacation and share a working config afterward.
Wanted feature?
Cheers
Timo

The post create commands are executed during Cloud Init. Perhaps changing the partition layout during that process isn't supported by Cloud Init.

Parts of Perplexity.ai's answer to that question might me wrong, but the source of https://askubuntu.com/questions/1019772/how-to-setup-partitions-on-my-boot-disk-with-cloud-config describes a way that seems to have worked already. Lets try.. The rest of AIs answer(citate):
To change the partition layout during the cloud-init process on Ubuntu or Debian, you need to carefully configure the cloud-config file to specify the desired partitioning and filesystem setup. Here’s a step-by-step guide based on the provided sources:
Cloud-Config File Structure
Here is an example of a cloud-config file that partitions the disk into three parts: / (root fs), /home, and /var, each with the specified percentages.
text
#cloud-config

resize_rootfs: false

disk_setup:
  /dev/vda:
    table_type: 'mbr'
    layout:
      - 25  # Root FS (25% of the disk)
      - 50  # Home (50% of the disk)
      - 25  # Var (25% of the disk)
    overwrite: true

fs_setup:
  - label: root_fs
    filesystem: 'ext4'
    device: /dev/vda
    partition: vda1
    overwrite: true```

  - label: home_disk
    filesystem: 'xfs'
    device: /dev/vda
    partition: vda2
    overwrite: true
  - label: var_disk
    filesystem: 'xfs'
    device: /dev/vda
    partition: vda3
    overwrite: true

runcmd:
  - [ partx, --update, /dev/vda ]
  - [ mkfs.xfs, /dev/vda2 ]
  - [ mkfs.xfs, /dev/vda3 ]
  - [ partprobe ]
  - parted /dev/vda set 1 boot on

mounts:
  - ["/dev/vda1", "/", "ext4", "defaults", "0", "0"]
  - ["/dev/vda2", "/home", "xfs", "defaults", "0", "0"]
  - ["/dev/vda3", "/var", "xfs", "defaults", "0", "0"]

Key Points
resize_rootfs: false: This ensures that the root filesystem is not automatically resized by cloud-init.
disk_setup: Defines the partition table and layout. Here, it uses MBR and specifies the percentages for each partition.
fs_setup: Configures the filesystems for each partition.
runcmd: Runs commands to update the partition table, create filesystems, and set the boot flag.
mounts: Specifies the mount points for each partition[1](https://forum.proxmox.com/threads/disk-partition-using-cloud-init-config.147349/)
[3](https://askubuntu.com/questions/1019772/how-to-setup-partitions-on-my-boot-disk-with-cloud-config)
[6](https://learn.microsoft.com/de-de/Azure/virtual-machines/linux/cloudinit-configure-swapfile)
.

Important Considerations
Ensure that the overwrite option is set to true if you want to overwrite any existing partitions.
The partx, mkfs.xfs, and partprobe commands are used to update the partition table and create the filesystems.
If you are using GPT instead of MBR, you need to adjust the table_type accordingly[3](https://askubuntu.com/questions/1019772/how-to-setup-partitions-on-my-boot-disk-with-cloud-config)
.

By using this configuration, you can achieve the desired partition layout during the initial boot process managed by cloud-init.

try or is the above useless?

try or is the above useless?

I have no idea. I haven't tested with custom partition layouts so far.


SAK-29496 - Podcasts: Use the Jquery datepicker

Podcasts publish is using old style date picker instead of the new one.
File cleanup of the old datepicker component.

This is looking good to me. I can test next week if no else gets to it sooner.

I've tested it with ES locale and works fine, the reason is the server validation, it uses a translation key to validate the format:
date_by_hand_format=MM/dd/yyyy hh:mm a
This translation key is not defined correctly in the SV file:
date_by_hand_format=dd-MM-yyyy hh:mm:ss
I agree with all the comments, having a translation key containing the format for each locale is a wrong solution, i'll work on improve this.

@ottenhoff I've did a hard effort here, i'm mostly convinced about this but want other opinions.
I'm ignoring the <h:inputText> value in the bean because it depends on the locale and i'm considering the hidden value as always comes in ISO format.
It only uses translation keys for displaying formats, as the current implementation does.
If this is a good way to do it, i'll implement the same strategy in other PRs.

i'm considering the hidden value as always comes in ISO format.

Yes, that is a good way to fix it.

@ottenhoff Are you still wanting changes on this?

Yes, I think we are still waiting on changes here. Correct @mpellicer ?

No no, the PR is up to date! All our PRs around the jQuery datepicker are up to date :)
Thanks @ottenhoff & @jonespm

You can see i'm considering always the ISO format, so it's independent from the user's locale
https://github.com/sakaiproject/sakai/pull/4138/files#diff-ca07e46a74f2ecccc75bebe21710c622R99


error on install

Hello,
I am interested in giving your operator panel a try.
on npm install i get the following..  any ideas?  I am running ubuntu 16
npm WARN lifecycle<EMAIL_ADDRESS>cannot run in wd %s %s (wd=%s<EMAIL_ADDRESS>bower install /usr/src/asterisk-operator-panel
Kind Regards,
Mike

Just to be sure, do you have bower installed in your path?

I get the same error on my Ubuntu 16.04 install. Just run bower install manually on the command line after npm install, which will retrieve all Bower assets for the frontend.


JOSS: Software > README

Concerning the JOSS review thread.

Include Logo: The documentation features a logo; consider adding it to the README for consistency and branding purposes.
Provide Usage Instructions: The README should include instructions on how to execute the software's functionality, including the necessary using ... commands to import the package.
Fix Code Errors: The following code snippet from the README returns an error:# Returns a vector of the values of all variables at time 0.0005 (feature not available in v1.0.1)
sol(0.0005)

Error Message:ERROR: MethodError: no method matching (::QuantizedSystemSolver.LightSol{2, 2})(::Float64)
Closest candidates are:
  (::Sol)(::Int64, ::Float64)
   @ QuantizedSystemSolver ~/.julia/packages/QuantizedSystemSolver/XwCgz/src/Common/Solution.jl:93
Stacktrace:
 [1] top-level scope
   @ REPL[17]:1

This suggests that the feature may not be available or properly implemented. Please resolve this issue or update the README to reflect the current capabilities.
Mathematical Explanation of the ODE Problem: The ODE problem presented in the README should be accompanied by a mathematical explanation. This will help users understand how to formulate their own problems and apply the software effectively.
Clarify Feature Availability: The README mentions several features marked as "available only in v1.0.1." This can be confusing for users. Please update the README to reflect the current version and available features accurately.
Plot Mismatch: The provided plot does not match the expected output (as per the attached image). Ensure that the plots in the README accurately represent the software's output to avoid confusion.
Error in Error Analysis Code: The error analysis code provided at the end does not run successfully. Please verify and correct the code examples to ensure they work as intended.
Improve Image Alignment: In the section titled "Example: Buck Circuit," the image alignment could be improved. Centering the image on a separate line would enhance the visual presentation.

The readme file now introduces:

the subject
the installation,
the problem the package aims to solve
usefull links for users (tutorial page) and developpers.


reword G20 #300

attempt to reword the paragraph on academic diversity #300

work out the mentoring dimension.

I've explicitly mentioned mentoring in this section. I guess we could add a link to the working in a team and teach competencies. or vice-versa.

currently I think, that it would be nice, if the competencies would do the back-reference and thereby show that they are derived from the values.


Added info about bad OV9655 breakout boards to camera tutorial.

I think it's good now, but need links to dev board schematics.


clearIncomplete should ignore optional trailing part

I'm using a mask of '999-999-9999 [x99999]' and when I set clearIncomplete to true it always clears unless the optional part is completely filled out.

I am facing similar issue here, when I use masking for independent input type it works fine.
$("#selector").setAttribute('data-inputmask', '"mask": "999-99-9999","clearIncomplete": true');
But when I use same masking in grid with jqGrid, having incomplete value it's not clearing the incomplete value.
                        editoptions: {
                            dataInit: function (element) {
                                $(element).inputmask({ mask: '999-99-9999', "clearIncomplete": true });
                            })}});

Any idea about this?


New editor change lock modal

Implements the new change-lock modal for the editor.
There are more changes than there really are, since I moved the view and related files from dashboard to the common dir.
Noteworthy changes:

The model was changed to be an actual model instead of a collection to avoid duplicating manual state-change logic, this made it a little simpler
The view has a default template for the "standard" texts and states (used on dashboard), but added the option to provide separate template, which I used for the use-case where an already locked item is opened in editor for which the modal is displayed directly indicating that the user must unlock it to continue (cancel and return to dashboard), since the template was diverging so much.

@javierarce please review :)

Frontend tests were OK :+1: (details)

Making that text shorter would be killer @javierarce

We could say something like:

Locking this map will hide it from the dashboard. Reveal it using the header menu or the bottom link.

Love that :)

Fixed in https://github.com/CartoDB/cartodb/commit/db5c184104057bde056e44cee500ecbc1aed8948 have a look there. Deploying on ded04 too if you want to have a "real" look

Frontend tests were OK :+1: (details)

:+1: Looks good to me!


Type of Angle - acute/right angled/ obtuse/straight/reflex/complete

Enter calculator name -
Your answer
Describe calculator functionality -
Your answer
Certainly! Here's a brief description:
Angle Type Classifier
This program determines the type of an angle based on its measurement in degrees. The types of angles it can classify are:

Acute Angle: A narrow angle measuring less than 90 degrees.
Right Angle: An angle that measures exactly 90 degrees, forming an L-shape.
Obtuse Angle: An angle measuring between 90 and 180 degrees, wider than a right angle.
Straight Angle: An angle that measures exactly 180 degrees, forming a straight line.
Reflex Angle: An angle between 180 and 360 degrees, larger than a straight angle.
Complete Angle: An angle that measures exactly 360 degrees, forming a full circle.

Users can input an angle, and the program will determine its type and provide the classification.
Under which category you wish to place it -

[] Computer Science
[x] Mathematics
[] Physics
[] Chemistry
[] Biology
[] Finance
[] Scientific
[] Health
[] Sports
[x] Let project owner decide
[] Suggest a new category - (Answer here)

@SarthakKeshari kindly assign this it to me

Could you please assign this issue to me?

@SarthakKeshari please assign this to me

@SarthakKeshari kindly assign it

Hey @Sam-bhav-20,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\mathematical\angleTypeClassifier
Issue completion deadline - 6th Oct 8:00:00 am IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant


add this feature

Add zooming button

Hi, thanks for your interest in this application! I looked at your changes and I think in the current state it will not work, I see at least the following problems:

You are adding a new C++ file but did not add it to the build (you need to edit the Makefile so your code is compiled with the project: https://github.com/scythx/Maps/blob/master/Makefile#L23 )
This is an application for Haiku, but the code you added is from a Qt application. The two are not compatible and will not work together.
Your code does not interact in any way with other parts of the project, so it will not change the behavior of the application in any way in its current state

If you are interested in contributing to Haiku applications, that's great, but I suggest starting with setting up Haiku on your computer (a real one or a virtual machine) and compiling and running the application there.
We have documentation on installing Haiku here: https://www.haiku-os.org/guides
We have a book for developers, which goes through the basics of C++ and the way our projects are usually organized: https://github.com/theclue/programming-with-haiku/releases/tag/v1.1 you can go through this to write your first C++ programs for Haiku
Let us know if you need any help with this :) You can join our chat https://www.haiku-os.org/community/irc or our forum https://discuss.haiku-os.org to meet with other developers and Haiku users.


docs: suggest using the library as a dev dependency and add example for icon collection installs

Hey there 👋
I've added two examples on how to install icon collections, so it's easer to follow the usage guide. Let me know what you think

Thanks!


Email notifications need to be directed toward specific curators

Description
Email notifications that are sent to curators are currently directed toward anyone having the curator role.  However, ESDIS has decided that each DAAC will host their own curator. This means that each curator will only be responsible for ATBDs associated with their specific DAAC.  Therefore, email notifications need to be directed toward specific curators.  For example, if a science team at the ASDC DAAC submit a review request for an ATBD, ONLY the curator(s) associated with the ASDC DAAC should receive this notification.   We want to ensure that curators are not being bombarded with unnecessary email notifications.
Email notifications table #609.
Tasks:

[ ] Review and determine what steps are needed to direct email notifications toward specific curator(s). Note: currently anyone assigned the curator role receives all notifications.
[ ] Discuss the proposed solution with Impact team members.
[ ] Implement the agreed upon solution.
[ ] Test the implementation.
[ ] After successful testing, let Impact know that this is ready for them to test.

Acceptance Criteria:

[ ] All email notifications are directed specifically toward curators at each DAAC.
[ ] This has been tested (both DevSeed and IMPACT) and works as expected.

@wrynearson @deborahUAH Please review this issue to make sure it makes sense.

Just to clarify....    If authorized users can be associated with individual ATBDs, we need curators to also be associated with certain ATBDs.  That said, there will always be the need to provide all curators with general APT information also.

@deborahUAH Should we close this or move it to the backlog?

hmm.   I think we can move to backlog.  If it is decided that APT will continue to be used, then this will be a needed feature since there will be different DAAC curators and communication would be more efficient if directed to the assigned curator for the ATBD.  @bwbaker1 thoughts?

agreed. moving to backlog.


[RESOLVED] Unavailable by ICMP ping

Problem started at 14:16:14 on 2023.06.13
Problem name: Unavailable by ICMP ping
Host: ZO-FG
Severity: High
Operational data: Down (0)
Original problem ID: 28613
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23123&eventid=28613

Problem has been resolved in 10m 0s at 14:26:14 on 2023.06.13
Problem name: Unavailable by ICMP ping
Host: ZO-FG
Severity: High
Original problem ID: 28613


Locale prefix should be removed from Link href with 'as-needed' middleware

Description
Go on a page with a local that is not the default locale.
The Link href is not respecting setting 'as-needed' from middleware and therefore is displaying the local prefix from the default local.
Mandatory reproduction URL (CodeSandbox or GitHub repository)
sandbox
Reproduction description
Steps to reproduce:

Click on "de" link
check the link for "en" link
See displayed href is '/en/about' instead of '/about'

Expected behaviour
Whatever the current local is, the Link href should not display the local prefix with 'as-needed' middleware.

The link points to /en/about only when you're on the de locale. This is required, because we don't know about the as-needed strategy of the middleware in this situation. However, clicking on the link will result in the correct URL.
Note that this only applies if you're switching the locale. If you're already on the en locale (i.e. no prefix in your case), then the link will point to /about. This optimization can be achieved because if we're on the client side, the current locale is en and we notice that it is not present in the URL, then the strategy must be as-needed.
I'm closing this since this is already working as intended. In 3.0 we've switched the default for localePrefix to always since it's a better default that avoids edge cases like this.
Hope this helps!

hi @amannn , because we are using domains setting and because one domain corresponds to one language so we set localePrefix: "never". However, when using the <Link> component from createLocalizedPathnamesNavigation, the ssr version of the , the href is always prefixed with the locale, but once it's hydrated the prefix is gone, this would have certain impact on the SEO.
I forked the above sandbox and changed the localePrefix: "never", as you can see from this sandbox that the en link, when hovered, shows /about, but if you go check the source code it has locale prefix in it.
en

Besides this, is there a way to not auto redirect to the unprefixed version and localized path? Current if you visit /en/about-us it got redirected to /about-us, and if you have localized path and visiting a path from another language it got redirected to the path of the current language. Is there a way to just yield 404 instead of 307 redirect?
Thanks a bunch!

@zipme This is discussed here: https://github.com/amannn/next-intl/issues/444

as-needed

hi @amannn
I'm not sure to understand "because we don't know about the as-needed strategy of the middleware in this situation". LocalePrefix strategy isn't something decided at project layer ? Why it should be inferred from somewhere, appart from project config?
In the meantime to avoid all my pages not using the default languages, and that are pointing to the default locale, having a "known in advance" redirection, I had to use a wrapper arround next-intl Link to use either next-intl Link or Next default Link.
something like this
import NextLink from 'next/link'
import { Link as IntlLink } from "/utils/navigation"

const _Link = ({
   locale,
   ...props
}) => {
 const locale = useLocale()

 const isDefaultLocale = locale === DEFAULT_LOCALE
 const useNextLink = !isDefaultLocale && (props.locale === DEFAULT_LOCALE)
 const Link = useNextLink ? NextLink : IntlLink

return <Link
  {...props}
 />
}


Updating at broker fails after updating a resource via PUT /admin/api/resources/resource

When I create a resource, using the example JSON from the Swagger UI at POST /admin/api/resources/resource:
{
  "title": "ExampleResource",
  "description": "ExampleResourceDescription",
  "policy": "Example policy",
  "representations": [
    {
      "type": "XML",
      "byteSize": 101,
      "name": "Example Representation",
      "source": {
        "type": "local"
      }
    }
  ]

and then register the connector at the broker, everything is working fine.

After updating the created resource with PUT /admin/api/resources/resource and just changing the title of the example:
{
  "title": "ExampleResourceUPD",
  "description": "ExampleResourceDescription",
  "policy": "Example policy",
  "representations": [
    {
      "type": "XML",
      "byteSize": 101,
      "name": "Example Representation",
      "source": {
        "type": "local"
      }
    }
  ]
}

updating the connector at the broker fails
"status": 500,
  "error": "Internal Server Error",
  "message": "java.lang.RuntimeException: Could not deserialize contract."

Thanks for the issue. We will test this for v5.


initial roadmap

We talked about this on our weekly call.  I suggest moving the unit handling work and sorting out how to understand the data pipeline up and a more through implementation of low-level artists back.

going to re-cycle for CI since there was a docs build failure, but this really should have limited effect on that.
No real reason to keep this as a PR, so intend to simply merge and if it needs changing iterate from there


small issue

Hello, I'm glad to use the plugin you developed，This solved my big problem.
Thank you very much for your selfless dedication.
In use, I found a small problem. When using the client to send a heartbeat and the server to return a heartbeat, it always outputs a Received message on the command line: ******, I think this is unnecessary data, which will affect For other code debugging, you can consider whether to use print in the code I write.
void _messageListener (dynamic message) {
     print ('Received message: $ message'); // this line
     if (_messageCallback! = null) {
       _messageCallback (message);
     }
   }

Thanks for your comment! I'm glad this plugin worked for you!
We've fixed this problem on version 0.2.1 (updated today)


startDate does not work when multi-calendars is enabled

Thanks a lot for this excellent library!
Describe the bug
When using the startDate prop and multi-calendars is enabled the following errors is being thrown:
Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'month')
    at P (vue-datepicker.js:839:16)
    at mt (vue-datepicker.js:991:7)
    at vue-datepicker.js:844:105

Removing multi-calendars fixes it.
Desktop & mobile (please complete the following information):

Browser Chrome 109
Library version 3.65

Thank you so much!


add chinese character range to heading escape regexp

It allow marked render Chinese by default like that:
## 灵活性

to this:

灵活性

instead of:

灵活性

The default heading rendered generates IDs just for convenience (many complained about this, too) and it must not be relied upon. Write a custom rendered with a generating function that suits your needs. I might suggest using something like https://github.com/jeremys/uslug

Thanks for the suggestion. I can use uslug in my own project.
However some basic tool like "Atom Editor" use marked to preview markdown, also some tools such as "markdown to pdf" or "markdown toc" depend on it. I cannot force them all use uslug to render a usable heading link in Chinese or Russian.
Some python implements will render heading link to a random ID. Maybe we can use that as a default implements instead?

const renderer = new Marked.Renderer()
renderer.heading = function (text, level, raw) {
  return '<h'
    + level
    + ' id="'
    + this.options.headerPrefix
    + raw.toLowerCase().replace(/[\s]+/g, '-')
    + '">'
    + text
    + '</h'
    + level
    + '>\n';
}
Marked.setOptions({
  renderer: renderer,
})


baseUrl auto or in config

Please, do not hardcode the baseurl
let baseUrl = 'http://localhost:3001'

use relative url or at least, a config file.
Thx

localhost:3001 is hardcoded in bundle.js. It is very difficult to use with an own domain.

I don't understand why you put this config in your own package.json.
On each upgrade, this file will be overriden and custom config lost.
Please use another file like 'settings.json'


Using placeholders for allow directive

Hello,
I am starting with Caddy and I am trying to use placeholders for the allow directive in the JWT config. I have following testing scenario:
(auth) {
  jwt {
    path /

    # this works
    # allow aud app<IP_ADDRESS>.1.nip.io:2015

    # this does not work
    allow aud {host}
  }
}

app<IP_ADDRESS>.1.nip.io:2015 {
  tls off
  import auth
  proxy / http://app1:8000
}

app<IP_ADDRESS>.1.nip.io:2015 {
  tls off
  import auth
  proxy / http://app2:8000
}

During my fiddling with Caddy I learnt that placeholders are not supported on every directive. Is that the reason for this not working? If so, do you see this as something that can be added to caddy-jwt?
My reason for this is that I have SSO service which I am using to issue the tokens. It is working very well, but I need to prevent JWT token reuse (taking token from app1 and using it for app2). Tokens already contain the claim which I would like to use for validation, but I need to use host name dynamically (the app config is auto-configured from docker in my scenario and I don't have much control over that).

Hi Adam,
This plugin currently doesn't support those placeholders.  It's an
interesting use case though.  I'm sure it's possible to add this, but
I'd have to look at how to do it.  Unfortunately, I don't have a ton of
time to work on this right now.
If anyone is reading this and wants to work it, I'm happy to accept a
pull request to add this.
On Sat, Apr 27, 2019 at 05:52:46AM -0700, adam-stanek wrote:

Hello,
I am starting with Caddy and I am trying to use placeholders for the allow directive in the JWT config. I have following testing scenario:
(auth) {
  jwt {
    path /

    # this works
    # allow aud app<IP_ADDRESS>.1.nip.io:2015

    # this does not work
    allow aud {host}
  }
}

app<IP_ADDRESS>.1.nip.io:2015 {
  tls off
  import auth
  proxy / http://app1:8000
}

app<IP_ADDRESS>.1.nip.io:2015 {
  tls off
  import auth
  proxy / http://app2:8000
}

During my fiddling with Caddy I learnt that placeholders are not supported on every directive. Is that the reason for this not working? If so, do you see this as something that can be added to caddy-jwt?
My reason for this is that I have SSO service which I am using to issue the tokens. It is working very well, but I need to prevent JWT token reuse (taking token from app1 and using it for app2). Tokens already contain the claim which I would like to use for validation, but I need to use host name dynamically (the app config is auto-configured from docker in my scenario and I don't have much control over that).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/BTBurke/caddy-jwt/issues/45

Thanks for the quick response and all your work on this project. I am not Go developer myself so I don't think I can help here. But seeing the recent adoption of Go in projects like this I think I should give it a try during some downtime :)


#2829 Dashboard Portfolio default sorting

https://github.com/bitshares/bitshares-ui/issues/2829

Fixed in https://github.com/blockchainprojects/bitshares-ui/pull/131


Not seeing the Accept changes / discard changes button in diff review

Describe the bug
Not seeing the Accept changes / discard changes button in diff review
To Reproduce
Steps to reproduce the behavior:

/edit improve code

Expected behavior
I should see the  Accept changes / discard changes button in diff review.
Screenshots

Environment

Operating System: [e.g. MacOS]
Continue Version: [e.g. v0.0.353]

Console logs
Additional context
Keyboard shortcuts still work.

A couple questions so I can narrow this down: Is this sporadically happening, or consistently? And does any amount of a) waiting, b) scrolling, or c) changing tabs cause them to show up?

Consistently.
No to A), b) and c)


disable logger on import

this will allow to disable or control logger without aedt_app object
eg
import pyaedt
if level > logging.DEBUG:
    pyaedt.aedt_logger.ENABLE_LOGGER = False
else:
    # debug is requested, set custom formatter and logging file
    pyaedt.aedt_logger.FORMATTER = formatter
    pyaedt.aedt_logger.DEFAULT_LOGGER_FILE = logging_file

LGTM. Great job @beliaev-maksim .


call_info should be made to work through macros

This comes pretty close now:
            macro_rules! id {
                ($($tt:tt)*) => { $($tt)* }
            }
            fn foo() {

            }
            id! {
                fn bar() {
                    foo(<|>);
                }
            }

Unfortunately when the cursor is between two parenthesis like the above the returned node is not recognized as a ast::CallExpr.


Call to undefined method ArcticFalcon\LaravelAnalytics

following all the installation steps got:
Call to undefined method ArcticFalcon\LaravelAnalytics\Providers\GoogleAnalytics::getAfterFilters()
what's missing??
any help please

This namespace is not our package. So please open an issue at "ArcticFalcon"


Compositions between maps and graphs with interactive selection do not render correctly initially

Use the following Brunel on the attached data:
map('usa') at(0,0,100,75) + x(Lat) y(Lon) size(Snowfall:200%) max(Snowfall) color(Source) label(Snowfall,City) tooltip(Snowfall, City, Source) interaction(filter)  at(0,0,100,75) + map(labels)  at(0,0,100,75) |  x(Time) bin(Time:20) color(#selection) opacity(#count) interaction(select) tooltip(Time)  at(0,85,100,100)
There should be a graph at the bottom.  The graph can be made to appear by placing the mouse in the area where it is expected and "zooming" out.  Potentially related, note that panning gestures within this graph will cause the map to pan.

Attaching data..
snowzilla.csv.txt

I believe this has been fixed on /develop now.

and now on master


Pill v1

### Checklist
- [ ] Density (HD, MD, LD, TD)
- [ ] Mode (Light, Dark)
- [ ] State (Default, Hover, Selected/Active, Disabled, Read-only(Static?), Other)
- [ ] Controlled API
- [ ] UITK accessibility parity (screen reader + keyboard interactions)

### Deliverables
- [ ] Characteristics spec
- [ ] Interactions spec, where necessary
- [ ] In Code & Figma (Component + Guide)
- [ ] Supporting site documentation

### Features
- [ ] Clickable pill
- [ ] Optional close button
- [ ] Optional icon descriptor

Discussions with @bhoppers2008 @ZarkoPernar

should have Read-only(Static) state, maybe in v2
Fill (Primary, Secondary, Tertiary) can be removed
Icon usage of pill on left hand side for now, revisit after more understanding about MCP right icon usage
Can do Closable and Clickable at the same time
Color-tagging should make sure the colours selected are following ADA

@ZarkoPernar feel free to update/add anything important I miss! Thanks

🟠7 July - Review Shannon’s files
🟠7 July - Review Nav’s Research
🟠5/6 July - Research: reach out to the team to discuss Pill usage (Nav’s research / Transact Larry/ Payments: Mike & James & Jonathan & Felipe / Security Service: Shannon &Thao)
✅5/6 July - Talk to Rich S explore Pill Usage and how do they (MCP) use Pill, understand if there are more interaction usage
✅5 July -  Pill Design Catch up with Ben & Zarko
ask questions and tell them I’m going to do research and update characteristics from UITK to Salt
✅ 4 July - Kick off call
✅ 3/4 July - UITK Pill research & Questions for component kickoff

07/07 - Zarko opened pr today, can someone please review?

Moved to Amber due to the Pill vs Badge conversation

July 14 - designs - characteristics specs reviewed with zarko/ben - feedback to be addressed;
pill/badge mtg next tuesday
dev - changes being made per designs
docs may be affected based on convo next week

July 18 - Moving closable to V2

@jpmorganchase/salt-content Please review the Pill Component doc @ZarkoPernar and I have completed in the folder Component Docs, thank you!

Have reviewed the figma artefacts. Some small changes before merging.

21/07 - Merged into labs and ready to be released today
Will look at plan to move to core

July 31 - docs ready to be converted to MDX (James)


Initial prototype for wandb sweep

Checklist
GitHub

[ ] I've given this PR a concise, self-descriptive, and meaningful title
[ ] I've linked relevant issues in the PR body
[ ] I've applied the relevant labels to this PR
[ ] I've assigned a reviewer

PR contents

[ ] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[ ] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

Initial prototype for using Wandb sweep with ivadomed. Feedback welcome!
Linked issues
Resolves https://github.com/ivadomed/ivadomed/issues/1124

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 9 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 74.443%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ivadomed/scripts/train_wandb_sweep_hyperparam.py
0
9
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
4614

Relevant Lines:
6198

💛  - Coveralls

Because of the time constraint, I thought a quick solution for running sweeps is to directly run from the wandb dashboard. On the project page, there is an option called "Sweeps" on the left-most column and wandb automatically suggests a list of hyperparameters to try (based on the previous runs) and lets us initialize and run the sweep. I tried on the spine-generic tutorial and it does not work because ivadomed is constrained to get parameter from the config file so even by specifying the hyperparameters separately does not start the sweep.
Next thing to-do:

[ ] Refer to ivadomed_automate_training.py to see how ivadomed can be called from the file itself (without requiring the command line)


docker: fix and docu

fixed omnect-cli ssh set-certificate command in omnect/omnect-cli:0.20.1 docker image
documented -b option to create bmap file is not working in omnect/omnect-cli docker image
@empwilli @mlilien we need to refine how we can support bmap file generation in docker distroless. Either we implement our self or we copy all the python deps into distroless image. Are there other options?

In the lieu of "have you considered rewriting it in rust", there is apparently a project that attempts to do so: https://www.collabora.com/news-and-blog/blog/2023/03/03/oxidizing-bmap-tools-rewriting-a-python-project-in-rust/. However, this project appears to currently only support the "copy" operation. Probably we should keep this tool on the watch list for now. Conversely, we could use the https://pyinstaller.org/en/stable/ project to at least simplify packaging all dependencies for bmap-tools.

In the lieu of "have you considered rewriting it in rust", there is apparently a project that attempts to do so: https://www.collabora.com/news-and-blog/blog/2023/03/03/oxidizing-bmap-tools-rewriting-a-python-project-in-rust/. However, this project appears to currently only support the "copy" operation. Probably we should keep this tool on the watch list for now. Conversely, we could use the https://pyinstaller.org/en/stable/ project to at least simplify packaging all dependencies for bmap-tools.

I was aware of both bmap-rs and the pyinstaller:

bmap-rs doesn't show much activity. I don't think there will be a create subcommand soon. I also had a look at the bmaptool python sources. Imho we could re-implement directly in omnect-cli or contribute it to bmap-rs
pyinstaller: I already spent (too much) time on it and don't get it working. I fail to include /usr/lib/python3/dist-packages/bmaptools dependency. I tried --hidden-import and hook files but no chance yet.

@empwilli @mlilien
Thus I propose to merge this one and solve the bmap (and ssh-tunnel) issues in further tasks. @empwilli you're more experienced with python than me. Maybe you get it working. I could provide you with my current Dockerfile etc...


Error in loading model does not halt execution

When there is an issue with a model, such as a syntax error, there is only a light and undescriptive warning coming from sqlizr after it is loaded, due to this pull request:
https://github.com/mikefrey/sqlizr/commit/a2ec57a0b75cd4902f7749f8fb48e28b10dbe772.
My expectation is that I shouldn't be able to start the server if there is an error with one of the models, as that means the application behavior would almost definitely become unpredictable when certain models are available and others are not.
Maybe you have different reasoning, in which case perhaps some sort of promise on sqlizr and a config option on hapi-sequelize changing this behavior would be better.

@danielrhodes this was intended but I see your point. I will keep this in mind for the new updates


Support for MCBE 1.17.0 / Protocol 440

WaterdogPE updated, but there are still people using Waterdog :)

same for me

Waterdog update is still planed, but it is not high priority at the moment. Update will be out once I will find enough time to create patches.

So when will it come out?

It will be out when it will be out.


Add option for CTRL+[Left]

I often use the combination CTRL+[Left] or [Right] to jump between words in the editor.
However, the [CTRL]+[Left] causes the file tree to collapse/expand.
It would be great to have an option in the configuration file (either per user or system-wide) to deactivate this shortcut.

Please watch this issue #18


What does the Preview Theme at the bottom of Aside @ getbootstrap.com do?

It applies the gradients that were found by default in previous versions of Bootstrap

What @wolfy1339 said. It's only visible on some elements.

And you can apply the theme to your own site by including bootstrap-theme.css

I see.
I understand you can customize the theme, download and apply the theme to my own site - but by that you probably mean my copy bootstrap documentation site - so that the Preview Theme will pick that up locally. But it probably does not make sense on the getbootstrap.com site. Unless, if the user could customize the theme on the customize page and only for their session preview their changes as applicable to the examples. Does that make sense?
IMO this will be a useful enhancement to the site.


React Group Project

In this project:

[ ] We created a Space Travelers' Hub app suing React and Redux
[ ]  Created a Rockets page that fetches rockets data from an API and display them the UI
[ ]  Created Missions page that fetches missions data from an API and renders them on the UI
[ ]  Created My Profile page that display reserved rockets and joined missions
[ ]  Created a button on the Rockets page to reserve or cancel a Rocket reservation
[ ]  Created a button to Join or leave a mission
[ ]  Reserved Rockets are displayed on the My profile page
[ ]  We wrote unit tests for all components using React Testing Library and Jest

Hello @anyars-encarta could you check your slack?


Turn ObjectColumnSelector into an abstract class.

This task is to see if ObjectColumnSelector could be turned into abstract class from interface, and isNull method is made final. Follow up comment from https://github.com/druid-io/druid/pull/5278#discussion_r166013339

It's a very small thing (goal was just to make one method final), I thought it could be a part of that PR, otherwise doesn't worth a separate issue IMO.

I just checked and can say - it could be turned into an abstract class.


APT whitelist request for dfu-programmer

Do you need any more help to get this merged?

@BanzaiMan what's missing from the auto-checker to have it also push clean package additions automatically? This is such a great initiative and it's too bad it's constrained by human resources. At least scaling up the team if it can't be fully automated would be nice. I'm sure you can easily build a web of trust among the people who have added tickets here.


CI: Upgrade test fails when it is the first test ran in test suite for v1.3 branch

While triaging test failures in a v1.3 backport branch, I observed the following:
Upgrade test failed for K8s 1.10 and K8s 1.11 tests.
I noticed that the upgrade test failed in 1.10 and 1.11, but not 1.8 and 1.9. I realized that for 1.10 and 1.11, that the upgrade test was the first test to be run - I suspect that the test doesn't work without some prior test having ran in the Ginkgo suite.

[ ] See if this behavior can be reproduced in v1.3 and master
[ ] If so, fix the test for the v1.3 branch

Another failure with upgrade test as the first test: https://jenkins.cilium.io/view/Cilium-v1.3/job/cilium-v1.3-standard/38/testReport/junit/k8s-1/8/K8sUpdates_Tests_upgrade_and_downgrade_from_a_Cilium_stable_image_to_master/

@ianvernon Very interesting observation!

Assigning myself for triaging.

Test runs fine in master when ran as the first test:
Reproducing steps:
$ git checkout master
$ cd test
$
$ # Clean up all prior state if necessary
$ K8S_VERSION=1.13 vagrant destroy -f k8s1-1.13 ; K8S_VERSION=1.13 vagrant destroy -f k8s2-1.13
$
$ # Boot and provision VMs.
$ K8S_VERSION=1.13 vagrant up --no-provision ; K8S_VERSION=1.13 vagrant provision k8s1-1.13; K8S_VERSION=1.13 vagrant provision k8s2-1.13
$
$ # Focus "K8sUpdates" test
$  K8S_VERSION=1.13 ginkgo --focus="K8sUpdates" -v -- -cilium.provision=false

Test passes:
Running Suite: k8s-1.13
=======================
Random Seed:<PHONE_NUMBER>
Will run 1 of 362 specs

SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
K8sUpdates
  Tests upgrade and downgrade from a Cilium stable image to master
  /Users/ianvernon/go/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:408
=== Test Finished at 2019-02-05T09:20:45-08:00====
<Checks>
Number of 'context deadline exceeded' in logs: 0
Number of 'level=error' in logs: 0
Number of 'level=warning' in logs: 0
Number of 'Cilium API handler panicked' in logs: 0
Number of 'Goroutine took lock for more than' in logs: 0

</Checks>

S [SKIPPING] [13.829 seconds]
K8sUpdates
/Users/ianvernon/go/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:376
  Tests upgrade and downgrade from a Cilium stable image to master [It]
  /Users/ianvernon/go/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:408

  Cilium "v1.3" is not supported in K8s "1.13". Skipping upgrade/downgrade tests.

  /Users/ianvernon/go/src/github.com/cilium/cilium/test/k8sT/Updates.go:87
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSAfterSuite: not running on Jenkins; leaving VMs running for debugging

Ran 0 of 362 Specs in 13.834 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 362 Skipped PASS

Will try in v1.3 branch.

This indeed reproduces for cilium v1.3:
Commands to run:
$ git checkout v1.3 && git pull
$ K8S_VERSION=1.11 vagrant destroy -f
$ K8S_VERSION=1.11 vagrant up --no-provision
$ K8S_VERSION=1.11 ginkgo --focus=" K8sUpdates"

Output (some output removed for brevity / to reduce noise):
$ K8S_VERSION=1.11 ginkgo --focus=" K8sUpdates"
Running Suite: k8s-1.11
=======================
Random Seed:<PHONE_NUMBER>
Will run 1 of 312 specs

Spinning up vagrant VMs... ●SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

------------------------------
• Failure [1877.691 seconds]
K8sUpdates
/Users/ianvernon/go/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
  Tests upgrade and downgrade from a Cilium stable image to master [It]
  /Users/ianvernon/go/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383

  cilium was not able to get into ready state
  Expected
      <*errors.errorString | 0xc0002d49c0>: {
          s: "Timeout reached: timed out waiting for pods with filter -l k8s-app=cilium to be ready",
      }
  to be nil

  /Users/ianvernon/go/src/github.com/cilium/cilium/test/k8sT/Updates.go:153
------------------------------

<K8s installed, images built / pushed, etc.>

STEP: Installing a cleaning state of Cilium
STEP: Installing kube-dns
STEP: Deploying etcd-operator
STEP: Cilium "v1.2" is installed and running
=== Test Finished at 2019-02-05T10:32:50-08:00====
===================== TEST FAILED =====================
cmd: kubectl get pods -o wide --all-namespaces
Exitcode: 0
Stdout:
 	 NAMESPACE     NAME                                    READY     STATUS    RESTARTS   AGE       IP              NODE      NOMINATED NODE
	 kube-system   cilium-etcd-operator-7d6cb45b79-mzcd5   0/1       Pending   0          10m       <none>          <none>    <none>
	 kube-system   coredns-687db6485c-2bcln                0/1       Pending   0          10m       <none>          <none>    <none>
	 kube-system   etcd-k8s1                               1/1       Running   0          25m       <IP_ADDRESS>   k8s1      <none>
	 kube-system   kube-apiserver-k8s1                     1/1       Running   0          25m       <IP_ADDRESS>   k8s1      <none>
	 kube-system   kube-controller-manager-k8s1            1/1       Running   0          25m       <IP_ADDRESS>   k8s1      <none>
	 kube-system   kube-proxy-6nskl                        1/1       Running   0          10m       <IP_ADDRESS>   k8s2      <none>
	 kube-system   kube-proxy-nzf69                        1/1       Running   0          26m       <IP_ADDRESS>   k8s1      <none>
	 kube-system   kube-scheduler-k8s1                     1/1       Running   0          25m       <IP_ADDRESS>   k8s1      <none>
	 monitoring    prometheus-core-6546477dc8-86j5w        0/1       Pending   0          10m       <none>          <none>    <none>

Stderr:

===================== Existing AfterFailed =====================
<Checks>
Number of 'context deadline exceeded' in logs: 0
Number of 'level=error' in logs: 0
Number of 'level=warning' in logs: 0
Number of 'Cilium API handler panicked' in logs: 0
Number of 'Goroutine took lock for more than' in logs: 0
Cilium pods: []
Netpols loaded:
CiliumNetworkPolicies loaded:
Endpoint Policy Enforcement:

</Checks>

SSSSSSSSS

Summarizing 1 Failure:

[Fail] K8sUpdates [It] Tests upgrade and downgrade from a Cilium stable image to master
/Users/ianvernon/go/src/github.com/cilium/cilium/test/k8sT/Updates.go:153

Ran 1 of 312 Specs in 1877.731 seconds
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 311 Skipped --- FAIL: TestTest (1877.74s)
FAIL

Ginkgo ran 1 suite in 31m29.284819134s


Remain access to original model after replacing model on a field

{
  ...
}, {
  key: 'routingNumber',
  type: 'input',
  model: {routingNumber: ''},
  templateOptions: {
  label: gettext('Routing number'),
    onChange: function(value, options, scope) {
      fetchBank(scope.model, value);
    }
  }
}, {
  ...
}

This is just one field, a part of bigger form.
I'm storing routingNumber field outside the model because this is just a search field so I needed to create isolated model for that field. However function fetchBank expects the original model as a first parameter because it wants to modify it (it searches for a bank and inserts it to the original model).
As of current formly version, model object on the field's scope is overriden with what is passed to model attribute and I lose access to the original model. I couldn't find any way to access the original model through the given params in onChange callback. Maybe there could be a reference to original model next to the current model that could be accessed like scope.originalModel or something like that?
If this doesn't make sense, I will try to find an easier example however this is real use case :)
If what I propose is acceptable solution, I could prepare PR as I imagine it is not very complicated issue but needs some documentation work too.
Cheers!

Here's what I'd recommend: https://jsbin.com/wibado/edit?html,js,console,output
Will that do it for you?
Either way, this could be helpful. If you want to make a PR, we can take a look at the amount of complexity it adds to angular-formly. I'm fairly confident I'd accept a PR for this though. Thanks!

Thanks @kentcdodds for the idea however I cannot use data: {originalModel: vm.model} because I have my formly directive inside ng-repeat so my vm.model is array of models, not the exact model that I want.
I will try to compose PR this week, however if you have other workaround I will gladly check if it could work for my case :)

Here's a good workaround: https://jsbin.com/wibado/edit?html,js,console,output

This looks good and legit workaround :) It will definately work in my case. I will try to come up with PR anyway as keeping original model reference might be a good feature anyway.

:+1:

:+1:

This actually would probably be a good first-timers-only issue. Maybe I'll work on adding some tests sometime. Until then, feel free to submit a PR if you want. Should be pretty simple.


EdgeSnap grant proposal

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).
If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

[ ] Level 1:  Up to $10,000, 2 approvals
[ ] Level 2:  Up to $30,000, 3 approvals
[x] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] Payment details have been provided (bank details via email or Polkadot (USDC & USDT) address in the application).
[x] I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @shankarwarang:matrix.org (change the homeserver if you use a different one)

I have read and hereby sign the Contributor License Agreement.

Thanks for the feedback @takahser. We have updated the proposal as per the suggestion.
Currently the Polkadot Snap by ChainSafe only supports Polkadot, Kusama and Westend. Also, EdgeSnap is not just about developing snap apps for substrate chains. We are building an App Store for Substrate Snaps. Also, the major proposition here is the whole service rather than just the product. We want to accelerate the snap-readiness in the Polkadot ecosystem dApps.
Those repos that we've linked currently do not exist as of now and we will be storing the custom npm packages in them. At the moment, we are using the EdgeSnap repo as the mono repo.

Thanks for the application. Two comments:

We don't offer upfront payments.
Are you aware of ChainSafe's intentions for including parachains in their snap?

Noted and made the changes accordingly.
Yes. However, we will be also including the solochains along with the parachains and relaychains (which are aligned with the Polkadot's vision, i.e. only those solochains which are available on Polkadot-JS/Apps). EdgeSnap is more of a service than just a project for the development of substrate snap apps and the brand new Substrate Snap Store. We started building on top of what ChainSafe built. ChainSafe is the core developing entity for bringing the Snap to Substrate in the first place. While we are aiming to become the accelerator for snap-readiness.

Hey @ShankarWarang , I want to follow up on this reply

Currently the [Polkadot Snap by ChainSafe]
(https://snaps.metamask.io/snap/npm/chainsafe/polkadot-snap/) only supports Polkadot, Kusama and Westend. Also, EdgeSnap is not just about developing snap apps for substrate chains. We are building an App Store for Substrate Snaps. Also, the major proposition here is the whole service rather than just the product. We want to accelerate the snap-readiness in the Polkadot ecosystem dApps.

The official metamask snap store is already such a store you envision with a lot of snaps available and a polished ux. What do you think will be the benefit of building another snap store? I suggest getting directly in touch with Chainsafe to see if you can simply work together on this project as it would be a pity to have two teams built on the same open source software with the same framework at the same time and most likely produce duplicates.
On another note: Having a milestone overly expensive to then argue that a non-paid service time will follow is nothing else but upfront payment. Please adjust your milestones so that you first deliver the service or software and upon delivery you will be paid. We can't hold anybody liable in case they completed all milestones and got paid but then don't (for any reason) deliver on further free promises that might have influenced the foundation to accept a grant in the first place.
If you really want to do something like this I would suggest to first write an application for the milestones you have, reduce the cost, and in case this project is a great success with lots of interest by ecosystem teams you can still apply for a maintenance grant. I think this makes it easier for all of us as there is no way to guess the maintenance and advisory workload that might occur in that timeframe.
Sadly the foundation doesn't fund market outreach, feedback collection, marketing or any community events that you are planning in the scope of this grant. Please see here: What activities/positions do you fund?
I'm looking forward to hearing back from you and hope that you will be able to reach out to Chainsafe.

@PieWol Thanks for the follow-up.
The official metamask snap store is not really what we envisioned. It only has two snaps from the whole substrate ecosystem! There could be entry barriers financially and reputation-wise. Building something substrate-native will massively benefit small/new parachains and solochains. The vercel preview (MVP) is for showcasing the functionalities. UI/UX improvements are part of the milestone 1.
ChainSafe proposed SubstrateSnap almost a year ago and it's not yet available. Also, parachains/solochains support is not included in their grant.
Snap Store is just one component of the EdgeSnap along with the Interactive UI, combined with the service which includes the development of snap apps for all the substrate chains and periodic snap integrations on Polkadot/substrate ecosystem dApps.
We are happy to remove the mention of non-paid service (maintenance for 9 months) from the proposal to avoid the influence bias. The current milestones' costs are not influenced by the free 9-month maintenance period.
The per-chain integration costs here are substantially less than the industry average. The average total cost involved per chain for EdgeSnap considering all the milestones will be 1165.0485 USD and the average integration cost per chain (considering milestones 2 & 3) will be 728.1553 USD.

There could be entry barriers financially and reputation-wise.

IIRC, an audit is required for any snap to be listed in the Snap store.

ChainSafe proposed SubstrateSnap almost a year ago and it's not yet available. Also, parachains/solochains support is not included in their grant.

This grant was completed and the result was the initial version of https://github.com/ChainSafe/metamask-snap-polkadot.
Given the size of the undertaking and this grant and the relative novelty of the project, I would recommend that you apply with the Decentralized Futures Program instead.

@semuelle

IIRC, an audit is required for any snap to be listed in the Snap store.

Thanks for highlighting that.

This grant was completed and the result was the initial version of https://github.com/ChainSafe/metamask-snap-polkadot.

I meant to imply that PolkadotApps/dotapps do not support the snap yet and the inclusion of parachains is not stated anywhere.

Given the size of the undertaking and this grant and the relative novelty of the project, I would recommend that you apply with the Decentralized Futures Program instead.

Does the Decentralized Futures Program process the applications on a rolling basis?

@ShankarWarang it's stated on the website of the decentralized futures program, that applications are open until june 2024. So you would have a good amount of time left to apply. It's also stated that applications are reviewed on a rolling basis, yes.

Thanks for your thorough answers @ShankarWarang and for the deep dive @PieWol I have to also concur that this would be a better fit for the DF program, since many of the deliverables cover parts of the development cycle we can't fund, and since the MVP has already been developed. For example, we can't fund feedback & analysis, weekly dev cohorts, etc. Let us know if this sounds good to you or if you'd rather refactor this application with a reduced scope/cost.

Sounds good @ShankarWarang thanks for confirming with us. I will go ahead and close this, let us know if you have further questions.

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/edgesnap-substrate-snap-readiness-accelerator/6326/1

We applied for the decentralised futures grant and also received a response from David Hawig. We replied to him using the edgeware.community custom domain email. As David might not have received any email from that domain before and as it also had embedded links, we suspect that email might have ended up in the spam box.
Can anyone please relay this to David if possible? @takahser @PieWol @semuelle @keeganquigley
Thanks!


Protect parse return string from an error

When WAMR returns an error the result code is 0. This has some weird effects when address translation occurs and causes a SEGV. This protects the return processing from interpreter errors.
Signed-off-by: Mic Bowman<EMAIL_ADDRESS>

So process_response would seem more natural (and maybe the first part of the function could be refactored in a separate extract_response_string function; currently that part makes the actual parsing (invocation) almost disappear).

There's also a parse_invocation_response function in addition. I think we should open an issue to refactor these.


BackgroundTask sample crash

Hello, I have noticed some crashes in the BackgroundTask sample.  It seems that with scenario 3 & 5 if you register, unregister, and then re-register, the app will crash with the following details:
System.Exception was unhandled by user code
HResult=-2147023080
Message=Not enough quota is available to process this command. (Exception from HRESULT: 0x80070718)
Source=Windows
StackTrace:
at Windows.ApplicationModel.Background.BackgroundTaskBuilder.Register()
at BackgroundTask.BackgroundTaskSample.d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at BackgroundTask.ServicingCompleteTask.d__3.MoveNext()
InnerException:

We discovered an OS bug that could result in this error being returned by BackgroundTaskBuilder.Register. It should be fixed in Windows 10 build 10240.
Please let us know if you still see this!

Hi. I get this kind of error occasionally when trying to register ApplicationTrigger background task. OS version is 10240.

I am currently seeing this with build 10586 on iot. After the background task crashes, the app cannot register the background task upon startup again. Every time BackgroundTaskBuilder.Register is called, the above exception is thrown.

i am also getting the same error on the UAP,Version=10.0.10240.0. I get this error while registering the task, i am not sure why it works for few times when you freshly install the app and then just stop working.. i am registering this from another BackgroundTask.. do you think is this got to do anything with it? any help will be appreciated
BackgroundTransferCompletionGroup completionGroup = new BackgroundTransferCompletionGroup();
            BackgroundTaskBuilder builder = new BackgroundTaskBuilder();
            builder.TaskEntryPoint = "xyz";
            builder.SetTrigger(completionGroup.Trigger);

            BackgroundTaskRegistration taskRegistration = builder.Register();

In case you want to re-register the task, don't forget to unregister previously registered instances first. There is a quotum on the number of registrations, that's where this error comes from. You can check if a task was previously registered by checking
var isAlreadyRegistered = Windows.ApplicationModel.Background.BackgroundTaskRegistration.AllTasks.Any(t => t.Value?.Name == yourtaskname);

This issue started reproduce again on Windows 1903 build 18362.175


How do I display this through notify.nvim?

Hi, this is already possible, you just need to install notify.nvim and the status should be displayed as a notification.

I have it installed and I can manually send notifications with lua but when pausing music for example, it does not display in the notifications, instead it displays as the following:

@TeaSpillStudios this plugin just calls to the notify api. Does any of these work for you?
:lua vim.notify("foo")
:call nvim_notify("foo", 2, {})
If they don't, you are probably missing overriding the default notify api.

The first one just returns foo at the bottom of my screen and the second one seems to do nothing. Sorry as this doesn't seem to be an issue with your plugin. I'll close this, thanks so much for your patience and help!


Does this have update method?

excuse me,
after I set the value into keychain,
if I want to update information,
which method should I call?  thanks.

Hi @hungwei0331, thanks for the question.
One can call the set method, it works both for storing data initially and updating existing data.

I see, thanks for your support


Nodes' icons and colors

not 100% sure i have the right solution this time...
... but either way, apologies for stealing this issue :sweat_smile: @MichaelMauderer

I left a review. I think @MichaelMauderer can still improve it :)

Reopening, as still an efficient indexing is to be done.


Feature: Allow MSAL Configuration to be set at runtime

Currently module configuration can only be set at compile time. There
are instances when configuration settings are loaded dynamically and
cannot be set after the module has already been imported in AoT mode.
Adding a runtime configuration method will solve these situations
without breaking existing functionality.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Avizacherman sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


update polkadot-v0.9.28

Bump dependencies to polkadot-v0.9.28

Codecov Report

Merging #799 (088cb86) into master (27115ac) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
+ Coverage   78.35%   78.41%   +0.06%
==========================================
  Files         102      102
  Lines        9927     9927
==========================================
+ Hits         7778     7784       +6
+ Misses       2149     2143       -6

Impacted Files
Coverage Δ

tokens/src/mock.rs
48.14% <ø> (ø)

authority/src/tests.rs
100.00% <100.00%> (ø)

asset-registry/src/lib.rs
93.67% <0.00%> (+2.53%)
:arrow_up:

authority/src/lib.rs
82.78% <0.00%> (+3.27%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more