[Feature request] Release builds only?

Hi!
It's very easy to run benchmark on an assembly built as debug. Sometimes it is good and sometimes definitely not. I've learned that hard way as I just spent some time just to figure out our CI server uses debug builds for our perftests:)
So, I propose the following feature to be included as opt-in:
The ability to proof that benchmark assembly is not built as debug
To define what "debug" assembly mean: it's an assembly with
	[assembly:Debuggable(DebuggableAttribute.DebuggingModes.DisableOptimizations)]

attribute applied.
The API for the feature may look like this (names are preliminary)
		// What to do on debug build
		enum DebugBuildBehavior
		{
			Run = 0,                // Run as usual
			Default = Run,          // The same, used by default
			FailsWithException = 1, // BenchmarkRunner.Run() throws an exception
			DoesNotRun = 2          // Warning is logged, benchmark exits
		}

Also, if DebugBuildBehavior is set to FailsWithException or DoesNotRun and the benchmark assembly is not debug one additional check is performed:
all assemblies being loaded during benchmark run should be checked too (using the AppDomain.AssemblyLoad event to hook it up).
The DebugBuildBehavior enum should be exposed as a property of the IConfig interface so it can be setup individually for each benchmark.
Thanks!:)

Very good point! I agree with you, we should not let the users use non-optimized dlls.
We already preload all dlls to check their target .NET version and build references for csproj so perhaps we could just extend this with the optimization check?
But I am not sure for the default behaviour. Personally I think that we should throw exception and stop. @AndreyAkinshin @mattwarren  what do you think?

@AndreyAkinshin
Also, should the runner throw the exception if the code is running under debugger?
*If you wonder how do you debug the benchmark, there's VS extension for child process debugging.

Don't sure about an exception. It would be cool to add a warning.
I think, if somebody try to debug a child benchmark process, then he should understand what he is doing.

@AndreyAkinshin
Looks like I've asked it wrong:)
Ok, one more time (sorry:))
You're proposing that the exception for debug builds should be thrown by default.
My question is, should the exception be thrown when the code is being run under debugger?

The question really should be whether JIT optimizations are enabled, because that's what makes most of the difference between optimized and non-optimized builds. And, by default, there won't be JIT optimizations when running under a debugger.

@goldshtn
Agreed. Failing even if debugger attached makes the debugging slightly harder, but I don't think that this is a real issue.
All in all, the code from benchmark always can be run (and debugged) directly, without using the BenchmarkRunner.

Ok. I have implemented this feature. How it works:

it is a standalone analyser (JitOptimizationsAnalyser)
it is enabled by default
if you want to disable it you just need to specify a Config class that does not inherit from DefaultConfig
if you want to enable it in your custom Config class  you just put Add(Analyzers.JitOptimizationsAnalyser.Instance);
I take all assemblies referenced by assembly that defines benchmark and for each of these I look for DebuggableAttribute and read IsJITOptimizerDisabled flag. If the flag is set to false I display warning
currently only Classic and Dnx runtimes are supported, Core is not (due to lack of Assembly.Load method and lack of any flags for DebuggableAttribute)

@ig-sinicyn could please let me know if this satisfies you as a user?

@adamsitnik

If the flag is set to false I display warning

Thanks!
There're two drawbacks, however.

The check does not throw and it's hard to detect that it was failed. Especially in case when the benchmark is run as unit test from VS.
There's currently no way to transform benchmark warnings into NUnit warnings, as the first ones are not exposed as member of the Summary class. And xUnit (AFAIK) does not support warning assertions at all.

The check is performed after the test is run. Again, this makes it hard to notice that something went wrong as the benchmark run could take a long time.

@ig-sinicyn Thanks for very usefull comments. I will add Warnings to summary and somehow extend IAnalyser to allow prevalidation and post verification

@adamsitnik  great news!
And thanks for exposing the warnings! I'll try to pass these as NUnit warnings when done. There's no documented way to do this, however the NUnit's IgnoreException is threated as a warning.

@ig-sinicyn @AndreyAkinshin @mattwarren
I have extended our current features with new thing: Validators
public interface IValidator
{
	IEnumerable<IValidationError> Validate(IList<Benchmark> benchmarks);
}

public interface IValidationError
{
	bool IsCritical { get; }
	string Message { get; }
	Benchmark Benchmark { get; }
}

Validators are executed before running benchmarks. There is only one mandatory validator: BaselineValidator (checks wether class does not have more than one Baseline = true method). Summary has been extended and contains list of found errors. If any of the errors is critical, then none of the Benchmarks is executed and export is also ommited.
@ig-sinicyn In your case if you would like to fail on error when any of the dlls that defines benchmark was not optimized you can use Add(JitOptimizationsValidator.FailOnError); in your config. Please let me know if it fixes the problem

@adamsitnik  Wow! That's much better than my original proposal, thumbs up.

Please let me know if it fixes the problem

It definitely does:)


Add --cap-add=SYS_PTRACE for debug purpose

In some situation, user job will hang and need to attach the process the debug this issue.
Currently, in container, we cannot using gdb to atttach the process due to ptrace not allowed.
Consider to add --cap-add=SYS_PTRACE to allow gdb attach, Need to investigate this capability
https://stackoverflow.com/questions/19215177/how-to-solve-ptrace-operation-not-permitted-when-trying-to-attach-gdb-to-a-pro

it was a feature in #2334

Thanks, seems we should add this back


Does this also work with other chains?

Since this is a rewrite of the rusty-blockparser, which could also read other chains, I was wondering if this project can also read other chains.

For the moment it does not yet support other chains. I am considering refactoring this project a bit to support other chains. If you find it helpful to you, I could add it to my plan.


React CheatSheet

Hi can i add React Cheatsheet?

There's already a react cheatsheet available, you can make some changes if you feel they would be valuable. Prior to that elaborate on the updates, you would do over there.

Oh okay cool, I'll take a look at that


There are two headers，how to resolve

why...
why...
why...

https://github.com/zenoamaro/react-quill/issues/784


Add support for icon tinting

Using DrawableCompat.wrap() and DrawableCompat.setTint() it would be possible to tint icon on the fly

I noticed a strange issue in the sample, once you use the tap either javaTinting or xmlTinting the other drawables in the view are also tinted. Maybe it's something the I guess it's an edge case that you'd want multi password fields on a page with different hide/show icon colours. But still wanted to flag encase you could see a fix. Tested on Android 4.2 and 5.0.

Strange
I tested it in my own app and there were no such issues
Waits for investigation

I think one solution here is to "mutate" the drawable so the drawable is not "recycled".

@nex0s Lol. Completely forgot about this issue. Seems to be the root of the evil

I added 'mutate' option to my commit to address this bug


Stored Github User information should be updated (#537)

Modified the logic in the Perform function in login/service.go
to retrieve the user everytime, and save the identity if
the user already existed, not just during creation.
Signed-off-by: Xavier Coulon<EMAIL_ADDRESS>

Can one of the admins verify this patch?

[test]

Current coverage is 69.53% (diff: 0.00%)

Merging #594 into master will decrease coverage by 0.01%

@@             master       #594   diff @@
==========================================
  Files            74         74
  Lines          4266       4267     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2967       2967
- Misses         1013       1014     +1
  Partials        286        286

Powered by Codecov. Last update 281d9cf...548994d

Weee, first commit!

\o/


GH-40261: [Go] Don't export array functions with unexposed return types

Rationale for this change
Exposing functions that return unexposed types in Go is considered poor practice. This approach complicates type handling, making it challenging for developers to utilize these return values in their functions. Developers must undertake the cumbersome process of identifying the applicable interface for the return type, a task that often results in significant time consumption and leads to confusing, non-informative types being suggested by godocs and IDEs.
Consider the difficulty in discerning the relationship between two return types, *simpleTable and arrow.Table, at a glance. It is not immediately clear whether they implement the same interface or are distinct entities:

Returning exposed interfaces is already commonly done in the Arrow package to ensure API consistency and usability, as evidenced in methods like AddColumn() -> arrow.Table and RecordFromJSON() -> arrow.Record. Extending this to all functions, including NewTable, NewTableFromSlice, and NewRecord, will standardize the codebase in line with these principles.
The use of *simpleTable and similar types is restricted in explicit type declarations and function signatures. Therefore, transitioning to exposed return types is a backward-compatible improvement that will lead to enhanced documentation and better support in IDEs for Arrow users.
What changes are included in this PR?

Change return signature of functions using the following unexposed return types:

*simpleTable --> arrow.Table
*simpleRecord --> arrow.Record
*simpleRecords --> array.RecordReader

Add the function String(), which is implemented by *simpleTable, to the arrow.Table interface. *simpleTable is the only implementation of arrow.Table, so this requires no further changes.

Are these changes tested?
Yes. The relevant code is already covered by tests in arrow/array/table_test.go (TestTable) and arrow/array/record_test.go (TestRecord, TestRecordReader).
All tests pass (subpackages without tests omitted):
ok      github.com/apache/arrow/go/v16/arrow    0.398s
ok      github.com/apache/arrow/go/v16/arrow/array      0.600s
ok      github.com/apache/arrow/go/v16/arrow/arrio      1.544s
ok      github.com/apache/arrow/go/v16/arrow/avro       0.629s
ok      github.com/apache/arrow/go/v16/arrow/bitutil    1.001s
ok      github.com/apache/arrow/go/v16/arrow/compute    2.147s
ok      github.com/apache/arrow/go/v16/arrow/compute/exec       0.813s
ok      github.com/apache/arrow/go/v16/arrow/compute/exprs      1.900s
ok      github.com/apache/arrow/go/v16/arrow/csv        0.288s
ok      github.com/apache/arrow/go/v16/arrow/decimal128 1.356s
ok      github.com/apache/arrow/go/v16/arrow/decimal256 1.718s
ok      github.com/apache/arrow/go/v16/arrow/encoded    0.493s
ok      github.com/apache/arrow/go/v16/arrow/flight     2.845s
ok      github.com/apache/arrow/go/v16/arrow/flight/flightsql   0.512s
ok      github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver    7.386s
ok      github.com/apache/arrow/go/v16/arrow/float16    0.570s
ok      github.com/apache/arrow/go/v16/arrow/internal/arrjson   0.419s
ok      github.com/apache/arrow/go/v16/arrow/internal/dictutils 0.407s
ok      github.com/apache/arrow/go/v16/arrow/internal/testing/tools     0.247s
ok      github.com/apache/arrow/go/v16/arrow/ipc        1.984s
ok      github.com/apache/arrow/go/v16/arrow/ipc/cmd/arrow-cat  0.530s
ok      github.com/apache/arrow/go/v16/arrow/ipc/cmd/arrow-file-to-stream       1.267s
ok      github.com/apache/arrow/go/v16/arrow/ipc/cmd/arrow-json-integration-test        1.074s
ok      github.com/apache/arrow/go/v16/arrow/ipc/cmd/arrow-ls   1.263s
ok      github.com/apache/arrow/go/v16/arrow/ipc/cmd/arrow-stream-to-file       0.935s
ok      github.com/apache/arrow/go/v16/arrow/math       0.616s
ok      github.com/apache/arrow/go/v16/arrow/memory     1.275s
ok      github.com/apache/arrow/go/v16/arrow/memory/mallocator  0.348s
ok      github.com/apache/arrow/go/v16/arrow/scalar     0.484s
ok      github.com/apache/arrow/go/v16/arrow/tensor     0.418s
ok      github.com/apache/arrow/go/v16/arrow/util       0.621s

Are there any user-facing changes?
This update will not affect users directly since the modified interfaces were previously unexposed and, consequently, inaccessible from user code. This change is aimed at improving the developer experience by simplifying type usage and enhancing documentation clarity.

GitHub Issue: #40261

Thanks for this and it looks great to me other than my one nitpick! :)

Thank you! Good callout, that's indeed way more elegant :)


Refactor tools code

This pull request fixes the Conversor JSON to CSV file name and improves some lines of python code.

Appreciate the fixes, espcially the args code, I'll take a note of that for the future.
With respect to itemgetter, if we use that rather than the lambda function, the end of the output looks like this:
--snip--
{
    "program_name": "Zscaler",
    "policy_url": "https://www.zscaler.com/company/vulnerability-disclosure-program",
    "submission_url": "https://www.zscaler.com/vulnerability-disclosure-form",
    "launch_date": "",
    "bug_bounty": false,
    "swag": false,
    "hall_of_fame": false,
    "safe_harbor": ""
  },
  {
    "program_name": "Zynga Whitehat",
    "policy_url": "https://bugcrowd.com/zynga-vdp",
    "submission_url": "https://bugcrowd.com/zynga-vdp/report",
    "launch_date": "",
    "bug_bounty": false,
    "swag": false,
    "hall_of_fame": true,
    "safe_harbor": "partial"
  },
  {
    "program_name": "cPanel",
    "policy_url": "https://cpanel.net/cpanel-security-bounty-program/",
    "submission_url"<EMAIL_ADDRESS>    "launch_date": "",
    "bug_bounty": true,
    "swag": false,
    "hall_of_fame": true,
    "safe_harbor": ""
  },
  {
    "program_name": "cPaperless",
    "policy_url": "https://www.cpaperless.com/security-statement/",
    "submission_url"<EMAIL_ADDRESS>    "launch_date": "",
    "bug_bounty": false,
    "swag": false,
    "hall_of_fame": false,
    "safe_harbor": ""
  },
--snip--

--snip--
Zscaler,https://www.zscaler.com/company/vulnerability-disclosure-program
Zynga Whitehat,https://bugcrowd.com/zynga-vdp
cPanel,https://cpanel.net/cpanel-security-bounty-program/
cPaperless,https://www.cpaperless.com/security-statement/
--snip--

This is because the sort function treats capitals - all capitals - as coming before lower case letters in the alphabet. It's only a few companies that start with a lower case letter, but I can see people re-adding them, assuming that because they don't appear under "C", they aren't in the list at all.

Holding on this until the above is addressed

@seantitmarsh Thanks! I didn't pay attention that sorting using itemgetter is case-sensitive.

@codingo You can merge it. Hope I helped you!

@mendesfabio Looks good now. I've closed my PR in favour of this one.
I didn't actually know about the case sensitivity of sort with itemgetter until yesterday, it took an hour or so of tearing my hair out to find out about the way python sorts alphabetically. Good learning experience though.
@codingo, agreed, this one is good to merge now.

Thank-you! Could you please list your twitter here so I can send you a one month pentesterlab voucher for your contribution.

Thanks! Here it is: https://twitter.com/fabiomendesafc

Thank-you! This has now been sent.


主线合并

Pull Request Test Coverage Report for Build 809024778

74 of 96 (77.08%)  changed or added relevant lines in 18 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.2%) to 56.076%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

<EMAIL_ADDRESS>0
1
0.0%

<EMAIL_ADDRESS>0
1
0.0%

<EMAIL_ADDRESS>3
4
75.0%

<EMAIL_ADDRESS>3
4
75.0%

<EMAIL_ADDRESS>3
4
75.0%

<EMAIL_ADDRESS>3
4
75.0%

<EMAIL_ADDRESS>0
4
0.0%

<EMAIL_ADDRESS>0
12
0.0%

Files with Coverage Reduction
New Missed Lines
%

<EMAIL_ADDRESS>4
0%

Totals

Change from base Build 792023126:
1.2%

Covered Lines:
1372

Relevant Lines:
2414

💛  - Coveralls


Add gyp paths for FreeBSD support

This doesn't build on FreeBSD because FreeBSD installs package files under /usr/local.  This diff adds a conditional check for FreeBSD, which adds those paths.

Thanks! Sorry for the delay. Released in v2.3.1.


feature - avoid utf-8 decoding for text frames

just because it is supposed to be in utf-8, doesn't mean I prefer it in that form.  specifically, my usecase, is giving the data to orjson, and passing it around as an orjson.Fragment().
Here are the documents for that use case.
https://github.com/ijl/orjson#deserialize
https://github.com/ijl/orjson#fragment
looking at websockets code, if such a capability were to be implemented, it seems like we'd want to add an flag to WebSocketCommonProtocol() and then use it to force binary around the time it decides on whether to decode it or not, located here:
https://github.com/python-websockets/websockets/blob/main/src/websockets/legacy/protocol.py#L1053
I'd be happy to whip up a patch in case you would consider this feature request.

That would work quit well.  I guess I misunderstood the code, because it looked to me as if the recv() method is decoupled from where the actual processing of inbound data (read_message()).  The solution you propose would certainly be more flexible.

just thinking about the send side, I think it really is less important.  there aren't too many servers that are strict in what they accept, especially when they are expecting text.  I think if we implement it for send, while the effect is the same (skip encode, skip decode), but the names of the options will be different, e.g: decode_text_frames=False for recv(), and send_as_text=True for send()

Yes, we need to pick the names for both sides carefully and, ideally, consistently.
raw_utf8 is a name that could work for both sides. I'm not sure it's the best name we can find, though.
If we have two names, I'd like some symmetry e.g. using the words decode and encode.

I'm finding myself in the same position, trying to send data encoded with orjson as a text frame even when it is provided to websockets in binary form.
Any chance this gets added?

This will be added as part of the new asyncio implementation (#1332).

The new asyncio implementations supports recv(decode=False), which is the original request here.
(Also recv(decode=True) for the opposite behavior.)
I'm not planning to work on the other features discussed above, notably send(), until someone has a use case.

send() was handled in #1515.


Omnicomplete not finding variables.

Actual behavior
When I try and invoke an omnicomplete on a Java file, it doesn't seem to have any knowledge of the variables.
In this example, I'm trying to type out adamId, and it decides to omnicomplete to wait().  It's not demonstrated with the gif, but this is true of any variable.

Also not demonstrated is that what I try invoking the completion after the ., no suggestions come up.
Expected behavior (Required!)
To complete the word I am typing based on the variables in scope, and to offer completions of the methods after hitting ..
The steps to reproduce actual behavior (Required!)

Use this config:

call plug#begin('~/.local/share/nvim/plugged')

Plug 'https://gitlab.com/tombert/vim-wombat-scheme.git'
Plug 'ctrlpvim/ctrlp.vim'
Plug 'artur-shaik/vim-javacomplete2'
Plug 'neomake/neomake'
Plug 'ervandew/supertab'
Plug 'tpope/vim-commentary'
Plug 'editorconfig/editorconfig-vim'
Plug 'tpope/vim-fireplace', { 'for': 'clojure' }
call plug#end()
call neomake#configure#automake('w')
let g:SuperTabDefaultCompletionType = "<C-X><C-O>"
map <silent> <C-E> :Lexplore<CR>
colorscheme wombat
let g:netrw_liststyle = 3

filetype plugin indent on
set ai
set nocompatible
set omnifunc=syntaxcomplete#Complete
autocmd FileType java setlocal omnifunc=javacomplete#Complete
" show existing tab with 4 spaces width
set tabstop=4
" when indenting with '>', use 4 spaces width
set shiftwidth=4
" On pressing tab, insert 4 spaces
set expandtab

Try the autocomplete in a method.

Environment (Required!)

OS: Mac OS 10.13.6
Vim version:
Neovim version: 0.3.1

Are you using any autocomplete plugins? Like YouCompleteMe or deoplete?

@artur-shaik I am not.  That is my complete configuration.  Should I be using one of those?

Yes. It triggers completions.
On 09-18 (08:44), Thomas Gebert wrote:

[1]@artur-shaik I am not. That is my complete configuration. Should I be
using one of those?
—
You are receiving this because you were mentioned.
Reply to this email directly, [2]view it on GitHub, or [3]mute the thread.
References
Visible links

https://github.com/artur-shaik
https://github.com/artur-shaik/vim-javacomplete2/issues/401#issuecomment-422444660
https://github.com/notifications/unsubscribe-auth/AEozuzphsXr0rOykFywEC9VWobKuvLYhks5ucRTBgaJpZM4WmcFQ

--
Best regards,
Artur Shaikhullin

Ok, upon installing deplete it seems to be more or less working.


are there pretained models?

I want to have a pretained mode trained on Imagenet? can anyone help me?

same question. @xiaochus

same question. @xiaochus

same question. @xiaochus   thanks

+1

+1

+1

The python keras-applications library is probably helpful here


How can i use rasa response and send it to my own robot?

Hi,
I don't know where is the correct place to ask this question, so if it's the wrong place, sorry about that!
I'm using rasa3.1 and everything is working with your HTML file. I want to have access to the rasa response in an HTML file and send it with URL method to my robot? so I need to define a string variable to store received messages as rasa responce and use this message in my own way. I searched a lot but I couldn't find something useful to work correctly.
I would be grateful if you give me a hand.
thanks.

Thanks for raising this issue, @losterloh will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

Dear @sara-tagger
I'm waiting and searching and checking! nothing yet..


[✨ FEATURE]: Implement Dependabot for Automated Dependency Updates

Feature Description 📝
Implement Dependabot support in the project to automate dependency updates.
Motivation 🌟
The motivation behind this feature request is to ensure that our project's dependencies are regularly updated to include security patches, bug fixes, and new features. Dependabot will automate the process of monitoring and updating dependencies, reducing the manual effort required to keep our project up-to-date.
Expected Behavior 🤔

Dependabot will periodically check for updates to our project's dependencies.
When updates are available, Dependabot will create pull requests to update the dependencies in our project.
We can review and merge these pull requests to incorporate the latest dependency versions into our project.

Additional Information ℹ
Dependabot is a widely-used tool in the open-source community for managing dependencies. By adding Dependabot support to our project, we can ensure that our dependencies are regularly updated and our project remains secure and up-to-date.
Thank you for considering this feature request! 🙌

@jvJUCA @KarinePistili Please assign me this issue and would love to hear our thoughts on this feature

Hello @asr2003 I think it is a good idea. I'll assign it to you

Following the period of inactivity on this issue, I have submitted a PR to address it. Please review it at your convenience. Thank you!

Closed as it was already satisfied on PR #412


V5 version: Use the tooltip plug-in, move the mouse into the floating window, the floating window will disappear, how to set the mouse to move to the floating window, the floating window will not disappear?

Describe the bug / 问题描述

如何设置鼠标移动到浮窗里面，浮窗不会消失呢？
Reproduction link / 重现链接
No response
Steps to Reproduce the Bug or Issue / 重现步骤
No response
G6 Version / G6 版本
🆕 5.x
Operating System / 操作系统
macOS
Browser / 浏览器
Chrome
Additional context / 补充说明
No response

配置 enterable: true 即可，后续会完善相关文档

感谢~

已解决


Terraform Destroy returns "credentials are not set correctly" but Terraform Apply works

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v0.15.0
on windows_amd64

provider registry.terraform.io/cloudflare/cloudflare v2.20.0
provider registry.terraform.io/hashicorp/local v2.1.0
provider registry.terraform.io/hashicorp/tls v3.1.0
provider registry.terraform.io/oktadeveloper/okta v3.10.1
provider registry.terraform.io/vancluever/acme v2.4.0

Affected resource(s)
cloudflare_origin_ca_certificate
cloudflare_record
Terraform configuration files
terraform {
  required_providers {
    cloudflare = {
      source = "cloudflare/cloudflare"
      version = "2.20.0"
    }
  }
}

provider "cloudflare" {

  # Configuration options
  email   = var.cloudflare_email
  api_key = var.cloudflare_api_key
    # api_token = var.cloudflare_api_token
  api_user_service_key = var.cloudflare_api_user_service_key
}

resource "cloudflare_record" "okta" {
  name = "_oktaverification.${var.okta_custom_domain_prefix}"
  zone_id = var.cloudflare_zone_id
  type = "TXT"
  ttl = 1
  value = ********
}

 resource "tls_private_key" "example" {
   algorithm = "RSA"
 }

 resource "tls_cert_request" "example" {
   key_algorithm   = tls_private_key.example.algorithm
   private_key_pem = tls_private_key.example.private_key_pem

   subject {
     common_name  = "${var.domain_name}"
     organization = var.org
   }
 }

 resource "cloudflare_origin_ca_certificate" "example" {
   csr                = tls_cert_request.example.cert_request_pem
   hostnames          = [ "${var.domain_name}", "*.${var.domain_name}" ]
   request_type       = "origin-rsa"
   requested_validity = 365
 }

 resource "local_file" "certificate" {
   filename = "${path.module}/certificate_request.pem"
   content = tls_cert_request.example.cert_request_pem
 }

 resource "local_file" "mykey" {
   filename = "${path.module}/private_key.pem"
   content = tls_private_key.example.private_key_pem
 }

 resource "local_file" "origin_ca" {
   filename = "${path.module}/origin_ca_tls.pem"
   content = cloudflare_origin_ca_certificate.example.certificate
 }

Debug output
│ Error: credentials are not set correctly
│
│   on modules\cloudflare\main.tf line 10, in provider "cloudflare":
│   10: provider "cloudflare" {
│
╵
This is the full output
https://gist.github.com/code2exe/a2c76b5412b867f0a2955b4c95081c25
Panic output
No response
Expected output
Apply complete! Resources: 0 added, 0 changed, 1 destroyed.
Actual output
Error: credentials are not set correctly
│
│   on modules\cloudflare\main.tf line 10, in provider "cloudflare":
│   10: provider "cloudflare" {
Steps to reproduce
terraform destroy
Additional factoids
The terraform destroy command doesn't work but if I comment out the resource I want to delete and run terraform apply, it then destroys the desired resource as should have during terraform destroy
References
No response

@code2exe are you able to provide the untruncated TF_LOG=DEBUG output please? I suspect this is because you have email/key and api_user_service_key in use and the authentication mechanism is getting confused however we'll need the output to be certain.

@code2exe are you able to provide the untruncated TF_LOG=DEBUG output please? I suspect this is because you have email/key and api_user_service_key in use and the authentication mechanism is getting confused however we'll need the output to be certain.

Hi @jacobbednarz
Yes, you're right. I used the email/key and api_user_service_key.  My intention is to create Origin CA certificate and the api_user_service_key is required for it.
I have tried to use only api_token but I still get that error

re: TF_LOG=DEBUG output, i need the untruncated version. unfortunately there isn't enough context in that to show what the issue is and what HTTP requests are happening. feel free to redact/scrub any sensitive details before providing it.

re: TF_LOG=DEBUG output, i need the untruncated version. unfortunately there isn't enough context in that to show what the issue is and what HTTP requests are happening. feel free to redact/scrub any sensitive details before providing it.

Here is the full output you requested for?
https://gist.github.com/code2exe/01bcf4a1985cb1ef5212b2517e8cf09f

re: TF_LOG=DEBUG output, i need the untruncated version. unfortunately there isn't enough context in that to show what the issue is and what HTTP requests are happening. feel free to redact/scrub any sensitive details before providing it.

Here is the full output you requested for?
https://gist.github.com/code2exe/01bcf4a1985cb1ef5212b2517e8cf09f

Hello @jacobbednarz  Any updates on this?

closing this one out since there have been multiple improvements in how the authentication works and is handled internally by the provider.
i'd recommend trying this again with the latest version and if it is still an issue, open a new ticket with the details.


[ACR] Decide whether to require Audience on ClientOptions

@lmolkova is working with the service team to understand whether to require callers to pass Audience into ACR clients, or whether we can set a default of "https://containerregistry.azure.net".
Once this is decided, implement the decided outcome.

Based on the information from the service team, we should proceed with defaulting to "https://containerregistry.azure.net/" when the audience is not set (for all clouds).


extentions restricted area

Problem
I am from Iran and you restricted Iran for downloading extensions from your website or the CMS admin marketplace menu.
Even Google Analytic stopped such restrictions for Persians after what they call Iran Nuclear deal. could you please stop these behaviors cause this is kind of racist now and defiantly it is not acceptable in the new world!

There is no geo restriction in place, to the best of my knowledge. What kind of error message do you receive that makes you think it is blocked from the server side?


Fixing squid: S1213 Members of an interface or class should appear in a pre-defined order

This pull request is focused on resolving occurrences of Sonar rule
squid:S1213 - “Members of an interface or class should appear in a pre-defined order”.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1213
Please let me know if you have any questions.
Fevzi Ozgul

I do not see any problems in the changes I made. I wonder why it says "the branch has conflicts" This PR is about changing the place of the variables within the class. Nothing more, nothing less. It should not result in any conflicts.

我把这个RP先关掉后,你可以尝试再发请一个RP

Hi dounine,
Do you mean I should send the Pull Request again?

yes

i close this pr

I created a new one.
On Thu, May 26, 2016 at 3:57 PM, dounine<EMAIL_ADDRESS>wrote:

Closed #19 https://github.com/dounine/clouddisk/pull/19.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/dounine/clouddisk/pull/19#event-673122688


Exposing struct_utils for accessing custom JWT fields

Exposing struct_utils to enable custom JWT fields to be retrieved from a
parsed JWT using the existing payload_pb field
Signed-off-by: Nick Smith<EMAIL_ADDRESS>

@googlebot I signed it!

Closing to sign with another CLA-covered email address.


Is it possible to use this seed to build an angular2 ui library?

It's possible, but you'll need to tweak the webpack config so the output is what you need it to be.
TL;DR
You'll have to make some tweaks to the web-pack config. We set ours up with a 'lib' area and a 'demo' area, and initially just had TypeScript import barrels at the root of the project - since we were using webpack to consume it, it didn't matter that the TypeScript/SCSS wasn't compiled yet. Although we do have an outstanding task to pre-compile the TypeScript for the library, we haven't gotten around to adding the build task for that, yet.

Thank you, I'm in the same situation.
FYI, I found this brother project that should have the library goal, but it's quite embryonal and inactive. I will stay tuned


Cluster support

If running on a cluster, e.g. using Slurm, then all GPUs and CPUs connected to the rack are measured even if your job is only running on a selected few of those.
Need to filter CPUs and GPUs used by your worker. Ideally, this should also account for several jobs being run on the same worker, e.g. if two jobs or backgrounds processes use the same CPU. This could be done by measuring utilization by process.

Fixed in v1.0.7.
A new feature request has been made for measuring utilization by process: https://github.com/lfwa/carbontracker/issues/6


Awaken effect whole party

Awaken is not used often.
Making it effect whole party would make it very useful.
https://github.com/Fenyx4/U4DosRandomizer/blob/master/u4_decompile/SRC/U4_SPELL.C#L147
Idea from organmike

I like this one. There are other spells that could use a tweak too, as they are almost never used.

An additional tweak would be a lasting effect. I.e., a spell status that KEEPS the party awake and protects against further sleep spells for a couple of turns.

https://github.com/Fenyx4/U4DosRandomizer/tree/awaken


fix: auto renaming for Templ files

This PR fixes the issue with auto renaming tags in Templ files.
Changes:

Added patterns for start and end tags specific to Templ files.
Updated skip patterns to handle Templ-specific nodes.

This ensures that tags in Templ files are correctly renamed automatically.

Thanks for the PR @axzilla, much appreciated.
Do you have a sample templ file I can use to make a test with. There's not a contributing requirement right now for tests, so I'm not going to push you to write them.
I just want an example templ file you'd expect nvim-ts-autotag features to work in so I can write some tests later to support this PR.
Once I have that sample, I'll merge 🙂

Nevermind, got a sample now. Thanks again 😄

Nevermind, got a sample now. Thanks again 😄

Glad, that i could help. =)


bug: panic on mv-on-mv

Describe the bug
I created 3 materialized views and the creation on mv1, mv2 was fine, but it always fell into panic when I created mv3 as join of mv1 and mv2.
thread 'tokio-runtime-worker' panicked at 'not yet implemented: handle finish report after meta recovery', /Users/wutao/git/risingwave-dev/src/meta/src/barrier/notifier.rs:123:33
stack backtrace:
   0: rust_begin_unwind
             at /rustc/cb121987158d69bb894ba1bcc21dc45d1e0a488f/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/cb121987158d69bb894ba1bcc21dc45d1e0a488f/library/core/src/panicking.rs:142:14
   2: risingwave_meta::barrier::notifier::UnfinishedNotifiers::finish_actors
             at ./src/meta/src/barrier/notifier.rs:123:33
   3: risingwave_meta::barrier::GlobalBarrierManager<S>::run::{{closure}}
             at ./src/meta/src/barrier/mod.rs:279:25
   4: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/cb121987158d69bb894ba1bcc21dc45d1e0a488f/library/core/src/future/mod.rs:91:19
   5: risingwave_meta::barrier::GlobalBarrierManager<S>::start::{{closure}}::{{closure}}
             at ./src/meta/src/barrier/mod.rs:202:45

To Reproduce
First, we need to use https://github.com/singularity-data/risingwave-demo/tree/main/workload-generator to generate the streams.
create materialized source ad_click (
    bid_id bigint,
    click_timestamp timestamp
) with (
    'connector' = 'kafka',
    'kafka.topic' = 'ad_click',
    'kafka.brokers' = '<IP_ADDRESS>:29092',
    'kafka.scan.startup.mode' = 'earliest'
) row format json;

create materialized source ad_impression (
    bid_id bigint,
    ad_id bigint,
    impression_timestamp timestamp
) with (
    'connector' = 'kafka',
    'kafka.topic' = 'ad_impression',
    'kafka.brokers' = '<IP_ADDRESS>:29092',
    'kafka.scan.startup.mode' = 'earliest'
) row format json;

CREATE MATERIALIZED VIEW ad_impressions_5min AS
SELECT
    ad_id,
    COUNT(*) AS impressions_count,
    window_end
FROM
    TUMBLE(
        ad_impression,
        impression_timestamp,
        INTERVAL '1' MINUTE
    )
GROUP BY
    ad_id,
    window_end;

CREATE MATERIALIZED VIEW ad_clicks_5min AS
SELECT
    ai.ad_id,
    COUNT(*) AS clicks_count,
    ai.window_end as window_end
FROM
    TUMBLE(
        ad_click,
        click_timestamp,
        INTERVAL '1' MINUTE
    ) AS ac
    INNER JOIN TUMBLE(
        ad_impression,
        impression_timestamp,
        INTERVAL '1' MINUTE
    ) AS ai ON ai.bid_id = ac.bid_id
    AND ai.window_end = ac.window_end
GROUP BY
    ad_id,
    ai.window_end;

CREATE MATERIALIZED VIEW ad_ctr_5min AS
SELECT
    ac.ad_id AS ad_id,
    ac.clicks_count :: NUMERIC / ai.impressions_count AS ctr,
    ai.window_end AS window
FROM
    ad_impressions_5min AS ai
    join ad_clicks_5min AS ac ON ai.ad_id = ac.ad_id
    AND ai.window_end = ac.window_end;

Then we are going to build several materialized views: ad_ctr_5min will join ad_impressions_5min and ad_clicks_5min.
It will definitely fail on ad_ctr_5min due to the panic above.
If I run the join on top of ad_impressions_5min and ad_clicks_5min in batch mode the results will show successfully:
dev=> SELECT
dev->     ac.ad_id AS ad_id,
dev->     ac.clicks_count :: NUMERIC / ai.impressions_count AS ctr,
dev->     ai.window_end AS window
dev-> FROM
dev->     ad_impressions_5min AS ai
dev->     join ad_clicks_5min AS ac ON ai.ad_id = ac.ad_id
dev->     AND ai.window_end = ac.window_end;
 ad_id |              ctr               |       window
-------+--------------------------------+---------------------
     1 | 0.50                           | 2022-05-24 06:24:00
     2 | 1                              | 2022-05-24 06:25:00
     4 | 0.25                           | 2022-05-24 06:24:00
     5 | 1                              | 2022-05-24 06:24:00
     5 | 0.75                           | 2022-05-24 06:25:00
     6 | 0.6666666666666666666666666667 | 2022-05-24 06:24:00
     6 | 0.6666666666666666666666666667 | 2022-05-24 06:25:00
     7 | 0.50                           | 2022-05-24 06:24:00
     9 | 0.25                           | 2022-05-24 06:24:00

Expected behavior
A clear and concise description of what you expected to happen.
NO PANIC.
Additional context
Add any other context about the problem here.

Cc @BugenZhao . It seems like when creating ad_ctr_5min, barrier manager received some impossible finished epoch. I will try to reproduce it and fix it.

After some more investigation, the FinishCreateMviewNotifier notified twice in rearraged_chain. This is quite weird and seems impossible.

Will check deeper. 🤔

ad_ctr_5min plan as follows:
                                                                 QUERY PLAN
--------------------------------------------------------------------------------------------------------------------------------------------
 StreamMaterialize { columns: [ad_id, ctr, window, ad_id#1(hidden), window_end(hidden)], pk_columns: [ad_id#1, window, ad_id, window_end] }
   StreamProject { exprs: [$3, ($4::Decimal / $1), $2, $0, $5] }
     StreamHashJoin { type: Inner, predicate: $0 = $3 AND $2 = $5 }
       StreamTableScan { table: ad_impressions_5min, columns: [ad_id, impressions_count, window_end], pk_indices: [0, 2] }
       StreamTableScan { table: ad_clicks_5min, columns: [ad_id, clicks_count, window_end], pk_indices: [0, 2] }
(5 rows)

After further investigation, the chain executor is built twice in this mview with same actor id.
2022-05-24T09:19:09.020321Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>72, actor: 32, fragment: 11, node: “MergeExecutor”
2022-05-24T09:19:09.020358Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>09, actor: 32, fragment: 11, node: “BatchPlanNode”
2022-05-24T09:19:09.021187Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>10, actor: 32, fragment: 11, node: “ChainExecutor”
2022-05-24T09:19:09.021228Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>72, actor: 32, fragment: 11, node: “MergeExecutor”
2022-05-24T09:19:09.021256Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>07, actor: 32, fragment: 11, node: “BatchPlanNode”
2022-05-24T09:19:09.022018Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>08, actor: 32, fragment: 11, node: “ChainExecutor”
2022-05-24T09:19:09.022055Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>16, actor: 32, fragment: 11, node: “StreamHashJoin { type: Inner, predicate: $0 = $3 AND $2 = $5 }”
2022-05-24T09:19:09.022127Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>18, actor: 32, fragment: 11, node: “StreamProject { exprs: [$3, ($4::Decimal / $1), $2, $0, $5] }”
2022-05-24T09:19:09.022169Z  INFO risingwave_stream::task::stream_manager: create executor:<PHONE_NUMBER>19, actor: 32, fragment: 11, node: “StreamMaterialize { columns: [ad_id, ctr, window, ad_id#1(hidden), window_end(hidden)], pk_columns: [ad_id#1, window, ad_id, window_end] }”

The fragmenter seems work not correctly on StreamHashJoin, it should be split into three fragments, rather than the follow:


tf2_urdf: 0.1.0-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository tf2_urdf to 0.1.0-1:

upstream repository: https://github.com/standmit/tf2_urdf.git
release repository: https://github.com/standmit/tf2_urdf-release.git
distro file: melodic/distribution.yaml
bloom version: 0.9.3
previous version for package: null

tf2_urdf
* fix missing dependency
* create package
* Contributors: Andrey Stepanov

Close and reopen to retrigger actions.

I'm sorry for the long delay here; we've been pretty swamped with Foxy and Noetic releases.
Can you please add a LICENSE file with the contents of the BSD license?
@tfoote This package provides some useful functionality, though the name is a bit generic.  How do you feel about merging this package?

This follows the pattern of providing tf2 datatypes for x package we use so I think it's fine. Like we have tf2_eigen and tf2_kdl etc.
I asked for this to be released instead of added to the geometry2 repository to avoid dependency growth. https://github.com/ros/geometry2/pull/456
+1 for adding the LICENSE file.

Can you please add a LICENSE file with the contents of the BSD license?

OK, I will add a LICENSE file to upstream repository soon. But I'm not familiar enough  with bloom. What is the way to update release repository and this pull request? Or should I close this pull request and then create another one?

OK, I will add a LICENSE file to upstream repository soon. But I'm not familiar enough with bloom. @clalancette What is the way to update release repository and this pull request? Or should I close this pull request and then create another one?

The easiest thing to do is to add the LICENSE file, do a new source release, close this PR, and then do a new bloom-release.  That will open a new PR automatically.

New pull request: #24943


HTTP Metrics: Add verbs back and preserve static paths

Description
This PR addresses a part of the discussion initiated in issue #7719.
Currently, in low cardinality, Dapr metrics perform a gRPC-like conversion on the method label. Since Dapr is moving away from this conversion (as discussed here), we propose adding back the HTTP method to the metrics (GET, POST, PUT, etc.).
This change addresses one of the current issues with Dapr HTTP metrics: all HTTP calls are grouped into the same bucket. For instance, if my app has GET, POST, and PUT methods on the same resource, these are all exposed as InvokeService/myapp-id, making it difficult to differentiate between them.
OLD - 3 HTTP calls to GET/POST/PUT on the same resource would end all in the same bucket:
dapr_http_server_request_count{app_id="my-service",method="InvokeService/my-service",status="200",le="100"} 3

NEW - OLD - 3 HTTP calls to GET/POST/PUT on the same resource:
dapr_http_server_request_count{app_id="my-service",method="GET", path="", status="200",le="100"} 1
dapr_http_server_request_count{app_id="my-service",method="PUT", path="", status="200",le="100"} 1
dapr_http_server_request_count{app_id="my-service",method="POST", path="", status="200",le="100"} 1

With this update, we will reintroduce the method labels, allowing us to distinguish between different HTTP methods in the metrics while maintaining constrained cardinality in paths. The path keys are also reintroduced as empty strings. Although this solution is not perfect (as it does not distinguish between different paths), it represents a more natural iteration towards HTTP protocol metrics. Users can further refine this with path matching, as proposed here.
Additionally this PR preserves well-known dapr paths, I identified this initial list of static dapr paths:
"/dapr/config"
"/dapr/metrics"
"/dapr/subscribe"
"/healthz":

Issue reference
https://github.com/dapr/dapr/issues/7719
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Can you make this optional please, or offer an option to turn it off? For some users the increased memory usage isn't worth knowing the difference between GET/POST/PUT etc

Can you make this optional please, or offer an option to turn it off? For some users the increased memory usage isn't worth knowing the difference between GET/POST/PUT etc

For HTTP, having this information is super important. Maybe having a flag to disable HTTP metrics entirely if memory is the only factor a specific user cares about.

@nelson-parente lint is failing

For HTTP, having this information is super important.

it's fine if it's enabled by default, but adding an option to disable it shouldn't be too hard and is helpful to some users

I understand the concern about memory usage, but adding a configuration option to disable HTTP metrics might not be necessary. This change doesn't significantly increase memory usage because we have bounded HTTP methods and static paths, so memory shouldn't be an issue here.
For users concerned about memory, we already have the metrics.enable option available. It seems inconsistent to have only HTTP metrics be individually disabled while others remain initialized.
If we decide we really want this option, I'd suggest moving it to a different PR and applying it to all metrics we have (gRPC, HTTP, component, resiliency, and workflow).

I think it makes sense to have an option to toggle whether verbs are attached to metrics.
We must only accepts verbs from a well-known set, with any unrecognized verb being put in an UNKNOWN bucket. As it stands it looks like we currently have unbound cardinality from the method label.

I think it makes sense to have an option to toggle whether verbs are attached to metrics.
We must only accepts verbs from a well-known set, with any unrecognized verb being put in an UNKNOWN bucket. As it stands it looks like we currently have unbound cardinality from the method label.

Thank you for the feedback. I will add the check for valid HTTP verbs, as I expected requests with invalid verbs to be rejected early on, but testing locally shows they are currently accepted.
Regarding the configuration option to toggle verbs, I still believe that including the verb always makes sense. Without it, metrics like dapr_http_server_request_count{app_id="my-service", path="", status="200",le="100"} provide limited value to the user, as they lack essential HTTP context.

Regarding the configuration option to toggle verbs, I still believe that including the verb always makes sense.

For many users, for sure. When the low-cardinality metrics feature was implemented, we had user requirements to not have pivots for each HTTP verb. If you could add a config flag (even if off by default) that would be very important

Regarding the configuration option to toggle verbs, I still believe that including the verb always makes sense.

For many users, for sure. When the low-cardinality metrics feature was implemented, we had user requirements to not have pivots for each HTTP verb. If you could add a config flag (even if off by default) that would be very important

@nelson-parente Please add this config option. I accept this is valid user feedback

I will add the config 🙂
Should this config be specific to low cardinality, or will it also affect high cardinality if enabled?

Added the new config, once I have positive feedback on this I will update my other docs PR :)

Tests were failing after this was merged, fix 👍

@holopin-bot @nelson-parente Thank you Nelson!


Great except the lag

Hello!
This is by far the best drawer I've found when it comes to looks and features, I have one problem though. When document start to increase in size, it gets very laggy. From my understanding it's because of re-rendering issues and no lazyload, if that was the case, why was it designed like that? Is there a quickfix or something in the pipeline?

See https://github.com/excalidraw/excalidraw/issues/7341


az postgres flexible-server create InternalServerError

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az postgres flexible-server create
Errors:
(InternalServerError) An unexpected error occured while processing the request. Tracking ID: '1ee513e2-8ba7-40d3-909c-409e7deb4551'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az postgres flexible-server create --resource-group {} --name {} --location {} --admin-user {} --admin-password {} --sku-name {} --tier {} --public-access {} --storage-size {} --backup-retention {} --version {}

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.6.8
Installer: MSI

azure-cli 2.22.0

Additional Context

route to service team

Please upgrade to latest version of az cli 2.40.0. Also if you face this issue again, reopen the issue


Create dataset loader for Thai Constitution Dataset

Dataloader name: thai_constitution/thai_constitution.py
DataCatalogue: http://seacrowd.github.io/seacrowd-catalogue/card.html?thai_constitution

Dataset
thai_constitution

Description
A collection of snippets from the Thai constitution from 1932 and retrieved from the Thai Office of the Council of State (http://www.krisdika.go.th/).

Subsets
-

Languages
tha

License
Apache license 2.0 (apache-2.0)

Homepage
https://github.com/PyThaiNLP/Thai-constitution-corpus/tree/master/data

HF URL
-

Paper URL
https://github.com/PyThaiNLP/Thai-constitution-corpus/tree/master/data

#self-assign
Curious what schema/task would this falls into? Self-supervised pretraining?

#self-assign

Currently drafting a PR :)


Can you please give several explanations?

Hi! Thank you for this solution! It is really awesome. Can you please explain several things:

what is the purpose in this case to use Webpack's "multi-main entry" ?
before running development, should I start all of watch:src, watch:dist and dev commands? If so , can I combine them as one command?
which files typically should be excluded in watched directory?
if I do not use typescript is that almost all the same, except of I ignore types in method definitions like here: function getEntry(name: string)  ?

With "multi-main entry", you don't need to place the import code in scripts, which means it's decoupled for scripts.
Actually, "dev": "concurrently yarn:watch:*" script will run all the watch:* script concurrently.
If you don't know which files should be excluded, you don't need to specify it.
Yes, just remove the types.


bugfix: updated Makefile to use langflow run

bugfix for #876

The lint error was fixed at https://github.com/logspace-ai/langflow/pull/886


fix typo

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:polonskiy/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Thanks! can you sign your commit with the instructions @GordonTheTurtle gave above?

@thaJeztah done

Awesome, thanks for the quick fix!
LGTM


"weed repair": a tool to ensure all volume replica are not missing and in sync

Hm I did that in PHP (without taking tombstones into account as I didn't see a way to read them) but I don't know if this will help you. And my solution is quite tightly integrated with our own framework. But maybe it could inspire you.

@brstgt It'll be good to see your code or pseudo code, and we can see how to adjust it or start from scratch.

I created a temporary repo for this https://github.com/brstgt/seaweed_repair_snippet
The code is not executable standalone. It is part of a framework. But it should outline what it does to repair/sync volumes.
Repair script:
https://github.com/brstgt/seaweed_repair_snippet/blob/master/bin/seaweed/repair.php
Uses mainly this class:
https://github.com/brstgt/seaweed_repair_snippet/blob/master/Service/Model/Seaweed/Admin/Repair.php

@chrislusf
Not a single reply on my post? Are you maintaining seaweed at all any more?

do not understand the php logic.

You could have asked. How can I help you then? What exactly is unclear?

Hi,@brstgt  I'm poor at php. But if u can explain your program maybe I can develop a standalone python script to do this repair job

From my point of view, a proper repair has to be handled by seaweed directly. For a solid repair you need to be able to read all the information from the volumes. You could still provide an interface to export volumes with more detailed information but it would still be less performant than doing it directly in seaweed.

@chrislusf Could you provide some insight into how you envision this to be implemented? I think we'll take a stab at implementing something for repairs, but as @brstgt mentioned, this should be handled by seaweed directly.

There could be 2 steps:

ensure the number of replicas are correct. If missing one replica, assign one volume server according to the replica setting.
for missing replicas, copy from the largest existing copy.

IMHO this is a little bit more complex if you do it correctly! It's not only about volume-count it's also about comparing and repairing multiple volumes and all files contained in them. You can't simply copy over the "largest" copy. You have to consider timestamps and also tomb-stones.

@chrislusf we made a script that will tell us about volume differences:
$ ./seaweed_volume_differ.sh
344,122265,"<IP_ADDRESS>:8080"
344,122266,"<IP_ADDRESS>:8080"
344,122266,"<IP_ADDRESS>:8080"

We've also seen from the logfile that the replication failed on one occasion:
weed[15045]: I0201 15:45:59 15045 upload_content.go:89] failing to upload to http://<IP_ADDRESS>:8080/344,025aebae94365551?ts=1517496359&type=replicate Post http://<IP_ADDRESS>:8080/344,025aebae94365551?ts=1517496359&type=replicate: read tcp <IP_ADDRESS>:39254-><IP_ADDRESS>:8080: read: connection reset by peer

So in this case we'd want to replicate the one missing file from <IP_ADDRESS> from either <IP_ADDRESS> or <IP_ADDRESS>. Is there a way I can retrigger the replicate call as seen in the logfile?
And if I didnt have the log file, how would I find out which file to replicate?

Can somebody tell me if I understand this correctly: If I have a SeaweedFS cluster with replication configured, and the data on one of my volume servers gets destroyed ( like a failed disk or something like that ), then I have no way of making sure that that data is re-replicated so that the proper number of replicas exists?
I was considering using SeaweedFS in production, but this is a pretty major deal. Having the replication there doesn't help me much if I can't actually be sure that volumes have the correct number of replicas. I could loose one drive, replace it, and not loose data the first time it happens, but if the other drive fails after that and I only had two replicas configured, then my data would be gone because the data wasn't re-replicated when the broken drive was replaced.

Currently the set of replicated volumes with some of them broken will become readonly, but no data is lost.

But if they are not re-replicated, and another drive fails, then that data will be lost, because there is now less replicas than initially specified.

I've got a partner with an enterprise use-case for a clustered filesystem for Docker Swarm and so far this looks like the only deal breaker. As far as I've seen, everything else that we need is taken care of. SeaweedFS is brilliantly simple and I've only had to spend two days on it to get my Docker volume plugin migrated and setup a Dockerized highly available cluster to test it with. It is an ideal solution beating even LizardFS in simplicity and ease of use, which is amazing.
If there is any way I could help with this, I might be able to carve out some time for it, but I'm probably going to need some guidance. Not sure if this is the kind of thing somebody who doesn't have an in-depth knowledge of the system can help with.

Thanks! I plan to work on it in the coming week.
Maybe you can help on https://github.com/chrislusf/seaweedfs/issues/891

fixed in https://github.com/chrislusf/seaweedfs/commit/6b70b3610530d9b3637fd4179a0f2cecc5541fdd

Awesome! Thank you lots! I can't wait to try it!


feat: new cli for batch jobs

This targets #604 by implementing two main new features

A new BatchJob class which allows users to create .jsonl files which are compatible with OpenAI's new batch job function
a batch cli command that allows users to see all outstanding jobs, create a new batch job and cancel an existing batch jobs

:rocket:
This description was created by Ellipsis for commit db0ba2880f8a6f1eff96ff27cc27dca75e7dd191

Summary:
This PR introduces a new BatchJob class and CLI commands for managing batch jobs with OpenAI's API.
Key points:

Added BatchJob class in instructor/batch.py for creating .jsonl files for batch jobs.
Added CLI commands in instructor/cli/batch.py to list, create, and cancel batch jobs.
Integrated new batch job commands into the main CLI in instructor/cli/cli.py.

Generated with :heart: by ellipsis.dev

please add a lil recording and doc pages before we're ready to merge

This is a video recording of the cli in action where we use a generated output.jsonl file in order to create a batch job, cancel the same batch job and also list all existing batch jobs.
https://github.com/jxnl/instructor/assets/45760326/b56d4714-bea4-4a7d-bb5d-f673f5dc2550
Also added a docs page which shows a new snippet on how to generate these .jsonl files

When can we expect the next release to include this?
Excited to use this batch CLI command

@slavakurilyak we just released v1.3.4 which has it!


Result incomplete:Insert failed due to LRU cache being full.;The database will be put in read-only mode

VERISON
OrangoDB 3.10.1
The server is runing well for a long time  until it got an error recentenly.

And we also found the relevant issue https://github.com/arangodb/arangodb/issues/16127
We set enforce-block-cache-size-limit = false in the starup.cfg,but it takes no effect.
We can't insert any record to any table even though we retart the OrangoDB server.
Please help to check this problem,thanks ~

The error happens when there is no more capacity in the RocksDB block cache, and no other data in the block cache shard can be freed.
Can you try setting the startup option --rocksdb.enforce-block-cache-size-limit to false? That should help avoid this particular error.
Btw, version 3.10.1 is more than a year old, and 3.10.2 changed the value of the startup option to false. So even better than changing the value of the startup option and stay on 3.10.1 would be to upgrade to the newest version of 3.10, or even to 3.11.

We modify the arangod.conf,add line as

Are you sure that the config file is being used, i.e. that the right config file was modified?
Because the option is supposed to work just fine, and if it doesn't, it is likely that it has been put into a config file that is not being used.

OK，this time, we set the enforce-block-cache-size-limit to false and we also drop the table that cause the error, and restart again, the error disappeared. Thanks~


Implemented suggested fix for issue #14

As far as I understand this should make it foolproof.

closing as it was fixed after all


DailyTotal component

Create a rolling daily total component to show the vendor the total monetary value of the transactions made on that day.
Input props

value: the monetary total of transactions made on that day

Sub-tasks

[x] Base component outputting the total
[x] Container to calculate the total

Initial draft has been completed, however this still needs a formal design and hooking up to the data

Matt to look into the UX/Design

An initial solution has been designed and added to the Invision prototype https://heathwallace.invisionapp.com/share/ENFXAUAMSQY#/screens/282595069

The critical intentions of this ticket has been completed, I'll close this ticket and raise a a separate ticket for the updated design.

New ticket for design implementation has been opened here: #97


OnMove trait is much more general than Pin

We use Pin to support self referencing type.
But what if we have a OnMove trait which define a method fn on_move(&mut self). Then when we move an object, on_move is called automatically.
OnMove trait is just like Drop trait, it's a part of the lifecycle of an object.
To make the name OnMove and Drop be the same pattern, we can name it Move.
Just an idea. If it's wrong, closed it.

Please read previous discussions on Pin. Not having move-constructor/move-assignment operator is a huge advantage of rust.

You can search in internals.rust-lang.org, for example:
https://internals.rust-lang.org/t/idea-on-movable-self-referential-structs/6694
Pin related issues have been discussed for more than a year, I believe all the possibilities have been explored. Repeating deprecated ideas does not help.

In this case I think the question is reasonable, yet extremely difficult to get a straight ansewr to just from searching past discussions. So here's my high-level summary of why I agree with going the Pin route:

Move constructors in general don't provide enough benefits to offset their cost. In particular, since Rust has had move semantics as the default from day one, the vast majority of C++'s motivation for adding move constructors simply doesn't apply to Rust.

Self-referencing types are often proposed as a Rust-specific motivation for move constructors, but this is actually a red herring as jpernst explains: https://internals.rust-lang.org/t/idea-on-movable-self-referential-structs/6694/6?u=ixrec

There's no way to make move constructors work without a new implicit trait bound. As far as I know, this is true of every proposed variation we've seen, including your OnMove. Implicit trait bounds run into all of the problems discussed here: https://github.com/rust-lang/rfcs/issues/2255 But to save you the time reading all of that and its many additional links...

Adding a new implicit trait bound is (surprise!) backwards incompatible. And this is not the kind of backwards incompatibility that editions let us get away with. So it turns out that was never an option anyway.

Solving this via a trait bound makes borrowing across yield points into "everyone's problem", i.e. you have to explicitly make it work or say you don't want to make it work, even when that feature is completely irrelevant to the type you're trying to write. So even if this was pre-Rust 1.0, we'd probably still want Pin because that localizes the solution to code that actually needs to care about the problem.

Also, there’s a lot of unsafe code out there that implements moves as a shallow byte copy. For example, call pushing to a Vec that is at capacity calls realloc. Declaring such code incorrect because it fails to call on_move manually (which did not exist at the time the code was written) is too big of a breaking change, even for editions.


Coverage for 'gcloud._apitools.http_wrapper'

Uses #1193 as a base.

@dhermes rebased after merge of #1193.

LGTM


Convert Halcyon projects to .NET Core

Convert the main Halcyon project to .NET Core to better support the Halcyon.MVC project. It still need to support projects targeting .NET 4.5  and above.

Completed in #27


Unable to read response's body contents

Commit https://github.com/guzzle/psr7/commit/45054d91c290de494549511e470ef5853f726a50#diff-f89246dce7e387482b2c6c584a5e7e9dR97 have introduced a bug by comparing $body with empty string.
I did not dig too deeply to find out the real reason of wrong behavior, but I guess it is caused by implicit calling of GuzzleHttp\Psr7\Stream::__toString() in order to cast object to string to make a comparison.
How to reproduce
        $client = new \GuzzleHttp\Client(['base_uri' => 'https://google.com.ua/']);
        $response = $client->request('GET');
        $html = $response->getBody()->getContents();

What is expected
$html contains a response HTML
What do we have instead
$html is an empty string
Patch?
Rolling back that line to if ($body !== null) fixes the problem. Not sure whether it is a proper fix.
Environment
PHP 5.6.20
Ubuntu 16.04
guzzle/psr7@dev-master

Merging commit: https://github.com/guzzle/psr7/commit/28d8dbf50cca47882af6bab1f916521b8db92c8c

Same issue here

Yes, this appears to be a regression that will need to be reverted.

I'm fixing this.

:+1:

See #96

Was looking for a solution all the day and found this issue ;x
I rolled back to 1.3. and now i wait for the update ;)

I'm kinda surprised that so many developers seem to be relying on an unreleased, unstable version.


Bug/enhancement - Allow url entries without "."s in the name

The App does not accept a URL such as 'http://localhost:6419/' (which I use with https://github.com/joeyespo/grip).  Apparently the URL must contain at least one '.'.  It is not clear what the App is unhappy with, or how to fix it.
A workaround (which I'm not sure why it works of if it is robust) is 'http://localhost.localhost:6419/'.
I recall that I had this issue with the API as well.
Client app information
App Platform: Chrome

This will be resolved in v1.4.0. In the meantime you can create a local hostname to get around this restriction.

Thanks Rich.  Also, for local cameras the URL is a rtsp://.  Please consider allowing all sorts of URLs.

Fixed in 6afd964.


Make it easier to write value transformers

Value transformers are critical to the power of kustomize and kpt, which really differentiate the approaches from monolithic configuration generators. We're going to need to build a lot more of them, and we need to make it as easy as possible to write such transformers, including guides (documentation, examples, videos, etc.), so that users don't fall back to less Config-as-Data-friendly approaches.
We’ve implemented several approaches to value propagation.
kustomize:

Kustomize transformer plugins (guide, example)
Kustomize vars (templates, more or less)
Kustomize replacement transformer (example use)

kpt:
4. Pre-1.0 kpt setters and substitutions
5. Kpt 1.0 setters
6. Catalog specific-purpose transformers, such as set-namespace
The appealing aspect of (1) is that configuration authors and consumers only need to specify the values to propagate, not where to propagate them to. Where they need to be propagated to is consistent for a given type of value and a given resource type, or set of resource types for horizontal transforms.
Transforms that apply to many resource types  or all types need to be written in a different manner than those that apply to one or two specific types. Some transformers are a mix of the two styles.
Perhaps we could even make a declarative value propagator function, like a more powerful replacement transformer with configuration that's reusable across packages.

Replicas example: plugin, filter, fields
Images example: plugin, filter, fields, example (it’s a problem that the kinds are not specified)

The transformer functions require understanding the schemas of applicable resource types, at least the field paths of interest. Eventually we should ensure that types of interest publish sufficient information attached to the OpenAPI schemas and that kpt can read it, or that there's a standard way to patch OpenAPI schemas with such information, but for now we should use an approach similar to kustomize, and enumerate relevant fields in their varying representations, and also support user-specified paths (again, in a way that's reusable across packages).
We will eventually want a better mechanism for defining value types and mapping resource attributes (by value type and by resource type) to them so that users can easily add support for additional resource types (skaffold image replacement example, ClusterAPI example). As one example, kustomize’s object reference and label selector transformations don’t work for arbitrary resource types out of the box because it only has data for built-in Kubernetes types.
To simplify targeting/filtering expressions, we should explore leveraging the package structure (nested subpackages), but we’ll need to look more at example packages to validate that. Hierarchical dictionaries of facts are common in configuration systems: hiera, facter.
In addition to performing the replacements, we’ll also want to be able to identify replacement locations, such as for documentation and introspection.
Some example functions that apply to non-built-in types we could try to write include #2562, #2658, #2677, #1400.

I think the problem with even the simplest SDK is that I have to build the image and publish it.  I would advocate that for scenarios like that and internal functions the easiest thing to do is to build in Starlark and run it without a container.  kpt simple transformer can not be much harder than bash + sed.
Templating of Helm values.yaml does not make sense because you can just put the right value in the values.yaml file and update the template to put it in the right places.  It's not much more difficult than sed.

I think the problem with even the simplest SDK is that I have to build the image and publish it. I would advocate that for scenarios like that and internal functions the easiest thing to do is to build in Starlark and run it without a container.

@mikebz That's right. We want users to use starlark for simple scenarios and go SDK for more complicated cases. Though we have a pile of KRM function tasks and I don't think starlark is more mature than go SDK to recommend. Another reason is that the above use case is more like a set-image transformation, which assume might need to import some logic from the set-image, which is in Go.

kpt simple transformer can not be much harder than bash + sed.
I like this description. It can be the standards to evaluate our starlark SDK.

One original motivation for templating values.yaml was because the files can get huge. The ability to merge multiple values.yaml files mitigated that issue.
However, if a value is in an environment variable, then automatically getting it into values.yaml, such as in a CI/CD pipeline, has the same challenge we're discussing here with kpt.
I understand the Starlark SDK is less mature.
kpt still supports exec functions, doesn't it? So I think even with Go a container isn't required.
We could also make it easy to build CLIs that source, run functions, then sink, without needing to invoke the kpt CLI.
But, yes, yq or envsubst could work in this case, especially if the configuration could live outside the Kptfile.
That reminds me that we could use a ConfigMap generator: #3119.

I think it's worth sharing the recipe of propagating values from environment variable to any KRM fields. For example, this use-case can be addressed by invoking search-replace function imperatively. I am assuming that substituting repo name in the deployment spec needs to be done once.
Here are the steps involved:
Assuming following Kptfile in the app-base package:
# Kptfile in app-base package
apiVersion: kpt.dev/v1
kind: Kptfile
metadata:
  name: app-base
  annotations:
    config.kubernetes.io/local-config: "true"
info:
  description: kpt package for provisioning a deployment
pipeline:
  mutators:
  - image: gcr.io/kpt-fn/set-image:v0.1.1
    configMap:
      name: bla/a
      newName: newblabla/a
      newTag: latest
  - image: gcr.io/kpt-fn/set-image:v0.1.1
    configMap:
      name: bla/b
      newName: newblabla/b
      newTag: latest

Assume thatapp-base also contains deployment.yaml:
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: frontend
  name: frontend
spec:
  replicas: 1
  selector:
    matchLabels:
      app: frontend
  strategy: {}
  template:
    metadata:
      labels:
        app: frontend
    spec:
      containers:
      - name: frontend
        image: bla/a
      - name: backend
        image: bla/b

Let's create deployable instance from the app-base blueprint:
$ kpt pkg get <app-base> --for-deployment

# Assuming REPO_NAME environment variable contains the name `app1`
$ kpt fn eval -i search-replace:v0.2.0 -- by-value="newblabla/a" put-value="$REPO_NAME/a"
[RUNNING] "gcr.io/kpt-fn/search-replace:v0.2.0"
[PASS] "gcr.io/kpt-fn/search-replace:v0.2.0" in 1.1s
  Results:
    [info] pipeline.mutators[0].configMap.newName: Mutated field value to "app1/a"

$ kpt fn eval -i search-replace:v0.2.0 -- by-value="newblabla/b" put-value="$REPO_NAME/b"
[RUNNING] "gcr.io/kpt-fn/search-replace:v0.2.0"
[PASS] "gcr.io/kpt-fn/search-replace:v0.2.0" in 900ms
  Results:
    [info] pipeline.mutators[1].configMap.newName: Mutated field value to "app1/b"

# Now let's run render on it.
$ kpt fn render
Package "app-base":
[RUNNING] "gcr.io/kpt-fn/set-image:v0.1.1"
[PASS] "gcr.io/kpt-fn/set-image:v0.1.1" in 900ms
  Results:
    [info] apps/v1/Deployment/frontend spec.template.spec.containers.image: set image from bla/a to app1/a:latest
[RUNNING] "gcr.io/kpt-fn/set-image:v0.1.1"
[PASS] "gcr.io/kpt-fn/set-image:v0.1.1" in 700ms
  Results:
    [info] apps/v1/Deployment/frontend spec.template.spec.containers.image: set image from bla/b to app1/b:latest

Successfully executed 2 function(s) in 1 package(s).

I just realized set-image isn't very useful for declarative workflow because now images field have new values, kpt fn render re-runs won't do anything.


Polygon render missing in 2D view

my polygon render missing when i change view to 2D and drag the map

Thanks for the report @qqqys. Would you be able to provide a sandcastle example with code to reproduce the issue?
This may be a manifestation of https://github.com/CesiumGS/cesium/issues/4871 or another known 2D issue.

https://sandcastle.cesium.com/#c=bZBNT8MwDIb/itVTJ5WUCXaBrgJt3JBAIHGhHLzW2yLSZHLSTgXtv5O2m1aN5hQ/fh/nIzfaOqgl7YlhDpr2sCArq1J8dCzMgryrF0Y7lJo4Cyb3ma6Rgal4NarZGO3NfoQg7aSTZAUWRfibafBrdwzdwRG0ayuJkfNt4/HxxAWy8zvUN2LNplzShonsIzM24efZBLiO4HYWDcl0Ns6uLlhHzuBrMuiW6IglqsGFjDIs3p6WfeiQ6UP79iAKEusaRelJfpDlzrCDilUoROyo3Ck/zcarKv8mJ3JrW7GNJvFQTQpZgyzmI78MuUJrfWddKfUufygL0iT2+X+qMlhIvXmpiRU2bWw7TZ97KIRIYl+Om84YtUK+mPwH

if i drag the 2D Map the polygon will change


'download' instead of 'upload' in Readme

In the Readme:
Instead of
useReadFile: (default: false)
If set to true, then files which the client uploads are slurped using 'readFile'.

shouldn't it be:
useReadFile: (default: false)
If set to true, then files which the client downloads are slurped using 'readFile'.

?

Thanks! I've updated the readme accordingly.


Cranelift: error "unimplemented relocation addend Relocation" on MacOS on aarch64

Thanks for filing an issue! Please fill out the TODOs below.
.clif Test Case
function u0:0() -> i64 apple_aarch64 {
    sig0 = (i64) -> i64 apple_aarch64
    sig1 = (i64) -> i64 apple_aarch64
    fn0 = u0:1 sig0
    fn1 = u0:2 sig1

block0:
    v0 = iconst.i64 13
    v1 = call fn1(v0)
    v2 = call fn0(v1)
    v3 = iconst.i64 0
    return v3
}

function u0:1(i64) -> i64 apple_aarch64 {
    sig0 = (i64) -> i64 apple_aarch64
    sig1 = (i64) -> i64 apple_aarch64
    fn0 = colocated u0:2 sig0
    fn1 = colocated u0:2 sig1

block0(v0: i64):
    v1 = iconst.i64 0
    v2 = icmp eq v0, v1
    brz v2, block2
    jump block1

block1:
    v3 = iconst.i64 0
    return v3

block2:
    v4 = iconst.i64 1
    v5 = icmp.i64 eq v0, v4
    brz v5, block4
    jump block3

block3:
    v6 = iconst.i64 1
    return v6

block4:
    v7 = iconst.i64 1
    v8 = isub.i64 v0, v7
    v9 = call fn0(v8)
    v10 = iconst.i64 2
    v11 = isub.i64 v0, v10
    v12 = call fn1(v11)
    v13 = iadd v9, v12
    return v13
}

Steps to Reproduce

Run on an Apple M1 chip

Expected Results

The program should compile

Actual Results
The program paniced:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error("unimplemented relocation addend Relocation { offset: 104, size: 26, kind: Relative, encoding: AArch64Call, symbol: SymbolId(3), addend: -4 }")', <some path>/.cargo/registry/src/github.com-1ecc6299db9ec823/cranelift-object-0.86.1/src/backend.rs:500:22

Versions and Environment
Cranelift version or commit: 0.86.1
Operating system: MacOS
Architecture: M1
Extra Info
This works for me on aarch64-unknown-gnu (see https://cirrus-ci.com/task/6079482023903232 - it runs a lot of additional things, but near the bottom of the "test" task it compiles the Fibonacci function fine), but not aarch64-apple-darwin. It also works on x86_64-apple-darwin.

Thanks for the report. Did this CLIF come from Wasmtime or some other frontend? (I ask because we try to support Wasmtime's use of Cranelift on aarch64-apple-darwin but the use of Cranelift with other frontends is much less well-tested. That doesn't mean we don't want to support it, I'm just trying to judge the severity.) It sounds like we need to implement another relocation case here. If you're willing to dig into it further, I'd be happy to review a PR.

I think this might already be fixed upstream in https://github.com/gimli-rs/object/pull/465, so it might be a case of just updating the object crate whenever they do their next release.

👋 Hey,
Would you be able to test this code using PR #5434? It includes the updated version of object, and I suspect it might fix your issue.


Move away old .venv directory away during install

To ensure a clean environment at installation time, the installer will now detect whether a previous .venv exists in the install location, and move it to .venv-backup before creating a fresh .venv. I'm suspicious that the current behavior of reusing the .venv is causing some of the weird problems users are experiencing.

Any previous .venv-backup is deleted.

User is informed of process.

This sounds a bit weird to me, why should a pip install --upgrade create issues 🤔

I agree with @mauwii - reinstalling over an existing .venv should usually be safe and reliable. Is this aiming to fix the issue where torch was previously installed without GPU support on Windows? If so, we could add a --reinstall flag to the install scripts, which would in turn pass  --upgrade --force-reinstall[1] to the pip install torch calls.

This was motivated by the people who manage to get xformers installed but the non-CUDA version of torch and then have lots of xformers errors. If adding --force-reinstall will fix this, then by all means let's implement it.

Obsoleted by #2532


compressed exif/xmp is not yet implemented

At the file format level, we have defined brotli-compressed boxes (brob), but this hasn't been implemented yet.

Does this closes the issue?
https://github.com/libjxl/libjxl/pull/902

Once https://github.com/libjxl/libjxl/pull/1350 merges, it should be fine, except cjxl_ng still needs to be wired up to preserve exif/xmp (compressed or uncompressed is less important, but it currently silently strips it), and probably djxl_ng is also not looking for metadata to add when decoding to png.
But as far as this issue is concerned, I think it can be closed.

Btw, I don't understand the need for the 4 extra (zero?) bytes prepended to the Exif buffer here? Usually both APP1 payload and any TIFF raw data just starts w/ "II"/"MM", I don't understand where this "tiff offset" comes from?

This is how it is specified in the ISOBMF Exif box, so we do it in the same way. I assume they defined it that way to allow people to put some arbitrary extra stuff in the Exif box, and the "tiff offset" would then tell you where the actual Exif data starts.

Thanks... I guess the idea was to perhaps try to record the original offset of the pre-existing Exif and/or Makernote IFDs in case they use original TIFF container absolute addresses instead of relative ones...
Can you please share a link, I can't find a spec for this Exif box anywhere (i.e. the only publicly available version  does not mention Exif it at all...)?

Thanks. I guess the spec is the spec if you decided to follow JPEG XS/HEIF.
However, I still don't get their rationale given the below, but I guess that's out of scope here, and I don't expect further clarification. Sorry for taking your time.

exif_tiff_header_offset is an offset in bytes from the first byte of exif_payload to the first byte of the TIFF Header of the Exif metadata, as specified in JEITA CP-3451B.

No mention of any such offset in the latest JEITA CP-3451E (Exif 2.32) spec - the payload always starts w/ the TIFF header AFAICT.

(e.g. exif_payload is formatted as specified for the DCF thumbnail file in JEITA CP-3461B)

Again, no mention of any such offset in JEITA CP-3461B either, the payload is as specified in JEITA CP-3451E previously, i.e. always starts w/ the TIFF header...

exif_payload is a variable sized array of bytes holding the Exif compliant metadata to be parsed by the reader. This is compliant with JEITA CP-3451B or JEITA CP-3461B and shall have as part of it a TIFF Header with referenced Image File Directories (IFDs). There may be additional bytes before or after this Exif data...

It's compliant in a way that is contains a valid Exif payload somewhere (i.e. neither JEITA CP-3451E nor JEITA CP-3461B mention any offsets to it), but the before/after part seems completely arbitrary/unnecessary...

Yeah I'm also not quite sure what the rationale is, but we decided to follow what others already did instead of defining our own 'Exif' box (which would need to have a different name then if it is defined in a different way).
I can only assume there might be use cases where besides the Exif itself, you also want to preserve extra stuff that came before or after the Exif data itself. I don't know what those use cases are. Perhaps it's something that they anticipated to be useful for something but then it turned out to be not useful. In any case, these four 'wasted' zero bytes didn't seem to be worth haggling about, especially since we can put an Exif box inside a brob box which will probably deal quite well with such zero bytes.

Yeah, originally we had an exif box (no capital letter) which was just an exif blob, but then I think some Japanese members of JPEG said we should call it Exif and use the same definition that was already used in JPEG XS and HEIF, so we did that :)

Once #1350 merges, it should be fine, except cjxl_ng still needs to be wired up to preserve exif/xmp (compressed or uncompressed is less important, but it currently silently strips it), and probably djxl_ng is also not looking for metadata to add when decoding to png. But as far as this issue is concerned, I think it can be closed.

Let's close it then...


DNS: Debug new hashFile failing

Conclusion is that recent PW roll caused the issue, and we will need another roll after https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/177530 lands


Nearest populated city

The O&M dataset has a bunch of weird things in the data, and the "Nearest Populated Center" column has text that aren't cities. These need to be filtered out or replaced in src/data_management/oandm.py
Here is an example of an error:
https://pipeline-profiles.herokuapp.com/dist/en/oil-and-liquids/trans_northern_en.html
as per the attached document ON, Oakville ON, Various .

Fixed in b717ea1


Modify fullscreen button styles

Presentation button now displays at 1024 and under.

Hey @Kunamatata; thanks again for this PR! Sorry for the huge delay... This is now merged and part of the upcoming release. Cheers!


[SUGGESTION] Option to disable/enable view profile button.

Title.

Thanks for the contribution ❤with #16


Add browser tests

Testing
With the same method used in meilisearch-js we should add a very simple test that tries out the search bar in doc-searchbar.js
How
As mvp we should add at least one test that does the following

Go the served webpage and check if it loads correctly
Using a library like puppeteer we should manipulate the DOM the following way.

Focus on the input
Change its value to a given search query, by mimicking typing behavior
Check for a dynamically created DOM element containing search results
Ensure this DOM element is not empty

Why
With these tests we check for two possible problems:

Testing front-end webpage still works correctly, thus confirming that any fail will not come from the test itself
Testing that DocSearchBar still works correctly when using a remote dataset that follows its requirements

Deprecated in favour of #339


Add support for copying state of final Collection and Map

And mark Properties field as final

What problem is this solving?

What problem is this solving?

We can make them final for immutability.
private final Properties dataSourceProperties = new Properties();

This doesn't protect anything real. It protects the reference but the properties themselves are still mutable.

This doesn't protect anything real. It protects the reference but the properties themselves are still mutable.

Yes, just for improving coding style, feel free to close it if you think it's not worthy.


Is there a demo?

Hello, is there a live demo of this working? Someone I know was going to use this but they said the video quality was not good.  I wonder if it might have been something they were doing so I would like to see someone else's implementation of this.

For jsmpeg quality demos, head over here:
https://github.com/phoboslab/jsmpeg . Notably:
http://phoboslab.org/files/jsmpeg/
Unfortunately there isn't a demo of this particular library and there's not
a lot of time on my hands right now to put one together.
Quality will largely depend on the compression rate you use in ffmpeg for
compressing the video. Feel free to fork and experiment.
On Sat, Jan 30, 2016 at 7:51 AM, kmax1940<EMAIL_ADDRESS>wrote:

Hello, is there a live demo of this working? Someone I know was going to
use this but they said the video quality was not good I wonder if it might
have been something they were doing so I would like to see someone else's
implementation of this
—
Reply to this email directly or view it on GitHub
https://github.com/kyriesent/node-rtsp-stream/issues/3.

--
What good is it if a man gains the entire world, yet forfeits his soul?


Brownie Installation: symbol not found in flat namespace

After have followed the guide to install brownie (brownie installation)
Even if everything seems to work fine, when I call
brownie --version
I got the following error:
ImportError: dlopen(/Users/edoardo/.local/pipx/venvs/eth-brownie/lib/python3.10/site-packages/cytoolz/functoolz.cpython-310-darwin.so, 0x0002): symbol not found in flat namespace '__PyGen_Send'
Someone can help ?
I'm on MacOS Monterey 12.0.1
Thanks a lot!

I have solved that installing pipx not in the terminal of visualstudio code where I had activated a conda virtualenv.
I leave the issue in case someone has the same problem !


Licensing

I've been playing around to see whether the licensing issue really is an issue.
What I've tried:

Played with both your docker image and thehomerepot one.
Tried deleting the container, and recreating it from the docker-compose (via portainer)
Tried starting with version 4.2 in the docker-image config of the docker-compose file. And then updating it to 'latest'. (via portainer)

To test if the license would break, I would activate a trial license and note down the HWID.
And then verify if the HWID changed or the trial license got deactivated.
Which never happened ... everything kept working perfect.
So what WILL make the nxwitness in docker setup make things go bad?
I don't want to have any issues with licences.
Please note, I do setup a fixed mac-address in docker-compose:
version: "3"

services:
  nx-witness:
    container_name: nx-witness
    image: 'thehomerepot/nxwitness:latest'
    restart: unless-stopped
    environment:
      TZ: "Europe/Brussels"
    volumes:
      - /opt/networkoptix/config:/config
      - /opt/networkoptix/recordings:/archive
    mac_address: "AA:BB:CC:DD:EE:FF" # something real ...
    ports:
      - "7001:7001"

I am 99% sure that mac_address does not take effect unless you create custom networks, and will not have an effect on host networking mode.
Recreating the container on the same hardware does not really change the hardware, look at the logs where the hardware id is reported, I'd assume is stays the same.
To experiment move the container to a different physical server, and / or create a macvlan network with a verified different MAC address.


Markdown inside HTML doesn't parse

When there is markdown inside of html it doesn't seem to parse.
For example:

This is an **awesome** link to another site: [Internal to this website :)](/#/foo-bar).

renders as:

Using showdown v1.2.0.
Was this done by design? Or have we not had a need for it?

Actually, according to spec, elements inside html blocks should not be parsed by md engine. It is assumed anything inside an HTML block is already in HTML so it shouldn't need to be parsed.
The original markdown.pl, however, had a way of parsing HTML blocks by "marking" them with markdown="1".
Example:
# some markdown

blabla

This is **not parsed**

This is **parsed**

This was one of the project's original milestones. However, since no one has requested it yet I haven't thought of a way to implement it.
Do you think this is a important feature?

I would greatly enjoy this feature. My main use case is to be able to decorate markdown to look prettier. But I can understand why the original spec didn't make heavy provisions for it- markdown should be markdown, not markdown with html.
That being said github doesn't support this.

@tivie, you say "according to spec". Which spec is that? Is that CommonMark's?

@rodrigogoncalves No, the original official spec, https://daringfireball.net/projects/markdown/

@SyntaxRules Added the feature just now to develop branch. Mind taking a look?


bad link to repository

Version of the custom_component

Configuration

Add your config here.

Describe the bug
A clear and concise description of what the bug is.
Debug log

Add your logs here.

Im having issues with my config,just wanted to let you know that this link comes up in hasio
Invalid config
The following integrations and platforms could not be set up:
openhasp    sends me here ----https://https//openhasp-docs.github.com/
automation
Please check your config and logs.
4 minutes ago

Thank you!


getting Hyperlink of Cell

I 'am trying to get hyperlink of a cell and also the label by this way
Row row=rowIterator.next();
Iterator<Cell> cellIterator = row.cellIterator();
currentCell = cellIterator.next();
parthyperlink=currentCell.getHyperlink().getAddress();
String label=currentCell.getHyperlink().getLabel();

and I 'am getting this Exception

com.monitorjbl.xlsx.exceptions.NotSupportedException
at com.monitorjbl.xlsx.impl.StreamingCell.getHyperlink(StreamingCell.java:353)
at com.z2data.mapping.ExeclHorizental.getCurrentRow(ExeclHorizental.java:88)

please any help :)
Thanks in Advance ..........

This library has an incomplete implementation of the POI Cell interface. A good deal of the methods are not compatible with a streaming back end, but there are quite a few that haven't been implemented because no one has needed them yet.
I'd lean towards this being in the latter group. I don't think there are any conflicts with a streaming back end to return a hyperlink.

Unfortunately it looks like the <hyperlinks> are written out at the end of the document (at least, they are in my case) so I'm not sure this can work with SAX.  I'm trying to create an XLSX diff tool that needs streaming due to the size of my documents so, @monitorjbl , if you have any ideas on how to get this working, I'm all ears.  I'm not particularly familiar with SAX (worked with it once so not totally foreign) but would be happy to re-contribute something to make this work if I can.
Ref:
<?xml version="1.0" encoding="UTF-8"?>
<worksheet xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships">
    <dimension ref="A1:C2" />
    <sheetViews>
        <sheetView workbookViewId="0" tabSelected="true" />
    </sheetViews>
    <sheetFormatPr defaultRowHeight="15.0" />
    <sheetData>
        <row r="1">
            <c r="A1" s="1" t="n">
                <v>0.0</v>
            </c>
            <c r="B1" s="2" t="n">
                <v>1.0</v>
            </c>
        </row>
        <row r="2">
            <c r="A2" s="3" t="n">
                <v>1.0</v>
            </c>
            <c r="B2" s="4" t="n">
                <v>2.0</v>
            </c>
        </row>
    </sheetData>
    <hyperlinks>
        <hyperlink ref="A1" r:id="rId1" />
    </hyperlinks>
    <pageMargins bottom="0.75" footer="0.3" header="0.3" left="0.7" right="0.7" top="0.75" />
</worksheet>

Six years have passed and this problem has not yet been resolved.😒
Unfortunately, I also need the implementation of this method.
Does anyone have a good idea?

@ElsayedAwdElsayed I have basic hyperlink support in my fork of this project - https://github.com/pjfanning/excel-streaming-reader/


Draft PR for help purposes

I am sure I am missing something. Forgive me while I work through this.
Please add any comments.

Prefer squash merge

Hi 👋
We appreciate your Feature contribution, however, the devcontainers/features repo only accepts improvements and bug fixes for the current set of maintained Features.
However, we would appreciate if you could add this Feature in a separate repository of your control. The devcontainers/feature-starter repo has more guidance on self authoring them.
Once you've self authored and if you'd like to share it with the community, we'd recommend adding it to the index. It will make them visible in our supporting tools (like https://containers.dev/templates, Dev Containers Extension, GitHub Codespaces etc).
Feel free to ask any questions/queries along the way, feedbacks are welcome too!


style: require parentheses around arrow function arguments

Description
Current formatting rules deny parentheses around arrow function arguments, which means that the formating is different for functions that have 1 argument compared to when it has 0 or 2+. That has been annoying for me during dev. Please consider changing the lint rule.
Seems like it should be prettier default, but for some reason(gts?) didn't apply to us.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Internal change (a change which is not visible to the package consumers)
[ ] Documentation change or requires a documentation update

Checklist:

[ ] Unit tests have been added/updated
[ ] Documentation has been updated
[ ] Change file has been generated (npm run change:new)
[ ] Delete this branch (after the PR is merged)

Codecov Report
Base: 88.94% // Head: 88.94% // No change to project coverage :thumbsup:

Coverage data is based on head (26b11d4) compared to base (96a308a).
Patch coverage: 72.72% of modified lines in pull request are covered.

:exclamation: Current head 26b11d4 differs from pull request most recent head 3f5e221. Consider uploading reports for the commit 3f5e221 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   88.94%   88.94%
=======================================
  Files          27       27
  Lines         914      914
  Branches      204      204
=======================================
  Hits          813      813
  Misses        101      101

Impacted Files
Coverage Δ

src/profiling/DebugExporter.ts
30.00% <0.00%> (ø)

src/profiling/OTLPProfilingExporter.ts
48.83% <0.00%> (ø)

src/instrumentations/http.ts
80.21% <100.00%> (ø)

src/instrumentations/index.ts
100.00% <100.00%> (ø)

src/instrumentations/redis.ts
92.85% <100.00%> (ø)

src/resource.ts
88.23% <100.00%> (ø)

src/start.ts
100.00% <100.00%> (ø)

src/tracing/index.ts
98.66% <100.00%> (ø)

src/utils.ts
94.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.