parampoly3 parameters

Thank you. I appreciate it. I'd like to know how you calculated the equation for finding parampoly3 parameters at known control points. Thank you very much~

check out this issue: https://github.com/grepthat/libOpenDRIVE/issues/7

check out this issue: #7
yes,I want to know how to get these four formulas.thank you very much
p0 = (aU | aV)
p1 = (bu/3 + p0x | bV/3 + p0y)
p2 = (cU/3 + 2p1x - p0x  | cV/3 + 2p1y - p0y)
p3 = (dU + 3p2x - 3p1x + p0x | dV + 3p2y - 3p1y + p0y)


Show the value that will be used if not customized

I think I like this idea, because seeing the default value definitely gives a nice hint as to what the option actually does before you commit to customizing it.
I wonder if with this change we could change the input parsing to turn empty strings into nothing, instead of the default value. I think less people would "accidentally" choose to customize a value and then enter an empty string to get the default if they knew what the default value was right away.
Could you also make the same change in interactive(T::Type)?

I extended this PR a bit and came up with this:
julia> Template(; interactive=true)
Template keywords to customize:
[press: d=done, a=all, n=none]
   [ ] user ("christopher-dG")
   [ ] authors ("Chris de Graaf<EMAIL_ADDRESS>and contributors")
   [X] dir ("~/.local/share/julia/dev")
   [ ] host ("github.com")
   [ ] julia (v"1.0.0")
 > [X] plugins (PkgTemplates.Plugin[])
Enter value for 'dir' (String): ~/code
Select plugins:
[press: d=done, a=all, n=none]
   [ ] CompatHelper
   [ ] ProjectFile
   [ ] SrcDir
   [ ] Git
   [ ] License
   [ ] Readme
   [ ] Tests
   [X] TagBot
   [ ] AppVeyor
   [ ] CirrusCI
   [ ] Citation
 > [X] Codecov
   [ ] Coveralls
   [ ] Develop
   [ ] Documenter
   [ ] DroneCI
   [ ] GitHubActions
   [ ] GitLabCI
   [X] TravisCI
TagBot keywords to customize:
[press: d=done, a=all, n=none]
 > [ ] branches (nothing)
   [ ] changelog (nothing)
   [ ] changelog_ignore (nothing)
   [ ] cron ("0 0 * * *")
   [ ] destination ("TagBot.yml")
   [ ] dispatch (nothing)
   [ ] dispatch_delay (nothing)
   [ ] file ("~/code/PkgTemplates/templates/github/workflows/TagBot.yml")
   [ ] gpg (nothing)
   [ ] gpg_password (nothing)
   [ ] registry (nothing)
   [ ] ssh (nothing)
   [ ] ssh_password (nothing)
   [ ] token (Secret("GITHUB_TOKEN"))
Codecov keywords to customize:
[press: d=done, a=all, n=none]
 > [ ] file (nothing)
   [ ] None (No customization)
TravisCI keywords to customize:
[press: d=done, a=all, n=none]
 > [ ] arm64 (false)
   [ ] coverage (true)
   [ ] extra_versions (["1.0", "1.4", "nightly"])
   [ ] file ("~/code/PkgTemplates/templates/travis.yml")
   [ ] linux (true)
   [ ] osx (true)
   [ ] windows (true)
   [ ] x64 (true)
   [ ] x86 (false)

@oxinabox asking for a review because this might seem slightly overwhelming for beginning users (it adds a lot of info to the interactive menus), but at the same time I think the addition is welcome.


Import from pastebin

Retrieving paste....
shows it and then gives an error (after 5 minutes)

You have to provide more info, can you start with linking the pastebin?


Unitests and config file

Description
Management of the parameters for the calculation using a config file. Also some updates on the unittests.
Notable points that this PR has either accomplished or will accomplish.

[x] Implementation of a config file. I used the built-in configparser library and created a default.ini file that includes the parameters that the software uses by default but that can be updated using the defined options in the command-line version.
[x] Partial updating of unittests.

Status

[x] Ready to go

Hey @bisejdiu , everything is solved, notice that the comments in the config file are with ; instead of #. Please let me know if any other changes are required in this regard.  Cheers!


Resolved ReDoS vulnerability in Corpus Reader

Hello!
Pull request overview

Resolved Regular Expression Denial Of Service vulnerability in the CorpusReader for the Comparative Sentences Dataset.
Added performance tests hinting that the ReDoS is removed.

Background
Wikipedia page for ReDoS.
The ReDoS
The regular expression vulnerable to a ReDoS is compiled here:
https://github.com/nltk/nltk/blob/23f4b1c4b4006b0cb3ec278e801029557cec4e82/nltk/corpus/reader/comparative_sents.py#L48
And only used once, right here:
https://github.com/nltk/nltk/blob/23f4b1c4b4006b0cb3ec278e801029557cec4e82/nltk/corpus/reader/comparative_sents.py#L259
Regex breakdown
In full:
\((?!.*\()(.*)\)$

It consists of 4 segments, described here:

Regex section

Explanation

\(

Match the character ( exactly.

(?!.*\()

Negative lookahead. Makes sure that .*\( can not be matched. In short, this means that the remainder of the match (after the previous segment) can not contain another (.

(.*)

Matches any number of characters, and places them in a group for extraction.

\)$

Match the character ) exactly, and ensure that this is the end of the line.

What does this regex try to do?
It tries to find information within the brackets in each line in e.g.
1_its 2_models 3_fast-forward 3_rewind (more)
 1_4.5 gb 2_0.7 gb (nicer)
1_mirror 2_silver 3_finish (more)
 1_dvd players 3_quality 2_this (better)
 1_panasonics 1_toshibas 1_sonys (cheaper)

i.e. extract more, nicer, more, better, cheaper. This is what segments 1, 3 and 4 do. Segment 2 ensures that the starting ( is the most right-most ( in the entire input. This way, in e.g.
1_its 2_models (3_fast-forward) 3_rewind (more)

Only more is extracted.
The ReDoS comes from the combination of the two .*'s, and likely results from naive backtracking in Python's regular expression engine.
The fix
The new regex looks like so:
KEYWORD = re.compile(r"\(([^\(]*)\)$")

It's fairly similar to the previous regex. Segments 1 and 4 are reused, while segment 2 is removed, and segment 3 is modified.
Segment 3 is now:
([^\(]*)

This regular expression will now, rather than match anything, match anything except (. Because the $ at the end anchors us at the end of the line, this is still guaranteed to only get the last case of e.g. ... (more).
I've quickly tested this new regex with all lines in the Comparative Sentences Dataset, and it finds just as many matches as the old regex. I believe it's identical in output, and only differs in performance.

Tests
In order to help convince that this has actually resolved the issue, I've created a doctest in corpus.doctest. It will:

Perform KEYWORD.findall(payload) 9 times with a malicious payload of 4000 characters. Then, take the mean execution time between these 9 calls. This is dubbed the short mean.
Perform KEYWORD.findall(payload) 9 times with a malicious payload of 40000 (!) characters. Then, take the mean execution time between these 9 calls. This is dubbed the long mean.
If the regular expression execution time is linear to the size of the input (as it should be in such a relatively simple regex), then the long mean should be roughly 10 times as big as the short mean.
To play it safe, we ensure that the long mean is at most 30 times as big. A value of 30 seems to work fine.
When the ReDoS was still intact, the long mean would be rougly 80 times as big, which definitely indicates that the regex is not linear in execution time.

Thank you for reporting this vulnerability through our team email.

Tom Aarsen

@tomaarsen nice fix... not just safer and more efficient, but more readable

I'm starting to lean towards a similar "empirical threshold" approach for the language vocabulary performance test.


fix: [PROD-11532] Prevent useless refresh on GenericTable

Before creating a PR, please check that:

[ ] Code is clean
[ ] Tests are still working (cypress tests and yarn test)
[ ] Changes don't cause new errors or warnings in browser console
[ ] Documentation is up-to-date
[ ] Breaking changes are clearly identified with conventional commits

LGTM :+1:


Feature request: Add SVG icons of each social network

Every time this plugin is used you'd need to obtain some icons for presentation. Could we add simple SVG icons for each network? If we have icons for the Twitter bird and Facebook "f", then it's a simple case of styling them up as you wish.

It may also be worth adding some base styles for ease of installation. Circular, or square buttons for example.

This is now available in the v2 branch, which is in testing.


[new gallery] Reisze gallery images

Some cause of jank on both Skia and Impeller are these massive images. We should just resize them so that the noise is reduced and we can see other performance issues.
Fixes https://github.com/flutter/flutter/issues/147797
Tested: this is a test!

test-exempt: this is a test.

This surprisingly had a negative effect on the worst raster time 🤷:
https://flutter-flutter-perf.skia.org/e/?keys=X88f7834493ddea4cad661bf2d18ae13d&selected=commit%3D40663%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253Dworst_frame_rasterizer_time_millis%252Ctest%253Dnew_gallery_impeller_old_zoom__transition_perf%252C&xbaroffset=40664

wrong benchmark!


Bump Flutter Engine to e059e420.

Bump Flutter Engine to e059e420 (June 14th).
Changes to impeller-cmake:

Update shaders.
Add symlink mechanism to allow FML to use includes beginning with flutter/third_party.
Remove multi_arch_shader_archive.fbs build.
Point to a patch branch off of e059e420 with minor STL compatibility fixes (use explicit includes for array+memory/avoid std namespace for cmath functions).

The macOS build is currently failing to link impellerc.
[570/805] Linking CXX executable impellerc
FAILED: impellerc
: && /Users/runner/work/impeller-cmake/impeller-cmake/llvm/bin/clang++ -g -arch arm64 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names  CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/compiler.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/compiler_backend.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/constants.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/impellerc_main.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/includer.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/reflector.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/runtime_stage_data.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/shader_bundle.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/shader_bundle_data.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/source_options.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/spirv_compiler.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/spirv_sksl.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/switches.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/types.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/uniform_sorter.cc.o CMakeFiles/impellerc.dir/third_party/flutter/impeller/compiler/utilities.cc.o -o impellerc  libfml.a  libimpeller_base.a  libimpeller_geometry.a  libimpeller_runtime_stage.a  third_party/spirv_cross/libspirv-cross-glsl.a  third_party/spirv_cross/libspirv-cross-msl.a  third_party/shaderc/libshaderc/libshaderc.a  libimpeller_base.a  libfml.a  -Xlinker -framework -Xlinker Cocoa  -Xlinker -framework -Xlinker CoreFoundation  third_party/abseil-cpp/absl/debugging/libabsl_symbolize.a  third_party/abseil-cpp/absl/debugging/libabsl_debugging_internal.a  third_party/abseil-cpp/absl/debugging/libabsl_demangle_internal.a  third_party/abseil-cpp/absl/base/libabsl_malloc_internal.a  third_party/abseil-cpp/absl/strings/libabsl_strings.a  third_party/abseil-cpp/absl/strings/libabsl_strings_internal.a  third_party/abseil-cpp/absl/base/libabsl_base.a  third_party/abseil-cpp/absl/base/libabsl_spinlock_wait.a  third_party/abseil-cpp/absl/numeric/libabsl_int128.a  third_party/abseil-cpp/absl/base/libabsl_throw_delegate.a  third_party/abseil-cpp/absl/base/libabsl_raw_logging_internal.a  third_party/abseil-cpp/absl/base/libabsl_log_severity.a  third_party/spirv_cross/libspirv-cross-glsl.a  third_party/spirv_cross/libspirv-cross-core.a  third_party/shaderc/libshaderc_util/libshaderc_util.a  third_party/shaderc/third_party/glslang/glslang/libglslang.a  third_party/shaderc/third_party/glslang/hlsl/libHLSL.a  third_party/shaderc/third_party/glslang/SPIRV/libSPIRV.a  third_party/shaderc/third_party/glslang/glslang/libMachineIndependent.a  third_party/shaderc/third_party/glslang/glslang/OSDependent/Unix/libOSDependent.a  third_party/shaderc/third_party/glslang/OGLCompilersDLL/libOGLCompiler.a  third_party/shaderc/third_party/glslang/glslang/libGenericCodeGen.a  third_party/shaderc/third_party/spirv-tools/source/opt/libSPIRV-Tools-opt.a  third_party/shaderc/third_party/spirv-tools/source/libSPIRV-Tools.a && :
ld: warning: ignoring duplicate libraries: 'libfml.a', 'libimpeller_base.a', 'third_party/spirv_cross/libspirv-cross-glsl.a'
ld: archive member '/' not a mach-o file in '/Users/runner/work/impeller-cmake/impeller-cmake/out/build/ninja-debug/third_party/shaderc/third_party/glslang/hlsl/libHLSL.a'
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
Error: Process completed with exit code 1.

This also happens to be locally when using homebrew clang++, but doesn't happen when using xcode's clang distribution. Need to tease the macOS build into using the correct toolchain.


Qingwei/show msg when no chart data

Coverage decreased (-0.02%) to 30.134% when pulling 0e3e91b74a33fbeeadb0cce40dfdf69876f104bf on qingweibinary:qingwei/show_msg_when_no_chart_data into 16b1ba440b4890fe249319ea3975e0fe8f37cbb5 on binary-com:master.

Coverage decreased (-0.02%) to 30.134% when pulling b8dcb2f1fa25af0c19be03f8e23e142a4aa21f78 on qingweibinary:qingwei/show_msg_when_no_chart_data into 16b1ba440b4890fe249319ea3975e0fe8f37cbb5 on binary-com:master.


SignalR client is not able to get Negotiate API response in "isolated worker model"

I have created a project where I implemented the "Negotiate" API to create the SignalR connection.
My client is in JavaScript having reference of "<EMAIL_ADDRESS>On the Server side, I have implemented the "Negotiate" API as below.

I am using the following versions of the references:
Microsoft.AspNetCore.Http -> v 8.0
Microsoft.Azure.Functions.Worker -> v 1.21.0
Microsoft.Azure.Functions.Worker.Extensions.SignalRService -> v 1.13.0
Microsoft.Azure.Functions.Worker.Sdk -> v 1.17.0

using Microsoft.AspNetCore.Http;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Extensions.Logging;

namespace TestSignalRProj
{
    public class SignalRNegotiate
    {
        private readonly ILogger<SignalRNegotiate> _logger;

        public SignalRNegotiate(ILogger<SignalRNegotiate> logger)
        {
            _logger = logger;
        }

        [Function(nameof(Negotiate))]
        public static string Negotiate(
          [HttpTrigger(AuthorizationLevel.Anonymous, "get", "post")] HttpRequest req,
          [SignalRConnectionInfoInput(HubName = "submission")] string connectionInfo)
        {
            return connectionInfo;
        }
    }
}

When I tried to get a response from Postman, it did not return any value.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9a81f341-dbf1-f04f-5bb8-8d28e368ad4a
Version Independent ID: 062aceba-71b2-960b-4356-85eb16bae784
Content: Azure Functions SignalR Service input binding
Content Source: articles/azure-functions/functions-bindings-signalr-service-input.md
Service: azure-functions
GitHub Login: @Y-Sindo
Microsoft Alias: zityang

@hardikpatelse
Thanks for your feedback! We will investigate and update as appropriate.

@ManoharLakkoju-MSFT, @mike-urnun-msft,
I have addressed this matter by changing the return type from string to HttpResponseData class within the Microsoft.Azure.Functions.Worker.Http namespace. Additionally, I have updated the request object from HttpRequest to HttpRequestData, resulting in the following code structure.
[Function(nameof(Negotiate))]
public static HttpResponseData Negotiate(
        [HttpTrigger(AuthorizationLevel.Anonymous, "post")] HttpRequestData req,
        [SignalRConnectionInfoInput(HubName = "submission")] string connectionInfo)
{
      var response = req.CreateResponse(HttpStatusCode.OK);
      response.Headers.Add("Content-Type", "application/json");
      response.WriteStringAsync(connectionInfo);
      return response;
}

Hi @hardikpatelse Glad to hear that you're unblocked, and thanks for sharing the details of how you resolved it.
Since we didn't determine any faulty steps/changes to this doc upon reviewing your feedback, we will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


【Hackthon_4th 180】在FastDeploy中集成地平线推理引擎

PR types(PR类型)

Description

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: seyosum:x: xuhaoxuhao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


chore: update nodejs to v20

@nedsalk @danielbate Could this new Node version cause problems if merged in the same RC as this?

https://github.com/FuelLabs/fuels-ts/pull/1310

@arboleya vitest's package.json says it supports ^18 and >=20, so there shouldn't be an issue.


using css modules with gulp-babel

I know this is not so much a matter of css loader/modules, but I really don't know a better place for this question.
My problem is I have React components, and like having a folder for each component, with all required resources (jsx, css, images). For example
var ClassName = require('./index.css')
var Footer = React.createClass({
   render(){
     return <div className={ClassName.footer}>
       {this.props.children}
     </div>
   }
})

My problem is I want to use gulp-babel to transpile all my app to normal js, and keep folder structure, etc. ( I would like to use webpack, but as far as I know, it cannot be used for this), so transform /src folder to /lib folder.
So people using my component, especially in webpack/browserify wil be able to use it (in package.json I have "main": "lib/index.js") so, if they use lodash or other modules in their app (and it happens my component also uses them), they get the module they are using, not the one my component is enforcing.
Basically, I want to avoid having to distribute a minified/concatenated version of my component.
But since gulp-babel only does transpilation, it will leave require('./index.css') as is, which is not what I want. What I really want is to remove those css requires (probably before transpilation) from the transpiled sources (people will be including an external css file the component is providing).
Any ideas on how to accomplish that? Thanks

There's likely no simple way to remove actual require statements within Webpack. You would have to use a transformation tool like recast for that.
Perhaps a nicer way to solve this would be to resolve CSS against null-loader? In this case the require statements would be included but they simply would do nothing.

Well, replacing the css-loader with the null-loader would not solve the problem, since I use the value returned by the css require call since I have auto-generated classNames.

@radubrehar I wonder if what you need here is a new babel plugin?  The main work of the plugin (exporting locally-scoped classnames) can be done with https://github.com/css-modules/css-modules-loader-core, like what we've done with https://github.com/css-modules/css-modulesify
There is a somewhat-related conversation going on over at https://github.com/css-modules/css-modules/issues/13 if you're interested.

Yes, I think a babel plugin is what I need. It should replace the css require call with an object containing the names of the auto-generated classes. The resulted code should be commonjs/nodejs compliant, so it can be used by third parties.
Thanks for pointing out to those links. I still don't think they solve the problem completely but it's a start.
Thinking more thoroughly, I think we need more than a babel plugin, since we need it to be aware of the classNames generated by webpack at build time (when the css bundle is built), so we might need a more tight integration.
What do you think?

You're right, there will be a little more work required to get css-modules-loader-core exporting identical classNames (at babel-time) to webpack (at build-time), because the format may be slightly different.
From what I can tell, you'll need to match webpack's localIdentName to postcss-local-scope's generateScopedName, which can be customized in an option: https://github.com/css-modules/postcss-modules-scope/blob/master/src/index.js#L33
You can see an example of this here: https://github.com/css-modules/css-modulesify/blob/master/index.js#L9-L19

I also use webpack with babel, also SASS and I think I found a solution to this: I forked css-loader and added a new parameter for localIdentName: sourceHash. This generate a hash from the localName and the source code, so the class names are stable.
https://github.com/Aluxian/css-loader

Looks like I just released babel 6 plugin for webpack loaders so you can build your library with babel as babel src --out-dir lib

Well ... this is HUGE! This looks fantastic to me! Thanks a lot

I think this should solve this issue. Other impressions?

I am resolving this issue. To the original issue, all support requests / questions should be done in either the Webpack Gitter or in Stack Overflow  w/ the webpack tag


Adjust retrieving _max_workers from Executor

The mpi4py implementation will return None if it can't give a specific number. So this adjusts how _max_workers is retrieved to set it to None if it can't be figured out. Then if it is None, it will fallback to dask.config.
xref: https://github.com/mpi4py/mpi4py/issues/94
xref: https://github.com/mpi4py/mpi4py/pull/117

[ ] Closes #xxxx
[ ] Tests added / passed
[ ] Passes black dask / flake8 dask / isort dask

Planning on merging end of day tomorrow if no comments.


[ddcommon] Add token bucket rate limiter implementation

What does this PR do?
Add an implementation of a token bucket rate limiter to ddcommon.
Motivation
Meant as a reference implementation of the rate limiter intended to be used by tracing clients for their sampling implementation.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Hm. A couple notes:

the time resolution on windows is ... rather milliseconds than nanoseconds. Not a fundamental problem, but it makes not much sense to have interval in anything but at least milliseconds, I'd say
the time is using system time, which is susceptible to ... system time changes, i.e. not monotonic.

I do already have an implementation of a rate limiter https://github.com/DataDog/libdatadog/blob/012dc9a33750008d2c4961e256ea7101a7fb2403/sidecar/src/shm_limiters.rs
I hadn't needed it outside of sidecar yet ... but probably should have pushed it to ddcommon.
That implementation is based on atomics.
I very much need atomics as the purpose of the limiter is being able to work across processes via shared memory, something I can't just Mutex.
Also my use case involves the ability to change the rate limit on an existing limiter. (i.e. being friendly to that scenario).
Do you want to keep your implementation, or should we rather take my limiter implementation and put the LocalLimiter I have into ddcommon (and possibly the ShmLimiter into ipc crate)?

@bwoebi my original implementation was using clocksource as a way to avoid the issues with SystemTime, that was something I wanted to revisit here.
I don't care too much about whose implementation is taken, but having a shared token bucket rate limiter implementation in ddcommon would be good.

That implementation is based on atomics.
I very much need atomics as the purpose of the limiter is being able to work across processes via shared memory, something I can't just Mutex.

Is there a reason you need it to work across processes?
For most of the language libraries the sampling rate limiter is per-process.

Codecov Report
Attention: Patch coverage is 93.08176% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (eb62a6d) to head (0329035).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   70.49%   70.58%   +0.08%
==========================================
  Files         213      214       +1
  Lines       28412    28588     +176
==========================================
+ Hits        20030    20179     +149
- Misses       8382     8409      +27

Components
Coverage Δ

crashtracker
25.21% <ø> (+0.07%)
:arrow_up:

datadog-alloc
98.73% <ø> (ø)

data-pipeline
50.00% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
86.79% <93.08%> (+0.56%)
:arrow_up:

ddcommon-ffi
74.58% <ø> (ø)

ddtelemetry
58.95% <ø> (ø)

ipc
84.18% <ø> (ø)

profiling
78.09% <ø> (ø)

profiling-ffi
56.76% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
35.42% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
71.14% <ø> (ø)

trace-normalization
98.24% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.16% <ø> (ø)

trace-utils
91.03% <ø> (-0.60%)
:arrow_down:

@brettlangdon The primary problem is that PHP tends to have many processes in some configurations, with autoscaling the number of processes depending on load, making the sample rate ... unpredictable.
Which is why shared rate limiting is needed - you just set it and it's valid for your host.

@brettlangdon The primary problem is that PHP tends to have many processes in some configurations, with autoscaling the number of processes depending on load, making the sample rate ... unpredictable. Which is why shared rate limiting is needed - you just set it and it's valid for your host, which is a perfectly known quantity.

What is the performance overhead of using a shared memory rate limiter vs an in-process one? I'd expect it to be quite heavy?

@brettlangdon Why would there be any extra overhead (apart from the initial mmap call)? It's just pointing to some memory.

@brettlangdon Why would there be any extra overhead (apart from the initial mmap call during process init)? It's just pointing to some memory.

Wouldn't we now be creating contention between processes on shared memory updates?

That's why the implementation is based on atomics, to avoid any lock contention.

Superseeded by #560.


Added bugfix 2, CommArch stuff, and final project stuff

Let me know if any of the yaml keys are wrong and I'll change them.

@IAmRasputin Could you add the key name: to the yaml file? It's now required to have a valid ofCourse yaml key. Feel free to put your normal name, handle, or whatever you feel is appropriate.

Done.

:strawberry: :sandal:


Update scalafmt-core to 3.1.1

Updates org.scalameta:scalafmt-core from 2.7.5 to 3.1.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-major, semver-spec-major

Superseded by #82.


vue devtools available in production mode

Describe the bug
I am using vite to build a javascript library using the "Library Mode". I noticed that the vue devtools are available for inspection in development mode but also in production mode.
What I expect:
Not being able to inspect my vue application after running npm run build.
What actually happens:
I can inspect the application despite running in production mode.

Reproduction
https://github.com/joonlabs/vite-vue-devtools-issue
Steps to reproduce

Clone the repo
Run npm install
Run npm run build (this will build the library in the dist folder and copy an index.html file to the dist folder)
Start a local server in the dist folder (e.g. cd dist && http-server)
Open the page in the browser
Open the vue devtools and inspect the app

The repo is a project initiated with npm create vite@latest. I modified the App.vue to display the current build mode, changed the config.vite.ts to build in "Library Mode" and added an index.html file (template) to quickly test the issue, as a built vite library does not come with an html file.
System Info
System:
    OS: macOS 12.4
    CPU: (8) arm64 Apple M1
    Memory: 66.06 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 16.16.0 - /usr/local/bin/node
    npm: 9.2.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 114.0.5735.106
    Edge: 113.0.1774.57
    Firefox: 113.0.2
    Safari: 15.5

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is because you are using process.env: {} in define. This will replace process.env.NODE_ENV  !== "production" with {}.NODE_ENV  !== "production" that means it's built with development mode.
Vue expects process.env.NODE_ENV to be replaced with 'production' for production mode.
To do that, you need to use 'process.env.NODE_ENV': JSON.stringify('production') instead.
Closing as this is not a bug.


[BUG] useNavigation hook gives 404 error when id of resource contains slash(/)

Describe the bug
When using different methods of the useNavigation hook like show, edit, etc. it returns a 404 page not found error if the id of the resource contains a slash(/). For example, if the id of the resource is ABC/2 then it redirects to /ABC/2 instead of /ABC%2F2 thus causing a 404 error.
To Reproduce
Use the show, edit or any other method of the useNavigation hook using a resource which has a slash in its id.
Expected behavior
Encode and Decode the params of the URL so that it  redirects to /ABC%2F2

Hey @sajjad006 , We've released 2.7.1! Could you approve this fix?

The issue is resolved. Thank you.


egl: print supported dmabuf formats

Useful for debugging dmabuf related problems e.g. when a client requests a certain and we fail to support it.

@emersion if that's the only style nit then I think I'm improving. Fixed.

Thanks!


⚠ Site ANTS has degraded performance

In f299b58, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 6648 ms

Resolved: Site ANTS performance has improved in b7c4d74.


fix(update): Tweak CLI behavior

What does this PR try to resolve?
When looking at cargo update for #12425, I noticed that the two flags related to --package were not next to it or each other.  I figured grouping them like that would make things easier to browse.
When looking into that, I noticed that the two flags conflict and figured we'd provide a better error message if we did that through clap.
How should we test and review this PR?
Looking per commit will help show the behavior changes.
Additional information
I wanted to scope this to being simple, non-controversial, low effort, incremental improvements with this change so I did not look into the history of --aggressive not requiring  --package like --precise does and figure out if there is any consistency we can be working towards.

Make sense. Thank you!
@bors r+

:pushpin: Commit 4fd0c3c46cef1d8a21bfdb7320f83fb6dd1b546a has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 4fd0c3c46cef1d8a21bfdb7320f83fb6dd1b546a with merge baebd2bfb6e36ec73c88a3f41fe576bc0bdd97cd...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing baebd2bfb6e36ec73c88a3f41fe576bc0bdd97cd to master...


batch_size not support list

1) Confirm the below

[X] My Python version is 3.5 or higher
[X] I have searched through the issues Issues for a duplicate
[X] I've tested that my Keras model works as a stand-alone

2) Include the output of:
talos.__version__
1.4
3) Explain what actually happened
keras version: 2.14.0
params={'batch_size': [10, 20, 30]}

def create_model(x_train, y_train, x_val, y_val, params):
    ...
    out = model.fit(x_train, y_train, batch_size=params['batch_size'])
    return out, model

talos.Scan(x=x_train, y=y_train,
                   model=create_model,
                   params=params,
                   experiment_name='build_model',
                   x_val=x_val, y_val=y_val)

log:
out = model.fit(x_train, y_train,
  File ".../lib/python3.9/site-packages/keras/src/utils/traceback_utils.py", line 70, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File ".../lib/python3.9/site-packages/keras/src/engine/data_adapter.py", line 275, in __init__
    self._size = int(math.ceil(num_samples / batch_size))
TypeError: unsupported operand type(s) for /: 'int' and 'list'
  0%|          | 0/192 [00:00<?, ?it/s]

when model.fit(batch_size=params['batch_size']), then 'batch_size' param not support list, even latest keras version v3.3.3:
batch_size: Integer or `None`.
                Number of samples per gradient update.
                If unspecified, `batch_size` will default to 32.
                Do not specify the `batch_size` if your data is in the
                form of datasets, generators, or `keras.utils.PyDataset`
                instances (since they generate batches).

Is there a problem with my configuration?

@anxinyf there is nothing apparent from what you have shared above. Is it possible to share a google colab notebook which reproduce this issue?


Node module caching

Morning team. Firstly thanks for all your work on this, really appreciating the fixes. I do have a question about caching node modules. I've been using the cache@v2 action for caching ./node_modules using the lockfile as a key in my non-SWA based repos but it doesn't work here as it doesn't appear that the swa action copies node_modules into the Oryx workspace. As a result the npm dependencies have to be downloaded again.
I did wonder about copying them into the Oryx working dir using a custom build command but 1. that seems like a bit of a hack and 2. I'm not even sure that would work for projects with separate frontend and api lockfiles?
Is this a viable way of doing it or have I missed something?

@kichalla are there any plans to add the ability to Oryx to pull node modules from a GH action cache?

Are there any updates on this? Our build takes 3 minutes to pull all node modules, costing both time and unneccessary npm bandwidth i guess.


Disconnects on long wait time for new messages

I have a discord bot that is supposed to send a message to discord after receiving an MQTT message. There is very little activity, so typically there is hours or even days between messages received. I noticed that when there's a long wait, the first time a message is published and is received by the bot, I hit Disconnected during message iteration. The result is the message on the subscribed topic is gone. Here is a log of the output when this happens:
bot   | 2020-12-19 05:51:55 INFO Connecting to MQTT.
bot   | 2020-12-19 05:51:55 INFO Connection to MQTT open.
...
bot   | 2020-12-19 16:18:19 ERROR Connection to MQTT closed: Disconnected during message iteration
bot   | 2020-12-19 16:18:22 INFO Connecting to MQTT.
bot   | 2020-12-19 16:18:22 INFO Connection to MQTT open.

Subsequent messages are published minutes later, and the bot is able to process the message as intended.
I've looked at the code in asyncio-mqtt but it's unclear to me how to prevent this condition. Any advice is greatly appreciated.
For background, the bot and mosquito are running with docker-compose, and are on the same docker network. My connection and message subscription loop is identical to the code in the test.

Thanks for submitting this issue. Let me have a look.

There is very little activity, so typically there is hours or even days between messages received.

I've never tested the library to this extreme, so it's good to have some data on the matter. :+1:
I'm guessing that the connection is lost due to the long wait. This is curious, though, since I was under the impression that paho-mqtt continuously pings the server to keep the connection alive. This is exactly what the keepalive parameter is supposed to do.
I have some questions:

Do you see a ping message every 60 seconds in the mqtt broker log?
Does the issue occur with paho-mqtt itself (without asyncio-mqtt)?

Again, thanks for reporting this issue. :+1:

I've been debugging this a bit, but still can't figure out why this is happening. There doesn't seem to be a rhyme or reason why the initial message doesn't get processed. I thought originally it was because of the length of time of the previous connection, however, looking at my logs if I add messages pretty close together, the first message never is sent. I see the same disconnect status.
I do not see a reconnect every 60s. My log shows the initial connection as:
mqtt       | 2020-12-25T23:12:06: New client connected from <IP_ADDRESS> as listener (p2, c1, k60).

The originating message is sent with paho-mqtt itself. I'm thinking of redoing that code using asyncio-mqtt. Originally just felt like overkill to send a message since I didn't need the asynchronous behavior.

Thanks for the follow-up with additional information. :+1:

There doesn't seem to be a rhyme or reason why the initial message doesn't get processed. I thought originally it was because of the length of time of the previous connection, however, looking at my logs if I add messages pretty close together, the first message never is sent.

These kind of issues are especially difficult to debug. :) Right now, the culprit can be either of the following:

An issue in asyncio-mqtt (this repo)
An issue in paho-mqtt (our dependency)
An issue in your code itself
An issue with your local setup (MQTT broker, network, etc.)

I'd like to have a go at this issue but the problem space (1–4 above) is way too big. Can you reproduce the issue somehow? Preferably with an independent code example that triggers the bug reliably.

Anyhow, here are some things that you can try:

Increase the QoS setting to exactly_once.
Use logger.info("Message %s %s", message.topic, message.payload) instead of logger.info("Message %s %s", message.topic, message.payload.decode()). The latter (from the test code) assumes UTF8-encoded payload. Maybe this is not the case in your scenario?
Thinking a bit further about the previous point: Maybe something inside your async for message in messages loop body raises an exception. You can try to simplify the code inside the for loop to simply print the message for the purpose of testing.

Sorry it's taken so long for me to get back to this. I've swapped my paho-mqtt code out entirely for asyncio-mqtt. (Actually saved me a few lines of code, yay for less code and more readable code!)
However, the problem persists. Originally I filed it as a long time with an open connection, but instead I'd like to amend this to say "the first call to". I still don't quite know why this happens, since that code path is hit again once a job completes too, and the second time through it works just fine.
I suspect it could still be any of 1 through 3. I doubt it's (4) since I am able to send messages to the topic and receive/be notified of new messages. I'm going to spend a little more time debugging this.

Sorry it's taken so long for me to get back to this. I've swapped my paho-mqtt code out entirely for asyncio-mqtt. (Actually saved me a few lines of code, yay for less code and more readable code!)
However, the problem persists. Originally I filed it as a long time with an open connection, but instead I'd like to amend this to say "the first call to". I still don't quite know why this happens, since that code path is hit again once a job completes too, and the second time through it works just fine.
I suspect it could still be any of 1 through 3. I doubt it's (4) since I am able to send messages to the topic and receive/be notified of new messages. I'm going to spend a little more time debugging this.

Sorry it's taken so long for me to get back to this.

That's completely fine. No hurry. At least not on my part. :)

I've swapped my paho-mqtt code out entirely for asyncio-mqtt. (Actually saved me a few lines of code, yay for less code and more readable code!)

Glad to hear that. :+1:

However, the problem persists. Originally I filed it as a long time with an open connection, but instead I'd like to amend this to say "the first call to". I still don't quite know why this happens, since that code path is hit again once a job completes too, and the second time through it works just fine.

Ah, well, that changes things. It is indeed very strange that it behaves differently the first time only. Can you show me your code somehow? Post it here maybe?

I suspect it could still be any of 1 through 3. I doubt it's (4) since I am able to send messages to the topic and receive/be notified of new messages. I'm going to spend a little more time debugging this.

Option 4 is a long shot. But let's not leave it out completely just yet.

Sorry it's taken so long for me to get back to this.

That's completely fine. No hurry. At least not on my part. :)

I've swapped my paho-mqtt code out entirely for asyncio-mqtt. (Actually saved me a few lines of code, yay for less code and more readable code!)

Glad to hear that. :+1:

However, the problem persists. Originally I filed it as a long time with an open connection, but instead I'd like to amend this to say "the first call to". I still don't quite know why this happens, since that code path is hit again once a job completes too, and the second time through it works just fine.

Ah, well, that changes things. It is indeed very strange that it behaves differently the first time only. Can you show me your code somehow? Post it here maybe?

I suspect it could still be any of 1 through 3. I doubt it's (4) since I am able to send messages to the topic and receive/be notified of new messages. I'm going to spend a little more time debugging this.

Option 4 is a long shot. But let's not leave it out completely just yet.

... looking amazed on this wonderful code ...
i am trying to write sort of topic-translator/state machine to connect crouton dashboard(s) to tinkerforge mqtt-sources...
one can imagine

1 mqtt connection per dashboard which might connect to the broker and issue requests
and
1 connection per data-source - which must be started and stopped as subprocess and will connect to the broker and serve requests

imy app n the middle keeping states and translating topics ;-)
so lots of parallel tasks which have to run endlessly and be kept happy ..
i think this is an ideal scenario for as yncio ...

... looking amazed on this wonderful code ...
i am trying to write sort of topic-translator/state machine to connect crouton dashboard(s) to tinkerforge mqtt-sources...
one can imagine

1 mqtt connection per dashboard which might connect to the broker and issue requests
and
1 connection per data-source - which must be started and stopped as subprocess and will connect to the broker and serve requests

imy app n the middle keeping states and translating topics ;-)
so lots of parallel tasks which have to run endlessly and be kept happy ..
i think this is an ideal scenario for as yncio ...

hope you solve the issue ... - might it be some race condition or broken assumption about ordering of events ?
is there some documentation or at least some big picture of the overall design ?

Hopefully this becomes apparent when we get the repro code. :)

hope you solve the issue ... - might it be some race condition or broken assumption about ordering of events ?
is there some documentation or at least some big picture of the overall design ?

Hopefully this becomes apparent when we get the repro code. :)

repro.zip
Attached is a repro, however, using that repro I'm unable to repro the issue!
What I left out here due to Let's Encrypt certs, and this is a biggie, is the Traefik setup. My setup with Traefik and Let's Encrypt is identical to that of https://gist.github.com/natcl/ed8253a34e7b87d879baabeba82cb846. I tried to add in Traefik without Let's Encrypt, but didn't get it to work. Figured I'd point you to that setup in case you want to give this a try and add in Traefik along with some dummy sub-domains that you control.
So it's possible that there's a weird "first time only" issue when listening to messages in bot.py using Traefik. But then why it works the next time is still a mystery.

repro.zip
Attached is a repro, however, using that repro I'm unable to repro the issue!
What I left out here due to Let's Encrypt certs, and this is a biggie, is the Traefik setup. My setup with Traefik and Let's Encrypt is identical to that of https://gist.github.com/natcl/ed8253a34e7b87d879baabeba82cb846. I tried to add in Traefik without Let's Encrypt, but didn't get it to work. Figured I'd point you to that setup in case you want to give this a try and add in Traefik along with some dummy sub-domains that you control.
So it's possible that there's a weird "first time only" issue when listening to messages in bot.py using Traefik. But then why it works the next time is still a mystery.

I've dug into this a bit more. Reading the documentation on MQTT and Mosquitto, it seems that each connection client id should be unique. So I've appended a uuid4().hex to the client id. This way each connection made will have a unique id. With that fix, I've not been able to reproduce this issue.

Glad that you found a solution to this. :tada:
The fix has some ties to #48. If we encourage the user to reuse the Client instance, then they will also reuse the ID. I think that change solves both these issues.


read products from index

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #25
Test URLs:

Before: https://main--sazerac-99brandparty--hlxsites.hlx.page/products
After: https://25-allproducts--sazerac-99brandparty--hlxsites.hlx.page/products

todo: images from index are not good, how to include proper ones with picture tag?


Number of WAL files for a tserver can become large

I've been experiencing a case where TabletServers will hold on to many more WAL logs than normal in a (seemingly) unbounded fashion until it is restarted.  As a byproduct, it causes extremely long recovery periods after the restart.  TabletServers will have hundreds or thousands of WAL entries in ZooKeeper instead of a normal 3-5.
Accumulo Version 1.9.3

@keith-turner , I noticed you self-assigned this about a month ago. Are you still looking into this? Have you made any progress?

Does this issue exist in any version later than the reported 1.9.3?


nz-tooltip cannot work with nz-options in the nz-select

Version
7.0.0-rc.3
Environment
MacOS
Reproduction link
https://stackblitz.com/edit/angular-sznujt
Steps to reproduce

Use the nz-select component, and set the labels of nz-options to a very long string.
Add nz-tooltip to every nz-option.

What is expected?
Tooltips work when hovering mouse on the options.
What is actually happening?
No tooltips.
Other?

@Fanoid  nzCustomContent
https://stackblitz.com/edit/angular-sznujt-upxc4v?file=src/app/app.component.ts


Cannot update stack with resource-group-id

Hi,
We cannot update a stack with a resource group using ros-cdk. Steps to reproduce:

Execute ros-cdk deploy <MASKED> --resource-group-id <MASKED>
Wait for the stack to be successfully created
Execute ros-cdk deploy <MASKED> --resource-group-id <MASKED> again. The command fails with the error below:
fail to update stack, cannot support set resource-group-id params to this operation.

CDK is based on ROS, and ROS UpdateStack API does not support update ResourceGroupId now. so, It cannot be supported at present.

Hi @baichenxu3, thanks for the reply, it's clear now. However, I think people may expect two exactly the same commands to have the same result and the whole operation to be idempotent. Would it be possible to implement it in ros-cdk to ignore the resource-group-id if the deployment is invoked for an update? I.e.:
ros-cdk deploy <MASKED> --sync --resource-group-id <MASKED> # Creates a stack in resource group
ros-cdk deploy <MASKED> --sync --resource-group-id <MASKED> # Ignore resource group id and update

Otherwise, every client using resource groups would need to write custom code to check it which seems to be harder than including the feature in ros-cdk. What do you think about it?

UpdateStack support ResourceGroupId has been arranged for development. The current solution is to use commands such as ros-cdk list to determine the deployment status.

Thanks, guys. We will work on a workaround on our side and we'll keep our fingers crossed for the feature to appear in ROS in the future ;).

UpdateStack supports ResourceGroupId now.
ros-cdk-cli 1.0.24 is released, the validation of --resource-group-id has been removed.
@kucharzyk-sebastian

Thanks, @Ehzyo, I can confirm it works well now!


HTTP  requests fail due to passing whole URL as the resource

Description:
When making a GET request for a resource, the whole URL sent as the resource that needs to be accessed. Therefore it fails with a 404.

The following is a correct GET request to the same resource.

Suggested Labels:
bug
Suggested Assignees:
@minudika
Affected Product Version:
WSO2SP-4.0.0, WSO2SP-4.1.0

Closing as per the above fix


fix: update to eye v10.9.1

fix: update to eye v10.9.1

:tada: This PR is included in version 16.6.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v16.6.1

Your semantic-release bot :package::rocket:


Fix github alias links in MAINTAINERS.md

Prepend the https://github.com to ensure that markdown rendered links
are not resolved as local links.
Signed-off-by: timflannagan<EMAIL_ADDRESS>
Description of the change:
Motivation for the change:
Reviewer Checklist

[x] Implementation matches the proposed design, or proposal is updated to match implementation
[x] Sufficient unit test coverage
[x] Sufficient end-to-end test coverage
[x] Docs updated or added to /doc
[x] Commit messages sensible and descriptive

/approve

/lgtm

Force merging as these changes won't affect anything user facing and it already has the requisite labels present.


Delete README.md

/ensure #1 and #2 are resolved first

/ensure #1 and #2 are resolved first

/ensure #1 and #2 are resolved first

/ensure #1 and #2 are resolved first

/ensure #1 and #2 are resolved first

/ensure nothing

/depends on #1

/depends on #4

/depends #1 and #2

/depends #1 and #2

/depends on nothing

/depends on nothing

/depends on nothing

/depends on nto

/ensure #4

/depends on #4

/depends on #4

/depends on #4, #1 and #2

/depends on #2 and #4 only


How to reproduce results on IC15?

IC15 evaluation requires the use of vocabulary. How do you make use of that?

Hi, we are working on releasing all of our evaluation code by next week. This will also include the necessary logic to evaluate with a vocabulary, as we did in our paper.
Thanks a lot for the interest in our work, I will keep you posted.


Update test_max_fee_limit_validate

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2ca7b46) 70.93% compared to head (44ba0fa) 70.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1272   +/-   ##
=======================================
  Coverage   70.93%   70.93%
=======================================
  Files          57       57
  Lines        7154     7154
  Branches     7154     7154
=======================================
  Hits         5075     5075
  Misses       1666     1666
  Partials      413      413

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


index multi fast5 files

Hi there,
I converted to single fast5 files in order to use albacore
multi_to_single_fast5 --input_path fast5 --save_path fast5_single
read_fast5_basecaller.py --flowcell FLO-MIN106 --kit SQK-LSK108 --barcoding --output_format fastq --input fast5_single --save_path fastq --worker_threads 8 --recursive --reads_per_fastq_batch 0
Then I got my fastq barcoded on which I did my minimap2 stuff as in https://github.com/jts/nanopolish/issues/320
Now in order to analyze my amplicon data to get the variants I need to generate the index files from my fast5 files and I in doubt how do it. Basically I need to run this command for each my barcoded fastq
for i in seq 1 10; do nanopolish index -d fast5_single BC$i; done
but, here it is the doubt, I need to use the fast5 single files converted or the fast5 multiple (the original one)?
Thanks
Best
Andrea

Since you used the single fast5 files for basecalling you should probably index those.  It would probably work with the multi files too though.
Jared

On May 20, 2019, at 2:03 PM, Andrea Spitaleri<EMAIL_ADDRESS>wrote:
Hi there,
I converted to single fast5 files in order to use albacore
multi_to_single_fast5 --input_path fast5 --save_path fast5_single
read_fast5_basecaller.py --flowcell FLO-MIN106 --kit SQK-LSK108 --barcoding --output_format fastq --input fast5_single --save_path fastq --worker_threads 8 --recursive --reads_per_fastq_batch 0
Then I got my fastq barcoded on which I did my minimap2 stuff as in #320
Now in order to analyze my amplicon data to get the variants I need to generate the index files from my fast5 files and I in doubt how do it. Basically I need to run this command for each my barcoded fastq
for i in seq 1 10; do nanopolish index -d fast5_single BC$i; done
but, here it is the doubt, I need to use the fast5 single files converted or the fast5 multiple (the original one)?
Thanks
Best
Andrea
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks @jts . I will try. One more thing: the index has to be done per each fastq file, which are from the concatenation of the several fastq from the barcoding step, right? I am in new in nanopore technology and I want to be sure that I am doing right.
Best

Yes, that's right. Feel free to re-open if you have other questions.


.NET Not Working in Visual Studio Code Despite Multiple Troubleshooting Steps

Type: Bug
I am trying to get .NET working on Visual Studio Code (VSC). I have installed the latest version of both, and have created a global.json file, but I don’t see .NET in my command palette.
Here are the steps I have taken to troubleshoot:
Checked that the C# extension in VSC is installed.
Killed any VSC process using the Task Manager.
Installed the .NET SDK from the official website.
Located .NET using where.exe dotnet command in a cmd.
Added the address that I got to the system path.
Rebooted my device.
Installed the C# extension in VSC.
Checked my .NET SDK installation by opening a new terminal and typing dotnet --version.
Checked my Visual Studio Code version by going to Help > About in Visual Studio Code.
Reinstalled the C# extension in Visual Studio Code.
Checked my system’s PATH by typing echo %PATH% in a new Command Prompt window and looking for the path to the .NET executable.
Restarted my system after making changes to the system’s PATH.
Uninstalled and reinstalled both Visual Studio Code and .NET SDK, making sure to add the .NET executable to my system’s PATH during the installation process.
Despite these steps, the issue persists. I am using the long-term support version of .NET. Any assistance would be greatly appreciated.
VS Code version: Code 1.82.2 (abd2f3db4bdb28f9e95536dfa84d8479f1eb312d, 2023-09-14T05:55:25.390Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 5 5600X 6-Core Processor              (12 x 3700)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.93GB (25.22GB free)

Process Argv
--crash-reporter-id 75fa1667-1767-40bb-abaa-75a7d8a70235

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

csharp
ms-
2.4.4

vscode-dotnet-runtime
ms-
1.8.0

python
ms-
2023.16.0

vscode-pylance
ms-
2023.9.30

cpptools
ms-
1.17.5

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
f6dab269:30613381
a9j8j154:30646983
showlangstatbar:30737416
962ge761:30841074
03d35959:30757346
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30805730
pythonnoceb:30805159
copilotsettingc:30839828
dsvsc013:30795093
dsvsc014:30804076
diffeditorv2:30821572
dsvsc015:30845448

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!

thanks for getting back to me.
okay I ran Extension Bisect and the problem of no .NET: New Project option in the command pallet persisted, I then re-downloaded, installed, and checked the .NET SDK 6.0 install, persisted. I uninstalled the Python and C++ extensions, just leaving .NET Runtime Install Tool and C#, no luck.. finally I reinstalled VSCode, and still the same problem, no .NET: New Project in the command pallet


⚠ Bofrost.es has degraded performance

In 6815a4f, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1528 ms

Resolved: Bofrost.es performance has improved in b47d6db after 6 minutes.


Support for integrated USB ports?

Hey there!
I want to use this script with my TI-84 plus CE-T, and it has an integrated USB port, not a graphlink port.
Can i still use this library?
Thanks in advance!
-Sven de Wit

Hi there! Unfortunately, ArTICL only supports the 2.5mm D-BUS or I/O port, not the USB port. However, it is possible to communicate with USB serial devices like an Arduino directly from the calculator: https://www.cemetech.net/forum/viewtopic.php?t=15087


Explicit References

The following documentation isn't completely accurate:
"The <references> element explicitly specifies the assemblies that the target project should reference when using the package. When this element is present, NuGet add references to only the listed assemblies; it does not add references for any other assemblies in the package's lib folder."
According to this, if no references are listed, it should not add any references.  However, with empty <references>, nuget still adds a reference to the DLL in the lib folder.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06a19d7d-253d-f17f-6421-624c9867473d
Version Independent ID: cc37eb17-f715-080c-7bfc-9eae868d50ba
Content: .nuspec File Reference for NuGet
Content Source: docs/reference/nuspec.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

Looks like the incorrect text has been removed.


API cleaning

API
GET /pattern
Get JSON for all nodes.
POST /pattern
Import JSON without a parent group.
expects JSON body []CreateElement
POST /pattern?action=reset
(recursive) Batch reset nodes.
expects JSON body []ElementID
POST /pattern?action=delete
(recursive) Batch delete nodes.
expects JSON body []ElementID
POST /pattern?action=get
(recursive) Batch JSON export of nodes.
expects JSON body []ElementID
POST /pattern?action=ungroup
Batch ungroup nodes. Each group deleted and all child nodes are given to their grandparent.
expects JSON body []ElementID
POST /pattern?action=translate&x=<offset>&y=<offset>
Batch translate nodes by offset.
expects JSON body []ElementID
GET /pattern/{id}
Get JSON of id and all descendants of id.
POST /pattern/{id}
Import JSON with parent group of id.
expects JSON body []CreateElement
PUT /pattern/{id}
sets node root keys.
expects JSON body UpdateElement
GET /pattern/{id}/state
returns node state (if applicable)
PUT /pattern/{id}/state
sets node state (if applicable)
expects JSON body
PUT /pattern/{id}/routes/{route_id}
sets route state on a group (if applicable)
expects JSON body UpdateElement
websocket client
subscription
{
    "action": "subscribe"
    "id": string
}

websocket server
element creation
{
    "action":"create"
    "data": [ Element ]
}

element translation
{
    "action":"translate"
    "x": int
    "y": int
    "data": [ ID ]
}

elements deleted
{
    "action":"delete"
    "data": [ ID ]
}

elements update alias
{
    "action":"update_alias"
    "id": string
    "alias": string
}

elements update position
{
    "action":"update_position"
    "id": string
    "position":{
        "x":int
        "y":int
    }
}

element update group route alias
{
    "action":"update_alias"
    "id": string
    "alias": string
}

element update group route hidden
{
    "action":"update_alias"
    "id": string
    "hidden": bool
}

element status
{
    "action":"status"
    "id": string
    "code": int
}

pattern JSON
[ Element... ]

where element order is leaf-first

I don't quite understand:

POST /pattern?action=get - method is POST, action is GET and it's an export? How is it different to GET /pattern ?
PUT /pattern/{id}/state - when would this be used?

you POST an array of IDs -- this is fo circumstances where you export a series of blocks without a root parent. I was thinking about offloading the operation that generates the copy JSON to the server, suc that when you hit ctrl-c, it does this api call to recursively retrieve all JSON of selected blocks that does not require a root.
the second is if you want a store to have a specific value. so i can post my weights to a store or whatever.


TypeError fails  Chroma SimilaritySearches in OpenAIEmbeddings.

In short, the function
async embedQuery(text)     allows for 'any' type to sent.  Fails when using Chroma...
langchain/dist/embeddings/openai.js:164
input: this.stripNewLines ? text.replace(/\n/g, " ") : text,
^
TypeError: text.replace is not a function
--
at OpenAIEmbeddings.embedQuery (file:///Users/fred/GPT/jsclient/node_modules/langchain/dist/embeddings/openai.js:164:46)
at Chroma.similaritySearch (file:///Users/fred/GPT/jsclient/node_modules/langchain/dist/vectorstores/base.js:103:90)

Can you share code so that I can repro? I don't quite understand the issue at the moment - it's typed to take a string:
https://github.com/hwchase17/langchainjs/blob/main/langchain/src/embeddings/openai.ts#L184


Error while executing(training for Hindi dataset):-  !python train_tacotron.py

I have changed the language = 'fr', tts_cleaner_name = 'basic_cleaners' in hparams.py.
The command below gives me no error.
py preprocess.py --path /content/tacotron/dataset_folder
output
71 wav files found in "/content/tacotron/dataset_folder."

Using 68 wav files that are indexed in metafile.

+-------------+-----------+--------+------------+-----------+----------------+
| Sample Rate | Bit Depth | Mu Law | Hop Length | CPU Usage | Num Validation |
+-------------+-----------+--------+------------+-----------+----------------+
|    22050    |     9     |  True  |    256     |    1/2    |      200       |
+-------------+-----------+--------+------------+-----------+----------------+

████████████████ 68/68 First val sample: 1_1_60`

Completed. Ready to run "python train_tacotron.py" or "python train_wavernn.py".

But when I run
python train_tacotron.py
I get the following error message:-
`Using device: cuda

Initialising Model...

Creating latest checkpoint...
Saving latest weights: /content/tacotron/checkpoints/ljspeech_raw.wavernn/latest_weights.pyt
Saving latest optimizer state: /content/tacotron/checkpoints/ljspeech_raw.wavernn/latest_optim.pyt
2020-12-30 07:09:50.274334: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library libcudart.so.10.1
Traceback (most recent call last):
  File "train_wavernn.py", line 62, in <module>
    voc_trainer.train(voc_model, optimizer, train_gta=args.gta)
  File "/content/tacotron/trainer/voc_trainer.py", line 46, in train
    path=self.paths.data, batch_size=bs, train_gta=train_gta)
  File "/content/tacotron/utils/dataset.py", line 38, in get_vocoder_datasets
    train_ids, train_lens = zip(*filter_max_len(train_data))
ValueError: not enough values to unpack (expected 2, got 0)`

hparams.py'de dili = 'fr', tts_cleaner_name = 'basic_cleaners' olarak değiştirdim. Aşağıdaki komut bana hata vermiyor. py preprocess.py --path /content/tacotron/dataset_folder
çıktı
71 wav files found in "/content/tacotron/dataset_folder."

Using 68 wav files that are indexed in metafile.

+-------------+-----------+--------+------------+-----------+----------------+
| Sample Rate | Bit Depth | Mu Law | Hop Length | CPU Usage | Num Validation |
+-------------+-----------+--------+------------+-----------+----------------+
|    22050    |     9     |  True  |    256     |    1/2    |      200       |
+-------------+-----------+--------+------------+-----------+----------------+

████████████████ 68/68 First val sample: 1_1_60`

Completed. Ready to run "python train_tacotron.py" or "python train_wavernn.py".

Ama koştuğumda
python train_tacotron.py
Aşağıdaki hata mesajını alıyorum: -
`Using device: cuda

Initialising Model...

Creating latest checkpoint...
Saving latest weights: /content/tacotron/checkpoints/ljspeech_raw.wavernn/latest_weights.pyt
Saving latest optimizer state: /content/tacotron/checkpoints/ljspeech_raw.wavernn/latest_optim.pyt
2020-12-30 07:09:50.274334: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library libcudart.so.10.1
Traceback (most recent call last):
  File "train_wavernn.py", line 62, in <module>
    voc_trainer.train(voc_model, optimizer, train_gta=args.gta)
  File "/content/tacotron/trainer/voc_trainer.py", line 46, in train
    path=self.paths.data, batch_size=bs, train_gta=train_gta)
  File "/content/tacotron/utils/dataset.py", line 38, in get_vocoder_datasets
    train_ids, train_lens = zip(*filter_max_len(train_data))
ValueError: not enough values to unpack (expected 2, got 0)`

I got the same error for train_forward. How did you solve this?

Has anyone found a solution to this issue?

Bu soruna çözüm bulan var mı?
Unfortunately.I wish I could find it but I couldn't

I added some extra logging, it seems like a lot of my data is being filtered out due to that filter_bad_attentions  function.
Using 20 train files. Filtered 3630 files due to bad attention!
Using 0 val files. Filtered 200 files due to bad attention!

I am wondering if either my dataset is not large enough or if it has problems.
filter_bad_attentions does a for loop on each item in the dataset and pulls out the name and the mel_len from the array. The items in the array look similar to: ('q-715-audio', 280). Then it uses the attention_score_dict and selects based on the file name and pulls out the align_score and the  sharp_score. The items in that dict look like 'q-1019-audio': (0.9242424368858337, 0.3374719023704529). At this point we check if align_score > min_alignment  and sharp_score > min_sharpness and if that passes, we add it to the returning object. The reason this error occurs is because the returned object is empty and nothing can be pulled out of it. The two values in the if check that we check against are hard coded at https://github.com/as-ideas/ForwardTacotron/blob/master/utils/dataset.py#L139 so I am wondering what makes those correct and if loosening those values is necessary for a smaller dataset. I will keep testing and update on what I find.

It looks like we can actually change those values in the config.yaml https://github.com/as-ideas/ForwardTacotron/blob/master/config.yaml#L124. You could set it to no filter and bypass this problem though I dont know how that will affect the resulting outcome.


Median hits per line?

Any chance you can switch to doing median hits per line, rather than mean hits per line for your average?  We have a small file that gets over 3 million hits per line, and that skews the results a tad.

Closing due to lack of activity. Feel free to reopen with new info


[Snyk] Security upgrade python from 3.12.3-alpine to 3.13.0rc1-alpine

Snyk has created this PR to fix 5 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

Dockerfile.mac_chip

We recommend upgrading to python:3.13.0rc1-alpine, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Integer Overflow or Wraparound SNYK-ALPINE320-EXPAT-7908298
  786

Integer Overflow or Wraparound SNYK-ALPINE320-EXPAT-7908299
  786

XML External Entity (XXE) Injection SNYK-ALPINE320-EXPAT-7908300
  786

Use After Free SNYK-ALPINE320-BUSYBOX-7233533
  514

Use After Free SNYK-ALPINE320-BUSYBOX-7233586
  514

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 XML External Entity (XXE) Injection
🦉 Use After Free

@anselmbradford Not sure why this was reopened.  We won't be moving to python 3.13 until its official release on Oct 1, and after making sure everything works right (which I can't imagine a minor release wouldn't be still will be testing our baselines with it).  And Orc2 is the current release candidate, not Orc1 as this PR requests.  So this PR should be rejected as it references a non-official baseline of python to move to and that's something we're just not going to do.

@jcadam14 I have no idea why this is coming from my account, it's an automated Snyk message that is somehow masquerading as me. I'll do some investigating…

Got rid of Dockerfile.mac_chip to remove snyk errors

think we can just close this (and other) snyk PRs that relate to the mac chip dockerfile? since the dockerfile removal resolved the issue, and there are no changes

think we can just close this (and other) snyk PRs that relate to the mac chip dockerfile? since the dockerfile removal resolved the issue, and there are no changes

When I previously tried closing it,


add shared credential object

Creates a class that's basically a subset of MSIDCredentialCacheItem for sharing with microsoft-authentication-library-for-cpp. Not used by microsoft-authentication-library-common-for-objc at this time.

Don't you guys have a policy that you can't merge unapproved PRs?

Since the related refactoring work is intended to happen later, I'll retarget this PR for a separate branch, as requested.


Update Query use case to to show the rank history by its button in LoggedInView panel.

branch not updated.


Roadmap for 2.* and 3.*

Hi!
Could you please point me to your lifecycle roadmap of of 2.* and 3.* versions? I'm happy with v2 and do not plan to upgrade in the nearest future. About 5 projects use second version... So it would be nice to know what to expect in next 365 days :)

Hi, as of now, v2 and v3 are pretty much the same, except for the actual http client. As such, maintaining both shouldn't be that much of a problem. I actually did that while launching v2.7.0, and it was pretty easy.
That being said, I think I'll actively maintain v2 until at least April 2018, and depending on the number of downloads for v2 by then, I'll re-evaluate and maybe extend it for another 3 or 6 months.
Another option is maybe include some sort of wrapper to ease the transition. You can always fall back to a blocking request in order to avoid much of the hazzle: https://github.com/unreal4u/telegram-api/blob/master/examples/01.blocking-get-me.php
I'll update the readme however to include the roadmap. Thanks!


Security Concern for Face - Detect

Hi, according to api document, "url" is required when I call Face - Detect so that cognitive service can get the image and detect faces. However, others can also get them. Personally, it is quite insecure. Can you provide some request headers for us to verify whether requests come from cognitive service? Or can we store the image data in request body just like speaker recognition api?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23b53a5e-c53f-7760-b59e-a4cb99d95705
Version Independent ID: 7fe313a1-fec1-2998-aa37-b4e0afa84d5a
Content: API Reference for the Face API Service - Microsoft Cognitive Services
Content Source: articles/cognitive-services/Face/APIReference.md
Service: cognitive-services
GitHub Login: @SteveMSFT
Microsoft Alias: sbowles

@PatrickPan2012 Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Thx so much.


[Improvement][Worker] Simplify the delivery of AlertClientService object and support multiple alert server

Describe the question
This issue want to talk about two things:

We don't need to transport the AlertClientService by parameter, only SqlTask need to send result by AlertClientService. We can register the AlertClientService to Spring container like other object.

https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/runner/TaskExecuteThread.java#L108-L110
https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/TaskManager.java#L47
https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/TaskManager.java#L60
https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java#L97-L110

Currently, the worker only supports to config one address of AlertServer, in the production environment, we may start multiple AlertServer, although we can set up a gateway on AlertServer, but can we have a better way?  Such as store the total addresses of AlertServer in worker, and use round-robin to select.

Which version of DolphinScheduler:
-[dev]

This is just a simple implementation, we considered accessing the registry before. But due to time reasons, it is not completed, you can look the previous issue.


[C API] Magic header not detected with AOT

wasm_module_new() fails with this message.
I have a precompiled wasm module. It loads fine on Linux/Mac/Windows when building WAMR with INTERP=1 AOT=0. The same binary loads after rebuilding WAMR with INTERP=0 AOT=1 on Mac and Windows but not on Linux. All systems Intel x64.
Probably related to https://github.com/bytecodealliance/wasm-micro-runtime/issues/251 . The module data is being loaded like this:
wasm_byte_vec_t moduleBytes;
wasm_byte_vec_new_uninitialized(&moduleBytes, fileSize);

size_t bytesRead = fread(moduleBytes.data, 1, fileSize, file);

Not sure this makes sense but already tried something like this at no avail:
wasm_byte_vec_t moduleBytes;
moduleBytes.size = fileSize;
moduleBytes.data = aligned_alloc(4, fileSIze, false);

size_t bytesRead = fread(moduleBytes.data, 1, fileSize, file);

I am using C++11 so there is no std::aligned_alloc, grabbed this implementation instead.

Update: same issue on Mac... disregard the platform part, blame my project build script.

May I ask which file was opened? XXX.wasm or XXX.aot .

I am using the asc AssemblyScript compiler here . There is no option for producing .aot files.
These are somehow beginner questions then:

Will these binaries run unmodified later in a web browser WASM runtime?

How to go from .ts to .aot?   the compiler above produces also produces .wat

Thanks

That was a silly question...
wamrc compiles .wasm files into .aot which target a specific CPU architecture, hence won't work in a web browser...

May I ask which file was opened? XXX.wasm or XXX.aot .

Helpful hint, closing now.


Error while building on Windows using MSVC...

Hey David, I am seeing the following error:
C:/src/tools-windows-msvc-master-branch/src/libobjc2/associate.m(171,2): error: cannot use '@try' with Objective-C exceptions disabled
        @try
        ^
1 warning and 1 error generated.

I’m guessing you’re missing the -fobjc-exceptions compiler flag.
You can find the flags needed e.g. here in the readme:
https://github.com/gnustep/tools-windows-msvc#using-the-toolchain-from-the-command-line


Fix an issue with start command

It is not possible to run the app with the current command mentioned in this document. It needs to be updated. Hence proposing this file change.

I just followed the instructions with no problem.  The app ran fine for me with
DEBUG=my-express-app:* npm start

Also, the express generator displays instructions with the same exact command, so if there is any issue with it, we should also update the generator.  However, it seems to work fine.
@samunplugged What OS/version are you using?

Ah, it works. Not sure what I did wrong the last time. Closing this. Thanks for response.


Move parser into its own package

Fixes #40 (minus potential refactoring)
~Please review in particular the Duration it was a bit more tricky due to the naming ambiguity between time.Duration and parse.Duration should be alright though as all tests pass~

Coverage remained the same at 89.593% when pulling 16e272a1afce6001fd1429d9943505a6b8336942 on serbrech:public-parser into 60c87a513a955ca7225e1b1c772581cea8420cb4 on containous:master.

Coverage remained the same at 89.593% when pulling e1a5fb9d3a814b6c6646df0499a9e097f5fc637c on serbrech:public-parser into 60c87a513a955ca7225e1b1c772581cea8420cb4 on containous:master.

Coverage remained the same at 89.593% when pulling e1a5fb9d3a814b6c6646df0499a9e097f5fc637c on serbrech:public-parser into 60c87a513a955ca7225e1b1c772581cea8420cb4 on containous:master.

Coverage remained the same at 89.593% when pulling e1a5fb9d3a814b6c6646df0499a9e097f5fc637c on serbrech:public-parser into 60c87a513a955ca7225e1b1c772581cea8420cb4 on containous:master.

I made a mistake early with Duration and changed Duration to time.Duration in parse.go
that lead me to wrongly fixing compile and test error in parse_test and flaeg, until everything worked... but with time.Duration. After a chat with @ldez, I found the root of my mistake and reverted to use parse.Duration where it was changed in e1a5fb9

Travis don't want to build this PR... 😞
I'm going closed and reopened.

Don't work... 😞
I will try to make a dummy commit.

I tested the PR locally, I bypass Travis.


A few improvements

Hi there,
I have played recently with this action and I have found a few things where I could help.

Improve issue validation using issue-parser package, which now detects cross-repo issues ( full URL ), ie.https://github.com/hattan/verify-linked-issue-action/issues/29  as well as shorthand ones, #issue_number
The issue referenced in the PR sidebar ( connected events ) was not working properly since it was returning inside forEach not inside the main function, possible connected to https://github.com/hattan/verify-linked-issue-action/issues/22
Add output for action has_linked_issues which can be used in other steps/jobs.
Added one args as quiet which prevent action for failing, allowing you to use the output in other steps
Added one arg as no_comment which prevent the action from adding the comment. quiet argument automatically for this as true.

Let me know if you find those useful.
P.S one example where I used the output is this:
name: Verify PR

on:
  pull_request:
    types: [ edited, synchronize, opened, reopened ]

jobs:
  verify_linked_issue:
    runs-on: ubuntu-latest
    if: github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
    name: Ensure Pull Request has a linked issue.
    steps:
      - name: Verify Linked Issue
        id: verify_linked_issues
        uses: Codeinwp/verify-linked-issue-action@master
        env:
          GITHUB_TOKEN: ${{ secrets.BOT_TOKEN }}
        with:
          quiet: 'true'
      - name: Find Comment
        uses: peter-evans/find-comment@v1
        id: find_coomment
        with:
          issue-number: ${{ github.event.pull_request.number }}
          comment-author: 'pirate-bot'
          body-includes: No Linked Issue found
      - name: Create or update comment
        uses: peter-evans/create-or-update-comment@v1
        if: steps.verify_linked_issues.outputs.has_linked_issues != 'true'
        with:
          comment-id: ${{ steps.find_coomment.outputs.comment-id }}
          token: ${{ secrets.BOT_TOKEN }}
          issue-number: ${{ github.event.pull_request.number }}
          body: |
            :guardsman: PR Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>
          edit-mode: replace
      - name: Fail action on no issue found
        if: steps.verify_linked_issues.outputs.has_linked_issues == 'false'
        run: exit 1;
      - name: Delete comment
        uses: jungwinter/comment@v1
        if: steps.verify_linked_issues.outputs.has_linked_issues == 'true' && steps.find_coomment.outputs.comment-id != ''
        with:
          type: delete
          comment_id: ${{ steps.find_coomment.outputs.comment-id }}
          token: ${{ secrets.BOT_TOKEN }}

This project looks dead I wonder if we should fork this project and keep it up to date with things like this and ignoring Dependabot PR's etc??


[WIP] Add react-i18next to Node app template

WHY are these changes introduced?
Part of the project App Localization - Tools and Guidance (tech design).
Translating apps is technically challenging, time-consuming, and costly. Despite the high demand for localized apps internationally, only a small fraction of apps offered in the Shopify App Store are translated.
None of Shopify's app templates are localized, meaning that the full burden of responsibility is on the developer to research and implement an i18n framework for their app. It’s also more likely to be an afterthought until the developer decides to expand internationally, at which point the effort to externalize all the app's strings is much higher.
By localizing the default Node app template, we reduce the toil for developers, and give them a head start in localizing their apps from the start.

WHAT is this pull request doing?

This is a draft pull request for the purposes of discussion - it will not be merged until:

It has buy-in with the client libraries & app templates team
It has been updated to use the Storefront locale file format used by themes and app UI extensions
The README has been updated

This PR:

Adds the i18next and react-i18next libraries
Extracts all hard-coded strings into locales/en.json
Adds locales/fr.json file for demonstration purposes
Adds an i18nUtil utility to initialize i18next
Adds an I18nProvider component to encapsulate locale selection
Extracts navigation to a Navigation component so that the page title can be externalized

Why react-i18next?

It is the most popular open source React i18n framework
It has comprehensive documentation and it's easy to get started
It's extensible with many plugins, including one for Remix

To Do

Write a plugin for i18next to support the Storefront locale file format
Update this PR to use the plugin and update the file format
Update the README to describe the i18next libraries and configuration

Checklist
Note: once this PR is merged, it becomes a new release for this template.

[ ] I have added/updated tests for this change
[ ] I have made changes to the README.md file and other related documentation, if applicable

Wrong repo 🤦🏻 , closing


Style/ExtraSpacing: Cannot win if I do, cannot win if I don't :-)

With this code:
      expect(ec2)
        .to receive(:run_instances)
        .with(
          image_id:                             :image_id,
          min_count:                            1,
          max_count:                            1,
          key_name:                             'sledger',
          security_group_ids:                   [ :security_group_id ],
          user_data:                            :user_data_base_64,
          instance_type:                        't2.small',
          monitoring:                           {
            enabled: true
          },
          subnet_id:                            :subnet_id,
          disable_api_termination:              false,
          instance_initiated_shutdown_behavior: 'stop',
          iam_instance_profile:                 {
            name: :iam_instance_profile_name
          },
          ebs_optimized:                        false
        )

I get the following:
C: Style/ExtraSpacing: Unnecessary spacing detected.
          ebs_optimized:                        false
                        ^^^^^^^^^^^^^^^^^^^^^^^

If I remove the spacing in an attempt to appease the man, I get:
C: Style/AlignHash: Align the elements of a hash literal if they span more than one line.
          ebs_optimized: false
          ^^^^^^^^^^^^^^^^^^^^

This problem will we fixed by #2233.


Lossy CRAM archive option not working?

I tried to use the archive option as specified in the documentation.
In our case the option [cram-lossless] seems to work as intended, but [cram] unfortunately throws an error [0], a CRAM file is generated nonetheless.
I suspect the quality score binning by bamUtil is causing the problem, because the actual compression to cram (using only samtools, without the binning) after the try/except in cram.py seem to work.
Have other users already encountered the same problem? I have seen the comment
https://github.com/bcbio/bcbio-nextgen/issues/2734#issuecomment-520844794, stating the archive option works, but not specifying which.
Are there any plans to use another tool for quality score binning instead of bamUtil as hinted in the interesting discussion https://github.com/bcbio/bcbio-nextgen/issues/2531#issuecomment-427403883?
samtool itself currently supports only lossy read names and in the above-mentioned discussion crumble  was mentioned.
Any feedback is very welcome
[0] Error message using archive option [cram] from bcbio-nextgen.log :

[2019-08-14T10:19Z] Uncaught exception occurred
Traceback (most recent call last):
File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 26, in run
_do_run(cmd, checks, log_stdout, env=env)
File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 106, in _do_run
raise subprocess.CalledProcessError(exitcode, error_msg)
CalledProcessError: Command 'set -o pipefail; /usr/local/share/bcbio-nextgen/anaconda/bin/bam squeeze --in /bioinf-data/bcbio/work/align/NA12878/NA12878-sort.bam --out -.ubam --keepDups --binQualS=2,10,20,25,30,35,70 --binMid | /usr/local/share/bcbio-nextgen/anaconda/bin/samtools view -T /usr/local/share/bcbio-nextgen/genomes/Hsapiens/GRCh37/seq/GRCh37.fa -@ 16 -C -x BD -x BI -o /bioinf-data/bcbio/work/bcbiotx/tmp5FA5Np/NA12878-sort.cram
Number of records read = 93864852
Number of records written = 93864852
[E::bgzf_read] Read block operation failed with error 2 after 176 of 280 bytes
[main_samview] truncated file.
' returned non-zero exit status 1

Thanks, this should be working fine-- I'm guessing that the command failed due to something unrelated. If you rerun your run, does it fail here again? You could also try running  /usr/local/share/bcbio-nextgen/anaconda/bin/bam squeeze --in /bioinf-data/bcbio/work/align/NA12878/NA12878-sort.bam --out -.ubam --keepDups --binQualS=2,10,20,25,30,35,70 --binMid | /usr/local/share/bcbio-nextgen/anaconda/bin/samtools view -T /usr/local/share/bcbio-nextgen/genomes/Hsapiens/GRCh37/seq/GRCh37.fa -@ 16 -C -x BD -x BI -o out-file.cram outside of bcbio and seeing if it fails.

The cram lossy compression is unfortunately still in the same state as the previous discussion we didn't come up with a good approach to tackle it based on the existing tools. Explicit software quality binning has also become a bit less useful the newer machines output binned values.
Practically, what you're seeing is that bam squeeze can be pretty unreliable and we just fall back to standard CRAM when it dies:
https://github.com/bcbio/bcbio-nextgen/blob/05f088353d2b3498f6f77006f0fcafead784dcb7/bcbio/bam/cram.py#L40
Lossless CRAM provides pretty good compression relative to BAM so we haven't yet got into exploring new tools to work around this. Sorry about that, and hope that the lossless CRAM will work okay for your case.

Thanks Brad and @sam-ber. I added a blurb about this to the documentation to direct folks to mainly use cram-lossless.

Thank you Brad, for your explanation.
I agree, quality score binning is less useful when newer machines output already binned values and as you pointed out, the compression rate of lossless CRAM vs BAM is already pretty impressive.
Furthermore, losing information through binning does not feel good to me (which is why I wanted to see the difference between lossy and lossless CRAM in crunchy numbers).
Thanks Rory for updating the documentation!
For posterity: Rerunning the whole analysis using bcbio and repeating only the specific command both lead to the identical error message.
It looks like bam squeeze does not produce a valid uBam file.

Thanks for following up @sam-ber, that is helpful information!


Normalize URI Path in in nethttpadaptor

fixes #6324
In the base nethttpadapter, we are currently using SetRequestURI for incoming requests. This results in fasthttp not normalizing the HTTP request path which eventually leads to requests not being routed to their intended handler (see issue).
PR changes the adapter to use SetQueryString, and importantly, SetPath which does normalize the path. This results in fixing downstream problems like the one in the issue.
/assign @artursouza

Would this cause any issue with using service invocation?

Would this cause any issue with using service invocation?

@ItalyPaleAle can you expand a bit on what you mean by this?

Would this cause any issue with using service invocation?

@ItalyPaleAle can you expand a bit on what you mean by this?

If a user invokes Dapr with a path that doesn't match any Dapr API, we assume they're doing service invocation. For example:
curl -H 'dapr-app-id: checkout' 'http://localhost:3602/checkout/100' -X POST

Do you think this could cause any issue if we "normalize" the URL?

Would this cause any issue with using service invocation?

@ItalyPaleAle can you expand a bit on what you mean by this?

If a user invokes Dapr with a path that doesn't match any Dapr API, we assume they're doing service invocation. For example:
curl -H 'dapr-app-id: checkout' 'http://localhost:3602/checkout/100' -X POST

Do you think this could cause any issue if we "normalize" the URL?

I don't expect so. By the time the request has got to the invoke handler (by the catch all {method:*} matcher), the path is normalized. The problem here is that the path is not normalized before routing, causes some paths to match to that catch all invoke route when they actually belong to another.

Please, move this change to release-1.10 and we can add to 1.10.7 release with proper release notes.

We have a PR merged in release-1.10 already for this, which means it will be merged into master. Closing this PR.


I can not find "train_data.json","val_data.json","test_data.json"  of didemo dataset,

Hello, I can not find "train_data.json","val_data.json","test_data.json"  of didemo dataset, and it also not be provided in this project. Can you share these files?

Hi @xmu-xiaoma666, feel free to access them in: https://github.com/LisaAnne/LocalizingMoments/tree/master/data


Incorporate ineffassign tool into our CI job (linter)

https://github.com/gordonklaus/ineffassign

Any problem with that issue?

I'd like this issue will be created in JIRA :)

Ok 🙂

Already included -> closing this issue :)


fix: owner spell

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/auto-cc


Preprocess test files with Browserify

Yeah, seemed like it.
I'll try it out tomorrow. Thanks a lot.


Add new mempool metrics to Grafana dashboards

Motivation
PR #6972 implements three new mempool metrics. These need to be added to our Grafana dashboards.
Proposed solution
Please follow the comments in #6972.
Testing
It would be good to manually test the edited/new dashboards.

Done in #7019.


enable auto deployment on tags to Github Releases

Someone with push access could generate Github authentication tokens and un-comment the deploy section in .travis.yml and .appveyor.yml.
Then, the next time a tag is pushed, wheels will be automatically uploaded to Github Releases page.

Thanks Cosimo.  I gave you commit access.

Thanks Behdad. I've added the secure Github token to .travis.yml in 7447370f149adc9f462d00622c7b68621d866d51
So now the next time a tag is pushed, wheels for OSX and Linux (and sdist) will be uploaded to Github Releases. For Appveyor we first need to enable it (#21), then we can do the same and upload Windows wheels to Github as well.
I would also like to set up PyPI deployment for compreffor. I can take care of the CI setup and also of maintaining the compreffor PyPI account, if you don't mind.

Done!
https://github.com/googlei18n/compreffor/releases


Initial browser testing

Addressing #8.

@chriseth I believe this PR is configured and coded correctly, but the results of the Selenium tests have been inconsistent. Their elapsed times are significantly variable, and there are occasional false negatives. I assume this is due to instability in the connection between Travis & Sauce.
I get consistent/fast results when running the tests on my laptop with a local Selenium Server. I get consistent/slow results when running the tests on my laptop via the Sauce connection. I get inconsistent results when the tests are run via Travis. You can see this here: https://travis-ci.org/ethereum/browser-solidity/pull_requests

Looks cool! Could you think about a way to make it more concise (i.e. not to have every single test in a separate file)? Not sure how to group tests though.

@axic You can learn more about writing tests at: http://nightwatchjs.org/guide#usage. It appears that each file represents a browser session. You can break up the tests in the file, but they really represent "steps" in a sequence. Can you do me a favor and try running the tests locally?

OMG I think I figured out how to get it working consistently on Travis. I started using waitForConditionTimeout, set to 60 seconds.

@redsquirrel please reabes

It's rebased. BUT, the browser tests are inexplicably failing again. 😞  Do not merge. 😞

@chriseth The tests passed. I suggest merging this. If the tests are flaky in master, then remove the call to nightwatch from travis and we can at least run them locally.


"Project management package 250" is depended on Public sector data

It's written: "there is currently a commercial system and shared package as well as a separate public sector system and shared package that CAN'T be used together". I upload 13 packages of "Commercial data" listed above without Public Sector packages and get more than thousands errors after"250 - Project management - HQUS" is imported, which say that company PSUS doesn't exist. PSUS belongs to Public sector packages. What are the requested packages and the sequence of their upload, if I need Project management data as well? Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3fc92d46-8f1c-dc72-82c0-dcbccf014c18
Version Independent ID: 934a9f55-fd2a-a08c-b8ce-cfd0c1fbb975
Content: Generate demo data by using data packages - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/data-entities/generate-demo-data-packages.md
Service: dynamics-ax-platform
GitHub Login: @ryansandness
Microsoft Alias: ryansand

Hi Ryan,
Data management

Unfortunetly, the logs for Import Sys_And_Shared and Fin_200_HQUS were deleted, but they were uploaded in that sequence.
Project management and accounting

example of error, referencing to PSUS

Thank you. Can you re-download the file from LCS (Demo data 8.1. 250 Project management and accounting HQUS) and compare the files within to these last two screenshots?  I downloaded from LCS and clearly see 88 items in the zip file with no reference to employee or fund.