HDFS-17234. Fix the logic for reconfigure slow peer enable for Namenode

Description of PR
As described in : https://issues.apache.org/jira/browse/HDFS-17234
if the parameter dfs.datanode.peer.stats.enabled is set to true, when it transitions to false, if there are "SlowNodes" at this time, the slowNodesUuidSet will always record certain datanode, and reads and writes may always be avoided. Therefore, it is necessary to clear the slowNodesUuidSet.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 21s

trunk passed

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 48s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 44s

trunk passed

+1 :green_heart:
mvnsite
0m 54s

trunk passed

-1 :x:
javadoc
0m 51s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 57s

trunk passed

+1 :green_heart:
shadedclient
21m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 44s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 35s

the patch passed

+1 :green_heart:
mvnsite
0m 47s

the patch passed

-1 :x:
javadoc
0m 38s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 54s

the patch passed

+1 :green_heart:
shadedclient
21m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
197m 32s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

290m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6213/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6213

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7df6674c7733 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6516e0679372060b7731c92cb416532909bfbb94

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6213/1/testReport/

Max. process+thread count
3366 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6213/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 51s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

-1 :x:
javadoc
1m  8s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
37m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

-1 :x:
javadoc
0m 57s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
37m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
224m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

375m 25s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6213/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6213

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 499c61fa2260 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6516e0679372060b7731c92cb416532909bfbb94

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6213/1/testReport/

Max. process+thread count
3719 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6213/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Change Regtest RPC port to Bitcoin 0.16+ default

This one bit me (for about 30 seconds today)  - can we make this change as part of the 0.20 update?


remove all ddo price tests

Integrate with upcoming stable aqua

Yeah, it's nice to have them because they are testing internal ocean.js functions


WIP - GDE-1161 Chef Client 13 POC

Refactored to work with Chef client 13
Ran Rubocop

This cookbook is deprecated.


Provide Diplomats with Glossary

CodeCombat is unlike anything you've previously translated.  Prepare for some archaic phrases and out-of-this-world concepts. In order for you to work more efficiently, we're compiling a glossary of some of the more esoteric phrases and concepts. New diplomats should look up their glossary (or create it) to ensure that their contributions fit with contributions from other diplomats.
For example, a lot of the boards have humans and ogres in them.  The word "human" probably has a few different translations in any given language, and the feel of things is so much better if the same word is used for this concept everywhere.  In the same, but opposite way, "ogre" is quite likely to not have a translation, and the diplomat would be faced with choosing one of (possibly many) words for vile creatures.
If you start to see a lot of boards with, e.g., "The Mirewood Fells" or something, and it becomes a CodeCombat meme, you could add that so that translators could agree on how to translate it.
I suggest a top-level i18n type called "Glossary." Along with that would be a page where a diplomat would be able to see the current glossary for his language (the current i18n UI might suffice).
Finally, the glossary should be populated with board-related things like gem, ogre, hero, Sarven. The entries would have to be tagged if they're a given name for something, or a species of beast or whatever, to help diplomats.
e.g. on the page https://codecombat.com/i18n/glossary/objects (does not exist (yet))

Description
English
Translation

Gem (awarded by game)
Gem
Juvel

Hero (protagonist)
Hero
Helt

And perhaps on the page https://codecombat.com/i18n/glossary/places

Description
English
Translation

Hilderbalad (in third campaign)
Hilderbalad
Hildeballade

The Frozen Forest
The Frozen Forest
Den forfrosne skog

A cheat-sheet page where the whole glossary (all types of glossary) could be kept open in a browser tab (no-frills) so that I can "ctrl+f" my way around it, with my entire glossary would be very useful.

We have started putting these in the GitHub wiki here: https://github.com/codecombat/codecombat/wiki/i18n#glossaries


Replace deprecated nerd font icons

Thank you for your contribution, was wondering why some nerd font symbols went missing (for example on my polybar)


chore(master): release 1.24.0

:robot: I have created a release beep boop
1.24.0 (2023-09-15)
Features

指令 (22f0292)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/KYX1234/Element-Admin/releases/tag/v1.24.0 :sunflower:


Add ResNet example

Supports ResNet 101 V2 from TFLite and ResNet 50 V2 from ONNX.
Fixed #7.

@huningxin, PTAL, thanks! I will add the preview once the corresponding test-data PR landed.

test data PR merged @Honry

@huningxin, thanks! Please check the preview https://honry.github.io/webnn-samples/image_classification/.

@huningxin, I've combined the buildLinearBottleneck1_ and buildLinearBottleneck2_ into buildBottleneckV2_, PTAL, thanks!


Remove service status check

Running steampipe --version is enough to verify that the steampipe binary is installed and available. Running steampipe service status is unnecessary.
This removes the need to tie the test to Error outputs which undergo continual improvements.
The output of steampipe --version has been frozen and will continue to remain in the same format for subsequent versions.
Plus, steampipe --version always exits with an exit code of 0

this got resolved now, closing this pr.


How to execute tests without Selenium hub

Hello
This is not a ticket. Just a question, since i didn't find where to ask questions.
When we configure Carina we need specify <selenium_host> property. Is there a chance to run a test on local selenium standalone specified in path? Or we always need make up hub?
P.S. As an improvement would be nice if you guys could do group on https://gitter.im/ and redirect there everybody, who has question, instead of creating tickets for question.
Thank you

there is easy way to setup full test automation solution in one click using docker, selenoid etc.
No need to support direct web driver creation which require extra configuration steps on local machine


Fixes RxAutoCompleteTextViewTest.itemClickEvents() test.

I managed to get the failure on this test when testing on the mobile device (Nexus 5) in landscape mode. The keyboard would fully cover the screen and drop-down list was not visible.
If tests run well it's the same problem on Travis CI as well.
Fixes #183.
EDIT: Guess that's not the problem, will look into it more.

Was a good thought though! The emulator should always be in portrait for CI.

@JakeWharton there you go, I guess the drop-down list doesn't fully encompass all of the elements.

Aha! Well done!


Greet

The picture above contains 2 forms. One for a simple greet (it takes in a name and prints it below with a static message prepended to it). The other takes in a number and returns the value squared.


Honey Fluid Cow makes bucket disappear

Using Java 8 Runtime
Forge 36.2.2
MC 1.16.5
When a honey fluid cow spawns. it does not provide a honey bucket. Using the honey bucket on it just causes the bucket to literally vanish.
Referencing an earlier comment on CurseForge saying that thermal series does not have a honey fluid, I hope these screenshots are more than enough proof that Thermal Series does indeed add a honey fluid.

Here is a recording:
https://youtu.be/UQHq5mr4fY4

Hi. Indeed Thermal series has a Honey Fluid but is present on the CofhCore library mod.
The disappearing Bucket is a bug in Random Fluid Cows and the cause is the fact that CofhCore fluids don't have a bucket version for the Fluids.
The bug is fixed in f47edb6, but your honey cow can't give you a Honey Bucket because the game doesn't have one.
I have two solutions for this problems:

I remove all the fluids that doesn't have a Bucket version and the game won't spawn cows with that fluid;
I add buckets when the fluid doesn't have one.

Let me know what is the best solution for your case.
Meanwhile I will open an issue to know if it's supposed to have a bucket version of Honey in CoFHCore.

Update:
I asked on discord and a moderator said this.

For solution 1, it is simplistic and from the surface level it does seem like the obvious way to go since the purpose of collecting fluids from cows is to use them in crafting recipes. In my case, since Thermal devs intentionally did not make a honey bucket so there would be not much use of a honey bucket in-game if there are no recipes that could use a bucket of honey. Adding a bucket for a fluid that does not originally have a bucket might (not necessarily will) create bugs for the concerned mod. From a programming perspective, solution 1 also seems easier to implement.
Personally, I prefer option 2 since it opens up more possibilities for customization (by manually adding a use for the bucket with the fluid through datapacks/crafttweaker, tho this is already the job of the modpack creator) and the fluid cows can then be used an actually viable alternative source for the fluid in question, such as honey. So that instead of searching for a beehive, it would be viable to capture a fluid cow. This makes gameplay less linear and makes the gameplay a little bit more interesting & fun by providing other ways to acquire resources.
Both solutions are fine for me, so I leave it to your discretion on which would make more sense.

I have the same opinion on both, that's why I asked you 😅
I may implement the solution 2 with a config to disable generated fluid buckets. I probably have time to upload the new version today on curse.

Fair enough I guess. Implementing the best of both worlds would give the benefits of solution 2 while having a failsafe from option 1 in case any bug/conflict with another mod arises.

Would the fix implemented here be ported to MC 1.16.5?

Unfortunately not. I originally develop this feature to 1.17 and didn't update it due to lack of time. Now with some time I ported it to 1.18 but isn't viable to backport it to 1.16. Sorry.


q: Does the wiki / FAQ contain information on how to publish this site for evaluation ?

Probably a dense question, I presume there's a simple answer as to how to publish this on an internal QA web instance to poke around and try it out ?

@2ndRecon the website is built using aws-cdk. You can deploy a fully functioning copy of this website by running yarn install and yarn workspace @mvsp/aws run cdk deploy --all. The running cost of it is around $0 to $1.1 a month depending on your AWS free tier usage.
You would have to change ZONE_NAME to your DNS zone and hostnames for the website.
If you just want to run a website on your localhost, then run yarn dev and it will start on port 5000.


error with mods

removing create unlimited fixed it
crash-2023-08-31_17.38.41-fml.txt

Please use the issue templates that I put so much effort into making that I have provided for you.

wait a minute they dont actually exist, hold on

they exist now. Please use.


Clicking on image does not go to hentai page.

All of a sudden, today, I was unable to open up a hentai page from clicking on the cover at the search window, I tried uninstalling and using the older version I was using but nothing worked anymore

NHentai changed the site behaviour, I will need to rewrite some code


Pull Request

Hi Farid,
I think that I need to create a pull request so that the repository appears on my profile page, and so that my contributions show up. Can you please accept this request?
Thanks!
  I
can reject this request or you can close it.
Susan
http://www.drsusansim.org
Twitter: @benevolentprof
Skype: benevolentprof
Cell:<PHONE_NUMBER>
On Sun, Oct 4, 2015 at 2:09 PM, Marcos<EMAIL_ADDRESS>wrote:

Hi Farid,
I think that I need to create a pull request so that the repository
appears on my profile page, and so that my contributions show up. Can you
please accept this request?
Thanks!
Marcos
You can view, comment on, or merge this pull request online at:
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4
Commit Summary

Initial commit
created exercise1 file
created exercise files
added my name
test push
this time i am committing to y changes
Merge remote-tracking branch 'origin/master'
added shares
added cost & author
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
Lab 1 Assignment
Lab 1 Assignment: link to multi-sided shapes
Lab 1 Assignment
testing pycharm+github
Merge remote-tracking branch 'origin/master'
Lab 1 Assignment
Lab 1 Assignment
prompt for user input
if, elif, else functions
function revised
assignment 1 revision - separate numeric and word, ie. "3" & "three"
assignment 1 revision - separate numeric and word, ie. "3" & "three"
Ask user for number of sides.
additional functions
added double quotations

File Changes

M README.md
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-0
(5)
M exercise1.py
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-1
(38)
M exercise2.py
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-2
(57)
M exercise3.py
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-3
(7)

Patch Links:

https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.patch
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.diff

—
Reply to this email directly or view it on GitHub
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.

Hi Prof. Sim,
Sorry about that. I just closed the request.
I was trying to send the pull request to my partner, Farid's fork, so I could create my repository (missing from my profile page - please see attached). Is it necessary for me to do this, or is it fine to keep pushing commits to his repo? The good news is that my commits are showing on the repo that he created.
Thanks,
Marcos

From: Susan Elliott Sim<EMAIL_ADDRESS>Sent: October 4, 2015 2:33 PM
To: benevolentprof/inf1340_2015_asst1
Cc: Marcos Armstrong
Subject: Re: [inf1340_2015_asst1] Pull Request (#4)
Marco,
You're trying to commit to my repo.  I
can reject this request or you can close it.
Susan
http://www.drsusansim.org
Twitter: @benevolentprof
Skype: benevolentprof
Cell:<PHONE_NUMBER>
On Sun, Oct 4, 2015 at 2:09 PM, Marcos<EMAIL_ADDRESS>wrote:

Hi Farid,
I think that I need to create a pull request so that the repository
appears on my profile page, and so that my contributions show up. Can you
please accept this request?
Thanks!
Marcos
You can view, comment on, or merge this pull request online at:
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4
Commit Summary

Initial commit
created exercise1 file
created exercise files
added my name
test push
this time i am committing to y changes
Merge remote-tracking branch 'origin/master'
added shares
added cost & author
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
Lab 1 Assignment
Lab 1 Assignment: link to multi-sided shapes
Lab 1 Assignment
testing pycharm+github
Merge remote-tracking branch 'origin/master'
Lab 1 Assignment
Lab 1 Assignment
prompt for user input
if, elif, else functions
function revised
assignment 1 revision - separate numeric and word, ie. "3" & "three"
assignment 1 revision - separate numeric and word, ie. "3" & "three"
Ask user for number of sides.
additional functions
added double quotations

File Changes

M README.md
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-0
(5)
M exercise1.py
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-1
(38)
M exercise2.py
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-2
(57)
M exercise3.py
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-3
(7)

Patch Links:

https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.patch

https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.diff

Reply to this email directly or view it on GitHub
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.

Reply to this email directly or view it on GitHubhttps://github.com/benevolentprof/inf1340_2015_asst1/pull/4#issuecomment-145371543.
Pull Request by rossvalera · Pull Request #4 · benevolentprof/inf1340_2015_asst1 · GitHub
Hi Farid, I think that I need to create a pull request so that the repository appears on my profile page, and so that my contributions show up. Can you please accept this request? Thanks! Marcos
Read more...https://github.com/benevolentprof/inf1340_2015_asst1/pull/4#issuecomment-145371543

It's fine to make commits. Pull requests and patches are not necessary.
http://www.drsusansim.org
Twitter: @benevolentprof
Skype: benevolentprof
Cell:<PHONE_NUMBER>
On Sun, Oct 4, 2015 at 3:13 PM, Marcos<EMAIL_ADDRESS>wrote:

Hi Prof. Sim,
Sorry about that. I just closed the request.
I was trying to send the pull request to my partner, Farid's fork, so I
could create my repository (missing from my profile page - please see
attached). Is it necessary for me to do this, or is it fine to keep pushing
commits to his repo? The good news is that my commits are showing on the
repo that he created.
Thanks,
Marcos

From: Susan Elliott Sim<EMAIL_ADDRESS>Sent: October 4, 2015 2:33 PM
To: benevolentprof/inf1340_2015_asst1
Cc: Marcos Armstrong
Subject: Re: [inf1340_2015_asst1] Pull Request (#4)
Marco,
You're trying to commit to my repo.  I
can reject this request or you can close it.
Susan
http://www.drsusansim.org
Twitter: @benevolentprof
Skype: benevolentprof
Cell:<PHONE_NUMBER>
On Sun, Oct 4, 2015 at 2:09 PM, Marcos<EMAIL_ADDRESS>wrote:

Hi Farid,
I think that I need to create a pull request so that the repository
appears on my profile page, and so that my contributions show up. Can you
please accept this request?
Thanks!
Marcos
You can view, comment on, or merge this pull request online at:
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4
Commit Summary

Initial commit
created exercise1 file
created exercise files
added my name
test push
this time i am committing to y changes
Merge remote-tracking branch 'origin/master'
added shares
added cost & author
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
calculated total cost, before commission
Lab 1 Assignment
Lab 1 Assignment: link to multi-sided shapes
Lab 1 Assignment
testing pycharm+github
Merge remote-tracking branch 'origin/master'
Lab 1 Assignment
Lab 1 Assignment
prompt for user input
if, elif, else functions
function revised
assignment 1 revision - separate numeric and word, ie. "3" & "three"
assignment 1 revision - separate numeric and word, ie. "3" & "three"
Ask user for number of sides.
additional functions
added double quotations

File Changes

M README.md
<
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-0>
(5)
M exercise1.py
<
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-1>
(38)
M exercise2.py
<
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-2>
(57)
M exercise3.py
<
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4/files#diff-3>
(7)

Patch Links:

https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.patch

https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.diff

Reply to this email directly or view it on GitHub
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4.

Reply to this email directly or view it on GitHub<
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4#issuecomment-145371543

.

Pull Request by rossvalera · Pull Request #4 ·
benevolentprof/inf1340_2015_asst1 · GitHub
Hi Farid, I think that I need to create a pull request so that the
repository appears on my profile page, and so that my contributions show
up. Can you please accept this request? Thanks! Marcos
Read more...<
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4#issuecomment-145371543

—
Reply to this email directly or view it on GitHub
https://github.com/benevolentprof/inf1340_2015_asst1/pull/4#issuecomment-145378927
.


PLEASE DO NOT APPROVE - bug bounty testing - please ignore. bupcet

PLEASE DO NOT APPROVE - bug bounty testing - please ignore. bupcet

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


BatteryPool should log when outages end

When a battery/inverter pair is marked as NOT_WORKING,  there is a log like indicating that some downtime is starting.  But it doesn't explicitly log when this outage ends and the components are marked as WORKING again.  This needs to be improved.

I am not sure that's true. I see the WORKING status as well
2023-07-28 08:32:34,027,27 WARNING  [_battery_status.py:274] Inverter 248 stopped sending data, last timestamp: 2023-07-28 08:32:33.007461+00:00
2023-07-28 08:32:34,027,27 INFO     [_battery_status.py:284] battery 23 changed status Status.NOT_WORKING
2023-07-28 08:32:34,031,31 INFO     [_battery_status.py:284] battery 23 changed status Status.WORKING
2023-07-28 08:32:34,032,32 WARNING  [fcr_balancing_actor.py:272] Ignoring battery Capacity value of None.
2023-07-28 08:32:34,032,32 WARNING  [fcr_balancing_actor.py:259] Ignoring battery SoC value of None.

Oh right,  I wrote it incorrectly.  I guess I was thinking of inverter stopped sending data -> inverter started sending data,  not just the state machine changes.
Because both inverter and battery could go into error state, and if one of them recover, there won't be a log.


本地开发的时候会报错SocketException (SocketException: Connection failed (OS Error: No route to host, errno = 65), address = xxxx, port = 8080)

Affected version
0.16.0
Flutter versions
3.13.8
No same issues found.

[X] Yes, I search all issues but not found.

Steps to Reproduce
SocketException (SocketException: Connection failed (OS Error: No route to host, errno = 65), address = <IP_ADDRESS>, port = 8080)
Code example
child: WebF(             bundle: WebFBundle.fromUrl(                 'http://<IP_ADDRESS>:8080/xxx'),             javaScriptChannel: javaScriptChannel,           ),
Expected results
正常页面展示
Actual results

检查网络问题


I can't install

Type: Bug
I can't install any extension
VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: Yes

Hi @AdKemi
Thank you for opening the issue. Sorry to hear you are experiencing the issue, It appears to be specific to VS Code editor and tools. It is best to reach out VS Code team at https://github.com/microsoft/vscode/issues.
-VS Marketplace Team


[Tidy] Reduce bar width in chart template

Description

Reduce default bar width in Vizro chart templates to follow data viz best practices
Remove redundant template configurations (e.g. go.Table, bar specific configurations)

Note: Based on this issue https://github.com/mckinsey/vizro/issues/673 I've initially raised, it's important to understand  that template.data.XXX impacts both go.Figures and px charts. However, we configured it incorrectly, which is why our specified bar width didn't take effect.
Another point to note is that px charts can override certain settings from the template, such as the legend_title_text. From my observations, they also override the titles and values of the x/y axes, the legend title and the overall color sequence. This means that any specifications within the template unfortunately don't apply. Consequently, I've removed the configuration for the legend title since it had no effect (by default, it's turned off for go.Figures).
I'll redo the screenshots after this has been merged: https://github.com/mckinsey/vizro/pull/669
Otherwise I have to redo them again 😬
Screenshot
Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

For reviewers:
This is the example from the main branch:

And this is from the feature branch:

Seems like that change on the bar width doesn't work well on the px.bar if the data is not aggregated. If I can't get both working, I might have to undo the bar width change 😢 , but the template removal will stay

Okay, I went into the go.Bar source code and it seems like we shouldn't set the bar.width inside the template. What previously worked fine for a categorical x-axis, doesn't work anymore for a numerical x-axis, and it's because the width is defined in "position axis units" so needs to vary depending on the x-axis scale. Fixing it inside would therefore only look good on a categorical axis, but not on a numeric one. Will therefore remove the setting of the bar width, but the rest stays 👍


style:add color to heading

Pull Request Type
What kind of change does this PR introduce?
[X] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
I am adding color to the heading.
Issue Number: #1595
What is the new behavior?
The heading has red color.
Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


HATEOAS JSON output doesn't have right links for collection

The json output of the links differ quite a bit from the single entity object. If I use the implementation in this example. I get the json output like this:
{
      "content":"Hello, User!",
      "_links":{
      "self":{
              "href":"http://localhost:8080/greeting?name=User"
       }
   }
}

But moment I change the output to a collection(refer the code below):
  @RequestMapping("/greeting/{name}" )
    public HttpEntity<List<Greeting>> greeting(@PathVariable(value = "name") String name) {

        Greeting greeting = new Greeting(String.format(TEMPLATE, name));
        greeting.add(linkTo(methodOn(AuditHistoryController.class).greeting(name)).withSelfRel());

        List<Greeting> greetings = new ArrayList<>();
        greetings.add(greeting);

        return new ResponseEntity<>(greetings, HttpStatus.OK);
    }

The output json is quite different. Refer the change in links
[
{
    "content": "Hello, User!",
    "links": [
        {
            "rel": "self",
            "href": "http://localhost:8899/risk-portal/api/greeting/User",
            "hreflang": null,
            "media": null,
            "title": null,
            "type": null,
            "deprecation": null
        }
    ]
}
]

That's because you are returning a List. Spring HATEOAS only applies its serialization strategies to return types like ResourceSupport and it's subclasses (Resource, Resources, and PagedResources).
If you did this:
return new ResponseEntity<>(new Resources(greetings), HttpStatus.OK)

...it should yield a HAL document.


docs: add community documentation

This PR introduces:

Issue templates for bug reports and feature requests
Pull request template
Code of conduct, which reuses the content from angular/angular
Guidelines for contributing to the project
A development document which explains how to get started with fixing
issues/implementing new rules. There's more work here, this is just the
initial draft
Update of the readme to introduce project scope

Hmm, maybe the .github folder should not be synced internally at google3? The plus side is you can merge those changes directly on github. The minus is that you couldn't change those files atomically in the same commit with files that are synced.

I'd vote for syncing everything to google3 so that we follow the same process for all PRs.


port change

hello sir i m using nginx on port :80 how chan i start your script on another port
i use - p option but its not working

For Dev environment you can change the port in src/configs/dev.config.ts
And for production environment you can add an env variable PORT = 8000 or whichever port you prefer


questions about image shape

Hi,
I am now training micro-sam with a custom dataset. The shape of my raw imags is HxWx3 and the label's shape is HxW. I found an error  "File "/home/jovyan/.conda/micro-sam/lib/python3.10/site-packages/torch_em/data/segmentation_dataset.py", line 61, in init
assert shape_raw == shape_label, f"{shape_raw}, {shape_label}"
AssertionError: (2048, 3), (2048, 2048)".
I am confused with this error. Please give me some tips why it happens and how to solve it.

Hi @JIBSN,
I hope the issue is fixed now. I'll go ahead and close this for now. Feel free to reopen this if the issue persists or you want to discuss something similar in the lines of the aforementioned issue.


[Test Suite] merge test file

Description
To make it clear that other test files are importing macro.rs and tester.rs, they have been merged into a folder called tester.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 97.922%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
31188

Relevant Lines:
31850

💛  - Coveralls


Added unique key policy support to spring data SDK

Description

Closes https://github.com/Azure/azure-sdk-for-java/issues/15928

Added unique key policy support to spring data SDK

How customers will use it ->

@Container
@CosmosUniqueKeyPolicy(uniqueKeys = {
    @CosmosUniqueKey(paths = {"/lastName", "/zipCode"}),
    @CosmosUniqueKey(paths = {"/city"})
})
public class CosmosUniqueKeyPolicyCodeSnippet {

    @Id
    String id;

    @PartitionKey
    String firstName;

    String lastName;
    String zipCode;
    String city;
}

How the annotations look like ->

/**
 * Represents the unique key policy configuration for specifying uniqueness constraints on items in the container in the
 * Azure Cosmos DB service.
 */
@Persistent
@Inherited
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
public @interface CosmosUniqueKeyPolicy {

    /**
     * Set of unique keys which enforce uniqueness constraint on items in the container
     * in the Azure Cosmos DB service.
     *
     * @return unique keys
     */
    CosmosUniqueKey[] uniqueKeys() default {};
}

/**
 * Represents a unique key on that enforces uniqueness constraint on items in the container in the Azure Cosmos DB
 * service.
 *

 * 1) For containers, the value of partition key is implicitly a part of each unique key.
 *

 * 2) Uniqueness constraint is also enforced for missing values.
 *

 * For instance, if unique key policy defines a unique key with single property path, there could be only one item that
 * has missing value for this property.
 *
 * @see CosmosUniqueKeyPolicy
 */
@Persistent
@Inherited
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
public @interface CosmosUniqueKey {

    /**
     * A set of paths which must be unique for each item in the Azure Cosmos DB service.
     *

     * The paths to enforce uniqueness on. Each path is a rooted path of the unique property in the item, such as
     * "/name/first".
     *
     * @return unique paths
     */
    String[] paths() default {};
}

/azp run java - cosmos - tests


General Issue: create_blogpost.R checks for and installs packages

Background Information
@StefanThoma and @manciniedoardo what do you all think about check and installing packages when you create a blog post.  could just be another helper file that create_blogpost calls??
packages to install

Helper program to check and install packages
check_and_install <- function(packages) {
for (package in packages) {
if (!require(package, character.only = TRUE)) {
install.packages(package, dependencies = TRUE)
library(package, character.only = TRUE)
} else {
message(paste(package, "already installed"))
}
}
message("Let's program some ADaMs!")
}
Use the function
check_and_install(c(
packages here...
))

sounds like a great idea @bms63 !

god...teal has so many dependencies...

Why not renv?

I am always weary of renv it made working on admiral unnecessarily challenging for new folks.
having just installed teal and mirai and I wondering if there is a way to not have to install them for new posers - just takes forever.  guess the docker image could be handy????

I wonder if there is a way where only a select few blogposts render, plus the new one?
That way they can test their blog, and when uploaded everything renders.

Yeah I always temporarily delete ~40 posts to render the website!

I see two options: r-lib/actions/setup-r-dependencies OR r-lib/actions/setup-renv
r-lib/actions/setup-r-dependencies:

this requires a DESCRIPTION file to read the dependencies from. You might create a dummy DESC file - it does not have to become a package. We are currently doing this trick in pharmaverse/examples. Please have a look at its DESCRIPTION file and how the action look like and its results.
this is super fast because it is using PPM and install from binaries (instead of from source) plus it has in-build caching. Once downloaded, it would stay in cache and you won't repeat the download (unless there is a new version or cache removed). Have a look at the latest result here - ℹ No downloads are needed.

r-lib/actions/setup-renv:
This unfortunately I have never used so can't share my experience. I just know that it exists.
By any means - I do not recommend to maintain a list of packages with its dependencies (!). Some of those packages are still under development and the dependencies are in scope of a change. Let it be identified automatically. There are tools for that. And let it be a low maintenance thing from our side. (That's for mirai package discussed here - you should not care about that :) )
The list you showed is of good size to be putted in the dummy DESC file. I have all the positive experience with setup-r-dependencies so I would suggest this.

Thanks @pawelru - I agree we should move to a package-like structure and take advantage of some of these r-libs actions.
I am also interested in making blog contributors have a really easy time writing a post and looking at ways to help minimize setup and headaches for them.  I am assuming a completely newb-like person here!


Data attributes on ajax call

Hi,
I try to add a data-attribute on my option tag on a ajax call but I can't.
    processResults: function (data) {
       return {
          results: $.map(data, function (item) {
                return {
                    text: item.text,
                    'data-tag': item.anotherValue,
                    id: item.id
                };
            })
        };
      },

If you're dealing with AJAX, you have full control over the data objects. So you don't need to include data- in front of things, the names will be included just like id and text normally are.


Try to reduce the number of notifications on edit when filtered views of the diagram is used

Asked in DID 9162 (Confluence 8.4.0 and drawio 12.0.7)

This correction is important to users because you can not watch Confluence pages with filtered draw.io pictures. Updating draw.io picture generates  multiple email notifications to users email e.g. in our case  1 update generated 14 email notifications.


postcss-conditionals:  Failed to parse expression

Container#eachAtRule is deprecated. Use Container#walkAtRules instead.
Your current PostCSS version is 5.2.0, but postcss-conditionals uses 4.1.16. Perhaps this is the source of the error below.
postcss-conditionals:  Failed to parse expression
21 | $type: monster;
22 | p {
> 23 |   @if $type == ocean {
         |   ^
24 |     color: blue;
25 |   } @else if $type == matador {

You might want to update the plugin to the latest version to resolve the deprecation notices:
npm update postcss-conditionals

Secondly, please post your configuration. It's likely that you simply have your postcss plugins in the wrong order.

Sorry, made a mistake

I updated the plugin, but the error is not corrected.
Error:
Error in plugin 'gulp-postcss'
Message:
    postcss-conditionals: C:\...\_base.scss:22:2: Failed to parse expression

  20 |
  21 | @define-mixin box_shadow ($level) {
> 22 |  @if $level==1 {
     |  ^
  23 |          box-shadow: 0 1px 3px rgba(0, 0, 0, 0.12), 0 1px 2px rgba(0, 0, 0, 0.24);
  24 |  }

Details:
    fileName: C:\...\about-us.scss

gulpfile.js
var conditionals = require('postcss-conditionals');
var processors = [
	smartImport(),
	conditionals(),
	comments({ removeAll: true }),
	autoprefixer({ browsers: [...] }),
	short(),
	mixins(),
	nested(),
	extend(),
	vars(),
	clearfix(),
	mqpacker(),
	focus(),
	color(),
	cssnano({
		reduceIdents: false
	})
];

Versions
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Try this instead:
var conditionals = require('postcss-conditionals');
var processors = [
    smartImport(),
    vars(),
    conditionals(),
    comments({ removeAll: true }),
    autoprefixer({ browsers: [...] }),
    short(),
    mixins(),
    nested(),
    extend(),
    clearfix(),
    mqpacker(),
    focus(),
    color(),
    cssnano({
        reduceIdents: false
    })
];

Yes, everything is super. Thank you very much for your time.

No problem :)


Autocomplete input unselecting values after collapsing and opening again

Reproduction
https://formkit.link/663fb587035f4362856b35217473af18
Describe the bug
The bug happens in autocomplete input with multiple set to true. Steps to reproduce
1.Select 4 or more options in the input initially.
2.Collapse the dropdown
3.Reopen and the dropdown & select another item. You'll see that the one of last chosen item is unselected automatically.
This bug happens only in autocomplete-input, the dropdown-input seems fine.
Environment
• OS: Windows 11
• Browser: Chrome
• Version: Formkit 1.6.2 Pro 0.123.1

@rahman-anz I'm seeing that the value itself remains but that the truncation at the end of the input makes it appear to be removed. Can you confirm this is the behavior you're seeing?

@sashamilenkovic No, the value also disappears from the selected values. You can see it here clearly, where I am v-modeling the selected values
https://formkit.link/535e176c3d85e89db2c7594d32560b27

@rahman-anz I also am not seeing the described behavior. Could you provide a screen capture of the issue you are seeing?

@justin-schroeder You can see it here
https://jam.dev/c/61bb4a85-0dc2-442a-aa71-700632143f8c

@rahman-anz Oh, I see, appreciate the reproduction.
So, the autocomplete multi-text input (the one in question), has a unique feature where the values rendered within the text input itself become selectable. As in, clicking "REQUESTED" for example within the text input will actually perform a cursor selection on it. This allows for direct replacement, so the user can cursor-select a previously selected value and selection of a new value will replace it inline directly. The user can also traverse up and down values by using arrow keys.
Now, in your reproduction, it appears that you are clicking not the listbox button (the button to the right of the text input), but on the text input near the last selected value, resulting in the cursor selection, resulting in a direct replacement (the behavior you are seeing where a value appears to become deselected). I could be wrong about my assumption I'm making in your reproduction as it's a bit difficult to see where you're clicking.
So with all that being said, I am seeing one issue:
Steps to reproduce:
1). Select "Requested" and "Pending" from the autocomplete in the previous example.
2). While the listbox is still open, click the text "Requested" to perform the cursor-selection
3). Blur the text input to close the listbox. The cursor-selection is now gone.
4). Reopen the listbox by specifically clicking the listbox button the right of the input.
Assertion: You will see that the text "Requested" is again cursor-selected.
Conclusion: Cursor-selection memory should not be remembered in between opening and closing of the listbox itself.
@justin-schroeder Let me know if you agree with this when you have the chance.
@rahman-anz Let me know if you agree with my assertion about your reproduction if you click specifically the listbox button.

@sashamilenkovic Thank you. That was it 😆
Btw, do we have a prop to control/disable this cursor-selection ?

@rahman-anz There is not a prop for that currently. Have you checked out using the prop selection-appearance="option" or even maybe just using the taglist input instead?

@sashamilenkovic  I think taglist would fit in with our needs. Thanks guys for the prompt response.


Can someone help me understand how to create inference?

Anyway, I installed bark in WSL ubuntu in a conda env, I don't get how I'm supposed to do inference.
These commands don't work
from bark import SAMPLE_RATE, generate_audio
from IPython.display import Audio
text_prompt = """
Hello, my name is Suno. And, uh — and I like pizza. [laughs]
But I also have other interests such as playing tic tac toe.
"""
audio_array = generate_audio(text_prompt)
Audio(audio_array, rate=SAMPLE_RATE)

Nevermind, somehow the code doesnt mention "Python" before the commands in the repo.


Cache docker info and version

This is to reduce the load on docker daemon.
In some cases, frequent docker info calls could lead to the system failure (high CPU, out-of-memory) due to many GetTotalUsedFds goroutines stuck in getdents64 syscall. In addition, docker version calls exec to run OS commands for getting other binaries' version, this can also become a bottleneck on a busy node due to many goroutines contending a lock for forking a new process.
This PR caches docker info for 1 minute and tries best to get docker version from the cache.

Also add version info in logs on starting.

The FS information is wildly incorrect anyway, and has been for years (ever since storage was moved)

@vikramhh
The main usage of docker info is getting the docker root dir (another usage is getting supported logging drivers, while cri-dockerd only supports json logging driver currently and docker supports it by default, so this is not a concern)
Changing docker root dir needs restarting docker daemon. On Linux, we configure the cri-dockerd service to depend on docker service, restarting docker service will restart cri-dockerd service too. So there's no stale data for docker root dir if we use cri-dockerd in this way.
I don't know how other softwares use cri-dockerd, if docker root dir changes and cri-dockerd does not restarts, then there will be stale data for 1 minute with this PR. It affects the reported ImageFsInfoResponse and ContainerStats in regard to FilesystemIdentifier of FilesystemUsage. Would it be a serious issue?

@xinfengliu - thanks for the details above, in light of which I am OK with the change as-is.

@afbjorklund

The FS information is wildly incorrect anyway, and has been for years (ever since storage was moved)

Yeah, we should fix it. Do you know if there's any existing github tickets for it in either this repo or kubernetes repo? I seem to not able to find it.
In addition, I'm not sure what's the best way to fix it. According to the definition of UsedBytes represents the bytes used for images on the filesystem.  For most used overlay2 graph driver, docker uses overlay2 dir to store layers, but it also contains RW layers of containers. Maybe we should iterate /var/lib/docker/image/overlay2/layerdb/sha256/ to read each size file under it.

Most of CRI is only defined by the implementations, and those are not being tested.
I don't know if there are any issues open, or even where those would be at...


@ViewChild returns undefined in unit tests with material components

Bug:
When I try to access to a material component using @ViewChild from the unit tests I recieve undefined. If I use  @ViewChild('element') element: ElementRef; all is fine, but if I use for instance  @ViewChild('prompt') prompt: MdSlideToggle; the  'prompt' value is undefined. I need to use MdSlideToggle instead of ElementRef because I need to access to the specific properties of the component.
What is the expected behavior?
The component accessed through the @ViewChild decorator should be visible in the unit tests.
What is the current behavior?
The component accessed through the @ViewChild decorator is undefined in the unit tests.
What are the steps to reproduce?
Create the following:

html:

<md-slide-toggle #prompt></md-slide-toggle>

ts:

@ViewChild('prompt') prompt: MdSlideToggle;
Now create a simple unit test and try to access to the 'prompt' element. The value is undefined.
What is the use-case or motivation for changing an existing behavior?
Because the angular material components should be accessible from the unit tests like the common html components.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular: 4.3.6
Material: 2.0.0-beta.10
Windows 10
TypeScript: 2.4.2
All browsers

This is specific to Material? If you use ViewChild to access any other component (not just elementRef), does it work?

Yes. If I try to access to a custom component created by me the result is correct. I am using in that case this:
@ViewChild('fromFilterValue') fromFilterValue: FilterValueComponent;
Where FilterValueComponent is my custom component.

@franpsif Can you provide an example test that this fails for?
I was able to use the ViewChild to reference a material component in a test as expected.
import {Component, ViewChild} from '@angular/core';
import {ComponentFixture, TestBed, async} from '@angular/core/testing';
import {MdSlideToggleModule, MdSlideToggle} from '@angular/material/slide-toggle';

describe('Test Component', () => {
  let fixture: ComponentFixture<TestComponent>;

  beforeEach(async(() => {
    TestBed.configureTestingModule({
      imports: [MdSlideToggleModule],
      declarations: [TestComponent]
    });
    TestBed.compileComponents();
  }));

  beforeEach(() => {
    fixture = TestBed.createComponent(TestComponent);
  });

  it('will have the both `ViewChild`s defined', () => {
    expect(fixture.componentInstance.myToggleByTemplateRef).toBeDefined();
    expect(fixture.componentInstance.myToggleByComponentRef).toBeDefined();
  });
});

@Component({
  template: `

This has a slide toggle in it

      <mat-slide-toggle #myToggle></mat-slide-toggle>

  `
})
class TestComponent {
  @ViewChild('myToggle') myToggleByTemplateRef: MdSlideToggle;
  @ViewChild(MdSlideToggle) myToggleByComponentRef: MdSlideToggle;
}

There's nothing in Angular Material that affects how the components are queried. Any issues would be something specific to your app/test

Yes, finally it was an error in our code, Sorry for that and thank you for your time.

using @ViewChild from the unit tests I receive undefined

Just to leave a comment, in case others get here from a google search.
In unit tests if your test component has an incomplete template, or have an html syntax error, it will get past compiling the component (it will pass the truthy test) and any View/Conent child/ren variables will be undefined.

Hello Guys, I need bit help in unit testing. It would be nice if someone can help me to write the unit test for slider and few other components. I can pay a small amount for it.. Thank you


vulnerabilities in imagemin-* libs

I know imagemin is a dependency of this project, but imagemin's current version doesn't have those vulnerabilities. Thanks

@Dhana-Krishnasamy let's update :+1:

sure... looks like its already being worked at: https://github.com/itgalaxy/imagemin-webpack/pull/55
besides, there are other dependencies those are dependent on vulnerable tunnel-agent <v0.6.0

@Dhana-Krishnasamy better create issue in their repo, I can not do anything here.


Logs Assets - Align mongodb integrations with logs-backend

What does this PR do?
Align mongodb integrations with logs-backend
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@pbeaudequin do you need help merging?


Deleted a coolest test file.

I see @nkhadka21. Can you make an issue such that we can keep track of this? Thank you!

I see @nkhadka21. Can you make an issue such that we can keep track of this? Thank you!

@sibirrer , coolest addressed my issue and I added coolest_slsim_interface with test functions!


Fixed navbar for mobile screen (specially for open-source section)

Fixes Issue
Closed #832
Changes proposed
Navbar width is fixed for open-source category
Screenshots

Note to reviewers
I have made changes according to issue mentioned in issue #832. Please merge it with main branch

@kedar1998 are you still working on this?

@rupali-codes Deleted pnpm-lock.yaml file


DOMNodeInserted

Describe the bug
quill.js:4237 [Deprecation] Listener added for a 'DOMNodeInserted' mutation event. Support for this event type has been removed, and this event will no longer be fired.
Reproduction
no
System Info
no

Used Package Manager
npm
Validations

[X] Read the the documentation in detail.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Were you able to fix it?


Update README.md

Pull Request Template
Explanation Video
Description
This PR adds the updated readme to the repo.
Fixes # (readme)
New info added to readme
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Adding the screenshot is incredibly helpful, and I believe it makes the end result much clearer.


RC cherry picking PRs 845 852 853

[like]  Risto Rangel reacted to your message:

From: Adam Mollis @.>
Sent: Tuesday, July 16, 2024 11:03:47 PM
To: MixedRealityToolkit/MixedRealityToolkit-Unity @.>
Cc: Risto Rangel @.>; Assign @.>
Subject: Re: [MixedRealityToolkit/MixedRealityToolkit-Unity] RC cherry picking PRs 845 852 853 (PR #854)
Merged #854https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/854 into releases/2024-07-09.
—
Reply to this email directly, view it on GitHubhttps://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/854#event-13527899521, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUBWJNZNMUSZ5IXR4O7M6DDZMWRFHAVCNFSM6AAAAABK7OM3L2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGUZDOOBZHE2TEMI.
You are receiving this because you were assigned.Message ID: @.***>


[Bug]: vite build error

Describe the bug / 问题描述
x Build failed in 26.50s
error during build:
[commonjs--resolver]<EMAIL_ADDRESS>(3:16): "graphlib" is not exported by "node_modules/dagre/index.js", imported by<EMAIL_ADDRESS>Reproduction link / 复现链接
No response
Steps to Reproduce the Bug or Issue / 重现步骤
No response
G6 Version / G6 版本
🆕 5.x
OS / 操作系统

[ ] macOS
[X] Windows
[ ] Linux
[ ] Others / 其他

Browser / 浏览器

[X] Chrome
[ ] Edge
[ ] Firefox
[ ] Safari (Limited support / 有限支持)
[ ] IE (Nonsupport / 不支持)
[ ] Others / 其他

I have the same problem.May i ask how it was ultimately resolved ？

I have the same problem.May i ask how it was ultimately resolved ？

I have the same problem. May I ask how to solve this? help help help， big lao
error during build:
[vite:worker-import-meta-url] node_modules/.pnpm/@antv+layout@1.2.14-beta.9_workerize-loader@2.0.2_webpack<EMAIL_ADDRESS>(3:16): "graphlib" is not exported by<EMAIL_ADDRESS>imported by "node_modules/.pnpm/@antv+layout@1.2.14-beta.9_workerize-loader@2.0.2_webpack<EMAIL_ADDRESS>

@hentailong @RBggdyy We will confirm the issue soon

I have the same problem also, is there a temporary solution?


[QUESTION] mobile offline geocoding

I hope it is OK to ask question here.
I am investigating the possibility of using Milli for offline mobile geocoding
The idea is this :

compile Milli for android and wrap.it through jni
generate a pre indexed database of geocoding doxuments

Presented like this it seems doable. But there are some questions and would love to have the team opinion befaure rushing into this:

i saw some numbers of 20mb memory usage with already indexed database. is that correct?
wondering about the size the database would be. is there any comparison we can do between the json representation of the database and the database itself in terms of size?
I know you have some Geo functions. could it handle filtering in a bbox ?
does that seem like a good fit to you?

Thanks for that amazing project

Hey @farfromrefug,

generate a pre indexed database of geocoding doxuments

What do you mean by pre-indexed? Is this something that milli will need to index or as it been already indexed by milli, and you are taking a snapshot (i.e. a copy of the already indexed file), here?

i saw some numbers of 20mb memory usage with already indexed database. is that correct?

Milli is entirely based on LMDB, which is a memory-mapped key-value store. Memory mapping is a technology that let the OS choose between loading pages from the disk in memory based on the available amount of memory and the usage of the pages. The memory usage that you could see is either the Rust program itself when functioning or the virtual memory usage (due to the memory mapping). In short: the OS can use the whole memory if it evaluates that it is more performant to do so but it will automatically release it if other programs need it.

wondering about the size the database would be. is there any comparison we can do between the json representation of the database and the database itself in terms of size?

It is, unfortunately, very hard to evaluate the amount of disk space that will be used by the engine, you can probably do some tests and graph with your own data.

I know you have some Geo functions. could it handle filtering in a bbox ?

I don't think so, you should look at the documentation, but I think this is something that we wanted to implement at some point. You can use the product repository to ask for specific features.

does that seem like a good fit to you?

A good fit for doing searches without calling the HTTP server? Yeah, but keep in mind that it hasn't been developed for such use cases and therefore the documentation of this library is not very good. Milli is the core of Meilisearch and is kind of hidden inside.

@Kerollmops First thank you for taking the time to answer me.

What do you mean by pre-indexed? Is this something that milli will need to index or as it been already indexed by milli, and you are taking a snapshot (i.e. a copy of the already indexed file), here?

yes i am talking about a snapshot that i would prepare in advance and then push on the phone. The idea is for milli to have everything ready.

A good fit for doing searches without calling the HTTP server? Yeah, but keep in mind that it hasn't been developed for such use cases and therefore the documentation of this library is not very good. Milli is the core of Meilisearch and is kind of hidden inside.

Yes the idea is to have something running as a lib and thus without an http server. Which is why i looked at milli directly. I know documentation is not "made for this" and i understand i would have to dig and test for myself.
This is also the reason i asked here first before going deep into it.
I think i l close this issue as you answered my questions. Though i might be asking a few more questions in the future if i have a go at this ;)
Thanks again


Ujson: decoding floating infinite and NaN values

Ujson already supports encoding Double.PositiveInfinity,
Double.NegativeInfinity, and Double.NaN (as the strings
"Infinity", "-Infinity", and "NaN" respectively). This just adds support
to also decode those values back into doubles.
See #890

Although I don't particularly like this solution, I like even less that we currently can't count on the client always deserializing server-serialized payloads.
I ran into this in a situation where we were packing JVM metrics using case class Metric(name: String, value: Double). We had a rather large payload which the the client interpreter would sometimes fail to decode due to a a NaN somewhere in one of the metrics (which we ironically weren't using).

I wonder why the 2.13 runs are timing out after 6 hours!

guess this should be fixed in ujson itself, though, what do you think?

This was my first instinct, but I'm not sure how it could be. What exactly would we want? We could request

that the string "Infinity" be parsed directly into ujson.Num (but that's a terrible idea since it might collide with legitimate string values).
that the ujson.Num extractor match ujson.Str("Infinity") implicitly, but then the order of the ujson.Str and ujson.Num cases in match on ujson could lead to subtly different behaviour (and warnings are bad on non-default extractors).

I think this code has to live somewhere where we have schema information about the fact we are expecting a Double/Float. Incidentally, upickle lives in that space and it handles the infinity + nan in its equivalent to JsonSchema too.

The Mima issue OK to add an exception for, right (looks just like an artifact of how Scala compiles concrete members in traits)?


[e2e]: maven workflow_dispatch main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5947721320
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Aug 23 06:15:38 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5960169492
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Aug 24 06:22:05 UTC 2023
Tests are passing now. Closing this issue.


Support Spring MVC and Spring Data non Reactive persistence

We could do that based on Arjen functional Servlet port. I was initially not sure about that one, but with Loom on the radar that makes sense. Also that would improve parity with regular Boot flavor.
To be decided if Spring MVC functional variant is part of Spring Framework 5.2 or incubated in Spring Fu like Coroutines support.

Since Servlet functional API is likely to become part of Spring Framework 5.2, I will contribute directly the Kotlin DSL on Spring Framework side, then we will leverage here the Boot support to configure it.

https://github.com/spring-projects/spring-framework/issues/22697 has been merged in Spring Framework master :tada:


LinearGradient throws exception when Diagnostic would be more appropriate

https://github.com/fusetools/fuselibs-public/blob/ac501d779d803b0c0b8694690ee233233bfb23f1/Source/Fuse.Drawing/Brushes/LinearGradient.uno#L139
Playing around with stop offsets in Studio encounters this very easily, killing the preview. We should make sure as few things as possible fail in this way; At worst, this should simply make the LinearGradient not render IMO

Yeah, this particular case should probably use Fuse.Diagnostics.UserError() instead.

Changed the title to reflect what is described in the ticket.


Auto Disable Accounts

Fixes #958
Creating a Draft PR to get help with code. Still need logic to disable the account in the database. There are comments in the code.

Run npm run lint:fix from the backend directory.

superseded by https://github.com/cisagov/crossfeed/pull/1532


fixes #139

Fixes npc linked holograms not updating properly with entity scale. This also implements a system where the hologram will also scale its size with the NPC.
Examples:
NPC Scale Of 2:

NPC Scale Of 0.1:

Thank you!


Add Windows Integrated Auth when possible. Default to long-lived PATs instead of JWTs when interactive is required.

@jmyersmsft @satbai @satishkumaarponnusamy

Thanks for the review @satbai. I don't have contributor permission, so (assuming there aren't other issues), could you please merge this?


[#5438] feat(iceberg): add view event for Iceberg REST server

What changes were proposed in this pull request?
Add view event for Iceberg REST server
Why are the changes needed?
Close: #5438
Does this PR introduce any user-facing change?
No
How was this patch tested?
unit test

@orenccl thanks for your work, LGTM except minor comments

@orenccl , merged to main, thanks for your work and figuring out the hidden bugs!


Adjustment

The PR is conflicting.

FichteFoll.
Should you delete the file package.json.
According to the guidelines of "wbond".
https://github.com/wbond/package_control_channel/pull/5742
I'm not able to correct the PR.

I will do it, depending on the outcome of wbond/package_control_channel#5742.

Ok. thanks.


patch is ignoring setter changes

I have a special setter for some properties, when I update the object passing patch: true only the properties passed to save method are store the rest are ignored
Model = BaseModel.extend({
  setProp: function(value) {
    // .. do things
    this.set('prop', value);
    return this;
  }
})

Model.forge({id: .1}).fetch({require: true})
  .then(function(model) {
    return model.setProp('...').save(null, {patch: true});
  });
  .then(function() {
     // prop is not stored in database
  });

Hi @rkmax. This is actually the designed behaviour of save(attrs, {patch: true}).
To get the effect you want you need to do this:
Model.forge({id: .1}).fetch({require: true})
  .then(function(model) {
    // Add `model.changed` as an argument.
    return model.setProp('...').save(model.changed, {patch: true});
  });
  .then(function() {
     // prop is not stored in database
  });

A similar confusion was noted in #698. My proposed fix was to update the docs to show the above as an example. But perhaps the API could be more expressive here.
I would like to deprecate the patch option to save and replace it with model.patch. The attrs argument could be done away with entirely, and model.changed could be used by default.
// the following all generate "update models set thing = 'something'"

// current:
model.set({thing: 'something'}).save(model.changed, {patch: true});

// proposed, defaults to `model.changed`:
model.set({thing: 'something'}).patch();

// still support current behaviour:
model.set({other: 'ignore'}).patch({thing: 'something'});

Does this feel more intuitive?

I think the more intuitive is the third one, remove {patch:true} from .save() and append a .patch() method

Right. And defaulting to model.changed seems sensible?

For .patch() method? No, I understand that the idea behind the .patch method is persist only the properties you are passing are arguments, right?

I understand that the idea behind the .patch method is persist only the properties you are passing are arguments

Well, that is the current behaviour of .save(attrs, {patch: true}), but both you and @FredKSchott (#698) assumed that the model would patch all changed attributes.
I actually think this is a reasonable expectation; I can't think of why one would want to set attributes on a model but not store them in an update query.

I think it's not necessary because in that case .patch will mimic .save

save() will save all set attributes on a model, not just those that have changed.
Also, if patch(attrs) was to replace save(attrs, {patch: true}) then there would be no longer be any use for the attrs argument to save.

Thinking about this more... Perhaps save should really be only updating changed attributes. Apparently this is how ActiveRecord works.

@rhys-vdw Totally agree with that. I never understood the point of saving every single attribute if they haven't changed. It's not even a breaking change AFAICT.

@ricardograca Cool, I think I agree. Although I wonder if it makes sense to move towards deprecating the attrs argument to save. It only seems useful in the context of patch, in all other situations set() does the job sufficiently, and can be chained.
model.set(attrs).save();
model.patch(attrs);

In the meantime we can still support save(attrs, {patch: true}) with a deprecation warning.

@rhys-vdw I like your suggestion. Setting values on the model and persisting changes back to a database are different and the API ought to reflect that.
I often find myself wanting to call set several times throughout application logic and then persist it all back once at the end (as a 'patch').

@abalmos That's actually the objective Bookshelf is currently aiming for: separating the model and the persistence layers to bring it more in line with the data-mapper pattern, so this proposed change makes sense.

Consider these points when revisiting this.

Consider this when making changes.

The project leadership of Bookshelf recently changed. In an effort to advance the project we close all issues older than one year.
If you think this issue needs to be re-evaluated please post a comment on why this is still important and we will re-open it.
We also started an open discussion about the future of Bookshelf.js here https://github.com/bookshelf/bookshelf/issues/1600. Feel free to drop by and give us your opinion.
Let's make Bookshelf great again


Adding picture to the example README

Feature Description
A picture must be added to examples/README.md for highway_ramps.
### highway_ramps.py

Example of a highway section network with on/off ramps

![](picture to be added)

@AboudyKreidieh do you have a picture for this?


OS X Ruby Issues

Couple of issues
There needs to be an extra step where user enters gcc into command line, to force OS X to install Developer Tools. This has to happen before gem install because, otherwise installation fails due to missing headers.
gem install github-pages should be sudo gem install github-pages. The step itself also takes a while without visual feedback, so a note should be made of that.
After installation is done, jeklly is not in PATH yet, so user should open new window/tab.

Added instructions on how to install Xcode Command Line Tools in #38 and the sudo part was added already back in #18
This gem install part has also been expanded to include info to wait, so I think all issues have been addressed.


Failed to create a ADLS directory using a SAS token

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az storage fs directory create
Errors:
The command failed with an unexpected error. Here is the traceback:
element indices must be integers
Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/multiapi/storagev2/filedatalake/v2020_02_10/_path_client.py", line 201, in _create
    return self._client.path.create(**options)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/multiapi/storagev2/filedatalake/v2020_02_10/_generated/operations/_path_operations.py", line 248, in create
    raise HttpResponseError(response=response, model=error)
azure.core.exceptions.HttpResponseError: Operation returned an invalid status 'An HTTP header that's mandatory for this request is not specified.'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 658, in execute
    raise ex
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 721, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 713, in _run_job
    return cmd_copy.exception_handler(ex)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/cli/command_modules/storage/__init__.py", line 371, in new_handler
    first(ex)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/cli/command_modules/storage/__init__.py", line 370, in new_handler
    raise ex
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 692, in _run_job
    result = cmd_copy(params)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/multiapi/storagev2/filedatalake/v2020_02_10/_data_lake_directory_client.py", line 162, in create_directory
    return self._create('directory', metadata=metadata, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/multiapi/storagev2/filedatalake/v2020_02_10/_path_client.py", line 203, in _create
    process_storage_error(error)
  File "/usr/local/Cellar/azure-cli/2.33.0/libexec/lib/python3.10/site-packages/azure/multiapi/storagev2/filedatalake/v2020_02_10/_deserialize.py", line 98, in process_storage_error
    additional_data[info] = error_body[info]
TypeError: element indices must be integers

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az storage fs directory create --file-system {} --name {} --connection-string {} --sas-token {}

Expected Behavior
Environment Summary
macOS-12.2.1-x86_64-i386-64bit, Darwin 21.3.0
Python 3.10.2
Installer: HOMEBREW

azure-cli 2.33.0 *

Additional Context

storage

Please provide either --connection-string or --sas-token(need to be used with --account-name), don't use them together.


Replace homepage gif

Thats a good question, I am not sure. (Left it there for now)

I feel now that it makes sense to remove the old gif, since we are not using it any more.
Added new commit to remove the old gif.


Why   animation element z-index will be changed      when I use velocity. js animation element z-index will be changed   such transition.slideLeftBigIn

Why   animation element z-index will be changed      when I use velocity. js animation element z-index will be changed   such transition.slideLeftBigIn ; It can not be covered ，Although the z-index is relatively small

Can you please create a JSFiddle recreating the issue using our template, which is available here:
http://jsfiddle.net/65xCP/4/
Once I can view the reduced test case, I can more effectively isolate and address your issue.

i saw the source code     scale /*   Chrome on Android has a bug ...... ensure that its first value is always 1*/

Are you sure it' the z-index changing? When animating a transform:translateZ(0); is added which moves the animation into the GPU making it far smoother (there's lots of information around proving the need for it) - but that takes the element out of the current z-index context and forces it to the front - have you tried adding mobileHA:false to your options?

Please try setting mobile acceleration to false.
Example:
$element.velocity(propertiesMap, { mobileHA: false });

Most of those problems occur because of the translateZ which is added during animation to hardware accelerate. You can deactivate this for specific animations to get rid of z-index problems.


added file deletion and more information

added file deletion
added more comments
save() now returns the path to the saved file

Hm, so #3 says that the input images aren't even stored on disk. Hence, we neither take input paths nor have to handle the deletion of the files, in my understanding.

i mean maybe? what is an image then?  @Freeze-FF @lukas-monet

Closing this, as it doesn't seem to be relevant anymore at this point


Incorrectly reporting SA1121 in Expression Bodied Function

I had an Expression Bodied Function creating an instance of of a type using an Object Initializer where one of the property names was Object. This incorrectly reporting SA1121 Use built-in type alias however the usage of Object was a property name rather than a type.
Changing the function to a normal method fixed the issue. See below
private ObjectVersionPair<DataAsset, DataAssetVersion> GetAssetVersionPair(AssetTemplates x) =>
    new ObjectVersionPair<DataAsset, DataAssetVersion>
    {
        Object = GetObject(x),
        Version = GetVersion(x),
    };

Reporting SA1121 Use built-in type alias
private ObjectVersionPair<DataAsset, DataAssetVersion> GetAssetVersionPair(AssetTemplates x)
{
    return new ObjectVersionPair<DataAsset, DataAssetVersion>
    {
        Object = GetObject(x),
        Version = GetVersion(x),
    };
}

Works as expected
Using StyleCop.Analyzers v1.0.2

Hi @a-jackson, I cannot reproduce the error that you describe. Could you please provide a more complete sample, including details on the used classes?

Since reporting this I've upgraded to VS 2017 and now can't reproduce it myself. It was originally in a dotnet core class library project with VS 2015, so an .xproj project.
I can attempt to make a minimal project with 2015 to try and reproduce this if you like or just close it as it no longer occurs with latest versions?

Feel free to close it if the problem no longer exists for you.
If you create a minimal project with the problem in it, I will of course have a look 😉

I've managed to reproduce it in Visual Studio 2015. Code is here https://github.com/a-jackson/StyleCop.Analyzers.Issue2489
I migrated the project to Visual Studio 2017 and it works as expected so it seems to be limited to 2015. Seems to only occur with the using System; which VS recognises as not needed but that makes sense I guess as Object would only work as a type if there was using System;.
Feel free to close this though if you aren't support 2015 dotnet core projects anymore.

Thanks for the code. It reproduces here with both 1.0.2 and 1.1.0-beta004.
I cannot get it to reproduce in the development environment however 😞
@sharwell I had a quick look at the code and this line in SA1121 is most likely where it goes wrong. Do you have any idea how this can be reproduced in the development environment?

Do you know the version of the compiler that is used? This looks like a compiler bug that was fixed with https://github.com/dotnet/roslyn/pull/8167.

It'll be whatever comes with dotnet core 1.0.0-preview2-003131. I can't figure out how to find the roslyn version it is using. the csc.dll in there is 1.3.0.

@a-jackson The fix for this first shipped with 2.0.0. This suggests it should reproduce in the original test project, but not the CSharp7 test project.

Closing this as an external bug


Add Settings Toggle for WiFi Direct

Allow users to choose to scan for WiFi Direct devices.

See remaining comments.

@cco3 fixed


KOGITO-1815: Chrome Extension Release

Task
https://issues.redhat.com/browse/KOGITO-1858
https://issues.redhat.com/browse/KOGITO-1859
Description

Remove unnecessary permissions of the Chrome Extension over the browser
Add a GitHub Actions workflow to upload and publish the released Chrome Extension on Chrome Store.

Before accept this PR
It's necessary to set up these secret variables on the repository:

GOOGLE_DEVELOPER_CONSOLE_CLIENT_ID
GOOGLE_DEVELOPER_CONSOLE_CLIENT_SECRET
GOOGLE_DEVELOPER_CONSOLE_REFRESH_TOKEN
CHROME_EXTENSION_ID

Video Overview
https://www.youtube.com/watch?v=TXuWErf6-Bo

Secrets were already created. Approving.


"IsPullToRefreshEnabled" and "IsRefreshing"

There are some problems while using "IsPullToRefreshEnabled" and "IsRefreshing",
"IsPullToRefreshEnabled" not work
"IsRefreshing" not work well with Binding mode OneWay

#27
Is this fixed by above. Can it be closed?


add FileWatcherSpec from ensime/ensime-server

Java7Watcher  is a replacement of ApachePollingFileWatcher. All 12 tests succeeded.

 You should sign our Contributor License Agreement in order to get your pull request merged.Alex Olkhovskiy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account ([for further information, click here] (https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user)).

failing because we have harder CI compile rules

you might want to change the email address you've used in this commit and squash, as it isn't recognised by github.

a couple of small comments, but overall this is looking really great! I can do the snapshot publish so we can use it from ensime-server (although that should hopefully happen automatically).

I think it would be better if java7-file-watcher project was a snapshot of ensime-server with java7 settings. Merging and testing would be much easier.

hmm, that would be extremely complex from a deployment perspective. It is much easier to manage as a dependency of ensime-server.

ahh... yes you are right. I can't see the wood for the trees. I forgot that it will be runtime decision to choose the watcher, not 2 separate java6 and java7 projects...

6 failed tests on windows :(

ouch

I have a Windows 7 VirtualBox image you're welcome to use for testing

How can I use you VirtualBox? Wouldn't it be less of a  hassle  to just create a new PR  in this project and trigger AppVeyor Windows integration testing?

you could use it locally to run the tests under windows.

(but yeah, keep triggering the tests here... if you can tolerate the time delay)

I added this watcher as a dependency to ensime-server and also created a watcher builder class to switch between apache and java7 watchers based on java.version. Tested in several projects and java versions and everything worked as expected.
https://github.com/lxol/ensime-server/commit/37d89fc0500c9fdf71cb026692b66cf085425927

this is fantastic, thank you!


Implements sqrt from math module

Co-authored-by: dannemarre
PR Checklist:
[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

As for math.sqrt function, it requires the input to be float, int, or bool, otherwise, it will definitely throw an exception. And it doesn't support an negative number as input. So if I test these, the test won't pass.

We see that you use try - except inside the tests with print statements, which means that the exceptions will be printed and therefore tested.
The exceptions thrown should be the same as normal python does and can therefore pass.
For example, you can see this in the test
"test_invalid_argument" here: https://github.com/shashd/voc_mp_group3/blob/master/tests/stdlib/test_collections.py#L134
Passing an int list to OrderedDict is an invalid type for OrderedDict, which expects a list of tuples. The test here makes sure that the java code and the python code throws the same type of error.


add wercker badge for master branch

https://app.wercker.com/#build/54ea5d49d9b14636631524b5 is clean. :ship:


Ignoring of memory-pool limits & OOM on large cartesian-product join

Describe the bug
There is an issue with possible OOM instead of ResourcesExhausted
Probably related to usage of unbounded channels (I believe it should be avoided actually)
To Reproduce
MRE to achieve ignoring of memory-pool with large Cartesian product:
CSV File example (250mb): GDrive link - it's random file and column to join by has the same value for all records (so it's cartesian product)
Memory pool limit: FairSpillPool::new(4 * 1024 * 1024 * 1024)
SQL:
SELECT * FROM rnd rnd1 JOIN rnd rnd2 ON rnd1."s3_drive" = rnd2."s3_drive"
Expected behavior
It should returnResourcesExhausted error with configured MemoryPool
Additional context
Add any other context about the problem here.
A part of this was described in the discussion here: https://github.com/apache/arrow-datafusion/issues/5108#issuecomment-1412491794, but there was mentioned the regression.
This example isn't regression and it's reproducible for old versions

I've changed the description, because this case isn't regression like one that was mentioned in #5108 by me. And probably more related to #3941.

I've changed the description, because this case isn't regression like one that was mentioned in https://github.com/apache/arrow-datafusion/issues/5108 by me. And probably more related to/part of https://github.com/apache/arrow-datafusion/issues/3941.

Thank you @DDtKey  -- I agree this is a feature gap (limiting memory usage by joins)

It seems I was wrong about #5339 closes this issue, my bad 😞 . This query shouldn't produce CROSS JOIN, and memory limitation for hash join required to fix this issue.

It seems I was wrong about https://github.com/apache/arrow-datafusion/pull/5339 closing this issue, my bad 😞 . This query shouldn't produce CROSS JOIN, and memory limitation for hash join required to fix this issue.

Yes, I think so, because this query produces hash-join in plan, but results in Cartesian product actually due to the same values in columns

I guess I'll fix Hash Join using the same approach in a couple of days then 🙃

Thank you @korowa

This

Closed by https://github.com/apache/arrow-datafusion/pull/5564


Fix pip install for python3, command argument and connection issue

fixes https://github.com/mokelly/wabbit_wappa/issues/10

I'm having the pip installation issues as well. Is this still a good fix, or is it giving you any trouble @MrMathias?

It's a pretty hacky solution, but it works just fine.


Issue with visualizing prisms in Visit (3.3.1)

Hello, I have been running into an issue of visualizing results from the Stix miniapp, found on the branch dh-sheath-bc-dev (stix3d_dh), within Visit. The output from Stix is a 2D mesh that is extruded out into a third direction. Using quads, I haven't had any issues with visit but I tried running a purely triangular mesh (prisms in 3D) and visit instantly crashes with the following attached error. I should note that Glvis works with the triangular solution.
visit_error.txt

I was able to reproduce this error in the master branch of MFEM without much of the specialized context that @christinamigliore is using.
To reproduce this open data/ref-prism.mesh using miniapps/meshing/mesh-explorer. The mesh should of course display correctly and it does. Then use mesh-explorer to save the mesh as a Visit Data Collection (keystrokes 'D' followed by 'v'). The resulting data collection cannot be used to display the mesh in VisIt.
@acfisher, I'm not sure where to look next. I would guess it's either the version of MFEM that VisIt is being built with or something in the way VisIt is calling MFEM when it encounters wedge elements.

ping: @cyrush

@mlstowell can you provide the output file you saved from mesh explorer? Then I can test with newer VisIt and debug if necessary.
VisIt 3.3.1 is from 2022, so it is certainty using an older version of mfem.

Thanks @cyrush!
mesh-explorer.tar.gz

@mlstowell thanks, confirming that I can replicate.

@mlstowell -- found the solution, we need to add logic for wedges (aka prisms) to the VisIt plugin.
I also tried adding a case for pyramids, but I saw a crash in MFEM LOR.
Just to make sure I don't have bad example data, can you make me a mesh with a pyramid?

Here is my hand coded example, but if there are any specific ordering constrains (especially with respect to the boundary) I doubt I was lucky enough to get it right:
MFEM mesh v1.0

#
# MFEM Geometry Types (see fem/geom.hpp):
#
# POINT       = 0
# SEGMENT     = 1
# TRIANGLE    = 2
# SQUARE      = 3
# TETRAHEDRON = 4
# CUBE        = 5
# PRISM       = 6
# PYRAMID     = 7
#

dimension
3

elements
1
1 7 0 1 2 3 4

boundary
5
1 2 0 1 4
2 2 1 2 4
3 2 2 3 4
4 2 0 3 4
5 3 0 1 2 3

vertices
5
3
0 0 0
1 0 0
0 1 0
1 1 0
0.5 0.5 1

@cyrush, thanks for tracking this down so quickly. We have at least two simple pyramid meshes in the master branch of MFEM. I put together a handful of test meshes containing pyramids. Two of these contain only pyramids the other two have a variety of element types.
pyramid-meshes.tar.gz

@mlstowell thank you
For the Pyramid cases, I am getting a crash when I try to create a refined mesh,
1          0x109e25830 mfem::Mesh::MakeRefined(mfem::Mesh&, int, int) + 212
0          0x109e26458 mfem::Mesh::MakeRefined_(mfem::Mesh&, mfem::Array<int>, int) + 2896

We are using MFEM 4.6, any chance that 4.7 has improvements related to Pyramid support?

@cyrush, I should have mentioned there are still limitations to the pyramid support. I would not expect refinement to work.

Thanks -- I will add support for wedges and provide an error message for the pyramid cases for now.

Thanks again @cyrush. I appreciate your efforts on this.

Thank you both, @cyrush and @mlstowell for your help on this!

For future testing I put together a minimal mesh with all of the element types in 3D.  You can find it in the mfem repo data/tinyzoo-3d.mesh.


slow-odgi: points of divergence and confusion

I think there is still a bug in odgi flip. Andrea made a fix for me, and this helped in one spot, but introduced an issue elsewhere. See here if curious.
I can't recreate the stated behavior of odgi inject even for trivial requests. I have asked on Matrix; see here.
I can recreate the behavior of odgi overlap, but I think they mean to calculate something more subtle and in fact have a bug. I have asked on Matrix; see here.
I remain very confused by odgi groom. See this comment if you're curious. I will ask about this next, after they have had a chance to think about the three fires I have recently lit.

Updates:
2. Got some clarity re: odgi inject. Will just get it done quickly.
3. Also got some clarity re: odgi overlap, but this has led to a new question: how to issue nontrivial flavors of this command?

Wow! Thank you for centralizing this "tracking" issue for understanding the bits of odgi we are currently confused about! This will be really useful to have.
This is very superficial and process-related, but one useful thing to do in this kind of GitHub issue is to edit the issue description to have checkboxes, like this:

[ ] match odgi flip behavior
[ ] figure out what's going on with odgi groom
[ ] …

This way, it's easy to see that, when all the checkboxes are checked, the issue is done.

I finally understand how to invoke odgi overlap in interesting ways! A basic invocation is correctly replicated already and that's been merged in, but at some point I'll flesh it out some more.
Here's the deal.
Say I have a graph:
S 1 ATGC...(* a seq of length 90 *)
S 2 ATGC...(* a seq of length 10 *)
S 3 ATGC...(* a seq of length 90 *)
P x 1+,2+
P y 2+,3+
L ... (* nothing special *)

If I query overlap with just the names of the paths, i.e. with flag -R and the file
x
y

I'll get that x overlaps with y and y with x. Fine.
The more interesting query is to specify ranges within the query path. So, for example:

"path x, start 0, end 50" will not return y;
"path x, start 0, end 100" will;
"path x, start 92, end 95" will as well.

The way to specify these ranges is via a special kind of BED file, a little different from the kind we have generated previously using flatten. So I'd run overlap with the -b flag and the following file.
x    0    30

I'm assuming that slow-odgi flip will not converge with odgi flip in the next few days, so I've checked it off here and moved it to #46, the parking lot for the next version. See there for more details!