Enhancement: Summary statistics tables seggregated

Description
It would be good to allow the user to obtain another summary statistic table that includes all patients that have been manually excluded from the analysis. In the same way, it would be also positive if for each of the table variables the user can also select the subjects, races or whatever variable values wants to particularly check.
Will be blocked until a method to exclude patients is included in the App!
Definition of Done
The requirements for the feature to be complete:

[ ] Include another summary table with only the patients excluded
[ ] Include an option to filter values of the aggregating variables used in summary tables (i.e, choose only certain USUBJIDs)

Related to #125
FYI, PKNCA has robust data exclusion functionality built-in (see https://billdenney.github.io/pknca/articles/v07-post-processing.html#modifying-results). Summarizing excluded individuals could be added to the PKNCA package without much effort, if helpful. Then, you could use the summary() function on a PKNCAresults object for what I think is being requested here.

It is good to know that you think it could be easily linked. We were not sure about this and our current summary is a customized function. We will then rethink about this!

Yes, if the summary coming out of PKNCA's summary() function doesn't fit all of your needs, we should discuss what is missing, and it may be a good fit to add within PKNCA rather than here. It does a lot of work to give useful summaries, already.


Calendar widget

Create a new widget which allows users to:

View dates on a convenient and easily navigable calendar
Add notes to specific dates that are saved in local session
Allow integration of the sticky note widget into the calendar (essentially, let users set notes from within the sticky note that show up on the calendar)

Also, don't forget to add it to the store so people can add it.

I think we can add Todos to this as well, potentially.

@Melkeydev I'm utilizing the existing react-calendar library as a launch pad for this work. I only had to add calendar event storage and display below selected weekdays and then of course the condensed view which can be changed in the system settings.
It looks like a pretty reputable component. Let me know if this is okay. I've already cut the majority of the fat from the repo itself to make it more maintainable, but the dependencies and build process are still separate from ours. I can combine them and transition from babel->vite to further assimilate into Astrostation.

@royanger Had a great point - can we just npm install the package instead of trying to re build it?

@royanger Had a great point - can we just npm install the package instead of trying to re build it? we can build around it and make a widget with it

Those are fair points. I thought about using their npm scripts, but the dependencies are almost all sub-dependencies, so I wasn't sure how that would impact the final size of the build. Is Vite/Node smart enough to remove/ignore duplicate dependencies during build-time if versions match?
What about automated builds in the case anyone decides to change it in the future? Right now, I have to run their scripts directly. I guess that's something I could figure out with Vite to make things work better or at the very least add a note to future developers to manually build with changes present.

Is Vite/Node smart enough to remove/ignore duplicate dependencies during build-time if versions match?

Assuming the package is written correctly, full tree shaking occurs.

What about automated builds in the case anyone decides to change it in the future?

I'm not quite sure what you're asking, but if we install from npm there is no build step. The package can immediately be used in the project. I'm not sure what you're referring to with "in the case anyone decides to change it in the future?" but I suspect it is a moot issue if we're using the npm package.

What about automated builds in the case anyone decides to change it in the future?

I'm not quite sure what you're asking, but if we install from npm there is no build step. The package can immediately be used in the project. I'm not sure what you're referring to with "in the case anyone decides to change it in the future?" but I suspect it is a moot issue if we're using the npm package.

I think there's a bit of miscommunication. I have not installed from NPM but rather utilized their source code directly with some modifications for the widget.

There is no miscommunication. I'm fully against that process unless we need to patch the package for some reason. We should not be taking over maintenance of a relatively complicated library via integrated it into our repo when we can simply npm install it. Yes, there are some issues with the npm ecosystem but with tree shaking it should be fine.
If we're going to have a calendar widget in the repo, my take would be to build it ourselves to spec. Keep it very lean with only exactly what we need and keep long term maintenance down.

I'm fully against that process unless we need to patch the package for some reason.

This is why I am opting to go the route I have specified above. The package react-calendar does not have the full functionality that is desired for this widget. It is missing calendar events and a simplified weekday UI that I have specified is desired for the widget. Ergo, I am suggesting we take what they have now and build on it. That is to say unless you think what they have is good enough for our purposes. Otherwise, building an entirely new widget from scratch (no matter how lean), styling it to fit the app, and maintaining it will require a significant amount of work upfront and potentially in the future (bugs and whatnot).
Here are our options as I see it:

Take the base npm react-calendar component as it is with some additional styling on top to fit in with Astrostation (some sample styling for ya, sorry for the text I was navigating their components)

Patch some desired functionality on top of react-calendar by taking what they have now for 3.x and do not maintain it beyond our additions.
Create a leaner calendar widget from scratch.

@royanger @Melkeydev @mattprivman @creativenull Any input on this? Personally, I'd prefer to do either of the first two, as I see myself practically rebuilding  react-calendar to meet our needs. I'll abide by what y'all think is best.

This is why I am opting to go the route I have specified above.

I think this is the heart of the miscommunication. When the npm option was first brought you mentioned dependencies and not lack of features.
Ignoring this library and really any existing solution, can you spec out the needs for the calendar?  Let's get that listed and then we can discuss those needs.


Error: Query root type must be provided.

root@ip-172-31-38-92:/home/ubuntu# curl -X POST -H "Content-Type: application/json" -d '{"query": "{ cardanoDbMeta { initialized syncPercentage }}"}' http://localhost:3100/graphql
{"data":{"cardanoDbMeta":{"initialized":true,"syncPercentage":100}}}
root@ip-172-31-38-92:/home/ubuntu# curl -X POST -H "Content-Type: application/json" -d '{"query": "{ cardano { tip { number slotNo epoch { number } } } }"}' http://localhost:3100/graphql
{"errors":[{"message":"Error: Query root type must be provided.","locations":[{"line":1,"column":3}],"path":["cardano"],"extensions":{"code":"INTERNAL_SERVER_ERROR","exception":{"stacktrace":["Error: Error: Query root type must be provided.","    at Object. (/application/packages/api-cardano-db-hasura/dist/executableSchema.js:78:35)","    at Generator.next ()","    at /application/packages/api-cardano-db-hasura/dist/executableSchema.js:8:71","    at new Promise ()","    at __awaiter (/application/packages/api-cardano-db-hasura/dist/executableSchema.js:4:12)","    at cardano (/application/packages/api-cardano-db-hasura/dist/executableSchema.js:63:63)","    at field.resolve (/application/node_modules/graphql-extensions/dist/index.js:134:26)","    at field.resolve (/application/node_modules/apollo-server-core/dist/utils/schemaInstrumentation.js:52:26)","    at resolveFieldValueOrError (/application/node_modules/graphql/execution/execute.js:467:18)","    at resolveField (/application/node_modules/graphql/execution/execute.js:434:16)"]}}}],"data":null}
Did I do something wrong?
@rhyslbw

@vae520283995
Please complete the bug report template and attach above

Environment
The CLI can be used to gather generic information about your system to assist with support.
No installation is required thanks to npx
npx @cardano-graphql/cli system-info

root@ip-172-31-38-92:/home/ubuntu# curl -X POST -H "Content-Type: application/json" -d '{"query": "{ cardanoDbMeta { initialized syncPercentage }}"}' http://localhost:3100/graphql
{"data":{"cardanoDbMeta":{"initialized":true,"syncPercentage":100}}}
root@ip-172-31-38-92:/home/ubuntu# curl -X POST -H "Content-Type: application/json" -d '{"query": "{ cardano { tip { number slotNo epoch { number } } } }"}' http://localhost:3100/graphql
{"errors":[{"message":"Error: Query root type must be provided.","locations":[{"line":1,"column":3}],"path":["cardano"],"extensions":{"code":"INTERNAL_SERVER_ERROR","exception":{"stacktrace":["Error: Error: Query root type must be provided."," at Object. (/application/packages/api-cardano-db-hasura/dist/executableSchema.js:78:35)"," at Generator.next ()"," at /application/packages/api-cardano-db-hasura/dist/executableSchema.js:8:71"," at new Promise ()"," at __awaiter (/application/packages/api-cardano-db-hasura/dist/executableSchema.js:4:12)"," at cardano (/application/packages/api-cardano-db-hasura/dist/executableSchema.js:63:63)"," at field.resolve (/application/node_modules/graphql-extensions/dist/index.js:134:26)"," at field.resolve (/application/node_modules/apollo-server-core/dist/utils/schemaInstrumentation.js:52:26)"," at resolveFieldValueOrError (/application/node_modules/graphql/execution/execute.js:467:18)"," at resolveField (/application/node_modules/graphql/execution/execute.js:434:16)"]}}}],"data":null}
Alternatively, what release or Git revision are you using:   git version 2.7.4
Platform

[√] Linux / Ubuntu
[ ] Linux / Other
[ ] macOS
[ ] Windows

Platform version:  Linux version 4.4.0-1092-aws (buildd@lgw01-amd64-030) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10) ) #103-Ubuntu SMP Tue Aug 27 10:21:48 UTC 2019
Runtime

[ ] Node.js
[√] Docker

Runtime version:
node -v
docker version Docker version 19.03.5, build 633a0ea838  docker-compose version 1.25.0, build 0a186604

Steps to reproduce the bug
Execute according to this document
https://github.com/input-output-hk/cardano-graphql/blob/master/README.md
What is the expected behavior?
root@ip-172-31-38-92:/home/ubuntu# curl -X POST -H "Content-Type: application/json" -d '{"query": "{ cardano { tip { number slotNo epoch { number } } } }"}' http://localhost:3100/graphql
{ "data": { "cardano": { "tip": { "number": 4391749, "slotNo": 4393973, "epoch": { "number": 203 } } } } }

with the stack running, please run docker-compose images and paste the output

root@ip-172-31-38-92:/data/cardano-graphql/cardano-graphql# docker-compose images
WARNING: The POSTGRES_DATA variable is not set. Defaulting to a blank string.
WARNING: The POSTGRES_NAME variable is not set. Defaulting to a blank string.
WARNING: The NODE_DB variable is not set. Defaulting to a blank string.
WARNING: The NODE_IPC variable is not set. Defaulting to a blank string.
WARNING: The CARDANO_NODE_NAME variable is not set. Defaulting to a blank string.
WARNING: The CARDANO_DB_SYNC_NAME variable is not set. Defaulting to a blank string.
WARNING: The CARDANO_GRAPHQL_HASURA_NAME variable is not set. Defaulting to a blank string.
WARNING: The CARDANO_GRAPHQL_NAME variable is not set. Defaulting to a blank string.
Container                          Repository                                 Tag                        Image Id       Size
cardano-db-sync-mainnet          inputoutput/cardano-db-sync          36e7621fa5ecb4be923569f735b74d60a26da6c1   0e1e5658fc52   1.003 GB
cardano-graphql-hasura-mainnet   inputoutput/cardano-graphql-hasura   2.0.0                                      20ec2257c042   123.5 MB
cardano-graphql-mainnet          inputoutput/cardano-graphql          2.0.0                                      d8ca620fd554   92.43 MB
cardano-node-mainnet             rhyslbw/cardano-node                 a4b6dae699fa21dc3c025c8a83d1718475cb3afc   9df1e6db7ff4   778 MB
postgres-mainnet                 postgres                             11.5-alpine                                da01ecfbabe1   71.85 MB

The reason for the warning is that I customize the container name and data directory

root@ip-172-31-38-16:/home/ubuntu# curl -X POST -H "Content-Type: application/json" -d '{"query": "{ cardanoDbMeta { initialized syncPercentage }}"}' http://localhost:3100/graphql
{"data":{"cardanoDbMeta":{"initialized":false,"syncPercentage":100}}}
[7a09bbf3:cardano.node.ErrorPolicy:Notice:53] [2020-08-14 08:47:37.20 UTC] [String "ErrorPolicySuspendConsumer (Just (ConnectionExceptionTrace (SubscriberError {seType = SubscriberParallelConnectionCancelled, seMessage = "Parallel connection cancelled", seStack = []}))) 1s",String "ErrorPolicyTrace",String "<IP_ADDRESS>:3001"]
cardano-node_1              | [7a09bbf3:cardano.node.DnsSubscription:Error:26515] [2020-08-14 08:47:37.70 UTC] [String "Application Exception: <IP_ADDRESS>:3001 HeaderError (At (Block {blockPointSlot = SlotNo {unSlotNo = 5789249}, blockPointHash = 68914f093daebff961def6df4830a21b2fffccec69442e8e6b780e51c40d5217})) (HeaderProtocolError (HardForkValidationErrFromEra S (Z (WrapValidationErr {unwrapValidationErr = ChainTransitionError [OverlayFailure (VRFLeaderValueTooBig (OutputVRF {getOutputVRFBytes = "\NUL\NUL\157\185\199\189l\210Y\130\175\220\248\140\242\129\&4!\138\193\175\235\238ch(\\\187\156Y3\239\204lYMF\160\239F.>S\248\193l\CAN\162\181\204\147\241\EOT\183\182P{Rz\\200vM\"}) (0 % 1) (ActiveSlotCoeff {unActiveSlotVal = UnsafeUnitInterval (1 % 20), unActiveSlotLog = -512932943875505334261962382072846}))]})))) (Tip (SlotNo {unSlotNo = 5789244}) 9c925a40b21eb2768f2b07733568f7bd9dbfe74848f0b29755b9e8a230b4f43e (BlockNo {unBlockNo = 4555199})) (Tip (SlotNo {unSlotNo = 5828555}) 761a204d720b0a6f7452617b3b6c903a150571f7a7b342b9f6c3c55fcb6a6ae4 (BlockNo {unBlockNo = 4557141}))",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""] cardano-node_1              | [7a09bbf3:cardano.node.ErrorPolicy:Warning:53] [2020-08-14 08:47:37.70 UTC] [String "ErrorPolicySuspendPeer (Just (ApplicationExceptionTrace (HeaderError (At (Block {blockPointSlot = SlotNo {unSlotNo = 5789249}, blockPointHash = 68914f093daebff961def6df4830a21b2fffccec69442e8e6b780e51c40d5217})) (HeaderProtocolError (HardForkValidationErrFromEra S (Z (WrapValidationErr {unwrapValidationErr = ChainTransitionError [OverlayFailure (VRFLeaderValueTooBig (OutputVRF {getOutputVRFBytes = \"\\NUL\\NUL\\157\\185\\199\\189l\\210Y\\130\\175\\220\\248\\140\\242\\129\\&4!\\138\\193\\175\\235\\238c*h(\\\\\\187\\156Y3\\239\\204lYMF\\160\\239F.>S\\248\\193l\\CAN\\162\\181\\204\\147\\241\\EOT\\183\\182P{Rz\200vM"}) (0 % 1) (ActiveSlotCoeff {unActiveSlotVal = UnsafeUnitInterval (1 % 20), unActiveSlotLog = -512932943875505334261962382072846}))]})))) (Tip (SlotNo {unSlotNo = 5789244}) 9c925a40b21eb2768f2b07733568f7bd9dbfe74848f0b29755b9e8a230b4f43e (BlockNo {unBlockNo = 4555199})) (Tip (SlotNo {unSlotNo = 5828555}) 761a204d720b0a6f7452617b3b6c903a150571f7a7b342b9f6c3c55fcb6a6ae4 (BlockNo {unBlockNo = 4557141}))))) 200s 200s",String "ErrorPolicyTrace",String "<IP_ADDRESS>:3001"]
cardano-node_1              | [7a09bbf3:cardano.node.DnsSubscription:Error:26516] [2020-08-14 08:47:37.74 UTC] [String "Application Exception: <IP_ADDRESS>:3001 HeaderError (At (Block {blockPointSlot = SlotNo {unSlotNo = 5789249}, blockPointHash = 68914f093daebff961def6df4830a21b2fffccec69442e8e6b780e51c40d5217})) (HeaderProtocolError (HardForkValidationErrFromEra S (Z (WrapValidationErr {unwrapValidationErr = ChainTransitionError [OverlayFailure (VRFLeaderValueTooBig (OutputVRF {getOutputVRFBytes = "\NUL\NUL\157\185\199\189l\210Y\130\175\220\248\140\242\129\&4!\138\193\175\235\238ch(\\\187\156Y3\239\204lYMF\160\239F.>S\248\193l\CAN\162\181\204\147\241\EOT\183\182P{Rz\\200vM\"}) (0 % 1) (ActiveSlotCoeff {unActiveSlotVal = UnsafeUnitInterval (1 % 20), unActiveSlotLog = -512932943875505334261962382072846}))]})))) (Tip (SlotNo {unSlotNo = 5789244}) 9c925a40b21eb2768f2b07733568f7bd9dbfe74848f0b29755b9e8a230b4f43e (BlockNo {unBlockNo = 4555199})) (Tip (SlotNo {unSlotNo = 5828555}) 761a204d720b0a6f7452617b3b6c903a150571f7a7b342b9f6c3c55fcb6a6ae4 (BlockNo {unBlockNo = 4557141}))",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""] cardano-node_1              | [7a09bbf3:cardano.node.ErrorPolicy:Warning:53] [2020-08-14 08:47:37.74 UTC] [String "ErrorPolicySuspendPeer (Just (ApplicationExceptionTrace (HeaderError (At (Block {blockPointSlot = SlotNo {unSlotNo = 5789249}, blockPointHash = 68914f093daebff961def6df4830a21b2fffccec69442e8e6b780e51c40d5217})) (HeaderProtocolError (HardForkValidationErrFromEra S (Z (WrapValidationErr {unwrapValidationErr = ChainTransitionError [OverlayFailure (VRFLeaderValueTooBig (OutputVRF {getOutputVRFBytes = \"\\NUL\\NUL\\157\\185\\199\\189l\\210Y\\130\\175\\220\\248\\140\\242\\129\\&4!\\138\\193\\175\\235\\238c*h(\\\\\\187\\156Y3\\239\\204lYMF\\160\\239F.>S\\248\\193l\\CAN\\162\\181\\204\\147\\241\\EOT\\183\\182P{Rz\200vM"}) (0 % 1) (ActiveSlotCoeff {unActiveSlotVal = UnsafeUnitInterval (1 % 20), unActiveSlotLog = -512932943875505334261962382072846}))]})))) (Tip (SlotNo {unSlotNo = 5789244}) 9c925a40b21eb2768f2b07733568f7bd9dbfe74848f0b29755b9e8a230b4f43e (BlockNo {unBlockNo = 4555199})) (Tip (SlotNo {unSlotNo = 5828555}) 761a204d720b0a6f7452617b3b6c903a150571f7a7b342b9f6c3c55fcb6a6ae4 (BlockNo {unBlockNo = 4557141}))))) 200s 200s",String "ErrorPolicyTrace",String "<IP_ADDRESS>:3001"]

@rhyslbw hello,I have 2 nodes that can't synchronize. Is there any group under discussion, such as telegram

root@ip-172-31-38-16:/home/ubuntu# curl -X POST -H "Content-Type: application/json" -d '{"query": "{ cardanoDbMeta { initialized syncPercentage }}"}' http://localhost:3100/graphql
{"data":{"cardanoDbMeta":{"initialized":false,"syncPercentage":99.98}}}

Hi @vae520283995
Best to stick to the latest release from Dockerhub, or checkout the 2.0.0 git tag and build from there. The next release is being planned, but is dependent on an update from cardano-db-sync

Hi @vae520283995
Best to stick to the latest release from Dockerhub, or checkout the 2.0.0 git tag and build from there. The next release is being planned, but is dependent on an update from cardano-db-sync

Unable to synchronize is the reason for cardano-node,Even if I update the latest version, it doesn't work

@vae520283995
Best to try from a clean state with:

inputoutput/cardano-node:1.18.0
inputoutput/cardano-db-sync:3.1.0
inputoutput/cardano-graphql:2.0.0

To achieve this without removing the existing volumes, docker-compose -p another-name up

root@ip-172-31-38-16:/data/cardano-graphql/cardano-graphql# docker-compose images
WARNING: The POSTGRES_DATA variable is not set. Defaulting to a blank string.
WARNING: The POSTGRES_NAME variable is not set. Defaulting to a blank string.
WARNING: The NODE_DB variable is not set. Defaulting to a blank string.
WARNING: The NODE_IPC variable is not set. Defaulting to a blank string.
WARNING: The CARDANO_NODE_NAME variable is not set. Defaulting to a blank string.
WARNING: The CARDANO_DB_SYNC_NAME variable is not set. Defaulting to a blank string.
WARNING: The CARDANO_GRAPHQL_HASURA_NAME variable is not set. Defaulting to a blank string.
WARNING: The CARDANO_GRAPHQL_NAME variable is not set. Defaulting to a blank string.
Container                          Repository                   Tag         Image Id       Size
cardano-db-sync-mainnet          inputoutput/cardano-db-sync          3.1.0         08e2fc63f973   1.003 GB
cardano-graphql-hasura-mainnet   inputoutput/cardano-graphql-hasura   2.0.0         7301341edecd   123.5 MB
cardano-graphql-mainnet          inputoutput/cardano-graphql          2.0.0         416ef6842e55   92.43 MB
cardano-node-mainnet             inputoutput/cardano-node             master        5098319ed904   776.7 MB
postgres-mainnet                 postgres                             11.5-alpine   da01ecfbabe1   71.85 MB

@vae520283995
Best to try from a clean state with:

inputoutput/cardano-node:1.18.0
inputoutput/cardano-db-sync:3.1.0
inputoutput/cardano-graphql:2.0.0

To achieve this without removing the existing volumes, docker-compose -p another-name up

      Container                          Repository                   Tag         Image Id       Size

cardano-db-sync-mainnet          inputoutput/cardano-db-sync          3.1.0         08e2fc63f973   1.003 GB
cardano-graphql-hasura-mainnet   inputoutput/cardano-graphql-hasura   2.0.0         7301341edecd   123.5 MB
cardano-graphql-mainnet          inputoutput/cardano-graphql          2.0.0         416ef6842e55   92.43 MB
cardano-node-mainnet             inputoutput/cardano-node             master        5098319ed904   776.7 MB
postgres-mainnet                 postgres                             11.5-alpine   da01ecfbabe1   71.85 MB

I have updated the latest version of cardano-node.  As per the upgrade instructions for<EMAIL_ADDRESS>you will need to rebuild the DB.

I get the same error as above, is there a solution?
:~/git/cardano-graphql$ docker-compose images
Container                                Repository                   Tag         Image Id       Size
cardano-graphql_cardano-db-sync-extended_1   inputoutput/cardano-db-sync          master        ae3bcae06bc1   1.001 GB
cardano-graphql_cardano-graphql_1            inputoutput/cardano-graphql          2.0.0         e3542d216c57   93.49 MB
cardano-graphql_cardano-node_1               inputoutput/cardano-node             1.19.1        263f2061b567   826.2 MB
cardano-graphql_hasura_1                     inputoutput/cardano-graphql-hasura   2.0.0         f26a5e991d85   123.5 MB
cardano-graphql_postgres_1                   postgres                             11.5-alpine   da01ecfbabe1   71.85 MB

I get the same error as above, is there a solution?
/git/cardano-graphql$ docker-compose images
Container Repository Tag Image Id Size
cardano-graphql_cardano-db-sync-extended_1 inputoutput/cardano-db-sync master ae3bcae06bc1 1.001 GB
cardano-graphql_cardano-graphql_1 inputoutput/cardano-graphql 2.0.0 e3542d216c57 93.49 MB
cardano-graphql_cardano-node_1 inputoutput/cardano-node 1.19.1 263f2061b567 826.2 MB
cardano-graphql_hasura_1 inputoutput/cardano-graphql-hasura 2.0.0 f26a5e991d85 123.5 MB
cardano-graphql_postgres_1 postgres 11.5-alpine da01ecfbabe1 71.85 MB

No solution, I think this is a cardano-grapql problem, I am waiting for the next release


Custom, non-entity backed types

Possibly related to #79 and #77
It would be nice to be able to create custom types that can be used in other type definitions, but do not correspond to a resource/permissions on their own. The current workaround is to either use the Json scalar type, but then we lose the benefit of type-checking, or create a normal type and associated relationships which adds a lot of unnecessary noise.
Ex.
type Location {
  address: String!
  city: String!
}

type Person {
  name: String!
  location: Location!
}

type Business {
  url: String!
  location: Location!
}

I can confirm that we had a lot of real-world use for a feature like this on a different graphqlAAS provider.

This feature is even more useful/important with the recent addition of schema extensions. See also #318.

This is very useful. We have to add A LOT of on-to-one relations to support nested fields. And in some instances we just have to fallback to JSON because there is no other way

These could even be used as storage types, with storage set to 'parent', meaning it will actually be stored as Json on the parent type. But the most obvious examples are of course resolver functions.

Closing in favour of #1160.

@alexeygolev It would be very helpful if you could describe a case where JSON is currently the only option, but  embedded types as described here would work.


Plugin "record" does not exist in NextJS

Description
I'm trying to run the react example on NextJS, but it doesn't work. However, if I use create-react-app it works fine...
If i try to run without plugins key on options, it works fine, i can reproduce a video with no problem
Well, I needed to make some additional things to be able to get this result. NextJS makes a pre-rendering on server and this library doesn't work on server (I got an error that i solved using Dynamic Import preventing Server Side Rendering) https://nextjs.org/docs/advanced-features/dynamic-import#with-no-ssr. So that, I geting this error now, but i'm sure about videojs works fine...
Plugin "record" does not exist.
Steps to reproduce
Video Example Component
// Video Example Component
/* eslint-disable */
import React, { Component } from 'react';

import 'video.js/dist/video-js.css';
import videojs from 'video.js';

import 'webrtc-adapter';
import RecordRTC from 'recordrtc';

// register videojs-record plugin with this import
import 'videojs-record/dist/css/videojs.record.css';
import Record from 'videojs-record/dist/videojs.record.js';

class VideoExample extends Component {
  componentDidMount() {
    // instantiate Video.js
    this.player = videojs(this.videoNode, this.props, () => {
      // print version information at startup
      const version_info =
        'Using video.js ' +
        videojs.VERSION +
        ' with videojs-record ' +
        videojs.getPluginVersion('record') +
        ' and recordrtc ' +
        RecordRTC.version;
      videojs.log(version_info);
    });

    // device is ready
    this.player.on('deviceReady', () => {
      console.log('device is ready!');
    });

    // user clicked the record button and started recording
    this.player.on('startRecord', () => {
      console.log('started recording!');
    });

    // user completed recording and stream is available
    this.player.on('finishRecord', () => {
      // recordedData is a blob object containing the recorded data that
      // can be downloaded by the user, stored on server etc.
      console.log('finished recording: ', this.player.recordedData);
    });

    // error handling
    this.player.on('error', (element, error) => {
      console.warn(error);
    });

    this.player.on('deviceError', () => {
      console.error('device error:', this.player.deviceErrorCode);
    });
  }

  // destroy player on unmount
  componentWillUnmount() {
    if (this.player) {
      this.player.dispose();
    }
  }
  render() {
    return (

        <video
          id="myVideo"
          ref={(node) => (this.videoNode = node)}
          className="video-js vjs-default-skin"
          playsInline></video>

    );
  }
}

export default VideoExample;

Video Page
import { NextPage } from 'next';
import dynamic from 'next/dynamic';

const DynamicComponentWithNoSSR = dynamic(
  () => import('@Components/Video/VideoExample'),
  { ssr: false },
);

const videoJsOptions = {
  controls: true,
  bigPlayButton: false,
  width: 320,
  height: 240,
  fluid: false,
  plugins: {
    record: {
      audio: true,
      video: true,
      maxLength: 10,
      debug: true,
    },
  },
};

const VideoPage: NextPage<{}> = () => {
  return (

Hola

      <DynamicComponentWithNoSSR {...videoJsOptions} />

  );
};

export default VideoPage;

Results
Expected
Video player with record capabilities
Actual

Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs-record: 4.5.0
browsers
Brave - Version 1.27.109 Chromium: 92.0.4515.115 (Official Build) (64-bit)
OSes
Edition	Windows 10 Home
Version	20H2
Installed on	4/24/2021
OS build	19042.1110
Experience	Windows Feature Experience Pack 120.2212.3530.0

@thijstriemstra Yes, i tried it and it works fine. However, when i try to integrate with videojs-record i got the same error

I found the solution... This line was the error, I replaced from import Record from 'videojs-record/dist/videojs.record.js'; to only import 'videojs-record/dist/videojs.record.js'; and it works fine. I would like to send a PR with a NextJS Example to help preventing this confusion later. Also, with function component (i want to test it well before)
/* eslint-disable */
import React, { Component } from 'react';

import 'video.js/dist/video-js.css';
import videojs from 'video.js';

import 'webrtc-adapter';
import RecordRTC from 'recordrtc';

import 'videojs-record/dist/css/videojs.record.css';
import 'videojs-record/dist/videojs.record.js';

class VideoExample extends Component {
  componentDidMount() {
    // instantiate Video.js
    this.player = videojs(this.videoNode, this.props, () => {
      // print version information at startup
      const version_info =
        'Using video.js ' +
        videojs.VERSION +
        ' with videojs-record ' +
        videojs.getPluginVersion('record') +
        ' and recordrtc ' +
        RecordRTC.version;
      videojs.log(version_info);
    });

    // device is ready
    this.player.on('deviceReady', () => {
      console.log('device is ready!');
    });

    // user clicked the record button and started recording
    this.player.on('startRecord', () => {
      console.log('started recording!');
    });

    // user completed recording and stream is available
    this.player.on('finishRecord', () => {
      // recordedData is a blob object containing the recorded data that
      // can be downloaded by the user, stored on server etc.
      console.log('finished recording: ', this.player.recordedData);
    });

    // error handling
    this.player.on('error', (element, error) => {
      console.warn(error);
    });

    this.player.on('deviceError', () => {
      console.error('device error:', this.player.deviceErrorCode);
    });
  }

  // destroy player on unmount
  componentWillUnmount() {
    if (this.player) {
      this.player.dispose();
    }
  }
  render() {
    return (

        <video
          id="myVideo"
          ref={(node) => (this.videoNode = node)}
          className="video-js vjs-default-skin"
          playsInline></video>

    );
  }
}

export default VideoExample;

I would like to send a PR with a NextJS Example

Sounds good.

This line was the error, I replaced from import Record from 'videojs-record/dist/videojs.record.js'; to only import 'videojs-record/dist/videojs.record.js'; and it works fine.

Maybe this should be changed in the react examples as well (if it works there as well).

@thijstriemstra Maybe, let me try it. I will send a PR as soon as i can make the examples


Last Error Log

[Cucumber_5] Implemented logic that appends an error to the scenario and step description.

The issues were fixed in commit c770f7fefaf3166d572ac7ad8d410e94a3c230ef
Thank you !


oneview_server_profile_template is not idempotent

Scenario/Intent
I'm trying to manage my server profile templates via ansible. This means: creating new templates, editing existing templates (mainly by adding new SAN Volumes) and deleting templates.
If I create a new template with, for example, 3 volumes, the creation is fine, but if I try to rerun the playbook with the same inventory, so without new volumes, I get an error regarding "associatedTemplateAttachmentId"
Environment Details

Module Version: 5.3.1
Ansible Version: 2.9.1
OneView Appliance Version: 3.10.08-0337757
OneView Client API Version: 500
Python Version: 2.7.5
python-hpOneView SDK Version: not sure, how do i check?
Platform: CentOS Linux release 7.7.1908 (Core)

Steps to Reproduce

Create a server profile template with a SAN Volume
Run the playbook again

Expected Result
Ansible shows a Green Ok task
Actual Result
Playbook fails with error
HPOneViewTaskError(msg, error_code)
HPOneViewTaskError: Cannot change the attribute associatedTemplateAttachmentId for existing volume attachments in a profile template. Attachment {null} in profile template {Test_template1}.
It seems like it requires the parameter "associatedTemplateAttachmentId" for each existing volume. I wasn't supplying any attachmentId since this is assigned by oneview automatically upon creating a new attachment.

@innerfears,
I wasn't able to reproduce the above error. But I could create and edit the server profile template by attaching SAN volumes to it. I haven't provided any associatedTemplateAttachmentId in the playbook.
Please find the below playbook in which you can create SPT without SAN volumes by commenting and rerun the playbook with SAN volumes included. I hope this helps.

hosta
vars:
config: "{{ playbook_dir }}/oneview_config.json"
server_profile_template_name: SPTVolume
server_hardware_type_name: SY 480 Gen9 2
enclosure_group_name: eg
server_profile_name: SP1
tasks:

name: Create a server profile template
oneview_server_profile_template:
config: "{{ config }}"
state: present
data:
name: "{{ server_profile_template_name }}"
serverHardwareTypeName: "{{ server_hardware_type_name }}"
enclosureGroupName: "{{ enclosure_group_name }}"
serialNumberType: Virtual
iscsiInitiatorNameType: AutoGenerated
macType: Virtual
wwnType: Virtual
description: 'use case 1: boot from SAN'
affinity: Bay
connectionSettings:
complianceControl: CheckedMinimum
manageConnections: true
connections:
- id: 1
name: FCNetwork
functionType: FibreChannel
portId: Mezz 3:1-b
requestedMbps: 2500
networkUri: /rest/fc-networks/1da44bdb-a2a8-4862-aa9b-1d7dc06c1495
boot:
priority: NotBootable
bootVlanId: null
managed: true
lagName: null
isolatedTrunk: false
networkName: null
sanStorage:
hostOSType: Windows 2012 / WS2012 R2
manageSanStorage: true
volumeAttachments:
- id: 1
lunType: Auto
storagePaths:
- isEnabled: true
connectionId: 1
targetSelector: Auto
networkUri: /rest/fc-networks/1da44bdb-a2a8-4862-aa9b-1d7dc06c1495
targets: []
volumeUri: null
volume:
templateUri: /rest/storage-volume-templates/bfb10cc7-548f-4e4a-970d-abdd007645e0
properties:
snapshotPool: /rest/storage-pools/93FA7CBF-F78F-41F5-B3EC-ABDD0075E296
isDeduplicated: false
storagePool: /rest/storage-pools/93FA7CBF-F78F-41F5-B3EC-ABDD0075E296
name: v
provisioningType: Thin
size: 268435456
isShareable: false
initialScopeUris: null
isPermanent: true
volumeStorageSystemUri: /rest/storage-systems/TXQ1010307
bootVolumePriority: NotBootable
- id: 2
lunType: Auto
storagePaths:
- isEnabled: true
connectionId: 1
targetSelector: Auto
networkUri: /rest/fc-networks/1da44bdb-a2a8-4862-aa9b-1d7dc06c1495
targets: []
volumeUri: null
volume:
templateUri: /rest/storage-volume-templates/bfb10cc7-548f-4e4a-970d-abdd007645e0
properties:
snapshotPool: /rest/storage-pools/93FA7CBF-F78F-41F5-B3EC-ABDD0075E296
isDeduplicated: false
storagePool: /rest/storage-pools/93FA7CBF-F78F-41F5-B3EC-ABDD0075E296
name: v2
provisioningType: Thin
size: 268435456
isShareable: false
initialScopeUris: null
isPermanent: true
volumeStorageSystemUri: /rest/storage-systems/TXQ1010307
bootVolumePriority: NotBootable
- id: 3
lunType: Auto
storagePaths:
- isEnabled: true
connectionId: 1
targetSelector: Auto
networkUri: /rest/fc-networks/1da44bdb-a2a8-4862-aa9b-1d7dc06c1495
targets: []
volumeUri: null
volume:
templateUri: /rest/storage-volume-templates/bfb10cc7-548f-4e4a-970d-abdd007645e0
properties:
snapshotPool: /rest/storage-pools/93FA7CBF-F78F-41F5-B3EC-ABDD0075E296
isDeduplicated: false
storagePool: /rest/storage-pools/93FA7CBF-F78F-41F5-B3EC-ABDD0075E296
name: v3
provisioningType: Thin
size: 268435456
isShareable: false
initialScopeUris: null
isPermanent: true
volumeStorageSystemUri: /rest/storage-systems/TXQ1010307
bootVolumePriority: NotBootable
bootMode:
   complianceControl: Checked
   manageMode: true
   mode: UEFIOptimized
   pxeBootPolicy: Auto
   secureBoot: Unmanaged
boot:
   complianceControl: Checked
   manageBoot: true
   order: [HardDisk]

params:
force: "True" # Supported only for API version >= 600
delegate_to: localhost

@innerfears,
I hope the above solution helps you to manage server profile template with SAN volumes. Please feel free to reopen the issue if you need any help.


Why Ugly Markdown

Haven't had a chance to play around with it, and it would look less clean in the raw text file, but (this SO answer)[http://stackoverflow.com/a/19976953/2272638] seems to suggest you can do multi-line tables in GFM with a little care. Dunno if it's worth it, but figured I'd at least mention.

Thanks @anderson-dan-w We're working on a revamp now.


chore(DotcomWeb.Router): expose LiveDashboard behind basic auth

I see this pull request exposes the live view, but I don't see how it interacts with basic auth

@kotva006 :basic_auth was added as a plug in the pipeline. It should prompt you for a username and password if you try to visit the /dashboard route, did it not do that for you?


[kwokctl] Fix -v argument passing

What type of PR is this?

/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Fix `-v` argument passing

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/lgtm


[executor] refactor state_view.into() -> state_view.into_state_cache()

Motivation
Love it being more explicit.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
existing coverage

/land


Did not manage to make it run on OSX

Hello,
This was looking great but I did not manage to make it run on osx.
any hints, I've got :
cc1plus: error: unrecognized command line option "-std=gnu++0x"

or
cc1plus: error: unrecognized command line option "-std=c++0x"

Would be nice to see your work in action

Hi,
I'm not familiar with OS X so I have no idea what flags the compiler needs but the idea is to compile the code with C++11. Gcc 4.6 needs the '-std=c++0x' so I guess you'll have to use something similar for your compiler.
Just change the following lines accordingly (CMakeLists.txt:27):
if(CMAKE_COMPILER_IS_GNUCXX)
    add_definitions(-std=c++0x)
endif()

If you'll get it running please let me know so I can fix it.
Btw don't get too excited about the application, it doesn't do much at the moment :).

OK, after lot of reading it appears that osx with Xcode is shipped with
gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)

So it is an old version patched by Apple.
Unfortunately, the c++0x flag we try to use here is only supported by GCC V4.6 and it is C++11 so :
http://www2.research.att.com/~bs/C++0xFAQ.html
Well, I do not have time to test this right now :
http://solarianprogrammer.com/2011/09/20/compiling-gcc-4-6-1-on-mac-osx-lion/
http://solarianprogrammer.com/2011/12/01/compiling-gcc-4-6-2-on-mac-osx-lion/
but this guy seems to well explained how to use gcc4.6 under OSX.
Well, for cross-plateform usability I could take some time to use Boost and see what could be replaced in your code, but right now... I do not.
Thank you any way !
G

Well, this application is a practice ground for C++11 for me so I will prefer using the new language constructs rather than the cross platform usability.
But should you want to make it running on OS X in the future feel free to fork and modify.


runc issues with Buildah when running a registry on Fedora 27

When running a registry with Buildah on Fedora 27, runc errors are popping up.  It appears we need a new version of runc on Fedora 27 as there is no issue if you clone/build runc, but installed versions including the latest update don't appear to work.
Email from @rossturk follows forwarded by @ipbabble
Hey Ross,
Thanks for the testing.  I'll touch base with Dan next week to see what's what with the runc versions.  I think we may need to have a new one built for Fedora.
Very much appreciate the testing and the reports.  I'm going to log this as an issue against Buildah on the GitHub site so we won't lose track of it.
t
On 12/08/2017 05:55 PM, Ross Turk wrote:

No worries on the hiccup! I hope I am not wasting time and this has some diagnostic value.
I altered your second command to reinstall buildah after the first command:
dnf -y remove runc
dnf -y install runc buildah --enablerepo updates-testing
Afterwards I got the same error. My runc version is:
runc version 1.0.0-rc4+dev
commit: 97b8bfe7fdea74d5e49b657013455a888328f04e
spec: 1.0.0
Cheers,
Ross

On Dec 8, 2017, at 1:51 PM, Tom Sweeney<EMAIL_ADDRESS>wrote:
Hi Ross,
Thanks for the note and sorry for the hiccup.  runc has caused a few from time to time.
If you've the time to play a little bit, could you do:
dnf -y remove runc
and then try
dnf -y install runc --enablerepo updates-testing
and let me know if Buildah is happy after that and/or what version runc sits at.
Thanks!
t
On 12/08/2017 04:13 PM, Ross Turk wrote:

That’s really odd! Just to be more specific about my environment, I’m running on a completely fresh Fedora 27 Cloud Base - ran those four dnf/buildah commands immediately following the VM creation.
Cheers,
Ross

On Dec 8, 2017, at 12:30 PM, William Henry<EMAIL_ADDRESS>wrote:
Ross confirmed that it worked with another package. I have not seen the issue. But it is worth bringing up.
For the record my working commit # is the same as his broken commit version:
$ runc -v
runc version 1.0.0-rc4+dev
commit: 01831c088179672b0a6af47954a626b3a886fcd8
spec: 1.0.0
¯_(ツ)_/¯
Willaim
William Henry
Senior Consulting Software Engineer
Red Hat
Colorado, USA.
On Fri, Dec 8, 2017 at 1:25 PM, Ross Turk<EMAIL_ADDRESS>wrote:
Hey folks - I ran into an issue walking through William’s new buildah tutorial that he thought I should make you aware of.

From a fresh Fedora 27 host, I ran these commands:

# dnf -y update # and reboot
# dnf -y install buildah
# registry=$(buildah from registry)
# buildah --debug run $registry

I get the following output:

DEBU[0000] error running runc [/entrypoint.sh /etc/docker/registry/config.yml]: exit status 139
DEBU[0000] error running [] in container "registry-working-container": exit status 139

I was able to chroot into the mounted container and successfully run entrypoint.sh manually, so I began to suspect runc. If I call runc -v it gives me this:

runc version 1.0.0-rc4+dev
commit: 01831c088179672b0a6af47954a626b3a886fcd8
spec: 1.0.0

If I build runc from current GitHub master, buildah run $registry works. A ha! The version of runc that works is:

runc version 1.0.0-rc4+dev
commit: 1d3ab6d668952a23498256dd385bec37f8f9fa04
spec: 1.0.0

I think the tutorial is about to go live, if it’s not already. I wonder - will people run into this issue with the runc packages currently in f27?

Cheers,
Ross

--
Ross Turk
Portfolio Evangelism, Red Hat
@rossturk

--
Ross Turk
Portfolio Evangelism, Red Hat
@rossturk

--
Ross Turk
Portfolio Evangelism, Red Hat
@rossturk

Rebuilding latest runc from upstream.
runc-1.0.0-13.rc4.git1d3ab6d

Please test and update Karma

https://bodhi.fedoraproject.org/updates/FEDORA-2017-3676a27a48


⚠ Bofrost.de has degraded performance

In c400fc6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1022 ms

Resolved: Bofrost.de performance has improved in 2a39f1b.


Delete Carthage formula

Keeping it here is a recipe for outdatedness, since there's an up-to-date formula in Homebrew proper: https://github.com/Homebrew/homebrew/blob/20f4ba664dc1739dd2cbbba492fbe376eb68585c/Library/Formula/carthage.rb

What do you mean? They seem to both be at the same version. We don’t keep packages out because they exist in homebrew. Many users prefer to install via homebrew-cask, and there are many packages we update sooner.

As a maintainer of Carthage, it's quite frustrating to me to get bug reports from users that are running older versions of the tool.
In a couple of cases, this has been because they installed from homebrew-cask, which was significantly out of date (multiple big releases behind) until https://github.com/caskroom/homebrew-cask/pull/9289.

Many users prefer to install via homebrew-cask, and there are many packages we update sooner.

I myself ensure that Homebrew has the latest version for its formula, as soon as we release a new version. I guarantee that it will have the newest update sooner.
Besides that, I don't know why there would be a preference for homebrew-cask in this case. It's not a GUI application, and Homebrew provides a bottle, so there's no building from source necessary.

Hello @jspahrsummers. First, let me thank you for taking an active interest in the cask for Carthage.
We are not in principle opposed to removing a cask upon request, but I should like to emphasize that Homebrew and homebrew-cask are different projects, with fairly different use cases. Similarly, the overlap of users is significant, but not complete. We generally avoid removing casks for reasons of duplication, on the basis that some users may prefer one system to the other.
Have your users experienced issues with installing Carthage via homebrew-cask? Perhaps you have noticed outdated bug reports, or similia? If the cask is not cared for sufficiently, and causes problems upstream, we are most definitely available to remove it.

I haven't experienced issues per-se but I was in the situation mentioned by @jspahrsummers earlier (building with 0.3x while the most current version was 0.52), hence the PR. I actually went to the trouble of installing homebrew cask before I saw it was available directly via homebrew.
I'm +1 on removing it from cask :)

Besides that, I don't know why there would be a preference for homebrew-cask in this case. It's not a GUI application—and Homebrew provides a bottle, so there's no building from source necessary.

Our general approach is to be inclusive, and we try to be open to unusual setups. For example, it is not exceptionally rare to only keep a minimal Homebrew installation for the purpose of using homebrew-cask.
I would like to wait for the opinion of other @caskroom/maintainers, but if you feel confident that the cask will serve too few users and represent a maintenance burden, I am in favor of merging this PR.

Even aside from the Homebrew up-to-date-ness, Carthage is a developer-focused tool with no GUI (command-line only)—which seems quite different from kind of app that homebrew-cask means to help with.

which seems quite different from kind of app that homebrew-cask means to help with.

It is not, as we have a bunch of CLI-only casks, even ones that are not distributed as pkgs but only as compiled binaries. For the latter we usually directed users to homebrew/homebrew-binary but eventually stopped doing it because users kept submitting those apps; they expected them to be present here.
Your understanding of the scope of apps provided by homebrew-cask is limited in that regard — If it can be installed without compilation, we allow it (not just apps, even). Examples include rust, iojs, and many others. That particular argument isn’t at all basis for removal. Receiving bug reports due to old versions is a concern, though, and one that we can feel as well.

For example, it is not exceptionally rare to only keep a minimal Homebrew installation for the purpose of using homebrew-cask.

This is an important point, and will only become more relevant if we separate from homebrew, which is a possibility outlined in an open issue.
The solution to this issue is not remove the cask, but to keep it updated1. That is the case with every cask, though, and we do the best we can to keep up. I believe we shouldn’t remove it. However, I also believe we should cater to the developers’ wishes when it makes sense, and if @jspahrsummers wishes to not have his work distributed by homebrew-cask, we should honor that2.

1 Were there a way to do it automatically, such as an appcast or watching the repo only for releases, I’d even do it myself. There seems to be a way but I’d rather have an official way that gave me a notification, not send an email
2 I do hope, however, it is now clear why some of the original reasoning is wrong, and that if the opinion stands it is with that in consideration.

Even aside from the Homebrew up-to-date-ness, Carthage is a developer-focused tool with no GUI (command-line only)—which seems quite different from kind of app that homebrew-cask means to help with.

I appreciate your concern, but scope would not be an issue. We welcome CLI software, from the very popular to the rather less so.

Hi @jspahrsummers !
A vendor request for withdrawal has happened twice before, and we have honored it both times.
We appreciate your input and are sorry to see you go.
It is likely that someone will re-submit this Cask at some point.  We will try to remember your request when that happens: we are just starting a doc to store that sort of thing.

Thanks @rolandwalker!


Aggra (Português)

And it's me again :D
Line 688
[1413]="Aggra,PvP,ptBR,PvP,EU",
should be
[1413]="Aggra (Português),PvP,ptBR,EU",

Fixed.

Fixed.


Too much text at once

Like the original homepage, there is too much text displayed to the user at once.
It would be better if the homepage explained what Fabric is (goals, ideas), then download is a separate page and blog/make mods are already in a separate page - keep it that way.

That has been already discussed, it was noted that the most visitors want downloads.

Unlike the original homepage I try to denote and clearly hierarchize the blocks, which 2 column layout and large graphic separators help with

Yes, the content is indeed better separated.
My point is - why display it all in one page? Or why make it readable in one scroll? Using more whitespace or pagination could help separate different kinds of content.

Pagination seems like much more unintuitive decision. The page contains 5 clear blocks:

most needed: downloads and help
buzzy goals and ideas
blog (was specifically requested by Fabric admins)
Make mods page reference to fill the gap
Downloads were requested instead of buzz words, because that is by very, very far the most visited part of the site. As of why so much text about them - to not have a separate page. That was deliberate, so users who only need the downloads and often instructions spend as little time to find all information as possible


Enable building of static libs

Thanks for the very useful project.
Sometimes it is useful to compile the tools in a static lib. This PR allows for this.

Thanks for the contribution.


Server crashes when file doesn't exist

Earlier today, I found an issue where the NodeSquarespace server will crash if a file within the "assets" directory does not exist (or, in my case, is improperly named). I attempted to add the following into the  of site.region:

Unfortunately, I spelled it incorrectly:

The server crashed almost immediately upon issuing "sqs server --reload." Once I commented out the offending , the server was able to start without issue.
Next, I attempted to access the asset in question at the incorrectly-spelled URL:
http://localhost:5050/assets/**phtotoswipe**/default-skin.css
This caused the server to crash and throw the same error as before. Relevant stack trace below:

sqs-log Get local cache for key => page-assets-phtotoswipe-photoswipe.cs.html
sqs-log Get local cache for key => page-assets-phtotoswipe-photoswipe.cs.json
sqs-log Store local cache for key => page-assets-phtotoswipe-photoswipe.cs.json
sqs-log Store local cache for key => page-assets-phtotoswipe-photoswipe.cs.html
sqs-log Get local cache for key => page-assets-phtotoswipe-photoswipe.cs.html
/usr/local/lib/node_modules/node-squarespace-server/squarespace-template.js:897
typeName = pageJson.collection.typeName;
^

TypeError: Cannot read property 'typeName' of undefined
at getTemplateKey (/usr/local/lib/node_modules/node-squarespace-server/squarespace-template.js:897:35)
at Object.renderTemplate (/usr/local/lib/node_modules/node-squarespace-server/squarespace-template.js:446:23)
at /usr/local/lib/node_modules/node-squarespace-server/squarespace-server.js:263:29
at /usr/local/lib/node_modules/node-squarespace-server/node_modules/node-squarespace-middleware/squarespace-middleware.js:376:13
at Request._callback (/usr/local/lib/node_modules/node-squarespace-server/node_modules/node-squarespace-middleware/squarespace-middleware.js:300:9)
at Request.self.callback (/usr/local/lib/node_modules/node-squarespace-server/node_modules/request/request.js:199:22)
at emitTwo (events.js:100:13)
at Request.emit (events.js:185:7)
at Request. (/usr/local/lib/node_modules/node-squarespace-server/node_modules/request/request.js:1036:10)
at emitOne (events.js:95:20)

Yeah, it should ideally not do this, but its just serving the template directory as a static dir through express, so it is relying on order of operations for  URLs. I haven't looked into a resolve for this yet other than make sure you're not referencing assets that don't exist :/


Removing watching via RTMP functionality.

Hey there, I'm trying to remove the ability to watch via RTMP because on my setup it's just a vulnerability (easy DDOSing/bypassing of access controls), I have a whole separate service that handles distribution. I commented out "PlayStreamRequested" in handle_raised_event() but noticed there are other places (I think, please correct me if I'm wrong) where clients can get added, such as https://github.com/KallDrexx/rust-media-libs/blob/master/examples/mio_rtmp_server/src/server.rs 277. Can I have some guidance on what to remove? Thanks :)

Sorry for the delay.
To remove the ability to watch, you need to modify handle_play_requested() to reject any request to watch.


Object functions are not recognized

Example:
testobj = {
  func1: () => {
    console.log('test1');
  },
  func2: () => {
    console.log('test2');
  }
};

In this case func1 is recognized but func2 is not.
Interesting that if the call inside func1 is removed then both func1 and func2 are recognized:
testobj = {
  func1: () => {
  },
  func2: () => {
    console.log('test2');
  }
};

Here, running ctags on a file containing only the first sample or only the second sample produces nothing.

testobj is not tagged because it doesn't have a var/let/const keyword, this should be changed.
func1() and func2() are not tagged because I don't have a pattern for arrow functions as object methods, this should be changed.

As a matter of fact, there are other places where I should add arrow functions support.

This construct is now supported. Thank you.

with class syntax does not work
class Test {
  method = (param) => {
    console.log('test');
  }
}


THRIFT-5678: lib: cpp: TConnectedClient: warning due to non-virtual dtor

"Commit 042580f53441efe1bc5c80c89351fcb30740659e removed the virtual keyword from the declaration of ~TConnectedClient().
While mostly benign, it does cause a warning in some versions of GCC, which can throw off CI sometimes when building with -Werror.
Since the destructur is just default in TConnectedClient.cpp it probably makes sense to just remove it there and declare it both virtual and default in TConnectedClient.h.

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G @emmenlau - let me know your preferences. E.g. ensure all destructors are virtual, inline in .h vs in .cpp, etc.

Not sure what the status is here?

Zephyr v3.3 rc1 was just vmcut so I was a bit busy.
Additional work on this PR is required:

Declare all dtors virtual in .h
Implementations in .cpp (no .h inlines)

Any idea how to continue with this? I would rather not decide about this one alone.

My 2c: override implies virtual. It is both a duplication and not conventional pattern to have both specified for the same function (I think SonarQube will warn on this and say the virtual should be removed).
See override specifier

In a member function declaration or definition, override specifier ensures that the function is virtual and is overriding a virtual function from a base class.

If this update is made at least the PR will touch a bit fewer files since this change is massive
Also refer to this code guideline: C.128: Virtual functions should specify exactly one of virtual, override, or final

Looking at https://github.com/apache/thrift/commit/042580f53441efe1bc5c80c89351fcb30740659e yes virtual was removed from lib/cpp/src/thrift/server/TConnectedClient.h but override was added.
This enforces that the destructors are virtual for at least that type.

it does cause a warning in some versions of GCC

I think one would need to check specifically which classes gives this warning, since I expect it would not be TConnectedClient (since it is correct, virtual destructor)
Looking through this PR, I see there are actually a few classes that does not have virtual destructors, like TConcurrentClientSyncInfo.h. The question would probably be if they are base classes anywhere. Thus a change like this can be valuable.
@cfriedt I would suggest revert any change that adds virtual to a destructor already marked as override and then see where that leaves the PR.

Sure - thanks for the feedback.
There is one other change that I would need to do to upgrade the thrift version used in Zephyr after this. That is, namely, to redo the change where I added an alternative to some boost function (it's been so long I'm having a hard time remembering which).
And after that, I was thinking it would be interesting to try and coalesce fbthrift here too, because the newer compiler apparently generates really efficient c++ code with coroutines.

@CJCombrink - my PR needs approval to run tests. Can you please approve? This change definitely looks cleaner without the virutal ... override destructors. I'm not 100% sure if the virtual keyword is required on the windows class variants, but I think it could probably be removed as well if there are no inheritors. What do you think?

@Jens-G @emmenlau - any chance someone could approve and run tests?

Looks indeed good for me, so thumbs up from my side.

Any idea whether those CI errors exist already in the main branch?
Please let me know if there are any additional changes needed

Please let me know if there are any additional changes needed

I would be so bold to say that your change can not create build errors. Still, I briefly checked the CI, and at least some of the build errors are unrelated. For example the MSVC build was fine except for a python-test failling.
Looks good to me, can be merged.


feature request

make the inventory cables invisible

You can craft framed cables and paint them to hide them in the walls of your house.


fix addToCart resolver mutation

    const [addtocart, { error }] = useMutation(ADDTOCART);
    const func = async () => {
        try {
            const data = await addtocart({
                variables: {
                    product: {
                        "name": "Sample Product",
                        "price": 19.99,
                        "quantity": 10,
                        "description": "This is a sample product description."
                        // "category": ["5f4d7b5d163b341d8bfd9a40"]
                    }
                }
            })
        } catch (error) {
            console.log(error)
        }
    }

This is what I did to test this mutation. once this runs, we are getting a TypeError: Cannot read properties of undefined (reading 'findIndex') error.
The way our addToCart mutation in our resolvers.js is not correct.
addToCart: async (_, { productData }, context) => {
      console.log(context.user);
      if (!context.user) {
        throw new Error("Authentication required");
      }

      try {
        // Check if the user already has the product in their cart
        const existingCartItemIndex = context.user.cart.findIndex(
          (item) => item.product === productData.productId
        );

context.user.cart does not exist in our context.user, so it returns an undefined value.
if you were to console.log(context.user);, what gets returned is:
[0] {
[0]   email<EMAIL_ADDRESS>[0]   username: 'carlos',
[0]   _id: '65130ca8a9a4effbbbea6ddc'
[0] }

this is the context set in our auth.js
  signToken: function ({ email, username, _id }) {
    // create payload with values
    const payload = { email, username, _id };
    // create new token with payload as data, created secret and expiration time
    return jwt.sign({ data: payload }, secret, { expiresIn: expiration });
  },

Fix Cart is still causing issues. Remove item form cart is retuning a null and doesn't reset the quantity .

resolved done


Updated Closure Tutorial which needed major improvement

Please update the pull request since many changes were done to the closures page. Thanks

Yeah i agree with @ronreiter . This is old.


Print total api costs

Cost conscious users would want to monitor their api usage.
Prints the total cost at the end:
...
If you have time, please explain what was not working (ok to leave blank)

Total api cost: 0.30204

I think this is a great idea!
Would you mind adding a dollar sign on main.py, line  99, so that it becomes:
print("Total api cost: $ ", ai.usage_cost())
then I will merge.


Blackscreen when using GVRVideoType.VERTICAL_STEREO

I am using the gvr-360video demo to test Vertical stereo videos, it worked fine a couple of weeks ago. Since recent updates the screen is black, no video can be watched. When I switch the VideoType to GVRVideoType.HORIZONTAL_STEREO or GVRVideoType.MONO everything works fine.

Well, I can confirm the problem.  The shaders themselves looks fine.  I suspect some plumbing in between got disconnected.  @NolaDonato knows that plumbing well.  She'll help you out.

I have figured out what the problem is and have prepared a patch to fix it. A line of code was missing in the OESHorizontalShader.cpp file.

you mean OESVerticalShader.cpp?

Yeah, I changed the vertical one.
From: thomasflynn<EMAIL_ADDRESS>Sent: Friday, May 20, 2016 3:31 PM
To: Samsung/GearVRf<EMAIL_ADDRESS>Cc: Nola Donato<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Samsung/GearVRf] Blackscreen when using GVRVideoType.VERTICAL_STEREO (#574)
you mean OESVerticalShader.cpp?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/Samsung/GearVRf/issues/574#issuecomment-220733755

Nola's fix is merged.  please retest.  thanks.

Thanks for your really fast fix - I can confirm that VERTICAL_STEREO works fine again for me.


cmake does not work in distributions other than Ubuntu

 Issue by carlos.garcia
Wednesday Nov 02, 2016 at 13:36 GMT
Originally opened as https://git.tk.informatik.tu-darmstadt.de/SPIN/ID2T-toolkit/issues/1

Compiling libpcapreader is not possible using the current CMakeLists.txt
It must be adapter to run on different distributions.

 Comment by carlos.garcia
Monday Mar 05, 2018 at 10:39 GMT

 Comment by patrick.jattke
Thursday Nov 03, 2016 at 22:30 GMT

Sorry, but I am not very familiar with CMake. What exactly must be adapted to make it runnable on other distributions? If I should handle that, please tell me which OS you are using such that I can reproduce it. Thanks!


Fix err msgs

LGTM :rocket:
Thanks for the contribution! :heart:

LGTM 🚀
Thanks for the contribution! ❤

lol. I'm going to use confluent as well. This package helps a lot ❤.


apache/superset:dockerize amd64 not found

Bug description
I tried to install superset helm chart. The chart is fetching apache/superset:dockerize which is exit for arm but not for amd64 on dockerhub.
How to reproduce the bug
docker pull apache/superset:dockerize
dockerize: Pulling from apache/superset
no matching manifest for linux/amd64 in the manifest list entries

Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

same...

We are building dockerize for both architectures, but it seems you have to be explicit about the exact SHA you want, you can use initImage.tag to define it.
example: 5040044ee638e5e41d572deaa2f8547d02d05449-dockerize-linux-amd64-3.9-slim-bookworm

Might be my recent PR on docker-related things, let me check

Normally you would merge the different tags to one single one after both are built.
Example of such a thing:  Building and then Merging

Yeah, I'd think the main image really should be multi-arch.

First I hear of multi-platform docker images. At least now we'll have a distinct tag for each.

Not having apache/superset:dockerize to support linux/amd64 approach is breaking the helm install in all x86
Ideally one single tag can support multiple archs. Indeed superset chart already depends on postgres and redis images that already support both architectures.
This doc may be helpful:
https://docs.docker.com/build/building/multi-platform/

Duplicated.  Also in this issue: #26788

Any update on this?

Should be all set, can you confirm? More details here -> https://superset.apache.org/docs/installation/docker

@mistercrunch why don't you release tags using multi-architecture images?
During the build phase you can do something like this:
docker buildx create --name mybuilder --bootstrap --use
docker buildx build --platform linux/amd64,linux/arm64 -t <username>/<image>:latest --push .

More doc here:
https://docs.docker.com/build/building/multi-platform/#getting-started
It does not seem a big deal for Superset, and will prevent issues to all ARM users (raspberri pi, Apple M1/2/3... Most of the helm charts I've used just work without needing to change the image architecture.

@mistercrunch the helm installation for superset still fails since it expects the dockerize tag for amd platform.
https://github.com/apache/superset/blob/master/helm/superset/values.yaml#L189
Ideally we should be doing what @merlos is suggesting above

@mistercrunch it would be great if the release is a multi-arch image.
similar to this

The image under the dockerize tag is linux/amd64
https://hub.docker.com/layers/apache/superset/dockerize/images/sha256-6172f74040aab46c1dc44b75ba07477d3ad91be813ad4b6baa1aab1127349bbe?context=explore&tab=vulnerabilities
About multi-platform builds I agree it's a good idea, but requires more build time, slowing down CI. Given the 2 builds have each a different base, it's pretty much twice the work (presumably twice the clock time too). In theory we could do this on-release only (not for each PR/master merge, but only on official tag, ASF release).
Two approaches:

I think there's a way to merge the manifests post build, but that seemed tricky/annoying
pass two platform argument (which doubles the build time) and we only want on-release

I'd go with option 2, and on-release only, but it'd require doing a bit of work around the build script. Overall the process would be:

add support for multi-platform argument here
remove platform from the matrix here
pass the two platform in the call here
re-trigger the job for old releases (easy)

For now, can you just suffix the tags to the version you want? Also amd should be the default, not sure why you'd get that error message

@mistercrunch

About multi-platform builds I agree it's a good idea, but requires more build time, slowing down CI. Given the 2 builds have each a different base, it's pretty much twice the work (presumably twice the clock time too). In theory we could do this on-release only (not for each PR/master merge, but only on official tag, ASF release).

This sounds like the right approach imho.

Closing this issue, and opened a feature request here https://github.com/apache/superset/discussions/27043


Unable to run qiskit algorithms

Information

Qiskit IonQ Provider version: 0.1.1.dev0+4e04c4e

API URL or version:

Qiskit version: 0.25.1

Python version: 3.8.3

Operating system: macOS 11.2.3

What is the current behavior?
Unable to run Amplitude Estimations from qiskit 0.25.1, for example this:
from qiskit.algorithms.amplitude_estimators import IterativeAmplitudeEstimation
The error raised is:
FAILURE: Can not get job id, Resubmit the qobj to get job id.Error: 'QasmQobj' object has no attribute 'clbits'
Steps to reproduce the problem
Run an IterativeAmplitudeEstimation  using either the ionq_simulator or the ionq_qpu as the backend
What is the expected behavior?
The algorithm runs without error
Suggested solutions

repro code:
import matplotlib.pyplot as plt
import numpy as np
from qiskit import QuantumCircuit
from qiskit.utils import QuantumInstance
from qiskit_ionq import IonQProvider

from qiskit.algorithms import EstimationProblem
from qiskit.algorithms.amplitude_estimators import MaximumLikelihoodAmplitudeEstimation
from qiskit_finance.circuit.library.probability_distributions import NormalDistribution
from qiskit_finance.circuit.library.payoff_functions.fixed_income_pricing_objective import FixedIncomePricingObjective

ionq_provider = IonQProvider("token")
ionq_backend = ionq_provider.get_backend("ionq_simulator")
ionq_quantum_instance = QuantumInstance(backend=ionq_backend)

num_qubits = [2, 2]

low = [0, 0]
high = [0.12, 0.24]
mu = [0.12, 0.24]
sigma = 0.01*np.eye(2)
bounds = list(zip(low, high))
u = NormalDistribution(num_qubits, mu, sigma, bounds)

A = np.eye(2)
b = np.zeros(2)
cf = [1.0, 2.0]
c_approx = 0.125

fixed_income = FixedIncomePricingObjective(num_qubits, A, b, cf, c_approx, bounds)
state_preparation = QuantumCircuit(fixed_income.num_qubits)
state_preparation.append(u, range(u.num_qubits))
state_preparation.append(fixed_income, range(fixed_income.num_qubits))
objective_qubit = u.num_qubits

problem = EstimationProblem(state_preparation=state_preparation,
                            objective_qubits=[objective_qubit],
                            post_processing=fixed_income.post_processing,
                            )

ae = MaximumLikelihoodAmplitudeEstimation(evaluation_schedule=2, quantum_instance=ionq_quantum_instance)

print("Running on IonQ simulator")
result = ae.estimate(problem)
print('Estimated value:    \t%.4f' % result.estimation_processed)

Should work out of the box now that provider is pinned to Terra 0.17.4. (see #74). Feel free to comment if it's still giving you trouble.


Improving Navbar View

@tushargupta1504
I aim to optimize the navbar design to improve its visual appeal and accessibility, providing users with a seamless navigation experience.

Thank You

I want to work on this issue under Gssoc24-ext. Please assign me this


Identify same variable present in multiple map() clauses

.. and emit a warning to try to unify whenever possible. This shoud avoid some compiler issues that are likely to be fixed soon(tm).

Generates output as follows
* Line 96 contains the following statement
#pragma acc data create(a) copyin(sm) copyout(a[0:N][0:N])
that has been as been translated into:
#pragma omp target data map(to:sm) map(from:a[0:N][0:N]) map(alloc:a)
* WARNING(s)! Please review the translation.
  1. Potential mapping overlap between map(alloc:a) and map(from:a). Try to unify to avoid potential data mapping issues, for instance map(from:a).


Kanban Board Setup

Creating a Kanban board and dividing the tasks
In this capstone project, we are a group of 4 members.

@PeteUgwu
@IndieCoderMM
@tanveerisonline
@tobuya

Screenshot

Hi Team,
In my opinion, you are ready to move on to the next step! ⏭
Good luck! 🎉
Highlights

task weights assinged equitably 👍
All issues have godo descriptions 👍
You seem to have addressed all  👍

Optional suggestions

[OPTIONAL] Consider adding labels to your issues, it makes it easier to filter by different types and gives another added level of differentiation among tasks (front-end vs back-end etc.)

P.S. Please add the project lin kto description!
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.
Cheers and Happy coding!👏👏👏

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Allow using ExpectedBucketOwner

Adds ExpectedBucketOwner to the allowed ExtraArgs for uploads to protect against bucket sniping when uploading files.
The underlying APIs already complain if you give them args that don't match, so I'm a little curious why this extra layer/check helps, but regardless adding this allows me to use ExpectedBucketOwner without issue.

@juice500ml , @JordonPhillips @kyleknap @rvrangel , @jamesls.

If anyone wants to make this work in the meantime:
from s3transfer.manager import TransferManager
TransferManager.ALLOWED_UPLOAD_ARGS = TransferManager.ALLOWED_UPLOAD_ARGS + ['ExpectedBucketOwner']

Hi @liquidpele,
I think this looks good. I'm going to test it with boto3 and the AWS CLI to be sure. In the meantime, can you add the appropriate changelog entry? To do that:

Run the script scripts/new-change.
Set the following in the file editor that comes up when prompted and commit the resulting file:type: enhancement
category: s3
description: Adds `ExpectedBucketOwner` to the allowed `ExtraArgs` for uploads to protect against bucket sniping when uploading files. Fixes #181.

Squash your commits.

Let me know if you need any assistance!

@kdaily okay let me know if that's what you needed.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6e12d1f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #180   +/-   ##
==========================================
  Coverage           ?   97.44%
==========================================
  Files              ?       15
  Lines              ?     2383
  Branches           ?        0
==========================================
  Hits               ?     2322
  Misses             ?       61
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e12d1f...f90e44e. Read the comment docs.

@kdaily, Is there anything else which is blocking merging this change? Any help in getting this merged at the earliest is highly appreciated. @liquidpele @stealthycoin

Hi @muralich2002, sorry for the delay. I tested this with the AWS CLI and boto3, and manually tested the change. I'm checking to see if this parameter needs to be added here as well:
https://github.com/boto/s3transfer/blob/ec75ec0a4793b8518e6500fc68c3b715273361c0/s3transfer/__init__.py#L592

@muralich2002 et al, still working on this. While reviewing, it was noticed that all API calls that support ExpectedBucketOwner in the header are not getting this parameter passed through.
For a multipart upload, I tested using the boto3 client.upload_file, which uses the s3transfer manager. The header is sent with CreateMultiPartUpload but not UploadPart or CompleteMultiPartUpload, though all can take the parameter.
For copying, I used boto3's client.copy, which uses a managed upload. It sends the header on the initial POST but not on the PUTs . It also is not sent to HeadObject.
For consistency, we need to adjust those before making this change. I'm compiling the places that this needs to be added:

https://github.com/boto/s3transfer/blob/ec75ec0a4793b8518e6500fc68c3b715273361c0/s3transfer/copies.py#L40
https://github.com/boto/s3transfer/blob/ec75ec0a4793b8518e6500fc68c3b715273361c0/s3transfer/upload.py#L488
https://github.com/boto/s3transfer/blob/ec75ec0a4793b8518e6500fc68c3b715273361c0/s3transfer/constants.py#L19
maybe for delete operations too

@kdaily is that the full list?   I can add it to those places too if that's it.

Hi @muralich2002 and @liquidpele - to faciliatate testing against boto3 and the AWS CLI, I took your previous commits and added the rest to #192. It looks like it's good to go! Thanks again for your contributions.


refactor: update guide-module template

module update introduces local branch rules for main and development

closing as working

reopening for minor changes

closing as done


Lock is not acquired/owned by you

When I run this function in multithreading I get an error
`
const fs = require('fs');
async function main(ip, instance) {

  const {plugin} = require('puppeteer-with-fingerprints');
  let path_prof = `./engine_br/${instance}/profiles`;
  try{
    fs.rmdirSync(path_prof, { recursive: true });
  }
  catch{
    console.log('y');
  }
  let fingerprint = await plugin.fetch('some_key', {
      tags: ['Microsoft Windows', 'Chrome']
    });
  plugin.useProxy(ip).useFingerprint(fingerprint).setWorkingFolder(`./engine_br/${instance}`);
  console.log(`Finger has set`,`./engine_br/${instance}`)
  const browser = await plugin.launch(
    {headless:true,
    });

  console.log('Browser started');
  const page = await browser.newPage();
  console.log('New page open');
  try{
    page.goto('Https://google.com')
  }
  catch(error){
    console.log('Erorr Hapen.Lets retartf app!');
  }
  finally{
      await browser.close();
      console.log('Deleting Folder...');
      fs.rmdirSync(path_prof, { recursive: true });
    }

};
module.exports = main;`

And the script that starts the threads
`const fs = require('fs');
const configFile = 'Config_app.json';
const config = JSON.parse(fs.readFileSync(configFile));
const instance_list = config.BotInstances;
const logic = require('./logic.js')

async function runInstances() {
  while (true) {
    const promises = instance_list.map((instance) => {
      const instance_name  = instance.instance;
      const ip = instance.ip;
      return logic(ip, instance_name)
        .then(() => {
          console.log(`Main function completed for instance: ${instance_name}`);
        })
        .catch((error) => {
          console.error(`An error occurred for instance ${instance_name}:`, error);
        });
    });

    await Promise.all(promises)
      .then(() => {
        console.log('All instances completed successfully.');
      })
      .catch((error) => {
        console.error('An error occurred:', error);
      });
  }
}

runInstances().catch((error) => {
  console.error('An error occurred:', error);
});`

I get this error after few minutes..
`C:\Users\Administrator\Desktop\cleanJSCR\node_modules\proper-lockfile\lib\lockfile.js:285
            return callback(Object.assign(new Error('Lock is not acquired/owned by you'), { code: 'ENOTACQUIRED' }));
                                          ^

Error: Lock is not acquired/owned by you
    at C:\Users\Administrator\Desktop\cleanJSCR\node_modules\proper-lockfile\lib\lockfile.js:285:43
    at LOOP (node:fs:2816:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  code: 'ENOTACQUIRED'
}

Node.js v21.0.0`

I can't reproduce your lock file error, but your code has a number of issues that need to be fixed and kept in mind:

You should change the working folder BEFORE any interaction with the plugin. In your example, the plugin for the first call will first install the engine in the standard folder, only to request a fingerprint. And this will continue in the same way - for the next call the previous folder will be used when requesting a fingerprint. This is incorrect logic, so you should set the folder before requesting a fingerprint.
The setWorkingFolder method was made as an alternative to environment variables, hence the need for the logic described in the paragraph above. Also, using it is not thread safe as stated here. Therefore, I would recommend that you use additional synchronization when changing a folder - for example through async-lock.
The multithreading option is easier to implement through worker threads or an alternative, so that each client has its own process, in which case you will not need to worry about synchronization when using different folders, and all work will be completely parallel.

I recommend using at least the first and second tips and fixing your code, this may also help solve the problem with lock files - if there are other problems, please open a new ticket.


Design QA - Slight misalignment when moving through Categories

When you enter to a sub-category, there a is a slight vertical misalignment.
I have overlapped 2 images (a category and a sub-category) so you can see what I mean:
Sports and square with numbers are not aligned.

Looks good to me. @yanelbottini is this what you meant?

Looks good!


fix: Remove nonnecessary variable (932260 PL1)

Variable no longer necessary since #3521 removed chain rule.

Thank you @EsadCetiner


 Throws errors however, so still WIP - needing feedback on this:
jellyfin-plugin-autoorganize $ dotnet publish --configuration Release --framework netstandard2.0 --output ../bin/
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 34.96 ms for /var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj.
Core/EpisodeFileOrganizer.cs(9,16): error CS0234: The type or namespace name 'Naming' does not exist in the namespace 'Jellyfin' (are you missing an assembly reference?) [/var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj]
Core/EpisodeFileOrganizer.cs(10,16): error CS0234: The type or namespace name 'Naming' does not exist in the namespace 'Jellyfin' (are you missing an assembly reference?) [/var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj]
Core/MovieFileOrganizer.cs(9,16): error CS0234: The type or namespace name 'Naming' does not exist in the namespace 'Jellyfin' (are you missing an assembly reference?) [/var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj]
Core/MovieFileOrganizer.cs(10,16): error CS0234: The type or namespace name 'Naming' does not exist in the namespace 'Jellyfin' (are you missing an assembly reference?) [/var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj]
Core/EpisodeFileOrganizer.cs(57,17): error CS0246: The type or namespace name 'NamingOptions' could not be found (are you missing a using directive or an assembly reference?) [/var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj]
Core/EpisodeFileOrganizer.cs(56,17): error CS0246: The type or namespace name 'NamingOptions' could not be found (are you missing a using directive or an assembly reference?) [/var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj]
Core/MovieFileOrganizer.cs(47,17): error CS0246: The type or namespace name 'NamingOptions' could not be found (are you missing a using directive or an assembly reference?) [/var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj]
Core/MovieFileOrganizer.cs(46,17): error CS0246: The type or namespace name 'NamingOptions' could not be found (are you missing a using directive or an assembly reference?) [/var/home/joshua/Projects/Jellyfin/jellyfin-build/projects/plugin/jellyfin-plugin-autoorganize/Jellyfin.AutoOrganize/Jellyfin.AutoOrganize.csproj]

Problem solved, builds correctly but needs testing.


Experimental

Merge Experimental with master

Thanks, let me know if there are any other issues, i'll probably promote this to the main branch in a month or so.

Just added a PR with some more supported device - thanks for this :)
I might be missing something obvious, I've got the master branch through HACS - but is there an easy way to get HACS to use this experimental branch? Or do I need to pull down this branch and copy it across manually without HACS


Incorrect replacement of & by |

It seems the bitwise mutator is replacing reference operators by mistake:
-  foreach ($shared as &$file) {
+  foreach ($shared as |$file) {

Which causes a syntax error for that mutation.

Noted, I'll need to filter out references from replacement... Indeed, there should be anti-reference mutator all to itself.

This should fix nearly all uses of ampersand in referencing https://github.com/padraic/humbug/commit/fef019f7c08f565313cb9c24e72b6114f473d6a0


redis cluster：ERROR MOVED 5517

/confd-0.12.0-linux-amd64[16793]: INFO Backend nodes set to <IP_ADDRESS>:8390, <IP_ADDRESS>:8390, <IP_ADDRESS>:8391, <IP_ADDRESS>:8391, <IP_ADDRESS>:8391, <IP_ADDRESS>:8391
/confd-0.12.0-linux-amd64[16793]: ERROR MOVED 5517 <IP_ADDRESS>:8390
nodes=[
"<IP_ADDRESS>:8390",
"<IP_ADDRESS>:8390",
"<IP_ADDRESS>:8391",
"<IP_ADDRESS>:8391",
"<IP_ADDRESS>:8391",
"<IP_ADDRESS>:8391"
]
I'm sure my redis cluster is normal，I do not know where the problem is

I suppose the Redis backend doesn't handle the MOVED response by Redis, you can try to fix it by adding the logic to handle this type of response in the Redis backend.


Rename SeaProgramAttribute -> Cluster and move to its own area

Another quick cleanup, this renames SeaProgramAttribute -> Cluster and SeaProgramCompute -> Kernel and moves it to Icicle.Sea.Data. I also moved SeaName to Icicle.Sea.Name so it's up at the same level. Neither are really avalanche specific after all.
So the idea is that each input has a cluster of kernels which execute the relevant queries for that input.
! @tranma
/cc @amosr

Pushing this one through

👍
ack


Finding data disk is unclear

[Enter feedback here]

You should note that /dev/sdc is an example and it may be /dev/sda
lssci is not installed by default in UbuntuLTS. Perhaps you should add lsblk as a useful alternative to finding which is/are the data disks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2036c044-4fbd-6016-c026-fea724b530d6
Version Independent ID: dde369ae-7a34-0753-5dfe-3720bf69e996
Content: Add a data disk to Linux VM using the Azure CLI - Azure Linux Virtual Machines
Content Source: articles/virtual-machines/linux/add-disk.md
Service: virtual-machines-linux
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

@AronT-TLV Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@AronT-TLV Apologies for the delay, we've made updates to the article, what you've requested should be incorporated.

#reassign @cynthn

There were several articles covering identifying the correct data disk. I've updated them and they should all be live now. Thank you for the feedback!
#please-close


Clean up CP Theme's SASS

There are lots of unused vars in red-hat-sass. We need to simplify everything, possibly rename vars (considering whether it's important to align with PF), etc.

+1 and add more alignment with pf4.  @starryeyez024 @kylebuch8 I'm wondering what priority this work would be?  It seems foundational and might be good to do sooner rather than later


Lerna version should use exact version

If --exact is not specified:

bundle depends on<EMAIL_ADDRESS>and<EMAIL_ADDRESS>But since both are caret-ed version
NPM will prefer version with latest tag, which means @4.0.0-preview.veryold instead

Self-approving non-production code change.


Spacing between list items

Hi,
I've created PDFList using a few PDFListItem.
I need to set vertical spacing between each item.
How can i achieve that?

Hi there,
this is not implemented yet. I think it should be easy to add the necessary properties to PDFList to create your desired behaviour.
This has no priority yet, therefore I can't tell you when it is implemented.
But feel free to add the functionality on your own and open a Pull Request

Hi @JaiDeves,
as this enhancement request still exists, I was wondering if you still need it?
And if so, how would you want to use it, same spacing between all elements, or configurable per element?

Closed due to inactivity

I opened a PR to address this @philprime, let me know what you think 😋
it was my first ever open source contribution, so I apologise in advance if I have skipped some procedure. https://github.com/techprimate/TPPDF/pull/352


private activities definitions

[Enter feedback here]
Can you provide more details on what private activities are compromised of. A list would be great. Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af3206d1-a6f4-3cf6-5172-2e3dbbef6778
Version Independent ID: bfb6fab6-fbf8-36f5-5d36-742babde0ada
Content: Scope your Microsoft Cloud App Security deployment
Content Source: CloudAppSecurityDocs/activity-privacy.md
Service: cloud-app-security
Product: ****
Technology: ****
GitHub Login: @shsagir
Microsoft Alias: shsagir

@StarkCaptain Thanks for your question.
The focus of the feature is to allow you to specify groups of users, not specific activities, who's activities you want to keep private to comply with your organization's policies. When viewing the activity logs, activities for these users will not appear by default. To view these activities, for example as part of an investigation, authorized admins have the option to choose to view these private activities, with each instance being audited in the governance log.
Please let us know if there's anything more we can do for you. To follow up on this issue, leave us a comment with an @mention.


Demo Application Does Not Work in Safari 15 or 16

I wanted to evaluate the behavior of the polyfill in Safari 15 & 16 before integrating it into my project, so I opened the demo netlify app in each browser (I was using Saucelabs to access the browser), and in both cases, the styling of the demo app had issues:
In Safari 15, the demo application was usable, but completely unstyled.
In Safari 16, the demo application is completely unusable, as all the elements on the screen are invisible (except for the code samples, and, only when hovering, the OddBird logo in the nav bar).
It seems like, if the purpose of the library is to support older browsers, the demo app should probably work in older browsers. It certainly gives me pause as to the extent of the backwards compatible support if the demo app doesn't work in older browsers.
How is the polyfill being tested in these browser environments?
Note: I don't see any code for the demo app in this repo, but couldn't find a repo in your org that does have it. If there's a better place to file the ticket, please let me know.

@spiralman Thanks for reporting! I'm able to reproduce what you're seeing in Safari 15, but Safari 16 looks mostly-fine to me, with the exception of some Shadow DOM content.

It seems like, if the purpose of the library is to support older browsers, the demo app should probably work in older browsers. It certainly gives me pause as to the extent of the backwards compatible support if the demo app doesn't work in older browsers.

A fair point! We're working under very limited time/money resources at the moment, and just recently launched even the most basic version of a styled demo page -- whereas the polyfill itself has been used in production heavily over the past year. We'll take a look, but if you're willing to dig in and contribute that would be much appreciated!

How is the polyfill being tested in these browser environments?

In CI at the moment we're testing against Chromium 113, Firefox 112, and Webkit 16.4.

Note: I don't see any code for the demo app in this repo, but couldn't find a repo in your org that does have it. If there's a better place to file the ticket, please let me know.

Everything is here in the repo. The demo is served from index.html, with styles in the css folder.

@jgerigmeyer I think there might be two things causing the styles not to show properly here. The oldest version of Safari probably doesn't have support for Cascade Layers. The issue in the later version of Safari is probably caused by lack of CSS support for nesting. I could rework some of the css so that we're not using nesting. As far as Layers support, I could unlayer some of the critical styles or we could use our polyfill?

I could rework some of the css so that we're not using nesting. As far as Layers support, I could unlayer some of the critical styles or we could use our polyfill?

Those both sound reasonable to me, I'm fine with whatever you'd propose 👍

@stacyk I only got so far as to test whether I was right about what was causing the style issues here. Nesting will obviously be an issue with some styles since that's one of the latest features to be implemented. But I think the main cause of style issues is layers. Like I mentioned above, we could either unlayer the bare minimum styles to have this work okay in older browsers, or make use of our polyfill. Container queries are used for styles here too, but I don't think them not working is having as drastic of an effect on the layout as layers/nesting.


DataTable

I had came across Data Table in the site in Firefox that is now showing the way is intended as the other browsers. Below is the screen shot of how it looks in Chrome followed by the bug screen shot from Fire Fox

Hey, @britt6612  I'm having the same cross-browser compatibility issue. The DataTable works fine on chrome and safari but it gets distorted in Firefox just the image above.
How did you solve the issue?

Hey @RohitoOo  I cleared my cache and that is what did it for me. I was messing with the inspect element but after I cleared it then it did not show up again. try that if not feel free to reopen the issue!


Question regarding license

Hello night-shift,
the D Programming Language (dlang.org) is missing an implementation for converting floating point numbers to strings. At the moment a C function is called which has the big disadvantage that the conversion cannot be done at compile time.
(D has extremely good compile time and template features)
It would be genius if we could add your implementation to the D standard library.
This would solve a lot of problems we currently have.
The issue is, D is using the Boost license (https://www.boost.org/LICENSE_1_0.txt).
Boost and MIT license are not compatible.
Is there any chance you could publish your implementation also under the Boost license?
Please see also this forum post about your implementation
<EMAIL_ADDRESS>Kind regards
Andre

Thank you sooo much!
That is fantastic.
Kind regards
Andre


Add test_timeseries

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[x] CHANGES.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Add a function test_timeseries. The function takes in an array and the name of a variable (not indicator) and creates a DataArray or Dataset ready to be used for tests.
It will also be useful for xscen tests.

Does this PR introduce a breaking change?
no
Other information:
I don't really know how pytest and fixtures work, but I tried something...

@RondeauG @aulemahal Is this what you wanted?
~I put it in xclim.testing.helpers as discussed in the meetingthursday, but it seems like it is not found as a fixture. If I try to use it in test_atmos.py, it fails. If I put it in conftest.py, then I am able to use it in test_atmos.py. Should I move it or do something else to make it accessible ?
Should I do something like line 14 of test_sdba/conftest.py: cannon_2015_dist = pytest.fixture(tu.cannon_2015_dist)?~ -> this is fixed.
If the variable is not recognized, should I put "unknown" in the attrs or just put no attrs ?

LGTM. Were you planning on replacing the existing timeseries fixtures with this? Might be a lengthy process but I can give you a hand.

The initial goal of this PR was to create something that xscen could use for tests. It was not my plan to replace existing fixtures, but I/we can do it if it's something that people want/need.

what about just having the tas_series fixture (and others) call `timeseries ?

@aulemahal Just mentioned that as a much nicer approach to me. Let's go with that. I can effect that changes.

This PR has the @RondeauG of approval


bs-react-native components fail to build

I have created a react native app skeleton with create-react-native-app and followed the instructions of the bs-react-native Readme to set up the reason toolchain.
When I execute yarn watch for the first time the compilation of 2 components fails with:
FAILED: src/components/viewRe.cmi
[...]
File "/Users/kliron/Projects/my_app/node_modules/bs-react-native/src/components/viewRe.rei", line 44, characters 4-75:
Error: The type constructor ReasonReact.component expects 3 argument(s),
but is here applied to 2 argument(s)
I get the same error for modalRe.rei

I think you're using an outdated version of bs-react-native. Please use the one from master for now.
@saschatimme could you cut a new release with all the changes up to now?


chore: bump training-operator v1.7 -> v1.8

This commit introduces the following changes:

The charm now renders and applies a ValidatingWebhookConfiguration resource for
training-operator CRDs.
The charm will now patch the Service to also serve on port 9443 for the webhook service.
The oci-image is updated to v1.8 of the training-operator
The training-operator Deployment now has a volume mount for mounting
the secret that is used by the cert-controller to generate and rotate
certificates for the ValidatingWebhookConfiguration

Fixes #159

https://github.com/kubeflow/training-operator/issues/2143 could be affecting (intermittently) the CI.

Please review #171 before this, it should help working around the CI issue.

This PR is now affected by https://github.com/canonical/training-operator/issues/174


JSON streaming for AsyncStream[A]

#520
By the way, it didn't work properly for Buf without Transfer-Encoding: chunked

Oh, dat usability with inline comments. I think it would be nice to continue discussion here :smile:

Current coverage is 74.59%

Merging #566 into master will decrease coverage by -1.20% as of e44a40f

Powered by Codecov. Updated on successful CI builds.

Merging this in. Thanks again @ImLiar!