Please document how to add this template to an existing repo

Hi this is a great template and I have watched your videos, so thanks for that. However I do have an issue. You assume that  the bootstrap template is going to be use on a new repo. I am not going to use it this way. I have multiple repos that I intend to write documentation for using this bootstrap template, but you don't explain how to add this to an existing repo.
It seems that jekyll can only build from a docs folder, and this can't be changed as far as I know, so I'm just gonna accept this, but to me it makes sense that it should be configurable (I would rather call this site or www). When I extract this bootstrap template in the root folder, I see these folders

_data
_includes
_layouts
_sass
assets
docs
pages

So there is another docs folder. Having 2 docs folders feels wrong to me. Can this docs folder be a different name? I would hope that it could be.
So to add this to an existing folder, do we just copy everything inside this extraction root, to the repo's docs folder?
Thanks.

@plastikfan bootstrap-template is a basic set up for a Jekyll site that provides the file structure, assets, and some components to quickly start a Jekyll project--the file structure itself is the Jekyll project. So yes, you are on the correct track--you need to copy the full file structure to where ever you want to set up the Jekyll project.
If you are using GitHub Pages automatic Jekyll build, then you can have it either at the root or in the docs/ folder, in any branch.
If the root of your repo is something different--for example containing some software project, and the new Jekyll project is just for creating a documentation website--the best options are to use the docs/ folder or to create a new branch which you clean out and use to host only the documentation. In these situations a lot of people also just have a separate documentation repository.
So, if you do want to build the site from the "docs/" folder, then yes, you would copy the full contents of bootstrap-template into docs/. The "docs" folder inside of bootstrap-template is just to contain information about using the template, so you could delete that or rename it to what ever you like--it is not needed for the new site.
Then you would probably want to move your existing .md files into the "pages" folder, since the template is set up to expect content there.
Then when you go to activate GitHub Pages, you choose the branch and then choose /docs option (see github pages docs).
Let me know if that makes sense!

@plastikfan bootstrap-template is a basic set up for a Jekyll site that provides the file structure, assets, and some components to quickly start a Jekyll project--the file structure itself is the Jekyll project. So yes, you are on the correct track--you need to copy the full file structure to where ever you want to set up the Jekyll project.
If you are using GitHub Pages automatic Jekyll build, then you can have it either at the root or in the docs/ folder, in any branch.
If the root of your repo is something different--for example containing some software project, and the new Jekyll project is just for creating a documentation website--the best options are to use the docs/ folder or to create a new branch which you clean out and use to host only the documentation. In these situations a lot of people also just have a separate documentation repository.
So, if you do want to build the site from the "docs/" folder, then yes, you would copy the full contents of bootstrap-template into docs/. The "docs" folder inside of bootstrap-template is just to contain information about using the template, so you could delete that or rename it to what ever you like--it is not needed for the new site.
Then you would probably want to move your existing .md files into the "pages" folder, since the template is set up to expect content there.
Then when you go to activate GitHub Pages, you choose the branch and then choose /docs option (see github pages docs).
Let me know if that makes sense!

Hi @evanwill, thanks for your response after following your instrctions and updating the _config.xml file, I am still getting strange errors. I have excluded my source code in the config inside _config.yml under the exclude key, Jekyll is getting the followng error:
 ✘ plastikfan@Janus  ~/dev/github/PoSh/Loopz λ   gh-pages ±  jekyll s
Configuration file: none
            Source: /home/plastikfan/dev/github/PoSh/Loopz
       Destination: /home/plastikfan/dev/github/PoSh/Loopz/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
     Build Warning: Layout 'page' requested in docs/404.html does not exist.
    Liquid Warning: Liquid syntax error (line 300): Expected end_of_string but found id in "{{ Fill Functee Description }}" in Elizium.Loopz/docs/Invoke-ForeachFsItem.md
    Liquid Warning: Liquid syntax error (line 242): Expected end_of_string but found id in "{{ Fill CopyFiles Description }}" in Elizium.Loopz/docs/Invoke-MirrorDirectoryTree.md
  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'docs/assets/css/custom.scss':
                    Error: File to import not found or unreadable: theme-colors. on line 28:1 of custom.scss >> @import ^
                    ------------------------------------------------
      Jekyll 4.2.0   Please append `--trace` to the `serve` command
                     for any additional information or backtrace.
                    ------------------------------------------------

This looks like Jekyll is still processing files that have been excluded. My repo is a powershell module and powershell modules user there own docs folder which contains .md files. It looks like Jekyll is processing those md files which it shouldnt be becasue they have excluded by this line in _config.yml:

exclude: [docs/, Rakefile, README.md, LICENSE, azure-pipelines.yml, Elizium.Loopz/, VERSION]

The 'Elizium.Loopz/' entry here is the root of the powershell module and it has a docs folder that I just mentioned. This should not be being processed.
I think I may have to use a separate repo for documenting my source code, but I would rather not.
There is also a strange sass error:
plastikfan@Janus  ~/dev/github/PoSh/Loopz λ   gh-pages ±  jekyll s --trace
Configuration file: none
            Source: /home/plastikfan/dev/github/PoSh/Loopz
       Destination: /home/plastikfan/dev/github/PoSh/Loopz/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
     Build Warning: Layout 'page' requested in docs/404.html does not exist.
  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'docs/assets/css/custom.scss':
                    Error: File to import not found or unreadable: theme-colors. on line 28:1 of custom.scss >> @import ^
Traceback (most recent call last):
        29: from /usr/local/bin/jekyll:23:in `<main>'

in the custom.css file:
@import
  "theme-colors", "template", "custom"
;

I don't know why theme-colors is not available, it exists as theme-colors.csv in the docs folder. (See this is why I don't like the idea of have a docs/docs folder, because that just leads to more confusion)

Hi @evanwill, thanks for your response after following your instrctions and updating the _config.xml file, I am still getting strange errors. I have excluded my source code in the config inside _config.yml under the exclude key, Jekyll is getting the followng error:
 ✘ plastikfan@Janus  ~/dev/github/PoSh/Loopz λ   gh-pages ±  jekyll s
Configuration file: none
            Source: /home/plastikfan/dev/github/PoSh/Loopz
       Destination: /home/plastikfan/dev/github/PoSh/Loopz/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
     Build Warning: Layout 'page' requested in docs/404.html does not exist.
    Liquid Warning: Liquid syntax error (line 300): Expected end_of_string but found id in "{{ Fill Functee Description }}" in Elizium.Loopz/docs/Invoke-ForeachFsItem.md
    Liquid Warning: Liquid syntax error (line 242): Expected end_of_string but found id in "{{ Fill CopyFiles Description }}" in Elizium.Loopz/docs/Invoke-MirrorDirectoryTree.md
  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'docs/assets/css/custom.scss':
                    Error: File to import not found or unreadable: theme-colors. on line 28:1 of custom.scss >> @import ^
                    ------------------------------------------------
      Jekyll 4.2.0   Please append `--trace` to the `serve` command
                     for any additional information or backtrace.
                    ------------------------------------------------

This looks like Jekyll is still processing files that have been excluded. My repo is a powershell module and powershell modules user there own docs folder which contains .md files. It looks like Jekyll is processing those md files which it shouldnt be becasue they have excluded by this line in _config.yml:

exclude: [docs/, Rakefile, README.md, LICENSE, azure-pipelines.yml, Elizium.Loopz/, VERSION]

The 'Elizium.Loopz/' entry here is the root of the powershell module and it has a docs folder that I just mentioned. This should not be being processed.
I think I may have to use a separate repo for documenting my source code, but I would rather not.
There is also a strange sass error:
plastikfan@Janus  ~/dev/github/PoSh/Loopz λ   gh-pages ±  jekyll s --trace
Configuration file: none
            Source: /home/plastikfan/dev/github/PoSh/Loopz
       Destination: /home/plastikfan/dev/github/PoSh/Loopz/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
     Build Warning: Layout 'page' requested in docs/404.html does not exist.
  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'docs/assets/css/custom.scss':
                    Error: File to import not found or unreadable: theme-colors. on line 28:1 of custom.scss >> @import ^
Traceback (most recent call last):
        29: from /usr/local/bin/jekyll:23:in `<main>'

in the custom.css file:
@import
  "theme-colors", "template", "custom"
;

I don't know why theme-colors is not available, it exists as theme-colors.csv in the docs folder. (See this is why I don't like the idea of have a docs/docs folder, because that just leads to more confusion)

I wonder if line endings has anything to do with this. I am using wsl2 on ubuntu. I extracted the bootstrap zip inside ubuntu using the unzip command. In visual studio code, the lin ending indicator for the custom.scss file indicates LF (as oppose to CRLF).

I wonder if line endings has anything to do with this. I am using wsl2 on ubuntu. I extracted the bootstrap zip inside ubuntu using the unzip command. In visual studio code, the lin ending indicator for the custom.scss file indicates LF (as oppose to CRLF).

@plastikfan if your Jekyll project is in the docs/ folder, then you need to start Jekyll jekyll s from inside that folder, not from the root. Your build message above says Configuration file: none, meaning it is not reading the _config.yml--it expects to find it in the place where you are running jekyll s. If it isn't reading the _config.yml, then it isn't getting your exclude or anything else.
Line endings don't matter to VS code or wsl2. PowerShell might care.

@plastikfan if your Jekyll project is in the docs/ folder, then you need to start Jekyll jekyll s from inside that folder, not from the root. Your build message above says Configuration file: none, meaning it is not reading the _config.yml--it expects to find it in the place where you are running jekyll s. If it isn't reading the _config.yml, then it isn't getting your exclude or anything else.
Line endings don't matter to VS code or wsl2. PowerShell might care.

Hi @evanwill,
thanks for that. I restarted jekyll from the docs folder and that worked. However, when I now visit the site, none of the bootstrap styling is being applied so the page looks like this:

I looked in the index.html in the generated _site files and I couldnt see anything obviously wrong in their,  but there is probably an incorrect path reference somewhere, similar to the way I accidently ran Jeykll from th wrong directory. So would you have any idea why bootstrap styling isnt being applied?
Thank you.
PS: I realised that I can't really have my site in a separate repo from my source code, because the url would also have to be different, which is just another headache I'd rather not have.

Hi @evanwill,
thanks for that. I restarted jekyll from the docs folder and that worked. However, when I now visit the site, none of the bootstrap styling is being applied so the page looks like this:

I looked in the index.html in the generated _site files and I couldnt see anything obviously wrong in their,  but there is probably an incorrect path reference somewhere, similar to the way I accidently ran Jeykll from th wrong directory. So would you have any idea why bootstrap styling isnt being applied?
Thank you.
PS: I realised that I can't really have my site in a separate repo from my source code, because the url would also have to be different, which is just another headache I'd rather not have.

@plastikfan not really sure? I just pulled down your https://github.com/EliziumNet/Loopz , looked at gh-pages branch, cd docs, jekyll s, and the template part seems to be working fine for me.
In that version of the code there isn't a url or baseurlset, but in your image above the url is http://<IP_ADDRESS>:4000/Loopz/about.html, so I assume you are trying to set a baseurl? If that value isn't structured correctly is the most likely way to scramble the urls to the assets.
For example if this is the repo, https://github.com/EliziumNet/Loopz
The _config.yml options would look like:
##########
# URL VARIABLES [optional!]
#
# Optional if using GitHub Pages! If building manually, these must be set correctly.
#
# use url for the domain, e.g. https://thecdil.github.io
# on gh-pages follow the pattern: https://username.github.io
url: https://EliziumNet.github.io
# use baseurl to add subsection of the domain, e.g. /timelinejs-template
# on gh-pages this is a / followed by the name of the repository
# baseurl is your github repository's name prefixed with a /
baseurl: /Loopz
# location of code, the full url to your github repository
source-code: https://github.com/EliziumNet/Loopz

Keep in mind that jekyll s generates absolute urls in the code starting with http://<IP_ADDRESS>:4000/, so if you just double click the file it won't be able to find the assets unless jekyll s is running. When you jekyll build those will be replaced with your real url value (on github pages, if url is left blank, it is automatically filled in with the correct url).

@plastikfan not really sure? I just pulled down your https://github.com/EliziumNet/Loopz , looked at gh-pages branch, cd docs, jekyll s, and the template part seems to be working fine for me.
In that version of the code there isn't a url or baseurlset, but in your image above the url is http://<IP_ADDRESS>:4000/Loopz/about.html, so I assume you are trying to set a baseurl? If that value isn't structured correctly is the most likely way to scramble the urls to the assets.
For example if this is the repo, https://github.com/EliziumNet/Loopz
The _config.yml options would look like:
##########
# URL VARIABLES [optional!]
#
# Optional if using GitHub Pages! If building manually, these must be set correctly.
#
# use url for the domain, e.g. https://thecdil.github.io
# on gh-pages follow the pattern: https://username.github.io
url: https://EliziumNet.github.io
# use baseurl to add subsection of the domain, e.g. /timelinejs-template
# on gh-pages this is a / followed by the name of the repository
# baseurl is your github repository's name prefixed with a /
baseurl: /Loopz
# location of code, the full url to your github repository
source-code: https://github.com/EliziumNet/Loopz

Keep in mind that jekyll s generates absolute urls in the code starting with http://<IP_ADDRESS>:4000/, so if you just double click the file it won't be able to find the assets unless jekyll s is running. When you jekyll build those will be replaced with your real url value (on github pages, if url is left blank, it is automatically filled in with the correct url).

I havent commited my curent version yet. My local version has an updated version of the _config.yml with those fields setup:
#######
# SITE SETTINGS
#
title: Elizium.Loopz PowerShell module documentation
description: "Documentation for Elizium.Loopz PowerShell module"
year: 2021
author: plastikfan
# add search box to navbar, true/false
search: true

##########
# URL VARIABLES [optional!]
#
# Optional if using GitHub Pages! If building manually, these must be set correctly.
#
# use url for the domain, e.g. https://thecdil.github.io
# on gh-pages follow the pattern: https://username.github.io
url: https://eliziumnet.github.io
# use baseurl to add subsection of the domain, e.g. /timelinejs-template
# on gh-pages this is a / followed by the name of the repository
# baseurl is your github repository's name prefixed with a /
baseurl: /Loopz
# location of code, the full url to your github repository
source-code: https://github.com/EliziumNet/Loopz

#######
# BUILD SETTINGS [usually leave as is]
#
# Defaults to simplify front matter,
# all files in the "pages" folder will be output at root of site
defaults:
  - scope:
      path: "pages"
    values:
      layout: page
      permalink: /:basename:output_ext

# ignore stuff
exclude: [docs/, Rakefile, README.md, LICENSE, azure-pipelines.yml, Elizium.Loopz/, VERSION]

I havent commited my curent version yet. My local version has an updated version of the _config.yml with those fields setup:
#######
# SITE SETTINGS
#
title: Elizium.Loopz PowerShell module documentation
description: "Documentation for Elizium.Loopz PowerShell module"
year: 2021
author: plastikfan
# add search box to navbar, true/false
search: true

##########
# URL VARIABLES [optional!]
#
# Optional if using GitHub Pages! If building manually, these must be set correctly.
#
# use url for the domain, e.g. https://thecdil.github.io
# on gh-pages follow the pattern: https://username.github.io
url: https://eliziumnet.github.io
# use baseurl to add subsection of the domain, e.g. /timelinejs-template
# on gh-pages this is a / followed by the name of the repository
# baseurl is your github repository's name prefixed with a /
baseurl: /Loopz
# location of code, the full url to your github repository
source-code: https://github.com/EliziumNet/Loopz

#######
# BUILD SETTINGS [usually leave as is]
#
# Defaults to simplify front matter,
# all files in the "pages" folder will be output at root of site
defaults:
  - scope:
      path: "pages"
    values:
      layout: page
      permalink: /:basename:output_ext

# ignore stuff
exclude: [docs/, Rakefile, README.md, LICENSE, azure-pipelines.yml, Elizium.Loopz/, VERSION]

I'm thinking that I should do the initial setup using the github ui because I managed to get this working on a test repo I have (https://plastikfan.github.io/FakeBuddy/). The problem with my Loopz repo is that I tried to do the initial setup locally using jekyll server and so far my local version is not quite working yet, because of the missing bootsrap styling.

I'm thinking that I should do the initial setup using the github ui because I managed to get this working on a test repo I have (https://plastikfan.github.io/FakeBuddy/). The problem with my Loopz repo is that I tried to do the initial setup locally using jekyll server and so far my local version is not quite working yet, because of the missing bootsrap styling.

Ok. so I just commited my changes then pushed. I went to test it locally again and it started to work. I have no idea what happened here. My local changes were only un-commited when it wasnt working, then I commited, then it started working. Confused!

Ok. so I just commited my changes then pushed. I went to test it locally again and it started to work. I have no idea what happened here. My local changes were only un-commited when it wasnt working, then I commited, then it started working. Confused!

Thanks for helping me out with this @evanwill

Thanks for helping me out with this @evanwill

Perhaps I shouldn't close this if you intend to make some additions to your documentation to indicate how to add this template to an existing repo. Could I also suggest you have a troubleshooting section that documents anticipated mistakes users mmight make, eg starting the jekyll server from the wrong dorectory! (Feel free to close if you want tho)

Perhaps I shouldn't close this if you intend to make some additions to your documentation to indicate how to add this template to an existing repo. Could I also suggest you have a troubleshooting section that documents anticipated mistakes users mmight make, eg starting the jekyll server from the wrong dorectory! (Feel free to close if you want tho)

Glad you figured it out @plastikfan . the process is helpful for thinking about teaching and doc-ing.
Not sure what was going on in your last mystery--only guess would be browser caching confusing things--when developing its a good idea to use a private window with dev tools open, then you can hold down refresh to get options to hard refresh everything.
Good luck with the project!

Glad you figured it out @plastikfan . the process is helpful for thinking about teaching and doc-ing.
Not sure what was going on in your last mystery--only guess would be browser caching confusing things--when developing its a good idea to use a private window with dev tools open, then you can hold down refresh to get options to hard refresh everything.
Good luck with the project!

Ok great thanks. And thanks to you for creating this useful template.
Cheers

Ok great thanks. And thanks to you for creating this useful template.
Cheers

PS: that styling issue with bootstrap can be fixed in the local version of jekyll by running 'jekyll clean', then rerunning build/serve


Script for folding BatchNorm into conv and linear layers

works only for the case when batchnorm is after conv or linear
usage is supposed to be like that:
local utils = require 'inn.utils'
print('folding BN error:', utils.testSurgery(input, utils.foldBatchNorm, net)) -- check that we did not break anything

Nice! I guess you can extend it to the Volumetric version too...

@mys007 yes should not be difficult to extend, just change the strings.

Both functions could be condensated into only one template function, right ?

@fmassa right, could be done.


Radar Draws Over MapTiler Maps

MapTiler updated layer names, and now the radar image improperly renders over labels, roads, and other items.

Yes! With the placefile functionality I'm currently working (#75), I'm planning on adding a layer manager to allow configuration of layer positioning. With this, you'll be able to move the radar data above or below roads and other map graphics currently drawn over the radar. I expect this to be available in a development version in the coming weeks (development versions available under GitHub Actions).

I'll definitely be following and can test once it's released. Thanks!

This is now available as part of the Layer Manager (Tools menu) in the latest CI build. This will make release v0.3.0, currently planned for next weekend.


Add bzr package to jenkins

Checklist

[x] The charm style guide was applied
[x] The contributing guide was applied
[x] The changes are compliant with ISD054 - Managing Charm Complexity
[x] The documentation is generated using src-docs
[x] The documentation for charmhub is updated.
[x] The PR is tagged with appropriate label (urgent, trivial, complex)

closing since this is a duplicate of https://github.com/canonical/jenkins-k8s-operator/pull/160#pullrequestreview-2055703896


Ancestors/Descendents not parsed correctly

I've just been looking at using this for monitoring our LVM snapshot usage, and found that running with snapshots causes a scrape parse error:
lvm_up{status="4 error(s) occurred:\n* field lv_ancestors: strconv.ParseFloat: parsing \"lv_home\": invalid syntax\n* field lv_descendants: strconv.ParseFloat: parsing \"test_snapshot\": invalid syntax\n* field lv_full_ancestors: strconv.ParseFloat: parsing \"lv_home\": invalid syntax\n* field lv_full_descendants: strconv.ParseFloat: parsing \"test_snapshot\": invalid syntax"} 0

It seems that the fields lv_ancestors, lv_descendants, lv_full_ancestors and lv_full_descendants are being parsed as metrics, when they should be considered information fields. Moving these fields from metricFields into infoFields seems to resolve the issue.

@dsnt02518, thank you again for #2. Do you want me to tag a new release or do you use your own build anyway?

We're using our own build, but would be happier if we could be using an
official upstream release. No hurry though, and thanks for merging.
On Fri, 3 Dec 2021 at 16:02, hansmi @.***> wrote:

@dsnt02518 https://github.com/dsnt02518, thank you again for #2
https://github.com/hansmi/prometheus-lvm-exporter/pull/2. Do you want
me to tag a new release or do you use your own build anyway?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hansmi/prometheus-lvm-exporter/issues/1#issuecomment-985637361,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AETQITN6UKLCCXR327GNLRTUPDSYVANCNFSM5JGSMCNQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I've tagged version 0.3.0 and made a release out of it (https://github.com/hansmi/prometheus-lvm-exporter/releases/tag/v0.3.0).

Perfect, many thanks.


Error: Could not find the correct Provider above this Halaaman2 Widget

Hi,, I try to implement state provider in another page, so the variable that I have set will be passed to second page. I have search for several source, but it doesn't help. This error show when I go to page Halaaman2.dart from main.dart. These are my files
Error: Could not find the correct Provider<Counter> above this Halaaman2 Widget

To fix, please:

  * Ensure the Provider<Counter> is an ancestor to this Halaaman2 Widget
  * Provide types to Provider<Counter>
  * Provide types to Consumer<Counter>
  * Provide types to Provider.of<Counter>()
  * Always use package imports. Ex: `import 'package:my_app/my_code.dart';
  * Ensure the correct `context` is being used.

If none of these solutions work, please file a bug at:
https://github.com/rrousselGit/provider/issues

main.dart
import 'package:flutter/material.dart';
import 'package:flutter_provider/counter.dart';
import 'package:flutter_provider/halaaman2.dart';
import 'package:provider/provider.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.blue,
        // This makes the visual density adapt to the platform that you run
        // the app on. For desktop platforms, the controls will be smaller and
        // closer together (more dense) than on mobile platforms.
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
//      home: ChangeNotifierProvider<Counter>(
//          builder: (context)=>Counter(),
//          child: MyHomePage(title: 'Flutter Demo Home Page')
//      ),
      home: ChangeNotifierProvider<Counter>(
          builder: (_)=>Counter(),
          child: MyHomePage(title: 'Flutter Demo Home Page')
      ),
//    home:
//    MultiProvider(
//      providers: [
//        ChangeNotifierProvider(create: (context) => Counter()),
//        Provider(create: (context) => Halaaman2()),
//      ],
//      child: MyHomePage(),
//    ),

//    ),
    );
  }
}

class MyHomePage extends StatelessWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  Widget build(BuildContext context) {

    final counter = Provider.of<Counter>(context);
    return Scaffold(
      appBar: AppBar(
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(title),
      ),
      body: Center(
        // Center is a layout widget. It takes a single child and positions it
        // in the middle of the parent.
        child: Column(
          // Column is also a layout widget. It takes a list of children and
          // arranges them vertically. By default, it sizes itself to fit its
          // children horizontally, and tries to be as tall as its parent.
          //
          // Invoke "debug painting" (press "p" in the console, choose the
          // "Toggle Debug Paint" action from the Flutter Inspector in Android
          // Studio, or the "Toggle Debug Paint" command in Visual Studio Code)
          // to see the wireframe for each widget.
          //
          // Column has various properties to control how it sizes itself and
          // how it positions its children. Here we use mainAxisAlignment to
          // center the children vertically; the main axis here is the vertical
          // axis because Columns are vertical (the cross axis would be
          // horizontal).
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Consumer<Counter>(
              builder: (_, counter, __)=>
                  Text(
                    '${counter.value}',
                    style: Theme.of(context).textTheme.headline4,
                  ),
            ),
            Consumer<Counter>(
              builder: (_, counter, __)=>
                  Text(
                    '${counter.isi}',
                    style: Theme.of(context).textTheme.headline4,
                  ),
            ),
            FlatButton(
                child: Text('test'),
              onPressed: (){
                  counter.increment2('test');
              }
            ),
            FlatButton(
                child: Text('ubah'),
                onPressed: (){
                  counter.increment2('ubah');
                }
            ),
            RaisedButton(
              onPressed: (){
                Navigator.push(
                  context,
                  MaterialPageRoute(
                    builder: (context) =>Halaaman2(),
                  ),
                );
              },
              child: Text('route go to C'),
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: counter.increment,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
      // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

counter.dart
import 'package:flutter/foundation.dart';

class Counter with ChangeNotifier{
  int value = 0;
  String isi = 'awal';

  void increment(){
    value++;
    notifyListeners();
  }

  increment2(String test){
    isi = test;
    notifyListeners();
  }

}

second page in (halaaman2.dart)
import 'package:flutter/material.dart';
import 'package:flutter_provider/counter.dart';
import 'package:provider/provider.dart';

class Halaaman2 extends StatelessWidget {

  @override
  Widget build(BuildContext context) {
    final counter = Provider.of<Counter>(context);
    return Scaffold(
      appBar: AppBar(
        title: Text('test'),
      ),
      body: Column(
        children: [
          Consumer<Counter>(
            builder: (_, counter, __)=>
                Text(
                  '${counter.isi}',
                  style: Theme.of(context).textTheme.headline4,
                ),
          ),
        ],
      ),

    );
  }
}

Hey.
Your Halaaman2 Widget is not a descendent of a context which includes the Counter Provider.
Change your code to:
  MaterialPageRoute(
    builder: (context) => ChangeNotifierProvider.value(
      value: counter,
      child: Halaaman2()
    ),
  ),

Hi @chungmukhkhyung
provider is a 3rd party plugin
you may want to open an issue in the dedicate github
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it.
Thank you


Obsolete operator conditions tests temporarily

These tests are unreliable so we're obsoleting them temporarily while they get fixed. They are created by a script in gather-extra, but this is unreliable:
https://github.com/openshift/release/blob/4a07b67554d760fc75db4431f38094e82d60d57b/ci-operator/step-registry/gather/extra/gather-extra-commands.sh#L646

Some jobs skip gather on success, so these tests only get created on job failure
Some jobs have multiple post steps, and execution stops if an earlier step fails

/hold
Pending discussion


Feature Request: Building TensorRT Engine for Finetuned Llama-2-7B Model

The feature request is base on the use of TRT-LLM to build a tenssorrt engine from a finetuned llama-2-7b model.
Expatiate on the process built process
Exemplify vanilla optimization process

The feature request has been added in #26


After reinstall OSMC with Raspotify, Sound is Slow, and android app sound progress bar keeps jumping

I had to reinstall my osmc in raspberry pi 2.
I'm using it with pulseaudio and bluetooth dongle, plus mpd and a sony headphone.
In the old install i had no problems, and at a current install mpd and alsa/pulse works fine.
But raspotify goes under problems since i had to do the reinstall.
I have tested some workrounds posted in issues of this git, but with no success at all
There's no error on logs.
So, anyone have some ideia to help me

After last update (apt update), this week jan/2020:
The sound come to be work fine again, with no additional adjusts. Only with "apt update/upgrade"
raspotify      0.16.0~librespot.v0.1.3-37-g0adb851 armhf        Raspotify

After last update (apt update), this week jan/2020:
The sound come to be work fine again, with no additional adjusts. Only with "apt update/upgrade"
raspotify      0.16.0~librespot.v0.1.3-37-g0adb851 armhf        Raspotify


Update MLS validation service to support verifying credentials with ERC-1271 signatures

This is replaced by #646


Update using node 16

If you are using ubuntu-latest, it currently has yq installed. In which case, you might not need this action.
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md


Changing out the Google Custom Search for on-page search

Adding on-site search
This should clear up some of the confusion with the search functionality.

All hail @mindblender ! Awesome work.


Edit multiple points in one go?

This would be a great feature. I have a ton of geoJSON that is slightly skewed from GPS inaccuracies.  This would be so much easier than using qgis ;)

Can you be more specific about what you're asking? It's already possible to edit multiple points in one go by clicking the "Edit" button

Yeah.  What I'm referring to is selecting multiple points with a selection box (or shift and ctrl, much like file selection on your computer) and dragging them all together.  This way you would not have to click and drag individual points one at a time to move an entire route or group of markers.

Okay, that'd be a feature upstream in Leaflet.draw.

This would be upstream in Leaflet.draw - closing here, feel free to re-file there.


Proper erasing of characters - Fixes issue #51

Have tested this on Arch, Debian and Ubuntu - zsh, bash and plain sh.

@briandowns
Thanks for the merge. But unfortunately, I just noticed that while this works for pattern 39, it seems to cause issues for long variable-length patterns like 31 or if there is appended text. In this case the whole text doesn't get erased. (You can run the _example/main.go to understand this better)
In my previous testing I did not include such cases, so I seem to have missed it.

Thanks for noticing that. Is there any chance you'd be able to submit another PR?

Unfortunately, I am traveling right now and won't be able to look into this, at least until Monday. If it isn't fixed by then, I will try to see if I can do anything.


Performance issue when using subclass of ParseObject

A bit of background:
It is a Financial mobile app that calculates the value of a portfolio of transactions.
"Portfolio", "Transaction", "Stock" are all PFObject subclass
each "Transaction" has a column that is a pointer to "Portfolio", another pointer to "Stock"
Events:

PFQuery the "Portfolio" from Parse
PFQuery all the "Transactions" that has a pointer to this "Portfolio", in this case where I can reliably 100% lock it up, there are around 800 "Transactions", this PFQuery has "include" on "Stock" object
Fetch prices of each "Stock" from my own servers (not Parse related)
Loop through all 800 "Transactions", accessing its properties (of type string, number) frequently to do calculations.
Repeat 3&4 every 10 seconds.

Prior in 1.7.5 , step 4 takes around 0.2 seconds to compute, now in 1.8.2, it takes around 5 seconds to compute, so effectively locking up my app half the time.
If I reduce the number of objects I receive in the PFQuery to less than 100 "Transactions", the lock up becomes less noticeable. So I think it is related quickly accessing lots of PFObjects?
I spent sometime, and managed to create a useful XCode project that can demonstrate running the exact same code on Parse SDK 1.7.5 takes around 0.1 seconds,  and on Parse SDK 1.8.2 takes around 3 seconds.
(The calculation code is complicated and taken from my real app, I wish not to reveal the source code to the public, there used to be a way to mark submitted content "confidential" before you guys moved to GitHub, is there still this option now?  Otherwise, I need to mess up the code to make it worthless....)

I ripped apart the code and made a project that is not confidential, but still useful for demonstrating this bug: https://dl.dropboxusercontent.com/u/1874024/ParseSDK-iOS-Issue125-ReproducibleProject.zip
Two projects in the zip, one with SDK 1.7.5, the other with SDK 1.8.2., with exact same code otherwise.  Running on my iPhone 6 Plus iOS 8.4, the 1.7.5 version takes around 0.03 seconds, the 1.8.2 takes 10 to 20 times longer, around 0.70 seconds.
Note: the real algorithm involves a lot more calculation, for demonstration purposes, I extract some of the lines that accessed the ParseObject subclass's getters.  It seems that in SDK 1.8.2, accessing these getter's values is significantly slower than SDK 1.7.5

Thanks for the repro project!
I'll post the results of the investigation here.

Thanks for the super fast response guys, looking at your fix commit explains why it killed performance.  I shall wait for 1.8.3 to be released and hopefully see this completely resolved in my full production app.
Thanks again guys.

:grin:

If you'd like to verify that the fix works, feel free to update your podpsec (temporary, don't use this in production) to point to master:
pod 'Parse', :git => 'https://github.com/parseplatform/parse-sdk-ios-osx.git'

Let me know if you have any more issues!

Hi @nlutsenko @richardjrossiii
So, I finally had time to update my real app from Parse SDK 1.7.5 to Parse SDK 1.8.5 in my production app and it seems the performance issue is not "completely" fixed.  I'm still getting CPU 100% fro way longer than 1.7.5
Just like last time, I made a repo project that somewhat approximate my production app's code, capable demonstrating this performance issue:
https://www.dropbox.com/s/anp64wrr0yewmfr/ParseSDK-iOS-Issue125-ReproducibleProject-UpdatedFor1.8.5.zip?dl=0
Three projects in the zip, one with SDK 1.7.5, 1.8.2 and 1.8.5, with exact same code otherwise. Running on my iPhone 6 Plus iOS 8.4, the 1.7.5 version takes around 0.03 seconds, the 1.8.2 takes around 20 times longer, around 0.70 seconds.  the 1.8.5 takes around 10 times longer, around 0.30 seconds.
I'm thinking there are more than 1 place where you have bugs and you haven't caught them all yet?

Let's reopen this for a follow up then.

There's no bug here. We changed the way that properties are dynamically resolved in 1.8.0, to make it more robust in the future. The old implementation was faster, but relied upon a bunch of undefined behavior, the code was extremely tightly coupled to PFObject, and overall just didn't work.
So, in 1.8.0, we switched the implementation to use NSInvocation objects instead of crazy imp_impelementationWithBlock hacks, as imp_implementationWithBlock, especially on systems where you cannot copy a page with execute permissions (e.g. iOS, where mprotect always fails for execute), can easily run out of block trampolines.
It is true that the NSInvocation method is significantly slower, but it's also true that it's the best cross-platform and non-architecture specific (important as we being targeting bitcode and archs like ARMv7k) to have a more stable solution.
I know this doesn't solve your performance issues, but unless you know of a way to do JIT inside of an application, there's not that much we can do, sadly.

As a workaround, you could make the properties of your model objects non-dynamic, e.g.:
@interface foo : PFObject<PFSubclassing>

@property int bar;

@end

@implementation foo

- (int)bar {
    return [self[@"bar"] intValue];
}

- (void)setBar:(int)newBar {
    self[@"bar"] = @(newBar);
}

@end

It's a little bit more code, but it will be faster than going through the dynamic message forwarding dispatch, which is what most of the time overhead you're seeing is.

Thanks for the workaround, I can confirm the work around solves my performance issues.
I do agree with you, proper code is always better than having hack.   Good programmers write proper code once aiming for it to work for years and years rather hacks that is gonna keep popping up with issues.
Thanks again for the help.


D3 3 broken with babel application

Hello
I have a requireJS+babel application which uses "transform-es2015-modules-amd" plugin.
Recently I updated to d<IP_ADDRESS> and now my transpiled code no longer works with d3.
The reason seems to be the following line at the end of  https://d3js.org/d3.v4.js
Object.defineProperty(exports, '__esModule', { value: true });
For me, during runtime everything is amd modules, and transform-es2015-modules-amd uses the same __esModule to mark the modules it has transpiled, modules without the __esModule=true are handle a bit differently.
Anyhow, d3.js apparently was build by a different build system (rollup, webpack, I don't know) which also sets __esModule=true but does not play along with babel.
I think d3 could be changed to work with babel, the first lines in d3.js it selects the module system:
(a)  typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
(b) typeof define === 'function' && define.amd ? define(['exports'], factory) :
(c)  (factory((global.d3 = global.d3 || {})));
I think the "Object.defineProperty(exports, '__esModule', { value: true });" is only needed for the (a) case. The (b) case is AMD runtime, which is my case, if __esModule is not set then my code should just work. The (c) is putting d3 in the global name space, certainly that doesn't need __esModule.
In short, at the end of d3.js I wish we could have:
if (typeof exports === 'object' && typeof module !== 'undefined') {
Object.defineProperty(exports, '__esModule', { value: true });
}
Thank you
Felipe

This behavior is entirely controlled by Rollup. If you’d like to change Rollup’s output for its UMD format, please file an issue over on rollup/rollup.

Okay, filed https://github.com/rollup/rollup/issues/998
Thanks


Always pass Error instance to failure callback

Previously the failure callback for the get() method may receive either an Error object or a string message.  By Cordova convention a failure callback should always receive an instance of JavaScript error. This PR makes the logic consistent and always pass an instance of JavaScript error following Cordova best practice.
This PR also fixes minor issues in unit tests so all tests now pass:

Thanks for this, will have a look asap.

@sgrebnov Hi, why not add the executeNativeMethod function in securestorage.js and avoid noise and repetition of code. executeNativeMethod could use the _checkCallbacks that already exists in securestorage.js

I can update the code if this is an issue, but smaller files with single class/thing inside is easy to use/follow/maintain IMO. But I can definitely update the code if this does not play well with current architecture/design.

I would indeed use securestorage.js, there's very little code there anyway... Keep using your executeNativeMethod naming though.
Otherwise GTP, please also update the changelog with your contribution.

Updated the code: moved _executeNativeMethod to securestorage.js

Regarding the CHANGELOG note: not sure what should be done at this point - I expect it to be updated during plugin release along with plugin version bump.

Thanks again.


Is large_files.zip corrupted ?

I am wondering if the large_files.zip is corrupted? I am not able to obtain the train_data and topic_human_evals folders from the large_files.zip file. Is there any way that I can get those two folders? Thanks

Hi,
Sorry for the delay, I must have missed the issue notif. Anyway, I tried to download it myself on MacOS and was able to unzip and access things fine, but I did notice warnings such as the following when I tried to decompress using the "unzip" command.
warning [large_files.zip]:<PHONE_NUMBER> extra bytes at beginning or within zipfile
  (attempting to process anyway)
file #1:  bad zipfile offset (local header sig):<PHONE_NUMBER>
  (attempting to re-compensate)

What command are you using to decompress, and if it's not "unzip" could you try using that?

For future reference to anyone else with this issue-- I got another report that this didn't work and did some more investigation, it seems like it won't unzip on Linux for some reason, sorry. The raw files are available at https://drive.google.com/drive/folders/1GZfOGqpQxDmIfD2RvuhUQla9eX2OHUXU?usp=sharing .


Sql

As we are going to use Datasette we don't need this. This solution will be only if we don't have a server


[Docs] Update docs for Icon Button

@Zadielerick It looks good :+1:. Can you squash down?

@Zadielerick Yeah, one more, great job :+1:

@Zadielerick Awesome job :+1:  :+1: :+1: you've been a huge help ^_^

No problem! Hope I can finish all the components by next week!


Simple fix for "Error in data stream"

In case others are also encountering this error on batch downloads, here's a simple fix.
diff --git a/packages/dukascopy-node/src/buffer-fetcher/index.ts b/packages/dukascopy-node/src/buffer-fetcher/index.ts
index fbe14ce..0818e7b 100644
--- a/packages/dukascopy-node/src/buffer-fetcher/index.ts
+++ b/packages/dukascopy-node/src/buffer-fetcher/index.ts
@@ -78,7 +78,10 @@ export class BufferFetcher {
       return this.fetcherFn(url);
     }

-    const data = await fetch(url);
-    return data.buffer();
+    while (1) {
+      const data = await fetch(url);
+      if (data.status==200) return data.buffer();
+      await wait(100);   // Back-off before retry
+    }
   }
 }

@straitsboy awesome, thanks. I'll check it and will include in the new version!

@straitsboy can you also share the search config for which this fix is for? So I could replicate it on my side

Hi Leonid,
This error happens randomly. Sometimes everything goes smoothly with no errors. Other times it gets loads of 503 responses. I believe it is because Dukascopy is rate-throttling on their end. So there's nothing much we can do about it, except to retry the fetch when it happens.
Here's an example that I just ran. I ran it three times. Twice it ended with no errors. On the third run, it gets several 503 errors. I've attached an excerpt of the logs...
  {
    instrument: 'usdtry',
    dates: { from:<PHONE_NUMBER>000, to:<PHONE_NUMBER>000 },
    timeframe: 'h1',
    format: 'json',
    pauseBetweenBatchesMs: 1000
  }

  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/02/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/05/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/06/BID_candles_hour_1.bi5
  200 OK https://datafeed.dukascopy.com/datafeed/USDTRY/2019/09/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/01/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/03/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2019/10/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2019/11/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/04/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/02/BID_candles_hour_1.bi5
  200 OK https://datafeed.dukascopy.com/datafeed/USDTRY/2020/00/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/06/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/05/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/03/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/01/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2019/10/BID_candles_hour_1.bi5
  200 OK https://datafeed.dukascopy.com/datafeed/USDTRY/2019/11/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/05/BID_candles_hour_1.bi5
  503 Service Temporarily Unavailable https://datafeed.dukascopy.com/datafeed/USDTRY/2020/02/BID_candles_hour_1.bi5
  ...

@straitsboy the issue has been addressed. You can install the new version<EMAIL_ADDRESS>New config params were added: retryCount and pauseBetweenRetriesMs. See source code: https://github.com/Leo4815162342/dukascopy-tools/blob/master/packages/dukascopy-node/src/buffer-fetcher/index.ts#L89-L101
You can use them like this:
{
      instrument: "usdtry",
      dates: { from:<PHONE_NUMBER>000, to:<PHONE_NUMBER>000 },
      timeframe: "h1",
      format: "json",
      pauseBetweenBatchesMs: 1000,
      retryCount: 15,
      pauseBetweenRetriesMs: 100,
    }

That's great! Thank you very much. :)


Implement inline styles for FlexColumns

Sometimes, it's desirable to mark up a column with inline styles without having to specify a cellRenderer function.  eg. Trying to draw attention to a sorted column by giving it a background color, or applying a textTransform to the contents.  This PR implements the ability to use inline styles with your column simply and easily.  It also conservatively merges in the computed styles related to maxWidth, minWidth, and flex.

codecov/changes seems to think I added a bunch of files.  Not sure what's up there.

Thanks for putting this PR together. I'm currently chatting with @kof on issue #197 about a related topic so I'd like to hold off on this until I've decided how to proceed there. (The themes we're talking about might also support styles so...) Feel free to check out that thread (and the related one here) if you'd like to add any input.

[Current coverage][cc-pull] is 100%

Merging [#205][cc-pull] into [master][cc-base-branch] will increase coverage by +8.47%

@@           master       #205   diff @@
========================================
  Files          26         49     +23
  Lines         780       6580   +5800
  Methods         0       3935   +3935
  Branches      163        842    +679
========================================
+ Hits          714       6580   +5866
+ Misses         32          0     -32
+ Partials       34          0     -34

4 files (not in diff) in source/utils were modified. more

Misses -1
Hits +47

5 files (not in diff) in source/Grid/utils were modified. more

Misses -2
Partials -2
Hits +118

1 files (not in diff) in source/Grid were modified. more

Misses -11
Partials -10
Hits +571

2 files (not in diff) in source/FlexTable were modified. more

Hits +30

6 files (not in diff) in source/Collection were modified. more

Misses -16
Partials -14
Hits +663

6 files (not in diff) in source were modified. more

Misses -2
Partials -5
Hits +465

2 files in source/FlexTable were modified. more

Partials -3
Hits +419

2 files (not in diff) in source/utils were created. more
5 files (not in diff) in source/Grid/utils were created. more
1 files (not in diff) in source/Grid were created. more

[][cc-pull]

Powered by Codecov. Last updated by 45356e8
[cc-base-branch]: https://codecov.io/gh/bvaughn/react-virtualized/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/bvaughn/react-virtualized/pull/205?src=pr

It is still important to differentiate themes and runtime  styles, if this is something a user will want to modify at render time, then it should be part of style object in props.

@kof I just finished looking over the discussions @bvaughn linked to, and I wholeheartedly agree.  Being locked into a particular theming style or structure of style management by an external component would be a hearty 👎.

I feel like I totally botched my PR by checking in dist/ code, but it seemed like the right choice at the time (considering I had to push my built code to my branch to test it live in my app).  Now that you've updated to 6.3.0, I'm not sure how to resolve the resultant conflict (in a sourcemap file).
My first instinct is to just nuke this PR and create another one that's fully up to date, but I will wait to hear what you'd like to see first.

because dist should never be in the repository, it should be published to npm

That's what I thought, but the fact that it was in the repo made me second-guess myself.  :-)

because dist should never be in the repository, it should be published to npm

Binary dist files don't belong in a repository because they can't be diffed and so the storage is inefficient. Whether or not JavaScript dists belong in a repository is a matter of opinion. There are a lot of practical benefits including:

Easy for a maintainer to verify what's changed between tags.
Easy for contributors (using rawgit.com) to link Plunkers or other demo files to different versions of a library to demonstrate problems. (Granted this is also possible with npmcdn.)

Anyway, try not to assume such a one-size-fits-all outlook. PRs probably shouldn't include dist as a general rule- but even so, it's very easy to recover a PR like this. Just reset the dist folder to origin/master and re-build NPM if you want to test your updated changes.

@bvaughn Thanks for the advice -- I'll give it a shot.

To be honest though, I have considered (and still do consider) removing dist from Git since it does get in the way sometimes (like this). It's just not an obvious choice (for me) as it does provide some conveniences. :)

it was always a pain for me and lots of other popular projects I watch, so common sense I could recognize was do add dist to .gitignore and to add .src to npm ignore and generate lib and dist, where lib is a transpiled version. Putting es2015 into src will cause you also problems, see for e.g. redux setup.

It hasn't caused any problems for me (excluding this PR) and it has been convenient when I want to quickly performance test arbitrary version ranges of the library. I do understand why you prefer that approach though. I just think it should be up to the library maintainer.

Putting es2015 into src will cause you also problems, see for e.g. redux setup.

Not sure I understand what you mean?

Getting back to the topic of this PR...

It is still important to differentiate themes and runtime styles, if this is something a user will want to modify at render time, then it should be part of style object in props.

I'm not convinced it's practical to support inline style objects for components as complex as some of the react-virtualized ones. It's simple when we're talking about a component like Alert but FlexTable for example has a lot of internal parts. Allowing each one of them to be customized by either a class-name or style param seem like it might get bloated.

That is true, it depends on whether a style object can break the component or not. So either leave it up to user and make him responsible or support only specific props, which are then applied to the style if needed.

Yeah. My goal has been to keep react-virtualized components as invisible as possible. They set flex properties and such but they avoid things like borders, background colors, etc. As much as possible I prefer for that sort of style to be set by the rendered because that's the most flexible solution. You can use CSS/JSS/LESS/styles/whatever-you-want.
I think FlexTable is the one exception to this because without a few minimal styles, headers wouldn't make sense.

That being said, the type of change made in this PR would already be supported by specifying an inline style via the column renderer. It's just a question of convenience.
@MikeMcElroy I wonder if you considered using a HOC for this? Maybe something like...
export function styledCellRenderer (style: Object): Function {
  return function renderer (
    cellData: any,
    cellDataKey: string,
    rowData: any,
    rowIndex: number,
    columnData: any
  ): string {
    const displayText = cellData == null
      ? ''
      : String(cellData)

    return (
      <div style={style}>
        {displayText}
      </div>
    )
  }
}

Then you could reuse it in a more lightweight way...
<FlexColumn
  cellRenderer={
    styledCellRenderer({
      backgroundColor: 'blue'
    })
  }
  displayKey='id'
  header='ID'
  width={50}
/>

@bvaughn I actually did try that, and got this output:

when what I wanted was this:

@MikeMcElroy Your style probably just needs to specify a height: 100% value, no?

For one, I just tried that, and it doesn't work because the output of cellRenderer winds up in the truncated text div, which does not have height:100% specified.  For two, it's still not as flexible as using an inline style on the column -- if I want a background color on already custom-rendered content, I'll have to wrap my cellRenderer in the styledCellRenderer, and remember to set the height to 100%.  It seems like that makes it needlessly difficult.  There are many ways to accomplish a task in JS/HTML/CSS, but certain ways require more complexity than others.

Also, you do allow the user to directly style the containing div through classes (cellClassName is appended to the "outer cell div"'s className attribute.  I'm hoping that we can allow for style semantics to behave this same way.

@MikeMcElroy~ Just a friendly reminder that I'm just one guy and I maintain react-virtualized and my other OSS projects in my spare time. So when feature requests come in, before committing to do them, I need to consider a few things.

Are there any available workarounds available to users that wouldn't be an unreasonable amount of effort for them and would prevent requiring a library update? Many times this is the case. That's why I asked if you had considered something like what I wrote above.
Is it something I'll have the time to manage going forward? Each new feature adds complexity and potential for bugs. It's great when someone submits an initial PR to add a feature- but even so I'm probably the one who will end up maintaining it going forward.
Will it negatively impact performance?
Does it fit with the rest of the interface in a cohesive way or is it just a one-off for a very specific use case?

I think we probably both want the same thing here- a better, more flexible interface for users. In my thinking, the styling/theming changes that @kof and I have been discussing will probably be released with version 7. If I'm going to override the styling system, I might like to remove some of the redundant class-name properties (so I don't end up supporting multiple ways to do the same thing) and that will require a major release. So it's probably something that won't happen immediately as I'll need to give it a lot of thought beforehand. (If you're interested, I have a version 7 roadmap wiki page here.) So I mentioned what I said above as a potential, temporary workaround for you.

@bvaughn By no means was my argument meant as a slight at your awesome work w/ RV, and I apologize for it seeming that way.  I'm currently in a POC stage with RV at work, and the inline style battle has been fought already and decided on internally, but if I can't reasonably show that we can style columnally (inventing words FTW), it's a major ding against RV for our uses.

No worries. Text communication is difficult. It's often hard to tell what someone means. I appreciate the added insight into what's happening on your end.
The use case you're describing is actually 2 features rolled into 1:

Support custom inline styles.
Support styling an entire FlexTable column (not just individual cells).

Even if there were inline style equivalents to all of the currently-supported class properties, you still wouldn't be able to style the column in the way you're trying to (without overriding the default height of .FlexTable__truncatedColumnText). I agree this is too much hassle. FWIW deciding on a default DOM/style structure for FlexTable cells was obnoxious. I think most people want text to truncate inside of a "table" cell but the flex container spec doesn't make that easy. That's why I had to add the nested <div>.
Hm. Maybe I can put out a quick point release that adds some kind of column-style-support. Let me think on it a bit more.

Ping on this issue re: v7?

Still working on v7 (see PR #206). Hit a bit of a snag with dynamic cell measuring that I'm trying to work through. Other than that, I think styling/theming is the last big area to be finished.
Working on it as fast as I can but... I'm sick this week and I have my day job, so it's slow going.

Just looking for an update.  Carry on.

No worries. Haven't forgotten. Just been a bit overwhelmed this week. :)

There's a note on PR #206 about something that's causing problems with the CellMeasurer:

Figure out why CellMeasurer does not play nicely with VirtualScroll. (It's currently throwing the error, "Only a ReactOwner can have refs.".)

If you find yourself feeling ambitious and charitable, feel free to check it out. :)

Closing in favor of version 7 PR #206 (which I plan to merge momentarily). It supports a style property on FlexColumn as you've proposed. :)


Ability to change atmosphere color

This has been asked for a few times, including this forum post and this FOSS4G presentation.
Good beginner graphics issue.

Hi @pjcozzi , can I work on this one?
In this file SkyAtmosphereVS.glsl,
const vec3 v3InvWavelength = vec3(
    5.60204474633241,  // Red = 1.0 / Math.pow(0.650, 4.0)
    9.473284437923038, // Green = 1.0 / Math.pow(0.570, 4.0)
    19.643802610477206); // Blue = 1.0 / Math.pow(0.475, 4.0)

I think this is what needs to be modified? Any pointers on how to implement?

Some additional realism could be added to the atmosphere when lighting is enabled by fading the brightness or alpha on the night side of the globe.
It might also be cool down the track to combine the existing fog and atmosphere into a unified shader.  The new Google Earth JS app does this, and there is another GLES/Unity example at http://scrawkblog.com/2014/05/19/proland-to-unity-atmosphere/. This might be a bigger effort though.
There are some additional posts on that blog regarding varying the Rayleigh scatter value to produce different colors, but I think that's more related to Earth's atmosphere at different times of day.

@tokyovigilante Can you help me work on this bug ? :P

Sure, my physics background doesn't cover optics extensively, but we can give it a crack.
Have a look at Mie and Rayleigh scattering online.
The atmosphere in Cesium is currently based on this GPU Gems article
There is a DX9 implementation for the Proland renderer I posted above. I've just found another OpenGL implementation which has an impressive YouTube demo and should be relatively easy to port over to Cesium, however it has a fairly heavy fragment shader so I'm not sure about performance.
What effects are you aiming to implement? I would suggest increased realism during sunrise and sunset and day/night fading when the camera is in space are most useful.

First I would like to know,
Do we need to implement an API to change atmosphere colour?

Again that depends on your goal. If you want a more realistic representation of Earth's atmosphere, you'll need to implement one of the approaches I've mentioned above.
If you want to represent a different atmosphere, then you need to understand that the mixture of gases determine the scattering of sunlight and therefore perceived color, and alter input parameters, which to do effectively you'll again need to understand Rayleigh scattering.
Lastly, if you just want a ground-based view to have a different color, just turn off the atmosphere entirely and use either a static background color or a SkyBox with custom textures to simulate the atmosphere you want.


Display a message when there are no rows in the output table

Rather than printing an empty table and making the user think they might have
messed up, warn that there is nothing to output.
Fixes #23

Thanks!


Decompilation fails with "Unfinished decompilation was KILLED !!!"

[RetDec info]   :	Running the decompilation command ...
[RetDec info]   :	Working on input file "C:\Users\morph\Desktop\Sandbox\MalwareTest.exe".
[RetDec info]   :	Found retdec-decompiler.py at C:\Users\morph\Desktop\Database\Reverse-Engineering\Decompilers\retdec\bin\retdec-decompiler.py -> plugin is properly configured.
[RetDec info]   :	Running retargetable decompiler plugin:
[RetDec info]   :	Unfinished decompilation was KILLED !!!
[RetDec info]   :	Saving IDA database ...
Flushing buffers, please wait...ok
[RetDec info]   :	IDA database saved into :  C:\Users\morph\Desktop\Sandbox\MalwareTest.dec-backup.idb
[RetDec info]   :	Generating retargetable decompilation DB ...
[RetDec info]   :	Decompile input ...
[RetDec info]   :	Local decompilation ...
[RetDec info]   :	Decompilation command: "C:\Users\morph\Desktop\Database\Reverse-Engineering\Decompilers\retdec\bin\retdec-decompiler.py"
"C:\Users\morph\Desktop\Sandbox\MalwareTest.exe"
--config="C:\Users\morph\Desktop\Sandbox\MalwareTest.idb.json"
--color-for-ida
-o
"C:\Users\morph\Desktop\Sandbox\MalwareTest.exe.c"
--select-decode-only
--select-ranges="0xa50e70-0xa51092"
[RetDec info]   :	Running the decompilation command ...

Pictures of Settings:
Settings Picture

Hi. A couple of questions:

What IDA version do you use?
What version of the RetDec IDA plugin do you use?
What version of RetDec do you use?
Does it fail for all files that you try to decompile or only for the reported one? If only for the reported one, could you please attach it so we can try to reproduce the issue.

Hi. A couple of questions:

What IDA version do you use?
What version of the RetDec IDA plugin do you use?
What version of RetDec do you use?
Does it fail for all files that you try to decompile or only for the reported one? If only for the reported one, could you please attach it so we can try to reproduce the issue.

IDA Version: 7.0
v0.7
v3.2
Different error for another test, Test 2
No longer produces the "Unfinished decompilation was KILLED !!!" log

Could you please attach the input binaries that you are trying to decompile? You can zip them and upload them here via Attach files in the comment box.

Just a guess: Did you try running multiple decompilations at the same time?

Just a guess concerning the originally reported issue: Did you run multiple decompilations at the same time?

This has fixed both problems, and yes I did run multiple decompilations at the same time.

Unfortunately, the plugin currently does not support multiple simultaneous decompilations. Once you run a second decompilation, the first one gets automatically killed.
I am marking this as closed since the issue was resolved for you.

I created an issue to support multiple decompilations - #35. This is however not a priority right now, since it would be quite difficult to implement and we have some serious problems even with a single decompilation.


MIDI Synth - Big Update

Description
MIDI Changes

ADSR!
Multiple instrument banks
Simple pitch-shifted samples
Actual instrument definitions without hardcoded behavior
Many small things
platform-midi library submodule for basic OS MIDI support

Synth Mode Changes

New instrument icons
Lots of menus for controllers, etc.
Added wheel menu and related icons

Font Stuff

drawTextBounds(): Lets you write text, chopped off at arbitrary bounds
drawTextMarquee(): It's back, and it's coming to your swadge!
drawTextEllipsize(): Auto-ellipsizes text within a boundary
drawTextMulticolored(): Lets you draw rainbow-y text and such
Fixed an oversight in drawTextWordWrap() that made it un-continuable

Drawing Functions

drawRectFilled(), because fillDisplayArea() is much more fragile
drawCircleFilledQuadrants() to go along with drawCircleQuadrants()
drawRoundedRect()

Menu Stuff

Mania menu renderer uses drawTextEllipsize() if necessary (or drawTextMarquee() for the currently selected item)
Menu now updates 'current value' properly for settings option items
Utilities for easily saving and restoring the menu position between reconstruction

Other

addBefore() / addAfter() functions for linked_list
All sorts of fixes and improvements for wheel menu
Fixed a crash in the raw file preprocessor

Documentation

Updated docs for DNF packages which have changed slightly since last time

Test Instructions
Go crazy on the synth mode in the emulator and the hardware.
Ticket Links

Readiness Checklist

[x] I have run make format to format the changes
[x] I have compiled the firmware and the changes have no warnings
[x] I have compiled the emulator and the changes have no warnings
[x] I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
[x] I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
[x] I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

Also, being honest, I skimmed this review. It'd have been a lot to read...

Also, being honest, I skimmed this review. It'd have been a lot to read...

That's pretty fair, it's over 200 commits and like a billion lines. As long as the library code changes look good!

Something something more frequent, smaller PRs please


useSWRPages is not exported from swr

I am new to swr package, and I came to know it from a tutorial over the internet, which import a function named useSWRPages from the 'swr' package and uses it to paginate results from call made to API
However when I run the code , it says that 'useSWRPages' is not exported from 'swr'
Did the function exist but has been depreciated or it never was and that's the author's mistake?

@marouaneat95 useSWRPages was removed from swr since v0.3.0. you can use useSWRInfinite instead. checkout the usage sample in https://swr.vercel.app/examples/infinite-loading


Fix error when clean up scripts run

What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
The clean up scripts were relying on the shells rm -rf command which was causing to fail when the files matching the pattern were missing. I've replaced this with the del-cli node package that ignores those missing files.
Which issue (if any) does this pull request address?
This is addressing https://github.com/aralroca/next-translate/discussions/891
Is there anything you'd like reviewers to focus on?

@all-contributors please add @crs1138 for maintenance


Dataspreadsheet: cell selection area/s

What will this achieve?
This will allow the user to select one or multiple cells within the spreadsheet. When selecting groups of cells, there can also be multiple selections made
How will success be measured?
When you can select one or more groups of cells within the spreadsheet component.
Additional information

Designs
Existing code
etc

Complete


Elasticsearch Install Error

Expected behavior
Elasticsearch should be installed
Actual behavior
Error
Information about the Issue
(HTTP code 404) unexpected - manifest for elasticsearch:latest not found
Steps to reproduce the behavior
install docker for mac
install hello-world-nginx from mac command shell
install kitematic
install jenkins from docker
instal eliasticsearch from docker

I have the same issue, now 4 days later.

I have the same issue.


[WIP] Validate interdependencies in InterDependencies object

This is a yak-shave PR 🙂
In order to validate array parameter interdependencies when adding results (as pointed out by @jenshnielsen in #1430), I want to refactor all the inter-dependency validation out of the datasaver and into a dedicated object.
So far, this PR does it for register_parameter. Next step: add_result. After that refactor, I believe that it will be much easier to add the length check to add_result without screwing up something.
Changes proposed in this pull request:

Extend the InterDependencies object to do validation. The validation is done in the __init__ to avoid confusion by mutation
Refactor all validation from the measurements.py module into use of that object

@QCoDeS/core

Hopefully #1453 has resolved the issues seen in the tests here

Closing this in favour of #1477


Material Theme Builder PopUp not responsive

Hi! I loved the plugin but there is a row of buttons I can't see. I tried it on a bigger screen but still can't see the row of buttons. The popUp  stays the same.
I inspected the browser app and found out one of the elements has a fix height, while the other elements have their heights set on 100%
I dont know if this is the root of the problem, but I hope this helps.
Thanks!

Thank you! I was having a weird issue with height: 100%. But i will try a few things to fix it.
Is your system font or display scaled at all?


[feature request] new field sdk/compiler for determine compatibility

I mean what will be great if in the each lib haxelib.json contains field about compatible & tested version of Haxe compiler+std.

This sounds useful indeed! Also consider npm implementation: https://docs.npmjs.com/files/package.json#engines

I like impl. in the NPM. Couple of things:
For implement this feature we need to fully support semver. As i know now it is not (really?).

In the NPM impl. note:

Note that, unless the user has set the engine-strict config flag, this field is advisory only.

I think we do not have to create new define as there engine-strict. Instead it I see two options:

Fields "sdk"/"haxe"/"engines"is advisory only constantly and ever.
If these fields are present in haxelib.json => Haxelib have to strictly test fact of existing and version of each tool. Question how? because then we need a "where-to-look"- and "how-to-ask-version"-scheme for each possible third-party tool. (Getting the version of Haxe isn't a trouble because the compiler runs Haxelib in interpret mode and we have defines such as haxe_ver. ).

Anyway this fields must be optional of course for for backward compatibility.
Format and field-names variants:

"sdk" or "haxe" or "compiler": { "sdk" : ">=3.0.0 <3.3" }
"engines" or "tools":

{
  "engines": {
    "haxe": ">=3.0.0 <3.3",
    "node": ">=0.10.3 <0.12",
    "protoc": ">=3.0.0"
  }
}

Now new question: What kind of things can be specified in "engines"? Only executable cli-tools or maybe dynamic libraries or .so?

Correct me if I'm wrong, but I think NPM only supports hard-coded stuff like "node" and "npm", so it's not as pluggable as it seems. Maybe we should keep it simple only support "haxe/sdk/compiler/whatever".
I think it should be only advisory and the only thing it should do is emit a warning on installation (IIRC that's also how NPM works).
You're right about semver comparisons, we should first implement that, but there's still no consensus (see #81), so we have to delay this one until we agree on some version management mechanism.

Correct me if I'm wrong, but I think NPM only supports hard-coded stuff like "node" and "npm", so it's not as pluggable as it seems. Maybe we should keep it simple only support "haxe/sdk/compiler/whatever".

Then maybe first variant ("sdk" or "haxe" or "compiler": { "sdk" : ">=3.0.0 <3.3" }) and then we can use already existing dependencies part like that:
{
  "name": "openfl",
  "dependencies": {
    "lime": "",
    "haxe": "3.2"
  },
}

NPM only supports hard-coded stuff
Not sure because found { "engines" : { "iojs" : "1.6.1" } } in that post and never used this feature.

dependencies has the meaning of "add this lib to the compilation"
so unless haxe becomes a haxelib package (which would be cool) it's weird here.

agreed

:) If Haxe becomes a haxelib package we will real true virtual environment like one for Python. That will be cool.

I don't see how this (haxe as lib) could be easily done and tbh don't want to think about it at least for the forseeable future. The original "compiler" field idea is still worthy IMO.

A simple proxy exe which sends all its arguments to $(haxelib path haxe [version])/haxe with the required haxe_std env var should work without too much issues I guess (hope).
Thanks to Andy knowing about/getting updates on linux isn't an issue any more, but mac or windows it's still there,
but that's another issue.
The haxe field could still be used to warn about a haxe version too low (or too high?) for the lib the user is trying to install.


Fix/wrong snapshot versions

This PR fixes wrong snapshot versions – by bumping the aggregate version after successful commit but before snapshotting.

I can confirm that this fixes the issue with snapshotting.

BTW we don't have this covered with tests. All tests where green before this fix.

Yep that's true – i will setup a test for the repository.

:+1:

@darko-mijic added integration tests – you can verify it's working by commenting out this line:
https://github.com/meteor-space/event-sourcing/blob/fix/wrong-snapshot-versions/source/server/infrastructure/repository.coffee#L31

Thanks Dominik. I can verify that test and fix are working correctly. This can be merged.

Go for it! :+1:
Merging own PRs should be a rare exception :wink:


feat: external db reconnect

Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:

[ ] Target branch: Please verify that the pull request targets the dev branch.
[ ] Description: Provide a concise description of the changes made in this pull request.
[ ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[ ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[ ] Testing: Have you written and run sufficient tests for validating the changes?
[ ] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[ ] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:

BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry
Description
This builds off of #2666 that refused to cooperate with SQLite. Now the backend should automatically attempt to reconnect with the SQLite or Postgres DBs if the connection is dropped.

Not needed because of this: #3228. It's already in development.

Not needed because of this: #3228. It's already in development.

As of the last time I tested it, that earlier PR did not work properly if you were using the default SQLite database. I'll test this one later today when I have time to see if it addresses that issue.

@justinh-rahb, the PR that @RobinBially excellently delivered was open ~5 hours ago (#3228). I believe you might be mistaking it for #2666.

@justinh-rahb, the PR that @RobinBially excellently delivered was open ~5 hours ago (#3228). I believe you might be mistaking it for #2666.

You're correct. I blame insufficient supply of caffeine

@justinh-rahb, the PR that @RobinBially excellently delivered was open ~5 hours ago (#3228). I believe you might be mistaking it for #2666.

You're correct. I blame insufficient supply of caffeine

It's all good! I'm just hoping one of these 3 PRs pan out for open-webui. Good luck caffeinating further :)

Should be good to go now, verified it locally for both Postgres and SQLite. Tried on both completely new databases, and previously existing ones. Waited 15 minutes between new queries, repeated 3x times. Seems like it's finally working 🎉

I can't seem to break it.
Running with postgres database, I can now restart postgres and it no long requires to restart open-webui.
Running with SQLite localfile I can remove the database, It will attempt to create a new one, but if i replace it with the original it continues as expected.
Running with SQLite over a network connection i can break the connection and open-webui work once restored.

That's great to hear! 💪

hell yeah brother

let's gooooo


Warn when a store handler registers an undefined handler

We want to protect against:

This will ship in v9.18.0!


In seconds huh

50 secs of shady npm bogus progress bar into crash. fix

Please provide exact steps to reproduce your problem and a full error.


TS2339: Property '$vuetify' does not exist on type 'default'

when i use this.$vuetify.goTo()
i use ts

This question is available on Nuxt community (#c9442)

I am having the same issue with this Sentry Nuxt plugin
54:12 Property '$sentry' does not exist on type '{ triggerError(): void; }'.
    52 |   methods: {
    53 |     triggerError () {
  > 54 |       this.$sentry.captureException(new Error('Manually triggered exception'))
       |            ^
    55 |     }
    56 |   }
    57 | }

How do I let TS know about such top level variables? Is this the relevant Nuxt Typescript documentation? If so, where does the TS definitions go?

I have to add this and it's work for me:
import { Framework } from 'vuetify'

declare module 'vue/types/vue' {
  // this.$vuetify inside Vue components
  interface Vue {
    $vuetify: Framework
  }
}

import { Framework } from 'vuetify'
declare module 'vue/types/vue' {
// this.$vuetify inside Vue components
interface Vue {
$vuetify: Framework
}
}

added where?

import { Framework } from 'vuetify'
declare module 'vue/types/vue' {
// this.$vuetify inside Vue components
interface Vue {
$vuetify: Framework
}
}

added where?

import { Framework } from 'vuetify'
declare module 'vue/types/vue' {
// this.$vuetify inside Vue components
interface Vue {
$vuetify: Framework
}
}

added where?

in nuxt.config.js
  // Plugins to run before rendering page (https://go.nuxtjs.dev/config-plugins)
  plugins: [
    { src: '~/plugins/vuetify.ts' }
  ],

in plugins/vuetify.ts
import { Framework } from 'vuetify'

declare module 'vue/types/vue' {
  interface Vue {
    $vuetify: Framework
  }
}

import { Framework } from 'vuetify'
declare module 'vue/types/vue' {
// this.$vuetify inside Vue components
interface Vue {
$vuetify: Framework
}
}

added where?

in nuxt.config.js
  // Plugins to run before rendering page (https://go.nuxtjs.dev/config-plugins)
  plugins: [
    { src: '~/plugins/vuetify.ts' }
  ],

in plugins/vuetify.ts
import { Framework } from 'vuetify'

declare module 'vue/types/vue' {
  interface Vue {
    $vuetify: Framework
  }
}

Add vuetify  to your tsconfig.json file like this
"types": [
  "@nuxt/types",
  "@types/node",
  "@nuxtjs/auth-next",
  "vuetify"
]

Add vuetify  to your tsconfig.json file like this
"types": [
  "@nuxt/types",
  "@types/node",
  "@nuxtjs/auth-next",
  "vuetify"
]

I did that, still no luck

@JuanCarlosRC Have you tried changing vuetify to $vuetify and see? That might work.

@JuanCarlosRC
try declaring types as:
   "types": [       "@nuxt/types",       "@types/node",       "@nuxtjs/auth-next",       "@nuxtjs/vuetify",     ],
replacing 'vuetify' with '@nuxtjs/vuetify', or whichever alternative vuetify module for nuxtJS that's installed
My understanding of the error is that Typescript is not compiling @nuxtjs/vuetify's type package, either because @nuxtjs/vuetify is not saved in a default folder under node_modules, or because "types" was specified and thus only packages in "types" will be compiled. (ref: https://www.typescriptlang.org/tsconfig#types)

All previous attempts did not works. what worked is this
// src/shims-vue.ts
import Vue from 'vue'
import {Framework} from "vuetify";
import VueRouter from "vue-router";

interface PluginTypes extends Vue{
  $vuetify: Framework
  $router: VueRouter
}

declare module '*/**.vue' {
  type Vue = PluginTypes
}
declare module '*/**.Vue' {
  type Vue = PluginTypes
}
declare module 'vue/types/vue' {
  type Vue = PluginTypes
}

Don't forget to include "vuetify" in tsconfig.json, can omit nuxtjs if not using
"types": [
  "@nuxtjs/vuetify",
  "vuetify"
]


 This breaks from the Google style guide for Python. Do we care?
Fixes #262.
cc @jtattermusch

It also doesn't appear to format Cython code... Do we care?

Whoa. Thank you much!
Yes, we do care about breaking with the Google Python Style Guide. Please describe the differences in your commit message? Alternatively, is there such a thing as a ".pyformatrc" that we could use to maintain compliance with the style guide and/or put us more in control of exactly what differences we maintain?

We do care about formatting Cython code - I guess my reason for that would be "we have enough of it". If it can't be done today in this change, open a fresh issue for it?

LE GASP. Google's internal Python style guide is different from the external style guide! I'll have to go back and check over its agreement with PEP8.

They appear compatible.

This currently needs conflict resolution - hold off on rebasing until after 6609 and 6602 are integrated? Then let's cross our fingers and attempt integration of this?

rebased

How about we come back to this after pull request 7338?

Rebased.

I'd actually like to hold off on doing this before GA. Would rather not inadvertently force rebases for upmerges from v1.0.x.

Or, rather, I guess I'd prefer having this get simultaneously cherry-picked onto the v1.0.x branch just before 1.0.1.

I also fear that this will bring pain to anything that follows it and that has to be done on more than one branch. When is the next time that we'll be at a point in our development cycle with only one branch under active development and all other branches are stable/closed? More than a few days, less than a few weeks?

Maybe just before 1.1 is cut? Maybe.

The majority of the changes are just transforming each space to two spaces, where the usual 2-space indent becomes a 4-space indent.  The code is hard enough to go through with some the files being quite long, so maybe keeping it as a 2-space indent for now would be better for troubleshooting purposes.  Yes, the PEP8 style helps but things are changing every day that it might be nice to have it formatted after things stabilize for some time.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

outmoded


Support 'throw' expressions

Support proposal-throw-expressions.
That proposal is now stage-1, but worth to implements for convenience and this proposal not break backward-compatibilities.
Current
ts
const errorThrowExp = () => { throw new Error('Error!'); }
function errorThrowFn(maybeTrue) {
  if (maybeTrue){
    return ...;
  } else {
    throw new Error('Error!');
  }
}

js
const errorThrowExp = function() {throw new Error('Error!')}
function errorThrowFn(maybeTrue) {
  if (maybeTrue){
    return ...;
  } else {
    throw new Error('Error!');
  }
}

Proposal
ts
const errorThrower = () => throw new Error('Error!');
function errorThrowFn(maybeTrue: boolean) {
  return maybeTrue? ...: throw new Error('Error!');
}

js
const errorThrower = function() { throw new Error('Error!'); }
function errorThrowFn(maybeTrue: boolean) {
  return maybeTrue? ...: (function() { throw new Error('Error!') })();
}

Just to note, @rbuckton is closely aligned to the TypeScript team.  I highly suspect this proposal would be implemented when everyone is comfortable it is in a stable enough position.

@kitsonk That make sense.
So is this proposal premature?

So is this proposal premature?

Nope, it's fine to track it here. Like @kitsonk said, @rbuckton is championing it and is part of our team, but we will need it to reach a later stage before adopting it in TypeScript.
For what it's worth, I'd be willing to bet he has a branch with an implementation of throw-expressions. 😄

https://github.com/Microsoft/TypeScript/tree/throwOperator?files=1
Currently it does not yet support unreachability checks at the expression level. Also, I am waiting for the next TC39 meeting to see if the proposal moves to Stage 2.

@DanielRosenwasser @rbuckton
I got it.
Thank you for the detailed explanation!

TypeScript's current stance is that we will not adopt a proposed JavaScript feature until it has reached Stage 3. Currently, Stage 3 for throw expressions is blocked from advancement due to overlap with the do expressions proposal.

Ah, I see. Thanks, @rbuckton!

This is now in stage 3 :)

No, this has not yet advanced to Stage 3.

Closing since there's nothing for us to do but wait for TC39


Create a my-article feature

[ ] Create a new folder under \Smarticle\projboard\templates, there will be located the html parts of this feature
[ ]  Create the html file and css
[ ] Add to the \Smarticle\projboard\views.py file a function to render this html part
[ ] Add to the Smarticle\finalProject_g4\urls.py file a new path to create a new route
[ ] Add a test file that test the changes you add

Please change the title to my-articles


Api mediation doc

fix link in the TIP in api-mediation-onboard-an-existing-rest-api-service-without-code-changes.md
merged api onboarding into the master branch
added Onboarding article to Dev Tutorials > Onboard REST APIs to the API Mediation Layer.

missing space after the comma?

incorrect file listed in the config.js file

removed spaces

re-try


Allow iPad device rotation

Would be nice in general, but particularly nice for AR, because it makes way more sense to do landscape on a phone for AR.

The ideal would be to make it so that the camera view doesn't have to rotate (because it naturally rotates when you physically rotate the device) and just rotate the interface on top, but that might be too complicated (I did it for another project a while back and it was the pits), so it's probably worth just ignoring for now. Might need some tweaks to the logics in RootVC for setting the orientation of that view, and also will need some tweaks to how the none popups are displayed so that they work in portrait mode (they'll be a bit squished, but should be fine).
Only supporting iPad because making the node popups works in landscape iPhone is probably too hard (node popups would need basically all the screen space. But once it's working on iPad we could try it out on the phone and see if it can be made to look at all reasonable.


Yandex map source

Coverage remained the same at 100.0% when pulling 337ec291e8b65cc1d62a109a752161324efc6a32 on yandex-map-source into fb37c8873e4ad6c08c3cc7e8da7987e095f1bb3b on master.


Unable to call static method within the same class Model

python version: 2.7
django version: 1.10.6
django-rq version: 0.9.6.
Im unable to call a function inside a class.
sample code
class SampleClass(models.Model):
    @staticmethod
     def my_function(data):
         return things

     @property
     def push_function_to_worker(self):
          queue = django_rq.get_queue('high')
          data = {'data': 'things'}
          queue.enqueue(SampleClass.my_function, data)

our work around is defining the function outside the class, which is kinda dirty but it works. Is there any cleaner way to do this. Thank you 👍
def my_function(data):
    return things

class SampleClass(models.Model):
     @property
     def push_function_to_worker(self):
          queue = django_rq.get_queue('high')
          data = {'data': 'things'}
          queue.enqueue(my_function, data)

Did you manage to find a workaround/cleaner way to do this without having to move the function out of the class?

I think I've got the same issue. But considering that I'm not using django-rq I think it might be an error related to rq in general :(


Download Binary from Latest Yomitan Import Release

Would be better so that the binary in this repository does not have to be manually updated.

Yomitan import is probably not going to be further developed as focus is switched to Jitendex

Actually resolved: #9


ENH: update package version

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #4.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #4

The 3.4.26 tag was picked up by the "normal" bot, closing


Updating Azure Media Player

Initial commit. Needs to remove previous scripts if not necessary anymore but I need confirmation.

[ ] Add non-minified version of scripts
[ ] Remove injector pipeline

Please fix the merge issues.

@sebastienros you are the one that needs to fix merge issues :) haha

It seems the module is outdated. I opened an issue to discuss that #7671

Closing it in favor of https://github.com/OrchardCMS/Orchard/pull/7618


Revert "add user profile, value proposition, user stories"

Reverts AY2223S1-CS2103T-F12-2/tp#15

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (fe9015c) compared to base (c7aa4f6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.