API for invalidating cache on changed files? (Sharing Builder instance)

I am using JSPM builder inside Gulp like that:
const jspmBuilder = new jspm.Builder("src", "jspm.config.js")

gulp.task("js:main", function() {
  jspmBuilder.bundle("app/main", "main.bundle.js", jspm_options)
})

gulp.task("watch", [ "build" ], function()
{
  gulp.watch([
    "src/**/*.js"
  ], [ "js:main" ])
})

Interestingly there seems to be some file caching in place somewhere inside the builder.
What I experience is the following:

First build works fine
Following builds based on the gulp watcher are being rebuilded, but using the old file content.

Moving the initialization of the jspm.Builder inside the js:main task fixes this issue.
I care about good life circle and performance during development of larger applications so I figured that sharing the same builder instance for each build is a good pattern. Interestingly this does not seem to work.
Is there any workaround for can use to tell the Builder to invalidate changed files? Or can we make it smarter regarding its built-in caching?

I am using<EMAIL_ADDRESS>And I am accessing the Builder contructor via the jspm import:
import jspm from "jspm"

You can run builder.reset() between builds. This won't clear the cache, but will just mark the cache as needing revalidation from file statting. Yes this needs to be documented!

builder.invalidate(fileName) can also be used to invalidated individual files, supporting wildcards as well.

Thanks for sharing the "invalidate" call. That's super awesome and works very good:
https://github.com/sebastian-software/modern-spa-boilerplate/commit/2e7d4742518d4c60fb221326f48d9ae8d74c0fba
I see pretty quick rebuild times:
[15:37:13] Changed: src/components/Test.js
[15:37:13] Starting 'js:main'...
[15:37:13] Finished 'js:main' after 164 μs

That's much better than the initial runtime:
[14:59:54] Starting 'js:main'...
[14:59:54] Finished 'js:main' after 1.28 ms

which is super useful for live rebuilding/reloading.
I think I prefer that approach over transpiling in the browser.

Maybe we should close this task and open another one for documenting this useful API.

Sure, I've made a note in the issue at https://github.com/systemjs/builder/issues/250#issuecomment-152299085.


Add continuous testing on Windows using GitHub Actions

This is a pipeline using a Linux job that cross-compiles for Windows, followed by an actual Windows job linking and running that.
Based on https://github.com/crystal-lang/crystal/wiki/Porting-to-Windows/30956f45a4e739204881694ee6c92f4fb0bc5395
Note that all the actual commits from this PR are prefixed with "Win CI:", the rest is merges of pull requests that this relies on.
This PR creates and touches only the file ".github/workflows/win.yml".
Example in action
Fixes #8666.

This is really amazing! I almost didn't expect to get CI working on windows so quickly.
A few remarks:

In order to provide the same behaviour as the existing CI workflows, it would be nice if we could build stdlib specs with both latest and master compiler. I.e. before and after the build crystal step.
The versions for libgc and libatomic_ops in the guide are outdated. I didn't test it yet, but I suppose the latest releases should work as well. That's v8.0.4 and v7.6.10 as used for the linux compiler build.
I haven't looked deeply into GitHub actions but I figure we could extract building the library into a re-usable action step? I think that would help to separate concerns and keep the CI config more clear. Alternatively, a separate PowerShell script would also work and even provide the benefit that it would be easily applicable for local installs.

Sure, that can be done as a follow-up if deemed necessary. To me it seems like it's just extra runtime for no benefit currently. It's being checked on other systems, and the Windows build doesn't satisfy even weaker guarantees than this one.
Yes, but note that these versions are newer than what's used in Crystal's official Docker image (Older Ubuntu). Still, I tried updating, but it did not "just work": building bdwgc on Windows has been reworked.

Seems like that ability is a huge jump in difficulty, i.e. requires writing JavaScript code.
The separate script already exists and is linked from the wiki, but I found that GitHub Actions config was much more concise and expressive. Generally, grouping actions to a script makes the UI of builds less granular, though it's not so important here.

building bdwgc on Windows has been reworked

It's actually been fixed: ntwin32.mak is no longer required. I'd prefer to move to the cmake build for bdwgc if possible.

It's possible to merge this and then update that.

Actually I'm convinced by your argument that it's much simpler now.
Willing to try, but for now getting linking errors, maybe you can advise.
https://github.com/oprypin/crystal/runs/385894088#step:8:2

@oprypin ah, it's fixed on latest bdwgc but not the release: https://github.com/ivmai/bdwgc/blob/7dcf6be3a74335349aab5bd38fc96594761e5780/CMakeLists.txt#L299

No, didn't work either.
https://github.com/oprypin/crystal/runs/387467545
I am not pursuing this further.
Other than the remaining tiny dependency PR, this is ready.

Well, it can be merged even without #8674, it'll just fail 1 spec initially :>
So fully ready, actually.

@oprypin oh! forgot cflags=-DDONT_USE_USER32_DLL in the nmake as well. Sorry, but I'm sure that that will fix it.

Nope :upside_down_face: https://github.com/oprypin/crystal/runs/387628797#step:9:40

ffs


ELM-based ordinance retrieval and extraction

Add code to support ELM paper.
Notes

Tests break main ELM and ELM-ordinances up into separate pieces. This ensures base ELM can still be installed with no hassle.
Bumped Python version to 3.9 (max at 3.11)
Bumped ELM version to 0.0.4

Two additional comments and i'm not sure where they go:

While running ords, we get an error: AttributeError: None of the edge conditions from "init" were satisfied: [{'condition': <function llm_response_starts_with_yes at 0x12369cc10>}]

Maybe should say “This is not necessarily an error and may mean that the text does not have the requested data”

Could we download the pdf’s to a subdir similar to how the logs are stored?

Yup! Added both.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


MINOR: Document that Connect topics should use compaction

Update documentation for Kafka Connect distributed’s config.storage.topic, offset.storage.topic, and status.storage.topic configuration values to indicate that all three should refer to compacted topics.

Reference for config.storage.topic: https://github.com/apache/kafka/blob/bd8681cdd51d2878ea917941abe335f68a373716/connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java#L84
Reference for status.storage.topic: https://github.com/apache/kafka/blob/bd8681cdd51d2878ea917941abe335f68a373716/connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java#L57
I'm a little less confident about offset.storage.topic, but it does seem clear to me that offsets should have a persistent state and Kafka is the only state used for the distributed worker.
This contribution is my original work and I license the work to the project under the project's open source license.

Thanks for the patch! Committed to trunk.


feat: allow cors origin api header

Some private repositories, didnt allow cors

Hello, thank you for contributing.
Can you please tell me what kind of situation with what kind of private repo does this solve? I tested your change with Github package repo and I still get a CORS error. I am not sure that issue can actually be fixed without Github returning proper headers in their responses.

Closed for inactivity


The program can't start because libgccsdw2-1.dll is missing from your computer

I have successfully managed to produce a keyword file in windows 7 (x64) using the following command in the cmd:
C:\Users\User\Documents\Porcupine-master\Porcupine-master\tools\optimizer\windows\amd64/pv_porcupine_optimizer -r resources/ -p windows -o C:\Users\User\Documents\Porcupine-master\Porcupine-master -w "jarvis"
I have then tried to test it by running the following command:
C:\Users\User\Documents\Porcupine-master\Porcupine-master\demo\python\porcupine_demo_non_blocking.py --keyword_file_paths C:\Users\User\Documents\Porcupine-master\Porcupine-master\jarvis_windows.ppn
Which has given the error:
The program can't start because libgccsdw2-1.dll is missing from your computer. Try reinstalling the program to fix this problem.
Does anyone have any tips on how to fix this issue?
And also (not-essential), does anyone have any pointers on how to start integrating this into a python script
Many thanks in advance
Oliver Harris

You need to install http://www.mingw.org/

You need to install http://www.mingw.org/

It seems I may have spoken too soon. It worked on my windows 10 laptop but did not work on my windows 7 pc (the intended use). Any other suggestions?

please use the template for opening an issue. You need to provide enough details so I can point you in the right direction.


Cleanup in reverse order from startup (PROJQUAY-4629)

Stop services in reverse order, then remove quay root and systemd unit files and reload systemd

@dmc5179 Looks like the name change from quay-app to quay-postgress breaks uninstall. Can you update the PR to address this?
fatal<EMAIL_ADDRESS>FAILED! => ***"attempts": 20, "changed": true, "cmd": ["podman", "exec", "-it", "quay-postgres", "/bin/bash", "-c", "echo 'CREATE EXTENSION IF NOT EXISTS pg_trgm' | psql -d quay -U postgres"], "delta": "0:00:00.058352", "end": "2022-10-17 17:05:21.292428", "msg": "non-zero return code", "rc": 125, "start": "2022-10-17 17:05:21.234076", "stderr": "Error: no container with name or ID \"quay-postgres\" found: no such container", "stderr_lines": ["Error: no container with name or ID \"quay-postgres\" found: no such container"], "stdout": "", "stdout_lines": []***

Found the issue, it's related to the pause image we're using. I've made the update here. Once this is merged, can you rebase and we'll get this in? https://github.com/quay/mirror-registry/pull/94


datasheet: add texplained chip scans

I guess the best place will be after the renders.
Should be intro'd with some text like:
Thanks to Texplained for chip decap and scans.
Then each image described:
Image shows top metal 5. This layer is mostly used for power distribution.
Image shows substrate. This is done after all material is removed from the substrate.

To add them after the renders, simply edit docs/chip_map.md in the respective shuttle repo, e.g. https://github.com/TinyTapeout/tinytapeout-06/blob/main/docs/chip_map.md.
The images themselves can be added to docs/images/ in the respective shuttle's repo.


[WIP] GCP Providers

This PR is to update the API with the new storage and queue providers.

Pull Request Test Coverage Report for Build 315

0 of 0   changed or added relevant lines in 0 files are covered.
34 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-6.3%) to 93.669%

Files with Coverage Reduction
New Missed Lines
%

cmd/lighthouse-server/main.go
17
88.59%

cmd/phpcs-server/main.go
17
89.82%

Totals

Change from base Build 312:
-6.3%

Covered Lines:
503

Relevant Lines:
537

💛  - Coveralls

I bet the next commit is 100%. It feels like on every other build the coverage goes down then back up.

@rheinardkorf 🤣 my suspicions were correct. Back to 100% coverage!


Fix ALPN TLS connection issue with AWS IoT Core for MQTT and HTTP demos

There was incorrect configuration of the ALPN protocol string in  MQTT and HTTP demos that caused problems in using TLS ALPN extension when connecting to AWS IoT Core. This PR fixes the protocol strings to allow the mutually authenticated demos to TLS connect to AWS IoT Core on port 443 with ALPN extension.

This was addressed by PR #831


Build a mood tracking bot

I would like to propose the development of a Mood Tracking Bot that allows users to track and manage their moods and emotions effectively.
Key Features:

Mood Logging: Users can easily log their daily moods, indicating their emotional state on a scale or using predefined categories.

Data Visualization: The bot should provide clear visual representations of mood patterns over time, such as graphs or charts, allowing users to identify trends and fluctuations.

Please assign this to me.

@neelshah2409 Please assign this to me for gssoc'23

@neelshah2409 Hello please assign this to me for gssoc'23

@neelshah2409  Hello can you please assign me this issue for gssoc'23.

@neelshah2409 Hello can you please assign this issue for gssoc'23 to me?


Feature: OnlyKey auto-settime config option

Issue description
Annoying is having to manually onlykey-cli settime my key to get TOTP initialized. As the main docs point to this ruleset, the following could be uncommented to allow the ability to automatically set the time when the device is plugged in.
SUBSYSTEMS=="usb", ATTRS{idVendor}=="1d50", ATTRS{idProduct}=="60fc", MODE:="0660", GROUP:="onlykey", RUN+="$NIX_STORE/bin/onlykey-cli settime"
KERNEL=="ttyACM*", ATTRS{idVendor}=="1d50", ATTRS{idProduct}=="60fc", MODE:="0660", GROUP:="onlykey", RUN+="$NIX_STORE/bin/onlykey-cli settime"

What I would expect is something similar to
# configuration.nix
{
  # ...
  hardware.onlykey = {
    enable = true;
    autoSettime = true;
  };
}

and with this flag set, onlykey-cli will be added to the systemPackages and the above UDEV rules would then be added to /etc/udev/rules.d/99-local.rules just as the current config does in the hardware file.
# hardware/onlykey/default.nix
{
  # ...
  config = mkIf config.hardware.onlykey.enable {
    services.udev.extraRules = builtins.readFile ./onlykey.udev;
  };
  # new flag check here!
}

I wish I was more familiar with this side of GNU/Linux + Nix. Perhaps @kalbasit might see this as something trivial to add and helpful?

bump


how to use  choices for the field.widgets

when import xls file, the choices field is None,but xls exist data and the import preview page in the Admin UI exist data.

hi I can't understand what the issue is here.  Can you repost with as much information as possible (how to reproduce, screenshots if necessary).

thanks,
in models.py:
education = models.CharField(_("文化程度"), max_length=20, choices=Education.choices)
class Education(TextChoices):
A = '1', '小学'
B = '2', '初级中学'
C = '3', '普通高中'
D = '4', '技工学校'
E = '5', '大学专科'
F = '6', '大学本科'
G = '7', '硕士研究生'
H = '8', '博士'
I = '99', '不限'
in resources.py:
education = Field(column_name='文化程度', attribute='get_education_display')
Export is working.
when Import this field. the value in database is None;
1、A screenshot of the excel  file:

2、A screenshot of the confirm import view.:

3、A screenshot in database:

Sorry - I cannot understand the issue - can you reproduce in the example application?


fix bug in #695

What bug? Where's the test(s)?

Tests are in ServiceHubContextE2EFacts. the properties in HubOptions are null for ServiceManager.


Adds support for redirected URLs

This pull request adds support for redirected URLs. It enables the maximum redirect retries to be set and adds specs to test the new features.
The default retry attempts is 10. To change, use FFMPEG.max_http_redirect_attempts.

I'm not 100% convinced that streamio-ffmpeg should be in the business of checking URLs, vs. just passing them on to the binary.  It seems like a recipe for whack-a-mole!
Some possible gotcha cases:

does ffmpeg allow ftp:// urls? (this check may stumble on those, I'm not sure)
does ffmpeg accept untrusted/self-signed SSL certificates? (this check may raise errors on untrusted certificates, unless we set http.verify_mode = OpenSSL::SSL::VERIFY_NONE)

Thanks for jumping on this so quick! 👍

Thanks for the quick review. I was thinking the same thing as you but went ahead with the work to see where it went because I didn't feel that simply ignoring the url was any better.

Branch updated.


Remove CAPA command from deployment

What this PR does / why we need it:
The ENTRYPOINT in the CAPA image should dictate the command used. This allows us to use either images built via OCP release process or via ACM pipeline.
Checklist

[x] Subject and description added to both, commit and PR.

/lgtm

Ref 4.12 https://github.com/openshift/hypershift/pull/1970
/lgtm


cargo build -p app1 -p app2 produces different results than cargo build -p app1 && cargo build -p app2

Problem
When calling cargo build in a workspace to build multiple packages at the same time (e.g. cargo build --workspace or cargo build -p app1 -p app2), the results differ from building each package using a separate cargo invocation. This manifests in the fact that after cargo build -p app1 -p app2 has finished successfully, cargo build -p app2 still triggers a new build of the app2 binary.
I can trigger this behaviour by having two executable targets share the same crate as a dependency, but with different features, e.g.:

Cargo.toml:[workspace]
members = ["app1", "app2"]

app1/Cargo.toml:[dependencies]
proc-macro2 = { version = "1.0.46", features = ["span-locations"] }

app2/Cargo.toml:[dependencies]
proc-macro2 = "1.0.46"

See also: A full example workspace.
Steps

In the example workspace
Run cargo build -p app1 -p app2. It terminates successfully:simon@machina ~/repos/cargo-workspace-build-mwe (git)-[main] % cargo build -p app1 -p app2
   Compiling proc-macro2 v1.0.46
   Compiling unicode-ident v1.0.4
   Compiling app2 v0.1.0 (/Users/simon/repos/cargo-workspace-build-mwe/app2)
   Compiling app1 v0.1.0 (/Users/simon/repos/cargo-workspace-build-mwe/app1)
    Finished dev [unoptimized + debuginfo] target(s) in 2.83s

Also, two executable files app1 and app2 can now be found in ./target/debug.
Build app1 by itself:simon@machina ~/repos/cargo-workspace-build-mwe (git)-[main] % cargo build -p app1
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s

As expected, nothing needs to be done here 👍🏻
Build app2 by itself:simon@machina ~/repos/cargo-workspace-build-mwe (git)-[main] % cargo build -p app2
   Compiling proc-macro2 v1.0.46
   Compiling app2 v0.1.0 (/Users/simon/repos/cargo-workspace-build-mwe/app2)
    Finished dev [unoptimized + debuginfo] target(s) in 2.11s

Contrary to what I was expecting, app2 is getting rebuilt even though none of its sources have changed.
If I interpret the contents of ./target/debug/build correctly, a second version of proc-macro2, now without span-locations feature is being built and linked into this new build of app2.

Possible Solution(s)
From a mere user perspective, I would expect cargo build -p app1 -p app2 to produce the exact same results as cargo build -p app1 && cargo build -p app2. So if cargo builds multiple executables at the same time, it should not unify features between shared dependency crates but instead, if different binaries can do with multiple feature sets in a dependent crate, build multiple versions of the dependent crate during the cargo build call.
Notes
see: related discussion on users.rust-lang.org
Version
cargo 1.66.0-nightly (3cdf1ab25 2022-10-07)
release: 1.66.0-nightly
commit-hash: 3cdf1ab25dc4fe56f890e8c7330d53a23ad905d3
commit-date: 2022-10-07
host: x86_64-apple-darwin
libgit2: 1.5.0 (sys:0.15.0 vendored)
libcurl: 7.79.1 (sys:0.4.55+curl-7.83.1 system ssl:(SecureTransport) LibreSSL/3.3.6)
os: Mac OS 12.6.0 [64-bit]

A common workaround is to have a "workspace hack" which enables all of the features for you.  For example, see https://crates.io/crates/cargo-hakari.

This looks to be a duplicate of #4463.  If that is a mistake, let us know and we can re-open,.

Hi @epage,

This looks to be a duplicate of https://github.com/rust-lang/cargo/issues/4463.

Yes - that's exactly the issue! Thanks for pointing me to it 😊

A common workaround is to have a "workspace hack" which enables all of the features for you. For example, see https://crates.io/crates/cargo-hakari.

For my use case, I prefer crate-specific feature selection (to be speaking in terms of #4463). So I will likely build a fairly simple xtask that issues a single cargo build target for each call :-)


feature(core): redesign browse auctions

What kind of PR is this?:

/kind feature
What this PR does / why we need it:

Redesign auction cards
Add filtering - From your vault
Add filtering - With placed bids
Add sorting logic in the ff order:
- Placed bid lost (if multiple time remaining)
- Placed bid winning
- From your vault
- Time remaining

Which issue(s) does this PR fixes?:

Fixes #1879
Additional comments?:
Developer Checklist:

[x] Read your code changes at least once
[x] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
[x] No console errors on web
[x] Tested on Light mode and Dark mode*
[x] Your UI implementation visually matched the rendered design*
[x] Unit tests*
[x] Added e2e tests*
[ ] Added translations*

The design has changed for auctions v2


"Inter-link" terms before going live w/ V1

Once we consolidate the terms into one doc, we'll need to link terms that are mentioned in a definition and have their own definition. That way, readers can jump right to that term if they aren't familiar with it.

@CathPag Is now the time to go through and link as many definitions as possible for the completed terms?

Unfortunately, the first version will be a PDF, @IdealUsrname. But we can still do this.


Add sensor for International Space Station

Description:
Add sensor for International Space Station

one sensor to let you know if ISS is above your home location
one sensor that tell you how much time you have to wait until the next rise in minutes

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#1620
Example entry for configuration.yaml (if applicable):
sensor:
  platform: iss

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

Can you please resolve the conflict with .coveragerc?

I'm not able to do it on Github. When I click on "Resolve conflits" buttonn the page still loading without ending... Is there any other way ?

CONF_ISS_VISIBLE = 'visible'
CONF_ISS_NEXT_RISE = 'next_rise'
CONF_ISS_NUMBER_PEOPLE_SPACE = 'number_of_people_in_space'
CONF_TIME_SECOND = 'mn'

Nice sensor!
Isn't it best practice to call these like so, those aren't config file entries.
ATTR_ISS_VISIBLE = 'visible'
ATTR_ISS_NEXT_RISE = 'next_rise'
ATTR_ISS_NUMBER_PEOPLE_SPACE = 'number_of_people_in_space'
ATTR_TIME_SECOND = 'mn'


Problem running moltemplate.sh

Hi! I hope you are doing well!
I'm trying to run moltemplate.sh but I always get the following message:
########################################################
WARNING: atom_style unspecified
--> "Data Atoms" column data has an unknown format
Assuming atom_style = "full"
########################################################
And this happens if I try to run moltemplate.sh both for some example of the code and for some system I created. At the end of execution the following message is displayed:
lttree_postprocess.py v0.6.2 2021-4-20
Error(lttree_postprocess.py): Unable to open file
"Data Atoms.template"
for reading.  (Do your files lack a "Data Atoms" section?)
(To override this error, run moltemplate using the "-nocheck" argument.)
Thank you!

The first warning is to inform the user that the atom_style full structure is assumed in your Data Atoms section. To get rid of this warning, set the style explicitly with: moltemplate.sh -atomstyle full yourscript.lt.
For the second error, it is impossible to say what is wrong without you sharing your input files.

Hi @hothello. I hope you are doing well.
Thank you so much for reply.
The first warning was caused by "atomstyle" parameter.
Thus the second, the error was in the input file, in the coordinates of the atoms. In moltemplate, the atoms name will be diferent. This error was happening because, for example, all carbon atoms was "C" and the correct is "C1, C2, etc".


Enable Travis CI tests

The Travis CI tests don't seem to be enabled.

Ahh never mind. They started running after I made a PR. The 'unknown' status should go away

@amilajack Exactly. It didn't run on my initial commit.


Mangahub not loading images

Source information
Mangahub 1.4.39
Source language
English
Steps to reproduce
The extension becomes unusable after extended use and starts displaying "API limit exceeded visit mangahub.io to continue reading"
Expected behavior
Images should load
Actual behavior
Images not showing due to API limit
Mihon/Tachiyomi version
Tachiyomi j2k 1.7.4
Android version
Android 9
Other details

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Add a :+1: reaction to issues you find important.

Duplicate of #6573


xAPI Logo update

🗺  Requirements
Where will this work live in the application? What precisely is going to be built/changed?
We updated the xAPI image however, due to the size of the image and the design, the letters run to the edge of the frame and don't look right.

😍 Expected Behavior
The image looks sized properly for the frame that it's in.
✔  Acceptance Criteria
What are the essential components to mark this work as done?

[ ] Use new image with padding added for logo.

Image:

Reviewer: @kentzmann


unmonitorEvents() not working

I wrote monitorEvents(myController);
and it monitors everything as expected, but also on every other page thereafter (not expected)
So I thought, logically, let me remove it
unmonitorEvents(myController);
nothing changes... I get events being monitored on everything still
I've tried 'window', 'document', 'body', 'html', '$0'-'$4', and every type I can think of, as soon as I open the page, the eventmonitoring starts... how do I turn it off???

I'm an idiot...


Remove test_get_dummy_device_for_empty_array

An empty array will has actual device id in cupy/cupy#946 .

How about adding TODO to check assert cuda.get_device_from_array(x) == cuda.Device(0)?

I added.

Jenkins, test this please

Please make it a TODO, instead of actually checking.

jenkins, test this please.

Jenkins CI test (for commit 53d40757ae321f794150d405c4f26b6bb31cbac9) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

How about adding TODO to check assert cuda.get_device_from_array(x) == cuda.Device(0)?

How about this?
We should fix as such as soon as cupy/cupy#946 will be merged.

OK.

No, I mean to write TODO as a comment.

oh,ok. I will

LGTM. Thanks.

Jenkins, test this please

Jenkins CI test (for commit 5201c8f7935c7317777333145a9942632b8830c2) succeeded without errors!

Jenkins CI test (for commit 5201c8f7935c7317777333145a9942632b8830c2) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@niboshi Is this PR needs to be labeled as no-compat?

@kmaehashi
I think so. This PR reflects the change of exposed behavior.
I'm not sure if it has been documented, but it affects existing user code.

I discussed with @niboshi. As https://github.com/cupy/cupy/pull/946 is not merged yet, this PR itself does not break anything. I raised another issue #5113 for documenting this behavior change (its corresponding PR should be marked as no-compat)


System.ArgumentException : Cannot bind to the target method because its signature or security transparency is not compatible with that of the delegate type.

I got this exception when subscribing to an observable : Cannot bind to the target method because its signature or security transparency is not compatible with that of the delegate type.
Here is the sample code :
var dataGridCopy = Observable.Merge(dataGridKeyDown, dataGridKeyUp)
    .Buffer(2, 1)
    .Where(x => !x[0].EventArgs.KeyStatus.IsKeyReleased && !x[1].EventArgs.KeyStatus.IsKeyReleased)
    .Where(x => x[0].EventArgs.VirtualKey == VirtualKey.Control && x[1].EventArgs.VirtualKey == VirtualKey.C);

dataGridCopy.Subscribe(_ =>
    {
        // TODO
    });

I am working on a UWP application under Windows 10 Fall Creators Update with the package System.Reactive 3.1.1.

@Odonno are you able to provide a more complete example? It's not clear where dataGridKeyDown and dataGridKeyUp are coming from, and this is a common error on StackOverflow around creating certain kinds of delegates

Of course. Hope it helps.
ReproBug447.zip

What was the solution for this?  I'm having this issue as well.

@chrisevans9629 Well, rxjs with electron was the final solution. :)
But seriously, still don't know why..

For me, this happened when using Observable.FromEvent<>(); in Rx.NET
However, it worked fine after I switched to Observable.FromEventPattern<>():
Don't know why, but it did the trick!


RESIDENT EVIL 6 in-engine cutscenes stutter a lot

In-engine cutscenes in RESIDENT EVIL 6 stutter a lot, replaying cutscenes doesn't fix the issue (i thought it was shader compilation stuff but it really does not seems like it)
what it looks like:
https://www.youtube.com/watch?v=cm4og_gee4g
Software information
RESIDENT EVIL 6 (Steam)
System information

GPU: RX 560 4 GB
Driver: MESA 21.3.7 RADV (Vulkan-radeon/lib32-vulkan-radeon arch package)
Wine version: Proton Experimental
DXVK version: 1.10/1.10.1

Apitrace file(s)
https://drive.google.com/file/d/199v5IcQUmRIpojeHsgiKoOeAG6vouuf-/view?usp=sharing

How do the stats look during the cutscenes if you run it with DXVK_HUD=full %command%

I played the first half hour of the game yesterday and the game seems to compile on average 20-30 graphics pipelines per camera cut. So I strongly suspect this is just shader compilation stutter.


Typo in example

Hello authors, thank you for your work putting this together!
I am working through the example, and I believe there is a typo here.
Lines 143 and 144 are currently
train_texts = train_texts[-dev_size:]
train_labels = train_labels[-dev_size:]

But they should be:
train_texts = train_texts[dev_size:]
train_labels = train_labels[dev_size:]

Also, line 58 is
(train_texts, train_cats), (eval_texts, eval_cats) = load_data()

and it probably should be:
(train_texts, train_cats), (eval_texts, eval_cats) = load_data(limit=n_texts)

Best,
Luke

Thanks, fixed!

Great!


Add Gradio interface for AlphaFold protein structure predictions

This version of the app tries to follow the capabilities of the AlphaFold Server interface, and implements a basic interface to gather various molecules that a user provides. I have not looked at the model inputs too carefully, so it is very possible that the fold function will not work well with a checkpoint at the moment. Furthermore, I was not sure how to obtain the predicted aligned error (PAE) plot, nor the plDDT, pTM, or ipTM values, so I left these for a future commit.
Regarding the input for the model, I am currently taking as input proteins, nucleic acids, ligands and metal ions. I have followed the AlphaFold inputs, and checked with the values found in life.py, but it might be possible I have missed something. Please let me know if something catches your eye!
I have also written some code in the comments to allow moving the model to a GPU, and quantize it to a desired precision. If that needs any other parametrization, please let me know and I will implement it.
Finally, the app contains some bugs. After clicking the predict button, everything else is no longer responsive. I tried to fix this by converting the fold function to be async (i.e., await model output and writing to file), but it did not work. This possibly was not needed, since gradio already incorporates some parallelization under the hood, if I am not mistaken. I will try to fix this issue in a future commit, but I was hoping to hear some opinions first regarding the current functionality 😄

lgtm! 🚀 🧬


[Algoa Bay Forecast] Improve and harden model job pipeline

Allow configurable start date
Triggering the Algoa Bay Forecast model run manually, you can specify a run date. this run date is captured by the Actions runner and made available to steps via ${{ needs.envs.outputs.MODEL_RUN_DATE }}. But this value needs to be passed to all scripts that use a run date, which may require updating MatLab/Python code

[ ] When the model is compiled, is the current date used at all?
[ ] Downloading boundary data (forcing inputs). The run date should be passed via a flag to the python script --rundate 20220701 for example
[ ] The make-forcings (MatLab) step
[ ] The run_croco.bash script probably needs to be updated too
[ ] Post processing (the output files are named for the run time date i think)

Retry download boundary data step on curl and motuclient errors
The job is configured to retry on failure, however errors in the download don't result in failing the job since these errors are swallowed by the Python script where curl and motuclient are called.

[ ] Python script for downloading data needs to throw errors correctly

Here is the error that Python is swallowing

The motuclient fails without restarting still


Fix text input label does not deactivate if the input is cleared programmatically

Details

Clearing the input programmatically won't deactivate the text input label.
Fixed Issues

$ https://github.com/Expensify/App/issues/21061
PROPOSAL: https://github.com/Expensify/App/issues/21061#issuecomment-1598258415
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Go to Settings > Workspaces > Choose any workspace > Members
In the "Find a member" input, type anything
Verify the "Find a member" label moves up
Press the Invite button
Go back
Verify the input is cleared and "Find a member" label moves back to its original position

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/50919443/2f826d72-7229-4610-8191-06df552742a0

Mobile Web - Chrome

https://github.com/Expensify/App/assets/50919443/5b67b447-5121-4fd0-bc31-7b31101d24cc

Mobile Web - Safari

https://github.com/Expensify/App/assets/50919443/64715e1c-e513-4dac-b98e-84b2afa10f63

Desktop

https://github.com/Expensify/App/assets/50919443/ac4ef5cb-7077-473f-82c2-06df80f8156c

iOS

https://github.com/Expensify/App/assets/50919443/f237d220-5c1d-497c-8277-59309e97a7e0

Android

https://github.com/Expensify/App/assets/50919443/11212899-66e1-49cb-8cc8-5c7aba375160

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.35-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Public Comment: Occupancy Popup missing 9am time period.

Add 9am Time Period to all popup windows for Occupancy.

Addressed by Kearey Smith


metrics dont appear accurate

The metrics numbers I get from port 4195 are not accurate with the word counts of the output file!  What do I need to modify or change to get them accurate?
I'm testing Benthos in Docker.  When I launch Benthos in a docker container I want to be able to pole metrics by running 'curl -s <IP_ADDRESS>:4195/metrics'.  When I look at the output of the json, the numbers don't agree with the word counts of the file I'm writing to.
[root@pdehost-wc-3p benthos-3.8.0]# wc outputfile; curl -s <IP_ADDRESS>:4195/metrics
102008   1780049 112846651 outputfile
{"benthos":{"goroutines":10,"input":{"batch":{"received":2142374},"connection":{"failed":0,"lost":0,"up":1},"count":2142374,"latency":516470,"latency_readable":"516.47µs","received":2142374},"output":{"batch":{"bytes":110738318,"latency":456066,"latency_readable":"456.066µs","sent":2142374},"count":2142374,"sent":2142374},"uptime":"1m51.428606739s"}}[root@pdehost-wc-3p benthos-3.8.0]#
The current config is:
input:
file:
path: "/input/infile"
multipart: false
max_buffer: 1e+06
delimiter: ","
metrics:
whitelist:
paths:
- input.received
- input.count
- input.batch.received
- input.connection.up
- input.connection.failed
- input.connection.lost
- input.latency
- buffer.backlog
- buffer.write.count
- buffer.write.error
- buffer.read.count
- buffer.read.error
- buffer.latency
- pipeline.processor.0.count
- pipeline.processor.0.sent
- pipeline.processor.0.batch.sent
- pipeline.processor.0.error
- output.count
- output.sent
- output.batch.sent
- output.batch.bytes
- output.batch.latency
- output.connection.up
- output.connection.failed
- output.connection.lost
child:
http_server:
namespace: benthos
Config fields, showing default values
output:
file:
path: "/output/outfile"
delimiter: ","

Hey @GrantEdmunds, are you sure that Benthos has finished processing the file when you query the metrics? With that config I would expect Benthos to shut down once the input file is fully consumed, in which case it wouldn't be possible to use curl to get the final counts.
If you try out the stdout it'll print a definitive value when the service shuts down, that might help narrow this down.

I realize with files, Benthos stops as soon as it reads the end of the input file.  But we want to test with Kafka as an input stream also.  So we’d like to know how many output records it has written to the output file, so we can shut it down after a certain amount.   The whole purpose is to test Logstash, with Benthos and Vector and any other log shippers to see which is faster and most efficient with the same inputs, cpus, memory, etc…!
Here’s what my python script does.

Take input parameters and initialize
Start dstat in the background
Launch benthos in docker container in background
Loop and read port 4195/stats (find the metric that says how many output records are written)

Or
Perform wc -l on output file.   (this isn’t very accurate because of buffer latency and long running when big!)

When number of records written reaches some level (input parameter) then terminate dstat, docker, and combine all information into output dir.

From: Ashley Jeffs<EMAIL_ADDRESS>Sent: Monday, March 2, 2020 1:10 PM
To: Jeffail/benthos<EMAIL_ADDRESS>Cc: Edmunds, Grant (Contractor<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Jeffail/benthos] metrics dont appear accurate (#390)
Hey @GrantEdmundshttps://urldefense.com/v3/__https:/github.com/GrantEdmunds__;!!CQl3mcHX2A!RmElYYgZlMWLz--ni-1i5-UopuuwEdAKMTFnxlYmstn2XIACTRZi_sUUjwo1oTSVcwp2$, are you sure that Benthos has finished processing the file when you query the metrics? With that config I would expect Benthos to shut down once the input file is fully consumed, in which case it wouldn't be possible to use curl to get the final counts.
If you try out the stdouthttps://urldefense.com/v3/__https:/www.benthos.dev/docs/components/metrics/stdout__;!!CQl3mcHX2A!RmElYYgZlMWLz--ni-1i5-UopuuwEdAKMTFnxlYmstn2XIACTRZi_sUUjwo1oVqgsPv6$ it'll print a definitive value when the service shuts down, that might help narrow this down.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/Jeffail/benthos/issues/390?email_source=notifications&email_token=AOWZTPONVKNNEGQYKGZWN5TRFQHBZA5CNFSM4K72OEU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENQYMII*issuecomment-593593889__;Iw!!CQl3mcHX2A!RmElYYgZlMWLz--ni-1i5-UopuuwEdAKMTFnxlYmstn2XIACTRZi_sUUjwo1oXwMzqtw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AOWZTPMWEXM3XRVCPMHNE23RFQHBZANCNFSM4K72OEUQ__;!!CQl3mcHX2A!RmElYYgZlMWLz--ni-1i5-UopuuwEdAKMTFnxlYmstn2XIACTRZi_sUUjwo1oeKDKfir$.

If you want to force Benthos to stay open after finishing the file you can add another input that stays open:
input:
  broker:
    inputs:
    - http_server: {}
    - file:
        path: "/input/infile"
        multipart: false
        max_buffer: 1e+06
        delimiter: ","

The http_server input will keep this instance running and shouldn't add any overhead.

Closing for now, if you have more questions feel free to reopen.


fix: now can use storage driver  oss

-tags include_oss

Codecov Report

Merging #11 (2e1815f) into master (25d1ff0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   62.79%   62.79%
=======================================
  Files           4        4
  Lines         172      172
=======================================
  Hits          108      108
  Misses         53       53
  Partials       11       11

Flag
Coverage Δ

unittests
62.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d1ff0...2e1815f. Read the comment docs.


cluster images (Objective-C)

Hi I am trying to change the clusters marker images to images I am getting from a json.

I download a json containing the urls of some items I want to cluster.
I create POIItems from these urls and pass them to the cluster manager.

what I would like is to have the last item in the cluster be the cluster images.
I have tried to use - (id)icongeneratorWithBuckets
but this seems to generate the icons before the json is even downloaded and after is it is downloaded it doesn't even run this function anymore.
How can I generate these marker icons using information from the items in the clusters?

 If it is the case, I'd suggest you perform the download of the images first. Once they've come back, start adding the items to the cluster manager. The defaultIconGenerator also has constructor to take custom images for each bucket.

This is some what what I have done but what I need to get is the cluster. once I have the cluster I can than determine which item is last in that cluster. once this is determined I can use that image as the icon of the cluster. I hope this makes sense.

This method

(GMSMarker *)renderer:(id)renderer markerForObject:(id)object;

could be what I am looking for but I have no idea how to use the object given and what to return.

I guess my real question is how do I use this
-- (void)renderer:(id)renderer willRenderMarker:(GMSMarker *)marker {
if ([marker.userData isKindOfClass:[MarkerDetails class]])
to check for cluster markers instead of item markers?

Closing this out as WAI. Please re-open if you need us to make any other changes. Thanks!


Readme and ImgBot.

Added Readme.md file and ImgBot for image optimisation.

@chicocvenancio please review the pr.

@Rohan-cod Thanks for sending a PR in. Sorry I missed the notifications last week.
Why did you include the svg "optimization" together with the added Readme?
It'd be a lot better to have these as separate PRs, one for the svg and another for the Readme.
On the Readme, I'll read it more thoroughly tonight and comment in-line. I'll add that it should be README.md with readme all caps. See https://en.wikipedia.org/wiki/README
On the svg, could you explain why imgbot is a good idea in this case? The 0.29kb difference stated in its commit message seems insufficient to justify the loss of readability that the indentation of the current SVG.
Cheers,

Okay sir, I will correct the name of the README.md file and send you another pr.
Actually, ImgBot optimises the images automatically. The difference was less may be because of the size or number of images but in the long run it will surely be an added benefit.
If you are not convinced, it's absolutely fine I will send a pr for the readme only.


Change the <operation.HttpMethod> to <operation.HttpMethodUpper>

I'm using your project to generate my AngularJS api client, and I found a problem, the METHOD of the http call was empty, I notice that AngularJs.txt T4 was using "operation.HttpMethod" instead "operation.HttpMethodUpper" which is been using Jquery T4 template who works fine.

Thank you for you fix... I haven't tested the Angular 1.x template yet... Is everything working for you? Please submit more PRs if more fixes are needed. I do not know the Angular http service that well...

You're welcome, your project is very useful, I'll start to use the generated client today, if I find something I'll fix and let you know.


AOL SMTP connection gets refused

known problem with using AOL -- "Connection Unexpectedly Closed" when using AOL

issue potentially identified as due to AOL's poor documentation on setting up SMTP not being clear on port and protocol, and due to others' poor documentation being incorrect.


iox-#2150 MinGW support for Windows

Pre-Review Checklist for the PR Author

[x] Add a second reviewer for complex new features or larger refactorings
[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[ ] Assign PR to reviewer

Notes for Reviewer

With this PR we do now support MSVC as well as MinGW to build iceoryx on Windows.
Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #2150

@elfenpiff thanks. I'll wait for #2155 to be merged first since these changes might have an undesired influence on the changes from that PR.


Lower level io methods for AssetServer.

Objective
Grant async code platform agnostic file system access to the assets folder and other AssetSources through AssetServer.
Solution
Added async methods read_stream and write_stream that can be used to read and write files as bytes or into an AsyncRead/AsyncWrite.
Example
async {
    let mut buffer = Vec::new();
    // Loads "assets/configs/config.toml"
    asset_server.read_stream("configs/config.toml", &mut buffer).await?;
    let config = toml::from_bytes(&buffer)?;
}

Testing
Added a test case for AssetServer
Issue: We currently have no tests for AssetWriter so the write function is untested. Adding testing support for AssetWriters would require a more dedicated PR.
Changelog

Added read_stream and write_stream to AssetServer.

If we don't want to merge a half untested pr, this is blocked on #13406.


eth-bytecode-db extractors: initialization

Starts blockscout extractor implementation. Initializes crate for extractors. Initialize initial migrations, according to schema.
The database migrations were intentionally implemented through the sea-orm framework to being possible to apply them to any database backend supported by sea-orm. That should allow to run the extractor locally with some local in-memory database (e.g. Sqlite)
One noticeable difference with other services design is that migrations were extracted into a root eth-bytecode-db directory instead of being implemented inside extractors crate. The reason is that in that case there would be 2 crates with the same name (migration) in one workspace: one for migrations in eth-bytecode-db and one for migrations in extractors. To solve the problem I suggest to extract migration and entity crates to root service directory.

seems outdated


Broken Link in README, leads to having build failure

The link for "Download and Setup" in the readme is broken. It leads to: https://github.com/timediv/tensorflow-with-kenlm/blob/master/tensorflow/g3doc/get_started/os_setup.md
This leads me to the error that when I clone and ./configure I get: no such package '@kenlm_archive//':

I have got the same problem too, did you solve it @wjpjet ?

fixed by using bugfix branch


[BUG] In PF2, unidentified items are classified as weapons

In PF2 systems, the unidentified item template is considered weapon when added to inventory rather than treasure. This makes it appear among the weapons and create a strike without proficiency, etc.

Possible Duplicate of #5
Basically, only retained thing is item.type. For example, dnd uses that to distinguish weapons from backpacks. From what I see, PF2 has similar approach:
  "Item": {
    "types": [
      "weapon",
      "melee",
      "armor",
      "equipment",
      "consumable",
      "treasure",
      "lore",
      "martial",
      "spell",
      "spellcastingEntry",
      "feat",
      "action",
      "backpack"
    ]
  }

I will investigate.

I might not get the system, but it seems it's assigning items the same as it would the original ones?

Okay, just confirmed it retains the type. Tanglefoot Bag is considered weapon, so adding it to inventory will add its unidentified item as weapon, which is a bit of spoiler what the item is. I know that this is a fringe case but it would be better if it were overridden as treasure in some cases, in others retaining the type (for unidentified items) is better. Can a conversion to Treasure be optional?

But there is also underlying issue that various item types in some systems might be internally incompatible and cause conflicts. You can basically freely edit the item beside it's type, so you can hide a magical fiery greatsword and set icon to show some Lute and name it "Bard's Bludgeon" ;)
As for conversion between types, that is very specific thing that should be done on system-by-system basis, or even on type-per-type basis. Currently out of scope, but I plan on making basic integrations and to expose full API to allow systems/other modules to integrate properly.

The way I see it, a new Make Treasure button for Unidentified items would be enough to fix this.


adding 'import harvester' test

Issue:

We need a harvester client for upcoming integration tests between rancher and harvester. https://github.com/rancher/qa-tasks/issues/468
Problem / Concerns

in order to import harvester's API, I had to modity go.mod a tad more than I was expecting. There are a few dependency bumps that may or may not be OK. Will likely need a Dev's approval on this PR. As it bumps everything from harvester's go.mod that is also in rancher's go.mod  to harvester's new minimum value, if its higher. i.e. the go version 1.22.0 -> 1.22.5
Solution

new client: https://github.com/rancher/shepherd/pull/342
rancher/rancher: add an action to register harvester as a provider in rancher (this will likely be a setup step in future tests)
rancher/rancher: add a test / proof-of-concept that shows harvester can be registered using Go.
Testing

tested on my homelab; able to connect an existing harvester setup with an existing rancher setup and use harvester as a provider.
note: this won't be easy to test in jenkins right now due to the new infrastructure Harvester has, and the lacking connection between it and our automation.

have some go.mod and go.sum conflicts. You can remove the go.mod and go.sum bumps as its been updated to the latest in one of the other prs. lgtm otherwise.


jq 1.6 has a poor performance

Related issue: https://github.com/stedolan/jq/issues/2069
There was a migration to the tag "1.6" in jq sources because of crashes: https://github.com/flant/libjq-go/issues/6. But 1.6 has poor performance. So the plan is:

create a benchmark to check if libjq-go is affected
choose a commit in master branch that has a good performance and don't crash on subsequent calls

Also, a 1.5 branch can be created with jq sources from tag "1.5".

Apart from the poor performance there is a problem with sequential Run calls. If jq expression has fromjson or tonumber that fail, then subsequent calls to jq_compile will fail and segfaulted.
The last commit that works well is https://github.com/stedolan/jq/commit/b6be13d5de6dd7d8aad5fd871eb6b0b30fc7d7f6. Also, this commit has good performance. So stick to this one: #11

Can be closed as resolved:

No issues with jq performance in shell-operator since v1.0.0-beta.9 release.
README now contains information regarding choosing a jq commit.


Detect If App Was Launched Via Push

Is there a parameter or flag somewhere that can let me know if the application was coldbooted via a push notification?
Currently, the on Notification handler fires concurrent to some other init code I have running at app start and it would be helpful to know if the app launched via a push notification before starting into my other code.
Thanks,
Matt

@84pennies look at data.additionalData.coldstart. It should be false if your app is already started and true if the app is not already started.
I have to document this in #483

He's referring to something outside the scope of the events triggered. Some global js var, or maybe a method on the api like this (which I agree would be usefull):
w.on('deviceReady', () => {
  PushNotification.wasColdstartedFromPlugin((answer) => {
    console.log("Was phonegap-plugin-push responisible for the last app coldstart? ", answer);
  });
})

I know the runtime is almost identical, but the limitation with how events work is tha we can't guarantee that it'll trigger sometime, as it will only trigger when that answer is true. This suggestion would be a nice way to enable  handling push notifications before the app is completely loaded to the user.

@fredgalvao Understood correctly what I was asking about.  The behavior I am trying to solidify is when cold booting the application from a push notification, the most efficient possible path would be to know ahead of time during the boot that the app was launched via push, make the call to 'register', and then wait for the .on('notification') handler to handle the background push and then do something accordingly.  However, since the app boot/init is not aware of how the app was launched or why, the .on('notification') handler ends up running at some point concurrent to another block of init code that has to be able to respond to the possibility of a push notification without warning.
Even at the least, it would be helpful to know when the registration occurs as a callback param that a notification is pending processing.  Or maybe some type of global var or param that indicates the app was launched via the user interacting with a push notification.
Thanks!

So, I was able to find this code block and add it to AppDelegate.m.  This let's you know if the app was booted via a push notification on iOS:
//adding this variable to track if app was launched via a push notif
BOOL launchedViaPush = false;

//check if app was launched via push
UILocalNotification *notification = [launchOptions objectForKey:UIApplicationLaunchOptionsRemoteNotificationKey];
if (notification) {
    NSLog(@"app recieved notification from remote%@",notification);
    launchedViaPush = true;
    //[self application:application didReceiveRemoteNotification:(NSDictionary*)notification];
} else {
    NSLog(@"app did not recieve notification");
}

My solution to getting this data into the cordova side of things is to add a query string parameter to the launch url (kind of hacky, yes) like so:
//appending a querystring parameter to tell cordova if it was launched via push
if (launchedViaPush) {
self.viewController.startPage = @"index.html?pushLaunch=y";
}
else {
self.viewController.startPage = @"index.html?pushLaunch=n";
}
This works just fine, but I have yet to find an equivalent Android solution (still working on it).  I am sure you could use a similar code block to interface it with the push plugin.  I'd try to write it, but I am not yet that familiar with the cordova exec/plugin interface stuff.

Be warned though, that piece of code will only work if the page to be loaded is exactly index.html. An ideal handling of that would be to query cordova settings to get the actual file name to be loaded, which may be different than index.html. Regardless, I still think that approach is suboptimal, as it would be lost as soon as a page change occured, so we really need that value to come from the native side directly (through an API method, as I suggested) so that it would survive any changes to the web side of things and still be available through the API.

@fredgalvao Totally agree.  Just sort of hacking my way through a solution.  And my page is never changing as it is a single page app.

I was able to find the portion of code in the android side of things that handles creating the intent if the app is not running and the push notification is engaged.  By using intent.putExtra() I was able to add an arbitrary parameter that I can then pick up in the onCreate in the main app class.  I can post more tomorrow, but so far I have what I need.  Granted the implementation (using the url parameter) isn't the cleanest.

For anyone wanting to see how to detect launch via push in the Android side of things, here's what you can do.  First, find this block in PushHandlerActivity.java.
/**
 * Forces the main activity to re-launch if it's unloaded.
 */
private void forceMainActivityReload() {
    PackageManager pm = getPackageManager();
    Intent launchIntent = pm.getLaunchIntentForPackage(getApplicationContext().getPackageName());
	String pushLaunch = "Y";

	//THIS ADDS A KEY THAT TELLS THE INTENT THAT IT WAS LAUNCHED FOR PUSH!  M.G. 1/14/2015
	launchIntent.putExtra("PUSH_LAUNCH", pushLaunch);

    startActivity(launchIntent);
}

Using the launchIntent, use the method putExtra().  This method allows you to add an extra parameter to the Intent that is being passed to the app.  In this case, I am simply adding a parameter to tell the onCreate() method that the launchIntent was invoked by interacting with a push notification.
Next, in the main app java file (platform>android>src>[your main app java file directory]), you can do the following to detect if the Intent has that extra parameter or not and therefore detect if the app was launched via push.
package com.m2.mbmd.phonegap;

import android.os.Bundle; //may need to add this to work with bundles
import org.apache.cordova.*;
import android.content.Intent; //need to add this

public class CordovaApp extends CordovaActivity
{
	@Override
	public void onCreate(Bundle savedInstanceState)
	{
		super.onCreate(savedInstanceState);
		super.init();
		final Intent intent = getIntent();  //this gets the intent
		boolean PushLaunch = false;  //var to store if this is a push launch
		Bundle extras = intent.getExtras();  //get the extra params from the intent

                    //I chose to iterate here, but you can also use .getString() to retreive a key value from a bundle
		if (extras != null) {
			for (String key : extras.keySet()) {
				if (key.equals("PUSH_LAUNCH") && value.equals("Y")) {
					PushLaunch = true;
				}
			}
		}

                    //here I am adding a querystring parameter to the launch url.  not the most ideal way to pass data to the webview, but this is where you could do something more elegant...
		if (PushLaunch) {
			launchUrl += "?pushLaunch=y";
		}
		else {
			launchUrl += "?pushLaunch=n";
		}
		loadUrl(launchUrl);
	}
}

@84pennies why don't you send a PR?

@84pennies I am trying to implement your solution, as my app also opens in the www/index.html of cordova, but I am unable to make it work
I am using
`- (BOOL)application:(UIApplication*)application didFinishLaunchingWithOptions:(NSDictionary*)launchOptions
{
//adding this variable to track if app was launched via a push notif
BOOL launchedViaPush = false;
//check if app was launched via push
UILocalNotification *notification = [launchOptions objectForKey:UIApplicationLaunchOptionsRemoteNotificationKey];
if (notification) {
    NSLog(@"APP START recieved notification from remote%@",notification);
    launchedViaPush = true;
} else {
    NSLog(@"APP START did not recieve notification");
}
//appending a querystring parameter to tell cordova if it was launched via push
if (launchedViaPush) {
    self.viewController.startPage = @"index.html?pushLaunch=y";
}
else {
    self.viewController.startPage = @"index.html";
}
return YES;

}`
Into the AppDelegate+notification.m, the log works fine, but my app stays in a black screen. I am really bad at objective, so maybe is a simple error. Can you help me?
Thanks in advance

Well, I am not too great at object C either, but I fumbled my way through this.  My AppDelegate.m has a bit more code in it than yours.
If you comment out the code blocks of mine that you're using, does your app work as expected?
If it were me, I would try to isolate which bit of code might be gumming it up by commenting it back in section by section and seeing if you can find the offender.

@macdonst Good idea.  I will try and get around to that soon!

@84pennies have you PR your work ? This is definitively something we need to merge into this plugin...

@zabojad See my reply to @macdonst above... Basically, I had to alter files outside the scope of this plugin in order for me to get this solution working.  I am sure there's a way to avoid doing that, but my experience in this arena is limited.  Feel free to use my code if it helps, but I am hoping others can implement a solution that doesn't require editing files outside the plugin.

I believe this has been changed
It's now notification.additionalData.foreground.  False if the app was opened from the notification

@csga5000 I was looking for a more general way to know how if the app was booted cold by interacting with a push notification.  It is more of a launch intent question.  That flag you noted works great if you want to know at the point of handling the push notification, but that happens too late in the launch/init process to be helpful for my use case.

Well if you received a notification and opened the app, then it'll be true and you can redirect.  But if you find a better option feel free to post it

I did post it a few months back :)
On Thu, Sep 29, 2016 at 5:26 PM Chase Anderson<EMAIL_ADDRESS>wrote:

Well if you received a notification and opened the app, then it'll be true
and you can redirect. But if you find a better option feel free to post it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/phonegap/phonegap-plugin-push/issues/501#issuecomment-250628915,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmI4O_sdOwS1bApCY3toS5oBrXOcHm_ks5qvFcggaJpZM4HEgsL
.

@macdonst  I really want to have a callback to the init function with the queued pushNotification and some additional info to solve this issue forever. Do you think it would go against something important?
Basically, what I want is to have every coldstart of the app noticeable by inspecting the object returned by the init event/callback.
interface InitInfo {
    wasLaunchedByNotification: boolean;
    notificationThatLaunchedTheApp: NotificationEventResponse;
}

That way we can solve two issues at the same time:

Being able to behave differently or skip something if the app was launched with the intention to deal with a pushNotification that was interacted with
Being able to get right away the pushNotification that triggered the launch and deal with it without having to wait for the later event to trigger.

As it is right now, having to "wait indefinitely until a pushNotification event maybe happens" is a really bad practice, and unfortunately we have no other option.
Maybe something like this:
const push = PushNotification.init({
    android: {},
    browser: {},
    ios: {},
    windows: {}
}, (initInfo: InitInfo) => {
    if(initInfo.wasLaunchedByNotification) {
        app.registerNotificationAsProcessed(initInfo.notificationThatLaunchedTheApp);
        $state.go('pushNotificationPage', {notification: initInfo.notificationThatLaunchedTheApp});
    } else {
        $state.go('home');
    }
});

or this
const push = PushNotification.init({
    android: {},
    browser: {},
    ios: {},
    windows: {}
});

push.on('initialization', (initInfo: InitInfo) => {
    if(initInfo.wasLaunchedByNotification) {
        app.registerNotificationAsProcessed(initInfo.notificationThatLaunchedTheApp);
        $state.go('pushNotificationPage', {notification: initInfo.notificationThatLaunchedTheApp});
    } else {
        $state.go('home');
    }
});

This is in a way an improved version of what coldstart aims to provide, but with a better time of execution. We could get rid of coldstart if we did what I'm suggesting, IMO. Of course this would be something for a major version bump, and we're lucky to already have one incoming (2.0 😉 )

Any updates on this? It would be nice to know if this feature can be expected in the future. Right now when user opens the app from notification the default screen is shown, then loading and then the right screen from notification payload. It would be great to skip the first screen.

I also am waiting for this, or at least some more discussion so a PR might maybe who knows sometimes be born :wink:

@84pennies this is exactly what I'm trying to do, sadly I don't succeed with. I pretty much have the same source like you have in your example from the 15th Jan 2016, but I can't get the extras back. Extra is always null.
Any hints?
Would be very much interested to put a working PR up when everything is working. I see this as a huge benefit.
(i'm using the latest plugin version 1.9.2)

Perfectly work the following combination to cover all cases.
Cordova itself has event 'resume' and 'pause'. One can listen to them to change the state of a flag foreground/background state of application (let't name it isPaused).
While the app is in the foreground, the notification observer is still called when a notification arrives.
So isPaused === true, notificationadditionalData.coldstart === false, notification.additionalData.foreground === false
We do not process this case.
While you click on the app icon on the desktop. You don't get the notification observer notified.
When you click on the message while you are on the desktop, you will get the following combination of state in the notification observer:
isPaused === false, notificationadditionalData.coldstart === false, notification.additionalData.foreground === true
If you run the app clicking on the message, you will get the following combination of state flags:
isPaused === false, notificationadditionalData.coldstart === true, notification.additionalData.foreground === false
When the app is run and you get the message.  You get the following state:
isPaused === false, notificationadditionalData.coldstart === false, notification.additionalData.foreground === true
When you click on the system message while you are in the app you get something like this again:
isPaused === false, notificationadditionalData.coldstart === false, notification.additionalData.foreground === false
Working for me as a charm.
`
if @_isPaused
return
if notification.additionalData?.coldstart || !notification.additionalData?.foreground
console.log 'cold'
(@_castMessageType notification).open @_state
return
`

@vashigor the discussion is about a slight different problem here. you need notification.additionalData, which you only get back when you have initialized PushNotification.init.
The idea is to know if the app has any push notifications queued before you call PushNotification.init and wait for the onNotification callback.
This way you can skip the default routing of the app and save a lot of time and the whole deep linking experience will be much more fluid.
P.s. I still couldn't get it to work with my native android skills, because getting the Intent won't give me the extras I put by the NotificationHandler beforehand. Any hints?
If this all works, I'd be very happy to create a working PR or put it in a separate plugin… I think it'd be a very good improvement for apps that work with deeplinks a lot.

It seems that push.init is called before push.notification, is there any solution for this? is this plugin production ready?

@benag this is going a bit off-topic: yes, this plugin is very production ready.
I still haven't found a solution to the getExtras() of the right intent back.

@zwacky , I see the point now. Looks like, I'm not so advanced with solving plugin's tricks yet. Probably the configuration of the initialization can be optionally offload to native part of the plugin installation, the same way that GCM id is specified. But I'll report results of my experiments with moving of notification processing before routing if I do some.

If it is guaranteed that the notification is called before any other code, then i can work around, if not I cant see how to use the plugin. It seems to be the case but is it certain on all devices?

@benag I don't think you're in the right issue for your problem. Please open a new issue for yours.

This would be a really useful feature to add if someone can figure out how to implement it. My code looks something like this:
function1();
push.on('notification') {
function2();
}
I want function2() to get called if the app is opened by clicking on the push notification. I want function1() to get called if the app is opened not by clicking on the push notification.
Right now function1() and function2() get called if I open the app by clicking on a push notification. I only want function2() to called called if I open the app by clicking on a push notification. Right now function1() gets called each time I open the app (I only want it called if I open the app not by clicking on the push notification).
Ideally this plugin would have a global variable called didOpenByClickingPushNotification. That way I could solve my problem by adding an if statement as follows:
if(!didOpenByClickingPushNotification) {
function1();
}
push.on('notification') {
function2();
}
The problem right now is that even though on('notification') does fire shortly after opening the app by clicking the push notification, my app doesn't know when it will get called.
Are there any plans to add this to the next version of this plugin?

In AppDelegate+notification.m I'd like to add sendPluginResult to the createNotificationChecker function, but I don't have access to self.commandDelegate in AppDelegate+notification.m.
[self.commandDelegate sendPluginResult:pluginResult callbackId:self.callbackId];
- (void)createNotificationChecker:(NSNotification *)notification
{

    NSLog(@"createNotificationChecker");
    if (notification)
    {
        NSDictionary *launchOptions = [notification userInfo];
        if (launchOptions) {
            NSLog(@"coldstart");
            self.launchNotification = [launchOptions objectForKey: @"UIApplicationLaunchOptionsRemoteNotificationKey"];
            self.coldstart = [NSNumber numberWithBool:YES];
        } else {
            NSLog(@"not coldstart");
            self.coldstart = [NSNumber numberWithBool:NO];
        }
    }
}

I also tried adding a load function to PushPlugin.m which calls the finishLaunching function like this:
- (void)load
{
[[NSNotificationCenter defaultCenter] addObserver:self
        selector:@selector(finishLaunching:)
        name:UIApplicationDidFinishLaunchingNotification
        object :nil];
}

- (void)finishLaunching:(NSNotification *)notification
{
}

But finishLaunching doesn't get called unless I make both class methods:
+(void)load
{
[[NSNotificationCenter defaultCenter] addObserver:self
        selector:@selector(finishLaunching:)
        name:UIApplicationDidFinishLaunchingNotification
        object :nil];
}

+ (void)finishLaunching:(NSNotification *)notification
{
}

The problem is that if they're class methods with +, then I can't use
[self.commandDelegate sendPluginResult:pluginResult callbackId:self.callbackId];

I'm facing the same matter too (using the plugin for an ionic project) and came across this topic :D I think this's definitely worth a PR. For now, I'm using a very ugly setTimeout to postpone the initial navigation to the root page in order to give the onNotification event enough time to figure out whether the app has been started from cold-state, if the answer is yes then I'll do st else with another page as the new root page. 1000 mili seconds is all it needs.

Would be very nice to have this enhancement fixed! +1


[BUG] crc status should report useful error codes

General information

OS: Linux / macOS / Windows
Fedora 32

Hypervisor: KVM / Hyper-V / hyperkit
kvm

Did you run crc setup before starting it (Yes/No)?
yes

Running CRC on: Laptop / Baremetal-Server / VM
N/A

CRC version
CodeReady Containers version: 1.13.0+8070bae
OpenShift version: 4.5.1 (embedded in binary)

Steps to reproduce

crc status
echo $?

Expected
"0" when "Running," other codes when not. Could be sophisticated to indicate state or could just be a "1"
Actual
Always "0"
Not having this means i have to grep the output in order to automate follow on work after crc start

Error codes are about the execution of the programming, not the state of the VM.

See #1227, closing as the referenced issue will solve the'grep' problem

Could be sophisticated to indicate state or could just be a "1"

This would have to be a flag as multiple combinations are possible;

VM is (NOT) running
OpenShift is (NOT) running
Operator(s) is/are (NOT) running
... etc

Note: if you insist on this, we can reconsider

We could follow what systemctl is doing https://man7.org/linux/man-pages/man1/systemctl.1.html#EXIT_STATUS and at least report cluster running/cluster not running/(if possible)cluster in a degraded state, with "cluster" being very generic and meaning VM + OpenShift.


fastlane stopped working after Xcode 8 Swift 2.3 upgrade, using legacy build

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I have read the Contribution Guidelines

Issue Description
fastlane stopped working after Xcode 8 Swift 2.3 upgrade with use_legacy_build_api on.
Complete output when running fastlane, including the stack trace and command used
[15:08:10]: ▸ Generating 'MyApp.app.dSYM'
[15:08:12]: ▸ Running script 'Crashlytics'
[15:08:12]: ▸ Running script 'Copy Pods Resources'
[15:08:12]: ▸ Running script 'Enable Charlex Proxy'
[15:08:12]: ▸ Running script 'Embed Pods Frameworks'
[15:08:12]: ▸ Touching MyApp.app
[15:08:14]: ▸ Signing /Users/rebecca/Library/Developer/Xcode/DerivedData/MyApp-ehspzmhgbbqgqubkiamelixpqmrz/Build/Intermediates/ArchiveIntermediates/MyApp\ Enterprise/InstallationBuildProductsLocation/Applications/MyApp.app
[15:08:15]: ▸ A launch storyboard or xib must be provided unless the app requires full screen.
[15:08:15]: ▸ Archive Succeeded
[15:08:15]: Legacy build api is enabled, the `export_method` value will be ignored
[15:08:15]: $ /usr/bin/xcrun /tmp/PackageApplication4Gym -v /Users/rebecca/Library/Developer/Xcode/Archives/2016-10-17/MyApp\ 2016-10-17\ 15.05.52.xcarchive/Products/Applications/MyApp.app -o '/var/folders/zp/46tdf0wj057bt5b6wsmkqgv00000gp/T/gym_output20161017-73258-dyyjrt/MyApp.ipa' exportFormat ipa
[15:08:20]: Error copying over framework file. Please try running gym without the legacy build API enabled
[15:08:20]: For more information visit https://github.com/fastlane/fastlane/issues/5863
[15:08:20]: Missing file /Users/rebecca/Library/Developer/Xcode/Archives/2016-10-17/MyApp 2016-10-17 15.05.52.xcarchive/Products/Applications/VarageSale.app/Frameworks/libswiftPassKit.dylib inside /Applications/Xcode.app/Contents/Developer/
[15:08:20]: If you're using Swift 2.3, but already updated to Xcode 8
[15:08:20]: try adding the following parameter to your gym call:
[15:08:20]: gym(use_legacy_build_api: true, toolchain: :swift_2_3)
[15:08:20]: or
[15:08:20]: gym --use_legacy_build_api --toolchain swift_2_3
[15:08:20]: -----------------------------------
[15:08:20]: --- Step: clean_build_artifacts ---
[15:08:20]: -----------------------------------
[15:08:20]: Cleaned up build artifacts 🐙
[15:08:20]: --------------------------
[15:08:20]: --- Step: notification ---
[15:08:20]: --------------------------
[15:08:20]: Variable Dump:
[15:08:20]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios applause", :GET_INFO_PLIST_VALUE_CUSTOM_VALUE=>"3.19"}
[15:08:20]: No such file or directory - /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftPassKit.dylib

+------+----------------------------------------------+-------------+
|                         fastlane summary                          |
+------+----------------------------------------------+-------------+
| Step | Action                                       | Time (in s) |
+------+----------------------------------------------+-------------+
| 1    | Verifying required fastlane version          | 0           |
| 2    | default_platform                             | 0           |
| 3    | Switch to ios set_build_number lane          | 0           |
| 4    | get_info_plist_value                         | 0           |
| 5    | get_info_plist_value                         | 0           |
| 6    | Switch to ios set_applause_build_number lane | 0           |
| 7    | get_info_plist_value                         | 0           |
| 8    | get_info_plist_value                         | 0           |
| 9    | set_info_plist_value                         | 0           |
| 10   | set_info_plist_value                         | 0           |
| 11   | Switch to ios archive_applause lane          | 0           |
| 💥    | gym                                          | 150         |
| 13   | clean_build_artifacts                        | 0           |
| 14   | notification                                 | 0           |
+------+----------------------------------------------+-------------+

[15:08:20]: fastlane finished with errors

[!] No such file or directory - /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftPassKit.dylib

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
  # make applause archive
  private_lane :archive_applause do
    gym(
      scheme: "MyApp Enterprise",
      configuration: "Release Enterprise",
      clean: true,
      use_legacy_build_api: true,
      export_method: "ad-hoc",
      xcargs: "ARCHIVE=YES" # Used to tell the Fabric run script to upload dSYM file
    )
  end

Environment
fastlane version (run fastlane -v): fastlane 1.105.2
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
What Xcode version do you use (e.g. 7.3, 8.0)
8.0

as in the log: toolchain: :swift_2_3 try setting this in gym

I did that too.  It fails immediately when I try that.
[15:40:48]: Variable Dump:
[15:40:48]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios applause", :GET_INFO_PLIST_VALUE_CUSTOM_VALUE=>"3.19"}
[15:40:48]: Could not find action or lane 'swift_2_3'. Check out the README for more details: https://github.com/fastlane/fastlane/tree/master/fastlane

+------+----------------------------------------------+-------------+
|                         fastlane summary                          |
+------+----------------------------------------------+-------------+
| Step | Action                                       | Time (in s) |
+------+----------------------------------------------+-------------+
| 1    | Verifying required fastlane version          | 0           |
| 2    | default_platform                             | 0           |
| 3    | Switch to ios set_build_number lane          | 0           |
| 4    | get_info_plist_value                         | 0           |
| 5    | get_info_plist_value                         | 0           |
| 6    | Switch to ios set_applause_build_number lane | 0           |
| 7    | get_info_plist_value                         | 0           |
| 8    | get_info_plist_value                         | 0           |
| 9    | set_info_plist_value                         | 0           |
| 10   | set_info_plist_value                         | 0           |
| 11   | Switch to ios archive_applause lane          | 0           |
| 12   | clean_build_artifacts                        | 0           |
| 13   | notification                                 | 0           |
+------+----------------------------------------------+-------------+

[15:40:48]: fastlane finished with errors

[!] Could not find action or lane 'swift_2_3'. Check out the README for more details: https://github.com/fastlane/fastlane/tree/master/fastlane

Thanks @hjanuschka - I had tried that, but missed the extra colon before "swift_2_3".  Works now, thanks!

@rsiu  glad it helped - yeah unusual to use symbols in the params 😄


Bump require for new AmplNLWriter release

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e2adbdb). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #19   +/-   ##
========================================
  Coverage          ?   96.2%
========================================
  Files             ?      11
  Lines             ?     422
  Branches          ?       0
========================================
  Hits              ?     406
  Misses            ?      16
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2adbdb...fc5956e. Read the comment docs.

Changes Unknown when pulling 6ac619a23854d1e02f71b8afd2ede6add8f5c16b on bumprequire into ** on master**.

Changes Unknown when pulling fdfbff12383b3d28ca91ddb48040cdbd526e6819 on bumprequire into ** on master**.

Changes Unknown when pulling fdfbff12383b3d28ca91ddb48040cdbd526e6819 on bumprequire into ** on master**.


Using an html form element as a root doesn't work

If I do this:
$('form').each(function () {
  var form = this,
      submit = $('button[type=submit]', form);
  submit.click(function () {
    // do stuff
  });
});

It doesn't work. The problem is that (at least in Chrome) html form elements have a length. Therefore, when qwery is trying to determine the root element, it looks at the form element as a qwery selector and returns form[0], which in this case turns out to be an input element of the form. The temporary way around this is to wrap the bare html form element in a qwery:
// instead of
var form = this;
// do
var form = $(this);

this is a regression that i had solved for once a very, very long time ago... and i'm sure i never looped @rvagg into it. ironically this used to be an old bug in jQuery too where they weren't checking the fact that forms have length properties (gah, stupid DOM 0 feature).

Now that is interesting. Consider it assigned to me, I'll have a fix in shortly along with a test to make sure it stays fixed.

thanks for picking this up btw @benekastah

@rvagg No problem. That was fast!


It doesn't show me any skin

I did the download correctly and I started again several times but still nothing I tried the trick of step 2 but still! Is there a problem because I come from France maybe?

This is not a Skin Changer or any sort of hack, IT MANAGES THE SKINS YOU OWN.
@Kiyt03

your page doesn't show me skins either, it's also just empty, I can't choose a skin why?

People's vision are so good these days.


Ability to change forgot password location

Usually the forgot password is place under the login button.
There are multiple solution but here I propose a cool one....I think.
We would need to have a way to order components.
A suggestion:
Define an enum
enum Components{
title,
title_description,
form,
login_action_button,
accrount_creation_action,
forgot_password_action
}
Add a property display_order to the AnimatedLogin class OR to the Theme with a default value provided for the list.
This will not break the current API.
And you can mark the showForgotPassord as deprecated....and in the meantime when this is true...change the display_order list !
Same thing for showChangeActionTitle
LMM

Enabling custom order of components is a great idea, thanks @wer-mathurin ! I will be implementing ASAP. It seems to fit in my mind.


[FEATURE] Websockets for Endpoints

The endpoints of the API could trigger Websocket-Events on which Front-end-Applications could listen

Yep, we will definitely need this for the map UI project

@Cahllagerfeld this seems like a cool feature, is it still needed?

I dont know how @eddiejaoude planned with this. In my opinion its still needed. I think theres even a nest-package for Websockets @nestjs/websockets @nestjs/platform-socket.io. The last time I had a look at websockets with nestjs there was an issue that the packages wasnt compatible with the newest socket.io-version. I think there needs to be some research done on it first before implementing.
What do you think about that Eddie?

yep I am definitely keen on this feature 👍 we could do a prototype / spike on a live stream 🤓


Add backend test for CountStat(messages_sent_to_stream:is_bot).

@rishig

Automated message from Dropbox CLA bot
@aakash-cr7, it looks like you've already signed the Dropbox CLA. Thanks!

This was merged via #3307.


Keep working directory same when new terminal is spawned

[ ]  ~cwd in Windows~

Here is a way to get cwd in windows. But don't have a windows pc to build it currently. So I'll leave it for future.


Merge master renames into usecases branch

Looks like Travis stopped working but it's a subset of Circle's tests.


Bug(locales): CMS still has hard coded English strings

Related issue: https://github.com/netlify/netlify-cms/issues/2947
Screenshots from that issue:

Please add more relevant screenshots if you identify more hard coded strings.

Hi, is this issue available for me to work on?

@tiuweehan, go for it. I think Login with Netlify Identity should be fixed by now, and the login modal might require fixing in https://github.com/netlify/netlify-identity-widget.

As I mentioned in #3186

As I mentioned in #3186

I already made this simple fix for that https://github.com/pniedzwiedzinski/netlify-cms/tree/optional-hardcoded, but I added only English and Polish translations.
Should we add all translations at once? And should we merge all these small fixes in one PR?

@pniedzwiedzinski your fix is already an improvement so thank you :) As each translation we have was contributed by a different persons(s), I don't think we need to wait. The process so far has been that people would close the gap from the english version when they have the time - we just need to expose a way for them to do so.

@pniedzwiedzinski I created a new branch on my fork. Maybe you could make a PR to my fork first, then I will make a PR to this repo after I am done with the rest of the issues?

Closing as I believe this is fixed


fixed jslib to use callbacks, cleaned up

Previously: method names were passed as strings, a SendMessage was used that searches for a monobehaviour with a given name (not quite reliable/efficient way of passing things in Unity).
Currently: methods are marshalled as proper callbacks. A MonoBehaviour in the scene is no longer necessary for this awesome system to work.
I also added small fixes to jslib so that things can be passed around between functions without using window. I suppose it can be further optimized, but I don't know how it ended up so complicated in the first place so I left it generally intact.

Thanks for this. My guess is the reason it was the way it was is that's the way I found in the docs in 2014 from my first Unity<->JS stuff. Thanks to your example I've learned better ways


[$250] [Bug] - Second message disappear when typing second message quickly after sending 1st one reported by @puneetlath.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

send a message
immediately start typing another
after a second, everything I’m typing goes away (notice how the I disappears in the second message).
If you're having difficulties reproducing, try other chats, specifically ones that have a shit-ton of messages. I (@mallenexpensify ) can replicate in Version 1.2.12-0 by attempting a couple times in different chats, feel free to test me with too<EMAIL_ADDRESS>
Expected Result:
No disappearing of the message
Actual Result:
after a second, everything I’m typing goes away (notice how the I disappears in the second message)
Workaround:
Unknown
Platform:

Where is this issue occurring?

Desktop App

Version Number: Version 1.2.12-0
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664559360112699
View all open jobs on GitHub
https://user-images.githubusercontent.com/43996225/193375849-020b480a-e22b-44f6-a64d-c818d1b04030.mp4
https://user-images.githubusercontent.com/43996225/193375850-4b10d3f7-94d1-4235-bff8-d37687a9f7bf.mov

@kavimuru, a lil misunderstanding here. It's reported by @puneetlath.

@youssef-lr - you're actively working on a PR for this, right? If so, can we assign this to you and replace it with an Internal label..

@trjExpensify PR ready!

Woop! Discussed in thread, assigning to @youssef-lr and marking as Internal.

@trjExpensify server-side fix deployed to staging and I can confirm I can longer reproduce this.

Thanks for the quick fix @youssef-lr !!!

This has been fixed. Closing!

hehe, it was an issue where Puneet, a contributor, was initially inc. as the reporter but Puneet, who works here, was the one who posted the bug.  Closing

@youssef-lr this is an edge case issue where the External label was added then removed. While the job was Help Wanted, @tienifr submitted the proposal above.   Since they weren't hired they're technically not due compensation but, if you referenced their code when working on your fix, we should compensate them.  Did you?

@mallenexpensify this was fixed in Web-E. We didn't end up changing code in App.

Thanks @youssef-lr !  Thanks @tienifr for submitting the proposal as well. closing... again.


Add preamble

A short (2-4 sentences) explanation of the challenge at the top of index.md is warranted.

9191c13


[Bug]: showAlert comes up as undefined on browser console.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Not sure of the repro steps here, loading an app logs showAlert as undefined on browser console
Steps To Reproduce

Go to app at this location
Open up browser console and observe the showAlert error as seen in the screenshot below

The functions:

Public Sample App
https://release.app.appsmith.com/app/earworm/spotify-and-youtube-61ea4a44361846772cfb1180/edit
Version
Cloud

Isn't showing up hence closing it


Text Icon (T)

Currently JamIcon provides wide variety of icons for Headers like h,h1,h2,h3.
We need an icon for Body Text too.

Added in v3.1.0