feat: save public key or its ID to secretFileData

In our Project where we use skipper, we want to implement a feature where re-encryption of secrets is possible using a single command.
In our best-case scenario, we want to be able to replace the key in the inventory and let our project's CLI do the rest. But this means we have to know which was the OLD key and which is the NEW one, we want to re-encrypt our secrets with.
This change saves the "Public Key" (there's no such driver as of this PR, which uses a public key) or a Key Identifier (azurekv) to enable skipper to know which secret got encrypted with which key.

@lukasjarosch PR is now ready, PTAL.


hyprcursor only changes theme if size is changed

hyprcursor fails to change the cursor theme if the size isnt changed to a diffrent one - discovered with catppuccin cursors.
hyprctl setcursor theme 24 doesn't work, but hyprctl setcursor theme 25, and then repeating the last command will change the cursor theme.
Hyprland, built from branch  at commit cba1ade848feac44b2eda677503900639581c3f4
hyprcursor 0.1.9-1

this is a hyprland bug


Improved the BlockChangeFlags.

API | Common
@gabizou

Can we also add some Javadocs to the BlockChangeFlags fields? While the names are fairly indicative of what they do, some may benefit from better explanations.

@gabizou I updated this PR for the changes you made, this now just removes the orFlag and exclusiveOrFlag methods and added some docs to the cataloged block change flags.


doctype appended as string to document content

We've noticed an issue where the start of pre-rendered output string is of the following format:
html<html lang="en"
This is causing Facebook's scraper to not scrape properly, which makes sense as it's not valid html.
Looking through the source code, I notice in chrome.js the following lines (536-545):
}).then((response) => {

			let doctype = '';
			if (response && response.result && response.result.description) {
				doctype = response.result.description;
			}

			tab.prerender.content = doctype + tab.prerender.content;
			clearTimeout(parseTimeout);
			resolve();

Can you explain why the doctype is being appended like this as a string? How are we supposed to consume the content output of the prerender object?
Thanks

Can you give an example of a URL where that is happening? Feel free to email that to me at<EMAIL_ADDRESS>if you want to keep it private.
When I run a local Prerender server and run:
curl -v http://localhost:1337/https://prerender.io/

I'm seeing a response starting with:
<!DOCTYPE html><html ng-app="prerender.io" class="ng-scope"><head>

So it's meant to add that doctype at the beginning there.

I've noticed this issue using Prerender with the stable version of Chrome since updating to 72.0.3626.81 (MacOS and Debian) last week. For now, I'm working around it with a custom plugin to modify req.prerender.content on pageLoaded, but just wanted to give a heads up that this appears to no longer be just a Chrome Canary issue. Unfortunately, I don't have an externally accessible example url available at the moment.
Thanks!

I just noticed this issue appear as well, on an Ubuntu 18.04 LTS system with current Node modules. It appears that document.doctype.description is now returning simply "html" instead of "" in valid HTML documents. I put in a workaround in my lib/browsers/chrome.js file. Could you please test against the most current Google Chrome and most current Node modules pulled down by "npm install" to see if you also have this behavior? Thank you so much!

I can confirm this as well with Chrome 72. Looks like we were depending on the default string value of the doctype object and that has changed. I'm about to push a backwards compatible fix that actually parses the correct doctype from the doctype object instead of relying on the correct string to be sent back.

This should now be fixed in Prerender v5.5.1.
Thanks so much for reporting this and please let me know if you see an issues after upgrading!

I meant to post back here, but confirming that I'm no longer seeing this issue on my end with Chrome 72 after upgrading to Prerender 5.5.1. Thanks!

Great, thanks!


refactor: simplify, align names

:tada: This PR is included in version 0.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Installing on Windows, init.R not included in sessions by default?

Describe the bug
I've gone through a couple of clean installs on Windows 10 laptops.
In both of these installs I installed:

vscode-r
r-lsp
httpgd

The blogs on https://renkun.me/2020/06/16/using-httpgd-in-vscode-a-web-based-svg-graphics-device/ really helped with this :)
These installs went really well, except that .vsc.browser is not available

To fix this locally, I manually edited my rprofile to get a source of init.r in there... and to get the chart drawing work I also had to enable the session watcher functionality.
I looked on https://github.com/Ikuyadeu/vscode-R/wiki/Installation:-Windows and couldn't spot any steps I missed.. it feels like perhaps there are some windows path installation issues?
To Reproduce
Follow
https://github.com/Ikuyadeu/vscode-R/wiki/Installation:-Windows
Open a new R window, then try using .vsc.browser - it is unknown...
Do you want to fix by self? (I hope your help!)
Yes - happy to try
(If yes,) what kind of help do you want? (e.g. Which file should I fix, Survey (related documents)
Some where you might look pointers...
Additional context
Thanks for this - fab stuff

It seems that the session watcher init.R is not sourced at all. Do you use R: Create R terminal to start R or do you start R manually in the terminal?

Thanks
I've always started it using Ctrl+Enter on some R in an editor window... that automatically starts and R session for me.
I've just experimented and I think that if I rollback my manual .Rprofile change and use Ctrl+Shift+P and "R: Create R terminal" then I do get .vsc injected...
So is this just about the route that Ctrl+Enter takes to creating a terminal?

Ctrl + Enter will run R: Create R terminal if r.alwaysUseActiveTerminal = false and there's no active R terminal. User .Rprofile is sourced before init.R. If an error occurs before init.R is sourced, then it won't be sourced at all.
Looks like there might be an error in your .Rprofile that prevents sourcing init.R from running?

OK
I've run lots of different combinations now...
I think the problem is by design...
I think in reading through the tutorial on https://renkun.me/2020/06/16/using-httpgd-in-vscode-a-web-based-svg-graphics-device/ and reading through the readme on here, I've completely missed the fact that those .vsc methods are only there if you somehow enable the session watcher.
Sorry for wasting your time on this - thanks for the excellent work and for answering this query - I know what I need to do now... so closing...


Latest image is broken

There appears to be a compiler error in the current nightly rust build. Might suggest switching to an older version like ghcr.io/nottirb/fuzz-rust@sha256:85ce0c47246b8ecdd4e3889a4964445d555406d53bbf9b99f3c833ac3a6446b6
You can do this as follows:
docker pull ghcr.io/nottirb/fuzz-rust@sha256:85ce0c47246b8ecdd4e3889a4964445d555406d53bbf9b99f3c833ac3a6446b6
docker tag ghcr.io/nottirb/fuzz-rust@sha256:85ce0c47246b8ecdd4e3889a4964445d555406d53bbf9b99f3c833ac3a6446b6 ghcr.io/nottirb/fuzz-rust:latest
docker push ghcr.io/nottirb/fuzz-rust:latest

Hopefully this is fixed now, if not let me know and I can revert and stop workflows. Sorry for the late reply.
Closing for now.


stop discovery metadata publishing if wis2box.data_mappings is not defined (#656)

Fixes #656

CI failure is unrelated (but critical).  codes.wmo.int recently went through a system upgrade which is causing the issue.


Update inlines.js

Do not instantiate material select on aucomplete fields (conflicts with Select2).
Fixes #103

Hi Anton!
I do not understand why this PR was rejected, as the issue raised in #103 is really annoying (and even blocking on our side). Could you please elaborate?


ci: auto add issues/PRs to AA project board

Tested here: https://github.com/semiotic-ai/project_automation_test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.712%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
332

Relevant Lines:
556

💛  - Coveralls

PS: it already ran the new workflow! You can see it in the PR checks above. (because the branch already is in the repo, and thus has access to the newly added secrets, etc)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.712%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
332

Relevant Lines:
556

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.712%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
332

Relevant Lines:
556

💛  - Coveralls


Introduce weighted edge connections in the project focused graph networks

Introduce weighted edge connections in the project focused graph networks based on degree of participation of contributors based on work done in  https://github.com/oss-aspen/Rappel/issues/188 on the prominence of individuals in a community.
Potential weighting ideas by @JamesKunstle:

Importance of a mutual contributor is either the max of the importance of contributor across all communities or the avg- maybe weighted additionally by some variant or inverse of TF/IDF
Weighted proportionally to recency as well, likely.

Assigned to @christinaexyou

Continuing discussion here: https://github.com/oss-aspen/Rappel/pull/236

should this be closed?


Add a default value for serial consistency: LocalSerial

This series adds a default serial consistency level for queries - LocalSerial. The decision is based on the fact that LocalSerial is the one that provides acceptable performance. Users interested in strong, cross-dc consistency - which could also cause prohibitive latencies - should override to Local.
The series also comes with a doc entry which briefly explains LWT queries (they weren't mentioned at all so far), as well as an extra validation layer which would prevent users from setting a wrong consistency level, without introducing any backward incompatible changes.
This series introduces a breaking change - serial consistency is now defined as a separate enum. Fixing the existing aplications is trivial and consists of replacing all occurrences of Consistency::LocalSerial to SerialConsistency::LocalSerial and Consistency::Serial to SerialConsistency::Serial.
Fixes #277
Pre-review checklist

[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[x] I added relevant tests for new features and bug fixes.
[x] All commits compile, pass static checks and pass test.
[x] PR description sums up the changes and reasons why they should be introduced.
[x] I added appropriate Fixes: annotations to PR description.

v2:

instead of runtime checks, split the types so that the compiler can check correctness for us

@piodul rebased, review ping

There's some clash with a recent bump of docs version, I'll debug. Meanwhile, the code itself is still reviewable


Add model parameter

Might be introducing a bug as same param is used in RecursiveCharacterTextSplitter.from_tiktoken_encoder and OpenAI client call. Checkout tiktoken.model.MODEL_PREFIX_TO_ENCODING and tiktoken.model.MODEL_TO_ENCODING for a supported list of strings to pass.
If we're doing this change, might as well make it more general and pass a 'translation_agent_model' class / object which implements get_completion. This way we give flexibility to user in experimenting, model could be local or api based ... etc.

Thank you @liugddx for submitting the PR, and @Omaraldarwish for the extension proposal.
@Omaraldarwish I agree that making this more general makes sense. If I understand your suggestion correctly, the "translation_agent_model" class you propose would also potentially give us more flexibility in controlling additional functionality, e.g. the way the reflection is done (which now uses just a call to get_completion()). Or it could be helpful if we wanted to add support for a glossary as described here.

@methanet yes!! I'm actually working on branch that pulls all parameters out so users can explicitly control them / experiment with the them -that's turning out to be quite the rebase from what is in main right now! Also not clear whether functional or object-oriented would be better. Could go both ways.
On the flip side, If we want a quick simple "bring your own model" refactor, it seems we only need them to pass a class that implements get_completion and num_tokens_in_string. Check it out here. Still need to update docs and test suite!


Make a distinction between App Service OS for agent-based app monitoring

Hello,
From this page I cannot see if there is Agent-based application monitoring available for App Service applications running on Linux OS. Please make sure to add this distinction and prevent others from researching deeper on this topic, which should be provided in this document. If there is a section or document on this present, maybe add a pointer or link?
Thanks,
Marjan

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 098ffe3a-2cbd-1038-30f2-dd2f528984a3
Version Independent ID: 65da3e70-2ac2-8f6e-51a5-e759bcc8253f
Content: Monitor Azure app services performance - Azure Monitor
Content Source: articles/azure-monitor/app/azure-web-apps.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@alternaivan Thanks for the question! We're investigating this and will get back to you shortly.

looping in @DawgFan as his team is working on expanding our capabilities in these areas and may want to touch base.

@alternaivan thank you so much for the suggestion! I have updated the doc to make clear that for Linux based workloads manual instrumentation is currently required.
The changes are merged internally and will go live in the public docs later today. Thanks again for helping to improve our docs!

#please-close


CI/CD infrastructure

We could use COMPSs' Docker image to check builds on every commit.
Continuous Deployment is not needed but I would like a Continuous Integration infrastructure that

checks builds
runs tests
measures code coverage

@fjconejero This feature is on-hold due to the fact that the COMPSs image with custom Python installation is broken.


add dump-external-links subcommand

Hi @untitaker, this is a stab at implementing the ability to count external (and poorly formed) URLs as broken, per this comment.
Here's an example.
www/index.html

$ cargo run www --count-uncheckable
Reading files
Checking 5 links from 1 files (1 documents)
www/index.html
  error: bad link /foo
  error: bad link /http:/www.url.com

Found 3 bad links

A couple of notes:

The http://www.url.com#baz URL isn't getting included in the list.  Seems like it's being merged with http://www.url.com after dropping the hash, leading to a mismatch between the number of errors logged, and the Found 3 bad links count at the bottom.
The error: bad link log for external URLs always has a leading slash which looks weird, and a slash is being removed from the scheme.  I'll look into that, hopefully next week.
The option name --count-uncheckable I find really clumsy, but I couldn't think of a better name.  Happy to change it if you have a better idea.

The http://www.url.com#baz URL isn't getting included in the list. Seems like it's being merged with http://www.url.com/ after dropping the hash, leading to a mismatch between the number of errors logged, and the Found 3 bad links count at the bottom.

this is happening if --check-anchors isn't being passed yes.

could you actually elaborate on the usecase for that? when you posted that issue comment I thought you were gonna add an additional number to the summary, not count those external links as broken. Leading to something like:
$ cargo run www --count-uncheckable
Reading files
Checking 5 links from 1 files (1 documents)
Found 0 bad links, 3 external links

That's my mistake, once I got into the code I found the is_bad_schema function was responsible for filtering out both invalid and external URLs.  I started to rewrite it, expanding the return type to represent internal, external, and invalid links, but that line of changes started to sprawl quite a bit.
My use case is that I have a static site and I want to know about all broken internal links, poorly formed links, and external links (whether they work or not).  When the is_bad_schema line of changes got big, I realized I could leave is_bad_schema as it was, but just start logging every link that returned true.  It's definitely a hacky shortcut for my usecase, and I realize now it doesn't belong in main at all.  Well, maybe having poorly formed links flagged as "bad" might be useful to others, but flagging valid external links as bad is a definite antifeature to everyone but me.

Thanks, I'll take that route this time. :)
In addition to the external link count, logging the external links would be useful to me.  Would you like to see that change as well?  Something like this:
Reading files
Checking 5 links from 1 files (1 documents)
www/index.html
  error: bad link /foo
  info: external link http:/www.url.com

Found 1 bad link, 1 external link

In that case I would create a separate command entirely that dumps those links, also in a format that is more machine-readable.
the concern i have is performance overhead for the common usecase.
This can be done by:

moving the link filtering into LinkCollector itself (concretely BrokenLinkCollector)
creating a new clap subcommand similar to match-all-paragraphs
using the UsedLinkCollector which just collects all observed links into a vec

Thanks, that helped a lot.  I'm pretty close, but the external UsedLink hrefs are being run through push_and_canonicalize which turns http://foo.com into http:/foo.com.  Also, hrefs
www/index.html
Foo

www/inner/index.html
Bar

Results in:
http:/foo.com
inner/http:/bar.com

I'm guessing this is also caused by relative path resolution inside push_and_canonicalize.  My only idea is to pass a bool down to where push_and_canonicalize is called here which can disable it when dumping external links.  What do you think?  Would that affect the default code path too much?

@mwcz i would attempt to move url canonicalization into the collector as well then, assuming the filtering now happens there. then the canonicalization can still happen after filtering.

@untitaker HyperlinkEmitter currently owns the arena allocator that gets used by push_and_canonicalize's BumpString param.  If I move canonicalization to BrokenLinkCollector, I think it needs to own an arena as well.  Does that check out?

I think that's fine, we'll have to benchmark but i think it should not cause too many problems
On Thu, Sep 8, 2022, at 18:02, Michael Clayton wrote:

@untitaker https://github.com/untitaker HyperlinkEmitter currently owns the arena allocator that gets used by push_and_canonicalize's BumpString param. If I move canonicalization to BrokenLinkCollector, I think it needs to own an arena as well. Does that check out?
—
Reply to this email directly, view it on GitHub https://github.com/untitaker/hyperlink/pull/158#issuecomment-1240918173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMPRN6EWU35S7GGYGBXVTV5IE3FANCNFSM6AAAAAAQDSAUEU.
You are receiving this because you were mentioned.Message ID: @.***>

Made some more progress today.  Here's some sample output:
$ hyperlink dump-external-links www
Reading files
Checking 5 links from 2 files (2 documents)
www/dir/index.html
  info: external link //www.url.com
  info: external link http://www.url.com

www/index.html
  info: external link http://www.url.com

Found 3 external links

Benchmarks
I used hyperfine to benchmark release builds of hyperlink on this branch and the main branch, using a large site (136,206 HTML files, ~300,000 broken links currently) and got these numbers:

(on a Ryzen 9 5900X)
Notes

I copied the standard output style, but I can change it to something more machine-readable if you like.
I added a is_external_url(url: &str) to mod.rs which is called in two places.  It does have some overlap with is_bad_schema and I can work towards combining them if you prefer.
Moving the push_and_canonicalize call to BrokenLinkCollector made test_document_links start failing.  I'll look into it.  Probably has to do with an is_bad_schema call site being moved, so the external URLs previously ignored are sneaking into this code path.  Test output below.

cargo test

running 20 tests
test collector::test_is_bad_schema ... ok
test html::test_document_href ... ok
test html::test_document_join_index_html ... ok
test html::test_push_and_canonicalize::basic ... ok
test html::test_push_and_canonicalize::empty_base ... ok
test html::test_push_and_canonicalize::external_scheme_empty_base ... ok
test html::test_push_and_canonicalize::empty_href ... ok
test html::test_document_join_bare_html ... ok
test html::test_push_and_canonicalize::external_scheme_index ... ok
test html::test_push_and_canonicalize::external_scheme_relative ... ok
test html::test_push_and_canonicalize::external_scheme_subdir ... ok
test html::test_push_and_canonicalize::index_html ... ok
test html::test_push_and_canonicalize::files ... ok
test html::test_push_and_canonicalize::index_html_middle ... ok
test html::test_html_parsing_malformed_script ... ok
test html::test_document_links ... FAILED
test tests::test_bad_dir ... ok
test tests::test_no_args ... ok
test tests::test_dead_link ... ok
test tests::test_dead_anchor ... ok
failures:
---- html::test_document_links stdout ----
thread 'html::test_document_links' panicked at 'assertion failed: (left == right)
Diff < left / right > :
[
Uses(
UsedLink {
href: Href(
"platforms/ruby",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"platforms/perl",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"platforms/rust",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"platforms/go",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"platforms/go",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"platforms/python/troubleshooting/ma",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"platforms/python/troubleshooting/[slug].js",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"platforms/python/troubleshooting/[schlug].js",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
<                "platforms/python/troubleshooting/mailto:foo@example.com",
<            ),
<            path: "public/platforms/python/troubleshooting/index.html",
<            paragraph: None,
<        },
<    ),
<    Uses(
<        UsedLink {
<            href: Href(
"platforms/python/troubleshooting/case",
<            ),
<            path: "public/platforms/python/troubleshooting/index.html",
<            paragraph: None,
<        },
<    ),
<    Uses(
<        UsedLink {
<            href: Href(
<                "platforms/python/troubleshooting/HTTP:/googel.com",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"platforms/python/troubleshooting/whitespace",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"static/image.png",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"static/image300.png",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
Uses(
UsedLink {
href: Href(
"static/image600.png",
),
path: "public/platforms/python/troubleshooting/index.html",
paragraph: None,
},
),
]
', src/html/mod.rs:477:5
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
failures:
html::test_document_links
test result: FAILED. 19 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

Description added.

This PR introduces a regression, causing mailto:, tel:, fax: etc to be considered broken.

@mwcz are you still interested in driving this PR?

@untitaker My need for it has diminished, but if you want to see it land I'm certainly willing to finish the final bits.

curious what changed for your situation, but if there's no need for it i'm inclined to not merge it

I had a need to do some link checking within my program so it could be acted upon during processing (ie, rewrite HTML to alert the user to a given link being broken and/or external).  I'm still using hyperlink to validate the final output, but the external links check is no longer needed at that point.
Feel free to ping me if anyone winds up wanting this feature, and I'll do my best to finish it.

@mwcz for what it's worth, after going back and forth with @matklad in #5 i think finishing this PR would be a decent step forwards enabling external links support for matklad's usecase.
I think I can do this on your PR right now:
hyperlink dump-external-links ./site-a/ | \
    rg '^(.*)https://site-b.com/' --replace '/' | \
    rg '^(.*)$' --replace '' > ./site-b/external-links.html
hyperlink ./site-b/

@matklad or @mwcz, do either one of you have the motivation to continue this PR and get it into a mergeable state? Otherwise I'll take a stab at it over the next weeks.

@untitaker I won't have the time to work on it, but the direction you and @matklad came up with looks good to me.


Proxy as string method

I think method .as_string should be added for proxy struct.
Method will return string in socks5://login:pass@ip:port format.

Also it will be good do methods for getting protocol/ip/port/maybe auth-credentials

What use case do you have in mind? Is it just for debugging purposes?

For example I check proxies and after writing it to output file.
Proxies are parsed/created once at the start.


All bugs

1

redirects should be site url itself not index.html.
2

whole section
3

should be at center properly

hey @Git21221 , please resolve these!


whats the command that i want to download the 30 seconds of video  thank you

whats the command that i want to download the 30 seconds of video  thank you

No such comand.

@asssdasad
I figure out how to download only the first 30 seconds of the video without
cutting in #19166.
Assuming you have ffmpeg installed. The following shell command should
download the first 30 seconds of the video and output it as out.mkv:
youtube-dl -o - -f best 'https://www.youtube.com/watch?v=BaW_jenozKc' | ffmpeg -i - -ss 0 -t 30 -c copy out.mkv


Please update the command step's to upgrade to Beta 11 version

Hi,
Please update the command step to upgrade to beta 11 version for this:
npm install --save --save-exact ionic-angular<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Because with the new Angular rc.5 if you don't specify the version of @angular/forms, npm get the latest version and is not compatible with Angular rc.4
Sorry for my English.
Regards

Hello @jorge13300 ! I just updated this in the changelog about 30 minutes ago with this commit https://github.com/driftyco/ionic/commit/82852fb353534210d6ecce7856c61d08e0449eb4. Thanks for using Ionic!


Add missing values to nether configuration

The recommended anti-xray config for the nether was missing the enabled and engine-mode values.

This shouldn't be needed. It's inherited from the global config.

Yeah, originally the idea here was to show or teach people that they can setup a default config for all worlds and then do adjustments per world (inheritance). In the most cases this makes sense, so I have decided to intentionally omit everything that is inherited correctly. This has the disadvantage that it is assumed that the overworld (default) config is present (or that people don't just blindly copy parts without adjusting).
If we decide to change this, I'd also add all other omitted settings (e.g. update-radius, use-permission, ...) to the nether world config as well to be consistent. This would be the most foolproof solution, however, I'm afraid that the above described learning effect is lost and another disadvantage is that the config gets more decentralized (e.g. if one wants to temporarily disable Anti-Xray one has to edit multiple files and there's a chance to miss something). The end world config should of course stay as it is because adding settings if it's disabled would just lead to confusion.

Okay, I just noticed that the instructions for The Overworld do specify that those values are for the paper-world-defaults.yml not the world-specific config.
For my server I need to configure anti-xray on a per-world basis. I searched Google for recommended anti-xray Paper config and clicked on this page from the docs. I copied The Overworld and The Nether configs into my world-specific config files and was confused why anti-xray wasn't working in The Nether, then realized that it was not enabled.
This might help people in similar situations, but up to you if you think this is helpful or not.

Please note the additional note in the first review comment:

Same for engine-mode: 2 below. Sorry, I can't do it via suggestion because it's not part of the diff.

Change for engine-mode: 2 was included in the commit

I can't see it. To be clear: lava-obscures: false is missing for engine-mode: 2 nether settings.


google.protobuf.message.DecodeError: Error parsing message when using hlo_pb2.HloModeuleProto

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
2.8
Custom Code
Yes
OS Platform and Distribution
ubuntu 16.04
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
A bug happened!
I use hlo_pb2.HloModuleProto.ParseFromString to get the hlo model, but 'google.protobuf.message.DecodeError: Error parsing message' will be reported.
In addition, I can use tf.compat.v1.GraphDef() to load the model.
May I ask if there is something wrong with the method I used
Standalone code to reproduce the issue
import tensorflow as tf

pb_file_path = os.getcwd()

with tf.compat.v1.Session(graph=tf.Graph()) as sess:
    x = tf.compat.v1.placeholder(tf.float32, name='x')
    y = tf.compat.v1.placeholder(tf.float32, name='y')
    b = tf.Variable(1.0, name='b')
    xy = tf.multiply(x, y)
    op = tf.add(xy, b, name='op_to_store')
    sess.run(tf.compat.v1.global_variables_initalizer())
    constant_graph = tf.compat.v1.graph_util.convert_variables_to_constants(sess, sess.graph_def, ['op_to_store'])
    with tf.io.gfile.GFile('./model/test.pb', 'wb') as f:
        f.write(constant_graph.SerializeToString())

from tensorflow.compiler.xla.service import hlo_pb2
with tf.io.gfile.GFile('./tmp.pb', 'rb') as f:
    module = hlo_pb2.HloModuleProto()
    module.ParseFromString(f.read())
    # module = tf.compat.v1.GraphDef()
    # module.ParseFromString(f.read())

Relevant log output
No response

there are a couple of bugs or typos in your code
In line 8, instead of tf.compat.v1.global_variables_initalizer(), it should be tf.compat.v1.global_variables_initializer() (notice the typo in 'initializer').

Ok, thanks for the warning

there are a couple of bugs or typos in your code
In line 8, instead of tf.compat.v1.global_variables_initalizer(), it should be tf.compat.v1.global_variables_initializer() (notice the typo in 'initializer').

Ok, thanks for the warning

@songh11, Apologies for the delay. I was able to replicate the issue in Colab using TF v2.12. Please find the gist here. Thank you!

@songh11, Apologies for the delay. I was able to replicate the issue in Colab using TF v2.12. Please find the gist here.
It seems like you're trying to load a TensorFlow SavedModel and parse the contents of the .pb file using the hlo_pb2.HloModuleProto class from the XLA module.
Please note that the hlo_pb2.HloModuleProto class is specifically designed for parsing HLO (High-Level Operator) module protos used in XLA, and it may not be compatible with the .pb file, which contains a serialized TensorFlow GraphDef or MetaGraphDef. Thank you!

I found jax.xla_computation().as_serialized_hlo_module_proto() to solve this problem. So this is a problom when I serialize my .pb file.
Thank you for your reply


Making publish a separate step

Issue link

n/a
Types of changes

Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)

@marcelomorgado FYI the updated version code from app.json doesn't make it into the Android build unless you publish first. That was surprising. So maybe we want to revert this, at least on Android. The same may be true for iOS.

@marcelomorgado FYI the updated version code from app.json doesn't make it into the Android build unless you publish first. That was surprising. So maybe we want to revert this, at least on Android. The same may be true for iOS.

OK, I've found these links that maybe help to understand why it's happening:
https://github.com/expo/expo/issues/63
https://forums.expo.io/t/how-to-build-without-publishing/14462

So if I understand the forum post correctly, the suggestion is to publish first to a non-prod release channel to get the build to increment the version code in the .apk, and then follow these instructions to move that published js bundle to a different release channel.
https://docs.expo.io/versions/v30.0.0/distribution/advanced-release-channels/#promoting-a-release-to-a-new-channel

If that's the recommendation, I should probably remove the --no-publish flag from the scripts


help Passing hparams via config file

Hi,
I would like to use configuration file with t2t-trainer command. How can I do it?
Best regards,
Andrey

We do not currently support doing that, but if you'd like to hook it up yourself, I'd recommend making your own t2t_trainer, reading in the config file, creating an HParams object, dynamically registering it, and then set FLAGS.hparams_set to the dynamically created name, then call t2t_trainer.main.


support for djangocms-text

removed djangocms-text-ckeditor
added djangocms-text
updated README and added some tweaks

I created https://github.com/django-cms/djangocms-text/issues/15 to fix the failing docker test.


Ignore deprecated methods when validating delegates

With the previous PR, you had to implement both the deprecated and the new methods in order for the validation to pass, which was obviously incorrect.
With this, it passes if a deprecated method is not implemented.
Though, I'm pretty sure that an additional check is needed here:
https://github.com/orta/gh_inspector/pull/20/files#diff-c65f1a97c8c4cb2204bde822b32bc755R37

@orta, Let me know if this is the correct way to fix it.

Shipped as 1.1.1


Attempting to register an account with an existing email address behaves unexpectedly

Not sure if this is an issue with our app setup (which looks to be pretty default, according to the Getting Started docs) or with the lib itself.
Note: This doesn't happen with validations like length of password - they are rendered on the form as I would expect.
Steps to replicate:

Have an existing user in the DB with a known email address
Attempt to register a new account with the same email address

What I would expect to see:

Some form of error rendered on the form (eg. GitHub has a "the email address is invalid or taken" message)

What actually happens:

The failure action in the configured auth controller is called, which renders an "Authentication Failure" message. :(

The problem is that this has security implications and can allow probing "does this user exist?"
Golden rule is to never provide a means to determine or differentiate between if a user exists but their password is wrong, vs an unknown user.

I get that for login, but this is for registration.

I think we should handle this, but we may need to make it opt-in behavior. The basic issue is that it's implemented with live view under the hood so adding rate limiting and other mitigation strategies might be harder to hook up (but not impossible). Would be worth seeing what phx.gen.auth does for this.

I get that for login, but this is for registration.

it doesn't matter if it's for registration or sign up - it still allows an enumeration attack.
You are free to implement the failure/3 in such a way that detects this situation.  Something like this would likely work fine:
def failure(conn, {:password, :register}, changeset) when is_struct(changeset, Ash.Changeset) and changeset.valid? != true do
  # check for user already exists error on changeset
  conn
  |> put_flash(:error, "A user with that email address already exists")
  |> redirect(to: ~p"/my-register-route")
end

def failure(conn, _, _) do
  # default failure handler.
end

So, having just added ash_authentication_phoenix to a new app, and trying to sign up with an email address I had used already and being greeted with this page:

I think we need to rethink the whole pattern of rendering an Authentication Failure page. I can't think of a single case where that would be the desired behavior. I think we need to build in a flash message + redirect into the default setup at a minimum. The ideal behavior I think would be a special kind of flash message that we render as though it was a form error (something we'd discussed in the past). Then to users it looks effectively the same. Although I do recall there was one major UX issue that caused us not to pursue that route which was the fact that the whole page blinked....
hold up. I think we can actually do the sign in token thing for sign ups, where we do the registration in the live view and issue a short lived sign in token. Then we won't have this issue at all.

I would also put forward that just by getting a special page or an error for typing in certain emails that they can already enumerate the thing used to sign in. I'd go as far as to say that it is practically unavoidable. Likely the only thing that could solve for this in some way would be ip-based rate limiting and other bot/scripting related protections.

With sign_in_tokens_enabled? set, the newest version now show this information on submit. Ultimately, it was always possible to enumerate emails/usernames using the sign in view, you'd just see which emails gave you back an error. To solve for this, you'd want to use some kind of rate limiting at the plug/conn level likely, or using an on_mount hook potentially if you wanted to do it at the LV level. You could also set up your own view and add a captcha or something similar.

User enumeration is really really to prevent.  Even doing the "forgot my password" can have different timing depending on if a user really was found and an email was sent, vs one that wasn't found with no email sent.  Its not that easy to make all cases indistinguishable with a sophisticated attacker, the best you can do is to not make it trivially obvious.
Another aspect to be careful with is password failures, when I looked at Ash Authentication there was no last failed, failure count, back-off or lock after N failures, which could permit password enumeration.

Yep! Would be open to building those features in. With that said, it should be doable in user-land code via extending the actions with hooks.

My view is that Ash should provide a set of core authentication support features but not necessarily a particular higher layer authentication solution.  An approach that is agnostic to but can be easily leveraged by various higher layer authentication solutions like Pow, Ueberauth, or phx.gen.auth (and having extensions for all of these is fine IMO).
So think just the resource parts that support token auth, account verification,  TOTP, external OIDC/OAUTH, WebAuthn, account auditing, credential reset/update, account back-off/lock policies.
I will look at contributing some code to Ash in the hope that some things may be useful/re-usable when I get over the current hump.


addressing modes

Hi,
I'm not 100% sure but regarding https://github.com/outofmbufs/python-pdp11-emulator/blob/main/machine.py#L454
At line 463 for registers that are not SP/PC, the autoincrement is set to word_size. But I think that should always be 2 unless I mis-interpret https://bitsavers.org/pdf/dec/pdp11/1170/PDP-11_70_Handbook_1977-78.pdf page 33, 3-9.
"Register is first used as a pointer to a word containing the address of the operand, then incremented (always by 2; even for byte instructions)". Same for mode 5 (which currently only for SP decrements by 2).

You are, of course, correct, as verified by common sense, the book, and SIMH. Kind of a miracle I got this far with that bug in there. Working on fixing it (with corresponding tests).


Camera2D get_camera_screen_center() reports bad position with rotating camera

Godot version:
Godot Engine v3.2.3.stable.official
OS/device including version:
Arch Linux 5.9.11-arch2-1 #1 SMP PREEMPT Sat, 28 Nov 2020 02:07:22 +0000 x86_64 GNU/Linux
OpenGL ES 3.0 Renderer: Mesa Intel(R) UHD Graphics 620 (KBL GT2)
Issue description:
What happened: Camera2D method get_camera_screen_center() does not return (0, 0) when the camera is being rotated with self.rotate(0.1*delta), Offset=(0, 0), Current=On, Rotating=On, and Anchor Mode = Drag Center.
Note: With Anchor Mode = Fixed TopLeft I also see unexpected behavior where the position reported by get_camera_screen_center() remains unchanged even though the camera view is rotating about the top left corner.
What I expected: get_camera_screen_center() should continue to return (0, 0) at any rotation angle as long as Offset=(0, 0) and the Anchor Mode = Drag Center.
Note: With Anchor Mode = Fixed TopLeft the position reported by get_camera_screen_center() should follow a circular path with center at the top left corner of the camera and radius equal to half the diagonal length of the camera window size.
https://docs.godotengine.org/en/stable/classes/class_camera2d.html#class-camera2d-method-get-camera-screen-center
Steps to reproduce:

Create a new 2d scene.
Create a Camera2D as a child node of the scene root.
Create a Label as a child node of the scene root. (The label is simply for displaying the result of get_camera_screen_center().)
Set the following Camera2D settings:
Anchor Mode: Drag Center
Rotating: On
Current: On
Attach the following script to the Camera2D node.

extends Camera2D

func _ready():
	set_process(true)

func _process(delta):
	self.rotate(0.1*delta)
	$"../Label".text = str(self.get_camera_screen_center())

Run.
You should see the label in the center of the screen rotating while displaying the output of get_camera_screen_center().

Minimal reproduction project:
bug_cam_screen_center.zip

With the following project settings: Window Width/Height = (800, 600), Stretch Mode = viewport, Stretch Aspect = keep. I observed the following approximate results from get_camera_screen_center() when the camera is rotated at the following angles at camera position or offset (0, 0):

0: (0, 0)
90: (700, -100)
180: (800, 600)
270: (100,700)
360: (0, 0)
At camera position or offset (50, 0):
0: (50, 0)
90: (750, -100)
180: (850, 600)
270: (150,700)
360: (50, 0)
At camera position or offset (0, 50):
0: (0, 50)
90: (700, -50)
180: (800, 650)
270: (100,750)
360: (0, 50)

Note: Screen center values are approximate and are rounded to remove floating point math artifacts, e.g. (50.000061, -0.000061).

For anyone else who has run into this issue, I found a workaround:
var inv_canv_tfm: Transform2D = self.get_canvas_transform().affine_inverse()
var half_screen: Transform2D = Transform2D().translated(get_viewport_rect().size / 2)
var actual_screen_center_pos: Vector2 = inv_canv_tfm * half_screen * Vector2(0, 0)

actual_screen_center_pos will be accurate even with camera smoothing enabled, zoom, and rotation. (Note: Did not test with camera offset)

@DragonAxe I tried to adapt your code to my game. But I can currently not multiply a vector with a transform (at least in my C# project). I don't actually understand the third line. Could you explain it so I can adapt?

@DragonAxe I tried to adapt your code to my game. But I can currently not multiply a vector with a transform (at least in my C# project). I don't actually understand the third line. Could you explain it so I can adapt?

Let me see if I can explain, it's been a while since I've looked at this.
Basically what I'm doing here is matrix-vector multiplication.
One thing to note is that GDscript has some special handling when using * with vectors and matrices.
I haven't done much with C#, but perhaps the Transform2D class has a .Multiply(<vector>) method you could use, or maybe .xform() and .xform_inv() methods are what you need.
(https://docs.godotengine.org/en/3.2/tutorials/math/matrices_and_transforms.html#converting-positions-between-transforms)
Here is a breakdown of my code above:
self.get_canvas_transform()
I start by getting a transformation matrix that can convert a vector from world space into screen space.
self.get_canvas_transform().affine_inverse()
Then I make it go in the opposite direction by inverting the matrix. (screen space to world space)
Transform2D().translated(get_viewport_rect().size / 2)
To make the next operation a simple matrix multiplication, I create another transformation matrix which, when multiplied with a vector, will move that vector to the center of the screen.
half_screen * Vector2(0, 0)
Then, I take a position at (0,0) then I move it (translate it) into the center of the screen. This gives us a vector that exists in screen space.
inv_canv_tfm *
Then I can use my handy screen space to world space transformation matrix to move the center screen position to the position of the camera.
Hope this helps!

Let me see if I can explain, it's been a while since I've looked at this.
Basically what I'm doing here is matrix-vector multiplication.
One thing to note is that GDscript has some special handling when using * with vectors and matrices.
I haven't done much with C#, but perhaps the Transform2D class has a .Multiply(<vector>) method you could use, or maybe .xform() and .xform_inv() methods are what you need.
(https://docs.godotengine.org/en/3.2/tutorials/math/matrices_and_transforms.html#converting-positions-between-transforms)
Here is a breakdown of my code above:
self.get_canvas_transform()
I start by getting a transformation matrix that can convert a vector from world space into screen space.
self.get_canvas_transform().affine_inverse()
Then I make it go in the opposite direction by inverting the matrix. (screen space to world space)
Transform2D().translated(get_viewport_rect().size / 2)
To make the next operation a simple matrix multiplication, I create another transformation matrix which, when multiplied with a vector, will move that vector to the center of the screen.
half_screen * Vector2(0, 0)
Then, I take a position at (0,0) then I move it (translate it) into the center of the screen. This gives us a vector that exists in screen space.
inv_canv_tfm *
Then I can use my handy screen space to world space transformation matrix to move the center screen position to the position of the camera.
Hope this helps!

Thank you for the explaination. I think I now understand it. I adapted the code to C#:
Transform2D inverseCanvasTransform = this.GetCanvasTransform().AffineInverse();
Transform2D halfScreenTransform = (new Transform2D()).Translated(this.GetViewportRect().Size * 0.5f);
Vector2 actualScreenCenterPosition = inverseCanvasTransform.Xform(halfScreenTransform.Xform(Vector2.Zero));

I tested if this works with my implemented camera shake. But I guess there is a problem left with the offset (as you mentioned already), because the position seems to be off when my camera shakes.
But maybe I can find a way to fix this. :)

Thank you for the explaination. I think I now understand it. I adapted the code to C#:
Transform2D inverseCanvasTransform = this.GetCanvasTransform().AffineInverse();
Transform2D halfScreenTransform = (new Transform2D()).Translated(this.GetViewportRect().Size * 0.5f);
Vector2 actualScreenCenterPosition = inverseCanvasTransform.Xform(halfScreenTransform.Xform(Vector2.Zero));

I tested if this works with my implemented camera shake. But I guess there is a problem left with the offset (as you mentioned already), because the position seems to be off when my camera shakes.
But maybe I can find a way to fix this. :)

I had accidentally made a duplicate of this. Reposting as a comment here in case my repro might be useful.
Godot version
v4.2.beta.custom_build [b1371806a], v4.1.2.stable
System information
Godot v4.2.beta (b1371806a) - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce GTX 1080 Ti (NVIDIA; <IP_ADDRESS>23) - AMD Ryzen Threadripper 1950X 16-Core Processor (32 Threads)
Issue description
The Vector2 returned by Camera2D::get_screen_center_position() is (incorrectly) affected by the camera's rotation. Rotating the camera will cause get_screen_center_position to return different values, despite the actual center being in the same place.
Steps to reproduce

Rotate a camera to non-identity.
get_screen_center_position returns incorrect values.

Minimal reproduction project
In this example project there are two scenes with similar setups.
One Sprite, colored red, follows the Camera2D's get_screen_center_position()
The other Sprite follows the Camera2D's get_target_position() for comparison
The Camera2D being followed is rotated by delta in _process
one_cam.tscn is from the perspective of the rotating camera.
two_cams..tscn is from the perspective of a second, zoomed out camera.
ReproProject.zip

I've looked at https://github.com/godotengine/godot/pull/63773 and it will unfortunately NOT close this issue, though I don't believe it was intended to. I agree that if that gets merged, it will at least make it easier to fix this issue.

I adapted the code to C#:
Transform2D inverseCanvasTransform = this.GetCanvasTransform().AffineInverse();
Transform2D halfScreenTransform = (new Transform2D()).Translated(this.GetViewportRect().Size * 0.5f);
Vector2 actualScreenCenterPosition = inverseCanvasTransform.Xform(halfScreenTransform.Xform(Vector2.Zero));

In C# default constructor zeroes the structs. In GDScript Transform2D() == Transform2D.IDENTITY but in C# new Transform2D() != Transform2D.Identity. So replacing new Transform2D() with Transform2D.Identity should fix that snippet.
Anyway, pure translation transform can be omitted by straight up adding the translation to the vector, same effect:
Transform2D inverseCanvasTransform = this.GetCanvasTransform().AffineInverse();
Vector2 actualScreenCenterPosition = inverseCanvasTransform.Xform(this.GetViewportRect().Size * 0.5f);


HPC-buildtest organization name change

We should change the name of the buildtest organization currently located at https://github.com/HPC-buildtest
The namespace buildtest and buildtests is taken https://github.com/buildtest https://github.com/buildtests so we must think of a new name.
Preferably, we should have a name that matches these requirements

Short org name (max 10chars) currently buildtest is 9 chars
Name should be unique so that there is no conflict between another open source project
The name should be available on pypi https://pypi.org/ so we could distribute package
Single word only, no special characters or dashes allowed (build-test)

Let's share few ideas on names here and proceed from here.

Hmm, so I was originally thinking these are for the organization name (and not the package, which is already buildtest, no?) So here are a few suggestions for the organization

buildorg
buildoc  (akin to "build doctor" but also alludes to documentation

But if you want the org name to == the project (and repository name) and the pypi name this is more challenging. Are you suggesting that you are open to changing the name of the package entirely? That would give us a lot more options:

https://github.com/buildshares

One of the fundamental ideas for the project is the idea of sharing builds. The buildshare project (pip install buildshare) would be under the buildshares org on GitHub (buildshare is taken). E.g., this repo would be https://github.com/buildshares/buildshare (or actually it could still be https://github.com/buildshares/buildtest)
https://github.com/buildsteps
I sort of like this one - the idea of many buildsteps coming together into a full build is kind of cool. Then you could have https://github.com/buildsteps/buildtest still (are you not able to get buildtest on pypi?)
https://github.com/buildspec
Since we have these build spec things, you could also just call it that :) The library is based on creating, sharing, running, and testing build specs, so it's not so crazy. It would nicely tie the namespace together I think too - buildspec would be common knowledge for the spec files and the software.
https://github.com/buildspec
I can think of others too... let me know!

My 0.02 is that I like the last (buildspec) the most. It's available as an org, and a package on pypi. https://pypi.org/project/buildspec/

So my thoughts are to change buildtest-framework to buildtest. Id prefer not to change the name of the project this may imply change to the module names and a complete rewrite of all the docs and some or if not most GitHub integration links.
I don't think there is an issue with getting buildtest namespace in pypi https://pypi.org/search/?q=buildtest  so we should not have an issue as soon as we do a release, we should also distribute on pypi.
So I think we can name the org whatever we want and not worry about few of the requirements especially changing the project to match org. I also send two of the guys email again to see if they respond back. I tried googling these guys they don't exist on this planet :) I really wish they can respond back and delete the buildtest project so we can take the namespace.
I like Buildspec for what it represents a YAML file, so I'd not want to confuse that with an org.

If you want to wait and see if we get response from these guys and maybe we can take the buildtest namespace maybe if you give a 2 weeks.
I guess a question I have is will we refer to the project by the org or by the name buildtest. Keep in mind two different names would cause a bit of confusion and given the history I have with previous talks and publication it be best if name is still buildtest. if it's last resort I am leaning towards we can call it buildtesters. If the namespace buildtest is freed up we could think about taking this namespace.

It’s customary to name by the project, not the org. You see a lot of projects under different (and even changing) org names.

In that case, i'd rather be safe and we can change buildtest-framework --> buildtest for this repo. Initially i had a repo buildtest which served only the docs but then i merge the docs into the framework.
If you agree this change could be done immediately, and then we would need to change all the update all the links, hopefully the url-checker will come in handy now.
As per org, the one that comes to mind is buildtesters, it contains the word buildtest, but also implies that users a.k.a testers who use buildtest are called buildtesters.

+1, I would rename the repo to buildtest right away, and try to claim the namespace on pypi (you can add me, I'm vsochat). We can manage the org name after - buildtesters I guess would work but it feels long.

You could do a take on "metoo" and call it "buildtoo" :)

Like buildtool but with a silent l?

I changed this repo name, to buildtest, The names sound nice buildtool i think the org name should have some variation of buildtest so that we have a high page rank. Doing a quick search on google now with buildtest we have 6 top-pages belonging to this page.
Here are few suggestions, can you please sort names based on your preference. I believe all these names are available.

buildtesters
buildntest ( sound like 'building' 'test')
buildtesters
buildstest - i wouldn't bother pronounce the 's' but to get the namespace, trying saying this 10x really fast :)
buildztest

I think buildstest would be confusing because people would confuse the org name with the package name. buildtesters is clear, but it's longer than the others. (you put it twice in the list, are you trying to bias me? lol). My favorite is buildntest because to me it sounds like build and test and that's exactly what is being done.
As for my favorites? I don't think any of them are super great, but in that they are all better than HPC-buildtest, it's an improvement. I don't think the github organization name determines page rank, the page rank algorithm has to do with linking and clicks. The organization name associated is irrelevant.

I also really like buildntest let's go with this. Yes it's much better than what we have right now 😁.

Want to let it sit a bit (the org name) before making global changes? To make sure we like it (and in case we think of something better?) It's a big (permanent) change after the fact so we should be sure. I'm not sure I like it. We could be more creative too, e.g.,

https://github.com/buildforge
https://github.com/buildmod
https://github.com/buildmake
https://github.com/buildsteps

I like most of these better than buildntest, because of the length factor.

+1 for buildsteps, buildforge. So just to be clear, the logo #282 will be for buildtest and not for org name since we can't get https://github/com/buildtest. The ones you suggested can have slightly different meaning and we could go creative with logos but if we decide to have the name buildtest in the logo then it can cause some confusion between org name and the project. Also keep in mind, we also have https://github.com/buildntest/lmodule which belongs to buildtest for now.
It won't be an issue if we picked an org as close to buildtest. I think the two that i like are

https://github.com/buildtesters
https://github.com/buildntest

Yep, clear on the logo, I'm just talking about the name for the org.
You don't like any of the other suggestions I made? I can keep thinking...

https://github.com/buildlib
https://github.com/building (is this one really available, or just protected?)
https://github.com/testguild
https://github.com/buildest (a descriptor like "biggest" but to describe building, "buildest") also is similar to buildtest (but shorter).
https://github.com/allbuild

I think I might like buildtesters better, but I don't love it. I guess after setting it to buildntest, it looks weird.

More ideas...

https://github.com/buildbee (could be really cute org logo)
https://github.com/testit
https://github.com/collatest (collaborative test)
https://github.com/testivity
https://github.com/buildix (akin to unix, linux, etc.)
https://github.com/buildology
https://github.com/testology
https://github.com/buildzilla
https://github.com/buildalus
https://github.com/buildvue

Based on all i saw i like

https://github.com/buildsteps
https://github.com/buildoc
https://github.com/buildat (this sounds cools too)
https://github.com/buildest (this is interesting, but i guess it doesn't matter how we pronounce it.)
https://github.com/buildsuite this is good too. I used the word testsuite a while back for some features in buildtest

Here is one other thought what about

https://github.com/buildtestcom - this represents buildtest + "community" which is a collection of buildtest repos, and it may include a collection of buildtest repos for each HPC site. Right now i have buildtest-stampede2 in this org for time being but it doesn't seem like it's the right place. I do want each site to have their own repo but a central location where we can find all the tests.

The name also applies that it is a buildtest community.

The last one sounds WAY too much like zombocom, which would just make it a joke. And I wouldn't think "community" I would think ".com" which makes me think of a dated point in time when .com's were all the rage :)
If we choose based on length then buildat and buildoc and buildest would be the top three? But the other ones are good too - I like all of them better than buildntest, which I think looks weird because d and n don't really appear next to one another often in the English language. if you want to think more (or come up with more ideas around community, group, lab, etc.) then I can give feedback on another set. I definitely gave my fair share of ideas for today so I think I'm spent!

Just kidding a few more... these are based on community but I don’t like them as much :/
https://github.com/buildgrp
https://github.com/buildbunch
https://github.com/buildfam
https://github.com/buildfact
https://github.com/buildlot
https://github.com/buildsec
https://github.com/buildpeople
https://github.com/buildfolks
https://github.com/buildclan
buildcommunity is taken.

https://github.com/buildmart
https://github.com/testmart
https://github.com/buildsh (You could try for build.sh)
https://github.com/buildcmd
https://github.com/testrope
https://github.com/buildcollective
https://github.com/buildcoop
https://github.com/buildville

Thanks for the suggestion, i dont like much of the suggestions based on the community so i am in agreement with you.
I guess we can ditch buildtestcom it may seem weird, i figured it may also sound like the .com era and i also thought about this.
The ones that stuck out to me that were my favorite are the following two

https://github.com/buildsteps -
Pros:

Character length 10 chars, it's same char count as buildntest but name is grammatically correct
Logo: i can see a good logo with this using a series of stairs or steps. A simple design could be a 10 steps with a letter per step that spells out buildtest
Cons:

Doesn't have the name buildtest in name, and it may not be clear if buildsteps means anything in relation to buildtest

https://github.com/buildtesters -
Pros:

Includes the name buildtest, also implies users are called buildtesters
Shortest and most meaningful namespace that includes buildtest in the name
Cons:
Char length 12 chars vs 10 chars (buildntest)

I agree, and I like the two that you've narrowed it down to. We can actually edit the html on the page to "preview" how it would be:

and

I think I like buildsteps better. It implies modular, and also has a nice visual for a logo, and usually something with "steps" make me think "easy" or "clear." I think we could call the org buildsteps and still have a community of "buildtesters."

You didn't like testit? it's very short.

You didn't like testit? it's very short.

Not really. Sorry

I agree, and I like the two that you've narrowed it down to. We can actually edit the html on the page to "preview" how it would be:

and

I think I like buildsteps better. It implies modular, and also has a nice visual for a logo, and usually something with "steps" make me think "easy" or "clear." I think we could call the org buildsteps and still have a community of "buildtesters."

This looks nice, it's bit tough decision, i am kinda leaning more towards buildtesters but i like both names. So here were my thoughts based on the two names
buildtester

I can see buildtesters term to refer to buildtest users  and not just be any arbitrary name for sake of getting a namespace.
I could see a documentation where we can have buildtesters grouped by sites so that we have a point of contact for any buildtester who wants to contact someone to use a test from one of the test repositories.
We are free to make logo whatever we want, but the name buildsteps seem to be more catchy when coming with a logo.
We could also refer to each buildtest test repo (buildtest-stampede2) as a buildtesters org. I am not sure what the best way to get all buildtest test repo in one org while giving them anyone privilege to create a repo but not have admin access to other repos. It would be nice if all buildtest test repos are in one central location at-least this builds a community of test repos. Another solution would be to create an empty repo and have everyone fork and use that to start as basis for the test repo. We won't expect contribution back but atleast all user can navigate to any fork to access other folks test. Ultimately, buildtest was meant for community sharing of tests so i could see this being useful if buildtesters was used as an org to host the test repos independent of this current org. I am not sure the best route.
Lastly i had this silly idea of having a leaderboard of all tests that buildtesters could vote. This was a bit tricky but i had  thought about this idea described in wiki but i dont know how useful it would be https://github.com/buildntest/buildtest/wiki/Managing-a-Test-Repository#voting-on-test

Buildsteps

I can see a nice logo since the name is visual with steps
I see a good motto maybe Build a Test one buildstep at a time
Name is shorter as pose to buildtesters
Currently, i dont see how we could refer to buildsteps in context of buildtest, as pose to buildtesters i can see some context w.r.t documentation

Sounds like you are decided :)

Well not really sure about point 4. I didn't like buildtesters in the beginning i was think i would be copying easybuilders https://github.com/easybuilders/ so i didnt want to do that. Anyhow, if we have a solution to point 4 not sure if we need a separate org for hosting tests since I am not sure where to place buildtest-stampede2. Soon i will create a repo when i start testing Cori at LBNL.

I think the "copy" actually is a positive thing, it copies something that has worked, and you might only worry if the easybuild team would have issue (I really doubt it!). I would try to just host them in the same org, having a second is excessive.

Since we are out of luck on http://github.com/buildtest and user has not replied despite several email attempts i'd prefer buildtesters over buildsteps so that the name has some relevance. I wish there would be more input from users but atm the project is relatively new so slack community is pretty much dead until we get new release.
We would need some logo #282  the one that came to mind was one was the word buildsteps with a stairs spelling out "buildtest". I think we need more logo designs. Maybe a catchy motto?
Here are some thoughts

Be a Buildtester, use buildtest
build, test, be a Buildtester
Test your HPC with a Buildtester
Hire a Buildtester to test your HPC! <-- this is my favorite

lol I don't think a "motto" is necessary at this point. Maybe when there is a larger community you could open this up and have a vote. For now, just focus on the org name.

Makes sense to me.

Okay i will change the org name to buildtesters for now and in future we can try to get some input when there is a community. I still wished we have http://github.com/buildtest but it wasn't meant to be.


PR to change zero_trace on graph

PR to change name of zero_trace to Reference and showlegend True in all graphs to be possible to filter out this trace.
Reg_pred_and_actual_in_time_widget.py zero_trace has showlegend True but by default it is not selected

Hey!
Unfortunately,  the library version has gone far ahead, and we do not accept the pull request.
Although, the idea of this change is good: we would like to leave the green line on the chart by default but allow turning it off.
I do apologize we lost this pull request. We will do our best to avoid such situations in the future and no longer lose useful changes.


Improvements to sonar action

Simplified styling, copy, and removed redundant cd prefix command
Added verbose parameter to allow users to completely hide scanner output
Added additional tests

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[ ] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context
Recently, I've implemented SonarQube in a number of projects. A limitation of the current action does not allow users to output control.  While the sonar-scanner tool does support verbosity parameters, these still do not fully silent the log output.  In very large/complex code bases being scanned, the logs can get massive and difficult to visually grep through.
Description
This pull request is providing users the ability to control the output by adding the verbose: param.  This controls the output of the sh task in the action.
While working on this, I decided to leave command printing to always hidden as the original owner did.  There will always be sensitive information printed and I didn't want to impact existing users with the unexpected change.
Since I was already expanding the existing feature set of the sonar action, I took the time to remove some redundancy, simplified copy, and simplified method names.   I'm not sure why the original author was changing directories to the project's root when actions default to that location.  I assume it was created during an earlier era of fastlane where directory behavior was less understood.  Also added an extra test.
Performed testing by running sonar-scanner against the fastlane and a private repository to ensure the action behaves the way I expected. Also ran rspec + rubocop as required by the the PR template.
Thanks for all y'alls hard work!  I've been using fastlane at a pretty large scale for almost 2 years now and I would argue it saved our product/company from failure during a rapid growth phase.  Beyond the technical benefits, fastlane has empowered to our dev/qa/product staff to keep our velocity when operating through a high risk era of our products.  I am proud to finally be contributing to the project!

I signed it!

huh?

Sorry, somehow got a commit in there that's from another account.  Switched my keys since it's not tied to that but still got in there I guess.   Might be git config related. I'll reopen when I sort it out.

Ah ok ;)


API JSON response should not show sending at time when data will not be sent to a destination

API JSON response should not show sending at time when data will not be sent to a destination.  While you can have an itemCount of 0 when all items are filtered for a destination, you can still get an itemCount > 0 for destinations that are not configured correctly and hence will never receive any data.  For example, as of 3/16/2022, md-doh for our local is setup with NO transport and hence nothing will truly be sent.  To duplicate this issue you can use the prime-router\examples\submission\simple_report_example.csv file and sent it as simple_report.  The result will be like
"organization_id": "md-doh",
            "service": "elr",
            "filteredReportRows": [],
            "sending_at": "2022-03-15T18:05:00.000Z",
            "itemCount": 2,
            "sentReports": [],
            "downloadedReports": [],
            "organization": "Maryland"

However, nothing is sent because the receiver does not have a transport.  Note this could be an issue in some other part of the code besides the JSON response, so make sure that the logic is correct in the proper place in code.
Design considerations:
The fix could be something on the JSON response, or somewhere else.  Is the answer a configuration check, but would this limit us?
Acceptance criteria:

The submissions and reports API shows the correct status of no items to be sent for a destination that is not configured to receive any data.

@carlosfelix2 Is this still something we need to address?

I think this condition should be rare in Production, just because we rarely have Receivers with 'timing' but no 'transport'.    The one "normal" situation when this will happen is for a receiver that is only using manual download via the web UI - they will having a 'timing' but no 'transport'.
I'm guessing there aren't many such cases in Production.


feat: Add Rigidbody2D extension

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


License file doesn't have your name/company or year

Your license file does not actually list your name (or company) or the year. You should probably fix that so that my company (and others) can properly (and safely) fork your code.

Fixed in be00f99


Fix issue #3: Correctly mock handle_and_remove in compare_and_replace…

… Tests
Description
This PR addresses the issue of properly mocking the handle_and_remove function in the compare_and_replace tests to ensure correct test behavior without actually deleting files. This change ensures that the compare_and_replace function behaves as expected in the tests by using a mock for handle_and_remove, resolving the issue where the real function was being called instead of the mock.

Fixes #3

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Tests update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] I have maintained a clean commit history by using the necessary Git commands
[x] I have checked that my code does not cause any merge conflicts

@Kota-Karthik @techy4shri please review PR, and please add labels gssoc-ext, level, hactoberfest-accepted

Looks good to me! @Kota-Karthik please review.

@techy4shri Thankyou so much

@techy4shri @Kota-Karthik please merge this PR, as soon as possible


Can COUNT GROUP BY return a array like select?

It seems like I can not do this:
SELECT COUNT(*), date FROM order WHERE customer = 1 GROUP BY date
Is there any plan to do this? Same for max, avg, etc.

just saw it duplicate with #635


Support Unity Barracuda ONNX operators.

Goal:
To be able to support in migraphx models that are created via Barracuda under Unity. Barracuda is Unity's inference engine (onnx compatible), important in the windows (gaming) ecosystem.
The list of desired operators are in:
<EMAIL_ADDRESS>Let's go over them and identify gaps.

Operators we do not currently have support for:

DepthToSpace
Multinomial
NonMaxSuppression
RandomNormal
RandomNormalLike
RandomUniform
RandomUniformLike
SpaceToDepth
TopK

Based on the list of gaps, here is a prioritization (feedback from client BU). A lower number means increased priority. We have a ticket for multinomial already. The random functions are also important, and we should probably address them together. Also TopK.   DepthToSpace,SpaceToDepth and nonMaxSuppression can be addressed in the future.
•	DepthToSpace (4)
•	Multinomial (1)
•	NonMaxSuppression (5)
•	RandomNormal (3)
•	RandomNormalLike (3)
•	RandomUniform (3)
•	RandomUniformLike (3)
•	SpaceToDepth (4)
•	TopK (2)

Add to release 1.3, particularly for the Random* operations.

This issue will move to 1.4.  A new issue should be opened to split the operations in to manageable pieces

SpaceToDepth is an "easier" one to add the "first label"

The prioritized list of operators with issues attached to allow work to be completed over time...
• Multinomial (1) #821
• DepthToSpace (4)  #905 #904
• NonMaxSuppression (5)  #866
• RandomNormal (3) #907
• RandomNormalLike (3) #907
• RandomUniform (3) #907
• RandomUniformLike (3) #907
• SpaceToDepth (4)
• TopK (2) #877


Use the user api token for the kernel requests

What does this PR do
This PR requests a token from JupyterHub for the temporary user that jupyterhub_client creates and uses that token to authenticate the kernel requests that follow.
Reasoning behind
When trying to use jupyterhub_client to create a JupyterHub service that would check if a hub is "healthy" (by creating a temporary user and executing a test notebook), I got a 403 from SingleUserNotebookApp (triggered by the ensure_kernel func):
[W 2020-12-16 13:51:41.928 SingleUserNotebookApp auth:870] Not allowing Hub service hub-health-check
[W 2020-12-16 13:51:41.930 SingleUserNotebookApp web:1786] 403 GET /user/service-hub-health-check-470d10bc-a124-4812-a3a9-0087f62acbca/api/kernelspecs (::ffff:<IP_ADDRESS>): service hub-health-check is not allowed.
[W 2020-12-16 13:51:41.930 SingleUserNotebookApp handlers:608] service hub-health-check is not allowed.
[W 2020-12-16 13:51:41.930 SingleUserNotebookApp log:181] 403 GET /user/service-hub-health-check-470d10bc-a124-4812-a3a9-0087f62acbca/api/kernelspecs (@::ffff:<IP_ADDRESS>) 56.98ms

The JupyterHub config that I used:
c.JupyterHub.services = [
   {
       "name": "hub-health-check",
       "admin": True,
       "api_token":  "super-secret",
       "command": ["jhubctl", "run", "--temporary-user", "--notebook", "simple.ipynb", "--hub", "http://<IP_ADDRESS>:8000"]
   }
]

From the looks of it, executing operations on a user's notebook by authenticated as the service that created that user is not allowed.
This PR solves this issue and should not interfere with the cases when there's no JupyterHub service and a user api token is used. Is there a better approach to solve this? What do you think?

Gentlest of pings to @costrouc :)

Gentlest of pings to @costrouc :)

Gentle ping again, @costrouc :)


update from other repo

The PR includes all the updates from the old pytket-extension repo

I was not sure why the PR is not merged yet and for that reason I have not included it here already. If we want it to be included I am happy to add that.


how to create views using managedobject

Can you give more details on what do you want to achieve?
P.S.: For questions better use slack as the github issues are more for new feature suggestiona and discussions and for reporting possible bugs.


Fixed a bug where clamp_uv was clamping one pixel short, stretching the last pixels.

Fixes https://github.com/godotengine/godot/issues/11417

If it is not used anymore, can you remove the half_texpixel variable?


Add MagicLeap 2 WebXR input profile

We need to map the device type coming from Wolvic to a list of supported WebXR input profiles. This way WebXR experiences can properly render the 3D model of the actual controllers.

Closing as there is no WebXR input profile for MagicLeap2 yet

Even if there is no profile for the ML2 I think having the MagicLeap One as fallback is better than nothing.


Changed behaviors: alt title parsing and user id parsing on profiles

Alternative titles
There are many pages where there are no alternative titles and it's a bit annoying that the logic throws an exception so I've changed  it to just produce an empty dict.
User profiles
It looks like MAL has changed the stuff a bit. The RSS link to the blog feed doesn't contain the user id anymore. Fortunately I could find it on the friend request button.
Fixes: #34 and #35

A better option may be to use the report button as it also contains an ID and doesn't require a login.

Will change it to that.


Text doesn't wrap when using customCardLayout

Heya,
I've got a standard board set up using a customCardLayout. I've used the custom card layout example in the readme, and also tried a basic
lots of text
 as the entire card layout, but the text never wrap. it always stays on 1 line.
The text wraps when you don't use a custom card layout, but when you do the text wont wrap.
thanks

When you opt for the custom card template, you take control of the styling for the card. But default, the card component has white-space: normal; set in the parent. Make sure you are not changing it or I would suggest applying that again to the card content.


Update identity for C# templates

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/2442
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/2442

View Changes | Compare Changes

Project: todo-csharp-sql-swa-func
Remote: azure-samples-staging
Branch: pr/2442
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/2442

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/2442
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql -b pr/2442

View Changes | Compare Changes


C# Fix smoketest csproj ProjectReference indent

Codecov Report

Merging #1653 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1653   +/-   ##
=========================================
  Coverage     86.04%   86.04%
  Complexity     4212     4212
=========================================
  Files           403      403
  Lines         16631    16631
  Branches       1735     1735
=========================================
  Hits          14310    14310
  Misses         1742     1742
  Partials        579      579

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41464d9...d73ea96. Read the comment docs.


[aggregator/ckey] implement a faster hash to reduce CPU and RAM usage

What does this PR do?
The highest CPU usage in the CPU profiles of highly loaded DogStatsD server was
the sorting of the metric tags in order to generate reproducible context keys.
This commit implements a hash which does not need to sort the tags to generate
reproducible context keys: it relies on XORing parts of the hash together instead
of building a bytes buffer containing all parts before hashing this whole buffer.
In order for this to work, a fast deduplication algorithm had to be written since
duplicated tags would make the hash computation wrong because of the XOR usage.
Using this implementation, the DogStatsD server will use less CPU to process more
metrics, and thus, it will use less RAM since it won't have to buffer as much as
before.
Micro-benchmarks of the KeyGenerator, 7.30.0-dev against this branch:
KeyGeneration/1-tags-8    23.6ns ± 1%  21.7ns ± 1%   -8.03%  (p=0.008 n=5+5)
KeyGeneration/2-tags-8    33.2ns ± 1%  29.9ns ± 1%  -10.04%  (p=0.008 n=5+5)
KeyGeneration/4-tags-8    55.2ns ± 0%  48.1ns ± 0%  -12.79%  (p=0.008 n=5+5)
KeyGeneration/8-tags-8     102ns ± 1%    91ns ± 0%  -10.79%  (p=0.016 n=5+4)
KeyGeneration/16-tags-8    203ns ± 2%   189ns ± 4%   -7.11%  (p=0.008 n=5+5)
KeyGeneration/32-tags-8    397ns ± 1%   314ns ± 2%  -20.75%  (p=0.008 n=5+5)
KeyGeneration/64-tags-8   2.61µs ± 1%  0.64µs ± 5%  -75.67%  (p=0.008 n=5+5)
KeyGeneration/128-tags-8  6.23µs ± 7%  1.24µs ± 2%  -80.12%  (p=0.008 n=5+5)

Here are different benchmarks results, where DogStatsD servers are hit with
300k metrics/second, with 10, 15 and 20 client tags added to the metrics
(the benchmarks are configured with "High cardinality" discovery tags, meaning
that the metrics end up with more than 50 tags approximately).
TODO(remy) update these graphs
PR results are in red/orange in those graphs, purple lines are 7.29.0:

Motivation
Improve performances of the DogStatsD server to lower its CPU and RAM usage.
Additional Notes
I've decided to continue to sort+unique the tags for Service Checks and (old) Events since their throughput isn't as high as DogStatsD samples.
AFAIK, mathematically, nothing has changed about the amount of collisions possible with this context key implementation, still, I've created a tool to naively / practically verify this in https://github.com/DataDog/datadog-agent/pull/8526 and this implementation has been through it multiple times successfully (i.e. tested with more than 50 millions different generated metrics).
This is a v2 of https://github.com/DataDog/datadog-agent/pull/8529 which had an unwanted behavior: sending tags unduplicated to the backend.
Describe how to test your changes
Validate that custom metrics received by DogStatsD are still available and display sane values.
Checklist

[x] A release note has been added or the changelog/no-changelog label has been applied.
[N/A] The need-change/operator and need-change/helm labels has been applied if applicable.
[N/A] The config template has been updated if applicable.

Is part of #8822


Registry delete API returns 200 for non-existing registry

Is this a request for help?:
No
Is this a BUG REPORT or a FEATURE REQUEST? (choose one):
BUG REPORT
Version of Anchore Engine and Anchore CLI if applicable:
anchore-cli --version
anchore-cli, version 0.3.4
What happened:
Deleting a non-existing or not-valid registry returns a 200 OK.
What did you expect to happen:
Deleting a non-existing or not-valid registry should return a 404 (Not Found).
What docker images are you using:
Engine DB Version: 0.0.9
Engine Code Version: 0.3.4
How to reproduce the issue:
anchore-cli --debug del non-existent-valid-registry
INFO:anchorecli.clients.apiexternal:As Account = None
DEBUG:urllib3.connectionpool:Starting new HTTP connection (1): localhost:8228
DEBUG:urllib3.connectionpool:http://localhost:8228 "GET / HTTP/1.1" 200 5
INFO:anchorecli.clients.apiexternal:As Account = None
DEBUG:anchorecli.clients.apiexternal:DELETE url=http://localhost:8228/registries/non-existent-valid-registry
DEBUG:urllib3.connectionpool:Starting new HTTP connection (1): localhost:8228
DEBUG:urllib3.connectionpool:http://localhost:8228 "DELETE /registries/non-existent-valid-registry HTTP/1.1" 200 5
DEBUG:anchorecli.cli.utils:fetched httpcode from response: 200
Success

@yathi-sysdig thanks, this seems like an inconsistency between idempotency in different routes

@yathi-sysdig @zhill - i've done a review of the DELETE behavior across the API - the earliest API was by design always returning 200 as long as the resource being DELETEd was 'not present in the system state after the operation finished' - there is some controversy as to whether 'idempotent' in an API such as anchore's extends to the response or is limited to the system state itself.  Over time, newer API calls have adopted a different approach, returning 200 when a resource is present and deleted, and 404 if the resource is not present to begin with.
Currently, there are three remaining API calls that behave the original way (200 regardless as long as the operation was successful, and the resource being DELETEd is not present in system state after operation completes).  they are:
# curl -X DELETE -u admin:foobar http://localhost:8228/v1/registries/blah
true
# curl -X DELETE -u admin:foobar http://localhost:8228/v1/images/blah
true
# curl -X DELETE -u admin:foobar http://localhost:8228/v1/subscriptions/blah
true

I suggest that this update (use the newer, consistent '20X if resource exists and has been deleted, 404 if resource doesn't exist) be made the next minor (rather than subminor) release, as it is an API change that could effect current integrations.


Error parsing email: TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array

I'm trying to use amadeus-ts to call the Amadeus API for the first time with this code:
const amadeus = new Amadeus({
    clientId: amadeusApiKey.value(),
    clientSecret: amadeusApiSecret.value(),
  });
  try {
    const response = await amadeus.travel.tripParser.post({
      payload: emailData,
      metadata: {
        encoding: "BASE_64",
      },
    });
    logger.debug(`Amadeus response: ${JSON.stringify(response)}`);
  } catch (e) {
    if (e instanceof ResponseError) {
      logger.error(`Amadeus error: ${e.code}`, e);
    } else {
      logger.error(`Error parsing email: ${e}`, e);
    }
  }

And I double checked that emailData is a base-64 encoded email body.
But then I get the following error that seems to come from inside this library:
Error parsing email: TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of Object TypeError: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of Object
    at new NodeError (node:internal/errors:405:5)
    at write_ (node:_http_outgoing:875:11)
    at ClientRequest.write (node:_http_outgoing:834:15)
    at Client.execute (/workspace/node_modules/amadeus-ts/dist/index.js:822:18)
    at Client.unauthenticatedRequest (/workspace/node_modules/amadeus-ts/dist/index.js:807:10)
    at Client.<anonymous> (/workspace/node_modules/amadeus-ts/dist/index.js:783:19)
    at Generator.next (<anonymous>)
    at fulfilled (/workspace/node_modules/amadeus-ts/dist/index.js:33:24)
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Am I doing something wrong?

Hi @sarbogast, thank you for reporting this issue. I have identified and fixed the problem, so you can download version 4.0.2 today when I release it shortly, and everything should be working fine.
The issue was in the library as you correctly assumed. Because the amadeus-ts library aims to eliminate the need for users to manually use JSON.stringify before passing the request body to some of the endpoints.
Example
in amadeus library you would have to pass your request as follows:
amadeus.travel.tripParser.post(JSON.stringify(body));

in amadeus-ts library:
amadeus.travel.tripParser.post(body);

But apparently I forgot to implement this feature to this specific endpoint when I was rewriting the codebase.
Thank you again for reporting this issue.

Wow, that was fast. Thanks a lot.


 There is a connection to my local MQTT broker (on my NAS as well as the iobroker instance) and using the adapter "MQTT" I can even see some message. But not with this adapter!
For example my bridge sends a tele status:
tele/sonoff/STATE = {"Time":"2018-06-19T11:32:24","Uptime":"4T18:19:15","Vcc":3.143,"Wifi":{"AP":1,"SSId ......
which I can see from the Tasmota Web Interface console
Do I need to manually setup something? I would have assumed that mqtt topics like tele/sonoff should appear automatically?
The log shows a lot of errors:

sonoff.0
2018-06-19 11:43:02.359
error
at process._tickCallback (node.js:428:17)

sonoff.0
2018-06-19 11:43:02.359
error
at nextTickCallbackWith3Args (node.js:522:9)

sonoff.0
2018-06-19 11:43:02.359
error
at net.js:1398:9

sonoff.0
2018-06-19 11:43:02.359
error
at listen (net.js:1289:10)

sonoff.0
2018-06-19 11:43:02.359
error
at Server._listen2 (net.js:1253:14)

sonoff.0
2018-06-19 11:43:02.359
error
at exports._exceptionWithHostPort (util.js:930:20)

sonoff.0
2018-06-19 11:43:02.359
error
at Object.exports._errnoException (util.js:907:11)

sonoff.0
2018-06-19 11:43:02.359
error
Error: listen EADDRINUSE <IP_ADDRESS>:1883

sonoff.0
2018-06-19 11:43:02.353
error
uncaught exception: listen EADDRINUSE <IP_ADDRESS>:1883

Problem solved. I was not aware that this adapter is also a MQTT broker, not only a client. It conflicted with my existing broker on the same host. After removing the adapter works as expected.
It would be nice idea to mention this in the readme.md? Would have saved me hours of troubleshooting. Thanks!


docker: ensures conf/var folders exist and copy files directly without stat

For docker deployments, this ensures that the /etc/ceph and /var/lib/ceph folders exist on the host. Also this copies directly without having to stat them first (if a file doesn't exist an error is thrown).
Fixes #725

@ivotron up :)

Correct me if I'm wrong, but dirs_permissions.yml already ensures all these directories exist and have the correct perms.  My solution was just to move fetch_configs.yml after dirs_permissions.yml in */docker/main.yml.  I'd think this is a simpler solution?  (And I can add a PR if desired; it's part of a WIP, but can stand alone)

And I have an existing PR that does just what Daniel is saying.  It has
been waiting to be merged.
On Thu, Apr 28, 2016 at 9:51 AM, Daniel Gryniewicz<EMAIL_ADDRESS>
wrote:

Correct me if I'm wrong, but dirs_permissions.yml already ensures all
these directories exist and have the correct perms. My solution was just to
move fetch_configs.yml after dirs_permissions.yml in */docker/main.yml. I'd
think this is a simpler solution? (And I can add a PR if desired; it's part
of a WIP, but can stand alone)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/ceph/ceph-ansible/pull/726#issuecomment-215492057

--
Jim Curtis
Principal Software Engineer
Emerging Technologies
Red Hat Inc.
<EMAIL_ADDRESS>

That's correct, @jimcurtis just merged your patch.
@ivotron can you make sure that #733 solves your issue? It should, so when you're good please close this PR.

It does. Thanks!


Reference Bug in NodeStatusMaxImagesExceeded

To provide the user more context, a reference to the related bug is added to the runbook.

@machadovilaca commented on this pull request.
I think the issue has a lot of discussion investigating the problem, and not much more info about the impact nor how to solve it than the runbook.
But maybe we can add a new section at the end, like references, and link it.

@machadovilaca  I updated according your suggestion.

I like it, let's just get
/cc @apinnick
review

/lgtm
sorry for the back and forth

Adding to d/s docs - https://github.com/openshift/openshift-docs/pull/56984


[Bug]: Text gets clipped

Summary Description
Today after I've entered a long text (36chars) I've noticed that the last character did not print.
Looking at the preview/simulate, it was missing that character also.
It seems that with different kinds of fonts, the right gets clipped (independent of long strings I've noticed) a little bit. (not complete characters but part of them)
In my case the last letter was an i which got clipped completely.
(Franklin Gothic Medium, Arial Black are examples of where clipping occurs)
Additional Details
No response
Crash logs
No response
MeerK40t Version
v0.9.4 B2-2
MeerK40t Type
Executable
Your Operating System
Windows

Hmm, bummer,
now I've noticed that the top of a text can get clipped too..

Acknowledged, this is an issue. Unfortunately it seems to be a hard nut to crack... I recommend you use vector text until we figured it out

Behind the scene the measuring of the size of the text within the gui toolkit sucks. It was so bad we ended up drawing on an image behind the scenes and then measuring the size of that image. This is because the behind the scenes render of the text is insufficient to cover the entire area and thus can't manage to figure out the right size for the would-be result.

We have an experimental fix, ie rewrite of the text drawing algorithm in place, that no longer clips the text - PR #2411
This needs to undergo thorough testing and code reviews before it can become part of the main codebase

When editing/typing text and (accidentaly) deleting all characters, the application crashes.

I hope I don't annoy too much ;-) but I've found a font, eager to give you a migraine regarding boundary calculation...
It should say pity..
GoogleFonts/AlexBrush-Regular

You recognize this is an 'awful' font, as it breaks all given character boundaries and makes any calculations about textsize more or less useless. Still a fix is in place...

It doesn't bother me at all, but in the properties window of the text, the preview is still clipped...

It doesn't bother me at all, but in the properties window of the text, the preview is still clipped...

I circumvented this, but this due to the poorly designed font with inappropriate kerning information.

Could I persuade you to make the line_gap variable into a user changeable setting?

Done

It doesn't bother me at all, but in the properties window of the text, the preview is still clipped...

I circumvented this, but this due to the poorly designed font with inappropriate kerning information.

Could you have a look again please? The preview now only shows the last line of text when multiline usage.
Anyway.. great how fast you respond man! Kudo's! Very nice indeed!

The preview area will not resize - so it will for bigger / multilined inputs provide a partial view only. The best preview is actually on the scene.... :-)

Nonsense - it's a bug, sorry ...

One would not disagree ;-)

What is the policy regarding merging this branch into main?
Thanks

oh ok!.. I have a private local branch with this and main merged. I am/was just interested in the policy.. I know now.. and in my case I use inkscape separate from mk.. so no probs for me ;-)
Thanks again

Policy wise, if you have a branch you'd like merged you open a PR. We'll review it and explain if there's any issues.